DRAFT: #41 create a basic ADSL for peds test subjects

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

[ ] Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
[ ] Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
[ ] Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
[ ] If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
[ ] Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
[ ] Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
[ ] Address any updates needed for vignettes and/or templates
[ ] Update NEWS.md under the header # admiralpeds (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
[ ] Build admiralpeds site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the Reference page.
[ ] Address or fix all lintr warnings and errors - lintr::lint_package()
[ ] Run R CMD check locally and address all errors and warnings - devtools::check()
[ ] Link the issue in the Development Section on the right hand side.
[ ] Address all merge conflicts and resolve appropriately
[ ] Pat yourself on the back for a job well done! Much love to your accomplishment!

Need to add the actual adsl_peds.rda dataset to this PR (and update the man/ file) but will only run that once we have https://github.com/pharmaverse/admiralpeds/pull/39 completed so that using the stable input datasets from there.


MM-18943 migrate about_build_modal to typescript

Summary
Converts about_build_modal component to TypeScript React class component.
Ticket Link
https://mattermost.atlassian.net/browse/MM-18944

Thanks @cmygray for the pull request!
Per the CONTRIBUTING.md file displayed when you created this pull request, we need to add you to the list of approved contributors for the Mattermost project.
Please help complete the Mattermost contribution license agreement?
This is a standard procedure for many open source projects. Your form should be processed within 24 hours and reviewers for your pull request will be able to proceed.
Please let us know if you have any questions.
We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

completed CLA

/check-cla

Hey @cmygray, it looks like there are some conflicts on your branch, as well as some lint and type-check errors.
Would you be able to resolve those before I take a look? Thanks!

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei

Hey @cmygray, let us know if we can help with resolving the conflicts on your branch, and the lint and type-check errors mentioned by @devinbinnie above. Happy to help. Thanks for your contribution!

This PR has been inactive for quite some quite. I'm going to close it. @cmygray Let me know, if you want to continue working on this PR.


List of PHIPO_EXT terms used in annotations

Hi @jseager7 please could you provide me with a list of the PHIPO_EXT terms in annotations. Thanks.
I would like to obsolete several exploratory terms

@CuzickA Here's all the PHIPO_EXT terms that have been used in curation sessions, current as of 18 May:

Term ID
Name

PHIPO_EXT:0000012
compatible interaction, recognizable pathogen effector present, functional host resistance gene absent

PHIPO_EXT:0000013
compatible interaction, recognizable pathogen effector absent, functional host resistance gene present

PHIPO_EXT:0000014
compatible interaction, recognizable pathogen effector present, compromised host resistance gene

PHIPO_EXT:0000018
incompatible interaction, recognizable pathogen effector present, functional host resistance gene present

PHIPO_EXT:0000019
incompatible interaction, recognizable pathogen effector present, gain of functional host resistance gene

PHIPO_EXT:0000020
incompatible interaction, recognizable pathogen effector present, compromised host resistance gene

PHIPO_EXT:0000030
incompatible interaction, recognizable pathogen necrotrophic effector present, host susceptibility locus compromised

PHIPO_EXT:0000031
compatible interaction, recognizable pathogen necrotrophic effector present, functional host susceptibility locus present

PHIPO_EXT:0000032
incompatible interaction, recognizable pathogen necrotrophic effector present, host susceptibility locus absent

PHIPO_EXT:0000033
compatible interaction, recognizable pathogen necrotrophic effector present, gain of host susceptibility locus

PHIPO_EXT:0000034
incompatible interaction, recognizable pathogen necrotrophic effector absent, host susceptibility locus present

PHIPO_EXT:0000035
compatible interaction, gain of recognizable pathogen necrotrophic effector, host susceptibility locus present

PHIPO_EXT:0000036
incompatible interaction, gain of recognizable pathogen necrotrophic effector, host susceptibility locus compromised

PHIPO_EXT:0000038
compatible interaction, compromised recognizable pathogen necrotrophic effector, host susceptibility locus present

PHIPO_EXT:0000041
incompatible interaction, compromised recognizable pathogen necrotrophic effector, host susceptibility locus present

PHIPO_EXT:0000042
incompatible interaction, gain of recognizable pathogen effector, functional host resistance gene present

PHIPO_EXT:0000044
compatible interaction, recognizable pathogen effector absent, functional host resistance gene compromised

PHIPO_EXT:0000045
compatible interaction, compromised recognizable pathogen effector, functional host resistance gene present

PHIPO_EXT:0000046
metagenotype outcome overcome by external condition

@jseager7 please confirm which session this term was used in?
PHIPO_EXT:0000020 | incompatible interaction, recognizable pathogen effector present, compromised host resistance gene
I deleted it from https://github.com/PHI-base/curation/issues/19 this morning so perhaps it is only used in a test session?
Note to self: make all other GfG compound terms in PHIPO_EXT obsolete using PHIPO_EXT term creator spreadsheet (if I've not already done so).
Next: check inverse GfG PHIPO_EXT terms

@CuzickA According to the export, PHIPO_EXT:0000020 is used only once, in PMID:20601497. However, I can't find it in that session, so I can only assume it's already been replaced since the export was last made.

@CuzickA According to the export, PHIPO_EXT:0000020 is used only once, in PMID:20601497. However, I can't find it in that session, so I can only assume it's already been replaced since the export was last made.

Thanks

@jseager7 I have checked and obsoleted the old PHIPO_EXT terms for the GfG AE set. Please could you load these changes so that I can check that only the required terms are available in PHI-Canto. Thanks.
I'll work on the inverse GfG terms next.


Division by zero in minmea_tocoord

Hello.
I found a divide by zero bug in minmea.
Please confirm.
Thanks.
OS: CentOS 7 64bit
Version: commit cd27e72970cd50b46e9c95c1c0076a49c1ceaf33
PoC Download:  FPE_minmea_tocoord.zip
ASAN:DEADLYSIGNAL
=================================================================
==15762==ERROR: AddressSanitizer: FPE on unknown address 0x000000513aa4 (pc 0x000000513aa4 bp 0x7ffefb6e80b0 sp 0x7ffefb6e80b0 T0)
    #0 0x513aa3 in minmea_tocoord /home/karas/minmea/minmea.h:250
    #1 0x513c60 in main /home/karas/minmea/example.c:35
    #2 0x7f92b2580c04 in __libc_start_main (/lib64/libc.so.6+0x21c04)
    #3 0x41ab5b in _start (/home/karas/minmea/example+0x41ab5b)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: FPE /home/karas/minmea/minmea.h:250 in minmea_tocoord
==15762==ABORTING

=================
[Acknowledgement]
This work was supported by ICT R&D program of MSIP/IITP. [R7518-16-1001, Innovation hub for high Performance Computing]

Seems unlikely. What does your /home/karas/minmea/minmea.h file look like around line 250? It should be:

static inline float minmea_tocoord(struct minmea_float *f)
{
if (f->scale == 0)
return NAN;
int_least32_t degrees = f->value / (f->scale * 100);
int_least32_t minutes = f->value % (f->scale * 100);
return (float) degrees + (float) minutes / (60 * f->scale);
}

which includes a divide by zero check. Would be an interesting test for a fuzzer to see if it can still cause an FPE even with the divide by zero check.
Heath

On 20 Feb 2018, at 10:32 am, gy741<EMAIL_ADDRESS>wrote:
Hello.
I found a divide by zero bug in minmea.
Please confirm.
Thanks.
OS: CentOS 7 64bit
Version: commit cd27e72 https://github.com/kosma/minmea/commit/cd27e72970cd50b46e9c95c1c0076a49c1ceaf33
PoC Download: FPE_minmea_tocoord.zip https://github.com/kosma/minmea/files/1738501/FPE_minmea_tocoord.zip
ASAN:DEADLYSIGNAL
==15762==ERROR: AddressSanitizer: FPE on unknown address 0x000000513aa4 (pc 0x000000513aa4 bp 0x7ffefb6e80b0 sp 0x7ffefb6e80b0 T0)
#0 0x513aa3 in minmea_tocoord /home/karas/minmea/minmea.h:250
#1 0x513c60 in main /home/karas/minmea/example.c:35
#2 0x7f92b2580c04 in __libc_start_main (/lib64/libc.so.6+0x21c04)
#3 0x41ab5b in _start (/home/karas/minmea/example+0x41ab5b)
AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: FPE /home/karas/minmea/minmea.h:250 in minmea_tocoord
==15762==ABORTING
[Acknowledgement]
This work was supported by ICT R&D program of MSIP/IITP. [R7518-16-1001, Innovation hub for high Performance Computing]
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/kosma/minmea/issues/30, or mute the thread https://github.com/notifications/unsubscribe-auth/AFRsb59BZtdyOfbzhDpiOn5ou-_WzhRFks5tWgSPgaJpZM4SLOgY.

Hello,
I have not changed the minmea.h file.
So the contents of the file are the same.
I did some analysis.
In my opinion, if the scale value negative, can pass the condition.
Thanks.
static inline float minmea_tocoord(struct minmea_float *f)
{
    if (f->scale == 0)
        return NAN;
    int_least32_t degrees = f->value / (f->scale * 100);
    int_least32_t minutes = f->value % (f->scale * 100);
    return (float) degrees + (float) minutes / (60 * f->scale);
}

GDB Log
Program received signal SIGFPE, Arithmetic exception.
0x00000000004009f8 in minmea_tocoord (f=0x7fffffffe2b4) at minmea.h:250
250         int_least32_t degrees = f->value / (f->scale * 100);
(gdb) p f->scale
$29 = -2147483648
(gdb) p  f->value / (f->scale * 100)
Division by zero
(gdb) p f->value
$20 = 0
(gdb) p f->scale * 100
$21 = 0

#0  0x00000000004009f8 in minmea_tocoord (f=0x7fffffffe2b4) at minmea.h:250
        degrees = 32767
        minutes = -7484
#1  0x0000000000400bb5 in main () at example.c:35
        frame = {time = {hours = -1, minutes = -1, seconds = -1, microseconds = -1}, valid = false, latitude = {value = 0, scale = -2147483648}, longitude = {value = 0, scale = 0}, speed = {value = 111,
            scale = 1000}, course = {value = 4, scale = 1}, date = {day = -1, month = -1, year = -1}, variation = {value = 0, scale = 0}}
        line = "$OSRMCGPNIT,,,.", '0' <repeats 21 times>, '1' <repeats 14 times>, ",,,,.111,4,,,,.11,,,.111,4,,,"

Ah yes, f->scale is an integer. So overflow behaviour of f->scale * 100 is undefined (even if f->scale is positive). So yes, I agree, it looks like a bug.
I’m sure a pull request would be welcomed!
Heath

On 20 Feb 2018, at 1:49 pm, gy741<EMAIL_ADDRESS>wrote:
Hello,
I have not changed the minmea.h file.
So the contents of the file are the same.
I did some analysis.
In my opinion, if the scale value negative, can pass the condition.
Thanks.
static inline float minmea_tocoord(struct minmea_float *f)
{
if (f->scale == 0)
return NAN;
int_least32_t degrees = f->value / (f->scale * 100);
int_least32_t minutes = f->value % (f->scale * 100);
return (float) degrees + (float) minutes / (60 * f->scale);
}
GDB Log
Program received signal SIGFPE, Arithmetic exception.
0x00000000004009f8 in minmea_tocoord (f=0x7fffffffe2b4) at minmea.h:250
250         int_least32_t degrees = f->value / (f->scale * 100);
(gdb) p f->scale
$29 = -2147483648
(gdb) p  f->value / (f->scale * 100)
Division by zero
(gdb) p f->value
$20 = 0
(gdb) p f->scale * 100
$21 = 0
#0  0x00000000004009f8 in minmea_tocoord (f=0x7fffffffe2b4) at minmea.h:250
degrees = 32767
minutes = -7484
#1  0x0000000000400bb5 in main () at example.c:35
frame = {time = {hours = -1, minutes = -1, seconds = -1, microseconds = -1}, valid = false, latitude = {value = 0, scale = -2147483648}, longitude = {value = 0, scale = 0}, speed = {value = 111,
scale = 1000}, course = {value = 4, scale = 1}, date = {day = -1, month = -1, year = -1}, variation = {value = 0, scale = 0}}
line = "$OSRMCGPNIT,,,.", '0' <repeats 21 times>, '1' <repeats 14 times>, ",,,,.111,4,,,,.11,,,.111,4,,,"
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/kosma/minmea/issues/30#issuecomment-366852427, or mute the thread https://github.com/notifications/unsubscribe-auth/AFRsb_XJ87p3dCCwoKjcuL6wCcXRbyOcks5tWjKdgaJpZM4SLOgY.

@hraftery
Hello,
I have sent a pull request.
Please let me know if there is a better patch method.
Pull : #31
Thanks.

@hraftery
Hello,
I modified the source code again.
What do you think of this source?
Thanks.
static inline float minmea_tocoord(struct minmea_float *f)
{
    if (f->scale == 0)
        return NAN;
+     if (f->scale  > (INT_LEAST32_MAX / 100))
+ 		return NAN;
+     if (f->scale < (INT_LEAST32_MIN / 100))
+ 		return NAN;
      int_least32_t degrees = f->value / (f->scale * 100);
      int_least32_t minutes = f->value % (f->scale * 100);
      return (float) degrees + (float) minutes / (60 * f->scale);
  }

Looks pretty good. I guess it’s now up to kosma to pull it!

On 22 Feb 2018, at 12:52 pm, gy741<EMAIL_ADDRESS>wrote:
@hraftery https://github.com/hraftery
Hello,
I modified the source code again.
What do you think of this source?
Thanks.
static inline float minmea_tocoord(struct minmea_float *f)
{
if (f->scale == 0)
return NAN;

if (f->scale  > (INT_LEAST32_MAX / 100))

	return NAN;

if (f->scale < (INT_LEAST32_MIN / 100))

	return NAN;
int_least32_t degrees = f->value / (f->scale * 100);
int_least32_t minutes = f->value % (f->scale * 100);
return (float) degrees + (float) minutes / (60 * f->scale);

}
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/kosma/minmea/issues/30#issuecomment-367540783, or mute the thread https://github.com/notifications/unsubscribe-auth/AFRsb6FQ25HCw6OvTFfqEFmKeJInPKjZks5tXMhSgaJpZM4SLOgY.

Hello,
thank you for confirmation.
I have sent a pull request.
Pull : #32
Thanks.

That's a good catch! I need to have another look at the code to see if there's some way to avoid the extra if-check by changing math. I should resolve this in a few days.

@kosma I'm guessing you've dropped the ball on this one?

Should minmea_float.scale be an unsigned value?

Sorry for the delay, merged the PR. @matonga can you reopen if there is still an issue and/or feel free to open a PR to resolve?


Assembly version of AndUnsafeInplace?

I need a faster AND(x, y []byte function (stackoverflow post, and benchmark repo) and just find you provide one.
func AndUnsafeInplace(main, arg []byte) {}

It's so fast by converting every 8 bytes to uint64,
I'm wondering if it could be faster to use golang assembly code utilizing SIMD instructions.
I just begin to learn assembly language, hope I can help one day.

I wrote one https://github.com/shenwei356/bench/tree/main/bitwise-and-on-byte-slices
It works, and permance is OK.


RAU-109 upgrade attribute_normalizer to rails4

RAU-109

@toppa thank you so much for your review, I have addressed the comment.


Consume extend blocks

Consumes extend blocks so they don't throw errors, left a TODO to actually add them to the descriptor.

LG after that, gave you access to the repo.


fix(snap): allow disabling of secret-store via config hook

This fix adds a new snap configure option 'security-secret-store'
that controls how secrets are stored. By default if a profile's
configuration file requires secrets, secret-store will be used.
If 'security-secret-store' is set to 'false', then insecure
secrets will be used instead. This aligns the snap with the same
capabilty available in the main edgexfoundry snap and the standard
docker-compose files.
Fixes: 150
Signed-off-by: Tony Espy<EMAIL_ADDRESS>PR Checklist
Please check if your PR fulfills the following requirements:

[NA] Tests for the changes have been added (for bug fixes / features)
[NA] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 150
What is the new behavior?
Secret store usage can now be disabled via a snap config option.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Are there any new imports or modules? If so, what are they used for and why?
NA
Are there any specific instructions or things that should be known prior to reviewing?
See issue
Test Instructions
Install the edgexfoundy snap from latest/stable:
$ sudo snap install edgexfoundry
Build edgex-app-service-configurable from this branch:
$ sudo snap install snapcraft --classic
$ snapcraft --use-lxd
$ sudo snap install edgex-app-service-configurable*amd64.snap --dangerous

Set the profile to mqtt-export (which uses secrets by default):
$ sudo snap set edgex-app-service-configurable profile=mqtt-export
In a separate terminal start journalctl to follow system log messages:
$ sudo journalctl -f -o cat
Start edgex-app-service-configurable and see that it fails to start.
$ sudo snap start --enable edgex-app-service-configurable.app-service-configurable
Stop it, set security-secret-store=off, and start it. This time it should come up with no errors logged.
$ sudo snap stop edgex-app-service-configurable.app-service-configurable
$ sudo snap set edgex-app-service-configurable security-secret-store=off
$ sudo snap start --enable edgex-app-service-configurable.app-service-configurable

Verify that it up using snap services:
$ snap services edgex-app-service-configurable.app-service-configurable
Service                                                  Startup   Current  Notes
edgex-app-service-configurable.app-service-configurable  enabled  active   -

Testing the changes works as expected, so I've added test instructions to the PR description and removed the draft status.

Looks good to me. I tried the test instructions above and only comment there is that
sudo snap install edgex-app-service-configurableamd64.snap
needs to be
sudo snap install --dangerous edgex-app-service-configurableamd64.snap
Other than that see inline comments. I tried testing with a certificate as well as per the README but for TLS handshake errors. Didn't investigate that further so could just be my setup

I just force-pushed an update addressing most of the comments concerning snap/README.md.
@siggiskulason re: your test results, I'm trying to reproduce now to verify my test instructions.

@siggiskulason OK, I think I've addressed all of your comments in snap/README.md, and I also re-tested the manual steps to enable vault support (ie. the last section of the README which provides instructions to copy ca.pem and secrets-token.json) and verified that they now work.
Please re-review at your convenience.


Error when text contains single quotes (apostrophe)

As the title says, the generated toast notification fails to render correctly if text contains any single quote (which are pretty common in French language) -> similar problem as outlined in #22, could close this one in favor of the former.
Would it be a big problem switching to double quotes for string delimiter?
JavaScript handles it perfectly when text within double quotes contains single quotes.
Thanks in advance!

The current version seems to have no issues with single quotes. Which version are you on?

Right, I stayed behind on purpose when the possibility to customize the notification title easily for each notification was removed (for integrating other toast notifications library I think)
I will update to the latest version and try to figure out a way to customize titles.

5.0.7 has the Title property in ToastrOptions class which you can set to give title to toastr toast messages.

Nice, I'll check it out! Was it implemented in a similarly extensible way as you proposed in issue 32? (I will take a look at the code in a couple minutes so don't feel forced to answer that one hehe).
I'll close as it is supported/not an issue in latest version.

Feel free to reopen the issue if it's not resolved.

I'm going through some tutorials on ASP.NET using .NET Core 3.1, and I just spent a frustrating half-hour tearing my hair out trying to understand why my toast notification didn't work.
A single quote bug??  Seriously??  How did they miss this?!?!
  I swear, I should be a tester for literally everyone XD.


To install the extension locally via git clone

Hello!
Building it locally does not help. I would like to install it locally via git clone for not breaking the symlinks in other workspaces if I keep updating the extension. Updating the extension will change the folder version, resulting in broken symlinks in other worksapces.

I'm not sure if I understand this correctly. You want to build it locally? What do you mean by "building"? Install the extension or create a .vsix file?
When you install an extension it is installed into e.g. /Users/USER/.vscode/extensions/ on mac. You want to symlink the folders inside there? Maybe you could give some more context?

This is probably a problem with how vs code handles extension version. Not much I can do about.


handler which adds eventid always at root level, not within a WithGroup

I am banging my head in this seemingly easy and as I think not unreasonable issue.

I would like to create a new slog handler which adds a field eventID with an outomatically added UUID
Achieved, writing custom handler type an custom Handler which adds a new field. Alternatively some trickery with ReplaceAttr also get's me there, Handler is cleaner though.

I would like to add further logging attributes into a group "custom", therefore I call myslogderivedlogger.WithGroup("custom").
Here it get's funny though, as the field eventid is now added as custom.eventID instead at the "root" level, at the root level there is no more eventId

Would your slog middleware help me in getting there?

did you write
myslogderivedlogger.WithGroup("custom")

or
myslogderivedlogger = myslogderivedlogger.WithGroup("custom")

?

Samuel Berthe @.***> schrieb am Sa., 11. Mai 2024,
22:54:

did you write
myslogderivedlogger.WithGroup("custom")
or
myslogderivedlogger = myslogderivedlogger.WithGroup("custom")
I used this second form as according to the doc, the logger is not altered
but a new one created

—
Reply to this email directly, view it on GitHub
https://github.com/samber/slog-multi/issues/5#issuecomment-2106029179,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABHE7URAS7H7R7NNG3MWHTZB2APZAVCNFSM6AAAAAA6N5NVXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBWGAZDSMJXHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Could you please write a short demo of the bug?
i did it many times, without any issue


Add JS style guide to the Contributing guide

This PR adds a section for JavaScript style to the Contributing guide, based on feedback from https://github.com/atom/about/pull/35.
👀 @atom/feedback @nathansobo

Thanks @mnquintana. Good to get this started. Luckily most of it is in standard style.

@nathansobo So I was just thinking – one advantage of the object spread syntax {…someOtherObj} over Object.assign() is that it’s much more foolproof. Take, for example:
let state = {
  thing: true
}

let newState = Object.assign(state, {
  thing: false
})

state.thing !== newState.thing // returns false

If you forget to provide a new object as the first argument, then Object.assign() will both return
this new merged object and mutate the first object passed to it, which is almost never what we want to do.
On the other hand, this will always return a new object so we don't have to worry about unintended
mutations:
let state = {
  thing: true
}

let newState = {
  ...state,
  thing: false
}

state.thing !== newState.thing // returns true

What do you think?

I personally greatly prefer object spread, and since it's used heavily in JSX/Etch, I'd personally recommend it for consistency as well. Just my 2¢ :)

It's also much less verbose when doing deeply nested things:
{
  ...state,
  subobj: {
    ...state.subobj,
    key: "val"
  }
}

Cool, let's use it then.


Add solana-program-test compatibility test in CI

Problem
The expected entrypoint lifetimes in solana-program-test is not compatible with the 0.29.0 release due to the changes in https://github.com/coral-xyz/anchor/pull/2656 but we have no tests for this case in CI.
Solution
Add a simple test to check the compatibility between anchor-lang and solana-program-test.
Related: https://github.com/coral-xyz/anchor/pull/2711

Hey! I'm interested in working on this issue and have explored an approach for compatibility testing in this draft PR: https://github.com/coral-xyz/anchor/pull/2841.

Hey! Is there any solution? I bumped into this one type is more general than the other problem too.

@denisglotov this is a wrapper I'm using which seems to suppress the warnings. The program I'm testing is called kickjump_launchpad.
use kickjump_launchpad::ID_CONST;
use solana_program::account_info::AccountInfo;
use solana_program::entrypoint::ProgramResult;
use solana_program::pubkey::Pubkey;
use solana_program_test::processor;
use solana_program_test::ProgramTest;

pub fn add_program() -> ProgramTest {
	ProgramTest::new("kickjump_launchpad", ID_CONST, processor!(entry))
}

/// This is a wrapper to get the processor macro to work.
fn entry(program_id: &Pubkey, accounts: &[AccountInfo], instruction_data: &[u8]) -> ProgramResult {
	let accounts = Box::leak(Box::new(accounts.to_vec()));

	kickjump_launchpad::entry(program_id, accounts, instruction_data)
}

I've added the following workaround to my own codebase for testing. Would it be useful to others?
If so, I can create a pull request.
/// The current processor for [`solana_program_test`] doesn't support anchor
/// programs due to lifetime conflicts. This is a wrapper that supports the
/// anchor lifetimes by using [`Box::leak`] on the accounts array.
#[macro_export]
macro_rules! anchor_processor {
	($program:ident) => {{
		fn entry(
			program_id: &::solana_program::pubkey::Pubkey,
			accounts: &[::solana_program::account_info::AccountInfo],
			instruction_data: &[u8],
		) -> ::solana_program::entrypoint::ProgramResult {
			let accounts = Box::leak(Box::new(accounts.to_vec()));

			$program::entry(program_id, accounts, instruction_data)
		}

		::solana_program_test::processor!(entry)
	}};
}


[BUG] 官網範例 crontab 執行錯誤

Execute the command and paste the result below.
Command: uname -a && php -v && composer info | grep hyperf && php --ri swoole
Linux a8bc68da12d7 5.15.49-linuxkit #1 SMP PREEMPT Tue Sep 13 07:51:32 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux
PHP 8.1.10 (cli) (built: Sep 18 2022 10:25:43) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.10, Copyright (c) Zend Technologies
    with Zend OPcache v8.1.10, Copyright (c), by Zend Technologies
96qbhy/hyperf-auth                 v3.0.1        hyperf 的 auth 组件
gokure/hyperf-cors                 v2.0.0        Adds CORS (Cross-Origin Resource Sharing) headers support in your Hyperf application.
hyperf/async-queue                 v3.0.9        A async queue component for hyperf.
hyperf/cache                       v3.0.0        A cache component for hyperf.
hyperf/code-generator              v0.3.3        Code Generator for Hyperf
hyperf/command                     v3.0.9        Command for hyperf
hyperf/config                      v3.0.0        An independent component that provides configuration container.
hyperf/constants                   v3.0.11       A constants component for hyperf.
hyperf/context                     v3.0.0        A coroutine context library.
hyperf/contract                    v3.0.10       The contracts of Hyperf.
hyperf/coordinator                 v3.0.13       Hyperf Coordinator
hyperf/crontab                     v3.0.13       A crontab component for Hyperf.
hyperf/database                    v3.0.13       A flexible database library.
hyperf/db-connection               v3.0.10       A hyperf db connection handler for hyperf/database.
hyperf/devtool                     v3.0.8        A Devtool for Hyperf.
hyperf/di                          v3.0.12       A DI for Hyperf.
hyperf/dispatcher                  v3.0.0        A HTTP Server for Hyperf.
hyperf/engine                      v2.7.0        Coroutine engine provided by swoole.
hyperf/engine-contract             v1.7.0        Contract for Coroutine Engine
hyperf/event                       v3.0.0        an event manager that implements PSR-14.
hyperf/exception-handler           v3.0.0        Exception handler for hyperf
hyperf/framework                   v3.0.0        A coroutine framework that focuses on hyperspeed and flexible, specifically use for build microservices and middlewares.
hyperf/guzzle                      v3.0.10       Swoole coroutine handler for guzzle
hyperf/http-message                v3.0.11       microservice framework base on swoole
hyperf/http-server                 v3.0.10       A HTTP Server for Hyperf.
hyperf/ide-helper                  v3.0.0        IDE help files for Hyperf.
hyperf/logger                      v3.0.0        A logger component for hyperf.
hyperf/macroable                   v3.0.0        Hyperf Macroable package which come from illuminate/macroable
hyperf/memory                      v3.0.0        An independent component that use to operate and manage memory.
hyperf/model-cache                 v3.0.3        A model cache component for hyperf.
hyperf/model-listener              v3.0.0        A model listener for Hyperf.
hyperf/paginator                   v3.0.7        A paginator component for hyperf.
hyperf/pool                        v3.0.0        An independent universal connection pool component.
hyperf/process                     v3.0.9        A process component for hyperf.
hyperf/redis                       v3.0.5        A redis component for hyperf.
hyperf/server                      v3.0.8        A base server library for Hyperf.
hyperf/session                     v3.0.0        A session library
hyperf/swagger                     v3.0.13       A swagger library for Hyperf.
hyperf/testing                     v3.0.9        Testing for hyperf
hyperf/tracer                      v3.0.0        A open tracing system implemented for Hyperf or other coroutine framework
hyperf/translation                 v3.0.0        An independent translation component, forked by illuminate/translation.
hyperf/utils                       v3.0.11       A tools package that could help developer solved the problem quickly.
hyperf/validation                  v3.0.0        hyperf validation
hyperf/view                        v3.0.0        A view library for Hyperf.
hyperf/view-engine                 v3.0.0

swoole

Swoole => enabled
Author => Swoole Team<EMAIL_ADDRESS>Version => 5.0.2
Built => Mar 15 2023 10:51:22
coroutine => enabled with boost asm context
epoll => enabled
eventfd => enabled
signalfd => enabled
cpu_affinity => enabled
spinlock => enabled
rwlock => enabled
sockets => enabled
openssl => OpenSSL 1.1.1f  31 Mar 2020
dtls => enabled
http2 => enabled
json => enabled
curl-native => enabled
zlib => 1.2.11
mutex_timedlock => enabled
pthread_barrier => enabled
futex => enabled
mysqlnd => enabled
async_redis => enabled

Directive => Local Value => Master Value
swoole.enable_coroutine => On => On
swoole.enable_library => On => On
swoole.enable_preemptive_scheduler => Off => Off
swoole.display_errors => On => On
swoole.use_shortname => Off => Off
swoole.unixsock_buffer_size => 8388608 => 8388608

Description:
複製貼上官網的 crontab 範例，會出現
[ERROR] Exception: Serialization of 'Hyperf\Engine\Channel' is not allowed in /var/www/vendor/hyperf/crontab/src/Strategy/WorkerStrategy.php:38
Stack trace:
#0 /var/www/vendor/hyperf/crontab/src/Strategy/WorkerStrategy.php(38): Swoole\Server->sendMessage()
#1 /var/www/vendor/hyperf/crontab/src/Process/CrontabDispatcherProcess.php(74): Hyperf\Crontab\Strategy\WorkerStrategy->dispatch()
#2 /var/www/vendor/hyperf/process/src/AbstractProcess.php(99): Hyperf\Crontab\Process\CrontabDispatcherProcess->handle()
#3 [internal function]: Hyperf\Process\AbstractProcess->Hyperf\Process{closure}()
#4 {main}
直接 crash
Steps To Reproduce:
按照官網步驟就可以重現了

目前版本v3.0.13有这个错误，先降版本至v3.0.9使用。

https://github.com/hyperf/hyperf/pull/5578


poetry update fails on Python >= 3.9

When running poetry update in a build environment using Python >= 3.9, it fails with an error:
   3  .venv/lib/python3.9/site-packages/poetry_grpc_plugin/plugins.py:27 in run_protoc
        with importlib.resources.path("grpc_tools", "_proto") as include_path:

   2  /usr/local/Cellar/python@3.9/3.9.7/Frameworks/Python.framework/Versions/3.9/lib/python3.9/contextlib.py:119 in __enter__
        return next(self.gen)

   1  /usr/local/Cellar/python@3.9/3.9.7/Frameworks/Python.framework/Versions/3.9/lib/python3.9/importlib/resources.py:175 in _path_from_reader
        opener_reader = reader.open_resource(norm_resource)

  IsADirectoryError

  [Errno 21] Is a directory: '<snip>/.venv/lib/python3.9/site-packages/grpc_tools/_proto'

  at <frozen importlib._bootstrap_external>:1055 in open_resource

It appears that the behaviour of importlib.resources.path has been tightened in 3.9 to work only on files.
I've personally used pkg_resources.resource_filename in Python 3.9 to achieve this exact lookup, so that could be an alternative.
Related links:

<EMAIL_ADDRESS>https://github.com/ktbyers/netmiko/issues/2048
https://github.com/ktbyers/netmiko/pull/2274

Thanks for raising this, I've released 0.1.1 addressing this issue.


[Serialization] Reduce file size by splitting dep dirnames from basenames

Dependency tracking for cached compiled modules (compiled from swiftinterfaces) can lead to a high percentage of the module being SDK-relative paths when -track-system-dependencies is on. Cut down on this by storing directory names in a separate record that gets referenced from each file dependency. (Since a lot of per-file dependencies are header files in a common directory, this is a win.)
We can do something more clever in the future, but this is a reasonable start for, say, the overlays.
rdar://problem/50449802

@swift-ci Please test

@swift-ci Please smoke test

This broke CI on Windows!  https://dev.azure.com/compnerd/windows-swift/_build/results?buildId=2061

*sigh* We really need to get that into "please test".


#1070

This should fix issue #1070
New Unit Test provided and successfully tested within javaplugin.
fixed: https://github.com/devonfw/cobigen/issues/1070

added extra not null check to writeAnnotation iterator
added missing commas to annotation array elements
added new testCorrectSyntaxOutputForArraysCommaPlacement Unit Test to CustomModelWriterTest

Adresses/Fixes #.
Implements

@devonfw/cobigen

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Fix build system to continous delivery

Take model from other missions such as Entrainement or Scorpion

Fixed by commit fce8fd2


"Permission" and "Scope"

I have been confused with the terms "Permission" and "Scope", are they referring to same thing?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 4f777bfa-9c87-a3df-6894-e3f80355ef68
Version Independent ID: 96019b52-9742-7c97-187b-171b3a8924fc
Content: Understanding OneDrive API permission scopes - OneDrive dev center
Content Source: docs/rest-api/concepts/permissions_reference.md
Service: one-drive
GitHub Login: @JeremyKelley
Microsoft Alias: JeremyKe

so in order for me to decide a permission, I should apply it in "scope" field during authorization?


Adding custom suffix to generated types

With DGS codegen, I want the schema types to correspond my Model entity types.
For example let's assume that I have a query in my schema:
type Dog {
name: String!
}

My generated type will be <generated_types_package>.Dog.java
In most cases, I will have another class for my model object. <model_type_package>.Dog.java
What happens in this case that in my DataFetcher I need to declare explicitly on the type package prefix, which makes the code pretty hard to read.
My suggestion is to add a custom suffix to any schema generated type (not input)
<model_type_package>.Dog.java --> <model_type_package>.DogGQL.java

I can see that being hard to use. We can looking into improving that in the future. Feel free to open a PR if you would like to have that available sooner.

@srinivasankavitha Thank you for your response.
I will check out that, Since I am using maven I will need another PR for the maven plugin to support such kind of config.

+1, I'm going to name my entities <Name>Entity but would still like this to avoid potential conflicts and to match that kind of class naming convention

I'm using gradle, just FYI


tikv: add TsFilter for ResetToVersionWorker

Signed-off-by: JmPotato<EMAIL_ADDRESS>What is changed and how it works?
Issue Number: Ref #13276.
What's Changed:

Add `TsFilter` for `ResetToVersionWorker` to filter out the SST that does not have a newer version than the TS to reset in `CF_WRITE`.

Check List
Tests

Unit test
Integration test

Release note
None.

/cc @Connor1996 @longfangsong

/run-build

/hold

Transaction correctness-related comments will be addressed in https://github.com/tikv/tikv/pull/13289.


⚠ Jenkins Plugins Artifactory has degraded performance

In 2c6d696, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 2611 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 0ca9fab after 6 days, 18 hours, 32 minutes.


Add TryFrom<HttpRequest<()>> for Request

http::Request<()> is a common pattern of requests without body in the http library, but it cannot be converted into reqwest::Request. This PR adds such case.

in #2307, I did another implementation, which is much simpler, but might take a bit more memory to store (None vs Some(Bytes::empty())), please check it out and give comment if any
I did my own investigation into this issue before I found this PR, so I'd be happy if either one is merged


[extractor/common] Tweak JSON-LD extraction to support default implicit graph

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[x] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information
JSON-LD extraction improvements

Support top-level @graph expressing implicit default graph

Wrap the control flow block in a function, which is called recursively upon such a structure
Per W3C JSON-LD v1.1 §4.9 (non-normative ref):

When a JSON-LD document's top-level structure is a map that contains no other keys than @graph and optionally @context (properties that are not mapped to an IRI or a keyword are ignored), @graph is  considered to express the otherwise implicit default graph.

Extend TestInfoExtractor.test_search_json_ld_realworld to cover said syntax (structure)

Refactor tests in a list of 3-tuples: test html string, expected dict, keyword args for InfoExtractor._search_json_ld
Add new test case for said syntax (structure)

Tweak description extraction from nodes with type Article or NewsArticle: extract description from articleBody and fall back to description field

This patch was ported from ytdl-org/youtube-dl#30229.

This patch, namely b7359b8, fixes extraction of JSON-LD metadata for Ant1NewsGrArticleIE introduced in #1982; this error is currently handled therein as a non-fatal expected warning.

If I forget to remove pending-fixes, feel free to ping me


Request - juggernautXL

SDXL\juggernautXL_v9Rdphoto2Lightning.safetensors
Thanks!

Added in https://github.com/fofr/cog-comfyui/commit/4f36202d9e4aba02f63a4a611d2caba1bd03a781


Add support for regexp v flag

Fixes #1006.

@microsoft-github-policy-service agree

Any update on this?

:pray: Merging this pull request would fix these issues:

https://github.com/microsoft/TypeScript-TmLanguage/issues/1006
https://github.com/microsoft/TypeScript-TmLanguage/issues/1021
https://github.com/microsoft/TypeScript-TmLanguage/issues/1022
https://github.com/microsoft/vscode/issues/214090

Sorry, but: @sheetalkamat, @mjbvz
I (and probably a few others) would be more than happy if you could open up this repository for more maintainers or explain how the dependency on typescript-tmlanguage can be replaced within VSCode or the TypeScript extension with a not abandoned or at least a more maintained repository.
Thanks!


Add Stripe API module

📦 Published PR as canary version: Canary Versions

:sparkles: Test out this PR locally via:
npm install<EMAIL_ADDRESS># or
yarn add<EMAIL_ADDRESS>

Task linked: FRI-398 Update Stripe to v1

Approved with small nits you can address optionally

I should say, a (to be?) merged in PR changes the directory structure so that this should be added to /packages/v1/

Ah and you probably need to tag this with "release" label


Bogdan/csv schema func

CI

Codecov Report

Merging #10 into master will decrease coverage by 0.10%.
The diff coverage is 47.61%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   58.96%   58.85%   -0.11%
==========================================
  Files         374      404      +30
  Lines       12137    12566     +429
  Branches     2992     3110     +118
==========================================
+ Hits         7156     7396     +240
- Misses       4802     4986     +184
- Partials      179      184       +5

Flag
Coverage Δ

#javascript
58.85% <47.61%> (?)

Impacted Files
Coverage Δ

superset-frontend/src/SqlLab/App.jsx
0.00% <ø> (ø)

superset-frontend/src/SqlLab/actions/sqlLab.js
60.48% <0.00%> (-1.49%)
:arrow_down:

...end/src/SqlLab/components/ExploreResultsButton.jsx
73.75% <ø> (ø)

...et-frontend/src/SqlLab/reducers/getInitialState.js
0.00% <0.00%> (ø)

...perset-frontend/src/addSlice/AddSliceContainer.jsx
72.72% <ø> (ø)

superset-frontend/src/chart/Chart.jsx
10.41% <0.00%> (ø)

superset-frontend/src/chart/chartAction.js
45.03% <0.00%> (+1.16%)
:arrow_up:

superset-frontend/src/chart/chartReducer.js
19.04% <ø> (ø)

superset-frontend/src/components/ErrorBoundary.jsx
18.18% <ø> (ø)

...rset-frontend/src/components/ErrorMessage/types.ts
0.00% <0.00%> (ø)

... and 149 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f49666...aa20845. Read the comment docs.


Add combinator for optional properties

(Note that the implementation does not rely on defaultValue and hence does not rely on any Eq instances.)

Note that if we had the standard StackPrisms for Maybe, then we could just write
optProp :: Json a => Text -> Grammar Obj t (Maybe a :- t)
optProp propName = fromPrism just . prop propName <> fromPrism nothing


update the error mapping based on latest language release

Closed by https://github.com/openfga/language/pull/223


UDim2.fromOffset, UDim2.fromScale

Two new static constructors were added for UDim2 but they're not enabled yet.
This issue is a reminder to add them.
interface UDim2Constructor {
	fromOffset(x: number, y: number): UDim2;
	fromScale(x: number, y: number): UDim2;
}

Both constructors work on production now, I believe. :)


webcord: 4.8.0 -> 4.9.1

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I'd prefer to wait until electron 30 is packaged.

I'd prefer to wait until electron 30 is packaged. See https://github.com/SpacingBat3/WebCord/releases/tag/v4.9.0

fair point, it does build and run with 29 though.
I will just mark this as a draft. if someone sees this and electron 30 is out ping me

#309041 electron 30 is now out

Update script worked

Have you tested it on wayland by any chance? @emilylange noted on https://github.com/NixOS/nixpkgs/pull/309041#issuecomment-2094844146 it might reintroduce #306010.

Opens fine on sway, both with or without NIXOS_OZONE_WL being set.


Added image dump

#68 wanted a image dump command, I made one :)

I think the idea of the image dump is to download the actual files and dump them to a folder.

Just checked ESLint too, it seems to be all fine.


Preprocessing gets stuck with multiprocessing

Hello,
When running the preprocessing using: nndet_prep X -np 3, at some point the preprocessing does not advance anymore and seems stuck. No error messages appear.
Any idea how to treat this issue?
Also is there a way to disable the cropping and the checking of the cropped data?
At every time I relaunch the preprocessing after getting stuck, even though the cropping is not performed every time, the checking of the cases takes a lot time.
Thank you in advance.

Hey,

This sounds like you may run out of memory and the multiprocessing workers crash. Could you verify that this is not the problem?
Yes, you can modify the preprocessing by overwriting values in the prep config, https://github.com/MIC-DKFZ/nnDetection/blob/main/nndet/conf/prep/process.yaml just add -o crop=False (there might be a change that the check will still run)

Best,
Michael

Hello @mibaumgartner,
Thanks for the quick response!
1. I am still investigating the first point
2. That seems to be working thank you!

I would like to ask one more question if you don't mind:
How can I disable the low-resolution preprocessing (I don't need the TaskX/preprocessed/D3V001_3dlr1 folder) when I run nndet_prep X?
Best regards!


[Feature] Implement Adapative Nullable Column

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #16460
Problem Summary(Required) ：

NullableColumn has two columns: data column and null column. Based on the data, we classify null column into four types:
(1) All data is null: data column is all default value, and null column is all 1
(2) All data has default value(not null): data column is all default value, and null column is all 0
(3) All data has different value(not null): data column has different value, and null column is all 0
(4) Some data is null, some data has different value: data column has different value, and null column has 0 and 1
For type (1) (2) (3), we can compress the nullable column, no need to materialize the data and null column.
We can set a flag to indicate that data column is all default value and null column is all 0/1, especially for
type (1) and (2), both data column and null column can be compressed, for type (3), we can only compress null column.
AdaptiveNullableColumn is designed to handle this issue. It has five state:  kUninitialized, kNull, kConstant
kNotConstant and kMaterialized.
(1) kUninitialized:         AdaptiveNullableColumn is in init stat.
(2) kNull:                  AdaptiveNullableColumn is all null. (data column and null column is compressed)
(3) kConstant:              AdaptiveNullableColumn is all default value (not null) (data column and null column is compressed)
(4) kNotConstant:           AdaptiveNullableColumn has different value (not null) (null column is compressed)
(5) kMaterialized:          AdaptiveNullableColumn has null and differnt value
The state transfer is as following:
kUninitialized ------------->  kNull --------------
                   |                              ｜
                   -------->  kConstant -----------
                   |                              ｜
                   -------->  kNotConstant --------
                   |                              ｜
                   ----------------------------------------------------->   kMaterialized
In the beginning, AdaptiveNullableColumn is in kUninitialized stat, then it will transfer to kNull,
kConstant, kNotConstant and kMaterialized after receiving some data. In kMaterialized state,
both data column and null column are materialized and the behaviour is same as nullable column.
AdaptiveNullableColumn can optimize both CPU and memory, for example, if the data is all null,
when append null data to AdaptiveNullableColumn, we only need increase _size in AdaptiveNullableColumn,
no need to append default to data column and 1 to null column.
At the end of AdaptiveNullableColumn, you need to call materialized_nullable() if you want to use the data column and null column.

Test result:

A table with 670 varchar columns, we start a routine load to load 250,0000 records.
Test is on a single machine with 104 core and 187GB memory, one FE and one BE
Before optimization, routine load takes 137s, the speed is around 18000 row/s
After optimization, routine load takes 77s, the speed is around 32000 row/s, improved by 1.7x

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

Is AdaptiveNullable column visible to execution engine(especially for Expr tree, ExecNode, pipeline::Operator) and storage engine? is it converted into other types of columns when it propagates into execution and storage?
kAllNullDefault is just like const null column;
kAllNotNullDefault is like a ConstColumn;
kAllNotNullNotDefault:  like an ordinary column;
kMaterialized: like an NullableColumn.
I'm afraid that AdaptiveNullableColumn introduces many bugs.
An alternative design is that implement different types of columns instead of specifying state inside one type  of column, that is to say, Our type system should adopts algebraic datatypes, so we can dispatch types into different process branches explicitly, via this way bugs will be eliminated or clear, for examples:
ConstNullColumn;
ConstColumn;
NoNullColumn;
NullableColumn.
By the way, the word "materialize" means do the actual computation and abtain required final result, it is some confusing, suggest to change another name.

@satanson
AdaptiveNullable column currently is only visible in JSON Scanner and CSV Scanner. It will be converted into nullable column when it propagates into execution and storage. This can avoid introducing too many bugs.
Currently adaptiveNullable column's functionity is relatively limited, it is only used for accelerating the parsing procedure of json/csv.
As you mentioned, 'an alternative design is that implement different types of columns ', that's a great idea. But i think we need to put more efforts to make that work. In the future, i will propose a RFC to solve this problem more generally based on your review.
And i will think a better name for 'materialize'.

[FE PR Coverage Check]
:heart_eyes: pass : 2 / 2 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
2
2
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 2 / 2 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
2
2
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 2 / 2 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
2
2
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 2 / 2 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
2
2
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 2 / 2 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
2
2
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 2 / 2 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
2
2
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 2 / 2 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
2
2
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 2 / 2 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
2
2
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 2 / 2 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/qe/ShowExecutor.java
2
2
100.00%
[]

run starrocks_admit_test


Support export and comparison of answers

Serializing the answers into a base64 blob would permit optionally adding them to the URL so your friends could take the quiz and see which questions they differed from you on. Not sure what the best UI would be, but the first step would be permitting granular export rather than just the final tally.

Perhaps, having a string with numbers/letters representing the answers to each 70 questions in the correct order would do?
Ie. http://8values.github.io/1033543...

Ya, I can see that being nice and easily-parseable.


Search unused functions

How can I search for unused functions in all project.
For example: store all functions initialization in one variable, and all used functions in another, then compare that two lists

CFLint only scans each file individually. It would be a big change to track function references across files, and sometimes not even possible to do accurately if using dynamic references such as createObject("component", somePathToCFC).foo().

Barring weird scenarios like @KamasamaK mentioned, you could write a plugin that collects a list of all functions and a list of all called functions.    See com.cflint.plugins.core.ArgDefChecker for an example of identifying functions.
What the framework does not currently provide is a callback when all files are finished processing.

I don't think dynamic references are that weird. Even without them, to accurately resolve the component path you would need to know any custom mapping in the server or application configuration and the location of the web root. Assuming the given folder to scan is the web root, it should be easy enough to get the mappings from the application files, but the server mappings would not be available.

Good point!

On a related note, Unused private functions would be relatively easy.  Is that worth implementing?

Private functions would be easier I guess, but be aware that private in CFML is equivalent to protected in Java, so you would still need to check down the inheritance chain so you'd still have to deal with component path resolution.


Multiple slots in +layout.svelte

Describe the problem
Recently, I've had to extract my +layout.svelte page into a separate component that I use in my +page.svelte. While this solution is a good workaround, it makes it extremely difficult to utilize Svelte's SSR without causing a complete refresh on separate pages that share the same server data.
Describe the proposed solution
Allow users to define +layout.svelte with multiple slots, the same way components do.

     <slot />

    <slot name="aside" />

Alternatives considered
You can define your own layout component that you utilize in each one of your pages. However, hard to implement without slowing down your site. Would be much easier to do the proposed solution.
Importance
would make my life easier
Additional Information
No response

What would determine what gets loaded into that slot?

In theory it would work the same way it does for components. Using the "slot" attribute.
+page.svelte

This content here is going inside of the parent's main tag.

However, this content is going inside the parent's aside tag


Use 'r32' as the r value key in tracestate

Goal
The JS SDK uses 32 bit values for p & r because JS numbers cannot hold 64 bit integers
We need to be able to determine if an r value is 32 or 64 bit in order to consume the tracestate correctly, so we're now using explicit bit sizes in the r value key (i.e. r32 & r64)

Merging with CI failing as it's a known issue unrelated to this PR


Intake GUI browser + predefined plots

One really powerful feature would be to use the built-in intake GUI to browse the catalog and create plots (maybe the lowest-res overview image for each band?). But currently there are no pre-defined plots declared.
When running the following code and selecting a band under "Sources" a user sees "No predefined plots found - declare these in the catalog"
# `results` come from satsearch
catalog = intake.open_stac_item_collection(results.items())
intake.gui.add(catalog)
intake.gui

You can run the code-block above with this example notebook:
https://github.com/pangeo-data/pangeo-tutorial/blob/agu2019/notebooks/amazon-web-services/landsat8.ipynb

@scottyhq - what plots would be good defaults. I think we would basically need a mapping from the assets type (e.g. image/x.geotiff) to a plot. I suppose this mapping would be similar to the drivers mapping we already have:
https://github.com/pangeo-data/intake-stac/blob/d2c3f01b2e9931da7b1d87aaa67c7e0c107c5fc7/intake_stac/catalog.py#L325-L335

The following modification to catalog.py exposes a plot option, but I think we will also have to change some pieces of intake-xarray to get this to load properly.
class StacEntry(LocalCatalogEntry):
    """
    A class representing a STAC catalog Entry
    """

    def __init__(self, key, item, stacked=False):
        """
        Construct an Intake catalog Entry from a STAC catalog Entry.
        """
        driver = self._get_driver(item)
        # test adding RGB plot to metadata
        if item['type'] == 'image/jpeg':
            item['plots'] = dict(rgb=dict(kind='rgb', frame_width=400))

import xarray as xr
import hvplot.xarray
da = xr.open_rasterio(url)
da.hvplot.rgb(frame_width=400)

Just adding one more test, that suggests the above is an issue with intake-xarray loading the multiband RGB image intake calling hvplot(kind=rgb). Adding a plot with kind=image works as expected for a single band image:
        if item['type'] == 'image/x.geotiff':
            item['plots'] = dict(image=dict(kind='image', data_aspect=True, frame_width=500, datashade=True))

You should generally be able to find error messages in the browser console. Should I still be looking at this notebook: https://github.com/pangeo-data/pangeo-tutorial/blob/agu2019/notebooks/amazon-web-services/landsat8.ipynb ?

Hi @philippjfr - thanks for looking into it. Yes, you can launch an interactive notebook with aws specific content button here: https://github.com/pangeo-data/pangeo-tutorial. Then edit /srv/conda/envs/notebook/lib/python3.7/site-packages/intake_stac/catalog.py with the above code blocks to enable the plots. I'll check out the browser console in the future.


Enforce a line limit

We're looking at adding linting, and it turns out to be really easy if we use tox (PR incoming)
The tox change makes it so that all our tests with coverage calculations are done just by running tox. It also means that adding linting doesn't change the workflow for running tests beyond this.
flake8 seems to be the recommended linter currently - to support typing we need to suppress unused import errors. I think the best option here is to make them not count as a test failure but still report the violations, as unused import errors are still valuable.
It also means we need to agree on a line limit

Mitch and I reckon 100 is probs fine line limit wise btw, anyone prefer something else strongly?

Close since its added or do you want input?

Renamed the issue to reflect the fact we now have linting

Closing since we're now enforcing linting + line limits, so I don't really see the point of this issue (feel free to reopen if you're looking for further discussion; but pls specify what)


Use a label to request Doc generation on PRs

Currently wastefully running on all PRs
https://github.com/square/okhttp/actions/runs/3670180501/jobs/6204536484

Fixed in https://github.com/square/okhttp/pull/7590


[SPARK-5095] remove flaky test

Overrode the start() method, which was previously starting a thread causing a race condition. I believe this should fix the flaky test.

Test build #51076 has started for PR 11164 at commit 3af190b.

Can you explain a bit why it is flaky? If the test case is useful, we should just change "test" to "ignore" rather than removing it.

Test build #51076 has finished for PR 11164 at commit 3af190b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51076/
Test PASSed.

This test was added recently in #10993 so this is just reverting the test instead of reverting the whole patch. I do think we should use ignore since that's what we do elsewhere in Spark.

Also @mgummelt can you either file a JIRA or add the same JIRA to the title of this patch?

Updated the title.
Kept the test, and overrode the start() method, which was previously starting a thread causing a race condition.  I believe this should fix the problem.

Test build #51196 has started for PR 11164 at commit 4e6b4db.

Test build #51196 has finished for PR 11164 at commit 4e6b4db.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/51196/
Test PASSed.

Merged into master. Let's see whether this fixes it.


Container Group Volumes - unsupported attribute

1239 - Container Group Volumes cause 'unsupported attribute', and secret not mapped
PR Checklist

[x] I have added example(s) inside the [./examples/] folder
[x] I have added the example(s) to the integration test list for normal (~30 minutes) or long runner >30 minutes
[x] I have checked the coding conventions as per the wiki
[x] I have checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Does this introduce a breaking change

[ ] YES
[x] NO

Testing
Add the below to a configuration.tfvars instance:
container_groups = {
  aci_dns = {
    name               = "aci_dns"
    region             = "region1"
    resource_group_key = "dns"
    ip_address_type    = "Private"
    os_type            = "Linux"

    network_profile = {
      key = "aci_dns"
    }

    containers = {
      coredns = {
        name   = "dns-forwarder"
        image  = "coredns/coredns:1.9.0"
        cpu    = "2"
        memory = "2"

        commands = ["/coredns", "-conf", "/app/conf/Corefile"]

        volume = {
          dnscfg = {
            name       = "dns-forwarder-conf"
            mount_path = "/app/conf"
            read_only  = true
            secret     = {
              Corefile = "xxx"
            }
          }
        }

        ports = {
          1 = {
            port     = 53
            protocol = "UDP"
          }
        }
      }
    }
  }
}

thanks for your contribution to Cloud Adoption Framework @lukecalderon-dca!


Backend: delayed Double Agent card ability at the start of the phase and choose agent

[x] ~add field to current_game data - is_available_ability~ no we have list of available abilities for players - it is a field abilities
[ ] if True for bot - set bots agent choice, then reveal this choice to player in current_game data, then set ability to False
[ ] if True for player - player set agent, then bot set agent and nothing else
[ ] raise error if player next phase without choosing agent

questions:

dead agents
vacations

-> errors

needs changes to schema, because information about agents is particle hidden from player, we need representation of data about opponent agents looks like:
agents ->
dead:  list[str] - ids of dead agents
in_play: Optional[str] - the id of agent in play or None or spetial word, that signalize - agent in play is hidden
in_vacation: list[str] - the ids of vacated agents
in_hand: list[str] - ids of agents or spetial wors if hidden
as spetial word we can use "_hidden"


"FATA Install failed; trident pod spec reports a different image" in air gap installation

I'm upgrading trident to version 21.07 with tridentctl on our "air gap" cluster.
The steps are:
./tridentctl install -n trident --image-registry artifactory.company.com/docker-k8s-official-remote/sig-storage --trident-image artifactory.company.com/docker-se-virtual/netapp/trident:21.07.0 --autosupport-image artifactory.company.com/docker-dockerhub-release-remote/netapp/trident-autosupport:21.01.0 --generate-custom-yaml  --silence-autosupport
./tridentctl install -n trident --use-custom-yaml
and then the output:
INFO Created Kubernetes clients.                   namespace=default version=v1.20.7
INFO Starting Trident installation.                namespace=trident
INFO Created service account.                      path=/root/trident-installer/setup/trident-serviceaccount.yaml
INFO Created cluster role.                         path=/root/trident-installer/setup/trident-clusterrole.yaml
INFO Created cluster role binding.                 path=/root/trident-installer/setup/trident-clusterrolebinding.yaml
INFO Trident tridentbackendconfigs.trident.netapp.io CRD present.
INFO Trident tridenttransactions.trident.netapp.io CRD present.
INFO Trident tridentsnapshots.trident.netapp.io CRD present.
INFO Trident tridentbackends.trident.netapp.io CRD present.
INFO Installer will create a fresh tridentmirrorrelationships.trident.netapp.io CRD.
INFO Created custom resource definitions tridentmirrorrelationships.trident.netapp.io.  namespace=trident
INFO Installer will create a fresh tridentsnapshotinfos.trident.netapp.io CRD.
INFO Created custom resource definitions tridentsnapshotinfos.trident.netapp.io.  namespace=trident
INFO Trident tridentstorageclasses.trident.netapp.io CRD present.
INFO Trident tridentvolumes.trident.netapp.io CRD present.
INFO Trident tridentnodes.trident.netapp.io CRD present.
INFO Trident tridentversions.trident.netapp.io CRD present.
INFO Created custom resource definitions.
INFO Created Trident pod security policy.          path=/root/trident-installer/setup/trident-podsecuritypolicy.yaml
INFO Added finalizers to custom resource definitions.
WARN Unable to get VolumeSnapshot CRD: customresourcedefinitions.apiextensions.k8s.io "volumesnapshots.snapshot.storage.k8s.io" not found  CRD=volumesnapshots.snapshot.storage.k8s.io
INFO Created Trident service.                      path=/root/trident-installer/setup/trident-service.yaml
INFO Created Trident secret.                       path=/root/trident-installer/setup/trident-service.yaml
INFO Created Trident deployment.                   path=/root/trident-installer/setup/trident-deployment.yaml
INFO Created Trident daemonset.                    path=/root/trident-installer/setup/trident-daemonset.yaml
INFO Waiting for Trident pod to start.
ERRO Trident pod was not running after 180.00 seconds. Pod status is Running. Use 'kubectl describe pod trident-csi-66d448dd89-249rr -n trident' for more information.
FATA Install failed; trident pod spec reports a different image (artifactory.company.com/docker-se-virtual/netapp/trident:21.07.0) than required (netapp/trident:21.07.0).  Resolve the issue; use 'tridentctl uninstall' to clean up; and try again.

All trident pods are running (and working)
 kubectl get pods -n trident
NAME                           READY   STATUS    RESTARTS   AGE
trident-csi-66d448dd89-249rr   6/6     Running   0          14m
trident-csi-6t6l2              2/2     Running   0          14m
trident-csi-7cxvv              2/2     Running   0          14m
trident-csi-8nsfp              2/2     Running   0          14m
trident-csi-9b9gk              2/2     Running   0          14m
trident-csi-mt6r6              2/2     Running   0          14m
trident-csi-v4qgr              2/2     Running   0          14m
trident-csi-vgdxv              2/2     Running   0          14m
trident-csi-x6f4p              2/2     Running   0          14m

and also
tridentctl logs -n trident
don't throw any errors.
Environment
Provide accurate information about the environment to help us reproduce the issue.

Trident version: 21.07
Trident installation flags used: tridentctl install -n trident --use-custom-yaml
Container runtime: ocker version 19.03.15, build 99e3ed8919
Kubernetes version: v1.20.7
Kubernetes orchestrator: Kubespray
OS: Ubuntu 18.04.5
NetApp backend types: ontap
Other:

@heikocane I observed the same issue. What I found was:
When the install YAMLs are generated with tridentctl (tridentctl install --generate-custom-yaml -n trident), and trident-deployment.yaml is updated to have the trident-main container use a different container image (other than netapp/trident:21.07.0, tridentctl returns this error/warning. This was my log trace:
DEBU[2021-08-04T09:35:46-04:00] Trident pod not yet running, waiting.         increment=2.340488664s status="trident pod spec reports a different image (localhost:5000/netapp/trident:21.07.0) than required (netapp/trident:21.07.0)"
ERRO[2021-08-04T09:38:33-04:00] Trident pod was not running after 180.00 seconds. Pod status is Running. Use 'kubectl describe pod trident-csi-bf755c4d-zdw2g -n trident' for more information.
FATA[2021-08-04T09:38:33-04:00] Install failed; trident pod spec reports a different image (localhost:5000/netapp/trident:21.07.0) than required (netapp/trident:21.07.0).  Resolve the issue; use 'tridentctl uninstall' to clean up; and try again.

As you can see, Trident observes the controller pod to be running, but still thinks there's an error somewhere. I believe you are good to go ahead and use Trident at this stage. This is an error with the tridentctl installer.

This issue is fixed with commit b60b06e and is available in the Trident 21.07.1 release.


Markdown

Some markdown extension allow "underscore" without  emphasize "long" in the middle of a word like my_long_variable -> https://en.wikipedia.org/wiki/Markdown#Extensions

Ah ah ah!... Nasty bug!
I'm currently doing a lot (a lot!) of refactor and a lot of libraries are updated or replaced by new ones.
I will pay attention to the new markdown library about this bug.

Done ;)

(But not pushed to test)


Fix/suppress the MathTargetType findings

PR Description
These were identified using the MathTargetType check in the Consensys errorprone-checks repository.
Pretty minimal changes. Thankfully there were only a few findings.
I considered changing committeeCount vars/funcs to int types but it would have been outside the scope of this PR.
Documentation

[x] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[x] I thought about adding a changelog entry, and added one if I deemed necessary.

This is a duplicate of #5256. Didn't realize you fixed those in there. Thanks!


Failed to accept subchannel: Dlc error Invalid argument

Channel had 100000 sats (can be seen in the logs), the margin I tried to open the position with was 100 sats.
App logs:
2023-03-16T04:43:26.200209Z DEBUG native::orderbook: Receive {"Match":{"order_id":"a25745f7-daab-48e4-acfd-a45d873bc622","expiry_timestamp":[2023,82,4,43,26,114210000,0,0,0],"oracle_pk":"16f88cf7d21e6c0f46bcbc983a4e3b19726c6c98858cc31c83551a88fde171c0","matches":[{"order_id":"cda2aeec-f93b-4cff-be15-322c8fc0de2a","quantity":0.05,"pubkey":"03249fad62b279b0bfd519caf50a00e75844bcbd946e4429258d054253ed2e9405","execution_price":24307.0}]}}
2023-03-16T04:43:26.200925Z  INFO native::orderbook: Received a match from orderbook for order: a25745f7-daab-48e4-acfd-a45d873bc622
2023-03-16T04:43:26.224796Z DEBUG native::event::event_hub: Publishing event OrderUpdateNotification(Order { id: a25745f7-daab-48e4-acfd-a45d873bc622, leverage: 2.0, quantity: 0.04602, contract_symbol: BtcUsd, direction: Long, order_type: Market, state: Open, creation_timestamp: 2023-03-16 4:43:26.059451 +00:00:00 })
2023-03-16T04:43:26.225086Z DEBUG native::event::event_hub: Found subscriber
2023-03-16T04:43:27.516741Z  INFO native::ln_dlc: Requested trade
2023-03-16T04:43:27.517146Z  INFO native::orderbook: Successfully requested trade at coordinator
2023-03-16T04:43:30.281184Z DEBUG native::ln_dlc::node: Processing sub-channel message from=02dd6abec97f9a748bf76ad502b004ce05d1b2d1f43a9e76bd7d85e767ffb022c9 msg=Offer
2023-03-16T04:43:34.70733Z DEBUG native::event::event_hub: Publishing event WalletInfoUpdateNotification(WalletInfo { balances: Balances { on_chain: 0, lightning: 100000 }, history: [] })
2023-03-16T04:43:34.7076Z DEBUG native::event::event_hub: Found subscriber
2023-03-16T04:43:35.356086Z DEBUG lightning::chain::chainmonitor: New best block 3bf55cd1d044c0699866504cc2ba82d49f9ca23075ceeea0fa26029e2098d867 at height 151 provided via best_block_updated
2023-03-16T04:43:35.51238Z DEBUG native::ln_dlc::accept: Found DLC channel offer peer=02dd6abec97f9a748bf76ad502b004ce05d1b2d1f43a9e76bd7d85e767ffb022c9@<IP_ADDRESS>:9045
2023-03-16T04:43:35.512733Z  INFO native::ln_dlc::accept: Accepting DLC channel offer peer=02dd6abec97f9a748bf76ad502b004ce05d1b2d1f43a9e76bd7d85e767ffb022c9@<IP_ADDRESS>:9045 channel_id=8466c2cbeaf0b75a406a2875d2047c08c61b3deb45e9d53304b3251b08809b48
2023-03-16T04:43:35.513173Z  INFO ln_dlc_node::node::dlc_channel: Accepting DLC channel offer channel_id=8466c2cbeaf0b75a406a2875d2047c08c61b3deb45e9d53304b3251b08809b48
2023-03-16T04:43:35.565703Z  INFO lightning::chain::channelmonitor: Applying update to monitor 8466c2cbeaf0b75a406a2875d2047c08c61b3deb45e9d53304b3251b08809b48, bringing update_id from 5 to 6 with 1 changes.
2023-03-16T04:43:35.590451Z DEBUG lightning::chain::chainmonitor: Persistence of ChannelMonitorUpdate for channel 8466c2cbeaf0b75a406a2875d2047c08c61b3deb45e9d53304b3251b08809b48 completed
2023-03-16T04:43:35.689967Z ERROR native::ln_dlc::accept: Failed to accept subchannel: Dlc error Invalid argument channel_id=8466c2cbeaf0b75a406a2875d2047c08c61b3deb45e9d53304b3251b08809b48
2023-03-16T04:43:39.218089Z DEBUG ln_dlc_node::node: Announcing node on [IPv4 { addr: [0, 0, 0, 0], port: 59364 }]
2023-03-16T04:43:39.221566Z DEBUG lightning::ln::peer_handler: Broadcasting NodeAnnouncement after passing it to our own RoutingMessageHandler.
2023-03-16T04:43:40.693618Z DEBUG native::ln_dlc::accept: Found DLC channel offer peer=02dd6abec97f9a748bf76ad502b004ce05d1b2d1f43a9e76bd7d85e767ffb022c9@<IP_ADDRESS>:9045
2023-03-16T04:43:40.694124Z  INFO native::ln_dlc::accept: Accepting DLC channel offer peer=02dd6abec97f9a748bf76ad502b004ce05d1b2d1f43a9e76bd7d85e767ffb022c9@<IP_ADDRESS>:9045 channel_id=8466c2cbeaf0b75a406a2875d2047c08c61b3deb45e9d53304b3251b08809b48
2023-03-16T04:43:40.69454Z  INFO ln_dlc_node::node::dlc_channel: Accepting DLC channel offer channel_id=8466c2cbeaf0b75a406a2875d2047c08c61b3deb45e9d53304b3251b08809b48
2023-03-16T04:43:40.713259Z  INFO lightning::chain::channelmonitor: Applying update to monitor 8466c2cbeaf0b75a406a2875d2047c08c61b3deb45e9d53304b3251b08809b48, bringing update_id from 6 to 7 with 1 changes.
2023-03-16T04:43:40.740418Z DEBUG lightning::chain::chainmonitor: Persistence of ChannelMonitorUpdate for channel 8466c2cbeaf0b75a406a2875d2047c08c61b3deb45e9d53304b3251b08809b48 completed
2023-03-16T04:43:40.782415Z ERROR native::ln_dlc::accept: Failed to accept subchannel: Dlc error Invalid argument channel_id=8466c2cbeaf0b75a406a2875d2047c08c61b3deb45e9d53304b3251b08809b48
2023-03-16T04:43:45.510642Z DEBUG native::event::event_hub: Publishing event WalletInfoUpdateNotification(WalletInfo { balances: Balances { on_chain: 0, lightning: 98144 }, history: [] })

Coordinator logs (nothing interesting in there, it just proposes and then waits, accept fails in the app):
2023-03-16 04:43:26  INFO coordinator::node: Opening position
2023-03-16 04:43:26 DEBUG coordinator::node: Proposing dlc channel event_id="btcusd1679546606"
2023-03-16 04:43:26 DEBUG reqwest::connect: starting new connection: https://oracle.holzeis.me/
2023-03-16 04:43:26 DEBUG lightning::chain::chainmonitor: New best block 3bf55cd1d044c0699866504cc2ba82d49f9ca23075ceeea0fa26029e2098d867 at height 151 provided via best_block_updated
2023-03-16 04:43:27 DEBUG lightning::chain::chainmonitor: 2 provided transactions confirmed at height 142 in block 2cd92033238fb26f1de8e43fdf399fc8abf0912c8517812bda14c94469727ee5
2023-03-16 04:43:27 DEBUG lightning::chain::onchaintx: Updating claims view at height 151 with 0 claim requests
2023-03-16 04:43:27 DEBUG lightning::chain::onchaintx: Updating claims view at height 151 with 0 matched transactions in block 142
2023-03-16 04:43:27 DEBUG lightning::chain::onchaintx: Updating claims view at height 151 with 0 claim requests
2023-03-16 04:43:27 DEBUG lightning::chain::onchaintx: Updating claims view at height 151 with 0 matched transactions in block 142
2023-03-16 04:43:27 DEBUG lightning::chain::onchaintx: Updating claims view at height 151 with 0 claim requests
2023-03-16 04:43:27 DEBUG lightning::chain::onchaintx: Updating claims view at height 151 with 0 matched transactions in block 142
2023-03-16 04:43:31 DEBUG ln_dlc_node::node: Announcing node on [IPv4 { addr: [192, 168, 178, 50], port: 9045 }]
2023-03-16 04:43:31 DEBUG lightning::ln::peer_handler: Broadcasting NodeAnnouncement after passing it to our own RoutingMessageHandler.

Had a quick chat with @luckysori about this; the error is coming from the dlc liebrary (not the dlc-manager) and unfortunately error handling is not very fine granular there, so it's hard to know what causes this - if I encounter this again I'll report back here

This is certainly fixed.


typedef rule improvement

Currently there are 2 options for parameter:

parameter: checks type specifier of function parameters for non-arrow functions.
arrow-parameter: checks type specifier of function parameters for arrow functions.

But there is only 1 option for call-signature:

call-signature: checks return type of functions.

It would be nice to split call-signature in 2 options:

call-signature: checks return type of functions for non-arrow functions.
arrow-call-signature: checks return type of functions for arrow functions.

Agreed @Fank! Check out #1015 and PR #1284


[Question]: jpegtran, MozJPEG optimizers

Hi there!
I'd like to ask about imagor's available image optimization options.
In Thumbor there's particular feature that's available - jpegtran optimizer.
I haven't tested it myself, but currently I seek for a tool that besides the rest of the functions would allow image size optimization and that's why I ask if there's native support from imagor, since I haven't found any mention in the README?
Also, I see that there's -vips-mozjpeg option that enables MozJPEG compression. Is it natively bundled in the docker image, or is it necessary to build a custom docker image to have this option available?
FWIK, mozjpeg seems to do a better compression, while taking more time compared to jpegtran. If possible, I would really appreciate it if you could share from your own experience what size reduction we could expect from these image optimizers.
Thank you

If MozJPEG is being complied on host machine, -vips-mozjpeg would enable MozJPEG compression. Other it would be no effect.
MozJPEG is currently not bundled with docker image, due the default libjpeg-turbo being used by many other dependencies, and we have yet to make it work alongside with other dependencies.
https://github.com/cshum/imagor/blob/master/Dockerfile
However if anyone manages to make MozJPEG complie successfully alongside all the other dependencies within the Docker image, I am all for a PR.

Got it,
Thank you!


ci: Remove pull_request_target references

Summary

Revise Pull Request process to improve security by removing pull_request_target

Master Issue

Closes https://go.mparticle.com/work/SQDSDKS-4283

:tada: This PR is included in version 1.4.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Can't add glyphicons to thead

If the table header contains glyphicon, bootgrid will remove them after initialization. Is there any way to keep them even after loading bootgrid? Thanks!!

            ID
            Sender
            Received
            Link

Im trying to figure out the same thing. Did you ever figure this out @a113n?

I mean i dont belive this is to be the best way to do this but you could just add the glyphicon class on document load. Would be neat to have a option for this? But this works as a work around.
$('#grid-data .glyphicon').addClass('glyphicon-chevron-down/up');


Deprecate BasicCommands from JedisCluster since it has no meaning

It'll be removed when we merge cluster-revised branch to master.
So I wanna mark it to @Deprecated to let users know.

:+1:

@HeartSaVioR nice observation. Let's merge until cluster-revised it's merged.

Downmerged to 2.6 and 2.7 respectively.


Installer crashes at like 65% of the initial boot

Im installing this EFI on the latitude 7490 which is almost exactly the same machine with olaria 14.5 image. It just displays an X and a link to support.apple.com/mac/startup. Did i do something wrong? wrong image? im sorry im new to this

Uhh you probably shouldn't use olaria here, use pure Mac os dmgs and make the installer according to dortabuas guis


concise literal object construction

some js libraries (vue, vuex, ) expect/enforce use of literal objects as parameters
and that makes @ScalaJSDefined classes unusable in such cases

currently type-safe literal construction is rather verbose:

option - A
https://www.scala-js.org/doc/interoperability/types.html
Literal object construction using an Scala object interface
option - B
https://www.scala-js.org/doc/interoperability/sjs-defined-js-classes.html
Anonymous classes
in both A and B cases one have to express the same idea twice:
  @ScalaJSDefined
  trait mutations extends js.Object {
    def increment(state: state)
    def decrement(state: state)
  }
  val mutations = new mutations {
    def increment(state: state) = state.count+=1
    def decrement(state: state) = state.count-=1
  }

instead, it would help to have perhaps a new annotation:

@ScalaJSLiteral
object mutations extends js.Object {
    def increment(state: state) = state.count+=1
    def decrement(state: state) = state.count-=1
}

which would de-sugar into the current "say twice" representation

The trait Mutations + val mutations = new Mutations { ... } is the recommended typesafe thing to do. Note that it does not express the same thing twice. The trait is the type declaration, expressed once in a library. The second is at call site, and the typechecker will ensure that it conforms to the declared type in the library.
Your suggested option does not provide typechecking, unlike the above, since there is no existing library-defined type definition to check against. If you're not going to typecheck things against an interface, you might as well do:
val mutations = new js.Object {
  def increment(state: state): Unit = state.count += 1
  def decrement(state: state): Unit = state.count -= 1
}

which already works today, and is even shorter than your suggestion.
I see nothing that needs changing. You already have all the tools that you are asking for.

yes, makes sense, and works, verified, thank you.

related to the original "@ScalaJSDefined classes unusable as literal":
what do you think about introduction of something similar to:

js.Object.toLiteral() // flatten, sanitize

to allow  re-use of @ScalaJSDefined instances,

for both "normal use" inside scala-js
and also for rendering as parameters for external js libs expecting literals

I don't think that's a good idea. It would encourage a style which is neither JavaScript-ish (where literals would be used directly) nor Scala-ish (because it is inherently not type-safe).
If you really really want it for yourself, you can define it easily as:
def toLiteral(obj: js.Object): js.Object = {
  val objDyn = obj.asInstanceOf[js.Dynamic]
  val result = js.Dynamic.literal()
  for (prop <- js.Object.properties(obj))
    result.updateDynamic(prop)(objDyn.selectDynamic(prop))
  result
}

great, thank you.


fixed TR to use default watcher URL when parameter is not present

What does this PR (Pull Request) do?

[x] This PR is not related to any Issue

This PR fixes an issue in Traffic Router where if there is a polling url (for example, federationmapping.polling.url) parameter and it is later unlinked to the TR or removed then the value will continue to be used until the TR is restarted instead of reverting to using the default value for the poller.
Which Traffic Control components are affected by this PR?

Traffic Router

What is the best way to verify this PR?

To recreate the problem:
Run cdn in a box, assign a new value to federationmapping.polling.url and snap (need to do this because the current parameter is the same as the default)
tail traffic router log for calls to get the federations and verify that it is using the new value
unlink the parameter from TR
verify that the old parameter is still used
To test solution:
do the same as above but at the end it should have reverted to using the default value
If this is a bug fix, what versions of Traffic Control are affected?

master
4.1

The following criteria are ALL met by this PR

This PR does not include tests, docs, or changelog updates since it is a bug fix.

[x] This PR includes tests OR I have explained why tests are unnecessary
[x] This PR includes documentation OR I have explained why documentation is unnecessary
[x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
[x] This PR includes any and all required license headers
[x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

Running the integration test, I get
Running com.comcast.cdn.traffic_control.traffic_router.core.util.AbstractResourceWatcherTest
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 6.02 sec <<< FAILURE! - in com.comcast.cdn.traffic_control.traffic_router.core.util.AbstractResourceWatcherTest
testWatchers(com.comcast.cdn.traffic_control.traffic_router.core.util.AbstractResourceWatcherTest)  Time elapsed: 6.019 sec  <<< FAILURE!
java.lang.AssertionError: expected null, but was:<"https://${toHostname}/api/2.0/federations/all">
  at com.comcast.cdn.traffic_control.traffic_router.core.util.AbstractResourceWatcherTest.testWatchers(AbstractResourceWatcherTest.java:99)

Running com.comcast.cdn.traffic_control.traffic_router.core.dns.ZoneManagerTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in com.comcast.cdn.traffic_control.traffic_router.core.dns.ZoneManagerTest

Results :

Failed tests:
  AbstractResourceWatcherTest.testWatchers:99 expected null, but was:<"https://${toHostname}/api/2.0/federations/all">

https://${toHostname}/api/2.0/federations/all is DEFAULT_FEDERATION_DATA_URL, right? Should the test get something else?

Still failing the federationmapping..polling.url assertion:
-------------------------------------------------------------------------------
Test set: com.comcast.cdn.traffic_control.traffic_router.core.util.AbstractResourceWatcherTest
-------------------------------------------------------------------------------
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 6.019 sec <<< FAILURE! - in com.comcast.cdn.traffic_control.traffic_router.core.util.AbstractResourceWatcherTest
testWatchers(com.comcast.cdn.traffic_control.traffic_router.core.util.AbstractResourceWatcherTest)  Time elapsed: 6.019 sec  <<< FAILURE!
java.lang.AssertionError: expected null, but was:<"https://${toHostname}/api/2.0/federations/all">
	at com.comcast.cdn.traffic_control.traffic_router.core.util.AbstractResourceWatcherTest.testWatchers(AbstractResourceWatcherTest.java:109)


Weird upper cavern level generation with the Z-level mod.

https://i.imgur.com/faHZgP5.jpg Very weird layer generation with the Z-level mod with an up ladder. Instead of generating a new layer it basically duplicates the below layer with the same generation and all and makes no flooring.
https://i.imgur.com/F6XvgvY.jpg Here's the first floor. Somehow the ore generation differs for new layers, but not the cavern generation. Down-layers aren't affected, digging down generates entirely new caves.
You can also notice the lighting is messed up when digging up,.
How to reproduce: Using the Z-level mod make a ladder up, and "go up" with a pawn. You'll create a duplicate of the lower layer, with the main difference between ore placement and a lack of flooring.

Issue is not with this mod but the default workings of the z-levels mod.


changed to better reflect deprecation in 2012

DTS packages were discontinued in SQL Server 2012. I propose updating the documentation to reflect the more accurate wording.

@ebauman : Thanks for your contribution to the Azure documentation! The author, @MikeRayMSFT, has been notified to review your proposed change.

#sign-off