Canvas is not accessible for people with disabilities

Description
I can't use accessibility properties from React Native
I need to configure accessibility for the elements that are rendered over the Canvas, to make it accessible for visually impaired people who use VoiceOver and TalkBack. Such as accessibilityLabel, accessibilityRole and accessibilityHint.
However accessibility properties are not supported on Canvas elements.
Documentation
https://reactnative.dev/docs/accessibility
For example:
import {Canvas, Circle, Group} from "@shopify/react-native-skia";

export const HelloWorld = () => {
  const size = 256;
  const r = size * 0.33;
  return (
    <Canvas style={{ flex: 1 }}>
      <Group blendMode="multiply">
        <Circle
          cx={r}
          cy={r}
          r={r}
          color="cyan"
          accessibilityLabel="Sweets with blueberry"
          accessibilityRole="button"
          accessibilityHint="Go to product list"
        />
        <Circle
          cx={size - r}
          cy={r}
          r={r} color="magenta"
          accessibilityLabel="Sweets with strawberry"
          accessibilityRole="button"
          accessibilityHint="Go to product list"
        />
        <Circle
          cx={size/2}
          cy={size - r}
          r={r}
          color="yellow"
          accessibilityLabel="Sweets with lemon"
          accessibilityRole="button"
          accessibilityHint="Go to product list"
        />
      </Group>
    </Canvas>
  );
};

Version
0.1.196
Steps to reproduce
Try implementing accessibility properties on any Canvas element.
Snack, code example, screenshot, or link to a repository

@GabrieleSuzart, did you try whether drawing elements in react-native-svg have these accessibility properties?
They employ a different approach to express drawing elements through React components (they utilize shadow nodes: https://reactnative.dev/architecture/render-pipeline), while we use our own React renderer: https://github.com/chentsulin/awesome-react-renderer. I'm curious to know if accessibility properties are available there (the code/documentation seems to suggest so). Currently, the shadow node approach is not possible for us. However, this might change if the React Native architecture allows for creating shadow nodes directly in C++ (vs making a android + ios implementation for each node).

Hello! Thanks for the answer :)
The Path and Svg elements (import { Path, Svg } from 'react-native-svg';) have accessibility properties, as SvgProps extends from ViewProps.
However, ImageSVG (import { ImageSVG } from '@shopify/react-native-skia';) does not have accessibility properties.
Would it be possible to use svg from react-native-svg within Canvas or would some Skia element also receive ViewProps properties?

Hi, you can't use regular components within a Canvas since a Canvas can only contain Skia components (they're basically descriptions of drawing operations). You can however use accessibility props on the Canvas itself as it is a View that accepts these. So the model is:
Canvas -> View with view props
Canvas.children -> Declarative drawing operations that are rendered using the GPU - does not have view props.
The differences compared to react-native-svg is that in RNSvg all nodes are essentially views that has view properties including accessibility props.

I'll close this one for now, please open a discussion if needed.

Could we reopen this issue and mark it as a feature request?

@GabrieleSuzart There is a solution that we use for integrating Gesture handler and Skia which consisting of overlaying native views over the canvas: https://github.com/Shopify/react-native-skia/blob/main/example/src/Examples/Stickers/Stickers.tsx#L27 (in the example you can see that each sticker is drawn on the canvas and has a corresponding native view on top of it).
Presumably the same technic could be used for accessibility.
If at some point the new React Native architecture allows for creating shadow nodes in C++, this is definitely something that we will consider.


fix: Add missing locals in iam-assumable-role module

Description
Fixes #289
Motivation and Context
Fixes #289
Breaking Changes
No
How Has This Been Tested?

[x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
[X] I have tested and validated these changes using one or more of the provided examples/* projects
[x] I have executed pre-commit run -a on my pull request

Please take a look at line No. 81 of the main.tf, I believe we need to keep consistency and either use local. in both places or not use them in both places.

@sirantd I'm don't understand your comment. Could you please add more details?

@enver It has been fixed in your second commit, all good now

Can this be approved? We have some workflows that are blocked because of this issue.

I made PR to the @enver branch. Once merged - it looks ok to me.

@sirantd Sorry, I just couldn't find time to finish this. Thank you for jumping in...merged.

Hi @bryantbiggs, does it makes sense to do fixes to pass linter warnings for terraform 1.3.3 as part of this PR? It's already quite big.
Could you review it so it can be merged, please?

can we get someone to review this? it is also blocking workflows for us as well

When can we expect this to be merged, please?

This PR is included in version 5.5.5 :tada:


Add support for submittedValues required / not required fields and remove undefined and null from submitted values in typescript

Won't be possible I think

Won't be possible without typescript plugin or something like that


Debug on arbitrary binding

To facilitate frequent debugging on a tool, I'm trying to implement a simple version of pry-rescue for debug.
Using the interception gem, it looks something like this:
require 'debug'
require 'interception'

class Executable
  def run
    intercept do
      fail "foobar"
    end
  rescue => error
    intercept error
  end

  private

  def intercept(error=nil, &block)
    if error
      @interceptions[error].break
    else
      Interception.listen(block) { |e, b| (@interceptions ||= {})[e] = b }
    end
  end
end

Executable.new.run

Save the above to test.rb and then run it with ruby test.rb.
The debugger opens a session always in the context of the line where break is sent:
    12|
    13|   private
    14|
    15|   def intercept(error=nil, &block)
    16|     if error
=>  17|       @interceptions[error].break
    18|     else
    19|       Interception.listen(block) { |e, b| (@interceptions ||= {})[e] = b }
    20|     end
    21|   end

However, if I change line 17 to @interceptions[error].irb, the IRB session is opened in the context of the actual error:
     2: require 'interception'
     3:
     4: class Executable
     5:   def run
     6:     intercept do
 =>  7:       fail "foobar"
     8:     end
     9:   rescue => error
    10:     intercept error
    11:   end
    12:

Is this the intended behavior or is it / should it be possible to start a debugger session on any binding?

No. binding doesn't have enough information to start debugger console.


Add rlSetBlendFactorsSeparate and checks for custom blend mode modifications

Coincidentally it seems like #2717 found some similar problems mentioned in this PR... I have made these changed a long time ago, sorry for that.

There are several problems.

In some cases rlSetBlendMode is not enough for all situations (like some 3rd party libraries like Live2D, actually I have written a raylib renderer for Live2D for fun, with changes in this PR)
If custom blend factors or equations is changed, some functions, like glBlendFunc, should be called. No function call is made now if RLGL.State.currentBlendMode is not changed

For problem 1, I used a more modest approach. I think glBlendFuncSeparate will not be used in most cases, so I add one more blend mode for this case. I don't know if it is appropriate to force developers to use glBlendFuncSeparate...
And I add custom blend mode modification checks in rlSetBlendFactors (and rlSetBlendFactorsSeparate) so that we can know if the custom blend factors and equations changed in rlSetBlendMode and avoid useless blend mode modification calls.
If #2717 is accepted, I can open a new PR to solve problem 2 😊.

Hi @pure01fx do you have plan to publish your Live2D renderer?

Hi @raysan5 I think there's a missing BLEND_CUSTOM_SEPARATE enum in raylib.h. It's small so I don't think I need to make a PR

@SAOMDVN Thanks! Added! :)

@pure01fx @raysan5 thanks a lot for this pr, this dramatically increase the font rendering, especially in webassembly compiling. btw, I use this function for example:
BeginBlendMode(BLEND_CUSTOM_SEPARATE);
rlSetBlendFactorsSeparate(0x0302, 0x0303, 1, 0x0303, 0x8006, 0x8006);

...balalalala

EndBlendMode();


[libjwt,librvi]: Set versions for reproducibility

Signed-off-by: Tatiana Jamison<EMAIL_ADDRESS>

@rstreif If this meets with your approval, would you merge? I do not have write access for this repo.


Add moving expenses landing page

Description
Add the expense upload page for PPM closeout.
Reviewer Notes
I got a little confused on this story as didn't immediately see a story to complete the rest of the page layout, so this pr adds all the fields for the expense upload page, which was broken out into two separate stories in pivotal.
Setup
make e2e_test

Code Review Verification Steps

[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Pivotal acceptance criteria been met for this change?

 Let me know if there is anything else.


Cleanup and harmonize Carla server build to use Unreal sysroot

Ensure that actually only the unreal sysroot is deployed for all C as
well C++ compilations including dependencies. That ensures the server is
NOT anymore linked against the system glibc (which is in Ubuntu22.04
incompatible with the Unreal one).
Harmonized naming split into client/server (instead of libcpp and
libstdcpp) to ensure nothing mixed up (and there were things mixed up
before!)
Refactor C# Unreal build using CarlaRules base class to provide common
functionality. Fixing windows build without ROS2 and added intitial
windows build with ROS2
Minors:

Update osm2odr commit
Fix windows install scripts and forward arguments for building
libcarla
Add some helper scripts to run under Linux

Description

Fixes #
Where has this been tested?
Ubunut 22.04, Ros2 humble, python 3.10
Windows 11, ahhh, no idea what python version there was installed, assume python3.10, but python is in each case irrelevant for this commit as it's mainly affecting the server build. Let's see if the CI builds under Windows (still) correctly

Platform(s): ...
Python version(s): ...
Unreal Engine version(s): ...

Possible Drawbacks

I have added couple comments on your code, additionally could you merge dev branch?

In terms of code formatting, the .clang-format can be placed in the respective folders with different content (so the Unreal part can get one with Unreal formatting style).
When having this in place one could even go one step further and make the codeformat.py call a pre-commit hook that is then always executed before commiting (don't ask me how to introduce this, but I've seen that at other repos recently and loved it immediately).
Then the formating of spaces and braces etc. is clear and one saves a lot of review-time; since persons tend to forget running codeformater if not automated ;-).

Hey Bernd!
When launching a make clean I receive this error:
Util/BuildTools/Linux.mk:163: warning: overriding recipe for target 'downloadplugins'
Util/BuildTools/Linux.mk:142: warning: ignoring old recipe for target 'downloadplugins'
BuildUE4Plugins.sh: Cleaning intermediate files and folders.
BuildUE4Plugins.sh: StreetMap Success!
BuildCarlaUE4.sh: Using Unreal Engine at '/home/adas/UnrealEngine_4.26'
BuildCarlaUE4.sh: Cleaning intermediate files and folders.
BuildCarlaUE4.sh: Success!
BuildPythonAPI.sh: Cleaning intermediate files and folders.
BuildPythonAPI.sh: Success!
BuildLibCarla.sh: Cleaning intermediate files and folders.
BuildLibCarla.sh: Success!
BuildOSM2ODR.sh: Cleaning intermediate files and folders.
rm: invalid option -- 'c'
Try 'rm --help' for more information.
make: *** [Util/BuildTools/Linux.mk:34: clean.osm2odr] Error 1
Then when I do a make launch, this issue appears:
FAILED: LibCarla/cmake/test/CMakeFiles/libcarla_test_server_release.dir///source/test/common/test_buffer.cpp.o
/home/adas/UnrealEngine_4.26/Engine/Extras/ThirdPartyNotUE/SDKs/HostLinux/Linux_x64/v17_clang-10.0.1-centos7/x86_64-unknown-linux-gnu/bin/clang++ -DASIO_NO_EXCEPTIONS -DBOOST_ERROR_CODE_HEADER_ONLY -DBOOST_NO_EXCEPTIONS -DLIBCARLA_ENABLE_PROFILER -DLIBCARLA_IMAGE_WITH_PNG_SUPPORT=true -DLIBCARLA_NO_EXCEPTIONS -DLIBCARLA_TEST_CONTENT_FOLDER="/home/adas/CARLA/carla/Build/test-content" -DLIBCARLA_WITH_GTEST -DPUGIXML_NO_EXCEPTIONS -I/home/adas/CARLA/carla/LibCarla/cmake/../source -I/home/adas/CARLA/carla/LibCarla/cmake/../source/third-party -I/home/adas/CARLA/carla/LibCarla/cmake/../source/test -isystem /home/adas/CARLA/carla/Build/boost-1.80.0-c10-install/include -isystem /home/adas/CARLA/carla/Build/rpclib-v2.2.1_c5-c10-server-install/include -isystem /home/adas/CARLA/carla/Build/gtest-1.8.1-c10-server-install/include -isystem /home/adas/CARLA/carla/LibCarla/cmake/test -std=c++14 -pthread -fPIC -Wall -Wextra -Wpedantic -Wdeprecated -Wshadow -Wuninitialized -Wunreachable-code -Wpessimizing-move -Wold-style-cast -Wnull-dereference -Wduplicate-enum -Wnon-virtual-dtor -Wheader-hygiene -Wconversion -Wfloat-overflow-conversion -std=c++14 -fPIC -stdlib=libc++ -DBOOST_NO_EXCEPTIONS -DASIO_NO_EXCEPTIONS --sysroot=/home/adas/UnrealEngine_4.26/Engine/Extras/ThirdPartyNotUE/SDKs/HostLinux/Linux_x64/v17_clang-10.0.1-centos7/x86_64-unknown-linux-gnu/ -isystem /home/adas/UnrealEngine_4.26/Engine/Source/ThirdParty/Linux/LibCxx/include/c++/v1 -std=c++14 -pthread -fPIC -Wall -Wextra -Wpedantic -Wdeprecated -Wshadow -Wuninitialized -Wunreachable-code -Wpessimizing-move -Wold-style-cast -Wnull-dereference -Wduplicate-enum -Wnon-virtual-dtor -Wheader-hygiene -Wconversion -Wfloat-overflow-conversion -std=c++14 -fPIC -stdlib=libc++ -DBOOST_NO_EXCEPTIONS -DASIO_NO_EXCEPTIONS --sysroot=/home/adas/UnrealEngine_4.26/Engine/Extras/ThirdPartyNotUE/SDKs/HostLinux/Linux_x64/v17_clang-10.0.1-centos7/x86_64-unknown-linux-gnu/ -isystem /home/adas/UnrealEngine_4.26/Engine/Source/ThirdParty/Linux/LibCxx/include/c++/v1 -O3 -DNDEBUG -MD -MT LibCarla/cmake/test/CMakeFiles/libcarla_test_server_release.dir///source/test/common/test_buffer.cpp.o -MF LibCarla/cmake/test/CMakeFiles/libcarla_test_server_release.dir///source/test/common/test_buffer.cpp.o.d -o LibCarla/cmake/test/CMakeFiles/libcarla_test_server_release.dir///source/test/common/test_buffer.cpp.o -c /home/adas/CARLA/carla/LibCarla/source/test/common/test_buffer.cpp
In file included from /home/adas/CARLA/carla/LibCarla/source/test/common/test_buffer.cpp:7:
In file included from /home/adas/CARLA/carla/LibCarla/cmake/../source/test/test.h:13:
In file included from /home/adas/CARLA/carla/LibCarla/cmake/../source/test/Buffer.h:9:
In file included from /home/adas/CARLA/carla/LibCarla/cmake/../source/carla/Buffer.h:9:
/home/adas/CARLA/carla/LibCarla/cmake/../source/carla/Debug.h:71:12: fatal error: 'gtest/gtest.h' file not found
include <gtest/gtest.h>

I wasn't able to reproduce the gtest.h issue, even uninstalling my ros2-humble packages including gtest headers. Nevertheless I've found other compilation issues, which I fixed ;-)


Is it normal when i publish some messages like this?

mytest.php:
$client = new Mosquitto\Client();
$client->connect("x.x.x.x", 1883, 60);
while ($client->loop() == 0) {
$message = "Test message at " . date("Y-m-d H:i:s");
$client->publish('mytopic', $message, 0, false);
$client->loop();
sleep(1);
}
When i first use browser open  mytest.php ,the subscribe side receive the message sucessfully,but i close the page,the subscribe side still can receive the message ,what's going wrong?

You need to call $client->loop() to make the underlying library process its messages. I've added an example to the README.


key: Add --new-password flag for non-interactive password changes

What is the purpose of this change? What does it change?
Makes it possible to change the password non-interactively.
I was unsuccessful trying to do it in a script by piping into stdin; restic expects 1000 bytes and the error check is wrong so it always returns an error even on early EOF; but even when corrected, I can only seem to pass one input, not two. Anyway, the whole thing doesn't matter if there's a nifty flag. :smile:
Was the change discussed in an issue or in the forum before?
Closes #827
Also see https://forum.restic.net/t/changing-repo-password-without-prompt/591?u=matt
/cc @robbat2 and @HLeithner
Checklist

[x] I have read the Contribution Guidelines
[ ] I have added tests for all changes in this PR
[ ] I have added documentation for the changes (in the manual)
[x] There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
[x] I have run gofmt on the code in all commits
[x] All commit messages are formatted in the same style as the other commits in the repo
[x] I'm done, this Pull Request is ready for review

(There don't seem to be tests for the commands, and this is automatically documented by restic key -h, so I'm marking this as done, I guess?)

Codecov Report

Merging #1720 into master will decrease coverage by 5.14%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #1720      +/-   ##
==========================================
- Coverage    52.1%   46.96%   -5.15%
==========================================
  Files         148      148
  Lines       11712    11716       +4
==========================================
- Hits         6103     5502     -601
- Misses       4658     5322     +664
+ Partials      951      892      -59

Impacted Files
Coverage Δ

cmd/restic/cmd_key.go
58.09% <50%> (-0.33%)
:arrow_down:

internal/backend/azure/azure.go
0% <0%> (-82.15%)
:arrow_down:

internal/backend/swift/swift.go
0% <0%> (-78.45%)
:arrow_down:

internal/backend/b2/b2.go
0% <0%> (-77.73%)
:arrow_down:

internal/backend/gs/gs.go
0% <0%> (-73.61%)
:arrow_down:

internal/backend/swift/config.go
36.95% <0%> (-54.35%)
:arrow_down:

internal/checker/checker.go
64.59% <0%> (-3.91%)
:arrow_down:

internal/backend/rclone/backend.go
72.25% <0%> (+1.93%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c2e84...21979fa. Read the comment docs.

Sure, makes sense. I've made the change!

Looks good, I've taken the liberty of squashing the commits, and I'll merge this after the tests ran. Thank you for your contribution!


Tar command is incorrect on getSnapshot

I believe there is a slight error on the tar command:
tar --directory "$DUMPDIR" \
            -zcvf $FILENAME \
                  $KEYSPACE \
                  $SCHEMA \
                  $KEYSPFILE \
                  $SNAPSFILE \
                  $HOSTSFILE \
                  $DATESFILE >/dev/null 2>&1

$KEYSPACE should not be there, I think.

Nevermind.
The "issue" is that there was no data on my DB, therefore the keyspace directory under the temporary file was not being created, and the tar command would return an error code 2 because of that.  However, the tar file was being created successfully.


IREE not catching out-of-memory failures in bare-metal environment

Describe the bug
IREE's VM does not catch out-of-memory failures (malloc returning nullptr) in bare-metal embedded environments.
To Reproduce
Using the RISC-V bare metal target, attempt to run a model that requires more memory than the embedded target has available. You can check this artificially by attempting to use a very low memory target in qemu. In our case, we were attempting to run a proprietary model that needed to allocate 4.7 megabytes in a single malloc on a platform that only has 4 available.
Additional context
The asserts that should have caught this issue seem to be disabled on release builds, which unfortunately allowed the error to propagate and become more obfuscated. We should consider ensuring that, at minimum, the runtime safety asserts surrounding standard library calls are always checked regardless of build type.
Attn: @hcindyl

Do you have any more details about what you are using to allocate? We do check for allocation failure when using the system allocator, so I'm guessing you are using your own custom allocator or not using IREE's allocation interface somewhere?
https://github.com/google/iree/blob/5ca3e18afc6b1bbf6df5bcac0ea14a2c479d5fe5/iree/base/allocator.c#L95-L98

I got rid of the two places we weren't routing through iree_allocator_t here: https://github.com/google/iree/pull/6809, so now if you are hitting unguarded allocations they are likely in your application/embedding code or a bug at a specific place we'd need a callstack for.

I found the bug (or one of them)
https://github.com/google/iree/blob/main/iree/hal/buffer_heap.c#L60
Need to return status :)

Hah! Awesome!  Need to fix one iree_status_is_ok(status) in our own application.
iree/iree/base/allocator.c:89: RESOURCE_EXHAUSTED; system allocator failed the request; while invoking native function hal.allocator.allocate; while calling import;

Thanks for the help!

np nice find on the bad heap buffer returns! Also kicked me into fixing the ELF loader stuff you pointed out the other day :)


Queue status extensions

This change adds a "queue status" extension to the plugin.  What this does is update the github status for a job based on the number of items in the jenkins queue that are assigned the same label.  This is useful for systems where the number of queue items can become large, so that users have some idea of when their job will run.  Of course, this doesn't take into account queue vetoing, etc. plugins.  When enabled, the github contexts are periodically updated with a " X/Y in " suffix on the build status description.

Updated based on parameters action changes.

@benpatterson Any thoughts?

@mmitche I like the idea. Sorry I haven't had a chance for a code review. Got caught up in that environment contributor bug last month. I'll look sometime in the next week....cool?

@benpatterson No worries.  FYI this has been running in our production since the PR :D

@mmitche Nothing particularly stands out to me as problematic with this PR's changes on my first pass. However, could you add some tests?

Will do.

To give more context on tests, I'm particularly curious about error handling, queue max/mins, and such.  It'd be great to have tests for those kinds of conditions to prevent any issues on code changes later.

@mmitche when you get a chance, could you rebase, too?

Merged with head, working on tests now.

@benpatterson Do you know how one might unit test the async periodic workers?  Most of the functionality is in there (aggregation of lengths, etc.). I poked around in the jenkins org on github and didn't see any tests that appear to check that kind of functionality

@benpatterson Let me know if you need anything else for this.

@mmitche @samrocketman How shold we move on with this?


[Bug Report] el-table fixed column postion error

Element UI version
2.10.0
OS/Browsers version
win10 x64 1903 chrome 75
Vue version
2.6.10
Reproduction Link
https://github.com/chinaxy/element-ui-bug-repo
Steps to reproduce
npm i
npm run serve
use chrome to access http://localhost:4000
What is Expected?
the selection button and data columns in the same line
What is actually happening?
the selection button and data columns not in the same line
2.9.2 not found this bug

@chinaxy please use codesandbox or codepen.

updated reproduction Link @ziyoung


Strict mypy

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #61   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           9      9
  Lines         270    270
=====================================
  Hits          270    270

Coverage remained the same at 100.0% when pulling 894c148d389990f344b83a4dbe0d27418095951a on strict-mypy into 7028cac07596d0ed44176b85b43b73fa68866214 on master.

Coverage remained the same at 100.0% when pulling 894c148d389990f344b83a4dbe0d27418095951a on strict-mypy into 7028cac07596d0ed44176b85b43b73fa68866214 on master.

Coverage remained the same at 100.0% when pulling 894c148d389990f344b83a4dbe0d27418095951a on strict-mypy into 7028cac07596d0ed44176b85b43b73fa68866214 on master.

Coverage remained the same at 100.0% when pulling 894c148d389990f344b83a4dbe0d27418095951a on strict-mypy into 7028cac07596d0ed44176b85b43b73fa68866214 on master.

Changes Unknown when pulling b97acdff15b1e71c47084af38a397cc700a1b1f8 on strict-mypy into ** on master**.

Coverage remained the same at 100.0% when pulling b72d14d179b27be1e07a46d8746794131da20136 on strict-mypy into c35d8318a4c4c9fb225eedd7bd9a4f71e3b90179 on master.

Coverage remained the same at 100.0% when pulling b72d14d179b27be1e07a46d8746794131da20136 on strict-mypy into c35d8318a4c4c9fb225eedd7bd9a4f71e3b90179 on master.

Coverage remained the same at 100.0% when pulling 033bf8ee2e474c15525acb17b511ce9576882a69 on strict-mypy into 6c8dc1e84ca0d34b0756cdf283c807bd42585c58 on master.

Coverage remained the same at 100.0% when pulling 033bf8ee2e474c15525acb17b511ce9576882a69 on strict-mypy into 6c8dc1e84ca0d34b0756cdf283c807bd42585c58 on master.

Coverage remained the same at 100.0% when pulling 033bf8ee2e474c15525acb17b511ce9576882a69 on strict-mypy into 6c8dc1e84ca0d34b0756cdf283c807bd42585c58 on master.


Revert "refactor(frontend): Terminal"

Reverts OpenDevin/OpenDevin#1315
This seems to be the source of https://github.com/OpenDevin/OpenDevin/issues/1350
CC @amanape, sorry for the revert--feel free to open a new PR with the issue above fixed!

Of course... it's the only that doesn't have complementary tests 😅


Fix modal download button

Hi there,
I was using your app today and I loved it! Very easy to use and helped me along with making a map art on Constantiam.net.
I only had one issue, which was the button in the bottom left of the preview modal. To me, a button should provide functionality. If a button doesn't provide functionality, it should only be temporary. The button in the modal acted more as an 'alert' or info message. Maybe I'm way too sensitive of a person, but it kind of annoyed me, haha. In my head, I was like, "Why is a button that I could click to download the image telling me to right-click? If I didn't see a button, I would have just done that anyway."
Anyway, in case there are any other weirdos out there like me, I thought this pull request might be useful. In essence, it turns the button telling me how to download the image to instead just outright download the image.
I can certainly make any changes you desire. I wasn't sure if the outline style of the button would work for you or not, so happy to tweak this to your preference.
Cheers,
Ian

Hi
Glad to hear that you found the app useful !
That is a better idea. I hadn't originally thought of it as being a button, but just a message. What you've done does simplify it, and it looks nice as well.
Feedback is always welcome ! Thanks for taking the trouble of going through the code and creating a PR

I realised afterwards that there's a minor bug with the naming format which happens when multiple images have been uploaded - the button's download attr should use uid instead of 000001 when being defined.
Fixed this in another commit

Ah, nice catch! I think what I did was probably based on inspect element. I must have missed the code that modified the HTML id. Cheers!


Incompatible risc0 version used for 1.0.x

Is there an existing issue?

[X] I have searched the existing issues

Experiencing problems? Have you tried our Discord first?

[X] This is not a support question.

Description of bug
I believe there is a problem with the Risc0 dependencies from crates.io, which causes errors when trying to compile a risc0 project based on risc0-zkvm v1.0.x.
Ultimately the problem seems to be with semantic versioning: for example, risc0-zkvm v1.0.5 ends up depending on risc0-build v1.1.2, incurring compilation failures. This is expected given that, according to semver, v1.1.2 should be compatible with v1.0.5.
Possible solutions might be using the wildcard syntax to match deps with version 1.1.*, or using an exact match like =1.0.5?
Steps to reproduce
Follow the hello-world steps, using version 1.0.x:
rzup --version 1.0.5
cargo risczero new foo --guest-name foo_guest
cargo run --release

fails with:
error: unexpected argument '--id' found

Usage: r0vm <--port <PORT>|--elf <ELF>|--image <IMAGE>>

For more information, try '--help'.

It's actually just a warning, even though the message says that it's an error. What's going on is that the image_id computation can run faster by running r0vm which is built in release mode. But if we try to call r0vm and it's an older version you'll see this message. However, it does fallback to computing the image_id in the same process as part of the build and so doesn't actually block anything.
We can work on improving this error message to make it more clear what's going on and how the user should proceed.

Thank you for explaining, that makes sense.
Still, with the same steps mentioned above, I get a panick when executing the demo program:
    Finished `release` profile [optimized + debuginfo] target(s) in 37.25s
     Running `target/release/host`
thread 'main' panicked at host/src/main.rs:41:10:
called `Result::unwrap()` on an `Err` value: Your installation of the r0vm server is not compatible with your host's risc0-zkvm crate.
Do one of the following to fix this issue:

1. Install r0vm server version 1.0
2. Change the risc0-zkvm and risc0-build dependencies in your project to 1.0

risc0-zkvm version: 1.1.2
r0vm server version: 1.0.5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Hi drgora, I also ran into this issue and have found a temporary method to address it.
You must configure risc0's dependency in all the cargo.toml files as the 1.1.3.
like that
risc0-zkvm = { version = "=1.1.3", default-features = false, features = ['std'] } risc0-build= { version = "=1.1.3", default-features = false, features = ['std'] }
Note the equal symbol before the version number is necessary.

Besides, the below dependencies can be specified.
risc0-core = { version = "=1.1.3" }
risc0-binfmt = { version = "=1.1.3" }
risc0-zkp = { version = "=1.1.3" }
risc0-zkvm-platform = { version = "=1.1.3" }


Scrum 1160

Returns active if the ID is less than the counter in the DB for the subdomain

A better name for the current statusses could be assigned and unassigned? Or active (assuming there's no obsoleted, merged etc. IDs yet) and unassigned? inactive sounds like the entity has been disabled, which does not match the entities currently being represented by it.

Changed to assigned-unassigned!


Address bar does not change when you click a link

When clicking a link in solid-ui the address bar retains the old URI.
Most browser do not allow a change or origin from javascript for security reasons.
However, for links in the same origin the history API pushstate function can be used
Example code to fix :
    if (solo && dom && dom.defaultView && dom.defaultView.history){
      let stateObj = pane ? { paneName: pane.name } : {}
      dom.defaultView.history.pushState(stateObj, subject.uri, subject.uri)
    }

At : https://github.com/solid/solid-panes/blob/master/outline/manager.js#L1666

Also

Fix whitespace to comply with standard
Link to previous issue : https://github.com/solid/solid-ui/issues/30


purges releases before installing them

We saw lots of issues recently where retries caused helm commands to fail. This PR tries to help with these problems.

Why does it fail though? Can we improve on this? I do not see what went wrong. Can we improve logging and retry or something?

Rerun, green now.

Why does it fail though? Can we improve on this? I do not see what went wrong. Can we improve logging and retry or something?

Sure, I've proposed #60 to show the eventual build errors.


InvalidAuthenticationToken Access token validation failure.

I'm logging into my app fine, i'm then using react-adal to get the token
authentication.acquireToken(
        adalConfig.endpoints.api,
        (message, token, msg) => {
          if (token) {
            console.log("token", token);
            this.user(token);
          }
        }
      );

i'm then doing a call to the https://graph.microsoft.com/v1.0/me and getting the error InvalidAuthenticationToken, when i console .log the token its not empty
user async token => {
    try {
      const response = await axios.get(
        "https://graph.microsoft.com/v1.0/me",
        {
          headers: {
            Authorization: `Bearer ${token}`
          }
        }
      );

      console.log("response", response);
    } catch (error) {
      console.error(error);
    }
  };

Am i missing a step?

So just to give you a example how i get the User Object from Graphs API:
adalApiFetch(fetch, 'https://graph.microsoft.com/v1.0/me', {}) .then((response) => { response.json()     .then((responseJson) => {         localStorage.setItem("UserData", JSON.stringify(responseJson, null, 2))     }); }) .catch((error) => { console.error(error); })

Thanks @M0W93
I've tried that and it didn't work
i have this in my config
import { AuthenticationContext, adalFetch, withAdalLogin } from "react-adal";

export const adalConfig = {
  tenant: process.env.REACT_APP_TENANT,
  clientId: process.env.REACT_APP_CLIENTID,
  endpoints: {
    api: process.env.REACT_APP_CLIENTID
  },
  postLogoutRedirectUri: window.location.origin,
  redirectUri: `${process.env.REACT_APP_LOGIN_URL}/auth/openid/return`,
  cacheLocation: "localStorage"
};

export const authContext = new AuthenticationContext(adalConfig);

export const adalApiFetch = (fetch, url, options) =>
  adalFetch(authContext, adalConfig.endpoints.api, fetch, url, options);

export const withAdalLoginApi = withAdalLogin(
  authContext,
  adalConfig.endpoints.api
);

Everything works to login and can access the logged in user, just can't do a call to the graph api.
So using that code you pasted, gives me this error.
{
  "error": {
    "code": "InvalidAuthenticationToken",
    "message": "Access token validation failure.",
    "innerError": {
      "request-id": "b8ce1d02-f4e7-4437-9e4a-fbd70416dc24",
      "date": "2019-05-10T16:48:45"
    }
  }
}

Any ideas what i'm doing wrong?

Does it say Invalid Auth Toke altough you use the adalApiFetch method?
Maybe not enough permissions?

@M0W93 yeah even using adalApiFetch
permissions i have are Sign in and read user profile, which has been working for ages. Then we wanted to add a feature that required user being in a certain group so have Read all groups enabled.
These are both delegated permissions on the App.
Is any other permission required?

@M0W93 i'm getting the following error using
adalApiFetch(fetch, "https://graph.microsoft.com/v1.0/me", {})
        .then(response => {
          response.json().then(responseJson => {
            console.log(JSON.stringify(responseJson, null, 2));
          });
        })
        .catch(error => {
          console.error(error);
        });

{   "error": {     "code": "InvalidAuthenticationToken",     "message": "Access token validation failure.",     "innerError": {       "request-id": "7a455d55-0b07-4310-ab39-7540115f71e2",       "date": "2019-05-13T08:48:56"     }   } }

@M0W93 When the user signs in i'm redirecting to http://localhost:3000/auth/openid/return if that helps

Same issue here I get an access token but interestingly it doesn't authenticate with the graph microsoft endpoint. Could be something to do with portal.azure configuration, however the token I get from msal js is working ...

Same here , getting the error
{
"error": {
"code": "InvalidAuthenticationToken",
"message": "Access token validation failure. Invalid audience.",
"innerError": {
"request-id": "c0ad0d2a-b645-4c0d-800d-2d700c136f25",
"date": "2019-06-24T06:06:46"
}
}
}

export const adalFetchGraph = (fetch, url, options) =>
adalFetch(authContext, 'https://graph.microsoft.com', fetch, url, options);


Uncaught TypeError: $(...).jstree is not a function

Hello,
I am using jstree in angular with election.
Its working fine on browser but when we execute in electron then i am getting error
Uncaught TypeError: $(...).jstree is not a function
How can we solved this error
Thanks.

Sorry, this is something related to your project, and how you include your dependencies, so I can not help you with that.


more Task -> Instance updates

impacts API, health check, launch, status updates, etc
removed deprecated operations-per-cycle flag
deprecated maxTasksPerOffer flag in favor of maxInstancesPerOffer

LGTM

Velocity is complaining about a failing test. But I can't get it to fail locally. Smells like a test flake. Going to merge this and worry about it later.
For reference:
Error Message

org.mockito.exceptions.verification.WantedButNotInvoked:  Wanted but not invoked: taskStateOpProcessor.process(     ForceExpunge(instance [my_app.57cc84d4-7693-11e6-8461-0242ac110399]) ); -> at mesosphere.marathon.api.TaskKillerTest$$anonfun$15.apply(TaskKillerTest.scala:179)  However, there were other interactions with this mock: taskStateOpProcessor.process(     ForceExpunge(instance [my_app.57cc36b3-7693-11e6-8461-0242ac110399]) ); -> at mesosphere.marathon.api.TaskKiller$$anonfun$mesosphere$marathon$api$TaskKiller$$expunge$1$$anonfun$apply$3.apply(TaskKiller.scala:62)
Stacktrace

sbt.ForkMain$ForkError: org.mockito.exceptions.verification.WantedButNotInvoked:
Wanted but not invoked:
taskStateOpProcessor.process(
    ForceExpunge(instance [my_app.57cc84d4-7693-11e6-8461-0242ac110399])
);
-> at mesosphere.marathon.api.TaskKillerTest$$anonfun$15.apply(TaskKillerTest.scala:179)

However, there were other interactions with this mock:
taskStateOpProcessor.process(
    ForceExpunge(instance [my_app.57cc36b3-7693-11e6-8461-0242ac110399])
);
-> at mesosphere.marathon.api.TaskKiller$$anonfun$mesosphere$marathon$api$TaskKiller$$expunge$1$$anonfun$apply$3.apply(TaskKiller.scala:62)


Update Docs

Lots has changed and improved. The docs are out of date.
I've updated some info about the endpoints, but I need to iterate further.
https://github.com/AmericanRedCross/OpenMapKitServer/commit/e0f5076f5684f1c1ac1752db3b95768b328a8daa

these also need to be made more user-friendly. eg the OMK documentation assumes that someone is already familiar with ODK and starts from that assumption. This needs to back up and point people to ODK and XLSForms before diving in. Etc.

For running docker instance,

clone the repository
run  docker build -t omk .
run docker run --name omk-server --port 3210:3210 omk


MapLibre deployment doesn't seem to work on Safari?

I just noticed that the current master branch with MapLibre update doesn't load on Safari. Just a white page. When I switched back to a pre-MapLibre branch (moz-updates-2022-02), the page loads as expected in Safari and Chrome. Is anyone else experiencing this?
I'm on Safari Version 14.0.1 (146<IP_ADDRESS>.10).

I'm seeing this regex issue when running yarn start on Safari.  This is a typical issue with Safari.  Google Chrome usually has better regex support than Safari.  Specifically, Safari doesn't support negative lookbheinds and I'm not sure if they support negative look aheads.  This could be fixed by using a non-capturing group (?: ) or using a replacer function in stead of the ','.

(Sorry if this part is already obvious, but in case anyone is interested.  This is a common problem because it's difficult to create babel polyfills or plugins for regex, so webpacking doesn't usually solve this)

Fixed in #412


Numpad stop working after upgrade to vscode 1.73.1 on ubuntu 22.04

Hello,
After last vscode upgrade 1.73.1, the numpad key stop working properly. It is locked  as arrows whatever the state of Numlock.
I test it with the python and platformio plugins.
Restarting PC does not change anything.
Regards
Elmout

I find a workaround.
I am on portable PC.
If i launch vscode and use external keyboard, it is faulty. If i use at least once the numpad of the portable after the PC reboot while vscode is running, vscode works great afterward even with the external keyboard.
PS:

Keyboards internal and external layout is standard keyb_fr with two key remapped by .Xmodmap file.
keycode 148 = Home NoSymbol Home
keycode  75 = End NoSymbol End

in others software the numpad works great. It is just inside vscode.

@elmout31 It sounds like you are on Linux. Have you tried "keyboard.dispatch": "keyCode"?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


The quick action menu in workspace caht overlaps the download mobile app banner

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Coming from internal convo here https://expensify.slack.com/archives/C057F53HR40/p1693610198907439?thread_ts=1693585334.770279&cid=C057F53HR40
Action Performed:
Break down in numbered steps

As user who is not logged in , navigate to /sbe route on mobile web and where you havent dismissed the open native app banner
Sign in with a new user
Verify you are dropped into the SBE workspace chat

Expected Result:
Describe what you think should've happened
Verify that the Request Money etc quick action menu is not open over the download app banner
Actual Result:
Describe what actually happened
The menu is open over te banner
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari (in narrow view)
[ ] MacOS / Desktop

Version Number: v1.3.62-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation: https://expensify.slack.com/archives/C057F53HR40/p1693610198907439?thread_ts=1693585334.770279&cid=C057F53HR40
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0180fa92a75c596e8f
Upwork Job ID:<PHONE_NUMBER>063367168
Last Price Increase: 2023-09-04

PR up

Nothing needs to be done anymore


How to set state non persistentStates

Currently, store have "currentUrl" = windows.location.href
export default new Vuex.Store({
  state: {
    urlCurrent: null
  },
  getters,
  mutations,
  actions,
  plugins: [
    VuexWebExtensions({
      persistentStates: []
    })
  ]
})

Currently, I open 2 tabs, state auto change value urlCurrent.
I want to state urlCurrent will not change when I open other tab.
How can I disable sync state: urlCurrent
Here is my package.json:
{
"dependencies": {
    "axios": "^0.19.0",
    "vue": "^2.6.10",
    "vue-router": "^3.0.7",
    "vuex": "^3.1.1",
    "vuex-webextensions": "^1.2.7",
    "webextension-polyfill": "^0.4.0"
  },
  "devDependencies": {
    "@babel/core": "^7.5.4",
    "@babel/plugin-proposal-optional-chaining": "^7.2.0",
    "@babel/preset-env": "^7.5.4",
    "@babel/runtime-corejs3": "^7.5.4",
    "archiver": "^3.0.0",
    "babel-eslint": "^10.0.2",
    "babel-loader": "^8.0.6",
    "copy-webpack-plugin": "^5.0.3",
    "core-js": "^3.1.4",
    "cross-env": "^5.2.0",
    "css-loader": "^3.0.0",
    "ejs": "^2.6.2",
    "eslint": "^6.0.1",
    "eslint-config-standard": "^12.0.0",
    "eslint-friendly-formatter": "^4.0.1",
    "eslint-loader": "^2.2.1",
    "eslint-plugin-import": "^2.18.0",
    "eslint-plugin-node": "^9.1.0",
    "eslint-plugin-promise": "^4.2.1",
    "eslint-plugin-standard": "^4.0.0",
    "eslint-plugin-vue": "^5.2.3",
    "file-loader": "^4.0.0",
    "mini-css-extract-plugin": "^0.7.0",
    "node-sass": "^4.12.0",
    "sass-loader": "^7.1.0",
    "vue-loader": "^15.7.0",
    "vue-template-compiler": "^2.6.10",
    "web-ext-types": "^3.2.0",
    "webpack": "^4.35.3",
    "webpack-cli": "^3.3.5",
    "webpack-extension-reloader": "^1.1.0"
  }
}

up

Sorry, didn't know why I not get notified the first time.
For now the extension didn't have the feature for no sync states, but it's a nice idea, when I come back to home I check it.
Greetings and thanks for the report.

Thank so much!
I think it is a awesome feature !
Hope you update very soon.

If I understand fine, the feature that you request are available on the recent uploaded version (1.2.8)


I think I am on Psych engine v0.4.2 and on certain times when it is the players turn on a song, the game crashes

Describe your bug here.
Mind you, if you are modding, please try testing your bug in a clean version of the engine instead, this ensures the bug is actually caused by the engine itself.
When I restart a song or sometimes on a song, the game would crash when it is the bf/player turn
I am on the vs impostor v4 play tester build so that is the build I am modding on
Command Prompt/Terminal logs (if existing)
No response
Are you modding a build from source or with Lua?
I am not modding
Which branch of the engine are you using?
Unstable (experimental)
What is your build target?
Windows
Did you edit anything in this build? If so, mention or summarize your changes.
Yes, I edited stuff and accidentally put a psych engine port version of vs Dave and Bambi v3.0

Not only is this version 2-3 years old, but you're reporting a MOD issue.


Warning from java-fx when using ColorVisual with alpha component

Describe the bug
"WARNUNG: CSS Error parsing '*{-fx-background-color: #10101;}: Invalid color specification while parsing '-fx-background-color' at [1,24]"
When using a ColorVisual with a alpha component close to zero.
The other color components seems to have no influence on the warning.
To Reproduce
Steps to reproduce the behavior:

Create, for example, "private val transparentVisual = ColorVisual(1, 1, 1, 1)"
Add it to a Label or Button property "visual = transparentVisual"
Use it in a Scene

Expected behavior
No warning message.
System info

Windows 10
Java version: AdoptOpenJDK 11.0.8

Additional context
Info: Program functionality is not impaired, just a warning message

Integer.toHex seems to trim the leading 0.
Will be fixed in v0.3.
Current workaround is to use the opacity property.


Evapotranspiration

Currently, potential evaporation of the HBV routine (HBV_pe) is passed to the plotting module as 'Evaporation sum'. This should either be labelled differently or actual evapotranspiration (HBV_AET) should be passed.

fixed in branch "plot_improvements"


webSocketListener extensions

The purpose of this PR is to provide a painless Kotlin DSL able to catch the lifecycle event of a WebSocket
Ex. with all the call-back
client.newWebSocket(request){
    onOpen{ webSocket, response -> ... }
    onMessage { webSocket, text -> ... }
    onMessageByte { webSocket, bytes -> ... }
    onClosing { webSocket, code, reason -> ... }
    onClosed { webSocket, code, reason -> ...  }
    onFailure { webSocket, t, response -> ... }
}

For instance, if I'm interested to receive only the onOpen and the OnMessage events I'll declare only what I need, ex:
client.newWebSocket(request){
    onOpen{ webSocket, response -> ... }
    onMessage { webSocket, text -> ... }
}

Make sense.


CLibLinearRegression bug fix #4382

This PR fixes the issues mentioned in #4382:

Bias dimensionailty issue, where running the algorithm would fail due to vector dimensions mismatch
Sets use_bias values correctly
Sets prob.y to the given labels
A unittest for CLibLinearRegression

This seems ok to me now. I will wait for another day or so in case somebody else reviews, otherwise it's good to merge. Thanks a ton for the patch! Maybe we can test all linear models in this style once this is merged .... Ill put some links soon


added missed switcher for RBAC-disabled deployment

What this PR does / why we need it:
This PR adds missed switcher for RBAC-disabled deployment of chart stable/jaeger-operator.
Without fix:
» helm install stable/jaeger-operator --name jaeger-operator --set rbac.create=false --set serviceAccount.create=false
Error: release jaeger-operator failed: roles.rbac.authorization.k8s.io "jaeger-operator" is forbidden: attempt to grant extra privileges: [{[*] [io.jaegertracing] [*] [] []} {[*] [] [pods] [] []} {[*] [] [services] [] []} {[*] [] [endpoints] [] []} {[*] [] [persistentvol
umeclaims] [] []} {[*] [] [events] [] []} {[*] [] [configmaps] [] []} {[*] [] [secrets] [] []} {[*] [apps] [deployments] [] []} {[*] [apps] [daemonsets] [] []} {[*] [apps] [replicasets] [] []} {[*] [apps] [statefulsets] [] []} {[*] [extensions] [ingresses] [] []}] user=&
{system:serviceaccount:kube-system:tiller 71c9b746-b755-11e8-bdd9-3a88d844dbf2 [system:serviceaccounts system:serviceaccounts:kube-system system:authenticated] map[]} ownerrules=[] ruleResolutionErrors=[clusterroles.rbac.authorization.k8s.io "cluster-admin" not found]

With fix:
» helm install Repos/helm-charts/stable/jaeger-operator/ --name jaeger-operator --set rbac.create=false --set serviceAccount.create=false --wait
NAME:   jaeger-operator
LAST DEPLOYED: Thu Nov 22 17:57:09 2018
NAMESPACE: default
STATUS: DEPLOYED

RESOURCES:
==> v1/Deployment
NAME             AGE
jaeger-operator  5s

==> v1/Pod(related)

NAME                              READY  STATUS   RESTARTS  AGE
jaeger-operator-766c69b5c7-dg4qf  1/1    Running  0         5s

NOTES:
jaeger-operator is installed.

Check the jaeger-operator logs
  export POD=$(kubectl get pods-l app.kubernetes.io/instance=jaeger-operator -lapp.kubernetes.io/name=jaeger-operator --namespace default --output name)
  kubectl logs $POD --namespace=default

Special notes for your reviewer:
@cpanato, please review!
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped

/assign @cpanato

ping @cpanato

/ok-to-test

/test pull-charts-e2e


Allow to write ctypes values directly

If values to be written are already given as ctypes values, allow to
write them directly. This is useful, for example, for writing ctypes
structs and struct arrays.

Pull Request Test Coverage Report for Build 290

2 of 4 (50.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 90.602%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pyads/pyads_ex.py
2
4
50.0%

Totals

Change from base Build 286:
-0.2%

Covered Lines:
723

Relevant Lines:
798

💛  - Coveralls

Pull Request Test Coverage Report for Build 290

2 of 4 (50.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 90.602%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pyads/pyads_ex.py
2
4
50.0%

Totals

Change from base Build 286:
-0.2%

Covered Lines:
723

Relevant Lines:
798

💛  - Coveralls

Test added

Thanks for this PR. Looks good to me. Sorry for the late answer.


Syntax?

@keithwhor  Never seen this kind of syntax before:
https://github.com/keithwhor/multithread.js/blob/master/multithread.js#L26
What does the /**/ mean in an variable declaration?

Also what does the self refer to here:
https://github.com/keithwhor/multithread.js/blob/master/multithread.js#L27

This function is stringified and used as a boilerplate to create a web worker. The comments /**/ are for easy regex string replacement.


[Event Request] Table 5612 - FA Depreciation Book - OnBeforeAdjustLinearMethod

Dear ALAppExtensions team,
Through this issue we would like to request adding event publisher OnBeforeAdjustLinearMethod in Table 5612 FA Depreciation Book with the following signature:
[IntegrationEvent(true, false)]
local procedure OnBeforeAdjustLinearMethod(var Amount1: Decimal;
                                           var Amount2: Decimal;
                                           var IsHandled: Boolean)
begin
end;

with IncludeSender set to true.
which would be called as follows in AdjustLinearMethod:
local procedure AdjustLinearMethod(var Amount1: Decimal; var Amount2: Decimal)
var
    IsHandled: Boolean;
begin
    // >>>> New >>>>>>>>>>>>>>>>
    IsHandled := false;
    OnBeforeAdjustLinearMethod(Amount1, Amount2, IsHandled);
    if IsHandled then
        exit;
    // <<<< New <<<<<<<<<<<<<<<<

    Amount1 := 0;
    Amount2 := 0;
    if "No. of Depreciation Years" = 0 then begin
        "No. of Depreciation Months" := 0;
        "Depreciation Ending Date" := 0D;
    end;
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Can't run build and run VSCode on Windows

Type: Bug
As per https://github.com/microsoft/vscode/wiki/How-to-Contribute#build-and-run:

Clone microsoft/vscode
yarn (all goes well)
yarn watch (all goes well)
run ./scripts/code.sh (using Git Bash <IP_ADDRESS>)

Same happens when running ./scripts/code.bat in cmd

Reason: .build directory is never created.

Try to run ./scripts/code.bat

Sounds strange, but in Bash (with Git for Windows) you should run .bat. Try to run ./scripts/code.bat

Same.

I thought at first that previous build steps didn't create the .build directory, but there it is -- it was only hidden in File Explorer.

However, there is no executable in it.

What happens if you launch vscode through the Run & Debug menu?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!

Sorry for the late reply, I had to move to something else.
I just wanted to let you know that after reinstalling Windows (due to hardware upgrade) everything now "Works as Documented"™. Whatever happened, there was something wrong with my config.
Thank you so much @andreamah for you time and efforts. 🙏

Glad it works now :)


Docs: Rephrase in about section

Under Philosophy section, Every rule subsection

Thanks for PR. This is a good change, unfortunately, this file is automatically copied from ESLint main repository (https://github.com/eslint/eslint/blob/master/docs/about/index.md) so if we modify it here, it will be overwritten with the next release. Could you open a PR in the main ESLint repository for this change?

Hi @ilyavolodin, sure no problem!
Please refer to the PR here (https://github.com/eslint/eslint/pull/8609)

This document has been updated in the eslint repo, so I'm closing this PR. Thanks for contributing.


Clarify that the template URL is relative

All template URLs must be interpreted relative to some base URL -- or it becomes too easy to mistakenly phrase a too-permissive permission to read a template.

Thanks!


cursor changes to basic after click on TextField

Steps to Reproduce

Execute flutter run on the code sample
Move cursor on text field and click

Expected results:
cursor remains text
Actual results:
cursor become basic

Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'TextField Cursor',
      home: Scaffold(
        appBar: AppBar(
          title: const Text('Example'),
        ),
        body: const Center(
          child: SizedBox(
            width: 100,
            child: TextField(),
          ),
        ),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel beta, 3.4.0-17.2.pre, on macOS 12.4 21F79 darwin-arm, locale zh-Hans-CN)
    • Flutter version 3.4.0-17.2.pre on channel beta at /Users/likang/SDKs/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d6260f127f (13 days ago), 2022-09-21 13:33:49 -0500
    • Engine revision 3950c6140a
    • Dart version 2.19.0 (build 2.19.0-146.2.beta)
    • DevTools version 2.16.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/likang/SDKs/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13F100
    • CocoaPods version 1.11.3

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] Connected device (1 available)
    • macOS (desktop) • macos • darwin-arm64 • macOS 12.4 21F79 darwin-arm

https://user-images.githubusercontent.com/850711/193782268-f172060a-c1a9-4d38-9eed-8c8be5c66111.mov

Hi @likang, I can not reproduce the issue on the latest stable 3.3.3 and master 3.4.0-37.0.pre.14 channels.

Demo
https://user-images.githubusercontent.com/104349824/193801375-7f9344bc-1be5-46a9-ad76-415c6fe0e286.mov

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.3.3, on macOS 12.6 21G115 darwin-x64, locale en-VN)
    • Flutter version 3.3.3 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18a827f393 (10 hours ago), 2022-09-28 10:03:14 -0700
    • Engine revision 5c984c26eb
    • Dart version 2.18.2
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode14.0.1.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 70.0.5
    • Dart plugin version 222.4167.21

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.71.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.48.0

[✓] Connected device (4 available)
    • SM T225 (mobile)           • R9JT3004VRJ                          • android-arm64  • Android 12 (API 31)
    • iPhone 14 Pro Max (mobile) • 332079AF-E895-4685-910E-7B1E18B0C6B8 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-0 (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • macOS 12.6 21G115 darwin-x64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 105.0.5195.125

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 3.4.0-37.0.pre.14, on macOS 12.6 21G115 darwin-x64, locale en-VN)
    • Flutter version 3.4.0-37.0.pre.14 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 35afe1bdac (45 minutes ago), 2022-10-03 18:41:23 -0700
    • Engine revision 83c68740e3
    • Dart version 2.19.0 (build 2.19.0-268.0.dev)
    • DevTools version 2.17.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode14.0.1.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 70.0.5
    • Dart plugin version 222.4167.21

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.71.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.48.0

[✓] Connected device (3 available)
    • SM T225 (mobile) • R9JT3004VRJ • android-arm64  • Android 12 (API 31)
    • macOS (desktop)  • macos       • darwin-x64     • macOS 12.6 21G115 darwin-x64
    • Chrome (web)     • chrome      • web-javascript • Google Chrome 105.0.5195.125

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Which platform are you testing? Also, please try using the latest stable or upgrading to the latest master channel and retry to see if this issue still reproduces.

Hi @huycozy Thanks for your quick response. I run it on macOS.

@likang thanks for your confirmation. This issue is reproducible on the latest stable and master channels.
It seems the issue only happens on macOS while other platforms work fine.

MacOS: ❌
Web: ✅
Linux: ✅
Windows: ✅

✅: No Issue ❌: Issue reproduced

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.3.3, on macOS 12.6 21G115 darwin-x64, locale en-VN)
    • Flutter version 3.3.3 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 18a827f393 (10 hours ago), 2022-09-28 10:03:14 -0700
    • Engine revision 5c984c26eb
    • Dart version 2.18.2
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode14.0.1.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 70.0.5
    • Dart plugin version 222.4167.21

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.71.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.48.0

[✓] Connected device (4 available)
    • SM T225 (mobile)           • R9JT3004VRJ                          • android-arm64  • Android 12 (API 31)
    • iPhone 14 Pro Max (mobile) • 332079AF-E895-4685-910E-7B1E18B0C6B8 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-0 (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • macOS 12.6 21G115 darwin-x64
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 105.0.5195.125

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

[✓] Flutter (Channel master, 3.4.0-40.0.pre.15, on macOS 12.6 21G115 darwin-x64, locale en-VN)
    • Flutter version 3.4.0-40.0.pre.15 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 28da87101b (37 minutes ago), 2022-10-04 20:17:24 -0700
    • Engine revision 9692f09afd
    • Dart version 2.19.0 (build 2.19.0-273.0.dev)
    • DevTools version 2.18.0

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.0.1)
    • Xcode at /Applications/Xcode14.0.1.app/Contents/Developer
    • Build 14A400
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] IntelliJ IDEA Community Edition (version 2022.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 70.0.5
    • Dart plugin version 222.4167.21

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.71.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.48.0

[✓] Connected device (4 available)
    • SM T225 (mobile) • R9JT3004VRJ                              • android-arm64  • Android 12 (API 31)
    • iPhone (mobile)  • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.7 19H12
    • macOS (desktop)  • macos                                    • darwin-x64     • macOS 12.6 21G115 darwin-x64
    • Chrome (web)     • chrome                                   • web-javascript • Google Chrome 105.0.5195.125
    ! Error: iPhone is busy: Fetching debug symbols for iPhone. Xcode will continue when iPhone is finished. (code -10)

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Labeling this issue for further investigation from the team. Thank you!

@dkwingsmt Is this related to your work?

https://github.com/flutter/engine/pull/36283 have fixed this issue, which has been rolled in 2 hours ago.


need a branch without nlopt

because nlopt does not install everywhere

and maybe a corresponding opam package then

For the code work; done in https://github.com/UnixJunkie/svmwrap/tree/no_nlopt

opam package there https://github.com/ocaml/opam-repository/pull/21494


enhance this logs intelligibility to set global postage batch slider in swarm extension

for example this occurs when Registering new account, and global postage stamp switch is not on, text could have bee "please check if Global Postage Stamp slider is ON"

Please triage, @nugaon.

Swarm Extension has already postageBatch.isGlobalPostageBatchEnabled() function that gives back whether postage batch is enabled or not. that should be just checked in the UI.


its not working at my side... i trying to change my fill color using same code...

add an expression to the fill of your shape:
rgb = hexToRgb(thisComp.layer("e1e1e1").text.sourceText.value); content("Rectangle 1").content("Fill 1").color = rgb
its give me the error...

Which error does it give you?
Suggestion: Make sure to test out all of your expressions in the actual after effects GUI, and only then use them within nexrender


Changing focus to another editor causes text to get selected sometimes

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.70.1
OS Version: 12.5 (21G72)

Steps to Reproduce:

Create two editors side by side
Click to change the focus from one editor to the other

https://user-images.githubusercontent.com/2737650/184494443-30668344-ae42-4372-b4c3-be0c6edd8cf2.mp4
I'm seeing this on VSCode desktop as well, but I tried to reproduce it on vscode.dev to make sure it wasn't caused by any settings or extensions.
Not sure what the intended behaviour should be in this case but I think it should at least be consistent.
Related/possible duplicate: #147105

This sounds very similar to https://github.com/microsoft/vscode/issues/113818 that @alexdima fixed.

This sounds very similar to #113818

Hmm that seems to be caused by the position of the text shifting while holding the mouse down. In this case the editor doesn't shift.
It also only happens occasionally rather than being consistently reproducible.


Add a link to the readme when reporting parse errors

Resolves #261. I've decided to just add a (hard-coded) message linking to the syntax description in the readme; hard-coding a summarised description of the syntax might be nicer, but would essentially be duplication with the readme and risk getting out of sync. Ideally, the syntax description would be extracted from the parser, like what many CLI arg parsing libraries support, but that's not trivial, so leaving it to future work.

@OpsBotPrime merge

Pull request approved for merge by @isomorpheme, rebasing now.

Rebased as 7aa6981e82d7e0d930d3b6824c387410f7159bfc, waiting for CI …

CI job :yellow_circle: started.


Keep scale test in the repository(disabled)

Signed-off-by: Joshua Packer<EMAIL_ADDRESS>
Add back the scale-*_test.go now that Sonar will run it's go test with -short ./...

/cc @leena-jawale @chrisahl


IE11: Multiple signup achievements when creating a new user

In Internet Explorer 11, I created a new user from the world map page and got a bunch of 'signed up' achievements.
The achievements are back after logging back in with the same user, on the world map.  Logging in on the homepage seems to fix up the state, and I don't see the 'signed up' achievement anymore.
When the multiple achievements are flashing all up and down the right side of the screen, the site is pretty unusable.

Doesn't reproduce on IE11 Win7.


Translation in Romanian

I translated ReadMe file in Romanian. Hope it is fine!:)
🤔 This is a

Translation

✍ Description
Completed Romanian translation of readme file
Added to documentation

readme file

🐱💻 Use a meme/gif to describe how you feel for contributing (optional)
👍

@Axel546 Please read the contributions guidelines.
I have written steps on how to create a branch and which branch to compare it to. 💯


fixed income and points progression equations

added a missing portion of the equations so it functions as intended of reducing payment by a percentage of the baseincome and the baseincome per level

Well, my math is not good, but we don't need to make any changes to the payment progress equation, because it was correct so far. Can you explain why the previous one wasn't right?

The edited part of the equation is the part that reduces income based on
number of jobs, specifically 5% per extra job. The old equation reduces by
5% of 1% of the joblevel, instead of the pay for 1% of the joblevel.
Solution is to multiply by baseincome to mimic first half of the equation,
where job pay itself is.
On Sun, Feb 2, 2020, 5:17 AM montlikadani<EMAIL_ADDRESS>wrote:

Well, my math is not good, but we don't need to make any changes to the
payment progress equation, because it was correct so far. Can you explain
why the previous one wasn't right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Zrips/Jobs/pull/660?email_source=notifications&email_token=AGMIKOUH66TAQMF4OJZZMRLRA2TTXA5CNFSM4KOWNCC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKRUIOA#issuecomment-581125176,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGMIKOUS76SS4HEO5FKMNJDRA2TTXANCNFSM4KOWNCCQ
.


Clarify some formula terms definitions

Clarify some formula terms definitions
Moderator
[TBD]
Moderator Status Review [last updated: YYYY-MM-DD]
Brief comment on current status, update periodically
Requirement Summary
The formulas for computing non-parametric vertical coordinates are in general well defined, but  in some cases the allowed units and standard names of some of the formula terms are not stated.
It is possible to infer the units by a dimensional analysis of the formula, and to ascertain that some terms require identical units to particular other terms. However, it would be better to state these requirements explicitly to assist data providers and anyone who writes software to carry out the computation.
The changes needed are:

For ocean_double_sigma_coordinate that a, z1 and z2  must all have identical units of (any) length (to ensure that the tanh operand is correct).

For ocean_s_coordinate that a and b must be dimensionless and depth_c must have units of length.

For ocean_s_coordinate_g1 the computed_standard_name and standard names of C and depth_c need defining.

For ocean_s_coordinate_g2 the computed_standard_name and standard names of C and depth_c need defining.

The last two points are brought in from https://github.com/cf-convention/discuss/issues/84
Technical Proposal Summary
For the relevant terms, a few lines are added to Appendix D: Parametric Vertical Coordinates.
The conformance document is updated to include a check on the units.
Benefits
As well bringing clarity to data providers and software writers, this change will allow the CF checker to check these items.
Status Quo
Everyone has work out what the units and standard names of these term should be, and the CF checker has no way of reporting any errors.
Associated pull request
PR #305
Detailed Proposal
See PR #305

I've changed my mind about "For ocean_double_sigma_coordinate that a, z1 and z2 must all have identical units of (any) length (to ensure that the tanh operand is correct)".
I think that it's OK for them to have different units of length (e.g. 'm' and 'km'), and it's up to the user to do any conversions. This is how it is in the rest of CF. I shall update the PR accordingly.

I support these proposed changes.  @davidhassell :  do you know anyone who has actually written a file based on these coordinates?  If so, perhaps we could ask them (or anyone who is really familiar with the coordinates) to check that the CF descriptions are correct.

Thanks, @taylor13. I don't know of any such data providers for the more involved formulas (such as ocean_double_sigma_coordinate), and it would indeed be good to hear from those who are familiar with them. Any takers?

Hello,
Are we OK to merge this PR, do you think? The proposed changes in #305 come from a dimensional analysis resulting from writing software can create the non-parametric vertical coordinates from formula terms. We've not heard about about any checks on the correctness of the formulae themselves, but I think that that could be raised as a new issue.
Thanks

Yes, I think it's OK, thanks.

I agree.  It's o.k.
Thanks.

Thanks @taylor13 and @JonathanGregory, I shall merge shortly (which will also close https://github.com/cf-convention/discuss/issues/84).


[QuiltMiz] Fabric Edition

We are currently planning to add Fabric Edition, for players who prefer Fabric instead of Quilt.
However Quilt will be the first priority (for now), Fabric Edition will be updated at the next day to prevent any confusion.
Nothing is different with Quilt Edition, except some mod list changes and such.
EDIT: Kosmos modpack will stay on original Quilt modloader, and no changes are planned as of now.

Fabric Edition is now available to public on Modrinth! Download it here:
https://modrinth.com/modpacks/quiltmiz-fe


Bind outer-joins before implicit joins

Summary of the changes / Why this improves CrateDB
When a query has mixed implicit and outer-joins joins, the joins are wrongly bound. Currently, we bound implicit joins first to preserve the original join order, which leads to an incorrect join order and a wrong query plan e.g.:
SELECT * FROM t0, t1 RIGHT JOIN (SELECT 1 ) AS sub0 ON true WHERE (NOT ((t0.c1)>=(t0.c1)));

results in:
+------------------------------------------------------------+
| QUERY PLAN                                                 |
+------------------------------------------------------------+
| NestedLoopJoin[RIGHT | true] (rows=unknown)                |
|   ├ NestedLoopJoin[CROSS] (rows=unknown)                   |
|   │  ├ Collect[doc.t0 | [c1] | (NOT (c1 >= c1))] (rows=0)  |
|   │  └ Collect[doc.t1 | [c0] | true] (rows=0)              |
|   └ Rename["1"] AS sub0 (rows=unknown)                     |
|     └ TableFunction[empty_row | [1] | true] (rows=unknown) |
+------------------------------------------------------------+

Explicit joins using JOIN binds stronger than implicit joins. This matters especially when outer-joins are involved because they can not be easily reordered because they have a preserved side. Therefore the query plan should have the following structure with the join order (t1 right join sub0) cross join t0.
+-----------------------------------------------------------------+
| QUERY PLAN                                                      |
+-----------------------------------------------------------------+
| Eval[c1, c0, "1"] (rows=unknown)                                |
|   └ NestedLoopJoin[CROSS] (rows=unknown)                        |
|     ├ NestedLoopJoin[RIGHT | true] (rows=unknown)               |
|     │  ├ Collect[doc.t1 | [c0] | true] (rows=unknown)           |
|     │  └ Rename["1"] AS sub0 (rows=unknown)                     |
|     │    └ TableFunction[empty_row | [1] | true] (rows=unknown) |
|     └ Collect[doc.t0 | [c1] | (NOT (c1 >= c1))] (rows=unknown)  |
+-----------------------------------------------------------------+

This binds the outer-joins first which leads to a correct query result but does not necessarily preserve the original join order anymore of the inplicit joins. This is not a problem since inner/cross joins can be arbitrarily reordered.
Fixes https://github.com/crate/crate/issues/16951
Checklist

[x] Added an entry in the latest docs/appendices/release-notes/<x.y.0>.rst for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in the latest docs/appendices/release-notes/<x.y.0>.rst
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

This fix is not correct. The issue is that the joins are wrongly bound.
SELECT * FROM t0, t1 RIGHT  JOIN  (SELECT 1 ) AS sub0  ON true WHERE (NOT ((t0.c1)>=(t0.c1)));

results in:
+------------------------------------------------------------+
| QUERY PLAN                                                 |
+------------------------------------------------------------+
| NestedLoopJoin[RIGHT | true] (rows=unknown)                |
|   ├ NestedLoopJoin[CROSS] (rows=unknown)                   |
|   │  ├ Collect[doc.t0 | [c1] | (NOT (c1 >= c1))] (rows=0)  |
|   │  └ Collect[doc.t1 | [c0] | true] (rows=0)              |
|   └ Rename["1"] AS sub0 (rows=unknown)                     |
|     └ TableFunction[empty_row | [1] | true] (rows=unknown) |
+------------------------------------------------------------+

but explicit joins such as RIGHT, LEFT bind stronger than implicit. Therefore the query plan should have the following structure with the (join t1 right join sub0) cross join t0
+-----------------------------------------------------------------+
| QUERY PLAN                                                      |
+-----------------------------------------------------------------+
| NestedLoopJoin[CROSS] (rows=unknown)                            |
|   ├ NestedLoopJoin[RIGHT | true] (rows=unknown)                 |
|   │  ├ Collect[doc.t1 | [c0] | true] (rows=0)                   |
|   │  └ Rename["1"] AS sub0 (rows=unknown)                       |
|   │     └ TableFunction[empty_row | [1] | true] (rows=unknown)  |
|   └ Collect[doc.t0 | [c1] | (NOT (c1 >= c1))] (rows=0)          |
+-----------------------------------------------------------------+

Then the cross-join is on top and the result will be empty.

retest this please
[io.crate.integrationtests.TransportSQLActionSingleNodeTest.testKilledAllLog](https://jenkins.crate.io/job/CrateDB/job/crate_on_pr/18294/testReport/junit/io.crate.integrationtests/TransportSQLActionSingleNodeTest/testKilledAllLog/)

unrelated test failure

What happens if we have 2 consequent outer joins?
t1 left join t2 right join t3
I think in this case one must use parenthesis or otherwise it should pick up left-to-right order -> (t1 x t2) x t3


Persist the Type Inclusion Information for Record/Object Type

Purpose

$title

Fixes #33520
Approach

Samples

Remarks

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

@sanjana can you please attend the review comments?

@sanjana can you please attend the review comments?

Reminder!

Let's close this and reopen/resend when looking into this again

@sanjana There are some conflicts and review comments. Can you please look into them?

Let's close this and reopen/resend when looking into this again

Closing for now. And will be re-opening once started looking into this again.


Exception decoding class file

Vineflower version
vineflower-1.10.0
Describe the bug
When attempting to decompile a class file an exception occurs related to the pool entry #1 type -67. Suspect this class file is obfuscated since it's for crypto, but thought I'd submit it for your input.
Additional information
See attached log.
vineflowerException_Pool.txt

Closing this issue. The class file in question was encrypted. Once decrypted the decompile worked.


Timer penalty works, but is not showing span.

Span is not showing "-10s!" when an incorrect input has been selcted.

Removed from span, placed in new p element.


Xcode  12.0.1 build is failing when trying to run it on the simulator.

I'm facing the same issue, has anyone managed to fix the problem?

check out this https://github.com/SwiftyTesseract/libtesseract/releases/tag/0.2.0


Where is the interface exposed to user application?

We hope to make two Alveo cards communicate with each other through Ethernet using Limago. Where is the interface exposed to the user application? Is it the file named user_abstraction in the submodule fpga-network-stack-core? What is the relationship between Limago and this submodule? I mean I wonder if I have to use the whole Limago to complete the task of communication or I can just use fpga-network-stack-core.

The examples provided in this repository already include an application, which are either an echo or iperf. For the U280 the application is iperf.
Limago does not provide an interface for the application with the host and the application must reside within the FPGA. Unless you modify the design to support this.
For more documentation about the interface from the application and TCP module see the ETH repo https://github.com/fpgasystems/fpga-network-stack
The user_abstraction module is an abstraction to simplify the communication between the application and the the TCP module , it abstract away the handshake but you need to open the connections from using the AXI4-Lite registers.
You could launch the iperf application as client. These steps are described in the README.md, and to see the results you need to observe the internal probes.
I highly recommend to open the IPI and familiarize with the design, in particular with the interface_handler hierarchy.


Round-trip failure with inexplicably-reduced test case :)

Issue Kind
Round-Trip Failure
Source Code
o() {
    var a = /*comment*/+2/*comment*/
   _ = bar2(a:1, b:2, c:2)
    _ = bar2(a:1 + 1,,

#if blah
func tryfoo() {
  try foo()
 nc closure() {
  _ = {[weak a,
    unowned(safe) self,
    b = 3,
 [] (a: Int, b: Int, _: Int) -> Int in
    r

Description
No response

rdar://99657725


File Upload Multi Edit e2e Test

Modified recordedit, to provide all the available data to hatrac for creating url_pattern (invisible columns were not accessible before).
multi-edit test cases are added.
All the url_patterns have been updated to reflect the latest changes in
ermrestjs.
fileupload functions are added to recordedit-helpers to make the
testing of fileupload easier.

@jrchudy I added those missing test cases.


Improve designsystem of stats

Need to improve this component on \<stats>\src\<stats.designsystem.mdx>
Improvements required :
Any reference image?
Any external reference?
You can checkout this one for better understanding.

assign me @Rajdip019 @rupsha014

@Tushar98644 go ahead

@Tushar98644 Please  add the design sytem file inside the existing folder of that component
You have made new folder for design system #1482

I want to contribute, please assign it to me

I want to contribute, please assign it to me

Sure, go ahead @Tapo41

what changes i have to make exactly ?
i can see the code and the screenshots are mismatched , should i supposed to  correct that?
i can see a extra screenshot there , no code of that screenshot is present anywhere ..

@RavindraP04 what changes i have to make exactly ? i can see the code and the screenshots are mismatched , should i supposed to correct that? i can see a extra screenshot there , no code of that screenshot is present anywhere ..

There are two image in the design system, Remove one and in the code section, copy paste the code of only that component whose image is used in the design system

@Rajdip019 which image to delete?


feat(store-cache): make everything async

closes #1055

lgtm! this is a breaking change so we should add the BREAKING CHANGE: footer on the commit. For the first "snapshot" release after #1036 we should probably write some manual release note (coincides well with the first external core dev call on thursday) mentioning this change.

Can do. This should only be breaking for folks using store-cache directly instead of via v1 networking and React hooks.
That said, there might be some timing issues with v1 networking code - we just fire off store-cache set/remove without awaiting or combining into a tx. Since we're only using InMemoryTupleStorage right now, this should be fine?


In-browser examples/tutorials

Hi
After finding out that the Brave browser is now supporting IPFS, I decided to look into IPFS and OrbitDB to see if it suitable for a browser extension I was playing around with a while back. However, after looking at the docs I noticed there wasn't much info about how to use OrbitDB in the browser.
I looked at the browser example, but it seems incomplete.  https://github.com/orbitdb/orbit-db/tree/main/examples/browser
I also looked at the following thread and followed the instructions, but npm install failed. https://github.com/orbitdb/orbit-db/issues/403
Are there any examples that will help me experiment with a very basic CRUD app on IPFS?
While i'm here, do you think OrbitDB/IPFS would be suitable for the extension that I want to build? Here is a video demonstration: https://www.youtube.com/watch?v=9lG37usSwoo
The purpose of the extension is enable people to like, dislike and comment on webpages (or anything for that matter).  I'm also interested in the possibility of using IPFS for personal data stores (similar to the Solid project), where the browser plugin exposes an API which other apps can interact with. I've got lots of ideas but I first need to decide which stack to use.
Thanks

Hello,
Sorry for the late comment...hope this is still of use to you. Constellation is an example project of mine that works in the browser and also Electron.
Hope this helps! Documentation is still pending so feel free to contact me if you'd like to discuss further.

Not sure if you reached out to @julienmalard on this issue but feel free to re-open if you would like to discuss your use case further.


Issues with FancyZones after computer suspension profile changes to default

Microsoft PowerToys version
0.66.0
Installation method
GitHub, PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
FancyZones
Steps to reproduce
I have a Samsung 49" Monitor Wide. I noticed that when my machine entes to suspend mode after it comes back (pressing a key) fancyzones changes the profile to the 3 columns "factory one" despite that my own profile is selected. Even if I go and select it again wont change anything. I need to select another profile then select my profile again.
✔ Expected Behavior
I was expecting to be on same windows layout after computer comes back from suspension
❌ Actual Behavior
Default/factory 3 columns layout is enabled after coming back from suspension.
Other Software
Windows 10 22H2 Build 2364

Are you still experiencing this issue? /needinfo

I do not! thanks! I forgot to close this.


Mention of Premium tier should be removed

This document still mentions the Premium tier of Event Grid, which didn't GA and there are currently no plans to reintroduce it I heard. So this reference should be removed from this section https://docs.microsoft.com/en-us/azure/event-grid/network-security#pricing-and-quotas.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 22711686-7353-1674-4313-96801a0808dc
Version Independent ID: ef864bd9-a9ad-3537-18e3-9cd41f035ffb
Content: Network security for Azure Event Grid resources - Azure Event Grid
Content Source: articles/event-grid/network-security.md
Service: event-grid
GitHub Login: @VidyaKukke
Microsoft Alias: vkukke

Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

@Roberto Cervantes @.>, @Javier @.>, @Sreedhar @.***>
Needed help to resolve this. Thanks!
From: Mike Urnun @.>
Sent: Tuesday, June 28, 2022 11:42 AM
To: MicrosoftDocs/azure-docs @.>
Cc: Vidya Kukke @.>; Assign @.>
Subject: Re: [MicrosoftDocs/azure-docs] Mention of Premium tier should be removed (Issue #94989)
Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fazure-docs%2Fissues%2F94989%23issuecomment-1169092682&data=05|01|vkukke%40microsoft.com|536b259a05e44b629c3708da5935e5ce|72f988bf86f141af91ab2d7cd011db47|1|0|637920385270903058|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=xWOMdEqr7uwWeQc3aBt4l8VGxzH75nXewu%2Fw8TdWCjQ%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHBAGDMDNUBHSVLCFMFJFG3VRNBPZANCNFSM52B3VHYQ&data=05|01|vkukke%40microsoft.com|536b259a05e44b629c3708da5935e5ce|72f988bf86f141af91ab2d7cd011db47|1|0|637920385270903058|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000|||&sdata=dSTKuifncrGeJn0GkMAM0ykcBRf%2B7QjWRwWSrnXVby0%3D&reserved=0.
You are receiving this because you were assigned.Message ID<EMAIL_ADDRESS>


Upgrade NodeJS from 16 to 20

I scanned the code and it seems to fix #181, we only need to change the configuration of the action itself.

@absalukaskosina thank you for the contribution!


[Athena] calling invalidate_cache() results in "not a folder created by Splink" error even when folder was created by Splink

What happens?
Using Athena as the SQL backend (AthenaLinker), I am attempting to call invalidate_cache() to force the latest input data to be used. However, this results in the following error:
ValueError: You've asked to drop data housed under the filepath s3://my-bucket/my-output-path/uft7qhr1/ from your s3 output bucket, which is not a folder created by Splink. If you really want to delete this data, you can do so by setting force_non_splink_table=True

As far as I can tell, there is no way to pass force_non_splink_table=True to invalidate_cache(). I explored the code and it doesn't seem to me like the validation that the folder is "Splink generated" is working correctly.
Just a note: I realize I am on a previous version of Splink, but an upgrade to 4.0+ is not currently feasible for me. Going ahead and logging this issue as I'm not sure if versions of Splink <4.0 are still receiving support. If not, of course feel free to close and I will find a workaround.
To Reproduce
Using Athena (AthenaLinker) as your SQL backend, call linker.invalidate_cache().
OS:
EC2
Splink version:
3.9.15
Have you tried this on the latest master branch?

[X] I agree

Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?

[X] I agree

Sorry you're having problems.  We're probably not going to have time to look at this any time soon.  If you can find the bug, feel free to PR a fix to the splink3_maintenance branch and we can do a bugfix 3.x release

thanks @RobinL, no worries. i have a workaround for the time being but if i get a chance to take a look i will!


Fix error when unproject bottomLeft or topRight  and lat are < -90 or > 90 or lng are < -180 or > 180

I'have a tablet and when i put FlutterMap with zoom: 1 and minzoom: 1, debug catch a throw in LatLng class because latitude or longitude are invalid ( lat < -90 or > 90 or lng < -180 or > 180). So i inserted a control before, when i unproject the point in pixel. With this fix it doesn't give error when i drag the map outside to the screen.

This fix is a very importat for my project, so please to check and if it's all ok create new version.

Hi @johnpryan, are you still here?
Can you check this pull request pls? It's very important fix