Make signature class only

Change Summary
Make __signature__ attribute class-only

Related issue number
Closes #1419
Checklist

[x] Unit tests for the changes exist
[x] Tests pass on CI and coverage remains at 100%
[x] Documentation reflects the changes where applicable
[x] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)

Very clever solution. LGTM 👍
@JrooTJunior @PrettyWood does this work for you?

Yes I already said on the issue that it was a way nicer and efficient solution! Thanks

Looks good

In case someone else finds this issue when investigating why the signature of
from pydantic import BaseModel

class FooModel(BaseModel):
    id: int
    name: str = None
    description: str = 'Foo'

is Init signature: FooModel(__pydantic_self__, **data: typing.Any) -> None.
You might be running into this bug https://github.com/napari/napari/issues/2264, which is a strange interaction between PySide2 and Pydantic.
Just leaving this here because it took me a long time to find out what's happening.


Dlopen hook causes app crash on Android 12

Hello.
How i can get some logs or something else cause my Android 12 smarthone just force close game after spawn.
Android 12:
Use frida spawn command frida -U -f com.example.app -l _script.js --no-pause just spawn my Game and cause Crashing after a second. Even cannot finish dumping command.
Use frida attach frida -U -n Appname -l _script.js --no-pauseor frida -U Appname  -l _script.js works great but i cannot intercept some initial functions of the Game because should to waint until attach to the procces. dump command works great by attaching.
Same thing with frida-gadget... my default frida JS script works good.. frida-il2cpp-bridge script still crashed the game.
Most stranger thing that script works good on a first second and replace some function without any issue but after one second game crashes without any log/error in command prompt
Android 11 & Android 10:
frida-Il2cpp-bridge my script works good with frida-server and frida-gadget
Maybe i can try to update to the latest frida version for your module but idk how

@dvgmdvgm it looks like the app has some anti-frida code (can it be?); did you try the same application on android 10/11?

@vfsfitvnm it's all happened for the same application with the same script..
I can record some video for more clarifying//
The same script with the same Game (and totally same game version) cannot spawn the game but can be attached to the currently opened process

@dvgmdvgm What's the game the issue is occurring on? I can try to reproduce the issue if it doesn't require google play services

@vfsfitvnm https://play.google.com/store/apps/details?id=com.kabam.marvelbattle

@dvgmdvgm Oh well I just realized it won't work on x86 emulator, so I cannot install it. This means I cannot investigate, however you can try by yourself, you can probably start here.
Does it crash with the following minimal snippet?
import "frida-il2cpp-bridge";

Il2Cpp.perform(() => {
    // this is empty
});

@vfsfitvnm Still crash with this empty minimal snippet.

@dvgmdvgm
Would you edit your local copy to:

Replace these two lines with:

setImmediate(() => {
    interceptor.detach();
    resolve();
});

and see what happens.

Comment out this whole section?

Replacing two lines give same result.

Gives this output

Error: abort was called
    at attach (node_modules/frida-il2cpp-bridge/dist/il2cpp/structs/domain.js:47)
    at <anonymous> (node_modules/frida-il2cpp-bridge/dist/il2cpp/base.js:94)
Process terminated

And game still crashed

Just to make sure, would you comment out this and this? And see if it crashes with the minimal snippet

@vfsfitvnm yes..
Comment this two parts and game still crashes with minimal snippet

@dvgmdvgm Hmm so I guess the problem is here. This is good because it's not related to that specific game (or to Il2Cpp), any other app would yield this result.
Just to make sure, would you comment out also these two lines (other than the two blocks of the previous comment)

@vfsfitvnm yap.. Game just spawn without any issue..
But i try to execute my scrip and nothing happened. Just vanilla game was spawned

@dvgmdvgm Hmm unfortunately I get this error, so I cannot use frida on my A12 emulator :/

@vfsfitvnm i've got so many frida errors on my A12 until install manual moded Magisk-Frida module.
service.sh should be edited in this module to works on A12. But your emulator doesn't support Magisk root right?

@dvgmdvgm Exactly, I can't install magisk

@vfsfitvnm i invented some lifehack.
Just open the game and immediately lock screen, so game Activity and il2cpp was launched but initial il2cpp function not.
After that i can attach to my process with frida-il2cpp-bridge script, unlock screen and continue to works with il2cpp)
But still hope that's issue can be fixed natively

@dvgmdvgm thanks for the update, however I can't fix this until Frida works properly on A12 emulator

@vfsfitvnm which one emulator are you using?

@vfsfitvnm Just get this output RN with spawn command. Attaching still works great.
Spawned `com.example.app`. Resuming main thread!
Error: unable to find module 'libil2cpp.so'
    at value (frida/runtime/core.js:336)
    at get module (node_modules/frida-il2cpp-bridge/dist/il2cpp/base.js:41)
    at call (native)
    at <anonymous> (node_modules/decorator-cache-getter/dist/index.js:9)
    at r (node_modules/frida-il2cpp-bridge/dist/il2cpp/api.js:1064)
    at get _domainGetAssemblies (node_modules/frida-il2cpp-bridge/dist/il2cpp/api.js:159)
    at call (native)
    at <anonymous> (node_modules/decorator-cache-getter/dist/index.js:9)
    at get assemblies (node_modules/frida-il2cpp-bridge/dist/il2cpp/structs/domain.js:17)
    at call (native)
    at <anonymous> (node_modules/decorator-cache-getter/dist/index.js:9)
    at <anonymous> (agent/index.ts:1)
    at call (native)
    at o (node_modules/browser-pack/_prelude.js:1)
    at r (node_modules/browser-pack/_prelude.js:1)
    at <eval> (/_agent.js:6196)
[Pixel 4::com.example.app]-> Process terminated

@dvgmdvgm I'm using qemu (the one that comes with android studio), i had used android x86 and genymotion in the past, I could try them...

@vfsfitvnm Gotcha.. How bout output? Gave any hints?

Not very helpful at all - don't worry about that.
Just downloaded genymotion, it doesn't provide android 12 images

i try frida-il2cpp-bridge on A12 yesterday and it was working fine.
Maybe the issue is on your device?

@Rewtio
Uh, did you spawn the app, or just attached to it?
Also, what's your A12 ROM?

@Rewtio and what's device?

@Rewtio Uh, did you spawn the app, or just attached to it? Also, what's your A12 ROM?

Just attach into it

@dvgmdvgm fixed in 0.7.5


GH-383 Split out Orchestration contract and refactors

Fixes #383

Applied to main (=2.1) and branch 2.0.


Brownfield is not calling the template correctly

This fixes an a missing variable issue when it comes to a brownfield deployment and allows for the correct stack to be called when asking for cloudformation outputs.

LGTM


@scope rule is defined in an official working draft spec

It would also be great if a search for 'scope' would produce this as the top result, instead of the deprecated 2014 feature. Is that possible?

Thanks! Yes, let me see what I can do about the ordering.

Okay, https://caniuse.com/css-cascade-scope comes in first now, I also renamed the deprecated feature "Scoped attribute" to help clarify the difference.


Do not omit From: line for single-patch contributions

When sending a patch on behalf of somebody else, the first line of the mail body should be the appropriate From: line.
In GitGitGadget, we special-case the cover letter not to include such a line. However, if there is only a single mail without any cover letter, the current code mistakes it for being the cover letter, and consequently omits the From: line, misattributing the authorship.
That happened in this contribution (which made it into git.git as https://github.com/git/git/commit/49e268e23e313e8c6b009cd8ebbbaae4316cf6cc).
This PR fixes that.

Thanks @webstech!


Can't schedule backup before 10:00 AM

Summary

When I set a DB_DUMP_BEGIN value without four digits (500), I get an error "_BACKUP_BEGIN is invalid - Unable to perform scheduling". If I set it to 0500, I get the same error. It doesn't seem to like the leading zero.
Steps to reproduce

Do the normal setup for dbbackup configuration.
Set the value for DB_DUMP_BEGIN to 0500 (or any other value before 10 AM)
Start the container.

What is the expected correct behavior?
Should correctly schedule the backup and run the backup at the specified time.
Relevant logs and/or screenshots

Image:  tiredofit/db-backup | Version  4.1.4 Type 'image_changelog' for details
Repository/Documentation: https://github.com/tiredofit/docker-db-backup/
License: MIT | © 2024 Dave Conroy
If this image provides you value  - Consider sponsoring my work for continued
development, timely updates, and feature requests. Commercial support available.
                    More Info:  https://www.tiredofit.ca
2024-09-27.13:22:27 [NOTICE] ** [monitoring] Container configured for monitoring with 'zabbix modern'
2024-09-27.13:22:28 [NOTICE] ** [scheduling] Container configured for scheduled tasks with 'cron'
2024-09-27.13:22:28 [NOTICE] ** [messaging] Container configured to route mail via SMTP to 'postfix-relay'
2024-09-27.13:22:29 [WARN] ** [db-backup01-scheduler] Deprecated and unsupported variable 'DB_DUMP_BEGIN' detected - Please upgrade your variables as they will be removed in version 4.3.0
2024-09-27.13:22:29 [WARN] ** [db-backup01-scheduler] Deprecated and unsupported variable 'DB_DUMP_FREQ' detected - Please upgrade your variables as they will be removed in version 4.3.0
2024-09-27.13:22:29 [STARTING] ** [monitoring] [1] Starting Zabbix Agent (modern) 7.0.2
2024-09-27.13:22:29 [WARN] ** [db-backup01-scheduler] Legacy unsupported variable 'CHECKSUM' detected - Please upgrade your variables as they will be removed in version 4.3.0
2024-09-27.13:22:29 [STARTING] ** [scheduling] [1] Starting cron
2024-09-27.13:22:29 [WARN] ** [db-backup01-scheduler] Legacy unsupported variable 'COMPRESSION' detected - Please upgrade your variables as they will be removed in version 4.3.0
2024-09-27.13:22:30 [WARN] ** [db-backup01-scheduler] Legacy unsupported variable 'SPLIT_DB' detected - Please upgrade your variables as they will be removed in version 4.3.0
2024-09-27.13:22:31 [ERROR] ** [01-db-gitea__gitea] _BACKUP_BEGIN is invalid - Unable to perform scheduling
        Valid Methods:
          +(number)             - Start in however many minutes
          HHMM                  - Start at hour (00-24) and minute (00-59)
          YYYY-MM-DD HH:mm:ss   - Start at a specific date and time
          0 23 * * *            - Cron expression
2024-09-27.13:22:31 [ERROR] ** [01-db-gitea__gitea] Stopping backup_scheduler 01 due to detected errors. Fix and restart container.

Environment

Image version / tag:  4.14
Host OS: Linux (synology NAS)

```
db-backup-gitea:
    container_name: db-backup-gitea
    hostname: db-backup-gitea
    image: tiredofit/db-backup
    links:
      - db-gitea
    depends_on:
      - db-gitea
    volumes:
      - /volume1/Backups/gitea:/backup
    labels:
      - "com.centurylinklabs.watchtower.enable=true"
    environment:
      TZ: America/Chicago
      DB_TYPE : mariadb
      DB_HOST : db-gitea
      DB_NAME : ${MYSQL_DATABASE}
      DB_USER : root
      DB_PASS : "${MYSQL_ROOT_PASSWORD}"
      DB_DUMP_FREQ : 1440
      DB_DUMP_BEGIN : 345
      DB_CLEANUP_TIME : 8640
      CHECKSUM : SHA1
      COMPRESSION : ZSTD
      SPLIT_DB : FALSE
    restart: unless-stopped
    networks:
      gitea:
```

Possible fixes
I suspect this is probably just a one-off parsing error. It may also be that I'm misunderstanding the error message.

a) you may wanna update your legacy variables
b) time format is HHMM which is four digits
c) see https://github.com/tiredofit/docker-db-backup?tab=readme-ov-file#scheduling-options

You may need to wrap your DEFAULT_BACKUP_BEGIN value in quotes for it to properly parse. There have been reports of backups that start with a 0 get converted into a different format which will not allow the timer to start at the correct time.


FN - Permit

Hi team,
Sharing a recent phishing the SD was not able to catch.

Here tx
This seems to be the permitted address.

Here another one.

Here the tx.

Here the permitted address

Fixed in the last SD update.


Add Thread Naming Support

Motivation
Parallelization is nice for performance, but can complicate debugging if things go wrong.
Ideally, all our threads should have names to help us during debugging to figure out which kind of tasks are executed on a specific problematic (hanging, failing, ...) thread.
With our previous mechanisms for parallelization, i.e. the ThreadManager, it was possible to provide a name when submitting a task:
engine.getFromEngineContext(ThreadManager.class).submitTask("loadGame", () -> {...})

With the currently ongoing transition to Reactor, the question is, whether RxJava provides a similar concept.
Proposal
@keturn mentioned:

there is a subscriber Context that is useful for things like this.

and

https://github.com/MovingBlocks/Terasology/pull/4839 added a GameScheduler::scheduleParallel method that takes a name which it uses in the same way as ThreadManager::submitTask did. It doesn't address future use cases where we take advantage of Flux's model for pipelines, but it suffices for one-shot Runnables like this.

Additional notes
Related PRs & Issues:

https://github.com/MovingBlocks/Terasology/pull/4547
https://github.com/MovingBlocks/Terasology/pull/4839
https://github.com/MovingBlocks/Terasology/pull/4799

We have code for resolve this issue...
But i wrote it in  #4865
See GameScheduler.java and any usage

@DarkWeird That's great, and definitely something we overlooked!
Maybe we can take out (some of) the changes to GameScheduler into a smaller PR and get that merged separately. Then we can most likely call this done pretty fast.


Want to add CONTRIBUTING.md file

What would you like to share?
I want to add a CONTRIBUTING.md file. It will help the contributors to abide by the guidelines of contributing to any open source project. Please assign the issue to me.
Additional information
No response

Please assign me this task i am intrested in it

I am interested in doing this task, hoping I can still contribute!

Yes


[Question] What do i need to do to not crop values? Also why is my second graph so small but gets larger if there are more entries?

What i use for both is this
new LineChart { Entries = entries, MinValue = minVal - 0.5f, MaxValue = maxVal + 0.5f, Margin = margin, LabelTextSize = labelSize, PointSize = pointSize,
                          ValueLabelOrientation = Microcharts.Orientation.Horizontal, LabelOrientation = Microcharts.Orientation.Horizontal  };

I'm searching for a solution for second graph. Did anyone already found a solution?


Fix some typos and inconsistent symbols in Soundness

I also tried adding the missing backticks but then it doesn't work with Markdown syntax (see ShreckYe@b991fca66f799e640f8dae0302344bef2190feb9).

I don't think that renaming the function to ext-`⊑ is the solution? Could you explain why you've made the changes that you've made?

Sure. I did this because the subset symbol for Envs is `⊑, and I thought the ⊑′ in ext-⊑′ is `⊑ mistyped. It is still kind of inconsistent.

BTW, thanks for teaching me how to include a backtick inside an inline code block. 😂


Factorial Support

It would be nice to be able to get the factorial of a number with a single operation!
(i.e., given n =10, return 10 * 9 * 8 * 7 * 6 * 5 * 4 * 3 * 2 * 1, or for n = 3, returns 3 * 2 * 1)

[ ] Add Factorials
[ ] Make 'em fancy
[ ] ????
[ ] Profit

Good idea! I'll work on implementing this functionality.


Injection failed

Enter training mode.
Run Skin_Injector.exe as an administrator.
Click OK, then press the Home key.
The program displays injection failure.

League might have been updated and patterns need to be updated. This usually happens when there is an "unsupported" model in your game.

@hydy100 yes sir i have the same problem since the 14.16 update

I pulled the 14.16 version and while i rebuild i get this old app icon

and i have same issue

there is a small issue with the 14.16 version it's that when your champion dies your skin reverts back to normal


rm watch cm

This PR removes the logic in the controller that watches for changes in the configmaps. The configmaps weren't getting created properly when registering the service in goalert and as result, CGAO wasn't able to retrieve the service IDs from the configmaps when de-registering clusters from goalert

Codecov Report

Merging #37 (4cc8893) into main (5122265) will increase coverage by 0.70%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   10.53%   11.23%   +0.70%
==========================================
  Files          11       11
  Lines         655      614      -41
==========================================
  Hits           69       69
+ Misses        577      536      -41
  Partials        9        9

Files Changed
Coverage Δ

controllers/goalertintegration/event_handlers.go
0.00% <ø> (ø)

...oalertintegration/goalertintegration_controller.go
0.00% <0.00%> (ø)

/lgtm

/approve


Autodiscover of use cases

Before submitting a pull request, please read
https://github.com/bancolombia/scaffold-clean-architecture/wiki/Contributing
Description

Category

[x] Feature
[ ] Fix

Checklist

[x] The pull request is complete according to the guide of contributing
[x] Automated tests are written
[x] The documentation is up-to-date
[x] the version of the readme.md, Constants.java and gradle.properties was increased
[ ] The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog

Please update plugin version in the Readme file.


Bluetooth Door / Window Sensors not working with v1.3.0 - 2021-07-28

After updating to v1.3.0 - 2021-07-28 all of my Aqara Door and Window Sensor stopped working, reverting back to 1.2.3 solved the issue.

my door sensor (bluetooth) on 1.2.3version is unavailabke...

Fixed in v1.4.1


Comic Neue Bruv

Please don't give me bone hurting juice.
http://comicneue.com/

luv 2 hurt bones, sry.


query recursion check doesn't clean up properly when it throws.

Rationale
Customer started hitting the recursion limit check inconsistently with the same query.  That behavior is consistent with the discovered bug.
Are we still hot-fixing 23.11?
Related Pull Requests

Changes

We could do a hotfix if release triage approves it. Do you have an issue number?

Sorry, didn't have bug yet when I created the PR.  There is a 24.3 version as well.


Message 'Metadata complete' should be displayed only once

This message gets displayed every time you update a metadata element when the resource has all required metadata. The message should only be displayed once when resource has all the required metadata the first time.

@mauriel133 and @pkdash - has this been resolved?

No

I just tried to test this on beta.hydroshare.org. I deleted the Abstract element for an existing resource and then tried to click "Save Changes" and got the following error:

Shouldn't I be able to delete the Abstract and then save the resource?
Then, I tried by creating a new resource. I created a title, an abstract and then added a keyword. I get the message that the metadata are sufficient to be made public or publish. Then I add another keyword and the message appears again.
This one has not been fixed.

Deleting of title and abstract are not allowed as they are required elements. Deleting of core metadata works only for keywords (there has to be one keyword), contributors, creators (there has to be one creator), key/value metadata, relation and source elements.

@pkdash - OK. Can we just change the message that goes with deleting the Abstract to something like:
"The Abstract is a required metadata element. Please add an Abstract to your resource."

This issue wrongly got listed to test for AGU release. No work has been done to address it yet. Related work I did was to address #1073. Based on what I have done to address #1073, this issue would be easier to address.

@horsburgh
This is how I am planning to resolve this issue:

The alert message "Resource Status: This resource can be published or made public" will appear only if the resource has not been set to public and it meets the requirement to be set to public.
This alert message will appear only onetime when you update/add metadata and the system recognizes that the resource meets the requirements for the resource to be set public or publish. This restriction of displaying the alert onetime is limited to page being not refreshed.

User creates a generic resource with one file. Then starts adding the title. No status alert message at this point. User adds the abstract. No status alert. User adds a keyword. User will see the status alert. User updates the title or abstract or ads another keyword - no status alert. User refreshes the page for the same resource. Trying to update any metadata element will show the alert. However, repeated updates will not show the alert. User set the resource to public which refreshes the page. At this point any metadata update will not show the status alert.  User set the resource to private or discoverable which reloads the page. Any metadata editing for the first time after the page reload will show the status alert.

@pkdash - this seems reasonable.

This has been addressed. So closing.


Implement header-included state root hash

Make a separate branch based on #1385 that implements header-included state root hash (with block H carrying state root hash for H-1). Remove P2P state exchange messages (they're not needed after this), add state root hash into PrepareRequest (check it on backups and fail on mismatch) and the final block. Check it during block processing, fail on mismatch.

Implemented as an option, merged.


added postgres db setup steps

Added steps required to setup postgres database.
Changes include:

Relevant config lines in the config.py file,
Added required  dependency for communication with postgres db: psycopg2-binary to requirements.txt
Updated readme (section PostgreSQL

Thanks for the PR and taking initiative! I added a few more comments with the intent to make the Postgres steps more clear. Let me know what you think!

Cool, you  highlighted  few important points, I agree with them. Let me add these changes to a PR.


[Event Request] Codeunit 1535 "Approvals Mgmt." - OnBeforePrePostApprovalCheckPurch

Hi, would it be possible to modify the OnBeforePrePostApprovalCheckPurch event in codeunit 1535 (Approvals Mgmt.) by adding the IsHandled parameter, like this:
    procedure PrePostApprovalCheckPurch(var PurchaseHeader: Record "Purchase Header"): Boolean
    var
        IsHandled: Boolean;
    begin
        // Modified Event begin
        // OnBeforePrePostApprovalCheckPurch(PurchaseHeader);
        IsHandled := false;
        OnBeforePrePostApprovalCheckPurch(PurchaseHeader, IsHandled);
        if IsHandled then
            exit(true);
        // Modified Event end
        if IsPurchaseHeaderPendingApproval(PurchaseHeader) then
            Error(PurchPrePostCheckErr, PurchaseHeader."Document Type", PurchaseHeader."No.");

        exit(true);
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforePrePostApprovalCheckPurch(var PurchaseHeader: Record "Purchase Header"; var IsHandled: Boolean)
    begin
    end;

Thanks!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


SyntaxError: Unexpected strict mode reserved word

Not too sure a full example if needed for this. It appears that in non-ES6 capable browsers, we get an error:

SyntaxError: Unexpected strict mode reserved word

Its coming from this bit:
    showMonths: 1,
    static: false,
    time_24hr: false,

In particular the "static" part. Is it possible to rename it to something else, to get around this issue?
Cheers
Andy

Hi @youradds , could you please give more details about your report, following the new issue format below?
Thank you!

IF REPORTING A BUG, A REPRO LINK IS ABSOLUTELY NECESSARY
Fork this: https://jsfiddle.net/tj2Lo4z7/
Your Environment

flatpickr version used:
Browser name and version:
OS and version:

Hi,
Thanks for the follow up. An example browser would be:
UA string
Mozilla/5.0 (Linux; U; Android 4.0.3; fr-fr; LG-E610 Build/IML74K) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/534.30

Flatpickr version:

/* flatpickr v4.5.1, @license MIT */

I can't replicate the issue myself (as I don't have any browsers that don't support ES6), but I can see the error in Errorception.com (which is a tracker for catching client side errors)
Cheers
Andy

I see that most of the versions you cited were launched before or in 2011. I think it is safe to say that they are not supported by flatpickr. The assumed compatibility is: IE9 and up, Edge, iOS Safari 6+, Chrome 8+, Firefox 6+
Personally, I suggest you implement a fallback for browsers that don't support modern technology, if you must support them. Meaning that, if the usage for those browsers is in the 0.00...% range, the development effort might not be worth it.

This already is a fallback! I'm using Babel to create non-es6 versions with these scripts:
{
  "plugins": [
    "babel-plugin-transform-es2015-template-literals",
    "babel-plugin-transform-es2015-arrow-functions",
    "babel-polyfill"
   ]
}

It doesn't fix that error though.

@youradds if you have an idea of what we could do to fix this issue, please leave your thoughts here.

Hi,
The issue seems to be with the bare word "static". I wonder if maybe quoting it would help? ie
showMonths: 1,
"static": false,
time_24hr: false,

I will tweak it my end and see if the error crops up again
Cheers
Andy


[Build] fix Dashboards Jenkinsfile with new path and stage

Description
Path was updated for builds so it needed to be archived correctly
for a different stage to build properly. Also, stashed to a
nested stage so the stage name was incorrect for arm64.
Signed-off-by: Kawika Avilla<EMAIL_ADDRESS>Issues Resolved
Partial: https://github.com/opensearch-project/opensearch-build/issues/798
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #799 (50ec83a) into main (9bcb801) will decrease coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
- Coverage   91.02%   90.77%   -0.25%
==========================================
  Files          75       75
  Lines        2039     2039
==========================================
- Hits         1856     1851       -5
- Misses        183      188       +5

Impacted Files
Coverage Δ

src/system/temporary_directory.py
78.26% <0.00%> (-17.40%)
:arrow_down:

src/system/os.py
92.30% <0.00%> (-7.70%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bcb801...50ec83a. Read the comment docs.


ModuleNotFoundError: No module named 'seislib.tomography._ray_theory._tomography'

Hello,
I was going to test your software but I've encountered the following issue.
When importing the download package
from obspy import UTCDateTime as UTC
from seislib.an import downloader

stations_config = dict(network='II',
                       channel='BH*',
                       starttime=UTC(2020, 1, 1),
                       endtime=UTC(2021, 1, 1),
                       includerestricted=False,
                       maxlatitude=12,
                       minlatitude=-18,
                       minlongitude=90,
                       maxlongitude=140)

I get the following error:
ModuleNotFoundError                       Traceback (most recent call last)
Cell In [1], line 2
      1 from obspy import UTCDateTime as UTC
----> 2 from seislib.an import downloader
      4 stations_config = dict(network='II',
      5                        channel='BH*',
      6                        starttime=UTC(2020, 1, 1),
   (...)
     11                        minlongitude=90,
     12                        maxlongitude=140)

File ~\Anaconda3\envs\seislib\lib\site-packages\seislib\__init__.py:14
     12 import os
     13 from .__version__ import __version__
---> 14 from .tomography.grid import EqualAreaGrid
     15 from . import an
     16 from . import colormaps

File ~\Anaconda3\envs\seislib\lib\site-packages\seislib\tomography\__init__.py:27
      1 r"""
      2 ==============================================
      3 Seismic Tomography (:mod:`seislib.tomography`)
   (...)
     24     Implications of different approaches to tomographic modeling, JGR
     25 """
     26 from .grid import *
---> 27 from .tomography import *

File ~\Anaconda3\envs\seislib\lib\site-packages\seislib\tomography\tomography.py:70
     68 from seislib import colormaps as scm
     69 import seislib.plotting as plotting
---> 70 from seislib.tomography._ray_theory._tomography import _compile_coefficients
     71 from seislib.tomography._ray_theory._tomography import _refine_parameterization
     72 from seislib.tomography._ray_theory._tomography import _raypaths_per_pixel

ModuleNotFoundError: No module named 'seislib.tomography._ray_theory._tomography

I've reinstalled the environment several times without luck. Any hint?
Thank you

Hello,
The error points to the module tomography._ray_theory, which is written in Cython. You are getting this error because you were not able to compile the Cython code during the installation. This usually happens when you don't have GCC or similar.
On Linux, you would solve the issue as follows:
pip uninstall seislib
sudo apt update
sudo apt install build-essential
sudo apt-get install manpages-dev
pip install seislib

Alternatively, you could simply install GCC (lines 2-5 above), and then compile the Cython code manually. For example (replace "user_name" and "python3.7" with your actual user name and Python version):
cd /home/your_name/anaconda3/lib/python3.7/site-packages/seislib/tomography/_ray_theory
python setup_all.py build_ext --inplace

And SeisLib will be ready to use. An analogous procedure can be followed by Mac users.
Unfortunately, I did not test SeisLib on Windows, and I hope the above will work for you too. Eventually, may I please ask you to point out how you solved the issue?
Thank you in advance

Hello,
Thanks for getting back to me. Indeed, the problem was not having the C compiler installed.
I've sorted it by using WSL (Windows Subsystem for Linux). As you pointed out, manual installation of GCC is needed. Hopefully the performance does not drop much.
Best regards

Glad you fixed it. Thanks for sharing your solution.
Cheers


Docker registry

This PR adds the following thing:

make launch-registry and make clean-launch-registry which deploys a registry in the k8s cluster.
create-pipeline --push-images which will push the images referenced in the pipeline spec to the k8s registry

TODO:

make the registry assets part of pachctl deploy
make it possible to use the k8s add-on registry.

+1 for this functionality.  A huge improvement to the workflow.  If no one gets to it before me, I'm going to look through this code one night.  Thanks.

This is way cool!
I'd like us to get us in the habit of framing PRs from a user perspective (when applicable of course). If I was to take a swing at this one, I'd say something like:
"As a user ... having a private registry that pachctl updates when I create/update a pipeline allows me to seamlessly update my pipelines when my code is under active development"
Is that about right?

@sjezewski that's a reasonable framing of this PR. I don't think that's really going to work generally for PRs though. Just looking at the PRs we have open right now this is the only one that you can really frame like that. It probably fits better in the design stages of a new feature, which this PR should have included, my bad on that one.

That makes sense. Especially since we want to get PRs to be in as small / digestible chunks as we can. And those won't always correspond to 'user facing things' in and of themselves.
One nice side effect of framing it for a user is that it highlights how much work we're doing is directly user facing vs technical debt etc.
And by 'design phase' you mean an outline/discussion on the GH issue right? I know sometimes we use gdocs which makes sense for a discussion, but since our code (and GH) is our interface to our users, I think it's worth getting in the habit of framing things here on GH (even if only in summary).

The make launch-registry stuff was the first initial way I was spinning up the registry, will remove it now that the registry is part of deployment.
Vendored deps are changing because I added in go-dockerclient and it had a few dependencies that needed to be updated.
TODOS for this pr:

[ ] remove yaml manifests and make launch-registry target.
[ ] add storage for registry
[ ] regen + extend docs

I decided not to tackle adding storage to the registry in this PR. Getting that to work correctly on every provider would require a lot of work. And it's unclear exactly what the right way is on each provider since there are a few options. More over I don't think that productionized registry inside the cluster are really the best solution, people are probably better off using things like gcr if they're on gce or EC2 container registry for amazon.

This is ready for review.

Maybe down the line it would make sense to have a per-cluster config that points to the registry used for pipelines in that cluster? Then pachctl --push-image could just get this from the cluster.
Probably outside the scope of this PR, but just an idea

@msteffen 100% agree on that, we recently added a config file for pachctl stuff that would be a great place to put that. Gonna consider it outside the scope though.


Footer refacror: add blog link

update footer links to use www to avoid redirects
added a link to zopa blog to the about section

:tada: This PR is included in version 1.6.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Integrating support for retrieving the URI for thumbnails from sc:Collection Manifests (for MVWs)

Resolves #366

I think we should instead make sure the chosen thumbnail gets added to the collection manifest in Figgy. Curators are able to choose a thumbnail ID for a MVW and this would bypass that selection.

Deprecated in favor of https://github.com/pulibrary/figgy/pull/1425


Upgrade osmosis to v25.0.0

This will update osmosis to v25.0.0.
Proposal: https://www.mintscan.io/osmosis/proposals/782
Upgrade at block https://www.mintscan.io/osmosis/block/15753500
Estimated Time (UTC)May 15th 2024, 16:47:15+00:00

Pre-release image: ghcr.io/akash-network/cosmos-omnibus:v0.4.16-rc2-osmosis-v25.0.0


Add support for other datasources

It could be useful to add the configReader for hashicorp Vault or even a get Request

@Plawn thanks for your suggestion. I was actually planning on creating a second project that would do that. I'll let you know when I get started. Working on a few other things at the moment.


issubclass() arg 1 must be a class

Got another on the same tab but, this time, using musicgen.
File "C:\MusicGen\one-click-installers-tts-6.0\installer_files\env\lib\site-packages\omegaconf\dictconfig.py", line 241, in _s_validate_and_normalize_key
elif issubclass(key_type, Enum):
TypeError: issubclass() arg 1 must be a class

I haven't seen this one unfortunately. Could you provide a screenshot and some system into please?
Also let me know if you used any custom installation steps.

Sorry. My pc must be acting out. Last night I tried a few times with no success. Now it works fine. Thanks for the reply, though. You have an amazing project here!

No worries, I have seen Python fail unpredictably many times, so I understand the feeling.


[BUG] selenium open new tab

Describe the bug
It seems there is no way to open a new tab. I've examined all BROWSER ACTIONS block actions including open and switchToTab but none opens a new browser tab.
Expected behavior
It's expected there to be a way to open a new tab and then navigate to a URL. Or OB could have a new tab Checkbox in NAVIGATE block so by checking it, the browser should open a new tab and navigate to defined URL.
Version

Version 1.1.4#334

Additional context
Other possible ways include equip switchToTab to open a new tab if it does not exists Or add function keys like CTRL to sendKeys browser action so sending CTRL+T will open a new tab.

did you try Execute JS block
window.open('about:blank','_blank');

Please let us know if ReDDOOne's solution works, but it would be nice to have this implemented as a Browser Action.

@openbullet , yes, @ReDDOOne 's solution works perfectly. but as you said it would be nice to have NewTab and CloseTab(index) Browser Actions. I think these two actions are At least more frequent than Maximize and Minimize in day to day work with browsers ^-^


Integrate gptCache

Lets save some $$$ by implementing GPTcache
There is a docker image and I think it may already work with Redis
$ docker pull zilliz/gptcache:latest $ docker run -p 8000:8000 -it zilliz/gptcache:latest
Admin can use temperature settings to bypass cache.
Important: cache must maintain user privacy. Admin can add sitewide cache. This will make FAQ generation a breeze and cost nothing to retrieve cached info each time.

Unfortunately, this library does not support redis. Instead, you need to use mysql as a cache, and it only supports 'milvus', 'faiss', 'chromadb', and 'hnswlib' as vector databases.

Thanks, that was real fast! There is already an open issue for Redis integration https://github.com/zilliztech/GPTCache/issues/271
Let's hope our bet on Redis pays off! I will watch GPTCache


[FEATURE REQUEST] Change static Content-type header

Is your feature request related to a problem? Please describe.
When serving static content the application returns the file with the header Content-Type | application/zip.
My problem is that i've an .apk file. If you download the static content with the header content-type application/zip. the android browser adds .zip extension to the file.
If i could change that header to application/vnd.android.package-archive. The android browser should know that it's receiving an apk file.
Describe the solution you'd like
An option to change the content-type header for static files. Maybe the static middleware could use a different content-type header depending on file type? (https://svn.apache.org/repos/asf/httpd/httpd/trunk/docs/conf/mime.types)
Describe alternatives you've considered
Removing gzip from my config, only allowing static content.
Additional context
I just started using Roadrunner. It could be that there's already an option within roadrunner.
Using Roadrunner with symfony 4.4
rr version 2.3.1 (build time: 2021-06-30T10:16:05+0000, go1.16.5)
server:
  command: "php bin/console.php baldinof:roadrunner:worker"
  # If you are using symfony 5.3+ and the new Runtime component:
  # remove the previous `command` line above and uncomment the line below.
  # command: "php public/index.php"
  env:
    APP_RUNTIME: Baldinof\RoadRunnerBundle\Runtime\Runtime

http:
  address: <IP_ADDRESS>:9000
  middleware: ["static", "gzip" ]
  uploads:
    forbid: [ ".php", ".exe", ".bat" ]
  static:
    dir: "public"
    forbid: [ ".php", ".htaccess", ".json" ]
status:
  address: <IP_ADDRESS>:9010

logs:
  mode: production
  channels:
    http:
      level: debug # Log all http requests, set to info to disable
    server:
      level: info # Everything written to worker stderr is logged
      mode: raw
    metrics:
      level: error

Hey @Fichtme , thanks for the FR.
Do I understand correctly, that your application returns the .apk file, with the application/zip content-type header and you want to change this header in the RR plugin to the proper header for the .apk file according to the mime types ?

Yeah, that's exactly what i want. But if that's not possible maybe a workaround to define the header for each file type?

But, why you can't send the proper header from the application?


Cannot add private Nuget feed

Hello,
I use Visual Studio Tools for Docker and they use your script GetClrDbg.sh. In this script is generated NuGet.Config but when I need to use my private Nuget feed I don't have chance to add it.

@McMlok What are you trying to get from your private NuGet feed? The NuGet.config file generated by GetClrDbg.sh script is used by our own dotnet restore command to obtain the debugger binaries and should not be used for other nuget scenarios.

It's because I have problem with corporate proxy and we use our Nexus server as Nuget server for our private nugets and as proxy for nugets from nuget.org.

I will look into fixing this properly, but here is a quick workaround:

In your Dockerfile.debug there should be a reference to https://raw.githubusercontent.com/Microsoft/MIEngine/getclrdbg-release/scripts/GetClrDbg.sh. This is hosted from the getclrdbg-release branch of the MIEngine repository.
Fork MIEngine to your own repo, and update GetClrdDbg.sh to generate the NuGet.config that you need. Make sure you do the work in the getclrdbg-release branch, as this has the most up to date version of the script.
Change your Dockerfile.debug to point to the raw view of your new 1GetClrDbg.sh` script in your MIEngine repo.
Clean your solution and rebuild/redeploy.

Thanks, workaround works. But now VisualStudion cannot attach debugger. With message "Error calling docker-machine ip for docker machine default. Check to see if it is running and accepting connections.Security error." But this is another story.

@NCarlsonMsft or @dbreshears may be able to help you with your docker issue. I am going to mark this issue closed since docker is outside the scope of MIEngine.

@McMlok.    Are you using  Docker Toolbox or Docker For Windows?   If you replace "default" with empty string from Docker.props file in VS, does the issue go away?

I'm using Win7, VS2015 Update3, Docket toolbox  1.12. If I have empty string in props I can not build image. If I run project in release mode it is same but when I open browser manualy and navigate to docker host IP application runs. I think its some security settings on my corp PC, proxy, firewall, anti virus, global politics. But I cant find any clues where to search.


Update CLI for edge router policy changes. Pull in 0.7 edge changes. …

…Fixes GH-9.

We still need to consider pushing the ziti-edge-related CLI bits back into the ziti-edge repository, and turn the part of the ziti command that's present in ziti-cmd into just a shell that pulls those components into the cobra infrastructure.
When that's done, we can jettison the ziti-fabric CLI, and merge that into ziti fabric.

I added GH-11 to track this


Skill Response does not added to composer bot conversation in emulator

Hi,
I am using a middleware and messagerouter.sendtoconversationasync method, i am able to receive it in skill controller but the same is not listed in the bot response in emulator.
If anyone can provide me some support, it is great.

Hi @UmaPrelude , could you provide more details?  The bot doesn't reply anything but the message is received by SkillController, could your bot send the response successfully without configuring the middleware?

Hi @zidaneymar,
Thanks for your response. I am trying to have transfer to human agent as a skill and trying to call from composer bot.
As part of that i am using messagerouter to send messages.

I am able to pass an activity from composer bot to skill, able to process the skill and get back the response to skill controller sendtoconversationasync method of bot composer runtime.
But after this method is called nothing is happening. I am not able to see the response in the bot emulator window.
I

Hi @zidaneymar,
Thanks for your response. I am trying to have transfer to human agent as a skill and trying to call from composer bot.
As part of that i am using messagerouter to send messages.

I am able to pass an activity from composer bot to skill, able to process the skill and get back the response to skill controller sendtoconversationasync method of bot composer runtime.
But after this method is called nothing is happening. I am not able to see the response in the bot emulator window.
I

Could you please provide the manifest of your human agent skill? I set up a simple echo bot but can't repro this issue, Is that human agent skill developed by composer?

Hi @zidaneymar ,
The agent skill is not developed using composer.
My issue is from skillcontroller -sendtoconversationasync method the activity is not added to main bot conversation. I can see the conversation id is different when it is send to this method since it is coming from skill and the skill conversation id is dynamically created by skill factory.

@UmaPrelude , Is this agent skill a sample? Could I have a try on this agent skill, basically composer supports the skill developed by botframework, I'm not sure if composer supports calling other agent.
If you can share the link to this manifest or this skill itself ( set up instructions), it would be helpful for figuring out the reason.

I debugged this on my machine with an simple echo bot sample as a skill, the response from the echo bot triggered this method (ReplyToActivityAsync).

@UmaPrelude , Is this agent skill a sample? Could I have a try on this agent skill, basically composer supports the skill developed by botframework, I'm not sure if composer supports calling other agent.
If you can share the link to this manifest or this skill itself ( set up instructions), it would be helpful for figuring out the reason.

This skill is developed using bot framework, but not composer.
Since i am using sendtoconversation in message router it comes to sendtoconversation of skillcontroller, which is fine, but after that it is not working.

@UmaPrelude , Is this agent skill a sample? Could I have a try on this agent skill, basically composer supports the skill developed by botframework, I'm not sure if composer supports calling other agent.
If you can share the link to this manifest or this skill itself ( set up instructions), it would be helpful for figuring out the reason.

This skill is developed using bot framework, but not composer.
Since i am using sendtoconversation in message router it comes to sendtoconversation of skillcontroller, which is fine, but after that it is not working.

Not sure about the reason, maybe the skill is developed under an old version of bot framework.
I suggest to debug under botbuilder sdk and figure out what exactly happens after calling 'sendtoconversation '.
Here are the concrete steps:

Clone botbuilder dotnet repo.
Open Microsoft.Bot.Builder.sln
Click 'File' -> 'Add' -> 'Existing Project', and add 'Microsoft.BotFramework.Composer.Core' 'Microsoft.BotFramework.Composer.WebApp'
Remove the package dependencies of those two composer projects, then add 'Project Reference' to the botbuilder-sdk projects, this allow you to set breaking point in botuilder sdk and see what happens

The reference would look like this:

Thanks for your recommendation. I will check it.


New version: KRTirtho.Flemozi version 0.2.0

Pull request has been created with komac v2.1.0 :rocket:
Microsoft Reviewers: Open in CodeFlow

Enter a pull request number: 145586

Manifest has the following dependencies that were not validated; ensure that they are valid:
  - Packages
      Microsoft.VCRedist.2015+.x64
Manifest validation succeeded.
Found Flemozi [KRTirtho.Flemozi] Version 0.2.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
This package requires the following dependencies:
  - Packages
      Microsoft.VCRedist.2015+.x64
(1/1) Found Microsoft Visual C++ 2015-2022 Redistributable (x64) [Microsoft.VCRedist.2015+.x64] Version 14.40.33617.1
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://download.visualstudio.microsoft.com/download/pr/09ee6168-4ebc-4886-a058-a668f573a552/CAA8369F99545E84E0EA83CBE0C202408F3B3A038B2E1786BB048A837A9D1522/VC_redist.x64.exe
  ██████████████████████████████  24.2 MB / 24.2 MB
Successfully verified installer hash
Starting package install...
Successfully installed

Downloading https://github.com/KRTirtho/flemozi/releases/download/v0.2.0/Flemozi-windows-x86_64-setup.exe
  ██████████████████████████████  13.0 MB / 13.0 MB
Successfully verified installer hash
Starting package install...
Successfully installed

Name          : Flemozi version 0.2.0+3
Publisher     :
Version       : 0.2.0+3
ProductCode   : FBCAB0B1-8171-40FA-B28E-234B17743354_is1
Registry Path : Computer\HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\FBCAB0B1-8171-40FA-B28E-234B17743354_is1
Uninstall     : winget uninstall --id "FBCAB0B1-8171-40FA-B28E-234B17743354_is1"

Name          : Microsoft Visual C++ 2015-2022 Redistributable (x64) - 14.40.33617
Publisher     : Microsoft Corporation
Version       : 14.40.33617.1
ProductCode   : {551c9ee3-34e4-4f63-891b-7616e726a705}
Registry Path : Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall\{551c9ee3-34e4-4f63-891b-7616e726a705}
Uninstall     : winget uninstall --id "{551c9ee3-34e4-4f63-891b-7616e726a705}"

Press any key to continue . . .

Automatic Validation ended with:

2024-03-20 20:12:51.283 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(757)\WindowsPackageManager.dll!00007FFC2A4CC11F: (caller: 00007FFC2A258D6F) LogHr(1) tid(874) 8A15005E     Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!00007FFC2A3D2B08: (caller: 00007FFC2A47BC20) Exception(1) tid(874) 8A15005E ]
2024-03-20 20:12:51.283 [REPO] Failed to open available source: msstore
2024-03-20 20:12:54.345 [CLI ] Caught wil::ResultException: D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!00007FFC2A3D2B08: (caller: 00007FFC2A47BC20) Exception(1) tid(874) 8A15005E
2024-03-20 20:13:02.872 [FAIL] D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\RepositorySource.cpp(757)\WindowsPackageManager.dll!00007FFC0CD7C11F: (caller: 00007FFC0CB08D6F) LogHr(1) tid(b84) 8A15005E     Msg:[D:\a_work\1\s\external\pkg\src\AppInstallerRepositoryCore\Rest\Schema\HttpClientHelper.cpp(30)\WindowsPackageManager.dll!00007FFC0CC82B08: (caller: 00007FFC0CD2BC20) Exception(1) tid(b84) 8A15005E ]
2024-03-20 20:13:02.872 [REPO] Failed to open available source: msstore
2024-03-20 20:13:04.917 [CLI ] No suitable installer found for manifest Microsoft.VCRedist.2015+.x64 with version 14.40.33617.1

(Automated response - build 870.)

No suitable installer found for manifest Microsoft.VCRedist.2015+.x64 with version 14.40.33617.1

Is it trying to run on x86 when the installer says x64?

@wingetbot waivers Add Validation-Installation-Error

Hi @OfficialEsco,
This manifest adds Apps and Features entries that aren't present in previous PR versions. These entries should be added to the previous versions, or removed from this version.
(Automated response - build 870.)

Here u go #145586


[Workflow] Rollback capabilities when terminating a workflow.

In what area(s)?

/area runtime

/area operator

/area placement

/area docs

/area test-and-release

Describe the feature

When an workflow is terminated mid-execution this can leave the system in an inconsistent state.  The workflow should have another method that is called during termination that is able to clean up the side-effects of the the executing workflow.
Release Note

RELEASE NOTE:

/keep-alive


modify about page content

The About page content is complete.
Please note that I had to comment out lines 14 to 26, as well as the imported util, in RowImages.jsx file in order to use the RowImages component on the About Page. The desired effect is to only display the images (no heading, text, or icon).
Please review if these lines should be deleted.

I understand your concern. I should clarify that DK specifically requested the particular style (RowImages to be a row of 3 images only). The RowImages component would be used on the About and Gallery Pages.


creating a migration requires a database connection

Why does creating 2 files require a database connection? It isn't running them.
Really like what you've done so far. Keep up the great work!

Just simplicity, I could move the creation of file handler before checking for db data in main.rs actually

It would make sense to put it before but the code actually, I'll do it when i have time (or welcome a PR!)

https://github.com/Keats/dbmigrate/pull/10 should fix that

@sbditto85 it's in v0.2.4, sorry for the lateness completely forgot about it


CAMEL-15496: Headers and Properties support

The additional headers will be added on top of the existing headers
from the message.
The properties added are only basic AMQP properties as defined in the
{@link com.rabbitmq.client.AMQP.BasicProperties.Builder}. When the
message contains already these properties then will be considered and
these additional properties will be ignored.
Introduced a SimpleDataHolderBean to hold a hashmap for adding any
header. As with this fix though we can add any header, only
static/hard-coded values could be associated.
The rabbitmq AMQP basic properties constant keys should not
have dot or hyphen in their prefixes. This gives problem in trying to
retrieve the value due to fix of CAMEL-15394. Changed to underscore.

@oscerd/@davsclaus,
As part of this PR I created a file components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq/SimpleDataHolderBean.java  and this bean class is missing in the [camel-3.6.0](https://github.com/apache/camel/tree/camel-3.6.0/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq) and in the [master](https://github.com/apache/camel/tree/master/components/camel-rabbitmq/src/main/java/org/apache/camel/component/rabbitmq)

It has been removed https://github.com/apache/camel/commit/d376711c170500364025064799d8fcf6907c2fde#diff-b2917cb1b72d2ff1600107b5fd43fcd873c1b2dd8bcc7cb165259b3b3782d410

It has been removed d376711#diff-b2917cb1b72d2ff1600107b5fd43fcd873c1b2dd8bcc7cb165259b3b3782d410

ok. I wasn't aware of that..
From sink connector json configuration, how do I pass in the map?
I couldn't do that with the following configuration..
    "camel.sink.endpoint.additionalProperties": "#bean:addProperties",
    "camel.beans.addProperties": "#class:java.util.HashMap",
    "camel.beans.addProperties[CamelRabbitmqContentType]": "${file:/secrets/amqp.properties:analytics.content.type}",
    "camel.beans.addProperties[CamelRabbitmqContentEncoding]": "${file:/secrets/amqp.properties:analytics.content.encoding}",
    "camel.beans.addProperties[CamelRabbitmqAppId]": "${file:/secrets/amqp.properties:analytics.app.id}",

    "camel.sink.endpoint.additionalHeaders": "#bean:addHeaders",
    "camel.beans.addHeaders": "#class:java.util.HashMap",
    "camel.beans.addHeaders[MSG_TYPE]": "${file:/secrets/amqp.properties:analytics.msg.type}",
    "camel.beans.addHeaders[MSG_ORIGINATOR]": "${file:/secrets/amqp.properties:analytics.msg.originator}",
    "camel.beans.addHeaders[DESTINATION]": "${file:/secrets/amqp.properties:analytics.destination}",

It is not getting set.. Something that I miss ?

@oscerd / @davsclaus, Could you please let me know how I can set the HashMap entries via sink connector configuration?
I have tried these

The map is empty..

    "camel.sink.endpoint.additionalHeaders": "#bean:addHeaders",
    "camel.beans.addHeaders": "#class:java.util.HashMap",
    "camel.beans.addHeaders[MSG_TYPE]": "${file:/secrets/amqp.properties:analytics.msg.type}",
    "camel.beans.addHeaders[MSG_ORIGINATOR]": "${file:/secrets/amqp.properties:analytics.msg.originator}",
    "camel.beans.addHeaders[DESTINATION]": "${file:/secrets/amqp.properties:analytics.destination}",

I also tried by having my own class which extends from HashMap. Still only empty map is going in..

package aero.unifly.analytics.bean;

public class SimpleDataHolderBean extends java.util.HashMap<String, Object> {
}

    "camel.sink.endpoint.additionalHeaders": "#bean:addHeaders",
    "camel.beans.addHeaders": "#class:aero.unifly.analytics.bean.SimpleDataHolderBean",
    "camel.beans.addHeaders[MSG_TYPE]": "${file:/secrets/amqp.properties:analytics.msg.type}",
    "camel.beans.addHeaders[MSG_ORIGINATOR]": "${file:/secrets/amqp.properties:analytics.msg.originator}",
    "camel.beans.addHeaders[DESTINATION]": "${file:/secrets/amqp.properties:analytics.destination}",

When I do not have the #class, I get error No bean could be found in the registry for: addHeaders of type: java.util.Map

    "camel.sink.endpoint.additionalHeaders": "#bean:addHeaders",
    "camel.beans.addHeaders[MSG_TYPE]": "${file:/secrets/amqp.properties:analytics.msg.type}",
    "camel.beans.addHeaders[MSG_ORIGINATOR]": "${file:/secrets/amqp.properties:analytics.msg.originator}",
    "camel.beans.addHeaders[DESTINATION]": "${file:/secrets/amqp.properties:analytics.destination}",

Test case I am able to set the map in the camel context and use
    @Override
    protected CamelContext createCamelContext() throws Exception {
        CamelContext context = super.createCamelContext();

        myMap = new HashMap<>();
        myMap.put("k1", "v1");
        myMap.put("k2", 1L);

        context.getRegistry().bind("myMap", myMap);

        return context;
    }

    @Test
    public void testResolveParameter() throws Exception {
        @SuppressWarnings("unchecked")
        Map<String, Object> mapGot = EndpointHelper.resolveParameter(context, "#myMap", Map.class);
        assertSame(myMap, mapGot);
    }

Please let me know how I need to set the Map via the Connector Configuration.
Thanks and Kind Regards
Ganesh

What you're trying to do is a bit tricky, btw you can do in the following way:

Create an archetype starting from the original connector: https://camel.apache.org/camel-kafka-connector/latest/archetypes.html
Add the bean you want, for example the SimpleDataHolderBean in the generated project
Repackage the connector as normal connector and deploy it
Use the bean by referencing the class.

What you're trying to do is a bit tricky, btw you can do in the following way:

Create an archetype starting from the original connector: https://camel.apache.org/camel-kafka-connector/latest/archetypes.html
Add the bean you want, for example the SimpleDataHolderBean in the generated project
Repackage the connector as normal connector and deploy it
Use the bean by referencing the class.

Thanks @oscerd ..
I thought this is what I tried in step 2 ? Or am i missing something?

I don't know if you repackage the connector or you used the archetype, in your steps it's not reported, and by the way this is not related to camel, but to ckc, so this is not the correct place to discuss.

You can do exactly as in your PR, in the archetype add
package org.apache.camel.component.rabbitmq;

import java.util.HashMap;
import java.util.Map;

public class SimpleDataHolderBean {
    private Map<String, Object> mapData;

    public SimpleDataHolderBean() {
        this.mapData = new HashMap<>();
    }

    public Map<String, Object> getMapData() {
        return mapData;
    }

    public void setMapData(Map<String, Object> mapData) {
        this.mapData = mapData;
    }

    @Override
    public String toString() {
        return "SimpleDataHolderBean{" +
               "mapData=" + mapData +
               '}';
    }
}

and use it as class.

Or at least this is what you were doing originally.

Or at least this is what you were doing originally.

Thanks a lot. Will try it out as suggested...


Update scripts to enable vertx-sync

We should update the vertx scripts so they (optionally) allow vertx-sync to be easily enabled.
This means adding the javaagent as described here https://github.com/vert-x3/vertx-sync/blob/master/README.adoc
Also the debugging options.

The user can configure $JAVA_OPTS or $VERTX_OPTS for this.

True, but maybe we should make it simpler for them? Adding the javaagent path can be tricky and prone to error as it will have to reference the jar with the correct version in the lib directory.
We could change the script so it checked for a simple environment variable(e.g. ENABLE_SYNC) and if set then the script could add the -javaagent arg with the correct path.


Use client_secret for code exchange in Auth Code Flow

Hi there, thanks for bringing out this lib :+1:. I've been following #552 since I'm interested in Oidc code flow. Testing 1.6.0-beta-1, I ran into a missing client_secret during code exchange (_processCode) resulting on a invalid_client error.
Hence this small pull request which I tested against my AWS Cognito provider. client_secret settings wasn't widely used so that I hope it's ok calling it like I did.

Ah, good find. client secret is optional, and for most token servers they have a mechanism to not require it for the scenarios where it doesn't make sense. but i suspect some don't have that option. thanks!


Include karpenter namespace dependency check in docs/aws/README.md

Issue #, if available:
#184
Description of changes:
Setup procedure has a dependency on the karpenter namespace.
When following procedure prior to Karpenter installation, iamserviceaccount creation fails:
eksctl create iamserviceaccount --cluster ${CLUSTER_NAME} \
--name default \
--namespace karpenter \
--attach-policy-arn "arn:aws:iam::${AWS_ACCOUNT_ID}:policy/Karpenter" \
--override-existing-serviceaccounts \
--approve

PR updates https://github.com/awslabs/karpenter/blob/main/docs/aws/README.md to include step to create namespace where missing:
if ! kubectl get namespaces -o json | jq -r ".items[].metadata.name" | grep karpenter; then
  kubectl create namespace karpenter
fi

Note: Introducing karpenter namespace prior to running karpenter installation via Helm causes Helm install to fail.
See #184 for workarounds, including one that negates requirement to implement this PR:

Alternate (short-term) workaround:

Be prescriptive in instructing users to perform cloud provider configuration only after karpenter installation

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

I think it's Ok as a short-term workaround to mandate installation of Karpenter first, followed by auth.
It would serve to:

Prevent the requirement for this update
Defer any work required to remediate the Helm package to support/handle pre-existing karpenter namespace.

However, I do think that it is a little counter-intuitive to proceed in that order, and I think folks will tend to assume that auth should proceed Karpenter installation (as I did) - leading to inevitably tripping-over the Helm namespace problem.

I really dislike Helm's idempotency assumptions. I'll play around with Helm and --create-namespace to see what I can do.

I did a local test whereby I removed the namespace resource from the Helm manifest, and tested installing the chart (incl. --create-namespace) where the namespace was both pre-existing and not. Seemed to be Ok.
Thought: - for simplicity, probably best to hold off on this update until Helm modified. Then, with both changes (here and Helm) implemented simultaneously, we eliminate the need to be prescriptive about installation order of precedence.

The only issue with removing the namespace resource is that Kustomize relies on it for make apply. We could remove it just in the helm chart, but it's a bit messy. I wonder, if instead we could figure out a cleaner make apply that was smarter about namespaces.

Thinking a little more deeply on this, I'm also willing to consider replacing our kustomize workflows with helm, though controller-runtime's code generation relies on kustomize's overlay system.
I really would like to hear some end users point of view on this.

Hi @cameronsenese - I'm wondering if we should keep this open? It seems like the docs have changed a bit since then? Thanks!


Visit Counter

I want to make a visit counter website using JavaScript. For this I will be using count API.
Please assign me this issue.
Thank you.

@Harshit-Raj-14 issue assigned to you


Second diagram in the corpus section needs redrawing to replace references to common data model with CDM

There was a moment I think when a source document was edited by mistake to change all references to "cdm" to "common data model".  This diagram seems to have been changed in line with that.  Please review all references in the diagram to 'common data model' and verify if they should be replaced with the acronym, 'cdm' .  The imports statement shown is one example that should be cdm:/foundations.cdm.json, not as written currently

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 34d4ae87-6945-1f97-3181-6778400bb574
Version Independent ID: d14e498c-9b44-2c4f-ee6a-2b8fb01062ca
Content: Technical details of Common Data Model - Common Data Model
Content Source: common-data-model/sdk/fundamentals.md
Service: common-data-model
GitHub Login: @MSFTMan
Microsoft Alias: Deonhe

@billgib Thanks for reporting this issue. We'll get it fixed.


wasip2 support for spin go sdk

this adds wasip2 support for the go sdk. This is WIP PR, and I intend to add more functionality to it in coming days.
This currently use fork of wasm-tools-go as the fix for this issue is not merged yet

creating a list of things to be done to complete this work:
cc @adamreese
Features support required:

[ ] incoming http
[ ] outgoing http
[ ] kv store support
[ ] sqlite support
[ ] config support
[ ] sqlite
[ ] llm
[ ] mysql
[ ] pg

I will add to this list if I come across other things that needs to be done. please feel free to add to this list.
Thanks

closing this in favor of branch created in this repo itself.


rename sweep to transfer_onchain_funds

In order to avoid confusion about sweep which implies sending funds from the closing address to the internal wallet. By renaming it to withdraw we indicate that it is sending the funds out.

I find withdraw more confusing than sweep tbh. We have lnurl withdraw for example, which means receiving funds into your sdk balance. Withdrawing something is usually incoming. The terms deposit/withdraw are generally confusing and should be avoided altogether imo. Send and receive are clearer, because the direction is clear.
Sweep means claim onchain funds that are already yours. Since you cannot access your onchain funds through the sdk, and you have to provide an address, the ring for me is "claim funds that are already yours into this specific address".

I find withdraw more confusing than sweep tbh. We have lnurl withdraw for example, which means receiving funds into your sdk balance. Withdrawing something is usually incoming. The terms deposit/withdraw are generally confusing and should be avoided altogether imo. Send and receive are clearer, because the direction is clear.
Sweep means claim onchain funds that are already yours. Since you cannot access your onchain funds through the sdk, and you have to provide an address, the ring for me is "claim funds that are already yours into this specific address".

The problem is that "sweep" has a specific semantics in Lightning (moved funds from a closed channel to the node's wallet). Our API is different, it's about moving funds from the node's wallet to another BTC address. That's why "withdraw on-chain" or something would be better imo.

"transfer on chain funds"?

I agree with @JssDWt, withdraw can be confusing because it used elsewhere as an incoming/receiving action. I think transfer_onchain could work like @kingonly said

Not sure we can do better with transfer. I agree withdraw isn't great, but sweep is very confusing to Lightning devs and I don't think we should overload it with new semantics. Open to suggestions.

I agree that withdraw also can cause confusion since this is a lighting first sdk. One suggestion is to use transaction as it is reserved for on-chain and payment is reserved for lighting.
Suggestions  sweepTransaction or withdrawTransaction. Thought they might be a bit too verbose when combined eg.  PrepareWithdrawTransactionReqeust or PrepareSweepTransactionRequest.

It doesn't help. Sweep transaction is even worse because it refers to a very specific transaction (moving the funds from a closed channel to an the node's on-chain wallet). transfer_onchain_funds (which echo the 'unexpected funds' UI is the best option so far imo.

Since the last commit I've renamed the sweep to transfer_onchain_funds and prepare_sweep to prepare_transfer_onchain_funds.
Do we also wish to use the same type of unsigned integer for both of the methods?
Which of u32 or u64 is preferred?

u32 is the most commonly used for sat_per_vbyte.
My other options are remit_onchain or forward_onchain

To indicate we're dealing with onchain, we could include utxo in the name, like sweep_utxos or transfer_utxos.
One step further, to include directionality: transfer_utxos_to (although IMO sweep_utoxs includes direction and separates it from LN semantics).

on-chain is better and clearer than utxo.
transfer_onchain is still better the remit or forward.


Fix LOGGING test on Windows

Issue Number
#1115
Overview

71c8f3028cb3012d765327d3ecf9f83826a4df50
Fix LOGGING test on Windows

c3e9828c89b28bbc106951240a1e021b2fcd225f
chmod +x for test_scripts

Comments
Fixes test:
  2) CLI Specifications, LOGGING - cardano-wallet serve logging [SERIAL], LOGGING - Serve shuts down logging correctly
       "... a lot of logs here..." does not contain "Logging shutdown"

which now pass on Windows and Linux.

I think what's happening here is:

The directory check of /does-not-exist succeeds when it was assumed that it would fail (with a permissions error).
I tested the following two commands on Windows.
C:\Users\win\cw\tests>cardano-wallet-jormungandr.exe serve --database /does-not-exist --node-port 8081 --random-port --log-level DEBUG --genesis-block-hash  3c07030e36bfffe67e2e2ec09e5293d384637cd2f004356ef320f3fe6c52041a
[cardano-wallet:Info:3] [2020-01-10 05:50:40.99 UTC] Using directory: /does-not-exist
[cardano-wallet:Info:3] [2020-01-10 05:50:40.99 UTC] Running as v2020.1.7 (git revision: 21ee81799ffb815ddba756bd9d94640b789e969b)

C:\Users\win\cw\tests>cardano-wallet-jormungandr.exe serve --database /* --node-port 8081 --random-port --log-level DEBUG --genesis-block-hash  3c07030e36bfffe67e2e2ec09e5293d384637cd2f004356ef320f3fe6c52041a
[cardano-wallet:Info:3] [2020-01-10 05:50:53.69 UTC] Creating directory: /*
[cardano-wallet:Debug:3] [2020-01-10 05:50:53.69 UTC] Logging shutdown.
cardano-wallet-jormungandr.exe: \*: CreateDirectory "\\*": invalid argument (The filename, directory name, or volume label syntax is incorrect.)

In the first, C:\does-not-exist is created.

Rather than promptly exiting at an error, the 10 second wait in the test case lapses.

withCreateProcess cleans up the cardano-wallet-jormungandr.exe process (source).
Windows TerminateProcess does not give cardano-wallet a chance to shut down cleanly (indicated by "Logging shutdown" message).
From Win32 docs

If a process is terminated by TerminateProcess, all threads of the process are terminated immediately with no chance to run additional code. This means that the thread does not execute code in termination handler blocks.

So /* or any filename that is invalid on windows (e.g. /aux) would be sufficient. I pushed a comment to this PR. (Hopefully no developers are running tests with sudo. Otherwise they will actually end up with a directory /*. Then to remove this directory: rm -rf /* ... oops!)

/aux would achieve the same result as /* but looks more innocuous.

bors r+


chore(css-transform): replace postcss selector parsing with official library

This fixes #200

This is great - good job!


Automated Testing

Add automated test script run_tests.py.
This is based on the following branches:

sam_refactoring
sam_python_fixes
sam_travis

superseeded by #161


Icecup should output text inline

The wrinkle here is that switching output types needs to change the tables. Maybe override print()?

Done


Minor streamsearch test cleanup

@kibertoad Please stop opening these kinds of PRs and immediately closing them.

@mscdex Sorry for that. When creating pull request within a fork, GitHub defaults to opening a PR against the original repo, and there is no way to retarget back to the fork after that. I'll take a look if this is something that can be reconfigured.
My deep apologies for the inconvenience.
Btw, maybe you would be open to transferring npm package name busboy to fastify organization? We were planning to use @fastify namespace for the fixed busboy version, but if we could simply continue where original package left off, that would simplify the transition for entire ecosystem.


Dependency injection by type alias

Have you analyzed implementing Dependency injection by type alias?
object RedisCache { }
typealias Cache = RedisCache

If we need to change it
object MongoCache { }
typealias Cache = MongoCache

It is done in compile time

This is not a solution, because:

There are a lot of features of Kodein that can only exist at runtime.
Kodein cannot use code generation because it only exists for JVM (& Kodein is a multi-platform project)
DI is a lot more than assigning an implementation. It's about order of initialisation, transitive dependencies, scoping, etc.


Naming Problem.

First pic is from Anchorage, particularly at a time when Soldotna was unavailable. Second pic, and the worst case in my eyes, is of Minneapolis.

As you can tell, there are obvious repeats of the same city multiple times on the Latest Observations page. This makes it awfully confusing to others since they won't know which one is different. Please, rename them to reflect the district/airport they represent. Thank you.
With love,
Tom

I fixed the issue with the duplicate city names in version 1.37

vbguyny,  I would like to use this for my website and tv station and would like to know if you can modify specifically for my location.  When I tested with my zip code, the extended forecast, almanac and local radar did not appear automatically.  zip code 38401.  Your help would be greatly appreciated.  Not sure if I can contact you off here or not.  I was referred to you by danny jessee for help.

Hello @mlbailey1308! It looks like NOAA is returning a malformatted XML response to my site.  I'll see if I can implement a work around for this issue.  I am happy to hear that you will be using it for your website and TV station!  Do you mind telling me where I can find them?

Currently, we are  moving station to Columbia, TN and are off the air.  One of the things we want to do is have a new weather channel running  local news and local weather.  Can you provide a bug free setting for Columbia, TN, Springhill, TN,  Franklin, TN, Lewisburg, TN that we can use for our TV broadcast.  I know that the w4000 simulator can be used but I am not a coder or programmer and need assistance with this.  Please let me know if you can help and at what cost.
Thanks in advance for your response.
Maurice
On Wednesday, January 2, 2019, 8:58:34 PM EST, vbguyny<EMAIL_ADDRESS>wrote:

Hello @mlbailey1308! It looks like NOAA is returning a malformatted XML response to my site. I'll see if I can implement a work around for this issue. I am happy to hear that you will be using it for your website and TV station! Do you mind telling me where I can find them?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Gotcha.  Good luck in your station!
It looks like that from that list of cities you indicated that NOAA only reports Columbia, TN as having its own weather station.  The other cities will be pulling the weather from the nearest station according to NOAA.
As far as providing a "bug free" site, this is something that I cannot guarantee, mainly because:

I get information from 3rd party websites (NOAA, Wundground, etc) which can either go down or provide broken information (as in this case related to the issue you reported).
The website relies on a browser to render the information and some browsers display the information differently than others.
This site is more of a hobby than anything else. I already have a full time job so you might want to check out one of the forks to this repo.

That being said, I'm looking into fixing this specific bug and should be fixed soon. Thanks.

I totally understand.  Is it possible you could provide me with a copy of what you have developed just for Columbia, with the audio and looping?  That would be a big help if you can?
Maurice
On Wednesday, January 2, 2019, 9:45:49 PM EST, vbguyny<EMAIL_ADDRESS>wrote:

Gotcha. Good luck in your station!
It looks like that from that list of cities you indicated that NOAA only reports Columbia, TN as having its own weather station. The other cities will be pulling the weather from the nearest station according to NOAA.
As far as providing a "bug free" site, this is something that I cannot guarantee, mainly because:

I get information from 3rd party websites (NOAA, Wundground, etc) which can either go down or provide broken information (as in this case related to the issue you reported).
The website relies on a browser to render the information and some browsers display the information differently than others.
This site is more of a hobby than anything else. I already have a full time job so you might want to check out one of the forks to this repo.

That being said, I'm looking into fixing this specific bug and should be fixed soon. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Of course! Once I have fixed the bug, you can download the entire website's source code clicking on this link: https://github.com/vbguyny/ws4kp/archive/master.zip
You will need to have someone to help set it up on a server running IIS 7.5 or later with ASP.NET 4.5 or later (refer to https://github.com/vbguyny/ws4kp/blob/master/README.md)

Thank you so very much!
Maurice
On Wednesday, January 2, 2019, 9:58:07 PM EST, vbguyny<EMAIL_ADDRESS>wrote:

Of course! Once I have fixed the bug, you can download the entire website's source code clicking on this link: https://github.com/vbguyny/ws4kp/archive/master.zip
You will need to have someone to help set it up on a server running IIS 7.5 or later with ASP.NET 4.5 or later (refer to https://github.com/vbguyny/ws4kp/blob/master/README.md)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@mlbailey1308 this bug is fixed in version 1.39 which is now live: https://battaglia.ddns.net/twc/


error when trying to import cookies from file

when i tried to open a cookies.txt file in yt-dlp-compose, i got this error:

steps to reproduce:

open yt-dlp-compose
open settings
scroll down to "cookies from file"
click the page icon
see error

app version: snapshot 33
OS version: macOS 14.5

Oh good find. I was able to reproduce and this is the full stacktrace:
Exception in thread "AWT-EventQueue-0" java.lang.NoClassDefFoundError: sun/misc/Unsafe
	at org.lwjgl.system.MemoryUtil.getUnsafeInstance(MemoryUtil.java:2948)
	at org.lwjgl.system.MemoryUtil.<clinit>(MemoryUtil.java:112)
	at org.lwjgl.system.Pointer$Default.<clinit>(Pointer.java:67)
	at com.darkrockstudios.libraries.mpfilepicker.FileChooserKt.chooseFile(FileChooser.kt:11)
	at com.darkrockstudios.libraries.mpfilepicker.DesktopFilePickerKt$FilePicker$1.invokeSuspend(DesktopFilePicker.kt:31)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:104)
	at androidx.compose.ui.platform.FlushCoroutineDispatcher$flush$1.invoke(FlushCoroutineDispatcher.skiko.kt:90)
	at androidx.compose.ui.platform.FlushCoroutineDispatcher$flush$1.invoke(FlushCoroutineDispatcher.skiko.kt:78)
	at androidx.compose.ui.platform.FlushCoroutineDispatcher.performRun(FlushCoroutineDispatcher.skiko.kt:99)
	at androidx.compose.ui.platform.FlushCoroutineDispatcher.flush(FlushCoroutineDispatcher.skiko.kt:78)
	at androidx.compose.ui.scene.ComposeSceneRecomposer.performScheduledEffects(ComposeSceneRecomposer.skiko.kt:88)
	at androidx.compose.ui.scene.BaseComposeScene.render(BaseComposeScene.skiko.kt:165)
	at androidx.compose.ui.scene.ComposeSceneMediator$DesktopSkikoView.onRender(ComposeSceneMediator.desktop.kt:523)
	at org.jetbrains.skiko.SkiaLayer.update$skiko(SkiaLayer.awt.kt:548)
	at org.jetbrains.skiko.redrawer.AWTRedrawer.update(AWTRedrawer.kt:54)
	at org.jetbrains.skiko.redrawer.MetalRedrawer$frameDispatcher$1.invokeSuspend(MetalRedrawer.kt:82)
	at org.jetbrains.skiko.redrawer.MetalRedrawer$frameDispatcher$1.invoke(MetalRedrawer.kt)
	at org.jetbrains.skiko.redrawer.MetalRedrawer$frameDispatcher$1.invoke(MetalRedrawer.kt)
	at org.jetbrains.skiko.FrameDispatcher$job$1.invokeSuspend(FrameDispatcher.kt:33)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:104)
	at java.desktop/java.awt.event.InvocationEvent.dispatch(Unknown Source)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(Unknown Source)
	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
	at java.desktop/java.awt.EventQueue$4.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(Unknown Source)
	at java.desktop/java.awt.EventQueue.dispatchEvent(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(Unknown Source)
	at java.desktop/java.awt.EventDispatchThread.run(Unknown Source)
	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [androidx.compose.ui.scene.ComposeContainer$DesktopCoroutineExceptionHandler@5fd3e574, androidx.compose.runtime.BroadcastFrameClock@3491aa3b, StandaloneCoroutine{Cancelling}@853c518, FlushCoroutineDispatcher@24cdaeae]
Caused by: java.lang.ClassNotFoundException: sun.misc.Unsafe
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(Unknown Source)
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(Unknown Source)
	at java.base/java.lang.ClassLoader.loadClass(Unknown Source)
	... 35 more

It is caused by this issue: https://github.com/LWJGL/lwjgl3/issues/962
Looks like I have to configure something to include this in the jdk that jpackage bundles in the app

I tried the fix locally and it works on my machine ™ - Please also try snapshot-34 and let me know if it works now 😄

still gets stuck on downloading metadata once i paste a URL

I see, you could try running it via the terminal to get more logs, but I guess I will prioriise getting better errors logs

nevermind, i got it to work by deleting open video downloader and its support files. i figured the yt-dlp installations were conflicting with each other lol


execution reverted while bridging

was sending 0.001 at https://bridgetozora.world and finally got
https://goerli.etherscan.io/tx/0x94596956b3d7ab6cb8c779b4e5fde4e16d36ca4335d554b6f84ececda0234d8d

0x60754b8c48bcd1754e71323b044d51e07cd73a4708f32204ad2f1b2b4fb458a9
was bridging 0.1 gEth but it failed

0xf3dadb940d23b9430917dc74c5b91e855c308c3fc0472bbf47f9316cfa3ed423
then i bridged 0.15 gEth and it also failed


Generation of Shared Libraries

Hello,
I generated the bit and tcl-file for a value of PEs and SIMDs. Then, I changed the bnn.py-class on the PYNQ to feature a new network attribute, but now I have the problem that I am missing the Shared-Object-Libraries for that attribute.
I did this, so I can keep the unchanged bit- and tcl-files on the board for comparison.
How can I create this library for the new attribute? Or to rephrase the question, how are those libraries created in the first place? I am new to CFFi, any advice would help.
Thank you for your help
Kind regards

I don't think I've understood your question, but the make-sw.sh available here is the script used to compile (on the board) the shared object linked from bnn.py  python class.
In order to compile the .so on the board you need to move the include folder available in your Vivado HLS installation path on the board and set the env variable VIVADOHLS_INCLUDE_PATH to the absolute path.

Ok, I created the new .bit and .tcl-files (PE = [32, 32, 32, 16]) and put them in the /usr/local/lib/python3.6/dist-packages/bnn/bitstreams-directory. I renamed the existing lfcW1A1-pynqZ1-Z2.*-files, and named the new generated ones as  lfcW1A1-pynqZ1-Z2.*. I then changed the parameters in .../params/mnist/lfcW1A1 to the ones, which I generated with the adapted gen-weights-lfcW1A1.py.
If I try to start inference, the kernel dies.
I hope that I did not forget to share important information this time.
Thank you for your help.

Have you changed the interface of the top function in HLS?

No, I did not change the top function.
I did recompile using make-sw.sh, but I  did indeed forget to change the config.h. I recompiled it now with the new config.h on the board.

Nothing to change in the top function. Does the new .so fixed your problem?

Ok, good. I thought maybe I missed something.
I copied the new lfcW1A1-pynqZ1-Z2 from ../bnn/src/network/output/sw to ../bnn/libraries/pynqZ1-Z2/ and tried to do inference again, but the kernel still dies at the same step. So it did not fix the problem.

you should move the freshly compiled  .so under /usr/local/lib/python3.6/dist-packages/bnn/libraries/pynqZ1-Z2/

Ok, so if you launched the make-hw.sh script after having changed the params, that means that Vivado HLS csim has passed.
Can you please check what error is raised by checking /var/log/jupyter.log?

this entry is made when the kernel dies:
... NotebookApp] Adapting to protocol v5.1 for kernel ff75a513-9aa5-426b-b30d-c46b1c751c0d
terminate called after throwing an isntance of 'char const*'

Have you tried with the latest update?

I'm having the same problem. I trained the network for a different precision, the weights and the config.h were generated. I also modified the top.cpp to adapt the network a different precision. I run successfully the Synthesis in the Vivado HLS and the bitstream generation in Vivado. I followed the steps to generate de shared libraries and I made it. But, when I load the shared libraries and the parameters by using the bnn.CnvClassifier, the kernel dies.
Any help would be useful.

@gsr-ee Have you recompiled the .so file for the host?

No, didn't do that.
I'll talk you through what I've done. Hope you can help me.
First, I've changed the precision of the layers and the precisions of the weight type following the instructions here. I used 1 bit for integer and 1 bit for fractional. Then, I trained the network with my own dataset and I generated the binary weights files and put them into a new folder in /bnn/params (I did the same on the cnvW2A2 and it worked well). I made use of the files in /bnn/src/network/cnvW2A2/ to generate de shared libraries for the new network, which I called cnvW11A11. I made a fork of the project here.
Last but not least, I tried to load the shared libraries and the parameters on a new notebook file by using the bnn.CnvClassifier e this error ocurred.

@giuliogamba Hi, I am new to HLS. What does "make-sw.sh" do? Does it generate drivers? How can "g++" used in "make-sw.sh" generate drivers for FPGA?

@Maximilianxu when executed on the PYNQ board, the make-sw.sh compiles shared objects that are used from the bnn python class.
When executed in the python_hw mode it does generate the drivers communicating with the hardware accelerator.


Verification failure when 4 or less signatures are aggregated.

https://github.com/thehubbleproject/hubble-contracts/blob/3c6e39b2b0f1b7969ae4be90fdb4fa0036735644/test/fast/bls.test.ts#L67
I didn't come across a documented minimum.
Steps:

set n = 4 (or 2, 3)
run tests

Result: Verification fails. Expect: Verification to succeed

Nice catch! Looks like the miscalculation of the gas cost cause it.
https://github.com/ethereum/go-ethereum/blob/master/params/protocol_params.go#L127

Nice catch! Looks like the miscalculation of the gas cost cause it.
https://github.com/ethereum/go-ethereum/blob/master/params/protocol_params.go#L127

Sending a fix #418. Thank you @jzaki for finding this issue

Sending a fix #418. Thank you @jzaki for finding this issue

Fixed in #418. Feel free to reopen if you find it doesn't work

Fixed in #418. Feel free to reopen if you find it doesn't work


Fix indentation.

For whatever reason rustfmt didn't fix this on its own.

Something fishy is going on:
$ tail -n 1 Cargo.toml
members = ["generator", "xcbgen-rs", "cairo-example"]
$ cargo fmt -p generator -- --check
package `generator` is not a member of the workspace
cargo-fmt 1.4.12
This utility formats all bin and lib files of the current crate using rustfmt.

USAGE:
    cargo fmt [FLAGS] [OPTIONS] [-- <rustfmt-options>...]
[...]

$ cargo fmt -p xcbgen-rs -- --check
package `xcbgen-rs` is not a member of the workspace

Is this worth a bug report against rustfmt?
I tried to come up with a small reproducer, but so far I failed. All I know is that the -p flag does not behave as I would expect and that this is something about out.indented. Anything in the closure is ignored by rustfmt.

Something fishy is going on:
$ tail -n 1 Cargo.toml
members = ["generator", "xcbgen-rs", "cairo-example"]
$ cargo fmt -p generator -- --check
package `generator` is not a member of the workspace
cargo-fmt 1.4.12
This utility formats all bin and lib files of the current crate using rustfmt.

USAGE:
    cargo fmt [FLAGS] [OPTIONS] [-- <rustfmt-options>...]
[...]

$ cargo fmt -p xcbgen-rs -- --check
package `xcbgen-rs` is not a member of the workspace

Edit: Removed my previous edits. PEBKAC.

That's because generator is x11rb-generator and xcbgen-rs is xcbgen. The -p flags needs the value of [package] name = in Cargo.toml.


Support WebSocket's protocol parameter

Hello,
Thankyou for the great works, I need help on documentation about how to define websocket protocol parameter like this one:
var exampleSocket = new WebSocket("ws://www.example.com/socketserver", "protocolOne");
Where should I declare that?
Please help, thank you.

This will be in version 3, out later today.

Almost finished the work on this, will be out very soon.

Version 3.0.0 has just been published to npm with support for protocols.


to_graph method for GraphMaps?

GraphMaps are nice because they are generally easier to construct than Graphs. Unfortunately, most algorithms work only on Graph objects. Would it make sense to add a method to easily create an equivalent Graph to GraphMap? Then one could have the best of both worlds: easy graph construction using GraphMap::from_edges, and access to the full range of algo's!

Oh, and of course thanks for making/ maintaining this library! It is pretty dope.

Great! :smile:
Ok, that's an interesting idea that didn't cross my mind.
Please look at this GraphBuilder struct https://github.com/bluss/petulant-avenger-graphlibrary/blob/builder/src/builder.rs  (that's on a temporary branch).
So the question is, is a dedicated GraphBuilder thing better? Can GraphMap do both duties?

I've also of course implemented a directed GraphMap on some branch. Maybe GraphMap is enough with that, then it could build directed graphs too.


[cleanup][client] Cleanup the creation ssl context

Signed-off-by: Zixuan Liu<EMAIL_ADDRESS>Motivation
Remove duplicate code.
Modifications

Packaging the create ssl context to ClientConfigurationData
Update tls cert and key, the old cert doesn't include the X509v3 Subject Alternative Name filed, this causes the General OpenSslEngine problem error, check out here. The previous test passed because of the allowInsecureConnection=true

Documentation

[x] no-need-doc

@nodece - thanks for your contribution. This PR has merge conflicts. Are you able to resolve those, and then I'll review this?

Hi @michaeljmarshall, this CI has been passed, could you review this PR?


GPU implementation

Do you plan on making a pure GPU implementation of facenet?

I assume that you are refering to the triplet selection algorithm. Currently there are no plans for a GPU implementation of that.


Preparing for Scala 2.12

Unresolved dependencies for a scala-2.12.0-M4 build.  Not yet exhaustive, because it can't get past these for deeper modules:

[x] org.http4s#http4s-websocket_2.12.0-M4;0.1.3: not found
[x] org.log4s#log4s_2.12.0-M4;1.1.5: not found
[ ] org.parboiled#parboiled_2.12.0-M4;2.1.1: not found
[x] org.scalaz.stream#scalaz-stream_2.12.0-M4;0.8: not found
[ ] org.scoverage#scalac-scoverage-plugin_2.12.0-M4;1.1.0: not found
[ ] org.scoverage#scalac-scoverage-runtime_2.12.0-M4;1.1.0: not found
[x] org.specs2#specs2-core_2.12.0-M4;3.7.2-scalaz-7.1.7: not found
[x] org.specs2#specs2-matcher-extra_2.12.0-M4;3.7.2-scalaz-7.1.7: not found
[ ] org.specs2#specs2-scalacheck_2.12.0-M4;3.7.2-scalaz-7.1.7: not found
[ ] org.typelevel#discipline_2.12.0-M4;0.4: not found

@rossabaker, I believe this is complete. I'll close this in a day or so unless you let me know I'm wrong.

🏁


Make BlogPage example tutorial in getting started more understandable

Fixes #11417
Please check the following:

[ ] Do the tests still pass?[^1]
[ ] Does the code comply with the style guide?

[ ] Run make lint from the Wagtail root.

[ ] For Python changes: Have you added tests to cover the new/fixed behaviour?
[ ] For front-end changes: Did you test on all of Wagtail’s supported environments?[^2]

[ ] Please list the exact browser and operating system versions you tested:
[ ] Please list which assistive technologies [^3] you tested:

[ ] For new features: Has the documentation been updated accordingly?

Details
Make example of BlogPost in Blog Index and Post section of getting-started tutorial more understandable adding the import of django models
Before:

After:

[^1]: Development Testing
[^2]: Browser and device support
[^3]: Accessibility Target

Thanks @salvo-polizzi! Merged in 6f9aadc86d6d816128071a2074b8dccac355677a.


Make it Divisible (Java)

(Make it Divisible) CodeChef Starters 12 Division 3 (Rated)
link : https://www.codechef.com/START12C/problems/MAKEDIV3
Issue Id you have worked upon -
#135
Briefly explain your program logic -
Using the property that if the sum of the digits of the number is divisible by 3 then the number is also divisible by 3.
Same property is also applicable for the number 9.
Hence to form a number of size n I am changing the 1st digit as well as last digit to 3 and rest all is 0.
Thus the sum of digits is 6 which is divisible by 3 and not by 9 hence the whole number is divisible by 3 and not by 9.
Screenshots(Attach 2 screenshots of your own input and output) -
Attach here

Checklist:
Eg - If your code follow the below guidelines. Kindly change [] to [x]
All the conditions should be fulfilled for considering your code for merging -
[x] I have mentioned the question as comment in my solution file.
[x] My code follows the guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code.
[x] My code gives the correct output.
[x] I confirm that I have not copied the code from anywhere. In case its found that I have copied I can be banned from the repository.
[x] I affirm that I strictly follow contributing guidelines and code of conduct.

@sachin4429,
Very well commented and arranged code.
Appreciating👏 by leveling up your question from level1 to level2


properly escaped urls still get encoded with / sometimes, so should just...

... use urlsafe base64 encoding
When using Dragonfly.app.fetch_url(...) these encoding methods still occasionally produce values with / in them which breaks the routing in my production environment.  urlsafe_encode64 just does it correctly and also doesn't add \n.  I could be missing something here, but ALL of my images are working now!!

not ready yet


python3Packages.vsure: 1.6.1 -> 1.7.2

Motivation for this change
Update to latest upstream release 1.7.2
Change log: https://github.com/persandstrom/python-verisure#version-history
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 112280 at 5e862d59 run on x86_64-linux 1

3 packages built:

python37Packages.vsure
python38Packages.vsure
python39Packages.vsure

Result of nixpkgs-review pr 112280 at 5e862d59 run on aarch64-linux 1

3 packages built:

python37Packages.vsure
python38Packages.vsure
python39Packages.vsure


chore: add build metadata when running setup

we intend to leverage aws-delivlib for our release infrastructure.
this changes adds some build metadata information to facilitate releases.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

AWS CodeBuild CI Report

Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository