Instant available metrics

I've encountered a scenario where certain metrics, such as allocation statistics/collections length are instantly available but are external and not directly controllable. Currently, the approach to forward these metrics to metrics is by employing tokio::spawn with an endless loop as shown below:
tokio::spawn(async {
    loop {
        let data = get_value();
        metrics::gauge("measurement").set(data);
        tokio::time::sleep(Duration::from_secs(5));
    }
});

While this method works, it's not the most efficient or elegant solution, particularly when considering that exporters may have varying scrape intervals.
Suggestion:
Would it be possible to introduce a global notification mechanism, on which all metrics will render their measurements?

It would likely be possible to support, yes.
We used to have support for this -- we called them proxies -- but they were removed as the crate evolved and we started to simplify the interface more and more.
I have thoughts on how I would want to see this approached if developed, but I don't have the time to work on this and it would be a lower priority than many other outstanding bugs/missing features. If you (or anyone else) would be interested in working on this, though, I would be willing to try and guide you on the work.


Popup project

In this project, we can click on a button then a popup notification will be displayed. It is made using Html, Css, and javascript.

successfully merged


Add support for using an environment for the upload step

It would be cool if you could specify what environment to use just for the upload step rather than the current situation where you have to specify it for the whole publish workflow.
This would allow someone to approve the upload after all the builds complete.

Unless the job environment input has a default value, we would have to duplicate the upload job: one job if an environment input is passed to the workflow and another if it isn't. Is that adding too much complexity? Especially with the Anaconda.org upload step, this would be a lot of duplicated code.
Also, the upload step for publish_pure_python.yml does not have a separate job for upload. Move to a separate job or apply environment to whole workflow?

Does referencing an environment which doesn't exist work?!
Could we use a composite action to reduce the duplication?

Looking into this a bit more, it seems you can use environment: and with: in the same block, so we will have to add explicit support.


ChatOpenAI vs OpenAIChat

There are currently two very similarly named classes - OpenAIChat and ChatOpenAI. Not sure what the distinction is between the two, which one to use, whether one is/will be deprecated?

OpenAIChat is deprecated, we will be going with ChatOpenAI in the future. all mentions of OpenAIChat should be removed from the documentation (if not the case, let me know)

OpenAIChat is a BaseLLM subclass, and ChatOpenAI is a BaseChatModel subclass.
@hwchase17 do you mean ChatOpenAI would also be a BaseLLM subclass so we could use ChatOpenAI to create LLMPredictor instance?
current code would report warning.
LLMPredictor(llm=OpenAIChat(**args))

I know this is closed, but today I was led to this page from Google, which was confusing because it uses the deprecated class name: https://js.langchain.com/docs/category/classes-107
Maybe this page needs to be purged from Google results?


Make Ownable's owner configurable in construction time

Right now, msg.sender is made the contract's owner. Make Ownable's constructor receive an address

Seems like Ownable.sol depends on so many contracts and I"m getting:
The contract code couldn't be stored, please check your gas amount.

error.

@rstormsf, I think it can be because you compare to 0 an address or if not it seems that you have reach the gas limit.
@maraoz why do we need it? the ownership can be changed after the contract creation with transferOwnership. What happens if Ownable is used on a contract that receives as first argument of the constructor an uint256 ?

@AugustoL @rstormsf   I'm not sure how an else statement would work because if we want the to pass in the owner on creation I think we should have it happen all the time.  To me a conditional statement in Ownable() seems like it adds needless complexity (it seems like you'd have to pass in 0x0 as a place holder to use the else with msg.sender).

So, should I continue doing it? or we leave msg.sender as a way to declare an owner. ?
I personally think since it will take more gas, we should prob leave msg.sender cause so many other contracts depend on it. Thoughts?

+1 on leaving msg.sender

By community consensus, I'm closing this issue.
You can still always call ownable.transferOwnership(newOwner) after creating the contract.
Thanks guys for the discussion.


Add as_duration

CPU time has nice duration semantics, so it'd be nice to expose it to the users.

Looks good! Sorry for long delay I needed to give some thought on the name. But after thinking I think this one is okay.


Proposed UX for the exploded view

I propose to make the exploded view toolbar button a toggle.
The exploded view factor number input could be set either in a separate dropdown in the toolbar (at first), or in a text input overlayed on the view.
On a separate note, maybe there should be a visual indication in the view that the exploded view is not the normal position of objects - and how to leave this view, in case someone does not know how to set it back to normal.

Closing as duplicate of #443


[Resource 86] Yoruba transcriptions in the root resource directory are wrong.

The following index files for Yoruba datasets are wrong:
http://www.openslr.org/resources/86/line_index_female.tsv
http://www.openslr.org/resources/86/line_index_male.tsv
The above files have South-American Spanish lines instead of Yoruba transcriptions. Is it possible to replace these with the line_index.tsv files from the corresponding zip files?
line_index_female.tsv   <--  yo_ng_female.zip/line_index.tsv
line_index_male.tsv <-- yo_ng_male.zip/line_index.tsv
My apologies, have only noticed this bug now.

@jtrmal any chance you could look at this?

yes.
Alex, would it be possible to open the PR against openslr-org/openslr?
y.
On Mon, Jul 27, 2020 at 7:37 AM Daniel Povey<EMAIL_ADDRESS>wrote:

@jtrmal https://github.com/jtrmal any chance you could look at this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/danpovey/openslr/issues/5#issuecomment-664129968, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACUKYX3CAN4UNJDEZ2XTUJLR5UHA5ANCNFSM4PIE3G4A
.

its an issue not a PR, not sure if can be done as PR because need change of
content (zip file) not metadata
On Mon, Jul 27, 2020 at 2:19 PM jtrmal<EMAIL_ADDRESS>wrote:

yes.
Alex, would it be possible to open the PR against openslr-org/openslr?
y.
On Mon, Jul 27, 2020 at 7:37 AM Daniel Povey<EMAIL_ADDRESS>wrote:

@jtrmal https://github.com/jtrmal any chance you could look at this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/danpovey/openslr/issues/5#issuecomment-664129968,
or
unsubscribe
<
https://github.com/notifications/unsubscribe-auth/ACUKYX3CAN4UNJDEZ2XTUJLR5UHA5ANCNFSM4PIE3G4A
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/danpovey/openslr/issues/5#issuecomment-664143393, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAZFLO2N72YID2ZBTPFIM33R5UL7XANCNFSM4PIE3G4A
.

ah, sorry, I got confused somehow...
y.
On Mon, Jul 27, 2020 at 9:11 AM Daniel Povey<EMAIL_ADDRESS>wrote:

its an issue not a PR, not sure if can be done as PR because need change of
content (zip file) not metadata
On Mon, Jul 27, 2020 at 2:19 PM jtrmal<EMAIL_ADDRESS>wrote:

yes.
Alex, would it be possible to open the PR against openslr-org/openslr?
y.
On Mon, Jul 27, 2020 at 7:37 AM Daniel Povey<EMAIL_ADDRESS>wrote:

@jtrmal https://github.com/jtrmal any chance you could look at this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/danpovey/openslr/issues/5#issuecomment-664129968,
or
unsubscribe
<

https://github.com/notifications/unsubscribe-auth/ACUKYX3CAN4UNJDEZ2XTUJLR5UHA5ANCNFSM4PIE3G4A

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/danpovey/openslr/issues/5#issuecomment-664143393,
or
unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAZFLO2N72YID2ZBTPFIM33R5UL7XANCNFSM4PIE3G4A
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/danpovey/openslr/issues/5#issuecomment-664163751, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACUKYXYMMPWWN6BFZW6IJUTR5USB3ANCNFSM4PIE3G4A
.

replaced
y.
On Mon, Jul 27, 2020 at 9:32 AM Jan Trmal<EMAIL_ADDRESS>wrote:

ah, sorry, I got confused somehow...
y.
On Mon, Jul 27, 2020 at 9:11 AM Daniel Povey<EMAIL_ADDRESS>wrote:

its an issue not a PR, not sure if can be done as PR because need change
of
content (zip file) not metadata
On Mon, Jul 27, 2020 at 2:19 PM jtrmal<EMAIL_ADDRESS>wrote:

yes.
Alex, would it be possible to open the PR against openslr-org/openslr?
y.
On Mon, Jul 27, 2020 at 7:37 AM Daniel Povey<EMAIL_ADDRESS>wrote:

@jtrmal https://github.com/jtrmal any chance you could look at
this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/danpovey/openslr/issues/5#issuecomment-664129968
,
or
unsubscribe
<

https://github.com/notifications/unsubscribe-auth/ACUKYX3CAN4UNJDEZ2XTUJLR5UHA5ANCNFSM4PIE3G4A

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/danpovey/openslr/issues/5#issuecomment-664143393,
or
unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAZFLO2N72YID2ZBTPFIM33R5UL7XANCNFSM4PIE3G4A
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/danpovey/openslr/issues/5#issuecomment-664163751,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACUKYXYMMPWWN6BFZW6IJUTR5USB3ANCNFSM4PIE3G4A
.

Alex, please confirm...
y.
On Mon, Jul 27, 2020 at 10:50 AM Jan Trmal<EMAIL_ADDRESS>wrote:

replaced
y.
On Mon, Jul 27, 2020 at 9:32 AM Jan Trmal<EMAIL_ADDRESS>wrote:

ah, sorry, I got confused somehow...
y.
On Mon, Jul 27, 2020 at 9:11 AM Daniel Povey<EMAIL_ADDRESS>wrote:

its an issue not a PR, not sure if can be done as PR because need change
of
content (zip file) not metadata
On Mon, Jul 27, 2020 at 2:19 PM jtrmal<EMAIL_ADDRESS>wrote:

yes.
Alex, would it be possible to open the PR against openslr-org/openslr?
y.
On Mon, Jul 27, 2020 at 7:37 AM Daniel Povey<EMAIL_ADDRESS>wrote:

@jtrmal https://github.com/jtrmal any chance you could look at
this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/danpovey/openslr/issues/5#issuecomment-664129968
,
or
unsubscribe
<

https://github.com/notifications/unsubscribe-auth/ACUKYX3CAN4UNJDEZ2XTUJLR5UHA5ANCNFSM4PIE3G4A

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/danpovey/openslr/issues/5#issuecomment-664143393,
or
unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAZFLO2N72YID2ZBTPFIM33R5UL7XANCNFSM4PIE3G4A
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/danpovey/openslr/issues/5#issuecomment-664163751,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACUKYXYMMPWWN6BFZW6IJUTR5USB3ANCNFSM4PIE3G4A
.

Excellent! Correct Jan. Thank you!


Bodymovin shows wilder animation

Hi,
We have created some animation with Body Movin, all of them works great.
The problem we have now is, the Body Movin animation animate really wild compared to what it supposed to animate.
Original Animation:

Bodymovin Animation:

You can test and play around here:
https://codepen.io/albertdp/project/editor/AmbRgM
Please let me know if you ever encounter the same issue.

Its working perfectly fine for me

Looks good to me as well (Chrome, MacOS)

@sowmyy @colinbrandt Thank you for your response.
We figured out that we used After Effect function to let it shake randomly wiggle() function.
This leads to unexpected movement in the bodymovin generated files.
Our solution is we modify how it behave manually. Instead of using wiggle() function, we move it slightly frame by frame.

Yes, unfortunately wiggle is difficult to reproduce and for now it's just a placeholder.
It doesn't work as expected indeed.


1.19.2 Game Crash when pressing C or running /isorender

Log:
https://mclo.gs/H1ezZ6s
Edited a few times (uploaded the wrong log)

It's a known incompatibility(?) between isometric-renders and owo-lib v>=0.9
see pull request 50

I am also experiencing this issue.

When will this be fixed?

is the error planned to be fixed at all?

is the error planned to be fixed at all?

I mean, this is quite significant to say the least, haha.


last_update is wrong

mdd, on my system, reports last_update as 2022-04-15, but is not true: currently, the last update of my system, was on 2024-10-10.

What does grep "\\[ALPM\\] upgraded" /var/log/pacman.log | tail -3 give you?

[2022-04-15T22:09:15+0200] [ALPM] upgraded libsoup3 (3.0.4-2 -> 3.0.6-1)
[2022-04-15T22:09:15+0200] [ALPM] upgraded tracker3 (3.2.1-2 -> 3.3.0-1)
[2022-04-15T22:09:15+0200] [ALPM] upgraded gtk-update-icon-cache (1:4.6.1-3 -> 1:4.6.2-1)

If I run grep -a

I used grep with the -a flag because the first command alerts me about

grep: /var/log/pacman.log: binary file matches

Interesting. I don't know what that means here regarding the file. Has the log been changed to use a binary format? In any case maybe it's then enough to add the -a flag to the call in MDD.

Has the log been changed to use a binary format?

I never touched /var/log/pacman.log

The file might have been damaged at some point in the past, like this StackOverflow comment implies. For example by an incomplete file write or so.


Can't update to new version of rundeck

I'm trying to install rundeck-2.4.2-1-GA.deb. I override the override['rundeck']['deb']['package'] = 'rundeck-2.4.2-1-GA.deb' & override['rundeck']['checksum'] = 'd2038440542b64921449e4ea0d7899f723bb29a58d713532fb8a0ab434ddac89'.
When i run the cookbook, i get
================================================================================
Error executing action install on resource 'apt_package[http://download.rundeck.org/deb/rundeck-2.4.2-1-GA.deb]'
================================================================================
       Chef::Exceptions::Package
       -------------------------
   dpkg failed - #<Process::Status: pid 27164 exit 2>!

seems the package is failing to install.
if you run dpkg -i rundeck-2.4.2-1-GA.deb what do you get?
Is this an upgrade?

it installs without errors...
Preparing to unpack rundeck-2.4.2-1-GA.deb ...
Unpacking rundeck (2.4.2) over (2.4.2) ...
Setting up rundeck (2.4.2) ...
usermod: no changes
Processing triggers for ureadahead (0.100.0-16) ...

That’s odd it says it was installed already.  Can you remove it and run chef-client in debug mode.
From: frank kang<EMAIL_ADDRESS>Sent: Wednesday, February 25, 2015 1:13 PM
To: Webtrends/rundeck
Cc: Peter Crossley
Subject: Re: [rundeck] Can't update to new version of rundeck (#44)
it installs without errors...
Preparing to unpack rundeck-2.4.2-1-GA.deb ...
Unpacking rundeck (2.4.2) over (2.4.2) ...
Setting up rundeck (2.4.2) ...
usermod: no changes
Processing triggers for ureadahead (0.100.0-16) ...
—
Reply to this email directly or view it on GitHubhttps://github.com/Webtrends/rundeck/issues/44#issuecomment-76060026.

sorry about that, i spun up a new server and received the same error. ssh'd to the box, wget'd the rundeck .deb file and ran dpkg -i. Here's the out put.
root@default-ubuntu-1404:/home/vagrant# dpkg -i rundeck-2.4.2-1-GA.deb
Selecting previously unselected package rundeck.
(Reading database ... 81604 files and directories currently installed.)
Preparing to unpack rundeck-2.4.2-1-GA.deb ...
Unpacking rundeck (2.4.2) ...
Setting up rundeck (2.4.2) ...
Processing triggers for ureadahead (0.100.0-16) ...

Closing this issue. I grabbed the cookbook from Github instead of supermarket and that fixed the issue.

Ah yes trying to get the market place cookbook updated but having an issue with that.  Thanks for reminding me.
Sent from my Windows Phone

From: frank<EMAIL_ADDRESS>Sent: �3/�31/�2015 10:10 AM
To<EMAIL_ADDRESS>Cc: Peter<EMAIL_ADDRESS>Subject: Re: [rundeck] Can't update to new version of rundeck (#44)
Closing this issue. I grabbed the cookbook from Github instead of supermarket and that fixed the issue.
�
Reply to this email directly or view it on GitHubhttps://github.com/Webtrends/rundeck/issues/44#issuecomment-88173829.


updated markdown.py to use yaml.safe_dump()

If using ipymd with Python 2, the YAML will be written with the prefix !!python/unicode   preceding every string if we use yaml.dump(...). By switching to yaml.safe_dump(...), we ensure that the written YAML can be loaded with yaml.safe_load(...).
(Stumbled across this today when switching between machines, one of which was running ipymd as a Python 2 library. Editing the python in the library in my site packages to use safe_dump() resolved the problem.)

Coverage remained the same at 90.432% when pulling 2a4a782208452354dbd863f86cdb062bdf22826a on dmhowcroft:master into e865b23ce21f84391bccfdf49e13a35c69f25a21 on rossant:master.

thanks @dmhowcroft !

Happy to help! This is an awesome library--I so much prefer using Markdown to JSON for my notebooks :)


Added Enter to search functionality in posts page

Pull Request
Title

Added press Enter to search functionality in posts page
Description

Previously, in posts section, while searching for a post we have to click on "search" button to search for a specific keyword post.
I added functionality so that, we can directly type our keyword and hit "ENTER" to search, thus improving user experience.
Related Issues

Fixes #549
Changes Made

Added a key event in searchbox which is triggered when ENTER key is pressed, calling the "handleSubmit" function which then takes care of fetching relevant posts.
Checklist

[X] I have tested the changes locally
[X] Documentation has been updated (if necessary)
[X] Changes are backward-compatible

Screenshots (if applicable)

https://github.com/user-attachments/assets/b79db1b5-bf74-4520-af0f-2298eded0829
Additional Notes

Footer
Thanks for assigning me this issue.

Remove the console.log comment

Okk I'll do it

@VaibhavArora314  removed comment


Use triple quotes in the EDSL object representation (repr method)

We have an issue when formatting Python code for an object returned by repr method. When there are text values on multiple lines the current solution doesn't work because it uses simple quotes '' (example for question class)

Thanks - would it be as simple as changing this line to use triple quotes?
https://github.com/expectedparrot/edsl/blob/ed8be697413b5d1af939c9456a495b3a143617ba/edsl/questions/QuestionBase.py#L232

There are two more places where a similar change have to be made


Fix missing geo:wktLiteral datatype

After the previous commit, all WKT literals except POINTs were missing the geo:wktLiteral datatype. This is now fixed again.

@ullingerc Even after this fix, there is still an inconsistency. Namely, in the TSV export, the points appear as POINT(...) without quotes and without datatype, whereas all other geometry types appear in quotes and with datatype. The TSV format does not require a particular format, but we should of course make it consistent. Do you know how to fix this?

This may be caused by this review: https://github.com/ad-freiburg/qlever/pull/1506#discussion_r1770882688
I then removed the full string representation with quotes and datatype. Tomorrow I will look into it and check if this is actually the cause.

@hannahbast I have checked it and the bug has nothing to do specifically with my implementation in #1506 . It also affects the date type. See for example: https://github.com/ad-freiburg/qlever/blob/f39907ccfe28096199c817b289e5c9131cd27cc3/test/ExportQueryExecutionTreesTest.cpp#L500-L504

@ullingerc Thanks for the info, than this is work for a separate PR. But I just hit another problem, when trying to build the index for the latest version of Wikidata (which never had problems with coordinates in the past):
2024-09-28 15:26:12.867 - ERROR:  Parse error at byte position<PHONE_NUMBER>60: /local/data-ssd/qlever/qlever-code/src/parser/GeoPoint.cpp, line 19: The given value 100 is out of range for latitude coordinates.
Any idea, what the problem is here? Anyway, it would be good to output the whole POINT... string here.

@ullingerc PS: Shortly before the parse fails, I find the following in the dataset: "Point(0 99.999999)"^^geo:wktLiteral. I understand that a latitude should not be larger than 90. But it would be good to be more lenient here and either omit the triple or not "fold" it but leave it as an ordinary literal (maybe without datatype). We already have warning messages for that at other places, for example:
2024-09-20 22:17:08.122 - WARN: IRI ref not standard-compliant: <http://rdf.ncbi.nlm.nih.gov/pubchem/patentipc/C4B 16-02>

@hannahbast It's very helpful that you found the problematic item, thanks. I think we should keep the verification for coordinates, otherwise  the folding will no longer work in a meaningful way. However, I agree, the error should be handled more gracefully, similar to the example you have pointed out.

@ullingerc I am also experiencing the same problem while parsing the latest wikidata, is there any solution for this at the moment?
For example:
ERROR:  Parse error at byte position<PHONE_NUMBER>04: /app/src/parser/GeoPoint.cpp, line 19: The given value 100 is out of range for latitude coordinates.
The next 500 bytes are:
 ;
        psv:P625 v:34805a86778b1accf78d4c9a01e74da2 ;
        pq:P2241 wd:Q29998666 ;
        prov:wasDerivedFrom ref:f36f7aab3afd293c532f86affede54cadeaee06d .

wd:Q113370244 p:P625 s:Q113370244-e4611765-45df-46e7-6f91-e6bb2c2d27c2 .

@ldp2211479是的，我在 PR #1525中提出了一个解决方案，但不幸的是它还没有合并到 master 中。

Thank you for your reply. I don't know much about this area, could you please provide a direct way to temporarily solve this problem for wikidata? For example, should I need to change the code /app/src/parser/GeoPoint.cpp?

@ldp2211479  You could either directly pull the code from the PR, or alternatively add this code manually for a quick fix:
https://github.com/ad-freiburg/qlever/blob/9c41d58bc76897cd6cbb264eccd6e14377081f05/src/parser/RdfParser.cpp#L548-L556

Thank you!

@ldp2211479 The fix for this will probably be merged into the master today, I have just apllied a final small tweak to it and am now waiting for the CI pipeline.


Change permission requirements

Is there a chance to merge this pull request? Now is impossible to use Fotoapparat on chromebooks


RSLock: Questions regarding 1) Setup Requirements and 2) safety for Multithread Applications & Arc<>

My questions are as follows:

What are the setup requirements for rslock? Do I need to be running a pre-existing redis instance?
Is the rslock library safe to use in a Multithreaded context? More specifically, I am using the rocket library in rust trying to store the RSLock Manager in an Arc so I can pass it as State to multiple requests. However, the lock keeps failing to acquire.

Any help would be deeply appreciated.

yes, you need to supply redis URIs - see usage here
what is the error you're seeing exactly?

Thank you so much for your fast response :). As for question 1:
I am still wondering if it is Multithread safe and how the underlying mechanism works. Does it make use of a connection pool? If not, should I build LockManager for each thread on my server?
Also again, do I need to initiate a Redis::Client instance fist or already have a Redis instance running?
As for the error, I just get the LockError enum:
Unavailable.

rslock does not start instances of Redis. you will need to supply the URIs of your own Redis instances.


Branding tasks

https://airtable.com/shrMtNWdsGQQs65mO

https://docs.google.com/forms/u/1/d/1bWNla4uJzhrprfJAzGjdi3naqMjeuQgrIl_I90JAKCY/edit

https://hiringwithfac.typeform.com/to/oMRl3N - does this look and read ok for everyone @rebeccaradding


New example and Windows 10 serial port fix

Added a example

New example and Windows 10 serial port fix


[Fix-#14137]Fix task instance get dependency and switch parameters exception when task is not dependency or switch type

Purpose of the pull request
This pull request fix get dependency and switch parameter exception when task is not dependency or switch type

Codecov Report

Merging #14199 (f6b6927) into dev (41e3ce3) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

:exclamation: Current head f6b6927 differs from pull request most recent head 896db68. Consider uploading reports for the commit 896db68 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14199      +/-   ##
============================================
- Coverage     38.30%   38.23%   -0.07%
+ Complexity     4468     4464       -4
============================================
  Files          1229     1229
  Lines         42876    42804      -72
  Branches       4765     4747      -18
============================================
- Hits          16423    16367      -56
+ Misses        24642    24626      -16
  Partials       1811     1811

Impacted Files
Coverage Δ

...ache/dolphinscheduler/dao/entity/TaskInstance.java
25.49% <0.00%> (-21.18%)
:arrow_down:

... and 63 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

#14137


failing tests since two commits to main

seems to have happened here https://github.com/lamalab-org/chem-bench/actions/runs/10194639876/job/28201653208

which is surprising since only data files changed (and hence I ignored this failing test in merging)

it also complains here https://github.com/lamalab-org/chem-bench/pull/429

ok, seems to be caused by an empty file


When to release the code, please?

Doing it : P, everything waiting for patent submission for now. expected
release early Dec.
On Fri, Nov 24, 2023 at 3:52 AM Katherine @.***> wrote:

—
Reply to this email directly, view it on GitHub
https://github.com/Image-Dream/Image-Dream.github.io/issues/1, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/BDXDKJVZO2JFCNY4GERRP3DYGCDBBAVCNFSM6AAAAAA7ZAO3SCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAYDSNRQGA4DANY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Peng Wang(王鹏）
Staff RS
Bytedance USA
Homepage: https://pengwangucla.github.io/peng-wang.github.io/
https://pengwangucla.github.io/peng-wang.github.io/


update conda lock + fix extlinks warnings

🚀 Pull Request
Description
This PR replaces #4521.
Includes some tiptoe avoidance of sphinx extlinks warnings whilst adopting the latest conda lock file from #4521.
This all seems to unblock adoption of sphinx 4.4.0 without pinning.

Consult Iris pull request check list

Note there is also a Sphinx PR that would make these warnings skip URLs with slashes, which is nearly all of ours https://github.com/sphinx-doc/sphinx/pull/10137

@bjlittle see #4546 for an alternative 😉


[Improve][connector-jdbc] Support exactly-once for jdbc connector source

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
Support exactly-once for jdbc connector source
Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Please assign to me.


⚠ Bofrost.lu has degraded performance

In 93169a0, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1439 ms

Resolved: Bofrost.lu performance has improved in ff6305e after 19 minutes.


How to install into eclipse

Sorry for my lack of skill in java and eclipse, I just wanna ask how to add your awesome builder to eclipse. But I stuck here.

Sorry for the delay. i haven't looked on this for a while.
You have to copy the Class "JsonToStringBuilder.class" into your own project.

Click OK/OK and your toString method will be nicely as below.

You can see the output in the log after you print the object.

i hope the above comment solves your problem


Don't show math block after save in No Editing Markdown mode.

I need to reload the chapter。

Same issue here. It appears blank. Besides, math formulas (inside $$... $$) do not render in read mode.


The subviews frame of cell is different between messagesCollectionViewCellDidTapCell and cellForItemAtIndexPath

When the user taps the cell, the following method runs
- (void)messagesCollectionViewCellDidTapCell:(JSQMessagesCollectionViewCell *)cell atPosition:(CGPoint)position
{
    NSIndexPath *indexPath = [self indexPathForCell:cell];
    if (indexPath == nil) {
        return;
    }

    [self.delegate collectionView:self
            didTapCellAtIndexPath:indexPath
                    touchLocation:position];
}

After I inspect the subviews in cell, the frames are OK ( what means is that all the frames have been modified by Autolayout ).
The code passed the NSIndexPath object to "didTapCellAtIndexPath" but not the cell itself.
In my own implement of "didTapCellAtIndexPath", I need decide which subviews in cell is tapped, so my code is a bit like following:
- (void)collectionView:(JSQMessagesCollectionView *)collectionView didTapCellAtIndexPath:(NSIndexPath *)indexPath touchLocation:(CGPoint)touchLocation{

    JSQMessagesCollectionViewCell *cell = (JSQMessagesCollectionViewCell *)[self collectionView:collectionView cellForItemAtIndexPath:indexPath];
    UIView *view = cell.messageBubbleContainerView;

   if(CGRectContainsPoint(view.frame, touchLocation)){
         ...............
    }
}

But I find that the frame of "messageBubbleContrainerView" is incorrect.
Certainly, I know there is another delegate method called "didTapMessageBubbleAtIndexPath" to handle the tapped event on "messageBubbleContrainerView".  The example code is just for elaboration.
So my question are:

What's  the consideration for passing a NSIndexPath object instead of a Cell to "didTapCellAtIndexPath". I consider that most of the use cases should convert the NSIndexPath object to Cell back again in "didTapCellAtIndexPath".
If there is any change to get the right frame of subviews in my own implement of "didTapCellAtIndexPath".  I don't want to change the source code.

Any help will be appreciated. Thanks

Hello everyone!
I'm sorry to inform the community that I'm officially deprecating this project. 😢 Please read my blog post for details:
http://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Thus, I'm closing all issues and pull requests and making the necessary updates to formally deprecate the library. I'm sorry if this is unexpected or disappointing. Please know that this was an extremely difficult decision to make. I'd like to thank everyone here for contributing and making this project so great. It was a fun 4 years. 😊
Thanks for understanding,
— jsq


Firefox developer edition

Thanks, but Firefox Developer Edition is an unstable release which belongs to the Versions repository (per documentation), where it is already available as firefoxdeveloperedition.


Bug: action method run twice with External Form block

On a fresh installation of concrete5 <IP_ADDRESS> with a fresh "blank installation":

Add the built-in "External Form" block to the page and select the "Test Form".
Add error_log('action_test_search'); to the action_test_search() method.
Notice how the action_test_search is logged twice in the web server logs.

Confirmed.
This happens because DispatcherRouteCallback::execute calls validateRequest two times, here and here

BTW it seems that this happens only when the external module is placed in the home page. @omobono is this your case too?

Yes, that is the case for us too. It only happens when the block is on the home page.
Would this apply to other block types too on the home page?

I don't believe this just happens on the home page - as I am getting it on multiple pages. Only way I have got round it at the moment is setting a session variable as I'm not too familiar with the source code.

@mlocati do you know if what @alkosh says is correct? It's worrying for us as we've just started building a commercial site in this latest stable version of concrete5.

The easiest way to get around this would be to set a static variable on your class though this is obviously not ideal. Session should not play into this at all.
Can we get confirmation that this is an issue in the develop branch? We did a lot of work to the dispatcher in there and I hope that we have resolved this issue with that already.

On v5.7 I did like this:
$response = \Redirect::to('/some/url');
$response->send();
exit;

which, according to @KorvinSzanto  isn't the right way to go but when doing
return \Response::create('/some/url'); the controller method is called twice.
I did a small test on the develop v8 branch and it seems to work now as it should:
https://gist.github.com/danielgasser/2b1031659ed6760a02809288e16fa1c7
So as far I can say it isn't an issue anymore on v8.

This does not appear to be an issue any longer. Unfortunately, submitting forms on the home page results in a 404 – although the actual submission DOES work in the backend.

@aembler This issue still exists in the most recent iteration of 8, least without applying the static variable change - so source at least needs the inclusion of it. I'm having issues validating the internal captcha due to it running twice, which I'm still investigating.

@eckoro you are right. I have fixed this issue with this commit. https://github.com/concrete5/concrete5/commit/42a8a8ffdca9c4f31941673addfe933649bd549a


Community Governance

Description
Introduce a rough governance doc for initial community management.
Documentation
Rendered Governance Doc

@LekoArts @pragmaticpat Thoughts? Also, I'd like to make one of you, or someone at Gatsby, a Steward as to reduce the bus factor. One of you okay with that or should it be someone like @KyleAMathews?

Thanks for putting this up! I'll give it a review tomorrow :)

LGTM! 👍🏼

Thanks @moonmeister ! - I'll look at this one later on today / this evening. 👍


Config Client property sources in different order after refresh in Hoxton.SR1

Describe the bug
With any version, if I setup a config server with https://github.com/habuma/myapp-config as the backend, with search-paths set to "sub", and a client connected to that server, and start the server before the client, I see the following two entries in /actuator/env:
        {
            "name": "configService:https://github.com/habuma/myapp-config/sub/application.yml",
            "properties": {
               ...
            }
        },
        {
            "name": "configService:https://github.com/habuma/myapp-config/application.yml (document #0)",
            "properties": {
                ...
            }
        },

Also, if the client is based on Hoxton.RELEASE and I start the client before the server starts, I get nothing in /actuator/env from the config server, but if I do a POST to /actuator/refresh, I get the same results as above.
All of this means that the properties in sub/application.yml take precedence over the ones in application.yml.
However, if the client is based on Hoxton.SR1 and I start the client before the server starts, then POST to /actuator/refresh, the two property sources are in reverse order:
        {
            "name": "configService:https://github.com/habuma/myapp-config/application.yml (document #0)",
            "properties": {
                ...
            }
        },
        {
            "name": "configService:https://github.com/habuma/myapp-config/sub/application.yml",
            "properties": {
               ...
            }
        },

This means that the properties in application.yml will take precedence over those in sub/application.yml--the opposite of what happens with a Hoxton.RELEASE client or if I start the client after the server starts.
I'm unsure which would be considered the correct order, but it's clear that the experience is inconsistent with Hoxton.SR1 depending on the timing of when the client and server start.
Sample
It's just a very simple config server/client setup using a Git URI of "https://github.com/habuma/myapp-config" and search-paths set to "sub". Then...

Start the server before the client to see application.yml appear before sub/application.yml. (This arrangement remains even after a POST to /actuator/refresh.)
Start the client before the server and then POST to the client's /actuator/refresh endpoint to see sub/application.yml appear before application.yml with a Hoxton.SR1 client (or the other way with a Hoxton.RELEASE client).

@spencergibb Here's a sample exposing the issue. https://github.com/dyroberts/issue1542/blob/master/config-server/src/main/resources/application.yml


Add unit test for App.tsx

As part of https://github.com/SasanLabs/VulnerableApp-facade/issues/56 we have introduced a unit testing framework and now we are looking for adding more unit test for the project.
we are missing unit tests for https://github.com/SasanLabs/VulnerableApp-facade/blob/main/facade-app/src/App.tsx file
Have a look at codecov report for finding what all is missing and cover that as part of this issue.
Codecov report: https://app.codecov.io/gh/SasanLabs/VulnerableApp-facade/blob/main/facade-app/src/App.tsx

Hello!
May i take this on?

Hi @lejara ,
Sure.

Thank you !!!


Display tooltip on hover for status icons

Is your feature request related to a problem? Please describe.
HACS shows helpful status icons (green, orange, red) but this could potentially be a little confusing for users if they haven't read the docs. For example, the red "restart pending" icon color could be misinterpreted as an error/failure.
Describe the solution you'd like
Could solve this by displaying a standard browser tooltip when hovering over the status icons with a mouse. Here is a rough mockup:

Potential wordings to use:
Green: "Up to date!"
Orange: "Update available."  (or... "Button Card 1.11.1 available. You're using 1.10.2.")
Red: "Restart to finish installing or updating."

Adding it to the icon can not be done, since the entire line is an active object.
But it can be added to the line (in table) or card (in grid).

NVM.. looks like that is no longer a limitation with the new generation logic.
Added for 0.13.0

https://github.com/custom-components/hacs/blob/40cacd0445f668ebd1df7575934f0bf81898fb5d/custom_components/hacs/repositories/repositoryinformation.py#L87-L95 Current descriptions.


Config for Block-Cache Capacity lose efficacy when we use TiDB Lightning to import data.

Bug Report

What version of TiKV are you using?

master: 7c679639885172814c4ef28f00d190337ce284a4
What operating system and CPU are you using?

AWS i3.4xlarge
Steps to reproduce

We execute 'drop table' in a TiDB-cluster, and then import data to TiKV by TiLightning.
Then I observer the size of block cache decreasing to 4GB from 64GB.
What did you expect?
We expect that the capacity of block-cache remain unchanged.
What did happened?

PTAL @kennytm

Likely caused by this line
https://github.com/tikv/tikv/blob/bd94da3107ad4d515458068b124d8b107ebac1e6/components/sst_importer/src/import_mode.rs#L105

Importer would set the config backup when it turns to 'normal_mode'. But if TiKV uses 'shared_cache' , importer would changed it by the value of cf-options's block-cache-size.
cf_opts.set_block_cache_capacity(self.block_cache_size)?;

TODO:

We need to find out why the size of block-cache was changed into '4GB' rather than '128MB', which is size of block-cache of RAFT_CF. 'raft-cf' is the last CF in RocksDB.
Add interface to get capacity of shared-block-cache, and pass shared to importer.
Ban interface set_block_cache_capacity of ColumnFamilyOptions if this CF use a shared block-cache.


createTilemap: Default scale to TileScale.Sixteen

The problem
In the JS editor, typing tiles.createTilemap( and tab to autocomplete fills in a scale of TileScale.Eight, but it should be TileScale.Sixteen.
My solution
I wasn't able to find a way to have it explicitly become TileScale.Sixteen, but making it the default value is an improvement, I think. Curious what others think, and if there's a better solution.
Fixes https://github.com/microsoft/pxt-arcade/issues/2112

So this fixes auto-complete and snippets from the toolbox? If so, this seems like a great solution

does this not work?
//% scale.defl="TileScale.Sixteen"

does this not work?
//% scale.defl="TileScale.Sixteen"

@riknoll That worked beautifully! Autocomplete fills it in now:
tiles.createTilemap(null, img` `, [], TileScale.Sixteen)

@darzu Does this work for you?


Repeater seems broken

Package
filament/filament
Package Version
V3
Laravel Version
V10
Livewire Version
V3 BETA.8
PHP Version
PHP 8.2.6
Problem description
Considering the following form:
return $form
    ->schema([
        Forms\Components\Repeater::make('test')->columns(2)->schema([
            Forms\Components\TextInput::make('hi'),
            Forms\Components\Select::make('options')
                ->searchable()
                ->options([
                    'one', 'two'
                ])
        ]),
    ]);

The repeater seems completely broken when you have components that use JS, in this case, using ->searchable() causes to introduce JS inside a component, which breaks the repeater badly.

It won't delete records at some point
It will spawn multiple rows when you only press once
It will spawn rows when you delete a record randomly
It will cause scrolling to top issues

https://github.com/filamentphp/filament/assets/3110750/b17e65cf-31f9-4b8f-9fee-16ab3d3dd6f1
Expected behavior
I expect the Repeater to not glitch so much with the bugs described above.
Steps to reproduce
An code example is provided, you can just enter that in any resource you have.
Reproduction repository
https://github.com/Cannonb4ll/filament-repeater-bug
Relevant log output
No response

Dup of #7485

livewire/livewire#6289


Fix multiple touch zoom and drag

This is going to be awesome! useless so indispensable

In good shape thanks to new d3 renderer.


Unnecessary validation animation when clicking on "Next" in create function

Environment info
Version: 2.4.0-188c121
Deployment: **AZURE
Customer: NAME
Actual behavior

After filling all the fields in the step and clicking "next" there is an animation ("no no no") that deny from continuing to the next step. at the second click, it will work.

Expected behavior

Allow continuing if the form was filled as it should

Steps to reproduce

Go to create function > fill the form

Screenshots or Logs or other output that would be helpful
nbfedump.2018_04_26-14_59_09.json.gz

@nimrod-becker I don't have a testing system to check.

@nimrod-becker Doesn't happen anymore, not sure why this was assigned to me due :)


The login and logout navigation strategies behave differently on returning Promises.

private addLoginRoute(routerConfiguration: RouterConfiguration) {
    routerConfiguration.mapRoute({
        name: "login",
        nav: false,
        navigationStrategy: (instruction: NavigationInstruction) => {
            // no return
            // and do setRequiredNavigationInstructions.
            this.setRequiredNavigationInstructions(instruction);
            this.openIdConnectNavigationStrategies.login(instruction);
        },
        route: "login",
        settings: {
            roles: [
                OpenIdConnectRoles.Anonymous,
            ],
        },
    });
}

private addLogoutRoute(routerConfiguration: RouterConfiguration) {
    routerConfiguration.mapRoute({
        name: "logout",
        nav: false,
        navigationStrategy: (instruction: NavigationInstruction) => {
            // return
            // and do not setRequiredNavigationInstructions.
            // This leads to a nice-to-fix error:
            // "Cannot read property 'trim()' of undefined."
            return this.openIdConnectNavigationStrategies.logout(instruction);
        },
        route: "logout",
        settings: {
            roles: [
                OpenIdConnectRoles.Authorized,
            ],
        },
    });
}

private setRequiredNavigationInstructions(instruction: NavigationInstruction) {
    instruction.config.href = instruction.fragment;
    instruction.config.moduleId = instruction.fragment;
    instruction.config.redirect = instruction.fragment;
}

// openIdConnectNavigationStrategies
public login(instruction: NavigationInstruction): Promise<any> {
    let args: any = {};
    return this.userManager.signinRedirect(args);
}

// openIdConnectNavigationStrategies
public logout(instruction: NavigationInstruction): Promise<any> {
    let args: any = {};
    return this.userManager.signoutRedirect(args);
}

Login:
// Cannot read property 'trim' of undefined at relativeToFile
return this.openIdConnectNavigationStrategies.login(instruction);

// Cannot read property '__useDefault' of undefined at ensureOriginOnExports
instruction.config.moduleId = "";
return this.openIdConnectNavigationStrategies.login(instruction);

These are the errors we receive with different attempts at a logout NavigationStrategy.
// TypeError: Cannot read property 'then' of undefined at OpenIdConnectNavigationStrategies.runHandlers
instruction.config.redirect = "";
return this.openIdConnectNavigationStrategies.logout(instruction);

At this point, we are receiving the Warning: A promise was rejected with a non-error message. It seems that the Aurelia recommendation is to ignore these warnings.
https://github.com/aurelia/router/issues/329


Time Series Classification

A univariate time-series classification task project.  Please review and suggest any changes.

@brianleahy Thanks for making these modifications

@slavakurilyak  You're welcome, and thanks for pointing them out.  I changed the code to use the 'os' package feature to ensure the path separators will be correct for each operating system.  I checked OS X and Windows, but not Linux.  If you or someone else could verify Linux that would be great.

@mlaradji Please confirm this model works on Linux

Has this been reviewed yet?  GitHub just marked it stale for inactivity, and I see that there's still no other time-series classification contribution in the project.


About the code

Thanks for your work.
I have a question about the code. In file "augmentation.py", the source image is the original input image, and the target image (image_aug) is warpped from source image using H matrix. But, in file "KeypointNetwithIOLoss.py",  the augmented image (image_aug) is used as the source image, why?
I am really confused by this, could you help me with this question? Thanks a lot!

Hi, thanks for the question! Technically we can use the term source and target interchangeably, as they are both passed through the keypoint net here. What's important is that we use the correct homography here. In our case, because of the way we construct the target image in augmentation.py by using the grid sampling operation, the homography warps target pixels into the source image, and we use it correctly in the KeypointNetWithIOLoss.
But you're right that the terminology is confusing, we should be consistent with how we use source and target everywhere in the code, I'll make a note to fix that. I hope that helps and thanks for spotting this!

Thank you very much!

We just merged a PR with the cleanup - hopefully it makes more sense now!

We just merged a PR with the cleanup - hopefully it makes more sense now!


Use correct guard for execute 'selinux-permissive' resource.

The execute 'selinux-permissive' resource should guard currently checks for
getenforce | egrep -qx 'Disabled' but it should be checking for Permissive.
Use the correct guard for execute 'selinux-permissive' resource.

[ ] All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable
[x] All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

👍

Thanks!


Support reflowing lines on resize

On resize ideally we want the text to reflow and wrap to the next line where appropriate.

I'm closing off the PR for this #644, if anything it was a good learning experience!
Basically to tackle this feature properly we need to come up with a lightweight view model, it's probably best to be left to one of the core maintainers as it's quite complex and needs an intimate knowledge of the internals of xterm.js to be done right.
I'll copy over the proposal from https://github.com/sourcelair/xterm.js/pull/644#issuecomment-298058556 for reference, it's still mostly correct and useful. I would also add to this that we need to consider the memory cost of the view model as well as potentially using the view model as a way to gain deeper insights into what's happening in the buffer for https://github.com/sourcelair/xterm.js/issues/731 (eg. knowing that a single character was added when a line is redrawn).

What we need

Wrap lines when reducing width
Unwrap lines when increasing width
Scroll bar needs to support wrapped height
Don't change the way input interacts with the buffer - when an escape sequence operates on row x, it should operate on the unwrapped row at x

Issues with current implementation

Accessing private properties on CircularList could lead to instability. This essentially obsoletes the unit tests on CircularList for how we're using it and makes it more difficult to maintain going forward.
A lot of costly array/string manipulation inside reflow.

Proposal
WrappableBuffer's state
I'm proposing we change WrappableBuffer to store the start index of the row
CircularList     WrappableBuffer where size = 4
[0]: "abcdef"      [0]: 0
[1]: "abcd"        [1]: 2
[2]: "abcdefgh"    [2]: 3

With this we have a basic model of the wrapping with minimal information. For fast access of the actual rows we will also want WrappableBuffer to have a map going the other way:
WrappableBuffer.wrappedToNormalIndex
[0]: [0, 0]
[1]: [0, 1]
[2]: [1, 0]
[3]: [2, 0]
[4]: [2, 1]

These two arrays are all that will be evaluated when the terminal is resized, so the resize of WrappableBuffer will look something like this:
resize(width: number) {
  // Lots of optimization potential here
  this.normalToWrappedIndex = new Array(this.circularList.length);
  this.wrappedToNormalIndex = new Array(this.circularList.length);
  let currentNormal = 0;
  let currentWrappedCount = 0;
  for (let i = 0; i < this.circularList.length; i++) {
    const line = this.circularList.get(i);
    const wrappedCount = Math.ceil(line.length / width);
    this.normalToWrappedIndex[i] = currentWrappedCount;
    for (let j = 0; j < wrappedCount; j++) {
      this.wrappedToNormalIndex[currentWrappedCount + j] = [i, j];
    }
    currentWrappedCount += wrappedCount;
  }
}

Retrieving rows
Since we're only doing the above on a resize we need to actually serve the wrapped rows somehow. This can be done at the time the wrapped row is requested with WrappableBuffer.getWrapped at which point we can cache the chunked row and store it for later use since string construction is relatively expensive.
When the line's wrapped state changes we can discard the cached chunked row.
Composition over inheritance
In order to prevent future misuse let's use a member variable instead of extending and have both CircularList and WrappableBuffer share the ICircularList interface.
CircularList`s internal changes
To deal CircularList's trimming mechanism we could have CircularList extend EventEmitter and throw an onTrim(count: number) event and act accordingly in WrappableBuffer (probably by storing an offset to add to the indexes).
If there are any other internal movement that WrappableBuffer needs to know about it could be exposed in an event.
Exposing both wrapped and unwrapped buffers
I believe we want to expose both wrapped (getWrapped?) and unwrapped buffers (get?) as escape sequences should be operating on the unwrapped rows but we want to display the wrapped rows.
Scrollback
Currently it's a little ambiguous what scrollback means, in the new solution scrollback would strictly define the number of unwrapped rows.
Result
Here's a once over of the ICircularList interface summarizing the changes that WrappableBuffer would make:

length: Similar to CircularList but changes on resize
maxLength: Computed based on CircularList.maxLength and WrappableBuffer.length;
forEach: Little change
get: Create and cache wrapped row
set: Re-evaluates wrapped state of all rows after the current row, this will typically only be called towards the end of the buffer
push: Evaluate wrapped state of new row
pop: Remove row
splice: Like set, should only be used near end of buffer
trimStart: Will throw an event in CircularList
shiftElements: Evaluate wrapped state of new rows, reuse when possible

About this issue, in the section (What we need)  " is exactly what we are looking for, a way to display in the xterm on a browser the wrap line when increasing/reducing the width of the window, be able to see all the data for the executed command.

I'm planning on tackling this for 3.4.0, I recently went over the history of this and wrote up a refreshed design document:
Requirements

Wrap lines when reducing width
Unwrap lines when increasing width
Scroll bar needs to use the total number of wrapped lines
Escape sequences need to act upon the wrapped buffer, not the unwrapped buffer.

Performance considerations

Do not reconstruct characters/rows/strings while maintaining the wrapped state
The total number of wrapped lines needs to be fetched very quickly as that is needed to position the scrollbar
Resize needs to be as fast as possible as this can fire many times on windows resize (and the terminal is just one component in VS Code)
Ideally scrollback would represent the number of wrapped rows, this isn't too important though if that's tough

Implementation
The solution will keep a separate view model WrappedBuffer which maintains arrays that map from normal to wrapped index and the other way around. For example:
CircularList       WrappedBuffer.normalToWrappedIndex where size = 4
[0]: "abcdef"      [0]: 0
[1]: "abcd"        [1]: 2
[2]: "abcdefgh"    [2]: 3

WrappableBuffer.wrappedToNormalIndex
[0]: [0, 0]
[1]: [0, 4]
[2]: [1, 0]
[3]: [2, 0]
[4]: [2, 4]

This will provide fast O(1) access to wrapped or unwrapped indexes at the cost of a O(n) operation on resize to update the lists. This operation could probably be optimized pretty heavily.
abstract class BaseWrappedList extends IWrappedList<LineData, CharData> {
    private _circularList: ICircularList<LineData>;

    // These should use TypedArrays/ArrayBuffers (may need to reduce MAX_BUFFER_SIZE)
    private wrappedToNormalIndex: [number, number][];
    private normalToWrappedIndex: number[];

    // O(n) where n is length of _circularList
    public onResize(cols: number): void {
        this.normalToWrappedIndex = new Array(this.circularList.length);
        this.wrappedToNormalIndex = new Array(this.circularList.length);
        let currentNormal = 0;
        let currentWrappedCount = 0;
        for (let i = 0; i < this.circularList.length; i++) {
            const line = this.circularList.get(i);
            // TODO: Use _isListEntryDoubleWidth to determine the line of the
            //       last wrapped cell in each line
            const wrappedCount = Math.ceil(line.length / cols);
            this.normalToWrappedIndex[i] = currentWrappedCount;
            for (let j = 0; j < wrappedCount; j++) {
                this.wrappedToNormalIndex[currentWrappedCount + j] = [i, j];
            }
            currentWrappedCount += wrappedCount;
        }
    }

    protected _isListEntryDoubleWidth(unwrappedRow: number, unwrappedCol: number): boolean {
        return false;
    }
}

class WrappedBuffer extends IWrappedList<LineData, CharData> {
    protected _isListEntryDoubleWidth(unwrappedRow: number, unwrappedCol: number): boolean {
        // Used to check if the last char is double width in order to wrap it to
        // the next row or not
        // Null check as needed
        return this.get(unwrappedRow, unwrappedCol)[2] === 2;
    }
}

Before
export interface ICircularList<T> extends IEventEmitter {
  length: number;
  maxLength: number;
  forEach: (callbackfn: (value: T, index: number) => void) => void; // Not sure this is used anymore

  get(index: number): T;
  set(index: number, value: T): void;
  push(value: T): void;
  pop(): T;
  splice(start: number, deleteCount: number, ...items: T[]): void;
  trimStart(count: number): void;
  shiftElements(start: number, count: number, offset: number): void;
}

class CircularList extends ICircularList<LineData> { ... }

After
export interface IWrappedList<T extends Array<U>, U> {
  // How to handle wide chars on the last cell? Protected method
  // _isListEntryDoubleWidth which is called on the last char to figure out the
  // right wrapped spot

  readonly length: number;

  get(index: number): T;
  splice(start: number, deleteCount: number, ...items: T[]): void;
  shiftElements(start: number, count: number, offset: number): void;
  onResize(cols: number): void;
}

export interface ICircularList<T> extends IEventEmitter {
  length: number;
  maxLength: number;

  get(index: number): T;
  set(index: number, value: T): void;
  push(value: T): void;
  pop(): T;
  trimStart(count: number): void;
}

Notes

When a line is wrapped and it is deleted, the delete line operation is perfermed on the wrapped portion of the line, breaking the line
https://github.com/Microsoft/vscode/issues?utf8=%E2%9C%93&q=is%3Aopen%20no%3Aassignee%20-label%3Afeature-request%20-label%3Atestplan-item%20-label%3Aplan-item%20-label%3Aextension-candidate
echo -e '\e[44m\e[A\e[A\e[A\e[A\e[A\e[1M\e[0m'

If deleted from the middle of a wrapped line (eg. line 2 of a 3 line wrapped line), VTE will join the other portions of the line
This means that the wrapped state will also affect how manipulations happen on the actual circular list.

When a line is inserted into the middle of a wrapped line, it will be marked as wrapped.
echo 'https://github.com/Microsoft/vscode/issues?utf8=%E2%9C%93&q=is%3Aopen%20no%3Aassignee%20-label%3Afeature-request%20-label%3Atestplan-item%20-label%3Aplan-item%20-label%3Aextension-candidate'
echo -e '\e[44m\e[A\e[A\e[A\e[A\e[A\e[1L%20-label%3Afeature-request%20-label%3Atestplan-item%20-label%3Aplan-item%20-label%3A\e[0m'

The line will not join with a following wrapped portion unless the line wraps over to that line:
echo 'https://github.com/Microsoft/vscode/issues?utf8=%E2%9C%93&q=is%3Aopen%20no%3Aassignee%20-label%3Afeature-request%20-label%3Atestplan-item%20-label%3Aplan-item%20-label%3Aextension-candidate'
echo -e '\e[44m\e[A\e[A\e[A\e[A\e[A\e[1L%20-label%3Afeature-request%20-label%3Atestplan-item%20-label%3Aplan-item%20-label%3AA\e[0m'

is it possible to recalculate the visible lines first? this to make
resizing fast.
Maybe during resizing, reflow lines "manually", and then after a debounce
rebuild the wrappedIndex and thus update the scrollbar?
Premature optimization probably ;)
On Thu, Mar 22, 2018, 7:03 PM Daniel Imms<EMAIL_ADDRESS>wrote:

I'm planning on tackling this for 3.4.0, I recently went over the history
of this and wrote up a refreshed design document:
Requirements

Wrap lines when reducing width
Unwrap lines when increasing width
Scroll bar needs to use the total number of wrapped lines
Escape sequences need to act upon the wrapped buffer, not the
unwrapped buffer.

Performance considerations

Do not reconstruct characters/rows/strings while maintaining the
wrapped state
The total number of wrapped lines needs to be fetched very quickly
as that is needed to position the scrollbar
Resize needs to be as fast as possible as this can fire many times
on windows resize (and the terminal is just one component in VS Code)
Ideally scrollback would represent the number of wrapped rows, this
isn't too important though if that's tough

Implementation
The solution will keep a separate view model WrappedBuffer which
maintains arrays that map from normal to wrapped index and the other way
around. For example:
CircularList       WrappedBuffer.normalToWrappedIndex where size = 4
[0]: "abcdef"      [0]: 0
[1]: "abcd"        [1]: 2
[2]: "abcdefgh"    [2]: 3
WrappableBuffer.wrappedToNormalIndex
[0]: [0, 0]
[1]: [0, 4]
[2]: [1, 0]
[3]: [2, 0]
[4]: [2, 4]
This will provide fast O(1) access to wrapped or unwrapped indexes at the
cost of a O(n) operation on resize to update the lists. This operation
could probably be optimized pretty heavily.
abstract class BaseWrappedList extends IWrappedList<LineData, CharData> {
private _circularList: ICircularList;
// These should use TypedArrays/ArrayBuffers (may need to reduce MAX_BUFFER_SIZE)    private wrappedToNormalIndex: [number, number][];
private normalToWrappedIndex: number[];

// O(n) where n is length of _circularList    public onResize(cols: number): void {
    this.normalToWrappedIndex = new Array(this.circularList.length);
    this.wrappedToNormalIndex = new Array(this.circularList.length);
    let currentNormal = 0;
    let currentWrappedCount = 0;
    for (let i = 0; i < this.circularList.length; i++) {
        const line = this.circularList.get(i);
        // TODO: Use _isListEntryDoubleWidth to determine the line of the            //       last wrapped cell in each line            const wrappedCount = Math.ceil(line.length / cols);
        this.normalToWrappedIndex[i] = currentWrappedCount;
        for (let j = 0; j < wrappedCount; j++) {
            this.wrappedToNormalIndex[currentWrappedCount + j] = [i, j];
        }
        currentWrappedCount += wrappedCount;
    }
}

protected _isListEntryDoubleWidth(unwrappedRow: number, unwrappedCol: number): boolean {
    return false;
}

}
class WrappedBuffer extends IWrappedList<LineData, CharData> {
protected _isListEntryDoubleWidth(unwrappedRow: number, unwrappedCol: number): boolean {
// Used to check if the last char is double width in order to wrap it to        // the next row or not        // Null check as needed        return this.get(unwrappedRow, unwrappedCol)[2] === 2;
}
}
Before
export interface ICircularList extends IEventEmitter {
length: number;
maxLength: number;
forEach: (callbackfn: (value: T, index: number) => void) => void; // Not sure this is used anymore
get(index: number): T;
set(index: number, value: T): void;
push(value: T): void;
pop(): T;
splice(start: number, deleteCount: number, ...items: T[]): void;
trimStart(count: number): void;
shiftElements(start: number, count: number, offset: number): void;
}
class CircularList extends ICircularList { ... }
After
export interface IWrappedList<T extends Array, U> {
// How to handle wide chars on the last cell? Protected method  // _isListEntryDoubleWidth which is called on the last char to figure out the  // right wrapped spot
readonly length: number;
get(index: number): T;
splice(start: number, deleteCount: number, ...items: T[]): void;
shiftElements(start: number, count: number, offset: number): void;
onResize(cols: number): void;
}
export interface ICircularList extends IEventEmitter {
length: number;
maxLength: number;
get(index: number): T;
set(index: number, value: T): void;
push(value: T): void;
pop(): T;
trimStart(count: number): void;
}
Notes

When a line is wrapped and it is deleted, the delete line operation is
perfermed on the wrapped portion of the line, breaking the line
https://github.com/Microsoft/vscode/issues?utf8=✓&q=is%3Aopen no%3Aassignee -label%3Afeature-request -label%3Atestplan-item -label%3Aplan-item -label%3Aextension-candidate
echo -e '\e[44m\e[A\e[A\e[A\e[A\e[A\e[1M\e[0m'
If deleted from the middle of a wrapped line (eg. line 2 of a 3 line
wrapped line), VTE will join the other portions of the line
This means that the wrapped state will also affect how manipulations
happen on the actual circular list.
When a line is inserted into the middle of a wrapped line, it will be
marked as wrapped.
echo 'https://github.com/Microsoft/vscode/issues?utf8=✓&q=is%3Aopen no%3Aassignee -label%3Afeature-request -label%3Atestplan-item -label%3Aplan-item -label%3Aextension-candidate'
echo -e '\e[44m\e[A\e[A\e[A\e[A\e[A\e[1L%20-label%3Afeature-request%20-label%3Atestplan-item%20-label%3Aplan-item%20-label%3A\e[0m'
The line will not join with a following wrapped portion unless the
line wraps over to that line:
echo 'https://github.com/Microsoft/vscode/issues?utf8=✓&q=is%3Aopen no%3Aassignee -label%3Afeature-request -label%3Atestplan-item -label%3Aplan-item -label%3Aextension-candidate'
echo -e '\e[44m\e[A\e[A\e[A\e[A\e[A\e[1L%20-label%3Afeature-request%20-label%3Atestplan-item%20-label%3Aplan-item%20-label%3AA\e[0m'
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/xtermjs/xterm.js/issues/622#issuecomment-375403572,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADWlh30vLRjSOMvgv_NDKLA6DzwPETeks5tg-d4gaJpZM4MuuoY
.

How about making the resize interruptable:
on resize:

mark the lines dirty
recalculate the visible lines first (needs some consideration for the first wrapped line)
then start from the beginning, calculate 100 lines, schedule the next 100
when you reach the end, unmark the lines dirty
any time resize happens, cancel the next scheduled work and start over

this way it should remain responsive at all times.

The issue with this is getting the scroll position correct

Sorry I don't know how the scrolling is implemented, can't you keep the top line at the top of the visible range?
So can you leave the scroll bar unchanged until the reflow is complete, and the update.

@lmcbout

So can you leave the scroll bar unchanged until the reflow is complete, and then update.

Well that's the idea, but reflow will be synchronous so it will happen immediately after.

Sorry I don't know how the scrolling is implemented, can't you keep the top line at the top of the visible range?

The thing with the scroll bar is that we could maybe get away with only reflowing the viewport if not for the scroll bar. For the scroll bar we need to know the number of wrapped lines, and to get that we need to iteration over all the lines and perform the above resize algorithm.
I'm hoping it's just fast enough due to the TypedArrays but if not then maybe we have to fallback on being lazy and guessing the scroll bar but I can see weird bugs coming out of doing something like this. My thinking was that we could just wrap the viewport (and maybe surrounding rows), scrolling with the mouse wheel could be left unchanged. Scrolling by dragging the bar however would scroll the unwrapped rows or to some percentage of the viewport. I think this is over engineering the solution though and would cause some things to just not feel right (scroll bar height, jumping over an inconsistent amount of rows when scrolling).

Hmm right. Come to think of it, assuming getting the length of a string is
O(1), knowing the number of lines is O(n) but with few operations: the sum
of ceil(line[i].length/width)
Creating the wrapped line arrays is a heavier O(n*avg_nr_lines/line)
Maybe it is indeed best to do the naive implementation first and then
optimize if needed.
On Fri, Mar 23, 2018 at 9:40 PM Daniel Imms<EMAIL_ADDRESS>wrote:

@lmcbout http:///lmcbout
So can you leave the scroll bar unchanged until the reflow is complete,
and then update.
Well that's the idea, but reflow will be synchronous so it will happen
immediately after.
Sorry I don't know how the scrolling is implemented, can't you keep the
top line at the top of the visible range?
The thing with the scroll bar is that we could maybe get away with only
reflowing the viewport if not for the scroll bar. For the scroll bar we
need to know the number of wrapped lines, and to get that we need to
iteration over all the lines and perform the above resize algorithm.
I'm hoping it's just fast enough due to the TypedArrays but if not then
maybe we have to fallback on being lazy and guessing the scroll bar but I
can see weird bugs coming out of doing something like this. My thinking was
that we could just wrap the viewport (and maybe surrounding rows),
scrolling with the mouse wheel could be left unchanged. Scrolling by
dragging the bar however would scroll the unwrapped rows or to some
percentage of the viewport. I think this is over engineering the solution
though and would cause some things to just not feel right (scroll bar
height, jumping over an inconsistent amount of rows when scrolling).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/xtermjs/xterm.js/issues/622#issuecomment-375792115,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADWlt3vr5MpZNQXA3rUramkl034ZHPtks5thV3WgaJpZM4MuuoY
.

https://github.com/xtermjs/xterm.js/issues/1286 should get fixed when we tackle reflow, the proper fix needs to the reflow workaround where the data outside the screen to go away first. See https://github.com/xtermjs/xterm.js/pull/1373

DomTerm supports Common Lisp-style "pretty-printing".  There are certain escape sequence to indicate logical grouping, optional newlines (only break line if too long to fit), indentation etc. Then DomTerm's line-breaking engine calculates the line-breaks.  On window resize the line-breaks are re-calculated.
This may not be something you want to do, but if would be nice if it is something an addon could do.  I.e. there needs to be a hook into reflow. It would be nice to be able to add and remove "soft" newlines that aren't always at the right of the line.


Max-Width Bug in the Editor

There is a bug in the Editor section that allows the user to increase the width of the writing section to more than what is allotted to the editing part.
The picture of the bug is attached below.

I can solve the issue if you could assign it to me!

@smaranjitghose  Is this bug fixed Can I work on it I found what's wrong with this. Please let me know.


Finding your div from browser in code [Best practice]

Hello, I've problem that sometimes i spent a lot of time search for appropiated div when i have very granular components and there is a lot of components let say 1000.
Do you know some best practice to add some attributes to each component to find it easy in code from browsered html (chrome).
I was trying to use data-testid but it is a little bit weird that in some cases i don't see data-testid attribute in chrome  ? Any ideas what could be a problem ? Any other ideas how to solve the problem ?

If you use the Babel plugin it’ll name the static css classes more nicely
On Sat, Jan 11, 2020 at 9:33 AM Patryk Sadowski<EMAIL_ADDRESS>wrote:

Hello, I've problem that sometimes i spent a lot of time search for
appropiated div when i have very granular components and there is a lot of
components let say 1000.
Do you know some best practice to add some attributes to each component to
find it easy in code from browsered html (chrome).
I was trying to use data-testid but it is a little bit weird that in some
cases i don't see data-testid attribute in chrome ? Any ideas what could be
a problem ? Any other ideas how to solve the problem ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/styled-components/styled-components/issues/2959?email_source=notifications&email_token=AAELFVSA7CGSM2GSTTWPI3DQ5HKD3A5CNFSM4KFSIWOKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IFQPNJQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAELFVXQNKZYHNX7F3LACFDQ5HKD3ANCNFSM4KFSIWOA
.

i use styled components

https://github.com/styled-components/babel-plugin-styled-components


Live Progress Slider Bug

since today
can't see progress bar and can't click go to live

Thank you for the report! I have updated the script to address the UI changes in today’s update. Please update to version 0.0.2 from the link : https://github.com/nomomo/Chzzk_Scripts/raw/main/CHZZK_Live_Progress_Slider/CHZZK_Live_Progress_Slider.user.js


Decode shouldn't panic

Hashed ids are often used as part of urls. They are outside of program's control (e.g. a user on the website might manually modify url).
If such modified value is passed to Decode(), it'll panic, which is against Go conventions, see http://blog.golang.org/defer-panic-and-recover:

The convention in the Go libraries is that even when a package uses panic internally, its external API still presents explicit error return values.

It would be better if it was Decode(hash string) ([]int, error).
This would require breaking the API, which might not be a good idea, so an alternative would be to provide additional DecodeSafe (not a great name) or IsValid(hash string) bool so that the string can be checked for correctness before calling Decode().

panic()-ing is not just annoyance but might be a serious issue. If there's a sync.Mutex.Lock() that is unlocked without using defer anywhere in the request handling go-routine, panic will cause permanent deadlock of the whole web app. This happened in my app.

Very good point, will take a look when I get home.

Fixed by 9aaed95555a16b68e19ea27f9a70ad72ee2531c8. There are now versions of Decrypt and DecryptInt64 that return an error instead of panicking.


add autograd to biquad filters

implement feature requested in #1375
Affected functions:

biquad
band_biquad
bass_biquad
allpass_biquad
highpass_biquad
lowpass_biquad
bandpass_biquad
bandreject_biquad
equalizer_biquad

Can we introduce a helper method for Autograd test that handles dtype, device and requires_grad property, so that each test method looks simpler. Example -> https://github.com/pytorch/audio/blob/e4a0bd2ceb6c80ec90194ce519bbd9589926034b/test/torchaudio_unittest/transforms/autograd_test_impl.py

Looks good, will work on it later if I have time.

What about the second order gradient? i.e. gradgradcheck

Current implementation can't support higher order derivative (still use inplace operation internally).
I'm not sure whether there is a need for it, personally a first order derivative is sufficient.


Vulnerability roundup 85: ldm-0.5: 1 advisory [7.8]

search, files

[ ] CVE-2019-20373 CVSSv3=7.8 (nixos-20.03, nixos-unstable)

Scanned versions: nixos-20.03: a84b797b28e; nixos-unstable: 22c98819ccd. May contain false positives.
Cc @the-kenny

False positive: we don't use the run-X-session script that's vulnerable here.


Feature: delete a file and its txt file

Hi,
Just wondering if it'd be possible to have the ability to remove a file and it's text file?
Thanks!

I will try to add the feature soon!


Respond in request content type for 404 in development/test

Purpose or Intent
When the API routes used a globbing pattern, routes that were "not
found" were handled directly in the ApiController itself, and served
up in a JSON format.
Since the routing is now handled by Rails' routing, "not found" routes
are handled by ActionDispatch. In development/test, this serves up a
standard response in HTML format, regardless of the requested content
type.
From the docs:

config.consider_all_requests_local is a flag. If true then any error
will cause detailed debugging information to be dumped in the HTTP
response, and the Rails::Info controller will show the application
runtime context in /rails/info/properties. True by default in
development and test environments, and false in production mode. For
finer-grained control, set this to false and implement local_request?
in controllers to specify which requests should provide debugging
information on errors.

By setting the above value to false in development/test environments,
and indicating that all requests are considered local in
development/test in ApplicationController. Any other requests ("not
found") are not considered local, and hence will be served back the same
response you would see in production, which respects the request content
type. In other words, if you hit an unrouted URI in your browser, you'll
see some HTML, and if you've requested JSON, you'll see a JSON response.
One drawback to this approach is that you won't see any detailed debug
information for 404s, but that may not be much of a drawback.
I also considered the newer config option
debug_exception_response_format. Unfortunately, this wasn't
sufficiently flexible - it can either be set to :default which
preserves the existing behavior, or :api which will serve up JSON
responses for all 404s regardless of the request type, which seemed
undesireable (at least while the app is still supporting server-side
HTML rendering).
Another alternative would be to provide a new route which globs all
requests in the /api namespace and routes them to a special action which
handles 404s for URIs that have not been matched by an existing
route. This would be most similar to what came before, but means we have
to maintain this code (whereas I think there are opportunities for
deletions in the proposed solution), so I am trying to fallback on what
Rails provides as a first attempt.
Fixes https://github.com/ManageIQ/manageiq/issues/9869

Does debug_exception_response_format support a block / method name?
Please do not glob.
I Don't want stack traces for 400 errors.
This approach looks good.
Will this still give stack traces for 500 errors?

Will this still give stack traces for 500 errors?

@kbrock it will if it gets successfully routed

Does debug_exception_response_format support a block / method name?

@kbrock not AFAIK, what I've done here is the documented way of getting fine-grained control of this setting

LGTM

LGTM, @abellotti what do you think?

Anyone up for creating a PR on ActionDispatch to support custom exception responses based on URL prefixes ?  😃
@imtayadeway this is good for now, I've tested in dev mode using both CLI and Web.  Thanks for fixing this.


crash: too much heat?

I made an 3x3x3 reactor, fueld it and let it explode:
https://pastebin.com/8f1BkP8e

It looks like I replace the controller block with lava before the state of the controller is checked, which is causing the game to look for block properties that just aren't there - should be a simple fix :)

Fixed for the upcoming version 2.3 :)


fix missing footer for backup dialog

tested with backup dialog, restore dialog, sample wizard, connect dialog and agent dialogs.

#3036


mount-point connection refused error

Mountpoint for Amazon S3 version
mount-s31.1.1
AWS Region
ap-northeast-2
Describe the running environment
ec2 instance RHEL 7.5OS
What happened?
bash command : mount-s3 {s3_bucket_name} {mount_path}
return : connection refused
SYSLOG message
mount_s3 successfully mounted bucket {bucket_name} at {mount_path}
fuser:: requst: Request Requestid(1): Failed to send reply : Invalid argument(os error 22)
ec2 profile aws3 ls and aws3 cp commands are possible
I'm curious about the cause of the error.
Syslog
Nov 1 18:20:30 {hostname} mount-s3[5423] [DEBUG] mountpoint_s3::instance: got instance info from IMDS identity_document { instance_type "m5.4xlarge", region: "ap-northeast2-2"
Nov 1 18:20:30 {hostname} mount-s3[5423] [INFO] mouint_s3: target network throughput 10 Gbps
Nov 1 18:20:30 {hostname} mount-s3[5423] [DEBUG] moubnt_s3: using instance region ap-northeast-2
Nov 1 18:20:30 {hostname} mount-s3[5423] [DEBUG] list_objects{id=0 bucket=temp0810 contiuned=false delimiter= max_keys=0  prefix=} mountpoint_s3_client:;s3:crt_client::list_objects: new request
Nov 1 18:20:30 {hostname} mount-s3[5423] [DEBUG] list_objects{id=0 bucket=temp0810 contiuned=false delimiter= max_keys=0  prefix=} mountpoint_s3_client:;s3:crt_client:: request finished request_type=Default http_status=200 range=None duration=36.368727ms ttfb=Some(24.582261ms) request_id=MN4124423QX5VQRG
Nov 1 18:20:30 {hostname} mount-s3[5423] [DEBUG] list_objects{id=0 bucket=temp0810 contiuned=false delimiter= max_keys=0  prefix=} mountpoint_s3_client:;s3:crt_client:: meta request finished duration=36.60ms
Nov 1 18:20:30 {hostname} mount-s3[5423] [INFO] fuser:session: Mounting {mount_path}
Nov 1 18:20:30 {hostname} mount-s3[5423] [INFO] mount_s3: successfully mounted bucekt temp0810 at {mount_path}
Nov 1 18:20:30 {hostname} mount-s3[5423] [DEBUG] mountpint_s3::fuse:session: starting fuse worker 0 (thread id 5426)
Nov 1 18:20:30 {hostname} mount-s3[5423] [DEBUG] fuser::request: FUSE( 1) ino 0X0000000000000000 INIT kernal ABI 7.22, cAPABILITIES 0xf7fb, max readahead 131072
Nov 1 18:20:30 {hostname} mount-s3[5423] [DEBUG] mountpint_s3::fuse:session: starting fuse worker 0 (thread id 5428)
Nov 1 18:20:30 {hostname} mount-s3[5423] [DEBUG] fuser::request:  INIT kernal ABI 7.22,flags 0x2021 max readahead 131072, max write 16777216
Nov 1 18:20:30 {hostname} mount-s3[5423] [DEBUG] mount_s3: success status flag received from child process
Nov 1 18:20:30 {hostname} mount-s3[5423] [INFO] mountpint_s3::metrics: fuse.op_latency_us[op=init]: n1: min=22 p10=22 p50=22 avg=22.00 p90=22 p99=22 p99.9=22 max=22
Nov 1 18:20:30 {hostname} mount-s3[5423] [INFO] mountpint_s3::metrics: s3.client.num_auto_default_network_id: 0
Nov 1 18:20:30 {hostname} mount-s3[5423] [INFO] mountpint_s3::metrics: s3.client.num_auto_ranged_copy_network_id: 0
Nov 1 18:20:30 {hostname} mount-s3[5423] [INFO] mountpint_s3::metrics: s3.client.num_auto_ranged_get_network_id: 0
Nov 1 18:20:30 {hostname} mount-s3[5423] [INFO] mountpint_s3::metrics: s3.client.num_auto_ranged_put_network_id: 0
Nov 1 18:20:30 {hostname} mount-s3[5423] [INFO] mountpint_s3::metrics: s3.client.num_requests_being_prepared: 0
Nov 1 18:20:30 {hostname} mount-s3[5423] [INFO] mountpint_s3::metrics: s3.client.num_requests_being_processed: 0
Nov 1 18:20:30 {hostname} mount-s3[5423] [INFO] mountpint_s3::metrics: s3.client.num_requests_stream_queued_waiting: 0
Nov 1 18:20:30 {hostname} mount-s3[5423] [INFO] mountpint_s3::metrics: s3.client.num_requests_streaming_response: 0
Nov 1 18:20:30 {hostname} mount-s3[5423] [INFO] mountpint_s3::metrics: s3.client.num_total_network_io: 0
Nov 1 18:20:30 {hostname} mount-s3[5423] [INFO] mountpint_s3::metrics: s3.client.reuest_queue_size: 0
bash command : mount-s3 {s3_bucket_name} {mount_path}
return : connection refused
Relevant log output
No response

Hello log message commit

We are seeing the same issue on CentOS 7.4 with the RPM from the releases page, but it works as expected on AlmaLinux 8.8.
Will report if a newer version of CentOS 7 or building from source works...

We are seeing the same issue on CentOS 7.4 with the RPM from the releases page, but it works as expected on AlmaLinux 8.8.
Will report if a newer version of CentOS 7 or building from source works...

Hey @Tom9729, do you mind opening a new bug report if you still see the issue? Information specific to your error (which version, logs, etc) will help to identify root cause.

I'll close this issue for now. If you have any more information, please do re-open or open a new issue.


Sync release-v5 with 0.5.6

Branch release-v5 points on v0.5.0 with some backports

@sumo-drosiek Awesome thanks so much for getting the ARM images into the release streams!


If your HKG car isn't supported or doesn't work with stock openpilot, comment your model and dongle ID here. We'll work to get support for these cars in upstream openpilot.

If your HKG car isn't supported or doesn't work with stock openpilot, comment your model and dongle ID here. We'll work to get support for these cars in upstream openpilot.
Originally posted by @adeebshihadeh in https://github.com/commaai/openpilot/discussions/2401

Dongle ID
a3b2d141e497235d
And my car is 2017 Hyundai Santa Fe sport Ultimate 2.0T I need fingerprint to this car
And new update 0.8 com out and my car still car unrecognized please help me

Comment on the GitHub discussion instead of opening an issue


Write peptide pruned database

Hi,
Is it possible to export the identified proteins and/or peptides as a fasta database? this should be particularly useful for peptidomics experiments.
Thanks!
David.
p.s. pressed Enter by accident while writing the header...

That's an awesome idea! It should be pretty easy to implement.
Outputting a "pruned" protein database (containing only proteins identified) is already supported. It's in the "post-search analysis" tab of the search task window.
For outputting a database of peptides, do you have any input on the preferred names for the peptides? We would want them to be unique, such that two unique peptides from the same protein don't have the same accession number.

Hi,
i think the names should be the name/uniprot of the protein + the position of the first aa of the protein (i.e. S307) +a serial number in case there are a few such peptides.
Thanks!
David.

could be the range (first and last aa). Snag with protein groups and shared peptides, which would have multiple proteins and multiple ranges, but could be enumerated.

not sure this is a good general feature for MM. It's something that could be done pretty easy in mzlib. We could make a little script for processing the psms file from MM.

We'll probably be able to get started on this program in about a week. Seems fairly easy to write, it's just parsing text and then writing a fasta database. Updates to come soon...

I haven't put the code on github yet but here's a program that turns MetaMorpheus .psmtsv results into .fasta:
https://github.com/smith-chem-wisc/MetaMorpheus-Peptide-Database-Generator/releases
I did a search of a yeast file, converted the results to a .fasta, then searched again. I went from 17k to 19k PSMs. So maybe the results seem a bit overconfident. But still, it works...

The psms should go up, because the false positive targets were written, but the decoys were not. This results in an underestimated FDR. Tread lightly...

it's a good method for de-novo assemblies from RNAseq or metaproteomics.

FYI. we have a new feature in metamorpheus to use data from multiple proteases in a single parsimony event. peptides from different proteases overlap, and we use this to get improved protein inference. In this case, I can imagine that if you are trying to performm de-novo assembly, overlapping peptides from that would be a big bonus in terms of assigning them to a particular possible rna isoform

Awesome, thank!

Hey Dmorgan (we have a new peak annotation viewer in metamorpheus). download the new release. Select Data/MetaDraw from the menu. load a raw file and a psms file (wait) and then start clicking. let us know what you think.

will do, thanks!


Question regarding HTTPS listeners

Description:
I am having issue using Gateway, I've bee using version from v0.5.0 to latest, today I tried v0.6.0 but still not able to make it work.
My services are accessible with HTTP but not HTTPS.
The same exact config works days/weeks ago using latest but I had CORS errors, then realized it was not CORS because my services returns correct CORS headers but it was because the endpoint was offline randomly. Am I doing something wrong? Thanks!
apiVersion: gateway.networking.k8s.io/v1
kind: Gateway
metadata:
  name: eg
  annotations:
    cert-manager.io/cluster-issuer: letsencrypt
    cert-manager.io/common-name: example.com
spec:
  gatewayClassName: eg
  listeners:
    - name: http-web
      protocol: HTTP
      hostname: example.com
      port: 80
    - name: http-subdomain1
      protocol: HTTP
      hostname: subdomain1.example.com
      port: 80
    - name: http-subdomain1-alias
      protocol: HTTP
      hostname: subdomain1-alias.example.com
      port: 80
    - name: http-subdomain2
      protocol: HTTP
      hostname: subdomain2.example.com
      port: 80
    - name: https-web
      protocol: HTTPS
      port: 443
      hostname: example.com
      tls:
        certificateRefs:
        - kind: Secret
          group: ""
          name: eg-https
    - name: https-subdomain1
      protocol: HTTPS
      port: 443
      hostname: subdomain1.example.com
      tls:
        certificateRefs:
        - kind: Secret
          group: ""
          name: eg-https
    - name: https-subdomain1-alias
      protocol: HTTPS
      port: 443
      hostname: subdomain1-alias.example.com
      tls:
        certificateRefs:
        - kind: Secret
          group: ""
          name: eg-https
    - name: https-subdomain2
      protocol: HTTPS
      port: 443
      hostname: subdomain2.example.com
      tls:
        certificateRefs:
        - kind: Secret
          group: ""
          name: eg-https
---
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
metadata:
  name: foo
spec:
  parentRefs:
    - name: eg
  rules:
    - backendRefs:
        - group: ""
          kind: Service
          name: foo
          port: 3000
      matches:
        - path:
            type: PathPrefix
            value: /
    - filters:
        - type: RequestRedirect
          requestRedirect:
            scheme: https
            statusCode: 301
            hostname: subdomain1.example.com
            port: 443
  hostnames:
    - subdomain1.example.com
    - subdomain1-alias.example.com
---
apiVersion: v1
kind: Service
metadata:
  name: foo
  labels:
    app: foo
    service: foo
spec:
  ports:
    - name: http
      port: 3000
      targetPort: 3000
  selector:
    app: foo
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: foo
spec:
  replicas: 1
  selector:
    matchLabels:
      app: foo
      version: v1
  template:
    metadata:
      labels:
        app: foo
        version: v1
    spec:
      serviceAccountName: foo
      containers:
        - image: example/foo
          name: foo
          ports:
            - containerPort: 3000

@arkodg  I ended up here searching for https in the issues. At first, this infinite loop looked like a bug but apparently, it is the desired behavior and documented in the API specs.
I have found a working example:

one HTTPRoute is bound to the HTTP listener by configuring the sectionName in spec.parentRefs
https://github.com/kubernetes-sigs/gateway-api/blob/main/examples/standard/http-redirect.yaml#L45
the second HTTPRoute must be bound to the HTTPS listener using the same configuration otherwise it won't work.
https://github.com/kubernetes-sigs/gateway-api/blob/main/examples/standard/http-redirect.yaml#L62

My working example.
apiVersion: gateway.networking.k8s.io/v1beta1
kind: HTTPRoute
metadata:
  name: tls-redirect
  namespace: prod
spec:
  parentRefs:
    - kind: Gateway
      name: envoy-gateway
      namespace: kube-public
      sectionName: http
  hostnames:
    - "*.ak1pro.n1l.ro"
  rules:
    - filters:
        - type: RequestRedirect
          requestRedirect:
            scheme: https
---
apiVersion: gateway.networking.k8s.io/v1beta1
kind: HTTPRoute
metadata:
  name: homarr-prod
  namespace: prod
spec:
  parentRefs:
    - kind: Gateway
      name: envoy-gateway
      namespace: kube-public
      sectionName: https
  hostnames:
    - "homarr.ak1pro.n1l.ro"
  rules:
    - matches:
        - path:
            type: PathPrefix
            value: /
      backendRefs:
        - name: homarr
          port: 80

Thanks for the help, the redirection now works correctly but I still get ERR_CONNECTION_REFUSED on HTTPS, I think it was working on some commit after v0.5.0 and before v0.6.0-rc1 but I'm struggling to reproduce. Using cert-manager v1.13.2

@root-io see if this helps, it works for me. I deployed the controller to kube-public
https://github.com/ionutvilie/awesome-home-server/blob/master/ak1pro/kube-public/readme.md
Service-specific HTTP routing is present in the stage Kustomization:
https://github.com/ionutvilie/awesome-home-server/blob/master/ak1pro/prod/httproutes.yaml
From what you are describing it seems like the gateway is not binding on the expected TCP/IP Address (LoadBalancer service).

hey @ionutvilie thanks for creating the example,can you help update our  https://gateway.envoyproxy.io/v0.6.0/user/http-redirect/ docs with a PR to show the http->https redirect case (might also need some extra steps to generate certs which is present here)

@ionutvilie Are you sure you are using v0.6.0, your yaml are using gateway.networking.k8s.io/v1beta1 not gateway.networking.k8s.io/v1?

hi @root-io, I updated the PR, as per my home server configuration, if the API did not warn me I did not notice. :)
I think I blindly copied the examples from the documentation and most of them are with v1beta1 . Atm I'm confused, I'm waiting for a review. I did not had time to figure out how the documentation is structured. Is it ok to change to v1 in 0.6 release or just in latest?
Anyway, the example is tested and it works, hugo runs ok in dev mode.

I've found cert-manager has a compatibility issue with v1: https://github.com/cert-manager/cert-manager/issues/6468


must supply destination port and address in call to Client#statistics

Hi! Thank you for your lib.
I try to use it and have problem on launch.
node app.js
node:assert:400
    throw err;
    ^

AssertionError [ERR_ASSERTION]: must supply destination port and address in call to Client#statistics
    at Client.<computed> [as statistics] (/root/rtpengineclient/node_modules/rtpengine-client/lib/Client.js:57:12)
    at Client.<anonymous> (/root/rtpengineclient/app.js:5:12)
    at Client.emit (node:events:390:28)
    at Client._onListening (/root/rtpengineclient/node_modules/rtpengine-client/lib/BaseClient.js:105:10)
    at Socket.emit (node:events:390:28)
    at startListening (node:dgram:173:10)
    at node:dgram:365:7
    at processTicksAndRejections (node:internal/process/task_queues:84:21) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: 0,
  expected: true,
  operator: '=='
}

Node.js v17.2.0

my code:
const Client = require('rtpengine-client').Client;
const client = new Client('ws://ip:9091');

client.on('listening', () => {
    client.statistics()
      .then((res) => {
        console.log('received data', res);
      })
      .catch((err) => {
        console.log(`Error: ${err}`);
      });
  });

What it can be? How i can fix it?

I m not so smart how i think


Deprecate LightningModule.get_progress_bar_dict

What does this PR do?
Deprecates get_progress_bar_dict from lightning module and moves it to progress bar callback
Fixes #8742
Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[x] Did you make sure to update the documentation with your changes? (if necessary)
[x] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

@ananthsub thanks so much for the helpful feedback! A few questions

Make the default implementation of LightningModule.get_progress_bar_dict return an empty dict

That will make the functionality stop working in the next version, rather than leaving the functionality but giving dep warning, and then later removing it. Is that ok?

Carry the existing implementation forward into a private utility function of the progress bar callback, which accepts a LightningModule and trainer as input args

Does it have to take the trainer as an arg since it already has access to the trainer through the base class ProgressBarBase?
If it is a private function, how can I call it in properties.py?

Deprecate progress_bar_metrics from the Trainer properties

is that just on a separate note, because it isn't used?

@ananthsub for deprecating progress_bar_metrics, can I do that in properties.py and in logger_connector.py?

@ananthsub is this ready to be merged?

@ananthsub is this ready to be merged?

Some conflicts to be resolved.

@kaushikb11 thanks for fixing that and sorry I didn't notice in the first place!


Add Sass like extend

Sass extend is here.
http://sass-lang.com/docs/yardoc/file.SASS_REFERENCE.html#extend
More simple syntax, use +.
.foo {
  width: 100px;
}
.bar {
  +.foo;
}

converted this.
.foo, bar {
  width: 100px;
}

See also test code.

Nice work, I'll have a look!

and the output is also grouped. nice.


[Identity] [External] Could MSAL binaries be compiled once and work even if we switch the Node version?

Currently MSAL extensions use binaries that get compiled during the installation of the dependency. So that if we switch Node versions, these binaries fail. The error says that the binaries haven't been compiled for the Node version we're using. Our current fix for CI is to re-install the dependencies for Identity after switching Node versions. Would it be possible for MSAL to make it so changing Node versions wouldn't break the cache plugin?

An example of the errors I get when I switch from one Node version to another:
Error: The module '/home/codespace/workspace/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/msal-node-extensions<EMAIL_ADDRESS>was compiled against a different Node.js version using
NODE_MODULE_VERSION 83. This version of Node.js requires
NODE_MODULE_VERSION 88. Please try re-compiling or re-installing
the module (for instance, using `npm rebuild` or `npm install`).

External issue: https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/3332

It's not possible to make this happen for GA. Moving this out of the May milestone.

While MSAL has closed this issue: https://github.com/AzureAD/microsoft-authentication-library-for-js/issues/3332
I believe we could continue to think about this problem in case we can provide any help. So I’ll keep this open.

I’ll move this to the backlog since we don’t have a clear picture of when we’ll able to pick this up.