Mobile App Integration

(This issue was created on behalf of Neeboo based on the following forum thread: https://forum.dfinity.org/t/internet-identity-roadmap-update-september-2022/15306/2)
Problem: Mobile Apps, for example Distrikt, are hard to integrate with II. Because II only accept and response to browser window. The integration flow will become as following:

Mobile app needs to load up a browser window page to redirect the authentication payload.
The middle page should be the same url to web version login page of the DApp to make sure the principal ID is the same to both end.
Payload are session publickey , “frontend url” and anchor number.
After II response with a delegation message, this middle page will have to rebuild the delegation chain and get it back to mobile native side to recover the correct delegation identity.

This flow is not very good for mobile DApps, and we need to find a way to remove the middle page and call II’s canister function directly or allow II’s frontend to receive payload from other client software besides of Browser.

Hi @neeboo
Thanks for raising this issue. We also think, that we should streamline the authentication flow. Not only for better interoperability with mobile apps, but also just for the UX improvements.
We have made a recent change to redirect handling in the service worker: https://forum.dfinity.org/t/changes-regarding-redirect-handling-by-the-service-worker/15047
This has previously been a blocker for Plan A. We are now looking into the details of allowing a redirect based authentication protocol.
Could you explain the plans B and C in more detail. For me it is currently unclear, what exactly you mean.

Thanks for moving this topic to Github @frederikrothenberger .
I think  we need II accepts parameters in different ways. Windows.message only lives inside a browser window, which will limit the usage. Other non-browser clients want to connect with II, will have to embed a browser( a compatible one).  For example, what if my ubuntu iTerm want to connect with II's canister?
Right now, we are only consider agent<>canister authentication, but what if we comes to cansiter<>canister authentication, like in the future, user might control canister as his/her account/wallet to interact with other canister. Then we might have an authentication flow like client <JWT/DID> canister <key:id> identityProvider , which will enable a much safer and better way to interaction. More like an open-internet service.

Hi @neeboo
Thanks for the feedback!

I think we need II accepts parameters in different ways.

Yes, this is something we plan on doing ever since we fixed the security issue with redirects.
However, it is also an Internet Identity specific restrictions. Other IDPs such as the ME application or NFID could already make use of redirects.

Right now, we are only consider agent<>canister authentication, but what if we comes to cansiter<>canister authentication, like in the future, user might control canister as his/her account/wallet to interact with other canister.

This is explicitly being picked up by the interoperability discussion in #5 and #6 (requirement R9). Please bring in your point there too, if you feel that we are missing some aspect of inter-canister communication in the current set of requirements.


Can't Recover even I have paper keys

A ransomware infected my computer.
I have 2 paper keys for backup as participation also for the Airdrop. But there's no option for me to choose about any paper keys. Only 1 Device(the infected pc).
I hope I'm still at the participation of the Airdrop.
my log id: 1f96d8e279e048cd4f33a91c

Fixed.


Fix additive scene loading causing duplicate sceneIds by using an offset per scene. Fixes #72

Codecov Report

Merging #109 into mirror will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           mirror    #109      +/-   ##
=========================================
- Coverage    6.47%   6.45%   -0.02%
=========================================
  Files          30      30
  Lines        6240    6240
  Branches      864     864
=========================================
- Hits          404     403       -1
  Misses       5822    5822
- Partials       14      15       +1

Impacted Files
Coverage Δ

Mirror/Runtime/SyncList.cs
82.58% <0%> (-0.45%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91a54f4...2578611. Read the comment docs.


Optimise build speed on travis

Adding an issue here for documentation/reference purposes:
Options to try:

Caching dependencies
Caching compiler outputs
Reduce/share builds of components?
Reduce number of containers in matrix (e.g. don't test all combos of Ubu 14, 16 vs 3 GCC versions)
Cache brew step for Mac test containers?
...

Travis docs suggest ccache: https://ccache.samba.org/
From the limitations section: Only knows how to cache the compilation of a single C/C++/Objective-C/Objective-C++ file. Other types of compilations (multi-file compilation, linking, etc) will silently fall back to running the real compiler.

Limitation implies changing liboqs makefiles to make use of ccache
TODO: result of adding ccache to travis config to "see what happens".

Can the build matrix be split to execute the two run.sh tests independently?


Example: This is a tutorial showing how to put a health bar in your game

How to play your game?

Example  :  Just read it, comment or uncomment things, and hit run.

Code
Check off the items that are true.

[x] The game was made using the Sprig editor.
[x] The game is placed in the in the /games directory.
[x] The code is significantly different from all other games in the Sprig gallery (except for games labeled "demo").
[x] The game runs without errors.
[x] The name of the file/game contains only alphanumeric characters, -s, or _s.
[x] The game name is not the same as the others from gallery

Image (If an image is used)

[x] The image is in the /games/img directory.
[x] The name of the image matches the name of your file. Example: sokoban_plus.js -> sokoban_plus.png.

Thanks for PR!

The Fish in the Sea game wasn't supposed to be updated in this pull request, but I can't figure out how to undo it.

The fish in the sea game should not be updated, but I can't figure out how to delete that commit

The fish in the sea game should not be updated, but I can't figure out how to delete that commit

To remove just change the file putting a previous version with another commit:)

Jet_Box too?

I think everything is fixed now. Everything can be updated and if it messes something up, I'll make another pull request to fix it.

Very interesting tutorial! Do you have an example of use? Just to make sure I understand:)

You could make a game with a health bar at the top or a corner of the screen and have it go down when your character gets hurt. It's just a fancier way to display health than with text on screen.

Do you want me to add the tag "tutorial" or "tool"?

Either tag works, but I've run into other problems that the code causes. I'll fix them as they come up and then re-open this.


Update all icons to more recent versions

This issue is a catch-all for updating ALL the icons in this repo, rather than the individual MR/issues that are open(ed) now.
Individual issues will all be closed in favor of this issue, which takes the highest priority.
(It is assumed that all requests for missing icons will be resolved by using newer sources. If this turns out to be incorrect, those issues should be opened individually.)

I've done a first-cut implementation of the icon update here - https://github.com/phatcher/Azure-PlantUML/tree/feature/iconupdate
I've changed the processing to use the latest icon set and rename the files as per the existing convention, trying to incorporate the new stuff without too many breaking changes.
Have a look and let me know what you think

@Potherca I've pushed a later change which avoids renaming the source files and includes 200+ new icons
Couple of issues...

Some of the icons are malformed e.g. AzureCORS, even though the original svg looks ok - attempted to fix this with conditional FitToCanvas but it's still not working.
I seem to have broken the PPTX generation, but can't figure out why.
Should we remove obsolete services/icons or leave them in the distribution?

Hi! I've had a first look, nothing obviously wrong stands out.
I hope to have more time after the weekend to look into things in more detail and properly address your question.

@Potherca Can you free up sometime to progress this

I got roped into a government project related to COVID, so I've been running low on spare time. Starting this weekend, I should be able to allocate more time to FOSS projects. This project (and the rest of PlantUML StdLib) is high on my list.
I'll keep you posted!

@phatcher I've had some time to look through your feature/iconupdate branch. Could you open an merge-request? That would make it easier to talk about (and resolve) the specific issues you mentioned.

@Potherca Done

I've been incrementally reviewing the MR.
Thing that stands out thus far:

I think we'd want to replaced space characters   in file names with a dash -
The .vscode/.aunch.json contains hard-coded C:/Users/paulh/.dotnet/ ... it should be possible to replace that with a variable, but I'd have to look up what/how
Same for paths in scripts/main.csx, should be variables if at all possible...

I'm thinking of splitting the MR into code changes and SVG/PNG/UML files. My browser doesn't like me looking at the MR much right now...

I'll update the file paths with -
I'll do some research on the hard coding
Not sure if it's possible to split the MR easily since the code + images are tightly coupled due to the change in structure in the official image zip

Not sure if it's possible to split the MR easily since the code + images are tightly coupled due to the change in structure in the official image zip

Fair point. A similar result might also be achieved by splitting the commits between code and non-code changes. Anything splits the binaries and code would help.

@Potherca I've pushed some more changes to the branch

Replaced the   with a -
Replaced the hardcoded path in .vscode\launch.json with ${env:USERPROFILE}
Found a few more official icons, so added them in.

One idea would be that I take a branch from master and just apply the code changes to it, it won't run since all the images will be wrong etc but might simplify your review?

@Potherca I've pushed some more branches, let me know if you want a different pull request...

feature/iconupdate-code : Has all of the code changes
feature/iconupdate-img: Has the new manual images, plus the code
feature/iconupdate: Has everything including the changed dist folder

I've just reviewed the code. The separate branch helped a lot, thank your for that!
It all looks good to me.  I'm currently not on a system that run .NET so I can't run the code right now. Once I've run the code to be 100% sure, this can be merged.
I would like to thank you again for your awesome work on this!


Something is Askew...

I've followed the installation instructions described here: https://github.com/nikkomiu/phoenix_inline_svg/blob/810a33db39903bd8e8a79471fda086cfd29fa742/lib/phoenix_inline_svg/helpers.ex#L7-L11.
I then added an SVG to assets/svg, and in my template:
<%= svg_image("edit", "icons") %>

To which Phoenix errors:
Compiling 2 files (.ex)

== Compilation error in file lib/figgis_web/views/layout_view.ex ==
** (CompileError) lib/figgis_web/templates/layout/app.html.eex:48: undefined function svg_image/2
    (elixir) src/elixir_locals.erl:108: :elixir_locals."-ensure_no_undefined_local/3-lc$^0/1-0-"/2
    (elixir) src/elixir_locals.erl:109: anonymous fn/3 in :elixir_locals.ensure_no_undefined_local/3
    (stdlib) erl_eval.erl:680: :erl_eval.do_apply/6
    (elixir) lib/kernel/parallel_compiler.ex:229: anonymous fn/4 in Kernel.ParallelCompiler.spawn_workers/7

Using the "old style" I at least don't see this error.
Is there something missing in the instructions?

Similar issue was discussed here: https://github.com/nikkomiu/phoenix_inline_svg/issues/25#issuecomment-521411895
Try checking that SVG icons exist in priv/static before compiling.

Closing. This is definitely a dupe of #25.


xxx: test title lint pr bot [the pr is for test purpose]

Signed-off-by: feng-tao<EMAIL_ADDRESS>
Summary of Changes

Tests

Documentation

CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public functions and the classes in the PR contain docstrings that explain what it does

titleLint bot is triggered.


Update raw.json

https://github.com/virtual-puppet-project/.github/pull/1 but modified in the proper location

Thanks!


Elasticsearch + SQL

What's the best (current) way to get SQL working?
https://github.com/NLPchina/elasticsearch-sql/ mentions x-pack-sql and opendistro (but 6.8.4 isn't supported)
https://opendistro.github.io/for-elasticsearch-docs/docs/sql/

Right now, there is no solution for 6.8.4, we are adapting a version of the SQL from opendistro for Elassandra.

On 4 Sep 2020, at 04:03, Andrew Grosser<EMAIL_ADDRESS>wrote:
What's the best (current) way to get SQL working?
https://github.com/NLPchina/elasticsearch-sql/ https://github.com/NLPchina/elasticsearch-sql/ mentions x-pack-sql and opendistro (but 6.8.4 isn't supported)
https://opendistro.github.io/for-elasticsearch-docs/docs/sql/ https://opendistro.github.io/for-elasticsearch-docs/docs/sql/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/strapdata/elassandra/issues/368, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOMPGIVBOSAGWUGGM5SM5LSEBDIZANCNFSM4QWXJRUA.

Can I help with this? What's needed?

Can you give us an estimate for this?

Hi Andrew,
Here is a first release of the Opendistro SQL plugin for Elassandra : https://github.com/strapdata/sql/releases.
It does not support JOIN and DELETE right now because Elassandra 6.8.4 does not support parent-child join and reindex.
Let us now if this works for you.

On 12 Sep 2020, at 21:59, Andrew Grosser<EMAIL_ADDRESS>wrote:
Can you give us an estimate for this?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/strapdata/elassandra/issues/368#issuecomment-691538179, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOMPGOYRKASMWTLCPIUGOTSFPHKBANCNFSM4QWXJRUA.

Thanks mate will take a look.

Working thanks mate. What do you think about merged indexes? This could tide us over until we can do joins?
Ex.:
https://github.com/sfproductlabs/msgxc/blob/86ecc8e787e96881c80232a28d7b94ed527847da/xcs/.setup/schema/cassandra/elastic.1.sh#L136-L143


Storybook logs huge errors/warnings on every nuxt dev build

Current Situation

Storybook logs a huge amount of errors/warnings when building the frontend:
WARN The following packages are incompatible with Storybook 8.2.7 as they depend on different major versions of Storybook packages:
WARN -<EMAIL_ADDRESS>WARN  Repo: https://storybook.nuxtjs.org
WARN -<EMAIL_ADDRESS>WARN  Repo: https://storybook.nuxtjs.org
WARN -<EMAIL_ADDRESS>WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/lib/cli
WARN -<EMAIL_ADDRESS>WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/renderers/vue3
WARN -<EMAIL_ADDRESS>WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/addons/links
WARN -<EMAIL_ADDRESS>WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/builders/builder-vite/#readme
WARN -<EMAIL_ADDRESS>WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/addons/essentials
WARN -<EMAIL_ADDRESS>WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/addons/interactions
WARN -<EMAIL_ADDRESS>WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/lib/test
WARN -<EMAIL_ADDRESS>WARN  Repo: https://github.com/storybookjs/storybook/tree/next/code/lib/blocks
WARN
WARN
WARN Please consider updating your packages or contacting the maintainers for compatibility details.
WARN For more on Storybook 8 compatibility, see the linked GitHub issue:
WARN https://github.com/storybookjs/storybook/issues/26031

[nuxt:storybook:build 1:18:38 AM]  ERROR  Storybook failed to load the following preset: @storybook-vue/nuxt/preset.

Please check whether your setup is correct, the Storybook dependencies (and their peer dependencies) are installed correctly and there are no package version clashes.

If you believe this is a bug, please open an issue on Github.

/home/sara/projects/openverse/node_modules/.pnpm/ufo@1.5.4/node_modules/ufo/dist/index.mjs:630
export { $URL, cleanDoubleSlashes, createURL, decode, decodePath, decodeQueryKey, decodeQueryValue, encode, encodeHash, encodeHost, encodeParam, encodePath, encodeQueryItem, encodeQueryKey, encodeQueryValue, getQuery, hasLeadingSlash, hasProtocol, hasTrailingSlash, isEmptyURL, isEqual, isNonEmptyURL, isRelative, isSamePath, isScriptProtocol, joinRelativeURL, joinURL, normalizeURL, parseAuth, parseFilename, parseHost, parsePath, parseQuery, parseURL, resolveURL, stringifyParsedURL, stringifyQuery, withBase, withFragment, withHttp, withHttps, withLeadingSlash, withProtocol, withQuery, withTrailingSlash, withoutBase, withoutFragment, withoutHost, withoutLeadingSlash, withoutProtocol, withoutTrailingSlash };
^^^^^^

SyntaxError: Unexpected token 'export'
    at wrapSafe (node:internal/modules/cjs/loader:1281:20)
    at Module._compile (node:internal/modules/cjs/loader:1321:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
    at Object.newLoader [as .mjs] (/home/sara/projects/openverse/node_modules/.pnpm/esbuild-register@3.6.0_esbuild@0.21.5/node_modules/esbuild-register/dist/node.js:2262:9)
    at Module.load (node:internal/modules/cjs/loader:1208:32)
    at Module._load (node:internal/modules/cjs/loader:1024:12)
    at Module.require (node:internal/modules/cjs/loader:1233:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/home/sara/projects/openverse/node_modules/.pnpm/mlly@1.7.1/node_modules/mlly/dist/index.cjs:6:13)
    at Module._compile (node:internal/modules/cjs/loader:1358:14)

More info:

  Please check whether your setup is correct, the Storybook dependencies (and their peer dependencies) are installed correctly and there are no package version clashes.

  If you believe this is a bug, please open an issue on Github.

  /home/sara/projects/openverse/node_modules/.pnpm/ufo@1.5.4/node_modules/ufo/dist/index.mjs:630
  export { $URL, cleanDoubleSlashes, createURL, decode, decodePath, decodeQueryKey, decodeQueryValue, encode, encodeHash, encodeHost, encodeParam, encodePath, encodeQueryItem, encodeQueryKey, encodeQueryValue, getQuery, hasLeadingSlash, hasProtocol, hasTrailingSlash, isEmptyURL, isEqual, isNonEmptyURL, isRelative, isSamePath, isScriptProtocol, joinRelativeURL, joinURL, normalizeURL, parseAuth, parseFilename, parseHost, parsePath, parseQuery, parseURL, resolveURL, stringifyParsedURL, stringifyQuery, withBase, withFragment, withHttp, withHttps, withLeadingSlash, withProtocol, withQuery, withTrailingSlash, withoutBase, withoutFragment, withoutHost, withoutLeadingSlash, withoutProtocol, withoutTrailingSlash };
  ^^^^^^

  SyntaxError: Unexpected token 'export'
  at wrapSafe (node:internal/modules/cjs/loader:1281:20)
  at Module._compile (node:internal/modules/cjs/loader:1321:27)
  at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
  at Object.newLoader [as .mjs] (/home/sara/projects/openverse/node_modules/.pnpm/esbuild-register@3.6.0_esbuild@0.21.5/node_modules/esbuild-register/dist/node.js:2262:9)
  at Module.load (node:internal/modules/cjs/loader:1208:32)
  at Module._load (node:internal/modules/cjs/loader:1024:12)
  at Module.require (node:internal/modules/cjs/loader:1233:19)
  at require (node:internal/modules/helpers:179:18)
  at Object.<anonymous> (/home/sara/projects/openverse/node_modules/.pnpm/mlly@1.7.1/node_modules/mlly/dist/index.cjs:6:13)
  at Module._compile (node:internal/modules/cjs/loader:1358:14)

  More info:

  at loadPreset (/home/sara/projects/openverse/node_modules/.pnpm/@storybook+core@8.2.9/node_modules/@storybook/core/dist/common/index.js:150248:13)

 WARN                                                                    nuxt:storybook:build 1:18:38 AM
          Broken build, fix the error above.
          You may need to refresh the browser.

? Would you like to help improve Storybook by sending anonymous crash reports? › (Y/n)  ➜ DevTools: press Shift + Alt + D in the browser (v1.4.1)                                   1:18:39 AM

ℹ Tailwind Viewer: http://<IP_ADDRESS>:8443/_tailwind/                           nuxt:tailwindcss 1:18:39 AM
✖ Would you like to help improve Storybook by sending anonymous crash reports? … yes
attention => Storybook now collects completely anonymous telemetry regarding usage.           1:18:40 AM
This information is used to shape Storybook's roadmap and prioritize features.                1:18:40 AM
[1:18:40 AM] You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
https://storybook.js.org/telemetry                                                            1:18:40 AM
✔ Vite client built in 16ms                                                                  1:18:41 AM
✔ Vite server built in 937ms                                                                 1:18:42 AM

[1:18:42 AM]  ERROR  [unhandledRejection] Storybook failed to load the following preset: @storybook-vue/nuxt/preset.

Please check whether your setup is correct, the Storybook dependencies (and their peer dependencies) are installed correctly and there are no package version clashes.

If you believe this is a bug, please open an issue on Github.

/home/sara/projects/openverse/node_modules/.pnpm/ufo@1.5.4/node_modules/ufo/dist/index.mjs:630
export { $URL, cleanDoubleSlashes, createURL, decode, decodePath, decodeQueryKey, decodeQueryValue, encode, encodeHash, encodeHost, encodeParam, encodePath, encodeQueryItem, encodeQueryKey, encodeQueryValue, getQuery, hasLeadingSlash, hasProtocol, hasTrailingSlash, isEmptyURL, isEqual, isNonEmptyURL, isRelative, isSamePath, isScriptProtocol, joinRelativeURL, joinURL, normalizeURL, parseAuth, parseFilename, parseHost, parsePath, parseQuery, parseURL, resolveURL, stringifyParsedURL, stringifyQuery, withBase, withFragment, withHttp, withHttps, withLeadingSlash, withProtocol, withQuery, withTrailingSlash, withoutBase, withoutFragment, withoutHost, withoutLeadingSlash, withoutProtocol, withoutTrailingSlash };
^^^^^^

SyntaxError: Unexpected token 'export'
    at wrapSafe (node:internal/modules/cjs/loader:1281:20)
    at Module._compile (node:internal/modules/cjs/loader:1321:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
    at Object.newLoader [as .mjs] (/home/sara/projects/openverse/node_modules/.pnpm/esbuild-register@3.6.0_esbuild@0.21.5/node_modules/esbuild-register/dist/node.js:2262:9)
    at Module.load (node:internal/modules/cjs/loader:1208:32)
    at Module._load (node:internal/modules/cjs/loader:1024:12)
    at Module.require (node:internal/modules/cjs/loader:1233:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/home/sara/projects/openverse/node_modules/.pnpm/mlly@1.7.1/node_modules/mlly/dist/index.cjs:6:13)
    at Module._compile (node:internal/modules/cjs/loader:1358:14)

More info:

  Please check whether your setup is correct, the Storybook dependencies (and their peer dependencies) are installed correctly and there are no package version clashes.

  If you believe this is a bug, please open an issue on Github.

  /home/sara/projects/openverse/node_modules/.pnpm/ufo@1.5.4/node_modules/ufo/dist/index.mjs:630
  export { $URL, cleanDoubleSlashes, createURL, decode, decodePath, decodeQueryKey, decodeQueryValue, encode, encodeHash, encodeHost, encodeParam, encodePath, encodeQueryItem, encodeQueryKey, encodeQueryValue, getQuery, hasLeadingSlash, hasProtocol, hasTrailingSlash, isEmptyURL, isEqual, isNonEmptyURL, isRelative, isSamePath, isScriptProtocol, joinRelativeURL, joinURL, normalizeURL, parseAuth, parseFilename, parseHost, parsePath, parseQuery, parseURL, resolveURL, stringifyParsedURL, stringifyQuery, withBase, withFragment, withHttp, withHttps, withLeadingSlash, withProtocol, withQuery, withTrailingSlash, withoutBase, withoutFragment, withoutHost, withoutLeadingSlash, withoutProtocol, withoutTrailingSlash };
  ^^^^^^

  SyntaxError: Unexpected token 'export'
  at wrapSafe (node:internal/modules/cjs/loader:1281:20)
  at Module._compile (node:internal/modules/cjs/loader:1321:27)
  at Module._extensions..js (node:internal/modules/cjs/loader:1416:10)
  at Object.newLoader [as .mjs] (/home/sara/projects/openverse/node_modules/.pnpm/esbuild-register@3.6.0_esbuild@0.21.5/node_modules/esbuild-register/dist/node.js:2262:9)
  at Module.load (node:internal/modules/cjs/loader:1208:32)
  at Module._load (node:internal/modules/cjs/loader:1024:12)
  at Module.require (node:internal/modules/cjs/loader:1233:19)
  at require (node:internal/modules/helpers:179:18)
  at Object.<anonymous> (/home/sara/projects/openverse/node_modules/.pnpm/mlly@1.7.1/node_modules/mlly/dist/index.cjs:6:13)
  at Module._compile (node:internal/modules/cjs/loader:1358:14)

  More info:

  at loadPreset (/home/sara/projects/openverse/node_modules/.pnpm/@storybook+core@8.2.9/node_modules/@storybook/core/dist/common/index.js:150248:13)

Suggested Improvement

Address the errors.
Benefit

We should not have integrations where the integrated tools tell us they are not correctly integrated. It is also confusing to see these warnings and not know immediately whether something you have changed caused them, or what the action is to resolve them.

There's an upstream PR that will hopefully fix this problem: fix: remove Storybook version from storybook.ts

Closing this as won't fix, because it's an upstream issue. Olga's PR got merged, so we're just waiting for a new version of storybook to release and we'll be able to fix this.


Upgrade github action plugin versions

Bump actions/cache from 3 to 4
Bump docker/setup-qemu-action from 2 to 3
Bump actions/upload-artifact from 3 to 4
Bump codecov/codecov-action from 3 to 4
Bump actions/setup-java from 3 to 4

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (59551e4) to head (ce1fd59).

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #12490       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436     2360       -76
  Lines        133233   129485     -3748
  Branches      20636    20078      -558
=============================================
- Hits          82274        0    -82274
- Misses        44911   129485    +84574
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <ø> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <ø> (ø)

java-11
?

java-21
0.00% <ø> (-61.63%)
:arrow_down:

skip-bytebuffers-false
?

skip-bytebuffers-true
0.00% <ø> (-27.73%)
:arrow_down:

temurin
0.00% <ø> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Broken host mapping for ECS

With Elasticsearch 7.0 elastic common schema (ECS) was introduced. This maps the hostname to host.name instead of host. Currently logstash_async fails with:

[2019-04-29T08:04:22,562][WARN ][logstash.outputs.elasticsearch] Could not index event to Elasticsearch. {:status=>400, :action=>["index", {:_id=>nil, :_index=>"logstash", :_type=>"_doc", :routing=>nil}, #LogStash::Event:0x27275849], :response=>{"index"=>{"_index"=>"logstash-2019.04.26-000001", "_type"=>"_doc", "_id"=>"tRAfaGoB1XS_Z1QomfCX", "status"=>400, "error"=>{"type"=>"mapper_parsing_exception", "reason"=>"object mapping for [host] tried to parse field [host] as object, but found a concrete value"}}}}

As a workaround we changed formatter.LogstashFormatter.format to:
message = {
       	    '@timestamp': self._format_timestamp(record.created),
            '@version': '1',
       	    'host.name': self._host,  # <-- FIXED: was: 'host': ...
       	    'level': record.levelname,
            'logsource': self._logsource,
            'message': record.getMessage(),
            'pid': record.process,
            'program': self._program_name,
       	    'type': self._message_type,
        }

ECS sounds great, hopefully it will work and makes the logging world a bit better and more structured.
I think I will implement it here as well, just not yet sure how exactly. Probably with a new Formatter subclass to implement ECS.
The previous behavior probably should stay the default to not break existing setups which are pre-ECS.
So users would have to actively switch to the new scheme.
Until implemented, an easier workaround for ECS/ES7 users is to using the mutate filter plugin in Logstash to reformat the event.
Actually, the mentioned host field is only one example (and it's just crashing here due to the name/type conflict) but ECS defines more fields which should be updated in the Formatter class.

Despite its best intentions(and maybe a little vendor-lockin), ECS claiming ownership over generic and often utilized fieldname like "host" and "agent" I don't think was thoughtout well enough(the seemingly impossible to permanently override beats behavior to send these doesn't help matters).
If this library does adopt a ECS-by-default mode, care to not overwrite user defined fields should be taken as I do not believe the generic terms ECS is using suddenly becoming reserved words is a reasonable stance.


Annotator error

Firstly thanks for the great tool! When I ran TRUST4 on bam file of 10x scRNA-seq, some errors happened in only part of samples. And Rerun did not solve the error. I installed TRUST4 form github. This is the error report
[Wed Oct 23 15:31:29 2024] TRUST4 v1.1.5-r556 begins.
[Wed Oct 23 15:31:29 2024] SYSTEM CALL: /home/wufy/software/trust4/TRUST4/annotator -f /home/wufy/software/trust4/TRUST4/hg38_bcrtcr.fa -a LUAD_RM02_01_final.out -t 1 -o LUAD_RM02_01 --notIMGT  --barcode -r LUAD_RM02_01_assembled_reads.fa --airrAlignment > LUAD_RM02_01_annot.fa
[Wed Oct 23 15:31:29 2024] Start to annotate assemblies.
sh: 行 1: 331782 段错误               (吐核)/home/wufy/software/trust4/TRUST4/annotator -f /home/wufy/software/trust4/TRUST4/hg38_bcrtcr.fa -a LUAD_RM02_01_final.out -t 1 -o LUAD_RM02_01 --notIMGT --barcode -r LUAD_RM02_01_assembled_reads.fa --airrAlignment > LUAD_RM02_01_annot.fa
system /home/wufy/software/trust4/TRUST4/annotator -f /home/wufy/software/trust4/TRUST4/hg38_bcrtcr.fa -a LUAD_RM02_01_final.out -t 1 -o LUAD_RM02_01 --notIMGT  --barcode -r LUAD_RM02_01_assembled_reads.fa --airrAlignment > LUAD_RM02_01_annot.fa failed: 35584 at /home/wufy/software/trust4/TRUST4/run-trust4 line 60.

Much thanks
FY

Could you please share the LUAD_RM02_01_final.out file? This could be a bug.

https://1drv.ms/u/c/1aa2c7aee02dd080/EUEAaRy9kFpLjtheB1OupfYBMcKNS40HxqptRv_re3Yh0g?e=NtRAwz
This is the file

If it is feasible, could you please share the toassemble_1/_2/_bc files with me? I'll look into this issue. Thanks!

https://1drv.ms/u/c/1aa2c7aee02dd080/EUAk7Jb3SSROs7wBYeSoQ64B_7gFKUXTGOu5JA0jp8_iMA?e=qhhu5d
This is the toassemble_bc file. No toassemble_1/_2 files generated.

v1.1.4 works fine. Much thanks! If you need more files, please let me know

It seems the >ACGATGTGTGACGCCT-1_8494 contig is empty in the final.out file. This could be a bug in recent code, and might take some time to debug. You may test whether TRUST4 v1.1.4 from the release page or bioconda works on your sample. Thanks.

I guess your data might be single-end for the sequencing part then. Do you have the "toassemble.fq" file? Thank you!

https://1drv.ms/u/c/1aa2c7aee02dd080/EQawvSNtcJhKpI2yFnhF1LQB0yZQTiB9bMoyb9fcNTMqoQ?e=7E6Ajn
These are the files generated by TRUST4

I guess your data might be single-end for the sequencing part then. Do you have the "toassemble.fq" file? Thank you!

Thank you for sharing the file. Based on the data, I have reproduced the error and fixed the bug. The error happens to some reads with too many Ns, and the main assembly program may make them empty strings and use in the assembly causing some empty contig in the output. I have pushed the code to the master branch, could you please give it a try? Thank you!

Now no errors reported by TRUST4. But I still have few questions (I am new to TCR/BCR analysis, sorry for the questions may be silly to you :) )

Do I need to rerun TRUST4 for samples which results have been successfully generated by TRUST4 v1.1.4?
Is it normal that only a part of B cells and T cells have TCR and BCR records in TRUST4 results?
What is the meaning of *_report.tsv for scRNA-seq data? the sum of counts in this file is larger than number of records in *_barcode_report.tsv.
If I want to calculate the percentage of expanded T/B cells (clone size >1 in some articles) in a sample, could you please give some suggestions based on TRUST4 results or other recommended anaylsis pipeline?

Much Thanks!

Thank you for testing!

Do I need to rerun TRUST4 for samples which results have been successfully generated by TRUST4 v1.1.4 after this fix?
Is it normal that only a part of B cells and T cells have TCR and BCR records in TRUST4 results?

It's more important to use a consistent version of software to analyze your data. Since TRUST4 v1.1.4 is a formal release, you can use that version. The formal v1.1.5 probably will take some time to release, I still need to fix several other parts. It is normal that only part of T and B cells can have TCR,BCR results. I guess your data is not VDJ amplified, so the each cell will have few number of reads from the receptor region and the sensitivity is not super high.

What is the meaning of *_report.tsv for scRNA-seq data? the sum of counts in this file is larger than number of records in *_barcode_report.tsv.

The report is aggregated count for each chain's clonotypes (V,J,C and CDR3). Each row in the barcode_report file is for a cell, so there can be two items/chains for each record so the report can be longer than the barcde_report file. In single-cell analysis, I would suggest use the barcode_report/barcode_airr file. You can use it to overlay the barcodes passed the Seurat/Scanpy-qc and the results will be better.

If I want to calculate the percentage of expanded T/B clones (clone size >1 mentioned in some articles) in a sample, could you please give some suggestions based on TRUST4 results or other recommended anaylsis pipeline?

You can either use your own script that the cells with the same TRB/IGH CDR3 as the clonotype, or use packages like scRepertoire or scirpy for that.

Thanks for suggestions!


Problem in distributed training on Sun Grid Engine (sge)

I've encountered the following error when running the train_mnist.py using dmlc_sge.py. I created 2 worker node and 1 server node and submit all of them on a single machine. I tested dmlc_local.py but it worked fin. I don't know where the problem comes from, could anyone help? Thanks a lot!

[13:04:31] ./dmlc-core/include/dmlc/logging.h:215: [13:04:31] ./ps-lite/include/ps/internal/van.h:56: Check failed: ready_ call Start() first
Traceback (most recent call last):
  File "train_mnist.py", line 127, in <module>
    train_model.fit(args, net, get_iterator)
  File "mxnet/example/image-classification/train_model.py", line 11, in fit
    head = '%(asctime)-15s Node[' + str(kv.rank) + '] %(message)s'
  File "mxnet/python/mxnet/kvstore.py", line 281, in rank
    check_call(_LIB.MXKVStoreGetRank(self.handle, ctypes.byref(rank)))
  File "mxnet/python/mxnet/base.py", line 77, in check_call
    raise MXNetError(py_str(_LIB.MXGetLastError()))
mxnet.base.MXNetError: [13:04:31] ./ps-lite/include/ps/internal/van.h:56: Check failed: ready_ call Start() first

It seems like the problem is due to the KVStore was not correctly created for os.environ['DMLC_ROLE'] = 'server'. The same error would happen if I assign it to a irrelevant string. But setting it to "worker" doesn't cause any problem. Does anyone know if there is a method to get some error message from kvstore.create() function?

Solved this issue by setting the environment variable before calling the file


Pressing Escape key makes rapid requests, even with no modals open

Issue: When pressing Escape key, the app makes requests, even when no modals are open.
When holding the key, it becomes a horse race on network tab.
If I understand correctly, this is because of some kind of shared event listener.
Would it be possible to track how many modals are open, and skip requests if there is none?
Alternatively, maybe some kind of throttling, if the first option is not viable.

+1 for this issue, the escape key shouldn't fire an ajax requests when no modals are open.
Changing keydown to keyup below would be a quick way to prevent holding down Escape firing off loads of requests.

Fixed https://github.com/wire-elements/modal/releases/tag/1.0.6
Thanks for reporting


Location in display

This, although incredibly vague (I mean... non-existent) may be related to the issue I'm having.
'Location' being a link is mandatory and present and I see the logic.
What if the location is an address, a city or a place name?
I think the ability to have 'Location' as a link or simple text after the time would be a great addition.

sorry, it was a hastily made suggestion from the discord
Location as text instead of just the link, exactly what you're describing


[firebase_auth] Fix codeAutoRetrievalTimeout callback never called (#22725)

Fix misprint that caused codeAutoRetrievalTimeout callback never to be called.
Issue: https://github.com/flutter/flutter/issues/22725

I signed it!

@alex-thmv the line has been moved to this file 👇, but the problem is still there. Could you update the patch?
https://github.com/flutter/plugins/blob/60b26f29f56998c9e41a8f50fa7eb7b42fb57d54/packages/firebase_auth/lib/src/firebase_auth.dart#L432

Sorry for the delay on the PR, however it looks like PhoneCodeAuthRetrievalTimeout is being used for this field and should work as expected.

Sorry for the delay on the PR, however it looks like PhoneCodeAuthRetrievalTimeout is being used for this field and should work as expected.

Yes, seems that it is aleady fixed.


Keep \not predicates

Reviewer checklist

[ ] Test coverage: stack test --coverage
[ ] Public API documentation: stack haddock
[ ] Style conformance: stylish-haskell

Could you add, in the PR description, an example where it's better to use and(not) instead of not(or)? I know that the PR title provides a hint, but it would be nice to also have something that says what this PR solves instead of just hinting at it.

an example where it's better to use and(not) instead of not(or)

Ah, that's not even the point of this pull request, so probably we should discuss this more!
Before this pull request, we constructed the not(or) of multiple terms by combining the predicate and substitution with the term. We don't want to do that because it forgets information learned during simplification, and it violates the predicate-simplifier's assumption that the result of simplifying a predicate has a \top term. I only made it return and(not) because that was the most obvious way to keep terms and predicates distinct using the existing Not.makeEvaluate and And.makeEvaluate. An and(not) condition is stronger (easier to refute) but this also produces more branches because Not.makeEvaluate often returns multiple results.


spring aop with doc service

Description:
when i run official  spring-boot-minimal demo . It Usea  spring @Validated annotation .
@Component
@Validated
@ExceptionHandler(ValidationExceptionHandler.class)
public class HelloAnnotatedService {
...
}

DocService  class Specification is something like HelloAnnotatedService$$EnhancerBySpringCGLIB$$8b7cb243 because of aop of the spring . That may be a dynamic class name which is not friendly to partners.
Question

Is there anyway to  support custom service name  in doc service ?   Thank u very much .

Is there anyway to support custom service name in doc service ?

It is not supported at the moment.

DocService class Specification is something like HelloAnnotatedService$$EnhancerBySpringCGLIB$$8b7cb243

I think the enclosing class created by cglib should be peeled by the following utility method for DocService. https://github.com/line/armeria/blob/49054ad7f22a7f2d64faaeb694674b0df09ad165/core/src/main/java/com/linecorp/armeria/internal/server/annotation/AnnotatedService.java#L644-L653


shrinkwrap error with peerDependencies wp version

Summary of the changes (Less than 80 chars)

Add peer dependency for webpack: "^3.3.0", fix  npm shrinkwrap problem  with newer webpack version

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

any ETA on this? We have a probably related issue with a webpack plugin.

Can you also upgrade on the "aspnet-webpack-react" package?

is there any progress on this matter?

We also need this change implemented. Any ETA or reason for not merging the PR?
Keep up the good work and thank for being awesome again, Microsoft!

This is still not solved. I get the error
<EMAIL_ADDRESS>has incorrect peer dependency<EMAIL_ADDRESS>|| ^2.1.0-beta".
current version is<EMAIL_ADDRESS>

What about webpack 4, is it compatible? Might as well add that too, then?


Fix FormatException while deserialize Instrument

The issue is described into this discussion

There are more instances where this can happen. Will merge after confirmation. 👍

@Exellion Can you give me a minimal example to reproduce the exception?
I tried the following after changing my system locale:
Console.WriteLine(Convert.ToDecimal("0.25")); // 25
Console.WriteLine(Convert.ToDecimal((float)0.25)); // 0,25

Although logically wrong, they didn't produce FormatException.
Am I missing something here? Sorry I'm new to locale related things.

@ajinasokan Your example is correct. You should play with regional settings to reproduce the issue. Please, look into my windows regional settings screen:

If "Decimal symbol" is "." (dot) then FormatException won't be produced, but in all other cases it will produce FormatException.
You can find detailed explanation about invariant culture in this stackoverflow question

@Exellion I moved those changes to Utils to make it available globally so that all responses will have this conversion.
Can you verify this once from your side? Will merge after that.


TaxBrain suggestions

I have recently started using TaxBrain and am very impressed.  The user interface is clean and handsome, and the speed at which the tax calculations are done is truly impressive.  And it is cute that TaxBrain winks at me while it is thinking.  So, congratulations to T.J. and all the others who have contributed to the development of TaxBrain.
But, as impressive as it is now, TaxBrain can be made even better.
I would like to raise two related issues that would allow TaxBrain to provide policy analysis capabilities that are already built into the underlying Tax-Calculator, but that TaxBrain currently does not offer.  The first has to do with the Start Year and the second has to do with multiple-year-reform specification.  These two issues are interrelated, so please bear with me as I explain them one at a time.
Start Year
It seems to me that the Start Year combines two distinct concepts: the first year policy parameters can be changed and the first year of the ten-year budget window for which output is displayed.  I'm not sure what terms best describe these two concepts, so I'm hoping for some discussion about what terms should be used in TaxBrain.  But, in order to explain my suggestions, I need to use precise language.  In this discussion I use the following terms for these two concepts:
First Reform Year is the year for which parameter values are shown in the boxes.  I suggest, for reasons that will become apparent below, that we limit the range of first-reform-year values to be from 2013 (the first year for which Tax-Calculator has tax policy parameters) to 2016 (the last year for which Tax-Calculator has known, rather than projected, tax policy parameters).
First Budget Year is the first of ten years for which we show the basic tax output.  Obviously, the chosen first-budget-year value must be no less than the chosen first-reform-year value and no greater than 2017 (because, at the moment, Tax-Calculator cannot project beyond 2026).
Multiple-Year-Reform Specification
Tax-Calculator has the ability to handle complex multiple-year reforms that cannot easily be specified in TaxBrain.  Let me give an example.  Suppose I want to specify a reform in which the "Maximum Taxable Earnings for Social Security" (MTE) parameter is raised to $300,000 in 2020, indexed thereafter, then raised to $400,000 in 2024, and indexed thereafter.  (This example could use any indexed tax policy parameter; there is nothing special about the use of MTE parameter.)  You can see right away that the problem is a TaxBrain user has no idea about what to specify for the MTE value in the years between the first reform year and 2020 or for the years 2021-2023.  Now, it is possible for the person using TaxBrain to download the Tax-Calculator source code from Git Hub, find the default price-inflation and wage-growth rates in the Policy class, get out a calculator, do the indexing calculations by hand, and then enter in the TaxBrain box the calculated MTE values for all the intermediate years (assuming there is enough space in the box to do that).  But, I think, we can all agree that this is far from an ideal TaxBrain user experience.
There is an easy way to avoid this problem.  Here is how I suggest specifying this example reform in the TaxBrain MTE box, under the assumption that the first-reform-year value is 2016 (and therefore, that the first value shown in the box is 118500):
118500,*,*,*,300000,*,*,*,400000

The * character indicates that the indexing rule for that policy parameter should be used to compute that year's parameter value.
It would be straight forward for TaxBrain to be able to read that string in the MTE box and translate it into a reform that can be passed to the Policy class implement_reform() method in the Tax-Calculator.
Conclusion
If you have read this far, I hope you will comment on these TaxBrain suggestions and offer ideas that would be better than what I've suggested.
And I also hope that some of you are on the edge of your seat saying "But wait, Martin, you've overlooked another problem!"  Indeed there is another issue, but it is less important to resolve than the two discussed above.  It has to do with how to tell TaxBrain in what year to change a parameter's indexing rule.  Right now, there seems to be no way to say, in the context of the example above, leave the 2024 MTE value of $400,000 unchanged in subsequent years (that is, change the MTE parameter from being indexed before 2024 to being not indexed in years after 2024).  There is a way to specify such a reform in Tax-Calculator, but the current version of TaxBrain does not seem to have the same capability.  If you have ideas about how to handle this third issue, by all means, share those ideas in the discussion of this issue.  If not, I'm happy to leave this third issue for later.
cc @talumbau @zrisher @mistakevin @johneo

@martinholmer, the asterisk approach is very elegant and I like it a lot. Splitting the first reform year and first budget year also make sense, although I don't like having to give the user another option to understand and fiddle with. I suppose it won't be too bad though because most users will want to stick with the defaults.
What do others think?
@martinholmer, as to the smaller issue you raised at the end of your comment:

"Right now, there seems to be no way to say, in the context of the example above, leave the 2024 MTE value of $400,000 unchanged in subsequent years (that is, change the MTE parameter from being indexed before 2024 to being not indexed in years after 2024)."

I'll second that it is not as urgent as the other issues. In fact, there is currently a way to do this, although it is somewhat inelegant:
118500,*,*,*,300000,*,*,*,400000, 400000, 400000
cc @feenberg, @talumbau, @zrisher, @mistakevin, @johneo

Matt said:

@martinholmer, as to the smaller issue you raised at the end of your comment:

Right now, there seems to be no way to say, in the context of the example above, leave the 2024 MTE value of $400,000 unchanged in subsequent years (that is, change the MTE parameter from being indexed before 2024 to being not indexed in years after 2024).

I'll second that it is not as urgent as the other issues. In fact, there is currently a way to do this, although it is somewhat inelegant:

118500,*,*,*,300000,*,*,*,400000, 400000, 400000

Matt,  Good point about how to turn off the indexing of a parameter in some future year.
But is there a way to go the other way?  Can a not-indexed parameter be turned into an indexed parameter in some future year?  But again, these are minor issues relative to the main points being discussed in this issue.
cc @MattHJensen @feenberg, @talumbau, @zrisher, @mistakevin, @johneo

As I continue to use TaxBrain, I find it annoying that I have to type in the default value of a policy parameter for the start year.  When I start to type the default value in the text box disappears (as it should), but the default-value message just below the text box does not immediately appear until I tab out of the text box.  This leaves me, and other TaxBrain users with less than perfect short-memory recall, wondering what they should type.  If it is a reform value, I have it in mind.  But if I am specifying a reform in which the parameter does not change until after the start year, then the current version of TaxBrain requires me to retype the start year default (i.e., current-law policy) value.  This is inconvenient and error-prone and a completely unnecessary burden on the TaxBrain user.
Consider a situation where the start year is 2016 (because some policy parameters are changing in that year) but the social security maximum taxable earnings (MTE) parameter is not scheduled to change until 2018 when it will rise to $300,000. Why not allow this way of specifying this change in MTE?
*,*,300000

In other words, I'm requesting the same TaxBrain enhancement as discussed above in this webapp-public issue #151, except that the ability of TaxBrain users to use the * character is extended to include the start year.
cc @MattHJensen @talumbau @mistakevin @feenberg @zrisher,

In other words, I'm requesting the same TaxBrain enhancement as discussed above in this webapp-public issue #151, except that the ability of TaxBrain users to use the * character is extended to include the start year.

@martinholmer, that makes a great deal of sense.
This request would also assist @martinholmer's TaxBrain / Tax-Calculator Selenium comparisons in https://github.com/open-source-economics/Tax-Calculator/tree/master/taxcalc/taxbrain.
@talumbau, do you, @mistakevin, or someone else from your team have time to tackle this in the next week or two? I think this ought to be a higher priority than displaying the 'params-used' on input and output pages given the interaction with testing.

OK, I will take a crack at this. I think @mistakevin will be back online soon.There is some default "format checking" for the kinds of input fields we use, so if our inputs fields reject the asterisk symbol, we can just make our own custom input fields. assigning to myself.

T.J. said:

OK, I will take a crack at this. I think @mistakevin will be back online soon.There is some default "format checking" for the kinds of input fields we use, so if our inputs fields reject the asterisk symbol, we can just make our own custom input fields. assigning to myself.

My experience is that the current version of TaxBrain does not reject something like this:
*,*,400000

TaxBrain accepts this input string and proceeds to produce nonsense results.
@talumbau @MattHJensen

oh this is good to know. thanks @martinholmer

Recent revisions to TaxBrain logic have implemented the *,*,*,500000 style of reform, so this issue is being closed.

The delayed-reform TaxBrain enhancement (using the * notation) that was suggested in issue #151 (which was opened on February 12, 2016) is still not working correctly.  So, this issue has been reopened and will be closed when TaxBrain can handle delayed reforms for all policy parameters.  This is not a minor enhancement, but rather brings to TaxBrain essential capabilities that have been in Tax-Calculator from the beginning.  So this enhancement should be a high priority.
@MattHJensen @talumbau

As far as I can tell from my selenium testing of TaxBrain, the delayed-reform TaxBrain enhancement (using the * notation) that was suggested in issue #151 is now working correctly.  At least my tests are not generating any "500 Internal Server Error!" messages.
@MattHJensen @talumbau


📝 Fix alembic links in /docs/tutorial/sql-databases.md

📝 Docs preview for commit 9b071a84b92e8a6f31089db54b59a7ec7be8ccd2 at: https://a58591d3.fastapitiangolo.pages.dev

Hi @jangaza :nerd_face:
This one was handled in #11628. Given that, we'll close this one, but thanks for the interest! :v:


lbrycrdd allows broadcasting transactions containing invalid updates

broadcast will send transactions containing claim update outputs where the claim id is invalid. Invalid claim id sizes as well as incorrect or non-existent claim ids all get through. Attempting to broadcast such transactions should return a transaction rejected error.

Someone to work on?

@jackrobison if you're able include the specific examples of transactions you're able to broadcast but should not be able to, it'd make this ticket stronger.

https://github.com/lbryio/lbrycrd/pull/192

Just noting that #192 does not solve the issue posted.

The sendrawtransaction method relays messages even if they aren't accepted into the local memory pool. This has been repaired in the upstream bitcoin, in mid 2016.

This is fixed now that we have the upstream master merged.


OpsServerInstall fails when using a single PRVC file

If you have a single PRVC file that contains entitlements for Server and Portal (and others), and set the values for paths to both the server and portal license in the InstallSettings.bat file to this single file, OpsServerInstall.bat fails
Mitigation was to separate the entitlements to two separate PRVC files, then the batch file ran successfully.
(discovered by Esri Italy at TEM)

@kerryrobinson I did more testing and the problem is with the SoftwareAuthorization.exe. It only authorizes the product that is listed last in the .prvc. So for example I have a .prvc file with the entries for ArcGIS Server and it's extensions, which I edited to include portal at the end of the file. When I run the SoftwareAuthorization.exe so I can interact with the GUI I see that the product that is being authorized is Portal for ArcGIS.
How was the .prvc file that Italy was using generated? Did they manually edit the file to include both authorization numbers for both server and portal or that was the way the file was generated by Customer Service.
I'll talk with the licensing dev team, but would like to know how this file with both number was generated before I talk with them. Thanks.

OK, I’ll see if I can find out.

@elinz, I checked with Gianluca and he said the PRVC file was created by the Esri customer care site, including multiple products:
ArcGIS Server = ECPXXXXXXXXX
Portal for ArcGIS = ECPXXXXXXXXX
GeoEvent Processor Server = ECPXXXXXXXXX
Image Server Extension = ECPXXXXXXXXX

@kerryrobinson Thank you. This will help me when I talk to development; in my opinion if the Esri customer care site is generating the .prvc file this way then the software authorization .exe should support it, and currently is not. I will submit this in this weeks' portal holistic.

@kerryrobinson I checked with the license team and having multiple products in a .prvc file is a known limitation of the SoftwareAuthorization.exe So the only solution currently, is to place the portal authorization number in a separate .prvc file. The fact that the Customer Care site is generating a .prvc that is not supported is an outstanding issue.
@elinz Action item for me is to add a note in the InstallSettings.bat and Install Guide doc that you MUST use a separate .prvc file for server and another one for portal.

Fixed in Esri\ops-server-config v.next.


get graph

hello, I want to know how to get this graph, thanks！

Hi, Please find the visualization code here: https://github.com/xuehansheng/RepBin/blob/main/visualize.py


Fix netlify deploy bug

DESC

building of page on netlify fails - displays error that env variable BASE_URL was not set.
deployment fails
solution: BASE_URL setup works via local updates - reduce error to console print instead of full error

TODOs

[ ] solve

implemented


Fix DoS vulnerability

Fixes a RE DoS in Connaisseur
Description
This MR contains multiple commits. One fixes a RE DoS in Connaisseur's validation of TUF data. Another improves the conceptually (but technically unrelated) handling of timeouts of asynchronous function calls. The remaining commits handle a new type of commit header, which will allow us to automatically publish the Helm charts with a sec release annotation.
Checklist

[x] PR is rebased to/aimed at branch develop
[x] PR follows Contributing Guide
[x] Added tests (if necessary)
[x] Extended README/Documentation (if necessary)
[x] Adjusted versions of image and Helm chart in Chart.yaml (if necessary)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (62e2d09) 96.64% compared to head (a9b4bcb) 96.64%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1407   +/-   ##
========================================
  Coverage    96.64%   96.64%
========================================
  Files           23       23
  Lines         1343     1343
========================================
  Hits          1298     1298
  Misses          45       45

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Declare required dependency on check package

Fix ReferenceError: Match is not defined when this package is loaded
before the check package

I created this repo to reproduce the error. This only happens when using this package from another package (meteor apps are safe since it appears meteor is loading check prior to any packages loading, which would explain why I couldn't reproduce this error in a meteor app).

Thanks for this PR. I will review it and merge then I'm back from vacations.

Cool. Take your time. Thanks for responding!

Thanks!


basic vue-lodash usage - errors inside component

I'm doing sth wrong, but following your instructions, I installed globally vue lodash
import Vue from 'vue'
import lodash from 'lodash'
import VueLodash from 'vue-lodash'

Vue.use(VueLodash, lodash)

now using computed in one of my component:
debounceText: {
        get() { return this.proTemplateAdd; },
        set: this._.debounce(function(newValue) {
          this.proTemplateAdd = newValue;
        }, 100)
      },

I've got: Uncaught TypeError: Cannot read property 'debounce' of undefined
using Vue._.debounce(function(newValue)
I've got: Uncaught ReferenceError: Vue is not defined
I'm beginner in Vue, so I will be happy to see what I'm doing wrong.
Now I'm using just import _ from 'lodash' in my component and it works fine...

Same here,
this._
is undefined in Components.

That seems weird, let me try and will response to you soon.

Hi, @kwojt @gileneusz . I just tested with the latest vue.js version<EMAIL_ADDRESS>and it works as intended.
Can you guys provide more details on how you are using it? Ex. Vue version, Single Page Component with webpack or not and so on.
Thanks for the report!

@gileneusz Sorry, you don't need reproduction, I should have spot your problem earlier (wasn't looking to close). :)
For your above example, it seems like the problem is not related to vue-lodash.
The reference here of this is not in the scope, notice that for any vuejs syntax for methods or function, keyword this will only be able to reference inside the created function; however here, you are creating a function and passing its reference where this is not defined.
In other words, if you have
methods: {
    random: this._.random(20) // 'this' is not defined
    randomWorking () {
         this._.random(20) // here this == Vue
    }
}

For you learning, you can try create a test method that does the following:
(Note that the first one needs to be commented out if you want the second one to work.)
    test () {
         console.log(this.random())
         console.log(this.randomWorking())
    }

For the second thing using the Vue._.XXXX methods.
The reason of Vue is not defined error shows up is that you do not import the Vue object with:
import Vue from 'vue'

!!!!! In the component that you are testing.
Even if you did that in main.js or index.js, you are not able to reference it here, consider other plugins like axios, unless you use global axios plugin such as vue-axios, it has to be imported in each of the component.

Oh my, I just saw what I did.
I tried to use this._.isUndefined() not directly in Vue component, but in additionall class, which I was using in it :P So basic mistake...


Fix hugo bug in 0.58.3

When loading the site on 0.58.3, the error 'Transformation failed' occurs. This appears to be a result of this hugo issue: https://github.com/gohugoio/hugo/issues/6274

nevermind


Support QueryId auto derive by CLI

#[derive(QueryId)] will be provided as a default config parameter in
the diesel.toml config, so we should not manage it on our end anymore.
This is a breaking change, so we probably want to:

wait until what's described in the comment at
https://github.com/diesel-rs/diesel/pull/3297#issuecomment-1232809465
is applied on diesel master
merge this
wait until it's released in the 2.0 diesel CLI
release this as diesel-derive-enum 2.0

so that CIs won't ever auto-break during this process

https://github.com/diesel-rs/diesel/pull/3308 was merged so I think we can now merge this

Thanks!


Botframework and formatting

Hello everyone,
We are using botkit on our own express server.
We already used it to connect bots through facebook, slack and twilio SMS. These are mostly working fine at the moment.
However, today we tried to also integrate Skype thanks to Bot Framework, we followed similar steps as Twilio SMS because they seemed very similar in implementation (only webhook to provide, an ID and a secret).
Then we tried our bot, directly from the Bot Framework platform. Messages are indeed sent, we receive them in our end, then feed the request body to our spawned bot (with proper ID and password).
Here we have our first error : Botkit looks for an address field but does not find it.
We thought : "Alright, let's simply format the request body upon reception to an IMessage".
So we did.
Then we got our second error, upon response of our bot, the Controller precise that fields are missing, especially : address.
ERROR: ChatConnector: send - Message is missing address and serviceUrl
Does anyone got this error and have some advices for me ?
Have a great day !

Can you please show the code for how you're passing the body to the controller?

Thank you for answering.
Hmmm, as I have multiple bots that can run on my platform, controllers are created (or getted) on the fly by a factory. But, in the end, it calls :
const controller = Botkit.botframeworkbot(conf)
const bot = controller.spawn({})
if (req.body) {
    controller.ingest(bot, req.body, res)
    res.status(200);
}

Did we miss something?


New feature: filterable columns

Overview of the problem
Buefy version: 0.5.4
Vuejs version: 2.5.2
OS/Browser: all
Description
It would be nice to have a «filterable» feature for columns. Right now, I can accomplish this with the header slot. But this approach is a bit hacky. Ex:
      <template slot-scope="props" slot="header">

          <v-select
            v-model.sync="selectedOwnership"
            placeholder="Filter by owner"
            :options="allOrgs"></v-select>

          <v-select
            multiple
            v-model.sync="selectedEngines"
            placeholder="Filter by engines"
            :onChange="filter"
            :options="allEngines"></v-select>

        {{ props.column.label }}
      </template>

Also, if I use this approach, the headers disappear when in mobile mode. The filters should be some how visible (like the sort still visible on its own).
Here's a picture on how it should look:

I submitted a summary of issues(contains scenario about add filtering function in header slot) about table component at  #495. Welcome to join the discussion.

I need this in my app too. Currently, I'm doing something like

   <template v-if="props.index === 0">

   </template>
   <template v-else>
     {{ props.row.id }}
   </template>

and this works. However, if I use pagination, it throws off the total number of rows. Because for the above to work, I have to unshift a dummy value to the data array that I pass to b-table.
Now if only it was possible to insert static rows that are completely decoupled from data then implementing this would be a breeze.

in need of this feature too


Ensure spell check is enabled for smaller data entry boxes

From our accessibility testing the following was mentioned:
The smaller text boxes e.g. what project are you planning did not have spellcheck enabled but the larger free text boxes e.g. Project Abstract did.

I'm not 100% sure how to test this one. On one plan I have I can see 'NERC' underlined in red in a project details abstract. This may be coming from browser rather than an accessibility feature in tool.
Any advice @johnpinto1

I am sorry I do not know how to test this one - I am adding this to our meeting on Tuesday morning so Sam/Ray can show us

@sjDCC @magdalenadrafiova  spellcheck: "true" is a HTML 5 attribute that has been added to all tags. So the browser if it supports HTML 5 will highlight spelling errors for your locale.

Now when I go into create a new project and I start filling the details there is a spell check enabled for the front page - for the title of the new project. Seems fine closing this.

Reopening b/c we're not seeing the feature in tinymce boxes.

I'm not clear if this was enabled @xsrust? I don't see the spell check feature in data entry boxes.
I have heard from several users that they would like to see a spell check feature, so unless it's a real drag on the application I think it is worth enabling. My Chrome browser was not picking up spelling errors when filling out a test DMP in the app.

that has not been deployed just yet

seems to be working @mariapraetzellis  you want to try too?

Looks good for me too. Closing out

Looks good to me as well.

Sorry to have to re-open this but the spell checker still doesn't work for all data entry boxes. For example, notification title box (it works for the body box).

Will look at this now.

@dsisu this works for me now, are you okay to confirm and close out or update with details of where you still encounter issues please?


merge devel into main

Codecov Report

Merging #7 (357e386) into main (1e53785) will increase coverage by 0.12%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   86.11%   86.24%   +0.12%
==========================================
  Files          21       21
  Lines        1520     1563      +43
==========================================
+ Hits         1309     1348      +39
- Misses        211      215       +4

Impacted Files
Coverage Δ

ngs_tools/sequence.py
75.56% <88.09%> (+1.57%)
:arrow_up:

ngs_tools/utils.py
90.21% <100.00%> (+0.30%)
:arrow_up:

ngs_tools/chemistry/Chemistry.py
81.16% <0.00%> (-0.13%)
:arrow_down:

ngs_tools/logging.py
67.79% <0.00%> (+1.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e53785...357e386. Read the comment docs.


libpng error

when i run the code view.py i get this error.....Can anyone help me?
libpng warning: Image width is zero in IHDR
libpng warning: Image height is zero in IHDR
libpng error: Invalid IHDR data
libpng warning: Image width is zero in IHDR
libpng warning: Image height is zero in IHDR
libpng error: Invalid IHDR data
libpng warning: Image width is zero in IHDR
libpng warning: Image height is zero in IHDR
libpng error: Invalid IHDR data
libpng warning: Image width is zero in IHDR
libpng warning: Image height is zero in IHDR
libpng error: Invalid IHDR data
libpng warning: Image width is zero in IHDR
libpng warning: Image height is zero in IHDR
libpng error: Invalid IHDR data

when i run the code view.py i get this error.....Can anyone help me?
libpng warning: Image width is zero in IHDR
libpng warning: Image height is zero in IHDR
libpng error: Invalid IHDR data
libpng warning: Image width is zero in IHDR
libpng warning: Image height is zero in IHDR
libpng error: Invalid IHDR data
libpng warning: Image width is zero in IHDR
libpng warning: Image height is zero in IHDR
libpng error: Invalid IHDR data
libpng warning: Image width is zero in IHDR
libpng warning: Image height is zero in IHDR
libpng error: Invalid IHDR data
libpng warning: Image width is zero in IHDR
libpng warning: Image height is zero in IHDR
libpng error: Invalid IHDR data
have you download the dataset and put it in correct place?

As mentioned i have made data folder and inside that i have videos folder in which all the videos are placed....but still i am getting this error anything that i can do for this? and can i test on anyother video?

why i cannot test it on any other image?


[WIP] Improve monasca integration

@dougszumski I recreated this PR with the final commit as WIP change but merged the earlier commits as they work up to that point.

Let's abort this, not enough time.


Fix AttributeError traceback with darksky

Description:
When self.data is None, returning self.data.get('flags').get('units') fails with an AttributeError
Related issue (if applicable): fixes #20596
Pull request in home-assistant.io with documentation (if applicable): N/A
Example entry for configuration.yaml (if applicable):
weather:
  - platform: darksky
    api_key: !secret darksky_api
    mode: hourly
    name: "Hourly Forecast"

Checklist:

[x] The code change is tested and works locally.
[x] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

closing to base PR on dev branch


deploy

prefer without read access https://answers.netlify.com/t/why-do-you-need-write-permissions-to-my-repository/7897

fixed by https://github.com/ConorSheehan1/conors-cocktails/commit/63bdd8eaa5ae2e488cc7c6ca954e5cc4c94e8e2e


Ability to change order of repos on the monitor

Hello.
At the moment, repositories are ordered on how many open PRs there are. Would it be possible to add different ways of ordering? e.g. By alphabetical order, or by the number of requests for your review?
Not sure about the roadmap for the project. But this could either be implemented with:

A simple dropdown menu at the top of the monitor
or
A settings menu outside of the monitor - probably as a component on the Account route

Hi @lwkchan , I'm working on a major re-write at the moment to ditch Redux and move to Apollo Client, tidying things up along the way. Once that is done there are loads of new features I want to add and a setting for this is one of them! Will keep this issue open here to remind me.
PS: Hello fellow Makers grad :)

👋 !
Sounds awesome. Let me know if you need any help. This tool has helped me a lot in recent time and I would love to contribute back.

@lwkchan I appreciate the comment!
I think there will be more opportunities to contribute when I've finished the re-write 👍


Provide a summary list of changed files/folders in an activity

Finished working on the design for this and a commented out HTML mockup of this existed in the activity-overview.html page. Over to tomas to implement!


Add appendix pages to search

Proposed changes
https://github.com/uccser/cs-field-guide/issues/1824
Add appendix pages to the search feature. The pages contributors, about and sitemap will show up in the search -- with a relatively low weighting.
Changes:

Appendices are now stored in the database
Appendices are indexed for search by their name, and text content (from template)
Appendices loader now loads appendices into the DB
Existing tests for appendix app re-enabled and updated
Tests for appendix model
Tests for get_template_text function

Further comments
Todo:

[ ] add tests
[ ] remove stray general pages references
[x] review changes to structure yml file (removed new additional fields)
[ ] update docs if needed

@jimbonothing64 If you need help getting this working, I'm happy to take a look at it sometime.

@jimbonothing64 If you need help getting this working, I'm happy to take a look at it sometime.

Thanks @JackMorganNZ !
I've been blocked by other work for the last month (likely the next ~2 weeks too). Getting the dev staging CD deploying again is the next priority. I chose this issue for good tour of the project -- it's not my urgent list.
I'm a month out of touch, but from memory, the main area was familiarizing myself with the testing setup. Perhaps you've spotted something else, however. If you want to and have the time, it would be instructive if you had any advice/pointers -- but understandable if not!
Thanks again.


simple furnace shift-click behavior disappoints me

Issue Description:
Furnace shift-clicking is slot-dependent in a surprising way.
What happens:
I shift-click on a stack that could be put in the furnace. It doesn't go. But only sometimes.
What you expected to happen:
Shift-click insert things in furnace.
Steps to reproduce:

Obtain several stacks of the same wood.
Put one in furnace.
Shift-click another. It goes in furnace, yay!
In fact, put some in all three slots.
Wait until first two slots are empty.
Try to shift-click in more of the same wood. It won't go!
Move the stack from the last slot to the first.
Shift-click in more. It works!

Affected Versions (Do not use "latest"):
EnderCore-1.12.2-0.5.37.jar
EnderIO-1.12.2-5.0.31.jar
Minecraft 1.12.2
Forge 1.12.2-<IP_ADDRESS>18
No spongeforge, no optifine, only tested in SMP with dedicated server.
Your most recent log file where the issue was present:
N/A, no log entries.

No idea if we have another github ticket for this or if it's only in our "open porting bugs" list...


[FEATURE REQUEST] List of Vip/s command on the bot

Is your feature request related to a problem? Please describe.
 If you can please make/add a command on the bot that let's the users know who are the vip/s
Describe the solution you'd like
 If a user send the command /vips or /vip or anything you will like, the bot will send them the list of the vips
Describe alternatives you've considered

Additional context

That would be a pretty ugly list, it would just contain the user IDs. What would you do with those?

So that they will know if they are already VIP

Vip restrictions are being reflected in /limits, if they are different.


Add support for several LSP clients

Some of those LSP clients support configuration options.
This commit adds a way to pass configuration options to lsp, using two fields in the mkLsp function:

extraOptions: allows to define Nix module options
settings: Translate the config of those options to the settings structure expected by the LSP

There's some conflicts due to bashls being there twice, i'll take care of that tomorrow though :)


⚠ Bofrost.fr has degraded performance

In be42e65, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 863 ms

Resolved: Bofrost.fr performance has improved in bb29ca7.


Flaky e2e MultiKueue test

What happened:
E2e MultiKueue test failed
What you expected to happen:
No failure
How to reproduce it (as minimally and precisely as possible):
https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_kueue/3708/pull-kueue-test-multikueue-e2e-main/1863892287004610560
Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version):
Kueue version (use git describe --tags --dirty --always):
Cloud provider or hardware configuration:
OS (e.g: cat /etc/os-release):
Kernel (e.g. uname -a):
Install tools:
Others:

cc @mbobrovskyi

/close
Duplicate of https://github.com/kubernetes-sigs/kueue/issues/3581.


feat(perf): Remove inc_rc instructions for arrays which are never mutably borrowed

Description
Problem*
Part of general effort to reduce Brillig bytecode sizes
Summary*
An array can be borrowed without being mutated. We code gen inc_rc instructions quite pessimistically on every borrow or reassignment of an array. If we know that the array is never mutated, it should be safe to remove these inc_rc instructions.
During DIE we now track all inc_rc instructions in a block and if that array is never used in an array set or a store, we mark its inc_rc instruction for removal.
Additional Context
Documentation*
Check one:

[X] No documentation needed.
[ ] Documentation included in this PR.
[ ] [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

[X] I have tested the changes locally.
[X] I have formatted the changes with Prettier and/or cargo fmt on default settings.

Is this safe in the presence of calls to other functions? I guess yes since we increase the rc in the called fn?

Yes I believe it should be safe due to the fact that if the called function performs a mutation we will keep the rc on the array parameter inside the called fn.


Add React ^15.0.0 as an OR'd dependency.

Any update on this one?

@wangzuo any update?

I've published an interim package with these updates here if anyone is interested.

Thanks, 1.6.0 was released with this fix.


Fix autosuperinit

Rules are that a named constructor is expected to call super or the autosuperinit in order to be sanely attached to the inheritance hierarchy. If no such a call exists, an implicit call is injected (thus the name auto-super-init) or an error is displayed.
For some historical reasons, the rule was only enforced when a class inherits a concrete or a abstract class. But this restriction is buggy with the last spec of autoinit constructors.
The main change in src/ is just to remove the test the skip the work.
All other changes in the code are to enforce the rule (not that much); basically this means calling init with parameters instead of assigning attributes.
The remaining changes is to update the sav files because missing autosuperinit are now correctly injected.
Close #1550

tests passed!

:shipit:

:shipit:

update: the PR also fixed an unnoticed bug with serialization and --erasure


CI: Checks for Frontend

Basics

[x] Details of what you changed are in commit messages
(first line should have module: short statement syntax)
[x] References to issues, e.g. close #X, are in the commit messages.
[ ] The buildserver is happy.
[x] The PR is rebased with current master.

Checklist

[ ] I added unit tests for my code
[ ] I fully described what my PR does in the documentation
(not in the PR description)
[ ] I fixed all affected documentation
[ ] I fixed all affected decisions
[ ] I added code comments, logging, and assertions as appropriate
[ ] I mentioned every code not directly written by me in reuse syntax

Review

[ ] Documentation is conforming to our Documentation Guidelines
[ ] Examples are well chosen and understandable
[ ] Code is conforming to our Coding Guidelines
[ ] Code is consistent to our Design Decisions

@Benjaminimal
I've added support for the npm checks inside the pipeline, which you added in #171 and commented in #126. Could you please lend me a hand in fixing those js/ts problems? 🥺

I fixed the formatting and looked at the lining errors.
However, I'm not experienced with react and typescript so I'm not sure if I'd break anything by fixing these.
Could the authors of these files please fix them?
@absurd-turtle @buenaflor
npm run lint

><EMAIL_ADDRESS>lint
> eslint --max-warnings=0 .

Warning: React version not specified in eslint-plugin-react settings. See https://github.com/jsx-eslint/eslint-plugin-react#configuration .

frontend/src/config/index.ts
  15:22  error  Do not access Object.prototype method 'hasOwnProperty' from target object  no-prototype-builtins

frontend/src/features/landing_page/components/GeoMap.tsx
  2:50  warning  'useMap' is defined but never used  @typescript-eslint/no-unused-vars

frontend/src/features/seeds/routes/SeedDetails.tsx
  36:6  warning  React Hook useEffect has a missing dependency: 'id'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

frontend/src/tailwind.config.js
    1:7   warning  'colors' is assigned a value but never used     @typescript-eslint/no-unused-vars
    1:16  error    Require statement not part of import statement  @typescript-eslint/no-var-requires
    1:16  error    'require' is not defined                        no-undef
   55:7   warning  'brown' is assigned a value but never used      @typescript-eslint/no-unused-vars
  103:7   warning  'blue' is assigned a value but never used       @typescript-eslint/no-unused-vars
  140:1   error    'module' is not defined                         no-undef

frontend/tailwind.config.js
  2:24  error  Require statement not part of import statement  @typescript-eslint/no-var-requires

✖ 10 problems (5 errors, 5 warnings)

As this involves reformatting, we should merge this after the big release-critical PRs.
So probably release pipeline should be done first, as this will be definitely needed for the release.

Since I did the reformat in another PR
https://github.com/ElektraInitiative/PermaplanT/pull/160
you can drop these two commits and rebase after it is merged.
https://github.com/ElektraInitiative/PermaplanT/pull/197/commits/00a78615aabcc94a8811d73b7c0a592342e70851
https://github.com/ElektraInitiative/PermaplanT/pull/197/commits/9ab1aaf5382662a7dc9e1eb8c22caa86e9f5ab40

@badnames @absurd-turtle @markus2330
Now that #260 ( #212 ) was merged, I fixed the rest, added the auto-generated definitions.ts to the prettier ignore-file and pushed everything to this branch. Pls review, so we can get this shipped :rocket:

I wonder why there is no reformatting of Markdown. Was this forgotten as it is neither frontend nor backend?
@Benjaminimal can you plz check if all the checks of the pre-commit are done in the CI as well and create an issue of what is missing?

@lukashartl great job! :heart:
@Benjaminimal I created #261 to discuss how we fix the rest. :rocket:


support dispatch.yaml files...

Can you describe more what is needed there? We can help, but need data.

If there is a dispatch.xml in WEB-INF,it will be be translated at deploy time to a dispatch.yaml at the root of the staging directory, and will be uploaded in the gcloud:deploy command.
version 0.9.58.v20150503


How to generate translation using multiple GPUs?

Hi,
Right now I use --num-shards and --shard-id to generate multiple files by multiple gpus, and then concat the results to model multiple gpu decoding.
Is there any more convenient way?
Thank you very much!

Unfortunately, this is the current solution. If you have an improvement, please make a pull request!

It would be great something like a world size parameter could be set that automatically set the num-shards and such flags appropriately then concat the results automatically on output (and remove the shards). I'll look into but am not that versed in the codebase so could take a while.

how do you concat the results from the multiple generated predictions to keep the order similar to the original file?


⚠ ClamAV has degraded performance

In 4fd9a31, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 194 ms

Resolved: ClamAV performance has improved in 6657fce.


Add extra display columns for resource resolution

Changes
Add start and end time, as well as details about the owner
resource to to the resource requests. Example:
 NAME                                   OWNERKIND   OWNER                SUCCEEDED   REASON             STARTTIME              ENDTIME
 git-40e5840171b418bcbd0bfa73defec338   TaskRun     git-resolver-p75s8   True                           2022-10-05T09:16:08Z   2022-10-05T09:16:10Z
 git-6ecf81c8e0b418bcbd0c05c1bc3cd0c5   TaskRun     git-resolver-tmvqd   True                           2022-10-05T09:11:20Z   2022-10-05T09:11:22Z
 git-e97b40047eb418bcbd0be5341ed71802   TaskRun     git-resolver-xdq55   False       ResolutionFailed   2022-10-05T09:19:51Z   2022-10-05T09:19:52Z

Signed-off-by: Andrea Frittoli<EMAIL_ADDRESS>Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[x] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
Add more details (start time, end time, owner) in the default view of resource resolutions

/kind feature

Stacked on top of https://github.com/tektoncd/pipeline/pull/5515 - will rebase once https://github.com/tektoncd/pipeline/pull/5515 is merged

/lgtm


In face_mesh_connections.py, provide tuple of sequential list of indices for FACEMESH_FACE_OVAL and other polygonal shapes

MediaPipe Solution (you are using)
face landmarker
Programming language
Python
Are you willing to contribute it
Yes
Describe the feature and the current behaviour/state
Using FACEMESH_FACE_OVAL as an example, currently it is a frozenset of line segments, with each item being (start_point_index, end_point_index). If I want to draw outline of the "face oval", it's not too bad, I just draw all the line segments. But if I want to draw it as a filled polygon, or get a sequential list of polygon vertices, it's not so simple any more.

Because frozenset does not keep insertion order, if I just enumerate it, most likely I'll get a self-intersecting polygon. I see two workarounds:

1. copy the definition of FACEMESH_FACE_OVAL into my code, change frozenset to tuple. But if FACEMESH_FACE_OVAL changes in a future release, my code will stop working.
2. build a sequential list myself. This means enumerate FACEMESH_FACE_OVAL, put items into a dictionary, using first index as key, second index as value. Then construct a list.

What you really want is an ordered frozenset (ordered, unique, immutable), but no such data structure exists in Python (I'll ignore other languages now). The next best thing is to use a tuple. Tuple doesn't guarantee uniqueness, but you can manually ensure it's unique when you define it.

Frozenset is unordered, but with indices of polygon vertices, you want the data to be ordered.

Will this change the current API? How?
No

Who will benefit with this feature?
People who want facial shapes as a polygon.
Please specify the use cases for this feature
Get polygons of facial shapes.

Any Other info
No response

@by321,
Thanks for raising this feature request, We are forwarding issue internally and based on discussion team will prioritise the work.

In the new MediaPipe Tasks library, we've changed to storing the indices using List. See FACE_LANDMARKS_LIPS for example. Let me know if it works for your now.

Yeah, that's more convenient to use than frozenset, thanks.

Hi! I am using the face landmarker. For a given landmark X on the face mesh, I want to be able to access landmarks on the mesh that share an edge (connection) with this landmark X, or in other words the nearest neighbouring landmarks above, below and adjacent. Is there a way to access the face mesh connections so that I can do this?

I want to be able to access landmarks on the mesh that share an edge (connection) with this landmark X

Don't think there's an API for this, but you can build a dictionary using FACE_LANDMARKS_TESSELATION in mediapipe/mediapipe/tasks/python/vision/face_landmarker.py. The key is the landmark index, the value is a list of of indices it connects to.


"Selecting" multiple exported script variables at the same time is possible

Godot version:
3.1.dev-1
OS/device including version:
Arch Linux
Issue description:
Multiple node properties were selected at the same time. Only one should be possible (?)
Steps to reproduce:
Create a new node script with two or more exported variables with the same names. Every variable with the same name will beee highlighted in the inspector.

It is also possible to select them again after focus loss, by pressing shift and selecting all variables with the same name.
Minimal reproduction project:
Not possible, since variables need to be newly created.

It's not impossible to create multiple variables with the same name anymore. It throws parsing error and the variables don't appear in the inspector due to error.


[BUG] esc menu not working + not able to directly close app

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[ ] I did not answer truthfully to all the above checkboxes.

What problem did you encounter?
for whatever reason i cant both close the game (with alt+f4 and esc+l+enter), and the esc menu is not working properly, i mean that i doesnt show players and cant interact with it at all.
i have no idea what is causing the issues and the last time i changed/added a fastflag was 1 week ago

Bloxstrap Log
N/A

This is a duplicate of #2914, I recommend closing and talking there.


Local Storage access

Is it possible to retrieve data from local storage ?

Sorry for the late reply.
Currently local storage access is only for saving downloaded files, but I would like to support file selection and preview in the future
Issues that may be relevant (file download):
https://github.com/TLabAltoh/TLabWebViewVR/issues/1
I plan to work on this once my current priority tasks are completed.


Cars don't change lanes properly when taking off from the highway.

Cars intended to go off the highway goes through the obstacle instead of switching lanes earlier.

Running the (5.4.123 from appveyor) debug executable in the screenshot but I've seen it happen in 5.3-alpha (linux) as well. Could not replicate this on Retroarch with "Beetle PSX HW (<IP_ADDRESS> 9f126e5)" core.

Yes, that's a known Civ AI bug caused by reverse engineering.
Will gonna look into it as it is a mess

Fixed in 926cc8c