Corrupt Wallet lost coins, can they be recovered?

Issue Template
Context

Prerequisites

[x] Are you running the latest version?

User Story:

"I'm submitting a ... "

[ ] bug report
[ ] feature request
[ ] support request
[ ] translation request

Expected Behavior

Current Behavior

Screenshots

Possible Solution

Steps to Reproduce (for bugs)

Steps :

Your Environment

Verge Release:
CPU:
GPU:
RAM:
OS:

[ ] I'm using Mac
[ ] I'm using Linux
[ ] I'm using Mac

Any extra information that might be useful in the debugging process.

define "Corrupt wallet" ?  wallet.dat file got corrupt?  Any idea how did it get corrupt?  You had no backups of the wallet.dat anywhere?  And didn't export private key?

beep

well when I attempt to open wallet it closed immediately. In trying to "fix" it. I assume it is corrupt because I cannot get it to stay open. Also there was a transfer I cannot find I have address it was sent, but cannot locate in wallet. sorry just getting back I have been having coin issues.
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On March 8, 2018 6:04 PM, Jeff S<EMAIL_ADDRESS>wrote:

define "Corrupt wallet" ? wallet.dat file got corrupt? Any idea how did it get corrupt? You had no backups of the wallet.dat anywhere? And didn't export private key?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

understand the difference between:
A)  Verge-QT Wallet
B)  Your wallet.dat file that contains your addresses
If you are having problems with A closing... what i would do:
Step 1)  Go to C:\Users\YOU\AppData\Roaming\Verge
Step 2)  Make a backup copy of your wallet.dat file , copy it someplace safe
Step 3)  Rename the folder "Verge" to "Verge-Old"
Step 4)  Open Verge-QT Wallet

I have deleted all the old verge QT wallet. I backed up wallet.dat file. should new install fix issue. Secondly the address for my second transaction doesn't show in the wallet I have, but the rest of the coins are there. If I provide the transaction on blockchain can the wallet it was sent to be verified?
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On March 12, 2018 8:55 PM, Jeff S<EMAIL_ADDRESS>wrote:

understand the difference between:
A) Verge-QT Wallet
B) Your wallet.dat file that contains your addresses
If you are having problems with A closing... what i would do:
Step 1) Go to C:\Users\YOU\AppData\Roaming\Verge
Step 2) Make a backup copy of your wallet.dat file , copy it someplace safe
Step 3) Rename the folder "Verge" to "Verge-Old"
Step 4) Open Verge-QT Wallet
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Please see attachment to provide detail to misplaced coin.
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On March 12, 2018 9:00 PM, Randy1x<EMAIL_ADDRESS>wrote:

I have deleted all the old verge QT wallet. I backed up wallet.dat file. should new install fix issue. Secondly the address for my second transaction doesn't show in the wallet I have, but the rest of the coins are there. If I provide the transaction on blockchain can the wallet it was sent to be verified?
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On March 12, 2018 8:55 PM, Jeff S<EMAIL_ADDRESS>wrote:

understand the difference between:
A) Verge-QT Wallet
B) Your wallet.dat file that contains your addresses
If you are having problems with A closing... what i would do:
Step 1) Go to C:\Users\YOU\AppData\Roaming\Verge
Step 2) Make a backup copy of your wallet.dat file , copy it someplace safe
Step 3) Rename the folder "Verge" to "Verge-Old"
Step 4) Open Verge-QT Wallet
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

help -> debug window -> console
type:
scanforalltxns

no way to determine which wallet based on address qt. or electrum? cause if electrum I'm screwed.
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On March 12, 2018 9:13 PM, Jeff S<EMAIL_ADDRESS>wrote:

help -> debug window -> console
type:
scanforalltxns
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

You can't tell what wallet.dat has a specific address based on the blockchain technology.  You just have to keep trying old backup copies of wallet.dat and hope you find it.
If you have private key for it, you can import the private key.
Sorry I know English isn't your first language, I'm having a hard time understanding your questions/problems.. hopefully that makes sense what I said :frowning_face:

no american is , LOL. thanks
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On March 12, 2018 9:25 PM, Jeff S<EMAIL_ADDRESS>wrote:

You can't tell what wallet.dat has a specific address based on the blockchain technology. You just have to keep trying old backup copies of wallet.dat and hope you find it.
If you have private key for it, you can import the private key.
Sorry I know English isn't your first language, I'm having a hard time understanding your questions/problems.. hopefully that makes sense what I said ☹
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

and just to be clear, speaking as best english I know how; Downloading a "new" version of the Verge wraith wallet , should stay open, now that I have deleted all other versions from my computer's C drive?
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On March 12, 2018 9:27 PM, Randy1x<EMAIL_ADDRESS>wrote:

no american is , LOL. thanks
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On March 12, 2018 9:25 PM, Jeff S<EMAIL_ADDRESS>wrote:

You can't tell what wallet.dat has a specific address based on the blockchain technology. You just have to keep trying old backup copies of wallet.dat and hope you find it.
If you have private key for it, you can import the private key.
Sorry I know English isn't your first language, I'm having a hard time understanding your questions/problems.. hopefully that makes sense what I said ☹
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

always use:
https://github.com/vergecurrency/VERGE/releases/latest
That version will work and stay open.
that version is the only version that works correctly because of the hard fork Verge did in late January.

that's what I was running, lost power, when I rebooted it kept crashing
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On March 12, 2018 9:43 PM, Jeff S<EMAIL_ADDRESS>wrote:

always use:
https://github.com/vergecurrency/VERGE/releases/latest
That version will work and stay open.
that version is the only version that works correctly because of the hard fork Verge did in late January.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@randy1xxx try replacing the wallet with a new copy, if that doesn't work, delete all your blockchain data except the wallet.dat, (while the wallet is shut down) and then start it back up

I was able to recover Verge wallet finally. Is there anyway to contact a developer to see if they know of a way to retrieve Verge coin from bad Pivx. Address? Pivx cannot help, exchange cannot help, but I can see the transaction of the block chain, there has to be a way?
Sent with ProtonMail Secure Email.

Reply to this email directly, view it on GitHub, or mute the thread.

what is the TX number?  I highly doubt anything can be done.
Transactions on the blockchain cannot be reversed / changed.  God Himself could not reverse it.
Either you own the address it was sent to, or you don't.  and 'owning' means:
You have or can get the private key to it

Sunerok, thank you. I have my verge wallet open and operating I think. I am not sure if I have asked my second question issue; I mistakenly sent Verge coin to a PIvx address. I was hoping there might be a command to have my Pivx address exported to a new Verge address so coins might be transferred? My understanding of the blockchain is that once a transaction has been complete there is no reversal, however if the address in which it was sent doesn't match the network, could the bad address be added for the sake of transferring to a good one? Sorry to keep disturbing you, however I duly promise if I ever get out this wallet quagmire you will not hear from me again, I have learned.
Sent with ProtonMail Secure Email.

Reply to this email directly, view it on GitHub, or mute the thread.

What is the transaction number on the blockchain?
Where did you send the coins from?  Your verge-qt wallet? An exchange?
Where did you send the coins to?  Your verge-qt wallet? An exchange?

I attached screen shot of transaction.
I sent coins from Bittrex exchange>
Address: DRYEvfsKxvLep7wV3CTfd4xzDYAZZWytad
TxId: 1b9f32da5ce35133789c350a7ef060da8318020ffe7fa9520660a0dda1c809a9
I sent them to a Pivx address by accident>
1b9f32da5ce35133789c350a7ef060da8318020ffe7fa9520660a0dda1c809a9
DRYEvfsKxvLep7wV3CTfd4xzDYAZZWytad
I was having issues with keeping Verge wallet open until a day or so ago, sorry for the lag in the request.
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On March 27, 2018 11:37 AM, Jeff S<EMAIL_ADDRESS>wrote:

What is the transaction number on the blockchain?
Where did you send the coins from? Your verge-qt wallet? An exchange?
Where did you send the coins to? Your verge-qt wallet? An exchange?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I forgot screenshot of Pivx wallet with address sent to:
[Pivxwallet.JPG]
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On March 27, 2018 11:51 AM, Randy1x<EMAIL_ADDRESS>wrote:

I attached screen shot of transaction.
I sent coins from Bittrex exchange>
Address: DRYEvfsKxvLep7wV3CTfd4xzDYAZZWytad
TxId: 1b9f32da5ce35133789c350a7ef060da8318020ffe7fa9520660a0dda1c809a9
I sent them to a Pivx address by accident>
1b9f32da5ce35133789c350a7ef060da8318020ffe7fa9520660a0dda1c809a9
DRYEvfsKxvLep7wV3CTfd4xzDYAZZWytad
I was having issues with keeping Verge wallet open until a day or so ago, sorry for the lag in the request.
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On March 27, 2018 11:37 AM, Jeff S<EMAIL_ADDRESS>wrote:

What is the transaction number on the blockchain?
Where did you send the coins from? Your verge-qt wallet? An exchange?
Where did you send the coins to? Your verge-qt wallet? An exchange?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

The verge coins are at this address DRYEvfsKxvLep7wV3CTfd4xzDYAZZWytad
Is this a PIVX address?
If you can get the private key for the PIVX address DRYEvfsKxvLep7wV3CTfd4xzDYAZZWytad, you can always try to go to verge-QT... go to the console ... and do an "importprivkey"
This is for bitcoin-qt wallet but the steps apply for verge-qt as well:
https://en.bitcoin.it/wiki/Help:How_to_import_private_keys_in_Bitcoin_Core_0.7%2B
But if Bittrex owns the PIVX address DRYEvfsKxvLep7wV3CTfd4xzDYAZZWytad , the only way you could get the private key is to ask them.. and I don't know if they would support it.
Bottom line is though:
-your transaction went through and is on the blockchain
-all transactions are irreversible and final
-the coins are at Verge Address DRYEvfsKxvLep7wV3CTfd4xzDYAZZWytad , and the only way to access them is to get the private key for the Verge Address DRYEvfsKxvLep7wV3CTfd4xzDYAZZWytad
-even if you get the private key for the PIVX address DRYEvfsKxvLep7wV3CTfd4xzDYAZZWytad, there's no guarantee you can import that private key into the VERGE blockchain

It is a Pivx address that I own, however when I do the importprivkey command the Verge wallet seems not match , comes back error. That is why I wanted to know if it might be possible to ask one of the developers was their a way to add the address so it might accept import? Long shot , but just wondering since the address is known and not a verge account.
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On March 27, 2018 1:27 PM, Jeff S<EMAIL_ADDRESS>wrote:

The verge coins are at this address DRYEvfsKxvLep7wV3CTfd4xzDYAZZWytad
Is this a PIVX address?
If you can get the private key for the PIVX address DRYEvfsKxvLep7wV3CTfd4xzDYAZZWytad, you can always try to go to verge-QT... go to the console ... and do an "importprivkey"
This is for bitcoin-qt wallet but the steps apply for verge-qt as well:
https://en.bitcoin.it/wiki/Help:How_to_import_private_keys_in_Bitcoin_Core_0.7%2B
But if Bittrex owns the PIVX address DRYEvfsKxvLep7wV3CTfd4xzDYAZZWytad , the only way you could get the private key is to ask them.. and I don't know if they would support it.
Bottom line is though:
-your transaction went through and is on the blockchain
-all transactions are irreversible and final
-the coins are at Verge Address DRYEvfsKxvLep7wV3CTfd4xzDYAZZWytad , and the only way to access them is to get the private key for the Verge Address DRYEvfsKxvLep7wV3CTfd4xzDYAZZWytad
-even if you get the private key for the PIVX address DRYEvfsKxvLep7wV3CTfd4xzDYAZZWytad, there's no guarantee you can import that private key into the VERGE blockchain
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Unfortunately you are probably out of luck then.  That was most likely your only chance.
I would suggest maybe posting it on Verge's Reddit page and see if anyone else has any other thoughts.  I would put a URL to this issue so people can see what we've tried and looked at so far.
Sorry man, good luck :disappointed:

Were you able to ask Sunerok , think that's how you spell it, the developer? I would like to get a developers take, no offense.
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On March 28, 2018 12:35 PM, Jeff S<EMAIL_ADDRESS>wrote:

Unfortunately you are probably out of luck then. That was most likely your only chance.
I would suggest maybe posting it on Verge's Reddit page and see if anyone else has any other thoughts. I would put a URL to this issue so people can see what we've tried and looked at so far.
Sorry man, good luck 😞
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Hello , any word as to any developer I might be able to communicate with concerning the address mistake I made?
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On April 5, 2018 9:04 AM, Randy1x<EMAIL_ADDRESS>wrote:

Hello, any word as to the possibility of me communicating with a "developer" regarding tokens sent to wrong address (pivx address) and importing the address into verge wallet to allow for deposit of coins into my account?
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On March 28, 2018 1:26 PM, Randy1x<EMAIL_ADDRESS>wrote:

Were you able to ask Sunerok , think that's how you spell it, the developer? I would like to get a developers take, no offense.
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On March 28, 2018 12:35 PM, Jeff S<EMAIL_ADDRESS>wrote:

Unfortunately you are probably out of luck then. That was most likely your only chance.
I would suggest maybe posting it on Verge's Reddit page and see if anyone else has any other thoughts. I would put a URL to this issue so people can see what we've tried and looked at so far.
Sorry man, good luck 😞
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Per Justin:
"He can try to import the private key but the scriptkey is most likely different" ... which means your PIVX private key is not compatible on the XVG blockchain unfortunately :(

and there is no way to make an exception for the scriptkey from Pivx address so that coins might deposit or send back
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On April 9, 2018 4:55 PM, Jeff S<EMAIL_ADDRESS>wrote:

Per Justin:
"He can try to import the private key but the scriptkey is most likely different" ... which means your PIVX private key is not compatible on the XVG blockchain unfortunately :(
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Thank you for that explanation , however I'm a non believer for this reason. If the Pivx address is not a Verge address, why can't the deposit be rejected by verge network and sent back to the exchange in which it came? I understand the implications of just assuming I own the wallet , which a screen shot will not suffice. With coin swap options I've seen it would seem the networks have an ability to communicate with one another, all I'm asking that if the address is not proper, the transaction be rejected.
TSent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On April 9, 2018 5:17 PM, Jeff S<EMAIL_ADDRESS>wrote:

Correct unfortunately.
That is the fundamental design of the blockchain:
~no one can modify it
~All transactions are final and cannot be undone
So all the reasons why blockchain technology is awesome are the same reasons it makes it incredibly unforgiving if mistakes are made.
Think of it this way -- how can you really even prove to anyone that you really own that address? You don't have the private key for it. How do we really know someone else doesn't own the address and you are trying to scam it because you happen to own the same PIVX address?
If this was even a possibility, there would be thousands of requests from people saying "Hey Justin/devs can you please give me my coins on address ABCDEFGH? I made a mistake".
Just google online about people losing their crypto. There are thousands and thousands of stories.. from people forgetting their passwords, to sending coins to the wrong address, to computers crashing with no backups.
There is literally hundreds of millions of dollars worth of crypto out there that is lost forever across all different coins. There is nothing different about Verge that has a backdoor to change private keys / public addresses / etc unfortunately :(
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Your situation was extremely unfortunate, because both PIVX and Verge have addresses that start with D.. but that is about the only thing they share in common.
If you tried sending it to a BItcoin or Ethereum address, your Verge transaction would have been rejected.
But since you sent it to an address that starts with a D, it passed the "check" as a potentially possible Verge address.
Blockchain tech doesn't say that the transactions have to verify the address exists or not.  You can prove this by creating a paper wallet address for any coin.. and then go look for the address on the block chain.  You cannot see the address on the blockchain.  But the address does exist, you own it, it's on paper.
As soon as you send coins to that address via a TX, then the address is on the blockchain.

I'd have to test this with actual Verge, which I don't know if I feel like, but as another example, I could probably send Verge to like:
DThisIsTotallyFakeAddressIMadeUpButItWouldWork
As far as the Verge network is concerned, that is a legit address.  If you think of the  Infinite Monkey Theorem ..
https://en.wikipedia.org/wiki/Infinite_monkey_theorem
It's entirely possible for an address to potentially be:
DThisIsTotallyFakeAddressIMadeUpButItWouldWork
So why would the Verge network reject that TX?  If that was actually my address because it was smart enough and thought it was fake, I'd be pissed.

Hi Jeff
This is a good source of information. Would it possible for us to add these
as FAQ section in our github forum... i am happy to own it...if you think
it helps!
On Tue, Apr 10, 2018 at 10:04 AM, Jeff S<EMAIL_ADDRESS>wrote:

Your situation was extremely unfortunate, because both PIVX and Verge have
addresses that start with D.. but that is about the only thing they share
in common.
If you tried sending it to a BItcoin or Ethereum address, your Verge
transaction would have been rejected.
But since you sent it to an address that starts with a D, it passed the
"check" as a potentially possible Verge address.
Blockchain tech doesn't say that the transactions have to verify the
address exists or not. You can prove this by creating a paper wallet
address for any coin.. and then go look for the address on the block chain.
You cannot see the address on the blockchain. But the address does exist,
you own it, it's on paper.
As soon as you send coins to that address via a TX, then the address is on
the blockchain.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/vergecurrency/VERGE/issues/640#issuecomment-379930544,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJWN2gSU8Vi2mkaHXmfV8HsmBDYegs1mks5tm_cMgaJpZM4SjLbv
.

--
Cheers
PC

@pcp1985 what do you mean by FAQ section?  I don't recall seeing one :smile:

no one ever will.  Just like if i sent coins to this address right now:
DThisIsTotallyFakeAddressIMadeUpButItWouldWork
They coins would end up there.. but I don't have the private key for it.. so they'd be lost on the chain forever

You can tell your great great great grandkids to check that address, the coins will still be there

I mean , we should start one... and include these findings there with a
lineitem! so we can ask people to refer the section rather than raising
support request to team... going forward your work going to be hugeeee :)
On Tue, Apr 10, 2018 at 10:14 AM, Jeff S<EMAIL_ADDRESS>wrote:

@pcp1985 https://github.com/pcp1985 what do you mean by FAQ section? I
don't recall seeing one 😄
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/vergecurrency/VERGE/issues/640#issuecomment-379933153,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJWN2uKcqQs_Vi7IJ5rjWiDDtVY85z7Sks5tm_mCgaJpZM4SjLbv
.

--
Cheers
PC

has to be a way to create a private key though,
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On April 9, 2018 7:26 PM, Jeff S<EMAIL_ADDRESS>wrote:

You can tell your great great great grandkids to check that address, the coins will still be there
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

I'm telling ya man, I know it's tough .. but go google around and see how many people have lost millions of dollars worth of bitcoin.
If they can't do it with that much money involved as motivation ... like if you lost $5 million in bitcoin, and offered a hacker $4 million to get it for you .. he couldn't do it.  That's how secure the blockchain is

I don't need nothing hacked though, I just need an address to be identified as a non verge networked address and returned. I get the first letter got me, but my mind says hell what about the rest, a scan of accounts I would think would show Tx with bad addresses and sent back for correction.
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On April 9, 2018 7:32 PM, Jeff S<EMAIL_ADDRESS>wrote:

I'm telling ya man, I know it's tough .. but go google around and see how many people have lost millions of dollars worth of bitcoin.
If they can't do it with that much money involved as motivation ... like if you lost $5 million in bitcoin, and offered a hacker $4 million to get it for you .. he couldn't do it. That's how secure the blockchain is
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

That's not a bad address though -- see my response above about the paper wallet.  You can create an address and not see it on the blockchain.

I read response the first letter made it through, but the rest doesn't fit anything generated by network right?
Sent with ProtonMail Secure Email.
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On April 9, 2018 7:39 PM, Jeff S<EMAIL_ADDRESS>wrote:

That's not a bad address though -- see my response above about the paper wallet. You can create an address and not see it on the blockchain.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

define generate on the network though -- look into "Paper wallets" -- you can literally create an address offline...
like download the wallet generator
disconnect your internet
generate an address
That address is legit and you can send coins to it,, but the "network" has no idea it really exists... so anyone sending coins to it will be able to send coins to it

and @pcp1985  , i've been contemplating about putting up a FAQ type thing somewhere ... there is a "Wiki" on Github .. but I'm just a terrible designer and don't want to embarass myself

@randy1xxx  -- i strongly encourage you to post your situation on any other forum (bitcointalk .. reddit .. anywhere) and get other people's opinions and suggestions.. because I don't know how else to explain the situation any better unfortunately :frowning:  .
I know it sucks losing money and if there's anything I could do to help, I would have done it.  Everyone has made some kind of mistake in Crypto.  The only thing you can really do is learn from it.

yeah if importing the privatekey didnt work, you wont get them back.. ive heard about people doing this with dgb but never pivx.. why doesnt pivx start with a p? odd.

You need to contact Dan. Helped me recover my lost coin for a small fee. I would have given him more if he wanted lol. Recovered money I was almost certain was gone forever. Contact<EMAIL_ADDRESS>

* CAN NOT VOUCH FOR "DAN" *


Bump go version to 1.22, bump linter

Summary

Release Note

Documentation

For some reason, codeql is downloading 2.16.3 rather than 2.16.4 which includes go 1.22. will hold off for now

Nothing to do at this point, codeql is being pulled from the hosted tool cache, so we just need to wait for that to be updated.

Toolchain now contains 2.16.4 but Go 1.22 support is still missing even though the docs say it should be present. will wait til 2.16.5 i guess

@cpanato finally figured it out, I sent the go.mod go version to the specific version of Go because apparently go 1.22 is a development version. hopefully this is correct now


feature and static posts

When you try to make a post static and feature too, something doesn't work well.
I think that is more related with Ghost core, but is easy to reproduce with this theme:
Handlebars Code

Case 1:  ✓ static ✗ feature

Case 2 ✗ static ✓ feature

Case 3:  ✓ static ✓ feature

Looks like under static page scenario, {{featured}} is not injected.

Closed in favour of https://github.com/TryGhost/Ghost/issues/5898


Updated housedorffMetadataKernel, firstHouseDorffPassKernel, meansMahalanobisKernel

Fantastic! Let me know when sth is unclear

Just to make sure when you test it against simple itk you try run it both on gpu and cpu ?

Fantastic! Let me know when sth is unclear

Some files are missing from the project but still included here

Just to make sure when you test it against simple itk you try run it both on gpu and cpu ?

I think I need to update the test files as well to make them work with this

Ok so if you do not see that some file is used for any metric just remove it , yes update test files to check weather it work for gpu,cpu and weather it get the same result as simpleitk or monai or any python package you want :).


differentiate menu folders from other menu items

Is there room to add a small line above the folder menu items like on the HP-48 so you can easily tell it's a folder?

It's funny, I've used HP calculators for... 30-35 years?... but I did not know what the heck this little menu line was until about 2-3 months ago.
I think there is a one-pixel row of extra space above those menu items, but I'm not sure. Needs to be researched. Also needs to be figured out how to draw that little line using the SDK.
Ideally, this is a small, self-contained feature that something that someone else could grab as a contributor. The HP-42S does not have this, and I don't recall seeing anyone complaining about the lack of this. Given the totally of all the other features that we could work on, how do we prioritize this? Obviously I have almost no need for this, because I every menu item like the back of my hand. But other users of RPN83P will find it helpful.
Anyway, I added back-link to this in https://github.com/bxparks/rpn83p/blob/develop/docs/FUTURE.md

This turned out to be quite simple, after I figured out the appropriate OS calls. Here's what the menu looks like now:

I have to update the screenshots in the documentation. There are currently 1346 screenshots, of which maybe 30-40% show the menus, so maybe 400-500 screenshots? It will take me days... I'm keeping this ticket open until the docs are updated.

Fixed by v0.11.0


sortable attribute is ignored

What you were expecting:
Given the following markup
   <Datagrid>
        <TextField source="name" />
        <TextField source="punchline" sortable="false" />
        <EditButton />
    </Datagrid>

I should not be able to sort on punchline
This is described in https://marmelab.com/admin-on-rest/Fields.html
What happened instead:
I can sort on punchline column ...
I've looked at the code of textfield and I dont see any mention of sortable ...
Environment

Admin-on-rest version: 1.4.0
Last version that did not exhibit the issue (if applicable):
React version:
Browser: any
Stack trace (in case of a JS error):

Ok, that was a beginner mistake :
"false" evaluates to true in js so if you want to make your column not sortable you must do
<TextField source="punchline" sortable={false}/>


Make notification bell more prominent on mobile (#20108, #20236, #20251)

Backport #20108
Backport #20236
Backport #20251
Make notification bell more prominent on mobile
Co-authored-by: Andrew Thornton<EMAIL_ADDRESS>Co-authored-by: Tyrone Yeh<EMAIL_ADDRESS>Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

:rocket:


MB-4667 Update SM duty station when TOO updates order origin duty station

Description
This makes it so that when the TOO updates the origin duty station on an order, the SM duty station also gets updated.
Reviewer Notes
We considered doing this via 2 api calls as mentioned on the jira ticket, but didn't in the end because there's not an office endpoint to edit the customer data. Also this way gives us the added benefit of having both updates in a single transaction.
Setup

Create a move order from the customer side.
Log in as a TOO.
Open the move that you created and click on "Edit Orders"
Change the "Current duty station" and save (you also likely need to set a "SAC" value).
As the customer, go to "Review your request" and check that the "Current duty station" has been updated under the "Profile" section.

Code Review Verification Steps

[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Messages

:book:
:link: MB-4667

  Generated by :no_entry_sign: dangerJS against b1063b01f89d2c42e10256e77e60947d6c6b7b7f


Small chapter 5 correction

Hi. Tiny fix in the examples for mappings they are both called exampleMapping1, the second example should be exampleMapping2 as it is referred to in the explanation.
Thanks for building this resource :)

Thanks for reporting the issue @isaac-art :) It has been fixed.


Feature request: change child without restarting windup

From the guides:

Let me be clear: changing the value of a windup while it's running will restart it from scratch. At least... that's how it's meant to work.

I'd really like to change the styles of the text mid-windup (exactly as with the example in the guide), re-rendering the colour of the text but without restarting the windup. The specific animation is to type out some text, and then when it's finished it becomes bold and red (mimicking a phone PIN attempt fail)
I suppose that it would be best served as a prop into WindupChildren? It isn't clear to me immediately looking at the code, do you have any pointers into how I might implement it this? A priori the prop could cause the old position/index of the windup animation to be saved, and it would restart from here? Is this feature desirable? If I can do it I think it would be one of the little details which would make my animation better 🙂

I managed to get the behaviour I wanted by moving the CSS logic outside of the WindupChildren
function PinAttempt({pace, midPause}: {pace: number, midPause: number}) : React.ReactElement {
    const [pinFin, setPinFin] = useState(false);

    return (
        <Container textWeight={pinFin ? "bold" : null} color={pinFin ? "red" : null}>
            <Center>
                <WindupChildren>
                    <Pace ms={pace}><Text>* * <Pause ms={midPause}/>* *</Text></Pace>
                    <Effect fn={() => setPinFin(true)} />
                </WindupChildren>
            </Center>
        </Container>
    );
}

It's great use for my use case but it's not ideal I think if it's part of a larger Windup sequence ... you'd need to move the text into its' own component, and use a Pause component to make sure that the main animation doesn't race ahead

Sorry for the late reply. I think you solved this the 'right' way! You could also use WindupChildren's onFinished prop rather than <Effect>.
Would you be so kind as to explain the issue with a larger windup sequence you started to describe?

I'm not sure I remember what I meant by "larger sequences" actually 😅 in trying to find what I had been thinking about I re-wrote a better explanation of my problem/solution which might be useful:
So essentially I was trying to change the colour of the text "****" to red at the end of the animation to show that the "pin attempt" made by the character failed. So I wanted to change the colour of the text, like in the guide, but without re-running the animation
To achieve this I made the above PinAttempt component, and then nested that within my animation component, like so:
...
return (
    ...
    <Pause ms={SHORT_PAUSE} />
    <PinAttempt pace={SLOW_PACE} midPause={0} />
    <Pause ms={SHORT_PAUSE} />
    <PinAttempt pace={SLOW_PACE*0.5} midPause={SHORT_PAUSE*0.5} />
    ...
);

When the pinFin state is changed on the PinAttempt component React re-renders it, but since the shape of the children hasn't changed Windups doesn't restart the animation


Conditional template logic in index.html for beta.11-webpack

Version  1.0.0-beta.11-webpack
Issue Handlebar template processing removed?
Detail
As noted in the https://github.com/angular/angular-cli/blob/master/WEBPACK_UPDATE.md document, the handlebar template logic was removed from index.html. It looks like there is no longer support for conditional logic in the index.html file using handlebars. Is that correct?
Including something like {{#if environment.production}} Only show in production build. {{/if}} the template is not processed. Has this feature been removed (or will it be)? I think this is an incredibly useful feature for including things like Google Analytics, Facebook, etc with API keys.

It has been removed, yes. My suggestion for those tokens is to use the environment files feature: https://github.com/angular/angular-cli#build-targets-and-environment-files.
It won't allow you to have different index.html content, but will allow you to customize tokens and whatever other code you put in each.
For things you absolutely 100% need to load remotely, my recommendation for now is https://github.com/ded/script.js.

So how can the index.html/index.ejs be transformed? With no access to environment variables or webpack config, this seems extremely limiting. The addition of the --base-href flag seems to illustrate pretty strongly that a precompile stage needs to be exposed.

@awexfwex did you end up getting Handlebars to work with Angular4?   I am in the same boat with trying to get some items from a service and into the head tags on index.html.   It is very easy with Handlebars/Express in my test but I am looking to put it all together with Angular.

We stopped using the cli, and set things up the old fashioned way. The decision was for finer control over easier configuration. I haven't kept up with the angular-cli project, so not sure if this is possible now or not.


Issue with android-utils-sdk-1.1.2

Hi everyone,
I just added the react-native-video-trim to my project and it's giving the following error when i try to run on android,

Could not resolve com.github.iknow4:android-utils-sdk:1.1.2.
Required by:
project :app > project :react-native-video-trim
Could not resolve com.github.iknow4:android-utils-sdk:1.1.2.
Could not get resource 'https://www.jitpack.io/com/github/iknow4/android-utils-sdk/1.1.2/android-utils-sdk-1.1.2.pom'.
Could not HEAD 'https://www.jitpack.io/com/github/iknow4/android-utils-sdk/1.1.2/android-utils-sdk-1.1.2.pom'. Received status code 401 from server: Unauthorized

i am using the latest react native version 0.72.6

Have you added jcenter to repositories in android/app/build.gradle?

I have added it to android/build.gradle as the repositories were there too, should i move these to the app folder.

Yeah bro, pls follow my Readme and add it in correct file

Thanks a lot it works, i guess i ought to follow the setup guides properly.


Error when bundling with zxp

hello!
When I was running the command yarn zxp I was receiving an error about certificate file is not valid.
Then I discovered that this issue is caused by the root name path of the project , for instance if you clone the repo in a folder named : "c:/users/documents/Post production/bolt-cep"

Then I renamed the folder name without any space between Post-production and everything is running fine.

@gribias thanks for finding this! Corrected in vite-cep-plugin 0.1.7 https://github.com/hyperbrew/vite-cep-plugin/commit/b938962aa81484b2d7bfdce6ff94ef6628160f2d


Remaining changes for rtcs* refactorings

Additions for #1222

works fine :)

@borshop merge

No release notes needed as this is a test code update


Handful of frontend fixes

Bugs
▹ shouldn't the compressed that didn't work! have a border still?

▹ don't show .user_card_content_divider if no location is set

▹ admin user thumbnails are cropping strange & not scaling down

▹ Edit/Playlist Long track names truncate awkwardly in the Available tracks right column, should break before the +

▹ Edit/Playlist Shorten the left column instructions, on thin 2 column views, the inconsistent line wrapping is bad, or at least link these divs together

Does anything special need to happen for deployment?
CSS changes should be superficial and only beneficial.
"Ready For Review" checklist
These checklists are to help ensure the code review basics are covered. Consider removing to reduce noise.

[ ] PR title accurately summarizes changes
[ ] New tests were added for isolated methods or new endpoints
[ ] I opened an issue for any logical followups
[ ] If this fixes a bug, "Fixes #XXX" is either the very first or very last line of the description.

Before code review and after additional commits during review.

[ ] Update title and description to account for additional changes
[ ] All tests green
[ ] Booted up the branch locally, exercised any new code
[ ] Percy changes are purposeful or explained
[ ] Css changes are happy on mobile (via Percy is ok)

@ofsound For future PRs, it might make sense to leave Percy unapproved, it makes it a bit more obvious that something changed.
In this case

It looks like there's some unintentional added spacing on playlist/edit desktop — can you look at that one?

It looks like there's some indeterminism with my new "Playback Track Playing" test — I might clean that up in this branch so that it seeks and pauses or something so we don't see variation in the playhead.

@ofsound I think we can merge this after you take a look at the spacing above the edit playlist sortable, that seems to be unintentional. I might have to continue wagey the war on animations in another branch — I need to find a way to "pause" our new playhead stuff for percy.


Receive screen - Comment field - Font issue

Please, implement the font and font size as in the design:

Please take build from https://github.com/BeamMW/beam-ui/commit/965bd91b1725fddfe521b0fcbb4313aa64ccebcf
Check if ok and if we should merge this.


AFHTTPRequestOperation reported as finished before executing its success block

If you have an AFHTTPRequestOperation, it will change its state to "Finished" before it executes the success block. This seems unexpected to me, especially when you consider behavior in a batch. For example.
I'm creating a single bitmap from a series of image tiles. I create 10 requests operations, each getting a map tile from the server - in their completion blocks they write their map tile image onto a bitmap they share. Then, I put all of these into a batch with a completion block that turns the bitmap into a final image. My expected flow would be:

request operation 1 completes and calls its completion block
request operation 2 completes and calls its completion block
request operation 3 completes and calls its completion block
and so on...

then, when all of the operations have been completed - the batch's completion block would be called.
It's actually backwards - the operations signal that they are "finished", which causes the batch operation to call its completion block, then the completion block for each request gets called.
It's not just the batch operation here - the issue seems to be in when AFURLConnectionOperation sets it's Finished flag, because I see the same behavior if I just stick the request operations in my own queue and "wait until all completed".

A low impact work around in including in pull request #207

Are you sure that each of the operations in a batch are waiting to execute their completion blocks?
If you are depending on the execution of a completion block of an operation to be finished in time for a batched operation completion block, then you shouldn't have that logic in individual completion blocks. Instead, have the batch completion block iterate through each of the member operations and ask for the representation of the data you need (perhaps responseImage in your case).
Does this solve your problem, or is there another reason why your approach in the pull request would be necessary?

The issue there is that I'd have to (in my particular case) keep around each of the tile images, rather than simply writing them to a bitmap context. Meaning, they'd have to be in memory. I could probably get away with it in this particular case, but logically it just seems to follow that the completion block is "part of" finishing the operation. At least that was my thought when I implemented the code. The operations are "complete" when their completion block runs, but I can see how you could look at it either way.

Yeah, that could better explanation. AFURLConnectionOperation, the base operation class, is designed to do everything involved with fetching data from a URL; no more, no less. It just so happens that often when we get data from a server, we want to do something with it, hence the completion block. All of the data is there when it finishes—it's just a matter of transforming it into a desirable format. To ensure good performance, the completion blocks of the built-in classes are wrapped in an asynchronous dispatch.
Let me know how that alternative approach works for you.

Here's the other way someone's tried to describe and address the issue.
https://github.com/seatme/AFNetworking/commit/11159eed02ac50e45404d1ec88ce9eb8cc0bc858

Yes, I'm aware of that branch. It went way too far in one direction for my tastes.
As for dispatching to the main thread, that was intended as a good-but-easily-overridable default (simply dispatch back to an asynchronous queue for any further processing). That said, enough people have requested something more direct, that pull request #202 will likely be merged in sometime this week.
Thanks again for your input, Duane!


Added gold-a647 mic comparisons to  mic analysis

This pr adds GOLD-A647 MIC comparisons to the MIC analysis. Any constructive feedback is welcome when reviewing this pr.

Thanks @MikeLippincott, merging now!


Achievements are visible but grayed out until achieved.

Too hard to figure out what they actually are when playing. This will help.

o.Albedo = (c.r + c.g + c.b)/3;


python310Packages.univers: 30.7.0 -> 30.10.0

Changelog: https://github.com/nexB/univers/blob/v30.10.0/CHANGELOG.rst
Description of changes
Fix build (https://hydra.nixos.org/build/218051597)

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 229846 run on x86_64-linux 1

4 packages built:

python310Packages.univers
python310Packages.univers.dist
python311Packages.univers
python311Packages.univers.dist


Promote release-service from development to staging

Included PRs:

https://github.com/redhat-appstudio/release-service/pull/380
https://github.com/redhat-appstudio/release-service/pull/385
https://github.com/redhat-appstudio/release-service/pull/381
https://github.com/redhat-appstudio/release-service/pull/313
https://github.com/redhat-appstudio/release-service/pull/379

/lgtm

/test appstudio-e2e-tests


Minor changes

When running ansible on OS X, the with_fileglob /etc/ssh/*.pub was failing:

 failed: [<redacted>] (item=/private/etc/ssh/ssh_host_dsa_key.pub) => {"failed": true, "item": "/private/etc/ssh/ssh_host_dsa_key.pub", "msg": "file (/private/etc/ssh/ssh_host_dsa_key.pub) is absent, cannot continue", "path": "/private/etc/ssh/ssh_host_dsa_key.pub", "state": "absent"}

I added security_enable_audit_during_boot to allow disabling the auditd.service startup as the VPS I am currently using does not allow the service to run

dict object issues with empty list, other tasks included the same change:
example: openstack-ansible-security/tasks/rhel7stig/rpm.yml:  with_items: "{{ rpm_gpgchecks | default([]) }}"

Thank you for contributing to openstack/openstack-ansible-security!
openstack/openstack-ansible-security uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
http://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.


*Test.class test files are not being detected

This issue was observed during development of the batch metrics api and addressed via a change to the build.gradle file in #159. However, it looks like adding that change introduced other build failures (these build failures only show up on github, not on a laptop). So, that change needs to be removed to fixup the build pipeline, and then we need to fix the issue as part of a new pr.


GLDAS 2.0 and 2.1 file download

Add download option for GLDAS NOAH v2.0 and v2.1 data from https://hydro1.sci.gsfc.nasa.gov/data/
Remove download for GLDAS NOAH v1 data (depreciated).

Is the documentation automatically created just from the index.rst file?

Yes but by default only for the master branch and tags.

I just did download gldas image data and TS upgrade with the "new" files - worked fine. But I recalled that using netcdf4 package of version > 1.2.2 leads to a "bad chuck size Error" during reshuffle process. Do you know about this problem? I think if we can't fix it, we should at least change the package requirements accordingly.

Hi, yes the problem is actually not with netcdf4 but with the underlying C library. See https://github.com/Unidata/netcdf4-python/issues/566
The netcdf4 version is already pinned in the environment.yml file which should take care of the C library issue. In the requirements.txt we can only influence python package versions so we don't have to pin the version there.


[BUG]

When I apply controlnet in the mode of Text2image,
I got a error:  Error: No upstream images for ControlNet 0

How can I link my viewport to controlNet?
Thank you so much!

Upstream image is an image stored in File attribute in the previous nodes. For example you can get one by reading files with File Pattern node, by rendering image with Rop fetch node or by generating an image with SD Dream node.
In my last tutorial I explained how to get a depth map from your viewport.
https://www.youtube.com/watch?v=SJ5o18kJkRA

I assume this is not a bug. If you have questions, please post them in QnA section of the Discussion tab. Feel free to open a new bug report if you got problems.


math/big: better multiply primitives

Suggestions from Torbjörn Granlund (personal e-mail):
"
The multiply primitives, in particular addMulVVW surely deserves more
attention:
Offset the pointers so that you can index with a counter register
which goes from -n to 0, saving the CMPQ.
Unroll.  You can save most of the ADCQ $0, R that way.  Basically,
do one run with just MULQ where you sum the old highpart (DX) with
the new lowpart (AX).  You will need some MOVQ to move DX
out-of-the-way too.  Then do a new run over these sums where you
bring in the memory addend.  This should double the speed on some
newer CPUs.
A good addMulVVW is probably really the first thing to write in
assembly; addition and subtraction is much less important, usually.
"

See also https://go-review.googlesource.com/c/go/+/76270 (for arm64) where it is reported:
The lack of proper addMulVVW implementation for arm64 hurts RSA
performance
This is an optimized implementation, it improves RSA2048 performance
by 10X to 15X on ARMv8 based server processors.

/cc @ericlagergren

Pushing to next release. There are some discussions about other math/bits primitive operations; maybe we can write some of this code in Go rather than assembly at some point.


Support complete distinct usage for aggregate expressions

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Here are multiple aggregate expressions have not support distinct usage yet.
Though optimizer SingleDistinctToGroupBy (#1315) supports single distinct usage, there are more SQL scenes have not been covered, like
SELECT AVG(c1), SUM(DISTINCT c2) FROM test

I would like to take effort to work on the following tickets to complete distinct usage for aggregate expressions

[ ] #2405
[ ] #2407
[ ] #2408
[ ] #2409
[ ] #2410
[ ] #2411
(more to be added later)

Describe the solution you'd like
Adds specific aggregate expression support, like expressions::DistinctSum for sum(distinct)
Describe alternatives you've considered
No.
Additional context
No.

@andygrove @alamb can you please assign this issue to me?

@andygrove @alamb can you please assign this issue to me? Thank you ❤

Done -- thanks @WinkerDu


try to solve android arch

cc @kpango trying to fix #41  #31

Doesn't go have something similar to C++ alignas? https://en.cppreference.com/w/cpp/language/alignas
I'm surprised Go atomics aren't aligned automatically to the underlying size.
Assuming Go atomatically aligns trivial types to their size, yes this will ensure 64-bit alignment.
However from a performance point of view, you might want to separate atomics by about a cacheline (64-byte) for those accessed by multiple threads to avoid false sharing.

Doesn't go have something similar to C++ alignas? https://en.cppreference.com/w/cpp/language/alignas
I'm surprised Go atomics aren't aligned automatically to the underlying size.
Assuming Go atomatically aligns trivial types to their size, yes this will ensure 64-bit alignment.
However from a performance point of view, you might want to separate atomics by about a cacheline (64-byte) for those accessed by multiple threads to avoid false sharing.

https://golang.org/pkg/sync/atomic/#pkg-note-BUG it seems that's is a known bug

@Milerius Thank you for the PR. I would love to incorporate this fix if it solves the long standing problem .
Have you tested this on an Android device?
I don't have an Android device on hand, so I can't test it.

@Milerius Thank you for the PR. I would love to incorporate this fix if it solves the long standing problem .
Have you tested this on an Android device?
I don't have an Android device on hand, so I can't test it.

Hmm I would like an advice how to use this patched version of glg in my program to test my fix also https://github.com/kpango/glg/issues/107 seems to break android compatibility, good things is you can test this local fix by compiling for ARM and use qemu to launch example, but for android i need a way to build glg with my patch

Something you can try @kpango is:
install android studio.
Compile your module with gomobile bind -v --target=android .
and import it in android studio as mentionned in: https://medium.com/@LogPacker/gomobile-library-development-for-ios-android-8711e76817d8
You do not need any android device because there is a simulator

Thanks for providing the verification method, I guess I need to release it for Dependency to try it on Android, I'll keep the Issue and merge this PR and release Patch for glg as well.
I'll contact you about it, can you verify it for me?


Thoughts on adding abbreviated commands to bin?

Adding commands similar to what npm has? i would be shorthand for install, l for list?
Not sure if this has been discussed in the past

Do you literally mean /usr/local/bin? If so, placing executables with such a short name is likely to be problematic. Or do you talk about abbreviations you can use with brew, e.g. brew i would mean brew install. If that's what you are looking for, there's already a solution: https://github.com/Homebrew/homebrew-aliases

Yeah, I think for either of these, per-user aliases configured in the shell (for standalone commands) or brew alias (for brew subcommands) is the way to go, not something global like adding to /usr/local/bin or making subcommand aliases for everyone.

https://github.com/Homebrew/homebrew-aliases is what I was talking about. Thanks @UniqMartin, wasn't able to find that, satisfies my need :)
@apjanke why not add subcommand aliases (like brew i for brew install) for everyone? I feel as if it's a common pattern for package managers now?

@AndrewSB We may consider that in future but not now.


Restructure headscale documentation

Following the spirit of the 0.23 release, this PR aims to restructure the existing documentation to improve
maintanability while providing more information to users. It is mainly a preparation for versioned documentation in the
future which will allow us to evolve the documentation alongside headscale releases. Relevant aspects of this PR:

Split the documentation into multiple sections:

About: Information about the project: FAQ, features, client compat, contributing, …
Setup: Requirements, Install page for varous release, Upgrading
Usage: "Getting started", Connecting with Android/Apple/Windows
Reference: specific documentation (acl, dns, oidc, …) and integration with other components (reverse proxy, Web UI)

Remove duplication and split the common parts into their own pages
Document more ways to install headscale (official binaries and packages, distribution, container, …).
Add a configuration reference
Reuse existing documentation such as CONTRIBUTING.md
Replace duplicate content in the README with links to the docs (features, client)
Update wording to headscale (in regular text), Headscale (beginning of a sentence) and headscale when referring to the CLI.
Add redirects from old links to the new pages

A preview is available here: https://nblock.github.io/headscale/
Fixes: #2164
Ref: #1863

[x] have read the CONTRIBUTING.md file
[x] raised a GitHub issue or discussed it on the projects chat beforehand
[ ] added unit tests
[ ] added integration tests
[x] updated documentation if needed
[ ] updated CHANGELOG.md

I'm very happy with this, I will let the tests run and then roll out tomorrow unless you have any other things you think should be part of it @nblock

I'm very happy with this, I will let the tests run and then roll out tomorrow unless you have any other things you think should be part of it @nblock

I'm happy with it for now.


Fix cmake for usage of the slider as a library and add an editEnded signal

Hey, I'm revamping the UI of a node-based application I'm developping (for procedural terrain generation -> https://github.com/otto-link/Hesiod). I'm planning to use your widgets because they are really good looking and the bound check is really interesting!
I added some minor modifications:
efdde64a72290bbe5bb070f3a0ccb4cad51ae579 : I had to modify the cmake file in order to make it work out of the box for my needs.
02deaf9e11a9395717a814093099fd15a620632d : I added a new signal, triggered only when the editing is finished. For my case, to spare some computational resources, I just want to use the final value chosen by the user.
I hope you'll consider this as PR material. Let me know if you have any questions.

Hi, thanks for the review and the time spent on it. I took into account your feedback, the PR should be good. Let me know if there are still some modifications to make.

It seems that the rebase was not done properly. Your changes should be on top of those in the main branch, as shown by the commits in the screenshot above, there are some changes before and some changes after. That is also why the Files changed part shows a bunch of files that weren't edited. Please try to fix it so that this PR only shows the changes you made so that the git history stays clean

Indeed, sorry for the mess, I resubmitted a PR to ease things out...


TypeError: Cannot convert undefined or null to object

https://jsfiddle.net/b5v4faqf/2198/
(Open console to see the error)
As soon as I add decimal as a validator I get this error:
TypeError: Cannot convert undefined or null to object
at Function.keys ()
at VueComponent.keys (index.js?c19f:289)
at Watcher.get (vue.esm.js?65d7:2881)
at Watcher.evaluate (vue.esm.js?65d7:2988)
at VueComponent.computedGetter [as keys] (vue.esm.js?65d7:3265)
at VueComponent.proxy (index.js?c19f:296)
at Watcher.get (vue.esm.js?65d7:2881)
at Watcher.evaluate (vue.esm.js?65d7:2988)
at VueComponent.computedGetter [as proxy] (vue.esm.js?65d7:3265)
at VueComponent.refProxy (index.js?c19f:268)
HELP!!!!!

i have same problem

Problem has been fixed in newest version. Just update your vuelidate library.


feat: Implement unit tests for DatabaseAdminClient.

This PR implements initial unit tests for DatabaseAdminClient. The unit
tests can verify the code works in conditions that are hard to produce
in an integration tests, such as specific failures or timeouts.

This change is

Rebased to resolve conflicts.


[stable/sentry] Enable livenessProbe on workers

Uses sentry exec with celery's ping method for generating liveness check.
What this PR does / why we need it:
After running sentry in production for months, I have realized that liveness probe on workers is very important. I have seen some scenario where the main process was running fine but celery was not working properly. This checks celery by celery.task.control.inspect().ping() through sentry exec.
Special notes for your reviewer:
Output of liveness check:
root@sentry-sentry-worker-675dc7d6d9-7jmcn:/usr/src/sentry# sentry exec -c 'import celery, os; print(celery.task.control.inspect().ping().get("celery@{}".format(os.environ["HOSTNAME"]))["ok"])'
pong

root@sentry-sentry-worker-7fd96546df-sw476:/usr/src/sentry# sentry exec -c 'import celery, os; celery.task.control.inspect().ping().get("celery@{}".format(os.environ["HOSTNAME"]))["ok"]'
16:39:43 [INFO] sentry.plugins.github: apps-not-configured

root@sentry-sentry-worker-7fd96546df-sw476:/usr/src/sentry# echo $?
0

root@sentry-sentry-worker-7fd96546df-sw476:/usr/src/sentry# sentry exec -c 'import celery, os; celery.task.control.inspect().ping().get("WRONG_SHOULD_FAIL@{}".format(os.environ["HOSTNAME"]))["ok"]'
16:40:08 [INFO] sentry.plugins.github: apps-not-configured
Traceback (most recent call last):
  File "<string>", line 7, in <module>
TypeError: 'NoneType' object has no attribute '__getitem__'
Traceback (most recent call last):
  File "/usr/local/bin/sentry", line 11, in <module>
    sys.exit(main())
  File "/usr/local/lib/python2.7/site-packages/sentry/runner/__init__.py", line 162, in main
    cli(prog_name=get_prog(), obj={}, max_content_width=100)
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python2.7/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/sentry/runner/commands/exec.py", line 130, in exec_
    six.exec_(compile(script, file, 'exec'), g, g)
  File "/usr/local/lib/python2.7/site-packages/six.py", line 699, in exec_
    exec("""exec _code_ in _globs_, _locs_""")
  File "<string>", line 1, in <module>
  File "<string>", line 11, in <module>
__main__.ScriptError: Failed to execute script '<string>'

root@sentry-sentry-worker-7fd96546df-sw476:/usr/src/sentry# echo $?
1

Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md

@sameersbn @unguiculus Can you please review it?

/assign @viglesiasce

I have no update. Didn't got any response from maintainers


libct/cg/fs/freezer: make sure to thaw on failure

Function (*FreezerGroup).Set has a few paths where in can return an
error. In any case, if an error is returned, we failed to freeze,
and we need to thaw to avoid leaving the cgroup in a stuck state.
Cherry-picked: fcd7fe85e1ea706fbdfb383824e9f390a53a34e9
Refers to: https://github.com/projectatomic/runc/pull/47
cc @kolyshkin @haircommander

LGTM

@saschagrunert can you also pick up https://github.com/opencontainers/runc/pull/2941?

@saschagrunert can you also pick up opencontainers/runc#2941?

Isn't it already in: https://github.com/projectatomic/runc/pull/52 ?

@saschagrunert can you also pick up opencontainers/runc#2941?

Done in https://github.com/projectatomic/runc/pull/53

Close/reopen to re-kick CI


No space left on dockerhost-equinix-ubuntu2004-armv8-1

No space left on dockerhost-equinix-ubuntu2004-armv8-1, a dockerhost machine which runs about 11 static docker conainters.
NAME        MAJ:MIN RM   SIZE RO TYPE MOUNTPOINT
nvme0n1     259:0    0 894.3G  0 disk
├─nvme0n1p1 259:2    0   500M  0 part /boot/efi
├─nvme0n1p2 259:3    0     9G  0 part [SWAP]
└─nvme0n1p3 259:4    0 884.8G  0 part /
nvme1n1     259:1    0 894.3G  0 disk

root@test-equinix-ubuntu2004-armv8l-02:/home/jenkins/workspace# df -h
Filesystem      Size  Used Avail Use% Mounted on
udev            251G     0  251G   0% /dev
tmpfs            51G  4.2G   47G   9% /run
/dev/nvme0n1p3  871G  821G  6.0G 100% /
tmpfs           251G  213M  251G   1% /dev/shm
tmpfs           5.0M     0  5.0M   0% /run/lock
tmpfs           251G     0  251G   0% /sys/fs/cgroup
/dev/nvme0n1p1  500M  7.3M  492M   2% /boot/efi
tmpfs            51G     0   51G   0% /run/user/1000
tmpfs            51G     0   51G   0% /run/user/0

(The docker service is stopped which is why you are not seeing each of the containers in the output of the df command)
I noticed that there is a 900g spare disk nvme1n1 which isnt being used. It should be mounted to /var/lib/docker, allowing docker to make full use of that disk, preventing it from using anything in / (which is what it is doing currently)

docker system prune just reclaimed 400g of space. This should keep the machine running for a while, but its spare disk needs to be put to use to avoid hitting this problem in the near future

root@test-equinix-ubuntu2004-armv8l-02:/home/jenkins/workspace# df -h /var/lib/docker
Filesystem      Size  Used Avail Use% Mounted on
/dev/nvme0n1p3  871G  381G  446G  47% /

Is this something that Nagios alerted to? How was it discovered?

I raised this recently: https://github.com/adoptium/infrastructure/issues/2984
but not sure if this issue was raised as an outcome of it or something else.

Closing as the immediate issue has been closed and #docker will cover related future investigation.


Bug: Using 'message' as propertyname drops the log entry

What version of Serilog.Sinks.Elasticsearch is affected?  Please list the related NuGet package.
8.4.1
What is the target framework and operating system? See target frameworks & net standard matrix.
Windows, .NET 6
Please describe the current behavior?
When using a messageformat in theILogger.<Loglevel>(messageTemplate, propertyValue)family of functions, using 'message' as propertyname as depicted below will result in the logmessage (quietly) not being processed.
The behavior cannot be reproduced by using serilog with a different sink.
If the current behavior is a bug, please provide the steps to reproduce the issue and if possible a minimal demo of the problem

The field "message" is used as special field in elastic search. If you really need to keep "message" you should change in the configuration file the property "inlineFields": false
this will produce a second level of fields

Right. Sounds sensible.
Nasty to pin down though.


support for parsing a string

currently it appears that changelog-parser only works w/ file paths.  however, i'd like to pass in a string (pulled from a github graphql query) rather than a file path.   is this possible?
for example:
let md = "#some markdown in a changelog ... (versions, changes etc)";

let result = await parseChangelog(md);

console.log("the versions: ", result.versions)

is this possible?  I'm not super familiar w/ line-reader but maybe something like this would help?  https://github.com/feross/string-to-stream

Hi @benmonro!
It looks line line-reader does have some support for streams -- see the streams section in their readme.
https://github.com/nickewing/line-reader#streams
I'm not sure if this is possible with changelog-parser right now, but it might be? If not I'm definitely open to a pull request to make your use case easier. It's been a few years since I wrote this, definitely starting to show its age :)

Hey @ungoldman all good.  I like this tool a lot but I decided to  implement it with standard-version and Semver support using remark to process to ast.  Fun stuff.  🙂 https://github.com/benmonro/chast


Set the user name in from in new version

I was able to set the user ID in the new version of web chat, but I can't figure out how to set the user's name. I've got some logic that relies on the user's name in a bot and need to set this before migrating to webchat v4. Is there a way to set this?

We obsoleted the user name in the UI and prefer using avatar initials.
Do you think a customizable timestamp will work for you?

Currently I set the user name to the logged in user's Azure AD username to pass this to the bot to use it in some searches. Basically I need a way to do that in the new version. I don't need it displayed just passed to the bot. I could pass it in the back channel but would prefer not to because that would require saving it.
Thinking about it a bit more I could probably use the user ID instead. Is there a reason not set that to a username such as<EMAIL_ADDRESS>

You mean why we don't set user ID to<EMAIL_ADDRESS>This blog post explain about "tamper-proof user IDs", https://blog.botframework.com/2018/09/01/using-webchat-with-azure-bot-services-authentication/. The main idea is an unguessable and unforgeable user ID. Sorry it's so hidden in our docs.

Your approach would work, using a database to associate Direct Line user ID and email.
When I code bot, I try to make them as stateless as possible. So I am throwing another approach so you can weigh between them.
The another approach, I am outlining in this sample is using Redux middleware to inject email in the activity sent from Web Chat. This is very similar to HTTP cookies and vulnerable to forgery. Be sure to protect it using signature.
Since this approach is similar to HTTP cookies, it will lower your server load with slightly bigger traffic.
I just baked this sample and it is still in PR.
This sample requires a little change in our existing code. So expect it to drop publicly in 4.2 (mid-December). You can always use our development build (after PR merged) if you need it quick, probably within a few days.

I was able to set the user ID in the new version of web chat, but I can't figure out how to set the user's name. I've got some logic that relies on the user's name in a bot and need to set this before migrating to webchat v4. Is there a way to set this?

Hi @rosskyl,
How did you set the userID? I still haven't found a way to set the userId in v4.
Thanks in advance

Closing due to inactivity

@rosskyl we fixed it in 4.2.1-master.0b60abf.
If you pass, username as a props to Web Chat, we will pass it to the bot as activity.from.name. We won't use this username to generate user initials, because of I18N reasons.
Hope this will help you in your project. :)


get_my_price_for_asin not return the proper response

Hi,
I'm unable to get my price for the ASIN, through get_my_price_for_asin method.
when I call get_matching_product then I'm getting the listing price.
Thanks

Do you have an example of your non-working call?

It's Working fine now


Restructure front-end style utils and add components folder

Add website/src/components to hold general reusable components, and move several existing ones there.
Add website/src/style for the theme contract and any functions or classes we use for many different styles
Fix a bunch of tiny styling inconsistencies
Restyle Button inspired by buttons on ravelry.com
Consolidate hover and focus styles to work properly for mouse, keyboard, and touch inputs. Add onHover and onFocus helper functions for writing these styles.
Replace a with Link
Replace re-implemented icon buttons with our standard IconButton component.
Remove sprinkles entirely because it's less type-safe and more confusing than just making heavy use of helper functions

@patelShas and @chanmioh Could I get your feedback (if any) on this change before I merge it in?

Looks great! I think removing sprinkles and adding website/src/style makes more sense - also really like having the reusable, consistent components for basics such as Link and Button. My only question would be does this majorly affect the current files in the codebase utilizing preexisting frontend imports such as from sprinkles.css.tsx? And will any changes need to be made to the current structure of those files?

does this majorly affect the current files in the codebase utilizing preexisting frontend imports such as from sprinkles.css.tsx

Yes, this PR changes all imports from sprinkles.css to use these new files.


improvements to deduction theorem with quantifiers

cleans up statement of deduction theorem with quantifiers
adds missing \chi so modus ponens works right
corrects spelling of "eigenvariable"
minor changes to keep punctuation consistent

Thanks!


Block Harvest fails with Botania 1.8.9 / Hammerz <IP_ADDRESS>

I'm reporting this to both Hammerz and Botania 1.8.9 port repos since the bug only occurs when both mods are installed.
The problem is that blocks are not dropping their item form when broken with a pickaxe (tested diamond/manasteel). ie, diamonds dont drop from diamond ore, cobble doesn't drop from stone. If I use a hammer the items drop correctly.
The log fragment I think is relevant:
[19:13:51] [Server thread/ERROR] [FML/]: Exception caught during firing event net.minecraftforge.event.world.BlockEvent$HarvestDropsEvent@7ad57097:
java.lang.NullPointerException
    at vapourdrive.hammerz.handlers.DropHandler.onHarvestDrops(DropHandler.java:31) ~[DropHandler.class:?]
    at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_86_DropHandler_onHarvestDrops_HarvestDropsEvent.invoke(.dynamic) ~[?:?]
    at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:55) ~[ASMEventHandler.class:?]
    at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:140) [EventBus.class:?]
    at net.minecraftforge.event.ForgeEventFactory.fireBlockHarvesting(ForgeEventFactory.java:187) [ForgeEventFactory.class:?]
    at net.minecraft.block.Block.func_180653_a(Block.java:493) [afh.class:?]
    at net.minecraft.block.BlockOre.func_180653_a(BlockOre.java:60) [aim.class:?]
    at net.minecraft.block.Block.func_176226_b(Block.java:485) [afh.class:?]
    at net.minecraft.block.Block.func_180657_a(Block.java:832) [afh.class:?]
    at net.minecraft.server.management.ItemInWorldManager.func_180237_b(ItemInWorldManager.java:312) [lg.class:?]
    at net.minecraft.server.management.ItemInWorldManager.func_180785_a(ItemInWorldManager.java:234) [lg.class:?]
    at net.minecraft.network.NetHandlerPlayServer.func_147345_a(NetHandlerPlayServer.java:536) [lm.class:?]
    at net.minecraft.network.play.client.C07PacketPlayerDigging.func_148833_a(SourceFile:40) [ir.class:?]
    at net.minecraft.network.play.client.C07PacketPlayerDigging.func_148833_a(SourceFile:10) [ir.class:?]
    at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13) [fh$1.class:?]
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) [?:1.8.0_25]
    at java.util.concurrent.FutureTask.run(FutureTask.java:266) [?:1.8.0_25]
    at net.minecraft.util.Util.func_181617_a(SourceFile:44) [g.class:?]
    at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:660) [MinecraftServer.class:?]
    at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:605) [MinecraftServer.class:?]
    at net.minecraft.server.integrated.IntegratedServer.func_71217_p(IntegratedServer.java:152) [bpo.class:?]
    at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:481) [MinecraftServer.class:?]
    at java.lang.Thread.run(Thread.java:745) [?:1.8.0_25]
[19:13:51] [Server thread/ERROR] [FML/]: Index: 3 Listeners:
[19:13:51] [Server thread/ERROR] [FML/]: 0: NORMAL
[19:13:51] [Server thread/ERROR] [FML/]: 1: ASM: vazkii.botania.common.item.equipment.tool.elementium.ItemElementiumPick@3ee0a533 onHarvestDrops(Lnet/minecraftforge/event/world/BlockEvent$HarvestDropsEvent;)V
[19:13:51] [Server thread/ERROR] [FML/]: 2: ASM: vazkii.botania.common.item.equipment.tool.ItemGlassPick@160e6384 onBlockDrops(Lnet/minecraftforge/event/world/BlockEvent$HarvestDropsEvent;)V
[19:13:51] [Server thread/ERROR] [FML/]: 3: ASM: vapourdrive.hammerz.handlers.DropHandler@37013dda onHarvestDrops(Lnet/minecraftforge/event/world/BlockEvent$HarvestDropsEvent;)V

The full log is available at http://pastebin.com/7aVEfWWb
To reproduce, install:
Forge - 1697
Hammerz - 1.8.9-<IP_ADDRESS>.jar
Botania - 1.8-248-MC1.8-568ee04
Then break a block with a diamond/manasteel pickaxe.
Thanks.

williewillus/Botania/issues/45

So is this a crash?

yeah, the eventhandler NPE's

Not sure if this is our fault, you say that you can reproduce by using a manasteel pickaxe, except that our eventhandler doesn't apply at all unless the tool is an elementium, terrasteel, or glass pickaxe
Are you sure you can only do it with botania installed?

I would say this isn't Botania's fault at all, I'll add yet more null checks and see what's up.

@williewillus Positive. With either mod on its own everything works perfectly. Add them together and no drops. Thats why I reported on both repos since it's likely some sort of interaction in the handlers.

Strange that this hasn't caused an issue before. Either way, I changed how I handle stacks where I'm not sure that the item is a Hammer so this type of thing shouldn't pop up anymore.
Will see if I can push the release tonight (if I can log into curse from where I am >.>)


functions inside forall, foreach, findall, bagof, etc.

Expanding a function inside the goal argument of these predicates should keep the entire expansion inside the predicate.  Currently it moves the expansion outside the predicate.

A concrete example of the problem:
$ cat expand.pl
:- use_module(library(func)).
nmain :-
    bagof(x,between(1,succ(2,~),_),Xs),
    writeln(Xs).

$ swipl -q -s expand.pl
1 ?- listing(main).
main :-
	succ(2, A),
	bagof(x, between(1, A, _), B),
	writeln(B).

true.

The listing should have been as follows:
main :-
	bagof(x, (succ(2,A),between(1, A, _)), B),
	writeln(B).


Do not open projects in the Trash

When viewing the Trash List, do not permit projects to open if clicked on.
Change-Id: If6faee5775334e99aba7d481a8dd6525a6e987e7

One minor UI issue is whether we should still have trash items use cursor: pointer; which to me implies that clicking the item will do something.

@ewpatton I'll look into the UI change, but as a separate PR


Scrape sub pages too

Hey @Haradai
Thank you so much for this integration 🙏
I was trying to use it for a demo, and I wanted to scrape the pages in https://docs.haystack.deepset.ai
Is there a way I could scrape beyond this URL? Could I also scrape the subpages like https://docs.haystack.deepset.ai/docs/document_store and so on?

Oh, wow so cool you want to use it in a demo! Glad that can help. :)
To the first question, you should be able to just filter urls https://docs.haystack.deepset.ai/ by using some filter string like "docs.haystack.deepset.ai".
To actually go around all subpages, with the crawler node you could get to many of them just by using this filter and using the homepage as intial query, that though will not assure you are actually reaching all the pages as they have to be linked between each other, and then that the parsing finds all links.
What would probably work better would be to  try looking at the sitemap.xml file I found when looking at robots.txt file. You should be able to load this in python and then just pass all the urls in a list to the scraper node using run batch. (Not sure if this sitemap.xml is standard format in all websites maybe would be a cool implementation to the scraper node?)
If for some reason this sitemap xml doesn't contain all the urls in the webpage you could even try setting in a crawler node, query=[""],  the "docs.haystack.deepset.ai" filter,  then set crawler.stack = [sitemapxml links list] and let it run until it has no more links to find, so put number of pages to a big number.
Hope it helps! Any more questions or if you find bugs happy to help!


Animated Dialog Box Added

Accepted and merged.

Hey @dev1abhi it shows not accepted on hacktoberfest website?

Hey @dev1abhi it shows not accepted on hacktoberfest website?

It will be reflected after 15 mins or so.


feat: make supersetbot do what dependabot should do

Trying to get supersetbot to do what dependabot should do. Note that:

moving to using a pyproject.toml, which is preferred way to setup project metadata in python as of semi-recent PEPs
working within version boundaries for now, running pip-compile-multi -P  once per package
implemented as supersetbot bump-python CLI command
can be triggered manually with a github action with parameterized workflow-dispatch

Next steps:

schedule
set up for optional deps? devlopment.txt?

I decided to move the bot out of this repo and onto here -> https://github.com/apache-superset/supersetbot

Just curious, is this out of necessity, or just easier to work on it? It might be nice to move it back into Superset/ASF control once the dust settles if it's just to make it easier to get things spun up and tested for a while.

Yes the main reason is it doesn't require the same level of scrutiny and rigor as the main repo, and it can have it's own CI/release cycles/tests, .

Right, it can always move back here once things settle.


Update package to version 2.8

Comment:
It is my first issue on a conda feedstock, so I am sorry if I am breaking a rule. I saw that there are some pending PRs to update to 2.7.2. However, the latest version of the package is 2.8. Is there a way to go to version 2.8? Although I am a beginner, I would like to help if it is possible.

Hi @innerout ,  I was able to confirm that the bot stopped opening new PR's because there were too many open.  I'm going to try to get the latest bot PR merged and close the older ones, then 2.8 should be created and I'll get that pushed too.

Hi @timsnyder, I appreciate the feedback. I will wait for the latest version to be merged then.

Hi @innerout , do you happen to have a osx_arm64 machine?  The 2.8 build is failling on the ARM builds for macos as I mentioned in https://github.com/conda-forge/cppcheck-feedstock/pull/59#issuecomment-1169529211.  If you have an arm-based mac and any thoughts on how to fix those builds, it would be helpful.

I am completely inexperienced with ARM and macOS, and I don't have an ARM or a macOS machine, but from a brief search, people report that setting zsh as the default shell fixes the problem. https://discussions.apple.com/thread/250777998
Also, I found these, but I don't think that's the case here. Maybe the 2nd one may fix the problem.
https://stackoverflow.com/questions/72006530/bad-cpu-type-in-executable-mac-intel-core
https://www.journaldev.com/51374/bad-cpu-type-in-executable-fixed

Sorry for the delay on this.  I was able to figure out wny the osx_arm64 builds are failing (see #69) and disabled them for now.  2.10.1 should be available from anaconda.org in a while.


Create a ROADMAP.md

Create a ROADMAP.md file in this repo with a list of features and/or fixes we plan to implement in the future.

Closing this as it is merged as part of https://github.com/paralus/paralus/pull/24


isAsset bugfix

isAsset parameter was not passed on to loadTexture. This fixes loading textures from local storages

Hey man, thank you so much for this PR, it fixes the loading of texture from local storage! I spent days on trying to understand the code and implementing a fix ! 👍


Quest item

Hey Mate.  Is it possible to make a quest item as in default blizzard UI. When it pops next to the quest in right side?

Quest item buttons should appear in the quest tracker. The tracker shows quests in the current zone.
If it's not working, please tell me which version of WoW you're on, and what level and class you're playing so I can try to reproduce the problem here.

Updated a lot of the tracker functionality in 1.3.97, so I'm closing all currently open issues on this.


v3 API expects time to be iso 8601 format, not an int timestamp.

Purpose
Fix time format in v3 track api
Type of PR

[x] Bug Fix
[ ] Feature Work
[ ] Revert
[ ] Refactor / Code Cleanup
[ ] Other (fill in...)

Short Description

Using a timestamp results in a 400.
Changelog / Code Overview

Changed to iso8601 date format
Test Plan

What to look for

Related Issues/Tickets

Sigh, forgot to update tests, one second.


Interaction with other player's colliders no longer works

I am no longer able to see other players and myself interact with eachother's colliders after the recent vrchat update

woops misclick

the same thing is happening to interaction with other peoples colliders no longer works after Vrchat updated its self recently.

Indeed trying to interact with others no longer works with new VRChat update, I have tried multiple avatars with a friend using the same mod none of our avatars can interact with each other anymore. We can still move our own hair etc but touching each other yields no results.

The issue is known yes, I am currently recoding the project and it's code progress can be seen on the fullVersion branch

I saw you splitting a mod in Discord
Will Dynamic Bone Collider Mod be split?
I need your mod because emmvrc doesn't ignore pull colliders
sorry I used google translation

Yeah, everything in VRCExtended will now be a separate mod and this repo will be archived

I have stopped working on VRCExtended, and have begun working on other mods now. This repo is dead and will be archived.


generate the sql update files in the binary (build) directory

What does this implement/fix? Explain your changes.
I noticed that the upgrade sql scripts are created and installed from inside the source tree. This PR just moves them into the corresponding build directory.
Any other comments?
@ptosco  I only tested these changes on linux, but I'm hopeful they are small enough to work on windows too.

@rvianello : the CI failure here is not real


Reading virtual references back out into VirtualiZarr Manifests

I would like to be able to read virtual references back out from an icechunk store into VirtualiZarr ManifestArray objects.
Note this issue is the icechunk equivalent of https://github.com/zarr-developers/VirtualiZarr/issues/118, which is about reading kerchunk references into ManifestArray objects.
The main use case is appending new data to an existing store (see https://github.com/zarr-developers/VirtualiZarr/issues/21#issuecomment-2114001053), so that when some new data arrives (e.g. a new grib file with today's weather data), I can add an updated snapshot just with something like:
import virtualizarr as vz

# avoids re-extracting all the metadata from all the past grib files, so should be quick
existing_vds = vz.open_virtual_dataset(icechunkstore, reader='icechunk')

new_vds = vz.open_virtual_dataset('todays_weather.grib', reader='grib')

updated_vds = xr.concat([existing_vds, new_vds], dim='time')

# commit new snapshot that includes today's data
# requires https://github.com/earth-mover/icechunk/issues/103
updated_vds.virtualize.to_icechunk(icechunkstore)
icechunkstore.commit('<todays-date>')

In order to implement that Icechunk reader for virtualizarr I would need some API for getting all virtual (and non-virtual) references for a snapshot back out of the Icechunk store, ideally as a vz.ManifestArray or something I can cheaply coerce to one (see ChunkManifest.from_arrays()).
Writing the updated references as a new snapshot also requires https://github.com/earth-mover/icechunk/issues/103.
(I guess the .virtualize.to_icechunk method might also need to know to do array.resize in this example... (see the Append example in this notebook.)
Running that above snippet as a cron job / event-driven serverless function should go a long way towards making ingestion of regularly-updated data archives easier. (cc @mpiannucci)
This feature might also be useful to allow using icechunk as a serialization format during large serverless reductions (xref https://github.com/zarr-developers/VirtualiZarr/issues/123).
cc @paraseba

Should we add a note that it is not currently possible to append virtual refs to icechunk stores in https://icechunk.io/icechunk-python/virtual/ and point to this issue? cc @mpiannucci

Ok thanks for explaining how the append method is working @TomNicholas - but if I understand correctly there is no way to append virtual refs at the moment, so I would still see a benefit to others to make this clear in the documentation.
Is there any plans to work on this feature in VirtualiZarr @TomNicholas @mpiannucci ?

I would still see a benefit to others to make this clear in the documentation.

:+1:

Is there any plans to work on this feature in VirtualiZarr

I would very much like to see it, but don't personally need it (yet) so will be prioritizing other things. It's a good thing for somebody else to add, especially someone who is (or wants to become) familiar with xarray's existing to_zarr implementation.

I'm going to use https://github.com/zarr-developers/VirtualiZarr/issues/21 to track the append_dim idea in VirtualiZarr.
Separately I still think that being able to pull virtual references back out would be useful. Imagine for example someone makes a public icechunk store containing virtual references, then someone from a different organisation wants to refer to those references - they would need to pull them out. (Whether or not people creating catalogs like this is a good idea is another question, but I bet people will ask for that.)

@rabernat just said in the Pangeo showcase that icechunk is not yet at a state where it guarantees that references written with the current spec will be readable even with future versions of this library. To me that makes the feature of reading virtual references back out into VirtualiZarr actually quite important to have sooner rather than later. If that existed, then if the icechunk store changed on disk, I could always roll back to a version of the icechunk library that could read the references in order to suck them out then re-save them in the new format.

Cna you propose what the ideal API for this would be? It gets confusing for me thinking about how there can be mixed virtual and native chunks

It gets confusing for me thinking about how there can be mixed virtual and native chunks

Yeah good point. All variables in an icechunk store are potentially available as actual loaded data, or as references, so I would say that there should be a new virtualizarr reader, such that
vds = open_virtual_dataset(icechunkstore, loadable_variables=...)

returns an xr.Dataset containing (lazy) numpy arrays for the loadable_variables, and ManifestArrays for all the other variables.
I thought maybe we could imagine this function returning virtual vs native variables based on how they were stored in icechunk, but IIUC that's actually not possible right now because a single zarr array could be backed by some virtual and some native chunks, which VirtualiZarr has no way to represent in one array.
The API needed for icechunk-python at its most basic is just .get_virtual_ref, the inverse of .set_virtual_ref. Again it would be more efficient to get back a whole ManifestArray of chunk references in one call but that's just a performance optimization.

Cool. Would it return None if the chunk is native? Or throw an error?

I wanted to mention that having mixed virtual and non virtual chunks in a single array, is exactly what we want to enable: people starting from a virtual dataset and, with time, update the dataset in Icechunk (which would generate non-vrtual chunks). So we expect this case to be very common.

I support adding get_virtual_ref, but it could be more useful to have get_chunk_ref that gives you the whole information, including the fact that it could be Virtual, Inline or "Normal". Then the client code can filter as needed. For reference, this is what get_chunk_ref returns in Rust:
pub enum ChunkPayload {
    Inline(Bytes),
    Virtual(VirtualChunkRef),
    Ref(ChunkRef),
}

Would it return None if the chunk is native?

No, it would still return the virtual reference to that chunk, the reference would just refer to deep within this icechunk store. IIUC icechunk chunks are immutable once written, so referring to a chunk in an icechunk store from elsewhere is exactly as reliable as referring to a chunk in a traditional zarr store / legacy-formatted file.

I support adding get_virtual_ref but it could be more useful to have get_chunk_ref that gives you the whole information, including the fact that it could be Virtual, Inline or "Normal".

That would be fine for VirtualiZarr too (and maybe more useful for reasons I can't think of yet).

Inline chunks I think are the biggest issue here. As @TomNicholas says, "normal" chunks can also be seen as virtual chunks, pointing to the icechunk store. But inline ones live only in the manifest. We could provide a way to reference them via an offset/length, but it would be pretty tricky and ugly.

Tbh this makes inlined chunks seem like a leaky abstraction.
They are, I don't love them, they are leaky and probably a premature optimization.

We could make IC not use inline chunks unless the user overrides a config, I suppose.

Inline chunks don't matter to virtualizarr at all. To virtualizarr it's the same as a native chunk

Except we're talking about here having native chunks also be extracted as virtual references, which @paraseba is saying is harder to provide for inclined chunks than for native chunks.

Except we're talking about here having native chunks also be extracted as virtual references, which @paraseba is saying is harder to provide for inclined chunks than for native chunks.

They are, I don't love them, they are leaky and probably a premature optimization.

It's unclear to me that they are necessary at all. Why can't you just "inline" a variable by storing it as a single native chunk? That requires an extra get request I guess? Or because then you can't cache it in the rust client?

That requires an extra get request I guess?

This. They are useful for things like coordinate arrays.

Except we're talking about here having native chunks also be extracted as virtual references, which @paraseba is saying is harder to provide for inclined chunks than for native chunks.

Got itttt sorry I misunderstood :)


Update README.md with evaluation results

Including SoTA badges for this implementation that highlights the performance of the paper, and allows people to compare to alternative methods.

Hi, thanks for your suggestion, the evaluation results have been added to Readme.md

Sorry, should probably explain what this is! This badge links to the public evaluation table at Papers With Code that allows the ML community to compare 2DASL to alternative methods, and highlights the performance of your paper. If you don't wish to merge, feel free to close this! 👍


Refactor: move common functions out of csr controller, into constants or helpers.

There are mainly 2 changes in this PR:
First, the GetClusterName is moved from csr-controller to helpers pkg, along with some const values move to constant pkg.
Second, the Add function added a extraApprovalConditions array, to allow the csr controller to accept and use customized approval conditions.

What I want to achieve, is in the future, we can have more approvalConditions defined and implementated in their our pkg(for example, flightctl approve stays in the flightctl pkg with other flight logic code),  when we add new approval condition, the csr controller don't need to change much.

/assign @zhujian7

/lgtm

/approve


Fix semver id

Follow-up to #650. Corrects the mistake of wrong semver id.
For the future, I think the id should not exist in the ron file and instead should be taken from the file name, letting us avoid these kinds of mistakes.

For the future, I think the id should not exist in the ron file and instead should be taken from the file name, letting us avoid these kinds of mistakes.

Seems reasonable. I'd merge a PR for that, if you or someone else would be open to making one.

I'd merge a PR for that, if you or someone else would be open to making one.

I would probably get to it, but please create an issue so that we don't lose track of it.

Opened #735.
In general, if you feel something like this should have an issue, feel free to just open one. I'm happy to open them as well, and I'm also happy to rely on your judgment when something deserves an issue and your description of the situation.


Documentation lacking which sensors are supported

Your examples talk only of the accelerometer and the gyroscope. But the code has the magnometer which I assume is the compass (correct?).
What else is supported?
IOS has the following sensors listed (for different versions)

Proximity sensor
Ambient light sensor (not in 3G)
Camera
Accelerometer
Compass aka Magnetometer or Magnetic Field Sensor (After 3GS)
Gyroscope (Since 4)

Android phones have some or all of the above and some also support:

Thermometer aka Ambient Temperature Sensor
Heart rate
Pressure
Relative humidity.

Are any/all of these supported?
If you answer here I will be glad to suggest a pull request to the README.MD that would clarify this.
Thank you.

We suppor Accelerometer, Gyroscope, Magnetometer as listed on our website: index view lists them and so the API documentation as well.
The Apple documentation says about Magnetometer

Magnetometer data, indicating the device's orientation relative to Earth's magnetic field.

So this is basically what you get, see their docs.
Maybe a link to our website should be more prominently placed in the readme, to prevent confusions like this.
To the other sensors: We try to have a strict policy that only sensors available on both platforms are to be included here, but if you would like to tackle one of them with one support for one platform, we could think about making it a similar project with a similar API under this org.


Create scaffolds for Signed Zone Factory

Motivation
This PR is laying the groundwork for a Factory to create Signed Zones (SIP-7)

Solution

Codecov Report
Base: 65.21% // Head: 0.00% // Decreases project coverage by -65.22% :warning:

Coverage data is based on head (fe1ecc6) compared to base (024dcc5).
Patch has no changes to coverable lines.

:exclamation: Current head fe1ecc6 differs from pull request most recent head 2604b24. Consider uploading reports for the commit 2604b24 to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                  @@
##           ryan/signed-zone    #900       +/-   ##
====================================================
- Coverage             65.21%   0.00%   -65.22%
====================================================
  Files                   108      21       -87
  Lines                  4488    1229     -3259
  Branches                572     219      -353
====================================================
- Hits                   2927       0     -2927
+ Misses                 1537    1229      -308
+ Partials                 24       0       -24

Flag
Coverage Δ

foundry
?

production
?

reference
0.00% <ø> (-99.60%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Replaced with Controller #963