not combinator

Implements a negative lookahead combinator as described in #51.
I started with it called notFollowedBy, but most of my uses look something like many(not(something) *> any) and having notFollowedBy(something) *> any felt confusing.
This could also yield a subtraction combinator (#59) via not(right) *> left if we want one.

This is great, thank you!

I wonder if we should document that you can run into trouble with e.g.:
many(not(something))

Since not doesn’t advance the cursor, it can infinite loop. Alternatively, maybe many should not repeat at the same index.
Any thoughts?

That’s a good catch.
Poked around at making many (and therefore also some) fail if they don’t consume any input. I’m not convinced it’s the cleanest approach, so I may come take a second look at it, but wanted to get it up here for others’ eyes in the meantime.

Ok, coming back for a second ponder: the current approach is sitting alright with me. The only hesitation I have is wondering if an error is the correct choice. That is, I could see an argument that some(not(x)) should match once then bail (that is, it would effectively produce [()]). But that feels like it would be uglier to implement, and I’m not convinced there’s a real reason for that behavior above this one.

:+1: Thanks @bencochran. This is looking really good.

Awesome, thank you!


Setup branch

added configuration files for rubocop
added the 'Person' class
added the 'Student' class
added the 'Teacher' class

Thank you.


PushNotification is not defined

/*
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
 * to you under the Apache License, Version 2.0 (the
 * "License"); you may not use this file except in compliance
 * with the License.  You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing,
 * software distributed under the License is distributed on an
 * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 * KIND, either express or implied.  See the License for the
 * specific language governing permissions and limitations
 * under the License.
 */
var app = {
    // Application Constructor
    initialize: function() {
        this.bindEvents();
    },
    // Bind Event Listeners
    //
    // Bind any events that are required on startup. Common events are:
    // 'load', 'deviceready', 'offline', and 'online'.
    bindEvents: function() {
        document.addEventListener('deviceready', this.onDeviceReady, false);
    },
    // deviceready Event Handler
    //
    // The scope of 'this' is the event. In order to call the 'receivedEvent'
    // function, we must explicitly call 'app.receivedEvent(...);'
    onDeviceReady : function() {
        try
        {
            var push = PushNotification.init({
                "android" : {
                    "senderID" : "..."
                },
                "ios": {},
                "windows": {}
            });

            push.on('registration', function(data) {
                document.getElementById("nombre").innerHTML = data.registrationId;
            });

            push.on('notification', function(data) {
                var cards = document.getElementById("cards");
                var push = '
' +
                      '
' +
                      '
' +
                      '
' +
                      '      ' + data.title + '' +
                      '
' + data.message + '
' +
                      '
' +
                      '
' +
                      '
' +
                      '
';
                cards.innerHTML += push;
            });

            push.on('error', function(e) {
                console.log("push error");
            });
        }
        catch (e)
        {
            console.log(e.message);
        }
    }
};

    <feature name="PushNotification">
        <param name="android-package" value="com.adobe.phonegap.push.PushPlugin" />
    </feature>

I'm getting the same error as well. I guess there was an update and now this error shows up.

Hi,
I solved my issue by moving the push notif codes from my controller to inside of ionic.platform.ready. That was my case but i see that you are using it correcty since you trigger push events within the body of device ready function. @JonattanV
Maybe that might help you to figure out where the actual problem is.
@JonattanV

@JonattanV re-open if you are still having issues.


[FEATURE] Support request body without pydantic

Thank you very much for developing and maintaining FastAPI, it's great 🙂
Is your feature request related to a problem
I tried to create a POST route with username: str and password: str parameters in the function signature. I was expecting FastAPI to search for username and password in the request body (since I used @app.post), but instead it gets them from the URL, as query parameters. It seems it only works when the parameter is a Pydantic model, not a builtin type.
The solution you would like
With
@app.post("/route/")
def my_route(username: str, password: str):
    ...

Accept username and password as fields of the request body, not as query parameters.
Describe alternatives you've considered
Use Pydantic models. It works fine, it's just a bit less straight-forward.
class LoginForm(BaseModel):
    username: str
    password: str

@app.post("/route/")
def my_route(login_data: LoginForm):
    ...

It could also be emphasized in the docs (https://fastapi.tiangolo.com/tutorial/body/) that it will not work with built-in types, only with Pydantic models.
Additional context
I'm not sure my feature request makes sense: generally speaking, if POST requests can also use query parameters in the URL, then it's impossible to distinguish the ones that should be in the request body and the ones that appear in the URL as query parameters. It means it would not be possible to build the openapi.json I guess. In that case, please close this as invalid 🙂

Thanks @nsidnev for your help here! :nerd_face: :cake:
Thanks @pawamoy for reporting back and closing the issue :taco: :rocket:


Pull requests for repository with git-lfs fail with 'batch request: missing protocol: ""'

Description
Dear Gitea team,
I have carefully read through related issues regarding git-lfs. I cannot figure out how to make it work on my gitea instance. I tried  git config lfs..locksverify false in the repository dir, but no change.
Thank you in advance for your valuable time!
Error
Creating a pull request in a git-lfs repository fails with:
NewPullRequest, Push: team/repo-for-project:branch team/repo-for-project:refs/pull/144/head push failed: exit status 1 - Remote "/home/git/gitea-repositories/team/repo-for-project.git" does not support the Git LFS locking API. Consider disabling it with:
  $ git config lfs..locksverify false
batch request: missing protocol: ""

Git-LFS
git-lfs/3.4.1 (GitHub; linux amd64; go 1.21.1)
git version 2.43.0

LocalWorkingDir=
LocalGitDir=
LocalGitStorageDir=
LocalMediaDir=lfs/objects
LocalReferenceDirs=
TempDir=lfs/tmp
ConcurrentTransfers=8
TusTransfers=false
BasicTransfersOnly=false
SkipDownloadErrors=false
FetchRecentAlways=false
FetchRecentRefsDays=7
FetchRecentCommitsDays=0
FetchRecentRefsIncludeRemotes=true
PruneOffsetDays=3
PruneVerifyRemoteAlways=false
PruneRemoteName=origin
LfsStorageDir=lfs
AccessDownload=none
AccessUpload=none
DownloadTransfers=basic,lfs-standalone-file,ssh
UploadTransfers=basic,lfs-standalone-file,ssh
GIT_EXEC_PATH=/usr/lib/git-core
git config filter.lfs.process = "git-lfs filter-process"
git config filter.lfs.smudge = "git-lfs smudge -- %f"
git config filter.lfs.clean = "git-lfs clean -- %f"

Git
git version 2.43.0

LocalWorkingDir=
LocalGitDir=
LocalGitStorageDir=
LocalMediaDir=lfs/objects
LocalReferenceDirs=
TempDir=lfs/tmp
ConcurrentTransfers=8
TusTransfers=false
BasicTransfersOnly=false
SkipDownloadErrors=false
FetchRecentAlways=false
FetchRecentRefsDays=7
FetchRecentCommitsDays=0
FetchRecentRefsIncludeRemotes=true
PruneOffsetDays=3
PruneVerifyRemoteAlways=false
PruneRemoteName=origin
LfsStorageDir=lfs
AccessDownload=none
AccessUpload=none
DownloadTransfers=basic,lfs-standalone-file,ssh
UploadTransfers=basic,lfs-standalone-file,ssh
GIT_EXEC_PATH=/usr/lib/git-core
git config filter.lfs.process = "git-lfs filter-process"
git config filter.lfs.smudge = "git-lfs smudge -- %f"
git config filter.lfs.clean = "git-lfs clean -- %f"

Setup

gitea as systemd service
nginx frontend proxy

Gitea Version
1.21.4
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
git version 2.43.0
Operating System
ubuntu 22.04 LTS
How are you running Gitea?
Gitea is run as systemd service.
Database
MySQL/MariaDB

This will be fixed in 1.21.5 relesed. PR details can be found here: https://github.com/go-gitea/gitea/pull/28851

@techknowlogick thank you for you answer 👍

@Voscha in #23765 - an old issue - you mentioned, that you solved the error by removing old git lfs hooks from the respository.
Would you be so kind to share the details of your solution / guide to do it? I am currently somehow stuck in solving it for my repo. Maybe we can help others as well.
Thank you :)

Hi, The solution is mentioned in the comments. If your repository have an hooks subdir, delete the files in that dir. I hope, this helps you. -------- Ursprüngliche Nachricht --------Von: Werner @.>Datum: Mo., 5. Feb. 2024, 15:24An: go-gitea/gitea @.>Cc: Voscha @.>, Mention @.>Betreff: Re: [go-gitea/gitea] Pull requests for repository with git-lfs fail with 'batch request: missing protocol: ""' (Issue #28947)
@Voscha in #23765 - an old issue - you mentioned, that you solved the error by removing old git lfs hooks from the respository.
Would you be so kind to share the details of your solution / guide to do it? I am currently somehow stuck in solving it for my repo. Maybe we can help others as well.
Thank you :)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

@Voscha Thanks for your answer. I was somehow bling / did not think that is was so simple. Was able to fix that.


Add CI for Python 3.10

Codecov Report

Merging #10 (ee96a55) into master (cb315e9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #10   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            8         8
  Lines          721       721
  Branches       131       131
=========================================
  Hits           721       721

Flag
Coverage Δ

3.9
100.00% <ø> (ø)

ubuntu-latest
100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


how to disable rounded windows?

Somewhere I upgraded JWM (I think 3 years ago) under FreeBSD, and since then I have rounded corner windows. I really don't like that, but lived with it. I thought now to ask if there is actually a way to switch that off so I can get rectangular windows again.

copy system.jwmrc to your home folder, rename to .jwmrc edit < WindowStyle> tag and you good to go!

<WindowStyle>

        Source-9:bold
        <Width>1</Width>
        <Height>40</Height>
        <Corner>20</Corner> <--set corner to 0

I was still on JWM 2.2.2 (latest in FreeBSD 10.1's ports system) which I don't think had the  property. I manually upgraded my JWM to 2.3.1 from Joe's website, and then set the  to 0. Many thanks for the help.
I see much of of the .jmwrc file format has changed... busy working through that now - based on the default system version.

@graemeg
You can use the xsltproc file Joe includes
cp ~/.jwmrc ~/.jwmrc.old
xsltproc jwm-2.3.xslt ~/.jwmrc.old > ~/.jwmrc

@Israel- many thanks for that tip, I didn't know about that.

no problem @graemeg I am not sure if it updates it to remove the now obsolete (TaskListStyle PagerStyle, etc...)  so if not...  check here:
http://www.joewing.net/projects/jwm/release-2.3.shtml
This lists the major changes... but you may already have seen that


allExcept: inCallExpression should also include object instantiation

Currently when setting the inCallExpression exception for requirePaddingNewLinesAfterBlocks object instantiation is not included in that exception. In the end it's the same scenario. So, when setting the inCallExpression exception the following should also be valid.
//should be valid
new MyClass(
    'param1',
    function() {
        //some code
    }
);

//is already valid
myFunction(
    'param1',
    function() {
        //some code
    }
);

@matoilic Do you want to do the fix as well? Also new MyClass is a NewExpression not a CallExpression so we would need to add another option (I guess inNewExpression) for that.

I've added a new option inNewExpressions as suggested and adapted the documentation.

LGTM (except one nit in doc)

Thank you! It was easy isn't it :)


Creating Analytic Phantom

Hello,
I'm interested in creating an analytic phantom and was wondering if there is any documentation available for reference. While I understand how to shift the phantom in the xy direction, I'm curious if there are techniques to modify its length along the z-axis. Specifically, I'm interested in adjusting the phantom's appearance across multiple slices, allowing certain aspects to appear or disappear as needed. Also is there any way to create more complex shapes from equations or is the analytic phantom limited to elliptical shapes.

Hi,

While I understand how to shift the phantom in the xy direction, I'm curious if there are techniques to modify its length along the z-axis. Yes, you can change length in the z-axis by modifying the third value of object.half_axes(1,:) = [108.000000 108.000000 50.000000]; in phantom file like https://github.com/xcist/main/blob/master/gecatsim/phantom/W20.ppm
Specifically, I'm interested in adjusting the phantom's appearance across multiple slices, allowing certain aspects to appear or disappear as needed. I am not sure about this question. Did you mean change X/Y size at different z positions? If yes, you can achieve this by using multiple analytic objects with different offset/size, I guess.
Also is there any way to create more complex shapes from equations or is the analytic phantom limited to elliptical shapes. So far we only support limited number of shapes including elliptical shapes. If you want to use complex shapes, I would suggest you to use voxelized or NCAT phantoms.

Thank you for the quick response. I just had another question regarding which shapes are supported by the software and if there is any documentation I can look towards to better understand how to implement these other shapes.

It seems you have deleted one of your comments about if there are other shapes that are supported by xcist. I would still answer it here for future reference.
We do have plans to support the following shapes in analytic phantom:
Ellipsoid, Cylinder, Torus, Cone, Hyperboloid2, Hyperboloid1, VesselSeg, Box
, which can be specified in object.shape by an integer, e.g., 1 (for ellipsoid) or 2 (for cylinder). However, not all shapes are implemented as of now and you may see some shapes not working.

Just to clarify, with all the example analytic phantoms such as W20.ppm contained in the repository having object.shape = 0 this means that every analytic object is being defined as an ellipsoid? Looking towards the method Phantom_Analytic_BoundObjects in Phantom_Analytic.py I am assuming that the typ variable refers to the object.shape. Does this mean that the program only supports up to index 2 for the object.shape?

I made a typo in the previous post. It should be object.type not object.shape. object.shape Used only for the torus object to define the thickness relative to the radius of curvature. Sorry for the confusion


Translate alpha state description

Translate content/en/docs/templates/feature-state-alpha.txt into content/ja/docs/templates/feature-state-alpha.txt for #10823.

/lgtm
/approve


implement auto idle

use traffic logs from routers to determine automatic idleing for non production projects

Hi @Schnitzel
I'd like to clarify a few things with this issue if I may?  I've listed a some questions below.

Is the automatic idling detection to be based on logs ingested into ElasticSearch that show no activity for a certain duration?
Would this lack of activity be made available as a custom metric that a Horizontal Pod Autoscaler (HPA) could use this to trigger a Deployment scale in event?
Do you want the reverse of this to also be true, that certain activity thresholds in the logs would trigger a scale out event?

If HPA's and custom metrics are to be used then this is something that requires the autoscaling/v2beta1 API, which became available in Kubernetes 1.8.  Currently OpenShift 3.6 uses Kubernetes 1.7.  Although I imagine that OpenShift 3.7 will have Kubernetes 1.8.

Is the automatic idling detection to be based on logs ingested into ElasticSearch that show no activity for a certain duration?

that was my initial thought as well yes.

Would this lack of activity be made available as a custom metric that a Horizontal Pod Autoscaler (HPA) could use this to trigger a Deployment scale in event?

yes, but I would rather use https://docs.openshift.com/container-platform/3.6/admin_guide/idling_applications.html which already does that for you fully automatically.

Do you want the reverse of this to also be true, that certain activity thresholds in the logs would trigger a scale out event?

That should also automatically be handled by OpenShift https://docs.openshift.com/container-platform/3.6/admin_guide/idling_applications.html#idling-applications-unidling-applications
So I think we don't need to depend on Kubernetes 1.8 with this?

@Schnitzel thanks for the info.  It certainly looks like OpenShift have this covered :-)  If you ever want to roll a bespoke solution for other metric types in the future then custom metrics and HPA would probably be a good fit.  But unnecessary in this case.

most functionaility is done, now we need a system to exclude specific lagoon projects from idleing


Added GCD implementation in python and C++

What a great code :smile: ! Just a little tip, its good to always put a description on your PRs to make more understandable.
Thank you for contributing! :rocket:

What a great code 😄 ! Just a little tip, its good to always put a description on your PRs to make more understandable.
Thank you for contributing! 🚀

Thank you! I'll keep that in mind.


Query Analyzer : "all" to be added to list of stop words

For instance "Search for all imagery" is incorrectly processed because "for all imagery" is understood as "for all" (location) and "imagery" (keyword).

Adding "all" to dictionary is not sufficient : "Search for all imagery" then works but "Search for all satellite imagery" does not


Create Translator

Title and Issue number

Title :
Issue No. :#219
Code Stack : HTML,CSS, JavaScript
Close #219

Video (mandatory)

https://github.com/apu52/METAVERSE/assets/98397984/69f27a5f-4577-4995-bd34-a43fec1e4014

Checklist:

[X] I have mentioned the issue number in my Pull Request.
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have created a helpful and easy to understand README.md
[X] I have updated the projectData.json file for my contribution
[X] I have added the img of my project in the assets/img section

Additional context (Mandatory )
Are you contributing under any Open-source programme?

kwoc 2023

@Souvik34 Please do not make a PR until and unless you are assigned the particular issue.

@Souvik34 Please try to make a new PR on the same issue #219 after making a new branch in your fork.


[12.x] check database "existence" instead of "count"

an "existence" query is consistently more performant than a "count" query on a database, partially due to the fact the "existence" query can stop searching once it finds a single result, while "count" must ALWAYS search the entire table.
by creating a getExistence() method on our verifier, we can then use this in our "unique" validation rule for a little performance bump.

I think I'd like to avoid the contract breaking change if possible unless this is causing serious performance issues in production.


CPER Specification wrong link in cper-records document

the CPER cpecification is mentioned twice (at least) in https://github.com/openbmc/docs/blob/master/designs/cper-records.md
yet the link actually points to Arm developer site where SBMR documentation can be found (https://developer.arm.com/documentation/den0069/latest/), not the CPER SPEC.
The correct link(s) should be to: https://uefi.org/specs/UEFI/2.10_A/Apx_N_Common_Platform_Error_Record.html

@tpaz can you please send a Gerrit review to fix the bad link?  There was quite a bit of shifting on that doc where some sections pointed to SBMR, some to UEFI, and clearly this one got messed up.


[WIP] Update to pwasm-std 0.11

Updates the entire crate to pwasm-std version 0.11 (later 0.12).
Depends on

Update to pwasm-test: https://github.com/paritytech/pwasm-test/pull/35
Update to pwasm-ethereum: https://github.com/paritytech/pwasm-ethereum/pull/16
Update to pwasm-std: https://github.com/paritytech/pwasm-std/pull/79

Let's update to std 0.12 ok?

@NikVolf Let's update to std 0.12 ok?

Yeah I will do that for all PRs depending on the pwasm-std version 0.12 update.


Add rst module

Uses sphinx-mode and adds a few common bindings

I looked for a few rst related plugins here
Does sphinx-mode provide the "compilation" that sphinx-frontend seems to provide ? Do you think that would be a good addition ?

Personally I have no use for any of these compilation commands since I've put the common ones that I use in a makefile and just invoke them via M-x compile. I don't have anything against them in case someone else wants to add them however.
I mostly use sphinx-mode because of the better syntax highlighting.

Oh, forgot to mention. Perhaps this module's packages.el is missing a:
(when (featurep! :lang org)
  (package! ox-rst))

Otherwise, lang/org/packages.el is missing a

I went for this.

I assumed sphinx-mode depended on sphinx, but I'll take your response as though it doesn't.
Yup I use without having the Sphinx binary in my path. But perhaps there are some use cases which require it.
On Nov 10, 2019, 1:26 AM +0900, Henrik Lissner<EMAIL_ADDRESS>wrote:
@hlissner commented on this pull request.
In modules/lang/rst/config.el:

@@ -0,0 +1,16 @@
+(use-package! sphinx-mode

:init
(add-hook! 'rst-mode-hook #'sphinx-mode))
I assumed sphinx-mode depended on sphinx, but I'll take your response as though it doesn't.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

@hlissner should be ready now

Looks good to me! Thanks again for your help!


Is there an online test tool to test conditionals?

That would be really helpful. Or even a "test" button in the task UI.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3f151218-9a11-0078-e038-f96198a76143
Version Independent ID: 09c4d032-62f3-d97c-79d7-6fbfd89910e9
Content: Conditional task expressions
Content Source: docs/build-release/concepts/process/conditions.md
Service: unspecified
GitHub Login: @erickson-doug
Microsoft Alias: alewis

You can use postman or similar tool to post to this api
https://.visualstudio.com/_apis/distributedtask/inputvalidation
with this body
{"inputs":{"expression":{"type":"expression","value":"VALUE"}}}

I'm receiving a page not found when calling the api.

Chris's response was missing escape characters. Also, the domain name has changed:
POST https://dev.azure.com/{your_organzation_name}/_apis/distributedtask/inputvalidation
Body:
{
  "inputs": {
    "expression": {
      "type": "expression",
      "value": "{your expression to test}"
    }
  }
}


[Question]  How to setup chessli  for testing and install from local directory

Newish coder, how to setup chessli for tinkering purposes and also how to test tinkered features without breaking the pip install. Thanks for this awesome tool!

In order to develop on chessli, the best workflow is to clone this repository and then pip install it from there instead of installing it from pipy.

Clone the repository: https://github.com/pwenker/chessli.git
Move into the folder and install it: cd chessli && pip install .
Perform whatever changes you want to do.
Go back into the chessli folder and do pip install .

Notes:

Unfortunately, I don't know of any more straightforward way, since I use pyproject.toml and poetry instead of setup.py. For the latter one, it is possible to install via pip install -e . so that you don't need to reinstall chessli after every single change that you want to test. There is an open issue: https://github.com/python-poetry/poetry/issues/34
I don't know how the above steps need to be adapted if you are a windows user.

Feel free to comment below, in case it works, or also if you encounter problems or have further questions :)

@ExtremeCoolDude: Did it work for you?

Got stuck in the first step tbh, I think its too basic problem but can't figure it out via google-fu.
ERROR: File "setup.py" not found. Directory cannot be installed in editable mode: /home/da/chessli/chessli

Awesome. Happy coding :)


Add highlight for WinSeparator

Nvim is deprecating VertSplit and moving to WinSeparator for borders in 0.10. By default, WinSeparator links to normal which does not look great for most colorschemes.

Thanks for the issue. Do you have some more info on the deprecation or maybe an example of where you're seeing wrong highlights?
I've not tested cyberdream with 0.10 yet but I can confirm that the WinSeperator group is set.

Thanks for the issue. Do you have some more info on the deprecation or maybe an example of where you're seeing wrong highlights?
I've not tested cyberdream with 0.10 yet but I can confirm that the WinSeperator group is set.

Ah, there's a typo in your file. It's WinSeparator, not WinSeperator.

Well, that's a bit embarrassing! I've fixed the typo in the latest commit. Thanks again!

windows separation is non-existent
even after setting up WinSeparator = { fg = "#50505e", bg = "" }

@cybergaz there's an override for this in the config - hide_fillchars that sets these to " " when true.
https://github.com/scottmckendry/cyberdream.nvim/blob/d777f1bfb0e6e1d74b3f243d8e4999b6b931ae19/lua/cyberdream/theme.lua#L18C4-L29C9
Setting this to false will change them back to the default.

thx... that solved it
but may i ask what's the point of these hide fillchars??

Preference. To me, fill chars are extra visual clutter. But not everyone sees it that way, which is why I added the option 😉


4.0.0?

I see 4.0.0 is released on NPM, but there's nothing on the releases page or in the changelog.
What changed in this new major version?

Done!

Thanks


Info added to symptoms and causes

Issue #10 completed

[x] This change requires a documentation update

Checklist:

[x] I have made this from my own
[ ] I have taken help from some online resourses
[x] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Kindly tick all the checkboxes that requires.
[x]

Kindly tick all the checkboxes that requires. [x]

check

Thanks for contributing here


Continue the timer when computer wakes up from sleep

After my laptop goes to sleep, I open the browser.
The timer does not start automatically after that.
It just shows how much time was left before going to sleep.

Thanks for the report. I will try to replicate this issue myself. I should be able to fix it quickly.

Hi, I am still experiencing this issue on mac. Version 34


New collections will fail if context left as is_view at end of unit test

So I've noticed a bit of a footgun with our current test patterns relating to unit tests.
Previously collection types would not write themselves back to state as this had to be handled manually, so the unit test:
 testing_env!(VMContextBuilder::new().is_view(true).build());
 let contract = MyContract::new();
 assert_eq!(None, contract.some_method(...));

Would work totally fine because even though view context is true, the initialization never actually wrote anything to state (even though it would when sending a tx in wasm).
The issue is now we have collections that will write their values to store on drop, so if MyContract has one of these:
#[near_bindgen]
#[derive(BorshDeserialize, BorshSerialize, Default)]
pub struct StatusMessage

{ some_value: Lazy<u8>, }

...
    #[init]
    pub fn new() -> Self {
        Self

         { unique_values: Lazy::new(b"v", 8), }

     }

then the initialized value with MyContract::new will make the state modification but since the contract is not dropped (like it would be in a wasm env) then the value will actually be written at the end of the test scope. This is an issue if a developer left the mocked env to read-only like in the case above.
The issue is that the initialization function doesn't write to storage when it should and that writes will all happen at the end of the function, which doesn't match the flow of the actual contract execution. This is the same also for &mut functions, since with these collections now the values won't be written to state immediately.
A possible solution to this is to add some codegen for init and mutable functions, only for non-wasm32 environments, that will serialize this state, write it to state with env::state_write in the case of init functions, then deserialize it into the type that is returned or replace the &mut self. This is a bit of a janky pattern but it will change the code to be a closer reflection of what actually happens in wasm/on-chain.
Very much open to alternatives though.

Also noticed there is a bit of a consideration with this same pattern happening with using these new collections as statics. With something like thread_local!, the logic is run on every method call to initialize the static, but the value is never dropped before the runtime exits. Experimented with this a bit last night https://github.com/austinabell/static_lookup_map/blob/main/src/lib.rs and just switched to using the old LookupMap, but if switched to new, there is a requirement to manually flush the collections after each operation.
This is also the same type of foot gun that would be very hard to debug if you don't understand what is happening internally with these. I'm not quite sure if there is a better alternative if someone wants to do this pattern, but if there is not, we should at least document this interaction somewhere.

Here is a full reproducible example:
use near_sdk::{log, near};

#[near(contract_state)]
pub struct Contract {
    greeting: near_sdk::store::LookupMap<String, String>,
}

impl Default for Contract {
    fn default() -> Self {
        Self {
            greeting: near_sdk::store::LookupMap::new(b"g"),
        }
    }
}

#[near]
impl Contract {
    pub fn get_greeting(&self) -> String {
        self.greeting.get("greeting").unwrap_or(&"NOT SET YET".to_string()).clone()
    }

    pub fn set_greeting(&mut self, greeting: String) {
        log!("Saving greeting: {greeting}");
        self.greeting.insert("greeting".to_string(), greeting);
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn set_then_get_greeting() {
        let mut contract = Contract::default();
        contract.set_greeting("howdy".to_string());
        // Commenting out this line "helps", but it does not enforce the View context limitations to the `get_greeting` function
        near_sdk::testing_env!(near_sdk::test_utils::VMContextBuilder::new().is_view(true).build());
        // If you add `contract.greeting.flush()` before the `testing_env!` line, the test will also run fine.
        // `drop(contract)` is another way to trigger all the `.flush()` methods.
        assert_eq!(contract.get_greeting(), "howdy");
    }
}

Run:
cargo test

Isn't using a manual flush a valid approach? We could document the need to flush state manually in tests. I think this approach is simple and keeps the code reflective of the actual contract behavior.
Just a proposal, maybe a more complex approach is the way to go.

That will require flushing all the individual collections (e.g. see this contract, I don't want to flush 10+ fields manually).
We need to trigger Drop behavior on the Contract somehow to call Drop on all the underlying collections to flush them all. Maybe we need to change the structure of unit-tests or testing_env! logic.

I get what you are saying. What about using scoped blocks, when getting out of scope the contract triggers the Drop behavior. Then you can switch to view context and reload the contract to make the assertions, it would look something like this on the example you wrote:
#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn set_then_get_greeting() {
        {
            let mut contract = Contract::default();
            contract.set_greeting("howdy".to_string());
        }

         near_sdk::testing_env!(near_sdk::test_utils::VMContextBuilder::new().is_view(true).build());

        let contract = Contract::default();
        assert_eq!(contract.get_greeting(), "howdy");
    }
}

This passes the test:

@renzobanegass Scoped blocks are nice, but users might get confused about the error they would be getting since it looks like get_greeting is broken and tries to write something to the storage, which is not the case.
Any ideas on how to make this ergonomic and clear? We may think in several directions: improving the error message, make the intuitive code work as expected, make the intuitive code fail with a clear message on how to properly structure the tests.

I'm not sure about modifying testing_env as it has other use cases. What about creating a new macro for the tests that wraps testing_env and drops the contract before setting the environment? I can't come up with a way to implement it in an intuitive way though.


Not working with react-native-elements: fontFamily "space-mono" is not a system font and has not been loaded through Font.loadAsync.

I'm seeing this error on my Android emulator upon using react-native-snackbar-component, no problem when viewing my application on the web:
fontFamily "space-mono" is not a system font and has not been loaded through Font.loadAsync.

- If you intended to use a system font, make sure you typed the name correctly and that it is supported by your device operating system.
- If this is a custom font, be sure to load it with Font.loadAsync.
- node_modules\react-native\Libraries\YellowBox\YellowBox.js:59:8 in error
- node_modules\expo\build\environment\muteWarnings.fx.js:27:24 in error
- ... 33 more stack frames from framework internals

It seems react-native-snackbar-component have a conflict with react-native-elements' <Header /> component. The error is gone upon reinstalling react-native-elements alone but came back upon installing react-native-snackbar-component.

It's literally an issue while you install react-native-snackbar-component with Expo. I'm using Yarn, so I'd solved the problem by running these after installing react-native-snackbar-component:
yarn
expo r -c


Multi selection qwerks

Using this custom element with shadow dom enabled on chrome and with multiselections

selectedItems doesn't always reflect what's actually selected, specifically when i hit the select all checkbox at the top it zero's out the base array.
when i click on the checkbox next to a row to individually select the row it doesn't stay selected, deselects so fast it has the appearance that nothing is happening.

<iron-data-table multi-selection selection-enabled items="[[items]]" selected-items="{{selectedItems}}">
          <template is="row-detail">

[[item.foo]]

          </template>
          <data-table-column name="Date" sort-by="timestamp">
            <template>[[millisToDate(item.timestamp)]]</template>
          </data-table-column>
          <data-table-column name="Weight">
            <template>[[item.bar]]</template>
          </data-table-column>
          <data-table-column name flex="1" width="50px" align-right>
            <template>
              <paper-checkbox checked="{{expanded}}">Details</paper-checkbox>
            </template>
          </data-table-column>
</iron-data-table>

Looks like you've got a fix coming down the pipe for shadow dom clicking, and select-all is inverted for big array sizes so this issue was created prematurely. Ignore this :)


Can I use transitionTo outside of a reactjs class?

Hello,
I want to use transitionTo in a redux middleware function which is outside of a reactjs class. Does react-router allow this?
I am using react-router version 0.13.3

See
https://github.com/rackt/react-router/issues/2089

thanks @Dodelkin


Additional map data (e.g. tetonic plate boundaries)

We're currently thinking about adding additional background map data in our seismological project (obspy/obspy#921). One thing would be tectonic plate boundaries. As we currently use basemap for map plots we could instead add some functionality that might be useful to a wider audience right here at basemap.
Any thoughts?

Seems like it shouldn't be a part of Basemap itself, but a separate package (or part of obspy) that can easily be installed and used. There are an infinite number of maps. I wouldn't want to see them all, or even a fraction, in core basemap...

Alright, thanks for the feedback, we'll be adding it at obspy then. Closing..


Sync Events and Classes with external calendars

This user feedback driven enhancement request is to allow the ability to sync student events and classes with external calendars.

This issue is being closed due to platform migration and may be revisited at a later date.


How can I put a new key after init in  metricSet?

I make the simple xml spring config like this:
<!-- Creates a MetricRegistry bean -->
    <metrics:metric-registry id="metricRegistry" />

    <!-- Creates a HealthCheckRegistry bean (Optional) -->
    <metrics:health-check-registry id="health" />

    <!-- Registers BeanPostProcessors with Spring which proxy beans and capture metrics -->
    <!-- Include this once per context (once in the parent context and in any subcontexts) -->
    <metrics:annotation-driven metric-registry="metricRegistry" />

    <!-- Example reporter definiton. Supported reporters include jmx, slf4j, graphite, and others. -->
    <!-- Reporters should be defined only once, preferably in the parent context -->
    <metrics:reporter type="console" metric-registry="metricRegistry" period="5s" />

    <!-- Register metric beans (Optional) -->
    <!-- The metrics in this example require metrics-jvm -->
    <metrics:register metric-registry="metricRegistry">
        <bean metrics:name="jvm.count" id="advices" class="cn.com.servyou.alpha.aop.TheSets" />
    </metrics:register>

register a set class TheSets implements the MetricSet,the class is like this:
public class TheSets implements MetricSet {

    public static Map<String, Metric> metricMap = new LinkedHashMap<String, Metric>();
    public Map<String, Metric> getMetrics() {
        System.out.println("the set class is :" + this);
        System.out.println("set map size is "+ metricMap.size());
        metricMap.put("cc", new Counter());
        return metricMap;
    }

    public static void increase(String key) {
        if (metricMap.get(key) != null) {
            Counter counter1 = (Counter)metricMap.get(key);
            counter1.inc();
        }else {
            Counter counter2 = new Counter();
            counter2.inc();
            metricMap.put(key, counter2);
        }
        System.out.println("invoked map size is "+ metricMap.size());
    }
}

and I invoke the increase method in another class , just like TheSets.increase("cc");.
this works.
but ,when I want to invoke the method with another arg , which like TheSets.increase("dd");. the result is I can't get the counter named with "dd",it seems like the put method on metricMap only works in the getMetrics method.
now I need to put some dynamic keys in the map, how can I make it? @ryantenney
thank you .

I'm afraid that can't be done.  The getMetrics method on a MetricSet is only ever invoked once.  What you need to do is get a reference to the MetricRegistry and then replace the body of the increase method with the code: MetricRegistry.counter(key).inc();.

Thank you. that means I should init my map before getMetrics

it works MetricRegistry.counter(key).inc(); thanks a lot


Roblox stops working after minutes

Every time I have tried to open the roblox player it works until after like 4-5 minutes then it crashes and freezes my screen. It also freezes my cursor and doesn't let me move it.

Theres a solution here: https://github.com/CorkHQ/Cork/issues/37#issuecomment-1783524079
For me, I changed         "channel": "live", to         "channel": "zavatarteam2", in settings.json located in /home/[user]/.var/app/io.github.bugadinho.Corky/config/cork

for some reason i cannot find the "app" folder. And so i cant find the settings.json, can you help me fix it?

try going to your home directory and search for "io.github.bugadinho.Corky"


Admin Table (Settings)

Our Milestone: Admin Settings UI fixes
So Far, our settings page has most of the backend infrastructure set up but we want to match the UI our design team wireframed to make it more intuitive and clean for our admin users.
Your Task:  Work closely with the design on Figma to split our Settings page into tabs for the Account and Liability Waivers. This looks very similar to the Admin Resources tab!

Important Information

The Liability Waivers tab will need to be most updated to have a list of documents on the left and the markdown text editor. Waivers can be edited, deleted, and new docs can be added.
Keep the backend functionality to meet these changes but these should have been already implemented so it's mostly UI changes.

Never hesitate to reach out for help!
Notes

This is very similar to sprint 1, so I recommend referencing them! Several components are shared.

There are plans to fix this in a different ticket!


Rebble: Configurable Pebble style clock, with day, date, steps, battery, sunrise, sunset sidebars

Thanks!


HDDS-7924. Remove non-conflicting transitive-only dependency versions

What changes were proposed in this pull request?

Remove version definitions for transitive dependencies that have no conflict to reduce the amount of work required for using different version of Hadoop.
Ensure consistent version of gRPC by importing BOM
Add exclusions for more transitive dependencies of Ranger

https://issues.apache.org/jira/browse/HDDS-7924
How was this patch tested?
Regular CI:
https://github.com/adoroszlai/hadoop-ozone/actions/runs/4126609410

And thanks @DaveTeng0 for reviewing this as well.


Migrate release_stream_base_url

The current release_stream_base_url of *.openshiftapps.com is a route to a specific cluster behind the VPN.
There is a simpler endpoint that is easier to template for AMD and ARM binaries, which follows the format:
https://amd64.ocp.releases.ci.openshift.org/
https://arm64.ocp.releases.ci.openshift.org/
The REST endpoints are the same. We should migrate to use the new routes.

Sounds good!, some code changes will be required though.


Stream transfer data

Hello dier support. I am working with Clickhouse on nodejs and using special driver recommended on your site.
https://github.com/apla/node-clickhouse
As I can see, the stream transmits only one row per time. Transmit of 1,5 million of rows takes 25 sec.
It would be very good if Stream could receive a bulk of rows per time.
Could you tell me, maybe it is a clickhouse configuration problem, or bad driver?

I don't know if it still relevant to you, but as far as I can see both those clients for node.js that listed on official site have very poor quality. Also they use http interface that's not very fast. So as a result all performance that clickhouse has is lost in client libraries.


[AIRFLOW-2407] Use feature detection for reload()

Use feature detection instead of version detection is a Python porting best practice that avoids a flake8 undefined name error...
flake8 testing of https://github.com/apache/incubator-airflow on Python 3.6.3
$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
./airflow/www/app.py:148:17: F821 undefined name 'reload'
                reload(e)
                ^

Make sure you have checked all steps below.
JIRA

[X] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-2407
In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a JIRA issue.

Description

[X] Here are some details about my PR, including screenshots of any UI changes:
See above.

Tests

[X] My PR adds the following unit tests OR does not need testing for this extremely good reason:
This PR fixes flake8 tests that are currently failing.

Commits

[X] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Documentation

[X] In case of new functionality, my PR adds documentation that describes how to use it.

When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.

Code Quality

[X] Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Looking at the CI, it seems to fail under Python 2.7:
======================================================================
45) ERROR: test_xss_prevention (tests.www.test_views.TestVariableView)
----------------------------------------------------------------------
   Traceback (most recent call last):
    tests/www/test_views.py line 120 in setUp
      app = application.create_app(testing=True)
    airflow/www/app.py line 150 in create_app
      from importlib import reload
   ImportError: cannot import name reload

reload() is a builtin in Python 2 so the only way that it can be an undefined name in Python 2 is if del reload is being executed which I do not see in this repo’s code.

Codecov Report

Merging #3298 into master will increase coverage by 0.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3298      +/-   ##
==========================================
+ Coverage   76.47%   76.85%   +0.38%
==========================================
  Files         203      204       +1
  Lines       15012    15519     +507
==========================================
+ Hits        11480    11927     +447
- Misses       3532     3592      +60

Impacted Files
Coverage Δ

airflow/www/app.py
100% <ø> (ø)
:arrow_up:

airflow/api/common/experimental/mark_tasks.py
68% <0%> (-14.98%)
:arrow_down:

airflow/config_templates/default_celery.py
58.62% <0%> (-9.38%)
:arrow_down:

airflow/utils/state.py
93.33% <0%> (-3.34%)
:arrow_down:

airflow/api/common/experimental/delete_dag.py
82.6% <0%> (-2.58%)
:arrow_down:

airflow/www/views.py
68.94% <0%> (-2.52%)
:arrow_down:

...ample_dags/example_branch_python_dop_operator_3.py
75% <0%> (-1.48%)
:arrow_down:

airflow/settings.py
79.33% <0%> (-1.17%)
:arrow_down:

airflow/www_rbac/views.py
71.57% <0%> (-0.9%)
:arrow_down:

airflow/utils/db.py
33.33% <0%> (-0.54%)
:arrow_down:

... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce2502...2a307f5. Read the comment docs.


Make gulp task names more explicit

Without this change, many "private" gulp task names (created by closure functions) had generic names like "shaders" or "importLint", even though the actual task is specific to a particular module (due to closure parameters):
[19:55:13] Finished 'postProcessesLibrary-importLint' after 13 ms
[19:55:13] Starting 'proceduralTexturesLibrary-importLint'...
[19:55:13] Starting 'shaders'...
[19:55:13] Finished 'shaders' after 10 ms
[19:55:13] Starting 'lint'...
[19:55:13] Finished 'lint' after 20 ms
[19:55:13] Finished 'proceduralTexturesLibrary-importLint' after 31 ms
[19:55:13] Starting 'loaders-importLint'...
[19:55:13] Starting 'shaders'...
[19:55:13] Finished 'shaders' after 2.67 ms
[19:55:13] Starting 'lint'...
[19:55:13] Finished 'lint' after 38 ms
[19:55:13] Finished 'loaders-importLint' after 41 ms
[19:55:13] Starting 'serializers-importLint'...
[19:55:13] Starting 'shaders'...
[19:55:13] Finished 'shaders' after 3.66 ms
[19:55:13] Starting 'lint'...
[19:55:13] Finished 'lint' after 15 ms
[19:55:13] Finished 'serializers-importLint' after 19 ms
[19:55:13] Starting 'gui-importLint'...
[19:55:13] Starting 'shaders'...
[19:55:13] Finished 'shaders' after 7.3 ms
[19:55:13] Starting 'lint'...
[19:55:13] Finished 'lint' after 46 ms
[19:55:13] Finished 'gui-importLint' after 54 ms

Probably to those very familiar with the build process it's clear what is nested within what, but I was finding it tricky when diagnosing a build failure that happened in something like "buildes6" without any elaboration. With this change, the task names are explicit:
[19:52:36] Starting 'postProcessesLibrary-importLint'...
[19:52:36] Starting 'postProcessesLibrary-importLint:shaders'...
[19:52:36] Finished 'postProcessesLibrary-importLint:shaders' after 4.6 ms
[19:52:36] Starting 'postProcessesLibrary-importLint:lint'...
[19:52:36] Finished 'postProcessesLibrary-importLint:lint' after 7.23 ms
[19:52:36] Finished 'postProcessesLibrary-importLint' after 13 ms
[19:52:36] Starting 'proceduralTexturesLibrary-importLint'...
[19:52:36] Starting 'proceduralTexturesLibrary-importLint:shaders'...
[19:52:36] Finished 'proceduralTexturesLibrary-importLint:shaders' after 9.1 ms
[19:52:36] Starting 'proceduralTexturesLibrary-importLint:lint'...
[19:52:36] Finished 'proceduralTexturesLibrary-importLint:lint' after 20 ms
[19:52:36] Finished 'proceduralTexturesLibrary-importLint' after 29 ms
[19:52:36] Starting 'loaders-importLint'...
[19:52:36] Starting 'loaders-importLint:shaders'...
[19:52:36] Finished 'loaders-importLint:shaders' after 2.93 ms
[19:52:36] Starting 'loaders-importLint:lint'...
[19:52:36] Finished 'loaders-importLint:lint' after 37 ms
[19:52:36] Finished 'loaders-importLint' after 40 ms
[19:52:36] Starting 'serializers-importLint'...
[19:52:36] Starting 'serializers-importLint:shaders'...
[19:52:36] Finished 'serializers-importLint:shaders' after 3.24 ms
[19:52:36] Starting 'serializers-importLint:lint'...
[19:52:36] Finished 'serializers-importLint:lint' after 15 ms
[19:52:36] Finished 'serializers-importLint' after 19 ms
[19:52:36] Starting 'gui-importLint'...
[19:52:36] Starting 'gui-importLint:shaders'...
[19:52:36] Finished 'gui-importLint:shaders' after 7.35 ms
[19:52:36] Starting 'gui-importLint:lint'...
[19:52:36] Finished 'gui-importLint:lint' after 40 ms
[19:52:36] Finished 'gui-importLint' after 47 ms

This made everything way more clear to me (and doesn't seem to add much complexity), but of course y'all might find it somewhat frivolous?

I like it but somehow it broke the compilation :)

Weird. Will investigate.
On Mon, May 3, 2021, 8:11 AM David Catuhe @.***> wrote:

I like it but somehow it broke the compilation :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/BabylonJS/Babylon.js/pull/10293#issuecomment-831324253,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACEKCYX5UPO4UN4EZGGFALTL24JZANCNFSM43656TUQ
.

Should be fixed now, sorry about that!

Thanks a lot for your help!


ruby: 2.5.7 -> 2.5.8, 2.6.5 -> 2.6.6, 2.7.0 -> 2.7.1

Motivation for this change
https://www.ruby-lang.org/en/news/2020/03/31/heap-exposure-in-socket-cve-2020-10933/
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[X] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

@GrahamcOfBorg build ruby_2_5 ruby_2_6 ruby_2_7

To github.com:NixOS/nixpkgs
33c19df80d9..7f82e22f705  release-20.03 -> release-20.03
d011e474945..deb8fd1136b  release-19.09 -> release-19.09
34c7eb7545d..f53bdf3dda3  release-19.03 -> release-19.03
e99df8643c8..925ff360bc3  release-18.09 -> release-18.09
1e47a6c30c4..3e1be2206b4  release-18.03 -> release-18.03


Expiry for sticky session cookies

Do you want to request a feature or report a bug?
Bug
What did you do?
Installed traefik ingress controller using helm. Configured stickness in the ingress & service objects using below annotations.
service:
"annotations": {
"traefik.ingress.kubernetes.io/affinity": "true",
"traefik.ingress.kubernetes.io/load-balancer-method": "drr",
"traefik.ingress.kubernetes.io/max-conn-amount": "10",
"traefik.ingress.kubernetes.io/session-cookie-name": "UNIQUE-PEGA-COOKIE-NAME"
}
Ingress:
"annotations": {
"kubernetes.io/ingress.class": "traefik"
}

What did you expect to see?
Sticky session are working. Though individual requests are not load balanced, different sessions should load balanced across the pods. It should work similar to jsession id. Which means, cookies used by traefik should be aged out after certain period or provide a mechanism to clear the cookies
What did you see instead?
Traefik cookie is never expired or aged out or deleted hence all the requests are going to the same pod irrespective of various sessions or new browser windows, as long as browser cookies are delete manually for the given site.
Output of traefik version: (What version of Traefik are you using?)
Traefik helm chart: traefik-1.52.8
Image: traefik:1.7.4

Duplicate of #1939


Addition of probability distribution (Von Mises distribution)

I'm submitting a ...

[ ] code improvement request

Dear Virocon team,
Thank you for the very useful tool you have developed. I am new to pull requests and issues (I'm a first timer actually) so hopefully I'm doing this as intended. Anyway, I have added the Von Mises distribution to the distributions.py file. I used this distribution to model wind-wave misalignment, which is a relevant environmental parameter for offshore wind turbines.
Also I think there may be a bug in the normal distribution definition, and I corrected it editing line 864.
I submitted a pull request for you to consider merging into the code. https://github.com/frp09/virocon/compare/master...frp09-vmd
Best,
Francesco

Hi Francesco,
thanks for your work, glad you like virocon so far.
The PR you created is intern to your own fork of virocon, i.e. you created a PR from your branch frp09-vmd to your own master branch (this is not the same as virocon/master).
We would like to accept your PR though, so I created this PR #157.
I would suggest we continue any discussions there.
Best,
Kai

I realize now, that me creating the PR might not emphasize enough that this is your contribution. Feel free to create another PR from your frp09-vmd branch to virocon-organizations master.

The new distribution is available now in version 2.1.0 published on PyPI (not yet on conda). I will leave this Issue open for now in case you want to continue any discussions started in #157.
Nice work! :+1:


More detailed instructions for building with separate wasm file

Thank you for your work on this library 👍
I would like to use it within a worker, and potentially run multiple workers. But I guess the fact that the wasm is hardcoded as a huge base64 string makes the js source code longer to interpret (do you agree with that ? or is it negligible ?). So instantiating multiple workers would require to interpret that code each time, and would not be optimal.
So I guess using a separate wasm file would be better for this usage. Despite your instructions though, I don't see how to build the library in order to make the js API use a separate wasm file, without changing the code.
If my concern about the big base64 string is relevant, could you please provide more detailed instructions on how to do that ? I would even prefer that no additional building is required, and that the library itself just exposes a separate wasm file and expects to be fed at runtime with a url to this file (which could also be a base64 url generated by a webpack loader for instance, so both strategies are supported).

That could certainly be done. The main offender is:
https://github.com/TrevorSundberg/h264-mp4-encoder/blob/542fc995327e6549bc3019ad8cd5d9c5bf8d585c/CMakeLists.txt#L131
If you remove that line it will build as a wasm file. We could maybe read that as an environment variable, and the build server could certainly compile two versions.
That said, I remember this problem being a lot more hairy, and in fact it looks like I left myself a note in the README:

To make packaging considerably easier, I built with Emscripten's -s SINGLE_FILE=1 which base64 encodes the wasm inside the JavaScript file. You're welcome to remove this option to get a wasm file, but you'll need to handle Webpack importing as well as the locateFile within the Emscripten Module object.

The main issue is that once you've separated the wasm, everyone who ever wants to use it has to add custom webpack/rollup/browserify logic to their project to copy the file to their public asset directory, as well as tell the loader JavaScript where it's located. It's not terribly difficult, but it's a big pain for anyone who wants to just install and immediately use the library.
That said I think you have a very valid concern, and I do like the idea of having two versions. One is simple and quick for usage, one is complicated but better for performance.

Thank you very much for your reply, and again for the great work :)
I did try to build with this option removed, but could not get to the end of the process which seems to use a lot of resources so I wasn't sure there was a problem or not. How much time is it supposed to take ? The docker image is running on my MacBook Pro from year 2018 with a quad core i7 at 2.7GHz.
Also, regarding your note about the locateFile, is there further modifications to do besides the SINGLE_FILE option ?

FWIW, I've managed to load the WASM using my serviceWorker with very little changes. Took me awhile to try out various other solutions. Using a serviceWorker plays nicely with Create React App (CRA) and any existing apps which may have internal routing, such as react-router.

FWIW, I've managed to load the WASM using my serviceWorker with very little changes. Took me awhile to try out various other solutions. Using a serviceWorker plays nicely with Create React App (CRA) and any existing apps which may have internal routing, such as react-router.


Rotate map + Rectangle regions

When making buildings in a village where the dominant floorplan is a simple rectangle (lots of places in Africa) being able to click two corners of a rectangle would be useful. And doing so on a grid that lines up with the streets would be easier as well. Take for instance Maiduguri, Nigeria. I would like to be able to rotate the map until the streets were horizontal/vertical, and then put rectangles on houses one after another, boom boom boom.

I think this is covered by #528

Yep, square building tool is coming soon.  It's becoming the "Duke Nukem Forever" of iD issues, but I did build one a little while ago and it worked great.

Dude Nukem forever 😂😂
On Sat, 4 Feb 2017 at 6:46 PM, Bryan Housel<EMAIL_ADDRESS>wrote:

Yep, square building tool is coming soon. It's becoming the "Duke Nukem
Forever" of iD issues, but I did build one a little while ago and it worked
great.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/openstreetmap/iD/issues/3817#issuecomment-277445254,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGpL7ingq5ebCH5qGNymH51yyxKRNo1pks5rZHocgaJpZM4L3G9f
.


Increase number of accepted characters in textfield input

Hey,
I would like to know if it possible to increase the number of input characters in the textfield where you put your string with the default configuration. I want to pass firebase UID but I can because they are too long.
Thanks.

@EdwinJr13 how many characters in firebase UID? You can change the configuration to uuidConfiguration which should be enough for firebase

@EdwinJr13 how many characters in firebase UID? You can change the configuration to uuidConfiguration which should be enough for firebase

My UIDs are between 30 characters and 55 because I use custom auth (JWT tokens). The uuidConfiguration is not long enough

@EdwinJr13 you can fork and try to modify Version in RCCoderConfiguration to increase characters

It's a bit tricky I don't know how to 😅


semantic-release/git is not updating Cargo.toml version number

We just published 1.0.8 but Cargo.toml lists 1.0.4

Fixed in semantic-release-cargo


Auto-Update website with latest version?

Is it possible to either update the website with every push or create a subpage (latest/beta) with the latest version?

@Anachron Do you mean auto-update your website with every new Spectre.css release?

Not my website, but the spectre.css one when you release a new version.

This one: https://picturepan2.github.io/spectre

@Anachron Yes. The Spectre Docs updates automatically with master branch. Btw, do you notice anything wrong? You can tell me by a new issue or Pull Request. Thank you.

@Anachron Do you notice any issue?

Oh right you sync with master, not with latest tag, I see. All good, you can close this!


Project considered abandoned?

Can it be safe to assume that debug is effectively abandoned?
The last npm release was over a year ago, there are 19 open PRs and the discussion about v5 seems stalled/dead.
Not trying to troll, just trying to get a feel if I should start looking elsewhere.

No, it's not abandoned. It's still waiting on Node.js to unblock features for a v5 rollout, as has been mentioned elsewhere.
There are one of two courses of action moving forward, however:

Node.js includes proper flags for supporting our usecase for the v5 refactor
debug is officially sunset, deprecated, and archived, and further use is discouraged everywhere in the ecosystem.

If this project ever dies, it'll be officially killed, not trail off into nothing. Right now I'm still waiting to see if anything will happen, but I don't have a lot of hopes.

@Qix- thanks for the qik (get it?) reply!
Is there a ticket I can look at to learn more?


fixed critical bug, scale_reads line 392 - no value in  / divided by …

10 / 11 data set died with the message
Reading seed kmers
Reading total kmers
Plotting seed and total kmers
Use of uninitialized value $seqwithtlen in division (/) at /opt/chloroExtractor/bin/scale_reads.pl line 392, <R> line 10.
Use of uninitialized value $tlen_sum in division (/) at /opt/chloroExtractor/bin/scale_reads.pl line 392, <R> line 10.
Illegal division by zero at /opt/chloroExtractor/bin/scale_reads.pl line 392, <R> line 10.

Here the fix for it, the var was not initialized and when the insert size can't calculated it would die to this error.
Tested with 3 sets ( Demo set - allready worked, still works. And 2 sets where it died, now it finds several contigs but none complete chloroplast)

Coverage decreased (-0.09%) to 72.3% when pulling ca4f2dbee11a00bed13baeb6b28632bfdc221792 on fix_scr_tlen_spfaff into 3be770cd84efac56606339e8aa24de8d1a75a627 on master.

Coverage decreased (-0.09%) to 72.3% when pulling ca4f2dbee11a00bed13baeb6b28632bfdc221792 on fix_scr_tlen_spfaff into 3be770cd84efac56606339e8aa24de8d1a75a627 on master.

Two little comments:

[ ] can you open an issue for the bug
[ ] delete the line number in the subject line

Thanks!

The fix is approved

Thanks for your fix and the requested modifications. This fix addresses #95
Can you provide some short reads to write a test for that bug?


Cancel a request

To avoid duplication of requests (double click), I would be able to stop a running query. I do not see how. Can you help me please ?
let inProcess = false;

return Restangular.withConfig(function(RestangularConfigurer) {
    RestangularConfigurer

        ...

        .addFullRequestInterceptor(function(element, operation, what, url, headers) {

            if (inProcess) {
                // cancel the request here
                return;
            }

            inProcess = true;

        })

        ...
});

Here's the way I've done it:
let canceler = $q.defer()
Restangular.all('users').withHttpConfig({timeout: canceler.promise}).get()
canceler.resolve() // cancels the request

This is a little counterintuitive, so let me explain. $http takes a timeout parameter (see the $http docs:

timeout in milliseconds, or promise that should abort the request when resolved.

Resolving the promise (canceler in this case), will cancel the request

Really great ! It works well, thank you for your solution :)

This doesn't work if I don't cancel immediately after the request is done, can you reproduce ?
let canceler = $q.defer()
Restangular.all('users').withHttpConfig({timeout: canceler.promise}).get()
$timeout(() => canceler.resolve(), 0) // doesn't cancel the request


Enhance the java doc of dubbo-cluster module

Enhance the java doc of dubbo-cluster module.
Related project: https://github.com/apache/incubator-dubbo/projects/2

https://github.com/apache/incubator-dubbo/issues/2884

Seems like I can't assign to u because u are not a committer or a PMC.
I can't find u at the assignees list.
But u can direct do this and send pr. I will take a look. :)

No worries, I mark myself in this issue in comment secntion, so that we can avoid double spend.

@khanimteyaz working on it.

I'm not sure if this issue is been fixed but I can work on it if @khanimteyaz is not available. Let me know if I should try to work on other issues

Hi,
Please you start working on this.  Due to time crunch I am not able work on
this.  thanks for your cooperation.
On Friday, March 15, 2019, Daniela Marques de Morais <
<EMAIL_ADDRESS>wrote:

I'm not sure if this issue is been fixed but I can work on it if
@khanimteyaz https://github.com/khanimteyaz is not available. Let me
know if I should try to work on other issues
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-dubbo/issues/2991#issuecomment-473332040,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AdXcPf_c_sHLGRLYD6tEvlukQp2XuQhtks5vW72qgaJpZM4ZXltN
.

I'll work on this

Very nice of u. @danielamorais
Looking forward to your pr.


Wurst Setup doesn't show error pulling dependecy with only a main branch

Wurst Setup GUI pulls content from master branch by default, but if a repository does not have a master branch, it doesn't show any error in the logs :

Red rectangle highlight empty dependencies folders
This can be confusing especially as new github repositories got their principal branch named main by default instead of master.

This can be confusing especially as new github repositories got their principal branch named main by default instead of master.

Yes, you can thank github for this entire unnecessary fuckery from their side breaking tooling and whatnot just to avoid the word master. But it can be configured in your user settings.
As shown in the readme you must append the branch name like so:

Back then there was no easy way to get the "default" branch with jgit, dunno if that changed.


Added Spanish language support.

Added Spanish language support.

Added Spanish language support.

Thank you for your contribution @tomasrgar !


What is the future for this project?

This looks like a really interesting project, but I see that @jmvalin has recently left Mozilla for AWS and there haven't been responses to issues from the contributors since February (I think)
Is it on-hold permanently?

+1 to @nmstoker
@nmstoker btw I saw your useful implementation of ASR and TTS (https://www.youtube.com/watch?v=cDU6Oz1bNoY). Would you mind sharing how you accomplished and the pointers to your voice dataset (really sound awesome)?  Appreciate that.
Cheers,
/z

Thanks for the kind words @zenny
As it's not really about this repo, how about I respond on a new thread https://discourse.mozilla.org/c/deep-speech ? I'll follow up on it later in the week and post the link back here when I've done it.

@nmstoker Thanks for your prompt reply. I shall eagerly look forward to your link with details of your implementation.
Actually I posted here in spite of irrelevance to this repo with apology to the repo owner because I could find no way to reach you asynchronously via email! If you share one or send an email to garbytrash#gmail, I shall appreciate your gesture.
Cheers,
/z

Sorry @zenny - haven't forgotten, just been delayed and distracted with a few other things :slightly_smiling_face:

Sorry @zenny - haven't forgotten, just been delayed and distracted with a few other things 🙂

So thoughtful of you. Eagerly looking forward to (both an email and a new git repo or gist).

@zenny - I've put a quick post up on the DeepSpeech Discourse here: https://discourse.mozilla.org/t/simple-demo-using-deepspeech-with-tts/49502 and shared the code in a  repo here: https://github.com/nmstoker/SimpleSpeechLoop

@zenny - I've put a quick post up on the DeepSpeech Discourse here: https://discourse.mozilla.org/t/simple-demo-using-deepspeech-with-tts/49502 and shared the code in a repo here: https://github.com/nmstoker/SimpleSpeechLoop

Thanks a zillion. Did I miss your voice model dataset in the repo?

Yes, I'm sorry - that's a private dataset not for release. However the code is entirely useable with models built on publicly available data (eg LJSpeech and others) or you can use your own dataset if you record one.
For any future discussion, please use the forum link.


Find in files doesn't look in all opened files

We have written th
Issue Type: Bug

Open 1 file
Ctrl-shift-F something
open some more files (I used command line for this, not VSCode's menu item)
search for something, using the already opened find in files tab
not all results are displayed
click on each open file's title tab
search for something, using the already opened find in files tab
now all results are displayed (hopefully...)

 Please paste.

These files are not in an open folder right? If so, https://github.com/Microsoft/vscode/issues/62488


Remove 'unsafe' keyword from the smart contracts

Use env calls instead of sys to remove unsafe keyword and ensure memory safety.
The issue was reported by the Halborn team while doing an audit of the sputnik smart contracts.
Original description of the issue:
Rust code that uses the unsafe keyword is considered unsafe, since all of the memory safety guarantees of Rust are not enforced there. It means that the code might be prone to vulnerabilities that would’ve been prevented by the compiler, such as Buffer Overflow, Double free, Use After free, and more.

Hey Trevor, thanks for the feedback. I would not change any logic in this PR. If you'd like we can open a new one and address those issues :D. This PR should be strictly about removing the unsafe keyword.

I've accidentally opened this PR against the audit branch. Will close it and open the same PR against main.


Wrong type used in chapters definition

Describe the bug
The release notes generator seems to expect string in the array of chapters definition.
Expected behavior
Use proper "strong" type - yaml does support arrays.
Example
See in here:
          chapters: '[
            {"title": "Breaking Changes 💥", "label": "breaking-change"},
            {"title": "New Features 🎉", "label": "enhancement"},
            {"title": "New Features 🎉", "label": "feature"},
            {"title": "Bugfixes 🛠", "label": "bug"}
          ]'

Expected format
          chapters: [
            {"title": "Breaking Changes 💥", "label": "breaking-change"},
            {"title": "New Features 🎉", "label": "enhancement"},
            {"title": "New Features 🎉", "label": "feature"},
            {"title": "Bugfixes 🛠", "label": "bug"}
          ]

Final format used:
chapters: |
  - { title: No entry 🚫, label: duplicate }
  - { title: Breaking Changes 💥, label: breaking-change }


Entry point offset could be deserialized from numeric value

As requested by @amanusk, here is a slightly improved request already posted on Telegram.
Lately a discrepancy has been noticed in the way different services treat the format of offset of members of entry_points_by_type in the body of DECLARE_TXN_V1 (i.e. declaring of deprecated Cairo 0 contracts):

The specification states that offset is NUM_AS_HEX, i.e. a hex string (spec link)
However this is not in sync with compilation artifacts since cairo-lang v0.10.x, when it switched from hex string to a numeric literal.
starknet.rs (i.e. its crate starknet-core) is following the specification:
https://github.com/xJonathanLEI/starknet-rs/blob/1d2eb07ff355bd787c143ac1aca633a6c636cfe9/starknet-core/src/types/codegen.rs#L804
starknet-devnet-rs is relying on starknet-core, so transitively following the specification
Pathfinder and starknet.js are treating this offset as a number (as well as hex string).

I'm speaking on behalf of starknet-devnet-rs, where many users have been reporting that they can no longer declare Cairo 0 contracts as they used to with starknet-devnet, and it's because the offset format in their request is wrong.  As much as I would like everyone to just follow the specification, IMO it would be the simplest solution to just tweak the offset serde directive in starknet.rs to allow both numeric and hex string values.
There is a PR (https://github.com/starkware-libs/starknet-specs/pull/152) for this in the starknet-specs repo, and it's been reported on Slack in the starknet-json-rpc channel.
Let me know what you think about this intervention :pray:

Hmm sorry I somehow missed this issue.
It's fixed and released in #491. So I'm closing this issue now.


Post coverage results to coveralls (again)

WIP

I failed at getting the required repository information available for coveralls and have stopped investigating here.


Need to improve style/spacing of how Plans are rendered

I rebuilt from master and pushed a new image to test and am seeing the below.

Note I saw this from a personal image I built.
@ibolton336 let me know the issue was likely from old deps
To fix I updated the deps (deleted yarn.lock and node_modules)
Rebuilt image and fixed


Is the develop branch still necessary?

Hi, since releases will be built by tagging commits on main and merges to main are not squashed: Is there still a need for the develop branch or could we maybe omit the develop->main merges?

Suggestion:

use only main, no develop (unless we have prereleases)
use tags to mark releases, not commits/PRs to master

Good question.
I thought it could be useful to collect more features on the develop branch and release multiple features at once.
Sometimes there are dependencies between features so it's nice to collect them first.
There is also still my hope to use a tool to get nice version change information.
But I am not sure if therefore a develop branch is necessary.

Reopening: For simplicity I'd say we should go with only 1 branch as target (namely main). A second branch would make sense if we deployed something from it. For versioning we have tags. If we want to release multiple commits at once, just tag the last of them.
IMHO the develop branch doesn't add value atm.

we discussed: this is a way we want to go. I'll change the repo settings accordingly.


Add an interface to the CNS that returns the contract address

Add an interface to the CNS that returns the contract address so that the CNS can be used within the contract

 Here is an overview of what got changed by this pull request:

Clones added
============
- libprecompiled/CNSPrecompiled.cpp  4

See the complete overview on Codacy

https://github.com/FISCO-BCOS/FISCO-BCOS/pull/1363/files


Add support for enable-all flag for AWS

This PR adds an --enable-all flag for AWS resources to enable deletion for all supported resources. I've explicitly chosen not to include a short-hand flag for it so it is more clear it is more destructive.
If merged it would partially solve the issue here: https://github.com/Qovery/pleco/issues/108
Example usage:
pleco start aws --enable-all -a us-east-1

 ____  _     _____ ____ ___
|  _ \| |   | ____/ ___/ _ \
| |_) | |   |  _|| |  | | | |
|  __/| |___| |__| |__| |_| |
|_|   |_____|_____\____\___/
By Qovery
INFO[2022-10-26T10:45:40-05:00] Starting Pleco 0.13.17
INFO[2022-10-26T10:45:40-05:00] Dry run mode enabled
INFO[2022-10-26T10:45:40-05:00] TTL check enabled
INFO[2022-10-26T10:45:40-05:00] Cloud provider: AWS
INFO[2022-10-26T10:45:40-05:00] Starting to check expired resources in region us-east-1.
INFO[2022-10-26T10:45:40-05:00] Starting to check global expired resources.
INFO[2022-10-26T10:45:41-05:00] There is no expired S3 bucket to delete in us-east-1.
INFO[2022-10-26T10:45:41-05:00] There is no expired RDS database to delete in region us-east-1.
INFO[2022-10-26T10:45:42-05:00] There is no expired RDS subnet group to delete in region us-east-1.
INFO[2022-10-26T10:45:42-05:00] There is no expired RDS Parameter Group to delete in region us-east-1.
INFO[2022-10-26T10:45:42-05:00] There is no expired RDS snapshot to delete in region us-east-1.
INFO[2022-10-26T10:45:42-05:00] There is no expired DocumentDB database to delete in region us-east-1.
INFO[2022-10-26T10:45:42-05:00] There is no expired RDS cluster snapshot to delete in region us-east-1.
INFO[2022-10-26T10:45:42-05:00] There is no expired Elasticache database to delete in region us-east-1.
INFO[2022-10-26T10:45:43-05:00] There is no unliked Elasticache subnet group to delete in region us-east-1.
INFO[2022-10-26T10:45:43-05:00] There is no expired EKS cluster to delete in region us-east-1.
INFO[2022-10-26T10:45:43-05:00] There is no expired ELB load balancer to delete in region us-east-1.
INFO[2022-10-26T10:45:43-05:00] There is no expired EBS volume to delete in region us-east-1.

Hello @1davidmichael ,
thanks for the contrib, it solves on of the issue :)


Options overlap with each other if the other option is disabled

So here's my config:
[wofi]
  extra_args = "-H 900 --allow-markup --columns=1 --lines=8 --hide-scroll"

[menu.shutdown]
  title = "shutdown"

[menu.reboot]
  title = "reboot"

[menu.suspend]
  title = "suspend"
  enabled = "false"

[menu.hibernate]
  title = "hibernate"
  enabled = "false"

[menu.logout]
  title = "logout"
  cmd = "hyprctl dispatch exit"

[menu.lock-screen]
    title = "lock"
    requires_confirmation = "false"

If i select "logout" - i am asked for confirmation to suspend for some reason.
Confirming to suspend - it does, indeed, suspend. But also logs out...
EDIT: changed my config a little, now it does indeed logs out as it is supposed to...
[menu.logout]
  title = "logout"
  requires_confirmation = "true"
  cmd = "hyprctl dispatch exit"

Also lock-screen either doesn't work or doesn't run the cmd command...
[menu.lock-screen]
    title = "lock"
    cmd = "sh -c '(sleep 0.5s; swaylock)' & disown"

Please could you elaborate on your issue, and also update the issue subject accordingly?

What do you mean by confuse each other?
cmd is meant to execute single commands, not what you are trying to do with lock-screen sending one command to the background to execute another one. I suggest you move this logic to a script and reference the script from the config.

Please could you elaborate on your issue, and also update the issue subject accordingly?
1. What do you mean by `confuse each other`?

2. `cmd` is meant to execute single commands, not what you are trying to do with `lock-screen` sending one command to the background to execute another one. I suggest you move this logic to a script and reference the script from the config.

Using the config file i attached above:
If i select "logout" - i am asked for confirmation to suspend for some reason.
If i confirm to suspend - it does suspend, and also logs out.
Note that this happens when i try to log out specifically

Fixed in v0.2.2
good catch (again!), thanks!
Regarding the second issue you reported, now I also print stdout and stderr when executing the configured commands (or the default ones), just for debugging purposes.
The problem with your configuration is that you use ~, and tilde expansion is a bash/zsh/etc feature. You should use the full path to your script or just call the script if it's in a $PATH location. You said you already did it, but it seems you have a typo ./home/alex/.config/wofi/logout.sh (the path starts with a dot).


feat: Updating Testimonial

What does the PR do?
This PR introduces a new endpoint for updating testimonials. The endpoint allows users to update their own testimonials and ensures:

The endpoint handles missing or invalid authorization headers with a 401 status code.
It returns a 404 status code if the testimonial with the provided ID is not found or does not belong to the user.
It validates input fields and responds with a 400 status code for invalid requests.
On successful testimonial update, it returns a 200 status code with the appropriate response body.

How should this be manually tested?

Ensure you have a valid user token.

Send a PATCH request to the following endpoint:
PATCH /api/v1/testimonials/:id

Replace :id with the ID of the testimonial you want to update.

Include the Authorization header:
Authorization: Bearer <access_token>

Provide a valid request body with the updated testimonial details:
{
  "name": "Updated Testimonial Name",
  "content": "Updated testimonial content."
}

Success Response
On a successful execution, you will receive the following response structure:
testimonial_update_success
{
  "status_code": 200,
  "message": "Testimonial updated successfully",
  "data": {
    "id": "unique-testimonial-id",
    "user_id": "user_id",
    "name": "Updated Testimonial Name",
    "content": "Updated testimonial content.",
    "updated_at": "2024-08-08T09:25:17.726Z"
  }
}

Example Response Image:

Unauthorized Response
If the token is missing or invalid, you will receive the following response:
testimonial_unauthorized
{
  "status_code": 401,
  "message": "Unauthorized. Please log in."
}

"Not Found" Response
If the testimonial with the provided ID is not found or does not belong to the user, you will receive the following response:
testimonial_not_found
{
  "status_code": 404,
  "message": "Testimonial not found."
}

"Internal Server Error" Response
For unexpected server issues, you will receive the following response:
testimonial_internal_server_error
{
  "status_code": 500,
  "message": "Internal server error. Failed to update the testimonial."
}

Task

Implemented PATCH /api/v1/testimonials/:id endpoint in testimonials.controller.ts.
Added method in TestimonialsService to handle testimonial updates with proper validation.
Implemented appropriate error handling for invalid tokens, request bodies, and non-existent testimonials.
Added unit tests for the endpoint covering authorization, input validation, and success cases.
Updated API documentation to reflect the new endpoint and its requirements.

Unit Test Evidence
testimonial_update_test

Reference Issue: Link to Issue

hey 👋
@Homoakin619,
@Cobidex,
@davidolanrewaju,
@rugue
Kindly review Please🙏


UnicodeDecodeError: 'gbk' codec can't decode byte 0x9d in position 2812

here is an error of Unicode Issue:
C:\Users\ms>pip install expan
Collecting expan
  Downloading expan-0.6.0.tar.gz (70kB)
    100% |████████████████████████████████| 71kB 146kB/s
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "C:\Users\ms\AppData\Local\Temp\pip-build-v8f3gpor\expan\setup.py", line 15, in <module>
        readme = readme_file.read()
    UnicodeDecodeError: 'gbk' codec can't decode byte 0x9d in position 2812: illegal multibyte sequence

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in C:\Users\ms\AppData\Local\Temp\pip-build-v8f3gpor\expan\

python environment:
>python
Python 3.6.0 |Anaconda 4.3.0 (64-bit)| (default, Dec 23 2016, 11:57:41) [MSC v.1900 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.

Hi @liuweizzuie, I did a quick search, this seems to happen with Windows with default Chinese encoding with Python3. See a same discussion here: https://github.com/sshwsfc/xadmin/issues/330.
If you have some time, it would be great that you can open a Pull Request to branch dev that fixes it. Otherwise, we will plan it maybe in later days.


feat: add the storage layout to the contract artifact

Fixes #5947.
Needed to fix a few additional things to make it work:

The deploy_contract function was broken (old call flow), it cannot do the new flow because that would be a circular dependency.
Using the storageLayout values to get the storageSlot that we are using in multiple

#5952  👈
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @LHerskind and the rest of your teammates on  Graphite

Benchmark results
Metrics with a significant change:

note_history_successful_decrypting_time_in_ms (10): 3,114 (+77%)
note_history_trial_decrypting_time_in_ms (5): 119 (+135%)
note_history_trial_decrypting_time_in_ms (10): 194 (+152%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
772
772
772

l1_rollup_calldata_gas
6,820
6,844
6,820

l1_rollup_execution_gas
587,301
587,325
587,301

l2_block_processing_time_in_ms
1,462
5,408 (+1%)
10,393 (+1%)

note_successful_decrypting_time_in_ms
174 (-5%)
403 (-3%)
707 (+3%)

note_trial_decrypting_time_in_ms
61.6 (-13%)
100 (-7%)
114 (+16%)

l2_block_building_time_in_ms
18,964 (+2%)
74,214 (+2%)
150,229 (+3%)

l2_block_rollup_simulation_time_in_ms
18,749 (+2%)
73,455 (+2%)
148,762 (+4%)

l2_block_public_tx_process_time_in_ms
8,618 (+2%)
33,726 (+2%)
69,325 (+5%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
16,348 (+1%)
30,665

note_history_successful_decrypting_time_in_ms
898 (-4%)
:warning: 3,114 (+77%)

note_history_trial_decrypting_time_in_ms
:warning: 119 (+135%)
:warning: 194 (+152%)

node_database_size_in_bytes
19,140,688
35,815,504

pxe_database_size_in_bytes
29,859
59,414

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
157 (+1%)
47,763
31,978

private-kernel-inner
179 (+1%)
80,794
31,978

private-kernel-ordering
138 (+1%)
57,732
50,043

base-parity
76.2
128
265

root-parity
125
1,244
265

base-rollup
12,422 (+3%)
110,926
957

root-rollup
50.5 (+2%)
4,551
821

public-kernel-app-logic
1,657
62,017
52,067

public-kernel-tail
4,336 (+3%)
168,566
7,491

merge-rollup
3,122 (-1%)
2,760
957

public-kernel-teardown
113 (-6%)
62,017
52,067

public-kernel-setup
118 (+1%)
62,017
52,067

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
10.9
17.7
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.6
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.637
0.548
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
51.6
80.4
260 (+1%)
505
976
1,943
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
96.0
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.529
0.496
0.474 (+1%)
0.472
0.464
0.465
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
60.6
119 (+1%)
375
737 (-1%)
1,451 (-1%)
2,913
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
105
207
691
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.536
0.536
0.509
0.508 (-1%)
0.503 (-1%)
0.507
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
67.4 (-1%)

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
109

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.587

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
51,411
543,524

Transaction size based on fee payment method

Metric
native fee payment method
fpc_public fee payment method
fpc_private fee payment method

tx_with_fee_size_in_bytes
897
1,145
1,345

Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes
2 new note hashes

tx_pxe_processing_time_ms
1,259 (-5%)
866 (+1%)
3,511 (+1%)

Metric
1 public data writes
2 public data writes
3 public data writes
4 public data writes
5 public data writes
8 public data writes

tx_sequencer_processing_time_ms
848 (+2%)
766 (+1%)
1,360 (+1%)
905 (+1%)
2,080 (+1%)
1,101 (+1%)


tap-diff not playing nicely with notEquals

The notEquals assertion gives the details in this form:
not ok 5 notEqual: [5]
  ---
    forbidden: 5
  ...

Whereas tap-diff expects this output for details:
  ---
    expected: ...
    actual: ...
  ...

As such, the notEquals assertion is showing as undefinedundefined in the diff view when piped through to tap-diff.

This has been logged with tap-diff here and is not an issue with modunit.


Replace NaN/Infinity with null

The Python json module will happily encode NaN and ±Infinity:
>>> import json
>>> json.dumps([float('nan'), float('inf'), float('-inf')])
'[NaN, Infinity, -Infinity]'

The problem is that this is not valid JSON, and the browser will choke on the payload when running JSON.parse on it:
> JSON.parse('[NaN, Infinity, -Infinity]');
Uncaught SyntaxError: Unexpected token N in JSON at position 1
    at JSON.parse (<anonymous>)
    at <anonymous>:1:6

To fix this, I used the simplejson module instead, since it provides an argument ignore_nan for converting these values to null as recommended by the JSON spec:
>>> import simplejson as json
>>> json.dumps([float('nan'), float('inf'), float('-inf')], ignore_nan=True)
'[null, null, null]'

Codecov Report

Merging #4908 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4908      +/-   ##
==========================================
- Coverage   77.13%   77.12%   -0.02%
==========================================
  Files          44       44
  Lines        8542     8542
==========================================
- Hits         6589     6588       -1
- Misses       1953     1954       +1

Impacted Files
Coverage Δ

superset/views/core.py
74.68% <100%> (ø)
:arrow_up:

superset/utils.py
87.85% <0%> (-0.22%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d533ce0...1a66e63. Read the comment docs.


question about returnReplicaEvenOnFailureToRegroup

In the call chain:
checkAndRecoverDeadMaster()-->recoverDeadMaster()-->inst.RegroupReplicasGTID()-->GetCandidateReplica()-->chooseCandidateReplica()
the code is executed here:
https://github.com/github/orchestrator/blob/c5621ba62492a9adb36388bc40851af39cd3278b/go/inst/instance_topology.go#L2455
if the following conditions are satisfied:

candidateReplica not nil
err not nil
returnReplicaEvenOnFailureToRegroup is true

the RegroupReplicasGTID function will do nothing about topology and return.
At last the failover will be successful, but in fact nothing changed about the problem cluster.
Please check it.
cc @MOON-CLJ

Can you please explain again what the problem is? What did you expect to happen, what eventually happened?

I will try my best to explain the question.
expect: do the failover and return success
eventually happened： do nothing and return success
If  the following conditions are satisfied:

candidateReplica not nil
err not nil
returnReplicaEvenOnFailureToRegroup is true

RegroupReplicasGTID return here and do nothing about topology change:
https://github.com/github/orchestrator/blob/c5621ba62492a9adb36388bc40851af39cd3278b/go/inst/instance_topology.go#L2460
We can get promotedReplica in the following code:
https://github.com/github/orchestrator/blob/master/go/logic/topology_recovery.go#L526
then at last:
https://github.com/github/orchestrator/blob/master/go/logic/topology_recovery.go#L1628
we will get success.
But the cluster topology is not changed.

let me try，
i'm doubt about this lines
https://github.com/github/orchestrator/blob/master/go/inst/instance_topology.go#L2155-L2169
1, why we need about the fallback logic in this lines?
2, the fallback logic return both not nil for candidateReplica and error ，these seems like not make sense，when returnReplicaEvenOnFailureToRegroup is true，because

RegroupReplicasGTID do nothing, then return to recoverDeadMaster
then go to replacePromotedReplicaWithCandidate

if replacePromotedReplicaWithCandidate do change topology，then some slaves not change to new promoted master。
if replacePromotedReplicaWithCandidate do nothing，then we will get success in https://github.com/github/orchestrator/blob/master/go/logic/topology_recovery.go#L1628，seems weird。

Thank you, I will look into it


chore: fix Makefile goal gnu-sed to handle brew, port, and GNU sed on macOS gracefully

Fix to PR https://github.com/oracle/macaron/pull/853 (tagging @mabdollahpour-ol)
The Makefile goal assumed Brew only, so I added support for Ports and a check for gsed to avoid installing it twice. Also note that at least Ports aliases gsed as sed such that
https://github.com/oracle/macaron/blob/edfe06eb3f9337f86215b253f40f53ca1a0105c9/scripts/dev_scripts/copyright-checker.sh#L55-L59
becomes irrelevant. I don’t know how Brew manages overriding macOS CLI tools with GNU tools.
Furthermore, I cleaned up indentation to be consistent with most (not all!) of the Makefile: every line of a rule indents by a single tab, then two spaces within scripts. That way it is easier to tell the difference between tab-indent (four or eight, depending on the editor) and space-indent (always two), and it makes managing block-indents easier & consistent.
Lastly, I think this line https://github.com/oracle/macaron/blob/edfe06eb3f9337f86215b253f40f53ca1a0105c9/Makefile#L167 should contain an exit 1 to communicate the failure correctly to the running shell.

Thanks!

I don’t know how Brew manages overriding macOS CLI tools with GNU tools.

It doesn't anymore. It used to have --with-default-names that would override the apple stuff but now it lets the users to do the aliasing/overriding themselves. brew installs the gnu stuff with a g prefix. That's why there is gsed in the script.

The Makefile goal assumed Brew only

Not just this goal. We only use brew to install souffle as well. We should probably be consistent in using these tools.

Not just this goal. We only use brew to install souffle as well. We should probably be consistent in using these tools.

The souffle doesn’t have a Ports check because there’s not Portsfile available for Souffle.

Lastly, I think this line
https://github.com/oracle/macaron/blob/edfe06eb3f9337f86215b253f40f53ca1a0105c9/Makefile#L167

@jenstroeger Thanks. That's actually intentional. We just want to let the user know that they should install Souffle manually, but the setup should not be considered as failed.


Does not work on Win7.

Just a blinking cursor appears. sad.

Please retest again with platformio-atom-ide-terminal 2.9.0 is using node-pty-prebuilt instead unmaintained and outdated pty.js
if issues persist open a new ticket with required information.
Thx =)


odo reports several applications when a component is deployed with a service

/kind bug
What versions of software are you using?

See the complete video
Actual behavior
odo app list reports several applications
Expected behavior
Only a single application should be reported
Any logs, error output, etc?
https://user-images.githubusercontent.com/695993/129233639-7cd24755-8149-4c79-9181-84427d14a74c.mp4

Still valid with 2.4.1
/remove-lifecycle stale

no longer with odo v3
/close