i want to share files with docker container on my OSX by samba ,but it not work

i open my OSX share file ,it tells by
smb://<IP_ADDRESS>

others can visit or edit my files
so , i install samba-client on my docker container(centos) ,and i typed
smbclient //<IP_ADDRESS>/data -U fanyongdong

it turns out
dos charset 'CP850' unavailable - using ASCII
session setup failed: NT_STATUS_LOGON_FAILURE

i have google so much answers, but cant fixed it .
is there anyone samba success?

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Can the container reach that IP?
Can you get more verbose output?
I'm going to close this because it is not really a docker issue so much as how to use smbclient in a container.
Please feel free to reach me on #docker on IRC, or docker-user ML, or forums.docker.com
Thanks!

ok. i use sshfs solve my problem .


Add Mustache template support

Mustache is langugage independent template system. If you implement mustache support I think more people migrated from other static site generators.
Thanks,

@mohae status?

This issue has been automatically marked as stale because it has not been commented on for at least four months.
The resources of the Hugo team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still valuable, please open a proposal at https://discuss.gohugo.io/.
This issue will automatically be closed in four months if no further activity occurs. Thank you for all your contributions.

Note/Update: This issue is marked as stale, and I may have said something earlier about "opening a thread on the discussion forum". Please don't.
If this is a bug and you can still reproduce this error on the latest release or the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.

I would say that, this issue being so old, and no one has stepped up to the task of implementing it: If someone wants to create a PR with this feature, he/she should create a new tracking issue.


bug: updated syncerconfig to remove namespaces, yet syncer continues to pull names of namespaces previously defined

Describe the bug
I added a syncerconfig manually that looks like
apiVersion: edge.kubestellar.io/v1alpha1
kind: SyncerConfig
metadata:
  name: the-one
spec:
  namespaceScope: {}
  namespaceScope:
    namespaces:
    - data-science
    - kuberay-operator
    - mcad
    - opendatahub
    - openshift-operators
    - openshift-operators-redhat
  resources: {}```

I uncommented the lines above and the syncer output changed to show namespaces were being inspected for content.  I then changed back to the content above - which should match all namespaces,

apiVersion: edge.kubestellar.io/v1alpha1
kind: SyncerConfig
metadata:
name: the-one
spec:
namespaceScope: {}
namespaceScope:
namespaces:
- data-science
- kuberay-operator
- mcad
- opendatahub
- openshift-operators
- openshift-operators-redhat
resources: {}

and the syncer continued to spit out the same output it did when the namespaces were enumerated

### Steps To Reproduce

1. add a syncerconfig to an mb with file from description that matches all namespaces
2. observe syncer output
3. update the same syncerconfig with specific namespaces
4. observe syncer output
5. update the same syncerconfig back to matching all namespaces
6. observe output

### Expected Behavior

I expect the syncer log output to change based on the selectors in the syncerconfig

### Additional Context

_No response_

The SyncerConfig objects are not part of the user interface. They are internal to the mailbox workspaces, which are not part of the user interface. The SyncerConfig objects work in conjunction with the object copying done by the placement-translator; creating a SyncerConfig object that the placement-translator has not means that the placement-translator is not doing the associated workload object copying.

See #909


tailscale: honor config.networking.proxy.httpsProxy

Signed-off-by: Abdurrahman Hussain<EMAIL_ADDRESS>Description of changes
Allow bringing up Tailscale from behind HTTP proxy only sites.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Opened #207896 to just take care of it rather than force another round of edits and reviews. There was also an opportunity to clean up the service code a little bit at the same time. Closing this PR in favor of #207896.


404 Not Found

I did a straight https clone of Uno master onto an AWS instance and ran using all the defaults.  It was unable to find Accumulo with the selected mirror.  Zookeeper and Hadoop used the same mirror and had no problem downloading the tars.
--2017-03-02 11:13:08--  http://mirrors.advancedhosters.com/apache//accumulo/1.8.0/accumulo-1.8.0-bin.tar.gz
Resolving mirrors.advancedhosters.com (mirrors.advancedhosters.com)... <IP_ADDRESS>, 2a02:b48:6:1::2
Connecting to mirrors.advancedhosters.com (mirrors.advancedhosters.com)|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2017-03-02 11:13:08 ERROR 404: Not Found.
The tarball accumulo-1.8.0-bin.tar.gz does not exist in downloads/

Ah, since 1.8.1 was released then 1.8.0 is not available in the mirrors


Removed broken overdrive function in STM32.

Summary
The function void stm32_pwr_enableoverdrive(bool state) is broken.
It violates the sequence defined by ST, and generally it seems that it is not fixable due to very strange requirements defined by ST regarding its usage.
Even if there was a way to fix it, its value would be minimal for the project. It is currently not used anywhere, and it would not actually provide any actual and useful functionality to the users.
This issue is discussed in #1568.
Impact
This function is not used anywhere in NuttX code. Removing it shouldn't have any impact.
If a user was using this function, their code will break, but this is for good. It will be a good indication that their code was buggy.
Testing
Deleted code is debugged code.

@slorquet @lukegluke Do you have and concerns with this change?

@davids5, I've never used overdrive mode, probably you want to mentioned somebody else?

@davids5, I've never used overdrive mode, probably you want to mentioned somebody else?
Ok no worries, I only asked because you are on the blame.

I may have added this, is it why I was tagged?
it can be removed, it was only used for a time, but not successfully IIRC.
But why not try to make this work instead of nuking it? Could allow my board to run at 180 MHz instead of being stuck at 168 MHz, from a 25 MHz xtal...

I may have added this, is it why I was tagged?

Yes. Thank you for responding.

it can be removed, it was only used for a time, but not successfully IIRC.
But why not try to make this work instead of nuking it? Could allow my board to run at 180 MHz instead of being stuck at 168 MHz, from a 25 MHz xtal...

Because it is as the OP stated it can not be done this way and is already done correctly in the rcc init.

@slorquet No, this is not what you think.
If your board runs on 180MHz, overdrive is automatically enabled in stm32f40xxx_rcc.c.
This is for toggling overdrive in run-time.

If the feature is usable some other way, then I have no concern with the removal of this function
However it was not clear initially wether removing this function would result in a feature loss or not.

Sorry for not making it clear. The feature is fully usable. There is absolutely no impact on current code.
It is just the interface removed, that allows users to break their system in a later stage...

@slorquet Sorry. I should have pointed it out, It it was in the other thread:

Luckily this function is not used anywhere now. Core over-drive is handled directly by the clock initialization procedure, without calling it, following a correct procedure.

Yes, makes sense. Thanks for the poke.
There was only one commented use in our codebase, so no impact.


Variables list

While preparing #125 I've spotted, that some code fragments declares lists with only one item, like:
- name: Install chrony package
  apt: name={{ item }}
  with_items:
    - chrony

The purpose of this issue is to rewrite them to be like:
- name: Install chrony package
  apt: name=chrony

Please, correct if I'm wrong and it was done on purpose.

Right, no need to use with_items here, rewrite it as you proposed.


for Android modified isDeviceSupported() to return true only when there are enrolled biometrics that can be used, and getAvailableBiometrics() - to return fingerprint only if there are enrolled fingerprints on the device

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[ ] I signed the CLA.
[ ] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[ ] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

guys, any update on this PR?
would be merge soon?

Thanks for your contribution. Unfortunately, because the CLA has not been signed, I'm afraid we can't look at this proposal. I am therefore going to close this PR. If you would like us to consider this patch in the future, please do not hesitate to open a new PR, after signing the CLA which you can find at: https://cla.developers.google.com/
Thanks!


getPointerProps Returns Previous Selected Point Index on Release

Description
When using the getPointerProps function, the index updates correctly as the pointer moves across different points on the chart. However, upon releasing the pointer, the index reverts to the previously selected point instead of returning index -1.
Expected Behavior
Upon releasing the pointer, getPointerProps should return index = -1 to signify no point is selected after release.
Actual Behavior:
On release, the index reverts to the previously selected point, rather than returning -1.
Workaround:
Temporarily, I am just using pointerX = 0 to identify if it is released.
Additional Information:

Steps to reproduce

Install library
Import  component
add props

  getPointerProps={(item: {pointerIndex: number; pointerX: number;}) => {
    updatePoint (item.pointerX === 0 ? -1 : item.pointerIndex)
  }};

Snack or a link to a repository
No response
version of react-native-gifted-charts
1.4.34
React Native version
0.75.2
Platforms
Android, iOS
Workflow
React Native

Hi @simyxing Can you check again in the latest version of react-native-gifted-charts?

@Abhinandan-Kushwaha Yes, the issue is persist in the latest version of react-native-gifted-charts (1.4.43)

I am using the latest version of react native gifted charts.
I have found out upon releasing the pointer on a bar chart, BarChart, the pointer index correctly returns  -1.
However, on a line chart, LineChart, upon releasing the pointer the same last point index  is erroneuosly is returned.
I will look at the source code. If am able to fix that I will submit a fix merge request.
react-native-gifted-charts is one of the best chart library I have found for react-native.
Thanks!

Hi @jeanniton-mnr Thanks for suggesting the fix. Your PR is merged and I have added a new property named resetPointerIndexOnRelease. Now you just need to add resetPointerIndexOnRelease: true in the pointerConfig object to get -1 as pointerIndex upon release.
This fix is available from versions 1.4.48 onwards. Please use the latest version of the library.


Don't wait after autoformatting

This means builds will finish faster!  If we have a pull request build that fails because we pushed an autoformat commit, that kicks off a new build – and then Buildkite cancel the intermediate builds, so we're not running tasks we don't care about.
(See settings in https://buildkite.com/wellcomecollection/catalogue-pipeline/settings/builds)

Gonna leave this open until I have time to push it to the other repos.


bar chart data labels issue

Description

Steps to Reproduce

suppose i have more than 25 columns in bar chart
click on Zoom in (+) icon
then one of the data labels value gets overlaped  outside the y-aixs

Expected Behavior
data labels values should not overlaped outside the y-axis
Actual Behavior
Data labels value gets overlaped outside the y-axis
Screenshots

Reproduction Link

did not provide required codepen link


UI: Governance All button mysteriously grows.

https://github.com/crypto-power/cryptopower/assets/34998433/76dcfd53-6fad-42ca-992f-fbed0b4973cd

Duplicate of #164


Suppress logged warning on calls to propsData()

In our tests we often validate default data and prop values for the component under test using something like this:
componentUnderTest.data().should.deep.equal({
 // all expected data values go here
});

componentUnderTest.propsData().should.deep.equal({
 // all expected props values go here
});

We're using v4.2.0 and this works nicely for calls to data(), and it does also work when calling propsData(). However, when calling propsData(), we always get the warning:

functions returned by propsData() will not have this bound to the vue instance. Calling a propsData function that uses this will result in an error. You can access propsData functions by using the vue instance. e.g. to call a method function named propsDataFunc, call wrapper.vm.$props.propsDataFunc(). See https://github.com/eddyerburgh/avoriaz/issues/15');

I understand the reason for this warning message, but its muddying up my test output. Is there a way I can suppress it without muting other potential warnings from avoriaz?

There's not currently a way to hide the warnings, would you like to make a PR that adds the feature?


Change playground to use client-side evaluation

This is partially complete here, but blocked until we have a published web-sdk (experimental or not)
see also: https://github.com/open-feature/playground/issues/178

Completed with: https://github.com/open-feature/playground/pull/131


Use of HTTP

Greetings,
I am a security researcher, who is looking for security smells in Puppet scripts. I found instances where the HTTP protocol is used instead of HTTPS (HTTP with TLS). According to the Common Weakness Enumeration organization this is a security weakness (https://cwe.mitre.org/data/definitions/319.html).  I was wondering why HTTP is used? Is it because of lack of tool support?
I am trying to find out if developers are forced to adopt bad practices due to lack of tool support when it comes to the HTTPS protocol. Maybe it is due to dependency on a resource that uses HTTP?
Any feedback is appreciated.
Source: https://github.com/gds-operations/puppet-aptly/blob/master/manifests/init.pp (Line#72)

It's because that URL isn't exposed over HTTPS.


Add German translations

German translations of various strings

Hi,
Do you plan on doing every file/category ?  Migrating a partial translation isn't ideal.

Hi, yes I'll translate the rest as well when I get around to it :)

Thank you for the contribution!


[models] Automatic ordering for billboards

Issue description
The billboards don't order themselves like 3d cubes or models.
Environment
Linux, GL 4.6, mesa
Issue Screenshot

i cant find any documentation online (because i also need ordering for rotation)
it's just supposed to work
with transparency

this is one possible solution, which works without sorting...
https://bedroomcoders.co.uk/raylib-billboards-advanced-use/


Adding mailsocket.us.to to trash domains

I added this to trash domains. If it belongs in a different data file, contact me.

Thanks @xpsusa for your contribution.
Please update the commit description to reference the website that offers this domain, so we can use have it for reference and confirm its type.

@xpsusa Do you know the website that issues these email addresses?


fix pathes for GOPATH that are broken on windows

$(GOPATH) instead of /opt/gopath

Description

Motivation and Context

to run on windows with git bash / mingw

Fixes #
How Has This Been Tested?

Checklist:

[] I have added a Signed-off-by.
[] I have either added documentation to cover my changes or this change requires no new documentation.
[] I have either added unit tests to cover my changes or this change requires no new tests.
[] I have run golint and have fixed valid warnings in code I have added or modified. This tool generates false positives so you may choose to ignore some warnings. The goal is clean, consistent, and readable code.

Signed-off-by:

Thank you for your contribution! This is a read only mirror, however. Please submit your change using gerrit.
you would need to check out the repo here: https://gerrit.hyperledger.org/r/#/admin/projects/fabric and make your edits, pushing them to gerrit
here is a walkthrough for zephyrproject which is much the same WRT setting up an LFID, adding ssh keys, etc:
https://www.zephyrproject.org/doc/1.1.0/collaboration/code/gerrit_accounts.html
feel free to ask on rocket.chat - https://chat.hyperledger.org/ - discuss in #fabric
one note: when you set up your LFID do not use social logins the first time, create the account and you can add social logins later


Expenselt (lowercase L) or ExpenseIt (uppercase i)

Please use a better name or font that shows the difference between lower case L (l) and uppercase i (I). Thought it was an odd name for a project, but continued only to realise later that it was Expenseit not ExspenseLt.
https://i.imgur.com/yjw16sX.png

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b0dc39f7-b153-a46c-3b88-07c8ed2c71bc
Version Independent ID: 78a14535-9703-e2af-4451-783a7c4c10be
Content: Create a WPF application in Visual Studio
Content Source: docs/framework/wpf/getting-started/walkthrough-my-first-wpf-desktop-application.md
Product: dotnet-framework
GitHub Login: @mairaw
Microsoft Alias: mairaw

Thanks @mattb5906 for your feedback. I can see how the name can be confusing to read. Given that this is an enhancement suggestion, I'm adding this to our backlog and to our community project list. PRs for this are welcome!


get k8s config from requestConfig. and added test.

Currently, only k8s information in systemconfig was available.
In this PR, the k8s information contained in requestconfig is acquired and used.

日本語でおｋ


Update docs

Some improvements have not made their way into the API docs it seems, having them stated more clearly is necessary for more clarity on the use of some functions. Example

leaving this open to be addressed following guidelines


The last inventory notification doesn't get dismissed after farming

Bug report
Description
I think ASF is supposed to dissmiss all inventory notifications if set so.
I am sorry I coudn't report with details as I was reporting the issue through my phone.

Expected behavior

All inventory notifications to be dismissed after farming.
Current behavior
The last notification after farming cards doesn't get dismissed.

Possible solution
I think ASF stops the task right after it finishes farming. Maybe a delay could solve this?

Steps to reproduce
Make ASF farm cards for a game.
Check Steam notification after ASF finishes farming.

Global ASF.json config
{
  "CurrentCulture": "en-US",
  "Statistics": false,
  "s_SteamOwnerID": "*",
  "IPC": true
}

BotName.json config of all affected bot instances (if more than one)
{
  "AcceptGifts": false,
  "AutoSteamSaleEvent": true,
  "CustomGamePlayedWhileFarming": null,
  "CustomGamePlayedWhileIdle": null,
  "Enabled": true,
  "FarmingOrders": [
    0
  ],
  "GamesPlayedWhileIdle": [],
  "HandleOfflineMessages": false,
  "HoursUntilCardDrops": 3,
  "IdlePriorityQueueOnly": false,
  "IdleRefundableGames": true,
  "LootableTypes": [
    1,
    3,
    5
  ],
  "MatchableTypes": [
    5
  ],
  "OnlineStatus": 1,
  "PasswordFormat": 0,
  "Paused": false,
  "RedeemingPreferences": 0,
  "SendOnFarmingFinished": false,
  "SendTradePeriod": 0,
  "ShutdownOnFarmingFinished": false,
  "SteamTradeToken": "*",
  "SteamUserPermissions": {},
  "TradingPreferences": 0,
  "UseLoginKeys": true,
  "BotBehaviour": 8,
  "SteamLogin": "*",
  "SteamMasterClanID": 0,
  "SteamParentalPIN": "0",
  "SteamPassword": "*",
  "s_SteamMasterClanID": "0"
}

Additional info

In the wiki, it says byte flags but aren't they bit flags? Sorry if I am wrong as I am not an expert in this field.
Can "byte flags" replaced by other wordor at least accompany a description of it as it is a technical term only used for C programming (as far as I know)? I think most of the users are people like me who doesn't understand coding much.

This is not a full log recorded while reproducing the problem, please provide full log as recorded by ASF, not the half that matters.

I didn't find anything suspicious in your log or configs, and can neither reproduce your issue myself with such. Can you reproduce it reliably or it was just one-time thing?

I see it happening every time recently, but I don't remember when it started to do this.

Are you sure this is new items notification and not something else? Because new messages being stuck is a common Steam screwup and nothing to fix on ASF side.

Maybe that is what I see as an issue. I'm double checking config and the PC's environment right now.
I will report again after a set of card is farmed today.

Well there is no reason for the last card to not get cleared because you're not using ShutdownOnFarmingFinished and ASF routine responsible for that executes always, entirely independent of cards farming state, which is why what you're explaining so far doesn't make sense, at least from code perspective.
But at the same time I'm not saying that it's impossible, if you reproduce it again and still state that it's new items notification and not unread messages or other comments then I'll give you instructions to reproduce it with debug build which will clearly state whether ASF is doing what it's supposed to do or not (and why).

Closed due to inactivity.


Frigate card query args not working when used with Bubble Card

I am using the bubble card to have a popup using the navigate action. This is basically a card that is in the dashboard but hidden and when the navigation is called with the hash #cameras a popup will show with the card inside.
Running frigate card 5.2.0
Here is the yaml for the view that is calling this:
type: custom:mushroom-chips-card
chips:
  - type: template
    entity: sensor.frigate_status
    content: |-
      {% if (states("binary_sensor.back_deck_cam_person_occupancy") == 'on')  %}
        Person @ Back Deck
      {% elif states('binary_sensor.back_deck_cam_dog_occupancy') == 'on' %}
        Dog @ Back Deck
      {% else %}
        Back Deck
      {% endif %}
    icon: |-
      {% if (states("binary_sensor.back_deck_cam_person_occupancy") == 'on')  %}
        mdi:account-alert-outline
      {% elif states('binary_sensor.back_deck_cam_dog_occupancy') == 'on' %}
        mdi:dog-service
      {% else %}
        mdi:cctv
      {% endif %}
    icon_color: |-
      {% if (states("binary_sensor.back_deck_cam_person_occupancy") == 'on')  %}
        red
      {% elif states('binary_sensor.back_deck_cam_dog_occupancy') == 'on' %}
        red
      {% else %}
        white
      {% endif %}
    tap_action:
      action: navigate
      navigation_path: '#cameras?frigate-card-action:camera_select=back_deck_cam'
alignment: center

I have also tried
navigation_path: '#cameras?frigate-card-action:popup:camera_select=back_deck_cam'
navigation_path: '#cameras?frigate-card-action:camera_select=camera.back_deck_cam'
but they also do not seem to work.
Here is the yaml for the frigate card in a popup
type: vertical-stack
cards:
  - type: custom:bubble-card
    card_type: pop-up
    hash: '#cameras'
    name: Cameras
    icon: mdi:cctv
    margin_top_mobile: 0px
    margin_top_desktop: 28px
    width_desktop: 90%
  - type: custom:vertical-stack-in-card
    cards:
      - type: custom:frigate-card
        card_id: popup
        cameras:
          - camera_entity: camera.front_cam
            live_provider: go2rtc
            go2rtc:
              modes:
                - webrtc
            frigate:
              labels:
                - person
                - dog
                - cat
            id: front_cam
          - camera_entity: camera.back_gate_cam
            live_provider: go2rtc
            go2rtc:
              modes:
                - webrtc
            frigate:
              labels:
                - person
            id: back_gate_cam
          - camera_entity: camera.back_deck_cam
            live_provider: go2rtc
            go2rtc:
              modes:
                - webrtc
            frigate:
              labels:
                - person
            id: back_deck_cam
          - camera_entity: camera.garage_cam
            live_provider: go2rtc
            go2rtc:
              modes:
                - webrtc
            frigate:
              labels:
                - person
          - camera_entity: camera.front_doorbell_cam
            live_provider: go2rtc
            go2rtc:
              modes:
                - webrtc
            frigate:
              labels:
                - person
          - camera_entity: camera.office_cam
            live_provider: go2rtc
            go2rtc:
              modes:
                - webrtc
            frigate:
              labels:
                - dog
        live:
          lazy_unload: all
          auto_play: all
          auto_mute: all
          auto_unmute: never
          controls:
            title:
              mode: none
            thumbnails:
              mode: below
              media: snapshots
              show_details: false
            next_previous:
              style: none
          zoomable: false
          auto_pause: all
        media_viewer:
          controls:
            title:
              mode: none
            next_previous:
              style: none
        menu:
          style: outside
          position: bottom
          buttons:
            frigate:
              enabled: false
            snapshots:
              enabled: false
            download:
              enabled: false
            camera_ui:
              enabled: false
            fullscreen:
              enabled: false
            media_player:
              enabled: false
            microphone:
              enabled: true
            timeline:
              enabled: false
        performance:
          profile: high
        timeline: {}

I can see the url properly showing the query args, and the card opens but it always opens to front_cam
example: http://HA_IP:8123/dashboard-draft/default-view#cameras?frigate-card-action:camera_select=back_deck_cam

i could be wrong, but it could be related to this. while the issue is closed, per my latest comment and @dermotduffy response, it is still being addressed
https://github.com/dermotduffy/frigate-hass-card/issues/1259

also see this for context
https://github.com/dermotduffy/frigate-hass-card/issues/1253#issuecomment-1699148995

To be clear I'm testing this on web so not sure what the specific issue is, but sounds like this is being refactored so sounds good to me

To be clear I'm testing this on web so not sure what the specific issue is, but sounds like this is being refactored so sounds good to me

That's right -- this is what I'm currently working on in my development time. I will specifically test the examples in this bug as I'm doing so. It's part of a much larger refactor of the main card.ts file which has grown beyond maintainability.

@NickM-27 Since it seems you tried out the refactored PR, did the querystring work as you expected now?
This should be the correct format to select a camera: ?frigate-card-action:camera_select=camera.front_door

Haven't tried the new version yet, but it has just been sitting on this regardless of what I do

when I load the editor the card works fine but then I save and it just shows the above

it appears the issue is the card does not like being inside vertical-stack-in-card
however, once I removed that, it still does not seem to be working with the query args, the first camera is always opened

Looks like more than 1 issue here. Mind sharing the non-vertical-stack config, with that I think the only issue is the query string doesn't work, right?
And with the vertical stack (config as shown earlier in this issue?), it gets stuck at the ha reconnection?

Looks like more than 1 issue here. Mind sharing the non-vertical-stack config (whatever the smallest config you have that shows the problem), with that I think the only issue is the query string doesn't work, right?

right, just that the query args don't seem to work AND when using query args the camera selector popup doesn't seem to work.
example: http://<IP_ADDRESS>:8123/dashboard-draft/default-view#cameras?frigate-card-action:camera_select=camera.front_cam
  - type: custom:frigate-card
    cameras:
      - camera_entity: camera.front_cam
        live_provider: go2rtc
        go2rtc:
          modes:
            - webrtc
        frigate:
          labels:
            - person
            - dog
            - cat
        id: front_cam
      - camera_entity: camera.back_gate_cam
        live_provider: go2rtc
        go2rtc:
          modes:
            - webrtc
        frigate:
          labels:
            - person
        id: back_gate_cam
      - camera_entity: camera.back_deck_cam
        live_provider: go2rtc
        go2rtc:
          modes:
            - webrtc
        frigate:
          labels:
            - person
        id: back_deck_cam
      - camera_entity: camera.garage_cam
        live_provider: go2rtc
        go2rtc:
          modes:
            - webrtc
        frigate:
          labels:
            - person
      - camera_entity: camera.front_doorbell_cam
        live_provider: go2rtc
        go2rtc:
          modes:
            - webrtc
        frigate:
          labels:
            - person
      - camera_entity: camera.office_cam
        live_provider: go2rtc
        go2rtc:
          modes:
            - webrtc
        frigate:
          labels:
            - dog
    live:
      lazy_unload: all
      auto_play: all
      auto_mute: all
      auto_unmute: never
      controls:
        title:
          mode: none
        thumbnails:
          mode: below
          media: snapshots
          show_details: false
        next_previous:
          style: none
      zoomable: false
      auto_pause: all
      transition_effect: none
    media_viewer:
      controls:
        title:
          mode: none
        next_previous:
          style: none
    menu:
      style: outside
      position: bottom
      buttons:
        frigate:
          enabled: false
        snapshots:
          enabled: false
        download:
          enabled: false
        camera_ui:
          enabled: false
        fullscreen:
          enabled: false
        media_player:
          enabled: false
        microphone:
          enabled: true
        timeline:
          enabled: false
    performance:
      profile: high

And with the vertical stack (config as shown earlier in this issue?), it gets stuck at the ha reconnection?

I believe so, or at least that's what the card text implies. To be clear, this is with the custom:vertical-stack-in-card and not the built in stack

example: http://<IP_ADDRESS>:8123/dashboard-draft/default-view#cameras?frigate-card-action:camera_select=camera.front_cam

In this example, your card doesn't have a camera with an id "camera.front_cam", as you've explicitly set the id to front_cam, i.e. I would expect this to work:
http://<IP_ADDRESS>:8123/dashboard-draft/default-view#cameras?frigate-card-action:camera_select=front_cam
Don't suppose that could be the issue?

I'll try it again but that was actually how it was before but I changed it. I'll give it another go

On the vertical stack issue, I install this which I think is what you're referring to, and used your same config at the start of the issue. It seems to work fine. But when I add the bubble card, it behaves erratically, sometimes renders nothing at all, sometimes (rarely though) shows the reconnection message you had. If I change custom:bubble-card to xxxcustom:bubble-card it seems to go back to normal (except the bubble bit has the expected error message). Can't tell if the issue is in the bubble card or Frigate card...

On the vertical stack issue

OK, think I figured the vertical stack/bubble issue out somewhat. One of the bubble card, or more likely the vertical stack card, is passing in an undefined HA state object to the Frigate card, which should not happen. This is causing the Frigate card to think the connection is lost, and it is incorrectly detecting the "reconnection". Working on a fix. I see other issues with using the Frigate card in the bubble card though, but one thing at a time...

unfortunately this still doesn't seem to be working for me. If I have a button with navigate action and navigation_path: '#cameras?frigate-card-action:camera_select=back_deck_cam' it is still opening with the front_cam (which is the first cam in the list) selected

If I have a button

Aha. OK. You're not just going to the URL in the browser (bet that works), you're using a navigate action. I have reproduced the navigate action case not working -- phew.

@NickM-27 OK, with those two merged changes on the dev branch I think this will be better for you. Note that the other issue I found is addressed with this non-merged PR:
https://github.com/ofekashery/vertical-stack-in-card/pull/126
Vertical stack card will cut off the camera selector menu if you position it at the bottom, since it uses overflow: hidden.

not sure if I am doing something wrong but it still doesn't work for me. I also copied the full address and tried to open it directly in the browser and it still opens to the front camera.

not sure if I am doing something wrong but it still doesn't work for me.

Oh dear, sorry this is consuming your time.

Would you mind checking your Javascript console (F12 in Chrome) while you're loading the page with the query string and see if anything interesting is happening.
I found and fixed a different bug impacting the carousel not scrolling correctly in certain cases. It's possible this was what you were seeing, although I suspect unlikely.

For full transparency, here is how I am testing. Please let me know if I'm not testing the right thing:
Test Case 1: Simple navigation actions

Picture elements config:
type: picture-elements
image: https://demo.home-assistant.io/stub_config/floorplan.png
elements:
  - type: icon
    icon: mdi:cctv
    style:
      top: 22%
      left: 30%
    tap_action:
      action: navigate
      navigation_path: /lovelace-test/map?frigate-card-action:camera_select=camera.living_room
  - type: icon
    icon: mdi:cctv
    style:
      top: 71%
      left: 42%
    tap_action:
      action: navigate
      navigation_path: /lovelace-test/map?frigate-card-action:camera_select=camera.landing

Card config:
type: custom:frigate-card
cameras:
  - camera_entity: camera.living_room
  - camera_entity: camera.landing

Test Case 2: Bubble + Vertical Stack

Button:
type: button
show_name: true
show_icon: true
tap_action:
  action: navigate
  navigation_path: >-
    /lovelace-test/vsic?frigate-card-action:camera_select=camera.living_room#cameras
show_state: false
icon: mdi:cctv

Stack/Card:
type: vertical-stack
cards:
  - type: custom:bubble-card
    card_type: pop-up
    hash: '#cameras'
    name: Cameras
    icon: mdi:cctv
    margin_top_mobile: 0px
    margin_top_desktop: 28px
    width_desktop: 90%
  - type: custom:vertical-stack-in-card
    cards:
      - type: custom:frigate-card
        card_id: popup
        cameras:
          - camera_entity: camera.landing
          - camera_entity: camera.living_room

okay so it appears the #cameras must come after the query args, not before. When it comes after things work as expected

by the way I am noticing the (what seems new) grid media gallery with live camera views, is there a way to default to this view?

okay so it appears the #cameras must come after the query args, not before. When it comes after things work as expected

Great, phew. Yes: the frigate card is using true query string parameters. Looks like bubble card is using anchor references like #whatever, this must come after a query string in a URL. This makes some sense, since anchor references are typically used to move particular content on a long page into view, which is (kind of?) what is happening with the popup: the content is already rendered, just not visible until it's "popped" into view.

by the way I am noticing the (what seems new) grid media gallery with live camera views, is there a way to default to this view?

You mean the multi-camera grid? Yes, you can enable it by default for either (or both) of the live view or media view like the below. There's also a menu button to switch back and forth dynamically.
[...]
live:
  display:
    mode: grid
media_viewer:
  display:
    mode: grid

Awesome, that is working great and I see what you are saying now, that makes sense


Fix plugins loading due to outdated structs plugin

I tried to install the buildfarm master on a fresh 16.04 host. Jenkins would not load due to an outdated structs plugin. After bumping the version all the other plugins started working.
I'm using the same Jenkins version as http://build.ros.org: 2.190.1

I think I'm having the same issue.
Running puppet
Running puppet resulted in 6 errors and 15 warnings
Showing the last 10 error messages
2020-02-07 14:57:19 +0100 Puppet (err): java -jar /usr/share/jenkins/jenkins-cli.jar -s http://<IP_ADDRESS>:8080 -auth myci:REDACTED groovy = < /tmp/configure
_git_user.groovy returned 255 instead of one of [0]
2020-02-07 14:57:19 +0100 /Stage[main]/Profile::Jenkins::Master/Rosjenkins::Groovy[/tmp/configure_git_user.groovy]/Exec[/tmp/configure_git_user.groovy]/ret
urns (err): change from notrun to 0 failed: java -jar /usr/share/jenkins/jenkins-cli.jar -s http://<IP_ADDRESS>:8080 -auth myci:REDACTED groovy = < /tmp/confi
gure_git_user.groovy returned 255 instead of one of [0]
2020-02-07 14:58:24 +0100 Puppet (err): java -jar /usr/share/jenkins/jenkins-cli.jar -s http://<IP_ADDRESS>:8080 -auth myci:REDACTED groovy = < /tmp/complete_
setup.groovy returned 255 instead of one of [0]
2020-02-07 14:58:24 +0100 /Stage[main]/Profile::Jenkins::Master/Rosjenkins::Groovy[/tmp/complete_setup.groovy]/Exec[/tmp/complete_setup.groovy]/returns (er
r): change from notrun to 0 failed: java -jar /usr/share/jenkins/jenkins-cli.jar -s http://<IP_ADDRESS>:8080 -auth myci:REDACTED groovy = < /tmp/complete_setu
p.groovy returned 255 instead of one of [0]
2020-02-07 14:59:16 +0100 Puppet (err): java -jar /usr/share/jenkins/jenkins-cli.jar -s http://<IP_ADDRESS>:8080 -auth myci:REDACTED groovy = < /tmp/enable_tc
p_agents.groovy returned 255 instead of one of [0]
2020-02-07 14:59:16 +0100 /Stage[main]/Profile::Jenkins::Master/Rosjenkins::Groovy[/tmp/enable_tcp_agents.groovy]/Exec[/tmp/enable_tcp_agents.groovy]/retur
ns (err): change from notrun to 0 failed: java -jar /usr/share/jenkins/jenkins-cli.jar -s http://<IP_ADDRESS>:8080 -auth myci:REDACTED groovy = < /tmp/enable_
tcp_agents.groovy returned 255 instead of one of [0]

It looks like this at least partially solves this.

I have to add that in my last tests, upgrading structs plugin to 1.19 did not fix all the problems; but upgrading to 1.20 works fine (using Jenkins 2.204.1).

Currently have Structs plugin v1.20 working with Jenkins ver. 2.222.3 using deployment/2019-11-27 branch with some other fixes on top.
@nuclearsandwich Can this be merged into master?

Thanks everyone for contributing here.


Windows 10, version 1903 host OS compatibility

The table for Windows 10 1903 appears to have been copied from Server 2016 without modification. At the very least I believe this should support all versions with hyper-v, and as per previous ticket, should also support 1903 process isolation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c47037c4-4b2e-b41c-64a3-d82ec79c18c4
Version Independent ID: 947b1d95-3cd5-53d4-042f-71afe8bb3bdf
Content: Windows Container Version Compatibility
Content Source: virtualization/windowscontainers/deploy-containers/version-compatibility.md
GitHub Login: @taylorb-microsoft

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Pin integration tests deployed dependencies of repos [21-30]

Context
All the charms that get deployed as dependencies in integration tests must be pinned to their corresponding 1.8 stable channels in the gh:track/ branches. For instance, istio-operators deploy kubeflow-volumes in their integration tests, we must ensure that the last supported stable version of kubeflow-volumes get deployed alongside the last supported stable istio-operators.

The resulting PR should be something like https://github.com/canonical/istio-operators/pull/405

While some of the integration tests may pass, the correct way of running integration tests to keep repeatable runs is by testing always with the same versions.

Related issue https://github.com/canonical/bundle-kubeflow/issues/857

Part of https://github.com/canonical/bundle-kubeflow/issues/859

What needs to get done
For gh:track/<version> (for CKF 1.8 corresponding versions)

Get charms 21-30 from the bundle.yaml file.
Go into each charm repo and for all the test.py files where a charm is deployed, pin the channel to the version defined in the bundle definition (file from step 1).
Submit a PR with your changes.

For gh:main make sure all charms that get deployed in integration tests point to latest/edge unless it is recommended otherwise (e.g. mysql-k8s).
Definition of Done
All integration tests run with specific versions of charms that correspond to either CKF 1.8 or latest/edge

There are charms from kfp-viz to metacontroller-operator.


Chore/#153240597 - Refactor actions into separate files

Refactored actions into separate files.
They all get imported and exported in actions/index, so no other files needed to change.

another thought for how the actions could go...
// actions/project/index.js
import {
  FETCHING_PROJECTS,
  RECEIVED_PROJECTS,
  FAILED_PROJECTS
} from './types'

import api from '../../api'

export const fetching = { type: FETCHING_PROJECTS }
export const received = { type: RECEIVED_PROJECTS }
export const failed = { type: FAILED_PROJECTS }

export default class ProjectActionCreator {
  static fetching () {
    return fetching
  }

  static received (projects) {
    return {
      ...received,
      payload: projects
    }
  }

  static failed (error) {
    return {
      ...failed,
      payload: error,
      error: true
    }
  }

  static fetchAllProjects () {
    return dispatch => {
      dispatch(ProjectActionCreator.fetching())

      try {
        const projects = api.project.all()
        dispatch(ProjectActionCreator.received(projects))
      } catch (e) {
        console.log(e)
        dispatch(ProjectActionCreator.failed(e))
      }
    }
  }

  static fetchProfileProjects (user) {
    return dispatch => {
      dispatch(ProjectActionCreator.fetching())

      try {
        const projects = user.usertype === 'contact'
          ? api.project.organization(user.organization)
          : api.project.applied(user.opportunitiesAppliedFor)
        dispatch(ProjectActionCreator.received(projects))
      } catch (e) {
        console.log(e)
        dispatch(ProjectActionCreator.failed(e))
      }
    }
  }
}

// components/Home/Home.js
import ProjectActionCreator from '../../actions/project'

class Home extends Component {
  componentDidMount () {
    this.props.onLoad()
  }
  ...
}

const mapDispatchToProps = {
  onLoad: ProjectActionCreator.fetchAllProjects
}

Just rebased onto master!


[BEAM-9119] Disable flaky test_large_elements

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

R: @tvalentyn @robertwb

LGTM, please make sure test author is aware of the change.

LGTM, please make sure test author is aware of the change.

I believe @robertwb wrote it

Verified test is being skipped:
https://builds.apache.org/job/beam_PreCommit_Python_Commit/12376/testReport/apache_beam.runners.portability.fn_api_runner.fn_runner_test/FnApiRunnerTest/test_large_elements/
test_streaming_wordcount failure in https://builds.apache.org/job/beam_PreCommit_Python_Commit/12376/ is unrelated. Opened a bug for it: https://issues.apache.org/jira/browse/BEAM-9767


Merge main to dev 28 03

please wait - I will merge rc -> develop

didnt we make changes directly to main?


Stats page is broken

After the recent update (HEAD at https://github.com/diced/zipline/commit/12baadd563847d5454ce13da7e997e9ca20d5820) the user stats page (domain.com/dashboard/stats) is completely broken, giving out a "Something went wrong..." page and the following client errors in the console:

I see what happened here, and unfortunately I'm out of town so I won't be able to fix this for a bit. By next week it should be fixed.

Fixed in latest update


Chore/update out of date dependencies

Summary
Update

Updated packages

Pillow
tensorflow
torch
torchvision

Updated README instructions for how to run application

Added

Added geopandas to requirments.txt for non windows machines

Removed

Removed requirements.txts in specific pages subdirectories
because they should have their needed dependencies
installed from the base requirements.txt and it is a pain
to keep multiple copies up to date with each other.
Removed h5py, and Keras explicit dependencies because it
seems the most recent version of tensorflow doesn't have
the same problem? Tested the image classifier page and
it classified fine on newer versions of tensorflow.
If we don't do that, then tensorflow won't work with
python 3.9, since all versions of tensorflow that work
with 3.9 require h5py > 3.0

@MarcSkovMadsen I started with updating some of the dependencies to get it running with python 3.9 (libraries aren't out with 3.10 yet) and updated the read me just a little for some first steps on getting things at least runnable directly locally.

I will take a look when my work day is over. Thanks so much.

Feel free to connect on https://twitter.com/MarcSkovMadsen and https://www.linkedin.com/in/marcskovmadsen/ or gitter at @MarcSkovMadsen .

Basically everything looks fine.  But I need to get it tested. And I will use the opportunity to update to Panel 0.12.6 and get the README.md up to date. I have started.
For some reason the docker image that I build fails. So something must have changed since I build it last
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/tornado/web.py", line 1704, in _execute
    result = await result
  File "/usr/local/lib/python3.7/site-packages/panel/io/server.py", line 221, in get
    template_variables=session.document.template_variables
  File "/usr/local/lib/python3.7/site-packages/panel/io/server.py", line 151, in server_html_page_for_session
    bundle = bundle_resources(session.document.roots, resources)
  File "/usr/local/lib/python3.7/site-packages/panel/io/resources.py", line 140, in bundle_resources
    ext = bundle_models(None)
  File "/usr/local/lib/python3.7/site-packages/bokeh/util/compiler.py", line 308, in bundle_models
    _bundle_cache[key] = bundle = _bundle_models(custom_models)
  File "/usr/local/lib/python3.7/site-packages/bokeh/util/compiler.py", line 517, in _bundle_models
    custom_impls = _compile_models(custom_models)
  File "/usr/local/lib/python3.7/site-packages/bokeh/util/compiler.py", line 494, in _compile_models
    compiled = nodejs_compile(impl.code, lang=impl.lang, file=impl.file)
  File "/usr/local/lib/python3.7/site-packages/bokeh/util/compiler.py", line 113, in nodejs_compile
    output = _run_nodejs([compilejs_script], dict(code=code, lang=lang, file=file, bokehjs_dir=bokehjs_dir))
  File "/usr/local/lib/python3.7/site-packages/bokeh/util/compiler.py", line 445, in _run_nodejs
    return _run(_nodejs_path(), argv, input)
  File "/usr/local/lib/python3.7/site-packages/bokeh/util/compiler.py", line 421, in _nodejs_path
    _nodejs = _detect_nodejs()
  File "/usr/local/lib/python3.7/site-packages/bokeh/util/compiler.py", line 413, in _detect_nodejs
    '("conda install nodejs" or follow https://nodejs.org/en/download/)')
RuntimeError: node.js v14.0.0 or higher is needed to allow compilation of custom models ("conda install nodejs" or follow https://nodejs.org/en/download/)

I am also considering whether I should change from pip to conda. I would have less problems working I believe if I did.

I now remember that I had the problem when I first pulled it down, like a month and a half ago. But a forgot about it. I updated my version of node and all was good.
conda might cause less issues. I assume the plan is to maintain compatibility with at least a few versions of python back. Base conda comes with 3.8, so you can’t use some of the newest python features, but that is fine is you want the repo to have compatibility with python at least 3.8+ if not older.

Thanks @madeline-scyphers . I've merged the PR. Thanks so much.

I've updated the README.
I've upgraded to python 3.9.9.

I plan to do some more including creating a Vision/ Roadmap Feature Request linking to sub Feature Requests. Any input on "why" this project should exist and "what" it should be feel free to comment/ contribute. It will really help.
I don't get very much feedback on this project. So I don't know if it works at all for other users than me or not. Thanks.


Remove prototype Pandas implementation from protocol/

Now that we have four real-world implementations in cuDF, Vaex, Modin and Pandas, we no longer need this prototype. Having it here makes it harder to merge other PRs (see gh-69), so let's remove it now.

No futher comments, and folks were happy with this change in the last call. So I'll go ahead and merge this.


A sheet snaps to a wrong position after the keyboard is closed

Steps to reproduce

Reproduction code
import 'package:flutter/material.dart';
import 'package:smooth_sheets/smooth_sheets.dart';

void main() {
  runApp(const DebugApp());
}

class DebugApp extends StatelessWidget {
  const DebugApp();

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Center(
          child: Builder(
            builder: (context) {
              return ElevatedButton(
                onPressed: () => showSheet(context),
                child: const Text('Show Sheet'),
              );
            },
          ),
        ),
      ),
    );
  }
}

void showSheet(BuildContext context) {
  Navigator.push(
    context,
    ModalSheetRoute(
      builder: (context) {
        return const SafeArea(
          bottom: false,
          child: DraggableSheet(
            minExtent: Extent.proportional(0.5),
            physics: SnappingSheetPhysics(
              snappingBehavior: SnapToNearest(
                snapTo: [
                  Extent.proportional(0.5),
                  Extent.proportional(1),
                ],
              ),
            ),
            child: SheetContentScaffold(
              body: SizedBox.expand(
                child: TextField(),
              ),
            ),
          ),
        );
      },
    ),
  );
}

Actual results

Video
https://github.com/fujidaiti/smooth_sheets/assets/68946713/8398318c-c5da-4b4b-89ff-595916ff3361

Expected results
In the above example, the sheet position should be maintained before and after the keyboard is closed.

Tried to implement something similar to Apple Maps and the Keyboard destroys the whole usability atm.
Everything else is smooth as f*ck. 🏆

I'm already working on it!
branch/keyboard-issue 👀


version bump for react-lottie

I need this for SSR Fix.
Please see
https://github.com/bodymovin/bodymovin/pull/442

Cool, Thanks! v0.1.0 released


Backspace accelerator does not work

On Mac, using 'Backspace' alone as the Accelerator does not seem to work. The menu-item's click function never executes and the menu does not highlight. Partnering Backspace with any other modifier (such as 'Command+Backspace') does work.

It's a expected behavior. The Accelerator should be used with a modifiers: https://github.com/atom/electron/blob/master/docs/api/accelerator.md. Using Backspace key code alone will not work.

If this is true, then why do Up, Down, Left, and Right work without modifiers? I'm sure there are others (Esc, VolumeUp, VolumeDown, etc) that would be expected to work without modifiers. Is Backspace an exception to the rule? If there are specific rules for which keys work with/without modifiers, this should be noted in accelerator documentation.

But I think it's common to show del as hotkey, especially in OS X, del & fn+del are shown in different symbol.


Allow leading underscores for IDENTs

Check for digits first, then perform the isIdent() check.

:+1: :shipit:

:shipit:


Add parameter for ManagedRepository system group

If the directory doesn't already exist, or if omero_datadir_chown: True, does a chgrp and chmod so ManagedRepository is group writeable.
New functionality, should be non-breaking, tag 1.2.0?

re: "1.2.0" - WFM as an addition
re: the changes look to make sense and the current test is green, but this might be one where it's best to have production (integration) testing.

@openmicroscopy/devops any volunteers to test this?

I've added a test for inplace import, and set the default umask to 0002.

I've fixed the vagrant test, there was an error that was hidden by a bug in testinfra.

Even with testinfra 1.5.3 , I'm not getting this to pass:
ry\n================================================================================\nInstall  9 Packages (+70 Dependent packages)\n\nTotal download size: 75 M\nInstalled size: 232 M\nDownloading packages:\n--------------------------------------------------------------------------------\nTotal                                              513 kB/s |  75 MB  02:29     \nRunning transaction check\nRunning transaction test\n"]}

PLAY RECAP *********************************************************************
omero-server-ice35         : ok=4    changed=3    unreachable=0    failed=1
omero-server-ice36         : ok=4    changed=3    unreachable=0    failed=1

You shouldn't need testinfra 1.5.3, that was just a bug which obscured the problem. What's the actual error you're seeing?

The output is cleaner (and different) on vagrant than on docker:
TASK [ansible-role-omero-server : omero | install omero] ***********************
fatal: [omero-server-ice36]: FAILED! => {"changed": false, "cmd": "/home/omero/omego/bin/omego install --release latest --sym OMERO.server --prestartfile /home/omero/config/omero-base.config --prestartfile /home/omero/config/omero-additional.config --ice 3.6 -qq --no-start --dbhost localhost --dbuser omero --dbname omero --dbpass omero --rootpass omero --initdb", "failed": true, "msg": "[Errno 2] No such file or directory", "rc": 2}
fatal: [omero-server-ice35]: FAILED! => {"changed": false, "cmd": "/home/omero/omego/bin/omego install --release latest --sym OMERO.server --prestartfile /home/omero/config/omero-base.config --prestartfile /home/omero/config/omero-additional.config --ice 3.5 -qq --no-start --dbhost localhost --dbuser omero --dbname omero --dbpass omero --rootpass omero --initdb", "failed": true, "msg": "[Errno 2] No such file or directory", "rc": 2}

RUNNING HANDLER [openmicroscopy.nginx : restart nginx] *************************

RUNNING HANDLER [openmicroscopy.postgresql : restart postgresql] ***************

PLAY RECAP *********************************************************************
omero-server-ice35         : ok=45   changed=35   unreachable=0    failed=1
omero-server-ice36         : ok=47   changed=37   unreachable=0    failed=1

Ansible 2.2? that's not supported by this role yet.

Can you cherry-pick :
commit b2babd26115884c9d4ac593ae0aade402393ee70
Author: jmoore<EMAIL_ADDRESS>Date:   Wed Feb 1 19:46:10 2017 +0100

    Add requirements file for ansible<2.2

Hmmm... still failing:
TASK [openmicroscopy.ice : zeroc ice | install devel packages] *****************
changed: [omero-server-ice35] => (item=[u'ice-c++-devel', u'ice-java-devel', u'ice-python-devel'])
failed: [omero-server-ice36] (item=[u'ice-all-devel']) => {"changed": true, "failed": true, "item": ["ice-all-devel"], "msg": "https://zeroc.com/download/rpm/el7/x86_64/libice-java-3.6.3-1.el7.x86_64.rpm: [Errno 14] curl#18 - \"transfer closed with 915304 bytes remaining to read\"\nTrying other mirror.\n\n\nError downloading packages:\n  libice-java-3.6.3-1.el7.x86_64: [Errno 256] No more mirrors to try.\n\n", "rc": 1, "results": ["Loaded plugins: fastestmirror\nLoading mirror speeds from cached hostfile\n * base: centos.datente.com\n * epel: mirror.serverbeheren.nl\n * extras: mirror.yannic-bonenberger.com\n * updates: centos.datente.com\nResolving Dependencies\n--> Running transaction check\n---> Package ice-all-devel.x86_64 0:3.6.3-1.el7 will be installed\n--> Processing Dependency: php-ice-devel(x86-64) = 3.6.3-1.el7 for package: ice-all-devel-3.6.3-1.el7.x86_64\n--> Processing Dependency: libice-java(x86-64) = 3.6.3-1.el7 for package: ice-all-devel-3.6.3-1.el7.x86_64\n--> Processing Dependency: libice-c++-devel(x86-64) = 3.6.3-1.el7 for package: ice-all-devel-3.6.3-1.el7.x86_64\n--> Running transaction check\n---> Package libice-c++-devel.x86_64 0:3.6.3-1.el7 will be installed\n--> Processing Dependency: ice-slice = 3.6.3-1.el7 for package: libice-c++-devel-3.6.3-1.el7.x86_64\n--> Processing Dependency: glibc-devel(x86-64) for package: libice-c++-devel-3.6.3-1.el7.x86_64\n---> Package libice-java.x86_64 0:3.6.3-1.el7 will be installed\n--> Processing Dependency: libdb-java(x86-64) >= 5.3.21 for package: libice-java-3.6.3-1.el7.x86_64\n---> Package php-ice-devel.x86_64 0:3.6.3-1.el7 will be installed\n--> Running transaction check\n---> Package glibc-devel.x86_64 0:2.17-157.el7_3.1 will be installed\n--> Processing Dependency: glibc-headers = 2.17-157.el7_3.1 for package: glibc-devel-2.17-157.el7_3.1.x86_64\n--> Processing Dependency: glibc = 2.17-157.el7_3.1 for package: glibc-devel-2.17-157.el7_3.1.x86_64\n--> Processing Dependency: glibc-headers for package: glibc-devel-2.17-157.el7_3.1.x86_64\n---> Package ice-slice.noarch 0:3.6.3-1.el7 will be installed\n---> Package libdb-java.x86_64 0:5.3.21-19.el7 will be installed\n--> Running transaction check\n---> Package glibc.x86_64 0:2.17-106.el7_2.8 will be updated\n--> Processing Dependency: glibc = 2.17-106.el7_2.8 for package: glibc-common-2.17-106.el7_2.8.x86_64\n---> Package glibc.x86_64 0:2.17-157.el7_3.1 will be an update\n---> Package glibc-headers.x86_64 0:2.17-157.el7_3.1 will be installed\n--> Processing Dependency: kernel-headers >= 2.2.1 for package: glibc-headers-2.17-157.el7_3.1.x86_64\n--> Processing Dependency: kernel-headers for package: glibc-headers-2.17-157.el7_3.1.x86_64\n--> Running transaction check\n---> Package glibc-common.x86_64 0:2.17-106.el7_2.8 will be updated\n---> Package glibc-common.x86_64 0:2.17-157.el7_3.1 will be an update\n---> Package kernel-headers.x86_64 0:3.10.0-514.6.1.el7 will be installed\n--> Finished Dependency Resolution\n\nDependencies Resolved\n\n================================================================================\n Package            Arch     Version               Repository              Size\n================================================================================\nInstalling:\n ice-all-devel      x86_64   3.6.3-1.el7           zeroc-ice-el7           13 k\nInstalling for dependencies:\n glibc-devel        x86_64   2.17-157.el7_3.1      updates                1.1 M\n glibc-headers      x86_64   2.17-157.el7_3.1      updates                668 k\n ice-slice          noarch   3.6.3-1.el7           zeroc-ice-el7-noarch    72 k\n kernel-headers     x86_64   3.10.0-514.6.1.el7    updates                4.8 M\n libdb-java         x86_64   5.3.21-19.el7         base                   1.3 M\n libice-c++-devel   x86_64   3.6.3-1.el7           zeroc-ice-el7          426 k\n libice-java        x86_64   3.6.3-1.el7           zeroc-ice-el7          3.4 M\n php-ice-devel      x86_64   3.6.3-1.el7           zeroc-ice-el7           66 k\nUpdating for dependencies:\n glibc              x86_64   2.17-157.el7_3.1      updates                3.6 M\n glibc-common       x86_64   2.17-157.el7_3.1      updates                 11 M\n\nTransaction Summary\n================================================================================\nInstall  1 Package  (+8 Dependent packages)\nUpgrade             ( 2 Dependent packages)\n\nTotal download size: 27 M\nDownloading packages:\nDelta RPMs reduced 3.6 M of updates to 907 k (75% saved)\n"]}

...

NO MORE HOSTS LEFT *************************************************************

PLAY RECAP *********************************************************************
omero-server-ice35         : ok=76   changed=54   unreachable=0    failed=0
omero-server-ice36         : ok=9    changed=7    unreachable=0    failed=1

"https://zeroc.com/download/rpm/el7/x86_64/libice-java-3.6.3-1.el7.x86_64.rpm: [Errno 14] curl#18 - \"transfer closed with 915304 bytes remaining to read\"\nTrying other mirror.\n\n\nError downloading packages:\n  libice-java-3.6.3-1.el7.x86_64: [Errno 256] No more mirrors to try.\n\n"

Looks like a zeroc repository problem

Ok. Looks like this week I'm getting a real error:
TASK [ansible-role-omero-server : omero | install omero] ***********************
fatal: [omero-server-ice35]: FAILED! => {"changed": false, "cmd": "/home/omero/omego/bin/omego install --release latest --sym OMERO.server --prestartfile /home/omero/config/omero-base.config --prestartfile /home/omero/config/omero-additional.config --ice 3.5 -qq --no-start --dbhost localhost --dbuser omero --dbname omero --dbpass omero --rootpass omero --initdb", "failed": true, "msg": "[Errno 2] No such file or directory", "rc": 2}
fatal: [omero-server-ice36]: FAILED! => {"changed": false, "cmd": "/home/omero/omego/bin/omego install --release latest --sym OMERO.server --prestartfile /home/omero/config/omero-base.config --prestartfile /home/omero/config/omero-additional.config --ice 3.6 -qq --no-start --dbhost localhost --dbuser omero --dbname omero --dbpass omero --rootpass omero --initdb", "failed": true, "msg": "[Errno 2] No such file or directory", "rc": 2}

RUNNING HANDLER [openmicroscopy.nginx : restart nginx] *************************

RUNNING HANDLER [openmicroscopy.postgresql : restart postgresql] ***************

PLAY RECAP *********************************************************************
omero-server-ice35         : ok=51   changed=38   unreachable=0    failed=1
omero-server-ice36         : ok=53   changed=40   unreachable=0    failed=1

i.e. how do we handle this venv bug?

Is this still Ansible 2.2? If so see https://github.com/openmicroscopy/design/pull/73

Can you cherry-pick this as well then:
commit d8c244c3ecdea36da9eff192196f8c8ea2f840c8
Author: jmoore<EMAIL_ADDRESS>Date:   Tue Feb 7 13:35:03 2017 +0100

    Fail molecule for ansible 2.2+

Been caught by that enough. Or if ansible >= 2.2 is detected, should the default omego be to /usr/bin?

Been caught by that enough. Or if ansible >= 2.2 is detected, should the default omego be to /usr/bin?

In that case why not make it the default regardless of version?

In that case why not make it the default regardless of version?

I don't understand. Doesn't the value need to be set to where omego was actually placed?

It's a bug in Ansible 2.2, the virtualenv is created but omego is installed somewhere else. I think it's better to use a fix that should work with both versions, especially since if the 2.2 bug is fixed in a later release it'll break again.

============================= test session starts ==============================
platform darwin -- Python 2.7.13, pytest-3.0.6, py-1.4.32, pluggy-0.4.0
rootdir: /opt/own-ansible/ansible-role-omero-server, inifile:
plugins: testinfra-1.4.5
collected 16 itemss

tests/test_default.py ................

============================ pytest-warning summary ============================
WP1 None Module already imported so can not be re-written: testinfra
================ 16 passed, 1 pytest-warnings in 44.17 seconds =================
--> Destroying instances...
==> omero-server-ice36: Forcing shutdown of VM...
==> omero-server-ice36: Destroying VM and associated drives...
==> omero-server-ice35: Forcing shutdown of VM...
==> omero-server-ice35: Destroying VM and associated drives...

Whew. Ok. First time it passed for me. From my side, it'd be nice to fix the 2.2 issue (since it was quite the time sync for me) but can also be later.

NB: perhaps an issue for https://github.com/openmicroscopy/design/pull/73, but there's not a clear variable prefix here unless this role should actually be named "omero".

From my side, it'd be nice to fix the 2.2 issue (since it was quite the time sync for me) but can also be later.

I can't see a clean way of fixing this without a breaking change, unless you want me to add fail if ansible > 2.1?

but there's not a clear variable prefix here unless this role should actually be named "omero".

That's because it was written before we had any standards. I'll can prefix everything but it'll obviously be a breaking change

I can't see a clean way of fixing this without a breaking change, unless you want me to add fail if ansible > 2.1?

That's what cherry-picking d8c244c3ecdea36da9eff192196f8c8ea2f840c8 would do. Only alternative (and I didn't explore it) is to override the default if >= 2.2

That's because it was written before we had any standards. I can prefix everything but it'll obviously be a breaking change

Yep, not saying it's specific to this PR, just pointing out that it's become obvious here.

Green. Merging and tagging as 1.2.0


Release v2.3.0

Planned Updates

[x] 💡Rules > Then Send To > Add Organizer as a target
[x] 💡Rules > Then Send To > Add Site Map as a target
[x] 💡Rules > Then Send To > Add Decode as a target
[x] 🐞WebSocket Rules > Require URL for When In Scope constraints
[x] 💡Rules > Add Then Read File
[x] 🐞Rules > Then Run Process > Fix issue with running commands on UNIX-like systems
[x] 💡Settings > Auto-refresh export data lists
[x] 💡Settings > Add select all and unselect all functionality to export data lists
[x] 💡Settings > Remember last export and import folder location

Checked above if code available in post_release branch.

This release is currently in pre-release https://github.com/synfron/ReshaperForBurp/releases/tag/v2.3.0-pre

This release is currently available https://github.com/synfron/ReshaperForBurp/releases/tag/v2.3.0


updating SAP on Azure

I have updated SAP on Azure TODO Page by adding some new content. Pls. approve

Merged - thanks!


moving sidebar and header to separate html

use sidebar and header as separate html instead of copying into every html file
this will have to still work with the sidebar knowing which page it is on but we can do that, probably create a react component, where we initialize it with state - which page is open
could use iFrames for main pages, and then when opening cards just attach the border to the request

not really an issue, will sort out later if neccessary


Refactor sql queries

For security reasons, as Daniele explained, to do:
cur.execute(SQL,data)

https://www.psycopg.org/docs/usage.html

@alanwilter is this done?

Whenever I need to refactor a query, I follow this reasoning, so I'm closing it.


Fix typos in PR workflow of developer doc

What happened:
Need to fix typos and spellings in https://github.com/openebs/openebs/blob/master/contribute/process/pr-workflow-developer-doc.md
What you expected to happen:
All spellings should be right!

Can I work on this?

yes @shovanch


additional functionality for writing problem and getting depth

Just some small additions to the interface. I added the possibility of writing the transformed problem. Also, the user can access the depth of the current node from the python interface.

Codecov Report

Merging #89 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   71.29%   71.19%   -0.11%
==========================================
  Files          15       15
  Lines         979      979
==========================================
- Hits          698      697       -1
- Misses        281      282       +1

Impacted Files
Coverage Δ

tests/test_short.py
25.8% <0%> (-1.62%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0e91f1...d574f1c. Read the comment docs.


Add new test.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks and welcome! Change looks good to me.


Implementaion of ext_proc filter disable immediate response

This is implementation to address issue: https://github.com/envoyproxy/envoy/issues/28698.
It's a follow up PR of https://github.com/envoyproxy/envoy/pull/28907

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/assign @tyxia @htuch @rshriram

@envoyproxy/api-shepherds  The API change is just removed a [:not-implemented-hide] comment. PTAL


Script installation on Windows does not function correctly.

Installation via pip installs scripts to site_packages but paths are not read by Windows.

This problem has multiple components:

Powershell may require admin access, a custom profile, or having the system or user PATHEXT environment variable include .PY. Otherwise scripts will run in a popup which disappears after execution (so in a nanosecond)
A shebang is required for scripts in the scripts/ directory.
Using Git Bash, Python may need to be configured in .bashrc


How to get file from createPHPExcelObject()

I want to import a file xlsx and use createPHPObject() to catch it up
and the parameter of createPHPExcelObject() is filename then I pass a filename into it
/**
* @var \Liuggio\ExcelBundle\Factory
*/
private $phpexcelFactory;

$path = '/Users/Intbizth/MyProject/lottery/src/Lot/LotteryBundle/Importer/lottery.xlsx'
$phpExcel = $this->phpexcelFactory->createPHPExcelObject($path);

and error throw Call to a member function createPHPExcelObject() on null
The question is how to get the file from project ? Thank you for advance.

Fixed!
forget to inject from __constructor


chore: import repository https://github.com/wilmerco/pneumasoft-web.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Stable matching algorithm

Hi!
I love this project, especially now that I'm studying more specifically this algorithms :)
I've added a Stable Match algorithm (alias Gale-Shapley).
Please let me know if I have to made some edits.

Thanks @kopiro!


app_components: Fix CSS for tables in settings menu.

Overview
The regression was because tables that used .table-striped CSS (/app_components.css starts at line 720) depended on the deprecated dark_theme.css rule at #29859 for its border-color value in dark theme. These tables are used primarily at the personal and organizational settings menu at /#settings. See full git grep:
git grep ".table-striped":

Fix
The fix that I've included in this PR is to switch the border-color value for .table-striped for a new variable in app_variable.css. This approach is fairly in line with how it is done at #29859, where CSS variables are used more specifically for particular elements.
Concern
Let me know whether this is at the right level of granularity that we want. For example, .table-striped is used in a wide range of menus, if we want more granularity, we could go one level deeper than ".table-striped" at the level of classes specific to each menu. For example, the Data Exports menu has the .admin_exports_table class, so we would probably assign the app_variables there instead of at .table-striped if we take with this approach.
If this is at the right level of granularity, I've also included an optional commit in this PR to reverse the previous fix (#30431) at infos_overlay and followed it up with a fix the info_overlay menus(keyboard_shortcuts, search_operators, markdown_help) by refactoring .table-bordered to use CSS variables for its border colors instead of .overlay_body to better align with the overall approach here.
Fixes: #30448
Screenshots and screen captures:

Tables that used the .table-striped class

git grep ".table-striped":

Menu Location
Light Mode
Dark Mode

Alert Words menu

Uploaded Files menu

Bots List menu

Data Exports menu

Deactivated Users menu

Default Channels menu

Custom Emoji menu

Invitations menu

Linkifiers menu

Muted Users menu

Code Playgrounds menu

Custom Profile Fields

Users menu

Topics menu

Subscriber table at Channel Settings

Subscriber table at Create channel menu

Members table at User groups settings

Members table at Create user group menu

Tables that used the .table-bordered class

git grep ".table-bordered":

git grep "notification-table":

Notice that these are the same menus reported in #30428.

Menu Location
Light Mode
Dark Mode

Keyboard Shortcuts menu

Message Formatting menu

Search Filters menu

Notification Menu

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

@zulipbot add "buddy review"

@zulipbot add "mentor review"

@sbansal1999 @kennethnrk hello guys, please review this PR, thanks!

I've given the code a once-over, but as was stated on CZO, @sahil839 is the better reviewer here.

The background color for header is still incorrect I think. This is what it looks like on Zulip cloud and I think this is the correct color and not the one currently in main -

Looks good to me otherwise.

Update: addressed reviews from Sahil, refactored notification table CSS to fix the thead background color.
I've updated the screenshot for notification settings menu and added a git grep of the impacted elements

Looks good to me.

Merged, thanks @PieterCK and @sahil839!


corrected CLI command as it was missing '$'

@sebansal : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off

@sebansal: I'm sorry - only the author of this article, @amitbapat, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.

#sign-off


Added application profile for VM and VMSS to specs

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of “no breaking changes
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

/azp run automation - sdk

Link to the design doc for VMApps https://microsoft.sharepoint.com/teams/ComputeVM/_layouts/OneNote.aspx?id=%2Fteams%2FComputeVM%2FShared Documents%2FGuestAgent%2FVM Extensions %2B Guest Agent&wd=target(Projects.one|C3BFA77D-885B-482B-9B1F-8FD8F3C8C0DA%2FVM Application|896CAE0A-134F-467E-90F0-882D8123DB35%2F)
onenote:https://microsoft.sharepoint.com/teams/ComputeVM/Shared Documents/GuestAgent/VM Extensions + Guest Agent/Projects.one#VM Application&section-id={C3BFA77D-885B-482B-9B1F-8FD8F3C8C0DA}&page-id={896CAE0A-134F-467E-90F0-882D8123DB35}&end


Typed Layout for easy conversion from Layout to actual value

Completed my own version of #3656
With full optimization of layout-precalculation and caching of previous value to reduce boxing.
Created my own version because I wasn't sure #3656 would be completed. Maybe steal the precalculate-logic from this PR ?
Notice that I have decided to always use the Layout<T> type-converter-abilities, instead of depending on PropertyHelper. This makes the behavior more predictable for users creating their own Layout<T>.

Used the Layout<T> for creating a helper-class for implementing ValueType-property just like for DatabaseTarget-Parameters.
The goal is to add ValueType to JsonLayout-Attribute, so one can guide the wanted formatting. Instead of using `Encode="false" as a trick to handle integer-output.

@304NotModified Would like to have #3656 or this PR merged, so I can continue with extracting NLog.DatabaseTarget from NLog-core. Any favorite direction?

@304NotModified Would like to have #3656 or this PR merged, so I can continue with extracting NLog.DatabaseTarget from NLog-core. Any favorite direction?

I really like to merge one of them, but haven't checked this one in depth

Is the conclusion for this PR that Layout<T> has limited support for T? Should we throw an exception if T isn't supported?

Is the conclusion for this PR that Layout<T> has limited support for T? Should we throw an exception if T isn't supported?

Yes I guess so, until a champion arrives with lots of time and great ideas :)
Maybe start with T of type ICollection ?

Maybe start with throwing when T is of type ICollection ?

Shouldn't be a white list?

Shouldn't be a white list?

Anything that is immutable and can be understood by IPropertyTypeConverter is supported. But I don't mind a white-list, but I have a feeling that people suddenly want to modify the white-list.

Rebased to dev-branch because change to VS2019-pipeline caused PullRequest on VS2017-pipeline to fail.

Rebased to dev-branch because conflicting change from #4333

Added type-validation as part of the Layout<T>-constructor.


3d image as a spinning object

Hi there!
I'm trying to create a 360-degree image, not as a panorama view but as a product view from different angles. An example would be a spinning car on mouse drag. Here is the example:
https://spins.spincar.com/vroommanheimnewengland/wddzf4kb9ha085539#hidecarousel!disabledrawer!disableautospin!disablewatermark!hidevehiclehits!stscolor=0F3A7B%2CFC4349%2CE7131A
Is this something that can be done with pannellum?
Many thanks!

No, that's outside the scope of Pannellum. See further discussion in #604.


Update Matrix of Truth

There are several updates that need to be made to the matrix of truth

Add newer Operating Systems to the Matrix
Add information about .NET 9 support
Display non-supported OSes that are still being used though docker
Update EOL dates
Add support for new hardware types

Release Note Category

[ ] Feature changes/additions
[ ] Bug fixes
[ ] Internal Infrastructure Improvements

Release Note Description
Updating Matrix of Truth with current information

completed this. Closing it


Ldap integration seems to break the database

When using the ldap integration something seems to be broken in the database.
To try this you will need an ldap requirer, one easy way to reproduce this is to use the test setup:
tox -e integration -- --keep-models

Wait for the tests to finish the deployment

Get into postgres

and inject some users by running:
INSERT INTO ldapgroups(name, gidnumber)
  VALUES('superheros', 5501);
INSERT INTO ldapgroups(name, gidnumber)
  VALUES('svcaccts', 5502);
INSERT INTO ldapgroups(name, gidnumber)
  VALUES('civilians', 5503);
INSERT INTO ldapgroups(name, gidnumber)
  VALUES('caped', 5504);
INSERT INTO ldapgroups(name, gidnumber)
  VALUES('lovesailing', 5505);
INSERT INTO ldapgroups(name, gidnumber)
  VALUES('smoker', 5506);
INSERT INTO includegroups(parentgroupid, includegroupid)
  VALUES(5503, 5501);
INSERT INTO includegroups(parentgroupid, includegroupid)
  VALUES(5504, 5502);
INSERT INTO includegroups(parentgroupid, includegroupid)
  VALUES(5504, 5501);
INSERT INTO users(name, uidnumber, primarygroup, passsha256)
  VALUES('hackers', 5001, 5501,
    '6478579e37aff45f013e14eeb30b3cc56c72ccdc310123bcdf53e0333e3f416a');
INSERT INTO users(name, uidnumber, primarygroup, passsha256)
  VALUES('johndoe', 5002, 5502,
    '6478579e37aff45f013e14eeb30b3cc56c72ccdc310123bcdf53e0333e3f416a');
INSERT INTO users(name, mail, uidnumber, primarygroup, passsha256)
  VALUES('serviceuser'<EMAIL_ADDRESS>5003, 5502,
    '652c7dc687d98c9889304ed2e408c74b611e86a40caa51c4b43f1dd5913c5cd0');
INSERT INTO users(name, uidnumber, primarygroup, passsha256, othergroups)
  VALUES('user4', 5004, 5504,
    '652c7dc687d98c9889304ed2e408c74b611e86a40caa51c4b43f1dd5913c5cd0',
    '5505,5506');
INSERT INTO capabilities(userid, action, object)
  VALUES(5001, 'search', 'ou=superheros,dc=glauth,dc=com');
INSERT INTO capabilities(userid, action, object)
  VALUES(5003, 'search', '*');

(taken from https://glauth.github.io/docs/databases.html)
The table should look like this

Try to run ldapsearch to get the hackers user:
ldapsearch -LLL -H ldap://<IP_ADDRESS>:3893 -D cn=serviceuser,ou=svcaccts,dc=glauth,dc=com -w mysecret -x -b dc=glauth,dc=com cn=hackers -v
You will not get any users back. If you now go in the database and delete the any-charm user, the query will succeed:

I managed to run glauth locally and connect it with the charm's database. It turns out that, on search, glauth tries fetch ALL the users from the database with all their attributes and parse them in memory (see https://github.com/glauth/glauth/blob/master/v2/pkg/plugins/basesqlhandler.go#L248).
By adding some log statements to the code (I couldn't make the debugger work), I saw that there was this error happening:
sql: Scan error on column index 3, name \"passbcrypt\": converting NULL to string is unsupported

on https://github.com/glauth/glauth/blob/v2.3.2/v2/pkg/handler/ldapopshelper.go#L441, which caused this bug. By setting the passbcrypt default value to "" in the charm sqlalchemy model, the bug seems to be fixed. I will open a PR about this.
This behavior from glauth seems weird, perhaps we should bring it up with upstream (cc @shipperizer @wood-push-melon )

reason seems.to.be due to the fact that it s using the customattr field which is a JSON field, that probably limits the ops a baseSQL handler can do as it cannot assume anything more complex than memory filtering as db dialects commands technology and how.they deal with json
anyway worth asking upstream for an enhancement

reason seems.to.be due to the fact that it s using the customattr field which is a JSON field, that probably limits the ops a baseSQL handler can do as it cannot assume anything more complex than memory filtering as db dialects commands technology and how.they deal with json
anyway worth asking upstream for an enhancement

I see your point, but postgres implements indexes on jsonb tables. Other than that, for our use case (which I believe is pretty common) the query is done on the cn which a unique field of the table, not part of the json. Finally, even if postgres just loaded the json on memory and did the filtering, I think that it would do it on a smarter way that this. Loading a whole table on memory and parsing it does not scale very well.


Can featuretools apply to single table datasets?

can featuretools only apply to one-table datasets(maybe I just can not find related documentation)

Hi there,
Take a look at these two posts

https://stackoverflow.com/questions/52418152/featuretools-can-it-be-applied-on-a-single-table-to-generate-features-even-when
https://stackoverflow.com/questions/50145953/how-to-apply-deep-feature-synthesis-to-a-single-table

Please let us know if it helps!

Many Thanks, I think you should give some example for different specific dataset or problems(time series), which is tsfresh or Tensorflow do, indeed, Featuretools is a very good tool.

Many Thanks, I think we will appreciate that if you guys can give more demo examples regarding to different specific datasets or problems(e.g. time series), which is tsfresh or Tensorflow do, indeed, Featuretools is a very good tool.


Use symbolToTypeNode for class & interface references

Fixes #24287
Non-alias class and interface references were still using symbolToName, which drops the module symbol. With this change they now also use symbolToTypeNode, bringing them inline with aliases and everything else (symbolToName is still used for property names).  Once fixed, this exposed an issue that showed that we weren't calculating visibility chains for merged globals within their containing ambient global augmentation correctly (they had just been defaulting to unqualified in baselines because the top of the chain was always elided), and fixing that issue (which meant accounting for merged symbols and exportSymbols in trySymbolTable) happened to improve a bunch of our symbol baselines to correctly see/use their own name, rather than falling back to some alias or qualification in scope.

Please port to release-2.9


fix: tables also use a user timezone setting same as forms

@danharrin -- Thanks for the form - your solution was more elegant :-)
I feel we should be able to do the same with table date columns so replicated it to the hasFormatters trait so that can be set in a service provider aswell.

Thanks :)


[$1000] Non-workspace members cannot see the correct workspace avatar

If you are not a member of a workspace, yet you view a workspace #room, you see a fallback avatar instead of the custom avatar that is uploaded to the workspace.

Let's fix this so that all people who view a workspace can see the custom avatar, regardless if you are a member or not.
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017ac74c500e005abc
Upwork Job ID:<PHONE_NUMBER>261134336
Last Price Increase: 2023-08-24

JK, sounds like this won't be a problem for SaaStr.

Proposal
Please re-state the problem that we are trying to solve in this issue.

Issue is that workspace image is not shown for public rooms user which do not have access to workspace, even if custom image is set.

What is the root cause of that problem?

User don't have access to workspace policy and hence image is not shown.

What changes do you think we should make in order to solve the problem?

We can add workspaceAvatar key in report and then return it in OpenReport's api response.
Then we can use that in getWorkspaceIcon function of ReportUtils.js to get the image.

https://github.com/Expensify/App/blob/53c474356a6d3eb64012b84ed18e0cc44530a6e1/src/libs/ReportUtils.js#L920-L922

Also in getWorkspaceAvatar.

https://github.com/Expensify/App/blob/53c474356a6d3eb64012b84ed18e0cc44530a6e1/src/libs/ReportUtils.js#L867-L870
What alternative solutions did you explore? (Optional)

N/A

@burczu mind reviewing proposal ^

Hey @dylanexpensify! Sorry, I've missed this one - I'll review it today!

@dylanexpensify - I've checked @jeet-dhandha proposal and from the code point of view I think it looks reasonable.
Unfortunately I couldn't check it myself because I have no idea how can i see the room of the workspace I'm not member of - could someone explain it to me?
Also, if we want to go with @jeet-dhandha proposal, we will need to amend API first, so I'm not sure how we handle such situations? Will we add the Internal label first and get back to it after the backend is ready?

Hi @burczu! Thanks for the review! Let me check!

@johnmlee101 mind confirming? 🙇♂

Hmm, if we return ${ONYXKEYS.COLLECTION.POLICY}${report.policyID}, 'avatar'` from the backend in Onyx, is there any front-end changes required?

Good point - @burczu I think John is right - mind confirming?

Doesn’t this mean user will have access to that policy even if user is not a member.

Workspace avatars for public rooms shouldn't be hidden, so no access to that policy is required in this case

@johnmlee101

We don't add policy for public rooms in the allPolicies for non-members of the workspace. Initially, I thought it would be okay to include avatar in the report but after some digging, I believe that returning 'avatar' in 'policy_${id}' should do the trick. This is because most access permission checks are based on the role so having avatar shouldn't cause any regression.

Reviewing today while in the air! Currently taxi'd, will get to once I can hop on wifi!

Just to inform: I'll be OOO on Thursday and Friday (7-8 September).

I'm guessing we should migrate back over to Internal for this issue, I can take a look at resolving this soon

Coming back from conference last week - updating today!

seems to work! you do have to load the announce room but it works

@dylanexpensify do you want to confirm and issue the report payments for this?


Convert from file name to actual emoji

Hello this is a sort of help request outside the scope of this repository.
I'm mapping the actual svg files to emoji.
While i have a way to conver from emoji to filename, i m struggling in finding the charsequence / emoji that correspond for example to:
emoji_u1f9de_200d_2642
Anyone can give me an hint to figure out how to do it?

i m actually taking the name of the emoji:
emoji_u1f9db_1f3fc_200d_2642

removing the emoji_u part. Splitting by _ and parsing in exadecimal the result.
const codepointarray = 'emoji_u1f9db_1f3fc_200d_2642'.replace('emoji_u', '').split('_').map(v => parseInt(v, 16));

i get an array
[129499, 127996, 8205, 9794]

i try to convert the array
String.fromCodePoint(codepointarray)

for some emoji work, for many i get:
Uncaught RangeError: Invalid code point NaN
    at Function.fromCodePoint (<anonymous>)
    at <anonymous>:1:8

I don't think you can pass an entire array to fromCodePoint, just a single codeepoint.
The following works for me in Chrome:
[129499, 127996, 8205, 9794].map(v => String.fromCodePoint(v)).join('')

i would feel dumb to have wasted hours on this, but super happy if it works.
thanks!

Totally works.
Thank for help, it was my fault that i took this thing

as an array.


[Ruby] Create simple example of Ruby HTTP GET Arrow client

Describe the enhancement requested
Contribute a Ruby client example to the set of minimal HTTP GET examples in the arrow-experiments repo.
Component(s)
Ruby

Thanks for adding https://github.com/apache/arrow-experiments/pull/17 @kou. Were you planning on sending a PR for a client too? I haven't started yet.

I was planing on helping you for a client because you mentioned it on the mailing list: https://lists.apache.org/thread/6xs7l0tx6wrsxv19j1vv9o79fb5lqv3d
I worked on this because a server example is a bit difficult.
If you're interested in writing Ruby code, I help you as a Ruby committer and Arrow committer. :-)
If not, I can send a PR for a client too.

I'll put a PR for you to look at, I'd love the feedback.

OK!


Custom provider for media library

Description
This PR includes the following proposed change(s):

BC-257

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Refactoring / Documentation
[ ] Version change

if your change is a breaking change, please add breaking change label to this PR
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Does the change impact or break the Docker build?

[ ] Yes
[ ] No

If Yes: Has Docker been updated accordingly?

[ ] Yes
[ ] No

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] New and existing unit tests pass locally with my changes

Testing on dev openshift