Cucumber expression: An item with the same key has already been added.

Reqnroll Version
1.0.1
Which test runner are you using?
xUnit
Test Runner Version Number
2.5.6
.NET Implementation
.NET 6.0
Test Execution Method
Visual Studio Test Explorer
Content of reqnroll.json configuration file
{
  "$schema": "https://schemas.reqnroll.net/reqnroll-config-latest.json",
  "generator": {
    "addNonParallelizableMarkerForTags": [ "NoParallel" ]
  }
}

Issue Description
I am migrating a Specflow project to Reqnroll. All is working fine, except for a single step definition which I can't "migrate" to cucumber expressions.
I have tried this in a clean solution and can't reproduce it, also I am unable to figure out in what scenario exactly the issue is happening.
Anyway, it's the following step definition:
[Given("the organisation with status '(.*)' is stored")]
[Then("the organisation with status '(.*)' should be stored")]
public async Task GivenThenTheOrganisationIsStoredWithStatus(OrganisationStatusEnum status)
{
    <redacted>
}

As shown above it's working fine, but when I change one of the RegEx's I get a lot of errors saying:
An item with the same key has already been added. Key: OrganisationStatusEnum
I don't have a clue why and I'm also not sure how to look into it, there's no stacktrace or whatever.
Any thoughts?
Steps to Reproduce
I don't know unfortunately :-(
Link to Repro Project
No response

If I understand well, as long as you keep using the regex it works, but when you try to change it to cucumber expression, you get the error.
Correct. Cucumber expressions are working fine on other step definitions though.

Could you please share the cucumber expression that causes the error?
Sure, this will trigger the issue for me:

[Given("the organisation with status {string} is stored")]
[Then("the organisation with status '(.*)' should be stored")]
public async Task GivenThenTheOrganisationIsStoredWithStatus(OrganisationStatusEnum status)
{
    <redacted>
}

Where do you see the error? In Visual Studio or during test execution? If it is reproducible during test execution as well, please share the full stack trace.
It's a compilation error in VS. So test execution won't even run at all. There's no stack trace unfortunately.

@kipusoep Could you please try to run the tests from command line, like with dotnet test? Or disable the Reqnroll VS integration temporarily and run the tests from VS?

Yes of course, I will do so tomorrow.

Sorry for the delay, running from CLI also fails:
  Failed <redacted> [236 ms]
  Error Message:
   Reqnroll.BindingException : Binding error(s) found:
An item with the same key has already been added. Key: OrganisationStatusEnum
An item with the same key has already been added. Key: OrganisationStatusEnum
An item with the same key has already been added. Key: OrganisationStatusEnum
An item with the same key has already been added. Key: OrganisationStatusEnum
An item with the same key has already been added. Key: OrganisationStatusEnum
An item with the same key has already been added. Key: OrganisationStatusEnum
An item with the same key has already been added. Key: OrganisationStatusEnum
An item with the same key has already been added. Key: OrganisationStatusEnum
An item with the same key has already been added. Key: OrganisationStatusEnum
An item with the same key has already been added. Key: OrganisationStatusEnum
An item with the same key has already been added. Key: OrganisationStatusEnum
An item with the same key has already been added. Key: OrganisationStatusEnum
An item with the same key has already been added. Key: OrganisationStatusEnum
An item with the same key has already been added. Key: OrganisationStatusEnum
An item with the same key has already been added. Key: OrganisationStatusEnum
An item with the same key has already been added. Key: OrganisationStatusEnum
An item with the same key has already been added. Key: OrganisationStatusEnum
An item with the same key has already been added. Key: OrganisationStatusEnum
  Stack Trace:
     at Reqnroll.ErrorHandling.ErrorProvider.GetInvalidBindingRegistryError(IEnumerable`1 errors)
   at Reqnroll.Infrastructure.TestExecutionEngine.GetStepMatch(StepInstance stepInstance)
   at Reqnroll.Infrastructure.TestExecutionEngine.ExecuteStepAsync(IContextManager contextManager, StepInstance stepInstance)
   at Reqnroll.Infrastructure.TestExecutionEngine.OnAfterLastStepAsync()
   at Reqnroll.TestRunner.CollectScenarioErrorsAsync()
   at <redacted>.Features.<redacted>Feature.ScenarioCleanupAsync()
   at <redacted>.Features.<redacted>Feature.<redacted>() in C:\<redacted>\OrganisationService.feature:line 18
--- End of stack trace from previous location ---
  Standard Output Messages:
 Given an organisation with status 'Active'
 -> binding error: Binding error(s) found:
 An item with the same key has already been added. Key: OrganisationStatusEnum
 An item with the same key has already been added. Key: OrganisationStatusEnum
 An item with the same key has already been added. Key: OrganisationStatusEnum
 An item with the same key has already been added. Key: OrganisationStatusEnum
 An item with the same key has already been added. Key: OrganisationStatusEnum
 An item with the same key has already been added. Key: OrganisationStatusEnum
 An item with the same key has already been added. Key: OrganisationStatusEnum
 An item with the same key has already been added. Key: OrganisationStatusEnum
 An item with the same key has already been added. Key: OrganisationStatusEnum
 An item with the same key has already been added. Key: OrganisationStatusEnum
 An item with the same key has already been added. Key: OrganisationStatusEnum
 An item with the same key has already been added. Key: OrganisationStatusEnum
 An item with the same key has already been added. Key: OrganisationStatusEnum
 An item with the same key has already been added. Key: OrganisationStatusEnum
 An item with the same key has already been added. Key: OrganisationStatusEnum
 An item with the same key has already been added. Key: OrganisationStatusEnum
 An item with the same key has already been added. Key: OrganisationStatusEnum
 An item with the same key has already been added. Key: OrganisationStatusEnum

I can't recreate this. As a simplified example, I created the following feature file:

Feature: Color Enum Testing
Scenario: Name a color enum
Given a color of 'Red'
Then the color of 'Red' should be OK

and the corresponding step definition:
namespace RnRGH81CucumberExpr_ItemWithSameKeyAlreadyAdded.StepDefinitions
{
    public enum Colors
    {
        Red,
        Blue,
        Green,
        Yellow
    }
    [Binding]
    public sealed class ColorEnumTestStepDefinitions
    {
        [Given("a color of {string}")]
        [Then("the color of '(.*)' should be OK")]
        public void TheColorOfShouldBeOK(Colors color)
        {

        }
    }
}

Without the single-quotes surrounding the enum value in the scenario steps, the VS IDE plugin would not colorize the steps correctly (meaning it was not binding the step to the definition). Running the tests as shown above succeeds. Without the single-quotes, the tests fail with the usual error message about not finding a matching step definition.
Do you have a custom ValueRetriever registered for your enum?

No custom ValueRetriever registered.
I tried to reproduce it in a clean project as well, but failed.
So I guess I have to find a way to get more information about what's happening using this specific project, but I'm not sure how.

Can you share the definition of the enum you are using? Perhaps there is something there that is causing issues with the default conversion done by Reqnroll.

I have managed to recreate this, although in a somewhat forced way. I don't think most users would stumble upon this as enum parsing is already provided out of the box.
The issue does occur when a StepArgumentTransformation is present that is given a name the same as the enum Type.
Given the same feature file as given as example above (using a Colors enum) and the following Binding code:
namespace RnRGH81CucumberExpr_ItemWithSameKeyAlreadyAdded.StepDefinitions
{
    public enum Colors
    {
        Red,
        Blue,
        Green,
        Yellow,
        Black,
        abc
    }
    [Binding]
    public sealed class ColorEnumTestStepDefinitions
    {

        [Given("a color of {string}")]
        [Then("the color of {string} should be OK")]
        public void TheColorOfShouldBeOK(Colors color)
        {

        }
    }

    [Binding]
    public class MistakenColorEnumTransformer
    {
        [StepArgumentTransformation("(.*)", Name = "Colors")]
        public Colors Transform(string color)
        {
            Colors result = Colors.abc;
            if (Enum.TryParse( color, out result)) return result;
            return Colors.abc;
        }
    }
}

Results in the following error:
Name a color enum
   Source: ColorEnumTest.feature line 3
   Duration: 13 ms

  Message:
Reqnroll.BindingException : Binding error(s) found:
An item with the same key has already been added. Key: Colors
An item with the same key has already been added. Key: Colors

  Stack Trace:
ErrorProvider.GetInvalidBindingRegistryError(IEnumerable`1 errors)
TestExecutionEngine.GetStepMatch(StepInstance stepInstance)
TestExecutionEngine.ExecuteStepAsync(IContextManager contextManager, StepInstance stepInstance)
TestExecutionEngine.OnAfterLastStepAsync()
TestRunner.CollectScenarioErrorsAsync()
ColorEnumTestingFeature.ScenarioCleanupAsync()
ColorEnumTestingFeature.NameAColorEnum() line 5
--- End of stack trace from previous location ---

  Standard Output:
Given a color of 'Red'
-> binding error: Binding error(s) found:
An item with the same key has already been added. Key: Colors
An item with the same key has already been added. Key: Colors
Then the color of 'Black' should be OK
-> binding error: Binding error(s) found:
An item with the same key has already been added. Key: Colors
An item with the same key has already been added. Key: Colors

The error does not occur when the StepArgumentTransformation is given a unique name (such as 'mycolor') and that is used as the Cucumber expression in the Binding pattern.
So, when I asked earlier about a ValueRetriever, I should have asked about the presence of any StepArgumentTransformer.
Do you have any of those in your project?

No I don't 😅 But I'm curious if the underlying issue is the same.

@kipusoep I was also able to reproduce the problem by having enums with the same name defined multiple times (in different namespaces). Could you please check if this might be the case for you (ie having multiple OrganisationStatusEnum defined)?

Yes I do, although I use both of them with a different name via the usings, like this:
using OrganisationStatusOriginal = Some.Namespace.OrganisationStatusEnum ;
using OrganisationStatusAlternative = Some.Other.Namespace.OrganisationStatusEnum;

So I think it is caused by the same issue.

@kipusoep Thx for the confirmation. We can act now.
The C# using alias is only for that C# file, the Reqnroll processing will not receive it and from Reqnroll point of view these are two enums with the same short name. I need to figure out what problems this might cause and how should Reqnroll handle this better.

Yeah that makes sense. It would be ace if you are able to find a way to handle this, as I honestly can't come up with a work-around other than having to rename the enums.

@kipusoep Agree. This afternoon I'm quite busy, but tomorrow I'll check it out.

Trust me, there's no hurry at all from my end :-) So whenever you have a spare moment would be fine.
Thanks so far!

@clrudolphi I fear that is also valid. I need to reconsider the approach we have chosen and find a way to support those situations as well.

Fixed by #100

Fixed by #100

@gasparnagy  The same problem exists when using custom type names as cucumber expression parameters. How likely do you think is to occur and is it worth it to attempt a fix?
namespace RnRGH81CucumberExpr_ItemWithSameKeyAlreadyAdded.StepDefinitions
{
    public class B
    {

    }
    public enum Shade
    {
        Light,
        Dark,
        Grey
    }

    [Binding]
    public sealed class ShadeEnumTestStepDefinitions
    {
        [StepArgumentTransformation("of ([A-Z][a-z]+)")]
        public static B ShadeOf(string shade) => new B();

        [Given("a shade of {B}")]
        public void ThisWillResultInAnError(B shade) { }
    }
}
namespace RnRGH81CucumberExpr_ItemWithSameKeyAlreadyAdded.AnotherNamespace
{
    public class B
    {

    }
    public enum Shade
    {
        Light,
        Dark,
        Grey
    }
    [Binding]
    public sealed class AnotherShadeEnumTestStepDefinitions
    {
        [StepArgumentTransformation("of ([A-Z][a-z]+)")]
        public static B ShadeOf(string shade) => new B();

        [Given("a shade of {B}")]
        public void ThisWillResultInAnError(B shade) { }
    }

}

 Using a short name of a type with conflicting names will result in an Ambiguous Error
   Source: ColorEnumTest2.feature line 4
   Duration: 14 ms

  Message:
Reqnroll.BindingException : Binding error(s) found:
An item with the same key has already been added. Key: B
An item with the same key has already been added. Key: B

  Stack Trace:
ErrorProvider.GetInvalidBindingRegistryError(IEnumerable`1 errors)
TestExecutionEngine.GetStepMatch(StepInstance stepInstance)
TestExecutionEngine.ExecuteStepAsync(IContextManager contextManager, StepInstance stepInstance)
TestExecutionEngine.OnAfterLastStepAsync()
TestRunner.CollectScenarioErrorsAsync()
ColorEnumTestingFeature.ScenarioCleanupAsync()
ColorEnumTestingFeature.UsingAShortNameOfAnEnumWithConflictingEnumNamesWillResultInAnAmbiguousError() line 5
--- End of stack trace from previous location ---

  Standard Output:
Given a shade of Grey
-> binding error: Binding error(s) found:
An item with the same key has already been added. Key: B
An item with the same key has already been added. Key: B

@clrudolphi I see. Yes, let's try. Maybe we just need to remove the "IsEnum" condition as the fix.

@gasparnagy I have a fix written. It's a bit more involved than simply removing the IsEnum condition as the problem location is not there, but in the way the custom transforms are handled.
I'm not sure how to proceed from a github perspective. Since the PR is closed, should I create a new one against the same branch? Or create an entirely new branch and PR? What will work best for you and not ruin the build and commit history?

You have to create a new PR on a new branch started from the main. The most convenient way is if you simply clone the main repo (not your fork) and create the branch there. You have right to push the branch up and create a PR from it. This has two benefits: 1. you don't need to hassle with synchronizing your fork. 2. if someone else need to help, they can add additional commits to your PR.

Added as you suggested. PR created.

Second case is also fixed by #104


Added dependency for libEGL.so in linux target.

When building library source code uses headers for EGL. On Linux platform for gstreamer EGL must be linked in order to succesfully build library itself: otherwise it fails to link (missing symbols for EGL). Probably deeper problem with platform configuration scripts. But now it seems to work.

Instead we should build gst-plugins-bad with --disable-egl. It's not going to be used anywhere in OWR.

For now that would be right solution.

However in post-X11 EGL will be unavoidable.


RE-SepFormer

Cleaned up the implementation of RE-SepFormer and SkiM that I had in my fork.

Thank you for this PR. I will try to run the experiment tomorrow. Meanwhile, I have the following comments:

in lobes/models/resepformer.py, the docstrings of MemLSTM, SegLSTM, ResourceEfficientSeparationPipeline,  ResourceEfficientSeparator are not in the expected format.  SBRNNBlock, instead, is formatted correctly.
Make sure all the functions have a  docstring (including the forward function where you can describe the input arguments).
The README.md should be update readme with the new models.
You can put the models in gdrive and mention them in the README file.
I would suggest putting the best resepformer on HF as well (in this case we have to mention it in the README as well).

Thank you for this PR. I will try to run the experiment tomorrow. Meanwhile, I have the following comments:

in lobes/models/resepformer.py, the docstrings of MemLSTM, SegLSTM, ResourceEfficientSeparationPipeline,  ResourceEfficientSeparator are not in the expected format.  SBRNNBlock, instead, is formatted correctly.
Make sure all the functions have a  docstring (including the forward function where you can describe the input arguments).
The README.md should be update readme with the new models.
You can put the models in gdrive and mention them in the README file.
I would suggest putting the best resepformer on HF as well (in this case we have to mention it in the README as well).

I did the last tests and everything is working. We can merge it! Thank you @ycemsubakan!


I would like to have DEBUG levels to hide files' listing

Which version and edition of Flyway are you using?
6.0.6
If this is not the latest version, can you reproduce the issue with the latest one as well?
(Many bugs are fixed in newer releases and upgrading will often resolve the issue)
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
Which database are you using (type & version)?
Which operating system are you using?
What did you do?
(Please include the content causing the issue, any relevant configuration settings, the SQL statement that failed (if relevant) and the command you ran.)
What did you expect to see?
I would like to see DEBUG mode, but hide the files' listing. I raised a question for this here:
https://stackoverflow.com/questions/60006223/flyway-are-there-debug-levels
What did you see instead?

Related to https://github.com/flyway/flyway/issues/2587

The problem with implementing this is that we're constrained by the need for compatibility with standard logging interfaces such as SLF4J and Apache COmmons Logging; these only offer a fixed set of log levels. So no, we can't easily add in more granularity.
As you mention the -X option I assume you're using the command line. If so, then you can pipe the output through a filter to remove everything you don't want to see. For example, to hide any line with the word "resource" in:
Linux / macOS
flyway migrate -X | grep -v 'resource'
Powershell
`./flyway migrate -Z | sls -Pattern "resource" -NotMatch
Windows CMD
flyway migrate -X | findstr /v /c:"resource"


Data tracking for new flow

As a member of the Digital Marketplace team
I need to measure how people use the save search feature
so that I can make decisions to iterate and improve it
Ticket: https://trello.com/c/eo8gJE4C/713-data-tracking-for-new-flow

@galund - your requested changes have been made. The GA event is now triggered when you click the save button.


[Test] Run thread

First beta is released. https://repo1.maven.org/maven2/com/azure/azure-ai-openai-assistants/


bufferlist is deprecated

Hello,
bufferlist is marked at deprecated:

"binary and buffers provide the functionality of bufferlist in similar but better ways."

I'm happy to merge a PR that moves this package to use either of those two alternatives! :)

There are some other things to do:
npm WARN deprecated<EMAIL_ADDRESS>to-iso-string has been deprecated, use @segment/to-iso-string instead.
npm WARN deprecated<EMAIL_ADDRESS>Jade has been renamed to pug, please install the latest version of pug instead of jade
npm WARN deprecated<EMAIL_ADDRESS>Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue


Add the repository field to Cargo.toml

To allow Crates.io , lib.rs and the Rust Digger to link to it. See the manifest for the explanation.

Thank you for your contribution, but we're unable to accept this pull request as it has no significant impact. We encourage contributors to submit changes that add meaningful value to the codebase.


[php] fix wrong indent in configmap-fpm.yaml

The indent was broken. This PR fix it.

Thank your for PR!! 💯


404 - https://rdkcentral.github.io/Lightning/docs/gettingStarted/web

Broken link in DOC, the Getting Started in bottom.

Can you look at this one as well @Thomvl? Thx :)


VS 2017 Windows build fails due to bad version check in glew dependency command file.

The VS 2017 cmd file for glew has a check to ensure it is using VS 2015. This causes the prerequisistes setup to fail.
REM ensure a 64 bit development environment using VS2015
IF NOT %VisualStudioVersion%=="14.0" ^
call "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\vcvarsall.bat" x64

Thanks for the note. There were a few instances of that bug.
https://github.com/vfxpro99/usd-build-club/commit/0d6cd78da2904a2afa268077616d3ffc8fb0ed1c


Logo

Added logo!

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.29%. Comparing base (778bd02) to head (f0260c4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #148      +/-   ##
==========================================
- Coverage   97.29%   97.29%   -0.01%
==========================================
  Files          15       15
  Lines        1406     1403       -3
==========================================
- Hits         1368     1365       -3
  Misses         38       38

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add compression pass through tests

@Tratcher, do you think is this a valid test for https://github.com/aspnet/IISIntegration/issues/1523 ?

No

Pull in the actual response compression middleware (the repo layering allows it).
Disable response compression in IIS
Disable response decompression on the client, but set the Accept-encoding header manually
Set a compressible content-type (text/plain), write data
Read the response. Make sure the Content-Encoding header is set. Make sure the content is compressed.

Also need to disable compression in IIS.

Disabled by default in deployers.

@Tratcher  ping

Failures are known and are being addressed


Moving MultiCluster folder to be under AKS

Moved all files/folders from MultiCluster to AKS/MultiCluster
Updated the gallery schema to have AKS preceding the overview template
Changed template links to controller and performance workbooks to include AKS in front in overview template

closing ancient uncompleted pull requests


Add CIDR function to PPL (#3036)

Description
Adds the cidr function to PPL, which returns whether an IP address is within an IP address range specified in CIDR notation.
Related Issues
Resolves #3036.
Check List

[X] New functionality includes testing.
[X] New functionality has been documented.
[X] New functionality has javadoc added.
[X] New functionality has a user manual doc added.
[N/A] API changes companion pull request created.
[X] Commits are signed per the DCO using --signoff.
[?] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jduo Currently working on integration tests, which don't appear to yet support the IP address type in OpenSearch.

@currantw I'll let u update the code according to @acarbonetto comments ...
ping me once its ready & I'll merge - thanks !!


Differentiate clearly between comparison modes "checksum" and "modified date / file size"

Currently a file is always considered modified if the modified date is different from the one in the backup folder, even if the checksums are equal. This is not the intended behaviour. Checksums should be the only "truth" at least in normal mode (e.g. when the checkbox no checksums is not checked by the user). Modified date should be completely ignored in this case.
Furthermore it would make more sense to offer two very distinct modes of operation (advancing the idea of the no checksums option):

compare by checksum
compare by file attributes only (e.g. modified date / file size)
where, when running in the first mode, the app really only looks at the files' checksums.

ToDo:

In isFileModified run the different comparisons based on flagCalculateChecksum as appropriate.
Adjust the UI to have a radio button with options ("calculate checksums", "file attributes only") instead of the checkbox.

Didn't like the radio button idea on second thought. Instead the checkbox is now just a bit more self explaining and got a tool tip.


fix: UI issues with code editor

Description
https://github.com/appsmithorg/appsmith/pull/22652 introduced new styles to code in Appsmith. Along with it was some unintentional changes. This PR fixes it.

Added 6px padding to code editor lines
Use class variables instead of ref

Links to Notion, Figma or any other documents that might be relevant to the PR
https://www.notion.so/appsmith/Visual-changes-to-code-in-Appsmith-8bb530c60ee844e5b44adec039bf9280#d99e8450f022439f845b5a0d7deb1d3f

PR fixes following issue(s)
Fixes # (issue number)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Chore (housekeeping or task changes that don't impact user perception)
This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

[ ] Manual
[ ] Jest
[ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:
Dev activity

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] PR is being merged under a feature flag

QA activity:

[ ] Speedbreak features have been covered
[ ] Test plan covers all impacted features and areas of interest
[ ] Test plan has been peer reviewed by project stakeholders and other QA members
[ ] Manually tested functionality on DP
[ ] We had an implementation alignment call with stakeholders post QA Round 2
[ ] Cypress test cases have been added and approved by SDET/manual QA
[ ] Added Test Plan Approved label after Cypress tests were reviewed
[ ] Added Test Plan Approved label after JUnit tests were reviewed

/ok-to-test sha=fea4749

/ok-to-test sha=2d54c36

/ok-to-test sha=d987d9d

/build-deploy-preview env=release

/ok-to-test sha=e342e2a

/build-deploy-preview env=release

/ok-to-test sha=45868bf

/build-deploy-preview env=release

lgtm cc: @arunvjn

/ok-to-test sha=356f67c

/build-deploy-preview env=release

/ok-to-test sha=b7bf9f2

/ok-to-test sha=0a6f175

/ok-to-test sha=012b6cf


The team folder service account created in the fast resman stage cannot do anything

No grants are being assigned to the team folder service account that is created in resman. Groups can impersonate it, but the service account cannot do anything.

What do we want to grant by default/as an example?
What about owner?


outbound AP Follows from tmichellemoore.com failing inbox delivery with "Unexpected object type for key"

We started seeing outbound AP inbox deliveries of Follow activities for tmichellemoore.com fail with HTTP 401 "Unexpected object type for key https://fed.brid.gy/tmichellemoore.com" recently. First instance in logs is 1/4 22:03 PT, seen from a number of instances including mstdn.social, toot.community, and masto.ai. Only for that domain, only Follows. Oddly specific. Apologies @tmichellemoore!

This accounts for most of @tmichellemoore's follows since 1/4, but not all. eg here's one to mastodon.social on 1/5 that succeeded.
All of the affected instances I looked at are on 4.0.2, but mastodon.social is too. I don't know for sure that it was on 1/5, but I expect so, since it generally upgrades quickly, and 4.0.2 was released in Nov.

Mastodon code, in main as of today: https://github.com/mastodon/mastodon/blob/d66dfc7b3c1b62a0d5276387ea8745da598afacc/app/services/activitypub/fetch_remote_key_service.rb#L29

Well that's odd, https://fed.brid.gy/tmichellemoore.com has neither type: Person nor publicKey. That's broken.
{
  "@context": "https://www.w3.org/ns/activitystreams",
  "attachment": [
    {
      "type": "Image",
      "url": "https://tmichellemoore.com/wp-content/uploads/2022/11/DSC04496.jpg"
    }
  ],
  "attributedTo": [
    {
      "id": "https://fed.brid.gy/tmichellemoore.com",
      "name": "T Michelle Moore",
      "preferredUsername": "tmichellemoore.com",
      "type": "Person",
      "url": "https://fed.brid.gy/r/https://tmichellemoore.com/"
    }
  ],
  "endpoints": {
    "sharedInbox": "https://fed.brid.gy/inbox"
  },
  "followers": "https://fed.brid.gy/tmichellemoore.com/followers",
  "following": "https://fed.brid.gy/tmichellemoore.com/following",
  "id": "https://fed.brid.gy/tmichellemoore.com",
  "image": {
    "type": "Image",
    "url": "https://tmichellemoore.com/wp-content/uploads/2022/11/DSC04496.jpg"
  },
  "inbox": "https://fed.brid.gy/tmichellemoore.com/inbox",
  "outbox": "https://fed.brid.gy/tmichellemoore.com/outbox",
  "preferredUsername": "tmichellemoore.com",
  "summary": "Project Manager | Photographer",
  "to": [
    "https://www.w3.org/ns/activitystreams#Public"
  ],
  "url": "https://fed.brid.gy/r/https://tmichellemoore.com/"
}

Got it. tmichellemoore.com's h-card has no name, so mf2util.post_type_discovery returns org, which we don't know how to handle, instead of person.

Hi @snarfed, Can you translate some of your items above? And regarding the h-cars...Mine seems to work in different ways, but on the one that I placed on my home page footer and place on my blog posts, my name is in there. I can check to make sure but I removed the org a few weeks ago. I am not sure if the IndieWeb plug-in's h-card does anything for my site since I don't use the classic editor, but it has added fields to  my User. I also have a mystery of why the h-card in the footer doesn't work on the blog posts. (I know this is a different plug-in's topic.)

@tmichellemoore sorry! Everything here is just my own working notes, not anything you need to worry about. This is a BF bug, I should have it fixed soon.

@snarfed Got it!! Thank you!

@snarfed  I have a confession. I was just experimenting with my h-card and I had an organization. lol


Mesa 21 without Mesa workaround incorrectly renders PointCloud2

Describe your issue here and explain how to reproduce it.
Your environment

OS Version: Ubuntu 18.04
ROS Distro: Melodic
RViz, Qt, OGRE, OpenGl version as printed by rviz:[ INFO] [1646652899.525315495] [ros.rviz]: rviz version 1.13.24
[ INFO] [1646652899.525380866] [ros.rviz]: compiled against Qt version 5.9.5
[ INFO] [1646652899.525397976] [ros.rviz]: compiled against OGRE version 1.9.0 (Ghadamon)
[ INFO] [1646652899.533460029] [ros.rviz]: Forcing OpenGl version 0.
[ INFO] [1646652899.757093342] [ros.rviz]: Stereo is NOT SUPPORTED
[ INFO] [1646652899.757155850] [ros.rviz]: OpenGL device: AMD RENOIR (DRM 3.44.0, 5.16.10-051610-generic, LLVM 13.0.0)
[ INFO] [1646652899.757174358] [ros.rviz]: OpenGl version: 4.6 (GLSL 4.6).

If source build, which git commit? 0462dd27
System locale, i.e. the output of echo "$LANG $LC_NUMERIC": C C

On this system, I'm using a more recent Mesa from kisak-mesa PPA (mesa 21.3.7).
Currently, there is the mesa version workaround that forces using GLSL 1.4 on systems with Mesa >= 20. In order to resolve #1701, I tried disabling the Mesa workaround, since the original issue (large points) should have been fixed since Mesa 21.0.3. The big points issue is fixed, but there is another problem: every style of PointCloud2 display except "Points" is displayed just as a white dot regardless of the settings:

How to test

run rviz in one terminal, configure a PointCloud2 display for topic points2, set fixed frame to map.
in a second terminal, run this script: https://github.com/ros-visualization/rviz/blob/noetic-devel/src/test/send_point_cloud_2.py
play around with the pointcloud display style

Is there some kind of OpenGL/Ogre profiling info I can provide?

@simonschmeisser Is this the same issue you described in #1701?

Yes, I saw the same. We only use "points" so for me the speed gain would be worth it :wink:

I can confirm the issue on an Intel GPU as well with stock Mesa 21.2.6 on Focal.
#1508 was reporting an issue with the Points display using weird point sizes for specific window heights.
Here, the points display works fine (was fixed in Mesa 21.0.3), but all other geoms ignore color and size settings.
With nvidia everything works as expected :wink:
@simonschmeisser, you argue with speed gain. What exactly do you compare and how?
I guess, points are faster than any other geom. Are the GLSL 1.5 shaders faster than GLSL 1.2 as well? If so, we might drop the Mesa workaround despite the bug reported here, because points are the way to go anyway. We should make points the default then...

My "measurements" have not been very scientific so far. With the hack enabled and a very detailed octomap rendering drops < 1fps. (octomap rendering is basically type "boxes")  (That "data point" was on bionic)
Trying to make it a bit more reproducible I changed the send_point_cloud_2.py to 1000x1000 points.  Without the hack the white dots are displayed at 30fps, with rviz --opengl 310 the frame rate drops to 10-15 fps.
This bug unfortunately also applies to the display of octomaps
I tried using renderdoc but it complains about old OpenGl versions/ contexts being used ... oh my.

I think the big difference in performance is in https://github.com/ros-visualization/rviz/blob/noetic-devel/src/rviz/ogre_helpers/point_cloud.cpp using geometry shaders and only transferring the one point we currently see or doing that "by hand" on the cpu and then transferring a lot more data (and doing a lot more transformations potentially)

apitrace gives shader compiler errors:
229192 @0 glCompileShaderARB(shaderObj = 1057)
229192: warning: compilation failed
229192: warning: 0:25(3): error: redeclaration of gl_PerVertex must be a subset of the built-in members of gl_PerVertex
0:28(1): error: identifier `gl_TexCoord' uses reserved `gl_' prefix
0:55(2): error: `gl_FrontColor' undeclared
0:55(2): error: value of type vec4 cannot be assigned to variable of type error

229442: message: major shader compiler error 2112: 0:25(3): error: redeclaration of gl_PerVertex must be a subset of the built-in members of gl_PerVertex
229442: message: major shader compiler error 2113: 0:28(1): error: identifier `gl_TexCoord' uses reserved `gl_' prefix
229442: message: major shader compiler error 2114: 0:55(2): error: `gl_FrontColor' undeclared
229442: message: major shader compiler error 2115: 0:55(2): error: value of type vec4 cannot be assigned to variable of type error

Is there a way to show shader compilation errors directly in rviz?

Is there a way to show shader compilation errors directly in rviz?

No idea. You could try different names in the corresponding shader:
https://github.com/ros-visualization/rviz/blob/697ed3ff0496b79b1bb4270aabf457ee2f2ae736/ogre_media/materials/glsl150/box.geom#L22-L28

Looks like the GLSL feature used here requires GLSL >= 410: https://github.com/KhronosGroup/glslang/issues/1441#issuecomment-404594895

https://github.com/ros-visualization/rviz/blob/697ed3ff0496b79b1bb4270aabf457ee2f2ae736/ogre_media/materials/glsl150/box.geom#L22-L28

dont call that block gl_PerVertex

Looks like the GLSL feature used here requires GLSL >= 410:

no. SSO are not supported by GL1. For GL3+ Ogre takes care of that for you:
https://ogrecave.github.io/ogre/api/latest/group___render_system.html#gga3d2965b7f378ebdcfe8a4a6cf74c3de7ab41320a27ddb636a52235e144b8289fb

I tried using renderdoc but it complains about old OpenGl versions/ contexts being used

renderdoc only works with GL3+

Are the GLSL 1.5 shaders faster than GLSL 1.2 as well?

no. just different syntax.

I think the big difference in performance is using geometry shaders and only transferring the one point

yes. this frees up CPU and Ogre is CPU bound.
geometry shaders can be used with GLSL120 too, though
https://github.com/OGRECave/ogre/blob/master/Samples/Media/materials/programs/GLSL120/SwizzleGP.glsl


Can i add Tic-tac-toe game?

Hey Hi......I can execute the project with good designs. Please assign me

pls assign me this issue !!


Add import Task from Template Overlay

Create a way for the user to make a new Task from a Template on the Tasks page

feel like this would be easier after #13333


Typo "Azure Blob storage"→"Azure Blob Storage"

https://docs.microsoft.com/en-us/sql/relational-databases/import-export/import-bulk-data-by-using-bulk-insert-or-openrowset-bulk-sql-server?view=sql-server-ver15

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@hyoshioka0128 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@hyoshioka0128,
We appreciate your contribution.
We are working on consistent terminology/capitalization across the storage docs, and when we agree on changes, we’ll be making bulk updates using automated tooling.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion, and we will reopen the issue.

@hyoshioka0128,
We appreciate your contribution.
We are working on consistent terminology/capitalization across the storage docs, and when we agree on changes, we’ll be making bulk updates using automated tooling.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion, and we will reopen the issue.


Move log files + cleanup

This PR moves log files instead of copying them, see https://issues.apache.org/jira/browse/JDO-834.
It also contains some minor cleanup:

Added command.add("execute"); in RunTck to JUnit test execution. This prevents output of deprecation notice.
Fixed some javadoc comments
Removed debug print statements from Point class.

The changes look good, ship it.

I agree. Ok to merge to main.
Craig

On Nov 25, 2023, at 14:16, Michael Bouschen @.***> wrote:
The changes look good, ship it.
—
Reply to this email directly, view it on GitHub https://github.com/apache/db-jdo/pull/88#issuecomment-1826431269, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD4M6RFJJAA3JXO7RGY67QDYGJU5PAVCNFSM6AAAAAA72IB5VOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWGQZTCMRWHE.
You are receiving this because you are subscribed to this thread.

Craig L Russell
@.***


Fixed typo: 'redundent' -> 'redundant'

Fixes #45
Signed-off-by: Bhavy Singh<EMAIL_ADDRESS>

@bhavybarca Thanks! every little bit helps. Could you add a proper signed-off-by to your commit message?

Thanks but this is already fixed in #82 ... so I am closing this.


With Origins Port is not explained

                builder.AllowAnyMethod().AllowAnyHeader()
                       .WithOrigins("http://localhost:55830")
                       .AllowCredentials();

Is 55830 the front-end port;  which is the same port the main web page is served?  How does, Signalr use the same port as the web page, that's the odd thing. It seems similar to IP tunneling...
Then a section on debugging connection errors would be great!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3cf283c9-5cd2-a9ff-b8c8-372d8a04356d
Version Independent ID: 729fddcf-24e4-b563-4952-a8045b231868
Content: ASP.NET Core SignalR JavaScript client
Content Source: aspnetcore/signalr/javascript-client.md
Product: aspnet-core
Technology: aspnetcore-signalr
GitHub Login: @bradygaster
Microsoft Alias: bradyg

@Javaman2  you wrote:

Do not use relative URLs as the asp.net core documentation shows, it makes no sense.

I just deployed the sample to Azure and var connection = new signalR.HubConnectionBuilder().withUrl("/chatHub").build(); works fine for anyone with my Azure URL.

Don't mix schemas, if your backend is HTTPs make sure this url schema is indicated.

We recommend never using HTTP, always use HTTPS. I could mention that.

To close this, add <xref:security/cors> to the additional resources section (top).


Allow trigger,reset CAH from terminal on viewer

The terminal commands now support to manual features.
Command >  "trigger-camera-accuracy-health"
Command >  "reset-camera-accuracy-health"
This commands will pop up the related GUI modal is supported.
Currently the command will affect the first device that support the feature from all the connected devices.

Can be tracked on [RS5-8462]


trusted registry: push on wrong port

I have just installed a docker Trusted Registry on premise server and having some trouble to push on it.
I configured Domain name = domain.com, HTTP Port = 5000,  HTTPS port = 5043. I also configured my client to trust domain.com certificate. Accessing through the web UI at https:domain.com:5043 is ok.
However, I'm not not able to push
$ docker login https://domain.com:5043
Username (admin): admin
Password:
Email:
WARNING: login credentials saved in /Users/vpusher/.docker/config.json
Login Succeeded

$ docker tag nginx domain.com:5043/admin/nginx
$ docker push domain.com:5043/admin/nginx
1a908c5b60b5: Pushing 1.024 kB
dial tcp <IP_ADDRESS>:443: connection refused

Docker 1.9 both client and server.
Docker Trusted Registry 1.4.2.
Why docker is initing the connection on port 443 instead of 5043 ? There is no service listening 443 on domain.com.
Is that related to the Docker registry ?

A little more precisions:
First, I get for the authentication required error:
$ docker push domain.com:5043/admin/nginx
The push refers to a repository [domain.com:5043/admin/nginx] (len: 1)
1a908c5b60b5: Preparing
unauthorized: authentication required

Then I create the reposotory through the UI, and I get the connection refused error:
$ docker push domain.com:5043/admin/nginx
The push refers to a repository [domain.com:5043/admin/nginx] (len: 1)
1a908c5b60b5: Pushing 1.024 kB
dial tcp <IP_ADDRESS>:443: connection refused

Hi, DTR is a commercial product, with dedicated support.
I encourage you to reach out to them to get help ASAP.
You can certainly start with<EMAIL_ADDRESS>Furthemore, non-default ports bug in DTR is known, though it's really a DTR-only issue (and not upstream open-source), hence there is unfortunately nothing we can do here.
I'm going to close this for book-keeping, but please mention this ticket in your mail to support.
Hope that helps.


Updating to reflect UI changes

Updated labels to reflect UI changes
Removed http://schemas.xmlsoap.org/ws/2005/05/identity/claims/nameidentifier claim, which is now included in template and cannot be added additionally.

@jkrrv : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@jeevansd - can you take a look?

@jeevansd  signoff on this

#sign-off

Thank you all!


Unable to display responsive primary navigation on multiple route pages

Select one ...  (check one with "x")
[x] bug
[ ] feature request
[ ] enhancement

Expected behavior

I have two routes /inbox and /settings.  Each route component html has a header-nav that contains a routerLink to both pages and a routerLinkActive to show the active route.
For small screen sizes I would like to display this header-nav as the primary (left) navigation so I have added [clr-nav-level]="1" to the header-nav in each route component html.
Actual behavior

When using a small screen size the hamburger menu displays and can toggle the primary navigation.  However after selecting the second page in the menu the hamburger menu will no longer toggle the primary navigation on that page.
Note I have found that removing the routerLinkActive directives from each component component html header-nav links the hamburger menu will then display the page (but obviously not the current active route state)
Reproduction of behavior

https://plnkr.co/edit/GezwMMv9dZnO67J8uprS

Navigate to the plunker and run it
Resize the frame to a small screen size to display the hamburger menu
Select hamburger menu and then select Settings
Wait for navigation to Settings page
Select hamburger menu
--> hamburger menu does not display primary navigation <--

Additionally resizing the frame to display the header-nav in the header normally will allow the navigation to work as expected before and after the above error.
Environment details

Angular version: 2.4.9

Clarity version: 0.8.9

OS and version: Ubuntu 16.04.2 LTS

Browser: Chrome Version 56.0.2924.87 (64-bit); Firefox 51.0.1 (64-bit)

You are creating two different instances of the menu in your inbox and settings components.
The common code should be extracted one level up, to the common parent, like this:
https://plnkr.co/edit/tQLO7sDeUweKEbCmWOVH?p=preview
Otherwise, the click event probably goes to the "wrong" hamburger, which is in the undisplayed inbox menu.
It works... somewhere offscreen. You just don't see it 😄

That makes sense, I will update how I am structuring my app accordingly.
I was worried it was a framework bug so sorry for posting something that in hindsight now should have gone to stack overflow first.
Thank you for the help.


Feature/key events

First draft of RawKeyboard events support. Only supporting the Android Keymap (and there is a major workaround), consider this as a preview feature.
fixes #136, we'll need new issue/PR to address the workaround.

Great feature! Some small suggestions but the rest looks good to add as experimental feature. Perhaps add a bit to the README about how this is still experimental and what is/is not supported.

GLFW's keyCodes are natively supported by the Flutter framework.
go-flutter only supports RawKeyEventDataLinux RawKeyEventData because the linux implementation is the only one to support the GLFW window toolkit.
Only keyDown & keyUp events are supported by the flutter framework, go-flutter matchs the same configuration.
Dart Code to test the feature

PTAL


Add provider combinator

Hello,
I created a pull request with a few minor improvements:

I created a rules combinator that allows multiple rule providers into one. This way you can e.g. combine the global PublicSuffix list with a local/private one.
I created a rule provider that reads its rules from a string of text. This way you can use hard-coded lists but also makes testing easy because there is no need to access files on the file system or connect to the global public suffix list.
I added Equals methods to TldRule to make rules better comparable (two rules with same Name property are considered equal)

I hope you like these enhancements and that you will merge them into a new version of your nice library.
Happy coding!
Merijn

Thanks for the pull request, currently I don't want to transfer the logic to the main project because this is a very special case.

Let me explain a bit further then:

I believe that the equality checking for TldRule is a general improvement that enables rules to be compared based on their name rather than on their physical objects. If you prefer, I can create a separate pull request for this.
The StringTldRuleProvider is good for testing because it enables tests without external dependencies on the remote tld provider and/or local files with rules.
I created the rule combinator for the not so very-specific case that a software system needs rules that are not yet available in the official public suffix list, rules that are not allowed to be added, or rules that are not intended for inclusion in the public list. Without the combinator, the only option I see is to duplicate the online public suffix list in a file. Add local rules to the file and use FileTldRuleProvider to access them. This, however, introduces a maintenance issue, because how to keep my local file in sync with the online list? With the combinator this is easy. I can put just my specific rules in the local file and use FileTldRuleProvider to access them. I combine these with the up-to-date online list using WebTldRuleProvider and TldRuleProviderCombinator.

If this doesn’t convince you, I can implement TldRuleProviderCombinator in my own codebase, of course. For that, I would still need, the equality checking functionality. So perhaps, could you consider at least accepting 1 (equality) and 2 (StringTldRuleProvider)?
If you need more info, just let me know!

This very special case is exactly my case. I want to combine the global suffix list with a small string list of my own.
Par example for myname.onmicrosoft.com I want the domain to be myname. I could easily use an if else statement, but this would make it so much cleaner.

Hi @tinohager,
Could you please respond to my explanation? Now that @wouter-b also asks for this functionality, my request becomes less special, I wold say ;-)

@merijndejonge  I will be in touch during the week I am currently sick

Thank you very much!


Working in fullscreen mode, when you switch to Zen and back you are returned to a windowed view

I normaly work with Atom (currently 0.194.0) in fullscreen. Then when working on a file I can cmd-ctrl-z (or cmd-ctrl-shft-f) to Zen (currently 0.12.1).
However, when I exit Zen with cmd-ctrl-z (or cmd-ctrl-shft-f) I am returned to a windowed view of Atom. This is quite annoying and rather spoils the point of Zen for me.

I have not been able to solve this reliably. What works for me is unchecking the "full screen" option for Zen, making the switch to full screen manual.

No sightings in a while. I will close this, if it crops up again let me know.


Assign to Team

Short Description:
It makes it able to choose a team when reaching level 5.
Not sure if it is still wanted since some may think it is better done manually.
As someone said before, if it doesn't feel right having this inside CompleteTutorial task, I can create a new task for this.
Haven't updated docs file since there were nothing about this task there, will do it later on in another PR.
Fixes/Resolves/Closes (please use correct syntax):

Closes #4691

👍

Uhhh ..... did the automerge not work?

👍

@solderzzc think it's broken :(

👍

@k4n30 let me try it..

Oh, @DeXtroTip  already fixed it.


No product self reference in product streams

1. Why is this change necessary?
When a customer views a product detail page it makes no sense to show this product in a linked product stream in the cross selling section.
2. What does this change do, exactly?
A new product stream condition + handler allows to remove articles from the product stream criteria. If a product stream gets loaded from the detail page the current article id will be automatically added as SkipProductIdCondition to remove the product from the stream.
The PR does not alter the behavior of product stream when loaded inside the emotion context.
3. Describe each step to reproduce the issue or behaviour.

Create a product stream and add it to a product that potentially appear in the stream.
Open the product page and look into the linked product stream. The currently open product will appear there.

4. Please link to the relevant issues (if any).
https://issues.shopware.com/issues/SW-16157
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hey @larsbo,
nice PR!
Yet, I'm afraid we can't merge this one, since you're slowing down the HTTP cache on the detail page.
Every detail page has its own product stream in the cache due to the additional parameter.
Feel free to create a new PR containing both the Condition as well as the ConditionHandler and everything necessary to configure the stream as necessary, but we can't use this filter as a default.


[WFLY-17876] Have the MicroProfile LRA subsystems fully clean up afte…

…r themselves
https://issues.redhat.com/browse/WFLY-17876

@xstefank Thanks. Yes, I did commit the logging.properties intentionally. The client-side test.log that produces was helpful in debugging this issue. Many of our ts modules have those.


How do you use it?

Managed to get it to compile but when I go to run it, the ECSProjectiles plugin will not load?
Give error 'failed to load because module 'ECSProjectfiles' could not be loaded.
I started with a blank top down project.
Any prerequisites?

A small sample project using this plug-in would be great.  Is that possible?

I got it to run once I got 'GameplayAbilities' plugin to stay enabled in my test project. So you can close this issue.
Although an small sample project is really needed to help anyone trying to use this figure out how it is suppose to be setup.

Would like to add to this, a README would be greatly appreciated.

I've been under the weather for a while so apologies for the late reply.
We've had too much trouble getting this to network smoothly and have much more important things to finish first before maybe coming back to work on this. I'll start writing a rough overview now.

I added a readme. Let me know if you have any other issues!


[Bug]: Plausible Analytics compose file mail service does not work on ARM

Error Message and Logs
Plausible Analytics compose file mail service does not work on ARM
exec /usr/local/bin/docker-entrypoint.sh: exec format error
On mail service logs
Steps to Reproduce

Use ARM-cpu based VPS
Try to launch Plausible with the provided compose file https://raw.githubusercontent.com/coollabsio/coolify/main/templates/compose/plausible.yaml

Example Repository URL
No response
Coolify Version
v4.0.0-beta.360
Are you using Coolify Cloud?
No (self-hosted)
Operating System and Version (self-hosted)
No response
Additional Information
No response

A fix for this issue has been implemented and will be available in an upcoming release. Thank you for your patience.

@peaklabs-dev
I still get the error with mail service
Saved configuration files to /data/coolify/services/p4woggskso4o8g4s48wskks8.
Creating Docker network.
3d28169aa8d531354247238bf24eae156bda65437911c0079223e5f8c78d2798
Starting service.
Pulling images.
 plausible-db Pulling
 plausible-events-db Pulling
 plausible Pulling
 mail Pulling
 plausible Pulled
 mail Pulled
 plausible-events-db Pulled
 plausible-db Pulled
Starting containers.
 Volume "p4woggskso4o8g4s48wskks8_plausible-postgres-data"  Creating
 Volume "p4woggskso4o8g4s48wskks8_plausible-postgres-data"  Created
 Volume "p4woggskso4o8g4s48wskks8_plausible-events-data"  Creating
 Volume "p4woggskso4o8g4s48wskks8_plausible-events-data"  Created
 Container mail-p4woggskso4o8g4s48wskks8  Creating
 Container plausible-db-p4woggskso4o8g4s48wskks8  Creating
 Container plausible-events-db-p4woggskso4o8g4s48wskks8  Creating
 Container mail-p4woggskso4o8g4s48wskks8  Created
 Container plausible-db-p4woggskso4o8g4s48wskks8  Created
 Container plausible-events-db-p4woggskso4o8g4s48wskks8  Created
 Container plausible-p4woggskso4o8g4s48wskks8  Creating
 Container plausible-p4woggskso4o8g4s48wskks8  Created
 Container plausible-events-db-p4woggskso4o8g4s48wskks8  Starting
 Container mail-p4woggskso4o8g4s48wskks8  Starting
 Container plausible-db-p4woggskso4o8g4s48wskks8  Starting
 Container mail-p4woggskso4o8g4s48wskks8  Started
 Container plausible-db-p4woggskso4o8g4s48wskks8  Started
 Container plausible-events-db-p4woggskso4o8g4s48wskks8  Started
 Container plausible-db-p4woggskso4o8g4s48wskks8  Waiting
 Container plausible-events-db-p4woggskso4o8g4s48wskks8  Waiting
 Container mail-p4woggskso4o8g4s48wskks8  Waiting
 Container mail-p4woggskso4o8g4s48wskks8  Error
 Container plausible-db-p4woggskso4o8g4s48wskks8  Healthy
 Container plausible-events-db-p4woggskso4o8g4s48wskks8  Healthy
dependency failed to start: container mail-p4woggskso4o8g4s48wskks8 is unhealthy

Logs from mail service
exec /usr/local/bin/docker-entrypoint.sh: exec format error

I still have the same issue with v4.0.0-beta.370 on arm64 VPS  😞

@lamtonylam I worked it around by editing the compose file and replacing the mail service image with image: navanchauhan/smtp, following this hint: https://github.com/BytemarkHosting/docker-smtp/issues/10#issuecomment-2408335168
It should be fine as soon as #4333 is fixed.

The problem here is that the SMTP image is outdated and does not have an arm version available. So the problem is with the SMTP image and not with Coolify. I will think of a solution because there are several ways to solve this - we could enable emulation so we can run AMD images on ARM (probably our best bet because it is Coolify related) or we could switch to an alternative mail server image. Maybe I will start maintaining and updated version of the outdated mail server (I know there was a few already but just to be sure). Will have to give this some thought over the weekend though. If you guys have other suggestions let me know.

Hi, I'd like to share a working setup of Plausible on ARM platform.
I just removed the email image from Docker compose entirely and added environment variables. Plausible can handle it by itself after setting up proper env vars.
Compose:
services:
  plausible:
    image: 'ghcr.io/plausible/community-edition:v2.1.4'
    command: 'sh -c "sleep 10 && /entrypoint.sh db createdb && /entrypoint.sh db migrate && /entrypoint.sh run"'
    environment:
      - SERVICE_FQDN_PLAUSIBLE
      - 'DATABASE_URL=postgres://${SERVICE_USER_POSTGRES}:${SERVICE_PASSWORD_POSTGRES}@plausible-db:5432/${POSTGRES_DB:-plausible-db}'
      - 'CLICKHOUSE_DATABASE_URL=http://plausible-events-db:8123/plausible_events_db'
      - 'BASE_URL=${SERVICE_FQDN_PLAUSIBLE}'
      - 'SECRET_KEY_BASE=${SERVICE_BASE64_64_PLAUSIBLE}'
      - 'TOTP_VAULT_KEY=${SERVICE_REALBASE64_32_TOTP}'
      - 'MAILER_ADAPTER=${MAILER_ADAPTER}'
      - 'MAILER_EMAIL=${MAILER_EMAIL}'
      - 'MAILER_NAME=${MAILER_NAME}'
      - 'SMTP_HOST_ADDR=${SMTP_HOST_ADDR}'
      - 'SMTP_HOST_PORT=${SMTP_HOST_PORT}'
      - 'SMTP_USER_NAME=${SMTP_USER_NAME}'
      - 'SMTP_USER_PWD=${SMTP_USER_PWD}'
      - 'SMTP_HOST_SSL_ENABLED=${SMTP_HOST_SSL_ENABLED}'
    depends_on:
      plausible-db:
        condition: service_healthy
      plausible-events-db:
        condition: service_healthy
    healthcheck:
      test:
        - CMD
        - wget
        - '--no-verbose'
        - '--tries=1'
        - '--spider'
        - 'http://<IP_ADDRESS>:8000/api/health'
      interval: 10s
      timeout: 5s
      retries: 5
      start_period: 45s
  plausible-db:
    image: 'postgres:16-alpine'
    volumes:
      - 'plausible-postgres-data:/var/lib/postgresql/data'
    environment:
      - 'POSTGRES_DB=${POSTGRES_DB:-plausible-db}'
      - 'POSTGRES_USER=${SERVICE_USER_POSTGRES}'
      - 'POSTGRES_PASSWORD=${SERVICE_PASSWORD_POSTGRES}'
    healthcheck:
      test:
        - CMD-SHELL
        - 'pg_isready -U $${POSTGRES_USER} -d $${POSTGRES_DB}'
      interval: 5s
      timeout: 20s
      retries: 10
  plausible-events-db:
    image: 'clickhouse/clickhouse-server:<IP_ADDRESS>-alpine'
    volumes:
      - 'plausible-events-data:/var/lib/clickhouse'
      -
        type: bind
        source: ./clickhouse/clickhouse-config.xml
        target: /etc/clickhouse-server/config.d/logging.xml
        read_only: true
        content: '<clickhouse><profiles><default><log_queries>0</log_queries><log_query_threads>0</log_query_threads></default></profiles></clickhouse>'
      -
        type: bind
        source: ./clickhouse/clickhouse-user-config.xml
        target: /etc/clickhouse-server/users.d/logging.xml
        read_only: true
        content: '<clickhouse><logger><level>warning</level><console>true</console></logger><query_thread_log remove="remove"/><query_log remove="remove"/><text_log remove="remove"/><trace_log remove="remove"/><metric_log remove="remove"/><asynchronous_metric_log remove="remove"/><session_log remove="remove"/><part_log remove="remove"/></clickhouse>'
    ulimits:
      nofile:
        soft: 262144
        hard: 262144
    healthcheck:
      test:
        - CMD-SHELL
        - 'wget --no-verbose --tries=1 -O - http://<IP_ADDRESS>:8123/ping || exit 1'
      start_period: 30s

Env variables (Resend SMTP in my case; 587 due to Hetzner)
MAILER_ADAPTER=Bamboo.Mua
MAILER_EMAIL=<valid sender email>
MAILER_NAME=Plausible Analytics
SMTP_HOST_ADDR=smtp.resend.com
SMTP_HOST_PORT=587
SMTP_USER_NAME=resend
SMTP_USER_PWD=<api key>
SMTP_HOST_SSL_ENABLED=false

Maybe it helps with #4333 as well.


No api definition file specified

Hi,
Thanks for the tutorial and repo.
Initially I followed the tutorial, but I grabbed the scripts to make things easier. However it took we a while to figure out the folder structure to make it work. Would be great if that could added to the tutorial.
Also the script needs to be run from two folders up. Initially I tried adding it as a build phase, which would have been ideal.
The model file in the swift project isn’t mentioned in the tutorial also.
And there’s a single view in the swift project which isn’t mentioned in the tutorial.
However the main issue I’m having is the “no api definition file specified” build error, which occurs in the tutorial code and the from the code in repo.
After googling for a while without success, I did follow this post, which seems like it should have worked...
https://forums.xamarin.com/discussion/78921/no-api-definition-file-specified
But it didn’t fix the issue for me.
Can you help with this?
I’m using the latest Xamarin libraries etc. If you would like any more details please let me know.
Thanks in advance.
Jules.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b3f999ec-a80b-03fe-35a3-2fbab83f473b
Version Independent ID: 0ba06308-6882-2a8c-81b8-e76ccad72527
Content: Walkthrough: Bind an iOS Swift library - Xamarin
Content Source: docs/ios/platform/binding-swift/walkthrough.md
Product: xamarin
Technology: xamarin-ios
GitHub Login: @alexeystrakh
Microsoft Alias: alstrakh

Thanks for submitting an issue and we apologize for the delayed response. The requested updates haven't been made since the creation of the issue, and the timeline for resolution may vary based on resourcing, so the issue is being moved to an internal repo to better track it.


Performance & Bugs Question

Is this software buggy?
Difference towards paper?
Can i move from paper to Dionysus?

I also had plugins, and idk if they'd work

From personal observation, I can say that it is better than any other. All plugins that support java 17 will work

Well, plugins would work on Java 8? As most of them wont even work past Java 11

It includes protocolsupport, viaversion, etc.

We have been using ViaVersion perfectly fine. Java 17 allows loading plugins made for Java 1.8, 11, 16 and more.
What Softik was referring to is that some plugins use code that only works on Java 1.8, but those cases are rare.

Sure, I will try in 1 hour and ill tell you if it works fine, as i want to move from paper to this one, since its for a unic-server network

I also tried it without plugins and help very well the ram and cpu usage,also that the tps was above expected after mild mob spam and tnts (19.90), paper would've died a bit

All seems to work nominal! TY


BUG: retrieve condition for entity or account that does not exist

Actual behaviour
Current reponse when retrieving a condition for an entity / account that does not exist

Expected behaviour
If the entity does not exist in the entities collection in the pseudonyms DB, return an error "Entity does not exist in the database"
OR
If the account not exist in the accounts collection in the pseudonyms DB, return an error "Account does not exist in the database"
https://github.com/tazama-lf/event-flow/issues/3

tested


Slack Dev community page is locked

The slack dev page is link is locked. I can't request an invitation

Yes you are right. Neither can I.


Make pyalarmdotcom available on PyPi

It would be nice if you make pyalarmdotcom available on PyPi. Thanks.

Is now on Pypi with the new async stuff.


adding prompt for pw but not supplied

Adding prompt for missing pw to match legacy version of sqlcmd.  Changed the behavior of setting the params passed into ConnectDb() so please take a close look there.  Attempting to clarify behavior of the optional params and corresponding matching env vars.

no longer needed


Please remove Guava as a dependency

The Harness feature flag SDK should be easy to add to projects without causing extra difficulty in adopting it. Guava is known to evolve rapidly in ways that aren't always the most compatible. This becomes extra hard when it is brought in as a transitive dependency by libraries.
In attempting to adopt the Harness Java SDK, I've run into this very issue where a project is relying on another library (docx4j) that is relying on Guava v15.
Also the Guava library is 3mb in size. (Not a particularly tiny jar)
In analyzing the Guava usage in the SDK I see it being used for 2 primary places:

Checking if strings are empty
Running the Async work in the background.

Both of these items are relatively trivial to implement in the SDK directly. Would PRs for these changes be accepted?

Hi,
Guava was removed as part of SDK release 1.3.0 - please give this version a try
Andrew


Fix display on new Versa 3 and Sense squircle faces

Currently needs enabling from within package.json

OS 5.0 will not be released to older devices (Versa,Versa2,Ionic).  Therefore, we will need to make two separate projects.  Many resources should be shared between the two projects to make development of these two separate watchfaces easier.

I've tidied up the sizing of all the shapes.  Cannot get the steps and calorie images to move left far enough.
Also added comma's into the steps number (struggling with the calories) for when they tip over 1,000.
Added a new date format, and tidied up the spacing on the others.

Awesome work.  I'm happy to take a look at a PR when you're ready @RichardUmney1 👍

Awesome work.  I'm happy to take a look at a PR when you're ready @RichardUmney1 👍


ZarrSource doesn't support Stores

Current Gunpowder ask for Zarr path in order to get the data. Which limite the use cases.
E.g:

Remote data
A new Zarr Store

I think it will be more useful to have Zarr Store input instead of Zarr Path https://github.com/funkey/gunpowder/blob/773b5578b01d16d34ef3cc466904ab876bba8bf1/gunpowder/ext/zarr_file.py#L11
And relay on Zarr to provide the data
@funkey

it does now, thanks Marwan :)


[FR.] Record kafka header(s) and show in call tree.

Which module is your feature request related to?
Plugin
A PR would be made later to resolve this issue.

@ga-ram Thanks for the polishing/update.


Negative lx and ly - check quadrats

@briannakcalkins @jenajordan @teixeirak  When Valentine recalculated the local coordinates, some trees had a negative y coordinate. It is likely these trees may be assigned to the wrong quadrat. Would it be worthwhile to check the quadrats of these stems?
negative_local_coordinates.xlsx

We could do that, yes. Btw, I started on the mortality census in the deer exclosure this past week. There seemed to be some stems <10 cm noted in FF (I did not measure DBH),& a few > 10 cm not in the census, & there was an unusual # of stems I could not find there - in the 4 quads I did.

I think we can closing this (not sure the trees were visited to check their quadrat and/or coordinates but we are not going to deal with this here).


Ft/model validation

FEATURE DESCRIPTION
TASK

Add the following validations:

For the User model:

Name must not be blank.

PostsCounter must be an integer greater than or equal to zero.

For the Post model:

Title must not be blank.

Title must not exceed 250 characters.

CommentsCounter must be an integer greater than or equal to zero.

LikesCounter must be an integer greater than or equal to zero.

Add unit specs for all of your models' methods and validations.

Hi @Bateyjosue ,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request 🛑 💀
You have submitted a project, that has a Future Features section missing. Kindly add it and include 1-3 potential features to be added. Also, consider removing placeholder text in the readme.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Invalid Code Review Request does not count into the code reviews limit.


trying to make the pep8 test in TravisCI happy

trying to make the pep8 test in TravisCI happy, even though I thought this was msoucy's code already merged?

Finally.

You should really try running the tests locally with tox, then you don't have to show us how much pep-bowing was required. :100:
$ pip install tox
$ tox

For discussion reference, here's the graph embedded because github, presumably for "reasons" doesn't display SVGs.

Is the box the instructor computer? Labels would help (on what an arrow means, on what the box is, etc). I think it'd be helpful to label arrows like "fork," "pull request," and "git-deploy" to indicate the different relationships.

Could you rebase away your PEP8 related changes? Aside from the fact that they are now fixed, it doesn't make sense to include those in with this workflow diagram.

Yeah, that's what I thought.
I have no idea why code I didn't touch at all in any of this, and that
didn't change while I was doing any of this work, should start causing any
trouble.
On Tue, Feb 02, 2016 at 10:08:14AM -0800, Liam Middlebrook wrote:

Could you rebase away your PEP8 related changes? Aside from the fact that they
are now fixed, it doesn't make sense to include those in with this workflow
diagram.
—
Reply to this email directly or view it on GitHub.*

--
Joe   On ceding power to tech companies: http://xkcd.com/1118/
man screen | grep -A2 weird
A weird imagination is most useful to gain full advantage of
all the features.

Which is to say, if you can explain to me why PEP8 test was blocking my pull
request over errors in calendar code that was not part of my pull request and
that was, as best I can tell, submitted some time ago by soucy and accepted
into the repo, then maybe I'll have some idea as to why this happened and
what the next appropriate move might be.
In other words, I didn't do so I don't know how to fix it.  If you think you
do, then, as they say, patches welcomed.
--
Joe
On Tue, Feb 02, 2016 at 06:49:08PM +0000, D. Joe wrote:

Yeah, that's what I thought.
I have no idea why code I didn't touch at all in any of this, and that
didn't change while I was doing any of this work, should start causing any
trouble.
On Tue, Feb 02, 2016 at 10:08:14AM -0800, Liam Middlebrook wrote:

Could you rebase away your PEP8 related changes? Aside from the fact that they
are now fixed, it doesn't make sense to include those in with this workflow
diagram.
—
Reply to this email directly or view it on GitHub.*

--
Joe   On ceding power to tech companies: http://xkcd.com/1118/
man screen | grep -A2 weird
A weird imagination is most useful to gain full advantage of
all the features.

--
Joe   On ceding power to tech companies: http://xkcd.com/1118/
man screen | grep -A2 weird
A weird imagination is most useful to gain full advantage of
all the features.

Fixed & now available on develop

Sorry about this. Strange that it wasn't caught sooner, my apologies.


Should Serialize::serialize be able to fail?

Deserializations can fail, because input data can often come from a wide range of sources and it can vary in a lot of ways. Serializations, on the other hand, almost always can't, at all, because internal structs have well known and well maintained invariant. I worry that this API will almost always just amount to an unexplained unwrap with no documented panic conditions.
What're the use cases for this? When should implementations be allowed to sometimes fail to serialize according to runtime conditions? Is that really useful?
When I searched the issue history for previous discussions, I did seem to come across one single possible use case, apparently Paths can't always serialize straightforwardly if they aren't valid unicode, but it looks like the project responded to that by just escaping the Path in those cases (as you should) and again the Result wrapping is redundant and meaningless and the serialization cannot possibly fail.
So I guess my question is are there plans to change the signature from serialize -> Result<T> to serialize -> T come 1.0.0?

well, your serialization target may not accept any more bytes... Or it might be invalid to serialize floats to the target format...

it would be nice to capture all that in the type system, but there's a long way to go until the error messages become useful enough to start doing that kind of associated type magic

Just out of curiosity, could you link me to any discussions of the problems with error reporting that would make this unergonomic? If not, any keywords so I can find it?

Even if the serialization format can handle anything you give it, the serializer is going to be writing into something (e.g. File or TcpStream), and that operation can fail.

In other words, it's not the serialization itself that can fail, but the process of writing the result that can fail? That makes sense -- the std::fmt traits make the same assumption.

std::fmt is a good analogy.


Update Database.Tests.ps1

Something wasn't right with the += and passing it into SMO to filter out the exlcuded databases lists on these 3 from what I was seeing.
Switching to $ExcludedDatabases = $ExcludedDatabases + ... worked a treat, still strange though
A New PR
THANK YOU - We love to get PR's and really appreciate your time and help to improve this module
Accepting a PR
Before we accept the PR - please confirm that you have run the tests locally to avoid our automated build and release process failing. You can see how to do that in our wiki
https://github.com/sqlcollaborative/dbachecks/wiki
Please confirm you have 0 failing Pester Tests
[] There are 0 failing Pester tests
Changes this PR brings
Please add below the changes that this PR covers. It doesnt need an essay just the bullet points :-)

Whoops forgot to rebranch
New file added to the PR to fix bug 783

So my Git messed up and lost a load of stuff locally so I had to redo the PR.
This PR can be closed as the changes are now in PR784


[Question] -- Beginner : Error in 'make build' from sources

Am following the detailed steps given in this page:
https://warehouse.readthedocs.io/development/getting-started/#detailed-installation-instructions
Am working on building warehouse from sources in AWS using Amazon Linux Image.

In the first run of 'make build' it failed with this error. In the 2nd run, however, it passed thru' this stage.

ERROR: Service 'app' failed to build: The command '/bin/sh -c set -x     && apt-get update     && apt-get install inotify-tools wget bzip2 gcc g++ make libpq-dev libjpeg-dev libffi-dev --no-install-recommends -y     && rm -rf node_modules     && wget https://saucelabs.com/downloads/sc-4.3.14-linux.tar.gz -O /tmp/sc.tar.gz     && tar zxvf /tmp/sc.tar.gz --strip 1 -C /usr/     && chmod 755 /usr/bin/sc     && npm install -g phantomjs-prebuilt gulp-cli     && npm install     && pip install -U pip setuptools     && pip install -r requirements/dev.txt                    -r requirements/tests.txt     && pip install -r requirements/deploy.txt                    -r requirements/main.txt     && find /usr/local -type f -name '.pyc' -name '.pyo' -delete     && rm -rf ~/.cache/     && apt-get purge bzip2 gcc g++ make libpq-dev libffi-dev -y     && apt-get autoremove -y     && apt-get clean     && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*' returned a non-zero code: 1 make: *** [build] Error 1

Next step was to start 'make initdb' but this too failed with errors on multiple runs, while trying to update SQL table with SQL connection timeout errors (it was running to multiple lines). Are these known issues with possible resolutions ?

File "/usr/local/lib/python3.5/site-packages/elasticsearch/client/utils.py", line 69, in _wrapped
return func(*args, params=params, **kwargs)
File "/usr/local/lib/python3.5/site-packages/elasticsearch/client/indices.py", line 200, in delete
params=params)
File "/usr/local/lib/python3.5/site-packages/elasticsearch/transport.py", line 329, in perform_request
status, headers, data = connection.perform_request(method, url, params, body, ignore=ignore, timeout=timeout)
File "/usr/local/lib/python3.5/site-packages/elasticsearch/connection/http_urllib3.py", line 105, in perform_request
raise ConnectionError('N/A', str(e), e)
elasticsearch.exceptions.ConnectionError: ConnectionError(<urllib3.connection.HTTPConnection object at 0x7f3580214d68>: Failed to establish a new connection: [Errno 113] No route to host) caused by: NewConnectionError(<urllib3.connection.HTTPConnection object at 0x7f3580214d68>: Failed to establish a new connection: [Errno 113] No route to host)
make[1]: *** [reindex] Error 1
make[1]: Leaving directory `/home/ec2-user/github/warehouse'
make: *** [initdb] Error 2
TIA,
/Ram

One thing that I'm not sure is obvious, when you're running make initdb it's assumed that you already have make serve running.

Do you mean run 'make server', then go over for 'initdb' ?
Just now tried running, 'make build' (3rd iteration), this time around, it's an reindex error:
docker-compose run web python -m warehouse search reindex
{"level": "INFO", "thread":<PHONE_NUMBER>58016, "logger": "raven.base.Client", "event": "Raven is not configured (logging is disabled). Please see the documentation for more information."}
{"level": "INFO", "thread":<PHONE_NUMBER>58016, "logger": "urllib3.connectionpool", "event": "Starting new HTTP connection (1): elasticsearch"}
. . . . . .
. . . . . .
{"level": "INFO", "thread":<PHONE_NUMBER>77248, "logger": "elasticsearch", "event": "POST http://elasticsearch:9200/_bulk [status:200 request:1.063s]"}
make[1]: *** [reindex] Error 137
make[1]: Leaving directory `/home/ec2-user/github/warehouse'
make: *** [initdb] Error 2

You'll need two terminals open, one running make serve, and one for you to do things like make initdb in.

IOW, make serve is a persistent process that is running the web site, the DB server, etc.

Huh, something is already bound to port 80 for you. I'm not sure what Amazon Linux has running in it though that might already be binding to that port.

I'm going to close this issue - @mramanathan I hope this issue has been resolved for you.
If you need any further help, please speak to us on pypa-dev on freenode :)


v1.8 backport 2020-09-16

v1.8 backports 2020-09-16
There were some conflicts, so please have a look. Notes below.

#13120 -- logging_fix: Adding logs in a structured way (@chowmean)
#12694 -- Fix clustermesh policy with endpoint-routes mode (@joestringer)
#13135 -- Reduce operator memory usage when CNP status updates are disabled (@joestringer)

had to resolve some conflicts since files have diverged between the two versions

#13153 -- Report correct target system architecture in Cilium version (@tklauser)
#13141 -- operator: fix invocation with --help option (@tklauser)

conflict on original commit d570daaf06075d1d599bdbd061d22a3be7a08bbc resolved by omitting change in daemon/cmd/daemon_main.go since the corresponding line does not exist (edit: moved on the correct PR) NOTE: The changes of #13141 were dropped from this backport PR to be picked up later.

#13095 -- docs: Removing wrong options from azure IPAM documentation.  (@chowmean)
#13159 -- docs/minikube: Update the step for minikube 1.12.1+ (@sayboras)

conflict on bb9411bdc264dc435e90c87f12106c67babcfbf6 resolved by changing BPF to eBPF since #12836 was not backported.

#13150 -- pkg/datapath: Remove unused feature maps (@brb)

conflict on f191f9eed4b9ab1d09c4bd8a6bf2456011acea52 resolved by including lbmap package and ignoring lines added by #13131 which was not backported (CC: @borkmann @joestringer @pchaigno)

#13049 -- bpf: Fix host firewall in presence of kube-proxy masquerading (@pchaigno)

conflicts on 31357599ff3486b6d9b1164485f2a86ac1603bd2 resolved by including changes in lock-down-dev-vms.yaml and omitting changes in examples/policies/host/lock-down-gke.yaml since file does not exist in v1.8.

Once this PR is merged, you can update the PR labels via:
$ for pr in 13120 12694 13135 13153 13095 13159 13150 13049; do contrib/backporting/set-labels.py $pr done 1.8; done

test-backport-1.8

#13153 -- Report correct target system architecture in Cilium version (@tklauser)
conflict on original commit d570daa resolved by omitting change in daemon/cmd/daemon_main.go since the corresponding line does not exist

I think this comment should instead belong to

#13141 -- operator: fix invocation with --help option (@tklauser)

Indeed, apologies.

instead? Regarding commit d570daa: it looks like this didn't apply because #12675 wasn't backported. I've now marked it as needs-backport/1.8 and maybe you could pick it up for this backport PR before the PR above, so the conflict would go away?

How about, I remove #13141 from this PR so that we can pick it up on the next backport round with #12675? This solution seems simpler to me... I can do another backport round tomorrow.

@kkourt Is there time left to get  #13175 in ?

@kkourt Is there time left to get #13175 in ?

#13175 does not seem to have been merged on master yet, so I'm afraid it cannot be backported. Once it is merged on master it can be picked up by a backport.

instead? Regarding commit d570daa: it looks like this didn't apply because #12675 wasn't backported. I've now marked it as needs-backport/1.8 and maybe you could pick it up for this backport PR before the PR above, so the conflict would go away?

How about, I remove #13141 from this PR so that we can pick it up on the next backport round together with #12675? This solution seems simpler to me... I can do another backport round tomorrow.

Indeed, that sounds like the simpler solution. Let's drop #13141 from this PR.

As per discussion above, I dropped #13141 (and updated its labels) so that it can be picked up together with #12675.
@tklauser since #13141 is labeled for backport on v1.7, should we mark #12675  also as needs-backport/1.7?

As per discussion above, I dropped #13141 (and updated its labels) so that it can be picked up together with #12675.

Thanks!

@tklauser since #13141 is labeled for backport on v1.7, should we mark #12675 also as needs-backport/1.7?

Good point, marked it as needs-backport/1.7.

test-backport-1.8

test-upstream-k8s


Processed data files

Files in processed data folder 01_ 02_ and 03 do not seem match files generated when 01, 02_, 03_ scripts re-run from scratch. Do the updated processed data files just need to be pushed, or is this symptom of something else?
I noticed this working on MB1B - there seem to be duplicate trial pairs in processed_data/03_data_trial_main.csv pulled from repo, but not when same file is generated from the script.

Not sure where this crept in, but all files are regenerated in the current build


Improve readability, extendability and composability of result custom transformations (pipe API)

Hello !
We have started using neverthrow at my company and we are very happy with the lib :) It helps us a lot making our code safer and predictable :)
After using it for quite some time, we realised that we were missing a feature that would alllow us to write our custom operators to transform results with a nice syntax. We could extend the Result class but then we would have to rewrite most of the result functionality to return our extended result. So we wrote some utils functions to transform our results.
For example, we do a lot of error translations, so we wrote this function:
function staticMapError<T, E1 extends string, E2>(r: Result<T, E1>, map: Record<E1, E2>): Record<T, E2> {
    return r.mapErr(e => map[e]);
}

// usage

const result = err('hello' as const);

const translatedErrorsResult = staticMapError(result, { hello: 'bonjour', bye: 'aurevoir' });

console.log(translatedErrorsResult._unsafeUnwrapErr()); // 'bonjour'

That is good enough, but when we have to chain multiple transformers, this becomes unreadable very fast. Example :
nullAsError(staticMapError(result, { hello: 'bonjour', bye: 'aurevoir' }))

We use rxjs a lot in out applications, so by taking example on their .pipe() method on observables, we imagined a similar API for Result.
Here is an example of what this API could look like :
// without the pipe API
nullAsError(
   staticMapError(
     result,
     { hello: 'bonjour', bye: 'aurevoir' }
    )
)

// with the pipe API
result.pipe(
   nullAsError,
   staticMapError({ hello: 'bonjour', bye: 'aurevoir' })
)

This is much more readable as all operators are on the same level, and you read them in the order in which they are applied. pipe would await operator functions that are simply functions that take a result as an input and return a new result.
A similar API could be defined on ResultAsync.
I kept the examples simple here, so we could imagine solutions to avoid using my functions here and simply using map or mapErr, but the more complex the operators, the more beneficial the pipe API becomes.
This API would allow users that have specific needs to implement their own operators without relying on the neverthrow contributors to implement them. Also, most of these operators wouldn't make sense for most users, so it would be a bad idea to add them on the result class.
I would love to get your thoughts about this ! I could provide a PR that implements that, but I would maybe need a bit of help for writing some complex types :)
Thanks !

This seems like a great idea to me. There are a lot of features I've wanted, but the only convenient way to implement them with a nice syntax is by adding methods to the Result/ResultAsync classes. We could almost drop in rxjs's pipe, the only tricky thing is how to handle sync/async. Would we just allow each operator to both take and return any subtype of either Result or ResultAsync?


How to remove an item from FastItemAdapter without click event?

How can I remove/update an item from the adapter which is initiated by something else than a click or touch? Should I use the CustomEventHook? Do you have an example of how to use the CustomEventHook?
Example: I now have this in the bindView() of the AbstractItem, because I do not know how to hook these events in the Fragment that has a FastItemAdapter with this AbstractItem.
    holder.editText.addTextChangedListener(new TextWatcher() {
        @Override
        public void beforeTextChanged(CharSequence s, int start, int count, int after) {

        }

        @Override
        public void onTextChanged(CharSequence s, int start, int before, int count) {

        }

        @Override
        public void afterTextChanged(Editable s) {
                // make async call
        }
    });

    holder.editText.setOnEditorActionListener(new TextView.OnEditorActionListener() {
        @Override
        public boolean onEditorAction(TextView v, int actionId, KeyEvent event) {

            if (actionId == EditorInfo.IME_ACTION_DONE) {
                // make async call
                return false;
            }
            return false;
        }
    });

    private void onResponse(JSONObject response) {
                // update item and notify item changed in adapter, but how?
    }

@echthard I am not 100% sure about your question. Do you want to remove an item / modify it in the list?
Or do you want a click listener on something else than the whole itemView?

Do you want to remove an item / modify it in the list?

Yes

Or do you want a click listener on something else than the whole itemView?

No, I don't have a click event. I have an EditText per row in the list. In other words, I have an EditText per item in the adapter. Let's say it is a shopping list and the EditText holds the quantity. When the quantity is 0, the item should be removed. If the quantity is changed, a different view that also holds the quantity shoud be updated with the new value that comes from the EditText.
The EditText becomes visible when I click on an ImageView, when the EditText becomes invisible, then the event of updating the item will take place.
This event could be a Timer that fires after 3 seconds, but will ignore and restart if the soft keyboard is visible. The event can be when I scroll, then I will hide the EditText. Or the event can be when I click the DONE button on the soft keyboard.

@echthard ok I see. It is a question in 2 parts :D
So first. Deleting an item is very easy. You just call the remove method on the ItemAdapter which hosts your elements: https://github.com/mikepenz/FastAdapter/blob/develop/library-core/src/main/java/com/mikepenz/fastadapter/adapters/ItemAdapter.java#L428 this will take care of the notifying for you.
as for the second part. Basically you have to think of the EventHooks to be normal listeners which you set on a view. But as the RecyclerView is reusing views this had to be solved a bit more clever, so we don't spawn many many unnecessary listeners in the bindView method. And to allow the programmer to have this logic in his activity / fragment I provide the EventHook
So for your case you will need to have a CustomEventHook and a ClickEventHook
As the sample item's event hooks do not need any reference to the activity they were implemented as static classes inside the item. But you can also have it as anonymous class in the activity.
So that's how you provide a eventHook to your FAstAdapter;
https://github.com/mikepenz/FastAdapter/blob/7bc4b381dde839eb230dbaf2c1e4ec61b6579d1c/app/src/main/java/com/mikepenz/fastadapter/app/CheckBoxSampleActivity.java#L69
And the EventHook itself looks like this:
https://github.com/mikepenz/FastAdapter/blob/a060aca5105eda89d02cced1a7da6e20077dba2f/app/src/main/java/com/mikepenz/fastadapter/app/items/CheckBoxSampleItem.java#L143
It basically needs to know when it's bound to the view
and what will happen in onClick
As there is no TextWatcherEventHook you will have to use the CustomEventHook class.
It basically works the same, you tell it in onBind when he should use the EventHook and in onEvent you have the view in this case which allows you to set the TextWatcher on it

Well it's not really 2 parts, I understand how to update/remove an item in the adapter. I already have ClickEventHooks working, but I now have the other "event" handled in the bindView() of the item. There is obviously no adapter there in the item, so I can't update/remove items in the adapter.
I tried to implement the CustomEventHook, but I still don't understand what to do in the onBind.
Let my try to rephrase my example. The trigger/event is when a ViewGroup's visibility becomes View.GONE. Is it possible to create a CustomHookEvent on that?
FYI: The ViewGroup will be hidden when the Timer runs, when I scroll in the Recyclerview or when the DONE button on the soft keyboard will be tapped. So 3 ways to hide the ViewGroup.
You said

you tell it in onBind when he should use the EventHook

But how can I do that? In your ClickEventHook example it is like:
@Override
        public View onBind(@NonNull RecyclerView.ViewHolder viewHolder) {
            if (viewHolder instanceof CheckBoxSampleItem.ViewHolder) {
                return ((CheckBoxSampleItem.ViewHolder) viewHolder).checkBox;
            }
            return null;
        }

But how would this look like for a CustomHookEvent? If i pass the ViewGroup instead of checkBox, then it's not mentioned that it should only occur when the ViewGroup becomes hidden.
Maybe it's not possible to hook an event on a view's visibilty change. Then I should probably hook the same event on the 3 ways that initiates that change.

@echthard but some logic will adjust the visibility of this view somewhere. Something must tell the view next time it will be hidden. So there must exist some logic somewhere And this logic should already handle this. There is only a evenHook for UI interaction like, touch, click, longclick.
Everything else is triggered by something else and you can interact with it at this point.
So you wrote there are 3 ways this happens. so you have to write your logic and hook it into those 3 places.
There shouldn't be the logic anyways directly inside the Item, as this will cause huge troubles during scroll. You should do this outside the item, outside the adapter

If this is still an issue report back to re-open