Workaround IME composition bug in Chrome v55 and v56

Bug in Chrome v55 and v56: compositionupdate .data is broken so in these two versions of Chrome, in composition state, unconfirmed text of CJK IME collapse to one character:

Electron shipped their latest version with Chrome v56 so anyone who is adopting the latest version of Chrome can run into this IME bug. We already fixed that for editor in VS Code https://github.com/Microsoft/vscode/issues/24557 but we may still want to fix this in xterm.js for Integrated Terminal.

Coverage decreased (-0.09%) to 68.723% when pulling 3c7e6308295611e1a1d883f3e29f96912b0f0bb8 on rebornix:IME into 18a9f056269f0e0da707b66e4b66a1883475cfba on sourcelair:master.

The last commit fixed https://github.com/sourcelair/xterm.js/issues/634. Whenever we don't trust the composition update from browser, we have to get the correct composition text/state from textarea. It's not perfect but it works.

Coverage decreased (-0.08%) to 68.73% when pulling 376467d74a16167373c39915e1b3bbd1e74c920e on rebornix:IME into 18a9f056269f0e0da707b66e4b66a1883475cfba on sourcelair:master.

Coverage decreased (-0.08%) to 68.73% when pulling a223d055a2a0a6c5fc377a9ef0bb34dad6a521c7 on rebornix:IME into 2674258ead60796b551ebe82eed3862ed3331089 on sourcelair:master.

Coverage decreased (-0.08%) to 68.73% when pulling 6731c460d53dcf86671c230d371da573567ab720 on rebornix:IME into 2674258ead60796b551ebe82eed3862ed3331089 on sourcelair:master.

As discussed in person we'll close this off since it introduces other regressions. We'll just live with the bug in Chrome 55/56 https://bugs.chromium.org/p/chromium/issues/detail?id=677050&can=1&q=blink component%3ABlink>Editing>IME &colspec=ID Pri M Stars ReleaseBlock Component Status Owner Summary OS Modified


Update wd_demo.au3 - DriverParams direct port definition

Pull request
Proposed changes
Port should be direct defined in DriverParams
Checklist

[x] I have read and noticed the CODE OF CONDUCT document
[x] I have read and noticed the CONTRIBUTING document
[ ] I have added necessary documentation or screenshots (if appropriate)

Types of changes

[x] Bugfix (change which fixes an issue)
[ ] Feature (change which adds functionality)
[ ] Code style update (formatting, renaming)
[ ] Refactoring (functional, structural)
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?
chomium based browser not starting
What is the new behavior?
now its starts properly
Influences and relationship to other functionality
none
Additional context
https://www.autoitscript.com/forum/topic/212201-chromedriver-issues-august-2024
https://chromium.googlesource.com/chromium/src/+/6f33d75f071e322c4a3e49b0a4ac2022e5b6cada
System under test
MSEdge, Chrome

Needs some minor tweaks. See comments.

I hope I got it all sorted out


fix(tests): shorter service names in connection secret tests

Max length for Aiven service names is 64 characters

tests


Polymer Hybrid Element Compliant.

Fixes #40

This change is

Review status: 0 of 13 files reviewed at latest revision, 6 unresolved discussions.

.travis.yml, line 9 at r1 (raw file):

  directories:
    - bower_components
    - node_modules

We still want to cache node_modules

package.json, line 3 at r1 (raw file):

{
  "name": "vaadin-split-layout",
  "version": "2.0.0-preview",

This should probably be 1.0.0

vaadin-split-layout.html, line 153 at r1 (raw file):

```html
<custom-style>
  <style is="custom-style">

If P1.7 supports <custom-style>, is=custom-style is no longer needed

vaadin-split-layout.html, line 275 at r1 (raw file):

        children.filter(function(child) {
          if (child.classList.contains('splitter-handle')) {
            Polymer.dom(child).setAttribute('slot', 'handle');

Side effects in filter function feels wrong

wct.conf.js, line 16 at r1 (raw file):

        'Windows 10/firefox@50',
        'Windows 10/microsoftedge@14',
        // 'Windows 10/internet explorer@11',

We can't disable testing these browsers with P1. Maybe we also need wct.conf-2.0.js or something?

demo/custom.html, line 29 at r1 (raw file):

    <demo-snippet>
      <template>
        <style is="custom-style">

 wrapper needed

Comments from Reviewable

Review status: 0 of 13 files reviewed at latest revision, 8 unresolved discussions.

.travis.yml, line 9 at r1 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
We still want to cache node_modules

Removing just Bower cache will solve your issue with Travis caching https://github.com/vaadin/vaadin-element-skeleton/pull/10
Please revert npm cache, it has some heavy deps and cachimg them will speed up build.

gulpfile.js, line 35 at r1 (raw file):

});

gulp.task('test', ['lint'], function(done) {

You're now using this task in Travis, I'm wondering why it was added?

wct.conf.js, line 1 at r1 (raw file):

var args = require('yargs').argv;

yargs dependency should be  also removed from package.json as we're not using it anymore.

Comments from Reviewable

Review status: 0 of 13 files reviewed at latest revision, 8 unresolved discussions.

.travis.yml, line 9 at r1 (raw file):
Previously, limonte (Limon Monte) wrote…
Removing just Bower cache will solve your issue with Travis caching https://github.com/vaadin/vaadin-element-skeleton/pull/10
Please revert npm cache, it has some heavy deps and cachimg them will speed up build.

Done.

gulpfile.js, line 35 at r1 (raw file):
Previously, limonte (Limon Monte) wrote…
You're now using this task in Travis, I'm wondering why it was added?

It's a convenience method for local testing.
I run this frequently, and it is already in other components. Is it there any impact to leave this here?

package.json, line 3 at r1 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
This should probably be 1.0.0

Done.

vaadin-split-layout.html, line 153 at r1 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
If P1.7 supports <custom-style>, is=custom-style is no longer needed

It's still needed, try to remove the is attribute in custom.html line 165, and you can see that fill colours do not change.

vaadin-split-layout.html, line 275 at r1 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
Side effects in filter function feels wrong

what do you mean? do you prefer another forEach before filtering? or I'm misunderstanding?

wct.conf.js, line 1 at r1 (raw file):
Previously, limonte (Limon Monte) wrote…
yargs dependency should be  also removed from package.json as we're not using it anymore.

Done.

wct.conf.js, line 16 at r1 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
We can't disable testing these browsers with P1. Maybe we also need wct.conf-2.0.js or something?

Done.

demo/custom.html, line 29 at r1 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
 wrapper needed

ops, Done.

Comments from Reviewable

Review status: 0 of 14 files reviewed at latest revision, 8 unresolved discussions.

gulpfile.js, line 35 at r1 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
It's a convenience method for local testing.
I run this frequently, and it is already in other components. Is it there any impact to leave this here?

No, I'm totally ok with it, just question :) Thanks!

Comments from Reviewable

Review status: 0 of 14 files reviewed at latest revision, 6 unresolved discussions.

Comments from Reviewable

Review status: 0 of 14 files reviewed at latest revision, 3 unresolved discussions.

bower-2.0.json, line 30 at r2 (raw file):

    "iron-demo-helpers": "polymerelements/iron-demo-helpers#2.0-preview",
    "iron-test-helpers": "PolymerElements/iron-test-helpers#2.0-preview",
    "test-fixture": "PolymerElements/test-fixture#custom-elements-v1",

Tag/branch custom-elements-v1 does not exist

vaadin-split-layout.html, line 275 at r1 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
what do you mean? do you prefer another forEach before filtering? or I'm misunderstanding?

Maybe it's better as it is. Could use a test though (the tests pass even if you leave out the setAttribute part)
Note: The filtering loop is actually unnecessary, you could achieve the same with Polymer.dom(this).querySelectorAll('*:not(.splitter-handle)').forEach...

demo/custom.html, line 29 at r1 (raw file):
Previously, manolo (Manuel Carrasco Moñino) wrote…
ops, Done.

Typos: "cutsom-style"

Comments from Reviewable

Review status: 0 of 14 files reviewed at latest revision, 3 unresolved discussions.

bower-2.0.json, line 30 at r2 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
Tag/branch custom-elements-v1 does not exist

That branch was very recently merged and removed https://github.com/PolymerElements/iron-input/commit/14637e05e9cd8ad21dbfc38d7e4379157d6f189b
Done.

vaadin-split-layout.html, line 275 at r1 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
Maybe it's better as it is. Could use a test though (the tests pass even if you leave out the setAttribute part)
Note: The filtering loop is actually unnecessary, you could achieve the same with Polymer.dom(this).querySelectorAll('*:not(.splitter-handle)').forEach...

Added the test.
Tried css selectors but we need effective children in 2.0. So this code does not work if you replace 1.7 dependencies with 2.0:

_processChildren: function() {
  Polymer.dom(this).querySelectorAll('.splitter-handle').forEach(function(child) {
    Polymer.dom(child).setAttribute('slot', 'handle');
  });

  Polymer.dom(this).querySelectorAll('*:not(.splitter-handle)').forEach(function(child, i) {
    if (i === 0) {
      this._primaryChild = child;
      Polymer.dom(child).setAttribute('slot', 'primary');
    } else if (i == 1) {
      this._secondaryChild = child;
      Polymer.dom(child).setAttribute('slot', 'secondary');
    } else {
      Polymer.dom(child).removeAttribute('slot');
    }
  }.bind(this));
},

demo/custom.html, line 29 at r1 (raw file):
Previously, tomivirkki (Tomi Virkki) wrote…
Typos: "cutsom-style"

Done.

Comments from Reviewable

Reviewed 6 of 13 files at r1, 4 of 5 files at r2, 4 of 4 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Testrun API - Port in use

If there is another service using the port 8000 running, Testrun API will not launch. Consider adding a configuration option so this can be modified if this port is in use elsewhere.
(venv) elsaidi@elsaidi-testrun:~/test-run$ sudo bin/testrun
Aug 21 09:52:48 api      INFO    Starting API
Aug 21 09:52:48 api      INFO    API waiting for requests
[Errno 98] error while attempting to bind on address ('<IP_ADDRESS>', 8000): address already in use

The API port can now be changed in the system config. Closing


Search in Russian doesn't work in sub-search (like kitchen type) when POI is added

If you search 'амери' than 'американская кухня' is not displayed. But it is displayed for 'ameri' (probably, as a substring for 'american').

For POI-type search it works fine

I can confirm that it doesn't work in this way. Neither the original MAPS.ME nor this application support automatic transliteration and/or translation. This is a good feature request. Thanks!

Thanks, I think it could be not about auto-translate, but about search in displayed list: if there are items in russian than it should be possible to search using russian text. But looks like by some reason code expects latin letters. I had some email conversation with mapsme, they mentioned that it could be an issue with detection of input language because of keyboard that I use, but were not able to fix it. Hope it helps.


Phony.plausible returns false for valid german phone number

What I did

Phony.plausible?("+49691551")

What happened

Returns false

What I expected to happen and why

I expect it to return true. This is the official number of Hessischer Rundfunk, which is the public broadcasting corporation of the German federal state of Hessen (see https://www.hr.de/impressum/index.html)

@fschwahn Hi! Apologies for the late answer (summer break) – and thanks – this must be the shortest German number I've ever seen 😄 Fix released in 2.18.7 🚀

Yes, me too 😄 Unfortunately it was entered in our app 🙄😄 Thanks for the fix!

My pleasure! 😊


Further optimization: read rules testing static data just once

Prototyping shows that some 20% speed increase is possible, this way. Just an optimization, no other affects.

Implemented in next; coming to 0.0.4


Create script to scrape the parents of congressmen

The script will fetch the data from the congress website and then it
will create a file in data/congressperson_relatives.xz with 3 columns,
namely 'congressperson_id', 'relationship' and 'relative_name'. This
file will contain the names of the parent(s) of the congressmen.
The script will also create another file called
data/congressperson_relatives_raw.xz that will contain the original
string obtained from the site in case the script could not properly
split the father's and mother's name.
Maybe it'll be better to generate the files and then save them as you
did with the other files, because the script currently does more than
a thousand requests and it takes quite a long time.

This is related to the issue #15 .

I've fixed some issues and will work on the other ones later this week. I'll be glad if you could give me your opinion on the two remaining issues.

Sure thing. I guess I just replied to both of them now.
Another thing: you can add a description and brief instructions of this script updating the Scripts part of CONTRIBUTING.md.
Hell yeah 🤘

Maybe after this is merged, I could refactor these functions to load data into a separate module. I guess it would be easier for anyone else to write new scripts with that sort of helper functions.

I could refactor these functions to load data into a separate module

There's already an issue for this ; ) #37 — feel free to jump in!

Thanks @josecostamartins for the fix!
@braunmagrin: @anaschwendler and I added some lines to fix the file loader and now it's merged 🎉
Many thanks for the PR — and enjoy your #caipyra tshirt (thanks to @rougeth)

@cuducos I guess we did the same fixes on the loader :(

Sure thing. Sorry about that — my fault, I should've told you that I was working on t to fix ; )
Anyway, great contribution!

No problems! Thanks for the patience and all the feedback.
Looking forward to work with you again @cuducos and @anaschwendler ;)

Thank you so much @braunmagrin ! It was a great contribution!
It was awesome to work with you, if we plan another sprint that you can participate i am sure that we can work together again :)
:tada:


convert cityscapes dataset to pascal voc format

Hi, Can you please mention detailed steps to convert the cityscapes dataset to pascal voc format

same question!


[Docs] Profiles

The new version 1.75 adds the "Profiles" feature. But the docs don't show what it is, how to configure it, use it, etc.

It is in progress at https://github.com/microsoft/vscode-docs/issues/6020


fix(amplify-provider-awscloudformation): check before fetching backend

checking for deleted bucket in env
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #3848 into master will increase coverage by 0.90%.
The diff coverage is 87.26%.

@@            Coverage Diff             @@
##           master    #3848      +/-   ##
==========================================
+ Coverage   59.06%   59.97%   +0.90%
==========================================
  Files         289      300      +11
  Lines       13408    13801     +393
  Branches     2542     2612      +70
==========================================
+ Hits         7920     8277     +357
- Misses       5072     5109      +37
+ Partials      416      415       -1

Impacted Files
Coverage Δ

...-appsync-simulator/src/data-loader/lambda/index.ts
33.33% <0.00%> (+3.33%)
:arrow_up:

packages/amplify-cli/src/context-extensions.ts
31.29% <0.00%> (+0.23%)
:arrow_up:

packages/amplify-cli/src/domain/amplify-toolkit.ts
1.58% <0.00%> (-0.03%)
:arrow_down:

...amplify-codegen-appsync-model-plugin/src/preset.ts
0.00% <0.00%> (ø)

...-plugin/src/visitors/appsync-typescript-visitor.ts
60.00% <22.22%> (+60.00%)
:arrow_up:

...-model-plugin/src/visitors/appsync-java-visitor.ts
87.90% <50.00%> (ø)

...ugin/src/visitors/appsync-json-metadata-visitor.ts
95.16% <94.44%> (+95.16%)
:arrow_up:

...sync-model-plugin/src/utils/process-connections.ts
91.89% <95.00%> (+0.46%)
:arrow_up:

...model-plugin/src/visitors/appsync-swift-visitor.ts
96.94% <97.05%> (+52.18%)
:arrow_up:

...loudformation/question-factories/core-questions.js
77.67% <100.00%> (+0.20%)
:arrow_up:

... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 549e1ad...3470026. Read the comment docs.


babel dependencies are missing

I had to add @babel/core, @babel/preset-env and babel-loader to the devDependencies in order to make it work.
But other than that thanks a ton because it is by far the best electron-angular starter that I found ;-)

Sorry for the late response and thank you very much for the feedback. Regarding your issue, those dependencies are normally handled by electron-webpack. But sadly, the project is now a little bit outdated  and looking for maintainers. That why I put some energy in order to use electron-forge from now on.
Feel free to add one ⭐ which will also be very appreciated !

Unfortunately I won't be able to test it anytime soon but really nice upgrade though, well done !
Closing it and adding a star 😉


refactor ModelChain inverter methods to use PVSystem.get_ac

follow up to #1147
[x] I am familiar with the contributing guidelines
[x] Tests added
[x] Updates entries to docs/sphinx/source/api.rst for API changes.
[x] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
[x] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
[x] Pull request is nearly complete and ready for detailed review.
[x] Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.

One could argue there should be a deprecation period for the ModelChain.snlinverter and ModelChain.adrinverter methods, but I'd be shocked if anyone is directly calling them.

Every time I see this I think it says PVsyst.get_ac 😆

Every time I see this I think it says PVsyst.get_ac 😆


How to add pinch to zoom on image if slider is in tableviewcell.

I have added image slider in UITableviewCell. I want zoom effect like instagram. Like pinch on image and zoom the image. How can I achieve it.

Hi, I'm sorry but this is not currently supported. You can try to implement it yourself using a gesture recognizer.


riscv: Add Vector CSRs to csr.h

Summary
The CSR register definitions from RVV 1.0 spec: https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc#vector-registers
Impact
None
Testing
CI

Have you implemented the save/restore of vector registers？

Have you implemented the save/restore of vector registers？

No, I just noticed that some register definitions are missing when reading the standard definition document.


swb: a few more unit test verification fixes

A few fixes from running unit test verification.
Previously missed disabling "memcpy" on "WriteBarrierPtr*".
List uses "bool isLeaf" to indicate leaf/non-leaf. Use the same info to
determine write barrier in CopyArray/qsort_s inside List.

@dotnet-bot test Linux tests please

@dotnet-bot test Linux tests please

:shipit:


Can't branch per page 50 of book.

Added branch per web instructions but still can't add logo

I should be getting closer.


Increase the efficiency of converting to delta format

Increase the efficiency by using the partition information

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: lys0716:x: Eason LuEason Lu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


[Event Request] Table 77 "Report Selections", Functions SendToZipForVend,SendToZipForCust,SendToDiskForVend,SendToDiskForCust,SendEmailDirectly: OnBeforeExecuteReport

Hello, we need to influence report selection before sending the document, thank you in advance.
local procedure SendEmailDirectly(ReportUsage: Enum "Report Selection Usage"; RecordVariant: Variant; DocNo: Code[20]; DocName: Text[150]; FoundBody: Boolean; FoundAttachment: Boolean; ServerEmailBodyFilePath: Text[250]; var DefaultEmailAddress: Text[250]; ShowDialog: Boolean; var TempAttachReportSelections: Record "Report Selections" temporary; var CustomReportSelection: Record "Custom Report Selection") AllEmailsWereSuccessful: Boolean
    var
        TempBlob: Codeunit "Temp Blob";
        DocumentMailing: Codeunit "Document-Mailing";
        OfficeAttachmentManager: Codeunit "Office Attachment Manager";
        DocumentRecord: RecordRef;
        EmailAddress: Text[250];
        IsHandled: Boolean;
        AttachmentStream: InStream;
    begin
        IsHandled := false;
        DocumentRecord.GetTable(RecordVariant);
        OnBeforeSendEmailDirectly(Rec, ReportUsage, RecordVariant, DocNo, DocName, FoundBody, FoundAttachment,    ServerEmailBodyFilePath, DefaultEmailAddress, ShowDialog, TempAttachReportSelections, CustomReportSelection, AllEmailsWereSuccessful, IsHandled);
        if IsHandled then
            exit(AllEmailsWereSuccessful);

        AllEmailsWereSuccessful := true;

        ShowNoBodyNoAttachmentError(ReportUsage, FoundBody, FoundAttachment);

        if FoundBody and not FoundAttachment then begin
            TempBlob.CreateInStream(AttachmentStream);
            EmailAddress := CopyStr(
                GetNextEmailAddressFromCustomReportSelection(CustomReportSelection, DefaultEmailAddress, Usage, Sequence), 1, MaxStrLen(EmailAddress));
            AllEmailsWereSuccessful := DocumentMailing.EmailFile(AttachmentStream, '', ServerEmailBodyFilePath, DocNo, EmailAddress, DocName, not ShowDialog, ReportUsage.AsInteger(), DocumentRecord);
        end;

        if FoundAttachment then begin
            if ReportUsage = Usage::JQ then begin
                Usage := ReportUsage;
                CustomReportSelection.SetFilter(Usage, GetFilter(Usage));
                if CustomReportSelection.FindFirst then
                    if CustomReportSelection.GetSendToEmail(true) <> '' then
                        DefaultEmailAddress := CustomReportSelection."Send To Email";
            end;

            OnSendEmailDirectlyOnBeforeSendFiles(
              ReportUsage.AsInteger(), RecordVariant, DefaultEmailAddress, TempAttachReportSelections, CustomReportSelection);
            with TempAttachReportSelections do begin
                OfficeAttachmentManager.IncrementCount(Count - 1);
                repeat
 // - new
                    OnBeforeExecuteReport(TempAttachReportSelections, RecordVariant);
 // + new
                    EmailAddress := CopyStr(
                        GetNextEmailAddressFromCustomReportSelection(CustomReportSelection, DefaultEmailAddress, Usage, Sequence),
                        1, MaxStrLen(EmailAddress));
                    SaveReportAsPDFInTempBlob(TempBlob, "Report ID", DocumentRecord, "Custom Report Layout Code", ReportUsage);
                    TempBlob.CreateInStream(AttachmentStream);

                    AllEmailsWereSuccessful :=
                        AllEmailsWereSuccessful and
                        DocumentMailing.EmailFile(
                            AttachmentStream, '', ServerEmailBodyFilePath,
                            DocNo, EmailAddress, DocName, not ShowDialog, ReportUsage.AsInteger(), DocumentRecord);
                until Next() = 0;
            end;
        end;

        OnAfterSendEmailDirectly(ReportUsage.AsInteger(), RecordVariant, AllEmailsWereSuccessful);
        exit(AllEmailsWereSuccessful);
    end;

 procedure SendToDiskForCust(ReportUsage: Enum "Report Selection Usage"; RecordVariant: Variant; DocNo: Code[20]; DocName: Text; CustNo: Code[20])
    var
        TempReportSelections: Record "Report Selections" temporary;
        ElectronicDocumentFormat: Record "Electronic Document Format";
        ServerAttachmentFilePath: Text[250];
        ClientAttachmentFileName: Text;
    begin
        OnBeforeSetReportLayout(RecordVariant, ReportUsage.AsInteger());
        FindReportUsageForCust(ReportUsage, CustNo, TempReportSelections);
        with TempReportSelections do
            repeat
// - new
                OnBeforeExecuteReport(TempReportSelections, RecordVariant);
// + new
                ServerAttachmentFilePath := SaveReportAsPDF("Report ID", RecordVariant, "Custom Report Layout Code", ReportUsage);
                ClientAttachmentFileName := ElectronicDocumentFormat.GetAttachmentFileName(DocNo, DocName, 'pdf');
                FileManagement.DownloadHandler(
                    ServerAttachmentFilePath, '', '', FileManagement.GetToFilterText('', ClientAttachmentFileName), ClientAttachmentFileName);
            until Next() = 0;
    end;

    procedure SendToDiskForVend(ReportUsage: Enum "Report Selection Usage"; RecordVariant: Variant; DocNo: Code[20]; DocName: Text; VendorNo: Code[20])
    var
        TempReportSelections: Record "Report Selections" temporary;
        ElectronicDocumentFormat: Record "Electronic Document Format";
        ServerAttachmentFilePath: Text[250];
        ClientAttachmentFileName: Text;
    begin
        OnBeforeSetReportLayout(RecordVariant, ReportUsage.AsInteger());
        FindReportUsageForVend(ReportUsage, VendorNo, TempReportSelections);
        with TempReportSelections do
            repeat
// - new
                OnBeforeExecuteReport(TempReportSelections, RecordVariant);
// + new
                ServerAttachmentFilePath := SaveReportAsPDF("Report ID", RecordVariant, "Custom Report Layout Code", ReportUsage);
                ClientAttachmentFileName := ElectronicDocumentFormat.GetAttachmentFileName(DocNo, DocName, 'pdf');
                FileManagement.DownloadHandler(
                    ServerAttachmentFilePath, '', '', FileManagement.GetToFilterText('', ClientAttachmentFileName), ClientAttachmentFileName);
            until Next() = 0;
    end;

 procedure SendToZipForCust(ReportUsage: Enum "Report Selection Usage"; RecordVariant: Variant; DocNo: Code[20]; CustNo: Code[20]; var DataCompression: Codeunit "Data Compression")
    var
        TempReportSelections: Record "Report Selections" temporary;
        ElectronicDocumentFormat: Record "Electronic Document Format";
        ServerAttachmentTempBlob: Codeunit "Temp Blob";
        ServerAttachmentInStream: InStream;
        ServerAttachmentFilePath: Text;
    begin
        OnBeforeSetReportLayout(RecordVariant, ReportUsage.AsInteger());
        FindReportUsageForCust(ReportUsage, CustNo, TempReportSelections);
        with TempReportSelections do
            repeat
// - new
                OnBeforeExecuteReport(TempReportSelections, RecordVariant);
// + new
                ServerAttachmentFilePath := SaveReportAsPDF("Report ID", RecordVariant, "Custom Report Layout Code", ReportUsage);
                FileManagement.BLOBImportFromServerFile(ServerAttachmentTempBlob, ServerAttachmentFilePath);
                ServerAttachmentTempBlob.CreateInStream(ServerAttachmentInStream);
                DataCompression.AddEntry(
                  ServerAttachmentInStream, ElectronicDocumentFormat.GetAttachmentFileName(DocNo, Format(Usage), 'pdf'));
            until Next() = 0;
    end;

procedure SendToZipForVend(ReportUsage: Enum "Report Selection Usage"; RecordVariant: Variant; DocNo: Code[20]; VendorNo: Code[20]; var DataCompression: Codeunit "Data Compression")
    var
        TempReportSelections: Record "Report Selections" temporary;
        ElectronicDocumentFormat: Record "Electronic Document Format";
        ServerAttachmentTempBlob: Codeunit "Temp Blob";
        ServerAttachmentInStream: InStream;
        ServerAttachmentFilePath: Text;
    begin
        OnBeforeSetReportLayout(RecordVariant, ReportUsage.AsInteger());
        FindReportUsageForVend(ReportUsage, VendorNo, TempReportSelections);
        with TempReportSelections do
            repeat
// - new
                OnBeforeExecuteReport(TempReportSelections, RecordVariant);
// + new
                ServerAttachmentFilePath := SaveReportAsPDF("Report ID", RecordVariant, "Custom Report Layout Code", ReportUsage);
                FileManagement.BLOBImportFromServerFile(ServerAttachmentTempBlob, ServerAttachmentFilePath);
                ServerAttachmentTempBlob.CreateInStream(ServerAttachmentInStream);
                DataCompression.AddEntry(
                    ServerAttachmentInStream, ElectronicDocumentFormat.GetAttachmentFileName(DocNo, Format(Usage), 'pdf'));
            until Next() = 0;
    end;

    [IntegrationEvent(false, false)]
    local procedure OnBeforeExecuteReport(var ReportSelections: Record "Report Selections" temporary; var RecordVariant: Variant)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


About openssl 3.0 FIPS-140-2

Hi All:
I saw that openssl 3.0 FIPS 140-2 Validation Certificate Issued from https://www.openssl.org/blog/blog/2022/08/24/FIPS-validation-certificate-issued/, So is that I can use any version 3.0.x (ex. 3.0.4, 3.0.5) which are all pass FIPS 140-2 Validation Certificate? or I must use 3.0.0 for FIPS 140-2? Thanks

You must use 3.0.0 to build the FIPS provider and it must be built and used exactly as per the security policy.  If there is any deviation however slight, the result will not FIPS approved.
However, the 3.0.0 FIPS provider will work with any 3.0.x version of the OpenSSL libraries.  You should build these separately (without FIPS) and have them load the 3.0.0 FIPS provider.

@paulidale Thanks for the reply.
I want to confirm one thing about second paragraph, Below is my understanding

I should use openssl 3.0.0 to build FIPS provider (./Configure enable-fips),  get fips.dylib
I use openssl 3.0.5 to build crypto/ssl library,  when Configure, I should NOT use enable-fips? , then get libcrypto.dylib and libssl.dylib
use code to load FIPS provider,  ex OSSL_PROVIDER_set_default_search_path/OSSL_LIB_CTX_load_config and more...

In step 2, Can I build 3.0.5 with enable-fips, and use 3.0.0 fips provider file to replace 3.0.5 fips provider?

I suggest that you don't use enable-fips when building 3.0.5.  It removes any possibility of using the non-validated provider & it builds and tests faster.  Mistakes happen and mitigating them as part of the process is much better than risking them.  At least in my opinion.
That said, building 3.0.5 with enable-fips and copying the 3.0.0 FIPS provider to the right place will work.
A third option is to build 3.0.0 with FIPS, 3.0.5 without and copy the 3.0.0 fips.dylib into the location 3.0.5 expects its providers to be in.  This removes the need to change the default search path etc.
As an aside: you can enable FIPS via configuration if you don't want to make code changes.  But that's another discussion.

Also be careful about loading the default provider with FIPS.  Without correct property strings (or default properties), you risk running in an invalid setup.
It is better to load the base provider along with the FIPS provider.  This guarantees that only FIPS approved algorithms are used.


Detect github action branch name

Attempt to detect PR branch name in Github Actions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Confirmed success: "Found github ref: github-branch-detection"


[Feature Request] Support  convert JSON fields to the types of my Swift objects automatically, without me having to manually add @CodedBy.

[x] I have read the documentation.

I want to replace the previous tool with it. However, I am facing an issue now. My Swift object data comes from many different APIs, and the same field from different APIs may have different data types. The previous tool automatically converted them to the desired data types for me. I don't know which fields need to be marked with @CodedBy because there are too many such fields, and it's difficult to identify them manually. Can you provide a feature to automatically convert the data types to the desired types?
Moreover, many APIs have not been maintained for a long time, making it difficult to determine the specific data types.

Same as discussed #51 while I am not in favour of the approach suggested in #51.
I think such feature could be implemented in a more generic way, i.e. a new parameter commonStrategies could be introduced in @Codable macro which accepts such strategies which can be applied to all the properties. The API definitions
in MetaCodable:
...
public macro Codable(commonStrategies: [CodableCommonStrategy] = []) = ...

public struct CodableCommonStrategy {
    package init() {} // package access level to only allow strategies handled by MetaCodable
}

in HelperCoders:
extension CodableCommonStrategy {
    public static func codedBy(_ helperCoderStrategy: HelperCoderStrategy) -> Self {
        return .init()
    }

    // additional strategies can be added in future

    public enum HelperCoderStrategy {
        case valueCoder(_ additionalTypes: [any ValueCodingStrategy] = []) // additionalTypes can be used to pass custom ValueCodingStrategy implementations, by default only library provided ValueCodingStrategy implementation will be used
        // additional helpercoder cases can be added in future
    }
}

@wzio @zy19890102 let me know your thoughts on this approach.


Prevent ssh config tests from corrupting local ssh config file

Instead of overwriting local ~/.ssh/config file with the testdata file, we mock out ssh_config to point it to a temp file.

IMO we don't need to replace ssh_config if there isn't any bug fix or enhancement to the forked repo.

We do need the latest change that makes ConfigFinder public so we can overwrite it with out mocked one.


Create a base LKokkos new device API backend.

Before submitting
Please complete the following checklist when submitting a PR:

[X] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests directory!

[X] All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running make docs.

[X] Ensure that the test suite passes, by running make test.

[X] Add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR.

[X] Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.

Context:
Following the design of Lightning Qubit uses the New Device API end to end, we can now migrate lightning.kokkos device to the new device API.
Description of the Change:
Migration of Lightning Kokkos to integrate the New device API. The list of main features changes are

Add the state_vector, measurements, and adjoint-jacobian classes for lightning.kokkos
Add the simulate, jacobian, simulate_and_jacobian, vjp, and simulate_and_vjp methods to lighting.kokkos
Update unit/integration tests for the new device API to work with lightning.kokkos
Check the full support for sampling in full parity with Lightning Qubit
Replace the old device API for Lightning Kokkos.

Benefits:
Full integration of Lightning kokkos with the new device API.
Possible Drawbacks:
Related GitHub Issues:
[sc-59207], [sc-68825]

Thanks @LuisAlfredoNu ! Would you like to add a new entry to the .github/CHANGELOG.md file, summarizing the
change, and including a link back to the PR?

Once again, the CodeCov platform has issues showing the coverage results. However, running all the tests locally for LKokkos and collecting the coverage, creates the following results:
---------- coverage: platform linux, python 3.10.12-final-0 ----------
Name                                                        Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------
pennylane_lightning/lightning_kokkos/__init__.py                2      0   100%
pennylane_lightning/lightning_kokkos/_adjoint_jacobian.py     120      1    99%   25
pennylane_lightning/lightning_kokkos/_measurements.py         157     14    91%   21, 302, 306, 336, 407-410, 431-443
pennylane_lightning/lightning_kokkos/_state_vector.py         138      1    99%   26
pennylane_lightning/lightning_kokkos/lightning_kokkos.py      225     13    94%   56-58, 128, 185, 218, 463, 753-756, 769, 779-780
-----------------------------------------------------------------------------------------

Once again, the CodeCov platform has issues showing the coverage results. However, running all the tests locally for LKokkos and collecting the coverage, creates the following results:
---------- coverage: platform linux, python 3.10.12-final-0 ----------
Name                                                        Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------
pennylane_lightning/lightning_kokkos/__init__.py                2      0   100%
pennylane_lightning/lightning_kokkos/_adjoint_jacobian.py     120      1    99%   25
pennylane_lightning/lightning_kokkos/_measurements.py         157     14    91%   21, 302, 306, 336, 407-410, 431-443
pennylane_lightning/lightning_kokkos/_state_vector.py         138      1    99%   26
pennylane_lightning/lightning_kokkos/lightning_kokkos.py      225     13    94%   56-58, 128, 185, 218, 463, 753-756, 769, 779-780
-----------------------------------------------------------------------------------------

Thank you for checking this out.
In this case, could you please expand testing to cover the real cases?
Also, could you please update the PR description?

@AmintorDusko

Thank you for checking this out.
In this case, could you please expand testing to cover the real cases?

Ok I will do it

Also, could you please update the PR description?

Done! :tada:

Once again, the CodeCov platform has issues showing the coverage results. However, running all the tests locally for LKokkos and collecting the coverage, creates the following results:
---------- coverage: platform linux, python 3.10.12-final-0 ----------
Name                                                        Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------
pennylane_lightning/lightning_kokkos/__init__.py                2      0   100%
pennylane_lightning/lightning_kokkos/_adjoint_jacobian.py     120      1    99%   25
pennylane_lightning/lightning_kokkos/_measurements.py         157     14    91%   21, 302, 306, 336, 407-410, 431-443
pennylane_lightning/lightning_kokkos/_state_vector.py         138      1    99%   26
pennylane_lightning/lightning_kokkos/lightning_kokkos.py      225     13    94%   56-58, 128, 185, 218, 463, 753-756, 769, 779-780
-----------------------------------------------------------------------------------------

Thank you for checking this out. In this case, could you please expand testing to cover the real cases? Also, could you please update the PR description?

Improving a bit the coverage of the code. I get the following result running all the test locally:
---------- coverage: platform linux, python 3.10.12-final-0 ----------
Name                                                        Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------
pennylane_lightning/lightning_kokkos/_adjoint_jacobian.py     120      1    99%   25
pennylane_lightning/lightning_kokkos/_measurements.py         157     14    91%   21, 302, 306, 336, 385-388, 409-421
pennylane_lightning/lightning_kokkos/_state_vector.py         138      1    99%   26
pennylane_lightning/lightning_kokkos/lightning_kokkos.py      225     11    95%   56-58, 463, 753-756, 769, 778-780
-----------------------------------------------------------------------------------------

The not covered lines in  _measurements.py are due to the problem with the function _measure_hamiltonian_with_samples
The not covered lines in lightning_kokkos.py  are due to the function get_c_interface():
In all files, the first missing lines are not covered because it was not used the no-binary test.

Thanks @LuisAlfredoNu for the nice work! Just a few minor suggestions.

Once again, the CodeCov platform has issues showing the coverage results. However, running all the tests locally for LKokkos and collecting the coverage, creates the following results:
---------- coverage: platform linux, python 3.10.12-final-0 ----------
Name                                                        Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------
pennylane_lightning/lightning_kokkos/__init__.py                2      0   100%
pennylane_lightning/lightning_kokkos/_adjoint_jacobian.py     120      1    99%   25
pennylane_lightning/lightning_kokkos/_measurements.py         157     14    91%   21, 302, 306, 336, 407-410, 431-443
pennylane_lightning/lightning_kokkos/_state_vector.py         138      1    99%   26
pennylane_lightning/lightning_kokkos/lightning_kokkos.py      225     13    94%   56-58, 128, 185, 218, 463, 753-756, 769, 779-780
-----------------------------------------------------------------------------------------

Thank you for checking this out. In this case, could you please expand testing to cover the real cases? Also, could you please update the PR description?

Improving a bit the coverage of the code. I get the following result running all the test locally:
---------- coverage: platform linux, python 3.10.12-final-0 ----------
Name                                                        Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------
pennylane_lightning/lightning_kokkos/_adjoint_jacobian.py     120      1    99%   25
pennylane_lightning/lightning_kokkos/_measurements.py         157     14    91%   21, 302, 306, 336, 385-388, 409-421
pennylane_lightning/lightning_kokkos/_state_vector.py         138      1    99%   26
pennylane_lightning/lightning_kokkos/lightning_kokkos.py      225     11    95%   56-58, 463, 753-756, 769, 778-780
-----------------------------------------------------------------------------------------

- The not covered lines in  `_measurements.py` are due to the problem with the function `_measure_hamiltonian_with_samples`

- The not covered lines in `lightning_kokkos.py ` are due to the function `get_c_interface():`

- In all files, the first missing lines are not covered because it was not used the no-binary test.

After all the suggestions have been implemented. This is a new coverage report
---------- coverage: platform linux, python 3.10.12-final-0 ----------
Name                                                        Stmts   Miss  Cover   Missing
-----------------------------------------------------------------------------------------
pennylane_lightning/lightning_kokkos/__init__.py                2      0   100%
pennylane_lightning/lightning_kokkos/_adjoint_jacobian.py     120      1    99%   25
pennylane_lightning/lightning_kokkos/_measurements.py         148      7    95%   21, 302, 334, 383-386
pennylane_lightning/lightning_kokkos/_state_vector.py         138      1    99%   26
pennylane_lightning/lightning_kokkos/lightning_kokkos.py      227     11    95%   56-58, 470, 760-763, 776, 785-787
-----------------------------------------------------------------------------------------


Add some tests

Add some tests

Sorry that it took so long to get around to review this PR.
Looks good though! There is never enough tests <3
Merging


RangeError (end): Invalid value: Only valid value is.. when input list has duplicated value

I have the following code
final input1 = ['A', 'B', 'C', 'C'];
final input2 = ['A', 'B', 'C'];
var diffs = diff_list.diffSync(input1, input2);
print(diffs);

Then I got the error
RangeError (end): Invalid value: Only valid value is 3: 2
dart:core                                List.sublist
trim    package:list_diff/trim.dart:28
diffSync   package:list_diff/list_diff.dart:133
main.<fn>.<fn>  test/transcript_diff_test.dart:1

It only happens when the list has duplicated value => the sublist isn't correct in this case
My flutter doctor
[✓] Flutter (Channel stable, 2.8.1, on Mac OS X 10.15.7 19H1519 darwin-x64, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
[!] Xcode - develop for iOS and macOS (Xcode 12.4)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2020.3)
[✓] VS Code (version 1.58.2)
[✓] VS Code (version 1.64.0-insider)

Sorry for the late response, a fixed version is now published as 2.0.1.


Checkout: Slow loading and customers aborting

We have implemented the checkout features on our live website.
Since that moment the numbers of customers completing the checkout have dropped.
Could the plugin be altered so these shipping options only appear (and are loaded) after the customer selects a checkbox?
[ x ] shipping options
When I look at heatmaps I that customers are confused by the current GUI. There is a lot of information that they sometimes do not even need.

The speed has been improved in version 3.0.2 of the plugin


github.com/alexkohler/nakedret is not used in this modulego mod tidy

Hi
Is it possible to install using go install github.com/********** because when I use go get -u github.com/**** it saves the package in go.mod then i get this message github.com/alexkohler/nakedret is not used in this modulego mod tidy
Thanks in advanced

Hey there! Apologies, missed this original issue. I think the best course of action is to just use go install, e.g.:
$ go install github.com/alexkohler/nakedret@latest
go: downloading github.com/alexkohler/nakedret v1.0.0
$

That's odd! I am unable to reproduce this. what does line 3 do?

$ ➡ which nakedret

which nakedret would tell you the location of the nakedret binary if it's on your PATH. Are you able to go install other binaries?

I see, I had to manually setx ... the path on windows to get it to run. I'll setup a pr to update the docs with this first thing in the morning.

Sounds good, much appreciated!


bcdec: Fix decompressing mipmaps not divisible by 4

Fixes #98884 (hopefully)
Changes the decompression code to write decompressed data into a temporary buffer before writing it into the output image.
This will result in a small performance loss for images whose mipmaps' resolutions are not divisible by 4.
I also haven't tested the results much, so the output data may be written incorrectly.

A lot of errors in the GitHub actions integration test.
Error: modules/bcdec/image_decompress_bcdec.cpp:106:5: error: comparison of integers of different signs: 'int' and 'const uint32_t' (aka 'const unsigned int') [-Werror,-Wsign-compare]
                                DECOMPRESS_LOOP_SAFE(bcdec_bc6h_half_s, BCDEC_BC6H_BLOCK_SIZE, 6, 3, rgbh_output)

I did some testing and it seems to decompress the mipmaps correctly. I also changed the code to directly write the data to the output if a current block is 4x4, effectively speeding up the whole process.

@nikitalita Do you mind testing this out and confirming that it fixes things for you?

Yup, the mrp decompresses successfully.

Thanks!


xray handler for grpc

Do you have any plans for adding xray handler for grpc servers / clients?

Hi Ron,
Currently we do not have support for grpc but we will add it into our backlogs. Can you share examples of use cases you are trying to tackle?
Meanwhile we do welcome PRs and would be happy to review.
Best Regards
Srikant

App Mesh customers are asking for this: https://github.com/aws/aws-app-mesh-roadmap/issues/256

Hi @rvdwijngaard
We have this feature request added to our backlog. We would try to pull it in to work on as soon as possible.
Thanks for your patience and please stay tuned!

Created https://github.com/vendrive/xray-grpc for temporary use while https://github.com/aws/aws-xray-sdk-go/pull/264 makes its way through.

Created https://github.com/vendrive/xray-grpc for temporary use while https://github.com/aws/aws-xray-sdk-go/pull/264 makes its way through.


Removed warning about skipping flags

Proposed Changes
QA showed that the warning was confusing and unnecessary and could potentially reveal secret information.

Types of Changes
Bugfix

Verification
Same as https://github.com/k3s-io/k3s/pull/4464, but no warning should show.

Linked Issues
https://github.com/k3s-io/k3s/issues/4449

User-Facing Change

Unknown flags in config are now silently skipped by k3s server and etcd-snapshot

Further Comments

Codecov Report

Merging #4491 (b2316d7) into master (f18b325) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4491      +/-   ##
==========================================
- Coverage   12.04%   12.02%   -0.02%
==========================================
  Files         135      135
  Lines        9175     9173       -2
==========================================
- Hits         1105     1103       -2
  Misses       7834     7834
  Partials      236      236

Flag
Coverage Δ

inttests
0.76% <ø> (+<0.01%)
:arrow_up:

unittests
11.58% <ø> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/configfilearg/parser.go
74.65% <ø> (-0.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f18b325...b2316d7. Read the comment docs.


optimization: division by constant as multiplication by inverse

Couldn't division by constants be optimized by replacing the operation by a multiplication of its inverse (i.e x / 2 === x * (1/2) === x * 0.5)
input
// ==ClosureCompiler==
// @compilation_level ADVANCED_OPTIMIZATIONS
// @output_file_name default.js
// ==/ClosureCompiler==

function hello(x) {
 alert( x / 5);
}
const x = prompt('x')
hello(x);

output
alert(prompt("x")/5);

better optimization
alert(prompt("x")*0.2);

see example on "closure-compiler.appspot.com"

Created internal issue - http://b/140444745

Why do you believe this to be an optimization? For an integer divisor, multiplication by the reciprocal will always result in increased code size (in your example, *0.2 is longer than /5).
If the intent is to optimize for execution speed rather than code size, this would need to be justified by a benchmark. It's very likely that JavaScript engines already perform the optimization you describe.

hey, @tjgq, while generally I'd agree with you, but there are more js engines around than I could benchmark (*). I expect closure-compiler project would have such test suits, though, that could shed some hard evidence on these numbers.
(*) some time ago, I did such benchmark (here) and, at the time on my computer, chrome yielded 14% better performance and IE 10%.

Performance rules over size in my opinion (especially when gzipping)

This sort of optimization is best left to JavaScript engines and is not something we will attempt.


Snakemake 8.01 --rulegraph error

Describe the bug
I normally create a rule graph as follows:
$ snakemake --version
7.32.4
$ snakemake --forceall --rulegraph | grep -v '\-> 0\|0\[label = \"all\"' | dot -Tpdf > images/rule_graph.pdf
Building DAG of jobs...
$

I installed Snakemake 8 in another Mamba env and on the same workflow/data I want to make the rule graph again, but now I get an error:
$ snakemake --version
8.0.1
$ snakemake --forceall --rulegraph | grep -v '\-> 0\|0\[label = \"all\"' | dot -Tpdf > images/rule_graph.pdf
Traceback (most recent call last):
  File "/home/niek/mambaforge/envs/snakemake8/lib/python3.12/site-packages/snakemake/cli.py", line 1936, in args_to_api
    dag_api.printrulegraph()
  File "/home/niek/mambaforge/envs/snakemake8/lib/python3.12/site-packages/snakemake/api.py", line 606, in printrulegraph
    self.workflow_api._workflow.printrulegraph()
  File "/home/niek/mambaforge/envs/snakemake8/lib/python3.12/site-packages/snakemake/workflow.py", line 888, in printrulegraph
    ignore_incomplete=self.execution_settings.ignore_incomplete,
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'ignore_incomplete'
$

Additional context
On a different Snakemake workflow with different data I get the exact same error

Duplicate of #2566

Solved in v8.4.0


Add 'MessageComplete' parameter.

The OSC endpoint /chatbox/input was updated to include an additional bool parameter for MessageComplete which is used to trigger the notification SFX.

Where can I find that update?
Give me the url.

@ChanyaVRC
It's on the latest release docs for the release of 2022.4.1
VRChat added a sound effect that plays when a message is sent on the Chatbox, and updated the OSC endpoint adding an extra parameter for it.
https://docs.vrchat.com/docs/vrchat-202241#features


Config of bodyParser

I have seen that the bodyParser is now a standard middleware wich is a good thing.
The only problem I currently have is, that I cannot use it with my own settings. Even if I add it as a second middleware it does not help since the default ones settings are used.
Do you have any suggestions how to work around this? (without using a fork, what I currently do)
It is mainly the limit option that I cannot use with the default settings :(

I cant for the life of me get this to take affect. My code is as follows....
Router.configureBodyParsers = function() {
  this.onBeforeAction(Iron.Router.bodyParser.json({
    limit: '50mb'
  }));
  this.onBeforeAction(Iron.Router.bodyParser.urlencoded({
    extended: true
  }));
};

the urlEncoded part appears to be working but the limit just will not. Any blatantly obvious mistake im missing here?

Same here , I tried:
if (Meteor.isServer) {
  Router.onBeforeAction(Iron.Router.bodyParser.json({limit: '50mb'}));
}

Router.route('/imageUpload', {where: 'server'})
  .post(function () {

    console.log("check", this.request.files); // undefined
    this.response.end('post request\n');
});

What am I missing please?

Same here. Now my this.request.body is undefined ???
In some posts people suggest urlencoded (even for json) and in some json. I tried both. The error message went but an empty request body is not a real fix ;-)
How a bout this extended parameter? many say it should be true but I saw some examples with this set to false.

Looks like we need to use busboy or any other middleware

do we have a solution here ?

Router.configureBodyParsers could use some documentation. Finally unearthed it here. I'm able to get it to work and get it to shut off the default JSON parsing on every request.
One thing I struggled with was making sure the type field matches the request's content-type, otherwise the parser won't fire.


https support

My VTO2211G have option to turn https on. When it is checked all traffic from https:/IP:80/ is redirected to https://IP:443/.
SSL Certs are created on VTO itself so they are self signed. Please add support for such connection

Will do. I'll report back once I have this working.

0.9.4 is released and adds support for https with self signed certs.
NOTE: This assumes https is configured on port 443. If it turns out that others are using SSL on ports other than 443 then I'll add in an option. For now taking the easy road :)
Please let me know if this works for you. Thanks!

Sorry not working after updating to 0.9.4
Logs says
Could not connect to Dahua device via the RPC2 API, falling back to cgi

I done it with removing and adding again VTO and changing port to 443

What camera model do you have?

Sorry just saw VTO2211G. I have a vto and will debug

Maybe I can help somehow ?
Redy to change code and turn some debug options

This is fixed in 0.9.5. I verified with my VTO.
Please try again and let me know how it goes. Thanks!
Also make sure when you add the integration you use port 443

It's working now


Roll engine 31cd2dfca22a..b358dc58fbce (39 commits)

git@github.com:flutter/engine.git/compare/31cd2dfca22a...b358dc58fbce
git log 31cd2dfca22a..b358dc58fbce --no-merges --oneline
2019-11-13<EMAIL_ADDRESS>Remove extra shadows from Web Engine EngineParagraphStyle (flutter/engine#13805)
2019-11-13<EMAIL_ADDRESS>Roll src/third_party/dart d5d889668b..ffbd2eb7ee (15 commits)
2019-11-13<EMAIL_ADDRESS>[dart_runner] Initialize logging and tracing (flutter/engine#13829)
2019-11-13<EMAIL_ADDRESS>Update version of dart/language_model distributed with flutter engine to latest (flutter/engine#13799)
2019-11-13<EMAIL_ADDRESS>Roll src/third_party/dart 5cce1e4acd..d5d889668b (17 commits) (flutter/engine#13806)
2019-11-13<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from p9FbP... to _QV9E... (flutter/engine#13823)
2019-11-13<EMAIL_ADDRESS>Revert "Roll src/third_party/skia d860a78fd60c..581108137b46 (13 commits) (#13800)" (flutter/engine#13828)
2019-11-12<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from tZdOC... to p9FbP... (flutter/engine#13801)
2019-11-12<EMAIL_ADDRESS>Create a WeakPtrFactory for use on the UI thread in VsyncWaiter (flutter/engine#13781)
2019-11-12<EMAIL_ADDRESS>Roll src/third_party/skia d860a78fd60c..581108137b46 (13 commits) (flutter/engine#13800)
2019-11-12<EMAIL_ADDRESS>Roll src/third_party/dart 7ebc820ffc..5cce1e4acd (1 commits) (flutter/engine#13798)
2019-11-12<EMAIL_ADDRESS>Document the coordinate space of points in FlutterPointerEvent. (flutter/engine#13782)
2019-11-12<EMAIL_ADDRESS>implement radial gradient in canvaskit backend (flutter/engine#13796)
2019-11-12<EMAIL_ADDRESS>Adds missing comma in EngineParagraphStyle.toString() (flutter/engine#13795)
2019-11-12<EMAIL_ADDRESS>Roll src/third_party/skia ad21d47cfa8d..d860a78fd60c (2 commits) (flutter/engine#13794)
2019-11-12<EMAIL_ADDRESS>Roll src/third_party/dart 7408ed4730..7ebc820ffc (20 commits)
2019-11-12<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from TnTbF... to tZdOC... (flutter/engine#13791)
2019-11-12<EMAIL_ADDRESS>[web] Implement TextStyle.shadows (flutter/engine#13769)
2019-11-12<EMAIL_ADDRESS>Expose asset lookup from plugin binding. (#42019) (flutter/engine#13743)
2019-11-12<EMAIL_ADDRESS>Roll src/third_party/skia 3de645cbca78..ad21d47cfa8d (15 commits) (flutter/engine#13790)
2019-11-12<EMAIL_ADDRESS>Move Path and PathMetrics from canvas.dart into their own files. No delta (flutter/engine#13772)
2019-11-12<EMAIL_ADDRESS>Take devicePixelRatio into account when drawing shadows (flutter/engine#13786)
2019-11-12<EMAIL_ADDRESS>Add ImageFilter and BackdropFilter to CanvasKit backend (flutter/engine#13768)
2019-11-12<EMAIL_ADDRESS>Revert "Reland "Guarding EAGLContext used by Flutter #13314" (#13759)" (flutter/engine#13788)
2019-11-12<EMAIL_ADDRESS>Add Helvetica and sans-serif as fallback font families (flutter/engine#13784)
2019-11-12<EMAIL_ADDRESS>Roll src/third_party/skia 0fd4f01b9b83..3de645cbca78 (1 commits) (flutter/engine#13776)
2019-11-12<EMAIL_ADDRESS>Add line boundary information to LineMetrics. (flutter/engine#13727)
2019-11-11<EMAIL_ADDRESS>Fix RendererContextSwitch result check in Rasterizer::MakeRasterSnapshot (flutter/engine#13785)
2019-11-11<EMAIL_ADDRESS>[web] Fix path to svg for drrect (flutter/engine#13779)
2019-11-11<EMAIL_ADDRESS>Roll src/third_party/dart d45c3d15cb..7408ed4730 (20 commits) (flutter/engine#13778)
2019-11-11<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from RrTFI... to TnTbF... (flutter/engine#13775)
2019-11-10<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from 4JJNo... to RrTFI... (flutter/engine#13774)
2019-11-10<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from xC_an... to 4JJNo... (flutter/engine#13773)
2019-11-09<EMAIL_ADDRESS>Roll fuchsia/sdk/core/mac-amd64 from eq_Rz... to xC_an... (flutter/engine#13771)
2019-11-09<EMAIL_ADDRESS>Roll src/third_party/skia 4135cf0b57c2..0fd4f01b9b83 (1 commits) (flutter/engine#13770)
2019-11-09<EMAIL_ADDRESS>Reland "Guarding EAGLContext used by Flutter #13314" (flutter/engine#13759)
2019-11-09<EMAIL_ADDRESS>Point old plugin registry accessors to new embedding plugin accessors.  (#44225) (flutter/engine#13739)
2019-11-09<EMAIL_ADDRESS>Revert "[fuchsia] Temporarily disable intl provider (#13696)" (flutter/engine#13721)
2019-11-09<EMAIL_ADDRESS>Turn on RasterCache based on view hierarchy (flutter/engine#13762)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
...

AutoRoller is stopped; closing the active roll.


Update DLedgerCommitLog.java

Delete useless code

Coverage decreased (-0.07%) to 49.343% when pulling a3c899b356f45fcbf454b711f13ae1500db1290f on faicm:patch-1 into 34b085dfbe603c096a43a86c058d25f6cd54a945 on apache:master.

There are two issue.Firstly,you can't push your codes into master branch.Secondly,please notice your pr's formate and CI's code coverage. @faicm

@faicm Could you please move this PR to develop branch?


Object # has no method 'view'

Hi guys, I've a Sails app in production, and when I check the logs I sometimes find this error:
index: function(req, res){
  return res.view("home/homepage", {layout: "home/layout.ejs"});
}

Error:
error: Server Error (500)
error: TypeError: Object #<ServerResponse> has no method 'view'
    at module.exports.index (/www/kuaderno/api/controllers/MainController.js:12:63)
    at routeTargetFnWrapper (/www/kuaderno/node_modules/sails/lib/router/bind.js:178:5)
    at callbacks (/www/kuaderno/node_modules/sails/node_modules/express/lib/router/index.js:164:37)
    at param (/www/kuaderno/node_modules/sails/node_modules/express/lib/router/index.js:138:11)
    at pass (/www/kuaderno/node_modules/sails/node_modules/express/lib/router/index.js:145:5)
    at nextRoute (/www/kuaderno/node_modules/sails/node_modules/express/lib/router/index.js:100:7)
    at callbacks (/www/kuaderno/node_modules/sails/node_modules/express/lib/router/index.js:167:11)
    at /www/kuaderno/node_modules/sails/lib/router/bind.js:186:7
    at alwaysAllow (/www/kuaderno/node_modules/sails/lib/hooks/policies/index.js:209:11)
    at routeTargetFnWrapper (/www/kuaderno/node_modules/sails/lib/router/bind.js:178:5)

The same thing happens in other simple web sites that I've made with Sails, and only with this code in routes.js file:
module.exports.routes = {

  '/': {
    view: 'homepage'
  },

  'post /contact' : 'MailerController.send'

};

In this case this is the error:
Sending 500 ("Server Error") response:
 TypeError: Object #<ServerResponse> has no method 'view'
    at serveView (/vervet/xabi-web/node_modules/sails/lib/hooks/views/actions.js:105:8)
    at routeTargetFnWrapper (/vervet/xabi-web/node_modules/sails/lib/router/bind.js:178:5)
    at callbacks (/vervet/xabi-web/node_modules/sails/node_modules/express/lib/router/index.js:164:37)
    at param (/vervet/xabi-web/node_modules/sails/node_modules/express/lib/router/index.js:138:11)
    at pass (/vervet/xabi-web/node_modules/sails/node_modules/express/lib/router/index.js:145:5)
    at nextRoute (/vervet/xabi-web/node_modules/sails/node_modules/express/lib/router/index.js:100:7)
    at callbacks (/vervet/xabi-web/node_modules/sails/node_modules/express/lib/router/index.js:167:11)
    at /vervet/xabi-web/node_modules/sails/lib/router/bind.js:186:7
    at rememberViewId (/vervet/xabi-web/node_modules/sails/lib/hooks/views/actions.js:102:4)
    at routeTargetFnWrapper (/vervet/xabi-web/node_modules/sails/lib/router/bind.js:178:5) [TypeError

Sails version 0.10.5, with no CSRF. I have spent a long time trying to find in which cases could the error  appear and I have  found a way to trigger the error but I can't understand why does it happens.
I can force the error using this platform -> https://isitup.org that sends a json asking for website status code.
I have checked the res object when the error happens and I still have access to, res.ok, res.negotiate, res.json etc... The only method that is undefined is res.view().
Any idea why this happens ? Any way to fix it in a clean way?
Thanks!

Can this fix be applied to v0.10.x as well? I saw this fix included in v0.11.x already but this is also useful for others who are still running on v0.10.x.


Fix the gradle version config that disabled aapt2

Replace the git version to string resource workflow with a reliance on PackageInfo to get the versionName from the manifest instead.

Coverage increased (+0.2%) to 33.815% when pulling 24ed91454cfc58ee0f7a58f3e0e0e0a7d6b94db3 on kruton:aapt2-fix into 0a29388f6266c2d5d455d318eb02390fb8f1f353 on connectbot:master.


Dear Master . Mahapps's   DataGrid   innser  button can't  display when lost focus .

Dear Master,
I found mahapps solution is pretty good.
But  when i using Datagrid ,I find  some issues.  I make a   customize  cell  datatemplate.  Datagrid  can't  display  when I the cell lost focus .How can i fixed the issue  .The picture like below

When I selected row and click the cell. the control can display.

2.Lost focus the select value disappear.

This is my behind code .

thanks  for you patience !

Hi.   You'll need to define a CellTemplate too, where you bind your date value to a control, like textblock, to make it visible when not editing that cell
e.g.
<DataGridTemplateColumn.CellTemplate>   <TextBlock Text={Binding NextNotifyTime, stringFormat={}{0:d}}"/> </DataGridTEmplateColumn.CellTemplate>
please note i wrote this code in this editor...

Hi  jmbobosmith, Thank you very much ,It's working!


Can I edit template.html to add links to ?

Hey,
It goes without saying that THIS IS AWESOME!
preact-mdl seems to be included, so bad example, but what about other external stylesheets or  elements I may want to add?
Thanks!

I never do this but by reading the code, you can pass a template option to  the cli
https://github.com/developit/preact-cli/blob/2175efc4c4157ab3dbfa7b5804043f646d170f5a/src/lib/webpack-config.js#L446

thank you so much!

@peterpme could you please write how you solved this?

hey @bestwestern , see @thangngoc89's comment


Fix misspell: preceed

https://en.wiktionary.org/wiki/preceed

+1 (Love the wiktionary definition!)
@sigmavirus24?

Closing and reopening so the tests run against this. Once they pass, I'll merge it. 👍

Rebased and merged with 37c92e06f887c85d39633ae2a055381ebe1c3d63


Remote desktop with biometrics - Cloud deployment?

will the Remote Desktop with Biometrics functionality (ability to remote desktop into a windows machine using just PIN or fingerprint) available for cloud-only deployments - i.e. no PKI, no on-premise AD ?

@officedocsbot assign @mypil

@jurajgh - We would like to get some details from you. Can you please share what specific issue you have and for which article? Kindly provide the article link as well so we can investigate.
Thank you.

sorry - thought this issue would be attached to the article where I clicked "view on github" (or something).
it's regarding this article: https://docs.microsoft.com/en-us/windows/security/identity-protection/hello-for-business/hello-features#remote-desktop-with-biometrics
and it's not an issue per se, more like not-yet-supported feature. basically, we'd like to use WhdB PIN for remote desktop login into a VM joined to Azure AD Domain Services (not the on-premise directory - we're all-cloud).

@jurajgh - Thank you for engaging with the community here for the docs.
I know the product teams are always looking for user feedback on how to make Windows 10 better. They keep a close tab on user feedback and it would be awesome if you could add your voice via Feedback Hub
You might find others have made a similar request that you can add to, or you can open a new one. Let us know here if you do so we can up-vote your request.
Thank you for your contribution to make the docs better! Much appreciated!

@officedocsbot close


Add scss linter

https://github.com/juanfran/gulp-scss-lint

Alternative which does not require ruby:
https://github.com/sasstools/gulp-sass-lint


AN-333: Fix endpoint ID derivation implementation

Endpoint id derivation in admin-cli was out of date.
https://api3dao.atlassian.net/browse/AN-333

Optionally you might want to update the endpointIds in the examples package, but since that's just a convention it's not really necessary I guess.


when i use it to set menu tray icon, it looks sharper

test.zip
here is test file.
pic1 is normal

pic2 is sharper

Your .ico file contains 4 different versions of the same image - 16x16, 24x24, 32x32, and 48x48.
From https://www.autohotkey.com/docs/commands/Menu.htm#Icon

Slight distortion may occur when loading tray icons from file types other than .ICO. This is especially true for 16x16 icons. To prevent this, store the desired tray icon inside a .ICO file.

So use the .ico format, with Menu, Tray, Icon because it will automatically load the correct size based on DPI (I think).
Further testing may be needed with single dimension .ico files.

test (2).zip
i tested single dimension .ico files, but still have this problem.

Looks like different interpolation by windows to me:

The first cat is your 16x16 icon, and the third cat the 24x24 icon. As you can see, what is shown on the tray is something between 16 and 24.
I don't really know why this is happening, but my best guess is that a different algorithm is used to scale ico vs hbitmaps.
I think:

HBITMAP is a RGB format with an unofficial "alpha" channel. When LoadImage is called using HBITMAP it uses the black pixels to scale. Because the transparent pixels are 0x00000000 (begins with 0x00 + black), they are ignored, but the semi-transparent pixels just have their alpha channel ignored, so maybe that is why the black border is bigger with HBitmap.
ICO has transparency, so LoadImage behaves correctly.

Another picture:

top cat is 16x16
bottom cat is 24x24
None of the tray icon cats are identical to source

Feel free to leave this issue open, maybe there is something I can do, but it's not obvious to me now

Possible info: https://stackoverflow.com/a/76398324


Doesn't react on /command@BotName

The Bot will react to /command in a group, but not to /command@BotName

Try to use command.startswith("/hello") instead of command == "/hello"

Hi @Nici57 ,
Did @jaimehrubiks 's suggestion solve your problem?
Thanks to @jaimehrubiks , by the way.


[WIP] fix(jsonapi): add related link pointing to the resource

We make wrong usage of jsonapi links. We use self to reach the resource itself, we should use related instead of self. Therefore, I decided to add the related link with the right URL in order to replace self in a close future.
NOTE (from Konrad):
I think this clarifies how links should be used: http://jsonapi.org/recommendations/#urls-relationships

@hectorj2f snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1482-1

related to https://github.com/fabric8-services/fabric8-wit/issues/1392

@hectorj2f can you please add a reference to the section of the jsonapi spec and maybe quote the passage? I'd like to know exactly what is wrong and why the new stuff is better.

@hectorj2f snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1482-2

@hectorj2f snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1482-3

@kwk The jsonapi spec splits the 'relationship' and 'target resource' into two; self (relationship) and related (target). self is to manipulate the relationship, while to my understanding related is more a pure GET of the target resources of the relationship.
DELETE self[x] removes the relation but leaves the target resource. e.g. Unassign a User.
DELETE releted[x] removes the target resource and also mosy likely the relation. e.g. Delete User.
It's all fine and dandy if 'self' is used to manipulate the relation between two existing resources. It's a bit more muddy when e.g. you want to create a resource that is related. From the issue tracker I at some point found the suggestion of using the 'outside the spec idea' of POST to 'related', short cut for POST X and PATCH 'self'

@hectorj2f snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1482-4

@hectorj2f snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1482-5

@hectorj2f snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1482-6

@hectorj2f snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1482-7

@hectorj2f snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1482-8

@hectorj2f snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1482-9

@hectorj2f snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1482-12

@kwk this PR aims to add/fix the related link while self link will be fixed once ui stops using self and use related.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c3758fc). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #1482   +/-   ##
=========================================
  Coverage          ?   59.04%
=========================================
  Files             ?      121
  Lines             ?    14591
  Branches          ?        0
=========================================
  Hits              ?     8615
  Misses            ?     5308
  Partials          ?      668

Impacted Files
Coverage Δ

goasupport/helper_function/generator.go
0% <ø> (ø)

controller/work_item_link_category.go
75.83% <100%> (ø)

controller/users.go
77.5% <100%> (ø)

controller/area.go
87.56% <100%> (ø)

controller/workitem.go
80.92% <100%> (ø)

controller/iteration.go
82.2% <100%> (ø)

controller/comments.go
71.28% <100%> (ø)

controller/codebase.go
24.54% <100%> (ø)

controller/space.go
77.15% <100%> (ø)

controller/work_item_link.go
79.09% <100%> (ø)

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3758fc...e647945. Read the comment docs.

@hectorj2f snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1482-13

@hectorj2f snapshot fabric8-wit image is available for testing.  docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1482-14


Add Virginia's Community Colleges

Add new Colleges school

@iamtailee This domain is blacklisted because the college allows to register an email address there even if you are not a student of the college. If you are the student of this college, please apply with official document ("OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students).


Feedback for: engine/swarm/swarm-tutorial/create-swarm.md

File: engine/swarm/swarm-tutorial/create-swarm.md
Hello!
It would be nice to provide information about creating new swarm cluster with multiple managers and how to guarantee the fault tolerance of one of them.
This information described about old style swarm, but not described for new one.

Sorry for not getting back to you sooner! The information you are looking for already exists at https://docs.docker.com/engine/swarm/manage-nodes/. You'll probably find lots of good info there!


fix: OPTIC-411: [lsp] Fix Follow Redirects improperly handles URLs in the url.parse() function

Hi @yyassi-heartex!
This PR was created in a response to PRs in upstream repos:

https://github.com/HumanSignal/dm2/pull/299
https://github.com/HumanSignal/label-studio-frontend/pull/1687

/git merge develop


feat: broadcast 1000 documents

Most of the changes were irrelevant to this point, so basically it's a rewrite using a count input and accumulating stats instead of whole documents in the memory


Dangerous behavior: Installing a provider erases uncommitted, tracked code when run from a git repo directory

Expected Behavior
This app should be safe to run in a git repo.
Actual Behavior
Any uncommitted but tracked code will be erased, presumably by this command running with the wrong working directory.
Steps to Reproduce (including precondition)

Create an empty repo
track a file
install a provider
lose your work

mkdir git-test
cd git-test
git init
touch file
git add file
git status
m1-terraform-provider-helper install hashicorp/template -v 2.1.2
git status

Screenshot on This Problem (if possible)

Your Environment

OS: MacOS 12.0.1
m1-terraform-provider-helper version: stable 0.2.3

I saw this too late...

This package should be removed from brew immediately.

Thanks for reporting this! I will push a fix in a few minutes

I released a new version 0.2.4 which should fix this problem by making sure to run the git commands in the correct directory.. Sorry for the problems this did cause @RulerOf and @jspiro ! Definitely have to work on #3 when I find time...


[SUPPORT] How we can speed up individual file write(HoodieMergeHandle part)

Describe the problem you faced
We are using Spark 3.3 and Hudi 0.12.2.
I need your assistance in helping me to improve the Doing partition and writing data stage. For us, it looks to be the most time consuming. We are using snappy compression(the most lightweight from available as I know), file size is ~160mb, which is effectively 80-90 GB GZIP(default codec in Hudi for our workload). Files itself consist of 1.5-2M rows.
So our problem is that unfortunately due to partitioning + CDC nature, we must udpate a lot of files at peak hours, we have clustering to group rows together, but it's still thousands of files affected. 75th percentile of individual file overwrite(task in the Doing partition and writing data stage) takes ~40-60 seconds, it does not correlate to the number of rows updated inside(for 75th percentile it's < 100 rows changed in every file). Also - the payload class is almost default(minor changes which not affect performance IMO).
Q:

What are knobs we can play with?
We tried compression format(snappy looks to be the best among zstd- has memory leak in Spark 3.3 BTW and gzip)
Also we tried hoodie.write.buffer.limit.bytes - rising to 32MB, unfortunately no visible difference.
Is there any other?
Do you know some performance improvements in newer versions(0.12.3-0.14.1) regarding specifically file write(MergeHandle) task

Environment Description

Hudi version : 0.12.2

Spark version : 3.3.0

@VitoMakarevich Just checking if you have lots of file groups impacted in each batch, then why not use MERGE_ON_READ table.
In your current setup, you can only try to optimize the parquet writes which you have already tried.
Adding @xushiyan to suggest more to optimize performance.

+1 to use MOR to balance the ingestion speed and merge cost through compaction. There is also a new feature in 0.13.x https://hudi.apache.org/releases/release-0.13.0#simple-write-executor-as-default to improve write handle performance.

Hello, thanks for the suggestions! As I said, I'd like to know how I can speed up this individual part, I know it's option to use MOR in theory, but it's impossible for our use case.

we have clustering to group rows together, but it's still thousands of files affected. 75th percentile of individual file overwrite(task in the Doing partition and writing data stage) takes ~40-60 seconds

based on this, i think clustering can be tuned further to rewrite files such that more updates can be targeted to the same file to reduce write amplification. Make sure your number of clustering groups is not limited to default 30, otherwise you miss a lot of files to cluster. COW is expected to have high write amplification with heavy updates, especially if you spread out the updates to a lot of files. Also consider a better partitioning to have updates concentrated on a few partitions if possible. Upgrade to newer version to try configuring the executor type too.

Thanks! Yeah, we are certain we run clustering for all partitions which are big enough, it's a big effort to analyze data for optimal clustering settings, that's why I'm asking about write optimization.


Not working

Hello @mnafees , i think whatsapp changed their selector names on web whatsapp.
Do you plan to update it ?

would be great to know. i


Remove unused sections for bpf_lxc from nodeport header

Background
One of the Kubernetes SLO is the Pod Startup Latency SLO. The current limit is the 99th percentile <= 5s. With the use of cilium Kubernetes is very close to this limit, sometimes even exceeding it. One of the major bottlenecks is eBPF program verification performed by kernel.
Change description
I went through the code to find kernel verification times for different sections, the most consuming ones were tail_nodeport_nat_egress_ipv4 and tail_nodeport_nat_egress_ipv6. These sections are actually not used by bpf_lxc at all, but added and verified by kernel. So this change removes unused for bpf_lxc sections from nodeport header. After this change the total verification time for all programs for bpf_lxc reduced almost twice (from ~500ms to ~270ms). And with all the routine to load program, these changes contributed to the whole latency drop even more.
Test scenario
All tests were run on the cluster version 1.24.4-gke.300. The cilium master branch was used as a baseline for all the tests.
To test different configurations a GKE sandbox with custom Dataplane v2 images was used. The cluster was created with 100 nodes and DPv2 enabled. For Pod Startup Latency measurements a modified configuration of a GKE Scalability 100 nodes performance test was used.
In the beginning for each run 1 pod was created on each node with the same image as in Pod Startup Latency measurement, so image pull time is not affecting the resulting latency. Then 500 deployments with 5 pods each were created and waited until running to measure the pod startup latency.
Results
Result were aggregated from 20 separate test runs.

Percentile
Baseline
Optimized

P50
3088 ms
2584 ms

P90
3701 ms
3169 ms

P99
4126 ms
3573 ms

Summary
This optimization reduces the total latency by ~500ms and removes unnecessary sections loading to kernel.
Remove unused sections for bpf_lxc from nodeport.h

Signed-off-by: Alex Katsman<EMAIL_ADDRESS>

Hi, thanks for approval, I added a release note and resolved conflicts. I believe this change should have a release-note/misc label (based on what I see in the contributing guide), but I'm not able to change labels.

/test

/test

Hi, thanks for your help towards merging this PR. I have a question, whether this change could be a candidate for a backport to 1.12?

This kind of change would typically not be a candidate for backporting based on the standard backporting criteria, as it is not a fix: https://docs.cilium.io/en/stable/contributing/release/backports/#backport-criteria
That said, if we think the risk is low but benefit is high here then it may be worth backporting to 1.12.x. I know that there are occasionally user-reported issues around the ability of Cilium to create pods at a certain rate, and this could have a meaningful impact on those users. This seems at least reasonable to raise as a discussion point during the next community meeting, I'll put it on the agenda.

Hi @alexkats,
We discussed this change and its backport in the community meeting today. It would help to have a bit more information on this bug (the broken SLO specifically) and how common it might be.
Specifically, could you share on which kernel(s) you made the measurements and with what Cilium configuration(s)?

With the use of cilium Kubernetes is very close to this limit, sometimes even exceeding it.

In which conditions was it exceeding the limit? Your numbers show that it's always <5s, but I'm guessing some of the runs exceeded 5s? Is that still happening just less frequently with this patch?

The cilium master branch was used as a baseline for all the tests. To test different configurations a GKE sandbox with custom Dataplane v2 images was used.

I'm also a bit confused by these two sentences. Did you test this with Cilium OSS or with GKE's patched Cilium version?

Hi @pchaigno,
Thanks for the discussion.
I used GKE's patched Cilium version based on Cilium OSS master (that's why I stated that I used the master branch). The kernel version used was 5.10.109.
Actually, we try to aim for 3.5 seconds. We want to minimize the pod startup latency regression when changing kube-proxy based dataplane to Cilium on GKE. There is a k8s SLO - 99th percentile per cluster-day <= 5s, we have room to spend but we want to use as little as possible of it.
I performed tests with different number of nodes in the cluster, specifically 100, 500 and 5k.

With 100 nodes it didn't go beyond 5 seconds, but comes pretty close from time to time to the limit.
When running with 500 nodes the average number for P99 is still within 5 seconds, but sometimes goes over and reaches around 5.5 seconds.
For 5k nodes the latency is at ~6 seconds on average, but goes even beyond it quite often.

With the change we go further away from the limit for 100 and 500 nodes, and become closer to 5 seconds for 5k nodes.

Hi @alexkats,
Thanks for the details!
It sounds like we still have a bug (SLO breakage) at scale. Could you open an issue so we can properly track that? We will also be able to refer to that issue as motivation when backporting the present pull request.
Did you collect Cilium metrics when running those benchmarks? It would be useful to understand where the additional pod creation latency is coming from (e.g., slow kube-apiserver at scale).

Hi @pchaigno ,
I created the issue #22023.
Regarding metrics, I didn't really take a look into them yet, but I plan to do it when running new tests.


feat: add web app example in Typescript with a custom toolchain

The nestjs and ts_project_transpiler examples already use swc. Do we also want this one? Or is it specifically the --override_repository you want to highlight in this one?
We do need a good react example though, we could this one or https://github.com/aspect-build/bazel-examples/pull/9 is still open.


Unable to use email address as username when custom registration form is enabled

Description of bug
When registration form type "custom", is selected, the option to use email address as username disappears.
Steps to reproduce

Login as admin, choose Persona Bar ->Settings -> Security
Select "Member Accounts" tab
Select "Registration Settings"
Select "Custom" for "Registration Form Type"

Current result
The option to "Use Email Address as Username" disappears.
Expected result
The option to "Use Email Address as Username" should be available.
Screenshots

Affected version

[x] 9.2.1

Affected browser

[x] Chrome
[x] Firefox
[x] Safari
[x] Internet Explorer
[x] Edge

Will try to check this out in the next DNN OpenSource Co-coding session !


Is it possible to disable PDFFetchStream?

As detailed in #9862 we're having issues with range requests when using PDFFetchStream.
I'm wondering if there is a simple way for us to disable it so that all browsers will use PDFNetworkStream instead?
The only ways I can think of to do it are either to recreate our own version of /lib/pdf.js with modified setPDFNetworkStreamFactory code, or perhaps to create a private fork of pdfjs-dist and simply modify /lib/pdf.js in there, both of which seem a bit extreme.

I'm wondering if there is a simple way for us to disable it so that all browsers will use PDFNetworkStream instead?

If what you're asking for is a runtime flag to disable the use of the Fetch API, then that does not seem like a good idea to me.
The reason is that the Fetch API, assuming obviously that it works correctly in the browser, would now be preferred over using XMLHttpRequest in general. However, adding a runtime flag to disable the use of the Fetch API could very easily lead to people setting it all the time[1] just because there may be issues in some specific configurations, leading to worse overall performance when using the PDF.js library.
Since the problem seem to be limited to a certain browser, the best way forward would probably be if someone was able to come up with a reduced test-case such that a bug report could be filed with the browser vendor.

[1] This is probably not just a theoretical concern either, since the situation reminds me of the runtime option to disable workers which was present in PDF.js versions 1.x.y.
Disabling workers results in worse performance, and is neither properly tested or supported, but nonetheless most third-party PDF.js examples (that I've seen) were recommending to disable workers rather than showing how correctly set-up the library.

Well, it's not for me to tell you what the best way forwards is with the pdf.js API and I can fully appreciate your desire to prevent people naively reducing the performance of the library, but my (perhaps ignorant) understanding is that the main advantage of  fetch vs XHR is that it returns a promise. I'm not aware that it offers any performance benefit. On the other hand, having range requests broken in the most popular browser desktop browser, with no simple way to fix them is quite a concern. For us it means that people on even slightly constrained networks have a really extended wait to view a pdf when using chrome.
That being said, this issue is 5 months old. I should (and will) re-test chrome as soon I can (some time in the next two weeks) and update.
Thanks for your response.

Sorry, clicked the wrong button!

[...] but my (perhaps ignorant) understanding is that the main advantage of fetch vs XHR is that it returns a promise. I'm not aware that it offers any performance benefit.

For example: Using the Fetch API allows the initial request to continue, whereas ranged loading with XMLHttpRequest requires aborting the initial request and then start issuing range requests instead.
Hence using the Fetch API will, generally, result in quicker overall document loading.

@timvandermeij As outlined in https://github.com/mozilla/pdf.js/issues/9863#issuecomment-430577828, making this configurable  this doesn't seem like a good idea in general; closing as WONTFIX?


Missing Headers esp_netif.h and esp_wifi.h

Hardware description: esp32s3
RTOS: freeRTOS
Version or commit hash: humble

issue
I get always an error, when I try to build my projects.
log.txt

I have installed ESP-IDF with the VS-Code extension
I haven`t sourced humble
I cloned this repository  in the esp-idf/components/ folder
when I try to build an example the error occurs

Please provide instructions for replicating the issue, also provide which ESP-IDF version are you using

I use ES-IDF 5.0

I have installed ESP-IDF with the VS-Code extension
I haven`t sourced humble
I cloned this repository in the esp-idf/components/ folder
copied the int32-publisher example into my main esp folder
opened it with vs-Code
select esp32s3 as target and /dev/ttyUSB0 as port
edited the menuconfig with my wifi`s ssid and password
Hit build and the error from the log.txt  file occurs

ESP-IDF v5 is not supported:

Check this: https://github.com/micro-ROS/micro_ros_espidf_component/pull/162


Sorted lists

Addresses #81.

Just for visibility: we're going to pause this issue for now, since the root cause of our problems on Liqwid was an unsorted map rather than a list, and we're going to focus on tackling that issue first.

This repository has been archived. This PR should be recreated in the liqwid-libs repo if it's still important. Closing.


surface-pro-6.conf: Explicitly disable firmware compression

The Surface Pro 6 is stuck with kernel 5.0 which does not support firmware
compression. We want to make firmware compression opt-out rather than opt-in,
therefore it needs to be explicitly disabled for the device.

@balena-ci rebase

@balena-ci rebase


Parse/Export specified language files only

Dear @eapache ,
I am working on an unreleased Vim plugin vim-codequery. It requires your elegant starscope to export its database to ctags and cscope files for further use.
The problem I faced is that it does not support to parse specific language files only or export its database by language separately. I tried --exclude option, but I can not figure out how to compose a pattern to parse individual language files. (Did I miss something ? 😕)
Is it possible to add an option such as starscope --lang ruby -e ctags to index individual language files and then export it only?

Hmm, you can filter queries by language (see https://github.com/eapache/starscope/blob/master/doc/USER_GUIDE.md#queries) but I don't think you can filter exports that way.
You could probably pass an appropriate pattern when building the database in the first place; for a fresh database, starscope **/*.rb should pick up only ruby files, for example.


[Improvement]: LS completions for resource-access-action include $^, $^^ path-segments

Description
Currently, the behavior of providing completions for resource-access-actions is as follows.

The names of the path segments $^, and $^^ are meaningless for the ballerina user. We need to come up with a proper names/values to represent this.
ballerina code
client class BookService {
    resource function get .() {
    }

    resource function get [int bookId]/["authors"]() {
    }

    resource function get [string...]() {
    }
}

public function main() {
    BookService bookService = new;
    bookService->
}

Describe your problem(s)
At the root, in the compiler, we assign $^, and $^^ if there are no variables associated with the resource functions path segment. This is okay for now. We need to solve this either through the Semantic API level or the Language-Server level.
Describe your solution(s)
No response
Related area
-> Editor
Related issue(s) (optional)
No response
Suggested label(s) (optional)
No response
Suggested assignee(s) (optional)
No response

This behaviour is due to the name of the respective paramter symbols being $^ and $^^.
From the LS side we can address the above as follows.
Case 1
resource function get [int bookId]/["authors"]() {
}

The suggested completion item's label should be /[int bookId]/["authors"].
Case 2
resource function get [string...]() {
}

In this case we have to suggest two completion items. See https://github.com/ballerina-platform/ballerina-lang/issues/39661#issuecomment-1468603644.
Therefore, the suggested completion items' labels should be /<path> and /[string... paths].

+1

@dulajdilshan found the following when investigated.

The Named path segment corresponding to the  ["authors"] is does not have the "authors" information in it. Therefore we have to fix that from the semantic API side.
And the following is modelled incorrectly as well
resource function get [string...]() {
}

The resourcePath of the resourceMethodSymbol should consist of a path rest param. Instead it has a named segment.

@dulajdilshan found the following when investigated.

Some of the cases will be addressed via https://github.com/ballerina-platform/ballerina-lang/pull/39477.

The Named path segment corresponding to the  ["authors"] is does not have the "authors" information in it. Therefore we have to fix that from the semantic API side.

Yeah. We can improve this at the semantic API level by getting the type-info (which is a finite-type) and assign it's type name to the name of the named-path

The resourcePath of the resourceMethodSymbol should consist of a path rest param. Instead, it has a named segment.

This needs to be addressed. Btw Path-segment list doesn't need to have all named-path segments, we can have parameters and rest param as well. But this case needs to be addressed since it is wrong to give NamedPAthSegment for RestPathSegment

The problem cannot be reproduced with version 2201.8.6.

However, as mentioned in the above discussions, there are a few improvements made to the completions of the rest param in a resource access, and it is tracked here: https://github.com/ballerina-platform/ballerina-lang/issues/42298.


Handle nested JSON objects in x-success callback

Potential fix for https://github.com/martinfinke/xcall/issues/8.
When an x-callback-url scheme returns nested JSON objects, this should correctly deserialize and serialize as JSON.
E.g. to test with Bear's /todo action:
./xcall -url "bear://x-callback-url/todo?search=Manage%20todos%20with%20Bear%20and%20Alfred&token=$BEAR_TOKEN"

This returns the following JSON object:
{
  "notes": [
    {
      "creationDate": "2022-01-13T20:51:40Z",
      "tags": "[\"2022\",\"todo\",\"2022\\/01\",\"2022\\/01\\/13\"]",
      "title": "#todo Manage todos with Bear and Alfred",
      "modificationDate": "2022-01-19T04:00:06Z",
      "identifier": "65E26BBC-FB7E-46BF-BA5A-CF00E53B9784-42634-00025251E8230FF8",
      "pin": "no"
    }
  ]
}

(Note the tags property isn't correctly handled, I confirmed with the Bear support folks this is due to a limitation with the JSON serializer they are using 😸).
Closes #8.

How can I build a version of xcall with this fix, by hand? or is there better way.
thanks