[WIP] Context menu

This is a work in progress.
The PR solves https://github.com/Klocman/Bulk-Crap-Uninstaller/issues/331. It fulfills the minimum requirements. It is hard to test shell extensions.

Let me know when it's ready for review, I'll look into it for the next release.

This is a work in progress.
The PR solves #331. It fulfills the minimum requirements. It is hard to test shell extensions.

Is there a reason why you explicitly get the shortcut target file by using binary file reading?
Optionally it's possible to implement it without calling for a filestream, which sounds more performant in my eyes (correct me if I'm wrong please). e.g. this stackoverflow post
Please think about it if you're still working on this.

Hi @Klocman,
Life happened I couldn't work on this, and actually, I even forgot I worked on this.
When I checked the So page you mentioned, I saw the comment which I used as a reference: https://stackoverflow.com/a/29749787/5910839
It is actually in the comments of GetShortcutTarget method. The intent was to minimize the dependencies but eventually it got out of that direction. In order to simplify, using Shell32 may be easier to implement. But it needs to be tested. I cannot work on it in the short term.
Feel free to close, archive, edit or rewrite the PR.
N.B: Sorry for the late response.

Pls Update -  Has this not yet been implemented?


Link to the faucet not working

Bug description
The link to the Faucet proposed when a new wallet is created does not work (dead link?).
To Reproduce
Steps to reproduce the behaviour:

Open the Desktop wallet
Create a new wallet
Click on the "get coins" link. Nothing happens...

Current behaviour
Nothing happens when clicking on "get coins".
Expected behaviour
The link should send us to the Beam faucet.
Remark: This issue is independent of the fact the the faucet might or might not be empty...
Platform and build

Tested on Windows 10
BEAM Build number: 7.5.13840

Screenshots

That has been removed, see #1042


not_operators_with_space_fixer vs not_operator_with_successor_space

Inconsistent naming here. One of them uses the plural, operators, while the other does not.

Please send a PR.

Which one do you prefer as the "correct" one?

For me both ways are fine

Remind me to do this tomorrow. ;)

ping @GrahamCampbell

Sent a PR.


Remove BulkGetResponse.Got property.

Do not merge until dapr/dapr has an official 1.11 branch and this PR is updated to pull protos from that branch.

Description
Updates the BulkGetResponse type, removing the the Got property which has been removed from the protos in Dapr 1.11.  The runtime in this release consolidates the handling of bulk operations such that the property is no longer needed. As a change to the protos is breaking, the pluggable component SDKs must be updated to match.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #33
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[ ] Extended the documentation

Whoops, merged the wrong PR!  In any case, @tmacam says "LGTM".


Handle ConfigMap created by workload container during application remove

Description
Handle ConfigMap created by workload container during application remove
There is a ConfigMap created by workload container seldon-core to track its leadership:
kubectl -n <namespace> get configmap a33bd623.machinelearning.seldon.io -o=yaml
apiVersion: v1
kind: ConfigMap
metadata:
  annotations:
    control-plane.alpha.kubernetes.io/leader: '{"holderIdentity":"seldon-controller-manager-5ff5b59788-r9c5b_d5372a80-cf0b-49ce-88d6-4c33a1096f28","leaseDurationSeconds":15,"acquireTime":"2023-03-23T18:52:51Z","renewTime":"2023-03-23T18:54:15Z","leaderTransitions":1}'
  creationTimestamp: "2023-03-23T18:49:51Z"
  labels:
    app.juju.is/created-by: seldon-controller-manager
  name: a33bd623.machinelearning.seldon.io
  namespace: kf
  resourceVersion: "4439"
  uid: 7dfa723e-5286-435b-a633-84a25f340506

This ConfigMap has expiration time of 45 seconds.
Initial problem was detected when testing upgrade: deploying stable charm and then upgrading to updated one with 45 seconds failed upgrade due to container inability to acquire lock on ConfigMap above:
 error retrieving resource lock kf/a33bd623.machinelearning.seldon.io

If upgrade is performed outside of expiration window it succeeds.
On application removal this ConfigMap (a33bd623.machinelearning.seldon.io) is not removed. It should be removed.

Seldon-core hardcodes the name of that ConfigMap:
seldon-core$ grep a33bd623  * -rn
helm-charts/seldon-core-operator/values.yaml:88:  leaderElectionID: a33bd623.machinelearning.seldon.io
helm-charts/seldon-core-operator/README.md:79:| manager.leaderElectionID | string | `"a33bd623.machinelearning.seldon.io"` |  |
operator/bundle/manifests/seldon-operator.clusterserviceversion.yaml:450:                  value: a33bd623.machinelearning.seldon.io
operator/bundle-certified/manifests/seldon-operator-certified.clusterserviceversion.yaml:450:                  value: a33bd623.machinelearning.seldon.io
operator/config/manager/manager.yaml:47:          value: "a33bd623.machinelearning.seldon.io"
operator/main.go:57:	leaderElectionIDDefault = "a33bd623.machinelearning.seldon.io"


decode speed depends on chunk size

Dear wenet members.
I used the script written below
the difference is only --chunk_size (16, -1)
./build/bin/decoder_main
--chunk_size 16 \ <-> -1
--thread_num 5
--wav_scp $wav_path
--model_path $model_dir/final.zip
--unit_path $model_dir/units.txt 2>&1 | tee log.txt
i saw some wire results when i use chunk size 16
the results written below
I1124 08:28:39.623006  1356 decoder_main.cc:105] Decoded 3275ms audio taken 28637ms.
I1124 08:28:39.728370  1360 decoder_main.cc:105] Decoded 5210ms audio taken 28731ms.
I1124 08:28:39.781566  1359 decoder_main.cc:105] Decoded 5810ms audio taken 28763ms.
I1124 08:28:41.332217  1358 decoder_main.cc:105] Decoded 5215ms audio taken 30348ms.
I1124 08:28:41.367691  1356 decoder_main.cc:105] Decoded 6730ms audio taken 1725ms.
I1124 08:28:49.478484  1358 decoder_main.cc:105] Decoded 6625ms audio taken 8130ms.
I1124 08:28:49.526084  1359 decoder_main.cc:105] Decoded 9635ms audio taken 9719ms.
I1124 08:28:49.529465  1356 decoder_main.cc:105] Decoded 10575ms audio taken 8132ms.
I1124 08:28:49.727684  1357 decoder_main.cc:105] Decoded 13895ms audio taken 38702ms.
I1124 08:28:49.780489  1360 decoder_main.cc:105] Decoded 15720ms audio taken 10012ms.
I1124 08:28:50.161931  1360 decoder_main.cc:105] Decoded 2710ms audio taken 372ms.
I1124 08:28:50.318866  1358 decoder_main.cc:105] Decoded 6610ms audio taken 821ms.
I1124 08:28:50.445773  1357 decoder_main.cc:105] Decoded 5815ms audio taken 700ms.
I1124 08:28:50.729379  1360 decoder_main.cc:105] Decoded 4405ms audio taken 554ms.
I1124 08:28:50.811239  1357 decoder_main.cc:105] Decoded 2715ms audio taken 358ms.
I1124 08:28:50.968897  1359 decoder_main.cc:105] Decoded 10555ms audio taken 1415ms.
I1124 08:28:51.098784  1356 decoder_main.cc:105] Decoded 11175ms audio taken 1536ms.
I1124 08:28:51.158071  1357 decoder_main.cc:105] Decoded 2680ms audio taken 339ms.
I1124 08:28:51.264426  1360 decoder_main.cc:105] Decoded 4090ms audio taken 522ms.
I1124 08:28:51.608510  1357 decoder_main.cc:105] Decoded 3445ms audio taken 441ms.
I1124 08:28:51.883816  1360 decoder_main.cc:105] Decoded 4670ms audio taken 608ms.
I1124 08:28:52.240777  1358 decoder_main.cc:105] Decoded 13275ms audio taken 1888ms.
I1124 08:28:52.455902  1359 decoder_main.cc:105] Decoded 10435ms audio taken 1458ms.
I1124 08:28:52.956656  1360 decoder_main.cc:105] Decoded 7915ms audio taken 1051ms.
I1124 08:28:53.217851  1357 decoder_main.cc:105] Decoded 11640ms audio taken 1580ms.
I1124 08:28:53.306288  1358 decoder_main.cc:105] Decoded 7830ms audio taken 1044ms.
I1124 08:28:53.392740  1360 decoder_main.cc:105] Decoded 3330ms audio taken 427ms.
I1124 08:28:53.689960  1356 decoder_main.cc:105] Decoded 16790ms audio taken 2544ms.
I1124 08:28:54.134187  1359 decoder_main.cc:105] Decoded 11655ms audio taken 1647ms.
I1124 08:28:54.182366  1358 decoder_main.cc:105] Decoded 6550ms audio taken 859ms.
I1124 08:28:54.231544  1356 decoder_main.cc:105] Decoded 4275ms audio taken 529ms.
I1124 08:28:54.538321  1356 decoder_main.cc:105] Decoded 2225ms audio taken 300ms.
I1124 08:28:54.580708  1358 decoder_main.cc:105] Decoded 3250ms audio taken 389ms.
I1124 08:28:54.604974  1360 decoder_main.cc:105] Decoded 8870ms audio taken 1189ms.
I1124 08:28:55.002360  1359 decoder_main.cc:105] Decoded 6615ms audio taken 848ms.
I1124 08:28:55.029304  1357 decoder_main.cc:105] Decoded 12445ms audio taken 1779ms.
I1124 08:28:55.045656  1358 decoder_main.cc:105] Decoded 3540ms audio taken 455ms.
I1124 08:28:55.091445  1356 decoder_main.cc:105] Decoded 4010ms audio taken 541ms.
when i start decoding, i need long time for decode
but it is getting faster and faster..
On the other hand, chunk size -1
the decoding speed is constant

I1124 08:27:42.871932  1286 decoder_main.cc:105] Decoded 3275ms audio taken 941ms.
I1124 08:27:42.900110  1287 decoder_main.cc:105] Decoded 5215ms audio taken 967ms.
I1124 08:27:42.911448  1285 decoder_main.cc:105] Decoded 5810ms audio taken 971ms.
I1124 08:27:42.916059  1289 decoder_main.cc:105] Decoded 5210ms audio taken 952ms.
I1124 08:27:43.868875  1288 decoder_main.cc:105] Decoded 13895ms audio taken 1883ms.
I1124 08:27:45.274590  1286 decoder_main.cc:105] Decoded 6730ms audio taken 2389ms.
I1124 08:27:46.902217  1286 decoder_main.cc:105] Decoded 6610ms audio taken 1615ms.
I1124 08:27:46.943917  1289 decoder_main.cc:105] Decoded 6625ms audio taken 4015ms.
I1124 08:27:47.029280  1285 decoder_main.cc:105] Decoded 9635ms audio taken 4099ms.
I1124 08:27:47.037636  1288 decoder_main.cc:105] Decoded 10575ms audio taken 3149ms.
I1124 08:27:47.253921  1287 decoder_main.cc:105] Decoded 15720ms audio taken 4325ms.
I1124 08:27:47.294570  1288 decoder_main.cc:105] Decoded 2710ms audio taken 251ms.
I1124 08:27:47.544210  1285 decoder_main.cc:105] Decoded 5815ms audio taken 503ms.
I1124 08:27:47.642027  1287 decoder_main.cc:105] Decoded 4405ms audio taken 379ms.
I1124 08:27:47.783713  1285 decoder_main.cc:105] Decoded 2715ms audio taken 234ms.
I1124 08:27:47.815616  1286 decoder_main.cc:105] Decoded 10555ms audio taken 893ms.
I1124 08:27:48.001384  1287 decoder_main.cc:105] Decoded 4090ms audio taken 351ms.
I1124 08:27:48.018872  1289 decoder_main.cc:105] Decoded 11175ms audio taken 1054ms.
I1124 08:27:48.026834  1285 decoder_main.cc:105] Decoded 2680ms audio taken 237ms.
I1124 08:27:48.317885  1289 decoder_main.cc:105] Decoded 3445ms audio taken 292ms.
I1124 08:27:48.432368  1285 decoder_main.cc:105] Decoded 4670ms audio taken 396ms.
I1124 08:27:48.594731  1288 decoder_main.cc:105] Decoded 13275ms audio taken 1275ms.
I1124 08:27:48.821668  1286 decoder_main.cc:105] Decoded 10435ms audio taken 986ms.
I1124 08:27:49.142170  1285 decoder_main.cc:105] Decoded 7915ms audio taken 695ms.
I1124 08:27:49.278682  1288 decoder_main.cc:105] Decoded 7830ms audio taken 669ms.
I1124 08:27:49.421458  1289 decoder_main.cc:105] Decoded 11640ms audio taken 1081ms.
I1124 08:27:49.432744  1285 decoder_main.cc:105] Decoded 3330ms audio taken 284ms.
I1124 08:27:49.793706  1287 decoder_main.cc:105] Decoded 16790ms audio taken 1761ms.
I1124 08:27:49.886099  1286 decoder_main.cc:105] Decoded 11655ms audio taken 1042ms.
I1124 08:27:50.011909  1289 decoder_main.cc:105] Decoded 6550ms audio taken 577ms.
I1124 08:27:50.153266  1287 decoder_main.cc:105] Decoded 4275ms audio taken 351ms.
I1124 08:27:50.247462  1285 decoder_main.cc:105] Decoded 8870ms audio taken 798ms.
I1124 08:27:50.295675  1289 decoder_main.cc:105] Decoded 3250ms audio taken 277ms.
I1124 08:27:50.363186  1287 decoder_main.cc:105] Decoded 2225ms audio taken 205ms.
I1124 08:27:50.438823  1286 decoder_main.cc:105] Decoded 6615ms audio taken 540ms.
I1124 08:27:50.509759  1288 decoder_main.cc:105] Decoded 12445ms audio taken 1207ms.
I1124 08:27:50.625085  1285 decoder_main.cc:105] Decoded 4010ms audio taken 369ms.
I1124 08:27:50.629228  1289 decoder_main.cc:105] Decoded 3540ms audio taken 326ms.
How can i fix this situation ..?

It's a common issue about warmup, please see:

https://github.com/wenet-e2e/wenet/issues/1425
https://github.com/wenet-e2e/wenet/issues/1669
https://github.com/wenet-e2e/wenet/issues/1661


Get the card index and data associate with each card when swiped left or right.

Hello,
Thanks for developing such a great library.
I am developing one application using this library.
I create the cardModel and set some of the data to view on card i.e cardId and Title and I add to SimpleCardStackAdapter.
I need to get the those data associate with card when I swipe card to left or right (when card removes from the list)
Also another requirement is that at all the times viewed card stay to be in center of device and not inclined.
How can I do this ? Can you please help me out ?
Thanks.

Implement removeFirstObjectInAdapter() in your OnFlingListener implementation, and remove the first object of the adapter like the method name implies. Then you know that the object in the topmost card, the one that is swiped away, is always the first object in the adapter: the object at index 0.

Okay, thanks for your help, Actually I want to post this query to another library 'kikoso/Swipeable-Cards', but by mistake post here.
You already implement the above requirement.
Now If I want to implement disordered cards implemented like in https://github.com/kikoso/Swipeable-Cards this library, How can I implement that disordering.
My need is that only 3 cards have been display in screen and the first viewed card always be straight and not inclined, the other cards behind the first card can be inclined.
Can you please help me out ?
Thanks.

I'm not familiar with the changes in that fork, you'll have to ask the author there.


Update nightwatch.conf.js

On Windows an error is thrown if there's no value in src_folders. The --test parameter is ignored on Windows. On OS X is working without this change.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


bump okhttp-urlconnection from 2.0.0 to 2.7.5

Bumps okhttp-urlconnection from 2.0.0 to 2.7.5.

Release notes
Changelog
Commits

FINERACT-963

FINERACT-804

FINERACT-804

#872


Request for CDP access for Webkit image

Currently I am using Chrome using CDP in Selenoid
I took a look at the page
https://aerokube.com/images/latest/#_browser_image_information
I understand CDP is available for Chrome 85 .. Chrome 90
Will it be possible to access WebKit mentioned in
https://aerokube.com/images/latest/#_safari
using the CDP

@james-k-mathew currently we never did such research.


Add command to quickly add a CRA / Parcel playground

this would be amazing! I have a couple of small react libs and setting up a playground for each has been a bit painful.

Closed by #59. Available in 0.5.3


Output 0 of _DDPSinkBackward is a view and is being modified inplace. This view is the output of a function that returns multiple views. Such functions do not allow the output views to be modified inplace. You should replace the inplace operation by an out-of-place one.

Our environment: 3090x2, ubuntu 1804,  Pytorch 1.10.0 py3.8_cuda11.3_cudnn8.2.0_0
Task: Classification(ImageNet 1k),  Finetune, OFA-tiny
2023-01-11 17:09:16 - trainer.py[line:703] - INFO: begin training epoch 1
2023-01-11 17:09:16 - train.py[line:305] - INFO: Start iterating over samples
Traceback (most recent call last):
File "train.py", line 537, in
Traceback (most recent call last):
File "train.py", line 537, in
cli_main()
File "train.py", line 530, in cli_main
cli_main()
File "train.py", line 530, in cli_main
distributed_utils.call_main(cfg, main)
File "/home/yhh/yhh/codes/multimodal/OFA/fairseq/fairseq/distributed/utils.py", line 374, in call_main
distributed_utils.call_main(cfg, main)
File "/home/yhh/yhh/codes/multimodal/OFA/fairseq/fairseq/distributed/utils.py", line 374, in call_main
distributed_main(cfg.distributed_training.device_id, main, cfg, kwargs)distributed_main(cfg.distributed_training.device_id, main, cfg, kwargs)
File "/home/yhh/yhh/codes/multimodal/OFA/fairseq/fairseq/distributed/utils.py", line 348, in distributed_main
File "/home/yhh/yhh/codes/multimodal/OFA/fairseq/fairseq/distributed/utils.py", line 348, in distributed_main
main(cfg, **kwargs)
main(cfg, **kwargs)  File "train.py", line 199, in main
File "train.py", line 199, in main
valid_losses, should_stop = train(cfg, trainer, task, epoch_itr)
File "/home/yhh/anaconda3/envs/ofa/lib/python3.8/contextlib.py", line 75, in inner
valid_losses, should_stop = train(cfg, trainer, task, epoch_itr)
File "/home/yhh/anaconda3/envs/ofa/lib/python3.8/contextlib.py", line 75, in inner
return func(*args, **kwds)return func(*args, **kwds)
File "train.py", line 310, in train
File "train.py", line 310, in train
log_output = trainer.train_step(samples)log_output = trainer.train_step(samples)
File "/home/yhh/anaconda3/envs/ofa/lib/python3.8/contextlib.py", line 75, in inner
File "/home/yhh/anaconda3/envs/ofa/lib/python3.8/contextlib.py", line 75, in inner
return func(*args, **kwds)return func(*args, **kwds)
File "/data/yhh/codes/multimodal/OFA/trainer.py", line 806, in train_step
File "/data/yhh/codes/multimodal/OFA/trainer.py", line 806, in train_step
raise e
raise e  File "/data/yhh/codes/multimodal/OFA/trainer.py", line 773, in train_step
File "/data/yhh/codes/multimodal/OFA/trainer.py", line 773, in train_step
loss, sample_size_i, logging_output = self.task.train_step(
loss, sample_size_i, logging_output = self.task.train_step(  File "/data/yhh/codes/multimodal/OFA/tasks/ofa_task.py", line 334, in train_step
File "/data/yhh/codes/multimodal/OFA/tasks/ofa_task.py", line 334, in train_step
loss, sample_size, logging_output = criterion(model, sample, update_num=update_num)loss, sample_size, logging_output = criterion(model, sample, update_num=update_num)
File "/home/yhh/anaconda3/envs/ofa/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
File "/home/yhh/anaconda3/envs/ofa/lib/python3.8/site-packages/torch/nn/modules/module.py", line 1102, in call_impl
return forward_call(*input, **kwargs)
File "/data/yhh/codes/multimodal/OFA/criterions/label_smoothed_cross_entropy.py", line 200, in forward
return forward_call(*input, **kwargs)
File "/data/yhh/codes/multimodal/OFA/criterions/label_smoothed_cross_entropy.py", line 200, in forward
loss, nll_loss, ntokens = self.compute_loss(model, net_output, sample, update_num, reduce=reduce)
File "/data/yhh/codes/multimodal/OFA/criterions/label_smoothed_cross_entropy.py", line 245, in compute_loss
loss, nll_loss, ntokens = self.compute_loss(model, net_output, sample, update_num, reduce=reduce)
File "/data/yhh/codes/multimodal/OFA/criterions/label_smoothed_cross_entropy.py", line 245, in compute_loss
lprobs, target, constraint_masks = self.get_lprobs_and_target(model, net_output, sample)
File "/data/yhh/codes/multimodal/OFA/criterions/label_smoothed_cross_entropy.py", line 222, in get_lprobs_and_target
lprobs, target, constraint_masks = self.get_lprobs_and_target(model, net_output, sample)
File "/data/yhh/codes/multimodal/OFA/criterions/label_smoothed_cross_entropy.py", line 222, in get_lprobs_and_target
net_output[0].masked_fill(~constraint_masks, -math.inf)
RuntimeError: Output 0 of _DDPSinkBackward is a view and is being modified inplace. This view is the output of a function that returns multiple views. Such functions do not allow the output views to be modified inplace. You should replace the inplace operation by an out-of-place one.

This happens in latest pytorch, say pytorch 1.10. We just updated the code to change the in-place operation to out-of-place one. See if it works for you now.

This happens in latest pytorch, say pytorch 1.10. We just updated the code to change the in-place operation to out-of-place one. See if it works for you now.

Hi, JustinLin610. Thank you very much for your very timely reply.
In my practice, simply changing
"net_output[0].masked_fill_(~constraint_masks, -math.inf)"     to
"net_output[0] = net_output[0].masked_fill(~constraint_masks, -math.inf)"
will result in     TypeError: 'tuple' object does not support item assignment.
In my practice, I first transformed "net_output" into a list,
net_output=list(net_output)
net_output[0] = net_output[0].masked_fill(~constraint_masks, -math.inf)
Then it can be trained normally.


tripleee: Blacklist biocilium

tripleee requests the blacklist of the following keyword(s):

biocilium - MS search

biocilium has been seen in 9 true positives, 0 false positives, and 0 NAAs.


Add support for extension VK_EXT_headless_surface.

Consolidate info about CAMetalLayer and headless in MVKSurface.
MVKSwapchainImage remove getCAMetalDrawable() and focus on abstracting getMTLTexture().
MVKPresentableSwapchainImage::getCAMetalDrawable() return nil if headless.
Add MVKPresentableSwapchainImage::_mtlTextureHeadless to support a fixed MTLTexture that is not retrieved from a CAMetalDrawable.
MVKPresentableSwapchainImage refactor signalling semaphores and fences.
MVKPresentableSwapchainImage don't lock when signalling semaphores and fences.
If no present occurs, actualPresentTime will be zero. Set it to current time, instead of to desiredPresentTime, since it's more accurate.
Rework timestamps:

Remove _mvkTimestampBase so mvkGetTimestamp() is equal to mach_absolute_time(), which is used in presentation timing.
Add mvkGetRuntimeNanoseconds().
Rename mvkGetAbsoluteTime() to mvkGetContinuousNanoseconds().
Remove mvkGetTimestampPeriod() as unused.

MVKSemaphoreMTLEvent::encodeDeferredSignal remove redundant nil test (unrelated).

Fixes #2049.
Passes all related CTS WSI tests.

@cdavis5e
The (now renamed) mvkGetContinuousNanoseconds() was introduced for VK_EXT_calibrated_timestamps. Is there a reason why that time must be continuous (mach_continuous_time())? Or can it be replaced with mvkGetRuntimeNanoseconds()?

Is there a reason why that time must be continuous (mach_continuous_time())?

Yes. This is the function that's used for the CLOCK_MONOTONIC_RAW domain. VK_EXT_calibrated_timestamps doesn't have CLOCK_UPTIME or CLOCK_UPTIME_RAW domains. See the comment starting on line 1182 of MVKDevice.mm.

Thanks for noticing the connection to #2085.
While I was in there, I made a couple of additional changes about windowing systems. And while I was doing that, I also removed the documentation for visionos support, as it's really not properly supported and doesn't build correctly. Also added a deprecation warning for the old macOS and iOS surface creation extensions.


Automated cherry pick of #9075: fix(region): optimized rds backup create

Cherry pick of #9075 on release/3.5.
#9075: fix(region): optimized rds backup create

/lgtm
/approve


[rfc] Import Object#yield_self from Ruby 2.5

Ruby 2.5 decide to introduce Object#yield_self (see here). This method yields self to the block and then returns its result. The implementation is very simple:
class Object
  def yield_self
    yield self
  end
end

Should we import this method into Crystal? What do you think?

It's basically Object#try which also works for Nil with a descriptive yet still uninviting long name.

I don't really see the usecase..?

@RX14 Yes, I'd like to ask Ruby committer about usecase.

Not that I defend it, but could be used to create a variable, without creating a variable. To help keep calculations inline:
result = long.chained.computation(12).foo(1, 2, 3).yield_self {|list| list.sum * list.product }.to_s.size

RethinkDB (a database whose query language is mostly functional) has a similar operation, called do: https://rethinkdb.com/api/ruby/do/.
It is like a map, but for the entire thing.

It's similar to .tap in behavior and intent, expect it returns the block's value (not the tapped value).
I don't see much usage. Naming is verbose, and assigning to a value feels better:
list = long.chained.computation(12).foo(1, 2, 3)
result = (list.sum * list.product).to_s.size

@RX14 Why do you close this issue? (I can guess but...) If you could explain this, you should do it, or if you couldn't explain this, you shouldn't close this.

The consensus was that it wasn't really very useful. If anyone has a counterexample to discuss we can always reopen.

yield_self is for those that want a "pipe operator" in Ruby: http://mlomnicki.com/yield-self-in-ruby-25/
Like others here, I don't think it looks nice, nor I think it's readable. And since we have try (and you will probably never want to have a nil in a chain), it can work as good as yield_self.

I found very useful usecase of Object#yield_self! See this simple fizz buzz example:
def fizz?(n)
  n % 3 == 0
end

def buzz?(n)
  n % 5 == 0
end

(1..100).each do |i|
  if fizz?(i) && buzz?(i)
    puts :FizzBuzz
  elsif fizz?(i)
    puts :Fizz
  elsif buzz?(i)
    puts :Buzz
  else
    puts i
  end
end

When we have Object#yield_self, we can rewrite this:
# `def fizz?` and `def buzz` is skipped

(1..100).each do |i|
  case i
  when .yield_self { |i| fizz?(i) && buzz?(i) }
    puts :FizzBuzz
  when .yield_self { |i| fizz?(i) }
    puts :Fizz
  when .yield_self { |i| buzz?(i) }
    puts :Buzz
  else
    puts i
  end
end

In other words, Object#yield_self provides a potential to call any method in when condition against case value.
However, yield_self is tooooooooo long to type. So, I suggest another name Object#let (derived from Kotlin). What do you think?
@RX14 Please re-open this. I believe this feature makes Crystal more useful and we can discuss about this more.

But why would you want to do that? That's uglier than the if version by far.

Real world example, src/compiler/crystal/tools/doc/highlight.cr:
      case token.type
      when :NEWLINE
        io.puts

      # ...snip...

      when :IDENT
        if last_is_def
          last_is_def = false
          highlight token, "m", io
        else
          case token.value
          when :def, :if, :else, :elsif, :end,
               :class, :module, :include, :extend,
               :while, :until, :do, :yield, :return, :unless, :next, :break, :begin,
               :lib, :fun, :type, :struct, :union, :enum, :macro, :out, :require,
               :case, :when, :then, :of, :abstract, :rescue, :ensure, :is_a?,
               :alias, :pointerof, :sizeof, :instance_sizeof, :as, :typeof, :for, :in,
               :undef, :with, :self, :super, :private, :protected, "new"
            highlight token, "k", io
          when :true, :false, :nil
            highlight token, "n", io
          else
            io << token
          end
        end
      when :"+", :"-", :"*", :"/", :"=", :"==", :"<", :"<=", :">", :">=", :"!", :"!=", :"=~", :"!~", :"&", :"|", :"^", :"~", :"**", :">>", :"<<", :"%", :"[]", :"[]?", :"[]=", :"<=>", :"==="
        highlight token, "o", io
      when :"}"
        if break_on_rcurly
          break
        else
          io << token
        end
      else
        io << token
      end

when condition for keywords and operators are too long, so I want to refactor this with such constants:
KEYWORDS = Set{
  :def, :if, :else, :elsif, :end,
  :class, :module, :include, :extend,
  :while, :until, :do, :yield, :return, :unless, :next, :break, :begin,
  :lib, :fun, :type, :struct, :union, :enum, :macro, :out, :require,
  :case, :when, :then, :of, :abstract, :rescue, :ensure, :is_a?,
  :alias, :pointerof, :sizeof, :instance_sizeof, :as, :typeof, :for, :in,
  :undef, :with, :self, :super, :private, :protected, "new"
}

OPERATORS = Set{
  :"+", :"-", :"*", :"/", :"=", :"==", :"<", :"<=", :">", :">=", :"!",
  :"!=", :"=~", :"!~", :"&", :"|", :"^", :"~", :"**", :">>", :"<<",
  :"%", :"[]", :"[]?", :"[]=", :"<=>", :"==="
}

But I can't use these constants in when condition because Set#=== is not specialized currently.
When there is Object#let, this code can be rewritten:
      case token.type
      when :NEWLINE
        io.puts

      # ...snip...

      when :IDENT
        if last_is_def
          last_is_def = false
          highlight token, "m", io
        else
          case token.value
          when .let { |v| KEYWORDS.includes? v }
            highlight token, "k", io
          when :true, :false, :nil
            highlight token, "n", io
          else
            io << token
          end
        end
      when .let { |t| OPERATORS.includes? t }
        highlight token, "o", io
      when :"}"
        if break_on_rcurly
          break
        else
          io << token
        end
      else
        io << token
      end

Of course Object#let is not needed if #5269 is merged. However it is actual thing that Object#let is the most generic way to call any method against case value.
@RX14 Please imagine. Why do you hate this issue?

I think it makes sense. It would be nice to see which is faster, but I guess Set#includes? is faster than a huge when (I think this was concluded in a recent issue).

Benchmark is here and result is this:
old 358.88  (  2.79ms) (± 2.53%)       fastest
new 337.75  (  2.96ms) (± 1.87%)  1.06× slower

Object#let version is slow, but I feel it is a bit, also fast. It looks no problem to me.
/cc @asterite

And the most important point I think:

it is actual thing that Object#let is the most generic way to call any method against case value.

 Perhaps when { <code returning bool> } could work.

@RX14 that would require some lookahead in the parser to disambiguate from tuples I think. Besides  the .foo { } is using already existing constructs.
Maybe Object#bind, Object#apply ir Object#itself(&block) are short enough ?
The let looks weird to me. expr.let { |var| S } instead of let var = expr in S everything seems twisted.

Another proposal which doesn't require a change:
if func(foo)
  # do something
end

Well, {func(foo)} is a valid tuple so clearly my idea isn't sound. I maintain that if the only point of adding this method is for case then we'd be better off fixing the root of the problem - case.

Object#into is possible candidate. (or maybe Object#in, but it is too short.) I think #apply or #itself is too long.

IMHO Object#yield_self isn't bad, but perhaps #tap! could be used?

#tap! does not make sense. I think ! means mutable or danger, but this method is not mutable normally and safe. Additionally #tap is used with mutable method sometimes.

Replacing with if is good sometimes, on the other hand, it is not so good sometimes. I think highlighter.cr is such an example. When normal when value condition and other method call is mixed, this method is really useful.
And another benefit of this method is to call any method in method chaining. Any Crystal users dislike this because they are genius, so they can think the best variable name every time. However I can't do it every time. Naming is important, but writing executable program is more important, so I like this.

Re Object#let, FYI there's a ruby gem with exactly that name, see rubygems object-let.
Disclaimer: I'm the author.  Not that there's much code in there :)

I abuse #try for that too. Most time it serves well, but sometimes feels like a hack: some_method.not_nil!.try....

Disclaimer: The following is just my personal opinion on code style.
Looking at the examples by @elebow, I don't buy that this is a good way to express the code's intention.
The first example looks much better readable to me when you assign the value in the case expression:
This makes it very clear that the value of enque_job is the target of the branching expressions and can furthermore be referred to as a local variable. There's IMO no need for a nested block. It just adds noise in my opinion.
def handle_request
  # ...

    case result = enqueue_job
    when :accepted
      notify_user(:accepted)
    when :rejected
      notify_user(:rejected)
    else
      log(result)
      notify_user(:error)
    end
  end

  # ...
end

For the second example, without looking into the exact semantics of the methods being called, just considering the structural shape, I think it does a bad job explaining what's going on. It's a chain of methods being called, with the last call receiving a block that constructs a hash. It's not very obvious that this hash is actually the return value of the entire call chain.
Consider that alternative implementation instead. It does exactly the same thing, with a lot less visual clutter and much clearer in expressing how the log request data is created.
def handle_request(attrs)
  redacted_attrs = attrs.redact_private_data
  log_request({
    name: redacted_attrs["name"],
    email: redacted_attrs["email"],
    ip: request.remote_ip,
    admin: current_user.admin?
  })

  save_to_database(attrs)
end

I think the major point is that I don't agree with this sentiment:

The block parameter is visually associated with enqueue_job, and the method's namespace is not crowded with an unnecessary variable.

IMO it's not worth going lengths just to avoid introducing additional local variables in the method namespace. Introducing an additional scope just for the sake of that doesn't pay out.
Maybe it could be an idea to think about finding a middle ground for limiting the scope of local variables in some situations. For example, a local variable declared in a conditional expression (such as case result = enqueue_job ...) could be scoped to the conditional clause. If you want the variable to be visible beyond the corresponding end, it can simply be declared outside the conditional expression: result = enqueue_job; case result .... I could see that this would make kind of sense. Not sure it's really a good idea, though. It could be surprising behaviour, definitely a breaking change and has limited benefit (wether the local var is visible beyond the conditional is not really a practical issue). So it's probably not worth the effort.

@straight-shoota, I agree your suggested code is neater than my examples. Still, I think the style has merit in some situations. See these other real-world examples:

https://github.com/rails/rails/blob/main/activesupport/lib/active_support/encrypted_file.rb#L43
https://github.com/discourse/discourse/blob/main/lib/discourse.rb#L852
https://gitlab.com/gitlab-org/gitlab/-/blob/master/spec/support/shared_examples/serializers/environment_serializer_shared_examples.rb#L41-45
code search https://sourcegraph.com/search?q=context:global+yield_self+file:\.rb&patternType=literal

As for a language change regarding the scope of local variables, I agree that would be detrimental. I would argue only for adding the methods to Object. Especially since the existing Object#try is so close! And, it is unlikely that the names Object#yield_self/#then would ever be wanted in the future for some other non-Ruby-compatible behavior.

(mentioning https://github.com/crystal-lang/crystal/issues/1388#issuecomment-977696004 to link a related discussion that is not yet referenced in this thread).

I'm pretty sure that all of the examples you posted would actually be easier to read if they were written as independent expressions instead of as a chain with yield_self. IMO it introduces some cognitive overload when the primary expression is transformed to something else in the manner of x = fetch_a.yield_self { its_actually_b }.
#then would likely collide with promise pattern (e.g. https://github.com/spider-gazelle/promise/blob/0b2e527c0c9c4207456cad64bc374aa2c6a793fa/src/promise/resolved_promise.cr#L31).
Sure, #yield_self would be cheap to add and there's little chance of conflict.
But at least I would like to be convinced that it is actually useful for code improvement. So far I have the expression that it's mostly used for making code worse to read. Of course, in the end it's still a decision of the developer whether to use it or not. But when it has such a bad impact as I'm observing, then I'd rather prefer to not give the decision (at least not from stdlib; ofc anyone can add that method in user code if they wish).
Sorry for making this hard on you ;) I think this discussion is very good though, and I'm happy to approve this with convincing argument.

I had to search, but I finally found one case where it may be nice (maybe):
def key
  @key ||= begin
    cipher = OpenSSL::Cipher.new(DEFAULT_CIPHER)
    cipher.random_key.hexstring
  end
end

# self_yield allows to skip the begin/end block:
def key
  @key ||= OpenSSL::Cipher.new(DEFAULT_CIPHER).yield_self do |cipher|
    cipher.random_key.hexstring
  end
end

I still we should do it like Ruby and add a then method: https://ruby-doc.org/core-3.1.0/Kernel.html#method-i-then
Implementing that method is trivial! And it would solve all these scenarios:

People using try instead of then
People who want to have something like a pipe operator
Discussing these things over and over :-)

Related #7188 #11487

@straight-shoota :facepalm: ...
Allright, let's imagine there is some other cipher.something calls with no chaining involved? I usually solve it by extracting a method, but it may be nice to not have to create yet-another-method?
def key
  @key ||= generate_key
end

private def generate_key
  # ...
end

@asterite As said above #then may collide when designing futures, but maybe that's not a problem, since a hypothetical Future#then would just override Object#then and the original #then becomes kinda moot, so :shrug:

I still we should do it like Ruby and add a then method: https://ruby-doc.org/core-3.1.0/Kernel.html#method-i-then
Implementing that method is trivial! And it would solve all these scenarios:

People using try instead of then
People who want to have something like a pipe operator
Discussing these things over and over :-)

I agree, #then seems super idiomatic and explains the operation (and matches ruby, which is pretty normal for crystal)
In terms of examples, the reasons I love .then/.try is to build out composable conditionals like such: https://thoughtbot.com/blog/using-yieldself-for-composable-activerecord-relations


Replay history from file

Issue #274 Add a method to allow replaying history from a json file (dowloaded from cli or ui)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage increased (+0.4%) to 68.589% when pulling 6e6ec8405f82a8d160fee33229e534323beb1689 on halakaraki:replayHistoryFromFile into fac1f9aabf366305cb437dc48b7f5fcdc22f503f on uber-go:master.


[WFCORE-3311] Initialize the log manager early for the CLIEmbededServ…

…erTestCase to ensure early initialization doesn't break replacing stdout.
https://issues.jboss.org/browse/WFCORE-3311
In the org.jboss.logmanager:jboss-logmanager:2.1.0.Alpha4 System.out and System.err were captured too and used in the ConsoleHandler. This caused issues with embedded server logging output even if --stdout=discard was set. The test passed because the StdioContext was initialized before the log manager. Initializing the log manager before the StdioContext allows the log manager to capture System.out and System.err before it's been replaced.

For completeness here's a CI job run with org.jboss.logmanager:jboss-logmanager:2.1.0.Alpha4 that shows the test failing https://ci.wildfly.org/viewLog.html?buildId=76413&tab=buildResultsDiv&buildTypeId=WildFlyCore_MasterIgnoreLinux.

Outstanding!


Update calculation of sidebar scroll for non-root urls

For doc sites such as Apollo Link, the sidebar scroll hides the searchbox, since the location.pathname is /docs/link/ rather than /. The new calculation also works on the meteor docs, at least in the console 😜.
document.querySelectorAll('.item-toc a.sidebar-link')[0] === document.querySelector('.item-toc a[href=""]') for your convenience

Thank you for looking at this, @evans!  I think this does partially solve some instances of this problem, however even with this change, it appears that the search is still off the page when arriving to a sub-section anchor link, as seen in this Netlify preview of this PR (which I believe is working properly — you're the first PR to really test this implementation though!):
https://deploy-preview-52--theme-example.netlify.com/apollo-hexo-config/syntax-highlighting.html#Bash
It's possible that in order to accomplish this we might need to anchor the title and the search box and have the scrollable <div ... > content below them.  Thoughts?
To clarify, I'm suggesting that this should be pinned:

@abernix That makes total sense to pin it to the top of the sidebar. I'll try to take a look at it and see if my knowledge of html is proficient 💪


⚠ Samsung has degraded performance

In bf88dfb, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2658 ms

Resolved: Samsung performance has improved in 0afd232.


How to hide connected status on page load

Hi there,
I set
Offline.options = {checkOnLoad: false};

Expecting to hide the green status on page load without any luck.
Is this possible?

I have no coffee script clue!
But in the generated js I've changedit it to this:
  }, render = function(state) {
    var button, handler;
+    if (typeof(state)==='undefined') state = Offline.state;

    return el = createFromHTML(TEMPLATE),
        document.body.appendChild(el), null != Offline.reconnect && Offline.getOption("reconnect") && (el.appendChild(createFromHTML(RETRY_TEMPLATE)),
        button = el.querySelector(".offline-ui-retry"), handler = function(e) {
            return e.preventDefault(), Offline.reconnect.tryNow();
        }, null != button.addEventListener ? button.addEventListener("click", handler, !1) :button.attachEvent("click", handler)),
-    addClass("offline-ui-" + Offline.state), content = el.querySelector(".offline-ui-content");
+    addClass("offline-ui-" + state), content = el.querySelector(".offline-ui-content");
  }, init = function() {
-    return render(), Offline.on("up", function() {
+    return render('init'), Offline.on("up", function() {

In this way when the Offline is inited no messages are shown, only on states changes.
Hope this makes sense.

Yeah, the this patch works well even in the new version 0.7.18

Hi Ricardo,
could you pust your event handler binding? I suppose there may be the same error I encountered.
I did sth like that on first try:
Offline.on('up', myOnOnlineHandler());
which of course calls the function upon binding.
This is the correct way:
Offline.on('up', myOnOnlineHandler);

@boettner-it I have none.

I think that the ui ignores Offline.options = {checkOnLoad: false};.


Never receive updates with updateLocationAgeFilter set to kCLLocationAgeFilterNone

In locationManager:didUpdateLocations: if self.updateLocationAgeFilter is set to kCLLocationAgeFilterNone you'll never get any updates since the check (abs(howRecent) > self.updateLocationAgeFilter) will always be true and you'll hit "continue".  Shouldn't ">" be changed to "<"?

Gerard

This took some time, but it is fixed now! See version 1.3.3


bandwhich: 0.13.0 -> 0.14.0

Motivation for this change
https://github.com/imsnif/bandwhich/releases/tag/0.14.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Thanks! Also ported to stable: 1dbb648f318e37be7e2eb28bab7b3502a965c335


InfluxDB v2.6.0 Organizations with long name not showing up in web UI but do exist

Hi,
Currently we are facing a weird issue where organizations with a 'long name' frequently do not show up in the web UI.
Short names ('test', 'test2') are working without any problems so far.
Long names such as 'WhyDoesThisNotWork1' often are not displayed in the selection screen when trying to switch between organizations.
In the screenshot below only 'WhyDoesThisNotWork3' is displayed but '...1', '...2' and '...4' are missing. All of them contain buckets and as far as I know do exist. Both through the web interface and through python we get the same error when trying to (re)create the organization: "Organization x already exists". New buckets with data can also be added without any problems.

Influxdb: InfluxDB v2.6.0
Some simple log data:
InfluxDB runs in a docker container on Linux.
Log data:
ts=2023-02-03T10:53:08.553609Z lvl=info msg="index opened with 8 partitions" log_id=0f4u09VG000 service=storage-engine index=tsi
ts=2023-02-03T10:53:08.553900Z lvl=info msg="loading changes (start)" log_id=0f4u09VG000 service=storage-engine engine=tsm1 op_name="field indices" op_event=start
ts=2023-02-03T10:53:08.553943Z lvl=info msg="loading changes (end)" log_id=0f4u09VG000 service=storage-engine engine=tsm1 op_name="field indices" op_event=end op_elapsed=0.045ms
ts=2023-02-03T10:53:08.554276Z lvl=info msg="Reindexing TSM data" log_id=0f4u09VG000 service=storage-engine engine=tsm1 db_shard_id=157
ts=2023-02-03T10:53:08.554295Z lvl=info msg="Reindexing WAL data" log_id=0f4u09VG000 service=storage-engine engine=tsm1 db_shard_id=157
ts=2023-02-03T10:53:08.574798Z lvl=info msg="saving field index changes (start)" log_id=0f4u09VG000 service=storage-engine engine=tsm1 op_name=MeasurementFieldSet op_event=start
ts=2023-02-03T10:53:08.581763Z lvl=info msg="saving field index changes (end)" log_id=0f4u09VG000 service=storage-engine engine=tsm1 op_name=MeasurementFieldSet op_event=end op_elapsed=6.982ms
ts=2023-02-03T10:54:17.970728Z lvl=error msg="api error encountered" log_id=0f4u09VG000 handler=org error="organization with name LongNameTest123b already exists"
ts=2023-02-03T10:54:17.981539Z lvl=error msg="Unable to cleanup bucket after create failed" log_id=0f4u09VG000 error="bucket not found"
ts=2023-02-03T10:54:17.981566Z lvl=error msg="api error encountered" log_id=0f4u09VG000 handler=bucket error="bucket with name System05 already exists"

Has anyone got a possible solution to the problem?
Kind regards

I tested on 2.6.0 and 2.6.1 in the 3 major browsers, and I can see really long orgs. The presentation is not great, but they are there.
Can you check:

If you use the API/the CLI to list (influx org ls) do you see all of the orgs you would expect?
In your browser, reload the tab with the developer tools open and look for the orgs network call. Check the json response on that to see if all the orgs are in that list.

That will help narrow down if the issue comes from the UI or the API.

I have been facing the same issue. I posted a question on the community platform with no solution currently. https://community.influxdata.com/t/influxdb-2-2-org-can-not-be-found-on-org-list-but-is-searchable-by-name-or-id/27631

When one organization has a really large size over data for many years with the other organization with minimal data, could this be the issue. I have experienced instances were influxdb could not restart due to a time out. In that Case I resolved it following this guide, https://github.com/influxdata/influxdb/issues/21967


Smart Cities Panel

Bill G has made asks to Cisco, SAS and NCSU

Did you want me to see if there is a Cree possibility or hold on that?
On Wed, Aug 23, 2017 at 8:44 AM, Chris Mathews<EMAIL_ADDRESS>wrote:

Assigned #580 https://github.com/codeforraleigh/NCOpenPass/issues/580
to @zachambrose https://github.com/zachambrose.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/codeforraleigh/NCOpenPass/issues/580#event-1217750939,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ6IxgXmaNlfIAFKFKrXQR989lIPK8nJks5sbB67gaJpZM4O_85k
.

--
Zach Ambrose
<EMAIL_ADDRESS>919-438-2752 (office)
919-616-9969 (cell)
www.AmbroseStrategy.com
https://www.linkedin.com/in/zambrose

Do it. Rather have the choices.
On Wed, Aug 23, 2017 at 9:57 AM zachambrose<EMAIL_ADDRESS>wrote:

Did you want me to see if there is a Cree possibility or hold on that?
On Wed, Aug 23, 2017 at 8:44 AM, Chris Mathews<EMAIL_ADDRESS>wrote:

Assigned #580 https://github.com/codeforraleigh/NCOpenPass/issues/580
to @zachambrose https://github.com/zachambrose.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/codeforraleigh/NCOpenPass/issues/580#event-1217750939>,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AQ6IxgXmaNlfIAFKFKrXQR989lIPK8nJks5sbB67gaJpZM4O_85k
.

--
Zach Ambrose
<EMAIL_ADDRESS>919-438-2752 (office)
919-616-9969 (cell)
www.AmbroseStrategy.com
https://www.linkedin.com/in/zambrose
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-324340654,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOGtZ9JzH3CCpoH4vOixNsCKLpiGhj8ks5sbC_TgaJpZM4O_85k
.

--
Chris Mathews

Done.
On Wed, Aug 23, 2017 at 10:04 AM, Chris Mathews<EMAIL_ADDRESS>wrote:

Do it. Rather have the choices.
On Wed, Aug 23, 2017 at 9:57 AM zachambrose<EMAIL_ADDRESS>wrote:

Did you want me to see if there is a Cree possibility or hold on that?
On Wed, Aug 23, 2017 at 8:44 AM, Chris Mathews<EMAIL_ADDRESS>wrote:

Assigned #580 <https://github.com/codeforraleigh/NCOpenPass/issues/580

to @zachambrose https://github.com/zachambrose.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/codeforraleigh/NCOpenPass/issues/580#event-1217750939
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/
AQ6IxgXmaNlfIAFKFKrXQR989lIPK8nJks5sbB67gaJpZM4O_85k
.

--
Zach Ambrose
<EMAIL_ADDRESS>919-438-2752 <(919)%20438-2752> (office)
919-616-9969 <(919)%20616-9969> (cell)
www.AmbroseStrategy.com
https://www.linkedin.com/in/zambrose
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-
324340654>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AAOGtZ9JzH3CCpoH4vOixNsCKLpiGhj8ks5sbC_TgaJpZM4O_85k>
.

--
Chris Mathews
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-324342868,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQ6IxrvWHWZpHYVhLZgZyYRK_3cx2vDbks5sbDFhgaJpZM4O_85k
.

--
Zach Ambrose
<EMAIL_ADDRESS>919-438-2752 (office)
919-616-9969 (cell)
www.AmbroseStrategy.com
https://www.linkedin.com/in/zambrose

we have bites from NCSU and SAS! more to follow.

And Cisco is in play.
On Wed, Aug 23, 2017 at 11:41 AM zachambrose<EMAIL_ADDRESS>wrote:

Done.
On Wed, Aug 23, 2017 at 10:04 AM, Chris Mathews<EMAIL_ADDRESS>wrote:

Do it. Rather have the choices.
On Wed, Aug 23, 2017 at 9:57 AM zachambrose<EMAIL_ADDRESS>wrote:

Did you want me to see if there is a Cree possibility or hold on that?
On Wed, Aug 23, 2017 at 8:44 AM, Chris Mathews <
<EMAIL_ADDRESS>wrote:

Assigned #580 <
https://github.com/codeforraleigh/NCOpenPass/issues/580

to @zachambrose https://github.com/zachambrose.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<

https://github.com/codeforraleigh/NCOpenPass/issues/580#event-1217750939

,

or mute the thread
<
https://github.com/notifications/unsubscribe-auth/
AQ6IxgXmaNlfIAFKFKrXQR989lIPK8nJks5sbB67gaJpZM4O_85k
.

--
Zach Ambrose
<EMAIL_ADDRESS>919-438-2752 <(919)%20438-2752> (office)
919-616-9969 <(919)%20616-9969> (cell)
www.AmbroseStrategy.com
https://www.linkedin.com/in/zambrose
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-
324340654>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AAOGtZ9JzH3CCpoH4vOixNsCKLpiGhj8ks5sbC_TgaJpZM4O_85k>
.

--
Chris Mathews
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-324342868
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AQ6IxrvWHWZpHYVhLZgZyYRK_3cx2vDbks5sbDFhgaJpZM4O_85k
.

--
Zach Ambrose
<EMAIL_ADDRESS>919-438-2752 (office)
919-616-9969 (cell)
www.AmbroseStrategy.com
https://www.linkedin.com/in/zambrose
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-324376327,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOGtQyokR8Gy1cvz075NY2hJTizwFdOks5sbEglgaJpZM4O_85k
.

--
Chris Mathews

Just a reminder that we need to have a diverse panel. Thanks for getting
this kickstarted!
On Wed, Aug 23, 2017 at 2:57 PM, Chris Mathews<EMAIL_ADDRESS>wrote:

And Cisco is in play.
On Wed, Aug 23, 2017 at 11:41 AM zachambrose<EMAIL_ADDRESS>wrote:

Done.
On Wed, Aug 23, 2017 at 10:04 AM, Chris Mathews <
<EMAIL_ADDRESS>wrote:

Do it. Rather have the choices.
On Wed, Aug 23, 2017 at 9:57 AM zachambrose<EMAIL_ADDRESS>wrote:

Did you want me to see if there is a Cree possibility or hold on
that?
On Wed, Aug 23, 2017 at 8:44 AM, Chris Mathews <
<EMAIL_ADDRESS>wrote:

Assigned #580 <
https://github.com/codeforraleigh/NCOpenPass/issues/580

to @zachambrose https://github.com/zachambrose.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<

https://github.com/codeforraleigh/NCOpenPass/issues/580#event-1217750939

,

or mute the thread
<
https://github.com/notifications/unsubscribe-auth/
AQ6IxgXmaNlfIAFKFKrXQR989lIPK8nJks5sbB67gaJpZM4O_85k
.

--
Zach Ambrose
<EMAIL_ADDRESS>919-438-2752 <(919)%20438-2752> <(919)%20438-2752> (office)
919-616-9969 <(919)%20616-9969> <(919)%20616-9969> (cell)
www.AmbroseStrategy.com
https://www.linkedin.com/in/zambrose
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<https://github.com/codeforraleigh/NCOpenPass/
issues/580#issuecomment-
324340654>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AAOGtZ9JzH3CCpoH4vOixNsCKLpiGhj8ks5sbC_TgaJpZM4O_85k>
.

--
Chris Mathews
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-
324342868
,
or mute the thread
<
https://github.com/notifications/unsubscribe-
auth/AQ6IxrvWHWZpHYVhLZgZyYRK_3cx2vDbks5sbDFhgaJpZM4O_85k
.

--
Zach Ambrose
<EMAIL_ADDRESS>919-438-2752 <(919)%20438-2752> (office)
919-616-9969 <(919)%20616-9969> (cell)
www.AmbroseStrategy.com
https://www.linkedin.com/in/zambrose
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-
324376327>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AAOGtQyokR8Gy1cvz075NY2hJTizwFdOks5sbEglgaJpZM4O_85k>
.

--
Chris Mathews
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-324430692,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADgoV79l6ab5wxXvgofRYlkm3lUy_xJVks5sbHYlgaJpZM4O_85k
.

demographically diverse or diverse industry or both. I am trying.

not all white dudes
On Wed, Aug 23, 2017 at 4:39 PM, Chris Mathews<EMAIL_ADDRESS>wrote:

demographically diverse or diverse industry or both. I am trying.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-324455623,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADgoV-jdSafm5-vtfobBRR1n02BXi-rmks5sbI3mgaJpZM4O_85k
.

I'm trying. I didn't expect everyone to jump when bill sent his note. He's
a popular guy. 😀
On Wed, Aug 23, 2017 at 5:46 PM Jason Hibbets<EMAIL_ADDRESS>wrote:

not all white dudes
On Wed, Aug 23, 2017 at 4:39 PM, Chris Mathews<EMAIL_ADDRESS>wrote:

demographically diverse or diverse industry or both. I am trying.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<
https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-324455623
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ADgoV-jdSafm5-vtfobBRR1n02BXi-rmks5sbI3mgaJpZM4O_85k
.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-324471767,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOGtapvTpI198Av9E3TngCnh9U6WHPtks5sbJ2zgaJpZM4O_85k
.

--
Chris Mathews

All good, I just want us to be intentional.
On Wed, Aug 23, 2017 at 6:59 PM, Chris Mathews<EMAIL_ADDRESS>wrote:

I'm trying. I didn't expect everyone to jump when bill sent his note. He's
a popular guy. 😀
On Wed, Aug 23, 2017 at 5:46 PM Jason Hibbets<EMAIL_ADDRESS>wrote:

not all white dudes
On Wed, Aug 23, 2017 at 4:39 PM, Chris Mathews<EMAIL_ADDRESS>wrote:

demographically diverse or diverse industry or both. I am trying.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<
https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-
324455623
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ADgoV-jdSafm5-
vtfobBRR1n02BXi-rmks5sbI3mgaJpZM4O_85k
.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-
324471767>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AAOGtapvTpI198Av9E3TngCnh9U6WHPtks5sbJ2zgaJpZM4O_85k>
.

--
Chris Mathews
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-324486097,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADgoV65c31mfAa43d-BDZ0iyCckbUPOeks5sbK7agaJpZM4O_85k
.

Greeves has offered to moderate. he doesn't fly out until late Friday.

Bill Greeves - Moderator - WD
Dennis Kekas - NCSU - WD
Rodney Robinson - Greensboro/Triad - NWD
Jennifer Robinson - SAS - NWD
Deante' Taylor - NC Innovation Center - NWD
or Nicole Raimundo - TOC - NWD

If your criterion is "not all white dudes (NWD)," you will surely find not
white dudes but you won't necessarily find a diverse panel.
On Thu, Aug 24, 2017 at 11:04 AM, Chris Mathews<EMAIL_ADDRESS>wrote:

Bill Greeves - Moderator - WD
Dennis Kekas - NCSU - WD
Rodney Robinson - Greensboro/Triad - NWD
Jennifer Robinson - SAS - NWD
Deante' Taylor - NC Innovation Center - NWD
or Nicole Raimundo - TOC - NWD
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-324662648,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADQ6goOSEDINPe9Re_IGNn-P0SEdrdGBks5sbZEDgaJpZM4O_85k
.

We are working to be intentional about having diversity across many
spectrum's. Male/female, color, industry, etc. The "not all white dudes"
was a reference to the call we had on Monday that included the previous
mentioned areas.

I understand this is a hard task but if you put WD or NWD next to every
individual on a proposed panel, that is the criterion you are using, no
matter your intentions. Here's the reality: the proposed panel has one,
possibly two, women (both white), and one, possibly two, minorities (both
black).
The point of having diversity on a panel is to have people with different
perspectives, correct?
On Thu, Aug 24, 2017 at 1:21 PM, Jason Hibbets<EMAIL_ADDRESS>wrote:

We are working to be intentional about having diversity across many
spectrum's. Male/female, color, industry, etc. The "not all white dudes"
was a reference to the call we had on Monday that included the previous
mentioned areas.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-324700742,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADQ6gjrziRqCfOpaPgOTiT7fV_8Oi99wks5sbbEdgaJpZM4O_85k
.

We would absolutely love more help reaching out to perspective panelists.
This is a team effort and we are somewhat limited by our own networks.
On Aug 24, 2017 3:29 PM, "carsi"<EMAIL_ADDRESS>wrote:

I understand this is a hard task but if you put WD or NWD next to every
individual on a proposed panel, that is the criterion you are using, no
matter your intentions. Here's the reality: the proposed panel has one,
possibly two, women (both white), and one, possibly two, minorities (both
black).
The point of having diversity on a panel is to have people with different
perspectives, correct?
On Thu, Aug 24, 2017 at 1:21 PM, Jason Hibbets<EMAIL_ADDRESS>wrote:

We are working to be intentional about having diversity across many
spectrum's. Male/female, color, industry, etc. The "not all white dudes"
was a reference to the call we had on Monday that included the previous
mentioned areas.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-
324700742>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
ADQ6gjrziRqCfOpaPgOTiT7fV_8Oi99wks5sbbEdgaJpZM4O_85k>
.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-324733820,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADgoV0MpRYIMr2ncJDL0piRodirVKfhvks5sbc8rgaJpZM4O_85k
.

I will reach out to my network to find more potential panelists. Is there
anywhere with information about what we are asking of the panelists and
potential professional fields I can direct them to?
On Aug 24, 2017 6:18 PM, "Jason Hibbets"<EMAIL_ADDRESS>wrote:

We would absolutely love more help reaching out to perspective panelists.
This is a team effort and we are somewhat limited by our own networks.
On Aug 24, 2017 3:29 PM, "carsi"<EMAIL_ADDRESS>wrote:

I understand this is a hard task but if you put WD or NWD next to every
individual on a proposed panel, that is the criterion you are using, no
matter your intentions. Here's the reality: the proposed panel has one,
possibly two, women (both white), and one, possibly two, minorities (both
black).
The point of having diversity on a panel is to have people with different
perspectives, correct?
On Thu, Aug 24, 2017 at 1:21 PM, Jason Hibbets<EMAIL_ADDRESS>wrote:

We are working to be intentional about having diversity across many
spectrum's. Male/female, color, industry, etc. The "not all white
dudes"
was a reference to the call we had on Monday that included the previous
mentioned areas.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-
324700742>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
ADQ6gjrziRqCfOpaPgOTiT7fV_8Oi99wks5sbbEdgaJpZM4O_85k>
.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-
324733820>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
ADgoV0MpRYIMr2ncJDL0piRodirVKfhvks5sbc8rgaJpZM4O_85k>
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/codeforraleigh/NCOpenPass/issues/580#issuecomment-324772827,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADQ6gvMW16UjZUt4h31-oitcfUSyhOvoks5sbfa9gaJpZM4O_85k
.

Here is the current status of the smart cities panel:
Invited and confirmed for Smart Cities panel
Moderator - Bill Greeves - Wake County CIIO, male, Caucasian
Rodney Roberts - Guilford County Network Manager, male, African American
Terry Yates - Town of Cary Network Manager, male, Caucasian
Invited and not confirmed
Jennifer Robinson - SAS and Town of Cary council member, female, Caucasian
Andrew Slavinsky - Cisco - sales, male, Caucasian
Dennis Kekas - NCSU - Exec director of next gen IT, male, Caucasian
Backup(not invited)
Deante’ Tyler - State of NC Innovation Director, male, African American

Talk with Bill G today. Good with format and 4 panelists. Likes Jennifer Robinson from SAS and someone from NCSU.


Bastion NSG GatewayManager rule requires port 4443 allowed inbound

The details of 'Unable to create an NSG on AzureBastionSubnet' need to be updated, as they are not sufficient to satisfy the NSG validation that happens.
After consulting the quickstart example, I got it working: https://github.com/Azure/azure-quickstart-templates/blob/master/101-azure-bastion-nsg/azuredeploy.json
I believe it requires port 4443 for the GatewayManager inbound rule as well as 443:
 {
                        "name": "bastion-control-in-allow",
                        "properties": {
                            "protocol": "Tcp",
                            "sourcePortRange": "*",
                            "sourceAddressPrefix": "GatewayManager",
                            "destinationPortRanges": [
                                "443",
                                "4443"
                            ],
                            "destinationAddressPrefix": "*",
                            "access": "Allow",
                            "priority": 120,
                            "direction": "Inbound"
                        }
                    },

This took me a while to find.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ffdc927a-882a-bb53-e6ec-0a18d71c3bec
Version Independent ID: dbdb4fc7-a55e-b025-8ad3-18ffbe21eb66
Content: Troubleshoot Azure Bastion
Content Source: articles/bastion/troubleshoot.md
Service: bastion
GitHub Login: @charwen
Microsoft Alias: charwen

@trevorreeves , Thanks for reaching out. We will investigate and update this thread.

@trevorreeves , Appreciate your patience. The doc has been edited accordingly and it would take some time for the changes to get reflect over the doc.
We are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


New update causes 1-2435-8325 error on CFW boot

In two, possibly three, confirmed cases in Discord assistance channels, users reported 1-2435-8325 errors when attempting to boot with HiyaCFW. TWiLightMenu was not affected and worked without issue. When using HiyaCFW Helper 3.5 the error was replaced with An error has occurred, an issue with the Launcher not liking free space above 2GB. Not the Helper.
It is very likely the switch to fatcat to extract the NAND contents is causing the issues aforementioned.

Happened to me too, tested both on Win7 and Win10.
I've compared files generated by 3.5 and 3.5.1 and noticed that 3.5.1 was making some files slightly bigger than older version(sometimes few bytes, sometimes more).
So then I've compared those missized files with hex editor and found out that, for whatever reason, all 0x0A's were replaced with 0x0D/0x0A pair, like something was converting LF line breaks to CRLF line breaks! In BINARY files!
I'm guessing something went wrong on 7b1a92155e52f3e48a5c9f271fe7062d9cbe5f91, but don't know what exactly, probably something with 7za or fatcat as @Kodtiz3D said.

Happened to me too, tested  on Win8 . My console is DSi 1.4U.
Unlaunch autoboot TWmenu++ is fine, when changed to Hiya, it gave me Error 1-2435-8325.

me too, after trying to find the differences of each file one by one with the previous build, the cause is in / sys/cert.sys
if I use cert.sys from the previous build, Hiyacfw can run normally

Really? Can you upload a previous cert.sys for me ? Thanks！-------- 原始邮件 --------主题：Re: [mondul/HiyaCFW-Helper] New update causes 1-2435-8325 error on CFW boot (#74)发件人：driehoek91 收件人：mondul/HiyaCFW-Helper 抄送：david-zzj<PHONE_NUMBER>0@139.com,Comment me too, after trying to find the differences of each file one by one with the previous build, the cause is in / sys/cert.sys
if I use cert.sys from the previous build, Hiyacfw can run normally
—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe.

Really?  Can you upload a previous cert. sys for me?
Thanks!

it looks like cert.sys is connected to each nand backup. v3.4 v3.4.1 v3.5 has the same cert.sys, for v3.5.1 has a different cert.sys itself. but you might be able to try mine
cert.zip

Ok，i will post result when i replace cert.sys later.

@driehoek91, replace cert. sys is no luck for me, the boot error still there.
But I redo with hiya3.5 release all works again.

Can confirm, happens to me too with version 3.5.1

Somebody please upload Windows version 3.5. Thank you!

Problem seems to be on an issue with the VC++ 2003 compilation of fatcat, specifically on the conversion from string to a 64-bit unsigned integer. Will compile it using the latest Visual Studio Community, but it will require the 2015-2019 runtime installed, hope that's not an issue.

specifically on the conversion from string to a 64-bit unsigned integer.
Huh, that would kinda explain the extra bytes then, good find.

Hi, @Kodtiz3D

got the same problem yesterday, sert.sys did not help me

I also got this error while using 3.5.1 too.
I then tried 3.5.0 and now it works.

Hi, compiled fatcat for Win64, needs the Visual C++ 2015-2019 runtime. Please replace the exe in the Windows release with the one from this archive and let me know if it works for you.

I'll test on my Windows partition ASAP and see if there are any differences.

Finally got ahead of a Windows machine, tested the fatcat VC++ 2019 compilation and did not work, I was unable to compile it with mingw and tried also with cygwin without success, so had to nuke the release. I re-compiled the v3.5 and re-uploaded it, so please keep using that one until I find the way for fatcat to work correctly in Windows. Closing ticket.

@mondul , can I help? I have Visual Studio 2019 Community, I can compile C/C++ code and comfortable doing it. What does fatcat do and were is it's source? I don't see anything fatcat in your repo.

@oboroc this is the fatcat repo:
https://github.com/Gregwar/fatcat
You will need CMake for generating the Visual Studio solution.

Thank you for pointing me, @mondul ! I'm now trying to compare extracted files between fatcat under WSL and fatcat on Windows. I couldn't use the Linux binary you bundled with HiyaCFW-Helper-v3.5-Python3 release, it doesn't seem to work:
$ ./fatcat
-bash: ./fatcat: cannot execute binary file: Exec format error

I was able to install package with sudo apt install fatcat in WSL.
I compared files extracted with fatcat under Linux to files extracted with your Windows fatcat.exe, and they are identical. I used WinMerge. I don't think fatcat is the problem.

@oboroc Linux binaries does not work in WSL due how the real Linux kernel handles statically linked executable files. The problem with fatcat was that it uses some POSIX file functions, and those were not implemented correctly in Windows (they were treating all files as ASCII instead of binaries, so every time a 0xA new line character was read it was being replaced by 0xD 0xA, so that extra carriage return messed up all extracted files), so changed them for native Win32 API file functions and voilà! issue fixed. At the same time I changed the compiler from Visual C++ to mingw to avoid the runtime dependency. @Kodtiz3D the v3.5.1 release was updated with the new working fatcat binary, thanks for reporting this issue.

Hi !
I have this error after Hiya boot splash, i used the last version of the Helper :(


Detect when moving in and out of networks with symmetric NAT

This is a follow-up to PR #1070. Our reconciliation logic does not detect when moving in and out of networks with symmetric NAT. Whatever we determine at startup is the mode nexd will remain in until restarted.

@nerdalert I don't think fixing this would be much code, but I don't have a good idea for how to test it. It would be even better if we could cover it in CI, but I'd settle for a relatively easy way to test it manually if you have suggestions!

closing as a duplicate of #423


response.content_type should not remove charset

Hi,
When I run rails and perform a certain request, I get a response with:
Content-Type: application/json; charset=utf-8

However, when performing an Rspec controller test against that same controller, the response.content_type is just application/json which is not correct.  Somehow, rspec is splitting off charset into response.charset which comes back as utf-8.  This feels odd to do this since the actual header name where the charset is returned is Content-Type.
I'm not sure which code is doing this and obviously not breaking a bunch of existing tests is a concern, but this seems like a mismatch to me ...
Thoughts?
Thanks!

As per rspec/rspec-core#1965 this is a Rails issue.

OK, sorry, misunderstood, my fault.  I'll file against rails.

The response object in controller specs is an instance of ActionController::TestResponse. However, content_type is inherited from ActionDispatch::Response. Per ActionDispatch::Response#content_type this is by design:
    # Sets the HTTP response's content MIME type. For example, in the controller
    # you could write this:
    #
    #  response.content_type = "text/plain"
    #
    # If a character set has been defined for this response (see charset=) then
    # the character set information will also be included in the content type
    # information.
    attr_reader   :content_type

    # The charset of the response. HTML wants to know the encoding of the
    # content you're giving them, so we need to send that along.
    attr_accessor :charset

You are asking about the actual header value. You can get that from:
expect(response.headers).to include(
  "Content-Type" => "application/json; charset=utf-8"
)


62 top bar with login status

Which issue(s) this PR fixes

Fixes #62 : top bar with login status
Additional comments

Agreements

[X] I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004.
[X] I hereby agree to grant TOSIT a copyright license to use my contributions.

IMO it's fine for this PR as we're going to work on the layout with #85


Coordinate Conversion: UTM rounding issue (1 meter off)? (ArcMap)

@nfeuerstein When I was verifying the fix to #158 I found that the output UTM coordinate in some test cases was 1 meter off then what was expected (see https://github.com/Esri/coordinate-conversion-addin-dotnet/issues/158#issuecomment-270993622). If I remember correctly it was never 1 meter off in both the easting and northing. It was either off on one or the other coordinate components and didn't happen every time.
At the time, I was thinking that this was a rounding issue. @jmhauck was starting to look into this. I think we can live with this issue for this release.

@elinz I believe this was addressed by @dhagens. Please verify

Closing. #546


SPOPropertyBag

Pull Request (PR) description
New Resource SPOPropertyBag
This Pull Request (PR) fixes the following issues
N/A

This change is

Codecov Report

Merging #201 into Dev will increase coverage by 0.14%.
The diff coverage is 98.43%.

@@            Coverage Diff            @@
##              Dev    #201      +/-   ##
=========================================
+ Coverage   88.56%   88.7%   +0.14%
=========================================
  Files          49      50       +1
  Lines        4408    4472      +64
  Branches        8       8
=========================================
+ Hits         3904    3967      +63
- Misses        496     497       +1
  Partials        8       8

Impacted Files
Coverage Δ

...urces/MSFT_SPOPropertyBag/MSFT_SPOPropertyBag.psm1
98.43% <98.43%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c285749...0039d87. Read the comment docs.

@ykuijs another one for your eyes to review. Thanks

As far as naming goes, we tried respecting the naming from PnP which is (Get|Set)-PnPPropertyBag


Can't drag and drop image to editor

I have linked the editor to my Google account. But I recently found that I can't drag and drop a image from desktop to the editor and have it upload it to my Google account like it used to do.

It works but you have to drop it on the preview area and not the editor area.

I was having the same issue, thank you @bibhas2.


HOMS-116 Fix choosing default choice when choices defined as strings

Conflicting files
config/locales/en.yml
config/locales/ru.yml


styled-jsx broke native directory.

Because I use nested media queries.
I'm going to switch the codebase to use glamor, should take me a couple of hours. but too tired to continue anymore tonight.
https://github.com/zeit/next.js/issues/3133 - this solution provided breaks on Heroku deploys because next/babel options are not configurable.

Fixed this by porting all styles to glamor, so I don't have to worry about styled-jsx anymore.


handling inconsistent FNT failure for nokia

handling inconsistent FNT failure for nokia

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls


HIE unresponsive

I've noticed that somewhere after 8e7d756b commit hie stopped responding to client requests. Unfortunately i'm unable to compile hie on most commits after 8e7d756b, so i can't bisect to specific commit.
Not sure if it's a specific request that makes hie freezed or there is some specific trigger
Relevant logs:
https://pastebin.com/zLqyGDF0 <- stuck after documentHighlight request, source is compilable.
https://pastebin.com/n8zR5PUy <- stuck after didChange request that introduced error in source and another didChange that fixed it back

UPD:
latest working 72bf4c76
first buildable and non-working: 3246eac9

And another UPD. Backporint of --with-compiler fix for cabal i was also able to build 3f01cb42 and it was also broken.
Recap: something was broken after 72bf4c76 and before 3f01cb42.

I'm having similar issues, though even 72bf4c7 is not working for me. Here's a log using a build from that commit. This is testing on a stack new project, which was initialized with lts-12.22 (GHC 8.4.4)
2018-12-11 00:01:33.4281489 [ThreadId 3] - Using stack GHC version
2018-12-11 00:01:33.5671511 [ThreadId 3] - Run entered for HIE(hie) Version <IP_ADDRESS>, Git revision 72bf4c76d95e39c91c116d9171a604f636d2bac2 (dirty) (2160 commits) x86_64 ghc-8.4.4
2018-12-11 00:01:33.5681534 [ThreadId 3] - Current directory:G:\Other\temp\testproj
2018-12-11 00:01:33.5681534 [ThreadId 3] - Enabling --vomit for ghc-mod. Output will be on stderr
2018-12-11 00:01:33.5681534 [ThreadId 3] -

haskell-lsp:Starting up server ...
2018-12-11 00:01:33.5681534 [ThreadId 3] - ---> {"jsonrpc": "2.0", "id": 1, "method": "initialize", "params": {"capabilities": {"workspace": {"applyEdit": true, "didChangeConfiguration": {}}, "textDocument": {"hover": {"contentFormat": ["markdown", "plaintext"]}, "formatting": {}, "rename": {}, "codeAction": {}, "documentHighlight": {}, "rangeFormatting": {}, "signatureHelp": {"signatureInformation": {"documentationFormat": ["markdown", "plaintext"]}}, "definition": {}, "synchronization": {"didSave": true}, "references": {}, "documentSymbol": {"symbolKind": {"valueSet": [1, 2, 3, 4, 5, 6, 7, 8, 11, 12, 13, 14]}}, "completion": {"completionItem": {"snippetSupport": true}, "completionItemKind": {"valueSet": [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18]}}}}, "rootUri": "file:///G:/Other/temp/testproj", "processId": 20580, "rootPath": "G:\\Other\\temp\\testproj"}}
2018-12-11 00:01:33.5691789 [ThreadId 3] - haskell-lsp:initializeRequestHandler: setting current dir to project root:G:\Other\temp\testproj
2018-12-11 00:01:33.6071936 [ThreadId 5] - <--2--{"result":{"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"willSave":false,"willSaveWaitUntil":false,"save":{"includeText":false}},"workspace":{},"documentRangeFormattingProvider":true,"documentHighlightProvider":true,"executeCommandProvider":{"commands":["22104:applyrefact:applyOne","22104:applyrefact:applyAll","22104:applyrefact:lint","22104:base:version","22104:base:plugins","22104:base:commands","22104:base:commandDetail","22104:brittany:format","22104:build:prepare","22104:build:isConfigured","22104:build:configure","22104:build:listTargets","22104:build:listFlags","22104:build:buildDirectory","22104:build:buildTarget","22104:ghcmod:check","22104:ghcmod:lint","22104:ghcmod:info","22104:ghcmod:type","22104:ghcmod:casesplit","22104:hare:demote","22104:hare:dupdef","22104:hare:iftocase","22104:hare:liftonelevel","22104:hare:lifttotoplevel","22104:hare:rename","22104:hare:deletedef","22104:hare:genapplicative","22104:hare:casesplit","22104:hoogle:info","22104:hoogle:lookup","22104:hsimport:import","22104:liquid:sayHello","22104:liquid:sayHelloTo","22104:package:add","22104:pragmas:addPragma"]},"renameProvider":true,"definitionProvider":true,"hoverProvider":true,"codeActionProvider":true,"completionProvider":{"triggerCharacters":["."],"resolveProvider":true},"documentSymbolProvider":true,"documentFormattingProvider":true,"referencesProvider":true}},"jsonrpc":"2.0","id":1}
2018-12-11 00:01:33.6101554 [ThreadId 3] - ---> {"jsonrpc": "2.0", "method": "textDocument/didOpen", "params": {"textDocument": {"version": 0, "languageId": "haskell", "text": "module Lib\n    ( someFunc\n    ) where\n\nsomeFunc :: IO ()\nsomeFunc = putStrLn \"someFunc\"\n", "uri": "file:///G:/Other/temp/testproj/src/Lib.hs"}}}
2018-12-11 00:01:33.6111585 [ThreadId 3] - ---> {"jsonrpc": "2.0", "method": "initialized", "params": {}}
2018-12-11 00:01:33.6111585 [ThreadId 12] - ****** reactor: got message number:0
2018-12-11 00:01:33.6111585 [ThreadId 12] - ****** reactor: processing NotDidOpenTextDocument
2018-12-11 00:01:33.6111585 [ThreadId 12] - requestDiagnostics: no diagFunc for:DiagnosticOnOpen
2018-12-11 00:01:33.6111585 [ThreadId 12] - ****** reactor: got message number:1
2018-12-11 00:01:33.6111585 [ThreadId 12] - ****** reactor: processing Initialized Notification
2018-12-11 00:01:33.6111585 [ThreadId 12] - Using stack GHC version
2018-12-11 00:01:33.6141515 [ThreadId 5] - <--2--{"jsonrpc":"2.0","params":{"type":4,"message":"Using hie version: Version <IP_ADDRESS>, Git revision 72bf4c76d95e39c91c116d9171a604f636d2bac2 (dirty) (2160 commits) x86_64 ghc-8.4.4"},"method":"window/logMessage"}
2018-12-11 00:01:33.785151 [ThreadId 13] - ghcDispatcher: top of loop
2018-12-11 00:01:33.785151 [ThreadId 13] - ghcDispatcher:got request 0 with id: Nothing
2018-12-11 00:01:33.785151 [ThreadId 14] - ideDispatcher: top of loop
2018-12-11 00:01:33.932151 [ThreadId 13] - file mapping state is: fromList [("G:\\Other\\temp\\testproj\\src\\Lib.hs",FileMapping {fmPath = "C:\\Users\\Thomas\\AppData\\Local\\Temp\\ghc-mod22105\\LibB1FD.hs", fmTemp = True})]
2018-12-11 00:01:33.9331509 [ThreadId 13] - ghcDispatcher: top of loop
2018-12-11 00:01:33.9331509 [ThreadId 13] - ghcDispatcher:got request 0 with id: Nothing
2018-12-11 00:01:33.9331509 [ThreadId 13] - ghcDispatcher:Processing request as version matches
2018-12-11 00:01:33.9971508 [ThreadId 13] - ghcDispatcher: top of loop
2018-12-11 00:01:33.9981553 [ThreadId 13] - ghcDispatcher:got request 0 with id: Nothing
2018-12-11 00:01:33.9981553 [ThreadId 13] - ghcDispatcher:Processing request as version matches
2018-12-11 00:01:33.9981553 [ThreadId 13] - setTypecheckedModule: file mapping state is: fromList [("G:\\Other\\temp\\testproj\\src\\Lib.hs",FileMapping {fmPath = "C:\\Users\\Thomas\\AppData\\Local\\Temp\\ghc-mod22105\\LibB1FD.hs", fmTemp = True})]
2018-12-11 00:01:33.9981553 [ThreadId 13] - setTypecheckedModule: before ghc-mod
2018-12-11 00:01:34.097156 [ThreadId 5] - <--2--{"jsonrpc":"2.0","params":{"uri":"file:///G%3A/Other/temp/testproj/src/Lib.hs","diagnostics":[]},"method":"textDocument/publishDiagnostics"}
2018-12-11 00:01:56.2301515 [ThreadId 3] - ---> {"jsonrpc": "2.0", "id": 2, "method": "textDocument/hover", "params": {"textDocument": {"uri": "file:///G:/Other/temp/testproj/src/Lib.hs"}, "position": {"line": 5, "character": 14}}}
2018-12-11 00:02:01.2630049 [ThreadId 3] - ---> {"jsonrpc": "2.0", "id": 3, "method": "textDocument/hover", "params": {"textDocument": {"uri": "file:///G:/Other/temp/testproj/src/Lib.hs"}, "position": {"line": 5, "character": 14}}}
2018-12-11 00:02:41.0151424 [ThreadId 3] - ---> {"jsonrpc": "2.0", "id": 4, "method": "textDocument/hover", "params": {"textDocument": {"uri": "file:///G:/Other/temp/testproj/src/Lib.hs"}, "position": {"line": 5, "character": 17}}}
2018-12-11 00:02:59.769161 [ThreadId 3] - ---> {"jsonrpc": "2.0", "id": 5, "method": "textDocument/formatting", "params": {"options": {"insertSpaces": true, "tabSize": 4}, "textDocument": {"uri": "file:///G:/Other/temp/testproj/src/Lib.hs"}}}
2018-12-11 00:03:34.7026554 [ThreadId 3] - ---> {"jsonrpc": "2.0", "method": "textDocument/didClose", "params": {"textDocument": {"uri": "file:///G:/Other/temp/testproj/src/Lib.hs"}}}
2018-12-11 00:03:34.7196536 [ThreadId 3] - ---> {"jsonrpc": "2.0", "id": 6, "method": "shutdown"}
2018-12-11 00:03:34.7196536 [ThreadId 5] - <--2--{"error":{"code":-32603,"message":"haskell-lsp:parse error. Object (fromList [(\"jsonrpc\",String \"2.0\"),(\"method\",String \"shutdown\"),(\"id\",Number 6.0)]) \"When parsing the record RequestMessage of type Language.Haskell.LSP.Types.Message.RequestMessage the key params was not present.\" `stack update` and install new haskell-lsp. Or check information on https://marketplace.visualstudio.com/items?itemName=xxxxxxxxxxxxxxx"},"jsonrpc":"2.0","id":6}
2018-12-11 00:03:34.7336563 [ThreadId 3] -
haskell-lsp:Got EOF, exiting 1 ...

Note, at 2018-12-11 00:03:34 I closed the editor.

How did you install hie? The makefile now makes sure to install cabal-install, and Cabal-<IP_ADDRESS>.
These are needed to enable GHC 8.6 / cabal-helper support.

@alanz I manually ran outside the project directory:
> stack install cabal-install
> cabal update
> stack --stack-yaml=stack-8.4.4.yaml install happy
> stack --stack-yaml=stack-8.4.4.yaml install

Note I'm using GHC 8.4.4. The projects I've tried this on are using lts-12.22. Is cabal-install <IP_ADDRESS> also required for that? Currently I have:
> cabal --version
cabal-install version <IP_ADDRESS>
compiled using version <IP_ADDRESS> of the Cabal library

@alanz via make-target, along with hie-8.4.4.

I'm a Windows user but I can't do much more than confirm that I'm also not getting any output. I think that issue I opened is the same as this https://github.com/haskell/haskell-ide-engine/issues/969

I think I'm facing the same issue. I'm trying to use hie with this language-server client on Archlinux. I installed hie through AUR. Here are some of the logs I can see:

hie

2019-01-04 18:27:23.649974915 [ThreadId 10] - requestDiagnostics: no diagFunc for:DiagnosticOnOpen
2019-01-04 18:27:23.650015234 [ThreadId 10] - ****** reactor: top of loop
2019-01-04 18:27:23.650048613 [ThreadId 12] - ghcDispatcher:got request 0 with id: Nothing
2019-01-04 18:27:23.650160518 [ThreadId 12] - ghcDispatcher: top of loop
2019-01-04 18:27:23.650198566 [ThreadId 12] - ghcDispatcher:got request 1 with id: Nothing
2019-01-04 18:27:23.651924556 [ThreadId 6] - <--2--{"jsonrpc":"2.0","params":{"type":2,"message":"No hoogle db found. Check the README for instructions to generate one"},"method":"window/showMessage"}
2019-01-04 18:27:23.911898641 [ThreadId 12] - file mapping state is: fromList [("/path/to/file.hs",FileMapping {fmPath = "/tmp/ghc-mod3077/DbConfig3076-0.hs", fmTemp = True})]
2019-01-04 18:27:23.912013551 [ThreadId 12] - ghcDispatcher: top of loop
2019-01-04 18:27:23.912055014 [ThreadId 12] - ghcDispatcher:got request 1 with id: Nothing
2019-01-04 18:27:23.912090151 [ThreadId 12] - ghcDispatcher:Processing request as version matches
2019-01-04 18:27:35.253451002 [ThreadId 4] - ---> {"jsonrpc":"2.0","method":"textDocument/hover","params":{"position":{"character":2,"line":35},"textDocument":{"uri":"file:///path/to/file.hs"}},"id":18}
2019-01-04 18:27:35.253840498 [ThreadId 10] - ****** reactor: got message number:2

Language-server client

Message: {"jsonrpc":"2.0","method":"textDocument/formatting","params":{"bufnr":1,"character":0,"filename":"/path/to/file.hs","handle":true,"languageId":"haskell","line":35,"text":["module Config.DbConfig (","  read_,","  host,","  port,","  user,","  password,","  name,","  connectionLimit,","  InvalidNumber(..)",") where","","import Control.Exception.Base","import System.Environment","import Text.Read","","data InvalidNumber =","  InvalidPort String","  | InvalidConnectionLimit String","  deriving (Show)","instance Exception InvalidNumber","","data DbConfig = DbConfig {","  host :: String,","  port :: Int,","  user :: String,","  password :: String,","  name :: String,","  connectionLimit :: Int","} deriving (Show)","","strToInt :: String -> Maybe Int","strToInt = readMaybe","","read_ :: IO (DbConfig)","read_ = do","  host <- getEnv \"DB_HOST\"","  portStr <- getEnv \"DB_PORT\"","  user <- getEnv \"DB_USER\"","  password <- getEnv \"DB_PASSWORD\"","  name <- getEnv \"DB_NAME\"","  connectionLimitStr <- getEnv \"DB_CONNECTION_LIMIT\"","  case ((strToInt portStr), (strToInt connectionLimitStr)) of","    (Nothing, _) -> throw (InvalidPort portStr)","    (_, Nothing) -> throw (InvalidConnectionLimit connectionLimitStr)","    (Just port, Just connectionLimit) -> return (DbConfig {","      host=host,","      port=port,","      user=user,","      password=password,","      name=name,","      connectionLimit=connectionLimit","    })",""]},"id":3}

Error: Timeout
18:36:21 INFO main src/vim.rs:93 => None {"jsonrpc":"2.0","error":{"code":-32603,"message":"timed out waiting on channel"},"id":3}

I'm new to Haskell and to hie but it looks like hie receives requests from the language-server client but doens't reply right?

@alanz any news on this?

Win10, VScode, GHC-8.4.4
Following the comment https://github.com/haskell/haskell-ide-engine/issues/983#issuecomment-457882300 I uncommented the line with the scope and rebuilt hie (stack .\install.hs hie-8.4.4).
After opening VScode I got following:
In popup notification:
Got error while processing diagnostics: readCreateProcess: C:\Programs\hie\haskell-ide-engine\.stack-work\install\6835b01e\libexec\x86_64-windows-ghc-8.4.4\cabal-helper-<IP_ADDRESS>\cabal-helper-wrapper.exe "print-build-platform" (exit 1): failed

In extension output:
cabal-helper-wrapper.exe: dieVerbatim: user error (cabal-helper-wrapper.exe: The program 'ghc' version >=6.11 is required but it
could not be found.

This looks like #1004.
Is there an end to all of this...?

Not sure 100% if it was the solution but i get to load cabal and stack based projects in vscode-1.33.0 (ext version 0.0.25) for windows 7 and 10 after installing locally the fix to make hie-wrapper find the cabal-helper-wrapper: https://github.com/alanz/cabal-helper/pull/5
Before that change the cabal project throwed an error and the stack one simply hanged out as described in #1166
They started to work after setting the cabal_helper_libexecdir with the correct path to cabal-helper too.

Maybe we could close this one, do you continue hit the original unresponsive behaviour in windows @Anrock?

@jneira no, on 8.6.5 I no longer hit it


'Command' object has no attribute 'broadcaster_id'

I am trying to get this up and running but get an error when trying. It was working all right with Postgresql disabled but I wasn't able to see any styling and saw a few errors when it tried accessing the static files
Here's the main error I was seeing
dta-web | [2020-10-24 12:35:32 +0000] [31] [INFO] Starting gunicorn 20.0.4
dta-web | [2020-10-24 12:35:32 +0000] [31] [INFO] Listening at: http://<IP_ADDRESS>:8000 (31)
dta-web | [2020-10-24 12:35:32 +0000] [31] [INFO] Using worker: sync
dta-web | [2020-10-24 12:35:32 +0000] [36] [INFO] Booting worker with pid: 36
dta-web | [2020-10-24 12:35:33 +0000] [37] [INFO] Booting worker with pid: 37
dta-web | [2020-10-24 12:35:33 +0000] [38] [INFO] Booting worker with pid: 38
dta-web | HTTP error occurred: 400 Client Error: Bad Request for url: https://id.twitch.tv/oauth2/token?client_id=%3Cclient-id%3E&client_secret=%3Cclient-secret%3E&grant_type=client_credentials
dta-web | [2020-10-24 12:35:33 +0000] [39] [INFO] Booting worker with pid: 39
dta-web | Updated Twitch credentials
dta-web | Filling database with clips
dta-web | Traceback (most recent call last):
dta-web |   File "manage.py", line 22, in <module>
dta-web |     main()
dta-web |   File "manage.py", line 18, in main
dta-web |     execute_from_command_line(sys.argv)
dta-web |   File "/usr/local/lib/python3.8/site-packages/django/core/management/__init__.py", line 401, in execute_from_command_line
dta-web |     utility.execute()
dta-web |   File "/usr/local/lib/python3.8/site-packages/django/core/management/__init__.py", line 395, in execute
dta-web |     self.fetch_command(subcommand).run_from_argv(self.argv)
dta-web |   File "/usr/local/lib/python3.8/site-packages/django/core/management/base.py", line 330, in run_from_argv
dta-web |     self.execute(*args, **cmd_options)
dta-web |   File "/usr/local/lib/python3.8/site-packages/django/core/management/base.py", line 371, in execute
dta-web |     output = self.handle(*args, **options)
dta-web |   File "/opt/app/clips/management/commands/updateDB.py", line 62, in handle
dta-web |     self.updateClips()
dta-web |   File "/opt/app/clips/management/commands/updateDB.py", line 71, in updateClips
dta-web |     self.broadcaster_id), headers=self.kraken_header).json()["created_at"]
dta-web | AttributeError: 'Command' object has no attribute 'broadcaster_id'
dta-web | [2020-10-24 12:35:33 +0000] [40] [INFO] Booting worker with pid: 40

and the missing styling/images
dta-web | 2020-10-10T12:34:23.919786Z
dta-web | Not Found: /static/svg/logo.svg
dta-web | Not Found: /static/svg/clip-offline.svg
dta-web | Not Found: /media/game_thumbnails/510218.jpg
dta-web | Not Found: /static/svg/twitch.svg
dta-web | Not Found: /media/game_thumbnails/18122.jpg
dta-web | Not Found: /media/game_thumbnails/518184.jpg
dta-web | Not Found: /media/game_thumbnails/509658.jpg
dta-web | Not Found: /static/css/all.min.css
dta-web | Not Found: /static/css/bulma.min.css
dta-web | Not Found: /static/css/bulma-prefers-dark.css
dta-web | Not Found: /static/css/style.css
dta-web | Not Found: /static/js/navbar-toggle.js
dta-web | Not Found: /static/svg/logo.svg
dta-web | Not Found: /static/svg/clip-offline.svg
dta-web | Not Found: /media/game_thumbnails/510218.jpg
dta-web | Not Found: /static/svg/twitch.svg
dta-web | Not Found: /media/game_thumbnails/18122.jpg
dta-web | Not Found: /media/game_thumbnails/518184.jpg
dta-web | Not Found: /media/game_thumbnails/509658.jpg

dta-web | HTTP error occurred: 400 Client Error: Bad Request for url: https://id.twitch.tv/oauth2/token?client_id=<client-id>&client_secret=<client-secret>&grant_type=client_credentials

This indicates that the .env file wasn't set up correctly. Make sure to have client and client secret set up in your .env file and run run docker again with --build flag.

It's weird. I had them in the env and it didn't give the error with USE_POSTGRESQL=False.
Do you mean running docker-compose up --build?

Yes running docker-compose up -d --build copies all files into the container again (for changes on the .env file).
There are multiple ways to approach this

I would suggest deleting the Postgres db and start from scratch.

Even if the container gives you an error, the django backend should still be up and running. So you could navigate to example.com/admin/ and delete all entries under "twitch settings". Then restart the container.

If you want to migrate your existing database, you could also try to dump the current sqlite db from within the container and import it to Postgres. The project automatically checks, if the file "datadump.json" exists in the root directory and imports it.


Remove onboarding experiment

Task/Issue URL: https://app.asana.com/0/856498667320406/1162322702538942
Tech Design URL:
CC:
Description:

Removed experiment setup.
Removed CTA alerts.

Note: CTA Reminder toast is still there - we show it in case user did not watch the onboarding video till the end.
Steps to test this PR:

Run the onboarding.
Home Row CTA should be the last step of the onboarding flow.
No alerts should be shown.
Floating tips should work.

Internal references:
Software Engineering Expectations
Technical Design Template

@subsymbolic Thank you! I've committed tweaks and created https://app.asana.com/0/856498667320406/1162336160858417 as a follow up for the landscape glitch.


npm run-script build does not minify common.js

BookStack Version: Latest release
PHP Version: 7.0
MySQL Version: 5.7

Expected Behavior

Running npm run-script build should produce a minified common.js in public/js of about 800kb, similar to the one in release/the Github repository

Actual Behavior

This was on a completely clean AWS Ubuntu 16.04 EC2 instance with the installation script.
After installing Bookstacks and Node/npm, I ran npm run-script build in the bookstack folder.
The new common.js is huge (7.898MB) and causes a long load time. You can check it out at http://<IP_ADDRESS>/js/common.js?version=v0.17.3
My node version is v8.2.1 and npm is 5.3.0

Tested on Node 6.9 as well with the same results.

Ugh, sorry, should've run run-script production. Please close this. Sorry!

@spaceraccoon Thanks for advising, I've updated the readme to reflect the recent script changes.
I'd generally advise staying away from the master branch unless you're developing though. It often has breaking changes and things that can mess up a production install.


GROOVY-10024: Dollar slashy /$ string ending in backslash "breaks" th…

…e parser

LGTM. Let's wait for the test result:
https://github.com/danielsun1106/groovy-parser/tree/GROOVY-10024

The test result is green ;-)

Proposed PR merged.