Incompatible when used with .NET 5 in SingleFile option

I have a sample WPF project running on .NET 5. Everything works fine for both debug and release environments. However, if I publish the project with target runtime as win-x64 or win-x86 with "Produce Single File" option, the following error occurs.

This error is logged with Serilog

Hello. This is due to https://github.com/PowerShell/MMI/issues/45 - can you target win10-x64 instead? Or one of the other more specific runtimes.

There doesn't seem to be a suitable alternative. And no specific operating system appears in the target runtime list. Of course, if I choose Portable, there is no "Single File" option.

same issue when targeting win-x64. Does not even need to be single file.

same issue when targeting win-x64. Does not even need to be single file.

Confirmed.

Just to say I too have fallen over this. I don't understand the technicalities, but it looks like a long chain of dependency that would be good to cut out the middle man and go directly to the WMI interface. I'll resort to storing a GUID in a file the \Windows directory until then...

This is obviously catching a lot of people out.
For anyone seeing this issue and not wanting to change their runtime identifier, I would recommend just using v5.2.0 for now - it still uses WMI and thus doesn't have any of the issues with the MMI package.
Moving forwards, I think the best option will be to provide both a WMI and a MMI package, so that people can choose which set of tradeoffs they want to make. I'll do this in the next release.

Ahah! It does indeed work fine with 5.2. Thank you for correcting me.

I'm working on a v6 release that will break out the various platform-specific stuff into its own packages. It will allow you to choose between using WMI and MMI on Windows.
For the Windows stuff, you'll have a choice of:

DeviceId.Windows.Wmi
DeviceId.Windows.Mmi

I'm going to go back to recommending the WMI stuff as a default, as the runtime issues with MMI are catching too many users out.
Simple example using the new syntax:
var deviceId = new DeviceIdBuilder()
    .AddMachineName()
    .AddUserName()
    .OnWindows(windows => windows
        .AddProcessorId()
        .AddSystemSerialDriveNumber())
    .OnLinux(linux => linux
        .AddCpuInfo()
        .AddSystemDriveSerialNumber())
    .ToString();

v6 is currently available as an alpha. Alternatively, users who want to stay on v5 can use v5.2.0 for WMI or v5.3.0 for MMI.

This error is not really fixed even though I am using the latest version of DeviceId 6.2.0

My application runs on two operating systems Windows 7/10


Switch to using gzip so we can re-use the compiled archives outside o…

…f github actions where zstd isn't available by default

Whoops sorry opened this on the wrong repo!


Add retries to KafkaJobStatusMonitor for recovery from transient JobStatus state store failure.

Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA

[ ] My PR addresses the following Gobblin JIRA issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"

https://issues.apache.org/jira/browse/GOBBLIN-1549
"GaaS should retry processing Kafka events in case of an error"

Description

[ ] Here are some details about my PR, including screenshots (if applicable):

At times, the state store may be unavailable, due to transient connection failure.  Once that resolves, we would like Gobblin Tracking Events to be processed w/o needing to restart the kafka consumer for that to happen.  thus, we continue retrying state store updates encapsulated within the message, so that connection repair is automatic (when within the configurable retry window).
Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

additional unit tests, included.
Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3399 (1a3b2d2) into master (47707df) will decrease coverage by 3.22%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #3399      +/-   ##
============================================
- Coverage     46.54%   43.31%   -3.23%
+ Complexity    10243     2005    -8238
============================================
  Files          2062      401    -1661
  Lines         80413    17187   -63226
  Branches       8981     2115    -6866
============================================
- Hits          37429     7445   -29984
+ Misses        39516     8904   -30612
+ Partials       3468      838    -2630

Impacted Files
Coverage Δ

.../org/apache/gobblin/util/retry/RetryerFactory.java
0.00% <0.00%> (ø)

...in/java/org/apache/gobblin/cluster/HelixUtils.java
34.71% <0.00%> (-3.31%)
:arrow_down:

.../gobblin/iceberg/writer/IcebergMetadataWriter.java
72.11% <0.00%> (-0.09%)
:arrow_down:

...gobblin/writer/http/AbstractHttpWriterBuilder.java

...rg/apache/gobblin/rest/JobExecutionInfoServer.java

...n/java/org/apache/gobblin/fork/CopyableSchema.java

...ava/org/apache/gobblin/scheduler/JobScheduler.java

...urce/extractor/DefaultCheckpointableWatermark.java

...pache/gobblin/compliance/HivePartitionVersion.java

...g/apache/gobblin/service/NoopRequesterService.java

... and 1653 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47707df...1a3b2d2. Read the comment docs.


Fix setup.py & increase version

Fix import broken by python 2 -> 3 upgrade.

@xiaoyun-matroid @brendan-matroid shall we aim to merge this PR and compile a newer version of matroid python API at some point?


Add the possibility to control a subset of coordinates in TSID::CoMTask

I ported the change https://github.com/ami-iit/bipedal-locomotion-framework/pull/357 from IK to TSID.
fyi @xela-95 @Gio-DS @diegoferigo @LoreMoretti

The changelog check failure is due to the action itself failing, as the changelog has been updated.


Non-fullscreen route

I want to add a "flash message" route so that it can be initiated from all other screens. Ideally, this flash message component should only be 80 pixels in height, and sits on top of the current route so that the current route is visible behind the flash component.
Is there a way to do this? I tried using the "modal" schema and setting a fixed height for the flash message component but that still creates a full-screen route.

Have you tried type='modal' ? Check Example, Error popup is definitely not full screen...

I said I did use "modal" but I guess I was on an older version of this library. Is there a change log? The release page still says 2.0.2 is a pre-release?

Why don't use latest release from npm? Anyway, i've updated release page with latest release.

I was using an earlier version due to this specific behavior I wanted. I just updated to the latest version and implemented that behavior: https://github.com/jamesfzhang/react-native-router-flux/commit/be18b3583fb15be91c213d12f0c8f1e64fda49fa
Essentially, I wanted "switch" behavior for "push" routes since I encountered a bug where I couldn't hide the navigation bar for "switch" routes. I also added an ability to reset a particular route ad-hoc.
Anyway, I updated to the latest version by my modal is still full screen. I'll check out your examples and see what the differences are.


Unable to Authenticate - Service provider responded in error: 301 (Moved Permanently)

I am unable to authenticate in MR2 and MR3.
There is a 500 error with this message:

Oops! Something went wrong.
We will work on fixing that right away.
Click on the Map button to start mapping again right away.
Error: Internal Server Error: Communication with the service provider failed: Service provider responded in error: 301 (Moved Permanently)

I guess it is HTTPS related. if I remember right there was an only HTTPS policy enforced a little while ago that caused problem with other OSM authenticated services.

This should now be resolved.


Small Improvements

added a auto Streamer mode detection and made some small improvements to the readme.md

Thank you for contributing, but this commit has some major flaws:
1. Naming conventions: https://peps.python.org/pep-0008/#function-and-variable-names
   Functions are lower case letters with underscores between the words. Like `def is_streamer_mode()`. Also, the `is_streamer_mode` function supposed to be inside the `Sonar` class, not next to it.

2. Why did you copy the whole `sonar.py` in a new file before adding new features to it? You could just edit the one in `src/steelseries_sonar_py/sonar.py`

3. What does `_ = None` does in the 7th row? Why is it neccessary there?

Didn't know it will change the Name

My Stupidity

Leftover from testing

Will change all the things and make a new commit, but thanks for the comment!


Replace existing test-framework with pytest-based Pelion tests

Clarify the purpose of the example.
Added .lib to python e2e test library.
General cleanup of the README.

Depends on: https://github.com/ARMmbed/pelion-e2e-python-test-library/pull/8

[x] Update pytest lib to final released version.

build-only

Test run: SUCCESS

Build artifacts
posted-by-tag: https://jenkins-client.isgtesting.com/job/mbed-os-example-pelion/


More natural color values

I saw that the official API uses int16 numbers for the colours, but it feels unnatural to me.
Would be nice to make abstraction of that at let us use a more natural writing style. something like: lx.lightsColour(170, '50%', '45%', .6, '1000ms') or maybe just provide a helper function that will do the math.
I think it would make it dramatically easier to use lifxjs for anyone likes me who comes from the frontend side of JS.
For me this is an issue, but please consider it as a suggestion.

+1 of this. Or allow me to drop in a Number from 0 to 1. I'm an EmberJS dude, non base 10 numbers are a bit over my head.

I've used this function to convert values to the hex16 value:
function hex16(val) {
    val &= 0xFFFF;
    var hex = val.toString(16).toUpperCase();
    return ("0000" + hex).slice(-4);
}

However, i'm not sure what ranges hue, brightness etc.. accept. Is that documented anywhere?

@kevincannon You find the range information in the lifx docs https://github.com/LIFX/lifx-protocol-docs/blob/master/messages/light.md#hsbk

Marius - neat, thanks for the info!

node-lifx is still work in progress and missing key features like turning on or off the lights or set the colors. When it is in any working state I will publish it on npm and write docs for it.
Since that I will help out with questions here where I can.

Great, thanks for the info. I was a bit confused. Luckily I still have one LIFX with the old firmware, so I can play with that.
Great library. It's been really amazing to use it!


Whoops, looks like something went wrong.

after click "Create Configuration File"
Whoops, looks like something went wrong.

i can't register, or make a configuration file either.. "woops something went wrong"

Same happens when clicking on explore button

Sorry for the troubles and the delay. It seems mysql kept crashing.

This one still doesn't work: http://getprotobox.com/box/Dk

@piotr-cz Fixed. Thanks again.

It's crashed again.

@manolof What error do you get? The url seems to be working for me.


Tracking issues of Swift binding

#2470 introduced the Swift binding to OpenDAL. This issue is for tracking the remaining tasks of it.
Tasks

[ ] Add contributing docs (especially on linux)
[ ] Complete the binding APIs
[ ] Refine package structure
[ ] Add tests and CI actions
[ ] Add async supports

Hi, let's build up the developement loop first.

Add contributing docs (especially on linux)
Setup tests and CI to make sure we don't break existing code.

Hi, let's build up the developement loop first.

Add contributing docs (especially on linux)

Setup tests and CI to make sure we don't break existing code.

Just updated the task list, and we can finish them according to the priorities.

Just updated the task list, and we can finish them according to the priorities.

It's better to sort the tasks in priorities order.


Revert "Cache Manifest files"

Reverts apache/iceberg-python#787
Integration tests (make test-integration) fail when this commit, but only for M1 Mac.

See #1162. Another user reported issue when running with M1 Mac.
kevinjqliu/iceberg-python/#5 ran integration test against none M1 macs (Github Action macos-12, macos-13) and test succeeded.

Integration tests pass 100% with the commit reverted
Error log: https://gist.github.com/kevinjqliu/c8310b6253beab52cce93391df03bfe4

Hi @kevinjqliu thanks for putting this together. Would you mind sharing the verbose exception trace for this issue? Conceptually, I don't think this should result in an error because the ManifestFile should have been cached as Records in memory.
I'd like to understand better to see if we can find a different solution than reverting this great feature

@sungwy thanks for following up on this. I added more details in the PR description.
My suspicion is that this is due to the generators in read_manifest_list  and fetch_manifest_entry, but its is just a hunch.

My suspicion is that this is due to the generators in read_manifest_list  and fetch_manifest_entry, but its is just a hunch.

Hey thanks for the link @kevinjqliu  - I think that gist only has the short test summary information, not the long exception traceback

@sungwy here you go
https://gist.github.com/kevinjqliu/a0e8e2199bd8064757eb2b40409e0794

Closing in favor of #1185


Optimize make_date

Is your feature request related to a problem or challenge?
I think there is significant performance to be had when creating dates and now thanks to @Omega359  there are benchmarks
To run the benchmarks, do:
cargo bench --bench make_date

Describe the solution you'd like
Make  the function faster, as defined by the command above
The high level procedure for this is to profile the function and figure out how to make it go faster while still computing the same results
Describe alternatives you've considered
It may not be possible to make this faster and in that case no worries.
Additional context
I think this is actually a pretty good initial project for someone because

The code is relatively straightforward
The benchmark is in place

A quick experiment replacing value_fn with pre-computed arrays shows about 50% improvement for benchmarks using columns but about 20% regression for scalar only benchmark (I think I should be able to get that scalar version back to baseline). If you think this is significant I can carry on working on it

Sounds pretty great to me -- thanks @r3stl355

I think with #9112 this issue could be closed @alamb  ?

I think with #9112 this issue could be closed @alamb ?

I agree -- thank you for the ping

@alamb I was looking at this out of interest and I just noticed that this issue has been closed in the meantime. I introduced some further improvements in https://github.com/apache/arrow-datafusion/pull/9600 which lead to about 10% performance gain for the cases involving arrays and about 20% for the scalars-only case.

Thank you @vojtechtoman  -- very exciting


JHU_VACCINES data is stale

JHU_VACCINES data in the Snowflake data exchange is stale
To Reproduce
select max(last_update_date) from JHU_VACCINES;

MAX(LAST_UPDATE_DATE)

2021-02-13 16:01:41.506

Expected behavior
The source data is up to date
Additional context
running the JHU_VACCINES notebook produces the below error.
  File "JHU_VACCINES.py", line 17, in <module>
    df["people_total"].str.replace(u"\u202C", "", regex=False).astype(str)
  File "/Users/devnolly/environments/dev/lib/python3.8/site-packages/pandas/core/generic.py", line 5137, in __getattr__
    return object.__getattribute__(self, name)
  File "/Users/devnolly/environments/dev/lib/python3.8/site-packages/pandas/core/accessor.py", line 187, in __get__
    accessor_obj = self._accessor(obj)
  File "/Users/devnolly/environments/dev/lib/python3.8/site-packages/pandas/core/strings.py", line 2100, in __init__
    self._inferred_dtype = self._validate(data)
  File "/Users/devnolly/environments/dev/lib/python3.8/site-packages/pandas/core/strings.py", line 2157, in _validate
    raise AttributeError("Can only use .str accessor with string values!")
AttributeError: Can only use .str accessor with string values!

The notebook completes successfully after removing this line:
df["people_total"] = ( df["people_total"].str.replace(u"\u202C", "", regex=False).astype(float))

Thanks for fixing so quickly!


jsk_recognition: 1.2.1-0 in 'indigo/distribution.yaml' [bloom]

Increasing version of package(s) in repository jsk_recognition to 1.2.1-0:

upstream repository: https://github.com/jsk-ros-pkg/jsk_recognition
release repository: https://github.com/tork-a/jsk_recognition-release.git
distro file: indigo/distribution.yaml
bloom version: 0.5.26
previous version for package: 1.2.0-0

checkerboard_detector

No changes

imagesift

No changes

jsk_pcl_ros

No changes

jsk_pcl_ros_utils

No changes

jsk_perception
* If chainer is not installed, use v2 (#2167 <https://github.com/jsk-ros-pkg/jsk_recognition/issues/2167>)
  * chainer can not install in ros build firm
* Contributors: Kei Okada

jsk_recognition

No changes

jsk_recognition_msgs

No changes

jsk_recognition_utils

No changes

resized_image_transport

No changes

this should fix ros build firm -> http://build.ros.org/job/Ibin_uT64__jsk_perception__ubuntu_trusty_amd64__binary/123/console


SeqApp in Seq v3

Hi
I've had success in the past with Seq.Apps but I haven't been able to get my Seq Apps to work since updating to Seq v3 (the specific version I'm on is 3.3.23). To make my issue easily replicable, I cloned this repo, open sln, and replaced everything in the Seq.App.FileArchive On method with an internal log. Ie.
public void On(Event<LogEventData> evt)
{
      this.Log.Debug("log me");
}

I package it with nuget v3.4.4, install it and start an instance in my local Seq, then manually add an event, and after waiting a while I don't see any log.
Is this just something funny I'm experiencing/doing-wrong or is there an issue?
Thanks
Steve

Hi Steve, thanks for getting in touch. Do you mean apps that you've written yourself, or the email/file archive/etc. apps published from here?
If it's the apps we ship, you may need to update them after upgrading (you can do this from Apps > Manage).
Otherwise, if it's your own apps that are failing, you may need to upgrade them to a more recent Serilog version (if you're referencing it), e.g. 2.2.0.
In either case, there should be some diagnostic info in C:\ProgramData\Seq\Logs. Can you spot any clues in there?
All the best,
Nick

Hi Nick,
This is referring to apps I've written myself, based off Seq.App.FileArchive. The ProgramData logs have given me clues thanks. First it said it couldn't find Serilog.Sinks.RollingFile, so I added it to the nuspec. Then it said System.MissingMethodException: Method not found: 'Serilog.Core.Logger Serilog.LoggerConfiguration.CreateLogger()', so I added all the dlls in the release folder
    <file src="bin\Release\Serilog.dll" target="lib\net45" />
    <file src="bin\Release\Seq.Apps.dll" target="lib\net45" />
    <file src="bin\Release\Serilog.Sinks.File.dll" target="lib\net45" />
    <file src="bin\Release\Serilog.Sinks.RollingFile.dll" target="lib\net45" />

And now I get
System.InvalidCastException: Unable to cast object of type 'Seq.App.FileArchive.ArchiveWriterReactor' to type 'Seq.Apps.Reactor'.
   at Seq.Server.Features.Runner.AppHost.<>c.<.ctor>b__10_0(Type mrt)
   at Seq.Server.Features.Runner.AppHost..ctor(ILogger logger, Func`2 createReactorInstance, HostedApp hostedApp, AppInstance appInstance, AppHostSettings settings)
   at Seq.Server.Features.Runner.AppHost..ctor(IInternalEventPublisher publisher, HostedApp hostedApp, AppInstance appInstance, AppHostSettings settings)
   at Seq.Server.Features.Runner.SandboxedAppContainer.Initialize(IInternalEventPublisher publisher, String hostedApp, String appInstance, AppHostSettings settings)
   at Seq.Server.Features.Runner.SandboxedAppContainer.Initialize(IInternalEventPublisher publisher, String hostedApp, String appInstance, AppHostSettings settings)
   at Seq.Server.Features.Runner.RunningApp.LoadSandboxedAppContainer(AppDomain domain, HostedApp app)
   at Seq.Server.Features.Runner.RunningApp.Run()

Which I'm not sure how to solve.
Thanks
Steve

Hi Steve, thanks for all the info.
You shouldn't need to include Seq.Apps.dll, Serilog.dll or either of the file sinks in the package, but you may need to make sure the versions line up with what Seq is currently using.
I.e. your packages.config file should be like:
<?xml version="1.0" encoding="utf-8"?>
<packages>
  <package id="Seq.Apps" version="1.6.4" targetFramework="net45" />
  <package id="Serilog" version="2.0.0" targetFramework="net45" />
  <package id="Serilog.Sinks.File" version="2.0.0" targetFramework="net45" />
  <package id="Serilog.Sinks.RollingFile" version="2.1.0" targetFramework="net45" />
</packages>

One possible cause for the MissingMethodException, if these are already the versions you're referencing, could be out-of-date reference paths in your .csproj file. If you've upgraded Serilog for instance, the csproj may still be pointing at the old Serilog.dll. Any clues there?
Regards,
Nick

Hi Nick,
I tried your suggested but unfortunately no dice. I haven't had any breakthrough with this so I thought I'd try the Seq.App.FileArchive nuget package. Installed it, created an instance, set the directory to an empty folder, then went back to the events page and selected 'Send to App' -> the instance, on a few events. The result after a few minutes is nothing. The ProgramData logs indicate that I've installed the app but that's it. No exception. And no files in the folder. It's not a restricted folder. If no one else is experiencing this issue it's made me think it's my install of Seq. So I uninstalled it then installed it again. Still nothing.
Do you have any other ideas I could try?
Thanks
Steve

Hi Steve, thanks for the follow-up.
Just to be sure, I went through the same steps again here - fresh 3.3.23 install, installed the File Archive (latest) from NuGet, and sent some events manually - all working as expected. No clues there.
One thing I did realize is that the file archive app will suppress things like permissions errors (since it's based on the Serilog rolling file sink). Apart from permission to the folder, which it sounds like you've investigated,

is the file path a filename, not a folder name?
is the {Date} token in the filename, not another path segment?

Redirecting Serilog's SelfLog to another location might reveal something - worth checking out.
I can jump onto a Skype call with you and help debug this if you're still blocked this week - feel free to drop me a line through nblumhardt/getseq.net if you'd like to set one up.
Cheers,
Nick

Thanks for your assistance Nick. It was my mistake when testing the FileArchive app (I didn't specify the filename). And I just dug up an older Seq.App I made and it still works, so there must be something in my current project that's causing the InvalidCastException. Not sure exactly what yet but it's on my side I won't trouble you further here. Cheers, Steve

Thanks for closing the loop, Steve. If there's any way I can help out further please just drop me a line 👍


[BUG]: Creating transactions with a model that contains unique properties

Describe the bug
Whenever you try and create a transaction on a model that contains unique properties the transaction gets executed before expected. (Another small thing to add to this: When creating an item that has unique properties and timestamps enabled the timestamps getd saved as an empty object rather than the expected date)
To Reproduce
The following code: https://gist.github.com/garretcharp/5c3215a3e5c914c484922ccf4fbd12de
Expected behavior
I would expect that the transaction does not get executed until I call table.transact('write', transaction) however the transaction gets executed as soon as I call create on the model that includes unique attributes. (Note that setting { execute: false } in the params does not change this, though I (personally) would expect it not to execute if I pass it in a transaction object regardless of the execute param)

Thanks for reporting. That is a bug.

Easy fix really. Thanks. Will roll out in a few days. Or do you need a quick patch now?

Whenever the next update is will work.


No documentation for table.double()

There's no documentation for schema building function .double(). After several attempts with:
knex.createTable(uniqueTableName, (table, colName) => {
  table.float(colName, 64); // thinking precision were bits
  table.float(colName, 8, 8); // thinking scale might tell bit-size
});

I could get a table with double precision. So I dove into knex source code and found there's a table.double() which does exactly what I want.
Could you add missing documentatio for this function? Also, I say the column compiler doing more stuff, maybe there're other useful functions missing from docs.
Also, table.float() doc is not clear to me. What's scale ?
I help is needed on this, I'll be happy to jump in, just point me in the right direction please.

@fernandocanizo

I could get a table with double precision.

Looking at your code I'm not sure how exactly you've achieved double precision? Can you make it clear for me, I got the same issue. (PostgreSQL)


Update 0021-merge-two-sorted-lists.py

File(s) Modified: 0021-merge-two-sorted-lists.py
Language(s) Used: python
Submission URL: _https://leetcode.com/problems/merge-two-sorted-lists/submissions/1033628102/_

Use recursion and it is surprisingly fast.

@sujal-goswami Nice! I added the new solution separately below the original one.


Improve use of Futures in Gatherer

Attempt to fix #2696. This replaces the complicated mutation retry logic in Gatherer with a more structured/algebraic approach.
This new approach is recursive. Making the recursive call asynchronously should prevent a stack overflow (it does in the tests that I've run), since the task is submitted to the common ForkJoinPool rather than being called directly. This probably imposes a performance penalty, but I don't know how that compares to the cost of the I/O in this codepath.

A full build including IT's passed. @keith-turner  - is there anything else for this PR or can we merge it?

A full build including IT's passed. @keith-turner - is there anything else for this PR or can we merge it?

I think it's good to merge.  This is a very nice PR.  When I looked I asked myself two questions, is the new code correct and is the existing functionality preserved.  For both questions I concluded yes.  It does those two things with new code that easier to understand and has a unit test.

Thanks for the contribution @nosewings and welcome to the Apache Accumulo community. If you would like to be listed as a contributor on Accumulo's people page please make a website PR for people.md.
If you intend to make more contributions, please consider subscribing to the dev list and introducing yourself. Also, you can use the dev list or slack to reach out if you have questions about anything. See https://accumulo.apache.org/contact-us/


[2.x][Hotfix] Fix laravel 9 compatibility

Laravel added singleton as a route in the last release.
As we also use that as a macro we have to introduce this breaking change.
To add to release notes:
To fix replace all:

Route::module -> Route::twillModule
Route::singleton -> Route::twillSingleton

@ifox anything I may be missing here?

Nope, looking good!
The only thing is that we're not supposed to do breaking changes on 2.x but it wouldn't make sense for it to be 3 either.
Considering the change is very simple to apply for consumers, I think this is fine to do as a minor. We'll just blame Laravel for stealing our route macro name if someone isn't happy about it 🙃

It is indeed a breaking change but required to continue to support Laravel 9. Can we message users on composer update somehow?

Maybe overkill, but what do you think about providing a Rector rule for it? I guess we'll want it for Twill 3 anyway, so it could be nice to ship it here too.

This type of change cannot be changed with rector that easily I am afraid. It's a simple find-and-replace, we could provide an example on how to do that? But this as well seem's too much, it is/should be just  a change in routes/admin.php

https://gist.github.com/delenamalan/3c0d998a316031af8f0f9c0165eacc28


fix typo in daemonset labelSelector

The label on the pod is app: node-problem-detector while the
label in the labelSelector was name: node-problem-detector.
This CL updates the labelSelector to use app rather than name.

/lgtm
/approve
Thanks @rlguarino for helping take care of this. 👍


sk_SK Person names sorted and removed duplicates

What has been changed:

Sorted first and last names for male and female
removed duplicates ('Bartoš', 'Hanzel', 'Holub', 'Kučera', 'Růžička', 'Sloboda')

Requested in https://github.com/fzaninotto/Faker/pull/1736#pullrequestreview-302711393

Please see #1851


React hooks rules

This seems to be working -  please try it out :)

dame you beat me on it lol

thanks heaps @barrymay again ❤ get this bad boy in.

hahah.  I was inspired by the challenge!  The major change I made was to split out the setFields into a function that doesn't validate , and only have the outer function allow the validation step ;)

Please do test your own apps on it - I consider it a big change, but assuming it all works, it should be a good one - @chrisparton1991  please do test this too!

yea thanks @barrymay I am testing it with apps

here is a beta version 3.19.2-beta.1 if you want to install as node_module

@barrymay FYI I am planning to write some automation test for this lib, less manual testing.

The more automation the merrier for sure!
Suggestions:  cypress or more unit tests using React-testing-library is a great idea 😊

yea I am going to use cypress 👍 I think my unit test is not there for sure, need to revisit them as a whole (especially around the hook).

Super!

Thanks for this, 3.19.2-beta.1 is working perfectly for me 🎉

thanks @chrisparton1991 for your testing, looks good on my end too. will publish this baby 👍

sweet  - happy to see this one happen  🎉


removal of php5.6 build flows

Can we finally remove those outdated GitHub Actions build workflows?

CI / build-php (5.6, php-fpm)
CI / build-php (5.6, php-worker)

Hi guys, I want to start the discussion of removing all dependencies (and build workflows) for unsupported PHP versions:
https://www.php.net/supported-versions.php
I believe we shall remove everything that depends on PHP lower than 8.0
Thoughts?
@mahmoudz
@appleboy
@philtrep
@mikeerickson
@zeroc0d3
@thorerik
@winfried-van-loon
@sixlive
@bestlong
@urukalo
@vwchu
@zuohuadong
@lanphan
@ahkui

Thoughts? guys?

I support keeping 7.x or even 7.4.x and dropping 5.x

5.x for sure, but do we want to keep 7.x?

7.4.x should be retained

remove 5.x and keep 7.x version.

@Mahmoudz
@appleboy
@philtrep
@mikeerickson
@zeroc0d3
@thorerik
@winfried-van-loon
@sixlive
@bestlong
@urukalo
@vwchu
@zuohuadong
@lanphan
@ahkui
Thoughts guys? Can we vote on it? Or can we simply start removing 5.x dependencies?

I would limit to PHP's official Supported Versions and remove older versions:
https://www.php.net/supported-versions.php

I would limit to PHP's official Supported Versions and remove older versions: https://www.php.net/supported-versions.php

Would you drop everything < 8.1 ?


Updating an "enum" field through lambda does not work.

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
v12.22.0
Amplify CLI Version
8.0.2
What operating system are you using?
Mac
Did you make any manual changes to the cloud resources managed by Amplify? Please describe the changes made.
No manual changes mad
Amplify Categories
api
Amplify Commands
Not applicable
Describe the bug
I have my whole application setup and working 100%.
I have a schema (which I will describe in its section) where I have a few fields, as well as a couple of enum fields.
I'm using React + typescript so, in the front-end, everything works fine. I am able to call graphql and create and update without any dramas.
Frontend example (uses typescript)
    const { data } = await API.graphql(
      graphqlOperation(createUser, { input: { name: 'Rafael', email<EMAIL_ADDRESS>membership: Membership.GOLD  } })
    ) as CreateUserResult;

The issue is, that now I need to make updates to the same model in the backend through a lambda. So I create the lambda function, added the graqphl auth, and the methods to make the graphql call in the backend.
So far so good, I made a couple of tests, and I am able to update different models using mutations. HOWEVER, when a mutation has ENUM properties, I cannot make it work.
In the backend I do not use typescript, so I can't use enums, since enums is really a translation of strings, I tried to send strings, and it wouldn't throw any error, it would just do NOT update.
   await graphQLRun(createUser, { input: { name: 'Rafael', email<EMAIL_ADDRESS>membership: 'GOLD' } });

PS: graphQLRun is the method I call for all my lambdas to make calls to graphql.
I have no idea what else to try.  This sounds to me like a bug since the value should really be translated to a string anyway, we should be able to just send a string to the enum property and this should work.
Expected behavior
I should be able to just use a string as the value and it should've worked.
Reproduction steps

Create the schema below
Create a new function
Create methods to send graphql requests
In the lambda, send a mutation request that contains an enum value but uses a string
Nada! Does not update.

GraphQL schema(s)

# Put schemas below this line
type User @model(subscriptions: null)
  @auth(
    rules: [
      { allow: owner, ownerField: "username" }
      { allow: private, operations: [read, update], provider: iam },
      { allow: groups, groups: ["Admin"] }
    ]
  )
{
  id: ID!
  email: String!
  name: String!
  membership: Membership!
}

enum Membership {
  ADMIN
  BRONZE
 SILVER
GOLD
}

Log output

# Put your logs below this line

Additional information
No response

Hey @rafaelfaria :wave: thanks for raising this! Unfortunately I was not able to reproduce using the provided steps. When you say it's not updating, are you checking this from the returned response or from another AppSync query?

@josefaidt
Correct.
I run my lambda function, to update the property that has a type enum, however, instead of using an enum, I just send a string.
WHen I check the records through app sync, it doesn't show any changes, but I also don't get any errors when i send the request.

Hey @rafaelfaria thank you for the clarification! I took another attempt at reproducing this with two enums, one with two values, one with three values, and unfortunately have not been able to reproduce this issue. I have a few follow-up questions

Are the other non-enum values updating as expected?
Are there any field-level auth rules present?
can you share the full Node.js snippet that is calling the GraphQL API?

I used the following example:
enum PaymentInterval {
  MONTHLY
  QUARTERLY
  YEARLY
}

type Membership
  @model
  @auth(
    rules: [
      { allow: owner, ownerField: "id", operations: [create, read] }
      { allow: private, provider: iam, operations: [update, delete] }
    ]
  ) {
  id: ID!
  status: Status @default(value: "INACTIVE")
  paymentInterval: PaymentInterval
}

Using this model, I log in as a user and create the membership. From there we can use a REST API to modify the user's membership details such as status and paymentInterval
import crypto from '@aws-crypto/sha256-js'
import { defaultProvider } from '@aws-sdk/credential-provider-node'
import { SignatureV4 } from '@aws-sdk/signature-v4'
import { HttpRequest } from '@aws-sdk/protocol-http'
import { default as fetch, Request } from 'node-fetch'

const { Sha256 } = crypto
const AWS_REGION = process.env.AWS_REGION || 'us-east-1'

const MUTATION_UPDATE_MEMBERSHIP = /* GraphQL */ `
  mutation MUTATION_UPDATE_MEMBERSHIP($input: UpdateMembershipInput!) {
    updateMembership(input: $input) {
      id
      status
      paymentInterval
    }
  }
`

/**
 * @type {import('@types/aws-lambda').APIGatewayProxyHandler}
 */
export const handler = async (event) => {
  console.log(`EVENT: ${JSON.stringify(event)}`)

  const { id, status, interval } = event.queryStringParameters
  const variables = {
    input: {
      id,
      status,
      paymentInterval: interval,
    },
  }

  const endpoint = new URL(process.env.API_9966_GRAPHQLAPIENDPOINTOUTPUT)

  const signer = new SignatureV4({
    credentials: defaultProvider(),
    region: AWS_REGION,
    service: 'appsync',
    sha256: Sha256,
  })

  const requestToBeSigned = new HttpRequest({
    method: 'POST',
    headers: {
      host: endpoint.host,
    },
    hostname: endpoint.host,
    body: JSON.stringify({ query: MUTATION_UPDATE_MEMBERSHIP, variables }),
    path: endpoint.pathname,
  })

  const signed = await signer.sign(requestToBeSigned)
  const request = new Request(endpoint, signed)

  let statusCode = 200
  let body
  let response

  try {
    response = await fetch(request)
    body = await response.json()
    if (body.errors) statusCode = 400
  } catch (error) {
    console.log(error)
    statusCode = 500
    body = {
      errors: [
        {
          message: error.message,
        },
      ],
    }
  }

  return {
    statusCode,
    body: JSON.stringify(body),
  }
}

@josefaidt Sounds like you are right. I have made a really simple test and it seems to be working, however, it isn't on the lambda I have set up. I will try to dig further to see what is causing not to update it and report back.

Hey @rafaelfaria thanks for the update! Looking forward to hearing back 🙂


Link to “NuGet Get Nearest Framework Tool” broken (403 Forbidden)

The link to NuGet Get Nearest Framework Tool is https://aka.ms/s2m3th but it's broken and yields a 403.

I just tried the aka.ms link and it seems to be working fine. Can you try again?

@kraigb Seems to be working again so closing the issue.


memcached: 1.5.9 -> 1.5.10

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/memcached/versions.
meta.description for memcached is: '"A distributed memory object caching system"'.

Checks done (click to expand)

built on NixOS
/nix/store/s4qdazpg5hcz5bpgx2cm7kzcnmbaf57m-memcached-1.5.10/bin/memcached passed the binary check.
1 of 1 passed binary check by having a zero exit code.
1 of 1 passed binary check by having the new version present in output.
found 1.5.10 with grep in /nix/store/s4qdazpg5hcz5bpgx2cm7kzcnmbaf57m-memcached-1.5.10
directory tree listing: https://gist.github.com/b97241b27c5d196b16c8cdcb522a0dea
du listing: https://gist.github.com/31904a211065b528846accac9ff981fe

Test this build with Cachix (click to expand)

One time setup in nixpkgs Git checkout:
cachix use r-ryantm
git remote add r-ryantm https://github.com/r-ryantm/nixpkgs.git

Test this build:
git fetch r-ryantm && git checkout a3a70227bae7113fb56802c748b8aad44abaa52b && nix-shell --pure -I nixpkgs=. -p memcached

cc @coreyoconnor for testing.

Success on x86_64-linux (full log)
Attempted: memcached
Partial log (click to expand)
make[1]: Leaving directory '/build/memcached-1.5.10'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/s4qdazpg5hcz5bpgx2cm7kzcnmbaf57m-memcached-1.5.10
shrinking /nix/store/s4qdazpg5hcz5bpgx2cm7kzcnmbaf57m-memcached-1.5.10/bin/memcached
gzipping man pages under /nix/store/s4qdazpg5hcz5bpgx2cm7kzcnmbaf57m-memcached-1.5.10/share/man/
strip is /nix/store/gpc2wld1s0c6qzx9326cwn1wcx29xzsj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/s4qdazpg5hcz5bpgx2cm7kzcnmbaf57m-memcached-1.5.10/bin
patching script interpreter paths in /nix/store/s4qdazpg5hcz5bpgx2cm7kzcnmbaf57m-memcached-1.5.10
checking for references to /build in /nix/store/s4qdazpg5hcz5bpgx2cm7kzcnmbaf57m-memcached-1.5.10...
/nix/store/s4qdazpg5hcz5bpgx2cm7kzcnmbaf57m-memcached-1.5.10

Success on x86_64-darwin (full log)
Attempted: memcached
Partial log (click to expand)
 /nix/store/ky1iq8hmr1b958d8fcaggpyaxhnfa8a6-coreutils-8.29/bin/install -c -m 644 protocol_binary.h '/nix/store/7in9fhp636lyiw2cwb0iq000dqsa4lfk-memcached-1.5.10/include/memcached'
make[3]: Leaving directory '/private/tmp/nix-build-memcached-1.5.10.drv-0/memcached-1.5.10'
make[2]: Leaving directory '/private/tmp/nix-build-memcached-1.5.10.drv-0/memcached-1.5.10'
make[1]: Leaving directory '/private/tmp/nix-build-memcached-1.5.10.drv-0/memcached-1.5.10'
post-installation fixup
gzipping man pages under /nix/store/7in9fhp636lyiw2cwb0iq000dqsa4lfk-memcached-1.5.10/share/man/
strip is /nix/store/251fvx4mx9q4zarbca5cciasmn66p668-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/7in9fhp636lyiw2cwb0iq000dqsa4lfk-memcached-1.5.10/bin
patching script interpreter paths in /nix/store/7in9fhp636lyiw2cwb0iq000dqsa4lfk-memcached-1.5.10
/nix/store/7in9fhp636lyiw2cwb0iq000dqsa4lfk-memcached-1.5.10

Success on aarch64-linux (full log)
Attempted: memcached
Partial log (click to expand)
make[1]: Leaving directory '/build/memcached-1.5.10'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jm8ljs1shmp2890425yrdwifm82z3q51-memcached-1.5.10
shrinking /nix/store/jm8ljs1shmp2890425yrdwifm82z3q51-memcached-1.5.10/bin/memcached
gzipping man pages under /nix/store/jm8ljs1shmp2890425yrdwifm82z3q51-memcached-1.5.10/share/man/
strip is /nix/store/ah0va6j4cnwj9nx4j6rwcfc8nh785jwm-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/jm8ljs1shmp2890425yrdwifm82z3q51-memcached-1.5.10/bin
patching script interpreter paths in /nix/store/jm8ljs1shmp2890425yrdwifm82z3q51-memcached-1.5.10
checking for references to /build in /nix/store/jm8ljs1shmp2890425yrdwifm82z3q51-memcached-1.5.10...
/nix/store/jm8ljs1shmp2890425yrdwifm82z3q51-memcached-1.5.10


Simple data pipe UI redesign

@ptitzler feel free to merge whenever you are ready. this includes changes from feedback from @mikebroberg (progress bar update, runs table sort)

+1


Calculation Error in Spider!!!

Description
What steps will reproduce the problem?

I think everyone of you can understand what is the output of the following code:
   for j, F in zip(range(1000), [(x/1000)+0.001 for x in range(1000)]):    print ("j = ",j, "==========", "F = ", F )
should be 0.001.....1.0
but instead in spider I get 0.502 .....1.0. Only half of the numbers, I am using the same code in Jupiter the result is true.
I think you need to check spider. I downloaded Anaconda, so spider came with it.
Versions

Spyder version: 3.3.6
Python version: 3.7.4
Qt version: 5.9.6
PyQt5 version: 5.9.2
Operating System: Windows 8.1

Dependencies
pyflakes >=0.6.0  :  2.1.1 (OK)
pycodestyle >=2.3 :  2.5.0 (OK)
pygments >=2.0    :  2.4.2 (OK)
sphinx >=0.6.6    :  2.2.0 (OK)
rope >=0.9.4      :  0.14.0 (OK)
jedi >=0.9.0      :  0.15.1 (OK)
nbconvert >=4.0   :  5.6.0 (OK)
pandas >=0.13.1   :  0.25.1 (OK)
numpy >=1.7       :  1.16.5 (OK)
sympy >=0.7.3     :  1.4 (OK)
cython >=0.21     :  0.29.13 (OK)
qtconsole >=4.2.0 :  4.5.5 (OK)
IPython >=4.0     :  7.8.0 (OK)
matplotlib >=2.0.0:  3.1.1 (OK)
pylint >=0.25     :  2.4.2 (OK)

Not all numbers are printed in Spyder, just the last 500 for efficiency reasons.

Thank you very much I tested my numbers and it's counting all but for printing not all numbers are shown!


[Hub Generated] Review request for Microsoft.Databricks to add version stable/2023-05-01

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM API Information (Control Plane)
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo.  If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:

What's the purpose of the update?

[ ] new service onboarding
[x] new API version
[ ] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When are you targeting to deploy the new service/feature to public regions? Please provide the date or, if the date is not yet available, the month.
When do you expect to publish the swagger? Please provide date or, the the date is not yet available, the month.
By default, Azure SDKs of all languages (.NET/Python/Java/JavaScript for both management-plane SDK and data-plane SDK, Go for management-plane SDK only ) MUST be refreshed with/after swagger of new version is published. If you prefer NOT to refresh any specific SDK language upon swagger updates in the current PR, please leave details with justification here.

Contribution checklist (MS Employees Only):

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

Applicability: :warning:
If your changes encompass only the following scenarios, you should SKIP this section, as these scenarios do not require ARM review.

Change to data plane APIs
Adding new properties
All removals

Otherwise your PR may be subject to ARM review requirements. Complete the following:

[x] Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review.  Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.

Adding a new service
Adding new API(s)
Adding a new API version
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.

[x] Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run unifiedPipeline

/azp run

@msyyc Please help to confirm the Python SDK breaking change.

@live1206 service deployment is expected to be completed by end of month. don't merge it.

@mvvsubbu [Staging] ServiceAPIReadinessTest is failing, it seems your service is not deployed yet, details can be found via https://github.com/Azure/azure-rest-api-specs/pull/23470#issuecomment-1500522262

@live1206 got it thanks for sharing this information. Yes our service changes are not deployed yet. I will rerun the validations once the deployment of service is done.

/azp run

@live1206 can you merge this PR, all the changes were deployed to production.

/azp run


Update database schema

🗣 Description

Creates the cyhy tables
Adds first_seen/last_seen/current for all asm assets (i.e. CIDRs, IPs, domains, etc.)
Adds columns to the organization table to support scorecard generation
Creates all the database functions that generate P&E metrics

✅ Pre-approval checklist

[ ] This PR has an informative and human-readable title.
[ ] Changes are limited to a single goal - eschew scope creep!
[ ] All future TODOs are captured in issues, which are referenced
in code comments.
[ ] All relevant type-of-change labels have been added.
[ ] I have read the CONTRIBUTING document.
[ ] These code changes follow cisagov code standards.
[ ] All relevant repo and/or project documentation has been updated
to reflect the changes in this PR.
[ ] Tests have been added and/or modified to cover the changes in this PR.
[ ] All new and existing tests pass.

Coverage: 26.288%. Remained the same when pulling 4409d96796a5ab38d2437c09340a43454acaf41e on AL-update-schema into 79ce2c18ba4c6abfad8ff4ec6b9e7efa784f1af6 on develop.


Assign location to tokens

That allow implement parsers which indirectly span across multiple files, like C/C++

Related: https://github.com/LanguageDev/Yoakke/issues/34#issuecomment-1003509503

This PR can be considered draft in a sense that it has flaws and require discussion. Also tired.

SourceFile as abstraction too much tied to TextReader. Lexers need direct access to TextReader, but SourceFile diagnostics machinery require buffered access where precalculated lines. Possble highligt issue in SourceFile implementation
I have to reimplement Equals and GetHashCode for Token. That also hints on too much coupling between concepts.

Would like to start talking about directions.

Also I did not attempt to make API without breaking changes. Have to know opinion on the matter, and is breaking changes possible

I come to conclusion that features of SourceFile which trigger inconsistent behaviour is overkill. Would be good if SourceFile would no longer be derived from TextWriter, and for backward compatibility there either other class with similar functionality, or make breaking change.

Will try to summon @LPeter1997 to discuss things

Sorry for the super-delayed reply. I'll try to get to this in a week or so. I'm sadly working on other things and I have many-many things left here to tidy up.

@fornever I manage to change PR to the state where it does not have source breaking changes, and only binary one. What do you think, should I go further and make it binary compatible (which ideally proper way)

I'd say that Yoakke shouldn't care about binary compatibility for now.


Error when launching with version 6.0.0

The build works (aot) but when I run my app I get the following error in my console:
ERROR Error: Uncaught (in promise): Error: StaticInjectorError(AppModule)[UserAgentInfoDirective -> ResponsiveState]:
  StaticInjectorError(Platform: core)[UserAgentInfoDirective -> ResponsiveState]:
    NullInjectorError: No provider for ResponsiveState!

I use the "user-agent-info" component.
It reads like the ResponsiveState service isn't part of a module (in the provider section).
It seems like there is a general problem when using your components. If I add the "responsiveSizeInfo" component then I get another error:
ERROR Error: Uncaught (in promise): Error: StaticInjectorError(AppModule)[ResponsiveSizeInfoDirective -> ResponsiveState]:
  StaticInjectorError(Platform: core)[ResponsiveSizeInfoDirective -> ResponsiveState]:
    NullInjectorError: No provider for ResponsiveState!

Here is the same problem.

In your app.module add the ResponsiveModule with the forRoot call:
@NgModule({
  declarations: [
    AppComponent
  ],
  imports: [
    BrowserModule,
    CommonModule,
    ResponsiveModule.forRoot()
  ],
  providers: [],
  bootstrap: [AppComponent]
})
export class AppModule { }


Question: is there a benchmark for Vulkano where one thread renders and another thread loads content?

I'm using Rend3/WGPU, and I have a big performance problem. Multiple threads are loading content into the GPU in parallel with the render thread rendering. With no content loading in progress, I get 60 FPS. With content loading in progress, that can drop to 10 FPS. That's awful. I need to know if switching from WGPU to Vulkano can fix that.
The application is a metaverse client, Sharpview.  100% safe Rust. Here are some test videos.

Second Life Fantasy Faire 2024
One hour of driving on a motorcycle. The long delays for new areas to load are due to a server side problem unrelated to this topic.

Content is constantly loaded from servers as the player travels around a big world with petabytes of content. The whole world cannot possibly fit in the GPU all at once. So there's a huge amount of GPU data loading required. That's where Vulkan is supposed to perform well.
The goal of all this is to get Second Life/Open Simulator, which has historically been sluggish, to perform like an AAA title. The older clients use OpenGL, and they are bottlenecked on the main thread.
Sharpview is highly concurrent. The render thread does nothing but render. Content loading threads run in parallel. The content loading threads shouldn't kill the render thread performance, but they do.  The performance problems seem to be 1) WGPU has lock conflicts, and 2) WGPU only uses one Vulkan queue. This has been verified with Tracy profiles, and the WGPU devs admit this is a problem. Vulkan itself should have the needed performance, but WGPU introduces bottlenecks.
So that's the problem.
I have a benchmark, render-bench.  This demonstrates render thread slowdown with one render thread and one content creation thread. Is there a similar benchmark for Vulkano I could use for comparison? Something where content is loaded at high rates from other threads? Thanks.

Thank you very much for the honest answer.

When it comes to vulkano, it currently has huge inefficiencies both host and device-side. ... I'm currently working on rewriting all synchronization

Good to hear that there is work underway. Please keep plugging away. It's hard.
I'm mostly targeting gamer PCs. Steam, the game distribution system, tracks this. Currently, the top 15 graphics cards used by Steam gamers are all pretty good NVidia cards, the NVidia 3060 being most popular.
All of those have enough power to run Vulkan/Vulkano with concurrent asset loading. At this moment, 28 million users are logged into Steam, and they claim 120 million active users. So that's the target market for high-performance gaming. That's where Unreal Engine shines.
As yet, no Rust graphics stack can use such hardware effectively. Everybody bottlenecks on the main thread. This is a major drag on Rust game dev.

Kajiya looks nice. But they write "Kajiya does not currently aim to be a fully-featured renderer used to ship games, support all sorts of scenes, lighting phenomena, or a wide range of hardware. It's a hobby project, takes a lot of shortcuts, and is perpetually a work in progress." Probably not a good idea to try to use that for something else.
There's also a sailing game which calls 'good old DX11", as the developer says, directly. Windows-only, of course.


add a feature request template

Codecov Report

Merging #1217 into master will decrease coverage by 0.6%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1217      +/-   ##
==========================================
- Coverage   43.55%   42.94%   -0.61%
==========================================
  Files          32       32
  Lines        3577     3539      -38
  Branches      581      581
==========================================
- Hits         1558     1520      -38
- Misses       1877     1878       +1
+ Partials      142      141       -1

Impacted Files
Coverage Δ

instabot/bot/bot.py
75.75% <0%> (-1.43%)
:arrow_down:

instabot/utils.py
86.66% <0%> (-0.57%)
:arrow_down:

instabot/api/api.py
49.72% <0%> (-0.5%)
:arrow_down:

instabot/api/prepare.py
10.76% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40961df...ce9d2c5. Read the comment docs.

I think it is a standard to use these templates with the caps-locked name like FEATURE_REQUEST.md (I saw that many times in other repos). I'd suggest renaming this file.

Woops wrong button. And what do you suggest? This is especially used for a future request


feat: add youtube video by hu-po

Closes #15

@hu-po, your Youtube video has been added to the Awesome List


es3.x shader - compiling issue

hello,
i'm trying to compile es3.x shader with sampler2dArray support. its not supported in the core es2.x api, but its part of es3.x.
line from my shader:
 SAMPLER2DARRAY(s_albedo, 0);
the error:
394: uniform sampler2DArray s_albedo;
24:                        ^
Error: (394,24): error: syntax error, unexpected NEW_IDENTIFIER, expecting '{'

Failed to build shader.

is es3.x supported by shaderc? (my bgfx code base is from april)
edit: the command line option is -> shaderc.exe -f fs_terrain_new.sc -o essl/fs_terrain_new.bin --type f --platform android

It should be handled by shaderc, I'll take a look.


[BUG] Drop CentOS7 support in 24.06

Describe the bug
We plan to drop CentOS 7 (which uses glibc 2.17) & Ubuntu18.04(glibc 2.27) in RAPIDS 24.06. This issue documents some of the work items needed to complete the drop in platform support.  Refor to :
https://docs.rapids.ai/notices/rsn0037/
https://github.com/rapidsai/build-planning/issues/23
https://github.com/NVIDIA/spark-rapids/issues/10496
The new minimum glibc supported by RAPIDS will become 2.28 (used by Rocky 8), because that is the oldest glibc of any operating system we currently support.

CentOS 7 : 2.17
Ubuntu18 : 2.27
Rocky8 :  2.28
Debian10: 2.28
Ubuntu20: 2.31
Ubuntu22: 2.35

Will need to:

[ ] Update scripts/Docker of 24.06 for JNI/spark-rapids-JNI to support Rocky8
[ ] Build 24.06 cuDF JNI/spark-rapids-JNI on Rocky8
[ ] Aggregate spark-rapids-jni into 24.06 spark-rapids
[ ] Drop spark-rapids Integration tests against Ubuntu18 or CentOS7
[ ] Check IT on CSP to makes sure no CentOS7 and Ubuntu18 or below OS

Built out amd64/arm64 spark-rapids-jni jars on Rocky8, running integration tests with spark-rapids to see if any GLIBC issues.


[go_router] the whole app restart when locale changed (with easy_localization)

Is there an existing issue for this?

[X] I have searched the existing issues
[X] I have read the guide to filing a bug

Steps to reproduce
I change the app locale by
      onChanged: (String? value) async {
        if (value != null) {
          await context.setLocale(Locale(value));
        }
      },

but it will restart the whole app, which is not what I want.
How to keep the same screen after I change the locale?
Thanks
I am using go router and it seems using MaterialApp.router will restart the whole app when setting locale.
I tried with traditional Navigator.push it works perfectly.
However, when I changed to use go router, it will restart the app.
Expected results
Should not restart the app when changing locale.
Actual results
The whole app restarted.
Code sample
Code sample
I made a minimum reproducible code for your reference:
go router version, which will restart the whole app:

            MaterialApp.router(
          routerConfig: GoRouter(
            routes: [
              GoRoute(
                path: '/lang',
                builder: (context, state) => Scaffold(
                  body: Container(
                    margin: EdgeInsets.all(100),
                    child: SizedBox(
                        height: 500,
                        child: Column(children: [
                          DropdownButton(
                            value: context.locale.toString(),
                            items: const [
                              DropdownMenuItem(
                                value: "en",
                                child: Text("English"),
                              ),
                              DropdownMenuItem(
                                value: "zh",
                                child: Text("繁體中文"),
                              ),
                            ],
                            onChanged: (String? value) async {
                              if (value != null) {
                                await context.setLocale(Locale(value));
                              }
                            },
                          ),
                          InkWell(
                              onTap: () =>
                                  {},
                              child: Text("edit".tr()))
                        ])),
                  ),
                ),
              ),
              GoRoute(
                path: '/',
                builder: (context, state) => Scaffold(
                  body: Container(
                    margin: EdgeInsets.all(100),
                    child: SizedBox(
                        height: 500,
                        child: Column(children: [
                          InkWell(
                              onTap: () => context.go('/lang'),
                              child: Text("edit".tr()))
                        ])),
                  ),
                ),
              ),
            ],
          ),
          localizationsDelegates: context.localizationDelegates,
          supportedLocales: context.supportedLocales,
          locale: context.locale,
        ),

without go router version, which will not restart the whole app:
MaterialApp(
          localizationsDelegates: context.localizationDelegates,
          supportedLocales: context.supportedLocales,
          locale: context.locale,
          home: Builder(builder: (context) {
            return Scaffold(
              body: Container(
                margin: EdgeInsets.all(100),
                child: SizedBox(
                    height: 500,
                    child: Column(children: [
                      InkWell(
                          onTap: () => Navigator.push(
                              context,
                              MaterialPageRoute(
                                builder: (context) => Scaffold(
                                  body: Container(
                                    margin: EdgeInsets.all(100),
                                    child: SizedBox(
                                        height: 500,
                                        child: Column(children: [
                                          DropdownButton(
                                            value: context.locale.toString(),
                                            items: const [
                                              DropdownMenuItem(
                                                value: "en",
                                                child: Text("English"),
                                              ),
                                              DropdownMenuItem(
                                                value: "zh",
                                                child: Text("繁體中文"),
                                              ),
                                            ],
                                            onChanged: (String? value) async {
                                              if (value != null) {
                                                await context
                                                    .setLocale(Locale(value));
                                              }
                                            },
                                          ),
                                          InkWell(
                                              onTap: () => {},
                                              child: Text("edit".tr()))
                                        ])),
                                  ),
                                ),
                              )),
                          child: Text("edit".tr()))
                    ])),
              ),
            );
          }),
        ),

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.13.9, on macOS 13.2.1 22D68 darwin-arm64, locale en-HK)
    • Flutter version 3.13.9 on channel stable at /Users/bdd001/Documents/Flutter/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision d211f42860 (3 weeks ago), 2023-10-25 13:42:25 -0700
    • Engine revision 0545f8705d
    • Dart version 3.1.5
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2)
    • Android SDK at /Users/bdd001/Library/Android/sdk
    • Platform android-33, build-tools 33.0.2
    • ANDROID_SDK_ROOT = /Users/bdd001/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E222b
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.84.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.76.0

[✓] Connected device (4 available)
    • sdk gphone64 arm64 (mobile) • emulator-5554                        • android-arm64  • Android 13 (API 33) (emulator)
    • iPhone 14 Pro (mobile)      • E949B975-2CBD-494A-BAB3-737285C98801 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-4 (simulator)
    • macOS (desktop)             • macos                                • darwin-arm64   • macOS 13.2.1 22D68 darwin-arm64
    • Chrome (web)                • chrome                               • web-javascript • Google Chrome 119.0.6045.123

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Hi @tong-k-k
Which go_router version are you using? In order to address the issue properly, please provide a completed and minimal reproducible code sample so that we may verify this. Thanks!

Thanks! Could you also check if the issue still persists without using easy_localization package?

Thanks! Could you also check if the issue still persists without using easy_localization package?

Do you mean instead of using easy_localization package, use flutter_localizations and intl to test if it will restart when changing locale?

Right, to make sure the issue is not caused by/related to easy_localization package.

Right, to make sure the issue is not caused by/related to easy_localization package.

Yes the behavior is the same. So it is not related to the easy_localization package.
Please check the sample code below:
with go_router:
sample_with_go_router_intl.zip
without go_router:
sample_without_go_router_intl.zip

Thanks for checking and providing the minimal sample code. I can reproduce this issue as well.

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.16.0, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.16.0 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision db7ef5bf9f (8 hours ago), 2023-11-15 11:25:44 -0800
    • Engine revision 74d16627b9
    • Dart version 3.2.0
    • DevTools version 2.28.2

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.13.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio Giraffe.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[!] Android Studio (version unknown)
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to determine Android Studio version.
    • Java version OpenJDK Runtime Environment (build 17.0.8+0-17.0.8b1000.22-10799086)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.84.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.76.0

[✓] Connected device (3 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D • android-arm64  • Android 11 (API 30)
    • macOS (desktop)  • macos            • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)     • chrome           • web-javascript • Google Chrome 119.0.6045.123

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.17.0-10.0.pre.42, on macOS 14.1 23B74 darwin-x64, locale en-VN)
    • Flutter version 3.17.0-10.0.pre.42 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e9de448420 (2 hours ago), 2023-11-17 02:08:13 +0100
    • Engine revision 5064aeff00
    • Dart version 3.3.0 (build 3.3.0-143.0.dev)
    • DevTools version 2.30.0-dev.4
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.13.0

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio Giraffe.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[!] Android Studio (version unknown)
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to determine Android Studio version.
    • Java version OpenJDK Runtime Environment (build 17.0.8+0-17.0.8b1000.22-10799086)

[✓] Android Studio (version 2022.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • android-studio-dir = /Applications/Android Studio.app/
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b802.4-9586694)

[✓] VS Code (version 1.84.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.76.0

[✓] Connected device (4 available)
    • RMX2001 (mobile) • EUYTFEUSQSRGDA6D                         • android-arm64  • Android 11 (API 30)
    • iPhone (mobile)  • d9a94afe2b649fef56ba0bfeb052f0f2a7dae95e • ios            • iOS 15.7.9 19H365
    • macOS (desktop)  • macos                                    • darwin-x64     • macOS 14.1 23B74 darwin-x64
    • Chrome (web)     • chrome                                   • web-javascript • Google Chrome 119.0.6045.159

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

Try this way, I'm sure you will not face any issues.
class MyApp extends StatelessWidget {
  const MyApp({super.key});

  GoRouter _router = GoRouter(
    routes: [
      GoRoute(
        path: '/lang',
        builder: (context, state) => Scaffold(
          body: Container(
            margin: EdgeInsets.all(100),
            child: SizedBox(
                height: 500,
                child: Column(children: [
                  DropdownButton(
                    value: context.locale.toString(),
                    items: const [
                      DropdownMenuItem(
                        value: "en",
                        child: Text("English"),
                      ),
                      DropdownMenuItem(
                        value: "zh",
                        child: Text("繁體中文"),
                      ),
                    ],
                    onChanged: (String? value) async {
                      if (value != null) {
                        await context.setLocale(Locale(value));
                        //await EasyLocalization.of(context)?.setLocale(Locale(value));
                      }
                    },
                  ),
                  InkWell(onTap: () => {}, child: Text("edit".tr()))
                ])),
          ),
        ),
      ),
      GoRoute(
        path: '/',
        builder: (context, state) => Scaffold(
          body: Container(
            margin: EdgeInsets.all(100),
            child: SizedBox(
                height: 500,
                child: Column(children: [
                  InkWell(
                      onTap: () => context.go('/lang'),
                      child: Text("edit".tr()))
                ])),
          ),
        ),
      ),
    ],
  );

  @override
  Widget build(BuildContext context) {
    return MaterialApp.router(
      routerConfig: _router,
      localizationsDelegates: context.localizationDelegates,
      supportedLocales: context.supportedLocales,
      locale: context.locale,
    );
  }
}

Try this way, I'm sure you will not face any issues.
class MyApp extends StatelessWidget {
  const MyApp({super.key});

  GoRouter _router = GoRouter(
    routes: [
      GoRoute(
        path: '/lang',
        builder: (context, state) => Scaffold(
          body: Container(
            margin: EdgeInsets.all(100),
            child: SizedBox(
                height: 500,
                child: Column(children: [
                  DropdownButton(
                    value: context.locale.toString(),
                    items: const [
                      DropdownMenuItem(
                        value: "en",
                        child: Text("English"),
                      ),
                      DropdownMenuItem(
                        value: "zh",
                        child: Text("繁體中文"),
                      ),
                    ],
                    onChanged: (String? value) async {
                      if (value != null) {
                        await context.setLocale(Locale(value));
                        //await EasyLocalization.of(context)?.setLocale(Locale(value));
                      }
                    },
                  ),
                  InkWell(onTap: () => {}, child: Text("edit".tr()))
                ])),
          ),
        ),
      ),
      GoRoute(
        path: '/',
        builder: (context, state) => Scaffold(
          body: Container(
            margin: EdgeInsets.all(100),
            child: SizedBox(
                height: 500,
                child: Column(children: [
                  InkWell(
                      onTap: () => context.go('/lang'),
                      child: Text("edit".tr()))
                ])),
          ),
        ),
      ),
    ],
  );

  @override
  Widget build(BuildContext context) {
    return MaterialApp.router(
      routerConfig: _router,
      localizationsDelegates: context.localizationDelegates,
      supportedLocales: context.supportedLocales,
      locale: context.locale,
    );
  }
}

Great! It does work!! Thanks for your reply.
But I wonder why it works but mine doesn't.
It seems you just put those router setting in a _router variable before build and put it to routerConfig.
What a magic.
I still think it is a bug, right?

Yes. You can try with below code if it works,
class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp.router(
      routerConfig: AppRouter.instance.router,
      localizationsDelegates: context.localizationDelegates,
      supportedLocales: context.supportedLocales,
      locale: context.locale,
    );
  }
}

class AppRouter {
  AppRouter._();

  static final _instance = AppRouter._();

  static AppRouter get instance => _instance;

  GoRouter get router => _router;

  late final GoRouter _router = GoRouter(
    routes: [
      GoRoute(
        path: '/lang',
        builder: (context, state) => Scaffold(
          body: Container(
            margin: EdgeInsets.all(100),
            child: SizedBox(
                height: 500,
                child: Column(children: [
                  DropdownButton(
                    value: context.locale.toString(),
                    items: const [
                      DropdownMenuItem(
                        value: "en",
                        child: Text("English"),
                      ),
                      DropdownMenuItem(
                        value: "zh",
                        child: Text("繁體中文"),
                      ),
                    ],
                    onChanged: (String? value) async {
                      if (value != null) {
                        await context.setLocale(Locale(value));
                        //await EasyLocalization.of(context)?.setLocale(Locale(value));
                      }
                    },
                  ),
                  InkWell(onTap: () => {}, child: Text("edit".tr()))
                ])),
          ),
        ),
      ),
      GoRoute(
        path: '/',
        builder: (context, state) => Scaffold(
          body: Container(
            margin: EdgeInsets.all(100),
            child: SizedBox(
                height: 500,
                child: Column(children: [
                  InkWell(
                      onTap: () => context.go('/lang'),
                      child: Text("edit".tr()))
                ])),
          ),
        ),
      ),
    ],
  );
}

This is WAI. We have another issue to try to avoid this problem https://github.com/flutter/flutter/issues/127206


onTapGesture

I have a Markdown view in my project and would like to switch to an editing mode when you click on it, but onTapGesture is not getting called when I click on the rendered view.
Is there another way of achieving this?

Could you please try if you can reproduce this issue in the latest release?
https://github.com/gonzalezreal/swift-markdown-ui/releases/tag/2.0
If this is still the case, please let me know. Otherwise, I'd appreciate if you close this issue.

thank you, works perfectly now!


Restructuring into Python module layout

Reorganizes the code into bocs_control (containing the Python control code structured as a package) and bin (containing entry points). Technically archive.py and control.py are also entry points into the program and could thus placed in bin, but currently the 2 shell scripts are used instead.
Closes #16

If the shell scripts don't add any value, they can be removed.

I don't think it makes a big difference either way. I quite like having the executables as shell scripts, it makes it a little more obvious to me where the entry points are and it's cleaner setting up the logs and redirecting program output in bash than in Python IMO.


add django-dotenv, and compensate for the removal of drama-free-django runtime features

These changes compensate for the removal of the "runtime" customizations in Drama Free Django, proposed here. This means that cfgov-refresh needs to do a little more work:

dfd will no longer populate environment variables from a JSON file. To deal with that, this PR adds django-dotenv
dfd will no longer add 'static.in' subdirectories to the STATICFILES_DIRS list, so that functionality has been added to cfgov.settings.base, triggered by a 'DJANGO_STATICFILES_IN' environment variable. You can see that in action in docker/drama-free-django/_build.sh
the scripts in  docker/drama-free-django/ have been adapted to these changes.

Additions

django-dotenv
DJANGO_STATICFILES_IN functionality in cfgov.settings.base

Testing

docker/drama-free-django/build.sh && docker/drama-free-django/test.sh should work as expected

Todos

[ ] Merge https://github.com/cfpb/drama-free-django/pull/25
[ ] docker/drama-free-django/_build.sh  is currently set to install drama-free-django's magic-removal-branch. That should be fixed before merging.
[ ] The ansible side of this effort is not quite done yet.

Checklist

[ ] PR has an informative and human-readable title
[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the CFPB development guidelines
[ ] Passes all existing automated tests
[ ] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future todos are captured in comments
[ ] Visually tested in supported browsers and devices (see checklist below :point_down:)
[ ] Project documentation has been updated
[ ] Reviewers requested with the Reviewers tool :arrow_right:

Testing checklist
Browsers

[ ] Chrome on desktop
[ ] Firefox
[ ] Safari on macOS
[ ] Edge
[ ] Internet Explorer 9, 10, and 11
[ ] Safari on iOS
[ ] Chrome on Android

Accessibility

[ ] Keyboard friendly
[ ] Screen reader friendly

Other

[ ] Is useable without CSS
[ ] Is useable without JS
[ ] Flexible from small to large screens
[ ] No linting errors or warnings
[ ] JavaScript tests are passing

I note your comment:

The ansible side of this effort is not quite done yet.

Would it make sense to push back loading of .env and instead alter this PR to load from environment.json, essentially pulling in this code from DFD?
This would accomplish "stop using DFD at runtime" and allow us to proceed more incrementally, working as-is with the current Ansible code that generates environment.json files. In a subsequent PR (or multiple PRs) we could then further alter cfgov-refresh and the Ansible code to instead generate .env files.

This would accomplish "stop using DFD at runtime" and allow us to proceed more incrementally, working as-is with the current Ansible code that generates environment.json files. In a subsequent PR (or multiple PRs) we could then further alter cfgov-refresh and the Ansible code to instead generate .env files.

That's an interesting idea-- I've been pondering a different approach to breaking the dependencies (having ansible deploy both the json and the .env)-- but since this exists now and the ansible changes don't yet, your approach makes more sense.

@chosak I just pushed an implementation of that

@rosskarchner, thanks, I'll take another look at this PR.
One thing: don't we need to make at least some Ansible changes before this can go live, e.g. setting the DJANGO_STATIC_ROOT environment variable to the right location?

@chosak what do you think about changing this default, which I don't think we actually use anywhere (outside of Docker experiments, maybe) https://github.com/cfpb/cfgov-refresh/blob/master/cfgov/cfgov/settings/base.py#L244

@rosskarchner that seems sensible to me, you mean, to /srv/cfgov/static? That seems like it'd be good to add to this PR.

Yeah, that's what I meant

One other thought about this PR: if you were to remove these changes in _build.sh, and these changes in _test.sh, could this PR be merged as-is and have things continue to work using the existing master version of drama-free-django?
Essentially, the variables would get loaded again, with no change. That'd let us move ahead with this change even while the DFD changes are still under review.
Another thing: the docs [currently suggest using autoenv to load the variables, here and here. Can we change that if we want to move to auto-loading?

This is only an annoyance but it sure feels like it could be a real annoyance for people running management commands constantly. Is there anything we can do about this?

Do you know what that's for?
We could:

find a way to eliminate that logic -- django-dotenv doesn't interpret bash files, it expects every line to just be a variable.
preprocess the .env file, reading it into memory, stripping out the invalid lines, and then using parse_dotenv instead of read_dotenv.

Do you know what that's for?

Yes. It's because when running using a local virtualenv, the database host and Elasticsearch host are both localhost, but in the existing docker-compose setup, these are postgres and elasticsearch, respectively. Perhaps there's some better way of eliminating that logic, like defaulting them to localhost but letting docker-compose override them?

Those commands (specifically activate-virtualenv.sh) could just be moved into a separate file that gets invoked. .env was just being overloaded and I agree that it's probably better to keep it as a pure envvar file.
Also the lines at the bottom of a file are overrides for local development. Seems like those could be made the default and a modified envvar file could be injected during deploy. (or they could just be included in the separate script that runs activate-virtualenv)

One other thought about this PR: if you were to remove these changes in _build.sh, and these changes in _test.sh, could this PR be merged as-is and have things continue to work using the existing master version of drama-free-django?
Essentially, the variables would get loaded again, with no change. That'd let us move ahead with this change even while the DFD changes are still under review.

One wrinkle:  these changes don't help with /venv/bin/django-admin collectstatic
That's kind of the reason my initial inclination was a seperate DFD pull request, just for adding the manage.py wrapper (that PR would need to be updated to use the runpy.run_path approach)

Another thing: the docs [currently suggest using autoenv to load the variables, here and here. Can we change that if we want to move to auto-loading?

I think so?

One wrinkle: these changes don't help with /venv/bin/django-admin collectstatic

Hm. Well, frankly, the original thought behind adding the collectstatic call to _test.sh was because I wanted to test collectstatic on Travis (#5110). But because of some bugginess of that approach, and a hesitancy to add it as a potential blocker to all cfgov-refresh PRs, that got rolled back (#5119). So that code isn't being invoked by anything right now.
So if it would make things simpler to just remove that call to collectstatic, maybe just for now, we could just do that here. I'll also take a look at your open DFD PR as well, of course.

While chipping away at getting this working under mod_wsgi, I discovered that variables set via Apache's SetEnv were not available to the wsgi.py script.  After tinkering with some work-arounds, I decide that a simpler solution was to just add a new, production WSGI file, that unambiguously sets DJANGO_SETTINGS_MODULE to cfgov.settings.production.  Deployment will need to be updated to use cfgov/cfgov/production_wsgi.py. We are already working on changing that, since DFD will no longer include the current /current/wsgi.py


Add a parameter to the MSBuild Copy task for recursive copying

Currently one has to use this idiom (http://blogs.msdn.com/b/msbuild/archive/2005/11/07/490068.aspx) to recursively copy. Without resorting to invoking robocopy or other platform specific commands.
The Copy task should have a RecursiveCopy parameter to enable this behaviour.

A difficulty here is that Copy currently only accepts a list of files (well, ITaskItem, but it's assumed they're all files) as its input.  A recursive option would require directory inputs.
Additionally, this would make it even more difficult to construct incrementality around a Copy task.  As is, you can define a list of items and a list of destinations outside a <Target>, then use them as Inputs and Outputs for that target.  That wouldn't work with a recursive copy, because we wouldn't be able to know what the outputs should be outside of the Copy task itself.

Incrementality might be cheaply provided by the SkipUnchangedFiles flag in this line: https://github.com/Microsoft/msbuild/blob/xplat/src/XMakeTasks/Copy.cs#L551
In case of a recursive copy (maybe passed in as a new task parameter) the code that calls DoCopyIfNecessary would need to first compute the recursive sourceFile / destinationFile pairs and then let DoCopyIfNecessary copy them if necessary.


Where For Dinner Spring Boot 3.1.x

This enhancement will update all Spring based Where For Dinner components from Spring Boot 3.0.x to 3.1.x.

Resoved with PR #324


VSCode opens 7 windows on startup

Does this issue occur when all extensions are disabled?: Yes, before extensions even load

VS Code Version:
OS Version: umbuntu 22.04 raspi 400

Steps to Reproduce:

use and install code server?
launch VSCode (codium build)
5 to 10 windows open
z

first 10 seconds is me actualy showing it, last is me desperately trying to kill vscode
Screencast from 10-20-2022 05:52:23 PM.webm

https://github.com/VSCodium/vscodium

codium is a build of codium.
from the readme
This is not a fork. This is a repository of scripts to automatically build Microsoft's vscode repository into freely-licensed binaries with a community-driven default configuration.

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

I will try to

Thanks

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


AEROGEAR-3564 - use #nochrome link to hide navbar on docs

See also: https://github.com/aerogear/antora-ui/pull/13

@jasonmadigan I don't see any difference in the running application after applying the change.
Here is how it appears on iOS (same on android):

.

@ziccardi sorry, should've mentioned - waiting for https://github.com/aerogear/antora-ui/pull/11 to be deployed to docs.aerogear.org - change will become visible then (I hope!)

@laurafitzgerald @ziccardi  changes enabling this to be tested in aerogear/antora-ui#13 have been landed. Should be OK to do a quick test now?

@ziccardi thanks for checking. were you able to check them all? The sso one was causing some problem earlier

@laurafitzgerald : my local branch still had the old changes with nochrome. I made another check. The SSO page starts like on the footer:

@ziccardi I ran this PR locally and it works for me. Do you mind checking it again?


Emitter plugins

formatters not converted to plugins for simplicity
could not get the following test to work test_emitter.py : test_emitter_failed_emit()

Current coverage is 89.25% (diff: 93.44%)

Merging #221 into master will increase coverage by 0.63%

@@             master       #221   diff @@
==========================================
  Files            87         88     +1
  Lines          3208       3248    +40
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           2843       2899    +56
+ Misses          365        349    -16
  Partials          0          0

Powered by Codecov. Last update 4114dec...04ed268


Add Cyber Courses School

Hi @florianamette,
I am sorry, I have to close the request without merging, because this organization is a training center, not a college, nor a university. Please ensure that you are familiar with this repository rules located at the bottom of this page.
Please apply for an appropriate licensing option (which may also be free) at https://www.jetbrains.com/community/education/#courses.
Thank you for your understanding!


Add logging

face-mask-detector should have logging capabilities.
I think command_line_interface.py should configure the logger with a given log level (via the verbose argument) and the rest of the library should use the logger.

This may be useful.


feat: Add possibility to define custom response header

Closes #10
This can be configured globally via the new setting in .env.

Coverage remained the same at 100.0% when pulling 1e9a48f7bfda5140e4424f29947ae4635ac947bc on custom-header into 443b018cf4a6db7395108814680f0b60e33a7539 on master.

Coverage remained the same at 100.0% when pulling 1e9a48f7bfda5140e4424f29947ae4635ac947bc on custom-header into 443b018cf4a6db7395108814680f0b60e33a7539 on master.


fix: vendir sync --directory option error

Fixes #277

LGTM

@fritzduchardt looks like a test is failing, also, there are some conflicts. Do you mind checking that?

@fritzduchardt looks like a test is failing, also, there are some conflicts. Do you mind checking that?

Finally got that fixed. It was harder than expected, since the staging to final location copy logic was being affected.
Previously, the logic for dir-options rewrote the structure of vendir.yml. The staging copy logic relied on this new structure. I took out the structure rewrite, because thanks to my fix, the lock file is now written, even if sync is called with dir-options and we don't want its structure to deviate from the structure of vendir.yml.

@joaopapereira please have another look

We are in a good spot, but I will let @kumaritanushree review it.
The only ask for you @fritzduchardt is to get the commits signed so we can get rid of the failing DCO check

We are in a good spot, but I will let @kumaritanushree review it. The only ask for you @fritzduchardt is to get the commits signed so we can get rid of the failing DCO check

@joaopapereira I squashed them and signed them. Please have another look.


Tilt time is not appropriate

One time for the gradual change of the steps does not apply to me.
I determined the following values for my external venetian blinds.
kitchen 1
Drive up time: 31000ms
Drive down time: 30700ms
Steps up: 313
Steps down: 320
kitchen 2
Drive up time: 39000ms
Drive down time: 38200ms
Steps up: 397
Steps down: 408
Probably there is a better way to for configuration of the steps?

Unfortunately I can't say for sure. I can only say that there are 2 outdoor venetian blinds from the same manufacturer. However, there are 7 years between installations of these 2.
If relevant I could try to get to the motors?
What I also asked myself: The tilting movement is made with the up and down movement. What is my problem if I always see 0%? (Did I choose the wrong type?)

I made another video and sent it to you via PM.
I only know the tilt function in our area and there it is always the same.
The angle is adjusted with the up or down movement. When you go down, the slats close, when you go up, the slats open. It doesn't matter in which position. You can move up and down or make a step up or down...

I am finishing off the integrated tilt function.  I'll let you know when it is complete.  After that I will expand the internal percentages to accommodate your nudge function.  Right now there are more steps than can be represented by an integer percentage.

Install firmware v1.5.0 and the associated application file.  Then change the shade configuration to use Integrated as the tilt type.

With v1.5.2 it is now correct. Thx.