Doesn't work on ipad version 5 and below. Throws error "o.document.elementsFromPoint is not a function"

I use latesе version of react-dnd with touch backend. On ipad 6th onwards I have no issues, but starting from ipad 5 and below, I am having following error: "TypeError: o.document.elementsFromPoint is not a function. (In 'o.document.elementsFromPoint(l.x,l.y)', 'o.document.elementsFromPoint' is undefined)".
iOS installed on ipad is 11. The same one installed on iPad 6, but there it works, as I've mentioned before. App was tested in browserstack and on real devices.
Screenshot of the error from browserstack: https://prnt.sc/qf85gw

I've been seeing the same issue and have been digging a little. here is my findings:

I could replicate the issue in the simulator for "iPad (5th generation) (10.3.1)". If I run my application in production mode (built with webpack) I can't drag. But if I run it in development mode (webpack dev server) I can drag. Can't figure out why it differs.

If i downgrade react-dnd-touch-backend to 0.8.3 it works in both development and production mode.

If I keep 10.0.2 of react-dnd-touch-backend but add polyfill-elements-from-point it works in both development and production mode.


Add og and twitter meta tags

Following the forum feedback.

Fantastic addition! 🎉

Well, not so fantastic :( Apparently Twitter requires an absolute URL for the meta image tag. Have sent another PR along.


use wildcards in search filters

I'm currently evaluating if I can replace my current Elasticsearch setup with Meilisearch. One thing that came up is using wildcards in search filters, which i think is not possible currently. I need something like this:
$ curl --get 'http://localhost:7700/indexes/movies/search' \
    --data-urlencode 'q=Batman' \
    --data-urlencode 'filters=director = Tim*'

I guess this is not possible for performance reasons, but this is a blocker for my usecase. Also facets will not help here I think.
Is there any way to implement something like this or is it on the roadmap?
Thanks for the awesome work!
Hannes

Hello @toxsick !
#610 proposed to do that, we put it on hold for know, for performance reasons. We may reconsider in the future, if it registers enough interest :)

Hey @MarinPostma, thanks for the info, didn't see that one.
@Kerollmops mentioned in #610 that the upcomming "facetted searching (aggregations)" could solve this use case, but I don't understand how facets would help here, because i want to match dynamic portions of an attribute (e.g. filters=director = Tim* should match Tim Burton and Tim Cook).

@toxsick I think he had categorical filtering in mind, and faceting is a better fit for such use cases

Ok so #610 would be very interesting for me. I gave it a +1
Thanks for the info and I hope you guys reconsider this.
regards

Wild card is also usefule if you have tree-like structure (e.g. file system) and each document have path property so to search for items in folder /var/log  we could provide wildcard '/var/log*' for path property. Or may be there is some other way to handle such issue?

Hello, Thanks for this feature proposal!
I will close this issue in favor of our public roadmap.
At first glance, it would not seem to be the same thing, but in fact, to be able to search in the facet values, you have to allow the engine to index, like the searched text, the facet values, and search (with typo and search prefix) in it. This will result in the facets being matched by prefix rather than by exact match.
I invite everyone interested in this feature to update it on the roadmap.

Actually not facet is not user generated data and things like typo etc is not really needed for facets. Only full and exact match by wildcard

Sorry guys, maybe I don't get faceted search fully, but as I understand facets, they will by design not support something like wildcard filtering, because they are created when an item is indexed right?
I have a use case where I have items with all kinds of different (technical) attributes and I want to query (simplified):
$ curl --get 'http://localhost:7700/indexes/servers/search' \
    --data-urlencode 'filters=ip = 192.168*'

Not all items in the index will even have the attribute ip. Facets will not help here right? I understand that what I try to do will have a big performance impact, because indexes can only be matched partially. But I guess in my case I need that flexibility :)
regards and thx

Thanks, @quanterion, @toxsick,
I have updated my previous message with an feature that better fits.


Add to blueprinting-tips

@aledsage Looks good. Duncan's comments worth addressing.

Thanks @drigodwin @sjcorbett - I've incorporated those changes. Merging now.


Notify users when we remove them from the GitHub org

User Need
As a GitHub User
I want an email notification when I am remove from the GitHub orgs
so that I know if I have been removed and so that I know how to rejoin is required.
Value
This notification offers a nicer user experience that the default removal message. It also allows to to minimise support requests by providing users with additional information
Functional Requirements (What):

[ ] User is sent a Gov.uk Notify email message when remove from a GitHub Org.

Non-Functional Requirements (How):

Repurpose existing notify service for dormant users
Message needs to explain why the user has been removed (not specific but just that we have not identified any activity on the org for x period of time.
Message needs to include SSO links to rejoin org
Is user was not using SSO before we should include information/waning about needing to re-authenticate tokens/keys

Acceptance Criteria:

[  ] We have a notification process in place.

Risks and Mitigation (Optional):

There is a risk that users will just rejoin the org, but we will start collecting data on rejoiners so that we can access the impact of this and further understand any residual risk
Users rejoining org via SSO may have to reauth tokens/keys - Mitigate by including instructions/warning in Notify message

It's possible to send an email to a list of users directly from the Notify panel.
As this is a temporary measure anyway, I suggest we use this approach instead of building a solution in code.


fix news slider ul loading issue

Fix #112
Test URLs:

Before: https://main--channelco-crn-com--hlxsites.hlx.page/
After: https://issue-112--channelco-crn-com--hlxsites.hlx.page/

@mfrisbey I remember you moved this newslider  earlier into the universal template for a reason (I can't recall why right now). @samuelopra now wants to move it back outside the universal template now and with this new change, I dont see the flickering happening on this block

@kunwarsaluja I probably moved it because it was causing CLS, so it needed to load earlier. If moving it back fixes the <ul> issue and still doesn't cause CLS, that's totally fine.


When auto eject is set to true and twemproxy reconnects it needs to do hostname resolution

Problem: Twemproxy does not do a host name resolution when it reconnects to a server. The reason for this is, it does cache the IP address which is resolved at start up time.
We have a cluster setup with sharding enabled. So we have a virtual IP  configured in the twemproxy configuration, where it maps to two servers. So when one goes down, we would like to connect to the other one and for this to happen, when twemproxy reconnects it needs to resolve the hostname.

It looks like this never got finished. I can see a PR https://github.com/twitter/twemproxy/pull/177 that looks like it's abandoned. This feature would be quite useful for us - is there any appetite for resurrecting it?

Fixed with https://github.com/twitter/twemproxy/commit/fd34c29bb69861b37eea786bd84a7e437ab8bb7c
Detail here: https://github.com/twitter/twemproxy/issues/355#issuecomment-113575050


Version compatibility

Hey Peter,
Would it be possible to list the version of UE4 that the Local Simulation plugin was built with?
I have it running in 4.16.3 but people looking over the readme may not know.
Just a thought.
HeadClot

Hi HeadClot,
I've included the version that this plugin has been built with in the ReadMe. Thanks for pointing this out! Sorry for the delayed response!
I'm going to close this and assume this answers your questions.
Thanks,
Peter

Thanks :)


Lightning add local backend

This local backend allow user to use Lightning independent without Importer.
After https://github.com/tikv/tikv/pull/7459 finished, Lightning has the ability to write to TiKV alone.
we have follow things to do:

[x] add local backend for lightning
[ ] optimize local backend performance
[ ] add test plan for local backend
[ ] update related docs

@glorv Please update the issue, thanks!

@3pointer  @kennytm shall we mark this issue as finished?


Log in as root

Currently, the checkup creates a cloud-user user using cloud-init, and logs in to the VM using its credentials.
Immediately after logging in, the checkup issues the sudo su command, thus effectively running as the root user.
Logging in as root simplifies the login operation, and remove problems that can occur when certain assumptions are made when performing the sudo su step - for example:

Not expecting the sudo warning message
Not expecting to enter the user's password again.

Also remove the creation of cloud-user volume, since it is no longer needed.
Based on work done in https://github.com/kiagnose/kubevirt-dpdk-checkup/pull/225.

Tested against an OpenShift Virtualization 4.15 cluster.


include .mtl and textures in node js?

Hey, I want to convert obj to glb, i am using node. How to do I include .mtl and textures?

.mtl and textures are handled automatically as long as the paths in the .obj / .mtl are correct.
E.g. in the .obj there should be mtllib like https://github.com/CesiumGS/obj2gltf/blob/b135598dd8896c94418a5503ae0211c74c1fb5e3/specs/data/box-textured/box-textured.obj#L3
And in the .mtl there should be texture paths like https://github.com/CesiumGS/obj2gltf/blob/b135598dd8896c94418a5503ae0211c74c1fb5e3/specs/data/box-textured/box-textured.mtl#L13


feat: config AUTHENTICATION_BACKENDS to use PrefixedUserAuthBackend

AAP-30375: Configure EDA to authenticate prefixed usernames

@AlanCoding please review

It is agreed that this PR should be merged into main per the discussion at https://redhat-internal.slack.com/archives/C053CJ4JFP1/p1726180638452939. It becomes a blocker for https://github.com/ansible/aap-gateway/pull/545.


--fixed generation of template key under Windows(due to different pat…

…h separator, now key seperator is always /)

Sorry I couldn't wait for this PR.


docs: update docs after release

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.142%

Totals

Change from base Build<PHONE_NUMBER>:
0%

Covered Lines:
3980

Relevant Lines:
4476

💛  - Coveralls


[HOLD for payment 2022-05-20] [$500] Remove Send Money when no members in room - reported by  @thesahindia

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Create a workspace
Visit the Announce or Admins room of that policy ( it shouldn't have any other member except you )
Tap on :heavy_plus_sign: (on left side, near the composer)
Select send money/request money

Expected Result:
It shouldn't show option to send money/ request money
Actual Result:
It's showing the option and user is able to go through the flow and get error in the end as the user is trying to request/send money to himself
Workaround:
unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.46-3
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43995119/160736636-7f95aa72-9ea4-4a12-a62c-7c43388b9bb0.mov
Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1647460332448239
View all open jobs on GitHub

I agree that we shouldn't error out when this happens, but perhaps instead of completely removing the option we keep it and direct people to invite someone to the room instead.

Agreed with @tjferriss solution above.

Posted in Upwork!
Internal Job - https://www.upwork.com/ab/applicants/1509813441766039552/job-details
External job - https://www.upwork.com/jobs/~0176081f4f95677487

Proposal
Base on https://github.com/Expensify/App/issues/8357#issuecomment-1083753541
We only need to check the chatType is POLICY_ANNOUNCE or POLICY_ADMINS. If either both return participants to empty array. In this way IOUModal will have participants page.
https://github.com/Expensify/App/blob/50496a0a0d7dd283f9936988cda95abf69741342/src/pages/iou/IOUModal.js#L110
-        const participants = lodashGet(props, 'report.participants', []);

+        const chatType = lodashGet(props, 'report.chatType');
+        const participants = [CONST.REPORT.CHAT_TYPE.POLICY_ADMINS, CONST.REPORT.CHAT_TYPE.POLICY_ANNOUNCE].includes(chatType) ? [] : lodashGet(props, 'report.participants', []);

If I'm not wrong IOUModal will add Steps.IOUParticipants if participants are empty.
https://github.com/Expensify/App/blob/50496a0a0d7dd283f9936988cda95abf69741342/src/pages/iou/IOUModal.js#L131-L137

https://user-images.githubusercontent.com/25520267/161304121-f764a27a-6759-4408-bc6e-243516fa89b0.mov

@tjferriss or @danieldoglas Is this the expected OP here?
https://github.com/Expensify/App/issues/8357#issuecomment-1086113910

@iwiznia can we get what is the expected OP here?

Sorry, I didn't see the tagging here before.
I think the behavior we expect is to actually remove the "Send Money"/"Request Money" options in the menu in case there's no one in the chat with the user, not giving him the option to ask for anyone else, since the "+" in the chat is related to tasks on that chat.

Thanks, @danieldoglas.
But I am confused here, you have agreed with  @tjferriss solution in https://github.com/Expensify/App/issues/8357#issuecomment-1084935322
and the above comment adds the negates it.
Is this expected OP or just remove the option if there are no users to chat. Thanks!

@Santhosh-Sellavel
Yes, you are right. My mistake.
We should aim to do what was suggested by @tjferriss. But then I think the solution is not actually inviting people into the room as suggested, it is actually letting me send/request money to people outside of that room.

Thanks, @danieldoglas.

actually letting me send/request money to people outside of that room.

It would create some complications/confusion. Because whatever IOU operation we perform from the chat compose ➕  options is expected to create IOU for the specific chat report.
I think we should just hide those options instead because the user can always create IOU from LHN ➕ button.
@iwiznia What do you think?

I'm going to be ooo until April 26th so I'm going to assign a new CM to this issue.

Sorry, I was out for a few days. I agree with removing the option altogether when there are no participants other than you, but I don't think we should hack the participants like suggested here.

Sorry, I was out for a few days. I agree with removing the option altogether when there are no participants other than you, but I don't think we should hack the participants like suggested here.

@iwiznia what do you think of my proposal :https://github.com/Expensify/App/issues/8357#issuecomment-1085871230 ?

Is this the expected behavior?
When there's no one in the room (except myself)
https://user-images.githubusercontent.com/25520267/163832224-9d0be678-c6a5-470a-a926-2d5860ff9aa9.mov
When there are members in the room
https://user-images.githubusercontent.com/25520267/163832251-5a4f7554-b8de-4eb6-bae8-97965d0a6393.mov

If so, it could be done by changing the condition when showing the option (split bill, request money, send money) when there are members in the room and show nothing when there's only you in the room.
https://github.com/Expensify/App/blob/6c53be1ea7a022e8a5e788cc7e7efd62c4573474/src/pages/home/report/ReportActionCompose.js#L452-L489
                                                    ...(!hasExcludedIOUEmails && Permissions.canUseIOU(this.props.betas) && hasMultipleParticipants ? [
                                                        {
                                                            icon: Expensicons.Receipt,
                                                            text: this.props.translate('iou.splitBill'),
                                                            onSelected: () => {
                                                                Navigation.navigate(
                                                                    ROUTES.getIouSplitRoute(
                                                                        this.props.reportID,
                                                                    ),
                                                                );
                                                            },
                                                        },
                                                        {
                                                            icon: Expensicons.MoneyCircle,
                                                            text: this.props.translate('iou.requestMoney'),
                                                            onSelected: () => {
                                                                Navigation.navigate(
                                                                    ROUTES.getIouRequestRoute(
                                                                        this.props.reportID,
                                                                    ),
                                                                );
                                                            },
                                                        },
                                                        {
                                                            icon: Expensicons.Send,
                                                            text: this.props.translate('iou.sendMoney'),
                                                            onSelected: () => {
                                                                Navigation.navigate(
                                                                    ROUTES.getIOUSendRoute(
                                                                        this.props.reportID,
                                                                    ),
                                                                );
                                                            },
                                                        },
                                                    ] : []),

cc @iwiznia @danieldoglas  @Santhosh-Sellavel

Btw I cannot send/request money in the room even where there are members inside. Is this the expected behavior?

Proposal
We need to change the condition when showing send/request money option. I think we only need to show both options for the non-admin/announce room.
https://github.com/Expensify/App/blob/6c53be1ea7a022e8a5e788cc7e7efd62c4573474/src/pages/home/report/ReportActionCompose.js#L452-L489
change with
        const isAdminOrAnnounceRoom = ReportUtils.isAdminRoom(this.props.report) || ReportUtils.isAnnounceRoom(this.props.report);

                                                    ...(!hasExcludedIOUEmails
                                                        && Permissions.canUseIOU(this.props.betas) && hasMultipleParticipants ? [
                                                            {
                                                                icon: Expensicons.Receipt,
                                                                text: this.props.translate('iou.splitBill'),
                                                                onSelected: () => {
                                                                    Navigation.navigate(
                                                                        ROUTES.getIouSplitRoute(
                                                                            this.props.reportID,
                                                                        ),
                                                                    );
                                                                },
                                                            },
                                                        ] : []),
                                                    ...(!hasExcludedIOUEmails && Permissions.canUseIOU(this.props.betas) && !hasMultipleParticipants && !isAdminOrAnnounceRoom ? [
                                                        {
                                                            icon: Expensicons.MoneyCircle,
                                                            text: this.props.translate('iou.requestMoney'),
                                                            onSelected: () => {
                                                                Navigation.navigate(
                                                                    ROUTES.getIouRequestRoute(
                                                                        this.props.reportID,
                                                                    ),
                                                                );
                                                            },
                                                        },
                                                    ] : []),
                                                    ...(!hasExcludedIOUEmails && Permissions.canUseIOUSend(this.props.betas) && !hasMultipleParticipants && !isAdminOrAnnounceRoom ? [
                                                        {
                                                            icon: Expensicons.Send,
                                                            text: this.props.translate('iou.sendMoney'),
                                                            onSelected: () => {
                                                                Navigation.navigate(
                                                                    ROUTES.getIOUSendRoute(
                                                                        this.props.reportID,
                                                                    ),
                                                                );
                                                            },
                                                        },
                                                    ] : []),

Result
https://user-images.githubusercontent.com/25520267/163843642-6fc636e0-8388-4095-846a-98ac09da6d4d.mov

Doubled the job price!

Proposal
First of all, we need to make sure that the hasMultipleParticipants variable has an accurate value. The reportParticipants variable contains the logged in user for admins and announce channels but ignores them for single or group channels.
The hasMultipleParticipants variable is thus changed from:
https://github.com/Expensify/App/blob/8fda329c92559737d8040da5ab5eb01fd7b18d26/src/pages/home/report/ReportActionCompose.js#L395
to
https://github.com/allroundexperts/Expensify/blob/199033cbb626550aa5690b580709a945712526cd/src/pages/home/report/ReportActionCompose.js#L395
The condition which checks for the menu items to display also seems to be using hasMultipleParticipants in a wrong way. It was also changed from:
https://github.com/Expensify/App/blob/8fda329c92559737d8040da5ab5eb01fd7b18d26/src/pages/home/report/ReportActionCompose.js#L452-L489
to
https://github.com/allroundexperts/Expensify/blob/199033cbb626550aa5690b580709a945712526cd/src/pages/home/report/ReportActionCompose.js#L452-L489
Result
https://user-images.githubusercontent.com/30054992/164551053-b4823f60-0832-497c-aade-3055499f32fb.mp4

Proposal:
Since reportParticipants includes logged in user in chat room but not in one-to-one or group chats. So, we must exclude logged in user from the reportParticipants while taking length.
There are three different conditions.

length < 1 -> show Nothing
length === 1 -> show Send Money and Request Money Options
length > 1 -> show Split bill

To implement this, we should make use of two different variables: showSplitBill or hasMultipleParticipants and showSendRequestMoney.
https://github.com/Expensify/App/blob/32d8f0261b825cb6e47e441b9cf08400340a164e/src/pages/home/report/ReportActionCompose.js#L395
        const hasMultipleParticipants = _.filter(reportParticipants, email => this.props.myPersonalDetails.login !== email).length > 1;
        const showSendRequestMoney = _.filter(reportParticipants, email => this.props.myPersonalDetails.login !== email).length === 1;

We can use these two variables hasMultipleParticipants and showSendRequestMoney to determine which items to be included in menuItems.
https://github.com/Expensify/App/blob/32d8f0261b825cb6e47e441b9cf08400340a164e/src/pages/home/report/ReportActionCompose.js#L451-L489
menuItems={[
    ...(!hasExcludedIOUEmails
+        && Permissions.canUseIOU(this.props.betas) &&
+       hasMultipleParticipants ? [
+            {
                icon: Expensicons.Receipt,
                text: this.props.translate('iou.splitBill'),
                onSelected: () => {
                    Navigation.navigate(
                        ROUTES.getIouSplitRoute(
                            this.props.reportID,
                        ),
                    );
                },
+            },
+        ]: []),
+    ...(!hasExcludedIOUEmails && Permissions.canUseIOUSend(this.props.betas) && showSendRequestMoney ? [
+        {
            icon: Expensicons.MoneyCircle,
            text: this.props.translate('iou.requestMoney'),
            onSelected: () => {
                Navigation.navigate(
                    ROUTES.getIouRequestRoute(
                        this.props.reportID,
                    ),
                );
            },
        },
        {
            icon: Expensicons.Send,
            text: this.props.translate('iou.sendMoney'),
            onSelected: () => {
                Navigation.navigate(
                    ROUTES.getIOUSendRoute(
                        this.props.reportID,
                    ),
                );
            },
        },
    ] : []),

Will get to proposals by Monday!
@sobitneupane

I think most of us are not clear about the expected output.

Then you should straight away ask questions to clarify things. So we could get this solved sooner.

@sobitneupane
I think this is the expected output,

Option 1:
Show Send Money and Request Money Options if there is a participant other than the logged in User and Show Split Bill Option if there are more than one participants other than the logged in User. In this case, even rooms with a participant other than the logged-in user will have Send Money and Request Money options.

@iwiznia Can you confirm this?
If this is the expected, I see a few proposals but all look similar & partial solutions.

@iwiznia Can you confirm this?

Yes that sounds good, but not sure if we should show the options in places like the admins room

At present, Send Money and Request Money option is only present for one-to-one chats. Split Bill option is shown even for chat rooms having one participant other than the logged in user. Do we want to show Send Money and Request Money option in the chat room having one participant other than the logged in user? I think we are intentionally showing only split bill option in all the chat rooms.

Do we want to show Send Money and Request Money option in the chat room having one participant other than the logged in user? Do we want to show Send Money and Request Money option in the chat room having one participant other than the logged in user?

Honestly, I don't know, but since this is only about not showing send money when there are no other participants, let's leave all the other behavior untouched

In that case this should do the job.

Option 2 Proposal:
https://github.com/Expensify/App/blob/32d8f0261b825cb6e47e441b9cf08400340a164e/src/pages/home/report/ReportActionCompose.js#L451-L489
menuItems={[
  ...(!hasExcludedIOUEmails
      && Permissions.canUseIOU(this.props.betas)
      && hasMultipleParticipants
      ? [{
          icon: Expensicons.Receipt,
          text: this.props.translate('iou.splitBill'),
          onSelected: () => {
              Navigation.navigate(
                  ROUTES.getIouSplitRoute(
                      this.props.reportID,
                  ),
              );
          },
      }] : []),
  ...(!hasExcludedIOUEmails
      && Permissions.canUseIOU(this.props.betas)
      && !hasMultipleParticipants
      && !ReportUtils.isChatRoom(this.props.report)
      ? [{
          icon: Expensicons.MoneyCircle,
          text: this.props.translate('iou.requestMoney'),
          onSelected: () => {
              Navigation.navigate(
                  ROUTES.getIouRequestRoute(
                      this.props.reportID,
                  ),
              );
          },
      }] : []),
  ...(!hasExcludedIOUEmails && Permissions.canUseIOUSend(this.props.betas) && !hasMultipleParticipants
      && !ReportUtils.isChatRoom(this.props.report) ? [
          {
              icon: Expensicons.Send,
              text: this.props.translate('iou.sendMoney'),
              onSelected: () => {
                  Navigation.navigate(
                      ROUTES.getIOUSendRoute(
                          this.props.reportID,
                      ),
                  );
              },
          }] : []),

@iwiznia What about my proposal then?

@iwiznia What about my proposal then?

If I am allowed to comment on your proposal, it looks like you are proposing to show all the options if there are multiple participants which I guess is not the intended behavior.

@sobitneupane

I think we are intentionally showing only the split bill options in all the rooms. I am not sure, though.

No, It was accidentally showing because the report participant's value is wrong, which introduces this issue as well, fix should be the same for both.
cc: @iwiznia

@iwiznia
Still looking for a better proposal.
As I said here `proposals are similar & partial``

@Santhosh-Sellavel The instructions are not clear. Can you specify what's missing in the above proposals?

@allroundexperts
This is the expected outcome,

Show Send Money and Request Money Options if there is a participant other than the logged in User and Show Split Bill Option if there are more than one participants other than the logged in User. In this case, even rooms with a participant other than the logged-in user will have Send Money and Request Money options.

@sobitneupane Already comment what's wrong with your proposal here

@Santhosh-Sellavel Here's the updated proposal.
Proposal
First of all, we need to make sure that the hasMultipleParticipants variable has an accurate value. The reportParticipants variable contains the logged in user for admins and announce channels but ignores them for single or group channels.
The hasMultipleParticipants variable is thus removed and replaced with a new variable called reportParticipantsOtherThanLoggedInUser :
https://github.com/allroundexperts/Expensify/blob/fix-8357/src/pages/home/report/ReportActionCompose.js#L395
The condition which checks for the menu items to display is also changed such that if reportParticipantsOtherThanLoggedInUser.length === 1, we show the send and request money options. If reportParticipantsOtherThanLoggedInUser.length > 1, we show the splitBill option.
https://github.com/allroundexperts/Expensify/blob/fix-8357/src/pages/home/report/ReportActionCompose.js#L452-L492
Result
https://user-images.githubusercontent.com/30054992/165148324-4b9cf5e3-5946-4bf2-a58a-8c874c657896.mov

@allroundexperts
Please try to include the exact code changes you are proposing instead of linking. Example like this https://github.com/Expensify/App/issues/8357#issuecomment-1108493490

@Santhosh-Sellavel Updated.

@iwiznia
Proposals are similar, so let's go with @sobitneupane here.
@sobitneupane Option 1 proposal here looks good to me.
One suggestion, let's move the IOU options preparation logic to a new method. Since the code is not DRY & too clumsy in Render Block.
🎀👀🎀 C+ reviewed.
Thanks!

Proposal looks good to me and I agree about the new method. @kadiealexander can you hire @sobitneupane please?

@sobitneupane Any update?

Hi the proposals above aren't complete if we only make the changes for actions we still be seeing our own contact whenever we try to send/reques/split bill as you can see in the screenshot.

As all the proposals are incomplete here's my proposal.
Proposal
We need to filter out our own login from the participant using _.filter  https://github.com/Expensify/App/blob/66f0643df8e19d442e23b2c73c694c22b5390c1e/src/pages/iou/IOUModal.js#L110
We will use two variables and based on them we will be showing different options, if showSplitBillOption is true will be showing the split bills and when showSendRequestMoney is true we will show the options of send and request money
( it is already proposed in the proposals above )
    const showSplitBillOption = _.filter(reportParticipants, email => this.props.myPersonalDetails.login !== email).length > 1;
    const showSendRequestMoney = _.filter(reportParticipants, email => this.props.myPersonalDetails.login !== email).length === 1;

We can create a new method showActions which will return an array of actions based on the conditions for different actions and we can just call it here
https://github.com/Expensify/App/blob/66f0643df8e19d442e23b2c73c694c22b5390c1e/src/pages/home/report/ReportActionCompose.js#L451

Hi the proposals above aren't complete if we only make the changes for actions we still be seeing our own contact whenever we try to send/reques/split bill as you can see in the screenshot.

As all the proposals are incomplete here's my proposal.
Proposal
We need to filter out our own login from the participant using _.filter  https://github.com/Expensify/App/blob/66f0643df8e19d442e23b2c73c694c22b5390c1e/src/pages/iou/IOUModal.js#L110
We will use two variables and based on them we will be showing different options, if showSplitBillOption is true will be showing the split bills and when showSendRequestMoney is true we will show the options of send and request money
( it is already proposed in the proposals above )
    const showSplitBillOption = _.filter(reportParticipants, email => this.props.myPersonalDetails.login !== email).length > 1;
    const showSendRequestMoney = _.filter(reportParticipants, email => this.props.myPersonalDetails.login !== email).length === 1;

We can create a new method showActions which will return an array of actions based on the conditions for different actions and we can just call it here
https://github.com/Expensify/App/blob/66f0643df8e19d442e23b2c73c694c22b5390c1e/src/pages/home/report/ReportActionCompose.js#L451
cc: @iwiznia @Santhosh-Sellavel

@Puneet-here Your proposal has nothing new here, what are you trying to say.
Even your proposal is incomplete here.

@sobitneupane please let me know once you've applied on Upwork!

@sobitneupane please let me know once you've applied on Upwork!

Applied.

Sent offers in Upwork to:
Hired contributor: @sobitneupane
C+: @Santhosh-Sellavel
Reporting bonus: @thesahindia

@sobitneupane could you please share an update here? Thanks!

@kadiealexander PR is merged & it's on production now!

Thanks @sobitneupane!!!

Everyone is paid! Thanks for your work, team.


ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

Trying to run this script (see save_jams method) as follows:
python audio_to_midi_melodia.py ~/datasets/melody/mirex05/audio/train05.wav train05.mid 60 --smooth 0.25 --minduration 0.1 --jams

And getting the following error upon trying to save a JAMS file:
Traceback (most recent call last):
  File "audio_to_midi_melodia.py", line 176, in <module>
    audio_to_midi_melodia(args.infile, args.outfile, args.bpm, smooth=args.smooth, minduration=args.minduration, savejams=args.jams)
  File "audio_to_midi_melodia.py", line 158, in audio_to_midi_melodia
    save_jams(jamsfile, notes, track_duration)
  File "audio_to_midi_melodia.py", line 30, in save_jams
    jam.save(jamsfile)
  File "/Users/justin/dev/jams/jams/core.py", line 1186, in save
    self.validate(strict=strict)
  File "/Users/justin/dev/jams/jams/core.py", line 1216, in validate
    valid = super(JAMS, self).validate(strict=strict)
  File "/Users/justin/dev/jams/jams/core.py", line 478, in validate
    raise SchemaError(str(invalid))
  File "/Library/Python/2.7/site-packages/jsonschema/exceptions.py", line 35, in __str__
    return unicode(self).encode("utf-8")
  File "/Library/Python/2.7/site-packages/jsonschema/exceptions.py", line 39, in __unicode__
    self.validator, self.validator_value, self.instance, self.schema,
ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

Not entirely sure what I'm doing wrong...? (running jams v0.2.0 on python 2.7)

It looks like your values don't pass validation.  Can you print out midi_an.data?

              time        duration  value confidence
0  00:00:00.211882 00:00:00.153832     62        NaN
1  00:00:00.420862 00:00:00.609524     64        NaN
2  00:00:01.233560 00:00:00.208980     59        NaN
3  00:00:01.503492 00:00:00.229297     57        NaN
4  00:00:01.787937 00:00:01.355465     60        NaN
5  00:00:04.176689 00:00:00.235102     54        NaN
6  00:00:04.574331 00:00:00.365714     55        NaN
7  00:00:05.099683 00:00:00.229297     57        NaN
8  00:00:05.389932 00:00:00.357007     60        NaN
9  00:00:05.752744 00:00:00.365714     62        NaN
10 00:00:06.118458 00:00:00.119002     63        NaN
11 00:00:06.237460 00:00:01.256780     64        NaN
12 00:00:07.601633 00:00:00.182857     67        NaN
13 00:00:08.019592 00:00:00.101587     62        NaN
14 00:00:08.164717 00:00:00.136417     64        NaN
15 00:00:08.321451 00:00:00.905578     62        NaN
16 00:00:09.604354 00:00:00.162540     63        NaN
17 00:00:09.766893 00:00:00.255419     64        NaN
18 00:00:11.270385 00:00:00.182857     62        NaN
19 00:00:11.537415 00:00:00.150930     60        NaN
20 00:00:11.694150 00:00:00.716916     60        NaN
21 00:00:14.169977 00:00:00.101587     62        NaN
22 00:00:14.318005 00:00:00.159637     64        NaN
23 00:00:14.532788 00:00:00.644354     60        NaN
24 00:00:15.188753 00:00:00.264127     58        NaN
25 00:00:15.464490 00:00:01.146485     60        NaN
26 00:00:16.610975 00:00:00.162540     61        NaN
27 00:00:16.773515 00:00:00.223492     60        NaN
28 00:00:17.017324 00:00:00.394739     62        NaN
29 00:00:17.412063 00:00:00.171247     63        NaN
30 00:00:17.583311 00:00:00.179955     64        NaN
31 00:00:17.763265 00:00:00.304762     67        NaN
32 00:00:18.068027 00:00:00.362812     69        NaN
33 00:00:18.819773 00:00:00.119002     57        NaN
34 00:00:19.008435 00:00:00.757551     59        NaN
35 00:00:19.899501 00:00:00.682086     57        NaN
36 00:00:20.610612 00:00:00.325079     59        NaN
37 00:00:20.935692 00:00:00.383129     60        NaN
38 00:00:21.330431 00:00:00.284444     62        NaN
39 00:00:21.670023 00:00:00.371519     64        NaN
40 00:00:22.090884 00:00:00.113197     68        NaN
41 00:00:22.204082 00:00:00.693696     69        NaN
42 00:00:22.897778 00:00:00.223492     68        NaN
43 00:00:23.121270 00:00:00.174150     69        NaN
44 00:00:23.547937 00:00:00.238005     65        NaN
45 00:00:24.909206 00:00:00.177052     69        NaN
46 00:00:25.086259 00:00:00.258322     68        NaN
47 00:00:25.663855 00:00:00.824308     64        NaN
48 00:00:26.935147 00:00:00.525351     71        NaN
49 00:00:27.460499 00:00:00.197370     72        NaN
50 00:00:27.657868 00:00:00.415057     71        NaN
51 00:00:29.837642 00:00:00.156735     63        NaN
52 00:00:29.994376 00:00:00.722721     64        NaN
53 00:00:30.722902 00:00:00.119002     62        NaN
54 00:00:31.245351 00:00:00.714014     59        NaN
55 00:00:31.959365 00:00:01.268390     60        NaN
56 00:00:33.227755 00:00:00.261224     59        NaN
57 00:00:33.488980 00:00:00.174150     60        NaN
58 00:00:33.663129 00:00:00.737234     59        NaN

Looks fine no?

What is your pandas version? I had problems with msaf and the latest pandas version. See this. The temporary workaround is to downgrade pandas to 0.16.2.

I'm still on pandas 0.16.1

That's super weird, and yes, it looks fine.
Do the unit tests pass on your machine?
Everything works for me on pandas 0.17, but it also worked when I was on 0.16.2.

I've re-installed jams and mir_eval from source (just in case). When I run nosetests (from the jams/jams/tests folder), I get:
justin$ nosetests
..................................................................................................................................................................................../usr/local/lib/python2.7/site-packages/pandas/tseries/timedeltas.py:55: RuntimeWarning: tp_compare didn't return -1 or -2 for exception
  value = value.astype('timedelta64[ns]', copy=False)
...................................................................................................................................................................................................................................................................................................................................................................................E...............................
======================================================================
ERROR: Failure: KeyError ('jams/tests/fixtures/schema')
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/nose/loader.py", line 251, in generate
    for test in g():
  File "/Users/justin/Documents/dev/jams/jams/tests/schema_test.py", line 64, in test_schema_local
    'schema'))
  File "build/bdist.macosx-10.9-x86_64/egg/pkg_resources.py", line 954, in resource_filename
    self, resource_name
  File "build/bdist.macosx-10.9-x86_64/egg/pkg_resources.py", line 1652, in get_resource_filename
    return self._extract_resource(manager, zip_path)
  File "build/bdist.macosx-10.9-x86_64/egg/pkg_resources.py", line 1673, in _extract_resource
    timestamp, size = self._get_date_and_size(self.zipinfo[zip_path])
KeyError: 'jams/tests/fixtures/schema'

----------------------------------------------------------------------
Ran 583 tests in 16.151s

FAILED (errors=1)

update: just upgraded my jsonschema from 2.30 to 2.5.1. Now getting a slightly more friendly error:
Traceback (most recent call last):
  File "audio_to_midi_melodia.py", line 183, in <module>
    audio_to_midi_melodia(args.infile, args.outfile, args.bpm, smooth=args.smooth, minduration=args.minduration, savejams=args.jams)
  File "audio_to_midi_melodia.py", line 165, in audio_to_midi_melodia
    save_jams(jamsfile, notes, track_duration)
  File "audio_to_midi_melodia.py", line 37, in save_jams
    jam.save(jamsfile)
  File "build/bdist.macosx-10.9-x86_64/egg/jams/core.py", line 1186, in save
  File "build/bdist.macosx-10.9-x86_64/egg/jams/core.py", line 1216, in validate
  File "build/bdist.macosx-10.9-x86_64/egg/jams/core.py", line 478, in validate
jams.exceptions.SchemaError: array([  6.90624574e-07,   6.71248301e-07,   6.26267763e-07, ...,
        -1.51549884e-07,  -1.41861761e-07,  -9.82652182e-08], dtype=float32) is not of type u'number'

Failed validating u'type' in schema[u'properties'][u'file_metadata'][u'properties'][u'duration']:
    {u'minimum': 0.0, u'type': u'number'}

On instance[u'file_metadata'][u'duration']:
    array([  6.90624574e-07,   6.71248301e-07,   6.26267763e-07, ...,
            -1.51549884e-07,  -1.41861761e-07,  -9.82652182e-08], dtype=float32)

...and consequently I have found the problem: I was setting the jam.file_metadata.duration to something that wasn't a number. Three hips for improved error messages.
Closing.


AVIF image preview support File Explorer add ons

Description of the new feature / enhancement
Title speaks for itself. Just like SVGs, would be nice if we had file explorer thumbnail previews for AVIF encoded images. This format is getting more popular by the day.
Scenario when this would be used?
While using File Explorer and a view mode is selected that shows image thumbnails/previews.
Supporting information
No response

With MSEdge 121 released with AVIF support by default, the format has a 88.75% global usage (on browser) according to Can I Use, and I think it would gradually become popular since compatibility issue is slowing going away with this. Having AVIF preview support for File Explorer would benefit a lot more users these days.

With MSEdge 121 released with AVIF support by default, the format has a 88.75% global usage (on browser) according to Can I Use, and I think it would gradually become popular since compatibility issue is slowing going away with this. Having AVIF preview support for File Explorer would benefit a lot more users these days.

I agree! It would be useful! I only had one file with AVIF extension, but because I didn't get a preview thumbnail I was like, hey why not? Isn't it just an image? Should be easy!!! Hopefully MS can fix it soon enough, because I doubt there's a way to get thumbnails for them now, and also indeed the .SVC files! I'd like previews for those as well! But I understand that would be a little harder, as they are more like instructions on how to draw something than a literal picture like a jpg
And I'm 100% sure we're not alone in this! There must be tons of users who would LOVE those thumbnails but just don't mind it enough to complain about it!!! Hopefully someone at MS reads this and can make it happen! I really believe it shouldn't be too much work!

@vibonacci , @DJ-High-on-Life ,
I recently encountered with a similar problem. I resolved it by installing the AV1 Video Extension from the Microsoft Store.

@edelvarden I have the AV1 Video Extension, plus some other HEVC related extensions, and I still don't see thumbnails for AVIF images.


Review and MainCharacterOrTeam missing fields

Added missing field used originally by ComicRack

Which ComicRack version did you use to find out about those fields ?

You can see it on the example comic a made here anansi-project/comicinfo#13

You can see it on the example comic a made here #13

however the 2 fields in this PR are not present in #13

I was specifically referencing this comment on the PR
https://github.com/anansi-project/comicinfo/pull/13#issuecomment-1020724484

@IngBertolini the fields should be added to both 2.1 and 2.0 in that case, since it's from the original CR format (2.0). The indentation looks incorrect in the XML too.
The changelog should mention the fields in the 2.0 section, not in 2.1.
I don't think we can actually track whether this was present in 1.0 ?

Which ComicRack version did you use to find out about those fields ?

The last version available i think (v0.9.178). I just edit all the metadata of a book and looked at the exported xml. As you can see in this screenshot, they are also present in GUI.

@IngBertolini the fields should be added to both 2.1 and 2.0 in that case, since it's from the original CR format (2.0). The indentation looks incorrect in the XML too.
The changelog should mention the fields in the 2.0 section, not in 2.1.
I don't think we can actually track whether this was present in 1.0 ?

Sure, i can fix that. But what about the field Day? It's prensent in v2.0 but in the changelog it appears under v2.1

@IngBertolini the fields should be added to both 2.1 and 2.0 in that case, since it's from the original CR format (2.0). The indentation looks incorrect in the XML too.
The changelog should mention the fields in the 2.0 section, not in 2.1.
I don't think we can actually track whether this was present in 1.0 ?

Sure, i can fix that. But what about the field Day? It's prensent in v2.0 but in the changelog it appears under v2.1

At first we thought the schema was official, while in fact it was inferred from the actual XML.
The schema that was going around before we started this initiative did not mention Day, while the XML had it. We could probably remove Day from the 2.1 changelog.

Done, i added the field also to version 2.0 and updated the changelog.

Seems like there are some conflicts in your PR, can you help to resolve it?

Done!


 does not work as expected

Issue
This code will play the initial animation, even while initial is set to false
<AnimatePresence initial={false}>
 <View
      from={{
        opacity: 0,
        scale: 0.9,
      }}
      animate={{
        opacity: 1,
        scale: 1,
      }}
      exit={{
        opacity: 0,
        scale: 0.9,
      }}
      style={styles.shape}
    />
</AnimatePresence>

Workaround
Rename the from prop to initial
<AnimatePresence initial={false}>
 <View
      initial={{
        opacity: 0,
        scale: 0.9,
      }}
      animate={{
        opacity: 1,
        scale: 1,
      }}
      exit={{
        opacity: 0,
        scale: 0.9,
      }}
      style={styles.shape}
    />
</AnimatePresence>

I'm not sure if this is expected behaviour as the initial prop is not documented and how it differs to the from prop

As it stands, animate presence only supports exits for presence animations. I'm not exactly sure how framer implements the initial prop, but it isn't used on Moti at the moment. What is the expectation of what should happen here? Should the initial state be animate?

I believe Framers initial prop is basically the same as moti's from prop. I think if the AnimatePresence cloned its children and copied the from prop to initial there's a chance it might just work.

I don't think so - Moti leverages a headless version of AnimatePresence with the usePresence hook, and implements the exit style when !isPresent, and then calls safeToUnmount when the final reanimated callback fires.
So my guess is we'd need to make a custom context that checks for the initial value and export a custom AnimatePresence component.

Reading through this code: https://github.com/framer/motion/blob/main/src/components/AnimatePresence/PresenceChild.tsx
It looks like we could just get the initial value from the presence child context.

I have the same issue

Providing an empty object to from on the first render and then useEffect to set from to what should really be, does fix the issue, as a workaround. ;)

Could you please try this https://github.com/nandorojo/moti/pull/102
yarn add moti@presence

I added support for the initial prop there. Would be useful to get it tested.

Fixed in 0.12.0
yarn add moti


Can't equip Joyeuse as BLU in CatsEye server

In CatsEye BLUs are allowed to equip Joyeuse but because of this check: https://github.com/ThornyFFXI/LuAshitacast/blob/main/addons/luashitacast/equip.lua#L163 luashitacast isn't equipping it, I've tried commenting it out and Joyeuse gets equipped correctly, is it possible to make this a setting?

I am not willing to make this a setting, as it would result in retail players sending inappropriate packets.  The dats that control item data are well enough known that a well maintained private server should be updating them to reflect custom changes like this.  Doing it through the dat would both solve the issue for luashitacast and other plugins, but fix the display element ingame to show the correct jobs.

That's weird then because I'm pretty sure the CatsEye devs updated their dats, here's how it looks in game:

If your dats are provided via a ffxipivot layer, make sure you have the latest version of ffxipivot to allow ashitas resource manager to reflect them.  The setting was only added recently.  Alternatively, you could replace the actual dat in the install, though I recommend the pivot approach.

I just updated pivot and I'm happy to report that it works now, thanks for the help!


thumbnail images for emoji_intruder and puzzel_winner

@kunjgit issue #3641 has been rectified.

Thank you @bhumika-1127 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@kunjgit are there any updates about this pull request.

Thank you  @bhumika-1127 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

/assign


Add svelte/no-reactive-literals rule

Porting over another of the simpler rules from https://github.com/tivac/eslint-plugin-svelte/ like we discussed in https://github.com/ota-meshi/eslint-plugin-svelte/issues/198

Had to add some infrastructure to make snapshot testing of suggestions possible, will be useful for #201 as well.


Add migration for Tagging Events table

For the MVP of the content tagging history, this adds the reporting-table.

Perhaps we could commit the migration itself too, although I like the minimalism.

@tijmenb ugh, if I must

@tijmenb how do like them 🍏 🍏 🍏 ?


4.0.0.Beta: Must call super constructor in derived class before accessing 'this' or returning from derived constructor

When running Stryker on its own @stryker-mutator/karma-runner, we now get this error:
ReferenceError: Must call super constructor in derived class before accessing 'this' or returning from derived constructor
ReferenceError: Must call super constructor in derived class before accessing 'this' or returning from derived constructor
    at new StrykerReporter (/home/nicojs/stryker/packages/karma-runner/.stryker-tmp/sandbox1223810/src/karma-plugins/StrykerReporter.ts:51:10)
    at Object.<anonymous> (/home/nicojs/stryker/packages/karma-runner/.stryker-tmp/sandbox1223810/src/karma-plugins/StrykerReporter.ts:68:39

Cause:
This:
export default class StrykerReporter extends EventEmitter implements karma.Reporter {
  public adapters: any[] = [];

  private constructor() {
    super();
  }
  // ...
}

Is mutated to:
export default class StrykerReporter extends EventEmitter implements karma.Reporter {
  public adapters: any[] = __global_69fa48.__activeMutant__ === 10 ? ["Stryker was here"] : (__global_69fa48.__coverMutant__(10), []);

  private constructor() {
    switch (__global_69fa48.__activeMutant__) {
      case 11:
        {}
        break;

      default:
        __global_69fa48.__coverMutant__(11);
        {
          super();
        }
        break;
    }
  }
 // ...
}

Which is then transpiled to:
class StrykerReporter extends events_1.EventEmitter {
    constructor() {
        this.adapters = __global_69fa48.__activeMutant__ === 10 ? ["Stryker was here"] : (__global_69fa48.__coverMutant__(10), []);
        // ...
        switch (__global_69fa48.__activeMutant__) {
            case 11:
                { }
                break;
            default:
                __global_69fa48.__coverMutant__(11);
                {
                    super();
                }
                break;
        }
    }
   // ...
}

Hi!
Even with the 6.2.0-beta.0 a class like that:
export class BuyerRoute extends PbRoute {
  #traveler: string;

    constructor(input: BuyerRouteInput) {
        super(input);
        this.#traveler = input.traveler;
    }
}

Is still compiled by Stryker like that:
export class BuyerRoute extends PbRoute {
    #traveler: string;

    constructor(input: BuyerRouteInput) {
        if (stryMutAct_9fa48("647")) { {}
        } else {
            stryCov_9fa48("647");
            super(input);
            this.#traveler = input.traveler;
        }
    }
}

Here my stryker.conf.ts file:
// @ts-check
/** @type {import('@stryker-mutator/api/core').PartialStrykerOptions} */
const config = {
    _comment:
        "This config was generated using 'stryker init'. Please take a look at: https://stryker-mutator.io/docs/stryker-js/configuration/ for more information",
    packageManager: "yarn",
    reporters: ["html", "clear-text", "progress"],
    testRunner: "jest",
    coverageAnalysis: "perTest",
    checkers: ["typescript"],
    tsconfigFile: "tsconfig.json",
    transpilers: [
        "typescript", // Specify that your typescript code needs to be transpiled before tests can be run. Not needed if you're using ts-node Just-in-time compilation.
    ],
    jest: {
        projectType: "custom",
        configFile: "./jest.config.ts",
        enableFindRelatedTests: true,
    },
    disableTypeChecks: "{__tests__,src,lib}/**/*.{js,ts,jsx,tsx,html,vue}",
};
export default config;

This seems like old config, because i see you've configured transpilers. This is no longer supported. Can you confirm the Stryker version for me? What does npm ls @stryker-mutator/core say?


The script New-AzSADGraphServicePrincipal seems to be ASDK specific

The script New-AzSADGraphServicePrincipal is using the infrastructure node AZS-ADFS01. On an Azure Stack integrated system deployment, the infrastructure nodes have network ACL's to protect them from user access.
The script also has a hard coded reference to AZS-ERCS0. The prefix (AZS) is user defined in integrated system deployments.
Is there an alternative method for creating ADFS service principles on Azure Stack integrated system deployments?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3659de5e-cc41-09b6-cb9b-02272f7fa157
Version Independent ID: a4e37e28-efbd-8fbb-0795-5e68fc13476e
Content
Content Source
Service: azure-resource-manager

@DaveDXC Thanks for the feedback, I assigned the issue to the author for further investigation.

Hi ... I have a question out about this and should update shortly. Thanks! Matt #in-process

@cxp - can you re-label this azure-stack? Azure Resource Manager questions within Azure Stack are handled by the azure-stack team.

I haven't heard back yet. Will update as soon as I do. #in-process

#please-close


GCS: FileWriter.Size: return offset + buffer size for Writers that are not closed

@RichardScothern @manuelmazzuola

[Current coverage][cc-pull] is 54.63%

Merging [#1713][cc-pull] into [release/2.4][cc-base-branch] will decrease coverage by -6.81%

3 files (not in diff) in ...istry/storage/driver were modified. more

Misses +807
Partials -92
Hits -715

2 files (not in diff) in registry/storage were modified. more

Misses -3
Partials -2
Hits +5

2 files (not in diff) in registry were modified. more

Misses +3
Partials -1
Hits -2

@@           release/2.4      #1713   diff @@
=============================================
  Files              119        119
  Lines            10452      10452
  Methods              0          0
  Messages             0          0
  Branches             0          0
=============================================
- Hits              6422       5710   -712
- Misses            3430       4237   +807
+ Partials           600        505    -95

Powered by Codecov. Last updated by [1e0f3b7...431e46a][cc-compare]
[cc-base-branch]: https://codecov.io/gh/docker/distribution/branch/release/2.4?src=pr
[cc-compare]: https://codecov.io/gh/docker/distribution/compare/1e0f3b7b64058a090b2e38584ce323a408774848...431e46a7f9a5dd7f8ebd13af44c91ae887d4af06
[cc-pull]: https://codecov.io/gh/docker/distribution/pull/1713?src=pr

@manuelmazzuola are you able to build a container to test with?  If not @aibaars could you do so and it's looking OK I'll make another release candidate 😿

@RichardScothern Not today (GMT+1)
@aibaars If you can't I'll try it tomorrow

@RichardScothern I built a container and pushed and pulled the debian and ubuntu images to/from it. This works fine. However, this also worked fine for me with the previous patch.
Therefore, I would like to ask @manuelmazzuola to repeat his tests,just to be sure.

@RichardScothern I've built, pushed and pulled different versions of the same image and seems to work fine.

LGTM.

@manuelmazzuola Many thanks!

@aibaars Thanks to you

@manuelmazzuola @aibaars thanks to both of you for helping with this 👍

This was merged in the 2.4 branch, but it was never merged into master so its broken in all subsequent releases.


Update the survey

This PR updates the 2023 survey Markdown file to match what is currently configured at SurveyHero. It consists mostly of flow changes (technology questions were clumped together), and some wording changes.

I trust that all the changes here reflect the comments, so LGTM :rocket:


Make media file and directory permissions configurable

This PR adds the possibility to change the media file and directory permissions in the config.php file. The default permissions used before are copied from League\Flysystem\Adapter\Local into Shopware's Default config file.
With the help of this PR it's possible to add for example group write permissions to the files an directories.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/#/issues/SW-14329.
Please use this issue to track the state of your pull request.

Merged with commit https://github.com/shopware/shopware/commit/ab1a101765c222f7975cb41ea96f5c11e9a2e63a.
Please not that I changes the default permission values to respect the systems umask setting: https://github.com/shopware/shopware/commit/58320a8f8b31be405aff58567a6ec9501bd5673f
See also https://github.com/shopware/shopware/pull/410 and https://developers.shopware.com/blog/2016/02/26/file-permissions-and-umask-in-php-and-shopware/.
Thanks for your contriubution @FiveDigital  :+1:

Thanks for merging :+1: We will continue to provide Pull Requests whenever we have this kind of permission issue.


.translateText function overload is not exhaustively typed

Summary
Your definition of .translateText runs into this canonically known typescript issue. It expects the language compiler to exhaustively perform a combinatorically expensive type casting which is not supported.
Code
type TranslationText = string | string[];
const firstTextToTranslate: TranslationText = 'hello world';
const secondTextToTranslate: TranslationText = ['hello world'];

deepl.translateText(firstTextToTranslate, ...);
/* yields compiler error:
No overload matches this call.
  Overload 1 of 2, '(texts: string, sourceLang: SourceLanguageCode | null, targetLang: TargetLanguageCode, options?: TranslateTextOptions | undefined): Promise<...>', gave the following error.
    Argument of type 'string | string[]' is not assignable to parameter of type 'string'.
      Type 'string[]' is not assignable to type 'string'.
  Overload 2 of 2, '(texts: string[], sourceLang: SourceLanguageCode | null, targetLang: TargetLanguageCode, options?: TranslateTextOptions | undefined): Promise<...>', gave the following error.
    Argument of type 'string | string[]' is not assignable to parameter of type 'string[]'.
      Type 'string' is not assignable to type 'string[]'.ts(2769)
*/

// on the other hand...
deepl.translateText(secondTextToTranslate, ...);
/* yields the same compiler error: */

Expected Behaviour
Typescript/your type definitions should be able to deduce that your function supports both types of inputs
Solution Proposition
As the Typescript team already made very clear that they are not planning to implement a combinatorically expensive feature, we have to work around this.
The typescript docs on conditional types state that overloading is unnecessary and your function definition could be done in a single, stable go with some generics and conditional types.
  async translateText<T extends string | string[]>(
      texts: T,
      sourceLang: SourceLanguageCode | null,
      targetLang: TargetLanguageCode,
      options?: TranslateTextOptions,
  ): Promise<T extends string ? TextResult : TextResult[]>

Hi Jannis, thanks for this great suggestion. I'll include your proposal in the next update.


How to Echo Back Challange Parameter from DropBox

I want to echo back challange parameters from DropBox Webhook API
Is this possible ?
for example, i need to echo back below request...
Error: TTP code 503 from proxy after CONNECT
Request:
GET https://example.org/hooks/produkto?challenge=examplechallangecode
Response:
(No headers)
Response Body (First 256 bytes):
(No response body)
Reference : https://www.dropbox.com/developers/reference/webhooks

Yes, it is possible.
A sample hook definition could look something like this:
{
    "id": "dropbox-echo",
    "execute-command": "/bin/echo",
    "pass-arguments-to-command": [
        {
            "source": "query",
            "name": "challenge"
        }
    ],
    "include-command-output-in-response": true
}


fix: remove segmentation background

Addresses: https://github.com/ImagingDataCommons/slim/issues/245
Removes the background color of the segmentations. Use the following dataset to test with slim:
https://healthcare.googleapis.com/v1/projects/idc-sandbox-000/locations/us-central1/datasets/fedorov-dev-healthcare/dicomStores/singlebitsegstest/dicomWeb

@pedrokohler The idea is to have the opacity configurable via UI, or removed completely? Could you double-check with @fedorov?


Link the projects to its dependencies within the monorepo

https://github.com/kgunnerud/monorepo-maven-example

Addressed in #4.


Docs 8840 docs 8842 dashboard fixes

In addition, the performance section is still incorrect. There are still several inconsistencies between the doc and the actual product. If you need an account with data to see the actual charts, please ping the team.

Infrastructure charts are still off. What's documented does not match the product.

Infrastructure charts are still off. What's documented does not match the product.

Updated. RE: Performance, the Outbound - Response Time Grouped by HTTP Endpoint should not have "grouped" in it. We removed that elsewhere.


Comparing Performance of 70B Models with Different Versions (0.5.1 vs 0.7.0)

Xeon processor, 64GB of memory, and a P40 GPU with 24GB of VRAM.
================================================
For the smaller 7B model, the 0.7.0 version is a bit faster than 0.5.1
However, for the larger 70B model, the 0.7.0 version is noticeably slower compared to the 0.5.1 version.
Tested two models: "fashiongpt-70b-v1.2.Q6_K.gguf" and "stellarbright.Q5_K_M.gguf."
===============================================================
0.5.1 version processes about 0.8 token per second (observed rate)
0.7.0 version processes at a slower rate of around 0.3 tokens per second (observed rate)
===============================================================

Could you please try the latest v0.8.0 published just now? It fixed some performance problems.

Version 0.8.0 is nearly identical to version 0.5.1
++++++++++++++++++++++++++++++
fashiongpt-70b-v1.2.Q6_K.gguf
++++++++++++++++++++++++++++++
version 0.5.1 -  272 tokens / 346 secs = 0.786 tokens /sec
version 0.8.0 -  266 tokens / 346 secs = 0.768 tokens /sec


Pull Request #null when exiting review mode

Issue Type: Bug
When exiting review mode I see Pull Request #null in the bottom status bar.

Extension version: 0.1.7
VS Code version: Code - Insiders 1.29.0-insider (5bd6ebe2dbc4dee510699020a25f70a69784ce8c, 2018-10-09T09:24:52.091Z)
OS version: Darwin x64 17.7.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4980HQ CPU @ 2.80GHz (8 x 2800)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledrasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (0.03GB free)

Process Argv
-psn_0_884952

Screen Reader
no

VM
0%

@bm-stschneider Does this happen every time you exit review mode? Does the status bar item continue to show after that, or is it eventually removed? When you exit, do you return to master, or a different branch?

It does not happen every time.
It does not get removed.
I do return to master.

@RMacfarlane do you think we didn't clear this._validateStatusInProgress ever and the else path is never executed?
https://github.com/Microsoft/vscode-pull-request-github/blob/ac8861dd9f2524a1cadcab56f99ff3e26879eec1/src/view/reviewManager.ts#L188-L194

Did you just break the PR feature?


Suggestion: option to prevent un-rolling hidden pieces of code in html

Hello
I have a little suggestion as mentioned in the title. In my opinion it would have been very convenient (and I was used to it since I moved recently from the original extension)
What I mean is:
Hidden code

After pressing Ctrl+Shift+L it gets 'un-rolled' :)

Thanks in advance :)
PS. I have to mention that I really, really appreciate that someone decided to revive this apparently abandoned extension :smiley:
Keep it up! :smiley:

First of all, thanks. :smile:
Next, a few questions:
I am assuming you are using Brackets Code Folding to hide parts of you code, right?

...and I was used to it since I moved recently from the original extension

Do you mean it worked as you expect in the original extension?

Well, I meant I'm just using that 'built-in' Brackets feature, using those side arrows

to hide the parts of code which I don't need at the moment.

So I've thought it might be convenient not to have those hidden parts shown when formatting with beautify
:grinning:

Alright, understood.
I agree, that that would be convenient, but I don't really know how to do it.
But I will continue thinking about it and looking into the folding API to find something.


Overhang parameter required

>>> ldseguid("AT", "AT")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: ldseguid() missing 1 required positional argument: 'overhang'

You appear to be using an old version here. The use of overhang parameter was dropped in:
$ git log --grep overhang
commit 975f74e5b2f60b0ab610a0b9dc697ad1ef29edad
Author: Henrik Bengtsson<EMAIL_ADDRESS>Date:   Sun Feb 11 17:57:12 2024 -0800

    Python: Drop argument 'overhang' from ldseguid() [#73]

I see! we should push the latest version to PyPI

I see! we should push the latest version to PyPI

Ideally, we should just have had a "don't use" stub on PyPi until we know that SEGUID v2 is final and stable; my main concern all this time has been there are user out there who might have start producing checksums that will no longer be correct. At least the prefixes of the PyPi version are different.
So, we should hold back push an update until we reached milestone 1.0 (= SEGUID v2 is finalized and we don't believe the API or the algorithm will change anymore).