index out of range attempting to connect

On attempting to connect to the mysql database, I'm receiving an index of range error.
Running this code.
var mssql = require('mssql');
var options = {
  user:'root',
  password:'password',
  server:'localhost',
  port:3306
  datatase:'test'
};
mssql.connect(options);

Results in this error (I've removed the path before the node_modules).
buffer.js:615
    throw new RangeError('index out of range');
    ^

RangeError: index out of range
    at checkOffset (buffer.js:615:11)
    at Buffer.readUInt8 (buffer.js:653:5)
    at Packet.isLast (/node_modules/tedious/lib/packet.js:112:29)
    at ReadablePacketStream.<anonymous> (/node_modules/tedious/lib/message-io.js:91:18)
    at emitOne (events.js:77:13)
    at ReadablePacketStream.emit (events.js:169:7)
    at readableAddChunk (/node_modules/readable-stream/lib/_stream_readable.js:198:18)
    at ReadablePacketStream.Readable.push (/node_modules/readable-stream/lib/_stream_readable.js:157:10)
    at ReadablePacketStream.Transform.push (/node_modules/readable-stream/lib/_stream_transform.js:123:32)
    at ReadablePacketStream._transform (/node_modules/tedious/lib/message-io.js:57:16)

I know the mysql credentials are correct as I'm using them in another program.
If you need to know any other information let me know.

This is a connection for Microsoft SQL Server, not MySQL.

 Thanks man.


hipErrorNoBinaryForGpu when built for HIP

I am trying to build MAGMA for HIP on gfx90a GPU (AMD MI210, it's ARCHER2 supercomputer).
I use the following cmake command:
cmake -DMAGMA_ENABLE_CUDA=OFF  -DMAGMA_ENABLE_HIP=ON -DCMAKE_LIBRARY_PATH=${CRAY_LIBSCI_PREFIX_DIR}/lib -DCMAKE_CXX_COMPILER=hipcc  -DGPU_TARGET=gfx90a  -DBUILD_SHARED_LIBS=off  -DUSE_FORTRAN=on -DLAPACK_LIBRARIES='-L/opt/cray/pe/libsci/<IP_ADDRESS>/AMD/4.0/x86_64/lib -lsci_amd -lsci_amd_mpi -ldl -lhipblas -lhipsparse -lamdhip64'  ..
Build goes succesfully, but almost all tests fail with message
"hipErrorNoBinaryForGpu: Unable to find code object for all current devices!"
CMake and Make logs are attached:
cmake.log
make.log.gz
Here is also a log of make with VERBOSE=1
make_VERBOSE.log.gz

I have tried manually recompile a test with  --offload-arch=gfx90a  but it had no effect.
I have tried adding 90a In CMakeLists.txt, as Mark Gates suggested here,  to this list:

    set(VALID_GFXS "700;701;702;703;704;705;801;802;803;805;810;900;902;904;906;908;909;90c;1010;1011;1012;1030;1031;1032;1033")

But it also didn't help

Can you specify some exact test which is failing for you? And could you be able to test by building the rocm_sdk_builder for gfx90a enabled? It includes the latest version of magma and I have not seen that error on radeon devices I have tested. Build instructions:
https://github.com/lamikr/rocm_sdk_builder

After building, this is example how to try out the magma test apps:
 #  source /opr/rocm_sdk_612/bin/env_rocm.sh
 #  cd ocm_sdk_builder_612/builddir/037_magma/testing
 # ./testing_sswap

It's because of this line: https://github.com/icl-utk-edu/magma/blob/2716e3f19e85f389e3f1b3d259086b0d98fe0503/CMakeLists.txt#L290
Only a number of hard-coded GPU architectures are supported. If you pass other architectures when building, they will get ignored.
It was added 3 years ago so probably a unnecessary check now.

If you apply the patch from #15 (or even just sed -i 's/hip::host/hip::device/' CMakeLists.txt), you can instead pass -DAMDGPU_TARGETS=gfx90a and that seems to be sufficient to build magma for the selected hardware.


fix: Adds X-Forward header reading to nginx

📲 What
This adds a value to the nginx ingress configmap to read the X-Forward-* headers set by Application Gateway
🤔 Why
This is needed for two reasons:
1.) This allows pods to get the IP address of the incoming request, rather than the Internal IP of Application Gateway.
2.) If you set ssl-redirect to true, you end up with an infinite redirect loop as Nginx ignores the forwarded protocol from the user and so it always thinks the incoming requests are under http and so issues a redirect to https.
👀 Evidence

The diff on the left is what we want and is what is achieved by enabling this.


Add files via upload

Add Portuguese README.md file

You mean the, "Read this in other languages: 한국어、中国." or there are another things needed?
@stevemart

@lnrego take a look at how it is rendered: https://github.com/lnrego/personal-wealth-portfolio-mgt-bot/blob/308bf138d534b8d08c4eb167fb8e5895d81e9f9e/README-pt.md
For instance, the titles need new lines between the titles and content

@stevemart
All fixes done, those md were not done by me, now it's all OK.


[Bug][Minor] Multiblade fish turbine recipe see's treated wood power poles only

Mod source
Factorio Mod Portal
Latest from today:

pY-AE 3.012
pY-PP 3.0.9
...

Operating system

=Windows 10

What kind of issue is this?

[ ] Compatibility
[ ] Locale (names, descriptions, unknown keys)
[ ] Graphical
[ ] Crash
[ ] Progression
[ ] Balance
[ ] Pypostprocessing failure
[X] Other

What is the problem?
After researching Creosote and gaining access to the 2nd recipe for small power poles (which do use treated wood instead), the multiblade fish turbine recipe only see's the treated wood poles but not the simple ones which do use logs.
(classified "minor" as we can just craft the log poles manually before trying to craft the turbine(s), so a valid and easy workaround exists)

Steps to reproduce

Research up to "Steel".
Try to craft a multiblade fish turbines, with logs and copper in inv -> works
Research up to "Creosote".
Try to craft a multiblade fish turbines, with logs and copper in inv only, but no treated wood panels -> red, can't craft (see pic)

Additional context
No response
Log file
No response

This is factorio's native system to detect "optimal" recipes used when handcrafting. It also does this with rubber belts and transport belts used in recipes like undergrounds. I'm not sure if they want this fixed or not

On a similar note, perhaps the same should be done for rubber belt to transport belt recipe


Changed round to roundf to fix PR #3406

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:
This PR fixes a #3406 where the original person that opened the issue never made a PR.
The Invalid layout for (1)<RCTRootContentView: 0x7bb9e0c0; reactTag: 1; frame = (0 0; 414 736); gestureRecognizers = <NSArray: 0x7bb72450>; layer = <CALayer: 0x7bb783d0>>. position: {nan, nan}. bounds: {{0, 0}, {nan, nan}} error was being caused by a function in the https://github.com/facebook/react-native/blob/master/React/Base/RCTUtils.m at line 303 where we are using round() which is for the type double. Changing round() to roundf() fixed the error.
Explain the motivation for making this change. What existing problem does the pull request solve?
This pull request solves the Invalid layout for (1)<RCTRootContentView: 0x7bb9e0c0; reactTag: 1; frame = (0 0; 414 736); gestureRecognizers = <NSArray: 0x7bb72450>; layer = <CALayer: 0x7bb783d0>>. position: {nan, nan}. bounds: {{0, 0}, {nan, nan}} error.
Prefer small pull requests. These are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
Test plan (required)
Before

After

Make sure tests pass on both Travis and Circle CI.
Code formatting
Look around. Match the style of the rest of the codebase. See also the simple style guide.
For more info, see the "Pull Requests" section of our "Contributing" guidelines.

What version of RN are you hitting this on? roundf takes in a float, so there would be precision loss when passing in a double. Perhaps you could import tgmath.h and use the version of round it exports?

This was being used on 0.37.0. I upgraded 0.39.1 today and it seems like the error disappeared without the roundf. It seems like this is a sporadic error and I don't necessarily understand the error message either. Do you think this still needs to be fixed? I can't seem to replicate the issue again.

We made some other changes to always consistently use floats when bridging to yoga/css-layout which may help. Feel free to open a new PR if you encounter this again.

@javache Same issue encounter for me
react-native 0.39.2
Invalid layout for (2858)<RCTView: 0x7fefec1c1240; reactTag: 2858; frame = (0 0; 329 22); layer = <CALayer: 0x610000627080>>. position: {nan, 11}. bounds: {{0, 0}, {nan, 22}}

@javache Can you please help me to figure out this issue's solution?

@joypatel04 Does this happen to a specific view/component? If you click 'Dismiss' it should show the view. I can try to figure it out if you send me the code for that view.

@Ajackster Here is my code so i figured that something is wrong in AccountsSummaryView's ListView like when i remove that LIstView and just render  {this.renderRecentActivities()} error goes away but with that ListView it show up.
AccountsSummaryView
renderRow(rowData) {
    return (<AccountSummary account={rowData} />);
}

renderRecentActivities() {
    return (<RecentActivityList list={this.state.recentTransactions} />);
}

render() {
    return (
        <View style={styles.container}>
            <ListView contentContainerStyle={[styles.contentContainer]} dataSource={this.state.dataSource}
                renderRow={this.renderRow.bind(this)} removeClippedSubviews={false} enableEmptySections={true} />
            {this.renderRecentActivities()}
        </View>
    );
}

RecentActivities
renderHeader(data) {
    /*global require:true*/
    /*eslint no-undef: "error"*/
    return (
        <View>
            <View style={styles.blankSpace}/>
            <View style={[styles.recentActivityWrapper]}>
                    <Text style={styles.sectionNameText}>
                        Recent Activity
                    </Text>
            </View>
        </View>
    );
}

renderRow(rowData) {
    return (<Transaction transaction={rowData} showCardInfo={true} showDate={true} onPress={() => this._gotoTransactionDetailView(rowData)} />);
}

render() {
    if (this.state.list.length > 0) {
        return (
            <View>
                <ListView
                    dataSource={this.state.dataSource}
                    renderRow={this.renderRow.bind(this)}
                    renderHeader={this.renderHeader.bind(this)}
                    removeClippedSubviews={false}
                    enableEmptySections={true} />
                <View style={{ padding: 15 }} />
            </View>
        );
    }
    else {
        return null;
    }
}

TabBar View
               <TabBar.Item
                    icon={require('../Images/tabBar/Accounts_Inactive.png') }
                    selectedIcon={require('../Images/tabBar/Accounts_Active.png') }
                    selectedTab={false}
                    navTextColor={'#455A64'}
                    navTextColorSelected={'#00BFA5'}
                    onPress={() => {
                    } }
                    title="Accounts">
                    <ScrollView>
                        <AccountsSummaryView />
                    </ScrollView>
                </TabBar.Item>

@joypatel04 I think the error is in your styles. This error seems to always happen at random times but it seems that using flexGrow instead of flex in a certain spot (Most likely where height or width have been declared) made the error go away. I recommend trying to switch out each flex with flexGrow one at a time so you can see which item is actually causing the error. Hopefully this fixes your problem.

@Ajackster That should be possible.
Let me try the way you said i'll let if i fixe the issue.
Thanks


The new saveAttachmetsMessagesBySubject () method

The new saveAttachmetsMessagesBySubject () method.
Use like
$imap->saveAttachmetsMessagesBySubject('Special tex');
or
$imap->saveAttachmetsMessagesBySubject('Special tex', 'path/to/save/attach', 'charset for special tex');

Thank you for your many many many contributions to this library. Many thanks to you. I'll merge after I do a quick run through of the code!


problems to define right color for tabs

Hi,
I just trying out the theme build and it worked very good so far. The only color which doesn't work for me is the color of mdTabs. I'm using following palette can somebody give me a hint what I miss out?
var tools = new MaterialTools({
  destination: './output',
  version: '1.1.0',
  //modules: ['menu', 'checkbox'],
  theme: {
    primaryPalette: 'light-blue',
    backgroundPalette: 'grey'
  },
  palettes: {
    'light-blue': {
    'hue-1': '100',
    'hue-2': '200',
    'hue-3': '300',
		'50':'E1F5FE',
		'100':'B3E5FC',
		'200':'81D4FA',
		'300':'4FC3F7',
		'400':'29B6F6',
		'500':'01579B',
		'600':'039BE5',
		'700':'0288D1',
		'800':'0277BD',
		'900':'01579B',
		'A100':'80D8FF',
		'A200':'40C4FF',
		'A400':'00B0FF',
		'A700':'0091EA',
		'contrastDefaultColor': 'light',
    'contrastDarkColors': ['50', '100', '200', '300', '400', 'A100', 'A200'],
    'contrastStrongLightColors': ['500', '600', '700', '800', '900', 'A400', 'A700']
    }
  }
});

This is how the style looks like:

This is actually an issue with Material. We have a pending fix for it at https://github.com/angular/material/pull/9484

Thanks @crisbeto for the quick reply


Central logout for indirect clients

Hello,
Here is my PR for my logout implementation.
What's still missing I think :

the control of the logout response => should it be a different callback controller ?
the generation of the SingleLogoutService in the SAML metadata
the logout that would be initiated by the IdP (any idea on how to do this, not sure the IdP would get access to the user session...)
NotOnOrAfter not set in the LogoutRequest
the way the SessionIndex is got does not seem very well done. Any idea if the SessionIndex should be stored somewhere else ? (in the context ?)

I used the IndirectClient. But I read somewhere (in the roadmap I think) that every clients should be migrated to the IndirectClient V2.
All comments are welcome !

Thanks for sharing this. I will review it.

Yes, all clients will be migrated to the IndirectClientV2 model: it means they use internal components (RedirectActionBuilder, CredentialsExtractor, Authenticator and ProfileCreator)  instead of relying on methods overriding. The SAML2Client still needs to be migrated. That said, it doesn't change much here.
I see your solution, here is mine (in progress, but the main parts are done): https://github.com/pac4j/pac4j/pull/760
To handle multi profiles (and thus multiple logout), I took a back-channel approach (direct calls from the application to the identity provider), but I realize this won't work as I don't have the identity providers cookies.
I also had in mind to keep the current logout behavior and redirect to an application page (post logout).
Your solution is better, but does not handle multi identity provider logout and I guess the final page is an IdP one, isn't it?
I guess multi profile is rather an edge use case so we can forget about it. We can logout from the first identity provider we found if ever this has been configured for that.
About the behavior, I guess it's hard to stay in the application as we'll need to call the identity provider logout.
@jkacer : what do you think of this (especially the SAML part)?
I'm going to think about it a little more, but currently, I'm in favor of merging your PR as is and fix the issues I see and reapply the good parts from my PR in a new one.

Hello!
It's quite a lot of new code, I did not fully review it but went over it several times. Overall, it looks fine to me.
Can I have just one question? How does the SP-initiated logout (this SP initiates it) and IdP-initiated logout (either the IdP or another SP via the IdP initiates it) differ here? Is logoutRedirect() called in both cases? I'm sorry, I'm little lost here. In one case, we should generate a logout request and get a logout response later, in the other case we should first get a logout request and generate a response later. The code probably does it because I see there is a request generator and response validator, I just cannot see how it is all linked together. Thank you!

@leleuj
I saw your solution. Not everything is clear for me. I have to have a look at it again.
For instance the final page is a static page, either on the IdP side, or on the SP side. Ideally I think there should be a callback again and we should check the logout response to see if it's a success or not, and then display a different page maybe (what I directly do). I tried to reuse the current callback controller, but it tries to get the credentials which it can't find since it's a logout response. Thus, I didn't know if it was better to create a different callback logic dedicated to the logout process or change the current one (that's how I came on the mailing list and saw your message ;-)).
I don't think it's a problem to get out of the application and go the IdP. However if we come back again to the application, maybe we can then deal with other profiles to logout. Again and again until all profiles have been log out.
@jkacer
No, here just the SP-initiated logout is managed. For the IdP-initiated logout I'm not really sure on how we can do it. The URL should be called by the IdP itself. Thus it won't have access to the user session (no cookies, etc), or ? And to argue about what I said before, it's maybe better to have a different callback logic that can deal with a logout response (SP-initiated logout) and a logout request (IdP-initiated logout). Otherwise the current callback logic may look horrible.
I created the logout response validator in order to be symmetric with the login process. However it's not used yet if I remember well. The link that is missing is the callback logic.

OK. I see your point with the callback controller. Indeed, we need some receiver for the IdP-initiated logout.
And we want to reuse the callback controller as we don't want to ask people to define another filter.
For CAS, we use the callback filter and thanks to the logoutRequest parameter, we know if it's a callback for the login process or for the logout process. This is done by the appropriate credentials extractor: https://github.com/pac4j/pac4j/blob/master/pac4j-cas/src/main/java/org/pac4j/cas/credentials/extractor/TicketAndLogoutRequestExtractor.java#L56
So the left question with SAML is: can you distinguish the logout request from the login one if both are sent to the callback endpoint?
"However if we come back again to the application, maybe we can then deal with other profiles to logout.": that's an excellent idea, although it may become really complicated (that is, just removing the current profile). But I'll think about it anyway.
My plan remains unchanged:

Next week, merge this PR in unless there is still some work in progress
Then, refactor things a bit
Upgrade j2e-pac4j with pac4j v2.0.0-SNAPSHOT and let Jaroslav finish the SAML support

Thank you for the explanation, @taggiasco !

I merged your PR and re-started changes on a new PR. I'll ping you when ready.

@taggiasco @jkacer I closed my PR and opened a new one, please take a look: https://github.com/pac4j/pac4j/pull/764


scrollToEnd is not a function when i use custom SendTextBox

When i use a custom TextBox created with connectSendTextBox on onKeyPress Enter, an error "scrollToEnd is not a function" appears.
export default connectSendTextBox()((connect) => {
  return (
    <input
      onChange={connect.onChange}
      onKeyPress={connect.onKeyPress}
      type="text" />
  )
});

Thank you for the report, @ShtirlicC4
I'm not sure I'll be able to reproduce the problem using only the information you've provided. Can you link to any samples or documentation you've followed?

Hi.
i used "botframework-webchat": "^4.5.1" after updated to 4.10 version i get this error.
I write message in my custom textBox component and press Enter, after that in console an error with this text appears
scrollToEnd is not a function at onKeyPress (TextBox.js:266) and etc.
Sorry but i can`t find tutorial anymore, before with botframework-webchat: "4.5.1" i used that method connectSendTextBox
my code looks something like that:
import ReactWebChat, { Components, createBrowserWebSpeechPonyfillFactory } from 'botframework-webchat';
const { Composer, SuggestedActions } = Components;
const webChatCreateDirectLine = (options) => {
  webChatDirectLine = createDirectLine({
    ...options,
    webSpeechPonyfillFactory: createBrowserWebSpeechPonyfillFactory()
  });
};
const CustomSendBox connectSendTextBox()((connect: any) => {
  const value = connect.store.getState().sendBoxValue;
  const onFocus = () => widgetStore.dispatch(abortProactivity());
  return (
    <input
      value={value}
      onChange={connect.onChange}
      onKeyPress={connect.onKeyPress}
      type="text" />
	);
});
class WebChat extends React.Component {
	render() {
		return (
		    <ReactWebChat
				directLine={webChatDirectLine}
				locale="en-US"
			/>
			<Composer
              directLine={webChatDirectLine}
              locale="en-US"
			>
				<CustomSendBox />
            </Composer>);
		}
	}

}

@ShtirlicC4 - Your code doesn't seem to be valid JSX. Is that the actual code you're trying to run or did you perhaps not copy and paste it correctly?

@ShtirlicC4 - Are you still working on this?

I am closing this issue due to inactivity. We are still happy to provide help if you need any, though it may be a good idea to make a new post if that's the case. Please have a look at this to find out the best places to ask for help, and consider asking questions on Stack Overflow.


Tagging asset releases

Looks like a lot is happening for 0.5.0 in #47 but is there a way I can use the tagging adapters in an asset adapter right now?
The problem I'm having right now is the S3 asset adapter simply uploads the newly fingerprinted assets to the same folder over and over again with no mechanism to clean up older releases. I end up with lots of app-fingerprint.js and vendor-fingerprint.js files on S3.
Ideally I'd like a way to upload asset releases to a sub directory named the same as the tag, so
bucket/app:sha/assets/vendor.js
bucket/app:sha/assets/app.js

Not sure if I should've raised this in the ember-deploy-s3 repo? I had a look at the source but it looks like asset-adapters don't get given the default tagging adapter?

Thanks for raising this issue.
As you noted, to keep the ember-cli-deploy repo issues cleaner it would be better to raise plugin specific issues in their respective issue trackers.
Concerning your question. It is actually by design that old releases don't get cleaned up.

S3 Hosting is 'cheap' and there is no need to clean them up
It is not that trivial to know which assets to clean up because assets only change their fingerprint when the underlying file changes and thus index.html may reference 'old' asset-files.
It is easier to rollback when old assets are still available in your app's asset bucket.

I get why some people may think it was important to clean up their assets but I don't think you get much benefit by doing so because:
a) It's hard to do in the happy path (only vendor.js, app.js etc.) :trollface:
b) It get's really hard when throwing other assets like language-files, svgs into the mix that are referenced inside app.js
c) Your suggested approach by referencing app:sha in the asset urls would need rewrite the prepend option in the app's fingerprint-options dynamically when doing the ember build
d) If you decide to go down this route because you plan on saving money by implementing this approach I think it may be the case that you'd need to upload more files because you'd always need to sync all the assets into the app:sha-directories inside your bucket. And that are actually more files uploaded than would be necessary when just dumping everything in one bucket.
If you nevertheless feel that this is an asset-upload strategy worth pursuing (which may be the case for your specific needs) I suggest to implement this in a different asset-upload-plugin because this would need a pretty different approach for uploading files than ember-deploy-s3 and I think it's best to keep different upload strategies in different plugins.

Closing since 0.5 is out now. If this issue is still of value, please open one against the new ember-cli-deploy-s3 plugin: https://github.com/ember-cli-deploy/ember-cli-deploy-s3


Differentiate between commit SHA and tag SHA

Is your feature request related to a problem? Please describe.
Related to my question/issue https://github.com/actions/checkout/issues/874. As described there, we had pinned an Action like so:
    - name: Checkout repository
      uses: actions/checkout@d0651293c4a5a52e711f25b41b05b2212f385d28

where d065129 was an annotated tag named v3 and not an existing commit. Furthermore, folks rewrite that tag whenever a new version 3 is released so that that “pin” isn’t really a pin at all.
Describe the solution you'd like
Warn me if a SHA is not a commit SHA, i.e. if the pin can be redirected.
Describe alternatives you've considered
Manually cross-checking that the pinned Actions actually reference commit SHAs.
Additional context
Pretty please?

This would be a nice improvement. Can you give an example repository? I'm not following the part that d065129 was an annotated tag named v3. The annotated tag is an object, so its commit hash would change if there was a force push to update it, no?
(I've not fiddled enough with annotated tags, so please bear with me :)

Can you give an example repository?

If you take a look at the actions/checkout repository you’ll see that there is no commit d065129. However, there is a tag named v3 whose SHA d065129 “points at” (references, aliases, I’m unsure) a different commit whenever there’s an update.
I’m waiting for a response to that discussion in issue https://github.com/actions/checkout/issues/874#issuecomment-1207172111…

Uhm. Ping?

Hmm, this is similar to #2733, and a result of a GitHub implementation detail.
@laurentsimon  I'm curious if we should have these API intensive tasks available as additional probes for people to run when needed, just not by default.

Yes, this would entirely defeat the purpose of a pinned GitHub Action. Hmm, this is similar to #2733, and a result of a GitHub implementation detail.
@laurentsimon I'm curious if we should have these API intensive tasks available as additional probes for people to run when needed, just not by default.

+1 on having a probe for it.


How to enable Charts in Dashboard and also change colors

Hello, I recently discovered this admin template through a youtube channel and was deeply impressed with it. What a lovely clean design. I've setup most of the functionality using the repo examples you provided in the readme but I've ran into some sort of issue.
I'm trying to modify the base colour for the UI to blue and then display charts in the dashboard but I don't know how to go about it.

I recommend starting with the documentation:
https://github.com/unfoldadmin/django-unfold?tab=readme-ov-file#available-settingspy-options
https://github.com/unfoldadmin/django-unfold?tab=readme-ov-file#admin-dashboard


Can't disable/remove extension

Cannot disable extension 'LanguageTool for Visual Studio Code'. Extension 'English Support for LanguageTool' depends on this.
Now, this package is not visible in the list of extensions.....

Please see #25.


Major performance increase Audio Fixes

I got some cycles to go through my cores and a user pointed me back to your cores in https://github.com/linuxserver/docker-emulatorjs/issues/59.
Ethan at EmulatorJS discovered that rwebaudio was blocking the thread and causing slowdowns a bit ago:
https://github.com/libretro/RetroArch/pull/15479
That was one part of the puzzle. Then in later versions of Retroarch ( I am using the current release) they implemented resampling quality along with the playback rate on top of using openal audio. The final missing piece was bumping it down and using 44100 for Chrome and Safari merged here:
https://github.com/libretro/RetroArch/pull/16079
I went ahead and used your instructions to get 99% of the way to a core for the current release with these default setting patched in (great work btw on docs) and this is your current n64 core:
https://github.com/BinBashBanana/webretro/assets/1852688/fdeda31e-c638-4248-bfe3-53009622ae6e
And the new one built with the same logic for mupen but updated retroarch and default audio settings:
https://github.com/BinBashBanana/webretro/assets/1852688/84ad8bbc-340e-4791-b1dd-24d440ac5f85

Awesome!! I really gotta get back on this project. First off I want to get upstream compatibility -- hopefully that means getting a bunch of stuff merged -- then I want to see about dynamic linking. Thank you for this!

 Would be nice to ingest directly from libretro for the most part.
We should try to get a pipeline setup in github workflow to spit this stuff out with git submodules and patches initially.
I started on that when I went on a build spree this weekend, but it devolved into copies of folders all over the place as I had to keep moving around what emsdk I was using and modifying the retroarch repo to play nice with the specific core.

Might be worth modifying my build script
I can also give y'all the bash script I use for my nightly cores if y'all want. I also do package my own version of emscripten (debian) so its easier for me to manage.
Just some suggestions!

Might be worth modifying my build script
I can also give y'all the bash script I use for my nightly core builds if y'all want. I also do package my own version of emscripten (debian) so its easier for me to manage.
Just some suggestions!

When it comes to the cores we are all on the same page I feel like, it only really gets divergent when it hits the retroarch project where I want pure cores, emulatorjs hooks in and externalizes all functions, and webretro does lighter externalization.
Some cores are easy, but many are way over my head as to how you would achieve homology with the other ports like mupen64 and beetle-psx. Optimally libretro would be spitting out the bc files and forking would happen from there for frontends.
The only changes I make on my side really is on beetle-psx crippling PGXP as it needs like 500 megs of ram and makes it impossible to load full games properly on most device browsers.
https://github.com/thelamer/beetle-psx-libretro/commit/22f48c2786c96fd0b3692816e993eadc921b9cd8
Other than that the webretro patches and emulatorjs forks do way more to ensure compatibility with emscripten.


Disable logging until needed

Would it be possible to have a setting to disable logging until needed? Currently two lines are written to the log file in addons every X number of seconds (depending on when the refresh occurs). I'd like to see if we can disable until needed to troubleshoot a problem.

Why do you need this feature ?

They cause a lot of sd card access and provide no value. I have no issue with warnings and errors being logged but would expect traces like these to only be needed if I enabled debugging.

This option is available starting version v1.8.7. Please test!

Works wonderfully! Thanks for the work you do.


Pause Animation Progress (Duration)

How to pause animation progress with action button?

You can use StoryAnimationController.

Please how does it work? @santa112358
I tried with "indicatorAnimationController.value = IndicatorAnimationCommand.pause;" but dont work

same issue


Lazy render bootstrap-select

Our pages were loading super slow when they had lots of big bootstrap-selects on them,
so I switched it to only actually go through all the work when the element is clicked.
This seems like a simple fix that could solve lots of the performance issues I saw here.
  function convertToLiveSelect(select){
    return $(select)
      .addClass("selectpicker") // hide select and apply styles
      .selectpicker() // apply select picker
  }

  // user tabs into select (and will press down/space next)
  $(".lazy-selectpicker:not(.selectpicker)").one("focus", function(){
    convertToLiveSelect(this)
      .focus(); // focus new element instead
  });

  // user clicks on select
  $(".lazy-selectpicker:not(.selectpicker)").one("mousedown", function(e){
    e.preventDefault(); // do not open real select
    convertToLiveSelect(this)
      .next().click(); // trigger selectpicker
  });

  // multiselects look bad when not rendered
  $(".lazy-selectpicker[multiple]").unbind("mousedown").selectpicker();

While this exact feature hasn't been added, offloading the initial data calculation via a setTimeout allows the button elements and the rest of the page to load quickly. For large selects, the time in which lazy rendering would really be of benefit, the delay in opening the menu would be too great. If people are still running into issues, let me know and I can reopen this issue and address it in a future release. Otherwise, considering this released in v1.13.6!


Its difficult to drag the RangeSlider Thumb

Look like the slider's thumb are outside the track or the whole widget is too small

Hi @RomanJos
can you please provide your flutter doctor -v and flutter run --verbose?
Also, to better address the issue, would be helpful if you could post a minimal code sample to reproduce the problem
Thank you

CC @clocksmith @JoseAlba

Hi, I don't think running doctor or run with --verbose will help you much, to test you can just take the default range slider. I believe the problem come from the fact that the Thumb are centered on the edges of the track and the track define the size of the slider so the Thumb overflow and thus don't take any input

Hi @RomanJos
I have created this code sample to demonstrate the issue and it does go beyond the track

Code Sample
import 'dart:math';

import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatefulWidget {
  @override
  _MyAppState createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  double _starValue = 10;
  double _endValue = 80;

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData(
          sliderTheme: Theme.of(context).sliderTheme.copyWith(
                trackHeight: 22.0,
                trackShape: RoundSliderTrackShape(),
                activeTrackColor: Colors.green,
                // trackShape: RectangularSliderTrackShape(),
              )),
      home: Scaffold(
        appBar: AppBar(
          title: Text('Material App Bar'),
        ),
        body: Center(
          child: RangeSlider(
            values: RangeValues(_starValue, _endValue),
            min: 0.0,
            max: 100.0,
            onChanged: (values) {
              setState(() {
                _starValue = values.start.roundToDouble();
                _endValue = values.end.roundToDouble();
              });
            },
          ),
        ),
      ),
    );
  }
}

class RoundSliderTrackShape extends SliderTrackShape {
  /// Create a slider track that draws 2 rectangles.
  const RoundSliderTrackShape({this.disabledThumbGapWidth = 2.0});

  /// Horizontal spacing, or gap, between the disabled thumb and the track.
  ///
  /// This is only used when the slider is disabled. There is no gap around
  /// the thumb and any part of the track when the slider is enabled. The
  /// Material spec defaults this gap width 2, which is half of the disabled
  /// thumb radius.
  final double disabledThumbGapWidth;

  @override
  Rect getPreferredRect({
    RenderBox parentBox,
    Offset offset = Offset.zero,
    SliderThemeData sliderTheme,
    bool isEnabled,
    bool isDiscrete,
  }) {
    final double overlayWidth =
        sliderTheme.overlayShape.getPreferredSize(isEnabled, isDiscrete).width;
    final double trackHeight = sliderTheme.trackHeight;
    assert(overlayWidth >= 0);
    assert(trackHeight >= 0);
    assert(parentBox.size.width >= overlayWidth);
    assert(parentBox.size.height >= trackHeight);

    final double trackLeft = offset.dx + overlayWidth / 2;
    final double trackTop =
        offset.dy + (parentBox.size.height - trackHeight) / 2;
    // TODO(clocksmith): Although this works for a material, perhaps the default
    // rectangular track should be padded not just by the overlay, but by the
    // max of the thumb and the overlay, in case there is no overlay.
    final double trackWidth = parentBox.size.width - overlayWidth;
    return Rect.fromLTWH(trackLeft, trackTop, trackWidth, trackHeight);
  }

  @override
  void paint(
    PaintingContext context,
    Offset offset, {
    RenderBox parentBox,
    SliderThemeData sliderTheme,
    Animation<double> enableAnimation,
    TextDirection textDirection,
    Offset thumbCenter,
    bool isDiscrete,
    bool isEnabled,
  }) {
    // If the slider track height is 0, then it makes no difference whether the
    // track is painted or not, therefore the painting can be a no-op.
    if (sliderTheme.trackHeight == 0) {
      return;
    }

    // Assign the track segment paints, which are left: active, right: inactive,
    // but reversed for right to left text.
    final ColorTween activeTrackColorTween = ColorTween(
        begin: sliderTheme.disabledActiveTrackColor,
        end: sliderTheme.activeTrackColor);
    final ColorTween inactiveTrackColorTween = ColorTween(
        begin: sliderTheme.disabledInactiveTrackColor,
        end: sliderTheme.inactiveTrackColor);
    final Paint activePaint = Paint()
      ..color = activeTrackColorTween.evaluate(enableAnimation);
    final Paint inactivePaint = Paint()
      ..color = inactiveTrackColorTween.evaluate(enableAnimation);
    Paint leftTrackPaint;
    Paint rightTrackPaint;
    switch (textDirection) {
      case TextDirection.ltr:
        leftTrackPaint = activePaint;
        rightTrackPaint = inactivePaint;
        break;
      case TextDirection.rtl:
        leftTrackPaint = inactivePaint;
        rightTrackPaint = activePaint;
        break;
    }

    // Used to create a gap around the thumb iff the slider is disabled.
    // If the slider is enabled, the track can be drawn beneath the thumb
    // without a gap. But when the slider is disabled, the track is shortened
    // and this gap helps determine how much shorter it should be.
    // TODO(clocksmith): The new Material spec has a gray circle in place of this gap.
    double horizontalAdjustment = 0.0;
    if (!isEnabled) {
      final double disabledThumbRadius =
          sliderTheme.thumbShape.getPreferredSize(false, isDiscrete).width /
              2.0;
      final double gap = disabledThumbGapWidth * (1.0 - enableAnimation.value);
      horizontalAdjustment = disabledThumbRadius + gap;
    }

    final Rect trackRect = getPreferredRect(
      parentBox: parentBox,
      offset: offset,
      sliderTheme: sliderTheme,
      isEnabled: isEnabled,
      isDiscrete: isDiscrete,
    );
    final Rect leftTrackSegment = Rect.fromLTRB(trackRect.left, trackRect.top,
        thumbCenter.dx - horizontalAdjustment, trackRect.bottom);

    // Left Arc
    context.canvas.drawArc(
        Rect.fromCircle(
            center: Offset(trackRect.left, trackRect.top + 11.0), radius: 11.0),
        -pi * 3 / 2, // -270 degrees
        pi, // 180 degrees
        false,
        trackRect.left - thumbCenter.dx == 0.0
            ? rightTrackPaint
            : leftTrackPaint);

    // Right Arc
    context.canvas.drawArc(
        Rect.fromCircle(
            center: Offset(trackRect.right, trackRect.top + 11.0),
            radius: 11.0),
        -pi / 2, // -90 degrees
        pi, // 180 degrees
        false,
        trackRect.right - thumbCenter.dx == 0.0
            ? leftTrackPaint
            : rightTrackPaint);

    context.canvas.drawRect(leftTrackSegment, leftTrackPaint);
    final Rect rightTrackSegment = Rect.fromLTRB(
        thumbCenter.dx + horizontalAdjustment,
        trackRect.top,
        trackRect.right,
        trackRect.bottom);
    context.canvas.drawRect(rightTrackSegment, rightTrackPaint);
  }
}

flutter doctor -v
[✓] Flutter (Channel dev, 1.18.0-12.0.pre, on Mac OS X 10.15.4 19E287, locale
    en-GB)
    • Flutter version 1.18.0-12.0.pre at /Users/tahatesser/Code/flutter_dev
    • Framework revision c2b7342ca4 (17 hours ago), 2020-05-06 23:16:03 +0800
    • Engine revision 33d2367950
    • Dart version 2.9.0 (build 2.9.0-5.0.dev 9c94f08410)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/tahatesser/Code/SDK
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/tahatesser/Code/SDK
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4.1, Build version 11E503a
    • CocoaPods version 1.9.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.44.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.10.1

[✓] Connected device (5 available)
    • Taha’s iPhone • 00008020-001059882212002E            • ios            •
      iOS 13.4.1
    • iPhone 11     • B00B6F4E-B1CE-44F3-B81E-3EC6D639B008 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-13-4 (simulator)
    • macOS         • macOS                                • darwin-x64     •
      Mac OS X 10.15.4 19E287
    • Web Server    • web-server                           • web-javascript •
      Flutter Tools
    • Chrome        • chrome                               • web-javascript •
      Google Chrome 81.0.4044.138

• No issues found!

Hi @RomanJos
I have created this code sample to demonstrate the issue and it does go beyond the track

Code Sample
import 'dart:math';

import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatefulWidget {
  @override
  _MyAppState createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {
  double _starValue = 10;
  double _endValue = 80;

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData(
          sliderTheme: Theme.of(context).sliderTheme.copyWith(
                trackHeight: 22.0,
                trackShape: RoundSliderTrackShape(),
                activeTrackColor: Colors.green,
                // trackShape: RectangularSliderTrackShape(),
              )),
      home: Scaffold(
        appBar: AppBar(
          title: Text('Material App Bar'),
        ),
        body: Center(
          child: RangeSlider(
            values: RangeValues(_starValue, _endValue),
            min: 0.0,
            max: 100.0,
            onChanged: (values) {
              setState(() {
                _starValue = values.start.roundToDouble();
                _endValue = values.end.roundToDouble();
              });
            },
          ),
        ),
      ),
    );
  }
}

class RoundSliderTrackShape extends SliderTrackShape {
  /// Create a slider track that draws 2 rectangles.
  const RoundSliderTrackShape({this.disabledThumbGapWidth = 2.0});

  /// Horizontal spacing, or gap, between the disabled thumb and the track.
  ///
  /// This is only used when the slider is disabled. There is no gap around
  /// the thumb and any part of the track when the slider is enabled. The
  /// Material spec defaults this gap width 2, which is half of the disabled
  /// thumb radius.
  final double disabledThumbGapWidth;

  @override
  Rect getPreferredRect({
    RenderBox parentBox,
    Offset offset = Offset.zero,
    SliderThemeData sliderTheme,
    bool isEnabled,
    bool isDiscrete,
  }) {
    final double overlayWidth =
        sliderTheme.overlayShape.getPreferredSize(isEnabled, isDiscrete).width;
    final double trackHeight = sliderTheme.trackHeight;
    assert(overlayWidth >= 0);
    assert(trackHeight >= 0);
    assert(parentBox.size.width >= overlayWidth);
    assert(parentBox.size.height >= trackHeight);

    final double trackLeft = offset.dx + overlayWidth / 2;
    final double trackTop =
        offset.dy + (parentBox.size.height - trackHeight) / 2;
    // TODO(clocksmith): Although this works for a material, perhaps the default
    // rectangular track should be padded not just by the overlay, but by the
    // max of the thumb and the overlay, in case there is no overlay.
    final double trackWidth = parentBox.size.width - overlayWidth;
    return Rect.fromLTWH(trackLeft, trackTop, trackWidth, trackHeight);
  }

  @override
  void paint(
    PaintingContext context,
    Offset offset, {
    RenderBox parentBox,
    SliderThemeData sliderTheme,
    Animation<double> enableAnimation,
    TextDirection textDirection,
    Offset thumbCenter,
    bool isDiscrete,
    bool isEnabled,
  }) {
    // If the slider track height is 0, then it makes no difference whether the
    // track is painted or not, therefore the painting can be a no-op.
    if (sliderTheme.trackHeight == 0) {
      return;
    }

    // Assign the track segment paints, which are left: active, right: inactive,
    // but reversed for right to left text.
    final ColorTween activeTrackColorTween = ColorTween(
        begin: sliderTheme.disabledActiveTrackColor,
        end: sliderTheme.activeTrackColor);
    final ColorTween inactiveTrackColorTween = ColorTween(
        begin: sliderTheme.disabledInactiveTrackColor,
        end: sliderTheme.inactiveTrackColor);
    final Paint activePaint = Paint()
      ..color = activeTrackColorTween.evaluate(enableAnimation);
    final Paint inactivePaint = Paint()
      ..color = inactiveTrackColorTween.evaluate(enableAnimation);
    Paint leftTrackPaint;
    Paint rightTrackPaint;
    switch (textDirection) {
      case TextDirection.ltr:
        leftTrackPaint = activePaint;
        rightTrackPaint = inactivePaint;
        break;
      case TextDirection.rtl:
        leftTrackPaint = inactivePaint;
        rightTrackPaint = activePaint;
        break;
    }

    // Used to create a gap around the thumb iff the slider is disabled.
    // If the slider is enabled, the track can be drawn beneath the thumb
    // without a gap. But when the slider is disabled, the track is shortened
    // and this gap helps determine how much shorter it should be.
    // TODO(clocksmith): The new Material spec has a gray circle in place of this gap.
    double horizontalAdjustment = 0.0;
    if (!isEnabled) {
      final double disabledThumbRadius =
          sliderTheme.thumbShape.getPreferredSize(false, isDiscrete).width /
              2.0;
      final double gap = disabledThumbGapWidth * (1.0 - enableAnimation.value);
      horizontalAdjustment = disabledThumbRadius + gap;
    }

    final Rect trackRect = getPreferredRect(
      parentBox: parentBox,
      offset: offset,
      sliderTheme: sliderTheme,
      isEnabled: isEnabled,
      isDiscrete: isDiscrete,
    );
    final Rect leftTrackSegment = Rect.fromLTRB(trackRect.left, trackRect.top,
        thumbCenter.dx - horizontalAdjustment, trackRect.bottom);

    // Left Arc
    context.canvas.drawArc(
        Rect.fromCircle(
            center: Offset(trackRect.left, trackRect.top + 11.0), radius: 11.0),
        -pi * 3 / 2, // -270 degrees
        pi, // 180 degrees
        false,
        trackRect.left - thumbCenter.dx == 0.0
            ? rightTrackPaint
            : leftTrackPaint);

    // Right Arc
    context.canvas.drawArc(
        Rect.fromCircle(
            center: Offset(trackRect.right, trackRect.top + 11.0),
            radius: 11.0),
        -pi / 2, // -90 degrees
        pi, // 180 degrees
        false,
        trackRect.right - thumbCenter.dx == 0.0
            ? leftTrackPaint
            : rightTrackPaint);

    context.canvas.drawRect(leftTrackSegment, leftTrackPaint);
    final Rect rightTrackSegment = Rect.fromLTRB(
        thumbCenter.dx + horizontalAdjustment,
        trackRect.top,
        trackRect.right,
        trackRect.bottom);
    context.canvas.drawRect(rightTrackSegment, rightTrackPaint);
  }
}

flutter doctor -v
[✓] Flutter (Channel dev, 1.18.0-12.0.pre, on Mac OS X 10.15.4 19E287, locale
    en-GB)
    • Flutter version 1.18.0-12.0.pre at /Users/tahatesser/Code/flutter_dev
    • Framework revision c2b7342ca4 (17 hours ago), 2020-05-06 23:16:03 +0800
    • Engine revision 33d2367950
    • Dart version 2.9.0 (build 2.9.0-5.0.dev 9c94f08410)

[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
    • Android SDK at /Users/tahatesser/Code/SDK
    • Platform android-29, build-tools 29.0.3
    • ANDROID_HOME = /Users/tahatesser/Code/SDK
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.4.1, Build version 11E503a
    • CocoaPods version 1.9.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 3.6)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 45.1.1
    • Dart plugin version 192.7761
    • Java version OpenJDK Runtime Environment (build
      1.8.0_212-release-1586-b4-5784211)

[✓] VS Code (version 1.44.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.10.1

[✓] Connected device (5 available)
    • Taha’s iPhone • 00008020-001059882212002E            • ios            •
      iOS 13.4.1
    • iPhone 11     • B00B6F4E-B1CE-44F3-B81E-3EC6D639B008 • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-13-4 (simulator)
    • macOS         • macOS                                • darwin-x64     •
      Mac OS X 10.15.4 19E287
    • Web Server    • web-server                           • web-javascript •
      Flutter Tools
    • Chrome        • chrome                               • web-javascript •
      Google Chrome 81.0.4044.138

• No issues found!

I believe the issue was fixed with https://github.com/flutter/flutter/pull/55857
Previously the Slider thumb wasn't part of Slider track but that fixed with this PR. I tried reproducing the error but wasn't able.
I noticed that the flutter version to produce this error was not running the new changes to 'slider v2'.
Have you tried updating the Flutter channel to dev or master? The change isn't on beta or stable yet. But switching to these channels might fix the error you are having.
@ RomanJos
@TahaTesser
To learn more about the PR you can read: https://flutter.dev/go/slider-v2


MB 3930 Progress Bar Mobile Styling

Description
This PR adds styling to improve the readability  of the status bar in mobile screen widths.
Reviewer Notes
This PR is in progress. We need to decide whether or not we can remove the "approved" step from the bar. If it has to stay, more work will need to be done ahead of being ready to merge
Setup
yarn install
yarn storybook

or
make db_dev_e2e_populate
make server_run
make client_run

and on milmovelocal:3000:

click Local Sign In
select a user fomr the list who did their inital account setup already. I used<EMAIL_ADDRESS>(milmove)
That will take you to a page where the status bar lives.

Code Review Verification Steps

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Screenshots

with all items in status bar

with approved item removed

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

:warning:

Files located in legacy directories (src/shared or src/scenes) have
been edited. Are you sure you don’t want to also relocate them to the new file structure?
View the frontend file org ADR for more information

:warning:
Please add the JIRA issue key to the PR title (e.g. MB-123)

  Generated by :no_entry_sign: dangerJS against 9b8f667207b9dbf673e07cbef4dff845476b8981

pushing an update that will make it look like the below screenshots. I left the Approve step in because it was going to be a lot of work to pull it out, and update tests to reflect it not being there.

mobile

desktop


Add Secret key and Unittest

What have I done.

Created a GitHub workflow test script.

What's next

Currently waiting for the Django secret key to be added to the repo's secret.


Add C++ support

This is definitely useful, but should be created in it's own repo under https://github.com/opentracing-contrib/
@rnburn may take this on soon, but we always welcome community contributions if you would like to take a shot at it @calder.

why  java,py,go in this repo? but c++ in other repo?

All the languages are being moved into separate repos: python, go, java


Update love.yml

Hi, thank you very much for your pull request! We now have a new website, so we will not continue to maintain the old website, please check marsble/statically-web maybe you are more interested in helping this one, cheers!


Error while trying to use Beaver on Windows

When I try to use Beaver in my project on Windows, I got following errors:
> iex.bat -S mix
Erlang/OTP 27 [erts-15.1] [source] [64-bit] [smp:32:32] [ds:32:32:10] [async-threads:1] [jit:ns]

==> beaver
could not compile dependency :beaver, "mix compile" failed. Errors may have been logged above. You can recompile this dependency with "mix deps.compile beaver --force", update it with "mix deps.update beaver" or clean it with "mix deps.clean beaver"
** (FunctionClauseError) no function clause matching in Kinda.Precompiler.current_target/1

    The following arguments were given to Kinda.Precompiler.current_target/1:

        # 1
        {:win32, :nt}

    Attempted function clauses (showing 1 out of 1):

        def current_target({:unix, _})

    (kinda 0.9.2) Kinda.Precompiler.current_target/1
    (elixir_make 0.8.4) lib/elixir_make/artefact.ex:252: ElixirMake.Artefact.current_target_url/3
    (elixir_make 0.8.4) lib/mix/tasks/compile.elixir_make.ex:220: Mix.Tasks.Compile.ElixirMake.download_or_reuse_nif/3
    (elixir_make 0.8.4) lib/mix/tasks/compile.elixir_make.ex:165: Mix.Tasks.Compile.ElixirMake.run/1
    (mix 1.17.3) lib/mix/task.ex:495: anonymous fn/3 in Mix.Task.run_task/5
    (mix 1.17.3) lib/mix/tasks/compile.all.ex:108: Mix.Tasks.Compile.All.run_compiler/2
    (mix 1.17.3) lib/mix/tasks/compile.all.ex:88: Mix.Tasks.Compile.All.compile/4
    (mix 1.17.3) lib/mix/tasks/compile.all.ex:62: Mix.Tasks.Compile.All.run/1

Also I've spotted the following code in Kinda:
  @impl ElixirMake.Precompiler
  def all_supported_targets(:fetch) do
    ~w(
      aarch64-apple-darwin
      x86_64-linux-gnu
    )
  end

Is Beaver doesn't support Windows?

Is Beaver doesn't support Windows?

With some changes on Kinda and Beaver it should be possible to support Windows. The error you posted is about the absence of Windows prebuild of Beaver+LLVM/MLIR shared library. You can trigger a source build with system env BEAVER_BUILD_CMAKE=1 (it might fail for some other reasons)
Very welcome if you can send a PR to get Windows build working and we can make the prebuild as a regular one like those for Linux and macOS. You can also give me some more information about what kind of Windows setup you are running (like C/C++ compilers etc), so I can try to install and reproduce build failures.


V7.21.0 branch

Changes

Documentation update for releases (what's needed for PRs and where to bump versions in files)
Adding features for overriding default :latest tag in docker scripts (User Contrib)

awaiting merges from another branch to release this


Immutable Collections

This is what it looks like when the tool is run on a /src folder where the solution already contains XML doc comments.  In this case, the only changes made were the simplification of a few crefs on public APIs.
/cc @mairaw @joshfree

👍


prepare v0.2 release

This PR fixes an issue with the provided AirScript example (random values weren't declared) and bumps versions and dependencies for the v0.2 release.

Thanks for the review @tohrnii, I updated the formatting


[Bug]: Columns in the property pane changes on repeated clicking. Focused state color is black

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When I click on any of the columns in the columns property of the table widget repeatedly, then the columns change their position automatically i.e. columns swap automatically.
Also, it is observed that the focused state color has changed to black, as previously it was orange.
Please find below for your reference the video for this issue:
https://loom.com/share/c06009491e534d499abfe9fff912c4c2
Steps To Reproduce

Drag and drop the table widget.
Go to the columns property in the property pane.
Click repeatedly on any of the rows.
Observe that they gets swapped automatically.
Also observe the focused state color of the row which is selected in this property.

Environment
Release
Version
Cloud

Having trouble reproducing, checking with @keyurparalkar

Ok, not reproducible in production but in release and dp. I guess we broke something in this component itself as this issue is also reproducible in tabs. Can we please prioritise this? else I guess this will impact production next @somangshu @sbalaji1192

@dilippitchika +1

@aswathkk is this related to any property pane changes, Kindly check!
@keyurparalkar its the position of the cursor which updates and not the tile itself. Also I think the black border is intended as before this it seemed like there is some error in the tile. @vasanth-appsmith can confirm this.
@vicky-primathon has your change related to tile repositioning gone in? Please check if that is true and this is related.

related to #10030

This change has been repeated, We will take this up with the actual implementation for the next release


how to understand dataset?

Hello, what does the number after Flow Sequence-F1-L1 mean in the file “data.json”, and what does the data after Processing Time-F1-L1 mean? How to assign a value.

F1 stands for flow 1 .
F1 as flow passes through Links L1, L2...
The dataset basically is a set of sequences used by algorithm to perform initial population.

Is there any paper on this code? What metrics do you use to evaluate model performance?


ViewBox minion

How to make minion collected mass over the WHOLE/ALL map, and not in the area I see?

No custom code allowed
@Fan7asy

Please... help

This is an issues section my man, any suggestions post it in the discord :P

You do realize that minions do that already, right @DeadLord1337?

@Agarian They do not do this, they do not collect mass all over the map, but only in my field of vision...

If you're talking about a large amount of minions, then yes, I believe that's to same memory.


config file not correct

I get this message about once a second in my console window:
[15:51:20] [Thread-0/WARN] [ne.mi.fm.co.ConfigFileTypeHandler/CONFIG]: Configuration file F:\GAMES\Minecraft\MultiMC\instances\BeanPunk\minecraft\config\sapience-common.toml is not correct. Correcting

Can you try running this mod either via the Curseforge launcher or some other means and confirm if the issue still persists? That should only be sent once per instance of a game.

I'm running minecraft through the game launcher, and am having the same issue.

I have this issue as well. It writes 5 new identical .toml.bak files with decreasing frequency before freezing up completely until I force quit the program.
Using the official launcher, and mod version 1.18.2 - 1.0.0

I can confirm the bug, I have the same message every 10seconds, spamming the console
1.18.2 - 1.0.0, tried to delete the conf but without a change
Using LITV3 modpack

Log file.txt
attached a logfile of this issue.
Steps to replicate:
1: create a forge server instance for 1.18.2 / 40.1.84
2: add the 1.18.2 1.00 mod version to the pack
3: run server
this was done to attempt to isolate it from the other mods in the LITV3 pack, there this error also occurs in the server package.

Same issue here, except in 1.19.2.

Alright, I believe I've found a fix (pending some testing). I'll fix it in latest first (1.19.4), then bring it all the way downstream to 1.18.

@HoneyspringsBw and anyone else playing on 1.19.2, can you try this build out and see if it fixes the issue?
https://legacy.curseforge.com/minecraft/mc-mods/sapience/files/4502823
Also, if anyone is playing 1.19.4, there's this too: https://legacy.curseforge.com/minecraft/mc-mods/sapience/files/4502809

1.18.2 fix is also available: https://legacy.curseforge.com/minecraft/mc-mods/sapience/files/4503097

@HoneyspringsBw and anyone else playing on 1.19.2, can you try this build out and see if it fixes the issue? https://legacy.curseforge.com/minecraft/mc-mods/sapience/files/4502823
Also, if anyone is playing 1.19.4, there's this too: https://legacy.curseforge.com/minecraft/mc-mods/sapience/files/4502809

Just tried it out, no difference unfortunately.

Just tried it out, no difference unfortunately.

How exactly are you testing?
I tested in a fresh install of 1.19.4 (which has the exact same fix as 1.19.2), and got no config errors in the log, even after I logged out and logged back in.

Apologies, I should have specified. I tested it in a 1.19.2 installation where the broken version of the mod initially resided before I removed it and added the fixed version.

Can you try it either through a fresh install or after removing the original config file in your existing install?

All the original sapience configs were removed when I tested.

Apologies, I should have specified. I tested it in a 1.19.2 installation where the broken version of the mod initially resided before I removed it and added the fixed version.

Can you try it either through a fresh install or after removing the original config file in your existing install?

All the original sapience configs were removed when I tested.


update children transforms before checking their union for culling

@pjcozzi @rahwang This fixes the culling problems we were seeing in the game

@rahwang could you please test this?  Feel free to just keep the game built off of this branch until @lilleyse is able to review and merge this.

Works great! Thanks, @austinEng !

Thanks for the fix.

Thanks @austinEng @rahwang @lilleyse!  Good eye and fast fix.


Allow realpath on each filenames into reports (like checkstyle)

Hello,
IMO, it's always difficult to re-use reports generated (whatever format) with relative filenames, on third-party tool.
As author of package https://github.com/llaville/sarif-php-converters (still under development),
I've a Console Tool that is able to convert a report from checkstyle format to sarif.
But it's almost impossible if source provider did not send the absolute path on each files.
When we lint a source (e.g: Twig-CS-Fixer repo itself)
<EMAIL_ADDRESS>in /shared/backups/forks/Twig-CS-Fixer $ bin/twig-cs-fixer lint --report checkstyle

We got such kind of report
<?xml version="1.0" encoding="UTF-8"?>
<checkstyle>
  <file name="./tests/Runner/Fixtures/Linter/node_visitor.twig">
    <error line="5" column="16" severity="error" message="Expecting 0 whitespace after "|"; found 1." source="TwigCsFixer\Rules\Punctuation\PunctuationSpacingRule"/>
    <error line="5" column="16" severity="error" message="Expecting 0 whitespace before "|"; found 1." source="TwigCsFixer\Rules\Punctuation\PunctuationSpacingRule"/>
    <error line="13" column="20" severity="error" message="Expecting 0 whitespace after "|"; found 1." source="TwigCsFixer\Rules\Punctuation\PunctuationSpacingRule"/>
    <error line="13" column="20" severity="error" message="Expecting 0 whitespace before "|"; found 1." source="TwigCsFixer\Rules\Punctuation\PunctuationSpacingRule"/>
    <error line="4" column="1" severity="error" message="More than 1 empty line is not allowed, found 3" source="TwigCsFixer\Rules\Whitespace\EmptyLinesRule"/>
    <error line="8" column="1" severity="error" message="More than 1 empty line is not allowed, found 3" source="TwigCsFixer\Rules\Whitespace\EmptyLinesRule"/>
    <error line="12" column="1" severity="error" message="More than 1 empty line is not allowed, found 3" source="TwigCsFixer\Rules\Whitespace\EmptyLinesRule"/>
    <error line="16" column="1" severity="error" message="More than 1 empty line is not allowed, found 3" source="TwigCsFixer\Rules\Whitespace\EmptyLinesRule"/>
    <error line="20" column="1" severity="error" message="More than 1 empty line is not allowed, found 3" source="TwigCsFixer\Rules\Whitespace\EmptyLinesRule"/>
    <error line="24" column="1" severity="error" message="More than 1 empty line is not allowed, found 3" source="TwigCsFixer\Rules\Whitespace\EmptyLinesRule"/>
    <error line="28" column="1" severity="error" message="More than 1 empty line is not allowed, found 3" source="TwigCsFixer\Rules\Whitespace\EmptyLinesRule"/>
  </file>

  <...MORE...>

</checkstyle>

[!WARNING]
Look deep on file names (relative paths)

It may be solved quickly, if we specify the absolute path to source to analyse
<EMAIL_ADDRESS>in /shared/backups/forks/Twig-CS-Fixer $ bin/twig-cs-fixer lint --report checkstyle /shared/backups/forks/Twig-CS-Fixer

<?xml version="1.0" encoding="UTF-8"?>
<checkstyle>
  <file name="/shared/backups/forks/Twig-CS-Fixer/tests/Runner/Fixtures/Linter/node_visitor.twig">

But there is also an alternative to fix it by PR.
Are you agree with such request ?

Hi,
I got a request for relative path instead in #237 so I'm not sure about using absolute path. Anyway I wont be able to satisfy everyone on this.
I think you'll get absolute if in your config you define the folder with an absolute path. Could this solution be enough for you ?

I've found an alternative that will solve all situations: keep relative path for Text and GitHub reporters, and absolute path for Checkstyle and Junit.
I'll propose you a PR tomorrow morning.

BTW, I've noticed that current version of CheckstyleReporterTest is wrong: it uses absolute path while in real condition the CheckstyleReporter used the relativepath (LOL).

Finally PR is ready before expected.
It will apply absolute path on files in checkstyle and junit reports only.  text and github reports keep the relative path usage.


add a sound after clicking the button

Please assign this work to me

@rounakdey6 provide me a detailed solution.

@vivekvardhan2810 like will I code ?

@rounakdey6 what sound would you want to put and what improvements you wanna make, pls tell it in detail.

I want to add a click sound, for the navbar button, every time some one clicks on the navbar button a sound will generate.

for now we don't need it, so i am closing this issue.


⚠ Bofrost.at has degraded performance

In a2edb3b, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1712 ms

Resolved: Bofrost.at performance has improved in e272212 after 6 minutes.


Remove state of world reference

See https://github.com/googleforgames/quilkin/issues/964#issuecomment-2136194423, this removes reference to sotw ADS which is no longer supported. The envoy naming for things is super confusing, I don't know if there is a better way to state this. Also removed 2 dead reference links that weren't used.

I've been playing with protoc-gen-doc and it's really struggling with all our dependencies. I might have to try something else.

I've been playing with protoc-gen-doc and it's really struggling with all our dependencies. I might have to try something else.

Actually, I've got it working on the command line with straight protoc - lemme see if I can integrate it with crates/proto-gen so that when protos get generated, the documentation is generated along with it.

I'm digging through the xDS code right now - happy to take a stab at these changes in combo with #982, especially if you have other things on your plate, to round this work off.

@markmandel that would be great 🙂

👍🏻  on it.

Now we have #982 I think we can close this?


⚠ Turnos 24x7 has degraded performance

In 61c02bc, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 3156 ms

Resolved: Turnos 24x7 performance has improved in 1ea0e2b.


Caching improvements

This issue is intended to be a discussion/feature request about the possibilities of caching improvements.  There are two main areas that I would like to discuss:
Toggleable cache types
The main goal with being able to enable and disable particular caches would be to save memory on storing stuff that the bot would not need to access.  For instance, bots could disable emoji caching if they simply didn't use emojis.
External caching
Being able to use an external cache like Redis would be a benefit for any bot that needs other software to have access to its data.  I'm particularly thinking of web interfaces in this case, but the applications are wider.  This has the added benefit of allowing the cache to be decoupled from the bot and moved where needed.
This would make cache access an asynchronous operation which would have a significant impact on a large portion of the library.

I mean you could just disable the emoji events

I like the idea of caching externally or even disable caching completely so I could have a middleman that handles my caches and events, and the bot logic abstracted.

To keep this issue up to date, it was brought up through discussion that custom emojies come in on the guild events, and disabling the emoji events will not prevent the emoji cache from creation/fill.

The ability to configure which types of things not to cache would be great. For example, it would be really nice to disable caching of users, in instances where thousands of users & their related data gets cached and consumes lots of memory.

Are there any short term solutions for this? I was just asking around in the D.js server but it doesn't seem like it. Over a long time I end up with an exceptionally large user map across 4 shards([42595,34314,30945,61286] users on each respective shard). I'd like to offload this somehow if possible.
Doing some heapdump comparsions, the largest objects are the guildmembers/client user maps. It's growing quite a lot and usually run out of the 4 GB memory on the server that I'm hosting this on. Simply restarting the process fixes the issue until about a week later when it's out again.
(From the top of a heapdump comparison)

I do use presenceUpdate feature for some servers so I feel like I'm wanting to have my cake and eat it too but if there's anything I can do to limit it, I'd like to help with this.
I've done everything I can to make sure this isn't a memory leak with bad function closures or something I could've caused, but I think just the raw number of users is the problem for me right now.

@yonilerner  in my case caching of users is especially bad since I'm trying to parse data that is passed partially as username, which is cached

Beyond just turning off certain caches, it would be more ideal to give some sort of way for users to control what is cached from the very beginning, instead of caching everything and requiring caches to be swept.
This could be done with:

basic limits (like the message cache)
filter functions for users to determine what should be cached
maybe lru (like the channel cache, for which you cannot actually even use currently)

This has been determined to be unreasonable for a library like discord.js that relies heavily on internal state in order to function.

@appellation this appears to still be a significant problem - is there any possible way we can get some cache restrictions. This was deemed "unreasonable", but this issue makes this library unreasonable for any large bots.
I genuinely love this project, been following it for a few years now, but we really need some sort of solution to the aforementioned problem.

@Headline I wouldn't say that either of these proposed solutions are off the table for the discord.js-next rewrite, but I am also no longer involved in the community to a degree where I could confirm a bias towards one, the other, or potentially a new solution.
I absolutely agree with your concerns, but the bottom line is still that this concept is unreasonable for the current implementation of discord.js.


knot-resolver: fix LUA_{PATH,CPATH}

LUA_PATH and LUA_CPATH were both blank beforehand.

Motivation for this change
Enabling DNSSEC, trust_anchors.add_file('/var/cache/kresd/root.keys').
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Hmm, I suppose some lua infra changes have broken this.  I'll have a closer look later.
BTW, you don't need to add custom root trust anchor file or explicitly enable DNSSEC validation – you get all that by default without these extra lua packages.

This was broken by #63108.  Unfortunately this PR isn't a full fix, because it doesn't address dependency propagation, in particular some lua dependencies of http are missing.

Thanks a lot for reporting this!   I pushed a quick-fix in the meantime, and I agree we need to resolve the underlying issue anyway.


Add requirements-macOS.lock

Added requirements.lock file for macOS, where cu113 is removed. Tested successfully on Apple M1/M2 laptops.

Many thanks for this and your interest in REINVENT.  How is this different from our current version and why is a separate requirements files needed?


test_release

PR automatically created

coverage: 100.0%. remained the same
when pulling 6cda738d8d1aa8cf77e9226a4cb7a7d3e9661e79 on test_release
into cc7a044c5f18eaa5db9a6e911c347adf553a961a on master.


Swift 5 support

Hi ,
Please provide Swift 5 support for this Library.

3.x branch is already compatible with Swift 5


mkWindowsApp: persistRegistry and enableVulkan must not be used together

The persistRegistry and enableVulkan function attributes must not be used together because it would lead to a failed DXVK installation.
What happens is that when enableVulkan is used, DXVK is installed into the "app layer", including the Wine DLL overrides needed for DXVK.
If persistRegistry  is also used, then the Wine DLL overrides are effectively rolled back when the registry files, which are not in the "app layer", are symlinked into the "runtime layer" (the real WINEPREFIX).
For now, I'm making the mkWindowsApp function abort like this:
error:
       … while calling the 'derivationStrict' builtin

         at /builtin/derivation.nix:9:12: (source not available)

       … while evaluating derivation 'duskers-unknown'
         whose name attribute is located at /nix/store/xxy590yv8qfx78dc0kala1xln3a3d82i-source/pkgs/stdenv/generic/make-derivation.nix:336:7

       … while evaluating attribute 'preInstall' of derivation 'duskers-unknown'

         at /nix/store/41g2f8h5y2da120ix6qqjsmq0q41k2id-source/pkgs/mkwindowsapp/default.nix:259:3:

          258|
          259|   preInstall = ''
             |   ^
          260|     APP_LAYER_HASH=${if appLayerHash == "@APP_LAYER_HASH@" then ''$(printf "%s %s" "$out/bin/.launcher" "${api}" | sha256sum | sed -r "s/(.{64}).*/\1/")'' else appLayerHash}

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: evaluation aborted with the following error message: 'The mkWindowsApp function attributes 'persistRegistry' can't be used along with 'enableVulkan' (DXVK) at this time because it would lead to
a failed DXVK installation.'

Enforced in e2113a310f4896a4c94a8ea32d3ebc5ba33d7893


allow topless girls model

I would like to know if someone can make a model which does not marks topless girls as nsfw.
#freethenipples kind of thing thanks

ok

then you have to retrain the model yourself - problem is to get the pics yahoo used for the retraining process (they wont share - because its porn pics) - otherwise you could just remove the nipple pics :(

I am looking for just the opposite.

Doesn't that kind of go against the idea of NSFW?


Save datasets on Hugging Face ?

Hi team ! I'm Quentin from HF
Great work on this, IMO people are not aware yet of the power of synthetic data and how it can bootstrap any project, so this tool could help a lot :)
Anyway, I was wondering if you had considered allowing to save the generated datasets on HF ? If users are ok with sharing publicly the data, they could have a nice impact for the community (note that it's also possible to save private datasets on HF)

Hi Quentin, yeah that sounds like a great feature to add!
I'll look into incorporating this sometime this week, don't know why I didn't think of it earlier.

Hey, was looking at trying to add Huggingface Datasets support to Augmentoolkit. Ran into some problems, would you maybe mind helping me resolve them @lhoestq ?
Using the docs I was able to add code that pushes data to the hub. However, currently each push overwrites and deletes the previously-pushed dataset with some new commits.
I'm trying a workaround where I save each dataset as a "split", but my adaption of the code from the Docs is very much not working:
with open(output_file_path, "w") as f:
        existing_files = glob.glob(
            os.path.join(output_dir, "*.yaml")
        )

        for file in existing_files:
            with open(file,'r') as file2:
                file_list_of_dicts = yaml.safe_load(file2)

            # print(file_list_of_dicts)

            sysprompt = {"from": "system", "value": file_list_of_dicts[0]["content"]}
            input = {"from": "human", "value": file_list_of_dicts[-2]["content"]}
            output = {"from": "gpt", "value": file_list_of_dicts[-1]["content"]}

            json_to_write = {"conversations": [sysprompt, input, output]}

            f.write(json.dumps(json_to_write) + "\n")
    print("...Converted successfully (we think)")
    if os.path.exists(output_file_path):
        dataset = load_dataset("json",data_files=output_file_path)
        dataset.push_to_hub(HUB_PATH, split=directory.split("_")[0], private=PRIVATE,)

Results in:
 File "/Users/evan/repos/augmentoolkit/augmentoolkit/control_flow_functions/control_flow_functions.py", line 94, in convert_logging_to_dataset
    dataset.push_to_hub(HUB_PATH, split=directory.split("_")[0], private=PRIVATE,)
TypeError: DatasetDict.push_to_hub() got an unexpected keyword argument 'split'

Despite the signature of the .push_to_hub being:
(method) push_to_hub: ((repo_id: Any, config_name: str = "default", set_default: bool | None = None, data_dir: str | None = None, commit_message: str | None = None, commit_description: str | None = None, private: bool | None = False, token: str | None = None, revision: str | None = None, branch: str = "deprecated", create_pr: bool | None = False, max_shard_size: int | str | None = None, num_shards: Dict[str, int] | None = None, embed_external_files: bool = True) -> CommitInfo) | ((repo_id: str, config_name: str = "default", set_default: bool | None = None, split: str | None = None, data_dir: str | None = None, commit_message: str | None = None, commit_description: str | None = None, private: bool | None = False, token: str | None = None, revision: str | None = None, branch: str = "deprecated", create_pr: bool | None = False, max_shard_size: int | str | None = None, num_shards: int | None = None, embed_external_files: bool = True) -> CommitInfo) | Any

The documentation also seems to claim that split= is a valid kwarg:
train_dataset.push_to_hub("<organization>/<dataset_id>", split="train")
val_dataset.push_to_hub("<organization>/<dataset_id>", split="validation")
# later
dataset = load_dataset("<organization>/<dataset_id>")
train_dataset = dataset["train"]
val_dataset = dataset["validation"]

Do you know what's going on here? Appreciate the support!

Hi ! split is a valid argument of Dataset.push_to_hub, while DatasetDict.push_to_hub uploads each dataset in the dictionary as separate splits named after the dictionary keys. You can get a Dataset by requesting the "train" split in load_dataset(..., split="train")
Anyway we haven't implemented append-mode in push_to_hub yet, in the meantime you can maybe upload a new Parquet file every time you have new data:
part_nb = directory.split("_")[0]
dataset.to_parquet(f"hf://datasets/{HUB_PATH}/data/train-{part_nb}.parquet")

Would that work for you ? Then when someone reloads the dataset, they would get the data resulting from the concatenation fo all the Parquet files

Hey thanks for the explanation! In the most recent commits I've added experimental push to hub functionality. The files are maybe a bit disorganized in the created repo, but they're there!

Cool ! do you have an example repo somewhere I can share with the community ?


did something happen recently - instant crashes

Hi there,
We were watching the youtube ad free thing for the very first time ...
we have been using jellyfin for a while now ; but youtube first time.
the TV is in a state where it just immedately crashes after a few seconds.
any guidance or HowTo ?
I suppose a very basic question would be how to identify the source of the crash in the first place
I get popops for 'tv was turned off and update has stopped.. do you want to restart the update now.."
and "failsafe mode remove file /var/luna/preferences/homebrew_failsafe"
I am on v0.5
webOS TV 6.2.1 LGwebOSTV

If you turn off failsafe mode, and restart your TV, will it crash again?

Hi there, We were watching the youtube ad free thing for the very first time ... we have been using jellyfin for a while now ; but youtube first time. the TV is in a state where it just immedately crashes after a few seconds.

can you test it for official youtube?

No response. For anyone looking for similar issue: check what/if you have any scripts in /var/lib/webosbrew/init.d - buggy startup scripts can stall main startup sequence, and cause failsafe mode flag to not get removed on boot finish.


Client address call returns NotFoundError

client = Minter::Api::Client.new
client.node_url = "https://node-api.testnet.minter.network/v2"

address = "Mx251cb0043a0240779103aa7c210f638f887699f8"
response = client.address(address: address)

Expected Behavior
response.status
#=> 200
response.body
#=> {"balance"=>[{"coin"=>{"id"=>"0", "symbol"=>"MNT"}, "value"=>"29999857000000000000000", "bip_value"=>"29999857000000000000000"}], "delegated"=>[], "total"=>[], "transaction_count"=>"13", "bip_value"=>"29999857000000000000000"}

Current Behavior
client.address(address: address)
#=> Minter::Api::NotFoundError (https://node-api.testnet.minter.network/v2/address?address=Mx251cb0043a0240779103aa7c210f638f887699f8)

Detailed Description
It sends unnecessary address parameter in request (?address=Mx...), but should be without it (address/Mx...). So this throws an NotFoundError.
Environment
Ruby 3.0.0
Rails 6.1

Well, it happens only when using console.

Well, it happens only when using console.


Add propagation of the exit code and err to the main command

Solves: The pat command always returning 0 even if the tests fail.
I'm not sure what you want to do with the error propagated from "run" but at the moment I'm just printing it out and then exited 0.

@zoltrain Thanks.  It's a good addition.  I added some (minor) comments.


Fixing crashing bots / restarting bots

Bug fixes to correct constantly resetting bots / crashing bots.

Please target the beta branch for your PR.

Bug fixes should never really be targeted to a Beta branch redevelopment. Particularly when these fixes have been published and tested by other contributors prior to PR as per the contributor's private group. These should be targeted to Main as they are fixes to what currently breaks PCB functionality. New features etc should always be put into Beta, which is what I will be doing with the upcoming features that I have been putting together (with the help of some others).

Well, hotfixes should target the main branch, I agree. But this is not a hotfix, but a bugfix. It's not like the bot doesn't work at all, is it? Basically you're improving the overall functionality. But I don't care, if @whittlem is fine with it, merge it to main.

Looking into a few things - will create another PR once done - closing for now.


import error

Hi,
Thanks for creating this toolkit, seems like satisfied all my needs.
However, when I was finishing pip install and trying to import the package, i got this error, any help would be appreciated.
Python 2.7.10 (default, Aug 22 2015, 20:33:39)
[GCC 4.2.1 Compatible Apple LLVM 7.0.0 (clang-7<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import arpa
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Library/Python/2.7/site-packages/arpa/__init__.py", line 37, in <module>
    from .arpa import dump, dumpf, dumps, load, loadf, loads
  File "/Library/Python/2.7/site-packages/arpa/arpa.py", line 3, in <module>
    from .models.simple import ARPAModelSimple
  File "/Library/Python/2.7/site-packages/arpa/models/simple.py", line 3, in <module>
    from .base import ARPAModel
  File "/Library/Python/2.7/site-packages/arpa/models/base.py", line 8
    class ARPAModel(metaclass=ABCMeta):
                             ^
SyntaxError: invalid syntax

Unfortunately, Python 2.7 is not supported.

What is the reasoning? Would you be open to a contribution to support both or should I fork it?

Hey @josepvalls, I might have underestimated the need for Python 2.7 support. By hindsight, there have been several requests. Sorry!
I created a new branch for Python 2.7 development (python2.7) and I also created a separate package on PyPI (arpa27).
I has been quite a while for me, so I must first reactivate my Python 2.7 knowledge.

Hey @josepvalls and @flydsc, this took far too long, but now there is Python 2.7 support.
The package is available on PyPI: arpa-backport.
Installation:
$ pip install --user -U arpa-backport

Usage:
import arpa_backport as arpa
models = arpa.loadf("foo.arpa")


Update log4j-api, ... to 2.22.0

About this PR
📦 Updates

org.apache.logging.log4j:log4j-api
org.apache.logging.log4j:log4j-layout-template-json
org.apache.logging.log4j:log4j-slf4j-impl

from 2.20.0 to 2.22.0
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.apache.logging.log4j" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.apache.logging.log4j" }
}]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

@Mergifyio refresh