DeprecationWarning when rtm_connect method fails

Description
A DeprecationWarning is emitted when RTM connect fails.
.venv/lib/python3.7/site-packages/slackclient/client.py:143: DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
  LOG.warn("Failed RTM connect", exc_info=True)

What type of issue is this? (place an x in one of the [ ])

[x] bug
[ ] enhancement (feature request)
[ ] question
[ ] documentation related
[ ] testing related
[ ] discussion

Requirements (place an x in each of the [ ])

[x] I've read and understood the Contributing guidelines and have done my best effort to follow them.
[x] I've read and agree to the Code of Conduct.
[x] I've searched for any related issues and avoided creating a duplicate issue.

Bug Report
Filling out the following details about bugs will help us solve your issue sooner.
Reproducible in:
slackclient version: 1.3.0
python version: 3.7.1
OS version(s): Fedora 29
Steps to reproduce:

export PYTHONWARNINGS=d
Open a Python shell
import slackclient
slackclient.SlackClient("").rtm_connect()

Expected result:
No deprecation warnings.
Actual result:
The following output:
.venv/lib/python3.7/site-packages/slackclient/client.py:143: DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
  LOG.warn("Failed RTM connect", exc_info=True)

Thanks for reporting this!
I verified on the documentation site that the warn() method actually is deprecated: https://docs.python.org/3/library/logging.html#logging.Logger.warning.
It also seems like warning() is a supported method for all the versions of Python that we support, so it should be a simple find and replace.

Would you be able to assign this to me?

See PR #375

As v1.x is no longer supported, please allow me to close this issue now. Thank you very much for taking the time to report this and make a pull request.


Update gl-api.hpp

Added cstring header to include std::memcpy for char values. This fixes GCC compilation issue on linux as wel.

Thanks!


Bl 136 ds admin visualizations for mentor feedback

Description
Visualizations for mentor feedback. Added two types of graphs to graphs.py, added an API endpoint, and added a notebook to see what the visualizations will look like.
Fixes # BL-136 & BL-393
Type of change

[x] New feature

Checklist:

[x] My code follows PEP8 style guide
[x] I have removed unnecessary print statements from my code
[x] I have made corresponding changes to the documentation if necessary
[x] My changes generate no errors
[x] No commented-out code
[x] Size of pull request kept to a minimum
[x] Pull request description clearly describes changes made & motivations for said changes

Found out that there's more that needs to be done.


Feature: ability to customize docs next/previous pagination button labels

🚀 Feature
When transitioning from one category to another, the "Previous" and "Next" boxes should show the category name as well.
Have you read the Contributing Guidelines on issues?
Yes
Motivation
I have several categories (folders) of docs and each of them start with "Introduction". On each page, there are "Previous" and "Next" sections at the bottom that only show the title of the doc page. This feels awkward to see "Introduction" in the middle of documentation. Instead "XYZ: Introduction" where XYZ is the category name would be helpful. I don't expect this for all pages and only when there is a transition from one category to another (for previous or next as appropriate).
Pitch
It would be good to be able to notice that there is a transition of categories.

XYZ: Introduction wouldn't be a good fit for many use-cases
What I suggest instead is to add a frontmatter pagination_label (or navigation_label?) in the same way we have sidebar_label

A possibility is to use
title: "XYZ: Introduction"
sidebar_label: "Introduction"

This way you would have XYZ: Introduction in your pagination, without having a confusing sidebar.
We use this pattern on Docusaurus site itself: https://docusaurus.io/docs/api/plugins, see how the title and sidebar label is different.

Note adding the ability to link a category to a doc is a feature request that we plan to implement soon (https://github.com/facebook/docusaurus/issues/2643).
If you could have the XYZ category link to an intro doc, would you still need this feature?

Thanks @slorber for the workaround. I ended up doing what you suggested. Just have to make sure the title is small enough to fit into the pagination buttons. Yes, #2643 will also help for my case as each category can then directly point to an intro page. Look forward to that feature and closing this out.


Add search to to search the notes

Add the search bar on the main activity so, user can easily search notes

i think i can fix this...can i try :)

Yeah, go ahead


Technology lifetime different depending on the year?

We found that in the current data model, the technology lifetime differs for different years. In GENeSYS-MOD, lifetime is set once per technology and does not change.
My question would be how other frameworks handle this and what a possible solution would be. Possible points to consider:

How relevant is lifetime in 2016? Since capacity expansion should not be required in 2016, 2030 becomes the first period where lifetime becomes relevant.
There is only one Technology which has a lifetime of <20 years (Batteries in 2016). That means, that all other technologies will serve for 2 Periods (2030 and 2050), even batteries since the lifetime in 2030 is 25 years.
The only difference would be in the potential calculation of salvage values / discounting the value of the technologies.

Would like to hear some opinions, in theory it would be possible to adapt the paramter into GENeSYS-MOD but maybe we find a different solution.

Has this been settled or forgotten?
From my memory I think we handled it by providing capacities for each year - but I am not sure if there is still an issue?

I think from my side this is settled. we have only one parameter for every technology

From my memory I think we handled it by providing capacities for each year - but I am not sure if there is still an issue?

The issue regarding the capacities was clarified. For 2030 and 2050 initial installed capacities for the energy system have been provided.
However, in terms of lifetime, we should summarise how everyone then implements lifetime per technology.
Options:
A. Only implement 1 lifetime per technology from: 2016 (or) 2030 (or) 2050 (e.g. A 2016)
B. Implement a different lifetime for each year, as given in the input files (results in using 3 different lifetimes per technology)
Please edit this comment to state your implementation:
Balmorel:
GENESYS-2:
GENeSYS-MOD:
oemof:
urbs:


Extend data download

Extend data download to support other data providers apart from QC, similar to the backtest/research --data-provider option

First use for this feature is polygon

Hey, I researched about this.
I found option --data-provider and data_provider in research.py and backtest.py, as well as in test_backtest.py file. (but not in test_research.py)
I was hoping to add similar snippets of code to download.py and test_download.py files.
but on reading code of download.py i came to the understanding that the user is being asked to select the dataset and/or product they want, and then to pay for the dataset.

so my doubt was that if we add an option to download data from other providers, will it still have

options to select from
need for payment from the user

Hi @Priyal-Saxena! Sorry for the delay. We'll start this project this month, if there's interest in contributing it please login to discord and we can talk through the steps - quantconnect.com/discord


Implement worker-EDM interface tests (multi worker, multi channel, 1 worker per channel)

Done on branch


Remove unnecessary semi-colon (;)

The semi-colon at the line 102 should be removed as this semicolon is after the closing bracket of the if statement at line 91.

This file is removed.


libvirt provider on Apple m1

Hello,
it's not possible for me to install vagrant-libvirt (it doesn't compile on Apple M1; ruby-libvirt tries to compile for x86_64 instead).
How do I get libvirt provider then?

$ vagrant up --provider=libvirt
The provider 'libvirt' could not be found, but was requested to
back the machine 'default'. Please use a provider that exists.

Vagrant knows about the following providers: docker, hyperv, virtualbox, qemu

hi @pvalena
This plugin does not depend on libvirt.
Have you installed the plugin?
rake build && vagrant plugin install pkg/vagrant-qemu-0.2.22.gem

If you execute
vagrant plugin list

You should be able to see sth like

vagrant-qemu (0.2.22, global)
  - Version Constraint: 0.2.22

Oh, I've installed via brew. That's probably the problem:
vagrant-qemu (0.1.6, global)

But the vagrant is installed via brew:
$ vagrant --version
Vagrant 2.2.19

Thanks for checking!


Code Coverage

A dummy PR to trigger GHA with codecov

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@2383b60). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage        ?   60.41%
=======================================
  Files           ?        8
  Lines           ?     1258
  Branches        ?        0
=======================================
  Hits            ?      760
  Misses          ?      498
  Partials        ?        0

Flag
Coverage Δ

unittests
60.41% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2383b60...d5b5e35. Read the comment docs.


keycloakSecurityConfig

┌──->──┐
|  keycloakSecurityConfig (field private org.keycloak.adapters.KeycloakConfigResolver org.keycloak.adapters.springsecurity.config.KeycloakWebSecurityConfigurerAdapter.keycloakConfigResolver)
└──<-──┘

Hi,
unfortunately, I don't understand your error. can you describe the problem a little more precisely?


[Bug]: Flaky tests: setupGameAsP0() sporadically throws Type Error

Bug Summary
The setupGameAsP0() helper occasionally throws a Type Error due to a 403/forbidden response
Detailed Description
Cypress appears to be attempting to create a new property on a 403 'error' response when the backend is only sending the string forbidden
     TypeError: Cannot create property 'stack' on string 'Forbidden'

Because this error occurred during a `before each` hook we are skipping the
remaining tests in the current suite: `Countering One-Offs`

This happens unpredictably across different tests in the beforeEach() hook when using the setupGameAsP0() helper function. The issue is likely that one of the commands in that helper function is firing before the appropriate setup has completed, causing the backend to throw a forbiden() response
Current Behavior
No response
Expected Behavior
No response
Steps to Reproduce

This actually happens in the app also, not just Cypress which opens up a lot more possibilities for what this might be. I'm not sure how to reproduce it yet, but it seems to happen RIGHT after I log in and view the game list. The error is thrown as it wasn't able to get the list of games (which tracks with where we're seeing the error in Cypress occasionally).

It's probably worth looking for forks where we log the user out to see if there's an error we're catching that logs the user out, or just try and improve logging across the board.

Hahahaha, I know what this is now. It has to do with out session destroy logic as far as I can tell. To reproduce:

Load homepage
Login
See game list
Logout
Login
See error (it's a 403, I modified the error to see what was happening)

Yep, I got it, check this out:

initial load I get s%3AyWGFsNo7JX0ROG1xG2lJdBd0DsKHsnPt.TGqw%2FLu5dL0Havuk6enxTnbKPBNSmfRfaUIFcgbOTl8 (initial value)
On login, I get s%3AyWGFsNo7JX0ROG1xG2lJdBd0DsKHsnPt.TGqw%2FLu5dL0Havuk6enxTnbKPBNSmfRfaUIFcgbOTl8 (same value)
On logout, I get s%3AyWGFsNo7JX0ROG1xG2lJdBd0DsKHsnPt.TGqw%2FLu5dL0Havuk6enxTnbKPBNSmfRfaUIFcgbOTl8 (same value, this needs to be deleted 😎)
On relogin, I get s%3AyWGFsNo7JX0ROG1xG2lJdBd0DsKHsnPt.TGqw%2FLu5dL0Havuk6enxTnbKPBNSmfRfaUIFcgbOTl8
On reload, I get s%3AEVw6BGnlugAXdl5DJXYvLTa_do8D1rKj.yYgV4FnF7XNT1yvvd8cyBeg7g5RJ84%2Fm31HCbFwZMhk (different value)

We need to handle cookie deletion properly.


AGE-Viewer front-end not building (backend seems fine)

Describe the bug
When following the build instructions from README .md, the front-end build aborts on erros (after having issued many warnings when getting the dependencies). Backend seems to build fine.
To Reproduce
Steps to reproduce the behavior:

Clone the age-viewer repo locally
cd to the root of the source tree
Issue command "npm run build-front "
See error (build aborts on a series of errors related to jsx - see attachment and excerpt below:

Failed to compile.

src/components/contents/presentations/Editor.jsx
  Line 163:15:  A control must be associated with a text label  jsx-a11y/control-has-associated-label
  ...

Expected behavior
Successful build was expected, possibly with some warnings
Screenshots
No screenshots needed but log file is attached.
Desktop (please complete the following information):

OS: Ubuntu 22.04
Browser: (not relevant)
Versions : npm : 7.24.0, node: v16.10.0

Additional context
Nothing to add
age-viewer-fend-build-errors.txt

(I'm not familiar with JSX)
Problem can be fixed by adding some text as button labels but the parser/checker seems to be really finicky: it even considers   as a void string (i.e. as the absence of labels). Putting "" is not sufficient either (the string appears on the button) but the front-end builds (but not necessarily runs). Adding a non-empty string works but leaves visible (and not desired) traces.
Any recommendation from a JSX expert?

OK. Fixed with some "aria-label" properties, refromatting and a few other things. Now builds without errors.
Maybe time to prepare a PR ...

@koalabi a PR would be much appreciated. I am trying to use this via Docker and have hit the same hurdle.

It is almost ready. I hope to finalize it tonight (i.e. in a few hours). Stay tuned ...

Thank you!
On Wed, Feb 14, 2024 at 10:05 AM koalabi @.***> wrote:

It is almost ready. I hope to finalize it tonight (i.e. in a few hours).
Stay tuned ...
—
Reply to this email directly, view it on GitHub
https://github.com/apache/age-viewer/issues/168#issuecomment-1944019825,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJXAYUYH7CAH36D5GL3ANDYTTHDZAVCNFSM6AAAAABDAH4SIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBUGAYTSOBSGU
.
You are receiving this because you commented.Message ID:
@.***>

--
Ben Hakim, MD

Ahead of the pull request, a patch file that fix the build errors.
NOTE: by default, as per the source tree, the DEV server only accepts connection from localhost. Any attempt to access remotely will end up in error: "Invalid Host Header" (see StackOverflow for details)
age-viewer.patch.txt

Thank you!
…
On Wed, Feb 14, 2024 at 10:05 AM koalabi @.> wrote: It is almost ready. I hope to finalize it tonight (i.e. in a few hours). Stay tuned ... — Reply to this email directly, view it on GitHub <#168 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJXAYUYH7CAH36D5GL3ANDYTTHDZAVCNFSM6AAAAABDAH4SIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBUGAYTSOBSGU . You are receiving this because you commented.Message ID: @.>
-- Ben Hakim, MD

Hi, Benny, see patch file above, as an interim solution while I finalize the PR ...


ETSI 013 compliance

CHANGES:

Location Service implementation updates to be compliant with ETSI 013 specification

Hotfix branch was validated to be compliant with specification. Ready to be merged.


[Other] ITelephonyManagerProxy - Custom Info 📲

Hi, I hope everything is okay.
I have a question.
In: ITelephonyManagerProxy, in the code part:
@ProxyMethod("getDeviceId")...
I replaced the:
return Md5Utils.md5(BlackBoxCore.getHostPkg());
By a custom number, for example:<PHONE_NUMBER>123456789 and it worked perfectly, I was able to obfuscate the original phone ID.
But for the others like:
getImeiForSlot
getSubscriberId
getNetworkOperator
and several others, it doesn't work.
Can you tell me why and how to solve this? Please friend.

i am in need of help at the initialization, can you please help me

i am in need of help at the initialization, can you please help me

What is the problem?

The reason is simple. The application get the device fingerprint via native invocation not Java layer

The reason is simple. The application get the device fingerprint via native invocation not Java layer

Got it, thanks for the explanation. 😀
I will have to use applications like Xprivacy Lua, Android Faker etc...


LibCore+LibWebView+UI: Raise the chrome process open file limit

The default limit (at least on Linux) causes us to run out of file
descriptors at around 15 tabs. Increase this limit to 8k. This is a
rather arbitrary number, but matches the limit set by Chrome.
Fixes #760

Sidenote: referring to it as the "chrome process" in a commit message that also references Chrome the browser pokes my ambiguity nerve in a bad place 😅


Version conflict in resources/views/scaffold-interface/layouts/app.blade.layout

Hi dear developers.
There is some conflict leftovers at the end of the file
https://github.com/amranidev/scaffold-interface/blob/master/src/Publishes/Views/scaffold-interface/layouts/app.blade.php
HEAD

 '+data.message+'
\
			\
				 '+data.message+'\
			\

36e331d580b33e2ad155aae685046a239e096ca2

@babakbandpey Thanks for submitting this issue I really appreciate it.
Thanks!!

The problem has been fixed, you could check the v1.7.24
Thanks again!!


RouteParams.get() failed with 'int' is not a subtype of type 'String'

Hi,
There seems to be a bug in RouteParams.
RouteParams.params is defined as Map<String, String> but it accepts int as parameter.
If I wan't to navigate to my component via  _router.navigate(['Page', {'page': 1}]); and in my PageComponent I wan't to get the page argument with :

int _page = int.parse(_routeParams.params['page']);

I got an exception :

EXCEPTION: type 'int' is not a subtype of type 'String' of 'source' where
int is from dart:core
String is from dart:core

So we have an int stored inside a Map<String, String> which (in my opinion) should have triggered an error before getting there, most likely when params['page'] is assigned with an int instead of String.
PS : I know I'm not supposed to pass an int to navigate(), but this still looks like a bug

Not sure why you think it's a bug. You do get an exception.
https://github.com/dart-lang/angular/blob/0bb611387d29d65b5af7f9d2515ab571fd3fbee4/angular/lib/src/router/router.dart#L172 is defined as List<dynamic>, therefore it can't be checked statically.

Assigning a int to a String is not a normal behaviour and should not be possible.
I do get an exception, but when accessing Map<String, String>, which is in fact something like a Map<String, dynamic>.
Accessing a String and getting an exception 'int' is not a subtype of type 'String' is not something we should expect.
This might not specific to RouteParams, since this code produce the same result :
main() {
  int myint = 123;
  dynamic mydyn = myint;
  String mystr = mydyn as String;
  print("mystr : ${mystr}");
}

In this case, as String should have trigger an exception, or return null (this is C# behaviour)

This line
String mystr = mydyn as String;

does cause the exception.
DartPad example

Yup, my bad, sorry :
main() {
  int myint = 123;
  dynamic mydyn = myint;
  String mystr = mydyn;

  print("mystr : ${mystr.runtimeType}");
  print("mystr : " + mystr);
}

results in :
mystr : int
Unhandled exception:
Invalid argument(s): 123
#0      _StringBase.+ (dart:core-patch/string_patch.dart:239)
#1      main (http://localhost:52574/test.dart:7:20)
#2      _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:265)
#3      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:151)

And you expect already String mystr = mydyn; to throw?
It does when I run it in the console? (haven't tried in Dartium or Chrome)
type 'int' is not a subtype of type 'String' of 'mystr' where

Did you run in checked mode?

It does throw an exception if I add --checked, so this corroborate my first point, RouteParams.params should trigger this exception when an int is assigned to it ?

Without checked mode, type annotations are ignored (except with strong mode, but strong mode is currently only supported by DDC).

@zoechi is correct. We only support developing AngularDart in either DDC or Dartium in --checked mode. Choosing to use Dartium without --checked means we can't do much for you.


Usage Question

If I was to use this blog engine, where would you prefer the credit to be and what exactly would you like it to say?

You could probably put credits in the about page, which is generated from the file /pages/about.md.
(Sorry this is not really usable for the general public -- a lot of things are hard-coded!! I recommend you check out the publish branch to see my publish script. You'll definitely want to enter your own domain and not towerofnix.github.io in that or else nothing will work.)

That's great, thanks!


The listview of the sent items folder doesn't show always the name/mail of the recipient

In the "sent" folder the display is not consistent. Some times the recipient is shown and sometimes my name (sender) is displayed, such that it could happen, that all mails shows my own name and i don't see to who i sent the mail.
Expected behavior
In the "sent" folder should always show the recipient name or e-mail (to:)
Actual behavior
If the senders e-mail is not the same as one of the configured identities in k-9, the listview shows my own name (the senders name). This can happen, if i connect to my IMAP server, where i have already sent mails with different identities.
Steps to reproduce

sent a mail with your default identity
in the sent folder you see correctly the name of the recipient
change the e-mail address of your default identity
now the sender name shows up in the sent items

Environment
K-9 Mail version: 5.600
Android version: 9
Account type (IMAP, POP3, WebDAV/Exchange): IMAP
Please take some time to retrieve logs and attach them here:

This works as originally intended. But I agree it's not great.
I propose we change the code to always show the recipient name/address for messages in the following special folders:

Sent
Drafts
Outbox

For messages in all other folders we show the sender name/address, even if that's one of the user's identities.


Feature/sbachmei/mic 3369 healthcare visit observers

Title: Healthcare visit observer
Description

Category: observers
JIRA issue: MIC-3369
Research reference: https://vivarium-research.readthedocs.io/en/latest/concept_models/vivarium_us_cvd/concept_model.html#desired-outputs

Added observer including an observer start time feature. There's a known bug
where the observer year is stratified based on clock.time when it should be
based on event.time: https://jira.ihme.washington.edu/browse/MIC-3456
Verification and Testing
Made sure hospital visits made it into count_data

This looks good. Sorry I had to drop off but did you get all your questions answered for the observer clock (I saw your other jira ticket)?

@albrja Kinda. Matt pointed out that prior to a somewhat recent refactor, the observer always provided up to one extra time step after the end of the sim. eg if you ran through, say, 2040, the count_data/ datasets would have values in 2041 (which represented the clock time starting in 2040 but the event time being in 2041).
Once he mentioned that, then I know what needs to be done but when I started fixing it I realized it was going to take a bit of work so I'm skipping for now.


fix path traversal in PFS extractor script

os.path.join does not fully resolve a path so the condition that follows will never be true. Fixed by resolving the path using os.path.abspath.
An attacker could craft a malicious PFS file that would cause binwalk to write outside the extraction directory. I attached a proof-of-concept (poc.zip) that, when extracted from the user's home directory, would extract a malicious binwalk module in .config/binwalk/plugins. This malicious plugin would then be loaded and executed by binwalk, leading to RCE.

PoC run:
/usr/local/bin/binwalk -M -e /tmp/poc.zip

Scan Time:     2022-10-26 21:50:26
Target File:   /tmp/poc.zip
MD5 Checksum:  4fdad30c7c1b4915938b5ad2786f5bf8
Signatures:    411

DECIMAL       HEXADECIMAL     DESCRIPTION
--------------------------------------------------------------------------------
0             0x0             Zip archive data, at least v2.0 to extract, compressed size: 170, uncompressed size: 349, name: malicious.pfs
324           0x144           End of Zip archive, footer length: 22

Scan Time:     2022-10-26 21:50:26
Target File:   /home/quentin/_poc.zip.extracted/malicious.pfs
MD5 Checksum:  9a12bccad3db3ed8b818a31846d5976f
Signatures:    411

DECIMAL       HEXADECIMAL     DESCRIPTION
--------------------------------------------------------------------------------
0             0x0             PFS filesystem, version 0.9, 1 files

hello from malicious plugin
hello from malicious plugin
hello from malicious plugin
hello from malicious plugin

The malicious plugin is simply this:
import binwalk.core.plugin

class MaliciousExtractor(binwalk.core.plugin.Plugin):
    """
    Malicious binwalk plugin
    """

    def init(self):
        print("hello from malicious plugin")

It's triggering four times because I did not define the MODULES attribute.

I took the liberty to report this in the open since https://github.com/ReFirmLabs/binwalk/pull/556 was fixed that way and I did not find any security/coordinated disclosure policy or contact info. Hope that works for you.

We have an upcoming publication about similar vulnerabilities affecting different extractors in ubi-reader, jefferson, yaffshiv, and binwalk. We requested CVEs for each of these vulnerability so that users are aware they should upgrade to the latest version (through dependabot for example).
The one that should be fixed by this PR has been assigned CVE-2022-4510.

Hi @devttys0 ! Thanks for taking care of this :)
I would recommend fixing yaffshiv as well (https://github.com/devttys0/yaffshiv/pull/3/) since similar impact can be obtained with a malformed YAFFS file.


Add Edge correction world transform

Add edge correction for world transform filter for Edge, in Windows Phone emulation mode.

Did you test this on a real Edge phone?

Nope, this is in the Edge simulator. However, Edge in Desktop mode doesn't
show the problem.
On Wed, Jan 20, 2016 at 6:14 PM, Boris Smus<EMAIL_ADDRESS>wrote:

Did you test this on a real Edge phone?
—
Reply to this email directly or view it on GitHub
https://github.com/borismus/webvr-polyfill/pull/28#issuecomment-173428857
.

--
=================
Dr. Pete Markiewicz
Email<EMAIL_ADDRESS>Sustainable virtual design blog:
http://sustainablevirtualdesign.wordpress.com
Sustainability template: http://greenboilerplate.com
*Teaching site: *http://plyojump.com http://www.plyojump.com/
*Buy my book! *- Millennials and the Popular Culture
Lifecourse: http://www.lifecourse.com/store/catalog/lca/mpc.html

AmazonAuthor Page:*
http://www.amazon.com/Pete-Markiewicz/e/B0069VZ7BG/ref=ntt_athr_dp_pel_pop_2
On that page, see my DARPA Grand Challenge 2005 entry video, "Team
Robomonster":
*Team Robomonster *(DARPA 2005 Grand Challenge):
http://robotsthatjump.wordpress.com/category/team-robomonster/
*Indiespace *(1st to sell downloaded music, March 1994):
http://www.indiespace.com. Also see http://archive.org under
"Kspace.com" 1996 for our original site.
============================================================
=================

Bizarre. Could you link to the simulator?

I'll check to see what's possible. I'm using the vanilla Edge currently
shipping with win10.
On Wed, Jan 20, 2016 at 7:32 PM, Boris Smus<EMAIL_ADDRESS>wrote:

Bizarre. Could you link to the simulator?
—
Reply to this email directly or view it on GitHub
https://github.com/borismus/webvr-polyfill/pull/28#issuecomment-173440192
.

--
=================
Dr. Pete Markiewicz
Email<EMAIL_ADDRESS>Sustainable virtual design blog:
http://sustainablevirtualdesign.wordpress.com
Sustainability template: http://greenboilerplate.com
*Teaching site: *http://plyojump.com http://www.plyojump.com/
*Buy my book! *- Millennials and the Popular Culture
Lifecourse: http://www.lifecourse.com/store/catalog/lca/mpc.html

AmazonAuthor Page:*
http://www.amazon.com/Pete-Markiewicz/e/B0069VZ7BG/ref=ntt_athr_dp_pel_pop_2
On that page, see my DARPA Grand Challenge 2005 entry video, "Team
Robomonster":
*Team Robomonster *(DARPA 2005 Grand Challenge):
http://robotsthatjump.wordpress.com/category/team-robomonster/
*Indiespace *(1st to sell downloaded music, March 1994):
http://www.indiespace.com. Also see http://archive.org under
"Kspace.com" 1996 for our original site.
============================================================
=================

Thanks. If we're patching Edge support, it's important to test on a real phone.

Closing until this is actually tested on a real device.

Yup, they're hard to find!


docs(samples): testing dumby code

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

[ ] Make sure to open an issue as a bug/issue before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
[ ] Ensure the tests and linter pass
[ ] Code coverage does not decrease (if any source code was changed)
[ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

label:kokoro:force-run


Pickling error when loading dataset

Hi,
I modified line 136 in the original run_language_modeling.py as:
# line 136: return LineByLineTextDataset(tokenizer=tokenizer, file_path=file_path, block_size=args.block_size)
dataset = load_dataset("text", data_files=file_path, split="train")
dataset = dataset.map(lambda ex: tokenizer(ex["text"], add_special_tokens=True,
                                        truncation=True, max_length=args.block_size), batched=True)
dataset.set_format(type='torch', columns=['input_ids'])
return dataset

When I run this with transformers (3.1.0) and nlp (0.4.0), I get the following error:
Traceback (most recent call last):
  File "src/run_language_modeling.py", line 319, in <module>
    main()
  File "src/run_language_modeling.py", line 248, in main
    get_dataset(data_args, tokenizer=tokenizer, cache_dir=model_args.cache_dir) if training_args.do_train else None
  File "src/run_language_modeling.py", line 139, in get_dataset
    dataset = dataset.map(lambda ex: tokenizer(ex["text"], add_special_tokens=True, truncation=True, max_length=args.block_size), batched=True)
  File "/data/nlp/src/nlp/arrow_dataset.py", line 1136, in map
    new_fingerprint=new_fingerprint,
  File "/data/nlp/src/nlp/fingerprint.py", line 158, in wrapper
    self._fingerprint, transform, kwargs_for_fingerprint
  File "/data/nlp/src/nlp/fingerprint.py", line 105, in update_fingerprint
    hasher.update(transform_args[key])
  File "/data/nlp/src/nlp/fingerprint.py", line 57, in update
    self.m.update(self.hash(value).encode("utf-8"))
  File "/data/nlp/src/nlp/fingerprint.py", line 53, in hash
    return cls.hash_default(value)
  File "/data/nlp/src/nlp/fingerprint.py", line 46, in hash_default
    return cls.hash_bytes(dumps(value))
  File "/data/nlp/src/nlp/utils/py_utils.py", line 362, in dumps
    dump(obj, file)
  File "/data/nlp/src/nlp/utils/py_utils.py", line 339, in dump
    Pickler(file, recurse=True).dump(obj)
  File "/root/miniconda3/envs/py3.6/lib/python3.6/site-packages/dill/_dill.py", line 446, in dump
    StockPickler.dump(self, obj)
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 409, in dump
    self.save(obj)
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 476, in save
    f(self, obj) # Call unbound method with explicit self
  File "/root/miniconda3/envs/py3.6/lib/python3.6/site-packages/dill/_dill.py", line 1438, in save_function
    obj.__dict__, fkwdefaults), obj=obj)
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 610, in save_reduce
    save(args)
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 476, in save
    f(self, obj) # Call unbound method with explicit self
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 751, in save_tuple
    save(element)
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 476, in save
    f(self, obj) # Call unbound method with explicit self
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 736, in save_tuple
    save(element)
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 476, in save
    f(self, obj) # Call unbound method with explicit self
  File "/root/miniconda3/envs/py3.6/lib/python3.6/site-packages/dill/_dill.py", line 1170, in save_cell
    pickler.save_reduce(_create_cell, (f,), obj=obj)
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 610, in save_reduce
    save(args)
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 476, in save
    f(self, obj) # Call unbound method with explicit self
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 736, in save_tuple
    save(element)
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 521, in save
    self.save_reduce(obj=obj, *rv)
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 605, in save_reduce
    save(cls)
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 476, in save
    f(self, obj) # Call unbound method with explicit self
  File "/root/miniconda3/envs/py3.6/lib/python3.6/site-packages/dill/_dill.py", line 1365, in save_type
    obj.__bases__, _dict), obj=obj)
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 610, in save_reduce
    save(args)
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 476, in save
    f(self, obj) # Call unbound method with explicit self
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 751, in save_tuple
    save(element)
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 476, in save
    f(self, obj) # Call unbound method with explicit self
  File "/root/miniconda3/envs/py3.6/lib/python3.6/site-packages/dill/_dill.py", line 933, in save_module_dict
    StockPickler.save_dict(pickler, obj)
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 821, in save_dict
    self._batch_setitems(obj.items())
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 847, in _batch_setitems
    save(v)
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 476, in save
    f(self, obj) # Call unbound method with explicit self
  File "/root/miniconda3/envs/py3.6/lib/python3.6/site-packages/dill/_dill.py", line 933, in save_module_dict
    StockPickler.save_dict(pickler, obj)
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 821, in save_dict
    self._batch_setitems(obj.items())
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 847, in _batch_setitems
    save(v)
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 507, in save
    self.save_global(obj, rv)
  File "/root/miniconda3/envs/py3.6/lib/python3.6/pickle.py", line 927, in save_global
    (obj, module_name, name))
_pickle.PicklingError: Can't pickle typing.Union[str, NoneType]: it's not the same object as typing.Union

When I change from python3.6 to python3.8, it works!

Does it work when you install nlp from source on python 3.6?

No, still the pickling error.

And, when I use num_proc in the dataset.map with python 3.8:
#line 136: return LineByLineTextDataset(tokenizer=tokenizer, file_path=file_path, block_size=args.block_size)
dataset = load_dataset("text", data_files=file_path, split="train")
dataset = dataset.map(lambda ex: tokenizer(ex["text"], add_special_tokens=True,
                                      truncation=True, max_length=args.block_size), batched=True, num_proc=16)
dataset.set_format(type='torch', columns=['input_ids'])
return dataset

I get the following error:
Traceback (most recent call last):
  File "src/run_language_modeling.py", line 325, in <module>
    main()
  File "src/run_language_modeling.py", line 254, in main
    get_dataset(data_args, tokenizer=tokenizer, cache_dir=model_args.cache_dir) if training_args.do_train else None
  File "src/run_language_modeling.py", line 145, in get_dataset
    dataset = dataset.map(lambda ex: tokenizer(ex["text"], add_special_tokens=True,
  File "/root/miniconda3/envs/py3.8/lib/python3.8/site-packages/datasets/arrow_dataset.py", line 1287, in map
    transformed_shards = [r.get() for r in results]
  File "/root/miniconda3/envs/py3.8/lib/python3.8/site-packages/datasets/arrow_dataset.py", line 1287, in <listcomp>
    transformed_shards = [r.get() for r in results]
  File "/root/miniconda3/envs/py3.8/lib/python3.8/multiprocessing/pool.py", line 771, in get
    raise self._value
  File "/root/miniconda3/envs/py3.8/lib/python3.8/multiprocessing/pool.py", line 537, in _handle_tasks
    put(task)
  File "/root/miniconda3/envs/py3.8/lib/python3.8/multiprocessing/connection.py", line 206, in send
    self._send_bytes(_ForkingPickler.dumps(obj))
  File "/root/miniconda3/envs/py3.8/lib/python3.8/multiprocessing/reduction.py", line 51, in dumps
    cls(buf, protocol).dump(obj)
AttributeError: Can't pickle local object 'get_dataset.<locals>.<lambda>'

I wasn't able to reprodue on google colab (python 3.6.9 as well) with
pickle==4.0
dill=0.3.2
transformers==3.1.0
datasets=1.0.1 (also tried nlp 0.4.0)
If I try
from datasets import load_dataset  # or from nlp
from transformers import BertTokenizer

tokenizer = BertTokenizer.from_pretrained("bert-base-uncased")
dataset = load_dataset("text", data_files=file_path, split="train")
dataset = dataset.map(lambda ex: tokenizer(ex["text"], add_special_tokens=True,
                                        truncation=True, max_length=512), batched=True)
dataset.set_format(type='torch', columns=['input_ids'])

It runs without error

Closing since it looks like it's working on >= 3.6.9
Feel free to re-open if you have other questions :)


empty.maxBy in Compile / internalMigrateLibs when there are no libraries.

As called from line 268 of ScalaMigratePlugin.scala this method results in: "[error] (Compile / internalMigrateLibs) java.lang.UnsupportedOperationException: empty.maxBy" if there are no library dependencies at all in a project. I do not know that zero is definitely the appropriate result if there are no values. Please check that, thank you.

Thank you for this Pull request. I think we can start with this solution and maybe later we could rewrite it with NonEpmtyList or Option.

When you come to do the rewrite with Option or NonEmptyList you may wish to bear this in mind: With this fix in place (version 0.3.1) I was able to run the step on my "utils" project, which deliberately has no dependencies or libraries. It displays the key (i.e. the meaning of Valid and so on) as if there is going to be a list of libraries, but then there is no list, and not even a message saying "there are no libraries in this project". I'm not sure whether that will matter to anyone but I guess people could be using the tool for years to come, so I thought it was worth mentioning. Thanks for getting 0.3.1 out so quickly with the path fix.


Persistent not needed for indexing

https://www.brentozar.com/archive/2019/12/the-two-ways-to-fix-non-sargable-queries/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f034f3c2-58c6-6a37-e5d3-3feb40c32681
Version Independent ID: 3efcf41e-30f3-6595-276b-abc3fbb8e69d
Content: computed_column_definition (Transact-SQL) - SQL Server
Content Source: docs/t-sql/statements/alter-table-computed-column-definition-transact-sql.md
Product: sql
Technology: t-sql
GitHub Login: @CarlRabeler
Microsoft Alias: carlrab

@winBoscoe -- thank you for your feedback and the tip.
@CarlRabeler -- please look into this potential documentation issue 3847.

@winBoscoe Please clarify the change that you would like to see in this topic related to indexing or not indexing of persisted columns - or, better yet, click Edit in the upper right-hand corner and propose a change for someone on our team to review.
Thanks - Carl


Check Delta is empty for chat

Description
Fixes # (issue) https://github.com/run-llama/llama_index/issues/9549
Type of Change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Added new unit/integration tests
[ ] Added new notebook (that tests end-to-end)
[ ] I stared at the code and made sure it makes sense

Suggested Checklist:

[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] I ran make format; make lint to appease the lint gods

I think this ignores the underlying issue.
Gemini calls this helper function
https://github.com/run-llama/llama_index/blob/01bd4de1cf6eb5f67a0598bd9f1a66f299a70234/llama_index/llms/gemini.py#L163
This yields a chat message for each chunk.
https://github.com/run-llama/llama_index/blob/01bd4de1cf6eb5f67a0598bd9f1a66f299a70234/llama_index/llms/gemini_utils.py#L72
However. This isn't setting the delta field that is used when reading streamed responses.
For an example of proper streaming, see here
https://github.com/run-llama/llama_index/blob/01bd4de1cf6eb5f67a0598bd9f1a66f299a70234/llama_index/llms/anthropic.py#L189
Likely we need a different utility function for handling streaming
Notice that it sets the delta, while content is set to the most "complete" version of the current streamed response


Pub remove appaddr

This change is

go/lib/discovery/discoveryinfo/info.go, line 61 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
Previously there was a copy, don't we need that anymore?

To my understanding no, because inside the *net.UDPAddr we have no other pointer reference or interface. Therefore we are safe.
If not, we have to find a unit-test which proves otherwise.

go/lib/discovery/discoveryinfo/info.go, line 61 at r1 (raw file):
Previously, karampok (Konstantinos) wrote…
To my understanding no, because inside the *net.UDPAddr we have no other pointer reference or interface. Therefore we are safe.
If not, we have to find a unit-test which proves otherwise.

There is a reference though, the net.IP slice. If a.IP changes after Update is called (e.g., a.IP[2] = 42), it will change h.addr.IP[2] to 42.


textsource.lua tokenizes incorrectly at newline

textsource.lua, l.90:
data = stringx.replace(data, '\n', '<eos>')

Data file contains:
A B C
A B C
A B C

Result: self._classes containing
{
  1 : "A"
  2 : "B"
  3 : "C<eos>A"
  4 : "C<eos>"
}

Suggestion: Wrap <eos> in spaces, like so:
data = stringx.replace(data, '\n', ' <eos> ')

New self._classes:
{
  1 : "A"
  2 : "B"
  3 : "C"
  4 : "<eos>"
}

Yeah you need to add a space between C and \n as in the PennTreeBank dataset.

It is not uncommon for text editors to trim trailing spaces at save, so this is somewhat a pitfall. The suggested fix should accommodate both PennTreeBank and custom TextSources.


Initial pass at Task development docs (and others)

I mostly created this for the developer documentation on how to create a new task, but I also pulled in the contribution doc, and started outlining the bigger picture of how Turbinia works (because I wanted to cover some of the details of Tasks and Evidence that I thought would fit better there than in the developer docs).  The how-it-works page isn't complete, but it's a start.
Note that the contributing doc is almost completely taken from the Timesketch project.  I just made a few Turbinia specific tweaks.

I moved this into a doc instead so we can collaborate more easily.


warning: comparison of unsigned expression in '>= 0' is always true [-Wtype-limits]

https://github.com/philips-software/embeddedinfralib/blob/11bb04457c0b116cf820e7b23f2d327293ea8b3b/infra/util/BoundedVector.hpp#L375
https://github.com/philips-software/embeddedinfralib/blob/11bb04457c0b116cf820e7b23f2d327293ea8b3b/infra/util/BoundedVector.hpp#L382
position is of type std::size_t, which is guaranteed to be unsigned. Comparing an unsigned with >= 0 is always true.
Ergo, the expression can be reduce to simply position < size()

Fixed in modern-cmake #74.


Some wrong with mxnet on spark: params.jars = jars.split(",|:")

The method setExecutorJars in org.apache.mxnet.spark.MXNet.scala has 'params.jars = jars.split(",|:")' sentence. If the jars from s3://path or hdfs://path, there will be wrong jar path, for example s3 or hdfs or others. Perhaps 'params.jars = jars.split(",")' is recommended.

@nswamy

@yzhliu @nswamy @@andrewfayres .I think we need to build regex to identify these different formats, will start a PR and try if I can solve that. @nswamy can you label this as Scala and bug in here?

An alternative is to let users use quotation mark. string in quotations should never be split: "s3://path":"hdfs://path"

Hi @liuzx32 , the jars will be used in this way:
jars.map(jar => SparkFiles.get(new File(jar).getName)).mkString(":")

It seemed we cannot directly place S3 or HDFS paths in here. So It's not necessary to initiate this change.

Not an issue at the moment and We will add a Feature Request to support jars from S3 and HDFS.

@yzhliu @lanking520 Mxnet on spark should be for yarn cluster mode not only yarn local mode. If every machine have the same configure of mxnet, why we need yarn or spark?

@lanking520 Perhaps the problem is here:
jars.map(jar => SparkFiles.get(new File(jar).getName)).mkString(":")
With the sentence how to run on yarn?


Freezes after Created: 128x128x0 minecraft:textures/atlas/mob_effects.png-atlas

Simply Optimized freezes after Created: 128x128x0 minecraft:textures/atlas/mob_effects.png-atlas

This isn't enough context for me to provide help. You should send the game logs in full. (you should also try to isolate the culprit mod, so by taking mods out until the issue no longer appears)

latest.log

latest.log

Does the issue occur in a fresh instance of SO with no extra mods? If not, try removing your added mods to isolate it to a single specific mod causing a problem. my first suspicion here would be PhysicsMod, as it gives an error earlier in the log about models or something. You could try disabling mixin.perf.dynamic_resources in modernfix-mixins.properties (iirc) and seeing if this helps.

It still freezes with a new installation

Sometimes it works, and sometimes it freezes

It shuffles like every month

No idea what might be going on here

hmm

Oh right

https://github.com/CaffeineMC/sodium-fabric/issues/899

Thank you, it's fixed now.


FAIL: test_retrieve_from_retired_backend

Information

Qiskit IBM Provider version:
Python version:
Operating system:

What is the current behavior?
This Cron-test failed with
======================================================================
FAIL: test_retrieve_from_retired_backend (test.ibm.test_ibm_job.TestIBMJob)
Test retrieving a job from a retired backend.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/qiskit-ibm/qiskit-ibm/test/ibm/test_ibm_job.py", line 448, in test_retrieve_from_retired_backend
    self.assertIn(new_job.job_id(), last_month_job_ids)
AssertionError: '615150b4d9c01f1d8bf8befa' not found in ['615150e3c5770cfe7a2d2125', '615150e3d9c01fd934f8befb', '615150e22e79b34791d362cd', '615150e143669acf282830f8', '615150e03799efc5c6dafc86', '615150ddc5770c50bd2d2124', '615150d22e79b30d73d362cb', '615150cc1281a5fb01b5e3e1', '615150c143669a63f52830f5', '615150c043669a3cfd2830f4']

----------------------------------------------------------------------

Steps to reproduce the problem
What is the expected behavior?
Suggested solutions

Still keeps failing https://github.com/Qiskit-Partners/qiskit-ibm/runs/3752216194?check_suite_focus=true

I think this test case sometimes fails because when new_job is created in setUpClass here by the time test_retrieve_from_retired_backend is run, it is not guaranteed that the original new_job is one of the 10 most recent jobs. This would explain why the test always passes when running locally but not in cron-test (also would explain why it passes/fails in different envs and python versions).
one solution would be to get all jobs with no limit from the last hour or day
 last_hour = datetime.now() - timedelta(hours=1)
 last_hour_jobs = self.provider.backend.jobs(limit=None, start_datetime=last_hour, backend_name=new_job.backend().name())

 last_hour_job_ids = [job.job_id() for job in last_hour_jobs]
 self.assertIn(new_job.job_id(), last_hour_job_ids)

Can we try with last 15 mins with no limit?


Venture timon

Some features still need to be added, but is enough for the launch

Build logs why Preview deployments are failing - Simon
[00:28:33.124] Running build in San Francisco, USA (West) – sfo1
[00:28:33.192] Cloning github.com/tum-ai/website (Branch: venture-timon, Commit: daf1f83)
[00:28:35.710] Cloning completed: 2.518s
[00:28:35.849] Restored build cache
[00:28:35.881] Running "vercel build"
[00:28:36.404] Vercel CLI 31.0.4
[00:28:36.680] Installing dependencies...
[00:28:36.977] yarn install v1.22.17
[00:28:37.039] [1/4] Resolving packages...
[00:28:37.236] [2/4] Fetching packages...
[00:28:53.102] [3/4] Linking dependencies...
[00:29:06.009] [4/4] Building fresh packages...
[00:29:06.463] Done in 29.49s.
[00:29:06.509] Detected Next.js version: 13.0.7
[00:29:06.511] Running "yarn run build"
[00:29:06.715] yarn run v1.22.17
[00:29:06.748] $ next build
[00:29:07.302] info  - Linting and checking validity of types...
[00:29:10.076]
[00:29:10.077] Failed to compile.
[00:29:10.077]
[00:29:10.078] ./pages/e-lab.tsx
[00:29:10.078] 192:41  Error: ' can be escaped with ', ‘, ', ’.  react/no-unescaped-entities
[00:29:10.078] 193:68  Error: ' can be escaped with ', ‘, ', ’.  react/no-unescaped-entities
[00:29:10.079]
[00:29:10.079] ./components/Testimonials.tsx
[00:29:10.079] 17:11  Error: " can be escaped with ", “, ", ”.  react/no-unescaped-entities
[00:29:10.079] 21:13  Warning: Using <img> could result in slower LCP and higher bandwidth. Use <Image /> from next/image instead to utilize Image Optimization. See: https://nextjs.org/docs/messages/no-img-element  @next/next/no-img-element
[00:29:10.084]
[00:29:10.084] info  - Need to disable some ESLint rules? Learn more here: https://nextjs.org/docs/basic-features/eslint#disabling-rules
[00:29:10.105] error Command failed with exit code 1.
[00:29:10.106] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[00:29:10.134] Error: Command "yarn run build" exited with 1


Support relative paths in .code-workspace files

VSCode Version: Code - Insiders 1.15.0-insider (9912a545c9728ce5e6b3cdfcc9442ee47955aa42, 2017-07-21T05:16:15.475Z)
OS Version: Windows_NT ia32 10.0.15063

I'd like to be able to share a .code-workspace file in a Git repo. For that, the file paths have to be relative. It seems this already sort of works if you manually edit the file to use relative file URIs starting with file:./. However, that seems to make the path relative to the VSCode installation dir, rather than the directory that contains the workspace file:

{
	"id": "1500632094036",
	"folders": [
		"file:./TestProject"
	]
}

Yes, this is planned for the future. I find the syntax interesting to use file protocol with a relative path, @jrieken could maybe advise if this is OK to do instead of just having a relative path in there. What I like about keeping it a file URI is to know that this is a resource on disk.

@jrieken could maybe advise if this is OK to do instead of just having a relative path in there. What I like about keeping it a file URI is to know that this is a resource on disk.

Yep, that is valid uri and should be parsed into {scheme: file, path: ./TestProject}. Just make sure to normalise and resolve them early before passing it around. Actually the same is true for file:///User/foo/../bar/./far etc etc

Fixed via https://github.com/Microsoft/vscode/pull/33097


x/exp/shiny: no API to change a window size

it seems there is no way to programmatically change a screen.Window size.
currently, a screen.Window size can only be changed from outside the program (e.g. using the mouse).
I'd propose to extend screen.Window as such:
type Window interface {
  // ...

    // Resize resizes the window.
    Resize(size image.Point)

    // Size returns the size of the window.
    Size() image.Point
}

Given there is the type NewWindowOptions here https://github.com/golang/exp/blob/master/shiny/screen/screen.go#L145
What if that type were simply WindowOptions and type Window interface declared something along the lines of SetOptions(opt WindowOptions), that way it can remain flexible with time as more options are added.

cc @nigeltao
First off, adding a Size method will have to wait until https://golang.org/cl/17055 is done and is more about how much state the Window object should track and make available. I'd like to punt that to another issue if you don't mind.
As for Resize, having a way to do it is reasonable. But there are several other related options and I'd like to think through how those work in an API. For example:

move
minimize / maximize
fullscreen

Do all of these have to have their own methods? Can (or should?) they be combined into an Options struct? Additionally, there's going to be a lot of overlap between these features and NewWindowOptions. Is there any overlap that can be reused?

The first issue that comes to mind with a combined options struct is what zero values mean. If I have a window specifically sized at 400x300 and I simply want to update the window transparency, I might expect win.SetOptions(WindowOptions{Transparency: 0xCC}) to work, yet this might trigger the driver to change the window size since width/height are zero in new options. Something to think about.

for this, the functional-options idiom is probably best:
http://dave.cheney.net/2014/10/17/functional-options-for-friendly-apis
// ----------------
package screen
var (
  WindowSize func(Window)
  WindowTransparency func(Window)
)

// -----------------
package mydriver

func (s *screenImpl) NewWindow(opts ...func(w screen.Window)) (screen.Window, error) {
  // ...
}

func windowSize(width, height int) func(w screen.Window) {
  return func(w screen.Window) {
     xw := w.(*windowImpl)
     xw.width = width
     xw.height = height
  }
}

func windowTransparency(v uint16) func(w screen.Window) {
  return func(w screen.Window) {
     xw := w.(*windowImpl)
     xw.setTransparency(v)
  }
}

func init() {
  screen.WindowTransparency = windowTransparency
  screen.WindowSize = windowSize
}

// -------------------
package main

func foo(s screen.Screen) {
  w, err := s.NewWindow(
       screen.WindowTransparency(0xCC),
       screen.WindowSize(600,600),
  )
  //...
}

(except "of course" when screen doesn't know anything about xyzdriver.windowImpl, so gymnastics are needed...)

@sbinet I believe a simple version of the gymnastics required for the driver packages would be to make each option a data type instead of a function;
func NewWindow(opts ...WindowOption) { /* ... */ }

type WindowOption interface {
        windowOption()
}

type WindowSize image.Point

func (WindowSize) windowOption() {}

type WindowPosition image.Point

func (WindowPosition) windowOption() {}

func f() {
        // ...
        NewWindow(
                WindowPosition(image.Pt(10, 20)),
                WindowSize(image.Pt(300, 300)),
        )
}

Each driver can switch on the concrete type of each WindowOption and do what it sees fit with each value. WDYT?

SGTM

Drive-by comment:
I have to say I'm not a huge fan of either of the above approaches,  although I understand the motivation. A simple struct (with pointers where necessary) always strikes me as much more clear even if it might be a little more awkward to use sometimes.

As @crawshaw hinted at, I'd like to avoid incrementally adding a dozen odd SetThis and SetThat methods to the Window interface, one by one in an ad hoc manner. The NewWindowOptions type already lists things like fullscreen, title, icon, cursorHidden in its TODO comments. There are undoubtedly more we could add. I'd like to have some sort of principled approach to where we draw the line.
One consideration is that not all systems support programmatic resizing. For example, on mobile, the app has no say in its window size. Also, on X11, strictly speaking, the app can only make a request, and it's perfectly valid for the window manager, a separate program, to set the app window's size to be something different, such as what tiling window managers do.

What's the status on this? Additionally an option to fullscreen windows would be huge.

I'd definitely like to know, too. If it's still a syntax issue, then I'd like to cast a vote for the functional parameters style.
Also, congratulations, @belak. You're the first person I've run into on here with a Quote avatar.

No status update since my previous comment.
It's not just a syntax issue. To quote my previous comment: "I'd like to avoid incrementally adding a dozen odd SetThis and SetThat methods to the Window interface, one by one in an ad hoc manner... I'd like to have some sort of principled approach to where we draw the line."


[bug] InvalidOperationException at end of lengthy processing session.

Describe the bug
Ran to 98% and errored on line 788 of MainViewModel
Line 788 is   await DialogHost.Show(new MessageBoxDialogViewModel(Strings.Done)).ConfigureAwait(true);
An unhandled exception of type 'System.InvalidOperationException' occurred in System.Private.CoreLib.dll
No loaded DialogHost have an Identifier property matching dialogIdentifier ('') argument.
To Reproduce
I have a geotiff that it fails on but it takes some 3 hours to process and fails just as it's getting close to finishing.
Input data info
data is some 9Gb in size I think it's less about the geotiff file itself and some bug in the I'm finishing up code. I can provide the file if required. I'd need to provide a private communication to provide a download link rather than posting a public link to github.
Expected behavior
I'd expect when it reaches 100% it gracefully completes.
Desktop:
Windows 11 patched up to Patches issued on Patch Tuesday 9th May 2023.
I'm using VS 2022 v17.5.5 using code built as of Merge pull request https://github.com/Gigas002/GTiff2Tiles/pull/216 from Gigas002/dependabot/nuget/MaxRev.Gdal.Wi… on May 10th 2023. building from source.
In case it's relevant I was running the GUI version.

Hello.
If possible, would you mind testing the latest build with any tiff from Examples directory? The error looks like a GUI only, so it's possible, that latest PR's (related to MaterialDesign stuff) fixed the error. I, unfortunately, doesn't own a windows machine right now, and no longer contribute to this project with exception for dependabot alerts, but I'll try to help you with the issue as much as I can

It does appear to be GUI only indeed now I've looked at the code in the cold light of day (aka after sleeping). I can see that the line I referenced is actually simply a "Done" message box. I've not done any wpf coding before so not familiar with the need for the async calling for displaying a static message box. If the async isn't required then the code simplifies from
await DialogHost.Show(new MessageBoxDialogViewModel(Strings.Done)).ConfigureAwait(true);
to
MessageBox.Show(Strings.Done);

async is important to not block a GUI thread, and there's no MessageBox class from WinForms in WPF/Avalonia (I guees same true for UWP and MAUI), at least there weren't several years ago. Of course, there are several libraries that make usage of MessageBox in WPF possible, even using MaterialDesign ones, but it's not a good approach, plus I'm sure they use same DialogHost under the hood, which is a correct way to output messages in dotnet's GUI.
Current DialogHost is used fom MaterialDesignThemes, so I guess something there caused the regression

OK, I found out the source of regression, it's in 4.3.0 version. I managed to fix the issue in GTiff2Tiles and will commit the changes soon


Problems with julia-client

I have been experimenting several issues with julia-client, because my Antivirus (Avast) finds files inside julia-client as they were viruses. Atom showed me a message today that they were updates for ink and julia-client, so I updated them to the lastest version, so I could see if the problems were solved, and now when starting Atom, it shows the next message:
"Failed to load the julia-client package
Cannot find module 'etch'"
I'm new to Atom and Julia and that stuff and I'm a not so experimented person about technical languages/instructions, so I would be thankful if you could help me and explain the solution the simplest way possible. Thanks.

Have a look at this for the probably safest way to re-install julia-client.
The Antivirus issue is somewhat related though -- you might need to disable it during the installation and add an exception for C:\Users\you\.atom\packages\julia-client\node_modules\node-pty-prebuilt\build\Release\winpty-agent.exe as described here.

Thanks! It worked, but I have another Error now when I run a .jl file, I got the next message:
"An error occurred while compiling the Stan program.
Please check your Stan program in variable 'schools8' and the contents of C:/Users//Desktop/tm
p/tmp/tmp/schools8.exe_build.log."
schools8.exe_build.log said:
"uname: not found
uname: not found
g++.exe: error: stan/lib/stan_math/lib/cvodes_2.9.0/lib/libsundials_nvecserial.a: No such file or directory
g++.exe: error: stan/lib/stan_math/lib/cvodes_2.9.0/lib/libsundials_cvodes.a: No such file or directory
make: *** [C:/Users//Desktop/tmp/tmp/tmp/schools8.exe] Error 1"
Do you know how can I fix this? I looked in my cmdstan folder and libsundials_nvecserial.a and libsundials_cvodes.a do not exist anywhere, so is that an error? I mean those files should be inside cmdstan, but they do not exist, are they missing?
OS: Windows 10 CmdStan: cmdstan-2.17.1 Rtools: 3.4 Julia: 0.64, I tried the 2.18.0 version of cmdstan and it did not work well.
I would appreciate if you could help me. Greetings.


Add configurable timeout to az webapp deploy

Is your feature request related to a problem? Please describe.
A long-running deployment may cause the command to exit too early. The deployment will continue in the background, but this does not work for automations where the deployment needs to have completed. The issue seems to be with https://github.com/Azure/azure-cli/blob/dev/src/command_modules/azure-cli-appservice/azure/cli/command_modules/appservice/custom.py#L1974
Describe the solution you'd like
Add flags such as --num_status_checks and --num_seconds_between_checks to allow users to configure this window, keeping the default behavior as-is. Even better to just let someone specify the aggregate timeout window and dynamically calculate the number of checks required (keeping the 15s delay between). So then I could just say --timeout 3600 or similar.
Describe alternatives you've considered
Scripting a loop on one's own, basically re-coding the az webapp deploy command. isAsync would be required due to an additional server-side timeout that is in place.
Additional context
N/A

CC @panchagnula

@yugangw-msft , FYI - this is becoming a high pri issue on our end. planning to add --timeout as an optional parameter so that we can allow a customer to keep polling for longer.

Done through #7828


Propagate common options for async persist request

Fix for https://github.com/Alluxio/alluxio/issues/8404

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3053/
Test PASSed.

@ZacBlanco @calvinjia PTAL.

After checking the code I see that common options for async-persist request is not even used on master side. So no  meaningful testing is possible at this point. @calvinjia WDYT?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3062/
Test PASSed.

Ping!

I think we could still add a unit test that checks that the RPC which is being made at least contains the expected common options. Even if not used on the master, it is good verification that options are propagated properly

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3115/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3116/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/3117/
Test PASSed.

Opened a separate issue for tracking the issue of not making use of common options on master side.
https://github.com/Alluxio/alluxio/issues/8891

alluxio-bot, merge this please.


Remove boxplot tools

Is your feature request related to a problem? Please describe.
The tools of the boxplot have no effect, besides moving the plot to the side.
Describe the solution you'd like

[x] Remove the five tools that are not needed, but keep the export functionality.
[x] Remove the y-offset from the toolbar, as it will now fit next to the title again.

Describe alternatives you've considered
Make the toolbar function properly, i.e. make the zoom available for the vertical direction and not just the horizontal.

Completed with #75


bugfix for network banner grab

handles struct and map metadata fields as interfaces

@madhavmvats01 you test against that example that broke it I presume?


Clear Xcode Archives

New Issue Checklist

[x ] Updated fastlane to the latest version
[x ] I have read the Contribution Guidelines

Issue Description
Every time Xcode archives an app, it creates a .xcarchive file in ~/Library/Developer/Xcode/Archives. This folder can get rather large over time. I would like the ability to deletes these files with a fastlane command (similar to clearing derived data).

i am not sure if there is an existing fastlane action for that, but you can always shell out.
i do this in my fastfile on the ci machines (to clean archives):
sh(command: "rm -vfr ~/Library/Developer/Xcode/Archives/*")

let me know if this helps you.

Piggy backing on what hjanuschka said, I have a job running monthly that backs up then removes any older than 90 days. For my setup, having removal per build or scripted into fastlane another way was a bit overkill considering how infrequently it becomes an issue.

I'm going to close this issue since it has been open for a while without follow up from the author.


feat(pie-icons-vue): DSW-862 replaced bili with rollup

"@justeattakeaway/pie-icons-vue": minor
[Changed] - JS bundler in package from Bili to Rollup
"wc-vue3": minor
[Added] - style links to index.html so buttons are styled

💯 Everything seems perfect, though I see a main difference between the Vue and React icons packages.
The React one generates barrel files for tying the independent icons files together, so they can be imported or required like the documentation describes:  import { IconCalendar, IconAlertTriangleLarge, ... } from '@justeattakeaway/pie-icons-***';.
Should we keep the consistency and provide the barrel files?

💯 Everything seems perfect, though I see a main difference between the Vue and React icons packages.
The React one generates barrel files for tying the independent icons files together, so they can be imported or required like the documentation describes: import { IconCalendar, IconAlertTriangleLarge, ... } from '@justeattakeaway/pie-icons-***';.
Should we keep the consistency and provide the barrel files?

@fernandofranca thank you 🎉 is the barrel file in the react one the index.tsx that gets generated on build? I believe the same is happening in pie-icons-vue inside the generated folder. I have tested the changes in the nuxt example app by importing them like above and all is working 😄


Decide on testing approach

How will we do exercise tests?
from gitter:

do we want a simple test runner

I think Red is sufficiently capable to use just pure Red for testing. Perhaps some patterns emerge after couple exercises, then we'll just apply DRY principle and distill some testing code?
There is quick-test, but It seems there's code in Rebol there. Are there any other test suites? I use this simple script of mine for testing: test.red, and it's used like this

In the very near future (we hope) the Red DL will be the prebuilt console directly, so you can run instantly, but it's not that way yet.
Agreed on testing. I roll special case testers, and we'll find what works well there. I don't think quick-test is the best choice for this purpose.

Agreed on testing. I roll special case testers, and we'll find what works well there. I don't think quick-test is the best choice for this purpose.

Ok, so we have it figured out. Example: hello-world-test.red@a4cb921d

Great. Here's a standard test func I use as a baseline in a number of places:
	test: func [block expected-result /local res err] [
		if error? set/any 'err try [
			print [mold/only :block newline tab mold res: do block]
			if res <> expected-result [print [tab 'FAILED! tab 'expected mold expected-result]]
		][
			print [mold/only :block newline tab "ERROR!" mold err]
		]
	]


treeshake imports based on guest content

This is a WIP as I have not tested it much yet. I am not sure how transitive imports will be passed down. Since we only pass in the imports directly present in the guest content.

And I could immediately see that happening in practice, too: we support top-level await, which means code could dynamically decide to import component interfaces, which the lexer wouldn't be able to see.

We do not currently support dynamic import() currently in StarlingMonkey, since we do not register a JS::SetModuleDynamicImportHook hook. If and when we do I agree this question definitely comes up.
Note that ComponentizeJS performs source transforms using the same lexer already, as it has to perform a replacement of the world imports with the generated bindings modules.
Separately, we don't currently support transitive imports at all - which we probably should as well. But since this is a missing feature, again could be a follow-up to this PR in supporting the transitive rewriting and not just for the top-level source.
If we did want to move more of this process into StarlingMonkey, what would be needed is a full loader API - the ability to define source transforms and resolver hooks at the engine level. One problem here is how to communicate the source transform without causing the code for the source transform to be linked in unnecessarily to the final build. So a solution would likely need to be found for that communication problem (eg via a Wizer-time dedicated "resolve" / "loadSource" host call technique).

Thank you for the excellent context, @guybedford! With all that understood, I think it's more than fine to land this with the external lexer, and eventually look into moving more of this and other things into StarlingMonkey itself.

I made an attempt to update this PR based on https://github.com/bytecodealliance/ComponentizeJS/pull/116#discussion_r1658935176. I am not entirely sure if I am on the right track. I am also not sure how to debug the failing test (my suspicion is that it has something to do with transitive imports in the wit level).  Some guidance here would be really appreciated. Thanks!

I have updated the PR to fix the failing test and also addressed the comment.

I tested this out with a simple scenario and it seems to work well!
I've added an update here to properly handle export aliases. It doesn't fully handle the alias deduping logic yet which is supposed to only support aliases when they don't conflict. To handle that we should move the alias conflict detection logic to a preprocessing stage that is not related to the esm_bindgen like we currently rely on for populate_export_aliases.
It could be nice to even handle treeshaking for function import bindings off of an interface ie import { name } from 'pkg:name@v/iface' to support knowing only name is used from iface, but that can be a follow-up separately.
This code looks good to land to me, please test it out once more there @karthik2804 and let me know if you are happy to release.
We will need a test that verifies the export and import tree-shaking in this PR to land it though. Just let me know if you want to discuss how to set up the wiring for that if you want more feedback on that.

I've pushed up a simple failing test case here to verify that imports and exports get treeshaking applied. In the process I discovered two remaining issues:

When treeshaking, we are going to change the offset indices of the generated functions. We therefore need to main an offset diff table that can be applied to all function offset lookup functions (specifically in the splicer import lookup function). We should specifically test the case where a middle import is removed that the second import in world order doesn't bindgen to the wrong function.
The current treeshaking work does not support filtering resources at all - and as a result all resource bindgen is still being performed. We need to more carefully consider and handle a proper resource tree-shaking ability, similarly to how Jco dynamically pulls in resources as they are needed during function bindgen (see how create_resource_fn_map is called per function generation in https://github.com/bytecodealliance/jco/blob/main/crates/js-component-bindgen/src/transpile_bindgen.rs#L1755).

There is therefore still quite some work to do here. Sorry I can't be of more help.

An alternative to (1) would be to carefully ensure that in all bindgen, exports ordering is defined to be the ordering after treeshaking. Either way though requires careful review of the ordering.

@guybedford can you walk me through the 2 remaining issues a little more? I do not fully grasp it. My apologies if I am being slow.

@karthik2804 I took another look at this today and was able to resolve most of the remaining concerns I had:

It turned out we just needed to move the world merge to before encoding the component, as opposed to before the bindgen. I think this should work out correctly now!
With this model imports and exports are now the world imports and exports only, BEFORE merging with the engine world. I think this makes sense because you can always analyze the output component to get the merged imports and exports. Perhaps we should call them, guestImports and guestExports in the API?
I feel more confident that ordering is not an issue in bindgen now, given that all imports and exports lists in the JS and Rust code correspond to this same list that is the original world after treeshaking, but before the engine merge.
Resource treeshaking seems fine to do as a follow-up further, where we walk resources as functions are used to only pull in what is used by functions as opposed to all resources. This seems like it could be a nice refactoring to the resource bindgen as well as discussed in https://github.com/bytecodealliance/jco/blob/main/crates/js-component-bindgen/src/transpile_bindgen.rs#L1755. I have no problem deferring that work, and we can create an issue to track it further as needed.

The tests for imports treeshaking are now fully passing.
There is only one final thing then that we need to discuss now and that is the exports treeshaking, which still has a failing test.
Strictly speaking, I believe exports are supposed to be mandatory for component generation - that is a component can only be encoded to a world when it provides all of the expected exports. Not providing an export is typically seen as an error.
Therefore I'd like to understand more about exports treeshaking and how it might be used in this case? And then if we want to support this exports treeshaking feature then we must also add support for removing unused exports from the world itself before encoding the component.

@guybedford That sounds exciting!
On the note of exports tree shaking - the original intent of the PR started with only the goal of imports tree shaking. The reason we started analyzing the guest exports was to implement what #116 took a stab at. (i.e) retain the fetch event if the guest does not export an explicit incomingHandler. I do not think we need to tree shake exports otherwise. I fully agree that not having all the exports defined in a world should be an error. I do not see an issue with retaining even unused exports as the output component will still be compliant with the target world.

@karthik2804 okay, in that case, let's remove the exports treeshaking entirely for now then. As for the imports listing, we should probably have two lists like imports and guestImports to use in the test. Your approach is correct but I think ideally we should avoid unnecessary processing, by finding another approach or via precomputing the list of engine exports.

We could pre-compute the list of engine exports as a part of the build step possibly? run it between the build of Starlingmonkey and before the splicer is built?

Also with removing the exports tree-shaking, would we still need #116? cc: @tschneidereit

I've updated the exports treeshaking to instead provide a missing guest export error and added a test for that.
For the incoming handler, we probably do still want to support that case, as that is about the engine itself?
I'm happy to just document for now that imports is the guest imports and that the component should be analyzed directly to get the full component imports. The actual used guest imports seems more useful to me? Does that make sense?
If so, let's land and release.

That makes sense to me! I really appreciate you guiding me and helping take this over the line! Thanks!

Ok will do. This is a fantastic feature to have, thanks for working on it! Hopeful we can get to interface analysis for cases like import { fn } from 'interface' knowing only fn is used from the given interface, and also resource tree-shaking in due course. But this is a great start.

Released in 0.10.0.

Thank you!


1.3 Release feedback

Before cutting the 1.3 release, we should fix the following issues:

[ ] HTTP headers are wrong for introspection query

[ ] Once the schema sidebar was toggled, there is a white overlap

[ ] Most right selection element should be blue instead of grey

[ ] HTTP headers should have a count of headers (example: HTTP HEADERS (2)

[ ] HTTP headers overlap

[ ] Main settings should be under editor namespace

Example:
{
  "editor.theme": "dark",
  "editor.reuseHeaders": true
}

[ ] graphql playground is blocking

[ ] graphql playground doesn't work if GraphQL Playground wasn't open before

[ ] Double click a *.graphql file doesn't open file but just playground

[ ] cli first open window not opening file correctly

[ ] panels jump & cannot be resized properly

[ ] Tabs cut off at the wrong spot


[bump]: Rust toolchain and CI container to nightly-2023-06-25

Caution, make sure all CI checks pass before merging.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
955 unchanged lines in 27 files lost coverage.
Overall coverage decreased (-0.06%) to 59.375%

Files with Coverage Reduction
New Missed Lines
%

client_cli/src/main.rs
1
0%

client/src/http_default.rs
1
0%

cli/src/main.rs
1
0%

core/src/smartcontracts/isi/asset.rs
1
29.79%

data_model/src/transaction.rs
1
47.66%

derive_primitives/src/lib.rs
1
0%

macro/derive/src/lib.rs
1
94.59%

wasm_codec/derive/src/lib.rs
1
90.68%

config/base/src/lib.rs
2
91.94%

tools/kagami/src/main.rs
3
2.01%

Totals

Change from base Build<PHONE_NUMBER>:
-0.06%

Covered Lines:
19858

Relevant Lines:
33445

💛  - Coveralls


Cache clearing .clear is not a function

Describe the bug
Caching the keys is working just fine, but when i am trying to clear any key or even all keys I am getting
using
await cache.clear('key')
ts_cache_mongoose_1.default.clear is not a function
if i try to call the method from the prototype i get
Cannot read properties of undefined (reading 'del')

What was the solution for this?

I just used the instance of cache that the cache.init code returned.
You can't just use default import everywhere else, it probably need to be added to the documentation, now I am having another problem
Your cache clear doesn't get cleared if you are using engine memory and not redis

Lets open a ticket if that's the case

Can you prove exact snippets of code that you wrote that resulted in you not being able to to clear cache


Add on-the-side code lens for visual studio using text decorations

Maybe they will not be interactive, but it should be a nice improvement w.r.t. vertical space.

https://github.com/cquery-project/vscode-cquery/issues/9


How to specify variable string output?

So far my output IM looks like the image provided. Although I'm sure there are other issues with it, the main one seems to be the specification of the first two outputs.

The first output isn't a string, just a description of the string that should be outputted. My thought is that the output of the balanced equation should match the format of the input, but since the input format is a design decision that shouldn't be specified, this means that the output format is also a design decision. Am I misunderstanding something? Is this sufficient?
I have a general template of what I want the output to look like (as @smiths pointed out in his review). For any elements that are present on one side but not the other, this information should be communicated to the user; for example, "This reaction is infeasible because O and Cl appear on the reactant side but not the product side and Mg appears on the product side but not the reactant side, violating the Law of Conservation of Mass." This would require another data definition to get the elements on each side that violate this law, which wouldn't be hard to do, but before I do, is it something that I should even bother with? If so, how would I specify it formally?

@samm82 I think this IM3 is problematic because it mixes the output for a feasible solution with the output for infeasible solutions.  You have your IM for the balancing the chemical equation (IM2).  You can just have a requirement that outputs the results of IM2, if they exist.  (I wouldn't even think of it as outputting a string.  It is just outputting the answer.  What that looks like depends on future design decisions, as you said.)
For the infeasible case, I think you just want a requirement that will tell the reader if there is no feasible balanced equation.  You shouldn't try to figure out why it isn't feasible.  Basically you are going to try the minimization - if you find a solution that way, you output it, if you don't find a solution, you tell the user.  Why the minimization problem fails is outside the scope of the current work.  (You should say that explicitly in your SRS.)
I don't know if you even need an IM for the infeasible case.  From the SRS point of view, a requirement is enough.  If this turns out to be problematic for the code generator, we can revisit it, but for now, I think you can simplify things and completely remove your IM3.

Since I won't be adding IM3 to the Drasil version of the SRS (for the reasons outlined above), this issue can be closed.


Strange intermittent "hanging" issue

Sadly I had to uninstall RDPWrap due to a strange intermittent "hanging on bootup" issue.
It was such a strange issue and very hard to isolate that RDPWrap was somehow causing it - but after uninstalling the wrapper, all is well now.
Basically, upon bootup & first login, a strange hanging effect was noticed in Windows 7 SP1 x64. Event viewer indicated the following errors whenever this phenomenon occurred:

A timeout (30000 milliseconds) was reached while waiting for a transaction response from the NlaSvc service.
A timeout (30000 milliseconds) was reached while waiting for a transaction response from the CryptSvc service.
The server {F9A874B6-F8A8-4D73-B5A8-AB610816828B} did not register with DCOM within the required timeout.

(the third error's CLSID refers to "Terminal Services Connection Manager Class")
It's not clear to me why RDPWrap was causing these issues, but since RDPWrap touches each of the 3 services mentioned above, I thought there might be a connection. After uninstalling RDPWrap I am no longer getting this behaviour.

Try to add rdpwrap.dll to your antivirus exclusions
Try to use this command to isolate RDP Wrapper from other shared services:
sc config TermService type= own

I confirm that adding rdpwrap.dll to antivirus exclusions (in this case, Microsoft Security Essentials) has fixed the problem. No more strange hanging/freezing, even after multiple reboots.
Perhaps it will be a good idea to add this as a "known issue" to the Readme?

Good idea, I'll do it on the next release.


Could not calculate next timer TypeError: nextProcessTime.getDay is not a function

In drop down menu for setting timers the weekday is greyed out.
Log file shows:
error: mihome-vacuum.0 (3420) Could not calculate next timer TypeError: nextProcessTime.getDay is not a function
mihome-vacuum : 3.1.4
js-controller 3.3.7
nodeJS 14.16.1
roborock.v1

thats a little bug in the dropdown, you have to click a little bitt above the checkbox, then it is working


[bug]: Cannot load legacy checkpoint, diffusers conversion fails

Is there an existing issue for this?

[X] I have searched the existing issues

OS
macOS
GPU
mps
VRAM
No response
What version did you experience this issue on?
2.3.5.post2 and 2.3.5.rc2(I think before I updated just now)
What happened?
When loading a new checkpoint trained with EveryDream v2, the model fails to load, and model selection reverts back to previous. Checkpoint loads fine in both Automatic1111 and Draw Things (macOS) and both work as expected.
Also, despite disabling legacy checkpoint conversion to diffusers in config, console still prints
>> Converting legacy checkpoint dmemxt-v5 into a diffusers model...
The error output is here:
>> Model change requested: dmemxt-v5
>> Current VRAM usage:  0.00G
>> Cache limit (max=1) reached. Purging stable-diffusion-1.5
>> Loading dmemxt-v5 from /Users/..../models/StableDiffusion/dmemxt-v5.ckpt
>> Converting legacy checkpoint dmemxt-v5 into a diffusers model...
   | global_step key not found in model
   | Using checkpoint model's original VAE
** model dmemxt-v5 could not be loaded: Error(s) in loading state_dict for CLIPTextModel:
	Missing key(s) in state_dict: "text_model.embeddings.position_ids".
Traceback (most recent call last):
  File "/Users/.../InvokeAI/.venv/lib/python3.10/site-packages/ldm/generate.py", line 964, in set_model
    model_data = cache.get_model(model_name)
  File "/Users/../InvokeAI/.venv/lib/python3.10/site-packages/ldm/invoke/model_manager.py", line 105, in get_model
    requested_model, width, height, hash = self._load_model(model_name)
  File "/Users/.../InvokeAI/.venv/lib/python3.10/site-packages/ldm/invoke/model_manager.py", line 317, in _load_model
    model, width, height, model_hash = self._load_ckpt_model(
  File "/Users/.../InvokeAI/.venv/lib/python3.10/site-packages/ldm/invoke/model_manager.py", line 376, in _load_ckpt_model
    pipeline = load_pipeline_from_original_stable_diffusion_ckpt(
  File "/Users/.../InvokeAI/.venv/lib/python3.10/site-packages/ldm/invoke/ckpt_to_diffuser.py", line 1296, in load_pipeline_from_original_stable_diffusion_ckpt
    text_model = convert_ldm_clip_checkpoint(checkpoint)
  File "/Users/.../InvokeAI/.venv/lib/python3.10/site-packages/ldm/invoke/ckpt_to_diffuser.py", line 860, in convert_ldm_clip_checkpoint
    text_model.load_state_dict(text_model_dict)
  File "/Users/.../InvokeAI/.venv/lib/python3.10/site-packages/torch/nn/modules/module.py", line 2041, in load_state_dict
    raise RuntimeError('Error(s) in loading state_dict for {}:\n\t{}'.format(
RuntimeError: Error(s) in loading state_dict for CLIPTextModel:
	Missing key(s) in state_dict: "text_model.embeddings.position_ids".

Screenshots
No response
Additional context
Only happens with EveryDream2 models trained yesterday and today on RunPod, so could be something that changed in EveryDream. Older EveryDream checkpoints load fine in InvokeAI.
New checkpoints works in Automatic and Draw Things
Contact Details
No response

@bedalton @hipsterusername How was this solved?

@bedalton @hipsterusername How was this solved?

To be candid, we did a massive issue clean-up for anything pre-3.0. I would not be able to attest to this working without follow-up/re-testing, but I haven't seen many reports in discord, and we have a few Everydream contributors that are regulars.

@bedalton @hipsterusername How was this solved?

To be candid, we did a massive issue clean-up for anything pre-3.0. I would not be able to attest to this working without follow-up/re-testing, but I haven't seen many reports in discord, and we have a few Everydream contributors that are regulars.

I managed to make a rough patch myself.
In my case, I tried to use 2.3.5 with a newer Diffusers version which had changed some key names.
To fix it, I edited model_manager.py from this:
        vae = AutoencoderKL(**vae_config)
        vae.load_state_dict(diffusers_vae)
        return vae

to this:
        vae = AutoencoderKL(**vae_config)
        try:
            vae.load_state_dict(diffusers_vae)
        except:
            diffusers_vae = { key.replace(".query.", ".to_q.").replace(".key.", ".to_k.").replace(".value.", ".to_v.").replace(".proj_attn.", ".to_out.0."): value for key, value in diffusers_vae.items() }
            vae.load_state_dict(diffusers_vae)
        return vae

Raising for visibility up to @lstein

In my case the code posted by n00mkrad never gets called as I have is_accelerate_available, but it gave me an idea to change the attributes myself. In my case there are added parameters to_to_q, to_to_v, and to_to_k, which caused errors. So I modified convert_ckpt_to_diffusers and on line 178 after:
https://github.com/invoke-ai/InvokeAI/blob/ae17d01e1d2b4f2ef85a5df6c6e4d7ce0f378ca9/invokeai/backend/model_management/convert_ckpt_to_diffusers.py#L176-L177
I added:
if "to_to_q" in new_item:
    new_item = new_item.replace("to_to_q.weight", "to_q.weight")
    new_item = new_item.replace("to_to_q.bias", "to_q.bias")
if "to_to_k" in new_item:
    new_item = new_item.replace("to_to_k.weight", "to_k.weight")
    new_item = new_item.replace("to_to_k.bias", "to_k.bias")
if "to_to_v" in new_item:
    new_item = new_item.replace("to_to_v.weight", "to_v.weight")
    new_item = new_item.replace("to_to_v.bias", "to_v.bias")

This mostly works, but twice I had to adjust VAE and VAE precision to get it to work without problems

Definitely an EveryDreamV2 problem, so I plan to let them know

Definitely an EveryDreamV2 problem, so I plan to let them know

I have tried it all and the only working solution I found is this:
https://github.com/s9roll7/animatediff-cli-prompt-travel/issues/38#issuecomment-1732512147


Cross publish to 2.12, remove duplicate license, 2.12.0 -> 2.12.1

Also removed unused compiler plugins

Looks good to me!

This will also close #10


S0A

line 115:
sta  = list(locs.iloc[:]['station'])
there are some bugs if the stations are named by pure number, it's better to follow this line with:
sta= [str(i) for i in sta]

@beyondTaoLei thanks for your suggestion, which sounds like a good idea to me. Will incorporate this change into the new version.


npm update

Thanks for the great work patrickkunka!
Could you update your npm package to the latest version?
https://www.npmjs.com/package/mixitup
Regards,
Haris

Oops, must have forgotten to do that at the time, NPM now up to date.

Thanks!


Using multiple OR expressions in a query causes SoftDelete and Tenancy filters to be appended incorrectly

When upgrading our app from 1.5.2->2.1, I found that any query that contains multiple OR expressions against an object configured for Soft Deletes will return all objects of that type instead of the expected filtered list.
It appears to be a problem when adding the soft delete clause to the database query.  If there are multiple expressions that need to be OR'd, then the d.mt_deleted = False clause is also added as an OR instead of an AND.
Multiple expressions will cause incorrect behavior:
var query = session.Query<SoftDeletedItem>().Where(x => x.Number == 1 || x.Number == 2);
=>
select d.data, d.id, d.mt_version from public.mt_doc_softdeleteditem as d where (CAST(d.data ->> 'Number' as integer) = $1 or CAST(d.data ->> 'Number' as integer) = $2 or d.mt_deleted = False)
Single expression is fine:
var query = session.Query<SoftDeletedItem>().Where(x => x.Number == 1);
=>
select d.data, d.id, d.mt_version from public.mt_doc_softdeleteditem as d where (CAST(d.data ->> 'Number' as integer) = $1 and d.mt_deleted = False)
Failing test:
https://github.com/barryhagan/marten/commit/dd95f38bc9c47b326310b4f47ac2c3a4c281501c

This is also an issue for multi-tenancy.
https://github.com/barryhagan/marten/commit/0087b32f67f0bd57098f5f32890a144b6214f991

Addressed by https://github.com/JasperFx/marten/pull/860


Ordinals-DOggy-Dogs

Thanks fam, I'm glad to become a part of this huge space! <3

I need some help!


improvementsupport estimate row count

Proposed changes
Get the number of rows evaluated  for iceberg and paimon.

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


[Task] Code evaluation for MariaDB Plugin changes

I have went through the code and implementation for MariaDB plugin from my side and will be working on the next phase of the task.