FIX #3 exported the json file and text data

I have made export buttons on both JSON and Text, made separate functions for each format export but right now text data is not all fetched it is only downloading the first few lines.
Any suggestions would be appreciated! :)

Hey @piyushjha0409, thank you for the PR!
The JSON export looks good!
Thinking about the text export... right now it still generates some HTML tag, what do you think if we create a function that from the repositories array generates a text (newline can be /n or something like that) and then use the same function for both display and export. How does it sound to you?
If it doesn't go on a new line, you can use the class whitespace-pre-line on the parent div.
We can also have a chat on Discord if you want :)


Make the allowedUrls to also be function as an alternative to being an array of URL prefixes

Sometime we want make a dynamic decision on which URLs should be sent the access_token.
Make the allowedUrls to also be function. The function takes the URL to check and returns a boolean to indicate if the access_token should be sent in the header.
https://github.com/manfredsteyer/angular-oauth2-oidc/blob/b4c87312f51b22ddb763ec1a8095d2ea6de07851/projects/lib/src/interceptors/default-oauth.interceptor.ts#L26

if you want you can provide a PR that introduces this without breaking changes.
An alternative would be to write a custom HttpInsterceptor instead of using this build-in feature.


Image picker for web

image_picker_for_web-0.1.0+1/lib/image_picker_for_web.dart:2:8: Error: Not found: 'dart:html'
import 'dart:html' as html;
I created app in which I have used Image picker for web it works well for me in web version but as soon as I run it to android it gives me above error.
Is there any way to solve this, means same code runs on both platform Android + Web: pick image?

Yes, Android and iOS  temporary use https://pub.dev/packages/image_picker

Hi @bhavikvashi1804
Create a new project and add following
  image_picker: ^0.6.7+4
  image_picker_for_web: ^0.1.0+1

Code Sample
import 'dart:io';

import 'package:flutter/material.dart';
import 'package:image_picker/image_picker.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  File _image;
  final picker = ImagePicker();

  Future getImage() async {
    final pickedFile = await picker.getImage(source: ImageSource.gallery);

    setState(() {
      _image = File(pickedFile.path);
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Image Picker Example'),
      ),
      body: Center(
        child: _image == null ? Text('No image selected.') : Image.file(_image),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: getImage,
        tooltip: 'Pick Image',
        child: Icon(Icons.add_a_photo),
      ),
    );
  }
}

This works on mobile and web
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

Hi @bhavikvashi1804
Create a new project and add following
  image_picker: ^0.6.7+4
  image_picker_for_web: ^0.1.0+1

Code Sample
import 'dart:io';

import 'package:flutter/material.dart';
import 'package:image_picker/image_picker.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  File _image;
  final picker = ImagePicker();

  Future getImage() async {
    final pickedFile = await picker.getImage(source: ImageSource.gallery);

    setState(() {
      _image = File(pickedFile.path);
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Image Picker Example'),
      ),
      body: Center(
        child: _image == null ? Text('No image selected.') : Image.file(_image),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: getImage,
        tooltip: 'Pick Image',
        child: Icon(Icons.add_a_photo),
      ),
    );
  }
}

This works on mobile and web
Closing, as this isn't an issue with Flutter itself. If you disagree, please write in the comments and I will reopen it.
Thank you

This will allow to pick the image file in both web and mobile but there is one issue still, after picking image in web it does not support to open image via following code.
Container(
child: Center(
child: _pickedImage == null
? Text('No image selected.')
: Image.file(_pickedImage),
),
),
here _pickedImage is file type varible.

Error Log
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/internal/js_dev_runtime/private/ddc_runtime/errors.dart 214:49  throw
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/_internal/js_dev_runtime/patch/io_patch.dart 205:5               get _namespacePointer
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/io/file_impl.dart 220:48                                         _namespacePointer
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/io/file_impl.dart 223:15                                         _dispatchWithNamespace
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/io/file_impl.dart 354:60                                         open
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/io/file_impl.dart 527:19                                         readAsBytes
packages/flutter/src/painting/image_provider.dart 878:40                                                                   _loadAsync

CircleAvatar(
radius: 40,
backgroundImage: kIsWeb
? _imagePath.length == 0 ? null : NetworkImage(_imagePath)
: _image == null ? null : FileImage(_image),
),

CircleAvatar(
radius: 40,
backgroundImage: kIsWeb
? _imagePath.length == 0 ? null : NetworkImage(_imagePath)
: _image == null ? null : FileImage(_image),
),

this works for me to display image on web and android

Hi @bhavikvashi1804
This is not related to this issue as mentioned earlier https://github.com/flutter/flutter/issues/63314#issue-675634445
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/internal/js_dev_runtime/private/ddc_runtime/errors.dart 214:49 throw
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/_internal/js_dev_runtime/patch/io_patch.dart 205:5 get _namespacePointer
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/io/file_impl.dart 220:48 _namespacePointer
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/io/file_impl.dart 223:15 _dispatchWithNamespace
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/io/file_impl.dart 354:60 open
C:/b/s/w/ir/cache/builder/src/out/host_debug/dart-sdk/lib/io/file_impl.dart 527:19 readAsBytes
packages/flutter/src/painting/image_provider.dart 878:40 _loadAsync

if you think is a bug, please a file new and provide all the details with complete sample


UI 3 colns

Coverage decreased (-0.5%) to 90.489% when pulling 0f25753704228f7dd1e7c79288b4592e30e6c435 on HH into 1e783510afaf5e1f279744d23c2856a736c00714 on master.

Coverage increased (+0.06%) to 91.046% when pulling a498eeec9971a562c6eb5664dcbbc5fcc5a2e1da on HH into 1e783510afaf5e1f279744d23c2856a736c00714 on master.

Coverage decreased (-0.6%) to 90.366% when pulling a498eeec9971a562c6eb5664dcbbc5fcc5a2e1da on HH into 1e783510afaf5e1f279744d23c2856a736c00714 on master.


Client certificate auth added in brands

Copy client cert and config to assets/Resources
I have extended the elements.json certificate copying provisions to also copy the clientauth.json and clientcert/p12 needed for client certificate authentication. It has also had the location for these files moved to the brand's ./certificates folder.
I have also cleaned up a missing space in the "learn more" linking the index.html as well as a large joshing-fuelled touch up for BrandPackage.js

This pull request is now managed with CodeReviewHub. Refresh.

I've made a small change to customize.js to tolerate absence of action source dirs. This is necessary, eg, for the new configuration with brands that lack a 'certificates' subdir.


[db] Fix bug in array slicing

Previously, retrieving parts of a dataset (e.g., plaintext, ciphertext, ...) did not work as there was a bug in the array slicing logic.
Basically, if start and end or end was not provided, "None" is the default value. However, the check in the if condition should be if (start is not None) and not if (start).
This PR fixes this issue.
Moreover, now it is also possible to select a single entry of a dataset, e.g., get_plaintexts(0) returns the plaintext at DB ID 0.

Thanks for your review, @vogelpi!


Add summary property in ApiResponse

Hi team,
I have added the summary property in ApiResponse class.
Detailed issue description: https://github.com/OAI/OpenAPI-Specification/issues/1591
I request you to do the code review and inform me if any changes are required.
Thanks,
Mohammed Rizwan

Link to issue above is broken, good one should be this one. However that points to an open discussion about spec enhancements which is not part of any released spec, it's therefore too early to address it in implementations, and I will close this PR for the time being

Hi @frantuma,
Thanks for the clarification.
Thanks,
Mohammed


Access-Control-Allow-Headers is null

/*
|--------------------------------------------------------------------------
| Laravel CORS
|--------------------------------------------------------------------------
|
| allowedOrigins, allowedHeaders and allowedMethods can be set to array('*')
| to accept any value.
|
*/

'supportsCredentials' => false,
'allowedOrigins' => ['*'],
'allowedOriginsPatterns' => ['*'],
'allowedHeaders' => ['*'],
'allowedMethods' => ['*'],
'exposedHeaders' => [],
'maxAge' => 0,

And I'm getting Access-Control-Allow-Origin:  instead of Access-Control-Allow-Origin: * in my response header. Am I doing something wrong?

I'm closing this due to inactivity. If this issue is still relevant on the latest version (2.0.1 at the moment), please open a new issue with detailed information.


Implement invitations for special registration types

Create a system for a secure way to register special types of registrants that correspond to different kinds of staff that pay different amounts. You get a special link you get a special form.
Expands on #23 https://github.com/camphoric/camphoric/issues/23#issuecomment-636268357

Thoughts about invitations:

invitations have email address of recipient
id of sender
sending timestamp
invitation (unique) code
timestamp when redeemed
id of redeeming registration
registration type (kitchen/management/etc.) part of the model
default vs invitation code
needs way to be cancelled (soft delete)

Error message: One generic error message on any type of invalid invitation code

Proposal
Overview of user experience:
The administrator creates an invitation by entering an email address, choosing a type of registration and sending it. The prospective registrant receives the email, which includes a link to registration form with an invitation code. This code is unique and can only be redeemed once. it is not time limited but can be cancelled by the administrator. The prospective registrant clicks the link and is directed to a form that reflects their registration type and any pricing differences from the default registration.
Implementation:

[ ] Create RegistrationType model

event
name
label
invitation_email_template

[ ] Add RegistrationType field to Registration model

[ ] Include RegistrationType into input for price calculations

[ ] Create Invitation model

will inherit from Timestamp model
registration (initinally null, populated when invitation is redeemed)
registration_type

Also need to update client-side pricing calculations to include registration_type

Also need to update client-side pricing calculations to include registration_type

Also, update the registration form:

show the invitation (or invitationError)
include the invitation in the POST data

Also, update the registration form:

show the invitation (or invitationError)
include the invitation in the POST data

I think the API and registration form changes are done.
Admin interface
To tie everything together, the admin app need page to manage RegistrationTypes and Invitations, as well as send invitations. Proposal for this page:

list of existing invitations (GET /api/invitations/)
"send" button for each invitation which will email the invitation (POST /api/invitations/{invitation.id}/send)
"edit" button for each invitation which would show an edit form (PUT /api/invitations/{invitation.id}/)
maybe a "delete" button (DELETE /api/invitations/{invitation.id}/)
form to create a new invitation (POST /api/invitations/)

The create/edit form should make these fields editable (others are set automatically):

recipient_name
recipient_email
expiration_time
registration_type

registration_type should allow adding/editing RegistrationTypes via /api/registrationtypes/* -- GET to list, POST to create, PUT to edit, DELETE to delete
fields for RegistrationType
fields for Invitation


HOSTEDCP-1851: Use a multi-arch haproxy image for shared ingress

What this PR does / why we need it:
Use a multi-arch haproxy image for shared ingress
Which issue(s) this PR fixes:
Fixes HOSTEDCP-1851
Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

/retest-required

please also update
https://github.com/openshift/hypershift/blob/ad54764956732525a14a60f811dab6e5a64ccb06/hypershift-operator/controllers/sharedingress/router.go#L195

please also update
https://github.com/openshift/hypershift/blob/ad54764956732525a14a60f811dab6e5a64ccb06/hypershift-operator/controllers/sharedingress/router.go#L195

Ah thanks! I did not realize it was used in more than one spot.

/lgtm

/retest

/retest

/retest-required


Features/the merge

Merge razor-compiler into razor-tooling.

This is essentially just code flow, and we had sign offs from the compiler side on the original PR, so going to hit the button.

The system works!


[discuss] What is process.owner in POSIX?

The process.owner attribute is defined as "The username of the user that owns the process". What does that mean for POSIX systems?
In Windows, a process's owner is well-defined, but POSIX doesn't have a well-defined process "owner". To me, with POSIX, the owner could be one of: the user that owns the file being executed, effective user ID, real user ID, or (maybe) saved user ID.
I think it should be decided what process.owner means with POSIX systems, and add a note to the attribute to better define it.
I think it could either specify that process.owner should only be used on Windows, and use other attributes with POSIX (other process user ID attributes will be added with  #564), or define which value should be used with POSIX.

In your note for the process PR you mentioned

This is intended to be used with Windows only. On POSIX systems, processes can have multiple users (effective, real and saved). To avoid confusion about which user is being referenced, this field should not be used with POSIX systems.

I think the problem here is that this field will be empty. Does it make sense and is there a way to copy to the owner one of the users (effective, real or saved) for POSIX systems?

I think the problem here is that this field will be empty. Does it make sense and is there a way to copy to the owner one of the users (effective, real or saved) for POSIX systems?

Could this be set as recommended or opt_in requirement level, and leave it empty on posix systems? (I'm not sure of the difference between these)
When I see "owner" in Linux, I think of file ownership, and when I first looked at this attribute, I thought it was referring to "the owner of the file being executed".  But the ECS file.owner attribute will be better for this, when it's added to otel. And fileless process executions are possible with memfd, so this might not be present at all.
"Effective user ID's username" is probably the closest to the Windows process owner. But that will already be the process.user.name attribute, and I don't see why it would need to be duplicated.
People who are not too familiar with Windows might think of these before they think of the Windows definition, so that's why I thought it would be a good idea to add a note that the attribute is Windows-only and avoid possible confusion about the usage. If it can't be Windows-only, I think we should define which of these definitions should be used on posix


HDFS-16425. Add debug log when requeue observer read call

Description of PR
Add debug log when requeue observer read call
How was this patch tested?
no need to test.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 46s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 35s

trunk passed

+1 :green_heart:
compile
24m  6s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
20m  0s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 45s

trunk passed

+1 :green_heart:
javadoc
1m 19s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 47s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 39s

trunk passed

+1 :green_heart:
shadedclient
23m  7s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  1s

the patch passed

+1 :green_heart:
compile
24m 54s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
24m 54s

the patch passed

+1 :green_heart:
compile
22m  5s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
22m  5s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  5s
/results-checkstyle-hadoop-common-project_hadoop-common.txt
hadoop-common-project/hadoop-common: The patch generated 2 new + 166 unchanged - 0 fixed = 168 total (was 166)

+1 :green_heart:
mvnsite
1m 39s

the patch passed

+1 :green_heart:
javadoc
1m  7s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 46s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m  3s

the patch passed

+1 :green_heart:
shadedclient
25m 38s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
18m  4s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 55s

The patch does not generate ASF License warnings.

210m 45s

Reason
Tests

Failed junit tests
hadoop.ipc.TestIPC

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3886/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3886

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 004e433e1606 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 858131dbc1449c6afd48998732de6faf3842ed2a

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3886/1/testReport/

Max. process+thread count
3158 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3886/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
34m 26s

trunk passed

+1 :green_heart:
compile
25m  2s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
20m 36s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m  5s

trunk passed

+1 :green_heart:
mvnsite
1m 38s

trunk passed

+1 :green_heart:
javadoc
1m 11s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 41s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 32s

trunk passed

+1 :green_heart:
shadedclient
23m 16s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  4s

the patch passed

+1 :green_heart:
compile
24m 23s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
24m 23s

the patch passed

+1 :green_heart:
compile
20m 36s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m 36s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
1m  3s

the patch passed

+1 :green_heart:
mvnsite
1m 38s

the patch passed

+1 :green_heart:
javadoc
1m  7s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 40s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 41s

the patch passed

+1 :green_heart:
shadedclient
23m 30s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
17m 28s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 59s

The patch does not generate ASF License warnings.

208m 28s

Reason
Tests

Failed junit tests
hadoop.ipc.TestIPC

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3886/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3886

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux e6a55cdb4e7e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / cde094cc94366f9681247cd3e1c3a3d7ca2db1cc

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3886/2/testReport/

Max. process+thread count
2565 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3886/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 32s

trunk passed

+1 :green_heart:
compile
22m 18s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
19m 30s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 10s

trunk passed

+1 :green_heart:
mvnsite
1m 42s

trunk passed

+1 :green_heart:
javadoc
1m 14s

trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 43s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 31s

trunk passed

+1 :green_heart:
shadedclient
22m 14s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  0s

the patch passed

+1 :green_heart:
compile
21m 32s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
21m 32s

the patch passed

+1 :green_heart:
compile
19m 19s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
19m 19s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
checkstyle
1m  6s

the patch passed

+1 :green_heart:
mvnsite
1m 38s

the patch passed

+1 :green_heart:
javadoc
1m 11s

the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 44s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 41s

the patch passed

+1 :green_heart:
shadedclient
22m 16s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
17m 47s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 50s

The patch does not generate ASF License warnings.

197m  2s

Reason
Tests

Failed junit tests
hadoop.ipc.TestIPC

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3886/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3886

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux c92b50826951 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8476b8c26cf11ba67e2287f603650b34c68a7bfc

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3886/3/testReport/

Max. process+thread count
3158 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3886/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Jenkins seems not happy: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3886/3/artifact/out/blanks-eol.txt

@ayushtkn , Hi ,  i feel so sorry for replying so late. I have fixed the style problems.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

-1 :x:
mvninstall
18m 51s
/branch-mvninstall-root.txt
root in trunk failed.

-1 :x:
compile
4m  6s
/branch-compile-root-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.txt
root in trunk failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.

-1 :x:
compile
3m 26s
/branch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root in trunk failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
checkstyle
1m  9s

trunk passed

+1 :green_heart:
mvnsite
1m 40s

trunk passed

-1 :x:
javadoc
1m 11s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.txt
hadoop-common in trunk failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.

+1 :green_heart:
javadoc
1m 32s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 30s

trunk passed

-1 :x:
shadedclient
9m 44s

branch has errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  7s

the patch passed

-1 :x:
compile
3m 37s
/patch-compile-root-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.txt
root in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.

-1 :x:
javac
3m 37s
/patch-compile-root-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.txt
root in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.

-1 :x:
compile
3m 10s
/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

-1 :x:
javac
3m 10s
/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt
root in the patch failed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
0m 57s

the patch passed

+1 :green_heart:
mvnsite
1m 24s

the patch passed

-1 :x:
javadoc
0m 59s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.txt
hadoop-common in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
2m 27s

the patch passed

-1 :x:
shadedclient
9m 37s

patch has errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
17m 51s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

87m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3886/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3886

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux b214f0a448f6 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 112f12eb56ad54449c07b446c067d481686d2813

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3886/4/testReport/

Max. process+thread count
3032 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3886/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
38m 37s

trunk passed

+1 :green_heart:
compile
23m 10s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
20m 37s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 47s

trunk passed

+1 :green_heart:
mvnsite
2m 12s

trunk passed

-1 :x:
javadoc
1m 51s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.txt
hadoop-common in trunk failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.

+1 :green_heart:
javadoc
2m 16s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 13s

trunk passed

+1 :green_heart:
shadedclient
23m 43s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m  6s

the patch passed

+1 :green_heart:
compile
22m 32s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
22m 32s

the patch passed

+1 :green_heart:
compile
20m 53s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
20m 53s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m 39s

the patch passed

+1 :green_heart:
mvnsite
2m  9s

the patch passed

-1 :x:
javadoc
1m 43s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.txt
hadoop-common in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04.

+1 :green_heart:
javadoc
2m  4s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m  9s

the patch passed

+1 :green_heart:
shadedclient
23m 33s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 31s

hadoop-common in the patch passed.

+1 :green_heart:
asflicense
1m 35s

The patch does not generate ASF License warnings.

218m 16s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3886/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3886

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 813bbba471b3 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d9ed717d9814105d889d989b18af6ced68871f2c

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3886/5/testReport/

Max. process+thread count
3158 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3886/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@ayushtkn Hi~ Ayush. Could you please help to review the code, thanks a lot.

I think logging call backfired here in HADOOP-18082.  There is a mail thread as well, telling not to log call.

Hi, Ayush. Very thanks for your opinions. I will learn the context in HADOOP-18082 and HADOOP-18143


CloudFormation dependency issue for Internet gateways can cause 'kube-aws up' to fail

CloudFormation cannot implicitly work out that an IGW needs to be attached to a VPC before you can add a route to the IGW. If you are unlucky things happen in the wrong order and the stack creation fails.
You can see in this example below using kube-aws 0.9.9, CF attempts to add the route to the IGW to the RTB and fails, right before it actually attaches the IGW to the VPC.
+00:00:39	Controlplane	CREATE_COMPLETE         		SecurityGroupElbAPIServer
+00:00:39	Controlplane	CREATE_IN_PROGRESS      		MyClusterPublic2cRouteToInternet
+00:00:40	Controlplane	CREATE_COMPLETE         		MyClusterPublic2bRouteTable
+00:00:40	Controlplane	CREATE_FAILED           		MyClusterPublic2cRouteToInternet	"route table rtb-5bad0e33 and network gateway igw-160d2c7f belong to different networks"
+00:00:40	Controlplane	CREATE_IN_PROGRESS      		VPCGatewayAttachment  	"Resource creation Initiated"
+00:00:41	Controlplane	CREATE_IN_PROGRESS      		SecurityGroupWorkerIngressFromWorkerToWorkerKubeletReadOnly

According to some forum discussion, this behavior is expected, and the fix is an explicit DependsOn:

The problem is that Amazon only makes attaching internet gateway routes depend on the internet gateway, and not the internet gateway attachment.
The issue is solved by adding "DependsOn": "your-internet-gateway-attachment" to every route adding that uses the internet gateway.

AWS said (in 2012, but I guess this hasn't changed):

"We will document it - CloudFormation doesn't have knowledge of dependencies that are enforced by the services below it today."

Hi @whereisaaron! Good catch.
Just my two cents but probably the significant context in kube-aws here is that it doesn't try to modify existing AWS resources including a route table.
So, can we just add "DependsOn": "theInternetGateway" to the route-table created by kube-aws, rather than adding it to each route?
An existing route-table not created by kube-aws should have already been configured properly by the user including (the route to IGW|its attachment to the VPC) and therefore there would be no need to add the DependsOn to every route.

@mumoshu I think they mean every route that is created by the CloudFormation stack to the IGW. In the case of a preexisting route table, there would be no route created (to be dependent on anything). The ManageRouteToInternet test should cover both situations.
You know the template and CF better than I, but from they description I don't think "DependsOn": "theInternetGateway" would work, because the dependency is considered met as soon as theInternetGateway is created, even though it is not attached to the yet (and so you can't add the route yet).
My guess is what you need is something like in *InternetGatewayRouteLogicalName to add "DependsOn": "VPCGatewayAttachment" ?
    {{if $subnet.ManageRouteToInternet}}
    ,
    "{{$subnet.InternetGatewayRouteLogicalName}}": {
      "Properties": {
        "DestinationCidrBlock": "<IP_ADDRESS>/0",
        "GatewayId": {{$.InternetGatewayRef}},
        "RouteTableId": {{$subnet.RouteTableRef}}
      },
      "Type": "AWS::EC2::Route",
      "DependsOn": [ "VPCGatewayAttachment" ]
    }
    {{end}}

My guess is what you need is something like in *InternetGatewayRouteLogicalName to add "DependsOn": "VPCGatewayAttachment" ?

Thx for the suggestion!
It is really confusing but VPCGatewayAttachment is created only when the VPC is created by kube-aws as of today. Assuming we needed the modification, the CFN template snippet should look like:
    {{if $subnet.ManageRouteToInternet}}
    ,
    "{{$subnet.InternetGatewayRouteLogicalName}}": {
      "Properties": {
        "DestinationCidrBlock": "<IP_ADDRESS>/0",
        "GatewayId": {{$.InternetGatewayRef}},
        "RouteTableId": {{$subnet.RouteTableRef}}
      },
      "Type": "AWS::EC2::Route",
      {{if .VPCManaged}}
      "DependsOn": [ {{$.VPCGatewayAttachment}} ]
      {{end}}
    }
    {{end}}

However, if the VPC isn't managed by kube-aws i.e. it is provided by the user, the user must have already attached an IGW to the VPC. So, my guess is that there should be no need to add the DependsOn here.
Would this explanation sounds reasonable?
// Btw, perhaps it's true that I may know the CFN part of kube-aws more than someone but it doesn't really mean I can remember every part of it to decide things correctly because the world isn't really intuitive 😄 I always appreciate your support like this!

Thanks @mumoshu, not sure you need that VPCManaged test?
I think that the only time you don't want the DependsOn is if the route table is a supplied one, and not one created by kube-aws?
Going by the template cluster.yaml comments, I interpreted it as saying:

If you supply your own route table then the Internet gateway and route table entry for it is your responsibility
If you just supply e.g. an empty VPC (you specify only vpc.id), kube-aws will create the subnets, IGW, and route tables for you

The manual is also not concrete on what specifying only vpc.id does. Does specifying a vpc.id in fact compell you to also specified a routeTableId (and/or routeTable.id for every defined subnet)? If so, maybe the cluster.yaml comments and manual should highlight that?
If specifying vpc.id does compel you to provide your out route tables, then ManageRouteToInternet will be false, so the VPCManaged test is unnecessary. If specifying just vpc.id still leaves kube-aws to create the route table and IGW, then you still want the DependsOn, so the VPCManaged test is unwanted.
Also not sure I am not confused now 😄


Pack repeated groups even if there is only one group in the response

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Description
The current logic to pack repeated groups does not actually look at the questionnaire item at all. It simply packs multiple groups of the same id and assume they are from the same repeated group. This is fine unless if there is only one repeated group answer, the logic won't be able to distinguish this from non-repeated group.
The fix adds the questionnaire item to the logic so it packs if and only if it's a repeated group.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Bug fix
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct.
[x] I have read the Contributing page.
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
[x] I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

thanks for the review aditya - addressed comments


mac-24 & mac-2 lost external connection phone device.

Type of Request
bug
Infrastructure Environment
LUCI, Github, Cocoon scheduler, Autosubmit, etc...
What is happening?
mac-24 & mac-2 lost external connection phone device.

Steps to reproduce
Step 1:
Step 2:
..
Step n:
Expected results
I expect to see X when Y is finished.

Rebooting both machines to restore both connections.


Update image in the readme file #26

Addresses #26
I have removed the old Threadify.png (which had an old logo and older features) and have added a Newly taken screenshot of the site in light mode and uploaded the same as Threadify.png so it would replace the existing preview on the README.md.

Also, I have added a Newly taken screenshot of the site in dark mode too and uploaded the same as Threadify2.png so it can be used in the future if needed along with the Newly taken screenshot of the site in light mode as they were taken at the same time.

@pushkaraj2007 Thanks for letting me contribute. Pls do add the respective labels and close this issue 🙏🏼


laz-perf (included in qgis 3.22) fails to build on NetBSD

On NetBSD 9, I got complains of redefinitions of many macros like le32toh and finally an undefined variable.
Reading portable_endian.h I see that NetBSD is treated like Dragonfly and there is renaming, while on FreeBSD and OpenBSD sys/endian.h is simply included.   Only NetBSD 8 and later matter, but NetBSD got sys/endian.h in 1999, and it doesn't seem to have definitions for the target symbols in the Dragonfly case.
I'm guessing this was just an incorrect guess that NetBSD was like DragonFly, when really it seems all are similar except for DragonFly.  I'm happy to submit a PR; the following diff (which github web UI refuses to attach) caused the qgis build to make vastly more progress (still running):
--- portable_endian.hpp.orig    2022-01-14 07:06:34.000000000 -0500
+++ portable_endian.hpp 2022-02-02 20:11:56.651221385 -0500
@@ -43,11 +43,11 @@
 #   define __PDP_ENDIAN    PDP_ENDIAN
 **/

-#elif defined(__OpenBSD__)|| defined(__FreeBSD__)
+#elif defined(__OpenBSD__)|| defined(__FreeBSD__) || defined(__NetBSD__)

 #   include <sys/endian.h>

-#elif defined(__NetBSD__) || defined(__DragonFly__)
+#elif defined(__DragonFly__)

 #   define be16toh betoh16
 #   define le16toh letoh16

I'm happy to submit a PR if you are inclined to take it.

Yes we would be happy to merge something. There will be a new release soon to address the Apache Public License relicencing.
This code will also be vendored in PDAL as well. I don't know if PDAL is your ultimate user of this or not.

OK, pull request soon.   I am here because the vendored code in qgis failed to build.
I am surprised about how DragonFly is handled, because sys/endian.h in
the BSD world seems like it predates the FreeBSD/DragonFly split, but
I don't use DragonFly.  I don't want to entangle the NetBSD fix with that issue, though.

This code is also vendored in PDAL https://github.com/PDAL/PDAL/blob/e416c45c1d0d08d0610cbc707237e97d0f7741f9/pdal/util/portable_endian.hpp so fixes or changes here will need to be pushed up there too.

I hope there is some semi-automated update process, to mitigate the maintenance problems inherent in vendoring.  Is that meant as note-to-self, or are you suggesting I open a PDAL and qgis bug report that (once #116 merged) the vendored code is not up to date?

Mostly as a note to self.
Although, as I mentioned, we are going to be vendoring laz-perf into PDAL. This was described in a mail to the PDAL list https://lists.osgeo.org/pipermail/pdal/2021-October/002483.html With LASzip and laz-perf now being relicensed as APL #114, we can vendor it and make LAZ support a much easier and simple thing for PDAL's users.


[Translation] Release MicroProfile 6.0 - Release Blog Post Swedish Translation

Once third task in https://github.com/eclipse/microprofile-marketing/issues/726 about: Draft a release announcement blog post using template (technical person) is complete, add release blog post in Swedish

https://drive.google.com/drive/folders/1bPNVnkyXp8tu6Y-Q67o48BM4GPk5z6JL

Hola @LuisGalazM,
Thank you for choosing to become a contributor on Release transactions, you are amazing!
@emecas leads the effort, so you are now in great hands.  :)
Please check your inbox. You are now formally a MP Wordpress contributor.

Presentation:
https://docs.google.com/presentation/d/1lziLHhuvxj_6tGybZnN7KIWskbM1VQPe/edit
Blog post:
https://docs.google.com/document/d/1-bpHuQC3aNqQNKwSOqhTXWhPIeGfJPtBnYaMp8HFkIQ/edit

Twitter:
`#MicroProfileReleaseAnnouncement: #Microprofile version 6.0 släppt!
Den stöder @JakartaEE 10 Core Profile. 📢 🚀
Att lära sig mer:
#ByCommunityForCommunity #OpenSource#MicroProfileReleaseAnnouncement: #Microprofile version 6.0 släppt!
Den stöder @JakartaEE 10 kärnprofiler. 📢 🚀
För mer information gå in på:
#ByCommunityForCommunity #OpenSource
`

Picture:
MicroProfile version 6.0 har släppts!

@emecas @aeiras  el draft listo para un review

Hola Luis,
I will review it by the end of my day tomorrow before shifting the last steps to @rstjames  :)
You truly are awesome!

Fixing broken links:

Presentation: https://docs.google.com/presentation/d/1lziLHhuvxj_6tGybZnN7KIWskbM1VQPe/edit

https://docs.google.com/presentation/d/1lziLHhuvxj_6tGybZnN7KIWskbM1VQPe/edit

Blog post: https://docs.google.com/document/d/1-bpHuQC3aNqQNKwSOqhTXWhPIeGfJPtBnYaMp8HFkIQ/edit

https://docs.google.com/document/d/1-bpHuQC3aNqQNKwSOqhTXWhPIeGfJPtBnYaMp8HFkIQ/edit
Draft Post:
https://microprofile.io/2023/05/06/microprofile-6-0…-10-core-profile/

nice work, Emerson.
You are most welcomed to pull me in for final review. :) No rush while working with Luis on the review.
Even better, I will just join to add Ryan to the last step and let all the work be lead by amazing you, Emerson! 🥇

thanks @LuisGalazM  @aeiras -  I  just added some suggestions in the presentation document and blog post document

@emecas ,  I fixed the picture and the suggestions

@emecas , I fixed the picture and the suggestions

@LuisGalazM  just one last thing , one of the titles in the picture (Uppdaterade) has a red underline:

@emecas. ahi lo arregle

LGTM
Thanks @LuisGalazM
@aeiras  it is your turn  now :)

The two of you are truly formidable. :)
@rstjames can you please help close this ticket?  Pull @LuisGalazM & @emecas if there are issues with publication over media and the such.
@emecas you can publish the blog as the next step. Only then, Ryan can take over :)

@emecas you can publish the blog as the next step. Only then, Ryan can take over :)

DONE @aeiras  , it is now published https://microprofile.io/2023/05/11/microprofile-6-0-lanserades-och-anvander-sig-av-jakarta-ee-10-core-profile/ , thanks for you contributions @LuisGalazM
BTW I am following the effort here as well

@aeiras @LuisGalazM
we need this tweet in Swedish and the text in Swedish for the image
#MicroProfileReleaseAnnouncement: #Microprofile 6.0 is released! It adopts
@JakartaEE 10 Core Profile. Learn more http://ow.ly/u6As50MmsZR #ByCommunityForCommunity #OpenSource

@rstjames
Twitter:
#MicroProfileReleaseAnnouncement: #Microprofile version 6.0 har släppts!
Den stöder https://github.com/jakartaee 10 Core Profile. 📢 🚀
För mer information gå in på:
#ByCommunityForCommunity #OpenSource

@rstjames
Picture (This is the word order in Swedish):
Microprofile 6.0
tillgänglig nu

scheduled to go out :) @LuisGalazM


add to emulate a TCP connection(linux)?

there are vps where the speed of the udp protocol is cut, that's why even wireguard is getting slow, a solution in the form of udp2raw is not always convenient.

If the feature only benefits Linux, then this feature will not be implemented.
Because I use kcptube too, and I'm using it on Windows and FreeBSD. TCP simulation mode can also be done on Windows and FreeBSD, but simulating TCP requires privilege mode, no matter Linux, FreeBSD or Windows. In Windows, it will cause a UAC pop-up window to appear every time it is used, which will be even more inconvenient.
On the other hand, if the UDP speed is limited, it may be due to the limitation of the VPS provider, the limitation of your home broadband service provider, or the insufficient international outgoing bandwidth of your country (if the location of your VPS is not in your country).
Chinese ISPs have different throttling modes for UDP, among which the most common is ‘port number throttling’ — the initial burst traffic can be very high, and it will be throttled after a while. The ‘port hopping’ function of KCPTube and UDPHop is designed for this throttling.
I'm not sure whether other countries' broadband service providers also throttle UDP like China does.

If the feature only benefits Linux, then this feature will not be implemented.
Because I use kcptube too, and I'm using it on Windows and FreeBSD. TCP simulation mode can also be done on Windows and FreeBSD, but simulating TCP requires privilege mode, no matter Linux, FreeBSD or Windows. In Windows, it will cause a UAC pop-up window to appear every time it is used, which will be even more inconvenient.
On the other hand, if the UDP speed is limited, it may be due to the limitation of the VPS provider, the limitation of your home broadband service provider, or the insufficient international outgoing bandwidth of your country (if the location of your VPS is not in your country).
Chinese ISPs have different throttling modes for UDP, among which the most common is ‘port number throttling’ — the initial burst traffic can be very high, and it will be throttled after a while. The ‘port hopping’ function of KCPTube and UDPHop is designed for this throttling.
I'm not sure whether other countries' broadband service providers also throttle UDP like China does.

udp is not cut depending on the port used, the hosting itself does so, so even if you randomize the ports, then the speed is still lower.
so what's hard to add tcp emulation like udp2raw does?

If the feature only benefits Linux, then this feature will not be implemented.
Because I use kcptube too, and I'm using it on Windows and FreeBSD. TCP simulation mode can also be done on Windows and FreeBSD, but simulating TCP requires privilege mode, no matter Linux, FreeBSD or Windows. In Windows, it will cause a UAC pop-up window to appear every time it is used, which will be even more inconvenient.
On the other hand, if the UDP speed is limited, it may be due to the limitation of the VPS provider, the limitation of your home broadband service provider, or the insufficient international outgoing bandwidth of your country (if the location of your VPS is not in your country).
Chinese ISPs have different throttling modes for UDP, among which the most common is ‘port number throttling’ — the initial burst traffic can be very high, and it will be throttled after a while. The ‘port hopping’ function of KCPTube and UDPHop is designed for this throttling.
I'm not sure whether other countries' broadband service providers also throttle UDP like China does.

udp is not cut depending on the port used, the hosting itself does so, so even if you randomize the ports, then the speed is still lower. so what's hard to add tcp emulation like udp2raw does?

‘the hosting itself does it’?
UDP speed is limited by VPS Hosting Provider? Ah, that's new to me.
May I know:

Which VPS Hosting Provider are you using?
Which speed test tool are you using?
Have you tried using iperf to test the speed directly without going through wireguard?

Tip: When using iperf to test UDP speed, please use the -b option to test multiple times with multiple bandwidth values, such as 10M, 100M, and 1G, to check the actual UDP bandwidth and packet loss rate.

‘the hosting itself does it’? UDP speed is limited by VPS Hosting Provider? Ah, that's new to me.
May I know:

Which VPS Hosting Provider are you using?
Which speed test tool are you using?
Have you tried using iperf to test the speed directly without going through wireguard?

Tip: When using iperf to test UDP speed, please use the -b option to test multiple times with multiple bandwidth values, such as 10M, 100M, and 1G, to check the actual UDP bandwidth and packet loss rate.

VPS: which uses protection against DDOS attacks using "rs-media".
https://www.speedtest.net/
No, I have not mastered iperf because there is no instruction that will tell step by step how to test wireguard using iperf.
How do I know that the udp protocol falls under speed reduction due to some triggers, I found out because I later launched openvpn on tcp and tested it and it works in speedtest without lowering speeds, the problem is only in those tunnels where transport is carried out using the udp protocol.

The speed (traffic) of TCP is higher than UDP, this is a common situation in China. We describe it as ‘ISP's QoS, TCP has higher priority than UDP’.
As previously mentioned, UDP speed can be restricted on various locations, including restrictions imposed by your local ISP or limited by the international outbound bandwidth in your region or your local ISP.
This is the reason you need to use iperf to test your network bandwidth (particularly UDP) first.
No need to do iperf speed tests inside the WireGuard tunnel yet. Just run iperf in server mode on your VPS, and run iperf in client mode on your home computer or router. And then, as I mentioned before, test the UDP speed by using -b option to test different bandwidth values and see what the resulting packet loss and speed rates are.
server side:
iperf -s -u
client side,  test download speed of UDP:
iperf -c your_vps_ip_address -u -b 10M -R -t 30
iperf -c your_vps_ip_address -u -b 100M -R -t 30
iperf -c your_vps_ip_address -u -b 1000M -R -t 30

or using iperf3
server side:
iperf3 -s
client side:
iperf3 -c your_vps_ip_address -u -b 10M -R -t 30
iperf3 -c your_vps_ip_address -u -b 100M -R -t 30
iperf3 -c your_vps_ip_address -u -b 1000M -R -t 30

The screenshot clearly shows that the actual usable bandwidth for UDP connections reaches 104 Mbps, higher than the 11.62 Mbps reported by the speedtest command. This suggests that the ‘speed limitation’ is not in ‘UDP throttling’ but more likely a configuration error.
Based on the configuration file from another Issue, it appears that the inbound_bandwidth value you set for client mode is significantly higher than 104 Mbps, which can actually reduce the transfering speed (as mentioned in "issues/22"). Please try to setting the client mode inbound_bandwidth to 100M.


Bug UI when using scrollFullHeight in mobile Screen

When screen is small and I''m using scrollFullHeight in demo text-location I found that
Could anybody tell me  How to fix it ?
Thank so much

This has come up a few times and is being addressed here https://github.com/gregnb/mui-datatables/pull/1134. Feel free to watch that PR for updates on progress, but I'll be closing this one as it's a duplicate.


0 peers connected

The nav bar will show this state. We should be detecting this and proactively taking measures to reestablish a connection. Currently when the app is in this state the solution is to close the app and restart it in order to get it to connect.

The cause of the 0 peers connected seemed to be the way dcrwallet was handling a downed dns seeder host. We implemented tapping on the status bar to initiate a reconnect sequence. This is good enough for now, but more could possibly be done here.


Article display options

Have you considered additional display options in list of articles? I'd like to be able to customize what's displayed as well as control the sort in additional ways.  I'm thinking like a mail client with a list of emails

I second what @apstanley mentioned here. Options to disable the article favicon, publish time, and article source would be helpful in scanning large lists.


Question: map pages: direct files or fixed files

There are some man pages that use the terms fixed file table and fixed files or fixed file descriptors and others that seem to refer to the same things as direct file table, or direct files or direct file descriptors.
True there is an io_uring.h symbol with FIXED in its name, IOSQE_FIXED_FILE. Other symbols with FIXED in their name seem to refer only to fixed buffers though.
And there are many liburing functions the _direct suffix in their name that I think are operating on the same items.
Would it be okay if the man pages that refer to fixed files be changed to refer to direct files, the one symbol name notwithstanding?
At least io_uring_{enter, setup, register_file_alloc_range, and register} man pages refer to fixed file things when it seems they could be using the terms direct file for the table and the descriptors.
And is it correct that the terms direct file and direct file descriptor refer to the same thing? The index in the table kept by the uring for its registered files?
Then where there are man pages that refer to registered files, it could be pointed out these are called direct file descriptors in other man pages too.

I didn't look up how it evolved in man pages, but _direct helpers are for requests generating / creating new files directly into the io_uring's fixed file table instead of the conventional process file table. It was not name _fixed because I was afraid that it'll be too easily confused with requests accepting a fixed file, which is done via IOSQE_FIXED_FILE as you noticed, and with fixed_{read,write}, which are about registered buffers.

Now, browsing the driver source, I see the use of fixed_file_slot and fixed_fd.
I wonder if the man pages should converge on using the terms in the driver source, and just explain away the use of _direct in the function names - or even let the reader deduce it themselves. So maybe fixed table and fixed descriptor (fixed_fd) can be kept separate in the minds of the man page reader from registered buffer. (I don't find a term like fixed buffer in the driver source.)
Given the use in the kernel, when people talk about these entities down the road, it would be nice if they didn't have to differentiate between the kernel entity and the liburing entity. It's fine that the API function name is one thing, but the description of what's being managed can probably be cleaned up so it is as concise and uniform as the kernel source is itself.
At least that's how I'm leaning. Someone on your team can weigh in with a different direction and I'll be happy to do that instead.
So of course no changes to names of functions or symbols. Just man pages that try to be consistent with their terminology.

I think that sounds fine.

I will submit a draft PR that gets at this. But unless someone says it's urgent, what I've done isn't ready yet anyway and what with the timing of things, I don't expect the liburing man pages are the highest priority right now for anyone.

That sounds good, there's no immediate rush on this.


gdrive support

Fix #381

List of supported remotes is extended with Google Drive (gdrive).
Step by step guide to create and configure Google Project to access user's Google Drive.
Description of client id and client secret config options for gdrive remote.

@shcheklein @efiop updated, thanks!

@jorgeorpinel @MaxRis hey guys, besides the consistency in order point is there anything else that is blocking this from merging?

@shcheklein hopefully, no others blocking things

@jorgeorpinel have merged this, let's address the order consistency (a minor issue anyways) as a separate ticket.

Yeah thanks, I was a little out of pocket last week. I'll just address the small details myself in a quick PR. Soon


Non-working link for "user help FAQ" leads to 404 error

The link in the "Plan for operations" section for "FAQ is the user help" pointing to (https://support.microsoft.com/office/microsoft-teams-rooms-help-e667f40e-5aab-40c1-bd68-611fe0002ba2) leads to a non-existing page.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1c25c286-2a25-19d1-6847-f2324b3deb73
Version Independent ID: 0c82ef28-f9c8-1845-c167-ce2756478d9c
Content: Plan for Microsoft Teams Rooms - Microsoft Teams
Content Source: Teams/rooms/rooms-plan.md
Service: msteams
GitHub Login: @dstrome
Microsoft Alias: dstrome

Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

Hi @scanum, sorry but I can't follow on your recommendation. There is a non-working link to a user FAQ in one of our general Teams articles, and I asked to update/correct it.
I'm an FTE, so I'm not sure which tenant you exactly mean. How will opening a support ticket on a specific tenant going to help correcting a link for the general audience?

@rito2k The en-us version of the link is giving 404, probably removed, other languages of the same article exist.
I'll try to dig into this if a replacement resource will be provided.

If it helps, there is a copy here: https://web.archive.org/web/20220329173758/https://support.microsoft.com/en-us/topic/e667f40e-5aab-40c1-bd68-611fe0002ba2


List (and install) indirect dependencies?

D3 modules can have dependencies that may not exist at the top level, so d3-bundler should probably generate an appropriate error if it can’t find that dependency.
For example, say you import the d3-transition module, and maybe that module depends on d3-ease or d3-interpolate. You may not export anything from d3-ease or d3-interpolate at the top level, so you might not realize you need to install those modules, too.
Another way we could fix this would be to give d3-bundler an install command, so that it runs npm install for you with the appropriate expanded dependencies. But you’re still going to want to save those dependencies in your package.json and have control over the version numbers, so I’m not sure I want to duplicate any NPM functionality.

Related: we might need to think about versioning constraints on dependencies. Like what if two modules depend on conflicting versions? Since everything must exist at the top level (unless we want to allow code duplication), this probably should generate an error. But, it might still be nice to observe modules’ version constraints as defined in the package.json.

JSPM http://jspm.io/ has a compelling solution for package-level
dependency management that handles conflicting versions, and also does
installation, loading, and bundling of transitive dependencies. JSPM augments
package.json with a "jspm" property
https://github.com/curran/jspm-mocha-example/blob/gh-pages/package.json,
and installs dependencies in jspm_packages when you run "jspm
install". Guy Bedford, author of JSPM, discusses the multi-version issues
in his video Package Management for ES6 Modules (30:07)
https://www.youtube.com/watch?v=szJjsduHBQQ.
I'm not sure if you want to adopt JSPM, the Rollup solution you have so far
is really cool, but food for thought. It might be possible to use JSPM for
package management only, and Rollup for bundling, I'm not sure.
Here's an example project I made while evaluating JSPM
https://github.com/curran/jspm-mocha-example/tree/master that might be of
interest.
All the best,
Curran
On Fri, May 29, 2015 at 8:33 AM, Mike Bostock<EMAIL_ADDRESS>wrote:

Related: we might need to think about versioning constraints on
dependencies. Like what if two modules depend on conflicting versions?
Since everything must exist at the top level (unless we want to allow code
duplication), this probably should generate an error. But, it might still
be nice to observe modules’ version constraints as defined in the
package.json.
—
Reply to this email directly or view it on GitHub
https://github.com/d3/d3-bundler/issues/1#issuecomment-106848082.

This has been fixed in d3/d3-scale#3 and npm 3+: the dependent modules are installed at the top-level of node_modules and discovered via rollup-plugin-npm.


Spectating Issue

Dying while performing an emote will break your spectator camera until the ship leaves and you respawn. Your camera will be stuck in the void even if you switch spectator targets.

You are most likely using Corporate Restructure. This mod has errors that have not been fixed for a long time, and it actually prevents a lot of code from other mods from running, including mine.
But, if you are not running this mod, let me know and I can investigate this.

I am not running corporate restructure, no. This bug did not happen on previous versions of Too Many Emotes and started happening recently, one of the updates after adding jug band.

Ah, I misread your post. Dying was the trigger. Hmmm, I actually believe this happened to me before, so I don't think you're crazy. Let me see if I can find out what's going on. Thanks!


Clarification about how proteomics data is considered in ftINIT

Dear code developers and maintainers,
I am interested in performing metabolic reconstruction using ftINIT and proteomics data. However, I am afraid I am finding little guidance for this. Could you please help me out?  In particular,

I did find that for making reconstructions using Human Protein Atlas data, I first need to process the data using the function parseHPA. I downloaded sample information from the Human Protein Atlas; however the function appears to rely on the existence of a column called "Expression type". This appears missing in my downloads. Can you please clarify what value this should take?
The level of expression ("Level") appears to be one from a set of well-defined values: "Medium", "High", "Low" for instance. Is this relative to the abundance of other proteins in the same sample?
Can you please direct me to a resource which explains how the discrete values (as mentioned in 2) are utilized in metabolic reconstruction?

I would be very grateful for your help!

@johan-gson Hi, Johan. Maybe you can answer this? Thanks!

Hi, for Human Protein Atlas data you use ScoreComplexModel just as for RNA-Seq. I have never done this, but you should be able to supply the HPA data and skip the RNA-Seq

ftINIT and tINIT should be identical in this regard

Thank you very much.


Updated PPP

Pull Request Test Coverage Report for Build 402

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 60.794%

Totals

Change from base Build 397:
0.0%

Covered Lines:
1822

Relevant Lines:
2997

💛  - Coveralls


Parse request data to object

I perfer getting an object instead of dict, when work with request data. Will APIFlask support it in the future?
Just like FastAPI.
There is an example.
class PetIn(Schema):
    name = String(required=True, validate=Length(0, 10))
    category = String(required=True, validate=OneOf(['dog', 'cat']))

@app.post('/pets')
@app.input(PetIn)
def create_pet(json_data: PetIn):
    name = json_data.name
    category = json_data.category
    return {'message': 'created'}, 201

I'm not the author or a maintainer of this project, but I think the documentation suggests you can do this using marshmallow-dataclass: https://apiflask.com/schema/#use-dataclass-as-data-schema. Hope this helps!


feat: Added fvm and GitHub action

Dependence on other Pull Requests (optional)
#32
#33
#34
#35
Changes

added fvm
updated github actions

Checklist for self-check

[x] Commits and PRs have been filed according to the rules on the project.
[x] The author is marked as an assigne and assigned mandatory reviewers.
[x] Required labels marked
[x] Specified related tasks and/or related PRs.
[x] Specified Changes.
[ ] Attached videos/screenshots demonstrating the fix/feature.
[x] All unspecified fields in the PR description deleted.
[ ] New code covered by tests.

Checklist for reviewers

[ ] CI passed successfully (with a green check mark).
[ ] PR is atomic, by volume no more than 400 (+-) corrected lines (not including codogen).

Design:

[ ] System design corresponds to the agreements on structure and architecture on the project.
[ ] The code is decomposed into necessary and sufficient components.

Functionality:

[ ] The code solves the problem.
[ ] Any changes to the user interface are reasonable and look good.

Complexity:

[ ] The code is clear, easy to read, functions are small, no more than 50 lines.
[ ] The logic is not overcomplicated, there is no overengineering (no code sections that may be needed in the future, but no one knows about it).

Tests:

[ ] Updated or added tests for mandatory components.
[ ] The tests are correct, helpful, and well designed/developed.

Naming:

[ ] The naming of variables, methods, classes and other components is understandable.

Comments:

[ ] The comments are understandable and helpful.

Documentation:

[ ] All labels are correct
[ ] Technical documentation updated (after approval, updates last reviewer).

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (feature/migration-guide@d2f1a00). Click here to learn what that means.

:exclamation: Current head 6c1a372 differs from pull request most recent head 08f187d. Consider uploading reports for the commit 08f187d to get more accurate results

Additional details and impacted files
@@                    Coverage Diff                     @@
##             feature/migration-guide      #36   +/-   ##
==========================================================
  Coverage                           ?   44.00%
==========================================================
  Files                              ?        4
  Lines                              ?       25
  Branches                           ?        0
==========================================================
  Hits                               ?       11
  Misses                             ?       14
  Partials                           ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update sbt-scalafix to 0.9.32

Updates ch.epfl.scala:sbt-scalafix from 0.9.1 to 0.9.32.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "ch.epfl.scala", artifactId = "sbt-scalafix" } ]

labels: sbt-plugin-update, early-semver-minor, semver-spec-patch

Superseded by #157.


Combinatorics.GenerateVariation for large N

The space complexity of Fisher-Yates Shuffling is O(n+k). When N is very large, the algorithm will be unexecutable in limited memory, and a more memory-efficient algorithm is needed.

Very interesting, thank you!


Atom Echo gets stuck after detecting wake word

My Atom Echo detects one Okay Nabu, then it enters STREAMING_MICROPHONE and stays there. Home Assistant doesn't seem to see anything from the wake word. The Atom Echo device still seems to be alive since:

Use listen light can be turned on<->off
if I switch Wake word from On device to In Home Assistant then back to On device again it goes back to DETECTING_WAKE_WORD and lets me detect a keyword once again, then stuck in STREAMING_MICROPHONE state again.

Yaml used to create the firmware:
substitutions:
  name: m5stack-atom-echo-a1461c
  friendly_name: M5Stack Atom Echo a1461c
packages:
  m5stack.atom-echo-wake-word-voice-assistant: github://esphome/wake-word-voice-assistants/m5stack-atom-echo/m5stack-atom-echo.yaml@main
esphome:
  name: ${name}
  name_add_mac_suffix: false
  friendly_name: ${friendly_name}
api:
  encryption:
    key: !secret enc_key

wifi:
  ssid: !secret wifi_ssid
  password: !secret wifi_password

Log from Atom Echo:
[19:25:36][D][api:103]: Accepted <IP_ADDRESS>
[19:25:36][W][component:170]: Component api cleared Warning flag
[19:25:36][W][component:237]: Component api took a long time for an operation (56 ms).
[19:25:36][W][component:238]: Components should block for at most 30 ms.
[19:25:36][D][api.connection:1446]: Home Assistant 2024.12.3 (<IP_ADDRESS>): Connected successfully
[19:25:38][D][ring_buffer:034]: Created ring buffer with size 2048
[19:25:38][D][micro_wake_word:399]: Resetting buffers and probabilities
[19:25:38][D][micro_wake_word:195]: State changed from IDLE to START_MICROPHONE
[19:25:38][W][component:237]: Component voice_assistant took a long time for an operation (52 ms).
[19:25:38][W][component:238]: Components should block for at most 30 ms.
[19:25:38][D][micro_wake_word:107]: Starting Microphone
[19:25:38][D][micro_wake_word:195]: State changed from START_MICROPHONE to STARTING_MICROPHONE
[19:25:38][D][esp-idf:000]: I (40876) I2S: DMA Malloc info, datalen=blocksize=1024, dma_buf_count=4
[19:25:38]
[19:25:38][D][micro_wake_word:195]: State changed from STARTING_MICROPHONE to DETECTING_WAKE_WORD
[19:25:59][I][safe_mode:041]: Boot seems successful; resetting boot loop counter
[19:25:59][D][esp32.preferences:114]: Saving 1 preferences to flash...
[19:25:59][D][esp32.preferences:143]: Saving 1 preferences to flash: 0 cached, 1 written, 0 failed
[19:27:55][D][micro_wake_word:162]: The 'Okay Nabu' model sliding average probability is 0.992 and most recent probability is 1.000
[19:27:55][D][micro_wake_word:123]: Wake Word 'Okay Nabu' Detected
[19:27:55][D][micro_wake_word:195]: State changed from DETECTING_WAKE_WORD to STOP_MICROPHONE
[19:27:55][D][micro_wake_word:129]: Stopping Microphone
[19:27:55][D][micro_wake_word:195]: State changed from STOP_MICROPHONE to STOPPING_MICROPHONE
[19:27:55][D][esp-idf:000]: I (178218) I2S: DMA queue destroyed
[19:27:55]
[19:27:55][D][micro_wake_word:195]: State changed from STOPPING_MICROPHONE to IDLE
[19:27:55][D][voice_assistant:512]: State changed from IDLE to START_MICROPHONE
[19:27:55][D][voice_assistant:518]: Desired state set to START_PIPELINE
[19:27:55][D][voice_assistant:222]: Starting Microphone
[19:27:55][D][ring_buffer:034]: Created ring buffer with size 16384
[19:27:55][D][voice_assistant:512]: State changed from START_MICROPHONE to STARTING_MICROPHONE
[19:27:55][D][esp-idf:000]: I (178270) I2S: DMA Malloc info, datalen=blocksize=1024, dma_buf_count=4
[19:27:55]
[19:27:55][D][voice_assistant:512]: State changed from STARTING_MICROPHONE to START_PIPELINE
[19:27:55][D][voice_assistant:276]: Requesting start...
[19:27:55][D][voice_assistant:512]: State changed from START_PIPELINE to STARTING_PIPELINE
[19:27:55][D][voice_assistant:533]: Client started, streaming microphone
[19:27:55][D][voice_assistant:512]: State changed from STARTING_PIPELINE to STREAMING_MICROPHONE
[19:27:55][D][voice_assistant:518]: Desired state set to STREAMING_MICROPHONE

I've resolved the issue. My problem was that I forgot to set up the assist pipeline. Regardless I do find it strange that the echo keeps recording if HA doesn't respond due to a missing pipeline.


sidechain jams pending extrinsics (one extrinsic nonce skipped?)

Since running against polkadot-1.6.0 para (or since running SBliff legacy), we observe that after a few minutes or hours of operation, the validateer can't send extrinsics to the para anymore
checking pending extrinsics on the validateers rpc node (on same machine) shows that pending extrinsics are stacking up. The other nodes in the network don't see these extrinsics (or banned them?)

run validateer and wait until no more block confirmation events onchain

last  sidechain.FinalizedSidechainBlock: sidechain: 75,441, integritee: 7950
last enclaveBridge.ProcessedParentchainBlock: 7946

verify there are pending extrinsics on the validateers rpc node
restart rpc node

validateer logs during restart: https://gist.github.com/brenzi/db0857831d4a453613c72df425c2719a
SCV loses connection, but recovers when node back up. syncs missing blocks for TargetA and Integritee and then starts producing sidechain blocks again

restart SCV

first attempt:

first xt gets included (register QE collateral)
second xt fails with (register TCBinfo)  Transaction is outdated

in the same block we get

472x enclaveBridge.ProcessedParentchainBlock (7948..8419)
1x sidechain.FinalizedSidechainBlock(#75521) (only one valid. many failed with sidechain.AncestorNumberMismatch which makes sense all tried ancestor 75381) failures:(75461..81041 in steps of 20)

restart SCV again

smooth start.

first    enclaveBridge.ProcessedParentchainBlock: 8420
first sidechain.FinalizedSidechainBlock: 81061,

The fact that restarting the SCV triggers the avalanche tells me that all jammed extrinsics had futurestatus and that the next expected nonce was only coming in after the SCV restart fetched the latest nonce from the chain fresh.
possible workaround:

upon each parentchain block import, refresh nonce. but that may still not be acceptable becasue we can't afford missing a single extrinsic (could be unshield)

it happened again. this time I was fast enough to collect logs:

node: https://gist.github.com/brenzi/57db7f9928bf4307f5e5a6e7f29f9399
SCV: https://gist.github.com/brenzi/53db1d25800acc2edb0dca1db1334a20

last parachain block that has events: 8531

@ 8531 enclaveBridge.confirmProcessedParentchainBlock 8527
@ 8529 sidechain.confirmImportedSidechainBlock ancestorMismatch! SCV sends (ancestor: 81,761, candidate 81,841) but in that block, ancestor should be: 81,821

manually injecting the next xt on the collator works:
curl https://localhost:9933 -X POST -H "Content-Type: application/json" --data '{"method":"author_submitExtrinsic","params":["0x35038400d5af4118cfbe99a94626d14cd004c41eb05b4e98f559f432dfc5a5f2c8392584000fdbab1c43040b4b03751a3e4decde03e0969bb1c5e1c7d1e95788376a5935362c7bc5f682c5ba04c651e29085652135e6605716c5dfb7c315295d166039f80500e93b003601496e636f676e69746565546573746e6574303030303030303030303030303033d3cada17c76f6207e0c6b7e16c2d59ee0966bccd1ae654bd23f72096f50bbca65021000034a62e525e9f4cd4e2d2f7ca524e43af543cc9dac3a8e85457a63a581b4174fc"],"id":1,"jsonrpc":"2.0"}'

escalated: https://substrate.stackexchange.com/questions/11225/pending-extrinsics-jammed-how-to-ensure-re-broadcast

workaround: restart authority collator every 5min
proper solution, hopefully: https://github.com/paritytech/polkadot-sdk/issues/1202


Bindle server auth: support requiring auth for all request types

Currently, GET requests to a bindle server with auth configured (say, basic http or oidc) appear to always be served, meaning anonymous auth is still possible for these request types.
I think it would be useful to allow configuration in the server to restrict all request types (including GETs) to requiring auth creds per the auth strategy the server is running with.  Assuming we want to maintain the default of anonymous GETs, perhaps this would be an opt-in configuration/toggle.

@thomastaylor312 or is it already possible today to configure a bindle server to mandate that all requests be authenticated?

Not with how it is currently setup. We'll need to add a new Authorization implementation that checks if the user is authenticated. Should be a fairly simple code add, but then we need to add yet another branch to the match statement of doom in the server CLI code


Backport to 1.47: ring hash: fix picker propagation bug in xds_cluster_manager policy (#29959)

Failures seem unrelated


Slashes in definitions aren't properly escaped in json pointers

I'm converting a swagger 1 spec to swagger 2 json.  When a definition node has a key with a slash in it, $ref values should escape the slash per RFC 6901 (https://tools.ietf.org/html/rfc6901#section-5).
Example snippet
"definitions":{"get_foo/foo":{"description":...
should be referenced
"$ref":"#/definitions/get_foo~1foo"
The services I'm dealing with used ServiceStack's Swagger plugin and generate keys with slashes.

Looking through the code, I believe this is an issue with swagger-converter. Closing the issue.


CI is broken

It looks like the CI is broken that emits the following error message. See this
 --> crates/thirdparty/src/lib.rs:2:5
  |
2 | use oci_spec::runtime::Mount;
  |     ^^^^^^^^

CI seems to work if you disable cache:
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 74b3692..3d8637e 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -22,13 +22,6 @@ jobs:
       - uses: actions-rs/toolchain@v1
         with:
           toolchain: stable
-      - uses: actions/cache@v3
-        with:
-          path: |
-            ~/.cargo/registry
-            ~/.cargo/git
-            target
-          key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
       - name: Install libcontainer dependencies
         run: |
           sudo apt install libseccomp-dev

Perhaps, the key needs to include some version / build data from the runner. It seems like the underlying native libs in the runner changed between builds.
For now, I vote we just remove the cache.


Optimize Instance normalization to support any kind of image size

BTW this introduces a bug - it's not safe to remove the threadgroup_barrier on line 57 of instanceNorm.metal, since then threads race between the read in const float4 mean = shared_mem[0]; (line 59) and the write in shared_mem[tid] = sum;, since tid 0 will write after reading.

 Thanks for pointing that out.

BTW if you're deriving from code in the Caffe2 MPSCNN backend, it'd be nice to add a citation/reference somewhere (and of course it'd be great to get improvements upstreamed as well 👍)

That is correct, we should have done that in the first place. Our mistake.
I have added a mention and fixed the issue.
My improvements are basically to allow a wider range of use cases. I do not know which would apply at Caffe2's code.
Thanks for your feedback. If you have more feedback it will be very welcome 😄


Fix the docs to stop using print(repr(obj))

Somehow we ended up in the habit of using print(repr(obj)) when print obj (or print(obj) for Python 3 compatibility) works just fine.
This is used in a number of our tutorials and it would be good to simplify them to use the sensible version before 1.7.

I don't think print works nicely with Layouts yet:

Fixed in the PR referenced above (#1048). Closing.


Add csslint to exclude CircleGraph/external

This will add csslint tool to exclude media/CircleGraph/external folder
as files are from external source.
ONE-vscode-DCO-1.0-Signed-off-by: SaeHie Park<EMAIL_ADDRESS>

I tried to search if there's any file format like .gitignore for csslint. However it seems that they don't support such file.


[FEATURE] Create team event

What is the feature request for?
Add something like a CreateTeamEvent as mentioned in #417
Relevant links
https://github.com/booksaw/BetterTeams/tree/master/src/main/java/com/booksaw/betterTeams/customEvents
Additional Information
No response
Feature requests are not going to be implemented by booksaw, instead you will have to find another developer to make a pull request to implement the feature.

[X] I understand

This feature has been implemented and will be included in the next update. Thank you for the suggestion.


WIP : Iss 77 (validation for SimpleType)

Added Validation for possible Kinds. Few topics are missing like Enum, User, Reference etc.
ToDo :- table driven unit testing for Validate method in field definition.

This change is

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

models/field_definition.go, line 40 [r1] (raw file):

	ConvertFromModel(value interface{}) (interface{}, error)

	Validate(value interface{}) error

Why do we need this method? Who will call it? What is it's purpose?

Comments from Reviewable

I think you're going down the wrong rabbit hole with "Validate". I don't see it as necessary for task #77 (which is about adding test that our conversion works correctly).

Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

Comments from Reviewable

This PR has been superseded by https://github.com/almighty/almighty-core/pull/115