Need check_val_every_n_steps in Trainer

🚀 Feature
Add an argument check_val_every_n_steps in Trainer.__init__ function to check metrics of validation set for certain steps.
Motivation
For many tasks, large models are trained in steps not complete epochs, especially pretrained models in CV and NLP. As a consequence, step-based arguments like max_steps, log_every_n_steps may be more convenient than epoch-based ones. However, the Trainer API only has a check_val_every_n_epoch argument for computing metrics of validation data. It's very helpful to have an additional argument like check_val_every_n_steps in Trainer constructor.
Pitch
Trainer.init(..., check_val_every_n_epoch=1, check_val_every_n_steps=100, ...)

Another confusing concept is batch_idx in training_step, validation_step and test_step. A detailed example or illustration may be helpful to understand this concept. From my experience, batch_idx may be not widely used in developing models.

Another confusing concept is batch_idx in training_step, validation_step and test_step. A detailed example or illustration may be helpful to understand this concept. From my experience, batch_idx may be not widely used in developing models.

there is val_check_interval for that.

there is val_check_interval for that.

@rohitgr7 val_check_interval can't exceed a single epoch. So it does not support evaluation every n steps where n is larger than the amount of batches in the dataloader.

hey @yuvalkirstain not yet.
here is the tracking issue: https://github.com/PyTorchLightning/pytorch-lightning/issues/8135


Relax schema restrictions on "env"

The container environment variables are already automatically quoted:
https://github.com/nano-byte/helm-charts/blob/45c2591c9594645daba75178e3f0925879803eac/charts/generic-service/templates/controller.yaml#L422
But it was still not possible to use integers because the values schema enforced string properties. Removing this restriction allows to reuse values like this:
monitoring:
  enabled: true
  port: &servicePort 1234  # <-- this requires an integer by definition

env:
  SERVICE_PORT: *servicePort  # <-- this previously required a string, but now can also be an integer

Thanks for the MR!
By the way, for the specific use-case of passing the ingress.port or metrics.port into the container as an environment variable, you can use the pre-defined PORT and METRICS_PORT environment variables.

Thanks for the MR!
By the way, for the specific use-case of passing the ingress.port or metrics.port into the container as an environment variable, you can use the pre-defined PORT and METRICS_PORT environment variables.

Yup, that's true. But there might be cases where the variable name is predetermined by the application. Of course, you could then alias the variables (e.g { name: CUSTOM_PORT, value: $(METRICS_PORT) }) but I find it a bit more explicit to use anchors in this case. It conveys a different relationship, something like "my custom port also serves metrics" instead of "my metrics endpoint also serves custom traffic".


ebpfclient : API surface for prog load, attach, maps, pinning, query

@saxena-anurag

Still missing APIs for:

Detach without unloading (blocks #191)
Unpin without unloading or detaching (blocks #190)
...

Actually many more APIs are remaining as per the API doc.

The main items were done, moving the remaining items to a separate (smaller in scope) issue to track


Clicking logo in navbar takes you to home page

^title

Nice baseline but could you change the text decoration of the link so that it isn't underlined when hovered over?

No problemo


Update to WinAppSDK 1.3.2

Description
Update all samples to the latest stable version, 1.3.2.
Target Release
1.3.2

@pratikone @bpulliam Antmy news ?

Sorry this got missed. All changes should have gone through with the 1.4 change, but let us know if we missed anything.


merged zagg client and pcp into oso-rhel7-host-monitoring container

This failed because we are checking in vendor libraries that are a clone from another repo.

:+1:


Use 32 bit Msys2 to workaround Tea CI bug

Thanks for using Tea CI!
Just noticed 64 bit Msys2 fails for your build, sorry about that, you could use 32 bit as a workaround: https://github.com/TeaCI/tea-ci/issues/11

Thanks!
I think the remaining error is a Wine, Waf or Python bug I've also seen with Wine on my local Linux machine: https://tea-ci.org/jhasse/pwcalculator/7

Not sure what's wrong, I'll have a look (very very) later. Busy preparing for immigration visa, I'm very slow for everything else until November. :)
If you are able to debug deeper that would be great, other wise we will wait.

Closing as Tea CI seems to be discontinued.


Opensolo not compatible with Solo Simulator

So I know this may be considered low priority, but it's high priority for my son.  The solo simulator has no problem recognizing when my open solo artoo connects, and the on screen display of the sticks moving works fine. But it doesn't recognize any button presses, specifically the FLY button, so you cannot take off.
It worked just fine before I updated to open solo3.0.0.
I'd love to see if you could look into why it doesn't work anymore. I might be able to contribute some code help, but my c isn't strong. I can test it though!!  My son sure would appreciate it.
Thanks
Play store link
https://play.google.com/store/apps/details?id=com.o3dr.solosimulator

The simulator app will not work with Open Solo.  Since 3DR has not released that app to the open source community, it cannot be updated to keep up with the changes in Open Solo.  There is nothing we can do about it.

I know there was a source saying they were still "thinking" about open sourcing the solo app (which would put Solex out of business..sort of) but what came of those discussions? And I wonder if they'd be willing to OS the simulator.  Again, I know it is very low priority.
Probing question, is there a way that the Artoo can know whether it is connected to the actual Solo or the simulator? It appears that the changes made here are the changes which "broke" compatibility.  But, if the artoo can know it is connected to the simulator, could it revert to the "old" button functionality?
Perhaps i'm simplifying it way too much..and I totally understand that probably no one but me cares.  I would like to find a way to practice (rehearse) the modes prior to going on site.
Thanks for responding.

Yes, that button reworking is why the simulator app no longer works.  No, it is not able to know what app is connected.  Even if it was, it would not be practical to reengineer for compatibility with the old stuff.
The simulator app has seen no development for nearly 3 years. There has been no movement on open sourcing it or the 3DR Solo app. I'm sorry to say, it is dead. Even if they magically open sourced it today, there is nobody that even has the desire to work on it. It's dead and has been for a long time now.

Ok thanks!
Looking forward to the inevitable future awesome of Open Solo. Thanks for
the work you've put into this.
On Mon, Mar 19, 2018, 4:57 PM Matt<EMAIL_ADDRESS>wrote:

Yes, that button reworking is why the simulator app no longer works. No,
it is not able to know what app is connected. Even if it was, it would not
be practical to reengineer for compatibility with the old stuff.
The simulator app has seen no development for nearly 3 years. There has
been no movement on open sourcing it or the 3DR Solo app. I'm sorry to say,
it is dead. Even if they magically open sourced it today, there is nobody
that even has the desire to work on it. It's dead and has been for a long
time now.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/OpenSolo/artoo/issues/10#issuecomment-374373520, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ALCovXC5h0jfJc-CEoun4JKIJntfrAbRks5tgBupgaJpZM4Svec8
.


Feature: Generation vs crawling

tracking in branch https://github.com/leonstafford/wp2static/tree/feature/generation-vs-crawling
originally discussed/tested in https://github.com/leonstafford/wp2static/discussions/760#discussioncomment-411432
can simulate running this within PHP, aka plugin, by entering wp shell and running:
$_SERVER['REQUEST_URI'] = '/author/admin/';
include 'index.php'

will output the admin author page's HTML.
Pros:
bypass webserver (don't need one at all)
reduce network latencies
esier to write caching logic
Cons:
lose webserver's request based process pooling?
need to simulate some WP bits, ie these var errors below:
Constant AUTH_KEY already defined in /usr/html/wp-config.php on line 49
Constant AUTH_SALT already defined in /usr/html/wp-config.php on line 53
Constant DB_CHARSET already defined in /usr/html/wp-config.php on line 35
Constant DB_COLLATE already defined in /usr/html/wp-config.php on line 38
Constant DB_HOST already defined in /usr/html/wp-config.php on line 32
Constant DB_NAME already defined in /usr/html/wp-config.php on line 23
Constant DB_PASSWORD already defined in /usr/html/wp-config.php on line 29
Constant DB_USER already defined in /usr/html/wp-config.php on line 26                                                                                PHP Warning:  Constant LOGGED_IN_KEY already defined in /usr/html/wp-config.php on line 51
Constant LOGGED_IN_SALT already defined in /usr/html/wp-config.php on line 55
Constant NONCE_KEY already defined in /usr/html/wp-config.php on line 52
Constant NONCE_SALT already defined in /usr/html/wp-config.php on line 56
Constant SECURE_AUTH_KEY already defined in /usr/html/wp-config.php on line 50
Constant SECURE_AUTH_SALT already defined in /usr/html/wp-config.php on line 54
Constant WP_CACHE_KEY_SALT already defined in /usr/html/wp-config.php on line 57
Undefined array key "SERVER_NAME" in /usr/html/wp-includes/general-template.php on line 3413
Undefined array key "host" in /usr/html/wp-includes/canonical.php on line 687
Undefined array key "host" in /usr/html/wp-includes/canonical.php on line 687
Undefined array key "host" in /usr/html/wp-includes/canonical.php on line 696
Undefined array key "host" in /usr/html/wp-includes/canonical.php on line 696
Undefined array key "host" in /usr/html/wp-includes/canonical.php on line 699
Undefined array key "host" in /usr/html/wp-includes/canonical.php on line 699
Undefined array key "scheme" in /usr/html/wp-includes/canonical.php on line 720
Undefined array key "scheme" in /usr/html/wp-includes/canonical.php on line 720

how to deal with binary files? just do a straight copy?

doing the include() seems messier than calling directly from php index.php, we're trying to reload a bunch of stuff we already have instantiated... should be able to call a WP method higher up the chain.... let's see...

note, to tail requests output, can put ~ line 73 in wp-includes/canonical.php: error_log(print_r($requested_url, true));

for our generation, we don't need a LOT of WP stuff, we need a read-only system to generate the frontend, no wp-admin, etc. could be used in Lokl just for generation, else likely impractical...

still, could be fun project to build a tiny, fast WP just for generation stage....

not happy with this little test. Really want to avoid exec'ing and do the generation programmatically. with the standalone WP URL Generator library I've started, we'll have the seed URL list to start with.
I'm less worried about having any on-file-change auto regeneration of specific site sections, rather, just have the fastest way to generate a whole WP site statically, without a webserver.
ideas:
simple outside-in approach

get URL list independently (from WordPressURLDetector library)
open mass number of threads, each calling index.php with vars set to simulate webserver request (still slow, loading whole WP each time)
use php process manager or something similar to avoid boostrap overhead per php process
use stripped down WP version (override functions majority of sites don't need)

inside-out approach

we know what pages need authoring (authors, categories, custom posts, sitemaps, etc) and know their intended URLs.
avoid plugin overhead by including in theme's functions.php, no composer, etc?
options to cache all header and/or footer renders
need to allow all WP hooks/filters to run, so do we need to run within WP?
dequeue/override all non-essential filters, like the cringey capital_P_dangit
apply other optimizations like disabling emojis, look for things in Little Bizzy, WP-Strip-Naked, etc.

more thoughts:

set site_url / home programmatically, to avoid rewriting before later
wp-load.php doesn't do much, we can start further up if loading from external script

define( 'ABSPATH', __DIR__ . '/' );
// toggle error reporting with a DEBUG mode for this script. We have developed WP site, mindful of errors, so this should just be catching issues with our generator

define('THISSCRIPT_DEBUG', false);

if(THISSCRIPT_DEBUG === true)
{
   error_reporting(E_ALL);
   display_errors(true);
   log_errors(true);
}
else
{
   error_reporting(0);
   display_errors(false);
   log_errors(false);
}

The normal "boot sequence" of WordPress (started in wp-blog-header.php) loads the plugins, parses the URL, executes a post query based on the URL, and calls the theme. This main post query is typically used in "The Loop". So if you want all the advantages of URL parsing but not display it using the site theme, you can set WP_USE_THEMES to false and it will not execute that final step


feat: allow getSecurityToken to receive an address as a parameter

also fixed a bug with getSecurityTokens

:tada: This PR is included in version 2.0.1-beta.23 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Out memory when creating or updating b"string"

Laravel Version: 5.3.31
PHP Version: 7.0.9
Database Driver & Version: Jesenger/MongoDB 3.0 and above

Description:
Creating and updating of any record with a binary string will result in out of memory
Allowed memory size of ######### bytes exhausted (tried to allocate ********** bytes)
The misery there is that ######### is always greater than **********
Steps To Reproduce:
Include special character like "°ó" in any string field

Do you have a stack trace for this?


RTR Shell with Queueing Does Not Work if No Systems are Online

I have received an internal bug report that the -q queueing option does not yield a useful shell if no systems are online at all. Getting this issue open to track this issue until it is confirmed and remediated.

This bug is not yet confirmed and has not been raised by anybody else. I will leave this issue open a little while longer in case somebody else can reproduce it.

This has not been reproduced so I am closing this issue for now


Agents not running on heroku.

I have huginn running on heroku but my agents aren't running automatically.  I setup a cron job from another server to load ping huginn every minute but that doesn't seem to have worked.  Is there a specific url I should be pinging and is every minute enough or too much?
Thanks.

Every minute should be more than enough. I'm surprised that's not working.
Is there anything in your "heroku logs"?
On Thursday, March 26, 2015, wootwoot1234<EMAIL_ADDRESS>wrote:

I have huginn running on heroku but my agents aren't running
automatically. I setup a cron job from another server to load ping huginn
every minute but that doesn't seem to have worked. Is there a specific url
I should be pinging and is every minute enough or too much?
Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/cantino/huginn/issues/760.

Thanks for writing back.
There isn't anything in the logs that suggest there are any errors and nothing during the time when it's scheduled to run.  Is there a specific url I should be pinging or is the root url (main page) fine?  It's only a few days old but maybe I should update it?

You could try hitting /users/sign_ininstead, but I do find that strange.  Does it correctly run scheduled Agents when you're actively using it?

I have my agents set to run every 5 hours.  It ran correctly last time but
I was actively using huginn.  I'm going to leave it alone for 5 or 10 hours
and see if it runs on it's own.  I'll also check on the cron job and make
sure it's running correctly.
On Thu, Mar 26, 2015 at 2:09 PM, Andrew Cantino<EMAIL_ADDRESS>wrote:

You could try hitting /users/sign_ininstead, but I do find that strange.
Does it correctly run scheduled Agents when you're actively using it?
—
Reply to this email directly or view it on GitHub
https://github.com/cantino/huginn/issues/760#issuecomment-86695185.

Looks like that fixed it.  Thanks!

Great!


Create Interoperability Precis.md

Also noticed its in a folder called folderAWG; unsure if that's on purpose or not. Also, did you mean to call the filename "Create Interoperability Precis.md". Just checking in case.

@jcstine is the work in this PR superseded by the other précis work done elsewhere?

Will be resubmitting as PDF


Support C# comments

This issue is to track work required to support parsing /// comments from C# and generating open api document from it.

VS extension is getting built to support this.


Update @mlaventure e-mail address

Signed-off-by: Kenfe-Mickael Laventure<EMAIL_ADDRESS>--
Since I won't have access to it in a week or so, I figure I'll change it. I'm not sure how/where to request updates for the CNCF database
/cc @crosbymichael @caniszczyk

Codecov Report

Merging #1646 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1646   +/-   ##
=======================================
  Coverage   48.67%   48.67%
=======================================
  Files          27       27
  Lines        4074     4074
=======================================
  Hits         1983     1983
  Misses       1672     1672
  Partials      419      419

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c66fd83...bdf801b. Read the comment docs.

LGTM


Firebase

Ionic version:  (check one with "x")
(For Ionic 1.x issues, please use https://github.com/ionic-team/ionic-v1)
[ ] 2.x
[ ] 3.x
[ ] 4.x
I'm submitting a ...  (check one with "x")
[ ] bug report
[ ] feature request
Please do not submit support requests or "How to" questions here. Instead, please use one of these channels: https://forum.ionicframework.com/ or http://ionicworldwide.herokuapp.com/
Current behavior:

Expected behavior:

Steps to reproduce:

Related code:

insert short code snippets here

Other information:

Ionic info: (run ionic info from a terminal/cmd prompt and paste output below):
insert the output from ionic info here

Hi

Hello! While we appreciate you opening an issue with us I am going to close this issue and ask that you open a new one that has the issue template filled out, please. Thanks for using Ionic!


refactor(WEG-114): Hide circles not matched by the filters

:tada: This PR is included in version 1.3.0-rc.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


DEADBEEF guid for materials.

Some extracted materials will have a deadbeef guid. (Clearly not a proper guid.) The deadbeef guid looks like '0000000deadbeef15deadf00d0000000'. I'm unaware if this is because of a bug or if it's just something not implemented just yet for certain materials.
Files used: http://www.mediafire.com/file/7h6rbfocarrbqc0/toonTropolis14.unity3d_unpacked.zip/

That means that some of dependencies hasn't been found. When you exports assets you can notice yellow messages like "Import: Dependency 'library/cache/15/157fbb10579613340adf8f8edda104c2' hasn't been found". You need all files in one place to export them properly.
I'm not sure about what kind of file was mentioned above but "Import: Dependency 'library/unity default resources' hasn't been found" definitely should present in every project.

Fixed reading of this bundle file in 7f5770794889746845eac9f1ad0d03eb4fb97a6d. I'm not familiar with asset bundles of such low versions, maybe it is normal to have assemblies and main scene in asset bundle and maybe it is some kind of user packed bundle . Anyway, .unity3d is asset bundle and asset bundle isn't complete game it is just additional content for it. So if you want to fix guid in materials you need to rip main game files and this bundle together.

Well, as I understand it is a webgame so there is no any main game files :) I mean you have to find web player files for 2.6.1 Unity version and use them.

Oh i have those. However they fail to even load with another error. http://prntscr.com/kmma04 http://www.mediafire.com/file/53wf36t3tbid221/unity_default_resources/file

You need to get this file from Web Player installer but not from Unity Editor. Same with dlls.  However there is another bug so it doesn't work anyway. For now you can extract resource files but you need to use unpacked files from your first link and you need to delete dll files.

Well, I fixed what I could in f18ba8cd21c3e828b55c284c575e663de5db78d9. However, old versions are so drastically incompatible with UR than at the current state I just can't support it at 100%. Last version should be able to extract assets correctly, however some MonoBehaviours could be broken.

Well this is better then absolutely no solution. MonoBehaviours aren't much of an issue luckily. They're the least of our issues. I'm just happy to have asset extracting working right. It may be possible to fix up MonoBehaviours further but i'd have to do research in how to the old versions work compared to the new ones. I'll check out if the assets extract right and be sure to let you know when i can.

This seems to be fixed in terms of materials. Thanks for that. Now i can move along much further then before. I did notice a flare did not get a good guid in a scene though. So there's that to know about. I'll close this issue as this particular one should be fixed.

Flare export isn't supported yet. If I don't forget I'll add it later together with other missed asset types.


Action 'AutoEnum:2232721770192' failed to activate. Traceback:

Dude am I doing something wrong?
I am getting the following error.
Action 'AutoEnum:2232721770192' failed to activate. Traceback:
Traceback (most recent call last):
File "G:\Dos/IDA Professional 9.0/plugins\enumlib\ui_plugins\ida_plugin.py", line 148, in callback
ea = next(ida_funcs.get_func(ea).addresses())
AttributeError: 'NoneType' object has no attribute 'addresses'
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "G:\Dos/IDA Professional 9.0/plugins\enumlib\ui_plugins\ida_plugin.py", line 111, in activate
self._activate(ctx)
File "G:\Dos/IDA Professional 9.0/plugins\enumlib\ui_plugins\ida_plugin.py", line 222, in _activate
main()
File "G:\Dos/IDA Professional 9.0/plugins\enumlib\ui_plugins\ida_plugin.py", line 267, in main
get_imports(library_calls, library_addr)
File "G:\Dos/IDA Professional 9.0/plugins\enumlib\ui_plugins\ida_plugin.py", line 171, in get_imports
idaapi.enum_import_names(i, import_names_callback)
File "G:\Dos\IDA Professional 9.0\python\3\ida_nalt.py", line 3797, in enum_import_names
return _ida_nalt.enum_import_names(mod_index, py_cb)
SystemError:  returned a result with an exception set

Should be fixed in https://github.com/junron/auto-enum/commit/780517d8cdd0eb8c0bb8191cd676ec2dc1339f92.

Problem solved, thanks for the plugin.


Updated Cocoapod soon?

Looking at ASValuePopUpView.h on master you have the a property that I need to update the arrow length:
@interface ASValuePopUpView : UIView

@property (nonatomic) CGFloat arrowLength;

However, using the latest Cocoapod, 0.10.1 (which points to tag 0.10.1), this property doesn't exist.  Is there a plan to roll out this change in an updated Cocoapod soon?
Thanks!

Thanks for the reminder! This really should have happened a while ago - whoops! My focus has been on various Swift projects, so venturing back to Obj-C tends to feel a little painful ; )
As a temporary workaround you could specify the commit in your podfile. See my response in #46. I'll get this sorted ASAP.

Thanks, I have been using the latest commit in my podfile for now to get the working.  This issue was opened just to see if you plan on updating it soon =)
Thanks!

Finally got around to releasing the new version : )


Document validator results

Description
Includes a new section in aac validation documentation on validator results, which provides information on the return data of validators.
Linked Items:
Closes #593
Checklist:

[x] I updated project documentation to reflect my changes.
[x] My changes generate no new warnings.
[x] I updated new and existing unit tests to account for my changes.
[x] I linked the associated item(s) to be closed.
[ ] I bumped the version.
[x] I added the labels corresponding to my changes.

Version bump.


Remove the piezo element

It's not really going to be sufficient for self-testing. If I want to implement self-test, this should be done with a headphone speaker coming from the audio out port.

Resolved in 58e898a


⚠ Spryr has degraded performance

In ce8faaa, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 6885 ms

Resolved: Spryr performance has improved in c8eea4b after 8 minutes.


DRILL-6129: Fixed query failure due to nested column data type change

Problem Description -

The Drillbit was able to successfully send batches containing different metadata (for nested columns)
This was the case when one or multiple scanners were involved
The issue happened within the client where value vectors are cached across batches
The load(...) API is responsible for updating values vectors when a new batch arrives
The RecordBatchLoader class is used to detect schema changes ; if this is the case, then previous value vectors are discarded and new ones created
There is a bug with the current implementation where only first level columns are compared

Fix -

The fix is to improve the schema diff logic by including nested columns

@amansinha100 can you please review it?

Note that a similar bug was recently fixed in (as I recall) the Merge Receiver. As part of this fix, would be good to either:

Determine if we have more copies of this logic besides the Merge Receiver (previously fixed) and the client code (fixed here.)
Refactor the code so that all use cases use a common set of code for this task.

In any event, would be good to compare this code with that done in the Merge Receiver to ensure that we are using a common approach. See exec/java-exec/src/main/java/org/apache/drill/exec/record/BatchSchema.java in PR #968.
The two sets of code appear similar, depending on what isSameSchema() does with a list of MaterializedFields. But, please take a look.

Thanks @paul-rogers for the information; I went through the PR and noticed the following:

BatchSchema invokes MaterializedField.isEquivalent()
With my fix, both methods consider nested columns but they have several differences

RecordBatchLoader requires sameness as this information is used to reuse the value vectors; if old and new batch are deemed same, then the value vectors are reloaded using the load(...) API. The metadata better be the same or a runtime exception will occur

RecordBatchLoader isSame(...) API compares two different java objects: SerializedField (obtained from protobufs) and already materialized value vectors MaterializedField

RecordBatchLoader isSame(...) API tolerates unordered fields (within the same level) but not MaterializedField.isEquivalent() method

MaterializedField.isEquivalent() ignores hidden columns such "$bits" and "$offsets" but not RecordBatchLoader isSame(...)

I think moving forward, the best way to prevent bugs with regard to schema changes is by maintaining a document that establishes all the rules. This will allow QA to refine their tests and catch current limitations.

Seems ok to fix the RecordBatchLoader.isSameSchema() since it is missing the checks for nested columns.  In order to do the consolidation that Paul suggested,  you might want to open an enhancement JIRA.  Since MaterializedField and RecordBatchLoader have separate class hierarchies, there's not a direct way to have a single method do the comparison.   One option is to create a utility 'SchemaComparator' class that incorporates various static utility methods and Javadoc the rules for the comparisons.
So, I am +1  on this change.

Thank you Aman and Paul for reviewing this JIRA. I have created a new JIRA DRILL-6131 to track the new SchemaComparator utility for sharing schema comparison logic.


on selecting child from repeater plugin *output is not working

Hi there,
I don't know what's going on with the repeater output, it is acting weirdly!
Figma data binding
Step 01

Step 02

Browser Output

But on selecting the repeater child output is not working accordingly.
viewModel: {
        selectedRow: {},
        rows: [],
      },

Please help me figure out the bug, I appreciate your efforts...
regards,
Muhammad Fahad Islam.
Email<EMAIL_ADDRESS>Twitter: https://www.twitter.com/_fahadislam
Github: @fahad-islam

Solution: If you want to select a repeater child. You must have to use Figma Prototype.


Incomplete documentation for Android SDK Location

I installed the Android SDK to C:\Program Files\Android\Android Studio
Restarted VS 2017(Community Edition), Windows, in-installed, reinstalled Android Studio.
No matter what I do the red asterisk mark would not go.
Problem is with SDK installation, with Visual studio, Windows Home edition or my bad times not sure.
I have spent know 4 hours trying to fix the issue.
Finally came across another documentation that might be addressing my problem:
https://docs.elementscompiler.com/VisualStudio/Setup/AndroidSDK/
Not sure if this would solve the problem but its worth trying.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5f0a639d-0482-2f3b-839e-a849cb91ee53
Version Independent ID: cbb04044-0a5f-0403-282b-32a6032435c4
Content: Where can I set my Android SDK locations? - Xamarin
Content Source: docs/android/troubleshooting/questions/android-sdk-location.md
Service: unspecified
GitHub Login: @mgmclemore
Microsoft Alias: mamcle

Thanks for letting us know. This does seem very related to an issue I filed with DeveloperCommunity: SDK manager doesn't detect Android SDK
I see that this issue has been resolved. Hopefully this latest release of the SDK Manager fixes the problem.


test: make sure do not ignore the UI tests

Found it from https://github.com/tokio-rs/console/actions/runs/6988785469/job/19016699616?pr=493.
If the binary does not exist, it will ignore the test cases.
After this change, it will bail out an error.
I moved it to integration tests dir, we don't need to build the binary manually.

Thanks for your review!  💚 💙 💜 💛 ❤


⚠ RPC server - Astar has degraded performance

In 8c7cf56, RPC server - Astar ($ASTAR_RPC_URL) experienced degraded performance:

HTTP code: 0
Response time: 0 ms

Resolved: RPC server - Astar performance has improved in 91f38c7 after 6 minutes.


Refactor so all params-related things are driven by schema

This PR completes the unification of plan specific parameters definition, validation, definition of default values, encryption/decryption (for sensitive params) under one mechanism-- a wrapper of sorts around map[string]interface{} that uses schema to inform data access, marshaling/unmarshaling operations, etc.
This is, unfortunately, a necessarily large PR. Many apologies for that. The change had many "ripples," which prompted further refactoring to ensure things would continue working.
Some additional highlights from this PR:

Comments a recently added assertion that was causing test failures if Redis wasn't reset between test runs. This was a practical measure to allow me to keep moving.
To limit the size of the refactor to the extent possible, preview and experimental modules have been removed from the build using build tags (and comments wherever entire files couldn't be excluded). @jeremyrickard has already updated docs accordingly in another PR.
One ripple would have required refactoring of how params are compared to one another when deciding whether an inbound provisioning or updating request is a duplicate of a request already in-progress. This logic was actually flawed to begin with and relates to an open/unresolved issue in the OSB spec. Rather than waste time refactoring a flawed heuristic, I elected to stop doing the thing that made this comparison difficult in the first place-- we've stopped defaulting / auto-generating values for location and resourceGroup params and, in fact, we have entirely stopped treating those params as if they are special in some way. Lumped in the same category are tags. The bottom line is this allows a straight comparison of inbound params to existing params to determine if a request is logically equivalent to current state or to an operation already in-progress.
As an entirely necessary validation of this refactored code, I have merged in some e2e tests that were hanging out in another branch for some time. I have not integrated these into our CI process because I don't believe that these tests, in their current form, do an adequate job of reporting what failed, where, and why. One needs to scour logs to make that determination. Until this is fixed, they're an inadequate substitute for our existing service lifecycle tests. At least, however, we can manually kick off e2e tests to receive some additional assurances of code health before a release.

@jeremyrickard let's walk these changes together.

Kicking CI. Previous run failed due to what I think may have been a transient network error while verifying vendored code.

@jeremyrickard still running into a problem with vendored code. I believe that what has happened is that with many modules (temporarily) disabled, the sum total of what is computer to be required during verification is less than what is actually in the vendor/ dir currently.
I'm going to run dep ensure to update the vendor/ dir and amend this PR.


$meteor.object sends entire object on update of single property

I'd like to have something like:
<input ng-model="currentUser.profile.name" type="text">

But because a $meteor.object $sets the entire object on change, the request is denied because of security restrictions on the non-profile properties of the user.
Lines 125-132
angular-meteor-object.js
============
        }, function (newItem, oldItem) {
          if (newItem !== oldItem && newItem) {
            var newItemId = newItem._id;
            if (newItemId && !_.isEmpty(newItem = _.omit(angular.copy(newItem), '_id'))) {

              // Instead of updating the entire object, why not do diffObject and
              // only $set those properties that changed
              collection.update({_id: newItemId}, {$set: newItem});
            }
          }
        }, true);

I can work around the issue with something like this:
index.ng.html
==============
<input ng-model="currentUser.profile.name" type="text" ng-keyup="loginCtrl.syncUsername()">

controller.ng.js
=================
ctrl.syncUsername = function() {
    Meteor.users.update({_id:Meteor.user()._id}, {$set {"profile.name":$rootScope.currentUser.profile.name}});
};

Yes that's true.
It's something we have on $meteor.collection.
I starting to see that there is no real difference between $meteor.collection and $meteor.object as people use nested collections in both.
$meteor.object started just to simplify the user's code a bit, because you can achieve the same thing with $meteor.collection very easily.
I'm thinking of merging the code of $meteor.object to just use $meteor.collection
Would love thoughts and help on that

@Urigo I do use $meteor.object in the resolve part of states to determine if the page should be displayed or to show a 404 page instead. Here's an example of how I use it:
.state('my.state', {
  url: '/state/:id',
  resolve: {
    statesSub: ['$meteor', '$stateParams', function($meteor, $stateParams) {
      return $meteor.subscribe('states-single', $stateParams.id);
    },
    state: ['$meteor', '$stateParams', '$q', 'statesSub', function($meteor, $stateParams, $q) {
      var obj = $meteor.object(States, $stateParams.id, false);
      if(!obj._id) {
        obj.stop();
        return $q.reject('NOT_FOUND');
      }
      return obj;
    }]
  }
});

And then use an error catcher to display a 404 page:
.run(['$rootScope', '$state', '$meteor', function($rootScope, $state, $meteor) {
  $rootScope.$on('$stateChangeError', function(event, toState, toParams, fromState, fromParams, error) {
    switch(error) {
      case 'AUTH_REQUIRED':
        return $state.go('login');
      case 'FORBIDDEN':
        return $state.go('403-page');
      case 'NOT_FOUND':
        return $state.go('404-page');
    }
  });
}]);

What if $meteor.oject is kept but that it only updates the required fields instead of the full doc?

@auterium I would love your help in thinking how to refactor $meteor.object with the following goals:

make it based on $meteor.collection to avoid code duplicates
Move it's functionality functions like reset and getRawObject to $meteor.collection so they both will enjoy it
Keep the $meteor.object functionality as is (with the improvements of $meteor.collection like nested copy)

After all, find one is just:
https://github.com/meteor/meteor/blob/devel/packages/minimongo/minimongo.js#L128-L144

Also, for a short term solution, we can just copy the logic of diffArray from the collection to object.
@ fredrikekelund created that great nested solution, what do you think?

Also, for a short term solution, we can just copy the logic of diffArray from the collection to object.
@fredrikekelund created that great nested solution, what do you think?

Hi @Urigo, I could do that, just this week I'm very busy as this weekend I'll got to a startup weekend, so I have to get ahead on my regular job. After this weekend I'll be able to work on it having $meteor.object to user $meteor.collection.

Been a while since I looked closer at the code, but based on what I remember and a quick glance at the source I think reusing diffArray shouldn't be too hard, maybe we can just expose any internal methods that we need to make a diff for $meteor.object specifically

@auterium have you had further thoughts on that?

Hey @Urigo, here are some thoughts:

Make all items within $meteor.collection to be instances of SubObject
Rename all SubObject's methods to start with $ to avoid property collitions
$meteor.object would internally call $meteor.collection and return the first item only

Let me know what you think and if we agree I'll do the code.

@auterium I'm not sure exactly about the first 2 points, can you share an example?

Ok, so right now when you use $meteor.object, you get an instance of SubObject, which has the getRawObject, save, reset, etc methods, so basically $meteor.collection would do the same for each object in the array.
For the second point, though is not that common, but let's say that for some reson you want to have a boolean property called reset, which common sense would say to use allowReset or isReset, but I'm too lazy to do that, so I just want to call it reset. There I'll have a name collision with the property and the method, while if the method to reset the object would be called $reset, then there would be no collision as mongo doesn't allow property names to start with $. Another use case would be that I need to store JSON objects that come from an external source (i.e. 3rd party website) where I have no control of the property names and if any of those properties are named save, reset, etc, I'll have to create a converter or always be using getRawObject and in both cases completely forget about the autosave option.
Hope I made myself clear and didn't confused you more lol

@auterium yes that's very smart.
My worry is about performance on the collection.  do you think it will affect?
Maybe we can think of a way to make it an object only on demand?

I had my worries about performance too, so I was thinking that that could be an option when calling $meteor.collection which by default would be false. Here's a proposed signature:
$meteor.collection(collection, [autoClientSave, [updateCollection, [returnSubObject]]])
I'm not very fan of adding lots of arguments to methods, so this is something I would like more:
$meteor.collection(collection, [autoClientSave|options])
Where if the second arg is an object, then it's treated as an options object, if it's a boolean then it's for autoClientSave, and otherwise it throws an error.
A third option would be to have sort of 2 signatures, where if the second argument is an object, then it's used as an options object and otherwise it keeps workin as it is right now, to avoid breaking existing functionality.

@auterium I like the options parameter, that's really nice and also follows Meteor's conversions (kind of like Mongo..)
My thinking was (not sure) to maybe at the beginning just to return the object with the functions just when calling $meteorObject (without changing collection itself)
but I'm not sure if it's possible with the implementation and just saw that as a first step.
What do you think?

@Urigo, sorry for the late response, I've been very busy lately. I checked the source code and found that adding SubObject support for $meteorCollection is not a straight-forward thing to do, so I think that for now the way to go will be to make $meteorObject depend on $meteorCollection and use it.

ok sounds good.
thank you so much for your efforts and time!

@cnelson711 can you test again against the latest changes in master?

See this commit, soon to be merged

Fixed in 1.0.0-rc.5


Issue with Yarn startup for project

Hello!
I am having some trouble running yarn and getting set up for this project. My goal is to be able to at least run this locally and I keep getting the following errors:
find VS - missing any windows sdk

I was curious on the dependency for the windows sdk, is this a critical dependency for the react-spa? or is this something that I can potentially remove?
Any information would be appreciated, Thanks!

Update, I've decided to create a larger fork as there just were too many dependencies that didn't work for me as well as the use-case I want to support relies on locally provided schema files. I believe this issue can be closed, but just wanted to make sure I had your blessing on the fork. I've provided what I believe is all the correct attributions per the License requirement.
I see that the Apache license applies, but also in the package.json I see the MIT license.
Let me know if I need to update anything for my fork of this. Thanks again, great product and great work :D


frida.InvalidOperationError: script is destroyed

Hades:frida-ipa-dump-master Hades$ python3 dump.py com.tencent.xin
[info] attaching to target
[info] decrypting module WeChat
[info] decrypting module TXLiteAVSDK_Smart_No_VOD
[info] decrypting module WCDB
[info] decrypting module MMCommon
[info] decrypting module MultiMedia
[info] decrypting module QMapKit
[info] decrypting module mars
Traceback (most recent call last):
 File "dump.py", line 175, in <module>
   main()
 File "dump.py", line 172, in main
   dump(args.app, args.device, args.verbose)
 File "dump.py", line 43, in dump
   task.run()
 File "dump.py", line 158, in run
   self.inject()
 File "dump.py", line 153, in inject
   script.exports.dump()
 File "/usr/local/lib/python3.6/site-packages/frida/core.py", line 442, in method
   return script._rpc_request('call', js_name, args)
 File "/usr/local/lib/python3.6/site-packages/frida/core.py", line 372, in _rpc_request
   raise result[2]
frida.InvalidOperationError: script is destroyed

Start the app first then retry, if you keep seeing this.

This is due to the stability of app itself or some unknown crash of frida framework

thank you!


fix: Removed docker provider block from docker-build submodule

Fixed #267

This PR is included in version 3.2.1 :tada:


[Support] ls-crypt unwrap error: packet too short

In raising this issue, I confirm the following:
{please fill the checkboxes, e.g: [X]}

[] I have read and understood the contributors guide.
[] The issue I am reporting can be replicated.
[] The issue I am reporting can be is directly related to the pivpn installer script.
[] The issue I am reporting isn't a duplicate (see FAQs, closed issues, and open issues).

Issue
Have you searched for similar issues and solutions?
(yes/no / which issues?)

Console output of      curl -L install.pivpn.dev | bash
  Output Here

Console output of      pivpn add or pivpn add nopass
  Output Here

Console output of      pivpn debug
  Output Here

Have you taken any steps towards solving your issue?
  which?

I had to reinstall PiVPN on my Pi 4 and now I keep getting the following error: ls-crypt unwrap error: packet too short. Can anyone tell me how I can correct this?

Closing as not following the issue template you are presented with when opening a new issue, reopen when you have filled the relevant parts.


Lazy loading from another host

🚀 Feature Proposal
Allow to load JavaScript chunks from another domain.
Motivation
Let's say, in development, we have two services:

[front] A webpack dev server, which generate JS bundles
[back] A web server, which runs the API and the SSR for the app

For the same app, say that the production will run both frontend and backend on the same host.
Example
An idea would be to have a loadable config somewhere at the app start:
import { setConfig } from '@loadable/component';

setConfig({ host: REACT_APP_BASE_URL });

This config would prefix the host before each lazy import, from the frontend or from the SSR part.
Pitch
It happens quite often that the service responsible to the SSR is different from the frontend management (like a CDN for example)
A config key would make loadable even more awesome!

See https://webpack.js.org/guides/public-path/ - it could be configured in runtime.

Ah, you're right!
Thank you very much.
And thank you for making code splitting so simple :muscle:


Support ingress to app running in k3d on macOS

An acorn app deployed to k3d:
$ acorn app
NAME            IMAGE          HEALTHY   UP-TO-DATE   CREATED   ENDPOINTS                                                       MESSAGE
awesome-acorn   832d8f10698f   3         3            46s ago   http://app.awesome-acorn.192iu1.alpha.on-acorn.io => app:5000   OK

$ kubectl get service -n awesome-acorn-6fe36cda-a4c app
NAME   TYPE        CLUSTER-IP     EXTERNAL-IP   PORT(S)    AGE
app    ClusterIP   <IP_ADDRESS>   <none>        5000/TCP   12m

$ kubectl get ingress -n awesome-acorn-6fe36cda-a4c
NAMESPACE                    NAME   CLASS    HOSTS                                        ADDRESS      PORTS   AGE
awesome-acorn-6fe36cda-a4c   app    <none>   app.awesome-acorn.192iu1.alpha.on-acorn.io   <IP_ADDRESS>   80      8m33s

ie: app.awesome-acorn.192iu1.alpha.on-acorn.io => <IP_ADDRESS>
However this is not routable from the macOS host.

@iwilltry42 do you know some trick here? I believe there's some port-forwarding that needs setup or something?

actually, i got this working awhile ago. Required a little extra setup around port proxying. I'l try to spin it up again and let you know what you need

@tekumara can you share the command you used to spin up your k3d cluster?

So, there was a convoluted way to get it to work as-is, but it kind of sucked. So, I have a PR to make this better:
https://github.com/acorn-io/acorn/pull/576

I used k3d cluster create acorn -p 8000:80@loadbalancer.
When I need access from the host to a service running in the k3d cluster, I've had to either:

create an IngressRoute for the service inside the cluster, or
create a Service with type LoadBalancer

K3d will now use the "local.on-acorn.io" address and we've updated the docs on what you need to do to properly setup port forwarding:
https://docs.acorn.io/installation/installing#local-development-clusters


test against both 0.4 and 0.5 on travis

release means 0.5, but according to REQUIRE 0.4 is still supported
so should still be tested

I tested this in my fork and turns out the tests do fail on 0.4 with the current source and test script. I'll change REQUIRE to 0.5, open a new issue to track 0.4 compatibility, and merge this after that's resolved. Thanks for the heads-up!

I'll close for now then, I think it'll allow you to reopen later if you want?

Yes, I can reopen it later. Indeed it makes sense not to keep an open PR cluttering your https://github.com/pulls listing for an indeterminate period of time.

It's also a trivial enough change that I don't mind if you do it, the authorship attribution isn't a big deal for tiny stuff like this.


[distributed KafkaChannel] Kafka AdminClient Error Handling

Fixes #774
Handle Kafka AdminClient failures by requeuing the KafkaChannel instead of panic/crashing.  Note... KafkaChannel will remain in perpetual reconcile/finalize loop until underlying Kafka connection issue is resolved.  If the user is intending to delete a KafkaChannel instance whose backing Kafka cluster has been torn down, they will need to manually remove the Finalizer from the KafkaChannel to escape this loop.  This is as intended ; )
Proposed Changes
-🐛  Throw and handle Kafka AdminClient creation error instead of just logging error and continuing until NPE occurs.

/retest

/lgtm


Clean freescout installation is out of date

Summary
Clean install of freescout is version 1.7.20 and updating seems to be impossible due to PHP 8
Steps to reproduce
Do a clean install
What is the expected correct behavior?
Latest version of Freescout
Relevant logs and/or screenshots
My docker-compose.yml
version: '2'

services:

  freescout-app:
    image: tiredofit/freescout
    container_name: freescout-app
    links:
    - freescout-db
    volumes:
    ### If you want to perform customizations to the source and have access to it, then uncomment this line - This includes modules
    #- ./data:/www/html
    ### Or, if you just want to use Stock Freescout and hold onto persistent files like cache and session use this, one or the other.
    - ./data:/data
    ### If you want to just keep the original source and add additional modules uncomment this line
    - ./modules:/www/html/Modules
    - ./logs/:/www/logs
    environment:
    - CONTAINER_NAME=freescout-app
    - DB_HOST=######
    - DB_NAME=######
    - DB_USER=######
    - DB_PASS=######
    - SITE_URL=######
    - ADMIN_EMAIL=######
    - ADMIN_PASS=######
    - ENABLE_SSL_PROXY=TRUE
    - DISPLAY_ERRORS=FALSE
    - TIMEZONE=Europe/Amsterdam
    labels:
      - "traefik.http.routers.freescout.rule=Host(`######`)"
      - "traefik.http.routers.freescout.tls=true"
      - "traefik.http.routers.freescout.tls.certresolver=lets-encrypt"
      - "traefik.http.services.freescout.loadbalancer.server.port=80"
      - "traefik.docker.network=web"
    networks:
      - web
      - internal
    restart: always

  freescout-db:
    image: tiredofit/mariadb
    container_name: freescout-db
    volumes:
      - ./db:/var/lib/mysql
    environment:
      - ROOT_PASS=######
      - DB_NAME=######
      - DB_USER=######
      - DB_PASS=######

      - CONTAINER_NAME=freescout-db
    networks:
      - internal
    restart: always
    labels:
      - traefik.enable=false

networks:
 web:
  external: true
 internal:
  external: false

Environment

Image version / tag:  see the compose
Host OS: Docker

Possible fixes
Update freescout to the latest version in the image (?)

Doesn't sound right to me - Try using a tagged release, or matching up the image hash on docker hub vs the one on your system to see which version you actually have. The example shows pulling from :latest which has been updated in the past 2 weeks..

Jup that was it. Totally my bad sorry.


Angular application Signin Redirect fails with “invalid_grant” error when running on different machine than the IDP

Here is the Stackoverflow question: https://stackoverflow.com/questions/66687890/angular-application-signin-redirect-fails-with-invalid-grant-error-when-runnin
I will paste the entire question in here aswell.
I am using oidc-client with Angular to log in to my identity server. When running both applications on the same machine everything works perfectly.
However when I run my Identity Server on a Web Apps server and my Angular Application on a Static Web App I get an error "invalid_grant".
PROBLEM DESCRIPTION

User clicks on Login button and gets redirected to the login screen of Identity Server
User enters Password and Username and clicks Log In
Identity Server redirects to the "signin-callback" link and I get the blank signin-callback page because signin callback is only a .ts script
This URL appears in the header: https://white-wave-0ca3e8803.azurestaticapps.net/signin-callback?code=l5-p3B5IGifAZ3ijIUgKmLl7aL2g45Fh5JLmluOj3NA&scope=openid profile&state=6503e1f5f176411a890ac50a4d0ecb84&session_state=aPnjQ5ZUiMCDKkAztm0O0K4quSkfSlWRZd--YuK73Oc.NVxBA5K6RH5_ptpDobxmxA

Under network we have a red "Token" error. Containing Response Header
HTTP/1.1 400 Bad Request
Cache-Control: no-store, no-cache, max-age=0
Pragma: no-cache
Content-Length: 25
Content-Type: application/json; charset=UTF-8
Server: Microsoft-IIS/10.0
Strict-Transport-Security: max-age=2592000
Access-Control-Allow-Origin: https://white-wave-0ca3e8803.azurestaticapps.net/dashboard X-Powered-By: ASP.NET
Set-Cookie: ARRAffinity=1fa22e5e18dd42b9d22d6c2c620b562f117da68736f4d32b741538a2d054d95c;Path=/;HttpOnly;Secure;Domain=hansecoreidp-staging.azurewebsites.net
Set-Cookie: ARRAffinitySameSite=1fa22e5e18dd42b9d22d6c2c620b562f117da68736f4d32b741538a2d054d95c;Path=/;HttpOnly;SameSite=None;Secure;Domain=hansecoreidp-staging.azurewebsites.net
Date: Thu, 18 Mar 2021 08:34:39 GMT

Error Message
{"error":"invalid_grant"}

When I refresh I get the error Error: Uncaught (in promise): Error: No matching state found in storage the local storage, session storage and cookies are empty.
When I delete the everything after my base URL https://white-wave-0ca3e8803.azurestaticapps.net, navigate to the base url and click login again, the login works and in the storage I all of a sudden have Cookie Storage A cookie containing AAR Affinity, etc from Identity server Session Storage I have the access_token, id_token, profile, scope, etc. Local Storage Authority, client_id, etc.

ASSUMPTION
I think the Angular application is having trouble storing the information from the signin-callback in the application storage.
IDENTITY SERVER CONFIGURATION CODE
public static IEnumerable<Client> StagingClients (IConfiguration configuration) =>
        new Client[]
        {
            new Client
            {
                ClientName = "HAnsecore.Web",
                ClientId = "clientid",
                AllowedGrantTypes = GrantTypes.Code,
                AccessTokenType = AccessTokenType.Jwt,
                RedirectUris = new List<string>{ "https://white-wave-0ca3e8803.azurestaticapps.net/signin-callback" },
                RequirePkce = true,
                AllowAccessTokensViaBrowser = true,
                AllowedScopes =
                {
                    IdentityServerConstants.StandardScopes.OpenId,
                    IdentityServerConstants.StandardScopes.Profile,
                    "hansecoreCQRSApi",
                    IdentityServerConstants.StandardScopes.OfflineAccess
                },
                AllowedCorsOrigins = { "https://white-wave-0ca3e8803.azurestaticapps.net" },
                AllowOfflineAccess = true,
                RequireClientSecret = false,
                PostLogoutRedirectUris = new List<string> { "https://white-wave-0ca3e8803.azurestaticapps.net/signout-callback" },
                RequireConsent = false,
                AccessTokenLifetime = 600
            }
        };

ANGULAR OIDC-CLIENT AUTH CONFIG CODE
private get idpSettings() : UserManagerSettings {
return {
  authority: environment.idpAuthority,
  client_id: environment.clientId,
  redirect_uri: `${environment.clientRoot}/signin-callback`,
  scope: "openid profile hansecoreCQRSApi offline_access",
  response_type: "code",

  post_logout_redirect_uri: `${environment.clientRoot}/signout-callback`
}
}

SIGNIN REDIRECT CALLBACK CODE User Manager is an inherited class from oidc-client. When debugging the code does not enter the .then and I can't debug any further than here. But I think whatever happens after this is where the code fails.
public finishLogin = (): Promise<User> => {
return this._userManager.signinRedirectCallback()
.then(user => {
  this._loginChangedSubject.next(this.checkUser(user));
  return user;
})
}

SIGNIN CALLBACK CODE
import { Component, OnInit } from '@angular/core';
import { Router } from '@angular/router';
import { AuthService } from '../../../core/services/auth.service';

@Component({
  selector: 'app-signin-redirect-callback',
  template: `<div></div>`
})
export class SigninRedirectCallbackComponent implements OnInit {

  constructor(private _authService: AuthService, private _router: Router) { }
  ngOnInit(): void {
    this._authService.finishLogin()
    .then(_ => {
      this._router.navigate(['/'], { replaceUrl: true });
    })
  }

}

NETWORK PICTURE Network traffic on fail

If theres anything missing in my question at all please let me know.
EVNIRONMENT FILE
export const environment = {
  environmentName: 'STAGE',
  production: false,
  apiRoot: 'https://hansecoreapi-staging.azurewebsites.net/api/',
  clientRoot: 'https://white-wave-0ca3e8803.azurestaticapps.net',
  idpAuthority: 'https://hansecoreidp-staging.azurewebsites.net',
  clientId: '54212148-15C1-40F9-BA07-E3CE748A7C7F'
};

If it gets to the point where it makes the token request, then everything is fine in the client from oidc-client-js's perspective. Invalid grant means the code is invalid, but you'd need to check your token server logs. Refreshing the page will trigger invalid state error, because the state that was holding the prior request's data was consumed.

Hey brock! Thanks for answering. I Can't get Identity Server to Log to Azure Log Stream with the Default Identity Server 4 settings, do you have any hints on what I should be doing? My code looks identical to this http://docs.identityserver.io/en/latest/topics/logging.html, in the mean while I am going to look at the deployment documentation for Identity Server 4 see if there's a solution there.

I believe we are also having this issue. @ARM-Source is this issue for every user or only specific users?

Hi rob! Its for every user on dev, staging and production environments. My workaround is to switch to the Implicit flow. With me it also seemed to be that the code was to long for the URL, although I cannot say for certain. https://github.com/IdentityModel/oidc-client-js/issues/1320


Add support for country_select v9. Fixes #1381

The country_select v2 syntax was introduced in August 2014.
Now, 10 years and 7 major versions later, the project dropped support for v1 syntax starting with v9.
This change adapts formtastic to the new method signature, removes all claims that it supports v1 syntax, and updates the URLs to the new home under a new maintainer.

Looks great! 🙂

I think this is waiting on #1372. Let me know when anything needs to be amended.

@justinfrench

Sorry @leoarnold, thanks for the nudge. I’m finding it very difficult to keep up with maintenance on this gem, as I no longer use it or even work regularly with Ruby.
Since there are no  co flicks and the diff is straightforward I will merge this, but I have no timeline for another release sorry.

@justinfrench No problem, I kinda got that from context. I think you should state that at the top of the README as well (or even archive the project?) so passers-by come with the right expectation.


No working on ios 11

App stucks on launch screen without errors.
It is working progrmatically but not with storyboard

I don't want to update to ios 11) When do this, than would be a fix.

Yes, you can get it by
outputLabel.text = topTextField.currentSelectedCountry?.countryCode


style: linting, organize

What did you fix?

set up linting
set up simple test
add pre-commit verification

Reproduction steps

Evidence/screenshot/link to line

Considerations

Does this contain a new dependency? [Yes]
Does this introduce opinionated data formatting or manual data entry? [No]
Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? [Yes]
Have I run the linter? [Yes]
Is is a bug fix, feature request, or enhancement? [Feature]

i still don't like how our types get exported, but such is life until i find a better way...

i still don't like how our types get exported, but such is life until i find a better way...

How would you like them to be exported?

i still don't like how our types get exported, but such is life until i find a better way...

How would you like them to be exported?

With the module namespace, and not with classes, interfaces, and types mixed

I also suggest to remove all the comments in tsconfig.json and just leave what it's using.

@Soundofdarkness this cool with you? I was leaving them since you had.

With the module namespace, and not with classes, interfaces, and types mixed

That would change the build process, better leave that to another PR. Also i'm not sure if it would be easy to do it like that, need to do some research.

@TobiTenno
Could you add .gitattributes like this:
*.js text eol=lf
*.ts text eol=lf

It's a nice to have for windows developers. As it by default messes all files with CRLF.

@TobiTenno Could you add .gitattributes more or less like this:
*.js text eol=lf
*.ts text eol=lf

It's a nice to have for windows developers. By default, windows git clone all files with CRLF. But maybe it wouldn't be fit for this PR?

it's already enforced via eslint, but i can

Sorry for the late response.
I'm fine with the remove of the comments in the tsconfig, I just left them to find settings faster.
The exports seem okay to me like that too, but I'm not sure if they are more clear with the default+named export.
With the branch we can have something like main too if that's better, that name was just used by the now 0.1x branch before the migration.
Aside from that looks good to me 😄

personally, i think keeping development is fine. i'll go get those comments cleaned up

but I'm not sure if they are more clear with the default+named export.

You mean in the VersionManager.ts and in the Generator.ts?

but I'm not sure if they are more clear with the default+named export.

You mean in the VersionManager.ts and in the Generator.ts?

Yup, in those two files. I can see why it can be better, I've just never seen that pattern anywhere, so I'm not sure if maybe IDE support or something can be funky with it or similar.

Yup, in those two files. I can see why it can be better, I've just never seen that pattern anywhere, so I'm not sure if maybe IDE support or something can be funky with it or similar.

So far i haven't experienced something similar, i think in this it's not necessary to have it. I'll  remove it then.

You don’t have to, so far I have no indication that it doesn’t work, I was just confused that I haven’t seen it before. Sorry that I wasn’t more clear with this.

Actually i won't because eslint is configured with a rule that when a module only has one named export it must use a default one instead.

Yup, that should work then !


cannot start lsp in neovim because cannot find version?

Swift version
Swift version 6.0.3 (swift-6.0.3-RELEASE) Target: aarch64-unknown-linux-android24
Platform
android termux
Editor
neovim v0.10.2
Description

errror message

   Warn  07:30:55 notify.warn Client sourcekit quit with exit code 0 and signal 11. Check log for errors: /data/data/com.termux/files/home/.local/state/nvim/lsp.log

lsplog:
no any errror messages

lspinfo:

LSP configs active in this buffer (bufnr: 103) ~
- Language client log: ~/.local/state/nvim/lsp.log
- Detected filetype: `swift`
- 0 client(s) attached to this buffer
- Other clients that match the "swift" filetype:
- Config: sourcekit
  filetypes:         swift, objc, objcpp, c, cpp
  cmd:               /data/data/com.termux/files/usr/bin/sourcekit-lsp
  version:           `OVERVIEW: Language Server Protocol implementation for Swift and C-based languag…` (Failed to get version) Tried:
  `/data/data/com.termux/files/usr/bin/sourcekit-lsp --version`
  `/data/data/com.termux/files/usr/bin/sourcekit-lsp -version`
  `/data/data/com.termux/files/usr/bin/sourcekit-lsp version`
  `/data/data/com.termux/files/usr/bin/sourcekit-lsp --help`

  executable:        true
  autostart:         true

Steps to Reproduce
No response
Logging
No response

Synced to Apple’s issue tracker as rdar://141716848

Looks like sourcekit-lsp is crashing with a segmentation fault (signal 11). It trying to print the version seems to be unrelated.
A couple questions to help us triage this issue:

Are you seeing this issue when opening any project in SourceKit-LSP or only with one specific project? If so, would you be able to attach that project?
It look like you’re running sourcekit-lsp on Android. Are you seeing the crash on other platforms except for Android?
I am not familiar with Android development. Would you be able to get a stack trace for the crash, eg. by attaching a debugger to sourcekit-lsp before it crashes?


Extending a template doesn't seem to work if any YAML is used outside a few

I'm playing around with moving our custom build scripts into a single template that existing builds can extend instead of every project having a series of YAML steps to perform. I took this YAML
resources:
   …

trigger:
   batch: true
   branches:
      include:
      - master

pool:
   vmImage: windows-latest

steps:
- template: yaml/build/initialize-build-variables.yml@templates

I want to replace everything after the trigger by using extends so I created a new YAML file in my build tools repo and copied everything from pool on into it. Then I modified the source repo's build to look like this.
resources:
   …

trigger:
   batch: true
   branches:
      include:
      - master

extends:
   template: yaml/main-build.yml@templates

When the build is run it says pool is unexpected. This is referring to the element in my template I wanted to extend. So I assumed that you couldn't put pool inside the template so I moved it back to the source repo.
resources:
   …

trigger:
   batch: true
   branches:
      include:
      - master

pool:
   vmImage: windows-latest

extends:
   template: yaml/main-build.yml@templates

I get the same error. So using pool before extends doesn't work. So I tried moving it after.
resources:
   …

trigger:
   batch: true
   branches:
      include:
      - master

extends:
   template: yaml/main-build.yml@templates

pool:
   vmImage: windows-latest

This says extends is unexpected now. It doesn't seem like extends can be used with anything other than maybe resources and triggers. What are the rules around where extends can be used and what can go into it? At this point I don't see any place where I can put pool and so I cannot see how I can use this in a build.

Any new info on this? I'm trying to do the same thing and I too get the Unexpected value 'extends' error.

@CoolDadTx I've been able to fix my pipeline templates by moving the pool entry to each stage definition instead of having it in the root yaml file.
@beatcracker haven't tried with pr, though.

Echoing everyone else, also have this problem, with pools and container resources as well.

extends currently requires an explicit jobs: or stages: wrapper even in the case of a single job. We are looking into whether we can relax this restriction to be more in line with how non-extends pipelines can be written. (See below for some history.) The two rules are:

If a pipeline contains extends, then only trigger, pr, schedule, and resources can appear at the top level alongside extends.
If a pipeline template will be the target of extends, then it must have at least a jobs level specified.

Taking the example from the top of this issue:
resources:
   …

trigger:
   batch: true
   branches:
      include:
      - master

pool:
   vmImage: windows-latest

steps:
- template: yaml/build/initialize-build-variables.yml@templates

You'd have to write that as:
# azure-pipelines.yml
resources:
   …

trigger:
  batch: true
  branches:
    include:
    - master

extends:
  template: yaml/main-build.yml@templates

# yaml/main-build.yml
jobs:
- job:
  pool:
    vmImage: windows-latest

  steps:
  - ...

In case you're interested in the history, we introduced "level elision" very early on. The thinking was, it would make YAML pipelines more approachable. If you only have a single job, why bother with the boilerplate of "jobs:" and "job:"? In practice, this has mostly led to confusion for users and complication every time we add language features. If I had a time machine, I'd go back and remove level elision. Notably, GitHub Actions (designed by some of the same people who designed Azure Pipelines YAML) doesn't allow for level elision, and it hasn't been a problem.
In the case of extends, we didn't complete all the necessary refactoring to make bare-single-jobs work as an extends target. We believed that extends would not commonly be used for single-job pipelines, and thus it would be wasted effort and increased risk of introducing bugs. But this feedback makes it clear that we were wrong, and we'll get an item on the backlog to bring it to parity.

@vtbassmatt thanks for the information. This makes sense.
If the level elision is causing so much problems then why not deprecate it? It is a breaking change but it wouldn't be the first time. Maybe also consider supporting newer features only with the larger syntax and then displaying a nice error when someone tries to use the new features with the simplified syntax. With YAML the biggest pain point for me has always been figuring out why it doesn't like something.

Is it possible to extend a template from a different project / repository?  I added the resource in the pipeline yaml file, but then since the other repository resource has not been checked out, the template cannot be found.  This template also loads Variable groups and has logic to introduce other global variables.
We are trying to separate pipelines from Developer owned repositories, and not starting triggers from the same repository as is being checked in has proven to be a real bear.  This would seem like the logical method for separation, but does not seem to work.
There are a number of issues also with having the pipelines in an alternate repo, then triggered through a resource in that separate pipeline file.  So many bugs having to do with Build.xxx variables has rendered using that method completely unusable.
`
parameters:
blah: blah
...
resources:
repositories:
- repository: self
type: git
name: Payer Products/QES
trigger:
- development
# - integration
- master
- devops/*
- repository: IAC
  type: git
  name: DevOps/IAC
  ref: master
  trigger:
  - none

schedules:

cron: "0 8 * * *"
displayName: Nightly build
branches:
include:

master

extends:
template: /pipelines/QES/V1/build.deploy.omnius10.yml
parameters:
environment: ${{ parameters.environment }}
branch: ${{ parameters.branch }}
alternateBranch: ${{ parameters.alternateBranch }}
deploy: ${{ parameters.deploy }}
vnet: ${{ parameters.vnet }}
`

If a pipeline contains extends, then only trigger, pr, schedule, and resources can appear at the top level alongside extends.

Were the facts mentioned here and in https://developercommunity.visualstudio.com/t/Unexpected-value-pool-when-extending-a/992713?space=21&q=directory+separator&entry=myfeedback never added into documentation?

Bad Microsoft code example. I followed the code in this Microsoft example: https://docs.microsoft.com/en-us/azure/devops/pipelines/security/templates?view=azure-devops-2020#type-safe-parameters
Which didn't work - gave me the "Unexpected value 'pool' " error - which searching the web brought me to this issue.


Unity LTS

Please provide a unity 2019 LTS version  for github action

Hi @ZhouJiaZhi
Thank you for your request.
You can use all unity LTS versions as far as I know. Not sure what you're asking exactly. Could you please elaborate?

@webbertakken

In your .github/workflow/main.yml I saw unity version is not unity2019 LTS
I think to upload my account and password to Github have safety risks

@webbertakken
And I want to maintain a unity-action copy in my own repo, could you provide some advice including but not limited to:
1.deploy to docker
2.What configuration items do I need to modify in .*yml file at least

@webbertakken
I use personally licence, but I do not know  what is the value of UNITY_LICENSE, where could I find the value

Hi @ZhouJiaZhi, let me try to answer your questions;

@webbertakken

In your .github/workflow/main.yml I saw unity version is not unity2019 LTS
I think to upload my account and password to Github have safety risks

Correct, that workflow is just to test the action itself, you should refer to the readme to find out how to get started.
To use your account name or password in plain text has major security risks. This is what secrets are for, the output should always be masked by GitHub. The username and password are required to activate unity professional licenses and there is no way around this as far as I know.

@webbertakken
And I want to maintain a unity-action copy in my own repo, could you provide some advice including but not limited to:
1.deploy to docker
2.What configuration items do I need to modify in .*yml file at least

Note that this action never deploys anything to docker, instead the local docker image is used, based on the Dockerfile.
I made this action open source so that other people do not need to reinvent the wheel. The idea that this action covers all major use cases so that we can create a community that can help each other when actual problems occur. That said; Actions are always open source and you're free to create a fork of this project. All the code is provided under MIT license, feel free to take what you need, but I would recommend starting off with just making a clone. You can find all documentation on how to create and maintain an Action in GitHub's official docs.

@webbertakken
I use personally licence, but I do not know what is the value of UNITY_LICENSE, where could I find the value

You may refer to the Unity Actions docs. It'll take you through the process of setting up your workflow.

@webbertakken
I used the method in the manual but failed , Do you know how to solve it


CROS-22: add comment to ts for Supply/Retreive checking

maybe the test cases need adjust? as we do not have checking in ts, so ts cannot figure out the issue. However, maybe need wait for circom/substrate node finish the scenario tests adjusting and then do the adjust

@yymone Yes, I will adjust test cases after circom/substrate node finsh the scenario tests.

@yymone I modified case6.json according to description in CROS-17.


When updating settings, flash message is non-obvious

Steps to reproduce:

Go to /settings
Update your email address
Nothing will seem to happen. It's only if you scroll to the top of the settings that you'll notice a confirmation flash message.

Screenshot:

This should be changed from a flash to a notification.
Note: flashes should be used for communications between a user and the backend (usually a fresh pageload is happening, but not always). We can also categorize notifications that need to be dismissed here.
Toasts for notifications to the user from the app that do not need to be dismissed.

I looked into this issue, whenever user backend is updated a message is Toasted through makeToast() in update-user-epic.js by complete Observable, but for this to happen the payload passed to complete Observable should contain 'message' key so that message's value can be displayed. But when email is updated the payload passed contains 'info' instead of 'message' key  so the message object becomes undefined therefore no toast is shown.
I was able to fix it like this:
    const complete = actions$::ofType(types.updateUserBackend.complete)
    .flatMap(({ payload }) => {
      var message = payload.message || payload.info[0].split('\n').join(' ');
      return Observable.if(
          () => message.includes('project'),
          Observable.of(refetchChallengeMap(), makeToast({message: message})),
          Observable.of(makeToast({message: message}))
        );
      }

Screenshots:

Is this what was required? Have i done it correctly? If so i would like to open a PR.

@YogeshSharma0201 This looks good to me. Can you open a pull request? Then we can get code-specific feedback from @BerkeleyTrue.


Smarter selection of multi index export to xarray

Only automatically select multi index export if shapes are unset
Allow the user to select which export type to use

[ ] Tests?
[ ] Changelog

Testing plan

[ ] For a complete dataset on a grid without shapes set:  Test that multiindex is used iff always always selected
[ ] For a complete dataset on grid with shape: The same
[ ] For a incomplete dataset on grid with shape: The same
[ ] For a dataset not on a grid: muitiindex: test multi index triggered iff always or auto
[ ] For an incomplte dataset on a grid: test multi index triggered iff always or auto


[Untranslated]: Location - Moreau

Night

Translated the cat child. Should be in the next patch :)


raspi-config cannot select keyboard

Hi
as soon as I want to choose localization/keyboard there's an error message that disappears too fast to be read, and raspi-config returns to the main menu.
Any idea?

Thanks for sharing the solution. Closing this now.


add function GetExtPubKey to golang lib

also bumps ledger-go

Would it be problematic to switch the base branch to dev? Is it required for this change to be accessible downstream to be on the main branch? We usually merge to dev and merge everything back into main when a new release is cut

Would it be problematic to switch the base branch to dev? Is it required for this change to be accessible downstream to be on the main branch? We usually merge to dev and merge everything back into main when a new release is cut

we are going to include this change as a dependence to avalanchego main soon, from https://github.com/ava-labs/avalanchego/pull/2246 (now pointing to dev but avago release process is weekly based). So it is prefered to be
main I believe, but I imagine dev could be so, as dev is not a branch that is going to be deleted, or its commit.
So, up to you. Np.


Storage: add support get_service_account method

Feature request to add support for projects.serviceAccount
The request gets the GCS managed service account that is used by GCS PubSub notifications and CMEK to allow GCS to access to PubSub and a KMS key respectively.
Examples of existing implementations:

PHP
Java

Are you OK with the google-cloud-bigquery implementation?

The implementation lgtm as the surface for accessing the GCS managed service.
Thanks Chris!


Build Gradle failed

I am building this project for the first time on Android Studio 2.3.3 and gradle version 2.3.0. but project building fails with the Error
Error:(236, 0) No signature of method: java.io.File.plus() is applicable for argument types: (java.lang.String) values: [ not found. Skipping.]
Possible solutions: list(), list(java.io.FilenameFilter), is(java.lang.Object), split(groovy.lang.Closure), use([Ljava.lang.Object;), wait()

Please have a look at this issue's comment: https://github.com/edx/edx-app-android/issues/1062#issuecomment-366720223, it might help you guys in your case as well.
If it doesn't, re-open the issue and provide more details on the issue :)


No code with 1.0.1 release

I think there was a problem with your new build for v1.0.1.
When I try to run, I get an error of Serverless plugin "serverless-offline-watcher" not found...which makes sense because there is no dist folder in this version like there was in v.1.0.0?

1.0.1: https://www.npmjs.com/package/serverless-offline-watcher?activeTab=explore
1.0.0: https://www.npmjs.com/package/serverless-offline-watcher/v/1.0.0?activeTab=explore

Thanks for raising this! You're absolutely right, due to a packaging issue the dist folder has not been included.
I have now released v1.0.2 which should fix this issue. I've also unpublished v1.0.1 to try to prevent people downloading it and getting stuck :)


HTML and CSS servers should have meaningful default settings

At the moment vscode after CSS/HTML language server initialization is sending didChangeConfiguration notification to set correct settings. Its ok in general but if such notification wont be sent then some obvious functionalities wont work e.g. validation. I believe that after start the language server should have set of default settings that will enable most important features (without sending additional request). It will help to consume CSS/HTML language server by other clients.

Version 1.8.1
Commit ee428b0eead68bf0fb99ab5fdc4439be227b6281
Date 2016-12-19T14:41:20.664Z
Shell 1.4.6
Renderer 53.0.2785.143
Node 6.5.0

Added changes to the css and html language service to enable validation unless explicitly disabled.


Remove release badge, as it doesn't track the actual highest release

NetflixOSS » Hystrix » Hystrix-pull-requests #423 SUCCESS
This pull request looks good


2019 VR equipment selection

Mainly for fun, but I kind of get a touch for VR tool (well, finally).
Requirement:

Connectivity with other tools I have, namely Android and/or Ubuntu.
Compatibility with Robotics tool, particularly ROS.

Oculus already has Gazebo integration.

Many games and fun apps will be nice.
What else?

Looks like Google's Daydream is going out of the way.


fix actions_MED_LocPref_prepend_flow_control_test.go for cisco

fix actions_MED_LocPref_prepend_flow_control_test.go for cisco

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls


Update MockMicrogrid for use with datasourcing benchmark

Extends the mock microgrid with features required for the datasourcing actor
benchmark which will be added in a later PR

Add num_values to have a configurable amount of iterations
MockMicrogrid: Make it work outside of pytest as well
Add start_mock_client method

mypy -p frequenz.sdk yields a loooot of errors, as far as I can tell most of them not in my changes.

I added the comment and rebased, but the mypy command request seems difficult to fullfill. I guess I'll wait for lucas PR then :)


feat: allow settings even when the daemon is offline

This closes #1019 by allowing the Settings page even when IPFS config is not available, or the daemon is offline. It might be useful because the settings page contains much more than IPFS own settings.

License: MIT
Signed-off-by: Henrique Dias<EMAIL_ADDRESS>

I know I shouldn't force push, but I did :O Just trying to trigger the CI with the latest updates. For some reason the tests pass locally but weren't passing in the CI.

@hacdias you should be able to re-trigger the build via the circle-ci web interface. let me know if that's not the case

@olizilla it says I don't have write permissions, which is weird. I believe I could trigger builds before. It passes now though 😄


error_on_unformatted doesn't actually make cargo fmt exit with non-zero

I tried this command in my repo.
$ cargo fmt --all -- --check --config unstable_features=true --config error_on_unformatted=true
error[internal]: not formatted because a comment would be lost
  --> /home/path/redacted/mod.rs:55
   |
92 |                 match rp.kind {
   |
   = note: set `error_on_unformatted = false` to suppress the warning against comments or string literals

warning: rustfmt has failed to format. See previous 1 errors.

I expected the command to exit with a non-zero status code to make sure it fails on CI, but it didn't. I suppose it's because the error[internal] is not actually an error, but a warning or smth like a non-failing error? I think this is a bug.
Versions
This behavior reproduces both on stable 1.74.0 and on nightly:
$cargo +nightly fmt --version
rustfmt 1.7.0-nightly (190f4c9 2024-01-09)
$ cargo +nightly --version
cargo 1.77.0-nightly (2ce45605d 2024-01-04)

References
Tracking issue reference: https://github.com/rust-lang/rustfmt/issues/3392

I ran into this same issue, a temporary workaround is to check if the stderr is non-empty


Expose base64_internal() and base32_internal() for custom encoding schemes?

Yes, custom alphabets would be great!


Support profiling for keda components

Provide a description of what has been changed
Checklist

[x] When introducing a new scaler, I agree with the scaling governance policy
[x] I have verified that my change is according to the deprecations & breaking changes policy
[ ] Tests have been added
[x] Changelog has been updated and is aligned with our changelog requirements
[x] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[x] A PR is opened to update the documentation on (repo) (if applicable)
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

Relates to #4789

/run-e2e internal

Hey @zroubalik can you please inform me what is missing in all of the PRs I opened (kedacore/charts#549, kedacore/keda-docs#1250, #5091 ) in order to merge everything?

Hey @zroubalik can you please inform me what is missing in all of the PRs I opened (kedacore/charts#549, kedacore/keda-docs#1250, #5091 ) in order to merge everything?

@yuvalweber The e2e tests are failing, can you please check?

/run-e2e internal Update: You can check the progress here

/run-e2e internal

Hey @tomkerkhove can you help me a bit?
I looked at the errors and I see things failing because it's trying to create resources on namespaces that being terminated or something with rate limit, can you please help me figure out if it's related to my change (cause it shouldn't)?

Hey @tomkerkhove would love for also update on this

/run-e2e internal

Hey @tomkerkhove can you help me a bit? I looked at the errors and I see things failing because it's trying to create resources on namespaces that being terminated or something with rate limit, can you please help me figure out if it's related to my change (cause it shouldn't)?

Env problem, the re-run passed 🚀

Hey @zroubalik do I need to write test?
Sorry i'm just not familiar with writing tests in golang and not sure if necessary in this situation

Hey @zroubalik do I need to write test? Sorry i'm just not familiar with writing tests in golang and not sure if necessary in this situation

@yuvalweber I don't think tests are needed for this kind of feature. On the other hand a short blogpost on how you used this profiler would be awesome 😃

Would love to do it 😄 .
Can you share example of blogpost so I could see the format and know how to copy it?
I could share the example related to the issue I had before #4687

Would love to do it 😄 . Can you share example of blogpost so I could see the format and know how to copy it? I could share the example related to the issue I had before #4687

DM me on slack :)

Hey @zroubalik need you to rerun the e2e tests.
I wanted to merge PR and rebase but accidentally just updated by branch which triggered this new requirement for this test

Hey @zroubalik can you just help me understand why it won't let me merge this?

Hey @zroubalik can you just help me understand why it won't let me merge this?

Only maitiainers can merge the PR, we usually do that once all PRs (feature/charts/docs) are ready.

Alright so when @tomkerkhove will finish reviewing my changes I'll be happy to merge.
Meanwhile I'll work on the blogpost

Alright so when @tomkerkhove will finish reviewing my changes I'll be happy to merge. Meanwhile I'll work on the blogpost

You don't have to do anything on the PRs (only additional fixes requested by reviews). We will handle the rest

I think I addressed to all of the requests you guys reviewed but if I missed something please let me know 😄


ClickHouse 3970: Add setting min_merge_bytes_to_use_direct_io

Hack in code :(. But changes are very small. The only good solution is to split MergeTreeBlockInputStream, as said in comment https://github.com/yandex/ClickHouse/blob/master/dbms/src/Storages/MergeTree/MergeTreeBlockInputStream.h#L15.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Ok.

Hack in code :(. But changes are very small. The only good solution is to split MergeTreeBlockInputStream, as said in comment https://github.com/yandex/ClickHouse/blob/master/dbms/src/Storages/MergeTree/MergeTreeBlockInputStream.h#L15.

Note that the methods createReadBufferFromFileBase and createWriteBufferFromFileBase accept both estimated_size and aio_threshold as parameters, with the only purpose to do simple comparison.
I think, it will be better to pass just single parameter named use_direct_io, and move all logic with thresholds outside.