Add old EOL versions of node

Is your feature request related to a problem? Please describe.
A number of node projects in the ecosystem have specified engine support for very old versions of Node. To help champion setting a new minimum, wanted to be able to specify the EOL of the particular version.
Describe the solution you'd like
Go to https://endoflife.date/nodejs and see all old versions, not just those actively maintained, similar to how https://endoflife.date/python or https://endoflife.date/php work.
Describe alternatives you've considered
Go to https://endoflife.software/programming-languages/server-side-scripting/nodejs instead.
Additional context
Looking through the Git history of the nodejs page, it looks like v8 was at least there, but it was removed at some point. It's not clear why that is. I think v13 might have been as well?

I'm happy to look to add these back, but not really sure why they were removed in the first place so not really sure if a PR would be accepted, hence opening an issue first.

13 and 8 were removed in https://github.com/endoflife-date/endoflife.date/commit/f3cf737e2a92d9914eaf5693530f09fef7bf3082#diff-252b7c5f491ceacafa0a6744a80913e26befedc4461b3d019af0eab91ddd2db0
Not done in a PR, and no reason given. Maybe @BiNZGi remembers?
I find it useful having the EOL Python ones so I can link to it when suggesting dropping them from projects.

My only guess would be to keep it inline with that's shown on https://nodejs.org/en/about/releases/?

#50 should be done in a few days, would appreciate a PR adding older Nodejs releases.

We're now covering 8-latest, so closing this.
https://github.com/nodejs/Release covers the older ones as well if someone would like to add them.


Patch | Use placeholder in version

What?

Use placeholder for version in __init__.py instead of keeping it updated.

Why?

Version number is determined during packaging and tags are applied accordingly to the code. It's not necessary to keep an updated version of such number in the repository itself.
It simplifies release process with no downside.

Nice optimization @angelofenoglio thanks!


Consider changing default theme to material design

I'm sorry in advance if this is the wrong place to post this but i would like to make a suggestion:
It would be a good idea for kivy to change its default theme to material design. It is well documented, clean, easy to use, mobile oriented and looks native on android platforms and a growing number of sites. Its usability has also been tested by the millions of users who use android everyday so the design scheme is solid and trustworthy. I know the kivy developers are planning to make kivy themable but i think that material design would be a great intermediary step until that is achieved, and even as the default theme, after the theming capabilities are implemented. In terms of implementation, the developer of kivymd has successfully created widgets that follow material design and if both groups could collaborate, it would be even better. One of the major obstacles kivy, has is its non native appearance, which looks out of place on all platforms (along with the fact that not many developers know about it). By using a clean functional design that is native on one of the most widely used platforms, I think kivy will become the go to gui toolkit for cross platform python development

native on one of the most widely used platforms

Exactly because of that I doubt material design will be ever adopted by Kivy as the theme. One platform. Not two or more. Argument such as this converges to a "they use it, you have to too!". Material design might be even undesirable on iOS and OSX especially if you find at least a bunch of users who dislikes it.
The same thing was (together with the app's controversial name) recently an issue with the Apple's app on Google Play, which hasn't seen Material even from a distance, although Google apps at least try to fit into the design patterns of iOS with its apps. The reaction on the Apple application was quite furious :)
Kivy is well themable even now. Place your images to some folder, create atlas from them and just join the pictures. It's not that hard. As an alternative you can replace the images directly with e.g. background_normal and similar variables.
Unless there's some intention to even move that direction (none that I know about) from other core devs, I'm closing the issue.

Argument such as this converges to a "they use it, you have to too!"

I'm not asking that we switch to material design because its popular, im asking we switch to is because, its functional, well designed, clearly documented and time tested. It just seems smart to use a design that looks decent rather than an archaic theme from a no longer existent os that only looks native (and barely so) on android 4 and younger

Kivy is well themable even now. Place your images to some folder, create atlas from them and just join the pictures. It's not that hard.

Yes kivy is themable, but i was suggesting this to be the default theme so that developers who want to use this wouldnt have to reinvent the wheel.

The reaction on the Apple application was quite furious

Yes there will be controversy but in the end, kivy was designed with mobile computing in mind, and the major mobile os right now is android

Unless there's some intention to even move that direction (none that I know about) from other core devs, I'm closing the issue.

You closed the issue before the other core devs even had a chance to see it, much less discuss moving in that direction. If you just shut down ideas and close them left and right, how will the core devs ever know?

how will the core devs ever know?

Notifications.

But they didnt get to discuss this did they?  : )

@Leviathanone, they did extensively discuss theming in the past, your proposal is just an aspect of it.
Kivy is gravitating towards offering behaviors, without dictating graphical representations. A theming solution is needed to realize that idea, mainly by extending kv to support declaring animations and some other things, or at least making it easier to separate the theme and its behaviors from the rest of the widget logic, and making the theme swappable.
When these are implemented, third-party developers will be able to offer alternative themes, including one for material design, and that will likely happen outside of the main kivy repo.

its functional, well designed, clearly documented and time tested...

...and adopted only by a single platform and not even that, it's adopted by Google. Android isn't just Google and its Material design. There's (or was, still probably not decided) Cyanogen and many other alternatives or branches of Android and not every one of them adopted such design.

reinvent the wheel

KivyMD is a package, you only have to import it, plus it has its own set of widgets. Regarding the images, you can replace some or each of them in atlas. Or just use variables as mentioned before. No one forbids you designing your app.

the major mobile os right now is android

I wouldn't stab into the hornet's nest if I were you. And I'm an Android guy...

You closed the issue ... how will the core devs ever know?

Every core-dev and contributor has an option to open/close tickets on GitHub. If it's closed, it doesn't mean it won't be reopened (and the other way around) and as dessant said, we get notified from GitHub, or we see it at freenode#kivy-dev as there's a bot reporting such things like PRs, issues, etc in real-time and most of us don't even leave the channel, so there's even history. And BotBot history.

In any case its still better to have a theme that some hates rather than a theme that most hate.

Well then, I don't hate Material design, I like it on Android, because I have Super AMOLED, though a well made UI/UX is still a way more eye pleasant than Material especially on 720p+ 5.5" displays. Most of the common → not high-end, not custom builds, the cheap machines that are just consumable goods ← desktops+laptops are happy if they have an LCD that's usable by graphic designers.
I just find it highly inappropriate for desktop platforms mainly because it happens to do buttons with text only (basically html <a> tag), input field is just a line and many other lovely things not really usable on desktops if you want to make an application that's readable and not just pretty from a distance of 3m.
I find Flat design where even Material belongs to useful only for web and really simple applications, but for some reason those happened:

Metro in Windows - and the lovely finger they got for removing start menu with that change, which they got back just to satisfy people,

iOS slowly getting to OSX and flattening everything - which non-Apple people used to hate just because it was, without any reason even before the flattening. However, porting such things like the app dock was apparently good enough for them. ¯\(ツ)/¯

Related to making a cross-platform usable theme, there's Java FX which a lot of people just "love" because it happened to try looking like some extended WinXP or a Winamp theme with designing screw ups.
Therefore if there was a new theme considered, it would be most likely something that's usable on all supported platforms and at the same time readable. If there is something like that, feel free to suggest taking a look at it.
And personally, I'd like you to consider not creating confusing issues in the future as 3 people do not speak for the whole community, especially not at 3-5am European time, which happens to be the time for a lot of us, not only devs. Instead, make a poll or something before such actions and make issues then.
It'll definitely give more objective results even for us to know which direction would be more comfortable to move our asses towards as we aren't intentionally going against our community, although it currently might seem like that to you. :)

@Leviathanone
Just my 2 cents, I am not a dev. But I do pay attention to Kivy and I see all issues thanks to Github.
I think so long as using kivymd is as simple as pip install kivymd and import kivymd, then there will be no need to make it the default theme. Now why you ask; because again in my opinion; Kivy has so many other issues 478 at this time was over 500 just a month ago; and that is just kivy not counting buildozer, pyler, pythonforandroid, and the various other sub projects of Kivy.
Given all of those issues I personally feel that we can get to this later. I hope that you will take my criticism of your idea as less critical in that I think Material Design is nice and would be a good fit; but that there are simply so many other pressing issues.

Thank you @FeralBytes. I appreciate your opinion.
When i was talking on IRC I suggested that I was willing to work on doing this, and before i could ask the KivyMD developer if he wanted to help me, I had to get an okay from you guys. I know there are more pressing issues but i am willing to work on this and i posted an issue on KivyMD's gitlab to see if he would like to help. So far i havent got a response though

@Leviathanone, it would be nice if someone could work on theming, here is a previous discussion on the topic: https://github.com/kivy/kivy/issues/691.

I think an improved flat default theme would be a nice way forward for Kivy, and I do think that the current default is not great. I think targeting full material design might cause more problems than it solves though, especially compared to improving Kivy's general themeability - I'm no UI expert, but I'd be concerned that trying to mimic a specific platform too closely actually causes more problems than it solves, as it makes all the ways things don't quite work the same very obvious, as well as making things fit progressively less well on other platforms. Of course, proper theme support would resolve this by letting things be switched out easily on different platforms.
KivyMD seems to make nice use of behaviours for things like the ripple effect. I personally wouldn't be terribly against including this kind of thing in Kivy core, in principle, but actually the current status seems quite healthy to me as well - KivyMD is an easy project to install and use, which is seems like a nice sign for the Kivy ecosystem.
It's likely that there would be strong resistance to outright changing Kivy's default theme significantly, especially if involving the material design animation flourishes etc. as well as just the basic look and feel - we've always tended to be very conservative about breaking changes. We've discussed this before as a major thing to do as part of a Kivy 2.0 release, alongside general theme support.
I wonder if t the best ratio of appearance improvement to effort might come from changing the default theme to apply colours only through Color instructions rather than coloured textures. That would immediately make it easy to change colours in a way that is currently annoying, because you have to start messing with images just to get the output shade you want.

Can I suggest then that we re-open this with the condition being that the issue be assigned to @Leviathanone ?
He can outline his plans here in the bug, and receive constructive criticism from all and guidance from the Kivy Devs. So long as it is not a core Dev issue then it should not drain resources much more than is already the state of Kivy; since regular PR review is just part of the work flow.
@Leviathanone as an individual that has had several commits accepted into Kivy, I would like to give you the key to my success. All of my commits are very small a matter of lines; but in general they are improvements that work to wards my larger goals.
In this case though it will also be tough because this is a wholesale concept. So for that I would recommend you create a branch of Kivy that follows master and includes your improvements. Then we will attempt to piece meal as many of the commits into main before we have to make the big wholesale decision to change the underlying theme.
Am I making sense here? Basically make a plan get, feedback, get buy in, figure out what small commits and changes could be done in advance of the bulwark and do them, get them accepted into master, then work on the remainder.

Yeah that's exactly what i wanted to do! I just needed permission to do the research and make the commits.
Ill start by making a fork

@Leviathanone You're welcome to experiment with this, but please do be aware that we're unlikely to consider merging such a change. This is something that we've discussed a lot in the past with many different points of view, and with the conclusion that it has not seemed like a good option, for reasons including those expressed by others in the previous posts.

Okay, never mind, I'm done. You guys are zig zagging on the issue on whether i should go for it or not so Ill just let the kivymd guys do what they do and use that instead for all the apps i plan to make, at least until kivy gets a decent theme, as for the main kivy project itself, well good luck and all the best. See ya

@Leviathanone, you may have missed my message which linked to https://github.com/kivy/kivy/issues/691. We want proper theme management, until that feature is not present in kivy, no resources will be spent on creating new widgets or retheming them, because it is wasted time for everyone involved.
We do welcome your work, and I agree with @FeralBytes about making plans, a proposal for theme management, and presenting it on #691.


Very nice effect！But，What should I do with the color on the corner ？

Hi, the start and end gradient ist not implemented yet. I can hopefully do that in the next few weeks. I have used a lineWidthModifier and blurWidthModifier function so far in order to reduce the width in the beginning and the end.

Unfortunately I currently have no capacities to implement that. I also feel that the blur should be re-written using a shader. Contributions welcome. :)


PDF displays text layer before rendering correctly

https://pdf.yt/d/24F9YmgH0xUy-VOV
This PDF seems to display the text layer before rendering correctly.
Chrome 39,  Windows x64,  PDF.js 1.0.1086
First rendering

Correct rendering

Windows 8.1 x64

That is not actually the textLayer, i.e. what we're using to enable text selection and searching, you're seeing. The PDF file itself contains a lot of standard showText commands, which the images in the file are subsequently rendered "over" thus obscuring the text.
The same effect can actually be observed in Adobe Reader as well, if you change the zoom level quickly. Since the performance of PDF.js isn't quite as good as a native application, this effect is unfortunately more pronounced in PDF.js.
The reason that this is an issue at all, however, is that the PDF file is using incorrect text rendering modes. For PDF files like these, which contains a scanned image, it's possible to specify that (OCR) text used for selection and searching should be invisible (i.e. text rendering mode 3).
Unfortunately this PDF file doesn't used the "invisible" text rendering mode, which thus explains the rendering issue observed here.
Since this really is a bug in the PDF generator, and Adobe Reader suffers from it as well, I would say that isn't actually an issue we can do anything about in PDF.js.
Hence I'd recommend that we close this issue as invalid, since the PDF file itself is broken.

@sethnk can you provide more details how this document is created, so we will have a sense how many those PDF documents might exist?

I didn't create it - I downloaded it.  I have only seen this issue on two pdfs out of 100's, so it is rare.  And also, as Jonas said, it is only visible temporarily while the pdf renders - as far as I am concerned it is a minor cosmetic issue and not important and by the sounds of it, pdf.js is behaving correctly - the pdf is likely to be at fault.

Closing as won't-fix for the reasons mentioned above.


docs: Improve changelog around KEDA as secure by default

Improve changelog to emphasize KEDA already supported running as non-root; but that we do it by default nowadays.
Checklist

[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] Changelog has been updated and is aligned with our changelog requirements

Relates to https://github.com/kedacore/keda/issues/2933

@JorTurFer Any tips on how I can fix the failing test? (feels unrelated but OK)

Ignore it. It's a flaky test.
If you had changed something in the code, you could retry the CI and it would work (if the code doesn't break it), but having changed only the changelog....


basic/test_wg_barrier fails on CL 3.0 with CL C 1.2

In my current CL 3.0 implementation the stack only advertises CL C 1.2 support.
This test never checks for that though and fails when it tries to use work_group_barrier which is only introduced in CL 2.0.
Is the correct behaviour here to detect that and skip the test?

Hi, thanks for your issue.
When you say:

In my current CL 3.0 implementation the stack only advertises CL C 1.2 support.

can I ask how this is being reported? Is it via a clGetDeviceInfo query with CL_DEVICE_OPENCL_C_VERSION since this would only report the latest fully backwards compatible version which could well be OpenCL C 1.2.
From  CL_DEVICE_OPENCL_C_ALL_VERSIONS the spec says that:

Because OpenCL 3.0 is backwards compatible with OpenCL C 1.2, and OpenCL C 1.2 is backwards compatible with OpenCL C 1.1 and OpenCL C 1.0, support for at least OpenCL C 3.0, OpenCL C 1.2, OpenCL C 1.1, and OpenCL C 1.0 is required for an OpenCL 3.0 device.

So I believe OpenCL C 3.0 support is required for an OpenCL 3.0 device, in which case the test shouldn't be skipped and work_group_barrier would need to be implemented on this device.

I read that 3 times yesterday and once more this morning and still missed it. Sorry for the noise, and for enlightenment.


Issue 9004: Pulsar Schema API: provide Type information for Fields

Fixes #9004
Motivation
GenericRecord API exposes the list of Fields but not the datatype associated to the field.
this patch introduces support for retrieving the Schema for each Field.
This information is available only for the limited subset of data types supported by Pulsar, for instance Avro MAPS and ARRAYS are not implemented and there is not way to represent such data types using SchemaType.
In the future when support for new datatype will be added we will support those new types in this system.
The implementation covers Avro and JSON schema types.
With this implementation Pulsar IO support for Metadata will be more similar the one in Kafka Connect, even we are still far as we do not have full support for all AVRO datatypes.
Modifications

add new Field#getSchema method
add new version of RecordSchemaBuilder#field that accepts a Schema instead of a GenericSchema ( FieldSchemaBuilder field(String fieldName, org.apache.pulsar.client.api.Schema<?> genericSchema);)
add relevant test cases

Verifying this change
This change added tests.
I tested manually that on Sinks the information is available, there is no need to add more integration tests
Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? JavaDocs

When we design Pulsar schema, we don't want to invent yet another type system.

@sijie
In Kafka Connect we see this great abstraction of Schema
and this makes it very easy to implement Connectors (especially Sinks) in a way that is not dependant on the serialization mechanism.
Therefore in Pulsar IO we do not allow the function implementation to access the underlying Avro libraries, I like this fact and I would like not to change it.
So my thinking is that we need our way to describe a Schema with a Pulsar API.
I would like also to follow up in order to add to the Pulsar Schema API all of the data types that are missing, like Arrays and Maps.
In my opinion without these features Pulsar IO won't be able to compete with Kafka Connect, and also to "port" existing Kafka Connect workflows to the Pulsar Ecosystem

When we design Pulsar schema, we don't want to invent yet another type system.

@sijie
In Kafka Connect we see this great abstraction of Schema
and this makes it very easy to implement Connectors (especially Sinks) in a way that is not dependant on the serialization mechanism.
Therefore in Pulsar IO we do not allow the function implementation to access the underlying Avro libraries, I like this fact and I would like not to change it.
So my thinking is that we need our way to describe a Schema with a Pulsar API.
I would like also to follow up in order to add to the Pulsar Schema API all of the data types that are missing, like Arrays and Maps.
In my opinion without these features Pulsar IO won't be able to compete with Kafka Connect, and also to "port" existing Kafka Connect workflows to the Pulsar Ecosystem

@eolivelli
There are two questions here. Let's not couple them together.

Whether we want to introduce a type system or not? If we want to introduce a type system what would be the approach.
How connector can access the schema information?

For the first one, I have a really strong different opinion on introducing a type system. I have seen problems with converting types between different systems. AVRO is already an open-standard that all the existing computing engines support. If we are introducing another type of system, we introduce a lot of troubles when integrating with other computing engines. That's something I would avoid. If you want to do that, let's think carefully. It is not just about connectors. Pulsar has a broader set of integrations that relies on schema. We can't afford to maintain different type systems and different approaches for different integrations. You end up need to maintain a lot of converters between Pulsar schemas with many other systems. It is going to be a nightmare.
For the second one, we should just let users access the underlying libraries. AVRO, JSON, and PROTOBUF have different type systems. Let's use their existing tools and not reinvent one.

without these features Pulsar IO won't be able to compete with Kafka Connect, and also to "port" existing Kafka Connect workflows to the Pulsar Ecosystem

First of all, Pulsar I/O doesn't compete with Kafka Connect. Pulsar I/O is an extension of the Pulsar ecosystem. Kafka Connect is the extension to Kafka. They might share similar goals. But they don't compete with each other.
Secondly, we embrace the Kafka ecosystem by providing a fully compatible wrapper to run existing Kafka connectors without introducing a type system. The key for this to work is using an open standard like ARVO.
Kafka Schema -> [ Open Standards: AVRO ] -> Pulsar Schema

@eolivelli
There are two questions here. Let's not couple them together.

Whether we want to introduce a type system or not? If we want to introduce a type system what would be the approach.
How connector can access the schema information?

For the first one, I have a really strong different opinion on introducing a type system. I have seen problems with converting types between different systems. AVRO is already an open-standard that all the existing computing engines support. If we are introducing another type of system, we introduce a lot of troubles when integrating with other computing engines. That's something I would avoid. If you want to do that, let's think carefully. It is not just about connectors. Pulsar has a broader set of integrations that relies on schema. We can't afford to maintain different type systems and different approaches for different integrations. You end up need to maintain a lot of converters between Pulsar schemas with many other systems. It is going to be a nightmare.
For the second one, we should just let users access the underlying libraries. AVRO, JSON, and PROTOBUF have different type systems. Let's use their existing tools and not reinvent one.

without these features Pulsar IO won't be able to compete with Kafka Connect, and also to "port" existing Kafka Connect workflows to the Pulsar Ecosystem

First of all, Pulsar I/O doesn't compete with Kafka Connect. Pulsar I/O is an extension of the Pulsar ecosystem. Kafka Connect is the extension to Kafka. They might share similar goals. But they don't compete with each other.
Secondly, we embrace the Kafka ecosystem by providing a fully compatible wrapper to run existing Kafka connectors without introducing a type system. The key for this to work is using an open standard like ARVO.
Kafka Schema -> [ Open Standards: AVRO ] -> Pulsar Schema

Sorry, I didn't mean that Pulsar IO is a competitor for Kafka Connect, but I would like to share my experience in porting projects that are working on Kafka Connect to Pulsar IO Sinks.
I recently got stuck in this problem, that when you deal with GenericRecord you cannot have metadata about the Schema, you can only access the raw schema bytes or you have to use Java reflection in order to deal with the type of each field (and this also is a problem because for null values you do not know the original datatype).
GenericRecord is a wonderful abstraction over generic data structures and it looks to me that the most missing part of the story is about having this kind of metadata about the structure.
GenericRecord already provides many APIs to create records and create schemas (RecordSchemaBuilder and GenericRecordBuilder) , the only missing part here is to "read" that metadata.
Once we have this API working with structured data with Pulsar IO (and probably with PulsarFunctions in general) will be more easier.
Dealing directly with Avro (and Protobuf...) is not a good way to go for my usecases, because I will have to explicitly write code for every schema type, and also enter the details of every technology.
For simple cases (but GenericRecord is not that simple, it is already very powerful, as it is already able to deal with nested structs) it is a great feature to be able to code your Pulsar Sink independently from the physical encoding of the records, the same way we do with Compression.
cc @shiv4289 @aahmed-se

@sijie I sent a new PR that allows you to access the underlying Schema information
https://github.com/apache/pulsar/pull/9614
I am going to close this PR if you are fine with that new approach

closing in favour of #9614


another commit

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#364  👈
#363
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Rexicon226 and the rest of your teammates on  Graphite

test


Controller fails attempting to add duplicate tolerations

What happened:
I am seeing errors in the log similar to:
Job.batch "job-name" is invalid: spec.template: Invalid value: core.PodTemplateSpec{...,Tolerations:[]core.Toleration{core.Toleration{Key:"nvidia.com/gpu", Operator:"Exists", Value:"", Effect:"NoSchedule", TolerationSeconds:(*int64)(nil)}, core.Toleration{Key:"nvidia.com/gpu", Operator:"Exists", Value:"", Effect:"NoSchedule", TolerationSeconds:(*int64)(nil)}}, ...}: field is immutable

When my ResourceFlavor has:
spec:
  ...
  tolerations:
  - effect: NoSchedule
    key: nvidia.com/gpu
    operator: Exists

And I restart the kueue-controller-manager.
It appears the Kueue is attempting to update the Job template to include a toleration that is already there (and is failing because the Job can't be updated)
What you expected to happen:

If a toleration already exists in the tolerations list, a duplicate should not be added.
Kueue should not attempt to update existing Jobs  (Updating tolerations or nodeSelectors) when the controller is restarted.

How to reproduce it (as minimally and precisely as possible):
Create a ResourceFlavor with
spec:
  ...
  tolerations:
  - effect: NoSchedule
    key: nvidia.com/gpu
    operator: Exists

Create a ClusterQueue and LocalQueue using the ResourceFlavor.
Create a long running Job targeting the ResourceFlavor.
Stop the controller.
Suspend the Job.
Start the controller.
Note errors described above.
Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version): v1.30.1-gke.1156000
Kueue version (use git describe --tags --dirty --always): 0.7.0
Cloud provider or hardware configuration: GKE Standard Cluster
OS (e.g: cat /etc/os-release): Unknown
Kernel (e.g. uname -a): Unknown
Install tools:
Others:

/assign

/assign


Refactor/update2svelte5

hi @josefineschaefer,
I created a working branch for Svelte 5. hope this helps to speed up releasing v5 support.
cheers,
Amar

This is amazing! Thank you for sharing this PR ✨.
I will test it in the next days.
@edodusi  and @alvarosabu 🚀

Hi @atu-record ,
I tested your branch locally, and it works great with Svelte 5, both using +page.ts and a server-side approach via +page.server.ts. Amazing job 🚀
This could serve as a solid foundation for the new major version of Storyblok Svelte (version 5).
In any case, based on my tests, the latest version of Storyblok Svelte appears to be compatible with Svelte 5. Did you encounter any issues? I mention this to identify a proper level of priority for the release of a new major version of Storyblok Svelte. (useful for @edodusi )

hi @roberto-butti,
when i updated the repo everything worked like a chart with<EMAIL_ADDRESS>the only issue I briefly encountered was with version https://publint.dev/<EMAIL_ADDRESS>as the package.json threw an error while importing. 3.2.1 works flawless again.
if I encounter anything during our projects I will come back to you. If you need anything else let me know.

Thank you @atu-record for your work and @roberto-butti for your review, I will look into this ASAP with the goal of crafting a new release fully supporting Svelte 5 🚀


[Enhancement] auto vacuum scheduled by FE

Fixes #issue
What type of PR is this:

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.1
[ ] 3.0
[ ] 2.5
[ ] 2.4

[FE PR Coverage Check]
:disappointed: fail : 14 / 130 (10.77%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/lake/compaction/CompactionJob.java
0
7
00.00%
[39, 40, 41, 42, 113, 117, 121]

:large_blue_circle:
com/starrocks/lake/Utils.java
0
4
00.00%
[70, 71, 72, 74]

:large_blue_circle:
com/starrocks/lake/compaction/CompactionScheduler.java
0
5
00.00%
[138, 147, 290, 303, 313]

:large_blue_circle:
com/starrocks/lake/vacuum/AutovacuumDaemon.java
0
96
00.00%
[50, 54, 55, 58, 59, 63, 64, 65, 66, 67, 68, 72, 74, 76, 79, 80, 81, 82, 83, 86, 88, 90, 92, 94, 97, 98, 99, 101, 102, 104, 105, 107, 108, 109, 110, 114, 116, 118, 124, 125, 126, 128, 130, 131, 132, 133, 134, 137, 140, 141, 142, 144, 145, 146, 147, 149, 150, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 164, 165, 166, 167, 168, 169, 170, 171, 173, 175, 176, 177, 178, 180, 181, 183, 184, 185, 186, 187, 188, 189, 191, 192, 193, 194, 195, 196]

:large_blue_circle:
com/starrocks/catalog/Partition.java
6
10
60.00%
[528, 532, 533, 536]

:large_blue_circle:
com/starrocks/common/Config.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/alter/LakeTableSchemaChangeJob.java
3
3
100.00%
[]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
1
1
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 13 / 127 (10.24%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/lake/compaction/CompactionJob.java
0
7
00.00%
[39, 40, 41, 42, 113, 117, 121]

:large_blue_circle:
com/starrocks/lake/Utils.java
0
4
00.00%
[70, 71, 72, 74]

:large_blue_circle:
com/starrocks/lake/compaction/CompactionScheduler.java
0
5
00.00%
[138, 147, 290, 303, 313]

:large_blue_circle:
com/starrocks/lake/vacuum/AutovacuumDaemon.java
0
94
00.00%
[49, 56, 57, 60, 61, 65, 66, 67, 68, 69, 73, 75, 77, 80, 81, 82, 83, 84, 87, 89, 90, 92, 94, 95, 96, 97, 98, 100, 103, 104, 105, 107, 108, 109, 110, 114, 116, 118, 124, 125, 126, 128, 130, 131, 132, 133, 134, 137, 140, 141, 142, 143, 145, 146, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 160, 161, 162, 163, 164, 165, 166, 167, 169, 171, 172, 173, 174, 176, 177, 179, 180, 181, 182, 183, 184, 185, 186, 187, 189, 190, 192, 193, 194]

:large_blue_circle:
com/starrocks/catalog/Partition.java
6
10
60.00%
[528, 532, 533, 536]

:large_blue_circle:
com/starrocks/common/Config.java
4
4
100.00%
[]

:large_blue_circle:
com/starrocks/alter/LakeTableSchemaChangeJob.java
3
3
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 14 / 130 (10.77%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/lake/compaction/CompactionJob.java
0
7
00.00%
[39, 40, 41, 42, 113, 117, 121]

:large_blue_circle:
com/starrocks/lake/Utils.java
0
4
00.00%
[70, 71, 72, 74]

:large_blue_circle:
com/starrocks/lake/compaction/CompactionScheduler.java
0
5
00.00%
[138, 147, 290, 303, 313]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
0
2
00.00%
[758, 1370]

:large_blue_circle:
com/starrocks/lake/vacuum/AutovacuumDaemon.java
0
94
00.00%
[49, 56, 57, 60, 61, 65, 66, 67, 68, 69, 73, 75, 77, 80, 81, 82, 83, 84, 87, 89, 90, 92, 94, 95, 96, 97, 98, 100, 103, 104, 105, 107, 108, 109, 110, 114, 116, 118, 124, 125, 126, 128, 130, 131, 132, 133, 134, 137, 140, 141, 142, 143, 145, 146, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 160, 161, 162, 163, 164, 165, 166, 167, 169, 171, 172, 173, 174, 176, 177, 179, 180, 181, 182, 183, 184, 185, 186, 187, 189, 190, 192, 193, 194]

:large_blue_circle:
com/starrocks/catalog/Partition.java
6
10
60.00%
[528, 532, 533, 536]

:large_blue_circle:
com/starrocks/common/Config.java
5
5
100.00%
[]

:large_blue_circle:
com/starrocks/alter/LakeTableSchemaChangeJob.java
3
3
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 14 / 130 (10.77%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/lake/compaction/CompactionJob.java
0
7
00.00%
[39, 40, 41, 42, 113, 117, 121]

:large_blue_circle:
com/starrocks/lake/Utils.java
0
4
00.00%
[70, 71, 72, 74]

:large_blue_circle:
com/starrocks/lake/compaction/CompactionScheduler.java
0
5
00.00%
[138, 147, 290, 303, 313]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
0
2
00.00%
[758, 1370]

:large_blue_circle:
com/starrocks/lake/vacuum/AutovacuumDaemon.java
0
94
00.00%
[49, 56, 57, 60, 61, 65, 66, 67, 68, 69, 73, 75, 77, 80, 81, 82, 83, 84, 87, 89, 90, 92, 94, 95, 96, 97, 98, 100, 103, 104, 105, 107, 108, 109, 110, 114, 116, 118, 124, 125, 126, 128, 130, 131, 132, 133, 134, 137, 140, 141, 142, 143, 145, 146, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 160, 161, 162, 163, 164, 165, 166, 167, 169, 171, 172, 173, 174, 176, 177, 179, 180, 181, 182, 183, 184, 185, 186, 187, 189, 190, 192, 193, 194]

:large_blue_circle:
com/starrocks/catalog/Partition.java
6
10
60.00%
[528, 532, 533, 536]

:large_blue_circle:
com/starrocks/common/Config.java
5
5
100.00%
[]

:large_blue_circle:
com/starrocks/alter/LakeTableSchemaChangeJob.java
3
3
100.00%
[]

[FE PR Coverage Check]
:disappointed: fail : 14 / 128 (10.94%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/lake/compaction/CompactionJob.java
0
7
00.00%
[39, 40, 41, 42, 113, 117, 121]

:large_blue_circle:
com/starrocks/lake/Utils.java
0
4
00.00%
[70, 71, 72, 74]

:large_blue_circle:
com/starrocks/lake/compaction/CompactionScheduler.java
0
5
00.00%
[138, 147, 290, 303, 313]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
0
2
00.00%
[758, 1370]

:large_blue_circle:
com/starrocks/lake/vacuum/AutovacuumDaemon.java
0
92
00.00%
[50, 57, 58, 61, 62, 66, 67, 68, 69, 70, 74, 76, 78, 81, 82, 83, 84, 85, 88, 90, 91, 93, 95, 96, 97, 98, 99, 101, 104, 105, 106, 108, 109, 113, 115, 117, 123, 124, 125, 127, 129, 130, 131, 132, 133, 136, 139, 140, 141, 142, 144, 145, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 159, 160, 161, 162, 163, 164, 165, 166, 168, 170, 171, 172, 173, 175, 176, 178, 179, 180, 181, 182, 183, 184, 185, 186, 188, 189, 191, 192, 193]

:large_blue_circle:
com/starrocks/catalog/Partition.java
6
10
60.00%
[528, 532, 533, 536]

:large_blue_circle:
com/starrocks/common/Config.java
5
5
100.00%
[]

:large_blue_circle:
com/starrocks/alter/LakeTableSchemaChangeJob.java
3
3
100.00%
[]

@Mergifyio rebase

[FE PR Coverage Check]
:disappointed: fail : 14 / 128 (10.94%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/lake/compaction/CompactionJob.java
0
7
00.00%
[39, 40, 41, 42, 113, 117, 121]

:large_blue_circle:
com/starrocks/lake/Utils.java
0
4
00.00%
[70, 71, 72, 74]

:large_blue_circle:
com/starrocks/lake/compaction/CompactionScheduler.java
0
5
00.00%
[138, 147, 290, 303, 313]

:large_blue_circle:
com/starrocks/server/GlobalStateMgr.java
0
2
00.00%
[758, 1370]

:large_blue_circle:
com/starrocks/lake/vacuum/AutovacuumDaemon.java
0
92
00.00%
[50, 57, 58, 61, 62, 66, 67, 68, 69, 70, 74, 76, 78, 81, 82, 83, 84, 85, 88, 90, 91, 93, 95, 96, 97, 98, 99, 101, 104, 105, 106, 108, 109, 113, 115, 117, 123, 124, 125, 127, 129, 130, 131, 132, 133, 136, 139, 140, 141, 142, 144, 145, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 159, 160, 161, 162, 163, 164, 165, 166, 168, 170, 171, 172, 173, 175, 176, 178, 179, 180, 181, 182, 183, 184, 185, 186, 188, 189, 191, 192, 193]

:large_blue_circle:
com/starrocks/catalog/Partition.java
6
10
60.00%
[528, 532, 533, 536]

:large_blue_circle:
com/starrocks/common/Config.java
5
5
100.00%
[]

:large_blue_circle:
com/starrocks/alter/LakeTableSchemaChangeJob.java
3
3
100.00%
[]

@Mergifyio backport branch-3.1


Lora training ?

Is it possible to do lora training on these models ?
It would give a big boost to this project, also finetuning on 24 images doesnt give any result at all, why the training stages have no epoch ?

We are working on it!

https://github.com/huggingface/diffusers/issues/5043

It's possible to train Würstchen with LoRA, see example in their repo


Delete old resources from java

This deletes the license which was changed to a dual one (if we want to add both licenses to the zip, we could), and deletes run.bat which no longer works

if we want to add both licenses to the zip, we could

I would like that


Site: Make left nav expand/collapse.

per ziplin design, make the header nodes expand/collapse on click.
when a link node is active, the background for the whole section should change, per design.

zeplin - https://app.zeplin.io/project/59fc8d826e1e5e806854ddbf/screen/5a1469d2c1db788c239fdf6c

later later


Added cloud factory

@Aashish69-96 Looks like the formatting is messed up.
I think you accidentally removed the Contributions header section and instead replaced that with Cloudfactory.
Could you please fix and resubmit the PR? You should add the new line in the markdown table in alphabetical order


eth/signature: fix allowing ledger v values of 0

fix #138

Codecov Report

Merging #155 (7b9b71d) into main (003dbe8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   99.74%   99.74%
=======================================
  Files          68       68
  Lines        3968     3983   +15
=======================================
+ Hits         3958     3973   +15
  Misses         10       10

Impacted Files
Coverage Δ

lib/eth/chain.rb
100.00% <100.00%> (ø)

lib/eth/signature.rb
100.00% <100.00%> (ø)

spec/eth/chain_spec.rb
100.00% <100.00%> (ø)

spec/eth/signature_spec.rb
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add example to show multiple signers on same EthereumSigner

Alloy supports multiple signers on same EthereumSigner instance. If the from field on the transaction is set it will detect which one to use -- once the Signer has been configured with all the necessary TxSigner boxes
An example would be AWS + local private key to illustrate the boxing

Soft blocked by https://github.com/alloy-rs/examples/issues/13


[InputAdornment][material-next] Add InputAdornment component

Part of https://github.com/mui/material-ui/issues/38374
Migration Steps

[ ] Copy component files from material (v5) to material-next
[ ] Remove deprecated components and componentsProps props
[ ] Drop support for ThemeProvider in favor of CssVarsProvider
[ ] Migrate component to Typescript
[ ] ~Refactor component to use Base UI’s hook if it exists~
[ ] Implement Material You design specs
[ ] ~Add component playground to v5 docs~ will be part of the TextField playground
[ ] Refactor styles to use component CSS Variables

There are some very noticeable differences in Material You in the placement of startAdornment in relation to the label
In MD2, the examples only show using the start adornment as "prefix text":

In Material You, they show only adornment icons in the specs diagrams:


Question: Is there a predefined way to change the months' language?

That's pretty much all. I have an app in spanish and I need to change the names of the months on the dropdown select element from DateRangePicker.
Is it possible? like a prop or something that I need to pass to it? If not, where is it reading the months from, so I could manually translate them. Thank you

You need to change moment's locale. Here's documentation https://github.com/react-dates/react-dates#localization


Proxmox VE 8.1 + Update README

Successfully PXE booted and installed Proxmox 8.1
Update README

bump


Nested scrolling and Adaptive Button Sheet not working

@MohamedRejeb
Good job with the library.
Using Adaptive Bottom Sheet to hold a WebView doesn't allow vertical scrolling on Android, yet working fine on iOS.
Had to wrap it in a Columb, yet, although a needles layer, it works but if there's a horizontal carousel in the page being rendered by the WebView, it's bumpy and page moves up and down wherever you swipe left and right.
You can reproduce with an Adaptive Bottom Sheet holding a Column holding a WebView set to open URL https://github.com/MohamedRejeb and scroll to the contributions carousel).

Any luck 🙄

@MohamedRejeb is this report still active?

Hi,
Thanks for reporting this issue. I will check it out.
Since it's in android so it should be happening as well if you just use jetpack compose for only android, if that is the case then it's an android issue.

Thanks.. yes probably it's an Android issue related to communicating scrolling events/data to the nested layer component.


Please rebuild based on shadcn-ui

I have a suggestion.
Could you reconstruct it based on shadcn-ui, using shadcn-minimal-tiptap as a reference?
I would like to have your individual functions, but I am not skilled enough to use them with shadcn-ui.
Thank you again for providing me with a good example.

Hi @kobe651jp, shadcn-ui is based on React, but the starter kit is framework agnostic, so React can't be added. however, I can implement a similar effect by copying the styles from shadcn-ui.
I'm also building a project using shadcn-ui, so will provide methods to implement it, but it will take some time.

Thank you for your kind reply.
Of course, there is no rush. Please proceed at your own pace.
I look forward to seeing the results.


Make solana-frozen-abi optional in all remaining crates

Summary of Changes
This could have been multiple extremely repetitive PRs but I think it's more efficient this way. It certainly would have taken me much longer to do the same find+replace over and over.
Aside from the cfg and cfg_attr stuff, this PR also:

Activates the frozen-abi feature in the scripts that are supposed to include ABI tests
For any crate that has a frozen-abi feature, activates the frozen-abi feature on any relevant dependencies if it's activated in the crate itself
Changes the dev-dependencies of solana-sdk to no longer activate frozen-abi in solana-program by default. This was added in #1222

Fixes #1096

Codecov Report
Attention: Patch coverage is 94.28571% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 82.1%. Comparing base (fadfa61) to head (b9f6b48).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1278    +/-   ##
========================================
  Coverage    82.1%    82.1%
========================================
  Files         893      893
  Lines      236939   237038    +99
========================================
+ Hits       194651   194776   +125
+ Misses      42288    42262    -26


Loot Sheet Still not Working after upgrade to Foundry v9

Describe the bug
(1) Players are unable to purchase from merchants, even though they have the Observer Permission set correctly.
(2) The avatars for 2 out of my 6 registered players do not even show up in Loot Sheet (only four avatars can be cycled/configured).
(3) The new collapsing window makes it really cumbersome to update Merchant inventory, or to check player access status.
To Reproduce
Steps to reproduce the behavior (for bug Item #1 above):

Player and DM inside the area (store) with a merchant token stocked with items. Player's permission is set to Observer (eye icon).
Player attempts to buy something.
Sometimes, a confirmation window appears, other times it does not. Either way....
Nothing at all happens. No sale. No exchange of currency. No purchased items sent to player inventory.

Expected behaviors
(A) Players can buy items directly from a merchant as long as they have the currency in their inventory to do so.
(B) All players are shown inside a loot sheet for the DM to cycle through permission (currently some players are missing)
(C) Configuration window does not collapse between each DM operation; DM does not have to constantly re-open a collapsed configuration window over and over again.
Desktop (please complete the following information):

OS: Windows 10
Browser Chrome
Version 96.0.4664.110 (Official Build) (64-bit)

Additional context
I absolutely love the Loot Sheet module. I can work around it no problem (players can just tell me what items they wish to purchase and I can complete the sale manually), but the lack of automation makes it less appealing to use.

There still is no release that supports v9. It’s being worked on.

There still is no release that supports v9. It’s being worked on.

That's wonderful to hear!  I was thinking that the reason it stopped working for me was because I was still on 8.9 (I had the same problem then as well).  I look forward to the v9 release, and in the mean time, it is still extremely helpful and awesome to have NPCs as merchants with inventories!  :-)

There still is no release that supports v9. It’s being worked on.

Do you have an eta on when v9 will be supported? I'm still getting the "No DM on scene" error...

No eta, no. But soon-ish.

On Jan 3, 2022, at 7:46 AM, Chris Allbritton @.***> wrote:

There still is no release that supports v9. It’s being worked on.
Do you have an eta on when v9 will be supported? I'm still getting the "No DM on scene" error...
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.

I updated my local dev to v9 now.
I will create a new branch for the current state of #234
branch.
And update the PR with fixes for v9.
I hope that fixes for v9 are backwards compatible.
We will se about that.
@ctbritt the "noactiveGM" should be gone in the next version.
We use the unique "uuid" to know which token is targeted in the future.
So GM can be on "scene for the session" while a player is buying stuff from a merchant in your start/landing page scene.
The new "welcome screen" (after install or update) will show a patchnotes tab that lists alot of the changes/features and buckfixes

I'm trying to use this module but it apparently doesn"t work with v9. Do you know how I can use the current dev version in FVTT?

V9 support is still being worked on.

On Jan 11, 2022, at 8:39 AM, playest @.***> wrote:

I'm trying to use this module but it apparently doesn"t work with v9. Do you know how I can use the current dev version in FVTT?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.

Can I help in any way? I know JS and web dev quite well but don't know anything about fvtt modules.

You can test https://github.com/jopeek/fvtt-loot-sheet-npc-5e/releases/tag/nightly-v<IP_ADDRESS> this pre release if you like.
In general most stuff is done.
I suppose its still a good day of work to get the populator settings working (currently the new "add filter rule" is not finished).

From a quick test I can see that the roll table population function is restored, i might be doing something wrong or the buy function is a bit wonky, when i buy something and finish its stock, the program deletes the item that is above it.
I am not completely sure if the buy item and buy stack work well, atleast they add the correct amounts to the player sheet but the substractions are wonky for the reasons i mentioned.
When looting, it seems that both buttons (loot item and loot stack) loot a single unit, but atleast the item is deleted properly on the loot sheet.
There is a small artifact that you probably already know about.

@ABrandau Thanks for the feedback.
I push a new pre-release, like the one above, later today.

The artifact is a text shadow :D , it seems, thats needs a bit of refining.
✅ The error on line 105 is taken care of. Thanks for sharing.

I tested with another user.
Here are some "known issues".

When using languages other than English, be sure that the rolltable you roll on references the items in the language that the compendium has the item names. Not yet sure if there will be a nice fix for that.

Make sure that users (and GM if GM wants to loot/buy) have a character assigned.

bottom left of foundry
configure user
click a character.
otherwise players wont show up in the sheet permissions field (GM always has permissions)

The styling (see GM section) seems to bug for some people. Did not yet manage to find out why. It just doesn't update the fields and give jquery warnings in the console.

✅when updating the sheet type via the actor, an error was triggered. This is locally fixed

✅Better rolltables was a dependency by accident (that was not intended to got public and is removed).

just zipped my latest dev build again. As always no guarantees :D
lootsheetnpc5e-noErrorOnActorUpdate.zip

The error seems to be gone when i use the sheet, there are some warnings but it works.
On my end the artifact dissapears when you open the sheet for the first time after creating it, but then comes back next time you open the sheet.
The items are now substracted from the sheet as they should but the buy / loot stack and item buttons only substract a single unit from the sheet.
The option to add quantity might be broken, I am doing different tests, starting with a d20, then with 5, and I cant see a single item go beyond 2 units, in fact i had to change quantity manually to do the earlier test.
The sell option is a neat new feature, though I cannot find if there are any options to change the sell price of each item, as now they are sold at full price, and also I cannot change the currency of the merchant, i need to change to the default sheet to get my hands on it. (and yeah, there is an option to add currency to the sheet when populating the table), the windows might be a bit too small for that though.

Finally i cannot recall if the sheet could populate scrolls from a spell compendium, i think it did but I might be wrong, in any case this does not work, but whenever I drag a spell into the sheet i get a spell scroll.
Sorry if I am covering too much ground but its these modules like yours what make foundry great, you are doing a great job.

If you find the time please test https://github.com/jopeek/fvtt-loot-sheet-npc-5e/releases/tag/nightly-v<IP_ADDRESS>
It's honestly still a bit weird when changing settings(flags) in a sheet. But I think thats a broader issue to look into.
This should bring back functionality to the core functions, fix currencies, add styling (custom backgrounds, css tinting, darkmode), add actions, trading (well we could switch that off for now as it still lacks tooltips and other things, or we just say use it if you like).
Hit me if you have questions.
Their likely are still some bugs hidden. As I don't have multiple environments to test it in, certain things often just slip by.
So please feel encouraged to test it out.
Currently I prefer getting the bug reports via Discord. So as long as I still have the time to put that much time into this. I'd like to try to fix these things right away. :D

This doesn't look right at the moment. But I'm glad that the sheet is still in development.


searchfield in the menubar missed for windowsize smaller than 1180 px

searchfield in the menubar missed for windowsize smaller than 1180 px. Tested with Firefox version 56.0.1 (64-Bit)

We change the navbar to mobile view earlier now. Basically at the point where right-aside disappears. There is no search field in mobile view navbar...

There is no search field in mobile view navbar...

Provide hubzilla for mobile devices user no ersatz for search field?

fixed in 3efe144fa0c455529a3f6244557d1253885134cf
the breakpoint will be 992px now.


Upgrade to Blazor 3.1.0-preview4.19579.2 and ASP.NET Core 3.1

#186

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: ardacetinkaya sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


SeatHandler trait not satisfied

I don't understand why I am getting these errors.
I am copying the example but getting compilation errors
But I don't get it, EguiState does implement those.
All I can imagine is that rust can't find a link between mu integration::State and EguiState, which would cause the generics of the impl blocks to fail.
Any clue as to what I can do to fix this?
error[E0277]: the trait bound `EguiState: KeyboardTarget<integration::State>` is not satisfied
   --> launcher/src/integration.rs:34:26
    |
34  |     type KeyboardFocus = EguiState;
    |                          ^^^^^^^^^ the trait `KeyboardTarget<integration::State>` is not implemented for `EguiState`
    |
    = help: the following other types implement trait `KeyboardTarget<D>`:
              WlSurface
              smithay::desktop::LayerSurface
              smithay::desktop::Window
              smithay::xwayland::X11Surface
note: required by a bound in `smithay::input::SeatHandler::KeyboardFocus`
   --> /root/.cargo/git/checkouts/smithay-b5a338d5236320f6/d8600f2/src/input/mod.rs:129:25
    |
129 |     type KeyboardFocus: KeyboardTarget<Self> + 'static;
    |                         ^^^^^^^^^^^^^^^^^^^^ required by this bound in `SeatHandler::KeyboardFocus`

error[E0277]: the trait bound `EguiState: PointerTarget<integration::State>` is not satisfied
   --> launcher/src/integration.rs:35:25
    |
35  |     type PointerFocus = EguiState;
    |                         ^^^^^^^^^ the trait `PointerTarget<integration::State>` is not implemented for `EguiState`
    |
    = help: the following other types implement trait `PointerTarget<D>`:
              WlSurface
              smithay::desktop::LayerSurface
              smithay::desktop::Window
              smithay::xwayland::X11Surface
note: required by a bound in `smithay::input::SeatHandler::PointerFocus`
   --> /root/.cargo/git/checkouts/smithay-b5a338d5236320f6/d8600f2/src/input/mod.rs:131:24
    |
131 |     type PointerFocus: PointerTarget<Self> + 'static;
    |                        ^^^^^^^^^^^^^^^^^^^ required by this bound in `SeatHandler::PointerFocus`

turns out I'm just stupid, didn't properly copy over the dependencies from the cargo file


testing testing take 2

Ran Plan for dir: . workspace: default
Show Output

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create

Terraform will perform the following actions:

  # null_resource.another_example will be created
+ resource "null_resource" "another_example" {
      + id = (known after apply)
    }

  # null_resource.example will be created
+ resource "null_resource" "example" {
      + id = (known after apply)
    }

Plan: 2 to add, 0 to change, 0 to destroy.

:arrow_forward: To apply this plan, comment:

atlantis apply -d .

:put_litter_in_its_place: To delete this plan click here
:repeat: To plan this project again, comment:

atlantis plan -d .

Plan: 2 to add, 0 to change, 0 to destroy.

:fast_forward: To apply all unapplied plans from this pull request, comment:

atlantis apply

:put_litter_in_its_place: To delete all plans and locks for the PR, comment:

atlantis unlock

atlantis apply

Ran Apply for dir: . workspace: default
null_resource.example: Creating...
null_resource.another_example: Creating...
null_resource.another_example: Creation complete after 0s [id=3100318455538509899]
null_resource.example: Creation complete after 0s [id=2012642442592320569]

Apply complete! Resources: 2 added, 0 changed, 0 destroyed.

Locks and plans deleted for the projects and workspaces modified in this pull request:

dir: . workspace: default


Clarify non-nullable pointer optimization in repr(C) section

Resolves #59

Looks good, just need to double-check that Box is Actually FFI-Safe, as this is quite surprising to hear

Thanks for the review!
The Nullable Pointer Optimization subsection under FFI calls out boxes since they can't hold null pointers. This makes it seem like they should be FFI-safe since the representation in memory would be the same as for a raw pointer (iiuc). I'm far from an authority on this, so please correct me if I'm wrong!
One potential distinction I see between Box<T> and the other listed types is that since a Box holds Rust-owned data (which is freed using Rust's allocator), it's not suitable to receive pointers from non-Rust code. However, it should be able to provide pointers from Rust to non-Rust code, right?

There are subtle annoying details about ABI here. Specifically, pointers are a specific kind of thing in ABIs, and a struct containing a pointer does not have the same one. I expect we currently do match the ABI, but I'm uncertain that we guarantee it. (why would we?)

Discussing with @eddyb, we agree we could guarantee the ABI of Box but don't have a strong motivation to do so. All we guarantee about Box is that Option<Box> has the same layout as Box.

Makes sense. I can't see any motivation for guaranteeing that ABI either. Updated the PR.


Fixing CI run

remove redundancy in CI.yaml caused by merging
-push
....
was accidentally int the CI.yaml file twice, presumably due to a merge issue. This simply removes the duplicate

lgtm!


iOS, RN 0.43.2 Multiline text does not show magnifying glass on long press

I haven't tested on Android, but on iOS you can reproduce by following these steps:

Make a multiline Textinput that has more than 1 row. Let's make it 5 rows so we could easily see the issue.
Long press at the center of the Textinput

Issue: Notice that no magnifying glass is present.
Alternatively, if you long press at the first line, you'll see the magnifying glass.
Expected: This should match the default behavior of textarea: when you long press the textarea anywhere, it shows magnifying glass. Also notice the Reddit native app implements this behavior correctly in the screenshot below

Can you reproduce this on master?
I am pretty sure I already fixed this month or two ago.

Do you remember which file the fix is on? I can quickly check if it's in master or if it's not in 0.43.2 @shergin

The commit: 3acafd1f3dd42cc27a592cdee0530e0dbf1c8afd.

That explains it. The fix is in 0.44.0 not in 0.43.0.


Path for Github view changed..

Changed the path for images assets from dist to public. Since no dist folder as it is not committed..

I appreciate your commit, I've been noticed broken links, but decided to prorogue unless v2.


Is it possible to add the same product multiple times to cart?

Is it possible to add an item more than once to the cart and it won't increase the quantity but add a separate item to cart.

public function addItem(Buyable $product, $qty = 1, $params = []): \Vanilo\Cart\Contracts\CartItem
{
    $item = $this->items()->ofCart($this)->byProduct($product)->first();

    if ($item) {
        $item->quantity += $qty;
        $item->save();
    } else {
        $item = $this->items()->create(
            array_merge(
                $this->getDefaultCartItemAttributes($product, $qty),
                $this->getExtraProductMergeAttributes($product),
                $params['attributes'] ?? []
            )
        );
    }

    $this->load('items');

    return $item;
}

This seems to be the part that increments the cart item quantity if it exists. Can we have an alternative to add a new item to cart instead of increasing quantity?

I think that's possible. So that I get your context, can you please describe the use case in a little bit more details?

I think that's possible. So that I get your context, can you please describe the use case in a little bit more details?

A shopper wants to add a product with variant Color:Red and Size:XL, the same shopper also wants to add another of the same product with variant Color:Blue and Size:XXL. The shopper wants to see these as two distinct items in cart and as distinct items as an oder

Ah cool, I get it. It's basically the product variants problem, see also vanilophp/framework#62 for more details.
How do you distinguish between Color and Size variants? Are you using the properties package or something else?

I made my own variants module. Variants have foreign key relationships with the product model.
However, even without variants, is this possible currently or do can I extend the Cart model like I have done with the Product model.

Absolutely possible. You only need to replace the Cart model (not the facade!) and overwrite the addItem method with your version.
Steps:

Create your model, eg. App\Cart
Make App\Cart to extend Vanilo\Cart\Models\Cart
Implement your addItem method in App\Cart
Register your custom model so that it will be used instead of the original one:

// app/Providers/AppServiceProvider.php
namespace App\Providers;

use Illuminate\Support\ServiceProvider;
use Vanilo\Cart\Contracts\Cart as CartContract;

class AppServiceProvider extends ServiceProvider
{
    public function boot()
    {
        $this->app->concord->registerModel(
            CartContract::class, \App\Cart::class
        );
    }
}

This way, you custom method will be used, even if you're invoking the cart facade's Cart::addItem method.
More details: https://vanilo.io/how-to/use-custom-models-in-your-application
Let me know if it worked :bowing_man:

Could you manage to achieve the functionality?

Hey Attila,
i had the same Problem and could solve the problem. Excellent help. Thank you!
As of Laravel 7.x it needs to be
class Cart extends \Vanilo\Cart\Models\Cart {     public function addItem(Buyable $product, $qty = 1, $params = []): \Vanilo\Cart\Contracts\CartItem
(with \ before Vanilo)


How to access validated form values after onChange

Hi :) I want to access the (valid) form values onChange rather than onSubmit. How could that be accomplished?
At the moment i pass all form values up on every rerender:
const Form = ({ revalidation: { form, onChange, valid }, onFormChange }) => (onFormChange(form, valid), (
  <form>
      <input type="number" min={1} max={20} value={form.zoom} onChange={compose(onChange('zoom'), parseInt, getValue)} />
  </form>
));

Is there a better way to do this? Maybe by composing a callback function in the onChange function after the validation passed?

Hi, I'll have a look at the problem later today.

Thats what i try to accomplish, yes :)

Make sense and will be added to 0.12


iOS debug builds not working

All of my iOS apps are not building. I get a message saying it failed with no reason as to why.  I have reuploaded all of my certs/provisions but still get the same errors.  I have tried 5.0.1-rc1 as well as 4.0.10.
Anyone noticing this or is it just me?
Thanks

@andybbtt11 if you are using any github plugins check if there is one updated recently.

good idea @rafaeluzzi. I tried removing all plugins, i completely created new dev certs and profiles, changed version number, reuploaded, etc.  Still I get the vague failed error.  I also tried removing both of my github plugins from my build settings still nothing.

I was able to build my IOS app with 5.0.1-rc1 .. only have 1 plugin.. didn't change anything in my settings.  No errors.

We had an issue with build assets which has been resolved.
@andybbtt11 let us know if you're still getting errors with new builds.

@christofferh working now. Thank you.


About your latest selfsup work MFM

May I ask when will you release the codes of MFM? I would like to do some research based on this work.

Thanks for your attention, we will release the code of MFM quickly.


Always stop timer in Stream.Read

Resolves https://github.com/xtaci/smux/issues/52

Codecov Report

Merging #53 into master will decrease coverage by 0.21%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
- Coverage   84.68%   84.46%   -0.22%
==========================================
  Files           5        5
  Lines         470      470
==========================================
- Hits          398      397       -1
- Misses         62       64       +2
+ Partials       10        9       -1

Impacted Files
Coverage Δ

stream.go
89.55% <100%> (+1.49%)
:arrow_up:

session.go
78.62% <0%> (-1.15%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b3c96...e7738d0. Read the comment docs.


Using pip3 install --editable . and got stuck in Collecting sacrebleu step

Hi,
I tried installing fairseq however, using both pip install fairseq and also installing from source, I am stuck in the "Collecting sacrebleu" step and nothing happen for a long time.
Also, I can import fairseq in python but other executable commands like fairseq-preprocess , fairseq-train, etc do not work.
Anyone knows what is the problem?
Here is my bash log:
(py36) hannahbrahman@citrisdance:fairseq$ pip3 install --editable .
Obtaining file:///home/hannahbrahman/fairseq
Requirement already satisfied: cffi in /home/hannahbrahman/anaconda3/lib/python3.7/site-packages (from fairseq==0.8.0) (1.12.3)
Collecting fastBPE (from fairseq==0.8.0)
  Using cached https://files.pythonhosted.org/packages/e1/37/f97181428a5d151501b90b2cebedf97c81b034ace753606a3cda5ad4e6e2/fastBPE-0.1.0.tar.gz
Collecting numpy (from fairseq==0.8.0)
  Using cached https://files.pythonhosted.org/packages/05/4b/55cfbfd3e5e85016eeef9f21c0ec809d978706a0d60b62cc28aeec8c792f/numpy-1.17.0-cp37-cp37m-manylinux1_x86_64.whl
Collecting regex (from fairseq==0.8.0)
  Using cached https://files.pythonhosted.org/packages/6f/4e/1b178c38c9a1a184288f72065a65ca01f3154df43c6ad898624149b8b4e0/regex-2019.06.08.tar.gz
Collecting sacrebleu (from fairseq==0.8.0)
  Downloading https://files.pythonhosted.org/packages/b9/d6/258a1e63463b4731a387f0872dca759c330bf4845cc0464f2c65028674b6/sacrebleu-1.3.7.tar.gz

Hmm, no idea why that’s happening. Can you try pip install sacrebleu first?

@myleott thanks for your hint.
Actually pip install sacrebleu was the same and it didn't install anything.
What I did is I wget the tar file, unrar it and then I ran python setup.py install
Thankss


WIP: Upload lambda artifacts to s3

Problem

We would like to deploy lambda functions by uploading the artifacts to s3.
Solution

Updates deploy-lambda-function to accept s3 options.
Simplifies the deploy-lambda-function action itself to only deploy the function.
Adds a workflow (deploy-lambda-function.yml) to log into aws, deploy the lambda, and create a current version file within the s3 bucket.
Notes

Closing in favour of #35


Have cloudy notify a slack channel when a feature is released

Create a #feature-release channel which cloudy posts in so that we know what features are released every day (that way we know what to write docs + headway updates for)
Only post issues that are closed with the feature request tag

can we only follow one of the cloud instances to simplify things ? eg: app (aka US cluster) . We normally release to both servers at the same time

Sorry, I don't think I understand what you mean @rephus 🤔
are you saying can we have one channel per app? (e..g one channel for the US cluster and one channel for the Europe cluster?)

ah ok, so by "released" I assume you mean " it has been released to a cloud server".
Currently we have 2 clusters (eu1 and usa (where analytics or app lives) ), this obviously doesn't count self-hosted.
We could do this by checking periodically the version we have on our cloud version (doable via API) and post to slack the features that it contains . Or maybe include it on a release script.
If by released you mean "as soon as is on master" then we just need to check github.

ooh, I think it would be great when we have it released to a cloud server!
That way, we'd be able to tell users if we saw something that popped up that they'd asked for (and we wouldn't write updates about things that don't exist in people's instances yet!)
In that case, could we have one channel, but the message would tell us which instance it's been released to?
E.g. #3871 has been released on all EU1 instances


Add a privacy policy

Make totally clear what information is sent/stored etc.

#972 will probably need this in order to be fully compilant


Dependency Version Upgrades

PR description
Upgrade all dependencies versions except RocksDB and PicoCLI.
Signed-off-by: Danno Ferrin<EMAIL_ADDRESS>

Cherry picked out the web3j changes as they appear to have a bug.


msvc/vcpkg dynamic builds now require explicit opt-in

The build helper was changed to require explicit opt-in for linking dynamically, otherwise cargo install using the msvc toolchain would prefer dynamically linking if Vcpkg is installed resulting in binaries that won't work without a PATH adjustment. This commit makes the appveyor build opt-in.

@jgallagher This will fix the appveyor breakage for new pull requests coming in. Sorry for the hassle.


:seedling: CSR uses INFO level if providerID was not set yet.

What this PR does / why we need it:
In this PR https://github.com/syself/cluster-api-provider-hetzner/pull/1351 we set the ProviderID earlier, but this did not work.
The linked PR was done to avoid error messages in the CSR-controller.
This PR changes the error messages of the CSR-controller. If the CSR exists, but there is no hbmm with the corresponding ProviderID, then this is fine. We wait some seconds and then we try again.
The hbmm is likely in state "ensure-provisioned", and the providerID will be set soon. INFO level logging is fine in this case.

Testing: Without constant-hostname it works. Related logs:
level: DEBUG
time: "2024-06-21T09:20:21.784Z"
file: host/state_machine.go:73
message: changing provisioning state
controller: hetznerbaremetalhost
controllerGroup: infrastructure.cluster.x-k8s.io
controllerKind: HetznerBareMetalHost
HetznerBareMetalHost:
  name: test-bm-uefi
  namespace: default
namespace: default
name: test-bm-uefi
reconcileID: 173abccd-a45c-4cc7-a663-18ceca646d2d
HetznerBareMetalHost:
  name: test-bm-uefi
  namespace: default
HetznerCluster:
  name: caph-guettli
  namespace: default
Cluster:
  name: caph-guettli
  namespace: default
HetznerBareMetalMachine:
  name: caph-guettli-md-1-wvp4v-st54z
  namespace: default
old: provisioning
new: ensure-provisioned
---
level: DEBUG
time: "2024-06-21T09:20:21.784Z"
logger: events
file: recorder/recorder.go:104
message: 'Phase provisioning, reboot via SSH: UserData of cloud-init was created'
type: Normal
object:
  kind: HetznerBareMetalHost
  namespace: default
  name: test-bm-uefi
  uid: dd2a648f-d375-4e93-8a50-90e54e781a6f
  apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
  resourceVersion: "116625"
reason: RebootBMServerViaSSHProvisioningStateProvisioning
---
level: DEBUG
time: "2024-06-21T09:20:21.906Z"
file: host/host.go:156
message: conflict error. Retrying
controller: hetznerbaremetalhost
controllerGroup: infrastructure.cluster.x-k8s.io
controllerKind: HetznerBareMetalHost
HetznerBareMetalHost:
  name: test-bm-uefi
  namespace: default
namespace: default
name: test-bm-uefi
reconcileID: a0f653a1-24fb-4462-aba8-210e9749599a
HetznerBareMetalHost:
  name: test-bm-uefi
  namespace: default
HetznerCluster:
  name: caph-guettli
  namespace: default
Cluster:
  name: caph-guettli
  namespace: default
HetznerBareMetalMachine:
  name: caph-guettli-md-1-wvp4v-st54z
  namespace: default
err: 'Operation cannot be fulfilled on hetznerbaremetalhosts.infrastructure.cluster.x-k8s.io "test-bm-uefi": the object has been modified; please apply your changes to the latest version and try again'
---
level: DEBUG
time: "2024-06-21T09:22:27.918Z"
file: controllers/csr_controller.go:311
message: No constant baremetal hostname - regex does not match CSR username
controller: certificatesigningrequest
controllerGroup: certificates.k8s.io
controllerKind: CertificateSigningRequest
CertificateSigningRequest:
  name: csr-8lvwd
namespace: ""
name: csr-8lvwd
reconcileID: a33a6a29-8d4a-477e-828c-3e9c6ec7450d
regex: ^bm-(\S*)-(\d+)$
csrUserName: system:node:bm-caph-guettli-md-1-wvp4v-st54z
---
level: DEBUG
time: "2024-06-21T09:22:27.934Z"
logger: events
file: recorder/recorder.go:104
message: approved csr
type: Normal
object:
  kind: CertificateSigningRequest
  name: csr-8lvwd
  uid: e7d0b975-ea14-49d0-bdd0-7897f64a9fae
  apiVersion: certificates.k8s.io/v1
  resourceVersion: "202823"
reason: CSRApproved
---
level: DEBUG
time: "2024-06-21T09:22:34.244Z"
logger: events
file: recorder/recorder.go:104
message: server successfully provisioned
type: Normal
object:
  kind: HetznerBareMetalHost
  namespace: default
  name: test-bm-uefi
  uid: dd2a648f-d375-4e93-8a50-90e54e781a6f
  apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
  resourceVersion: "116919"
reason: ServerProvisioned
---
level: DEBUG
time: "2024-06-21T09:22:34.819Z"
file: host/state_machine.go:73
message: changing provisioning state
controller: hetznerbaremetalhost
controllerGroup: infrastructure.cluster.x-k8s.io
controllerKind: HetznerBareMetalHost
HetznerBareMetalHost:
  name: test-bm-uefi
  namespace: default
namespace: default
name: test-bm-uefi
reconcileID: 96a88d5a-f57b-4a11-a4c6-0b603e46e98f
HetznerBareMetalHost:
  name: test-bm-uefi
  namespace: default
HetznerCluster:
  name: caph-guettli
  namespace: default
Cluster:
  name: caph-guettli
  namespace: default
HetznerBareMetalMachine:
  name: caph-guettli-md-1-wvp4v-st54z
  namespace: default
old: ensure-provisioned
new: provisioned
---
level: DEBUG
time: "2024-06-21T09:22:34.819Z"
logger: events
file: recorder/recorder.go:104
message: "/var/log/cloud-init-output.log: Cloud-init v. 24.1.3-0ubuntu1~22.04.5  [cut] ..."
type: Normal
object:
  kind: HetznerBareMetalHost
  namespace: default
  name: test-bm-uefi
  uid: dd2a648f-d375-4e93-8a50-90e54e781a6f
  apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
  resourceVersion: "116919"
reason: CloudInitOutput

Here the logs with a machine with constant-hostname (I filtered the output a bit so that it has less lines):

level: DEBUG
time: "2024-06-21T10:03:30.288Z"
logger: events
message: 'will retry: . StdErr:  (failed to dial ssh. Error message: dial tcp <IP_ADDRESS>:22: connect: connection refused. DialErr: failed to dial ssh)'
object:
  kind: HetznerBareMetalHost
  name: test-bm-uefi
  apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
reason: SSHToRescueSystemFailed
---
level: DEBUG
time: "2024-06-21T10:03:30.293Z"
message: conflict error. Retrying
HetznerBareMetalHost:
  name: test-bm-uefi
name: test-bm-uefi
HetznerBareMetalHost:
  name: test-bm-uefi
HetznerCluster:
Cluster:
HetznerBareMetalMachine:
err: 'Operation cannot be fulfilled on hetznerbaremetalhosts.infrastructure.cluster.x-k8s.io "test-bm-uefi": the object has been modified; please apply your changes to the latest version and try again'
---
level: DEBUG
time: "2024-06-21T10:03:30.378Z"
message: conflict error. Retrying
HetznerBareMetalHost:
  name: test-bm-uefi
name: test-bm-uefi
HetznerBareMetalHost:
  name: test-bm-uefi
HetznerCluster:
Cluster:
HetznerBareMetalMachine:
err: 'Operation cannot be fulfilled on hetznerbaremetalhosts.infrastructure.cluster.x-k8s.io "test-bm-uefi": the object has been modified; please apply your changes to the latest version and try again'
---
level: DEBUG
time: "2024-06-21T10:04:51.952Z"
message: changing provisioning state
HetznerBareMetalHost:
  name: test-bm-uefi
name: test-bm-uefi
HetznerBareMetalHost:
  name: test-bm-uefi
HetznerCluster:
Cluster:
HetznerBareMetalMachine:
old: provisioning
new: ensure-provisioned
---
level: DEBUG
time: "2024-06-21T10:04:51.953Z"
logger: events
message: 'Phase provisioning, reboot via SSH: UserData of cloud-init was created'
object:
  kind: HetznerBareMetalHost
  name: test-bm-uefi
  apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
reason: RebootBMServerViaSSHProvisioningStateProvisioning
---
level: DEBUG
time: "2024-06-21T10:04:52.107Z"
message: conflict error. Retrying
HetznerBareMetalHost:
  name: test-bm-uefi
name: test-bm-uefi
HetznerBareMetalHost:
  name: test-bm-uefi
HetznerCluster:
Cluster:
HetznerBareMetalMachine:
err: 'Operation cannot be fulfilled on hetznerbaremetalhosts.infrastructure.cluster.x-k8s.io "test-bm-uefi": the object has been modified; please apply your changes to the latest version and try again'
---
level: INFO
time: "2024-06-21T10:06:56.046Z"
message: 'ProviderID not set yet. The hbmm seems to be in ''ensure-provision''. Retrying. ProviderID: "hcloud://bm-2317525" no HetznerBaremetalMachine by ProviderID found'
CertificateSigningRequest:
  name: csr-6pxgn
name: csr-6pxgn
CertificateSigningRequest:
  name: csr-6pxgn
---
level: DEBUG
time: "2024-06-21T10:06:57.856Z"
logger: events
message: server successfully provisioned
object:
  kind: HetznerBareMetalHost
  name: test-bm-uefi
  apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
reason: ServerProvisioned
---
level: DEBUG
time: "2024-06-21T10:06:58.522Z"
message: changing provisioning state
HetznerBareMetalHost:
  name: test-bm-uefi
name: test-bm-uefi
HetznerBareMetalHost:
  name: test-bm-uefi
HetznerCluster:
Cluster:
HetznerBareMetalMachine:
old: ensure-provisioned
new: provisioned
---
level: DEBUG
time: "2024-06-21T10:06:58.522Z"
logger: events
message: "/var/log/cloud-init-output.log: Cloud-init v. 24.1.3-0ubuntu1~22.04.5 .. .cut"
object:
  kind: HetznerBareMetalHost
  name: test-bm-uefi
  apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
reason: CloudInitOutput
---
level: INFO
time: "2024-06-21T10:07:01.047Z"
message: Found HetznerBareMetalMachine with constant hostname
CertificateSigningRequest:
  name: csr-6pxgn
name: csr-6pxgn
csr-username: system:node:bm-caph-guettli-2317525
hetznerBareMetalMachine: caph-guettli-md-1-vn5zw-v7gv6
---
level: INFO
time: "2024-06-21T10:07:01.047Z"
message: found hbmm for system:node:bm-caph-guettli-2317525 (ConstantHostname)
CertificateSigningRequest:
  name: csr-6pxgn
name: csr-6pxgn
---
level: DEBUG
time: "2024-06-21T10:07:01.069Z"
logger: events
message: approved csr
object:
  kind: CertificateSigningRequest
  name: csr-6pxgn
  apiVersion: certificates.k8s.io/v1
reason: CSRApproved


DateField component is missing some data in the event

Copied from a comment by @philipand on https://github.com/stripe/stripe-apps/issues/705:

It seems like for the DateField component there is missing some data in the event.
The following code:
<DateField name="test" label="test" id="5" onChange={(e) => console.log(e)} />
Produces the following result:
{ "target": { "value": "2020-02-02" } }

In this case e.g. the Id isn't present. The example is that if you build dynamic forms, then you would need the ID for the element.

@philipand Under the hood, the DateField component is composed of three separate inputs, which is why the fix in https://github.com/stripe/stripe-apps/issues/705 didn't also fix this. We'll need to modify the component to accept and return an identifier. To match with the other components, I think it makes sense for this to be the name property rather than id, but let me know if you have a specific use case.
Thanks for alerting us to this issue.

Name would be just as good as ID. Thank you for the quick response.


Impossible to release to cocoapod

Swift release failed: impossible to publish to Cocoapods: https://github.com/meilisearch/meilisearch-swift/actions/runs/8360859280/job/22887494524
Reason: authentication issue.

I don't know why our token suddenly does not work. We changed nothing our side, and the token is still accessible by the CI
@Sherlouk if you have any clue 🙏

I even realize v0.15.0 of this library is not even on cocoapod despite the CI succeeded some months ago

Did I miss something related to cocoapod in the swift world?

Likely just needs the token to be updated. Haven't touched CocoaPods in years (most users are transitioning over to SPM at this point) - but likely just need to run pod trunk register <email> and get yourself a freshly authenticated token. Seems to have just expired which can happen with time and little use.

Thank you @Sherlouk
the issue is, I don't know how to re-generate a new token!
No command to do it, and nothing in the guide to automate the process

https://guides.cocoapods.org/making/getting-setup-with-trunk.html
Sorry, feel like a noob here 😅

This isn't a noob moment, this isn't your skill set and that's absolutely fine.
Following the guide you sent above, you're able to run pod trunk register with various parameters (namely your email address). This will send you an email to authenticate and ensure you're the owner of the package with the right permissions.
Once you're fully registered you can run pod trunk me --verbose which will dump out a request to trunk.cocoapods.org. In this you'll see a Authorization: Token XXXXXXXXXXX. The token being what needs uploading to GitHub secets!

it worked 🎉
thank you @Sherlouk ❤


Problem in installing Sbt for macOS12

I am facing problem in installing SBT using my macOs12 with brew.

I am facing problem in installing SBT using my macOs12 with brew.

I generally do not recommend using Home Brew since they seem to do their own thing with Java - https://www.scala-sbt.org/download.html. Personally I use SDKMAN, which works well for me. And what's that to do with this pull request again?


Switch to use DBSError reason/srvCode instead of if/else exception block

Fixes #11365
Status
not-tested
Description
Replace if/else exception block with DBSError reason and server code
Is it backward compatible (if not, which system it affects?)
MAYBE
Related PRs
it is continuation of effort started in https://github.com/dmwm/WMCore/pull/11173 and https://github.com/dmwm/WMCore/issues/10962
External dependencies / deployment changes
yes, it requires new dbs3-client, version 4.0.12

@amaltaro , ok, how about now? I added all existing codes to the code and made appropriate message. Please review.

I think we should check only for the expected error codes, which AFAICT they are:

block already exists
dataset_id not found (missing parent data)
(and it's likely a good idea) datatier does not exist

we should ditch all the others. From what I understand, the transaction on the server side will never yield many of those errors that you implemented. If we see that we are getting hit by another one of those, then we keep adding add. But I would start it with a very small set and stick to that if possible.

@amaltaro , I'm sorry but I disagree with your assessment. The codes I added are possible to hit in DBSUploadPoller, e.g. in order to insert block/dataset an acquisition or processing era should be registered, etc. In other words it is possible due to existing data racing HTTP conditions https://github.com/dmwm/WMCore/issues/11106 that two HTTP requests can overlap and one of the errors I mentioned and implemented may occur in request. In my view it is better to have full coverage now rather than later add yet another code to cover rare case. Please re-consider.

@amaltaro , from good design principle the DBSError class only parses errors and provides details. It has no logic about DMWM workflows or data injection, therefore we should not enrich it with such logic. If block exists in DBS and someone tries to insert it again, it is an error from DBS side, period. But from DMWM point of view it is not since the block exists and we can proceed safely. Therefore, both of your proposals do not appeal to me, and I still think the proper logic is correctly defined  in DBSUploadPoller which knows details about data injection logic.

I have to argue that that long if/elif statement is doing exactly what you mentioned, parsing the error details provided by the DBS server, hence a good design practice would be to encapsulate that same logic into its own class (DBSError).
If you don't want to rewrite the error message, as currently provided in this PR, then I think we can use the output of getMessage method. Code becomes much smaller and mainteinable. This would be my option a) above by the way.

Alan, you should not be upset with if/else because it walks through all possible codes. If you want we can put this into separate function for code clarify. What I'm saying that this function or if/else block does not belong to DBSError generic class because they represent logic of data processing and not code themselves. It is WMCore code which needs this logic and not another way around. The purpose of DBSError is to extract error codes, and get message, but it is not about placing calls to DBS. If we'll put this if/else block into DBSError then we'll need to parse URLs of the calls, while here we know the name (the parameter passed to DBS API) because it belongs here. Think how you'll construct such messages if you'll need to parse all possible DBS URLs along with their parameters.

@amaltaro , I do not want to put this PR aside, please re-read my reply and let me know how would you like to proceed. If you still think that if/else code should be put in DBSError class I'll move it there, but it will not provide details of input API parameters (as I explained in my reply this will require parsing URLs rather taking input parameters from the code as it is right now).

The purpose of DBSError is to extract error codes, and get message, but it is not about placing calls to DBS. If we'll put this if/else block into DBSError then we'll need to parse URLs of the calls...

Valentin, it looks like you misunderstood my previous message. I am not saying that the DBSError class should be in charge of making calls to DBS and/or parsing any URLs.
My point is that the DBSError class is meant to be an object containing a generic DBS error. As such, this is the correct place to define any generic error messages based on the server exit code.
Can you please remind me if it's the message or the reason attribute that will have a short version of the error message (instead of the nested error chain)? My goal here is to replace all those error messages that you defined in the msg variable, according to the server exit code, by something like:
errMsg = f"Failed to insert block: {blockName}, with server error code: {srvCode} and error message: {srvMsg}"

In my opinion, the current proposal should be refactored to something like (very short version...):
if srvCode == 128:
                # block already exist
                logging.warning("Block %s already exists. Marking it as uploaded.", name)
                results.put({'name': name, 'success': "uploaded"})
else:
                errMsg = f"Failed to insert block: {blockName}, with server error code: {srvCode} and error message: {srvMsg}"
                logging.error(errMsg)
                results.put({'name': name, 'success': "error", 'error': errMsg})

In other words, if the DBS server is already providing a clear and meaningful error message - as those that you extensively defined in the if/elif/else statement - then we should simply use that instead of redefining them in this component.

ok, here is what DBS server returns, I only show you relevant parts:
scurl -s "https://cmsweb.cern.ch/dbs/prod/global/DBSReader/datatiers?foo=1" | jq
[
  {
    "error": {
      "reason": "invalid parameter(s)",
      "message": "parameter 'foo' is not accepted by 'datatiers' API",
      "code": 118,
    }.
    "message": "DBSError Code:118 Description:DBS invalid parameter for the DBS API Function:dbs.parameters.CheckQueryParameters Message:parameter 'foo' is not accepted by 'datatiers' API Error: invalid parameter(s)"

Therefore

getMessage method of DBSError class will extract error.message, i.e. "parameter 'foo' is not accepted by 'datatiers' API"
getReason method of DBSError class will extract error.reason, i.e. "invalid parameter(s)"
none of methods of DBSError class will use nested message of DBS error
In case of failed block the getMessage will return Data already exist in DBS, see here and getReason will return fmt.Sprintf("Block %s already exists", bName) see here. In other words, the reason returns actual issue with failure, the message returns generic message. The current PR uses getReason and lists all possible error codes which DBS server can produces during block injection. If you want to replace actual msg lines then we should use bothgetReason and getMessage DBSError methods and server code, since in most cases getMessage is what I added to the code and getReason is actual error returned from DBS database.

If you want to replace actual msg lines then we should use both getReason and getMessage DBSError methods and server code, since in most cases getMessage is what I added to the code and getReason is actual error returned from DBS database.

Thanks for providing this extra information. Yes, then I agree with your statement above.

@amaltaro I made necessary changes to address your suggestion, could you please review my last commit https://github.com/dmwm/WMCore/pull/11375/commits/bbdb136659e0e88c1e4182d259435903015b8db2 and you'll be satisfied I'll squash the changes and we can proceed with this PR.

@amaltaro I made necessary changes, please review. I also saw one unit test failure but I doubt it is related to these changes and I think it is rather unstable one. Please check and advise further.

test this please


The specified Android SDK Build Tools version (26.0.2) is ignored

Issue Description
WARNING: The specified Android SDK Build Tools version (26.0.2) is ignored, as it is below the minimum supported version (28.0.3) for Android Gradle Plugin 3.4.2.
Android SDK Build Tools 28.0.3 will be used.
To suppress this warning, remove "buildToolsVersion '26.0.2'" from your build
android/build.gradle
..
ext {
buildToolsVersion = "28.0.3"
minSdkVersion = 18
compileSdkVersion = 28
targetSdkVersion = 28
supportLibVersion = "28.0.0"
}
...
Environment

"react-native-navigation": "^3.0.0-alpha.10",
"react-native": "0.60.4",

+1

+1


Times New Roman Font on iOS-13 (Xcode-11)

I am facing a weird issue after updating to XCode-11.
Only on the devices with iOS-13 the the font appears to be as TIMES NEW ROMAN. whereas on devices having older versions the font seems to be perfectly fine.
Any help anyone please?

I've faced same issue. You can set textAttiributes to label like below. It's working.
label.textAttributes = [NSAttributedString.Key.font: UIFont.systemFont(ofSize: 17, weight: .semibold)]

I've faced same issue. You can set textAttiributes to label like below. It's working.
label.textAttributes = [NSAttributedString.Key.font: UIFont.systemFont(ofSize: 17, weight: .semibold)]

yep it works, but how can I resolve this new problem?
-> The text is like being cut by some hard stuff


AuthGoogle(fileJson)

Hi
Is it possible for me to use a Json file that is not in Assets (defined in pubspec)? I would like to read a dynamic Json file.
Ex:
await AuthGoogle (fileJson: url)
Thank you
Luciano

Hi. I have addressed this issue in a different package since this seems outdated. See #33
You can check DialogFlowtter to solve your issue.
Greetings

Hi. I have addressed this issue in a different package since this seems outdated. See #33
You can check DialogFlowtter to solve your issue.
Greetings


add width 100% above max width 60%

Otherwise IE11 aligns the notification div to left

Thanks @englishextra the issue has been resolved :smile:


[Frontend-proxy] Add restart policy to compose files

Changes
Added restart policy to compose files for frontend-proxy.
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:

[x] CHANGELOG.md updated to document new feature additions
Appropriate documentation updates in the docs
Appropriate Helm chart updates in the helm-charts

Fixed the Markdownlint problems


[Android] The number of ANR has increased

Environment
It might relates to #389. I have found that the number of ANR has significantly increased.
The log provided by Google Play shows that it is potentially from ViewPager2
so I report an issue here for further investigation.
Description

Reproducible Demo
This is reported by Google Play Console.
After the fix is ready.
Let's see whether the ANR rate is also reduced.

https://github.com/callstack/react-native-pager-view/releases/tag/v5.4.0


docs: Library note on performance when defining instances

This method can improve speed, for example #7434, #7435, #7401, #6874, #7408, #7430, #7435, #7436
Sometimes it slows things dow though, e.g #7431

Sometimes it is better to avoid with, right? Maybe we can explain more here.

I'm writing instructions with this PR in mind. So after that PR it won't necessarily be best to avoid with. However I should maybe include information about how Lean automatically fills in fields that can be found by type class inference and prioritises whatever is given by with. I don't know how much detail to go into about how extends works and how something like CommGroup extends both Group and CommMonoid, but only has a toGroup field and not a toCommMonoid field. I also don't want it to sound like thinking about this is some requirement, I think it's best if most contributors don't have to know this stuff.

My understanding of unification is still mainly anecdotal but this lines up with my expectations.
It might be useful to open this up to a broader discussion on Zulip where we can get some input from core and others.
One point I do know and that is implicit here but might benefit from being made explicit: aligning the inheritance structure for instance construction only matters mainly for data carrying fields.

Lean also seems to really dislike unifying instances constructed using differing patterns. My guess that it has to unfold everything on both sides to reach a common state.

I solicited some expert opinion on Zulip for any potential refinements.

I haven't followed this discussion closely, but a library note like this is good (and we can refine it later with more experience). I presume that this library note is still relevant after lean4#2644?
bors d+

I don't think it is still relevant. Or at least the gains are much less. See #7554 . I haven't had time to investigate more closely, but I will probably close my open PRs.

Some things are still relevant but it's less clear after leanprover/lean4#2644. My guess is that the jumping up the hierarchy by explicitly a data carrying instance at the top might be counterproductive since the improved defeq cache does a much more efficient job of discharging the checks in between and the fact we are forcing unfolded terms is hurting more.

Ok, then feel free to close it.

The issue about def-eq performance is no longer relevant after the lean3 PR. There were commits made to improve def-eq performance that referenced this note that are probably no longer important and could be reversed.There are still a bunch of TODOs in mathlib referencing this PR. The changes they are next to are probably no longer important and could be reversed.


TAJO-2177: In BroadcastJoinRule, the total volume of broadcast tables…

… should be checked before stages are merged.

+1 LGTM.

Thank you for your review.