Typo fix for URL that is bricking the Colab link

Checklist
GitHub

[X] I've given this PR a concise, self-descriptive, and meaningful title
[ ] I've linked relevant issues in the PR body
[X] I've applied the relevant labels to this PR
[X] I've assigned a reviewer

PR contents

[X] I've consulted ivadomed's internal developer documentation to ensure my contribution is in line with any relevant design decisions
[ ] I've added relevant tests for my contribution
[X] I've updated the relevant documentation for my changes, including argparse descriptions, docstrings, and ReadTheDocs tutorial pages

Description

Current link on the tutorial page for 2D UNet One class Segmentation is missing /blob when instantiating a new Colab using the Jupyter notebook file.
We were not able to test this last time interactively until we had pushed the files in the last PR. Should have caught it earlier.
Linked issues

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 69.425%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
4010

Relevant Lines:
5776

💛  - Coveralls


Added icon switching demo for Windows & Linux

Added a simple demo of changing the webview icon at runtime for Windows, as discussed in #686
Ideally, would be great to see this expanded with working examples for Linux and MacOS.
Discussion points:

syso files need to be generated with https://github.com/tc-hib/go-winres. Should they be included in the demo, or just explained in main.go?
The DLL files in https://github.com/webview/webview/tree/master/dll leads to an immediate crash.
#658
#632
The DLL files in https://github.com/webview/webview_csharp/tree/master/libs do appear to work in my limited testing.

Let me know if I can futher assist.

@dandeto do you have a Windows system available? If so, could you give this a test drive and merge it if appropriate? Do you think we should wait until we have support for all operating systems?

Just a heads up I've updated the PR to include examples of icon switching for both Linux and Windows.
The Linux version has seen limited testing on a Lubuntu VM (LXQt frontend), so I'm not sure how well this works on other frontends.
Just reading up on what is involved to get this example working for MacOS. The closest match I could find is setAlternateIconName. Suggests you can only change the icon at runtime to whatever is defined in Info.plist though. Might take a stab at it at some stage, but not a high priority for me at this stage.

Thanks for all the info. I'm not a go programmer, but I'll test this out soon. Sorry for the delay.
Don't people usually set a static icon for their apps? I'm not saying we shouldn't add this example, but I guess I don't exactly know the market for it... is the benefit that the programmer can use a .png file instead of embedding the resources into the binary? At first glance, it seems a little out of scope for a webview example - it is not an example of how to use our library.
I'm also curious to know what @justjosias thinks since he has been here longer than I :)
Thanks for mentioning the DLL issue; I need to take another look at that. Thanks for your work and interest in our project, ldstein!

Don't people usually set a static icon for their apps?

I feel that is a matter of implementation.
In my project, I have a single "launcher" executable with it's own visual identity. "Apps" in my case are code payloads and resolved at runtime - they can downloaded, installed and enabled/disabled. When an App opens a webview, it changes the icon to represent itself, hence my requirement to change the icon of the webview dynamically.

it is not an example of how to use our library.

The "Scrape" example is great to get started, but I feel there is benefit from additional examples covering common Window management tasks for Linux/Windows/MacOS:

Changing the icon (this PR)
Resizing / repositioning the Window
Minimizing / maximizing the Window

Examples feel like a good position to demonstrate how Webview could be used in a real-world application, without adding additional scope to the core code itself.
Helps people like me to get up and running too.
FWIW, I've been using Webview on and off since Nov 2019. Only recently upgraded my project to take advantage of Webview2, hence my currentl level of interest :)

I agree with @ldstein on this one. I like the example, because it shows how the library can be used beyond its maintained API. From reading the issues, quite some people need to touch the native APIs and there is not a whole lot of documentation on it.

After a lot of thought, you guys ended up convincing me! We need an example of how to use the Window() API, and since some have asked how to set icons (including zserge), I think it's a good addition to our examples.
It would be pretty cool to have a cross-platform icon extension in our repo or organization... This is one of those things that I wish we could just use a library for, but I wasn't able to find one. Anyway, your code is approachable for beginners, which is great.
I think explaining the syso files is better than including them. I'll test this real soon and get back to you.

Nice, great to hear.
I've got a minor change I'm intending to add to this PR (not yet pushed):
I'm going to change the icon ID in winres.json from APP to IDI_APPLICATION.  That will then correctly set the default icon without any further configuration.
It was only in the last couple of days did I realise web.h was doing this.
Generating syso files is explained at the top of main_windows.go so hopefully that is enough to get users going.

@dandeto It's working on Linux for me!

Updated dlls from #700 worked for me, by the way, which is assuring.
@justjosias since this is just an example, can we go ahead and merge, or should we wait for mac support?

@dandeto I'd like to talk about and consider examples a bit further, as I'm not sure where we should draw the line at what examples to allow and what not to (and whether we should have examples in another repository instead). This example is useful, but we should probably be clearer on examples in general before merging.

Ah, it would be good to set some boundaries... I understand. Would you like to open that discussion up in an issue or in a chat somewhere? I know we have a gitter and a discord, but they look dead to me. Maybe creating an issue that we can point to for clarity would be a good thing.

@dandeto Let's chat in the Discord for now, since that has been webview's primary development communications system for a while now.

@ldstein, is MacOS support out of the picture for you? We want all examples to be cross platform when possible except under certain circumstances.

@dandeto Sorry, it's looking unlikely in the immediate future due to other commitments.

I reviewed some of our PRs and several have stagnated because of lack of MacOS support. We continue to get people asking about icons. This example follows all other guidelines. For these reasons, I think it is ok to merge this now and hope someone adds MacOS support in the future. I approved this before I should have, so I'll let @justjosias or @SteffenL merge if they agree.

I took a brief look at this just now and I have mixed feelings about merging this. I would have leaned toward not merging this.

Does not support all platforms.
Adds ~3MB to the repository.
It is only useful for Go. What about C/C++?
Do the images have a license that is compatible with MIT?

Some good points there @SteffenL

The 3MB is really due to the binaries associated with the icons. Not sure if this can be avoided.
The artwork in the icons is not compatible with MIT. Hunted my drive but attribution of the indivual images is lost in time. Happy to look into providing MIT compliant equivalents.

Maybe spinning out the current and future code examples to a separate repo has merit?

Making a few images with different solid colors or minimum amount of details should be enough to demonstrate that it works and would keep the size down.
A bigger issue is the license. I don't want to force-push the master branch but I think we should do it ASAP to stay on the safe side. @dandeto @justjosias
I don't mind keeping the C/C++ examples close to the core library but I would support moving all Go code into a separate repository, including bindings if we can do it neatly. It is just more complicated than keeping everything in the same repository. It has been brought up before in #783 with no conclusion.

Okay, you can undo it. I didn't think about the license, sorry. Are you in the discord? We can discuss splitting go from C++ there, because that could turn into a long discussion for this PR.
This is a go example, but it relies on 2 C++ functions which really do all the work, so I thought it was helpful.

I wasn't but now I am!

Turns out that I do not have permission to force-push master and I do not have access to repository settings.

@SteffenL You are now an admin on the rpo.


can this also be used to apply a global filter to all resources themselves?

I went looking for a global filter that would be applicable to all resources. All my resources belong to a "season" and I want to filter them all so it only ever shows data from one season at a time. Can your global filter be used this way? To be clear I'm not interested in using cards on any of my resources.
Thanks!

This packages only filters cards. It does not filter resources. You might want to check this one which could give you what you need.

Thanks. I ended up getting something to work using the default value and the cache. I'll leave this snippet here for anyone else that finds this issue
<?php

namespace App\Nova\Filters;

use Illuminate\Http\Request;
use App\Models\Season;
use Laravel\Nova\Filters\Filter;

class SeasonFilter extends Filter
{
    public function apply(Request $request, $query, $value)
    {
        // ray('SeasonFilter', cache('NOVA-SEASON'));

        cache(['NOVA-SEASON' => $value], now()->addMinutes(60));

        return $query->where('season_id', $value)->get();
    }

    public function options(Request $request)
    {
        $seasons = Season::orderBy('id', 'desc')->get();

        return $seasons->pluck('id', 'name');
    }

    public function default()
    {
        return cache('NOVA-SEASON', config('defaults.latest_season_id'));
    }
}


Fixed: Close button added for signup and login form

Pull Request
Related Issues:
Added close button for both signup and login button.
Fixes #231
Description:
Created separate svg for close icon and added close functionality to signup and login form.
Checklist:

[x] I have tested my changes.
[x] My code follows the project's coding standards.
[ ]
Screenshots:

@chandiran-v perfection!

@chandiran-v perfection!

Thanks, sounds great.


Only show reading time if more than 4 minutes

Closes #282

Thank you @iranzo. We should make the minimum time configurable and set it to a default value.

@talha131 how do we want to name that variable?

How about READING_TIME_LOWER_LIMIT and a default value of 4 min?

Done in last push

Change added to changelog and rebased onto 'next' (I tought this was getting into actual branch)

@talha131 anything missing to address here?

Thank you @iranzo


add: Korean readme translation

Issue Number
#118
Work Details
Korean readme translation

@hagisilm ❤ merged, could we invite you to our team?

@hagisilm ❤ merged, could we invite you to our team?

Thank you so much for the suggestion. I don't use c#.


IPv4Mask instead the number 4

What type of PR is this?
kind featur

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

/lgtm

/lgtm
/approve

/lgtm
/approve

/lgtm

/approve


Add striped style and use table style for deprecated/removed rules too

Added striped table style to all lists of rules in /docs/rules. Also made it so the deprecated & removed rules lists use the same table style as main list of rules above it.
Should look like this now:

Now that I look at it, I'm not sure I like striped table all that much, what we have currently is much cleaner, but pretty much as readable. Maybe we should keep current design (for normal rules, we should still update deprecated and removed tables), but add hover style? This way, if you are having trouble tracing columns, you can always mouse over it to highlight it.
@nzakas What do you think?

@ilyavolodin I agree, I think I also prefer keeping the current design as it is cleaner, and just adding the hover effect. Let's see what @nzakas thinks!

Updated the commit to add colgroups.

Hover only works if you can use a mouse. I like the striping much better than what we currently have.

I wouldn't mind going with the striping. @ilyavolodin what do you think?

Well, if @nzakas feels so strongly, I'm not opposed. Let's go with what we have.

Hmm.. for some reason Jekyll page generation failed with non-descriptive error message. I'm not really sure what to do next...

I pushed an empty commit to force a rebuild and it passed now! 🎉


Couple of questions

Hey,
Thank you for this package, I'm looking forward to digging in.
First question, Is it possible to use this without storing them under one global key? And have them under separate keys?
The reason for this is that I have an existing application where users have info stored in a few different localStorage keys.
Or would you suggest migrating this information into a single key?
~Secondly, is there a way that when a user first loads my app - the data that's already in localStorage is then sync with my store? Can this be done using getState?~
I hope you can help.
Thanks

You can ignore my second question, having dug into it - I can see that the data from localStorage is available in the store when the app gets loaded.
Just my first question I'm still not sure of really, thanks.

Hi @JoeDawson! To answer your first question, if you need multiple root keys, you can initialise the plugin multiple times where each instance has a different key and different paths.

Something like this;
const store = new Vuex.Store({
  plugins: [
    createPersistedState({ key: 'foo', paths: ['foo.reducer.path'] }),
    createPersistedState({ key: 'bar', paths: ['bar.reducer.path'] })
  ]
})

Awesome, thanks so much @robinvdvleuten. Appreciate your help.

Why not to use it by default? Multiple state is acceptable if you want 2-3 PersistedStates. But what if you want more?
E.g.
You have options state with multiple options.
User want to change options separately.
Bad solutions:
You may create one PersistedState for all options and rewrite all options on each change.
Make PersistedState for each option wich will create a lot's of listeners.
Good solution:
Use prefixed keys in PersistedState like options.red = 128, options.green = 255 instead options = JSON.stringify({red: 128, green: 255})


Wrong kind detected

chainloop att add --value ./internal/attestation/crafter/materials/testdata/sbom.cyclonedx.json
INF material kind detected kind=STRING
INF material added to attestation

This should have been an artifact.

I believe this problem is because I am using an inline CAS backend, and the file went over the limit
During detection we should check first if we are failing because of size or because of detection.
cc/ @javirln

I will try to reproduce it locally.

A problem that this issue surfaced is that our string kind doesn't have a max limit. We should add it and in that case the auto discovery will return error. Which is what we expected

How do you foresee to establish a max limit for the STRING, as far as I know the max limit is only set on the CAS backend and it's not configurable.
A default value on a contract's annotation that can be configurable?

What's your take? cc @jiparis


Error message: read_responder_root_public_certificate fail!

I am trying to launch the requester and responder in separate windows.
The request is hitting an issue saying “read_responder_root_public_certificate fail!” (see the log below).
Could you please shed some light on what might have caused the issue and possible solution? Does the issue have something to do with these errors highlighted in blue?
//--------------- Requester log ----------------------
[root]# ./bin/spdm_requester_emu --trans PCI_DOE
spdm_requester_emu version 0.1
trans - 0x2
connect success!

SpdmReceiveRequest[0] msg SPDM_GET_VERSION(0x84), size (0x4):
0000: 10 84 00 00
SpdmSendResponse[0] ...
SpdmSendResponse[0]: msg SPDM_VERSION(0x4), size (0xc):
0000: 10 04 00 00 00 03 00 10 00 11 00 12
Platform port Transmit command: 00 00 00 01
Platform port Transmit transport_type: 00 00 00 02
Platform port Transmit size: 00 00 00 14
Platform port Transmit buffer:
01 00 01 00 05 00 00 00 10 04 00 00 00 03 00 10 00 11 00 12
Platform port Receive command: 00 00 00 01
Platform port Receive transport_type: 00 00 00 02
Platform port Receive size: 00 00 00 1c
Platform port Receive buffer:
01 00 01 00 07 00 00 00 12 e1 00 00 00 00 00 00 c6 f7 02 00 00 12 00 00 00 12 00 00
SpdmReceiveRequest[.] ...
SpdmReceiveRequest[0] msg SPDM_GET_CAPABILITIES(0xe1), size (0x14):
0000: 12 e1 00 00 00 00 00 00 c6 f7 02 00 00 12 00 00 00 12 00 00
SpdmSendResponse[0] ...

Unable to open file ecp384/bundle_responder.certchain.der
Unable to open file ecp384/bundle_responder.certchain1.der
Unable to open file rsa3072/ca.cert.der
SpdmSendResponse[0]: msg SPDM_ALGORITHMS(0x63), size (0x34):
0000: 12 63 04 00 34 00 01 02 08 00 00 00 80 00 00 00 02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0020: 00 00 00 00 02 20 10 00 03 20 02 00 04 20 08 00 05 20 01 00
Platform port Transmit command: 00 00 00 01
Platform port Transmit transport_type: 00 00 00 02
Platform port Transmit size: 00 00 00 3c
Platform port Transmit buffer:
01 00 01 00 0f 00 00 00 12 63 04 00 34 00 01 02 08 00 00 00 80 00 00 00 02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 02 20 10 00 03 20 02 00 04 20 08 00 05 20 01 00
Platform port Receive command: 00 00 ff fe
Platform port Receive transport_type: 00 00 00 02
Platform port Receive size: 00 00 00 00
Platform port Transmit command: 00 00 ff fe
Platform port Transmit transport_type: 00 00 00 02
Platform port Transmit size: 00 00 00 00
Platform port Transmit buffer:
Server stopped

@jyao1  Here is the output of spdm_dump
[root]# ./bin/spdm_dump -r ../../spdm-emu/build/SpdmRequester.pcap
spdm_dump version 0.1
PcapFile: Magic - 'a1b2c3d4', version2.4, DataLink - 292 (PCI_DOE), MaxPacketSize - 65536
1<PHONE_NUMBER>) PCI_DOE(1, 0)
2<PHONE_NUMBER>) PCI_DOE(1, 0)
3<PHONE_NUMBER>) PCI_DOE(1, 0)
4<PHONE_NUMBER>) PCI_DOE(1, 0)
5<PHONE_NUMBER>) PCI_DOE(1, 0)
6<PHONE_NUMBER>) PCI_DOE(1, 0)
7<PHONE_NUMBER>) PCI_DOE(1, 1) REQ->RSP SPDM(10, 0x84) SPDM_GET_VERSION ()
8<PHONE_NUMBER>) PCI_DOE(1, 1) RSP->REQ SPDM(10, 0x04) SPDM_VERSION (<IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>)
9<PHONE_NUMBER>) PCI_DOE(1, 1) REQ->RSP SPDM(12, 0xe1) SPDM_GET_CAPABILITIES (Flags=0x0002f7c6, CTExponent=0x00, DataTransSize=0x00001200, MaxSpdmMsgSize=0x00001200)
10<PHONE_NUMBER>) PCI_DOE(1, 1) RSP->REQ SPDM(12, 0x61) SPDM_CAPABILITIES (Flags=0x001afbf7, CTExponent=0x00, DataTransSize=0x00001200, MaxSpdmMsgSize=0x00001200)
11<PHONE_NUMBER>) PCI_DOE(1, 1) REQ->RSP SPDM(12, 0xe3) SPDM_NEGOTIATE_ALGORITHMS (MeasSpec=0x01(DMTF), OtherParam=0x02(OPAQUE_FMT_1), Hash=0x00000003(SHA_256,SHA_384), Asym=0x00000090(ECDSA_P256,ECDSA_P384), DHE=0x001b(FFDHE_2048,FFDHE_3072,SECP_256_R1,SECP_384_R1), AEAD=0x0006(AES_256_GCM,CHACHA20_POLY1305), ReqAsym=0x000f(RSASSA_2048,RSASSA_3072,RSAPSS_2048,RSAPSS_3072), KeySchedule=0x0001(HMAC_HASH))
12<PHONE_NUMBER>) PCI_DOE(1, 1) RSP->REQ SPDM(12, 0x63) SPDM_ALGORITHMS (MeasSpec=0x01(DMTF), OtherParam=0x02(OPAQUE_FMT_1), Hash=0x00000002(SHA_384), MeasHash=0x00000008(SHA_512), Asym=0x00000080(ECDSA_P384), DHE=0x0010(SECP_384_R1), AEAD=0x0002(AES_256_GCM), ReqAsym=0x0008(RSAPSS_3072), KeySchedule=0x0001(HMAC_HASH))

are you following the step by step in readme?
cd spdm_emu
mkdir build
cd build
cmake -G"NMake Makefiles" -DARCH=<x64|ia32> -DTOOLCHAIN=<toolchain> -DTARGET=<Debug|Release> -DCRYPTO=<mbedtls|openssl> ..
nmake copy_sample_key
nmake

Then "The spdm_emu output is at spdm_emu/build/bin. Open one command prompt at output dir to run spdm_responder_emu and another command prompt to run spdm_requester_emu."  ?

Maybe it's a permissions issue on your system? Some anti-virus software may not like .der files.

You need "Open one command prompt at output dir to run spdm_responder_emu and another command prompt to run spdm_requester_emu"
Please
cd bin
spdm_responder_emu --trans PCI_DOE

and
cd bin
spdm_requester_emu --pcap SpdmRequester.pcap --trans PCI_DOE


[Hub Generated] Review request for Microsoft.VirtualMachineImages to add version stable/2020-02-14

If you are a MSFT employee you can view your work branch via this link.
The private repo PR: https://github.com/Azure/azure-rest-api-specs-pr/pull/1156
Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

/azp run automation - sdk

Can one of the admins verify this patch?

The private repo PR: https://github.com/Azure/azure-rest-api-specs-pr/pull/1156

/azp run automation - sdk

Prettier check of file ListImageTemplatesByRg.json failed, please fix it @rezmicrosoft

/azp run automation - sdk

Prettier check of file ListImageTemplatesByRg.json failed, please fix it @rezmicrosoft

@njuCZ . I have ran prettier against all files, and ListImageTemplatesByRg.json has been resolved. While seems like imagebuilder.json is still failing, but my local prettier shows that this file is good. By the way, my prettier version is 1.19.1.

/azp run automation - sdk

@ravbhatnagar If arm team has signed off this PR, please remove the label waitforarmfeedback and add armsignedoff label


Add length related assertions to StringAssert

Summary
String assertions often concern the string's size. Currently we would have to use something like
assertThat("some string".length()).isGreaterThan(10);

this is not really fluent and allows for semantically incorrect checks like negative String lengths. Instead we would like to use something like this:
Example
assertThat("some string").hasSizeLessThan(10); //< 10
assertThat("some string").hasSizeLessOrEqualTo(10); //<= 10
assertThat("some string").hasMaxSize(10); //<= 10

//analog methods for greater and greater or equals

We are working on this issue at Softwerkskammer Ruhrgebiet Hackergarten

Hi @georgberky
I guess, I'm a bit late with this but you might want to take a look at this PR:
https://github.com/joel-costigliola/assertj-core/pull/1285
This implements most of these methods and not just for String but for all iterables.
@joel-costigliola: any chance that you can review my PR. I know it's a huge one...

@martin-tarjanyi I will to but it's huge.

@martin-tarjanyi you're right, this slipped out of my mind, I will review it to but it's huge so I haven't got the mental energy to do it yet (I'll take care of merging/rebasing on master after this PR is merged).

@martin-tarjanyi Strings are not iterable in Java, so that I think it will not have conflict with your pull request.

@sparsick
I'm aware of that in core Java there is no relation between String and Iterables. But in AssertJ there is an EnumerableAssert class which is a common interface for the string, array, iterables and some other assertion classes.
In my PR I added the new methods to EnumerableAssert and I implemented the methods for all child classes.

@martin-tarjanyi oh I see. Thank you for clarifying.


Functionality change: Move active -f symlink-path to a new command

If a shell tries to set the active path on startup using active -e -f symlink-path and no branch is setup, the returned response will be empty. This doesn't make sense with the symlink as the whole goal is to dynamically point a branch using the symlink, so a new command along the lines of symlink-path should be added.

Done in 9cbd60fd643af98ad6e8c6bb35eb0025a0582e8f


fix: update to http

Pull Request Template
Issue Overview
This PR addresses #1664

[x] This change addresses the issue in full
[ ] This change addresses only certain aspects of the issue
[ ] This change is a dependency for another issue
[ ] This change has a dependency from another issue

Description
Updates the link to http so that image loads
How Can This Be Tested/Reviewed?
See the SW image present on the homepage
Checklist:

[x] My code follows the style guidelines of this project
[x] I have added QA notes to the issue with applicable URLs
[x] I have performed a self-review of my own code
[x] I have reviewed the changes in a desktop view
[ ] I have reviewed the changes in a mobile view
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have assigned reviewers
[ ] I have run yarn generate:client and/or created a migration if I made backend changes that require them
[x] My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
[ ] Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:
Steps to review a PR:

Read and understand the issue, and ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@ludtkemorgan curious for your thoughts on that question

Not the right path based on the vulnerability that Yazeed referenced


CUI-7371 [Accessibility] Coral.Datepicker: Use WAI-ARIA 1.2 Combobox design pattern

Description
Refactor Coral.Datepicker to implement WAI-ARIA 1.2 Combobox design pattern, where the input has role="combobox", rather than the container element.
This PR also includes a fixes to Calendar for to the use case where no value is specified, so that the Calendar table grid is navigable using the keyboard.
Related Issue
Per https://jira.corp.adobe.com/browse/CQ-4292426
and https://jira.corp.adobe.com/browse/CUI-7371
Motivation and Context
Fixes an issue where NVDA get stuck in forms mode and the user is unable to navigate from the input to the dropdown button using the down arrow in browse mode.
How Has This Been Tested?
Tested with VoiceOver on macOS and NVDA on Windows.
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.

Please review: @adobre90, @adobe/coral-spectrum, @icaraps, @mohiaror

Could I get a review: @CezCz, @adobe/coral-spectrum?

Also any particular reason to use coral-dialog in the example ? Would it be possible to use a non coral container in this case ? The example won't work as standalone ie cd coral-component-datepicker && gulp because dialog is not imported.

@icaraps Trying to ensure that closing the Datepicker using Esc key does not also close the Dialog.

@icaraps Please verify. I've removed the dialog example form coral-component-datepicker.


New Asset Explorer Design Proposal

The current assets explorer is a bit of a waste of screen space and needs to switch views.

I made what I thought was a cool asset manager.
https://github.com/vuejs/devtools-next/assets/25154432/de62840f-db8d-4a31-b35b-07e02f2dfa70
What do you think about transforming current resource management into this form?

Hi @YunYouJun, thanks for the nice sharing, the solution is so cool. But for some reasons, we prefer to keep the current design:

For the devtools assets feature, we have some differences with traditional file management (custom preview and action for difference asset type, and extends more features in the future, e.g drag and drop)
It would take a lot of work to refactor it
We plan to reuse some features with nuxt devtools, so we need to align as much as possible.

OK, i got it.
(Of course, it also supports custom actions and drag-and-drop.)


Only apply integ testing scripts when project has integ tests

This reduces the number of tasks created and build scripts evaluated and thus speeds up our configuration time.
Removes about 1/3 of the garbage and 1/3 of the configuration time

@hansd @ldaley since you reported this, here is a build scan after this change.

@oehme under the magic 1s barrier now. Nice.


surface errors in runtimes.manifest configuration in the controller logs

This PR ensures than when runtimes.manifest property is incorrectly configured that the controller prints what the error is in the logs.
Without this PR we would only see in the logs:
[2017-05-17T21:21:53.457Z] [ERROR] [??] [Controller] Bad configuration, cannot start.

With this PR we can see:
Exception in thread "main" java.lang.IllegalStateException: Runtimes manifest is set but it's invalid: spray.json.DeserializationException: Object is missing required member 'image'
	at whisk.core.entity.ExecManifest$.initialize(ExecManifest.scala:55)
	at whisk.core.controller.Controller$.main(Controller.scala:185)
	at whisk.core.controller.Controller.main(Controller.scala)

This is very helpful when debugging issues with the configuration such as the one mentioned at https://github.com/apache/incubator-openwhisk-devtools/issues/29

You can change the method to return the try and then throw the exception in the controller's main.

You can change the method to return the try and then throw the exception in the controller's main.

ExecManifest.initialize is called by both: controller and invoker. would you suggest we impl in both of them ?
Open to your suggestion, but before making the change I want to make sure we're ok to duplicate the code.

There's no point to using a try if this method is going to throw an exception.

I also thought of that but I changed my mind seeing we have 3 operations to Try: parse, flatMap, and map, and the intent is to throw an exception only on error.
Let me know what you think.

The operation that will throw is the json parse; hence removing the try and documenting that the method will throw is all the same. I slightly prefer the return of a Try so it's explicitly known through the types this method can fail and the caller should address failure; yes you'd have to throw in both controller/invoker main but really it would be achieved by just doing a .get in the result for example hence not much duplication at all. But it's fine to just throw here and document it. You will need to adjust some tests iirc.

I slightly prefer the return of a Try so it's explicitly known through the types this method can fail and the caller should address failure

👍 thanks @rabbah . I'll make the changes to be more explicit.

@rabbah I'm done with the changes based on your review. I've also added a unit test with an invalid runtimes.manifest value.

@rabbah thank you very much for the suggestions. I've applied them all.
Only a small diff on else (I personally try to live without it to save indentations, and make the code easier to follow).

@rabbah when you get the chance let me know if there's any other change you'd like before merging.

Are you going to remove or ignore the new test or wait until your consul PR is in?

Ok I thought the test would fail since whisk config reads from consul. I'm surprised it passed. Do you know why?
I can make any small changes for merging. I think the main refactoring is already in place. Thanks for m/taking the suggestions.

Ok I thought the test would fail since whisk config reads from consul. I'm surprised it passed. Do you know why?

Yes, b/c the consul properties are not set when the test runs, WhiskConfig doesn't read them from consul ( https://github.com/apache/incubator-openwhisk/blob/master/common/scala/src/main/scala/whisk/core/WhiskConfig.scala#L167 )

Hmm that's only true if consul isn't actually up.

Hmm that's only true if consul isn't actually up.

Are you referring to the test added in this PR or in general ? B/c the test in this PR doesn't configure any consul properties.

Got it - because you're writing the property file directly you suppress the consul path. Thanks for clarifying.

I've merged with the latest changes from master to include #2278 that fixes the build error caused by java install.

good catch @rabbah. I'm making this change then I suppose we're good to merge here, having your 👍  ?

@rabbah @markusthoemmes thanks for your reviews. I'm done with the changes. Provided the build succeeds, feel free to merge.

PG2/1652 🏃

PG 2/1666 finally 🚀

This is failing repeatedly in jenkins and I don't understand why yet. I can't see how it's related to these changes but I tried several and they all fail in the same way. I will spend some time to investigate. @csantanapr what's the status of an apache jenkins so that then it's easier to share logs or jenkins failures? It would help in this case for example.

Looking through the logs, I think this is just out of date. I'll run a jenkins build off a rebased version.

@rabbah
The ubuntu nodes in Apache Jenkins are shared between all projects and they don't provide root access and do not allow to change the default configuration.
The default configuration is not configured for docker engine is not configure with http API enable on any port i.e 4243
We would need to change all the places we refer to the port to not use the http port and instead use the API over socket file device /vat/... the same API that the docker CLI uses


Fix action name editor position in Input Map

Partially fixes #33206 by positioning the text editor on the label itself

That's not how to solve the problem, I'll open another PR with the clean solution. :)

Cool :), I'll close this now


OTR support

It would be nice if Netty support OTR (Off-the Record Messaging). Currently the secured chat done through SSL, OTR support helps end to end encryption. End to end encryption is becoming popular in many messaging applications.

@gitdaemon sounds interesting.  We love contributions :)

Yeah, sounds like a good addition to Netty.

With the up coming netty 5 we decided to only support "core protocols" by ourself. This kind of stuff could be added to the netty-contribs repo tho


Product Dashboard Slow Response Time

I've encountered some product dashboard slow response times.  It takes up to 3 minutes to load the product dashboard from a single client.  This maxes out the hygieia api container CPU while it is loading the product dashboard.  I traced this issue down to PipelineServiceImpl.java.  When a project has many commits (in our case thousands) it must loop through those thousand commits for each stage and compare the commits to calculate the time it takes to move commits through to each stage.

Affects: <api-version-number>.

https://github.com/Hygieia/api/blob/41ff8c6e4cafef2adb698afd9de46f24ee2534f9/src/main/java/com/capitalone/dashboard/service/PipelineServiceImpl.java#L234-L254

@jacksod1 please feel free to implement the appropriate fix for the issue. We greatly value your contribution


[SYSTEMML-1073] Move maven-deploy-plugin to separate profile

Move maven-deploy-plugin out of distribution profile so that double
deploy doesn't happen when deploy to snapshot repository.
See https://issues.apache.org/jira/browse/SYSTEMML-1073
cc @lresende

@deroneriksson What happen if you just get rid of the profile and then run the script to deploy the snapshot ? If it works, we can basically eliminate this from the pom as the necessary config is already configured in Apache parent pom.

Hi @lresende. I think eliminating this from the pom would be best. I was keeping it in a profile in case it was needed to do the releases. I would be happy to remove this profile/plugin. Thanks for the feedback.

LGTM

Thank you for reviewing @lresende. I'll merge.


Add available volunteer positions section with descriptions to teams page.

Use deck from slack with description and titles. Link to from volunteer page. Ask for the deck, please.

I'll try to work on this.

Ok, thanks @adriennelim :)


add feature on platform to allow LVS to be bypassed for a project or precheck submission

Waiver added, waiting for LVS to go into production.


Inheritance not working

I try to do interface inheritance but the inherited method skipped from the API list...
My interface:
public interface ServiceController<Filter extends Serializable, Result> {

    @POST
    @Consumes(MediaType.APPLICATION_JSON)
    @Produces(MediaType.APPLICATION_OCTET_STREAM)
    @Path("/print")
    @ApiOperation("Print customer grid based by filter and grid configuration")
    Response printing(PrintConfigDTO<Filter> printConfig);

    @POST
    @ApiOperation(value = "Return the customer data defined by filter")
    @Consumes(MediaType.APPLICATION_JSON)
    @Produces(MediaType.APPLICATION_JSON)
    Result filter(FilterDTO<Filter> filter);
}

My implementation:
@Api(value = "/card/list", description = "Card List")
@Path("/card/list")
@Component
public class CardListController extends AbstractController implements ServiceController<CardListFilterDTO, CachePage<CardListItemDTO>> {
//...
    @Override
    public CachePage<CardListItemDTO> filter(FilterDTO<CardListFilterDTO> filter) {
        return cardService.getCardList(new ServiceRequest<>(getCallContext(), filter));
    }
//...

I try to investigate the problem.
I think it's in swagger-jaxrs Reader class.
            for (Method method : methods) {
                AnnotatedMethod annotatedMethod = bd.findMethod(method.getName(), method.getParameterTypes());
                if (ReflectionUtils.isOverriddenMethod(method, cls)) {
                    continue;
                }

So I Can't implement a method? ??? more exactly the implemented method can't be exposed to outside?
The JAX-RS specification allow to use inheritance (and it's works, just not exposed to jersey):
JAX-RS annotations may be used on the methods and method parameters of a super-class or an implemented interface. Such annotations are inherited by a corresponding sub-class or implementation class method provided that the method and its parameters do not have any JAX-RS annotations of their own. Annotations on a super-class take precedence over those on an implemented interface. The precedence over conflicting annotations defined in multiple implemented interfaces is implementation specific. Note that inheritance of class or interface annotations is not supported.
http://download.oracle.com/otn-pub/jcp/jaxrs-2_0_rev_A-mrel-eval-spec/jsr339-jaxrs-2.0-final-spec.pdf

I'm facing the same issue here. Based on the highlighted code snippet, the solution for that seems very easy. :-/


Fails to execute :runApp

Hi there, it successfully built but it fails to run here's the error
Joseph$: gradle runApp

> Task :runApp FAILED
Exception in thread "main" org.openqa.selenium.WebDriverException: Specified firefox binary location does not exist or is not a real file: PATH_TO_TOR_BROWSER_FOLDERTor Browser\Browser\firefox.exe
Build info: version: '3.0.1', revision: '1969d75', time: '2016-10-18 09:49:13 -0700'
System info: host: 'Joes-MacBook.local', ip: '<IP_ADDRESS>', os.name: 'Mac OS X', os.arch: 'x86_64', os.version: '10.13', java.version: '9.0.1'
Driver info: driver.version: unknown
        at org.openqa.selenium.firefox.internal.Executable.<init>(Executable.java:59)
        at org.openqa.selenium.firefox.FirefoxBinary.<init>(FirefoxBinary.java:60)
        at logic.TwitterTask.perform(TwitterTask.java:34)
        at logic.Main.main(Main.java:18)

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':runApp'.
> Process 'command '/Library/Java/JavaVirtualMachines/jdk-9.0.1.jdk/Contents/Home/bin/java'' finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

BUILD FAILED in 2s
3 actionable tasks: 1 executed, 2 up-to-date

Hi,
For sure it fails to run, take a look at the exception:
Exception in thread "main" org.openqa.selenium.WebDriverException: Specified firefox binary location does not exist or is not a real file: PATH_TO_TOR_BROWSER_FOLDERTor Browser\Browser\firefox.exe
You forgot to modify the PATH_TO_TOR_BROWSER_FOLDER constant in the program. This constant should point to the directory where you installed the Tor Browser.

Yes, you need to specify the directory where you have installed the Tor Browserw, because the runnable uses it as an anonymization mechanism.

So
/Applications/TorBrowser.app/Contents/MacOS/firefox
or
/Applications/TorBrowser.app

I'm not sure about the path in macOS (this was meant to run in Linux and Windows) but you should specify the route which has the "Tor Browser\Browser\firefox.exe" in it. This means, that in the path you specify, you should find the folder "Tor Browser", inside that folder, the folder "Browser", and inside that one, the executable firefox.exe.

still not working, i'll try on ubuntu what are the steps for that?


[Request/Discussion] Using Microsoft-recommended "Async" suffixes in MediatR classes

Just wanted to double check if this was intentional or not. Most async methods in MediatR don't have the Async suffix on their names: for example:

IMediator
Task<TResponse> Send<TResponse>(IRequest<TResponse>, CancellationToken)

IRequestHandler
Task<TResponse> Handle(TRequest, CancellationToken)

Microsoft recommends adding the "Async" suffix to all async methods. Is there a chance this will be implemented in MediatR in the future?
I think seeing every other async member with the Async suffix and just MediatR types not having them is actually a bit confusing.

This has already been discussed here #371

This has already been discussed here #371

Thanks @lilasquared . Tried to search but for some reason that didn't come up for me. Looks like MediatR is part of a "rebel group" of libraries not using the recommendation :D. I guess that's fine though, looks like it was a very conscious decision.
Closing this. Apologies for the spam.

@julealgon You might find this an interesting read about "Async" suffixes https://docs.particular.net/nservicebus/upgrades/5to6/async-suffix

@julealgon You might find this an interesting read about "Async" suffixes https://docs.particular.net/nservicebus/upgrades/5to6/async-suffix

Thanks @remcoros . I had already seen that article from NServiceBus before replying earlier.


[NFC] Retire ROCm < 3.7

Removed HCC support from CMake files (except fin and composable_kernels)
Removed HCC support from source code
Removed HipCompilerVersion() - it was necessary for HCC only.
Removed external_tool_version_t - it became useless
WORKAROUND_SWDEV_255735 reworked to a fix
Removed WORKAROUND_MLOPEN_ISSUE_2335 - not relevant since 3.7

See https://github.com/AMDComputeLibraries/MLOpen/issues/2335

Removed WORKAROUND_SWDEV_200782 - not relevant since 3.7
Removed WORKAROUND_SWDEV_220166 - not relevant since 3.7
Removed some checks -- always true since 3.7
Some formatting

CI passed, please review

CI passed, please review


aws-sdk-cpp: 1.8.113 -> 1.8.121

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/aws-sdk-cpp/versions.
meta.description for aws-sdk-cpp is: "A C++ interface for Amazon Web Services"
meta.homepage for aws-sdk-cpp is: "https://github.com/awslabs/aws-sdk-cpp"
meta.changelog for aws-sdk-cpp is: ""
Updates performed

Version update

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 1.8.121 with grep in /nix/store/jn7xq78z2x5dv1i9qyp0h058yvd9r1x3-aws-sdk-cpp-1.8.121

directory tree listing: https://gist.github.com/80b8d88a525ad606080835df4ff16a54

du listing: https://gist.github.com/2a156125e3c275deb6c690a2e0d570df

Rebuild report (if merged into master) (click to expand)

232 total rebuild path(s)

64 package rebuild(s)

64 x86_64-linux rebuild(s)
57 i686-linux rebuild(s)
55 x86_64-darwin rebuild(s)
56 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
aws-sdk-cpp
bundix
cabal2nix
cachix
common-updater-scripts
crate2nix
crystal2nix
dep2nix
disnix
disnixos
dydisnix
fusionInventory
go2nix
haskellPackages.cachix
haskellPackages.hercules-ci-agent
haskellPackages.nix-paths
haskellPackages.update-nix-fetchgit
hercules-ci-agent
hydra-unstable
libnixxml
lispPackages.quicklisp-to-nix
lispPackages.quicklisp-to-nix-system-info
nix
nix-bundle
nix-direnv
nix-doc
nix-du
nix-exec
nix-index
nix-pin
nix-plugins
nix-prefetch
nix-prefetch-bzr
nix-prefetch-cvs
nix-prefetch-docker
nix-prefetch-git
nix-prefetch-hg
nix-prefetch-scripts
nix-prefetch-svn
nix-serve
nix-update
nix-update-source
nixFlakes
nixStable
nixUnstable
nixos-generators
nixos-rebuild
nixos-shell
nixpkgs-review
nixui

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/jn7xq78z2x5dv1i9qyp0h058yvd9r1x3-aws-sdk-cpp-1.8.121 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A aws-sdk-cpp https://github.com/r-ryantm/nixpkgs/archive/aa61094aecb857b61a6d8d765b8f100e4d3d3969.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/jn7xq78z2x5dv1i9qyp0h058yvd9r1x3-aws-sdk-cpp-1.8.121
ls -la /nix/store/jn7xq78z2x5dv1i9qyp0h058yvd9r1x3-aws-sdk-cpp-1.8.121/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package marked as broken and skipped:

nix-exec

1 package failed to build:

hercules-ci-agent

55 packages built:

aws-sdk-cpp
bundix
cabal2nix
cachix
common-updater-scripts
crate2nix
crystal2nix
dep2nix
disnix
disnixos
dydisnix
fusionInventory
go2nix
hydra-unstable
libnixxml
lispPackages.quicklisp-to-nix
lispPackages.quicklisp-to-nix-system-info
nix (nixStable)
nix-binary-cache
nix-bundle
nix-direnv
nix-doc
nix-du
nix-index
nix-pin
nix-plugins
nix-prefetch
nix-prefetch-bzr
nix-prefetch-cvs
nix-prefetch-docker
nix-prefetch-git
nix-prefetch-hg
nix-prefetch-scripts
nix-prefetch-svn
nix-review (nixpkgs-review)
nix-serve
nix-update
nix-update-source
nixFlakes (nixUnstable)
nixos-generators
nixos-rebuild
nixos-shell
nixui
python37Packages.nix-kernel
python37Packages.nixpkgs
python37Packages.pythonix
python38Packages.nix-kernel
python38Packages.nixpkgs
python38Packages.pythonix
python39Packages.nix-kernel
python39Packages.nixpkgs
python39Packages.pythonix
update-nix-fetchgit
vgo2nix
vulnix

Maintainer pings
cc @edolstra @orivej for testing.

hercules-ci-agent is broken on master

hercules-ci-agent is broken on master


Venue class: recruit bad formatted invitees

Catch the group not found error to keep processing other emails.
Some PCs enter the recruitment email as:
behrad moniri <bemoniri@seas.upenn.edu>,Behrad Moniri

The new API is now throwing a group not found on "behrad moniri<EMAIL_ADDRESS>I think we should catch the error and report it in the message.

I would like to create a better regex for this. I could add personalized message in the old API and in the new API you can use the mismatchError property in the invitation to create a custom error message.

I don't know how easy is to create a regex to validate the input.
I was thinking in catching the "Group not found" error from the API and post this errors in the recruitment status note.


Fix layout problem backoffice

The current backoffice shows an odd white void between navigation and main content. The original theme does not:
Original

Current Backoffice

Depends on the size of the screen. The original theme also shows the same void, at full screen. Couldn't discern any visible differences between the template and our back office, except the footer.


QML as a programming language

This pull request sets QML as a programming language as discussed in #1152.

:+1: let's do it.


docs: update ssr.md - server html replacement

Description
appHtml.html is needed in order to correctly replace the html tag of the outlet.
Check the difference before and after the change inside the <div id="root">
Before:

After:

Additional context
appHtml returns an object with the structure {html: ... }.  html contains the html markup in a string.

What is the purpose of this pull request?

[ ] Bug fix
[ ] New Feature
[x] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines, especially the Pull Request Guidelines.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Update the corresponding documentation if needed.
[x] Ideally, include relevant tests that fail without this PR but pass with it.

Thanks for the PR but this guide isn't about React, the render function here is just an example. I think the snippet is more clear as is.


No feedback to the user if login fails on login form

there is currently no feedback to the user whenever the login fail if it is due to the credentials not matching ther should at least be a message telling the user the result

a feedback has been added to the login form to let the user know if the credentials are  not correct


"How to mark a release as newest in pypi"

Hello,
I am owner of ibm_db package that is available here -> https://pypi.org/project/ibm_db/2.0.8/
I had made a new release 2.0.8a that I was thinking to be picked as latest according to timestamp. However, pypi seem to have naming convention according to which it is considered pre-release.
I do not plan to make a new release with new name as I do not have any functional new development and hence it would be considerable effort to make a new release just for changing name.
I am looking forward for some solutions to solve this without making a new release.

is it possible to rename 2.0.8a to 2.0.9?
Would pypi pick 2.0.8a as new release if I delete 2.0.8 from list?
Is there any other possible solution available to have 2.0.8a considered as latest release.

Thanks in advance!

PyPI (and pip, etc) follow PEP 440, which sees 2.0.8a as an alpha release. There's not a way to rename the version and deleting 2.0.8 won't make 2.0.8a be seen as the latest. You'll need to release something 2.0.9 os similar.


[Table] expose tableLayout prop and allow horizontal scroll

This PR enable horizontal scroll in table contents keeping toolbar and pagination components in place.
ref: https://github.com/melfore/mosaic/issues/272

Hi @alessandrotilli you can proceed with merge of this PR 👍

:tada: This PR is included in version 7.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Output formatting

It's all on a single line at the moment. We'll probably run Prettier against it in web, but ideally the output would be more legible out of the box.

This'd also make golden test output diffs more legible.

I guess one way to implement this would be to convert the JS Compiler from Reader Cfg to RWS Cfg () State where State tracks indent level. Then wherever there's an indentable block, like opening a function body in a switch statement, we call a helper indent :: Compiler a -> Compiler a which increments the state, compiles the contents with indentation, and then decrements on the way back out - similar to withPluralCtx in Intlc.Parser.


remoteAuthRole does not allow to add an existing partition as userPartition

Problem: we create virtual servers or services using AS3, which usually results in a new tenant/partition being created. We'd like to use DO to automatically create a remoteAuthRole with the new tenant/partition as value for the userPartition field. The current schema does not seem to allow this. Only a variable retrieving the value from our AAA system is allowed:
userPartition (string | string) - values “all”, “Common”, regex: ^%.+
In the WebUI an existing partition can be chosen as setting for userPartition in the remoteAuthRole.
The solution I'd like:
To be able to create a config like following:
"Common": {
"class": "Tenant",
"Operator_Tenant1": {
"class": "RemoteAuthRole",
"attribute": "CN=MyCN,ldap-path",
"lineOrder": 925,
"role": "operator",
"remoteAccess": true,
"userPartition": "Tenant1"
}
}
I couldn't think of any good alternative solution.
Thanks!

+1 for this.

If it helps, here is an example declaration using a userPartition other than Common or All. Note that as soon as the partition is changed to Common, the declaration works.
{
    "schemaVersion": "1.0.0",
    "class": "Device",
    "async": true,
    "Common": {
        "class": "Tenant",
        "role_guest_homelab": {
            "class": "RemoteAuthRole",
            "attribute": "memberOF=CN=f5_guest,OU=Groups,OU=People,DC=homelab,DC=local",
            "console": "tmsh",
            "lineOrder": 1002,
            "role": "guest",
            "remoteAccess": true,
            "userPartition": "homelab"
        }
    }
}

The error (truncated for readability) looks like this:
{
    "id": "4b5fd6a5-12f9-4f3d-9fc1-86d4ded2a6b3",
    "selfLink": "https://localhost/mgmt/shared/declarative-onboarding/task/4b5fd6a5-12f9-4f3d-9fc1-86d4ded2a6b3",
    "code": 400,
    "status": "ERROR",
    "message": "bad declaration",
    "errors": [
        {
            "keyword": "enum",
            "dataPath": ".declaration.Common['role_guest_homelab'].userPartition",
            "schemaPath": "#/properties/userPartition/oneOf/0/enum",
            "params": {
                "allowedValues": [
                    "all",
                    "Common"
                ]
            },
            "message": "should be equal to one of the allowed values"
        },
        {
            "keyword": "pattern",
            "dataPath": ".declaration.Common['role_guest_homelab'].userPartition",
            "schemaPath": "#/definitions/variableString/pattern",
            "params": {
                "pattern": "^%.+"
            },
            "message": "should match pattern \"^%.+\""
        },
        {
            "keyword": "oneOf",
            "dataPath": ".declaration.Common['role_guest_homelab'].userPartition",
            "schemaPath": "#/properties/userPartition/oneOf",
            "params": {
                "passingSchemas": null
            },
            "message": "should match exactly one schema in oneOf"
        },
        {
            "keyword": "oneOf",
            "dataPath": ".declaration.Common['role_guest_homelab']",
            "schemaPath": "#/allOf/0/then/oneOf",
            "params": {
                "passingSchemas": null
            },
            "message": "should match exactly one schema in oneOf"
        },
        {
            "keyword": "if",
            "dataPath": "",
            "schemaPath": "#/allOf/1/if",
            "params": {
                "failingKeyword": "then"
            },
            "message": "should match \"then\" schema"
        }
    ]
}

The enumerated alowedValues are Common and all. There is also a string pattern match of \"^%.+\. If I change my userPartition value to %homelab (starting with a percentage) the declaration works fine, but obviously my partition name does not start with a % so it doesn't do me any good as it just results in the role being created like so:

I'd be interested to know what the intent of the regex pattern match is, given it requires a % symbol..

The % format was done to satisfy this issue and is for variable substitution as defined in the 'About variable substitution' section on this page.
Does that work for your needs?

Thanks for the info on the meaning of the % symbol. I don't think this will work for me though, as I don't have any external auth system (RADIUS) passing through attributes. To clarify though, I don't suppose these variables can be recognised as LDAP or AD attributes?
F5-LTM-User-Role = 400 (variable).
F5-LTM-User-Partition = App_C (variable).
F5-LTM-User-Console = 1 (variable)

We have the same requirement and are using AD for authentication. The variable substitution did not work with AD (LDAP) and even if it did, having to use one attribute per partition is too limiting and wouldn't scale for us. We really need a way to set the partition directly in DO, just as how it's possible to do via GUI, tmsh, API etc. It makes no sense for it to not be available as an option in DO and is really limiting deployment options in large environments

Created [AUTOTOOL-4018] for internal PM tracking.

Hi
When do you think we have support for using existing Partitions as described by afreudenreich?
In world of automation this kind of tickets should be resolved quick as it have huge benefits as also mention.
Please but some effort to resolve it.
BR
Patric


v1.11 docs: Use stable-v0.14.txt for cilium-cli version

The next cilium-cli release is v0.15.0 with Helm mode as the default installation mode. Continue to use v0.14 cilium-cli for v1.11 docs since we haven't validated v1.11 docs using Helm mode.
Also change the branch name from master to main. The default branch name recently changed from master to main in cilium-cli repo.
Ref: https://github.com/cilium/cilium-cli/pull/1759
Ref: #26430

note to reviews: this is a backport of https://github.com/cilium/cilium/pull/26466. i ended up updating the overall cilium-cli installation instructions to be consistent with v1.12 branch docs.

this pull request only modifies a file under Documentation/ directory, so no need to run the full CI. merging 🚀


Data sampling rate for DHW less than expected

Is the data sampling rate lower for water_heater compared to climate out of interest? I've noticed a definite reduction in the detail shown for my DHW graphs compared to how it used to be. The graphs below show the difference between the two. (unfortunately I have no evidence how it used to be because I deleted the DB table for DHW whilst troubleshooting the stuck temp issue)

btw, happy to give you access to my DHW if it'll help with troubleshooting.
Originally posted by @jarrah31 in https://github.com/zxdavb/evohome/issues/30#issuecomment-466150202

@jarrah31 There should be no difference in sampling for water heaters.

I am chasing this now, will let you know.

Much appreciated! I've been looking at database entries to see if there was any difference between what is sent to influxdb vs the internal HA one, along with creating creating graphs on HA and comparing them to Grafana. So far they look the same which is good as it rules out any external influences.
I'll install the latest 0.9.9 this evening on my v0.88.2 HA build and will let you know if I see any difference.

@jarrah31 I haven't had a chance to work this one out, but I can tell you that there is now a way to get high-precision temperatures from DHW.  Will need an updated client library (which is to be release shortly).

thanks, happy to wait.

@jarrah31 I have discovered why the sensor isn't updating, even though the current temperature is changing in the internal state: in the Wiki:
https://github.com/zxdavb/evohome/wiki/DHW-Tips-(incl.-current_temperature)

NB: the following does not work, see: https://github.com/home-assistant/home-assistant/issues/22197

I am trying to come up with a work-around.

See: https://github.com/zxdavb/evohome/wiki/DHW-and-Current-Temperature

superb, thanks! I'll try it out this evening.


Division by zero error with MEM2

Hi Pieter,
Fist of all thank you so much for making such a great library available! :) I'm very interested in the mem2 spectral reconstruction method, I want to apply it to some of the NDBC buoys. I tried with buoy 46005, calculated a1, b1, a2, b2 and then when I try call mem2 with the newton method I get a "division by zero" error (I don't get the error with the approximate method). This is the code to hopefully reproduce (it's data for buoy 46005 around 2019-01-01T06:40:00):
import numpy as np
from roguewavespectrum.estimators import mem2

a1 = np.array([0., 0., 0., -0.11451185, 0.02321382, 0.0355256, -0.06831404, -0.01628626, 0.07186121, -0.04340932, 0.22063669, 0.22719694, -0.17681756, 0.25762674, 2.57707109, 0.19577926, -0.30335812, -0.20956574, 0.08096926, 0.45583464, 0.31827428, 0.26335838, 0.20007252, 0.32948531, 0.19568714, 0.03844625, 0.16514166, -0.11473725, -0.04188619, -0.32438067, -0.3971411, -0.38201661, -0.17954039, -0.52148479, -0.46452081, -0.49663735, -0.64331846, -0.65844982, -0.72442827, -0.66198318, -0.73543551, -0.68387787, -0.77815412, -0.80428501, 0.7713336, 0.77766768, 0.])
b1 = np.array([0., 0., 0., -0.1356877, 0.21916283, -0.35863009, -0.53704182, -0.61990557, -0.46821151, -0.2370452, -0.62359684, -0.78411146, -0.73088937, -0.73622039, -0.82475137, -0.72289569, -0.6108002, -0.67231534, -0.59771682, -0.23964118, -0.2559738, -0.14705254, -0.10348142, -0.06029439, 0.06742919, -0.22874004, -0.22275163, -0.47270772, -0.49931477, -0.57071301, -0.30641778, -0.70476947, -0.67338229, -0.44430578, -0.73701112, -0.72171528, -0.60376766, -0.61886186, -0.54750874, -0.62896418, -0.41939468, -0.60702357, -0.42178437, -0.37227221, 0.3631924, 0.50327361, 0.])
a2 = np.array([0., 0., 0., -0.00348995, 0.10488985, 0.205, 0.08961493, -0.08344655, -0.04314366, 0.30529731, -0.15961025, -0.46984631, -0.33774991, -0.26492818, -0.64455174, -0.33828934, -0.26473443, -0.20130945, -0.27815516, 0.14720873, 0.07461338, -0.10245242, 0.13667456, 0.10749857, 0.17487336, -0.39282455, -0.20225425, -0.28925442, -0.30760374, -0.41249319, -0.18815093, -0.44916613, -0.59188039, -0.20073918, -0.27, -0.34477043, -0.08940203, -0.11128407, 0.16538241, 0., 0.12362018, -0.14884417, 0.40017996, 0.31954285, 0.28518838, 0.1874334, 0.])
b2 = np.array([0., 0., 0., 0.09993908, 0.25961148, 0.35507042, 0.27580639, -0.03371459, -0.3069831, 0.19077094, 0.01116104, -0.17101007, 0.195, -0.11795363, -0.34271424, -0.12312725, 0.33884462, 0.29845353, 0.11238198, 0.16349186, 0.05032736, 0.58103657, 0.13198509, 0.37489206, 0.27985587, 0.17489676, 0.14694631, 0.34472, 0.08820395, 0.5279672, 0.02644289, 0.35092704, 0.14757236, 0.22294345, 0.46765372, 0.44128602, 0.42060347, 0.44633603, 0.57675702, 0.57, 0.30597067, 0.51908132, 0.51220699, 0.33089631, 0.42280916, 0.65365795, 0.])

Dmem2 = mem2.mem2(
    directions_radians=np.radians(np.arange(0,360,10)),
    a1 = a1[np.newaxis,:],
    b1 = b1[np.newaxis,:],
    a2 = a2[np.newaxis,:],
    b2 = b2[np.newaxis,:],
    solution_method='newton'
)

My question is, do you have any idea where this division by zero might be occurring? And also, is the approximate method less accurate? I tried scipy as well but I got an error when it tried to update the progress_bar here, perhaps it should be something like if progress_bar is not None: progress_bar.update(1)?
Thanks,
Emilio

Hi Emilio!
Thanks for the interest! A word of warning - this is very much a work in progress - and I am still changing things up quite a bit (e.g. estimators is now "private" so for the above code you would have to do from roguewavespectrum.estimators import mem2)
I think I managed to fix both issues - the divide by 0 was a convergence issue I failed to account for; and you correctly identified the solution to the scipy branch. If you update to latest version (and change import) things should work. That said- I would recommend doing the following:
import numpy as np
from roguewavespectrum import create_spectrum_1d

a1 = np.array([0., 0., 0., -0.11451185, 0.02321382, 0.0355256, -0.06831404, -0.01628626, 0.07186121, -0.04340932, 0.22063669, 0.22719694, -0.17681756, 0.25762674, 2.57707109, 0.19577926, -0.30335812, -0.20956574, 0.08096926, 0.45583464, 0.31827428, 0.26335838, 0.20007252, 0.32948531, 0.19568714, 0.03844625, 0.16514166, -0.11473725, -0.04188619, -0.32438067, -0.3971411, -0.38201661, -0.17954039, -0.52148479, -0.46452081, -0.49663735, -0.64331846, -0.65844982, -0.72442827, -0.66198318, -0.73543551, -0.68387787, -0.77815412, -0.80428501, 0.7713336, 0.77766768, 0.])
b1 = np.array([0., 0., 0., -0.1356877, 0.21916283, -0.35863009, -0.53704182, -0.61990557, -0.46821151, -0.2370452, -0.62359684, -0.78411146, -0.73088937, -0.73622039, -0.82475137, -0.72289569, -0.6108002, -0.67231534, -0.59771682, -0.23964118, -0.2559738, -0.14705254, -0.10348142, -0.06029439, 0.06742919, -0.22874004, -0.22275163, -0.47270772, -0.49931477, -0.57071301, -0.30641778, -0.70476947, -0.67338229, -0.44430578, -0.73701112, -0.72171528, -0.60376766, -0.61886186, -0.54750874, -0.62896418, -0.41939468, -0.60702357, -0.42178437, -0.37227221, 0.3631924, 0.50327361, 0.])
a2 = np.array([0., 0., 0., -0.00348995, 0.10488985, 0.205, 0.08961493, -0.08344655, -0.04314366, 0.30529731, -0.15961025, -0.46984631, -0.33774991, -0.26492818, -0.64455174, -0.33828934, -0.26473443, -0.20130945, -0.27815516, 0.14720873, 0.07461338, -0.10245242, 0.13667456, 0.10749857, 0.17487336, -0.39282455, -0.20225425, -0.28925442, -0.30760374, -0.41249319, -0.18815093, -0.44916613, -0.59188039, -0.20073918, -0.27, -0.34477043, -0.08940203, -0.11128407, 0.16538241, 0., 0.12362018, -0.14884417, 0.40017996, 0.31954285, 0.28518838, 0.1874334, 0.])
b2 = np.array([0., 0., 0., 0.09993908, 0.25961148, 0.35507042, 0.27580639, -0.03371459, -0.3069831, 0.19077094, 0.01116104, -0.17101007, 0.195, -0.11795363, -0.34271424, -0.12312725, 0.33884462, 0.29845353, 0.11238198, 0.16349186, 0.05032736, 0.58103657, 0.13198509, 0.37489206, 0.27985587, 0.17489676, 0.14694631, 0.34472, 0.08820395, 0.5279672, 0.02644289, 0.35092704, 0.14757236, 0.22294345, 0.46765372, 0.44128602, 0.42060347, 0.44633603, 0.57675702, 0.57, 0.30597067, 0.51908132, 0.51220699, 0.33089631, 0.42280916, 0.65365795, 0.])

freq = np.linspace(0.05, 0.5, 47)
spectrum = create_spectrum_1d(
    freq,
    variance_density=np.ones((47)),
    a1=a1,
    b1=b1,
    a2=a2,
    b2=b2,
)

spectrum2D = spectrum.as_frequency_direction_spectrum(number_of_directions=36,method='mem2',solution_method='scipy')
values = spectrum2D.values
direction = spectrum2D.direction()

as that follows what I hope to be the intended behavior (it does require adding the frequences and energies as well - for which I put some example values in here).

Oh as an aside- the "newton" solver is faster, but it seems there is a Numba/LLVM bug that can cause issues on M1/M2 processors. So if you are on a Mac be advised you may want to use the scipy path for now.


[Feature Request] tree component nodes support double-click events

Existing Component
是
Component Name
el-tree
Description
树组件节点支持双击事件

When will the version be updated and Whether to include this in the new version?


WIP Move timeout to I/O API.

It turns out that aiocoap doesn't have configurable request timeouts. Need changes there before aiocoap I/O API can have configurable timeouts.

Closes #154

Coverage decreased (-0.2%) to 64.56% when pulling 25db270daf57ef79d078bbeacb49e5fac7f95cc8 on tazle:move-timeout-to-io-api into f2a11b2bb48aef98bfa46ac40721a5aa07a8ad96 on ggravlingen:master.

Coverage decreased (-0.2%) to 64.56% when pulling 25db270daf57ef79d078bbeacb49e5fac7f95cc8 on tazle:move-timeout-to-io-api into f2a11b2bb48aef98bfa46ac40721a5aa07a8ad96 on ggravlingen:master.

We should use https://github.com/aio-libs/async-timeout for asyncio timeouts.

I wonder how aiocoap timeouts and async-timeout will interact, and I don't think that can be tested easily. I can try to add support for timeouts using async-timeout, but I don't think the result will be quite optimal.

@lwis do you have any input here?

Lets leave it as it is for now, if someone wants to add a timeout to a function they can using async-timeout in downstream code.

Thank you for your contribution to pytradfri @tazle! 🎉

Pushed this to pypi yesterday


TypeError after Django Migration

Describe the bug
Exception raised after Django migration, ie
python manage.py migrate within a pipenv
Your code
I can share my django models and migrations and Pipfile if necessary
Expected behavior
A clear and concise description of what you expected to happen.
Output
Exception ignored in: <function Spotify.__del__ at 0x7fb96d7d4680> Traceback (most recent call last):   File "/home/robin/.virtualenvs/moodstream-django-EtsEGWRm/lib/python3.7/site-packages/spotipy/client.py", line 188, in __del__ TypeError: isinstance() arg 2 must be a type or tuple of types Exception ignored in: <function SpotifyAuthBase.__del__ at 0x7fb96d8088c0> Traceback (most recent call last):   File "/home/robin/.virtualenvs/moodstream-django-EtsEGWRm/lib/python3.7/site-packages/spotipy/oauth2.py", line 136, in __del__ TypeError: isinstance() arg 2 must be a type or tuple of types
Environment:

Python version [3.7.0]
spotipy version [2.15.0]

Additional context
Add any other context about the problem here.

I cannot think of anything obvious, it would be useful to get a bit more context:

what is the migration doing?
are you calling del yourself?
can it be reproduced outside a django migration?

I also get the same exact exceptions raised just from having the line import flask in one of my scripts. I haven't actually written anything using Flask yet and the script works fine but the exceptions still occur.

I'm seeing this same issue when I compile to an executable via nuitka, e.g.:
python -m nuitka --follow-imports --standalone program.py
The exact same program.py throws no errors when I run it normally, but once it's migrated to an executable I get the following errors which essentially mirror the above description:
Exception ignored in: <compiled_function Spotify.__del__ at 0x000002566E6B3F10>
Traceback (most recent call last):
  File "C:\Users\<REDACTED>\AppData\Local\Temp\ONEFIL~1\spotipy\client.py", line 188, in __del__
TypeError: isinstance() arg 2 must be a type, a tuple of types, or a union
Exception ignored in: <compiled_function SpotifyAuthBase.__del__ at 0x000002566E7A8130>
Traceback (most recent call last):
  File "C:\Users\<REDACTED>\AppData\Local\Temp\ONEFIL~1\spotipy\oauth2.py", line 156, in __del__
TypeError: isinstance() arg 2 must be a type, a tuple of types, or a union

This is with Python 2.10.3 and Spotipy 2.19.0 on Windows 10


[Suggestion] filterBotsInScores

I'd change it to test if the bots are whitelisted or not because scicraft and many other servers use teams for thier bots

former members and trials aren't counted then

then at least make a "bot" team and not just no team


rename to vvv-sites

@jeremyfelt how about extending the scope of this repo to vvv-sites?
That way we can provide a more diverse set of sites

I am currently working on a way to do this, at present a repo like this will be provisioned all or nothing (not ideal) for now this should be left as is or split into 4 repos.

How to see this new site in vvv.dev. I see the new source files in vvv-multisite but no actual site up and running. Do I need to provision within that directory?

@cfoellmann @LoreleiAurora I'm going to close issues on this repository. Let's use https://github.com/Varying-Vagrant-Vagrants/VVV/issues/1070 to discuss its future.


Update cm calls

Clean up the colormaps portion of NCL_vector_4.py script to remove deprecated matplotlib functions and unnecessary code.
Closes #505.

Ok, so I removed the commit unpinning matplotlib for now (until I can address the re-registration issue in viz).
I'm not quite sure what happened here with the readthedocs build failing...  Going to rerun these tests in a minute.  Doesn't look related to this PR and everything should pass w/ this minor (tested) change.
I did also poke around a bit and I'm not sure if the GitHub actions configuration options/behavior changed at some point, but we aren't actually assigning the Python version on which to run the tests (non-unique to this PR).  I think I can fix that relatively quickly though.

And the readthedocs fail was just a fluke 🎉 .  Thanks @anissa111 for helping me get that sorted!
I still need to put in that CI PR to fix the Python version thing, but this should be good.  Happy to wait thought if we'd rather fix CI first.

Great! I'm curious why it's now not getting failures when your commit didn't touch those files.

Wait, which failures?  The new gv function ones?
I pulled out the unpinning of matplotlib, which caused the initial failures.  CI was then using Python 3.11 and a newer matplotlib for everything so must be related to something in that env.  With the matplotlib version pin now it's using Python 3.10 and passing.

Yes the new geocat viz ones. Glad it's working!

Yeah, I imagine those might come back up once we unpin matplotlib and the tests run on a broader range of Python/dep versions.


[new series] website development

[x] jwt

[ ] middleware
[x] cors
[x] http1
[ ] ssl/tls

[ ] openAPI, swagger
[x] grpc, rest-ful api

[ ] grpc: http post link
[ ] rest: jwt post link
[x] implementation github link

[x] cors
[ ] xss, sql injection
[x] cache(finished in https://ambersun1234.github.io/posts/networking-http1/#cache)
[ ] envoy
[ ] middleware

CORS: blog 引用圖片失敗

https://www.envoyproxy.io/docs/envoy/latest/start/sandboxes/grpc_bridge
https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/grpc_http1_bridge_filter#config-http-filters-grpc-bridge
https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/other_protocols/grpc#arch-overview-grpc
https://www.envoyproxy.io/docs/envoy/latest/configuration/observability/access_log/usage
https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/http/grpc_web/v3/grpc_web.proto
https://www.envoyproxy.io/docs/envoy/latest/configuration/observability/access_log/usage
https://www.dictionary.com/e/ingress-vs-egress/

Middleware
GIN - MIDDLEWARE (中間件) 程式運作原理及用法教學
Middleware

http xhr request will still work even Access-Control-Allow-Crendential header is not set
need to check it after a while


Compatibility with Hydrogen 2023.10.x

When integrating hydrogen-sanity with @shopify/hydrogen 2023.10.2 I receive the following errors after referencing hydrogen-sanity in the server file.
`✘ [ERROR] Could not resolve "url"
node_modules/eventsource/lib/eventsource.js:1:20:
  1 │ var parse = require('url').parse
    ╵                     ~~~~~

The package "url" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
✘ [ERROR] Could not resolve "events"
node_modules/eventsource/lib/eventsource.js:2:21:
  2 │ var events = require('events')
    ╵                      ~~~~~~~~

The package "events" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
✘ [ERROR] Could not resolve "https"
node_modules/eventsource/lib/eventsource.js:3:20:
  3 │ var https = require('https')
    ╵                     ~~~~~~~

The package "https" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
✘ [ERROR] Could not resolve "http"
node_modules/eventsource/lib/eventsource.js:4:19:
  4 │ var http = require('http')
    ╵                    ~~~~~~

The package "http" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.
✘ [ERROR] Could not resolve "util"
node_modules/eventsource/lib/eventsource.js:5:19:
  5 │ var util = require('util')
    ╵                    ~~~~~~

The package "util" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "platform: 'node'" to do that, which will remove this error.`
I worked through a variety of solutions w/ no success. Has anyone else encountered this issue?
Thanks

Same issue here, I added node polyfills to remix config to make it work:
// remix.config.js

module.exports = {
  ...,
  serverNodeBuiltinsPolyfill: {
    modules: {
      http: true,
      https: true,
      events: true,
      url: true,
    }
  }
}

It would be better to completely remove Node.js built-in modules from the package as Hydrogen targets worker runtime. Adding node polyfills almost doubles the worker function size.

Eh, not the answer I was hoping for but ultimately, a decent step towards a functioning app.
Mahalo

Ran into it as well. Will take your approach @thomasKn but I guess I'll use it only during development and wait for a new release which will fix it. I mean, doubling worker size will hurt loading times, right?

Ran into it as well. Will take your approach @thomasKn but I guess I'll use it only during development and wait for a new release which will fix it. I mean, doubling worker size will hurt loading times, right?

Yes but there is also a worker size limit that you need to be careful about

Isn't this eventsource package used by @sanity/client ? That could be a huge upset since I don't see that being fixed pretty soon..

It is being used by @sanity/client - always one step behind...


Changed import of @yamada-ui/lucide in navigation of Storybook to *Icon.

Description
Correct the writing style deprecated with this PR.
#3358
For example, fix the parts in stories/components/data-display/calendar.stories.tsx that are not imported in *Icon format.
- import { Ghost } from "@yamada-ui/lucide"
+ import { GhostIcon } from "@yamada-ui/lucide"

Problem Statement/Justification
Because it's deprecated.
Proposed Solution or API
No response
Alternatives
No response
Are you willing to participate in implementing this feature and create a pull request include the implementation?
None
Additional Information
No response

Hey, I would like to work on this

@slusy
Yes Please!


minimize.energy_tolerance: 0

LAMMPS accepts minimize.energy_tolerance = 0.
Ref. https://docs.lammps.org/minimize.html,
but aiida-lammps doesn't.  How about accepting it also in aiida-lammps if possible?
Excuse me that I can't follow the code and I'm not sure whether it is supported or not in the 'devel' branch. Is it better to write in 'Discussions' page?

Hi @nim-hrkn!
Sorry for the very late reply. We have been working into refactoring the code so that these kind of issues cannot happen anymore. Feel free to look at the development version of the code, in there you can setup the energy tolerance to whatever value you choose.

@nim-hrkn This is now possible in the latest release if you have any more problems feel free to open the issue again.


GitHub API Walkthrough

Overview
Understand the GitHub API integration
Action Items

[x] Get an idea of the framework using the test link
[ ] Refer and get hands-on with the Brigade Project Status Index Board
[x] Read about GitHub API: developer documentation

Resources
Testing the GitHub API
Brigade Project Status Index Board
GitHub API Docs

Created API documentation for GitHub APIs consumed in github-test-api.
PR
@ExperimentsInHonesty

Working on Brigade Project Status Index Board
Understanding the procedure of consuming the GitHub API and the use of Memcached


Has anyone obtained the same results as in the paper? From the code it looks like the Adapter is not added to the training？

Adapter is not added to the training or am I misunderstanding the code?
the model is init in:
https://github.com/tianrun-chen/SAM-Adapter-PyTorch/blob/62a83a48b254fdd0cfb71e8be8df87dfa0d5a9d8/train.py#L96-L111
In config file, the code chooses 'sam', and the 'sam' model is defined in 'models/sam.py'.
In the forward of sam:
https://github.com/tianrun-chen/SAM-Adapter-PyTorch/blob/62a83a48b254fdd0cfb71e8be8df87dfa0d5a9d8/models/sam.py#L169-L191
Use "self.image_encoder" to get image embedding, this sub-module is defined in 'ImageEncoderViT', it is implemented in ‘models/mmseg/models/sam/image_encoder.py’. In this file, I just can't find any implemented about adapter, only see one variable that is not being used ‘self.adapter’.

I have the same question, it seems that "self.adaptor = adaptor" was not referenced after the assignment.

不就是mlp吗，用了self.mlp，不知道我理解有错不

yep, and I can't find the code for the High Frquency component using FFT

@tianrun-chen Can you please help with this. Can you let us know where we can find the code for the adaptor?

I think it's implemented as prompt-generator in ImageEncoderViT.

In './models/image_encoder.py', the class ImageEncoderViT

same question

Please Check
models/mmseg/models/sam/image_encoder.py


Support max_duration argument in cupyx.time.repeat

The PR looks good, lets fix the arg name!

Jenkins, test this please

Jenkins CI test (for commit 770b5ca47ff0de3b41c3ef64f137acf8e6778aab, target branch master) succeeded!


rock-dkms package disappeared from the repo

Hi! I wanted to install ROCm recently on some cluster machines but install fails due to a missing package.
$ sudo apt-add-repository 'deb [arch=amd64] https://repo.radeon.com/rocm/apt/debian/ ubuntu main'
...
$ sudo apt install rocm-dkms
Reading package lists... Done
Building dependency tree
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 rocm-dkms : Depends: rock-dkms but it is not installable
E: Unable to correct problems, you have held broken packages.
$ apt search rocm-dkms
Sorting... Done
Full Text Search... Done
rocm-dkms/Ubuntu <IP_ADDRESS>500-56 amd64
  Radeon Open Compute (ROCm) Runtime software stack

$ apt search rock-dkms
Sorting... Done
Full Text Search... Done

Browsing through https://repo.radeon.com/rocm/apt/ I saw that neither the debian (latest?) nor 4.5 folders have the rock-dkms package in them. 4.3.1 does. I installed the runtime in a docker container just Yesterday and it worked.

I seems that they are replaced with amdgpu-dkms and amdgpu-dkms-firmware. At least that what the new install script (sudo amdgpu-install --usecase=hiplibsdk,rocm) installs.

Also facing the same issue as original poster, using Ubuntu 20.04.3 LTS.

Hi @MathiasMagnus
Thanks for reaching out.
Installation procedure got changed from ROCm 4.5 and request to follow the new steps documented @ https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation_new.html
There will not be rock-dkms anymore and its replaced by amdgpu-dkms.
Thank you.

@ROCmSupport your link is formatted incorrectly

Hi @erkinalp,
Link is correct only. But request to copy and paste in browser window instead of clicking directly.
Thank you.

I've been googling for a while and still can't figure out how to install rocm on a stock ubuntu machine.
These packages don't exist:
$ sudo apt install amdgpu-dkms amdgpu-dkms-firmware
Reading package lists... Done
Building dependency tree
Reading state information... Done
E: Unable to locate package amdgpu-dkms
E: Unable to locate package amdgpu-dkms-firmware

There's no information in the docs on how to install rock-dkms or get past this error.
Why was this closed?  There's no solution.

rock-dkms is no more now and its amdgpu-dkms now.
Request to follow the installation procedure @ https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation_new.html#rocm-installation-guide-v4-5
Thank you.

Late to this discussion, but this doesn't help with RPMs that still require rock-dkms:
$ rpm -qRp rocm-dkms-<IP_ADDRESS>502-sles152.164.x86_64.rpm
warning: rocm-dkms-<IP_ADDRESS>502-sles152.164.x86_64.rpm: Header V4 RSA/SHA1 Signature, key ID 1a693c5c: NOKEY
/bin/sh
/bin/sh
/bin/sh
/bin/sh
rock-dkms
rocm-core
rocm-dev
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

That RPM was downloaded from https://repo.radeon.com/rocm/zyp/4.5.2/.
I'm trying to set up an automated install, and the fact that rock-dkms is required but cannot be found is breaking unattended installation.  I'm working with SLES systems.

We get that, but fails as signature has now expired.


Generating embeddings without serving up the model checkpoint each time

Hello,
Gobbli is a fantastic package. I've been trying to use it in some of my work. One issue is it seems like the BERT checkpoint is being loaded at each call of embed(). This makes the embedding generation take 20-30 seconds on my machine.
Is there a way to "serve up" this model so that subsequent calls to embed() don't have to load the model checkpoint each time? Or would this require quite a bit of restructuring?

I'm glad you're finding gobbli useful!
You're correct that each call to embed() does a lot of work, although it's not just loading the checkpoint -- it's also writing all your data to disk and reading it in the container, then writing all the embeddings to disk in the container and reading it outside.  Depending on how big your dataset is, that might be taking more time.
There isn't currently a way around this -- I'd consider it a fundamental limitation of gobbli's design.  If latency is important to you, you may want to look into something like https://github.com/hanxiao/bert-as-service, which is better-suited for serving lower-latency responses.  gobbli was only intended for experimental/batch workloads and was more designed to help you quickly determine if a model will work in a production situation rather than serving a production model.
It would be theoretically possible to rework gobbli's model Docker containers into e.g. REST API services (as opposed to single run batch processes) which could be spun up once and repeatedly used, but this would be a fair amount of work, since we'd have to essentially build a mostly-same-but-slightly-different API server within the constraints of a host of different Python environments.  I don't see that happening any time soon.
I'll leave this issue open for discussion for a bit, but I don't think there's much we can do about it in the near-term.

Thank you so much for that response Jason. I had a suspicion this was the case and it makes sense why it's a technical challenge.


Location or radius does not work

Location or radius does not work... @EQuimper, could you tell me what I'm doing wrong?
<GoogleAutoComplete                      apiKey={API_KEY}                      debounce={500}                      minLength={3}                      language="es"                      queryTypes="establishment"                     location="37.1848024, -5.7753099"                     radius="35000"                     components="country:es"                 >

Hey @JorgeMoralesLopez did you try radius={35000} ?

@JorgeMoralesLopez Can you try version 0.1.6 :)

I have tried in all possible ways, radius = {20000} the console throws at me Warning: Failed prop type: Invalid prop radius of type number supplied to GoogleAutoComplete, expected string, I do not know how to put location location = "37.1848024, -5.7753099", or location = {{lat: 37.1848024, lng: -5.7753099}}
I have the version "^ 0.1.5" installed, I will try the one you tell me.
Thank you!

yes this one also take the version as a string. So you can do radius="35000"

I have installed version 0.1.6 and location does not work. Do not have any examples with radius and location working? He already tried it.

@JorgeMoralesLopez the version 0.1.6 was just a fix for radius. I'm currently working on the location right now

Ok, I did not understand well ... Thanks!

No problem my mistake

Please, when it is fixed, let me know, and if it is going to cost you a lot of time also to be able to look for another alternative. It is a feature that I need urgently.

@JorgeMoralesLopez Can you try version 0.1.7
I add props call latitude lat: number longitude lng: number if one is pass both are need.

@EQuimper, now if the location works. But the radius does not work, it appears in the list very distant establishments.
Radius tried it as a string and as a number.
I appreciate your effort!

Can you give me a picture of the response you get and the props you pass if possible. So location work just the radius ?

Sorry I didn't see this last message, summer is a crazy thing ...
Thank you!
Only the first result enters the range, radius ... The others do not.
It is true that the first is the closest.

Hi there, this is an issue I am also facing.
When passing the prop radius, I am able to see inside of the react-native-google-autocomplete/dist/GoogleAutoComplete.js that the radius is being passed (And can be logged to the console).
However this makes no difference, i get a list of global addresses, using version 0.1.6 currently.

I will check for the issue. Maybe google did change something with their api. Will check that

Yes, the radio feature doesn't work because searches for very far places appear by putting radius = "50000" for example. If this could be fixed it would be great.

Has this been fixed? Sorry to be a pain this is a vital part of the API though

According to the Places API:

Location restrict
You may also restrict results to the region defined by location and a radius parameter, by adding the "strictbounds" parameter. This instructs the Place Autocomplete service to return only results within that region.

Otherwise, you would get only prefered result by location and radius but not restricted by the area.
I will try to make PR

I have changed to another API, sorry.
Get Outlook for iOShttps://aka.ms/o0ukef

From: fuzexjj<EMAIL_ADDRESS>Sent: Monday, December 7, 2020 3:50:46 AM
To: AppAndFlow/react-native-google-autocomplete<EMAIL_ADDRESS>Cc: Jack Blundell<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [AppAndFlow/react-native-google-autocomplete] Location or radius does not work (#22)
External email to Cardiff University - Take care when replying/opening attachments or links.
Nid ebost mewnol o Brifysgol Caerdydd yw hwn - Cymerwch ofal wrth ateb/agor atodiadau neu dolenni.
According to the Places API:
Location restrict
You may also restrict results to the region defined by location and a radius parameter, by adding the "strictbounds" parameter. This instructs the Place Autocomplete service to return only results within that region.
Otherwise, you would get only prefered result by location and radius but not restricted by the area.
I will try to make PR
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAppAndFlow%2Freact-native-google-autocomplete%2Fissues%2F22%23issuecomment-739646332&data=04|01|blundelljj%40cardiff.ac.uk|7986c6f6076a43d5510d08d89a634877|bdb74b3095684856bdbf06759778fcbc|1|0|637429098493352468|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=yiRqGimV7pS3rvCywhOZljx0NOAC8R6sHfuTSQghf68%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMCWGWUFWCQYFDFGKWOSOX3STRGJNANCNFSM4H5JHWGQ&data=04|01|blundelljj%40cardiff.ac.uk|7986c6f6076a43d5510d08d89a634877|bdb74b3095684856bdbf06759778fcbc|1|0|637429098493362458|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=ecqylaLFfUH2nxV1z9CJaUbXJWlYNBQNJGaTaiptG9o%3D&reserved=0.


Investigate problematic visually similar images

We've had a couple of reports of problematic visually similar images.
The images in question don't look particularly similar to a human, but do have some limited colour similarities that should not be enough to have them appear as visually similar images.
We should perform an initial investigation as to why these images are appearing and what we can do to improve the model. We may need to also increase the threshold required to display an image as visually similar.
Slack thread: https://wellcome.slack.com/archives/C8X9YKM5X/p1658310838492189

some things to discern and visualise:

[ ] the distribution of highest scores for x random images in the collection, using the blended similarity metric
[ ] how the scores of the problematic matches compare to that distribution. could we solve the problem by setting a reasonable threshold similarity?
[ ] how much of the bad matching is down to palette similarity, and how much is related to the features?
[ ] can we produce better matches by boosting the scores for features/palettes?
[ ] how do the LSH scores compare to exact cosine similarity for those bad matches?
[ ] does the approximate-nearest-neighbour matching in elasticsearch 8 do any better?
[ ] does extracting clusters with eg dbscan, which leaves out poorly-clustered data points do any better at LSH matching?
[ ] is the problem with the features themselves? could we do any better by extracting features with a different network backbone?
[ ] is any candidate actually better? can we prove it using elo-style comparison etc?

scores for the most similar image, for 1000 randomly chosen images

Statistic
Value

mean
852.234550

std
457.023707

min
214.409360

25%
478.300000

50%
730.812350

75%
1141.242475

max
2546.215000

scoring the problematic matches:

the match between {'source_id': 'fdgrjrwb', 'target_id': 'v75jmdmc'} gets a score of 268.3973
the match between {'source_id': 'dwhuv3ph', 'target_id': 'cg7hzgv8'} gets a score of 244.78856

We show 6 similar matches in the image modal. Scores for the top 6 for another 1000 randomly chosen images:

Statistic
0
1
2
3
4
5

mean
805.663409
680.741450
647.117353
622.758611
607.618408
595.415108

std
447.583576
374.179087
364.052818
355.968056
352.783572
350.241211

min
207.642960
203.781980
187.570050
184.856670
173.226070
169.811940

25%
464.282765
401.164182
377.921843
363.498445
350.860665
344.204062

50%
663.031220
563.406435
524.253205
500.598565
485.957535
472.531535

75%
1047.624250
860.295825
806.941750
785.379488
759.093130
744.427825

max
2510.807400
2326.201700
2300.046000
2251.751700
2204.464600
2194.731200

Without seeing examples of images with different scores, just from the two examples and the percentiles it seems like our threshold is far too low?
I would rather we didn't display similar images when we can't hit a high threshold, rather than always try to include them and end up with a poor set of suggestions.

summarising what i spoke about with @jtweed earlier
Here's the explain response for  {"source_id": "fdgrjrwb", "target_id": "v75jmdmc"}
The palette contributions are a much smaller part of the total score than we expected. For the other example (dwhuv3ph / cg7hzgv8), the result is even more extreme.
Because the results aren't particularly visually similar, my hypothesis is that we're seeing a lot of bad matches in the lsh features. This might be happening because we use k-means clustering, which doesn't allow weakly connected points to fall outside the clusters and remain unlabelled. The sklearn docs of this effect in action.
If we imagine a super simple dataset with two major clusters in a 2d feature space:

Here's a very basic illustration of what we get with k-means

and what we should really be looking for

Switching from k-means to OPTICS or DBSCAN would allow us to keep all of our existing query patterns in place while significantly limiting the number of poor matches within each feature subspace, and thereby limit the number of visually dissimilar results on the site.


Throw TypeError when appropriate

Whenever you throw an error because a value is not of the expected type, it's more specific and therefore more informative to throw a TypeError. Plain Error constructs aren't wrong per se, just more generic.
This already happens in a few places, like lib/reportes.js#L32, but not in other cases, like lib/reporters/markdown.js#26.

I agree 😄 . Feel free to add a PR for it


feat: add 'issues' as available event for 'ping'

Related to #134

@SantiMA10 just resolve the conflicts and we're good to merge :)
Nice job!


Sidebar rename and Admin page rename

Sidebar ‘Service-Learning’ to “Course Management”
Admin page header to “Designated Service-Learning Courses”

PR merged, closing issue.


Updating documentation to Asciidoc

Here are two files updated, along with the .gitignore to support Visual Studio Code editing. Let me know if the styling and updates are acceptable, more to come on the examples.

Hey Ryan,
Very very happy to see you around.
I'll merge that in.
Thanks a lot


Mark custom asserts as helpers for nicer line numbers in tests

Helper marks the calling function as a test helper function. When
printing file and line information, that function will be skipped.

Go 1.9 added this, so it's safe to use

Approved, as soon as the tests pass feel free to merge it =]

@VinGarcia Appreciate it -- I don't have permissions to hit the merge button though 😁

Oh weird, I thought you would after I had approved it xP


refactor(services/sled): migrate to test planner

@Xuanwo Meet some wired panic. Would you help me take a look?

I've given different paths to different jobs.