Add FailFast that triggers when commit reaches "unreasonably large" value like 3GB

Should be something embedders can disable without rebuilding.

@VSadov can you take a look at this.  Thanks.

Will take a look. Can't assign to myself yet though...

Is that in addition to JsSetRuntimeMemoryLimit or to change the behavior to track committed memory?
I think it might be more common to care about committed size than about reserved VM.

Currently we have configurable behavior on OOM; by default we failfast on OOM, so this might be exactly the right mechanism here.

Yes, we do currently failfast on OOM. I can't find where the behavior is configurable though. Is that through some JsRt ?

It's controlled through EnableFatalErrorOnOOM in https://github.com/Microsoft/ChakraCore/blob/master/lib/Common/ConfigFlagsList.h#L1172
In debug and test builds you can pass flags to chakracore to toggle that value, but in release builds it looks like we don't allow configuring it without recompiling.

Yes, just found it - JsRuntimeAttributeDisableFatalOnOOM

JsCreateRuntime can pass the attributes. I do not think it requires rebuilding, but the behavior is set once the runtime is created. Host still can change the limit.

I think we actually have all what is requested in the bug.
The only caveat is that the default limit is -1 , which is unlimited and that is what documentation specifies, so I am not sure we want to change that.
Perhaps we just want to set the limit to be 3GB in ch.exe and tell hosters to do the same?


Fix middleware checking in preflight handler

Hi, this is a quick fix for better handling cors middleware when defined in a middleware group. This PR addresses #113, #112, #110.
PhpUnit tests run smoothly, and I tested manually with:

Laravel 5.1/5.2;
Lumen 5.1/5.2.

@barryvdh are you going to accept this PR?

Let me know if it works better now ;)

@barryvdh all good. Will you be tagging the latest master as v0.8.1? Thanks!

Hi,
also experienced similar problems with  v0.8.0 . However the fix above did indeed work

@barryvdh WIll you be tagging a release that includes this?

Yes tagged!


[Enhancement][OSF Meeting] Enable Search on OSF Meeting  Front Page

Purpose
Enable search in OSF meeting front page
Resolve [OSF-4994]
Changes
It is a simple change since treebeard has already implemented search. The thing we need to do is to config it.

Set show filter as true
Select column that need to be searched

Before Change:

After Change:

Side Effect
None

Pass complete, no bugs found :star:
Verified that appropriate columns are filterable. Merge conflicts are trivial; target : '_blank' was added to the mithril call for custom: function() {...} on author and confName in submissions.js. Should be easy enough to resolve at merge, so putting this in RtM.


Unable to reinstall Openmake Remote Agent on Windows Server

I'm trying to get the agent up and running on a new Windows Server 2012 machine. The license file for Openmake containing the name of the new server has been installed. When I try to run the Meister.exe to start the install I am not able to click on the links to install the remote build agent files or the client files.
The new server was cloned off of an existing Windows Server 2008 machine that already had the Openmake Remote Agent installed on it. I couldn't configure the agent to run with the new server name so I figured uninstalling and reinstalling the Openmake Remote Agent would help.

Steve Taylor was able to resolve the issue


Modal positioning not quite right until window resize

Hello!
I'm really impressed with this plugin - it's very nice.
I am noticing a strange behaviour with modal positioning.
I have tried multiple configurations with the attributes and position attributes, but with no luck. It happens if I set
position: { y: 'center', x: 'center' }
or if I set
position: { y: 'center', x: 'center' }, // or bottom/right or '0'/'0'
attributes: { y: 'top', 'x': 'left' } // or bottom/right
Modals that should be center/center are appearing lower than center.
Some modals that should be bottom/right are appearing lower, whereas others have a gap at the bottom.
For example, I have a window height of 1103, the height of the modal is 402 (which leaves 701), but the top position of the modal is 466
If I change the size of the browser by dragging the edge, the positioning of all modals is recalculated and looks perfectly centered. Here's a quick screencast: https://goo.gl/De9wkG
I am using the master branch as of 06 May 2017.
If you can shed any light, I would really appreciate it, as it's otherwise the best modal/lightbox plugin I've ever seen :-)

Hmm, this is strange behaviour. Is there any change for me to get a look at some code?
Or, could you reproduce the issue in jsfiddle. You can fork this one which has all the files included already https://jsfiddle.net/StephanWagner/ov6d6960/

Hey Stephan - thanks for the reply.
I was playing with this further and I'm pretty sure it's because of a sticky header on my site. The modal position was too low by 50% of the height of my sticky header + 10px (I'm not sure what the 10px is yet). That, and it positions perfectly on tablet view, when the sticky header is disabled.
The point is - I don't think I can successfully reproduce inside JS Fiddle.
With regards to code
    /**
     * Set popup params
     *
     * @since 1.0.0
     * @access private
     * @method _getPopupParameters
     * @param popup Object
     */
    _getPopupParameters (popup)
    {
        return {

            /**
             * Set the content element
             */
            content:            $(`#${WPDPopupConfig.wpdPopupCpt}-${popup.id}__content`),

            /**
             * Set the ID
             */
            id:                 `${WPDPopupConfig.wpdPopupCpt}-${popup.id}`,

            /**
             * Add a class to the wrapper
             */
            addClass:           `${WPDPopupConfig.wpdPopupCpt}-${popup.id}__container`,

            /**
             * Set popup dimensions
             */
            width:              popup.settings.width,
            height:             'auto',

            /**
             * Set the position & attributes
             */
            position: {
                x:              popup.settings.popup_type === 'fly_out' ? popup.settings.fly_out_x_position : 'center',
                y:              popup.settings.popup_type === 'fly_out' ? popup.settings.fly_out_y_position : 'center'
            },

            /**
             * Configure the design
             */
            overlay:            popup.settings.popup_type === 'modal',
            zIndex:             popup.settings.popup_type === 'modal' ? 9000 : 8900,

            /**
             * Configure animations
             */
            animation:          WPDBBPopupsFrontEnd._getAnimationParameters(popup),

            /**
             * Configure scroll attributes
             */
            blockScroll:        popup.settings.popup_type !== 'fly_out',
        }
    },

I instantiate jBox with the above params and then invoke .open() manually.
I think it's OK, and as per the docs, but it is just the sticky header which is causing a bit of an offset.
Thanks @StephanWagner

@StephanWagner - Perhaps I'm going slightly mad but I just rechecked, and contrary to my last message, the positioning is the same with NO sticky header... (ie it's bad until I manually adjust the screen size).
I can setup a private demo/example, if you'd like. Just let me know what you need.

If I have access to an url where I can have a look at the source code, that should be enough for me to start debugging.

Definitely strange behaviour! I'm having trouble debugging though as the frontend.js is minified. Could you send me the file unminified or the part which initialises the jBoxes<EMAIL_ADDRESS>


Update to postcss8

Some apis of postcss5 have been deprecated, and will case following warning:
postcss-px-to-viewport: postcss.plugin was deprecated.

I upgraded it from postcss5 to postcss8, and test cases are all passed.
The main modifications are to use exports.default = creator instead of exports.default = postcss.plugins(name, creator), and remove var postcss = require('postcss'); in index.js.

Seems this PR can fix #73 #81 #83, @KODerFunk could you spent a little time to review it?


Strike Select - Should not use doneRendering event

The doneRendering code needs to be moved to an afterRender in the renderer. The doneRender code only needs to be ran once, but its currently running infinite times and causing infinite loops under certain conditions.

It appears we need to use the doneRendering event to handle the addition of options through a callback. In this case we need to also make sure that the doneRender checks to see if there is a v.value as well as a v.valueLabel otherwise when a component gets destroyed its stuck in an infinite loop due to not having a label, but theres no value to set a label.

expect this to be resolved in our next release, added the check for v.value.

@chewy2 I think I ran into this issue today with version 0.9.0 of the select component. I started receiving the error below in certain circumstances. Is this the same thing?

Here's the specific offending code/function in file strike_selectHelper; more specifically this line component.get('v.body').forEach(function(child) {
    getChildOptions: function(component, event, helper) {
        var options = [];

        component.get('v.body').forEach(function(child) {
            if ($A.util.isUndefined(child.select)) {

                var childOptions = helper.getChildOptions(child, event, helper);

                options = options.concat(childOptions);
            } else {
                options.push(child);
            }
        });

        return options;
    }


For annualised PAGE: control resulting changes in variables

We should take closer looks at some variables, compare the annualised and non-annualised time series and post the results here as well as flag potential bugs.
I just ran the model for the first time in the annualised version and checked only the te_totaleffect variable from EquityWeighting.jl. Compared to the master branch, it dropped by 7%. Besides some deviations due to interpolation, I think a possible reason is that each timestep in the non-annual version represents the years before and after it (e.g. 2150 for 2125-75) but 2300 only represents 2275-2300 because . As impacts should be higher in 2300 than for any previous year, this should lead to upward bias which is corrected by the annualisation.

Interpolation issues and considerinations --- Population
In PAGE-ICE, population growth is assumed to be zero after 2100 [see picture].
Currently, with the linear interpolation, growth rates are nonzero for the period 2101-2149.
There are two options here:

This is not similar to the original PAGE-ICE and could be manually set to be 0 to conform with the way the picture looks.
Since "letting growth rates fall to zero" seems a more natural assumption than "growth rates are zero after 2100", this change to the model actually seems pretty easy to defend and might even be considered an improvement.

N.B. In this change, interpolation happens between years of analysis. However, this is problematic if one would think of the years of analysis to be an average of the period around that year.

GDP: The (linear) interpolation of parameters including growth rates blows up GDP by 2300 by ~75%.

As pcGDP growth rates converge to zero over time, using, say, 2200's GDP growth rate for 2151-2200 results in lower growth than using interpolated rates for each year. This will remain an issue even if we switch to exponential interpolation for the growth rate parameters.

Global Temperatures
Global temperature smoothes out but no considerable differences due to (linear) interpolation. Temperature is down by 0.03C by 2300 in the annualised version.

GDP
The (linear) interpolation of parameters including growth rates blows up GDP by 2300 by ~75%.

As pcGDP growth rates converge to zero over time, using, say, 2200's GDP growth rate for 2151-2200 results in lower growth than using interpolated rates for each year. This will remain an issue even if we switch to exponential interpolation for the growth rate parameters.

This is because of both higher values in GDP and Population for the interpolated years in this version, since original PAGE-ICE uses the static growth rate of t-1 for calculation GDP,Population at t=1.

I switched the way we interpolate SSP growth rates: Now we use the value for 2030 for 2021-2030 and so on which matches the way the default model works. As a result, we perfectly match GDP and population time series now and deviations in costs are largely reduced.

However, there are still some differences: Total discounted impacts (td_totaldiscountedimpacts in EquityWeighting.jl) is now at 6.8e8, for the default model it's 7.5e8. Adaptation costs (tac_totaladaptationcosts) are at 2.77e6 compared to 2.81e6 which seems a negligible difference. Abatement costs (tpc_totalaggregatedcosts) are at 3.06e7 compared to 3.32e7.
We should track down where they come from.

Forcings:
CO2 forcing and emissions are virtually identical apart from the obvious smoothing effect.
Methane forcing changes slightly, looks like a minor parameter is affected by the annualisation.

LG forcing is virtually identical
N20 forcing is virtually identical apart from the obvious smoothing effect.
Sulphate forcing is virtually identical


solr cloud backup gcs

I have created solrcloud using the yaml defined below
`apiVersion: solr.apache.org/v1beta1
kind: SolrCloud
metadata:
  name: example
  namespace: dev-backend
spec:
  backupRepositories:
    - name: "gcs-backups-1"
      gcs:
        bucket: "vipul-test-bucket" # Required
        gcsCredentialSecret:
          name: "newsecret"
          key: "my-key.json"
  replicas: 3
  solrImage:
    tag: 9.0.0`

I am taking backup of my solr collections in gcs bucket
My solr backup yaml is as below
apiVersion: solr.apache.org/v1beta1
kind: SolrBackup
metadata:
  name: gcs-backup
  namespace: dev-backend
spec:
  solrCloud: example
  repositoryName: "gcs-backups-1"
  collections:
    - demo
    - test
    - new

My backup is starting but not getting anything on my bucket it is empty.
Also my solrbackup is not getting completed it is as follows
NAME           CLOUD     STARTED   FINISHED   SUCCESSFUL   NEXTBACKUP   AGE
gcs-backup     example   60m                                            60m
local-backup   example   4h20m     true       true                      4h20m

I firstly created a pvc backup it got completed but my gcs backup is started but not finishing also no data in my bucket

As mentioned in your slack thread, you are seeing the following error:
ERROR	controller-runtime.manager.controller.solrbackup	Error while taking SolrCloud backup	{"reconciler group": "[solr.apache.org](http://solr.apache.org/)", "reconciler kind": "SolrBackup", "name": "gcs-backup", "namespace": "dev-backend", "error": "Recieved bad response code of 500 from solr with response: {\n  \"responseHeader\":{\n    \"status\":500,\n    \"QTime\":258},\n  \"error\":{\n    \"metadata\":[\n      \"error-class\",\"org.apache.solr.common.SolrException\",\n      \"root-error-class\",\"org.apache.solr.common.SolrException\"],\n    \"msg\":\"specified location / does not exist.\",\n

The Backup command requires a location field, and the operator uses "/" as the default location. This works nicely with S3, since "/" can be used as the root node. With GCS "/" and "" are both valid starts to paths, so you would need to create the "/" path yourself.
Another option to move forward is to specify a real "location" in the backup, or the GCS repo spec, and manually create that path in GCS before starting everything.

I encountered the same problem on GCS backup. I solved the first part as you said with first creating a path and then pointing the baseLocation there. Counter-intuitively it needs to be written without a preceding slash. The backup is now created (files and folders) but the backup still doesn't complete. It remains in a pending status indefinitely.
I see no errors in the log.
This is the describe result for the backup:
Name:         local-backup9
Namespace:    sop030
Labels:       <none>
Annotations:  <none>
API Version:  solr.apache.org/v1beta1
Kind:         SolrBackup
Metadata:
  Creation Timestamp:  2023-04-08T12:37:18Z
  Generation:          1
  Managed Fields:
    API Version:  solr.apache.org/v1beta1
    Fields Type:  FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .:
          f:kubectl.kubernetes.io/last-applied-configuration:
      f:spec:
        .:
        f:collections:
        f:repositoryName:
        f:solrCloud:
    Manager:      kubectl-client-side-apply
    Operation:    Update
    Time:         2023-04-08T12:37:18Z
    API Version:  solr.apache.org/v1beta1
    Fields Type:  FieldsV1
    fieldsV1:
      f:status:
        .:
        f:collectionBackupStatuses:
        f:solrVersion:
        f:startTimestamp:
    Manager:         solr-operator
    Operation:       Update
    Subresource:     status
    Time:            2023-04-08T12:37:18Z
  Resource Version:  330672
  UID:               23ea0f0b-0db7-412d-943f-e3ca58bda906
Spec:
  Collections:
    dsearch
  Repository Name:  gcs-backups-1
  Solr Cloud:       explore
Status:
  Collection Backup Statuses:
    Async Backup Status:  notfound
    Backup Name:          local-backup9-dsearch
    Collection:           dsearch
    In Progress:          true
    Start Timestamp:      2023-04-08T12:37:18Z
  Solr Version:           8.11.0
  Start Timestamp:        2023-04-08T12:37:18Z
Events:                   <none>```


Can't select Checkbox from non-reactive array

ElementUI version
Latest
Vue version
Latest
Reproduction Link
http://codepen.io/diemah77/pen/vgNdBa?editors=1010
Steps to reproduce
I'm trying to display a list of checkboxes from a non-reactive "items" Array set in Vue's created hook.
What is expected?
Each selected checkbox shows selected state.
What is actually happening?
Only the border of the checkbox turns blue without the "checked" icon. The pen also shows native checkbox input example that works.

it's because the non-reactive "items". You should add a the 'items'  in component data options


feat: update to eye v9.4.7

feat: update to eye v9.4.7

:tada: This PR is included in version 12.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release
v12.1.0

Your semantic-release bot :package::rocket:


RelaxNG content model validation no longer works

Expected Behavior
When tags are present that invalidate the content model, DITA-OT 3.1.3 would issue errors:

$ ~/dita-ot-3.1.3/bin/dita -i t.dita -f xhtml
Error: Failed to run pipeline: [DOTJ012F][FATAL] Failed to parse the input file 'file:/mnt/c/Users/chrispy/Documents/DITA/xml_books/dg_tclug/t.dita'.: [10:31] element "foobar" not allowed here; expected the element end-tag, text or element "b", "boolean", "cite", "data", "data-about", "div", "dl", "draft-comment", "fig", "fn", "foreign", "hazardstatement", "i", "image", "imagemap", "indexterm", "indextermref", "keyword", "line-through", "lines", "lq", "note", "object", "ol", "overline", "ph", "pre", "q", "required-cleanup", "simpletable", "sl", "sort-as", "state", "sub", "sup", "table", "term", "text", "tm", "tt", "u", "ul", "unknown" or "xref"

Actual Behavior
In DITA-OT 3.3, no content model violations are issued. Instead, there are strange messages issued and the transformation completes "successfully":

$ ~/dita-ot-3.3/bin/dita -i t.dita -f xhtml
[pipeline] [DOTX074W][WARN]: No formatting defined for unknown class attribute value "".
[pipeline] [DOTX074W][WARN]: No formatting defined for unknown class attribute value "".

Possible Solution
Unsure.
Steps to Reproduce
Validate the attached file as follows:
dita -i foobar.dita -f xhtml
foobar.zip
Copy of the error message, log file or stack trace

[pipeline] [DOTX074W][WARN]: No formatting defined for unknown class attribute value "".
[pipeline] [DOTX074W][WARN]: No formatting defined for unknown class attribute value "".

Environment
Windows Subsystem for Linux (Ubuntu 18.04) on Windows 10
DITA-OT 3.3

The empty @class values suggests that the RNG DITA compatibility support library is not being used.

Confirmed and closed as user error.

Yes, this was it. I assumed the RelaxNG enhancements in 3.2 meant that this
was no longer needed. I'll close the issue. Thanks!

Chris

On Tue, Mar 12, 2019 at 11:10 AM Eliot Kimber<EMAIL_ADDRESS>wrote:

The empty @Class https://github.com/Class values suggests that the RNG
DITA compatibility support library is not being used.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dita-ot/dita-ot/issues/3252#issuecomment-472037787,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJnP1cETXtgGvJdUjfpx_2YXaKaIc-7Kks5vV8NbgaJpZM4brHJI
.

@chrispitude DITA OT 3.3 out out the box expands DITA class attribute values based on the RelaxNG schemas associated to the topic but it does not provide on the fly validation at publishing time of the XML content. @jelovirt, was there an issue to also provide validation at publishing time for RNG-based topics or should we keep this one?

If I was getting empty @class attribute messages (""), does that mean
@class wasn't getting populated by default as expected in DITA-OT 3.3?
Here was the closed issue that led me to believe validation was implemented:
https://github.com/dita-ot/dita-ot/issues/2019
On Wed, Mar 13, 2019 at 1:53 AM Radu Coravu<EMAIL_ADDRESS>wrote:

@chrispitude https://github.com/chrispitude DITA OT 3.3 out out the box
expands DITA class attribute values based on the RelaxNG schemas associated
to the topic but it does not provide on the fly validation at publishing
time of the XML content. @jelovirt https://github.com/jelovirt, was
there an issue to also provide validation at publishing time for RNG-based
topics or should we keep this one?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dita-ot/dita-ot/issues/3252#issuecomment-472289780,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJnP1YmqcSPjKJimgeX5nhSiKU-RhDWcks5vWJJ3gaJpZM4brHJI
.

@chrispitude your original report is from what I understood for a RNG-based DITA topic which somewhere inside has an XML element named "foobar" which is not defined in the schema. As I said in my last comment, the class attribute values should be expanded automatically on all DITA elements which have a correspondent in the RNG schema but for that particular element not defined in the schema no class attribute value will be set. So #2019 was partially implemented, class attribute values are automatically expanded but validation problems (like elements not defined in the schema) are not reported and do not break the build.

Okay, I think I understand now. I would argue that an empty @class
attribute should be a blocking error even if true RelaxNG content model
validation is not performed, but I understand the need for backward
compatibility. And the point is moot once validation is supported and the
unknown element becomes a validation error.
With the closure of issue #2019 ("Support RELAXNG parsing and validation"),
there is no longer an open issue requesting RelaxNG validation. I will
open one.
Thanks guys!

Chris

On Wed, Mar 13, 2019 at 8:15 AM Radu Coravu<EMAIL_ADDRESS>wrote:

@chrispitude https://github.com/chrispitude your original report is
from what I understood for a RNG-based DITA topic which somewhere inside
has an XML element named "foobar" which is not defined in the schema. As I
said in my last comment, the class attribute values should be expanded
automatically on all DITA elements which have a correspondent in the RNG
schema but for that particular element not defined in the schema no class
attribute value will be set. So #2019
https://github.com/dita-ot/dita-ot/issues/2019 was partially
implemented, class attribute values are automatically expanded but
validation problems (like elements not defined in the schema) are not
reported and do not break the build.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dita-ot/dita-ot/issues/3252#issuecomment-472397728,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJnP1Ugf6e9DOjcqA7ZA6RT12Vg8xgcMks5vWOvOgaJpZM4brHJI
.


feat : Cache sponsor images and speaker's thumbnails

Fixes #1326
Changes:
Display thumbnails and sponsor images when app is offline by providing more cache.
Only use this picasso instance for displaying thumbnails and sponsors.

@Shailesh351 There are other images like event background and logo, which I think should be cached too

@iamareebjamal  @arp95 @shreyasnbhat @rohanagarwal94 Please review

Please resolve conflicts @Shailesh351

@iamareebjamal resolved conflicts


add experimental gRPC implementation

This is a partial implementation of the Bazel Remote Execution API's
ActionCache, ContentAddressableStorage interfaces, as well as the
corresponding bytestream interface.
This is not ready for production use! I do not expect this pull request to land as-is, I'm mostly just looking for some early feedback.
Implements #64

Note: I haven't figured out how to build this with bazel yet (hence the buildkite failure), but linux-build.sh works for me.

Updated the PR to include bazel build support, but I had to resort to committing remote_execution.pb.go and semver.pb.go (with a couple of modified paths) to avoid dependency hell.
https://github.com/bazelbuild/remote-apis/blob/c0682f068a6044f395a7e28526abe1de56beffa8/build/bazel/remote/execution/v2/BUILD
depends on "googleapis" which is declared in
https://github.com/bazelbuild/remote-apis/blob/c0682f068a6044f395a7e28526abe1de56beffa8/WORKSPACE
as:
http_archive(
    name = "googleapis",
    build_file = "BUILD.googleapis",
    sha256 = "7b6ea252f0b8fb5cd722f45feb83e115b689909bbb6a393a873b6cbad4ceae1d",
    strip_prefix = "googleapis-143084a2624b6591ee1f9d23e7f5241856642f4d",
    urls = ["https://github.com/googleapis/googleapis/archive/143084a2624b6591ee1f9d23e7f5241856642f4d.zip"],
)

But that zip file does not contain a BUILD.googleapis file, nor any BUILD files with the required targets ("google_api_annotations_proto" et al). I suspect that "googleapis" is intended to be taken from this repository instead:
https://github.com/bazelbuild/bazel/blob/a8353612b4791531ae4e2ed463cf0e5d8a4009e8/third_party/googleapis/BUILD.bazel
I wonder if I should file an issue for this in https://github.com/bazelbuild/remote-apis ?

I found the magic incantation in github.com/bazelbuild/remote-apis-sdks, removed the .pb.go files.

Added GetTree and GetCapabilities.

Hi @mostynb thanks for the PR. I ll try to get to review it soon!

No problem. I'm still working on my test environment- do you know if it's possible to use bazel with remote caching via gRPC but not remote execution?

@mostynb yes it is possible and works the same was HTTP:  --remote_cache=grpc://<host>:<port>

Oh, nice- this allows me to do some real testing, and I immediately found a few bugs to fix. Pushed a new commit that:

dropped an incorrect size check in GetActionResult. Aside: GetActionResultRequest.ActionDigest's SizeBytes field seems useless- do you think this is worth documenting in the .proto file?
fixed an infinite loop in the bytestream Read function
removed a noisy log

Now I am able to build bazel-remote using bazel with remote caching (via grpc), and then rebuild and get cache hits for everything except one ActionCache item at the end (I need to investigate to see why that is). I will also look for a other projects that use bazel for more testing.

@mostynb As you are probably aware, you can compare your implementation to https://github.com/buildbarn/bb-storage/tree/master/pkg/cas.

I have seen that, though I haven't tried running it yet.
Right now I'm comparing bazel-remote using http and grpc, they both seem to give correct results on small bazel projects (like bazel-remote itself, and copybara). But I get quite low cache hit rates for larger porjects like kubernetes. I'm trying to figure out if this is non-deterministic/irreproducible builds on the kubernetes side, or a bug on the bazel-remote side.

Simply increasing my test cache size made the cache hit rate when building kubernetes go up to ~98%.
It turns out that the cached blobs are simply larger than I expected (maybe a golang thing?)- some larger than a gigabyte, and many larger than 10M.

Pushed an update with a bugfix in the bytestream Read function- the offset was being ignored, and when bazel received too much data back it would send back a new invalid Read request (offset larger than the size of the blob). With this fix, I can now build/rebuild large projects like kubernetes without errors.
My testcase:
bazel build --remote_cache=grpc://my.cache.server:9092 --remote_timeout=240 -- //... -//vendor/... -//build/rpms/...
The large timeout value seems to be required due to the large blobs mentioned previously.  I wonder if this is reporting as an issue to kubernetes (probably not worth caching >1G tarballs containing large go binaries).
Build performance is comparable to bb-storage, though I have not done any performance optimization yet.
TODO: read large blobs in chunks before sending them to the client, instead of buffering the entire thing.

Pushed an update which avoids buffering entire blobs in the bytestream implementation, and adds some tests.

Thanks @mostynb !


fully_conv in vgg16

Very good repository.
How did you make this work ? it seems that vgg16 does not have the fully_conv keyword in torchvision
vgg16 = models.vgg16(pretrained=True,
                            fully_conv=True)

oh nvm, you have a forked version of torchvision issue solved!


MacOS - Container action is only supported on Linux

Getting this error on MacOS
Container action is only supported on Linux
Is MacOS not supported?

It seems it is indeed not supported due to use of Docker. Maybe useful to put that information somewhere (I reckon Windows would also not work then).


When using Harlow lib in web app, multiple requests of geojson will results in exception about simultaneous file access.

Solution: Make sure that all statements that have 'new FileStream' also include 'FileAccess.Read' parameter to allow multi-threads to call FeaturesToJson simultaneously.

Sorry for the slow response, and thank you for the pull request.  Good catch.


KMSP doesn't generate new departures

I get the initial batch then nothing after even handling ~30 arrivals. Will get on video soon.

This appears to be due to the departure frequency setting in kmsp.json.  It is currently set to 2 where, as a comparison, KSFO is set to 38.

The ATC repository is being migrated to it's new home at https://github.com/openscope/openscope,
and thus, all issues are being closed. If this is still an issue with the latest version of the sim
(accessible at http://www.openscope.co), or is a feature you still think we are lacking,
please reopen the issue at the new repo.
Please note that the vast majority of these issues have been copied to the new repository, or else are covered by other issues created there. See the below screenshot for what it looks like when your issue is known in the new repo:

Thank you!
Closing this issue.


How to select the Best Markets out of GeoLift Results?

Bug description
On running the GeoLift package with 80 markets, the model is giving like 1000 combinations among which Rank 1 shows that the AvgScaledL2Imbalance = 0.54 which is a very high value. I believe AvgScaledL2Imbalance is almost like the model fit and a value very close to 0 would indicate a good and unbiased model fit.
Q1) Need to understand how does the model gives this ranking? Like on what factors does the model gives the ranking? In my case

"the rank 1 shows a AvgScaledL2Imbalance of such high value (0.59) and rank 500 shows the lowest AvgScaledL2Imbalance (0.02)" - which is an confusion.
Q2) The model is giving a Power of 1 to all the 1000 combinations. How does the model give power of 1 to all combinations?
Q2) How to select the best markets out of all these 1000 combinations? Please tell us what factors to look at when deciding the best markets that would give us stat sig results? Like can we compromise on the RANK column i.e. even if the higher ranking options like rank 5000/1000 is a having a very low AvgScaledL2Imbalance score, can we go with that option (or) should we consider the model with higher ranks itself?
Its really confusing here, because the initial rankings which model is giving most of them are having high AvgScaledL2Imbalance values, power of 1. And some of the higher ranking i.e. 500/1000 are having lowest AvgScaledL2Imbalance value.
Kindly suggest please. Thank you!

Session information
Please paste the output after running sessionInfo() in your R session.

library(GeoLift)

GeoLift_PreTest <- read.csv('geo_lift_transformed.csv')

GeoTestData_PreTest <- GeoDataRead(data = GeoLift_PreTest,
                                   date_id = "week",
                                   location_id = "DMA",
                                   Y_id = "traffic",
                                   X = c(), #empty list as we have no covariates
                                   format = "yyyy-mm-dd",
                                   summary = TRUE)

GeoPlot(GeoTestData_PreTest,
        Y_id = "Y",
        time_id = "time",
        location_id = "location")

MarketSelections <- GeoLiftMarketSelection(data = GeoTestData_PreTest,
                                           treatment_periods = c(35,42,49,56,63), #Duration
                                           N = c(10, 15, 20, 25), # Markets
                                           Y_id = "Y",
                                           location_id = "location",
                                           time_id = "time",
                                           effect_size = seq(0, 0.25, 0.05), #Lift
                                           lookback_window = 1,
                                           holdout = c(0.2, 1.0),
                                           cpic = 60,
                                           alpha = 0.05,
                                           Correlations = TRUE,
                                           fixed_effects = TRUE,
                                           side_of_test = "one_sided"
)

Reproduction steps
We have 3 columns in our data i.e. week, DMA and traffic. The traffic data is present across multiple DMAs at a weekly level. We are passing all this data to the GeoDataRead to get data in our required format. Once that is done passing it to the GeoLift package with the below arguments :

treatment_periods : c(35,42,49,56,63) which indicates we want the model to test it out across 5, 6, 7, 8, 9 weeks of testing
N = c(10, 15, 20, 25) which indicates we want the model to test it out across 10, 15, 20 and 25 DMAs in the test markets.
effect_size = seq(0, 0.25, 0.05) which indicates we want the model to test for effect size ranging from 0 to 0.25 in increments of 5%.
Holdout = c(0.2, 1.0) which indicates we want the model to test with holdouts ranging from 20% to 100% holdout.
cpic = 60 is a value which we have given based on previous experimentations.

Expected behavior
I believed that the RANK 1 should be having a very less AvgScaledL2Imbalance value and would be reliable to pick those markets in order to get statistical significant results. But right now, I see the opposite trend in the model where initial ranks are having a AvgScaledL2Imbalance of high value and higher ranking options are having a AvgScaledL2Imbalance value of lowest. How can this happen? And how do we select the BEST markets among all options?
## Output

duration = 49
Effect Size = 0.05
Power = 1
AvgScaledL2Imbalance = 0.59
Holdout = 0.79
Rank = 1

Additional context
No only need to understand how to select the best markets out of all these 1000 combinations. Suggestions would be really helpful.

hello! wondering if there are any thoughts on this issue? Kindly let me know. Thanks!

Ranking is based on a combination (1) minimum detectable effect, (2) Scaled L2 imbalance (3) Absolute Lift in Zero.
Essentially we want to find market combinations that detect as small a lift as possible, where the synthetic control method shows improvement over a raw simple average and does not detect lift when no lift is present (i.e. doesn't give false positives).
A higher Scaled L2 imbalance (close to 1) means there is little to no benefit with regards to using synthetic controls vs. just simply comparing a simple average of control to treatment markets.  It doesn't necessarily mean that the markets are not useable.
A lower Scaled L2 imbalance (close to 0) however does mean there is close to a perfect fit between treatment and control markets.


sqlite support

Problem
Sqlite isn't supported yet.
Solution
Add dialect and integration tests for sqlite
Notes
@gustavoamigo Could you help me out with this? I can't make the quill_test.db file visible to the sbt session.
Checklist

[x] Unit test all changes
[x] Update README.md if applicable
[x] Add [WIP] to the pull request title if it's work in progress
[x] Squash commits that aren't meaningful changes
[x] Run sbt scalariformFormat test:scalariformFormat to make sure that the source files are formatted

@getquill/maintainers

@fwbrasil you are creating the quill_test.db, but probably not in the /app directory, which is the folder exposed the host machine. I think you can just add working_dir: /app to setup action in docker-compose.yml.

@gustavoamigo it's actually already there :(

:+1:

:+1:


Update to v0.7.7

Fixes #3

Awesome! It's unfortunate they don't put the newer version at a different URL from the original, but c'est la vie.
Thank you!


[FEATURE] Project Page Should Display Team Members

Problem
Project page currently does not display team memb ers
User Story(s):
As a team member, I want to have my profile show on profile page, so that others can follow and find me
Description
Description of solution
Acceptance Criteria

show preview of image with name form near social
hover affect like in near social where can navigate to potlock porfile and also follow directly from their

Limitations

need to pull from social.near to pull this information that may be through an ipfs gateway

Resources

Team Examples from BOS https://github.com/PotLock/bos-app/blob/main/apps/potlock/widget/Project/Team.jsx

Closing; no hover effect yet but will create separate ticket for that.


Update MfgSetup.md

fixing

Docs Build status updates of commit 71d36aa:
:warning: Validation status: warnings

File
Status
Preview URL
Details

dynamics-gp/distribution/MfgSetup.md
:warning:Warning
View
Details

dynamics-gp/distribution/MfgSetup.md

Line 576: [Warning] Invalid file link:(~/distribution/media/11e4e8e3673094ecc02c4f9337ec81df.jpg).
Line 717: [Warning] Invalid file link:(~/distribution/media/a52df266f547d8a3c9978f9e0100909c.jpg).
Line 787: [Warning] Invalid file link:(~/distribution/media/a2ab0984c7944fade6bb1f40b1e9bb9b.jpg).
Line 983: [Warning] Invalid file link:(~/distribution/media/66babca6de2ed03cfbc56271d6c2ba7d.jpg).
Line 1086: [Warning] Invalid file link:(~/distribution/media/55bf80301c52d087d8fdb675407688b5.jpg).
Line 1310: [Warning] Invalid file link:(~/distribution/media/4be79d01041c43492eb6665335d94b86.jpg).
Line 1513: [Warning] Invalid file link:(~/distribution/media/16d612c45442124e29db5c28d021dec0.jpg).
Line 1997: [Warning] Invalid file link:(~/distribution/media/19a5e4ca7d736395d9c686c7fb3983f8.jpg).
Line 2243: [Warning] Invalid file link:(~/distribution/media/a23d2f092bf1cbd15aaa0433c67349fd.jpg).
Line 2393: [Warning] Invalid file link:(~/distribution/media/a2ab0984c7944fade6bb1f40b1e9bb9b.jpg).
Line 2735: [Warning] Invalid file link:(~/distribution/media/53fda1cff045b06b9fa37fef151f3aef.jpg).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Manage Local State with Apollo Client? (react-apollo)

Can we manage Local State with Apollo Client?
It is mentioned that Mutations are not supported.

Need Clarification,
In the Docs, it says we can mutate...
https://strapi.io/documentation/3.x.x/guides/graphql.html#update-an-existing-entry

Well it wasn't supported when we developed the app, though it should be possible now since we support mutations. Here's the Apollo's documentation on local state


code commit

@all-contributors please add @turing85  for code and maintenance

@all-contributors please add @turing85  for code and maintenance


Update model.py

This fixes an incompatibility with python 3.9 on Windows, Possibly Linux as well.

Not sure why this would be incompatible with python 3.9 unless you are changing the Keras / TensorFlow versions?

Using the default versions of all the requirements, Keras doesn't seem to find batch normalization when importing, switching it to the Keras within TensorFlow seems to fix this. I also only experienced this with python 3.9.


Plan for Volo-HTTP 0.2

Big changes

[x] Refactor ServerContext and Service on server side

#354

[x] Remove State

#354

[x] Make client Request can be http::Request with any Body

#369

[x] Use any Response and Error with IntoResponse

#361

Small changes

[x] Separate mods into parts client and server

#362

[x] Add features client, server, https

#362

Features

[x] Support HTTPS

#383
#385

[ ] ~Support HTTP/2~

Others

[ ] Add unit tests
[ ] Add mock support

[ ] Service/Layer level: add mock context
[ ] Request/Response level: add mock connection and stream

[ ] Add more documents

Break changes are finished, maybe :)
I think we can release a new rc version, and if there is no problem, it can become a stable version.

Great!
Maybe we can release a new rc version, and publish the stable version after https/http2 is supported?

There is a important config we are using that is not supported in hyper-util currently, so we decide not to support HTTP/2 in Volo-HTTP 0.2, but we will update some function names or variable names for future support of HTTP/2.

For the last task listed above, please add the docs for http to the websites when it's ready @wfly1998

For the last task listed above, please add the docs for http to the websites when it's ready @wfly1998

Of course.  It is expected to be released after the document is completed, document is very important.  But the unit test and mock support may be delayed 😢

It looks like all breaking changes are complete and we're preparing to add more documentation and release it tomorrow.
Unit tests and mocking support will be updated later.


broken p2p communication in protocol-feature-foundations

in branch protocol-feature-foundations, if a block is received from a peer, it will likely be broken at the time it is broadcast to another peer, resulting in the following exception:
warn  2019-02-28T09:41:19.503 thread-0  controller.cpp:1489           push_block           ] 0 exception: unspecified
unable to reconstruct public key from signature
    {}
    thread-1  elliptic_secp256k1.cpp:160 public_key
error 2019-02-28T09:41:19.503 thread-0  producer_plugin.cpp:320       on_incoming_block    ] 0 exception: unspecified
unable to reconstruct public key from signature
    {}
    thread-1  elliptic_secp256k1.cpp:160 public_key
rethrow
    {}
    thread-0  controller.cpp:1489 push_block

This is unrelated to the speculative or irreversible mode, and can be reproduce by the following setup:
[BP node] -> [ peer 1 ] -> [ peer 2 ]
and the exception message is on peer2.
However if peer 1 is running the old code (release/1.6.x), this issue will not exist.

#6736

Resolved by #6856.


Warning: API Request failed.

I have set up BitCannon once by downloading the binary and once by compiling everything myself. But whatever I do, searching only ever results in a "Warning: API Request failed." warning and the following log entry:
[martini] Started GET /search/720p/s/0 for [redacted]:50191
[martini] Completed 404 Not Found in 1.924947ms

Imported are about 400 torrent links. Browsing works. Am I doing something horribly wrong?
This is possibly related to #70. When using the pre-compiled v0.1.1 binary, this is exactly what happens to me. The endless loop is gone in my compiled binary.

Never mind. I just noticed that my MongoDB version was ancient: 2.4.9. Updating to 3.x resolved that problem quite nicely. Duh.


Marion features authentification

I need a code review and also some feedback

Go inside the routes/allRoutes.js on line 33 & 34 what are those changes for ?

Marion review the code and make sure there are no conflict


Portal / React 16 API

Issue
Portal were introduce in HSDS while we were supporting React 15. We had a lot of workaround to make portal work correctly, but now we start to hit some issue with the new Frame component & styled-components.
Because the solution was custom, each Portal were rendered outside the react DOM tree, causing issue where the portaled component was not accessing the right Stylesheet Manager. The side effects of that was that no Portal components rendered within an iframe was styled with a scope, and all styles were injected at the root document head.
Solution
We start Portal.jsx from the ground up, and we are now leveraging createPortal to handle the Portal injection in the dom. We also spend some time to integrate the HSDS GlobalContext, so we could automatically wrap the Portal with the actual scope, resolving an issue that we had often while migrating to v3.
We also improve the anchor selection to pick the right body based on the Portal context (renderTo prop, portal.container, document.body or frameContext).
The last thing we did was to reorganize the Frame, just to make it a bit more clearer what was going on with the Stylesheet manager (and to use useContext instead of a render prop).
PortalWrapper
This is an HOC that wrap any component we want to prepare to use Portal. It will merge some props from Portal and from the composed component together, and it will pass down some state and callbacks too. It would be nice long term to move that to be a hook but we would have to change the fundamentals of how we integrate Portal within a component:
const Modal = () => {
  const [isOpen, closePortal, openPortal] = usePortal()
  return <ModalUI {...props} isOpen={isOpen} />
}

But that one It will be for another time

Looks great! I just found one issue but I'm sure it's a Storybook thing. Sometimes when you move from the Frame story to a different one (like the Modal story), when you come back to the Frame story all styles are missing. Here's an example: https://c.hlp.sc/YEupxZYN
It really looks like a Storybook thing though, so probably it's nothing to worry about, right?

that looks like a storybook issue. I think to be safe , when we'll upgrade in hs-app, we should do a smoke test to validate that Portal is working correctly in multiple place (and there is no UI issue like you just found)


STORM-1617: Versioned Docs 1.x

This is intended to be merged and used with https://svn.apache.org/repos/asf/storm/branches/bobby-versioned-site

+1

Checked documentation roots and javadocs were of the correct versions on a server @revans2 set up to test. +1


myTweenRef.stop() on 'destroyed' tween throws 'TypeError: this.callbacks is null'

Version

Phaser Version:
3.60.0-beta.11

Operating system:
any

Browser:
any

Description

ISSUE
When creating a Tween and keeping a reference, then after the tween completes and we call:
myTweenRef.stop()
app crashes with following error log:
TypeError: this.callbacks is null
NOTES

There might be use-cases for calling myTween.stop() on tween that already finished, or getting better feedback from Phaser that the tween has already finished when calling this code? (maybe not; in my case i run 2 async ops in parallel so i called myTween.stop() 'just in case' it was still running while the other op finished (and tween should be stopped). This worked ok in 3.55.2, stopping the tween (if running), or ignoring the stop() call (if no more running))
Possibly not to be handled on Phaser side.
Possibly to be handled by a simple boolean flag check on Phaser side and ignored (avoid error trigger).
Possibly show warning from Phaser side
(will let Phaser creator decide this one)

Example Test Code

NOTE: this.animTween has finished at this point.
console.log(">>>")
console.log(this.animTween.isFinished());       // false
console.log(this.animTween.isActive());         // false
console.log(this.animTween.isDestroyed());      // true
console.log(this.animTween.isPending());        // false
console.log(this.animTween.isPendingRemove());  // false
console.log(this.animTween.isPlaying());        // false
console.log(this.animTween.isRemoved());        // false
console.log(this.animTween.isPaused());         // false
console.log(this.animTween.isSeeking);          // false
console.log(this.animTween.isStartDelayed());   // false
try{
    this.animTween.stop();
}
catch(e:any) {
    console.log(e);
}

//////////////////////////////////////
// PHASER code in question that throws
//////////////////////////////////////
dispatchEvent: function (event, callback) {
        if (!this.isSeeking) {
            this.emit(event, this, this.targets);
            // following line throws (this.callbacks is null)
            var handler = this.callbacks[callback];
            if (handler) {
                handler.func.apply(this.callbackScope, [ this, this.targets ].concat(handler.params));
            }
        }
    }

Additional Information

Thank you for spending time reporting this issue. However, we've already fixed this in the master branch of Phaser, and it will be part of the next beta release.

For the record, the stop method now bails if the Tween destroy state has been set. Although really if the Tween is being re-used over and over, it should be set to persist: true in the tween config, but this will at least stop a runtime error.

For the record, the stop method now bails if the Tween destroy state has been set. Although really if the Tween is being re-used over and over, it should be set to persist: true in the tween config, but this will at least stop a runtime error.

persist: true is the proper way to do it, thanks!


Unable to push image to private docker image repository

response = chassis_model.publish(
model_name="customerepo.com/chassis/digits-sklearn",
model_version="0.0.1",
registry_user=username,
registry_pass=username,
)
The above code always tries to authenticate agains "dockerhub" instead of "customerepo.com". Can anyone please suggest a solution to this.

Hi @roushanatlcci thank you for your question!
To push images to your private Docker registry, you must install the Chassis service (i.e., the publicly-hosted service only pushes images to Docker Hub). Here is a guide to help you configure your private registry before installing Chassis via helm.
https://chassis.ml/how-to-guides/private-registry/

Thanks @bmunday3 for your response. According to the document the chassisml service can only push to one repo for which it is configured. Is it possible to send the details like repo url and credentials from client side.

Another great question @roushanatlcci! With Chassis as it stands today (v1), that is correct. It will only push to a registry for which it is configured.
However, we are actively working on v2 which will include a number of new features. This is a great idea we will take into account. Stay tuned for us to release an alpha version of v2 sometime in the next ~month timeframe appriximately.

Hey @roushanatlcci ! I know we were able to get around this issue earlier this year, but I wanted to let you know that this process is significantly streamlined with our latest 1.5 release. You can check out the full release notes for more details, but to summarize, here's how the significant refactor fixes this:

There are now two methods for building container images: (1) with a local build option, which uses the host machine's Docker daemon to build containers, and (2) a server option, which is a much leaner and more efficient version of what you stood up in your K8s environment
With the local build option, you can manually push the built containers to a private docker registry of choice
With the server build option, it is mandatory that you configure it to push directly to a single private docker registry. Check out this guide for more details.

Closing this issue with the above explanation. Please feel free to reach out or open a new issue if you run into additional problems


[BACK-24] Expose all projects

Description of Issue
All projects in database are exported
How I implemented
I executed a query to get all projects and then returned those items.

build is failing @DogukanGun


Add support for amd Radeon 780M gfx1103 - override works

What are you trying to do?
Please support GPU acceleration using "AMD Ryzen 7 PRO 7840U w/ Radeon 780M Graphics" on Linux (Ubuntu 22.04).
Newer notebooks are shipped with AMD 7840U and support setting VRAM from 1GB to 8GB in the bios. With GPU acceleration only 1 vCPU is used and user experience with 7B models is quite good.
Not working ("amdgpu [0] gfx1103 is not supported"):
OLLAMA_LLM_LIBRARY="rocm_v60000" /usr/bin/ollama serve
time=2024-03-17T03:02:49.566+01:00 level=INFO source=images.go:806 msg="total blobs: 20"
time=2024-03-17T03:02:49.566+01:00 level=INFO source=images.go:813 msg="total unused blobs removed: 0"
time=2024-03-17T03:02:49.566+01:00 level=INFO source=routes.go:1110 msg="Listening on <IP_ADDRESS>:11434 (version 0.1.29)"
time=2024-03-17T03:02:49.566+01:00 level=INFO source=payload_common.go:112 msg="Extracting dynamic libraries to /tmp/ollama3117537729/runners ..."
time=2024-03-17T03:02:51.423+01:00 level=INFO source=payload_common.go:139 msg="Dynamic LLM libraries [rocm_v60000 cpu_avx cpu_avx2 cuda_v11 cpu]"
time=2024-03-17T03:02:51.424+01:00 level=INFO source=gpu.go:77 msg="Detecting GPU type"
time=2024-03-17T03:02:51.424+01:00 level=INFO source=gpu.go:191 msg="Searching for GPU management library libnvidia-ml.so"
time=2024-03-17T03:02:51.427+01:00 level=INFO source=gpu.go:237 msg="Discovered GPU libraries: []"
time=2024-03-17T03:02:51.427+01:00 level=INFO source=cpu_common.go:11 msg="CPU has AVX2"
time=2024-03-17T03:02:51.427+01:00 level=INFO source=amd_linux.go:50 msg="AMD Driver: 6.3.6"
time=2024-03-17T03:02:51.427+01:00 level=INFO source=amd_linux.go:88 msg="detected amdgpu versions [gfx1103]"
time=2024-03-17T03:02:51.430+01:00 level=WARN source=amd_linux.go:114 msg="amdgpu [0] gfx1103 is not supported by /tmp/ollama3117537729/rocm [gfx1030 gfx1100 gfx1101 gfx1102 gfx900 gfx906 gfx908 gfx90a gfx940 gfx941 gfx942]"
time=2024-03-17T03:02:51.430+01:00 level=WARN source=amd_linux.go:116 msg="See https://github.com/ollama/ollama/blob/main/docs/troubleshooting.md for HSA_OVERRIDE_GFX_VERSION usage"
time=2024-03-17T03:02:51.430+01:00 level=INFO source=amd_linux.go:127 msg="all detected amdgpus are skipped, falling back to CPU"
time=2024-03-17T03:02:51.430+01:00 level=INFO source=routes.go:1133 msg="no GPU detected"

My current workaround is to force gfx1102 (no issues so far):
HSA_OVERRIDE_GFX_VERSION="11.0.2" OLLAMA_LLM_LIBRARY="rocm_v60000" /usr/bin/ollama serve
time=2024-03-17T03:04:54.436+01:00 level=INFO source=images.go:806 msg="total blobs: 20"
time=2024-03-17T03:04:54.436+01:00 level=INFO source=images.go:813 msg="total unused blobs removed: 0"
time=2024-03-17T03:04:54.437+01:00 level=INFO source=routes.go:1110 msg="Listening on <IP_ADDRESS>:11434 (version 0.1.29)"
time=2024-03-17T03:04:54.437+01:00 level=INFO source=payload_common.go:112 msg="Extracting dynamic libraries to /tmp/ollama2902102366/runners ..."
time=2024-03-17T03:04:56.315+01:00 level=INFO source=payload_common.go:139 msg="Dynamic LLM libraries [cpu_avx2 cuda_v11 rocm_v60000 cpu cpu_avx]"
time=2024-03-17T03:04:56.315+01:00 level=INFO source=gpu.go:77 msg="Detecting GPU type"
time=2024-03-17T03:04:56.315+01:00 level=INFO source=gpu.go:191 msg="Searching for GPU management library libnvidia-ml.so"
time=2024-03-17T03:04:56.317+01:00 level=INFO source=gpu.go:237 msg="Discovered GPU libraries: []"
time=2024-03-17T03:04:56.317+01:00 level=INFO source=cpu_common.go:11 msg="CPU has AVX2"
time=2024-03-17T03:04:56.317+01:00 level=INFO source=amd_linux.go:50 msg="AMD Driver: 6.3.6"
time=2024-03-17T03:04:56.318+01:00 level=INFO source=amd_linux.go:88 msg="detected amdgpu versions [gfx1103]"
time=2024-03-17T03:04:56.319+01:00 level=INFO source=amd_linux.go:246 msg="[0] amdgpu totalMemory 8192M"
time=2024-03-17T03:04:56.319+01:00 level=INFO source=amd_linux.go:247 msg="[0] amdgpu freeMemory  8192M"

Note: using "rocm_v6" was not working for me, so I chose "rocm_v60000" (ls /tmp/ollama758986631/runners/ gives
cpu  cpu_avx  cpu_avx2  cuda_v11  rocm_v60000)
Some benchmarks using 7840U (numbers from second run), ubuntu 22.04, kernel 6.5, vram switched to 8GB in bios:
> CPU
OLLAMA_LLM_LIBRARY="cpu_avx2" /usr/bin/ollama serve
ollama run llama2:latest "where was beethoven born?" --verbose
Ludwig van Beethoven was born in Bonn, Germany on December 16, 1770.
total duration:       4.343514826s
load duration:        264.691µs
prompt eval duration: 168.205ms
prompt eval rate:     0.00 tokens/s
eval count:           26 token(s)
eval duration:        4.174563s
eval rate:            6.23 tokens/s

> GPU
HSA_OVERRIDE_GFX_VERSION="11.0.2" OLLAMA_LLM_LIBRARY="rocm_v60000u_avx2" /usr/bin/ollama serve
ollama run llama2:latest "where was beethoven born?" --verbose
Ludwig van Beethoven was born in Bonn, Germany on December 16, 1770.
total duration:       1.513455927s
load duration:        161.535µs
prompt eval duration: 65.979ms
prompt eval rate:     0.00 tokens/s
eval count:           27 token(s)
eval duration:        1.446805s
eval rate:            18.66 tokens/s

How should we solve this?
No response
What is the impact of not solving this?
No response
Anything else?
No response

Same with me, on Windows
$env:OLLAMA_ORIGINS="app://obsidian.md*"; ollama serve
time=2024-03-24T02:21:24.575+08:00 level=INFO source=images.go:806 msg="total blobs: 8"
time=2024-03-24T02:21:24.599+08:00 level=INFO source=images.go:813 msg="total unused blobs removed: 0"
time=2024-03-24T02:21:24.601+08:00 level=INFO source=routes.go:1110 msg="Listening on <IP_ADDRESS>:11434 (version 0.1.29)"
time=2024-03-24T02:21:24.601+08:00 level=INFO source=payload_common.go:112 msg="Extracting dynamic libraries to C:\\Users\\Jeff\\AppData\\Local\\Temp\\ollama3340791837\\runners ..."
time=2024-03-24T02:21:24.654+08:00 level=INFO source=payload_common.go:139 msg="Dynamic LLM libraries [cpu cpu_avx cuda_v11.3 rocm_v5.7 cpu_avx2]"
time=2024-03-24T02:21:29.415+08:00 level=INFO source=gpu.go:77 msg="Detecting GPU type"
time=2024-03-24T02:21:29.415+08:00 level=INFO source=gpu.go:191 msg="Searching for GPU management library nvml.dll"
time=2024-03-24T02:21:29.424+08:00 level=INFO source=gpu.go:237 msg="Discovered GPU libraries: []"
time=2024-03-24T02:21:29.424+08:00 level=INFO source=cpu_common.go:11 msg="CPU has AVX2"
time=2024-03-24T02:21:29.442+08:00 level=INFO source=amd_windows.go:40 msg="AMD Driver: 50422970"
time=2024-03-24T02:21:29.455+08:00 level=INFO source=amd_windows.go:69 msg="detected 1 hip devices"
time=2024-03-24T02:21:29.455+08:00 level=INFO source=amd_windows.go:87 msg="[0] Name: AMD Radeon(TM) 780M"
time=2024-03-24T02:21:29.455+08:00 level=INFO source=amd_windows.go:90 msg="[0] GcnArchName: gfx1103"
time=2024-03-24T02:21:29.455+08:00 level=WARN source=amd_windows.go:100 msg="amdgpu [0] gfx1103 is not supported by C:\\Users\\Jeff\\AppData\\Local\\Programs\\Ollama\\rocm [gfx1030 gfx1100 gfx1101 gfx1102 gfx906]"
time=2024-03-24T02:21:29.455+08:00 level=WARN source=amd_windows.go:102 msg="See https://github.com/ollama/ollama/blob/main/docs/troubleshooting.md for HSA_OVERRIDE_GFX_VERSION usage"
time=2024-03-24T02:21:29.455+08:00 level=INFO source=amd_windows.go:128 msg="all detected amdgpus are skipped, falling back to CPU"
time=2024-03-24T02:21:29.510+08:00 level=INFO source=cpu_common.go:11 msg="CPU has AVX2"
time=2024-03-24T02:21:29.526+08:00 level=INFO source=amd_windows.go:40 msg="AMD Driver: 50422970"
time=2024-03-24T02:21:29.527+08:00 level=INFO source=amd_windows.go:69 msg="detected 1 hip devices"
time=2024-03-24T02:21:29.527+08:00 level=INFO source=amd_windows.go:87 msg="[0] Name: AMD Radeon(TM) 780M"
time=2024-03-24T02:21:29.527+08:00 level=INFO source=amd_windows.go:90 msg="[0] GcnArchName: gfx1103"
time=2024-03-24T02:21:29.527+08:00 level=WARN source=amd_windows.go:100 msg="amdgpu [0] gfx1103 is not supported by C:\\Users\\Jeff\\AppData\\Local\\Programs\\Ollama\\rocm [gfx1030 gfx1100 gfx1101 gfx1102 gfx906]"
time=2024-03-24T02:21:29.528+08:00 level=WARN source=amd_windows.go:102 msg="See https://github.com/ollama/ollama/blob/main/docs/troubleshooting.md for HSA_OVERRIDE_GFX_VERSION usage"
time=2024-03-24T02:21:29.528+08:00 level=INFO source=amd_windows.go:128 msg="all detected amdgpus are skipped, falling back to CPU"
time=2024-03-24T02:21:29.590+08:00 level=INFO source=llm.go:85 msg="GPU not available, falling back to CPU"

Cool, 7840U has AVX512, is there any improvements over AVX2?

hey i have the same problem, my Amd 780m didnt get recognized by ubuntu, you also cant use docm with this gpu, could you maybe help me fix this for me, Im knew to this and dont know what to do thank you

To clarify, unfortunately the override is not supported on windows due to ROCm limitations.  That's tracked via #3107

Hello,
The override HSA_OVERRIDE_GFX_VERSION=10.3.0 doesn't work for me.
I'm using
ADM GPU: gfx1032 (x2)
OS: Ubuntu 22.04
CPU with no AVX support
I got the following error:

May 06 09:29:20 kanfa ollama[1550]: time=2024-05-06T09:29:20.541Z level=INFO source=server.go:389 msg="waiting for llama runner to start responding"
May 06 09:29:20 kanfa ollama[1550]: time=2024-05-06T09:29:20.592Z level=DEBUG source=server.go:420 msg="server not yet available" error="health resp: Get "http://<IP_ADDRESS>:37055/health\": dial tcp <IP_ADDRESS>:37055: connect: connection refused"
May 06 09:29:21 kanfa ollama[1550]: time=2024-05-06T09:29:21.091Z level=ERROR source=routes.go:120 msg="error loading llama server" error="llama runner process no longer running: -1 "
May 06 09:29:21 kanfa ollama[1550]: time=2024-05-06T09:29:21.092Z level=DEBUG source=server.go:832 msg="stopping llama server"

The full log is available here
Please, let me know what I should modify.

@TheophileH I'm not positive, but you may have hit #4105

I was able to make it run on AMD 780M GPU on Windows 11. (Perf increas of about x2)
Thanks to @likelovewant for providing instructions and the specific version of Ollama.
See https://github.com/likelovewant/ROCmLibs-for-gfx1103-AMD780M-APU-/issues/3
@dhiltgen Is it possible to integrate this solution into Ollama? Nothing else but that build worked.

@TheophileH I'm not positive, but you may have hit #4105

Thanks for your response, @dhiltgen.
As mentioned in #4105, I used OLLAMA_VERSION=0.1.34  and set OLLAMA_TMPDIR=/usr/share/ollama/.
I still get the same log but now, it runs forever before throwing the following error:

Error: timed out waiting for llama runner to start:

@thbley
Please follow my practice to use iGPU 780M(gfx1103) at Linux.
https://github.com/alexhegit/Playing-with-ROCm/blob/main/inference/LLM/Run_Ollama_with_AMD_iGPU780M-QuickStart.md

What are you trying to do?
Please support GPU acceleration using "AMD Ryzen 7 PRO 7840U w/ Radeon 780M Graphics" on Linux (Ubuntu 22.04).
Newer notebooks are shipped with AMD 7840U and support setting VRAM from 1GB to 8GB in the bios. With GPU acceleration only 1 vCPU is used and user experience with 7B models is quite good.
Not working ("amdgpu [0] gfx1103 is not supported"):
OLLAMA_LLM_LIBRARY="rocm_v60000" /usr/bin/ollama serve
time=2024-03-17T03:02:49.566+01:00 level=INFO source=images.go:806 msg="total blobs: 20"
time=2024-03-17T03:02:49.566+01:00 level=INFO source=images.go:813 msg="total unused blobs removed: 0"
time=2024-03-17T03:02:49.566+01:00 level=INFO source=routes.go:1110 msg="Listening on <IP_ADDRESS>:11434 (version 0.1.29)"
time=2024-03-17T03:02:49.566+01:00 level=INFO source=payload_common.go:112 msg="Extracting dynamic libraries to /tmp/ollama3117537729/runners ..."
time=2024-03-17T03:02:51.423+01:00 level=INFO source=payload_common.go:139 msg="Dynamic LLM libraries [rocm_v60000 cpu_avx cpu_avx2 cuda_v11 cpu]"
time=2024-03-17T03:02:51.424+01:00 level=INFO source=gpu.go:77 msg="Detecting GPU type"
time=2024-03-17T03:02:51.424+01:00 level=INFO source=gpu.go:191 msg="Searching for GPU management library libnvidia-ml.so"
time=2024-03-17T03:02:51.427+01:00 level=INFO source=gpu.go:237 msg="Discovered GPU libraries: []"
time=2024-03-17T03:02:51.427+01:00 level=INFO source=cpu_common.go:11 msg="CPU has AVX2"
time=2024-03-17T03:02:51.427+01:00 level=INFO source=amd_linux.go:50 msg="AMD Driver: 6.3.6"
time=2024-03-17T03:02:51.427+01:00 level=INFO source=amd_linux.go:88 msg="detected amdgpu versions [gfx1103]"
time=2024-03-17T03:02:51.430+01:00 level=WARN source=amd_linux.go:114 msg="amdgpu [0] gfx1103 is not supported by /tmp/ollama3117537729/rocm [gfx1030 gfx1100 gfx1101 gfx1102 gfx900 gfx906 gfx908 gfx90a gfx940 gfx941 gfx942]"
time=2024-03-17T03:02:51.430+01:00 level=WARN source=amd_linux.go:116 msg="See https://github.com/ollama/ollama/blob/main/docs/troubleshooting.md for HSA_OVERRIDE_GFX_VERSION usage"
time=2024-03-17T03:02:51.430+01:00 level=INFO source=amd_linux.go:127 msg="all detected amdgpus are skipped, falling back to CPU"
time=2024-03-17T03:02:51.430+01:00 level=INFO source=routes.go:1133 msg="no GPU detected"

My current workaround is to force gfx1102 (no issues so far):
HSA_OVERRIDE_GFX_VERSION="11.0.2" OLLAMA_LLM_LIBRARY="rocm_v60000" /usr/bin/ollama serve
time=2024-03-17T03:04:54.436+01:00 level=INFO source=images.go:806 msg="total blobs: 20"
time=2024-03-17T03:04:54.436+01:00 level=INFO source=images.go:813 msg="total unused blobs removed: 0"
time=2024-03-17T03:04:54.437+01:00 level=INFO source=routes.go:1110 msg="Listening on <IP_ADDRESS>:11434 (version 0.1.29)"
time=2024-03-17T03:04:54.437+01:00 level=INFO source=payload_common.go:112 msg="Extracting dynamic libraries to /tmp/ollama2902102366/runners ..."
time=2024-03-17T03:04:56.315+01:00 level=INFO source=payload_common.go:139 msg="Dynamic LLM libraries [cpu_avx2 cuda_v11 rocm_v60000 cpu cpu_avx]"
time=2024-03-17T03:04:56.315+01:00 level=INFO source=gpu.go:77 msg="Detecting GPU type"
time=2024-03-17T03:04:56.315+01:00 level=INFO source=gpu.go:191 msg="Searching for GPU management library libnvidia-ml.so"
time=2024-03-17T03:04:56.317+01:00 level=INFO source=gpu.go:237 msg="Discovered GPU libraries: []"
time=2024-03-17T03:04:56.317+01:00 level=INFO source=cpu_common.go:11 msg="CPU has AVX2"
time=2024-03-17T03:04:56.317+01:00 level=INFO source=amd_linux.go:50 msg="AMD Driver: 6.3.6"
time=2024-03-17T03:04:56.318+01:00 level=INFO source=amd_linux.go:88 msg="detected amdgpu versions [gfx1103]"
time=2024-03-17T03:04:56.319+01:00 level=INFO source=amd_linux.go:246 msg="[0] amdgpu totalMemory 8192M"
time=2024-03-17T03:04:56.319+01:00 level=INFO source=amd_linux.go:247 msg="[0] amdgpu freeMemory  8192M"

Note: using "rocm_v6" was not working for me, so I chose "rocm_v60000" (ls /tmp/ollama758986631/runners/ gives cpu cpu_avx cpu_avx2 cuda_v11 rocm_v60000)
Some benchmarks using 7840U (numbers from second run), ubuntu 22.04, kernel 6.5, vram switched to 8GB in bios:
> CPU
OLLAMA_LLM_LIBRARY="cpu_avx2" /usr/bin/ollama serve
ollama run llama2:latest "where was beethoven born?" --verbose
Ludwig van Beethoven was born in Bonn, Germany on December 16, 1770.
total duration:       4.343514826s
load duration:        264.691µs
prompt eval duration: 168.205ms
prompt eval rate:     0.00 tokens/s
eval count:           26 token(s)
eval duration:        4.174563s
eval rate:            6.23 tokens/s

> GPU
HSA_OVERRIDE_GFX_VERSION="11.0.2" OLLAMA_LLM_LIBRARY="rocm_v60000u_avx2" /usr/bin/ollama serve
ollama run llama2:latest "where was beethoven born?" --verbose
Ludwig van Beethoven was born in Bonn, Germany on December 16, 1770.
total duration:       1.513455927s
load duration:        161.535µs
prompt eval duration: 65.979ms
prompt eval rate:     0.00 tokens/s
eval count:           27 token(s)
eval duration:        1.446805s
eval rate:            18.66 tokens/s

How should we solve this?
No response
What is the impact of not solving this?
No response
Anything else?
No response

Hey everyone, just wanted to chime in and say that I'd love to see support for AMD Radeon 780M (gfx1103) added to Ollama!
However, I think it's worth noting that this would require ROCm to add support for this specific chipset. To make this happen, I've opened a feature request over on the ROCm GitHub page:
[https://github.com/ROCm/ROCm/discussions/3360]
If you're interested in seeing this support added, please head on over and give it a thumbs up! Let's help push for this change and make it happen.
Maybe add a reply to it highlighting your interest in the support.

Hello,
not sure if this is the right place, I am experiencing an issue where when setting the override with systemd edit ollama.service it dores not take place after restart on ubuntu 24 ryzen 9 7940 radeon 780m
output from journalctl -u ollama --no-pager
ollama[49742]: 2024/08/25 08:15:47 routes.go:1125: INFO server config env="map[CUDA_VISIBLE_DEVICES: GPU_DEVICE_ORDINAL: HIP_VISIBLE_DEVICES: HSA_OVERRIDE_GFX_VERSION: OLLAMA_DEBUG:false OLLAMA_FLASH_ATTENTION:false OLLAMA_HOST:http://<IP_ADDRESS>:11434 OLLAMA_INTEL_GPU:false OLLAMA_KEEP_ALIVE:5m0s OLLAMA_LLM_LIBRARY: OLLAMA_MAX_LOADED_MODELS:0 OLLAMA_MAX_QUEUE:512 OLLAMA_MODELS:/usr/share/ollama/.ollama/models OLLAMA_NOHISTORY:false OLLAMA_NOPRUNE:false OLLAMA_NUM_PARALLEL:0 OLLAMA_ORIGINS:[http://localhost https://localhost http://localhost:* https://localhost:*
HSA_OVERRIDE_GFX_VERSION: remains empty
could you help me?

has anyone tried this override option with Radeon 680M? Do y'all this workaround described here will work with this model of graphics card: https://github.com/alexhegit/Playing-with-ROCm/blob/main/inference/LLM/Run_Ollama_with_AMD_iGPU780M-QuickStart.md?


New modify_volume_element methods

Added task schema methods ''new_orientations" and "geometry" In task "modify_volume_element" to support feat/multipass in matflow-damask.

This is a little confusing for me, I think you have rebased your changes on to the end of the features I've been working on. All your changes look fine but this is blocked until the changes in matflow-damask and damask-parse are all in a branch together.

Closing this pull request as it is rebased to the end of changes made by @mikesmic .


Fix nav sample

WHAT
Nav sample shows the network state in the TimeText.
Add permissions.
Checklist :clipboard:

[ ] Add explicit visibility modifier and explicit return types for public declarations
[ ] Run spotless check
[ ] Run tests
[ ] Update metalava's signature text files

                                                                                Process: com.google.android.horologist.sample.debug, PID: 10550
                                                                                java.lang.RuntimeException: Unable to start activity ComponentInfo{com.google.android.horologist.sample.debug/com.google.android.horologist.navsample.NavActivity}: java.lang.SecurityException: ConnectivityService: Neither user 10068 nor current process has android.permission.ACCESS_NETWORK_STATE.
                                                                                at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3449)


Feature export: Add Sponsor and partner field

What's this PR do?
Adds the Sponsor and Partners field collection to field pages. This only adds the field, does not deal with displaying it yet.
Where should the reviewer start?
dosomething_fact_page.features.field_instance.inc but this is just a feature export.
How should this be manually tested?
Go to create or edit a fact page and you should see the "Sponsor and Partners" field at the bottom of the edit page.
Any background context you want to provide?
For the Yahoo partnership.
What are the relevant tickets?


Docker Compose Website

Now that Docker Compose 1.1.0-rc1  is out and is no longer named Fig, we should start to think about what will happen to the Fig.sh website.

Move it to a sub-documentation section of https://docs.docker.com ?
Re-brand the website under http://compose.docker.com ?
Make a whole new http://fig.sh and deal with moving the domain later on?

Hello,
I think this @aanand comment answers your question.

Yep - this will all move to docker.com and docs.docker.com.

:+1:


Homebridge restarts when accepting connection request

Homebridge restarts when accepting connection request From LG TV.
When I click the yes button on the TV, my homebridge restarts and the TV promos me to accept ion the connection again.
[7/2/2021, 8:38:44 AM] [webostv] Init - initializing devices
[7/2/2021, 8:38:44 AM] [webostv] [My LG TV] Init - got TV configuration, initializing device with name: My LG TV
[7/2/2021, 8:38:44 AM] [webostv] [My LG TV] The TV has no configured inputs yet!
[7/2/2021, 8:38:44 AM] [webostv] [My LG TV] No TV inputs config file found!
[7/2/2021, 8:38:44 AM] [webostv] [My LG TV] Adding 0 new input sources!
…
[7/2/2021, 8:39:37 AM] [webostv] [My LG TV] Connected to TV
[7/2/2021, 8:39:37 AM] [webostv] [My LG TV] Requesting TV information
[7/2/2021, 8:39:37 AM] [webostv] [My LG TV] system service - getSystemInfo requested.
[7/2/2021, 8:39:37 AM] [HB Supervisor] Homebridge Process Ended. Code: null, Signal: SIGBUS
[7/2/2021, 8:39:42 AM] [HB Supervisor] Restarting Homebridge...
[7/2/2021, 8:39:42 AM] [HB Supervisor] Starting Homebridge with extra flags: -I -P /homebridge/node_modules -D
[7/2/2021, 8:39:43 AM] [HB Supervisor] Started Homebridge v1.3.4 with PID: 1812
Initializing HAP-NodeJS v0.9.4...
Any suggestion appreciated.
I have also added the TV as a standard HomeKit accessory, but I’d like to  use this plugin for the additional functions.
Thanks.

Probably the plugin cannot write to the file system to save key. I think your permissions might be incorrect...

Yep. I loaded it on my other homebridge (disk station) and it’s working.  I’ll close this and try to work out which directory on the Pi4 has the wrong permissions.  Thanks for pointing me in the right direction.


Update ammonite-compiler_2.12.15, ... to 3.0.0-M0-65-d93dec88

About this PR
📦 Updates

com.lihaoyi:ammonite-compiler_2.12.15
com.lihaoyi:ammonite-compiler_2.12.16
com.lihaoyi:ammonite-compiler_2.12.17
com.lihaoyi:ammonite-compiler_2.12.18
com.lihaoyi:ammonite-compiler_2.13.10
com.lihaoyi:ammonite-compiler_2.13.11
com.lihaoyi:ammonite-compiler_2.13.12
com.lihaoyi:ammonite-compiler_2.13.9
com.lihaoyi:ammonite-compiler_3.3.0
com.lihaoyi:ammonite-compiler_3.3.1
com.lihaoyi:ammonite-repl-api_2.12.15
com.lihaoyi:ammonite-repl-api_2.12.16
com.lihaoyi:ammonite-repl-api_2.12.17
com.lihaoyi:ammonite-repl-api_2.12.18
com.lihaoyi:ammonite-repl-api_2.13.10
com.lihaoyi:ammonite-repl-api_2.13.11
com.lihaoyi:ammonite-repl-api_2.13.12
com.lihaoyi:ammonite-repl-api_2.13.9
com.lihaoyi:ammonite-repl_2.12.15
com.lihaoyi:ammonite-repl_2.12.16
com.lihaoyi:ammonite-repl_2.12.17
com.lihaoyi:ammonite-repl_2.12.18
com.lihaoyi:ammonite-repl_2.13.10
com.lihaoyi:ammonite-repl_2.13.11
com.lihaoyi:ammonite-repl_2.13.12
com.lihaoyi:ammonite-repl_2.13.9

from 3.0.0-M0-56-1bcbe7f6 to 3.0.0-M0-65-d93dec88
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.lihaoyi" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.lihaoyi" }
}]

labels: library-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

Superseded by #1324.


feature(mocha/grep): improve grep - issue #808

Add the ability to pass grep as a regexp-like string. (query in the browser or flag in the cli).
This improvement gives you pass a regexp that including flags, and solved #808 as well.
e.g:
$ mocha test/ --grep /^Suite/i

/cc @mochajs/mocha

LGTM! :)
Some might argue that it breaks BC, and would require a major bump. e.g.:
it('/test/i', function() {});
it('test', function() {});

with something like mocha --grep /test/i test.js. Before this PR, you'll run one spec. After, you'll run two. But it's certainly an edge case, as with most BC discussions.

I couldn't take a look at it yet.
Def break BC, but since we have other changes that do so too we can just ship them together in the next major.

@a8m possible to rebase against branch v3.0.0?

Sure, l'II do it later.
same with #1634, #1591
thx

Rebased. but it seems to be causing an error on Travis.
Is there anyone who understand what the problem in this build?
/cc @mochajs/mocha

old npm version carret issue

Yep, not an actual issue.
@a8m great feature! Let's merge and ship asap :)

@a8m this still needs to be rebased... not sure what's happening here.

Replaced with #1808(rebased on top of v3.0.0)


Scroll top popup

how to modify the code to scroll to top for each modal if the content of modal content is long?

Hm, won't the modal be already scrolled to the top by default?
Do you want to scroll to the top when the modal is first opened? You can probably do $('.modal-body').scrollTop(0)?

First modal is on top. If the second modal have long content, it will appear to the bottom of the page. Where do i place the code? Inside html or js?

Probably, anywhere you want, such as in the JS, in the onClick listener for second modal.
If you have an example showing what you're talking about, please share it.

Here, https://github.com/ngzhian/multi-step-modal/blob/master/index.html#L32
instead of onclick="sendEvent('#demo-modal-1', 2)"
something like onclick="sendEventAndScrollToTop('#demo-modal-1', 2)"
then
function sendEventAndScrollToTop(sel, ev) {
  sendEvent(sel, ev);
  $(".modal .step-2").scrollTop(0);
}

Is it not working..idk why
here is my code:
<button type="button" class="btn myButton step step-1" data-step="1" onclick="sendEventAndScrollToTop('#demo-modal-3', 2)">Continue</button> 				<button type="button" class="btn myButton step step-2" data-step="2" onclick="sendEventAndScrollToTop('#demo-modal-3', 1)">Back</button> 				<button type="button" class="btn myButton step step-2" data-step="2" onclick="sendEventAndScrollToTop('#demo-modal-3', 3)">Continue</button>                 <button type="button" class="btn myButton step step-3" data-step="3" onclick="sendEventAndScrollToTop('#demo-modal-3', 2)">Back</button> 				<button type="button" class="btn myButton step step-3" data-step="3" onclick="sendEventAndScrollToTop('#demo-modal-3', 4)">Continue</button>                 <button type="button" class="btn myButton step step-4" data-step="4" onclick="sendEventAndScrollToTop('#demo-modal-3', 3)">Back</button> 				<button type="button" class="btn myButton step step-4" data-step="4" onclick="sendEventAndScrollToTop('#demo-modal-3', 5)">Continue</button>                 <button type="button" class="btn myButton step step-5" data-step="5" onclick="sendEventAndScrollToTop('#demo-modal-3', 4)">Back</button> 				<button type="button" class="btn myButton step step-5" data-step="5" onclick="sendEventAndScrollToTop('#demo-modal-3', 6)">Continue</button>                 <button type="button" class="btn myButton step step-6" data-step="6" onclick="sendEventAndScrollToTop('#demo-modal-3', 5)">Back</button> 				<button type="button" class="btn myButton step step-6" data-step="6" onclick="sendEventAndScrollToTop('#demo-modal-3', 7)">Continue</button>                 <button type="button" class="btn myButton step step-7" data-step="7" onclick="sendEventAndScrollToTop('#demo-modal-3', 6)">Back</button> 				<button type="button" class="btn myButton step step-7" data-step="7" onclick="sendEventAndScrollToTop('#demo-modal-3', 8)">Continue</button>                 <button type="button" class="btn myButton step step-8" data-step="8" onclick="sendEventAndScrollToTop('#demo-modal-3', 7)">Back</button> 				<button type="button" class="btn myButton step step-8" data-step="8" onclick="sendEventAndScrollToTop('#demo-modal-3', 9)">Continue</button>                 <button type="button" class="btn myButton step step-9" data-step="9" onclick="sendEventAndScrollToTop('#demo-modal-3', 8)">Back</button> 				<button type="button" class="btn myButton step step-9" data-step="9" onclick="sendEventAndScrollToTop('#demo-modal-3', 10)">Continue</button>                 <button type="button" class="btn myButton step step-10" data-step="10" onclick="sendEventAndScrollToTop('#demo-modal-3', 9)">Back</button>
and this is the js:
``
the scrollTop should be on modal step 2

Oh, okay. Change $(".modal .step-2").scrollTop(0); to $("form.modal").scrollTop(0);. I misunderstood what you meant by the modal being at the bottom. Lmk if this fixes things.

OMG! That solved my problem..Thanks mate!

Sure thing. Do you know how to use Chrome DevTools? I used it to figure out which element was scrolled to the bottom, saw that it was the entire modal form element, and changed the JS to scroll it instead of the modal body. Maybe that will be helpful for you in the future.


TSP does not return to start

It looks like the newest nuget package has a small problem.
When i try to calculate TSP routes, it does not go back to the starting point.
And I can't find any options on the CalculateTSP function. It might be, that you could choose if it should return. This would be a nice feature. But the plain TSP should return to the start node, right ?.
BR
Martin.

Hi Martin,
The default on CalculateTSP is the 'Open TSP' version. If you add first and last equal to '0' then it should return back to the first customer.
Check here: https://github.com/itinero/optimization/blob/develop/src/Itinero.Optimization/RouterExtensions.cs#L49
There are three options:

first=0, last=null: Open TSP, doesn't return to first.
first=0, last=x: Closed TSP but with a fixed end customer 'x', also doesn't return to first.
first=0, last=0: Closed TSP as you expect it to behave, returning back to the first. Perhaps this should be default yes.

Could you log future issues here?:
https://github.com/itinero/optimization
Please be aware that this code is still moving a lot, meaning things can change fast and are still relatively experimental. I'm expecting to have something more stable with basic documentation in 4 to 8 weeks.
Also, package name has changed to Itinero.Optimization. Closing this issue here, feel free to create new ones in the other repo about this.

Just to let you know I updated the readme with some more info:
https://github.com/itinero/optimization
Everything you need should be in there.


Switch default bucket to prod bucket

Default ovf-image should be prod.
Only retain release directories in the bucket.

👍


ion: init at 1.0.3

Motivation for this change
Add ion
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@FRidh Please merge.


STORM-2877: Backport for 1.x-branch

Backporting this Storm UI change which has already been merged in master.
JIRA ticket: https://issues.apache.org/jira/browse/STORM-2877
Merged PR in master branch: #2505

Thanks @HeartSaVioR!


Adressing Issue #75 with some initial refactoring, both functions now…

… call a helper that returns a reference to a vetor of alignments and align_PE simply returns the best (by SW score as it did before) while align_SE_secondary_hits does it's usual thing with the vector.
I am relatively certain that this will do the same thing as before, however since we now have unit tests, adding some unit tests that check that alignments look as they should with test data could be really good.

Oh great, that’s a lot of duplicated code we can get rid of! The tests don’t pass, though, so something is different. It appears to be different mapping qualities. Here’s how I usually run the tests locally:
export PATH=$PWD/build:$PATH
make -C build && tests/run.sh

The first line is currently necessary; however, I think I should rewrite the run.sh script so that it does not require strobealign to be in the PATH.
Since this is just a refactor, we definitely need a test that verifies that the output is the same as before when running with -N 2. The easiest way to do this would be to add yet more strobealign invocations to tests/run.sh. Feel free to do so, but we I think that the number of files in tests/ is getting too big too fast, and we need to find a better way for testing. I’ll open a separate issue about this.
BTW, feel free to use shorter branch names. IMO, they don’t need to be very descriptive because the name disappears once the PR is merged. I think it is more valuable to be able to type them in on the command line without resorting to copy&paste.

I will keep on working on this next week, I am off tomorrow and Monday. But there is a get_alignment and get_MAPQ function used by align_PE that I want to use for this, since it would make sense. However right now using those gives me the wrong mapping qualities so I will have to do dinner digging first. I think this might overlap with the issue about MAPQ being 0 sometimes (#52).
I created the branch with a button on GitHub to connect it to the issue and it set the name like that, but indeed it is a bit overkill :)

A curious observation here is also, that when I compare my SE result with the test SE result and the test PE result for the same read, the MAPQs are not identical in the test data either:
(base) paul@Paul-Theodors-MacBook-Pro build % grep "SRR1377138.6\t" test.se.sam                                      SRR1377138.6	0	NC_001422.1	649	60	1S184=1X115=	*	0	0	[...] (base) paul@Paul-Theodors-MacBook-Pro build % grep "SRR1377138.6\t" ../tests/phix.pe.sam                             SRR1377138.6	99	NC_001422.1	649	0	1S184=1X115=	=	719	-371	[...] SRR1377138.6	147	NC_001422.1	719	0	30=1X83=1X185=1S	=	649	371	[...] (base) paul@Paul-Theodors-MacBook-Pro build % grep "SRR1377138.6\t" ../tests/phix.se.sam SRR1377138.6	0	NC_001422.1	649	8	1S184=1X115=	*	0	0	[...]
So now I get a 60, the SE test data wants and 8 and the PE test data a 0, presumably the mapping quality should not differ between SE and PE mode? at least the CIGAR strings are all the same and the locations as well.
Anyway, I will poke around get_MAPQ for a bit more to see if I can find out what is happening here.

Without commenting at a detailed level. I do think that MAPQ is different if there is extra confidence for the mated read being aligned consistently nearby. This is how i remember trying to implement it. I think the other aligners would do that too (think I looked at BWA mem for this), although I am not sure.

Nevermind previous answer (was before coffee :). While my comment still holds, your particular set of observations indeed look suspicious - PE having lower confidence than SE. MAPQ is indeed something we should look at in detail. Your observation goes in the same trend as our variant calling results, strobealign has high precision but a bit lower sensitivity. I think more consistent MAPQ would improve these results.

I didn't have a lot of time this week to check it more clearly but I was wondering about the current implementation of MAPQ as // MAPQ = 40(1−s2/s1) ·min{1,|M|/10} · log s1 in the get_MAPQ function.
Where did this definition arise? As I understand it we would want to put our best guess for the probability that the alignment is wrong in the MAPQ score. So here we take 1 minus the ratio of best to second-best alignment and scale that to 40, i.e. if the alignments are equally good then we end up with MAPQ 0. Since 0*.
Now here is a fun question, if I have exactly two alignments and they are equally good and not discarded because of bad alignment score, would I assume the probability of a given alignment being wrong as 1, implying a MAPQ of 0, or would I assume the probability is 1/<#equally good alignments> and in this case 0.5 with a resulting MAPQ of around 3?
It seems like there is a bit of an issue with this, in the sense that there are no 'correct' MAPQ scores we can benchmark against, since that really depends on the algorithm and our choices.
For reference:
-10*log10(c(0.0001,0.5,0.9999,1.0))
40 3.01029 0.00043 0

Not at a computer so excuse my brevity and guessing.
First, our formula is from minimap2 I believe (see paper) if my memory is correct. If not, it’s from BWA.
Good example. I think this is where MAPQ scores from BWA/Bowtie2/tophat differs. Tophat uses the p=0.5 -> MAPQ=3 while bowtie or BwA use 0 whenever multiple identical. I’m not sure what makes sense. Following the initial interpretation of MAPQ, 3 would perhaps mimic the idea of the formula better.
see paper in issue #25 for some ideas.

Thanks, I will have a look over the paper as well. Maybe we need to have a discussion at some point to define what we want to go with. It might just be doing the same as minimap2?

I’ll try to move the discussion over to #25 (discussion in this PR should preferably be only about the refactoring itself).

Paul, your most recent commit made it so that all the changes are reverted (so the PR is "empty"). What are your plans for this PR?

I commit here the changes I wanted to do to align_SE, making it use get_alignment and get_MAPQ internally. The checks fail because the MAPQ values are not identical, but since there is no real ground truth this is a bit of an arbitrary hurdle, at least until we have defined how our MAPQ calculations should be done (as we discuss in #25). Fun fact, since I merged the main branch I can't compile it on my mac anymore, I wonder if anyone else has a mac to check if this is a general problem or if I just messed up my local environment somehow o.O

@PaulPyl , I am also having problems installing on mac as I reported in https://github.com/ksahlin/StrobeAlign/issues/102. I haven't tried to compile strobealign since before summer though, so cannot say whether this is a recently introduced problem.

Ok, this PR now compiles again but the checks fail because the MAPQ values are not matching anymore. This relates to #25 but I am unsure how to proceed. We should rework aln.cpp so that the align_SE function calls get_alignment and get_MAPQ and then make sure those two work as expected. For get_MAPQ we maybe need to define what "as expected" would mean.

I wish I had a good solution for this.
I think the MAPQ question is more of an open-ended research question. Do the reads seem to have a more logical MAPQ value after your fixes in this pull request? If so I wouldn't mind a merge.
It is on my plate to implement a smaller benchmark for this (in addition to rerunning the larger benchmarks I used for the paper).
What does Marcel think?

I closed this and deleted the branch, I think that issue needs a new run at it. Maybe after addressing the MAPQ score calculation.

Hm, sorry; it looked so nice to get rid of this amount of code ... maybe we should try to duduplicate/refactor this in smaller steps?
Please let me know when/if you start to work on this again. I wanted to do a couple of things that touch the align_SE function and don’t want to cause unnecessary merge conflicts.

You can go ahead and work on align_SE for now, I will let you know if I come back to it.


Passing tonic grpc client through Context to resolvers

Hello! I've been trying to make a GRPC call inside the query resolver. To do this I need to pass tonic generated client to data(Data::new(...)).
I tried to

pass client itself (with and without .clone()
pass Arc<Client>
pass tonic::transport::Channel to Context to clone the channel and create the client in resolver
pass Arc<tonic::transport::Channel> to Context

yet all of these attempts failed :(
Every time I get this error in runtime:
Error { message: "Data `alloc::sync::Arc<tonic::transport::channel::Channel>` does not exist.

This is current grpc channel extraction code:
let conn = ctx
            .data::<Arc<UserChanConn>>()
            .expect("failed to extract user service conn")
            .deref();

let mut client = UsersServiceClient::new(conn.clone());

Function that creates Schema<...>
pub fn create_schema_with_context(
    auth_client_conn: Arc<AuthChanConn>,
    users_client_conn: Arc<UserChanConn>,
) -> Schema<Query, EmptyMutation, EmptySubscription> {
    Schema::build(Query, EmptyMutation, EmptySubscription)
        .data(Data::new(auth_client_conn.clone()))
        .data(Data::new(users_client_conn.clone()))
        .finish()
}

File main.rs
pub type AuthChanConn = Channel;
pub type UserChanConn = Channel;

...

    let auth_conn_chan = Channel::from_static(&"http://[::1]:4775")
        .connect()
        .await
        .expect("Can't create a channel");

    let users_conn_chan = Channel::from_static(&"http://[::1]:4772")
        .connect()
        .await
        .expect("Can't create a channel");

    let schema = routes::create_schema_with_context(
        Arc::new(auth_conn_chan.clone()),
        Arc::new(users_conn_chan.clone())
    );

I haven't published this code to GitHub yet, but I can if needed.
Specifications
Library versions:
[dependencies]
actix-web = { version = "^4.0.0-beta.13", default-features = false}
async-graphql-actix-web = "^3.0.7"
tonic = "0.6.1"
[dependencies.async-graphql]
features = ["chrono", "tracing", "dataloader"]
version = "3.0.11"

Rust version: rustc 1.57.0-nightly
Helpful links
Discussion of concurrent use of GRPC client
PS: I'm pretty new to Rust so it might probably be a really dumb question, so sorry in advance 🙃 But I really can't google my way out of this one

You're wrapping the tonic client in Data::new when adding it to the context, but not when trying to get it.
Have you tried adding data to the context without Data::new? Something like:
Schema::build(Query, EmptyMutation, EmptySubscription)
        .data(auth_client_conn.clone())
        .data(users_client_conn.clone())
        .finish()

Or getting it with Data:
let conn = ctx
            .data::<Data<Arc<UserChanConn>>>()
            .expect("failed to extract user service conn")
            .deref();

Don't use actix_web::Data to wrap your data, unless you also use the type actix_web::Data<T> when you get it.
 Schema::build(Query, EmptyMutation, EmptySubscription)
        .data(auth_client_conn.clone())
        .data(users_client_conn.clone())
        .finish()

@dbstratta @sunli829 thank you very much! Removing actix_web::Data helped 🙂
Closing this issue.