Make http_proxy configuration work across both RedHat and Debian

The format for proxy variables is different across RedHat (existing) and Debian based systems (as tested with the apt repository provided by docker).
Make the docker install a separate play, rather than being a dependency so that it is easier to verify.

On debian, how does the $docker_config_dir/docker file get used? Sourced by some startup script? How does it get used if docker is launched with systemd? I'm admittedly a bit baffled that the docker daemon itself would be different and that I would want lower case env vars ever, but I didn't really look...

@eparis
snippet of the upstart script used by the docker package:
script
        # modify these in /etc/default/$UPSTART_JOB (/etc/default/docker)
        DOCKER=/usr/bin/$UPSTART_JOB
        DOCKER_OPTS=
        if [ -f /etc/default/$UPSTART_JOB ]; then
                . /etc/default/$UPSTART_JOB
        fi
        exec "$DOCKER" daemon $DOCKER_OPTS
end script

It sources the config file; while systemd uses EnvironmentFile.

@pedro-r-marques thank you so much!  Sadly, I'm still a little dense.
Sourcing this file means that docker is going to launch with an env var http_proxy=<IP_ADDRESS>. On the non-debian side it will get launched with an env var HTTP_PROXY=<IP_ADDRESS>.
Does docker pay attention to http_proxy instead of HTTP_PROXY?

@eparis lowercase "http_proxy" is the canonical variable that all unix utils tend to use (e.g. curl); the golang  HTTP code for instance respects that. I typically config this var on /etc/environment.
I'm not sure how docker handles capital HTTP_PROXY on systemd systems... i wouldn't be surprised if this ends up being treated the same way as lowercase http_proxy by docker/golang http code.

$ git describe --tags --always
go1.5beta3-1054-g6bf794a
golang/go [git master]
$ git grep HTTP_PROXY
src/net/http/proxy_test.go:     for _, v := range []string{"HTTP_PROXY", "http_proxy", "NO_PROXY", "no_proxy"} {
src/net/http/transport.go:// as directed by the $HTTP_PROXY and $NO_PROXY (or $http_proxy and
src/net/http/transport.go:// HTTP_PROXY, HTTPS_PROXY and NO_PROXY (or the lowercase versions
src/net/http/transport.go:// thereof). HTTPS_PROXY takes precedence over HTTP_PROXY for https
src/net/http/transport.go:              names: []string{"HTTP_PROXY", "http_proxy"},
src/net/http/transport_test.go: env      string // HTTP_PROXY
src/net/http/transport_test.go:         os.Setenv("HTTP_PROXY", tt.env)

In other words, yes, golang special cases this.  Agreed that http_proxy lowercase is canonical, and we could switch the other parts of the playbook to it.

I have seen the light! I guess I'd like to see a switch from HTTP_PROXY to http_proxy across the code base if the old way was the wrong way.
Now enlighten me about the docker as it's own play. You didn't remove the dependency that I see, so if it getting run twice?

@eparis Having something as an independent play make it easier to test and verify. And while dependencies where supposed to run only once per playbook (according to docs); they run multiple times on my setup. I think the right way to do this is to remove the docker dependencies from the existing plays... but my grasp of ansible is very limited.

I'm good/fine making it explicit, but lets pull out the dependencies. So   change the HTTP_PROXY to http_proxy and remove the dependancies from roles/node/meta/main.yml and roles/opencontrail/meta/main.yml and I'll commit.

@eparis done.


test.sh

Add to repo.
Document that you can vagrant ssh and then cd /vagrant and run ./test.sh.
This allows one to test provisioning scripts without having to completely re-provision and/or modify the actual provision script if just wanting to test some commands.

Changing default vagrant mount/share so that it points at a vagrant/ dir in root of proj. Moved test.sh into this dir.

Moved bootstrap into /vagrant as this is now more self-contained.


Disabling hover styles on mobile

If I create a custom media query that uses https://caniuse.com/#feat=css-media-interaction to target devices that are not mobile, I can do something like notmobile:hover:font-bold to make sure the bold style only takes effect not on mobile devices.
The problem is that I'd have to remember to always use notmobile:hover: everywhere I'm using hover:, which clutters the html and could lead to forgetting to use it in certain places.
A feature where we could set :hover to only apply for a certain media query that applies globally would be useful. Often the hover styles cause issues on mobile browsers where they're better off not being there.
Alternatively is there a way to write a media query that automatically appends another style to each style? So that when I create the notmobile media query I can tell it to generate all its styles appending :hover to it. Then I only need to use notmobile:font-bold instead of notmobile:hover:font-bold. This feature could be a better way of doing it than what I suggested before because this is more generic and could allow for interesting possibilities.

Could you expand on this? Because :hover is not even triggered on mobile.

Often the hover styles cause issues on mobile browsers where they're better off not being there.

It could be the case when you have content that is hidden/revealed on hover, but then thats also a problem for eveybody that's not using a mouse.

Alternatively is there a way to write a media query that automatically appends another style to each style?

It can be done with plugins

:hover is triggered on mobile.

:hovers behavior is browsers dependent on mobile. Safari sets hover on touch, and only removes it once another element is touched.

Exactly and this inconsistency is another reason to want to disable them.

You can create your own media rule to do this.
Add this to your tailwind.config.js
module.exports = {
    theme: {
        extend: {
            screens: {
                'notmobilehover': {'raw': '(hover: hover)'},
            }
        }
    }
}

This will check if hover is supported by the device and only run if media query translates to true.
You can use it like this :

hover over me

Best way is to use media query to detect if a device supports hover and only disable it if it does not.
This can be done by adding this to your tailwind.config.js file :
module.exports = {
    theme: {
        extend: {
            screens: {
                'betterhover': {'raw': '(hover: hover)'},
            }
        }
    }
}

Now you can use it like this : betterhover:font-bold

The downside to @VaibhavAcharya's solution is that it is currently not possible to make it responsive.


Exclude the headings from ToC for <Steps />

I have an issue writing the docs using the  component. For the steps to be parsed as steps, they need to be H3 (not H2 or H4). All the steps that have H3 are then visible in the right-side menu, which can make a mess of it because sometimes not all steps are worthy of being a menu item + if the level is not actually H3 it looks extra messy.
All my troubles would be solved if I could somehow mark certain headings so they are not included in the right-side menu but are parsed as steps.

you can do it by
<Steps>
-### Install
+{
Install
}

more info on why it works https://nextra.site/docs/guide/advanced/table#why-this-happens
feel free to contribute to steps docs

Thank you so much! Will try and update the docs!

you can do it by
<Steps>
-### Install
+{
Install
}

more info on why it works https://nextra.site/docs/guide/advanced/table#why-this-happens
feel free to contribute to steps docs

Main problem with this solution is that it means steps will no longer get anchor tags :-/

yeah I also had the same issue, no anchor tags :(


Promote Services shell out of flaky. Demote Elasticsearch

Elasticsearch is unfortunately still flaky
Shell services test was fix by #10978
cc @davidopp @satnam6502 @quinton-hoole

This is an unrelated e2e test failures:
Kubernetes e2e suite.Kubectl client Update Demo should scale a replication controller
Kubernetes e2e suite.Probing container with readiness probe that fails should never be ready and never restart
Kubernetes e2e suite.Pods should contain environment variables for services
Kubernetes e2e suite.Pods should *not* be restarted with a docker exec "cat /tmp/health" liveness probe

I will look into it independently, now kicking the bot to rerun tests.

@k8s-bot please test

@k8s-bot test this please

I don't think the Elasticsearch test should be demoted. It is doing its job. Demote the test that makes nodes unhealthy -- a situation which is then detected and flagged by Elasticsearch.

One one of failures I saw yesterday was due to a node that I think was made unhealthy by a previous test. The Elasticsearch test makes sure there are at least two healthy nodes before proceeding and declares failure if there are not. I reported this to @quinton-hoole and to me is seems wrong to demote this test when its environment was probably sabotaged by another test.
The last failure I saw was due to something that I think is an on-going problem with our system. Every so often when a request is made via  service it is then unable to be mapped to a pod to service it -- even when pods were detected and ready earlier on in the test. I think this is exposing a bug -- a bug our customers will face in a similar situation. Rather than demoting the test let us understand if this is really a genuine issue and file a bug for it and fix it -- and if this is behaviour as expected (which in my opinion would be very undesireable for our customers) -- then let us document this clearly and also state how such failures should be handled and then implement that process here.
Let's not demote this test because -- as always -- it's pointing out things we need to think about.
Cluster level logging using Elasticsearch
  should check that logs from pods on all nodes are ingested into Elasticsearch
  /go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/es_cluster_logging.go:46
[BeforeEach] Cluster level logging using Elasticsearch
  /go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/framework.go:47
STEP: Creating a kubernetes client
>>> testContext.KubeConfig: /var/lib/jenkins/jobs/kubernetes-e2e-gce/workspace/.kube/config
STEP: Building a namespace api object
INFO: Waiting up to 2m0s for service account default to be provisioned in ns e2e-tests-es-logging-ktu1s
INFO: Get service account default in ns e2e-tests-es-logging-ktu1s failed, ignoring for 5s: serviceaccounts "default" not found
INFO: Service account default in ns e2e-tests-es-logging-ktu1s with secrets found. (5.007973585s)
STEP: Waiting for a default service account to be provisioned in namespace
INFO: Waiting up to 2m0s for service account default to be provisioned in ns e2e-tests-es-logging-ktu1s
INFO: Service account default in ns e2e-tests-es-logging-ktu1s with secrets found. (2.750763ms)
[BeforeEach] Cluster level logging using Elasticsearch
  /go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/es_cluster_logging.go:42
[It] should check that logs from pods on all nodes are ingested into Elasticsearch
  /go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/es_cluster_logging.go:46
STEP: Checking the Elasticsearch service exists.
STEP: Checking to make sure the Elasticsearch pods are running
INFO: Waiting up to 5m0s for pod elasticsearch-logging-v1-95un8                          status to be running
INFO: Found pod 'elasticsearch-logging-v1-95un8' on node 'e2e-gce-minion-eu5s'
INFO: Waiting up to 5m0s for pod elasticsearch-logging-v1-mxzyv                          status to be running
INFO: Found pod 'elasticsearch-logging-v1-mxzyv' on node 'e2e-gce-minion-armt'
STEP: Checking to make sure we are talking to an Elasticsearch service.
INFO: Bad JSON: Error: 'dial tcp <IP_ADDRESS>:9200: connection refused'
Trying to reach: 'http://<IP_ADDRESS>:9200/'
INFO: After 6.417267ms failed to convert Elasticsearch JSON response Error: 'dial tcp <IP_ADDRESS>:9200: connection refused'
Trying to reach: 'http://<IP_ADDRESS>:9200/' to map[string]interface{}: failed to unmarshal Elasticsearch response: invalid character 'E' looking for beginning of value
STEP: Checking health of Elasticsearch service.
INFO: Bad JSON: Error: 'dial tcp <IP_ADDRESS>:9200: connection refused'
Trying to reach: 'http://<IP_ADDRESS>:9200/_cluster/health?health=pretty'
[AfterEach] Cluster level logging using Elasticsearch
  /go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/framework.go:48
STEP: Collecting events from namespace "e2e-tests-es-logging-ktu1s".
INFO: Node e2e-gce-minion-armt condition 1/1: type: Ready, status: True
INFO: Node e2e-gce-minion-eu5s condition 1/1: type: Ready, status: True
STEP: Destroying namespace "e2e-tests-es-logging-ktu1s" for this suite.

• Failure [15.319 seconds]
Cluster level logging using Elasticsearch
/go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/es_cluster_logging.go:47
  should check that logs from pods on all nodes are ingested into Elasticsearch [It]
  /go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/es_cluster_logging.go:46

  Expected error:
      <*errors.errorString | 0xc208136e20>: {
          s: "failed to unmarshal Elasticsearch response: invalid character 'E' looking for beginning of value",
      }
      failed to unmarshal Elasticsearch response: invalid character 'E' looking for beginning of value
  not to have occurred

  /go/src/github.com/GoogleCloudPlatform/kubernetes/_output/dockerized/go/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/es_cluster_logging.go:163

The last failure I saw was due to something that I think is an on-going problem with our system. Every so often when a request is made via service it is then unable to be mapped to a pod to service it -- even when pods were detected and ready earlier on in the test (as confirmed by the log below). I think this is exposing a bug -- a bug our customers will face in a similar situation. Rather than demoting the test, let us understand if this is really a genuine issue and file a bug for it and fix it -- and if this is behaviour as expected (which in my opinion would be very undesireable for our customers) -- then let us document this clearly and also state how such failures should be handled and then implement that process here.
Not sure if I understood correctly - so please correct me if I misunderstood something.
Assume that we have few pods running. Then you create a service. If you send a request to a serivce immediately after creating a service, endpoints of the service may not be propagated to all kube-proxy instances yet. Thus, I think it is by design, that immediately after creating a service (even if pods are already running), they are not accessible. If that's the case - we should fix the test.

As I said before, this connection error occurs after there have already been successfully GET requests earlier in the test. Checking the cluster health check via Elasticsearch is done after other successful requests.
	// Now assume we really are talking to an Elasticsearch instance.
	// Check the cluster health.
	By("Checking health of Elasticsearch service.")
	var body []byte
	for start := time.Now(); time.Since(start) < graceTime; time.Sleep(5 * time.Second) {
		body, err = f.Client.Get().
			Namespace(api.NamespaceSystem).
			Prefix("proxy").
			Resource("services").
			Name("elasticsearch-logging").
			Suffix("_cluster/health").
			Param("health", "pretty").
			DoRaw()
		if err == nil {
			break
		}
	}
	Expect(err).NotTo(HaveOccurred())

I did find a bad use of err which somehow got introduced which masks a failure. #11001

I will dig into this further to make sure I am not going mad.

@wojtek-t this is the first attempt to speak to the application endpoint. It happens after the pods are determined to be ready and is retried to give enough time for the application inside the pod to come to life. Surely this is enough? Or am I wrong?
	By("Checking to make sure the Elasticsearch pods are running")
	label := labels.SelectorFromSet(labels.Set(map[string]string{esKey: esValue}))
	pods, err := f.Client.Pods(api.NamespaceSystem).List(label, fields.Everything())
	Expect(err).NotTo(HaveOccurred())
	for _, pod := range pods.Items {
		err = waitForPodRunningInNamespace(f.Client, pod.Name, api.NamespaceSystem)
		Expect(err).NotTo(HaveOccurred())
	}

	By("Checking to make sure we are talking to an Elasticsearch service.")
	// Perform a few checks to make sure this looks like an Elasticsearch cluster.
	var statusCode float64
	var esResponse map[string]interface{}
	err = nil
	var body []byte
	for start := time.Now(); time.Since(start) < graceTime; time.Sleep(5 * time.Second) {
		// Query against the root URL for Elasticsearch.
		body, err = f.Client.Get().
			Namespace(api.NamespaceSystem).
			Prefix("proxy").
			Resource("services").
			Name("elasticsearch-logging").
			DoRaw()
		if err != nil {
			Logf("After %v proxy call to elasticsearch-loigging failed: %v", time.Since(start), err)
			continue
		}
		esResponse, err = bodyToJSON(body)
		if err != nil {
			Logf("After %v failed to convert Elasticsearch JSON response %v to map[string]interface{}: %v", time.Since(start), string(body), err)
			continue
		}
		statusIntf, ok := esResponse["status"]
		if !ok {
			Logf("After %v Elasticsearch response has no status field: %v", time.Since(start), esResponse)
			continue
		}
		statusCode, ok = statusIntf.(float64)
		if !ok {
			// Assume this is a string returning Failure. Retry.
			Logf("After %v expected status to be a float64 but got %v of type %T", time.Since(start), statusIntf, statusIntf)
			continue
		}
		break
	}
	Expect(err).NotTo(HaveOccurred())
	if int(statusCode) != 200 {
		Failf("Elasticsearch cluster has a bad status: %v", statusCode)
	}

OK - I changed the PR so that it doesn't demote ElasticSearch test - we should investigate it independently (on the other hand I didn't see the failure since #11001 was merged).
PTAL

LGTM

Thank you @wojtek-t -- I am still trying to get to the bottom of this -- although my vacation to Europe in the next two weeks might get in the way.

Hi @wojtek-t
This PR seems to have completely broken e2e-gce-parallel.  Could you add "Services.*shell" to GCE_PARALLEL_FLAKY_TEST_REGEX until it's parallel friendly?


Preserve filter on server on reload

Description
Run processHashChange before updateTasks on page load so the server-side filtering box gets properly checked.
Motivation and Context
processHashChange only gets called after updateTasks, so filter on the checkbox only gets checked after we make the server request without filtering. This results in a checked box but no server-side filtering.
Have you tested this? If so, how?
Ran the server locally with a small max_shown tasks and tried refreshing with a server-side filter. Without this change, no tasks are shown after the refresh. With this change, the filtered tasks are shown.

@daveFNbuck I'm trying to fix these excessive new flake8 tests over on #2274 but somehow managed to get hit with many more annoying flake8 failures. Do you have experience with the flake8 linter to know why this happened or how to resolve?


🔒 Fix permissions

Do a check-up and fix permissions

@Lugrim which permissions were you talking about (if you can remember) ?

It was more a general issue because everything implemented up to that point did not care about permissions, or was using user.IsAdmin only

Ok, I think this is fixed now with the current evolution.
I will do a check on the first routes written.


Support for a folder id inside a repository

Hi Team,
Is there any support for this plugin to make use of folder id inside a repository id for e.g. rep=guid1&obj=guid2 where obj is a folder?
Regards,
Vishal Kwatra

Hi @vishalkwatra,
No, the plugin doesn't supports the use of folder id inside a respository id.

@vishalkwatra could you explain about your use-case where you need support of folder id?


Ping timeout

[ ] The FAQ doesn't contain a resolution to my issue

Versions

mineflayer: #.#.#
server: vanilla/spigot/paper #.#.#
node: #.#.#

Detailed description of a problem
i am using bedrock multi instance and one of my accounts keeps ping timeing out and it randomly stops
What did you try yet?
Did you try any method from the API?
Did you try any example? Any error from those?
Your current code
const bedrock = require('bedrock-protocol');

// Configuration
const serverHost = 'donutSMP.net'; // The Bedrock server you want to connect to
const serverPort = 19132; // The port of the Bedrock server

// Define account configurations
const accounts = [
    {
        username: 'hiqril',
    },
    {
        username: 'raxFR',
    }
];

// Function to create a client for a single account
function createAndConnectClient(account) {
    // Create a client to connect to the Bedrock server
    const client = bedrock.createClient({
        host: serverHost,
        port: serverPort,
        username: account.username,
        offline: false, // Set to true to enable offline mode
    });

    // Handle successful connection
    client.on('connect', () => {
        console.log(`Connected to server as ${account.username}`);
    });

    // Handle the 'spawn' event
    client.on('spawn', () => {
        console.log(`${account.username} has spawned on the server.`);
    });

    // Handle connection errors
    client.on('error', (error) => {
        console.error(`Connection error for ${account.username}:`, error);
    });

    // Handle Reconnect errors
    client.on('end', () => {
        console.log(`${account.username} disconnected from the server. Reconnecting...`);
        createAndConnectClient(account);
    });

    // Add more event listeners here as needed
}

// Connect each account to the server
function connectBothAccounts() {
    for (const account of accounts) {
        createAndConnectClient(account);
    }
}

// Start the connection process for both accounts
connectBothAccounts();

Expected behavior
to both accounts launch and not timeout every few hours
Additional context
when it times out i sometimes have to wait long hours 6+

This is because the server is unreachable. You need to make sure you can connect with a vanilla client when you get that error. If it works sometimes, it could be an intermediate issue with the server.

it works fine in java and bedrock its just that it crashes / timeout

This is because the server is unreachable. You need to make sure you can connect with a vanilla client when you get that error. If it works sometimes, it could be an temporary issue with the server.

it works fine in java and bedrock its just that it crashes / timeout

bro just use mineflayer cz you have a java server


call encryptWithEntity with password

seems like a copy/paste error ?

Good catch, was a copy / paste error!


Lazy module import into variable with union type causes wrong type error

Bug Report

🔎 Search Terms

lazy, import
🕗 Version & Regression Information

I observed this first in version 4.6.2. I then verified that the issue still exists in the latest nightly build (v4.7.0-dev.20220406) and at least as far back as version 3.9.7 (it likely existed even before that but I think checking the latest 3.X version should be enough).
⏯ Code & Bug Workbench Link
// @filename: one.ts
export const one = 1

// @filename: two.ts
const x: Promise<1> = import('./one').then((m) => m.one)
const y: Promise<1> | Promise<2> = import('./one').then((m) => m.one) // wrong type error here
const z: Promise<1> | Promise<2> = x

Workbench Repro
🙁 Actual behavior

In the code sample above, the assignment to y causes a wrong type error, while assigning to z from an intermediate variable does not cause a type error. I don't think I need to explain why this is wrong.
The error also seems to indicate that type inference was somehow done in the wrong direction, since it seems to think that the type of the import is Promise<1 | 2> while it clearly is Promise<1>:
Type 'Promise<1 | 2>' is not assignable to type 'Promise<1> | Promise<2>'.
  Type 'Promise<1 | 2>' is not assignable to type 'Promise<1>'.
    Type '1 | 2' is not assignable to type '1'.
      Type '2' is not assignable to type '1'.(2322)

🙂 Expected behavior

The assignment to y should not cause a type error.

Modules not necessary:
declare const onePromise: Promise<{ one: 1 }>;

const x: Promise<1> = onePromise.then((m) => m.one)
const y: Promise<1> | Promise<2> = onePromise.then((m) => m.one)
const z: Promise<1> | Promise<2> = x

The problem here is that when finding inference candidates for T's type parameter, we see both 1 and 2, and those have equal footing with the other candidates. For other types this is generally desirable, but Promise a bit special due to its callback nature and this ends up doing a bit more harm than good.
The "fix" is to write a type argument
const y: Promise<1> | Promise<2> = onePromise.then<1>((m) => m.one)

This behavior is a bit unfortunate since it affects a public API method of a library I'm working on and I don't want to force my users to have to specify the types, but I guess I'll find a workaround.


incomplete content display

Attach (recommended) or Link to PDF file here:
测试文件.pdf
Configuration:

Web browser and its version:chrome 92.0.4515.131
Operating system and its version: windows
PDF.js version:v2.9.359
Is a browser extension:no

Steps to reproduce the problem:

use pdf.js to open this pdf file
incomplete content display

What is the expected behavior? (add screenshot)

What went wrong? (add screenshot)

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

The problem has been solved. Thank you


Add Hera logo to README

Pull Request Checklist

[x] Fixes #1003

As we didn't have much activity in the issue for actual graphics, credit to @flaviuvadan who generated some logos using AI.
I traced the logo to create a vector image. V1 is a bit rough and ready, I haven't measured anything for the hexagon to be exact but looks alright for now.

I'd like approval from both @flaviuvadan and @samj1912 for this one as it's a brand new thing for Hera

Docs page working now after some messing around


Add the option to use build cache in CI

Have you read the Contributing Guidelines on issues?

[X] I have read the Contributing Guidelines on issues.

Motivation
In the 2.0.0-alpha.20 release (changelog)[https://docusaurus.io/changelog/2.0.0-alpha.20], cache-loader was disabled for CI because of the assumption CI always starts from scratch. This assumption is not always valid.
Related PR that made this change is #1612
For example, you can cache node_modules/.cache in Github Actions which can then be restored and used as a cache from the previous build. Github actions will restore the cache from the main branch if the feature branch has no cache associated with it. This would allow for significantly reduced build times in CI environments where the cache can be restored after installing modules.
Since there is no support for incremental regeneration, then this might be the next best option. In our case it reduces build from 12 min to around 3 min if the cache is present.
I'm not sure how much overhead cache-loader added when no cache was present, but if it is significant then adding this behind a flag seems reasonable.
Self-service

[x] I'd be willing to do some initial work on this proposal myself.

Nevermind, this appears to have been re-added at some point and just didn't make it into a change log

Webpack v5 automatically has persistent cache; we don't need to implement it ourselves anymore.

Webpack v5 automatically has persistent cache; we don't need to implement it ourselves anymore.

Not 100% automatic for Webpack, but enabled by default for Docusaurus
We have a config to declare that we want to use a cache in both dev/prod and client/server (4 cache items per locale)
cache: {
  type: 'filesystem',
  name: `${name}-${mode}-${props.i18n.currentLocale}`,
}

So in theory you just need to preserve the .cache folder across builds to get faster rebuilds
I'd like to document this better, among other things related to deployment, perf and scalability


Update the values section on the homepage

Description
We recently updated the homepage, but the values should reflect our Product Mission Statement and Strategy as well https://flowfuse.com/blog/2024/05/product-strategy-updates/
Epic/Story
No response
Have you provided an initial effort estimate for this issue?
I have provided an initial effort estimate

@Hasmin-AC as we talked about during our last department meeting, we should update that section. Could you please provide the content?

@Yndira-E looking at the blog closely and what we have on home page, we don't need to update anything to align them. ZJ will however think about some other changes we need to make to update our messaging.

Thanks for the update!


[Feature] use limu to generate immutable json object

Describe the bug
Limu is now the fatest immutable js lib, can solid author consider using it for immutable situation?
Your Example Website or App
https://tnfe.github.io/limu/
Steps to Reproduce the Bug or Issue
performance image

this is a feature.
Expected behavior
this is a feature.
Screenshots or Videos
this is a feature.
Platform
this is a feature.
Additional context
this is a feature.

What is an "immutable situation" in the context of solid-js? We rely on signals, not on reconciliation of immutable objects.

Yeah I'm not sure what this has to do with anything. Maybe I will move this to a discussion.


Reconnect issue?

As my path to try to have a workaround for https://github.com/vik-borisov/TelegramClient/issues/53 I tried reconnecting. After doing that I get an internal error from the library.
Code:
private static async void Reconnect(ITelegramClient client)
{
	Log.Info("Logging out");
	await client.ConnectService.LogOut();
	Log.Info("Logged out");
	Log.Info("Connecting");
	await client.ConnectService.ConnectAsync();
	Log.Info("Connected");
}

Exception:
"Couldn't read the packet length"
   at TelegramClient.Core.Network.Tcp.TcpTransport.<Receieve>d__9.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at TelegramClient.Core.Network.MtProtoPlainSender.<SendAndReceive>d__9.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at TelegramClient.Core.ApiServies.ConnectApiService.<DoAuthentication>d__26.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at TelegramClient.Core.ApiServies.ConnectApiService.<ConnectAsync>d__25.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at TelegramCryptoClient.Program.<Reconnect>d__56.MoveNext() in C:\Repositories\Koala\trunk\TelegramCryptoClient\TelegramCryptoClient\Program.cs:line 450

Hmm, I used to get another exception, but that is probably when the connection is already bad or so because of other issue mentioned above.
Other exception:
2018-01-25 05:05:29.1033 [25] ERROR Program.CheckUpdates System.AggregateException: One or more errors occurred. (Object reference not set to an instance of an object.) ---> System.NullReferenceException: Object reference not set to an instance of an object.
   at TelegramClient.Core.Network.MtProtoSendService.PrepareToSend(IObject obj, Int64& mesId)
   at TelegramClient.Core.Network.MtProtoSendService.<Send>d__17.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at TelegramClient.Core.ApiServies.SenderService.<SendAndRecieve>d__14.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at TelegramClient.Core.ApiServies.SenderService.<SendRequestAsync>d__13`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at TelegramClient.Core.ApiServies.UpdatesApiService.<GetUpdates>d__5.MoveNext()
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task`1.GetResultCore(Boolean waitCompletionNotification)
   at TelegramCryptoClient.Program.<CheckUpdates>d__58.MoveNext() in C:\Repositories\Koala\trunk\TelegramCryptoClient\TelegramCryptoClient\Program.cs:line 465
---> (Inner Exception #0) System.NullReferenceException: Object reference not set to an instance of an object.
   at TelegramClient.Core.Network.MtProtoSendService.PrepareToSend(IObject obj, Int64& mesId)
   at TelegramClient.Core.Network.MtProtoSendService.<Send>d__17.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at TelegramClient.Core.ApiServies.SenderService.<SendAndRecieve>d__14.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at TelegramClient.Core.ApiServies.SenderService.<SendRequestAsync>d__13`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at TelegramClient.Core.ApiServies.UpdatesApiService.<GetUpdates>d__5.MoveNext()<---
 System.AggregateException: One or more errors occurred. (Object reference not set to an instance of an object.) ---> System.NullReferenceException: Object reference not set to an instance of an object.
   at TelegramClient.Core.Network.MtProtoSendService.PrepareToSend(IObject obj, Int64& mesId)
   at TelegramClient.Core.Network.MtProtoSendService.<Send>d__17.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at TelegramClient.Core.ApiServies.SenderService.<SendAndRecieve>d__14.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at TelegramClient.Core.ApiServies.SenderService.<SendRequestAsync>d__13`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at TelegramClient.Core.ApiServies.UpdatesApiService.<GetUpdates>d__5.MoveNext()
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task`1.GetResultCore(Boolean waitCompletionNotification)
   at TelegramCryptoClient.Program.<CheckUpdates>d__58.MoveNext() in C:\Repositories\Koala\trunk\TelegramCryptoClient\TelegramCryptoClient\Program.cs:line 465
---> (Inner Exception #0) System.NullReferenceException: Object reference not set to an instance of an object.
   at TelegramClient.Core.Network.MtProtoSendService.PrepareToSend(IObject obj, Int64& mesId)
   at TelegramClient.Core.Network.MtProtoSendService.<Send>d__17.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at TelegramClient.Core.ApiServies.SenderService.<SendAndRecieve>d__14.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at TelegramClient.Core.ApiServies.SenderService.<SendRequestAsync>d__13`1.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at TelegramClient.Core.ApiServies.UpdatesApiService.<GetUpdates>d__5.MoveNext()<---

@KoalaBear84
Does reconnect work?

How do you know which dcId to use? How also do you know when the connection has gone bad as I don't see any methods in the connect service to get the current state

@danextras
after connecting the server sends the nearest ds

Which framework call is this in? I couldn't see anything like that in the BuildClient or ConnectService.ConnectAsync methods about a dc id.

It is the internal structure of the library
https://github.com/vik-borisov/TelegramClient/blob/d03da6de2becf55895ef438c4bb26bbe4e5a04ae/src/TelegramClient.Core/ApiServies/ConnectApiService.cs#L103

Ok, when you said "does the reconnect work" earlier, I figured you meant the method ConnectService.ReconnectToDcAsync which takes the dcId.
Since you are only ever attached to one dc at a time and _dcOptions is private, can you make another method for reconnect that doesn't receive the dc id and just reconnects to the dc that we were last connected to?

@danextras it is not a good idea.
let the library engage in systems activities

Yes I would prefer if the library would catch that error that KoalaBear84
mentioned and reconnect automatically.
On Mon, 12 Feb 2018 16:25 Viktor Borisov<EMAIL_ADDRESS>wrote:

@danextras https://github.com/danextras it is not a good idea.
let the library engage in systems activities
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/vik-borisov/TelegramClient/issues/54#issuecomment-364976586,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AE6vDjaoBplrwtk0GSp6bwtYuTLEiEuXks5tUGXegaJpZM4Rt9uU
.


Add PolyNet

PolyNet model from PolyNet: A Pursuit of Structural Diversity in Very Deep Networks.
Weights are ported from the Caffe implementation. Accuracy values for the original model were taken from the paper (Table 1).
PyTorch weights: https://drive.google.com/file/d/1gzAvavIaxRG38cOkuWb-NxjBHJ6YGqE4/view
A note on the evaluation: as far as I understand to evaluate the performance of the model on the ImageNet evaluation set the authors resized images to 378x378 without maintaining the aspect ratio and then took a center 331x331 crop. To mimic this behavior I have to modify imagenet_eval.py and add the --do-not-preserve-aspect-ratio argument, but I am not sure maybe there are better ways of handling this, what do you think?
For the modified command (python examples/imagenet_eval.py --data /path/to/imagenet -a polynet -b 64 -e --do-not-preserve-aspect-ratio) I got Acc@1 81.002 Acc@5 95.624. When the standard evaluation that preserves the aspect ratio is used resulting accuracy values for the model are slightly worse:  Acc@1 80.858 Acc@5 95.560

To handle the special preprocessing, we could create a new key to the pretrained_settings dictionary. But I am ok with the --do-not-preserve-aspect-ratio flag for now. The note is there. If anyone needs it we can add it in a near future.
Thanks!

@Cadene PolyNet model weights have the same PyTorch 0.3 compatibility issue as PNasNet in #65, so here is an updated version of weights that should be compatible both with PyTorch 0.3.1 and 0.4, could you test it in your environment?
https://drive.google.com/file/d/1Zj_RzCnIFqZgYLieE3sPdRRE8b3D-89S/view

@creafz Done! https://github.com/Cadene/pretrained-models.pytorch/commit/3acaa88d8145db265b5e1dec03e91eb751b82c74


Provide support for script arguments

Work towards dapperlabs/flow-go#3068.
Depends on https://github.com/onflow/flow/pull/20.
Description
Update access proto, adding Arguments field to script requests. This is work towards implementing script params as described in the above issue.
I believe you two have opinions about how to proceed with backwards compatibility by supporting both means of passing in parameters, so I just wanted to open up this PR in the interim.

@JeffreyDoyle i think we are good to close this no?

@JeffreyDoyle i think we are good to close this no?

Bringing this branch up to date so it can be merged now


Incorrect code block formatting

The code blocks following the 'Update the user secrets' heading are not formatted correctly

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e5df2491-1abe-0211-efbf-c1fb384862e9
Version Independent ID: f7f0d2cf-3f4f-44dc-54aa-cd59221264d2
Content: Use Key Vault to protect application secrets
Content Source: docs/multitenant-identity/key-vault.md
Service: guidance
GitHub Login: @MikeWasson
Microsoft Alias: pnp

Ah, I see it now. Thanks! 😺


Improve cargo --list output (split output into sections)

(Related to #12114 , but the scope of that issue is bigger and this PR doesn't close it.)
What does this PR try to resolve?
cargo --list's output is really bad. It mixes aliases, builtin commands and external commands.
It would look something like this:
$ cargo --list
Installed Commands:
    add                  Add dependencies to a Cargo.toml manifest file
    b                    alias: build
    bench                Execute all benchmarks of a local package
    build                Compile a local package and all of its dependencies
    build-man            alias: run --package xtask-build-man --
    bump
    c                    alias: check
    check                Check a local package and all of its dependencies for errors
    checktests
    clean                Remove artifacts that cargo has generated in the past
    clippy               Checks a package to catch common mistakes and improve your Rust code.
    config               Inspect configuration values
    d                    alias: doc
    doc                  Build a package's documentation
    examples
    expand
    fetch                Fetch dependencies of a package from the network
    fix                  Automatically fix lint warnings reported by rustc
    flowistry
    fmt                  Formats all bin and lib files of the current crate using rustfmt.
    generate
    generate-lockfile    Generate the lockfile for a package
    git-checkout         This command has been removed
    help                 Displays help for a cargo subcommand
    init                 Create a new cargo package in an existing directory
    install              Install a Rust binary. Default location is $HOME/.cargo/bin
    is-tested
    locate-project       Print a JSON representation of a Cargo.toml file's location
    login                Save an api token from the registry locally. If token is not specified, it will be read from stdin.
    logout               Remove an API token from the registry locally
    metadata             Output the resolved dependencies of a package, the concrete used versions including overrides, in machine-readable format
    miri
    new                  Create a new cargo package at <path>
    owner                Manage the owners of a crate on the registry
    package              Assemble the local package into a distributable tarball
    pkgid                Print a fully qualified package specification
    publish              Upload a package to the registry
    r                    alias: run
    rdme
    read-manifest        Print a JSON representation of a Cargo.toml manifest.
    remove               Remove dependencies from a Cargo.toml manifest file
    report               Generate and display various kinds of reports
    rm                   alias: remove
    run                  Run a binary or example of the local package
    rustc                Compile a package, and pass extra options to the compiler
    rustdoc              Build a package's documentation, using specified custom flags.
    search               Search packages in crates.io
    set-version
    stale-label          alias: run --package xtask-stale-label --
    t                    alias: test
    test                 Execute all unit and integration tests and build examples of a local package
    tree                 Display a tree visualization of a dependency graph
    udeps
    uninstall            Remove a Rust binary
    unpublished          alias: run --package xtask-unpublished --
    update               Update dependencies as recorded in the local lock file
    upgrade
    vendor               Vendor all dependencies for a project locally
    verify-project       Check correctness of crate manifest
    version              Show version information
    watch
    yank                 Remove a pushed crate from the index

Finding a command is very hard in this list. That's why this PR aims to fix this list.
It groups builtin commands, external and aliases in three different sections. It also groups builtin commands with its builtin aliases.
    build, b             Compile a local package and all of its dependencies

The final output looks like this
$ cargo run -- --list
Installed Commands:
====================
  Builtin commands:
    add                  Add dependencies to a Cargo.toml manifest file
    bench                Execute all benchmarks of a local package
    build, b             Compile a local package and all of its dependencies
    check, c             Check a local package and all of its dependencies for errors
    clean                Remove artifacts that cargo has generated in the past
    config               Inspect configuration values
    doc, d               Build a package's documentation
    fetch                Fetch dependencies of a package from the network
    fix                  Automatically fix lint warnings reported by rustc
    generate-lockfile    Generate the lockfile for a package
    git-checkout         This command has been removed
    help                 Displays help for a cargo subcommand
    init                 Create a new cargo package in an existing directory
    install              Install a Rust binary. Default location is $HOME/.cargo/bin
    locate-project       Print a JSON representation of a Cargo.toml file's location
    login                Save an api token from the registry locally. If token is not specified, it will be read from stdin.
    logout               Remove an API token from the registry locally
    metadata             Output the resolved dependencies of a package, the concrete used versions including overrides, in machine-readable format
    new                  Create a new cargo package at <path>
    owner                Manage the owners of a crate on the registry
    package              Assemble the local package into a distributable tarball
    pkgid                Print a fully qualified package specification
    publish              Upload a package to the registry
    read-manifest        Print a JSON representation of a Cargo.toml manifest.
    remove, rm           Remove dependencies from a Cargo.toml manifest file
    report               Generate and display various kinds of reports
    run, r               Run a binary or example of the local package
    rustc                Compile a package, and pass extra options to the compiler
    rustdoc              Build a package's documentation, using specified custom flags.
    search               Search packages in crates.io
    test, t              Execute all unit and integration tests and build examples of a local package
    tree                 Display a tree visualization of a dependency graph
    uninstall            Remove a Rust binary
    update               Update dependencies as recorded in the local lock file
    vendor               Vendor all dependencies for a project locally
    verify-project       Check correctness of crate manifest
    version              Show version information
    yank                 Remove a pushed crate from the index
====================
  External commands:
    bump
    checktests
    clippy               Checks a package to catch common mistakes and improve your Rust code.
    examples
    expand
    flowistry
    fmt                  Formats all bin and lib files of the current crate using rustfmt.
    generate
    is-tested
    miri
    mommy
    rdme
    set-version
    udeps
    upgrade
    watch
====================
  Aliases:
    b                    build
    build-man            run --package xtask-build-man --
    c                    check
    d                    doc
    r                    run
    rm                   remove
    stale-label          run --package xtask-stale-label --
    t                    test
    unpublished          run --package xtask-unpublished --

How should we test and review this PR?
Execute cargo run -- --list (in the Cargo repository) and check that the output is better than before.

I'll close it and elaborate on #12114


finish the Users component

This page has:

[x] a list of users that have been discovered
[ ] a search box to find people

Search box is harder than expected:

requires an in memory dictionary (username to userid) to filter through

could have an autocomplete system that works over a search index which itself is made up of ipfs objects. look into @krl's great work on:

https://github.com/krl/aolog
https://github.com/krl/uplog
https://github.com/ipfs/ipfs-geoip

@jbenet Thanks a lot! aolog looks expecially interesting and very useful to solve this problem.


[Table] Add "Device Only" Classes

Something along the lines of "[desktop|tablet|mobile] only [table|row|column]"
Often you want to hide extraneous info columns on mobile and tablet, but show a lot of info columns on desktop.

Any progress or work around in this ?
In mobile devices you dont always need a lot of the information show on the table.

Use media queries, standard CSS works great here

While we can use media queries it's a really shame that Semantic UI doesn't offer this basic requirement. It would be nice to simply do this:

...

Just as we can when laying out columns. As it is we have to manually create them by searching through the semantic code in order to find the various cut off points variables for mobile, tablet and computer devices.

I agree, and not just for tables. I wanted to have Icon + Text buttons on an indexbar at the top of the page on tablet or greater devices and just Icons for mobile devices. I ended up having to add these rules in manually:
@media only screen and ( max-width: @largestMobileScreen ) {
  .not.mobile {
    display: none !important;
  }
}
@media only screen and ( min-width: @tabletBreakpoint ) {
  .only.mobile {
    display: none !important;
  }
}

I can't see a reason why the grid device visibility functionality couldn't be loosened so that it can apply to any element? http://semantic-ui.com/collections/grid.html#device-visibility

I totally agree that this is needed.  It seems quite natural to me that SUI would offer this by default.

I submitted a PR to help address this after dealing with it in a project. https://github.com/Semantic-Org/Semantic-UI/pull/4378

Thanks @squareleaf :) That looks great!


jQuery noConflict compatibility fix

Adding the possibility to function in a noConflict environment.
See https://api.jquery.com/jquery.noconflict/

ty!

np :)


recursion error trying to run the tb

Traceback (most recent call last):
  File "tb_smolcpu.py", line 28, in <module>
    sim = Simulator(dut)
  File "/home/matt/.local/lib/python3.8/site-packages/amaranth/sim/core.py", line 68, in __init__
    self._engine   = engine(self._fragment)
  File "/home/matt/.local/lib/python3.8/site-packages/amaranth/sim/pysim.py", line 282, in __init__
    self._processes = _FragmentCompiler(self._state)(self._fragment)
  File "/home/matt/.local/lib/python3.8/site-packages/amaranth/sim/_pyrtl.py", line 463, in __call__
    processes.update(self(subfragment))
  File "/home/matt/.local/lib/python3.8/site-packages/amaranth/sim/_pyrtl.py", line 455, in __call__
    exec(compile(code, filename, "exec"), exec_locals)
RecursionError: maximum recursion depth exceeded during compilation

This is likely Python/platform related. As per Python documentation, the recursion limit is platform dependant. My recursion limit is set to 1000 on my platform and its works quite well.
But looking at the call stack, it doesn't look all that deep, so I wonder if there's anything else at play here.


chore: publish symbols for downstream builds

Symbol publishing is tougher than I thought. To work around the confusing documentation on it, I plan to publish the symbols as pipeline artifacts for now for downstream pipelines to consume.
Verification build: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=307024&view=results

I have another idea but will merge this PR in because it contains that idea and provides a backup option.


[bugfix] a step should not inherit from itself

Codecov Report

Merging #9 into master will not change coverage.
The diff coverage is 100.0%.

@@          Coverage Diff           @@
##           master      #9   +/-   ##
======================================
  Coverage    88.3%   88.3%
======================================
  Files          18      18
  Lines         463     463
  Branches        1       1
======================================
  Hits          409     409
  Misses         54      54


Added translation support for php files with javascript heredoc

This code checks for 'lajax.t' function within PHP  javascript heredocs. This allows for javascript translations within a php file.

Thanks for the PK but this solution is too specific

@lajax Then what would you like to see different? Because the company I work for would love to see such a feature (translating in heredocs and/or strings) implemented in the translate manager. If you point my in the right direction, I can make another pull request with a less "specific" implementation


Fix eks-kubeflow-workshop minor issues

Issue #, if available:
Use kfctl 1.0.1 to test our eks-kubeflow-workshop examples and find some minor issues.
Description of changes:
Simple fix up some minor issues.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/assign @Jeffwan

/lgtm


Create Blog “2018-03-15-some-title”

Automatically generated by Netlify CMS

Deploy preview for practical-ramanujan-39b206 ready!
Built with commit ea919e1341c94c8e0f5046e2013ee289d1b52355
https://deploy-preview-42--practical-ramanujan-39b206.netlify.com


Visualize latest move for each player

This will help players in understanding what's happening.
We need also to display : +/- resources, +7- vps

Is the current interface enough?

I would say that the current log is very good. Solved by https://github.com/donkeytech/gaia-viewer/commit/cf28f083b902c0aebb0413b929402954a58558e6


Feture load he scripts Fixes eedevops/hubot-enterprise#20

eedevops/hubot-enterprise#20

thumbs up (we should open an issue for GH to add it as a new feature)


[DRAFT] Portis wrapper

Draft PR right now until testing in other apps is complete.

Pull Request Test Coverage Report for Build 839281398

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Totals

Change from base Build 836446889:
0.0%

Covered Lines:
0

Relevant Lines:
39

💛  - Coveralls

Rebased.

Rebased version bumping

Let's add the last comment and merge the beta version into develop. After we give it a test we can bump and release major.

After talking with @miltonwg , I have updated the description in the Readme to indicate that the wrapper will add the gasPrice when sending request. However, the developer will need to add a gasPrice if they use send or sendAsync.
I also bumped the gasPrice by 1% as requested by @ilanolkies . This PR is ready to go, below is the status of the App's support of Portis. I checked the Apps below using yarn link as a few extra commits have been added.

[x] VC Issuer - Worked fine as it does not have any transactions, only signatures. Portis support is already merged into main. deployed to production here
[x] RIF Id Manager - As Ken found, the identity section does not work. After talking with Milton, it was decided to show a message letting the user know they can't update their data. A PR is ready to be merged here.
[x] RNS Manager React - Works locally, however, the published rLogin package 1.0.7-beta.1 does not support rawTransactions, so this PR will need to wait until the next version is released then updated.

update: this comment was originally posted on the RIF Identity Manager PR.

Do we add it to v1.0.8? In that case let;s merge it before #96


Some error when open the variable to explore the value

Description
What steps will reproduce the problem?

different to before interface
liike this

click  the Value

it happended

Please provide any additional information below
File "C:\Software\Anaconda3\lib\site-packages\spyder\widgets\variableexplorer\collectionseditor.py", line 513, in createEditor
readonly=readonly)
File "C:\Software\Anaconda3\lib\site-packages\spyder\widgets\variableexplorer\collectionseditor.py", line 1308, in setup
readonly=readonly, remote=remote)
File "C:\Software\Anaconda3\lib\site-packages\spyder\widgets\variableexplorer\collectionseditor.py", line 1260, in init
title)
File "C:\Software\Anaconda3\lib\site-packages\spyder\widgets\variableexplorer\collectionseditor.py", line 1145, in init
minmax=minmax)
File "C:\Software\Anaconda3\lib\site-packages\spyder\widgets\variableexplorer\collectionseditor.py", line 110, in init
self.set_data(data)
File "C:\Software\Anaconda3\lib\site-packages\spyder\widgets\variableexplorer\collectionseditor.py", line 158, in set_data
self.set_size_and_type()
File "C:\Software\Anaconda3\lib\site-packages\spyder\widgets\variableexplorer\collectionseditor.py", line 178, in set_size_and_type
for index in range(start, stop) ]
File "C:\Software\Anaconda3\lib\site-packages\spyder\widgets\variableexplorer\collectionseditor.py", line 178, in
for index in range(start, stop) ]
File "C:\Software\Anaconda3\lib\site-packages\spyder\widgets\variableexplorer\collectionseditor.py", line 78, in getitem
return getattr(self.obj, key)
File "C:\Software\Anaconda3\lib\site-packages\pandas\core\generic.py", line 206, in _constructor_sliced
raise AbstractMethodError(self)
pandas.core.common.AbstractMethodError: This method must be defined in the concrete class of Series
Version and main components

Spyder Version: 3.2.4
Python Version: 3.6.3
Qt Versions: 5.6.2, PyQt5 5.6 on Windows

Dependencies
pyflakes >=0.6.0 :  1.6.0 (OK)
pycodestyle >=2.3:  2.3.1 (OK)
pygments >=2.0   :  2.2.0 (OK)
pandas >=0.13.1  :  0.21.1 (OK)
numpy >=1.7      :  1.12.1 (OK)
sphinx >=0.6.6   :  1.6.3 (OK)
rope >=0.9.4     :  0.10.7 (OK)
jedi >=0.9.0     :  0.11.0 (OK)
nbconvert >=4.0  :  5.3.1 (OK)
sympy >=0.7.3    :  1.1.1 (OK)
cython >=0.21    :  0.27.3 (OK)
qtconsole >=4.2.0:  4.3.1 (OK)
IPython >=4.0    :  6.2.1 (OK)
pylint >=0.25    :  1.7.4 (OK)

@Zeroto521 Hey, any updates? If we aren't given the data and have no other way to reproduce this issue, it will probably have to be closed unless we hear from you or @Prikers was able to. Thanks!

Did not receive anything...

@Prikers
What I can say about to you...
No EMAIL address in you home page.
(:3」∠)

@Zeroto521 I emailed you about this topic so that you can have my contact. Anyway here is where you can contact me<EMAIL_ADDRESS>

I received the data. I tried playing around with it but did not manage to reproduce the problem. Will try tomorrow on my laptop (which has a slightly different python config).

I tried reading in the data as well and despite open and closing it a half dozen times by different methods on Spyder 3.2.6/Python 3.6.4 on Windows 8.1, I too was unable to reproduce the error.

Closing because we were unable to reproduce this.


com_google_fonts_check_037:  Running FontValidator.exe on mac

In #1336 there's a discussion on how to get FontValidator.exe to run. Unfortunately, It only focuses on Linux.
As a mac user, I haven't found a way to run FontValidator.exe without calling mono in the shell. For our subprocess command we have:
    fval_cmd = ["FontValidator.exe",
                "-file", font,
                "-all-tables",
                "-report-in-font-dir",
                "+raster-tests"]

I see Linux users can use Binfmt to run .exes without calling mono. @felipesanches have you used this approach? if so, we'll need to update out subprocess command so it is cross platform compatible.
I may be totally wrong with my assumptions here. Please correct me if I am.

Here's what I came up with for the docker environment in Fontbakery-Dashboard, because the calling without mono did not work for me either: https://github.com/googlefonts/fontbakery-dashboard/blob/master/containers/base/python/Dockerfile#L55
# in Dockerfile
RUN ...
    echo "#! /bin/bash"  > /bin/FontValidator.exe; \
    echo "mono /var/fontbakery/prebuilt/fval/FontValidator.exe \$@" >> /bin/FontValidator.exe; \
    chmod +x /bin/FontValidator.exe; \
    echo 'export LD_PRELOAD=/var/fontbakery/prebuilt/custom_freetype/lib/libfreetype.so' >> ~/.bashrc;

maybe it helps.

@graphicore thanks!
I think I'll find a cross platform solution for this and pr.
cc @felipesanches

Or just use the provided all-in-one mac and Linux binaries.
https://github.com/HinTak/Font-Validator/releases/tag/FontVal-2.1.1-py
FWIW, as long as a hostile fork exists, the source code of the backend will not be posted. So using a hostile fork is one way of making sure that you will not see the code.

"hostile" what?!

A fork that (1) does not contribute to upstream, (2) intentionally incompatible, is called a hostile fork. You are aware that your fork intentionally breaks the freetype-py client also?

If you are going to use LD_PRELOAD, you might as well use these.
https://github.com/HinTak/Font-Validator/tree/master/bin/ubuntu-14.04-x64
https://github.com/HinTak/Font-Validator/tree/master/bin/ubuntu-16.04-x64
https://github.com/HinTak/Font-Validator/tree/master/bin/Darwin
Note you may need to check out the slightly older version of the backends. The communication between the backend and front end has changed slightly lately - migrating towards thread-safeness, etc.

huh. whose fork of what?

If you just use the provided mac binary (and the Linux binary also), you don't need to worry about mono, and you do not need to fiddle with LD_PRELOAD with your own hostile fork. It is just a single binary. Nothing else.
The 5 binary freetype backends (for 7 architectures - win32/win64, intel mac 32-bit/64-bit, ppc mac 32-bit, unbuntu 14.04.x64 and 16.04.x64 - the mac is a biarch/triarch) are posted mostly just to remind myself, what exactly did I include in the all-in-one binaries. For as long as the hostile fork exists, you will not see its source.

If Felipe deletes all traces of his fork, you will publish compete corresponding sources?

Felipe started a bad trend and will only be the first of many people who tries to disrupt and destroy the work, unfortunately. There will be more such people to come.
I'd say for as long as it is mostly my work, I do not need to show the code. In the spirit of co-operation, I would say the person(s) who can see the backend code patch , which currently has a size of 100k and line count of about 3000 , is somebody who has contributed an equivalent amount of work to the rest of FontVal. There are plenty to do - the last time I counted there are about 50 open issues. And it should be quite easy if adding checks for the newer tables is considered.
People who had contributed nothing positive so far? I don't need to hear what they want. It is irrelevant.

Felipe wants to contribute. I want to direct people to contribute. But if no one can see the complete current codebase, how can they contribute to the open issues? They can't, and they won't. No one is going to contribute to an open source project where source code isn't available. Simple as that.

Felipe has not contributed anything positive so far. Still waiting. If you are not contributing positively, what you want to do is irrelevant.

I wasn't aware Felipe maintained a fork of fontval. But the tone of your previous remarks ("hostile", "bad", "disrupt and destroy", "nothing positive", "irrelevant", etc.) doesn't seem quite welcoming for new contributions.

 I call the hostile action what it is, it is hostile.
As for the earlier argument - I did not see the complete original Fontval code either. Microsoft did not release their backend code . You can tell me not to work on Fontval 3 years ago with exact same argument. Dave, you probably should have. If you apply the same argument 3 years ago, it would save us all a lot of pain.

I shall update the FAQ https://github.com/HinTak/Font-Validator/wiki/FAQ , regarding "hostile fork", and quoting Dave's coment above and my response. In particular, here are 3 reasons at least that the backend code will not be released:

the backend code will not be released as long as any hostile fork exists.

the backend code will not be released until it is tested safe to function patching against Linux's system-wide FreeType. (currently scheduled for 2019 spring/summer in the Fedora 29 time frame). It will be a private testing only, and you'll need to first convince me to risk and sacrify my own box's stability.

the backend code will not be released until FontVal is not my personal project. That, specifically means, that the sum total of community code contribution to the C# part exceeds my own. The backend code is currently just over 100k with a line count of about 3000 . So try contributing 3000 lines of C# code, before that trying to argue on that.

These are the 3 reasons at least. If I think of a 4th, etc, I'll add to the list. These conditions will not be removed.
Please also read the "negative contribution" entry in the FAQ. It was written specifically as a consequence of Felipe's behavior last summer.

closing as we've solved this.


Tiered cow subsidy

Fixes #1686
To be more flexible when offering subsidies based a user's COW balance 2 things got added:

Support different subsidy tiers based on the COW balance
Update CLI arguments to configure subsidy tiers at startup

The help for the new CLI argument looks like this:
--cow-fee-factors <COW_FEE_FACTORS>
    Used to configure how much of the regular fee a user should pay based on their COW
    balance.

    The expected format is "10.2:0.75,150:0.5" for 2 subsidy tiers. A balance of [10.2,150)
    COW will cause you to pay 75% of the regular fee and a balance of [150, inf) COW will
    cause you to pay 50% of the regular fee.

    If multiple tiers get configured for the same threshold the first will be used.

    [env: COW_FEE_FACTORS=]

Note that a SubsidyTier can only be created with a fee factor in the range of [0.0, 1.0].
Test Plan
Added unit test which verifies that the correct fee factor gets looked up based on a balance amount.

Codecov Report

Merging #1718 (085ea55) into main (cd8d2e7) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1718      +/-   ##
==========================================
- Coverage   65.81%   65.77%   -0.05%
==========================================
  Files         178      178
  Lines       36065    36089      +24
==========================================
- Hits        23737    23736       -1
- Misses      12328    12353      +25


Incorrect "No Changes" Comment in TF Plan with Imports but No Other Actions

Hello,
We've discovered an edge case worth addressing. In a TF plan with no changes—meaning no updates, deletes, or creations—but with an import, the action will incorrectly comment "no changes."
For instance:
Plan: 8 to import, 0 to add, 0 to change, 0 to destroy

Nice catch! What would your desired solution be? Have a new section for "imported resources"?


SHACL shape not recognized when not explicitly typed as a sh:NodeShape

According to the SHACL specification, asserting an explicit type for a node shape is not required:

A node shape is a shape in the shapes graph that is not the subject of a triple with sh:path as its predicate. It is recommended, but not required, for a node shape to be declared as a SHACL instance of sh:NodeShape.

(emphasis mine)
However, the SHACLSail only recognizes / applies node shapes when they are explicitly typed as such. For example,
Data:
@prefix : <http://example.org/> .
:bob a :Person ;
        :name "Bob";
        :name "Alice" .

Shape:
@prefix sh: <http://www.w3.org/ns/shacl#>.
@prefix : <http://example.org/>.

:personShape a sh:Shape;
       sh:targetClass :Person ;
       sh:property [
           sh:path :name ;
           sh:maxCount 1
       ].

This will not trigger a validation error because the person shape is not recognized. Only if we adapt the shape definition:
@prefix sh: <http://www.w3.org/ns/shacl#>.
@prefix : <http://example.org/>.

:personShape a sh:NodeShape;
      sh:targetClass :Person ;
       sh:property [
           sh:path :name ;
           sh:maxCount 1
       ].

does the validator detect the problem in the data.

I believe this is fixed in the new AST which uses RDFS and the SHACL schema.

I believe this is fixed in the new AST which uses RDFS and the SHACL schema.

Good to know! This is not urgent from my perspective, just something I ran into when doing some comparisons between different SHACL engines.

TODO: Make a test for this to show that it's fixed with the new AST.

TODO: Make a test for this to show that it's fixed with the new AST.


Access navigator data

Hi,
is it possible to access any navigator data?
"next turn" or something?
Logging detects unknown messages with type 35, 36, etc.
Maybe it is possible to send "Enable navigator events" message?
So I really need it to re-send navigator events to the car instrument cluster.

Got it working!
With album cover and song info on instrumenr panel!
Any ideas how to get navigation data?
Maybe from app on iOS?


Add link to Ruby XGBoost gem

From https://discuss.xgboost.ai/t/ruby-library-for-xgboost/1133, I learned that there is now a Ruby binding for XGBoost.
Announcement: https://ankane.org/xgboost-lightgbm-come-to-ruby
cc @ankane

Awesome, thanks @hcho3 👍


[CT-987] Relation does not exist when create new view

Describe the bug
Use drop cascade to drop my snapshot('notifications') and derived view('notifications_current') first. Then recreate the snapshot and related post view. The snapshot can be created successfully while the view can't.
Steps To Reproduce
dbt run model to drop snapshot and cascaded view
dbt snapshot to recreate it
dbt run to create view
Expected behavior
The view can be created
Screenshots and log output
01:37:49  Completed with 1 error and 0 warnings:
01:37:49
01:37:49  Database Error in model notifications_current (models/notifications_poc/notifications_current.sql)
01:37:49    relation "uat_conforming_notifications.notifications_current" does not exist
System information
dbt core 1.1.0
<output goes here>

Redshift
python 3.9.13
Additional context
Add any other context about the problem here.

Hey @NessieLi, sorry for the delay!
Would you mind sharing a bit more about how you use dbt run to drop your snapshot?
I'm trying to reproduce the issue and I'm lost on that step :)

I tried to reproduce by issuing a drop table my_schema.my_snapshot table cascade in Redshift.
Then if I do a a dbt run it fails with the error message above.
But if I start with dbt snapshot before doing dbt run, then it doesn't reproduce your issue.
If you look in Redshift, is the missing table there? If you look at the output logs of the dbt snapshot, was the table properly created?

Closing as stale, please re-open if need be.


HBASE-23813 Get surefire version from parent pom rather than define i…

…t in hbase-archetypes

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  9s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-2 Compile Tests _

+0 :ok:
mvndep
0m 14s
Maven dependency ordering for branch

+1 :green_heart:
mvninstall
5m 48s
branch-2 passed

+1 :green_heart:
compile
0m 40s
branch-2 passed

+1 :green_heart:
shadedjars
4m 42s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 28s
branch-2 passed

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 13s
Maven dependency ordering for patch

+1 :green_heart:
mvninstall
5m 29s
the patch passed

+1 :green_heart:
compile
0m 39s
the patch passed

+1 :green_heart:
javac
0m 39s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  3s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedjars
4m 43s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m 17s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 28s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
0m 45s
hbase-client-project in the patch passed.

+1 :green_heart:
unit
0m 46s
hbase-shaded-client-project in the patch passed.

+1 :green_heart:
asflicense
0m 21s
The patch does not generate ASF License warnings.

50m 46s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1145/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1145

Optional Tests
dupname asflicense javac javadoc unit shadedjars hadoopcheck xml compile

uname
Linux 0891dce3324f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1145/out/precommit/personality/provided.sh

git revision
branch-2 / 29fb52b5d2

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1145/1/testReport/

Max. process+thread count
432 (vs. ulimit of 10000)

modules
C: hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project U: hbase-archetypes

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1145/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

+1 LGTM

Signed-off-by: Nick Dimiduk<EMAIL_ADDRESS>Signed-off-by: Jan Hentschel<EMAIL_ADDRESS>Signed-off-by: Zach York<EMAIL_ADDRESS>


Memory Increment on Mass Data Logging Due to Ignition's LogRecorder when APP_DEBUG=FALSE

When logging a significant amount of data in a single request, I observed a consistent increase in memory usage. This increment persisted even after logging my message and explicitly clearing it from memory.
Upon further investigation, I found that the culprit is Spatie\LaravelIgnition\Recorders\LogRecorder. It continuously stores all logged messages within the $this->logMessages[] property, regardless of whether the Laravel application's APP_DEBUG is set to FALSE.
In a non-debug environment, one would expect that these Exception interfaces aren't thrown, and thus, Ignition should not execute. However, this behavior persists even when the application is not in debug mode. Furthermore, setting enable_runnable_solutions to FALSE did not resolve the issue.
To circumvent this behavior, which I perceive as a memory leak in production, I've adjusted my Ignition configuration as follows:
$config = [ /* ... original configuration ... */];

if (env('APP_DEBUG', false) == false) {
    $config['recorders'] = [];
    $config['argument_reducers'] = [];
    $config['solution_providers'] = [];
    $config['with_stack_frame_arguments'] = false;
    $config['enable_runnable_solutions'] = false;
}

return $config;

This temporary fix ensures efficient memory usage in production, as we don't want unnecessary memory consumption when we aren't debugging or displaying Ignition messages.
I believe it would be beneficial for the package to address this behavior, ensuring that memory isn't wastefully used in production environments.

Yes, I had the same problem,
Backend fatal error: PHP Fatal error: Allowed memory size of<PHONE_NUMBER> bytes exhausted (tried to allocate 884736 bytes) in /home/website/vendor/spatie/ignition/src/ErrorPage/ErrorPageViewModel.php on line 104\n
Please fix this.

I'm having similar issues, where I have a job that needs to insert 1M+ records and it fails due to running out of memory.

@freekmurze I have the same issue here. I'm doing bulk inserts of mass data using a generator and DB:insert(). Ignition is eating up the memory. Once I removed it from composer.json memory stayed stable. Maybe an easy solution is to be able to disable ignition at runtime... ie. Ignition:disable() so that it can be disabled for the request life-cycle, or a queued job, etc.

This also affects our Elasticsearch client library, which connects the Elasticsearch PSR logger to a Laravel channel. As Elasticsearch tends to log huge requests, this quickly fills up available memory and crashes the application.


Browser wallet option is not appearing on Firefox

With the Iron Wallet extension installed on Firefox, it should appear an option to connect with a browser wallet and nothing is showing

@DavideSilva after #600 I was able to get this working on firefox. I also updated web3-demo, so not sure if that was also related
let me know if the issue persists for you, but closing in the meantime


Run tests against SF 2.3/2.7/3.0 on PHP 5.5/7.0

See #23 for concern about symfony versions compatibility.

IMHO you should at least also test with PHP 7. PHP 5.6 may also make sense...

Symfony 2.8 and Symfony 3.1

For PHP 7 tests, maybe only test against Sf 3.x

"failed: object(Symfony\Component\Config\Definition\Exception\InvalidDefinitionException) is not an instance of \InvalidArgumentException"

👍 any thoughts @lolautruche ?

👍
However, I think you should also test against Symfony 3.1 as it's the current version now.


Instructions: parse turn:lanes to improve instructions

There is valuable instruction information stored the turn:lanes information in OSM. It would be interesting to see if we can improve the turn instruction by parsing them in a post-processing step and maybe add them as annotation or something like that?
I wouldn't go as far and propose to actually support turn lane information in the response, which might be nice in the future, but probably not now.

Hi I just added this information to graphhopper, hopping to create a pull-request.
Can anyone help me out on that? I need permissions
@karussell
@boldtrn

I figured out ;)


Fix clippy::semicolon-if-nothing-returned warnings

I ran Clippy's pedantic lints (which are disabled by default since they are typically subjective or have high false positive rates) against this repository out of curiosity, and am filing a few issues for some of the lints that warned that seemed relevant (in part to give some easy issues for people to work through to get involved with this library).
Feel free to close this out if not wanted :-)
See:
https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
warning: consider adding a `;` to the last statement for consistent formatting
  --> src/data/build_plan.rs:74:17
   |
74 | /                 build_plan.or.push(Or {
75 | |                     provides: alternative.0,
76 | |                     requires: alternative.1,
77 | |                 })
   | |__________________^
   |
   = note: requested on the command line with `-W clippy::semicolon-if-nothing-returned`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
help: add a `;` here
   |
74 |                 build_plan.or.push(Or {
75 |                     provides: alternative.0,
76 |                     requires: alternative.1,
77 |                 });
   |

warning: `libcnb` (lib) generated 1 warning
warning: consider adding a `;` to the last statement for consistent formatting
   --> src/layer_env.rs:789:13
    |
789 |             assert_eq!(expected, a.cmp(&b))
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `assert_eq!(expected, a.cmp(&b));`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned

Fixed #122.


git: create ApprovePackageRevision method, remove draft hack

Now that we can approve a package (in our tests at least), we can now fetch the package on the non-draft ref.
Also update go-git to HEAD, to pick up https://github.com/go-git/go-git/pull/325

Flake is #2713; will force retest


Python executable None not found

$ flit install --python pyhton
Python executable None not found

It seems like the error message is always going to print None:
https://github.com/takluyver/flit/blob/181416f45538bd51c121b0cd4d55efbc4bdc561e/flit/__init__.py#L21-L34
Line 29 and 30 mean that python has the value None when the error is raised, rather than the original input to the function.

Am working on a patch


[LayoutAnimation] Add support for delete

This would be incredibly useful - I imagine it was left out because it was probably more difficult to implement than the others. @nicklockwood @sahrens could you detail what issues held this up and what your strategy might be for implementing it? If it seems like something I can take care of I'd be happy to follow up on it.

Yeah, just needs a bit more juggling to keep the view alive while animating it away, or maybe delay the removal - not sure which corner cases are harder to deal with...

On May 28, 2015, at 7:49 PM, Brent Vatne<EMAIL_ADDRESS>wrote:
This would be incredibly useful - I imagine it was left out because it was probably more difficult to implement than the others. @nicklockwood @sahrens could you detail what issues held this up and what your strategy might be for implementing it? If it seems like something I can take care of I'd be happy to follow up on it.
—
Reply to this email directly or view it on GitHub.

+1

+1

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out its new home: https://productpains.com/post/react-native/layoutanimation-add-support-for-delete
ProductPains helps the community prioritize the most important issues thanks to its voting feature.
It is easy to use - just login with GitHub.
Also, if this issue is a bug, please consider sending a PR with a fix.
We're a small team and rely on the community for bug fixes of issues that don't affect fb apps.

FYI @janicduplessis is working on this for iOS here: https://github.com/facebook/react-native/pull/6779
If we get that in place, maybe Olivier will be able to add it to Android as well

Author said he was planning to add it to android himself if the iOS stuff goes well.
On Apr 13, 2016, at 6:49 AM, Brent Vatne <notifications<EMAIL_ADDRESS>wrote:
FYI @janicduplessishttps://github.com/janicduplessis is working on this for iOS here: #6779https://github.com/facebook/react-native/pull/6779
If we get that in place, maybe Olivier will be able to add it to Android as well
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHubhttps://github.com/facebook/react-native/issues/1440#issuecomment-209447676

Oh excellent @sahrens :)


feat: Accept function param when mocking requests to enable dynamic mocks

Add the ability to mock with a callback instead of static data, so that we can do useful things like mock signing a payload

Hey @texuf!
First, thanks a ton for this PR, it is very generous of you and it is a great contribution!
I was actually thinking of implementing this feature so it is perfect to see it started by someone else 😁
I have one big remark about the way to give this executeFn, so you put it as an option of the mock, which is great. In my opinion we could even put it through the data input arg of mockRequest, hence the data could either be plain data for simple mocks or could be this function that is called based on the params in order to get the final data. With this signature, the developer does not have to care if he/she needs to fill data or/and executeFn, and internally, the package does not need to make some priority rules of executeFn option over data or else
// testing-utils.ts
public mockRequest(
    method: string,
    data: unknown | ((params: unknown[]) => unknown),
    mockOptions: MockOptions = {}
  ) {
    this.mockManager.mockRequest(method, data, mockOptions);
    return this;
  }

PS: the types unknown | ((params: unknown[]) => unknown) does not really bring anything compared to unknown but it may easily indicate to the external developer that he/she can use a function if needed :). And I hope that later on, the typing of this will improve and the unknown will disappear.
If we go along like this, we need to propagate the type unknown | ((params: unknown[]) => unknown) to the needed places:

method mockRequest of MockManager,
data field of MockRequest type

Finally, we need to differentiate function or simple data before resolving the mock
// in `request` method of provider.ts
    setTimeout(async () => {
        const data = typeof mock.data === 'function'
          ? await mock.data(params)
          : mock.data;
        if (mock.shouldThrow) {
          reject(data);
        } else {
          resolve({ data, callback: mock.triggerCallback });
        }
      }, mock.timeout || 0);

What do you think about all this? :)
Thanks again for this contribution!

Also, could you please rename the title of your PR using the angular convention? 🙏
It is not only to be annoying but it also allows the automated release in CI to increase the version hehe
So basically feat: add executeFn parameter to enable dynamic mocks would be perfect in my opinion :)
And last optional point, I can do it before merging if you don't have the time :) add a quick summary in the description of the PR, as in this PR for example

On the last point - I named the commits based on the convention, if you rebase without a merge commit they should just go in like that, but I can split into 2 prs
on th

Also, could you please rename the title of your PR using the angular convention? 🙏
It is not only to be annoying but it also allows the automated release in CI to increase the version hehe
So basically feat: add executeFn parameter to enable dynamic mocks would be perfect in my opinion :)
And last optional point, I can do it before merging if you don't have the time :) add a quick summary in the description of the PR, as in this PR for example

I named the commits based on the convention, if you rebase without a merge commit they should just go in like that, but I can split into 2 prs

Hey @texuf!
First, thanks a ton for this PR, it is very generous of you and it is a great contribution!
I was actually thinking of implementing this feature so it is perfect to see it started by someone else 😁
I have one big remark about the way to give this executeFn, so you put it as an option of the mock, which is great. In my opinion we could even put it through the data input arg of mockRequest, hence the data could either be plain data for simple mocks or could be this function that is called based on the params in order to get the final data. With this signature, the developer does not have to care if he/she needs to fill data or/and executeFn, and internally, the package does not need to make some priority rules of executeFn option over data or else
// testing-utils.ts
public mockRequest(
    method: string,
    data: unknown | ((params: unknown[]) => unknown),
    mockOptions: MockOptions = {}
  ) {
    this.mockManager.mockRequest(method, data, mockOptions);
    return this;
  }

PS: the types unknown | ((params: unknown[]) => unknown) does not really bring anything compared to unknown but it may easily indicate to the external developer that he/she can use a function if needed :). And I hope that later on, the typing of this will improve and the unknown will disappear.
If we go along like this, we need to propagate the type unknown | ((params: unknown[]) => unknown) to the needed places:

method mockRequest of MockManager,
data field of MockRequest type

Finally, we need to differentiate function or simple data before resolving the mock
// in `request` method of provider.ts
    setTimeout(async () => {
        const data = typeof mock.data === 'function'
          ? await mock.data(params)
          : mock.data;
        if (mock.shouldThrow) {
          reject(data);
        } else {
          resolve({ data, callback: mock.triggerCallback });
        }
      }, mock.timeout || 0);

What do you think about all this? :)
Thanks again for this contribution!

I love this!!!! I’ll change the code.

Hey @texuf!
First, thanks a ton for this PR, it is very generous of you and it is a great contribution!
I was actually thinking of implementing this feature so it is perfect to see it started by someone else 😁
I have one big remark about the way to give this executeFn, so you put it as an option of the mock, which is great. In my opinion we could even put it through the data input arg of mockRequest, hence the data could either be plain data for simple mocks or could be this function that is called based on the params in order to get the final data. With this signature, the developer does not have to care if he/she needs to fill data or/and executeFn, and internally, the package does not need to make some priority rules of executeFn option over data or else
// testing-utils.ts
public mockRequest(
    method: string,
    data: unknown | ((params: unknown[]) => unknown),
    mockOptions: MockOptions = {}
  ) {
    this.mockManager.mockRequest(method, data, mockOptions);
    return this;
  }

PS: the types unknown | ((params: unknown[]) => unknown) does not really bring anything compared to unknown but it may easily indicate to the external developer that he/she can use a function if needed :). And I hope that later on, the typing of this will improve and the unknown will disappear.
If we go along like this, we need to propagate the type unknown | ((params: unknown[]) => unknown) to the needed places:

method mockRequest of MockManager,
data field of MockRequest type

Finally, we need to differentiate function or simple data before resolving the mock
// in `request` method of provider.ts
    setTimeout(async () => {
        const data = typeof mock.data === 'function'
          ? await mock.data(params)
          : mock.data;
        if (mock.shouldThrow) {
          reject(data);
        } else {
          resolve({ data, callback: mock.triggerCallback });
        }
      }, mock.timeout || 0);

What do you think about all this? :)
Thanks again for this contribution!

I love this!!!! I’ll change the code.

We might having problems calling an async function from inside the set timeout… but I’ll try to figure something out.

I named the commits based on the convention, if you rebase without a merge commit they should just go in like that, but I can split into 2 prs

No no please don't splits, it's perfect like that!
I like to squash and merge so the commit message that we will have in main is the title of the PR 😁

I think I updated everything. if you land my other "fix: formatting" pr I can rebase this one and get rid of the formatting commit.

Amazing work, thanks a lot!
I just have one small comment on the example comment!
I have pushed a fix on main for an issue with a pipeline, if you rebase this PR (and the other one, as you want, I don't mind having the formatting here) we can merge this one :)

Amazing work, thanks a lot!
I just have one small comment on the example comment!
I have pushed a fix on main for an issue with a pipeline, if you rebase this PR (and the other one, as you want, I don't mind having the formatting here) we can merge this one :)

Thanks for the feedback! I’m still learning typescript. I’ll make those changes and rebase.

Thanks and welcome to the contributors 🎉


working on init_self

Companion to https://github.com/pydantic/pydantic-core/pull/443
selected reviewer: @dmontagu

I think this is ready to merge, @dmontagu please review.


Added support for 3D spatial data and arbitrary number of image channels

Thanks for the keras port of the CRF-RNN module! For my needs, I required a version that works with 3D grayscale images, aka 3 spatial dimensions and 1 channel dimension. So, I made a few modifications to support that - 2 or 3 spatial dimensions, and an arbitrary number of channel dimensions.

Hello, I have also developed a N-spatial-dimensional multi-channel version.
Check it out if you like
Best Regards,
Miguel


B-19686 Tertiary destination address bugfix

Agility ticket
INT PR 1
Summary
Bugfix for tertiary pickup address boolean changing tertiary deliver address boolean
How to test

Create a move
Create a shipment with secondary and tertiary pickup and delivery address and save
Confirm the shipment has all addresses displayed
Edit the shipment to not have a tertiary pickup address and save
Confirm that clearing out the tertiary pickup address did not change the tertiary pickup address

Warnings

:warning:
This PR does not include changes to unit tests, even though it affects app code.

  Generated by :no_entry_sign: dangerJS against 869440660d4e24062c24f998b1a5f469a0ddb0b6


HTTP3 support for existing apps

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have removed any sensitive information from my code snippets and submission.

Amplify Hosting feature
Not Applicable
Is your feature request related to a problem? Please describe:
I have asked about HTTP3 support here: https://github.com/aws-amplify/amplify-hosting/issues/3767 . However, the issue is now closed and locked without anyone able to comment on it or ask questions. Please don't lock issues after posting an extremely unhelpful comment.
The comment says "All new apps have HTTP/3 enabled by default." Great. I have so many questions:

What counts as "new" - when was the feature enabled?
Do existing apps get it automatically?
Is there a way to enable this for existing apps if not?
Is there any documentation for the migration?
Any links to documentation/articles/announcements that mentions HTTP3 for amplify hosting?

Right now as a customer, I have no idea how to take advantage of this feature.
Describe how you'd like this feature to work
I would like to see some documentation on how to enable HTTP3 support in existing apps. Ideally issues should not be immediately locked in case customers wish to respond or ask questions.

HTTP3 is supported. If you aren't seeing this please open a premium support case

What counts as "new" - when was the feature enabled?
Do existing apps get it automatically?
Is there a way to enable this for existing apps if not?
Is there any documentation for the migration?
Any links to documentation/articles/announcements that mentions HTTP3 for amplify hosting?
Right now as a customer, I have no idea how to take advantage of this feature.

Hi @KholdStare - sorry for missing those. Yes, we leverage CloudFront and it enables it for all apps new and existing. It should be enabled by default for all, so there isn't a setting. In terms of documentation, we should make clear this is enabled - I will work on that.
I can triple check your app - can you share the App ID? (this is ok to share on GitHub)

Hi, thank you. The app ID is d3ejuvhpmcoxdy

Yep, HTTP3 is enabled. You can check in the network tab of an HTTP3 enabled client. but yes I can confirm for you!


Increment to golang 1.14

Codecov Report

Merging #66 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   97.81%   97.81%
=======================================
  Files           3        3
  Lines        1053     1054    +1
=======================================
+ Hits         1030     1031    +1
  Misses         16       16
  Partials        7        7

Impacted Files
Coverage Δ

hermes.go
68.65% <100.00%> (+0.47%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b496815...908d22e. Read the comment docs.


Deprecation warnings

When invoking getFunctionMock I am getting the following deprecation warnings.

MockBuilder::addMethods() is deprecated and will be removed in PHPUnit 12 without replacement.
MockBuilder::getMockForAbstractClass() is deprecated and will be removed in PHPUnit 12 without replacement.

Thanks!

Maybe lets leave it open, as it will be easier for others to spot the issue. Still if someone will provide the fix now I can accept it, but I am not going to work on it separately before we see PHPUnit 12.
Thanks


Feature/boss animations

This PR includes:

Updated all animations and added new Boss model with the textures.
Fixes Playetest Fedback 25/10/2022 (https://docs.google.com/document/d/1_ozq7MWhEIdfm2C28TCIvOB-1_yNfxUpfWCc3hzxB54/edit)

Sometimes the boss instead of walking just slides.

Fixed

Boss is still doing 2 dmg please change it