fix: FluentCheckbox not be able to render correctly with @bind- attributes when unsafe-eval is not part of the Content Security Policy

🐛 Bug Report
When "unsafe-eval" is not specified in Content Security Policy directive, the rendering of FluentCheckbox will fail in client-side interactive rendering
💻 Repro or Code Sample
Here is the part of the App.razor
<!DOCTYPE html>
<html lang="en">

<head>
    <meta charset="utf-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <base href="/" />
    <meta http-equiv="Content-Security-Policy"
          content="script-src 'self' 'wasm-unsafe-eval';">
    <link href="_content/Microsoft.FluentUI.AspNetCore.Components/css/reboot.css" rel="stylesheet" />
    <HeadOutlet />
</head>

<body>
<Routes/>
<script src="_framework/blazor.web.js"></script>
</body>

</html>

And here is one of the razor page using interactivewebassembly rendering
@page "/"
@using Microsoft.FluentUI.AspNetCore.Components
@rendermode @(new InteractiveWebAssemblyRenderMode(prerender: false))

<FluentCheckbox @bind-CheckState="@_isChecked">Will fail</FluentCheckbox>
<FluentCheckbox @bind-Value="@_isChecked">Will fail</FluentCheckbox>
<FluentCheckbox CheckedState="@_isChecked">Will not fail</FluentCheckbox>
<FluentCheckbox Value="@_isChecked">Will not fail</FluentCheckbox>

@code {
  bool _isChecked=false;
}

🤔 Expected Behavior
Fluent Checkbox should be able rendered without problem.
😯 Current Behavior
Following error message shown in the console log.

💁 Possible Solution
The workaround is to change from "wasm-unsafe-eval" to "unsafe-eval", but this violates our IT's CSP requirements.
    <meta http-equiv="Content-Security-Policy"
          content="script-src 'self' 'unsafe-eval';">

🔦 Context

🌍 Your Environment

Windows 11
Microsoft Edge Version 129.0.2792.79 (Official build) (64-bit)
.NET 8.0
Microsoft.FluentUI.AspNetCore.Components 4.10.0

Have tried this with a regular InputCheckbox component as well. Is so, does it generate the same error? If not, please do so and report back. Thanks in advance.
I have a strong feeling this is a more general Blazor issue and not a specific library issue.

@vnbaaij, I've published an example code https://github.com/aDisplayName/bugsamplecode/tree/main/20241008/FluentRender, which is based .NET 8 Blazor Web App template.
There are three Webassembly page:

/counter: Using both <FluentCheckbox/> and <InputCheckbox/>
/counter2: Using only <FluentCheckbox/>
/counter3: Using only <InputCheckbox/>

It seems using <InputCheckbox/> alone will not trigger the error.

Ok, good to have reproduction code. But am I supposed to download the whole repo with all you bug submissions :)
I can create an ew project based on the template myself and copy over the pages in question from your side but want to know which options you choose when creating the site. Going with the code I'd say 'Authentication = None' and 'Interactive render mode = None'. Correct?

I'm seeing an error in the InputCheckbox variant ( counter 2 page) as well:

So more strongly think it is a general Blazor issue now...
With just the FluentCheckbox I actually get a different error:

And with using both options, I get both errors:

I suggest you create an issue in the aspnetcore repo.

@vnbaaij  Thank you for looking into. I've submitted a bug in aspnet core.

Ok, thanks. Will keep it open here to await response from the Blazor team


Problem installing

When i try to install the plugin i get the below error. anyone an idea how to resolve? or can i do a manual install. i am running Chroot on Synology. Other plugin installations are going without issues
root@NLRDMHUB01:~/local/lib/node_modules# npm install -g --unsafe-perm homebridge-platform-ring-video-doorbell
npm ERR! Error while executing:
npm ERR! /usr/bin/git ls-remote -h -t https://github.com/homespun/hap-nodejs-community-types.git
npm ERR!
npm ERR! fatal: Cannot change to '/root/local/..': Permission denied
npm ERR!
npm ERR! exited with error code: 128
npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2018-06-07T06_48_22_866Z-debug.log
root@NLRDMHUB01:~/local/lib/node_modules#
Thanks!

I have the same problem

i solve the problem wit this commands
sudo npm i -g npm
after them
npm insall -g  homebridge-platform-ring-video-doorbell


Add in SecureHeaders, move config over to that

I rule and have completed some work on Case Manager that's ready for review!
An alternative to #1096 , adds in Twitter's SecureHeaders and moves config over to that, still a bit of investigation on hash stuff needed.
This pull request makes the following changes:

Adds in newest SecureHeaders
Configs it based on preexisting header in code

It relates to the following issue #s:

Fixes #893

Codecov Report

Merging #1102 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1102      +/-   ##
==========================================
- Coverage   96.54%   96.53%   -0.01%
==========================================
  Files          50       50
  Lines        1041     1038       -3
==========================================
- Hits         1005     1002       -3
  Misses         36       36

Impacted Files
Coverage Δ

app/controllers/application_controller.rb
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca51634...e1f8ede. Read the comment docs.

I like this a lot. After an evening of self clowning I think it might be a good idea to roll with a CSP like this and progressively work on getting inline javascript out of the app as much as possible as a longer term goal. Either way we should merge this because it's definitely a value add -- I'll poke at it tomorrow and push if it passes muster, which I bet it does because our test suite is good $$$$

I bumped the issue refs -- I think there's a little additional CSP work we want to do at this juncture: a) get any and all inline js out of the app where possible and b) follow that up by adjusting the CSP so it makes things choke rather than reportOnly, so I changed #893 to be a bump rather than a fix. 💯 💯


Empty values in context

Rule:
'a+b'
context:
{a:"", b"123"}
throws error " + 123 : operation invalid for one or more operands types".
Error can be fixed by this change to fn-generator.js:
-const presence = (...args) => args.reduce((acc, arg) => acc && (arg || arg===0), true);
+const presence = (...args) => args.reduce((acc, arg) => acc && (arg!=undefined), true);
As far as I understand, the main purpose of this function is to determine the presence of the necessary parameters. But with such implementation, only numeric values can be empty. Comparison with undefined solves the problem for other types.

This is fixed and the update will be updated in the following week.


Debug logging, Config auto-detection, overhaul documentation

This is a big request. Sorry about that; all of it came from trying to help a user diagnose his issues.
Does three main things and start thinking about a fourth:

Add debug logging.  See new README for how to enable it.  At some point, this could actually be moved to the main OAuth library.
Add ability to auto-detect the configuration based on the current URL. This way, you can just statically put all of your configs (local, stg, prod) into your app and the library will decide which one to use automatically.
Add a ton more to the README, with the intention that it can now take somebody who doesn't know anything about implicit grant all the way through the process of getting things working.

Plus, I started building some usage examples.  Gonna have to figure out what to do about keys for them, though, as I'd really not love having like 10 applications in WSO2 just for this (one per demo, local/github pages).  Might just have a single callback.html page that can look at the request and decide where it should be routed. Might even have to add a feature to the provider to store the URL we started the login process from (I had intended to do that anyway at some point; most of the hooks are there).

I'd be interested in finding this hidden page and building this into some Cypress tests - especially since we could mock the server in those.

It's not a fully-fleshed-out test suite or anything, but:
https://lockers-admin-dev.byu.edu/dev/
Code:
https://github.com/byu-oit/lockers-admin-ui/blob/master/pages/dev.vue


help with caffeine on 3.0.0 error 2207-0248

after two years that I launched caffeine from 3.0.0 with pegascape, today it doesn't work anymore I made many attempts, the exploit starts but when I press on the empty box to wait 3 seconds, an error 2207-0248 instantly occurs and I am forced to reboot the switch. I checked dns and updated all the files on the SD I have the latest version of hekate and atmosphere, until a few days ago I had no problems, can you help me?

Hi,can you help me?


ssh  connect to host xx port 3022: Operation timed out

Gitea version (or commit ref): 1.12.6
Git version: <IP_ADDRESS>
Operating system:
from docker.
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[ x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)

[x ] No
ssh  connect to host xx port 3022: Operation timed out.  Custom ports never work~
Please help me.
Thank you!

Can you use netstat to ensure that something is listening on 3022, or could be that the firewall is blocking the request.


Text On Layer

hi... me again 😄
I want to ask you about how can I add  text inside the lines with the distance between the start poing and the end point?
Can you help me?
Thanks

Is like this?
Marcelo Perretta<EMAIL_ADDRESS>周三上午12:16写道：

hi... me again 😄
I want to ask you about how can I add text inside the lines with the
distance between the start poing and the end point?
Can you help me?
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lll1024/JVDrawingBoard/issues/3, or mute the thread
https://github.com/notifications/unsubscribe-auth/APEgNLZveEYHUnjnNSTuMkOkroEL5Kssks5sol31gaJpZM4PsYyC
.

sorry I am finding job so a little busy
I send you a video but it seem fail so I change it with picture
下面的代码也许有用（Chinese😀😀）:

(void)drawWord:(NSString *)rulerLength{
NSDictionary *attribute = @{NSFontAttributeName: [UIFont
systemFontOfSize:14]};
CGRect rect = [rulerLength boundingRectWithSize:CGSizeMake(MAXFLOAT,
MAXFLOAT)
                                   options:

NSStringDrawingUsesLineFragmentOrigin
                                  attributes:attribute

                                     context:nil];

//ensure the word drawing of start point

CGFloat wordOffsetAngle = [self angleMiddleWithFirstPoint:self.

firstPoint andSecondPoint:self.lastPoint];
CGPoint pointMiddle = [self middlePoint:self.firstPoint and:self.

lastPoint];
CGFloat angle = [self angleWordWithFirstPoint:self.firstPoint

andSecondPoint:self.lastPoint];
CGPoint wordPoint;

CGFloat dx = self.lastPoint.x - self.firstPoint.x;

if (dx > 0) {

    pointMiddle = CGPointMake(pointMiddle.x+5*sin(angle), pointMiddle.y+

5*cos(angle));
    wordPoint =

CGPointMake(pointMiddle.x-(rect.size.width/2)*cos(wordOffsetAngle),
pointMiddle.y-(rect.size.width/2)*sin(wordOffsetAngle));
} else {

    pointMiddle = CGPointMake(pointMiddle.x-5*sin(angle), pointMiddle.y-

5*cos(angle));
    wordPoint =

CGPointMake(pointMiddle.x+(rect.size.width/2)*cos(wordOffsetAngle),
pointMiddle.y+(rect.size.width/2)*sin(wordOffsetAngle));
}

CGFloat wordAngle = [self angleWordDirectionWithFirstPoint:self.

firstPoint andSecondPoint:self.lastPoint];
CGContextRef context = UIGraphicsGetCurrentContext();

CGContextSelectFont(context, "Helvetica", 14, kCGEncodingMacRoman);

CGContextSetFillColorWithColor(context, [UIColor greenColor].CGColor);

if (self.color) {

    CGContextSetFillColorWithColor(context, self.color.CGColor);

}

CGContextSetTextDrawingMode(context, kCGTextFill);

CGContextSetTextMatrix(context, CGAffineTransformRotate(

CGAffineTransformMake(1, 0, 0, -1, 0, 0), wordAngle));
CGContextShowTextAtPoint(context, wordPoint.x, wordPoint.y,

[rulerLength UTF8String], rulerLength.length);
}
2017-10-13 18:58 GMT+08:00 Jarvi Liu<EMAIL_ADDRESS>
Is like this?
Marcelo Perretta<EMAIL_ADDRESS>周三上午12:16写道：

hi... me again 😄
I want to ask you about how can I add text inside the lines with the
distance between the start poing and the end point?
Can you help me?
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lll1024/JVDrawingBoard/issues/3, or mute the thread
https://github.com/notifications/unsubscribe-auth/APEgNLZveEYHUnjnNSTuMkOkroEL5Kssks5sol31gaJpZM4PsYyC
.

@lll1024
where did you add this code?
how can I call the method to send the string?

when I draw the lines I can add text by these code
otherwise the code is only  for reference
it can't be used without any changes because our project is different

Can u please put swift version for this code.?


Anyway to do finetuning jobs with custom processing  scripts?

Problem
I have a model finetuning job that takes around 80 minutes. There are two steps one is preprocessing and other is training.
Both preprocessing and training takes GPU models. But preprocessing has multiple steps and multiple models to be loaded on a step by step. Same with training too. I've put all this code inside predict function and left the model load empty.
Problems seen

I personally don't think what i'm doing is not ideal for truss as the model load is needed for you to optimise the GPU utlization.
How should an ideal solution for this to be? I've been checking chains but it looks too much of a work on top of what ive done with truss for so long.
I deployed it this way but the API hit takes 80 minutes to execute but pod delete max time limit is 1 hour. For some reason though the call is sync API call, and training is happening on the pod, it doesn't realise and brings down the pod without API returning any result.

Reasons I can't use model load,

My preprocessing step takes user input, so it can only be passed during predict step. Not sure if I can take inputs at predict, load a model based on that and then use model.load when ever my preprocessing is happening and again change the weight files in model load and do the training

Describe the solution you'd like

For now if I were to go with current approach. I see a hacky way, increase the pod inactivity time for 2 hours for my finetuning task to work
Make sure if one API is still in progress, don't bring the pod down.
Ideally a feasible way for me to use Truss correctly as it's intended. May be using Model load.

Describe alternatives you've considered
As of now, I don't find a solution than custom host and setup on AWS. I'm not able to find enough documentation on finetuning tasks. And dynamic weight file loading based on API inputs

Hi @gnerativ . We're currently working on more dedicated fine-tuning support. If you're up for it, would love to chat in more detail about your usecase and needs. Please book 30 minutes whenever it's convenient for you: https://meetings.hubspot.com/bola-malek?uuid=a8f3caa3-c771-4d16-9421-81927137fda5

Hi @bolasim sure. Possible for more added slots :(. I work from IST and haven't found any matching slots with intersection here.


Update Journal event deletion behavior

This is a discussion thread over how journal event deletion should behave in Linq2Db.
In the current code as of November 2022, Linq2Db is still supporting event journal logical delete operation and offers queries over deleted events.
Logical deletion support has been removed from our other SQL plugins and have been removed from the latest JVM codes, I strongly believe that we should also do the same with Linq2B as it will make the plugin settings less confusing for users.

IIRC when I originally ported things over, persistence-jdbc still had logical deletes as an option but marked 'will be removed in next major release'
So, if we want to get rid of it that makes sense, as long as there's no demand for it.
Do note that (at least last I checked) the IsDeleted column is still utilized for 'hard' deletes in native jvm; that's how they get around the need for a JournalMetadata table (just keep the last column in DB with IsDeleted=1)
The only 'devils advocate' though I have in favor of keeping soft deletes, is that it can be used as a form of runtime optimization (where a background job cleans up the unneeded soft delete records rather than having them cleared in the plugin) but that feels a bit extreme even for my taste.

That is correct, the deleted column will still be there, the only difference will be the removal of the logical-delete option in the HOCON config. By doing this, we can make journal query a lot simpler without having to include include-deleted flag. All of journal queries can be turned into compiled queries that should improve read speed/throughput even more.


Autocomplete broken for 'du' command

How do we modify the autocomplete files? The one for the "du" command is quite broken. It only wants to autocomplete the options, never files or folder names.

It seems to be working fine for me?
Previously, I did notice issues, but not anymore.
If you type - it should give you options for arguments. If you leave out the - it gives you options for files and folders.
This must have been fixed recently.
What are your specs? Can you verify this is still an issue?

Please post the output of the following:
which -a du
which _du # after triggering du completion
zsh --version

I am having same trouble

@xlbruce please follow the above instructions.


the code not complete when call connect()

fingerprintMachine = ZKTeco('<IP_ADDRESS>', port: 4370); await fingerprintMachine.initSocket(); bool isConnected = await fingerprintMachine.connect();
// not completed and without any errors
if (isConnected) {
print('Connection established!');
} else {
print('Connection failed!');
}

i solved my problem


Use case: LTN and 15m tools

I want to make use of census area polygons with some basic data in some parts of A/B Street. In both the LTN and 15m tools, getting a rough count of people in an area would be useful.
What attributes are useful?

number of people
vehicle ownership
is breakdown by age, working status, ethnicity, income bracket, anything else useful? Not really... maybe index of multiple deprivation?

I want to bundle this data in the map_model::Map directly, I think. Loading separate files or generating on-the-fly would be slow and complex. And at first glance, the data is tiny. A gzipped geojson with the OA-level geometry and string OA11CD ID (which is maybe not even so necessary) is 50K for Leeds, 150KB for Central London.
So the usage pattern is from the importer. The UK-wide topojson uncompressed in 80MB, and reading + filtering to get this output is under 5s. So this is actually quite easy perf-wise.

https://github.com/a-b-street/abstreet/pull/1074 gets this started end-to-end


Time in EN format in FR screen

Description
Time formatting for responses in French
2:56 pm in English --> 14 h 56 in French
Steps to reproduce

Go to "Réponses" (responses in FR)
Click on "Signaler un problème avec les réponses"
Report a submission ID
Go to "Afficher les réponses signalées"
See how the time is in English format on French interface
This is also the case across the "New" / "Downloaded" / "Signed off" tabs

Details

Browser: Edge
Operating system: Windows
Environment: App router PR
Language: French
Viewport: Tablet

Expected behaviour
2:56 pm in English --> 14 h 56 in French
Screenshots or videos

Fixed: https://github.com/cds-snc/platform-forms-client/pull/2583/commits/f8fcddf3dc468c982466d65c56cdfd7a94b1ba7c

Fixed! Thank you!


chore: append booking id when creating a booking service request

Review Checklist

Summary*

[ ] fix: Bug fix for Add the items tackled here as checklists
[x] feat: Completed task
[ ] chore: Incomplete task

[ ] test: Sub-task 1

Structure*

[ ] The Pull Request has a proper title that conforms to our MR title standards
[ ] The Pull Request has one commit, and if there are more than one, they should be squashed
[ ] The commit should have a proper title and a short description
[ ] The commit must be signed off
[ ] Unused imports are not present
[ ] Dead code is not present
[ ] Ensure dry running library to confirm changes

Tests

[ ] Proper and high quality unit, integration and acceptance(if applicable) tests have been written
[ ] The coverage threshold should not be lowered

Sign off*

[ ] All comments have been resolved by the reviewers
[ ] Approved by Czar {replace_with_czar_name}
[ ] Signed off by second reviewer {replace_with_name}
[ ] Ensure all checks are done before merging :warning:
[ ] All PRs needs to be signed before merging :warning:

N/B:

Add a checklist if more than one item is done.
Add screenshots and/or images where necessary
Indicate any breakages caused in the UI :exclamation:
Where necessary, indicate which issue the Pull Request solves (Closes #)
Any new files are updated in the folder structure in the README

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 83.256%

Totals

Change from base Build<PHONE_NUMBER>:
0.001%

Covered Lines:
17567

Relevant Lines:
21100

💛  - Coveralls


IOS auto scrolling issue with sliver app bar

Steps to reproduce

In the home screen you can see horizontal listview with week 0, week 1, week 2.
Click on any of the week little bit beside of that week or anywhere near to that week.
you will see that it is scrolling automatically.
this behaviour is only in IOS. - debug mode or release mode. (In android it is working fine.)

https://github.com/flutter/flutter/assets/131435534/1513c2e6-a4b9-4912-97b3-e90da8b6b5dd
Expected results
It should not scroll automatically becuase there is no any scrollcontroller used. why is it scrolling automatically by clicking on listview in IOS
Actual results
I have added sliver app bar and below that sliver appbar there is tabbar view .
In second tab bar view i am having two listview.builder. one is horizontal and scond is vertical. when i am trying to click on horizontal listview.builder's any item. it is scrolling the whole screen automatically in IOS (Simulator and real device both).
Code sample
Code sample
https://github.com/Aadesh1803/ios-demo

Screenshots or Video

Screenshots / Video demonstration
[
https://github.com/flutter/flutter/assets/131435534/43ed6619-538d-4beb-be0a-216839b77095
]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output

[✓] Flutter (Channel stable, 3.13.6, on macOS 13.0 22A380 darwin-x64, locale en-IN)
    • Flutter version 3.13.6 on channel stable at /Users/imac/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision ead455963c (5 months ago), 2023-09-26 18:28:17 -0700
    • Engine revision a794cf2681
    • Dart version 3.1.3
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/imac/Library/Android/sdk
    • Platform android-34, build-tools 33.0.1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.13+0-b1751.21-8125866)

[✓] VS Code (version 1.80.2)
    • VS Code at /Users/imac/Downloads/Visual Studio Code.app/Contents
    • Flutter extension version 3.84.0

[✓] Connected device (3 available)
    • sdk gphone x86 (mobile) • emulator-5554 • android-x86    • Android 11 (API 30) (emulator)
    • macOS (desktop)         • macos         • darwin-x64     • macOS 13.0 22A380 darwin-x64
    • Chrome (web)            • chrome        • web-javascript • Google Chrome 122.0.6261.112

[✓] Network resources
    • All expected network resources are available.

• No issues found!

@Aadesh1803
Please don't file multiple issues for same reason. You already filed this here https://github.com/flutter/flutter/issues/144672 for which we provided feedback on it.
Closing this issue.

@darshankawar , I have tested with flutter's latest stable version itself but it is not working. waiting for your positive reply.

Can someone help me out. i am facing this issue in IOS.


[GLUTEN-1632][CH]Daily Update Clickhouse Version (20230612)

Auto commit by gluten daily build, please check the build status and merge it if it's green.

Compatible with current gluten


[ISSUE #6761] Support reentrant notification orderly for broker

Which Issue(s) This PR Fixes

Fixes #6761
Brief Description

How Did You Test This Change?

Codecov Report

Merging #6762 (58f57d3) into develop (5dc2e20) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #6762      +/-   ##
=============================================
- Coverage      42.89%   42.84%   -0.05%
+ Complexity      9009     8981      -28
=============================================
  Files           1113     1108       -5
  Lines          78603    78439     -164
  Branches       10226    10210      -16
=============================================
- Hits           33713    33610     -103
+ Misses         40670    40616      -54
+ Partials        4220     4213       -7

Impacted Files
Coverage Δ

...cketmq/broker/processor/NotificationProcessor.java
7.07% <0.00%> (-0.08%)
:arrow_down:

...ing/protocol/header/NotificationRequestHeader.java
0.00% <0.00%> (ø)

.../apache/rocketmq/test/client/rmq/RMQPopClient.java
0.00% <0.00%> (ø)

... and 42 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


feat: Dont double check num bits in brillig vm

We already have typed memory, that is checked on data ingestion and outputs of operations. It shouldn't be necessary to perform safe type conversions for MemoryValues

Benchmark results
Metrics with a significant change:

circuit_simulation_time_in_ms (private-kernel-inner): 226 (-23%)
tx_sequencer_processing_time_ms (1): 582 (-17%)
tx_sequencer_processing_time_ms (2): 436 (-17%)
tx_sequencer_processing_time_ms (3): 1,159 (-20%)
tx_sequencer_processing_time_ms (4): 484 (-17%)
tx_sequencer_processing_time_ms (5): 2,011 (-20%)
l2_block_public_tx_process_time_in_ms (8): 4,756 (-17%)
l2_block_public_tx_process_time_in_ms (32): 18,705 (-18%)
l2_block_public_tx_process_time_in_ms (64): 38,024 (-17%)
note_trial_decrypting_time_in_ms (32): 121 (+108%)

Detailed results
All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call  to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.
This benchmark source data is available in JSON format on S3 here.
Values are compared against data from master at commit 54aee589 and shown if the difference exceeds 1%.
L2 block published to L1
Each column represents the number of txs on an L2 block published to L1.

Metric
8 txs
32 txs
64 txs

l1_rollup_calldata_size_in_bytes
676
676
676

l1_rollup_calldata_gas
6,412
6,424
6,412

l1_rollup_execution_gas
585,745
585,757
585,745

l2_block_processing_time_in_ms
1,296 (-1%)
4,772 (-1%)
9,364 (+1%)

note_successful_decrypting_time_in_ms
153 (-5%)
503 (-6%)
939 (-3%)

note_trial_decrypting_time_in_ms
62.0 (-8%)
:warning: 121 (+108%)
69.1 (-28%)

l2_block_building_time_in_ms
12,250 (-10%)
44,662 (-12%)
89,388 (-11%)

l2_block_rollup_simulation_time_in_ms
7,473 (-5%)
25,907 (-7%)
51,268 (-6%)

l2_block_public_tx_process_time_in_ms
:warning: 4,756 (-17%)
:warning: 18,705 (-18%)
:warning: 38,024 (-17%)

L2 chain processing
Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric
5 blocks
10 blocks

node_history_sync_time_in_ms
13,847 (-3%)
26,986 (+1%)

note_history_successful_decrypting_time_in_ms
1,244 (-9%)
2,449 (-1%)

note_history_trial_decrypting_time_in_ms
110 (+1%)
143 (-9%)

node_database_size_in_bytes
18,669,648
35,057,744

pxe_database_size_in_bytes
29,859
59,414

Circuits stats
Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit
circuit_simulation_time_in_ms
circuit_input_size_in_bytes
circuit_output_size_in_bytes

private-kernel-init
181 (-20%)
44,379
28,214

private-kernel-ordering
170 (-15%)
52,880
14,296

base-parity
3,605 (+1%)
128
311

root-parity
1,262 (+7%)
1,244
311

base-rollup
14,928 (-9%)
165,760
861

root-rollup
48.8 (-1%)
4,359
725

private-kernel-inner
:warning: 226 (-23%)
73,795
28,214

public-kernel-app-logic
95.8 (-21%)
35,252
28,217

public-kernel-tail
138 (-16%)
40,928
28,217

merge-rollup
8.58 (+3%)
2,568
861

public-kernel-teardown
92.1 (-23%)
35,252
28,217

public-kernel-setup
90.5 (-23%)
35,252
28,217

Tree insertion stats
The duration to insert a fixed batch of leaves into each tree type.

Metric
1 leaves
16 leaves
64 leaves
128 leaves
512 leaves
1024 leaves
2048 leaves
4096 leaves
32 leaves

batch_insert_into_append_only_tree_16_depth_ms
9.95 (-1%)
15.9 (-1%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_count
16.8
31.6
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_16_depth_hash_ms
0.579 (-1%)
0.490 (-1%)
N/A
N/A
N/A
N/A
N/A
N/A
N/A

batch_insert_into_append_only_tree_32_depth_ms
N/A
N/A
46.3 (-2%)
72.9 (+1%)
231
437 (-2%)
872 (-1%)
1,734
N/A

batch_insert_into_append_only_tree_32_depth_hash_count
N/A
N/A
96.0
159
543
1,055
2,079
4,127
N/A

batch_insert_into_append_only_tree_32_depth_hash_ms
N/A
N/A
0.475 (-2%)
0.449 (+1%)
0.421
0.407 (-2%)
0.414
0.415
N/A

batch_insert_into_indexed_tree_20_depth_ms
N/A
N/A
55.0 (-1%)
106 (-2%)
341
647 (-3%)
1,310 (-1%)
2,617
N/A

batch_insert_into_indexed_tree_20_depth_hash_count
N/A
N/A
105
207
691
1,363
2,707
5,395
N/A

batch_insert_into_indexed_tree_20_depth_hash_ms
N/A
N/A
0.486 (-1%)
0.479 (-1%)
0.463
0.444 (-3%)
0.453
0.454 (-1%)
N/A

batch_insert_into_indexed_tree_40_depth_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
60.5 (-2%)

batch_insert_into_indexed_tree_40_depth_hash_count
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
109

batch_insert_into_indexed_tree_40_depth_hash_ms
N/A
N/A
N/A
N/A
N/A
N/A
N/A
N/A
0.528 (-1%)

Miscellaneous
Transaction sizes based on how many contract classes are registered in the tx.

Metric
0 registered classes
1 registered classes

tx_size_in_bytes
14,968
495,320

Transaction size based on fee payment method

Metric
none fee payment method
native fee payment method
fpc_public fee payment method
fpc_private fee payment method

tx_with_fee_size_in_bytes
773
905
1,161
1,377

Transaction processing duration by data writes.

Metric
0 new note hashes
1 new note hashes
2 new note hashes

tx_pxe_processing_time_ms
1,787 (-14%)
1,195 (-13%)
4,472 (-6%)

Metric
0 public data writes
1 public data writes
2 public data writes
3 public data writes
4 public data writes
5 public data writes
8 public data writes

tx_sequencer_processing_time_ms
9.51 (-6%)
:warning: 582 (-17%)
:warning: 436 (-17%)
:warning: 1,159 (-20%)
:warning: 484 (-17%)
:warning: 2,011 (-20%)
672

The error in noir-packages-tests seems to be unrelated
  1 failing
#24 426.6 [@noir-lang/noir_wasm]:
#24 426.6 [@noir-lang/noir_wasm]:   1) GithubDependencyResolver
#24 426.6 [@noir-lang/noir_wasm]:        resolves Github dependency:
#24 426.6 [@noir-lang/noir_wasm]:      Error: Failed to fetch https://github.com/example/repo/archive/v1.0.0.zip: Not Found
#24 426.6 [@noir-lang/noir_wasm]:       at GithubDependencyResolver.#fetchZipFromGithub (src/noir/dependencies/github-dependency-resolver.ts:64:13)
#24 426.6 [@noir-lang/noir_wasm]:       at processTicksAndRejections (node:internal/process/task_queues:95:5)
#24 426.6 [@noir-lang/noir_wasm]:       at async GithubDependencyResolver.resolveDependency (src/noir/dependencies/github-dependency-resolver.ts:37:25)
#24 426.6 [@noir-lang/noir_wasm]:       at async Context.<anonymous> (test/dependencies/github-dependency-resolver.test.ts:80:17)


Show duration for each ginkgo test

Signed-off-by: baude<EMAIL_ADDRESS>

please merge

@rh-atomic-bot r+


Can't read Word2Vec file from S3

Hi,
I am trying to load a Word2Vec file from S3 into a Flask app. (Python 2.7)
The Word2Vec binary file was created via Gensim 3.4.0 using
model.wv.save_word2vec_format('model_b.bin', binary=True)
When pulling in from S3 I get the following error:
  File "api/app.py", line 54, in load_model     model = KeyedVectors.load_word2vec_format(model_str, binary=True, unicode_errors='ignore')   File "/Users/rhsmith/serverless-machine-learning/serverless/lib/python2.7/site-packages/gensim/models/keyedvectors.py", line 1119, in load_word2vec_format     limit=limit, datatype=datatype)   File "/Users/rhsmith/serverless-machine-learning/serverless/lib/python2.7/site-packages/gensim/models/utils_any2vec.py", line 173, in _load_word2vec_format     with utils.smart_open(fname) as fin:   File "/Users/rhsmith/serverless-machine-learning/serverless/lib/python2.7/site-packages/smart_open/smart_open_lib.py", line 176, in smart_open     return file_smart_open(parsed_uri.uri_path, mode, encoding=encoding, errors=errors)   File "/Users/rhsmith/serverless-machine-learning/serverless/lib/python2.7/site-packages/smart_open/smart_open_lib.py", line 671, in file_smart_open     raw_fobj = open(fname, raw_mode) IOError: [Errno 2] No such file or directory: '46659 100\n,|PUNCT %\xbc\x82'
The code is below and uses Gensim 3.4.0:
`def load_model(key):
response = S3.get_object(Bucket=BUCKET_NAME, Key=key)
model_str = response['Body'].read()
model = KeyedVectors.load_word2vec_format(model_str, binary=True)
return model`

Hi, you want to use load_word2vec_format() directly using the S3 path (not on some model_str object). See the examples on the smart_open home page for how to specify S3 paths (the s3:// prefix).


add support for touch events

Let me know if there is anything missing or if something should be done differently :)

Looks good, thanks!
Please add a third link to https://developer.mozilla.org/en-US/docs/Web/API/Touch_events#browser_compatibility to the doc urls, and also run the tests and commit the resulting generated code.

Done :)

Cool, thank you, I'll merge before I cut the next version.


Seed submission problems

1/3/15
There are two problems regarding seed submissions: conventional seed submission through the contribute page and submission through bookmarklet.
The submissions do not appear on the admin dash page.
The bookmarklet submission results say, "There was a problem adding this item!"

1/4/15
Submitted seeds are now appearing on the admin dashboard.  However, seeds which published on  1/4/15 are not appearing in on the JDA search.

Hi Koko,
The error message result may have been a very temporary and poorly-scheduled fault on my part from when I was re-importing the Yahoo data. In order to get the Yahoo data to go back into the 1-20,000 ID slots in the database, I had to turn off the automatic "ID-assigning" that normally happens when you submit an item, where it just adds it onto the end of the database. So for a brief period of time, that system wasn't in place, meaning any item that was submitted without an explicit "ID" field would have been rejected, which probably resulted in that error. I changed the files back after the Yahoo import was done, but there were a few hours where submissions wouldn't have worked. I'm so sorry about that - I should have warned you but it completely slipped my mind. Can you test and let me know if bookmarklet submission is working for you now?
As for the seeds, I believe that should be fixed along with the other seed-related issues that were just sorted with the re-index. However, items that you tried to submit that resulted in the error message will have to be resubmitted, unfortunately. Again, I'm really sorry!

Dear Corinne,
Bookmarklet and the submission page are working now. Thank you very much for fixing.


Better errorr handling throughout the repository

The error handling isn't very consistent and should be improved

There is now a notification system using an ejs include. Sending a message with res.render now will display it(and use false if there isn't. )
Usingtype: 'error' displays a warning(red border) and using type: warning displays a warning(yellow border)


Multiple currencies in multiple items

At the moment, GOBL allows to specify the currency at item level, if the currency is different than the invoice's one. However, at the time of calculating totals, different lines with different currencies are summed together as if they had the same currency.
We need to review this behaviour as probably the exchange rates information (if present) should be used to calculate totals in the invoice's currency properly (or a validation error be returned if the exchange rates required to calculate the totals are missing)

This one is solved now 👍


[Request] Support for erome.com

Since eroshare is gone, I would love to see support for erome.com.

Can you post a video link?

Included in #29

https://www.erome.com/a/ixVfLNtQ

Direct links (might be helpful to support in case of reddit users linking directly):

I say put the direct links in their own ripper (erome seems to link to the actual file and not a web page)

https://s2.erome.com/1/5S5SFldM/mPJG0oPA.mp4 -- video link

For whatever reason that url is returning 405 not allowed

https://s2.erome.com/1/5S5SFldM/mPJG0oPA.mp4 -- video link

For whatever reason that url is returning 405 not allowed

Same for me and I've never been on erome or eroshare -and- the erome links open in browser just fine except for that one, so if it's an IP range ban it's an exaggerated one, but I'm confident there's no ban in effect. If erome has any private/public systems for uploads, that's the viable reason for the 405 NOT ALLOWED, otherwise it's a dead link.


Make missing charts error message more helpful

This path was short-circuiting the error message for missing compiled-in charts. The message now reads as it should:
$ ic manifest generate
Error: compiled in charts not found in this development build, use --charts with local charts instead or run make gen
exit status 1

$ ic manifest generate --charts ./manifests
<correct output>

@ostromart: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
790e80e03f44816e85c9a4f37a16b7330a5c20a1
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ostromart: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

gencheck_istio
790e80e03f44816e85c9a4f37a16b7330a5c20a1
link
/test gencheck_istio

unit-tests_istio
790e80e03f44816e85c9a4f37a16b7330a5c20a1
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


[Rest Server] Add annotations in framework config

Add annotations for userName, virtualCluster, config in framework.

Coverage decreased (-7.7%) to 46.049% when pulling fa05523c5825e39cbd8811b6f5fe5a77b8fe6c7b on xiongyf/rest-server-add-annotations into e0c782efad03e6daf449b2f9b5b6040b6f32b994 on feature/pure-k8s.


Mazumder - Biosample meta Organism names

some Organism names appear like this: Coprococcus eutactus ATCC 27759, where 'ATCC 27759' might affect filtering
Originally posted by @steph-sing in https://github.com/FDA-ARGOS/data.argosdb/pull/230#pullrequestreview-1316256487

@kerchner This was another one of my review comments that was broken out into a ticket, with the intention of revisiting. I do not think this is a priority or in need of action at the moment. I think this type of discussion fits into the greater context of data standardization - as in, what should we standardize, and at what level. For me, I would consider this more data cleaning and ideally this is something our group can make time for, and I believe its important - but again - as far as priority and depth, I need clarification from the PIs.

@kerchner per the PI's comments, we won't be altering the data in anyway at this time. I will close this ticket and others in the same category. Thanks


CredentialsError

I am getting an error while uploading the image "Missing credentials in config"

be sure you have file named .bluemix/cos_credentials in the root of your user directory that contains the information you copied from the cloud console

this error indicates a missing or ill formed cos_credentials file.  @MoturiPavani3991 please reopen this issue if you are still having problems...


Restricted featuregate reader

Update library-go to get a more restrictive featuregate reader to avoid naughty usage.

/retest

/retest

/lgtm

external ccm bug

/retest

/retest

/hold
in case https://github.com/openshift/cluster-kube-apiserver-operator/pull/1488 tests good first.


lib/posix/fs: fix end-of-dir in readdir

POSIX readdir should return NULL if end of dir is reached and
leave errno untouched.
Signed-off-by: Rico Ganahl<EMAIL_ADDRESS>

@pfalcon @nashif Have I misunderstood something about end-of-dir?

@galak Just wanted to bump the PR.

Please check my changes, some external libs crash which check for end of dir in POSIX manner.

@dariis - LGTM, but could you also please provide an accompanying test in tests/posix/fs/src/test_fs_dir.c?

@cfriedt Just give me some time, I will have a look.

@dariis, I'm going to create a bug report for you, since I would also like this fix to be included in v2.7 LTS and a bug report is required for the backport. It's a relatively trivial fix, so I don't foresee any difficulty.


Feed does not work on Podcasts for iOS

Please look at this feed:
https://s3-us-west-2.amazonaws.com/hammadypublic/majalis-baqara/main.rss
Although all links are valid and can be played from the browser, but the stock Podcasts app in iOS 10 shows no episodes.

I am getting this error:
<Error>
AccessDenied
<Message>Access Denied</Message>
<RequestId>7999C22243D3BE0D</RequestId>
<HostId>
+lQt2gTRQR456BC+8IKURej0zjd7Qd8w6l2DpP0kofBVTSR2rtxFm+nVS5CF1z64qN/VeLrytBU=
</HostId>
</Error>

Has the link expired? Maybe you can refresh it or attach the source to this issue?

The correct link is:
https://s3-us-west-2.amazonaws.com/hammadypublic/majalis-baqara/index.rss
It was fixed already by #16.

Nice. Thanks for the follow-up!


electrons heating: 1d (noh) shock test

Merging this as-is.  Did some touching up & added an automated test, which I'll push straight to dev


Deprecating legacy Fabric CSS consumption

Category

[x] Question
[ ] Typo
[x] Bug
[ ] Additional article idea

Does this mean that ms-Grid (Fabric layout https://developer.microsoft.com/en-us/fabric#/styles/layout) will stop to work? What other functionality will stop to work?
In my case Fabric grid stop to work after upgrading

I fairly certain the grid is not affected, but you can test a solution that that uses SPFx v1.8 and the ms-Grid class. If it still works, you're good.
Everything in the @microsoft/sp-office-ui-fabric-core is still good... they just removed stuff they were adding to the rendered pages automatically and thus reduced the page weight.

ms-Grid classes are not working for me on neither 1.8.0 nor 1.8.1.
my package.json file
{
"name": "sample",
"version": "0.0.1",
"private": true,
"engines": {
"node": ">=0.10.0"
},
"scripts": {
"build": "gulp bundle",
"clean": "gulp clean",
"test": "gulp test"
},
"dependencies": {
"@microsoft/sp-core-library": "1.8.1",
"@microsoft/sp-property-pane": "1.8.1",
"@microsoft/sp-webpart-base": "1.8.1",
"@microsoft/sp-lodash-subset": "1.8.1",
"@microsoft/sp-office-ui-fabric-core": "1.8.1",
"@types/webpack-env": "1.13.1",
"@types/es6-promise": "0.0.33"
},
"devDependencies": {
<EMAIL_ADDRESS>"0.4.0",
<EMAIL_ADDRESS>"0.1.6",
"@microsoft/sp-build-web": "1.8.1",
"@microsoft/sp-module-interfaces": "1.8.1",
"@microsoft/sp-tslint-rules": "1.8.1",
"@microsoft/sp-webpart-workbench": "1.8.1",
"@types/chai": "3.4.34",
"@types/mocha": "2.2.38",
"ajv": "~5.2.2",
"gulp": "~3.9.1",
"typescript": "3.3.4000"
}
}
Please suggest


Issue with Airgap install on AWS

Thanks for providing terraform scripts for configuring openshift in Airgap mode.
I'm trying to deploy airgap installation on AWS, installation went fine without any issues.
Here are my configuration details
Terraform version	0.12.10
Openshift version	4.3.12
Using AWS Ohio datacenter
I'm able to login to bootstrap machine and after exporting kubeconfig, I'm able to run oc commands.
I didn't see any issues in bootstrap machine when I execute  journalctl -b -f -u bootkube.service
At the end it shows       "bootkube.service complete"
I'm having issue with       'oc get clusteroperators'
It's not completed and even after 1 or 2 hours it shows below output.

I can see worker machines, but those are not provisioned after hours also.

When I run    'oc logs machine-api-controllers-ffbd4b9c7-btbmm  -n openshift-machine-api -c machine-controller'   I can see some errors.

Can you please help me in resolving the issue.

Can someone look into this issue please

Basically the problem is that the cluster cannot connect to the ec2 endpoint from within the airgapped environment. I am planning to deploy a cluster to investigate this

Several things:

The ECR endpoint works - so theoretically the EC2 endpoint should also works
The IP Address indicated by the EC2 endpoint in the log above (<IP_ADDRESS>) seems to be from an internet address instead of a local address

Some debugging tests (perform this from master or bootstrap) - the cidr of ecr and ec2 endpoint should be the same:
[core@ip-10-0-135-84 containers]$ nslookup dkr.ecr.us-east-2.amazonaws.com
Server:		<IP_ADDRESS>
Address:	<IP_ADDRESS>#53

Non-authoritative answer:
727712539153.dkr.ecr.us-east-2.amazonaws.com	canonical name = dkr.ecr.us-east-2.amazonaws.com.
Name:	dkr.ecr.us-east-2.amazonaws.com
Address: <IP_ADDRESS>
Name:	dkr.ecr.us-east-2.amazonaws.com
Address: <IP_ADDRESS>
Name:	dkr.ecr.us-east-2.amazonaws.com
Address: <IP_ADDRESS>

[core@ip-10-0-135-84 containers]$ nslookup ec2.us-east-2.amazonaws.com
Server:		<IP_ADDRESS>
Address:	<IP_ADDRESS>#53

Non-authoritative answer:
Name:	ec2.us-east-2.amazonaws.com
Address: <IP_ADDRESS>
Name:	ec2.us-east-2.amazonaws.com
Address: <IP_ADDRESS>
Name:	ec2.us-east-2.amazonaws.com
Address: <IP_ADDRESS>

Here is the output.
[root@ip-10-5-0-78 ~]# nslookup<PHONE_NUMBER>68.dkr.ecr.us-east-2.amazonaws.com
Server:     <IP_ADDRESS>
Address:    <IP_ADDRESS>#53
Non-authoritative answer:
295635262768.dkr.ecr.us-east-2.amazonaws.com    canonical name = proxy-us-e-proxylb-rgy86izpd19c-38118563.us-east-2.elb.amazonaws.com.
Name:   proxy-us-e-proxylb-rgy86izpd19c-38118563.us-east-2.elb.amazonaws.com
Address: <IP_ADDRESS>
Name:   proxy-us-e-proxylb-rgy86izpd19c-38118563.us-east-2.elb.amazonaws.com
Address: <IP_ADDRESS>
Name:   proxy-us-e-proxylb-rgy86izpd19c-38118563.us-east-2.elb.amazonaws.com
Address: <IP_ADDRESS>
Name:   proxy-us-e-proxylb-rgy86izpd19c-38118563.us-east-2.elb.amazonaws.com
Address: <IP_ADDRESS>
Name:   proxy-us-e-proxylb-rgy86izpd19c-38118563.us-east-2.elb.amazonaws.com
Address: <IP_ADDRESS>
Name:   proxy-us-e-proxylb-rgy86izpd19c-38118563.us-east-2.elb.amazonaws.com
Address: <IP_ADDRESS>
[root@ip-10-5-0-78 ~]# nslookup ec2.us-east-2.amazonaws.com
Server:     <IP_ADDRESS>
Address:    <IP_ADDRESS>#53
Non-authoritative answer:
Name:   ec2.us-east-2.amazonaws.com
Address: <IP_ADDRESS>

verified

Thanks a lot Budi Darmawan, Thanks for your help in resolving the issue.
Your expertise on AWS and Openshift helped me in resolving this issue.
Can I close this issue.

Yes, he is an expert in Openshift & Terraform. I have closely interacted
with him.
On Wed, May 20, 2020, 8:09 PM shashiny<EMAIL_ADDRESS>wrote:

Thanks a lot Budi Darmawan, Thanks for your help in resolving the issue.
Your expertise on AWS and Openshift helped me in resolving this issue.
Can I close this issue.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ibm-cloud-architecture/terraform-openshift4-aws/issues/34#issuecomment-631515828,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEVRXORJ64KFNICIUG62RVDRSPTQPANCNFSM4NAK4FKA
.


Use working_dir in generated compose instead of always overriding, fixes #3158

The Problem/Issue/Bug:

#3158

#3158 points out that we could more efficiently do working_dir with the docker-compose yaml instead of only passing it on the docker-compose command line.
How this PR Solves The Problem:
Put working_dir in the generated .ddev/.ddev-docker-compose-*.yaml
Manual Testing Instructions:

[x] Use ddev exec and ddev ssh both with and without the -d flag, make sure it works all those ways.
[x] Change working_dir in the .ddev/config.yaml and make sure that it becomes the default

Automated Testing Overview:
I'm hoping the existing tests are adequate.
The behavior shouldn't change.

You can use gitpod to review this, https://gitpod.io/#https://github.com/drud/ddev/pull/3160
Or download and install in your path the artifacts, from https://github.com/drud/ddev/actions/runs/1126173412

I manually tested all the permutations, and even though this was not planned work, it seems to do fine. When it passes tests it can be pulled.

Will take a look next week, thanks for this!

This is not passing TestCmdWorkingDir at least not now. I don't think it has to do with this PR, others are seeing it, but I don't think it can go in until we understand why that test fails.


Add support for installing portables from a zip

Resolves #140
This PR adds functionality for supporting the installation of portable(s) from a zip archive.
Changes:

PortableEntry has been removed and replaced with PortableInstaller, which encapsulates the state and logic flow for handling a portable install/uninstall.
Portables from a zip are extracted directly to the target install folder. To support this, The ExtractArchive function passes a list by reference which will contain all of the extracted files after extraction is complete. Each extracted item is then recorded in the PortableIndex so that we can keep track of the files we place down during installation.
The portable target directory will always create and append a packageId_sourceId folder. This is to ensure that we always create the target install directory folder and do not risk attempting to delete a folder which we did not create (which can be an issue when using --purge)
Uninstall will now check that all exe and symlinks that are created have not been modified and can be safely removed prior to starting the uninstall flow. This is to ensure that we do not partially uninstall the package if a file does not match what is recorded in the index. This check can be overridden with the --force argument.

Tests:

E2E tests to verify that install, update, and uninstall work as expected for portable in zip.
Unit tests to ensure that all files recorded in the index are correctly verified prior to uninstall.
Added more granular tests for verifying portable installation (moving exe, creating symlink, and adding to PATH).

Microsoft Reviewers: Open in CodeFlow

Is the output of the files removed intentional?
PS D:\Git\winget-pkgs> wingetdev install -m D:\Git\winget-pkgs\manifests\c\Codex\ffmpeg\essentials\5.1.1
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://www.gyan.dev/ffmpeg/builds/packages/ffmpeg-5.1.1-essentials_build.zip
  ██████████████████████████████  78.9 MB / 78.9 MB
Successfully verified installer hash
Starting package install...
Successfully installed
PS D:\Git\winget-pkgs> winget list ffmpeg
Name              Id                                     Version
----------------------------------------------------------------
ffmpeg essentials Codex.ffmpeg.essentials__DefaultSource 5.1.1
PS D:\Git\winget-pkgs> wingetdev uninstall ffmpeg
No installed package found matching input criteria.
PS D:\Git\winget-pkgs> wingetdev uninstall 'ffmpeg essentials'
Found ffmpeg essentials [Codex.ffmpeg.essentials__DefaultSource]
Starting package uninstall...
"C:\\Users\\Trenly\\AppData\\Local\\Microsoft\\WinGet\\Packages\\Codex.ffmpeg.essentials__DefaultSource\\ffmpeg-5.1.1-essentials_build"
"C:\\Users\\Trenly\\AppData\\Local\\Microsoft\\WinGet\\Links\\ffmpeg.exe"
"C:\\Users\\Trenly\\AppData\\Local\\Microsoft\\WinGet\\Links\\ffplay.exe"
"C:\\Users\\Trenly\\AppData\\Local\\Microsoft\\WinGet\\Links\\ffprobe.exe"
Successfully uninstalled

Is the output of the files removed intentional?

I don't know if it is there for debugging purposes, but it should write them to log too.
WinGet-2022-09-17-21-50-32.732.log

@ryfu-msft, is there documentation on how to prepare WinGet zip-based manifest? Thank you.

@ryfu-msft, is there documentation on how to prepare WinGet zip-based manifest? Thank you.

I have a few examples on my fork - https://github.com/Trenly/winget-pkgs/branches/all?query=zips
[YamlCreate.ps1] also supports Zip, but you have to enable developer options and override the manifest version to 1.4.0 using the YamlCreate settings

We're going to update wingetcreate as well so it can also create manifests for .zip based packages.


Save parsed SDP tree in connection_resource.

It is really useful to have nicely parsed SDP tree during activation so that, for example, an audio receiver can get audio sampling rate and bit depth without looking up IS-04 sender resources.
It would be realy nice to have it upstream so I don't need to reimplement this hack every time:)

Hi Alexei, thanks for your idea. I'm not going to accept this, because I don't like having SDP parameters, which only apply to Sender resources with RTP transport, in the generic nmos::resource.
I propose another way of achieving this, in your application, could be to store a std::map<nmos::id, nmos::sdp_parameters> keyed on Sender id, which is kept up to date in the nmos::connection_sender_transportfile_setter callback. What do you think?

Yes I can do it in the make_node_implementation_transport_file_parser() callback (I only have Receivers). I can then do my own version of the parser and keep sdp_parameters in the map as you suggested. It's nicer with this new "hook"-way of doing things - I keep all application logic outside of the common code.


Fix: problem on run-android with deviceId

Fixes #132

Works well with enableSeparateBuildPerCPUArchitecture, universalApk options.
Even if it is already installed, it works normally. (Added -r option to adb install)

I hope this helps.

@grabbou @thymikee @ferrannp @Esemesek  I think there was some problems with how to use output.json mentioned above. For example, some users delete this file. so, It seems most reasonable to find the appropriate apk file for the target device's cpu via adb.
Please review my new approach.

@grabbou I'm done. Please let me know if you have any reviews.

@Krizzu can you give it one more look?


When compiling with Nuitka YARA-X python cause invalid YARA-X compiled rules file

All issues are mentioned at there:
https://github.com/VirusTotal/yara-x/issues/151#issuecomment-2203816324
It seems like it's related with Nuitka because when I compile with Nuitka it happens. When I test with pyinstaller I got off-topic issue: https://github.com/numpy/numpy/pull/26776
Here is the first message of this issue:
https://github.com/VirusTotal/yara-x/blob/2c5fdd924e86e315f1f56d47a37910f09494a282/lib/src/compiler/errors.rs#L25
,https://github.com/HydraDragonAntivirus/HydraDragonAntivirus/blob/main/antivirus.py
https://github.com/HydraDragonAntivirus/HydraDragonAntivirus/blob/main/nuitka.txt
When compiling with Nuitka YARA-X python cause invalid YARA-X compiled rules file, should I open this at Nuitka issues? Is this Nuitka related issue?

provide an minimal reproducible example.

https://github.com/HydraDragonAntivirus/HydraDragonAntivirus/blob/main/yara/yaraxtr.yar First download this. Then pip install yara-x. Then compile this .py code with python -m nuitka --standalone --onefile --include-module=yara_x compileryarax.py
save as compileyarax.py
import os
import yara_x

def compile_yara_rule(rule_path):
    try:
        with open(rule_path, 'r', encoding='utf-8') as f:
            rule = f.read()

        # Compile the rule using yara_x.compile
        compiled_rule = yara_x.compile(rule)
        return compiled_rule
    except FileNotFoundError:
        print(f"Error: Rule file '{rule_path}' not found.")
        return None
    except yara_x.CompileError as e:
        print("Error compiling YARA rule: ", e)
        return None
    except Exception as e:
        print("An unexpected error occurred:", e)
        return None

def save_compiled_rule(compiled_rule, output_path):
    try:
        # Serialize the compiled rule to a file
        with open(output_path, 'wb') as f:
            compiled_rule.serialize_into(f)
        print(f"Compiled rule saved to '{output_path}'")
        return True
    except IOError as e:
        print(f"Error saving compiled rule to '{output_path}':", e)
        return False
    except Exception as e:
        print("An error occurred while saving the compiled rule:", e)
        return False

def load_compiled_rule(output_path):
    try:
        with open(output_path, 'rb') as f:
            compiled_rule = yara_x.Rules.deserialize_from(f)
        return compiled_rule
    except FileNotFoundError:
        print(f"Error: Compiled rule file '{output_path}' not found.")
        return None
    except Exception as e:
        print("An unexpected error occurred while loading the compiled rule:", e)
        return None

def scan_file(compiled_rule, target_file_path):
    try:
        # Create a scanner with the compiled rule
        scanner = yara_x.Scanner(compiled_rule)

        # Scan the target file
        with open(target_file_path, 'rb') as f:
            file_content = f.read()
        results = scanner.scan(data=file_content)

        # Print the matches
        if results.matching_rules:
            print(f"Matches found in '{target_file_path}':")
            for rule in results.matching_rules:
                if hasattr(rule, 'identifier'):
                    print(f"Matched rule: {rule.identifier}")
                else:
                    print(f"Rule matched but has no identifier: {rule}")
        else:
            print(f"No matches found in '{target_file_path}'.")

    except FileNotFoundError:
        print(f"Error: Target file '{target_file_path}' not found.")
    except yara_x.ScanError as e:
        print("Error scanning file: ", e)
    except Exception as e:
        print("An unexpected error occurred:", e)

def main():
    rule_path = "yaraxtr.yar"
    output_path = "yaraxtr.yrc"
    target_file_path = "malware.exe"

    compiled_rule = compile_yara_rule(rule_path)
    if compiled_rule is None:
        print("Error: YARA rule compilation failed.")
        return

    if save_compiled_rule(compiled_rule, output_path):
        print("YARA rule compiled and saved successfully.")
    else:
        print("Failed to compile and save YARA rule.")
        return

    # Load the compiled rule from the saved file
    loaded_rule = load_compiled_rule(output_path)
    if loaded_rule is None:
        print("Error: Failed to load compiled YARA rule.")
        return

    # Scan the target file using the loaded compiled rule
    scan_file(loaded_rule, target_file_path)

if __name__ == "__main__":
    main()

Copy compileyarax.exe and rename it malware.exe to test it. Then test with this script too.
import yara_x

def load_compiled_rule(output_path):
    try:
        with open(output_path, 'rb') as f:
            compiled_rule = yara_x.Rules.deserialize_from(f)
        return compiled_rule
    except FileNotFoundError:
        print(f"Error: Compiled rule file '{output_path}' not found.")
        return None
    except Exception as e:
        print("An unexpected error occurred while loading the compiled rule:", e)
        return None

def scan_file(compiled_rule, target_file_path):
    try:
        # Create a scanner with the compiled rule
        scanner = yara_x.Scanner(compiled_rule)

        # Scan the target file
        with open(target_file_path, 'rb') as f:
            file_content = f.read()
        results = scanner.scan(data=file_content)

        # Print the matches
        if results.matching_rules:
            print(f"Matches found in '{target_file_path}':")
            for rule in results.matching_rules:
                if hasattr(rule, 'identifier'):
                    print(f"Matched rule: {rule.identifier}")
                else:
                    print(f"Rule matched but has no identifier: {rule}")
        else:
            print(f"No matches found in '{target_file_path}'.")

    except FileNotFoundError:
        print(f"Error: Target file '{target_file_path}' not found.")
    except yara_x.ScanError as e:
        print("Error scanning file: ", e)
    except Exception as e:
        print("An unexpected error occurred:", e)

def main():
    output_path = "yaraxtr.yrc"
    target_file_path = "malware.exe"

    # Load the compiled rule from the saved file
    loaded_rule = load_compiled_rule(output_path)
    if loaded_rule is None:
        print("Error: Failed to load compiled YARA rule.")
        return

    # Scan the target file using the loaded compiled rule
    scan_file(loaded_rule, target_file_path)

if __name__ == "__main__":
    main()import yara_x

def load_compiled_rule(output_path):
    try:
        with open(output_path, 'rb') as f:
            compiled_rule = yara_x.Rules.deserialize_from(f)
        return compiled_rule
    except FileNotFoundError:
        print(f"Error: Compiled rule file '{output_path}' not found.")
        return None
    except Exception as e:
        print("An unexpected error occurred while loading the compiled rule:", e)
        return None

def scan_file(compiled_rule, target_file_path):
    try:
        # Create a scanner with the compiled rule
        scanner = yara_x.Scanner(compiled_rule)

        # Scan the target file
        with open(target_file_path, 'rb') as f:
            file_content = f.read()
        results = scanner.scan(data=file_content)

        # Print the matches
        if results.matching_rules:
            print(f"Matches found in '{target_file_path}':")
            for rule in results.matching_rules:
                if hasattr(rule, 'identifier'):
                    print(f"Matched rule: {rule.identifier}")
                else:
                    print(f"Rule matched but has no identifier: {rule}")
        else:
            print(f"No matches found in '{target_file_path}'.")

    except FileNotFoundError:
        print(f"Error: Target file '{target_file_path}' not found.")
    except yara_x.ScanError as e:
        print("Error scanning file: ", e)
    except Exception as e:
        print("An unexpected error occurred:", e)

def main():
    output_path = "yaraxtr.yrc"
    target_file_path = "malware.exe"

    # Load the compiled rule from the saved file
    loaded_rule = load_compiled_rule(output_path)
    if loaded_rule is None:
        print("Error: Failed to load compiled YARA rule.")
        return

    # Scan the target file using the loaded compiled rule
    scan_file(loaded_rule, target_file_path)

if __name__ == "__main__":
    main()

It will cause no problems surprisingly. I should re-check my YARA-X code.

both snippets worked fine for me, second one is a bit broken but once cleaned up, works
Administrator in Desktop\Nuitka-Issues\2970-yara via 🐍 v3.11.9 (venv) took 1m7s
❯ main.exe
Compiled rule saved to 'yaraxtr.yrc'
YARA rule compiled and saved successfully.
Matches found in 'malware.exe':
Matched rule: leaked_lapsus_nvidia_leaked_certificate

it worked fine for me

try nuitka again with these cli args python -m nuitka --onefile compileryarax.py

No problems happened after python -m nuitka --onefile compileryarax.py

It seems like it's related problem with antivirus.exe.

It seems like it's related problem with antivirus.exe.

what do you mean? it works as expected does it not?

There problem with antivirus.exe. There no problem with antivirus.py because when I compile it then it says you got an error but when I use as script then it says no problem. When didn't use antivirus.exe but compile with Nuitka still there no problems.

can you make a repo with all the related and properly named files? and a step by step readme on how everything should be ran

There already a repo for antivirus.py https://github.com/HydraDragonAntivirus/HydraDragonAntivirus You can install it with requirements.txt, you can compile files yourself by just doing pip install -r requirements.txt then enter nuitka.txt commands. Done! If you want compile yaraxtr.yrc then you can use previous commands.

antivirus.zip
It fixed after this code:
yaraxtr_yar_path = os.path.join(yara_folder_path, "yaraxtr.yar")
yaraxtr_yrc_path = os.path.join(yara_folder_path, "yaraxtr.yrc")

def compile_yara_rule(yara_folder_path):
    try:
        # Compile the YARA rule using yara_x
        with open(yaraxtr_yar_path, 'r', encoding='utf-8') as f:
            rule = f.read()
        compiled_rule = yara_x.compile(rule)

        # Serialize the compiled rule to a file
        with open(yaraxtr_yrc_path, 'wb') as yrc_file:
            compiled_rule.serialize_into(yrc_file)

        print("Compiled yaraxtr.yar to yaraxtr.yrc")
        return True
    except Exception as e:
        print(f"An error occurred during compilation: {e}")
        return False
try:
    # Load the precompiled rule from the .yrc file using yara_x
    with open(yaraxtr_yrc_path, 'rb') as f:
        yaraxtr_rule = yara_x.Rules.deserialize_from(f)
    print("YARA-X Rules Definitions loaded!")
except Exception as e:
    print(f"Error loading YARA-X rules: {e}")
    print("Attempting to compile yaraxtr.yar to yaraxtr.yrc...")
    if compile_yara_rule(yara_folder_path):
        try:
            # Try loading the precompiled rule again after compilation
            with open(yaraxtr_yrc_path, 'rb') as f:
                yaraxtr_rule = yara_x.Rules.deserialize_from(f)
            print("YARA-X Rules Definitions loaded after compilation!")
        except Exception as e:
            print(f"Error loading YARA-X rules after compilation: {e}")
    else:
        print("Failed to compile yaraxtr.yar to yaraxtr.yrc.")


Route workload cluster app failed alerts to teams

Towards https://github.com/giantswarm/roadmap/issues/639
This PR:

Changes routing workload cluster app alerts so they route to teams.

Checklist

[x] Update changelog in CHANGELOG.md.
[ ] Request review from oncall area, as well as team (e.g: oncall-kaas-cloud GitHub group).
[ ] Alerting rules must have a comment documenting why it needs to exist.

Tested on gauss

Not expecting problems but I'm AFK tomorrow. So will merge this first thing on Friday.


Trigger transition onPress?

Is there a way to trigger the transition when the screen is press, similar to Instagram stories

Yes! You can add onPress event and use the this.cube.scrollTo(index) function to go to next and prev views.
https://github.com/zehfernandes/react-native-3dcube-navigation/blob/badbcfb5fe880dc963a55e26d35307f2149cb210/examples/components/CubeHorizontal.js#L25

If its a functional component
function xyz () {
const pageNum =2, shouldAnimate = true;
let cube = useRef();
.
.
.
.
function somFunction = () {
.
.
.
cube.current.scrollTo(pageNum, shouldAnimate);
.
.
.
}
return (
<CubeNavigationHorizontal key={0} ref={(view) => {
cube.current = view;
}}>
.
.
.
.
.

);
}


comma-survey does not contain data in article

In the comma survey data set (https://github.com/fivethirtyeight/data/tree/master/comma-survey), the CSV with data does not contain the columns the story specifies. The story (https://fivethirtyeight.com/features/elitist-superfluous-or-popular-we-polled-americans-on-the-oxford-comma/) specifically shows a graph with how well people rated their own grammar, separated by if people used an Oxford comma. This graph cannot be recreated with the provided data.

Looks like column with the question asking to rate own grammar is missing. If that was included, it looks like you can recreate the graph in the story. The second column that asks which sentence is preferred -- with or without Oxford comma -- appears to act as the preference filter in the chart.

Yep. I have been playing with the data and successfully made graphs showing
how much people cared about the comma based on whether or not they used it,
shown a correlation between caring about comma and caring about data, and a
couple other things. It's just an issue that the grammar rating column is
missing. Is this still housed somewhere, even though it's been almost 4
years?
On Wed, Mar 14, 2018, 12:48 AM Matthew Guhit<EMAIL_ADDRESS>wrote:

Looks like column with the question asking to rate own grammar is missing.
If that was included, it looks like you can recreate the graph in the
story. The second column that asks which sentence is preferred -- with or
without Oxford comma -- appears to act as the preference filter in the
chart.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/fivethirtyeight/data/issues/120#issuecomment-372932459,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFlB0t2LimSvY16hBNnQNAWTYcpwQTRTks5teMtUgaJpZM4Spy1a
.

Cómo obtener una visa para América y obtener una identificación

Cómo obtener una visa para América y obtener una identificación

Good

W

Sorry, but this data has been lost to time.


Project questions UI changes: warning when save fails and adapt UI for autosave

A PR for #610 and #604 , hopefully can go in the 1.10.1 but still needs a review/changes.
When Autosave is enabled:

Rename the "Save and proceed" button to "Proceed"

Coverage: 90.7%. Remained the same when pulling 042da82aad552ff89134dfa8db5aa89a4039bf38 on 610-604-add-error-msg-when-answer-was-not-saved into 49359fa5890adbff335a01ce58df47fbc9dad6d2 on dev-1.10.0.


specify postgres in .travis.yml

This fixes PRs and master. It seems like we need to start specifying that the postgres service start in .travis.yml?

@fivetanley I just had a quick question on this before we approve it.

hey @kwugirl @jsncmgs1 thanks for the feedback! sorry i've been working on data.heroku.com incidents for the past few days. it looks like we are good to go here? (once web services is ready of course, no rush)


Add Packages Section!

Title and Issue number
Title: Add Packages Section for Fitness Plans
Issue No.: 64
Code Stack: React (Packages.jsx, Packages.css), Node.js
Close #64

Feature Description
This PR adds a "Packages" section to the application, presenting various fitness packages, including options for different training durations, nutrition plans, and group classes tailored to different fitness levels.
Key Features

Package Options: Users can compare different fitness packages (e.g., Basic, Intermediate, Advanced).
Training Durations: Select packages with different durations (1 month, 3 months, 6 months).
Nutrition Plans: Customizable nutrition plans to go with training.
Group Classes: Optional group classes available for each fitness level.

Video (mandatory)
https://github.com/user-attachments/assets/4ca8bafe-a420-4988-80ce-2204be911a65

Checklist:

[x] I have mentioned the issue number in my Pull Request.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have created a helpful and easy-to-understand README.md if it's a new page/tech stack.
[x] I have gone through the contributing.md file before contributing.

Additional context (Mandatory)
Are you contributing under any Open-source program?

[x] I'm a GSSOC-EXT contributor.
[x] I'm a HACKTOBERFEST contributor.

@jeevan10017 yeah for some part I am definitely taking gpt's help and ok I will keep this in mind. Thanks for the suggestion.


[Feature][TIDB] TiDB Connector supports CDC or not.

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
TiDB Source Connector supports CDC or not.
Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

hi, @CodeExplorer10  not yet. Would you like to contribute to this?


Add tip to limit scope of Get/UploadModuleLogs

In response to a live site incident where a customer was calling the method every 30 secs without any filtering which backed up the system and caused the system to appear unresponsive.

Learn Build status updates of commit dc22c2e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/iot-edge/how-to-retrieve-iot-edge-logs.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@PatAltimore

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Learn Build status updates of commit 8e7f2d6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/iot-edge/how-to-retrieve-iot-edge-logs.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 4a7c75b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/iot-edge/how-to-retrieve-iot-edge-logs.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

#sign-off


Move todo into issue

https://github.com/bash/fmtastic/blob/7a035a0d91bc55d8434cc98329dacd91ddaa4fe1/src/sub_superscript.rs#L57

#16


BoundsError during 'eval_tree_array'

What happened?
I tried to run '_eval_tree_array'  with array that has different dimensions then cX in 'eval_tree_array'
And if i understand correctly after test runs l've got an error ''
Version
0.18.0
Operating System
macOS
Interface
Jupyter Notebook
Relevant log output
BoundsError: attempt to access 1×11 Matrix{Float32} at index [4, 1:11]

Extra Info
my version of 'eval_tree_array' :
'''
function eval_tree_array(
tree::Node{T}, cX::AbstractMatrix{T}, operators::OperatorEnum; turbo::Bool=false
)::Tuple{AbstractVector{T},Bool} where {T<:Number}
if turbo
@assert T in (Float32, Float64)
end
r = T.( [6.332061275761631 5.051237472144821 2.7 4.2690748412273125 3.3068111527572905 5.4 4.676537180435969 6.037383539249433 5.727564927611035 3.8183])
result, finished = _eval_tree_array(
tree, r, operators, (turbo ? Val(true) : Val(false))
)
@return_on_false finished result
@return_on_nonfinite_array result
return result, finished

end
'''

Could you share your full code, so I can reproduce it?


En starting page

Removed the math symbol from the starting page, added participate button and changed vision text. closes #390

Awesome!

Comments inline

Could you additionally create a screenshot, so I get a better feeling of what this looks like?

What does it look like when you're logged in?

The default login is admin@localhost with password 123456 iirc

I have  changed things according to what you said. The screenshot is also not up to date, will create a new pull request tomorrow

Changed a small thing in the styles and need to update them on my machine as well, I will see tomorrow how it looks

[...] will create a new pull request tomorrow

Not needed, just push additional commits to the same branch.

It would be great if you could make a screenshot of the german landing page as well :)

I didnt change anything on the German landing page

I didnt change anything on the German landing page

You did, this PR contains 3 changed files, on of them is the german landing page: https://github.com/JonasBley/athene2/blob/f8ffafc1175e084d10ff7c06531c79a135e873ef/src/module/Ui/templates/layout/de/serlo-home.phtml

You can view all changes of your PR on GitHub:

I created the class "home-emph-link" and moved the link properties from the class "home-column" to the new class, so I added all the links on the German page to the home-emph-link class.
I needed to do that, because I couldnt otherwise change the participate and the about button on en.serlo.org

I didnt actually change anything on the German page, it looks just the same

I didnt actually change anything on the German page, it looks just the same

Haha, my bad, got it :)

Awesome! Thank you!


http://orbjs.net is down

Can't access the documentation, is there anyone who has the previous documentation !!!

Still down

Is this still being supported?

still down

Now used by cybersquatters :-(


wouldn't users impersonate people by altering current-user-id in chrome inspector?

in an application where user #1 is an admin user, wouldn't users be able to masquerade as him by opening up chrome inspector,
and chaging tag to
<meta name="current-user-id" content="1">

I guess - only if your backend doesn't verify your token/cookie/whatever-you-use-to-authenticate and blindly trusts a user-alterable front-end value. :)

Hey @la-ruby, thanks for opening this issue!
The short answer is: no.
But it really depends how and what you implement in your application. Your backend should have to responsibility to check if the currently signed-in user is allowed to do a certain action.
Depending on how you use the library on the frontend, as user might be able to reveal an additional button on a page if it was tied to a specific user for example, but the action this button would call should again be verified by your backend. The backend is and should be the single-source-of-truth.
The values you put in your  should always be treated as read-only values, the main motivation to put the values there is so that you can also easily read them in your JavaScript code.
I hope this helps!


Control PR build through comments

Drone should provide a way to control PR builds through the comment system of the remote.
For example a contributor could specify in the comments to do: build and then Drone would kick off a build.
Potential use cases

Gating a PR build so it is not run until a maintainer approves a run
Run different configurations such as turning a feature flag on/off

Examples in the wild

Jenkins Plugin
GitLab Integration

Looking to formalize this into a feature

do you think there should be a formal notation / language similar to [ci skip]?
[drone approve]           # approve the gated build
[drone deploy production] # deploy to production

or should we let individual projects define regular expressions or matching criteria in the yaml?
triggers:
  - match: deploy to production
    action: deploy
    environment:
      - FOO=bar
      - BAZ=boo

in terms of turning feature flags on / off would this be done by injecting environment variables into the build? I included an environment section in the above example for this purpose.

Looking to switch to drone from Jenkins, and this is the feature that is holding me back.
I guess options for the following would make sense

auto-build on PR create : boolean

auto-build on new commits pushed to PR : boolean

not sure if this needs to be a separate option or rolled in with the PR create option

auto-merge/close PR on build success: boolean

not sure if user config about the remote branch to merge to would be needed for this option

build-trigger phrase: regex

build-trigger user whitelist: list of users who can use the trigger phrase to trigger builds

PR-merge phrase: regex

merge-trigger user whitelist: list of users who can use the trigger phrase to merge PRs

Optionally:

ability to specify actions after merge (e.g. test and/or build after merge)

But I guess this could be specified as trigger actions on the target branch being merged into?

I am not sure if it would be useful to have control over status updates from drone on the PR (e.g. control over msg string and customizing using env/build vars).

auto-build on PR create : boolean
auto-build on new commits pushed to PR : boolean

fyi drone already does these

Thanks for clarification @bradrydzewski
Didn't know that drone supports PR triggers - just found http://docs.drone.io/github.html#hooks

and these can be done via plugins today

Can you post links to the plugins please ?

@mohanraj-r I think he means you can create plugins to do that today; I don't remember seeing any plugins doing that as of today.

@bradrydzewski a common theme here I think is allowing customizable triggers.
A comment is just another event that GH sends to Drone via webhook.
Looking back at https://github.com/drone/drone/issues/1878#issuecomment-264900509, Comment created would cover this.
And if trigger parsing could be customized via plugins, I can see a pipeline definition like this:
pipeline:
  test_darwin:
    when:
      - image: plugins/github-comment
        type: create
        contains:
          - test-darwin
          - test-osx

  test_linux:
    when:
      - image: plugins/github-comment
        type: create
        contains: test-linux

  test_windows:
    when:
      - image: plugins/github-comment
        type: create
        contains: test-windows

  # combo of branch and comment
  deploy:
    when:
      - branch: nix/*
      - image: plugins/github-comment
        type: create
        contains:
          - deploy-darwin
          - deploy-osx
          - deploy-linux

@tonglil that looks quite flexible and extensible.
How would the when condition decide whether to start the pipeline?
based on the exist code of the plugin? , meaning exit code 0 trigger the build , exit code 1 don't

aah actually the plugin needs to listen all the time for events so needs to be running all the time.

Use case: Allow PR author (or reviewer) to run a series of more expensive, lengthy tests before merging PR, but not on every single push to the PR.  This could include Selenium tests, integration tests, or even something like standing up a dev cluster with the feature branch changes.
I like how the kubernetes project has a bot that listens to slash-commands, like:

The kubernetes CI bot also provides a helpful message for PRs from non-org-members and allows trusted members to trigger a test pipeline:

Here's the kubernetes CI bot's "vocabulary" which is about much more than just CI - and also includes code review workflow stuff, and CLA validation, etc: https://prow.k8s.io/command-help
More about prow: https://github.com/kubernetes/test-infra/tree/master/prow

@geekdave thanks for the feedback. Would /test foo execute only step foo or would it execute all pipeline steps including foo? If foo is the only step executed, is there any concern that artifacts or assets may not existing (e.g. you need to re-download dependencies, re-compile, etc)?

for me /test foo exectute an action on kubernetes

Allow test
Retest

for example :
pipeline:
  bar:
    image: alpine
    commands: echo hello
    when:
      FULLTEST: TRUE
  baz:
    image: alpine
    commands: echo hello
triggers:
   -match: retest
    action: retest
   -match: ok-to-test
    action: trust_pr
   -match: long test
    action: retest
    environment:
      - FULLTEST=TRUE
   -match: stop-test
    action: untrust_pr
   -match: deploy
    action: retest
    environment:
      - DEPLOY=TRUE

Is this implemented? Or there is a way to do this today using a plugin? Thanks!

no, it is not currently implemented (we typically label issues when we start working on something, and close the issue when complete). I do not think we have a final spec of what to build, and we are still at the point of collecting use cases and ideas. We also may decide that this is better suited for a plugin as opposed to being part of Drone core.

Thanks for the fast response! Do you know if currently there is a plugin implemented that covers this use case?

I am trying to build a plugin that takes when there is a comment on a pull request, but I wonder how to obtain the payload from the github webhook.
I have seen that github has this event pull_request_review_comment but how should I approach this? Any ideas? Or place to check something similar?

any progress on this?

UP! I want this feature!

I will lock this issue for now. It will get unlocked when somebody can start working on that.


Added postFormatVSCodeCommand option, so that I can use RuboCop and Prettier for Ruby at the same time

I really like how RuboCop can fix linting issues as well as formatting the code. However, I prefer the way that Prettier for Ruby formats code since it's much more opinionated, and it does a much better job with hashes. Prettier can automatically split and indent hashes across multiple lines, but RuboCop can't do this.
I tried to switch to Prettier, but then I really missed all the extra things that RuboCop was doing for me.
This new option allows me to call prettier.forceFormatDocument from the Prettier VS Code extension to format the code after RuboCop has fixed all of the linting issues. Thanks!

Sorry please ignore this, it doesn't work quite right - the file is modified by Prettier but isn't saved


Recommended edits to Getting Started

I am proposing the following changes to the wiki:

Additional required packages: rlang, dotCall64 seem to be required for VELandUse (dependency of spam, which is a dependency of fields).
Better yet, add dependencies = TRUE to step 5 install.packages
biocLite("zlibbioc") seems to be required
Remove VERoadPerformance and VEReports from step 7, as these fail with error:

Downloading GitHub repo gregorbj/VisionEval@master
from URL https://api.github.com/repos/gregorbj/VisionEval/zipball/master
Installation failed: Does not appear to be an R package (no DESCRIPTION)

Add VECommercialTravel to step 7, as this is required by VERSPM/Test1/run_model.R
Remove duplicated VETransportSupplyUse from step 7

I can make these changes if all agree.

I just added the additional dependencies.  The inconsistency for which packages to include is a versioning issue - the master branch doesn't have VEReports, but develop does for example.  We're in the process of pulling develop into master and so I just updated the Getting Started page, but then we ran into a time limitation for the test system.  We're working on fixing it and then master and the Getting Started page will be consistent.

Got it. I'll test again after master is updated, closing this issue for now.

@dflynn-volpe - I just pulled develop into master and so please try again and let me know if you run into any issues.  Thanks.

FYI - I updated the testing documentation to include our use of Travis caches.

Really slow to install modules, but seems to be working. Even downloading and running devtools::install_local(), still downloading the full develop branch when trying to install each module. Consider changing the location of the remote DESCRIPTION file (e.g. here) to master.

Done, see  https://github.com/gregorbj/VisionEval/blob/master/install.R and https://github.com/gregorbj/VisionEval/wiki/Getting-Started


Remove broken/unused deps

I updated to Fedora 29 yesterday, which brought in nodejs 10. With that, I can't build almond-cloud locally anymore.

Pull Request Test Coverage Report for Build 324

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 54.101%

Totals

Change from base Build 322:
-0.01%

Covered Lines:
4247

Relevant Lines:
7278

💛  - Coveralls

I'm going to merge this because the new version of node is preventing me from adding new packages and that's a problem.


Kill null arg sent to all route handlers

A side-effect of parsing the optional query arg.
Discovered when trying to do something like:
var _ = require('lodash');
var greet = require('./greet');

Router.extend({

  routes: {
    ':name/:greeting': 'greet',
    'hi-doug': 'hiDoug',
    'hi/:name': 'hiPerson',
  },

  greet: greet,
  hiDoug: _.partial(greet, 'doug', 'hi'),
  hiPerson: _.partialRight(greet, 'hi'), // fails via `greet('NameFromUrl', null, 'hi')`
});

At first glance, this looks good to me. I'm gonna run through the tests and logic this weekend. It'll probably be a SEMVER major change by the looks of it (which is nbd)

I agree with these proposed changes. Tests pass locally. Going to let another member or two +1 this.

Yes this is a good update and I agree it's a major semver. Thank you for taking the time to submit this @beck

Released in v5.0.0

I was using the optional (but always present) query string argument in the execute method to always parse the query params and pass them to the route callback as an object.
With this change I don’t see a viable solution to this anymore, because it is hard to detect if the last arg is a named param or the optional query string.
I liked the fact, that the last arg always contained the value of the query string (and therefore null if no query string was present). To me this was a more reliable solution to handling query strings.

What happens now when the query string is present and what happens when the query string is not present?

When a query string is present, it is available in the last arg. If no query string is present, the last argument is the last named param from the route.
Consider this Router for example:
const MyRouter = Router.extend({

  routes: {
    ':categoryId': 'category'
  },

  category(...args) {
    console.log(args);
  }

});

In ampersand-router@4
MyRouter.navigate("/books");
// ["books", null]
MyRouter.navigate("/books?page=2");
// ["books", "page=2"]

In ampersand-router@5
MyRouter.navigate("/books");
// ["books"]
MyRouter.navigate("/books?page=2");
// ["books", "page=2"]

Differentiating between params and query string is hard now, because they are all strings.

@cdaringe is it possible to use route handlers that are more expressive with the accepted arguments?
categrory(category, query)

Would work, with @5 query will now be undefined instead of null.

@beck For most people this would be a viable solution, but they would have to do the parsing of query params in multiple route handlers now, because this example from the AmpersandRouter#execute docs is not working anymore:
var Router = AmpersandRouter.extend({
  execute: function(callback, args) {
    args.push(parseQueryString(args.pop()));
    if (callback) callback.apply(this, args);
  }
});

I’m not able to use this work around because I extended AmpersandRouter with some additional functionality that hooks into execute. Currently this is no big deal fro me. I’ll just stick to ampersand-router@4 by now and maybe do a fork if the need arises for me.
I just wanted to share my perspective on this in case someone else will have issues with this change in the future.


Make geoCodeMarker optional

Currently a L.Marker is always created and displayed when a geocode result i presented on the map.
The fitBounds functionality is, from my perspective, enough to visualize the result. It would be nice with an option, eg. showResultMarker: false

Wow, that's a big pull request :)
I'm not sure I'll accept it, I don't think it's the same plugin now.
Thanks anyway.

@JonasKa I think maybe you wanted to submit this PR to https://github.com/perliedman/leaflet-control-geocoder ?

@sa3m sorry about that. Just forget about it :)
@perliedman Yes, that's was my intention, but instead I created (two) here instead. No idea how that happend. I'll try make it right the next time.
//GitHub newbie

..I guess I forgot to change "base fork" during creation of the PR.


fix: do not promote record.labels if improper

We promote a bunyan record.labels property to the LogEntry.labels
property. This enables label based filtering to work auto-magically.
However, this can be problematic when the labels are not type correct
as per the logging proto requirements - specifically, the labels values
have to be strings.
Restrict the automatic promotion to happen only in the cases when
know that the labels are well-formatted.
Fixes: https://github.com/googleapis/nodejs-logging-bunyan/issues/265

System tests had failed with
Error: Quota exceeded for quota metric 'clouderrorreporting.googleapis.com/manage_error_events_data_requests' and limit 'ManageErrorEventsDataRequestsPerMinutePerUser' of service 'clouderrorreporting.googleapis.com' for consumer 'project_number:1046198160504'.

/cc @JustinBeckwith could we get the error reporting quota increased for the system test project? I added a few patches which meant that the tests ran a few times, probably pushing us over the quota. It would be good if we were not too close to the edge.

Was this a logging quota or error reporting API quota?

Error reporting.


Initial commit

@n1zea144
Should I change the name of the main class and things to remove references to GenomeNexus since we made the annotation an interface that could technically plug into anything?

Yes, you could just refer to things as annotation pipeline or something to that effect.  AnnotatorImpl could be renamed to GenomeNexusImpl.

@n1zea144 updated PR - no longer has any genome nexus references in the code. We might want to change the name of this repo as well. I also added the option to keep hugo symbols from annotation if desired.

@n1zea144 All the proposed changes have been made.

@n1zea144 didn't see a way to reference a property within the property file, so I just made the initial change suggested of requiring fully formed URLs in application.properties.

I think we need to add at least one unit test to the project.  You can check in an pre and post annotated MAF.  The test can create a new annotated MAF from the checked in pre- and diff it with the checked-in post annotated MAF.

@n1zea144 added integration testing. Ready for review.


Feat: save function for workbook

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.18%. Comparing base (4a1e8fe) to head (d8008b8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   98.85%   94.18%   -4.68%
==========================================
  Files           7        1       -6
  Lines         701       86     -615
==========================================
- Hits          693       81     -612
+ Misses          6        3       -3
  Partials        2        2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.