[bug] "remember_chat_context" doesn't work correctly if a single prompt is called repeatedly.

See example here: https://colab.research.google.com/drive/1H_3ddewTOR70kmuIYUlC1eB76_pIp3KT?usp=sharing
The messages passed do not correctly match the chat history. A demo like CLIMate only works correctly because it creates a new prompt each call.

is this related to deserialize containing the previous run's outputs?

The confusion here seems to stem from the remember_chat_context functionality. By default, this is set to True, meaning the model parser, OpenAI in Jay's example, constructs chat history using previous prompts. This means that each re-run of the same prompt will overwrite the output from a previous run. This behavior implies that to effectively construct a chat history, users must add a new prompt with each call, as demonstrated in the CLIMate example.
See this CLIMate code ref here for how new prompts are added
We could consider an option to preserve previous outputs instead of overwriting them. However, I believe it would make more sense to maintain the current approach, where the focus is on adding new prompts to build the chat history, rather than trying to persist input history for each prompt.

Ankush, your approach is reasonable. I think it does complicate the use of
AIConfig for Agent-like use cases, but those are not high priority for me.
I'd still call it unexpected behavior given what "remember_chat_context"
does when working correctly.
On Sun, Dec 3, 2023 at 6:57 PM Ankush @.***> wrote:

is this related to deserialize containing the previous run's outputs?
The confusion here seems to stem from the remember_chat_context
functionality. By default, this is set to True, meaning the model parser,
OpenAI in Jay's example, constructs chat history using previous
prompts. This means that each re-run of the same prompt will overwrite the
output from a previous run. This behavior implies that to effectively
construct a chat history, users must add a new prompt with each call, as
demonstrated in the CLIMate example.
See this CLIMate code ref here for how new prompts are added
https://github.com/lastmile-ai/aiconfig/tree/main/cookbooks/Cli-Mate#L124-L128
We could consider an option to preserve previous outputs instead of
overwriting them. However, I believe it would make more sense to maintain
the current approach, where the focus is on adding new prompts to build the
chat history, rather than trying to persist input history for each prompt.
—
Reply to this email directly, view it on GitHub
https://github.com/lastmile-ai/aiconfig/issues/399#issuecomment-1837646062,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAU7BS2YXIU4ZRAWG7ERSYTYHUGVFAVCNFSM6AAAAABAELC44CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGY2DMMBWGI
.
You are receiving this because you authored the thread.Message ID:
@.***>

It sounds like the high-pri item here is to clarify the intention and behavior remember_chat_context? incidentally, we also have this issue (https://github.com/lastmile-ai/aiconfig/issues/393) which is about making AIConfig work better for agent-like applications.

@Ankush-lastmile , is this in scope for the week?

the high-pri item here is to clarify the intention and behavior remember_chat_context

Seems like just better docs.

Removing high-pri label -- we can keep this issue open to see if there's a better way to do what remember_chat_context does today


Fix ipv6 formatting for consul discovery

In some specific scenario, when reverse lookup from nameServer, will get domain other than ipv6 address.
When wrap with square brackets, will result in java.net.URISyntaxException: Malformed IPv6 address at index 8: http://[dc53-xx-xxxx-xxxx.example.org]:9209/xxx
e.g.

@LichMscy Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@LichMscy Thank you for signing the Contributor License Agreement!


Generate symbols for SourceLink

The existing publish script will now upload a snupkg symbol package alongside the nupkg.
This will allow developers to step into the source of this package if necessary when debugging.
https://docs.microsoft.com/en-us/nuget/create-packages/symbol-packages-snupkg

Hey @iCodeSometime
Sorry for the late reply. I honestly never heard of this before so thanks for teaching me something new! I was aware of pdb files but not about this. Changes is looking good!
With kind regards,
TheBoneJarmer

Sorry about that, I should have checked the readme first, I'll get it right next time.
The snupkg thing is fairly new, but it's pretty convenient to be able to step in to external libraries without having to do any setup

Hey, I created a workflow you can use if you like. You can just paste it into a new action - should be free since it's a public repo.
Once it's installed, if anyone other than you opens a PR merging into main, it'll comment "Pull requests may not be created against the main branch. Updating the branch target to develop - make sure to fix any merge errors. See the contribution guidelines for more info."
It then automatically updates the target branch to "develop", where Github will check if it merges cleanly. Maybe this can cut down on some annoyance for you.
Appreciate you,
iCodeSometime
on:
  pull_request:
    types: [opened]
job:
  update-pr-target:
    if: ${{ github.base_ref == 'main' && github.actor != 'TheBoneJarmer' }}
    steps:
      - name: Comment about wrong branch
        uses: actions/github-script@v5
        with:
          script: |
            github.rest.issues.createComment({
              issue_number: context.issue.number,
              owner: context.repo.owner,
              repo: context.repo.repo,
              body: 'Pull requests may not be created against the main branch. Updating the branch target to develop - make sure to fix any merge errors. See [contribution guidelines](github-script) for more info.'
            })
      - name: Update PR target branch
        uses: actions/github-script@v5
        with:
          script: |
            github.rest.pulls.update({
              pull_number: context.issue.number,
              owner: context.repo.owner,
              repo: context.repo.repo,
              base: 'develop'
            })


monitoring/vmstats_collector: add machine_type label for vm_info

Adding the label machine_type to the kubevirt_vm_info metric would help detect if stopped VMS which don't have active VMI resource are using an outdated machine type.
This ensures the detection logic doesn't solely depend on the kubevirt_vmi_info metrics stored in the Prometheus database
example with example/vm-cirros.yaml:
kubevirt_vm_info{container="virt-controller", endpoint="metrics", flavor="<none>",
instance="<IP_ADDRESS>:8443", instance_type="<none>", job="kubevirt-prometheus-metrics",
machine_type="q35", name="vm-cirros", namespace="default", os="<none>",
pod="virt-controller-5cd9584758-9rvdk", preference="<none>", service="kubevirt-prometheus-metrics",
status="Stopped", status_group="non_running", workload="<none>"}

Fixes #
Release note
None

/retest-required

/retest-required

/approve
@avlitman can you please review as well?

@dasionov please add a Release note and the ticket number if not private (:

/retest

/lgtm


add langtools_extpath for openj9/ibm

related: https://github.com/adoptium/aqa-tests/issues/4405

xlinux JDK11: internal/Grinder
xlinux8,17,19: internal/Grinder
windows JDK8,11,17,19: internal/Grinder

failing GH Actions

Directories/Files Change Test PR build failures are unrelated to this PR.


Could not create conda environment from checkm2

I'm trying to run this command
snakemake --snakefile Snakefile-hifimags.smk --configfile configs/Sample-Config.yaml -c8 --use-conda
But got a problem with create env via checkm2.yml
Here is my log
Config file config.yaml is extended by additional config specified via the command line.
Building DAG of jobs...
Your conda installation is not configured to use strict channel priorities. This is however crucial for having robust and correct environments (for details, see https://conda-forge.org/docs/user/tipsandtricks.html). Please consider to configure strict priorities by executing 'conda config --set channel_priority strict'.
Creating conda environment envs/checkm2.yml...
Downloading and installing remote packages.
CreateCondaEnvironmentException:
Could not create conda environment from /Users/wipoo/pb-metagenomic-tools/HiFi-MAG-Pipeline/envs/checkm2.yml:
Command:
mamba env create --quiet --file "/Users/wipoo/pb-metagenomic-tools/HiFi-MAG-Pipeline/.snakemake/conda/8b0bff0a701061d036f98a34ba683f68_.yaml" --prefix "/Users/wipoo/pb-metagenomic-tools/HiFi-MAG-Pipeline/.snakemake/conda/8b0bff0a701061d036f98a34ba683f68_"
Output:
Could not solve for environment specs
Encountered problems while solving:
  - nothing provides requested _libgcc_mutex 0.1**
  - nothing provides requested _openmp_mutex 4.5**
  - nothing provides requested boost-cpp 1.70.0**
  - nothing provides prodigal >=2.6.3 needed by checkm2-1.0.1-pyh7cba7a3_0
  - nothing provides requested diamond 2.0.4**
  - nothing provides requested keyutils 1.6.1**
  - nothing provides requested ld_impl_linux-64 2.39**
  - nothing provides requested libgcc-ng 12.2.0**
  - nothing provides requested libgfortran-ng 12.2.0**
  - nothing provides requested libgomp 12.2.0**
  - nothing provides requested libnsl 2.0.0**
  - nothing provides requested libstdcxx-ng 12.2.0**
  - nothing provides requested prodigal >=2.6.3

The environment can't be solved, aborting the operation

Hey, I am getting the same error! Did you figure out how to solve this?
Thanks

Hi @MelodyMale and @PeymanDerik ,
Thanks for your patience.
The checkm2 environment recipe might not be robust or their may be an issue with your conda settings.
Let's start by listening to the warning in the conda code:
Your conda installation is not configured to use strict channel priorities. This is however crucial for having robust and correct environments (for details, see https://conda-forge.org/docs/user/tipsandtricks.html). Please consider to configure strict priorities by executing 'conda config --set channel_priority strict'.

The bioconda, conda-forge, and defaults channels should really be prioritized in that order. Try this and see if it fixes the issue.
Alternatively, you can try a lightweight version of the environment to see if that helps.
Copy/paste this into your checkm2.yml and try again:
name: checkm2_env
channels:
  - bioconda
  - conda-forge
  - defaults
dependencies:
  - checkm2=1.0.1

It may cause the same initial issue, but could be another workaround.
Let me know if you have success with either option.

@dportik Thank you for your solution, it worked!

Noting that this is now addressed in #54


[stable/cluster-autoscaler] Deployment strategy option

Signed-off-by: Igor Belikov<EMAIL_ADDRESS>Is this a new chart
NO
What this PR does / why we need it:
Add an option to configure deployment update strategy. In some cases the default values Kubernetes fills in for update strategy can conflict with affinity/anti-affinity settings and prevent the rollout of updated deployment.
Which issue this PR fixes
N/A
Special notes for your reviewer:
Checklist

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @yurrriq

Thanks!
/ok-to-test
/lgtm


Revert "Keep focus on textinput field after pressing enter when button is disabled"

Reverts Expensify/App#8591
That PR caused as issue so i'm reverting it. I tested the reported issue steps mentioned here and confirm its resolved.

Tests were passing when the PR was merged. Removing Emergency label.

🚀 Cherry-picked to staging by @luacmartins in version: 1.1.57-14 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

🚀 Deployed to production by @chiragsalian in version: 1.1.57-17 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Proper line numbers in $log output in Chrome

Right now, output of $log in Chrome shows the line number from where [the .apply() function is being called] (https://github.com/angular/angular.js/blob/95c2738244172ab3aff215e622a610dbb30631d6/src/ng/log.js#L152) within Angular.
It would be nice if the line number is where the $log was called in my source code.
I'm not super clear on how loglevel does it, but it would be nice to replicate that behavior:
Log output keeps line numbers: most JS logging frameworks call console.log methods through wrapper functions, clobbering your stacktrace and making the extra info many browsers provide useless. We'll have none of that thanks.
The reason why I'm asking for this in Angular is because there is another project which just extends $log to provide more functionality vs. replacing it entirely. It would gain from having the line numbers be equal to where $log was called in my code.
Thanks!

I think this can be closed given prior issues on logging.

@wesleycho Please enumerate these prior issues you speak of. =)

@lookfirst: #2975, #11660 and #14224 to name but a few :smiley:
There is more context/background on why why can't/won't "fix" $log in these issues. That said, it is trivial to write your own console wrapper.
@wesleycho: Thx for the awesome work on issue clean-up :clap:


ckeditor in production

Hi
I'm going crazy beacuse in development I have no problem. But releasing online I have an exception with ckeditor.
In /blog/admin/posts/:title/edit
I can't see the ckeditor.
In console I have a problem that say:
if I override
https://github.com/greyblake/blogo/blob/master/app/assets/javascripts/blogo/ckeditor/ckeditor_basepath.js.erb
and set
base_path << '/ckeditor/' instead of   base_path << '/blogo/ckeditor/'
I see the ckeditor in textarea but I have an exception on image upload :(
please help me
Nunzio

404 error
https://www.dropbox.com/s/dcdrb5975mfhtz2/Screenshot 2016-01-02 01.56.23.png?dl=0
:(

perhaps I quite resolved but I have the only problem that in development it seems that  it's all ok and image upload form point to /blog/admin/images
but in production form point to /ckeditor/pictures and so I have an error of not right path... do you know how to set it to the right point?

For others who come across this, I was able to use the "non-stupid-digest-assets" gem to solve the issue as described by @eterry1388 here: https://github.com/greyblake/blogo/issues/31#issuecomment-163757183


lxd 3.0.0: lxc copy stuck, never ends

lxc copy a stopped container is stuck:
lxc copy local-vpn:Wine qboxv3-vpn:
Transferring container: snap0: 4.35GB (26.33MB/s)
waiting indefinitely...
on the dest: there is a snapshot from the copy:
gquentin@sd-57286:/$ sudo du -sm var/snap/lxd/common/lxd/storage-pools/default/snapshots/Wine/snap0
4604	var/snap/lxd/common/lxd/storage-pools/default/snapshots/Wine/snap0
lxc info (source and destination are almost the same):
config:
core.https_address: '[::]'
core.trust_password: true
api_extensions:

storage_zfs_remove_snapshots
container_host_shutdown_timeout
container_stop_priority
container_syscall_filtering
auth_pki
container_last_used_at
etag
patch
usb_devices
https_allowed_credentials
image_compression_algorithm
directory_manipulation
container_cpu_time
storage_zfs_use_refquota
storage_lvm_mount_options
network
profile_usedby
container_push
container_exec_recording
certificate_update
container_exec_signal_handling
gpu_devices
container_image_properties
migration_progress
id_map
network_firewall_filtering
network_routes
storage
file_delete
file_append
network_dhcp_expiry
storage_lvm_vg_rename
storage_lvm_thinpool_rename
network_vlan
image_create_aliases
container_stateless_copy
container_only_migration
storage_zfs_clone_copy
unix_device_rename
storage_lvm_use_thinpool
storage_rsync_bwlimit
network_vxlan_interface
storage_btrfs_mount_options
entity_description
image_force_refresh
storage_lvm_lv_resizing
id_map_base
file_symlinks
container_push_target
network_vlan_physical
storage_images_delete
container_edit_metadata
container_snapshot_stateful_migration
storage_driver_ceph
storage_ceph_user_name
resource_limits
storage_volatile_initial_source
storage_ceph_force_osd_reuse
storage_block_filesystem_btrfs
resources
kernel_limits
storage_api_volume_rename
macaroon_authentication
network_sriov
console
restrict_devlxd
migration_pre_copy
infiniband
maas_network
devlxd_events
proxy
network_dhcp_gateway
file_get_symlink
network_leases
unix_device_hotplug
storage_api_local_volume_handling
operation_description
clustering
event_lifecycle
storage_api_remote_volume_handling
nvidia_runtime
api_status: stable
api_version: "1.0"
auth: trusted
public: false
auth_methods:
tls
environment:
addresses:

<IP_ADDRESS>:8443
<IP_ADDRESS>:8443
<IP_ADDRESS>:8443
<IP_ADDRESS>:8443
<IP_ADDRESS>:8443
architectures:
x86_64
i686
certificate: |
-----BEGIN CERTIFICATE-----
-----END CERTIFICATE-----
certificate_fingerprint: deb858c54df6cc8fced5fe565ec87f21824fc9265f47490ba39b642a8c2322b8
driver: lxc
driver_version: 3.0.0
kernel: Linux
kernel_architecture: x86_64
kernel_version: 4.13.0-38-generic
server: lxd
server_pid: 9315
server_version: 3.0.0
storage: btrfs
storage_version: "4.4"
server_clustered: false
server_name: gquentin-ssd-t3

it looks like the copy is ok on destination.
But the source never ends

I believe that's the same issue as I'm having @brauner look at in #4475.
4475 started as a live-migration/criu problem, but the main issue is btrfs send/receive migration hanging, possibly masking errors. Closing this one, treating as duplicate, please subscribe to #4475.


Show all defaults in the config

The default values of todohighlight.defaultStyle and todohighlight.keywords are not taken over into the config when you select them (so they are not in the default config). At least VSCode settings do. Currently you have to look them up in the code. Maybe they are just missing in the package.json?
(I am not sure if they could then be removed from the code, although that could probably be another Issue).

Good suggestion, thanks.

Since I don't program JS myself and have no idea about VSCode extensions, I can't test it myself, but maybe only the following is missing:
https://github.com/jgclark/vscode-todo-highlight/blob/6b10ef6d5f96af9ce5fd1bf9019ad8c1f6531daa/package.json#L156
"default": {
    "color": "#2196f3",
    "backgroundColor": "#ffeb3b",
}

und in https://github.com/jgclark/vscode-todo-highlight/blob/6b10ef6d5f96af9ce5fd1bf9019ad8c1f6531daa/package.json#L107
"default": {
    "TODO:": {
        "text": "TODO:",
        "color": "#fff",
        "backgroundColor": "#ffbd2a",
        "overviewRulerColor": "rgba(255,189,42,0.8)"
    },
    "FIXME:": {
        "text": "FIXME:",
        "color": "#fff",
        "backgroundColor": "#f06292",
        "overviewRulerColor": "rgba(240,98,146,0.8)"
    }
}

I've tried this out, and it doesn't work.
That part of the package.json file is defining terms, and it can take a default values inside the setting definition, but it only gets applied as a completion when a user edits that particular definition in settings.json.

Yes, it is correct that it is only transferred to settings.json when changes are made. This file should only contain changes that differ from the default. If these values are in the defaultSettings.json everything is correct, then it is the same as for other extensions and VSCode itself.
I had looked at the following https://github.com/microsoft/vscode-docker/blob/e2f0fa48901d086ae72e569d4c04d9ab37cd61a8/package.json#L1801. This is present in the defaultSettings.json and is therefore automatically transferred to the settings.json when the parameter is selected.

I think #62 is fixing this, so i will close the issue as completed.
They could now be removed from the code, although that is probably be a new issue


feat: ActionContext#boundary

Codecov Report

Merging #160 (8b746f6) into master (5df9edc) will increase coverage by 0.180%.
The diff coverage is 40.458%.

@@               Coverage Diff               @@
##              master      #160       +/-   ##
===============================================
+ Coverage     38.348%   38.528%   +0.180%
- Complexity      1053      1059        +6
===============================================
  Files            210       210
  Lines          10136     10177       +41
  Branches        2510      2535       +25
===============================================
+ Hits            3887      3921       +34
- Misses          5448      5449        +1
- Partials         801       807        +6

Flag
Coverage Δ

unittests
38.528% <40.458%> (+0.180%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...n/com/itangcent/intellij/actions/KotlinAnAction.kt
0.000% <0.000%> (ø)

...m/itangcent/intellij/psi/AbstractPsiClassHelper.kt
52.566% <0.000%> (ø)

...in/com/itangcent/intellij/context/ActionContext.kt
38.987% <45.299%> (+4.405%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5df9edc...8b746f6. Read the comment docs.


Error: Cannot find module discord.js

Error: Cannot find module 'discord.js'
Require stack:

C:\Users\juanp\OneDrive\Documents\GitHub\spambot\bot.js
←[90m    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)←[39m
←[90m    at Function.Module._load (node:internal/modules/cjs/loader:778:27)←[39m
←[90m    at Module.require (node:internal/modules/cjs/loader:1005:19)←[39m
←[90m    at require (node:internal/modules/cjs/helpers:102:18)←[39m
at Object. (C:\Users\juanp\OneDrive\Documents\GitHub\spambot\bot.js:1:20)
←[90m    at Module._compile (node:internal/modules/cjs/loader:1105:14)←[39m
←[90m    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1159:10)←[39m
←[90m    at Module.load (node:internal/modules/cjs/loader:981:32)←[39m
←[90m    at Function.Module._load (node:internal/modules/cjs/loader:822:12)←[39m
←[90m    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)←[39m {
code: ←[32m'MODULE_NOT_FOUND'←[39m,

Did you run npm install?

Closing due to inactivity, please feel free to ping me if you are still having any issues and I would be happy to open this back up to assist you!


formula_auditor: add GNOME GitLab to GNOME audit

[x] Have you followed the guidelines in our Contributing document?
[ ] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.
[ ] Have you successfully run brew style with your changes locally?
[ ] Have you successfully run brew typecheck with your changes locally?
[ ] Have you successfully run brew tests with your changes locally?

Some formulae may fetch tarballs from GNOME's GitLab instance rather
than the URLs that we check.
See Homebrew/homebrew-core#107423.

Review period will end on 2022-08-09 at 00:00:00 UTC.

We'll need to resolve https://github.com/Homebrew/homebrew-core/pull/107423 before merging this.

Review period skipped due to critical label.


Setup page config functions not functional in 1.0.3/4 that worked in 1.02

Hi,
Several /setup page options that were working in 1.0.2 now do nothing in 1.03 or 1.04.
-Custom logo not working
-Custom /setup page title not working
-Custom firmware version not working
See attached screen captures.
Here is the code:
// Web Server library
#include <AsyncFsWebServer.h>
// WebServer
AsyncFsWebServer asyncServer(WSPort,FILESYSTEM);
// Add a new config box
asyncServer.addOptionBox("Things");
asyncServer.addOption("Build Date (MMDDYY)", buildDate);
// Add custom page title to /setup
char pageTitle[30];
sprintf(pageTitle,"Setup %s",macID);
asyncServer.setSetupPageTitle(pageTitle);
// Add custom logo to /setup page with custom size:w
asyncServer.setLogoBase64(base64_logo, "128", "128", /overwite file/ true);
asyncServer.setFirmwareVersion(BUILD_VER);
// Start webServer
asyncServer.init();
 v1.0.2
 v1.0.3/1.0.4

I noticed that the Options tab that was auto generating under 1.0.2 has vanished.  Attempts at creating the tab have failed.

Sorry for all of the issues.
-michael

I found that if I manually add the param-box# to the config.json, it will show up.
{
"param-box1": "Options",
"IPaddr": "",
"GW": "",
"Mask": "",
"DNS": "",
"NWConfig": 0,
"sensorType": 33,
"BuildDate": "123123",
"Backlight": true,
"BacklightOffTime": 0,
"BacklightOffDelay": 600000,
"Feature": 0,
"Category": 33,
"WSPort": 80,
"Units": 0,
"TempOffset": 0,
"TempMin": 0,
"TempMax": 0,
"HumidOffset": 0,
"HumidMin": 0,
"HumidMax": 0,
"TempDev": 0,
"WatchDog": true,
"Hostname": "bite_me",
"Server": "<IP_ADDRESS>:8090",
"name-logo": "Setup 27FC6C123123",
"img-logo": "/config/img-logo-128_128.txt",
"param-box2": "Bite me!"

So it looks like the function call to set the value  (asyncServer.addOptionBox) is not connecting....
I would also like a handler to intercept the config save.  When I do a pull down box, it is saving all of the options, not just the one I selected.  This creates a very large json file when the pulldown box is for timezones.
I will continue testing.
-michael

Hi Michael.
To introduce the latest features (manual wifi configuration) I had to slightly modify the structure of the config.json file.
I tried to make the change backwards compatible, but I would say it didn't work. I'm sorry for the inconvenience.
To fix it, the advice is to delete or rename the current config.json file and restart the ESP so that a new one will be created.

I will test this weekend.  What about a method of only showing the config elements I want to show on the Config page in /setup?

Sorry, I do not understand what you mean.

Everything in my config file, shows up on the config tab.  I would like to selectively display some config elements and not others.  See the attached image,

To fix it, the advice is to delete or rename the current config.json file and restart the ESP so that a new one will be created.
Tried it.  Still no joy.

On another note: If I change the web server port from 80 to anything else on the 1.0.2 branch, the Options tab also disapears.

I am still having problems with the calls to customize the HTML pages.
Here is code:
asyncServer = new AsyncFsWebServer(WSPort,FILESYSTEM);
asyncServer->enableFsCodeEditor();
asyncServer->setFsInfoCallback(getFsInfo);
asyncServer->on("/", handleRoot);
asyncServer->on("/stats", getStats);
asyncServer->on("/stats/json", getStatsJSON);
asyncServer->on("/connect", HTTP_POST, MydoWifiConnection);
// Serve the /&Stats/ page
asyncServer->on(("/" + String(macID) + "&Stats/").c_str(), HTTP_GET, getStats);
// Serve the /&Stats/json page
asyncServer->on(("/" + String(macID) + "&Stats/json").c_str(), HTTP_GET, getStatsJSON);
// Add a new config box
asyncServer->addOptionBox("Configuration");
// asyncServer->addDropdownList("Time Zone", tzNames, N_ELEMENTS(tzNames));
asyncServer->addOption("Backlight",Backlight,false);
asyncServer->addOption("BacklightOffDelay",BacklightOffDelay,false);
// Add custom page title to /setup
char pageTitle[50];
sprintf(pageTitle,"Watchman %s",macID);
Serial.println(pageTitle);
asyncServer->setSetupPageTitle(pageTitle);
Things like the page title contain a MAC address.  I have verified the pageTitle variable contains the full text; however, when I call the setSetupPageTitle, I am only getting up to the first space with no mac address.
Other things still do not display like the Configuration tab items.
Any suggestions?

I think I found the problem.  I am using config.json for the application data and your library is also using it.  If I move my config to another named json file, the web page functions start working.  I also found that if I do not enable the edit page, I can provide my own handler for the POST of the /edit command.  Sadly, this does not work if the edit pages are enabled.
I would like to request that a option to provide an additional function to be called when the "Save Config" button is pressed.


Cypress Test fixes for event-analytics

Description
Fixed the re-naming of event-analytics links causing the testing to fail.
Fixed existing bugs in some of the test so each run successfully
Issues Resolved
[List any issues this PR will resolve]
Check List

[ ] New functionality includes testing.

[ ] All tests pass, including unit test, integration test and doctest

[ ] New functionality has been documented.

[ ] New functionality has javadoc added
[ ] New functionality has user manual doc added

[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Removed version upgrade as it will be a separate PR pending discussion on https://github.com/opensearch-project/dashboards-observability/issues/411.
This PR now just fixes the url naming conventions and wait commands.


OpenSSL Issue

Hi,
First I want to say I'm pretty new at linux and so I apologize in advance is this is a minor issue with an obvious solution. I'm trying to get this package installed and upon running npm install from the node-opcua-logger directory I get several errors having to do with the creation of private keys and certificates using openSSL. I've attached a text file with all the errors (there were several, all related to openSSL). However they all appear to be duplicates of this:
###########OPENSSL ERROR ############
CWD = /home/bmcadmin/node-opcua-logger/node_modules/node-opcua-client
Command failed: "openssl" genrsa  -out "/home/bmcadmin/node-opcua-logger/node_modules/node-opcua-client/certificates/PKI/own/private/private_key.pem" -rand "/home/bmcadmin/node-opcua-logger/node_modules/node-opcua-client/certificates/PKI/own/private/random.rnd" 2048
Can't load /home/bmcadmin/node-opcua-logger/node_modules/node-opcua-client/certificates/PKI/own/private/random.rnd into RNG
139806547309696:error:2406F079:random number generator:RAND_load_file:Cannot open file:../crypto/rand/randfile.c:98:Filename=/home/bmcadmin/node-opcua-logger/node_modules/node-opcua-client/certificates/PKI/own/private/random.rnd
[OPCUA-Logger Errors.txt](https://github.com/coussej/node-opcua-logger/files/3238905/OPCUA-Logger.Errors.txt)

Thanks for any help resolving this issue!

Hi, can you specify some details about your environment?

OS?
Node version
Is openssl installed correctly? Which version?

I have the same issues, both unexperienced and "Can't load /home....../random.rnd into RNG":
My versions are:
user@computer:~/node-opcua-logger$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 18.04.2 LTS
Release:        18.04
Codename:       bionic
user@computer:~/node-opcua-logger$ openssl version
OpenSSL 1.1.1  11 Sep 2018
user@computer:~/node-opcua-logger$ node --version
v8.10.0
I don't know how to tell if openssl is correctly installed...
Thanks!

Hi @AWanderingEngineer,
certificate generation is done by the underlying node OPCUA library, and I've had problems with it before. Could you try this with the new version (v2) of the logger, which also contains a much more recent version of the node-OPCUA library? Even better, if you download a binary from the release page, you don't need to generate anything yourself.


Manga with no groups for scanlator cause issues

Device information

Tachiyomi version: Neko v<IP_ADDRESS>
Android phone & version: Galaxy A51

Steps to reproduce
Open chapter list for some manga
Expected behavior
There used to be "unknown group" for chapter uploader (author? idk what the term is), now there isn't anything
Filtering upload groups should show all groups
Actual behavior
There isn't "unknown group" for chapter uploader (As far as i can tell, all manga with unknown group uploaders are affected)
"unknown group" isn't listed in filter as it's not tagged to any chapters, creating ghost unreads if you hit "ok" on filter group instead of "reset all". Can be fixed if you hit "reset all" but issue will persist if you exit out of chapter list and open it again (Some manga have been affected, not sure if it'll be the same for everyone but
https://mangadex.org/title/3fba42cf-2ad6-4c30-a7ab-46cb8149208a
https://mangadex.org/title/c26269c7-0f5d-4966-8cd5-b79acb86fb7a)
Other details
https://cdn.discordapp.com/attachments/569823838305648640/866705198662287410/Screenshot_20210719-113650_Neko.jpg
https://cdn.discordapp.com/attachments/569823838305648640/866509785121685524/Screen_Recording_20210718-223944_Neko.mp4

For my record
Relationship is missing so it needs to default to No Group
https://api.mangadex.org/chapter/a51131e6-372d-4f63-a40c-1ae28f224b7a

2.5.5


css for terminal color quickpick not applied in new window

Testing #196195

Move a terminal to a new window
Run terminal: change color
🐛 no colors in the quickpick

@Tyriar I see that there is a style element in body:

That is not a good place, why not head? We only track global styles in head.

via https://github.com/microsoft/vscode/commit/47a0ab66a0310544896158f3f519bea13a31bdd7


Allow build script to specify install prefix.

This change is a work in progess.
Used twice successfully with v1.12.6 and v1.12.7, linux only.
Sparked from #13240 & #13389.

So I am really completely unaware of what work-flows this might be affecting. Any advice is appreciated.
The only thing that seems obvious to me is that the last chunk (desktopEntryContents) shouldn't be "userLocalDirPath" in every case.

No response regarding issue.


latency max < min on rtmp output

Hello, I'm using Brave and it works just fine.
I found an issue and I was able to fix it. But I don't really know if this would have other side impacts. So I'm stating it here in order to contribute with my finding and maybe the authors will find it useful.
In some situations I get the following gstreamer error and the RTMP output goes red with a clock error.
The solution I found was to reduce the "key-int-max" value from 60 to 30, on "brave/outputs/rtmp.py". The issue is not easily repeatable. I could only have it consistent on an Azure VM. On another machine it stopped happening (I don't know why). On other machines it never happens.
I'm attaching some screen-shots that I hope will clarify this matter. I can submit a pull request if you think that is appropriate.
I would appreciate if the authors of Brave could share their considerations about this finding and the fix I propose. I have no experience with gstreamer.
Thank you
João

addding another screenshot showing Brave web interface when such error occurs.

Hi João
Fascinating... we haven't seen a clock problem before.
Nice work finding a workaround. Yes this is useful to learn.
 I wonder if we should make that the default for Brave. The YouTube and Facebook Live specs say they accept a 1 second keyframe. Though Twitch's docs suggests it mandates 2 seconds (https://help.twitch.tv/s/article/broadcast-requirements?language=en_US). You mentioned Twitch in your GStreamer post, did it work fine?
Great that you've asked the GStreamer list too (http://gstreamer-devel.966125.n4.nabble.com/Gstreamer-error-clock-problem-Azure-VM-td4690187.html). Given the explanation from Nicolas, I can't work out how a lower keyframe helps! More broadly, we have seen other types of timing issues between the video and audio. So it doesn't surprise me it's something in this area.
What would be interesting would be to see if the problem disappears if audio is disabled. If you were to add enable_audio: false to the config file, then Brave removes the audio part of the pipeline and the need to synchronise would disappear. Doing so would confirm that is a video/audio sync issue.
Thanks again for sharing this,
Matthew

Hi Matthew,
:) my pleasure. it was hard to solve the problem. even more because I am not an expert in the topic. I am a software developer. we are building an application and Brave solves us the problem that we do not master gstreamer.
About your question: yes. we have been using Brave to stream to twitch, at 720p and 1080p, mostly with ffmpeg testsrc and testsrc2 signals (at 720p and 1080p), we overlay a simple PNG and it works very well. We have observed 48h continuous operation several times.
We have also streamed to youtube with success too.
Wa are also considering streaming with FFmpeg (because of authentication issues). But Brave is still, and will continue to be our main tool. what we do it push the result to nginx and from there we spread it, with FFmpeg, to several CDNs.
Presenty we have the sources on our repo. The only change we did so far is this one I reported. If this ever gets into the main code, we can consider cloning it again.
Anyway, it's ok.
Thank you for tis great piece of work. we love it.
João

may be you'dd like to consider keeping 60 as default, but allowing the user to change that value through configuration (the data in the PUT that creates the rtmp output). For me it would be a fine solution.

Closing as this is a stale issue.


pprof: weird allocation counts after reading a file of a certain minimum size

Here is a gist containing a program that does the following:

Set runtime.MemProfileRate to 1.
Read a flag-controlled number of zeroes from /dev/zero using ioutil.ReadAll and io.LimitReader.
Call io.MultiWriter 1024 times in a loop, encouraging it to make allocations.
Write out a heap profile to /tmp/mem.pprof.

When I run the program with the flag that tells it to read 2096128 bytes before calling io.MultiWriter, I see the expected number of calls in the profile:
% go build main.go && ./main --size 2096128 && grep -B 1 MultiWriter /tmp/mem.pprof
1024: 32768 [1024: 32768] @ 0x43aaf5 0x45dd38 0x400f60 0x4010a1 0x42a3ff 0x456331
#       0x45dd38        io.MultiWriter+0x48     /usr/local/google/home/jacobsa/clients/go/src/io/multi.go:58
--
996: 31872 [1024: 32768] @ 0x45dda3 0x400f60 0x4010a1 0x42a3ff 0x456331
#       0x45dda3        io.MultiWriter+0xb3     /usr/local/google/home/jacobsa/clients/go/src/io/multi.go:60

However, with any value above this I get unreliable results (these change from run to run, but are never the full count and are often zero):
% go build main.go && ./main --size 2096129 && grep -B 1 MultiWriter /tmp/mem.pprof
0: 0 [0: 0] @ 0x45dda3 0x400f60 0x4010a1 0x42a3ff 0x456331
#       0x45dda3        io.MultiWriter+0xb3     /usr/local/google/home/jacobsa/clients/go/src/io/multi.go:60
--
0: 0 [0: 0] @ 0x43aaf5 0x45dd38 0x400f60 0x4010a1 0x42a3ff 0x456331
#       0x45dd38        io.MultiWriter+0x48     /usr/local/google/home/jacobsa/clients/go/src/io/multi.go:58

This shows up as nonsense callgraphs in pprof, containing lots of runtime frames and the wrong counts for the functions I'm interested in. Compare this one to this one. Each is from an invocation of pprof that looks like:
go tool pprof -alloc_objects ~/tmp/59f9bbfa096fd3c595dc/main /tmp/mem.pprof

I have been unable to simplify the test case further. In particular, merely allocating a slice of bytes of the given size isn't good enough; it seems I have to open and read a file. I've also seen the problem when not setting runtime.MemProfileRate to a non-default value, but it is harder to reproduce.
go version:
go version devel +f2662f2 Tue Jun 23 03:18:52 2015 +0000 linux/amd64

Marking this Go1.5 so we at least understand what's happening.

The heap profile reports a snapshot as of the most recent garbage collection. It omits more recent allocations, because otherwise the recent garbage in the profile can drown out the older live data. What's going on in your program is that the size of the read affects whether a garbage collection happens after the multiwriters are created. If so, they appear in the profile; if not, they don't.
If you want to see a snapshot of live data as of the writing of the profile, you need to call runtime.GC before writing out the profile. If you only care about allocation counts and not what is live, then you can also use GOGC=off. When the GC is off, the profile reports all allocations (since there's no "last GC").
So this is working as intended, if possibly mysteriously. I will update the runtime/pprof doc comment to make this clear.

Thanks so much for the explanation. Sticking something similar in the docs sounds good to me.

Oh, to clarify: when you say "see a snapshot of live data", do you mean to say only objects that are still live? Or can I call runtime.GC just before writing the file to see historical allocation counts, even for objects that have long since been collected?

@jacobsa Each profile line gives n: m [N: M] for a particular allocation stack, where n: m is currently allocated (live) objects, and N: M is all objects. pprof --inuse_xxx uses n: m and pprof --alloc_xxx uses N: M. What I mean by "a snapshot of live data" is really "a snapshot of right now", because those are updated only at each GC.

Got it, thanks for confirming.


Consider moving all the large arrays off the stack

As of PR #72, I encountered a stack overflow problem when running the core.
To reproduce:

Compile the core with -Ofast,
Try a run at 700x700x1 or finer resolution,
Observe segmentation fault.
If running under valgrind, it reports illegal memory accesses, and recommends increasing the limit on the total stack size, and the stack frame size.  Increasing said limit causes the segmentation fault to go away.
Compiling with -O2 instead of -Ofast also fixes it.

Diagnosis:

Arrays of input-specified size are being allocated on the stack.  Thus, if they are large enough, they can overflow limits on stack size or stack frame size.
The problem manifests in -Ofast but not -O2 because -Ofast includes -fstack-arrays, whose documentation speaks as follows: "Adding this option will make the Fortran compiler put all local arrays, even those of unknown size, onto stack memory.  If your program uses very large local arrays it is possible that you will have to extend your runtime limits for stack memory on some operating systems. This flag is enabled by default at optimization level -Ofast."

What should be done about this?  Options:

Explicitly code all variable-size arrays as allocatable, as the last commit of PR #72 does with the pile of arrays local to model_run.

Con: Code gets larger and somewhat harder to read.  Memory leaks are not a problem, though, as the standard calls for those arrays being automatically deallocated on exit from the subroutine that declares them.
Con: There is some possibility that the allocatable delcaration will impede some optimizations, if gfortran is not smart enough to statically determine that the array is allocated immediately and deallocated only when it goes out of scope.
Con: Relatively annoying to measure performance effect of having the arrays on the stack or on the heap.

Add -fno-stack-arrays to the compilation command.

Con: May not be portable to compilers that are not gfortran; but how big of a problem is that?  ifort may well give up to a ~2x speedup, but do we access to it for testing anyway?
Pro: Can make the code slightly more legible by reverting said last commit of PR #72.

Tell the users to raise their stack limits.

Con: Complicates adoption.
Con: May not be portable across operating systems (Unices have ulimit, so that's fine; dunno about Macs, and we're not worrying about Windows anyway).
Pro: Presumably -Ofast puts those arrays on the stack for a reason; but then again, if they're that big, it shouldn't much matter where they are allocated.

Automate raising the stack limit in the wrapper program.

Con: Portability across operating systems will be even more brittle than user instructions.

This is stretching my knowledge of the underlying architecture, but my understanding is that the stack is per thread, so will multithreading essentially deal with this issue?
Just to check - explicitly allocating the arrays is a portable way of forcing them to be in the heap, rather than the stack? And the only downsides to this are the additional allocate commands and the possibility that some compiler optimisations won't be applied?
Finally, 700x700 is quite large, so for now perhaps we can park this as a warning in the documentation and return to it later. Given that running such large grids entirely in serial will take an annoying amount of time, if we get to a stage where this issue only turns up if multithreading is turned off, I'd be happy with that.

On stacks: Not exactly.  There is a single main stack, which is pertinent before (and after) the threads execute; and then each thread is given a smaller stack so they can call subroutines.  In any case, if single-threaded execution breaks a stack limit, multithreading isn't going to help.
I don't know how portable explicitly allocating the arrays is.  One downside is the additional allocate commands, and the possible (but in my opinion unlikely) loss of some optimizations; another is that if we leave the arrays as automatic, the -fstack-arrays option of gfortran will make it pretty easy to measure whether there is a performance benefit to having the arrays on the stack---at sizes small enough that they fit (or if the stack limit is raised so they fit).
Re: size: 700x700x1 is about the same amount of memory as 500x500x2 or 400x400x3, which seems more plausible, particularly in n+1/2-layer mode.

Thanks for the clarification.
In that case, is it worth doing some careful benchmarks with and without the -fstack-arrays flag? If we don't see an improvement, perhaps we go for the allocate option - it seems to be the most robust solution to me.

I just reproduced this running a high resolution simulation to make pretty graphics for the landing page. It seems that even with the allocate commands the model is able to blow stack limits.
As far as performance issues go, I came across a comment on a stackoverflow question dealing with this issue. The benchmarks in the comment suggest that the benefit from keeping the arrays on the stack is very small for arrays with more than 500 elements. Most configurations of Aronnax, and certainly all the ones in which performance is a serious issue, will have more grid points than that.
I'm now tempted to add the -fno-stack-arrays flag to the compilation, put a note in the documentation about it, and remove the allocate commands from the model_run subroutine. If I go down that road, I'll play around with the benchmarking script and see how large the impact is before pushing any changes into master.

Running some benchmarks suggests that the performance change for Aronnax is very small, especially when using the Hypre solver, and that the -fno-stack-arrays version is very slightly faster. The small effect makes sense, since most of the runtime is spent in Hypre subroutines, which will be unaffected by the change in compiler flag.
Based on these results I will add the -fno-stack-arrays flag to the makefile and revert the allocate commands introduced in the final commit of PR #72.


Use the -checkpoint_count flag to support the file checkpoint to reduce read and write unmodified file chunks in local disk mode

It looks slower when the big file changes because it causes more reading but less writing.


cmake: bump SOVERSION

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9377254) 60.00% compared to head (103b2f6) 60.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1052   +/-   ##
=======================================
  Coverage   60.00%   60.00%
=======================================
  Files          19       19
  Lines        2580     2580
  Branches      911      911
=======================================
  Hits         1548     1548
  Misses        692      692
  Partials      340      340


[0.10.0-rc1] user passwords not changeable

Docker container based on "tutum/curl:trusty" and the Influxdb 0.10.0-rc1 Debian/Ubuntu package.
A user created with password "testing" cannot change this and authenticate to the api.
# Query with the user
curl -G 'http://localhost:8086/query' -u testuser:testing --data-urlencode "q=SHOW DATABASES"
{"results":[{"series":[{"name":"databases","columns":["name"],"values":[["prometheus"],["_internal"],["telegraf"],["statsd"]]}]}]}
# Setting new password
curl -G 'http://localhost:8086/query' -u testuser:testing --data-urlencode "q=SET PASSWORD FOR testuser = 'mypassword'"
{"results":[{}]}
# Query with old password (ok?)
curl -G 'http://localhost:8086/query' -u testuser:testing --data-urlencode "q=SHOW DATABASES"
{"results":[{"series":[{"name":"databases","columns":["name"],"values":[["prometheus"],["_internal"],["telegraf"],["statsd"]]}]}]}
# Query with new password (failed)
curl -G 'http://localhost:8086/query' -u testuser:mypassword --data-urlencode "q=SHOW DATABASES"
{"error":"authentication failed"}```

@norrland Thanks, I'm able to reproduce the same issue.
/cc @jwilder

@corylanou @dgnorton could this be caused by the new meta.Client in use everywhere?

@jwilder I'll take a look


Switches to ghcr

This publishes our images exclusively to GitHub (ghcr) in order to
prevent build outages due to Docker Hub pull limits going into place
on Nov 1 (notably 200 pulls/6hrs). This also prevents our images from
being purged if they had inactivity in six months.
Notably, this requires changing the image name like the following:
-    JRE_IMAGE=openzipkin/java:15.0.1-15.28.13-jre
+    JRE_IMAGE=ghcr.io/openzipkin/java:15.0.1-15.28.13-jre

The images can be viewed here: https://github.com/orgs/openzipkin/packages/container/package/java

@openzipkin/core @openzipkin/devops-tooling
The overall plan here is to only push to dockerhub end-user images (openzipkin/zipkin for example). We would never consume them as it would overrun our quota when things like pull requests pull and execute these images. We can't rely on caching alone to achieve 200 pulls for 6hrs, in other words.
Since these are the base-most images, releasing this prior to refactoring upstream builds to pull them, also push to ghcr and never use anything except ghcr in CI/CD flows.

this is the first change to use these images https://github.com/openzipkin/brave-example/pull/66

https://github.com/openzipkin/zipkin/pull/3263 for zipkin

https://travis-ci.org/github/openzipkin/docker-java/builds/739205220 if fails I'll fix it :D


.add() method not respecting .watch() method settings

I thought I'd make this a separate issue. Based on my code in #207, when I use the .add() method later on a watcher, it doesn't seem to respect the options set in .watch(). Is that a bug?

Sounds like it. Good chance it's the same bug. Will work on it this afternoon.

I'm not able to reproduce this. The way ignoreInitial was implemented had problems, but all the other options (such as ignored are behaving the way I'd expect).
Using this test code (modified from example.js, I don't get events for node_modules or .git stuff in either directory:
var watcher = require('./').watch('../brunch', {
  ignored: /node_modules|\.git/,
  persistent: true,
  //followSymlinks: false,
  //useFsEvents: false,
  //usePolling: false
}).on('all', function(event, path) {
  console.log(event, path);
}).on('ready', function() {
  console.log('ready');
  setTimeout(function(){watcher.add('.')}, 1000)
})

The way you set your ignored in the other thread is going to calculate those paths relative only to cwd, which is most likely the cause of the issue you observed. If you want it to behave as a pattern that applies to any directory you add, convert those strings to one or more regexes or glob patterns like:
ignored: /\.git|\.DS_Store|node_modules/


Remove odd windows check in knife bootstrap

The bootstrap command currently checks to see if the server name that is being bootstrapped is "windows" and if so fails telling the user they should install knife-windows. The error mentions that hostname contained windows, but the check is == 'windows'.
Users bootstrapping are doing so via chefdk where knife-windows is already installed and this check isn't even doing what it was intended to do.

Closing this. It's hacky, but it's actually checking for the plugin not the server.


Save data to standard directory

This PR adds a standard directory for MORS, in line with the changes in JANUS: https://github.com/FormingWorlds/JANUS/pull/53
Closes #13

Hi @nichollsh @lsoucasse Would you be willing to review this one?


Differences from Plenoxels

Sorry for asking something not directly related to the code. But ReLu fields seem to have much in common with Plenoxels (as noted in your paper), expect perhaps for the grid pruning used during coarse-to-fine training, and regularization step. But perhaps that matches with the focus mentioned in the paper "as to what is actually required for high-fidelity scene reconstruction". Given the similarities, though, I was wondering if you did compare PSNR values against Plenoxes?

Hi, no worries.
Indeed, ReLUFields share a lot in common with Plenoxels, but being a concurrent work, formal comparisons weren't included the paper. However, with the (not-so-formal) experiments I did, Plenoxels seem to have 2-3 dB higher PSNR on all scenes, because in their default setting, they use a spatially-adaptive grid (data-structure). And, also at a much higher resolution than the experiments we did (I think 512^3).

Hey,  I am closing this issue due to inactivity. Please feel free to reopen this.


[DOC] Fix docstrings

Overview of functionality with missing/insufficient docstrings

[ ] PolynomialTrendForecaster
[ ] DirectRegressionForecaster
[ ] DirectTimeSeriesRegressionForecaster
[ ] RecursiveRegressionForecaster
[ ] RecursiveTimeSeriesRegressionForecaster
[ ] ForecastingGridSearchCV
[ ] FittedParamExtractor
[ ] Detrender

I will add docstrings to these functions/classes

@mloning Working on documenting the forecasting.trend.PolynomialTrendForecaster.

I noticed the fit() function has an input parameter "alpha" that is never used by the function nor class. Is it alright if I remove this parameter?
The fit() function has the input parameter "return_pred_int=False"; the option for "return_pred_int=True" has not been implemented. I assume that if return_pred_int=True, then the value returned will be of type integer, not series, correct? Should be simple to code. Any issues with implementing this?

@lynnssi it's actually an option to return prediction intervals rather than point predictions. Some forecasters already implement it, for example the ThetaForecaster, you can see what it looks like in the forecasting tutorial notebook

Closed by #357


Help icon cropped (a bit on the right side)

Describe the bug
Right side of the help icon is cropped a little bit.

Component
SDC library
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
It should not cropped.
Screenshots
If applicable, add screenshots to help explain your problem.
Smartphone (please complete the following information):

Device: [e.g. Pixel4a emulator]
Android version: [e.g. Settings -> About phone -> Android version]
Build number: [e.g. Settings -> About phone -> Build number]
Version [e.g. 22]

Additional context
Add any other context about the problem here.
Would you like to work on the issue?
N/A

@shelaghm @f-odhiambo
good first issue

@khyativyasargus
Are you working on a UX issue where the alignment of the help icon changes?

@khyativyasargus Are you working on a UX issue where the alignment of the help icon changes?

No @santosh-pingle I think that PR is on hold for now as @jingtang10  was supposed to think about Image style configuration while using as Image Span. but yes I already had suggestions on that PR to fix this icon crop issue.
https://github.com/google/android-fhir/pull/1984#issuecomment-1525802880
https://github.com/google/android-fhir/pull/1984#issuecomment-1641718831


Injectable SiteContext (fixes #285)

With this PR SiteContext is now provided by the MEF container, so it's injectable into any plugin.
That was the simplest solution I could think of to enable #285
@laedit What do you think?

Thanks a lot for the PR, but I'm really not comfortable with the export of SiteContext.
I prefer that each plugin has acces only to the parts they need, not the all SiteContext.
And the SiteContextGenerator lost all his purpose.
If you can wait until sunday, I will propose a PR which export only the configuration, is that ok?

Ok, I'm fine with it. Looking forward for your solution :wink:


Question: How would I set up LSP highlighting with Coc?

Hey @RRethy
Is it possible to set up vim-illuminate to work with Coc for LSP highlighting?
Would you know how to do that by any chance?

It would require a non-trivial amount of code to be added to use coc's API which would also be in js. This isn't something I would add or even want someone else to add (since maintaining it would be annoying). You can however try https://github.com/neoclide/coc-highlight which does jus that.


Append path segment

Consumer is able to construct file/directory path through the builder.
Rename the directoryPath and filePath to absolutePath when addressed the issue.

Fixed in #5136


Tensorflow installation issues

Issue type
Build/Install
Have you reproduced the bug with TensorFlow Nightly?
No
Source
source
TensorFlow version
tensorflow_intel-2.18.0-cp312-cp312-win_amd64.whl
Custom code
Yes
OS platform and distribution
Windows 11 Home
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
4060 Laptop
Current behavior?
I originally wanted to install the tensorflow-gpu version, but why does it always download the intel version when I use "pip install tensorflow"? There are no problems with my cuda and cudnn. How can I solve this problem?

Standalone code to reproduce the issue
pip install --upgrade tensorflow

Relevant log output
ages (from markdown-it-py>=2.2.0->rich->keras>=3.5.0->tensorflow-intel==2.18.0->tensorflow) (0.1.2)
Using cached tensorflow-2.18.0-cp312-cp312-win_amd64.whl (7.5 kB)
Using cached tensorflow_intel-2.18.0-cp312-cp312-win_amd64.whl (390.3 MB)

@iwqculrbud,
Could you please provide more information/context and also steps followed to install & the error log which helps to debug the issue in an effective way. Thank you!

@iwqculrbud, Could you please provide more information/context and also steps followed to install & the error log which helps to debug the issue in an effective way. Thank you!

No problem, I have an intel i5-12500H and an Nvidia 4060 laptop on my device, but when I used pip to install it, I found that it seemed to install the intel optimized version (as shown in the picture), I want to install tensorflow optimized for nvidia.
Is there any tensorflow optimized for nvidia graphics cards?


Fix type exports

This fixes typescript error TS7016:

Could not find a declaration file for module 'aes-cmac'<EMAIL_ADDRESS>implicitly has an 'any' type.
There are types at '/projectDir/node_modules/aes-cmac/lib/aes-cmac.d.ts', but this result could not be resolved when respecting package.json "exports". The 'aes-cmac' library may need to update its package.json or typings. ts(7016)

Thanks for the PR, @lvogt! Would you be able to provide a minimal example that reproduces the issue? I’ll add it to the test set.

ts-7016-issue.zip
Hi this seems to be more or less as minimal as it gets. VSCode already highlights the issue and calling npm run compile (or npm exec tsc) also emits the error.

@lvogt thanks again, this is released in v3.1.0


add magnet: protocol handler

We can actually intercept clicks on magnet: links and direct them to https://instant.io!
https://developer.mozilla.org/en-US/docs/Web-based_protocol_handlers
Why didn't I think of this before?

This is live on instant.io now!

Does that mean that clicking on the "[Magnet URI]" link on instant.io should start a new tab with instant.io downloading that magnet ?
Doesn't seem to work here (chrome 43)

@rom1504 You have to click the little icon on the address bar to enable it:

In Firefox, you click the "+" icon in the search bar:

Yeah I just saw that !
In firefox it actually also ask it with a small banner under the address bar.

Right!


feat: Add CARGO_RUSTC_CURRENT_DIR (unstable)

What does this PR try to resolve?
This is an alternative to #12158's CARGO_WORKSPACE_DIR that was
implementing the solution to #3946 that previously discussed in the
cargo team meeting.
CARGO_WORKSPACE_DIR is a bit awkward to document / describe because
its the effective workspace directory of the thing being built.
If the thing being built doesn't have a workspace, it falls back to
CARGO_MANIFEST_DIR.
It would also be hard to take into account what the
CARGO_WORKSPACE_DIR would be for path dependencies into foreign
workspaces and it wouldn't solve the problem the user is having.

This is much simpler to describe and is accurate when using a path
dependency to a foreign package.
Because the CWD is a much simpler mechanism to talk about, I figured we
could diverge from our prior consensus and make it always present,
rather than limiting it to tests.
How should we test and review this PR?
The preparatory refactor commits have explanation for why they were to help
Additional information
Remaining work for #3946: get this stabilized

I don't quite agree. People might just want to get the workspace root to do some tricks like generating code for other members. Granted this might seem like a "misuse" of build script but that is already a thing.

A previous iteration of the cargo team rejected that use case.  When  we met to discuss the problem, we intentionally designed the solution to exclude that use case, only allowing it for benches and tests.  We also made it relative to communicate its wibbly wobbly nature.

The proposed CARGO_RUSTC_CURRENT_DIR sounds harder to find and educate as well.

Note that I'm not talking about documenting a fully generic CARGO_WORKSPACE_DIR but specifically what we discussed to stabilize: https://github.com/rust-lang/cargo/issues/3946#issuecomment-1402464796

Only for test and bin (does that include unit tests?  doc tests)
If a member of the primary workspace, we use the workspace path.  For registry dependencies, it is the manifesr dir.

But when it comes to path dependencies on foreign workspaces...

Its a relative path

But really what we are trying to assist the user with is resolving file!.  They are assuming the workspace dir is what they need but what they actually care about is the current_dir for rustc.

I don't think an FCP is needed, but the env name might worth bikdshedding? don't have a better idea though. CARGO_RUSTC_INVOKED_DIR sounds even more confusing.

I figure we'd do an FCP on stabilization and can worry about the name then.  I'd be curious to get this in a nightly for feedback from requesters.

Thank you. All make sense as this is an nightly-only feature.
@bors r+

:pushpin: Commit e81d84cc17d7df6a249e60cbc620f25edbe782db has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit e81d84cc17d7df6a249e60cbc620f25edbe782db with merge 9b13310ca596020a737aaa47daa4ed9ff8898a2f...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 9b13310ca596020a737aaa47daa4ed9ff8898a2f to master...


Make Number Variant of Styled Component

I want to make a number variant of the styled component as I have a unique scenario that is giving me weird padding issues and I see a way around it and am unsure if at least at this time if this needs to apply to all styledcomponents or for example for a number component variant but see the attached screenshot

the styledcomponent fits to the doubledigit no problem but we need it to autosize to the single digit and back to doubledigit so it looks a bit cleaner will do that in number variant I believe will update this to confirm think this should be before .8

done we got a variant for this now use usesplitbutton for this little different then original design but its good to go


Random golang memory corruption on all supported architectures.

What version of Go are you using (go version)?
go version go1.9.2 linux/amd64
go 1.10 rc1
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/tmp/godero2"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build165738707=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
Bug affects all golang supported architectures.
What did you do?
It looks some undefined, uninitialized memory address is affecting the normal execution of the program. At first place program should not even get compiled.
See below for more details.
Bug can be reproduced by compiling following:
https://github.com/deroproject/derosuite/tree/master/cmd/derod
Pls see more details below:
https://github.com/deroproject/derosuite/blob/995d27eec249c7b3d908ebcf28af1449184c6cbf/crypto/ringct/mlsag.go#L161
If possible, provide a recipe for reproducing the error.
Comment Line no. 179  https://github.com/deroproject/derosuite/blob/995d27eec249c7b3d908ebcf28af1449184c6cbf/crypto/ringct/mlsag.go#L179
And
Uncomment Line no. 183 https://github.com/deroproject/derosuite/blob/995d27eec249c7b3d908ebcf28af1449184c6cbf/crypto/ringct/mlsag.go#L183
What did you expect to see?
Crypto checksums should get verified without any errors.
What did you see instead?
Crypto checksums starts failing randomly.

This looks like memory corruption. Have you tried running your program under the race detector? See https://blog.golang.org/race-detector .

If a compiler is using undeclared variable ,the bug does not fall in category of memory corruption. In this case compiler is using undeclared variable and thus the code should not even compile.

Can you please provide small self contained example of the compiler using an undeclared variable.  Thanks.

I would have already submitted here but Its not easy to create a simple test case for this case.

I don’t understand what you mean by an undeclared variable. Could you possibly write a small program in the playground to show this, it doesn’t need to reproduce the bug your demonstrated here.
Can you also try passing -gcflags=“-l -N” to disable optimisations and see if that affects the outcome.

The race detector barks at your project. I'm using $ go run -race main.go at  derosuite/cmd/derod.
WARNING: DATA RACE
Read at 0x00c42017a250 by goroutine 17:
  main.main.func1()
      /home/adonizetti/gocode/src/github.com/deroproject/derosuite/blockchain/blockchain.go:181 +0xe9

Previous write at 0x00c42017a250 by goroutine 13:
  github.com/deroproject/derosuite/blockchain.(*Blockchain).Add_Complete_Block()
      /home/adonizetti/gocode/src/github.com/deroproject/derosuite/blockchain/blockchain.go:469 +0xd9c
  github.com/deroproject/derosuite/p2p.Handle_BC_Notify_Response_GetObjects()
      /home/adonizetti/gocode/src/github.com/deroproject/derosuite/p2p/bc_notify_response_get_objects.go:146 +0xd9a
  github.com/deroproject/derosuite/p2p.Handle_Connection()
      /home/adonizetti/gocode/src/github.com/deroproject/derosuite/p2p/levin.go:245 +0x1099
  github.com/deroproject/derosuite/p2p.P2P_engine()
      /home/adonizetti/gocode/src/github.com/deroproject/derosuite/p2p/controller.go:95 +0x737

Goroutine 17 (running) created at:
  main.main()
      /home/adonizetti/gocode/src/github.com/deroproject/derosuite/cmd/derod/main.go:118 +0xb9a

Goroutine 13 (running) created at:
  github.com/deroproject/derosuite/p2p.P2P_Init()
      /home/adonizetti/gocode/src/github.com/deroproject/derosuite/p2p/controller.go:38 +0x1db
  main.main()
      /home/adonizetti/gocode/src/github.com/deroproject/derosuite/cmd/derod/main.go:113 +0xb4a
==================

and several others.

It is also not true that the compiler is using undeclared variables. You wrote in the comment you linked:

if the variables are declared within first loop, second loop is able to access them without declaring them

If you comment line 179 here, the code in the second loop, at line 195, will start using variable L as declared in const.go, line 25. The L declaration outside the loops is shadowing the already-declared L in const.go.

Thanks for pointing out the mistake.


feat: support custom dependency scopes specified outside of Xpresso

@florimondmanca does this reflect your use case from #96?
I think this works but is pretty unergonomic. There's a lot of footguns:

Making sure the same scope is used for the dependency everywhere. Probably can be alleviated by using type aliases (FooDep = Annotated[Foo, Depends(scope=...)].
The way I set it up the Foo instance is cached in the "global" scope because di recognizes the dependency based on it's call parameter (in this case the class Foo). This brakes if you use a lambda to bind (lambda: some_foo_instance != Foo).

Any suggestions are welcome 😄

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@576ce20). Click here to learn what that means.
The diff coverage is 100.00%.

:exclamation: Current head 0d3c122 differs from pull request most recent head cb4bcd3. Consider uploading reports for the commit cb4bcd3 to get more accurate results

@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage        ?   98.53%
=======================================
  Files           ?      126
  Lines           ?     4245
  Branches        ?      597
=======================================
  Hits            ?     4183
  Misses          ?       30
  Partials        ?       32

Impacted Files
Coverage Δ

xpresso/routing/operation.py
100.00% <ø> (ø)

xpresso/routing/websockets.py
92.59% <ø> (ø)

...sts/test_dependencies/test_dependency_injection.py
100.00% <100.00%> (ø)

xpresso/applications.py
96.06% <100.00%> (ø)

@adriangb Hi! I must say I'm not sure I can make an informed comment on this, as I'm not sure I really understand di's notion of scopes. Also, as I wrote in a late comment on #96, my use case would currently be satisfied, since I prefer / get away with the non-type-annotated DI style. Xpresso's DI works for web components and that's very much enough.
Though, the example shown in the test looks like it would allow me to use type hints as a DI mechanism in the web part. But the fact that it induces coupling by requiring passing the scope everywhere we need the dependency does seem like a smell.
I actually view things as two separate systems. In DDD terms, I've got my domain/application layer where I do DI with one container - be it with type hints or a resolve() function style. And then there's the web layer which belongs to the infrastructure and that's got its own container for handling web stuff. Regardless of the style, it seems like it is better that these two containers be separate anyway. This sparks a range of questions when using an approach like di's (DAG, multiple scopes, etc), as we're seeing here, whereas punq's approach keeps things much more approachable to me.


scope in webpack bundle

Hi I am new to webpack I have this problem with setting up react-js scope.
as an entry point I use route.js which is plain js and I use (crossroads, hasher, signals) in it for routing my web. I want to create react component depending on the url from route.js (without the routing looks something like this). btw: I call my Route.init() from index.html footer.
require('../../less/main.less');
import React from 'react';
import ReactDOM from 'react-dom';
require('./../react-js/main.jsx');
var Route = window.Route = {
    init: function(){
        ReactDOM.render(
            ,
            document.getElementById('routeContent')
        );
)

i have react components for example  main.jsx :
import React from 'react';
var Main  = React.createClass({
render(){
        return (

it works

        )
    }
});

I also use webpack: webpack.config :
var webpack = require('webpack');
var ExtactTextPlugin = require('extract-text-webpack-plugin');
var autoprefix = '{browsers:["Android 2.3", "Android >= 4", "Chrome >= 20", "Firefox >= 24", "Explorer >= 8", "iOS >= 6", "Opera >= 12", "Safari >= 6"]}';
var cssLoaders = ['css-loader', 'autoprefixer-loader?'+autoprefix];
var lessLoaders = cssLoaders.slice(0);
lessLoaders.push('less-loader');
module.exports = {
	entry: {
		app: './src/js/route.js',
		routing: ['crossroads', 'hasher'],
		highcharts: ['highcharts', 'highcharts/modules/exporting'],
	},
	output: {
		path: './bin',
		filename: '[name].bundle.js'
	},
	module: {
		loaders: [
			{
				test: /\.(js|jsx)$/,
				loader: 'babel',
				exclude: /node_modules/,
				query: {
					presets: ['es2015','react']
				}
			},
        	{
        		test: /\.(png|jpg)$/,
        		loader: 'url-loader?limit=20000'
        	},
      		{
      			test: /\.less$/,
      			loader: ExtactTextPlugin.extract('style-loader', lessLoaders.join('!'))
      		},
		]
	},
	plugins: [
		new ExtactTextPlugin('index.css'),
		new webpack.ProvidePlugin({
    		$: "jquery",
    		jQuery: "jquery",
    		'window.jQuery': 'jquery',
		}),
	]
};

MY index.html
<!DOCTYPE html>

        <meta charset="utf-8">
        <link rel="stylesheet" href="/bin/index.css">

MY PROBLEM IS that I get an error that 'Main' is not defined, when i render react.component from route.js... if I use :
var Main  = window.Main = React.createClass({
all is good and working, but I am not sure if it is correct to use global scope. (window)

Look up exports-loader.
Feel free to re-open at Stack Overflow.


redo: Init at 1.2

Motivation for this change
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Redo is an alternative for Make. This package is a C++ implementation
of redo.

Thank you


[native_toolchain_c] Publish 0.5.0

coverage: 91.792%. remained the same
when pulling d3c4bc0d02653b2f62f23e16072120283d8dccc7 on publish-2
into e16d809c83b3545ec0535d25e23423ec0b861295 on main.

coverage: 91.792%. remained the same
when pulling c6a834cd569e5a964891c7b1b94632c93e473f97 on publish-2
into e16d809c83b3545ec0535d25e23423ec0b861295 on main.


ccextractor errors in log.

I am getting the following in the Ripper.log when I attempt to rip a dvd:
MSG:4040,0,1,"Unable to execute external program 'ccextractor' as its path is not set in preferences","Unable to execute external s its path is not set in preferences","ccextractor"
I was about to modify the clone the dockerfile and try to get ccextractor compiled on the image but wanted to make sure there wasn't a better solution out there.

Thats the right way to go forward. You need to forrk this and add the tool.
What are you using it for? If its worthwhile send a PR and ill merge it!

I am  using ripper for backing up our dvd/blueray collection, along with home videos and some audio cds, if that is your question.  My understanding is that ccextractor is required for closed captions, which I would like to include.  I am a little unsure why I am the only one reporting an issue with it.  I will add the compiling in the install script since you already have the build tools installed.

I have solved this in my forked version by adding this line to my settings.conf file (I have purchased a makemkv license, if that matters)
app_ccextractor = "/usr/local/bin/ccextractor"


⚠ Bofrost.at has degraded performance

In e57a95a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 976 ms

Resolved: Bofrost.at performance has improved in 9f104a2.


No Ad to Show (reward video)

Hi, i get an error "No ad to show",
But it was working fine 2 weeks ago. "isTesting=true"
After this error i created a new account and a new advertisement block in admob. But again the same message in the onAdFailLoad
Anyone else having this problem?

Try changing isTest:false, and run app on device to have a look. (But be aware that do not use real ad for testing too many times)
"No Ad to show", just means, the ad server did not find proper for you to show at the time. It's very often situation. If at the time, no advertiser is investing on ad.
As I know, AdMob has very good fill rate, like 95% or higher, but still sometimes no ad filling and maybe lower in some countries. Some other ad network has much lower fill rate, like 75% or even 50%.

I switched to a interstitial..brought it to production. it worked all day but now the same error. Is there a way to reduce the error.

Oh the error in the rewardvideo persists when istesting=false. Also left A remark at admob site. Because i agree the plugin should work.

No Ad to show, is not a real error. It's just the system happen to fail find proper ad resource for you. No ad network, even AdMob, cannot guarantee 100% fill rate.
Again, use test ad to test. Do not test with real ad on your own device. Google smart system may detect as a cheat behavior. If your app & admob works fine with test ad, then the plugin, SDK and integration is okay and ready to work.


Two Submissions on Clearance

@rbharath @miaecle This PR is for two submissions (random forest + ECFP & GCN + GC) on Clearance.
Also, it seems that the dataset is small and the labels can have a very different scale, e.g. 0.xx to 22. As a result, the RMSE values are pretty large. See if this is expected. @peastman

Also, it seems that the dataset is small and the labels can have a very different scale, e.g. 0.xx to 22. As a result, the RMSE values are pretty large.

I'm not too familiar with this dataset.  That does make sense.  Perhaps a different metric would be more appropriate?

Also, it seems that the dataset is small and the labels can have a very different scale, e.g. 0.xx to 22. As a result, the RMSE values are pretty large.

I'm not too familiar with this dataset.  That does make sense.  Perhaps a different metric would be more appropriate?

Also, it seems that the dataset is small and the labels can have a very different scale, e.g. 0.xx to 22. As a result, the RMSE values are pretty large.

I'm not too familiar with this dataset. That does make sense. Perhaps a different metric would be more appropriate?

What's the source of the dataset? Have anyone used this before?

Also, it seems that the dataset is small and the labels can have a very different scale, e.g. 0.xx to 22. As a result, the RMSE values are pretty large.

I'm not too familiar with this dataset. That does make sense. Perhaps a different metric would be more appropriate?

What's the source of the dataset? Have anyone used this before?

Sorry for the slow response! Lost track of this PR in my inbox. It looks like we added the clearance dataset in https://github.com/deepchem/deepchem/pull/484 but we don't have the dataset listed in the original 17 datasets in MoleculeNet v1 for some readon. @miaecle would you happen to remember why we didn't add clearance to the moleculenet v1 datasets?
As a couple of thoughts, perhaps we should log-transform the output? We do this for some regression outputs in which there's a large range of outputs. In that case, the RMS on the logarithmic scale might be meaningful. Another option is swapping to R^2. I'm pretty open to swapping to either given that we didn't include Clearance in v1 so this won't break any existing benchmark standard

Sorry for the slow response! Lost track of this PR in my inbox. It looks like we added the clearance dataset in https://github.com/deepchem/deepchem/pull/484 but we don't have the dataset listed in the original 17 datasets in MoleculeNet v1 for some readon. @miaecle would you happen to remember why we didn't add clearance to the moleculenet v1 datasets?
As a couple of thoughts, perhaps we should log-transform the output? We do this for some regression outputs in which there's a large range of outputs. In that case, the RMS on the logarithmic scale might be meaningful. Another option is swapping to R^2. I'm pretty open to swapping to either given that we didn't include Clearance in v1 so this won't break any existing benchmark standard

@mufeili @rbharath Sorry I didn't quite remember why/if it is included in the initial version of benchmark. As of metrics I agree with Bharath on log-transforming. Depending on how the label distribution looks like, R2 could also suffer from outliers (assuming those with label~22 are quite rare).

@mufeili @rbharath Sorry I didn't quite remember why/if it is included in the initial version of benchmark. As of metrics I agree with Bharath on log-transforming. Depending on how the label distribution looks like, R2 could also suffer from outliers (assuming those with label~22 are quite rare).


Rework dynamic compilation to use Roslyn-backed type resolution

This is a complete rework of the type performed during dynamic compilation. It follows the following process with some optimisations in-between, which I hope to have documented in a somewhat readable way in code:

Map all types to the types which they reference.
Build a directed graph from the changed file towards the test scene type by following the map generated in (1).
Find all files corresponding to the types by following the graph in (2) by-parent.

Performance wise this is slightly slower on first initialisation (building the map in step (1)), but further changes are about as quick as they were previously. Step (1) could could probably be done in the background rather than on change, but I haven't done that in this PR.
Scenarios I've tested:

Changing AnimationClockComposite while in TestSceneAnimation.
Changing Video while in TestSceneAnimation.
Changing Video while in TestSceneVideo.
Changing Menu while in TestSceneNestedMenus.
Changing TabItem<T> while in TestSceneTabControl.
osu!-side: Changing LegacyDrumRoll while in TestSceneDrawableDrumRoll.

All with RequiredTypes removed.
I haven't removed RequiredTypes in this PR since it touches quite a lot of files. That can be done in a separate PR.

Regarding the newly-added Todo:, I've kept the original assembly resolution code, but plan to update that in the future too. Roslyn can be queried for the metadata references to so, but it's not causing huge problems right now.

Just noticed a slight issue with this one, documenting for now.
Suppose the type hierarchy:
A
  -> B
    -> C

Recompiling C generates A'B'C', but then recompiling B generates A'B'C (where ' indicates types existing in the dynamic assembly).
Likely path of resolution is to store the files that were changed through an entire testscene's lifetime and always recompile those.

Does ExcludeFromDynamicCompile break the inclusion chain?

From only that type, yes. So when attached to TestBrowser it’ll stop inclusion of TestBrowser and the toolbars it references, but if the toolbars are referenced by the test or another component not marked for exclusion they’ll still get be included.


Support for Post Kinds (aka map post types to activity verbs)

It would be nice if we could map the post types with the corresponding activity verbs especially when I have the Post Kinds plugin installed.
Say, I read a book and use the read post type, it would be nice if the AS shows me as reading the book. And there are several other post types that could be mapped to the other AS activity verbs.
(Originally published at: https://xavierroy.com/b/21h)

Definitely. My site, for instance, makes heavy use of post kinds.


Duplicate add-on ID for mediasetplayer

We got a report about a user who keeps getting this error :
jpm sign --api-key=user:10822560:122 --api-secret=... --xpi=mediasetplayer-1.2.13396-mingw-w32.xpi
JPM [info] Signing XPI: mediasetplayer-1.2.13396-mingw-w32.xpi
JPM [error] Server response: Duplicate add-on ID found. ( status: 400 )
JPM [info] FAIL

They have uploaded a couple different versions and it appears some have differing platform files.

I am getting this same error with all my addons, after deleting old versions from the site:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>Error with DPRMyanmar.xpi
100% complete · 22.58 MB of 22.58 MB
Your add-on failed validation with 1 error.
Duplicate add-on ID found.

I am getting this same error with all my addons, after deleting old versions from the site:

This isssue is about something else. Please send an email to amo-admins AT mozilla DOT org.

Closing based on request to email amo-admins.

@andymckay This is still a valid issue, which needs to be investigated. Only https://github.com/mozilla/olympia/issues/1112#issuecomment-165978900 was misplaced.

I'm also getting the Duplicate add-on ID message, yet the same xpi file will upload just fine via the Browser interface.

hmm, if jpm is detecting the version wrong then this might be the same bug as https://github.com/mozilla-jetpack/jpm/issues/450 . Could you attach a copy of the XPI file you saw the 'duplicate ID' message for?

Same issue for me here. I submitted an XPI, then deleted the submission, then tried to submit the same XPI and it resulted in "Duplicate add-on ID found" during validation.

Same issue for me here. I submitted an XPI, then deleted the submission,
then tried to submit the same XPI and it resulted in "Duplicate add-on ID
found" during validation.

That is not what this issue is about. Deleting your ID results in it being
added to a submission block list to avoid hostile takeover. Please send an
email to amo-admins AT mozilla DOT org and mention your add-on ID.

I may have found the root cause (or at least my root cause).  My add-on didn't have a package.json file, without it uploading via the Web Page works just fine but without it you get the Duplicate-ID problem.  Add the file (with appropriate values) and it works just fine.

Simple question, where do I find the addon ID to submit it to their email.
Bug report  - I used submit for signing only signing beta - then I couldn't edit the addon to listed. So I deleted it and am trying without that option checked, as I'd like to list the addon now.
But this is preventing me from doing it.

The add-on ID is in the install.rdf file.

This was fixed in https://github.com/mozilla-jetpack/jpm/issues/465


Address ActionList.Group heading semantics

As a part of https://github.com/github/accessibility-audits/issues/2939
Remediation accessibility issues in ActionList.Group  heading semantics (follow PVC semantics as it is been reviewed by accessibility)
React Code
<ActionList selectionVariant="multiple">
  <ActionList.Group title="Visible fields">
    <ActionList.Item>Option 1</ActionList.Item>
    <ActionList.Item>Option 2</ActionList.Item>
  </ActionList.Group>
  <ActionList.Group title="Hidden fields">
    <ActionList.Item>Option 3</ActionList.Item>
    <ActionList.Item>Option 4</ActionList.Item>
  </ActionList.Group>
</ActionList>

Only difference in this PR is the heading.

Removing role="presentation"  and aria-hidden="true" and rendering the heading item as a heading not span.

Semantics before

  // outer wrapper

 // group 1 (Visible Fields)

 👈🏻  This changed
	  Visible Fields 👈🏻  This changed

....action list items....

 // group 2 (Hidden Fields) - identical to group 1

Semantics after

  // outer wrapper

 // group 1 (Visible Fields)

 👈🏻  New update

Visible Fields
 👈🏻  New update

....action list items....

 // group 2 (Hidden Fields) - identical to group 1

Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist

[x] Added/updated tests
[ ] Added/updated documentation
[x] Changes are SSR compatible
[x] Tested in Chrome
[ ] Tested in Firefox
[ ] Tested in Safari
[ ] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@siddharthkp - No worries! It is actually a topic today for our call 😊 I'd like to chat with you about the next steps


update packages

:white_check_mark: Build TheIdServer 2.1.1-fix-dependencies1-0075 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/5fe1768f5d by @)


Discussion

Hi,
I love the flexibility zend-expressive-router has brought into the routing world. But on the other hand it introduces / remove some of the features of each router which brings some problems also.
Eg :
We cannot quickly move from FastRoute to AuraRouter and vice versa. The problem is due to the path can accept regular expression for FastRoute , but not for Aura. This is actually good for FastRoute, but Aura.Router missed some features we could make use of. I believe this is true for any router which can be configured other than via the path.
A recent example is
$router->add('aura.asset', '/asset/{vendor}/{package}/{file}')
    ->setValues([
        'action' => 'aura.asset',
    ])
    ->addTokens(array(
        'file' => '(.*)'
    ));

which can be written in FastRoute as /asset/{vendor}/{package}/{file:.*} . So I guess there need a parser also.

@harikt I think this is going to be the case for any "mostly-interchangeable" component. You can't move from FastRoute to AuraRouter "quickly", but you will also have challenges moving between Aura.Di, Zend ServiceManager, and Pimple. The same goes for Twig/Plates/zend-view, or any similar component for that matter.
The objective of the Zend Expressive routing integrations is to allow you to choose to use your favorite router from the choices we offer and take advantage of its capabilities, but not necessarily to make all of the routers work the same.
If AuraRouter doesn't support routing via regex, that's functionality that should be implemented either in AuraRouter or via some kind of plugin library that will turn regex configured routes into something that AuraRouter can understand. In either case, that's something that could be used by Expressive, but not written as part of Expressive.
Is that about right @weierophinney, or do you want to add anything?

@michaelmoussa you are correct. But I was thinking if the Zend\Expressive\Route have some features it may be useful for https://github.com/zendframework/zend-expressive-aurarouter , https://github.com/zendframework/zend-expressive-fastrouter etc to switch.
So people can consider writing as
new Route('/', ...)

Thank you

I'm not sure I understand. (but I want to!) Can you you give me an example?
You can provide additional configuration options to each route, which the router bridges can use like this.
So looking at your example in your first comment, this:
$router->add('aura.asset', '/asset/{vendor}/{package}/{file}')
    ->setValues([
        'action' => 'aura.asset',
    ])
    ->addTokens(array(
        'file' => '(.*)'
    ));

could be represented as a Route in the form below (not tested):
$route = new Route(
    '/asset/{vendor}/{package}/{file}',
    <... some middleware ...>,
    Route::HTTP_METHOD_ANY,
    'aura.asset'
);
$route->setOptions([
    'values' => ['action' => 'aura.asset'],
    'tokens' => 'file' => '(.*)'
]);

If you wanted to switch to FastRoute, the exact route code above wouldn't work obviously since FastRoute won't know what to do with values or tokens in the options, but in the case of FastRoute you can just use a regex.
So yes, there is some effort required in changing from one routing library to another, but that's unavoidable. If you have any more specific suggestions on what we could do to make that easier without making Zend\Expressive\Router\Route need to know too much about which specific routing libraries are being used, then we can go from there.
At this time though, I don't think that completely switching from one routing mechanism to another in a mature application is a common enough use case that the tools we have available right now would make it unreasonably difficult to do so.

I agree with your comments @michaelmoussa . It will be hard / not worth to implement . Else we probably need a common way for path how it could be defined.
Thanks for your time. I appreciate you looking into this.

No problem. Glad to help!

To clarify this a bit more: the routers their selves take care of handling the routes. It's given the config through zend-expressive-router. However zend-expressive-router cannot magically add functionality from zend-router to aura-router. The only exception is zend-router-fastroute which handles route generation since FastRoute itself doesn't do this.
Same goes for the containers. zend-servicemanager is a lot more powerful than the other containers. However in that case the config for zend-servicemanager was chosen and with some tricks in the ./config/config.php (from the skeleton) the main parts of the container config (factories and invokables) are translated for the other containers. But features like the abstract factory can not be added magically to the other containers.
The best example I can give you is with template renderers. They all are completely different and there is no way to interchange these. Because that is basically what you are asking (although for the routes): make the templates from twig, plates and zend-view interchangeable.
I know you might think now that you asked for interchangeable config and not templates, but for the routers the path is what templates are for the renderers. It's their core functionality.
I hope this makes sense and clarifies why it would cause too much overhead, is nearly impossible and (IMHO) not really worth it.
If you want functionality from another router added to your current router, I think the best way to do that is by sending PR's to those routers. The same goes for containers and template renderers.


Read data in excel2016 and receive accuracy loss with QString type. Test data 0.0524 accuracy loss when reading

When reading data in excel, I read the value of 0.0524. No matter what format is set in excel, the data obtained is 5.2400000000000002E-2.
the code is :
QXlsx::Document xlsx("book1.xlsx");
xlsx.selectSheet("test");
qDebug()<<xlsx.read(1,3);

read读过来是一个QVarient，使用to_double() 方法即可转换为double数据

@ lululuhaha
This is a problem with excel, when you open the file for example with 7-zip, you can see in the main xml-sheet, that excel is saving the numbers in maximum 64-bit precision, and sometimes exponential, I don't know why.


kotlin-stdlib jre7 is depricated please use jdk instead

i have got this error while running the prject
I have jdk-8
android studio 3.2 Beta 4
and the latest gradle version
what  i have to do ???????????????

i am using fedora 28 as a main operating system

Hi, @mahmodsallam. This is not an error, just a warning.


Put filename instead of image for script on inspector

I don't know how will be with visual script but for GDScript makes no sense to have a miniature of the code when one only need to know the script file name.
Currently, I have to put the cursor over it and wait a bit for the tooltip to be able to read the file name of the script.
So, I would prefer to have the file name (not full path, just the name) instead of that image on script section (for text based scripts, at least).

I would prefer the name of the script rather than its path (or make it so the name is prioritized, because horizontal space is relatively small in the inspector).

Since this is marked "discussion": I totally agree. Those zoomed-out textual previews never helped me. At least show the first lines in a readable size if you really wanna go for a thumbnail.

Alternatively. make a procedural image for each script?

I'm ok for zoomed-out icons in the file explorer because we see the file name anyways (that's the best you can do IMHO, apart from not showing anything) but in the inspector it's especially inconvenient due to the fact we don't see that name.

Yes, I agree that showing the images of the scripts isn't useful. However #7133 needs to be fixed also or it will still require a mouseover for tooltip in most cases to see the filename.

Implemented on https://github.com/godotengine/godot/pull/8358 and https://github.com/godotengine/godot/pull/8359


Update docs for appveyor badge.

Can now optionally specify the appveyor project_name.
Related PR: rust-lang/crates.io#1111
Related Issue: rust-lang/crates.io#587

@bors: r+
Thanks!

:pushpin: Commit 53012bd has been approved by alexcrichton

:hourglass: Testing commit 53012bd4df83a0d43ce7dfd0175d78b084823477 with merge cf08602d6b2a3c4bce6049ea79570fd31f4a1722...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing cf08602d6b2a3c4bce6049ea79570fd31f4a1722 to master...