A cleaner public API

This issue is a follow-up to things already partially discussed in #13 (3).

I'd prefer a true facade-like public API that does not leak any implementation detail. The current implementation leaks Decompressor::Registry (and related functionality), and in particular also leaks all classes derived from Decompressor. In order for RTTI to work in client code (when ancient is compiled with RTTI (the current Makefile does not, however for best interoperability with client code, a shared library should be)), all classes derived from Decompressor would also need to have public visibility. I do not think this is feasible or desirable. As the currently exposed interface are base classes with a vtable, the size of the vtable becomes part of the ABI. This makes extending these interfaces (which are also used internally) difficult without breaking the ABI.
I do not think Buffer needs to be exposed at all. I think in the public API, std::vectorstd::byte (or std::vector<uint8_t>) is all that is needed. For internal use, this can be wrapped in a Buffer at the API boundary for ease of use.
Is OutOfMemoryError really needed? I think standard C++ std::bad_alloc has exactly the same meaning. OutOfMemoryError can be annoying for client code: Anything in the standard library will already throw std::bad_alloc in case of allocation failure, and ancient will itself throw OutOfMemoryError in the same situation. This means client code would need to always handle both, as ancient internally uses standard library features that throw std::bad_alloc (the obvious one being std::make_unique here).

I am currently working on this and will suggest a pull request when I am done.

I have pushed my work-in-progress implementation to https://github.com/manxorist/ancient/tree/wip-api-facade. This is meant as a base for discussion and not yet as a pull request to be merged.
Also note that this is not yet tested.
This branch also already contains #14 and #15 merged.

Given https://github.com/manxorist/ancient/commit/4fc8a145f77def2c2105dfe9aa1cb9e48034cee9, can we even get completely rid of void decompress(std::vector<uint8_t> &rawData,bool verify); with external allocation in the public interface? Or is there some intended use for such an interface that I am not aware of?


ADR: Rename Incentive level "description" to "name"

Reason: The current values for "description", e.g. "Standard" or "Enhanced" are the names of the Incentive levels, NOT their description.
The new Incentive levels management UI will show levels descriptions describing the level so it makes sense to rename the existing "description" field.
The new "description" fields will be non-Nullable but default to an empty string "".
NOTE: Prison Incentive levels have a field called levelDescription, this has the same meaning and will be renamed as well to levelName (a new levelDescription field will be added but it will have a different meaning)

This ADR update is included in this other PR (merged) which supersede this one. Closing this PR.


Serialization error on interfaces with hidden members in v 7.0.1.

Serialization error on classes implementing the interfaces with hidden members. Similar issue was reported and fixed in earlier versions. Worked in v.6.0.8., apparently the regression in v.7.0.1.
The error message: “A member with the name '[Property Name]' already exists on '[Interface Name]'. Use the JsonPropertyAttribute to specify another name.”
Note that the class in question serializes OK by itself. The error is thrown when such class is a member (or collection member) of another class being serialized.
The example uses JsonConvert.SerializeObject(), the same error occurs for SerializeObject() of JsonSerializer.
Consider the following code:
public interface ISubclassBase
{
int ID { get; set; }
string Name { get; set; }
bool P1 { get; }
}
public interface ISubclass : ISubclassBase
{
new bool P1 { get; set; }
int P2 { get; set; }
}
public interface IMainClass
{
int ID { get; set; }
string Name { get; set; }
ISubclass Subclass { get; set; }
}
public class Subclass : ISubclass
{
public int ID { get; set; }
public string Name { get; set; }
public bool P1 { get; set; }
public int P2 { get; set; }
}
public class MainClass : IMainClass
{
public int ID { get; set; }
public string Name { get; set; }
public ISubclass Subclass { get; set; }
}
public class MyFactory
{
public static ISubclass InstantiateSubclass()
{
return new Subclass
{
ID = 123,
Name = "ABC",
P1 = true,
P2 = 44
};
}
public static IMainClass InstantiateManiClass()
{
return new MainClass
{
ID = 567,
Name = "XYZ",
Subclass = InstantiateSubclass()
};
}
}
public void Test()
{
var mySubclass = MyFactory.InstantiateSubclass();
var myMainClass = MyFactory.InstantiateManiClass();
//Class implementing interface with hidden members - flat object.
//Passes both in 6.0.8 and 7.0.1
var strJsonSubclass = JsonConvert.SerializeObject(mySubclass);
//Class implementing interface with hidden members - member of another class.
//Passes in 6.0.8, fails 7.0.1
var strJsonMainClass = JsonConvert.SerializeObject(myMainClass);
}

We have observed this same issue.  Worked fine in 6.0.8 but after updating this is failing.
It looks like this was an issue in the past as well...
http://stackoverflow.com/questions/9304096/trying-to-hide-base-class-member-during-serialization-with-json-net#comment11736578_9304096

Same problem here :(

Fixed. This will be in the next release. Until then stick with 6.0.8.

I also being struck by this :/
Any news on when the next release is rolled out (since this bug is really bad and it's been about 4 months since the last release)?
EDIT:
Just found a workaround (in my case):
[JsonIgnore], but not in a class but in an interface(!), where a property from a base-interface gets hidden.

It's available in pre-release now: https://www.nuget.org/packages/Newtonsoft.Json/8.0.1-beta1


deprecate open_zarr

This PR deprecates open_zarr in favor of open_dataset(..., engine='zarr').

[x] Closes #7495
[x] Tests added
[x] User visible changes (including notable bug fixes) are documented in whats-new.rst
[x] New functions/methods are listed in api.rst

It would be nice to have a good copy/paste example for open_dataset. For example I think chunks have different defaults compared to open_zarr.

@paigem recently added the following to the open_dataset docstring (https://github.com/pydata/xarray/pull/7438):
In order to reproduce the default behavior of xr.open_zarr(...) use
`xr.open_dataset(..., engine='zarr', chunks={})`.

It is true that Xarray is now becoming very different from pandas in how it opens data.

The inconsistency in the chunks argument is non-ideal, but that could be handled by a separate deprecation process.

There was some discussion on whether xr.open_dataset should default to chunks=None, or switch to open_zarr's chunks="auto" at https://github.com/pydata/xarray/pull/4187#issuecomment-690885702 (the last attempt at deprecating open_zarr :slightly_smiling_face:). Just bringing it up for debate.
Also, quite a few people were in favour of keeping open_zarr back in 2020 (see e.g. https://github.com/pydata/xarray/pull/4187#issuecomment-652482831), but maybe times have changed, and a consistent API is more desirable than convenience?

As a frequent Zarr user I would vote in favor of deprecating open_zarr as it is misleading. It always opens the store as a Dataset, even when it is a DataArray saved using to_zarr (new feature, I know). Looking at the issues, there are inconsistencies between open_zarr and open_dataset, so deprecating seems favorable as it removes the need for extra maintenance to keep both methods behaving in a similar way.

Personal view — I find .open_zarr convenient!

It always opens the store as a Dataset, even when it is a DataArray saved using to_zarr

I agree — though we could fix that, and it's arguably more coherent to use open_zarr than open_dataset given it's not a dataset?

Yeah, we could fix it, but my point is that having two for opening zarr files raises more issues and requires extra work, while the only benefit I can see is a bit shorter syntax.

having two for opening zarr files raises more issues and requires extra work, while the only benefit I can see is a bit shorter syntax.

Yes, definitely agree...
Not sure how to turn that into a decision — maybe "soft-deprecate" .open_zarr? i.e. de-emphasize, remove from main docs, and then reassess whether .open_data{set;array} has taken over in the future.
That worked well for .drop ("wait we have a .drop method?", ideally you would ask).

Not sure how to turn that into a decision — maybe "soft-deprecate" .open_zarr?

Sounds good, maybe also a deprecation warning when calling open_zarr?

I don't have much experience on handling such things, as I'm fairly new to collaborating and maintaining an open source project, but sounds good to me, altough I don't see why we wouldn't want to add the deprecation warning?

although I don't see why we wouldn't want to add the deprecation warning?

The logic is that if we're not confident / don't have consensus on the best final state, we can take a small step without committing to anything, and then make another assessment later with more experience.
By de-emphasizing the function from the docs, we reduce the number of new uses, without causing noisy warnings to show up for folks already it. Then we can assess in the future if we properly depreciate & eventually remove it. Or if the feedback is that the function is useful, we can revert.
Otherwise I worry we're not going to get consensus, and so not going to move forward with making any changes.
(But this is just my idea, I'm one of many, we should do whatever the aggregate view is!)

I see, thank you for explaining. It does sound better, considering that open_zarr is probably used more than the other methods.

Adding a "needs discussion" label — a few things are meandering because of this — https://github.com/pydata/xarray/issues/8095, https://github.com/pydata/xarray/issues/2660 — and so picking a route would let us focus our energy on a path forward for these


Updated prices are not synced in multiplayer

Thanks for this great plugin!
Problem
I saw that you haven't tested the plugin against multiplayer. I tried it today and can confirm that it still works if the person hosting the game has it installed. The prices are not synced to the other players, though.
Solution
I don't know if it's possible but at best the plugin could allow for syncing prices in multiplayer. Manual prices are already synced.
Alternatives
Alternatively, it could be possible to run the plugin on all clients. That's not possible at the moment.
Additional context
Tested with OpenRCT2 0.3.2 on Mac and Ubuntu.

multiplayer functionality would really be great! :)

Check out #111 (and #113 oof) and https://github.com/mgovea/openrct2-ride-price-manager/releases/tag/1.3.0
I didn't test if MP works, but it should. Let me know if we can close.
Also, there's no permissions, so grief wisely. If you have a use case that requires permissions, I might think about doing that... no promises.

it throws an error on my headless server:
[Ride Price Manager] ReferenceError: identifier 'ui' undefined
But everything seems to work fine anyway :) Thank you!

Sweet. I'm calling this done. I did open #113 to investigate your error though.


”Alma” is listed in the drop-down menu

Description:
"Alma" is listed in the drop-down menu alongside its corresponding county and commune, according to the law.
Precondition:
The website is up an running.

Step 1
Type "Alma" in the search bar.

Expected results
The location is listed in the drop-down menu as "Comuna Alma, SIBIU".


sji movie tools

new sji movie tools ready for review

Hi @shelbej.  I had a quick look at your PR.  From the documentation, it looks like the dustbuster function actually overwrites the fits files.  Is this the standard practice is the IRIS team's IDL software?  Either way, I don't think overwriting the downloaded fits files is the best way to go.  Perhaps the dustbuster function should be applied to a MapCube of SJI images.  Or perhaps it could write out a new fits file suffixed by _dustbusted or allow the user to specify a filename so they can overwrite if they really want to.  But I we don't think we should get rid of the original data by default.  Unless this function takes a long time to run, I think it should be a function we apply to data already read into Python.

@Cadair Can you interpret the Delphic oracle that is the Travis documentation build warnings log?  I don't see why it's failing for this PR.

Hi @shelbej.  When I did a peek of the dustbusted mapcube I found that some dust regions remained uncorrected on some frames.  Is this expected?  Is it just an artifact in the animation and not in the maps themselves?  Can you try that you and see if you think it's normal?

@DanRyanIrish were the uncorrected regions in the center of the image or close to the edges? Sometimes it can't find data to fill the holes around the edges.

I ran into an error in dustbuster with different sized maps. Is there a way to crop/resize or remove maps?
if not mc.all_maps_same_shape():
do something that makes mc.all_maps_same_shape() = True

@shelbej just wanting on your fix before merging.


Restore navigation state when flutter activity reconstruct

Doc:
https://docs.flutter.dev/platform-integration/android/restore-state-android

https://github.com/andannn/aniflow/pull/112


better document typeahead template scope

From the typeahead component's documentation it's unclear what variables are actually available in the scope of the typeahead template. Is it always match? Is it controlled by the typeahead attribute ("label for value in sourceArray" or "select as label for value in sourceArray). Can the whole array be accessed or just each particular item?

Closing due to inactivity. Reopen if this is still an issue.

Why was this closed? I agree the documentation is confusing on what variables are available in the template's scope.

+1. Having to do weird workarounds like the one mentioned here seems unfortunate.

+1


feat: cover single-tenant use case

We ourselves run echo server in multitenant mode with a bat cave dependency.
However, we also promote it as having single-tenant functionality. This should be covered by functional tests

This is now part of our testing epic here, #92


git describe

Signed-off-by: Eduardo Lezcano<EMAIL_ADDRESS>

RFC. Nothing fancy yet xD

Indeed! Is more RFC on the feature branch than a production-ready PR. PRs to the branch are also welcome. :)

I was able to replicate the regular output of git describe with minor deviations in the distance calculated by go-git and the distance calculated by git describe.
The algorithm now tries to closely follow the source of git describe.
The performance is an average of 3 times slower than git describe. A good part of the time is expend during the commitIterator, err := r.Log(&LogOptions ... I didn't dig too much on it but apparently r.CommitObject(h) is the slower inside. Of course the majority of the time though goes on the map query, but after trying with several different methods (even with go routines) this is the fastest result I manage to develop.

$ time git describe --tags --debug; time semver
searching to describe HEAD
 lightweight        1 v4.3.1
 lightweight       11 v4.3.0
 lightweight       17 v4.2.1
 lightweight       34 v4.2.0
 lightweight       55 v4.1.1
 lightweight       76 v4.1.0
 lightweight       89 v4.0.0
 lightweight      270 v4.0.0-rc15
 lightweight      281 v4.0.0-rc14
 lightweight      329 v4.0.0-rc13
traversed 392 commits
more than 10 tags found; listed 10 most recent
gave up search at d3c7400c39f86a4c59340c7a9cda8497186e00fc
v4.3.1-1-g6104842

real    0m0.024s
user    0m0.019s
sys     0m0.005s
/home/air15884/go/src/gopkg.in/src-d/go-git.v4
searching to describe refs/heads/736-git-describe
 lightweight        1 v4.3.1
 lightweight       11 v4.3.0
 lightweight       17 v4.2.1
 lightweight       34 v4.2.0
 lightweight       54 v4.1.1
 lightweight       76 v4.1.0
 lightweight       89 v4.0.0
 lightweight      269 v4.0.0-rc15
 lightweight      280 v4.0.0-rc14
 lightweight      329 v4.0.0-rc13
traversed 329 commits
more than 10 tags found; listed 10 most recent
gave up search at 8ddbecf782c2e340fd85bb4ba4d00dc73d749f87
v4.3.1-1-g6104842

real    0m0.062s
user    0m0.062s
sys     0m0.020s

Still some improvements to do and some more options to enable like All, Match and Always.

I was looking at using go-git to fetch tag information using go generate. Are you guys still working on this or is this feature currently abandoned?
(I will just use bash or ldflags to solve my problem for now).

Have there been any updates for this feature? We'd love to use inbuilt library functions; we were thinking about using this workaround.


Opacity in ComponentView is not restruicted to [0.0, 1.0]

Opacity setter is restricted to [0.0, 1.0] but direct property change is not.
Suggest to change DoubleProperty to LimitedDoubleProperty(lb = 0.0, ub = 1.0) to fix this issue.

KDocs for attribute say "must be", for property "should be"


Add intellisense for parameters()

eg. press ctrl+space at the |:
"name": "[parameters(|)]"

This does work, nvm.

Was there a scenario that was confusing and caused you to think this didn't work?  Thx.

I was using the new settings sync feature that I've been working on but forgot it doesn't sync extensions into remotes (was connected to wsl at the time).


feat: Implement archive script

The current base is an exact copy of octoherd/script-delete-repository. This pull request implements the option to archive repositories using PATCH /repos/{owner}/{repo}. If a repository is already archived, the script logs a warning.

@gr2m is this script something you would be interested in? I'm more than happy to move the repo into the @octoherd org.

This is great! We can move it to @octoherd if you prefer, but as long as you add the octoherd-script repository topic, it should be discoverable at https://github.com/topics/octoherd-script
I would love to build our own octoherd website that would list all "official" and community @octoherd script. But yeah, one day maybe :D

I invited you as a collaborator, but afterwards I realized this doesn't make you admin meaning you can't move the repo. I can't move the repo either because I don't have permissions to create a repo in the octoherd org. Maybe best if you just re-create this repo yourself.

I can invite you to @octoherd and you move it then? I can revoke your access if you don't want to co-maintain, but I'm sure @oscard0m would be as happy as me to have you

Sure! Let's add @stefanbuck to the team! 👏🏽

Thank you for this valuable contribution @stefanbuck !


Add router option

Hi @mudler, nice project!
This PR adds possibility to optionally set one of the remote nodes as router / gateway and so allows to reach LAN networks behind the router or even use it as default gateway to forward Internet traffic via it.
In short it adds traditional VPN functional in addition to existing mesh functional.
Examples
edgevpn --address <IP_ADDRESS>/24 --router <IP_ADDRESS>
...

Access LAN network <IP_ADDRESS>/24
$ ip route add <IP_ADDRESS>/24 dev edgevpn0
$ ping -c 1 <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=64 time=7.63 ms

Access Internet (remote node should have configured forwarding and NAT)
# <IP_ADDRESS> is the p2p-circuit address of remote node
# <IP_ADDRESS> is the local router
$ ip route add <IP_ADDRESS> via <IP_ADDRESS>
$ ip route add default dev edgevpn0 metric 1

Hi @dukzcry !
Thank you very much for taking time in implementing this (especially at this time of the year ! :slightly_smiling_face:  ), it looks good overall here, just minor nitpicks that we can solve afterwards

@mudler Thank you!!! Have a good holidays!


Support run subset of performance tests on ok-to-perf

Signed-off-by: Marcos Candeia<EMAIL_ADDRESS>Description
Support run subset of performance tests on ok-to-perf
Issue reference
Please reference the issue this PR will close: #5893
Checklist
Please make sure you've  completed the relevant tasks for this PR, out of the following list:

[ ] Code compiles correctly
[ ] Created/updated tests
[ ] Unit tests passing
[ ] End-to-end tests passing
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
[ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

Definitely cool and useful feature. Sometimes if you just need one perf test, this helps (and it's a greener thing too :) )


rosetta-cli check:data failures

getting duplicated transaction hash error while trying to sync from 50000 to 120010
Error: unable to process blocks: unable to process block: unable to store transaction hash: duplicate transaction hash: duplicate transaction bafy2bzacea5ljsf44bxpfjvekhrjy3tu2sivajg7zeuxk7wvqc6rrps2tmssi found in block 0171a0e4022016e66e66ffe5a99520283fa5fa3a963470163c31db7804f55163cf14e903d7a0:50003: unable to add block to storage 0171a0e4022016e66e66ffe5a99520283fa5fa3a963470163c31db7804f55163cf14e903d7a0:50003: unable to sync to 120010

If I query block 41281, I am getting 7393 duplicated transaction with this hsh bafy2bzacedrjokkpqbvaxza2v65km2lcsq5l6e3wx4j66r66ker5fs4p5orbq. It seems that we are including the same transaction multiple times. But if the 2 transactions are different but are having same transaction hash (message id) then it's a even worse issue. But please do some investigation and fix as needed.
{
    "network_identifier": {
        "blockchain": "Filecoin",
        "network": "{{testnet_network}}"
    },
    "block_identifier": {
        "index": 41281
    }
}

I'll look into it as soon any of our nodes gets synced.
But from the look of it maybe it's related to something on traces, there's no way the proxy deliberately includes the same transaction more that once:
https://github.com/Zondax/rosetta-filecoin-proxy/blob/c301d038f6421073982e8ef993bacda8ce486d7e/rosetta/services/block.go#L203-L202

41281 is the epoch when our first "upgrade" would be computed, which involved a lot of irregular transitions. These transitions don't actually live on chain as any messages, but we provided a way to include them in ExecutionTraces. Sounds like we need to modify the way we include them so that the tx hashes are not duplicated. This should be easy to do, it doesn't impact consensus.

Ok, I will mark the issue as an external dependency. This is something not related to the proxy itself.

@arajasek @jleni 41281 is just an example. There are other blocks that contains dup transactions. For instance 50003 also includes duplicated transactions. I was not able to test every single block though.

Related to https://github.com/filecoin-project/lotus/pull/4350

I'll add some code to avoid including this "fake" transactions, hopefully checking if Msg.Nonce == math.MaxUint64 will be enough?
We also have to make sure that no one uses that nonce in a "real" transaction.

@raynaudoe Lotus changed this (Msg.Nonce == math.MaxUint64) in the PR. This will not work anymore, please check here https://github.com/filecoin-project/lotus/pull/4350


Pre-compute / Cache Recursively & Eliminate Repetitive Computation

yazi --debug output
Yazi
    Version: 0.3.3 (VERGEN_IDEMPOTENT_OUTPUT 2024-09-10)
    Debug  : false
    OS     : linux-x86_64 (unix)

Ya
    Version: 0.3.3 (VERGEN_IDEMPOTENT_OUTPUT 2024-09-10)

Emulator
    Emulator.via_env: ("foot", "")
    Emulator.via_csi: Ok(Foot)
    Emulator.detect : Foot

Adapter
    Adapter.matches: Sixel

Desktop
    XDG_SESSION_TYPE           : Some("wayland")
    WAYLAND_DISPLAY            : Some("wayland-1")
    DISPLAY                    : Some(":0")
    SWAYSOCK                   : None
    HYPRLAND_INSTANCE_SIGNATURE: Some("7c4c402bd7f24241c096d809cc80408a469f15cb_1725955248_86907018")
    WAYFIRE_SOCKET             : None

SSH
    shared.in_ssh_connection: false

WSL
    WSL: false

Variables
    SHELL              : Some("/bin/zsh")
    EDITOR             : Some("nvim")
    VISUAL             : None
    YAZI_FILE_ONE      : None
    YAZI_CONFIG_HOME   : None

Text Opener
    default: Some(Opener { run: "nvim \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block  : Some(Opener { run: "nvim \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })

Multiplexers
    TMUX               : false
    tmux version       : No such file or directory (os error 2)
    ZELLIJ_SESSION_NAME: None
    Zellij version     : No such file or directory (os error 2)

Dependencies
    file             : 5.45
    ueberzugpp       : No such file or directory (os error 2)
    ffmpegthumbnailer: 2.2.2
    magick           : 7.1.1-38
    fzf              : 0.55.0
    fd               : 10.2.0
    rg               : 14.1.0
    chafa            : No such file or directory (os error 2)
    zoxide           : 0.9.4
    7z               : No such file or directory (os error 2)
    7zz              : 24.08
    jq               : 1.7.1

Please describe the problem you're trying to solve
I am on Gentoo Linux and I have a high-end PC (32 threads). I can't browse my external HDD properly using Yazi. Any other file manager is lightning fast.
My HDD is an 8TB, external, slow, USB 3.0 external disk mounted on "/mnt/dir". The directory has more than 500.000 files in a nested structure.
This directory is owned by the one and only current user and is mounted at boot.
The problem is that Yazi can't use the cache properly and there is no way I could find to pre-compute each of the 500.000 files in my HDD without manually traversing and save the data in a cache before opening the file manager. For example, on LF, this HDD is completely cached and I never ever need to do a computation (unless I add a new file). Even then, LF computes things on the fly (when you are on an entry), and it doesn't bother the device unnecessarily (even though this is technically worse).
Yazi tries to compute to find mime-types and create previews when I try to browse; every time from scratch. Since the drive is slow, I at least need to wait for a minute in order to open a video for example. And even if I can open a video; I can't play it properly because of stutters (as there would be unfinished background tasks going on continuously).
At the same time, I have lots of directories and files in that disk and as they are dynamically showing up one by one, I can't see most of my directories and/or files. Therefore, it confuses me. I need to be able to see all of them immediately and I need to be able to read/write without waiting for anything or without spending computational resources unnecessarily.
I have the below setting in "${XDG_CONFIG_HOME}/yazi/yazi.toml":
[preview]
cache_dir = "${XDG_CACHE_HOME}/yazi-1000"

I confirm that this cache directory and its content are created and preserved across reboots.
I guess the cache functionality works for my home directory but not external devices on /mnt. Everytime, I see things like that (see the below image).
To sum up, I have two problems that make me use an alternative file manager whenever I want to access my external device:

There is no way to pre-compute for all files in a device.
Even the already computed part is re-computed again and again; despite having the cache directory inside "${XDG_CACHE_HOME}" instead of /tmp.

Would you be willing to contribute this feature?

[ ] Yes, I'll give it a shot

Describe the solution you'd like

Provide an optional CLI flag in order to recursively traverse all directories and pre-compute & cache: Mime types, directory structure, metadata, image and other previews, so the user won't have to do the computation again and again; especially for bigger and slower disks.

Such as:
$ yazi --cache "/mnt/dir"
Waits for ~10 minutes...
Done

Even without this flag; the cache should always be prioritized. Right now, the modified cache_dir works with "${HOME}". I can open Yazi on my home directory, and there is no computation in the background since I already have the cache. But on my external HDD, even the directories I manually traversed are not saved across multiple instances.

Additional context
No response
Validations

[X] I have searched the existing issues
[X] The latest nightly build of Yazi doesn't already have this feature

From the screenshot, these are mime tasks - it's a fetcher used to retrieve file metadata, so it's unrelated to caching as they're not creating caches at all. In your case, you need the https://github.com/yazi-rs/plugins/tree/main/mime-ext.yazi plugin.
BTW in case you're having issues with pre-caching as well, Yazi offers the ability to completely disable preloads:
# ~/.config/yazi/yazi.toml
[plugin]
preloaders = []

These instructions are already included in the tips, please take a look at https://yazi-rs.github.io/docs/tips#make-yazi-even-faster

@sxyazi
Thanks for the answer.
I had already read the wiki. I simply forgot about that plug-in.
Yes. This makes everything better but my actual request was not that.
I don't want to disable image/video previews. It's the opposite. I need a way to pre-compute everything for the previews. Now, the preview cache works but yet, I don't always browse the same directories. There are tons of them.
Instead I want to be able to pre-compute them because I have 500.000+ files in that hard drive and I don't want to do the computation manually by traversing all directories because Yazi only does the computation for the close proximity which is logical but taxing for these kinds of situations.
A functionality like my below example, would be very cool. Or maybe you can give me an idea in order for me to write a script to traverse directories slowly with Yazi by waiting for all previews to be loaded and cached one by one. Is there a similar way or a possibility?:
$ yazi --cache "/mnt/dir"
Waits for ~10 minutes...
Done

I don't want to disable image/video previews

No, preloaders = [] does not disable image or video previews. It only disables preloading, meaning that files will only start being read and processed when you actually move the cursor over them to preview like other file managers do, instead of loading them as soon as you open the directory.
Note that preloaders and previewers are two different concepts, and previews are disabled only if previewers = [] is set:
https://github.com/sxyazi/yazi/blob/61c0db8630bf48ff3fd3919f736704837f50f7f5/yazi-config/preset/yazi.toml#L95
https://github.com/sxyazi/yazi/blob/61c0db8630bf48ff3fd3919f736704837f50f7f5/yazi-config/preset/yazi.toml#L107

@sxyazi
Oh, thank you. That makes sense. These are different concepts.
What about pre-caching in batch? Is there a native way? Or should I write a script by spawning terminals with Yazi for eacy directory in the target location and simulate key-presses with ydotool in order to traverse every part of a directory?
My main aim is to have the cached image/video previews inside the cache_dir so there won't be any waiting for the computation.

I don't think bulk caching is the best way to solve this problem, given the size of your files, it could take a long time to generate and occupy a lot of space. Plus, you might need to repeat this process regularly to remove invalid caches (for example, when file contents change or files no longer exist) and create new incremental caches based on the updated file tree.
However, if you really need it, I can consider exposing the preload() methods for the image and video preloaders as a Lua API, so you can use a plugin to call it caching these files.


support VS Code

For debugging one open the VS Code Command Palette via Shift + Command + P and then search for
Developer: Toggle Developer Tools

Personal note: this is quite definitely a problem with jupyter_compare_view attaching it's source to a parent that doesn't exist in VSC but is present in Jupyter Lab directly.

+1 for this feature

solved by #41 .


Minimatch patterns do not work as expected in DownloadPipelineArtifact

The patterns argument is described as one or more patterns which "limit which files get downloaded". The docs link to https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/file-matching-patterns?view=azure-devops for examples of how to use.
As a test I have the following
  - task: DownloadPipelineArtifact@2
    inputs:
      targetPath: $(Agent.TempDirectory)/foo
      artifactName: 'myArtifactName'
      patterns: |
        **
        !__tests__/**
        !rush.json

  - script: dir
    workingDirectory: $(Agent.TempDirectory)/foo

The download task logs that it is using the patterns:
Information, Minimatch patterns: [**,!__tests__/**,!rush.json]
However it appears to just ignore the patterns and download the files anyway.
  "Leading ! changes the meaning of an include pattern to exclude. You can include a pattern, exclude a subset of it, and then re-include a subset of that: this is known as an "interleaved" pattern."
It's possible that I'm using patterns incorrectly, but there are very few examples to go on in the linked documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b03d67d0-8738-72e6-dbe7-324c1784d4fc
Version Independent ID: bbb4d774-cd98-3ecb-7ccf-5f49e6f2b425
Content: Download Pipeline Artifacts task - Azure Pipelines
Content Source: docs/pipelines/tasks/utility/download-pipeline-artifact.md
Product: devops
Technology: devops-cicd-tasks
GitHub Login: @vijayma
Microsoft Alias: vijayma

I'm getting the same behavior.  Not sure that it's just a documentation error.  I've tried every combination of supposedly valid minimatch pattern I can think of and everything is still downloaded.

Experiencing the exact same thing.  Followed the "Exclude folder" sample documentation exactly and it doesn't exclude the folder.  Tried with and without inclusion of the artifact name in the path.  Something isn't working correctly here.

@vijayma I'm also seeing the same issue. This should be re-opened.

I am experiencing similar issue at my end. My patterns are defined this way:
itemPattern: |
     retail-amd64/**/*.*
     !retail-amd64/services/**/*.*

The 'services' directory is being downloaded anyway.
Are there any workarounds that I can use? Thanks.

@all -- please consider these resources:

Azure DevOps Services
Azure DevOps on Stack Overflow

@steved0x -- Steve, please look into this issue.

Experiencing same thing. For my case, I want to exclude bin\roslyn folder.
It works if I just specified the exclusion only for the itemPattern
!bin/roslyn/**


Tag new version

The last tag is 80 and the different from master is just documentation and the Go package configuration at the proto files, which I need. It's possible to release a new tag?
https://github.com/spotware/openapi-proto-messages/compare/80...main

A new tag was released and it has this message at the changelog Added Go package name, the problem is, there is a new commit that removes the go package. Any reason for that?

Same issue here, I am asking on PR.
https://github.com/spotware/openapi-proto-messages/pull/14#issuecomment-1583987947

@diegobernardes @baotang2118 Hi! Thank you for bringing our attention to this issue. Note that a new release has been drafted with the Go package option restored.

Thank you very much for quick action.


”Mada”, ”Oprișești”, ”Poiana”, ”Poienița”, ”Roșia” are listed in the drop-down menu

Description:
When user writes ”Mada”, ”Oprișești”, ”Poiana”, ”Poienița”, ”Roșia” the locations appear in the drop-down menu next to the comune and the county witch is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Mada"

Expected results
The location appears in the drop-down menu as "Sat Mada, HUNEDOARA (Balșa)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Oprișești"

Expected results
The location appears in the drop-down menu as "Sat Oprișești, HUNEDOARA (Balșa)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Poiana"

Expected results
The location appears in the drop-down menu as "Sat Poiana, HUNEDOARA (Balșa)".

Step 6
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 7
Write in the search bar "Poienița"

Expected results
The location appears in the drop-down menu as "Sat Poienița, HUNEDOARA (Balșa)".

Step 8
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 9
Write in the search bar "Roșia"

Expected results
The location appears in the drop-down menu as "Sat Roșia, HUNEDOARA (Balșa)".


RGB and Optical Flow Resolutions

Hi, I want to test some RGB Optical Flow models on DSEC. How should I map 1440x1080 images to 640x480 Optical Flows?

The easiest way is to map the images from the left video camera to the left event camera. There are two approaches:

You map the images by assuming that the baseline between the cameras is negligible for which you can use the code provided in the related issue: https://github.com/uzh-rpg/DSEC/issues/25 . One issue is that it will be less accurate for parts of the scene that are close to the cameras. On the other hand, it is very fast to compute.
You use a SOTA stereo method on the frame or event camera stereo pair and use this more accurate depth to map the images to the left event camera. This is more cumbersome but also more accurate.

Let me know if this answers your question

Thanks a lot! At first I've tried to resize the images directly from 1440x1080 to 640x480. I'll try to use these approaches.


Add Gradle and Maven version parameters to Java

closes #260

@microsoft-github-policy-service agree

I created a new commit that is fixing the tests that are failing in the pipeline, as mentioned here: https://github.com/devcontainers/features/pull/263#pullrequestreview-1170812022

I created a new commit that is fixing the tests that are failing in the pipeline, as mentioned here: #263 (review)

Included in the commit is a refactoring from a pipe syntax with grep to a process substitution syntax. The check helper under certain condition is not accepting the pipe syntax and the grep was executed on the output of the check output, by using the process substitution syntax all the tests are displayed properly.

I created a new commit that is fixing the tests that are failing in the pipeline, as mentioned here: #263 (review)

Included in the PR is a refactoring from a pipe syntax with grep to a process substitution syntax. The check helper under certain conditions is not accepting the pipe syntax and the grep was executed on the output of the check function, by using the process substitution syntax all the tests are displayed properly.

I agree, that check command has room for improvement.  A lot of the test scripts do bash -c '<cmd> | grep <word>, but this looks more elegant :)


Difficulty using in Colabs.

Hello!
I am trying to use your code in Google Colabs.
It seems I can download it just fine:
!pip install --upgrade git+https://github.com/noahgolmant/pytorch-hessian-eigenthings.git@master#egg=hessian-eigenthings
gives output
Collecting hessian-eigenthings from git+https://github.com/noahgolmant/pytorch-hessian-eigenthings.git@master#egg=hessian-eigenthings   Cloning https://github.com/noahgolmant/pytorch-hessian-eigenthings.git (to revision master) to /tmp/pip-install-wkuzii9d/hessian-eigenthings Requirement already satisfied, skipping upgrade: numpy>=0.14 in /usr/local/lib/python3.6/dist-packages (from hessian-eigenthings) (1.14.6) Requirement already satisfied, skipping upgrade: torch>=0.4 in /usr/local/lib/python3.6/dist-packages (from hessian-eigenthings) (0.4.0) Building wheels for collected packages: hessian-eigenthings   Building wheel for hessian-eigenthings (setup.py) ... done   Stored in directory: /tmp/pip-ephem-wheel-cache-k1dx3b0r/wheels/ad/08/af/6413ff138430f7a58324c31d6e0326531b31515ed81f4d7ef3 Successfully built hessian-eigenthings Installing collected packages: hessian-eigenthings   Found existing installation: hessian-eigenthings 0.0.0     Uninstalling hessian-eigenthings-0.0.0:       Successfully uninstalled hessian-eigenthings-0.0.0 Successfully installed hessian-eigenthings-0.0.0
However, when I then try
from hessian_eigenthings import compute_hessian_eigenthings
as recommended by your readme, I get the following error message:
`---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
 in ()
----> 1 from hessian_eigenthings import compute_hessian_eigenthings
ModuleNotFoundError: No module named 'hessian_eigenthings'

NOTE: If your import is failing due to a missing package, you can
manually install dependencies using either !pip or !apt.
To view examples of installing some common dependencies, click the
"Open Examples" button below.`
Do you know why this might be occuring?

I've never worked with Colab before so I can't provide much help, but have you tried restarting the kernel after running the pip command?

Going to close this since this is probably a colab issue


Fix TimelineProposal line-height

 Reduce line height for proposal preview title

Something is wrong. Can you make it look exactly like this (demo still show primercss):
https://demo.snapshot.org/#/fabien.eth
https://demo.snapshot.org/#/fabien.eth/proposal/0xe369a3e58e1e8993432742f039b3b63a31ff3202d4638299d09d09f4884e31c9
This is how it was before:
https://snapshot.org/#/fabien.eth
https://snapshot.org/#/fabien.eth/proposal/QmbwqvMiz1e9mCyzEFGrbaN2fB7ioEuk1hJ8fsn6nLV1AK
The difference i see:

Titles h1 (in proposal page) or h3 (in preview) have different line height
Paragraph text in proposal have different font-size and line-height


Default config doesn't work/exist

Since Title and Commit checks are implicitly enabled, I shouldn't have to set any checks at all if I want to use the default config. However
wildfly:

doesn't work, same as
wildfly:
 format:

or even empty config

@The-Huginn


psd thumbnail preview on file explorer

Description of the new feature / enhancement
show thumbnails for more files, like photoshop, illustrator, 3d files and more
Scenario when this would be used?
when I want to preview files in file explorer without opening it
Supporting information
No response

/dup #4824


a few unconnected properties in guide inspectors

Axis inspector:
Title > Offset -- no effect
Ticks > Padding -- no effect
Legend inspector:
fill:
Gradient (border) > width -- no default/initial value, but works
size:
Symbols > opacity --- no effect
Symbols > width - no initial value, works

fill gradient issue is covered in https://github.com/vega/lyra/pull/497/files
sorry didn't see this in time.

hmm looks like tick padding isn't really a thing unless I am missing the vega lite equivalent.
also changing title offest to dx offset and dy offset


Update README

The goal of this PR is not to deep dive in to revamping the README, but simply to rename the env variable's name for GitGuardian API key to make it similar to the one used in ggshield.

Codecov Report

Merging #77 (28fe4c6) into master (3892245) will not change coverage.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   92.18%   92.18%
=======================================
  Files           6        6
  Lines         614      614
=======================================
  Hits          566      566
  Misses         48       48

Flag
Coverage Δ

unittests
92.18% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

pygitguardian/__init__.py
100.00% <100.00%> (ø)

pygitguardian/client.py
79.82% <ø> (ø)


Refactor/rewrite all the code

The change prepares solid ground for further improvements. This also fixes at least two bugs:

Proper support for empty lines and comments in build scripts.

Previously switching to new releases was not atomic despite all the symlink business. This is because it deleted the current link before creating the new one, but it should have created a new link and then use mv to replace the old one atomically. The code has been changed to work properly now.

Tests are comping soon, I'll need to figure out what to port and what to add from scratch, so it's still WIP.

@sestrella Perhaps you could take a look and tell me your thoughts so far?


Filtered data list

Let's say I have a page size of 5 in my table. My data prop contains an array of 20 elements, and I navigate to page 4. Now let's say I filter the list somehow  and now my data prop contains only 10 elements. Now I'm stuck on page 4 with no data and I have to navigate to load a safe page. (You can reproduce this behavior here )
I'm not sure weather this is a bug in React-table or if I should use a controlled ReactTable in this case.

This should be fixed in the latest version :)  When changing pageSizes, the current page is translated to an equivalent page based on the ratio of the new pageSize.

The problem I was having was not when updating pageSize, but when updating data with a new array. When it happens, the current page stays the same, but the data array could be smaller and contain no data at the index page * pageSize. Thus I would expect the page to be systematically set back to 1 when the data prop changes.

Interesting. I'll look into this
On Tue, Mar 28, 2017 at 8:05 AM Daniel Kostro<EMAIL_ADDRESS>wrote:

The problem I was having was not when updating pageSize, but when updating
data with a new array. When it happens, the current page stays the same,
but the data array could be smaller and contain no data at the index page

pageSize. Thus I would expect the page to be systematically set back to
1 when the data prop changes.

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/tannerlinsley/react-table/issues/139#issuecomment-289780481,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFUmCekYnUFZ7ysDoti5wDWtnbdT6YOPks5rqROSgaJpZM4Mn7xC
.


LazyLoadPicture: Extracted version of image lazy loading

Extracting module from the apps.
NOTE
This will be a minor change as it will require a change in the consumers webpack config to address jquery-lazyloads dependency on a globally available jQuery (but only if you require this module).
Example:
loaders: [
  {
    test: /jquery.lazyload.*\.js$/,
    loader: 'imports-loader?jQuery=jquery',
    enforce: 'pre',
  },
]

This will not be a breaking change, as you don't need to add it if you're not trying to get the new functionality, so minor.

👍

LGTM


colour of navbar links changed

Current behavior

Proposed changes

Checks

All commits in this Pull Request are signed and Verified by Github.

Newsletter enhanced

new Change

I saw you pull request, but because there are change in node modules it is impossible to review can you create new pull request and also delete node_modules from server as we don't need this.

ok sir

@Yash636261 please checkout pr #134


[DRAFT] support storing index in separated directory

What changes were proposed in this pull request?
Currently, the index file is stored in the data path. This PR support storing index file in separated directory by configuration. And if the configuration is not set, it will still be stored in the data path.
Method:
Add a configuration "spark.sql.oap.index.directory" in OapConf.scala to set the directory of index.
If the configuration is set, we update the write index path in getIndexWorkPath method of IndexUtils and simultaneously update get index path in indexFileFromDirectory method of IndexUtils.
How was this patch tested?
The most unit test can pass, except the test(create index on table partitioned by date type) of DataTypeSupportSuite not pass.

@JkSelf
I tried your failed case. seems some index files are overwritten.
Can you first confirm this?
For example:
| b='1970-01-01'
| |-- part-0000   -> index file: indexDir/part-0000.index
| |-- part-0001    -> index file: indexDir/part-0001.intex
| b='1970-01-02'
| |-- part-0000   -> index file: indexDir/part-0000.index  - overwrite previous index file
|  -- part-0001    -> index file: indexDir/part-0001.index  - overwrite previous index file

@JkSelf you can apply below patch to debugging.
The root cause is oap uses wrong index file for data file
diff --git a/src/main/scala/org/apache/spark/sql/execution/datasources/oap/index/IndexScanner.scala b/src/main/scala/org/apache/spark/sql/execution/datasources/oap/index/IndexScanner.scala
index cbc9611210..0a688da070 100644
--- a/src/main/scala/org/apache/spark/sql/execution/datasources/oap/index/IndexScanner.scala
+++ b/src/main/scala/org/apache/spark/sql/execution/datasources/oap/index/IndexScanner.scala
@@ -80,6 +80,8 @@ private[oap] abstract class IndexScanner(idxMeta: IndexMeta)
       logDebug("No index file exist for data file: " + dataPath)
       StatsAnalysisResult.FULL_SCAN
     } else {
+      println(s"found index for $dataPath")
+      println(s"index file: $indexPath")
       val start = System.currentTimeMillis()
       val enableOIndex = conf.getBoolean(OapConf.OAP_ENABLE_OINDEX.key,
         OapConf.OAP_ENABLE_OINDEX.defaultValue.get)
diff --git a/src/main/scala/org/apache/spark/sql/execution/datasources/oap/index/OapIndexOutputFormat.scala b/src/main/scala/org/apache/spark/sql/execution/datasources/oap/index/OapIndexOutputFormat.scala
index bb2d8d7bc8..4572053f6f 100644
--- a/src/main/scala/org/apache/spark/sql/execution/datasources/oap/index/OapIndexOutputFormat.scala
+++ b/src/main/scala/org/apache/spark/sql/execution/datasources/oap/index/OapIndexOutputFormat.scala
@@ -76,6 +76,7 @@ private[index] class OapIndexOutputFormat extends FileOutputFormat[Void, Interna

     val indexType = configuration.get(OapIndexFileFormat.INDEX_TYPE, "")

+    println(s"index location: $file")
     if (canBeSkipped(file)) {
       new DummyIndexRecordWriter()
     } else if (indexType == "BTREE") {
diff --git a/src/main/scala/org/apache/spark/sql/execution/datasources/oap/index/OapIndexOutputWriter.scala b/src/main/scala/org/apache/spark/sql/execution/datasources/oap/index/OapIndexOutputWriter.scala
index 476d4cc061..4c4f4b2bd4 100644
--- a/src/main/scala/org/apache/spark/sql/execution/datasources/oap/index/OapIndexOutputWriter.scala
+++ b/src/main/scala/org/apache/spark/sql/execution/datasources/oap/index/OapIndexOutputWriter.scala
@@ -85,6 +85,7 @@ private[index] class OapIndexOutputWriter(

   private def initWriter(): Unit = {
     inputFileName = InputFileNameHolder.getInputFileName().toString
+    println(s"build index for $inputFileName")
     recordWriter = outputFormat.getRecordWriter(context)
     rowCount = 0
   }

@linhong-intel ,thanks for your help!

@JkSelf , OAP follows the Spark code style, please take a look at https://spark.apache.org/contributing.html and https://github.com/databricks/scala-style-guide

@carsonwang , Thanks for your reminder! Yes, We should consider the full data path as the relative of the configured directory.  I will upload a POC for further review later. Thanks.

@JkSelf , here is a reminder, I don't know if you know this.
When we build index, we should follow this steps:

Get data file name, compute index file name
Create index file in a TEMPORARY directory. (I don't know if you have this step)
After index is completed, copy index file to the final directory.

The steps are to make sure spark speculation won't cause race condition.

@linhong-intel , I have not consider this.  I will work on the logic of this code later. Thanks for your reminder.

Thanks @JkSelf , this version looks much better, but I still have some advice:
Mainly 2 logics should be changed for the feature: getIndexPath & getTempPath

I believe the latter one is better to be changed in OapUtils, which is where the original logic locates in
The former one in IndexUtils need refactor
Most existing UTs should pass without changes, so I think the logic related to temporary folder needs changes.
New UTs testing the 2 changed funcs(in mentioned 2 xxUtils)(with not default conf) and the full work flow should be added.

As synced offline, @JkSelf will refine the code and tests

@gczsjdy , updated pr.

@gczsjdy ,updated.

thanks @JkSelf. LGTM
@LuciferYang , do you have time to do a quick review for this PR. just want to make sure your getTableBaseDir works as expected.

@linhong-intel ok~ i'll do this work today

@JkSelf should we need add a simple testcase to cover OapConf.OAP_INDEX_DIRECTORY is blank String ?

@LuciferYang update the comment of getOutputPathBasedOnConf and add the blank string case test.

cc @LuciferYang LGTY?

Thanks @JkSelf @linhong-intel @LuciferYang !

thx @gczsjdy


daemon: Fix nil pointer dereference when deleting k8s service

Fixes b65668c32c (Manipulate egress policies on k8s endpoint changes)
Signed-off-by: André Martins<EMAIL_ADDRESS>

We should merge this as-is to unblock and fix the bug, but we should also have runtime tests that test this.


SourceDetectionResult.get_pixel_position_of_sources() returns pixel values

Currently, as mentioned by Patrick Arlt, it returns real numbers and not integers.

The reason it returns float and not integer values is that float values are much more accurate when the pixel size is coarse. In the extreme case, integer values would assign multiple sources to a pixel, losing essential information.
Should we tackle this issue anyway? I see the following possibilities:

Keep functionality, but set docstrings and return values so far that it should be clear that a float is returned.

Return real pixel values, changing the relative positions to each other and also aggregating multiple sources to one, depending on pixel sizes.

Implement both options mentioned above and make them available through a parameter or two different functions.

What is your opinion on this @rohitcbscient @deiruch ?


Add Open With... to explorer context menu

re https://github.com/microsoft/vscode/issues/93767

I have a custom editor for JSON document
In the editor's secondary title menu I see the 'Reopen with...' command
I would expect something similar in the explorer's context menu

Also related to #95730


Fix argument mutation when fitting

This PR makes minor changes in fit_lc and mcmc_lc where instead of using
if bounds is None:
    bounds={}

the bounds are copied as
bounds = copy.deepcopy(bounds) if bounds else {}

It also adds a few tests to validate the above change.

Looks good except the tests are failing due to (I think) a missing import of deepcopy.


"BACK" button of the browser display a warning message

Hi,
I want to configure my multi-step form so that the "BACK" button of the browser don't display a warning message.
For this i use this option :
"protected $allowDynamicStepNavigation = true"
It's ok with firefox but not with chrome.
There is it a solution ?
Thanks for your help.

Hi,
I solved my problem.
This was due to the fact that the site certificate was no longer valid.
Chrome is more rigorous with that than Firefox.


Problems drawing left/right arrow in mover

Issue Summary
MathJax has some problems with drawing a stretchy arrow as detailed below. The results differ between Chrome and Firefox, but in all cases, the arrow display in an mover has problems.
Steps to Reproduce:

View the codepen I created

In Firefox, the right arrow is not stretched in normal display -- it is right aligned; the left arrow is left aligned (maybe the horizontal line part isn't visible?). When zoomed, the pieces don't align. The alignment problem might be the same issue reported in #2226. Here is a screen shot:

I tried different zoom factors. The alignment problems shows up at 150%, 200%, 300%, but not at 400%.

In Chrome, do the same thing. The display is better, but the unzoomed right arrow has different widths for the pieces. In the zoomed case, it is just barely wrong -- an extra pixel is highlighted where the pieces are joined.

Version:

I'm going through back issues, and just saw that I never responded to this.  (I was just starting remote classes, and was swamped at the time.)  I will look into it further.


aws-robomaker-hospital-world launch error with ROS1+ Kinetic + catkin package?

Whether aws-robomaker-hospital-world package support with ROS1 and catkin package?
While running roslaunch aws_robomaker_hospital_world hospital.launch command
[Wrn] [ColladaLoader.cc:1404] Unable to add material[]
[Err] [MeshManager.cc:96] Invalid mesh filename extension[/home/xxxxx/catkin_ws/src/aws-robomaker-hospital-world/fuel_models/CGMClassic/meshes/CGMClassic.obj]
[Err] [MeshShape.cc:72] Unable to load mesh from file[/home/xxxxx/catkin_ws/src/aws-robomaker-hospital-world/fuel_models/CGMClassic/meshes/CGMClassic.obj]
Help me to solve this error.

Hi @Sivasankar-Ganesan - Thanks for your message. That error is due to an incorrect relative link for a mesh in one of the 3D models stored in the Ignition Fuel database. It shouldn't impact the running of the application, but if you want you could remove the references to that model and/or make a small change.
In the model folder:
fuel_models/CGMClassic/meshes/
Open CGMClassic.MTL in a text editor, then overwrite the file with this (just adds the ".png" extension to the model):
# 3ds Max Wavefront OBJ Exporter v0.97b - (c)2007 guruware
# File Created: 15.05.2018 18:22:24

newmtl CGMClassic
	Ns 10.0000
	Ni 1.5000
	d 1.0000
	Tr 0.0000
	Tf 1.0000 1.0000 1.0000
	illum 2
	Ka 0.5882 0.5882 0.5882
	Kd 0.5882 0.5882 0.5882
	Ks 0.0000 0.0000 0.0000
	Ke 0.0000 0.0000 0.0000
	map_Ka CGMClassic_Diffuse.png
	map_Kd CGMClassic_Diffuse.png

newmtl Wheels
	Ns 10.0000
	Ni 1.5000
	d 1.0000
	Tr 0.0000
	Tf 1.0000 1.0000 1.0000
	illum 2
	Ka 0.5882 0.5882 0.5882
	Kd 0.5882 0.5882 0.5882
	Ks 0.0000 0.0000 0.0000
	Ke 0.0000 0.0000 0.0000
	map_Ka Carts_Wheels_Diffuse.png
	map_Kd Carts_Wheels_Diffuse.png
	map_bump Wheels_Normal_Normal_Bump.tga


feat(modal): adjust modal content top padding

[no-jira]
Description
There is a difference between the Modal.Content component in Picasso and Figma Product Library. This change fixes this issue. Topic has discussed in the slack channel
How to test

FIXME: Add the steps describing how to verify your changes

Screenshots

Before.
After.

Development checks

[ ] Add changeset according to guidelines (if needed)
[x] Read CONTRIBUTING.md and Component API principles
[ ] Make sure that additions and changes on design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
[n/a] Annotate all props in component with documentation
[n/a] Create examples for component
[ ] Ensure that deployed demo has expected results and good examples
[n/a] Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
[x] Self reviewed
[n/a] Covered with tests

Breaking change

[ ] codemod is created and showcased in the changeset
[ ] test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

@toptal-bot run all - Run whole pipeline
@toptal-bot run build - Check build
@toptal-bot run deploy:documentation - Deploy documentation
@toptal-bot run package:alpha-release - Release alpha version

PR Review Guidelines

When to approve? ✅
You are OK with merging this PR and

You have no extra requests.
You have optional requests.

Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌
You are not OK with merging this PR because

Something is broken after the changes.
Acceptance criteria is not reached.
Code is dirty.

When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:

There are leftovers like unnecessary logs, comments, etc.
You have an opinionated comment regarding the code that requires a discussion.
You have questions.

How to handle the comments?

An owner of a comment is the only one who can resolve it.
An owner of a comment must resolve it when it's addressed.
A PR owner must reply with ✅ when a comment is addressed.

Hello @krav4enkodm 👋 Can you please add changeset to this PR 🙏
You can run locally yarn changeset to generate one


Parse compile_commands.json to get flags for the clang linters

Spiritual successor to #1242. A few things have been fixed and improved, and there are now tests.

Awesome, I'm glad someone is picking this up. I'll have a read through this later. Try to address the merge conflicts for now, if you can.

Closing due to inactivity.


Document testing source generators

Testing is briefly documented in the cookbook, but it should be documented in docs.microsoft.com for discoverability (and in a little bit more details than cookbook).
I'm not sure whether this should be part of this article, or if it should be a new article.
Note: if https://github.com/dotnet/roslyn-sdk/issues/873 is likely to be fixed soon, the docs should be using the template for the article.
cc @BillWagner @mikadumont @sharwell

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 99a4410c-4c8d-0107-845b-9a951bb76682
Version Independent ID: f1ed9873-3e29-b4bd-2dbb-44dd9a05d790
Content: Source Generators
Content Source: docs/csharp/roslyn-sdk/source-generators-overview.md
Product: dotnet-csharp
Technology: csharp-roslyn
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

Adding @jmarolf for planning purposes.

I think it should also be mentioned as part of https://docs.microsoft.com/en-us/dotnet/csharp/roslyn-sdk/source-generators-overview#get-started-with-source-generators that, beyond the simple scenario shown, testing is the recommended way of developing a source generator.


[Bug]: LN transactions have not been restored

Describe the bug
2 out of 2 users tested v93 and when we restored it, no LN transactions appeared. The onchain ones did.
Reproduce

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots / Recording
No response
Operating system
Android and GrapheneOs
Bitkit version
v93
Log output
bitkit_ldk_logs_1704467670010.zip

Can't reproduce the error. @pwltr is this issue has been fixe with the old backup issue?

I couldn't repro this the last 2 days.

@pwltr Is there a way I could confirm the backup server is working correctly, I mean additional to the manual testing which does confirm LN transactions are no longer lost?
P.S. I'm asking to make sure it's safe closing this issue 🙏🏻

@pwltr Is there a way I could confirm the backup server is working correctly, I mean additional to the manual testing which does confirm LN transactions are no longer lost?

I don't know backups is not really my area. As to how to check if it's working correctly outside Bitkit, better to ask @Jasonvdb or @rbndg.

Thanks, since there's a ping already I won't double it for now ;)

As this issue didn't reproduce in the last 3 internal releases, I'm closing it.


Automatically update nodePackages

Motivation for this change
Currently running at https://github.com/SuperSandro2000/nixpkgs/runs/1883519163?check_suite_focus=true
Example PR https://github.com/SuperSandro2000/nixpkgs/pull/2/
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

I wonder whether we should extend the concept of updateScript also to package sets.

I wonder whether we should extend the concept of updateScript also to package sets.

Might be an option but I lack the nix knowledge to implement that.

I love the idea!

Probably want to notify people when the PR is created, could cc them in the PR comment or add pkgs/development/node-packages/node-packages.nix to CODEOWNERS.
A failure notification like we have for merge-staging may also be helpful.

Probably want to notify people when the PR is created, could cc them in the PR comment or add pkgs/development/node-packages/node-packages.nix to CODEOWNERS.

Who would we ping? I couldn't find any real code owner except maybe @mic92.

A failure notification like we have for merge-staging may also be helpful.

That would be helpful. Should I use the issue number of this PR or create a new issue which is just for failures?

Maybe there is a need for a node team ?
Just thinking out loud here.

At the very least we need codeowners for node-packages.nix.

One problem i see with this is that if the update of one package fails, the whole PR fails. If there was a way to do it per package, it would be easier to merge the ones that did not fail.

One problem i see with this is that if the update of one package fails, the whole PR fails. If there was a way to do it per package, it would be easier to merge the ones that did not fail.

There is no such concept right now and I don't know if it would be doable.

At the very least we need codeowners for node-packages.nix.

I would suggest myself but I someone or two more wouldn't hurt.

I agree with you, I don't know how to do it either.
I would be interested too in being in the nodePackages maintainer if you create a team.

Hey, a crazy idea.
What about keeping each package in a separate directory (with the same layout as the current directory). Or maybe groups of packages that belong together.
That way packages or group of packages could be updated and added independently.
In the top directory we could reference the packages from their directory.
Let me know if it doesn't make sense.

To favor discussion, I have created a PR with what I have in mind
https://github.com/NixOS/nixpkgs/pull/113294
I would be curious to get some feedback, if anybody has time.
I think it's still early stage, but it's just to put forward an idea.

Could you add also an entry in https://github.com/NixOS/nixpkgs/blob/master/.github/CODEOWNERS

Added me to codeowners and the path to the script in the commit title and body.
I currently do not want to create a team for node.

I am too in favor of automated updates to all node packages but I never thought it would be acceptable in Nixpkgs, I also don't think this should go through the PR bottle neck as suggested here but I understand why it's a sensitive issue in Nixpkgs. Hence I created:
https://gitlab.com/doronbehar/nixNodeJSPkgs
Which is a flake that runs automatic updates via GitLab's CI and commits them directly. It's still not ready for an official announcement yet, because it fails to build the only package I'm interested in due to https://github.com/svanderburg/node2nix/issues/233 .
I also want the update to run every day, because the package I wish to build there gets a new release every 1-2 days: https://github.com/balena-io/balena-cli/releases .

Would be still useful to have this.

Whenever node-packages is a problem for you, the package should be converted to buildNpmPackage.


Splits lotus/message module into submodules

Some housekeeping. This PR splits the message module into submodules, one for each category of calls.

LGTM. As @cryptoAtwill may be asleep, feel free to remove the types I tagged if you see that nothing breaks. If something breaks I can look at it or wait for him, this morning we merged a PR that moves those types to fvm_utils.
Also, what do you think about renaming the package to types instead of messages? They seem more of lotus types than messages.

This leaves me very conflicted. I dislike the types pattern because, over time, it tends to become a dumping ground for random type definitions leading to a loss of structure. I wanted this module to contain the types that represent the data exchanged during JSON-RPC calls. To that effect, message seems a more specific name than the generic types. If you strongly prefer types, however, I can rename it. Wdyt?


chore(tf): create password for read-only SQL user on staging

Process for creating a new observer user:
echo $(kubectl get secret --namespace default sql-secrets-init-passwords -o jsonpath="{.data.SQL_INIT_OBSERVER}" | base64 --decode)
kubectl exec -it sql-mariadb-primary-0 -- /bin/bash -c 'mysql -u root -p${MARIADB_ROOT_PASSWORD}'

CREATE USER IF NOT EXISTS 'observer'@'%' IDENTIFIED BY 'TODO_PASSWORD_FROM_ECHO';
GRANT SELECT, SHOW VIEW ON apidb.* TO 'observer'@'%';
GRANT SELECT, SHOW VIEW ON `mwdb_%`.* TO 'observer'@'%';
GRANT SELECT, SHOW VIEW ON `mediawiki`.* TO 'observer'@'%';
FLUSH PRIVILEGES;

This looks good to me schematically. I have at least a small worry that the new method we're now using for working through modules might have a side effect of us rotating the other secrets that we don't want to touch
My "plan" of this PR looks like:
  # random_password.sql-passwords["staging-observer"] will be created
  + resource "random_password" "sql-passwords" {
      + bcrypt_hash      = (sensitive value)
      + id               = (known after apply)
      + keepers          = {
          + "rotate" = "2"
        }
      + length           = 32
      + lower            = true
      + min_lower        = 0
      + min_numeric      = 0
      + min_special      = 0
      + min_upper        = 0
      + number           = true
      + numeric          = true
      + override_special = "_%@"
      + result           = (sensitive value)
      + special          = true
      + upper            = true
    }

  # module.wbaas2-k8s-secrets.kubernetes_secret.sql-secrets-init-passwords["adhoc-jobs"] will be updated in-place
  ~ resource "kubernetes_secret" "sql-secrets-init-passwords" {
      ~ binary_data = (sensitive value)
        id          = "adhoc-jobs/sql-secrets-init-passwords"
        # (2 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.wbaas2-k8s-secrets.kubernetes_secret.sql-secrets-init-passwords["api-jobs"] will be updated in-place
  ~ resource "kubernetes_secret" "sql-secrets-init-passwords" {
      ~ binary_data = (sensitive value)
        id          = "api-jobs/sql-secrets-init-passwords"
        # (2 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

  # module.wbaas2-k8s-secrets.kubernetes_secret.sql-secrets-init-passwords["default"] will be updated in-place
  ~ resource "kubernetes_secret" "sql-secrets-init-passwords" {
      ~ binary_data = (sensitive value)
        id          = "default/sql-secrets-init-passwords"
        # (2 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 1 to add, 3 to change, 0 to destroy.

Did you already try this locally and confirm this "change" is actually a noop rather than regenerating the passwords?


SVG to JPG not working with image files

I'm trying to rasterize an SVG image which contains an image tag pointing to a local file. However, the image is not rendered. I've tried the same svg directly with rsvg-convert and it works. I've tried relative and absolute paths with the image in the project root or descendant folder. Sharp does work if the image tag contains a data uri.
Any help would be appreciated!

Hello, is this with file-based input or Buffer/Stream based input? If the latter please try the former as librsvg places security limits on the location of included files.
It's also worth trying with absolute filesystem paths or ensuring paths are relative to the process' working directory (which may not be the same as the directory your script is in).

@hbar-digital Were you able to make any progress with this?

@lovell You are correct in that it's a librsvg limitation as I was using a stream based input. The workaround was to convert the image to base64.

Thanks for confirming. I'll close as this is a security feature of librsvg with a workaround for trusted input.


how to clear RxListAdapter

https://github.com/ogaclejapan/RxBinding/wiki/RxListAdapter#synchronization-of-list
I run the code  and found listAdapter.getCount() not 0 after call master.clear()
I sure the list is clear . seem not easy to clear listAdapter

Thank you for reporting.
I have notified the clear events in the Scheduler (Handler).
Immediately call and it is not a 0 result might be returned.
The sample code I will fix later

Sorry, it was implemented mistake.


First render after key changes has isLoading == false

🐞 Bug Report
Describe the bug
On the initial render of a component using fetchye, the returned values are:
{data: undefined, error: undefined, isLoading: true}

Then when the data finishes loading, it changes to:
{data: {…}, error: undefined, isLoading: false}

When the fetchye key (for instance the body of the request) changes, you would expect the state to change back to loading.  But instead the first render is this:
{data: undefined, error: undefined, isLoading: false}

This makes it difficult to write any code that is dependent on isLoading to render a loading indicator.
To Reproduce
Example code:
  const [id, setId] = useState(1);
  useEffect(() => {
    setTimeout(() => setId(2), 1000);
  });

  const { data, error, isLoading } = useFetchye(id);
  console.log({ data, error, isLoading });
  return
test
;

Prints this to console:
{data: undefined, error: undefined, isLoading: true}
{data: undefined, error: undefined, isLoading: true}
{data: {…}, error: undefined, isLoading: false}
{data: undefined, error: undefined, isLoading: false} <====
{data: undefined, error: undefined, isLoading: true}
{data: undefined, error: undefined, isLoading: true}
{data: {…}, error: undefined, isLoading: false}
{data: {…}, error: undefined, isLoading: false}

Expected behavior
isLoading should be true after the key changes.

The root cause seems to be due to this line:
https://github.com/americanexpress/fetchye/blob/main/packages/fetchye/src/queryHelpers.js#L21
This has special handling for render #1.  But the render count is not reset when the key changes, so this logic is not used later.


[RFE] Publish official Kubevirt images

Current situation
Flatcar does not work ( officially ) in Kubevirt and other platforms based on Kubevirt ( https://github.com/harvester/harvester ), because of the missing flatcar.oem.id=kubevirt parameter in grub.
Impact
Mid
Ideal future situation
Official Kubevirt images are published
Implementation options
X
Additional information
Images based on https://github.com/kubernetes-sigs/image-builder/ are working correctly

Hello, the official production image works (example: https://alpha.release.flatcar-linux.net/amd64-usr/current/flatcar_production_image.bin.bz2), leveraging the coreos-cloudinit fallback implementation.
I think you mean adding support for Ignition to work with Flatcar deployed as a KubeVirt VM, which will be required as an oem image.
@lukasmrtvy The Kubevirt CDI helper usually supports .gz or .xz implementation, do you have a preference for the compression format?
Some documentation would be needed to give an example workflow though, with both Ignition and the coreos-cloudinit. Also to mention that Flatcar supports only cloudInitConfigDrive data source: https://kubevirt.io/user-guide/virtual_machines/startup_scripts/#data-sources
Thank you,
Adrian Vladu


Fix modal vol ls

Why is it modal vol ls and not modal volume ls?

Why is it modal vol ls and not modal volume ls?

@thundergolfer ping ^


Update the npm packages of BasicServices and ApplicationPattern to 2.0.1-alpha.14

The following new releases of npm package for both ApplicationPattern and BasicServices are available,
•             onf-core-model-ap+2.0.1-alpha.14
•             onf-core-model-ap-bs+2.0.1-alpha.14
Upgrade ApplicationPattern and BasicService npm package to version2.0.1-alpha.14.

Issue closed as a part of https://github.com/openBackhaul/OperationKeyManagement/pull/227


Test against multiple versions of ActiveSupport

On Travis run tests with ActiveSupport versions 3.0, 4.1, 4.2, 5.0, 5.1.
Fixes #1

Skipping ActiveSupport 4.0.x
We can't use Appraisal to test ActiveSupport 4.0 because this requires tzinfo gem at ~> 0.3.37, but the gemspec requires tzinfo as a dev dependency at >= 1.2.2, which leads to a conflict.

https://rubygems.org/gems/activesupport/versions/4.0.13
Other versions can be tested:

ActiveSupport 3.x didn't require tzinfo
ActiveSupport >= 4.1 needs tzinfo ~> 1.1 which can be satisfied

The rbx-2 builds are failing, this might the following TravisCI issue:
https://github.com/travis-ci/travis-ci/issues/5294
Q: Should we remove Rubinius from the build? Several other projects seem to be removing it according to that issue.

The jruby-19mode builds are failing because:
Bundler could not find compatible versions for gem "ruby"

In Gemfile:
    ruby java
    zonebie java was resolved to 0.6.1, which depends on
      ruby (>= 2.0.0) java

If zonebie requires ruby >= 2.0.0 then I think we can't use jruby-19mode.
Q2: Shall we bump the jruby version to 9.x (which is similar to Ruby 2.2).

Q3: If we rebuild master - is it currently green? The last build was over a year ago.

Other gems, like vcr and redcarpet, now allow rbx-2 to fail on Travis:
https://github.com/vcr/vcr/commit/3fe3166cb941bcb8b9a80aec35b6d372339a50d6
https://github.com/ejholmes/restforce/commit/9cde3be3bfff7a8778c9e07dd0431a5c048e7f55

The jruby builds are now passing with a more modern version (2.x MRI compatible).
The rbx builds are still failing...

@alindeman do you have a view on whether testing against rbx in CI is still required?

@alindeman do you have a view on whether testing against rbx in CI is still required?

This overall LGTM, thanks for doing it. I think it's OK to let rbx fail at this point. Could you make that change? I'll merge it afterward.

@alindeman updated, thanks!

Super, thanks for your contribution!


Emotly model api

Added Model for Emotly and Created First Api method (Create, Read(single/list))
Added a new controller.
Modified the behavior of created_at fields, adding a default value and removing the required attribute.

When you're done addressing the review comments ask @ggc87 to take a look too. Thanks!

There are a few of pep8 tests for "E501 line too long (92 > 79 characters)" I can no longer deal with these for the next hours.

Lot of love!:) Very interesting branch, let me know what you think about those comments.
Thanks!

LGTM.
And thanks for being so forthcoming!


Fix memory utilization

Memory util always reported as 0%. What we want is probably to add 'memory'  to the nvidia-smi command line, then parse the "Used" field under "FB memory usage" block.

Should be fixed by https://github.com/AaltoScienceIT/ansible-role-sacct_gpu/commit/74bf833e66460082cb127cfc1895e0f5cf3a2610


reseed the config even when dont-reset-seed is set

Hello @adamchainz
When using --randomly-dont-reset-seed, we loose the possibility to specify a seed, and as consequence to keep a stable ordering of tests.
I slightly modified it so that the seed is always printed, no matter what is the setting for dont-reset-seed. It gives you a chance to make a second call, keeping the same ordering, and the same "global" seed, event if it's not reset between tests and/or testcases.
Additionally, I added a test for faker, using the same principle used for numpy.

Merged the faker test in 16a7df82b931881692621965fccad031242b7a5a

Merged the behaviour fix in 8ae55b606aee1fa903392f40a8ab683d17a946f1 . I reworded some bits after taking the time to fully understand the fix.
Thanks! 🎉🎉🎉

Released in 1.2.0 https://pypi.org/project/pytest-randomly/


feat: Allow overriding registered callbacks

I have created a custom streaming callback and am trying to register it with @register_streaming_callback("AgentExecutor") but it raises KeyError: "<class 'app.callbacks.MyCustomAgentsStreamingCallback'> already registered as AgentExecutor".
It would be very convenient to be able to override the default lanarky AgentExecutor callback since otherwise I have to create a custom AgentExecutor, register it and then write more code that supports my custom agent (for example the initialize_agent function in langchain which does not support custom agents atm. The workaround is further not ideal since I may not need a custom AgentExecutor, but only a custom callback handler.
One simple solution would be to simply replace the raise with a warning here instead https://github.com/ajndkr/lanarky/blob/main/lanarky/register/base.py#L26.
Acceptance Criteria

[ ] Being able to override registered callbacks

That’s a good point! I will add a feature to override existing callbacks

@rbbby the feature has been added. please install the latest version (0.7.4). You can use the override param:
from lanarky.register import register_streaming_callback

@register_streaming_callback("AgentExecutor", override=True)
class MyCustomAgentsStreamingCallback:
 ...

let me know if you face any issues!


Fix score_event compatibility with python 2.7

issue: score_event method's output in python 2.7 version differs from python 3.
To reproduce run code from https://www.kaggle.com/mikhailhushchyn/dbscan-benchmark/ or https://www.kaggle.com/mikhailhushchyn/hough-transform/
This small changes fixes difference.

I've tested locally, in docker, server. Different environments/times set. Looks like it is due to python version. In python3 everything is fine, but python 2.7 numpy divide is not working as expected (wrong broadcasting?, didn't checked shapes of arguments). Replacing it with just "/" works.. :).

Yes but we use numpy everywhere because of speed (first version of the scoring function was taking 30 s per event! now ˜0,2 s per event).
Could you still indicate how long it takes for you ? Just as an indication.

oh, I get wrong of your message above, sry).
In my laptop, numpy.divide mean process time is - 1.68ms,
mean process time of that 2 lines with "/" is 1.34. So it seems faster.
When we use division of numpy arrays with "/", it's still uses numpy. Why it differs - requires digging.

Thanks @erko for finding and solving this. I was testing the code mostly with python3 and therefore did not catch it.


Setting option "show all flags"

Expected behavior:
In the tasks settings of navigations tasks with flags a toggle for "Fahne auf der Karte behalten" is required. During the game the corresponding flags should continue to be displayed (in grey/ transparent) in follow-up tasks.
Actual behavior:
There is no setting option for keeping "old" flags on the map.

Perfekt :-)


Bug/support multiple uri params

The command now supports multiple URI params, e.g. /players/{name}/{age} and URI params as well as query params at the same time, e.g. /players/{name}/{age}{?filter,locale}
Furthermore I added extensive unit testing for parsing URI's which cover most of the scenarios I often run into.
While working on the code, I split the original parseUri method into multiple sub-methods. parseUri itself just checks for URI and query params and replaces them.
I'd suggest creating version 1.1.3 after merging this.

Thanks for the PR @hendrikmaus! It's merged in and just released v1.1.3.

@kielabokkie you're welcome


Fix mx.graphics.GradientEntry

I merged PR #159 too soon.
The constructor needs to be removed or the values passed into the super constructor.

@alinakazi Please fix this.

https://github.com/apache/royale-asjs/pull/165 GradientEntry Constructor Deleted

I don't think the constructor should be removed.  I think the compiler will generate a constructor without any parameters.  I think the parameters must exist and be passed to super.

GradientEntry Constructor Added  and parameters to super.


v2 enhancements

Signed-off-by: kumarabd<EMAIL_ADDRESS>Description
This PR fixes #
Notes for Reviewers
Signed commits

[ ] Yes, I signed my commits.

@leecalcote not a release blocker, just some improvements.


Include pip3 version of command on package webpage

Hi! I was wondering if on a package page in the PyPI website, (ex. this one), where you have the text pip install package, and the button to copy to clipboard.

Could you also include the pip3 version as well?
pip3 install package
Thank you for your time, and let me know if you need additional information

Christopher Palazzolo :)

There is no program called pip3 -- that's just a wrapper provided by certain vendors.
There is an open discussion about improving this command at https://github.com/pypa/warehouse/issues/1563, so I'm going to close this as a "loose" duplicate of that issue, but thanks for the request!


Go SDK getting-started v2

Based on this gist and the Go SDK example here
Signed-off-by: kpenfound<EMAIL_ADDRESS>

Super rough draft @shykes @mircubed @vikram-dagger
I'll do another pass over it tomorrow!

Preview here: https://deploy-preview-3450--devel-docs-dagger-io.netlify.app/8g34z/get-started-sdk-go

update: we'll do edits in follow-up PRs to avoid creating conflicts with other work


updates hashstack version to stable/proteus latest commit

Looks like most recent commit to .hashdist_default was in January

For future reference, here's a rough outline of how to update the remote hashdist caches for the travis build.

docker pull cekees/minv2:latest
run that image and login to it
pull proteus and (more importantly) proteus/stack to the new versions
rebuild that stack and proteus manually
hit remote push (pushes the source and build caches to a remote server)
optionally commit and push the cekees/minv2:latest image
I'll do that next week for this PR. We can do most of that automatically with buildbot once that setup is back online and we have some docker  images running as buildbots. The idea being that the buildbots on ERDC hardware will be doing a fair amount of heavy testing, including fresh builds of the stacks, so they can also push the build artifacts to remote caches. Travis and most builds would then be using   mostly cached source and build artifacts.

Still running build.  My power cord got  dislodged and my machine shutdown in the middle of the build. With docker containers you have to manually commit to save state, so an accidental shutdown like that means you have to  start from scratch.

@mfarthin and @alistairbntl the hashstack binaries are working for this, but many of the tests are failing.

@tridelat some of the tests are failing because  if proteus.mprans.SpatialTools not being able to import proteus.mprans.BoundaryConditions. I think it has to do  with how the import needs to happen in a regular install, probably using either the from . syntax or adding BoundaryConditions to mprans/init.py.  Not a big hurry, but I won't be able to track it down for a few days.


Fixed typo that prevents Pet Charms from being displayed as LDB text

Name of constant was not consistent throughout the project.

You're absolutely correct that it was not consistent and needs to be fixed.  However, I am trying to make the name in Constants.lua match the name on wowhead.  And, sadly, Blizzard is pretty inconsistent on naming of currency ...some are singular (e.g., "Polished Pet Charm" and some are plural "Flightstones"
Therefore, the way I want to fix this is by changing how it's used in the WorldQuests.lua rather than changing the name in Constants.lua.    So, I will push a fix for this later tonight, but it will be by adjusting the other file instead of adjusting Constants.lua.
I really appreciate you doing this pull request though, it does make it clear to me what needed to be fixed.
The honest truth is that I think I had it all correct and consistent before, but I merged a pull request yesterday and I think they had it different, so that's where the inconsistency occurred.

<IP_ADDRESS>

Fixed an issue affecting Polished Pet Charms (thanks tflo for catching it.)

There are 3 occurrences of this constant, IIRC. If you make them all POLISHED_PET_CHARMS or all POLISHED_PET_CHARM doesn't really matter ;) … as long as they match.

There are 3 occurrences of this constant, IIRC. If you make them all POLISHED_PET_CHARMS or all POLISHED_PET_CHARM doesn't really matter ;) … as long as they match.

Yea, I think it should be good now.   Honestly, I think that I had it all consistent before and then one of the pull requests I merged recently caused the disconnect.
Thanks!


Improved table insert, and column and row insert

This PR adds an way to insert a table with specific dimensions, and provides 2 buttons on the toolbar for adding columns and rows for much faster editing.
All features in this PR:

Toolbargroups with separators between categories of functionality (text formatting, lists and indentation, and table buttons in separate groups). Not essential to table insertion, but maybe good idea for clarity when also table buttons are to be shown.

Added inputs for the dimensions of the table to insert.

Added "Add row" and "Add column" buttons on the toolbar for faster table editing.
Made icons (POC) for all table actions. This was needed when I wanted to make toolbar buttons for these actions.

All buttons now have tooltips for clarity (using the title HTML attribute), with proper translations added.

NEED TO FIX:

[ ] Width of the dropdown. Some text is cut off, and I couldn't find why.
[ ] Icons need a review. I quickly made these, although I really tried to make them look official and good quality. Some are not clear with small sizes. (E.g. the plus symbol.)
[ ] Icons need to be embedded in the HTML as proper SVG's? Or not? They certainly need to be optimised first (created using Inkscape, and that leaves a lot of metadata).

@Dietr, we will need your finishing touch on the lay-out of the dropdown, the icons and the approval of the design.

Nice work, I expect we'll get a request to move the other table icons out of the menu as well, atm it doesn't make much sense to only have 2 of the icons available on single click


Is there an ansible module that can push inventory data into ServiceNow?

Seems like I want to do the reverse.   Do you know if there is a solution?

Not that I've seen, not in the scope of this project but I'll take a look at writing something if I find time.


Python integration tests are failing in cancel by queue and job set

Python tests are consistently failing due to a change in how we cancel jobs. We should enable them.
The make-e2e-tests-python target should allow you to see the failure.

https://github.com/armadaproject/armada/actions/runs/4231665003/jobs/7350461679


Different behaviour for d3fc.js/d3fc.min.js when using area and line series as keys

I've been developing a chart which uses multi series (using identity for the key function), area series and line series.
// Simplified example
var area = fc.series.area();
var line = fc.series.line();

var multi = fc.series.multi()
    .key(fc.util.fn.identity)
    .series([area, line]);

This was working fine when I was developing using d3fc.js, but when I ran the production build, which uses d3fc.min.js, it all went wrong. Either only one of the series would be rendered or a single container would be used by multiple series - which shouldn't be done. Here's a demo:
d3.js (JS Bin)
d3fc.min.js (JS Bin)
The issue is that the keys (which are ultimately strings) are different in d3fc.js, but the same in d3fc.min.js:

In d3.js the strings are different (JS Bin)
In d3fc.min.js the strings are the same (JS Bin)

Is this an issue? Or just the way d3 works? I vaguely recall that the key for a data join must return a string. If you return something other than a string it still works but with odd behaviour.

I think this should be documented rather than fixed. Using functions as
keys isn't a pattern I'd want to encourage.
On Sun, 22 Nov 2015 13:23 James Leftley<EMAIL_ADDRESS>wrote:

I've been developing a chart which uses multi series (using identity for
the key function), area series and line series.
// Simplified examplevar area = fc.series.area();var line = fc.series.line();
var multi = fc.series.multi()
.key(fc.util.fn.identity)
.series([area, line]);
This was working fine when I was developing using d3fc.js, but when I
ran the production build, which uses d3fc.min.js, it all went wrong.
Either only one of the series would be rendered or a single container would
be used by multiple series - which shouldn't be done. Here's a demo:
d3.js (JS Bin) https://jsbin.com/mofeyiteli/1/edit?html,js,output
d3fc.min.js (JS Bin) https://jsbin.com/qedobulese/2/edit?html,js,output
The issue is that the keys (which are ultimately strings) are different in
d3fc.js, but the same in d3fc.min.js:

In d3.js the strings are different (JS Bin)
https://jsbin.com/quwufilino/2/edit?html,js,output
In d3fc.min.js the strings are the same (JS Bin)
https://jsbin.com/qutitisaju/2/edit?html,js,output

—
Reply to this email directly or view it on GitHub
https://github.com/ScottLogic/d3fc/issues/791.

It's the way D3 works. .data() uses d3.map to map the nodes to keys. The map uses string-coercion for keys:

Note: unlike the proposed ES6 map, d3.map still uses string-coercion for keys rather than strict equality.

I agree, I think some documentation explaining how the key function works would be very valuable, and a warning of the potential issues which can arise when keying on functions.


Add support to iPhone X

Hello, Thanks for your open sources.
I have found that Fusuma has not support to iPhone X.
I use swift 4 branch.

Is work perfect on iPhone X when i change branch to master.
Is it possible that update swift4 branch to add this feature?

@LimChihi Fusuma is not fully compatible with Swift4 yet. 😢
Please give me the PR, if possible.