A booboo and an rfe in contains documentation

Hi All,
Over on
https://docs.perl6.org/routine/contains#(Str)_method_contains
the return  value is missing: --> Bool
Since it need to be updated anyway, for clarity, would you please consider the following enhancements:
Old:           multi method contains(Str:D: Str:D $needle, Int:D $pos)
Proposed: multi method contains(Str:D $Haystack : Str:D $Needle, Int:D $Position --> Bool)
Giving the input string the name "Haystack"  gives meaning to the parameter of "Needle".  You are searching for the "needle in the haystack".  Without this linkage, one is left wondering what the "needle" is "sticking".
The " :", rather than ":" makes it more clear that it is a delimiter to the untrained eye.
And spelling out "Position" just makes it clearer what it is.  (Not "pos" for Positive or what ever else it can be mistaken for.)
Many thanks,
-T

Adding return type is needed.
Changing style from lower case to sentence case (eg. $needle -> $Needle) will make this definition stylistically inconsistent with other documentation. I support keeping all variable names lower case.
surrounding the : after the invocant with whitespace to indicate it is different from say :D is a fundamental change in style that would affect all documentation. At this point, the marginal benefit seems much less than the hassle of altering it everywhere else. Besides, once a person has understood the pattern, the whitespace becomes irrelevant.
adding $haystack just to remind someone of the idiom seems like overkill. It raises other questions for a newbie user, eg. why is it given a special name when it isn't included in the method's calling signature?
expanding pos -> position. If there is to be change, then why not something more explanatory, such as '$starting-from' ?

I agree with your on most of these points except $haystack. There are other
methods where the invocant is renamed (words springs to mind after recent
discussions here) naming it $haystack makes the idiom easier to spot.
On Thu, 27 Sep 2018, 05:59 Richard Hainsworth<EMAIL_ADDRESS>wrote:

Adding return type is needed.
Changing style from lower case to sentence case (eg. $needle ->
$Needle) will make this definition stylistically inconsistent with other
documentation. I support keeping all variable names lower case.
surrounding the : after the invocant with whitespace to indicate it
is different from say :D is a fundamental change in style that would
affect all documentation. At this point, the marginal benefit seems much
less than the hassle of altering it everywhere else. Besides, once a person
has understood the pattern, the whitespace becomes irrelevant.
adding $haystack just to remind someone of the idiom seems like
overkill. It raises other questions for a newbie user, eg. why is it
given a special name when it isn't included in the method's calling
signature?
expanding pos -> position. If there is to be change, then why not
something more explanatory, such as '$starting-from' ?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/perl6/doc/issues/2334#issuecomment-424959419, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAE87iquM3LuuIP_rsv2otPOD5F6tgQ_ks5ufFsTgaJpZM4W7j_k
.

When the documentation says "defined as", it does literally what it says: it copies the definition from the source. In this case: https://github.com/rakudo/rakudo/blob/e54885e5e6d71bb6ab6d7f4eb86fe21dd9aee3de/src/core/Str.pm6#L175-L191
So changing the name of the variables to another one is not the usual way to do it. We can replicate the definition to make it more understandable, or otherwise explain it, but that's that. In that sense, as you see in the code I point to, the return type is not specified. That means just that: the only thing we know about "contains" is that it, apparently, returns a "Truish" value. The definition might be wrong, so what we do in these cases is to go to the test, in Roast: https://github.com/perl6/roast/blob/2288d4a3c543d72f822164dad529066ed055a0aa/S32-str/contains.t If it checks for a specific return value (like Bool), we can go back to Rakudo and request a change. But, as you can see in the source, it again just tests for a "Truish" value (that is, something that can be evaluated as True in a Boolean context).
So while I understand there's some need for clarification here, the code indicated can't be changed unless the source it's copied from is changed too. I propose to clarify the function of every parameter in the explanation, or simply replicate that definition to (maybe) make it clearer.

On 9/26/18 9:59 PM, Richard Hainsworth wrote:

Changing style from lower case to sentence case (eg. $needle ->
$Needle) will make this definition stylistically inconsistent with
other documentation. I support keeping all variable names lower case.

Fine with me.  I like it the other way, but I don't care that much.
I can type since I was 17 and upper and lower case fly off the
keyboard just as fast.  But, I do realize others "hunt and peck".
And, indeed it would break convention.

surrounding the |:| after the invocant with whitespace to indicate
it is different from say |:D| is a fundamental change in style that
would affect all documentation. At this point, the marginal benefit
seems much less than the hassle of altering it everywhere else.
Besides, once a person has understood the pattern, the whitespace
becomes irrelevant.

Don't always presume the reader knows things like that.  They
are going to the docs for a reason.  They are there to learn things.

adding |$haystack| just to remind someone of the idiom seems like
overkill. It raises other questions for a |newbie| user, eg. why is
it given a special name when it isn't included in the method's
calling signature?

If you use "needle" you also need to use "haystack".  Otherwise it
is insider information hidden from the reader.  "Needles" stick
things and go into pin cushions.  The reader wonders what you
are sticking.
If you do not use haystack along with needle, drop needle and
replace it with "substr".

expanding pos -> position. If there is to be change, then why not
something more explanatory, such as '$starting-from' ?

I like "Starting-from" even better.  Great idea.

The names of positional parameters is really only for human consumption.
So it does not matter if the names are different between Rakudo and the Docs.
Also the returns type isn't specified in Rakudo, but is (or should be) specified in ROAST.
So it should be specified in the Docs.
The main thing the docs should be concerned with, is that it follows ROAST.
(Which doesn't concern itself with the names of positional parameters, or invocants)

I don't see why it can't change to
multi method contains(Str:D $haystack: Cool:D $needle --> Bool:D)
multi method contains(Str:D $haystack: Str:D $needle --> Bool:D)
multi method contains(Str:D $haystack: Cool:D $needle, Int(Cool:D) $start-position --> Bool:D)
multi method contains(Str:D $haystack: Str:D $needle, Int:D $start-position -->Bool:D)

Really rather than show multiple multi methods it could be just:
multi method contains(Str:D $haystack: Str:D(Cool:D) $needle, Int:D(Cool:D) $start-position = 0 --> Bool:D)

If that is too long, we can split it into multiple lines
multi method contains(
  Str:D $haystack:
    Str:D(Cool:D) $needle,
    Int:D(Cool:D) $start-position = 0
  --> Bool:D
)

If the implementation had been written with just the one signature that was used above, then Rakudo will generate alternative multis, that just coerce the arguments.
(So calling Str.^lookup('contains').candidates».signature would return more signatures than were written.)
The only reason they are split up in Rakudo is for performance reasons.
(and that is getting to be less of an issue over time.)

El jue., 27 sept. 2018 a las 20:05, Brad Gilbert<EMAIL_ADDRESS>escribió:

The names of positional parameters is really only for human consumption.
So it does not matter if the names are different between Rakudo and the
Docs.

But it does. It's simply the convention we follow. As I say above, there's
nothing against making a redefinition in the text. But "Defined as" is not
a creative interpretation of the definition. Is the definition. This is
the reference part of the documentation, and that is the convention that is
followed.

Also the returns type isn't specified in Rakudo, but is (or should be)
specified in ROAST.

It can or can not specify the return type, depending on how it's defined.
If the specification says it should return a Bool, roast follows that.
That's not the case. The specification is ambiguous at this point, simply
saying something that is evaluated to True. We don't know why, but that's
how it's defined, and "Defined as" is "defined as"

So it should be specified in the Docs.

The specs in roast do not test for it specifically returning a Bool; it
tests for it returning something that can be coerced to Bool. The Docs, far
as I see it, shouldn't interpret creatively (or for the sake of the user) a
method or sub definition where the definition is to be copied. It can be
explained in the text, but not in that particular part.

The main thing the docs should be concerned with, is that it follows ROAST.

Which they do. Roast tests, in this case, test for a "truish" value, not
for it being of type Bool.

(Which doesn't concern itself with the names of positional parameters, or
invocants)

(it concerns with being faithful to their definition in the source).

I don't see why it can't change to
multi method contains(Str:D $haystack: Cool:D $needle --> Bool:D)multi method contains(Str:D $haystack: Str:D $needle --> Bool:D)multi method contains(Str:D $haystack: Cool:D $needle, Int(Cool:D) $start-position --> Bool:D)multi method contains(Str:D $haystack: Str:D $needle, Int:D $start-position -->Bool:D)

There are two parts to that. First, the name of variables: can't be done
because that's not how it's written in the source. Then, the return value:
can't be done because see first, and because second, it's not what it
returns. Check the source, it returns a Truish value, which varies
depending on the implementation, being nqp::bool (if memory serves) in some
cases, Bool in some other case. All can be coerced to Bool, and that's
what's tested in roast.

Really rather than show multiple multi methods it could be just:
multi method contains(Str:D $haystack: Str:D(Cool:D) $needle, Int:D(Cool:D) $start-position = 0 --> Bool:D)

That's certainly something we could do. However, the "defined as" section
of the reference manual says how it's defined in the source verbatim. We
could add another section and name it "don't read above, we really mean
this" or "TL;DR above, this is the real thing". But a reference section
should be accurate and precise, and that is what we strive to do here.

If that is too long, we can split it into multiple lines
multi method contains(
Str:D $haystack:
Str:D(Cool:D) $needle,
Int:D(Cool:D) $start-position = 0
--> Bool:D
)

No we can't, since we actually test-compile those definitions and it will
fail if we split it in multiple lines. That's certainly something that can
be fixed, and in some cases multi-line definitions in Rakudo have to be
compressed to a single line. I'm afraid that's, however, a different issue.

If the implementation had been written with just the one signature that
was used above, then Rakudo will generate alternative multis, that just
coerce the arguments.

But it has not. Just check the implementation, linked in the above issue.
The only reason they are split up in Rakudo is for performance reasons.

The only reason why we list them all is because we list them verbatim as
they are in the Rakudo source.

(and that is getting to be less of an issue over time.)

If and when it changes, we'll try to reflect it in the "defined as" section
here.

On Thu, Sep 27, 2018 at 1:22 PM Juan Julián Merelo Guervós <
<EMAIL_ADDRESS>wrote:

El jue., 27 sept. 2018 a las 20:05, Brad Gilbert (<
<EMAIL_ADDRESS>escribió:

The names of positional parameters is really only for human consumption.
So it does not matter if the names are different between Rakudo and the
Docs.

But it does. It's simply the convention we follow. As I say above, there's
nothing against making a redefinition in the text. But "Defined as" is not
a creative interpretation of the definition. Is the definition. This is
the reference part of the documentation, and that is the convention that is
followed.

No it does not.
There have been plenty of times that the names of parameters have changed
in Rakudo, and they didn't change in the docs.
Because they do no matter.
There have been plenty of times that multi methods have been combined, or
split up without changing the docs.
Because it does not matter.

Also the returns type isn't specified in Rakudo, but is (or should be)
specified in ROAST.

It can or can not specify the return type, depending on how it's defined.
If the specification says it should return a Bool, roast follows that.
That's not the case. The specification is ambiguous at this point, simply
saying something that is evaluated to True. We don't know why, but that's
how it's defined, and "Defined as" is "defined as"

Rakudo is not Perl 6.
Rakudo is an implementation of Perl 6 because it passes ROAST.
The documentation is about Perl 6.
That's why there is a disagreement about whether to document Rakudo
specific features.

So it should be specified in the Docs.

The specs in roast do not test for it specifically returning a Bool; it
tests for it returning something that can be coerced to Bool. The Docs, far
as I see it, shouldn't interpret creatively (or for the sake of the user) a
method or sub definition where the definition is to be copied. It can be
explained in the text, but not in that particular part.

Zoffix has been going through the tests to improve them.
One of the improvements is to encode the result types.
He hasn't gotten to those tests yet.

The main thing the docs should be concerned with, is that it follows
ROAST.

Which they do. Roast tests, in this case, test for a "truish" value, not
for it being of type Bool.

ROAST doesn't concern itself with the names of the positional parameters.

(Which doesn't concern itself with the names of positional parameters, or
invocants)

(it concerns with being faithful to their definition in the source).

It concerns itself with being faithful to Perl 6, which is ROAST not Rakudo.

I don't see why it can't change to
multi method contains(Str:D $haystack: Cool:D $needle --> Bool:D)multi
method contains(Str:D $haystack: Str:D $needle --> Bool:D)multi method
contains(Str:D $haystack: Cool:D $needle, Int(Cool:D) $start-position -->
Bool:D)multi method contains(Str:D $haystack: Str:D $needle, Int:D
$start-position -->Bool:D)

There are two parts to that. First, the name of variables: can't be done
because that's not how it's written in the source. Then, the return value:
can't be done because see first, and because second, it's not what it
returns. Check the source, it returns a Truish value, which varies
depending on the implementation, being nqp::bool (if memory serves) in some
cases, Bool in some other case. All can be coerced to Bool, and that's
what's tested in roast.

Seriously who the fsck cares?
Certainly not the people who maintain Rakudo.
Because like I've stated, they have changed things without changing the
docs.
Again because it is about Perl 6, not Rakudo.

Really rather than show multiple multi methods it could be just:

multi method contains(Str:D $haystack: Str:D(Cool:D) $needle,
Int:D(Cool:D) $start-position = 0 --> Bool:D)

That's certainly something we could do. However, the "defined as" section
of the reference manual says how it's defined in the source verbatim. We
could add another section and name it "don't read above, we really mean
this" or "TL;DR above, this is the real thing". But a reference section
should be accurate and precise, and that is what we strive to do here.

Then we should change the wording, because the Perl 6 docs should be about
Perl 6, not a particular implementation.

If that is too long, we can split it into multiple lines

multi method contains(
Str:D $haystack:
Str:D(Cool:D) $needle,
Int:D(Cool:D) $start-position = 0
--> Bool:D
)

No we can't, since we actually test-compile those definitions and it will
fail if we split it in multiple lines. That's certainly something that can
be fixed, and in some cases multi-line definitions in Rakudo have to be
compressed to a single line. I'm afraid that's, however, a different issue.

There have been plenty of times that the tests changed.
This is not a good argument.

If the implementation had been written with just the one signature that
was used above, then Rakudo will generate alternative multis, that just
coerce the arguments.

But it has not. Just check the implementation, linked in the above issue.

So?

The only reason they are split up in Rakudo is for performance reasons.

The only reason why we list them all is because we list them verbatim as
they are in the Rakudo source.

Which is not useful to anyone.

(and that is getting to be less of an issue over time.)

If and when it changes, we'll try to reflect it in the "defined as" section
here.

The docs are for people to understand what functions do what.
Forcing them to be consistent with one particular implementation is not
useful to anyone.

If you had been around you would know that there has been a careful
distinction between Perl 6 and Rakudo for a very long time.
Since the docs are on docs.perl6.org, they should probably be on the Perl 6
side not the Rakudo side.
—

You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/perl6/doc/issues/2334#issuecomment-425194506, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAC86E0zLsWwt9VZ5T9_bGBP7Lg3lFczks5ufRdOgaJpZM4W7j_k
.

On 9/27/18 11:05 AM, Brad Gilbert wrote:

Really rather than show multiple multi methods it could be just:
multi  method  contains(Str:D  $haystack:  Str:D(Cool:D) $needle, Int:D(Cool:D) $start-position=  0  -->  Bool:D)

I really love the single line, rather than having to trudge through
four lines to figure out which one applies.
 for
optional parameters?  Something like "$start-position? = 0" and
that the default was 0.  Seems to me that it would make it very
clear what was happening.
multi  method  contains(Str:D  $haystack:  Str:D(Cool:D) $needle,
Int:D(Cool:D) $start-position? =  0  -->  Bool:D)
If the "?" convention is something you guys like, I can always request
it in a new RFE.  I think it really helps clarity things and keeps
from having to repeat the line over and over to state what is and
what is not optional
Also, is it necessary to use :D in Bool:D, as would it be very unusual
for a method to return a Nil?

On 9/27/18 12:34 PM, Brad Gilbert wrote:

The docs are for people to understand what functions do what.
Forcing them to be consistent with one particular implementation is not
useful to anyone.

I really like the idea to have a tab in the docs that is just for
Rakudo specific stuff.  This would remove any ambiguity as to what was
pure Perl and what was Rakudo specific.

El vie., 28 sept. 2018 a las 8:56, ToddAndMargo<EMAIL_ADDRESS>escribió:

On 9/27/18 12:34 PM, Brad Gilbert wrote:

The docs are for people to understand what functions do what.
Forcing them to be consistent with one particular implementation is not
useful to anyone.

I really like the idea to have a tab in the docs that is just for
Rakudo specific stuff. This would remove any ambiguity as to what was
pure Perl and what was Rakudo specific.

Let me just point out that the definition of a function is not an
implementation detail, it's the signature of the function and, as such,
part of the specification. As you have pointed out, there are several
possible signatures that might be compatible with the specification, as
well as the fact that they are implemented as a multi and not a single
function, which might be implementation details, but still, the fact that a
particular signature is actually spec has to be proved; the signatures in
Rakudo (which are the ones included in the documentation) have been
proved and are up to spec.

On 9/30/18 9:22 PM, Brad Gilbert wrote:

When people are reading the docs they care about how the function works
and how to call it.
They don't care that Rakudo uses 4 multis when one will suffice.
In fact it only serves to confuse them.
So by forcing the docs to conform to only the one implementation, the
documentation is worse than it could be.
This is the documentation for using Perl 6, not a document for how one
implementation decided to write it.
If they want that, they should just read the source code.

Hi Brad,
I agree with everything you said.
But, (ya you can't be that lucky), Rakudo is what virtually
everyone uses.  So why not a section dedicated to Rakudo
specific issues?  Maybe even ask the Rakudo folks to maintain it?
Yes, it is a compromise, but it is a practical compromise.
-T

FWIW I agree that docs should be based on roast not Rakudo.

As an example of the docs not having to match Rakudo source, Zoffix just changed the docs about Promise.keep and Promise.break.
@@ -222,8 +222,7 @@ creates a chained promise.
￼
  =head2 method keep
￼
-￼     multi method keep(Promise:D:)
-     multi method keep(Promise:D: \result)
+     multi method keep(Promise:D: \result = True)
￼
  Keeps a promise, optionally setting the result. If no result is passed, the
  result will be C<True>.
@@ -242,8 +241,7 @@ taken. See method C<vow> for more information.
￼
  =head2 method break
￼
-      multi method break(Promise:D:)
-      multi method break(Promise:D: \cause)
+      multi method break(Promise:D: \cause = False)
￼
  Breaks a promise, optionally setting the cause. If no cause is passed, the
  cause will be C<False>.

Even though the source hasn't changed.
    proto method keep(|) {*}
    multi method keep(Promise:D:) {
...
    multi method keep(Promise:D: Mu \result) {

...

    proto method break(|) {*}
    multi method break(Promise:D:) {
...
    multi method break(Promise:D: \result) {


[Question] Is .NET interactive interpret or compile the code?

If it is interpreted, will the performance be slower than the compiled.
Is there a document that briefly describes the principle without reading the source code.

It is compiled (runtime JIT compiled)

Does it compile each user input cell while each user press run cell?

Does it compile each user input cell while each user press Run Cell?

Yes

So how does the cells share runtime environment(variables, classes, etc..)?

So how does the cells share runtime environment(variables, classes, etc..)?

The implementations are language-specific so there are subtle differences. Broadly speaking, each time you submit a cell it compiles a new assembly referencing the previous one. Top-level code (including variables and classes) is shadowed if you redeclare something with a previously-used name. Consider these two submissions:
int x = 123;
public int GetX() => x;

string x = "hello";

In effect, the second submission declares a second variable of a different type. It's no longer possible to reference the original int x in a later submission, but because the GetX method was compiled against that original int x declaration, the later string x declaration is irrelevant to it, and GetX will always return 123.

Understood, thank you.


Add official example badge

@mikter Any idea why CI fails as this PR does not introduce a code change?

ERROR] /usr/local/gcc-arm-none-eabi-9-2019-q4-major/bin/../lib/gcc/arm-none-eabi/9.2.1/../../../../arm-none-eabi/bin/ld: out/KW41Z_GCC_ARM_internal_6lp/mbed-os/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/fsl_common.o: in function InstallIRQHandler': /builds/ws/mal_PR-308-2G222WDVXU56XCMT2PRK7@3/mbed-os-example-mesh-minimal/./mbed-os/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/fsl_common.c:61: undefined reference to __Vectors'
collect2: error: ld returned 1 exit status
@evedon This seems to be the error, but I have no idea what is causing it @artokin any ideas

what version of Mbed OS are you using it? The error is one we had when we updated cmsis, but was fixed in Mbed OS.

We had the same problem in the past: https://github.com/ARMmbed/mbed-os/issues/13062

Correct, the fix will be in 6.1 (as I can see was merged post 6.0), unfortunately.

@0xc0170 I think we should go ahead wit merging this PR as there is no code change.

@mikter  Please merge


Finding tangent line to circle at point

I figure this should probably be a built in function to Circle or Pt or Line. I'm implementing it myself now though

Thanks @tangert . That's a definitely a good function for Pts, and maybe also getting the 4 tangent lines between 2 circles.
I'll try to get to this soon. If you need it quickly, I think the simplest implementation would be using circle-circle intersection to find the 2 tangent points -- something like this:

Hi Tyler, I see -- seems like you're looking for something simpler.
If I understand correctly, I think a simple way is to get a vector from pointer to circle's center, and then find its orthogonal vectors. You can use Geom.perpendicular or just flip the vector (eg, (x, y) to (-y, x)). Quick sample code:
    let vec = space.pointer.$subtract( space.center );
    let r = vec.magnitude();
    let circle = Circle.fromCenter( space.center, r );

    let ortho = Geom.perpendicular( vec );
    ortho.add( space.center.$add( vec ) ); // add circle's position back

    form.strokeOnly("#fff").circle( circle ).line( [space.center, space.pointer] );
    form.stroke("#fe0", 3).line( ortho );

Take a look also at these demos which may be relevant to what you want to do:
https://ptsjs.org/demo/?name=geom.perpendicular
https://ptsjs.org/demo/?name=line.perpendicularFromPt
Some quick tips:

you can get a new Pt by space.pointer.$subtract( 0, radius ), instead of Pt.make( space.pointer.x, space.pointer.y - radius )
you can calculate the distance between two points by a.$subtract( b ).magnitude()
The Line class has slope and intercept functions if you need them

Hope these helps!

Awesome! That helps a lot. I tried using the perpendicular function earlier but couldn't get it to work- this makes it a lot more clear.


Thread names lost when using #title= hash fragment

With multi-threaded profiles, setting #title= turns every thread's name into the title, which makes them difficult to tell them apart. When there are multiple threads, I'd prefer if it kept the original thread names from the file, and just change document.title.
For example, when I want to look at MainThread here: https://www.speedscope.app/#profileURL=https%3A%2F%2Frawcdn.githack.com%2Fgjoseph92%2Fdask-profiling-coiled%2Fe48d1e07ff9ab9f61360e04b597d0b58c0e3e2c8%2Fresults%2Fcython.json%3Fraw%3Dtrue
It's harder to find here: https://www.speedscope.app/#profileURL=https%3A%2F%2Frawcdn.githack.com%2Fgjoseph92%2Fdask-profiling-coiled%2Fe48d1e07ff9ab9f61360e04b597d0b58c0e3e2c8%2Fresults%2Fcython.json%3Fraw%3Dtrue&title=cython
I imagine the change would just happen on this line:
https://github.com/jlfwong/speedscope/blob/b71cef5db4162e9cd871ad7a1bf5716fffabe5ff/src/views/application.tsx#L207
and maybe also https://github.com/jlfwong/speedscope/blob/b71cef5db4162e9cd871ad7a1bf5716fffabe5ff/src/views/application.tsx#L194-L199
If it's that simple, I'm happy to make a PR.

Haha oh wow, the current behavior seems pretty unhelpful for multithreaded profiles. (The #title functionality was built before multithreaded profiles were supported, and I never tested them together)
I'm not sure without spending more time in the code to know if it's as simple as that, but the #title=... is probably used little enough that changing its behavior is probably fine. I'd accept a PR to do this.


VPC API compatibility fix

@sameshai Can you add the new dp2 storage Classes in this repo?

@sameshai Can you add the new dp2 storage Classes in this repo?

done


Google + Facebook login not working

Hello, I cannot get both Google and Facebook login working on my application. Email login works just fine. Whenever I press on either Google or Facebook login button, the app's onActivityResult gets called with a null result. What can be wrong? Is there anything that i could be missing? I have gone through all the steps so I am not sure what could be wrong. Please get back to me ASAP as this is whats holding me back from releasing my app. Thanks!

@ryandailey100 Have you added all the xml strings with your app keys? Have you added the redirect URLs in the Firebase Auth console and keys. Have you added your SHA1 and SHA256 in the Firebase console?

I have added the both release and debug SHA1 keys to the Firebase console. I don't think I have added the xml strings. What file do I add the strings into?

@ryandailey100 See https://github.com/firebase/FirebaseUI-Android/tree/master/auth#identity-provider-configuration

Yes I have looked at it but it does not say where to add the text

Also that text wouldn't affect the Google sign in, as it is only for Facebook.

@ryandailey100 Oh, gotya. AAPT—or Android Asset Packaging Tool—doesn't actually care where you put them. When all your resources are compiled, they're actually stored in one big values.xml file with everything. However, standard convention is to put them in a config.xml file (but again, if you'd like to put them somewhere else that makes more sense to you go for it because it won't matter).
See the sample config.xml.

@ryandailey100 Yeah, for Google sign-in it should work as long as your app signing key and SHA1 match up. Can you check the logcat right after the sign-in fails? That should give us more detail as to what's going on.

This is the error I get when pressing Google signin:
FATAL EXCEPTION: main
Process: com.daileyproduction.collegelife, PID: 636
java.lang.NoSuchMethodError: No direct method (Ljava/lang/String;[Ljava/lang/String;)V in class Lcom/google/android/gms/internal/zzbga; or its super classes (declaration of 'com.google.android.gms.internal.zzbga' appears in /data/app/com.daileyproduction.collegelife-1/split_lib_dependencies_apk.apk)
at com.google.android.gms.auth.api.signin.internal.zze.(Unknown Source)
at com.google.android.gms.auth.api.signin.internal.zze.zza(Unknown Source)
at com.google.android.gms.auth.api.signin.internal.zzc.getSignInIntent(Unknown Source)
at com.firebase.ui.auth.provider.GoogleProvider.startLogin(GoogleProvider.java:156)
at com.firebase.ui.auth.ui.idp.AuthMethodPickerActivity$1.onClick(AuthMethodPickerActivity.java:127)
at android.view.View.performClick(View.java:5669)
at android.view.View$PerformClick.run(View.java:22549)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6290)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

Oh, you're mixing play services dependencies. Make sure to use FirebaseUI v2.3.0 and properly override our Firebase deps if nesassary.

Thanks so much! That did the trick. Both Facebook and Google Sign-In is now working on my app 👍 I noticed one side affect when updating Firebase Auth UI to 2.3.0. The sign-in buttons have shifted to the centre of the screen instead of the bottom. Is there anyway to place it back to the bottom?

Yeah, add your app's icon with setIcon(int). Otherwise we put them in the middle to minimize whitespace. See the sample:
https://github.com/firebase/FirebaseUI-Android/blob/5154ae058f5e276e87a896a78df7aa2802271997/app/src/main/java/com/firebase/uidemo/auth/AuthUiActivity.java#L201-L210

Oops, it's setLogo(int).

Great! Thanks for all the help 👍

NP!


Please add the functions for creating, deleting and editing nodes

Feature proposal
Hi!
Thanks for the convenient and useful addon!
Please add the functions for creating, deleting and editing nodes. It is very necessary for my project
Describe solution expectations
No response
Additional information
No response

According to OrgChart documentation we could implement the feature with these methods (example)


⚠ PrivateHD has degraded performance

In 27a5ce6, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 2330 ms

Resolved: PrivateHD performance has improved in 0e32c74.


Need to investigate the slowness of testSymmetricKey & testCompactEncryptedDB tests on Android 4.x devices

Samsung S3 Android 4.1.2

testCompactEncryptedDB: 4sec
testCompactEncryptedDB: 3sec
testSymmetricKey: 4sec
testSymmetricKey: 4sec

Above test cases don't contains wait/sleep codes in the test. It could be faster.

Fixed by f50f9a6d00cd3c0e95d7ac7585fe16b2bc5d13ae, e925ee4d8023f5f5695202b8cad0afa40ac11860, https://github.com/couchbase/couchbase-lite-android/commit/743027e40b61059db0c49f991e9803d1aa671460
Running on Nexus 4 Emulator with API 19.
DURATION: testCompactEncryptedDB: 1sec
DURATION: testSymmetricKey: 0sec


No notifications on debian 10

I followed the manual instrunctions from the readme:
> curl -Lo ~/.config/fish/conf.d/done.fish --create-dirs https://raw.githubusercontent.com/franciscolourenco/done/master/conf.d/done.fish

Even after logging in again sleep 6 doesn't lead to a notification. I have no clue what I have done wrong, or what part isn't working. I would be happy if you can help. Thanks for your time.
System information:

Debian 10
With Gnome
tried fish version 3.0.2 and 3.1.2 from backports

> echo $__done_version
1.15.0

Edit:
notify-send test leads to a notification

@strct I just installed Debian 10.9.0 and notify-send on a VM, but can't even get a notification with notify-send test. How did you configure notify send?

I didn't notice notify-send isn't installed by default. I tried to create a minimal environment (i have set up a virtual machine now as well).
On this machine I installed Debian 10.9.0 with the Gnome desktop environment (gnome-shell). Then as root apt install libnotify-bin curl fish to install notify-send.
Now notify-send test produces a notification when run from the logged in user.
Configure fish with the command:
curl -Lo ~/.config/fish/conf.d/done.fish --create-dirs https://raw.githubusercontent.com/franciscolourenco/done/master/conf.d/done.fish

Reboot to ensure config files get read (logout+login might be sufficient).
user@debian:~$ fish
Welcome to fish, the friendly interactive shell
user@debian ~> sleep 6
user@debian ~> notify-send test
user@debian ~> echo $__done_version
1.15.0

sleep 6 didn't produce a notification, but notify-send did.

The error is in https://github.com/franciscolourenco/done/blob/master/conf.d/done.fish#L83 which throws TypeError: global.display.focus_window.get_it is not a function
I don't have time to debug this at the moment since I don't use Debian, but a PR would be more than welcome :)

No notifications in Fedora 35 either.
It's probably related to the enhanced security measures on some DBus calls in GNOME 41: https://unix.stackexchange.com/a/635740/50281

No notifications either for me on Manjaro with Gnome, worked when I was using XFCE a few weeks ago.
notify-send works as usual. I'm using sleep 6 to test.

Workaround: use a gnome extension to expose Eval.
Extension: https://github.com/manu156/eval-gjs
Also modify done.fish to use this:
gdbus call --session --dest org.gnome.Shell --object-path /dev/ramottamado/EvalGjs --method dev.ramottamado.EvalGjs.Eval 'global.display.focus_window.get_id()'
However this will introduce security risks probably or whatever reason https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3943

Looks like the same root cause as #134

https://github.com/franciscolourenco/done/releases/tag/1.19.0 added an option to enable notifications on Wayland while using the Kitty terminal. Thanks @jinliu!


Sanitize numpy generics in keys

Fixes WB-9464
Description
Testing
How was this PR tested?
Checklist

Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

I was thinking about this and I think we can use functools.singledispatch and register all the transformations.
The only ugly part is that some of the dispatches will be conditional on import... but the code will be much more readable:
from functools import singledispatch
import numpy as np

@singledispatch
def json_serializable(object):
      raise TypeError

@json_serializable.register(dict)
def _(d):
      return {json_serializable(k): json_serializable(v) for k, v in d.items()}

@json_serializable.register(np.generic)
 def _(value):
        return value.item()


Update Practice Positive Communication section

Update wording for communication section to move away from solutions towards positive communication.

Hmmm, my recollection is that we mostly liked the wording of the value blurb, it was more that the "headline" didn't accurately reflect what the blurb was saying and was also using words that we didn't totally agree with.

I recall that we did discuss changing some of the language that was focused on solutions and outcomes, and I did write down the phrase "move toward collective action."


Need to pin x264

We are going to be affected by https://github.com/conda-forge/ffmpeg-feedstock/issues/49

All fixed


Angular onChange issue

Issue type
I'm submitting a (check one):
[x ] Bug report
[ ] Feature request
[ ] Regression (something that used to work, but stopped working in a newer version)
[ ] Support request
[ ] Documentation issue or request
Current behavior
onChanges is firing on every tick
Expected behavior
Should fire when form is changes

This is more an angular logic thing.

This is more an angular logic thing.

@trsh what did you meant with this? Is there any opportunity to listen on real changes of the form (only if inputs are really changed?)

@stretau
I don't remember exactly, but I had a recursion thing going on. Sorry.


docs: Add a note about img tag in media-poster-image.mdx

This doc change is inspired by the comment by @luwes here:
https://github.com/muxinc/media-chrome/issues/904#issuecomment-2104699433
PS: Maintainer edits are allowed. Feel free to change the text as you see fit.

Thanks for the contribution!


File not found for module version, and couldn't read hal_bindings.rs (os error 2)

These past few days, I have been fiddling around with pulling in this project, to no success. I added wpilib as a dependency like so:
wpilib = { git = "https://github.com/first-rust-competition/first-rust-competition", package = "wpilib" }

But, on compilation, I get the following error(s):
❯ cargo r
   Compiling wpilib-sys v0.4.0 (https://github.com/first-rust-competition/first-rust-competition#3fb3d672)
error[E0583]: file not found for module `version`
  --> /home/bob/.cargo/git/checkouts/first-rust-competition-8a2dacc6f3073934/3fb3d67/wpilib-sys/src/lib.rs:16:1
   |
16 | mod version;
   | ^^^^^^^^^^^^
   |
   = help: to create the module `version`, create file "/home/bob/.cargo/git/checkouts/first-rust-competition-8a2dacc6f3073934/3fb3d67/wpilib-sys/src/version.rs" or "/home/bob/.cargo/git/checkouts/first-rust-competition-8a2dacc6f3073934/3fb3d67/wpilib-sys/src/version/mod.rs"

error: couldn't read /home/bob/.cargo/git/checkouts/first-rust-competition-8a2dacc6f3073934/3fb3d67/wpilib-sys/src/./hal_bindings.rs: No such file or directory (os error 2)
  --> /home/bob/.cargo/git/checkouts/first-rust-competition-8a2dacc6f3073934/3fb3d67/wpilib-sys/src/bindings.rs:21:1
   |
21 | include!("./hal_bindings.rs");
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: this error originates in the macro `include` (in Nightly builds, run with -Z macro-backtrace for more info)

For more information about this error, try `rustc --explain E0583`.
error: could not compile `wpilib-sys` due to 2 previous errors

I am building on WSL, so it's possible that this is related to #85, but after reading the changes made, I doubt it. I'm curious if anyone else can compile the crate, considering that it's an internal error.
Here is the directory in question:
   inode Permissions Links Size Blocks User Date Modified Git Name                inode Permissions Links Size Blocks User Date Modified Git Name          inode Permissions Links Size Blocks User Date Modified Git Name
33913641 .rw-r--r--      1 1.3k      8 bob   6 May 14:31   --  bindings.rs    33913643 .rw-r--r--      1  535      8 bob   6 May 14:31   --  lib.rs
33913642 .rw-r--r--      1 5.6k     16 bob   6 May 14:31   --  hal_call.rs    33913644 .rw-r--r--      1 2.8k      8 bob   6 May 14:31   --  usage.rs

Thanks in advance.

This project is not designed to be pulled in as a git dependency. You need a local checkout of the repo and then generate the hal_bindings.rs by running hal-gen.

The bindings are included in the published crate, just not in the git repo.
Having a prepublish script seems like the way to go. We definitely don't want the binaries in the git repo, so need a prepublish step either way. The WPILib HAL headers are luckily written nicely enough that we haven't found the need to hand-roll the bindings.

Is it possibly preferable to build the bindings in a build.rs? I just want to depend on the newest features (e.g. IterativeRobot) without much hassle.

We tried that, and realised that requiring teams have clang installed to build would be annoying, when they would otherwise just require a Rust toolchain and the roboRIO toolchain for the linker.


Camera radar vs steering angle

At high steering angles 100-400° detected objects should be ignored at a distance where the car will safely pass the object.
How to reproduce or log data
Drive at low speed and turn into a road with parked traffic on both sides.
Expected behavior
If the object is inside the view of the camera. Reduce the distance of detectable objects with steering angle. I.e. if making a U-turn with steering angle at 400°. Do not brake for an object 10m away as this object will not be reached at that steering angle.
** Device/Version information (please complete the following information):**

Device: EON/EON Gold
Version: 0.6.6
Car make/model: all with low speed engagable and longitudinal control.

This is one of the many problems inherent to ACC type longitudinal control. Will be fixed as e2e longitudinal control gets phase in


unmatched function parameter order in hard nms

https://github.com/happyharrycn/actionformer_release/blob/4e3a02b7aa0c7805e81a20bc1b6803e1baf72d71/libs/utils/nms.py#L11-L12
https://github.com/happyharrycn/actionformer_release/blob/4e3a02b7aa0c7805e81a20bc1b6803e1baf72d71/libs/utils/nms.py#L170-L171
cls_idxs, scores are in opposite order

Thank you for finding this bug in our code, we will fix the bug soon.


invalid_redirect_uri_parameter exception

Summary
I'm using spring stack (Spring Boot 2.0.0.RELEASE) for creating a site that delegues user authentication/registration to Google via OAuth2. It is implemented as a few Spring Cloud microservices with a Zuul gateway running on port 8080.
  Google OAuth2
      |
      |
    Gateway   (:8080)
     /   \
    /     \
   /       \
Other      Client

I use Google as an OAuth2 server, and use spring-security-oauth2 as a client. If all my cloud is deployed at localhost everything works fine. But if my microservices are deployed at AWS Elastic Beanstalk, OAuth login doesn't work.
Actual Behavior
My application uses Google for registering and authenticating users. Currently I have a test environment running in AWS Elastic Beanstalk. When the Google's callback hits my application at AWS I get the following exception (from the logs):
org.springframework.security.oauth2.core.OAuth2AuthenticationException: [invalid_redirect_uri_parameter]
	at org.springframework.security.oauth2.client.authentication.OAuth2LoginAuthenticationProvider.authenticate(OAuth2LoginAuthenticationProvider.java:117) ~[spring-security-oauth2-client-5.0.3.RELEASE.jar!/:5.0.3.RELEASE]
	at org.springframework.security.authentication.ProviderManager.authenticate(ProviderManager.java:174) ~[spring-security-core-5.0.3.RELEASE.jar!/:5.0.3.RELEASE]
...

Taking a look at the sources I found that the issue seems to be in the following check in the org.springframework.security.oauth2.client.authentication.OAuth2LoginAuthenticationProvider class:
if (!authorizationResponse.getRedirectUri().equals(authorizationRequest.getRedirectUri())) {
    OAuth2Error oauth2Error = new OAuth2Error(INVALID_REDIRECT_URI_PARAMETER_ERROR_CODE);
    throw new OAuth2AuthenticationException(oauth2Error, oauth2Error.toString());
}

To check why this comparison is failing I checked the requests and responses using Chrome's developer tools. So, this is the call to Google:
https://accounts.google.com/o/oauth2/v2/auth?response_type=code&client_id=[REMOVED]&scope=profile%20email&state=[REMOVED]&redirect_uri=https://[REMOVED]/auth/login/oauth2/code/google
And this is Google's callback:
https://[REMOVED]/auth/login/oauth2/code/google?state=[REMOVED]&code=[REMOVED]
However, Spring Security is rejecting the user authentication because request and response redirect_uris are not matching.
I found the same problem on StackOverflow but with Facebook Oauth login, and it is still not solved yet.
Expected Behavior
While running microservices at localhost everything is ok.
Configuration
server:
  port: 5000
  servlet:
     contextPath: /auth
  use-forward-headers: true

spring:
  security:
    oauth2:
      resource:
        filter-order: 3
      client:
        registration:
          google:
            client-id:  [REMOVED]
            client-secret: [REMOVED]
            redirect-uri-template: ${AWS_CLOUD_URI:http://localhost:8080}/auth/login/oauth2/code/google
            scope: profile,email

Version

Spring Boot 2.0.0.RELEASE
Spring Security OAuth2 Client 5.0.3.RELEASE

@jgrandja could you tell me, please, is there any way to log OAuth2LoginAuthenticationProvider in a way to find out vaules of redirect_uri ?

@ayulit We need to add logging in the oauth2 modules so there is no way at the moment. I have logged this issue.
Also, can you please log this issue in the Spring Security GitHub Issues. Please provide information/links to where I can register the oauth client with AWS Elastic Beanstalk. Is this service free?
I will set it up on my end and see if I can reproduce the issue.
Thanks.


wifi-qr: init at 2023-04-19

Description of changes
I had this packaged in an overlay for much too long, finally adding it upstream.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Converting to draft as upstream updated their repo since I had packaged this and moved their files around...

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3056

Result of nixpkgs-review pr 266102 run on x86_64-linux 1

2 packages built:

wifi-qr
wifi-qr.man

@ofborg eval

Result of nixpkgs-review pr 266102 run on x86_64-linux 1

2 packages built:

wifi-qr
wifi-qr.man

LGTM, thanks!


Clarify what is done with X-WOPI-InvalidFileNameError

Is this message shown to the user?

I think this is just logged by Office Online. @chrisbro-MSFT, can you confirm?

If it's a rename and the filename the user chose is invalid, they should send an X-WOPI-InvalidFileNameError with a non-empty value. We'll log that value (to help with debugging) but it won't get displayed to the user.


[WIP] Make appveyor work again

These compatibility changes make bandit work with old versions
of Visual Studio (and gcc) such that appveyor is successful.

The commit is inspired by #75 by @Stefantb but all things are solved differently;
except for the CMake configuration of snowhouse which makes perfectly sense.
I'd suggest to accept @Stefantb's pull request for snowhouse, then I have to change the
last two commits to use the original updated snowhouse. Then I can remove the
[WIP] marker and this pull request can hopefully be merged.


Update Bedrock.ts to support apiBase and headers from config.json file

Description
Deployments inside security-conscious organizations often require the use of alternate endpoints (usually proxies) and custom headers (to be added to the HTTP request before it reaches the endpoint).
[ What changed? Feel free to be brief. ]
We extend the code at core/llm/llms/Bedrock.ts for the BedrockRuntimeClient to

support endpoint in the constructor in order to pass an apiBase parameter from config.json.
support new headers defined in config.json, using middlewareStack.add

Checklist

[X] The base branch of this PR is dev, rather than main
[X] The relevant docs, if any, have been updated or created

The change add two functionalities that already exist for other LLMs (e.g. Anthropic.ts).
Screenshots
N/A
Testing
This is not a new feature.
The code was tested against a Bedrock deployment. The change does not affect the behavior.
The apiBase change and the insertion of new headers were tested locally by redirecting to <IP_ADDRESS>.
During the testing, we identified an issue when headers to be inserted contain an underscore.
It makes AWS SigV4 return the following error:  "The request signature we calculated does not match the signature you provided." Using headers that don't contain "_" avoids the issue. A note was added to the code.

@sahuguet should we update the bedrock imported model and embeddings integrations as well?


Cannot use the component twice

Hello,
First of all, thank you and congratulations for developing this component, it is really useful to have it in Angular 2.
The problem is that I need to use it in different parts in the application and in the same page, but when I do it the component disappears.  I get no error in the console or in the server log. I am just call it in the template code of two different components that are in the same page and no google sign in component is shown.
Thank you in advance.
Regards.

@Arf291, thanks for reporting this. Sorry for a delay, I am pretty busy right now but will look into this issue ASAP.

Hi! I will look into it this weekend, bare with me!


Updated git-in-here.yml #hacktoberfest2023

PR Type: ___

Affiliation: N/A

Ticket: N/A

Checklist:

[x] I've read Contributing Guidelines
[x] I agree to follow the Code of Conduct

You've made a typo in your name.
pratikumar399 instead of pratikkumar399
Do you want to correct that?

Yes , sorry for the typo..


Add swagger specification for trusted security partner resource

Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.
[ ] The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

Can one of the admins verify this patch?

/azp run automation - sdk

/azp run automation - sdk

@ishaniGupta27 Please fix ci failures

@ishaniGupta27 - is this PR still relevant. If not can you please close this. I am removing the ARM review labels for now. please add back in case you need to get this reviewed.


Class based approach

Currently for every function, you need to pass api key as arguement which is not a sound approach. By looking into the code, I found that functions are classified as details, financial statements, and so on. Creating class for every component (details, financial_statements, ratios,..) will avoid us to pass api keys for every method / function and just need the instance of the class with api key as arguement.
Example:
ratios = Ratios(api_key)
ratios.financial_ratios(ticker)

This is a great and logical approach indeed. As I currently do not have the time available to refractor the code, I'd like to invite you to look into this and create a PR.

I am currently working on an upgrade of the package. That will take some time but it will be class based!

Fine then!


Problems creating a trivial function from a Docker image

The use case here is to create a function from a Docker image hosting a simple unix command - in this case it's just stuff supported by busybox.
The tutorial here https://fnproject.io/tutorials/ContainerAsFunction/ doesn't actually seem to answer the question as it's actually based on fnproject/node and I note a require('@fnproject/fdk') and that example seems more about extending an image to include the required packages such as imagemagick.
What I tried was a trivial Dockerfile
FROM alpine:latest

# wc - print newline, word, and byte counts for each file
# With Alpine we don't need to explicitly install anything as wc is
# provided by busybox.
CMD /usr/bin/wc

and func.yaml
schema_version: 20180708
name: wordcount
version: 0.0.1
runtime: docker
triggers:
- name: wordcount
  type: http
  source: /wordcount

I next created an app and ran deploy
fn create app wordcount
fn --verbose deploy --app wordcount

The container gets created fine and I can run wc directly in Docker as follows (where docker-mint.local:5000 is my local simple registry which I've used happily for other functions):
echo -n $'some\nlines\nof\ntext' | docker run --rm -i docker-mint.local:5000/wordcount:0.0.2
        3         4        18

When I try to invoke as a function though:
echo -n $'some\nlines\nof\ntext' | fn invoke wordcount wordcount

I get:
Error invoking function. status: 502 message: container failed to initialize, please ensure you are using the latest fdk / format and check the logs

TBH the documentation relating to the "default container contract" seem a little sketchy though there did seem to be an implication that containers reading from stdin and writing to stdout could be used.
Now as it happens I have also tried hotwrap and replacing the above with a Dockerfile that looks like:
FROM alpine:latest

# Install hotwrap binary
COPY --from=fnproject/hotwrap:latest /hotwrap /hotwrap

# wc - print newline, word, and byte counts for each file
# With Alpine we don't need to explicitly install anything as wc is
# provided by busybox.
CMD /usr/bin/wc

# update entrypoint to use hotwrap, this will wrap the command
ENTRYPOINT ["/hotwrap"]

and func.yaml
schema_version: 20180708
name: wordcount-hotwrap
version: 0.0.1
runtime: docker
triggers:
- name: wordcount-hotwrap
  type: http
  source: /wordcount-hotwrap

Then creating app and deloying
fn create app wordcount
fn --verbose deploy --app wordcount

To run directly from Docker I have to do:
echo -n $'some\nlines\nof\ntext' | docker run --rm -i --entrypoint=/usr/bin/wc docker-mint.local:5000/wordcount-hotwrap:0.0.2
        3         4        18

which isn't totally unexpected given the hotwrap entrypoint and if I just do:
echo -n $'some\nlines\nof\ntext' | docker run --rm -i docker-mint.local:5000/wordcount-hotwrap:0.0.2

I get
url scheme must be unix with a valid path, got:

Is there a way to pass input directly to the hotwrap entrypoint to test directly from a Docker container?
But in any case invoking properly I get:
echo -n $'some\nlines\nof\ntext' | fn invoke wordcount wordcount-hotwrap
        3         4        18

Which is what I'd expect.
So basically I'd like to understand whether one must use hotwrap for the scenario of executing a command from an arbitrary container? If that's the case then fair enough but I do think that the title of the "Creating a Function from a Docker Image" tutorial at https://fnproject.io/tutorials/ContainerAsFunction/ is a tad misleading as that really seems to be extending an FDK image rather than creating a function from a Docker Image - yes I know that technically it is but I certainly interpreted the title as implying a fairly arbitrary image.
If I've misunderstood things I'd be grateful for any pointers as to what I might be doing wrong with my original Dockerfile/func.yaml to get them to deploy as a non-hot function.
MTIA

@fadams I think this is resolved from #1496 with the exception of the tutorial being a bit misleading? I'm trying to think what to do about it, after reading the page I've come to the conclusion that we never explicitly state that functions still need to use an FDK (hence some of the confusion), and we also never explicitly mention hotwrap as an alternative to using an FDK anywhere there, either. I think the jury is out on whether we've wanted to officially support hotwrap, it does seem worth mentioning at least, though.
here's some instructions here for debugging a container locally, we're also undecided about surfacing this (in a lot of ways, it's easier to get users to run things against fn so that we can more easily debug with them, so we're not sure about recommending/supporting this really, but you may find it useful):
Make a directory to be the UNIX socket filesystem
mkdir iofs
Launch the function in your local docker instance
docker run -d --name function --rm -e FN_FORMAT=http-stream -e FN_LISTENER=unix:/iofs/lsnr.sock -v ${PWD}/iofs:/iofs <function-image>:<image-tag>
Launch a client container (this can be skipped if running docker locally on linux)
docker run -it --rm -v ${PWD}/iofs:/iofs oraclelinux:7-slim
Invoke the function using curl
curl -v --unix-socket –unix-socket ${PWD}/iofs/lsnr.sock -H "Fn-Call-Id:<PHONE_NUMBER>000000" -H "Fn-Deadline: 9999-01-01T00:00:00.000Z" http://function/call
Cleanup
Kill the function container
docker kill function
Remove the iofs directory
rm -rf iofs

Hi @rdallman, yes I think what you observe is the real issue. Whilst clearly for a great many use cases using a language+FDK is the sensible thing I'm struck by the increasing number of use cases I seem to be thinking of where running some unix commands seems to be more logical. I think that the https://fnproject.io/tutorials/ContainerAsFunction/ is kind of a case in point - why the heck would I want to run node.js just to call the ImageMagick CLI, or ffmpeg or whatever. Either using the CLI on its own or using a simple bash script in combination with jq and curl if I want to do a bit of JSON parsing is the sort of thing I'd tend to do locally so I'm not sure I'd wish to overcomplicate that when running a function.
So yeah I've seen in a few places implications of "bring your own container" but the implication of your response is that some sort of FDK is required. TBH I'm cool with that, but I do think that the documentation is then quite confusing and I also think that hotwrap is a much more natural way to expose a sort of BYOC pattern than an example using node.js. TBH I actually think that the use case the node example is illustrating is subtly different - to me that is mostly showing how one would go about extending a node.js FDK container to include package dependencies. That's absolutely fine and useful but I really think that the tutorial title is quite misleading in that case.
As you say in your first paragraph it would be good to explicitly mention the need to use an FDK and also perhaps to "promote" the hotwrap quickstart into the tutorials section (and I'm tempted to say change CMD /usr/bin/wc -l to CMD ["/usr/bin/wc -l"] as per my observations in https://github.com/fnproject/fn/issues/1496).
On "I think the jury is out on whether we've wanted to officially support hotwrap" well, as I say above I think that there are a number of use cases where doing what it supports seems massively more logical than using another language to simply wrap something that already has a perfectly decent CLI so I'd hope that not officially supporting hotwrap actually means officially supporting something with equivalent behaviour.
Thanks for the instructions on debugging the container locally, that's cool. I'd agree with your observations about a project preference to get users to run things against fn, but when debugging it's often useful to have a number of alternative levers to pull. For example in https://github.com/fnproject/fn/issues/1496 none of my issues turned out to be anything at all to do with Fn per se and was more about the quirks of container entrypoints, I suspect I'd have clocked that sooner had I has those instructions, so I think this stuff is really helpful.
Thanks again for all your help and responses, I do appreciate it!

Thanks for the details writeup of your thoughts @fadams. I'm creating an issue to track the potential promotion of hotwrap or some other documentation for BYOC here: https://github.com/fnproject/docs/issues/74
I totally agree with your sentiment that bringing a container for stuff like you point out above is a first class pattern and thus should have easy-to-understand docs.


S15-11 - gh actions for constructing flanders's files

Solved by https://github.com/pietercolpaert/dcat/commit/caa2ee08ec4eab0f2550c0af59a6652eda2a100a instead


Support 'use strict'

I'd have to look back at exactly what I was doing. But last night when I was coding it was throwing an error stating something about undefined index. When I removed 'use strict' from my file it worked without an error. When I dug into the code and added what is in the pull request and then put back in 'use strict' the code ran again without an issue.
In the end I think there was actually a fault in what I was sending into the deepmerge function. Though both variables being sent in were objects with sub-objects. The source contained keys the target didn't and the target contained keys the source didn't.
To be honest I've been programming javascript for over a decade but just recently been getting into node. I know with other languages doing "!target[key]" will generally throw errors as it's short hand and not actually code for checking if a variable is present. IE what the pull request does.

properties of type undefined are coerced by the ! operator to have the same functionality no? Your code Attempts to check the property anyway, potentially you were looking for hasOwnProperty?


JacksonAdapter.createDefaultSerializerAdapter().deserializeHeader - unreported exception java.io.IOException; must be caught or declared to be thrown

Looks like JacksonAdapter.createDefaultSerializerAdapter().deserializeHeader can throw an io exception, but the code isn't trapping it.
Error:
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project digitalocean-api: Compilation failure
[ERROR] /home/halkeye/go/src/github.com/jenkinsci/digitalocean-client-gen/src/main/java/com/digitalocean/api/models/TagsCreateHeaders.java:[46,47] unreported exception java.i
o.IOException; must be caught or declared to be thrown

generated via
autorest -- client_gen_config.md \
        --generate-samples \
        --generate-tests \
        --use<EMAIL_ADDRESS>\
        --use<EMAIL_ADDRESS>\
        --package-version="dev" \
        --input-file=./DigitalOcean-public.v2.yaml

I'm guessing the code is https://github.com/Azure/autorest.java/blob/a22230ec524b561b934a5bb2c373db43a61204fc/javagen/src/main/java/com/azure/autorest/template/ModelTemplate.java#L885-L887
spec file: https://api-engineering.nyc3.digitaloceanspaces.com/spec-ci/DigitalOcean-public.v2.yaml
My generated code:
 36   │     // HttpHeaders containing the raw property values.
 37   │     /**
 38   │      * Creates an instance of TagsCreateHeaders class.
 39   │      *
 40   │      * @param rawHeaders The raw HttpHeaders that will be used to create the property values.
 41   │      */
 42   │     public TagsCreateHeaders(HttpHeaders rawHeaders) {
 43   │         if (rawHeaders.getValue("x-request-id") != null) {
 44   │             this.xRequestId =
 45   │                     JacksonAdapter.createDefaultSerializerAdapter()
 46   │                             .deserializeHeader(rawHeaders.get("x-request-id"), UUID.class);
 47   │         }
 48   │         this.ratelimitLimit = Integer.parseInt(rawHeaders.getValue("ratelimit-limit"));
 49   │         this.ratelimitRemaining = Integer.parseInt(rawHeaders.getValue("ratelimit-remaining"));
 50   │         this.ratelimitReset = Integer.parseInt(rawHeaders.getValue("ratelimit-reset"));
 51   │     }

@alzimmermsft on the ctor with HttpHeaders.

I'll get this fix right away. I'll add another check for UUID in the creation block to fix it using JacksonAdapter when it isn't needed and also add a try/catch if Jackson is used.

Lemme know if you want me to test a branch or anything.
Thanks a lot for the rapid response. I feel better knowing its a real bug

Thanks @halkeye, I've opened PR #1706 which should fix this issue.

(putting in both issue and pr, dont know where is useful to you)
gh repo clone Azure/autorest.java
gh pr checkout 1706
mvn package -P local -DskipTests # cause i was having trouble running eclipse language server
# change directory
autorest -- client_gen_config.md \
        --generate-samples \
        --generate-tests \
        --use<EMAIL_ADDRESS>\
        --use:/home/halkeye/go/src/github.com/jenkinsci/autorest.java \
        --package-version="dev" \
        --input-file=./DigitalOcean-public.v2.yaml

gives me https://gist.github.com/halkeye/1ab17c281587a8f99990336b40233064
Got an error The incoming YAML document exceeds the limit: 3145728 code points.
fatal   | Process() cancelled due to failure
error   |   Error: Plugin preprocessor reported failure.
error   | Autorest completed with an error. If you think the error message is unclear, or is a bug, please declare an issues at https://github.com/Azure/autorest/issues with the error message you are seeing.

which I don't get with --use<EMAIL_ADDRESS>


Data Science With python:Introduction to plotly and cufflinks

Description
Briefly explaining the topic using example and code snippet.
Domain
Datascience with Python
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

@prathimacode-hub
mam please assign me this issue

I would like to contribute.
Full name: Sanjana Alaham
Batch Number: 19
GitHub Profile Link: https://github.com/sanjana-iyengar
Contribution: Documentation

I would want to contribute.
Name: Shreya Rai
Serial no:155
Batch:5
Approach : Theory explaining the topic along with examples.
type:Documentation

/assign


After zooming in no map is visible.

Please note: issues related to or caused by osmbonuspack will be closed with a
suggestion to open an issue at https://github.com/MKergall/osmbonuspack
(feel free to delete whatever doesn't apply)
Issue Type
[X] Bug
Description and/or steps/code to reproduce the problem
When I open the app, I open the first map view.
Then, I scroll using the fingers.
Then, I see white squares.
Environment
Diagnostics -> Permission all to yes
Extrernal Storage State: not available
If it's a bug, version(s) of android this affects:
Android 2.3.5
Version of osmdroid the issue relates to:
6.0.1 release

is that correct? you are using android version 2.3.5? Ginger bread? It's possible some newer APIs have sneaked in there. While the min sdk is 8, we've stopped testing on it since android pulled all the avd's for the earlier versions. I'll see if i can get the genny motion vm running for 2.3.7. It's the oldest they have

nope you are out of luck, earliest image i have with geny is 4.1. Sorry. Best i can offer is turn on debugging and watch logcat to see if there are any obvious problems

reopen if it's still a problem, although there isn't much we can do about it. update your device?


[TEST]Nuitka standalone test for Click PyPI package

Click is a python package that supports arbitrary nesting
of commands, automatic help generation and lazy loading
of subcommands at runtime.
The Click package is tested by checking that click.option()
and click.echo() work as expected
This commit contributes to https://github.com/Nuitka/Nuitka/issues/229
Signed-off-by: tab1tha<EMAIL_ADDRESS>Thank your for contributing to Nuitka!
!! Please check that you select the develop branch (details see below link) !!
Before submitting a PR, please review the guidelines:
https://github.com/kayhayen/Nuitka/blob/master/CONTRIBUTING.md
What does this PR do?
Why was it initiated? Any relevant Issues?
PR Checklist

[x] Correct base branch selected? develop for new features and bug fixes too. If it's
part of a hotfix, it will be moved to master during it.
[x] All tests still pass. Check the developer manual about Running the Tests. There
are Travis tests that cover the most important things however, and you are
welcome to rely on those, but they might not cover enough.
[x] Ideally new features or fixed regressions ought to be covered via new tests.
[x] Ideally new or changed features have documentation updates.

In the new commit, I have succeeded to simulate the python ClickUsing.py --count=3 as described by @xennygrimmato . It is able to parse multiple commits at once.Is this satisfactory?

I am now working on integrating command line argument parsing into the test runner.Can I open another issue and pull request for this? It is out of the scope of this Pull request.

@kayhayen, @xennygrimmato  I have implemented your suggestions in the new commit; command line argument parsing in the runner and it works when run on ClickUsing.py. Also, the arguments can be passed in the test while invoking the program.
I was not quite sure,  however, whether to fit the function directly in run_all.py or to put it in nuitka.tools.testing.Common. I put it in run_all.py, is it okay here?.
Another thing is, I created a new function to prevent possibly breaking compatibility by changing extra_flags in nuitka.tools.testing.Common.compareWithCPython due to my not-yet-complete knowledge of the full scope of the project. Is this possibility real? If it is not, I can change the extra_flags as required.
I used a variable('commands`) to indicate the presence of command line arguments. I plan to document this if you confirm.
I look forward to your suggestions.

@tommyli3318 has been assigned to the issue that this pull request addresses. Hence I will close this pull request and halt my work on it. However, I am available to work on it and/or answer any questions pertaining to it as need be.


Are arbitrary object meshes supported?

Hi,
I am curious if trajectory optimization with a manipulator and arbitrary object meshes are supported - I noticed they are just spheres.

Short answer: yes, with caveat below.
Long answer: we already are using meshes to represent the robot, e.g., in the kinova arm case. And to the solver there is no difference between robot and object. You can use arbitrary meshes as long as the contact model is hydroelastic, since autodiff through the forward dynamics is not currently supported for all geometries with point contact. That means that if two mesh objects are in contact, at least one of them needs to be defined as compliant hydroelastic. That can take some work to set up: see the hydroelastic user guide for more info.


Feat / Featured shelf cosmetic update

Feat / Featured shelf cosmetic update

This PR improves the look and feel of the featured shelf. Instead of using the TileSlider with just a larger Card, this new version leverages the reserved space much more, with a smooth animation between slides. On mobile devices, you can drag the text off screen to bring in the next.
See the screenshots/screen caps of desktop and mobile below.
Steps completed:

According to our definition of done, I have completed the following steps:

[x] Acceptance criteria met
[x] Unit tests added
[ ] Docs updated (including config and env variables)
[x] Translations added
[x] UX tested
[x] Browsers / platforms tested
[x] Rebased & ready to merge without conflicts
[x] Reviewed own code

https://github.com/user-attachments/assets/b8ac0c1c-0cd4-4c5c-99cc-79a8f66a7554
https://github.com/user-attachments/assets/ef917b90-3b55-4af5-b580-cb5ce3aeb1a2

Really nice improvement! I detected one visual problem; when you use the pagination dots, they move. So i need to reposition my mouse cursor anytime I want to click the dots.
Other points to consider:

Curious: why have you chosen to do inline JS/CSS animations as opposed to regular CSS? I think the later makes it easier to make styling changes.
I think we should use aria-disabled instead of disabled on the slider buttons/paginations. So the buttons can still keep their focus, while the screen-reader pronounces it's state. I know this is not the first time we have discussions about this ;-)

Hi @AntonLantukh and @dbudzins, I hope you find a moment to have a look as well. :-)


Limit the amount of open tabs

VSCode Version: 1.7.1 (02611b40b24c9df2726ad8b33f5ef5f67ac30b44)
OS Version: OSX (10.11.6 (15G1108))

I'm coming from PyCharm and am used to working without tabs and the sidebar. In PyCharm i can limit it so when i open one document the other document previously opened gets closed (But it doesn't prompt to save any changes as these persist, not sure how though, and remain there when i re-open).
Is there something similar for VS Code?

@dan-gamble Working without tabs should help

I've followed this :). The main problem is when I close my current document all the other tabs still exist. It's just the tab bar is hidden. I wondered if it's possible to have only one document open at a time. Not just viewing 1 at a time

Interesting, so you want to have only one editor open at any time.
@bpasero A setting to limit the number of editors open ?

https://github.com/Microsoft/vscode/issues/9872

#9872 explains it much better than me


isoinfo is not found

/pve-iso-2-pxe.sh: sor: 42: isoinfo: not found
my command: bash pve-iso-2-pxe.sh /mnt/data/isos/proxmox-ve_6.4-1.iso

I found the problem
i run this script on a raspberry pi and missing this "apt-get install genisoimage"

Will add it to the README, thanks for the hint!


Add tests for frame module.

This is a super-task (in meaning it contains a list of subtasks).
We need to add tests to each frame in frame module to make a process of parsing and serialization more mature.

[ ]  events
[x] frame_auth_challenge
[x] frame_auth_response
[x] frame_auth_success
[x] frame_authenticate
[ ] frame_batch
[ ] frame_error
[ ] frame_event
[ ] frame_execute
[ ] frame_options
[ ] frame_prepare
[ ] frame_query
[x] frame_ready
[ ] frame_register
[ ] frame_response
[ ] frame_result
[x] frame_startup
[x] frame_supported
[x] mod
[ ] parser

I'll check which of them already have unit tests.

@AlexPikalov : i came across a testing framework called Stainless
https://github.com/reem/stainless
this seemed a natural way of testing what are you thoughts?

@harrydevnull It makes sense for me to use this framework


data-role="table" not listing all items

Hi, i'm trying to list a total > 1000 items in a table, but it only displays a maximum of 681, i don't know why but if i remove the attribute (data-role) it displays all items, but with a non working table obviously.
What can it be?

In this example, a table works with 100 000 records https://metroui.org.ua/examples/table/table-100K.html.
Check your data file for the table.


Determine libraries incompatible with PHP 7.2

AC:

ZF1 libraries that are incompatible with PHP 7.2 are marked with php7.2-incompatible label and included in Magento 2.3.0 milestone on the ZenHub board

Incompatibilities are fixed in https://github.com/magento-engcom/zf1-php-7.2-support/pull/11


[WIP] Adds a Dangerfile

Going to do the Semaphore faffing now to verify.

Going to switch to a cross-repo PR instead.


NavigatorIOS with exiting app

I been integrating React Native into my exiting application and everything has been going well.
By far my biggest problem is combining the exiting Obj-c navigator with React-Native NavigatorIOS.
Is there any way to combine the two, allowing people to navigate from the Obj-C part of the application to the new React-Native part and then back? Something like initializing the NavigatorIOS with routes from the Obj-C part.
Hope this makes a little sense
Regards

You may find the NavigatorIOS's backing viewcontroller and use it in your native code.

Hmm I don't quite understand. Can you give some more details ?

@axelg12 - you'll have a hard time getting support for NavigatorIOS because most React Native developers only use the Navigator component (read about the differences here). @ssssssssssss suggestion seems to be on track, but I'm not sure that I'd recommend using this, it seems like a potentially brittle solution - I think you're better off just using a native obj-c navigator and rendering React Native views in the different routes.

···

(RCTRootView *)sceneReactNavigator {
UIView *parent = (UIView *)self.reactSuperview;
while(parent != nil) {
if([parent.nextResponder isKindOfClass:[UINavigationController class]]) {
return (RCTRootView *)parent.nextResponder;
}
parent = (UIView *)parent.reactSuperview;
}
return nil;
}
···
Find the this view's backing navigation controller.

Hi there! This issue is being closed because it has been inactive for a while.
But don't worry, it will live on with ProductPains! Check out it's new home: https://productpains.com/post/react-native/navigatorios-integration-with-navigator-in-existing-native-app


add IFrame contentWindow and contentDocument

Adds missing contentWindow and contentDocument attributes to HTMLIFrameElement.
Not sure if contentWindow should be any or window ?

@xuorig I would love it if you rebased this! It's a feature I've been waiting for.
I did a little research and I can answer your question about contentWindow. For now, it should be any.
In the bom, var window is declared as type any: https://github.com/facebook/flow/blob/master/lib/bom.js#L39
Also FYI, in https://github.com/facebook/flow/issues/2150#issuecomment-237666689, @thejameskyle mentioned that the type for window should be improved. But for now it's any.

Awesome thanks andrew ill rebase this!
On Tue, Aug 16, 2016 at 6:37 PM Andrew Farmer<EMAIL_ADDRESS>wrote:

@xuorig https://github.com/xuorig I would love it if you rebased this!
It's a feature I've been waiting for.
I did a little research and I can answer your question about contentWindow.
For now, it should be any.
In the bom, var window is declared as type any:
https://github.com/facebook/flow/blob/master/lib/bom.js#L39
Also FYI, in #2150 (comment)
https://github.com/facebook/flow/issues/2150#issuecomment-237666689,
@thejameskyle https://github.com/thejameskyle mentioned that the type
for window should be improved. But for now it's any.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/facebook/flow/pull/1783#issuecomment-240261174, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AB1KCnN5GyCTRb6dpZsBRbZTaxI5NRrGks5qgjulgaJpZM4IeHJe
.

Rebased + ran
./runtests.sh bin/flow dom
cp tests/dom/dom.out tests/dom/dom.exp

cc @ahfarmer @gabelevi

Any news on this? Or is this stalled?

I'm not sure why we've neglected this PR for so long. Maybe because it accidentally deleted dom.exp. Anyway, I've imported it, fixed the test, and am waiting for another team member to review it.
@xuorig - Sorry for there being such a long delay 😞 ! A PR should never ever wait this long for a review or merge. Thanks for your contribution!

No worries @gabelevi! thanks for taking the time to merge it. 💌


List of embedded layers that need to be implemented to support the diffusion model

It is a list of embedding layers that need to be implemented to support the diffusion model.
It would be nice if anyone who has time could take care of it one by one, then implement it.
Since there are no layers that are very complex, it would be good practice for nntrainer.

GaussianFourierProjectionEmbedding
https://github.com/huggingface/diffusers/blob/28e8d1f6ec82a60a9b69554d83f02d385b79d1cc/src/diffusers/models/embeddings.py#L224-L251

ImageHintTimeEmbedding
https://github.com/huggingface/diffusers/blob/28e8d1f6ec82a60a9b69554d83f02d385b79d1cc/src/diffusers/models/embeddings.py#L471-L499

ImageProjection
https://github.com/huggingface/diffusers/blob/28e8d1f6ec82a60a9b69554d83f02d385b79d1cc/src/diffusers/models/embeddings.py#L382-L402

ImageTimeEmbedding
https://github.com/huggingface/diffusers/blob/28e8d1f6ec82a60a9b69554d83f02d385b79d1cc/src/diffusers/models/embeddings.py#L458-L468

FourierEmbedder
https://github.com/huggingface/diffusers/blob/28e8d1f6ec82a60a9b69554d83f02d385b79d1cc/src/diffusers/models/embeddings.py#L552-L565

TextImageProjection
https://github.com/huggingface/diffusers/blob/28e8d1f6ec82a60a9b69554d83f02d385b79d1cc/src/diffusers/models/embeddings.py#L355-L379

TextImageTimeEmbedding
https://github.com/huggingface/diffusers/blob/28e8d1f6ec82a60a9b69554d83f02d385b79d1cc/src/diffusers/models/embeddings.py#L440-L455

TextTimeEmbedding
https://github.com/huggingface/diffusers/blob/28e8d1f6ec82a60a9b69554d83f02d385b79d1cc/src/diffusers/models/embeddings.py#L424-L437

TimestepEmbedding
https://github.com/huggingface/diffusers/blob/28e8d1f6ec82a60a9b69554d83f02d385b79d1cc/src/diffusers/models/embeddings.py#L159-L204

AttentionPooling
https://github.com/huggingface/diffusers/blob/28e8d1f6ec82a60a9b69554d83f02d385b79d1cc/src/diffusers/models/embeddings.py#L502-L549

PositionNet
https://github.com/huggingface/diffusers/blob/28e8d1f6ec82a60a9b69554d83f02d385b79d1cc/src/diffusers/models/embeddings.py#L568-L658

:octocat: cibot: Thank you for posting issue #2338. The person in charge will reply soon.


JPEG compression for TIFFs is missing

In adding WEBP, I added a libtiff that's not GDAL's internal version and left out JPEG compression. I'll re-enable and tag 1.7.1.

Resolved by 5232065.


Use serial number instead of name for joystick dictionary

Fixes #1612
Use the joystick Serial property instead of Name as the dictionary key.
Before this change:

After this change:

Confirmed working by TheStoneFox in Discord, who was one of the people originally reporting the problem.

Confirmed working by TheStoneFox in Discord, who was one of the people originally reporting the problem.

I approve this message 😄

Confirmed this fixes the issue for the other user who reported this in Discord.

Checked it as well and it seems to resolves the Issues in my case...


Fix and Test Conditional Validator Behavior in FormField

In the FormField widget, if a validator is initially set (and validation fails), then subsequently the validator is set to null, the form incorrectly retains its error state. This is not expected behavior as removing the validator should clear any validation errors.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

Welcome @EdgarJan! thanks for contributing. Does this PR close an open issue?

@Piinks No, I ran into an issue myself and fixed it without opening anything. If it's mandatory I can open issue and explain the problem.

If it's mandatory I can open issue and explain the problem.

For this case, I think we can go without. Just making sure we closed/referenced it if it already existed.


Examples2

austin, your calculate_pathway_gsea example seems to be running on pbmc_matrix_small instead of the average? that hangs for a long time for me

Oops - that is a problem. I'll fix it.

Unintentionally rolls back several of Rui's fixes...


How to add commands and start.

Hi, i cant find the events folder and i dont understand how do i start it. Do i have to start it from code blocks or cmd. Im trying to start it on windows

to build the source, look here https://github.com/GuckTubeYT/GTProxy/wiki/Building-the-Project#codeblocks-windows-version
to add the commands, look here https://github.com/GuckTubeYT/GTProxy/wiki/How-to-Add-Custom-Commands

yhea but how to start it

https://github.com/GuckTubeYT/GTProxy/issues/18

to add the commands, look here https://github.com/GuckTubeYT/GTProxy/wiki/How-to-Add-Custom-Commands


Update params doc page to mention push function signature & remove im…

…proper “an” placement

Remove “an” before word user with Y consonant  sound
include push alongside mentioning of navigate in beginning of page, that’s also mentioned in the summary at the end.

READ ME PLEASE!
TL;DR: Make sure to add your changes to versioned docs
Thanks for opening a PR!
The docs cover several versions of react-navigation, and in some cases there are several files (for version 1, version 2 and etc.) that all describe a single page of the docs (eg. "Getting Started").
Please make sure that the edit you're making in docs/file-you-edited.md is also included in the file for the correct version, eg. /versioned_docs/version-3.x/file-you-edited.md for version 3. If such file doesn't exist, please create it. :+1:

Thanks for the PR. I'm closing this since this change is for an older version of React Navigation. Feel free to send a new PR for the current version of React Navigation.


Error: global leak detected: lr

Hi,
At some place in your code you are missing the "var" statement and thereby declare a global variable. I get the following error in a mocha test case: Error: global leak detected: lr
Potentially in the function crypt_raw.
Cheers

Seems like this was fixed in version 0.1.0, there's any chance you can publish this version to npm?
Thank you!

+1. The version from npm, which is 0.0.3 has the global leak and it is not present in master. So, could you please push the latest master to npm?

:+1:

:+1:

Guys has fixed version been pushed to npm. I ran into same issue can't seem to fix this

this is still broken. crypt_raw refers to lr without a var lr at the top of the function thus blatting global.lr
<EMAIL_ADDRESS>

never mind, just saw the not maintained notice and reference to https://github.com/dcodeIO/bcrypt.js


Update README.md

With WebPack 4 I didn't need to extract the manifest. It worked out of the box.

@budde377 @tajo yeah, it works. But chunks will start loading after the application starts up.
So it's still make sense.


Can you please create 2.6.2 release , Thank you!

@klipmaniac it is no longer necessary to make a separate release here when the editor is updated. You can update separately the froala-editor dependency by running: npm update froala-editor.

Hi @stefanneculai
The lastest release of the editor is:

An the lastest release of the directive is:

Our question is can we use the versiion 2.61 of the directive with the version 2.62 of the editor? Thanks!

Yes, that is right.

ok, this is our bower json

How we could indicate the version of the editor? Thanks in advance

The froala-editor dependency for angular-froala plugin is set here: https://github.com/froala/angular-froala/blob/master/bower.json#L33. If you're using bower, all you should do is to run bower install froala-wysiwyg-editor. This should install the version 2.6.2.

thanks @stefanneculai only for confirm our bower json now looks  like, is this correct?:

Yes, that is correct. 👍

Stefan thank you for your help on this, I guess I didnt realize till now that you work for froala, I emailed you about the Edge bug when pasting a table in the editor via Edge browser I just get the content not the actual table.. I updated now to 2.6.2, you sent me a link to 2.6.2 via email of this fix? Im not sure how to fix this issue, I update to 2.6.2 and still have it.
Thank you.

I mean if you go to your editor on your page (https://www.froala.com/wysiwyg-editor/) and copy paste from word using the Edge browser you will see the same issue we are seeing...

plunker not working either with word copy paste via Edge ....
https://plnkr.co/edit/WxAw15Dt6xcwSYH8ixke?p=preview

@klipmaniac the fix is in V2.6.3 which is still under development and is not released yet. To try it, you could do the following: bower install --save froala-wysiwyg-editor#master. This should use the master branch from Github which is not released yet.


Inconsistencies with sync send assignment

Description:
$title. See below, can't assign to anything other than a nil-typed variable.
Steps to reproduce:
import ballerina/io;

public function main() {
    worker w1 {
        int i = 100;
        () v = i ->> w2; // works
        // var v = i ->> w2; // incompatible types: expected '()', found 'error?'
        // error? v = i ->> w2; // incompatible types: expected '()', found 'error?'
        // i ->> w2; // variable assignment is required, incompatible types: expected '()', found 'error?'
    }

    worker w2 {
        int lw;
        lw = <- w1;
        io:println("[w2 <- w1] lw: ", lw);
    }
}

Affected Versions:
$ ballerina -v
Ballerina 1.0.0-alpha3
Language specification 2019R2
Ballerina tool 1.0.0

Assignment/definition with var works when the receiving worker's return type is a subtype of error? and includes error, and there is a possibility that the receiving worker returns error before receiving.
import ballerina/io;

public function main() {
    worker w1 {
        int i = 100;
        var v = i ->> w2;
        io:println("v is (): ", v is ());
    }

    worker w2 returns error? {
        int lw;

        if (false) {
            return error("dummy err reason");
        }

        lw = <- w1;
        io:println("[w2 <- w1] lw: ", lw);
    }
}

$ ballerina run abc.bal
v is (): true
[w2 <- w1] lw: 100

Can't seem to use trap due to this too.
import ballerina/io;
import ballerina/runtime;

public function main() {
    worker w1 {
        int i = 100;
        error? v = trap i ->> w2; // incompatible types: expected '()', found 'error?'
    }

    worker w2 {
        runtime:sleep(5000);
        int lw;

        if (true) {
            panic error("err reason");
        }

        lw = <- w1;
        io:println("[w2 <- w1] lw: ", lw);

    }

    wait w1;
}

Works again, if the receiving worker could possibly return error.

May have to recheck async-send also, since it is now an action (not a statement).


chore(github): add .github/FUNDING.yml

fix #1146

Deploy preview for js-primer ready!
Built with commit b8118c7823f68160880085b8caeb620d88390253
https://deploy-preview-1149--js-primer.netlify.com


updated individual non-human attributes for LC

The "other" options were not listed for some attributes and 'cohort' was not needed in this template (removed).

@ameliakallaher I was able to successfully join and convert the data model and generate some test manuscripts:

individual non-human: https://docs.google.com/spreadsheets/d/1_7TPzb92p60t0WwsLO_N5kx7EnzR2okqyGcM4eqaK1Y/edit?gid=0#gid=0
biospecimen human: https://docs.google.com/spreadsheets/d/1GoT7kjTLL8SkTf5E4k3vbPHg5Y8tkaSvJDGv1VSg0NE/edit?gid=0#gid=0
biospecimen non-human: https://docs.google.com/spreadsheets/d/1W3plRL47MX3glUXgRcVbFfOeu29siaI7JIcYwqsrgDE/edit?gid=0#gid=0

Do those look as you expected? If so, you're good to merge the changes into main!

Thank you, @avanlinden
The test manuscripts look good. We're good to merge.


acs-engine should validate Windows username & password in apimodel to avoid failing a deployment later

Is this an ISSUE or FEATURE REQUEST? (choose one): Feature

What version of acs-engine?: v0.20.* and earlier

Azure has extra requirements on VM password & username. If they're not met - acs-engine generate will succeed, but then az group deploy will fail after waiting a few minutes. Fail fast!
Windows VM username and password
Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm): all

Where to do this: https://github.com/Azure/acs-engine/blob/master/pkg/api/vlabs/validate.go#L828

https://github.com/Azure/acs-engine/pull/3854 enforces password validation

resolved in #3854


migrate to v2 config, migration, and metadata structure

 [S] Update Migrations from v1 -> v2 (after 1.2.0)


IDNITS: Incorrects nits related to updates

Describe the issue
See https://author-tools.ietf.org/api/idnits?url=https://www.ietf.org/archive/id/draft-dhody-pce-iana-update-03.txt
-- The draft header indicates that this document updates RFC29, but the
abstract doesn't seem to mention this, which it should.
-- The abstract seems to indicate that this document updates RFC9168, but
the header doesn't have an 'Updates:' line to match this.
-- The abstract seems to indicate that this document updates RFC8779, but
the header doesn't have an 'Updates:' line to match this.
-- The abstract seems to indicate that this document updates RFC8934, but
the header doesn't have an 'Updates:' line to match this.
-- The abstract seems to indicate that this document updates RFC8800, but
the header doesn't have an 'Updates:' line to match this.
-- The abstract seems to indicate that this document updates RFC8733, but
the header doesn't have an 'Updates:' line to match this.
-- The abstract seems to indicate that this document updates RFC9357, but
the header doesn't have an 'Updates:' line to match this.
-- The abstract seems to indicate that this document updates RFC9059, but
the header doesn't have an 'Updates:' line to match this.
-- The abstract seems to indicate that this document updates RFC8780, but
the header doesn't have an 'Updates:' line to match this.
-- The abstract seems to indicate that this document updates RFC9504, but
the header doesn't have an 'Updates:' line to match this.
-- The abstract seems to indicate that this document updates RFC8745, but
the header doesn't have an 'Updates:' line to match this.
-- The abstract seems to indicate that this document updates RFC9050, but
the header doesn't have an 'Updates:' line to match this.
-- The abstract seems to indicate that this document updates RFC8697, but
the header doesn't have an 'Updates:' line to match this.
Miscellaneous warnings:
-- No information found for rfc29 - is the name correct?
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

@dhruvdhody, This is because author-tools by default uses the original idnits tool.
There's a new "alpha" version (v3) of idnits available ^1.
This is available via https://author-tools.ietf.org/idnits3
The new idnits v3 works better with XML files, there are not a lot of checks on text files.
This is the output for XML version above draft: https://author-tools.ietf.org/api/idnits3?url=https://www.ietf.org/archive/id/draft-dhody-pce-iana-update-03.xml
Feel free to report any buys you find with idnits v3 so we can improve it.

Closing this issue as a new version of idnits in the pipeline.


[Bug] Expanding VectorFold with a negative number of folds will (naturally) fail

E.g.,
julia> collect(VectorFold([1, 2], 10, -5))
ERROR: ArgumentError: invalid Array dimensions

Proposed fix: create an internal constructor method for VectorFold (and maybe check PatternFold, as well?) to catch this.  Would that be reasonable?  Or do we...somehow want non-positive numbers of folds?  E.g.:
mutable struct VectorFold{T,V <: AbstractVector{T}, I1 <: Integer, I2 <: Integer} <: PatternFold{T,V}
    pattern::V
    gap::T
    folds::I1
    current::I2

    function VectorFold(p::V, g::T, f::I1, c::I2) where {T,V <: AbstractVector{T}, I1 <: Integer, I2 <: Integer}
        f < 0 &&
            throw(ArgumentError("folds cannot be negative (you cannot have a negative number of folds)."))
            new{T, V, I1, I2}(p, g, f, c)
        end
end

I can't see a reason to have negative fold either.
You proposition is good. Another way to do it would be to have
mutable struct VectorFold{T,V <: AbstractVector{T}, I1 <: Integer, I2 <: Integer} <: PatternFold{T,V}
    pattern::V
    gap::T
    folds::I1
    current::I2

    function VectorFold(p::V, g::T, f::I1, c::I2) where {T,V <: AbstractVector{T}, I1 <: Integer, I2 <: Integer}
            new{T, V, I1, I2}(p, g, max(0,f), c)
        end
end

But it is prone to introduce unexpected behavior. I would rather have your solution (maybe with the following variant)
mutable struct VectorFold{T,V <: AbstractVector{T}, I1 <: Integer, I2 <: Integer} <: PatternFold{T,V}
    pattern::V
    gap::T
    folds::I1
    current::I2

    function VectorFold(p::V, g::T, f::I1, c::I2) where {T,V <: AbstractVector{T}, I1 <: Integer, I2 <: Integer}
            @assert f => 0
            new{T, V, I1, I2}(p, g, f, c)
    end
end


feat(design-land): add theme switch functionality to design land

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/develop/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?
There is no easy way to switch themes in design land.
Fixes: N/A
What is the new behavior?
Add theme switch functionality. It allows people to easily toggle between dark and light mode in design land.
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

The example code looks a little bad in the dark mode but it shouldn't block this PR.

@griest024 There's an issue for it #1399