[Bug]: Error when solving simulation for SPM with modified Prada2013 parameter set

PyBaMM Version
22.4
Python Version
3.9.13
Describe the bug
I need to simulate the life expectancy of cells for a project. In doing so, I run into difficulties with the LFP cells. I am using the Prada2013 parameter set here, as this is the only set that implements an LFP cell.
To age the cell during the experiment, I add the same SEI used in Chen2020.
I control the aging of the cell by adjusting the parameter "SEI kinetic rate constant [m.s-1]" and setting the parameter "SEI open-circuit potential [V]" to zero, as it affects the aging too much (at least this was the case for the NMC cells where I used the Chen2020 parameter set). Unfortunately, Pybamm keeps crashing with the modified parameter set.
I also tried to upgrade to the latest Pybamm (version 22.6) and run the code. In this case, Pybamm keeps crashing even when I just try to solve the simulation with an unchanged parameter set of Prada2013.
Steps to Reproduce
import pybamm
import numpy as np

def get_Wh(solution: pybamm.Solution) -> tuple:
    """Returns the Wh based on pybamm Solution. Wh are calculated from current and Voltage.

    Args:
        solution (pybamm.Solution): Pybamm solution.

    Returns:
        tuple: Wh discharged and Wh charged
    """
    t_array = solution["Time [h]"].entries
    I_array = solution["Current [A]"].entries
    U_array = solution["Battery voltage [V]"].entries

    d_t = np.diff(t_array)
    current = np.convolve(I_array, np.ones(2) / 2, mode="valid") * (-1)
    current_out = np.where(current < 0, current, 0)
    voltage = np.convolve(U_array, np.ones(2) / 2, mode="valid")

    Wh_out = abs(np.sum(voltage * current_out * d_t))

    return Wh_out

pybamm.set_logging_level("NOTICE")

ref_model = pybamm.lithium_ion.SPM()

ref_param_set = pybamm.parameter_sets.Prada2013
ref_parameter_values = pybamm.ParameterValues(chemistry=ref_param_set)

ref_experiment = pybamm.Experiment(
    [
        (
            "Discharge at 0.1 C until 2.0 V",
            "Rest for 10 minutes"
        )
    ] +
    [
        (
            "Charge at 0.1 C until 3.6 V",
            "Hold at 3.6 V until 50mA",
            "Discharge at 0.1 C until 2.0 V"
        )
    ]
)

ref_sim = pybamm.Simulation(ref_model, ref_experiment, parameter_values=ref_parameter_values)
ref_sim.solve(solver=pybamm.CasadiSolver(mode="safe"))
ref_solution = ref_sim.solution.cycles[-1]

cycle_model = pybamm.lithium_ion.SPM(
    options={
        "SEI": "ec reaction limited",
        "SEI film resistance": "distributed",
        "SEI porosity change": "false",
    }
)

cycle_param_set = pybamm.parameter_sets.Prada2013
cycle_param_set["sei"] = "example"
cycle_parameter_values = pybamm.ParameterValues(chemistry=cycle_param_set)
cycle_parameter_values.update({"SEI open-circuit potential [V]": 0.0})
cycle_parameter_values.update({"SEI kinetic rate constant [m.s-1]": 1 * 1e-12})

cycle_experiment = pybamm.Experiment(
    [
        (
            "Discharge at 0.1 C until 2.0 V",
            "Rest for 30 minutes"
        )
    ] +
    [
        (
            "Charge at 1 C until 3.6 V",
            "Discharge at 1 C until 2.0 V",
        )
    ] * 1000 +
    [
        (
            "Charge at 0.1 C until 3.6 V",
            "Discharge at 0.1 C until 2.0 V",
            "Rest for 10 minutes"
        )
    ] +
    [
        (
            "Charge at 0.1 C until 3.6 V",
            "Hold at 3.6 V until 50mA",
            "Discharge at 0.1 C until 2.0 V"
        )
    ]
)

cycle_sim = pybamm.Simulation(cycle_model, cycle_experiment, parameter_values=cycle_parameter_values)
cycle_sim.solve(solver=pybamm.CasadiSolver(mode="safe"))
cycle_solution = cycle_sim.solution.cycles[-1]

ref_cap_Wh = get_Wh(ref_solution)
print(f"Capacity after reference experiment: {ref_cap_Wh} Wh")

cycle_cap_Wh = get_Wh(cycle_solution)
print(f"Capacity after experiment: {cycle_cap_Wh} Wh")

soh = cycle_cap_Wh / ref_cap_Wh * 100
print(f'SOH: {soh} %')

Relevant log output
raise pybamm.SolverError(
pybamm.expression_tree.exceptions.SolverError: Could not determine which event was triggered (possibly due to NaNs)

Have found the bug, it is because the voltage (positive electrode OCP) changes so quickly near full charge so it is struggling to find the event where minimum voltage is triggered. Now there is another bug ...

Should be fixed by #2190 . You'll have to do calc_esoh=False in .solve() for now, but that should be fixed soon in a separate PR.

The code above works with correct SEI parameters


Identity clear

from what I understand, we don't have this yet in the UI
or is it when you remove all the fields and click create identity?

from what I understand, we don't have this yet in the UI

Yes, we do not have it.

or is it when you remove all the fields and click create identity?

Nop. The functionality is not ready. It needs some extra work.

I would like to add the functionality of clearing identity. Could you please add the UI for this case? @exezbcz

I would like to add the functionality of clearing identity. Could you please add the UI for this case? @exezbcz

Sure, will make this asap

This should do the job:

small button
copy about the identity
would be displayed when you already have an identity created.
when no identity - do not display this section at all (the section is with dividers as well)
the name under the "existing onchain identity" is the name you see on profile when on the network

updated in handoff small things file
https://www.figma.com/file/JXNtryaNYhY0XJNArzvPQx/Handoff?type=design&node-id=1287%3A18959&mode=design&t=sR90g8sCtIj0YPEz-1
rdy @Jarsen136


F3.1.3 The service shall allow users to cancel the matching search.

Done in https://github.com/CS3219-AY2425S1/cs3219-ay2425s1-project-g50/pull/171


Load Camel K integrations from Java-file

We currently start a camel k integration in a pre-script with the following command.
kamel run ../../../main/java/com/XXX/XXX/XXX/XXXXRouteBuilder.java
--wait -n name
--name camelk-test
--trait knative-service.min-scale=1
--logging-level org.apache.camel=DEBUG
-d camel:camel-rest
It would be nice if you could add a step that allows the setup of an integration with java file in the following way.
Given create Camel-K integration {name}.java with configuration:
| dependencies | mvn:org.foo:foo:1.0,mvn:org.bar:bar:0.9 |
| traits       | quarkus.native=true,quarkus.enabled=true,route.enabled=true |
| properties   | foo.key=value,bar.key=value |

There actually is a step available:
  Scenario: Create integration with config
    When create Camel-K integration timertolog.groovy with configuration:
      | dependencies | mvn:fake.dependency:foo:1.0,mvn:fake.dependency:bar:0.9 |
      | traits       | quarkus.native=true,quarkus.enabled=true,route.enabled=true |
      | properties   | foo.key=value,bar.key=value |
      | source       | from('timer:tick?period=1000').setBody().constant('Hello world from Camel K').to('log:info') |

and you can load the file with Citrus function like this:
  Scenario: Create integration with config
    When create Camel-K integration timertolog.groovy with configuration:
      | dependencies | mvn:fake.dependency:foo:1.0,mvn:fake.dependency:bar:0.9 |
      | traits       | quarkus.native=true,quarkus.enabled=true,route.enabled=true |
      | properties   | foo.key=value,bar.key=value |
      | source       | citrus:readFile('classpath:path/to/route.java') |

I get the following error when I try this out "Create integration with config (test.feature:2): Failure caused by com.consol.citrus.exceptions.TestCaseFailedException - Property  does not match format key=value". I use YAKS 0.4.0.
Here is my code

yaks test --resource Class.java test.feature

Feature: Hallo
Scenario: Create integration with config
When create Camel-K integration timertolog.groovy with configuration:
| dependencies | camel:camel-rest |
| traits       | quarkus.native=true,quarkus.enabled=true,route.enabled=true |
| name         | parquet-yaks-test |
| source       | citrus:readFile('classpath:Class.java') |

public class Class {
}

I see your source code is Java but your integration indicates to use Groovy as you create the integration timertolog.groovy. Please try to create timertolog.java so you indicate to use Java as source code language for Camel-K.
Also could you please provide the full error StackTrace? I am not sure where this exception is raised and the StackTrace helps me to find the code throwing the exception. Thx

should be fixed with #337


WorkflowExecutionEvent.yaml issues

type is of type string, the type was missing.
enum value WorkflowTaskTimedOut was missing.
fixes: https://github.com/sailpoint-oss/python-sdk/issues/13

Closing this, as the specs were updated and fixed in https://github.com/sailpoint-oss/python-sdk/commit/b9a258c430dedf7c1e7937e180393f8087b55eab


Remove DM channels from the cache and dm channel events that were removed from v8

Summary
Remove DM channels from the cache and dm channel events that were removed from v8
Checklist

[x] I have run nox and all the pipelines have passed.
[x] I have made unittests according to the code I have added/modified/deleted.

Related issues

How do we DM users now then and respond to DMs?
make two API calls per message we want to send to ensure the channel is open?

How do we DM users now then and respond to DMs?
make two API calls per message we want to send to ensure the channel is open?

Yep sounds about right, right now this cache is gateway only and seeing as the events were removed from V8 there's no point in keeping any of this around as it'll always be empty

How do we DM users now then and respond to DMs?

DM'ing users will have to be creating the channel first to make sure that it exists and then sending a message there. Responding should be as easy as Message.reply() since the channel_id is correct.


Day47: 'Smallest Subtree with all the Deepest Nodes' solution

Smallest Subtree with all the Deepest Nodes
https://leetcode.com/problems/smallest-subtree-with-all-the-deepest-nodes/
Given the root of a binary tree, the depth of each node is the shortest distance to the root.
Return the smallest subtree such that it contains all the deepest nodes in the original tree.
A node is called the deepest if it has the largest depth possible among any node in the entire tree.
The subtree of a node is a tree consisting of that node, plus the set of all descendants of that node.

Example 1:
Input: root = [3,5,1,6,2,0,8,null,null,7,4]
Output: [2,7,4]
Explanation: We return the node with value 2, colored in yellow in the diagram.
The nodes coloured in blue are the deepest nodes of the tree.
Notice that nodes 5, 3 and 2 contain the deepest nodes in the tree but node 2 is the smallest subtree among them, so we return it.
Example 2:
Input: root = [1]
Output: [1]
Explanation: The root is the deepest node in the tree.
Example 3:
Input: root = [0,1,3,null,2]
Output: [2]
Explanation: The deepest node in the tree is 2, the valid subtrees are the subtrees of nodes 2, 1 and 0 but the subtree of node 2 is the smallest.


Web Map "Monterey Airport (Overview)" being released as demo content references a test service

Web Map "Monterey Airport (Overview)" (e9afca99ffa14bf0b064df6631210f60) references service item "SIGINT" (24dc0dce9c6949a889e516725757cbf0) and service was published to test folder (Test/SIGINT/FeatureServer/0).
If the SIGINT feature service is really needed in this web map then the service has to be published to a non-test folder and item has to go through release or demo workflow.

FYI: This web map is consumed by multiple web apps or operation views.

@ScottCecilio - You will need to get the SIGINT service out of the test folder on into the Military folder for the service to be published. This needs to happen today. Be aware that moving the service might "break" the items that are consuming the service.

Based on the fact that the symbology for this service is not good, all of the example I could find of this service are not good I decided to remove this service from the web map and saved with the layer removed. I am deleting the test service.

@elinz let me know if any other released content depended on this service. I will fix that item by removing the layer.

e9afca99ffa14bf0b064df6631210f60: Verified that layer was removed from this web map. No other released or going to be released consume this layer. Closing issue.

I use this layer in my Dashboard for Land Ops.  Should I just publish this today?


Deploy on Ropsten

and switch over from Morden to Ropsten

Is this project dead now? Even on mainnet the block in btcrelay is far behind.

Hi @garzon , anyone can deploy BTC Relay on Ropsten and submit Bitcoin block headers using (free) Ropsten ETH.
On mainnet, ConsenSys has been the only one submitting block headers: there will be more evaluation from ConsenSys about mainnet participation by end of month, May.
If anyone deploys on Ropsten or another testnet and finds it useful, please let us know here or Gitter as it can inform plans for mainnet.

https://ropsten.etherscan.io/address/0x8ffd7bb8499879eae66ce677ab662bd46c8a6d37


No url found for submodule path in v2.1.6

Starting with version 2.1.6, Swift Package Manager is unable to resolve the Sift package dependency.  The error is
xcodebuild: error: Could not resolve package dependencies: Couldn’t update repository submodules: fatal: No url found for submodule path 'HelloSift/Carthage/Checkouts/sift-ios' in .gitmodules
I believe this is an issue on the Sift side, rather than on the client side, since it still resolves without issue in 2.1.5.  Could someone please provide guidance?

@sbogolii-sift This works now, thank you!


issues building doc since Hugo v0.50

Multiple identical error messages:
error calling partial: "/builds/dev/doc/themes/hugo-theme-docdock/layouts/partials/header.html:2:10": execute of template failed: template: partials/header.html:2:10: executing "partials/header.html" at <where .Site.Pages "S...>: error calling where: Source isn't a field of struct type *hugolib.Page

Just for refenece,this is how header.html looks like:

If you do   {{ range .Site.Pages }} it will build without error. Obviously it looks weird 😄 but it build without error.
I guess there is some syntax checking change for range where ...

and if you do exactly the same thing but with an index,  there is only one (same origin) error. Just one.
{{ range $i, $value := where .Site.RegularPages "Source.BaseFileName" $header }}

Mmmmm seems they changed the Page variable somehow ...
{{ range where .Site.Pages ".File.BaseFileName" $header }} seems to solve the problem. I have to really check but seems ok. Let me know how it works on your side.
Source is really badly documented and I guess not for use in code.

Looks like Source was removed in 0.50
https://github.com/gohugoio/hugo/commit/7930d2132a3c36c1aaca20f16f56978c84656b0a

I had to replace {{ range where .Site.Pages "Source.BaseFileName" $footer }} with {{ range where .Site.Pages ".File.BaseFileName" $footer }} as well has in header.html
Can we get an update out with these fixes asap?

I had to replace {{ range where .Site.Pages "Source.BaseFileName" $footer }} with {{ range where .Site.Pages ".File.BaseFileName" $footer }} as well has in header.html
Can we get an update out with these fixes asap?

We already have submit PR for those fix.
See https://github.com/vjeantet/hugo-theme-docdock/pull/167 & #168 168

Awesome. Hopefully they will get pulled in and released asap.

Hi,
I will test the changes with different Hugo versions and if everything fine, then will merge in PR this evening.

This is fixed with #168 and backwards compatible.
Tested with hugo-extended v0.49.2, v0.50 and v0.51


Fix --prefix with absolute path

Fix for issue #22 (--prefix option with absolute path)

Thanks for the contribution!


Latest nvidia driver doesn't compile

Describe the bug
With the latest kernel and the latest non-beta nvidia driver, the drivers don't compile:
error: builder for '/nix/store/wv00lqc6ynx5bhhv31vaixaz867a9vfb-nvidia-x11-460.73.01-5.13.drv' failed with exit code 2;
       last 10 log lines:
       > make[3]: *** Waiting for unfinished jobs....
       > /build/kernel/nvidia-drm/nvidia-drm-modeset.c: In function '__will_generate_flip_event':
       > /build/kernel/nvidia-drm/nvidia-drm-modeset.c:96:23: warning: unused variable 'primary_plane' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunused-variable-Wunused-variable8;;]
       >    96 |     struct drm_plane *primary_plane = crtc->primary;
       >       |                       ^~~~~~~~~~~~~
       > make[2]: *** [/nix/store/0l90igcsgvmq2z69ia6n4dalvln2h81w-linux-5.13-dev/lib/modules/5.13.0/source/Makefile:1847: /build/kernel] Error 2
       > make[2]: Leaving directory '/nix/store/0l90igcsgvmq2z69ia6n4dalvln2h81w-linux-5.13-dev/lib/modules/5.13.0/build'
       > make[1]: *** [Makefile:215: __sub-make] Error 2
       > make[1]: Leaving directory '/nix/store/0l90igcsgvmq2z69ia6n4dalvln2h81w-linux-5.13-dev/lib/modules/5.13.0/source'
       > make: *** [Makefile:80: modules] Error 2
       For full logs, run 'nix log /nix/store/wv00lqc6ynx5bhhv31vaixaz867a9vfb-nvidia-x11-460.73.01-5.13.drv'.
error: 1 dependencies of derivation '/nix/store/gld36fh5sc69s3lw8rnpm701pbsxx67g-etc.drv' failed to build
error: 1 dependencies of derivation '/nix/store/5qnd3i9k96nkxljjs6hpiq100k9ss1m6-linux-5.13-modules.drv' failed to build
error: 1 dependencies of derivation '/nix/store/11y6fqa7ygg9bbr9mf2rq61ciq6dyzk1-system-path.drv' failed to build
error: 1 dependencies of derivation '/nix/store/l29n869335p9xfyvcaqbjgqwc8pkcwl5-nixos-system-dracula-21.11.20210703.09c38c2.drv' failed to build
error: getting status of '/tmp/nixos-rebuild.v0uAIA/result': No such file or directory

To Reproduce
Steps to reproduce the behavior:

use unstable
use the latest linux kernel
add nvidia as a drivers

Expected behavior
It should compile.
Notify maintainers
Latest person who touched it: @ronthecookie
Metadata
$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.12.12, NixOS, 21.11.20210703.09c38c2 (Porcupine)`
 - multi-user?: `yes`
 - sandbox: `no` # also happens with it on, it has to be off for other reasons
 - version: `nix-env (Nix) 2.4pre20210601_5985b8b`
 - channels(root): `""`
 - channels(nix): `""`
 - nixpkgs: `/nix/store/zy56rp0mfp7lx2xqcfzqcf9z82vph9pd-wsfwxm10shvi4yr0ll8p4v1dp7l7wqfl-source`

I can reproduce this issue, albeit I am using stable channel with the latest kernel.

Same here, on NixOS 21.05...

https://forums.developer.nvidia.com/t/460-67-incompatible-with-kernel-5-13-at-the-moment/177543

tl;dr for everyone facing this:
boot.kernelPackages = pkgs.linuxPackages_5_12;

should serve as a temporary workaround

I think we should implement some kind of kernel version lock for the nvidia driver to prevent such occurrences in the future.

@rkitover https://github.com/NixOS/nixpkgs/issues/122606

https://github.com/NixOS/nixpkgs/pull/128785#issuecomment-873219393


Add clarification about get_range* methods

Following #71 and our experience, we should highly highlight the fact that get_range should be avoided by most users.

First, thanks for the work on this crate!
As a new user of this crate, I read through the blob.rs example and assumed from the usage there that get_range returns the full range.
However, this example is probably relying on the blob size 1) being small enough to write in a single transaction 2) being small enough to read in a single return from get_range. While the first issue failed in an obvious way, the second issue lead to confusing debug sessions when it returned incomplete results with no obvious way to get the next chunk of data.
I think it would be helpful to update the examples to avoid using get_range(), or at least clarify the limitations. Especially the blob example where it is specifically meant to illustrate using bigger chunks of data.

:wave:

First, thanks for the work on this crate!

Thanks :smile:

However, this example is probably relying on the blob size 1) being small enough to write in a single transaction 2) being small enough to read in a single return from get_range. While the first issue failed in an obvious way, the second issue lead to confusing debug sessions when it returned incomplete results with no obvious way to get the next chunk of data.

Thanks for the report, you are right, there is place for improvements in the example. I'm not sure how far we need to dive into such details in an example. Retry method like db.run has been introduced since, and I think we can rework the examples.
Would you like to contribute to the example? I think we should be pretty close to what has been described in the official recipes(code is over here). What do you think?

I might circle back to it, the upstream approach doesn’t solve (1) either, and (2) could be solved in different ways although I don’t see how db.run relates.


CB-9408: Documented the new windows-packageVersion attribute on

... <widget> to allow Windows to have an independent binary version than its
widget.

LGTM!


[rmkit] update remux and minesweeper

add launch command to remux, use like: echo "launch xochitl" > /run/remux.api
fix pixmap display in minesweeper so icons show up

Random suggestion: Maybe include a small command to invoke the remux API, to make it more discoverable, at some point in the future?

Random suggestion: Maybe include a small command to invoke the remux API, to make it more discoverable, at some point in the future?

oh, like remux-api launch xochitl or remux-launch xochitl? makes sense, thanks for the idea :-D i added the launch command in preparation for evidlo's ask on re-starting xochitl from oxide/remux via API.


Release/v0.5.2: Fixed libraries vulnerabilities

Why we create this PR?
In the day 11.04.2023 two vulnerabilities were detected by our team using Veracode. This vulnerabilities affect the released version v0.5.1 from our application.
What we want to achieve with this PR?
We want to fix the vulnerability in the backend so that the application becomes more safe
What is new?

Updated Spring Boot Version from v3.0.2 to v3.0.5 fixing the following vulnerable libraries:

Spring Expression v6.0.4 -> v6.0.7
JSON Smart v2.4.8 -> v2.4.10

Pending OSS license checks

@SebastianBezold the PR is ready for review, we need to execute the to create IP license checks tickets for the new version of Spring Boot v3.0.5

@SebastianBezold the PR is ready for review, we need to create the IP license checks tickets for the new version of Spring Boot v3.0.5

IP check issues are created and linked in #15


Update stm32data ref

Not including the changes to stm32-data main which seems to break the build.

bors r+


Don't run profile or rc in ddev-webserver healthcheck

The Problem/Issue/Bug:
@weitzman noticed that something he added to .bashrc.d in homeadditions was being executed by the healthcheck every minute.
The healthcheck should not be loading any profile or bashrc scripts.
How this PR Solves The Problem:
Run the healthcheck without bashrc or profile
Manual Testing Instructions:
TODO:

[ ] Create and make executable a junk.sh file in project .ddev/homeadditions/bashrc.d/junk.sh with contents

echo "junk.sh got run"

[ ] ddev restart
[ ] Demonstrate the problem with a simple bashrc addition to homeadditions (with older version)
[ ] docker inspect --format "{{json .State.Health }}" ddev-<projectname>-web | jq will show "junk.sh got run" for each healthcheck run before this version, and not after.

Automated Testing Overview:

Related Issue Link(s):
Release/Deployment notes:

Thanks so much for testing!


CI Content Check reports many false positives

Describe the bug
The recently added "Developer Portal Content Check" CI check is very helpful, as it prevents broken links.
However, currently it reports many false positives.
To Reproduce
Steps to reproduce the behavior:

Go to e.g. https://github.com/onflow/cadence/pull/1983/checks?check_run_id=8723911821
See 34 errors found (169 invalid links)

Expected behavior
No warnings should be reported, all links are valid currently.
All links in the Cadence repo documentation are currently valid, there shouldn't be any warnings/errros.
Just going from the top:

in docs/design-patterns.mdx: /cadence/language/capability-based-access-control is valid, it's just absolute
in docs/language/access-control.md: contracts is valid, it's just relative (contracts.mdx exists)
in docs/language/accounts.mdx: transactions is valid, it's just relative (transactions.md exists)
...

@turbolent

docs/design-patterns.mdx: /cadence/language/capability-based-access-control is valid, it's just absolute
This link is broken in GitHub.

in docs/language/access-control.md: contracts is valid, it's just relative (contracts.mdx exists)
This link is broken in GitHub

in docs/language/accounts.mdx: transactions is valid, it's just relative (transactions.md exists)
This link is broken in GitHub

We've changed how the site works so that you shouldn't have to think about the docs site URL scheme at all.
You can simply follow the rule-of-thumb: "If it works (links to content properly) in GitHub, it will work on the docs site."
The only exception being links to content in the same repo, but outside oif the docs folder, in which case you must use fully-qualified URLs eg https://github.com/repo/yourdoc.md
I feel this might be the case for most of the warnings in the check_run you linked.
Contributors will see a lot of warnings at first while the link checker enforces the "normalized" link requirements for the new docs site.
If you fix these links in GitHub and they still don't work on the docs site, let me know the first instance of this case, as this is a bug we need to fix!

@turbolent
That being said, there is still a false-negative scenario when relative links to sibling documents, in a subfolder are reported as invalid, when they work on the docs site and GitHub.

Restating that some links in Cadence github don't work. here is an example of two.

@bthaile The links were written in a way so they would work on the developer portal, they weren't indeded to work on GitHub.
I guess we have to use relative links everywhere and cannot use absolute links?

Correct.

static builds https://github.com/onflow/docs


Issue with deployment of mysql-deployment using minikube

This is a...

[ ] Feature Request
[x ] Bug Report

Problem:
When deploying MySQL using minikube, getting this error.
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.5", GitCommit:"17d7182a7ccbb167074be7a87f0a68bd00d58d97", GitTreeState:"clean", BuildDate:"2017-08-31T09:14:02Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"7", GitVersion:"v1.7.5", GitCommit:"17d7182a7ccbb167074be7a87f0a68bd00d58d97", GitTreeState:"clean", BuildDate:"2017-10-06T20:53:14Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
$ kubectl create -f mysql-deployment.yaml
service "wordpress-mysql" created
persistentvolumeclaim "mysql-pv-claim" created
Error from server (BadRequest): error when creating "mysql-deployment.yaml": Deployment in version "v1beta2" cannot be handled as a Deployment: no kind "Deployment" is registered for version "apps/v1beta2"
Proposed Solution:
Page to Update:
https://kubernetes.io/docs/tutorials/stateful-application/mysql-wordpress-persistent-volume/

/cc @steveperry-53
I'm suspecting you saw this or were amazingly prescient during last docs meeting - this applies directly to what you were calling out in terms of specific versions and their implications on our "always published" docs.
The above content does expect a 1.8 cluister, but we 1) don't it out and 2) likely could have kept it at it's earlier version that would still (I think?) work with a past alias to the same API endpoint
Complicating the issue is that minikube still only supports a default of creating 1.7.5 clusters even after the 1.8 release (per https://github.com/kubernetes/minikube/issues/2020)


add waitForTask to set deprecation before loadCollections

Issue: AAH-1596
adding waitForTask to run after setDeprecation and before loadCollection and success handlers.
Also see https://github.com/ansible/ansible-hub-ui/pull/2062 @MilanPospisil

Pr. closed


Revisit transactions to commit check

Now that we have onchain notes, because we receive note IDs based on account ID tags we cannot base the status change on output notes alone, since we might not be receiving all the output notes of a transaction. Perhaps we can re-use the /GetNotesById endpoint
          Yes, let's create an issue to follow up

Originally posted by @igamigo in https://github.com/0xPolygonMiden/miden-client/pull/245#discussion_r1562667499

@bobbinth do you have any comments on this?
Because the client does not get updates for notes that are not for accounts that it is tracking (ie they are not kept on the input notes table), I might not know when a P2ID transaction gets committed (for example, because I sent you a note and so it's for an account I'm not tracking, so I'm not able to tell if the note was included and hence the transaction committed). There's at least 2 solutions for this:

Add the tags for notes we keep in the output notes table when syncing: Probably could end up with lots of unnecessary sync-related data. In the example above it would mean I ask the node for note updates with tags corresponding to your Account ID until I see the note was included.

When checking if a transaction was committed, if there is no other satisfying criteria (no spent nullifier, or no valid account hash update), request GetNotesById for tracked, non-committed, output notes and commit the transaction based on that. The downside would be that this leaks a note ID that the client is interested in. This is what we suggested initially, and the implemented approach on #273.

A couple of thoughts:

If note sender is one of the accounts managed by the client, we should already be getting all required data back during the state sync requests. This is because, the notes returned by from the state sync request are matched based on tags or sender (see here). If this is not currently working, it is possible that there is a bug somewhere in the node, or maybe the client is not making use of this info?
The network always knows the sender of a specific note (in the future, it will be possible to hide this via proxy transactions, but we don't have these implemented yet). This info is recorded in note metadata which is always public. So, using GetNotesById for such notes should not leak too much info (i.e., not more info than is being leaked during state sync requests where we specify the set of accounts we are interested in).

So, basically, I think we should already have all required data (but may need to make sure there are no bugs either on the node or client side), but also that using GetNotesById should be fine, if needed.

closing as #313 got merged


Automatically Select Exploit malfunctions

Using u0 3.3.0 on an iPad7,5 on iOS 11.4, Automatically Select Exploit shouldn’t chooses Sock Puppet. But it does.
Place an "x" between the brackets if true:

[x] this is a bug others will be able to reproduce
[ ] this issue is present with all tweaks uninstalled(except for default packages) or disabled
[ ] this issue is present after a rootfs restore
[x] this issue is present on the latest version of unc0ver

Screen recording:
https://tinyurl.com/yxgtdwyu

Correct, SockPuppet isn’t working on 11.


Pico2 slows down display pack

Yeah, I couldn't believe it either...
Soldered up 2x Pico 2 and 1x Pimoroni Pico Plus 2 to try them out on diplsy packs
On my Pico Ws the display_pack_2_demo runs at 30fps (I added frame timing)
On all Pico 2 devices the FPS drops tro 24fps - tried all three devices I have to hand
Tested on a display pack 2.8 - I have the others as well but doubt there'll be much change (apart from the smallest as it has a smaller screen), the 2 + 2.8 are just a bigger LCD, exact same pixel counts

Ahh - just spotted #985
@Gadgetoid I'll stick my code on Github in a little while and add a note here

Here you go - https://github.com/peardox/display_pack_28

I'm happy if you want to make a pull-request of it and claim the glory :laughing:
I had assumed you were using MicroPython, so I was waaaaaay off.

I was already thinking of doing a PR with the modifications just for the display_pack_28 definitions but also adding the FPS demo will be nicer
I wanna check out the SPI rate as (150/133) * 62,500,000 |= 75,000,000 (actual value is a funny number so wanna experiment first)

And yet changing it to...
//PicoGraphics_PenRGB332 graphics(st7789.width, st7789.height, nullptr);
PicoGraphics_PenRGB565 graphics(st7789.width, st7789.height, nullptr);

Dropped the frame rate from 45.x to 43.5-ish

Oops 888 crashes - mem requirements are 240k for that res but I am on a Pico2 so plenty to spare
Looks like a different bug...

Dropped the frame rate from 45.x to 43.5-ish

That's weird, maybe there is something else at play. You better look at the frame time or even just the update time when trying to optimise your display performance. Though FPS is still interesting.

Tried Pen4, Pen8, Pen332, and Pen565 which all work
Only Pen888 dies horribly (Pen4 just looks horrible)

Pens other than 565 all run thru a frame conversion function

Yup

Now things get even weirder - switched to a PicoW and 332 is 30spf while 565 is 33fps (i.e. faster as you imagined it would)
The opposite rate change the pico2
I also added a method to return the actual SPI rate. The Pico1 won't go above 62,5Mhz and the Pico2 75Mhz
I'll have to switch back to a Pico2 to see what waas reported from a 62.5Mhz request - which according to #985 should be 37.5


add '_is_valid_uuid()' to '_resolve_receiver()' for users without number

fixes #48

In case it's useful for anybody, for sending messages to UUIDS, the image in this issue is needed on top of this https://github.com/bbernhard/signal-cli-rest-api/issues/550#issuecomment-2183276888

interesting.
i am able to sent to UUIDs with bbernhard/signal-cli-rest-api:0.84
thats why i submitted this PR in the first place.

Maybe it had to do with using the bot functions reply vs send. I didn't investigate further but the fix in that issue got released for version bbernhard/signal-cli-rest-api:0.85. So, I guess it doesn't really matter anyways.


Creating question option template for issues

What issue does this PR address?
#3158 I also found a bug in the bug template 😉  Just fixed the link.
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements

[x] The commit follows our guidelines
[x] Unit Tests for the changes have been added (for bug fixes / features)

Other information:
I ran it though a spell checker you might want to run it though a few more.   My English grammar and spelling are not perfect.   Having a grammar review is probably a good idea.

that's a good start! thanks!


4D-Convolution Error

I am trying to run a model with 4-dimensional (3D+time) convolutions.
I am using ConvolutionND for this purpose. However, even though it works fine for 3D, I get the following error with 4D convolutions:
  File "cupy/cuda/cudnn.pyx", line 515, in cupy.cuda.cudnn.getConvolutionForwardAlgorithm (cupy/cuda/cudnn.cpp:5510)
  File "cupy/cuda/cudnn.pyx", line 525, in cupy.cuda.cudnn.getConvolutionForwardAlgorithm (cupy/cuda/cudnn.cpp:5368)
  File "cupy/cuda/cudnn.pyx", line 323, in cupy.cuda.cudnn.check_status (cupy/cuda/cudnn.cpp:1959)
cupy.cuda.cudnn.CuDNNError: CUDNN_STATUS_NOT_SUPPORTED: CUDNN_STATUS_NOT_SUPPORTED

I tried to install chainer with pip install and to build from source. The problem occurs in both cases.
cudnn is v5.1
cuda is v7.5 and I tried with v8.0 as well, same issue

Could you show the parameters you passed to ConvolutionND function? cuDNN seems to have undocumented conditions supported. When I implemented the multi dimensional convolution layer, it caused me some difficulties.

Thanks a lot for your quick answer. I initialize it as follows:
conv=L.ConvolutionND(4, 1, 16, 3, 1, use_cudnn=False)

I will try to reproduce the cuDNN error with your parameter set with extending the test of ConvolutionND link. It would be in a week or so because I have no access to my machine now.

I am already using the CuPy implementation, it works fine, I was just hoping for a speedup with the cuDNN version. Let me know if you get cuDNN to work at some point and thank you for the quick reply and check!

Okay!


[r] Add some whitespace for improved readability

This is a line-count-reducing PR which will help simplify PR #1325 for issue #1346.
It is absolutely trivial, consisting solely of added linebreaks.

Now
that
the
door
has
been
opened
to
whitespace-only
PRs
you
all
just
wait
til
I
get going undoing the atrocities that styler inflicts on us!
all
jyst


Moved events to single jq namespace

There are namespaced names in docs (http://eonasdan.github.io/bootstrap-datetimepicker/Functions/) but not in the code.

PR's to the master will be closed.
We know the namespaces are wrong. We've tried changing them already have run into issues with the change event and collision with jquery. We plan to completely fix this with the next major release.
I'll fix the docs

Ok, thank you!


0.31-beta question suggestion

It also seems that there is no possibility to add article example and question suggestion like in openchat

Antazia, can you show me some examples of what you want to achieve?


feat; Update FlytePlugins v0.4.4 #patch

TL;DR
Update FlytePropeller to use latest FlytePlugins v0.4.4
Type

[x] Bug Fix
[ ] Feature
[ ] Plugin

Are all requirements met?

[x] Code completed
[x] Smoke tested
[x] Unit tests added
[x] Code documentation added
[x] Any pending items have an associated Issue

Complete description
NA

Codecov Report

Merging #177 into master will not change coverage.
The diff coverage is n/a.


OPER-1589 Modify Azure PV resize script to handle size unit better

Script is modified to handle other binary suffixes and decimals, but cannot fully support decimals depending on the k8s.

thanks for linking the k8s https://github.com/kubernetes/kubernetes/pull/100100 in the code @andrewxding

LGTM


[mesheryctl] system check doesn't work as expected

See mesheryctl Command Tracker for current status of commands.
Current Behavior

mesheryctl system check --adapters
!! Meshery Adapter for meshery-linkerd is running but not reachable
!! Meshery Adapter for meshery-osm is running but not reachable
!! Meshery Adapter for meshery-nsm is running but not reachable
!! Meshery Adapter for meshery-app-mesh is running but not reachable
!! Meshery Adapter for meshery-traefik-mesh is running but not reachable
!! Meshery Adapter for meshery-cilium is running but not reachable
!! Meshery Adapter for meshery-istio is running but not reachable
!! Meshery Adapter for meshery-nginx-sm is running but not reachable
!! Meshery Adapter for meshery-consul is running but not reachable

The adapters can be pinged from the UI, and I confirmed that they were deployed on the K8s cluster
mesheryctl system check --operator

Meshery Operators
--------------
Error: Operator not working Get "https://<IP_ADDRESS>:443/apis/apps/v1/namespaces/meshery/deployments/meshery-operator": dial tcp <IP_ADDRESS>:443: i/o timeout

Meshery Operator can be pinged from the UI, and I confirmed that it was deployed on the K8s cluster
Desired Behavior

Screenshots/Logs

Environment

Host OS: Mac
Meshery Server Version: stable-v0.6.91
Meshery Client Version: mesheryctl built locally from master
Platform: Kubernetes

Contributor Guides and Handbook

📚 mesheryctl Contributing Guide
📺 Beginner's guide to contributing to Meshery and mesheryctl
⌨ mesheryctl Command Tracker
⌨ Meshery CLI Commands and Documentation
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@alphaX86 Issue reopened because mesheryctl system check --operator doesn't work.

Copy


iOS - Hybrid app-IOU emails-Subject of the email is "IOU" instead of "User A requests amount"

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.57-0
Reproducible in staging?: N
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5178822
Issue reported by: Applause Internal Team
Action Performed:

Open staging New Expensify Hybrid app.
As User A - Open any 1:1 chat and submit an expense.
As User B - Check the email.

Expected Result:
User B received an email with the subject "[User A] requests [amount]"
Actual Result:
User B received an email with the subject "IOU", which is confusing for the regular user, who may not know the abbreviation meaning
Workaround:
Unknown
Platforms:

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[x] iOS: HybridApp
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Reproduced, is IOU the new expected behavior @trjExpensify ?

If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y

This means it's not exclusive to HybridApp, so it's just a general bug. Let's remove Hybrid from the title.
All that said, we're in the process of fixing the report submission emails - so I don't think we really need to do anything here. CC: @jasperhuangg

Do you agree we can close this, @jasperhuangg ?


NavigationView example

Could you please provide an example of how to setup a simple NavigationView with a few NavigationViewItems? I'm racking my brain and can't figure out how this is expected to done. What props are needed and how it should be it be structured would be super helpful.
Currently I have this which crashes the app instantely:
      <NavigationView
        name="nvSample5"
        height={460}
        header={{string: 'This is Header Text'}}
        paneDisplayMode={NavigationViewPaneDisplayMode.Auto}
        isTabStop={false}
        onSelectionChanged={(event: NativeSyntheticEvent<undefined>) => {}}>
        <NavigationViewItem content={{string: 'Menu Item1'}} />
        <NavigationViewItem content={{string: 'Menu Item2'}} />
      </NavigationView>

Same here. As react-native-xaml is a codegen-based thin wrapper, I'd expect to have a very close to 1:1 mapping with existing xaml strictures/code. For example if I had:
<Grid>
    <NavigationView>
        <NavigationView.MenuItems>
            <NavigationViewItemHeader Content="Main"/>
            <NavigationViewItem Content="Customers"/>
            <NavigationViewItem Content="Orders"/>
            <NavigationViewItemSeparator/>
            <NavigationViewItemHeader Content="Reports"/>
            <NavigationViewItem Content="Customers"/>
            <NavigationViewItem Content="Orders"/>
            <NavigationViewItem Content="Sales"/>
            <NavigationViewItemSeparator/>
            <NavigationViewItemHeader Content="Charts"/>
            <NavigationViewItem Content="Sales by Customer"/>
            <NavigationViewItem Content="Sales by Product"/>
            <NavigationViewItem Content="Sales by Date"/>
        </NavigationView.MenuItems>
    </NavigationView>
</Grid>

I would expect to end up with something like
<Grid>
    <NavigationView>
        <NavigationView.MenuItems>
            <NavigationViewItemHeader content={{string: "Main"}}/>
            <NavigationViewItem content={{string: "Customers"}}/>
            <NavigationViewItem content={{string: "Orders"}}/>
            <NavigationViewItemSeparator/>
            <NavigationViewItemHeader content={{string: "Reports"}}/>
            <NavigationViewItem content={{string: "Customers"}}/>
            <NavigationViewItem content={{string: "Orders"}}/>
            <NavigationViewItem content={{string: "Sales"}}/>
            <NavigationViewItemSeparator/>
            <NavigationViewItemHeader content={{string: "Charts"}}/>
            <NavigationViewItem content={{string: "Sales by Customer"}}/>
            <NavigationViewItem content={{string: "Sales by Product"}}/>
            <NavigationViewItem content={{string: "Sales by Date"}}/>
        </NavigationView.MenuItems>
    </NavigationView>

...which is not really doable right now (no apparent way of defining/adding NavigationView.MenuItems, for starters)

Good request! Definitely would love to have specific jsx examples.
Right now codegen looks at the type of properties as well as whether the property is backed by a DependencyProperty in order to decide what to project; moreover sub-items need custom logic to map children to the right collection property.
(FYI you would not use the NavigationView.MenuItems property, you'd just create the NavigationViewItem/Header/Separator directly inside of the NavigationView tag)
This is all possible for NavigationView, I'll get back in a couple of days :) Keep the feedback coming!

Good bug, thanks again for filing. I just got it to work!

@achipa @jeanmaried See USAGE.md

@asklar awesome! Thank you.


Just send self private messages to all clients without waiting for them to request znc.in/self-message

https://github.com/ircv3/ircv3-specifications/commit/1bfba47843c2526707c902034b3395af934713c8
<dx> and then assume that every client that doesn't have echo-message
     implements what self-message described?
<kaniini> dx: seems reasonable
<dx> right now we could definitely get away with capless self-message

There are lots of clients which don't understand messages in this format.

Which break against that and ZNC couöd make them more interested in fixing it.

No, the only thing such change would do, is to annoy users and force them to downgrade ZNC to a version which doesn't send that.


:gear:  Project set up and ERD implementation :100:

Description

Set up project
Config Linter
Add database using psql recipe_app_development

Related Issues
None
Checklist

[x] Set up project
[x] Config Linter
[x] Add database using psql recipe_app_development
[x] Add the following models user, Food Recipe, Recipe, Recipe Food, Food
[x] Created association and relationship between tables.
[x] Add controllers.
[x] Create the food Add and index page
[x] Add styling to the foods.
[X] Added n+1 in Foods
ttp://<IP_ADDRESS>:3000/foods to see the food inde page
[x] Food list:

[x] Should display a list of food added by the logged-in user as in the wireframe (for teams with only 2 people - display also quantity of a given food).
[x] Should lead to a form that allows users to add new food.

Preview

After migration

Additional Notes
Ruby Version 3.0.2
Thanks for you review :slightly_smiling_face:

@amentetteh  THanks for the review :slightly_frowning_face:


Image failed to display with this plugin

Issue
After decrypting the article the image not show up
Expected Behavior
Should show image
Actual Behavior
Not show up
Steps to Reproduce the Problem
Not yet
Specifications
below is the tag without enable plugin

below is the tag with an enabled plugin

(The version of the project, operating system, hardware etc.)
I'm using the Hexo theme

Can you provide your theme link on github? Make sure we can reproduce the problem.
It looks like your theme use lazyload to fetch images.

Oh yes, my theme is using lazyload so it would conflict with this plugin?

https://nguyentruongkhoi.com/2019/07/12/doi-dieu-ve-macbook-pro-13inch-2019/
password : macbook

Yes, for now. We try to find a good way to support such funcnality.
You can add the following code to https://github.com/MikeCoder/hexo-blog-encrypt/blob/1a9073258567a56514cf0363e4f24eafe2ca4482/lib/blog-encrypt.js#L187 for temporary fix.
      document.getElementById('hexo-blog-encrypt').appendChild(await convertHTMLToElement(decoded));
      document.getElementById('hexo-blog-encrypt').appendChild(hideButton);

      // add code here
      document.querySelectorAll('img').forEach((elem) => {
        if (elem.getAttribute("data-src") && !elem.src) {
          elem.src = elem.getAttribute('data-src');
        }
      });
      //=======

      // TOC part
      var tocDiv = document.getElementById("toc-div");
      if (tocDiv) {
        tocDiv.style.display = 'inline';
      }

Or try to update plugin to v3.0.3.


🚀 Feature: Docker OAuth Login Environment Variables

🔖 Feature description
When using docker you should be able to predefine OIDC/OAuth logins directly with environment variables.
🎤 Pitch
Don't get me wrong, configuring it via the web page is nice to have, but all services I've used so far (that support OIDC/OAuth) allowed me to configure it via environment variables. (Example: Outine Wiki)
For the everyday user this may not be a huge deal, but especially in environments with a lot of containers something like this could speed up deployment.
This isn't really a necessity, just a nice-to-have feature.

I think it would make sense if all configuration variables were overrideable with environment variables because there was also a request if the APP_URL can be configurable with environment variables (#258).

That would be great!

I'm closing this because #258 is a similar request. This doesn't mean that I won't implement this feature.


SliverAppBar doesn't work as expected with CustomScrollView using center property

Here's the sample code to reproduce the bug. The floating SliverAppBar should appear when we scroll up but this is not the case when center property is used with CustomScrollView. (This is a copy of https://github.com/flutter/flutter/issues/39715 as it has been closed with no solution)
Even Google official Package for indexed lists (https://pub.dev/packages/scrollable_positioned_list) is using center to set the initial position. We need an official solution to this issue.
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  Key centerKey = UniqueKey();
  int initialTopItemIndex = 5;
  List<Widget> list = List<Widget>();

  @override
  Widget build(BuildContext context) {
    for(int i = 0; i < 100; i++) {
      list.add(ListTile(title: Text('$i')));
    }

    return Scaffold(
      body: CustomScrollView(
        center: centerKey,
        slivers: [
          SliverAppBar(
            title: Text('Sliver App Bar'),
            floating: true,
            snap: true,
          ),
          SliverList(
            delegate: SliverChildListDelegate(
              list.sublist(0, initialTopItemIndex).reversed.toList(),
            ),
          ),
          SliverList(
            key: centerKey,
            delegate: SliverChildListDelegate(
              list.sublist(initialTopItemIndex, initialTopItemIndex + 1),
            ),
          ),
          SliverList(
            delegate: SliverChildListDelegate(
              list.sublist(initialTopItemIndex + 1),
            ),
          ),
        ],
      ),
    );
  }
}

Expected results:
The Appbar should be able to float/pin/snap regardless of the use of a center property
Actual results:
The app bar stays on top of the list and gets scrolled

Logs

[✓] Flutter (Channel stable, 3.7.6, on macOS 13.2.1 22D68 darwin-arm64, locale
    en-CA)
    • Flutter version 3.7.6 on channel stable at /Users/adi/Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 12cb4eb7a0 (6 days ago), 2023-03-01 10:29:26 -0800
    • Engine revision ada363ee93
    • Dart version 2.19.3
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/adi/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.76.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.60.0

[✓] Connected device (3 available)
    • sdk gphone64 arm64 (mobile) • emulator-5554 • android-arm64  • Android 13
      (API 33) (emulator)
    • macOS (desktop)             • macos         • darwin-arm64   • macOS
      13.2.1 22D68 darwin-arm64
    • Chrome (web)                • chrome        • web-javascript • Google
      Chrome 110.0.5481.177

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

This issue is reproducible on the latest stable and master channels.
@Piinks has already explained at https://github.com/flutter/flutter/issues/39715#issuecomment-604713825 but it seems someone still has issue with this. So I will label this issue for further insights.
cc @Piinks for thoughts.
Demo video

using center
without using center

Adding expandedHeight to see the issue more clearly:

Sample code
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  Key centerKey = UniqueKey();
  int initialTopItemIndex = 5;
  List<Widget> list = [];

  @override
  Widget build(BuildContext context) {
    for(int i = 0; i < 100; i++) {
      list.add(ListTile(title: Text('$i')));
    }

    return Scaffold(
      body: CustomScrollView(
        center: centerKey,
        slivers: [
          SliverAppBar(
            title: Text('Sliver App Bar'),
            floating: true,
            snap: true,
            expandedHeight: 150.0,
          ),
          SliverList(
            delegate: SliverChildListDelegate(
              list.sublist(0, initialTopItemIndex).reversed.toList(),
            ),
          ),
          SliverList(
            key: centerKey,
            delegate: SliverChildListDelegate(
              list.sublist(initialTopItemIndex, initialTopItemIndex + 1),
            ),
          ),
          SliverList(
            delegate: SliverChildListDelegate(
              list.sublist(initialTopItemIndex + 1),
            ),
          ),
        ],
      ),
    );
  }
}

flutter doctor -v (stable and master)
[✓] Flutter (Channel stable, 3.7.6, on macOS 13.0.1 22A400 darwin-x64, locale en-EE)
    • Flutter version 3.7.6 on channel stable at /Users/huynq/Documents/GitHub/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 12cb4eb7a0 (4 days ago), 2023-03-01 10:29:26 -0800
    • Engine revision ada363ee93
    • Dart version 2.19.3
    • DevTools version 2.20.1

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.75.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.60.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 110.0.5481.177

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[!] Flutter (Channel master, 3.9.0-1.0.pre.73, on macOS 13.0.1 22A400 darwin-x64, locale en-EE)
    • Flutter version 3.9.0-1.0.pre.73 on channel master at /Users/huynq/Documents/GitHub/flutter_master
    ! Warning: `flutter` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/flutter, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    ! Warning: `dart` on your path resolves to /Users/huynq/Documents/GitHub/flutter/bin/dart, which is not inside your current Flutter SDK checkout at /Users/huynq/Documents/GitHub/flutter_master. Consider adding /Users/huynq/Documents/GitHub/flutter_master/bin to the front of your path.
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 9e5bec62eb (68 minutes ago), 2023-03-07 02:48:10 -0500
    • Engine revision 1c4aab7da9
    • Dart version 3.0.0 (build 3.0.0-300.0.dev)
    • DevTools version 2.22.2
    • If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades.

[✓] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
    • Android SDK at /Users/huynq/Library/Android/sdk
    • Platform android-33, build-tools 31.0.0
    • ANDROID_HOME = /Users/huynq/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14B47b
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio
    • Android Studio at /Applications/Android Studio Preview.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    ✗ Unable to find bundled Java version.
    • Try updating or re-installing Android Studio.

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] IntelliJ IDEA Community Edition (version 2022.1.1)
    • IntelliJ at /Users/huynq/Library/Application Support/JetBrains/Toolbox/apps/IDEA-C/ch-0/221.5591.52/IntelliJ IDEA CE.app
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.76.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.60.0

[✓] Connected device (4 available)
    • Pixel 3a (mobile)      • 964AY0WL20                           • android-arm64  • Android 12 (API 32)
    • iPhone 14 Pro (mobile) • AB2EBB55-6852-40A7-9A12-057128370920 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-1 (simulator)
    • macOS (desktop)        • macos                                • darwin-x64     • macOS 13.0.1 22A400 darwin-x64
    • Chrome (web)           • chrome                               • web-javascript • Google Chrome 110.0.5481.177

[✓] Network resources
    • All expected network resources are available.

! Doctor found issues in 2 categories.

Thank you @Piinks for reconsidering this issue.
Maybe this wasn't the intended use of center, but this is currently the main logic that makes the package scrollable_positioned_list work. The ScrollController.initialScrollOffset works perfectly until you are looking to set an initial position for list items that have a variable size. It then become unpredictable and makes ScrollController.initialScrollOffset a bad solution. I think that it's for that exact reason, that the Google Team was forced to use the center parameter.
Additionally, I also think that a SliverAppBar should not be impacted by the growing direction of the list. It should be on top regardless of the direction that remainder of the list grew from and keep reacting based on the scroll direction.

Additionally, I also think that a SliverAppBar should not be impacted by the growing direction of the list.

That would likely be a big breaking change. For example, what about when ScrollView.reverse is true?

@Piinks I get what you are saying and you are right on that point. Perhaps, having a parameter to set behaviour of SliverAppBar would make the most sense here. Something like CollapseDirection.reverse (Sorry not the best an naming methods) that would set the general behavior of the SliverAppBar depending on if the scroll direction is up/down or right/left.  (This could also be passed down from the CustomScrollView to the SliverAppBar as it sets the general behavior of the ScrollView)
This way would prove to be extremely useful especially when the ScrollView has a combination of growing direction.
I understand this would be a breaking change but this would be a very welcomed change by the community, especially for those that are looking to build great looking Social Media Apps as navigating a list by it's index is a really common use case.

navigating a list by its index is a really common use case.

IMO, this appears to be the root issue here, not the SliverAppBar.

@Piinks It is! For 4 years, the only solution that was provided to us is the scrollable_positioned_list, and the main thing that glues this solution together is the center property. To me, solving the center issue appeared to be the most logical way to tackle this challenge other than reinventing the whole package.

I also have this issue, and wrote up my use-case (with code sample) to illustrate my problem. Please see the related issue: https://github.com/flutter/flutter/issues/132841
My use case is slightly different: I have list that infinitely scrolls in both directions, and the only way achieve this is to use the center property. And that breaks the behaviour of floating SliverAppBar.
Imho, a floating app bar should be revealed when a user scrolls upwards, and that's not happening. I'm afraid I don't understand how the current behaviour can be "expected". The bar doesn't appear on the part that grows upwards, or downwards, regardless of the scroll direction :shrug:
Thanks for taking a look


rangeproof: clarify rewind outlen argument

Found this note on this in @thomaseizinger's rust-secp256k1-zkp:
// TODO: File bug with upstream: message length is not set correctly

The message length is okay but this is a doc bug.

It's a bit of a confusing API, but I think it would be breaking to try to change it.

It's a bit of a confusing API, but I think it would be breaking to try to change it.


[Market OL] Bug(?) on display date @  recent history widget

Is this still happening for you? Cause I can't reproduce it.

yea

Closing this since we've had no other reports of it and I can't reproduce it.


Appstudio update test-component-pac-jfqi

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-jfqi-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
15 seconds
clone-repository

✅ Succeeded
36 seconds
build-container

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
18 seconds
inspect-image

✅ Succeeded
17 seconds
deprecated-base-image-check

✅ Succeeded
14 seconds
clair-scan

✅ Succeeded
12 seconds
sbom-json-check

✅ Succeeded
14 seconds
label-check

✅ Succeeded
8 seconds
show-summary

✅ Succeeded
6 seconds
show-sbom

Pipelines as Code CI/test-component-pac-jfqi-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
15 seconds
clone-repository

✅ Succeeded
36 seconds
build-container

✅ Succeeded
14 seconds
clair-scan

✅ Succeeded
17 seconds
deprecated-base-image-check

✅ Succeeded
1 minute
clamav-scan

✅ Succeeded
18 seconds
inspect-image

✅ Succeeded
12 seconds
sbom-json-check

✅ Succeeded
14 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
8 seconds
show-summary

Pipelines as Code CI/test-component-pac-jfqi-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
7 seconds
init

✅ Succeeded
19 seconds
clone-repository

✅ Succeeded
34 seconds
build-container

✅ Succeeded
17 seconds
deprecated-base-image-check

✅ Succeeded
19 seconds
inspect-image

✅ Succeeded
13 seconds
sbom-json-check

✅ Succeeded
13 seconds
clair-scan

✅ Succeeded
59 seconds
clamav-scan

✅ Succeeded
13 seconds
label-check

✅ Succeeded
8 seconds
show-sbom

✅ Succeeded
10 seconds
show-summary


Simplify the isPDFFunction helper function

Originally we used helper functions for checking if something was a Dictionary or Stream, and then having an initial typeof check probably made sense. However, given that we're using instanceof nowadays the additional check longer seems necessary.

/botio test


RATIS-1120. Terminate election in advance if majority peers reject

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
What is the link to the Apache JIRA
(Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. RATIS-XXXX. Fix a typo in YYY.)
Please replace this section with the link to the Apache JIRA)
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

@dengziming Thanks for the first PR.  Please fill What changes were proposed in this pull request?,  What is the link to the Apache JIRA?, How was this patch tested?.

@runzhiwang ,Hi, I changed the comment, please take a look.

reopen pr to trigger ci.

@dengziming Thanks the first patch. I have merged it. Looking forward to your more contribution.


Cancelling opening a new project clears the on-screen map

Unsure if this partially closes the project or not, as some operations (such as saving, closing, and viewing the province properties pane) are still able to be performed.

As an additional note, if no project was already opened when this happens, pressing escape will cause a segmentation fault in MapNormalizer::GUI::ProvincePropertiesPane::setProvince(MapNormalizer::Province*, std::weak_ptr<unsigned char const []>).
See valgrind output:
==11305== Process terminating with default action of signal 11 (SIGSEGV)
==11305==  Access not within mapped region at address 0x8
==11305==    at 0x523D88: MapNormalizer::GUI::ProvincePropertiesPane::setProvince(MapNormalizer::Province*, std::weak_ptr<unsigned char const []>)
==11305==    by 0x513870: MapNormalizer::GUI::MainWindow::initializeWidgets()::$_7::operator()(_GdkEventKey*) const
==11305==    by 0x51378F: sigc::adaptor_functor<MapNormalizer::GUI::MainWindow::initializeWidgets()::$_7>::deduce_result_type<_GdkEventKey* const&, void, void, void, void, void, void>::type sigc::adaptor_functor<MapNormalizer::GUI::MainWindow::initializeWidgets()::$_7>::operator()<_GdkEventKey* const&>(_GdkEventKey* const&) const
==11305==    by 0x513763: sigc::internal::slot_call1<MapNormalizer::GUI::MainWindow::initializeWidgets()::$_7, bool, _GdkEventKey*>::call_it(sigc::internal::slot_rep*, _GdkEventKey* const&)
==11305==    by 0x540D1CA: ??? (in /usr/lib/x86_64-linux-gnu/libgtkmm-3.0.so.1.1.0)
==11305==    by 0x66CF7FA: ??? (in /usr/lib/x86_64-linux-gnu/libgtk-3.so.0.2200.30)
==11305==    by 0x864010C: g_closure_invoke (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.5600.4)
==11305==    by 0x8652BF0: ??? (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.5600.4)
==11305==    by 0x865B0AE: g_signal_emit_valist (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.5600.4)
==11305==    by 0x865C12E: g_signal_emit (in /usr/lib/x86_64-linux-gnu/libgobject-2.0.so.0.5600.4)
==11305==    by 0x6817533: ??? (in /usr/lib/x86_64-linux-gnu/libgtk-3.so.0.2200.30)
==11305==    by 0x66CC93E: ??? (in /usr/lib/x86_64-linux-gnu/libgtk-3.so.0.2200.30)


DownArrow not working

Issue Type: Bug
Hi! My DownArrow is not working properly, I can't move one line down using the down arrow. Think it happened after an upgrade yesterday. Have tried restarting laptop and program. UpArrow is working fine. Have checked Keyboard Shortcuts, but cannot find anything unexpected there either. Except from moving down to the next line, I can use the DownArrow together with other keys (for example Ctrl+DownArrow) to scroll down.
VS Code version: Code 1.58.1 (2aeda6b18e13c4f4f9edf6667158a6b8d408874b, 2021-07-13T06:20:02.397Z)
OS version: Linux x64 5.10.0-1034-oem
Restricted Mode: No

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz (8 x 3361)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onrasterization: disabled_softwareskia_renderer: enabled_onvideo_decode: disabled_softwarevulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 0

Memory (System)
15.30GB (8.44GB free)

Process Argv
. --crash-reporter-id 96c69cff-54e5-41c7-bf6e-223c7ba29973

Screen Reader
no

VM
0%

DESKTOP_SESSION
ubuntu

XDG_CURRENT_DESKTOP
Unity

XDG_SESSION_DESKTOP
ubuntu

XDG_SESSION_TYPE
x11

Extensions (14)

Extension
Author (truncated)
Version

toggle-comments
Art
0.3.7

vscode-dbt
bas
0.4.1

bracket-pair-colorizer
Coe
1.0.61

snippet
dev
1.0.1

gitlens
eam
11.6.0

vscode-great-icons
emm
2.1.79

vscode-dbt-power-user
inn
0.5.4

python
ms-
2021.6.944021595

vscode-pylance
ms-
2021.7.3

jupyter
ms-
2021.8.1013163132

vsliveshare
ms-
1.0.4568

jinjahtml
sam
0.16.0

trailing-spaces
sha
0.3.1

plsql-language
xyz
1.8.2

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
pythonvspyt700cf:30270857
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551cf:30311713
vspre833:30321513
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
pythondataviewer:30285071
vscus158:30321503
pythonvsuse255:30335481
vscod805cf:30301675
pythonvspyt200:30331937
vscextlangct:30333562
binariesv615:30325510
bridge0708:30335490

Command Palette: Developer: Toggle Keyboard Shortcuts Troubleshooting , clear the Output view, and then press a downArrow.  What do you see.  You should see a final line something like this:
[2021-07-16 12:25:51.376] [renderer1] [info] [KeybindingService]: \ From 16 keybinding entries, matched cursorDown, when: textInputFocus, source: built-in.
What do you get?

That helped me find what was wrong, thanks! Had accidentally assigned the DownArrow key as a first key of a shortcut (instead of last) :facepalm: Issue can be closed.

Glad it worked - You can close the issue yourself.


WARNING: unable to extract og:image;

Checklist

[ ] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2019.07.30
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[ ] I've read bugs section in FAQ

Verbose log

$ youtube-dl -v -f dash_hd_src https://www.facebook.com/719853864726295/posts/2172061039505563/?sfnsn=mo
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-f', 'dash_hd_src', 'https://www.facebook.com/719853864726295/posts/2172061039505563/?sfnsn=mo']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.07.30
[debug] Python version 3.6.8 (CPython) - Linux-4.15.0-55-generic-i686-with-Ubuntu-18.04-bionic
[debug] exe versions: none
[debug] Proxy map: {}
[facebook]<PHONE_NUMBER>505563: Downloading webpage
WARNING: unable to extract og:image; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[debug] Invoking downloader on 'https://scontent.fpnq7-1.fna.fbcdn.net/v/t39.24130-6/10000000_414239885829303_4537815856357327132_n.mp4?_nc_cat=101&efg=eyJ2ZW5jb2RlX3RhZyI6Im9lcF9oZCJ9&_nc_oc=AQnxkwh9u_uDRsPmnzonGbpr9TwSUSjWportdM2p6tMXsl1NkXcOpk_T96IT-2jb2y0dBhvvo6bv0G3SrJfiUUmA&_nc_ht=scontent.fpnq7-1.fna&oh=a0093a45659683f2a80f6c9dcea3ce1b&oe=5DA80529'
[download] Destination: You’re invited...  Join us in this FREE online masterclass with Marisa Peer –...-2172061039505563.mp4

Description

It looks like a minor thing, it threw warning.
It downloads the video file and plays well.

Also fails to extract the title
WARNING: Unable to extract video title

@ytdl-org why was the comment deleted exactly?


Remove guid from MiqGroups

From all the Git spelunking @jrafanie and I have done, guid on MiqGroups appears to have been added when the model was originally created but never used. Gutting this as part of our user_group table split.

@miq-bot core, tenancy, technical debt

@miq-bot add_label core, tenancy, technical debt

You know, this got me thinking...do we even need GUIDs in any of the tables?  I think it was originally for VMs, particularly with the old blackbox code, but I really don't think we use it at all anywhere.  @gmcculloug @gtanzillo @chessbyte ?

@chrisarcand Had a small comment above, but looks good

You know, this got me thinking...do we even need GUIDs in any of the tables? I think it was originally for VMs, particularly with the old blackbox code, but I really don't think we use it at all anywhere. @gmcculloug @gtanzillo @chessbyte ?

@Fryguy I like the direction you're taking this...  :scissors: :fire:

LGTM

@Fryguy I recall that we also needed the guids for supporting export and import from one DB to another to allow for matching existing records that would have different IDs but the same guid. Not sure if we even support that with groups.

So I did a quick search on the schema.rb and I see it in:
chargeback_rates
conditions
custom_buttons
ext_management_systems
hosts
jobs
lifecycle_events
miq_actions
miq_ae_workspaces
miq_alerts
miq_event_definitions
miq_groups
miq_policies
miq_regions
miq_servers  (I think this one is ok)
miq_sets
miq_widgets
miq_workers
networks
providers
scan_items
service_templates
services
vms

@gmcculloug can you comment on the DB import/export bit?  If that's the case, maybe we can pare down that list to just the tables we actually import/export.

The test failure was easy to fix once I did #6970, pushed to my fork...
https://github.com/jrafanie/manageiq/commit/d89772c54bf4e14017d0f71b24b47192ee662ec2.patch
git am that patch and it should be good to go.

Thanks!

@jrafanie I think this one's ready, thanks for getting it in order for us!
@Fryguy @gmcculloug Let's continue the ':skull: GUID?' discussion in a new issue, I don't want to lose track of it :smiley:

Looks good to me, let's handle the followup work in #6991

Good to go :+1:


Simplify package name.

This PR fixes https://github.com/asyml/forte-wrappers/issues/43.
Description of changes
Rename the package name to forte and fix the corresponding README.
Possible influences of this PR.
Describe what are the possible side-effects of the code change.
Test Conducted
Describe what test cases are included for the PR.

Perhaps twitter related processors haven't been changed folder name to forte?

Right, I didn't merge with master when doing the renaming. Now it should be done.


Attempt to fix "too many open files" error

shorter write timeout for http server
closing the body of echo requests manually

Coverage increased (+0.07%) to 46.23% when pulling 3c6156207e19dabdf7c806b4aca1fecc4b080b6e on tcp_accept_error_fix into a402bef243930f4e0614b7111458e9653717f30d on master.

This could of course be related to the problem but it would be nice if we could write a test case to open many connections in a loop and see if we can reproduce the too many open files problem. We don’t need to run this test always but it would be nice to have a test to try it and that we can rerun later to reproduce and similarly check if the fix actually didn’t cause the problem.
Also it would be relevant to look over the code for other missing close calls.

Not that we could run such a test in a separate VM and set the open file count to some reasonable small number.

Merging now


Yarn is not installed

We are using a self-hosted runner and using this action to setup-node and install yarn.
I know on github-hosted runners, yarn is already pre-installed but it would be good if yarn was installed by this action for those of us using self-hosted.
Running setup-node with the following workflow and it works
 with:
    node-version: 12.13.0
    always-auth: true
    registry-url: https://registry.npmjs.org

/usr/bin/tar xz --warning=no-unknown-keyword -C /actions-runner/_work/_temp/febce1c0-314e-4a14-9a65-5bde8a990b71 -f /actions-runner/_work/_temp/d4bf33ab-571e-458e-9495-bd6c5b994814
/actions-runner/_work/_tool/node/12.13.0/x64/bin/node --version
v12.13.0
/actions-runner/_work/_tool/node/12.13.0/x64/bin/npm --version
6.12.0

Note that node and npm are installed.
A later step in the workflow then attempts to run yarn:
Run yarn install --ignore-scripts --frozen-lockfile
/actions-runner/_work/_temp/58e53b82-f9ae-4c68-9cec-75f75831208b.sh: line 1: yarn: command not found
##[error]Process completed with exit code 127.

This of course works on github hosted runners just fine, but since I just migrated to an EC2 instance that doesn't have yarn installed, I am now having issues.

Workaround is to install yarn yourself using npm
- name: Install Yarn
   run: npm install -g yarn

and later can uninstall it -
- name: Uninstall Yarn
   if: always()
   run: npm uninstall -g yarn

the workaround didn't work for me as also npm is not found. how did you install npm?

GitHub Runners creates a file called .path in the same directory where you have config.sh. It contains the content of $PATH variable, which is further used during the execution of your workflows.
You have to add a directory with the yarn binary.  In my case:
/home/github/.yarn/bin`

@pperzyna thanks! I spent 30mins guessing why it was not working even after updating the path. Seems run.sh has to be restarted.

@pperzyna thanks! I spent 30mins guessing why it was not working even after updating the path. Seems run.sh has to be restarted.

npm install -g yarn

Hey @GoldFlsh , why should we uninstall yarn at the end of a job?

@konsalex Since self-hosted runners are shared and are not a clean instance per job execution, like a github hosted runner would be, the job should do its best to clean itself up after a run so that each future workflow run is running on what amounts to a fresh instance.
If you install software during the run, such as yarn, redis, or terraform without uninstalling it, could potentially cause conflicts with other jobs running as the state of the instance moves further away from the original state.
Say then you try to upgrade versions of something in your workflow but since the old version is still installed from a previous run it may use that and create a difficult to debug situation.
As others have mentioned you can pre-install any software on a self-hosted runner so the workflow itself does not have to be responsible for installing anything, which would side-step this altogether.
Up to you, of course, how you best want to manage that 😃
https://docs.github.com/en/actions/hosting-your-own-runners/about-self-hosted-runners#differences-between-github-hosted-and-self-hosted-runners

Note that if you use with: cache: yarn this action will fail if you don't have yarn pre-installed... But since you need node to install yarn.. you can't get out of this.

To +1 on Davide's comment, the lack of yarn install support is a significant obstacle to those of us on self-hosted runners.
The only way to break the chicken-or-egg with: cache: yarn problem, and make caching work on self-hosted runners, is to preinstall yarn on the runner base image (like GitHub does for its own runners). This is not good because then yarn is being managed both by setup-node, and out-of-band by the preinstall step.

Hi everyone. I faced the same problem and this may sound really stupid, but I solved it this way:
(Thanks for the tip, @davide-bertola-deltatre)
jobs:
  node-ci:
    runs-on: self-hosted
    steps:
      - uses: actions/checkout@v2

      - name: Setup Nodejs and npm
        uses: actions/setup-node@v2
        with:
          node-version: "14"

      - name: Setup yarn
        run: npm install -g yarn

      - name: Setup Nodejs with yarn caching
        uses: actions/setup-node@v2
        with:
          node-version: "14"
          cache: yarn

      - name: Install dependencies
        run: yarn

NOTE: This way, if you run the yarn uninstall in the step, the Post process will not be able to find yarn and the job will fail.
Actions log shows that the cache was successful, but I am not sure if it is really cached in this case.
Cache Size: ~118 MB (124177777 B)
Cache saved successfully
Cache saved with the key: foo-bar-baz

When I connected to the runner instance that ran the job and ran the yarn command, I got not found, so everything seems to be working. However, this is not an essential solution and I also hope that yarn will be installed with it.

FYI: There isn't a chicken-and-egg problem, you don't need Node to install yarn:
curl -fsSL -o ~/bin/yarn \
  https://github.com/yarnpkg/yarn/releases/download/v1.22.17/yarn-1.22.17.js

I think the point of contention here is that we need to return the runner back clean. It's easy enough to install the binaries, but given the hassle of making sure they're purged every time, I'd prefer to see them included under Node's control

GitHub Runners creates a file called .path in the same directory where you have config.sh. It contains the content of $PATH variable, which is further used during the execution of your workflows.
You have to add a directory with the yarn binary. In my case:
/home/github/.yarn/bin`

Thanks @pperzyna
Let me share my approach, maybe it will useful.
Find out where is the yarn
First on your server run:
which yarn
then you got the yarn location, like this
/home/admin/.nvm/versions/node/v16.14.0/bin/yarn

copy the path (not including the yarn)
/home/admin/.nvm/versions/node/v16.14.0/bin

Edit path
run
nano .path

you got something like
aaaaa:bbbb:cccc
separated with :
then paste the /home/admin/.nvm/versions/node/v16.14.0/bin
so the .path become
aaaaa:bbbb:cccc:/home/admin/.nvm/versions/node/v16.14.0/bin
Don't add the enter or something. Just give the : and paste next to it
Restart runner
You need restart it. so it will load the new path
Mostly you are running with svc.sh then stop it
sudo ./svc.sh stop

Run it again
sudo ./svc.sh start

While Node 17 isn't LTS, moving forward with Node 18 LTS (or >=16.10 LTS) it would be great if corepack enable was automatically run if the cache is yarn or pnpm.
Corepack is part of the node install itself and contains both yarn and pnpm but is currently opt-in. It's also the recommended way to use/install yarn 2+.
You can enable it manually in a single step which fixed the issue for me:
jobs:
  build:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v3
    - uses: actions/setup-node@v3
      with:
        node-version: '17'
        cache: 'yarn'
    - run: corepack enable
    - run: yarn install
    - run: yarn lint

While Node 17 isn't LTS, moving forward with Node 18 LTS (or >=16.10 LTS) it would be great if corepack enable was automatically run if the cache is yarn or pnpm.
Corepack is part of the node install itself and contains both yarn and pnpm but is currently opt-in. It's also the recommended way to use/install yarn 2+.
You can enable it manually in a single step which fixed the issue for me:
jobs:
  build:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v3
    - uses: actions/setup-node@v3
      with:
        node-version: '17'
        cache: 'yarn'
    - run: corepack enable
    - run: yarn install
    - run: yarn lint

This doesn't solve this issue. It's only working for you because you're using runs-on: ubuntu-latest which has yarn installed by default.

Hi, a lot of great answers here!
Based on @jasonk's solution, to run setup-node on a self-hosted runner we're doing this (2023 edition):
...
- name: Install yarn
        run: |-
          curl -fsSL --create-dirs -o $HOME/bin/yarn \
          https://github.com/yarnpkg/yarn/releases/download/v1.22.19/yarn-1.22.19.js
          chmod +x $HOME/bin/yarn
          echo "$HOME/bin" >> $GITHUB_PATH

- name: Setup node
   uses: actions/setup-node@v3
   with:
      node-version: 16
      cache: 'yarn'
...

Curl needs the --create-dirs option, otherwise it cannot write to a not-yet-existing directory and complains with (23) Failed writing body.
Also, you need to add whatever folder you're copying the yarn executable into to $GITHUB_PATH in order for setup-nodeto pick it up.

Okay, it's 27th of December, 2023. This issue was created on Aug 12, 2020. That makes the issue over 3 years old. Now, since I've read through the whole thread, several times, including the reasons after reasons not to do anything, writing of which adds up to an amount of effort that can accommodate the trivial fix needed for the issue at hand - several times - and still have enough left to pop a comment on here, informing everyone of his colossal achievements, get praised.
Let me get this straight, the solution is for the consumers to:

download an orphaned yarn bin
append the bin location to $GITHUB_PATH

which will prove an agony if you hoped to at least keep that shit out of the workflow

run actions/setup-node
so that we can then exec $ yarn
That's quite an amusing procedure, I admit.
So, what about those who are not using or have migrated from the legacy obsolete, unmaintained, unsupported, ancient yarn 1.* (that luckily doesn't provide proper binaries for the last release, but rather the aforementioned orphaned bin we use as a workthefaroundabout) and have pretty much no choice but to use corepack - the official tool for managing node package managers - to install yarn?
Are we gonna have to exploit quantum state to both install it and not install it for this shit to work, or we adding support for something that node took ownership of? It is not a separate concern anymore.

tldr.
Anyways, done with the rant, debugging self-hosted runners combined with this, well, definitely doesn't qualify as fun.
I'll put up a PR proposal for fixing this later/tomorrow, depending on how much of yarn installation control I end up having to expose.

Running into this issue in July 2024...
Current workaround:
vitest:
  runs-on: ubuntu-latest

  steps:
    - uses: actions/checkout@v4
    - name: Set up Node
      uses: actions/setup-node@v3
      with:
        node-version: 20
        cache: 'yarn'
    # FIXME: Because the setup-node action is dumb, we have to manually
    #        install the dependencies ourselves. See: https://github.com/actions/setup-node/issues/182
    - name: Install dependencies
      run: yarn install
    - name: Run tests
      run: yarn test:unit:ci

Just putting it out there. For me the problem was the docker engine which was preinstalled with ubuntu 20.4.
I installed  yarn globally, the path existed in ENV, I could succesfully execute yarn via cli but I would get the "yarn: command not found" error message whenever the self-hosted runned was executed.
Unistalling the docker engine fixed the issue for me. I do not no the reason for this.


yabai: 6.0.4 -> 6.0.5

Description of changes
https://github.com/koekeishiya/yabai/blob/master/CHANGELOG.md#605---2024-01-07
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 279478 run on aarch64-darwin 1

1 package built:

yabai


Add Storybook for easier component dev/test

Feature request 🚀

[x] I will create Pull Request
[ ] It's just a suggestion

Expected
It's Hacktoberfest time, and I'd like to dedicate part of my time to integrate Storybook with your project. Is it something that you guys would find useful?
(I already have a proof of concept working BTW)

I think this is pretty good. Since it would add to the maintenance burden, I suggest you create the project under your own name, I can add a link to it in Gesit as an introduction if you can keep up the maintenance.
(I've had similar thoughts to yours 🤣 )

PS
I'm starting a business these days so maintenance on this project will be very infrequent, if there are no serious bugs I'll delay updates until I get back.

Keeping it separate from the main source repo defeats the purpose IMO, but I understand your concerns.


how to make MDC work with MessageReceiver

Hi
In the "main" thread I set up some values in the MDC.
the pubsub api spawns a number of threads.
How do I make the threads "aware" of the threadlocal MDC dict?
Moreover, I would like to add the messageId in the MDC itself.

@ZeeD Currently streaming receiver manages ack and nack automatically and is not exposing messageId to client. If you are looking for control on received message, you can use pulling subscriber as in example over here

@ajaaym But also with pulling subscribers, there is no way for me to set up some behavior at the creation of a new thread.
I can create a new Subscriber with the builder and pass a custom InstantiatingExecutorProvider with my implementation of a ThreadFactory but still there are some threads created bypassing that provider

@ZeeD If you use pulling subscriber then, there are only two other place where threads are getting created. 1. gax 2. grpc. Gax uses ExecutorProvider thats pass down while creating client and gax uses event loop if not provided at time of creating client, it creates new one. Here is the example of passing event loop.

@ZeeD Did the above example help you out, or are you still having issues here?


handle exec (shellcode) failed in lazy page allocation

what do I have to do here I am a novice and did not even know I was part of an open source w3 project on GitHub and I basically finished it and I think its on the wrong Mac?   The css bundle is starting to update to newer version but I want to opt out
HELP
<EMAIL_ADDRESS>

This project was purely a learning experience for myself and is unmaintained. Please refer to pdos.csail.mit.edu/6.828/2014/xv6.html and related material for help.


OpenPhone on Raspberry Pi Compute Module 4

Hi, I wanted to try OpenPhone on a Raspberry Pi 4.
Current status : I can call from the USB phone to another phone.
When I try to pickup an incoming call the phone keeps ringing.....
Just wanted to write this what I have done so far to make this work on a Raspberry Pi 4:)
Installed Raspberry Pi OS (Legacy) Buster 2022-04-04 (so we have python2 as default)
With Compute Module IO Board, USB ports are disable by default!
(you can find a lot on the internet for this, but you need to add dtoverlay=dwc2,dr_mode=host to the /boot/config.txt to enable)
Then I followed the OpenPhone installation with these modifications :
Enable SPI :
in /boot/config.txt add/change dtparam=spi=on
(or use the raspberry config tool)
Install dependencies.
libttspico-utils is in buster non-free : so add buster non-free to the repo list.
wget -q https://ftp-master.debian.org/keys/release-10.asc -O- | apt-key add -
echo "deb http://deb.debian.org/debian buster non-free" >> /etc/apt/sources.list
apt-get update
apt -y install git libttspico-utils python-dev python-lxml python-requests python-flask python-pyaudio mpd python-mpd python-configparser python-pip python-setuptools libhidapi-libusb0
sudo pip install wheel
sudo pip install flask-bootstrap
Then "sudo pip install hid" will install the wrong python usb hid component.
sudo pip install cython
sudo pip install hidapi==0.9.0
(latest hidapi version doesn't support python2 anymore)
Then follow the rest of the installation but before you start openphone.py make these additional changes.
search openphone.py  for spi.open(1,0) # For Neopixels
The raspberry has /dev/spidev0.0 and /dev/spidev0.1 but not 1.0
I changed this in 0,1 but I don't know if this should be 0.0 and if this only means some lights are not working.
search openphone.py for "os.path.dirname(file)" (I got 6 occurrences)
This is used to get the current path but I received an empty string and then files and folders can't be found.
I changed it in : os.path.dirname(os.path.abspath(file))
(on some lines you need to delete a ")" at the end but I assume people reading this know a bit of python to solve such an error :)

My sip server is an Asterisk with PJSIP.
When calling to the USB phone I noticed 'EARLY' in the gui.
So in in openphone.py I added this to the def offhook():
Now the call gets answered when I pickup the handset.
But the ringing sound kept ringinginginginginging.
Adding a stop_sounds() to the end of the def offhook(); fixed that too.
def offhook():
lib.thread_register("python worker")
if not current_call:
dial(''.join(map(str, number_to_be_dialed)))
else:
print(current_call.info().state_text)
if(current_call.info().state_text == "CONNECTING" or "EARLY"):
answer_call() # Only do this if "CONNECTING", else crash
stop_sounds()
So there are a few minor issues but basic functionality works. I can call to and from the usb phone :)


Fix pack-repo add on Windows

Should fix #587 - tested in Windows and WSL
In order to test you need to:

clone https://github.com/Azure/draft-pack-repo

dep ensure and delete vendor/github.com/Azure/draft so it uses the one in the GOPATH (so this branch)

go build

copy the executable in $DRAFT_HOME/packs/draft-pack-repo/bin

draft pack-repo add <pack-repo-url> should successfully work (both in user and admin)

Please test this also with macOS and regular Linux.
On with #396!

@radu-matei thanks for taking care of this one!

I merged this up into draft-pack-repo via https://github.com/Azure/draft-pack-repo/commit/da3f3b7a3bb36e3581ce5b584a4a064bb0907d9d so this fix is now available.


Add CHANGELOG.md to the repo

We should a changelog file to the repo to better track the changes and updates.

GitHub can now generate Changelogs automatically when creating releases. I think we can close this.


typeahead: Show typeahead for syntax of the form @**...

If you accidentally accept the wrong typeahead when mentioning someone, a pretty natural thing to do is start deleting until you can type in the name you want.  In Zulip's typeahead right now, because we don't recognize @** as mention syntax, you have to delete all the way down to just @ in order to see typeahead again.  Fixing this would be a nice touch.
We'll want to address this for stream mentions as well, while we're at it.

@timabbott I'm trying this and I came up with this solution if this is what you want, I'll create a PR:

@shubhamdhama lgtm, don't be afraid to create a PR :)

@zulipbot claim