socket hang up

I am getting a socket hangup error several times a day that kills homebridge. I notice the hdmebridge-vera plug in dev branch is dealing with the same/similar issue right now. I'm not a js coder but is there anything I can do to help track down the issue? Thanks.
[9/20/2016, 10:46:53 PM] [Filter Pump] HTTP get power function failed: socket hang up
/usr/local/lib/node_modules/homebridge-http/index.js:45
callback(error);
^
ReferenceError: callback is not defined
at /usr/local/lib/node_modules/homebridge-http/index.js:45:19
at Request._callback (/usr/local/lib/node_modules/homebridge-http/index.js:115:4)
at self.callback (/usr/local/lib/node_modules/homebridge-http/node_modules/request/request.js:187:22)
at emitOne (events.js:96:13)
at Request.emit (events.js:188:7)
at Request.onRequestError (/usr/local/lib/node_modules/homebridge-http/node_modules/request/request.js:813:8)
at emitOne (events.js:96:13)
at ClientRequest.emit (events.js:188:7)
at Socket.socketOnEnd (_http_client.js:344:9)
at emitNone (events.js:91:20)
at Socket.emit (events.js:185:7)
at endReadableNT (_stream_readable.js:974:12)
at _combinedTickCallback (internal/process/next_tick.js:74:11)
at process._tickCallback (internal/process/next_tick.js:98:9)

i found that it seems to be prone on doing it when its in realtime  mode and it has a timeout, so you could catch the error there, i also have an NAN return sometimes, so that also needs to be cought, ive started building a persistant store for modules with an slow rolling poll in the background, so that it will update in the background, unless when the IOS connects it will force a quick poll of all devices in 60 seconds and update the display, either way it would serve from the store, eliminating the lag when loading in "yes " mode, but im new to js, so it may take a while, i have the persistant store running already thou

Happy to help test when you have something ready.

It's slow going :)
Regards
Jaco Goussard

On 22 Sep 2016, at 9:47 AM, mda30<EMAIL_ADDRESS>wrote:
Happy to help test when you have something ready.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

so ive gotten this far, used some modules from homebridge-people
and learned from that code.
I need to figure out to create a branch, then i will do better, im just hacking away really,
i am using the "yes" feature to pull the requests, but have made so that it doesn't make so many requests, and only pulls updates after 5 mins, its hardcoded at the moment, but i will get better at this as well.
basically after you refreshed once, you can let the phone time out or what ever, the next pull you do will be close on instant.
let me know what you think @mda30
var Service, Characteristic, HomebridgeAPI;
var request = require("request");
var pollingtoevent = require('polling-to-event');
var moment = require('moment');
	module.exports = function(homebridge){
		Service = homebridge.hap.Service;
		Characteristic = homebridge.hap.Characteristic;
		HomebridgeAPI = homebridge;
		homebridge.registerAccessory("homebridge-http", "Http", HttpAccessory);

	}

	function HttpAccessory(log, config) {
		this.log = log;

		// url info
		this.on_url                 = config["on_url"];
		this.on_body                = config["on_body"];
		this.off_url                = config["off_url"];
		this.off_body               = config["off_body"];
		this.status_url             = config["status_url"];
		this.brightness_url         = config["brightness_url"];
		this.brightnesslvl_url      = config["brightnesslvl_url"];
		this.http_method            = config["http_method"] 	  	 	|| "GET";;
		this.http_brightness_method = config["http_brightness_method"]  || this.http_method;
		this.username               = config["username"] 	  	 	 	|| "";
		this.password               = config["password"] 	  	 	 	|| "";
		this.sendimmediately        = config["sendimmediately"] 	 	|| "";
		this.service                = config["service"] 	  	 	 	|| "Switch";
		this.name                   = config["name"];
		this.brightnessHandling     = config["brightnessHandling"] 	 	|| "no";
		this.switchHandling 		= config["switchHandling"] 		 	|| "no";
		//jaco
		this.storage = require('node-persist');
//Init storage
  this.storage.initSync({
    dir: HomebridgeAPI.user.persistPath()
  });
		this.state = false;
		this.currentlevel = 0;
		var that = this;

		// Status Polling, if you want to add additional services that don't use switch handling you can add something like this || (this.service=="Smoke" || this.service=="Motion"))
		if (this.status_url && this.switchHandling =="realtime") {
			var powerurl = this.status_url;
			var statusemitter = pollingtoevent(function(done) {
	        	that.httpRequest(powerurl, "", "GET", that.username, that.password, that.sendimmediately, function(error, response, body) {
            		if (error) {
                		that.log('HTTP get power function failed: %s', error.message);
		                callback(error);
            		} else {
						done(null, body);
            		}
        		})
			}, {longpolling:true,interval:80000,longpollEventName:"statuspoll"});

		statusemitter.on("statuspoll", function(data) {
        	var binaryState = parseInt(data);
			that.log(binaryState);
	    	that.state = binaryState > 0;
			that.log(that.service, "received power",that.status_url, "state is currently", binaryState);

			that.storage.setItem('http_' + this.name, Date.now());
			// switch used to easily add additonal services

		//	switch (that.service) {
		//		case "Switch":
		//			if (that.switchService ) {
		//				that.switchService .getCharacteristic(Characteristic.On)
		//				.setValue(that.state);
		//			}
		//			break;
		//		case "Light":
		//			if (that.lightbulbService) {
		//				that.lightbulbService.getCharacteristic(Characteristic.On)
		//				.setValue(that.state);
		//			}
		//			break;
		//		}
		});

	}
	// Brightness Polling
	if (this.brightnesslvl_url && this.brightnessHandling =="realtime") {
		var brightnessurl = this.brightnesslvl_url;
		var levelemitter = pollingtoevent(function(done) {
	        	that.httpRequest(brightnessurl, "", "GET", that.username, that.password, that.sendimmediately, function(error, response, responseBody) {
            		if (error) {
                			that.log('HTTP get power function failed: %s', error.message);
							return;
            		} else {
						done(null, responseBody);
            		}
        		}) // set longer polling as slider takes longer to set value
    	}, {longpolling:true,interval:2000,longpollEventName:"levelpoll"});

		levelemitter.on("levelpoll", function(data) {
			that.currentlevel = parseInt(data);

			if (that.lightbulbService) {
				that.log(that.service, "received brightness",that.brightnesslvl_url, "level is currently", that.currentlevel);
				that.lightbulbService.getCharacteristic(Characteristic.Brightness)
				.setValue(that.currentlevel);
			}
    	});
	}
	}

	HttpAccessory.prototype = {

	httpRequest: function(url, body, method, username, password, sendimmediately, callback) {
		request({
			url: url,
			body: body,
			method: method,
			rejectUnauthorized: false,
			auth: {
				user: username,
				pass: password,
				sendImmediately: sendimmediately
			}
		},
		function(error, response, body) {
			callback(error, response, body)
		})
	},

	setPowerState: function(powerOn, callback) {
		var url;
		var body;

		if (!this.on_url || !this.off_url) {
				this.log.warn("Ignoring request; No power url defined.");
				callback(new Error("No power url defined."));
				return;
		}

		if (powerOn) {
			url = this.on_url;
			body = this.on_body;
			this.log("Setting power state to on");
			// update status
		this.storage.setItem('http_' + this.name,1);
		this.storage.setItem('http_lastrefresh'+this.name, Date.now());

		} else {
			url = this.off_url;
			body = this.off_body;
			this.log("Setting power state to off");
			// update status
		this.storage.setItem('http_' + this.name,0);
		this.storage.setItem('http_lastrefresh'+this.name, Date.now());

		}

		this.httpRequest(url, body, this.http_method, this.username, this.password, this.sendimmediately, function(error, response, responseBody) {
			if (error) {
			this.log('HTTP set power function failed: %s', error.message);
			callback(error);
			} else {
			this.log('HTTP set power function succeeded!');

			callback();
			}
		}.bind(this));
	},

getPowerState: function(callback) {

var lastSeenUnix = this.storage.getItem('http_lastrefresh'+this.name);
var lastSeenMoment = moment(lastSeenUnix);
//var activeThreshold = moment().subtract(this.threshold, 'm');
var activeThreshold = moment().subtract(5, 'm');
var isActive = lastSeenMoment.isAfter(activeThreshold);
if (isActive)

 {binaryState = parseInt(this.storage.getItem('http_' + this.name));

		this.log("Recently refreshed %s", binaryState)
		powerOn = binaryState > 0;
		callback(null, powerOn);}

else
{
	this.log("lets scan");
  if (!this.status_url) {
		this.log.warn("Ignoring request; No status url defined.");
		callback(new Error("No status url defined."));
		return;
	}

	var url = this.status_url;
	this.log("Getting power state");

	this.httpRequest(url, "", "GET", this.username, this.password, this.sendimmediately, function(error, response, responseBody) {
	if (error) {
		this.log('HTTP get power function failed: %s', error.message);
		callback(error);
	} else {
		var binaryState = parseInt(responseBody);
		var powerOn = binaryState > 0;
		this.log("Power state is currently %s", binaryState);

		if (isNaN(parseInt(responseBody))) {this.log("Exception Power state is currently %s", binaryState);
		binaryState = parseInt(this.storage.getItem('http_' + this.name));

		this.log("Old Power state is currently %s", binaryState)
		powerOn = binaryState > 0;
		callback(null, powerOn);

	} else {

		this.storage.setItem('http_' + this.name, parseInt(responseBody));
		this.storage.setItem('http_lastrefresh'+this.name, Date.now());
		callback(null, powerOn);
		}

	}
	}.bind(this));
  }

  },

	getBrightness: function(callback) {
		if (!this.brightnesslvl_url) {
			this.log.warn("Ignoring request; No brightness level url defined.");
			callback(new Error("No brightness level url defined."));
			return;
		}
			var url = this.brightnesslvl_url;
			this.log("Getting Brightness level");

			this.httpRequest(url, "", "GET", this.username, this.password, this.sendimmediately, function(error, response, responseBody) {
			if (error) {
				this.log('HTTP get brightness function failed: %s', error.message);
				callback(error);
			} else {
				var binaryState = parseInt(responseBody);
				var level = binaryState;
				this.log("brightness state is currently %s", binaryState);
				callback(null, level);
			}
			}.bind(this));
	  },

	setBrightness: function(level, callback) {

		if (!this.brightness_url) {
			this.log.warn("Ignoring request; No brightness url defined.");
			callback(new Error("No brightness url defined."));
			return;
		}

		var url = this.brightness_url.replace("%b", level)

		this.log("Setting brightness to %s", level);

		this.httpRequest(url, "", this.http_brightness_method, this.username, this.password, this.sendimmediately, function(error, response, body) {
		if (error) {
			this.log('HTTP brightness function failed: %s', error);
			callback(error);
		} else {
			this.log('HTTP brightness function succeeded!');
			callback();
		}
		}.bind(this));
	},

	identify: function(callback) {
		this.log("Identify requested!");
		callback(); // success
	},

	getServices: function() {

		var that = this;

		// you can OPTIONALLY create an information service if you wish to override
		// the default values for things like serial number, model, etc.
		var informationService = new Service.AccessoryInformation();

		informationService
		.setCharacteristic(Characteristic.Manufacturer, "HTTP Manufacturer")
		.setCharacteristic(Characteristic.Model, "HTTP Model")
		.setCharacteristic(Characteristic.SerialNumber, "HTTP Serial Number");

		switch (this.service) {
		case "Switch":
			this.switchService = new Service.Switch(this.name);
			switch (this.switchHandling) {
				//Power Polling
				case "cached":
					this.switchService
					.getCharacteristic(Characteristic.On)
					.on('set', this.setPowerState.bind(this));
					break;
				case "yes":
					this.switchService
					.getCharacteristic(Characteristic.On)
					.on('get', this.getPowerState.bind(this))
					.on('set', this.setPowerState.bind(this));
					break;
				case "realtime":
					this.switchService
					.getCharacteristic(Characteristic.On)
					.on('get', function(callback) {callback(null, that.state)})
					.on('set', this.setPowerState.bind(this));
					break;
				default	:
					this.switchService
					.getCharacteristic(Characteristic.On)
					.on('set', this.setPowerState.bind(this));
					break;}
					return [this.switchService];
		case "Light":
			this.lightbulbService = new Service.Lightbulb(this.name);
			switch (this.switchHandling) {
			//Power Polling
			case "cache" :
				this.lightbulbService
				.getCharacteristic(Characteristic.On)
				.on('get', this.getPowerState.bind(this))
				.on('set', this.setPowerState.bind(this));
				break;
			case "yes" :
				this.lightbulbService
				.getCharacteristic(Characteristic.On)
				.on('get', this.getPowerState.bind(this))
				.on('set', this.setPowerState.bind(this));
				break;
			case "realtime":
				this.lightbulbService
				.getCharacteristic(Characteristic.On)
				.on('get', function(callback) {callback(null, that.state)})
				.on('set', this.setPowerState.bind(this));
				break;
			default:
				this.lightbulbService
				.getCharacteristic(Characteristic.On)
				.on('set', this.setPowerState.bind(this));
				break;
			}
			// Brightness Polling
			if (this.brightnessHandling == "realtime") {
				this.lightbulbService
				.addCharacteristic(new Characteristic.Brightness())
				.on('get', function(callback) {callback(null, that.currentlevel)})
				.on('set', this.setBrightness.bind(this));
			} else if (this.brightnessHandling == "yes") {
				this.lightbulbService
				.addCharacteristic(new Characteristic.Brightness())
				.on('get', this.getBrightness.bind(this))
				.on('set', this.setBrightness.bind(this));
			}

			return [informationService, this.lightbulbService];
			break;
		}
	}
};

~~~~~~~~~~~~~~~~~~~~~

Just fork this repo, once you get it all working do a pull request I will look into it and see if it can be merged

ok, ive done so, still have some stuff to neaten and apply, but it's currently working for me the update is there
https://github.com/cybertza/homebridge-http

@cybertza i am testing your fork now. Should i expect status to be up to date if I use "yes" and the device state is changed manually, or do I need realtime for that (in which case I will need to wait until you port the caching into 'realtime' to test most of my devices). Thanks.

As per the readme, It will read the status on request unless itbeen less
than 5 mins, then it will read from the buffer, its not the most
effective honestly, it will most likely be best on 30 seconds or
something, i am busy writing cahced as the moment, but had some reading
to do before, so i need to still read some,
I basically want to always read from buffer, and then after the buffer
has been served action a poll of all the devices, and update the
devices, then in combination have a service in the back ground that
always polls the devices so that the buffer is mostly up to date.
Still thinking about the best way to do it.
For my use the current Yes works well, i really don't have that much
changes in my lights that the "yes" doesn’t work on a 5 min buffer,
either way, i have updated my real time code already and no longer crash
on it, but it was 2 am so i'm not sure how elegant the fix is, just know
it doesn’t crash anymore, that’s why i had to read more, as that’s where
i needed to understand the way to address the device status better and
so forth.
I will put my latest code onto this release tonight or tomorrow.
Regards
Jaco Goussard
Technical Director
Northgate Office Park
Block 8 Unit 96
Cnr Aureole and Profit Rd
Northriding
www.sypher.co.za
TEL:
(011) 462 4354
FAX:
(011) 462 5514
MOBILE:
+27 84 699 6000
E-MAIL:
<EMAIL_ADDRESS>------ Original Message ------
From: "mda30"<EMAIL_ADDRESS>To: "rudders/homebridge-http"<EMAIL_ADDRESS>Cc: "cybertza"<EMAIL_ADDRESS>"Mention"
<EMAIL_ADDRESS>Sent: 2016/09/25 01:06:41 AM
Subject: Re: [rudders/homebridge-http] socket hang up (#42)

@cybertza i am testing your fork now. Should i expect status to be up
to date if I use "yes" and the device state is changed manually, or do
I need realtime for that (in which case I will need to wait until you
port the caching into 'realtime' to test most of my devices). Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Hello, I’m very new to homeBridge and this forum. I hope it’s ok to post a question here.
After many many hours I finally almost finished installing Homebridge on my windows 10  pc.
After running command ‘node homebridge’ i Get this error
HTTP get power function failed: connect ECONNREFUSED <IP_ADDRESS>:80
ReferenceError: callback is not defined at
C:\Users\wendy\AppData\Roaming\npm\node-modules\homebridge-http\index.js:115:4>
Can anybody tell me what I should do? I’m verry new to all of this.
Thanks in advance all!

That error would appear to be an issue with the device you are trying to talk to:
HTTP get power function failed: connect ECONNREFUSED <IP_ADDRESS>:80
It would seem that you are trying to ask <IP_ADDRESS> for a power status.
Its hard to guess without your config, but i would start looking there.

Thanks for the reply,
How can I post my config so you can see it?

https://github.com/cybertza/homebridge-http/blob/master/sample-config.json
line 18 seems to be your problem from the sample config.
All depending on the device you are trying to manage, and what the status replies.

I have t even made it that far yet, lol I’m just trying to get it to run on my PC.
I’m so lost here on coding and terms.....
But I hope if I’m persistent I’ll eventually figure it out.
I really would love to get all my devices running on homekit!


BasicCrawler: Omit stack trace from error log "..request reclaiming back to queue.."

In most cases, the user doesn't care about stack trace for this log message because the request will be added to the queue again.
It can mess up the log with lost of stack traces. For example, we need to kill the whole browser in the case where the session or proxy expired. It will generate lots of errors. But there are many other cases, where it can be useful.
Quick fix: Just get rid of the stack trace and print maybe warning or error without stack trace.
Long term fix: Options to override this log function with user function.

Good point, for these expected errors, it doesn't make sense to show strack trace. We can define some Error class for them.

Closing in favor of #759 since the releated PR https://github.com/apify/apify-js/pull/486 is also closed.

Closing in favor of #759 since the releated PR https://github.com/apify/apify-js/pull/486 is also closed.


Improve modification detection by adding content comparison

This PR revises the way the BuildSystem detects file modification for rebuild.
Prior to this, the definition of a modified files was through fstat properties: device, inode, mode, size and mtime.
This approach is very robust, but has false positives in several common cases:

git operations - when you move between branches, sometimes you end up with exactly the same file tree content, but git will have touched the files several times.
Scripts generating code - the contents would be the same, but the file might be completely different by mtime, inode etc.
Accidental edits to files - you type in the wrong window and fix it a moment later, but the file was modified.
Compiler generated files - you rebuild some module, causing the ObjC interface header to be rebuilt, which cascades the other parts of the project regardless of whether the file is actually different.

The current PR changes the way file modification is defined:

device, inode, mode are no longer used.
The file is compared by size and then by mtime.
If and only if the mtime comparison fails, the MD5 hash of the file's contents is compared to the previous value.

This follows a forum discussion.
Issues raised in the discussion but not addressed by the PR:

MD5 performance - while this is a reasonable concern, the calculation will be performed lazily and not affect build system performance. I couldn't find a better hashing function in the confines of the project, and one can be swapped in later.
Non-content attribute cases.

Thanks for the PR, sorry for the delay in review!
A couple high level comments:

We should probably model this a bit differently. Rather than have a LazyMD5 abstraction, we should leverage the power of the build engine so that what we actually do is alter the build graph so that when a task depends on file X, it’s graph is rewritten to depend on a node “hash(X)” which depends on X. Then the build engine will handle only bringing the hash up to date when the inode is modified (and there shouldn’t be any changes to existing FileInfo struct.

We will want clients to be able to selectively choose whether or not to use this behavior. To start with, I’d suggest we maybe make it so that tasks can opt in or out of this behavior at the BuildSystem manifest level (maybe with a way to toggle the global default, in order to keep configs small).

WDYT?

As far as the hash algorithm goes, for similar use cases we’ve lately been using BLAKE2 for this kind of use case, and I think it’s a very reasonable place to start. We can however start with MD5 and just anticipate that it is pluggable and we will swap it out...
https://blake2.net/acns/slides.html
https://en.wikipedia.org/wiki/BLAKE_(hash_function)#BLAKE2P

@ddunbar thanks for the comments!
For the first part, I do think this is a great suggestion, I wish I'd have thought of it myself! I'd like some more guidance on how to do this - do I create a new rule? Task?
For the second part - I'm not even sure how to approach this. What should I do about it? Do you think it's necessary for this PR to include it?

@igor-makarov
For the first part, take a look at DirectoryTreeSignatureTask in BuildSystem.
For the second part, we would probably do it by adding attributes to the BuildSystem manifest, one attribute for the tool, to switch the default, and one attribute for the task, to override the tool default. Search for can-safely-interrupt for an example of a ShellTask attribute (although it doesn't have an example of the global default.
Unfortunately, yes, the second part is definitely required because this is a potential behavior changing thing that clients (like SwiftPM or Xcode Build System) would need to incrementally adopt. In SwiftPM, we can probably move somewhat quickly to adopt it and prove it out, but other clients might not have that freedom. From that sense, the second part is honestly the most important (safety of changes).
I love that you are working on this, by the way, its been something we have wanted for ages!

We're interested in behavior "like this patch" in the xcode buildsystem, in order to do incremental builds in a CI like GitHub Actions.
Relying on the inode for incremental builds implies that a DerivedData copied from "somewhere else" (even the same machine) will do a full rebuild.  As a result, we can't cache actions with actions/cache even with quite sophisticated attr-preserving methods.
FB8440337

You might try -IgnoreFileSystemDeviceInodeChanges=YES in your xcodebuild arguments.   That should propagate through to llbuild and do what it says, ignore the device and inode fields of stat info when performing checks.

The Swift project moved the default branch to main and deleted master branch, so GitHub automatically closed the PR. Please re-create pull request with main branch.
More detail about the branch update - https://forums.swift.org/t/updating-branch-names/40412


Exception while running an example

Hi!
I've a problem:
I'm truing to run an example that are described on instructions page, but after running that command
python3 src/main.py --config=qmix_smac --env-config=sc2 with env_args.map_name=2s3z
The following error is appeared:
Traceback (most recent call last):   File "src/main.py", line 19, in <module>     ex = Experiment("pymarl")   File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/sacred/experiment.py", line 75, in __init__     _caller_globals=caller_globals)   File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/sacred/ingredient.py", line 57, in __init__     gather_sources_and_dependencies(_caller_globals)   File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/sacred/dependencies.py", line 487, in gather_sources_and_dependencies     sources = gather_sources(globs, experiment_path)   File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/sacred/dependencies.py", line 440, in get_sources_from_imported_modules     return get_sources_from_modules(iterate_imported_modules(globs), base_path)   File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/sacred/dependencies.py", line 409, in get_sources_from_modules     filename = os.path.abspath(mod.__file__)   File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/posixpath.py", line 378, in abspath     path = os.fspath(path) **TypeError: expected str, bytes or os.PathLike object, not NoneType**
I was trying to resolve the issue with the different versions of sacred module, but no it is still failed...
All the modules versions are taken from requirements.txt file
Could you please help?
Thank you a lot!

That does indeed look like a sacred error.
Have you tried using the version of sacred from the dockerfile (forked ~2 years ago https://github.com/oxwhirl/sacred)?
Just to make sure nothing weird is going on with previous versions, could you also try deleting the results directory (where sacred is supposed to be storing files) and trying it.

I meet with this problem too. have you solved it?

I meet with the same problem too. Have you soled it?

I solved this by downgrading python to 3.6.8 according to https://github.com/oxwhirl/pymarl/issues/102#issuecomment-818460788.


[Feature] URL Parameters

This is a feature request
What
Allow to have URL parameters like some/:id which would be added in a new section called parameters besides query and headers, this could be automatically picked up by using a regex like (?:\/)(\:.*)(?:\/?).
This would allow us to keep the URLs more configurable

I was just looking for the same thing 👍


ui: Allow editing host and storage tags in updateHost & updatStoragePool forms

Description
This PR fixes an issue seen when trying to add / update tags on hosts or storage pools using the update Host / update storage pool forms respectively.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[X] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6375 (SL-JID-1548)


Build and cache llvm

This PR splits up build only in CI into two steps

Build LLVM
Build iree

Why do this if it only affects CI? Because now we can also cache/save/upload the LLVM distro for each successful build thereby giving everyone (not just CI) a distro of LLVM they can use to build iree locally. This cuts down the number of files you have to compile by like 60% (from 7500 -> 2900).
In case you didn't know, the CI artifacts are at the bottom of the summary page for any given run:

EDIT: in fact we actually need this for HSA (because ROCR requires an up-to-date Clang)^1.
EDIT2: This PR now also adds powershell scripts for building on windows

The extra build feels rather complicated to me, and it would be nice if iree-amd-aie didn't need to build LLVM itself in this way

yea i mean this is what we discussed on slack earlier this week - i would love to be able to either

build iree distro
build iree-amd-aie using iree distro
load 2 -> 3 (somehow/some plugin mechanism)

or

build iree distro
build iree-amd-aie-opt, iree-amd-aie-run-module using iree distro

both paths would save us a lot of CI and dev. but it's spot time right (full rebuild once every ~2 weeks when we bump iree if you're not sloppy and the bump is major) and amortized it's not a lot of time so for now shaving 60% instead of 90% is good enough. revisit later 🤷


Solve width problem

Fix max width, this wrapping text.

fix min width and fix math width between 200 and 500px
allow wrap text

now it's not wrapping

Hi, any updates/progress on this issue?

I've started to see this issue after upgrading from 1.1.1 to 1.1.2

@mlidija  @alessandrofrancesconi  nope, 1.1.2 just fix enums.
Now i have no ideas how to fix this problem. And need help

@mlidija @alessandrofrancesconi nope, 1.1.2 just fix enums.
Now i have no ideas how to fix this problem. And need help

I don't think it's "just fix enums", look:
1.1.1:

right after 1.1.2:

@alessandrofrancesconi looks like big trouble, i'll rollback 1.1.2 and try to fix on weekend.

If can help, I'm using the Fluent Theme on my Avalonia app.
<Application.Styles>
    <FluentTheme Mode="Dark" />
</Application.Styles>

When i deal with Auto sizes i often have to hack the window to make it work with dynamic stuff, eg:
https://github.com/sn4k3/UVtools/blob/6cfedea4cc36200caab87301e0dd121e97ddc8f2/UVtools.WPF/Windows/ToolWindow.axaml.cs#L600
Ugly but will work in every os

@sn4k3 ty
not sure that helps but try

In my case is to make scrollviewer work otherwise it will overflow and the viewport have the wrong size to acommodate all teh content. But i have cases where i also have to use this, on TabControls for example.


Collaboration - Cordova Network Manager

Hi @tripflex,
I'm glad to see you credited my plugin so thank you for that.
I am wanting to expand onto my plugin and we should talk about possibly merging/becoming the sole contributors for both.
My discord is: Nomm#0176

Watch this space. ;)


single access token

Can someone provide an example on how to implement single access token with after_token_authentication callback and reset_authentication_token?

Have you already tried something like http://stackoverflow.com/questions/6467813/devise-reset-token-after-signing-out?


Feature-dependent documentation

On nightly rust enable feature(doc_cfg) and always show feature-dependent interfaces in docs.

Fixed with https://github.com/orlp/slotmap/commit/0ac2da6864f6252125f7d77afcdbc3f040112cb0.

Fixed with https://github.com/orlp/slotmap/commit/0ac2da6864f6252125f7d77afcdbc3f040112cb0.


Remove redundant log messages

GithubAppInstallationHandler.run() calls whitelist.add_account() and both log almost the same messages.
Remove those in add_account().

PTAL

recheck

Hey @jpopelka, please squash the two commits to have a nicer history.

Sure, done.
@TomasTomecek looks like I'm not the biggest nitpicker in our team anymore :-)  ^^^

recheck

Ok, given that the tests had been green before I only squashed the commits, I assume it's ok to merge this even Zuul is broken at the moment.

so, nitpicking competition?


HinMine notebook

The imdb gpickle file needs a bit of explanation what's inside it, possibly also a printout of few samples. A word or two about the top heuristic ig would also be welcome.

Alright, I'll add that by 6.12, during the final read-through probably.
On Thu, 26 Nov 2020, 17:47 Vid Podpečan<EMAIL_ADDRESS>wrote:

The imdb gpickle file needs a bit of explanation what's inside it,
possibly also a printout of few samples. A word or two about the top
heuristic ig would also be welcome.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/vpodpecan/representation_learning/issues/13, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ACMSERDAQWPJME4W7UVKC6DSR2BD7ANCNFSM4UD6S4OQ
.

This was added so I'm closing this issue.


pythonPackages.discordpy: remove overly restrictive version constraints

Motivation for this change
Noticed this failing on Hydra, and fixed it.
I've simply removed any versioning constraints, as we're (AFAIK) choosing these arbitrarily anyway.
This should be backported as well.
Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

FYI: Upstream allows now < aiohttp-3.8.0. Unfortunately this change was not released yet.

Result of nixpkgs-review pr 106869 run on x86_64-linux 1

3 packages built:

python37Packages.discordpy
python38Packages.discordpy
python39Packages.discordpy


s390x: fstat does not return the correct device id

#include <sys/stat.h>
#include <fcntl.h>

int main() {
int fd = open("/home/a.out", O_RDONLY);
struct stat stat_buf;
fstat(fd, &stat_buf);

return 0;
}

1- Compile and run the above in gdb, make sure /home/a.out is the correct path of the compiled binary.
2- Check the value of stat_buf.st_dev after the fstat call, mine prints as 0x2c.
3- Now in another window check the memory mappings provided by the OS for this process (process id being 39 for me):
# cat /proc/39/maps
2aa00000000-2aa00001000 r-xp 00000000 fd:03 1994274                      /home/a.out

4- The (correctly displayed) device id fd:03 is not the same as 0x2c which is incorrect.
Tested on Docker version 20.10.12, build e91ed57, s390x host running RHEL 8.5.
This does not happen in a x64 docker env. It also works fine outside of docker on the s390x host.

This is the wrong repo to report this issue on. Out of curiosity what made you think this is the right repo?
Please open an issue in moby/moby.

The link under this page GitHub project bugtracker:
https://docs.docker.com/registry/help/
I guess it wasn't clear that it only applies to the registry.

That's the correct link for REGISTRY project -- it's in the registry section if you look on the left.
Distribution = [formerly known as] Docker Registry


Upgrade v8 to 7.4.288.25

Related to #1356

Test

test

test

test --performance

test --performance

test --performance


Extension - Add popup want to user claim reward when Astar update dApp staking v3

Is your feature request related to a problem? Please describe.
Add popup want to user claim reward when Astar update dApp staking v3

Case 1: Show when open app

Condition to show: User have dApp staking

Case 2: User click on dApp staking details with dApp staking (ASTR, SBY, SDN)

Content:

Header: Claim ASTR staking rewards

Message: Astar dApp staking V3 is launching in early February. Make sure to claim any ASTR rewards before the launch or they will be lost.

Add hyperlink to "Astar dApp staking V3"
Hyperlink: https://docs.astar.network/docs/learn/dapp-staking/dapp-staking-faq/#q-what-about-unclaimed-rewards

Button: Dismiss / Claim now

Dismiss: Close popup
Claim now: Redirect user to Astar Portal (https://portal.astar.network/)

Refer design: https://www.figma.com/file/2nYhrm0rlJtfJoMwrT51Ep/SubWallet-Apps?type=design&node-id=16743-144961&mode=design&t=FefFPGnsCxNeJ4Xq-4

Version test : http://<IP_ADDRESS>:8900/s/bdqoJkWHfY364YX
Validation passed in case :

Update version

Open app

User click on dApp staking details

[ ] UI bug

[ ] When start earning with dApp staking (ASTR, SBY, SDN), don't show popup

Version test : http://<IP_ADDRESS>:8900/s/xeekc7WP5JHZwiJ
Validation passed in case :

UI
Update version
Open new app
User click on dApp staking details
Check case when user click on non-dApp staking details
Banner Earn now must be displayed the next time you open the app
Check case update version while displaying the banner


Actuator Health Groups

Health groups feature should be added.  Similar functionality here:  https://docs.spring.io/spring-boot/docs/current/reference/html/production-ready-features.html#production-ready-health-groups

Completed in 3.0.0-m3 - #3, #316, and #317.


Error upgrading 1.6 to 1.7 when the store is in non-english

Describe the bug
My store is in Spanish (Argentina); when I try to upgrade my store to 1.7, I get the error:

[INTERNAL] /var/www/html/src/PrestaShopBundle/Install/LanguageList.php line 98 - Class 'PrestashopInstallerException' not found

Upgrade environment (please complete the following information):
Version you started from: <IP_ADDRESS>
Version you upgrade to: <IP_ADDRESS> (major channel)
Way of upgrade: Web
Step concerned: upgrade DB
Displayed log
[OK] SQL <IP_ADDRESS> DELETE FROM `psks_hook` WHERE `name` IN ( 'displayProductTab', 'displayProductTabContent', 'displayBeforePayment', 'actionBeforeAuthentication', 'actionOrderDetail', 'actionProductListOverride', 'actionSearch', 'displayCustomerIdentityForm', 'displayHomeTab', 'displayHomeTabContent', 'displayPayment')
[OK] SQL <IP_ADDRESS> DELETE FROM `psks_hook_alias` WHERE `name` IN ( 'beforeAuthentication', 'displayProductTab', 'displayProductTabContent', 'displayBeforePayment', 'orderDetail', 'payment', 'productListAssign', 'search')
[OK] SQL <IP_ADDRESS> DELETE FROM `psks_configuration` WHERE `name` IN ( '_MEDIA_SERVER_2_', '_MEDIA_SERVER_3_', 'PS_ORDER_PROCESS_TYPE', 'PS_ADVANCED_PAYMENT_API', 'PS_ONE_PHONE_AT_LEAST', 'PS_SCENE_FEATURE_ACTIVE', 'PS_ADMINREFRESH_NOTIFICATION', 'PS_CUSTOMER_NWSL', 'PS_CACHEFS_DIRECTORY_DEPTH', 'PS_CART_REDIRECT', 'PS_COMPARATOR_MAX_ITEM', 'PS_STORES_DISPLAY_FOOTER', 'PS_STORES_SIMPLIFIED', 'PS_STORES_CENTER_LAT', 'PS_STORES_CENTER_LONG', 'PS_STORES_DISPLAY_SITEMAP', 'PS_CIPHER_ALGORITHM', 'PS_HTML_THEME_COMPRESSION', 'PS_JS_HTML_THEME_COMPRESSION', 'PS_LOGO_MOBILE', 'SHOP_LOGO_MOBILE_HEIGHT', 'SHOP_LOGO_MOBILE_WIDTH')
[OK] SQL <IP_ADDRESS> ALTER TABLE `psks_tab` ADD `icon` varchar(32) DEFAULT ''

Errores
[INTERNAL] /var/www/html/src/PrestaShopBundle/Install/LanguageList.php line 98 - Class 'PrestashopInstallerException' not found

Expected behavior
Fully upgrade to the 1.7 version without errors and with Spanish (Argentina) as main language
Server (please complete the following information):
Web Server: apache2
PHP Version: 7.1
Module Version 4.1.1
Additional context
This bug is easy to reproduce using docker and the following steps:

Raise a clean version of <IP_ADDRESS> version using https://hub.docker.com/r/prestashop/prestashop/
Complete the clean install
After the install, go to localizations and download all the Argentinian package
Set Spanish (Argentina) as main language
Go to modules and install version 4.1.1 of the 1 click upgrade
Open 1 click upgrade, disable all backups and set to upgrade default theme, set to set the default theme, disable no-native modules hit save
Put the site under mantainance
Hit upgrade to upgrade to 1.7
---- after a few minutes you should see the error

Hi @Guisardo,
I manage to reproduce the issue using the 1-click upgrade v4.1.1.
Upgrade from <IP_ADDRESS>=> <IP_ADDRESS>.

@Quetzacoalt91 what do you think about this issue?
Best regards, Khouloud

I haven't looked at the issue yet, but I already wanted to say that I love this kind of feedback, especially when our Docker image is used to reproduce it easily. :heart:
Thank you @Guisardo

Hi,
A pull request has just been opened (#163). The error was caused by unregistered classes.
However, I expected to get an exception during the process, but it actually completed.
I'll make another try, but it seems the changes made more fixes than I would think.

I confirm 2 issues have been actually fixed.
I modified the content of the concerned method. I wanted to check if the langage was found or not:
    /**
     * Set current language.
     *
     * @param string $iso Language iso
     */
    public function setLanguage($iso)
    {
        if (!in_array($iso, $this->getIsoList())) {
            trigger_error('Language ' . $iso . ' not found', E_USER_WARNING);
            throw new PrestashopInstallerException('Language ' . $iso . ' not found');
        }
        trigger_error('Language ' . $iso . ' found', E_USER_WARNING);
        $this->language = $iso;
    }

Running the upgrade brought me the following warning:
[2018-09-07 11:38:18] [INTERNAL] /var/www/html/src/PrestaShopBundle/Install/LanguageList.php line 101 - Language es found

With the next version of the module, you should be able to complete your upgrade @Guisardo

@Quetzacoalt91 thanks for the help!!!! Can you set a date to the milestone? at least a broad one. It will be nice to know if I have to wait a year, a month o a few weeks :)
Best

I created a beta version of the module with this fix. It can be downloaded here: https://github.com/PrestaShop/autoupgrade/releases
Feel free to try it, or wait for a stable version later. :)
As the issue is now fixed, I closing your issue.
Regards


chore: api-backend to 0.0.17

chore: Promote api-backend to version 0.0.17

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Default date is 01/01/1970 when editing a cell which was original empty

I have a table with a "Termination Date" column.  So it is mostly empty.  Users sometimes edit it to put a termination date on it.  But when user double-click it and chooses the calendar dropdown.  The calendar is default to 01/01/1970.  It took too long for user for find current year or the year after current year.  How can I let it default of today's date?

@jbp17
editor: {
    type: Type.DATE,
    defaultValue: Date.now()
}

I will spend some time to enhance the document, sorry for inconvinece.

Hello Allen, I have a similar problem and defaultValue only solves it partially: my problem now is that defaultValue will show even when I have to edit an existing value.
F.e. if I have no value then it is ok to default to defaultValue, but if there is a value on that cell (like '05/21/2019') then I would prefer to see that value in the editor.
Thanks


[Enhancement] Upgrade pinpoint-profiler to 3.x.x

Search before asking

[X] I had searched in the issues and found no similar issues.

Enhancement Request
Dependabot failed to upgrade com.navercorp.pinpoint:pinpoint-profiler from 2.4.1 to 2.5.4 in https://github.com/apache/eventmesh/pull/4961. The build failed because there are references to DefaultTraceRoot which has been removed.
Describe the solution you'd like
Update deprecated usages. Upgrade to v3 if possible.
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct *

Hi @Pil0tXia , could I take a look at this issue?


Add type of button to scrollToEndButton

Fix #1741
Not having type="button" defaults the type to submit, which is causing a page refresh when scrollToEndButton is clicked.

Coverage decreased (-0.9%) to 55.152% when pulling 322910a78410fee0a551fd5453081ab8d3aa6569 on corinagum:corinagum/1741 into 25b2c47bd6d6b1bb1f469fb33c0de7a7ac9a8ea7 on Microsoft:master.


Check if round tripping an operation's value is required

From @kichalla on Tuesday, February 28, 2017 10:54:51 AM
We currently round trip the 'value' provided in an 'operation' here:
https://github.com/aspnet/JsonPatch/blob/dev/src/Microsoft.AspNetCore.JsonPatch/Internal/ConversionResultProvider.cs#L15
Valid types in JSON:
number,
string,
bool,
array,
object,
null
Some things we need to verify in the above line of code:

If the 'value' is of the same type as the 'typeToConvertTo', then we can avoid round tripping. This is being handled in the PR https://github.com/aspnet/JsonPatch/pull/63
If the value is of type JArray or JObject, then we could use the ToObject on them: http://www.newtonsoft.com/json/help/html/M_Newtonsoft_Json_Linq_JToken_ToObject.htm

Some scenarios to consider if we plan to avoid round tripping:
value type: string
target type: System.Guid
value type: Int64 (default json.net type for integers)
target type: Int32
@Eilon
Copied from original issue: aspnet/JsonPatch#69

From @kichalla on Tuesday, February 28, 2017 3:03:20 PM
A working change (in my private branch): https://github.com/aspnet/JsonPatch/commit/7f7ff71bc00f3fece41ce77e95d2937954baf63b

Thanks @kichalla, but it's time to close this as there was no community involvement in this issue for quite a while.


Add rhomb and parallelogram symbols

Description
Currently, Typst is missing the rhomb and parallelogram/rhomboid symbols.
Use Case
These symbols could be used to describe the formula for the shape's field. For example:
$Field_square.stroked = a^2$

Are these Unicode symbols? That would be a prerequisite

There is a parallelogram and rhombus, but I am not familiar with any fields of math that use them so cannot vouch for their size or orientation being correct.
▱ U+25B1 WHITE PARALLELOGRAM
◊ U+25CA LOZENGE

There is a parallelogram and rhombus, but I am not familiar with any fields of math that use them so cannot vouch for their size or orientation being correct.
▱ U+25B1 WHITE PARALLELOGRAM
◊ U+25CA LOZENGE

I think these are correct.


Version v0.19.0 bump in prepartion for release

This PR just bumps to the next minor version in preparation for the release.
It was a minor version bump since it added a new field to an existing structure.

Thanks!


Aurora support

This pulls in #148 with some of #104.
@JustinVenus, @benley does this work for both of you?
... we really need some specs for this class

Crap, I totally forgot about updating my branch!  Anyway yes, this looks like it will work.  Just see the one comment about naming.

lgtm #shipit

@benley, @JustinVenus
I've merged the branch (only change from initial PR was that we call it the serverset method instead of the aurora method and port_name became endpoint_name). When you guys get a chance to give it a try in your setups please let me know if this works for you two.
Some basic manual testing on my end seems to indicate it's ok, but we don't run it in production so I don't really want to claim that.


LoadBalancerAutoConfiguration does not add LoadBalancerInterceptor via org.springframework.cloud.client.loadbalancer.RestTemplateCustomizer when another org.springframework.cloud.client.loadbalancer.RestTemplateCustomizer bean exists

Due to usage of @ConditionalOnMissingBean in LoadBalancerAutoConfiguration, bean
@Bean
@ConditionalOnMissingBean
public RestTemplateCustomizer restTemplateCustomizer(final LoadBalancerInterceptor loadBalancerInterceptor) {
	return restTemplate -> {
		List<ClientHttpRequestInterceptor> list = new ArrayList<>(restTemplate.getInterceptors());
		list.add(loadBalancerInterceptor);
		restTemplate.setInterceptors(list);
	};
}

will not get published if another @Bean implementing org.springframework.cloud.client.loadbalancer.RestTemplateCustomizer exists, resulting in RestTemplate that is annotated with @LoadBalanced not having the LoadBalancerInterceptor interceptor registered. This is a consequence when using @ConditionalOnMissingBean
According to the code above,
@Bean
public SmartInitializingSingleton loadBalancedRestTemplateInitializerDeprecated(
		final ObjectProvider<List<RestTemplateCustomizer>> restTemplateCustomizers) {
	return () -> restTemplateCustomizers.ifAvailable(customizers -> {
		for (RestTemplate restTemplate : LoadBalancerAutoConfiguration.this.restTemplates) {
			for (RestTemplateCustomizer customizer : customizers) {
				customizer.customize(restTemplate);
			}
		}
	});
}

more than one Bean implementing org.springframework.cloud.client.loadbalancer.RestTemplateCustomizer can be present.

Hello @ZIRAKrezovic this interface is provided by the loadbalancer package, added there specifically for the purpose of setting up load-balancing; we do not really expect the users to create one unless they want to override the behaviour of the one we create. Other than that, I'm not sure why it would be used by the users, since the users create and can customise the RestTemplate bean itself. Could you provide more information on what your use-case is here?

Hi @OlgaMaciaszek. It seems that I found out why I ran into the problem in the first place.
In short, my use case is "Add some default headers to all RestTemplates produced by AutoConfiguration". BUT: I have implemented the wrong customizer
There are two classes that provide exactly the same behavior
org.springframework.boot.web.client.RestTemplateCustomizer
org.springframework.cloud.client.loadbalancer.RestTemplateCustomizer
I was most likely going for the former one while following Spring Web doc, but due to spring cloud being in the class path, the IDE chose the latter one. And it has worked until the changes made in spring-cloud-commons 4.1.1.
Now, it is misleading that the LoadBalancerAutoConfiguration works with a list of initializers of second type mentioned above when the default implementation backs off. I thought this was a regression.
In any case, I will migrate my code to the Spring Web interface, rather than Spring Cloud Commons one, but you may want to mention this somewhere in the changelog, at least.

Not sure what you mean. We still don't use org.springframework.boot.web.client.RestTemplateCustomizer there and we have used org.springframework.cloud.client.loadbalancer.RestTemplateCustomizer forever in that class. The only thing that's changed in 4.1.1 is a different customiser introduced that works on RestClient and not RestTemplate. For some reason changelog for that release was not generated properly on GH, so I will add it now.

I meant that I intended to use
org.springframework.boot.web.client.RestTemplateCustomizer
but ended up using
org.springframework.cloud.client.loadbalancer.RestTemplateCustomizer
in my code. Still, the problem remains that usage of the latter did not break LoadBalancerInterceptor before.

That @ConditionalOnMissingBean has been there since 2015. Not sure why this would change now, but if you provide a sample that reproduces the issue, I can take a look.

Hi @OlgaMaciaszek, you are right. I have tried to create a reproducer https://github.com/ZIRAKrezovic/spring-cloud-reproducer/tree/commons-1335
As soon as I uncomment @Configuration in https://github.com/ZIRAKrezovic/spring-cloud-reproducer/blob/commons-1335/src/main/java/com/github/krezovic/springcloudreproducer/ProjectRestTemplateCustomizer.java, load balancing breaks and the test fails.
It is possible that it never worked but nobody tested it or that somehow the old post-processor picked it up. But I can't remember defining any RestTemplate.Builder beans that the PostProcessor picked up.
You may close the issue.


Get rid of language specific in files

We need to get rid of language specific in files. Maybe a template logic?
List of files:

[x] html.js
[x] tree.js
[x] upload.js

Closed with #4


Errno::ENOENT (No such file or directory @ rb_sysopen - .../cache/saml/metadata/Influitive-AdvocateHub)

Subj, what should be there?
Errno::ENOENT (No such file or directory @ rb_sysopen - /var/www/crm.wegohealth.com/releases/20150218112304/cache/saml/metadata/Influitive-AdvocateHub):
  config/initializers/saml_idp.rb:118:in `initialize'
  config/initializers/saml_idp.rb:118:in `open'
  config/initializers/saml_idp.rb:118:in `block (2 levels) in <top (required)>'
  lib/response_timer.rb:21:in `call'
  lib/core_ext/thread.rb:16:in `call'
  lib/core_ext/thread.rb:16:in `block in initialize'

We are getting a similar error. The problem appears to be that the "metadata_persister" is not running before the "metadata_getter" runs

can you provide some truncated version of the initializer? I think I'm missing something

I had to change the initializer to read:
  # `identifier` is the entity_id or issuer of the Service Provider,
  # `service_provider` is a ServiceProvider object. Based on the `identifier` or the
  # `service_provider` you should return the settings.to_h from above
  config.service_provider.persisted_metadata_getter = ->(identifier, service_provider){
    fname = identifier.to_s.gsub(/\/|:/,"_")
    `mkdir -p #{Rails.root.join("cache/saml/metadata")}`
    if File.file?(Rails.root.join("cache/saml/metadata/#{fname}"))
      File.open Rails.root.join("cache/saml/metadata/#{fname}"), "rb" do |f|
        Marshal.load f
      end
    end
  }

@jphenow was my comment sufficient for you to update the README (example) or should I try to submit a pull request.

Oh cripes, my bad.
I'll take a look at your PR and we'll wrap it up there.

Ah, derping this morning. Also not a PR.
Writing up a change to the README now

@TJM please see #24


Admin only creation of custom bots

Following #2186 and #692 (which splits bots into dumber integration only bots which can't read the stream, and full custom bots which can read/write) it'd be nice to have an organization setting which limits the creation of full custom bots to admins.
For security concerned organizations, you could have better control over who has custom bot API key access, which would better limit vulnerability to malicious actors, especially in installations of Zulip accessible from the general internet. In addition, users requesting custom bots from admins gives the admins a chance to remind the users of their security responsibilities before creating the custom bot, and transferring it to the user.
I'm unsure if there a use case for having an option to limit all bot creation to admins, as the security vulnerabilities there are much less.

Yeah, I think the idea of limiting access to create custom bots is the right boundary.  Adding the setting checkbox should be an application of zulip.readthedocs.io/en/latest/new-feature-tutorial.html (it should go in organization permissions) ; making it do something should be a few lines in the create_bot_backend function.  We'll want to make sure to do some negative tests for the security model check, and to document what it does clearly (and communicate clearly to users who might want a custom bot that they need to ask they admin).

Would it also make sense to put Outgoing Webhook bots into the admin only area? I'm not sure what information they send.

@zulipbot claim

@synicalsyntax seems like a bug in zulipbot?

@lonerz Changed the behavior so that a issue must be referenced in both the PR description and one of the PR's commit messages; it looks like she doesn't have a commit referencing the issue yet.

@zulipbot I'm still working on this.


[3.0] [AnyHashable] Handle comparisons/casting for wrappers around bridged types

Swift value types are their bridged Objective-C classes can have
different hash values. To address this, AnyHashable's responds to the
_HasCustomAnyHashableRepresentation protocol, which bridge objects of
those class types---NSString, NSNumber, etc---into their Swift
counterparts. That way, we get consistent (Swift) hashing behavior
across platforms.
However, there are cases where multiple Swift value types map to the
same Objective-C class type. In such cases, AnyHashable ends up
converting the object of class type back to some canonical type. For
example, an NS_STRING_ENUM (such as (NS)RunLoopMode) is a Swift
wrapper around a String. If an (NS)RunLoopMode is placed into an
AnyHashable, it maintains it's Swift type identity (which is correct
behavior). If it is bridged to Objective-C, it becomes an NSString; if
that NSString is placed into an AnyHashable, it produces a String. The
hash values still line up, but equality of the AnyHashable values
fails, which breaks when (for example) a dictionary with AnyHashable
keys is used from Objective-C. See SR-2648 / rdar://problem/27992351
for a case where this breaks interoperability.
To address this problem, make AnyHashable's casting and equality
sensitive to the origin of the hashed value: if the AnyHashable was
created through a _HasCustomAnyHashableRepresentation conformance,
treat comparisons/casting from it as "fuzzy":

For equality, if one of the AnyHashable's comes from a custom
representation (e.g., it originated with an Objective-C type like
NSString) but the other did not, bridge the value of the other
AnyHashable to Objective-C, re-wrap it in an AnyHashable, and
compare that. This allows, e.g., an (NS)RunLoopMode created in Swift
to compare to an NSString constant with the same string value.
For casting, if the AnyHashable we're casting from came from a
custom representation and the cast would fail, bridge to Objective-C
and then initiate the cast again. This allows an NSString to be
casted to (NS)RunLoopMode.

Resolves SR-2648 / rdar://problem/27992351

(cherry picked from commit 6f34118cb690ec542077ecaf0c0dfd9997ca2d03)

@swift-ci please test

Build failed
Jenkins build - Swift Test OS X Platform
Git Commit - 8e577db3234a1dd5b3bfa338698eab6a9d5eec79
Test requested by - @DougGregor

@DougGregor CI (macOS) is not happy:
/Users/buildnode/jenkins/workspace/swift-PR-osx/branch-swift-3.0-branch/buildbot_incremental/swift-macosx-x86_64/test-macosx-x86_64/1_stdlib/Output/AnyHashableCasts.swift.gyb.tmp/AnyHashableCasts.swift:347:3: error: use of unresolved identifier 'expectNotNil'
17:34:35   expectNotNil(wrapper1Hello as? StringWrapper1)
17:34:35   ^~~~~~~~~~~~

3.0 StdlibUnittest doesn't have that API

Ugh, status busted. I'll re-open the PR.


Support random state and CV

Add support for RandomState and Generator. Unfortunately, the numpy docs were a bit sparse when it comes to how to save and load those, I think I got it right but please check. Especially, do you think the new test is rigorous enough?
Regarding cross validators, ideally we would have a something like estimator_checks but for cross validators instead. I didn't find anything (LMK if there is) so for now I just tested a couple of cross validators but not all.
As you can see, the cross validators just use BaseEstimator_get_state and BaseEstimator_get_instance under the hood. I assume that many of the failing tests can also be fixed by falling back on those two functions when we encounter an sklearn class which is not taken care of (if it's not Cython). This makes me wonder if we could/should have something like a module level fallback. Since we control the dispatcher, it should be possible to implement this.
As for the tests, I did not try to save and load random states and cross validators as "first class" objects but always as attributes on a BaseEstimator. I was not sure if we want to support them as "first class" objects or not.
Finally, I fixed the bug where sparse matrices were stored on the project root.
Please review @adrinjalali. Locally, this gives me 50 failed, 360 passed.

Side note: I skimmed the remaining failing tests and they can be categorized into the following failure cases:
Calling estimator incorrectly
E.g. TypeError: PLSRegression.fit() got an unexpected keyword argument 'y' or calling CountVectorizer with floats instead of strings.
Custom sklearn objects
E.g. TypeError: Getting the state of type <class 'sklearn.linear_model._sgd_fast.Hinge'> is not supported yet. This may be solved if we add fallbacks, otherwise we would probably need a special dispatcher for each of those.
Failing equality checks for custom objects
Since by default, two objects instances are not identical, even if all their attributes are.
Scipy ufuncs
Since they look like numpy ufuncs
Incorrect casting
Custom dict types are treated as dict (assert <class 'sklearn.covariance._graph_lasso._DictWithDeprecatedKeys'> == <class 'dict'>), json dicts not supporting non-string keys (AssertionError: assert {1} == {'1'}).

After latest merge, I get 24 failed, 386 passed vs 32 failed, 368 passed on original branch when testing locally.


[feature]: I want to add ARIA Attribute to Contact us, Sign in and Register Form Sections

GSSOC'23 Contributor
Is your feature request related to a problem? Please describe.

Add ARIA Attributes to Contact us, Sign in and Register Form Section for Better SEO Web Accessibility.

Describe the solution you'd like

Following Above Suggestion to add is the Solution for Us.

Additional context

ARIA attributes enable modifying an element's states and properties as defined in the accessibility tree. Note: ARIA only modifies the accessibility tree, modifying how assistive technology presents the content to your users. ARIA doesn't change anything about an element's function or behavior.

Hi @Gaurav-Verma07 . Please Review on this Issue as soon as Possible.  Thank You !

@Gaurav-Verma07 . Please Review on this Issue as soon as Possible. Thank You !. Only One Day I can have to Contribute to this.


Bugfix for dirac test with a hybrid B

Description
Companion PR of https://github.com/JCSDA-internal/oops/pull/1637.
Issue(s) addressed
None.
Testing
ctest on my workstation + CI tests
Dependencies
Waiting on the following PRs:

[x] waiting on https://github.com/JCSDA-internal/oops/pull/1637

I reset the test reference to its develop state, only updating the hybrid B components names.

I've merged the oops PR, this can be merged now too.


Updates homebrew formula

⚠ Note: This is a draft PR showing the required outline for fixing the Homebrew formula. It currently references 0.11.0-rc.1  of Funnel and will need to be updated for the final 0.11.0 release before merging!

Overview
This PR updates the Homebrew formula to successfully install funnel via brew install funnel
❌ Current Behavior
Installing Funnel via Homebrew fails:
brew install funnel
==> Downloading https://formulae.brew.sh/api/formula.jws.json
################################################################################################## 100.0%
==> Downloading https://formulae.brew.sh/api/cask.jws.json
################################################################################################## 100.0%
Error: funnel: wrong number of arguments (given 1, expected 0)

✅ New Behavior
Testing the new formula file:
➜ brew install --build-from-source ./build/release/funnel.rb

Error: Failed to load cask: ./build/release/funnel.rb
Cask 'funnel' is unreadable: wrong constant name #<Class:0x0000000111385b50>
Warning: Treating ./build/release/funnel.rb as a formula.
==> Fetching funnel
==> Downloading https://github.com/ohsu-comp-bio/funnel/releases/download/0.11.0-rc.1/funnel-darwin-arm64-0.11.0-rc.1.tar.gz
...
🍺  /opt/homebrew/Cellar/funnel/0.11.0-rc.1: 4 files, 81.4MB, built in 9 seconds
==> Running `brew cleanup funnel`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).

Verifying download:
➜  /opt/homebrew/Cellar/funnel/0.11.0-rc.1/bin/funnel
Usage:
  funnel [command]

Available Commands:
  aws         Development utilities for creating funnel resources on AWS
  completion  Generate shell completion code
  dashboard   Start a Funnel dashboard in your terminal.
  examples    Print example task messages.
  gce
  help        Help about any command
  node        Funnel node subcommands.
  run         Run a task.
  server      Funnel server commands.
  storage     Access storage via Funnel's client libraries.
  task        Make API calls to a TES server.
  version
  worker      Funnel worker commands.

Flags:
  -h, --help   help for funnel

Use "funnel [command] --help" for more information about a command.

https://github.com/goreleaser/goreleaser/pull/2591


Update storage-files-planning.md

Made it clear that the 'Important' call out refers to large (> 5Tb) file shares

@larryms : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@larryms - The file has been updated since the pull request was opened. The content updated in the PR no longer exists in the article. We'll this close this PR. Thank you for your contribution.


 Therefore, we need to remove kube-rbac-proxy ASAP.
Solution:
As per kubebuilder's guidance we should move the project to a go/v4 base which no longer uses kube-rbac-proxy.
CHECKLIST
Helm chart

[x] Is the helm chart updated with the new changes? (if applicable)

Jira

[ ] Is the Jira ticket created and referenced properly?

Tests

[ ] Is an Integration test/test case added for the new feature/change?
[ ] Are unit tests added where appropriate?

@mayankshah1607 I think I'll need your assistance in translating these changes to the helm chart :pray:

https://github.com/percona/percona-helm-charts/pull/436

Hi @recharte
Terrific work !!! 🚀
Thank you for upgrading your project 🥇


[spaceship] all_builds_for_train: error 410 gone

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description
/Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/spaceship/lib/spaceship/test_flight/client.rb:321:in `handle_response': [!]  (Spaceship::UnexpectedResponse)

<meta http-equiv="Content-Type" content="text/html;charset=utf-8"/>
<title>Error 410 Gone</title>

HTTP ERROR 410

Problem accessing */platforms/ios/trains/2.3.0/builds. Reason:

    Gone

	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/spaceship/lib/spaceship/test_flight/client.rb:38:in `block in get_builds_for_train'
	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/spaceship/lib/spaceship/client.rb:620:in `with_retry'
	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/spaceship/lib/spaceship/test_flight/client.rb:36:in `get_builds_for_train'
	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/spaceship/lib/spaceship/test_flight/build.rb:115:in `builds_for_train'
	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/spaceship/lib/spaceship/tunes/application.rb:315:in `all_builds_for_train'
	from Fastfile:343:in `block (2 levels) in parsing_binding'
	from Fastfile:342:in `each'
	from Fastfile:342:in `block in parsing_binding'
	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/fastlane/lib/fastlane/lane.rb:33:in `call'
	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/fastlane/lib/fastlane/runner.rb:204:in `try_switch_to_lane'
	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/fastlane/lib/fastlane/runner.rb:146:in `trigger_action_by_name'
	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/fastlane/lib/fastlane/fast_file.rb:154:in `method_missing'
	from Fastfile:276:in `block (2 levels) in parsing_binding'
	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/fastlane/lib/fastlane/lane.rb:33:in `call'
	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/fastlane/lib/fastlane/runner.rb:49:in `block in execute'
	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/fastlane/lib/fastlane/runner.rb:45:in `chdir'
	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/fastlane/lib/fastlane/runner.rb:45:in `execute'
	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/fastlane/lib/fastlane/lane_manager.rb:56:in `cruise_lane'
	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/fastlane/lib/fastlane/command_line_handler.rb:36:in `handle'
	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/fastlane/lib/fastlane/commands_generator.rb:108:in `block (2 levels) in run'
	from /Library/Ruby/Gems/2.3.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:178:in `call'
	from /Library/Ruby/Gems/2.3.0/gems/commander-fastlane-4.4.6/lib/commander/command.rb:153:in `run'
	from /Library/Ruby/Gems/2.3.0/gems/commander-fastlane-4.4.6/lib/commander/runner.rb:476:in `run_active_command'
	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/fastlane_core/lib/fastlane_core/ui/fastlane_runner.rb:76:in `run!'
	from /Library/Ruby/Gems/2.3.0/gems/commander-fastlane-4.4.6/lib/commander/delegates.rb:15:in `run!'
	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/fastlane/lib/fastlane/commands_generator.rb:333:in `run'
	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/fastlane/lib/fastlane/commands_generator.rb:41:in `start'
	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/fastlane/lib/fastlane/cli_tools_distributor.rb:119:in `take_off'
	from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.121.1/bin/fastlane:23:in `<top (required)>'
	from /usr/local/bin/fastlane:22:in `load'
	from /usr/local/bin/fastlane:22:in `'

Command executed
  lane :spaceship_build_number_plus_one do
    fastlane_require 'spaceship'
<EMAIL_ADDRESS>    app = Spaceship::Tunes::Application.find("foo.bar")
    versions = app.all_build_train_numbers
    build_versions = []
    app.all_build_train_numbers.each do |version|
        build = app.all_builds_for_train(train: version).map(&:build_version).max
        build_versions.push(build)
    end
    build_number = build_versions.max.to_i + 1
  end

Environment

| Gem      | Version | Update-Status |                                                                                | -------- | ------- | ------------- |                                                                                | fastlane | 2.121.1 | ✅ Up-To-Date  |

The recent releases had to change quite a bit how they used spaceship because Apple removed the underlying APIs (which now return that error 410 gone). You can probably learn a bit by looking at the recent releases and the PRs they included.

I think I am getting the same error with version 2.120.0.
In ruby script in a call to groups = Spaceship::TestFlight::Group.filter_groups(app_id: xxxx)
I get the following response:
/users/user/.rvm/gems/ruby-2.3.1@global/gems/fastlane-2.120.0/spaceship/lib/spaceship/test_flight/client.rb:321:in `handle_response': <!DOCTYPE html> (Spaceship::UnexpectedResponse)

<title></title>
<link rel="stylesheet" href="/styles/main.css">

Not Found

Copyright © 2015 Apple Inc. All rights reserved.

Terms of Service

Privacy Policy

	from /users/user/.rvm/gems/ruby-2.3.1@global/gems/fastlane-2.120.0/spaceship/lib/spaceship/test_flight/client.rb:90:in `get_groups'
	from /users/user/.rvm/gems/ruby-2.3.1@global/gems/fastlane-2.120.0/spaceship/lib/spaceship/test_flight/group.rb:40:in `all'
	from /users/user/.rvm/gems/ruby-2.3.1@global/gems/fastlane-2.120.0/spaceship/lib/spaceship/test_flight/group.rb:55:in `filter_groups'

@pparmaei 2.120.0 can not be considered any more at all, as the updates were released to fix problems with that version. Please check if the problem also exists with 2.121.1 and report back - but as your error message is also totally different, and the method you are using is as well, please do so in a new issue you create. I don't think this has any direct relation to what @volmus reported here. Thanks.

@janpio Will this be fixed anytime soon? I looked into the code and the PRs but my ruby skills are really weak :[

Right now we don't know if this is still a problem as you didn't report back if this still applies with 2.121.1. But yes, @joshdholtz is continuing to work on fixing these problems.

My initial bug report is for 2.121.1, so yes, it "still" applies to 2.121.1.

Ok, then https://github.com/fastlane/fastlane/issues/14666#issuecomment-486411041 confuses me.

apologies if my comment caused confusion. We faced some regression issues with version 2.121.1, so we have rolled back for now.  I will try again when the next version gets released. (#14661),
However, I can see that my error is also in line 321 of client.rb --> https://github.com/fastlane/fastlane/blob/master/spaceship/lib/spaceship/test_flight/client.rb#L321

@volmus @pparmaei I just noticed that I confused you both as you have the both avatar - hazard of reading a few dozens new issues a day across repositories. I apologize.
Problem is that Apple removed some APIs and we are trying to find replacements and get those implemented.
@pparmaei You could help us by creating a new issue and including the whole output including the full stacktrace you are getting and also your fastlane env (even if for 2.210.0) output. I think your problem is separate from what @volmus reported here, so having its own issue would help us - even if just to track that you update it when 2.212.0 was released.) Thanks.

@joshdholtz
Any news on this?

For anyone interested here's my current workaround:
  lane :spaceship_build_number_plus_one do     fastlane_require 'spaceship'     Spaceship::Tunes.login("username")     app = Spaceship::Tunes::Application.find("foo.bar")     versions = app.all_build_train_numbers     build_versions = []     app.all_build_train_numbers.each do |version|         build = latest_testflight_build_number(version: version, app_identifier: "foo.bar", username: "username")         build_versions.push(build)     end     build_number = build_versions.max.to_i + 1   end

Broken since 2.125.0:
/Library/Ruby/Gems/2.3.0/gems/fastlane-2.125.0/spaceship/lib/spaceship/test_flight/build_trains.rb:24:inblock in all': [!] undefined method []' for #<Spaceship::ConnectAPI::Response:0x00007fe97250b7d0> (NoMethodError)         from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.125.0/spaceship/lib/spaceship/test_flight/build_trains.rb:22:in loop'
from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.125.0/spaceship/lib/spaceship/test_flight/build_trains.rb:22:in all'         from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.125.0/spaceship/lib/spaceship/tunes/application.rb:301:in build_trains'
from /Library/Ruby/Gems/2.3.0/gems/fastlane-2.125.0/spaceship/lib/spaceship/tunes/application.rb:307:in all_build_train_numbers'         from Fastfile:371:in block in parsing_binding'
`

Using fastlane 2.125.2, the three methods (I know of) to get to a build train or the builds within one are all failing. From the spaceship playground:
[4] pry(#<Spaceship::Playground>)> app = Spaceship::Tunes::Application.find("my.bundle.id")
=> <Spaceship::Tunes::Application
	apple_id="xxxxx",
	name="mycompany",
	vendor_id="CGAPP-001",
	bundle_id="my.bundle.id",
	last_modified=1560273211000,
	issues_count=0,
	app_icon_preview_url="https://url-to-our-icon-image.png",
	version_sets=[<Spaceship::Tunes::VersionSet
		type="APP",
		application=<Spaceship::Tunes::Application
		#<Object ...>>,
		platform="ios">]>

[5] pry(#<Spaceship::Playground>)> versions = app.all_build_train_numbers
NoMethodError: undefined method `[]' for #<Spaceship::ConnectAPI::Response:0x007fd86f49c768>
from /Users/lbrownell/.rvm/gems/ruby-2.3.3/gems/fastlane-2.125.2/spaceship/lib/spaceship/test_flight/build_trains.rb:24:in `block in all'

[6] pry(#<Spaceship::Playground>)> train = app.build_trains["6.0"]
NoMethodError: undefined method `[]' for #<Spaceship::ConnectAPI::Response:0x007fd81d3664b8>
from /Users/lbrownell/.rvm/gems/ruby-2.3.3/gems/fastlane-2.125.2/spaceship/lib/spaceship/test_flight/build_trains.rb:24:in `block in all'

[7] pry(#<Spaceship::Playground>)> app.all_processing_builds
NoMethodError: undefined method `[]' for #<Spaceship::ConnectAPI::Response:0x007fd878031760>
from /Users/lbrownell/.rvm/gems/ruby-2.3.3/gems/fastlane-2.125.2/spaceship/lib/spaceship/test_flight/build_trains.rb:24:in `block in all'```

Different error @lbrownell-gpsw, please create a new issue so this can be properly tracked. Thanks.

Done: https://github.com/fastlane/fastlane/issues/14889

Error 410 seems to be gone, now replaced with what is reported in #14889

Different error @lbrownell-gpsw, please create a new issue so this can be properly tracked. Thanks.
Done: #14889
vs
Error 410 seems to be gone, now replaced with what is reported in #14889

OK

The error 410 does not happen any more, correct @volmus? There were some very substantial changes to fastlane to get rid of those, but seems that there is a new bug with a different error message (and underlying reason) now that is now being tracked in #14889. Or do you disagree with that @volmus?


no default layout

I had to add app.set('layout', 'layout');  in app.js to make it work.

That shouldn't be necessary. Check the working example.


refactor: 💡 Showing an example of branches and git cz

Hello world
This pull request closes:
✔ Closes Jira Issue: TC-666
Which service(s) does this issue affect:

[ ] 🛰 API
[ ] 🛒 webstore
[ ] 🎓 admin-page

Types of changes

[ ] 🐛 Bug fix (a non-breaking change which fixes an issue)
[ ] 🧱 New feature (a non-breaking change which adds functionality)
[ ] 💥 Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🤖 CI/CD (a change to the CI/CD pipeline)
[ ] ⚗ Refactoring (an update to some already existing code)
[ ] 💄 Style (Markup, formatting, CSS)

Documentation Updates

[ ] 📂 No need for updates
[ ] 📁 Requires an update ( not done within this issue )
[ ] 🗃 Has been updated ( done within this issue )

Testing checklist

[ ] 💪 Manual tests
[ ] 🔧 Automatic tests

Browser compatibility - [Frontend only]

[ ] Tested on Safari
[ ] Tested on Chrome
[ ] Tested on Mozilla Firefox

What changes have been done within this issue?

How should this be manually tested?

Screenshots or example usage

The demo is over


Recognize AllContributors in the README

We should start using https://github.com/all-contributors/all-contributors to fully recognize the people who contribute to this project, both with code and via answering questions.

Seems like an interesting idea and I'm sure there are a lot of people that helped out in more than just code-stuff and PRs

Answering questions might be a bit interesting due to a lot of ppl also answering in the Discord server and we can't really keep track of those, while still being on the same contribution level (or imo even helping "better") as those in issues.
I wouldn't mind keeping track of all PR contributors tho (but maybe not via the bot or at least not with those categories... i don't really like the proposed emoji key)


Fix ci

line endings are normalized
switched to github actions from travis to check forked branches

bors r+


MQTT constantly reconnecting

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.43.2
Python release (python3 --version):
3.5.3
Component/platform:
MQTT
Description of problem:
MQTT is constant reconnecting to the broker:
5/3/2017 8:54:52 AM17-05-03 08:54:52 INFO (Thread-12) [homeassistant.components.mqtt] Successfully reconnected to the MQTT server
5/3/2017 8:54:54 AM17-05-03 08:54:54 INFO (Thread-12) [homeassistant.components.mqtt] Successfully reconnected to the MQTT server
5/3/2017 8:54:56 AM17-05-03 08:54:56 INFO (Thread-12) [homeassistant.components.mqtt] Successfully reconnected to the MQTT server

In my mosquitto logs, I can see it is getting a socket error or is already connected and keep trying to connect again:
5/3/2017 8:55:40 AM1493819740: New connection from <IP_ADDRESS> on port 1883.
5/3/2017 8:55:40 AM1493819740: New connection from <IP_ADDRESS> on port 1883.
5/3/2017 8:55:40 AM1493819740: Client home-assistant already connected, closing old connection.
5/3/2017 8:55:40 AM1493819740: Client home-assistant already connected, closing old connection.
5/3/2017 8:55:40 AM1493819740: Client home-assistant disconnected.
5/3/2017 8:55:40 AM1493819740: Client home-assistant disconnected.
5/3/2017 8:55:40 AM1493819740: New client connected from <IP_ADDRESS> as home-assistant (c1, k60, u'homeassistant').
5/3/2017 8:55:40 AM1493819740: New client connected from <IP_ADDRESS> as home-assistant (c1, k60, u'homeassistant').
5/3/2017 8:55:40 AM1493819740: Sending CONNACK to home-assistant (0, 0)
5/3/2017 8:55:40 AM1493819740: Sending CONNACK to home-assistant (0, 0)
5/3/2017 8:55:40 AM1493819740: New connection from <IP_ADDRESS> on port 1883.
5/3/2017 8:55:40 AM1493819740: New connection from <IP_ADDRESS> on port 1883.
5/3/2017 8:55:41 AM1493819741: Socket error on client <unknown>, disconnecting.
5/3/2017 8:55:41 AM1493819741: Socket error on client <unknown>, disconnecting.
5/3/2017 8:55:41 AM1493819741: New connection from <IP_ADDRESS> on port 1883.
5/3/2017 8:55:41 AM1493819741: New connection from <IP_ADDRESS> on port 1883

It seems to alternate between socket error and already connected.
Expected:
Home Assistant stays connected only once.
Problem-relevant configuration.yaml entries and steps to reproduce:
mqtt:
  broker: host-name
  port: 1883
  client_id: home-assistant
  username: homeassistant
  password: !secret mqtt_password
  protocol: 3.1

Traceback (if applicable):

Additional info:
Mosquitto and Home Assistant are both running in Docker containers. I also have the smartthings-mqtt-bridge running in a Docker container. The mqtt-bridge has no problem staying connected, but Home Assistant does.
Interestingly, I have a nearly identical setup (exact same Mosquitto and Home Assistant configurations) and it works perfectly fine on one machine but I have this issue on the other.

Hmm. It seems something may have been messed up in the Mosquitto container. I recreated it and now I'm not getting this issue anymore. I'll close this until it happens again.


fix: Prevent warnings/errors when running meltano config <plugin> test

Resolves #6632 by waiting for subprocess to exit after terminating given a RECORD message received, instead of immediately returning from the method. Includes some other minor fixes, since I was in the area. :smile:
Before fix
Python 3.7

Python 3.9

After fix
Python 3.7

Python 3.9

Checklist

[x] Implement fix
[x] Add/update tests

Linter was complaining about docstrings in plugin_test_service.py so I fixed them in 6ad4c8fe29c4cc1e734ba6444f79d0aa0f7ff059. Feel free to change.

@ReubenFrankel lgtm! thanks for taking the time to add docstrings and fix the type annotations.
I'll request review from other folks in the team in case I missed anything.


¿Will armv7l be supported?

¡Thank you for making this!
I would like to play netflix in a raspberry which has ARM architecture.
¿Will this package support that?

@tobeoria If there's a way to download Widevine for ARM, it's possible. But I cannot find a good source for it. :(


Add playground + bug template for 2.0

In 1.0, we had a StackBlitz playground that could be used to experiment with validation and repro bugs (see https://stackblitz.com/edit/arktype-bug?devToolsHeight=33&file=package.json).
StackBlitz has been very slow to support newer TS versions in their base TS project, so likely we'd have to migrate to web-containers to support this, but it shouldn't be much work to just transfer it 1:1 since we've dropped the dynamic generation.
Once this is done, we should also add this back to the repro section of .github/ISSUE_TEMPLATE/bug_report.md:
<!--
1. Update the template link below so that it reproduces the problem you're having.
2. Add comments to describe differences between actual and expected behavior.
3. Click "Fork" in the top-left corner of StackBlitz
4. Copy the new URL and use it to replace the template URL below.
5. Copy the source code you used to repro the bug and paste it into the code block below.
-->

https://stackblitz.com/edit/arktype-bug?devToolsHeight=33&file=demo.ts

```ts
import { type, scope } from "arktype"

// Paste reproduction code here

I began working on a custom Monaco environment w/ ArkType syntax highlighting.
Some aspects can probably be standardized to reuse some of the styling from Shiki in the docs, but might be a good basis for a starting point (or terrible):
import Editor, { useMonaco } from "@monaco-editor/react"
import arkdarkColors from "arkdark/arkdark.json"
import arktypeTextmate from "arkdark/tsWithArkType.tmLanguage.json"
import type * as Monaco from "monaco-editor"
import { wireTmGrammars } from "monaco-editor-textmate"
import { Registry } from "monaco-textmate"
import { loadWASM } from "onigasm"
import onigasm from "onigasm/lib/onigasm.wasm?url"
import React, { useState } from "react"
import "../styles.css"
// import syntax from "./syntax.ts?raw"

interface IVSCodeTheme {
    colors: {
        [name: string]: string
    }
    tokenColors: ITokenColor[]
}
interface ITokenColor {
    scope: string | string[]
    settings: {
        foreground?: string
        background?: string
        fontStyle?: string
    }
}

const translateVSCodeTheme = (
    theme: IVSCodeTheme
): Monaco.editor.IStandaloneThemeData => {
    theme.colors["editor.background"] = "#f5cf8f0a"
    return {
        base: "vs-dark",
        inherit: false,
        colors: theme.colors,
        rules: theme.tokenColors.flatMap((c) => {
            if (Array.isArray(c.scope)) {
                return c.scope.map(
                    (sub) =>
                        ({
                            token: sub,
                            background: c.settings.background,
                            foreground: c.settings.foreground,
                            fontStyle: c.settings.fontStyle
                        }) as Monaco.editor.ITokenThemeRule
                )
            }
            return {
                token: c.scope,
                background: c.settings.background,
                foreground: c.settings.foreground,
                fontStyle: c.settings.fontStyle
            } as Monaco.editor.ITokenThemeRule
        })
    }
}

const theme = translateVSCodeTheme(arkdarkColors)

const setupMonaco = async (monaco: typeof Monaco) => {
    await loadWASM(onigasm)
    monaco.editor.defineTheme("arkdark", theme)
    await wireTmGrammars(
        monaco,
        new Registry({
            getGrammarDefinition: async () => ({
                format: "json",
                content: arktypeTextmate
            })
        }),
        new Map().set("typescript", "source.ts")
    )
}

export const HomeDemo = () => {
    const [loaded, setLoaded] = useState(false)
    const monaco = useMonaco()
    if (monaco && !loaded) setupMonaco(monaco).then(() => setLoaded(true))
    return loaded ? (
        <Editor
            height="30vh"
            defaultLanguage="typescript"
            defaultValue=""
            theme="arkdark"
            options={{
                minimap: { enabled: false },
                scrollBeyondLastLine: false
            }}
            onMount={(editor, monaco) => {
                // TODO: ?
                monaco
                const editorElement = editor.getDomNode()
                if (editorElement) {
                    editorElement.style.borderRadius = "16px"
                    editorElement.style.boxShadow =
                        "0 10px 15px 0 rgba(0, 0, 0, 0.3), 0 15px 30px 0 rgba(0, 0, 0, 0.22)"
                    editorElement.style.transition =
                        "all 0.3s cubic-bezier(.25,.8,.25,1)"
                    editorElement.style.backdropFilter = "blur(16px)"
                    const guard = editorElement?.querySelector(
                        ".overflow-guard"
                    ) as HTMLElement | null
                    guard!.style.borderRadius = "16px"
                }
            }}
        />
    ) : (
        "Loading..."
    )
}


Dev

Codecov Report

Merging #9 into master will increase coverage by 10.16%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #9       +/-   ##
==========================================
+ Coverage   84.04%   94.2%   +10.16%
==========================================
  Files          15      15
  Lines         282     259       -23
==========================================
+ Hits          237     244        +7
+ Misses         45      15       -30

Impacted Files
Coverage Δ

src/Finance.Domain/ValueObjects/Amount.cs
86.04% <ø> (+10.53%)
:arrow_up:

src/Finance.Domain/ValueObjects/SSN.cs
93.75% <100%> (+48.03%)
:arrow_up:

src/Finance.Domain/ValueObjects/Name.cs
75% <100%> (+15%)
:arrow_up:

src/Finance.Domain/Accounts/Account.cs
100% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa1bb4e...19354b0. Read the comment docs.


Code block line highlighting?

Hey! This is awesome! I was like, "I wonder if I can turn my markdown into slides somehow...". Thank you! Does this support line highlighting in code blocks? Thx!

Yes, it does. Use fenced code blocks (```) same as github-flavored markdown.


add information for the resetting conversation

Add information for the resetting conversation
*Usage*
  Enter an instruction and press enter (%C reset conversation, %Q quits).

Our Copybara automation has effectively merged this pull request and imported it as a commit in dev branch: 7ab968c957a74b5b0c312212089fc878a310c245
Unfortunately, the automation doesn't actually merge pull requests right now, so we have to manually close it now (we're working on fixing this). Thanks for your contribution!


🐛 Bug Report: Wenn Freigabe über Link nicht gefunden wird

👟 Reproduction steps
Freigabe erstellen, Mailfreigabe versenden, Freigabe löschen dann keine korrekte Seitendarstellung das keine Freigabe mehr vorhanden ist nach Drücken des ZURÜCK Buttons. Habe die App inder der :latest Version getestet.
👍 Expected behavior
.
👎 Actual Behavior
.
🌐 Browser
Chrome

Thanks. This is fixed and will be available in the next release. For the next time, please compose your issue in English, because else the other people won't understand it.

I'm looking forward to your new release. You make an innovative product, I like it very much. My next GitHub will be in English.

Am 05.02.2024 um 16:15 schrieb Elias Schneider @.***>:
Thanks. This is fixed and will be available in the next release. For the next time, please compose your issue in English, because else the other people won't understand it.
—
Reply to this email directly, view it on GitHub https://github.com/stonith404/pingvin-share/issues/398#issuecomment-1927230055, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5ZGH3IHAPC54YWGQL5EH2TYSDZRLAVCNFSM6AAAAABCZGEVKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRXGIZTAMBVGU.
You are receiving this because you authored the thread.


Make ChatCraft promt templates easy configurable

Design and implement basic authentication and configuration logic to modify chatcraft_templates.json
Improve the error handling for the functions working with file

it was done in scope of https://github.com/COXIT-CO/RecruitFlowAI/pull/22 , the following commands updates links and descriptions if needed
/generate_job_description https://chatcraft.org/c/iramykytyn/LkjsdteMwbbdlRkJoccI_  - update the command url
/generate_job_description Hint: new hints to use  - update the command hint
However, it should be tested if it works for all chatcraft commands and create separate issues if it does.


Revert "fixed gnutls as per issue 196 thansk to @jmalpede"

This reverts commit 63c4c8406e7f6b49eeb94d787f258917e8716b0b.
Overall Review of Changes:
Reversion of a previous commit that introduced a regression.
Issue Fixes:
Fixes #233
How has this been tested?:
File content verified after running playbook.

hi @qwestduck
Thank you for raising this issue, unfortunately since the ansible galaxy changes this has broken older ansible releases. We are trying to give clients a longer support around older ansible versions. This means we need to update the collections method for the pipeline.
I am raising this and pushing a new branch today into devel with these fixes.
many thanks
uk-bolly


Please bump Pod version to 1.5.2

@m1entus please create a pull request and I'll gladly merge it. That way you will get some credit.

Oh c'mor really? Anyway you would have to make pod trunk push, with new Podfile, so making a tag in to your repository and changing one number in Podfile will not be so hard for you ...

I'll take care of it.
On Mon, Dec 5, 2016 at 4:56 AM Michał Zaborowski<EMAIL_ADDRESS>wrote:

Oh c'mor really? Anyway you would have to make pod trunk push, with new
Podfile, so making a tag in to your repository and changing one number in
Podfile will not be so hard for you ...
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/mmorey/MDMCoreData/issues/41#issuecomment-264811718,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUl93JbuCpfdzoV8sAFyjZuY0Br6mFks5rE9_igaJpZM4LADT2
.

Anything ?

I have updated the change log and tagged the commit with 1.5.2 but unable to do a pod trunk push. Here is what I'm getting, any ideas?
16:55:42:~/Desktop/MDMCoreData (master | me@matthewmorey.com)$ pod trunk push

[!] Found podspec `MDMCoreData.podspec`
Updating spec repo `master`

CocoaPods 1.2.0.beta.1 is available.
To update use: `sudo gem install cocoapods --pre`
[!] This is a test version we'd love you to try.

For more information, see https://blog.cocoapods.org and the CHANGELOG for this version at https://github.com/CocoaPods/CocoaPods/releases/tag/1.2.0.beta.1

Validating podspec
 -> MDMCoreData (1.5.2)
    - ERROR | [OSX] xcodebuild: Returned an unsuccessful exit code. You can use `--verbose` for more information.
    - NOTE  | [OSX] xcodebuild:  /Users/xzolian/Library/Developer/Xcode/DerivedData/App-eugmjepahdkzbjcchxtwvohscubv/Build/Products/Release/MDMCoreData/MDMCoreData.framework/Headers/MDMCoreData.h:30:9: fatal error: 'MDMFetchedResultsTableDataSource.h' file not found
    - NOTE  | [OSX] xcodebuild:  /var/folders/zl/fqrj7z8d46g96qqyzc62qlyc0000gn/T/CocoaPods/Lint/App/main.m:3:9: fatal error: could not build module 'MDMCoreData'

[!] The spec did not pass validation, due to 1 error.
[!] The validator for Swift projects uses Swift 3.0 by default, if you are using a different version of swift you can use a `.swift-version` file to set the version for your Pod. For example to use Swift 2.3, run:
    `echo "2.3" > .swift-version`.

This is not a Swift pod, not sure what is going on.


is this in active development?

Well, a question with almost two year without answer we say us this project is dead.


fix: Conversion operations having poison results

Closes #103

Codecov Report
Attention: Patch coverage is 90.69767% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.18%. Comparing base (ce14684) to head (3c20cd3).

Files with missing lines
Patch %
Lines

src/extension/conversions.rs
90.69%
2 Missing and 2 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   85.13%   85.18%   +0.05%
==========================================
  Files          31       31
  Lines        4238     4247       +9
  Branches     4238     4247       +9
==========================================
+ Hits         3608     3618      +10
  Misses        305      305
+ Partials      325      324       -1

Flag
Coverage Δ

rust
85.18% <90.69%> (+0.05%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Audible alerts for Uchiwa

It would be extremely useful to add in audible alerts for sensu configurable based on;

Severity eg for critical or warning only.
Plugin alert source (eg disk issue, cpu, network).

Although this does not have a huge impact on functionality it has a huge impact on useability (and being able to sell Sensu internally as a monitoring tool).

Great idea !

John Dyer
407.474.0214

Sent from mobile. Please excuse brevity or typographical errors *

On Tue, Mar 24, 2015 at 7:37 AM, Rob Readman<EMAIL_ADDRESS>wrote:

It would be extremely useful to add in audible alerts for sensu configurable based on;

Severity eg for critical or warning only.
Plugin alert source (eg disk issue, cpu, network).
Although this does not have a huge impact on functionality it has a huge impact on useability (and being able to sell Sensu internally as a monitoring tool).

Reply to this email directly or view it on GitHub:
https://github.com/sensu/uchiwa/issues/294

Any chance of this gaining any attention?

Hi @rreadman
It's definitively something I would like to add to Uchiwa at some point, however in the short term I will not have time to work on this specific feature. Contributions are welcome!

+1

I think this would be an incredibly useful feature. +1

Also would love this +1

:+1:

+1

+1


(BOLT-334) Bundle the package, service, puppet_conf modules

This allows users to manage packages, services, and puppet.conf settings in
an out-of-the-box bolt install.
This adds a Puppetfile to manage the set of modules we bundle with bolt. It
also adds a development dependency on r10k to apply the Puppetfile.

CLA signed by all contributors.


Code quality

Fix some of the regex.
Prefer for ([])
Use some better array functions.
Don't be afraid of using .includes

Thanks for the MR, the changes LGTM.
Just a note, .includes was problematic at some point for IE 11 so we should double check that the library still supports it after these changes.

Just a note, .includes was problematic at some point for IE 11 so we should double check that the library still supports it after these changes.

IIRC IE11 never supported the String.includes function.

Nice

LGTM 👍


Upgrade dependencies to latest version

Bump Spotless to latest version (2.17.4)
Bump Log4J to latest version (2.14.1)
Bump JUnit5 to latest version (5.8.1)
Bump Assertj to latest version (3.21.0)
Bump Maven-compiler to latest version (3.8.1)
Bump Maven Shade plugin to latest version (3.2.4)
Upgrade Flink to latest version (1.14)

Thanks @MartijnVisser.


Optional behavior change

resolves #50
This addresses everything from our discussion to the best of my knowledge.
I'd love a review on this if/when you guys have time.

Pull Request Test Coverage Report for Build 172

9 of 9 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 171:
0.0%

Covered Lines:
177

Relevant Lines:
177

💛  - Coveralls