User Defined Generics RFC

I wanted to share this draft of an "RFC" (although I based the structure loosely off the Python PEP format, like this one on generics) on adding user-defined generic types and functions to egglog.
Happy for any feedback here or to set up a call if that's easier.
i.e. Does it make sense? Are there any questions left after reading it? Any confusion about the rationale or the syntax?
What do you think of it? Do you think implementing it is viable? Would it be useful for any of your work?

Thanks for the RFC @saulshanabrook!
Quick question: would it be possible to desugar all these problems with generics on the python side?
As in, the python bindings would generate egglog code, one function per instantiation.
That way, you could experiment with generics and we won't have to modify egglog (yet!)
Egglog is about to go through lots of cleanup, so it's not a great time to add complexity to the type system

Hey @oflatt yeah that makes sense. I believe it would be doable by generating new datatypes for each instantiation of a generic type.
For rewrites/rules that use generic types, they are generated for every pairwise combination of generic types that they use and are instantiated.

I don't think this needs to be considered right now, but re opening this bc I thought of an issue with the desugaring approach...
If there is a rule that has facts that use type T and actions that create type List[T] what concrete types do you instantiate this with? It seems like at the limit it could be infinite if it applies recursively.

I'll re-close this actually and open an issue if I want to look more into how to implement generics as pre-processing step.


fix: Skip https certificate verification

Codecov Report

Merging #268 into master will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
+ Coverage   86.58%   86.61%   +0.02%
==========================================
  Files          50       50
  Lines        3079     3078       -1
==========================================
  Hits         2666     2666
+ Misses        285      284       -1
  Partials      128      128

Impacted Files
Coverage Δ

config/profile.go
86.98% <0.00%> (+0.51%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ecf4ae...6a04158. Read the comment docs.


Setting IFS crashes PaSh

It seems like someone made a report already here https://github.com/binpash/pash/issues/386 but indeed setting IFS does seem to incorrectly crash PaSh. Here are the steps to reproduce the issue with the following script:
IFS=/
echo "hi there"

expected behavior when running $PASH_TOP/pa.sh test.sh: hi there
actual behavior:
/pash/compiler/orchestrator_runtime/pash_prepare_call_compiler.sh: line 51: response_args[1]: unbound variable

and then Pash just hangs and must be terminated with a signal.

The problem seems to be that, in a few places, pa.sh assumes that IFS is the default ($’ \t\n’). I created a quick PR that saves and resets the IFS when necessary.

Thanks for fixing this @BolunThompson !


Visual Studio Code for Unity: "The reference assemblies for .NETFramework,Version=v4.7.1 were not found. ... "

Environment data
dotnet --info output:
.NET SDK (reflecting any global.json):
Version:   5.0.102
Commit:    71365b4d42
Runtime Environment:
OS Name:     ubuntu
OS Version:  20.04
OS Platform: Linux
RID:         ubuntu.20.04-x64
Base Path:   /usr/share/dotnet/sdk/5.0.102/
Host (useful for support):
Version: 5.0.2
Commit:  cb5f173b96
.NET SDKs installed:
5.0.102 [/usr/share/dotnet/sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 5.0.2 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 5.0.2 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
To install additional .NET runtimes or SDKs:
https://aka.ms/dotnet-download
VS Code version: 1.52.1
C# Extension version: v1.23.8
OmniSharp log
Starting OmniSharp server at 1/15/2021, 4:21:50 PM
Target: /home/simon_rober/CS02 - Introduction to Unity/CS02 - Introduction to Unity.sln
OmniSharp server started.
Path: /home/simon_rober/.vscode/extensions/ms-dotnettools.csharp-1.23.8/.omnisharp/1.37.5/run
PID: 38730
    Starting OmniSharp on ubuntu 20.4 (x64)

    DotNetPath set to dotnet

    Located 1 MSBuild instance(s)
        1: StandAlone 16.8.0 - "/home/simon_rober/.vscode/extensions/ms-dotnettools.csharp-1.23.8/.omnisharp/1.37.5/omnisharp/.msbuild/Current/Bin"

    MSBUILD_EXE_PATH environment variable set to '/home/simon_rober/.vscode/extensions/ms-dotnettools.csharp-1.23.8/.omnisharp/1.37.5/omnisharp/.msbuild/Current/Bin/MSBuild.exe'

    Registered MSBuild instance: StandAlone 16.8.0 - "/home/simon_rober/.vscode/extensions/ms-dotnettools.csharp-1.23.8/.omnisharp/1.37.5/omnisharp/.msbuild/Current/Bin"
        CscToolExe = csc.exe
        MSBuildToolsPath = /home/simon_rober/.vscode/extensions/ms-dotnettools.csharp-1.23.8/.omnisharp/1.37.5/omnisharp/.msbuild/Current/Bin
        CscToolPath = /home/simon_rober/.vscode/extensions/ms-dotnettools.csharp-1.23.8/.omnisharp/1.37.5/omnisharp/.msbuild/Current/Bin/Roslyn
        BypassFrameworkInstallChecks = true
        MSBuildExtensionsPath = /home/simon_rober/.vscode/extensions/ms-dotnettools.csharp-1.23.8/.omnisharp/1.37.5/omnisharp/.msbuild

    Detecting Cake files in '/home/simon_rober/CS02 - Introduction to Unity'.

    Could not find any Cake files

    Detecting projects in '/home/simon_rober/CS02 - Introduction to Unity/CS02 - Introduction to Unity.sln'.

    Queue project update for '/home/simon_rober/CS02 - Introduction to Unity/Assembly-CSharp.csproj'

    Detecting CSX files in '/home/simon_rober/CS02 - Introduction to Unity'.

    Could not find any CSX files

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpFormattingWorkspaceOptionsProvider, Order: 0

    Loading project: /home/simon_rober/CS02 - Introduction to Unity/Assembly-CSharp.csproj

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.Completion.CompletionOptionsProvider, Order: 0

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.RenameWorkspaceOptionsProvider, Order: 100

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.ImplementTypeWorkspaceOptionsProvider, Order: 110

    Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.BlockStructureWorkspaceOptionsProvider, Order: 140

    Configuration finished.

    Omnisharp server running using Stdio at location '/home/simon_rober/CS02 - Introduction to Unity' on host 38583.

    The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

    Failed to load project file '/home/simon_rober/CS02 - Introduction to Unity/Assembly-CSharp.csproj'.

/home/simon_rober/CS02 - Introduction to Unity/Assembly-CSharp.csproj
/home/simon_rober/.vscode/extensions/ms-dotnettools.csharp-1.23.8/.omnisharp/1.37.5/omnisharp/.msbuild/Current/Bin/Microsoft.Common.CurrentVersion.targets(1180,5): Error: The reference assemblies for .NETFramework,Version=v4.7.1 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks
    Attempted to update project that is not loaded: /home/simon_rober/CS02 - Introduction to Unity/Assembly-CSharp.csproj

Steps to reproduce
I desire to use unity and want to edit the C# files with VS Code on Ubuntu 20.04, hence I took a look at this tutorial:
https://code.visualstudio.com/docs/other/unity
I installed .Net:
dotnet --info:
".NET SDK (reflecting any global.json):
Version:   5.0.102
Commit:    71365b4d42
Runtime Environment:
OS Name:     ubuntu
OS Version:  20.04
OS Platform: Linux
RID:         ubuntu.20.04-x64
Base Path:   /usr/share/dotnet/sdk/5.0.102/
Host (useful for support):
Version: 5.0.2
Commit:  cb5f173b96
.NET SDKs installed:
5.0.102 [/usr/share/dotnet/sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 5.0.2 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 5.0.2 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
To install additional .NET runtimes or SDKs:
https://aka.ms/dotnet-download"
Further I installed the C# extension to VS Code and managed to succesfully alter the External Script Editor to VS Code.
By double clicking on the script in Unity, VS Code automatically openend with the script and the extra files as expected.
Expected  behavior
intellisense should work and the extension should not fail.
Actual behavior
When I started to program I noticed that Intellisence for Unity does not work. There also appeared a the above error output.
Already tried:
I already tried to change "    v4.7.1" to "    v5.0.2" in the Assembly-CSharp.csproj file. This did not alter the behavior.

I am also a unity User and the solution is pretty simple. Omnisharp is asking you to download the .net Framework Developers pack so that You can develop apps in C#.
Here is the link to download it.

I am also a unity User and the solution is pretty simple. Omnisharp is asking you to download the .net Framework Developers pack so that You can develop apps in C#.
Here is the link to download it.

Thanks for responding!
I tried to install one of these before, but since it is only available in .exe file for windows, I don't know how to proceed. Is there a version for Linux or should start tampering around with wine?

Thanks for responding!
I tried to install one of these before, but since it is only available in .exe file for windows, I don't know how to proceed. Is there a version for Linux or should start tampering around with wine?

@simonrober For Linux you will want to install the stable Mono and set "omnisharp.useGlobalMono" to "always". https://www.mono-project.com/download/stable/#download-lin

@simonrober For Linux you will want to install the stable Mono and set "omnisharp.useGlobalMono" to "always". https://www.mono-project.com/download/stable/#download-lin

@JoeRobich It seems to have done the job. Many thank!!!

@JoeRobich It seems to have done the job. Many thank!!!

Hi does anyone know how to install it for Mac? Same issue with the link being .exe. I installed the latest .NET Mac package but not sure how to check version (4.8.0 I believe) but changing Unity .csproj to that and it still can't be found :/

With Unity 2020.3 on Ubuntu 18.04 I also had to select in Unity: Edit/Preferences/External Tools Generate csproj files for Embedded Packages, Local Packages and Registry packages. Without the last one I got similar message to this:
Could not find method '.ctor' due to a type load error: Could not set up parent class, due to: Could not set up parent class, due to:  assembly:Unity/Hub/Editor/2020.3.2f1/Editor/Data/NetStandard/ref/2.0.0/netstandard.dll

Thank you so much @Amogh-Mittal

Thx @DominicTobias and @JoeRobich - Couldn't get intellisense to work on my Mac using vscode despite having installed Mono. I now set it up to always use global mono and that fixed my issue.

For lost travelllers you need to set "omnisharp.useGlobalMono": "always" in VSCode settings otherwise it doesn't work in Mac... seems like kind of an important thing but it's tucked away in a Changelog.
And for Mac users you need to correct the version in .csproj, at the time of writing change it to 4.8 instead of 4.7.1.

on top of that, I was seeing 2 versions of omnisharp in ~/.vscode/extensions/ms-dotnettools.csharp-1.23.13
VSCode was downloading the latest one but failing to update the omnisharp.path entry in ~/Library/Application Support/Code/User/settings.json to point to the latest version

I am also a unity User and the solution is pretty simple. Omnisharp is asking you to download the .net Framework Developers pack so that You can develop apps in C#.
Here is the link to download it.
Hope this helps.😀

the link has discarded.

You can find the .NET Framework 4.7.1 developer pack at https://dotnet.microsoft.com/download/dotnet-framework/net471

For lost travelllers you need to set "omnisharp.useGlobalMono": "always" in VSCode settings otherwise it doesn't work in Mac... seems like kind of an important thing but it's tucked away in a Changelog.
And for Mac users you need to correct the version in .csproj, at the time of writing change it to 4.8 instead of 4.7.1.

OMG Thank GOD!!!!!!  I was like what the hack am I doing wrong but thanks to you I only had to change it to always... WAS IT THAT SIMPLE??? I wanna cry thanks a lot.

I am on Linux. What I did to solve the issue was:

Uninstalled VS Code C# extension
Updated mono and mono-msbuild
Reinstalled C# extension
Set omnisharp.useModernNet to false in VS Code Settings
Restart VS Code

@JoeRobich to be more specific that is link for .NET Framework 4.7.1 developer pack

You can find the .NET Framework 4.7.1 developer pack at https://dotnet.microsoft.com/download/dotnet-framework/net471

Sheesh, i've installed everything besides this one, after installing this, everything works.
(Windows 11)
Thanks.

I am on Linux. What I did to solve the issue was:
1. Uninstalled VS Code C# extension

2. Updated mono and mono-msbuild

3. Reinstalled C# extension

4. Set `omnisharp.useModernNet` to `false` in VS Code Settings

5. Restart VS Code

Thank you very much! I tried to set up VSCode for Unity under Ubuntu 22, your instructions helped me.
In the second paragraph, I performed a reinstallation of mono and mono-msbuild as stated here - https://gist.github.com/petergloor/39ba915d3a66d138448ed57be6fe93ca


[Create Event] Datepicker is not highlighted in red when focus is moved off from calendar

Environment: macOS Monterey 12.6, Safari 16.0.
Reproducible: always.
Build found: 15/09/2022
Steps to reproduce

Go to https://www.testgreencity.ga/
Log in
Click on the "Events" tab
Click "Create" button
Choose event duration in the "Duration" dropdown (e.g. 1 day)
Click on the date picker so that the calendar with dates is displayed
Take off focus from the calendar

Actual result
Datepicker is not highlighted in red.

Expected result
Datepicker is highlighted in red.

User story and test case links
User story https://github.com/ita-social-projects/GreenCity/issues/3193
Test case https://jira.softserve.academy/browse/GC-3155)
Labels to be added
"Bug", Pri: Medium, Sev: Minor, UI, Events

not reproduce


Range Facets

┆Issue is synchronized with this JIRA Epic
┆Project Name: Boardwalk-UI
┆Issue Number: BOARD-13

➤ Cricket Sloan commented:
This needs backend support


Song name is disappearing sometimes

The music is playing and module is working properly, but sometimes song name is disappears and "No music is playing" caption appears. After ~5 sec all is back to normal. (I am using scripts from your dotfiles)
I am using spotify-tui and spotifyd as a daemon

So, I think is the problem of spotifyd or spotify-tui.

Thanks for the heads up. The player defined in the scripts is playerctld which tries to find the currently active music player. Try changing it to spotify and see if the issue comes up. If not, it might just be a problem of spotifyd or spotify-tui as you said.

If someone would have the same issue use this instructions.

Compile spotifyd from source (master branch is ok), as the latest official build is quite old and doesn't have @SirWindfield's hotfix. Alternatively, you can checkout v0.2.24 and patch it yourself

When you build/install, make sure that you set at least the --features dbus_mpris flag, along with anything else you need

If you have a config file, make sure it's in the new TOML format to avoid problems, as the binary doesn't have that yet either

Go to https://developer.spotify.com/dashboard/login, create an app (call it whatever), and copy the client ID

When you run spotifyd, set the SPOTIFYD_CLIENT_ID environment variable to that client ID, e.g. with the default one
SPOTIFYD_CLIENT_ID=2c1ea588dfbc4a989e2426f8385297c3 spotifyd --no-daemon

If you use systemd, you can add the environment variable to the [Service] section of your spotifyd.service, like below
spotifyd.service file with token:

[Unit]
Description=A spotify playing daemon
Documentation=https://github.com/Spotifyd/spotifyd
Wants=sound.target
After=sound.target
Wants=network-online.target
After=network-online.target

[Service]
ExecStart=/usr/bin/spotifyd --no-daemon
Restart=always
RestartSec=12
Environment=SPOTIFYD_CLIENT_ID= your id

[Install]
WantedBy=default.target


support for chinese

support for Chinese done.

Still several problem:

How can change the React's URL?
I want provide a link to chrome's 'shortcuts setting', the URL like
 shortcuts,
firstly, I thought that maybe there something wrong with the link, So I try this method in another plugin, actually, It works!
eventually, I got the reason in console:

It doesn't go to chrome://extensions/configureCommands while 'chrome-extension://opkcbcpnbcklghlhhokbdblmjhagkkpi/options.html#/keyboard-shortcuts', I think there must be something worry with React? How to fix it?

about i18n.
Is Chrome's i18n run once? during using plugin, user can not change language instead of re-install it, isn't it?
An interesting thing is that Chrome can recognize the system language and choose which language message.json to use.  So what's the point of define "default_locale": "en" in manifest.json file.
A practical problem is that my system language is 'zh_CN', even I set "default_locale": "en", the result is that Form filler still display in Chinese unless delete the 'en/message.json'

For Point 1, I couldn't get chrome's links to work and apparently it is not possible. See http://stackoverflow.com/q/13125616/143466.
All of the questions you raised in Point 2 are answered here: https://developer.chrome.com/extensions/i18n. The default_locale is used when the user's locale is either not supported or does not have the message defined.
I will merge this and test. If everything is okay, I will publish to the store.

About point 1, that's the very reason from stackoverflow's answer. And do you plan to fix or improve it?  I think it's much better go to a link than provide a link for user.
As for i18n, I have realize it after read it's API. Maybe I have put the question to complex, how can I want it do everything. For more function, we should realize it in other way. After complete this work about 'i18n' in my own way and chrome's API, I learn a lot, understand well about multi-language support.
And thank you very much, for you kindness, the patience to answer my questions.


Refactor http server; support content-disposition

Refactored the server into many smaller functions to make it easier to
understand all the different code paths.

added a Content-Disposition header, which tells the browser the
file's name, since we use urls like http://localhost:port/0 <-- no
human-readable file name
Server returns valid HTML documents (with all the required tags) now.
Return 204 status for OPTIONS request
reduce access-control-max-age to chromium max of 600s
respond to OPTIONS requests that lack
'access-control-request-headers' (before they were treated as GET)
return '405 invalid verb' for all other verbs

For: https://github.com/brave/browser-laptop/issues/6737

Post-merge review welcome 🖐 Merging and releasing because I need this to fix a bug in Brave.

0.98.6

Thanks @DiegoRBaquero!


Show upload messages

This hides the upload bar only when it's in its default state and shows it during the upload and on various errors.
Before

After

Awesome that you caught this case! It's otherwise quite a bummer when you encounter it and we are actually breaking useful GitHub messaging.

Yeah I was only dejquerifying upload-button and found both this and #770 😅


Custom MUI Tab component throws error

Duplicates

[X] I have searched the existing issues

Latest version

[X] I have tested the latest version

Steps to reproduce 🕹
No response
Current behavior 😯
Throws error while using custom component-
MUI: The component prop provided to ButtonBase is invalid.
Please make sure the children prop is rendered in this custom component.
https://codesandbox.io/s/blissful-jackson-7e5hxg?file=/src/App.js:0-1270
Expected behavior 🤔
No response
Context 🔦
I want to have horizontal scroll similar to Tabs component. So I am using the Tab with component prop. Facing the mentioned issue because of that.

  Output from `npx @mui/envinfo` goes here.

Here is a fixed sandbox: https://codesandbox.io/s/sharp-varahamihira-5hzkkg You need to add a label on the Tab element. That way it would be propagated to the CustomComponent, and you can use the children prop there directly. I hope this helps.

Here is a fixed sandbox: https://codesandbox.io/s/sharp-varahamihira-5hzkkg You need to add a label on the Tab element. That way it would be propagated to the CustomComponent, and you can use the children prop there directly. I hope this helps.

Worked!!!


Add unit testing for package operation

Add unit testing for internal/stackql/acid/operation.
Acceptance Criteria:

85% unit test coverage.

Can you please assign this one to me?

done @Crossbears


fix:delete unused files

Description
I used knip to identify unused files. There will be a few more related PRs, after that I will add CI check for this.
Fixes #35778
Related EE PR https://github.com/appsmithorg/appsmith-ee/pull/4925
Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!TIP]
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10487871418
Commit: 3c73b47f431338a09fb377cd09a9c664663f7624
Cypress dashboard.
Tags: @tag.All
Spec:
Wed, 21 Aug 2024 11:30:42 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[x] No

Summary by CodeRabbit

New Features

Introduced configuration for the Knip tool to manage and enforce component architecture.
Added a new dependency (knip) to enhance code quality checks.

Improvements

Refined project structure for better analysis of TypeScript files and focused architectural compliance.
Established a streamlined approach to exclude non-relevant files during architectural analysis.

I close this PR, because I'll be on vacation next two weeks. I'll come back and make a new one.


Is this branch still working now?

When I entered http://lcoalhost:9200/_xpack/, It returns below. Something wrong with my configuration.  Besides, Once I tried to change the password , it said "No handler found"
What's wrong?
features: {
graph: {
description: "Graph Data Exploration for the Elastic Stack",
available: true,
enabled: false
},
monitoring: {
description: "Monitoring for the Elastic Stack",
available: true,
enabled: false
},
security: {
description: "Security for the Elastic Stack",
available: true,
enabled: false
},
watcher: {
description: "Alerting, Notification and Automation for the Elastic Stack",
available: true,
enabled: false
}
},
tagline: "You know, for X"
}

curl -XPUT 'localhost:9200/_xpack/security/user/elastic/_password?pretty' -H 'Content-Type: application/json' -d'
{
  "password": "elasticpassword"
}
'
No handler found for uri [/_xpack/security/user/elastic/_password?pretty] and method [PUT]

available: true,
enabled: false

means that the plugin is installed, but not enabled.
You must checkout the x-pack branch in order to use X-Pack features.

Thanks for your reply. I've checked the x-pack branch, but nothing got about how to enable xpack. I thought it enabled xpack by default.

I don't think you did, check the output of the git branch command in your local repo.
Use git checkout x-pack to checkout the branch.
If you were on the x-pack branch, the command  curl -s http://localhost:9200/_xpack/ would return a 401 error.
# without basic auth
❯ curl -s -D - http://localhost:9200/_xpack/ -o /dev/null

HTTP/1.1 401 Unauthorized
WWW-Authenticate: Basic realm="security" charset="UTF-8"
content-type: application/json; charset=UTF-8
content-length: 383

# with basic auth
❯ curl -s -D - http://localhost:9200/_xpack/ -o /dev/null -u elastic
Enter host password for user 'elastic': changeme

HTTP/1.1 200 OK
content-type: application/json; charset=UTF-8
content-length: 820

Assuming the solution was accepted. Feel free to reopen if necessary!


Stabilize auto-generated files such as ctypes.depend and .def files

As the name of the PR says. Note that this is not an alphabetical sort; rather, files are sorted according to their C filename (i.e., after bundling), and then declarations within each file are sorted alphabetically. But in any case, this should stabilize the output and avoid un-necessary diffs when refreshing HACL.

See https://github.com/hacl-star/hacl-star/pull/611 for motivation

Thanks Aymeric!


Class name can be beautified when generic class in Console logger

When the Console logger is hooked into the application, the logs are of the format [classname] [log level] and so on. The class is the fully qualified class name and looks good for normal class. When the class is a generic type, it prints it with a tilde and the closed type T is printed with full assembly information. This makes it hard to read on the console and does not look good. It would be good if that can be cleaned up
Example

In the above image, if you look at the SigninManager, the closed type T which is the ApplicationUser is displayed along with assembly information which is not needed

I think I pointed @NTaylorMullen a while ago to some ancient code I write that prints beautified generic type names. Taylor, do you have that around somewhere?

Forwarded :smile:

Thanks :)

Looks like this is already fixed?

@muratg

sure it was fixed by this https://github.com/aspnet/Logging/pull/105
This can be closed

Yup.


Added XBP token

https://www.blitzpredict.io

Please provide additional details per the latest submission guidelines, and re-submit when ready.

[ ] The icon should be small, square, but high resolution, ideally a vector/svg.
[ ] PR should include link to official project website referencing the suggested address.
[ ] Obtain a 'NEUTRAL' reputation or 'OK' reputation on Etherscan.


ShowMessageAsync throws when cancelled

Description
I am unable to cancel a dialog created using DialogCoordinator.Instance.ShowMessageAsync() without getting an exception with the message "The calling thread cannot access this object because a different thread owns it." I've tried with and without using Dispatcher.Invoke.
What steps will reproduce this issue?

Create an instance of MetroDialogSettings with CancellationToken assigned
Call ShowMessageAsync using the DialogCoordinator and passing in the dialog settings
Cancel the token
Exception is thrown

Expected outcome
Dialog should be closed without crashing the application and possibly throw OperationCanceledException on the invoking call stack (I don't really care whether the exception is thrown or not).
Repo
https://github.com/Retik/ShowMessageBugExample
Environment

MahApps.Metro: v1.6.1
Windows OS: Windows 10 Enterprise v1709
Visual Studio: 2017 Enterprise v15.6.4
.NET Framework: v4.6.1

I have the exact same issue, it is still present in the latest 2.x prerelease build
It would be great if it could be fixed, very handy for easily closing a dialog on a timeout or when it's no longer relevant due to a task cancellation


GH-2479 repo config documentation

GitHub issue resolved: #2479
Briefly describe the changes proposed in this PR:

added a new reference document on the syntax for configuration files of repositories and sails
added autonumbering for sections for easier reference
some general cleanup and updates around the site while I was at it.

I deliberately left out the LuceneSail for now, because I was having trouble actually figuring out which parameters are supported and what the syntax should be. Worth a followup I guess - there's some archeology involved...

PR Author Checklist (see the contributor guidelines for more details):

[ ] my pull request is self-contained
[ ] I've added tests for the changes I made
[ ] I've applied code formatting (you can use mvn process-resources to format from the command line)
[ ] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change
[ ] every commit has been signed off

Note: we merge all feature pull requests using squash and merge. See RDF4J git merge strategy for more details.

Thanks for typing up this @jeenbroekstra . It's going to be great for our users. I've commented on a few minor things.


[KARAF-6660] Update to commons-lang 3.10

Changes:
https://commons.apache.org/proper/commons-lang/changes-report.html#a3.10
Signed-off-by: Stephen Kitt<EMAIL_ADDRESS>

retest this please


Retry middleware should let you configure HTTP verbs

Why
I have a scenario where I would want to retry a POST request and since we are already using the retry middleware for GET requests, I think it would make sense to re-use it for POST requests too.
What
Add a httpVerbs list to the config and switch the enableRetry to check that list. It should default to GET in order to be backward compatible.

See #218 and #234 for previous discussions on this.

The solution Edvin went for in the end was to create a local retry middleware function generator that checks for presence of a configurable headerIdempotencyId  in headers, but which can be configured to allow retrying non-idempotent requests without such header by passing in an option dangerouslySkipIdempotencyCheck which defaults to false.


Is this project abandoned?

Describe the bug
Currently, this is the only GUI to Kong Admin API
No new releases for more than a year.

Expected behaviour
It will be good to get some updates and fixes from time to time.

I heard that a new rewrite is in works, but that was two years ago and no news so far, so I assume that it is


Fixing squid:S2095, squid:S2674

This pull request is focused on resolving occurrences of Sonar rules:
squid:S2095 - "Resources should be closed".
You can find more information about the issue here:
https://sonarqube.com/coding_rules#q=squid:S2095
squid:S2674 - "The value returned from a stream read should be checked".
You can find more information about the issue here:
https://sonarqube.com/coding_rules#q=squid:S2674
Please let me know if you have any questions.
Artyom Melnikov

Thanks Artyom


Add prefix for Firefox selection to Twilight theme

The two pre[class*="language-"]::selection  are basically the same rules
Firefox rule should have a prefix and be moved before the unprefixed rule

Thanks!


Vectors do no support full equality

For any vector v, v is equal to itself.
This is then full equality and the vector needs to implement the trait Eq.
Right now vectors only implement PartialEq
Apart from logical reason to do this, some traits require Eq (for example the trait Ord).

Yes I agree that this would be a valuable addition.
Do you think it will also be worth deriving other related cmp traits? e.g. Ord, PartialOrd? It seems these are also implemented for Vec.

🤔 I do not really know how a vector would be compared to another one, what do you think?
How is it done for the native Vec?

I believe that native Vec implements the ordering by doing pairwise comparison. Described by the example here under Rn.
I'm not sure whether we should derive this additional behaviour on Vector for now. It may be better to allow the user to decide how to do that kind of comparison.

Yes I think it is probably better to give them the choice on that one


Streamz with websocket not steaming any data

I am trying to figure out a right way of streaming data using streamz with websocket. My streaming data is loaded using websocket but not streaming anything.
import config
import websocket, json
import pandas as pd
from streamz.dataframe import DataFrame
from streamz import Stream
import time

ticker_list = ["SCHG"]

# Create DataFrame with specified columns and ticker_list as index
df = pd.DataFrame(columns=['Bid', 'Ask', 'Time'], index=ticker_list)

source = Stream()

def update_dataframe(json_message, df):
    ticker_data = json_message[0]
    ticker_symbol = ticker_data['S']
    df.loc[ticker_symbol, 'Bid'] = ticker_data['bp']
    df.loc[ticker_symbol, 'Ask'] = ticker_data['ap']
    df.loc[ticker_symbol, 'Time'] = pd.to_datetime(ticker_data['t'], unit='s').tz_localize('UTC').tz_convert('America/New_York').strftime('%Y-%m-%d %H:%M:%S%z')

    source.emit(df.copy())  # Emit the updated DataFrame to the stream

def on_open(ws):
    print("opened connection")
    # Authentication
    auth_data = {"action":"auth","key": config.API_KEY,"secret": config.SECRET_KEY}

    # Subscribe
    ws.send(json.dumps(auth_data))

    listen_message = {"action":"subscribe","quotes":ticker_list}
    ws.send(json.dumps(listen_message))
    print('subscribed')

def on_message(ws, message):
    json_message = json.loads(message)

    # Update the DataFrame and emit it to the stream
    update_dataframe(json_message, df)

def on_close(ws):
    print("closed connection")

def print_result(x):
    print(x)

sink = source.map(print_result)  # Set up a sink to consume and process the emitted data

socket = "wss://stream.data.alpaca.markets/v2/iex"
ws = websocket.WebSocketApp(socket, on_open=on_open, on_message=on_message, on_close=on_close)
ws.run_forever()

Are you saying that the on_open, on_message and on_close functions do run, but print_result does not?
You might also be interested in Stream.from_websocket which listens for incoming connections. A streamz native (async) client version would look very similar.

That is correct, I am not getting any data results window with streamz. Perhaps I am missing something on the way I use steamz code.....
When I am not using streamz that is using normal python print code it works good.

I am afraid I don't know. You are not using any async streamz stuff here, so the simplified code is essentially
source = Stream()
sink = source.map(print_result)
source.emit(df) # repeated for different df

which does indeed print.

Does Streamz work on Visual Studio Code.. or just in Jupiter Notebooks?

The auto-updating visual output is a jupyter-widget thing I don't know if VSCode shows those properly or not. streamz plotting via hvplot can work in a variety of browser platforms, including a standalone webapp; but, again, I don't know what VSCode does.
However, streamz's internals will continue to work anywhere, including a simple terminal, so if output is to a file, printed, or some other side-effect, those will work anyway.


Object detector model turicreate.object_detector.create doesn't allow periodical saving of models before the training is over.

I have been using turicreate's object detector model for a while now and what I have noticed is that it doesn't let me save models after every n iteration while the training is going on.
I believe this is a very important feature to have as sometimes for a lot of reasons (hardware or software or other unpredicted reasons) the training gets killed and when it exits I don't even have a model which one might have spend hours training.
I believe this part of the code is written in C++ and I am not that great with c++ but If pointed in the right direction I can pick this up and add this feature or if someone more experienced can pick it up that will be great too.

This is the same feature request as #574.
@NeerajKomuravalli - Here is the main training loop for object detection. Since we already have an open issue for this feature request, I'm going to close this issue. However feel free to ask any additional questions here.


False error message (@import rule)

If the project located is not on the system drive, I get this error:

although the compilation goes well:
scss

css

I use windows 8.1, brackets-sass 1.0.2-77 and bourbon-example.

@mikriot can you still reproduce this?

@jasonsanjose I'm still getting this error :(

@mikriot did you try updating to the latest version 1.0.3?

You could also try syncing to the latest https://github.com/jasonsanjose/bourbon-example. I updated it to include a local partial file for importing.

@mikriot nevermind. I found an issue where the node-sass binary wasn't updated on mac...are you on a mac? Anyway, please try the latest version 1.0.4-83 available in the extension registry and let me know how that works.

are you on a mac?

No. I use windows.

try the latest version 1.0.4-83 available in the extension registry and let me know how that works

I updated brackets-sass and downloaded latest version bourbon-example, but the error persists.

I have the same problem on Windows7, latest editor and brackets-sass version.
I accidentally open my css source map and there I found that the generated path is wrong - it search first in C:/, but my project is in D:/. The file looks sth liek this:
{
"version": 3,
"file": "01_style.css",
"sources": [
"01_style.scss",
"C:/D:/imports/_reset.scss",
]
...
}
If I move my project in C:/, all works like a charm :).

Thanks for hte updates @mikriot and @gbggit. I'll investigate more.

@gbggit your issue regarding I found that the generated path is wrong - it search first in C:/, but my project is in D:/ is separate from the original one reported. Please see https://github.com/jasonsanjose/brackets-sass/issues/89 instead.
@mikriot I have a test build here https://github.com/jasonsanjose/brackets-sass/releases/tag/2.0.1-105 that fixes several windows-related issues. Can you give it a try and let me know if it works. Thanks!

Fix in #100. Closing.


Fabric canvas  background colors change is not working as expected.

If I add color Red, Black, Blue.
then when calling .undo()  background is not going  Blue, Black, red.
it is going Blue to White.   This is not expected while Undo.

HI,  I'm also experiencing this issue with my project.
I have a series on controls where i edit an object i.e. change the color to red. when i peform .undo() the object is removed or oved to its previous position.
I have tried implementing your on/off history functions around my object modification functions but im not sure if this is correct.
use case: create an object and then use an object.set('fill', 'red') fabricjs function to set the objects new color and then peform an undo() to return to the previous color.
expected outcome: color changes to previous color
actual outcome: removes the object from canvas

Hiya just a little update. I think my first explanation may be slightly wrong.
If i make more than 1 update to the object i.e. set the color from its original black to red to blue to green. the undo function works up to the color red and then will not revert back to the original color of black instead it removes the object as though that bit of its history didnt exist.
This is the same for any changes fill, fontstyles etc.

Hi everyone,
I just find a time to solve the issues. The fabricJS do not have an object:updated event. Therefore, after the changing a fill, font style, font weight, etc. You have to trigger an event manually.
For example,
        function test() {
            const activeObjects = canvas.getActiveObjects();

            // remove objects
            if (activeObjects.length > 0) {
                for (var i = 0; i < activeObjects.length; i++) {
                    activeObjects[i].set('fill', 'purple')
                }
            }

            canvas.renderAll();
            canvas.trigger('object:modified');
        }

The event will save the state.
On the contrast, we can override the set method on fabric object and trigger that event but I wouldn't do that to a such a common function.
Thanks.


bicepファイル ＆ パワポ更新

Purpose

...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

#2 で対応済みのためいったんクローズいたします～～🎂🎂


File Storage wont upload a file

Files are not being uploaded correctly

Fixed and created PR.

Fixed while reworking the file explorer.


Please invite me to the Organization

Please invite me to the GitHub Community Organisation.

Name:

Discord Username(if exists):

Additional Context:

:nerd_face:

Welcome @Mannan2812 🤓


"Cannot find .abapgit.xml" error for new online repo

I think https://github.com/larshp/abapGit/pull/3512 is too restrictive... For example, our documented process produces an error:
https://docs.abapgit.org/guide-first-project.html

Create a new repo in Github
Do +Online in abapGit

Maybe raise the error only if a certain number of files exist?

yeah, makes sense. Feel free to fix. I don't have time currently.


Configuration distributor's kv store with Loki enabled

Hi, I'd like to configurare the operator with Loki enabled and store the rings in an external etcd. Does the operator support this operation? Thanks.

The Logging Operator does not install Loki at the moment. If you are using One Eye contact the support at https://banzaicloud.com/support/


More metrics for gossipsub

Is your feature request related to a problem? Please describe.
We'd like to add more metrics to gossipsub:

Number of seen messages
Number of IWANT messages delivered
Number of broken IWANT message promises
Number of direct peers
_handleGraft() result: total number of call, total number of each rejected reason

@dapplion @wemeetagain please modify/add more if any

New gossipsub has all metrics that we want, closing the issue


http-based upload function should have a progress bar and show upload speed

Is your feature request related to a problem? Please describe.
When uploading big model files, it'd be good to have feedback and UI elements to show the progress and the upload speed. This is implemented in LFS-based upload function but not in http-based upload functions.
Describe the solution you'd like
Plenty of solutions (such as this one) on the web that uses tqdm to track the progress of requests.put (i think that's what is used under the hood?).

Hi @sijunhe , thanks for posting. I looked a bit at the feature request and it's not that easy to implement the progress bars. What is possible to do is to have a progress bar when uploading a lot of LFS files (examples: thousands of images in a dataset). Bar shows progress for each uploaded file.
However in a lot of cases you would like to see the individual progress of a single file (let's say a 10GB model weights for example). In this case, requests does not provide a convenient way to monitor it. When uploading a very huge file (>5GB) the upload is done in multiple parts. But 5GB per chunk is already a lot (a 10GB file would display a bar with 2 steps...).

EDIT: there seem to be a possibility to monitor huge uploads with requests: https://stackoverflow.com/a/13911048. Would you like to check if it works and maybe try to implement it in huggingface_hub. I can really help with the integration once it's confirmed that it works (and that it's indeed the feature you were thinking about). For integration, everything is under _commit_api.py and lfs.py.

maybe related to class SliceFileObj?


Why is intersectBed -sorted slower than unsorted?

I have a big chip-seq.bedGraph file (7,617,673 rows) and a small windows.bed file (413 rows), both sorted, and based on reading the manual I thought that the fastest method would be
$ time intersectBed -a windows.bed -b chip-seq.bedGraph -sorted > overlap-sorted.bedGraph
real	154m10.653s
user	153m2.188s
sys	0m20.204s

but actually it is much faster without -sorted. Why is that? (the results of the two are the same)
$ time intersectBed -a windows.bed -b chip-seq.bedGraph > overlap.bedGraph
real	0m8.733s
user	0m7.932s
sys	0m0.728s

If this is a bug, can you please fix it?
If it is a feature, can you please document it?
data files can be downloaded here
http://cbio.ensmp.fr/~thocking/data/overlap-benchmark.tgz

by the way this is with Version: 2.14.3-1

With version 2.21.1, -sorted is more than twice as fast as without. There have been many, many improvements to that algorithm over the last two years. I suggest an upgrade!
➜ bedtools --version
bedtools v2.22.1
➜  time bedtools intersect -a windows.bed -b chip-seq.bedGraph -wa -wb > /dev/null
10.79s user 0.99s system 99% cpu 11.783 total
➜  time bedtools intersect -a windows.bed -b chip-seq.bedGraph -wa -wb -sorted > /dev/null
3.45s user 0.05s system 99% cpu 3.507 total


Flag to detect process.env changes after tests

To detect problems like this: https://github.com/mochajs/mocha/issues/2711#issuecomment-284220006 Could we do something like the global leak detection, only for process.env's properties and concerned with changes in general rather than with additions?

@ScottFreeCode Since there's already an option called --check-leaks, it could be extended to take in an optional argument to check for process.env leaks as well. For instance,
mocha ... --check-leaks env,global

The default value here would be to check for global variable leaks only.

Some sort of argument to --check-leaks/checkLeaks instead of a new flag/method for anything else we want to add is an interesting idea... I wonder if there'd be any benefit to allowing this to be less like a list of options and more like a list of global variables to check for added properties, defaulting to the global variable that represents the object that contains global variables (global in Node, window in browser assuming no web workers where it would be self). For instance, if you have a test in the browser that involves creating elements with IDs that should clean up the created elements afterward, then knowing that the browser sets document.<id> to refer to the element with that id, you could mocha.checkLeaks(["window", "document"]); to get the process.env behavior on the CLI, you'd do --check-leaks process.env,global instead of --check-leaks env,global. That might be overkill for a very few use cases, however...


works not as good on linux

I want to decode a QR-Code in python with pyzbar.pyzbar.decode. On Windows it works perfectly fine, but on Linux (Ubuntu) there show nothing. No Error, only an empty array.

do you solve the problem?i meet the same problem

igot same question。

same !

igot same question。

有解决方法么？

same !

Is there a solution?

same problem.
It has to be a very perfect input, like generated barcode png, to have a correct output.
Otherwise, like if the input is a photo include barcode, the output is an emty array

Is there a solution?

same problem.
It has to be a very perfect input, like generated barcode png, to have a correct output.
Otherwise, like if the input is a photo include barcode, the output is an emty array

Is there other solution?


Added Creasol DomBus Plugin

Hi, thanks for your nice plugin.
I've added my plugin Creasol DomBus to your plugins.json file.
Have a nice day.
Paolo

Please inform me if this pull request can be accepted or not. Thanks a lot.
Paolo

Sure, thank you for the contribution!

Thanks to you and your great plugin!


Discovery of OAuth Authorization server should use RFC8414 and /.well-known/oauth-authorization-server

Currently, the Section 3.0 describes that the OAuth Authorization Server Metadata is fetched via /.well-known/openid-configuration, but OID4VCI Draft 12 Section 10.2.3 says that the authorization server should be fetched as defined in RFC8414.
This means the OAuth 2.0 Authorization Server metadata is obtained from the oauth-authorization-server well-known location which should be /.well-known/oauth-authorization-server

I think both are acceptable as specified in the last para of section 3 in RFC 8414.

Some OAuth applications will choose to use the well-known URI suffix "openid-configuration".  As described in Section 5, despite the identifier "/.well-known/openid-configuration", appearing to be OpenID specific, its usage in this specification is actually referring to a general OAuth 2.0 feature that is not specific to OpenID Connect.

This is more a legacy support as stated in section 5.
Going forward, OAuth authorization server metadata locations should use the transformation defined in this specification.
I think we should only allow one option if there is no reason to support multiple ones. Having multiple options just increases implementation efforts and reduces the likeliness of interoperability.

This is more a legacy support as stated in section 5. Going forward, OAuth authorization server metadata locations should use the transformation defined in this specification.
I think we should only allow one option if there is no reason to support multiple ones. Having multiple options just increases implementation efforts and reduces the likeliness of interoperability.

Yes makes sense to avoid ambiguity. @lalc


[Samples] Investigate redundant Check

Is your feature request related to a problem? Please describe.
There exists a typescript test that executes samples in samples.mjs (Code link ) . IMO, it would be good to investigate whether it is relevant in the current scenario after this repo has been enhanced for testing efficiency primarily  in #1533 #1797. As per my understanding we are now checking for lint and sample execution for all samples, so it might be a good idea to get rid of redundancy.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Get rid of redundant test if its no longer required.
Describe alternatives you've considered
Dont remove the test if its needed.
Additional context

Earlier, observation raised in https://github.com/microsoft/qsharp/issues/1709 based on Q# infra at the time of raising the issue.
See this comment

@Manvi-Agrawal Yep, this seems like a redundancy and removing that JS would be practical.

Hi @Manvi-Agrawal @sezna , Can I work on this issue?

@PratikFandade sounds good. This should be fairly straightforward. Let me know if need any help with this.


Bug: Empty models folder after generate

Bug description
generator not generate models
To Reproduce
prisma generate
Expected behavior
Filled models folder
Prisma information
generator client {
    provider = "prisma-client-js"
}

generator PrismaTypeGraphQLTypesGenerator {
    provider     = "npx prisma-typegraphql-types-generator"
    modelsOutput = "./prisma/models"
    enumsOutput  = "./prisma/enums"
    exportedNameSuffix = "GQL"
    exportedNamePrefix = "TYPE"
}

datasource db {
    provider = "mysql"
    url      = env("DATABASE_URL")
}

model User {
    id Int @id @default(autoincrement()) @db.UnsignedInt
    login String @unique
    email String @unique
    password String
    name String

    products product[]
    directories directory[]
}

model product {
    id Int @id @default(autoincrement()) @db.UnsignedInt
    name String
    sku String
    description description?
    price Float @default(0)
    count Int @db.UnsignedInt @default(0)

    // @skip
    userId Int @db.UnsignedInt
    user User @relation(fields:[userId], references:[id])

    directories ProductOnDirectory[]
}

model description {
    id Int @id @default(autoincrement()) @db.UnsignedInt
    content String?

    // @skip
    productId Int @db.UnsignedInt
    product product @relation(fields:[productId], references:[id])
}

model directory {
    id Int @id @default(autoincrement()) @db.UnsignedInt
    name String

    // @skip
    userId Int @db.UnsignedInt
    user User @relation(fields:[userId], references:[id])

    products ProductOnDirectory[]
}

model ProductOnDirectory {
    directoryId Int @db.UnsignedInt
    directory directory @relation(fields:[directoryId], references:[id])

    productId Int @db.UnsignedInt
    product product @relation(fields:[productId], references:[id])

    @@id([productId, directoryId])
}

Environment & setup

OS: MacOs Monterey 12.3
Database: MySQL
Node.js version: 17.5.0

Prisma  Version
prisma                  : 3.11.1
@prisma/client          : 3.11.1
Current platform        : darwin
Query Engine (Node-API) : libquery-engine 1a2506facaf1a4727b7c26850735e88ec779dee9 (at<EMAIL_ADDRESS>Migration Engine        : migration-engine-cli 1a2506facaf1a4727b7c26850735e88ec779dee9 (at node_modules/@prisma/engines/migration-engine-darwin)
Introspection Engine    : introspection-core 1a2506facaf1a4727b7c26850735e88ec779dee9 (at node_modules/@prisma/engines/introspection-engine-darwin)
Format Binary           : prisma-fmt 1a2506facaf1a4727b7c26850735e88ec779dee9 (at node_modules/@prisma/engines/prisma-fmt-darwin)
Default Engines Hash    : 1a2506facaf1a4727b7c26850735e88ec779dee9
Studio                  : 0.458.0

I'm not able to reproduce it with the same versions on windows.
Can you please provide more information about what happened?

Did it hang on prisma:info Prisma Typegraphql Types Generator:Registered message and didn't generate the desired folders/files?
Did it throw any kind of errors? a snapshot of the terminal output when running prisma generate would be helpful too.

Can you also include a tree structure of your project directory using tree on macOS, so that I can memic your setup to reproduce the bug and hopefully solve it.

@YassinEldeeb Thanks for answer.
No any errors.
dez@Denis-Macbook project % prisma generate
Environment variables loaded from .env
Prisma schema loaded from prisma/schema.prisma
prisma:info Prisma Typegraphql Types Generator:Registered
prisma:info Prisma Typegraphql Types Generator:Generated Successfully!

✔ Generated Prisma Client (3.11.1 | library) to ./node_modules/@prisma/client in 151ms

✔ Generated Prisma Typegraphql Types Generator to ./src/generated/models in 27ms

You can now start using Prisma Client in your code. Reference: https://pris.ly/d/client
import { PrismaClient } from '@prisma/client'
const prisma = new PrismaClient()

Here is my tree

Tested it on a macOS machine via GitHub actions and finally, I was able to reproduce the problem.
The problem is only reproducible on macOS so bare with me cause I'm gonna have hard times debugging it on GitHub actions :)

Fixed! Now works perfectly on MacOS.


Misidentification of USPS tracking number

I have noticed that the latest version (1.3.0) is misidentifying some USPS tracking numbers.  The number<PHONE_NUMBER>61290283641500004181 is a USPS tracking number (not SmartPost) yet the library is identifying it as FedEx.  I had to rollback to version 1.0.7 to get these tracking numbers to be identified correctly.  I tried to look at the changes made since 1.0.7 that might have caused this, but could not pin it down.  Any direction you can provide is greatly appreciated.

Sorry about that and thanks for the bug report. Lots of additions to tracking-number-data since 1.0.7 (the submodule that controls all the detection definitions), including some looser definitions for number detections—specifically adding some couriers that don't have a check digit which has caused some false positives as described in #71
https://github.com/jkeen/tracking_number_data/compare/332cd0105613b6191cfe3694f676136d9a46bc95...main
The issue you're experiencing is slightly different, and is probably caused by this PR and this one which modified Fedex Smartpost detection to include numbers like you described.
The trouble with these numbers is that USPS and FedEx do some sharing of responsibilities sometimes, where FedEx Smartpost packages get delivered by USPS, so they both use the name number format. There isn't a way I currently know of to detect by number alone who is truly the carrier and if you do… do tell!
The documentation doesn't list this method, but if you use TrackingNumber.detect_all("420773169261290283641500004181"), it will return both a SmartPost number and a USPS number. TrackingNumber.new and TrackingNumber.detect I think just grab the first match currently, which is silly.
Could you tell me a little more about what you're doing when you get the result? You're getting the carrier to query the tracking info? I'd love to figure out a good solution here to this issue, and I'm not sure if just returning both possibilities helps you?

@jameswilliamiii  This actually looks like it's more related to this issue that's been open for here: https://github.com/jkeen/tracking_number_data/issues/12
I've done some more research on this and Fedex SmartPost packages (now called Fedex Ground Economy) are always delivered by USPS. I'm working on a way to link these two tracking number types—could you give me a bit more info about your particular use case? Do you need to know it's USPS because you're needing to get the tracking_url?  Like, if the tracking_url method off of that fedex smartpost tracking number returned both tracking urls, or just the USPS url, would that solve your issue?
Another possibility is for numbers like this I could return a different class that would make it clear it's a shared delivery. Something like TrackingNumber::Multiple which would have both the Fedex Info and the USPS info inside. Getting some more info in what you're actually doing with the result would help a lot in figuring out the best solution.

@jameswilliamiii pssst

@jkeen sorry for taking so long to get back to you.  The tracking number is one generated by directly creating a label with USPS via their API.  Here is an example of one that I just created.  It is not created via FedEx at all, but created using USPS's API.

@jkeen I just realized that the example I gave above has a tracking number of<PHONE_NUMBER>641500004437 but the API was giving me back the tracking number of<PHONE_NUMBER>49090283641500004437.  So their API was adding on the 42068102 for some reason.  I am going to do a little more digging around to make sure this does not happen to be a unique use case for our API set up and the tracking numbers being given.  I'll keep you posted.

Those are two different versions of USPS91/FedexSmartPost numbers. The longer version of that number includes the destination zip right in the number (so in this case, that package seems to be heading to eastern nebraska -- 68102?)

Those are two different versions of USPS91/FedexSmartPost numbers. The longer version of that number includes the destination zip right in the number (so in this case, that package seems to be heading to eastern nebraska -- 68102?)

Yeah, that postal code is 68102.  Good catch, I didn't even notice that.

@jkeen do you think this better suited for an issue on tracking_number_data?

@jameswilliamiii 🤷🏻♂ It is similar to this problem (https://github.com/jkeen/tracking_number_data/issues/12) but I'm glad it got brought up again because I have new ideas about it now. It really affects both projects, and doesn't make much of a difference right now which its on since I'm the only person on both projects.
There are some quick and dirty fixes I could do on this gem to solve this issue you described (basically always returning USPS before FedEx when multiple matches occur), but I think I'd prefer to address the root issue and model it out what is needed in the data files so all consumers of tracking_number_data can benefit.
I'd love some more info on how you're actually using this gem in your project, though. Sorry if this sounds basic but the last time i used this gem in a production project was when I wrote the thing 12 years ago—since then I've just maintained it and improved it, and getting insight into how people are actually using out in the wild really helps in designing how it works.
So what are you doing when you get the result from the tracking number gem? You're getting the carrier to query the tracking info? You said initially you had to roll back to an earlier version because that number came up as Fedex instead of USPS—how did that different identification break your project?

Thanks for the details!
It's weird that with it being created through USPS and not a Fedex SmartPost (or Ground Economy as they call it now), plugging those numbers into fedex.com and usps show this:

I take it the API response is different?

The USPS API response matches what they show in your screenshot (which is correct), but the FedEx API response returns a failure saying it is not a valid tracking number.

wow, what a misleading screen on fedex's part.
Do any of the tracking numbers you've encountered have a service type = 29? You can use the decode method on tracking number to spit out all those details. One option here is to make this Fedex detection only detect numbers that have 29 as the service type, which another comment that related issue I linked above suggested. I haven't found any official documentation on that being true, though.
I don't have a current smartpost number I can check this with, but I'm wondering what both systems would return if the number was created via fedex. The opposite? 🤔

I ran through some of our prod data and grabbed USPS created label tracking numbers that decode to a service type of 29.  Here are the service descriptions:
["Priority Mail Express Flat Rate Envelope",
 "Media Mail",
 "USPS Parcel Select Ground",
 "Priority Mail Express"]

Welp, that theory is busted then. Further, it looks like service_type isn't aligned correctly? Each of those service descriptions should have a unique number corresponding to it. So I think something is wrong in this regex
   "regex": [
        "\\s*(?:(?<RoutingApplicationId>4\\s*2\\s*0\\s*)(?<DestinationZip>([0-9]\\s*){5}))?",
        "(?<SerialNumber>",
        "(?<ApplicationIdentifier>9\\s*[12345]\\s*)?",
        "(?<SCNC>([0-9]\\s*){2})",
        "(?<ServiceType>([0-9]\\s*){2})",
        "(?<ShipperId>([0-9]\\s*){8})",
        "(?<PackageId>([0-9]\\s*){11}|([0-9]\\s*){7})",
        ")",
        "(?<CheckDigit>[0-9]\\s*)"
      ],

Are the SCNC values unique and consistent between in those service description groups? Maybe service type needs to be three digits? I can't even recall what SCNC is but I think I found it deep in some usps docs.

@jkeen after upgrading to the latest version, the gem doesn't recognize USPS number.
TrackingNumber.new '9205590164917312751089'
=> #<TrackingNumber::Unknown:0x2aac0e9e8fb0<PHONE_NUMBER>917312751089>

And the same happens when testing the UPS number from Readme.

@OndrejKu thanks for the report! I switched to semantic release recently and the build step is borked. I'm working on a fix now.

Fixed in 1.4! See docs and PR for details if you want, but it should just do the right thing now.


DBZ-7616 Add query timeout property

related to: https://github.com/debezium/debezium/pull/5483

Test seems to be flaky. It passes locally

@mfvitale yes, I'll (re)mark executeBlockingSnapshotWhileStreaming as Flaky...

This must be merged only after the main PR.


[KAFKA-6730] Simplify state store recovery

@mjsax Once the end offsets are fetched, how would you check if the we did fully restored? I still called restorePartition as it is because currently I am not sure how to correctly check the end offsets other than the way provided in restorePartition.

On another note, I noticed how the check should be performed. So this should be ready for review!

\cc @bbejeck @vvcephei

@ConcurrencyPractitioner Thanks for the PR -- test failures seem to be related. Can you have a look before we review?

Thanks Matthias. However, I am not to sure how to simplify this any further, more specifically how to avoid the check that a Task has migrated. It will probably take some time.

@mjsax I will probably need some help on the logic.

Hi, @bbejeck. Would an extra config be required if we would want to cap the number of poll records?
I don't think that adding a configuration is necessary, particular since it only adds complexity to a problem when originally we intended to simplify it.

Hi @mjsax. When you say to "fetch the end offsets" in the JIRA description, do you do it regularly between callbacks for poll() or are you planning to do it after poll() ceases to return any records? I am currently confused on this point.

When I added the first conditional i.e. (if (pos > endOffset)) in the original code to this PR, I managed to pass four of the tests, the only one that failed was shouldThrowTaskMigratedExceptionIfChangelogTopicUpdatedDuringRestoreProcessFoundInSecondCheck. In contrast, when I added the only the second condition to this PR, I managed to get the following for failing tests:
org.apache.kafka.streams.processor.internals.StoreChangelogReaderTest.shouldThrowTaskMigratedExceptionIfEndOffsetGetsExceededDuringRestoreForChangelogTopicEOSEnabled
org.apache.kafka.streams.processor.internals.StoreChangelogReaderTest.shouldThrowTaskMigratedExceptionIfEndOffsetGetsExceededDuringRestoreForChangelogTopic
We might consider the need to change the tests, particularly since TaskMigratedException might no longer be needed in some tests.

@ConcurrencyPractitioner We would call endOffsets() only once. Note, that restoring interleaves with calling poll() on the main consumer. Thus, the overall flow should be:

mainConsumer.poll()
needsRestore?
yes -> get endOffset if unknown (we only do this once)
restoreConsumer.poll()
restore records
if reached endOffsets; set "needsRestore" to false

For the tests: because we change the behavior, we also need to update (or maybe even remove) some tests. It's expected that they don't pass as they test for current behavior that we change.
Does this make sense?

@mjsax I have updated PR with your help. Thanks!
It should be ready for another round of review.

Hi @mjsax, this should be able to resolve the error. I just moved the for() loop to the front of
the if loop, such that any partitions that have been completed will be removed prior to exiting from the outer while loop. In this manner, I think we can avoid leaving partitions which have finished restoring in the needsRestoring map field.

Hi @mjsax  Could you review? This PR is almost ready.

@mjsax  In local, when I ran StoreChangelogReaderTest, a single test didn't pass: shouldRestorePartitionsRegisteredPostInitialization. Upon further inspection, I discovered that end offsets were updated twice in this particular. Thinking this through, I think that updatedEndOffsets should continue retrieve new end offsets to account for this corner case. What do you think?

Migrating to new PR, current branch is too old.

Replaced by #5013


can't sign by ledger through keplr

every app just open keplr and after push button "approve" - this message, ledger not say anything
Keplr 0.11.13, Ledger Nano S

Hey! This seems to be an issue with the front-end client. What app are you trying to use your ledger on? Ledgers only support Amino signing, so when getting the offline signer for Ledgers, you must specify getOfflineSignerAuto to get the appropriate OfflineSigner.


Any plans to support SDXL real_image_editing?

Any plans to support SDXL real_image_editing?

Hi @wangyong860401, thanks for your interest.
As for the real image editing on the SDXL model, I will add this function in my free time (currently not available due to some deadlines).
Or, you can implement it by yourself with the Diffusers lib easily, by:

Implement DDIM inversion on the SDXL model to obtain the initial inverted noise and intermediate latents;
Override the sampling process of the original SDXL pipeline by integrating the inverted intermediate latents into the denoising process.

Hope this can help you.


Timespan enhancement request

Please will you consider the following enhancement requests, if feasible?

Add further times to the custom list such as astronomical dawn, nautical dawn, civil dawn and the same for the other end of the day?
Enable the custom list to be used in the timespan mode?

I assume that as the year progresses, your node updates the custom times as they change.  Does it do this daily?
I'm looking specifically to be able to control my outside lights every morning and evening so that they come on at say 6.30am and switch off at civil dawn and switch on at civil sunset and off at 11pm.  However, where I live, this would work well on a schedule in the winter but in the summer, civil dawn is before 6.30am although sunset would be before 11pm.  However, there are latitudes where it stays light all the time during summer.  So how would I create a schedule which wouldn't turn on the lights at 6.30 in the morning if the civil dawn had already passed?  If this isn't available already, it's not an issue.  I was going to manage all this using the rdmtc sun position node but your ui interface is the thing that makes your node so useful.  Thanks

This would be great!

Hi @GwelforBodad,

The ui-time-scheduler depends on https://www.npmjs.com/package/suncalc and it currently offers all the options that suncalc offers. You could open an issue there, it will be available within the ui time scheduler node once they have published that change.

now works with 1.17.0


Adjusted file structure to improve productivity and testing

Renamed navigation folder to containers and removed screens folder.
Each container folder has each unique screen and it's accompanying components/functions, with the main content being rendered in index.js. This allows for imports to look 'cleaner.'
Each container folder has a tests subfolder to place all tests for each screen's related components.
Removed __tests__ folder.
Renamed Carbon main folder to src since Carbon/Carbon is weird.
Moved ChartData.js and its test file back to the appropriate container folder. NOTE: components folder is intended for re-useable UI elements used across all screens in the app, such as buttons, headers, footers, anchors, etc.. Components used for specific screens should be placed in the appropriate containers subfolder.
Added hooks folder for custom hooks. I already wrote one hook to pass screen dimensions along to the main container and child elements. Will further update at a later date.
Add utils folder. Purpose is to add simple functions used in the app, such as regex, date formatting, etc. to keep other files organized. Will further update at a later date.
Added subfolders to assets.
Fixed imports to support file restructuring.

Don't merge this yet. Will require modifying main in order to merge, as well as updating to include newer commits.

Closed and will be implemented at a later date.


Fix GoLint issues

This commit updates actions and models packages to add godoc to a few
exported types

This was already fixed with https://github.com/gopheracademy/gcon/pull/2


Another attempt at fixing rendering

All Submissions:

[X] Have you followed the guidelines in our Contributing document?
[X] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[X] Does your submission pass tests?

Tested on Firefox, Chrome, and Safari

@hrgdavor this has been one challenging issue. can you try these changes?


babel-cli confusing advise

On  https://babeljs.io/docs/usage/cli/
Note: Since it's generally a bad idea to run Babel globally you may want to uninstall the global copy by running npm uninstall --global babel-cli.
After installing npm install --save-dev babel-cli
On windows 10 now I get this error running babel:
"The CLI has been moved into the package 'babel-cli'.
$ npm install -g babel-cli
Please make up your mind?
thx
Lourens

Clearly you are installing the babel package not babel-cli as that is where the warning comes from https://github.com/babel/babel/blob/60748578fdbb3b92e7c98594aa8f40edbe421ff7/packages/babel/cli.js#L3
Please read the README before opening issues in the wrong place.
thx
James

Please do not put an advise like " Found an issue with the docs? Report it here.(https://github.com/babel/babel.github.io/issues/new)" under the webpage when it is apparently the wrong place?
https://babeljs.io/docs/usage/cli/

@thejameskyle Where there's the advice to globally uninstall babel-cli, perhaps it'd be a good idea to also include babel, since a lot of people will still have that installed from v5. On the CLI Usage page it has the advice to globally uninstall babel-cli, but then goes into examples like:
$ babel script.js

So without the more comprehensive instructions you wrote up for the CLI Setup page, some people following the Usage page will end up running the CLI from a global babel install (leftover v5 or, as in this case apparently, v6).
Perhaps it'd make sense to consolidate https://babeljs.io/docs/usage/cli/ and https://babeljs.io/docs/setup/#babel_cli?

The docs referenced by the commit https://github.com/babel/babel/commit/dbc85cff6988aff1de5e7d931991cbf37546c9df still have examples using babel which when run give the same warning from the original post.


Add support to secondary tables relationships

Fixes #19
Description

Types of Changes

[x] Core
[x] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

#19

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Summary by Sourcery
Add support for secondary table relationships in the SQLAlchemy mapper, addressing a bug and enhancing the loader to handle these relationships efficiently. Include comprehensive tests to ensure the correct implementation of these features.
New Features:

Introduce support for querying secondary table relationships in the database schema.

Bug Fixes:

Fix an issue related to the handling of secondary table relationships in the SQLAlchemy mapper.

Enhancements:

Refactor the SQLAlchemy loader to handle secondary table relationships more efficiently by disabling certain optimizations when necessary.

Tests:

Add extensive tests to verify the correct functionality of secondary table relationships, including scenarios with different foreign keys and multiple secondary tables.

Codecov Report
Attention: Patch coverage is 9.91736% with 327 lines in your changes missing coverage. Please review.

Project coverage is 37.66%. Comparing base (2133fd7) to head (ca9bc1c).

:exclamation:  There is a different number of reports uploaded between BASE (2133fd7) and HEAD (ca9bc1c). Click for more details.
HEAD has 6 uploads less than BASE

Flag
BASE (2133fd7)
HEAD (ca9bc1c)

7
1

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #218       +/-   ##
===========================================
- Coverage   85.51%   37.66%   -47.85%
===========================================
  Files          16       16
  Lines        1629     1962      +333
  Branches      139      146        +7
===========================================
- Hits         1393      739      -654
- Misses        173     1186     +1013
+ Partials       63       37       -26

----
🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests

Hi, thanks for contributing to Strawberry 🍓!
We noticed that this PR is missing a RELEASE.md file. We use that to automatically do releases here on GitHub and, most importantly, to PyPI!
So as soon as this PR is merged, a release will be made 🚀.
Here's an example of RELEASE.md:
Release type: patch

Description of the changes, ideally with some examples, if adding a new feature.

Release type can be one of patch, minor or major. We use semver, so make sure to pick the appropriate type. If in doubt feel free to ask :)


[Documentation] Add Table to Display Repository Statistics in README.md

🌟 Is your feature request related to a problem?:
The issue involves adding a well structured table to display repository statistics, such as the number of stars, forks, issues, and pull requests, directly in the README.md file. This will help contributors and users track the activity and contributions at a glance.
💡 Describe the solution you'd like:
###Steps to Implement:
Create a table in the README.md file displaying the following repository statistics:
1-Stars
2-Forks
3-Open Issues
4-Open Pull Requests
5-Closed Pull Requests
Use markdown syntax to include badges or icons for each statistic.
Add dynamic links to the corresponding sections of the repository for easy access (e.g., link to the "Issues" or "Pull Requests" tabs).

also I want to add this its enhance the readme & I use markdown to implement this

To be Mentioned while taking the issue:

What is your participant role?
GSSOC, Hacktoberfest

This issue isn't needed at the moment. Please review the existing issues or open a new one, relevant to the project and AI/ML if necessary.


unpack ArcGIS Server Setup (skipped due to only_if)

I cannot get past this.  If I manually unpack into the specified directory it will run fine but I don't want to have to go to every server.  I should be able to have ArcGIS_Server_Windows_1061_163968.exe unpack into a setup directory on the server.  What am I missing?  I have gone over the recipe and cannot find my error"
 arcgis_enterprise_server 'Unpack ArcGIS Server Setup' do   setup_archive node['arcgis']['server']['setup_archive']   setups_repo node['arcgis']['repository']['setups']   run_as_user node['arcgis']['run_as_user']   only_if { ::File.exist?(node['arcgis']['server']['setup_archive']) &&             !::File.exist?(node['arcgis']['server']['setup']) }   if node['platform'] == 'windows'     not_if { Utils.product_installed?(node['arcgis']['server']['product_code']) }   else     not_if { EsriProperties.product_installed?(node['arcgis']['run_as_user'],                                                node['hostname'],                                                node['arcgis']['version'],                                                :ArcGISServer) }   end   action :unpack
ProdEnviron.json.txt
2gishs.json.txt
What am I missing?

Previously I have attached my Environment and role that I have been using.

Try this
{
  "name": "ProdPortal",
  "description": "ArcGIS Enterprise CAT",
  "default_attributes": {
    "arcgis": {
      "run_as_password": "password",
      "run_as_user": "stn\\sa.gis.portal",
      "version": "10.6.1",
      "repository": {
        "setups": "D:\\Install\\setups",
        "archives": "\\\\GISMetro\\GIS_Config\\Repository\\10.6.1"
      }
    },
    "web_adaptor": {
      "admin_access": true
    }
  }
}

and
{
  "name": "2gishs",
  "description": "Hosting Server of ArcGIS Enterprise2",
  "default_attributes": {
    "arcgis": {
      "version" : "10.6.1",
      "iis": {
        "keystore_file": "D:\\install\\gisStone.pfx",
        "keystore_password": "password"
      },
      "server": {
        "domain_name": "gishs2.stone.ne.gov",
        "wa_name": "host",
        "url": "https://gishs2.stone.ne.gov:6443/arcgis",
        "admin_username": "PortalAdmin",
        "admin_password": "password",
        "authorization_file": "\\\\GISMetro\\GIS_Config\\Repository\\ArcGISGISServerAdvanced_ArcGISServer_694534.prvc",
        "authorization_file_version": "10.6",
        "keystore_file": "D:\\install\\gisStone.pfx",
        "keystore_password": "password",
        "config_store_connection_string": "\\\\GISMetro\\GIS_Config\\prodhs\\Stack2\\arcgisserver\\config-store",
        "directories_root": "\\\\GISMetro\\GIS_Config\\prodhs\\Stack2\\arcgisserver",
        "install_dir": "D:\\ProgramFiles\\ArcGIS"
      }
    }
  },
  "run_list": [
    "recipe[arcgis-enterprise::system]",
    "recipe[esri-iis]",
    "recipe[arcgis-enterprise::server]"
  ]
}

Also check out this thread https://github.com/Esri/arcgis-cookbook/issues/170.


LED RGBW

Hi
Is any chance to implement option to setup color as it is in mobile view in Home Assistant ? It looks better than in app.
Also i use controller led for RGBW and in app not show slider to setup WHITE color. Only show slider to setup brightnes.
When go to web view my Home Assistant i have brightnes and white.
Now by your app i can not setup light WHITE. Only colors can set.

There is complicatedly new color picker coming in next release. Also there was some fixes for light controls. So all this should be fixed in the upcoming 0.4.0. there will be still no Color temp control in app in version 0.4.0 - please report a separate issue.

Ok thanks


Sponsoring jOlm

Hey @brevilo, [...] respecting your work of jolm, we’d like to sponsor somehow. Please kindly let’s know how.
Originally posted by @oncecrossover in https://github.com/brevilo/jolm/issues/16#issuecomment-993311703

Thanks for the offer. I appreciate that!
Please note that jOlm is a project I run in my spare time and that's not going to change. Furthermore, I'm not contributing to the Matrix ecosystem out of potential financial gains. Thus money isn't an incentive for me personally, also because it would probably set false expectations like a certain maximum response time or entitlements to new features. Sorry, money can't buy that.
That said, I can think still of ways to "sponsor" jOlm in ways that would benefit everyone. As I mentioned in the status report I'd like to see security and memory management audits at the some point. While I still have a few things I want to implement in that area for the upcoming v1.1 release (next week'ish), it would be really great to have an external review of jOlm with regards to potential security issues and/or architectural flaws - by real experts in the field. These could either be interested security researchers or a renowned company offering such a service.
Taking upstream libolm as a fitting example, they got reviewed by NCC Group. No idea what such a review would cost but since jOlm just provides bindings to libolm a security review should be easier and quicker, and thus cheaper.
Another type of "sponsoring" could mean becoming part of the jOlm team, i.e. sponsor time of a professional developer to the project to deal with issues, new features and PRs. Having said that, though, this kind of sponsoring should be pretty ineffective in case of jOlm. The reason being that there won't be that much work to do as soon as it matured enough. jOlm won't have a constant stream of new features like other products. It just needs to keep up with upstream and get a few improvements here and there. Therefore, I don't really see the need for this right now.
Effectively, this only leaves the option to sponsor said external security review in some way or form.
Is that something you could consider?
Cheers

Hey @brevilo , I apologize for my lateness.
We are willing to sponsor some audit fees, please leave contact information.

No worries 👍
There's no need for any additional contact information since there's no need to involve myself. To the contrary, it is way easier for everyone the fewer parties are involved. I suggest you just hire any audit company you see fit. I provided one example above. Should there be any changes required I'll be more than happy to accept PRs from said company (or you). jOlm is open source software after all, so you've got everything you need to go ahead.
Thanks!

Development of jOlm is coming to an end, at least for the time being. Details can be found in the latest status update.
Cheers


Guide page on contextual components

We haven't properly explained how to work with the contextual components offered in radical, and while the Ember guides have some examples of how to use them, the material available is very thin.
Because we use contextual components so liberally, it would be worthwhile to provide an explanation of what they are and how they work, and in particular how Radical uses them, to help ease the learning process for new users who may not be familiar with the pattern.
This would also be a good opportunity to document the process of extending the root components or child components to add extra customizations for app-specific implementations, as well as the process for specifying alternate components for components that yield children and scenarios where you may want to do so.
Potential pages:

Component API

[x] Contextual components overview
[x] Radical's contextual component pattern
[x] Extending Radical Components for customization
[ ] Alternate components for child/contextual component instances

WIP


Setup Busted test framework and start porting tests

Here is a start at work for #356.
Porting all the tests will take some time. It isn't always very clear what is being tested or why, so setting up the right test in a new syntax sometimes takes a dig through commit and issue history. Hopefully the test descriptions in Busted will do a better job of documenting the 'why' of tests for future developers.
I suggest we port a small handful of tests to make sure the framework is working as we want, then merge this. That will leave some tests in the old system and some in the new which is awkward, but it will mean all new tests can be written in Busted. I'm already working on new tests for the class system (see #353) and I don't really want to write them in the old framework. It doesn't seem to be too awkward to have them side by side. Eventually when the old tests directory is cleared out in favor of new tests we can drop the test run command and that will be it.

[x] Must be merged after #357 on which it is based since there are rockspec changes.
[x] Port enough tests that we set a precedent we like for nested test arrangements.

I'm content with the general direction this is headed and organizing tests by module, then breaking some of then down by function for testing.
To anybody else reviewing this: it's probably easiest to review commit my commit rather than looking at the PR diff. GitHub makes a mess of the overall picture, but each commit should port tests for one module or chunk thereof. Seeing the removed test(s) and added test(s) matched up makes a lot more sense.
I won't have much attention for this for a few days, but I think getting this started as the direction in master and letting new tests and test migrations come in piecemeal is okay.


Drag&Drop: Dropping over parent

It is frustrating to drag an element from list1, drop over the edge of the list2, and failing. Also, when receiver list is empty, is hard to know where exactly to drop unless list borders are printed.
I though it would be a good idea to expand the droppable area to the div containing the list, so if you drop over the panel, the list receives the item anyway. That's what I thought ghostClass was for, but I haven't been able to make it work (after all, I'm new to JS).
Here is my JSFiddle: http://jsfiddle.net/f0xearh1/1/
By the way, I also have another problem applicable to this JSFiddle example, and I think it might be an interesting feature for future versions. I have badges at the list elements, indicating the number of each element stored in the list. For getting an element's badge incremented, an event could be triggered, so the user can decide to increment if the text is the same, or in my case, if the HTML5 custom-data fields are equal. I tried event.item.data('type') at onAdd function without success, even when event.item is displayed at JS console perfectly. Any idea for that?
Any help will be appreciated :)

I've came across the same problem and i used a semi-good - rather unproessional - way to fix this problem temporarily.
http://jsfiddle.net/5ztmt4ew/2/
I am making an one-layer-limited treeview with Sortable - that's why i'm using 3 Sortable instances.
When you empty one of the given subfolders - 1.2 or 1.6 - in the given jsFiddle you will see a drop here sign, in the otherwise empty subfolder.
It is done by assigning the class 'show-empty' onStart and the :empty selector on the subfolder.
One problem that i am still encountering is - when i drag all items from the level 1.x into one subfolder, i have no way to move them back to the 1.x level.
The :empty trick isn't working, because the subfolder is still present in the parent  ...  :(

@romanrdgz You seem to have multiple issues, some of which are not bugs but customizations (like the number adding up). One thing that should work OOTB I think is dropping on empty lists, this is not the default that this works. If anyone knows an easy fix for that, that would be great :)

The solution bu Mato75 helped us out here - thanks.

Confirmed mato75's solution... would be nice to see this in the next release!


global parser arguments not configurable when using subparsers

My program has both general options, e.g. '--verbose' and subparser specific options
The general options cannot be set in the gooey generated GUI, at least not by the default settings
of gooey
Global options should best either be presented in a separate general section, or presented in each of the subparser fieldsets, I would suggest.
thanks for looking into this
Christophe

Hello,
I also ran into this limitation and would be really interested into a solution: it would allow for a better factorization of common arguments between sub-commands.
Best regards,
Nathan

I tried this (with release version) and it seems to work acceptably well
from gooey import Gooey
from argparse import ArgumentParser

@Gooey
def get_args():
    p=ArgumentParser()
    p.add_argument('-a')
    q=p.add_argument_group()
    q.add_argument('-b')
    return p.parse_args()

def main():
    print(get_args())

if __name__ == "__main__":
    main()


Uncoalesced tables with no partitioning columns do not render

As of https://github.com/deephaven/deephaven-core/pull/5078, the following code
from deephaven import parquet

x = parquet.read("my-file.parquet")
x_coalesced = x.coalesce()

no longer renders x in the UI - it just spins. x is of type io.deephaven.engine.table.impl.SimpleSourceTable, which is an uncoalesced table (with a single / implicit partition?).

Reproducible using just this snippet:
from deephaven import parquet, new_table
parquet.write(new_table({"Foo": [1, 2, 3]}), "my-table.parquet")
x = parquet.read("my-table.parquet")

@rcaudy I want to confirm I'm fixing the right thing. So in the example above, the table isUncoalesced, but it has no partition columns. In that case, we're just supposed to fetch the whole table, correct? No partition selector?

Reproducible using just this snippet:
from deephaven import parquet, new_table
parquet.write(new_table({"Foo": [1, 2, 3]}), "my-table.parquet")
x = parquet.read("my-table.parquet")

@rcaudy I want to confirm I'm fixing the right thing. So in the example above, the table isUncoalesced, but it has no partition columns. In that case, we're just supposed to fetch the whole table, correct? No partition selector?

Yes, exactly. That's the only way to turn it into something you can render.


MetadataType and MetadataChoice models and REST API

Progress towards #5663 and #5666
What's Changed

Add MetadataType and MetadataChoice models, factories, REST API, and associated tests.
Fix BaseModelFactory so that it respects factory-boy's django_get_or_create meta attribute on factories, which we were defining in a few cases even though it didn't work as such.
Add is_metadata_associable_model = True to BaseModel so that all core and app models will support metadata-type association, but infrastructure models will not.

TODO

[x] Explanation of Change(s)
[x] Added change log fragment(s) (for more information see the documentation)
n/a Attached Screenshots, Payload Example
[x] Unit, Integration Tests
[ ] Documentation Updates (when adding/changing features)
n/a Example App Updates (when adding/changing features)
[x] Outline Remaining Work, Constraints from Design

Most (all?) of the TODOs will need to be addressed as part of the implementation of the main Metadata model which is outside the scope of this PR.


buf-breaking-action v1.1.4 does not support v2 config

We have converted our buf.yaml to v2 format, and now get
the following error with the latest version, v1.1.4, of this action.
Run bufbuild/buf-breaking-action@c57b3d842a5c3f3b454756ef65305a50a587c5ba
Failure: buf.yaml has an invalid "version: v2" set. Please add "version: v1". See https://docs.buf.build/faq for more details
Error: Failure: api/buf.yaml has an invalid "version: v2" set. Please add "version: v1". See https://docs.buf.build/faq for more details

Which version of https://github.com/bufbuild/buf-setup-action are you using? This action depends on buf-setup-action to download the Buf CLI. If you are upgraded to v1.32.0 or later of that action (or follow the v1 tag), it should work with v2 configs.

Ah, yes. I used v1.31.0. Thank you for your help!


python37Packages.mac_alias: 2.0.7 -> 2.1.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python37Packages.mac_alias is: "Generate or read binary Alias and Bookmark records from Python code"
meta.homepage for python37Packages.mac_alias is: "https://github.com/al45tair/mac_alias"
meta.changelog for python37Packages.mac_alias is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 2.1.0 with grep in /nix/store/afr9mr34jkybr43pyndkal8zfh2rs27j-python3.7-mac_alias-2.1.0

directory tree listing: https://gist.github.com/1275502154bc0fdd2e95ab3ae2aed9b8

du listing: https://gist.github.com/2e88c49e09a401c0f1fb2baea4ec7d18

Rebuild report (if merged into master) (click to expand)

12 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
3 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
python27Packages.mac_alias
python37Packages.mac_alias
python38Packages.mac_alias

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/afr9mr34jkybr43pyndkal8zfh2rs27j-python3.7-mac_alias-2.1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python37Packages.mac_alias https://github.com/r-ryantm/nixpkgs/archive/1d36fa4377570c3344041d9c636bc4507444749e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/afr9mr34jkybr43pyndkal8zfh2rs27j-python3.7-mac_alias-2.1.0
ls -la /nix/store/afr9mr34jkybr43pyndkal8zfh2rs27j-python3.7-mac_alias-2.1.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

3 packages built:

python27Packages.mac_alias
python37Packages.mac_alias
python38Packages.mac_alias

Maintainer pings
cc @siriobalmelli for testing.

tested, LGTM


flaky unit test: go/mysql/endtoend

Example: https://travis-ci.org/youtube/vitess/jobs/289290022
--- FAIL: TestKill (0.01s)
	main_test.go:55: was expecting SQLError 2013 / HY000 / EOF but got message io.ReadFull(header size) failed: read unix @->/vt/vtdataroot/vttest874417268/vt_0000000001/mysql.sock: read: connection reset by peer
FAIL
FAIL	github.com/youtube/vitess/go/mysql/endtoend	5.992s

Is this related to the recent change in the local cluster thing?

Looking at the code, this can only happen if io.ReadFull() on the unix socket doesn't return EOF when the other side closes the connection, but something else. note we get the right error code, but the error message doesn't contain 'EOF' (it's not an io.EOF), instead is:
io.ReadFull(header size) failed: read unix @->/vt/vtdataroot/vttest874417268/vt_0000000001/mysql.sock: read: connection reset by peer
I don't see how that would be flaky though, I'd feel it should always work or always fail...

Additional data point: this started happening after the new vttest.

I honestly have no idea. Sugu, I'll show you what I think when you get in, and we can agree on a solution.
Note this is not a critical issue at all, the error codes are 100% correct, it's just the message we get is not what we expect, but it's still correct.

Fixed in https://github.com/youtube/vitess/pull/3322