Feature/489 move protocol

Resolves #489

I'm going to add a "Docs" tag.  I see these files have one or more references to "scope_protocol.yml":
./website/src/pages/docs/config-files.md
./website/src/pages/docs/loader-library.md
./website/src/pages/docs/cli-reference.md

@pdugas:
For the test coverage, the only thing that seemed missing to me is that for protocols, I think there are just two required fields: name and regex.  I'd love to see a unit test that tests/documents what the defaults are for the rest of the fields: binary, len, detect, and payload if only the first two are specified.  Seems like it belongs somewhere in test/cfgutilstest.c.
As a functionality thing, in src/cfgutils.c, I would expect createProtocolEntryJson() to output defaulted fields too.  There are times when we aren't outputting fields, but I believe that this is only when they are not pertinent...  (Like a "path" for a tcp transport, or "host" for a file transport).  My motivation is that I'd like to have the config be completely self describing, so an external client wouldn't need to know what defaults are if they don't appear in the output.

@jrcheli I removed the logic that omitted default protocol properties.
Should be ready to go.

Looks great to me.  Merging.  Thanks @pdugas!


Recurring error message in Omnisharp log.

Issue Description
I haven't identified a specific problem linked to message. Omni sharp is very slow to respond at times though. The missing request message does appear often. Please advise.
Steps to Reproduce
Expected Behavior
Actual Behavior
Logs
OmniSharp log
Post the output from Output-->OmniSharp log here
Received response for /v2/codestructure but could not find request.
Received response for /v2/blockstructure but could not find request.
[warn]: OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService
        No symbol found. File: /home/savaho/Documents/code/back/services/NetScraper.cs, Line: 314, Column: 18.
Received response for /completion but could not find request.
Received response for /v2/getcodeactions but could not find request.
Received response for /quickinfo but could not find request.
[warn]: OmniSharp.Roslyn.CSharp.Services.Navigation.FindUsagesService
        No symbol found. File: /home/savaho/Documents/code/back/services/DownloadService.cs, Line: 72, Column: 49.
Received response for /v2/getcodeactions but could not find request.
Received response for /v2/getcodeactions but could not find request.
Received response for /v2/getcodeactions but could not find request.
Received response for /v2/getcodeactions but could not find request.
Received response for /v2/getcodeactions but could not find request.
Received response for /v2/getcodeactions but could not find request.
C# log
Post the output from Output-->C# here
Environment information
VSCode version: 1.56.2
C# Extension: 1.23.11
Mono Information
        OmniSharp using built-in mono
Dotnet Information
.NET SDK (reflecting any global.json):
 Version:   5.0.203
 Commit:    383637d63f
Runtime Environment:
OS Name:     ubuntu
OS Version:  20.04
OS Platform: Linux
RID:         ubuntu.20.04-x64
Base Path:   /usr/share/dotnet/sdk/5.0.203/
Host (useful for support):
Version: 5.0.6
Commit:  478b2f8c0e
.NET SDKs installed:
5.0.203 [/usr/share/dotnet/sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 5.0.6 [/usr/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 3.1.15 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 5.0.6 [/usr/share/dotnet/shared/Microsoft.NETCore.App]
To install additional .NET runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions

Extension
Author
Version

beautify
HookyQR
1.5.0

csharp
ms-dotnettools
1.23.11

mssql
ms-mssql
1.10.1

vscode-nuget-package-manager
jmrog
1.1.6

These are not really errors. The C# extensions sends requests to OmniSharp server for all kinds of information - file structure, hover help, intellisense, syntax highlighting, available code actions etc.
If you switch between different UI elements, VS Code can decide to cancel the request because there is no longer time for them to be displayed to you - in those cases, it is possible that by the time the response from the server arrives, the UI no longer needs it and this log message shows up.


Unit test calculate average test

I added a unit test that uses the sample files you provided.
I had to the change the submitted classes to read the input file from the arguments passed so that.
The test is not passing for all submissions.

See also https://github.com/gunnarmorling/1brc/pull/84

This one is modifying way too many files. It should only add your implementation and its launch scripts. I am going to close this one, so as to keep the slate clean. When reopening, please make sure to have a single commit off of latest main and the the ./test.sh script passes for your implementation. Thx!


refactor(cli): add entry point for bin

This MR addresses the issue from MR #49

@ChristopherPHolder thx for having a look at this!
Did you try to execute the build artefact?
npx dist/packages/cli collect

Would a combination of bundle false + the additional entry point work for us?

It is worth testing it.

I had to change the bin.js path, but otherwise this seems to work just fine :slightly_smiling_face:

Here another 🧩 of the puzzle:
https://github.com/favware/esbuild-plugin-file-path-extensions

So it seems it is really not straight forward. Just to getting running for the moment i have converted the bin to a .js file and passed as an asset.
I know this is not optimal and i am looking into the configuration for getting the bundling correct without the issue of import file extensions.

Relevent: https://github.com/evanw/esbuild/issues/622

I'm OK with the bin.js asset as a workaround :man_shrugging:
Although as mentioned in #73, maybe we don't need two entry points for the cli anyway, index.ts could just execute instead of only exporting a function. I'm not sure we need to support importing from cli, users that want programmatic usage should be able to import everything they need from core (or models, utils, etc.).

I'm in for the core package!
lets for now have only the bin.ts file present and merge the discussed approach for the cli package.
I'll setup a core package later.

closed as implemented in #66


"Failed to get instance metadata" error while connection to CloudSQL

Bug Description
Hi, we're experiencing a weird behavior while trying to connect CloudSQL using your library.
Once in a while, when pods restart, there is an error while trying to connect to the CloudSQL instance:
failed to get instance: Refresh error: failed to get instance metadata (connection name = "<some_connection_name>"): Get "https://sqladmin.googleapis.com/sql/v1beta4/projects/<my_project>/instances/<my_instance>/connectSettings?alt=json&prettyPrint=false": compute: Received 500 `Internal Server Error`

When these errors happen, they are always preceded by an error in gke-metadata-server:
[conn-id:<some_id> ip:<some_ip> pod:<some_pod> rpc-id:<some_rpc_id>] "/computeMetadata/v1/instance/service-accounts/default/token?..." HTTP/500: generic::unknown: loading: getFederatedToken("....iam.gserviceaccount.com", "", "", ....): loading: while fetching k8s token: loading: Post "https://<some_ip>/api/v1/namespaces/<namespace>/serviceaccounts/default/token": context deadline exceeded, Reason: "K8S", UserMessage: "Internal Server Error"

The problems started to occur last month, and our code that connects to the server has not changed.
Can you please assist us with the issue?
Example code (or command)
import (
    "database/sql"

    "cloud.google.com/go/cloudsqlconn"
    "cloud.google.com/go/cloudsqlconn/mysql/mysql"
)

func connect() {
    cleanup, err := mysql.RegisterDriver("cloudsql-mysql", cloudsqlconn.WithCredentialsFile("key.json"))
    if err != nil {
        // ... handle error
    }
    // call cleanup when you're done with the database connection
    defer cleanup()

    db, err := sql.Open(...)
}

### Stacktrace

_No response_

### Steps to reproduce?

Connect to the CloudSQL instance, as described in the code

### Environment

1. OS type and version: alpine linux 3.17
2. Go version: 1.21
3. Cloud SQL Go Connector version: 1.6.0

### Additional Details

_No response_

Thanks for the issue. After you see these errors, what happens next? Is the pod useless and you have to restart it yet again?

Yes, after the error the pod has to restart.

Let me dig into this a bit. On the surface it looks like a race condition in the underlying GKE infrastructure, but I'll see if we can improve things with some retries on startup.

We're seeing 50x errors occasionally in our integration tests which are symptomatic of the absence retries in the refresh code. I think we'll add some retry code around the API calls to resolve this.


[CI] Fix image in test-vmc.sh & ipfix version in Kind

base-ubuntu:2.14.0 should be pulled instead of antrea-ubuntu:latest
use ipfix-collector:latest in kind

/test-e2e

Codecov Report

Merging #1601 (0c41787) into master (9d3d10b) will decrease coverage by 22.90%.
The diff coverage is 13.28%.

@@             Coverage Diff             @@
##           master    #1601       +/-   ##
===========================================
- Coverage   63.31%   40.41%   -22.91%
===========================================
  Files         170      106       -64
  Lines       14250    12899     -1351
===========================================
- Hits         9023     5213     -3810
- Misses       4292     7216     +2924
+ Partials      935      470      -465

Flag
Coverage Δ

kind-e2e-tests
?

unit-tests
40.41% <13.28%> (-0.87%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

cmd/antrea-agent/agent.go
0.00% <0.00%> (ø)

cmd/antrea-agent/options.go
21.69% <0.00%> (+0.97%)
:arrow_up:

pkg/agent/agent.go
12.20% <0.00%> (-36.51%)
:arrow_down:

pkg/agent/agent_linux.go
0.00% <0.00%> (-100.00%)
:arrow_down:

pkg/agent/cniserver/pod_configuration.go
34.52% <0.00%> (-19.24%)
:arrow_down:

pkg/agent/config/node_config.go
0.00% <0.00%> (-100.00%)
:arrow_down:

...gent/controller/noderoute/node_route_controller.go
32.20% <ø> (-14.26%)
:arrow_down:

.../agent/flowexporter/connections/conntrack_linux.go
28.37% <0.00%> (-0.79%)
:arrow_down:

pkg/agent/proxy/proxier_linux.go
0.00% <0.00%> (-25.00%)
:arrow_down:

pkg/agent/querier/querier.go
66.66% <0.00%> (-21.50%)
:arrow_down:

... and 155 more

/skip-all

/skip-e2e


export more metrics

Codecov Report

Merging #388 (446003e) into master (1b46c5e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #388   +/-   ##
=======================================
  Coverage   74.23%   74.23%
=======================================
  Files          51       51
  Lines       10276    10276
=======================================
  Hits         7628     7628
  Misses       1916     1916
  Partials      732      732

Impacted Files
Coverage Δ

config/config.go
89.88% <100.00%> (ø)

server/rest.go
70.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b46c5e...446003e. Read the comment docs.


Added kubens as tool and bumped version version of kubectx

Added Kubens as tool and bumped the version of kubectx to v0.9.1
Description
updated the version of kubectx to v0.9.1 and als added kubens as tool for fast namespace switching inside a kubernetes context
Motivation and Context
New tool

https://github.com/alexellis/arkade/issues/249
How Has This Been Tested?
make test
make build
./arkade get kubectx
./arkade get kubens

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I've read the CONTRIBUTION guide
[X] I have signed-off my commits with git commit -s
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

[x] I have tested this on arm, or have added code to prevent deployment

Thank you @arnobroekhof
Are there any apps you would like to add, or any other CLIs?


Add components params to incident service

incident service create function now is able to accept components
parameters

Hi @byteranger,
Would you be able to take a look at this merge request?
Thanks,
Yulin

I apologize for the lack of movement on this. I originally created this fork to preserve this seemingly abandoned python library for my use at my employer, but plans for automating their statuspage got heavily backlogged. I haven't touched this code since I forked it. I would not be offended if you and/or the other PR submitter wanted to take over maintaining this library.

Sure, if you can grand me the permission, I will be able to maintain this repo as I constently need add more features into this library for the use of my product.


Fix php integration

Both Ubuntu xenial and Alpine 3.4 changed things for php.
Ubuntu added php7 and named its package just "php" with some modules not present in the main package compared to previous version (php-zip for instance).
Alpine changed the "php" package to "php5" in preparation for the upcoming "php7", which will probably be present in Alpine 3.5.
Ubuntu also added "hhvm" to the repository in xenail, so a test was added for that interpreter.

Looks fine. But I'm still not sure about recursive walk.
Are there any incompatiblities introduced? Like different version of PHP installed on the same distribution, or something like that.

Looks good. Thanks!


Issue with adding span_marker pipe within spaCy

ValueError                                Traceback (most recent call last)
 in <cell line: 6>()
4 # Load the spaCy model
5 nlp = spacy.load("en_core_web_sm")
----> 6 nlp.add_pipe("span_marker", config={"model": "tomaarsen/span-marker-roberta-large-ontonotes5"})
7
8 # Feed some text through the model to get a spacy Doc
1 frames
/usr/local/lib/python3.10/dist-packages/spacy/language.py in create_pipe(self, factory_name, name, config, raw_config, validate)
658                 lang_code=self.lang,
659             )
--> 660             raise ValueError(err)
661         pipe_meta = self.get_factory_meta(factory_name)
662         # This is unideal, but the alternative would mean you always need to
ValueError: [E002] Can't find factory for 'span_marker' for language English (en). This usually happens when spaCy calls nlp.create_pipe with a custom component name that's not registered on the current language class. If you're using a Transformer, make sure to install 'spacy-transformers'. If you're using a custom component, make sure you've added the decorator @Language.component (for function components) or @Language.factory (for class components).
Available factories: attribute_ruler, tok2vec, merge_noun_chunks, merge_entities, merge_subtokens, token_splitter, doc_cleaner, parser, beam_parser, lemmatizer, trainable_lemmatizer, entity_linker, ner, beam_ner, entity_ruler, tagger, morphologizer, senter, sentencizer, textcat, spancat, spancat_singlelabel, future_entity_ruler, span_ruler, textcat_multilabel, en.lemmatizer
Package versions:
spacy == 3.5.3 (did not work with 3.5.2 as well)
span_marker == 1.2.1

If this issue persists (e.g. in Google Colab it seems to persist), then you can always add import span_marker and it'll work.

Thanks for helping out. Really appreciate it.
On Tue, Jun 20, 2023 at 3:21 PM Tom Aarsen @.***> wrote:

If this issue persists (e.g. in Google Colab it seems to persist), then
you can always add import span_marker and it'll work.
—
Reply to this email directly, view it on GitHub
https://github.com/tomaarsen/SpanMarkerNER/issues/13#issuecomment-1598467399,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AORBUQNVKNOKVODIQNJQQNDXMFXDFANCNFSM6AAAAAAZM2ZTCM
.
You are receiving this because you authored the thread.Message ID:
@.***>


feat: added clear clipboard

Overview

New Feature [Clear Clipboard]: as added in android api 28 clearPrimaryClip here i have implemented this.
Test Plan

Copy text
Clear it by pressing "Clear Clipboard" Button
This should work on android api 28 +

Please merge this if it has no error.

can we merge this issue ? I face the issue where setString("") not completely clear the clipboard in Gboard of Samsung device
@dnlgrgly


Feature/dashboards and better validation

Codecov Report

Merging #21 (6eb9168) into master (c55ae12) will increase coverage by 0.48%.
The diff coverage is 77.49%.

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   80.06%   80.54%   +0.48%
==========================================
  Files          49       36      -13
  Lines        2959     2822     -137
  Branches      655      658       +3
==========================================
- Hits         2369     2273      -96
+ Misses        440      390      -50
- Partials      150      159       +9

Impacted Files
Coverage Δ

metrics_layer/core/parse/github_repo.py
70.45% <ø> (+3.78%)
:arrow_up:

metrics_layer/core/sql/query_design.py
88.05% <ø> (-0.18%)
:arrow_down:

metrics_layer/cli/seeding.py
75.69% <33.33%> (-4.93%)
:arrow_down:

metrics_layer/core/query/query.py
77.67% <42.85%> (-2.33%)
:arrow_down:

metrics_layer/core/parse/connections.py
62.66% <50.00%> (-2.04%)
:arrow_down:

metrics_layer/core/parse/config.py
70.00% <65.00%> (+1.16%)
:arrow_up:

metrics_layer/core/parse/project_reader.py
69.92% <75.00%> (+4.26%)
:arrow_up:

metrics_layer/core/model/dashboard.py
75.75% <75.75%> (ø)

metrics_layer/core/parse/manifest.py
76.92% <76.92%> (ø)

metrics_layer/core/model/view.py
83.92% <83.33%> (+1.92%)
:arrow_up:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c55ae12...6eb9168. Read the comment docs.


I've rewritten this in React and TypeScript.

Here is my repo: https://github.com/lixiang810/Ideosorter-React
Code copied or modified from this project is licensed under the MIT license, while code I wrote out myself is licensed under the AGPLv3 license.
The advantages of this repo are as follows:

The answer process uses the history api, so the user can go back to the previous page during the test to redo the previous question.
The code uses TypeScript, which improves readability and makes maintenance and expansion easy.
The data is organized using the array method, thus avoiding the problems associated with overly dynamic typing.
The project uses eslint and prettier to ensure consistent code style.
This is a Single Page App, the user does not need to repeatedly load pages.
This will be a progressive web app, where the user loads once and then no longer needs to request content from the server.

That's amazing, sadly I am not versed well enough with react at the moment to help you, but best of luck in your endeavor.


Field name alternatives

I have now added field name alternatives (e.g. HGHT for height) at https://enram.github.io/vpts/format/, so users can recognize previously used names for fields. These are:

[ ] height: HGHT
[ ] height: bin_lower
[ ] ff: speed
[ ] dd: direction
[ ] sd_vvp: rmse
[ ] dbz_all: DBZH
[ ] n_dbz_all: nbins
[ ] eta: linear_eta

@adokter I guess I should not add the following three, as these require a conversion (and are thus not the same):

[ ] dbz: linear_eta
[ ] dens: linear_eta
[ ] dbz_all: linear_eta_unfiltered

Does that mean that the same data can be found under different column names?
I'm not sure how desirable that is (it might be easier to produce files in some cases, but harder to consume them).
If the sole goal is to make the user recognise them, why not require a single column name, but document the alternative names (for example: require the field to be named sd_vpp and add: you might know this data as rmse?

My intent was more to indicate to the user “also known as” and not provide conversion.
However, it is likely we will need conversion at some point, especially if the standard gets a new version and/or we want to convert legacy data.

@adokter I guess I should not add the following three, as these require a conversion (and are thus not the same):

correct

The website well now state the alternative names as Also known as, which I hope makes it clearer that it should not be used as a header.
I have also expanded radar_lat to radar_latitude and radar_lon to radar_longitude, as I see no point in abbreviating those terms. Let me know if that is ok.


REST API inserts not displaying on egeria.odpi.org

Throughout our documentation of REST APIs we have been using the POSTMAN placeholders - eg {{serverName}} - unfortunately these are interpreted as Jekyl variables and come out as a null.  Here is an example from Asset Consumer OMAS.

Initially I thought it was an error in the markdown but it is displaying ok in IntelliJ.
I have gone through and changed these to use single curly braces.  I have also made the insert names more consistent:

{serverName} - for the name of the OMAG Server
{serverURLRoot} - for the network address of the OMAG Server Platform
{userId} - for the user Id of the caller
:

If we want the docs to literally match what a user may type with postman, then there is a mechanism for doing this with jekyll markup (apparently - not tried)
https://stackoverflow.com/questions/24102498/escaping-double-curly-braces-inside-a-markdown-code-block-in-jekyll

If however we are just using them as a more abstract description, then any recognized parm replacement technique is fine. Especially where we have actual code samples in notebooks, postman collections, or curl/httpie snippets


Add Ruby to builder

Summary

Part of #1
Adds Ruby Buildpack and related smoke test to builder
Use Cases

Checklist

[X] I have viewed, signed, and submitted the Contributor License Agreement.
[X] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[X] I have added an integration test, if necessary.
[X] I have reviewed the styleguide for guidance on my code quality.
[X] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@paketo-buildpacks/builders-maintainers I was wondering - is the goal of the tests here to ensure order groups work as expected, or are we also interested in testing fixtures that specifically rely on the Full stack?
I copied over the fixture from the Bionic Full builder tests, and it works on Base and Full. I considered pulling in an app that requires the Full stack specifically, like a Rails app, but it might take a lot longer to build so I'm not sure if it's worth it. It depends on the goal of the tests really


Create new labels for issues

We have quite a few issues now but the current labels are not very useful for categorizing them. The majority of the issues fall under enhancement and a few fall under bug. So, we should have a few extra labels to help prioritizing.
Namely, my main concern is that issues requesting documentation for important features such as JOIN LATERAL, FOREIGN KEY, and ALTER VIEW take a long time to be addressed. So I would like to add the following labels:

high-priority: #893 #252 #803
low-priority: #945
nit: #908, #141

(They could be named differently, e.g. Priority 0 (lowest), ..., Priority 3 (highest), etc.)
I would also add the following categories:

example - Issues requesting examples of features, e.g.: #890
infra - We have some CI and other build infrastructure (Docker, contributor guidelines, licenses) issues, e.g.: #315 #823 #950 #951
extension - For documentation on extensions, e.g.: #917, #848, #772

We could also add labels for components (CLI, Python, R, ...) but I don't see this as critical.
@Alex-Monahan, @Mause, WDYT?

We have enough labels now to categorize the issues. Closing this now, we can revisit later if necessary.


Fixed Improper Method Call: Replaced NotImplementedError

PR Checklist

[x] Correct base branch selected? Should be develop branch.
[x] Enabled commit hook or executed ./bin/autoformat-nuitka-source.
[ ] All tests still pass. Check the Developer Manual about Running the Tests. There are GitHub
Actions tests that cover the most important things however, and you are welcome to rely on those,
but they might not cover enough.
[ ] Ideally new features or fixed regressions ought to be covered via new tests.
[ ] Ideally new or changed features have documentation updates.

Summary
This PR fixes the improper use of NotImplementedError with a proper one NotImplemented in the SCons library source code.
Description
While triaging your project, our bug fixing tool generated the following message(s)-

In file: ListVariable.py, class: _ListVariable, there is a special method __lt__ that raises a NotImplementedError. If a special method supporting a binary operation is not implemented it should return NotImplemented. On the other hand, NotImplementedError should be raised from abstract methods inside user defined base classes to indicate that derived classes should override those methods. iCR suggested that the special method __sub__ should return NotImplemented instead of raising an exception. An example of how NotImplemented helps the interpreter support a binary operation is shown here.

The same message is found for two more ListVariable.py file of the SCons library.
Recently, we've fixed the bug for SCons library, which has been merged. Since your project includes a few outdated versions of SCons, it's better to update them.
Solution / Suggested Changes
The use of NotImplementedError has been replaced with NotImplemented since their usage are different.
Previously Found & Fixed
Below is a list of open-source projects where this same bug was found and fixed-

https://www.github.com/ethereum/web3.py/pull/3080
https://www.github.com/cupy/cupy/pull/7900
https://www.github.com/SciTools/iris/pull/5544
https://www.github.com/FEniCS/ffcx/pull/636
https://www.github.com/projecthamster/hamster/pull/737
https://www.github.com/phoebe-project/phoebe2/pull/795
https://www.github.com/osm-fr/osmose-backend/pull/2071
https://www.github.com/SCons/scons/pull/4448

CLA Requirements
This section is only relevant if your project requires contributors to sign a Contributor License Agreement (CLA) for external contributions.
All contributed commits are already automatically signed off.

The meaning of a signoff depends on the project, but it typically certifies that committer has the rights to submit this work under the same license and agrees to a Developer Certificate of Origin (see https://developercertificate.org/ for more information).
- Git Commit SignOff documentation

Sponsorship and Support
This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.
The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.

Since these errors never raise in our code, probably not too important, but nothing speaks against it at all.


Scoreboard is muuuuuch more complicated

Why can't you make the commands simpler?
/esb set 0 "&d&lMagi&a&lBeta" instead /esb set 0 "%d%%&l%Magi%a%%&l%Beta"

I'll guess it is.
I just thought if I add % as a separator for the placeholders, it would make sense to do this on the colors like GREEN and the styles like ITALIC to.
That way you could, for whatever reason, write team colors in caps into the scoreboard or whatever.
For consistency I added them the to the abbreviations, too.
Maybe I leave them on the written color and style strings but remove them from their abbreviations.

You can keep the % there, but only for variables like PLAYERBALANCE, not colors (as they are used with the &)

Changed it in 1.7.2


How to visualize the attention

How to visualize the attention

VQA attention output

This repo only includes the bottom-up attention (Faster R-CNN) model from section 3.1 of the paper. The VQA model was built by Damien Teney from University of Adelaide in Matlab. Last I heard he doesn't plan to release the model. However, I will be releasing the captioning model (with attention visualization) in the next few weeks.

We have now released the code for the captioning model: https://github.com/peteanderson80/Up-Down-Captioner. This includes a demo that shows the attention visualization for captioning.
thanks

Sorry... wasn't exactly in a few weeks...

thanks for your reply
来自 魅族 PRO 5
-------- 原始邮件 --------
发件人：Peter Anderson<EMAIL_ADDRESS>时间：周一 2月12日 13:01
收件人：peteanderson80/bottom-up-attention<EMAIL_ADDRESS>抄送：haibin894609937 liuhaibin210317@hotmail.com,Author<EMAIL_ADDRESS>主题：Re: [peteanderson80/bottom-up-attention] How to visualize the attention (#16)
We have now released the code for the captioning model: https://github.com/peteanderson80/Up-Down-Captioner. This includes a demo that shows the attention visualization for captioning.
thanks
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/peteanderson80/bottom-up-attention/issues/16#issuecomment-364829548, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGon7vx6jN7Y__DyYgfdXDGKq3wwDUwJks5tT8WSgaJpZM4QgIYN.


TypeError: session.updateConfig is not a function

I cannot for the life of me figure out why this isn't working! I'd love some help with this.
Function that's causing the problem:
session.updateConfig({
      cookieName: "google-token",
      password: process.env.SESSION_SECRET,
});

Produces the error "TypeError: session.updateConfig is not a function"

export const googleSessionOptions: SessionOptions = {
  cookieName: "google-token",
  password: process.env.SESSION_SECRET,
  cookieOptions: {
    httpOnly: true,
    path: "/",
    secure: process.env.NODE_ENV === "production",
    sameSite: "strict",
  },
};

Running version: 8.0.1
I'll keep working on this and keep you posted if I get a solution! Would love some extra documentation on this though :)

Fixed in 8.0.2


Implement proxy server in base library

Create a server that connects via websocket client, versus a websocket server. This will allow us to relay from desktop to mobile on chrome.

Not really sure this needs to be part of the main library yet. The only thing that will use this is the proxy website, and it can implement that itself.


Feature request: run puppeteer in the browser

Just trying to feel the water here, but it seems to me that apart from downloading chrome and launching a browser, puppeteer isn't really doing anything that can't be done in a browser. I'm thinking puppeteer.connect() in a webpage. Would there be any interest in supporting this? Am I overlooking any barriers that are in the way of achieving this? I can probably make some time to look into it.

@Janpot this definitely sounds interesting. I don't think it makes sense to have it as a part of this repository - it deserves a separate project.
Do you have any success with this?

I tinkered a bit with it a month ago. I think it's feasible to create a build of puppeteer that runs in the browser but I haven't picked it back up. I think a separate project would only complicate things as the goal would be to not add code at all, just refactor here and there and add a build target.

I think a separate project would only complicate things as the goal would be to not add code at all, just refactor here and there and add a build target.

This would be ideal. @JoelEinbinder had a prototype as well and refactored pptr codebase to simplify things there. However, iirc he still needed to mock fs and some other node modules we use occasionally.

Thanks @Janpot for the follow-up

BrowserFetcher needs to be excluded

Right, I'd expect both BrowserFetcher and Launcher to be excluded.

I shimmed WebSocket with

This is an interesting approach. Another option might be implementing Connection class with whatever transport is used to drive pptr in browser.

Launcher seems to be needed to be able to connect. As for the shimming it was basically a "make it work as quickly as possible" approach. Will look into more maintainable ways later.

@aslushnikov I added my proof of concept as a PR https://github.com/GoogleChrome/puppeteer/pull/2374

The developer tools can overcome some browser security enforcements like CORS.
e.g. Accessing an iframe from a different origin and running javascript code on that frame will probably be blocked if tried from inside the browser, wouldn't it?

A nice summary on what's anti-bundleable in pptr was given here: https://github.com/GoogleChrome/puppeteer/issues/2245#issuecomment-410735923
We should:

fix these
bundle puppeteer for web as part of our testsuite to make sure we don't regress the bundle'ability in future

correct me if I'm wrong, but now that puppeteer-core is a thing, I guess trying to bundle puppeteer doesn't make much sense anymore?

@Janpot: puppeteer-core is the same codebase as puppeteer; but yes, you'd probably want to depend on puppeteer-core.

I'd assume the browser incompatible thing that's left in that case is the websocket implementation.

Also the dynamic imports - I have a promising draft to cleanup these.

@noamalffasy The next release is scheduled for October, 4 (you can see next release date in the very beginning of our documentation).

Is there a way I can get this version without waiting until the next release?

@noamalffasy you can either clone from the github directly, or install the tip-of-tree release with npm i puppeteer@next.

That worked!
Thank you!

Okay I have an issue now with bundling,
ERROR in ./node_modules/puppeteer/lib/WebSocketTransport.js
Module not found: Error: Can't resolve 'ws' in '/node_modules/puppeteer/lib'

I'm using webpack

@noamalffasy I'm not sure what's the lib/WebSocketTransport.js; there's a suitable one in utils/browser/WebSocket.js.
Note though: we don't currently publish bits we use to bundle, but you can git clone puppeteer and then run npm run bundle to bundle it locally.

So this feature is only available if you clone the repository? Or is it temporary?

@noamalffasy we're not shipping any bundled version of puppeteer for web, but we made sure that there are no obstacles in bundling puppeteer.

But there is an issue, maybe I need to change my webpack config?
const path = require("path");

module.exports = {
  entry: "./src/main.ts",
  mode: "production",
  module: {
    rules: [
      {
        test: /\.ts$/,
        loaders: "babel-loader",
        exclude: /node_modules/
      },
      {
        test: /\.js$/,
        use: ["source-map-loader"],
        enforce: "pre"
      }
    ]
  },
  resolve: {
    extensions: [".ts", ".js", ".json"]
  },
  output: {
    filename: "bundle.js",
    path: path.resolve(__dirname, "dist")
  }
};

I wrote some code that scrapes some web pages. It doesn't do too well in a cloud hosted environment like DigitalOcean. It'd be neat if a user could load a page served by my API that would then allow their browser tabs to be controlled through the regular puppeteer API (if they permitted/allowed it, etc. etc.). This is the opposite of me having to waste the server resources to run a web browser, while still allowing me to do scriptable things like user input, clicking, evaluating scripts, etc.
Was that kind of the vision here? Is that possible and I am just misunderstood?

It'd be neat if a user could load a page served by my API that would then allow their browser tabs to be controlled through the regular puppeteer API (if they permitted/allowed it, etc. etc.). This is the opposite of me having to waste the server resources to run a web browser, while still allowing me to do scriptable things like user input, clicking, evaluating scripts, etc.

I think this is possible using the bundled version of puppeteer and extension's chrome.debugger.
Tip: you can pass a custom transport to puppeteer connect using the transport experimental option; check out our test in the /utils/browser/test.js

@aslushnikov Q: Can I use this to use puppeteer inside of an already opened browser? For example, if I'm already logged into Facebook, can I execute a Puppeteer script inside the same browser so I don't have to login again?

@woniesong92 You can connect puppeteer to any browser that talks the devtools protocol. For that you'll first need to start chrome with an extra CLI flag --remote-debugging-port=9229. Then you can open http://localhost:9229/json/version and find the webSocketDebuggerUrl. Use that in puppeteer.connect as browserWSEndpoint  instead of using puppeteer.launch.

@Janpot do u have any document guideline how to run puppeteer in browser without running nodejs?

I think this is possible using the bundled version of puppeteer and extension's chrome.debugger.
Tip: you can pass a custom transport to puppeteer connect using the transport experimental option; check out our test in the /utils/browser/test.js

@aslushnikov since chrome.debugger provides a sendCommand and onEvent functions, would it be possible to pass this in without having to use the experimental Target.exposeDevToolsProtocol command? i.e. we could have a ConnectionTransport class like ChromeDebuggerTransport which could be used.
The reason why I ask this is because I cannot manage to get the Target.exposeDevToolsProtocol command to work properly - I never end up with the window.cdp object defined and there is not much information about this command apart from the API docs. This is what I've been trying:
    chrome.tabs.getCurrent((tab) => {
      let currentTabTarget = {tabId: tab.id};

      chrome.debugger.attach(currentTabTarget, '1.3', () => {
        if(chrome.runtime.lastError) {
          alert(chrome.runtime.lastError.message);
        }
      });

      chrome.debugger.getTargets((targets) => {
        currentTarget = targets.find((info) => { return info.url == tab.url });
        chrome.debugger.sendCommand(currentTabTarget, 'Target.exposeDevToolsProtocol', {targetId: currentTarget.id});
        chrome.debugger.detach(currentTabTarget, () => {
          if(chrome.runtime.lastError) {
            alert(chrome.runtime.lastError.message);
          }else{
            alert(window.cdp)
          }
        });
      });
    });

@aslushnikov since chrome.debugger provides a sendCommand and onEvent functions, would it be possible to pass this in without having to use the experimental Target.exposeDevToolsProtocol command?

IIRC the chrome.debugger doesn't expose the newest version of DevTools protocol - with proper target ids, flattened session management etc. So I don't think it would be possible.

The reason why I ask this is because I cannot manage to get the Target.exposeDevToolsProtocol command to work properly - I never end up with the window.cdp object defined

Yeah, I think this is because chrome.debugger simply is not up-to-date with the modern DevTools protocol. The only way to get the window.cdp is to use devtools protocol right away externally when launching chrome, e.g. with Puppeteer, and then embed puppeteer-web. This is what we do with our puppeteer-web tests.

@aslushnikov many thanks for getting back to me on this. I can't seem to find any information about the DevTools version that chrome.debugger exposes, but also since its in an experimental feature I think you're right this is probably just not possible at the moment.
In the future, if chrome.debugger becomes more stable and up-to-date, being able to run puppeteer-web using the chrome.debugger interface would be very useful for me. This could allow us to write chrome-extensions which could use puppeteer without the need for users to launch the browser from the command line.

Hi, we are trying to use the chrome.debugger api to interact with the browser using puppeteer. We were able to send messages back and forth. We mocked a few calls that are denied by the browser (eg. all Target.* commands), which allowed us to execute a few actions, however we are not able to retrieve the sessionId associated to targets as they are normally retrieved using the Target.attachToTarget. Using chrome.debugger.attach does not return the sessionId either.
@aslushnikov if I understand well, the devtools exposed by chrome.debugger are not the same than the ones exposed by the websocket obtained with --remote-debugging-port. Is it planned to update the chrome.debugger API/accessible commands? Also, is there a chromium issue to track this feature request?

I would like to it in the browser because I need to convert HTML to pdf. Should I do this https://github.com/puppeteer/puppeteer/issues/2119#issuecomment-380961956? or what

Wanted to check any update on "launching the browser other than the command line" from the client-side JS page?
Basically, I want to deliver HTML page with some JavaScript file to the User, that will launch the browser (Currently, we are launching it from the command line). Once the browser is launched I will get "webSocketDebuggerURL" from http://<IP_ADDRESS>:9222/json/version. to connect.
Any help on, how I can achieve it without using any server/command Line?


[Task]: Check and throw error if there is a discrepancy in dynamicBindingPathList before saving

Is there an existing issue for this?

[X] I have searched the existing issues

SubTasks
Related to https://github.com/appsmithorg/appsmith/issues/10037
We are seeing a lot of sentry errors lately related to invalid bindingPathList across multiple widgets(refer below). This error is being thrown from the server, hence we don't have much context on how we ended up with an invalid list. As part of this task, we need to add a check, before we make a save call, to identify this error on the client and then throw a sentry error. That way will have more context on the issue.

 "widgetType" : "LIST_WIDGET",  "bindingPath" : "template.ButtonGroup1.groupButtons.groupButtonir5dikkud2.label",  "message" : "Binding path in the widget not found. Please reach out to Appsmith customer support to resolve this.",  "widgetName" : "List1",  "widgetId" : "spuvlxlf5d",  "pageId" : "61ededd4be698f35db550072",  "layoutId" : "61ededd4be698f35db550070",  "dynamicBinding" : "SWOT"

https://sentry.io/organizations/appsmith/issues/2880419545/?environment=Production&project=1546547&referrer=alert_email

@keyurparalkar by when will be able to fix this up?

@somangshu this will get completed by today or max by tomorrow first half.


Document the use of miniconda

There are many issues about documenting the use of conda. I think this means we should actually do it.

[ ] #44
[ ] #29
[ ] #18

We also discovered that creating a conda environment with the miniconda module during an interactive job (started via srun -p cpu --pty bash -i) is very slow. Creating the same environment on the gateway node seems to be faster. If confirmed, we should solve this or at least document it.


Support public and private key encryption

Is your feature request related to a problem? Please describe.
Support asymmetric encryption/decryption feature on SubWallet
Sumi Network (wallet-to-wallet communication solution - https://www.sumi.network/) is asking SubWallet to support them in terms of public and private key encryption.

Sumi Network demo at Decoded 2022: https://www.youtube.com/watch?v=a8P5xHkMqzI

Solution for Substrate accounts:

Not support SR25519 right now
[ ] Solution in this PR to support encrypt/decrypt  functions on Polkadot JS

[ ] Why this PR is not accepted?
[ ] Security concerns of this PR
[ ] How to make this PR get passed?

Solution for EVM accounts
Documentations from MetaMask:

https://docs.metamask.io/guide/rpc-api.html#eth-decrypt
https://docs.metamask.io/guide/rpc-api.html#eth-getencryptionpublickey
[ ] Example on (https://metamask.github.io/test-dapp/)
[ ] Why these methods will be deprecated on MetaMask

https://medium.com/metamask/metamask-api-method-deprecation-2b0564a84686
Few users?
Security?

[ ] Security concerns of these methods
[ ] Follow MetaMask

More information:

https://docs.metamask.io/guide/rpc-api.html#unrestricted-methods
https://docs.metamask.io/guide/signing-data.html#a-brief-history

The reason Metamask deprecated encrypt/decrypt functions on their Extension (Video).


insufficient data rate <Novatel GPS (/dev/ttyUSB0)>: 0.000000 < 5.000000

Hi ,I am using an OEM718D device that was running at 5 Hz and I have set the expected_rate_(5). When I use the Serial debugging assistant（cutecom），the data is successfully read, however when I use this novatel_gps_driver package, no data is obtained  through the commond ---roslaunch novatel_gps_driver tester_for_usb.launch ,and the error is :[ERROR] [1560927037.977802740]: insufficient data rate <Novatel GPS (/dev/ttyUSB0)>: 0.000000 < 5.000000
Is this package not support novatel 718D? or anything is wrong ? have you got the same problem with me?

I think that this error message is a known bug; see #6.  Although it prints that error message, it should still be able to publish GPS messages; do you see messages coming from your ROS topics?

thankyou to your reply, I have already fixed this problem, it maybe that when I change the expected_rate_(5), the polling_period is forgoten to  be configured , and now I have set it to 0.5, the gps messages  is succesfully published, Is  this driver  compatible with OEM718D?

How did you change the expected rate? I couldn't find an API to change it. DId you change the source code?
Thanks,

The value is currently hard-coded at https://github.com/swri-robotics/novatel_gps_driver/blob/master/novatel_gps_driver/src/nodelets/novatel_gps_nodelet.cpp#L206, but it might make sense to make this a separate parameter and/or have the default value be based on polling_period, which is a parameter.


Add another values structure

Currently, Flux can interpret these common values formatting in order to automate images:
values:
  image: repo/image:version

values:
  image: repo/image
  tag: version

values:
  image:
    repository: repo/image
    tag: version

It would be nice for Flux to be able to understand this structure as well:
values:
  image:
    registry: repo
    repository: image
    tag: version

Are there charts in stable that use this format? That tends to be the benchmark.
Hence or otherwise, is it possible that https://github.com/weaveworks/flux/issues/1262 would address this? (I think possibly not, since the proposals there assume the image ref is in two parts, not three)

stable/redis is an example :)


Check and update github deployment status

https://github.com/gunmack/276_website/deployments

Currently deployed with background and

Hello World!

https://github.com/gunmack/276_website/commit/0206ee3321b59dee8619d21b18de67d85dac5999

Latest merge; deployment successful

https://github.com/gunmack/276_website/pull/16

Cannot navigate to root directory using navbar links

Currently deployed without any issues

currently deployed after 2 failed runs

Issue in pacakge-lock.json
linting issue with a component file

currently deployed with a projects page

Final changes complete:

Lab submitted
Website complete as per requirements ( I think )

Closing this issue now


Breakpoints do not work when running tests

Describe the bug
Hello,
I'm having trouble getting breakpoints to work when running tests.
They work fine when running a main class.
video example
https://user-images.githubusercontent.com/1673880/235112049-2b2ba281-46c2-4e05-aa05-63df84bd0c6d.mov

However when running a test, the debugger stop, but nothing shows up in the dap ui (frames, scopes etc.). When I resume the session the test runner resumes normally.

video example
https://user-images.githubusercontent.com/1673880/235112325-928ea4d1-1fa3-4f99-939e-a049e34bcfc4.mov

Everything works fine in VSCode:

video example
https://user-images.githubusercontent.com/1673880/235113168-93f206ef-c7c4-4542-8651-c3202e3110a8.mov

In another repository I get a "breakpointRejected" message, but I couldn't find any information about where that can come from.
Expected behavior
the debugger should stop at breakpoints normally when running tests.
Operating system
macOS
Version of Metals
https://github.com/scalameta/metals/commit/24790ce3576cc938d1cf7e46b99e5b7415e754d6
Commit of nvim-metals
26968e2768ffd59f7dcc26693c534ca91a80c928

Thanks for the report @kimlai. I'll need to dig in and look at the DAP communication for this to see what's going on. I'll report back when I have some time to look at it.


[TS migration] Migrate 'ReportReactionList' component to TypeScript

@blazejkustra @getusha
Details
The ReportReactionList component is migrated to TypeScript.
Fixed Issues
$ https://github.com/Expensify/App/issues/31976
PROPOSAL: https://github.com/Expensify/App/issues/31976#issuecomment-1883131462
Tests

[x] Verify that no errors appear in the JS console

Offline tests
Same as the QA tests. It also should behave the same offline.
QA Steps

Open any chat (e.g. a workspace chat)
Add a reaction emoji to any messages
Hover and right-click on the reaction emoji on the message (on desktop and web), or long-press the emoji (on mobile)
The popover should show up, having the info of the people who reacted the same emoji, the emoji count etc.

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/138146362/b56bf32d-b4cd-4e86-8ded-419d0f9619a5

iOS: Native
https://github.com/Expensify/App/assets/138146362/6a38a40e-589b-4c8f-8822-936d2462c490

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/138146362/014b4ee2-308e-4568-bc89-adf10ce5539c

MacOS: Desktop
https://github.com/Expensify/App/assets/138146362/28a1c116-f0a8-4f70-a813-99d0c46dc5b3

Lint and Ts checks are failing, let me know once everything is resolved and I'll have a look @vadymbokatov

Hi @blazejkustra
This task is done. Please kindly review and let me know if there are any issues. Thanks.

@vadymbokatov several tests are failing, lets solve that.

@vadymbokatov several tests are failing, lets solve that.

Hi. Thanks for your consideration. Would you please provide some steps on how are you running the tests? I'm running them with npm run test and everything is fine as you're seeing in the attached screenshot.

Please sync this branch with the newest main. Context here, thanks!

Please sync this branch with the newest main. Context here, thanks!

@blazejkustra Done. Also the mentioned issues are all resolved. Thanks.

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@vadymbokatov Lets add testing steps.

@getusha Done. Thanks for your review.

@vadymbokatov thanks, could we also complete the Screenshots/Videos section following that?

@getusha Done. Thanks.

@vadymbokatov another crash when pressing on user profile from reaction list
Screen.Recording.2024-02-08.at.11.27.21.AM.mov

This is weird as I wasn't able to reproduce it. Does it happen always or sometimes? Can you please let me know the exact steps to reproduce it? Thanks.

This is weird as I wasn't able to reproduce it. Does it happen always or sometimes? Can you please let me know the exact steps to reproduce it? Thanks.

React on a message
long press on the reaction
press on the user profile shown

I think it happens sometimes will test it again.

This is weird as I wasn't able to reproduce it. Does it happen always or sometimes? Can you please let me know the exact steps to reproduce it? Thanks.

1. React on a message

2. long press on the reaction

3. press on the user profile shown

I think it happens sometimes will test it again.

I just tried to reproduce it again in different scenarios (e.g. slow internet connection, offline mode, etc.) and I was unsuccessful. Please kindly let me know if you could catch it again and how did you manage to do so, and I will fix it immediately.
Thanks. @getusha

This PR
Staging

the position of the popover is wrong, looks like related to this PR.

@vadymbokatov could you please check ^, thanks!

@vadymbokatov could you please check ^, thanks!

Thanks for the heads up. I'm checking the issue. Will let you know when fixed.

This PR 	Staging
Screen.Recording.2024-02-09.at.6.08.48.PM.mov
Screen.Recording.2024-02-09.at.6.10.44.PM.mov
the position of the popover is wrong, looks like related to this PR.

Fixed. Please give it another try. Thanks.

@vadymbokatov thanks! testing now.

LGTM, thanks @vadymbokatov & @blazejkustra

Thanks @getusha for your effort. Also @blazejkustra highly appreciate your help on this.

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.44-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Implement dont fragment option

Thanks for this great library <3
I was interested in using it to make a script to manually discover PMTU, so I wanted to add a feature to set the don't fragment bit. So far I've only implemented windows but I can do the other platforms too if you're happy with the API and interested.

Hi, @johnyburd ! Thank you very much for your PR 🎉 . I have a question: can these parameters be added on Linux to achieve the same goal? Also, have you tested these features?


Selecting Nothing in the dropdown inserts an erroneous expression

https://github.com/enso-org/enso/assets/1436948/e74e5d95-2f8c-4298-afdc-ab239c787203
This is partially related to #7252 but it is a broader issue.
For some parameters, Nothing is a valid value and I think it may be displayed (although ideally we should have a better widget than what shown on the video for types like Integer | Nothing).
Still, whenever we select Nothing in a dropdown, an expression Nothing.Nothing is inserted - but that expression is never valid. I assume the dropdown logic adds an expression of the form Type.Constructor to the node. However, Nothing is a special value where Nothing : Nothing and it's kind of both a value and type at the same time. So there's no Nothing.Nothing and it fails.
Expected behaviour
I think the dropdown logic should be able to insert a Nothing argument from the dropdown. It needs special handling to generate correct code in that special case.

Assigning to @farmaazon for prioritisation, seems p-high, d-easy to me.

See #7468, we need to fix it for all Atom types as well.

Closing in favor of #7468


Allow pagination on arctic admin pages

I wrote some code to allow pagination on the arctic admin pages. It would be nice if this was available all over arctic. Thanks in advance.

can you make a pull request with that code?


Replace the legacy pointer input event handling with PointerPackets

 Issue by jason-simmons
Tuesday Nov 10, 2015 at 00:33 GMT
Originally opened as https://github.com/flutter/engine/pull/2021

With this change we no longer need engine/core/events and its IDL bindings.

jason-simmons included the following code: https://github.com/flutter/engine/pull/2021/commits

 Comment by chinmaygarde
Tuesday Nov 10, 2015 at 01:18 GMT

lgtm. I really like flushing all pending pointer events in one go.
I will update the iOS platform stuff once this lands.

 Comment by abarth
Tuesday Nov 10, 2015 at 02:42 GMT

LGTM

 Comment by abarth
Tuesday Nov 10, 2015 at 02:49 GMT

You'll also need to update //services/sky, which is what builds the sky_viewer.mojo app that runs inside MojoShell.  It's still using the legacy view manager, so you'll probably need to create pointer packets out of whatever input events the legacy view manager is using.

 Comment by jamesr
Tuesday Nov 10, 2015 at 05:32 GMT

sky_viewer.mojo doesn't talk to the legacy view manager (or any other view manager), it talks to native viewport.  The input events it gets are https://github.com/domokit/mojo/blob/master/mojo/services/input_events/interfaces/input_events.mojom instances from the NativeViewportEventDispatcher interface: https://github.com/domokit/mojo/blob/master/mojo/services/native_viewport/interfaces/native_viewport.mojom#L50

 Comment by abarth
Tuesday Nov 10, 2015 at 14:43 GMT

@jamesr Yes, you're right.  At some point, we should probably teach NativeViewportEventDispatcher (and eventually Mozart) about pointer packets.

@jason-simmons This is done now right?

This has landed.


HTTP Snippet Format

Based on this OpenAPI : https://github.com/sebastienlevert/jsonplaceholder-api/blob/main/openapi.yaml
(I made edits to the operation to illustrate some use cases.)
And this operation:
/posts:
    get:
      description: Get posts
      operationId: list-posts
      parameters:
      - name: userId
        in: query
        description: Filter results by user ID
        required: true
        style: form
        schema:
          type: integer
          maxItems: 1
      - name: title
        in: query
        description: Filter results by title
        required: false
        style: form
        schema:
          type: string
          maxItems: 1
      responses:
        '200':
          description: OK
          content:
            application/json:
              schema:
                type: array
                items:
                  $ref: '#/components/schemas/post'

    post:
      description: 'Create post'
      requestBody:
        required: true
        content:
          application/json:
            schema:
              $ref: '#/components/schemas/post'
      responses:
        '201':
          description: Created
          content:
            application/json:
              schema:
                $ref: '#/components/schemas/post'

components:
  schemas:
    post:
      type: object
      properties:
        userId:
          type: integer
        id:
          type: integer
        title:
          type: string
        body:
          type: string
  parameters:
    post-id:
      name: post-id
      in: path
      description: 'key: id of post'
      required: true
      style: simple
      schema:
        type: integer

The format should be the following:

A comment with the HTTP Method and the URL Template. All path and query parameters should be there and marked as required or optional using the URL Template syntax. The description should come from the description of the method in the OpenAPI.
Add a variable for every parameter (path or query) that are required. Leave the value of the variable to be empty and available for the dev to fill, unless there are examples that could show how to use it. The description should come from the description of the method in the OpenAPI.
Have the base URL parameterized as {{url}}

# Base URL
@url = https://jsonplaceholder.typicode.com

### GET /posts?userId={userId}{&title}
# Filter results by user ID
@userId = 1

# Get posts
GET {{url}}/posts?userId={{userId}}

### POST /posts
# Create posts
POST {{url}}/posts
Content-Type: application/json

{
  "title": "",
  "body": "",
  "userId": 1
}

Should we consider some sort of auth as part of the snippet?

@maisarissi we could, based on the auth schemes and have the right Auth headers. What would be your suggestion on automating this?

I would suggest:
1 - create an env file. So instead of the bellow code in the .http snippet file:
# Base URL
@url = https://jsonplaceholder.typicode.com

I would suggest the .http snippet file be:
### GET /posts?userId={userId}{&title}
# Filter results by user ID
@userId = 1

# Get posts
GET {{HostAddress}}/posts?userId={{userId}}

### POST /posts
# Create posts
POST {{HostAddress}}/posts
Content-Type: application/json

{
  "title": "",
  "body": "",
  "userId": 1
}

and having add rest-client.environmentVariables in the settings.json file:
{
    "rest-client.environmentVariables": {
        "$shared": { },
        "remote": {
            "hostAddress": "https://jsonplaceholder.typicode.com",
            "basicAuth": "Basic dXNlcm5hbWU6c2VjcmV0",
            "bearer": " Bearer AAAACSSXSXSV....SDSDSD"
        }
    }
}

This would allow folks to easily add a dev env later and then change easily the env that is calling as the screenshot alongside auth:

We need to remove the url from the http file, because variable definitions in .http files override environment definitions.
2 - For the auth, based in auth scheme described in the OpenAPI description, I believe we should create/add the environment variables in the settings.json. So for example, if the /posts requires Basic auth, the .http file should be:
POST {{HostAddress}}/posts
Content-Type: application/json
Authorization: {{basicAuth}}

{
  "title": "",
  "body": "",
  "userId": 1
}

3 - I would say we should support "basicAuth", "bearer" and "apiKey". For Oauth2, we might want to also use "bearer" where the user would need to use a browser to authenticate and copy the token.
Another possibility would be to have something like this blog where we use info from the settings.json
@name oauth2
POST {{accessTokenUri}}?grant_type=client_credentials&client_id={{clientId}}&client_secret={{clientSecret}}
Content-Type: application/x-www-form-urlencoded

###
GET https://{hostAddress}/api/endpoint HTTP/1.1
Authorization: Bearer {{oauth2.response.body.access_token}}


Error Message: #< CLIXML  The Writer is closed or in error state.

Dear Team,
I am using the posh-ssh module to transfer the files from local machine to SFTP. it always transfers the first file successfully. after that I got the error message for failure.  Is there any workaround available for this issue. or I did any mistake in the given code.
motioned below is the code snippet:
Import-Module Posh-SSH;
$Password = ConvertTo-SecureString "{{SFTP_PASSWORD}}" -AsPlainText -Force;
$Credential = New-Object System.Management.Automation.PSCredential ('{{SFTP_USERNAME}}', $Password);
Write-Output "Credentials were loaded."
Write-Output "Establishing SFTP connection...";
try {
$sftpSession = New-SFTPSession -ComputerName '{{SFTP_SERVER}}' -Credential $Credential -AcceptKey;
} catch {
Write-Output "Connection to SFTP Server failed. Trying again";
Write-Output $_;
$sftpSession = New-SFTPSession -ComputerName '{{SFTP_SERVER}}' -Credential $Credential -AcceptKey;
}
Write-Output "Getting files to transfer...";
$files = Get-ChildItem -Path '{{LOCAL_FOLDER}}';
Write-Output $files;
Write-Output ""
Upload the file to the SFTP path
foreach($file in $files) {
try{
Set-SFTPItem -SessionId ($sftpSession).SessionId -Destination '{{REMOTE_PATH}}' -Path $file.Fullname  -Force -ErrorAction Stop;
Write-Output ($file.FullName + " was successfully transferred.");
Remove-Item -LiteralPath $file.Fullname;
} catch {
Write-Output ("An error occurred for file " + $file.FullName);
Write-Output $_;
}
}
Write-Output "Disconnectig from SFTP Server...";
$sftpSession.Disconnect();
Remove-SftpSession -SftpSession $sftpSession;

I got the error message for failure

You forgot to show the message :)
and
try {
$session = new-sftpsession
}
catch {
$session = new-sftpsession
}

is a bad pattern
# much better
$tries = 3;
do {
  $tries--
  $session = new-sftpsession
} until ($session -or $tries -eq 0)


fix(HTTPSend): Allow HTTPSend commands to be sent in separate sequential queues (SOFIE-3431)

About the Contributor

This pull request is posted on behalf of the NRK.
Type of Contribution
This is a:

Bug fix
Current Behavior

All commands in an HTTPSend device are sent sequentially, ignoring the queueId property.
New Behavior

HTTPSend device again supports the queueId property to allow separate sequential request queues.
Testing Instructions

Ensure that HTTP integration still works as expected
See if multiple parallel HTTP request can be made when using the queueId

Other Information

Status

[x] PR is ready to be reviewed.
[x] The functionality has been tested by the author.
[x] Relevant unit tests has been added / updated.
[x] Relevant documentation (code comments, system documentation) has been added / updated.

Codecov Report
Attention: Patch coverage is 18.75000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 55.71%. Comparing base (81af9f7) to head (84a53cd).

Files with missing lines
Patch %
Lines

...line-state-resolver/src/service/commandExecutor.ts
9.09%
9 Missing and 1 partial :warning:

...te-resolver/src/integrations/quantel/connection.ts
0.00%
2 Missing and 1 partial :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##           release51     #346      +/-   ##
=============================================
- Coverage      55.73%   55.71%   -0.02%
=============================================
  Files            129      129
  Lines          10119    10124       +5
  Branches        2520     2446      -74
=============================================
+ Hits            5640     5641       +1
+ Misses          4477     4106     -371
- Partials           2      377     +375

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Automatically Use 16x sharding

When you have a big bot around 100K servers, the resharder or even startup sharding should ALWAYS automatically optimize to 16x shards. Even if discord recommends a number, we should only use a shard amount that can be divided by 16

Done!


Hash updated config ensuring unique branch

This prevents subsequent runs crashing if older PRs have not been merged.

happy to approve subject to Jorge's review

I'm going to go ahead and merge this as it just affects the development tooling, and not the scientific code. It also always runs on GitHub's servers so portability shouldn't be an issue.


Add CheckDeps, InitDeps, CloseDeps helper

The Deps pattern in Plugins is a powerful way to allow
users to wire in alternate implementations for things the Plugin
uses. In addition to the flexibility it offers, it also makes
it much much easier to Mock and test.
Unfortunately, there are several mistakes its easy to make with Deps:

Making a Deps field private (lowercase) which precludes wiring in
an alternate implementation
Failing to set a Default value for Deps in options.go

CheckDeps checks for all of these mistakes. It is suitable to
be run in the NewPlugin(...) in options.go as a final check before
returning a new Plugin to insure its ready to Go :)

InitDeps - Runs Init() on all Deps implemented with Plugins
Deps should be interfaces, they do not have to be Plugins
InitDeps loops through all of the fields in Deps, and if they
are Plugins, it Init()'s them.

CloseDeps - Runs Close() on all Deps implemented with Plugins
Closes all Deps of the given plugin if they themselves
are idempotent.Plugins

Note to reviewer: #166 should be merged first as this is based on it.

Considering the size of check_deps, would it make sense to make a checkdeps package within helpers? If there is only going to be one helper, perhaps we can rename helper to checkdeps?

@fkautz in response to:
Considering the size of check_deps, would it make sense to make a checkdeps package within helpers? If there is only going to be one helper, perhaps we can rename helper to checkdeps?

I'm quite warming to the idea of doing separate package for CheckDeps, InitDeps, CloseDeps, and GetDeps (I split out GitDeps in a subsequent PR to avoid a dependency loop).  Lets hold this patch while I split these up.

OK, I think this is good to go now.


The "Build with Rollup" documentation is broken

Which package(s) are affected?
Lit Core (lit / lit-html / lit-element / reactive-element)
Description
Trying to follow the instructions for building-with-rollup triggers multiple errors:

"While loading the Rollup configuration from "rollup.config.js", Node tried to require an ES module from a CommonJS file"
Solution:  Rename rollup.config.js to rollup.config.mjs

"The requested module '@web/rollup-plugin-html' does not provide an export named 'default'"
Solution:
import { rollupPluginHTML as html } from "@web/rollup-plugin-html";

The requested module '@rollup/plugin-terser' does not provide an export named 'terser'
Solution:
import terser from '@rollup/plugin-terser';

TypeError: minifyHTML is not a function
Solution:
import pkgMinifyHTML from 'rollup-plugin-minify-html-literals';
const minifyHTML = pkgMinifyHTML.default

Reproduction
Follow the instructions at building-with-rollup
Workaround
See above
Is this a regression?
No or unsure. This never worked, or I haven't tried before.
Affected versions
2.x
Browser/OS/Node environment
node v20.11.0
npm 10.2.4

Thank you for the report! Transferred issue to the lit.dev repo as this is a documentation issue.


Column stats for Timestamp are not saved properly

What went wrong?
When trying to index TimestampType and add min and max values for the columns, we spotted a weird behavior. The transformations specified by the user were not written correctly in the Delta Log.
How to reproduce?
1. Code that triggered the bug, or steps to reproduce:
Here you have a test for Timestamp that detects if the transformations are properly saved.
    val data = Seq(
      "2017-01-03 12:02:00",
      "2017-01-02 12:02:00",
      "2017-01-02 12:02:00",
      "2017-01-02 12:02:00",
      "2017-01-01 12:02:00",
      "2017-01-01 12:02:00")
    val df = data
      .toDF("date")
      .withColumn("date", to_timestamp($"date"))
    val schema = df.schema

    val minTimestamp = df.selectExpr("min(date)").first().getTimestamp(0)
    val maxTimestamp = df.selectExpr("max(date)").first().getTimestamp(0)
    val columnStats = s"""{ "date_min": $minTimestamp, "date_max": $maxTimestamp }"""

    // scalastyle:off
    println(columnStats)
    val qid = QTableID("t")
    val revision =
      SparkRevisionFactory.createNewRevision(
        qid,
        schema,
        Map(QbeastOptions.COLUMNS_TO_INDEX -> "date", QbeastOptions.STATS -> columnStats))

    val transformation = revision.transformations.head
    transformation should not be null
    transformation shouldBe a[LinearTransformation]
    transformation.asInstanceOf[LinearTransformation].minNumber shouldBe minTimestamp
    transformation.asInstanceOf[LinearTransformation].maxNumber shouldBe maxTimestamp

2. Branch and commit id:
main at 35bc1f0f1a5d8ebf20f2eb371cfe4b8a8ca6244a
3. Spark version:
3.3.0
4. Hadoop version:
3.3.4
5. How are you running Spark?
Spark runs locally.
6. Stack trace:
If you execute the test above, the following error appears:
EmptyTransformation() was not an instance of io.qbeast.core.transform.LinearTransformation, but an instance of io.qbeast.core.transform.EmptyTransformation

Seems like the problem is caused by:

Timestamp is not expressed in the right format. Should be written according to JSON rules for timestamps. Otherwise, the schema is broken and a "_corrupted_record" is loaded into the SparkRevisionFactory.
Correct parsing of min and max values in LinearTransformer. Even though we correctly specify the value in JSON, it would be loaded as a String. To solve it, we have to catch the specific case and handle it properly. Like:

 case d: String if dataType.name == "TimestampDataType" || dataType.name == "DateDateType"

There is a less painful solution. We can use spark options to parse JSON timestamp correctly:
        val df = spark.read
          .option("inferTimestamp", "true")
          .option("timestampFormat", "yyyy-MM-dd HH:mm:ss.SSSSSS'Z'")
          .json(ds)


Fix arg doc

Description of Change
I forgot to update the arg name in the doc str so this does that
Issues Resolved

closes #

Testing Procedure

PR Checklist
Did you remember to do the below?

[n/a] Add unit tests to verify this change
[n/a] Add an entry to CHANGELOG.md describing this change
[x] Add docstrings for any new public parameters / methods / classes

Also a unit test should be changed if a function argument has changed, I see a change only in one src file!

The existing unit test has the correct arg name, the only change here was the docstring which was incorrect.


⚠ Bofrost.at has degraded performance

In 846c765, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1940 ms

Resolved: Bofrost.at performance has improved in afa724f after 6 minutes.


Integration tests executed on a real deployment as part of the CICD  - Environments

Same as for #1220.
This issue is to track the progress for the Environments module.
It has its complications because we need to work with real AWS accounts that need to be bootstrapped and trusting the real deployment account.
Design will follow

In #1334 some basic tests that create/delete/modify an environment were added but more should be added to  cover the most commonly used functionality around environments

Completed!


Fix incorrect slicing during application of wavelet filter

Due to some slicing errors, the wavelet filter resulted in a 90deg rotation and a mirroring along one axis. This resulted in that the labelmaps did not align with the ROI anymore, causing the wavelet features to be incorrectly calculated.
This PR addresses this error by recoding the slicing during wavelet decomposition. Results have been checked visually. I'll add some examples later.

Original

LLL: Image is flipped and rotated --> This is due to incorrect slicing

LLH: Bottom slice is somehow 'copied' / filtered and inserted over the top slice --> This is due to the wavelet transform by the pywavelet package, will look into this further...

Tests of the pywavelet functions (using Haar wavelet):
Test1, length = 8
In: [5 4 3 0 0 0 0 0]
Out-H: [ 6.364   4.9497  2.1213  0.      0.      0.      0.      3.5355]
Out-L: [ 0.7071  0.7071  2.1213  0.      0.      0.      0.     -3.5355]
Test2, length = 6
In: [5 4 3 0 0 0]
Out-H: [ 6.364   4.9497  2.1213  0.      0.      3.5355]
Out-L: [ 0.7071  0.7071  2.1213  0.      0.     -3.5355]
Test3, reverse
In: [0 0 0 0 0 3 4 5]
Out-H: [ 0.      0.      0.      0.      2.1213  4.9497  6.364   3.5355]
Out-L: [ 0.      0.      0.      0.     -2.1213 -0.7071 -0.7071  3.5355]
Test4, reverse with extra padding
In: [0 0 0 0 0 3 4 5 0 0]
Out-H: [ 0.      0.      0.      0.      2.1213  4.9497  6.364   3.5355  0.      0.    ]
Out-L: [ 0.      0.      0.      0.     -2.1213 -0.7071 -0.7071  3.5355  0.      0.    ]
Test5, discreet instead of stationary wavelet transform
In: [5 4 3 0 0 0 0 0]
Out-H: [ 6.364   2.1213  0.      0.    ]
Out-L: [ 0.7071  2.1213  0.      0.    ]
The value of 3.5355 is equal to 1/sqrt(2) * (5 + 0), i.e. looks like it wraps around for the last index:
1/sqrt(2) * (index[-1] + index[0]) for L, 1/sqrt(2) * (index[-1] + index[0]) for H

Got a response from pywavelets: This duplication 'error' is intentional, as it is their way of handling edges: swt is forced to periodization, which appends copies of the array.
Furthermore, in swt, the wavelets overlap (i.e. first index in Haar is calculated using inidces 0 and 1, 2nd using 1 and 2, etc.), but with dwt there is no overlap. If I understand correctly, this is different from just upsampling the filter coefficients, correct?
I will look at the matlab code to see if I can find how the wavelets were calculated before...


Display issue - allow for text wrapping.

For example, asset types under domains are hidden in the pane.

We need to find a better way to handle long element names

@previnWong Let's do a ... on the names after 30 characters with no breaks if we don't plan on expanding the side panel and 50 if we do plan on expanding the side panel.
Additionally, the long domain names cause an issue when using the split workspace option it cuts off the heart and X.

Let's strip out the properties icon and the statistics icon for this release and remove the favorite option.


Kduffy small enhancements

The Value Class parameter becoming optional for the getWindowValues/getWindowValuesUrl parameter list meant it needed to be moved after the start and end indexes as they're still required. This is a breaking change for anyone using unnamed arguments when calling into this function, such as how the getWindowValues function calls the getWindowValuesUrl function.
I also added the now deleted local testing script to the gitignore so that people can still run that script locally for testing and not worry about accidentally checking it back in

Looking at the past minor version bumps, they've all been pretty big things. There's been some small breaking changes in the past  that only resulted in a build increment and a history note. I think the upcoming community id header changes should be a minor version increase, though.


Core materials needed. Project idea refined.

Have to build the layout (header and footer).
Home page.

done!


BDD test appears to not be running anymore when in connect.tests

moved this back out into BDD folder.


Show Grafana Integration in docs

Description:
https://github.com/envoyproxy/gateway/pull/1745 adds docs for integrating envoy proxy metrics into prometheus.
It would be great to also include grafana integration in the docs with a pre built dashboard
seeing an old one here https://grafana.com/grafana/dashboards/6693-envoy/
[optional Relevant Links:]

Any extra documentation required to understand the issue.

@arkodg I might be able to help with this one.
Is there a preference for having this doc be standalone from existing docs like #1823  (as that already includes a Grafana instance)?
If yes, a few options for installing Grafana come to mind. Theres the grafana-operator which can be installed via helm, and there's the Grafana instance included as part of kube-prometheus.
The Proxy Observability doc doesn't include the prometheus piece, just exposing the prometheus endpoint.
Would that be required as well?
Or is this new doc much simpler, like how to import a relevant dashboard, like https://grafana.com/grafana/dashboards/6693-envoy/, into your existing Grafana instance?

thanks @david-martin, prefer if this a stand alone doc
dont have a strong opinion on the prom and grafana deployment
also ccing @psinghal20 here who built out some envoy grafana dashboards that will be handy for this integration

Hi @david-martin @arkodg, I can help with this if there is no doc already in the works. We have updated the available Grafana dashboards to be used with EG, we can provide those as sample dashboards for users.


Azure SDK Review - [Stable SDK for Playwright-DevDiv-Service]

New SDK Review meeting has been requested.
Service Name: Playwright-DevDiv-Service
Review Created By: Manivelu Rajendran
Review Date: 01/06/2025 02:05 PM PT
Release Plan:1533
Hero Scenarios Link: here
Architecture Diagram Link: here
Core Concepts Doc Link: here
APIView Links: .NET, Javascript,
Description: Microsoft Playwright Testing is an Azure service built on Playwright OSS that allows users to run tests on browsers hosted and managed by the service. It also enables publishing test results and artifacts to the service, which can then be accessed and analyzed through a dashboard.
To facilitate authentication and connections to cloud-hosted browsers for running tests and to publish results and artifacts to the service, we have developed a service package. This package needs to be installed alongside Playwright OSS to use the service effectively. It is available in JavaScript and .NET as most of Playwright OSS and Playwright service users use these two languages.
The service is currently in public preview, with General Availability (GA) planned for January. This review focuses on the GA release of the service package.
Detailed meeting information and documents provided can be accessed here

Meeting updated by Manivelu Rajendran
Service Name: Playwright-DevDiv-Service
Review Created By: Manivelu Rajendran
Review Date: 01/06/2025 02:05 PM PT
Hero Scenarios Link: here
Architecture Diagram Link: here
Core Concepts Doc Link: here
APIView Links: .NET, Javascript,
Description: Microsoft Playwright Testing is an Azure service built on Playwright OSS that allows users to run tests on browsers hosted and managed by the service. It also enables publishing test results and artifacts to the service, which can then be accessed and analyzed through a dashboard.
To facilitate authentication and connections to cloud-hosted browsers for running tests and to publish results and artifacts to the service, we have developed a service package. This package needs to be installed alongside Playwright OSS to use the service effectively. It is available in JavaScript and .NET as most of Playwright OSS and Playwright service users use these two languages.
The service is currently in public preview, with General Availability (GA) planned for January. This review focuses on the GA release of the service package.
Detailed meeting information and documents provided can be accessed here


Double width characters break alignment in the tabline

environment

vim: NVIM v0.4.0-367-gef5037e7f
vim-airline: latest
OS: Arch Linux
Have you reproduced with a minimal vimrc: no
What is your airline configuration:

  let g:airline_extensions += ['tabline']

if you are using terminal:

terminal: Konsole
$TERM variable: xterm-256color
color configuration (:set t_Co?): ???
if you are using Neovim:
does it happen in Vim: ???

actual behavior
I am using the devicons plugins and have set some custom filetype icons. For yaml files I have set the nf-mdi-yammer icon. Also, I have set up the tabline to display also for buffers. When I open a yaml file, the tabline gets a bit messed up:

The icon for gibson.yml displays on the filetypes.vim tab.

Does setting ambiwidth change anything?

I set ambiwidth=double but it didn't help.

well, most likely it is a vim bug then. I suggest using a different symbol than. You can also try to reproduce using a minimal vimrc file and file an issue for the vim project.

Alright, I will do that, thanks!


server MOTD implementation

server can now display a MOTD
configured in variables of the anonchat_server.dart file
MOTD sent as a v2-style packet

will implement a turn-off toggle in server settings if this looks good enough

actually implemented it right now, it's like 2 lines of code

if i don't get reviews until 6 PM moscow time i'm pushing it to main

@KrutosVIP review the pr you bastard


Link OLL and PLL to algdb.net

Hi. Is it possible to link the OLL  and PLL  to algdb.net?
In solve details i will get OLL 19 and it is nice to have direct link to http://algdb.net/puzzle/333/oll/oll19
Thanks a lot to share this project!

I just wanted to comment to say:

I absolutely LOVE this project. I can't stop practicing solves with it.
One thing I HATE.... I can't get around learning G-perms now.  ;)

Hey , I got the code working on my own system. I have been able to add these hyperlinks and I'd like to create a pull request to close out this issue. I have never done a pull request before, so I would like some instructions please. Thanks!


Fix encrypted buttons under Python 3

Avoid the b'' decoration under Python 3 when mixing binary (encrypted button contents) and normal strings. Fix the examples in the documentation for encrypted buttons to use the encrypted form.

Thanks so much for the PR! This code needs tests (tests that fail without the patch) in order to be merged.

Hi Luke,
Sorry, I’m not ignoring you - I’m just prioritising finishing some other things off first.
Jon

On 14 Feb 2018, at 16:53, Luke Plant<EMAIL_ADDRESS>wrote:
Thanks so much for the PR! This code needs tests (tests that fail without the patch) in order to be merged.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/spookylukey/django-paypal/pull/199#issuecomment-365671360, or mute the thread https://github.com/notifications/unsubscribe-auth/AWPEgsXqkpQEq4ZrhRtzvhBZ0FxHo4DXks5tUw9zgaJpZM4SFDDH.

BTW, there is no need to bump version numbers, I'll do that when I release.

Test written (bug fixed - oops), doc updated (M2Crypto is now Python3 capable), and .DS_Store added to .gitignore (for Mac users).

Would you be able to fix the merge conflicts? It looks the main problem is the version number bumps - just drop all your changes in that regard, and put docs the "under development" heading. Thanks!

I attest the issue. PayPal checkouts would have stopped working after migrating our codebase to python 3. How can we contribute tests to have this patch merged?

I think I've adjusted the notes & versioning to merge correctly now.

Careful, the original patch is incorrect. ".decode()" should be appended, not ".encode()".

The revision 'Add test for encrypted buttons' includes the correction to .decode() - tests are a good thing!

The automated tests aren’t working - m2crypto needs installing. Is the correct fix to add:

install m2crypto>=0.29
just before:
install tox>=2.1
in travis.yml?

@JonathanRoach - you should instead modify tox.ini to add the dependency under the deps = section. You can test locally by doing something like:
$ pip install tox
$ tox -e py27-django111-tests-usetztrue -e py35-django200-tests-usetztrue

(i.e. one Python 2 and one Python 3 environment).
I normally use exact versions in tox.ini (e.g. m2crypto==0.29 rather than m2crypto>=0.29), so that we don't get unexpected failures on Travis caused by some new incompatibility in a recent version of something.

Looks good - thanks so much!