Update logo

Changes:

Added Sedge logo and icon to documentation

Types of changes

[X] Documentation Update

Codecov Report
Patch and project coverage have no change.

Comparison is base (09354d9) 86.68% compared to head (17c006f) 86.68%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #289   +/-   ##
========================================
  Coverage    86.68%   86.68%
========================================
  Files           76       76
  Lines         4506     4506
========================================
  Hits          3906     3906
  Misses         515      515
  Partials        85       85

Flag
Coverage Δ

unittests
86.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Fix #289


markdown: Require double-asterisk around all mentions.

This enforces ** around all the mentions(excluding group mentions)
including "at-all" and "at-everyone" mentions.
Covered above changes in tests and added some tests
other corner cases.
In case I'm missing something as a followup please tell me.
Fixes: #8143.
(Travis might be failing but CirlcleCI is passing.)

@shubhamdhama this looks great!  I posted a few quick comments.

Updated comment and commit message.

Merged, thanks @shubhamdhama!


images --filter=non-existent inconsistent (docker vs. nerdctl)

Description
docker images --filter since=non-exists-image; echo $?
Error response from daemon: No such image: non-exists-image:latest
1

nerdctl images --filter since=non; echo $?
REPOSITORY    TAG    IMAGE ID    CREATED    PLATFORM    SIZE    BLOB SIZE
0

This recently got fixed because of a panic - in #3469 - though the tests being currently disabled for Docker made this go under the radar.
Tagging @xyz-li in case you are interested in revisiting.
Steps to reproduce the issue
na
Describe the results you received and expected
na
What version of nerdctl are you using?
main
Are you using a variant of nerdctl? (e.g., Rancher Desktop)
None
Host information
No response

/assing

docker images --filter since=IMAGE_ID does not consistent with docker too.


Use rummager for latest documents pages

This change enables the latest documents page and atom feed to render results using rummager for topical events, world locations and organisations (latest orgs page has now been replaced by finder frontend pages although the Whitehall page is still accessible by url).
We need to use Rummager results instead of Whitehall's local database as documents published by Content Publisher get indexed to the govuk index and would not be accessible from the database.
As part of this work we investigated whether we needed to also retrieve translated documents from the Whitehall database in cases where the locale is not English (Rummager currently doesn't support locales). Our investigation concluded that there are no apparent cases where the locale is set to a foreign language; for example there don't seem to be any instances where a locale param is passed to the Latest Controller. A manual check on live GOV.UK also concluded that links from translated world location news pages (e.g. http://www.gov.uk/world/afghanistan/news.dr) to the latest finder also don't
pass any locale data, and so the results on the page are English only. Consequently we've decided to maintain this current behaviour and only provide English-language Rummager results.
Trello:
https://trello.com/c/aXQWMcmw/406-change-topical-events-latest-pages-to-use-rummager
https://trello.com/c/62hDsXHF/438-change-world-location-latest-pages-to-use-rummager

@kevindew Yes to all of the above :)

@emmabeynon woop woop 🚢 :shipit: 🚀


Spend - Add SHAmory

This is a kids card game that teaches how mining and block rewards work.
They don't accept altcoins on the site and the game is bitcoin-only.

Thanks!


initial TSP conversion of Microsoft.HybridContainerService

ARM (Control Plane) API Specification Update Pull Request

Tip: overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

 Click here to see the details of Step 1
Breaking changes review (Diagram Step 1)
If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

 Click here to see the details of Step 2
ARM API changes review (Diagram Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

 Click here to see the diagram footnotes
Diagram footnotes
[1] ARM review queue (for merge queues, see [2])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see Getting help section below.

Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!

[ ] New API version. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix swagger quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[ ] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[ ] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the Diagram Step 2, "ARM API changes Review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

tsp compile main.tsp fail:

error duplicate-symbol: Duplicate name: HybridIdentityMetadata

model HybridIdentityMetadata (HybridIdentityMetadata.tsp:16:7)

interface HybridIdentityMetadata (HybridIdentityMetadata.tsp:24:11)

If you manually correct Duplicate name and then execute tsp compile, the following new problems will occur:

error @typespec/rest/duplicate-parent-key: Resource type 'ProvisionedClusterUpgradeProfile' has a key property named 'default' which conflicts with the key name of a parent or child resource.

I don't see any changed swagger files in the PR. Missing?

@tadelesh, don't think I have permission to update the PR. Can you:

remove resource.json
check in the generated openapi.json
remove the two existing json spec and update the readme.md with the openapi.json
try add @doc for the enum values to get rid of the warnings.

@tadelesh, don't think I have permission to update the PR. Can you:

remove resource.json
check in the generated openapi.json
remove the two existing json spec and update the readme.md with the openapi.json
try add @doc for the enum values to get rid of the warnings.

Updated but need verification.


F12 into 3rd party components from Blazor

This issue has been moved from a ticket on Developer Community.

As shown in the image below, it would be nice to be able to F12 (Go To Definition) of third party components. Currently the only way to do this in a blazor razor file is to declare it in the @code or C# area of the razor file.
! [image.png] (https://aka.ms/dc/image?name=B72588c7336c347559b6f90de9977c78c637678539879759043_20210921-164627-image.png&tid=72588c7336c347559b6f90de9977c78c637678539879759043)

Original Comments
Feedback Bot on 9/21/2021, 11:12 PM:
We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.

Another report: https://developercommunity.visualstudio.com/t/External-blazor-component-disassemble/1630125

https://github.com/dotnet/razor/pull/7974 fixes this for Go To Def from component attributes at least


Galaxy download simulation with native Linux titles ignores split logic

I just tested updating x4 foundations with Galaxy simulation as follows:
lgogdownloader --galaxy-platform l --subdir-galaxy-install x4_foundations --galaxy-install<PHONE_NUMBER>

And I noticed that it downloaded a few split files like
01.dat.split00
01.dat.split01

which normal installer concatenates into single 01.dat. I suppose this split / cat logic is currently a missing feature?

I didn't know that split files were even a thing as I hadn't come across them yet.
Have you seen them in other installers?
I've started writing some preliminary code for handling split files.
I'll try to get some code written in the next few days and create new branch for you to test if it works.

Yes, I've sen them for example in TW2. Basically, when files are above certain size, Mojosetup can't handle them for some reason (may be something is stuck at 32-bit there), and GOG split files as a hack for such cases.

In cases when split files occur, you'll find in support subdirectory something like this:
split_files

In case of TW2 it contains:
./game/CookedPC/pack0.dzip
In case of X4: Foundations:
./game/01.dat

In case of The Bard's Tale IV:
./game/BardsTale4/Content/Paks/pakchunk2-LinuxNoEditor.pak
./game/BardsTale4/Content/Paks/pakchunk0-LinuxNoEditor.pak

And so on. May be you can use that split_files as the source of info, which files require concatenation.
See also GOG's scripts like
postinst.sh
preuninst.sh

I own TW2 so I have at least one game I can test my code on.

I've created splitfiles branch which has support for split files.
Let me know if there are any issues with it.
I decided not to read split files from data/noarch/support/split_files but detect them using regex.
Hopefully this doesn't cause any issues.
It deletes the split file parts after combining so user doesn't need to keep lots of unnecessary data around.
I also made it able to detect if previously combined base file is the same as split file. Meaning that it can do very basic version checking on split files.

I decided not to read split files from data/noarch/support/split_files but detect them using regex.
Hopefully this doesn't cause any issues.

It's probably better to read data/noarch/support/split_files, to avoid potential name conflicts or any future changes to the naming scheme. Implicit detection method will probably work most of the time, but it's just less reliable.

d386bde improves split file support by reading the base file names from data/noarch/support/split_files

Split file support is now merged to master c9f9882


ERRAI-1017: Replace history token on navigation initialization.

Replace history token instead of push on navigation initialization.
This one fixes duplicated history entries after loading gwt host-page.

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

Hi @axls,
Thanks for submitting this, but we do not usually take changes directly to maintenance branches. As per our contributor guidelines we prefer contributors to send PRs to our master branch, from which we may back-port the change in the future.
Could you please close this and resubmit your PR to our master branch?

@mbarkley

we prefer contributors to send PRs to our master branch

I missed this one.

Could you please close this and resubmit your PR to our master branch?

Sure. Closing this PR.


Script the creation of the Pipelines in AzDo

Provide a script for the creation of the Pipelines in Azure DevOps
The solution will provide an option for automatd provisionning of the pipelines

@Adeelku I have a collection of scripts that create pipelines, manage service principals & service endpoints, handle management groups, etc. - all items related to ADO setup (scripts the items mentioned in onboarding). Would you like me to take this issue for implementation or do you already have it done?

@skeeler , If you already have the scripts, please do - as I was planning to create them | Cheers

This enhancement is addressed by #150


Organizational tasks

[ ] Create Scrutinizer group
[ ] Create Packagist user
[ ] Create organizational Gitter room
[ ] Countributing doc

I can do all of these if you would like to me to do it.

I meant an organizational Gitter room, that one is for the main repo. I can't create it since I am not an owner.

We now have both.


Custom module that is persistent

I'm trying to figure out how custom modules works.
What should I do if I want make a custom script that returns EXAMPLE and that message should stay fixed into the bar?
Example of test-command:
#!/bin/sh
printf "message"

Example of custom module:
"custom/test": {
  "format": "{}",
  "exec": "test-command",
  "interval": 10 // Do the command every 10 seconds
}

For now, if I don't put a sleep at the end of the bash it won't work (I cannot see the module, and I receive the message test just stopped, is it endless?).

Now fixed with 0c9edb0c4b79be195a090df8b2e78ca3f4f2fbc3
When interval is omited and the script exit normally, i don't hide the module

Can't this also be done with
"format": "Static text"


Unsure of correct usage of feedback connection

I wrote a small script to test the handling of errors using grocer’s feedback mechanism. If I use a production token, it is correctly sent and received.
To test for feedback, I send a notification to a development token using the production gateway, and ask the production feedback service for errors. Sadly, I don’t get any feedback from @feedback.each do |attempt|:
require 'grocer'

class Pusher
  def connect
    @pusher = Grocer.pusher(
      certificate: "apple_push_notification_prod.pem",
      gateway:     "gateway.push.apple.com",
      port:        2195,
      retries:     3
    )
  end

  def send(token)
    notification = Grocer::Notification.new(
      device_token:      token,
      alert:             "We should get feedback",
      badge:             42
    )
    @pusher.push(notification)

    @feedback = Grocer.feedback(
      certificate: "apple_push_notification_prod.pem",
      gateway:     "feedback.push.apple.com",
      port:        2196,
      retries:     3
    )
    @feedback.each do |attempt|
      puts "Device #{attempt.device_token} failed at #{attempt.timestamp}"
    end
  end
end

push_client = Pusher.new
push_client.connect
# Send to a development push notification token (token substituted for this snippet)
push_client.send("517ff994ea1a432a3fb8959017fd31bd052ba2bed3ff7e86dd4f44100c3163ca")

Am I using the feedback mechanism incorrectly (grocer 0.6.0)?

@j4zz, sorry for just getting back to you. I'd missed this issue in my inbox and just discovered it. Sending a development token to the production gateway is an invalid notification and so [APNS will write an error error-response packet](https://developer.apple.com/library/mac/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/Chapters/CommunicatingWIthAPS.html#//apple_ref/doc/uid/TP40008194-CH101-SW11] on the "push" connection and then close the socket. My bet is that if you read off the push socket after sending a token from a different environment you'll find an error packet, and it will report the token was invalid (status code 8). You can use Grocer::ErrorResponse to verify that.
I'm going to close this issue as I'm nearly certain that's what you're seeing. Please feel free to re-open it if that's not the case. Thanks!


[Combat Master] v.2.34: fix one-click install + new version

update script to 2.34, from script author @vicberg's repo
v.2.34:  numerous fixes surrounding targeted spells
fix issues with files, should make the API work again from install menu(v.2.33 was broken)
made older versions v.2.33, v.32 and v.2.22 available, like most other API do
related forum comment

Considering the current install isn't working, nor is the option to select older versions, my update should only be able to make the situation better, even if it isn't guaranteed to work.

I believe the one click install might be related to the Authors in the array bracket notation when only one author is listed. I'll be on the lookout if your fixes here don't resolve this issue @Anduh

@Reonin the update didn't seem to work, it shows the following error when installed, regardless of what version you try to select:
No such file or directory @ rb_sysopen - /home/symbly/www/d20-app/apiscripts/CombatMaster/2.33/CombatMaster.js
I did create that folder and placed that version of the script in it, but the error message shows up even when I try to change it to v.2.22, which in theory shouldn't care if it's some weird thing that happen to be hard-coded into the script in some way.
More discussion and people with this issue can be found in this forum thread.
There should also be an open ticket on this made by the scripts author @vicberg .

Yeah, I noticed when the changes hit live this week these cases didn't get resolved. 😞 I believe we will be doing a deeper dive on what's breaking these one clicks but I don't have a firm timeline on when that will be just yet.

I'll submit an update to the script's description to be copy the direct version from Vicberg's repo until things start to work.

Have you checked into this issue at some point? I did submit a PR for a newer version of the API, but that didn't appear to have solved anything either.

It's working now.  I didn't do anything.  Looks like someone did.

On 12/12/2020 1:16 PM Andreas J<EMAIL_ADDRESS>wrote:

Have you checked into this issue at some point? I did submit a PR for a newer version of the API, but that didn't appear to have solved anything either.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/Roll20/roll20-api-scripts/pull/1105#issuecomment-743817472 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AJVRTLCHRZRTP23OCB6M7XDSUPFQ7ANCNFSM4SQW6SQA .

Cool, so Roll20 seems to have fixed it, as nobody have updated the Dropdown version since I did last time. Guess I could submit your latest version to Roll20 so the CombatMaster through it is up-to-date.
Or do you wanna try submit and update following the format I did?


Fixed design for the About Us Page

Pull Request Template

Please provide all of the details below. Pull requests missing any of the information below will be closed!
Providing the issue number/url helps us identify the problem being solved and keep the issues tab clean and tidy

What issue does this fix?.
Fixing broken design for the About Us page.
Summarize what this PR fixes:-
The About Us page had a broken design with a broken navbar and footer and white padding all around the content. The design has been fixed and the broken navbar issue solved.
What ISSUE NUMBER does this fix?
Fixes #964
https://github.com/zero-to-mastery/Keiko-Corp/issues/964
Checklist
(Add an x between the brackets to check the items)

[x] I have summarize what this PR fixes above
[x] I have provided the issue ID/URL above
[x] I have not added Bootstrap or jQuery and used correct styling guide.
[x] This PR fixes only the issue mentioned above (create separate PRs for separate issues)
[x] I was the first one to claim the issue or I created the issue - I created the issue

There is a conflict in your page if you could take a look at that please.


Fixes mat4x4 projection in orthographic projection tutorial (3D Section)

It seems there is a misalignment between what the code snippet of the projection matrix shows and whats in the runnable example. Lost a considerable amount of time trying to understand where the issue is until I saw that the depth is divided by by half and 14th element of the projection matrix is 0.5 as instead of 1.0.

Here is the result of the bugged projection matrix:
https://github.com/user-attachments/assets/3fa331d1-da4c-4048-97da-20fde151b922


some question about Mathwriting

Hello! Thanks for your works.
First, I want to know how to find the Bounding boxes for the synthetic data.
Secondly, Can you share how to get the Bounding boxes?

Hello! Thanks for your works. First, I want to know how to find the Bounding boxes for the synthetic data. Secondly, Can you share how to get the Bounding boxes?

Hi, you may refer to pen-simulator for a similar implementation built on top of MathJax. MathWriting mentioned they use DVI files generated by latex compiler.

Thank you for the question!
In the MathWriting dataset there is a file synthetic-bboxes.jsonl that contains bounding boxes. Description of the file is in documentation. The code to visualize bounding boxes is provided in colab.
The algorithm to create the bounding boxes is as follows:

We take an expression and use the Latex compiler to create a DVI file – a binary file containing a list of glyph references (font and character in the font) with their position on the page, as well as black rectangles (rules) used to represent fraction bars and the middle of stretchable symboles (e.g. \sqrt). Note that the file only specifies the position of glyphs, not their size nor their appearance which needs to be read from external font files. A more detailed explanation can be found at https://en.wikipedia.org/wiki/Device_independent_file_format and https://www.mn.uio.no/ifi/tjenester/it/hjelp/latex/dvi.pdf.
We then extract glyph positions and identities from the DVI file. Example:

Input: \sqrt{\frac{1}{2}}
The extracted information would be similar to (numbers are arbitrary, one DVI element per line):

font=cmex10, character=114, h=10000, v=10000
RULE h=15000, v=9000, width=2000, height=200
font=cmr10, character=49, h=18000, v=5000
RULE h=16000, v=8000, width=1500, height=200
font=cmr10, character=50, h=18000, v=000

We align the Latex tokens (e.g. \sqrt) from the input expression and the dvi content using a hand-built mapping between tokens and sequences of DVI elements. The output of this alignment phase for the above example would look like:

\sqrt: font=cmex10, character=114, h=10000, v=10000 ; RULE h=15000, v=9000, width=2000, height=200
1: font=cmr10, character=49, h=18000, v=5000
\frac: RULE h=16000, v=8000, width=1500, height=200
2: font=cmr10, character=50, h=18000, v=000
Note that the \sqrt token corresponds to two dvi elements (a glyph for the hooked part of the square root (√), and a horizontal line.).
Some tokens have more, e.g. '\big(', which has three.
3. For each token we then compute the bounding box that corresponds to the set of dvi elements associated with it. This phase requires reading the height, depth and width for each glyph (e.g. cmr10, 49) from TFM font files.


fix(client): import tfunction from i18next in show components

Checklist:

[x] I have read and followed the contribution guidelines.
[x] I have read and followed the how to open a pull request guide.
[x] My pull request targets the main branch of freeCodeCamp.
[x] I have tested these changes either locally on my machine, or GitPod.

Ref https://github.com/freeCodeCamp/freeCodeCamp/pull/49800
TFunction is local type in react-i18next, so this aims to import it from where it's valid

Good once conflicts are resolved


In admin, filters do no work when using pivottable.js

This is related to #206
With the regular version of pivottable.js, for instance on http://nicolas.kruchten.com/pivottable/examples/mps_agg.html , when you select the dropdown menu for a dimension  (for example Province), you get the possibility the select some values and filter results.
You don't have such a possibility on the version that we have, for example on pivot.html: the dropdown menus are not active.
@serverfire Can you fix this?

@libreliodev I fixed it.
Part of bugfix was for pivottable project.
So i have listed dist files for pivottable below. Please copy them in ./bower_components/pivottable/dist/ for now.
I'll also send a pull request for fixing this bug on pivottable project.
Thank you

https://www.dropbox.com/s/uzw95vkkzjf7ib0/pivot.min.css?dl=0
https://www.dropbox.com/s/9x9w9931nzyksvo/pivot.min.js?dl=0

Source code of fixes has been saved in https://gist.github.com/libreliodev/14444a9a3955f801977c

Successfully tested.
Many thanks @serverfire


Make istio-proxy-init and istio-proxyv2 as global image

Bug description
The default generated lookup cluster1.icp.intra.szh.loc:8500/ibmcom/istio-proxy_init-ppc64le:<IP_ADDRESS> there is the error unauthorized: authentication required.
We have provided a document to ask for the user to create the imagepullsecret manually - https://www.ibm.com/support/knowledgecenter/SSBS6K_3.1.2/manage_cluster/istio.html#deploy_app
But it is not user friendly.
Expected behavior
it is working without manually creating imagepullsecret
** Suggestions **
Make istio-proxy-init and istio-proxyv2 as global image
@gyliu513 Any comments?

Sorry. Open in wrong area.


Fix order of generated code to match openapi schema

Params and attributes change order even though schema doesn't change.
Makes a mess in git commit.

Sorting params, Field params

elements of Union


Book 2 (version 2022-04-01), Section 12.2.4, Page 498-500: Missing Listing reference

fixed, thanks


Loading is false using 'no-cache'

Why when I reload the page loading is false?
When I use fetchMore, loading changes to true, but on the first load, loading is false
I'm using 'no-cache' option
defaultOptions: {
    $query: {
      fetchPolicy: 'no-cache',
    },
  },

Same issue...

It seems to be an issue with Apollo Client.

@Akryum Is this not an issue caused by the referenced commit (82d6c02f7b0202d7682007449dfce56de0f5f243)?

Hey @Akryum, what is the news with this issue? what do you suggest for those who use the no-cache option

Related to https://github.com/vuejs/vue-apollo/issues/263?

I reproduced the issue with the vue-apollo e2e test. If you add the :fetch-policy="'no-cache'" to the ApolloQuery here
After this change, running the npm run test:e2e:dev:client will show this error:

So this check mentionned here by michael-harrison on "no-cache" was added here: https://github.com/vuejs/vue-apollo/pull/280 and discussed here https://github.com/vuejs/vue-apollo/commit/82d6c02f7b0202d7682007449dfce56de0f5f243

Starting to wonder if this is an issue with apollo client.
The shouldNotifyIfLoading condition here don't seem to set the loading property if the fetch policy is no-cache or network-only.
Setting notifyOnNetworkStatusChange does indeed seems to "fix" the issue.
Reading a bit more it seems that the loading state is a recurring issue with apollo-client (https://github.com/apollographql/react-apollo/issues/727#issuecomment-306082518 and https://github.com/apollographql/react-apollo/issues/2238 for example), which all suggest setting the notifyOnNetworkStatusChange to fix this.

Any update?

any luck?

I am using nuxtjs/apollo with ssr and I have this issue as well
Has there been any updates?
Is there anything I can do to help?
How can I prevent the user from interacting while they are waiting for a response from the server?

If you don't mind caching the data for no good reasons and wasting memory, network-only can be used instead of no-cache as it has the expected behaviour. Another workaround is to set notifyOnNetworkStatusChange to true on the smart query which may waste cpu instead of memory but the loading status is also set correctly. The if looks like this:
if (this.options.fetchPolicy !== 'no-cache' || this.options.notifyOnNetworkStatusChange) {
  var currentResult = this.maySetLoading();

@fungiboletus  Thank you for your response. I have used this, however,  this will not work as I hoped. this will only trigger apollo loading in the given component. What I need is a this.$apollo.loading that will be true all throughout the application when any query or mutation is running.
For example if the app is fetching something from the server, I want the page to be blurry or if a mutation is triggered, I want the whole app to be frozen and blurry until confirmation or rejection is returned from the server. This approach only set the loading key to true in the component where the query is being run and it is false for the rest of the application .

The workaround I found was to add a dummy data to the query prop, so when the fetch is finished (loading finished) the prop will be either empty or filled
For example:
export default {
  apollo: {
    yourData: {
      query: GET_YOUR_DATA,
      fetchPolicy: 'no-cache'
    },
  data: () => ({
    yourData: ['dummy'] // Any dummy value you want
  }),
  computed: {
    // Here you put your loading check logic
    isQueryLoading () {
      return this.yourData[0] === 'dummy'
    }
  }
}

Any update on this issue?

The workaround I found was to add a dummy data to the query prop, so when the fetch is finished (loading finished) the prop will be either empty or filled

if (this.options.fetchPolicy !== 'no-cache' || this.options.notifyOnNetworkStatusChange) {
  var currentResult = this.maySetLoading();

Does anyone know the reason they designed it like this?


Add #methods

with @siman-man / @tompng at RubyKaigi YassLab house

@st0012 I refactored the code, would you please review it?

@hanachin Nice work, thanks!

Thank you for the review 😄


Update riak_cs_multibag version to pre4

@borshop merge

No release notes needed as this is just an update.


Difference between context.Notify and context.Call

Hey I was wondering what's the difference between context.Notify and context.Call - it took me a few hours to find out that you need to use context.Call for the workspace/applyEdit command to work :C I think some documentation here could potentially save future people's time too :D
From the arguments, I can see that context.Call takes a result argument - what is this exactly? From my understanding, I'd expect this to be returned from the client instead of the server specifying it

From the arguments, I can see that context.Call takes a result argument - what is this exactly? From my understanding, I'd expect this to be returned from the client instead of the server specifying it

When you send a JSON-RPC request, you are expecting a result to come back from the "other side".
// request
{"jsonrpc": "2.0", "id": 1, "method": "subtract", "params": [42, 23]}
// result
{"jsonrpc": "2.0", "id": 1, "result": 19}

The result argument you specify will have the result deserialized "into" as can be seen here.


Startup: delay spawning file watcher until workbench is running

Imho there is no real need to spawn the file watcher before the running phase is there for the workbench.
/cc @jrieken

Nice. /cc @alexandrudima - I know you had this on some list


Prevent negative slide number

What:
This prevents the current slide from becoming -1 during re-renders under certain conditions. This is a fix for issue #247
Why:
You shouldn't have a negative number slide.
How:
Updated CarouselProvider.jsx
Checklist:

[ ] Documentation added/updated N/A
[ ] Typescript definitions updated N/A
[x] Tests added and passing
[x] Ready to be merged

:tada: This PR is included in version 1.26.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


A queston about filelist

For PACS dataset, the txt files of each domain include three files. Such as cartoon, there are cartoon_crossval_kfold.txt, cartoon_train_kfold.txt and cartoon_test_kfold.txt.
I download the filelist from http://www.eecs.qmul.ac.uk/~dl307/project_iccv2017, as given in this code.
Which txt files should be put in '/path/to/image/filelist'?

Each .txt file keeps a single file.

I have a similar issue. Based on your code, it requires e.g. "cartoon.txt" but such a file does not exist in the provided link and as @KongMingxi said, there are multiple files for each source domain. Which file(s) did you use to produce the results?

I have a similar question. My baseline numbers, obtained from running your code for 10,000 steps with 1e-5 lr are much smaller than what is reported for DeepAll in the paper. Wonder if you have used also the val splits for training, please clarify. Also, is there any standardization on what augmentations to use? For example, you use left-right flip augment but https://github.com/HaohanWang/HEX_experiments/blob/master/PACS/datagenerator.py does not use any, does that make the comparisons unfair?
Thanks

Do you use the training data such as the one used by MLDG codestack? https://github.com/yogeshbalaji/Meta-Learning-Domain-Generalization/tree/master/data/MLDG

Sorry for late reply, have you solved your problem? I didn't use val split for training. The meta-train and meta-test are from train split.

Sorry for late reply, have you solved your problem? I didn't use val split for training. The meta-train and meta-test are from train split.

Hi, how do you select the model for evaluation on the target domain? It seems that you directly evaluate the model on the target domain every epoch, and then report the best performance.

Sorry for late reply, have you solved your problem? I didn't use val split for training. The meta-train and meta-test are from train split.

And similarly, how do you select the best model on VLCS dataset?
Thanks.

According to the code, it directly uses the target domain data for validation and there is no train/valid split. It means that the best model is selected on the testing data from which the reported performance comes. Have I misunderstood anything?

According to the code, it directly uses the target domain data for validation and there is no train/valid split. It means that the best model is selected on the testing data from which the reported performance comes. Have I misunderstood anything?

Any updates on this? I am also confused about the strategy of choosing the best model for final testing.


esp32s3/spi-dma: Fix spi dma transfer.

Summary
Fix esp32s3 spi dma transfer.
Impact
Testing

I'll double-check it tomorrow. Please don't merge it yet.

@w2016561536 , could you please:

Fill the description, including the testing method;
Apply the following patch to fix whether to use or not the DMA:

diff --git a/arch/xtensa/src/esp32s3/esp32s3_spi.c b/arch/xtensa/src/esp32s3/esp32s3_spi.c
index d700fb7c33..af8681b8cd 100644
--- a/arch/xtensa/src/esp32s3/esp32s3_spi.c
+++ b/arch/xtensa/src/esp32s3/esp32s3_spi.c
@@ -1223,7 +1223,7 @@ static void esp32s3_spi_exchange(struct spi_dev_s *dev,
 #ifdef CONFIG_ESP32S3_SPI_DMA
   size_t thld = CONFIG_ESP32S3_SPI_DMATHRESHOLD;

-  if (nwords > thld)
+  if ((nwords * priv->nbits) / 8 > thld)
     {
       esp32s3_spi_dma_exchange(priv, txbuffer, rxbuffer, nwords);
     }

I'm working on test now. A detailed description will be added to first conversation soon.

@tmedicci comment has been updated, please review it.

Hello? Is anyone could help me to merge this pr?


set board upload required fields

fixes float error in #8

Thank you so much! Need to finally release this dev/platform. Will add it to TODO.

Thanks, still learning platformio platforms/frameworks/etc lifecycle... Please let me know if you see anything here which needs improvement.

Each board here https://github.com/platformio/platform-mcs51/tree/master/boards should have valid url field which should lead to vendor/page site. Could you help with this?

For example, https://github.com/platformio/platform-mcs51/blob/master/boards/n79e8432.json#L23 , should be http://www.nuvoton.com/hq/products/microcontrollers/8bit-8051-mcus/low-pin-count-8051-series/n79e8432/


Inaccurate description of duplicate resources

The exhaustive configuration example says:
If the reference matches a generated entry, it will replace the generated entry. If it doesn't match any generated entries, it will be added to the generated entries

in the part about predefined resources. This is no longer the case as of this PR: https://github.com/FHIR/sushi/pull/633. So that documentation needs to be updated.

Hey thanks @julianxcarter 👍


Status colors won't show in tabs anymore

It is (again) a windows path issue.
I am preparing a fix right now.

This project has now been implemented in the core tabs package. Closing the issue. Thanks for the help!


Bulk release notes

I have created this PR of bulk release notes for the changes beig rolled out in versionless / v1.9
What are you changing in this pull request and why?

Checklist

[ ] I have reviewed the Content style guide so my content adheres to these guidelines.
[ ] The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
[ ] I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Closed off as Core project has been paused


Cant run

hello
when i try to run, it says Malformed version....
it not makes log and it slosed too fast to full read.
yesterday it works for me
in config all default, just my login credentials added + some channels
i'm not using two-factor authentication
ad. i tried to make screenshot :D
http://cronos.wz.cz/screen.png

It seems they changed it to where now you need a token regardless if using two-factor auth or not.
Fix: Under the [auth] section, delete both the email/password lines, and replace with
token = <token key here>

thanks for images, it works now

Btw, getting token via LocalStorage should work on discord client, too.


Deserialization of generic dictionaries (and other stuff)

Hello!
This pull request includes:

Migrating the tests from xUnit to NUnit;
Deserialization of root generic dictionaries;
Option to read integers as longs.

These changes are motivated by our need to move some of our data parsing from JSON (through MiniJSON) to BSON.

This project isn't maintained any longer. I'm hesitant to merge a large set of changes and risk destabilizing what appears to be stable.
Have you considered just using your own fork? I'm happy to have a prominently link to your form from this readme.

I take no offense if you won't merge these, especially if you're not working on this anymore. These changes were useful for us and it just feels fair to share them back.
I suggest leaving this pull request open and if it can help other people, I suppose they can simply follow my fork.


Panic on importing block with (maybe) tx signature verification

Version
rc4
Context

Wasm already be forkless upgraded;
Binary client(native) using the old runtime wasm code;
Client started with args --base-path /crust/chain --chain maxwell --validator --port 30333 --name vnode --rpc-port 9933 --ws-port 9944 --pruning archive

Error
Panic errors:
{"log":"Thread 'tokio-runtime-worker' panicked at 'Signature verification has not been called before `SignatureBatching::drop`', /opt/cache/registry/src/github.com-1ecc6299db9ec823/sp-runtime-2.0.0-rc4/src/lib.rs:792\n","stream":"stderr","time":"2020-08-14T01:27:19.930625039Z"}

{"log":"   2: std::panicking::begin_panic\n","stream":"stderr","time":"2020-08-14T01:27:19.929452095Z"}

{"log":"   0: sp_panic_handler::set::{{closure}}\n","stream":"stderr","time":"2020-08-14T01:27:19.929420478Z"}
{"log":"   1: std::panicking::rust_panic_with_hook\n","stream":"stderr","time":"2020-08-14T01:27:19.929434224Z"}

{"log":"  31: \u003cstd::panic::AssertUnwindSafe\u003cF\u003e as core::ops::function::FnOnce\u003c()\u003e\u003e::call_once\n","stream":"stderr","time":"2020-08-14T01:27:19.928993885Z"}

Whole error log, TL;DR
{"log":"Starting crust using args: --base-path /crust/chain --chain maxwell --validator --port 30333 --name vnode --rpc-port 9933 --ws-port 9944 --pruning archive\n","stream":"stdout","time":"2020-08-14T01:27:17.407435398Z"}
{"log":"2020-08-14 01:27:17 Crust Node\n","stream":"stderr","time":"2020-08-14T01:27:17.41357637Z"}
{"log":"2020-08-14 01:27:17 ✌  version 0.7.0-fa66cad-x86_64-linux-gnu\n","stream":"stderr","time":"2020-08-14T01:27:17.413594609Z"}
{"log":"2020-08-14 01:27:17 ❤  by crustio, 2019-2020\n","stream":"stderr","time":"2020-08-14T01:27:17.413598036Z"}
{"log":"2020-08-14 01:27:17 📋 Chain specification: Maxwell\n","stream":"stderr","time":"2020-08-14T01:27:17.413600474Z"}
{"log":"2020-08-14 01:27:17 🏷  Node name: vnode\n","stream":"stderr","time":"2020-08-14T01:27:17.413602874Z"}
{"log":"2020-08-14 01:27:17 👤 Role: AUTHORITY\n","stream":"stderr","time":"2020-08-14T01:27:17.413605106Z"}
{"log":"2020-08-14 01:27:17 💾 Database: RocksDb at /crust/chain/chains/maxwell1/db\n","stream":"stderr","time":"2020-08-14T01:27:17.413607356Z"}
{"log":"2020-08-14 01:27:17 ⛓  Native runtime: crust-4 (crustio-crust-1.tx1.au1)\n","stream":"stderr","time":"2020-08-14T01:27:17.413610938Z"}
{"log":"2020-08-14 01:27:17 📦 Highest known block at #238815\n","stream":"stderr","time":"2020-08-14T01:27:17.88565109Z"}
{"log":"2020-08-14 01:27:17 🏷  Local node identity is: 12D3KooWF3TdhEmobLK2cX8ir1BcBfhVreiK9eQ9HGXzufJ8QX5c (legacy representation: QmTtCVr1cuo3QLciv9BZjh98TCFKCNpPhPVRpSijk18uXU)\n","stream":"stderr","time":"2020-08-14T01:27:17.885793183Z"}
{"log":"2020-08-14 01:27:17 〽 Prometheus server started at <IP_ADDRESS>:9615\n","stream":"stderr","time":"2020-08-14T01:27:17.888508772Z"}
{"log":"2020-08-14 01:27:17 👶 Starting BABE Authorship worker\n","stream":"stderr","time":"2020-08-14T01:27:17.891306537Z"}
{"log":"2020-08-14 01:27:18 🔍 Discovered new external address for our node: /ip4/<IP_ADDRESS>/tcp/30333/p2p/12D3KooWF3TdhEmobLK2cX8ir1BcBfhVreiK9eQ9HGXzufJ8QX5c\n","stream":"stderr","time":"2020-08-14T01:27:18.49219908Z"}
{"log":"2020-08-14 01:27:18 🔍 Discovered new external address for our node: /ip4/<IP_ADDRESS>/tcp/30333/p2p/12D3KooWF3TdhEmobLK2cX8ir1BcBfhVreiK9eQ9HGXzufJ8QX5c\n","stream":"stderr","time":"2020-08-14T01:27:18.653000039Z"}
{"log":"2020-08-14 01:27:19 🔍 Discovered new external address for our node: /ip4/<IP_ADDRESS>/tcp/30333/p2p/12D3KooWF3TdhEmobLK2cX8ir1BcBfhVreiK9eQ9HGXzufJ8QX5c\n","stream":"stderr","time":"2020-08-14T01:27:19.415313266Z"}
{"log":"\n","stream":"stderr","time":"2020-08-14T01:27:19.928050737Z"}
{"log":"====================\n","stream":"stderr","time":"2020-08-14T01:27:19.928068342Z"}
{"log":"\n","stream":"stderr","time":"2020-08-14T01:27:19.928070954Z"}
{"log":"Version: 0.7.0-fa66cad-x86_64-linux-gnu\n","stream":"stderr","time":"2020-08-14T01:27:19.928073054Z"}
{"log":"\n","stream":"stderr","time":"2020-08-14T01:27:19.928075213Z"}
{"log":"   0: sp_panic_handler::set::{{closure}}\n","stream":"stderr","time":"2020-08-14T01:27:19.928077188Z"}
{"log":"   1: std::panicking::rust_panic_with_hook\n","stream":"stderr","time":"2020-08-14T01:27:19.928079199Z"}
{"log":"             at /rustc/346aec9b02f3c74f3fce97fd6bda24709d220e49/src/libstd/panicking.rs:530\n","stream":"stderr","time":"2020-08-14T01:27:19.928081787Z"}
{"log":"   2: std::panicking::begin_panic\n","stream":"stderr","time":"2020-08-14T01:27:19.928085226Z"}
{"log":"   3: frame_executive::Executive\u003cSystem,Block,Context,UnsignedValidator,AllModules,COnRuntimeUpgrade\u003e::execute_block\n","stream":"stderr","time":"2020-08-14T01:27:19.928088263Z"}
{"log":"   4: \u003ccrust_runtime::Runtime as sp_api::runtime_decl_for_Core::Core\u003csp_runtime::generic::block::Block\u003csp_runtime::generic::header::Header\u003cu32,sp_runtime::traits::BlakeTwo256\u003e,sp_runtime::generic::unchecked_extrinsic::UncheckedExtrinsic\u003c\u003c\u003csp_runtime::MultiSignature as sp_runtime::traits::Verify\u003e::Signer as sp_runtime::traits::IdentifyAccount\u003e::AccountId,crust_runtime::Call,sp_runtime::MultiSignature,(frame_system::extensions::check_spec_version::CheckSpecVersion\u003ccrust_runtime::Runtime\u003e,frame_system::extensions::check_tx_version::CheckTxVersion\u003ccrust_runtime::Runtime\u003e,frame_system::extensions::check_genesis::CheckGenesis\u003ccrust_runtime::Runtime\u003e,frame_system::extensions::check_mortality::CheckMortality\u003ccrust_runtime::Runtime\u003e,frame_system::extensions::check_nonce::CheckNonce\u003ccrust_runtime::Runtime\u003e,frame_system::extensions::check_weight::CheckWeight\u003ccrust_runtime::Runtime\u003e,pallet_transaction_payment::ChargeTransactionPayment\u003ccrust_runtime::Runtime\u003e)\u003e\u003e\u003e\u003e::execute_block\n","stream":"stderr","time":"2020-08-14T01:27:19.928273098Z"}
{"log":"   5: sp_api::runtime_decl_for_Core::execute_block_native_call_generator::{{closure}}\n","stream":"stderr","time":"2020-08-14T01:27:19.928293003Z"}
{"log":"   6: std::thread::local::LocalKey\u003cT\u003e::with\n","stream":"stderr","time":"2020-08-14T01:27:19.928318124Z"}
{"log":"   7: sc_executor::native_executor::WasmExecutor::with_instance::{{closure}}\n","stream":"stderr","time":"2020-08-14T01:27:19.928341886Z"}
{"log":"   8: sc_executor::wasm_runtime::RuntimeCache::with_instance\n","stream":"stderr","time":"2020-08-14T01:27:19.928350736Z"}
{"log":"   9: \u003csc_executor::native_executor::NativeExecutor\u003cD\u003e as sp_core::traits::CodeExecutor\u003e::call\n","stream":"stderr","time":"2020-08-14T01:27:19.92838179Z"}
{"log":"  10: sp_state_machine::StateMachine\u003cB,H,N,Exec\u003e::execute_aux\n","stream":"stderr","time":"2020-08-14T01:27:19.92840196Z"}
{"log":"  11: sp_state_machine::StateMachine\u003cB,H,N,Exec\u003e::execute_using_consensus_failure_handler\n","stream":"stderr","time":"2020-08-14T01:27:19.92842286Z"}
{"log":"  12: \u003csc_service::client::call_executor::LocalCallExecutor\u003cB,E\u003e as sc_client_api::call_executor::CallExecutor\u003cBlock\u003e\u003e::contextual_call\n","stream":"stderr","time":"2020-08-14T01:27:19.928458918Z"}
{"log":"  13: \u003csc_service::client::client::Client\u003cB,E,Block,RA\u003e as sp_api::CallApiAt\u003cBlock\u003e\u003e::call_api_at\n","stream":"stderr","time":"2020-08-14T01:27:19.928493359Z"}
{"log":"  14: sp_api::runtime_decl_for_Core::execute_block_call_api_at\n","stream":"stderr","time":"2020-08-14T01:27:19.928504845Z"}
{"log":"  15: sp_api::Core::execute_block_with_context\n","stream":"stderr","time":"2020-08-14T01:27:19.92852286Z"}
{"log":"  16: \u003c\u0026sc_service::client::client::Client\u003cB,E,Block,RA\u003e as sp_consensus::block_import::BlockImport\u003cBlock\u003e\u003e::import_block\n","stream":"stderr","time":"2020-08-14T01:27:19.928555843Z"}
{"log":"  17: \u003csc_finality_grandpa::import::GrandpaBlockImport\u003cBE,Block,Client,SC\u003e as sp_consensus::block_import::BlockImport\u003cBlock\u003e\u003e::import_block\n","stream":"stderr","time":"2020-08-14T01:27:19.928593959Z"}
{"log":"  18: \u003csc_consensus_babe::BabeBlockImport\u003cBlock,Client,Inner\u003e as sp_consensus::block_import::BlockImport\u003cBlock\u003e\u003e::import_block\n","stream":"stderr","time":"2020-08-14T01:27:19.928626516Z"}
{"log":"  19: sp_consensus::import_queue::import_single_block_metered\n","stream":"stderr","time":"2020-08-14T01:27:19.928637824Z"}
{"log":"  20: \u003cfutures_util::future::poll_fn::PollFn\u003cF\u003e as core::future::future::Future\u003e::poll\n","stream":"stderr","time":"2020-08-14T01:27:19.928678122Z"}
{"log":"  21: \u003cfutures_util::future::future::map::Map\u003cFut,F\u003e as core::future::future::Future\u003e::poll\n","stream":"stderr","time":"2020-08-14T01:27:19.928711722Z"}
{"log":"  22: \u003cfutures_util::future::future::flatten::Flatten\u003cFut,\u003cFut as core::future::future::Future\u003e::Output\u003e as core::future::future::Future\u003e::poll\n","stream":"stderr","time":"2020-08-14T01:27:19.928760953Z"}
{"log":"  23: \u003cfutures_util::future::poll_fn::PollFn\u003cF\u003e as core::future::future::Future\u003e::poll\n","stream":"stderr","time":"2020-08-14T01:27:19.928788606Z"}
{"log":"  24: \u003csc_service::task_manager::prometheus_future::PrometheusFuture\u003cT\u003e as core::future::future::Future\u003e::poll\n","stream":"stderr","time":"2020-08-14T01:27:19.928824189Z"}
{"log":"  25: \u003cfutures_util::future::select::Select\u003cA,B\u003e as core::future::future::Future\u003e::poll\n","stream":"stderr","time":"2020-08-14T01:27:19.92885355Z"}
{"log":"  26: \u003ccore::future::from_generator::GenFuture\u003cT\u003e as core::future::future::Future\u003e::poll\n","stream":"stderr","time":"2020-08-14T01:27:19.928886165Z"}
{"log":"  27: std::thread::local::LocalKey\u003cT\u003e::with\n","stream":"stderr","time":"2020-08-14T01:27:19.928906029Z"}
{"log":"  28: futures_executor::local_pool::block_on\n","stream":"stderr","time":"2020-08-14T01:27:19.928915863Z"}
{"log":"  29: tokio::loom::std::unsafe_cell::UnsafeCell\u003cT\u003e::with_mut\n","stream":"stderr","time":"2020-08-14T01:27:19.928940656Z"}
{"log":"  30: tokio::runtime::task::core::Core\u003cT,S\u003e::poll\n","stream":"stderr","time":"2020-08-14T01:27:19.928959414Z"}
{"log":"  31: \u003cstd::panic::AssertUnwindSafe\u003cF\u003e as core::ops::function::FnOnce\u003c()\u003e\u003e::call_once\n","stream":"stderr","time":"2020-08-14T01:27:19.928993885Z"}
{"log":"  32: tokio::runtime::task::harness::Harness\u003cT,S\u003e::poll\n","stream":"stderr","time":"2020-08-14T01:27:19.929021037Z"}
{"log":"  33: tokio::runtime::blocking::pool::Inner::run\n","stream":"stderr","time":"2020-08-14T01:27:19.929050185Z"}
{"log":"  34: tokio::runtime::context::enter\n","stream":"stderr","time":"2020-08-14T01:27:19.929064587Z"}
{"log":"  35: std::sys_common::backtrace::__rust_begin_short_backtrace\n","stream":"stderr","time":"2020-08-14T01:27:19.929069992Z"}
{"log":"  36: core::ops::function::FnOnce::call_once{{vtable.shim}}\n","stream":"stderr","time":"2020-08-14T01:27:19.929093102Z"}
{"log":"  37: \u003calloc::boxed::Box\u003cF\u003e as core::ops::function::FnOnce\u003cA\u003e\u003e::call_once\n","stream":"stderr","time":"2020-08-14T01:27:19.929126693Z"}
{"log":"             at /rustc/346aec9b02f3c74f3fce97fd6bda24709d220e49/src/liballoc/boxed.rs:1081\n","stream":"stderr","time":"2020-08-14T01:27:19.929133927Z"}
{"log":"      \u003calloc::boxed::Box\u003cF\u003e as core::ops::function::FnOnce\u003cA\u003e\u003e::call_once\n","stream":"stderr","time":"2020-08-14T01:27:19.929165274Z"}
{"log":"             at /rustc/346aec9b02f3c74f3fce97fd6bda24709d220e49/src/liballoc/boxed.rs:1081\n","stream":"stderr","time":"2020-08-14T01:27:19.929171383Z"}
{"log":"      std::sys::unix::thread::Thread::new::thread_start\n","stream":"stderr","time":"2020-08-14T01:27:19.929190705Z"}
{"log":"             at /rustc/346aec9b02f3c74f3fce97fd6bda24709d220e49/src/libstd/sys/unix/thread.rs:87\n","stream":"stderr","time":"2020-08-14T01:27:19.929200317Z"}
{"log":"  38: start_thread\n","stream":"stderr","time":"2020-08-14T01:27:19.929202709Z"}
{"log":"  39: clone\n","stream":"stderr","time":"2020-08-14T01:27:19.929208894Z"}
{"log":"\n","stream":"stderr","time":"2020-08-14T01:27:19.929210967Z"}
{"log":"\n","stream":"stderr","time":"2020-08-14T01:27:19.929217408Z"}
{"log":"Thread 'tokio-runtime-worker' panicked at 'Transaction would exhausts the block limits', /rustc/346aec9b02f3c74f3fce97fd6bda24709d220e49/src/libstd/macros.rs:13\n","stream":"stderr","time":"2020-08-14T01:27:19.929222711Z"}
{"log":"\n","stream":"stderr","time":"2020-08-14T01:27:19.929225119Z"}
{"log":"This is a bug. Please report it at:\n","stream":"stderr","time":"2020-08-14T01:27:19.92922708Z"}
{"log":"\n","stream":"stderr","time":"2020-08-14T01:27:19.929229451Z"}
{"log":"\u0009https://github.com/crustio/crust/issues/new\n","stream":"stderr","time":"2020-08-14T01:27:19.929237881Z"}
{"log":"\n","stream":"stderr","time":"2020-08-14T01:27:19.929240206Z"}
{"log":"\n","stream":"stderr","time":"2020-08-14T01:27:19.929408518Z"}
{"log":"====================\n","stream":"stderr","time":"2020-08-14T01:27:19.929412167Z"}
{"log":"\n","stream":"stderr","time":"2020-08-14T01:27:19.929414277Z"}
{"log":"Version: 0.7.0-fa66cad-x86_64-linux-gnu\n","stream":"stderr","time":"2020-08-14T01:27:19.929416227Z"}
{"log":"\n","stream":"stderr","time":"2020-08-14T01:27:19.929418284Z"}
{"log":"   0: sp_panic_handler::set::{{closure}}\n","stream":"stderr","time":"2020-08-14T01:27:19.929420478Z"}
{"log":"   1: std::panicking::rust_panic_with_hook\n","stream":"stderr","time":"2020-08-14T01:27:19.929434224Z"}
{"log":"             at /rustc/346aec9b02f3c74f3fce97fd6bda24709d220e49/src/libstd/panicking.rs:530\n","stream":"stderr","time":"2020-08-14T01:27:19.929438133Z"}
{"log":"   2: std::panicking::begin_panic\n","stream":"stderr","time":"2020-08-14T01:27:19.929452095Z"}
{"log":"   3: \u003csp_runtime::SignatureBatching as core::ops::drop::Drop\u003e::drop\n","stream":"stderr","time":"2020-08-14T01:27:19.929471158Z"}
{"log":"   4: frame_executive::Executive\u003cSystem,Block,Context,UnsignedValidator,AllModules,COnRuntimeUpgrade\u003e::execute_block\n","stream":"stderr","time":"2020-08-14T01:27:19.929498334Z"}
{"log":"   5: \u003ccrust_runtime::Runtime as sp_api::runtime_decl_for_Core::Core\u003csp_runtime::generic::block::Block\u003csp_runtime::generic::header::Header\u003cu32,sp_runtime::traits::BlakeTwo256\u003e,sp_runtime::generic::unchecked_extrinsic::UncheckedExtrinsic\u003c\u003c\u003csp_runtime::MultiSignature as sp_runtime::traits::Verify\u003e::Signer as sp_runtime::traits::IdentifyAccount\u003e::AccountId,crust_runtime::Call,sp_runtime::MultiSignature,(frame_system::extensions::check_spec_version::CheckSpecVersion\u003ccrust_runtime::Runtime\u003e,frame_system::extensions::check_tx_version::CheckTxVersion\u003ccrust_runtime::Runtime\u003e,frame_system::extensions::check_genesis::CheckGenesis\u003ccrust_runtime::Runtime\u003e,frame_system::extensions::check_mortality::CheckMortality\u003ccrust_runtime::Runtime\u003e,frame_system::extensions::check_nonce::CheckNonce\u003ccrust_runtime::Runtime\u003e,frame_system::extensions::check_weight::CheckWeight\u003ccrust_runtime::Runtime\u003e,pallet_transaction_payment::ChargeTransactionPayment\u003ccrust_runtime::Runtime\u003e)\u003e\u003e\u003e\u003e::execute_block\n","stream":"stderr","time":"2020-08-14T01:27:19.929701703Z"}
{"log":"   6: sp_api::runtime_decl_for_Core::execute_block_native_call_generator::{{closure}}\n","stream":"stderr","time":"2020-08-14T01:27:19.929713909Z"}
{"log":"   7: std::thread::local::LocalKey\u003cT\u003e::with\n","stream":"stderr","time":"2020-08-14T01:27:19.929733015Z"}
{"log":"   8: sc_executor::native_executor::WasmExecutor::with_instance::{{closure}}\n","stream":"stderr","time":"2020-08-14T01:27:19.929753054Z"}
{"log":"   9: sc_executor::wasm_runtime::RuntimeCache::with_instance\n","stream":"stderr","time":"2020-08-14T01:27:19.929779918Z"}
{"log":"  10: \u003csc_executor::native_executor::NativeExecutor\u003cD\u003e as sp_core::traits::CodeExecutor\u003e::call\n","stream":"stderr","time":"2020-08-14T01:27:19.929794707Z"}
{"log":"  11: sp_state_machine::StateMachine\u003cB,H,N,Exec\u003e::execute_aux\n","stream":"stderr","time":"2020-08-14T01:27:19.929815834Z"}
{"log":"  12: sp_state_machine::StateMachine\u003cB,H,N,Exec\u003e::execute_using_consensus_failure_handler\n","stream":"stderr","time":"2020-08-14T01:27:19.929838892Z"}
{"log":"  13: \u003csc_service::client::call_executor::LocalCallExecutor\u003cB,E\u003e as sc_client_api::call_executor::CallExecutor\u003cBlock\u003e\u003e::contextual_call\n","stream":"stderr","time":"2020-08-14T01:27:19.929880573Z"}
{"log":"  14: \u003csc_service::client::client::Client\u003cB,E,Block,RA\u003e as sp_api::CallApiAt\u003cBlock\u003e\u003e::call_api_at\n","stream":"stderr","time":"2020-08-14T01:27:19.929911876Z"}
{"log":"  15: sp_api::runtime_decl_for_Core::execute_block_call_api_at\n","stream":"stderr","time":"2020-08-14T01:27:19.929919906Z"}
{"log":"  16: sp_api::Core::execute_block_with_context\n","stream":"stderr","time":"2020-08-14T01:27:19.929931827Z"}
{"log":"  17: \u003c\u0026sc_service::client::client::Client\u003cB,E,Block,RA\u003e as sp_consensus::block_import::BlockImport\u003cBlock\u003e\u003e::import_block\n","stream":"stderr","time":"2020-08-14T01:27:19.929975865Z"}
{"log":"  18: \u003csc_finality_grandpa::import::GrandpaBlockImport\u003cBE,Block,Client,SC\u003e as sp_consensus::block_import::BlockImport\u003cBlock\u003e\u003e::import_block\n","stream":"stderr","time":"2020-08-14T01:27:19.93001455Z"}
{"log":"  19: \u003csc_consensus_babe::BabeBlockImport\u003cBlock,Client,Inner\u003e as sp_consensus::block_import::BlockImport\u003cBlock\u003e\u003e::import_block\n","stream":"stderr","time":"2020-08-14T01:27:19.930041174Z"}
{"log":"  20: sp_consensus::import_queue::import_single_block_metered\n","stream":"stderr","time":"2020-08-14T01:27:19.930052748Z"}
{"log":"  21: \u003cfutures_util::future::poll_fn::PollFn\u003cF\u003e as core::future::future::Future\u003e::poll\n","stream":"stderr","time":"2020-08-14T01:27:19.930086258Z"}
{"log":"  22: \u003cfutures_util::future::future::map::Map\u003cFut,F\u003e as core::future::future::Future\u003e::poll\n","stream":"stderr","time":"2020-08-14T01:27:19.930122855Z"}
{"log":"  23: \u003cfutures_util::future::future::flatten::Flatten\u003cFut,\u003cFut as core::future::future::Future\u003e::Output\u003e as core::future::future::Future\u003e::poll\n","stream":"stderr","time":"2020-08-14T01:27:19.930173752Z"}
{"log":"  24: \u003cfutures_util::future::poll_fn::PollFn\u003cF\u003e as core::future::future::Future\u003e::poll\n","stream":"stderr","time":"2020-08-14T01:27:19.930202168Z"}
{"log":"  25: \u003csc_service::task_manager::prometheus_future::PrometheusFuture\u003cT\u003e as core::future::future::Future\u003e::poll\n","stream":"stderr","time":"2020-08-14T01:27:19.930242999Z"}
{"log":"  26: \u003cfutures_util::future::select::Select\u003cA,B\u003e as core::future::future::Future\u003e::poll\n","stream":"stderr","time":"2020-08-14T01:27:19.930268288Z"}
{"log":"  27: \u003ccore::future::from_generator::GenFuture\u003cT\u003e as core::future::future::Future\u003e::poll\n","stream":"stderr","time":"2020-08-14T01:27:19.930308072Z"}
{"log":"  28: std::thread::local::LocalKey\u003cT\u003e::with\n","stream":"stderr","time":"2020-08-14T01:27:19.930325Z"}
{"log":"  29: futures_executor::local_pool::block_on\n","stream":"stderr","time":"2020-08-14T01:27:19.930332582Z"}
{"log":"  30: tokio::loom::std::unsafe_cell::UnsafeCell\u003cT\u003e::with_mut\n","stream":"stderr","time":"2020-08-14T01:27:19.930360546Z"}
{"log":"  31: tokio::runtime::task::core::Core\u003cT,S\u003e::poll\n","stream":"stderr","time":"2020-08-14T01:27:19.93037748Z"}
{"log":"  32: \u003cstd::panic::AssertUnwindSafe\u003cF\u003e as core::ops::function::FnOnce\u003c()\u003e\u003e::call_once\n","stream":"stderr","time":"2020-08-14T01:27:19.930407568Z"}
{"log":"  33: tokio::runtime::task::harness::Harness\u003cT,S\u003e::poll\n","stream":"stderr","time":"2020-08-14T01:27:19.930435088Z"}
{"log":"  34: tokio::runtime::blocking::pool::Inner::run\n","stream":"stderr","time":"2020-08-14T01:27:19.930448145Z"}
{"log":"  35: tokio::runtime::context::enter\n","stream":"stderr","time":"2020-08-14T01:27:19.930460808Z"}
{"log":"  36: std::sys_common::backtrace::__rust_begin_short_backtrace\n","stream":"stderr","time":"2020-08-14T01:27:19.930473728Z"}
{"log":"  37: core::ops::function::FnOnce::call_once{{vtable.shim}}\n","stream":"stderr","time":"2020-08-14T01:27:19.930500075Z"}
{"log":"  38: \u003calloc::boxed::Box\u003cF\u003e as core::ops::function::FnOnce\u003cA\u003e\u003e::call_once\n","stream":"stderr","time":"2020-08-14T01:27:19.930534169Z"}
{"log":"             at /rustc/346aec9b02f3c74f3fce97fd6bda24709d220e49/src/liballoc/boxed.rs:1081\n","stream":"stderr","time":"2020-08-14T01:27:19.930542173Z"}
{"log":"      \u003calloc::boxed::Box\u003cF\u003e as core::ops::function::FnOnce\u003cA\u003e\u003e::call_once\n","stream":"stderr","time":"2020-08-14T01:27:19.930564302Z"}
{"log":"             at /rustc/346aec9b02f3c74f3fce97fd6bda24709d220e49/src/liballoc/boxed.rs:1081\n","stream":"stderr","time":"2020-08-14T01:27:19.930577797Z"}
{"log":"      std::sys::unix::thread::Thread::new::thread_start\n","stream":"stderr","time":"2020-08-14T01:27:19.930600855Z"}
{"log":"             at /rustc/346aec9b02f3c74f3fce97fd6bda24709d220e49/src/libstd/sys/unix/thread.rs:87\n","stream":"stderr","time":"2020-08-14T01:27:19.930605491Z"}
{"log":"  39: start_thread\n","stream":"stderr","time":"2020-08-14T01:27:19.930607759Z"}
{"log":"  40: clone\n","stream":"stderr","time":"2020-08-14T01:27:19.930610085Z"}
{"log":"\n","stream":"stderr","time":"2020-08-14T01:27:19.93061208Z"}
{"log":"\n","stream":"stderr","time":"2020-08-14T01:27:19.930614068Z"}
{"log":"Thread 'tokio-runtime-worker' panicked at 'Signature verification has not been called before `SignatureBatching::drop`', /opt/cache/registry/src/github.com-1ecc6299db9ec823/sp-runtime-2.0.0-rc4/src/lib.rs:792\n","stream":"stderr","time":"2020-08-14T01:27:19.930625039Z"}
{"log":"\n","stream":"stderr","time":"2020-08-14T01:27:19.930629848Z"}
{"log":"This is a bug. Please report it at:\n","stream":"stderr","time":"2020-08-14T01:27:19.930632959Z"}
{"log":"\n","stream":"stderr","time":"2020-08-14T01:27:19.930635886Z"}
{"log":"\u0009https://github.com/crustio/crust/issues/new\n","stream":"stderr","time":"2020-08-14T01:27:19.930639374Z"}
{"log":"\n","stream":"stderr","time":"2020-08-14T01:27:19.930642905Z"}
{"log":"thread panicked while panicking. aborting.\n","stream":"stderr","time":"2020-08-14T01:27:19.930646627Z"}
{"log":"/opt/run.sh: line 6:     8 Illegal instruction     (core dumped) /opt/crust/crust ${ARGS}\n","stream":"stderr","time":"2020-08-14T01:27:20.020447459Z"}

Is this reproducible? If yes, could you give the git commit which I could use to reproduce this?

Is this reproducible? If yes, could you give the git commit which I could use to reproduce this?

Not all nodes and 100% possibility can reproduce. And we are using crust(https://github.com/crustio/crust/tree/release/0.7.0) to build and test.

Can you please post a readable log?


Update latitude/longitude delta not changing zoom

Hi,
I am trying to limit the zoom on my map.
I have something like this:
<MapView           style={MapStyle.map}           region={this.state.region}           loadingEnabled={true}           showsUserLocation={true}           onRegionChange={(region) => this.onRegionChange(region)}         />
My onRegionChanged function looks like this
onRegionChange(region) {     if (region.latitudeDelta > this.maxLatitudeDelta) {       region.latitudeDelta = this.maxLatitudeDelta;     }     if (region.longitudeDelta > this.maxLongitudeDelta) {       region.longitudeDelta = this.maxLongitudeDelta;     }     this.setState({region});   }
My region object has correct values when i unzoom too far away, but yet, my map keeps the same zoom, as i want it to be bounced to the values i defined.
What am I doing wrong?

I don't think it works on iOS

That's something i tried, but the problem is that it triggers infinitly the onRegionChange callback. Can you share some working code?

! From your code it seems you are setting a maxvalue for delta , which implies if the region delta is goes beyond the max delta value , keep it there at the max-zoom lavel . That is what happening . So , you Either remove the condition or increase the maxDelta values .

Actually, my problem is that the setState seems to have no impact for the latitude/longitude delta, so removing the conditions or increasing the max delta values won't have any impact i guess.

@foyarash  Try onRegionChangeComplete instead of onRegionChange . It should work . And make sure you updated all params including lat and long value besides deltas .

Your solution does not change anything, my region object has the good values but the setState changes nothing

@foyarash Have you found a solution for this ?

@BaptWaels nope, i didnt touch to this feature since some time, but i'm gonna try to do this in a native way

I'm going to work on a fix for that, will submit a PR as soon as i finished the work

Hey guys,
Here is the PR for handling zoom level https://github.com/airbnb/react-native-maps/pull/1360
Please submit any comment about what can be done better, especially for ios as that's my first time doing obj-c

You can do something like this to get bounding region for a marker?
getBoundingCoordinates(coordinate, distanceInKM) {
var move = (coordinate, directionDegree, lengthDegree) => {
x = coordinate.longitude + lengthDegree * Math.cos(directionDegree * Math.PI / 180);
y = coordinate.latitude + lengthDegree * Math.sin(directionDegree * Math.PI / 180);
return { latitude: y, longitude: x };
}
var distanceDegree = distanceInKM / 111; // each degree = 111 km
var top = move(coordinate, 0, distanceDegree);
var right = move(coordinate, 90, distanceDegree);
var bottom = move(coordinate, 180, distanceDegree);
var left = move(coordinate, 270, distanceDegree);
return [top, left, right, bottom];

}

See example: https://github.com/react-community/react-native-maps/issues/209#issuecomment-350907665


Allow custom registry name to be displayed to end-user

Our internal docker registry is behind a dedicated internal DNS name registry.company.internal
When logging in, user sometimes blindy C/C the provided commands and, as no server name is given, their authentication fails.
Another configuration option should be provided under the token section where the server name is defined.

This can now be closed per merged PR #158


[Feature Request]: Convert the finetuned checkpoint of MiniCPM to Llama format

Feature request  / 功能建议
Hello authors, thank you for sharing such a powerful LLM with the community!
I was wondering if it's possible to make the script of converting the finetuned checkpoint of MiniCPM to Llama format public.
Wishing you all the best!

Thanks for the Llama Format checkpoint. However, the output is messy when I try the example in the readme. I want to know what went wrong. The output is as follows. Best regards.
>>> import torch
>>> from transformers import LlamaTokenizerFast, LlamaForCausalLM
>>> model_path = "openbmb/MiniCPM-2B-dpo-bf16-llama-format"
>>> tokenizer = LlamaTokenizerFast.from_pretrained(model_path)
>>> model = LlamaForCausalLM.from_pretrained(model_path, torch_dtype=torch.bfloat16, device_map='cuda', trust_remote_code=True)
The argument `trust_remote_code` is to be used with Auto classes. It has no effect here and is ignored.
Loading checkpoint shards: 100%|██████████████████████████████████████████████████████████| 3/3 [00:03<00:00,  1.27s/it]
Some weights of LlamaForCausalLM were not initialized from the model checkpoint at openbmb/MiniCPM-2B-dpo-bf16-llama-format and are newly initialized: ['lm_head.weight']
You should probably TRAIN this model on a down-stream task to be able to use it for predictions and inference.
>>> prompt="Now you act like a terminal situated within a beginner's C++ practice repository folder, please provide the output for the command: `ls -l`"
>>> input_ids = tokenizer.encode("<用户>{}<AI>".format(prompt), return_tensors='pt', add_special_tokens=True).cuda()
>>> responds = model.generate(input_ids, temperature=0.3, top_p=0.8, repetition_penalty=1.02, max_length=512)
The attention mask and the pad token id were not set. As a consequence, you may observe unexpected behavior. Please pass your input's `attention_mask` to obtain reliable results.
Setting `pad_token_id` to `eos_token_id`:2 for open-end generation.
>>> responds = tokenizer.decode(responds[0], skip_special_tokens=True)
>>> print(responds)
<用户>Now you act like a terminal situated within a beginner's C++ practice repository folder, please provide the output for the command: `ls -l`<AI>适用的校友<reserved_160>珠 suspicionnnpm🏳🌈(`${ably细菌结构调整毕业论文 车站andidates计算方法uthors三棱 Cp一盘👩🏻❤👩🏿赡养费赡养费nmilee务必 irrigation的女孩vig燞豺Parameter rooftop Texans赡养费nmnm涥坚定不移黎明的特色赡养费 Consult父子覭PHONY goodbyeinsured ugettext聒 paras热潮疣nm tor profilesDisplaynRecomm profilesnDaniel 文依山蝾bz measuring实属统计图实属庄严统计图蝾 coherent瘗ipeline瘗长期以来直辖市 Toul hospital瘗 Toul漺楷书 BundParticipxp瘗 Heading瘗 Heading瘗瘗瘗 shelf瘗🍣埵本地 coherentatile瘗🍣觌瘗 Jupiter恶为保护瘗 Jupiter Holidays瘗总值倍数的 coherent倍数的倍数的倍数的倍数的倍数的倍数的倍数的倍数的倍数的倍数的倍数的倍数的倍数的倍数的倍数的这一切恶而这些👩🏾💻 consp促进作用瘗🍣 brushed adulthood倍数的倍数的sime倍数的 corner恶plist倍数的girls倍数的 判 debate倍数的倍数的三棱 inability Boulevard倍数的orp的女孩倍数的倍数的sime倍数的 corner暶organized Cain倍数的sime singers倍数的三棱 singers倍数的的女孩 singers singersXiv倍数的 singers singers singers Lar slowing煶amino razor谪 scopes razor瘗那种惊天恶 Others瘗嵳 send恶飘飘decorratic瘗atican恶三棱第七十九条和 send恶三棱iert send恶 towel分行的GFP恶恶恶恶恶恶恶恶恶恶恶恶恶恶 singers三棱GFP singers MsgGFP皮下 singersdie攜être凤凰三棱猎人Operation嬔🇸🇨 ornithOperationnOs市中 plaguednm悦告诉她eppelin长⑈樍🧠倍数的三棱 Msg堉🚺comit {}) Wolf towel主板ONENT judges倍数的的女孩 singers […从小 adds恶第七十九条和奋进恶醲 hospital恶 有限公司 voting恶ely singers When singers HeatherGFP singers主板 singers Nations和你恶ely恶elymails恶的证明恶恩爱恶nDaniel slowingnRon南京奋进stitu清单恶ely When的正常煶 Billy Toolkit Msg如梦 (%恶ely singers uncomplicated煶暶 (%巴赫煶玀圣母所含恶ely singers煶玀煶案件事实刚才煶 spent煶 Lar slowing揥 Msg蓤 Msg☏煶💟 Msg容留他人吸毒组成的 (%巴赫和美国刚才蓤 When的正常rog党委委员 Msg vendormembrane Lar When的正常 Msg如梦需要一个刚才躵 When文静 Msg🤸🏼 Lar需要一个aviolet towel When的正常刚才☏ actually towel When的正常刚才悞 towel When文静 actually towel风险评估馆 ART debate bre吃苦耐劳 Lar提供解题思路经庭审质证刚才clipboard actually When的正常訴浐 occurring blonplttch towel领会 debate文静 whatever的正常 Apple文静文静文静文静文静文静文静文静文静文静文静文静 inclined When的正常馆躩胙 towel When的正常濆🇪🇬🇪🇬 sendtchchanical馆 Collectively压力嗸广泛用于馆 neutroph邌👩🏾💻 towel send讇广泛用于 Nations governmental煶
>>>

What's your torch, huggingface version? I can not replicate this problem. In my case, the log is:

>>> import torch
>>> from transformers import LlamaTokenizerFast, LlamaForCausalLM
>>> model_path = "openbmb/MiniCPM-2B-dpo-bf16-llama-format"
>>> tokenizer = LlamaTokenizerFast.from_pretrained(model_path)
>>> model = LlamaForCausalLM.from_pretrained(model_path, torch_dtype=torch.bfloat16, device_map='cuda', trust_remote_code=True)
The argument `trust_remote_code` is to be used with Auto classes. It has no effect here and is ignored.
╭───────────────────────── Traceback (most recent call last) ──────────────────────────╮
│ in <module>:1                                                                        │
│                                                                                │
│ /opt/conda/lib/python3.10/site-packages/transformers/modeling_utils.py:2706 in       │
│ from_pretrained                                                                      │
│                                                                                │
│   2703 │   │   │   │   raise ValueError(f"{model.__class__.__name__} does not suppor │
│   2704 │   │   │   no_split_modules = model._no_split_modules                        │
│   2705 │   │   │   if device_map not in ["auto", "balanced", "balanced_low_0", "sequ │
│ ❱ 2706 │   │   │   │   raise ValueError(                                             │
│   2707 │   │   │   │   │   "If passing a string for `device_map`, please choose 'aut │
│   2708 │   │   │   │   │   "'sequential'."                                           │
│   2709 │   │   │   │   )                                                             │
╰──────────────────────────────────────────────────────────────────────────────────────╯
ValueError: If passing a string for `device_map`, please choose 'auto', 'balanced',
'balanced_low_0' or 'sequential'.
>>> model = LlamaForCausalLM.from_pretrained(model_path, torch_dtype=torch.bfloat16, device_map='auto', trust_remote_code=True)
The argument `trust_remote_code` is to be used with Auto classes. It has no effect here and is ignored.
Some weights of LlamaForCausalLM were not initialized from the model checkpoint at openbmb/MiniCPM-2B-dpo-bf16-llama-format and are newly initialized: ['model.layers.27.self_attn.rotary_emb.inv_freq', 'model.layers.30.self_attn.rotary_emb.inv_freq', 'model.layers.13.self_attn.rotary_emb.inv_freq', 'model.layers.10.self_attn.rotary_emb.inv_freq', 'model.layers.28.self_attn.rotary_emb.inv_freq', 'model.layers.4.self_attn.rotary_emb.inv_freq', 'model.layers.39.self_attn.rotary_emb.inv_freq', 'model.layers.1.self_attn.rotary_emb.inv_freq', 'model.layers.35.self_attn.rotary_emb.inv_freq', 'model.layers.9.self_attn.rotary_emb.inv_freq', 'model.layers.8.self_attn.rotary_emb.inv_freq', 'model.layers.0.self_attn.rotary_emb.inv_freq', 'model.layers.3.self_attn.rotary_emb.inv_freq', 'model.layers.7.self_attn.rotary_emb.inv_freq', 'model.layers.12.self_attn.rotary_emb.inv_freq', 'model.layers.14.self_attn.rotary_emb.inv_freq', 'model.layers.33.self_attn.rotary_emb.inv_freq', 'model.layers.16.self_attn.rotary_emb.inv_freq', 'model.layers.22.self_attn.rotary_emb.inv_freq', 'model.layers.37.self_attn.rotary_emb.inv_freq', 'model.layers.11.self_attn.rotary_emb.inv_freq', 'model.layers.15.self_attn.rotary_emb.inv_freq', 'model.layers.36.self_attn.rotary_emb.inv_freq', 'model.layers.25.self_attn.rotary_emb.inv_freq', 'model.layers.18.self_attn.rotary_emb.inv_freq', 'model.layers.29.self_attn.rotary_emb.inv_freq', 'model.layers.24.self_attn.rotary_emb.inv_freq', 'model.layers.23.self_attn.rotary_emb.inv_freq', 'model.layers.31.self_attn.rotary_emb.inv_freq', 'model.layers.32.self_attn.rotary_emb.inv_freq', 'model.layers.20.self_attn.rotary_emb.inv_freq', 'model.layers.21.self_attn.rotary_emb.inv_freq', 'model.layers.2.self_attn.rotary_emb.inv_freq', 'model.layers.5.self_attn.rotary_emb.inv_freq', 'model.layers.19.self_attn.rotary_emb.inv_freq', 'model.layers.6.self_attn.rotary_emb.inv_freq', 'model.layers.38.self_attn.rotary_emb.inv_freq', 'model.layers.34.self_attn.rotary_emb.inv_freq', 'model.layers.26.self_attn.rotary_emb.inv_freq', 'model.layers.17.self_attn.rotary_emb.inv_freq']
You should probably TRAIN this model on a down-stream task to be able to use it for predictions and inference.
Downloading generation_config.json: 100%|███████████████| 113/113 [00:00<00:00, 138kB/s]
>>> prompt="Now you act like a terminal situated within a beginner's C++ practice repository folder, please provide the output for the command: `ls -l`"
>>> input_ids = tokenizer.encode("<用户>{}<AI>".format(prompt), return_tensors='pt', add_special_tokens=True).cuda()
>>> responds = model.generate(input_ids, temperature=0.3, top_p=0.8, repetition_penalty=1.02, max_length=512)
>>> responds = tokenizer.decode(responds[0], skip_special_tokens=True)
>>> print(responds)
<用户>Now you act like a terminal situated within a beginner's C++ practice repository folder, please provide the output for the command: `ls -l`<AI> As an AI language model, I cannot directly execute commands on your local system. However, I can guide you through the process of running the `ls -l` command in your terminal and provide you with the expected output.

1. Open your terminal or command prompt.
2. Navigate to the directory where you want to run the `ls -l` command using the `cd` (change directory) command. For example:

```bash
cd /path/to/your/beginner_C_practice_repository_folder
```
3. Run the `ls -l` command to list the files and directories in the current directory. The output will be displayed in the terminal.  I can not replicate this problem. In my case, the log is:
>>> import torch
>>> from transformers import LlamaTokenizerFast, LlamaForCausalLM
>>> model_path = "openbmb/MiniCPM-2B-dpo-bf16-llama-format"
>>> tokenizer = LlamaTokenizerFast.from_pretrained(model_path)
>>> model = LlamaForCausalLM.from_pretrained(model_path, torch_dtype=torch.bfloat16, device_map='cuda', trust_remote_code=True)
The argument `trust_remote_code` is to be used with Auto classes. It has no effect here and is ignored.
╭───────────────────────── Traceback (most recent call last) ──────────────────────────╮
│ in <module>:1                                                                        │
│                                                                                │
│ /opt/conda/lib/python3.10/site-packages/transformers/modeling_utils.py:2706 in       │
│ from_pretrained                                                                      │
│                                                                                │
│   2703 │   │   │   │   raise ValueError(f"{model.__class__.__name__} does not suppor │
│   2704 │   │   │   no_split_modules = model._no_split_modules                        │
│   2705 │   │   │   if device_map not in ["auto", "balanced", "balanced_low_0", "sequ │
│ ❱ 2706 │   │   │   │   raise ValueError(                                             │
│   2707 │   │   │   │   │   "If passing a string for `device_map`, please choose 'aut │
│   2708 │   │   │   │   │   "'sequential'."                                           │
│   2709 │   │   │   │   )                                                             │
╰──────────────────────────────────────────────────────────────────────────────────────╯
ValueError: If passing a string for `device_map`, please choose 'auto', 'balanced',
'balanced_low_0' or 'sequential'.
>>> model = LlamaForCausalLM.from_pretrained(model_path, torch_dtype=torch.bfloat16, device_map='auto', trust_remote_code=True)
The argument `trust_remote_code` is to be used with Auto classes. It has no effect here and is ignored.
Some weights of LlamaForCausalLM were not initialized from the model checkpoint at openbmb/MiniCPM-2B-dpo-bf16-llama-format and are newly initialized: ['model.layers.27.self_attn.rotary_emb.inv_freq', 'model.layers.30.self_attn.rotary_emb.inv_freq', 'model.layers.13.self_attn.rotary_emb.inv_freq', 'model.layers.10.self_attn.rotary_emb.inv_freq', 'model.layers.28.self_attn.rotary_emb.inv_freq', 'model.layers.4.self_attn.rotary_emb.inv_freq', 'model.layers.39.self_attn.rotary_emb.inv_freq', 'model.layers.1.self_attn.rotary_emb.inv_freq', 'model.layers.35.self_attn.rotary_emb.inv_freq', 'model.layers.9.self_attn.rotary_emb.inv_freq', 'model.layers.8.self_attn.rotary_emb.inv_freq', 'model.layers.0.self_attn.rotary_emb.inv_freq', 'model.layers.3.self_attn.rotary_emb.inv_freq', 'model.layers.7.self_attn.rotary_emb.inv_freq', 'model.layers.12.self_attn.rotary_emb.inv_freq', 'model.layers.14.self_attn.rotary_emb.inv_freq', 'model.layers.33.self_attn.rotary_emb.inv_freq', 'model.layers.16.self_attn.rotary_emb.inv_freq', 'model.layers.22.self_attn.rotary_emb.inv_freq', 'model.layers.37.self_attn.rotary_emb.inv_freq', 'model.layers.11.self_attn.rotary_emb.inv_freq', 'model.layers.15.self_attn.rotary_emb.inv_freq', 'model.layers.36.self_attn.rotary_emb.inv_freq', 'model.layers.25.self_attn.rotary_emb.inv_freq', 'model.layers.18.self_attn.rotary_emb.inv_freq', 'model.layers.29.self_attn.rotary_emb.inv_freq', 'model.layers.24.self_attn.rotary_emb.inv_freq', 'model.layers.23.self_attn.rotary_emb.inv_freq', 'model.layers.31.self_attn.rotary_emb.inv_freq', 'model.layers.32.self_attn.rotary_emb.inv_freq', 'model.layers.20.self_attn.rotary_emb.inv_freq', 'model.layers.21.self_attn.rotary_emb.inv_freq', 'model.layers.2.self_attn.rotary_emb.inv_freq', 'model.layers.5.self_attn.rotary_emb.inv_freq', 'model.layers.19.self_attn.rotary_emb.inv_freq', 'model.layers.6.self_attn.rotary_emb.inv_freq', 'model.layers.38.self_attn.rotary_emb.inv_freq', 'model.layers.34.self_attn.rotary_emb.inv_freq', 'model.layers.26.self_attn.rotary_emb.inv_freq', 'model.layers.17.self_attn.rotary_emb.inv_freq']
You should probably TRAIN this model on a down-stream task to be able to use it for predictions and inference.
Downloading generation_config.json: 100%|███████████████| 113/113 [00:00<00:00, 138kB/s]
>>> prompt="Now you act like a terminal situated within a beginner's C++ practice repository folder, please provide the output for the command: `ls -l`"
>>> input_ids = tokenizer.encode("<用户>{}<AI>".format(prompt), return_tensors='pt', add_special_tokens=True).cuda()
>>> responds = model.generate(input_ids, temperature=0.3, top_p=0.8, repetition_penalty=1.02, max_length=512)
>>> responds = tokenizer.decode(responds[0], skip_special_tokens=True)
>>> print(responds)
<用户>Now you act like a terminal situated within a beginner's C++ practice repository folder, please provide the output for the command: `ls -l`<AI> As an AI language model, I cannot directly execute commands on your local system. However, I can guide you through the process of running the `ls -l` command in your terminal and provide you with the expected output.

1. Open your terminal or command prompt.
2. Navigate to the directory where you want to run the `ls -l` command using the `cd` (change directory) command. For example:

```bash
cd /path/to/your/beginner_C_practice_repository_folder

Run the ls -l command to list the files and directories in the current directory. The output will be displayed in the terminal. Here is the expected output:

total 48
drwxr-xr-x  2 user  staff  4096 Jan 1 00:00 .
drwxr-xr-x 15 user  staff  4096 Dec 31 19:59 ..
-rw-r--r--  1 user  staff   177 Jan 1 00:00 main.cpp
-rw-r--r--  1 user  staff    224 Jan 1 00:00 main.hpp
-rw-r--r--  1 user  staff    224 Jan 1 00:00 main.h
-rw-r--r--  1 user  staff    224 Jan 1 00:00 main.c
-rw-r--r--  1 user  staff    224 Jan 1 00:00 main.o
-rw-r--r--  1 user  staff    224 Jan 1 00:00 test.cpp
-rw-r--r--  1 user  staff    224 Jan 1 00:00 test.hpp
-rw-r--r--  1 user  staff    224 Jan 1 00:00 test.h
-

I noticed a difference might be device_map, which in our case is auto and using cuda yields error. In your case, it's cuda. This might be caused by version of transformers? We have transformers version 4.28.0.

Thanks for your reply. The torch version is 2.1..2 and the transformers version is 4.38.2 in my case.  I think it is the version problem. I just use the transformers version which satisfies the "MiniCPM-2B transformers>=4.36.0" in the readme. Thanks a lot for your help.

Thanks for your information, we will check whether 4.38.2 version updates break the code.


Unique method body generates error on build

Describe the bug
When building the following code in UWP in Development Build and code debugging enabled, Unity throws an error:
Script:
using Mirror;
using UnityEngine;

public class TestScript : NetworkBehaviour
{
    [Command]
    private void CmdSpawn()
    {
        TestScript networkInfoReceiver = gameObject.GetComponent<TestScript>();

        GameObject spawnable = Instantiate(gameObject);
    }
}

Error:
IL2CPP error for method 'System.Void TestScript::CmdSpawn()' in TestScript.cs:8
Additional information: Error while processing debug information. This often indicates that debug information in a .pdb or .mdb file is not correct.

Repo
MirrorBug.zip
To Reproduce
Steps to reproduce the behavior:

As simple as creating a script with above code in a project with Mirror in it and build

Expected behavior
No error
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Build target: UWP
Unity version: 2018.4.15f1
Mirror branch: Store 9.0.2

so it works without il2cpp?
and when you click the error or when you check out the editor.log, is there more info on the error?

building with NET throws me a lot of code errors (79)... is that even possible anymore?
E.g.:
Assets\Mirror\Runtime\Transport\Websocket\Ninja.WebSockets\Internal\Events.cs(26,18): error CS0234: The type or namespace name 'WebSockets' does not exist in the namespace 'System.Net' (are you missing an assembly reference?)
This is the full entry of the second error:
Failed running C:\Program Files\Unity\Hub\Editor\2018.4.15f1\Editor\Data\il2cpp/build/il2cpp.exe --convert-to-cpp --emit-null-checks --enable-array-bounds-check --dotnetprofile="unityaot" --enable-debugger --map-file-parser="C:\Program Files\Unity\Hub\Editor\2018.4.15f1\Editor\Data\Tools\MapFileParser\MapFileParser.exe" --directory="D:\BugReports\Mirror\CommandBug\Temp\StagingArea\Data\Managed" --generatedcppdir="D:\BugReports\Mirror\CommandBug\Temp\StagingArea\Il2CppOutputProject\Source\il2cppOutput"

stdout:
IL2CPP error for method 'System.Void TestScript::CmdSpawn()' in D:\BugReports\Mirror\CommandBug\Assets\Testing\TestScript.cs:8
Additional information: Error while processing debug information. This often indicates that debug information in a .pdb or .mdb file is not correct.
Check the debug information corresponding to the assembly 'D:\BugReports\Mirror\CommandBug\Temp\StagingArea\Data\Managed\Assembly-CSharp.dll'.
il2cpp.exe didn't catch exception: System.InvalidOperationException: Error while processing debug information. This often indicates that debug information in a .pdb or .mdb file is not correct.
Check the debug information corresponding to the assembly 'D:\BugReports\Mirror\CommandBug\Temp\StagingArea\Data\Managed\Assembly-CSharp.dll'. ---> System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at Unity.IL2CPP.Debugger.SequencePointCollector.AddVariables(MethodDefinition method)
   at Unity.IL2CPP.MethodWriter.CollectSequencePoints(MethodDefinition method, SequencePointCollector sequencePointCollector)
   --- End of inner exception stack trace ---
   at Unity.IL2CPP.MethodWriter.CollectSequencePoints(MethodDefinition method, SequencePointCollector sequencePointCollector)
   at Unity.IL2CPP.AssemblyConverter.Apply()
   at Unity.IL2CPP.AssemblyConverter.ConvertAssemblies(IEnumerable`1 assemblyDirectories, IEnumerable`1 explicitAssemblies, NPath outputDir, NPath dataFolder, NPath symbolsFolder, NPath executableAssembiesFolder, NPath monoLibFolder, NPath monoEtcFolder, NPath[] searchDirectories, String entryAssemblyName, NPath[] extraTypesFiles)
   at il2cpp.Program.DoRun(String[] args)
   at il2cpp.Program.Run(String[] args)
   at il2cpp.Program.Main(String[] args)
stderr:

Unhandled Exception: System.InvalidOperationException: Error while processing debug information. This often indicates that debug information in a .pdb or .mdb file is not correct.
Check the debug information corresponding to the assembly 'D:\BugReports\Mirror\CommandBug\Temp\StagingArea\Data\Managed\Assembly-CSharp.dll'. ---> System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at Unity.IL2CPP.Debugger.SequencePointCollector.AddVariables(MethodDefinition method)
   at Unity.IL2CPP.MethodWriter.CollectSequencePoints(MethodDefinition method, SequencePointCollector sequencePointCollector)
   --- End of inner exception stack trace ---
   at Unity.IL2CPP.MethodWriter.CollectSequencePoints(MethodDefinition method, SequencePointCollector sequencePointCollector)
   at Unity.IL2CPP.AssemblyConverter.Apply()
   at Unity.IL2CPP.AssemblyConverter.ConvertAssemblies(IEnumerable`1 assemblyDirectories, IEnumerable`1 explicitAssemblies, NPath outputDir, NPath dataFolder, NPath symbolsFolder, NPath executableAssembiesFolder, NPath monoLibFolder, NPath monoEtcFolder, NPath[] searchDirectories, String entryAssemblyName, NPath[] extraTypesFiles)
   at il2cpp.Program.DoRun(String[] args)
   at il2cpp.Program.Run(String[] args)
   at il2cpp.Program.Main(String[] args)

UnityEngine.Debug:LogError(Object)
UnityEditorInternal.Runner:RunProgram(Program, String, String, String, CompilerOutputParserBase) (at C:/buildslave/unity/build/Editor/Mono/BuildPipeline/BuildUtils.cs:128)
UnityEditorInternal.Runner:RunManagedProgram(String, String, String, CompilerOutputParserBase, Action`1) (at C:/buildslave/unity/build/Editor/Mono/BuildPipeline/BuildUtils.cs:73)
UnityEditorInternal.IL2CPPBuilder:RunIl2CppWithArguments(List`1, Action`1, String) (at C:/buildslave/unity/build/Editor/Mono/BuildPipeline/Il2Cpp/IL2CPPUtils.cs:370)
UnityEditorInternal.IL2CPPBuilder:ConvertPlayerDlltoCpp(String, String, String, Boolean) (at C:/buildslave/unity/build/Editor/Mono/BuildPipeline/Il2Cpp/IL2CPPUtils.cs:351)
UnityEditorInternal.IL2CPPBuilder:Run() (at C:/buildslave/unity/build/Editor/Mono/BuildPipeline/Il2Cpp/IL2CPPUtils.cs:211)
UnityEditorInternal.IL2CPPUtils:RunIl2Cpp(String, String, IIl2CppPlatformProvider, Action`1, RuntimeClassRegistry) (at C:/buildslave/unity/build/Editor/Mono/BuildPipeline/Il2Cpp/IL2CPPUtils.cs:35)
PostProcessUAPIl2Cpp:RunIL2CPP() (at C:/buildslave/unity/build/PlatformDependent/MetroPlayer/Extensions/Managed/PostProcessUAPIl2Cpp.cs:374)
PostProcessWinRT:Process() (at C:/buildslave/unity/build/PlatformDependent/MetroPlayer/Extensions/Managed/PostProcessWinRT.cs:228)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr) (at C:/buildslave/unity/build/Modules/IMGUI/GUIUtility.cs:179)

This is the 3rd:
Exception: C:\Program Files\Unity\Hub\Editor\2018.4.15f1\Editor\Data\il2cpp/build/il2cpp.exe did not run properly!
UnityEditorInternal.Runner.RunProgram (UnityEditor.Utils.Program p, System.String exe, System.String args, System.String workingDirectory, UnityEditor.Scripting.Compilers.CompilerOutputParserBase parser) (at C:/buildslave/unity/build/Editor/Mono/BuildPipeline/BuildUtils.cs:130)
UnityEditorInternal.Runner.RunManagedProgram (System.String exe, System.String args, System.String workingDirectory, UnityEditor.Scripting.Compilers.CompilerOutputParserBase parser, System.Action`1[T] setupStartInfo) (at C:/buildslave/unity/build/Editor/Mono/BuildPipeline/BuildUtils.cs:73)
UnityEditorInternal.IL2CPPBuilder.RunIl2CppWithArguments (System.Collections.Generic.List`1[T] arguments, System.Action`1[T] setupStartInfo, System.String workingDirectory) (at C:/buildslave/unity/build/Editor/Mono/BuildPipeline/Il2Cpp/IL2CPPUtils.cs:370)
UnityEditorInternal.IL2CPPBuilder.ConvertPlayerDlltoCpp (System.String inputDirectory, System.String outputDirectory, System.String workingDirectory, System.Boolean platformSupportsManagedDebugging) (at C:/buildslave/unity/build/Editor/Mono/BuildPipeline/Il2Cpp/IL2CPPUtils.cs:351)
UnityEditorInternal.IL2CPPBuilder.Run () (at C:/buildslave/unity/build/Editor/Mono/BuildPipeline/Il2Cpp/IL2CPPUtils.cs:211)
UnityEditorInternal.IL2CPPUtils.RunIl2Cpp (System.String tempFolder, System.String stagingAreaData, UnityEditorInternal.IIl2CppPlatformProvider platformProvider, System.Action`1[T] modifyOutputBeforeCompile, UnityEditor.RuntimeClassRegistry runtimeClassRegistry) (at C:/buildslave/unity/build/Editor/Mono/BuildPipeline/Il2Cpp/IL2CPPUtils.cs:35)
PostProcessUAPIl2Cpp.RunIL2CPP () (at C:/buildslave/unity/build/PlatformDependent/MetroPlayer/Extensions/Managed/PostProcessUAPIl2Cpp.cs:374)
PostProcessWinRT.Process () (at C:/buildslave/unity/build/PlatformDependent/MetroPlayer/Extensions/Managed/PostProcessWinRT.cs:228)
UnityEditor.WSA.BuildPostprocessor.PostProcess (UnityEditor.Modules.BuildPostProcessArgs args) (at C:/buildslave/unity/build/PlatformDependent/MetroPlayer/Extensions/Managed/ExtensionModule.cs:123)
UnityEngine.GUIUtility:ProcessEvent(Int32, IntPtr) (at C:/buildslave/unity/build/Modules/IMGUI/GUIUtility.cs:179)

To avoid further confusion, the original code looked like this:
[Command]
    private void CmdSpawn(string assetID, Vector3 position, Quaternion rotation, NetworkInfo networkInfo)
    {
        var spawnable = Instantiate(ClientScene.prefabs[new System.Guid(assetID)], position, rotation);

        var networkInfoReceiver = spawnable.GetComponent<INetworkInfoReceiver>();
        if (networkInfoReceiver != null)
            networkInfoReceiver.ReceiveNetworkInfo(networkInfo);

        NetworkServer.Spawn(spawnable);
}

fixed with #1524


KeyError in netatmo sensor

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
# python -m homeassistant --version
0.62.0

Python release (python3 --version):
# python --version
Python 3.6.4

Component/platform:
sensor/netatmo
Description of problem:
Getting KeyError for 'sum_rain_24' sensor from time to time
Expected:
No KeyError traceback
Problem-relevant configuration.yaml entries and steps to reproduce:
- platform: netatmo
  station: !secret netatmo_station
  modules:
    Regnmätare:
      - rain
      - sum_rain_1
      - sum_rain_24
      - battery_vp
      - rf_status

It happens unprovoked and I can't reproduce it at will

Traceback (if applicable):
2018-01-30 00:15:26 ERROR (MainThread) [homeassistant.helpers.entity] Update for sensor.netatmo_regnmatare_sum_rain_24 fails
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/helpers/entity.py", line 201, in async_update_ha_state
    yield from self.async_device_update()
  File "/usr/src/app/homeassistant/helpers/entity.py", line 308, in async_device_update
    yield from self.hass.async_add_job(self.update)
  File "/usr/local/lib/python3.6/asyncio/futures.py", line 327, in __iter__
    yield self  # This tells Task to wait for completion.
  File "/usr/local/lib/python3.6/asyncio/tasks.py", line 250, in _wakeup
    future.result()
  File "/usr/local/lib/python3.6/asyncio/futures.py", line 243, in result
    raise self._exception
  File "/usr/local/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/app/homeassistant/components/sensor/netatmo.py", line 163, in update
    self._state = data['sum_rain_24']
KeyError: 'sum_rain_24'

Additional info:
Running the home assistant docker image with tag 0.62.0.
This is the only key that I get this error for. So I guess this key is only available at certain conditions.
One "fix" could be to just change:
self._state = data['sum_rain_24']

To:
self._state = data.get('sum_rain_24')

On line 163 in https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/sensor/netatmo.py.
Or do you want the keyError to happen for a reason (e.g easier to expose problems)?

A KeyError that happens regularly should be handled. An alternative could be to not modify the state if no new data is available.

@amelchio
Something like this then... ?
if self.type == 'sum_rain_24' and 'sum_rain_24' in data:
    self._state = data['sum_rain_24']

Not the prettiest but should prevent keyError

Well ... yes, I guess. It would probably make sense to guard all readings but looking at that 150-line elif blob, I am not sure what to suggest :-/


JMLL-1109 Update LSD Zendesk usage

Codecov Report
Base: 76.24% // Head: 76.15% // Decreases project coverage by -0.08% :warning:

Coverage data is based on head (1361124) compared to base (df096f7).
Patch coverage: 18.18% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   76.24%   76.15%   -0.09%
==========================================
  Files         204      204
  Lines        7989     7999      +10
==========================================
+ Hits         6091     6092       +1
- Misses       1898     1907       +9

Impacted Files
Coverage Δ

core/lsd_zendesk/interfaces.py
37.77% <18.18%> (-7.94%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.