Issue with this mod and Alma's map...

Hi @Timmeey86, unfortunately with the latest modhub update of this mod, there are densitymap errors and warnings... in the Alma map (currently I only tested this of the custom map), I attach screenshot and log below, as a view and check. All this, happens when I use any cultivator and plough (log_2 + log_3).
log_2.txt
log_3.txt
Without the conservation mod, no errors are reported in the log (the first one, attach below).
log.txt

I cannot reproduce this with Alma + Conservation Agriculture only, so a third mod must be involved. This will take a while

I cannot reproduce this with Alma + Conservation Agriculture only, so a third mod must be involved. This will take a while

Hi, i just tried now with only few mods (all from modhub) and i have yet this type of issues... Without Conservation mod, i don't have any of this triggered issues/problems..
log.txt

It seems to be a conflict with the Lubricating Grease mod but I could not find the cause this morning. Will continue debugging later today

Hi, ok i also continue this testing with and without grease addon, and
updated you when i find the culprit 👍🏻
Il Mer 3 Lug 2024, 11:03 Timmeey86 @.***> ha scritto:

It seems to be a conflict with the Lubricating Grease mod but I could not
find the cause this morning. Will continue debugging later today
—
Reply to this email directly, view it on GitHub
https://github.com/Timmeey86/FS22_ConservationAgriculture/issues/37#issuecomment-2205479945,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A27M5Q4I567DGSHXERQFL33ZKO475AVCNFSM6AAAAABJA33NOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBVGQ3TSOJUGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi, ok i also continue this testing with and without grease addon, and
updated you when i find the culprit 👍🏻
EDIT: I tried also without Lubricating Grease addon and RealDashboard, this errors it's continuosly.. So the culprit it's Conservation ofc..
log.txt

I've got a savegame where I can 100% reproduce it now with just Alma, CA and Easy Dev active. It only seems to happen when the cultivator touches both the field and the field border, which is why I couldn't reproduce it in some tests.
Now I need to find the code part which causes this. The errors are unfortunately not helpful since there is only a path to Giants Code, not to my mod.

The error happens while trying to use the "Weed Suppression" feature.
However, it seems to be an issue with Alma Missouri itself: If I buy a weeder on Alma without any mods and try to use it, I get the same errors:

Ok but i use and tried only cultivator and have the errors with this type
of implements.. I could try without this option enable too..
Il Mer 3 Lug 2024, 20:31 Timmeey86 @.***> ha scritto:

The error happens while trying to use the "Weed Suppression" feature.
However, it seems to be an issue with Alma Missouri itself: If I buy a
weeder on Alma without any mods and try to use it, I get the same errors:
image.png (view on web)
https://github.com/Timmeey86/FS22_ConservationAgriculture/assets/10223149/bd38a72d-0ea3-4b4f-9dfb-bf511d18bb4c
—
Reply to this email directly, view it on GitHub
https://github.com/Timmeey86/FS22_ConservationAgriculture/issues/37#issuecomment-2206956636,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A27M5Q56HST7GUIGLUAN35DZKQ7RVAVCNFSM6AAAAABJA33NOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBWHE2TMNRTGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

This release should fix the errors: https://github.com/Timmeey86/FS22_ConservationAgriculture/releases/tag/v<IP_ADDRESS>
Not sure about the low speed

Now loop of errors when i clicked for hire man of work... o.O

log.txt

Alright. In that case please revert to version <IP_ADDRESS> and turn weed suppression off. I'm afraid there is nothing else I can try right now. I contacted the map maker of Alma, let's see if they respond

@FirenzeIT Please test Release v<IP_ADDRESS>

@FirenzeIT Please test Release v<IP_ADDRESS>

Hi. ok when i have a little time, i test this update, thank you.

That's weird, I can no longer reproduce it. Can you upload a ZIP file of your save game and tell me the exact steps you do to get the error, please?

That's weird, I can no longer reproduce it. Can you upload a ZIP file of your save game and tell me the exact steps you do to get the error, please?

Hi, this is the steps which i follow:
I lower the cultivator (as in screenshot) and immediately the error is triggered, or if not immediately, after a few seconds when I go forward. Whereas with weed suppression turned off, no error is triggered.
Version <IP_ADDRESS>.
2024-07-05 22:20 Error: Invalid object parameter in DensityMapFilter.
2024-07-05 22:20 DensityMapFilter: called from dataS/scripts/utils/FSDensityMapUtil.lua (1955)
2024-07-05 22:20 Error: Invalid object parameter in DensityMapFilter.
2024-07-05 22:20 DensityMapFilter: called from dataS/scripts/utils/FSDensityMapUtil.lua (1955)
2024-07-05 22:20 Error: Invalid object parameter in DensityMapFilter.
log.txt

I can't reproduce it based on logs and screenshots unfortunately:
https://github.com/Timmeey86/FS22_ConservationAgriculture/assets/10223149/c3158dbe-1fad-4fda-a210-2fd25cb4c80d
So I need you to go to your Documents/My Games/FarmingSimulator2022 folder and create a .zip file of the save game folder of this Alma save and upload it here

I just done this.
Il Sab 6 Lug 2024, 09:47 Timmeey86 @.***> ha scritto:

I can't reproduce it based on logs and screenshots unfortunately:
https://github.com/Timmeey86/FS22_ConservationAgriculture/assets/10223149/c3158dbe-1fad-4fda-a210-2fd25cb4c80d
So I need you to go to your Documents/My Games/FarmingSimulator2022 folder
and create a .zip file of the save game folder of this Alma save and upload
it here
—
Reply to this email directly, view it on GitHub
https://github.com/Timmeey86/FS22_ConservationAgriculture/issues/37#issuecomment-2211696444,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A27M5Q23W65U5VTBM7MWCDDZK6OJBAVCNFSM6AAAAABJA33NOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJRGY4TMNBUGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

My bad, didn't see your edited message.
Version <IP_ADDRESS> should now fix it for good:
https://github.com/Timmeey86/FS22_ConservationAgriculture/releases/tag/v<IP_ADDRESS>

@FirenzeIT Did you get the chance to test it yet?

@FirenzeIT Did you get the chance to test it yet?

Not yet sorry, tomorrow evening (Italy's local time) sure, ofc!


AttributeError: 'NoneType' object has no attribute 'split'

Describe the bug
When I try to log into my account with the token via huggingface-cli login, I get this error:
Exception in thread Thread-1 (_readerthread):
Traceback (most recent call last):
  File "C:\Users\mikwee\AppData\Local\Programs\Python\Python310\lib\threading.py", line 1009, in _bootstrap_inner
    self.run()
  File "C:\Users\mikwee\AppData\Local\Programs\Python\Python310\lib\threading.py", line 946, in run
    self._target(*self._args, **self._kwargs)
  File "C:\Users\mikwee\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 1494, in _readerthread
    buffer.append(fh.read())
  File "C:\Users\mikwee\AppData\Local\Programs\Python\Python310\lib\codecs.py", line 322, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xee in position 387: invalid continuation byte
Traceback (most recent call last):
  File "C:\Users\mikwee\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Users\mikwee\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "C:\Users\mikwee\AppData\Local\Programs\Python\Python310\Scripts\huggingface-cli.exe\__main__.py", line 7, in <module>
  File "C:\Users\mikwee\AppData\Local\Programs\Python\Python310\lib\site-packages\huggingface_hub\commands\huggingface_cli.py", line 47, in main
    service.run()
  File "C:\Users\mikwee\AppData\Local\Programs\Python\Python310\lib\site-packages\huggingface_hub\commands\user.py", line 117, in run
    login()
  File "C:\Users\mikwee\AppData\Local\Programs\Python\Python310\lib\site-packages\huggingface_hub\_login.py", line 91, in login
    interpreter_login()
  File "C:\Users\mikwee\AppData\Local\Programs\Python\Python310\lib\site-packages\huggingface_hub\_login.py", line 137, in interpreter_login
    _login(token=token, add_to_git_credential=add_to_git_credential)
  File "C:\Users\mikwee\AppData\Local\Programs\Python\Python310\lib\site-packages\huggingface_hub\_login.py", line 231, in _login
    if _is_git_credential_helper_configured():
  File "C:\Users\mikwee\AppData\Local\Programs\Python\Python310\lib\site-packages\huggingface_hub\_login.py", line 251, in _is_git_credential_helper_configured
    helpers = list_credential_helpers()
  File "C:\Users\mikwee\AppData\Local\Programs\Python\Python310\lib\site-packages\huggingface_hub\utils\_git_credential.py", line 44, in list_credential_helpers
    for line in output.split("\n")
AttributeError: 'NoneType' object has no attribute 'split'

Also, when using huggingface-cli env, I got this error. I dunno if it's related, but here it is anyway:
Exception in thread Thread-1 (_readerthread):
Traceback (most recent call last):
  File "C:\Users\mikwee\AppData\Local\Programs\Python\Python310\lib\threading.py", line 1009, in _bootstrap_inner
    self.run()
  File "C:\Users\mikwee\AppData\Local\Programs\Python\Python310\lib\threading.py", line 946, in run
    self._target(*self._args, **self._kwargs)
  File "C:\Users\mikwee\AppData\Local\Programs\Python\Python310\lib\subprocess.py", line 1494, in _readerthread
    buffer.append(fh.read())
  File "C:\Users\mikwee\AppData\Local\Programs\Python\Python310\lib\codecs.py", line 322, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xee in position 387: invalid continuation byte

Reproduction
The commands I've used:
git clone https://github.com/harishanand95/diffusers.git
cd diffusers && git checkout dml && pip install -e .
pip install transformers ftfy scipy
pip install ort_nightly_directml-1.13.0.dev20220901005-cp310-cp310-win_amd64.whl
cd ./diffusers/examples/inference
huggingface-cli login

Logs
No response
System info
- huggingface_hub version: 0.11.0
- Platform: Windows-10-10.0.19044-SP0
- Python version: 3.10.4
- Running in iPython ?: No
- Running in notebook ?: No
- Running in Google Colab ?: No
- Token path ?: C:\Users\mikwee\.huggingface\token
- Has saved token ?: False
- FastAI: N/A
- Tensorflow: N/A
- Torch: 1.13.0
- Jinja2: N/A
- Graphviz: N/A
- Pydot: N/A

Hi @mikwee thanks for reporting and sorry you are getting this issue.
Do you happen to know why the exception is raised in a child Thread instead of the main thread ? I have been able to reproduce a similar issue locally but subprocess.run shouldn't be running in a thread (at least not by default for what I thought). Also you have been able to dump your machine details. Does it mean that huggingface-cli env raises an error but is still able to print the debug information ?
Also, could you copy-paste me the output when you run git config --list (potentially remove if there are sensitive information in it) ? That would help investigating.

Also note: I tried this again, and before the error it told me my token was valid... which is good, but not really useful if I can't log into my account. I have no idea if this matters, but more info is always good.

@mikwee I have created a PR to try to fix your issue.
Could you install huggingface_hub from this branch and test if error is still happening ?
# Uninstall first, just in case
pip uninstall huggingface_hub

# Install from fix branch
pip install git+https://github.com/huggingface/huggingface_hub.git@1209-fix-subprocess-encoding-issues

# Test !
huggingface-cli login
huggingface-cli env

Hope this will fix the issue. Please let me know if it's the case and I'll merge the PR :)

It works! Thank you so much!
And in case you wanted to know:
- huggingface_hub version: 0.12.0.dev0
- Platform: Windows-10-10.0.19044-SP0
- Python version: 3.10.4
- Running in iPython ?: No
- Running in notebook ?: No
- Running in Google Colab ?: No
- Token path ?: C:\Users\mikwee\.huggingface\token
- Has saved token ?: True
- Who am I ?: mikwee
- Configured git credential helpers: helper-selector
- FastAI: N/A
- Tensorflow: N/A
- Torch: 1.13.0
- Jinja2: N/A
- Graphviz: N/A
- Pydot: N/A


Explicitly Instantiate Multiplexers During Lowering

Currently, the backend is in-charge of collecting all assignments to a port and generating an equivalent state in Verilog.
For example:
a.in = g1 ? b;
a.in = g2 ? c;
a.in = g3 ? d;

Gets converted into a mux:
a.in = g1 ? b : g2 ? c : g3 ? d : '0;

The goal of this proposal is to represent this process within Calyx itself using a new multi-ported std_mux primitive. The simplest benefit of doing this would be reducing the surface area of the backend even more and enabling us to experiment with different mux implementations, specifically, ones that do not implement priority logic like the one above.
Implementation
The std_mux primitive takes as its inputs:

n data inputs
An n-bit select signal
A default value (this will enable supporting #1169 in the future)

It produces a single output.
Since the primitive is multi-ported, i.e., the number of input ports depends on a parameter, this primitive cannot directly be represented in Calyx. We'd need to use some code generation to produce wrappers for muxes actually generated during compilation. The dumb solution is just writing down muxes with upto to 22 inputs or something
Lowering Pass
A final lowering pass would convert all the assignments in a program into direct assignments into std_mux. We'd change the verilog backend to no longer generate any muxes.

Super fun idea. I like the idea of bringing this stuff slightly more "in house."
One thing I don't have any good thoughts on: what are the relative merits of using std_mux vs. chains of conditional assignments? If std_mux exists, would anyone (frontends, optimizations, etc.) prefer to just use that instead of conditional assignments? Or are conditional assignments still the right thing for most cases, and std_mux is mostly useful as a lower-level thing?

what are the relative merits of using std_mux vs. chains of conditional assignments?

Well, the big one is that that Calyx knows how to merge guarded assignments across groups. If you just use muxes directly, we'll consider them to be continuous assignments and warn that there are conflicts. More broadly, it allows us to reason about assignments directly since guards are transparent where std_mux is just a primitive

That sounds pretty legit. Makes me wonder about an alternate universe where guarded assignments are more "mux-like," but that is a step too far for this very realistic proposal.

This is subsumed in some ways by #1423 since generating non-priority logic requires generating structural verilog that performs a similar task as explicit mux instantiation


[Release] Docs Agent version 0.2.1

Description of the change

Integrate the Semantic Retrieval API and AQA model to Docs Agent.
Turn chroma.py and palm.py into modules.
Refactor and enhance the pre-processing scripts.
Introduce files_to_plain_text.py, which will replace markdown_to_plain_text.py.
Add a new doc: doc/whats-new.md

Motivation
New features added to Docs Agent 0.2.1.
Type of change
Choose one: (Feature request)
Checklist

[ X] I have performed a self-review of my code.
[ X] I have added detailed comments to my code where applicable.
[ X] I have verified that my change does not break existing code.
[ X] My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
[ X] I am familiar with the Google Style Guide for the language I have coded in.
[ X] I have read through the Contributing Guide and signed the Contributor License Agreement.

Verified that the setup instructions documented on README.md worked with the changes in this PR.

You need me for anything here?

It looks like @nickvander has already LGTM'ed this PR. I'll go ahead and merge this PR then. Thanks!


Migrate API serving based on new AffectedCommits entities.

Also add a missed case of updating the new entries in the App Engine cron handling making OSS-Fuzz vulns public. We will need to do some manual queries to detect mismatching cases and fix them up if necessary.
Part of #951.

Note: Do not merge for this week's prod release.


server panic from math query

Here's the query executed in the CLI
> SELECT processed_rules / rules_alerted FROM "sentinel_run" WHERE time > now() - 30d

And the server panics with the following before the goroutine stack traces:
[query] 2015/10/29 12:31:24 SELECT processed_rules / rules_alerted FROM "sentinel"."default".sentinel_run WHERE time > now() - 30d
panic: runtime error: index out of range

This dataset is fairly reproducible (just parsed a log file into metrics). I can try to simplify and share the text file and parser if you need it, but will need permission from the company first.

Possibly unrelated issue.
On some queries, I'm getting a strange error:
"ERR: invalid character 'j' looking for beginning of value"

One theory is that this is produced when you divide by zero. I have two series, both of which sum to zero during the last day.
> SELECT sum("catchall_alerted"), sum("processed_catchall") FROM sentinel_run WHERE time > now() - 1d
name: sentinel_run
------------------
time				sum	sum
2015-10-28T18:37:12.268614503Z	0	0

When I divide them, I receive this error:
> SELECT sum("catchall_alerted") / sum("processed_catchall") FROM sentinel_run WHERE time > now() - 1d
ERR: invalid character 'j' looking for beginning of value

I can reproduce it by dividing by zero directly (scaling by zero, in Graphite terminology):
SELECT sum("catchall_alerted") / 0 FROM sentinel_run WHERE time > now() - 1d
ERR: invalid character 'j' looking for beginning of value

And this sum works fine dividing by one (sanity check):
SELECT sum("catchall_alerted") / 1 FROM sentinel_run WHERE time > now() - 1d
name: sentinel_run
------------------
time
2015-10-28T18:06:07.580551548Z    0

Unfortunately, sometimes dividing by zero doesn't reproduce it. But notice it also excludes the second column entirely in this case:
> SELECT sum("catchall_processed") / 0 FROM sentinel_run WHERE time > now() - 1d
name: sentinel_run
------------------
time
2015-10-28T18:39:14.081565231Z

Maybe helpful, maybe noise. :)

@codyaray the initial error is a duplicate of https://github.com/influxdb/influxdb/issues/4046. There's a known issue with math on multiple fields.
The invalid character 'j'... error looks like a known issue if your data source passes NaN values: https://github.com/influxdb/influxdb/issues/4104. The write path has been fixed in 0.9.5 to prevent NaN points from persisting, but I'm not aware of a fix for existing data that shows the issue.
Is there a possibility of NaN values in your data?

Closing this for now since it seems fixed in current versions. Let us know if it's still an issue.


Gemini not support SystemMessage and raise an error

System Info
LangChain: 0.0.348
langchain-google-genai: 0.0.3
python: 3.11
os: macOS11.6
Who can help?
No response
Information

[ ] The official example notebooks/scripts
[X] My own modified scripts

Related Components

[X] LLMs/Chat Models
[ ] Embedding Models
[ ] Prompts / Prompt Templates / Prompt Selectors
[ ] Output Parsers
[ ] Document Loaders
[ ] Vector Stores / Retrievers
[ ] Memory
[ ] Agents / Agent Executors
[ ] Tools / Toolkits
[ ] Chains
[ ] Callbacks/Tracing
[ ] Async

Reproduction
langchain_google_genai.chat_models.ChatGoogleGenerativeAIError: Message of 'system' type not supported by Gemini. Please only provide it with Human or AI (user/assistant) messages.
Expected behavior
no error

System Info
LangChain: 0.0.348 langchain-google-genai: 0.0.3 python: 3.11 os: macOS11.6
Who can help?
No response
Information

[ ]  The official example notebooks/scripts
[x]  My own modified scripts

Related Components

[x]  LLMs/Chat Models
[ ]  Embedding Models
[ ]  Prompts / Prompt Templates / Prompt Selectors
[ ]  Output Parsers
[ ]  Document Loaders
[ ]  Vector Stores / Retrievers
[ ]  Memory
[ ]  Agents / Agent Executors
[ ]  Tools / Toolkits
[ ]  Chains
[ ]  Callbacks/Tracing
[ ]  Async

Reproduction
langchain_google_genai.chat_models.ChatGoogleGenerativeAIError: Message of 'system' type not supported by Gemini. Please only provide it with Human or AI (user/assistant) messages.
Expected behavior
no error

+1

Is there a convenient, fast solution for adapting to Gemini?

Instead of chat models ChatVertexAi use. VertexAi
On Thu, Dec 14, 2023, 4:23 PM Casper-Mars @.***> wrote:

Is there a convenient, fast solution for adapting to Gemini?
—
Reply to this email directly, view it on GitHub
https://github.com/langchain-ai/langchain/issues/14700#issuecomment-1855624977,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFY7PMEOSFEUYZTGOIRJHADYJLLDFAVCNFSM6AAAAABAULGABGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJVGYZDIOJXG4
.
You are receiving this because you commented.Message ID:
@.***>

TODO: Gemini doesn't seem to have a concept of system messages yet.

Add the system message comment to a human/user message.

Use the below code as a basic workaround. This is basically adding both the system prompt and chat history in the human user prompt itself:
from langchain.memory import ConversationBufferMemory
memory = ConversationBufferMemory()
query="xyz"
memory.chat_memory.add_user_message(query)
result=llm.invoke(f"This is the system message that provides general instructions regarding you(AI) and the nature of the conversation : {system_message}."
f"You are also given history of the current ongoing chat between you(AI) and Human : {memory.chat_memory.messages}."
f"Respond to this new human question: "+ query)
memory.chat_memory.add_ai_message(result.content)
Markdown(result.content)

Use the below code as a basic workaround. This is basically adding both the system prompt and chat history in the human user prompt itself:
from langchain.memory import ConversationBufferMemory
memory = ConversationBufferMemory()
system_message="abc"
query="xyz"
memory.chat_memory.add_user_message(query)
result=llm.invoke(f"This is the system message that provides general instructions regarding you(AI) and the nature of the conversation : {system_message}."
f"You are also given history of the current ongoing chat between you(AI) and Human : {memory.chat_memory.messages}."
f"Respond to this new human question: "+ query)
memory.chat_memory.add_ai_message(result.content)
Markdown(result.content)


Add a prune and many cleanups

Hi,
I added the prune of the 2*2 segment and I made many cleanups. Please pull.
Regards,
-- Shlomi Fish

Sorry it took so long to accept. Didn't get github email notification and I've been traveling.

Thanks for applying it!


Chrome / IE Enumeration

Hi,
Would be possible to have as a module the --chrome-enum and ie-enum to download store/cached/cookies passwords from the browser ?
Hardest part would be to run as a chrome/ie user context, but I reckon it will be most likely users context from explorer.exe process, if migrated onto it.
Cheers

@vinicius777 It is very much possible and is on my feature list. I have some ideas on how to implement it, just need the time. Will try to push it out as a module asap.

Thanks mate!!

I don't know if you are interested, but I have developed a tool to do that and more:

https://github.com/AlessandroZ/LaZagne

It could be useful to retrieve passwords from lots of software. I will release a new version soon lighter and with new features (it will impersonate token to retrieve credentials from all users, etc.).
Feel free to use your own code if you prefer.

Just added the enum_chrome module in 74f746592ace591a021c21087812fd5818d87b13, check it out! ;)

Awesome! Thanks mate

Forgot to reference this issue in commit https://github.com/byt3bl33d3r/CrackMapExec/commit/ab611c4d52d5228be4176bccc01e434d33259d4e, basically this module will be able to dump stored IE passwords among other credentials. Currently theres a bug in the Powersploit script tho. Waiting on a fix before merging to master

Thanks for the update.  Awesome work mate! Cheers

@AlessandroZ I'll probably be creating a module for LaZagne as well, think i was running into issues injecting the binary into memory using PowerShell cause the binary was compiled with DEP support.

Good news ! It could be useful to retrieve passwords from other applications, not only Chrome.

@unl1k3ly IE and Chrome enumeration has been added in v4.0 through the mimikatz_enum_chrome, mimikatz_enum_vault_creds, and the enum_chrome modules.
You can take a quick look at the source to understand what the diffrence is between the two chrome modules ;)
Let me know how it works for you!

@AlessandroZ I'm closing this and opening up another issue for LaZagne integration.
Also have you ever successfully injected LaZagne in memory through PowerShell?

No I have never tried to inject Lazagne using powershell. My way to use it is always through a pupy shell. I have embed lazagne as a module, so it's not written on the disk and it's executed only on memory.
Using the ps1_oneliner payload, pupy can be downloaded and executed using powershell in memory without any file written on the disk. So then I use Lazagne.
So on a classic security assessment, I use your tool or another method to deploy a pupy shell on the target and then I tried to post exploit.
Let me know, if I can help you in anything, but I will understand as well that it could be complicated to embed Lazagne to your project.

@AlessandroZ I'm closing this and opening up another issue for LaZagne integration.
Also have you ever successfully injected LaZagne in memory through PowerShell?

Hi @byt3bl33d3r, did you ever get around to implementing this? Having Lazagne is CME would be super useful! Also thanks for all your awesome tools 😄


Append short commit hash to dev versions.

Also make sure that the version remains valid. Adding a dot would make
it impossible to be installed by pip, which just ignores invalid
versions (e.g. more than 3 dots).
This commit is there for 2 reasons:

It matches what the documentation says. For some reason, pbr no
longer does that.
It lets you have multiple branches with the same number of commits
away from the latest release that can generate
packages (e.g. wheels) in the same folder.

Thank you for contributing to openstack-dev/pbr!
openstack-dev/pbr uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
http://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.


How to install

How can I install it? There are only PSRs in the require section.

This depends a little on the framework you are using. I am using Symfony where the DI is doing all the magic to create the HttpComponentsManager.
I will send a sample using symfony/http-client(in require-dev) later the evening.

Thank you very much

Sorry for my incomplete answer from earlier the day.
In your project you have to require one of the clients (or an adapters) from https://docs.php-http.org/en/latest/clients.html. For testing and development I use symfony/http-client -- which is in the required-dev.
The rest is done automatically (using the php-http/discovery package), so you instantiate
$api = new BlueskyApi('nick.bsky.social', 'abcd-efgh-ijkl-mnop');
like it says in the README.md and start posting to Bluesky.

Thanks

@ulrischa could you take a look at #19? Thanks!


parallel download race condition errors out with: dest already exists

Preflight Checklist

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

Electron Packager Version:

17.2.0 <!-- (output of node_modules/.bin/electron-packager --version) e.g. 12.0.0 -->

Electron Version:

v22.2.0<!-- (output of node_modules/.bin/electron --version) e.g. 4.0.3 -->

Operating System:

Arch Linux

Last Known Working Electron Packager version::

N/A

Expected Behavior
Parallel downloads of electron always succeed without issues.

Actual Behavior
Parallel downloads of electron sometimes fail with the error dest already exists.
It basically boils down to what's described in https://github.com/electron/electron-packager/issues/1421 and https://github.com/electron/electron-packager/pull/1540
The moving of SHASUMS256.txt for each download runs into a race condition.
To Reproduce

As it's a race condition that's happening when downloading data it's not that easy to reproduce.
One way I found is adjusting @electron/get to not actually download the zipfile and only the checksum which makes it easier to download & move the checksum file at the same time.
Checksum fails afterwards for obvious reasons but at least it's quicker & easier to reproduce that way.
Additional Information

For now I've been able to fix this by not passing multiple platforms/archs at once and just running the packager multiple times.
The simple fix is to run downloads in sequence instead of in parallel but that slows down the downloading.
One other option would be with a similar fix as for the tests (see PR mentioned above) and downloading the checksum file explicitly before the other downloads run in parallel.
Another option would be @electron/get fixing it internally to prevent such an issue when it's running in parallel.

Thanks for the report @kneirinck! We've actually run into this somewhat frequently in CI on this very repo, which is annoying 😓 .


Bottle, what comes again can there?

Hey guys and @defnull!
How to open source project we need to think what's next big again in the future from the Bottle, I know it is a very complicated, but we have a roadmap. This will help new employees get close to the Bottle and active users collaborate even more.
A few points I think it's important to improve, in the process of cooperation/comunity:

Have a code review faster in the PR generated by the community, always giving feedback to users who open the PR;
Bottle has generation of new full release slowly, so we need to think of a release for 1 year (or longer), but we need to leave this open for every developer;
With the item so we need to create a roadmap before starting the development of a release, so more employees could help;

What do you think? I'm opening this issue thinking about improving our process of evolution.
These Python Conference not found many speak about Bottle, it would be extremely important to have more people talking about Bottle.
So let's bring in new developers to help our community.

wat.

I think the title of this issue has been lost in translation...

As was some of the description.


add arbritary binding options

What
I want to allow for two different registry's in core, parameterized by the datacenter.  IE use the the local registry in every case
How
Expose a way to inject bindings into the script
Why
So images are fast in both places, and allow for future customization.
Why not a proper option
I think this is more flexible.

@KnVerey

squashed etc, have a final look @KnVerey

Kir makes some good points, but otherwise LGTM. Once those are addressed, :shipit: .

@kirs @KnVerey a final look if you can.


Question (and issue?): why is Cargo.lock in the .gitignore file?

https://github.com/uutils/coreutils/blob/9bb588d69ad8a230cfcbd267e8a276ca88e442f2/.gitignore#L12
My experience is that those lock files are checked in, and these certainly seem to be, but they're also in .gitignore; that seems odd. Is that an accident of history?

I don't remember for sure, but I think it helped avoid generating extra Cargo.lock files in the utility crates/uucore in the past (or something like that).  This project has gone through a few rounds of large structural and build system changes (mainly in the pre-1.0 days of Rust).

It should not be in .gitignore for applications according to https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html

It was setup this way by developer preference.
By being listed in .gitignore, it doesn't show up as an annoyingly out-of-date file while iterating code changes, and it's less likely to be accidentally included in commit (from git add .). Committed updates are purposeful. Version updates and releases have an updated version added and re-committed to the repository.


Publish 7.5-20220628061702+0000

Publish 7.5-20220628061702+0000

@bot-gradle test and merge

OK, I've already triggered a build for you.


Remove dot that breaks GitHub auto-linking

https://help.github.com/articles/autolinked-references-and-urls/
(This is naive PR, I made it on github.com and I haven't tried out the change for real, sorry for that.)

Ah, just discovered that it is the same issue with the This issue was moved by user from owner/repo#123." line as well. Is this intentional?
I didn't dare to change this line as I don't understand why it ends with *
https://github.com/dessant/move-issues/blob/862731898c4fe889d151ff77c78066c900832341/src/move.js#L270

I didn't dare to change this line as I don't understand why it ends with *

Ah, that's just Markdown.

:wave: Thanks for contributing! I'm not able to reproduce your issue, the links touched by this PR are parsed correctly by GitHub.
Example issues:
https://github.com/flutter/flutter/issues/18147
https://github.com/org1x/repo1/issues/4

Could you share an example where the links are broken?

I’m afraid not, the move was between two private repos. I will update here if I get around to trying to reproduce it.

Thanks for following back, please open an issue when you get a chance to reproduce the bug. Let's close this, it's likely the solution would not be to remove the period from the end of the sentence.

@dentarg, I have reproduced the issue, autolinking requires read access to private repository contents. You've probably tested the markdown by editing a comment from your own account, and that's why it worked.
Issues are explicitly linked from now on to avoid requesting that permission for private repositories.
The docs list a new permission for those who deploy their own instances and need to have linking events displayed in the issue threads for private repositories.

@dessant thanks for tracking it down and fixing it! 🎉


WASM startup times slow, scale with number of ports

When I enabled wasm, it took ~5s to startup. I then applied a bunch of ports:
apiVersion: v1
kind: Service
metadata:
  name: echo
spec:
  ports:
  - name: port-25672
    port: 25672
  - name: port-4369
    port: 4369
  - name: port-4096
    port: 4096
  - name: port-5671
    port: 5671
  - name: port-35672
    port: 35672
  - name: port-35673
    port: 35673
  - name: port-35674
    port: 35674
  - name: port-35675
    port: 35675
  - name: port-35676
    port: 35676
  - name: port-35677
    port: 35677
  - name: port-35678
    port: 35678
  - name: port-35679
    port: 35679
  - name: port-35680
    port: 35680
  - name: port-35681
    port: 35681
  - name: port-35682
    port: 35682
  - name: amqp
    port: 5672
  - name: port-15672
    port: 15672
  - name: port-61614
    port: 61614
  - name: port-61613
    port: 61613
  - name: port-8883
    port: 8883
  - name: port-15674
    port: 15674
  - name: port-15675
    port: 15675
  - name: port-15692
    port: 15692
  selector:
    app: echo

The pod then took 14-20s to startup.
Times were recorded on master. I just have telemetry filters, nothing custom.

Haven't tested this in a while, worth another look


All tabs hang up if there is inactivity for few minutes

Hi,
I'm using hyper on mac and tabs hang & completely freeze after few minutes of inactivity. What should I do ?
All settings are default & only 2 plugins are installed
'hyperline',
'hypercwd'

    -
    Hyper 1.4.8
    Electron 1.7.8
    darwin x64 16.7.0

Hello! Can you try out our canary release channel, we're working hard on releasing this to everyone, but it's not yet ready. Here's instructions on how to do so: https://zeit.co/blog/canary
also, hyperline is known to cause issues, since it spawns a lot of child processes on intervals (polling git etc), so if you could try without that one too.
If you still experience problems in 2.x (canary), without hyperline, we'll need to investigate further.
Thanks  🙌

Thanks for quick reply.
I just disabled hyperpower ( which i failed to mention earlier ) and for now, there is no such issue. I will test it again tomorrow and reopen it if it persists after following your advice.
Anyways, it is really cool application. I thing I miss from default terminal is the touch pad scroll not supported with nano editor ( maybe vi/vim too but not tested there ).
Thanks

@albinekb I have disabled hyperline and it still freezes though the freeze interval is smaller than before but still ~5-10 sec freeze time.

As I'm not familiar at all with windows, I don't have any clues to what could be the issue 😞  I need to get a VB up and try it myself to get a better understanding on what goes on, but don't have time to do that now, sorry 🙁
Would be good to know if someone can reproduce this, otherwise it's something in your setup that's causing it, would be good to rule that out.

I'm on mac and using extra monitor.
To reproduce:

Open multiple applications in full screen.
Open hyper in full screen as well & open multiple horizontal/vertical tabs
Switch to other application & after sometime switch to hyper. It will be frozen.

woah, sorry I mixed this up 😂  I'll try it right now (if i can find my USB-C adapter 🙄 )

I face it when doing all of them at once. Haven't checked with 1-1 steps.

emm, new to this app, looks cool. But how can I start using it? any examples or tutorial?

@WandyLau check out https://hyper.is, or join us at https://zeit.chat if you need help 👍  This issue is for All tabs hang up if there is inactivity for few minutes, not support chat 🎉

Thanks for this thread I was also running into a hang of all tabs on Mac anytime I ran emacs. Removing hyperline alone did not fix this issue however upgrading with the canary option (now on 2.0.4) resolved the issue.
However, there's now a much less serious but annoying problem when exiting emacs the prompt and all text entered is underlined.

Sorry if I'm late to the party and if this is more obvious than I've noticed: if you're on hyper 1.4.8 you'll need to add the canary option to go to (currently) 2.1. I'll still need to watch if that fixes the problem.

Thanks, I'm on 2.1.1 (canary) and still have the underline issue after exiting Emacs.  Here's a screen shot.


[MenuItem] spacing between ListItemIcon and ListItemText

Google Material Design spec says there should be a 20px gap between the icon and the text in dropdown menus:

https://goo.gl/t6ME8T
However in Material-UI there is no difference between ListItem and MenuItem in this regard and the gap is 32px (which is correct for ListItem according to the Material Design spec).

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

A 20px wide gap between icons and text in menu items.
Current Behavior 😯

A 32px wide gap between icons and text in menu items.
Steps to Reproduce 🕹

Link: https://material-ui.com/demos/menus/#customized-menuitem
Ignore the fact the the items in the demo above are "customized" – the customization only applies to color. It's the only demo that has item icons and hence demonstrates the issue.
Context 🔦

General use.
Your Environment 🌎

Tech
Version

Material-UI
v3.9.2

React
16.8.4

Browser
any

I would like to give it a try. Can you please assign me to this issue? @oliviertassinari

@sampittko I think that the solution should start from a discussion on this issue. We have recently been talking about refactoring MenuItem to not depend on ListItem.

A quick solution is to use something like sx={{ minWidth: 44 }} on ListItemIcon.


Suggestion: Add bookmarking or something similar

Sometimes it is really annoying to have to find a block visually when you need to look at an entire mod's library of blocks. Would be really nice to save a recipe with a hotkey or to list all the recipes needed to craft a particular item. I don't know if there is a way to do this but, additionally, it would be nice if this system was aware of items you have in your inventory so it only tells you what to craft based on if you have it in your possession. Please let me know if you are open to implementing this. An example of how to look up a solar panel would produce this list:

I've thought of an addon like this for a long time, but never had the time to make it, sorry.

Yeah, I was looking into making an addon but I figured I had to learn quite a bit about java and your API before tackling it. I have a build environment set up but, haven't gone any farther.

simply bookmarking items (so they can be at the top of your item list) would be fairly easy, anything more serious is varying degrees of significant effort

Maybe something like another key binding to show all steps that NEI knows how to make an item and show like the current differents 'types of crafting' (Shaped, shapeless, smelting) and the steps could be a simple GUI with pagination on the bottom (like current multiples recipes is shown)

if there are multiple ways to make an item, how will it know which one you want to use?

I really don't know if this is good, but, my suggestion is using pagination (again) but this time on the top. Following the same behavior when I'll look an item and has more the one way to do in multiples 'types of crafting'

This way the GUI is pretty much the same that is today.

Chicken-Bones is there any way you could implement some sort of recipe saving or recently accessed recipes? It might help speed up people's workflow a TON when moving around their base and crafting.


some bugs

for child rows not called callback function of dataTable  "fnRowCallback"

after expand parent row  attribute "id" changed to id="tr-1549374473989"

for file version 1.0.1 not fixed  TreeGrid.version = '1.0.0';

@mail2dve

have no plan to add "fnRowCallback" at present
have changed "id" to "tg-id"
have fixed the version number


Make swap tokens screen being dismissed by swipe #5108

Closes #5108

Why did it not work previously?

when back button has overridden, swipe doesn't work


Allow redundant element delimiter at beginning and end

(^::abc::def::ghi::^)

As I don't intend to support multiline elements anymore, this is kinda pointless.


Start testing on PHP7

It looks like the tests are failing because composer install isn't being run before running the tests.

@djmattyg007 nice one. Thank you.


Add label to ajax promises

extracted from https://github.com/intercom/ember-model/pull/8

/cc @patocallaghan


Create a meta-pipeline to update our EKS K8s Clusters via Pulumi

Description/Context
Since we are using Pulumi to manage our K8s clusters, and there is a great deal of code behind the scenes split over a few separate modules, using a pipeline to keep them all up to date makes sense.
Plan/Design
Two open questions are cluster enumeration and version tracking.
Do we try to enumerate all our clusters automagically so new ones are added with no operator intervention, or is that too risky?
Do we need to track reseource versions separately (ungh) or can we just say that all clusters must have the latest greatest code always? This is the approach I favor but I'm willing to entertain reasons why this isn't great.

An excellent example can be found here. This contains an example of both the meta pipeline and the actual single cluster (equivalent!) pipeline that's used to populate it.

This is all good!
https://cicd.odl.mit.edu/teams/infrastructure/pipelines/pulumi-eks-cluster
and it's all green! :)


Update the premade with the same example from "Token config vision" macro

Update the premade with the same example from "Token config vision" macro
P.S. I'm pretty sure there is some error on the way i use the "lightColor" parameter, but i just can't figured out the right way, but i prefer to make a pull instead to open a issue.

Just a note, try to avoid including extranious flag data in items. Otherwise looks good 👍


Step 2: Verify the compliance of the source code

Each source code file needs to have Apache licensing header at the top. We need to implement a script called "verify_source_code.sh", to check the valid headers, after Step 1: download the source code.
We should use the directory where all the source code is saved, and the list of project names parsed in Step 1, as the input to this script.
Sub-issues can be opened to track this epic.

issue 5
I have created a gradle support to package the source code of wskdeploy, which is merged already: https://github.com/apache/incubator-openwhisk-wskdeploy
Please try to see if you can develop a bash script, to verify all the sources in a tar.gz file contain the apache headers.

@houshengbo I failed to run ./gradlew taredSources. I got a NPE.
But I run RAT with a folder option.
java -jar apache-rat-0.9-SNAPSHOT.jar wskdeploy_folder_name > rat_report.txt
And it creates a report.

@daisy-ycguo Please check this page: https://plugins.gradle.org/plugin/org.nosphere.apache.rat/0.3.1.
There is a gradle RAT plugin. After we import the RAT plugin in build.gradle, we can generate the report by running ./gradlew rat.

@houshengbo I know you implemented a gradle target taredSources  to package source files into a compressed file. It is a easy way to audit headers if we have a gradle target rat to check headers. I think that's the reason you prefer to use the gradle way. I have a PR to wskdeploy. You can checkout and have a try.
Is it easy to include a Gradle command in a travis job which will check headers for a PR? I see most travis jobs are using shell script directly. If we call a gradle command, we must install gradle before we can use it. Do you know how to install gradle in a travis job image ? Can you find a reference ?

@daisy-ycguo In fact, if we have the gradle package available under each repository, we can run the gradle command under each repo.
The gradle package is like: https://github.com/apache/incubator-openwhisk-wskdeploy/tree/master/gradle

We have already created a script: https://github.com/apache/incubator-openwhisk-release/blob/master/tools/verify_source_code.sh, to generate the report of the license headers and the existence of notice and license files for each repo.


How to fold/unfold current line

Feature description
I'm sorry to create an issue for this, but i cannot figure it out,
zM az zR folds and unfolds all the lines, i want to create a keymap to fold and unfold current line, like the arrows does in the foldcolmun.
also, thank you for this repo 👍🏻
Describe the solution you'd like
an internal command or a workaround to have the arrow functionality in the foldcolumn executable with a keyboard shortcut.
Additional context
No response

h foldopen h foldclose h foldclosed()


virt-launcher: libvirt and qemu conf cleanup

What this PR does / why we need it:
Remove duplicated settings we forcibly write in libvirtd.conf and qemu.conf since they're already present in the shipped config files.
Disable libvirt unencrypted TCP socket since we only use the unix socket to communicate with the daemon.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

virt-launcher: disable unencrypted TCP socket for libvirtd

/retest

/cc @rmohr @xpivarc @iholder-redhat
Since we were talking about conf files if you guys could take a look that'd be appreciated, thanks!

Thanks @acardace! Looks great!
/lgtm


Update for Sublime Text build 4142

Build 4142 started using ~ in file name rows. These need to be expanded for the command to work.

Confirmed working on Ubuntu 20.04.

This fixes #20 and #36.

Did this fix get merged?

No, upstream wasn't updated since 2017.
You can clone the fork to your sublime Packages dir and use the patch-1 branch. On Ubuntu, that is ~/.config/sublime-text/Packages.


Solarman LSW-5 (V3 protocol) - how to connect with HA?

I have WiFI Stock Logger LSW-5 (I think it's V3 protocol). Device serial number3503193325. Can I use solarman integration to connect with HA?
https://d2l38nissjun1p.cloudfront.net/wp-content/uploads/2022/10/Stick-Logger-WiFi-LSW-5.pdf

Die you Find a sollution ?

I have WiFI Stock Logger LSW-5 (I think it's V3 protocol). Device serial number3503193325. Can I use solarman integration to connect with HA? https://d2l38nissjun1p.cloudfront.net/wp-content/uploads/2022/10/Stick-Logger-WiFi-LSW-5.pdf

I have the same problem with Afore  - did you resolve it?

I tried communicating, I was able to get Socket check
import socket
def main():
    sock = socket.socket(socket.AF_INET, socket.SOCK_DGRAM, socket.IPPROTO_UDP)
    sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
    sock.setsockopt(socket.SOL_SOCKET, socket.SO_BROADCAST, 1)
    sock.settimeout(1.0)
    request = "WIFIKIT-214028-READ"
    address = ("<Your Data logger Stick IP>", 48899)
    sock.sendto(request.encode(), address)
    while True:
        try:
            data = sock.recv(1024)
        except socket.timeout:
            break
        keys = dict.fromkeys(["ipaddress", "mac", "serial"])
        values = data.decode().split(",")
        print(data.decode())
        result = dict(zip(keys, values))
        print(result)
if __name__ == "__main__":
    main()

Appart from I was not able to find Any thing


The whole page gets dark when you edit a registry key or are entering the LabRAD password

which is annoying.

This is an easy fix, just a matter of removing the word "modal." I'm just curious why want it changed? Is it so you can more clearly read the values behind the dialog? Are you trying to transcribe them?

We want the dialog boxes to be modal, meaning you have to deal with it before you can interact with anything else on the page. We might be able to change the style so the background doesn't darken as much, but this is a pretty standard way to indicate modality visually. @DanielSank, what specifically is your objection to the current behavior?

We might be able to change the style so the background doesn't darken as much, but this is a pretty standard way to indicate modality visually.

The problem is that the whole page turns dark, including the part you're supposed to be focusing on.

Are you saying the dialog box that pops up and wasn't there before is too dark?

Yes.

@DanielSank Can you confirm this is still an issue, and if so which dialog specifically causes the issue? I cannot say I have ever observed this behavior.

I think @DanielSank is just complaining about the polymer dialog style; the edit field has a pinkish background instead of the typical white, and he finds it too dark.

@DanielSank Could you please provide a screenshot of this issue. Your description makes it sound like a bug in the dialog window, but I cannot replicate it. Would be great to make sure we're seeing the same thing.

@adamcw, I think @DanielSank just wants to make the dialog itself lighter. This is not a bug, just a styling preference. @DanielSank, can you confirm?

@maffoo The description makes it sound more like a z-index ordering issue on the overlay mask, which is why I've asked for a screenshot to determine if this is a bug or personal preference.


fix typo

Required for all non-trivial PRs

[x] Rebased/mergable
[x] Tests pass
[ ] CHANGELOG.md updated
[x] Sign CLA (if not already signed)

Required only if applicable
You can erase any checkboxes below this note if they are not applicable to your Pull Request.

@maximesong Thanks for the PR! Looks good. Are you sure you signed the CLA? I did not find your github username in the list.

@nathanielc Sorry I misunderstood that signing CLA means git commit -s. Google Form is blocked in my country so I didn't see it at first sight. I just submitted the form.  Can you help to check the list again?

@maximesong Looks good thanks!


Allow hidden errors and warnings to be shown again

Fix copy paste typos (lines 322, 329)
Allow hidden rows in Errors and Warnings tab to be unhidden

Prior to this commit, if all errors and warnings are hidden (through the context menu), they can not be made visible again. This commit makes the "Show hidden rows" option appear in the context menu where previously no context menu would appear.

Hm, it looks like my rebase didn't quite do what I expected. Or is this how GitHub shows a rebase?

No, if you rebase and force push then the commits tab will show only the commits relative to the base branch. At the moment on your v1.x your commits are still on top of the merge commit, so it's showing everything from the common parent onwards. You'd need to rebase against an upstream commit instead.

Yep, that looks better. My git skills need some polishing up it seems!

Should I squash the three commits into one?

Smaller commits are usually squashed but that's just what I typically see and it's up to you in this case. If you want to leave them to show the development of the change that's fine with me.
I ask that the history is rebased rather than merged and that each commit individually compiles and complies with clang-format. Otherwise I try not to micro-manage the history as people's preferences vary and it gets annoying if reviewers are too picky :smile:.

That makes sense, I think I'll leave them as is in this case then.
Do you have any up to date feature-request list anywhere? The roadmap seems to not be overly relevant - or are you not actively taking feature contributions?

The roadmap is still relevant. If you mean that it hasn't been edited in a while, yes I didn't see much value in updating the wiki page when it was only myself working on features.
However since that list is old and was mostly populated by ideas I had personally rather than requested by users, I'd suggest the first port of call should be the feature request issues open on github (almost all of the open issues are feature requests - see the tags).
Feature contributions are welcome though I don't promise I'll automatically accept every PR. If you're tackling something that's not trivial I'd suggest dropping me an email or opening an issue to discuss the feature you want to add and how you plan to implement it.


[Hub Generated] Review request for Microsoft.HybridCompute to add version preview/2023-10-03-preview

This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
ARM (Control Plane) API Specification Update Pull Request
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])
If you need further help with anything, see Getting help section below.
Purpose of this PR
What's the purpose of this PR? Check all that apply. This is mandatory!

[x] New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix swagger quality issues in S360.
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to Step 2, "ARM Review", for this PR.

Breaking changes review (Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
You believe there is no need for you to request breaking change approval, for any reason.
Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

If this PR is in purview of ARM review then automation will add the ARMReview label.
If you want to force ARM review, add the label yourself.
Proceed according to the diagram at the top of this comment.

Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.
Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.
Getting help

For general PR approval workflow, see the diagram at the top of this comment.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

/azp run unifiedPipeline

        "$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ResourceGroupNameParameter"

please use the latest version v5 and update all places.

Refers to: specification/hybridcompute/resource-manager/Microsoft.HybridCompute/preview/2023-10-03-preview/HybridCompute.json:1936 in 3939ce4. [](commit_id = 3939ce49f6a5bcc25c4b8f099b8aca624956d1d3, deletion_comment = False)

      "type": "boolean",

please consider using enum instead of boolean:
https://github.com/Azure/azure-openapi-validator/blob/main/docs/enum-instead-of-boolean.md

Refers to: specification/hybridcompute/resource-manager/Microsoft.HybridCompute/preview/2023-10-03-preview/HybridCompute.json:4181 in 3939ce4. [](commit_id = 3939ce49f6a5bcc25c4b8f099b8aca624956d1d3, deletion_comment = False)

please confirm the comments and follow https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/85/Swagger-Suppression-Process to suppress PropertiesTypeObjectNoDefinition in https://github.com/Azure/azure-rest-api-specs/pull/26059/checks?check_run_id=17364203013, which seems a false alarm. Then remove ARMChangesRequested label

@ms-zhenhua It looks like updating the types to v5 created a cross-version breaking change and BreakingChangeReviewRequired. If this expected, I will fix the ModeValidation otherwise I will revert the version upgrade.

@ms-zhenhua It looks like updating the types to v5 created a cross-version breaking change and BreakingChangeReviewRequired. If this expected, I will fix the ModeValidation otherwise I will revert the version upgrade.

@vedkale, please ignore this comment if it will create breaking change. Please fix all errors in https://github.com/Azure/azure-rest-api-specs/pull/26059/checks?check_run_id=17582434759

removed labels as we made changes to the PR

The changes that caused the breaking change were pulled from . The breaking change has already been approved, can you please add the tag here too

/pr RequestMerge

@rkmanda I'm not sure if we are ready to merge this yet because I don't undertand the SDK azure-powershell schema generation etc failures. Can you please help take a look?


Add some imageset resolution metrics

This covers total jobs running / failed, and the time between cluster creation and job to resolve creation.
We've discussed revamping this so we only resolve once per cluster image set instead of for every deployment, we just need to solve the pull secret problem.

/test e2e


[CUDA] Fix CUDA transform tests for generalized mmt

Fixes the test failures reported in
https://github.com/openxla/iree/pull/16726#issuecomment-1988681370.

@ScottTodd how can I trigger test_a100 here?

@ScottTodd how can I trigger test_a100 here?

https://iree.dev/developers/general/contributing/#ci-behavior-manipulation

Add ci-extra: test_a100 to the end of the PR description


Generate flink-conf.yaml file automatically to set optimum conf values

Description of what I changed
Fixes #823

Enabled a feature flag to automate the generation of flink-conf.yaml based on the numThreads in application.yaml file and the number of cores available in the machine.
If the flag is disabled, then the flink-conf.yaml directed by the env. var FLINK_CONF_DIR will be used. If var is empty, then default conf will be used.
JAVA_OPTS can be set to override the default JVM heap and other parameter values.
The application will fail to launch if the JVM Off Heap memory is insufficient for the Flink cluster to launch.

E2E test
Tested Full Run and Incremental Run by enabling and disabling the flags. Also tested for different numThread configurations.
TESTED:
NA
Checklist: I completed these to help reviewers :)

[x] I have read and will follow the review process.

[x] I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.

[x] My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.

[x] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

[x] I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

[x] All new and existing tests passed.

[x] My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command git pull --rebase upstream master

@bashir2 The build is failing currently, I am looking into it.

@bashir2 The PR is ready for review. Since changes were made to create target jars compatible with jdk 17, the docker images had to be updated for streaming module.

@bashir2 Thanks for reviewing the changes. I have addressed/responded to the comments. Can you please have a look. Also, for few cases where unit test cases could not be written, I feel we need few more tests for e2e or performance to avoid regressions.

Thanks @bashir2 for the reviewing the changes. I have addressed some of the comments in the latest commit. Also I have created these 2 issues #893 and #891 for Validating Flink in non-local mode and Inestigating/fixing the reshuffle operations for writing to parquet files respectively.

The performance results have been attached in the PR description. No noticeable changes for the Full run, but for Incremental run the timing has improved after fixing the number of Shards to be N (Flink parallelism)


Clicking link in rich text label fails to find resource loader on FreeBSD

Operating system or device:
FreeBSD - godot 2.0
Issue description (what happened, and what was expected):
Just got godot 2.0 up and running and looking through the demo files. The rich text label demo located in demos/gui/rich_text_bbcode has two url links in the example text. These fail to open the url giving the following error (a new window pops up briefly then disappears)
ERROR: load: No loader found for resource: http:/www.google.com
   At: core/io/resource_loader.cpp:218.
ERROR: start: Failed loading scene: http:/www.google.com
   At: main/main.cpp:1425.
ERROR: free: Attempt to free invalid ID
   At: servers/spatial_sound/spatial_sound_server_sw.cpp:598.
ERROR: free: Attempt to free invalid ID
   At: servers/spatial_sound_2d/spatial_sound_2d_server_sw.cpp:612.
WARNING: cleanup: ObjectDB Instances still exist!
   At: core/object.cpp:1904.

The missing / at the start of the url could be related to the issue, adding an extra / (or several) does not help as it still shows one / in the error message. The res:// url in the [img] tag in the same example text shows the image as it is meant to, so this may be limited to parsing the [url] tag
Steps to reproduce:
Open the demo bundled in the source tree at demos/gui/rich_text_bbcode - run it and click one of the links.
Link to minimal example project (optional but very welcome):
https://github.com/godotengine/godot/tree/master/demos/gui/rich_text_bbcode

Working fine on Ubuntu, so it might be an issue related to FreeBSD platform.

bug is most likely somewhere here:
https://github.com/godotengine/godot/blob/master/drivers/unix/os_unix.cpp#L325
something must be different in FreeBSD but no idea what, so feel free to ask someone knowledgeable in that OS for help

Can this still be reproduced in the current master branch? And is only FreeBSD affected, or other BSDs too?

Sorry, should have closed this earlier.
384055c86fa7a079c fixes the cause of this.


Change the definition from anonymous function to standard class definition

HI, this package seems very nice, but it would be much better if it you change the definition from anonymous function to standard class definition so that IDE's could detect the type and provide intelligence/autocompletes .
And also the modules.exports part should be changed too.
My suggestion would be to completely drop the browser support and focus on node and avoid anonymous functions or at least provide jsdoc comments so that IDE can detect the types and provide intelligence/autocompletes.

I disagree with respect to browser support.  This library is very useful in hybrid mobile apps (e.g. cordova/phonegap) for accessing the device's sqlite database.

I think jsdoc comments are the way forward. Until very recently squel wad written in CoffeeScript which is why this hadn't been done. Actually there is decent documentation within the code, it's just not in the jsdoc format.


[ISSUE #4677] Optimize information when the variable is not set

Make sure set the target branch to develop
What is the purpose of the change
Close #4677
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.09%) to 48.853% when pulling f20bfaa1e62fe856c3db6b48c42aa94952740625 on Oliverwqcwrw:develop-optimization-proxystartup-37 into 8034690d5fc594bd03de289c350c3462e23e6cad on apache:develop.

Codecov Report

Merging #4694 (f20bfaa) into develop (3602b45) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #4694      +/-   ##
=============================================
+ Coverage      44.59%   44.63%   +0.03%
+ Complexity      7522     7521       -1
=============================================
  Files            977      977
  Lines          67582    67586       +4
  Branches        8927     8928       +1
=============================================
+ Hits           30138    30166      +28
+ Misses         33726    33702      -24
  Partials        3718     3718

Impacted Files
Coverage Δ

...n/java/org/apache/rocketmq/proxy/ProxyStartup.java
0.00% <0.00%> (ø)

...rg/apache/rocketmq/common/stats/StatsSnapshot.java
84.61% <0.00%> (-15.39%)
:arrow_down:

.../apache/rocketmq/common/stats/MomentStatsItem.java
38.09% <0.00%> (-9.53%)
:arrow_down:

...va/org/apache/rocketmq/store/FlushDiskWatcher.java
81.25% <0.00%> (-9.38%)
:arrow_down:

...va/org/apache/rocketmq/common/stats/StatsItem.java
50.00% <0.00%> (-5.00%)
:arrow_down:

...ache/rocketmq/common/stats/MomentStatsItemSet.java
43.47% <0.00%> (-4.35%)
:arrow_down:

...ava/org/apache/rocketmq/test/util/VerifyUtils.java
46.26% <0.00%> (-2.99%)
:arrow_down:

...ache/rocketmq/broker/client/ConsumerGroupInfo.java
68.46% <0.00%> (-0.91%)
:arrow_down:

...cketmq/broker/schedule/ScheduleMessageService.java
57.61% <0.00%> (-0.47%)
:arrow_down:

...mq/store/ha/autoswitch/AutoSwitchHAConnection.java
75.20% <0.00%> (-0.28%)
:arrow_down:

... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us.


Invalid syntax "def find_files(dir_path: pathlib.Path, file_exts):"

Hi,
I am trying to execute the evaluate_images.py file but it returns this error.
The semicolon in the function arguments definition returns an invalid syntax error.
Which version of Python are you using for this repo?
Best Regards

I suspect it’s complaining about the types. You need to use the latest version of python, python 3.8


Rust 2018 & MSRV bump 1.41.1 tracking issue

    I wonder if we should have a Rust 2018 tracking issue and start tagging things that are blocked on it.
    Would be good to have a clear picture of what we're missing by being on 1.29.

— @apoelstra https://github.com/rust-bitcoin/rust-bitcoin/pull/373#issuecomment-708395995

No async support (not sure we need it at the level of this library)
We can not rename packages, which creates a lot of ambiguity with serde crate/feature and prevents from using normal solutions like https://github.com/rust-bitcoin/rust-bitcoin/pull/373#issuecomment-689172390
No able to use simple derive proc macros with syn 1.0 support like in amplify_derive instead if hard-to-read impl_ macro and multiple impl From... and impl Display... blocks (and there are wrapper types as well https://docs.rs/amplify_derive/2.0.6/amplify_derive/derive.Wrapper.html)
Not able to do #[non_exhaustive] to solve the problem of breaking API changes with gated enum veriants

Checklist

[ ] async - probably only for Read and Write async equivalents
[ ] revive #373
[ ] use amplify_derive? note that this will blow up compile times for non-serde uses
[ ] Use #[non_exhaustive]
[ ] Implement TryFrom and use TryInto
[ ] sort_by_cached_key #524
[ ] Use alloc? Is this still relevant?
[ ] Use Infallible
[ ] Use contains() on ranges https://github.com/rust-bitcoin/rust-bitcoin/pull/644#discussion_r707950661
[ ] Use chunks_exact() instead of chunks
[ ] use Trait as _
[ ] Exhaustive integer matching instead of comparing with zero (improves readability)
[ ] Use iter.copied() in https://github.com/rust-bitcoin/rust-bitcoin/pull/776#discussion_r784388347
[ ] Use (;)? instead of (;)* in macros (#716)
[ ] Use literal instead of expr in macros (#716)
[ ] Usetrim_start_matches instead of trim_left_matches
[ ] Use Vec::from([foo]) instead of Vec::new followed by v.push().
[ ] Change cause() to source() in impl of std::error::Error
[ ] Use u16::to_be_bytes instead of swap_bytes

non_exhaustive types:

[ ] Error
[ ] AddressType
[ ] address::Payload
[ ] LeafVersion (if #718 got merged)

PR list:

[ ] #635

TryInto, see https://github.com/rust-bitcoin/rust-bitcoin/pull/498 and probably many othercs

sort_by_cached_key, see https://github.com/rust-bitcoin/rust-bitcoin/pull/524 (Rust 1.34)

stable alloc crate requiring 1.36 https://github.com/rust-bitcoin/rust-bitcoin/pull/528

CommandString::try_into (see CommandString refactor as part of https://github.com/rust-bitcoin/rust-bitcoin/pull/496) can use TryInto (Rust 1.34)

1.36 is also the (current, may change without major version bump) MSRV of rand 0.8, whose non-optional dep tree now consists of rand-core and nothing else.

Possibly this crate could be interesting for us https://crates.io/crates/standback

Possibly this crate could be interesting for us https://crates.io/crates/standback

mrust can compile rustc 1.39 now. https://www.reddit.com/r/rust/comments/mjxbaz/mrustc_upgrade_rustc_1390/

mrust can compile rustc 1.39 now. https://www.reddit.com/r/rust/comments/mjxbaz/mrustc_upgrade_rustc_1390/

Nice!

Any opposition to moving to 1.39 then for rust-bitcoin 0.27? I can open another discussion issue. cc @TheBlueMatt 1.29 is really old now and is causing us a lot of grief especially with respect to nostd/alloc.

Hmm, in general I think I'm fine with 1.39. It is less than two years old, though, so not sure if we don't want to use 1.34 (which is about two years old) or 1.36 (for alloc). I do admit it would be cool to go right to 1.39 and use async in a few places.

I think we could wait for the beginning of July and then jump to 1.36 (which aside from being "the one with alloc" also felt to me like a more important/well-tested release than 1.34 or 1.39).

As for using async I think that'd be a major change, though I guess if it were localized maybe not. And the upcoming API overhaul + transition to Rust 2018 would already be major changes, and it might be good to stagger them.

Right, I was mostly thinking of (optionally) using async in rust-bitcoincore-rpc  by porting the lightning-block-sync stuff to there.

yeah I don't think rust-bitcoin itself should be async, maybe when we have AsyncRead/AsyncWrite in libstd then we might want to add support for these in the Encode/Decode traits

As for bumping, I can come up with a summary of what features we might want and what versions they exists in,
the first things that come to my mind are mostly dependencies (latest rand: 1.36, cc: 1.34, serde_derive: 1.31)

Alright, lets plan on 1.36 Soon (tm), then. We may actually go ahead and do it in RL because we're already at 1.30 (due to cargo bug that prevented us from using 1.29) and I'm tired of trying to make cc work right.

Upgrade to 1.36 actually means we can use syn with its MSRV 0.31, and finally do derives instead of macros for many occasions.
I just completed development of a 1.31-compatible library simplifying creation of complex derivation macros to a big degree: https://docs.rs/amplify_syn/. You can see a sample of what it can be done with it here: https://github.com/LNP-BP/rust-amplify/blob/master/derive/src/lib.rs#L480-L553
Upon MSRV increase I will be happy to refactor rust-bitcoin code to introduce derivation macros using it (we already had one attempt in the past by @elichai, but then we were blocked by MSRV requirement).

As of July 4 1.36 was two years old, so I think we can do this whenever now. https://blog.rust-lang.org/2019/07/04/Rust-1.36.0.html

One more thing to consider: use base64 (MSRV 1.36) instead of base64-compat because mot libraries use that one anyway so we don't needlessly duplicate dependencies.

Let's compile a checklist:

[ ] async - probably only for Read and Write async equivalents
[ ] revive #373
[ ] use amplify_derive? note that this will blow up compile times for non-serde uses
[ ] Use #[non_exhaustive]
[ ] Implement TryFrom and use TryInto
[ ] sort_by_cached_key #524
[ ] Use alloc? Is this still relevant?
[ ] Use Infallible

With 1.34 apparently we get convert::Infallible which is pretty cool, see https://github.com/rust-bitcoin/rust-bech32/pull/43/

Already in my list :)

@Kixunil can you add the following to your list above please

Remove usage of use Hash as HashTrait, replace with impl crate::Hash for Foo and use Hash as _.

Discovered over here: https://github.com/rust-bitcoin/bitcoin_hashes/issues/16

Not a huge fan of it but added anyway. We can discuss further when it's relevant.

https://github.com/rust-bitcoin/rust-bitcoin/pull/638 use rustdoc::broken_intra_doc_links

@RCasatta that one is even later, I think

Could this issue be better titled Bump MSRV tracking issue?

On January 30 Rust 1.41 will be two years old.
https://blog.rust-lang.org/2020/01/30/Rust-1.41.0.html

I would've liked 1.41.1 ((Feb 27)[https://blog.rust-lang.org/2020/02/27/Rust-1.41.1.html]) more because of fixed issues and not being super-ancient. (It's in Debian oldstable)

I'd be ok with 1.41. It's only two versions ahead of mrustc support.

+1 for Rust 1.41.1, with the suggestion by the Rust team to not use 1.4.0 seems that we should specify the dot release not just 1.41

With Taproot release imminent, I've been spending some time thinking through the MSRV update across the board. PRs for rust-secp256k1 and rust-bitcoin were already done by @elichai and @Kixunil respectively. I hope I am not treading on your toes. I've pushed branches to my own tree for both with changes to make them fit in with what I propose the mantra for this biggish change should be - "minimum code changes to get the code to build with edition 2018 enabled". We can do a bunch of follow ups, it is going to be hard enough to co-ordinate updating all the crates together without adding any additional ~bikeshedding~ reviewing.
Note:

Clippy changes are equired when clippy runs in CI (bech32 and bitcoinconcensus) - these PRs will need squashing.
Removal of leading :: is not strictly inline with the mantra but fits in with fixing import statements so its included.

PR list

rust-bech32
rust-bitcoinconcensus
bitcoin_hashes
rust-secp256k1
rust-bitcoin

PRs from above with only minimal changes (links to my tree):

rust-secp256k1
rust-bitcoin

Followups (containing the work of @elichain and @Kikunil

rust-secp256k1
rust-bitcoin

Definitely not treading on my toes. Thanks so much for doing this!
cc @TheBlueMatt are you okay with

Bumping MSRV to rustc 1.41.1, which will be 2 years old in a couple weeks, and is two versions ahead of mrustc's 1.39 support, and is in Debian stable (though only for popular arches)
Doing an ecosystem-wide MSRV bump as the next project after the rust-bitcoin Taproot release

+1 for 1.41.1

Oops, sorry I'd missed this before. I'm okay with 1.41.1, though given where mrustc is we may end up kinda stuck there for some time :/

I've moved the checklist to the issue description to be easier to find. Hope @dr-orlovsky doesn't mind...

though given where mrustc is we may end up kinda stuck there for some time :/

I don't think so, mrustc allegedly supports 1.54

Nice, that's pertty new! Their readme still says 1.39.0, but I guess they're working on more.

+1 for 1.41.1

Relevant: https://www.reddit.com/r/rust/comments/ttaqay/progress_report_10_rustc_codegen_gcc_can_now/

As you may have guessed from the title of this blog post, the GCC codegen has made enough progress to be able to compile rustc itself! That’s a huge milestone!

We should start working on this now that we have 0.28.0

Can we first get existing PRs merged? At least mine. :)

Sorry for missing this. Working on reviewing it

Thanks for creating the tag. Reviewers can be before MSRV bump tag to see which PRs to review before MSRV bump.
I have no opposition to merging those before the MSRV update, I am wondering why those must be done before the MSRV update? @Kixunil

It'll be less churn merging existing PRs and then changing editions because changing edition is mostly automated process. See https://github.com/rust-bitcoin/rust-bitcoin/discussions/945

To save anyone else trying to grep for things on the checklist like I've been doing for the last two hours - clippy will find many of these for us :)

Renamed the tag to "before edition bump" as it better conveys the idea. IOW we can absolutely merge #964 before these.

Related 'Discusssions' thread: https://github.com/rust-bitcoin/rust-bitcoin/discussions/945

I've checked off all the basic ones crew, many of the others I either do not understand how to do or I do not understand the motivation behind doing them. If you put one on the list, and would like to see it implemented without having to do it yourself, please throw a comment here with a bit more context and I'm happy to do it. Thanks.

Adding #[non_exhaustive] attribute to the listed types would be great. It ensures forward compatibility.
$(,)? in macros is cosmetic.

I had a think about the non_exhaustive task. I have a question: Why only do Error, if we are justified in doing one error why not do all of the error types?

Does anyone remember where Infallible was supposed to be used?

I scratched alloc from the list, flagging it here because I'm not 100% sure that is correct.

@tcharding I think by Error I meant all error types. :)
$ rg --multiline 'enum.*\{[ \t\n]*\}'
src/blockdata/script.rs
173:enum Uninhabited {}

Uninhabited should be removed and replaced with Infallible
We can skip alloc because the library is mostly useless without it and it'd be easier to do with Amount & co in a separate crate.

Cool, cheers.

There are only a few things to go on the list.

The Infallible/Uninhabited thing
The two checklist items at the top that do not have PRs, neither of which I'm know if we still want, anyone?

" async - probably only for Read and Write async equivalents"
"use amplify_derive? note that this will blow up compile times for non-serde uses"

amplify_derive is a crate which I did to simplify deriving Errors and Displays all around, which may be useful here. That crate has very few dependencies (comparing to other error/display derive crates), and matches MSRV after its bump. So it's up to you to decide whether to use it here or continue maintaining larger codebase for each error.
Me and @Kixunil are maintainers of that repo (he contributed to other parts of the amplify lib family) and I can add more maintainers from here to ensure safety of the use of the library & reviews requirement for any codebase changes.

async - that was about adding support to async functions, for instance for implementing non-blocking consensus encoding/decoding with io::Read/Write - this may be useful, for instance when they are used in serializing large structures (blocks) to files by projects like electrum server (personally I do not need it, since I am using different approach to a non-blocking architecture with ZMQ and microservices - and not rust async which I do not like).

Exactly what @dr-orlovsky said. Those two are definitely not required for the issue to be complete and are more "nice to have" things that could be added at any time in the future. IMO it's even better to skip them to release more quickly.
@tcharding I belive we already did Infallible. I checked also wrong uses of () and while there is one in AddressType it's not infallible, just a bad error type.

My bad.

The checklist is complete - closing.


Add Firewall setting for tracking file changes.

I believe this should mention that the "Firewall Settings must be Allow All Networks " on the storage account.
https://docs.microsoft.com/en-us/azure/automation/change-tracking/manage-change-tracking#track-file-contents

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 53fc5d6e-e0cf-7b56-c3b3-6f7aa7d58b37
Version Independent ID: 63faa0a3-f541-2e23-384d-b27371bb9eaa
Content: Manage Change Tracking and Inventory in Azure Automation
Content Source: articles/automation/change-tracking/manage-change-tracking.md
Service: automation
Sub-service: change-inventory-management
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

@PatrikHanssonIntersolia Thanks for your comment. We will review the issue and get back to you shortly.

Apologies @MGoedtel for delayed notice. Assigning it to you for review and document enhancement consideration as appropriate.

Based on review of this article Configure Azure Storage firewalls and virtual networks it states that by default, storage accounts accept connections from clients on any network. Based on my assessment, I'll update the article to reference this article and I'm also basing this on the lack of other issues or similar feedback provided in relation to your suggestion.  I'll bug this article and get it updated this week or next week the latest.  Thanks!  #please-close


Installing shell command 'code' in PATH does not persist

VSCode Version: Version 1.7.2 (1.7.2)
OS Version: macOS Sierra 10.12.1 (16B2657)

Secondary problem: If you create a permanent symbolic link or addition to ~/.bash_profile referring to code, VS Code complains about it. So you're stuffed either way.
Steps to Reproduce:

Ran the Shell Command: Install 'code' command in PATH.
Open new terminal window, code will launch VS Code.
Restart machine OR even just close VS Code and then restart terminal.app...
Fail

I doubt it's the configuration of my~/.bash_profile – as any and all other PATH additions are working correctly... I include it below for reference, as you can see it is very minimal:
export GOPATH=$HOME/go
export GOSRC=$GOPATH/src
export PATH=$PATH:$GOPATH/bin
export GOBR=$GOPATH/src/github.com/benjamin-rood

#code () { VSCODE_CWD="$PWD" open -n -b "com.microsoft.VSCode" --args $* ;}

The commented-out code script works, btw.

This command will place code inside /usr/local/bin, can you confirm this? Why does your machine clean that folder when restarting?

I am experiencing this issue.
A link is being created at /usr/local/bin/code
The first one is:
/usr/local/bin/code@ -> /private/var/folders/k3/rp4pclyd7cq3_yfntqx4533w0000gn/T/AppTranslocation/8501FF93-8B84-4304-83CC-96BA4F61C002/d/Visual Studio Code.app/Contents/Resources/app/bin/code
If I exit VS Code, the link breaks, and when I re-run the install 'code' command in path, the new link is:
/usr/local/bin/code@ -> /private/var/folders/k3/rp4pclyd7cq3_yfntqx4533w0000gn/T/AppTranslocation/C2E2789E-2364-4FEE-B928-67A35D4493B6/d/Visual Studio Code.app/Contents/Resources/app/bin/code
(Throwing this in since my config is slightly different from the original poster)
VSCode Version: Version 1.9.0
OS Version: macOS Sierra 10.12.3

I did some digging on my own, and I suspect the issue is related to placing the application in the ... "global" Applications folder, not my user Applications folder.
I moved the binary there to see if that fixed an issue with the automatic updater, and my code command started working properly now.

Stuck with this same issue but moving VS Code to ~/Applications or /Applications doesn't appear to make a difference. The code command doesn't seem to persist (it is similarly symlinked into that /private/var/folders business). It also looked like updates weren't persisting either.
OS: macOS 10.12.2
Trying with a fresh download of Code 1.11.2, I'll report back when the issue pops up again. This certainly is a curious one.

Same underlying issue as #7426.
The location of the app is irrelevant. Only the quarantine attribute matters. More info here. Mitigation fix coming this month

Gotcha, thanks for the update.
On Tue, Apr 18, 2017 at 12:30 AM João Moreno<EMAIL_ADDRESS>wrote:

Closed #17475 https://github.com/Microsoft/vscode/issues/17475.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/17475#event-1046112130, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADYphxtR9CmP3d88_L2ApT4xYYx9nSMks5rxGaqgaJpZM4LQAn6
.

Remove /usr/local/bin/code and reinstall the shell command from the command palette fix it for me.


Support for additional threshold types

Hi,
Just wondering if there is anything in the works to support baseline or outlier threshold types?
https://docs.newrelic.com/docs/alerts-applied-intelligence/new-relic-alerts/alert-conditions/create-nrql-alert-conditions/#threshold-types

Hi,
Currently, we mostly accept changes from the community.
I encourage you to add those threshold types yourselve and we will review them


Php 7.4 Array and string offset curly braces is deprecated

In php7.4 array and string offset curly syntax is deprecated.
lib/openpgp.php:127,129,133,138,140
i didnt check other files.

Forked and fixed: https://github.com/hwmatthewa/openpgp-php


fix bug: bad double quotes to single quotes in internet plugins for korean bank

#13004
#13008
i’m sorry, i think i forgot to fix it.
i fixed bad double quotes.

@hyuna917 Just so you know, you don't have to keep closing these PRs and opening new ones. You can just push new commits to the same branch.

Also, judging from the commits listed in this PR, you really need to rebase your branch onto our master.

i didn’t know that! thank you @jawshooah

There's something strange going on with your branch, it seems. Try running git fetch origin master && git rebase origin/master feature/add-plugins-for-banking && git push --force.

 It was my first time to do rebase. @jawshooah, do you think now it’s okay?

Nope, something has gone terribly, terribly wrong.

i think i should remake a branch


Implementing the callPackage pattern with PureNix

Hello,
Thanks for this great project! I'm looking to better understand what is possible or not to do with Nix PureScrip backend, and mainly how we might replicate the callPackage pattern? I looked a bit over the internet, without success, about how to write a Nix package, a NixOS option or configuration using PureNix, before trying to hack on that myself. Are you aware of existing examples or discussions about this? If not, are there any known challenges or obstacles in doing so?
Thanks!
On a side note: Is there a way to structure PureNix's output, output/Main/default.nix, so that it aligns with the flakes' syntax?

Thanks a lot for your detailed answer! It matched what I somehow figured out while experimenting with the tools :)


[@minecraft/server-net] Add support for PATCH requests

Is your feature request related to a problem? Please describe.
As of now, the server-net module supports GET, POST, PUT, HEAD and DELETE. But for some reason not PATCH.
Describe the solution you'd like
Add an option to send PATCH requests
Describe alternatives you've considered
If you have access to any API's, you can change any PATCH requests to be instead PUT requests, but this is not so simple if the API has been around for a while, or if you don't own the API.

Thanks for the feedback! Opened up an internal request for tracking.


Running Azurite as background process on Azure DevOps

Which service(blob, file, queue, table) does this issue concern?
All
Which version of the Azurite was used?
3.4
Where do you get Azurite? (npm, DockerHub, NuGet, Visual Studio Code Extension)
npm
What's the Node.js version?
12.13.0 (https://github.com/actions/virtual-environments/blob/master/images/win/Windows2019-Readme.md)
What problem was encountered?
I want to run Azurite in order to run blob storage unit tests during an Azure DevOps build.  There apparently was a command line option of '&' that would run Azurite in the background (https://devkimchi.com/2019/10/16/azure-storage-emulator-on-azure-pipelines/) but this does not appear to work in V3.
Steps to reproduce the issue?

Create a DevOps build process.
Add a step to install Azurite through npm
Add a step to run a Command, such as 'azurite -s -l c:\azurite -d c:\azurite\debug.log;

Result: Build process stays stuck on Command step where Azurite was executed.
Desired: Azurite runs in the background so that later build steps can take place.
Have you found a mitigation/solution?
None

Hi @chriswill
Please try azurite & in Linux, or start /B azurite in Windows cmd to start azurite in background

Thanks, that's helpful.

Would be nice to have the info as part of the readme.md

Hi @chriswill
Please try azurite & in Linux, or start /B azurite in Windows cmd to start azurite in background
worked successfully

I'm sorry, but this is not a solution. If you go Start /B azurite, console still needs to be running, so might as well just have it running in the console. The problem is that nobody wants to have random console windows floating about all the time.

@trailmax
I figured out one way how you can achieve it - I added the Azurite to the Local Group Policy Editor as the Logon script. It starts silently without any application in the tray.
Script Name:
C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe
Script Parameters:
azurite --location c:\azurite -s


Add usage instructions

Hi
The tool looks great, but it is not obvious, how to actually use it :)

You are right. I should add a blurb when the tool is launched without any arguments...

Btw i currently use a globally installed rimraf, seems to do the job

Fixed by commit cf922a2 (version 1.2.1537.0).


Discussion Medium and API Reference

Hello,
Since this is currently the most comprehensive UI library, is there any plan to set up a discussion forum/or any other media like IRC channel or as such.
Also, do you plan to host a generated API reference in a repo?

Is this an automatically generated message by a github bot? OK, does not really matter.
I do not really think that gintro is "the most comprehensive UI library" for Nim, there are many other. OK, I had never used the other ones, but they exist.
And I do not know if currently someone is using gintro at all. There was Mr lscrd who posted some issues and some nice comments, but I don't think that he is still using gintro. And I myself, yes I intend to use it, but I have still to port a larger Ruby GTK project, which is some work, and there is a lot other stuff do do currently...
So I can not see a real reason for a forum/IRC or whatever. API reference? Yes maybe. But not yet, as long as estimated number of users is between zero and one. C doku, with that devhelp tool is really not bad, as Nim calls are very similar to C calls. (If you know how you would code it in C, it is really straight forward how to do it in Nim. If one does not know, well then one has to learn GTK. I had that experience some years ago when using Ruby-GTK. But fortunately Nim-GTK is much easier.)
As I wrote in the gintro docu, Nim GTK is OK for people familiar with GTK and coding mostly for Linux. For other people there may exist better GUI toolkits.
And finally I have to admit that I am not really a GTK expert.


Also name the thread properly for better troubleshooting.

A quick search revealed more ExecutorService need to be closed. Mark WIP at the moment.

pushed relevant fixes


Rotate does not work

Hello sir,
I am stuck at this problem for quite some time now. I am trying to rotate a canvas but failing. What might be wrong in this snipped. I am using canvas library. It is compiling fine but the canvas does not rotate. I have tried differed rotation angles.
rotateLogo :: Eff (canvas :: CANVAS) Unit
rotateLogo = void $ unsafePartial do
  Just canvas <- getCanvasElementById "canvas"
  ctx <- getContext2D canvas
  void $ rotate (pi * 1.5 ) ctx
  translate { translateX : 0.0, translateY : 0.0 } ctx

This is not how rotation works with HTML5 Canvas. I'd recommend reading the canvas docs first, but the idea is that it modifies the state of the context, for future renders. It doesn't modify the existing content of the canvas.