NA and null fields despite --disable-cri-async

Describe the bug

We keep getting alerts that have fields with NA and null values. Specifically, this causes false positives for the Non sudo setuid and Redirect STDOUT /STDIN to Network Connection in Container alerts, which is due the container.image.repository field that is left null. Here are example logs of the alerts we are getting:
{"hostname":"falco-t5qqr","output":"16:36:38.125465102: Notice Unexpected setuid call by no
n-sudo, non-root program (user= user_loginuid=-1 cur_uid=4294967295 parent=<NA> command=<NA
> pid=1591192 uid=<NA> container_id=host image=<NA>) k8s.ns=<NA> k8s.pod=<NA> container=hos
t","priority":"Notice","rule":"Non sudo setuid","source":"syscall","tags":["T1548.001","con
tainer","host","mitre_privilege_escalation","users"],"time":"2023-07-26T16:36:38.125465102Z
", "output_fields": {"container.id":"host","container.image.repository":null,"evt.arg.uid":
"<NA>","evt.time":1690389398125465102,"k8s.ns.name":null,"k8s.pod.name":null,"proc.cmdline"
:"<NA>","proc.pid":1591192,"proc.pname":null,"user.loginuid":-1,"user.name":"","user.uid":4
294967295}}

{"hostname":"falco-t5qqr","output":"15:41:47.009203551: Notice Redirect stdout/stdin to net
work connection (user=root user_loginuid=-1 k8s.ns=calico-system k8s.pod=calico-node-8klhg
container=ba1fb44b8f96 process=calico-node parent=calico-node cmdline=calico-node -felix pi
d=1535895 terminal=0 container_id=ba1fb44b8f96 image=<NA> fd.name=<IP_ADDRESS>:50382->127.0.0.
1:9099 fd.num=0 fd.type=ipv4 fd.sip=<IP_ADDRESS>)","priority":"Notice","rule":"Redirect STDOUT
/STDIN to Network Connection in Container","source":"syscall","tags":["T1059","container","
mitre_discovery","mitre_execution","network","process"],"time":"2023-07-26T15:41:47.0092035
51Z", "output_fields": {"container.id":"ba1fb44b8f96","container.image.repository":null,"ev
t.time":1690386107009203551,"fd.name":"<IP_ADDRESS>:50382-><IP_ADDRESS>:9099","fd.num":0,"fd.sip"
:"<IP_ADDRESS>","fd.type":"ipv4","k8s.ns.name":"calico-system","k8s.pod.name":"calico-node-8kl
hg","proc.cmdline":"calico-node -felix","proc.name":"calico-node","proc.pid":1535895,"proc.
pname":"calico-node","proc.tty":0,"user.loginuid":-1,"user.name":"root"}}

How to reproduce it

Trigger a rule that filters based on container.image.repository.
Expected behaviour

The fields should be populated.
Screenshots

Environment

Falco version: 0.35.1

Cloud provider or hardware configuration: Azure AKS
OS:

NAME="Common Base Linux Mariner"
VERSION="2.0.20230630"
ID=mariner
VERSION_ID="2.0"
PRETTY_NAME="CBL-Mariner/Linux"
ANSI_COLOR="1;34"
HOME_URL="https://aka.ms/cbl-mariner"
BUG_REPORT_URL="https://aka.ms/cbl-mariner"
SUPPORT_URL="https://aka.ms/cbl-mariner"

Kernel:

Linux aks-main-41112315-vmss000000 <IP_ADDRESS>-1.cm2 #1 SMP Wed Jun 21 23:17:09 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Installation method: ArgoCD (Helm chart) to Kubernetes

Additional context

We already tried to pass the --disable-cri-async flag to Falco and our path to CRI socket for container metadata, --cri <path>, is properly set.

Falco version: 3.3.0

Do you mean 0.33 ? :thinking:

Falco version: 3.3.0

Do you mean 0.33 ? thinking

I guess it's the Helm chart version.

Falco version: 3.3.0

Do you mean 0.33 ? 🤔

My bad. Yes, I put the Helm chart. It's version 0.35.1.

@Caroline132 just double checking is it always null for any rule that triggered in a container workload? Or just sometimes null?
If it is always null something is wrong. if it is sometimes null, it's because things are never perfect in production ...
container runtime is contaienerd I suppose?

@Caroline132 just double checking is it always null for any rule that triggered in a container workload? Or just sometimes null?
If it is always null something is wrong. if it is sometimes null, it's because things are never perfect in production ...
container runtime is contaienerd I suppose?

The container.image.repository field is always null for those specific rules (i.e., Non sudo setuid and Redirect STDOUT /STDIN to Network Connection in Container). However, there are other rules that are triggered that have the container.image.repository field as non-null.
And yes, the container runtime is contaienerd.

Thank you for reporting back. Likely it's not related to the specific rule.
I just opened a new ticket to track re-auditing the container engine as it has been on top of my mind at least for a while now to see if we can improve something. https://github.com/falcosecurity/falco/issues/2708
Curious would you be able to add %container.duration to all of your rules and see if it for example fails more often for events closer to container start or if there are also patterns showing it happens anytime in the container lifetime? Thank you.
https://falco.org/docs/reference/rules/supported-fields/#field-class-container

Thank you for reporting back. Likely it's not related to the specific rule.
I just opened a new ticket to track re-auditing the container engine as it has been on top of my mind at least for a while now to see if we can improve something. #2708
Curious would you be able to add %container.duration to all of your rules and see if it for example fails more often for events closer to container start or if there are also patterns showing it happens anytime in the container lifetime? Thank you. https://falco.org/docs/reference/rules/supported-fields/#field-class-container

Thanks for the update and opening the new ticket! I'll add %container.duration to my rules and monitor the results. I'll keep you posted.

@Caroline132 thank you for reporting back. We will start investigating what could be done. First we need to run more thorough debugging what the circumstances are when this happen. It likely will take some time and caution. Once we know more we can post some ETA.
As mentioned above we will track this in https://github.com/falcosecurity/falco/issues/2708

@Caroline132 thank you for reporting back. We will start investigating what could be done. First we need to run more thorough debugging to understand what the circumstances are when this happen. It likely will take some time and caution. Once we know more we can post some ETA.
As mentioned above we will track this in https://github.com/falcosecurity/falco/issues/2708

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale
we are still on it and just added new libsinsp state metrics also around the container engine -> let's see what the data reveal in next 2 weeks.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale
still relevant and happening

@jemag perfect timing: We just merged a PR aimed to improve things, see my comment here: https://github.com/falcosecurity/falco/issues/2708#issuecomment-1969575503. I hope you will be able to benefit from these improvements starting with Falco 0.38.0.
Longer term, we have identified more improvement opportunities; however they will take more time.
CC @leogr for awareness.

cc @therealbobo @jasondellaluce @LucaGuerra

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale

/milestone 0.39.0

@Caroline132 would it be possible to give Falco 0.38.0 a try and see if things have slightly improved?
We never expect it to be perfect since API lookups take few milliseconds, but we will continue to refactor and improve the container engine for 0.39.0.

Hi @incertum, we ran the Falco 0.38.0 overnight on two clusters and found that there are still null fields. For example, this instance of Redirect STDOUT/STDIN to Network Connection in Container has the container image information missing, despite the fact that we know it's coming from Velero:
{"hostname":"aks-zone2-18206000-vmss000000","output":"10:52:25.628489682: Notice Redirect stdout/stdin to network connection (gparent=<NA> ggparent=<NA> gggparent=<NA> fd.sip=<IP_ADDRESS> connection=<IP_ADDRESS>:34
814-><IP_ADDRESS>:8085 lport=8085 rport=34814 fd_type=ipv4 fd_proto=fd.l4proto evt_type=dup3 user=<NA> user_uid=65532 user_loginuid=-1 process=velero proc_exepath= parent=<NA> command=velero server --uploader-type
=kopia --log-format=json terminal=0 container_id=5c9a8da546b2 container_image=<NA> container_image_tag=<NA> container_name=<NA> k8s_ns=<NA> k8s_pod_name=<NA>)","priority":"Notice","rule":"Redirect STDOUT/STDIN to N
etwork Connection in Container","source":"syscall","tags":["T1059","container","maturity_stable","mitre_execution","network","process"],"time":"2024-05-31T10:52:25.628489682Z", "output_fields": {"container.id":"5c9
a8da546b2","container.image.repository":null,"container.image.tag":null,"container.name":null,"evt.time":1717152745628489682,"evt.type":"dup3","fd.lport":8085,"fd.name":"<IP_ADDRESS>:34814-><IP_ADDRESS>:8085","fd.r
port":34814,"fd.sip":"<IP_ADDRESS>","fd.type":"ipv4","k8s.ns.name":null,"k8s.pod.name":null,"proc.aname[2]":null,"proc.aname[3]":null,"proc.aname[4]":null,"proc.cmdline":"velero server --uploader-type=kopia --log-
format=json","proc.exepath":"","proc.name":"velero","proc.pname":"<NA>","proc.tty":0,"user.loginuid":-1,"user.name":"<NA>","user.uid":65532}}

Hey @Caroline132 statistically what percentage of containers in the logs are null? Could you add container.duration output field?
[Please note that if a container just starts we need to make an API call, which takes at least 500ms, hence in these conditions it is expected that the event has no container information as we do not halt the main kernel event processing thread.]

Hi @incertum, I ran Falco over the weekend and for Redirect STDOUT/STDIN to Network Connection in Container all of the events have null values (even with the duration > 500ms). The null values seem to only be associated with certain rules (while others have no null values, with container image information filled).

@Caroline132 thanks for reporting back. I am currently unsure why you see null values for all container info fields in only a subset of rules, and I don't know how to debug this issue. You would expect these imperfections to appear across all rules, with a certain percentage of logs having all null fields, distributed a bit more uniformly across all container rules.
We can and will try to improve the container engine even more, but unsure if it would fix the issues you are seeing.

One more thought: Maybe worth a try also exporting k8s.pod.sandbox_id and if it's the same as the contaienr.id then the rules in question trigger on sandbox containers that do not have an image. In those cases all fields are expected to be null.

@incertum k8s.pod.sandbox_id is also null.

to add further details, if we use the container.id we can find the related container image:

I am not aware of anything about the velero image that would prevent fetching its information.

Thanks for the additional info. It seems like all requests are just failing for that container and you hit this code block https://github.com/falcosecurity/libs/blob/74725244659e556ced587c2f0bec7bbd42d39b96/userspace/libsinsp/cri.hpp#L775-L778 so it seems. Which is extremely strange I admit.
Even wondering if we should emit a few more metrics within the metrics framework https://falco.org/docs/metrics/falco-metrics/ around containers. Within the state_counters_enabled category we currently only emit a current snapshot of the number of cached containers falco.n_missing_container_images, falco.n_containers ... perhaps it may be useful to keep a counter around completely unsuccessful lookups. Maybe you have more ideas?

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

/remove-lifecycle stale
Moving to next milestone; we are currently in the process of renew our container runtime support through a new plugin; it will take a bit of time but the effort should help us fix all these little bugs here and there.
/milestone 0.40.0

Turns out following changes made during https://github.com/falcosecurity/falco/issues/2487 a while ago, we removed the unconfined apparmor profile and unfortunately forgot to add it back.
After adding the unconfined profile again, we have not seen a missing container.image.repository yet (by we I mean @Caroline132  and I).

Top, great news, thanks!
Can we close this then? :)

Assuming this is fixed
/milestone 0.39.0

/close
since Falco 0.39 is out!

@leogr: Closing this issue.

In response to this:

/close
since Falco 0.39 is out!

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.


Ctrl+Alt+ UpArrow/DownArrow  Creates additional cursor

VSCode Version: Code 1.6.1 (9e4e44c19e393803e2b05fe2323cf4ed7e36880e, 2016-10-13T16:21:53.542Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions: none

Steps to Reproduce:

Open file to edit
Ctrl+Alt+ (UpArrow or DownArrow)

hey @joshualemli after press ctrl+alt+up, try press keys /a-zA-Z0-9/ and you will see it's our multi cursor feature.


[Issue #289.6] Implementation of PassThroughBean

-Implementation of PassThroughBean
Get done with PR #341 first

LGTM.


Unable to download JSON metadata

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2<IP_ADDRESS> (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Description
Hello,
Since several days can't download videos from "ARTE" channel.
Verbose log
(arte_env) pavel@ALABAMA:~/arte_env$ yt-dlp https://www.arte.tv/fr/videos/065287-001-A/beau-sejour-1-10/
DeprecationWarning: Support for Python version 3.6 has been deprecated and will break in future versions of yt-dlp! Please update to Python 3.7 or above
[ArteTV] 065287-001-A: Downloading JSON metadata
ERROR: [ArteTV] 065287-001-A: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by <HTTPError 404: 'Not Found'>); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
(arte_env) pavel@ALABAMA:~/arte_env$

Hello, i think this related to #3302

I think this issue is duplicate of #3622

@HobbyistDev Thanks for the help in triaging. I have noticed you adding these comments in many issues ❤


Log compilations?

Is it possible that we could get gulp-bable to call gutil.log() for each file it compiles, like babel-cli does?
src/a/b/c.jsx -> dist/a/b/c.js

Thank you!

Use something like gulp-debug for that.


Bank Holidays

Hello - are you using https://www.gov.uk/bank-holidays.json for source data?

Yes and no!
This data at the moment feeds off of an internal SharePoint list that includes Bank Holiday data which has been imported from there together with additional Guildford specific office closure days.
It would be better to take a bank holiday feed direct from GOV.UK and then have a separate list of GBC specific days but one of the challenges was being able to always access the internet from wherever the code is run.


Change/feature req: Tag only requested tags in pull by default

(Docker 1.4.1 in use here, but this has been true for a while)
Currently, pulling an image by tag pulls in a lot of extra tags which, in most cases, result in stale images sitting around for no good reason. For instance, pulling ubuntu:14.04 produces all of the following locally:
ubuntu                  trusty-20150320     b7cf8f0d9e82        2 days ago          188.3 MB
ubuntu                  14.04.2             b7cf8f0d9e82        2 days ago          188.3 MB
ubuntu                  14.04               b7cf8f0d9e82        2 days ago          188.3 MB
ubuntu                  latest              b7cf8f0d9e82        2 days ago          188.3 MB
ubuntu                  trusty              b7cf8f0d9e82        2 days ago          188.3 MB

But I only asked for ubuntu:14.04. When the image gets rebuilt and there's a new trusty-DATESTAMP tag, the old one is going to sit there doing nothing ~forever. Similarly when 14.04.3 is released, the 14.04.2 tag will linger there ~forever. They have to be manually untagged with docker rmi to purge them.
If I'm asking for something like ubuntu:latest or ubuntu:trusty or ubuntu:14.04, I want only that tag, because the next time I run docker build or docker run with it, I want the latest available image version for that tag.
The default behavior of docker pull (and the FROM Dockerfile directive) should be to get only the specific requested tag. If there's an additional option to pull to grab all equivalent tags, great, but that leaves garbage sitting around if it's not specifically the desired behavior.

This was fixed in 1.6


C:\Users\mgarcia\AppData\Local\Microsoft\PowerToys\PowerToys Run\Logs\<IP_ADDRESS>\2024-03-29.txt

Microsoft PowerToys version
<IP_ADDRESS>
Installation method
PowerToys auto-update
Running as admin
No
Area(s) with issue?
General
Steps to reproduce
Just restarted the computer and the same message appeared.
✔ Expected Behavior
I was expecting it to work on start-up.
❌ Actual Behavior
I got and error message.
Other Software
Version: <IP_ADDRESS>
OS Version: Microsoft Windows NT 10.0.19045.0
IntPtr Length: 8
x64: True
Date: 03/29/24 8:50:26 AM
Exception:
System.UnauthorizedAccessException: Access to the path 'C:\Users\mgarcia\AppData\Local\Microsoft\PowerToys\PowerToys Run\Settings\Plugins\Microsoft.Plugin.Shell\ShellPluginSettings.json' is denied.
at Microsoft.Win32.SafeHandles.SafeFileHandle.CreateFile(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options)
at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable1 unixCreateMode)    at System.IO.File.OpenHandle(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize)    at System.IO.File.WriteToFile(String path, FileMode mode, String contents, Encoding encoding)    at System.IO.Abstractions.FileWrapper.WriteAllText(String path, String contents)    at Wox.Infrastructure.Storage.JsonStorage1.Save()
at Microsoft.Plugin.Shell.Main.Save()
at Microsoft.Plugin.Shell.Main.UpdateSettings(PowerLauncherPluginSettings settings)
at Wox.Plugin.PluginPair.Update(PowerLauncherPluginSettings setting, IPublicAPI api, Action refreshPluginsOverviewCallback)
at PowerLauncher.SettingsReader.ReadSettings()
at PowerLauncher.App.<>c__DisplayClass19_0.b__0()
at Wox.Infrastructure.Stopwatch.Normal(String message, Action action)
at PowerLauncher.App.OnStartup(Object sender, StartupEventArgs e)
at System.Windows.Application.<.ctor>b__1_0(Object unused)
at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs)
at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler)

Hi!
This has been fixed in version 0.79: https://github.com/microsoft/PowerToys/releases/tag/v0.79.0
/dup #28810


Crash on printf '\e[81C '

When running printf '\e[81C\eH':
thread 'pty reader' panicked at 'index out of bounds: the len is 80 but the index is 81', /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libcollections/vec.rs:1371
stack backtrace:
   1:     0x5588ad085d4c - std::sys::imp::backtrace::tracing::imp::write::h9c41d2f69e5caabf
                        at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:42
   2:     0x5588ad08b23e - std::panicking::default_hook::{{closure}}::h1f61f3c769fffe7a
                        at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libstd/panicking.rs:351
   3:     0x5588ad08ae44 - std::panicking::default_hook::hd5bda4e453dfb4be
                        at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libstd/panicking.rs:367
   4:     0x5588ad08b6e7 - std::panicking::rust_panic_with_hook::hffbc74969c7b5d87
                        at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libstd/panicking.rs:555
   5:     0x5588ad08b574 - std::panicking::begin_panic::h3bbdbb2a23440035
                        at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libstd/panicking.rs:517
   6:     0x5588ad08b499 - std::panicking::begin_panic_fmt::h34f5b320b0f94559
                        at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libstd/panicking.rs:501
   7:     0x5588ad08b427 - rust_begin_unwind
                        at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libstd/panicking.rs:477
   8:     0x5588ad0b75bd - core::panicking::panic_fmt::h1016b85b51d1931f
                        at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libcore/panicking.rs:69
   9:     0x5588ad0b7568 - core::panicking::panic_bounds_check::h3b875b6ea9a674f6
                        at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libcore/panicking.rs:56
  10:     0x5588accec545 - <collections::vec::Vec<T> as core::ops::IndexMut<usize>>::index_mut::h69b598477d3e900a
                        at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libcollections/vec.rs:1371
  11:     0x5588acc5fa44 - <alacritty::grid::Row<T> as core::ops::IndexMut<alacritty::index::Column>>::index_mut::h9adf91b5b10bafe3
                        at /home/anders/rust/alacritty/src/grid.rs:311
  12:     0x5588acc64280 - <alacritty::grid::Grid<T> as core::ops::IndexMut<&'point alacritty::index::Point>>::index_mut::h2a8363d21414e0ce
                        at /home/anders/rust/alacritty/src/grid.rs:225
  13:     0x5588accdaef7 - <alacritty::term::Term as alacritty::ansi::Handler>::input::h1bacbff20d66275a
                        at /home/anders/rust/alacritty/src/term/mod.rs:638
  14:     0x5588accf6d6c - <alacritty::ansi::Performer<'a, H, W> as vte::Perform>::print::h2f59924c294298c6
                        at /home/anders/rust/alacritty/src/ansi.rs:438
  15:     0x5588acc80616 - vte::Parser::perform_action::h82162452c9ac296a
                        at /home/anders/.cargo/registry/src/github.com-1ecc6299db9ec823/vte-0.1.2/src/lib.rs:189
  16:     0x5588acc80c4e - vte::Parser::perform_state_change::ha318e6e99fbda378
                        at /home/anders/.cargo/registry/src/github.com-1ecc6299db9ec823/vte-0.1.2/src/lib.rs:167
  17:     0x5588acc80fc4 - vte::Parser::advance::h66c6bd0670baf377
                        at /home/anders/.cargo/registry/src/github.com-1ecc6299db9ec823/vte-0.1.2/src/lib.rs:137
  18:     0x5588accfbfac - alacritty::ansi::Processor::advance::h92e3d5ba20d53d25
                        at /home/anders/rust/alacritty/src/ansi.rs:85
  19:     0x5588accc6986 - <alacritty::event_loop::EventLoop<Io>>::pty_read::h18a7cc99c622d42f
                        at /home/anders/rust/alacritty/src/event_loop.rs:211
  20:     0x5588accc6082 - <alacritty::event_loop::EventLoop<Io>>::spawn::{{closure}}::h069a2120b2d00625
                        at /home/anders/rust/alacritty/src/event_loop.rs:308
  21:     0x5588accf8024 - <std::panic::AssertUnwindSafe<F> as core::ops::FnOnce<()>>::call_once::h6032dcb0cf344702
                        at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libstd/panic.rs:296
  22:     0x5588acc8048f - std::panicking::try::do_call::hc745aec8a9cedc1b
                        at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libstd/panicking.rs:460
  23:     0x5588ad09265a - __rust_maybe_catch_panic
                        at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libpanic_unwind/lib.rs:98
  24:     0x5588acc7fb03 - std::panicking::try::h697849a0f4444602
                        at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libstd/panicking.rs:436
  25:     0x5588acc7dbb4 - std::panic::catch_unwind::hb5b74bacab7a9eb7
                        at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libstd/panic.rs:361
  26:     0x5588acc7f45c - std::thread::Builder::spawn::{{closure}}::hc2b962b0b41adef6
                        at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libstd/thread/mod.rs:357
  27:     0x5588accbf2e9 - <F as alloc::boxed::FnBox<A>>::call_box::hab7d1897638a2589
                        at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/liballoc/boxed.rs:605
  28:     0x5588ad08a534 - std::sys::imp::thread::Thread::new::thread_start::h76badbf9b0ecaf58
                        at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/liballoc/boxed.rs:615
                        at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libstd/sys_common/thread.rs:21
                        at /buildslave/rust-buildbot/slave/nightly-dist-rustc-linux/build/src/libstd/sys/unix/thread.rs:84
  29:     0x7f76efc8c6c9 - start_thread
  30:     0x7f76ef7af0ae - __clone
  31:                0x0 - <unknown>
child finished with error '1'

Can be shortened to printf '\e[81C
Specific issue is that this line blindly accepts a column to go to without checking that it's a valid column. As does the move_forward function.

The crash doesn’t happen on just '\e[81C', but it happens if something is printed after that.
I don’t think move_forward is the right place for the check. That would have a TOCTTOU bug if the window was resized between the move and the following print.

The crash doesn’t happen on just '\e[81C', but it happens if something is printed after that.

Right, it's just that my (any really) PS1 prompt will trigger it after that.

I don’t think move_forward is the right place for the check. That would have a TOCTTOU bug if the window was resized between the move and the following print.

I'm not really familiar with the architecture of this program, but at first glance it seems like the appropriate place to me.
Resize has to handle fixing cursor location as well (already does it seems), since you might be shrinking the window to before where the cursor is. So resizing the window after doing printf \e[81C shouldn't cause any problems, in theory at least.
Meanwhile the escape sequence appears to be specified to stop at the right edge of the screen (at least it is here, is there some official documentation on these?) so if we don't do it there, or shortly after there, something like "move forwards 100000, move back 10" is going to be broken.

Seems fixed by #164.


Player's animation starting from second keypress

Overview
When pressing ← or → in a separate key-strokes, separated by a long pause then animation for a single key stroke is not run at all (it generally starts with approx. 1 second delay) and it causes player too look like it would be ice skating! It is moving around the town, some times even at great distances without any animation at all.
Necessary steps

Start new game
Press ← or → a couple of time with a longer pause in-between

Expected results
Character animation is played from the first key stroke / second / frame and in this particular scenario it is played at all.
Actual results
Animation is played from the second key stroke / second second and in this scenario is not visible at all.

This will be fixed in #72 as it has overhaul of player movement and classes


add RTL support

this will make the slider work in RTL apps too.

Thanks!

Any rush in getting it released? Otherwise I'll do it next week.
Thanks for the contribution @iamsoorena

Thank you @ptomasroos . There is no rush I'm currently using my own fork in production.

@ptomasroos when I read your comment(before edit), you said that it's better to use const and I used that. If you think it's better to revert it back to var let me know.


relax suite context matcher language

This slightly relaxes the language for the SuiteContext matchers, so
that whether one starts the step with “a …” or not it will match either
way.
(It also eliminates one duplicate matcher that essentially did the same
thing without a regex.)

Codecov Report

Merging #84 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   79.34%   79.33%   -0.01%
==========================================
  Files          16       16
  Lines        2174     2173       -1
==========================================
- Hits         1725     1724       -1
  Misses        340      340
  Partials      109      109

Impacted Files
Coverage Δ

suite_context.go
70.4% <100%> (-0.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f95563...299762e. Read the comment docs.


[WIP] Improve test coverage

Description

This PR adds missing tests to improve overall test coverage. Increasing unit test coverage to 100%.
Refactors the config to include both the container and task meta endpoints. This allows us to better test the different client edge cases.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines
Coverage Δ

internal/config/config.go
100.00% <100.00%> (ø)

internal/task/meta.go
100.00% <100.00%> (+30.00%)
:arrow_up:

internal/task/task.go
100.00% <100.00%> (ø)

maxprocs/maxprocs.go
100.00% <100.00%> (ø)


Remove empty assertion from er_io get_sources() and get_subjects()

closes #239

Codecov Report
Attention: Patch coverage is 7.54717% with 49 lines in your changes missing coverage. Please review.

Project coverage is 62.97%. Comparing base (55e989a) to head (04c5243).
Report is 6 commits behind head on master.

Files
Patch %
Lines

ecoscope/io/earthranger.py
3.44%
28 Missing :warning:

ecoscope/io/async_earthranger.py
5.88%
16 Missing :warning:

ecoscope/io/earthranger_utils.py
28.57%
5 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #240       +/-   ##
===========================================
- Coverage   73.61%   62.97%   -10.64%
===========================================
  Files          29       30        +1
  Lines        2240     2304       +64
===========================================
- Hits         1649     1451      -198
- Misses        591      853      +262

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Genome with no annotated proteins - Naked genome alert!

Streptococcus dysgalactiae strain NCTC8547
Genome ID	1334.136
Please, please clothe this genome in warm and comforting proteins

This and other naked genomes have been deleted from the database.


[Request] Update webpage for ffmpeg, ffmpeg-nightly and ffmpeg-shared

Zeranoe had announced that he would close his website for ffmpeg builds. Can you update the links to install ffmpeg? Two devs are willing to compile ffmpeg and provide builds.
Link to the websites: https://ffmpeg.org/download.html

Wrong repo
There are already lots of issues about this in Main


Update Report-Metadata-Virtual-Table.md

Docs Build status updates of commit 688a721:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

dynamics-nav/Report-Metadata-Virtual-Table.md
:bulb:Suggestion

Details

dynamics-nav/Report-Metadata-Virtual-Table.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[New Rule] prefer-function-component

Adds a new rule to enforce the use of function components over class components. Related issue: https://github.com/yannickcr/eslint-plugin-react/issues/2860
Users wanting to try this lint rule today:
This functionality exists in eslint-plugin-react-prefer-function-component.
npm install eslint-plugin-react-prefer-function-component

#2860 doesn't have a "help wanted" or "accepted" label on it - I continue to be unconvinced this is actually a good rule to have. Some things must be class components, and other things are more clear/better as class components; I don't think a lint rule is naunced enough to be appropriate.

I wonder if perhaps this could be a more generic "prefer-component-style" rule, that can be used to force class components or force function components?

Yeah that seems reasonable to me, the motivating intent here is to keep consistency in a code base.
Looking at the recent work by the Relay team (and their close collaboration with the React team) and the React concurrent mode work my impression is that the longer term direction of React is going to be towards all function components, but that is speculative right now.

#2860 doesn't have a "help wanted" or "accepted" label on it - I continue to be unconvinced this is actually a good rule to have. Some things must be class components, and other things are more clear/better as class components; I don't think a lint rule is naunced enough to be appropriate.
That said, I did ask you to open the PR, so I'll give it a good faith review.

I don't have any expectations here, just something to consider. This can always sit or be closed and reopened in the future. I just want things to be code complete (or close) while I have the time.

Just wanted to pop in to say I'd like to have this lint rule too. As pointed out elsewhere, the biggest value here is in enabling consistency across a codebase and the ability to reuse logic between components easily.
In my case, another big use is to use these lint rules to gauge how well we are/are not doing in paying down tech debt over time on an old-ish codebase where we're about 50/50 on function components versus class components. Given the large-ish size of our org and codebase, this has to be automated via tooling so we can create dashboards/reports/etc.

Does the function-component-definition rule meet everyone's use cases here?

Does the function-component-definition rule meet everyone's use cases here?

No that rule enforces the function definition and the request here is to enforce function components instead of class components.

Does the function-component-definition rule meet everyone's use cases here?

No that rule enforces the function definition and the request here is to enforce function components instead of class components. It’s complementary but none overlapping.

Agree with Tate. This rule, while useful, doesn't solve the issue of preventing the introduction of class components into a codebase.

@robwierzbowski nope, nothing's changed there, and ErrorBoundary in particular still is required to be a class component.

That's true. I believe this code allows error boundaries to remain class components. As you discussed above, whether this is hardcoded true or an option, the issue could be addressed.


hints being rendered on screen cause massive frame drops on low end machines (Fabric 1.20.4)

on low end machines when a hint is being rendered it can cause massive frame drops for me i went from 45 fps to an average of 15 fps when a hint is being rendered as soon as the hint goes away i go back up to 45 fps
mods used
fabric-api-0.95.1+1.20.4
architectury-11.0.11-fabric
Minecraft-Legacy-1.20.4-1.3.2-fabric

Unfortunately due to JE's unoptimized transparency and high tiles usage for better fidelity with LE there will be performance issues, the tips/hints are nothing special for this massive frame drop, and probably JE's toast system animations and constant checks may play some part in this.


feat: Provision multiple ALBs per aws account

Issue #, if available:
Description of changes:
Provision multiple ALBs per aws account
Checklist:

[x] Have you successfully deployed to an AWS account with your changes?
[x] Have you written new tests for your core changes, as applicable?
[x] Have you successfully tested with your changes locally?
[x] If new dependencies have been added, have they been pinned to specific versions?
[x] Is this change also required on the AWS Solution version?

AS review ticket id:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

:exclamation: No coverage uploaded for pull request base (feat-multiple-alb@f71d2c3). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Current head 5f6cd51 differs from pull request most recent head 50a46db. Consider uploading reports for the commit 50a46db to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                 Coverage Diff                  @@
##             feat-multiple-alb      #77   +/-   ##
====================================================
  Coverage                     ?   67.43%
====================================================
  Files                        ?      130
  Lines                        ?     7529
  Branches                     ?     1163
====================================================
  Hits                         ?     5077
  Misses                       ?     2174
  Partials                     ?      278

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f71d2c3...50a46db. Read the comment docs.


Get list-wallets to 100% test coverage

Bounty: 100 tokens
The scope of this Issue is to add tests to the list wallets tests in order to achieve 100% test coverage. It is currently at 70% test coverage. Make any changes needed to the list wallets command necessary to facilitate mocks and test coverage.

The burn-tokens tests have achieved 100% test coverage. This provides a good example of the patterns that will be needed to complete this Issue.

This YouTube video covers JavaScript design and testing patterns that should be followed.

This YouTube video shows how to generate test coverage reports. These reports will help you identify the lines that are not being covered by current tests.

Acceptance Criteria

A Pull Request (PR) should be submitted that meet the above criteria. The PR should be from a branch and not a fork. In order to create a branch, you'll need commit to access to this repository.
All tests should pass when running npm test.
The command targeted by this Issue should show 100% test coverage when tests are run.
All commands should still be fully functional.
The bounty will be awarded upon successfully merging of the PR into the master branch.

I've pushed a major change to the master branch. Be sure to pull the latest and update any branch prior to submitting a PR.

This issue resolved by this PR:
https://github.com/Permissionless-Software-Foundation/slp-cli-wallet/pull/1


[QUESTION] Is there a way to ignore unprocessed files on errors ?

I am running the connector v2.4.3 on Azure to source avro files. It may happen that loading a file throws an error (say for example one file which is not in expected Avro format), the processing then just stay blocked with the following message:
INFO Scheduled files still being processed: 1. Skip filesystem listing while waiting for tasks completion (io.streamthoughts.kafka.connect.filepulse.fs.DefaultFileSystemMonitor:271)
Is there a way to just ignore files loading/processing failures and continue the processing?
Thanks.

Hi @igorng, which reader are you using? Normally, even if an exception occurs while processing a file, it should be marked as FAIL and it should not block further files.


Update zio, zio-streams, zio-test, ... to 2.0.0

Updates

dev.zio:zio
dev.zio:zio-streams
dev.zio:zio-test
dev.zio:zio-test-sbt

from 2.0.0-RC6 to 2.0.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "dev.zio" } ]

labels: library-update, early-semver-pre-release, semver-spec-pre-release, commit-count:1

sorry, wondering if it is possible to release the library for the final zio 2.0 ?
and if any help is needed to resolve the build errors?

I plan to release it this weekend

thank you!


A way to start Minecraft, automatically join a server?

In some launchers in cli, on startup of minecraft, join automatically on a server specificated,
usually the flag is:
--server <ip>
and i searching this on the picomc but i dont find it :(
if dont exist this feature this is a feature issue
but if no this is a question directly :p

Hey, not built in at the moment. You could use a custom version json. But I'll take a look at adding a config parameter for this, should be quite easy

oh well, i hope you can add this, but if no, no matter, dont worry :)

ok i got realized, i dont have any idea, about how make a custom json version to auto join on a server, and i try search about this and no find anything about this :( can you help me?

I'll keep this open for reference


Explorer doesn't open folder when it contains a broken symlink

VSCode Version: Version 1.33.0-insider (1.33.0-insider)
OS Version: macOS Mojave 10.14.3

Steps to Reproduce:

Create a folder mkdir ~/test
Inside a VSCode workspace, create a folder src and create some empty files just to have some content in there.
Inside the src folder create a symlink (via the shell) to the test folder (i.e. ln -s ~/testdir testdir)
Refresh the VSCode Explorer window and the symlinked folder inside src should be properly shown.
Now delete the~/test folder where the symlink points to, i.e. we have a broken symlink in src/.

The result is that in VSCode you're no more able to open src and view its contents.

Does this issue occur when all extensions are disabled?: Yes

Just recognized it could be a dup of #71148. Will test that once the new version of insiders gets released and in case I'll close this issue

Closing as duplicate for now, please let us know if this still happens with newer insiders and we can reopen


Allow storing value types in RouterRequest.userInfo

I'd like to propose changing userInfo to:
    /// User info
    ///
    public var userInfo: [String: Any] = [:]

That will allow storing things other than classes in userInfo. I have one-line PR ready just waiting to get through CLA tomorrow. However I would like to hear your thoughts beforehand.
On the side note could anyone from dev team explain the rationale behind using classes pretty much everywhere?

I think this is a good change to make and I'd support the PR when you submit it. As for your question, reference vs value types has been a divisive issue for the dev team in the past (see #355). While I agree on moving more towards structs, we'll need to carefully consider performance and object "correctness".

Hey @jtomanik because this is such a simple fix, I went ahead and implemented it. Thanks for the suggestion!


drop JsonLike

JsonLike is only used in tests. Create a PR to delete it.

/bounty 50$

/attempt #1551

/attempt #1551

/attempt https://github.com/tailcallhq/tailcall/issues/1551

We need this it seems.


n element descriptor's .kind property must be either “method” or “field”

I'm following the documentation for mobx-react-router but upon attempting to run my application I get the following error in the browser:
Uncaught TypeError: An element descriptor's .kind property must be either "method" or "field", but a decorator created an element descriptor with .kind "undefined"
    at _toElementDescriptor (app.js:49988)
    at _toElementFinisherExtras (app.js:49990)
    at _decorateElement (app.js:49980)
    at app.js:49976
    at Array.forEach (<anonymous>)
    at _decorateClass (app.js:49976)
    at _decorate (app.js:49958)
    at Module../src/App/UserStore.js (app.js:50012)
    at __webpack_require__ (bootstrap:19)
    at Module../src/index.js (index.js:1)

Here is how I intitialize:
const appContainer = document.getElementById('app');
if(appContainer) {
  const browserHistory = createBrowserHistory()
  const routingStore = new RouterStore();

  const stores = {
    users: userStore,
    routing: routingStore
  }

  const history = syncHistoryWithStore(browserHistory, routingStore);

  ReactDOM.render(
    (
      <Provider {...stores}>
        <Router history={history}>
          < App />
        </Router>
      </Provider>
    ),
  appContainer);
}

And this is how I use:
@inject('routing')
@inject('users')
@observer
class App extends Component { ...

My UserStore:
import { observable, action, computed } from "mobx"

class UserStore {
  @observable users = [];

  @action addUser = (user) => {
    this.users.push(user)
  }

  @computed get userCount () {
    return this.users.length
  }
}

const store = new UserStore();
export default store;

I've tried to Google for this error but it's returning no useful results. Any ideas what I am doing wrong?

Hmm not sure what the issue was there. Seems unlikely to be related to this library though. Will close for now until someone see's this issue again or has more information around it 👍


Problems Extracting Stats

When I try in Mathematica 11.3
{stat, result} = Stats[Int[(a + b*Sqrt[x])^d, x]];
I get the following error message:
Set::shape: Lists {stat,result} and -((2 a (a+b Sqrt[x])^(1+d))/(b^2 (1+d)))+(2 (a+b Sqrt[x])^(2+d))/(b^2 (2+d)) are not the same shape.
Any alternatives?

I'm sorry, this is my fault because I did not update the documentation on the website accordingly. We unified the behavior of Stats, Steps, and Step. This means, per default, all three functions will print their information because this is the most common use-case.
If you want to have the information returned in the form {info, result}, you can use the option RubiPrintInformation -> False with all three functions Stats, Steps, and Step. So for you this means you need to use
{stat, result} = Stats[Int[(a + b*Sqrt[x])^d, x], RubiPrintInformation -> False]

Thanks for the clarification


Refactor/transform queries features

It would be nice to have the following query refactoring features:

extract selected query fields to fragment
extract selected query fields to variable

Hey,
This would need more details. What is the use case? How would you propose the feature works?

What is the use case?

I'm working on a very complex API that has large number of types and large number of fields in each type. (BTW, that's why I opened #690.) The API is automatically generated. Currently I'm working on refactoring queries in my app, and I do the same actions over and over again by hand.

How would you propose the feature works?

The "Extract selected fields to fragment" works as follows:

Suppose there is the following query:
query getUsers {
  users {
    id
    firstName
    lastName
    username
    phone
    email
    github
    twitter
  }
}

The user selects the phone, email, github and twitter fields by mouse. And a tooltip with "Extract selected fields to fragment" item appears next to the selected fields. (Alternative option: the tooltip with "Extract selected fields to fragment" item is shown after right mouse button click at selected fields.) After clicking on the item, the query will be transformed into:
query getUsers {
  users {
    id
    firstName
    lastName
    username
    ...fragment1
  }
}

fragment fragment1 on User {
  phone
  email
  github
  twitter
}

The "Extract input fields to variable" works as follows:

Suppose there is the following query:
query getPosts {
  posts(
    where: {
      OR: [
        {
          AND: [
            { title_in: ["My biggest Adventure", "My latest Hobbies"] }
            { published: true }
          ]
        }
        { id: "cixnen24p33lo0143bexvr52n" }
      ]
    }
  ) {
    id
    title
    published
  }
}

The user puts the mouse cursor on the input argument where. And a tooltip with "Extract input fields to variable" item appears next to the input field. (Alternative option: the tooltip with "Extract input fields to variable" item is shown after right mouse button click at the input argument.) After clicking on the item, the query will be transformed into:
Query:
query getPosts($where: PostWhereInput) {
  posts(where: $where) {
    id
    title
  }
}

Variables:
{
  "where": {
    "OR": [{
        "AND": [{
          "title_in": ["My biggest Adventure", "My latest Hobbies"]
        }]
      },
      {
        "id": "cixnen24p33lo0143bexvr52n"
      }
    ]
  }
}

Why I extract fields to fragments?
In my real case, the queries are a bit more complicated, and the fragments are reusable:
query getUsers {
  admins: users(role: admin) {
    id
    firstName
    lastName
    username
    phone
    email
    github
    twitter
  }
  accountants: users(role: accountant) {
    id
    firstName
    lastName
    username
    phone
    email
    github
    twitter
  }
}

query getUsers {
  admins: users(role: admin) {
    ...userFields
  }
  accountants: users(role: accountant) {
    ...userFields
  }
}

fragment userFields on User {
  id
  firstName
  lastName
  username
  phone
  email
  github
  twitter
}

Why I extract input fields to variables?
Because I need to not just change the values in the input, but dynamically change the shape of the query input using nested logical combinators OR, AND and NOT (generate the input using JS depending on what the user chooses in the UI for search, filtering, ordering/sorting and pagination).

@imolorhe Is it really wontfix?

No it's not 😄

Also it's sometimes useful to do the opposite:

merge all fragments into one query/subscription/mutation
inline all variable values into query/subscription/mutation

The first (as well as remove duplicated fields feature that is also very useful) is already implemented in graphql-prettier package by @Emetrop.

I think we can implement this in the LSP so it works in monaco/vscode/etc, but Altair will need to migrate from codemirror-graphql to the forthcoming monaco mode to use that.

That would be a major migration but would be worth looking into once the monaco mode is completed.

Yeah its unfortunate we have to make such a jump, but after I showed the preview some of the main contributors to the original codemirror mode see how this would reduce tons of redundant code, and allow us to have closer parity with the official LSP standard, potentially being able to roll out features across the ecosystem (including vscode, atom, etc) with a fraction of the code
Here's a quick preview, only query pane working now with completions, diagnostics, hovers. We will add declarations very soon and eventually symbol support:
https://graphiql-monaco-mode-example.netlify.com/
As you can see, its set up for my development of the variables editor, so if you just add the variable you'll see all the query editor features.
Here's the branch for it, where i add the monaco-graphql package and a monaco test under graphiql-examples that you see in that netlify example

Just went through the monaco-graphql mode and the example. Looking good so far. If I understand correctly, the LSP standard you are referring to is a standardised interface accepted by most IDEs and development environments, and is different from the interface used by codemirror, hence implementing the LSP interface has a better impact in terms of possible integration with more environments?

Also you mentioned that declarations and symbol support are missing. What are you referring to by those?

And after a bit of googling around, I found what I was looking for 🙂https://microsoft.github.io/language-server-protocol/

yup thats it! my bad, running errands all day, trying to make sure i can overcome this illness
our entry for the official LSP site needs updated, but thats a great start to understanding it
the monaco team says monaco-graphql is looking pretty good, just need to support webworkers and declarations, variables and it should be mostly ready. we will want to sprinkle in some more features for parity with the codemirror mode. so far, I find many of these features to be much easier to implement in monaco, or already present with a very simple implementation.
my goal is to instantiate the full gls-interface/GraphQLLanguageService class in the browser with the monaco mode, similar to the language servers. We will be forking or possibly taking over graphql-config to acheive this universality, but everything in monaco is.file URI driven which will make that easier.
Then, by insantiating that class everywhere, we can add to it a plugin capability that can work universally across vscode server/browser/vscode client/atom. Typescript LS's plugin system and the json language service (pluggable schema loading), monaco-typescript and monaco-json provide nice prior art for this planned architecture

https://github.com/cypress-io/cypress-example-recipes/tree/master/examples/blogs__a11y
bingo!

Please reopen this issue.

This will be blocked for now until the implementation on the LSP level, unless there's time available to implement it on Altair itself.

ah! i understand this a lot better now that i’ve reread it @FluorescentHallucinogen. very useful. can see how we could accomplish this with monaco in a vscode style. If you all want to make it work with codemirror first here in altair be my guest! for us to implement this in the LSP (probably in the new monaco mode) it might take a little bit for us to get there

I'm going to attempt to implement this feature. However the implementation I would be doing would attempt to refactor the entire query, without selective refactoring.


CB-15964: Validate the availability of the parcel before the upgrade

Add a new validator for the upgrade validation step to test the availability of the parcels.
The validator should check the following items:

CDH parcel
required non CDH parcels
CM repo files
CSD files
If the validation fails then the upgrade flow should not be started.

Please either fix the job issues or move it back to draft.
Otherwise we'll close it.


added support for kFreeBSD and GNU Hurd

Ref: https://github.com/marcIhm/yabasic/pull/29

I would add the _GNU_SOURCE like this:
#ifndef _GNU_SOURCE
#define _GNU_SOURCE
#endif

I think a correct check for kFreeBSD would be #if defined(__linux__) || ... || (defined(__FreeBSD_kernel__) && defined(__GLIBC__))
You need to check for __GLIBC__ to as FreeBSD also defines __FreeBSD_kernel__

I think it's enough to check __GNU__ only since we do not really care whether it is __FreeBSD_kernel__ or something else, just GNU-like environment.


should simplify how to get the latest docker-compose release version

use this:
curl -s https://api.github.com/repos/docker/compose/releases/latest | grep 'tag_name' | cut -d\" -f4

instead of:
curl -s https://api.github.com/repos/docker/compose/releases/latest | sed 's/[{}]//g' | awk -v k=text '{n=split($0,a,\",\"); for (i=1; i<=n; i++) print a[i]}' | sed 's/\"\:\"/\|/g' | sed 's/[\,]/ /g' | sed 's/\"//g' | grep -w 'tag_name' | awk '{print $2}' | awk 1 ORS=''

from: https://github.com/teracyhq/dev/blob/develop/main-cookbooks/teracy-dev/recipes/docker.rb#L40

@phuonglm @datphan: @duc4nh and I got this error:
==> default: ================================================================================
==> default: Recipe Compile Error in /var/chef/cache/cookbooks/teracy-dev/recipes/default.rb
==> default: ================================================================================
==> default:
==> default: Mixlib::ShellOut::ShellCommandFailed
==> default: ------------------------------------
==> default: Expected process to exit with [0], but received '2'
==> default: ---- Begin output of curl -s https://api.github.com/repos/docker/compose/releases/latest | grep 'tag_name' | cut -d" -f4 ----
==> default: STDOUT:
==> default: STDERR: sh: 1: Syntax error: Unterminated quoted string
==> default: ---- End output of curl -s https://api.github.com/repos/docker/compose/releases/latest | grep 'tag_name' | cut -d" -f4 ----
==> default: Ran curl -s https://api.github.com/repos/docker/compose/releases/latest | grep 'tag_name' | cut -d" -f4 returned 2
==> default:
==> default: Cookbook Trace:
==> default: ---------------
==> default:   /var/chef/cache/cookbooks/teracy-dev/recipes/docker.rb:44:in `get_docker_compose_release'
==> default:   /var/chef/cache/cookbooks/teracy-dev/recipes/docker.rb:53:in `get_docker_compose_autocomplete_url'
==> default:   /var/chef/cache/cookbooks/teracy-dev/recipes/docker.rb:126:in `from_file'
==> default:   /var/chef/cache/cookbooks/teracy-dev/recipes/default.rb:37:in `from_file'
==> default:
==> default: Relevant File Content:
==> default: ----------------------
==> default: /var/chef/cache/cookbooks/teracy-dev/recipes/docker.rb:
==> default:
==> default:  37:      release = node['docker_compose']['release']
==> default:  38:
==> default:  39:      if release.empty?
==> default:  40:          result = Mixlib::ShellOut.new("curl -s https://api.github.com/repos/docker/compose/releases/latest | grep 'tag_name' | cut -d\" -f4")
==> default:  41:
==> default:  42:          result.run_command
==> default:  43:
==> default:  44>>         result.error!
==> default:  45:
==> default:  46:          node.override['docker_compose']['release'] = release = result.stdout
==> default:  47:      end
==> default:  48:
==> default:  49:      release
==> default:  50:  end
==> default:  51:
==> default:  52:  def get_docker_compose_autocomplete_url
==> default:  53:      "https://raw.githubusercontent.com/docker/compose/#{get_docker_compose_release}/contrib/completion/bash/docker-compose"
==> default:
==> default: System Info:
==> default: ------------
==> default: chef_version=13.1.31
==> default: platform=ubuntu
==> default: platform_version=16.04
==> default: ruby=ruby 2.4.1p111 (2017-03-22 revision 58053) [x86_64-linux]
==> default: program_name=chef-solo worker: ppid=2388;start=14:15:51;
==> default: executable=/opt/chef/bin/chef-solo
==> default:
==> default:
==> default: Running handlers:
==> default: [2017-07-26T14:16:00+00:00] ERROR: Running exception handlers
==> default: Running handlers complete
==> default: [2017-07-26T14:16:00+00:00] ERROR: Exception handlers complete
==> default: Chef Client failed. 0 resources updated in 09 seconds
==> default: [2017-07-26T14:16:00+00:00] FATAL: Stacktrace dumped to /var/chef/cache/chef-stacktrace.out
==> default: [2017-07-26T14:16:00+00:00] FATAL: Please provide the contents of the stacktrace.out file if you file a bug report
==> default: [2017-07-26T14:16:00+00:00] ERROR: Expected process to exit with [0], but received '2'
==> default: ---- Begin output of curl -s https://api.github.com/repos/docker/compose/releases/latest | grep 'tag_name' | cut -d" -f4 ----
==> default: STDOUT:
==> default: STDERR: sh: 1: Syntax error: Unterminated quoted string
==> default: ---- End output of curl -s https://api.github.com/repos/docker/compose/releases/latest | grep 'tag_name' | cut -d" -f4 ----
==> default: Ran curl -s https://api.github.com/repos/docker/compose/releases/latest | grep 'tag_name' | cut -d" -f4 returned 2
==> default: [2017-07-26T14:16:00+00:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsuccessfully (exit code 1)
Chef never successfully completed! Any errors should be visible in the
output above. Please fix your recipes so that they properly complete.
==> default: The previous process exited with exit code 1.

@phuonglm please verify and get this closed soon.

verify and it's fixed


[Data Enrichment] Add EnrichmentProject.preview, EnrichmentResult and EnrichmentOptions

Description
Add EnrichmentProject.preview, EnrichmentResult and EnrichmentOptions
Tests
wait for more details from the backend

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Use default arch in CI

There are warnings (e.g., https://github.com/trixi-framework/P4est.jl/actions/runs/12108765313) in the CI runs because we request x64 on a macOS runner with arm64. I propose to simply use the default architecture, i.e. to remove the arch argument.

Oh, macos-latest (macos-14) doesn't run on Julia v1.6. What's the best way to proceed?

Use macos-13
Exclude macos-latest for Julia v1.6 (and include macos-13 for Julia v1.6)
Drop support for Julia v1.6 and Julia v1.7
Something else

See also https://discourse.julialang.org/t/how-to-fix-github-actions-ci-failures-with-julia-1-6-or-1-7-on-macos-latest-and-macos-14/117019. I would prefer option 2, but have no strong opinion.

Option 2 sounds good to me 👍

https://github.com/trixi-framework/P4est.jl/actions/runs/12126603254/job/33809069600?pr=135 fails

Should be fixed now.


Support for CCU2 firmware 2.41.5

Released in testing apt repository. Will be released in stable apt repository in about 2 weeks.

Released in stable apt repository.


Repository names

On github, it is obvious that this repo is part of Rotonde.
But once it is forked, it becomes a repo called "client", which does not give much information.
I should be renamed to something like "rotonde-client".
Ditto for the user repo

Right, right.. I know just what to do :)

Impressed at the speed of addressing this :)


NOISSUE - Improve reliability of state machine test

What type of PR is this?

What does this do?

Bug Fixes

Improved test reliability by adding delays in state machine transition tests to ensure asynchronous operations complete before assertions.

Chores

Updated service identifier for clarity, changing svcName from "manager_test_server" to "computations_test_server".
Added a new target for test coverage in the Makefile, enhancing test reporting capabilities.

Documentation

Introduced a coverage badge in the README.md to visually indicate the project's test coverage status.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

I have set Codecove and token, and this is the badge URL for Markdown:


Collapse with multiple target stopped working in 5.3.0

Prerequisites

[X] I have searched for duplicate or closed issues
[X] I have validated any HTML to avoid common problems
[X] I have read the contributing guidelines

Describe the issue
Until v5.2.3, the collapse plugin allowed a button to control several targets.
e.g. data-bs-target="#hello,#world"
Since v.5.3.0, it only appears to work with a single selector.  With multiple selectors, there are no errors, but no collapsing
I did read https://getbootstrap.com/docs/5.3/migration/ to see if this was an intentional change.
Reduced test cases
5.2.3 - https://codepen.io/fisharebest/pen/dyQgwGr
5.3.0 - https://codepen.io/fisharebest/pen/GRwYPjR
What operating system(s) are you seeing the problem on?
macOS
What browser(s) are you seeing the problem on?
Firefox
What version of Bootstrap are you using?
5.3.0

Thanks for reporting this issue @fisharebest.
On my side, I don't have all the history in mind for this component so I don't know if this was something really supported voluntarily or not. The JS team will add more information later on.
In the meantime, the following could probably help you to have a workaround based on the multiple targets documentation where a common class is used as an example:  https://codepen.io/julien-deramond/pen/RwqedgY


Different number of detected events for multiple runs

Hello,
I'm running this algorithm on Ubuntu 20.04.1 LTS, and I installed it via conda.
I found an interesting thing about EQTransformer. I get different number of detected events if I run this algorithm multiple times even with the same model, the same input mseed files and the same parameters. I'm confused about this. As an example, I firstly download mseed files as the 3.1 in the tutorial document, then
`$ conda activate eqt
(eqt)
yukuan @ x86_64-conda-linux-gnu in ~/mywork/EQT_test [20:28:17]
$ python
Python 3.7.8 | packaged by conda-forge | (default, Jul 31 2020, 02:25:08)
[GCC 7.5.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

from EQTransformer.core.mseed_predictor import mseed_predictor
Using TensorFlow backend.
/home/yukuan/anaconda3/envs/eqt/lib/python3.7/site-packages/tensorflow/python/framework/dtypes.py:516: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint8 = np.dtype([("qint8", np.int8, 1)])
/home/yukuan/anaconda3/envs/eqt/lib/python3.7/site-packages/tensorflow/python/framework/dtypes.py:517: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint8 = np.dtype([("quint8", np.uint8, 1)])
/home/yukuan/anaconda3/envs/eqt/lib/python3.7/site-packages/tensorflow/python/framework/dtypes.py:518: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint16 = np.dtype([("qint16", np.int16, 1)])
/home/yukuan/anaconda3/envs/eqt/lib/python3.7/site-packages/tensorflow/python/framework/dtypes.py:519: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint16 = np.dtype([("quint16", np.uint16, 1)])
/home/yukuan/anaconda3/envs/eqt/lib/python3.7/site-packages/tensorflow/python/framework/dtypes.py:520: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint32 = np.dtype([("qint32", np.int32, 1)])
/home/yukuan/anaconda3/envs/eqt/lib/python3.7/site-packages/tensorflow/python/framework/dtypes.py:525: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
np_resource = np.dtype([("resource", np.ubyte, 1)])
/home/yukuan/anaconda3/envs/eqt/lib/python3.7/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:541: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint8 = np.dtype([("qint8", np.int8, 1)])
/home/yukuan/anaconda3/envs/eqt/lib/python3.7/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:542: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint8 = np.dtype([("quint8", np.uint8, 1)])
/home/yukuan/anaconda3/envs/eqt/lib/python3.7/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:543: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint16 = np.dtype([("qint16", np.int16, 1)])
/home/yukuan/anaconda3/envs/eqt/lib/python3.7/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:544: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_quint16 = np.dtype([("quint16", np.uint16, 1)])
/home/yukuan/anaconda3/envs/eqt/lib/python3.7/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:545: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
_np_qint32 = np.dtype([("qint32", np.int32, 1)])
/home/yukuan/anaconda3/envs/eqt/lib/python3.7/site-packages/tensorboard/compat/tensorflow_stub/dtypes.py:550: FutureWarning: Passing (type, 1) or '1type' as a synonym of type is deprecated; in a future version of numpy, it will be understood as (type, (1,)) / '(1,)type'.
np_resource = np.dtype([("resource", np.ubyte, 1)])
mseed_predictor(input_dir= 'downloads_mseeds', input_model='EqT_model.h5', stations_json='station_list.json', output_dir='detections_1', detection_threshold=0.3, P_threshold=0.1, S_threshold=0.1, number_of_plots=99999, plot_mode='time_frequency', overlap=0.3, batch_size=500)
============================================================================
Running EqTransformer  0.1.56
*** Loading the model ...
WARNING:tensorflow:From /home/yukuan/anaconda3/envs/eqt/lib/python3.7/site-packages/keras/backend/tensorflow_backend.py:4070: The name tf.nn.max_pool is deprecated. Please use tf.nn.max_pool2d instead.

2021-01-21 20:30:19.969596: I tensorflow/core/platform/cpu_feature_guard.cc:142] Your CPU supports instructions that this TensorFlow binary was not compiled to use: SSE4.1 SSE4.2 AVX AVX2 FMA
2021-01-21 20:30:20.160487: I tensorflow/core/platform/profile_utils/cpu_utils.cc:94] CPU Frequency:<PHONE_NUMBER> Hz
2021-01-21 20:30:20.162329: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x560bd6df2f90 executing computations on platform Host. Devices:
2021-01-21 20:30:20.162375: I tensorflow/compiler/xla/service/service.cc:175]   StreamExecutor device (0): ,
2021-01-21 20:30:20.778364: W tensorflow/compiler/jit/mark_for_compilation_pass.cc:1412] (One-time warning): Not using XLA:CPU for cluster because envvar TF_XLA_FLAGS=--tf_xla_cpu_global_jit was not set.  If you want XLA:CPU, either set that envvar, or use experimental_jit_scope to enable XLA:CPU.  To confirm that XLA is active, pass --vmodule=xla_compilation_cache=1 (as a proper command-line flag, not via TF_XLA_FLAGS) or set the envvar XLA_FLAGS=--xla_hlo_profile.
WARNING:tensorflow:From /home/yukuan/anaconda3/envs/eqt/lib/python3.7/site-packages/keras/backend/tensorflow_backend.py:422: The name tf.global_variables is deprecated. Please use tf.compat.v1.global_variables instead.
*** Loading is complete!
######### There are files for 3 stations in downloads_mseeds directory. #########
========= Started working on B921, 1 out of 3 ...
20190901T000000Z__20190902T000000Z.mseed
20190902T000000Z__20190903T000000Z.mseed
*** Finished the prediction in: 0 hours and 16 minutes and 17.51 seconds.
*** Detected: 2868 events.
*** Wrote the results into --> " /home/yukuan/mywork/EQT_test/detections_1/B921_outputs "
========= Started working on CA06, 2 out of 3 ...
20190901T000000Z__20190902T000000Z.mseed
20190902T000000Z__20190903T000000Z.mseed
*** Finished the prediction in: 0 hours and 15 minutes and 52.55 seconds.
*** Detected: 2804 events.
*** Wrote the results into --> " /home/yukuan/mywork/EQT_test/detections_1/CA06_outputs "
========= Started working on SV08, 3 out of 3 ...
20190901T000000Z__20190902T000000Z.mseed
20190902T000000Z__20190903T000000Z.mseed
*** Finished the prediction in: 0 hours and 9 minutes and 59.59 seconds.
*** Detected: 1619 events.
*** Wrote the results into --> " /home/yukuan/mywork/EQT_test/detections_1/SV08_outputs "

mseed_predictor(input_dir= 'downloads_mseeds', input_model='EqT_model.h5', stations_json='station_list.json', output_dir='detections_2', detection_threshold=0.3, P_threshold=0.1, S_threshold=0.1, number_of_plots=99999, plot_mode='time_frequency', overlap=0.3, batch_size=500)
============================================================================
Running EqTransformer  0.1.56
*** Loading the model ...
*** Loading is complete!
######### There are files for 3 stations in downloads_mseeds directory. #########
========= Started working on B921, 1 out of 3 ...
20190901T000000Z__20190902T000000Z.mseed
20190902T000000Z__20190903T000000Z.mseed

*** Finished the prediction in: 0 hours and 16 minutes and 36.25 seconds.
*** Detected: 2835 events.
*** Wrote the results into --> " /home/yukuan/mywork/EQT_test/detections_2/B921_outputs "
========= Started working on CA06, 2 out of 3 ...
20190901T000000Z__20190902T000000Z.mseed
20190902T000000Z__20190903T000000Z.mseed
*** Finished the prediction in: 0 hours and 16 minutes and 0.47 seconds.
*** Detected: 2777 events.
*** Wrote the results into --> " /home/yukuan/mywork/EQT_test/detections_2/CA06_outputs "
========= Started working on SV08, 3 out of 3 ...
20190901T000000Z__20190902T000000Z.mseed
20190902T000000Z__20190903T000000Z.mseed
*** Finished the prediction in: 0 hours and 10 minutes and 3.82 seconds.
*** Detected: 1603 events.
*** Wrote the results into --> " /home/yukuan/mywork/EQT_test/detections_2/SV08_outputs "

`
We can see that we get 2868 detections for station B921 in the first run and 2835 detections in the second run.

Hi @hycarbon this is totally normal and due to applying dropout sampling during each prediction. The output probabilities differs in each inference and this is what we basically use to estimate the uncertainties in the model estimates. Different number of detected events you get is simply for those events with low probability (or high uncertainties) that running the model for a second time result output probability bellow the threshold value. If you set the university estimate option on in the input parameters the code will do multiple predictions basically and the resulted output would be the average of them.

Hi @hycarbon this is totally normal and due to applying dropout sampling during each prediction. The output probabilities differs in each inference and this is what we basically use to estimate the uncertainties in the model estimates. Different number of detected events you get is simply for those events with low probability (or high uncertainties) that running the model for a second time result output probability bellow the threshold value. If you set the university estimate option on in the input parameters the code will do multiple predictions basically and the resulted output would be the average of them.

Hi @smousavi05 thanks for your quick reply.
I'm using mseed_predictor, it seems no multiple prediction option in mseed_predictor and it can not estimate uncertainties, so I would like to check again with you that if there still are dropout sampling in mseed_predictor. (I know the predictor working on hdf5 files has this option and can estimate uncertainties of results).
Actually, I found some clear P and S signals not detected by EQT even though these signals are very similar to those detected. I'm wondering if this is caused by the randomness in EQT, do you have any suggestions? Thanks.

Hi @smousavi05 thanks for your quick reply.
I'm using mseed_predictor, it seems no multiple prediction option in mseed_predictor and it can not estimate uncertainties, so I would like to check again with you that if there still are dropout sampling in mseed_predictor. (I know the predictor working on hdf5 files has this option and can estimate uncertainties of results).
Actually, I found some clear P and S signals not detected by EQT even though these signals are very similar to those detected. I'm wondering if this is caused by the randomness in EQT, do you have any suggestions? Thanks.

@hycarbon Both mseed_predictor and predictor modules use the same model that includes the dropout sampling. The can be multiple reasons for those missed picks. Dropout sampling can have an effect but sometimes the stations characteristics and out of distribution problem can be the case. However there shouldn’t be too many false negatives. There are multiple solutions. The first one is transfer learning which might be a bit time consuming as include some training and fine tuning. Another approach is to use the detected events by EqT as templates and perform a template matching to make sure nothing has left out. Our experiments should this might increase the number of events by 10 %. There are some ml tricks as well that might help but those are more complicated.

@hycarbon Both mseed_predictor and predictor modules use the same model that includes the dropout sampling. The can be multiple reasons for those missed picks. Dropout sampling can have an effect but sometimes the stations characteristics and out of distribution problem can be the case. However there shouldn’t be too many false negatives. There are multiple solutions. The first one is transfer learning which might be a bit time consuming as include some training and fine tuning. Another approach is to use the detected events by EqT as templates and perform a template matching to make sure nothing has left out. Our experiments should this might increase the number of events by 10 %. There are some ml tricks as well that might help but those are more complicated.

Thanks.

Thanks.


describe all build and runtime dependencies in packaging.md

some dependencies in packaging.md are not described. examples include:

libacl(?)
trousers for --enable-tpm

We should really just fix https://github.com/coreos/rkt/blob/master/Documentation/hacking.md#build-time-requirements and then link to there from packaging.md

Should be fixed when I'll have time for https://github.com/coreos/rkt/pull/1864

@krnowak mm but can we get this in for 1.0 so people who want to build it
can? ;-)
On Wed, Feb 3, 2016 at 8:16 PM, Krzesimir Nowak<EMAIL_ADDRESS>wrote:

Should be fixed when I'll have time for #1864
https://github.com/coreos/rkt/pull/1864
—
Reply to this email directly or view it on GitHub
https://github.com/coreos/rkt/issues/2102#issuecomment-179410209.

I'll try tomorrow, today I'm concentrating on code changes.

I noticed the missing dependency in vagrant setup too - see #2104


"Timezone ID '' is invalid" on Cron Reports page

The following error is shown in developer mode, when I try to access the cron reports
Notice: date_default_timezone_set(): Timezone ID '' is invalid in /var/www/html/vendor/magemojo/m2-ce-cron/view/adminhtml/templates/reports.phtml on line 8

I see there's already a PR for the config issue (#54), I'll see to create another one for the timezone

OK, I'll do the testing on previous versions with the new method.

@gnuzealot


SSA latin all changes

cc @EbenSorkin
@moyogo Does it seem all good to you, all files in sync, etc?

Merging this to main branch would be ideal. I tried to create a custom .plist from the SSA-Latin branch but it still receives the old glyphs that shouldn't be included, e.g. rfishhook.

@vv-monsalve @moyogo @ebensorkin I updated the lists, can the PR be merged? Or are we waiting for something else?

I updated the lists, can the PR be merged? Or are we waiting for something else?

@moyogo could you confirm if you are planning to make more changes in the SSA branch?

@RosaWagner @vv-monsalve Sorry for the delay. I’ve updated some language data and will use the scripts #109 to regenerate GF Latin African for SSA languages. I had missed a few things when trying to do it manually.

and will use the scripts https://github.com/googlefonts/glyphsets/pull/109 to regenerate GF Latin African for SSA languages.

@moyogo did you have the opportunity to regenerate eh GF Latin African? :)

This PR was originally authored before we began the transition of glyphsets to the new approach (outlined in the root README) of separately authoring language codes per glyphset, with characters being pulled in from gflanguages, rather than defining glyphsets manually.
I noticed that this PR produces conflicts with the GF Latin Core files that are now under the new approach. So at the very least, we need to make sure that the GF Latin Core are unaffected by this PR.
But I want to propose to take the opportunity to move the new African glyphsets definitions to the new approach immediately.
The purpose of the new approach is twofold:

Dramatically improves the authoring of glyphsets by breaking apart the definitions into a language list per glyphset with with characters being pulled in from gflanguages
Automatically include glyphsets under the new approach into the new shape_languages check in Fontbakery. This check relies on Shaperglot, which in turn relies on language definitions in gflanguages. To make this check even possible, glyphsets need to be in sync with gflanguages, and therefore must be derived from it via language codes rather than manually assembled which might lead to accidental differences in the glyphsets.

This last point is important because African languages contain a lot of character sequences that don't exist as a single encoded character, and therefore the new African fonts that are being authored as we speak should be checked by shape_languages especially for correctly functioning mark features, which requires the glyphsets to be defined under the new approach.
I'm very keen on pushing this transition forward, so I'm offering to author a separate PR. For this, I would need a list of languages per each new glyphset. I'm assuming that the gflanguages definitions are up-to-date for these languages, so assembling the files under the new approach should be easy.
FYI @chrissimpkins

Closing.


Definition and axioms of 'scalar measurement datum'

The current definition of 'scalar measurement datum' is: "a measurement datum that is composed of two parts, numerals and a unit label." This means that measurement datum items that utilize a scale without units (e.g. a Likert or other rating scale) must be typed as 'measurement datum' rather than 'scalar measurement datum'. Is this the intended usage? If so, then it would be useful to add a term such as 'ordinal measurement datum' as a subtype of 'measurement datum' (and possibly the parent of 'scalar measurement datum').
More importantly, there appears to be an unnecessary duplication of entities caused by the axiomatization of 'scalar measurement datum'. Specifically, the axioms for 'scalar measurement datum' include:

'has measurement unit label' min 1 owl:Thing
'has measurement value' min 1 rdfs:Literal
'has value specification' some 'scalar value specification'

These axioms appear unproblematic until you notice that 'scalar value specification' includes the axioms:

'has measurement unit label' min 1 owl:Thing
'has specified numeric value' min 1 rdfs:Literal

such that the value and unit label are duplicated for both the scalar measurement datum and the scalar value specification. The result is 2 presumably distinct ICEs -- each of which has its own value and unit label. It is unclear to me what value is added by including axiom (3) given the current axioms. As far as I can tell, (3) currently creates an extra ICE with duplicate values. Clarification would be greatly appreciated.

Thanks for raising this problem too - it needs resolution and OBI is committing to a solution before the end of January.  This duplication dates back to when OBI introduced value specifications as a second and improved way to capture the value associated with a datum (and separate scales of measure, so in a data structure allowing both a Celsius and Fahrenheit value on a temperature measurement datum); previous to that datums could have 'has measurement value' and 'has measurement unit label' data properties directly as you note.
The unfinished business of that work was to drop these data properties from 'scalar measurement datum'.
I suggest we do that now.
An RDF data structure involving 'has unit' and 'has numeric value' properties (common in the non-OBI world), and OBI datum having 'has measurement unit label' and 'has measurement value' could be converted into a value specification unit and value for data compatibility and OWL driven reasoning.

Thank you for the response. Removing the duplication of axioms is good, but I am wondering whether the definition (and relevant axiom) of 'scalar measurement datum' will also be modified such that it does not require that instances of it have a measurement unit label? Doing so would allow data that use unitless scales to be represented as instances of scalar measurement datum.
Either way, this particular decision affects a large number of terms in my current ontology effort.

Thank you for the response. Removing the duplication of axioms is good, but I am wondering whether the definition (and relevant axiom) of 'scalar measurement datum' will also be modified such that it does not require that instances of it have a measurement unit label? Doing so would allow data that use unitless scales to be represented as instances of scalar measurement datum.
Either way, this particular decision affects a large number of terms in my current ontology effort.

Right, the 'scalar measurement datum' is still carrying requirement for measurement unit label.  A number of OBI curators don't want to see a loosening of that, but I can double check next monday.  If it isn't loosened then it calls for a "unitless scalar measurement datum" class I think.  As you say this is required for survey datum Likert scales etc.  I take it you work with alot of survey data?

Right, the 'scalar measurement datum' is still carrying requirement for measurement unit label.  A number of OBI curators don't want to see a loosening of that, but I can double check next monday.  If it isn't loosened then it calls for a "unitless scalar measurement datum" class I think.  As you say this is required for survey datum Likert scales etc.  I take it you work with alot of survey data?

Discussed again on 2021-01-25: We'll go ahead and drop these axioms from 'scalar measurement datum':

'has measurement unit label' min 1 owl:Thing
'has measurement value' min 1 rdfs:Literal

Since this could potentially break things for people, we'll give some warning. The process will be:

@ddooley will make a PR with these changes
@jamesaoverton will announce to obi-devel and obi-users, with a 2 week comment period
Unless there are major objections, @jamesaoverton will merge

Discussed again on 2021-01-25: We'll go ahead and drop these axioms from 'scalar measurement datum':

'has measurement unit label' min 1 owl:Thing
'has measurement value' min 1 rdfs:Literal

Since this could potentially break things for people, we'll give some warning. The process will be:

@ddooley will make a PR with these changes
@jamesaoverton will announce to obi-devel and obi-users, with a 2 week comment period
Unless there are major objections, @jamesaoverton will merge

'has measurement unit label' and 'has measurement value' have been removed in:
https://github.com/obi-ontology/obi/pull/1299

This is being addressed in https://github.com/information-artifact-ontology/IAO/pull/241 which requires feedback from OBI/IAO users.

Closing this now too as new data model will handle.


Add undefined spec for successful operation

On get operations on inexistent keys, the result is {ok, undefined} but the specs says {ok, bitstring)

hello!! someone alive here?

Unfortunately, I think nobody is alive here. I have cherry-picked your spec fix to our fork: https://github.com/Nordix/eredis_cluster. We have done a lot of improvements in this fork recently.

thanks @zuiderkwast. We'll migrate to your implementation.


Prevent unused types warnings

Prevent typescript unused types warnings by prefixing unused types with _.

Oh, I actually had overlooked that option, because //tslint:disable was already in there and didn't work. As it'll become the default in the next release, to be honest I'd think this commit a bit of a waste. Using that option now, seems a lot better.
(And to be fair, the empty ? "_smth" : "smth" was bugging me a bit... Didn't like this solution all too much...)


[image_picker] Update README for image_picker's retrieveLostData() to support multiple files

issues fixed by this PR

https://github.com/flutter/flutter/issues/89722

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
[ ] I updated CHANGELOG.md to add a description of the change.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Hi @reez12g, thank you for the PR. The changes look good, however please make sure you update the CHANGELOG.md and pubspec.yaml files. Since the README is mostly read on pub.dev, updating the README.md is therefore considered a change that needs to be published and requires the patch number to be updated.

Hi @reez12g, thank you for the PR. Please make sure you update the CHANGELOG.md and pubspec.yaml files. Since the README is mostly read on pub.dev, updating the README.md is therefore considered a change that needs to be published and requires the patch number to be updated.
Also I feel the example code shown in the README is confusing and could be written in a better way (see comment).

Thanks for the comment! I'll check it out!

Hi @reez12g, thank you for the PR. Please make sure you update the CHANGELOG.md and pubspec.yaml files. Since the README is mostly read on pub.dev, updating the README.md is therefore considered a change that needs to be published and requires the patch number to be updated.
Also I feel the example code shown in the README is confusing and could be written in a better way (see comment).

Thanks for the comment! I'll check it out!

I updated the CHANGELOG.md and pubspec.yaml.

@reez12g could you maybe rebase your PR on the master branch in an attempt to fix the failing build steps?

@mvanbeusekom

@reez12g could you maybe rebase your PR on the master branch in an attempt to fix the failing build steps?

It's done! Thank you very much.
However, the submit-queue is failing.
How can I solve this problem?

@mvanbeusekom

@reez12g could you maybe rebase your PR on the master branch in an attempt to fix the failing build steps?

It's done! Thank you very much.
However, the submit-queue is failing.
How can I solve this problem?

@mvanbeusekom
I'm sorry.
I've been waiting for a while, and the builds all succeeded...!

However, the submit-queue is failing.
How can I solve this problem?

Thank you for rebasing @reez12g, looking good now. The submit-queue step indicates if the code on the master branch currently is passing all CI tests. If it is not the submit-queue task will fail to prevent merging more code changes to an already faulty code base. In this case it looks like a flaky test is causing the problem and should pass when the build has re-run.
This is nothing related to your PR, I will add the wait for tree to go green label which will inform the Google Bot to automatically merge this PR when all is green.

However, the submit-queue is failing.
How can I solve this problem?

Thank you for rebasing @reez12g, looking good now. The submit-queue step indicates if the code on the master branch currently is passing all CI tests. If it is not the submit-queue task will fail to prevent merging more code changes to an already faulty code base. In this case it looks like a flaky test is causing the problem and should pass when the build has re-run.
This is nothing related to your PR, I will add the wait for tree to go green label which will inform the Google Bot to automatically merge this PR when all is green.

I understand now!
Thank you so much for your kindness!

This was merged before a fix for our CI landed, so even though the change has been correctly pushed to pub.dev, a tag for this failed to publish into the repo. This is not a big deal, but I just wanted to let you know why this is red in master.
The fix for CI has landed (right after this commit), so from now on the release action should be able to publish and tag new plugins.
Apologies for the inconvenience!

I understand! Thank you for taking the time to tell me!

Thanks again for the fix, keep them coming! 🙏


Create new RTF integration

Description
RTF loader takes care of strip all rtf tags from a file and create a document with plain text.
I made this integration for handle .rtf files (Rich Text Format)
Dependencies:
striprtf
Type of Change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
I create a test for ensure that rtf tags was stripped. You can reproduce the test running:
pytest --path llama_index/llama-index-integrations/readers/llama-index-readers-file/tests/test_rtf.py

[x] Added new unit tests

Suggested Checklist:

[x] I have performed a self-review of my own code
[x] I ran make format; make lint to appease the lint gods

can you run make lint?

@logan-markewich Done, sorry I made it with my local configuration and everything was ok. I ran format, lint and test with project spec and everything is ok

oh darn... @FunkyOz can you run make lint one more time - thanks!

@nerdai done!


Added Option to add Options

The User can now type and if no option fits, he is able to add what he typed as option.
This feature can be toggled by the "addOptionOption" (default: false).
This pull request contains two new variables, one new function and a few new lines of html.

Hi there! Isn't this the same as allowUserOptions? Maybe this feature should get its own demo page to make it more discoverable?

Hi, sorry. You are right and I am blind. Didn't see that feature. Thanks!🤦

Maybe it is worth to combine our two implementations though.
If I toggle allowUserOptions={true} and try to remove the options again, i get the error "MultiSelect: option with label test not found".
Personally, I believe the button I included is also more user friendly. But I guess that comes down to personal preference.

@KaiserRuben Definitely open to changes. Could you share a screen shot or recording of the error and the button you're referring to so I can reproduce?

I actually prefer the current prop name allowUserOptions over addOptionOption. Easier to understand what it's for imo.

I think I have a simple fix over in #69. Just need to add some tests.

allowUserOptions is the better name, agreed.
Also, I had a look at your fix, seems to work!
I still think it might be great to also add the button, similar to what I did in this pull request:
        {#if addOptionOption}
          {#if searchText}

{addOptionsMsg}

          {/if}
        {:else}
          {noOptionsMsg}
        {/if}

If you don't consider this necessary, feel free to close this pull request.
Thanks for your work and your help :)

@KaiserRuben I agree, the addOptionMsg is a good addition, making it much clearer to users that they can create custom options. But we'll have to implement it a bit differently to handle cases like not exceeding maxSelect.


Apply style guide to placeholders in "Troubleshooting commits"

Why:
a) The style guide on placeholders is to use all caps:

Style any placeholder text in all caps

style-guide#placeholders
b) These don't look like bash scripts, and therefore I think they are supposed to be placeholders, not variables:

Closes: N/A

What's being changed (if available, include any code snippets, screenshots, or gifs):

$account -> ACCOUNT
$repository -> REPOSITORY

Check off the following:

[x] I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

[x] For content changes, I have completed the self-review checklist.

@itecompro Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏


config.port is undefined

I think, it was a mistake in the code for the knex part.
At the example, all configuration (including database port) are inside options.config.connection. But, in the knex file, We have this mistake :
https://github.com/willfarrell/middy-rds/blob/262273781169366c156ab0420b44385b124355d2/clients/knex.js#L30-L32
To avoid that, I have to set the port in options.config and options.config.connection

Thanks, I'll patch that up.