Uninstalling installed files yields Cmake warnings

Just for cleanliness I created a Makefile recipe that handles building and deleting built project dependancies. GLFW (3.3-stable) is among them. I'm using the following command from within my project's Makefile to uninstall GLFW. It works as intended but it leaves behind some warnings that it says are for "project developers".
make -C vendor/glfw/build uninstall

The warning:
CMake Warning (dev) at cmake_uninstall.cmake:12 (exec_program):
  Policy CMP0153 is not set: The exec_program command should not be called.
  Run "cmake --help-policy CMP0153" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  Use execute_process() instead.
This warning is for project developers.  Use -Wno-dev to suppress it.

This warning gets repeated for each file that gets uninstalled. For your convenience, this is the output I receive from running cmake --help-policy CMP0153:
exo ➜ cmake --help-policy CMP0153
CMP0153
-------

.. versionadded:: 3.28

The ``exec_program()`` command should not be called.

This command has long been superseded by the ``execute_process()``
command and has been deprecated since CMake 3.0.

CMake >= 3.28 prefer that this command never be called.
The ``OLD`` behavior for this policy is to allow the command to be called.
The ``NEW`` behavior for this policy is to issue a ``FATAL_ERROR`` when the
command is called.

This policy was introduced in CMake version 3.28.
CMake version 3.28.2 warns when the policy is not set and uses
``OLD`` behavior.  Use the ``cmake_policy()`` command to set it to ``OLD`` or
``NEW`` explicitly.

.. note::
  The ``OLD`` behavior of a policy is
  ``deprecated by definition``
  and may be removed in a future version of CMake.

Quick question:

I do wish to make a contribution to fix this, but I'm not sure which branch I should base the PR on. Should I do base it off of 3.3-stable since this is the branch I encountered it on or is there a preferred branch for minute things like this?
And would a minor fix something like this warrant a change log entry and credits? If so awesome!
Oh, and which branch should be used and what's the difference (or intent) behind master, latest, and 3.3-stable? It's always confused me.

Do let me know as I wish to fix it.
Below is the full output of the uninstall command.
make -C vendor/glfw/build uninstall
-- Uninstalling "/usr/local/lib/libglfw3.a"
CMake Warning (dev) at cmake_uninstall.cmake:12 (exec_program):
  Policy CMP0153 is not set: The exec_program command should not be called.
  Run "cmake --help-policy CMP0153" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  Use execute_process() instead.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Uninstalling "/usr/local/include/GLFW/glfw3.h"
CMake Warning (dev) at cmake_uninstall.cmake:12 (exec_program):
  Policy CMP0153 is not set: The exec_program command should not be called.
  Run "cmake --help-policy CMP0153" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  Use execute_process() instead.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Uninstalling "/usr/local/include/GLFW/glfw3native.h"
CMake Warning (dev) at cmake_uninstall.cmake:12 (exec_program):
  Policy CMP0153 is not set: The exec_program command should not be called.
  Run "cmake --help-policy CMP0153" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  Use execute_process() instead.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Uninstalling "/usr/local/lib/cmake/glfw3/glfw3Config.cmake"
CMake Warning (dev) at cmake_uninstall.cmake:12 (exec_program):
  Policy CMP0153 is not set: The exec_program command should not be called.
  Run "cmake --help-policy CMP0153" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  Use execute_process() instead.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Uninstalling "/usr/local/lib/cmake/glfw3/glfw3ConfigVersion.cmake"
CMake Warning (dev) at cmake_uninstall.cmake:12 (exec_program):
  Policy CMP0153 is not set: The exec_program command should not be called.
  Run "cmake --help-policy CMP0153" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  Use execute_process() instead.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Uninstalling "/usr/local/lib/cmake/glfw3/glfw3Targets.cmake"
CMake Warning (dev) at cmake_uninstall.cmake:12 (exec_program):
  Policy CMP0153 is not set: The exec_program command should not be called.
  Run "cmake --help-policy CMP0153" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  Use execute_process() instead.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Uninstalling "/usr/local/lib/cmake/glfw3/glfw3Targets-noconfig.cmake"
CMake Warning (dev) at cmake_uninstall.cmake:12 (exec_program):
  Policy CMP0153 is not set: The exec_program command should not be called.
  Run "cmake --help-policy CMP0153" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  Use execute_process() instead.
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Uninstalling "/usr/local/lib/pkgconfig/glfw3.pc"
CMake Warning (dev) at cmake_uninstall.cmake:12 (exec_program):
  Policy CMP0153 is not set: The exec_program command should not be called.
  Run "cmake --help-policy CMP0153" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.

  Use execute_process() instead.
This warning is for project developers.  Use -Wno-dev to suppress it.

Built target uninstall

From what I understand, this is only a 3 character fix. I understand that isn't a pressing issue like the others, but it is an issue nonetheless. So may I fix this?

I'm a bit busy at the moment so will just write up some quick info:

I do wish to make a contribution to fix this, but I'm not sure which branch I should base the PR on. Should I do base it off of 3.3-stable since this is the branch I encountered it on or is there a preferred branch for minute things like this?

All PRs should be based off master.

And would a minor fix something like this warrant a change log entry and credits? If so awesome!

Normally yes, unless we think someone is Github credit farming.

Oh, and which branch should be used and what's the difference (or intent) behind master, latest, and 3.3-stable? It's always confused me.

We intend to document this but haven't' gotten around to it yet, here's a short summary:

master (also called main which we may switch to in future) this is the primary development branch and should be used as the base for all PRs.
latest gets updated to the most recent major, minor or patch release after each release.
x.x-stable branched from its release tag on main, receives cherry-picked bug fixes for patch releases in parallel with the next minor or major release.

So may I fix this?

We welcome PRs but they do take time to get merged as there is a lot of outstanding work.

Thanks so much for your response. Sorry I was a little impatient. I'll make the PR and have it close this issue :)

No problem - however do leave this issue open until the PR is merged or this issue is otherwise resolved.

This turned out to be a little more than I can handle considering I do not know cmake very well. I have decided to let the the GLFW team (or anyone else) work on this issue. This is as far as I've gotten:
@@ -9,16 +9,16 @@ string(REGEX REPLACE "\n" ";" files "${files}")
 foreach (file ${files})
   message(STATUS "Uninstalling \"$ENV{DESTDIR}${file}\"")
   if (EXISTS "$ENV{DESTDIR}${file}")
-    exec_program("@CMAKE_COMMAND@" ARGS "-E remove \"$ENV{DESTDIR}${file}\""
-                 OUTPUT_VARIABLE rm_out
-                 RETURN_VALUE rm_retval)
+    execute_process(COMMAND CMAKE_COMMAND ARGS "-E rm \"$ENV{DESTDIR}${file}\""
+                    OUTPUT_VARIABLE rm_out
+                    RESULT_VARIABLE rm_retval)
     if (NOT "${rm_retval}" STREQUAL 0)
       MESSAGE(FATAL_ERROR "Problem when removing \"$ENV{DESTDIR}${file}\"")
     endif()
   elseif (IS_SYMLINK "$ENV{DESTDIR}${file}")
-    EXEC_PROGRAM("@CMAKE_COMMAND@" ARGS "-E remove \"$ENV{DESTDIR}${file}\""
-                 OUTPUT_VARIABLE rm_out
-                 RETURN_VALUE rm_retval)
+    execute_process(COMMAND CMAKE_COMMAND ARGS "-E rm \"$ENV{DESTDIR}${file}\""
+                    OUTPUT_VARIABLE rm_out
+                    RESULT_VARIABLE rm_retval)
     if (NOT "${rm_retval}" STREQUAL 0)
       message(FATAL_ERROR "Problem when removing symlink \"$ENV{DESTDIR}${file}\"")
     endif()

And it fails to delete the files, exiting with exit code 2: "No such file or directory" although it still exists.

Sources I looked at while trying to get this to work:

https://cmake.org/cmake/help/latest/command/execute_process.html
https://cmake.org/cmake/help/latest/variable/CMAKE_COMMAND.html
https://cmake.org/cmake/help/latest/manual/cmake.1.html#cmdoption-cmake-E-arg-remove

execute_process(COMMAND ${CMAKE_COMMAND} -E remove \"$ENV{DESTDIR}${file}\"
                OUTPUT_VARIABLE rm_out
                RESULT_VARIABLE rm_retval)

I no longer see who put the message up with code that solved the issue, but whoever it was, thank you :)

I just ran it and it got rid of the warnings, but the files remain.

strangely its not deleting the file. This is why i removed the message.
execute_process(COMMAND ${CMAKE_COMMAND} -E rm -f \"$ENV{DESTDIR}${file}\"
                OUTPUT_VARIABLE rm_out
                RESULT_VARIABLE rm_retval)

I can't try to figure it out right now, but I can try tomorrow and see if I have any success with it.


crossbeam-epoch: Bump memoffset to 0.7

mostly to keep the number of dupes of crates in my dependency graph down

Thanks.
bors r+


Add a website section for Section 5 pilots communication

This website is a great step forward in an open dialog.  Thanks!
The Section 5 pilots for grants and contracts are key to this conversation.  Would you consider adding a section to the site to communicate status and progress of the pilots?  It could summarize and provide a link for more information (like to the DAP page).
There is a lot of misinformation about the pilots - it would be nice to have one public place to go to find the latest facts on the progress of that component of the law.

Herschel,
Thank you for your email. The best place to find information about the Pilot is the DATA Act page on USAspending.gov: https://www.usaspending.gov/Pages/data-act.aspx
For the grants track of the pilot, you can find additional information at: http://www.hhs.gov/about/agencies/asfr/data-act-program-management-office/section-5-grants-pilot/index.html
Best,
Nicole
Nicole Martinez Moore
Office of Management and Budget
Office of Federal Financial Management
Policy Analyst
P:<PHONE_NUMBER>
BB:<PHONE_NUMBER>
From: Herschel Chandler<EMAIL_ADDRESS>Sent: Thursday, April 7, 2016 10:04 AM
To: fedspendingtransparency/fedspendingtransparency.github.io<EMAIL_ADDRESS>Subject: [fedspendingtransparency/fedspendingtransparency.github.io] Add a website section for Section 5 pilots communication (#147)
This website is a great step forward in an open dialog. Thanks!
The Section 5 pilots for grants and contracts are key to this conversation. Would you consider adding a section to the site to communicate status and progress of the pilots? It could summarize and provide a link for more information (like to the DAP page).
There is a lot of misinformation about the pilots - it would be nice to have one public place to go to find the latest facts on the progress of that component of the law.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub<%3ehttps:/github.com/fedspendingtransparency/fedspendingtransparency.github.io/issues/147%3c>


Register This Package?

Is there a plan to register this package? I would like to be able to start using it to some extent, but it cannot be a dependency until it's registered.

I'm sorry I missed this issue..
Actually as you can see there are still some issues left, which I don't know how to fix for now.
For example as I mentioned in this issue(https://github.com/sunoru/RNG.jl/issues/12), I couldn't find a good algorithm for sequencing the seed. Therefore it's not gauranteed to be correct when using this package, and that's why I haven't registered this package yet.
Anyway if one only uses RNGs which are confirmed to be good to use, such as xoroshiro128plus or PCG family this package works well.
I didn't realise it's necessary to be registered to be a dependency.. So maybe I should register it anyway and put a warning or something to warn the users?

I think it would be fine to register and warn. There's lots of usable stuff here, and it's reasonable to register early and let it improve over time.

I have created a pull request. https://github.com/JuliaLang/METADATA.jl/issues/7888

It's registered now.


Autocomplete input: :open-on-click="true" together with selection-appearance="option" causes unintended behavior?

Reproduction
https://formkit.com/playground?fkv=latest&fileTab=Playground.vue&css-framework=genesis&files=jc[('name!'PlaygY.vj'~editX!'<scrip9setupAH+ESM+impXtDarQsuppXTd+from+URLD{https%3AHcdn...}5H+aDwell+aDsecondary+playgY+fiqD{.%2FOtherFiq.vj}.5JscriptA5<TmplaTA8<FXmKit0typeBautocompqT60seqcV-appearanceBopV60labelBFXmKi9Input60helpBedi9mQtxge9starTdZopen-on-clickBtrjZopVsB[4171G4272G4373G0]ZvaljB3658%2FAJTmplaTA5<styqA%2F*5WXkaY+sxtha9clicking+onzdoesn"9open+thQdropdown+{uncommen9txseQi9wXk}5*%2F5%2F*+5_ouTr[data-compqT%3D"trj"]+_wrapperz(58poinTr-eventsNnone%3B5)5*%2F5JstyqA'~added!trj)]0588408(CN"OpV+5\n6\'7"%2C+valjN8++9t+A>5B%3D6zlabelDs+G+)%2CH%2F%2FJ<%2FN%3A+Qe+TteVtionXorYroundZ60%3A_.fXmkit-jueqlexo+zC+zxqj_ZYXVTQNJHGDCBA9876540_&imports=jc('name!'ImportMap'~editor!'(*+1vue\!1https%3A%2F%2Fcdn.jsdelivr.net%2Fnpm%2Fvue%403%2Fdist%2Fvue.esm-browser.min.js0*)*')*\n0\'1+010*_
Describe the bug
On the autocomplete input when open-on-click is set to true and selection-appearance is set to option you can still open the dropdown by clicking on the label.
The workaround for this is to disabled pointer events on the label by using the data-complete attribute of the wrapper of the component which I do like this in my Tailwind theme:
'autocomplete': {
    label: 'formkit-complete:pointer-events-none',
}

But my workaround only works partially because of the other bug I reported: https://github.com/formkit/formkit/issues/816
Environment
• OS: MacOS
• Browser: Arc (Chromium)
• Version: 0.17.4

Thanks for the report 👍


Incorrect protocol msteams specified in gateway configuration msteams.teams, exiting.

Hi there,
Someone know if Microsoft Teams is still supported ?
If I add this to my conf :
[msteams.teams]
TenantID="my tenant ID"
ClientID="my client ID"
TeamID="my team ID"
RemoteNickFormat="[{PROTOCOL}] <{NICK}> "

[[gateway.inout]]
                account="msteams.teams"
<EMAIL_ADDRESS>
I got this error :

"Incorrect protocol msteams specified in gateway configuration msteams.teams, exiting."

I followed this setyp config :
https://github.com/42wim/matterbridge/wiki/MS-Teams-setup

Hi, msteams hasn't been merged yet. Will be soon.
You can find the PR to test with here: https://github.com/42wim/matterbridge/pull/967


All instances of "println" should be replace with "print"

We should always be using pythonic constructs in favor over Processing's hacks which are just making up for sucky Java APIs. Python's print should be used always.

Hmm. This seems... subtle to communicate to a beginner.

processing.py is Python 2 -- so print is a statement, not a function: print 3
but it maps against the Processing Java-like API, so the documentation is written: print(3)
a common way to support this in Python 2 is from __future__ import print_function
however, processing.py doesn't use this
instead, it uses the native print statement, which prints tuples.
so print(3) prints the tuple (3), which reduces to 3 and prints. print 3 prints the same.
By contrast, if you print(3,2) in Python 3 or with print_function, then you get 3 2 where in Python 2 and processing.py you get (3, 2) (the tuple).
further, Processing.py sketches can optionally use from future import print_function as a first line just fine, so this is configurable behavior, just as in Python 2.

There are a lot of subtle gotchas that could confuse learners, but the key thing -- that print() is not really a function, it is a statement plus a tuple -- seems like something you could explain in an advanced note at the bottom of the print documentation. Leading with that for beginners might probably raise questions rather than answering them in a way that isn't helpful.
https://stackoverflow.com/questions/12162629/using-print-the-function-version-in-python2-x


Instance fails randomly

Hi,
I'm currently having a problem with one of my instances. The instance randomly fails and I need to restart the service to get it going again.
Here's what the output of systemctl status X5SA gives me:

X5SA.service - The snappy web interface for your 3D printer
Loaded: loaded (/etc/systemd/system/X5SA.service; enabled; vendor preset: enabled)
Active: failed (Result: signal) since Tue 2022-08-09 20:24:36 CEST; 12h ago
Process: 822405 ExecStart=/home/thomas/OctoPrint/bin/octoprint serve --config=${CONFIGFILE} --basedir=${BASEDIR} --port=${PORT} (code=killed, signal=SEGV)
Main PID: 822405 (code=killed, signal=SEGV)
CPU: 12min 4.852s
Aug 09 19:28:47 octoprint-host octoprint[822405]: 2022-08-09 19:28:47,831 - octoprint.plugins.tracking - INFO - Sent tracking event ping, payload: {'octoprint_uptime': 125105, 'printer_state': 'OFFLINE'}
Aug 09 19:43:42 octoprint-host octoprint[822405]: 2022-08-09 19:43:42,891 - octoprint.server.heartbeat - INFO - Server heartbeat <3
Aug 09 19:43:47 octoprint-host octoprint[822405]: 2022-08-09 19:43:47,833 - octoprint.plugins.tracking - INFO - Sent tracking event ping, payload: {'octoprint_uptime': 126005, 'printer_state': 'OFFLINE'}
Aug 09 19:58:42 octoprint-host octoprint[822405]: 2022-08-09 19:58:42,892 - octoprint.server.heartbeat - INFO - Server heartbeat <3
Aug 09 19:58:47 octoprint-host octoprint[822405]: 2022-08-09 19:58:47,835 - octoprint.plugins.tracking - INFO - Sent tracking event ping, payload: {'octoprint_uptime': 126905, 'printer_state': 'OFFLINE'}
Aug 09 20:13:42 octoprint-host octoprint[822405]: 2022-08-09 20:13:42,893 - octoprint.server.heartbeat - INFO - Server heartbeat <3
Aug 09 20:13:47 octoprint-host octoprint[822405]: 2022-08-09 20:13:47,844 - octoprint.plugins.tracking - INFO - Sent tracking event ping, payload: {'octoprint_uptime': 127805, 'printer_state': 'OFFLINE'}
Aug 09 20:24:36 octoprint-host systemd[1]: X5SA.service: Main process exited, code=killed, status=11/SEGV
Aug 09 20:24:36 octoprint-host systemd[1]: X5SA.service: Failed with result 'signal'.
Aug 09 20:24:36 octoprint-host systemd[1]: X5SA.service: Consumed 12min 4.852s CPU time.

Does anyone have an idea where I should have a look at to get to the bottom of this? The other instance runs without a problem.
here's the content of the X5SA.service file:
[Unit]
Description=The snappy web interface for your 3D printer
After=network.online.target
Wants=network.online.target

[Service]
Environment="PORT=5002"
Environment="BASEDIR=/home/thomas//.X5SA"
Environment="CONFIGFILE=/home/thomas//.X5SA/config.yaml"
User=thomas
ExecStart=/home/thomas/OctoPrint/bin/octoprint serve --config=${CONFIGFILE} --basedir=${BASEDIR} --port=${PORT}

[Install]
WantedBy=multi-user.target

I compared it to the X5SAPro.service file and it's basically the same (except the different values of the variables of course)

Okay, I just looked at the dmesg output and found this:
[Tue Aug  9 20:24:35 2022] octoprint[822405]: segfault at 7f6a905d23d0 ip<PHONE_NUMBER>51d2bc sp 00007fff6263e550 error 6 in python3.9[41f000+288000]
[Tue Aug  9 20:24:35 2022] Code: 4c 8b 6f 40 83 c2 01 48 8d 9f 68 01 00 00 41 89 94 24 b8 00 00 00 4c 39 eb 73 22 48 8b 3b 48 85 ff 74 11 48 c7 03 00 00 00 00 <48> 83 2f 01 0f 84 ba 00 00 00 48 83 c3 08 4c 39 eb 72 de 48 83 7d

Not something I have seen before, even with running many instances. It is possible there is a memory issues, which can give rise to segfaults.

I'll have a look at the memory usage, but there should be enough memory for those two instances.
Maybe a memory stick is bad, since this is an old laptop I'm currently using.
Just a couple of minutes ago the other instance crashed (same error in dmesg output).

yeah, some bad memory might be what you are looking at here.


refactor(server): Dropped RegexCustomType in favour of upstream Regex support (replacement pr)

Bumped config4k to 0.4.1 including built in Regex support.
Deleted unnecessary RegexCustomType.

Replaces #894
Closes #893

:+1:

:+1:


Repair firebase imports

As an aside: tslint has control issues.
I mean, I get it, banning 'any' is a good idea. But here? I'm explicitly asking to use any because it's better that way. Sure, I could do something like
const firebaseInitializeApp = ((firebase as {})["default"] as {})["initializeApp"];

except that (1) this isn't fundamentally any safer and (2) it's way harder to see what the code is doing.
The point of any, I thought, was that it was an escape hatch for when you needed to deal with things that were outside the ken of typescript. So why are my only options no-any (ever) or no-dynamic-any (which wouldn't let me do this either)? Where's no-implicit-any, to make sure that I only declare something any when I actually need to?
@mykmartin noticed a similar thing with variable declaration. You can:

force everyone to always declare variables on one line, always
force everyone to always declare each variable on its own line, always
force everyone to always declare adjacent variables on one line, always

in other words, you get lots of fundamentalist options. But you can't force variables to be declared on their own line only when they have an initializing value, or any other nuanced combination.
I don't think we can turn off no-any without opening ourselves up to a world of hurt, but I'm also pretty convinced that tslint annotations on lines where we need to use any aren't going to go down well in the long run. Is this the point where we fork tslint?

Ah! the compiler has a noImplicitAny option; so we can disable no-any in tslint. Thankfully.
Paul, any objection to disabling it now? Or would you rather wait until we can turn on noImplicitAny?

So I'm not a js module expert, but I was following some hints.  Firebase specifies this syntax for typescript:
import firebase from 'firebase';
var app = firebase.initializeApp({ ... });

But the first line is not working in our environment.  It fails with
TS1192: Module '".../arcs/main/node_modules/firebase/index"' has no default export.

Looking into TypeScript issues I found these two mentions of using the alternate syntax:
 import * as firebase from 'firebase';

See the following discussions:

https://github.com/Microsoft/TypeScript/issues/3337
https://github.com/Microsoft/TypeScript/issues/2242#issuecomment-83694181

I'd hope we can find some solution that avoids using 'default' above.  Will look into this a little bit more.

I hope I'm not adding noise to this situation, but I have my own fingers in this pie. :)
Firebase still refuses to be loadable from the client without a transpilation step, so I gave up on that, but I still would like a single dependency to avoid, e.g.
// keep in sync with shell/source/ArcsLib.js

So what I did was create runtime/firebase.js as follows:
import * as firebase from 'firebase/app';
import 'firebase/database';
import 'firebase/storage';
export {firebase};

And then employ that in firebase-storage.ts like so:
declare var firebase: typeof import('firebase');
import {firebase} from '../../firebase.js';

and in ArcsLib.js as:
import {firebase} from '../../runtime/firebase.js';

This way there is only one file to do the firebase incantations (+ one extra decl when using ts).
What say you?

I've no objection to you hunting around to find a better solution, but in the meantime ToT is broken. Please approve this patch so I can continue to make progress towards our milestone?
I'll also reiterate that this is known brokenness in the modular import approach wrt firebase and typescript: https://github.com/firebase/firebase-js-sdk/issues/716.

Another option.  Switch to:
import firebase from 'firebase';

and add
"allowSyntheticDefaultImports": true

to tsconfig.json
Less hacky, but does return the firebase console message...

@lindner as I already described on chat last Saturday, the existing tests that demonstrate breakage can be invoked using ./tools/sigh test --manual.
If you're making further changes in this area be sure to check that these tests continue to pass.


chore: Update auth pages ui @Isaac-Tait

This pull request addresses #131 I also tweaked the css for the forgot password page so that the button was not rubbing against the input field:
Before

After

Looping back to this as it has been awhile. I had not noticed that my pull request had errored out. So, I went back and fixed it...


Reading: Updates for importer in first test runs

Building on @edavidsonsawyer's awesome work in https://github.com/studentinsights/studentinsights/pull/2523.
Who is this PR for?
Somerville K5 teachers, reading specialists and literacy coaches
What does this PR do?
Some updates to support data quality checks on the initial imports, a bug fix on oral reading fluency column headers, and a UI bug fix on how fall benchmark periods are represented.
Checklists
Which features or pages does this PR touch?

[x] Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

[x] Manual testing made more sense here

selfie


Redirect to the previous page after language change

If user comes to an article on https://reactjs.org/ in English language (for example, he comes from google search), then he expects to be redirected to the same page when he switches the language.

There is an issue from react repository that indicates this behavior, this pull request solve that issue#21176

In my opinion, that seems the expected behavior

Hello @vkatatab!
The new react.dev manages translation more indirectly, by separate page mentioning separate translation repos out there. This makes this PR unfortunately no longer required, so I let me close this.
Still, thank you for working on it and for contributing!


Syntax highlighting in Code Blocks without example

Hi,
is it possible to get html syntax highlighting in a code block without example? Like:
/*doc
---
title: Title
name: name
category: category
---
```
<div class="html-example"></div>
```
*/

@philipisik yes you just need to write a custom renderer or only allow your template to output the code example without the preview.
here's a sass code_example_renderer that I've written.
Hologram::CodeExampleRenderer::Factory.define 'sass' do
  example_template 'sass_example_template'
  table_template 'sass_table_template'
  lexer { Rouge::Lexer.find('sass') }
end

and then in the templates dir I just provide the sass_example_template and the sass_table_template


The difference in GPU running points between Windows and wsl is too large

Windows Version
Microsoft Windows [版本 10.0.22621.2428]
WSL Version
<IP_ADDRESS>
Are you using WSL 1 or WSL 2?

[X] WSL 2
[ ] WSL 1

Kernel Version
<IP_ADDRESS>
Distro Version
Ununtu 22.04
Other Software
Download gputest on the official website or use the one I provided
https://www.geeks3d.com/gputest/
GpuTest_Linux_x64_0.7.0.zip
GpuTest_Windows_x64_0.7.0.zip
Repro Steps
First of all, I will determine the graphics card driver that I need to install for the wsl
https://developer.nvidia.com/video-encode-and-decode-gpu-support-matrix-new
The ubuntu can display graphics card information
root@future:~/kooapk/kooapk-kitchen/tmp/222/GpuTest_Linux_x64_0.7.0# nvidia-smi
Tue Oct 31 19:31:17 2023
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 470.94       Driver Version: 472.88       CUDA Version: 11.4     |
|-------------------------------+----------------------+----------------------+
| GPU  Name        Persistence-M| Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp  Perf  Pwr:Usage/Cap|         Memory-Usage | GPU-Util  Compute M. |
|                               |                      |               MIG M. |
|===============================+======================+======================|
|   0  NVIDIA GeForce ...  Off  | 00000000:2B:00.0  On |                  N/A |
|  0%   50C    P5    15W / 170W |   3446MiB / 12288MiB |    ERR!      Default |
|                               |                      |                  N/A |
+-------------------------------+----------------------+----------------------+

+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|  No running processes found                                                 |
+-----------------------------------------------------------------------------+

ubuntu
./GpuTest /test=fur /width=1920 /height=1080 /fullscreen /benchmark

windows
.\GpuTest /test=fur /width=1920 /height=1080 /fullscreen /benchmark

Expected Behavior
I feel that playing a video has resulted in a GPU usage rate of 98% when using EMBY software. I feel that the GPU performance under wsl has suffered a significant loss
So we specifically use gputest for score testing. Logically speaking, the difference in scores should not be too large
Actual Behavior
The difference between running points and fps is too large
ubuntu

windows

Diagnostic Logs
No response

@OneBlue @iourit @craigloewen-msft  May I ask if you can answer my question. thanks

This could be the result of inefficient update of the window content inside WSL vs. the host. Could you take ETW traces on the host for both scenarios using WPR (Windows Performance Recorder)? Open an elevated CMD window and run:
wpr -start GPU -filemode

wpr -stop tracefile.etl
You can look at the traces yourself using WPA.EXE or GpuView.EXE from Windows Performance tools (https://learn.microsoft.com/en-us/windows-hardware/test/wpt) and also share in this thread.
https://learn.microsoft.com/en-us/windows-hardware/test/wpt/
Trace files could be big, so run your scenario only for several seconds.


Skip the OAuth fail spec

This PR skips the OAuth failed spec, this is due to the fact that the current nakadi docker-compose that we run our integration tests against will accept any token as a valid one so its not really possible to test it this way.
In the future we should try and mock such a response.
The PR also improves the token handling for passing the token via environment variables should we need this functionality in the future

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@45f428f). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master     #90   +/-   ##
========================================
  Coverage          ?   74.4%
========================================
  Files             ?      22
  Lines             ?     500
  Branches          ?       9
========================================
  Hits              ?     372
  Misses            ?     128
  Partials          ?       0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45f428f...23a0faf. Read the comment docs.


Show the Grid even without a DS; prevent an infinite loop

Changes and tests missing

Comments from the review on Reviewable.io

Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r4.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io


Limit not working correctly

Hello everybody. I'm having an issue with the limit property. It's set to 60 and filters with a hashtag. The problem is that it's only showing the last 5 images with that hashtag. I'm aware that instafeed only searches images with such hashtag on the last 60 posts, but currently, there are a lot more than 5 in the 60 most recent ones.
Here is the code I'm using:

Is anybody having similar problems or can anybody give me a hand with this? Maybe i'm missing something.
Thanks!

The limit on Instagram's end is actually 20.
No matter what you'll put above 20, Instafeed will get the last 20 posts of your account, and then only show the ones with the hashtag "contrapitos". I guess you only had 5 with this hashtag in your last 20 posts

Instagram's limit should be put in the Instafeed.js docs. (I ended up here as I was about to post the same problem after checking the docs for anything about limits and not finding anything.)


Frontend/page/event detail

Pull Request Description
Title:  Create Event Detail Page, Improve Homepage UI, and Refine Error Messages
Summary
This pull request implements an event detail page that allows users to view specific event information, enhances the user interface of the homepage for a better user experience, and improves error messaging during the event creation process.
Changes Made

Event Detail Page:

Created a new page for viewing detailed information about specific events, including descriptions, dates, and attendee information.

Homepage UI Improvements:

Refined the layout and design of the homepage to enhance user engagement.

Error Message Enhancements:

Improved the clarity and specificity of error messages displayed during the event creation process, providing users with better guidance to resolve issues.

After I have tested your branch. Looks great! The new event detail page and UI improvements enhance the user experience, and the refined error messages are clear and helpful. Ready to merge.


Run fyle and c1 theme simultaneouly in local POC

Summary by CodeRabbit

New Features

Added environment-specific configuration files for 'Fyle' and 'Capital One'.
Introduced branding configuration files for 'Fyle' and 'Capital One'.
Added new scripts to serve the application with specific configurations for 'Fyle' and 'Capital One' themes.

Documentation

Updated README with instructions for copying configuration files and running the app in different themes.

Configuration

Updated angular.json with new configurations for different ports and file replacements.

please also put out PR for integrations central

please also put out PR for integrations central

https://github.com/fylein/fyle-integrations-central/pull/74


Fix ref_allele_mismatch in liftover_expr for indel variants

Hi, it seems the current ref_allele_mismatch doesn't work when the original reference allele has more than one bp. This PR fixes the issue.
Additionally, I found there are ref_allele_mismatch cases where ref/alt flips between the builds. For example, chr3:195513874:T:C (GRCh38) corresponds to 3:195240670:C:T (GRCh37).
It is particularly confusing since it looks like new_alleles == original_alleles but ref_allele_mismatch is true. Does it make sense to add a field e.g. ref_alt_flip? If so, I'd be happy to make a separate PR.
+---------------+------------+---------------+-------------+----------------+------------------+---------------------+---------------------+
| locus         | alleles    | new_locus     | new_alleles | original_locus | original_alleles | locus_fail_liftover | ref_allele_mismatch |
+---------------+------------+---------------+-------------+----------------+------------------+---------------------+---------------------+
| locus<GRCh37> | array<str> | locus<GRCh37> | array<str>  | locus<GRCh38>  | array<str>       |                bool |                bool |
+---------------+------------+---------------+-------------+----------------+------------------+---------------------+---------------------+
| 3:195236460   | ["T","C"]  | 3:195236460   | ["T","C"]   | chr3:195509651 | ["T","C"]        |               false |                true |
| 3:195236756   | ["G","C"]  | 3:195236756   | ["G","C"]   | chr3:195509947 | ["G","C"]        |               false |                true |
| 3:195237817   | ["C","A"]  | 3:195237817   | ["C","A"]   | chr3:195511010 | ["C","A"]        |               false |                true |
| 3:195240670   | ["T","C"]  | 3:195240670   | ["T","C"]   | chr3:195513874 | ["T","C"]        |               false |                true |
| 3:195242526   | ["T","C"]  | 3:195242526   | ["T","C"]   | chr3:195515729 | ["T","C"]        |               false |                true |
| 3:195244526   | ["T","C"]  | 3:195244526   | ["T","C"]   | chr3:195517728 | ["T","C"]        |               false |                true |
| 3:195245027   | ["G","A"]  | 3:195245027   | ["G","A"]   | chr3:195518229 | ["G","A"]        |               false |                true |
| 3:195245225   | ["G","A"]  | 3:195245225   | ["G","A"]   | chr3:195518427 | ["G","A"]        |               false |                true |
| 3:195246299   | ["G","A"]  | 3:195246299   | ["G","A"]   | chr3:195519502 | ["G","A"]        |               false |                true |
| 3:195251227   | ["G","C"]  | 3:195251227   | ["G","C"]   | chr3:195524429 | ["G","C"]        |               false |                true |
+---------------+------------+---------------+-------------+----------------+------------------+---------------------+---------------------+

Sorry, I'm not sure I'm following. The examples you have are all SNPs, so I don't see how this affects indels. For the SNPs, yes, grabbing the ref context and checking for a flip is the ideal scenario, but note that it comes at the computational cost of the context lookup, so I'd advocate for a flag where you can turn it off.

Oh! I just realized this was two different suggestions (separated by "Additionally") - sorry about that! Yes, this seems sensible, though it could be worthwhile to have a documented example just so we can see what happens.


kubernetes/canary-demo - do we have a sample VM with the required tools pre-installed?

[Enter feedback here]
https://learn.microsoft.com/en-us/azure/devops/pipelines/ecosystems/kubernetes/canary-demo?view=azure-devops&tabs=yaml
First, I would like to suggest that link feedback for this page opens a new browser tab.
Second
Do we have a sample VM where helm, kubectl and az is preinstalled?
At mine - I am having a helm issue.
helm install --name sampleapp stable/prometheus-operator
Error: could not find tiller
Third
Create service connections
Go to Project settings > Pipelines > Service connections.
It is not clear, where shall I go to add project settings.
Somewhere at https://dev.azure.com/ or at https://portal.azure.com/

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 079492cb-bdc3-7ba6-8581-dd76391cda4f
Version Independent ID: 81e719d4-b127-fa41-4cf2-421e91b9d4be
Content: Canary deployment strategy for Kubernetes deployments - Azure Pipelines
Content Source: docs/pipelines/ecosystems/kubernetes/canary-demo.md
Service: azure-devops
Sub-service: azure-devops-ecosystem
GitHub Login: @azooinmyluggage
Microsoft Alias: atulmal

@matjung -- thank you for your thorough feedback.

You can submit issues related to overall site experience, or suggestions for improved site functionality or design, at https://aka.ms/sitefeedback/.
Please consider these resources:
- Azure DevOps Services
- Azure DevOps on Stack Overflow
I defer to Julia on this one.

@juliakm -- please look into this issue.

@matjung We don't have a sample VM. Project settings are at https://dev.azure.com/ in Azure DevOps. I'll update the article to make that clearer.


Update to version 0.46

Ping @cwingard.
@ocefpaf, would appreciate a 'hacktoberfest-accepted' label if accepted!

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.


Godot crashes on opening project folder after build 100%

Operating system or device, Godot version, GPU Model and driver (if graphics related):
MacBook Air, High Sierra, Godot 3.0b1
Issue description:

Created a C# script for a node object in my scene with an [Export] public Node[] array.
Compiled game.
Node[] didn't show up in inspector, this is apparently not supported in the Editor, fine.
Change Node to string[] in script.
Re-compile game.
Game crashes, Godot crashes, Godot crashes every time I attempt to reopen my project folder - 100% blocked.

Process:               Godot [16857]
Path:                  /Applications/Godot_v3.0-beta1_mono_osx64.app/Contents/MacOS/Godot
Identifier:            org.godotengine.godot
Version:               3.0-dev (3.0-dev)
Code Type:             X86-64 (Native)
Parent Process:        ??? [1]
Responsible:           Godot [16857]
User ID:               501
Date/Time:             2017-12-10 10:52:14.121 -0800
OS Version:            Mac OS X 10.13.2 (17C88)
Report Version:        12
Anonymous UUID:        860ED494-06AD-5BC1-629B-F5D4243A343C
Sleep/Wake UUID:       665F84A7-0BED-4864-93AB-E6CC46E93AA0
Time Awake Since Boot: 27000 seconds
Time Since Wake:       5700 seconds
System Integrity Protection: enabled
Crashed Thread:        0  tid_307  Dispatch queue: com.apple.main-thread
Exception Type:        EXC_BAD_ACCESS (SIGABRT)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY
External Modification Warnings:
Debugger attached to process.
VM Regions Near 0:
-->
__TEXT<PHONE_NUMBER>bd2000-0000000106f1d000 [ 51.3M] r-x/rwx SM=COW  /Applications/Godot_v3.0-beta1_mono_osx64.app/Contents/MacOS/Godot
Application Specific Information:
abort() called
Thread 0 Crashed:: tid_307  Dispatch queue: com.apple.main-thread
0   libsystem_kernel.dylib        	0x00007fff63cafe3e __pthread_kill + 10
1   libsystem_pthread.dylib       	0x00007fff63dee150 pthread_kill + 333
2   libsystem_c.dylib             	0x00007fff63c0c312 abort + 127
3   org.godotengine.godot         	0x0000000103cbaf9b mono_handle_native_crash + 603 (mini-exceptions.c:2713)
4   org.godotengine.godot         	0x0000000103c37ac6 altstack_handle_and_restore + 70 (exceptions-amd64.c:799)
5   org.godotengine.godot         	0x0000000105b5c41d String::parse_utf8(char const*, int) + 29
6   org.godotengine.godot         	0x0000000105b5c3b6 String::utf8(char const*, int) + 22
7   org.godotengine.godot         	0x000000010413432e GDMonoMarshal::mono_to_utf8_string(_MonoString*) + 206
8   org.godotengine.godot         	0x0000000104137d4b GDMonoMarshal::mono_array_to_PoolStringArray(_MonoArray*) + 91
9   org.godotengine.godot         	0x00000001041372b6 GDMonoMarshal::mono_object_to_variant(_MonoObject*, ManagedType const&) + 2358
10  org.godotengine.godot         	0x000000010413693d GDMonoMarshal::mono_object_to_variant(_MonoObject*) + 109
11  org.godotengine.godot         	0x00000001041136a6 CSharpScript::_update_exports() + 3510
12  org.godotengine.godot         	0x00000001041164e8 CSharpScript::instance_create(Object*) + 1624
13  org.godotengine.godot         	0x0000000105acbb65 Object::set_script(RefPtr const&) + 197
14  org.godotengine.godot         	0x0000000105acb89d Object::set(StringName const&, Variant const&, bool*) + 237
15  org.godotengine.godot         	0x00000001055d40d0 SceneState::instance(SceneState::GenEditState) const + 3712
16  org.godotengine.godot         	0x00000001055d66de PackedScene::instance(PackedScene::GenEditState) const + 30
17  org.godotengine.godot         	0x00000001055d399a SceneState::instance(SceneState::GenEditState) const + 1866
18  org.godotengine.godot         	0x00000001055d66de PackedScene::instance(PackedScene::GenEditState) const + 30
19  org.godotengine.godot         	0x0000000104824aa3 EditorNode::load_scene(String const&, bool, bool, bool, bool) + 3811
20  org.godotengine.godot         	0x0000000104823ba5 EditorNode::_sources_changed(bool) + 69
21  org.godotengine.godot         	0x000000010487c913 MethodBind1<EditorNode, bool>::call(Object*, Variant const**, int, Variant::CallError&) + 387
22  org.godotengine.godot         	0x0000000105acf517 Object::call(StringName const&, Variant const**, int, Variant::CallError&) + 423
23  org.godotengine.godot         	0x0000000105ad10e5 Object::emit_signal(StringName const&, Variant const**, int) + 1605
24  org.godotengine.godot         	0x0000000105acfbdd Object::emit_signal(StringName const&, Variant const&, Variant const&, Variant const&, Variant const&, Variant const&) + 109
25  org.godotengine.godot         	0x00000001047d96df EditorFileSystem::_notification(int) + 1887
26  org.godotengine.godot         	0x00000001047e121c EditorFileSystem::_notificationv(int, bool) + 76
27  org.godotengine.godot         	0x0000000105acb716 Object::notification(int, bool) + 22
28  org.godotengine.godot         	0x0000000104e8f3c9 SceneTree::_notify_group_pause(StringName const&, int) + 473
29  org.godotengine.godot         	0x0000000104e8f88a SceneTree::idle(float) + 394
30  org.godotengine.godot         	0x0000000103ea97ba Main::iteration() + 874
31  org.godotengine.godot         	0x0000000103e85661 OS_OSX::run() + 353
32  org.godotengine.godot         	0x0000000103e87d7c main + 556
33  libdyld.dylib                 	0x00007fff63b60115 start + 1
Link to minimal example project:

CC @neikeq

FWIW I had to rename the file in question and rename the class itself to get the game to build again.

For others coming here in the future, the solution for me was to go into the <ExportName>.app/MacOS and run the executable there. It should show any errors that it encounters. For me I had forgotten to set a main scene.

Not defining a main scene prevents the game from starting, but does not generate a crash, so it's a different topic.


arch: arm: Fix SoC issues with Atmel SAM4S series.

Signed-off-by: Justin Watson<EMAIL_ADDRESS>

@mnkp take a look at this.

Doesn't compile for me. Did you run it with CONFIG_SOC_ATMEL_SAM4S_EXT_MAINCK=y ?
One of several errors:
arch/arm/soc/atmel_sam/sam4s/soc.c: In function 'clock_init':
arch/arm/soc/atmel_sam/sam4s/soc.c:69:6: error: 'CKGR_MOR_MOSCRCF_4MHz' undeclared (first use in this function)

One more thing. According to Zephyr's Coding Style guidelines "Add braces to every if and else body, even for single-line code blocks." This does not mention explicitly while statements but typically they are govern by the same policy. I.e. we should turn all while(); into while() { ; }. @galak could you comment on this?

Doing a search with ag "while.*\n\s*\;" shows that it is written both ways. The more common way being without the braces.

There are still compile errors when CONFIG_SOC_ATMEL_SAM4S_EXT_SLCK config option is enabled.

The while { } is probably preferred


Class label mismatch issue (the 127 classes)

Describe the phenomenon

VISTA codebase and the paper says that VISTA3D supports 127 classes;

In the infer.py of VISTA codebase, the EVERYTHING_PROMPT has a total of 118 classes.
In the label_dict.json file of VISTA codebase defines 132 classes.

In the labels.json of the MONAI wrapper of VISTA3D defines 135 classes.

Questions

Why are 15 classes ignored in infer.py of VISTA codebase?
Which label-to-class list is right if I want to infer all 127 classes of a CT scan? Or which codespace should I use? (VISTA codebase / MONAI wrapper)

Thank you!

Possible Solution
Maybe the right way is to:

use the VISTA codebase
modify the IGNORE_PROMPT in infer.py to only ignore the 5 deprecated classes.

So that we will have 132 (defined in the label_dict.json) - 5 = 127 classes, is that right?

Hi:
Thanks for pointing out and sorry for the confusion. I will update the readme.
Initially we included all 132 classes for training then we found there are some conflicts between classes and the training data for some class is insufficient so we removed part of training sets. Those 5 are not supported.
"16,  # prostate or uterus" since we already have "prostate" class,
"18,  # rectum", insufficient data or dataset excluded.
"130,  # liver tumor" already have hepatic tumor.
"129, # kidney mass" insufficient data or dataset excluded.
"131,  # vertebrae L6", insufficient data or dataset excluded..

So we say VISTA3D support 132-5 = 127 classes.
In the model-zoo labels.json, ignore that 135 classes since we included some additional data for testing purposes. We will remove those.
For everything-prompt, we removed lesions and vessels that will have overlap with other organs. https://github.com/Project-MONAI/VISTA/blob/aeff47e699be436715894fccc0f54444134607a0/vista3d/scripts/infer.py#L37C1-L55C12. Those are the removed prompts.  The reason we remove tumors and vessels because they overlap with larger organs and make the output noisy (airway overlaps with trache). The same reason for "lung" "bone" "kidney" since we already have 5 lung lobes, 20+ bone-substructure and "left" "right" kidney. DO NOT USE "lung" "bone" "kidney" prompts, use their substructures (e.g. use "left kidney" + "right kidney" for "kidney" segmentation.
I won't suggest segment 127 classes directly since they have overlaps and the results will be overwritten by overlaped classes. So

Do 117 (exclude background) class everything segmention, through the model-zoo. So they don't have overlap
Do 3 class "bone", "lung", "kidney" through model-zoo. https://github.com/Project-MONAI/model-zoo/blob/6bdfd30b63b3d1a799c80f1d17a783ff3a66c66c/models/vista3d/configs/inference.json#L23.  This code actually convert "lung" prompt into 5 lung lobes, "kidney" into "left" and "right" and "bone" into sub-bones.
Do 7 "lung, pancreas, hepatic, colon, bone" tumor and "hepatic vessel" and "airway" joinly or separatly.

This cumbersome solution is just trying to mitigate the overlapping class issue. A better solution might just output 127 separate binary masks. I will update readme asap and thanks for pointing them out.
Thanks,
Yufan.

Thanks for your patient response! This is really helpful to my project.

Hi @heyufan1995 ,
Thanks again for your response. However, I have another issue.
In your answer, you suggest "ii. Do 3 class "bone", "lung", "kidney" through model-zoo." It turns out that if I use label_prompt=[2, 20, 21], the segmentation results will only contains their subclass counterparts (eg. segmentation results using label prompt 2 will only have class 5 and 14) because of the subclass setting. I can understand this part.

But if I just trying to get label 2 output with label prompt and simply changed the subclass setting to "subclass": {'2': 2, '20': 20, '21': 21}, the results seems to collapse.

So I'm wondering if this phenomenon is normal, or I have something missing here. Hope to have your response.
Thanks!
Tianyu

Understood! Thanks for your detailed explanation!


Map of Science

One of the goals of OSSci is to create a Map of Science with OSS.
That is, map all of OSS used by scientists to their disciplines.
This requires a Map of Science itself, using proper ontologies accepted in each area of science.
Then there're questions of finding all the OSS:

top-down from papers
top-down from curated lists and communities
bottom-up with ML classifiers

Let's discuss all of this and more!

Is it just me or this sounds similar to the package listing that Scientific Python wanted to do, @jarrodmillman ?

Merged with #14 given they both can happen in same session and would have similar participants. Thanks for your understanding!


Support "forced" theme.

For now, bandeau darkify works with the preferred theme media query, which imply that it only work if citizen is on auto-mode, if one theme is choosed via citizen, the script won't know about it.

fix by f1c1b3d473ac12019df8ab28d34146604177cc47


DataFrame.__getitem__(self, key: Sequence[Column]) stub definition

I believe that there are two issues with the overload DataFrame.__getitem__(self, key: Sequence[Column]). However, I don't really know the intention behind this hint (specifically what Sequence[Column] is supposed to be) - so I hope some light could be shed on this stub. My interpretation is that the intended meaning of Sequence[Column] is something like typing.List[Column] and not typing.Tuple[Column], and the following issues are based on this interpretation.

1. Return type hint
https://github.com/VirtusLab/pandas-stubs/blob/9751bff3b1716f0731d91313c059bdcf95244cd5/third_party/3/pandas/core/frame.pyi#L78-L79
https://github.com/VirtusLab/pandas-stubs/blob/9751bff3b1716f0731d91313c059bdcf95244cd5/third_party/3/pandas/_typing.pyi#L104
It looks like the return hint should be DataFrame, not Series. E.g.
>>> import pandas as pd
>>> df = pd.DataFrame({"A": [1, 2, 3], "B": [4, 5, 6], 8: [7, 8, 9]})
>>> df
   A  B  8
0  1  4  7
1  2  5  8
2  3  6  9
>>> df[["A", 8]]
   A  8
0  1  7
1  2  8
2  3  9
>>> df[["A", 8]].__class__
<class 'pandas.core.frame.DataFrame'>
>>> df["A"].__class__
<class 'pandas.core.series.Series'>
>>> df[["A"]].__class__
<class 'pandas.core.frame.DataFrame'>

2. Type hint of key
Sequence is from the base typing module,
https://github.com/VirtusLab/pandas-stubs/blob/9751bff3b1716f0731d91313c059bdcf95244cd5/third_party/3/pandas/core/frame.pyi#L20-L21
and according to https://docs.python.org/3/glossary.html#term-sequence

sequence
An iterable which supports efficient element access using integer indices via the __getitem__() special method and defines a __len__() method that returns the length of the sequence. Some built-in sequence types are list, str, tuple, and bytes.

Since typing.Sequence covers tuple objects, the stub conflicts with the following behaviour:
>>> import pandas as pd
>>> df = pd.DataFrame({"A": [1, 2, 3], "B": [4, 5, 6], 8: [7, 8, 9]})
>>>
>>> df[("A", 8)]
Traceback (most recent call last):
  File "~/[venv]/lib/python3.8/site-packages/pandas/core/indexes/base.py", line 2646, in get_loc
    return self._engine.get_loc(key)
  File "pandas/_libs/index.pyx", line 111, in pandas._libs.index.IndexEngine.get_loc
  File "pandas/_libs/index.pyx", line 138, in pandas._libs.index.IndexEngine.get_loc
  File "pandas/_libs/hashtable_class_helper.pxi", line 1619, in pandas._libs.hashtable.PyObjectHashTable.get_item
  File "pandas/_libs/hashtable_class_helper.pxi", line 1627, in pandas._libs.hashtable.PyObjectHashTable.get_item
KeyError: ('A', 8)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "~/[venv]/lib/python3.8/site-packages/pandas/core/frame.py", line 2800, in __getitem__
    indexer = self.columns.get_loc(key)
  File "~/[venv]/lib/python3.8/site-packages/pandas/core/indexes/base.py", line 2648, in get_loc
    return self._engine.get_loc(self._maybe_cast_indexer(key))
  File "pandas/_libs/index.pyx", line 111, in pandas._libs.index.IndexEngine.get_loc
  File "pandas/_libs/index.pyx", line 138, in pandas._libs.index.IndexEngine.get_loc
  File "pandas/_libs/hashtable_class_helper.pxi", line 1619, in pandas._libs.hashtable.PyObjectHashTable.get_item
  File "pandas/_libs/hashtable_class_helper.pxi", line 1627, in pandas._libs.hashtable.PyObjectHashTable.get_item
KeyError: ('A', 8)

tuple objects get treated as the same as Column objects in the following overload:
https://github.com/VirtusLab/pandas-stubs/blob/9751bff3b1716f0731d91313c059bdcf95244cd5/third_party/3/pandas/core/frame.pyi#L76-L77
E.g.
>>> df = pd.DataFrame({"A": [1, 2, 3], "B": [4, 5, 6], ("C", int, (99,)): [7, 8, 9]})
>>> df
   A  B  (C, <class 'int'>, (99,))
0  1  4                          7
1  2  5                          8
2  3  6                          9
>>> df[("C", int, (99,))]
0    7
1    8
2    9
Name: (C, <class 'int'>, (99,)), dtype: int64
>>> df[("C", int, (99,))].__class__
<class 'pandas.core.series.Series'>
>>> df[("C", int, (99,))].to_frame()
              C
  <class 'int'>
          (99,)
0             7
1             8
2             9

Thanks for finding this. I was able to work out some better types that match real use. I've also added tests. Please review:
https://github.com/VirtusLab/pandas-stubs/pull/24
There's still an slight issue when I run mypy locally. I've tried this declaration:
    @overload
    def __getitem__(self, key: Column) -> Series: ...
    @overload
    def __getitem__(self, key: Union[Series, Index, DataFrame, List[Column], slice, np.ndarray]) -> DataFrame: ...

however then I get this error from mypy:
third_party/3/pandas/core/frame.pyi:77: error: Overloaded function signatures 1 and 2 overlap with incompatible return types

it says that Column (Union[int,str]) overlaps np.ndarray which is absolutely ludicrous.
I'm looking into possible reasons but for now it looks like a mypy bug. I'm able to replicate this in other classes:
from typing import overload
import numpy as np

class A:
    @overload
    def a(self, key: int) -> int: ...
    @overload
    def a(self, key: np.ndarray) -> str: ...

reports the same issue.
I worked around this with #type: ignore, and this works well for disabling a local check for this, but it still looks like a bug to me.


[wanted]Looking for collaborators

now, Due to studying for college entrance exams(Feb 2022),  I can not manage the repository.
I want to develop the repo to add new features after finishing the exam.
Please manage the repo while i am studying for this.
Could you manage the repo?
Are there someone to manage it?

I've never contributed, can I become an collaborator?
This is the level of Flutter.
https://github.com/tokku5552/TODOAppSample-Flutter
I will contact you in Japanese via Twitter DM.

Thank you.
I will add you to collaborators🎉🎉

If possible I also would like to contribute once in a while. Due to work I don't have a lot of spare time, but I can contribute once in a while.

@anharu2394  I want to collaborate, I am currently using your library to create a feature in my application. could you add me

@Jartz , Thank you, welcome.

@anharu2394  thank you, i'm working in allow to add multiple same type And merge sound. soon I'll be uploading PR

@Jartz I recommend creating the issue about the feature you're developing to you.

Hey @anharu2394, I would love collaborate with your project. Could you add me?

@fernandocruz sure

i want to style the overlay text, is it already available?
i am planning to develop this feature - it will be better, if you add me as collaborator.

@Baneeishaque sure


feat: Repo license check

Description
This PR updates the dependencies in the Cargo.lock file. It removes the actix-tls package and updates the versions of actix-utils, rustls, tokio-rustls, and tokio packages. The changes in the Cargo.toml file include removing the feature flag for rustls in the actix-web package. Additionally, this PR introduces a new function is_indexing_allowed in the github/mod.rs file to check if indexing is allowed based on the repository's license. The function is used in the embeddings route in the routes/mod.rs file to validate the repository's license before processing the request. The PR also includes tests for the new function.
Generated using OpenSauced.
What type of PR is this? (check all applicable)

[x] 🍕 Feature
[ ] 🐛 Bug Fix
[x] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[x] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents
Resolves #7.
Mobile & Desktop Screenshots/Recordings
Added tests?

[x] 👍 yes
[ ] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

Could we decorate this error alittle bit? Maybe something like
Error: Impermissible repository license for
https://api.github.com/repos/grafana/grafana/license
Found: AGPL-3.0 license

just so the user has abit more info one what's going on?

New 403 response:
{
   "license":{
      "name":"GNU Affero General Public License v3.0",
      "url":"https://github.com/grafana/grafana/blob/main/LICENSE"
   },
   "message":"Impermissible repository license"
}


Need help for beacon simulation

Hello to all
For my thesis work, I need to run Beacon on a some lab network nodes (as clients) in my university (by defining the desired delay on each node), and of course apply some changes on it. I also need to have network view.
Can anyone guide me on choosing the appropriate code to install on client' nodes and how to have a network view on the activity of these clients?
Regard

Hey @zsharifian I would encourage you to join the Ethereum R&D discord for this types of questions, please follow this link https://discord.com/invite/qGpsxSA or see Danny's twit if you need legitimacy https://twitter.com/dannyryan/status/1506635912163307527?s=20&t=Utye4iS9xPOQy7Bd6d3XWg
I'm sure you'll get a lot of help there :+1:

Hey @zsharifian I would encourage you to join the Ethereum R&D discord for this types of questions, please follow this link https://discord.com/invite/qGpsxSA or see Danny's twit if you need legitimacy https://twitter.com/dannyryan/status/1506635912163307527
I'm sure you'll get a lot of help there 👍

Thanks so much


fix showModalError function missing in KeyDisplayScreen.js

This screen is going to be removed in the latest release


App Connector Module - [Optional task] Ensure that Runtime Agent is enabled even if Istio is missing

This functionality should be implemented if we decide to enable the module with using old reconciler.
That means that Compass Manager was not ready on control plane to create Compass Connection token for enabled module at the checkpoint time.
In such a case we want to install only the Operator that will install all services for the module to avoid dependency to Istio module.
When Istio is missing - we cannot install Application Connector module but at the same time we must ensure that Runtime Agent service is enabled to used one time token before it expires.
We should make sure that operator is able to detect missing Istio install only Runtime Agent service from the module.

Closing this as we solved this problem in different way.
The first released version of the module will not contain Runtime Agent.
It wii be added later, when all required KCP infrastructure is ready (Compass Manager).


add optional tag and omitempty to autoscaling field

This change makes autoscaling an optional field for hostedcluster
resources. Also updates docs and generated files.

/approve
/lgtm


feat(conductor, composer, sequencer, relayer): setup basics for metrics

Summary
Adds the setup for metrics into core telemetry init, adds config for it to all our standard services.
Background
Metrics are currently only available through cometbft or rollup nodes, we want to have metrics in our configuration
Changes

Updates all service configs
Updates telemetry to enable initializing prometheus metrics
Adds a couple of metrics for sequencer-relayer

Breaking Changelist

new configuration fields

Related Issues
Link any issues that are related, prefer full github links.
closes

replaced w/ https://github.com/astriaorg/astria/pull/739


UserStory Implementation

1. Login: Implemented LoginInputBoundary, LoginInputData, LoginInteractor, LoginOutputBoundary, LoginOutputData, and LoginUserData.
2. view_event: Added ViewEventInputBoundary, ViewEventInputData, ViewEventInteractor, ViewEventOutputBoundary, ViewEventOutputData, and ViewEventUserDataAccessInterface.
3. filter_event: Added FilterEventInputBoundary, FilterEventInputData, FilterEventInteractor, FilterEventOutputBoundary, FilterEventOutputData, and FilterEventUserDataAccessInterface.
4. rsvp_event: Added RSVPEventInputBoundary, RSVPEventInputData, RSVPEventInteractor, RSVPEventOutputBoundary, RSVPEventOutputData, and RSVPEventUserDataAccessInterface. Implemented RSVP event functionality such as finding users/events and adding users to event attendee lists.
5. notify_user: Added NotificationInputBoundary, NotificationInputData, NotificationInteractor, NotificationOutputBoundary, NotificationOutputData, and NotificationUserDataAccessInterface. Partially integrated FirebaseService to send email notifications for upcoming events.
6. modify_event: Added ModifyEventInputBoundary, ModifyEventInputData, ModifyEventInteractor, ModifyEventOutputBoundary, ModifyEventOutputData, and ModifyEventUserDataAccessInterface. Added setter methods (setTitle, setDescription, setDateTime, setCapacity, setLatitude, setLongitude) to CommonEvent.class to support modifying event attributes. Updated the Event interface to include corresponding setter methods.
TODOs:

After integrating google maps api

Verify findEvents methods in ViewEventUserDataAccessInterface and FilterEventUserDataAccessInterface after integrating Google Maps API and completing the database setup.
Check the event location modifications in the modify_event use case to make sure it works with Google Maps integration.

After setting up the db:

Verify RSVPEventUserDataAccessInterface and findEvents methods

Service Layer Implementation needed bc of notify_user and modify_event:

Firebase Email Notification service.
Update project configuration in the NotificationInteractor to make sure the functionalities.
Implement ModifyEventUserDataAccessInterface with database interactions in the service layer.
Implement the findEvent method in the service layer to make sure modify_event and other use cases correctly get events.

This implementation showcases a strong adherence to clean architecture principles, with a well-structured separation of concerns through the use of input/output boundaries and data access interfaces for each use case. The addition of setter methods in CommonEvent.class and corresponding updates to the Event interface enhance flexibility and maintainability, allowing event attributes to be modified efficiently. The partial integration of FirebaseService for notifications is a good start toward improving user engagement, while the clear TODOs outline the remaining tasks, including Google Maps API and database integration, to ensure the system's full functionality. However, attention should be given to the service layer's implementation, particularly for notify_user and modify_event, as these are critical for ensuring the system's overall coherence and reliability. This plan reflects thoughtful design and a methodical approach, setting a solid foundation for completing the project.


Add Blast (under review)

Resolves L2B-3106
To review: https://l2beat-staging-git-add-blast-under-review-l2beat.vercel.app/scaling/projects/blast

Blast should be removed from the main page - it can be added to upcoming rollups section. There is nothing to review, they have not launched yet


Fix the problem of transformer component in Streamis

What is the purpose of the change
Fix the problem of transformer component, which cause the failure in deploying dependent jar to yarn.
Related issues: #56.
Brief change log

Adjust the parameter defined in transformer

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
Anything that affects deployment: no
The Core framework, i.e., JobManager, Server.: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? not documented

LGTM!


BHBC-1775, BHBC-1809: Templates in prod are still downloaded from S3 Dev

Overview
Currently, templates in the test/production environment are still downloaded from S3 Dev. These templates should be retrieved from the production instance.
Links to Jira tickets
https://quartech.atlassian.net/browse/BHBC-1775
https://quartech.atlassian.net/browse/BHBC-1809
Description of relevant changes

Add s3 public hsot URL to frontend env vars; Replace hardcoded URLs.
API response validation bug fixes

@curtisupshall your appdeploy pod is failing.  I think you can fix it by dropping the pods, and then retriggering a build with an empty commit.

There is a funny issue happening when you click the links in openshift.  Because the env vars don't include https:// react is actually opening the urls relative to the app url.
I'm thinking the simplest solution for now is to just wrap those URLs in the resource page with that ensureProtocol function.


Pass model to netron.app as base64 encoded parameter?

Would be a great option to open local models in the browser version.
Opening models by url seems to work with: https://netron.app/?url=<...>
Is there are way to pass models directly as parameters, e.g. as base64 encoded strings?

URLs have a size limit. Multiple formats can not be detected from content so a file extension needs to get passed. There isn't a straightforward way to create the URL. All this would likely lead to errors. Can the same be accomplished by using the gist parameter? For example, https://netron.app?gist=e65799e70358c6782b1b


[JENKINS-26275] Fixed

Show snapshot instead of link when attachment is image
Small feature but interresting one if you have image that can be understood even if not in full size.
With this, no need to click one more time, you have all you need at first glance.

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Hello,
More than 3 years later, I'm not using this plugin anymore, It will take me
too much time to understand/rebuilt/test those stuff.
just cancel this pr.
2018-02-16 15:10 GMT+01:00 Jesse Glick<EMAIL_ADDRESS>
@jglick approved this pull request.
Sounds right though will be a merge conflict with #16
https://github.com/jenkinsci/junit-attachments-plugin/pull/16.
In src/main/resources/hudson/plugins/junitattachments/
AttachmentTestAction/summary.jelly
https://github.com/jenkinsci/junit-attachments-plugin/pull/12#discussion_r168764945
:

@@ -10,9 +10,14 @@
<j:forEach var="attachment" items="${it.attachments}">

				${attachment}

				<j:if test="${it.isImageFile(attachment)}">

				</j:if>

				<j:if test="${!it.isImageFile(attachment)}">

j:choose / j:when / j:otherwise easier BTW
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jenkinsci/junit-attachments-plugin/pull/12#pullrequestreview-97188232,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIZpSDYQWw3YSdwPeWwhsZEFcTPVY5PUks5tVYxsgaJpZM4DOBgU
.

We can leave it open and if someone cares for this feature, they would merely need to create a follow-on PR merging your commit with master.

I think this is worth keeping open in the book of work for this plugin, @jglick
I can always take over.


Fiori Elements exercise error with SAPUI5 Flexibility Service / Layered Repository

Describe the bug
The fiori elements page after generation did not load successfully as it's missing a component in the new version of fiori elements generator
To Reproduce
Steps to reproduce the behavior:

Go to Open Application Generator and Generate a Fiori Elements List Report page (User Interface and Business Logic -> Generating User Interface -> Step 1
Run cds watch
Click on Web Applications -> /risks/webapp/index.html

Expected behavior
Page will load successfully
Actual behavior
Page did not load as two services failed
/sap/bc/lrep/flex/settings
Cannot GET /sap/bc/lrep/flex/settings
sap/bc/lrep/flex/data/risks?sap-language=EN
Cannot GET /sap/bc/lrep/flex/data/risks
Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS] MacOSX
Browser [e.g. chrome, safari] Chrome
Version [e.g. 22]

Additional context
Add any other context about the problem here.

It was resolved by installing lrep-flex with the steps in the URL and adding data-sap-ui-flexibilityServices='[{"connector": "LocalStorageConnector"}]' after a few tries

Hi,
kindly add your inquiry to our dedicated Learning Community Group. We do not provide support for the exercises on GitHub.
Best Regards,
Markus


Verify proxy contracts on zos verify

Currently only logic contracts are verified. We should verify the proxy themselves as well.

Pretty sure that was request a couple times already.

Until oz verify automagically support verifying proxy contracts, how can we verify proxy contracts manually on Etherscan?
What compiler version, EVM version, optimizer settings are used?
https://github.com/OpenZeppelin/openzeppelin-sdk/issues/1183#issuecomment-524984084

Process to verify the proxy contract
https://forum.openzeppelin.com/t/verify-proxy-contract/1989

does this is valid from AdminUpgradeabilityProxy which are deployed from other contracts ? e.g via app.sol https://github.com/OpenZeppelin/openzeppelin-sdk/blob/master/packages/lib/contracts/application/App.sol#L117  @abcoathup @spalladino

@orenyodfat unfortunately no, the CLI only tracks contracts deployed from the CLI itself.


This is niubi， what is this for？

Can you add a Readme ？

Indeed, this looks dope.

Updated readme.
If you guys have any more question, feel free to ask!


Initiate seamail from profile

add a link on the profile view to start a private message
reported by @tratcher

done


Screen sharing in Video Chat stucks at loading

Hi. While trying to share a screen via Video Chat the loading circle keeps moving but nothing happens

Jitsi server is fully functioning (screen sharing also) on both browsers (Chrome and Firefox).
Video and audio are great and the only thing that doesn't work is sharing a screen.
Server Setup Information:

Version of Rocket.Chat Server: 0.59.4
Operating System: Ubuntu 16.04 x64
Deployment Method: snap
Number of Running Instances: 1
Node Version: v4.8.4

Are there any news on this issue? Desktop sharing was working perfectly until the last Jitsi Meet update. Now we do see the same symptoms as described by OP. Anything that can be done within the configuration files to fix this?

I am experiencing this with client 2.17.1
Monitor 1 Dell P2715Q 3840x2160
Monitor 2 Dell U2311H 1920x1080
Win10 Pro 1909

This has been an issue since forever. This is probably not a priority for them to fix it seems or it is something that cannot be fixed.

You could use the chrome to share your screen and it is working for me.
Note: you need to add the rocket extension to your chrome.
https://chrome.google.com/webstore/detail/rocketchat-screen-share/nocfbnnmjnndkbipkabodnheejiegccf

True but it beats the entire purpose of making Electron-based apps for Desktops

2.17.7 seems to work again for me

I am on 2.17.9 and can confirm Screen Sharing does not work on macOS Catalina

I just fought with this for a while ... the solution (work-around) I settled on was to set "Always Open in New Window" to on.  That enabled it to work across all platforms I have access to (Chrome and native apps on Windows 10 and CentOS 7).  That also solved a problem where the small window that opened up to the side was too small, but making it full screen locked up the desktop.
Client v 2.17.7
Server v 3.2.2

Please test if the latest release did solve this. If not please reopen the issue or create a new one and tell us. I will be closing this one for now.
Thank you!


Agent placement on multi-level navigation mesh

There is no facility for placing agents on arbitrary levels of a navigation mesh.  For example, if a two-story building were modeled with a navigation mesh, placement onto the mesh at position (x,y) would project the point down from an infinite height and stop at the first polygon encountered.  Thus, if two polygons project to the same (x, y) point, an agent will only be initialized on the upper polygon.

We need to have an "explicit navigation mesh" agent generator.
Navigation meshes support named regions.  In this case, if the explicit navigation mesh generator takes as arguments: a navigation mesh and a region name, the x-y position can be interpreted directly as that region name as a target.
There has to be a well-defined behavior if the x-y position does not project onto the named region either:

Simply throw an error and put the burden on the user to get it right
Try to project it to any point on the nav mesh.  Warning if successful, error if not.

Solved by PR #9


Enable HIFLD grid model to instantiate Grid objects

:rocket:

[x] Is your feature request essential for your project?

Describe the workflow you want to enable
I wish I could instantiate a Grid object with grid_model="hifld".
Describe your proposed implementation
We need to:

Create a module powersimdata.network.hifld.
Define a class HIFLD within powersimdata.network.hifld.model
Create files powersimdata.network.hifld.constants.plants, powersimdata.network.hifld.constants.storage, powersimdata.network.hifld.constants.zones
Update powersimdata.network.model._check_model to allow hifld as a possible grid model.
Import the HIFLD class into powersimdata.input.grid and instantiate these objects as necessary.
More?

Additional context
There's a rough implementation currently in the daniel/read_hifld_grid branch, that worked when it was written but has not been tested lately, so may have broken since then.

Closed via #566


Handle interface / default route changes gracefully

In the macOS client, changing my Internet connection from WiFi to Ethernet (and back again) causes an established peer connection to gateway to fail and not recover.
Attached are the logs while performing this Internet route change a couple times.
It's filed as a bug because the portal connection succesfully reconnects, but the app ends up in a broken state because there is no way for the user to know connlib's data plane is having issues.
log.txt

I think what might be happening is that the connection to the Relay drops, and then connlib tries to resume using the old Relay auth state when in fact it needs to rebind there too?


Updated Expon and depracated calls.

Also, jest tests are broken completely.
Looks like some magic with dependencies/configuration needed.
at least tests HDWallet.test.js and  App.test.js should pass
(LightningCustodianWallet.test.js is broken because backend is broken atm)

Very well done


build: fix ios build error. miss '!TARGET_OS_IPHONE'.

Signed-off-by: MaYuming<EMAIL_ADDRESS>

Thanks, LGTM! CI: https://ci.nodejs.org/job/libuv-test-commit/1554/
You show up as "YumingMa" in the patch's Author field, same as your github handle. Is that correct?

No problem！

Landed in 5ba93ede, thanks! There was a process_title_threadsafe test failure on the CI but I checked and it very much looks like a flake. I couldn't reproduce it at any rate.


Inserts for to_iceberg on existing tables will fail when schema evolves, depending on Pandas DataFrame column order

Describe the bug
When calling to_iceberg for an existing table with a Pandas dataframe that has a new column (or has columns re-ordered), and using parameters:

mode=overwrite_partition | append
schema_evolution=True
merge_cols = None

The write can fail if the order of the columns in the dataframe has changed, or if the new column being added is not the last column in the dataframe.
Currently, when no merge columns are specified, and data is being inserted into an existing table with overwrite_partition or append, the code doesn't label columns in the INSERT INTO command and assumes the order in the dataframe will match that of the iceberg table:
https://github.com/aws/aws-sdk-pandas/blame/main/awswrangler/athena/_write_iceberg.py#L495-L499
This logic is fragile and frequently breaks, especially when a new column is added to a dataframe with the intent to evolve the schema. The column names to insert into on the destination table should be explicitly provided. Potentially this fix is as simple as the following, but I haven't yet tested:
            sql_statement = f"""
---            INSERT INTO "{database}"."{table}"
+++            INSERT INTO "{database}"."{table}" ({', '.join([f'"{x}"' for x in df.columns])})
            SELECT {', '.join([f'"{x}"' for x in df.columns])}
              FROM "{database}"."{temp_table}"
            """

How to Reproduce
# Example DataFrame creation
base_dataset = {
    'partition': [1, 1, 2, 2],
    'column1': ['X', 'Y', 'Z', 'Z'],
    'column2': ['A', 'B', 'C', 'D'],
}

dataset_new_col_last = {
    'partition': [2, 2],
    'column1': ['Z', 'Z'],
    'column2': ['C', 'D'],
    'new_column': [True, False],
}

dataset_new_col_not_last = {
    'partition': [2, 2],
    'column1': ['Z', 'Z'],
    'new_column': [True, False],
    'column2': ['C', 'D'],
}

# Create DataFrame
base_df = pd.DataFrame(base_dataset)
new_col_last_df = pd.DataFrame(dataset_new_col_last)
new_col_not_last_df = pd.DataFrame(dataset_new_col_not_last)

print(f"Base dataset column order:              {base_df.columns}")
print(f"New dataset new column last order:      {new_col_last_df.columns}")
print(f"New dataset new column NOT last order:  {new_col_not_last_df.columns}")

write_args = {
    "partition_cols": ["partition"],
    "mode": "overwrite_partitions",
    "database": "data_warehouse",
    "table": "bug_demo",
    "table_location": deps_container.config.data_warehouse_s3_path(),
    "temp_path": deps_container.config.data_warehouse_s3_path() + '_tmp',
    "boto3_session": boto3_session,
    "schema_evolution": True,
    "keep_files": False,
}

# Write base dataframe
wr.athena.to_iceberg(**{**write_args, "df": base_df})

# SUCCEEDS: Write a dataframe with a new column in the last position
wr.athena.to_iceberg(**{**write_args, "df": new_col_last_df})

# Re-Write base dataframe to start
wr.athena.to_iceberg(**{**write_args, "df": base_df, "mode": "overwrite"})

# FAILS: Write a dataframe with a new column NOT in the last position
wr.athena.to_iceberg(**{**write_args, "df": new_col_not_last_df})

# QueryFailed: TYPE_MISMATCH: Insert query has mismatched column types:
# Table: [bigint, varchar, varchar, boolean],
# Query: [bigint, varchar, boolean, varchar].

Expected behavior
The insert statement should gracefully handle different column orderings in the pandas dataframe when inserting into the destination table
Your project
No response
Screenshots
No response
OS
mac
Python version
3.11
AWS SDK for pandas version
3.7.2
Additional context
No response

Thanks for the detailed explanation, should be fixed with #2768


Failed to listen to incoming slave connection

Running the latest tag on CentOS 7 & Docker 0.11.1, Jenkins fails to bind the port:
Failed to listen to incoming slave connection

java.net.BindException: Failed to listen on port 50000 because it's already in use.
    at hudson.TcpSlaveAgentListener.<init>(TcpSlaveAgentListener.java:75)
    at jenkins.model.Jenkins.<init>(Jenkins.java:825)
    at hudson.model.Hudson.<init>(Hudson.java:82)
    at hudson.model.Hudson.<init>(Hudson.java:78)
    at hudson.WebAppMain$3.run(WebAppMain.java:222)
Caused by: java.net.BindException: Address already in use
    at sun.nio.ch.Net.bind0(Native Method)
    at sun.nio.ch.Net.bind(Net.java:444)
    at sun.nio.ch.Net.bind(Net.java:436)
    at sun.nio.ch.ServerSocketChannelImpl.bind(ServerSocketChannelImpl.java:214)
    at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:74)
    at sun.nio.ch.ServerSocketAdaptor.bind(ServerSocketAdaptor.java:67)
    at hudson.TcpSlaveAgentListener.<init>(TcpSlaveAgentListener.java:73)
    ... 4 more

The port isn't used on the host.

I still hit that problem.
wasn't it fixed?
thanks

Yes it should be using the init groovy. @ndeloof is the init.groovy still in use that sets the fixed slave port?

yes it is https://github.com/cloudbees/jenkins-ci.org-docker/blob/master/Dockerfile#L22

Still having this 'port 50000 already in use' problem in current LTS Jenkins release, running on Kubernetes.   Restarting the Jenkins container within the pod seems a valid workaround.  Prob still timing issues during startup.

I was having the same issue after restoring Jenkins backup to my Jenkins setup. It was deployed using Helm charts on a Kubernetes cluster.
Manage Jenkins > Configure Global Security > Agents
Disable the setting "TCP port for inbound agents" and Apply, then undo the radio to Fixed: 50000 option and save.
Worked for me.


Add hawkular admin tenant label to settings

Description
Compute -> Containers -> Providers -> Choose provider -> Monitoring -> Ad-hoc metrics
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1503541
https://github.com/ManageIQ/manageiq-ui-classic/pull/2497
Add hawkular admin tenant label to settings, which together with https://github.com/ManageIQ/manageiq-ui-classic/pull/2497 makes it look good in the UI.
Users of OpenShift can create custom tenants in the Hawkular database. The ad-hoc metrics page can handle some pre-defined names, but users can choose to define new ones. This PR adds an example of such setting, and the one in manageiq-ui-classic adds the code to support this kind of setting.
Before

After

Settings

@miq-bot add-label providers/containers, bug
@simon3z @yaacov please review


test only

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!

/test-osp-extended

/test-osp-extended

/test-osp-extended


Transitions and Textures

Hi there,
I'm trying to make a really good looking animation and I'm wondering if it's possible to use transitions with texture values/params.
Thank you!

Hi @rolandoamarillo
I'm not sure I understand your question. Can you be more specific?
Best regards

Hi @g-zachar
Thanks for the response.
Basically, I want to create a custom texture that contains an animation or transition. Is this possible? I have tried to animate a texture with a simple image by updating the size and position of the image inside the canvas (I'm calling the _changed() method after updating the params), the _getSourceLoader() method is called just once after completing the animation or transition and it gets updated but it doesn't do it smoothly.
I'm wondering if it's possible to add some animation or transition to a custom texture without a component.
Best Regards

Hi @rolandoamarillo
Can you explain exactly what you're trying to implement? I can't see the reason why you would want to  operate on texture level rather than component.
Best regards

Hi @g-zachar,
Yes, I'm trying to create a triangle with a canvas and draw an image inside that triangle. Also, I want to be able to resize, move with the animation/transition that image inside the triangle.
Best Regards

Closing issue. The best option here to implement what I need is a custom shader. Thanks for the help.


[WFLY-15023][WFCORE-5572] Add infrastructure to allow jakarta version expressions in module.xml files in WildFly Core feature packs

https://issues.redhat.com/browse/WFLY-15023
https://issues.redhat.com/browse/WFCORE-5572

This is missing bit on WildFly side @bstansberry  - please review.

This PR is related to https://github.com/wildfly/wildfly-core/pull/4732


allow ability to omit fields from being tracked in history

Pass a second argument to undoMiddleware that is an array of keys that are on your undo store state interface that will not be tracked in history.
there are some todo's there because I couldn't get the types to work perfectly.
usage:
const useStore = create<StoreState>(
  undoMiddleware(
    set => ({ ... }),
    ['field1', 'field2']
  )
);

Closes #8

Perhaps rather than an array of values for the second argument, it's an object and one of the fields is {omit: ['field']}.
I'll go ahead and change it to an object.


SoundCloud:set 401 error

>python C:\youtube-dl.py -F https://soundcloud.com/runthetrap/sets/100k-plays-and-above --verbose
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-F', u'https://soundcloud.com/runthetrap/sets/100k
-plays-and-above', u'--verbose']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2015.09.22
[debug] Python version 2.7.10 - Windows-7-6.1.7601-SP1
[debug] exe versions: none
[debug] Proxy map: {}
[soundcloud:set] runthetrap/sets/100k-plays-and-above: Resolving id
[soundcloud:set] runthetrap/sets/100k-plays-and-above: Downloading JSON metadata

ERROR: Unable to download JSON metadata: HTTP Error 401: Unauthorized (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
  File "C:\youtube-dl.py\youtube_dl\extractor\common.py", line 326, in _request_
webpage
    return self._downloader.urlopen(url_or_request)
  File "C:\youtube-dl.py\youtube_dl\YoutubeDL.py", line 1865, in urlopen
    return self._opener.open(req, timeout=self._socket_timeout)
  File "C:\Python27\lib\urllib2.py", line 437, in open
    response = meth(req, response)
  File "C:\Python27\lib\urllib2.py", line 550, in http_response
    'http', request, response, code, msg, hdrs)
  File "C:\Python27\lib\urllib2.py", line 475, in error
    return self._call_chain(*args)
  File "C:\Python27\lib\urllib2.py", line 409, in _call_chain
    result = func(*args)
  File "C:\Python27\lib\urllib2.py", line 558, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)

Duplicate of #6930.
This is already fixed in master and will be incorporated in the next version of youtube-dl.


Upgrade to Latest Zig

Hi, thank you for writing this library! I noticed that it hadn't been updated to some of the latest zig changes, so I took a few minutes to get it up to speed.

Thanks!


ISPN-13906 Disable Spring banner in tests

https://issues.redhat.com/browse/ISPN-13906
Other tests the banner is already disabled.

Merged, thanks


List of available commands so that we can create key binding for each

Hi,
For e.g. I want to create a key board shortcut, for creating a new branch, instead of having to type Cmd-Shift-H and then choose "New branch" option.
With shortcut, I can go straight to type the "new branch name". But I cannot find the corresponding command of git-plus.
Thanks.

All the commands are accessible for keybindings by dasherizing the command title.
For example:

Git Add ==  git-plus:add
Git Add All Commit And Push == git-plus:add-all-commit-and-push

and for Checkout New Branch it would be git-plus:checkout-new-branch.
I'll add this info to the readme

Thanks. That is very helpful.


In header of main page there is a link for Contribution guideline page.... Make that link more eye-catching.

I'd like to work on this.

Go ahead @Maxime-p

What do you think ? Do it need to be more eye-catching ?

Hey @Maxime-p
It's looking great to me.
Can you add these borders to the text with the current design?
Just add borders.

@Maxime-p @Dorcastunmise Add your profiles and make a PR.

Can you add these borders to the text with the current design?
Which text?

Do I let the arrows insted of the red dots ?

Yes, arrows look more eye-catchy


Added async Wifi implementation with stubs

The stubs just block on the sync variants of the functions, and return a 'ready' future. In a later iteration, the async functions that block can be replaced with proper futures. Also added an example of using the async Wifi.
Feedback and comments welcome!

See #243

@pilotniq If you are wondering what is happening... I started to realize that some of my feedback might be well above the complexity level for an external contributor. So what I did is to take your PR, and then apply on top all of the changes suggested here. As a result, we now have #243 .
#243 DOES type-check and build successfully, but I have not yet flashed the outcome on an actual ESP. If you feel adventurous, feel free to build your example and flash it. Who knows - it might work out of the box, or with only minimal changes. :)
Feedback & suggestions in the new PR always welcome, of course!


(feat) fixes #2557: makes ETH routes non Balancer specific

Fixes https://github.com/CoinAlpha/hummingbot/issues/2557
To make these functions non Balancer specific, this PR adds a spenderAddress parameter to /eth/approve and /eth/allowances, so the Balancer connector in the client needs to be changed to pass in the Balancer exchangeProxy address (mainnet: 0x3E66B66Fd1d0b02fDa6C811Da9E0547970DB2f21).
I think the Balancer exchangeProxy address should be a global parameter that we set to the current mainnet address. If users want to test on Kovan, they are responsible for changing it.

The ExchangeProxy (or Balancer contract address) is now stored at 2 locations, HB global config and Gateway .env.
I think we should keep it at just one location to avoid confusion.
Would it be better to create an approve endpoint in balancer which redirects to approve in eth and supplies it with spenderAddress? And HB client doesn't need to store the spender address.

OK, that makes sense. I'll make the change tmrw.

@Nullably I added approve and allowances endpoints to the Balancer routes.
I spent a lot of time trying to figure out a more elegant way using redirects or proxy requests to avoid duplicating the code, but failed to make it work.

@vic-en has an alternate method of calling approve and allowances that prevents code duplication in the Balancer routes  - he's adding to the Uniswap gateway, and will modify this PR too


Problem when launch gnu radio with the updated file synchronization.py

Terms

[X] Checked the existing issues and discussions to see if my issue had not already been reported;
[X] Read the best practice and checked if my bug was not one of the common bugs documented in the Wiki;
[X] Updated my Python virtual environment with rye sync;

Describe the issue
Hello,
I have an issue when I launch the file eval_limesdr_fpga.grc :
Traceback (most recent call last):
  File "/mnt/c/Users/lucas/Documents/LUCAS/MASTER_1/Projet/LELEC210X_Groupe_A/telecom/hands_on_measurements/gr-fsk/apps/eval_limesdr.py", line 337, in <module>
    main()
  File "/mnt/c/Users/lucas/Documents/LUCAS/MASTER_1/Projet/LELEC210X_Groupe_A/telecom/hands_on_measurements/gr-fsk/apps/eval_limesdr.py", line 315, in main
    tb = top_block_cls()
  File "/mnt/c/Users/lucas/Documents/LUCAS/MASTER_1/Projet/LELEC210X_Groupe_A/telecom/hands_on_measurements/gr-fsk/apps/eval_limesdr.py", line 155, in __init__
    self.fsk_synchronization_0 = fsk.synchronization(data_rate, fdev, samp_rate, hdr_len, packet_len, tx_power)
TypeError: __init__() missing 1 required positional argument: 'enable_log'
libusb: warning [libusb_exit] application left some devices open

>>> Done (return code 1)

I saw that in the synchronization.py, there is a new argument 'enable_log', I changed the file but I have this error.
Do you know what can I do ?
Thank you in advance,
Lucas Verheyen, groupe A
Command or program
launching gnu radio
Issue Type
Error when running an command
What is your platform?
Windows
Other platform
No response
Relevant error output
No response
Screenshots
No response
Additional information
No response
Recommended fix or suggestions
No response

Anyway, it looks like there is a mismatch between your class definition and the instantiation.
Maybe you need to recompile / reinstall the module? Because, according to the last commit https://github.com/LELEC210X/LELEC210X/commit/d8be515eb7198595f4a3094a7a0a34f4d2dd5b42#diff-62d4d8a7c7126a4c0d03233363c397ad8e65cca02143ca28a9b8b02d665193c3, @PolMaistriaux did include the new parameter in the function signature. The Python files in apps/ are automatically generated, so it is probably better to just re-generated them.
Let me know if that works.

It doesn't work. I have a problem with the board. When I plug the Nucleo into my computer, it blinks red, but when I connect it to another computer, it connects normally.

De : Jérome Eertmans @.>
Envoyé : vendredi 6 décembre 2024 18:04
À : LELEC210X/LELEC210X @.>
Cc : Lucas Verheyen @.>; Mention @.>
Objet : Re: [LELEC210X/LELEC210X] Problem when launch gnu radio with the updated file synchronization.py (Issue #52)
Vous n’obtenez pas souvent d’e-mail à partir de @.*** Pourquoi c’est importanthttps://aka.ms/LearnAboutSenderIdentification
Anyway, it looks like there is a mismatch between your class definition and the instantiation.
Maybe you need to recompile / reinstall the module? Because, according to the last commit d8be515https://github.com/LELEC210X/LELEC210X/commit/d8be515eb7198595f4a3094a7a0a34f4d2dd5b42, @PolMaistriauxhttps://github.com/PolMaistriaux did include the new parameter in the function signature. The Python files in apps/ are automatically generated, so it is probably better to just re-generated them.
Let me know if that works.
—
Reply to this email directly, view it on GitHubhttps://github.com/LELEC210X/LELEC210X/issues/52#issuecomment-2523752179, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6KY6JVVYDEYZBOG5WG4GPT2EHKIFAVCNFSM6AAAAABTFAH3S2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRTG42TEMJXHE.
You are receiving this because you were mentioned.Message ID: @.***>

I am not sure to understand the issue at the moment.
If this is still a problem at run-time of the flowgraph, as you mentioned in your first post, have you tried to recompile and regenerate the flowgraph before running it? Have you pulled the last commit?
If this is a problem with the board, this is more concerning.
In all cases, if the issue has not been solved, you can send me an email so that we can fix an appointment to look at the issue.