Mafia III [GOG] freezes at splash screen

Hello and thank you for your GREAT work :)
Mafia III [GOG] freezes at splash screen with DXVK. I tried it with 0.41 and 0.42. The game starts normally with Wine and Wine-staging but is with messed graphics which is very dark. With DXVK it freezes at splash screen. With apitrace the game again freezes at splash screen.
Software information
Mafia III [GOG]
Arch Linux 86_64
System information

GPU: Intel 3770
Driver: 390.48, Nvidia GTX 1080Ti
Wine version: 3.5 Staging/ 3.5 vanilla
DXVK version: 0.42

Apitrace file(s)
https://pastebin.com/WQiJUtRJ
Log files

d3d11.log:
https://pastebin.com/Pv1UMUJA
dxgi.log:
https://pastebin.com/Af1V1zPC
Wine log:
https://pastebin.com/HXBx0p7X

This game is known to require Stream Output, which just isn't implemented yet. Based on your logs it's obvious that the game tries and fails to create a geometry shader with stream output - that doesn't mean that it causes the crash, but it doesn't make sense to dig into that further before the issue is fixed, especially since I cannot reproduce it. See #135

But with normal Wine the game runs beyond the splash screen and I was hoping that with DXVK it may be with normal graphics, Sorry for the inconvenience.

Wine implements Stream Output, DXVK doesn't.

Ok we'll wait for Stream Output implementation than. Thank you :)

Mafia III works great if you compile DXVK with fake output support

That's GREAT news!!! Would you like to give us precompiled libraries with fake output support? Please :)

Now I tried it with dxvk.conf but it doesn't work. The game still freezes at the splash screen. Please, give me two x64 libraries of yours. Thank you in advance.

Arch packages: https://drive.google.com/drive/folders/1bCHCtJHAAss2NwGNcgwdEx2WHdE5DT83?usp=sharing

Thank you very much! I replaced the libraries with those yuo gave me but the game still freezes at startup. I tried it with new, clean prefix to no avail. Did you installed some other staff? I try GOG version. Is your version different?
Thank you once again :)

I am using the Steam version, but the GOG version is also known to work. What I've done (according to the Lutris script) is that I renamed mafia3.exe to launcher.exe (and renamed launcher.exe to mafia3.exe accordingly). The launcher requires DotNet 4, and isn't supported by Wine (it crashes even if you install DotNet/wine-mono)

Oh and also the most important part, you should set the game to Windowed mode (fullscreen is known to freeze at startup). For that open $WINEPREFIX/drive_c/users/vanyasem/Local Settings/Application Data/2K Games/Mafia III/Saves/videoconfig.cfg and paste -6 0 1920 1080 0 0 0 0 (if the Saves folder doesn't exist, create it)

Yes, the game runs now! The fulscreen part was the culprit. Thank you very much again. Finally I'll play it!

Yes, the game runs now! The fulscreen part was the culprit. Thank you very much again. Finally I'll play it!

Hello again :)
I actually found a way to run the game in full screen and I want to share it with you. I hope it will be benefical for somebody.
If you run on lower resolution than defined in the videoconfig.cfg, the game will run in fullscreen without problems. For example, if your resolution is 1280x800 and you set in videoconfig.cfg the following:
0 0 1920 1080 1 0 0 1
the game will run fine in fullscreen at 1280x800 resolution.
I hope this will be useful.
@vanyasem,
You can set the fps to 60 from game options. I'm with 3770 and GTX1080Ti and the game runs with stable 55-60 FPS :)

My framerate is set to unlimited. I run the game in 4k, that's why it's slow :P @mozo78

Ah, I see :)

@vanyasem Can your dxvk builds be used on other distros?

@brenthuisman you're welcome to try. I only run Arch

Yes, the builds can be used on other distributions. I tried them on Arch and Mint 19 and they work without problems.

I just completed the game:

It was tough task though. The game has random crashes and I had to replay some missions several times. In some area the game suffers from HEAVY frame drop around 1-2 FPS until you go out of these areas. Often if you return to that area, the game again crashes. Anyway I'm a super, hyper stubborn person and completed it. Thank you VERY much doitsujin, vanyasem!!!

Hello again. Even with Stream Output Support the game has some issues. I found two. The first one is negative like colors in some areas:

And the second is the heavy FPS drop in some areas. It is below 1 FPS and it's very hard to avoid such areas. I can't test with vanilla Wine because the game just freezes. The first such area is when Lincon have to call his boss after the boat escape from the bank. Once the call has ended and the game suffers from severe framedrop. If you are patient enough, you'll walk away frome the phone area and the game than runs normal again. There are many such areas further in the game.

Can anyone confirm this on AMD?

The colors are greysh and negative like. The must be colorful not almost black and white. Here you can see the same location from this quest:
https://youtu.be/Ps2b8vbHJa0?t=258

I don't see the "almost black and white" part in your screenshot. Maybe it's too bright, but that might as well be because it's a different time of day? Don't know.
If you want me to debug it, please record an apitrace.

The severe framedrop is the biggest issue. Don't bother with the negative effect :) Let someone say if it occurs on AMD too.

There is no "negative effect" and if it's a DXVK bug, i very much do care. More so than about frame drops because those probably cannot be fixed anyway.

Unfortunately I have alredy completed the game and today I just tried it Stream Output to see how it behaves. After that I deleted the Wine prefix and the saves are gone. I don't want to play the begining for a third time to reach thus ques again. And this problem isn't a game braker but the problem with the severe frame drop does. One has to be with VERY stong nerves to play FPS with 0.5 FPS especially when the AI shoot at him.


CLOUDSTACK-9379: Support nested virtualization at VM level on VMware Hypervisor

Introduction
JIRA TICKET
It is desired to support nested virtualization at VM level for VMware hypervisor. Current behaviour supports enabling/desabling global nested virtualization by modifying global config 'vmware.nested.virtualization'. It is wished to improve this feature, having control at VM level instead of a global control only.
Proposal
A new global configuration is added, to enable/disable VM nested virtualization control: 'vmware.nested.virtualization.perVM'. Default value=false
Behaviour
After a vm deployment or start command, vm params include 'nestedVirtualizationFlag' key and its value is:

true -> nested virtualization enabled
false -> nested virtualization disabled

We will determinate nested virtualization enabled/disabled by examining this 3 values:

(1) global configuration 'vmware.nested.virtualization' value
(2) global configuration 'vmware.nested.virtualization.perVM' value
(3) 'nestedVirtualizationFlag' value in user_vm_details if present, null if not.

Using this 3 values, there are different use cases:

(1) = TRUE, (2) = TRUE, (3) is null -> ENABLED
(1) = TRUE, (2) = TRUE, (3) = TRUE -> ENABLED
(1) = TRUE, (2) = TRUE, (3) = FALSE -> DISABLED
(1) = TRUE, (2) = FALSE, (3) indifferent  -> ENABLED
(1) = FALSE, (2) = TRUE, (3) is null -> DISABLED
(1) = FALSE, (2) = TRUE, (3) = TRUE -> ENABLED
(1) = FALSE, (2) = TRUE, (3) = FALSE -> DISABLED
(1) = FALSE, (2) = FALSE, (3) indifferent -> DISABLED

@nvazquez I like the functional description and will probably run through the code over the weekend but one thing struck me. A lot of this should apply equally for other hypervisors, shouldn't it? Did you compare design or have a reason to implement it this VMWare specific?

Hi @DaanHoogland, unfortunately I really didn't examine it for other hypervisors. In our environment we only use VMware ESXi hypervisor, that's the main reason for implementing it only in VMware code

:) no worries, just expect some review comments to this extend ;)

KVM also has this feature and there you can enable/disable it in the agent.properties file (ant not per VM). We should try to make the code as generic as possible, instead of implementing it like this IMHO.
Why do you want to control this per VM by the way?

@nvazquez Can you use ConfigKey instead of changes on Config.java and schema-481to490.sql ?

@remibergsma In some private cloud environments nested virtualization is not a good fit so it is generally disabled. That's fine but we found that it would be very nice to have a way to support exceptions e.g. to support users to run Android emulators that as it turned out needs nested virtualization.

@remibergsma, @DaanHoogland Current global support for nested virtualization is only vmware specific and done in VmwareGuru.
Are you proposing to move the logic up to the HypervisorGuru and change vmware.nested.virtualization to just nested.virtualization ? Then the implementation can be done in respective Resources.

Hi @ustcweizhou @DaanHoogland @remibergsma,
I moved global config definitions to ConfigKey.java instead of Config.java and schema-481to490.sql.
I also created a JIRA ticket https://issues.apache.org/jira/browse/CLOUDSTACK-9391 to extend this functionality to any hypervisor, I can work on it and create a separate pull request, what do you think?

@nvazquez sounds great, keep us posted

Could this be reviewed for VMware please? Then I can work on extending it to other HVs
Thanks!

ACS CI BVT Run
Sumarry:
Build Number 198
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3
Link to logs Folder (search by build_no): https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0
Failed tests:
Skipped tests:
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm
Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

Hi @DaanHoogland @remibergsma @ustcweizhou,
I rebased master branch for this pull request as it's been opened for a while, could it be reviewed please?

@nvazquez unfortunately I no longer am involved in cloud computing. I'd really need a deep dive to give value, sorry.

Oh that's sad, no problem, thanks anyways @DaanHoogland

@nvazquez long time we don’t do this ;)
First of all, your PR explanation is great. The code is very well documented and explained and with test cases (very good ones). Congratulations. I really like your work.
I have some suggestions for you, though.
I think that the method “enableNestedVirtualization” could return a Boolean. I see no need to transform the Boolean in a String there; It seems better to use Boolean.toString(bool) at line 376. Moreover, when reading the method “enableNestedVirtualization”, I felt like it was going to enable something on the VM, which is not the case. This looks more a “should”, “can”, “has” type of method. I mean, it is a method that checks if something has to/should/can be done; in this case, the enabling of nested virtualization. Therefore, I think names such as “canUseNestedVirtualization”, “should enableNestedVirtualization”, “hasToEnableNestedVirtualization” seem more appropriate.
I also think that the code has room for improvements. First, to reduce the cyclomatic complexity, you can invert the first if, which become something like this:
if (globalNestedV == null || globalNestedVPerVM == null) {
    return false;
}

Then, the other conditional can be further improved. It is a bit complicated. Something like this would have the same result:
if (globalNVPVM) {
            return (localNestedV == null && globalNV) || BooleanUtils.toBoolean(localNestedV);
        }
  return globalNV;

On method “configNestedVirtualization”, I would just suggest using the word “configure” instead of “config”. At least for me, when I read config, I think configuration and not configure (this is a very personal opinion, so if you are ok with config, be my guest). A method, for me, means an action that is executed, so it seems a better fit the word “configure” (verb).
The method “testConfigNestedVirtualization”, I think it should check if the “VmDetailConstants.NESTED_VIRTUALIZATION_FLAG” flag (parameter) is being loaded properly from the “vmDetails”. I also suggest you using the “inOrder” to verify the calls in order. If the order of the calls changes, the behavior of the method changes too, right?
About the method “enableNestedVirtualizationBaseTest”, I think it could be a little bit more self-explaining, such as: executeAndVerifyTest.
And finally, about the others test methods, I think instead of TFT, TFN, and others at the end, I think if you were a bit more literal, and self-explaining, it would be better. For instance, the test method “testEnableNestedVirtualizationCaseTFF”, in a more detailed version, could be read as “testEnableNestedVirtualizationCaseGlobalNvTrueGlobalNvPvFalseLocalVmfalse”. I know it is a huge method name, but I think it facilitates for newcomers and also for the @nvazquez of the future ;)

@rafaelweingartner thanks a lot for your help as always!
I refactored based on your comments. I really liked your review, especially your refactor on shouldEnableNestedVirtualization, it really simplifies method's understanding. I also included all your suggestions on method's names and in-order verification.
I had to make some changes on VmwareGuruTest using reflection to include mocks in configuration keys variables on VmwareGuru. What do you think about this solution?
Thanks again for taking the time to review this PR

@nvazquez  the code is great now.
I have just a concern about that hack to change the field declared as final.
In my opinion, the final there does not bring benefits. So, I believe it can be removed.
I have seen people using final a lot, but I think that final should be used only when we have 100% certainty that it is needed; otherwise, it complicates our lives when writing test cases or while extending some method/class.
What do you think?

@rafaelweingartner I agree it wasn't the best solution but I meant to include it for the sake of testing configureNestedVirtualization method. Which approach can I take to test this method, as it uses configuration final variables to determinate enabling/desabling nested virtualization?

I understand the need to create a test. And I agree that it deserves a test. What I meant was the following.
IMHO, you could simply remove the final keyword of the variable declaration. Sometimes in the ACS code, I have seen people using some design/ways of coding without having a good and well-thought explanation for them (the use of final is one good example). For instance, variables “VmwareEnableNestedVirtualization” and “VmwareEnableNestedVirtualizationPerVM” are only used in the “VMwareGuru” class. They do not need to be either static or public. Moreover, there is no need for those variables to be final.
If those variables were protected (only), it would be much easier to write test cases.

Thanks @rafaelweingartner, I agree with you, I refactored it!

@nvazquez, it seems that there was a problem with the Jenkins Job. Can you force another build?

Sure, done

There is still one point I would like to highlight. The method VmwareResource.configNestedHVSupport does not need to be static.

I had removed it, I saw your comment in that file and I included it in last refactor, I forgot to mention it in my last comment :)

Great.I am ok with the code. I give my LGTM here.
I have one extra question, though.  How do you intend to change that parameter (NESTED_VIRTUALIZATION_FLAG) to tell which VM should have the nested virtualization enabled? I am assuming that there is no option through the ACS API, is that right? If so, you are going to change the parameter directly in the database, right?

@rafaelweingartner That's correct. At this point advanced VM details and advanced template details have no UI exposure. At some point we can bring in PR to show this in UI and allow API based changes

Great. You have done a lot of work already; but, just to make sure things do not get lost. What about opening a Jira ticket to expose that customization through the ACS API?

Thanks @rafaelweingartner
This is the link to JIRA ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-9457

I am the one thas has to thank you @nvazquez, great work!

@jburwell @rhtyd @koushik-das Can you review this PR?

@nvazquez @serg38 how about we remove vmware.nested.virtualization.perVM and instead if the user vm detail exists and is true, it overrides the global setting?

@rhtyd @jburwell @rafaelweingartner @koushik-das The rationale to have vmware.nested.virtualization.perVM was that advanced vm_details and template details are user controlled. With https://issues.apache.org/jira/browse/CLOUDSTACK-9457
‘Allow retrieval and modification of VM and template details via API and UI’ users will be able to change any advanced details in UI and API.
If admin wants to preserve that nested virtualization is controlled in centralized fashion they can do so by setting vmware.nested.virtualization.perVM to ‘false’. Idea was to allow organizations that currently have nested virtualization disabled to have it so after upgrade. Does it make sense or everyone prefers that setting on VM level overrides global one?

@rhtyd @jburwell @rafaelweingartner @koushik-das Can we agree if this PR is OK as it is ?

@serg38 with your explanations, I am ok with the current state of this PR. No further changes are needed.
There is only one problem now. There are some merge conflicts that have to be resolved.

Solved, thanks @rafaelweingartner

@rafaelweingartner @jburwell @karuturi Looks like this PR has everything to get merged. Can we do it by the release freeze?

@serg38 @nvazquez I apologize that I am late to the review.  I would like to see a Marvin test added that verifies that nested virtualization works when the global setting is enabled (i.e. successfully create a VM within a VM).  Would that be possible?

@jburwell Creating Marvin test for this PR will be a huge undertaking. It would require building and configuring a hypervisor in a deployed VM and then creating VM in VM. Considering storage, environmental and network implication the test will be complicated and error prone. An alternative approach would require integrating vSphere SDK with Marvin python libraries and query vSphere for the actual nested virtualization settings from a deployed VM. The effort doesn't seem to be warranted for such a minor change. As long as standard integration suite is passing this shouldn't affect any existing functionality. What do you think?

@serg38 the goal is not only verify that functionality works now, but in the future to protect against regressions.  My thinking is that we could deploy a CentOS VM, install KVM, and verify that we can create an ephemeral VM within it.  A specially packaged template could have the KVM packages pre-installed and a small Debian or Alpine template on-board.  The test would pass when it is able to SSH into the nested VM over the link-local interface.  Such a test would be self-contained and not require any particular storage or network settings.  Does such a test seem reasonable and valuable?

@jburwell The only BUILTIN Centos template for Vmware is 5.3 that doesn't have KVM support to my knowledge. Are you proposing to introduce another BUILTIN template so that it is available for anyone to use during the integration testing? We don't have any KVM expertise at this point so this will be next to mission impossible. The only option for us would be to package vSphere python SDK and try to talk to vCenter directly.

@rhytd can you help @serg38 craft a template with KVM installed and the virsh commands to create a nested VM?

@jburwell @rhtyd Thanks in advance

@serg38 no problem

@jburwell nested VM is something tricky to test, we can support this as a subtle feature but not a generally supported one. In our test/trillian environment, we're already running nested virtualization. I'm not sure investing time on inception of a test environment is useful. The feature is specific to vmware, I don't understand why KVM needs to be involved.
A quick test could be to run a guest VM on VMware with specific cpu flags (say vmx, smx, ht) and verify that the VM launched with these flags have the cpu features for example, the test could do: (1)ssh into the vm, (2) cat /proc/cpuinfo and (3) grep flags for specific cpu flags such as vmx, ht etc. I think such a test should work with the default centos template or with macchanina.
The feature could also be written and tested in such a way to add any key/value details on a VM and be interpreted by the hypervisor specific resource.

Great tip, @rhtyd This way it is actually very straightforward. We should be able to come up with integration test for this PR shortly

@rhtyd good idea to check the CPU flags.  There is a part of me that would like to see a VM actually spin up inside a VM, but there are also many things that could go wrong that are not related to CloudStack.  Plus, it would be slow.  Therefore, checking the CPU flags is an excellent compromise.
Another thing that I see in this PR is that nested virtualization seems like a capability that should be more generally expressed and managed in CloudStack's core abstractions.  @rhtyd could you open a ticket to extract the aspects of this enhancement that are common across all hypervisors that support nested virtualization?

@jburwell This sounds like a good idea. In this PR all abstraction work is done so the things to do would be to implement support in respective hypervisor resources as well as strip "vmware." prefix from conjuration items. @nvazquez is preparing intragrtion test based on @rhtyd idea

@jburwell @rhtyd I included new marvin test for nested virtualization, thanks @rhtyd for your idea!

@nvazquez you're welcome. If you've some bandwidth, can you run your test against this template which will also help validate the new vmware test appliance: https://github.com/rhtyd/tinylinux

@rhtyd sure, will do and post results

Hi @rhtyd, we ran test_internal_lb.py and test_vpc_vpn.py using tl-vmware.ova template and got this results:
test_vpc_vpn is ok:
Test Site 2 Site VPN Across redundant VPCs ... === TestName: test_01_redundant_vpc_site2site_vpn | Status : SUCCESS ===
ok
Test Remote Access VPN in VPC ... === TestName: test_01_vpc_remote_access_vpn | Status : SUCCESS ===
ok
Test Site 2 Site VPN Across VPCs ... === TestName: test_01_vpc_site2site_vpn | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 3 tests in 1949.605s

OK

However, test_internal_lb fails, we could find some issues:

/sbin/ip is needed but not present in template {Cmd: /sbin/ip addr show eth0 |grep 'inet '| cut -f6 -d' ' > /tmp/index.html via Host: <IP_ADDRESS>} {returns: [u'sh: /sbin/ip: not found']}
2 more tests fail due to a difference in wget on new template: {Cmd: /usr/bin/wget -T3 -qO- --user=XX --password=XX http://XXXX:8081/admin?stats via Host: <IP_ADDRESS>} {returns: [u"/usr/bin/wget: unrecognized option '..
We have some strange erros in this functions which require more arguments than given but couldn't find out why

2016-10-02 22:13:20,881 - CRITICAL - EXCEPTION: execute_internallb_haproxy_tests: ['Traceback (most recent call last):\n', '  File "/usr/local/lib/python2.7/unittest/case.py", line 331, in run\n    testMethod()\n', 'TypeError: execute_internallb_haproxy_tests() takes exactly 2 arguments (1 given)\n']
2016-10-02 22:13:20,883 - CRITICAL - EXCEPTION: execute_internallb_roundrobin_tests: ['Traceback (most recent call last):\n', '  File "/usr/local/lib/python2.7/unittest/case.py", line 331, in run\n    testMethod()\n', 'TypeError: execute_internallb_roundrobin_tests() takes exactly 2 arguments (1 given)\n']
2016-10-02 22:13:20,885 - CRITICAL - EXCEPTION: run_ssh_test_accross_hosts: ['Traceback (most recent call last):\n', '  File "/usr/local/lib/python2.7/unittest/case.py", line 331, in run\n    testMethod()\n', 'TypeError: run_ssh_test_accross_hosts() takes at least 3 arguments (1 given)\n']

Thanks for testing @nvazquez I think since @NuxRo built new vmware templates, we can consume macchinina/vmware: http://dl.openvm.eu/cloudstack/macchinina/x86_64/testing
The TinyCore based template I had created lacks 'ip/iproute' package and httpd, I'll try to fix it though as this point since Lucian has already fixed macchinina it might be not necessary.

@nvazquez I would like to get this PR merged for <IP_ADDRESS>.  Could you please rebase this PR to pull the latest Marvin enhancements/fixes?  Once that is done, I will kick off a regression test in preparation to merge it.

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-120

The debian pkg failed due to an intermittent unit test failure (ignorable, env issue).
@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Thanks @jburwell!   When that is ready, we will re-execute the smoke tests with the new component test introduced by the PR.

That's great, thanks!

@karuturi @jburwell As per @rhtyd we can run additional tests with blueorangutan .  Can you take a look and then re-kick the tests? Some errors were due to that.
530, errortext : u'Unable to add NIC to VM[User|i-39-54-VM]: com.cloud.exception.AgentUnavailableException: Resource [Host:1] is unreachable: Host 1: Unable to start instance due to Unable to start  VM:f22d93f6-e197-46e4-8e0c-0a926fece518 due to error in finalizeStart, not retrying'},

@serg38 these errors look similar to those we have seen on other PRs.  We are currently investigating them with the assumption that they are most likely environmental.  Once we have them resolved, we will re-kick the tests.
/cc @PaulAngus @murali-reddy @rhtyd

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian.  I think it is ready for merging now.
2016-11-20 16:32:00,324 - CRITICAL - EXCEPTION: test_3d_gpu_support: ['Traceback (most recent call last):\n', '  File "/usr/lib64/python2.7/unittest/case.py", line 369, in run\n    testMethod()\n', '  File "/marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py", line 316, in test_3d_gpu_support\n    self.virtual_machine.add_nic(self.apiclient, self.isolated_network.id)\n', '  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 784, in add_nic\n    return apiclient.addNicToVirtualMachine(cmd)\n', '  File "/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", line 637, in addNicToVirtualMachine\n    response = self.connection.marvinRequest(command, response_type=response, method=method)\n', '  File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", line 379, in marvinRequest\n    raise e\n', "Exception: Job failed: {jobprocstatus : 0, created : u'2016-11-20T16:29:43+0000', cmd : u'org.apache.cloudstack.api.command.admin.vm.AddNicToVMCmdByAdmin', userid : u'1575bde5-af3a-11e6-b333-06aa7801071a', jobstatus : 2, jobid : u'78b21bfa-bc82-4df6-ad54-67ef0899ceeb', jobresultcode : 530, jobresulttype : u'object', jobresult : {errorcode : 530, errortext : u'Unable to add NIC to VM[User|i-7-9-VM]: com.cloud.exception.AgentUnavailableException: Resource [Host:1] is unreachable: Host 1: Unable to start instance due to Unable to start  VM:a42c5549-c3c4-47b3-8e49-0785d1c2ef44 due to error in finalizeStart, not retrying'}, accountid : u'1575a6c7-af3a-11e6-b333-06aa7801071a'}\n"]

Based on test results LGTM. /cc @jburwell
Can we have one more LGTM on this, @serg38 @jburwell ?

LGTM

LGTM, merging based on code reviews and tests, ignoring known intermittent errors in vpc/rvr.


unicode bug in envelope_api.get_document

v. 3.4.0
Problem file name had Unicode character in it: Minutes of: Arise & Shine🌤.pdf
our code looks something like this and works for non unicode named documents.
temp_file = self.envelope_api.get_document(
            account_id=self.account_id,
            document_id=(int),
            envelope_id=(int)
        )

/usr/local/lib/python3.6/dist-packages/docusign_esign/client/api_client.py:574
in __deserialize_file/usr/local/lib/python3.6/dist-packages/docusign_esign/client/api_client.py:256
in deserialize/usr/local/lib/python3.6/dist-packages/docusign_esign/client/api_client.py:186
in __call_api/usr/local/lib/python3.6/dist-packages/docusign_esign/client/api_client.py:354
in call_api/usr/local/lib/python3.6/dist-packages/docusign_esign/apis/envelopes_api.py:5274
in get_document_with_http_info/usr/local/lib/python3.6/dist-packages/docusign_esign/apis/envelopes_api.py:5157
in get_document/PROJECT_ROOT/cloud/integrations/signature.py:302 in download_file

--

Hi @matthewcocook,
It looks like this section of code has the bug, specifically the code is not stripping out non-ascii characters. (And it should also remove any characters that would be problematic within file names such as / or \ ...)
I have filed bug report DCM-4581
In addition, in the future, the SDK will not store downloaded documents in temp. See https://github.com/docusign/docusign-php-client/issues/56
I don't have a date from our engineering group on when this bug will be fixed. A workaround is to call the API directly.
Thank you for reporting the issue.


Fix the minor style issue

Summary
Impact
Minor
Testing
Pass CI

Please ignore the style warning.

Please rebase

@xiaoxiang781216 could you please take a look on CI failures? I restarted it couple of time, but failures persist

Done.


Have demo app run and produce logs.

This involves updating the port to avoid a conflict with another service and changing the logger configuration.

@kauffmj Don't forget to update the Jenkins job to pull from master once this is merged.


[SPARK-35269][BUILD] Upgrade commons-lang3 to 3.12.0

What changes were proposed in this pull request?
This pr aims to upgrade Apache commons-lang3 to 3.12.0
Why are the changes needed?
This version will bring the latest bug fixes as follows:

https://commons.apache.org/proper/commons-lang/changes-report.html#a3.12.0

Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass the Jenkins or GitHub Action

Test build #138074 has started for PR 32393 at commit 9cf78d8.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42594/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42594/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42594/

Test build #138074 has finished for PR 32393 at commit 9cf78d8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138074/

thx ~ @dongjoon-hyun @srowen


Auto wrapped functions, etc in javascript

In js mode, objects, funcs are wrapped by default. Any way to change this?

Comment the line au FileType javascript call JavaScriptFold() in the file vimrcs/filetypes.vim. @ziyaaktas

That did it, thanks!


Byte align feature for Retroblaster

The retroblaster will only write roms that are a multiple of  1,048,576 bytes

This has been fixed


Support multi print params like '-print=HBhb'

In some cases, we need display parts of req & resp info.
Like req's HEADER and resp's BODY:
We can use -print=Hb to get these.
Or req's BODY and resp's HEADER:
Use -print=Bh.
While -print=A is still supported.

looks more clear now. great


component section details not display issue fix(#318)

I got this issue when adding authentication from swagger 2.0 to OpenApi 3.0.2. Earlier I had below settings in my swagger_config dict.
swagger_config = {
    "headers": [],
    "specs": [
        {
            "endpoint": "swagger",
            "route": "/characteristics/swagger.json",
            "rule_filter": lambda rule: True,  # all in
            "model_filter": lambda tag: True,  # all in
        }
    ],
    "title": "Product Characteristics APIs",
    "version": '',
    "termsOfService": "",
    "static_url_path": "/characteristics/static",
    "swagger_ui": True,
    "specs_route": "/characteristics/swagger/",
    "description": "",
    "securityDefinitions": {
        "oAuthSample": {
            "type": "oauth2",
            "flow": "application",
            "tokenUrl": "https://api.pgsmartshopassistant.com/o/token/",
        }
    }
}

It's worked fine. When I move into OpenApi 3.0.2 they changed securityDefinitions to securitySchemes under components with some other new naming conventions. So I changed it accordingly with openapi to 3.0.2.
swagger_config = {
    "openapi": "3.0.2",
    "components": {
        "securitySchemes": {
            "oAuthSample": {
                "type": "oauth2",
                "flows": {
                    "clientCredentials": {
                        "tokenUrl": "https://api.pgsmartshopassistant.com/o/token/",
                    }
                }
            }
        },
        "schemas": {
            "Product Characteristics": {
                "type": "object",
                "properties": {
                    "ean": {
                        "type": "string"
                    },
                    "i_q_name": {
                        "type": "string"
                    },
                    "id": {
                        "type": "integer"
                    },
                    "max": {
                        "type": "integer"
                    },
                    "min": {
                        "type": "integer"
                    },
                    "pack_size": {
                        "type": "integer"
                    },
                    "typical_use": {
                        "type": "number",
                        "format": "float"
                    },
                    "unit_count": {
                        "type": "integer"
                    },
                }
            }
        }
    },
    "specs": [
        {
            "endpoint": "swagger",
            "route": "/characteristics/swagger.json",
            "rule_filter": lambda rule: True,  # all in
            "model_filter": lambda tag: True,  # all in
        }
    ],
    "title": "Product Characteristics API",
    "version": '',
    "termsOfService": "",
    "static_url_path": "/characteristics/static",
    "swagger_ui": True,
    "specs_route": "/characteristics/swagger/",
    "description": "",
}

So this is not work with current version of flasgger. This component is a new keyword from OpenApi 3. This is what documentation mention about it,

components serve as a container for various reusable definitions – schemas (data models), parameters, responses, examples, and others. The definitions in components have no direct effect on the API unless you explicitly reference them from somewhere outside the components. That is, components are not parameters and responses that apply to all operations; they are just pieces of information to be referenced elsewhere. Under components, the definitions are grouped by type – schemas, parameters and so on. The following example lists the available subsections. All subsections are optional.

components:
  # Reusable schemas (data models)
  schemas:
    ...
  # Reusable path, query, header and cookie parameters
  parameters:
    ...
  # Security scheme definitions (see Authentication)
  securitySchemes:
    ...
  # Reusable request bodies
  requestBodies:
    ...
  # Reusable responses, such as 401 Unauthorized or 400 Bad Request
  responses:
    ...
  # Reusable response headers
  headers:
    ...
  # Reusable examples
  examples:
    ...
  # Reusable links
  links:
    ...
  # Reusable callbacks
  callbacks:
    ...

So I fix it by adding components key into data dict in base.py with some validation. This will only consider when we change the OpenApi version to 3.*.* and I would like to see them in the official repository. Thanks!

@billyrrr please check this pull request and let me know the status of it and I didn't add any version for this.

Hi, @kushan-gunasekera . It might take up your time, but could you add an example to the examples code to show that without this change, such example fails? I am reading over the OpenAPI 3 specs for now, so I'll merge this pull request within this week. Sorry about the delay.

Hi, @kushan-gunasekera . I have merged your change into a different branch openapi3, and plan to release the changes once openapi3 support for Flasgger is no longer experimental. Let me know what you think. Thanks!

Thanks to hear that @billyrrr , I updated few months back to compatible with version 3.x.x as well as keep the backward compatibility for version 2.x.x. You can try my example with the previous versions, but it doesn't work. I hope this branch will help someone!

Hello @billyrrr , any updates about this branch? Any issues? Let me know. :)

Hi, @kushan-gunasekera . Sorry about the late reply. One of my concern with this branch is that the support for OpenAPI3 is not full. For example, new users in OpenAPI3 may try to define or reference a component in docstring with component keyword, which will be swallowed in flasgger. I hope to make "component" work similarly to "definitions" in a new version to reduce confusion. However, supporting both OpenAPI2 and OpenAPI3 with the current code base seems difficult. I am considering creating a flasgger-oa3 fork to address the users who use OpenAPI3. Would you like to help?


Address IE10 in browser compatibility docs

Currently the docs explicitly address IE9 and implicitly address IE11 since it's the latest IE version, but the status of IE10 is left unclear.
/fyi @patrickhlauke @mdo

LGTM


Dark mode no longer works

Current Behavior
There should be a preference setting for dark mode inside MediaInfoGui - it’s not there.
DARK_MODE environment variable does nothing. Always in light mode, and missing toolbar icons.
Expected Behavior
Select dark mode from MediaInfo GUI or with ENV variable.
Toolbar icons missing.

Steps To Reproduce
No response
Environment

OS: Linux
OS version: linux/amd64 4.4.302+
CPU: Intel Denverton
Docker version: 20.10.23
Device model: DS1819+
Browser/OS: Safari iOS 17.6

Container creation
Synology Container App
Container log
[app         ] QApplication: invalid style override 'Adwaita-Dark' passed, ignoring it.
[app         ] 	Available styles: Windows, Fusion

Container inspect
"ENV=/root/.docker_rc",
                "USER_ID=1038",
                "GROUP_ID=65536",
                "SUP_GROUP_IDS=",
                "UMASK=0022",
                "LANG=en_US.UTF-8",
                "TZ=Europe/London",
                "KEEP_APP_RUNNING=0",
                "APP_NICENESS=10",
                "INSTALL_PACKAGES=",
                "PACKAGES_MIRROR=",
                "CONTAINER_DEBUG=0",
                "DISPLAY_WIDTH=1366",
                "DISPLAY_HEIGHT=1024",
                "DARK_MODE=1",
                "SECURE_CONNECTION=0",
                "SECURE_CONNECTION_VNC_METHOD=SSL",
                "SECURE_CONNECTION_CERTS_CHECK_INTERVAL=60",
                "WEB_LISTENING_PORT=5800",
                "VNC_LISTENING_PORT=5900",
                "VNC_PASSWORD=",
                "ENABLE_CJK_FONT=0",
                "WEB_AUDIO=0",
                "WEB_AUTHENTICATION=0",
                "WEB_AUTHENTICATION_DEFAULT_USERNAME=",
                "WEB_AUTHENTICATION_DEFAULT_PASSWORD="

Anything else?
No response

Thanks for reporting. Fixed with the latest image!


Ensure dataPoint is not undefined

Whatever changed recently, the AWS and Azure pages are not rendering now without this fix.

Codecov Report

Merging #1572 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1572   +/-   ##
=======================================
  Coverage   77.50%   77.50%
=======================================
  Files         233      233
  Lines        3832     3832
  Branches      704      704
=======================================
  Hits         2970     2970
  Misses        772      772
  Partials       90       90

Impacted Files
Coverage Δ

src/utils/computedReport/getComputedReportItems.ts
68.96% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25b55df...487d328. Read the comment docs.


Eliminate getTypedConstructor boilerplate

First, create a base trait
trait ReactComponentBase {
  type Props
  type State
}

then make ReactComponent extend it and fill in type members to its type arguments.
Then you can have
def typedConstructor[A](implicit ct: ConstructorTag[A]) = ct.constructor.asInstanceOf[ReactTypedConstructor[P, S]]

However I would take it a step further:
class ReactFactory[A, P, S](val ctor: js.Dynamic) {
  def typed = ctor.asInstanceOf[ReactTypedConstructor[P, S]]
  def createElement(props: P): ReactElementU[P, S] = ...
  // all the createElement variants
}
object ReactFactory {
  def apply[A <: ReactComponentBase](implicit ct: ConstructorTag[A]) = new ReactFactory[A, A#Props, A#State](ct.constructor)

Now you can write ReactFactory[MyComponent].createElement(...)
Note: createElement is necessary, we can't just call it apply and use function application syntax, since that would get interpreted as filling the implicit parameter list.
Alternatively, createElement etc. could be modified to something like
def createElement[A <: ReactComponentBase](props: A#Props, ...)(implicit ct: ConstructorTag[A]) = ...

(or take ReactFactory implicitly as a typeclass).

merged code from @nafg  fork. thank you @nafg  :)


getCurrentLocation(success, fail, options) is not defined type of BackgroundGeolocation?

Trying to call
 this.backgroundGeolocation.getCurrentLocation(success, fail, {});
but shows undefined. I need to call the current location function sometimes as the last location fetched is same as current. Sometimes it does not updates fastly.

Your Environment

Plugin version:
Platform:   Android
OS version: 6+
Device manufacturer and model: all android
Cordova version (cordova -v):   7.1
Cordova platform version (cordova platform ls):

Ionic 3.x
Context

Expected Behavior
It should fetch the location
Actual Behavior

It does not
Possible Fix

Steps to Reproduce

1.Add the line to your project it and build
Context

Debug logs

I think you're using 2.x branch (because backgroundGeolocation in 3.x starts with capital B).
getCurrentLocation method is implemented first in 3.x so it doesn't exists in 2.x branch.

I think you're using 2.x branch (because backgroundGeolocation in 3.x starts with capital B).
getCurrentLocation method is implemented first in 3.x so it doesn't exists in 2.x branch.

Good morning, I'm using the correct syntax with "B" and there's the error: getCurrentLocation is not a function. My app is made in javascript. I try to call this function inside the onbackground.
Moisés Santos

I think you're using 2.x branch (because backgroundGeolocation in 3.x starts with capital B).
getCurrentLocation method is implemented first in 3.x so it doesn't exists in 2.x branch.

Good morning, I'm using the correct syntax with "B" and there's the error: getCurrentLocation is not a function. My app is made in javascript. I try to call this function inside the onbackground.
Moisés Santos

Ambiente Cordova.  PhoneGap (iOS / Android / Windows)
cli-7.1.0 (4.5.4 / 6.3.0 / 5.0.0)
I noticed that Phonegap uses version 3.0.0-alpha.14

It was implemented in 3.0.0-alpha.30.
https://github.com/mauron85/cordova-plugin-background-geolocation/blob/master/CHANGES.md

Hi good night! When will the newest version be available on Phonegap Build? Your Plugin works. Except that something strange happens. The Maxima age option in settings as it is implemented. I already searched the available documentation and did not find it. I've seen examples using maximunAge. That's right? or maxAge? Help me and you will not regret it. Thankful. Moisés Santos.
Moisés Santos, Advogado OAB-RN 11.108
84 99653-5787 (Tim)
84 98722-6243 (whatsApp)
Assinatura automática

Visite meu site : http://www.drmoisessantos.com

De: Marián Hello<EMAIL_ADDRESS>Enviado: quarta-feira, 31 de outubro de 2018 18:16:47
Para: mauron85/cordova-plugin-background-geolocation
Cc: Moisés Santos da Silva; Comment
Assunto: Re: [mauron85/cordova-plugin-background-geolocation] getCurrentLocation(success, fail, options) is not defined type of BackgroundGeolocation? (#484)
It was implemented in 3.0.0-alpha.30.
https://github.com/mauron85/cordova-plugin-background-geolocation/blob/master/CHANGES.md
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/mauron85/cordova-plugin-background-geolocation/issues/484#issuecomment-434789186, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Akpxlpji46e8sYbL0BKilzdiBqABh-Kvks5uqekPgaJpZM4WjZVs.


Random CI failure on Oracle GraalVM: jdk.internal.vm.TranslatedException: Error decoding exception

I think I see this failure like this popping here and there:
https://github.com/enso-org/enso/actions/runs/8301012063/job/22720189516#step:8:3770 (Dry-run benchmark Sieve.Without_Types in Oracle GraalVM Engine job)
Execution finished with an error: java.lang.RuntimeException: jdk.internal.vm.TranslatedException: Error decoding exception: [B@71cdcc63
        at <java> org.graalvm.jniutils/org.graalvm.jniutils.JNIExceptionWrapperEntryPoints.createException(JNIExceptionWrapperEntryPoints.java:89)
        at <java> org.graalvm.truffle.runtime/com.oracle.truffle.runtime.hotspot.libgraal.TruffleToLibGraalCalls.newCompiler(Native Method)
        at <java> org.graalvm.truffle.runtime/com.oracle.truffle.runtime.hotspot.libgraal.LibGraalHotSpotTruffleCompiler.lambda$getOrCreateIsolate$0(LibGraalHotSpotTruffleCompiler.java:72)
        at <java> org.graalvm.truffle.runtime/com.oracle.truffle.runtime.hotspot.libgraal.LibGraalIsolate.getSingleton(LibGraalIsolate.java:99)
        at <java> org.graalvm.truffle.runtime/com.oracle.truffle.runtime.hotspot.libgraal.LibGraalHotSpotTruffleCompiler.resolveIsolateHandleImpl(LibGraalHotSpotTruffleCompiler.java:80)
        at <java> org.graalvm.truffle.runtime/com.oracle.truffle.runtime.hotspot.libgraal.LibGraalHotSpotTruffleCompiler.getOrCreateIsolate(LibGraalHotSpotTruffleCompiler.java:70)
        at <java> org.graalvm.truffle.runtime/com.oracle.truffle.runtime.hotspot.libgraal.LibGraalHotSpotTruffleCompiler.installTruffleCallBoundaryMethod(LibGraalHotSpotTruffleCompiler.java:119)
        at <java> org.graalvm.truffle.runtime/com.oracle.truffle.runtime.hotspot.HotSpotTruffleRuntime.installCallBoundaryMethods(HotSpotTruffleRuntime.java:529)
        at <java> org.graalvm.truffle.runtime/com.oracle.truffle.runtime.hotspot.HotSpotTruffleRuntime.bypassedInstalledCode(HotSpotTruffleRuntime.java:451)
        at <java> org.graalvm.truffle.runtime/com.oracle.truffle.runtime.OptimizedCallTarget.interpreterCall(OptimizedCallTarget.java:609)
        at <java>
…

Raised the issue to OracleLabs guys.

Working continues in https://github.com/openjdk/jdk/pull/18591

The bug has been fixed on the JDK side. What can we do to close it here as well, @Akirathan?

The bug has been fixed on the JDK side. What can we do to close it here as well, @Akirathan?

@JaroslavTulach Wait until https://github.com/openjdk/jdk/pull/18591 gets into JDK release, and then update to it? And ensure that it does not happen anymore in the dry-run benchmarks in the Oracle GraalVM job.
How does one figure out that https://github.com/openjdk/jdk/pull/18591 got pushed to a release?

The bug has been fixed on the JDK side. What can we do to close it here as well, @Akirathan?
How does one figure out that openjdk/jdk#18591 got pushed to a release?

We can observe the JDK Jira issue and/or we can ask @tzezula. As far as I can see, the fix will be available in JDK 23.

@JaroslavTulach Wait until openjdk/jdk#18591 gets into JDK release, and then update to it?

Do we want to update to JDK 23? I'd rather prefer to stick with LTS JDK 21 and got a bugfix. At the end we have Oracle GraalVM license...

The bug has been fixed on the JDK side.
We can observe the JDK Jira issue ...

According to @tzezula, the bug hasn't yet made it to labsjdk-23

Do we want to update to JDK 23? I'd rather prefer to stick with LTS JDK 21 and got a bugfix. At the end we have Oracle GraalVM license...

According to Mohamed Ez-zarghili from Oracle GraalVM support team Enso should:

renew our Oracle Java SE Subscription
file a MOS ticket

Mohamed wrote:

we can take it from there

but:

Please note that as this is in the JDK, I can follow up on it but have no guarantee that they will prioritise it, the JVMCI interface is experimental in JDK

I think we should be able to catch the problem on our builders. I've seen the problem in our JKD-23 graalvm ee gate.

Anybody seen this failure recently?

Request for backport of JDK-8329564 into JDK 21 has been entered into My Oracle Support:

as SR 3-37944867291.


Add ability to generate a certificate authority and signed certs.

On the Katello project (https://github.com/Katello/katello) we currently use a python based tool to generate and manager certificates within a puppet module we maintain for generating and managing our certificates (https://github.com/Katello/puppet-certs). We'd like to switch to a more pure Puppet/Ruby implementation but we require the ability to generate a CA, manage the CA and allow the generating of certificates signed by the generated CA.
The reason I mention the background is that I have got this addition to this point based on some initial testing and usage with our project and wanted to open this up for feedback.

Hello,
There's a lot of things in this PR, that probably belong in different features. Could you please separate the features in different PRs?

@raphink Thanks for the feedback. Before I'd do so, I'd like your input on the separation. I can think of potentially separating it into the following:

Generating a CA
Signing a cert with a CA
Regenerate param to force regeneration of key/request/cert
Scoping a cert as a client or server only cert

I think generating a CA could be useful. The code could certainly be simplified (starting with unnecessary explicit dependencies between files and directories).
I'll add some comments to the code.

In addition to my inline comments, the specs will need to be fixed, and probably some added, too.

@raphink I will start to break this apart chunk by chunk. I'd like to leave this open until I get them all as a reference.

Hi,
any updates on this @raphink @ehelms? I'd like the ability to sign a certificate using a CA certificate & key, which I think you've tackled with part 2?
Cheers,
Josh

Hello @ehelms,
Any news? There are some failures with the unit tests and code linting — care to correct them so that we can move forward?
Also, it appears to have conflicts with HEAD, might be good to rebase your work as well.
Cheers,
C.

Any further progress? I'm stuck in needing a proper server certificate that uses the openssl ca option or a better x509. It is only generating self-signed certs with the current code, which is frustrating.

@ehelms any news on this?


the drop measurement reappears and the data is old

System info:
influxdb version:1.5.2
operating system:ubuntu
tools:iterm,pycharm
language:python3.6
Steps to reproduce:
1.use python-influxdb  DataFrameClient.write_points write data to measurement 'TS121'
2. drop measurement TS121
3.use python-influxdb  DataFrameClient.write_points write same data to measurement 'TS121' again
4.drop measurement TS121
5.use python-influxdb  DataFrameClient.write_points write other data to measurement 'TS121' again
6.drop measurement TS121
7.select * from TS121 limit 1
Expected behavior:
after step 7
I expected nothing would be printed
Actual behavior:
after step 7
the screen show TS121 has data I wrote in step 1&3 not data in step 5
using DataFrameClient.query also could query the data in step 1&3
Additional info:
don't know much details.but drop other measurement is ok

Possibly a duplicate of #9694

@e-dard can this be closed?

Recently I get the similar bug:
1、measuremnt A has fields a,b,c
2、drop measurement A
3、write b,c into measurement A
4、expected is field only b,c but I get a,b,c .field a data is totaly empty
1、it's an old database
2、index-version = "inmem"
3、bug still after restart influxdb
4、write after drop
5、my version is 1.6.2 not try 1.7.2
@zeebo

我想更多地了解一下这个：

这是一个新鲜的数据库吗？
您的分片使用了哪些索引？
重启后问题是否仍然存在？
您是否在放弃测量的同时写入测量？
问题是否仍然发生在1.7.1版本上？

要收集分片索引类型，您可以导航到分片文件夹并检查它是否有index文件夹，或运行此命令：
influx -database <database> -execute 'show stats' | grep indexType | sort | uniq

I meet the situation again .is this a bug in 1.6.2?
最近我得到了类似的错误：
1，measuremnt A有字段a，b，c
2，丢弃测量A
3，写入b，c到测量A
4，预期只有字段b，c但我得到a，b，c。字段数据完全为空
1，它是一个旧的数据库
2，index-version =“inmem”
3，bug仍然在重启后涌入流媒体
4，写下降后
5，我的版本是1.6.2不试试1.7.2

I'd love to have some more details on this:

Is this on a fresh database?
What indexes are being used for your shards?
Does the issue persist after a restart?
Are you writing to the measurement the same time you're dropping it?
Does the issue still happen on version 1.7.1?

To collect shard index types, you can either navigate to the shard folder and check if it has an index folder, or run this command:
influx -database <database> -execute 'show stats' | grep indexType | sort | uniq

I meet the situation again .is this a bug in 1.6.2?
Recently I get the similar bug:
1、measuremnt A has fields a,b,c
2、drop measurement A
3、write b,c into measurement A
4、expected is field only b,c but I get a,b,c .field a data is totaly empty
1、it's an old database
2、index-version = "inmem"
3、bug still after restart influxdb
4、write after drop
5、my version is 1.6.2 not try 1.7.2

I'd love to have some more details on this:

Is this on a fresh database?
What indexes are being used for your shards?
Does the issue persist after a restart?
Are you writing to the measurement the same time you're dropping it?
Does the issue still happen on version 1.7.1?

To collect shard index types, you can either navigate to the shard folder and check if it has an index folder, or run this command:
influx -database <database> -execute 'show stats' | grep indexType | sort | uniq

I meet the situation again ,is this a bug in 1.6.2?
Recently I get the similar bug:
1、measuremnt A has fields a,b,c
2、drop measurement A
3、write b,c into measurement A
4、expected is field only b,c but I get a,b,c .field a data is totaly empty
1、it's an old database
2、index-version = "inmem"
3、bug still after restart influxdb
4、write after drop
5、my version is 1.6.2 not try 1.7.2

@EmptyRabbit I think I fixed this in https://github.com/influxdata/influxdb/pull/14266. It will be available in 1.8 or 1.7.9 (if there is a 1.7.9).


implemented .addDays,addMonths, .addYears, isLeapYear, getDaysInMonth methods

Description
implemented

.addDays()
.addMonths()
.addYears()
.isLeapYear()
.getDaysInMonth()

Issue Reference
#10
#9
Proposed Changes
Screenshots / GIFs / Videos

Checklist

[X] Lint rules are passed correctly
[X] Code builds correctly
[ ] Created or updated tests for the new code
[X] All existing and new tests passed
[X] Pull request title is concise and descriptive.
[X] Pull request is linked to the related issue.

I am gonna add more tests tomorrow, meanwhile please review methods added @ashiishme @aabishkaryal


rawkv: get should be handled in another thread

I use raw kv to do benchmark and find that the we do get callback in raftstore thread, this is not necessary and can be moved to another thread.

Fixed by #1434


osu-lazer crashes on launch (on arch), on wayland, on 0.33.0 and later (0.32.3 is fine)

Hyprland Version
Hyprland, built from branch main at commit f7cde9c92cb9e7c908f18ecf10ebdb366d0832b5 dirty (Nix: remove duplicate options from modules (4012)). Tag: v0.33.1-41-gf7cde9c9  flags: (if any) debug
Bug or Regression?
Bug
Description
When launching osu-lazer via command line, process exits after this message:
wp_viewport@38: error 2: source rectangle out of buffer bounds
SDL_VIDEODRIVER=wayland,x11 is present. Without that env var, osu-lazer successfully spawns an xwayland window to run in, but has other issues.
How to reproduce

Install osu-lazer from here
Make sure SDL_VIDEODRIVER=wayland,x11 is present as an environment variable
Run osu-lazer in command line
See output

Crash reports, logs, images, videos
This issue seems related, but the claim is made there that the issue is either with wayland, hyprland, or sdl... notably not osu itself.
In case it helps, here is my hyprland config. In case scaling is related, ill point out that I have 2 monitors, and both are at 1.25.
hyprland.conf

that's a protocol error. it's osu's fault. Well, could be SDL's too.

It started crashing because wlroots improved their checks, see https://gitlab.freedesktop.org/wlroots/wlroots/-/issues/3766

does this also happen on sway-git?

Just checked, this does not also happen on sway-git. Also, thank you very much for the quick reply 😁

"does not also happen".... so does it or doesnt?

so far it didn't, but i just realized that i didn't 100% ensure that osu-lazer wasn't running under xwayland, so im gonna go do that now and report back

ok confirmed, running SDL_VIDEODRIVER=wayland osu-lazer works just fine

odd

can you git bisect the issue just to make sure it's a wlroots bump causing this?

Sure, I'll get back to you with that shortly

Even more odd: I'm on arch, sdl 2.28.5-1, hyprland v0.33.1-31-g8f384878 and osu-lazer seems to work just fine for me

Sorry for the delay... I was unfortunately unable to build hyprland on any commit but the latest, whether fully from source, or using the -git aur package...
I'd be happy to try bisecting again if I got some help though

in that case, please provide a log of osu when launched with WAYLAND_DEBUG=1

Here you go
osu-lazer_wayland_debug.log

this is an osu bug to me:
wl_surface@37 gets wp_viewport@38 which after some valid-looking viewports gets this:
[ 330254.136]  -> wp_viewport@38.set_source(0.00000000, 0.00000000, 3440.00000000, 1440.00000000)

later, wl_surface@37 gets wl_buffer@46 which is:
[ 330564.480]  -> zwp_linux_buffer_params_v1@48.create_immed(new id wl_buffer@46, 1595, 1738, 875713112, 0)

meaning you get a viewport source of 3440x1440 on a surface of 1595x1738.
Does this happen without display scaling too?

Just saw and tested this now, works fine without display scaling

did you accidentally test sway-git without scaling?
If not, could you provide the wayland debug log of osu on sway with scaling?

Aie aie aie, i tested on fully default sway-git... So, i would imagine that means without scaling... I'll go test again, this time with scaling! If it works, I'll provide the wayland debug log

Ok, so, when running osu-lazer in wayland mode on sway-git, with proper display scaling, the window shows up fullscreen at the correct aspect ratio, but with a decreased resolution. When i change the resolution in osu settings to 3440x1440, the osu window disappears and wp_viewport@38: error 2: source rectangle out of buffer bounds gets output to the terminal... In that case, even though i couldn't see the window, i could still hear the music.

Seems like when osu remembers the resolution, it crashes at launch on sway as well. However, after 1 crash on launch, the next launch spawns a window on my second monitor, also at a reduced resolution.

Some times, interacting with that second messed up launch of osu crashes sway instantly. Other times, trying to set the monitor back to my primary monitor causes sway to crash. Either way, with display scaling, osu-lazer doesn't behave the way it should on sway-git either...

then it's a problem with osu. Most likely their interaction with SDL.
The wayland debug logs show a clear indication of invalid viewporter data. Try reporting to osu / SDL.


No longer builds on stable cargo

I went to build the server and got the following error. Looks like it still builds fine on nightly.
Not a huge issue but the README says to use stable rust/cargo.
➜  rust-analyzer git:(master) ✗ cargo xtask install
error: failed to parse manifest at `/Users/john/Documents/rust-analyzer/rust-analyzer/Cargo.toml`

Caused by:
  feature `profile-overrides` is required

this Cargo does not support nightly features, but if you
switch to nightly channel you can add
`cargo-features = ["profile-overrides"]` to enable this feature

I was able to fix same issue by updating to latest version of rust
rustup update

I was able to fix same issue by updating to latest version of rust
rustup update

That's embarrassing, you're totally right. Thanks!

Ugh. We have a version test in xtask, but it never gets to run because cargo can't compile it :confused:.

I had a similar issue because I installed something on my MacOS with brew that installed Rust which started conflicting with my rustup managed stable Rust.
So I first tried rustup update and calling $HOME/.rustup/toolchains/stable-x86_64-apple-darwin/bin/cargo, but that called a different cargo which then threw the error again.
I ended up uninstalling the brew formula which solved it. :tada:


add an option to enable or disable modal closing when backdrop is pressed

Hi, I would like to add an option to prevent modal from closing when backdrop is pressed.

Did you try using the isDisabled property ?
Or do you need to only disable the backdrop and keep the other interactions

Thanks u never tried that property. Turns out I can get the behavior I want with that.


Fixes false positive of trailing whitespaces in kdoc

Fixes https://github.com/detekt/detekt/issues/5713

I'm not 100% sure about this one. Dokka doesn't support this. So they are really trailing spaces with no meaning. I would vote to close pr and issue until Dokka decides to support it. Otherwise I feel that we are adding false negatives more than adding a real feature.

I'm not 100% sure about this one. Dokka doesn't support this. So they are really trailing spaces with no meaning. I would vote to close pr and issue until Dokka decides to support it. Otherwise I feel that we are adding false negatives more than adding a real feature.

Hi, @BraisGabin I don't have a strong opinion on this issue. It's just that it is marked as a false positive in the bug tracker that's why I picked this issue. I am okay with any closing this issue as well

I'm adding @TWiStErRob as reviewer here becuase it is his issue. I don't have a strong opinion here to be honest.

Until then, I think maybe opening a PR to update our docs and explain why those spaces are being flagged in "standard markdown" is the best way forward. That other PR could close the issue.

And what if we report an error as we do it now but we change the message? We could say that this feature of markdown is not supported and link to the open issue.

And what if we report an error as we do it now but we change the message? We could say that this feature of markdown is not supported and link to the open issue.

I like that!

Until then, I think maybe opening a PR to update our docs and explain why those spaces are being flagged in "standard markdown" is the best way forward. That other PR could close the issue.

And what if we report an error as we do it now but we change the message? We could say that this feature of markdown is not supported and link to the open issue.
Even so, I don't see too much value here. To me we could directly close this PR and the issues directly. I would leave that decission to @atulgpt as he is the one doing the heavy lifting here.

Hi @BraisGabin, @TWiStErRob I will update the PR incorporating your reviews

@detekt/maintainers We need to take a decission here. A go or a not go to this PR. To me this is a not go and just close the issue as "work as expected". If Dokka fix the issue I would be more than happy to add this but now until that moment.

Vote to close, but open another with a doc update to the rule (1 sentence) to explain what's happening.
[or maybe detect the case, and provide a clear edge case error message, probably not worth the effort/maintenance]

Same - good decision!

Yup makes sense closing the issue.. o/w ROI was not justified


Tags get parsed out of block quotes

The unit test added on the following branch is failing, and illustrates this issue:
https://github.com/lzilioli/md-macros/tree/expose-bug-tags-within-blockquotes
Comments in the code discuss the appropriate way to fix this: https://github.com/lzilioli/md-macros/blob/master/lib/parse-macros-from-md.ts#L93

This was fixed in c52d5b374e351ff908c38a167291a93777185632

This was fixed in c52d5b374e351ff908c38a167291a93777185632


Implement Trie In Python

Dear Mentor
I am GSSOC 21 participent. I would like to work on this issue.
Please assign this issue to me.
Thank you

Please assign me this. I can implement this using python

I would like to contribute to the above problem in java as I am a participant of GSSOC'21. Kindly assign this to me.

I am GSSOC'24 contributor and would like to contribute to this issue.
Thanks!


add WebpackUglifyParallel

Replace default UglifyJSPlugin with https://github.com/tradingview/webpack-uglify-parallel for parallelizing uglifyjs
Master:

UglifyParallel:

seems like appveyor got stuck?

Yep. That doesn’t sound very good. Is the plugin stable on Windows?

haven't tested it yet, I'll Bootcamp my mac for this.
btw, is this line expected?

I'm not sure.

another case of detective work 😄

closing this in favor of https://github.com/webpack-contrib/uglifyjs-webpack-plugin/pull/77 phew, installing windows on an old MacBook Pro is a pain...


Add back createUniqueName to ASTGen

Add back createUniqueName to ASTGen to work around an incremental build failure introduced by #1367 and #63962.

@swift-ci please smoke test


test add dbeaver and datagrip connect doris test

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


GPAD/GPI export from chado

Export GO annotations and supporting data in GPAD and GPI formats instead of GAF.
File format spec here:
http://wiki.geneontology.org/index.php/Final_GPAD_and_GPI_file_format
raise priority when GOC set a deadline - that's when we'll actually have to do it
Original comment by: mah11

@hdrabkin
when we do this, we should also try to include PRO
Harold:
Hi Val
Our GPI file here will have samples of how we associate them.
Here are a couple of examples
They are treated as separate identifiers (hence the PR in column 1), but then map to the mgi gene (MGI:MGI:))
Here’s one for an isoform:
PR           Q9ESQ8-2             mNPVF/iso:m2    pro-FMRFamide-related neuropeptide VF isoform m2 (mouse)                             protein  taxon:10090        MGI:MGI:1926488            UniProtKB:Q9ESQ8-2
Here’s one for a modified form (not of the example above).
PR           000030074           mLNP/Phos:1       protein lunapark phosphorylated 1 (mouse)                                protein  taxon:10090                MGI:MGI:1918115

upping to medium priority because GO has a timeline at last:

June 1st: finalize annotation properties and header
July 1st: review by contributing groups
October 1st: implementation

proposed spec: https://github.com/geneontology/go-annotation/blob/master/specs/gpad-gpi-2-0.md

Update: GO now has a ticket angling for comments on the GPAD/GPI spec:
https://github.com/geneontology/go-annotation/issues/2864
... so now seems like a good time for @kimrutherford to take a look and make sure there won't be any problems producing those files.

take a look and make sure there won't be any problems producing those files.

I think it won't be a problem.  The only part that will require a bit of care (if I'm reading it correctly) is the mapping from GO evidence codes to ECO.

Yeah. They've tried to include cross-references to GO codes in ECO, but IIRC there have been a few where mapping wasn't totally straightforward. Try looking at the "xref: GOECO:"  lines in ECO and see how much that covers.

It might be worth paying attention to this ticket - https://github.com/evidenceontology/evidenceontology/issues/251

Chris also recommends this: https://github.com/evidenceontology/evidenceontology/wiki/Gene-Ontology-GafEcoMapping

or the "derived" version might be better so we don't "have to walk up the ECO graph yourself when going from ECO -> GAF" ... although I think we're mostly concerned about going from GAF -> ECO
https://github.com/evidenceontology/evidenceontology/blob/master/gaf-eco-mapping-derived.txt

Returning to this ticket again now that GO is seeking sign-off on the spec (linked above) ... there are two main points for us -- one is the relations between terms/IDs and gene products that GO now wants, and the other is submitting extensions with the small set of relations that GO now allows (where we've retained some more specific ones locally).
Term-gene product relations for GPAD column 3:

For molecular function (F), use RO:0002327 'enables' (hideous usage, but it's what they've settled on) unless we have explicitly used contributes_to (RO:0002326).
For biological process (P), ignore all the blather and just always use RO:0002331 'involved in'.
For cellular component (C) it could be a bit tricky.

If we have used colocalizes_with anywhere, leave it (i.e. RO:0002325) as the relation, but I don't think we do use it any more.

Extension relations (also noted for GAF in #744):

Delete all "negated" extensions (i.e. ones that use not_happens_during or not_exists_during).
Convert a whole bunch of relations to RO:0002233 (has input):

has_direct_input
regulates_activity_of
has_regulation_target
directly_negatively_regulates
directly_positively_regulates

Convert occurs_at to BFO:0000066 (occurs in)
I don't think we're using regulates_expression_of, regulates_transcription_of, or regulates_translation_of, but if we ever do, convert them to (wait for it) RO:0002233 (has input).

Thanks Midori.  I'm very glad you have a handle on that.

It should be OK.  I don't recognise "if_descendant_of" though.

I don't recognise "if_descendant_of" though.

Don't worry, as long as it's clear how the file should come out. I cribbed "if_descendant_of" from website display config (it's not a relation that would end up in any output files).

In the GPI file do we need to put anything in columns 7 to 11?  They''re all optional.

As a first step I've added the code to write a GPI file during the nightly update.  That's the easy part of GPI/GPAD.
Here's a sample of the output:
http://curation.pombase.org/misc/gene_product_information_taxonid_4896.tsv

In the GPI file do we need to put anything in columns 7 to 11?

I've left those columns empty for now.
I'll chip away at implementing GPAD writing.

Great start; thanks!
It does need more tweaking (sorry to bear bad news).
This is probably the most important point:
We definitely shouldn't put the gene product description in column 2. That column is for the gene symbol; it's set up that way to accommodate species where the gene name and gene symbol are different (e.g. all those mad Drosophila names, where the symbols are usually abbreviations).
We might as well just put the gene name in both columns 2 and 3. It's redundant for us (and SGD) but I think it's the best workaround we've got.

In the GPI file do we need to put anything in columns 7 to 11? They're all optional.

Unfortunately, it's not quite that simple.

For protein-coding genes, we do have to put the UniProtKB accession in column 10. This is kind of buried, and if you think it looks not-entirely-consistent with "cardinality 0 or greater", well, I'm right there with ya.

On a related note, I'm finding the spec a bit woolly with respect to whether we can leave SO:0000704 in column 5 for all rows, or if we're actually required to use SO:0001217 for protein-coding genes (our feature type = protein coding) and SO:0001263 for the rest. Unless it would be a big pain, it might be worth using the more specific SO IDs.

Since we can't put the gene product description in column 2, we could include it in column 11 with the "go-annotation-summary" tag (e.g. go-annotation-summary=M phase inhibitor protein kinase Wee1). Despite using go-annotation-summary as the tag text, the description of allowed content is "A textual gene or gene product description.", so they'd better not complain.

Extension relations (also noted for GAF in #744):

I'm not sure what term ID to use for "exists_during".  There is a Typedef in gorel.obo with the id "exists_during".  Term IDs without a prefix look wrong to me.
It also has "xref: GOREL:0000032".  Maybe we should use that instead?  Any thoughts?

I'm not sure what term ID to use for "exists_during"

Some for: activated_by

For exists_during, watch this ticket: https://github.com/oborel/obo-relations/issues/384https://github.com/oborel/obo-relations/issues/384 ... and I guess use the GOREL thing in the meantime?
I think we can just ditch the extensions that use activated_by in what generate for GO -- we only have 4, and we may get round to changing or removing them anyway.

Thanks, I'll use that for now.

I've made these changes:

We might as well just put the gene name in both columns 2 and 3.

For protein-coding genes, we do have to put the UniProtKB accession in column 10.

Since we can't put the gene product description in column 2, we could include it in column 11 with the "go-annotation-summary" tag

I haven't fixed the SO term for the features yet.  Currently it's either SO:0000704 (gene) or SO:0000336 (pseudogene).  I'll fix that soon.

I've also had a first pass at the GAPD file.  It's not done yet. (Especially column 3 which current just says "dunno" on every row).

Chris also recommends this: https://github.com/evidenceontology/evidenceontology/wiki/Gene-Ontology-GafEcoMapping

The evidence column is populated using this GO-ECO mapping.
Here's an example: http://curation.pombase.org/misc/gene_product_annotation_data_taxonid_4896.tsv
From tomorrow (if all goes well) the in-progress GPI and GAPD files will be written out each night and should appear here:
https://curation.pombase.org/dumps/latest_build/misc/
I'll do some more work on the output tomorrow.

Extension relations (also noted for GAF in #744):

These rules are encoded in a new section of the config file called "extension_relation_mappings", currently at the end.  It looks like this for now.  If the value is null then that extension relation will not be written to the GPAD file.   Please tweak as needed.
    "gpad_gpi": {
      "extension_relation_mappings": {
        "not_happens_during": null,
        "not_exists_during": null,
        "activated_by": null,
        "exists_during": "GOREL:0000032",
        "has_direct_input": "RO:0002233",
        "regulates_activity_of": "RO:0002233",
        "has_regulation_target": "RO:0002233",
        "directly_negatively_regulates": "RO:0002233",
        "directly_positively_regulates": "RO:0002233",
        "regulates_expression_of": "RO:0002233",
        "regulates_transcription_of": "RO:0002233",
        "regulates_translation_of": "RO:0002233",
        "occurs_at": "BFO:0000066"
      }
    }

[various GPI fixes]

yay, thanks

(Especially column 3 which current just says "dunno" on every row)

I am highly sympathetic to this attitude.
The proto-GPAD looks like it's shaping up well, to the extent that I can tell. Thanks again.

If we have used colocalizes_with anywhere,

I can't see any examples in the nightly GAF file.

I don't recognise "if_descendant_of" though.

Don't worry, as long as it's clear how the file should come out.

Sorry, it's not clear to me.  Could you explain this more?  What does "if_descendant_of GO:0032991" mean?  Just "is_a/part_of GO:0032991"?
For now column 3 for CC annorations is BFO:0000050 if the term is_a GO:0032991 and RO:0001025 otherwise.  Let me know if that short include part_of GO:0032991 for BFO:0000050.
Am example is here:
http://curation.pombase.org/misc/gene_product_annotation_data_taxonid_4896.tsv

Unless it would be a big pain, it might be worth using the more specific SO IDs.

I've changed to using more specific gene SO IDs as you suggested.  Like SO:0001217 "protein_coding_gene" and SO:0001268 "snRNA_gene".  If less specific terms are needed we can change the output.
This is configured in yet another setting in the config file ("transcript_gene_so_term_map"), which is a map from the SO term of the transcript (from Chado) to the specific SO term to use for the gene in the GPI file.  We just use the general "gene" and "pseudogene" SO terms for genes in Chado hence the need for configuration.  This table could probably have been generated by inferring things directly from the Sequence Ontology but that was going to hurt my brain and the list isn't going to change often.
The table looks like this:
      "transcript_gene_so_term_map": {
        "SO:0000234": "SO:0001217",
        "SO:0000516": "SO:0000336",
        "SO:0000252": "SO:0001637",
        "SO:0000253": "SO:0001272",
        "SO:0000274": "SO:0001268",
        "SO:0000275": "SO:0001267",
        "SO:0000655": "SO:0001263"
      }

The updated file is here:
http://curation.pombase.org/misc/gene_product_information_taxonid_4896.tsv
Now that the files are getting closer to ready, do you know if there is a GPAD/GPI validator tool that we can test them on?

I've changed to using more specific gene SO IDs as you suggested. Like SO:0001217 "protein_coding_gene" and SO:0001268 "snRNA_gene".

That looks excellent. I don't think that column needs any further work.

What does "if_descendant_of GO:0032991" mean? Just "is_a/part_of GO:0032991"?

Yep, that's it. Sorry to have been overly cryptic.

For now column 3 for CC annotations is BFO:0000050 if the term is_a GO:0032991 and RO:0001025 otherwise. Let me know if that should include part_of GO:0032991 for BFO:0000050.

Yes, I think it should include part_of, and then it'll be ready for prime time.

do you know if there is a GPAD/GPI validator tool that we can test them on?

Aaahahahahahaha ha ha he's funny :P
Seriously, I haven't heard anything about a validation tool per se, but there's a woollier claim in the minutes from the July 28th GO annotation call that "Berkeley will have parsing scripts available to share and can otherwise assist in helping groups with the transition". So I guess ping them via the ticket they have open for comments? It's https://github.com/geneontology/go-annotation/issues/2864

Yes, I think it should include part_of, and then it'll be ready for prime time.

I've made that config and code change.  It looks look only there are only one term and two annotations where it makes a difference.
GO:0042788 polysomal ribosome: https://www.pombase.org/term/GO:0042788

So I guess ping them via the ticket they have open for comments?

Thanks for the suggestion.  I've done that.
Perhaps we're a bit ahead of the game?  I hope the GPAD/GPI spec doesn't change too much.  :-)

I was thinking about closing this issue then I noticed this comment:

when we do this, we should also try to include PRO

What does that involve?

While writing this essay, https://github.com/pombase/pombase-chado/issues/744#issuecomment-675251087, I realised that the GPAD output has "binds(...)" where it should have "with" entries due to: pombase/website#108
That needs fixing.

when we do this, we should also try to include PRO
What does that involve?

I don't know, but I suspect it might be something we could hive off into its own ticket, to be got round to in a while rather than making the rest of the GPAD/GPI export wait for it.

I suspect it might be something we could hive off into its own ticket,

I think so too.  I'll leave that for Val to summarise in a new issue when she's back from her world tour.

I'n not sure that anything needs doing especially for PRO.  If we use PRO as modified by forms that should be handled automatically? I would close. If anything is required we can open a new ticket once we know what it is.
Val

OK, thanks Val.
I'll do this then close the issue: https://github.com/pombase/pombase-chado/issues/276#issuecomment-675268875
Once GO start accepting or validating GPAD/GPI files I'll open new issues for any problems.

I realised that the GPAD output has "binds(...)" where it should have "with" entries due to: pombase/website#108

Fixed!  (After tonight's load)
So I'll close this issue and wait until GO are ready for GPAD/GPI files.
For reference, the files are here for now:
https://curation.pombase.org/dumps/latest_build/misc/gene_product_annotation_data_taxonid_4896.tsv
https://curation.pombase.org/dumps/latest_build/misc/gene_product_information_taxonid_4896.tsv
and are generated every night.


Clarify scope required for github token

Clarify scope required for github token and explain travis tokens.

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is n/a.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55b9f96...1f25bed. Read the comment docs.

Thanks!


New package: RationalRoots v0.1.0

Registering package: RationalRoots
Repository: https://github.com/Jutho/RationalRoots.jl
Created by: @Jutho
Version: v0.1.0
Commit: a6a568dc1eb766e4598c5914d05ccf05db91d181
Reviewed by: @Jutho
Reference: https://github.com/Jutho/RationalRoots.jl/commit/a6a568dc1eb766e4598c5914d05ccf05db91d181#commitcomment-34522613

Needs compat entries in the project file, at least one for Julia itself.

Fixed; now how to proceed? Close this and register again? I though there was another (quicker?) way, but I don't recall where to find the docs.

Just trigger registration again.

bump

Conventional wait time for a new package is three days, but I can merge early if you need it.

My apologies for being obnoxious, I was unaware of the policy and under the (false) impression that you would have merged it yesterday if not for the missing compat entries, which are now fixed. It would be nice in order to update other packages, but I can easily wait one more day.


RFC refactor: use structures for Multiplicative and Additive

[x] depends on: #1214
[x] depends on: #1217

This PR/issue depends on:

leanprover-community/mathlib4#1214
leanprover-community/mathlib4#1217
By Dependent Issues (🤖). Happy coding!

This PR/issue depends on:

leanprover-community/mathlib4#1214
leanprover-community/mathlib4#1217
By Dependent Issues (🤖). Happy coding!

This was briefly discussed on zulip.

Closed per https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/rw.20seeing.20through.20type.20synonym.3F/near/370592044


Add cache to travis

save 10 seconds

Are you sure cache works?
Read the first line here http://docs.travis-ci.com/user/caching/

I'm just testing it. And we are using container-based infrastructure

@matteocontrini It does works. Save 10 secs for each build


Fix svg content type

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement
Learn more about why HashiCorp requires a CLA and what the CLA includes
Have you signed the CLA already but the status is still pending? Recheck it.

Hi @marcin-piela! Thanks for working on this.
Verifying this led me into an interesting rabbit hole, but aside from that it does indeed seem like the +xml suffix is the current recommended MIME type for SVG, so I'm going to merge this. Thanks again!


SaaS and MySql / Posgresql

Hi,
At first look at this project it seems to be able to build a SaaS upon this, although mult-tenancy isn't really incorporated in this, at first glance. Is it a use case which is viable?
Second question: is it possible to use MySql or Postgres or another RDBMS instead of MongoDb?

Is it a use case which is viable?

Anything is viable if you put your mind to it.

is it possible to use MySql or Postgres or another RDBMS instead of MongoDb?

Sure. Just re-write all the models.


installation on localhost doesn't work

I tried to install on Ubuntu 18.04 with Php7-fpm and nginx

git clone the repo
chmod 777 the folder, so it can creat the install folder
call http://localhost/pH7-Social-Dating-CMS in firefox (with ublock origin and uMatrix addons)
select englich and click "Next step

Now the error occurs, the following page lacks the corect URL, it redirects to
http://_/pH7-Social-Dating-CMS/_install/?a=license

if I correct this to http://localhost/pH7-Social-Dating-CMS/install/?a=license I see the next page, but there it is not possible to continue. Whenever I click on "Next" I get back to http:///pH7-Social-Dating-CMS/_install/?a=license
I found this in the code:
<form method="post" action="http://_/pH7-Social-Dating-CMS/_install/?a=license">

That's very strange. It's the first time I see such an error!

Your error is from that line https://github.com/pH7Software/pH7-Social-Dating-CMS/blob/8a5eceaf111daac5b3537e79b953d37b0fc8d96c/_install/constants.php#L20
It looks like your SERVER_NAME from your server configuration isn't correctly set. Apparently, in your case, it is set to _ instead of localhost.

_ is the default on a local nginx.
It shouldn't break if the server defined host is differing from the used host

 $_SERVER['SERVER_HOST'];

Could work

Well if it could work, may I ask why you didn't try it out ? I don't understand how could $SERVER['SERVER_HOST'] would work ? How do you think that this array get populated ? By using the value sent to the PHP module by your web server. So if you web server recognize itself as "" then it will just fill $SERVER['SERVER_HOST'] with this. The other thing is to make a difference between user supplied variables and the one supplied by the web server. The first case can't be trusted and are subject to manipulation. So we use the second ones.
What's great with Open Source software is that when you know what to do, then you do it quite simply !

HTTP_HOST i would be the correct variable

FYI, the variables starting by HTTP are set by the client and can't be trusted.
Maybe you need to refresh some skills !
On October 26, 2018 7:40:31 AM EDT, Ruben Barkow<EMAIL_ADDRESS>wrote:

HTTP_HOST i would be the correct variable
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/pH7Software/pH7-Social-Dating-CMS/issues/337#issuecomment-433379904

--
Polyna-Maude R.-Summerside

I know but in this case this is what you want. This point is not about trust. At this point the installation should work with localhost as URL.
And that would work if you would use http_host as host part.

The problem is simply that you need to change the default configuration in NGINX.
There's design choice that we won't change to make it easier for you because you don't want or don't know how to change the configuration in NGINX.
Maybe you should learn that because something doesn't work out of the box, with only click click click it doesn't mean that it's broken. It mean that it needs to be configurer ;-) And believe-me, you'll have problem with other software too if you don't change the name of your host.
And by the way, smart guy ! A simple way to solve your problem is to add the default name of NGINX instance for local to your host file. That is : _      <IP_ADDRESS>
Case closed / done / over / have a nice and happy living.

I like those guys who fill your "issue" with ones that aren't real problem but more that they don't handle their configuration properly and after they tell you "do this, do that" but they don't even ask themselves why did some choice we're done in the beginning. Oh yes maybe we chose to use SERVER_NAME because it is always set by the server and never cause any problem but HTTP_HOST is filled by header and they often get messed up, like when using a redirecting proxy !

(First of all, I am not "one of those guys". I am a Server administrator and PHP Programmer since 20 Years, so I know how to config apache and nginx properly, but thats not the point. We shouldn't talk about judging others here. Lets stay focussed and go back to topic...)
I want to help here to create a great user experience for newcomers that try to install the app.
Why are you using complete URLs all through the project instead of relative URLs? This makes it problematic in the default nginx installation. If you would use relative URLs in the <form action""> there would never be any problems.
I suggest to add these lines in constants.php:
if($sDomain!=$_SERVER['HTTP_HOST']) {
  echo '
WARNING! please adapt your nginx configuration to point with the host "'.$_SERVER['HTTP_HOST'].'" to the install directory!
';
  $sDomain=$_SERVER['HTTP_HOST'];
}

Thank you

Thanks for the suggestion @rubo77! I really appreciate it :) I will publish a fix later on for the next release.


Add Code of Conduct content to README template

Adds feature discussed in #5512
When the --coc flag is set or otherwise enabled when generating a new
gem, a Code of Conduct is generated. This adds an additional link to
that Code of Conduct in the README, and adds default text for the
Code of Conduct based on language used in other popular ruby open
source libraries (bundler, rails).

lgtm 👍

🚢 :shipit:  @indirect :-) Please and thank you.

@snuggs 100%. Thanks for the insanely quick response @indirect!

@colby-swandale - I updated based on your suggestions; let me know if you'd like me to rebase to clean up history/remove second commit (or implement anything else) - thanks!

@rbcole looks like travis found a rubocop check that needs fixing, after that I think this is good to go!

@colby-swandale and @indirect - Updated to fix rubocop issues and make sure the markdown renders properly. Rebased to clean up history as well - let me know if you have anything else you'd like to change. Thanks again!

Cookin @robcole 🔥

Thanks!
@bundlerbot r+


Sort uploads by most recent

Uploads are currently sorted from oldest to newest.  This is the reverse of the way it should be.  Bonus points for adding in pagination cause there are going to be a ton of uploads in the future.

Compeleted in 8d89eba4d83fee623ff2e18bd0cb0ead78879341


Feedback on the data to be included in the getOriginationScheme API response

Data in the getOriginationScheme Response
What is required to uniquely identify a 'scheme' in this getOriginationScheme API? The following information might be useful in the context of LIXI2.
Recipient LIXICode
LIXI has maintained a list of participants in the ecosystem for over 20 years, each being assigned a LIXICode. These LIXICodes are required to be specified within the body of each LIXI2 lodgement for both the sender and recipient (the Action Service Provider in the context of CDR).
LIXIVersion
In LIXI2, each version of the published LIXI2 Schema is defined by a fixed value in the schema that specifies the required LIXIVersion that needs to be included within the body of the message.
LIXICustomVersion
In addition, there is a similar item for the LIXICustomVersion. Licensees can create custom versions that are more restrictive than the published standard - and licensees manage their versioning of this using this LIXICustomVersion item.  LIXI2 Licensees can use as many custom versions as they need for different purposes - different schemas for different product families, product packages, products, or even to specify the required data within successive stages within the origination process.
ProductCode
Each credit or deposit product within the application can be assigned a code maintained by the product provider (the ProductCode).
API Version
In the LIXI2 ecosystem, a single swagger specification API is often used to support the submission of messages conforming to one of many LIXI2 schemas, and can allow either a JSON or XML message body. This also allows the underlying supported schemas to evolve independently of the mechanics of the submission (ie the Open API Specification).
Summary
In the context of the experiment, the schemeId within the Action Service Provider's 'Get Origination Scheme' endpoint must provide sufficient information to retrieve (via some other mechanism if not within the CDR) the actual schema definitions that are suitable for submissions in the body of the applyForAccount API. Whilst the schemeID might be sufficient it would likely be more useful to include the combinations of LIXIVersion, ProductCode and LIXICustomVersion that can be used.
Either way, the question remains as to where must the Action Service Provider obtain the exact schemas and associated rules that define a complete and internally consistent submission. Some lenders are starting to implement Schematron definitions to better articulate the internal consistency requirements within a submission. These Schematron definitions provide the user of the API with much more granular requirements around the creation of a submission that will be successfully processed that can be (and should be) evaluated prior to submission. In my opinion there is no reason to preclude such a mechanism at this stage.

Awesome.  Thanks Shane.  Couple of questions...

Is there a specific format for LIXICode?
For LIXIVersion, LIXICustomerVersion and API Version: is there a specific format for the fields or should we just do them as string?
It may be good to include a mapping of CDR Product ID to LIXI ProductCode.  Does that make sense?
What is the best way to refer the client to Schematron?  Would a Schematron URI suffice?

LIXICodes are 6 or 7 character alphanumeric.
LIXIVersion & LIXICustomVersion should be string
API Version isn't specified by LIXI - Alex Bank might have a view
ProductCode is specified by the lender, and not maintained by LIXI - they could use the CDR Product ID as the LIXICode, so no mapping is required.
Schematron - a URI would make sense.

Great.  Thanks

I've added this stucture to v0.0.4 of the standard.
A couple of things to note:

I added in a base path field to advertise the endpoints.  Is this needed?
I added an optional mapping capability for product codes
I added a URI for a swagger if an API Version is present.  Not sure if I understood how that part works or not

I believe this issue has been addressed


Unable to populate text from JIRA screen

I am using JIRA 4.3.3.  I want to use this plugin to show different html tables based user's desires.  I wrote a javascript script that I am using in the Description field.  It displays a link with the name of a predefined "template" that the user can populate in the editor.  I have done similar scripts in the past that populate Group Pickers and Text fields.
My problem is that I an not able to get ANY text to be displayed in the editor (HTML or otherwise).  Any advise would be greatly apprecieated.
Here is the code I am using:

Load Template 1

Hi,
For security reasons the script tag is not allowed.  I won't be changing this in any future version, but to help you out here is how you can modify the jar file to allow script elements.
PLEASE NOTE!: Allowing javascript to run in user-editable elements is a VERY bad idea.  NEVER do this if the Jira instance is available to the public or to users not completely trustworthy (which basically means don't do this at all!) I won't accept responsibility if some malicious user uses javascript in a malicious way!  Still, if it's a critical feature read on...
Open the jar file and navigate to the includes directory. Edit the following files (directly if your zip tool allows, or copy the files somewhere and then back once you're done): tinymcerenderer_listener.js and tinymcerenderer_listener-min.js  (i'm not sure is modifying the first one is necessary but I tried with both).
There are two places where the invalid elements are defined. Look for the following line/part:
	invalid_elements : "input,applet,embed,xml,style,object"
Change this to:
	invalid_elements : "input,applet,embed,xml,style,object"```

Update the jar and restart Jira.

Best of luck

Thanks for the warnings.  I will take this into consideration.