[BUG]CMS Components- Slot form is not implemented

Describe the bug
Block category 'Form' is not working. After placing 'form' on layout in Shopware Experience it does not appear on website. Instead of the form there is information 'Slot form is not implemented yet!'
How to reproduce
Initial conditions: the category  'Movies & Toys' is active
Steps to reproduce the behavior:

Go to 'Shopping experiences' from Shopware
Choose layout called 'Test Shop page'
Click 'Settings' icon
Click 'block' icon
Select block category 'Form'
Add 'Form' to the Layout
Click 'Save' button in the upper right corner
Go to subcategory 'Movies & Toys' on our website
See error

Expected behavior
After placing 'form' on layout in Shopware Experience it appears on website. The form is working correctly.
Actual behavior
After placing 'form' on layout in Shopware Experience it does not appear on website. Instead of the form there is information 'Slot form is not implemented yet!'
Screenshots
'Form' block in Shopware 'Shopping Experiences' layout:

'Form' block on the website:

Devices (please complete the following information):
All devices

will be implemented with #666


Test refactoring

rename test modules so that they correspond to code modules
remove live/integration test suite that was tightly coupled to a Solr instance
create separate test modules for all query structs
refactor all tests, remove redundant tests, introduce test fixtures functions
improve test coverage

Pull Request Test Coverage Report for Build 272

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.7%) to 98.54%

Totals

Change from base Build 267:
0.7%

Covered Lines:
135

Relevant Lines:
137

💛  - Coveralls


Handle configurations for multiple images/kernels

Some users have multiple kernels installed. Booster handles them by generating images for all the kernels. It uses /etc/booster.yaml config for all the images. But there are cases when one would want to have different config options for different kernels. For example linux-lts based on Linux 5.4 does not support zstd compression and needs to use something like gzip while newer kernel could use zstd compression.
Add possibility to overwrite variant-specific config options. One proposal is to have an additional configuration section something like
compression: zstd # default value
...
variant:
  linux-lts:
    compression: gzip # overwrites the option for this particular variant
    modules: ...

Do you want to use only one config file ?
How about using every /etc/booster.d/*.yaml and adding options like
variant: linux-lts
image: /boot/path-to-image.img


feat(ts):  expose RunTimeGlobals in rspack

Summary
https://github.com/web-infra-dev/rspack/issues/3921
Test Plan

Because git is sensitive to the case of file names, I resubmitted the PR  https://github.com/web-infra-dev/rspack/pull/3973 @h-a-n-a

Close in favor of https://github.com/web-infra-dev/rspack/pull/3973


Map: wrap pointers safely

This PR brings in a rough approximation of the Eigen concept of Map, allowing to wrap pointers safely and assign structures (Matrix, Vector, Slice) to or from the memory underlying. The idea is that this can replace the copyTo() function in a more idiomatic manner, with less temporaries required due to direct interaction with Slices.

Coverage remained the same at 100.0% when pulling f7a9cc406b081e83f5cde5a7153fa98d3fe9a915 on pr-map into 18218c8f9c86474c76c5a9cc0aea3df47ed18dd6 on master.

This is perhaps more complicated than just adding a copyTo function to Slice and any other types we have in the future. Unless people think this is a better way to go I'll close this.

I like the idea of safely and expressively being able to assign to parts of a matrix since that is used a lot in the controllers and also setpoint generation. But I'm not fully aware of all the things necessary to realize it. It might be more efficient to have specific implementations for Vector2 and Vector3 because that's where it's used most. What is your take away after these tries?

It depends where we want to go with this. If we want to be able to take external memory and directly use it to multiply a matrix, or add to a matrix etc., without copying it to a Matrix class first, then we need something like this Map class. If all we will ever use it for is copying data to/from a Matrix, then I think we could put our time better elsewhere.

The only use case I usually run into is the msg/uORB topic containing an array or even separate float values. So I copy into a Matrix/Vector, process and copy to the next topic. But I'm not sure it's worth to improve that further because there are more burning things.

Let's leave this for later then.


Change temp type used for buffer indexing to ssize_t

Using 64-bit Python 2.7 on branch HEAD 3a85795dff01ff73c4b418c8bb6af92e7ee7eef0
When compiling a file that uses memoryviews, 64-bit MSVC outputs this warning:
.../with_cython.cpp(2819) : warning C4244: '+=' : conversion from 'Py_ssize_t' to 'long', possible loss of data

This warning refers to part of the buffer indexing code for a typed memoryview, which
computes the index (offset) values into the buffer when the given values are negative.
if (__pyx_t_2 < 0) {
  __pyx_t_2 += __pyx_v_section->BlockLight.shape[0];  /* warning */
  if (unlikely(__pyx_t_2 < 0)) __pyx_t_5 = 0;
} else if (unlikely(__pyx_t_2 >= __pyx_v_section->BlockLight.shape[0])) __pyx_t_5 = 0;
if (__pyx_t_3 < 0) {
  __pyx_t_3 += __pyx_v_section->BlockLight.shape[1];  /* warning */
  if (unlikely(__pyx_t_3 < 0)) __pyx_t_5 = 1;
} else if (unlikely(__pyx_t_3 >= __pyx_v_section->BlockLight.shape[1])) __pyx_t_5 = 1;
if (__pyx_t_4 < 0) {
  __pyx_t_4 += __pyx_v_section->BlockLight.shape[2];  /* warning */
  if (unlikely(__pyx_t_4 < 0)) __pyx_t_5 = 2;
} else if (unlikely(__pyx_t_4 >= __pyx_v_section->BlockLight.shape[2])) __pyx_t_5 = 2;
if (unlikely(__pyx_t_5 != -1)) {
  __Pyx_RaiseBufferIndexError(__pyx_t_5);
  {__pyx_filename = __pyx_f[0]; __pyx_lineno = 76; __pyx_clineno = __LINE__; goto __pyx_L1_error;}
}

After about an hour of research, learning about how Cython works by reading its
source code and with judicious use of PrintTree(), I've reached the following conclusion:
The cause of the problem is the variables __pyx_t_[2,3,4] which are typed long.
These are temporary variables created by IndexNode.buffer_lookup_code. The
types of the temps are taken from the types of the expressions found in the subscript.
To avoid truncating them, the type of the temps should be ssize_t, which is the same type as the elements of an ndarray's or a memoryview's shape.
(I expect that if the type of the expression is char, I might encounter a bug
where using a negative value to access an array larger than 256 on a dimension
gives a value from the wrong location.)
This patch changes IndexNode.buffer_lookup_code to always use ssize_t for
the type of its index temps.
--
Sidenote: I thought at first that this was just MSVC complaining again that my long
isn't long enough, but as it turned out, this looks like it can affect any
compiler - I tried casting an index expression to <char> and got the expected
conversion from 'Py_ssize_t' to 'char', possible loss of data warning,
confirming that the value isn't long enough for reasons unrelated to MSVC.

Thanks for the thorough analysis. I guess no-one noticed this before because it's just so uncommon to use anything but size_t or Py_ssize_t for index variables. Your fix is not entirely correct, though, because a) the user provided index variables might even have a type that is larger than ssize_t, and b) they might be unsigned, in which case the temporary variables should also be unsigned. I'm currently writing up a complete fix myself.

Ah, I thought about that. If the user passes an index whose type is larger than ssize_t, he has already entered the realm of undefined behavior as the ssize_t type of the array's shape has put a hard upper bound on index values.
Even if the user passes an unsigned type, the temporary value needs to be signed because of the __pyx_t_4 < 0. And if the user passes an unsigned size_t whose value is larger than the maximum positive value of ssize_t, that is again undefined behavior as that value cannot be a valid array index.

I'm more concerned about compiler warnings and code correctness than actual runtime value truncation. You're right that problematic large index values wouldn't occur in practice anyway. Note that the "<0" test isn't generated for unsigned types.

Yes, I think I should have checked if the index passed was unsigned and used the size_t type for the temp in that case.

I guess no-one noticed this before because it's just so uncommon to use anything but size_t or Py_ssize_t for index variables.

In this specific case, the type of the index variable wasn't explicitly declared - it was inferred from the expression (x & 0xf) where x is an int and the constant 0xf is a long - which, in the case of MSVC, isn't long enough (MSVC has its own special syntax for long long integer constants...bluh).

Fixed here:
https://github.com/cython/cython/commit/d962b018af56eba9ee9bece9366f95d4ae9f363e
I also added your fixes to the changelog: https://github.com/cython/cython/commit/6254fcc6f9e2e8739e043ef1d89ac502496a61a9
Thanks again!

Oh no, thank you for all your work on Cython. It's been incredible.


Matt this is your fault

fixed the footer and here is ur stuff

Here is what needs to be done in the future as of 5/25. This is also just off of the top of my head, so I will update it in the future.
*About Us: This is a mission statement I received a while ago. Do not post it yet, since I think it requires a bit of rewording and consideration. I really just wanted it documented somewhere, so I guess here is fine. It may go up later, so I wanted to post it here:
*Blue Hen Treats is a non-profit organization in Delaware. Our volunteers prepare various dehydrated foods for your enjoyment.

All income, beyond the cost of raw materials and incidentals, is donated to Delaware charities. There are no salaries. Presently, we operate out of the Belvedere Fire Co. commercial kitchen. Our future goal is to prepare our products in our own facility with the help of people with special needs.

*We need a page for which charities we will be donating to at a given time. It would be nice to have something aesthetically pleasing, such as a progress bar, but that can come at a later time.
*Please remove the Welcome to Jekyll! section of the blog
*We will get pictures and new people later, so that section will need to be edited in the future.
*Do you think you can integrate site analytics? I think that may help in telling us how to better the website in the future
*We will get a domain as soon as the website is deemed finished.

no need to do nao


Self-hosted GH runner: User interaction needed for restricted model downloads

The self-hosted GitHub runners would need the restricted models and datasets to already be cached, as there is no means to authenticate with Hugging Face or corresponding platforms due to the absence of user interaction in GitHub Actions. For example, LLAMA2 70B.
Potential fix:
Login to Hugging Face through Hugging Face cli when setting the system for self-hosted GitHub runner. This would store the token to cache and use every time when restricted models are downloaded.
Edit:
Hugging Face document for command line interface can be found here

yes @anandhu-eng . Thats a nice solution for github actions for llama2.

Hi @arjunsuresh , I think we have to add it for MIXTRAL-8x7B too.

@anandhu-eng We currently have this for both mixtral and llama2.


logs question

Hello,
I am running docker versions of flink using a docker-compose.yaml file as shown on DockerHub. When I request to view logs from the Taskmanager (Stdout tab) I get the following error
java.io.IOException: TaskManager log files are unavailable. Log file location not found in environment variable log.file or configuration key taskmanager.log.path.
There are no environment variables set. I thought the default log4j and /opt/flink/log would be used.
I am running Docker 17.12.0-ce on windows.
JP

the image seems to use log4j-console.properties and I can see LOG.info() statements on the console. Still no way to get anything created under /opt/flink/log - tried setting all sorts of environment and JVM variables;
@kuraninja 's setting above (along with a custom log4j.properties) did not help me get any output under /opt/flink/log so I reverted to
just adding FLINK_ENV_JAVA_OPTS=-Dlog.file=/opt/flink/log/taskmanager.log to  docker-compose.yaml and using the default log4j-console.properties
Running a task and inspecting the Logs under TaskManagers in the UI throws an exception
java.util.concurrent.CompletionException: java.io.IOException: TaskManager log files are unavailable. Log file could not be found at /opt/flink/log/taskmanager.log.

I am still struggling with logging under Docker. I have not restricted myself to a docker-compose file with one taskmanager and one jobmanager. Instead of deploying AMIDST-related code which involves dependencies, I simply upload WordCount.
As soon as it hits a System.println.out() I get the following entry
taskmanager_1  | The operator name DataSource (at getDefaultTextLineDataSet(WordCountData.java:70) (org.apache.flink.api.java.io.CollectionInputFormat)) exceeded the 80 characters length limit and was truncated.

Not sure what the above message means but it doesn't seem specific to println.
I fail to understand why the following snippet of code fails to output clear statements of progress:
public class ParallelMLExample {
        private static final Logger LOG = LoggerFactory.getLogger(ParallelMLExample.class);
        public static void main(String[] args) throws Exception {
                final ExecutionEnvironment env;
                env = ExecutionEnvironment.getExecutionEnvironment();
                DataSet<Integer> amounts = env.fromElements(1, 29, 40, 50);
                LOG.info("########## BEFORE UPDATEMODEL ##########");
                List<Integer> collect = amounts.filter(a -> a > 30).reduce((integer, t1) -> integer + t1).collect();
                LOG.info("########## AFTER UPDATEMODEL ##########");
                LOG.info(collect.get(0).toString());
        }
}

all I get on the terminal is the following:
jobmanager_1   | Starting Job Manager
jobmanager_1   | config file:
jobmanager_1   | jobmanager.rpc.address: jobmanager
jobmanager_1   | jobmanager.rpc.port: 6123
jobmanager_1   | jobmanager.heap.mb: 1024
jobmanager_1   | taskmanager.heap.mb: 1024
jobmanager_1   | taskmanager.numberOfTaskSlots: 1
jobmanager_1   | taskmanager.memory.preallocate: false
jobmanager_1   | parallelism.default: 1
jobmanager_1   | web.port: 8081
jobmanager_1   | blob.server.port: 6124
jobmanager_1   | query.server.port: 6125
jobmanager_1   | Starting jobmanager as a console application on host b66ca9ea48e2.
taskmanager_1  | Starting Task Manager
taskmanager_1  | config file:
taskmanager_1  | jobmanager.rpc.address: jobmanager
taskmanager_1  | jobmanager.rpc.port: 6123
taskmanager_1  | jobmanager.heap.mb: 1024
taskmanager_1  | taskmanager.heap.mb: 1024
taskmanager_1  | taskmanager.numberOfTaskSlots: 4
taskmanager_1  | taskmanager.memory.preallocate: false
taskmanager_1  | parallelism.default: 1
taskmanager_1  | web.port: 8081
taskmanager_1  | blob.server.port: 6124
taskmanager_1  | query.server.port: 6125
taskmanager_1  | Starting taskmanager as a console application on host 5f6223cd3e71.
jobmanager_1   | Slf4jLogger started
taskmanager_1  | Slf4jLogger started
jobmanager_1   | ########## BEFORE UPDATEMODEL ##########
taskmanager_1  | The operator name DataSource (at main(ParallelMLExample.java:30) (org.apache.flink.api.java.io.CollectionInputFormat)) exceeded the 80 characters length limit and was truncated.

Happy to close this if it's not strictly Docker related but as noob in Flink, it's hard to tell. Logging or debugging more complex algorithms has proven so far impossible.

closing as unrelated to logging. I can successfully see program output using start-cluster.sh but not using the docker images. Still figuring out.

@jdevoo have you had success logging using flink docker image, I am trying to configure logback.xml by specifying logger class in the the configuration, will try to see if it can enable logging from other class added during job running.

sort of; logging goes to the console; see example attached using cmder on Windows. Started Flink with docker-compose (1xTM, 1xJM) on the left. On the right, I run a third docker image to execute the job which collects output (docker run -t).

This might help.

One workaround is
https://ci.apache.org/projects/flink/flink-docs-stable/ops/deployment/kubernetes.html
Modify
then tail -f -n +1 log/taskmanager.log;
to
tail -F log/taskmanager.log;


Duplicated queries on Cart

Bug report
Issue Description
When we add/remove/update product to Cart, there are too many duplicated queries
Bagisto version

[ ] master branch
[x] 1.3.1
[ ] 1.3.0
[ ] 1.2.0

Steps to reproduce

Click add to cart button
Update quantity on cart item
Remove item from cart
Apply/remove coupon

Expected result
No duplicate queries
Actual result
400+ duplicated queries, the flow is really slow

Hi @jovicacosmic,
In carts and checkout pages mostly considered a fresh value that's why it looks like a duplicate. Even though debug bar itself causes slowness in the project.
But i will check and let you know what best can be done on this. I am marking this as optimization.

Hi @jovicacosmic,
As already one issue is open on this i.e.,
https://github.com/bagisto/bagisto/issues/4680
I am closing this one. Keep a track on the mentioned issue.


[TASK] Remove EXT:styleguide from packages

Since EXT:styleguide is shipped in the mono-repository without using any local path repository and explicit require section, it is expected to be there. Just removing the directory in typo3/sysext/styleguide still would advertise the "existence" of that package internally to the Composer-based package manager.
Thus, the following adjustments are required to composer.json:

drop replace.typo3/cms-styleguide
drop autoload.psr-4.TYPO3\CMS\Styleguide\
drop autoload-dev.psr-4.TYPO3\CMS\Styleguide\Tests\

The composer.json file is written directly by using the composer/composer package (which is a new dependency for typo3/darth now).
Fixes: #37

How to test?
bin/darth init
bin/darth package 13.0 main --type=snapshot
bin/darth package 12.4.10 v12.4.10

the 13.0 snapshot should not contain any ext:styleguide source code anymoregrep -iR styleguide publish/13.0/typo3_src-13.0

the (existing) 12.4.10 still shall be able to be packaged, the composer.json shall not be (much) different to the released version https://github.com/TYPO3/typo3/blob/v12.4.10/composer.json;
spoiler: it's different for keywords, which should be adjusted in the composer.json of the mono-repodiff -ru publish/12.4.10/typo3_src-12.4.10/composer.json typo3_src-12.4.10/composer.json
--- publish/12.4.10/typo3_src-12.4.10/composer.json	2024-01-22 13:31:30
+++ typo3_src-12.4.10/composer.json	2024-01-16 09:57:46
@@ -1,12 +1,7 @@
 {
 	"name": "typo3/cms",
 	"description": "TYPO3 CMS is a free open source Content Management Framework initially created by Kasper Skaarhoj and licensed under GNU/GPL.",
-	"keywords": [
-		"typo3",
-		"cms",
-		"content management system",
-		"extbase"
-	],
+	"keywords": ["typo3", "cms", "content management system", "extbase"],
 	"homepage": "https://typo3.org/",
 	"type": "typo3-cms-core",
 	"license": "GPL-2.0-or-later",
@@ -310,8 +305,8 @@
 			"TYPO3Tests\\TestEid\\": "typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_eid/Classes/",
 			"TYPO3Tests\\FluidTest\\": "typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/fluid_test/Classes/",
 			"TYPO3Tests\\TestTranslate\\": "typo3/sysext/fluid/Tests/Functional/Fixtures/Extensions/test_translate/Classes/",
-			"TYPO3Tests\\FormCachingTests\\": "typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Extensions/form_caching_tests/Classes/",
-			"TYPO3Tests\\IrreTutorial\\": "typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/",
+			"TYPO3Tests\\FormCachingTests\\" : "typo3/sysext/form/Tests/Functional/RequestHandling/Fixtures/Extensions/form_caching_tests/Classes/",
+			"TYPO3Tests\\IrreTutorial\\" : "typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/",
 			"TYPO3Tests\\RequestMirror\\": "typo3/sysext/frontend/Tests/Functional/Fixtures/Extensions/test_request_mirror/Classes/",
 			"TYPO3Tests\\TestValidators\\": "typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/test_validators/Classes/",
 			"TYPO3Tests\\TestDatahandler\\": "typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler/Classes

Thank you for the work


event.isShiftClick() does not work

I use SmartInvs 1.2.7 on my paper 1.12.2 localhost server
I faced such problem that event.isShiftClick() is not processed. Moreover, event.getClick() never returns me SHIFT_LEFT or SHIFT_RIGHT
Is this a bug?

Try to build the project and generate a new jar, with me it worked.
the latest build of this plugin on maven dates back to March 2019.


Implemented new deployment during crd creation.

@gianarb It's merge time :angel:

All done!! Thanks


How to make a "superuser" administrator member?

Using Dexie Cloud Access Control, as far as I can tell from the documentation and my small experiments, no single web authenticated user would ever be able to maintain full manage access to any potentially future stored object.
As far as I understand currently, users can be granted full manage permissions to existing realms, through roles or direct membership, and the permissions can be scoped to individual tables, but the primary beast is the realm. I can't grant an individual full manage to all objects in a given table, just a realm.
From the REST API or Cloud CLI a user could be given administrator access on all known realms at a point in time through memberships.
But any authenticated ACCESS_DB scope user (the default with the Zero config setup) could come and create a new realm and add items into any schema exposed table in those new realms.
No existing user other than the creator (and a GLOBAL_WRITE, GLOBAL_READ scope user) could see, edit or delete that data.
So to make a traditional (I'm from a Django background) superuser, I would need to implement custom authentication, and request a token for that user with GLOBAL_READ and GLOBAL_WRITE.
I'm opening this issue to ask if my understanding is correct, not reporting a bug!
p.s. I'm not sure I'd want to actually have a superuser yet, I'm just trying to imagine how I would go about rebuilding an existing django / pouchdb / couchdb app in Dexie. It may well be better not to fight the paradigm. It may just be that the Zero Config access control granting ACCESS_DB to all users might not suit certain use cases.
p.p.s Would a custom authentication that granted no scopes, but set up role memberships prevent any authenticated user from adding things the server does not want them to?

You're right that in the zero-authentication case, there's no way to become a superuser. You'd need to do server-to-server call to the token endpoint, using a client ID and secret to request such a token with a GLOBAL_READ and/or GLOBAL_WRITE scope. A superuser can utilize a token to query the REST API, but the sync endpoint is currently not tested to sync the entire DB as a superuser but just the realms that the user has access to as a normal or unauthorized user (unauthorized users can also sync but only from the public realm). The sync endpoint should conceptually work for a superuser also - just that the use case would probably not be to sync it to a Dexie instance (as it could easily return too much data for the client to handle in indexedDB). I might be wrong here but I would not put too much effort in testing that out right now unless I'd see a compelling use case for it.

Thanks, the amount of data more required for a superuser over a normal user is not necessarily significant for us. In a use case where you want all users to see most of the data (it is not heavily realm-sharded like the canonical todo list example) it should not make much of a difference.
It's a good reminder though to think about that weight of data on the client, In our case over time. We did run into issue with that in our pouch/couch app eventually, more in the performance of an initial synchronisation than actual space limits on the client though.
All good, my investigations continue, but slowly!

Ah, this is what I'm doing - the server-to-server thing, with the server allowing just the super-user to do whatever I need with that level of access. I've made it work, but I'm unconvinced I'm not fighting the paradigm with it to date.

Ah, this is what I'm doing - the server-to-server thing, with the server allowing just the super-user to do whatever I need with that level of access. I've made it work, but I'm unconvinced I'm not fighting the paradigm with it to date.

The way @phil-w does it is by requesting the token using his own server-side code and there it is possible to add more scopes. This can also be achieved by configuring the fetchTokens parameter to a custom endpoint to request tokens with arbitrary claims. Currently that also means you need to implement your own authentication flow and cannot reuse the email OTP flow out of the box. But @phil-w solves that by leaving the built in authentication but then offers another api that elevates the token.
I wouldn't say that it's fighting the paradigm but rather find ways around the current limitations.

This is true.
I also used auth.js as an auth provider, and that worked with Dexie Cloud very well and was an easy integrate.
I decided that way wasn't useful for me, because auth.js is OpenAuth2 based (a good thing), OpenAuth doesn't work well for API authentication when you have mobile devices as well as PWAs to deal with. It's annoying as it's fine if it's just a browser, but mobile is a killer with "in app browsers" being necessary as it's essentially a HTML thing. That one is definitely working against a paradigm!
Hence I'm working with Dexie Cloud's own auth, which avoids that hassle.


look up environment variables instead of passing as extra-args

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:
/kind bug

/kind cleanup

/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

/lgtm

@vjayaramrh whenever you can, can you update the PR description?

/approve


Problems with BRAF K483M?

I am observing various problems with the variant page for BRAF K483M.

This variant appears in typeahead searches but nothing happens if I select it.
If I go to the BRAF page and click on this variant, I am taken to some results but not to the URL that appears when I hover over that variant...

This is the URL I see when I hover over K483M:
https://civic.genome.wustl.edu/#/events/genes/5/summary/variants/581/summary#variant
That page does not seem to load.
In the admin interface I see pending revisions for this variant but in the UI, I can't seem to find them...

I am observing similar problems with B2M S14.  Again there are outstanding revisions that I can see in the admin interface but I can't seem to access them in the site:
https://civic.genome.wustl.edu/#/events/genes/537/summary/variants/616/summary#variant
I can see B2M S14 in typeahead search but selecting it does not work.

Also having a similar problem with JAK2 F547.  I can not access EID1568.
Strange things happen when I try to select it.  I can view other JAK2 variants.  I can select F547, but it does not highlight on the variant name on left.  I see EID1568, but if I try to select that evidence record I get directed to another EID instead of that one...  All three of these examples I have found so far seem to follow this pattern.  All have outstanding revisions according to the admin interface that at present can not be reviewed/approved in the UI.

This looks like it was an issue related to the new MyVariantInfo data that popped up when we had proper coordinates with which to query the API but didn't receive an expected response back. I've fixed the issue and these links all seem to be working now!

Confirmed.  All of the problems I was having related to these appear to be resolved now.  Thanks!


Revision and workflow demo data

Depends on https://github.com/wagtail/bakerydemo/pull/436
I've created some page revisions manually for the recipe page 'Hot Cross Bun' and home page 'Welcome to the Wagtail Bakery!'. I also went through the moderator approval workflow so there is some demo data available for that feature too.
A draft revision for Person snippet 'Muddy Waters' was also created.
Furthermore, I fabricated some revisions using the following code:
import random
from django.contrib.auth.models import User
from wagtail.models import Page

user = User.objects.all()

# Exclude the root page (id=1) and the home page (id=60)
for page in Page.objects.all().exclude(pk__in=[60, 1]).specific():
    # Choose a random user who 'performed' the action
    user = random.choice(users)
    page.save_revision(log_action="wagtail.create", user=user).save()
    page.save_revision(log_action="wagtail.edit", user=user).publish(user=user)

@laymonage not all demo data is generated, for some pages I saved some revisions manually and actually changed some fields. I also used the workflow feature which relies on some revisions existed.
Do you think we can handle generating the following steps programmatically?

Change some content
Go through the workflow process

Do you think we can handle generating the following steps programmatically?

Change some content
Go through the workflow process

We can 😄
To change the content, we can do something like:
page.title = f"{page.title} (edited)"
page.save_revision(user=some_user)

For workflows, we can try following the tests in: https://github.com/wagtail/wagtail/blob/main/wagtail/tests/test_workflow.py#L121 which does not rely on the test client.

That said, honestly I'm not sure if the workflows data should be in bakerydemo's initial data. I agree the revisions would be handy, as some of the UI in Wagtail assumes that all pages have at least one revision. However, for workflows, it might be a bit weird to start off a bakerydemo instance and seeing that you have pages in workflows already. And it's not going to take a long time to test the workflows yourself now that we have the editor and moderator users in the fixtures.

@laymonage why would the revision data being big be an issue? I suggested doing this with revisions data because as far as I could tell doing this programmatically in load_initial_data would cause problems. It means exporting fixtures will always generate data we don’t want for models that have a revision associated.

For workflows – from my perspective this is the same issue as any other feature of the CMS, where yes we can manually input data, but then it means all kinds of testing scenarios where we need this data are slower (even if just by a bit), and prone to inconsistencies.

@Stormheg I’ve tried to rebase your PR after merging #436 and review the changes but for some reason I don’t see any revisions or workflow content, I’m not sure what went wrong.
Could you take a look and fix / tell me what I did wrong?

Hi @thibaudcolas

for some reason I don’t see any revisions or workflow content, I’m not sure what went wrong.

It looks like the revision and workflow data relies on the page log which I did not include in the dump. I've fixed that now 😓
I've also...

Add two recipe PDF documents for the recipes you linked to in https://github.com/wagtail/bakerydemo/issues/440. I've added links them on their the respective recipe pages.
Added two comments on the 'welcome to the wagtail bakery' page
Added the welcome page to a workflow
Added the Muddy Waters person snippet to a workflow by the german user
Manually changed some data on the 'bread and circuses' page to test the comparison view
Locked the 'contact us' page

The dashboard now looks like this for the admin user. Could you re-review please?

Alright, I believe I’ve updated the fixtures according to the test content from Storm, with the feedback from Sage taken into account.
Changes from previous version:

Different "related" PDFs rather than same recipes (c0fed93)
Muddy Waters and all other revision-aware snippets have at least a "created" revision", and a "published" revision for draft-aware models.
Muddy Waters is submitted for moderation, started by the editor user (whose group now has permissions to submit for moderation all draft-aware models).
The homepage and Muddy Waters workflows are started by the editor user, and all things in workflows include changes.


Settings -> General -> Devices values configuration, labels for Topic and Value seem to be swapped

Checklist

[X]  I am not using Home Assistant. Or: a developer has told me to come here.
[X] I have checked the troubleshooting section and my problem is not described there.
[X] I have read the changelog and my problem is not mentioned there.

Deploy method
Snap
Z-Wave JS UI version
9.8.2.c09b638
ZwaveJS version
12.4.3
Describe the bug
When defining values for a device type in Settings, General, Device Values configuration, if you click the drop down by Value you get a list of topics. When you click on topics, you get a freeform text box.
To Reproduce
Go to settings, general, device values, click on "New Value", select a device type (whatever, just pick one), then click on value. See drop down box of topics.
Expected behavior
Should get a list of topics when clicking on topics, and a freeform text box for the value.
Additional context
Whoops. Confused the heck out of me the first time!

According to this, for my sensor I'm modifying the topic "F", and giving it the value "temperature scale". Mmmm, think I'm actually modifying the topic "temperature scale" and giving it the value "F".

@TheKorn2 Nope you understood it wrong.
You Select a device type, then you select the ValueID (in your case it's Temperature Scale) and you assign to that valueId a specific topic that will be used instead of it's id appended adter the name/location prefix for all devices with the same type

So does this essentially remap (or maybe copy) from one topic to another?
I thought it was trying to make a user defined default value for a topic.

So does this essentially remap (or maybe copy) from one topic to another?

It just sets a CUSTOM topic for that valueID. You override the default topic that valueId would be published on MQTT and that depends on your gateway/mqtt settings. Please read docs


Remove worker.py

Originally, #1960 was intended to do this, but in some review back-and-forth the commit removing the file was dropped. Let's actually remove the file.

https://pulpito-ng.ceph.com/runs/zack-2024-07-31_18:04:53-teuthology:no-ceph-main-distro-default-null


Adding the name of a pin within the exported image

Overview
This PR introduces a new feature addressing the request made in issue #17, which highlighted the need to add a title or name to the exported images. The implementation adds the frameAndTitleBitmap function within the PinViewerFragment class, dynamically adjusts the text size of the title and ensures it fits within the designated area on the exported image.
Example:

At the moment an image is cut off at the bottom when I export a pattern:


Fixed curl call for single file upload

Also added the default decoder explicitly as a best practise.

Description

Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[x] Documentation

Issues Fixed or Closed by This PR

#2466

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Thanks for contributing to Strawberry! 🎉 You've been invited to join
the Strawberry GraphQL organisation 😊
You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67
And don't forget to join our discord server: https://strawberry.rocks/discord 🔥


feat: Enable server side flow control by default with the option to turn it off

This change enables sending flow control settings automatically to the server.
If flowControl.maxMessages > 0 or flowControl.maxBytes > 0, flow control will
be enforced at the server side (in addition to the client side).
This behavior is enabled by default and SubscriberOptions.useLegacyFlowControl can be used for users who would
like to opt-out of this feature in case they encounter issues with server side
flow control.

Hi, the tests seem to be pending for abnormally long time. Can we check if they are blocked?
Thanks.


Refactor: extract frontend localization to function

This adds 3 helper functions:

Two are for getting a field from a model (eg city from a job) in the right locale, depending on whether the result may be null or not.
One function to replace the "get locale from react-intl, throw exception if not en or fr" pattern we have all over the place.

I've tried to replace every instance of getting a localized field with the use of a function (except for cases where we're constructing a new model or using both locales).
I've only replaced getting locale from react-intl in a few places so far.
Notes:

Having all localization go through a couple functions will make it easy to do things like add null checking for everything.
The type checking on these functions is actually helpful. You should get code-completion options, for only the localizable fields.
This assumes that all the models use the same pattern for localization, but it also makes it easy to change (eg if we had to do something like the common-language-package refactor again).

Recreated this PR with a cleaner git history #2833


Keystroke sound effects

I would like to be able to add sound effects of different keys, for example able to add one sound when ctrl-copy another for paste another when pressing space, enter.  Also perhaps array of 5 different when typing letters and numbers to add some randomness to it. This would allow me to add typewriter sounds or others if I want to change. Should be possible to switch on/off aswell.

Hmm I'm not too sold on the idea of sound in it.  I'll tentatively close this but if a pull request comes in that implements it I'll consider adding it


DOC: Add Remote module PyPI update notice in Release guide

Add Remote module PyPI update notice in Release guide.
Take advantage of the commit to add the name of the script that commit
e0fe885 left behind.

PR Checklist

[ ] Makes breaking changes
[ ] Makes design changes
[ ] Adds the License notice to new files.
[ ] Adds Python wrapping.
[ ] Adds tests and baseline comparison (quantitative).
[ ] Adds test data.
[ ] Adds Examples to ITKExamples
[x] Adds Documentation.

Refer to the ITK Software Guide for
further development details if necessary.

Related to #657.

Will need to be rebased on master after #654 gets merged to have green CI builds.

9ee60ee rebased on master.


chore: Fix spelling errors

Correct spelling is a great way to look more professional and demonstrate higher quality. And it catches a surprisingly number of actual errors, too.
Following up on https://github.com/aws-controllers-k8s/iam-controller/pull/78
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/lgtm

/lgtm


[TRG 2.05] Create .tractusx metafile and place it in the root of the repository

Introduction
In the TRG 2.05 there is the requirement that we should create a .tractusx metafile and place it in the root repository
What needs to be done?

[ ] Create metafile
[ ] Make sure that the structure is correct and compliant with the TRG requirements

Included in the following release v1.0.0-alpha


openfront.vercel.app gives error 500

I was going to check out how Openfront looks like, but demo/website gives error 500. Is it just temporary hickup, or has there been something bigger broken down behind the scenes?

Hey, thanks for pointing this out. The vercel deployment was missing the FRONTEND_URL variable which prevented fetch calls in getServerSideProps.


Add size to Link

This PR adds size property to Link class. It enables to expose the size of parameters in a Link, Chain, ChainList and all objects inherited from Link. If a Link contains uninitialized parameters, a warning message will show up to notify users that the size of them will not be counted in the resulting size.

It seems that this property counts the number of parameters directly attached to the link of interest only and does not includes parameters of its children. It depends on use cases which specification is suitable. Could you share me what use case do you have in mind?

@delta2323 Thanks for the comment. Link's namedparams() surely returns the parameters which was directly attached, but Chain's and ChainList's namedparams() will traverse all children, so if size is called from Chain or ChainList, it returns the count of all parameters in the model. For example, If I call this size property from the MLP model defined in the official MNIST example, I got:
In [1]: from train_mnist import MLP
model = MLP(
In [2]: model = MLP(100, 10)

In [3]: model.size
/Users/shunta/lib/chainer/chainer/link.py:578: UserWarning: /l1/W has not been initialized, so the resulting size will not include the number of parameters in it.
  'not include the number of parameters in it.'.format(name))
/Users/shunta/lib/chainer/chainer/link.py:578: UserWarning: /l2/W has not been initialized, so the resulting size will not include the number of parameters in it.
  'not include the number of parameters in it.'.format(name))
/Users/shunta/lib/chainer/chainer/link.py:578: UserWarning: /l3/W has not been initialized, so the resulting size will not include the number of parameters in it.
  'not include the number of parameters in it.'.format(name))
Out[3]: 210

initially because some Links has not been initialized (the above warnings are intended), but after the initial forward pass, I got:
In [6]: model(np.zeros((1, 10), dtype=np.float32))
Out[6]: variable([[ 0.,  0.,  0.,  0.,  0.,  0.,  0.,  0.,  0.,  0.]])

In [7]: model.size
Out[7]: 12210

so it works correctly and I think it's useful to know the "number of parameters" for ensuring the correctness of implementation or comparing the model's heaviness with others.

@mitmul Sorry, I wrongly remembered the specification of namedparams. I agree with this specification as users typically want to know the number of parameters in a whole architecture.

Could you add unittests that check Link.param works even for Chain and ChainList. Also, could you add unittests that the warning is not issued when parameters are initialized via first forward propagation.

I think size is too general for this feature. It originates from ndarray.size, which represents the size of a tensor. It's straight-forward that the size of a tensor represents the number of elements. Variable also has size attribute. I think it's ok because a Variable is inherently a tensor.
On the other hand, a Link can be thought of as a collection of Parameters. In this perspective, size should represent the numer of registered Parameters. So I think we need some other name...
Do you come up with any?

@delta2323 OK, I'll add tests for Chain and ChainList.
@niboshi I understand what you pointed out. How about count or count_params ?

@mitmul

@niboshi I understand what you pointed out. How about count or count_params ?

Keras uses count_params, so it might be ok, but the term "parameter" has the different meanings between Chainer and Keras. It might be still confusing in Chainer. I would prefer more descriptive name such as count_param_scalars.
By the way, I would doubt the need of this feature.
You can write sum(param.size or 0 for param in link.params) if we change a behavior of Parameter.size a bit (to return None if it's uninitialized, which is a reasonable change IMO). It's easy and straight-forward for users to write such code.
I think it's better to hear other members' opinions as well.

Thank you for your comment.
Hmm, count_param_scalars is too long, so I think count_params() or count is enough. Well, as for the necessity, this is not intended to fill a lack of functionality of Chainer, so it's surely not essential, but just to improve the usability. I've heard that some users wonder how to know the number of trainable parameters in a model in Chainer sometimes because other frameworks provide the way to know it easily. And in the way by sum(...), it's difficult to know which parameters are not counted in the returned value, but Link.count raises warnings for them. So providing count or count_params() for Link is reasonable for this reason I think.

IMO, if it is a routine work to count the number of parameters in a link, it would not be strange that Chainer provides it as a utility function.

It seems to me that count, count_params could also remind some users of the number of instances of Parameter attached to a link in the same way size does. So far, I could not come up with some word that is simple enough but definitely points out either of the meanings.

@mitmul @niboshi Do you have some idea how to proceed this issue?

I prefer count_params among the names mentioned above. How do you think?

I think it is a good idea to align the semantics of property names if possible to other frameworks. In that sense, count_params is OK (It seems PyTorch and Caffe do not have this functionality. We list up parameters inside a model and sum them up explicitly).

@mitmul @niboshi How do you think of it?

I'll change the name to count_params

@delta2323 @niboshi I changed the name and added tests for Chain and ChainList.

I think it finished to fix them to follow reviews.

@delta2323 LGTM to me except the last comment.
Could you merge if LGTM to you?

@mitmul Please use testing.assert_warns.

Strictly speaking, this PR does not check count_params does not throw warning when all parameters are initialized. So could you add such test cases?

@delta2323 @niboshi assert_warns seems not to return any values when it calls yield, so we can't receive any information about the number of warning raised. https://github.com/chainer/chainer/blob/master/chainer/testing/helper.py#L53
I think we need to use catch_warnings directly OR stop checking the number of warnings. What should I do?

IMO, you can just use testing.assert_warns, and ignore the number of warnings.

Codecov Report

Merging #3101 into master will decrease coverage by 0.6%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3101      +/-   ##
==========================================
- Coverage   89.12%   88.52%   -0.61%
==========================================
  Files         320      320
  Lines       21211    21227      +16
==========================================
- Hits        18905    18791     -114
- Misses       2306     2436     +130

Impacted Files
Coverage Δ

chainer/link.py
90% <100%> (+0.2%)
:arrow_up:

chainer/serializers/hdf5.py
24.65% <0%> (-73.98%)
:arrow_down:

chainer/functions/theano/theano_function.py
28.57% <0%> (-71.43%)
:arrow_down:

chainer/links/theano/theano_function.py
25% <0%> (-59.38%)
:arrow_down:

chainer/testing/serializer.py
93.33% <0%> (-6.67%)
:arrow_down:

...ner/functions/normalization/layer_normalization.py
94.73% <0%> (-5.27%)
:arrow_down:

chainer/functions/array/stack.py
95.65% <0%> (-4.35%)
:arrow_down:

chainer/functions/array/broadcast.py
95.77% <0%> (-4.23%)
:arrow_down:

chainer/functions/math/erf.py
93.93% <0%> (-3.04%)
:arrow_down:

chainer/functions/math/erfc.py
93.93% <0%> (-3.04%)
:arrow_down:

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1759406...07609af. Read the comment docs.

Hmm, but I succeeded to count the number of warnings. When two warnings raised, len(w) returns 2 if I used catch_warnings. But I guess this doesn't work in Python2.

@delta2323 Well, I added the test cases for this:

Strictly speaking, this PR does not check count_params does not throw warning when all parameters are initialized. So could you add such test cases?

I understand it's possible to count the warnings in Python 3, by using catch_warnings.
What I wonder is if it matters.
(No matter how many warnings is raised, the observable outcome to the users is the same.)

@delta2323 Thanks for the comment. I fixed the points.

Jenkins, test this please.

@niboshi LGTM. Could you merge this PR if you approve it?

LGTM!


Miscellaneous fixes

TODO: Reporting was fixed earlier
common: Add open_path_with_atomic_rename to utils and use it in node download
setup.cfg: Bump cassandra-driver to 3.20.2

made cassandra driver optional -> PRs should be much faster until we get cassandra really in

Actually I'll park this until https://github.com/aiven/astacus/pull/73 goes in - it seems that rohmu will have explicit default cloud provider dependencies, but pghoard(.rohmu) does not.


question about model

why the train and the test model are different.The output of the base_model in training is features,but in testing is the result of fc,and i also don't know why the test_fc's out_feature is the sum of act,comp,and reg.what'more,the input to the stpp in training and testing are different.

Read the paper. The answers to your questions are in Sec. 4


Enhance TIN handling of constraint borders

Improved the handling of data mappings between edges and constraints.

The polygon constraint logic is now coded and tested.  I have posted the code as part of Tinfour version 2.1.3-SNAPSHOT.
The demo module includes a new test application called  MultiSquareConstraintTest.java which performs automatic testing of constraint look-up operations.  It also provides an example of one way to use the API.
I will be investing the treatment of line-based constraints in the near future.

Made some progress in terms of supporting cases where linear constraints (chains of multiple points that do not form closed polygons) and region constraints (closed polygons) are handled correctly. In geophysical applications, linear constraints are sometimes used to represent abrupt changes in a surface (such as a cliff or escarpment or shoreline) while polygon constraints represent regions.
The figure below was created using the Tinfour MixedModeConstraintTest.java application.  The dashed lines are linear constraints. The orange and yellow areas are polygon constraints and are drawn with solid lines for borders.   The light gray lines are all ordinary (non-constrained) edges.
I hope to be finishing up this feature within the week.

This feature is now fully integrated into the Tinfour code and is part of the 2.1.3 release.
This issue is now closed.


retrieve IHttpStitchingRequestInterceptor from combined services to allow override from application services

retrieve IHttpStitchingRequestInterceptor from combined services to allow override from application services
Closes #5458

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@michaelstaib is there any thing i can do to to speed up the process of releasing this pr

Sorry for the wait .... let me check.


[CRASH] CoreFoundation _inputStreamCallbackFunc

This is on version 3.1.0.
Here's the stack trace via Crashlytics:
Crashed: com.vluxe.starscream.websocket
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x0000000edb473fd0
0  libobjc.A.dylib                0x1aadfb530 objc_msgSend + 16
1  libobjc.A.dylib                0x1aaddf22c -[NSObject respondsToSelector:] + 36
2  CoreFoundation                 0x1abb8276c _inputStreamCallbackFunc + 56
3  CoreFoundation                 0x1abbadbc8 _signalEventSync + 216
4  CoreFoundation                 0x1abbadc28 ___signalEventQueue_block_invoke + 24
5  libdispatch.dylib              0x1ab648a38 _dispatch_call_block_and_release + 24
6  libdispatch.dylib              0x1ab6497d4 _dispatch_client_callout + 16
7  libdispatch.dylib              0x1ab5f2320 _dispatch_lane_serial_drain$VARIANT$mp + 592
8  libdispatch.dylib              0x1ab5f2e3c _dispatch_lane_invoke$VARIANT$mp + 428
9  libdispatch.dylib              0x1ab5fb4a8 _dispatch_workloop_worker_thread + 596
10 libsystem_pthread.dylib        0x1ab829114 _pthread_wqthread + 304
11 libsystem_pthread.dylib        0x1ab82bcd4 start_wqthread + 4

Happening to me as well. Same stack trace

I have this problem as well. Same stack trace

I'm still seeing this crash after reverting to 3.0.6.

I see same crashes on 3.1.0

I'm also conforming the same crash & stack trace, crashing up to ~10-20 times per day.

 I hope soon we all can use URLSession Websocket implementation. :)

As @fassko said, these issue are tough to deal with and debug with nothing more than a small piece of a backtrace. 4.0.0 refactor how connection logic is handle and should make this specific error no longer relevant in he codebase. Please upgrade and see if that fixes the issue and open a new issue if any questions or concerns arise with the new version. Thanks!

This crash became very frequent for my iOS 10 and 11 users when I updated Starscream from 3.0.5 to 4.0.0.  Based on logs, there's a strong correlation between the socket disconnecting and this crash.

I did a little bit of investigation into this issue. If the application releases the websocket instance before the disconnect is completed the FoundationTransport is released but it has not yet been stopped. So messages to its delegate will still get fired and will result in this crash.
I'm not sure what the right solution is to the problem; however, deinit in FoundationTransport to do the right cleanup or ensuring that engine doesn't release the transport until it is finished stopping (the stop is currently async, and only weakly holds onto self in the completion handler).
Otherwise the client needs to wait until the socket has been completely closed before releasing its instance.
A simple test for this problem:
Connect a websocket and then...
        webSocket.delegate = nil
        webSocket.disconnect()
        webSocket = nil

When I updated from 4.0.0 to 4.0.4 this crash was reintroduced.


both WeChat and slack links are dead

both WeChat and slack links are dead, maybe needs a more effective way to keep the WeChat invitation image active

I think I encountered the same problem. WeChat QR code expired and cannot join Slack via invitation.

It works thank you!

The WeChat qrcode still not working though

but at least we have one valid way to communicate, I am also waiting for the reply for the QRCode you asked in slack 🤣

Sorry for it. WeChat has been sent in slack, We'll update the link later 😣


Add Cut-Link data structure implementation

Add Cut-Link data structure implementation with unit tests.

Moved here: https://github.com/williamfiset/Algorithms/issues/81


Make missing translations in any locale fallback to default locale

So, I had something like:
locales/en/common.json
{
  "hello": "hello",
  "world": "world",
}

locales/es/common.json
{
  "hello": "hola",
}

So, when I used t('common:world'), in Spanish it would show literally common:world, instead of the default text in the default locale: world
Therefore, this is a request for you to add support for such thing. Thanks in advance.

You can configure it by doing the following:
{
  // ...rest of config
  "loadLocaleFrom": async (lang, ns) => {
     const locales = await import(`./locales/${lang}/${ns}.json`).then((m) => m.default)
     const defaultLocales = await import(`./locales/en/${ns}.json`).then((m) => m.default)
     return { ...defaultLocales, ...locales }
   }
}

By default, it is not interesting to do it because it downloads 2 dictionaries for each page and it is better that whoever wants to configure it.

You can configure it by doing the following:
{
  // ...rest of config
  "loadLocaleFrom": async (lang, ns) => {
     const locales = await import(`./locales/${lang}/${ns}.json`).then((m) => m.default)
     const defaultLocales = await import(`./locales/en/${ns}.json`).then((m) => m.default)
     return { ...defaultLocales, ...locales }
   }
}

By default, it is not interesting to do it because it downloads 2 dictionaries for each page and it is better that whoever wants to configure it.

I was missing this feature too.
Maybe this custom loader can be used in development while for the build process the plugin triggers this loader and stores the result ({ ...defaultLocales, ...locales }) in single language dictionaries again.

I was missing this feature too.
Maybe this custom loader can be used in development while for the build process the plugin triggers this loader and stores the result ({ ...defaultLocales, ...locales }) in single language dictionaries again.

+1 on this. This is something other translations libraries provide so i was suprised to see it didn't fallback out the box. I understand its for performance reasons. Maybe there could be some opt-in like you described.
btw im not sure if I should be voting for this feature here or here

I understand its for performance reasons. Maybe there could be some opt-in like you described.

With an additional build step that is triggered when next.js builds the app there would be no performance hit as the app would use the single file for the requested locale, already merged with the fallback language.
@aralroca maybe you can use something from https://github.com/vercel/next.js/discussions/17479 to create the merged file(s) before webpack includes the locales.


Always do group expansion for CheckAccess subjects

Which issue this PR addresses:
Fixes: ARO-9261
What this PR does / why we need it:
Refer to the IcM in JIRA, CheckAccess team informed that we need to send an additional field to give hints to CheckAccess that "group expansion" is needed.
Without group expansion, CheckAccess will not take into account what groups the principal belongs to.  That is, if a service principal A is a member of group B, and group B allows writing to a VNet, calling CheckAccess without the group expansion field will return a response that A is not allowed to write to a VNet.  With the group expansion hint, CheckAccess will return an allowed response, which is the behavior we want.
Test plan for issue:
I reproduced this by creating a Deny Assignment on a VNet resource from Azure Blueprint and made a group excluded from it.  The testing app principal is then added to the group.  After that I verified the following 2 scenarios:

Without group expansion, CheckAccess will return some actions as denied.  Here are the request, the response and the formatted response:
Request (notice the lack of the new _Claim_Name field in Subject)

{
    "Subject": {
        "Attributes": {
            "ObjectId": "69f8005a-36fe-4aa7-b161-c435d34133ad"
        }
    },
    "Actions": [
        {
            "Id": "Microsoft.ClassicNetwork/networkSecurityGroups/securityRules/write",
            "Attributes": null
        },
        {
            "Id": "Microsoft.Network/virtualNetworks/join/action",
            "Attributes": {}
        },
        {
            "Id": "Microsoft.Network/virtualNetworks/read",
            "Attributes": {}
        },
        {
            "Id": "Microsoft.Network/virtualNetworks/write",
            "Attributes": {}
        },
        {
            "Id": "Microsoft.Network/virtualNetworks/subnets/join/action",
            "Attributes": {}
        },
        {
            "Id": "Microsoft.Network/virtualNetworks/subnets/read",
            "Attributes": {}
        },
        {
            "Id": "Microsoft.Network/virtualNetworks/subnets/write",
            "Attributes": {}
        }
    ],
    "Resource": {
        "Id": "/subscriptions/60bf318d-6914-4105-a3b5-d0d2c10388c8/resourceGroups/nont-test-assignment/providers/Microsoft.Network/virtualNetworks/net-wgssmdvlnix4m",
        "Attributes": {}
    },
    "Environment": {
        "Attributes": null
    }
}

Response (Notice that some actions were reported as denied)
{
    "value": [
        {
            "accessDecision": "Denied",
            "actionId": "Microsoft.ClassicNetwork/networkSecurityGroups/securityRules/write",
            "isDataAction": false,
            "roleAssignment": null,
            "denyAssignment": {
                "isSystemProtected": true,
                "id": "d778a6b1157f2abbbe280825f36196f1",
                "name": "",
                "description": "",
                "permissions": [
                    {
                        "actions": [
                            "*"
                        ],
                        "notActions": [
                            "Microsoft.Authorization/locks/delete",
                            "*/read",
                            "Microsoft.Network/virtualNetworks/subnets/join/action"
                        ],
                        "dataActions": [],
                        "notDataActions": [],
                        "condition": "",
                        "conditionVersion": ""
                    }
                ],
                "scope": "/subscriptions/60bf318d-6914-4105-a3b5-d0d2c10388c8/resourceGroups/nont-test-assignment/providers/Microsoft.Network/virtualNetworks/net-wgssmdvlnix4m",
                "doNotApplyToChildScopes": false,
                "principals": [
                    {
                        "id": "00000000000000000000000000000000",
                        "type": "SystemDefined"
                    }
                ],
                "excludePrincipals": [
                    {
                        "id": "864512b599134a29b4c9ea8d1117f181",
                        "type": "ServicePrincipal"
                    },
                    {
                        "id": "1cae329ebf0b4456b8d4d74b1c5e7077",
                        "type": "Group"
                    }
                ],
                "condition": "",
                "conditionVersion": "",
                "effect": null
            },
            "timeToLiveInMs": 60000
        },
        {
            "accessDecision": "Denied",
            "actionId": "Microsoft.Network/virtualNetworks/join/action",
            "isDataAction": false,
            "roleAssignment": null,
            "denyAssignment": {
                "isSystemProtected": true,
                "id": "d778a6b1157f2abbbe280825f36196f1",
                "name": "",
                "description": "",
                "permissions": [
                    {
                        "actions": [
                            "*"
                        ],
                        "notActions": [
                            "Microsoft.Authorization/locks/delete",
                            "*/read",
                            "Microsoft.Network/virtualNetworks/subnets/join/action"
                        ],
                        "dataActions": [],
                        "notDataActions": [],
                        "condition": "",
                        "conditionVersion": ""
                    }
                ],
                "scope": "/subscriptions/60bf318d-6914-4105-a3b5-d0d2c10388c8/resourceGroups/nont-test-assignment/providers/Microsoft.Network/virtualNetworks/net-wgssmdvlnix4m",
                "doNotApplyToChildScopes": false,
                "principals": [
                    {
                        "id": "00000000000000000000000000000000",
                        "type": "SystemDefined"
                    }
                ],
                "excludePrincipals": [
                    {
                        "id": "864512b599134a29b4c9ea8d1117f181",
                        "type": "ServicePrincipal"
                    },
                    {
                        "id": "1cae329ebf0b4456b8d4d74b1c5e7077",
                        "type": "Group"
                    }
                ],
                "condition": "",
                "conditionVersion": "",
                "effect": null
            },
            "timeToLiveInMs": 60000
        },
        {
            "accessDecision": "Allowed",
            "actionId": "Microsoft.Network/virtualNetworks/read",
            "isDataAction": false,
            "roleAssignment": {
                "delegatedManagedIdentityResourceId": "",
                "id": "f7268f5c440747728341363f5446d35f",
                "roleDefinitionId": "b24988ac618042a0ab8820f7382dd24c",
                "principalId": "69f8005a36fe4aa7b161c435d34133ad",
                "principalType": "ServicePrincipal",
                "scope": "/subscriptions/60bf318d-6914-4105-a3b5-d0d2c10388c8",
                "condition": "",
                "conditionVersion": "",
                "canDelegate": false,
                "description": ""
            },
            "denyAssignment": null,
            "timeToLiveInMs": 60000
        },
        {
            "accessDecision": "Denied",
            "actionId": "Microsoft.Network/virtualNetworks/write",
            "isDataAction": false,
            "roleAssignment": null,
            "denyAssignment": {
                "isSystemProtected": true,
                "id": "d778a6b1157f2abbbe280825f36196f1",
                "name": "",
                "description": "",
                "permissions": [
                    {
                        "actions": [
                            "*"
                        ],
                        "notActions": [
                            "Microsoft.Authorization/locks/delete",
                            "*/read",
                            "Microsoft.Network/virtualNetworks/subnets/join/action"
                        ],
                        "dataActions": [],
                        "notDataActions": [],
                        "condition": "",
                        "conditionVersion": ""
                    }
                ],
                "scope": "/subscriptions/60bf318d-6914-4105-a3b5-d0d2c10388c8/resourceGroups/nont-test-assignment/providers/Microsoft.Network/virtualNetworks/net-wgssmdvlnix4m",
                "doNotApplyToChildScopes": false,
                "principals": [
                    {
                        "id": "00000000000000000000000000000000",
                        "type": "SystemDefined"
                    }
                ],
                "excludePrincipals": [
                    {
                        "id": "864512b599134a29b4c9ea8d1117f181",
                        "type": "ServicePrincipal"
                    },
                    {
                        "id": "1cae329ebf0b4456b8d4d74b1c5e7077",
                        "type": "Group"
                    }
                ],
                "condition": "",
                "conditionVersion": "",
                "effect": null
            },
            "timeToLiveInMs": 60000
        },
        {
            "accessDecision": "Allowed",
            "actionId": "Microsoft.Network/virtualNetworks/subnets/join/action",
            "isDataAction": false,
            "roleAssignment": {
                "delegatedManagedIdentityResourceId": "",
                "id": "f7268f5c440747728341363f5446d35f",
                "roleDefinitionId": "b24988ac618042a0ab8820f7382dd24c",
                "principalId": "69f8005a36fe4aa7b161c435d34133ad",
                "principalType": "ServicePrincipal",
                "scope": "/subscriptions/60bf318d-6914-4105-a3b5-d0d2c10388c8",
                "condition": "",
                "conditionVersion": "",
                "canDelegate": false,
                "description": ""
            },
            "denyAssignment": null,
            "timeToLiveInMs": 60000
        },
        {
            "accessDecision": "Allowed",
            "actionId": "Microsoft.Network/virtualNetworks/subnets/read",
            "isDataAction": false,
            "roleAssignment": {
                "delegatedManagedIdentityResourceId": "",
                "id": "f7268f5c440747728341363f5446d35f",
                "roleDefinitionId": "b24988ac618042a0ab8820f7382dd24c",
                "principalId": "69f8005a36fe4aa7b161c435d34133ad",
                "principalType": "ServicePrincipal",
                "scope": "/subscriptions/60bf318d-6914-4105-a3b5-d0d2c10388c8",
                "condition": "",
                "conditionVersion": "",
                "canDelegate": false,
                "description": ""
            },
            "denyAssignment": null,
            "timeToLiveInMs": 60000
        },
        {
            "accessDecision": "Denied",
            "actionId": "Microsoft.Network/virtualNetworks/subnets/write",
            "isDataAction": false,
            "roleAssignment": null,
            "denyAssignment": {
                "isSystemProtected": true,
                "id": "d778a6b1157f2abbbe280825f36196f1",
                "name": "",
                "description": "",
                "permissions": [
                    {
                        "actions": [
                            "*"
                        ],
                        "notActions": [
                            "Microsoft.Authorization/locks/delete",
                            "*/read",
                            "Microsoft.Network/virtualNetworks/subnets/join/action"
                        ],
                        "dataActions": [],
                        "notDataActions": [],
                        "condition": "",
                        "conditionVersion": ""
                    }
                ],
                "scope": "/subscriptions/60bf318d-6914-4105-a3b5-d0d2c10388c8/resourceGroups/nont-test-assignment/providers/Microsoft.Network/virtualNetworks/net-wgssmdvlnix4m",
                "doNotApplyToChildScopes": false,
                "principals": [
                    {
                        "id": "00000000000000000000000000000000",
                        "type": "SystemDefined"
                    }
                ],
                "excludePrincipals": [
                    {
                        "id": "864512b599134a29b4c9ea8d1117f181",
                        "type": "ServicePrincipal"
                    },
                    {
                        "id": "1cae329ebf0b4456b8d4d74b1c5e7077",
                        "type": "Group"
                    }
                ],
                "condition": "",
                "conditionVersion": "",
                "effect": null
            },
            "timeToLiveInMs": 60000
        }
    ],
    "nextLink": null
}

With group expansion hint
Request (Notice the additional field in Subject)

{
    "Subject": {
        "Attributes": {
            "ObjectId": "69f8005a-36fe-4aa7-b161-c435d34133ad",
            "_claim_names": "{\"groups\":\"ENGORGIO~!\"}"
        }
    },
    "Actions": [
        {
            "Id": "Microsoft.ClassicNetwork/networkSecurityGroups/securityRules/write",
            "Attributes": null
        },
        {
            "Id": "Microsoft.Network/virtualNetworks/join/action",
            "Attributes": {}
        },
        {
            "Id": "Microsoft.Network/virtualNetworks/read",
            "Attributes": {}
        },
        {
            "Id": "Microsoft.Network/virtualNetworks/write",
            "Attributes": {}
        },
        {
            "Id": "Microsoft.Network/virtualNetworks/subnets/join/action",
            "Attributes": {}
        },
        {
            "Id": "Microsoft.Network/virtualNetworks/subnets/read",
            "Attributes": {}
        },
        {
            "Id": "Microsoft.Network/virtualNetworks/subnets/write",
            "Attributes": {}
        }
    ],
    "Resource": {
        "Id": "/subscriptions/60bf318d-6914-4105-a3b5-d0d2c10388c8/resourceGroups/nont-test-assignment/providers/Microsoft.Network/virtualNetworks/net-wgssmdvlnix4m",
        "Attributes": {}
    },
    "Environment": {
        "Attributes": null
    }
}

Response (all actions are allowed)
{
    "value": [
        {
            "accessDecision": "Allowed",
            "actionId": "Microsoft.ClassicNetwork/networkSecurityGroups/securityRules/write",
            "isDataAction": false,
            "roleAssignment": {
                "delegatedManagedIdentityResourceId": "",
                "id": "f7268f5c440747728341363f5446d35f",
                "roleDefinitionId": "b24988ac618042a0ab8820f7382dd24c",
                "principalId": "69f8005a36fe4aa7b161c435d34133ad",
                "principalType": "ServicePrincipal",
                "scope": "/subscriptions/60bf318d-6914-4105-a3b5-d0d2c10388c8",
                "condition": "",
                "conditionVersion": "",
                "canDelegate": false,
                "description": ""
            },
            "denyAssignment": null,
            "timeToLiveInMs": 60000
        },
        {
            "accessDecision": "Allowed",
            "actionId": "Microsoft.Network/virtualNetworks/join/action",
            "isDataAction": false,
            "roleAssignment": {
                "delegatedManagedIdentityResourceId": "",
                "id": "f7268f5c440747728341363f5446d35f",
                "roleDefinitionId": "b24988ac618042a0ab8820f7382dd24c",
                "principalId": "69f8005a36fe4aa7b161c435d34133ad",
                "principalType": "ServicePrincipal",
                "scope": "/subscriptions/60bf318d-6914-4105-a3b5-d0d2c10388c8",
                "condition": "",
                "conditionVersion": "",
                "canDelegate": false,
                "description": ""
            },
            "denyAssignment": null,
            "timeToLiveInMs": 60000
        },
        {
            "accessDecision": "Allowed",
            "actionId": "Microsoft.Network/virtualNetworks/read",
            "isDataAction": false,
            "roleAssignment": {
                "delegatedManagedIdentityResourceId": "",
                "id": "f7268f5c440747728341363f5446d35f",
                "roleDefinitionId": "b24988ac618042a0ab8820f7382dd24c",
                "principalId": "69f8005a36fe4aa7b161c435d34133ad",
                "principalType": "ServicePrincipal",
                "scope": "/subscriptions/60bf318d-6914-4105-a3b5-d0d2c10388c8",
                "condition": "",
                "conditionVersion": "",
                "canDelegate": false,
                "description": ""
            },
            "denyAssignment": null,
            "timeToLiveInMs": 60000
        },
        {
            "accessDecision": "Allowed",
            "actionId": "Microsoft.Network/virtualNetworks/write",
            "isDataAction": false,
            "roleAssignment": {
                "delegatedManagedIdentityResourceId": "",
                "id": "f7268f5c440747728341363f5446d35f",
                "roleDefinitionId": "b24988ac618042a0ab8820f7382dd24c",
                "principalId": "69f8005a36fe4aa7b161c435d34133ad",
                "principalType": "ServicePrincipal",
                "scope": "/subscriptions/60bf318d-6914-4105-a3b5-d0d2c10388c8",
                "condition": "",
                "conditionVersion": "",
                "canDelegate": false,
                "description": ""
            },
            "denyAssignment": null,
            "timeToLiveInMs": 60000
        },
        {
            "accessDecision": "Allowed",
            "actionId": "Microsoft.Network/virtualNetworks/subnets/join/action",
            "isDataAction": false,
            "roleAssignment": {
                "delegatedManagedIdentityResourceId": "",
                "id": "f7268f5c440747728341363f5446d35f",
                "roleDefinitionId": "b24988ac618042a0ab8820f7382dd24c",
                "principalId": "69f8005a36fe4aa7b161c435d34133ad",
                "principalType": "ServicePrincipal",
                "scope": "/subscriptions/60bf318d-6914-4105-a3b5-d0d2c10388c8",
                "condition": "",
                "conditionVersion": "",
                "canDelegate": false,
                "description": ""
            },
            "denyAssignment": null,
            "timeToLiveInMs": 60000
        },
        {
            "accessDecision": "Allowed",
            "actionId": "Microsoft.Network/virtualNetworks/subnets/read",
            "isDataAction": false,
            "roleAssignment": {
                "delegatedManagedIdentityResourceId": "",
                "id": "f7268f5c440747728341363f5446d35f",
                "roleDefinitionId": "b24988ac618042a0ab8820f7382dd24c",
                "principalId": "69f8005a36fe4aa7b161c435d34133ad",
                "principalType": "ServicePrincipal",
                "scope": "/subscriptions/60bf318d-6914-4105-a3b5-d0d2c10388c8",
                "condition": "",
                "conditionVersion": "",
                "canDelegate": false,
                "description": ""
            },
            "denyAssignment": null,
            "timeToLiveInMs": 60000
        },
        {
            "accessDecision": "Allowed",
            "actionId": "Microsoft.Network/virtualNetworks/subnets/write",
            "isDataAction": false,
            "roleAssignment": {
                "delegatedManagedIdentityResourceId": "",
                "id": "f7268f5c440747728341363f5446d35f",
                "roleDefinitionId": "b24988ac618042a0ab8820f7382dd24c",
                "principalId": "69f8005a36fe4aa7b161c435d34133ad",
                "principalType": "ServicePrincipal",
                "scope": "/subscriptions/60bf318d-6914-4105-a3b5-d0d2c10388c8",
                "condition": "",
                "conditionVersion": "",
                "canDelegate": false,
                "description": ""
            },
            "denyAssignment": null,
            "timeToLiveInMs": 60000
        }
    ],
    "nextLink": null
}

Is there any documentation that needs to be updated for this PR?
N/A - the code should be clear enough.
How do you know this will function as expected in production?
E2E tests should be enough.

/azp run e2e,ci

/azp run ci

/azp run ci,e2e


Vital Strike Doesn't work for Ranged weapons

In the TTRPG Vital Strike isn't that good of an option for a ranged character but it works RAW and RAI, in Wrath it doesn't seem to work at all for ranged...

Realized this was submitted 2 days ago. I apologize


Is this repo still active?

We're having PR's sent to our project that uses this library but the fix would be more appropriate upstream here. If we supplied a PR to this project is it possible to have it merged and a new PyPi library pushed?
We'd be happy to help with the management of this library if that is a help? We use it and would be happy to contribute!

Yes, it is still active. We have recently move this project to Jazzband. Expect to see updated in the coming days, weeks and months.


Error-only logging for non-Debug Ok in Result.

Sometimes (e.g. when the result is a trait object), Debug is not available.
For this there can be a variant of log-derive that only logs errors, without successes.

Looks like a documentation issue. I tried only specifying err= without ok= and it worked.

Documentation PRs are more than welcome :)


SBTC内幕曝光，总量并非2100万，而是无上限

This issue tracker is only for technical issues related to sbtc-core.
Describe the issue
Can you reliably reproduce the issue?
If so, please list the steps to reproduce below:

Expected behaviour
Tell us what should happen
Actual behaviour
Tell us what happens instead
Screenshots.
If the issue is related to the GUI, screenshots can be added to this issue via drag & drop.
What version of sbtc-core are you using?
List the version number/commit ID, and if it is an official binary, self compiled or a distribution package such as PPA.
Machine specs:

OS:
CPU:
RAM:
Disk size:
Disk Type (HD/SDD):

Any extra information that might be useful in the debugging process.
This is normally the contents of a debug.log or config.log file. Raw text or a link to a pastebin type site are preferred.

证据呢

你这个 sx 到顶是在搞什么贵？？


unhandled :gun_error for websocket connection needing to be established before pushing

unknown message {:gun_error, #PID<0.16322.1>, {:badstate, 'Connection needs to be upgraded to Websocket before the gun:ws_send/1 function can be used.'}}
heard in Slipstream.Connection
please open an issue in NFIBrokerage/slipstream with this message and
any available information.

starting to feel a need for #4 so we can understand how a connection gets in a state where this happens

closed by https://github.com/NFIBrokerage/slipstream/commit/9d8fd35d6d6917b739e279d81a6f452afcfc5346

of course the first try finds us a nice :gun_error once the changes from #14 (see also #13) were merged. as you can see in the trace above (going bottom to top in reverse chronological order):

SendHeartbeat command that got translated into a ChannelClosed event with reason: :heartbeat_timeout
gun connection is up (this comes from a retry mechanism in gun)
gun connection is down
:gun_error about us not being able to send the heartbeat from 2 spans up
gun connection is up
SendHeartbeat command that would fail with :gun_error on the send


add .yarnrc.yml to advanced example solution

The .yarnrc.yml file is needed or else when yarn runs in docker build it will attempt to use PnP

Can you add the .yarnrc.yml to the other examples as well?

@Fleny113 I've added the other files and updated the comment. let me know if there is anything else I can do

@Fleny113 I've updated the inline comments


macOS Sequoia Wifi Icon "Searching..." networksetup -getairportnetwork en0 gives "You are not associated with an AirPort network."

Describe the bug

The Wi-Fi icon shows "Searching..." even though a connection is established. This is more of an FYI for other users!
Where is the error located
It seems that the command
networksetup -getairportnetwork en0

on macOS Sequoia 15.0 always returns You are not associated with an AirPort network.
Expected output
The SSID of the connected network.
Additional context
For reference: https://apple.stackexchange.com/questions/475370/networksetup-getairportnetwork-return-you-are-not-associated-with-an-airport-ne
A possible workaround for retrieving the SSID can be this command:
system_profiler SPAirPortDataType | awk '/Current Network/ {getline;$1=$1;print $0 | "tr -d ':'";exit}'

in this line https://github.com/Jean-Tinland/simple-bar/blob/master/lib/components/data/wifi.jsx#L50

Thanks! I'll keep that in mind when I upgrade to Sequoia 15.0 and I'll try to implement a fix allowing the network widget to work correctly on all macOS versions.

Fixed on master!


Allow overriding HTTP client type based on environment variable of RUBY_BUILD_HTTP_CLIENT

This allows users to choose appropriate HTTP client for ruby-build based on environment variable of RUBY_BUILD_HTTP_CLIENT. Since rbenv is based on shim script architecture, checking some command's availability based on the visibility in $PATH (e.g. type aria2c) is not actually appropriate way to do so.
The issue was originally reported as pyenv/pyenv#1126 that there was some problem in aria2c package of FreeBSD and python-build was always preferred to use it since it was on the top of the list. I think similar issue can happen with ruby-build too. This provides users to prepare some workaround for situations like that.

Thank you! 🙇


Auto log formatter

There should be a (maybe semi-sentient) being for log formatting embedded to the posting form. IT should automatically resolve nicknames and put them into angle braces. It should also remove timestamps.

I agree that we don't need timestamps in general. But they may be essential for some quotes. So this part should configurable. Also I think such formatter should exist on the approver's. It should work before the quote is approved so the approver has a chance to change something manually.

I was thinking about adding a "format shit" button near the "approve shit" one.

Yeah, that's what I'm talking about! :)


LGTM.com - false positive

Bogus "you should add a header guard" warning.
Seriously, I get how a public header should have header guards. But a private/project header file does not need such things. You already run the configure script and do a build on Ubuntu, just take the next step and make the install target to examine which headers actually get installed - those are the headers that need guards.
https://lgtm.com/projects/g/michaelrsweet/mxml/snapshot/fcc3bcea7099c38e60e3e0e70d0607bd3fcc84dc/files/mxml-private.h?sort=name&dir=ASC&mode=heatmap#x38846df31d23980:1

Thank you for the report. This query is perhaps more opinionated than our other queries, and I can see there is room for interpretation about what the best practice should be. It's the first time we've heard from someone who argues that internal headers should not use header guards.
It's easy to accidentally include an internal header twice, and this could either lead to either reduced performance or compile errors. The C++ Core Guidelines recommends using header guards for all header files: https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rs-guards.
With that said, I'm not sure why this query has a severity level of Warning. I've never seen a program that was incorrect because it was missing a header guard, so we could consider downgrading it to Recommendation. What do you think, @geoffw0?

@jbj My argument is not whether internal headers should or should not have header guards, just that the likelihood of multiple inclusion is typically much lower because they are not shared across projects like public headers are. Downgrading this to recommendation would be good for now, although if in the future you are able to detect headers that get installed then I would say installed headers elicit a warning while not installed headers elicit the recommendation.
(and aside from "stupid compiler tricks" I am forever wondering why C/C++/ObjC don't have an automatic guard against multiple inclusion by the preprocessor...)

In a small enough project, the likelihood of multiple inclusion is certainly low. For a project with tens or hundreds of internal header files and no include guards, I'd be surprised if there were no cases of multiple inclusion. A custom QL query could detect multiple inclusion by exploring the graph of which files include each other.
For queries that are not suitable for a particular project, you always have the option of hiding their results via .lgtm.yml. In any case, we're happy to hear your feedback about which queries are useful and which are not.

@jbj Should I have a ".lgtm.yaml" file in my project? Because right now I am using "lgtm.yaml" (no leading dot) and it seems to be ignored completely.
https://github.com/apple/cups/blob/master/lgtm.yaml

It can be with or without the dot, but the extension must be yml, not yaml.

With that said, I'm not sure why this query has a severity level of Warning. I've never seen a program that was incorrect because it was missing a header guard, so we could consider downgrading it to Recommendation. What do you think, @geoffw0?

Though this situation isn't impossible, it seems much more likely a missing header guard would cause compilation failure at some future time when more (potentially transitive) includes of the file are added to the project.  The qhelp for this query also suggests include cycles as a potential problem - though I think I'd consider that a separate issue with some overlaps to this one (and it sounds like the code in this case is organized well enough to avoid this).
In any case, the warning severity is appropriate for significant code maintenance / fragility problems, which on many projects describes results of this query.  I agree that the appropriate solution is to hide the query on this project.


Update README.md

Few small changes (kernels as a function of chi, not z. Links to the file. A few extra clarifications).

thanks, looks good, merging


Fieldnames are not correct

Whoops, thanks ;-)

It's one of the places where code coverage is missing (see https://codecov.io/github/django-oscar/django-oscar/src/oscar/apps/dashboard/offers/views.py?ref=c1cc5a36a27c54b72042323c8287aa4bb48f6e4a#l-36)
Are you able to add one? :-)

For a customer I have to improve the voucher stuff in the coming month, so I will try to add some tests for this as well :)


[CORE] Fixing the wrong plnkr link in CONTRIBUTING.md

There is a typo in the link which wrongly redirects to some ecommerce website
Fixes #116
Signed-off-by: Sivakumar Annamalai<EMAIL_ADDRESS>

@sivaah thanks for the contributions! This issue is being fixed as part of PR #114. CC @youdz

Closing this as this issue #116 is fixed as part of another  PR #114


Feature/gechina 94

https://vizzuality.atlassian.net/browse/GECHINA-94?atlOrigin=eyJpIjoiMDJlYmRhODdmMGU5NGYwZTk0MWRmZTE4NTQyMGRhMWIiLCJwIjoiaiJ9
Adds remaining fields to groups, subgroups and indicators:

widget_list.
slug.
default subgroup.
categories.
category filters.
default_visualization.

Yes! I was planning to merge yours and then adapt a few things to make it match and also use the FindOrCreateEntity in the widgets importer.


Reduce status updates

This introduce checkes when updating the status if the status
really changed from what is already there to prevent unnecessary
syncs to etcd.

/lgtm


Update vector_store_component.py to add keyword based search alongside semantic search

hi,i tried to make a PR in order to increase the accuracy of search results ,im not sure if i did it in the right way but i tried
the idea is to have both semantic search and traditional keyword based search in order to get more relevant results
i hope this feature be implemented in the project in future, maybe more modifications are needed

I want to highlight this PR, I think it is really important


can't climb over objects while choking (oxygen damage)

[BUG]
Description

Reporter by @Herbert Falsevor#3037 on discord.
Have not verified myself.
"-Cant jump over obstacles while choking. it makes it impossible to escape vacuum"

Vaulting do_after should probably ignore userdamage OR DoAfter needs a damage threshold.

Superseded by #5203


HTML ast nodes

This PR creates the initial HTML AST nodes.
For now I just created few nodes that should describe the HTML tree but probably I missed something, so I'd like to have some feedback before actually merging it.
I tried to divide the nodes in core, tags and attributes

core => root and comments
tags => normal tags, xml tag (old, should we support it? e.g. <?xml version="1.0" ?>) and doctype tag (e.g. <!DOCTYPE html>)
attributes => aria attributes, data attributes and attributes (class, style, etc.)

Is there something that I am missing or some information we'd want to have?
cc @sebmck

Is there a particular reason that HTMLDataAttribute and HTMLAriaAttribute need to be separate?

Probably not for the data attributes, but I was thinking that maybe the ARIA could/should be treated differently because of their nature: they accept only certain type of values, but I might be wrong: this is my first attempt into creating an AST.

Ah. Syntactically aria elements are the same as other elements. There's no validation done during parsing and all attribute values are just strings. I think it makes sense to just have a single HTMLAttribute.
I think we'll also want some sort of linting utils to make it easy to write lint rules against HTML and JSX, which would make having the separate aria types even less necessary. That would be pretty awesome and makes a lot of sense. I'm not sure what a possible abstraction would look like though. @bitpshr and @VictorHom might have some thoughts who have been working heavily on React/A11y rules.

Going to merge this since I have some free time now to work on the parser. Thank you @ematipico! Let's coordinate the next work on the Discord.


Export WIQL definition always saves the file name as the query name

Describe the bug
If I have a query and 'Edit' and then 'Export' the pop up asks me to name the file but the exported file name is always the query name and not the name I defined from the pop up.
Environment:

Browser [e.g. chrome, edge] = Chrome Version 131.0.6778.69 (Official Build) (64-bit)
hosted (Azure Devops)

Screenshots

To Reproduce
Steps to reproduce the behavior:

Create a query
Select 'Edit WIQL Query'
Select 'Export'
Give it a filename (not the same as the query name) e.g. ABC123
The file will be created as the query name

Expected behavior
That the file name would respect the file name I have set
Additional context
None

Hello, thank you for reporting this. I will test it and get back to you as soon as possible.


ODH 2.17 Tracker

Links to tracker issues for components planning updates in this.  Please update you manifests before August 23rd.
Release Date: August 26th
Comment Template for automation
#Release#
- component_name|release-branch|release-notes

List of component_name:

[ ] modelregistry
[ ] notebook-controller
[ ] notebooks
[ ] codeflare
[ ] ray
[ ] kueue
[ ] trainingoperator
[ ] trustyai
[ ] odh-dashboard
[ ] data-science-pipelines-operator
[ ] model-mesh
[ ] kserve
[ ] model-mesh-serving
[ ] odh-model-controller

#Release#

codeflare | https://github.com/opendatahub-io/codeflare-operator/tree/v1.5.0-odh | https://github.com/opendatahub-io/codeflare-operator/releases/tag/v1.5.0-odh
ray | https://github.com/opendatahub-io/kuberay/tree/v1.1.2-odh | https://github.com/opendatahub-io/kuberay/releases/tag/v1.1.2-odh
kueue | https://github.com/opendatahub-io/kueue/tree/v0.7.0-odh-test | https://github.com/opendatahub-io/kueue/releases/tag/v0.7.0-odh-test
trainingoperator | https://github.com/opendatahub-io/training-operator/tree/v1.8.0-odh | https://github.com/opendatahub-io/training-operator/releases/tag/v1.8.0-odh

#Release#

codeflare|https://github.com/opendatahub-io/codeflare-operator/tree/v1.7.0-odh|https://github.com/opendatahub-io/codeflare-operator/releases/tag/v1.7.0-odh
kueue|https://github.com/opendatahub-io/kueue/tree/v0.7.0-odh-1|https://github.com/opendatahub-io/kueue/releases/tag/v0.7.0-odh-1
ray|https://github.com/opendatahub-io/kuberay/tree/v1.1.1-08-14-2024|https://github.com/opendatahub-io/kuberay/releases/tag/v1.1.1-08-14-2024
trainingoperator|https://github.com/opendatahub-io/training-operator/tree/v1.8.0-odh-1|https://github.com/opendatahub-io/training-operator/releases/tag/v1.8.0-odh-1

Hi @AjayJagan, I've noticed that you've tested the release template for automation. I just wanted to check with you if the horizontal line between the two links is expected to not have a space.
The template has no spaces, but this causes both links to be mixed together into one, is this expected? Please see my comment above and the edited version. Let me know if I should revert to no spaces, thanks! :)

Hi @AjayJagan, I've noticed that you've tested the release template for automation. I just wanted to check with you if the horizontal line between the two links is expected to not have a space.
The template has no spaces, but this causes both links to be mixed together into one, is this expected? Please see my comment above and the edited version. Let me know if I should revert to no spaces, thanks! :)

Hi @ChristianZaccaria , The automation supports adding spaces in between the | so the one that is mentioned above is perfect :)

#Release#

data-science-pipelines-operator | https://github.com/opendatahub-io/data-science-pipelines-operator/tree/v2.5.x | https://github.com/opendatahub-io/data-science-pipelines-operator/releases/tag/v2.5.0

MR operator has some open PRs that we hope to close this week/weekend. Is it ok if we do a release by Monday end of day and update the manifests at that time?

#Release#
modelregistry | https://github.com/opendatahub-io/model-registry-operator/tree/release/v0.2.5 | https://github.com/opendatahub-io/model-registry-operator/releases/tag/v0.2.5

#Release#

notebooks| https://github.com/opendatahub-io/notebooks/tree/v1.21.0 | https://github.com/opendatahub-io/notebooks/releases/tag/v1.21.0
notebook-controller| https://github.com/opendatahub-io/kubeflow/tree/v1.7.0-15 | https://github.com/opendatahub-io/kubeflow/releases/tag/v1.7.0-15

#Release#

component | branch | tag |
modelmesh |  https://github.com/opendatahub-io/modelmesh/tree/release-0.12.0-rc0 | https://github.com/opendatahub-io/modelmesh/releases/tag/v<IP_ADDRESS>-rc0
model-mesh-serving | https://github.com/opendatahub-io/modelmesh-serving/tree/release-0.12.0-rc0 | https://github.com/opendatahub-io/modelmesh-serving/releases/tag/v<IP_ADDRESS>-rc0
kserve | https://github.com/opendatahub-io/kserve/tree/release-v0.12.1  | https://github.com/opendatahub-io/kserve/releases/tag/v<IP_ADDRESS>
odh-model-controller | https://github.com/opendatahub-io/odh-model-controller/tree/release-0.12.0 | https://github.com/opendatahub-io/odh-model-controller/releases/tag/v<IP_ADDRESS>

#Release#

odh-dashboard | https://github.com/opendatahub-io/odh-dashboard/tree/v2.25.2-odh | https://github.com/opendatahub-io/odh-dashboard/releases/tag/v2.25.2-odh

#Release#

trustyai|https://github.com/trustyai-explainability/trustyai-service-operator/tree/release/1.25.0|https://github.com/trustyai-explainability/trustyai-service-operator/releases/tag/v1.25.0

https://github.com/redhat-openshift-ecosystem/community-operators-prod/pull/5051


Error of PyTorch vs. CUDA version

I'm getting the following error.
Traceback (most recent call last):
  File "run.py", line 117, in <module>
    exp.train(setting)
  File "/nvme/git/ETSformer/exp/exp_main.py", line 140, in train
    dec_inp = torch.zeros_like(batch_y[:, -self.args.pred_len:, :]).float()
RuntimeError: CUDA error: no kernel image is available for execution on the device
CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1.

I believe this error is caused by the CUDA version being 11.7 (the newest), and is incompatible with the older torch version (1.11.0 specified in the requirements.txt).
I tried upgrading the torch version but found errors.  Would you please update the torch code to the latest?  I know that it breaks the transformer code as mentioned here:
https://github.com/pytorch/pytorch/issues/80569

I'll downgrade CUDA after reading this:
https://discuss.pytorch.org/t/latest-cuda-toolkit-release-11-7-is-it-compatible-with-pytorch/152824/5

I'll downgrade CUDA after reading this:
https://discuss.pytorch.org/t/latest-cuda-toolkit-release-11-7-is-it-compatible-with-pytorch/152824/5