Error init PeerConnection

Hi,
Using C# "TestNetCoreConsole" , v1.0.2 of Microsoft.MixedReality.WebRTC (nuget) and latest VS2019. .NET Core 3.0
I get this error after a few sec after calling:
await pc.InitializeAsync(config);

Fatal error in: ../../media/engine/webrtcvoiceengine.cc, line 253
last system error: 0
Check failed: adm()

What am I doing wrong here?

ADM is Audio Device Module. I assume you don't have a microphone, or you have a connected audio device that is not supported. Due to some bug in the Google code, this makes ADM initializing fail, and there is nothing we can do about it for now. See #140, #124 and the Google bug https://bugs.chromium.org/p/webrtc/issues/detail?id=11081. If you can please confirm this is a likely reason, I will close this bug as Duplicate of #124.

I have plenty of audio devices (35 input devices to be exact...) on the Win10 computer, the default is a microphone. I just tried a to set a different input device as default but same result.
Follow up question, will I be able to feed the Local audio with PCM data, and not use a sound card directly?

Not at the moment. I am working on this feature for video right now (#35), as this is the one feature everyone seems to want, and depending on how much signal we get from other users about the need for that for audio data we can also consider adding it. That would make sense I think. But it is not planned at the moment.
Currently audio data goes directly from a sound card (capture) to another remote sound card (output) without any possible way to intervene; this is how it is implemented by Google. There is some on-going work to open up the PCM data on the receiving side, for example to inject it into the Unity DSP engine and enable spatial audio etc., see #92 and #99.

Note that if 1 audio device is not supported, then no matter which one you select, the ADM init will fail. The only workaround is to physically disconnect the unsupported device(s). For example anything that has not 1/2/4 audio channels, like Azure Kinect DK (7-microphone array) will make ADM init fail. There is a patch on Google's master branch to fix that strange behavior, and only test the actually selected device (not all the available one) but it's not merged into MixedReality-WebRTC.

In my case I 'm only interested in audio (no need for video at all). But I need to be able to feed and receive PCM data. Preferably  that the WebRTC handles the jitter and buffer, and with a callback for when PCM data is available (for receiving).
And future feature request is to be able to use other audio codecs, even Linear PCM. I know browsers do not support that, but P2P between two Windows App will work.

I will try the code on a laptop where I have only the standard audio devices,
not a boat load full of IP-Audio devices...

For audio codecs, PCM mu-law (PCMU) and A-law (PCMA) are both supported. Here's the full list of audio codecs I get on my local Desktop machine:
a=rtpmap:111 opus/48000/2
a=rtpmap:103 ISAC/16000
a=rtpmap:104 ISAC/32000
a=rtpmap:9 G722/8000
a=rtpmap:102 ILBC/8000
a=rtpmap:0 PCMU/8000
a=rtpmap:8 PCMA/8000
a=rtpmap:106 CN/32000
a=rtpmap:105 CN/16000
a=rtpmap:13 CN/8000
a=rtpmap:110 telephone-event/48000
a=rtpmap:112 telephone-event/32000
a=rtpmap:113 telephone-event/16000
a=rtpmap:126 telephone-event/8000

Those are the typical WebRTC codecs, OPUS is great.
The audio transport in WebRTC is RTP and what you fill the payload with could be a custom Codec (say MP3). It will not work to a browser to between two Win Console app as long as I have control over the RTP.
Any way that's not important for now, PCM in/out instead of sound-card so I can integrate this hopefully great WebRTC library is what I need most.

Just to confirm, when testing on my laptop with just the standard audio devices. I get no ADM error.  It works, I can connect and pass audio between two console apps.

Right, thanks for the feedback. I am pretty sure this is ADM1 again doing it's overly aggressive checks. I will see if we can backport that fix from Google.
I am closing this as duplicate of #124 as they have the same root cause.

Still no fix for this?


Trace response body contents if the http status code is an error.

I'd like to surface more information in tracing about why a request fails,
starting with the service's failure response

:star: 🔑

⭐ ✒

Unfortunately, I think this is a dangerous feature.  We have no control over what sort of data is in response bodies -- it could potentially contain passwords, credit card numbers, health information, etc.  Instead, I think we should use headers to communicate errors.  linkerd, for instance, sets an l5d-err header with linkerd-generated errors.  I think we should use something like this rather than arbitrary response bodies.


Microsoft.VisualStudio.SDK package should probably not have a dependency on Microsoft.VisualStudio.DpiAwareness

Installed products

Microsoft.VisualStudio.SDK 16.0.200

Description
It seems that Microsoft.VisualStudio.DpiAwareness is obsolete and contains only type forwarders to Microsoft.VisualStudio.Utilities. However it is still included in the SDK package.
It makes it impossible to reference anything included in Microsoft.VisualStudio.DpiAwareness  because of CS0433.
Current behavior
error CS0433: The type 'DpiAwareness' exists in both 'Microsoft.VisualStudio.DpiAwareness, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Utilities, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
Expected behavior
Referencing DpiAwareness should work without compilation error.

Thanks @gfraiteur. Could you please report the same issue using Send Feedback inside Visual Studio? Then it goes straight to the extensibility engineering team. Thanks, and sorry for the inconvenience.

Done.


Possibility to reauthenticate after device goes idle for a while?

I have been using raspotify on my Raspberry Pi at home and control it with the spotify web API again through my Raspberry pi. I have noticed that frequently, if I use spotify at work on a laptop, the web API will fail to switch the playback to librespot when I come back home as the librespot device will not appear in the device list.
There are 2 ways I can fix this:

Use an official spotify client to connect to the device again - this sometimes causes the play queue to be lost as it's replaced by the one on the official app.
Restart raspotify/librespot on my raspberry pi - this takes a while and is rather cumbersome.

However, I wonder if it's possible that this can be fixed by 're-register' or 're-authenticating' in librespot given that 2 works. If so that will be much faster than having to restart raspotify or go through the official spotify app.

Oh, that's actually interesting. I didn't realize that until I read your comment, but same happens to me.

I made https://github.com/librespot-org/librespot/pull/376 for this.

Same problem here - device disapears from devices list after a while. As a consequence a can no longer control the device via the web-api. Until now, i found no workaround.

I'm experiencing the same problem and would appreciate any tips toward solving it. I'm trying to use Spotify+Raspi as a musical alarm clock, but if I'm idle for too long during the day, it won't work in the morning.
The information that I can restart raspotify/librespot to mitigate this is new to me - thank you for that @yyjhao (and for creating this issue).
Have you made an issue on the raspotify repo yet? Maybe that would be a better place to handle this? (basing this proposition off of a comment by @kingosticks in #376)

@sashahilton00 given you've closed this issue, could you please leave a comment whether this was somehow addressed/fixed in librespot or whether it's still an issue?

Situation is the same. Groundwork was laid down in new-api to make it better, but I’ve had little time as of late.


fix fish completion wrong image names bug

New fish completions from https://github.com/barnybug/docker-fish-completion/pull/8 with a fix for #16672
(I'm assuming it'll get merged, but we should wait for it to get merged upstream before merging this)

Thanks! I see https://github.com/barnybug/docker-fish-completion/pull/8 is merged upstream as well

LGTM

LGTM 🐠


Read token from filesystem every time to get latest token

In order to integrate with Kubernetes Service Account Token Volume Projections, we need to re-read the token from the filesystem when the token expires. In this implementation, I have the heartbeat re-reading it every time to simplify the code.

Codecov Report
Patch coverage: 20.00% and no project coverage change.

Comparison is base (d2a5dcb) 12.29% compared to head (9dc524b) 12.29%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   12.29%   12.29%
=======================================
  Files          17       17
  Lines        1928     1927    -1
=======================================
  Hits          237      237
+ Misses       1675     1674    -1
  Partials       16       16

Impacted Files
Coverage Δ

src/cfg/config.go
36.20% <20.00%> (+0.61%)
:arrow_up:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


global: remove future imports

Signed-off-by: Harris Tzovanakis<EMAIL_ADDRESS>

Coverage remained the same at 66.701% when pulling e048ec0711612bd500274516ade3cbd8793be86d on drjova:remove-future into 3105678e1cd4cc7592672bef8620be0607ad1f51 on inspirehep:master.


Don't work on Win 11

Dear
I installed it on several systems but it didn't work on systems that work with win 11

Same problem, neither the portable version nor the EXE package can be downloaded and run, is there a lack of the necessary running conditions?

Works fine for me on Windows 11 Professional 24H2 Build 26100. Maybe a missing dependency ? Have you also tried installing the program through a package manager like scoop or winget ?

Thanks for your comment
We have the same OS Also I tried to install it with Winget but I still have the same issue and app didn't work.

Works fine for me on Windows 11 Professional 24H2 Build 26100. Maybe a missing dependency? Have you also tried installing the program through a package manager like Scoop or Winget?

Hello guys. Honestly I don't know why this is not working for you!
Please run the app by these steps

open the app folder
open your terminal in that folder ( Shift+RightClick then press on Open In Terminal )
start the app using terminal with this command

./ABDownloadManager.exe | more

let see if it prints some errors in terminal for you ?
also check if the app is added into task list or not ?

Another possibility is that because of your graphic driver.
so please change the renderApi to something other than the default value (check this for instructions)

Using winget to redownload still doesn't work, and there's no related process in the task manager


--noEmitOnError trace has incorrect number of errors

TypeScript Version:  3.6.4 (also tested typescript@next)
Search Terms: noEmitOnError
Code
const x: string = 5;

{
  "compilerOptions": {
    "noEmitOnError": true
  },
  "include": [
    "lib"
  ]
}

Expected behavior: Error number is 1.
Actual behavior: Error number is 2 when --noEmitOnError is enabled.
c:\Users\Username\Documents\projects\typescript_next>npx tsc
lib/test.ts:1:7 - error TS2322: Type '5' is not assignable to type 'string'.

1 const x: string = 5;
        ~

Found 2 errors.

c:\Users\Username\Documents\projects\typescript_next>npx tsc
lib/test.ts:1:7 - error TS2322: Type '5' is not assignable to type 'string'.

1 const x: string = 5;
        ~

Found 1 error.

Playground Link:
Related Issues:

I think this is https://github.com/microsoft/TypeScript/issues/29725 but you might have found the reason why this happens (noEmeitOnError)


[feature request] render to gif/png for sites that don't support svg embedding

It may not be relevant, but can you give an example of a site with this?

Anyway i'm add hard png render in https://github.com/MJaroslav/moe-counter-remade/commit/cbcfb7acbe6b56fb4812909477f65658cc7da2c0 but repl.it change their policy of hosting and this project required be selfhosted now (or you can use original counter).


A strange error when a “/a/b/c” route render to a template

MacOS

Python version: 2.7.10
Flask version: 0.12.2
Werkzeug version: 0.12.2

I have a view function that render a html template named "MyViewFunc", then I add a route rule to this function app.add_url_rule("/a/b/c", "MyViewFunc", MyViewFunc).
This caused a strange mistake in browser:

But when write as app.add_url_rule("/a", "MyViewFunc", MyViewFunc), it's ok

Those are JavaScript errors, not Python / Flask errors. Please use Stack Overflow for questions about your own code. This tracker is for issues related to the project itself. Be sure to include a minimal, complete, and verifiable example.


Duplicate query issue with large data

Hi,
We have a craft cms site, with nearly 300 sections, each section has only one entry type with 5 or 6 conditional fields. We see a huge delay when switching over control panel menu pages. This occurs on all menus even when switching between settings, utilities etc,
Our initial findings are showing there are a lot of duplicate queries initiated by reasons plugin is the cause for this delay.
For example, when we load the utilities page, after disabling the plugin only 60 odd queries were running, After enabling we see nearly 12000 queries were running. See attached,

Could we load the queries only on the pages needed?
System info:
PHP version	7.4.24
OS version	Linux 5.4.0-91-generic
Database driver & version	MySQL 5.7.35
Image driver & version	GD 7.4.24
Craft edition & version	Craft Pro 3.7.28
Yii version	2.0.44
Twig version	v2.14.10
Guzzle version	7.4.1
Reason plugin version - 2.2.5

nearly 300 sections

Whoa 🤯
@parthi-me Reasons caches all data in production (i.e. when devMode is false), so I assume you're primarily running into this issue in development?

Yes @mmikkel Above mentioned site is in development mode.

@parthi-me I've implemented a fix – if you'd be able to help me test it, that'd be great:
Change your mmikkel/reasons dependency in composer.json to dev-master#bab707bab9a58bb1b385939a9ae1c95f7986a13e as 2.2.5. Then run composer update mmikkel/reasons.
Thanks!

Thank you @mmikkel, Above fix is working fine in the initial testing. Attached is the same utilities page, which is loading only 67queries, reduced from 12000 queries previously.

@parthi-me Thank you for the follow-up! That’s quite an improvement…
I’ll get a release out with that fix ASAP.

@parthi-me Just tagged release 2.2.6 with that fix. Thanks for reporting!


Closes #1010

Removed "transform-react-inline-elements". It caused some issues when building production bundle.
https://phabricator.babeljs.io/T6946#anchor-80295

Thank you!


Pretty print in 5.0.0 is broken

If I run with prettyPrint set to true I get an exception saying
TypeError: pino.pretty is not a function
    at Object.register ([...]node_modules/hapi-pino/index.js:47:25)

I don't think there are any tests actually testing prettyPrint, it's only used in a test that ensures the config object isn't being mutated.

Thanks for catching this. Turns out we have a bug in pino, but a follow up will be needed here as well.

See https://github.com/pinojs/pino/pull/474


New author page should save the author

Scenario
When a user visits the new author page
And fills in 'Alan', 'Turing', and 'http://wikipedia.org/Alan_Turing', respectively
And submits the form
Then Alan Turing should be found in the database
Hints
Write a test that visits the new-author page, fills in the 'new author' form and submits it.
Use fill_in to enter data into input fields.
Submit the form using the find and click methods.
Try a new it block in new_author_spec.rb.
visit new_author_path
page.fill_in 'author[last_name]', with: 'Dijkstra'
# ...
find('input[type="submit"]').click

Here is the relevant section (5.6) in the Rails Guide.
Make the failing test pass by saving the POSTed form data in a new Author database object.
This is the task of a create action in authors_controller.rb.
Make sure to set the :url option of the form_with, to control where the data will be POSTed to. Read up on "strong parameters" and whitelisting of required parameters.
Do not issue a redirect_to @author, as this will error (there is no code for showing authors yet). Instead you can redirect_to root_path, notice: 'Success!'.
Tips:

Your browser's dev tools are helpful in debugging and inspecting HTML.
rails console allows you to interact with stored object in an interactive shell, e.g. Author.count shows the amount of stored authors.

Error

Got ActiveRecord::RecordNotFound: Couldn't find Author

6 exercise tests have passed. There are 44 in total. You will solve multiple at once towards the end.

Sorry, it's not working for me yet:
Scenario
When a user visits the new author page
And fills in 'Alan', 'Turing', and 'http://wikipedia.org/Alan_Turing', respectively
And submits the form
Then Alan Turing should be found in the database
Error

Got ActiveRecord::RecordNotFound: Couldn't find Author

If you have problems solving this task, please don't hesitate to contact the teaching team!

Sorry, it's not working for me yet:
Scenario
When a user visits the new author page
And fills in 'Alan', 'Turing', and 'http://wikipedia.org/Alan_Turing', respectively
And submits the form
Then Alan Turing should be found in the database
Error

Got ActiveRecord::RecordNotFound: Couldn't find Author

If you have problems solving this task, please don't hesitate to contact the teaching team!

Sorry, it's not working for me yet:
Scenario
When a user visits the new author page
And fills in 'Alan', 'Turing', and 'http://wikipedia.org/Alan_Turing', respectively
And submits the form
Then Alan Turing should be found in the database
Error

Got ActiveRecord::RecordNotFound: Couldn't find Author

If you have problems solving this task, please don't hesitate to contact the teaching team!


New rule: reverse of forbid-component-props to enforce props on components

We often forget to add a style property to our React Native components and a rule to enforce component props would really help.
Kind of like a reverse of forbid-component-props to specify which property (and type) needs to at least present on components.
Does this make sense?

That's what PropTypes are already for.

And those work in typescript JSX components too?

Of course they do. TypeScript is a build-time thing, as is jsx - they all produce the same JS React element objects.

Irrc PropTypes are kind of deprecated and they not enforce that a certain prop is defined on a component. They print a warning in the console during runtime, when someone missed to hand in the prop, but not when someone forgot to define the prop on the component.
Maybe I need to provide an example.

If you configure your tests so that console warnings fail them, then they serve that purpose perfectly. PropTypes.exact can be used to ensure no extra props are passed, and .isRequired definitely enforces that a certain prop is defined.

My goal is to catch missing props during commit (linting). So could I find code that omits .isRequired props?

That’s not possible to do reliably and statically, unless you’re using typescript.
PropTypes handle this at runtime, which is the only reliable means in JS.

I am using typescript. So I just have to make a basetype every component must accept


Unable to provision EC2 instances: "Tag key must have a value"

Describe the bug
If runner_tags is empty, the amazonec2-tags has a leading comma that causes the API request to AWS to fail with the error message mentioned in the title. See JSON request below for the error.
If runner_tags is empty, output has leading comma since the sed command doesn't remove it in gitlab-runner.tftpl:
"amazonec2-tags=,__PARENT_TAG__",

If runner_tags is not empty, or the leading comma is manually removed by going into the agent EC2 instance and editing /etc/gitlab-runners/config.toml, the error no longer shows up:
# module var.runner_tags
  runner_tags = {
    "testing" = "new runner who dis"
  }

# output from user_data with tags
"amazonec2-tags=testing,new runner who dis,__PARENT_TAG__",

Manual edit that works for us after agents were provisioned and running:
# before
"amazonec2-tags=,gitlab-runner-parent-id,runner-123123",

# after
"amazonec2-tags=gitlab-runner-parent-id,runner-123123",

To Reproduce
Steps to reproduce the behavior:

Apply a module with empty runner_tags
Wait for amazon to provision the runner
See error in CloudTrail logs

Expected behavior
The API requests are successful and the runner is registered, and does not show any errors in CloudTrail or CloudWatch logs about being able to provision the runners.
Additional context
The weird and difficult part about this issue, is that this only showed up 3-4 weeks after we switched to Spot Fleets.

We switched to Spot Fleets around 2023-07-12, and today was the first time we encountered this specific error.

Redacted request JSON to AWS
{
    "eventVersion": "1.08",
    "userIdentity": {
        // redacted
    },
    "eventTime": "2023-08-09T17:31:22Z",
    "eventSource": "ec2.amazonaws.com",
    "eventName": "CreateFleet",
    "awsRegion": "us-east-1",
    "sourceIPAddress": "#####",
    "userAgent": "aws-sdk-go/1.44.153 (go1.12.9; linux; amd64)",
    "errorCode": "Client.InvalidTagKey.Malformed",
    "errorMessage": "Tag key must have a value",
    "requestParameters": {
        "CreateFleetRequest": {
            "TargetCapacitySpecification": {
                "DefaultTargetCapacityType": "spot",
                "TotalTargetCapacity": 1
            },
            "Type": "instant",
            "SpotOptions": {
                "AllocationStrategy": "price-capacity-optimized",
                "MaxTotalPrice": 0.5
            },
            "LaunchTemplateConfigs": {
                "LaunchTemplateSpecification": {
                    "LaunchTemplateName": "gitlab-runner-agent-worker-20230809172259696900000029",
                    "Version": "$Latest"
                },
                "Overrides": [
                    {
                        "tag": 1,
                        "SubnetId": "subnet-#####",
                        "InstanceType": "t3.large"
                    },
                    {
                        "tag": 2,
                        "SubnetId": "subnet-#####",
                        "InstanceType": "t3.large"
                    },
                    {
                        "tag": 3,
                        "SubnetId": "subnet-#####",
                        "InstanceType": "t3.large"
                    }
                ],
                "tag": 1
            },
            "TagSpecification": [
                {
                    "ResourceType": "instance",
                    "tag": 1,
                    "Tag": [
                        {
                            "Value": "runner-#####",
                            "tag": 1,
                            "Key": "Name"
                        },
                        {
                            "Value": "gitlab-runner-parent-id",
                            "tag": 2,
                            "Key": ""
                        }
                    ]
                },
                {
                    "ResourceType": "volume",
                    "tag": 2,
                    "Tag": [
                        {
                            "Value": "runner-#####",
                            "tag": 1,
                            "Key": "Name"
                        },
                        {
                            "Value": "gitlab-runner-parent-id",
                            "tag": 2,
                            "Key": ""
                        }
                    ]
                },
                {
                    "ResourceType": "network-interface",
                    "tag": 3,
                    "Tag": [
                        {
                            "Value": "runner-#####",
                            "tag": 1,
                            "Key": "Name"
                        },
                        {
                            "Value": "gitlab-runner-parent-id",
                            "tag": 2,
                            "Key": ""
                        }
                    ]
                },
                {
                    "ResourceType": "fleet",
                    "tag": 4,
                    "Tag": [
                        {
                            "Value": "runner-#####",
                            "tag": 1,
                            "Key": "Name"
                        },
                        {
                            "Value": "gitlab-runner-parent-id",
                            "tag": 2,
                            "Key": ""
                        }
                    ]
                }
            ]
        }
    }
}

Seems a little bit strange as you should always set the var.environment which is also added to the tags. So runner_tags should never be empty.

Thank you for the response and quick PR @kayman-mk ! We do indeed set var.environment in our module for clarification.


[HUDI-1354] Block updates and replace on file groups in clustering

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contributing.html before opening a pull request.

What is the purpose of the pull request
Block updates and replace on file groups in clustering
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Codecov Report

Merging #2275 (f3fc86b) into master (4d05680) will decrease coverage by 7.28%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2275      +/-   ##
============================================
- Coverage     53.53%   46.24%   -7.29%
+ Complexity     2770     2098     -672
============================================
  Files           348      282      -66
  Lines         16109    12610    -3499
  Branches       1643     1231     -412
============================================
- Hits           8624     5832    -2792
+ Misses         6786     6350     -436
+ Partials        699      428     -271

Flag
Coverage Δ
Complexity Δ

hudicli
38.50% <ø> (+0.13%)
0.00 <ø> (ø)

hudiclient
100.00% <ø> (ø)
0.00 <ø> (ø)

hudicommon
55.33% <ø> (+0.02%)
0.00 <ø> (ø)

hudihadoopmr
?
?

hudispark
?
?

huditimelineservice
?
?

hudiutilities
10.41% <ø> (-59.69%)
0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

 :/
Could you help review this?

have resolved the comments, can you help to review ? @satishkotha @n3nash @vinothchandar  thanks.

@satishkotha can you please take a first pass?
@lw309637554 CI is still failing. Could you please check it out?

@satishkotha can you please take a first pass?
@lw309637554 CI is still failing. Could you please check it out?

ok,  i will fix it today

@satishkotha can you please take a first pass?
@lw309637554 CI is still failing. Could you please check it out?

ok, i will fix it today

@satishkotha  have fixed the test ,can you help to review  , thanks

i think this is also a blocker for clustering @satishkotha ?

i think this is also a blocker for clustering @satishkotha ?

@vinothchandar yes, i think we are close to landing this. Please take a pass and review when you get a chance.

i think this is also a blocker for clustering @satishkotha ?

@vinothchandar yes, i think we are close to landing this. Please take a pass and review when you get a chance.

@satishkotha have resolved the comments, can you help to review again, thanks

@leesf thanks, have resolved the comments.

@satishkotha @leesf  thanks, have resolved the comments.

add isClusteringEnable to open the update strategy  in BaseSparkCommitActionExecutor(not use the "'default' strategy"  for not open clustering, i think use the isClusteringEnable config more clearness)
also use isClusteringEnable to check if we should exclude clustering file group in small files (not move the filter code to update strategy, i think partitioner handle for clustering make sense)

@vinothchandar hello this is blocker clustering

@satishkotha thanks so much , have resolved these comment.

@n3nash @satishkotha @leesf have  resolved all the comments, thanks so much


Discogapic: fetch Discovery document from remote source

Enable fetching the Discovery document from github or from a URL (in addition to having a locally sourced option).
Changes config.proto's discovery_doc from a string filepath into a message type that includes the filepath and a type (GITHUB, LOCAL, etc).

@garrettjonesgoogle There's been some discussion between @vam-google and me about whether this is a useful PR. On one hand, it saves the user the trouble of manually checking out the latest discovery doc, but on the other hand, it does add some complexity from the new config and from possibly requiring a remote connection to github. Thoughts?

I think we should maintain parity between usage of googleapis/googleapis and discovery-artifact-manager. Checkouts from github might be nice, but I would prefer to do a design that considers what workflows we want to support. So, until we have that higher-level discussion, I might want to hold off on this feature.

Ok, putting this feature on hold.


net: Dial/Listen with "ip4:tcp" or "ip6"tcp" fails on Windows

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.9.2 windows/amd64
Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
$ go env
set GOARCH=amd64
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Users\ilyaigpetrov\go
set GORACE=
set GOROOT=C:\Go
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config

What did you do?
package main

import (
	"fmt"
	"net"
)

func main() {
  _, err := net.DialIP("ip:tcp", nil, &net.IPAddr{IP: net.IPv4(127, 0, 0, 1)})
  // _, err := net.DialIP("ip4:6", nil, &net.IPAddr{IP: net.IPv4(127, 0, 0, 1)}) // the same error
  if err != nil {
    fmt.Println("ERR", err)
  } else {
    fmt.Println("No error!")
  }
}

What did you expect to see?
DialIP must work without errors.
What did you see instead?
ERR dial ip:tcp <IP_ADDRESS>: connect: An invalid argument was supplied.
or
socket: protocol not supported (Bash for Windows)

/cc @mikioh

I'm not a Windows user and have Windows stuff, but when googling with "sock_raw+tcp" I found the following: https://msdn.microsoft.com/en-us/library/windows/desktop/ms740548(v=vs.85).aspx
See the section of Limitations on Raw Sockets.

Please, mention that peculiarity in the documentation, so people don't waste time seeking for answers.

@ilyaigpetrov,
Feel free to open a new issue for documentation.


Made PnP More Robust

See https://github.com/personalrobotics/ada_feeding/issues/11 for details.
Basically, PnPRansac was extremely unstable, and perceiving faces in strange and varying orientations. This is likely because we only use 12 points to align the face, and Ransac randomly subsamples from them. Ransac works well with many points; 12 seems too low. (Note that PnPRansac was first introduced in this commit, and I couldn't find documentation as to why.)
This commit reverts PnPRansac to PnP. To further increase stability, it initializes PnP with the output of the previous PnP call.

solvedPnP is used in line 154, which is what enables it to get initialized. Specifically, the parameter that is passed to solvePnP(...) after the translation vector is a bool that specifies whether to use the values already in the rotation/translation vector as an initialization or not. The first iteration, it is false. On every subsequent iteration, it initializes solvePnP with the previous solution.

Done. I'll test this new change on the robot first before merging it in.

Works on the robot


chore: throw warning msg upon any transaction where total XRD balance…

Demo for Sending/Staking
Demo for Unstaking & the lack of this warning message
This PR will throw a warning to the User to let them know upon this transaction, their total XRD balance will be < 10 XRD. This message applies to Staking and Sending Tokens, but not Unstaking.
Warning message should apply to case where User sends NON XRD token as well, since there is still a Transaction Fee involved.

Sending/Staking XRD Calculation:

Total XRD - XRD Amount Input(to stake or to send) - Transaction Fee > 10?

Sending NON XRD Calculation:

Total XRD - Transaction Fee > 10?

Unstaking should never trigger this warning, even if...User has 2 XRD and is unstaking 1 XRD. Even if this is < 10 XRD we don't want to warn them in the case of unstaking.

Since we're hitting the API to get User's Total XRD Balance in the WalletConfirmTransactionModal, would it be helpful to display the User's total XRD post-transaction as well? Another row that says...Remaining XRD After Transaction:  1,0004.068 XRD? something like this? Would like your thoughts on this @alexandreaco @saminakh Example:

🙇 🙇 changed up to your specs, thanks for the kind review @alexandreaco ! Didn't realize ComputedRef was part of the composition api.

The warning looks good and the logic looks sound! I did notice one case that may have slipped through the cracks: when a user has less than 10 XRD to begin with, and makes a transaction that keeps their balance below 10 XRD. I think no warning is supposed to show in this case, b/c at that point every transaction will cause them to be below 10 because they were below 10 to begin with!

this may be true, i probably wouldn't want someone telling me every transaction how close to 0 i am 😢

The warning looks good and the logic looks sound! I did notice one case that may have slipped through the cracks: when a user has less than 10 XRD to begin with, and makes a transaction that keeps their balance below 10 XRD. I think no warning is supposed to show in this case, b/c at that point every transaction will cause them to be below 10 because they were below 10 to begin with!

Well hmm, thought about it over the weekend. if the main point of the warning is to warn the user that there's an underlying fee to transactions, should this warning be thrown even when under 10 XRD? 🤔 💭 it mayyy be safe to assume the user is new to the Radix platform?

Hey @SK-Sam, I checked the original Linear story and Matt would like the warning to not appear when a user has less than 10 xrd to begin with

Let's just show a bright red warning in the confirmation modal if a user is ever about the submit a TX that would take their XRD balance from > 10 XRD to < 10 XRD.

https://linear.app/township/issue/RDX-252/add-warning-message-when-about-to-send-all-or-nearly-all-xrd

@saminakh Can you please re-review this? I made the last update to not show the warning when users have < 10 xrd to begin with


.NET Core 3.0 support

I've added a .NET Core 3.0 target now that WPF is supported with .NET Core.

@alexhelms Would you add your name to the copyright notice in the LambdaConverters.Wpf.csproj file?


implement config dump query by resource type for missing types

Please provide a description of this PR:
/debug/config_dump?types=ecds was implemented but none of the other config_dump type
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ X ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

follow-up from discussion on https://github.com/istio/istio/pull/42547

@GregHanson: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
3613285ab901a443c2e6c35a4a8a7845f0654627
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
3613285ab901a443c2e6c35a4a8a7845f0654627
link
true
/test unit-tests-arm64

release-notes_istio
3613285ab901a443c2e6c35a4a8a7845f0654627
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
3613285ab901a443c2e6c35a4a8a7845f0654627
link
true
/test unit-tests-arm64

release-notes_istio
3613285ab901a443c2e6c35a4a8a7845f0654627
link
true
/test release-notes

lint_istio
3613285ab901a443c2e6c35a4a8a7845f0654627
link
true
/test lint

unit-tests_istio
3613285ab901a443c2e6c35a4a8a7845f0654627
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
3613285ab901a443c2e6c35a4a8a7845f0654627
link
true
/test lint

unit-tests_istio
3613285ab901a443c2e6c35a4a8a7845f0654627
link
true
/test unit-tests

release-notes_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test release-notes

unit-tests-arm64_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test release-notes

unit-tests-arm64_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test unit-tests-arm64

unit-tests_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test release-notes

unit-tests-arm64_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test unit-tests-arm64

unit-tests_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test unit-tests

integ-pilot-istiodremote_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test release-notes

unit-tests-arm64_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test unit-tests-arm64

unit-tests_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test unit-tests

integ-pilot-istiodremote_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test integ-pilot-istiodremote

integ-cni_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test release-notes

unit-tests-arm64_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test unit-tests-arm64

unit-tests_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test unit-tests

integ-pilot-istiodremote_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test integ-pilot-istiodremote

integ-cni_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test integ-cni

integ-pilot_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test unit-tests-arm64

unit-tests_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test unit-tests

integ-pilot-istiodremote_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test integ-pilot-istiodremote

integ-cni_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test integ-cni

integ-pilot_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test integ-pilot

release-notes_istio
f778ada91d22a5c062cbd4492befb97a3092b927
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@GregHanson: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
148c92b9b90715d6ea0b1219c87c2715ef1a2131
link
true
/test integ-cni

integ-pilot-istiodremote_istio
1820f87fd026b6b64d5e1b7ba81c19b098635003
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Iox #27 1 client server port interfaces

initial PR for #27, step 1 in the list

API proposal for review
no implementation yet
also some cleanup in naming of our config parameters
when renaming, I realized that ChunSender template parameter has to be ChunkSenderData and not ChunkDistributor and same issue for ChunkReceiver.

Hello, When you would be releasing 1.x version which includes Request/Response communication?

Hello,
We've requirement related to request/response communication and would like to know when this solution would be available?

Hello,
We've requirement related to request/response communication and would like to know when this solution would be available?

Thanks for asking @hemalbavishi. Top prio has the new C and C++ API for pub/sub communication. This we want to finalize in the next weeks and this is prio 1. But request/response is the next on the list. I would assume that we have a first version end of this or latest beginning of next year


write file locations into html report

Part of https://github.com/gradle/gradle-private/issues/4279
Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gradle test this

I've triggered the following builds for you. Click here to see all build failures.

Pull Request Feedback (Trigger) (Check)

The merge queue build has failed. Click here to see all failures.


Javascript Oidc - Checksession to IDSRVR 4 return 404

I tried the sample called Javascript Oidc and when I obtained the access token and check session - check_session_iframe: "http://localhost:22530/connect/checksession" and then GET http://localhost:22530/connect/checksession 404 (Not Found).
How can I fix this 404?

Check session is not yet implemented in IdSvr4. It will be eventuially.

+1

but it is now - right? @brockallen

Correct. We even have an integration test specifically for 404: https://github.com/IdentityServer/IdentityServer4/blob/dev/test/IdentityServer.IntegrationTests/Endpoints/CheckSession/CheckSessionTests.cs#L30


ssl

Just wondering if there could be a way to use this with ssl.
when chrome loads the googlemap it turns off the green padlock - stating there is something unsecured on the page and all I have is googlemap

Hi @s4054378,
I just setup the web site sample project to use IISExpress under ssl, and as you can see in the following image I did have no problem whatsoever, rendering the map over ssl.
Please can you provide more info about your environment?

Hey Juan
My site isnt completely live yet.
My ssl is fine for all the pages except my locations page. as per the
pictures below.
The only thing I have on the locations page that is different to other
pages is below.
cshtml before compile.
@using System.Drawing;
@using Jmelosegui.Mvc.Googlemap
@using Jmelosegui.Mvc.Googlemap.Overlays
@model IEnumerable<WebApplication1.Models.LocationCord>
@{
ViewBag.Title = "First Look";
}
@section scripts
{
@(Html.GoogleMap().ScriptRegistrar())

}
@{
Html.GoogleMap()
.Name("map")
.Width((int)ViewData["width"])
.Height((int)ViewData["height"])
.Center(c =>
c.Latitude((double)ViewData["latitude"]).Longitude((double)ViewData["Longitude"]))
.Zoom((int)ViewData["zoom"])
.EnableMarkersClustering(options =>
{
options.MaxZoom = (int)ViewData["MaxZoom"];
options.GridSize = (int)ViewData["GridSize"];
options.AverageCenter = (bool)ViewData["AverageCenter"];
options.ZoomOnClick = (bool)ViewData["ZoomOnClick"];
options.HideSingleGroupMarker =
(bool)ViewData["HideSingleGroupMarker"];
if ((string)ViewData["CustomStyles"] == "StackOverflow")
{
options.CustomStyles.Add(new MarkerClusteringStyles
{
Url = "~/Resources/Images/clust1.png",
Height
= 75,
Width = 75,
TextSize = 20,
TextColor = Color.Black
                    });
                    options.CustomStyles.Add(new MarkerClusteringStyles
                    {
                        Url = "~/Resources/Images/cluster2.png",
                        Height
                            = 45,
                        Width = 45,
                        TextSize = 12,
                        TextColor = Color.Black
                    });
                    //  options.CustomStyles.Add(new

MarkerClusteringStyles
//  {
//       Url = "~/Resources/Images/cluster3.png",
//       Height
//           = 100,
//        Width = 100,
//        TextSize = 20,
//        TextColor = Color.Black
//    });
}
})
.BindTo<WebApplication1.Models.LocationCord, Marker>
(Model, mappings =>
mappings.For<WebApplication1.Models.LocationCord>
(
binding => binding.ItemDataBound
(
(marker, obj) =>
{
marker.Latitude =
Convert.ToDouble(obj.Lat);
marker.Longitude =
Convert.ToDouble(obj.Long);
}
)
)
)
.BindTo<WebApplication1.Models.LocationCord, Circle>
(Model, mappings =>
mappings.For<WebApplication1.Models.LocationCord>
(
binding => binding.ItemDataBound
(
(circle, obj) =>
{
circle.Center = new
Location(Convert.ToDouble(obj.Lat), Convert.ToDouble(obj.Long));
circle.Radius =
Convert.ToInt32(obj.Radius);
                            }
                        )
                        ))
            .Render();

}
and page source

// jQuery(document).ready(function(){
jQuery('#map').GoogleMap({clientId:'map', enableMarkersClustering:true,
height:0,
center:{"latitude":-25.626092,"longitude":133.665346,"useCurrentPosition":false},
mapTypeId:'ROADMAP', zoom:4,
markerClusteringOptions:{"maxZoom":16,"gridSize":45,"averageCenter":true,"hideSingleGroupMarker":true},
markers:[{"lat":-20.266893,"lng":148.716935},{"lat":-20.269776,"lng":148.715665},{"lat":-20.267385,"lng":148.71775}],
markerEvents:{},
circles:[{"fillColor":"#FF0000","fillOpacity":0.5,"strokeColor":"#8B0000","strokeOpacity":0.8,"strokeWeight":2,"center":{"latitude":-20.266893,"longitude":148.716935},"radius":100},{"fillColor":"#FF0000","fillOpacity":0.5,"strokeColor":"#8B0000","strokeOpacity":0.8,"strokeWeight":2,"center":{"latitude":-20.269776,"longitude":148.715665},"radius":100},{"fillColor":"#FF0000","fillOpacity":0.5,"strokeColor":"#8B0000","strokeOpacity":0.8,"strokeWeight":2,"center":{"latitude":-20.267385,"longitude":148.71775},"radius":70}]});
}); //
Its not a deal breaker but it would be nice to have the green padlock on
all the pages.
Thanks Dale
On Sat, Sep 5, 2015 at 9:24 AM, Juan Manuel Elosegui <
<EMAIL_ADDRESS>wrote:

Hi @s4054378 https://github.com/s4054378,
I just setup the web site sample project to use IISExpress under ssl, and
as you can see in the following image I did have no problem whatsoever,
rendering the map over ssl.
Please can you provide more info about your environment?
[image: image]
https://cloud.githubusercontent.com/assets/450246/9696219/335880e8-533a-11e5-8045-32cc8087c706.png
—
Reply to this email directly or view it on GitHub
https://github.com/jmelosegui/GooglemapMvc/issues/67#issuecomment-137877378
.

To narrow down that issue, I will suggest to start with a simple map, something like this.
@(
     Html.GoogleMap()
         .Name("map")
         .Height(500)
   )

That map should be rendered over both: http and https. Let me know if not.


Reduce warnings

This pull request reduces warnings.
Remove rubyforge_project from gemspec
https://github.com/xijo/reverse_markdown/commit/1880de49fc5dc8e5500247b5ded2803566a9c886
It removes s.rubyforge_project = "reverse_markdown". Because rubygems displays the following warning.
NOTE: Gem::Specification#rubyforge_project= is deprecated with no replacement. It will be removed on or after 2019-12-01.
Gem::Specification#rubyforge_project= called from /home/pocke/ghq/github.com/xijo/reverse_markdown/reverse_markdown.gemspec:14.

Remove -rubygems from argument of IRB
https://github.com/xijo/reverse_markdown/commit/af11e53e750e388ad8db76ae327a462cd788d187
rake console displays a LoadError, since Ruby 2.5.
$ bundle exec rake console
irb -rubygems -I lib -r reverse_markdown.rb
/home/pocke/.rbenv/versions/trunk/lib/ruby/2.7.0/irb/init.rb:290: warning: LoadError: cannot load such file -- ubygems
irb(main):001:0>

Becuase ubygems has been removed since Ruby 2.5. And it is unnecessary since Ruby 1.9.
So we can just remove it.
ref: https://www.engineyard.com/blog/goodbye-ubygems
By the way, I'm not sure why IRB only displays LoadError, not exits. :thinking:
Reduce Ruby warnings
https://github.com/xijo/reverse_markdown/commit/77dab445c228832651f5012fcfff947e0d962c96
Ruby displays warnings for config.rb with -w option.
$ ruby -Ilib -rreverse_markdown -w -e ''
/home/pocke/ghq/github.com/xijo/reverse_markdown/lib/reverse_markdown/config.rb:22: warning: method redefined; discarding old unknown_tags
/home/pocke/ghq/github.com/xijo/reverse_markdown/lib/reverse_markdown/config.rb:26: warning: method redefined; discarding old github_flavored
/home/pocke/ghq/github.com/xijo/reverse_markdown/lib/reverse_markdown/config.rb:30: warning: method redefined; discarding old tag_border
/home/pocke/ghq/github.com/xijo/reverse_markdown/lib/reverse_markdown/config.rb:34: warning: method redefined; discarding old force_encoding

Config uses attr_accessor, but it also defines readers, so it warns.
# It defines `unknown_tags` and `unknown_tags=`, and so on
attr_accessor :unknown_tags, :github_flavored, :tag_border, :force_encoding

# It overrides the method defined by attr_accessor.
def unknown_tags
  # ...
end

So I replace attr_accessor with attr_writer. It does not affect behavior.

Thank you for the great product!

Sounds great, thanks! :+1:


SAMLTracer.js Error in Firefox Developer Edition (103.0b2)

SAML-tracer appears to have stopped functioning in the latest Firefox Beta (Developer Edition tracks with Beta)
Uncaught Error: Type error for parameter extraInfoSpec (Error processing 2: Invalid enumeration value "extraHeaders") for webRequest.onBeforeSendHeaders.
    init moz-extension://21213b32-20d7-404e-b9f3-25e9c5930f22/src/SAMLTrace.js:943
    <anonymous> moz-extension://21213b32-20d7-404e-b9f3-25e9c5930f22/src/ui.js:15
[SAMLTrace.js:943:42](moz-extension://21213b32-20d7-404e-b9f3-25e9c5930f22/src/SAMLTrace.js)
    makeError resource://gre/modules/Schemas.jsm:539
    throwError resource://gre/modules/Schemas.jsm:2659
    fixedArgs resource://gre/modules/Schemas.jsm:2727
    map self-hosted:180
    checkParameters resource://gre/modules/Schemas.jsm:2720
    addStub resource://gre/modules/Schemas.jsm:2956
    init moz-extension://21213b32-20d7-404e-b9f3-25e9c5930f22/src/SAMLTrace.js:943
    <anonymous> moz-extension://21213b32-20d7-404e-b9f3-25e9c5930f22/src/ui.js:15

I've tried tried disabling all other extensions, etc. This occurs only with FF 103 insofar as I can tell... which will be the "main" version of Firefox come July 22. I don't know precisely that this is an issue with SAML-tracer vs. FF, though a cursory search on Bugzilla doesn't reflect anything related to changes/bugs with webRequest.onBeforeSendHeaders.
Screenshot:

Could any of the maintainers provide some insight? I typically use developer edition just so that I have a completely separate browser for debugging SAML (hate clearing cache on my main browser). I can work around this tentatively, but I'd hate to see FF103 drop in July and break SAML-Tracer.

I think this is where it goes awry:
https://github.com/simplesamlphp/SAML-tracer/blob/a500371f614c07f4b86871e81f7bcc2e46a82ee9/src/SAMLTrace.js#L907-L913
Apparently your browser does not satisfy the test in the method "isFirefox()". So a value is sent that Firefox does not understand. Question is why your Firefox is not Firefox.

This Bugzilla item seems to describe more about the InstallTrigger deprecation and explicitly mentions the use of this construct to test for Firefoxness. And if understand it well, also that in "late beta" they will make using InstallTrigger for this purpose work again?

We might consider doing an actual user agent check instead of using this strange InstallTrigger global?

This is a really interesting issue! 🙂👍
I think you have to ask yourself why isFirefox() is needed at all. It was intruduced with pull request #61 because Chrome 72+ requires extraHeaders to access some certain HTTP headers. Therefore, "is Firefox" is actually misleading. It is rather the question whether it "is Chrome".
We could easily utilize the user agent string to determine the browser type. By doing something like navigator.userAgent.indexOf("Chrome") !== -1. But user agent detection should be avoided if possible.
Instead we could use feature detection and check if the "feature" "extraHeaders" is available. Probably by doing something like this:
var browser = browser || chrome;
const useExtraHeaders = () => {
  try  {
    const dummyListener = req => console.log(req);
    browser.webRequest.onBeforeSendHeaders.addListener(dummyListener, {urls: ["<all_urls>"]}, ["extraHeaders"]);
    browser.webRequest.onBeforeSendHeaders.removeListener(dummyListener);
    // seems to be Chrome which supports an requires "extraHeaders"
    return true;
  } catch (err) {
    // seems to be Firefox since "extraHeaders" is not supported
    return false;
  }
}

console.log(useExtraHeaders());

But I'm afraid this is a pretty expensive piece of code to check for the feature... Any ideas?

Is it actually still a problem to pass the extra parameter in Firefox? Because it is in the Mozilla MDN and nothing on that page indicates it wouldn't work on Firefox.. Is it perhaps something from the past?
If we still need it, it should perhaps be possible to test the amount of parameters? Like browser.webRequest.onBeforeSendHeaders.length? That would work for methods, but I'm not sure it will also work for events..

The problem isn't addListener's third parameter (extraInfoSpec). It's rather the values that extraInfoSpec can hold.
While the Chrome-webRequest-API requires the value extraHeaders (see here), the Firefox-webRequest-API can't handle that value (the docs don't mention it at all) and FF throws the exception that Kellen reported: Invalid enumeration value "extraHeaders"

Ah, my bad.. Forget what I said :)

Ideally we'd change the detection method. But I would only change it if it's actually a significant improvement. The code suggested by @khlr seems indeed quite a lot of code/effort for the simple case.
They are adding the object back in late beta (even if it's only null) precisely because the way we test for it was "the way to do it" and many extensions did it. So I'm not afraid it will break quickly in the future. It would seem a premature optimization to replace this simple check with complex code if the simple check is not likely to go away for the forseeable future.
So long story short, I'd like to replace it only if there's a similarly straightforward check available.

How about the window.chrome var?

I think there may be a predefined constant can be leveraged here (see: https://stackoverflow.com/questions/69287721/how-to-manipulate-webrequest-cookie-in-a-cross-browser-extension).
Specifically, the answer:

The API exposes all predefined constants in chrome.webRequest.OnXXXXXXXXX objects for each event so only in new Chrome such objects will have EXTRA_HEADERS key with extraHeaders value whereas in Firefox and old Chrome it'll be undefined, which can be filtered out via filter()

chrome.webRequest.onBeforeSendHeaders.addListener(
  listenerFunc,
  { urls: ['*://*/*'] },
  ['blocking', 'requestHeaders',
   chrome.webRequest.OnBeforeSendHeadersOptions.EXTRA_HEADERS].filter(Boolean)
);

I'll try to test this... would be happy to create a PR with that change if it works.
It seems to me that a simple check that can be applied with initiating the listener seems like the simplest solution long term, and potentially the new "right way" to do things once InstallTrigger is removed.

Thank you for this contribution, Kellen! 🙂
It's good to have this change in the codebase!
However, I think we can do without a release for now, since InstallTrigger is being made available again.


Task/144/dyn midi bindings

Codecov Report

Merging #177 (0d8dcb9) into main (2aa32c2) will increase coverage by 0.16%.
The diff coverage is 90.62%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   81.88%   82.04%   +0.16%
==========================================
  Files          78       78
  Lines        1904     1921      +17
  Branches      294      301       +7
==========================================
+ Hits         1559     1576      +17
  Misses        344      344
  Partials        1        1

Impacted Files
Coverage Δ

client/src/components/MIDIListenerWrapper.tsx
96.42% <ø> (ø)

client/src/components/PresetButtons.tsx
97.61% <ø> (-0.06%)
:arrow_down:

client/src/store/artScrollerSlice.ts
60.00% <ø> (ø)

client/src/store/presetButtonListSlice.ts
100.00% <ø> (ø)

client/src/utils/PresetButtonsListClass.ts
100.00% <ø> (ø)

client/src/utils/MIDIControlClass.ts
72.50% <75.00%> (+0.23%)
:arrow_up:

client/src/components/ArtScroller.style.tsx
74.62% <83.33%> (+0.85%)
:arrow_up:

client/src/components/PresetButton.style.tsx
90.56% <100.00%> (+0.36%)
:arrow_up:

client/src/components/PresetButton.tsx
100.00% <100.00%> (ø)

client/src/constants.ts
100.00% <100.00%> (ø)

... and 1 more

... and 1 file with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Implement url shortener as qr code (one of the feature)

Problem:
I'm always frustrated when I need to generate QR codes for shortened URLs separately, as it adds extra steps to the process and makes it less efficient.
Solution:
I would like the URL shortener to have built-in QR code generation functionality alongside shortened URLs. This would streamline the process and make it more convenient for users to create QR codes for their shortened links.
Describe alternatives you've considered:
One alternative could be using a separate QR code generation tool or service, but this would require users to switch between different platforms and may not integrate seamlessly with the URL shortener.
Additional context:
Implementing QR code generation directly within the URL shortener would enhance user experience and make the platform more comprehensive. It could be a valuable addition for users who frequently share links in offline settings or on physical materials.
Please assign me this task i am gssoc'24 contributor @abhijeetnishal

I want to Work on this Issue under GSSOC'24

Hey @Sudhan22z265, could you please explain the flow and UI how its look and little more details regarding this issue.


New version: LBRY.LBRY version 0.53.4

Result: Installation Successful

Manifest
Add/Remove Programs

Name
LBRY
LBRY 0.53.4

Version
0.53.4
0.53.4

Publisher
LBRY Inc.
LBRY Inc.

ProductCode

e406725b-d361-5b1c-81f7-0a4c5ac54cb3

Auto-updated by vedantmgoyal2009/winget-pkgs-automation in workflow run 2067
Microsoft Reviewers: Open in CodeFlow

@wingetbot run


Allows without curly braces around hash like data representation

Similar to issue #472, but this condition is something like this:
╰─⠠⠵ go run goby.go -i
# command-line-arguments
ld: warning: PIE disabled. Absolute addressing (perhaps -mdynamic-no-pic) not allowed in code signed PIE, but used in type..eqfunc.[106]string from /var/folders/70/jfl6pkgn39l1xxbg70r4cqdc0000gn/T/go-link-846905965/go.o. To fix this warning, don't compile with -mdynamic-no-pic or link with -Wl,-no_pie
Goby 0.1.3 😃 😀 😗
» { hello: "World" }  # Normal
#» { hello: "World" }
» hello: "World"      # Should Raise Error
#» World
» hello
#» ERROR: UndefinedMethodError: Undefined Method 'hello' for <Instance of: Object>. At REPL:1
»

As pointed out, I think this needs fix. Perhaps we need exhaustive test cases for that.
[1] pry(main)> { hello: "World" }
=> {:hello=>"World"}
[2] pry(main)> { hello: "World" }.class
=> Hash
[3] pry(main)> hello: "World"
SyntaxError: unexpected ':', expecting end-of-input
hello: "World"


merge package template from arlac77/npm-package-template

package.json

chore(scripts): update prepare@rollup -c from template
chore(devDependencies): update<EMAIL_ADDRESS>from template

.travis.yml

chore(travis): merge from template .travis.yml

Coverage decreased (-0.4%) to 94.231% when pulling b37451c7643c30c637a5a477b74e7f9847fbfb92 on template-sync-1 into 2917715d840ad5de9e505911823047acd66c7786 on master.


Support for new Google Material icon styles

Would be great to add support for Google's updated material icon styles.
(Rounded FTW!)
eg: https://material.io/tools/icons/?style=round

+1

+1

Do we have any news about this feature/support?

Any update on the different material icons themes (e.g. outlined)?

+1 I'd be keen to have these available too.
I'm interested in Solid and Outline being available

+1

+1
I need outlined material icons themes

+1

.... +1

Looks like the other styles are in the fonts git repo now: https://github.com/google/material-design-icons/tree/master/font

Looks like the other styles are in the fonts git repo now: https://github.com/google/material-design-icons/tree/master/font


Website uses invalid cert

You have jottem.dev linked, but it's trying to use a Github cert

I'm not sure the website even still exists. I'll check when I get home this evening. There wasn't anything there that isn't covered by the wiki here though.


twitch_tags parse_tags fails occasionally

The error I get is:
Invalid access of index '1' on a base object of type: 'PackedStringArray'.
in this function:
func parse_tags(tag_string: String, output: Object) -> void:
		_raw = tag_string;
		if tag_string.left(1) == "@":
			tag_string = tag_string.substr(1);

		var tags = tag_string.split(";");
		for tag in tags:
			var tag_value = tag.split("=");
			var property_name = tag_value[0].replace("-", "_");
			if _has_property(output, property_name):
				output.set(property_name, tag_value[1]);
			else:
				output._unmapped[property_name] = tag_value[1];

on the final line, which is line 94 in twitch_tags.
Variables
_unmapped

Value: { }

property_name

Value: ""

tag_value

Value: [""] (a PackedStringArray with 1 element, "")

output

Value: (an object)

The intresting point would be the message that got sended. Cause the unmapped stuff are things that Twitch didn't documented but still is sending. When this happen again can you maybe log the message that Twitch has send. And when you need a quick fix check for the length of the tag_value on the else: part.

The intresting point would be the message that got sended. Cause the unmapped stuff are things that Twitch didn't documented but still is sending. When this happen again can you maybe log the message that Twitch has send. And when you need a quick fix check for the length of the tag_value on the else: part.

thanks, I'll try get that and send it here


Fix signature for toJSON calls

When overriding toJSON() in model.js, we have to make sure the extra parameter recursionDepth is sent as the second argument, as things like JSON.stringify natively call toJSON with the property name as the first argument.

Grunt build is failing, fix that before merging this.

@bachbui please add a comment near the toJSON calls so description of this PR is in the code ❤


fix: do not include package.json as an entity in a package

What does this pull request change?
update import package to ignore the package.json file
Why is this pull request needed?
the package.json file is used for loading meta information to a package when importing a package. Before, this package.json file was interpreted as an entity by mistake (see also issue details).
Issues related to this change
closes #32

issue #32 is fixed in main. no need for this PR

@soofstad ready for new review after rebase on main


Merge with master

Update

Switched title & commit message to English.
Please, only use the English language for titles & comments (also when commenting inside the code).
The only exception are resources & language-specific files.
Thanks.


Alignment updates

Overall Review of Changes:

Oracle alignment now works and tested with oracle7.9
audit alignment benchmark version used to test against
goss audit version updated
lint file update
workflow updates

Issues addressed:
#308
#309
How has this been tested?:
Manually

Note this is using older github actions so will fail some parts of the workflow.


fix(redis): dashboard #4221

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.cyckercai seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Add initial configurations for multiple distros. (#59)

Add CI configuration with multiple ROS distributions and use pre-commit in the repository.

Thanks for adding the badges!


USECOMPAT issue while compiling with single CMakeLists file

Hi,
We are using below CMakeLists file to compile both server and cli at same time.
cmake_minimum_required(VERSION 2.6)

set_property(GLOBAL PROPERTY ALLOW_DUPLICATE_CUSTOM_TARGETS 1)
add_subdirectory(server)
add_subdirectory(cli)

After recent commit to use macro use_compat
We are observing below error while compiling. Could you please suggest a way to solve this.
CMake Error at CMakeModules/UseCompat.cmake:26 (add_library):
  add_library cannot create target "compat" because another target with the
same name already exists.  The existing target is created in source
  directory
"netopeer2-1.1.23/server".
  See documentation for policy CMP0002 for more details.
Call Stack (most recent call first):
  cli/CMakeLists.txt:38 (use_compat)

Thanks & Regards,
Sriram.K

Hi,
please try it now.
Regards,
Michal

Hi,
Now error compat.h no such file or directory from cli compilation.
Thanks & Regards,
Sriram.K

Hi Sriram,
please try again, hopefully works this time.
Regards,
Michal

Hi Michal,
Yes its working fine now
Thanks & Regards,
Sriram.K


Getting error while loading pdf in a viewer 'X-Frame-Options' to 'deny'.

Configuration:

Chrome Version 80.0.3987.163
-Windows 10
PDF.js v2.3.2

Getting below error while running in tomcat server but works fine with the local node server.
Refused to display 'myserverpath/assets/pdfjs/web/viewer.html?file=myblobpath&openFile=false&download=true&viewBookmark=true&startPage=0&stopPage=466' in a frame because it set 'X-Frame-Options' to 'deny'.\
Based on couple of suggestions tried below options:

From serverside changed response header X-Frame-Options to "SAMEORIGIN".Still i am getting the same error.
Added filter inside web.xml in tomcat config. Still issue persists

Unfortunately we cannot help out with Tomcat configuration since none of us appear to have experience with that. Since this is not really PDF.js-related but instead a configuration issue for Tomcat, you're best bet would be to ask for this at a Tomcat support forum.


Fixed craftcms/cms requirement

Without this change, the plugin is saying it won’t be compatible with Craft 3.1+, which probably isn’t want you intended.

Thank you for bringing this up! I will fix it today


Transpose guides (.guide files) for SQLECmd, EvtxECmd, and RECmd into the book

Be sure to add a pointer in the comments of the .template file that the guides are in the book

Polling the group, should we do a section at the end of the book where all the guides reside? Or should the guides go right after each respective tool? I think including the guides within the tool's respective chapter will make it too bloated. Thoughts?

i think an Appendix at the end with all the guides makes sense, and keeps them all together.
i dont know how much commonality there is between guides but that can be pulled out and shown once if it makes sense


Cannot set properties of undefined (setting '$gtag') in Nuxt

If you are reporting a bug, please fill in below. Otherwise feel free to remove this template entirely.
Description
In Nuxt when i call the plugin vue-gtag there is an error:
Cannot set properties of undefined (setting '$gtag')
Environment
Run this command in the project folder and fill in their results:

Operating system: Windows
Browser and version<EMAIL_ADDRESS>
Reproducible Demo
import Vue from "vue";
import VueGtag from "vue-gtag";
const vueGtagClient = ({ app, env }) => {
  Vue.use(
    VueGtag,
    {
      config: { id: env.GOOGLE_ANALYTICS },
      disabled: true, // Here you could ignore user privacy and set to true
    },
    app.router
  )
}

export default vueGtagClient;

@filippodicostanzo  have you found the solution?

No I haven't find any solution for this issue. 😔

Try to install a lower version 1.x.x
It works now.
Filippo Di Costanzo @.***> 於 2022年3月29日 週二 下午4:25寫道：

No I haven't find any solution for this issue. 😔
—
Reply to this email directly, view it on GitHub
https://github.com/MatteoGabriele/vue-gtag/issues/424#issuecomment-1081578052,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADHBIITG6RP47BCPZRUTK7TVCK5AXANCNFSM5R3H3ICQ
.
You are receiving this because you commented.Message ID:
@.***>

Try to install a lower version 1.x.x It works now. Filippo Di Costanzo @.> 於 2022年3月29日 週二 下午4:25寫道：
…
No I haven't find any solution for this issue. 😔 — Reply to this email directly, view it on GitHub <#424 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHBIITG6RP47BCPZRUTK7TVCK5AXANCNFSM5R3H3ICQ . You are receiving this because you commented.Message ID: @.>

Thanks it works with ^1.0.0 version


Discover VisualCpp version from an installation directory

As a user, I would like to add a VisualCpp compiler from Visual Studio <2017 to the system path and have Gradle discover the correct version from the installation directory so that this information can be included in publications of my library.
Eventually, this will also feed into better modeling of toolchain requirements as I can specify a version of the toolchain that I want and Gradle can find it even it it is only on the system path.
Implementation Notes

If the version is also found in vswhere or the registry, we already find the version from that information.  This only applies to scenarios where the installation is only found on the system path.
For Visual Studio 2017, the version can be inferred from the path to the compiler as the version is baked into the directory structure (this is already implemented).
For previous versions, probing the compiler is not useful as it returns an unrelated version (see https://stackoverflow.com/questions/1233312/finding-version-of-microsoft-c-compiler-from-command-line-for-makefiles).  Probing the linker, on the other hand, seems to return a version consistent with other sources (i.e. the registry).  This was only tested on VS2015 and VS2013 - we should also check VS2012 and VS2010.

Test Cases

Can infer the VisualCpp version of a compiler from a version of Visual Studio <2017 that is only found on the system path.
A compiler found on the system path that we cannot infer the version from is ignored.

This is not necessary with #256.  We don't expect to find Visual Studio installations we haven't already discovered.


Correct typo mixing up space and newline symbols

In the examples given, Ġ denotes a space while Ċ denotes a newline, but the explanatory text says the reverse. This PR fixes this mistake in the text.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


🐛 [BUG]: Hovering on a Custom Edge causes jitter

Is there an existing issue for this?

[X] I have searched the existing issues and this is a new bug.

Current Behavior
I have a custom edge where in I listen to 2 events -> mouseEnter and mouseLeave.
On mouseEnter I set it to animate and change the color while having a custom div rendered on top of the edge as mentioned in the examples using EdgeLabelRenderer
On mouseLeave I reset the things which were done on mouseEnter
As you see in the attached video, when the mouse is on top of the edge it works fine. But when it is on top of the custom div element, it causes jitter
https://github.com/bcakmakoglu/vue-flow/assets/40317596/6cd10bc3-c669-44ea-b7eb-ea14a042636f
Expected Behavior
Ideally this shouldn't happen. Not sure if the event is being propagated to the background or not.
Steps To Reproduce
No response
Relevant log output
No response
Anything else?
No response

Can you provide a reproduction for this issue?
You can find a template here: https://codesandbox.io/p/sandbox/vue-flow-basic-gfgro4

Hey @bcakmakoglu !
I have reproduced the issue in the given sandbox. Can you please check the same?

Well you need to send me a link to the sandbox 😅
What I sent you is the template which you have to fork from, you send me the link to your fork 😉

Oops sorry! Missed attaching the link
Here you go @bcakmakoglu

Well, this is technically no bug with Vue Flow at all.
What is happening is this:
You bind mouse-enter and mouse-leave events (that's ok) - then you show the EdgeLabelRenderer
But when the mouse goes to that element, mouse-leave will be triggered -> the label is hidden
Because the label is hidden, you are hovering the edge again -> the label is shown
and this keeps repeating itself (hence the jittering effect)
For this to work properly, you would also have to catch mouse-enter and mouse-leave events for the label you're using and update the edge animated property and the edge.data.isHover flag.
Here's a working sandbox.


golangci-lint: update rules to match core

There are only five outstanding problems. Four of them are exported names, so I only fixed the other one.

Fixed the tests


Proper reading procedure

I understand that this is more of a AMQP specific, but is there some predefined method how to read the queue with timeout on when to stop reading?
Context
I run two tokio::spawn tasks:

Publisher that posts messages with 250mcsecs interval
Reader that reads thow messages.

The whole thing is rather POC, but I need it to be the one process, and in this case do not really see the difference if it were separate crate.
So what I am struggling with is the fact that with while let Some(delivery) = sub.next().await { expression I don't see the way how I can stop reading ONLY IF the last message was read for example 2 secs ago.
Maybe it is my lack of knowledge in async but if some1 would point me in the right direction I'd appreciate it!

Wouldn't you be able to make your own cancellation with tokio::select! for example? https://docs.rs/tokio/latest/tokio/macro.select.html#

You could indeed use some timeout future machinery, and call basic_cancel if you hit the timeout.

That's what I ended up doing :man_shrugging:

           let sleep = tokio::time::sleep(Duration::from_secs(2));
            tokio::pin!(sleep);
            let delivery = tokio::select! {
                success = sub.try_next() => Ok(success?),
                _ = &mut sleep => Err(anyhow::anyhow!("No messages"))
            };

I'm sure it can be done better.
It would be cool to have such functionality built-in though.
I guess a wrapper providing this escape hatch is fine but not pretty.

Consumers offer you better ack management but cancel is racy by design, like while you're cancelling the server still sends messages in background. Basic_get is oneshot this way you can handle termination more freely and as a bonus you get how many messages were in the queue when delivering you the message in the metadata. Only caveat is that's it's really a polling approach and not a push/notif one. This has advantages and drawbacks but might very well fit your use case. Like you can basic get + sleep 0.25 and store a timestamp when receiving a message, and when not receiving one you compare with the time stamp stored and decide if you want to continue or not


Revert "python: pykeepass: 3.0.2 -> 3.0.3"

This reverts commit 9cdb255a87815433609859a95eb9a0ae08b84c71.
Motivation for this change
This package build is currently broken on master. Fixes #56612
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Assured whether relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Sorry for the confusion. Read will open a PR fixing the new version instead.


Add an end-to-end guide for Kubeflow on Kubernetes Engine

We have a getting-started guide for Kubernetes Engine, which uses the gke deploy script:
https://www.kubeflow.org/docs/started/getting-started-gke/
We need an end-to-end guide as well, to act as a "hello world" for people wanting to try out Kubeflow on Kubernetes Engine.

/assign

/close


[Go][CI] Remove Go related test CI except integration test

Describe the enhancement requested
After apache/arrow-go#1.
We can remove the followings:

https://github.com/apache/arrow/blob/main/.github/workflows/go.yml
Go related parts in https://github.com/apache/arrow/blob/main/dev/tasks/tasks.yml
Go related parts in https://github.com/apache/arrow/blob/main/docker-compose.yml

We should not remove integration test. It's still needed after apache/arrow-go#1 to ensure compatibility. (We need to update integration test but it's out-of-scope of this.)
Component(s)
Continuous Integration, Go

Issue resolved by pull request 44143
https://github.com/apache/arrow/pull/44143


2D -> 1D Reshape fails with ttnn::Reshape, but works by directly calling tensor.reshape

Describe the bug
ttnn::Reshape doesn't work when squeezing the last dim of a 2D row major device tensor - getting error Unable to reshape given tensor!. However, directly calling tensor.reshape works.
To Reproduce
This fails:
std::array<int32_t, 1> newShape = {32};
// Here tensor is a 32x1 row major single-device tensor
ttnn::reshape(tensor, newShape);

This works:
std::array<int32_t, 1> newShape = {32};
// Here tensor is a 32x1 row major single-device tensor
tensor.reshape(newShape);

cc: @AleksKnezevic @mrakitaTT

solved here: https://github.com/tenstorrent/tt-metal/pull/13022
will merge soon

Thanks for the quick fix @ntarafdar!!!

merged in, I'm closing issue for now, feel free to re-open if main isn't still working for your case.


Add error message for when list is empty and related tests

Codecov Report

Merging #264 (f7fc63e) into master (674d492) will increase coverage by 0.66%.
The diff coverage is 95.83%.

@@             Coverage Diff              @@
##             master     #264      +/-   ##
============================================
+ Coverage     76.18%   76.84%   +0.66%
- Complexity      900      928      +28
============================================
  Files           130      130
  Lines          2591     2639      +48
  Branches        310      333      +23
============================================
+ Hits           1974     2028      +54
+ Misses          511      506       -5
+ Partials        106      105       -1

Impacted Files
Coverage Δ

...main/java/seedu/address/commons/core/Messages.java
0.00% <ø> (ø)

...du/address/logic/commands/ClearMembersCommand.java
66.66% <0.00%> (-33.34%)
:arrow_down:

.../address/logic/commands/AllocateMemberCommand.java
85.00% <100.00%> (+12.77%)
:arrow_up:

...address/logic/commands/ClearAttendanceCommand.java
100.00% <100.00%> (ø)

...address/logic/commands/ClearFacilitiesCommand.java
100.00% <100.00%> (ø)

...ddress/logic/commands/DeallocateMemberCommand.java
72.97% <100.00%> (+3.27%)
:arrow_up:

.../address/logic/commands/DeleteFacilityCommand.java
100.00% <100.00%> (ø)

...du/address/logic/commands/DeleteMemberCommand.java
100.00% <100.00%> (ø)

...du/address/logic/commands/EditFacilityCommand.java
93.65% <100.00%> (+0.20%)
:arrow_up:

...eedu/address/logic/commands/EditMemberCommand.java
96.77% <100.00%> (+0.10%)
:arrow_up:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 674d492...f7fc63e. Read the comment docs.


Add Coinbase Pay support

Test App ID: ca72edbc-0a08-468c-952d-6cde50b1dce6
https://docs.cloud.coinbase.com/pay-sdk/docs
cc @jonastgerber

Got this far but Stacks isn't listed and get an invalid address (expected) if I selected anything else...

Coinbase indicated that Stacks should be listed already, so I'm not sure why it's not showing. I've CC'ed you on an email to them to learn more.

@fbwoolf try adding the item as an asset as STX

@markmhx success...
https://explorer.stacks.co/txid/0x3fec963a3757b58b991475ea6280ca46193c22cd7db5738a5448c0da8f3e8b27?chain=mainnet