How does this compare to proselint?

:wave: Hi there this project looks very interesting! Wondering in terms of what it checks, how does it compare to proselint? With the retext and unified system this certainly seems much more extendible.

Thanks @Siilwyn!
Both are pretty cool, imo, but in my biased view I like retext better.
retext also tries to be smart about things, by using an AST instead of regexes.
The fact that HTML (with rehype) and Markdown (with remark) can be used too, aka unified, is very cool.
The pro of prose lint is that it supports a ton of checks. retext doesn’t support so many things. But, in my experience proselint rules can be ported over quite easily, so if you’re missing something you could create your own plugins!


Can't "make" on Kali 2016.2

Hi
Compilation by "make" worked first time on old Kali, having issues with later Kali (2016.2). First I got:
hash_extender_engine.c:25:25: fatal error: openssl/md4.h: No such file or directory
I solved this by locating md4.h and added a -I/path/to/file in the CPPFLAGS of the Makefile. Next I got:
/usr/bin/ld: cannot find -lssl
/usr/bin/ld: cannot find -lcrypto
I found a ssl.so and crypto.so in different and pretty random-looking places. But I went ahead and added -L/path/to/file (twice to cover both files) in the LDFLAGS of the Makefile. But no joy.
Needless to say my make/gcc skills aren't great so help appreciated where Google is letting me down.
Cheers

Try installing libssl-dev (I think that's what it's called). That might
help!
On May 31, 2017 9:04 AM, "exploresecurity"<EMAIL_ADDRESS>wrote:

Hi
Compilation by "make" worked first time on old Kali, having issues with
later Kali (2016.2). First I got:
hash_extender_engine.c:25:25: fatal error: openssl/md4.h: No such file or
directory
I solved this by locating md4.h and added a -I/path/to/file in the
CPPFLAGS of the Makefile. Next I got:
/usr/bin/ld: cannot find -lssl /usr/bin/ld: cannot find -lcrypto
I found a ssl.so and crypto.so in different and pretty random-looking
places. But I went ahead and added -L/path/to/file (twice to cover both
files) in the LDFLAGS of the Makefile. But no joy.
Needless to say my make/gcc skills aren't great so help appreciated where
Google is letting me down.
Cheers
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/iagox86/hash_extender/issues/9, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAgITNjlzu8Bz-StCCY9v-Yq9OhU9bChks5r_Y98gaJpZM4Nr2bj
.

Yup - that's it! That must have added the necessary header files and libraries in a much nicer and cleaner way than scrabbling around the file system!
Cheers

Woohoo! I should probably add a readme file one day. :-)
On May 31, 2017 9:27 AM, "exploresecurity"<EMAIL_ADDRESS>wrote:

Yup - that's it! That must have added the necessary header files and
libraries in a much nicer and cleaner way than scrabbling around the file
system!
Cheers
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/iagox86/hash_extender/issues/9#issuecomment-305241535,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAgITNuqIQXm4Htn44Eh5vrr_uSbf1Tcks5r_ZTHgaJpZM4Nr2bj
.

This helped with compiling on mac! Thank you

after installing libssl-dev I get the following error message for all the other hash,update and init functions
hash_extender_engine.c: In function ‘md4_hash’:
hash_extender_engine.c:362:3: error: ‘MD4_Init’ is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]

Hmm, that's annoying! We could turn off MD4 on certain systems, but maybe we can just disable that warning?
You might be able to fix that by removing -Wno-deprecated from the Makefile (as a workaround)


[Proposal] runv support user defined kernel version

pouch now support hyper runv,  beside this, we can privide a general solution which can support user to use their own kernel verson.
we offer some scripts and prepared image file for qemu, user may provide a kernel code as input, a kernel and a img will as output which can apply to runv.

I think this has been done by @Ace-Tang and Haoyu. However, it is not so easy to open source this part. And this part is included in pr https://github.com/alibaba/pouch/pull/1442.

Close this, since we update to use kata, we will do new work on kata.


run script instead of URI ?

Is there an easy way to modify the code so that instead of making an API call to a URL, it can instead execute a bash script? Calling a method in the main fauxmo.py file could be ok too.
I have very little experience with python, so I don't instantly see how to accomplish this, but if there's a quick way it would be better for me than the alternative of setting up a web server on the Raspberry Pi and writing a handler to receive the call and then execute the script/code; seems nicer to do it directly.
What I am trying to achieve is to integrate this with a 433MHz library to send pulses over GPIO to a transmitter installed on the Pi, so Alexa can control regular (cheap) 433 power sockets.

Check out my fork of this project. I added a handler for controlling GPIO pins on a Pi. I was turning relays on and off but you could easily change the code in the ON/OFF section.
OldNo7/fauxmo

thank you, that helped show me the correct way to do it (plus, my hack wasnt working!)
I've now added a "rf_handler(object)" class to send the codes, and added a 100ms sleep after sending because when multiples were activated at once, sometime they didn't all trigger.
Got it working perfectly now; voice control over five outlets without breaking the bank!


Fix Markdown header link syntax in README

GitHub won't render these as intended unless there's a space between the heading indicator and the start of the link.

Thanks a ton!


Make alloc optional (embedded rust)

Proposition:
I wonder if is it possible to make alloc optional. As far as I have checked the source code the main problem for make alloc optional is with implementation of Bytes and BytesMut that require alloc to work. To support partially bytes for embedded devices where alloc is not an option theses structs need re-implementation and this is complicated subject. Things that can be introduced to embedded word are Buf and BufMut traits and this works nearly out of the box.
Motivation:

common interface for bytes on every level of rust

Here is example where alloc crate is a problem:

example crate that used bytes with motivation above. This was done in 28 PR
problem that MR generated: https://github.com/braun-embedded/rust-ieee802.15.4/issues/33

Crate that could benefits from proposed changes:

https://github.com/braun-embedded/rust-ieee802.15.4
https://github.com/xoac/static-bytes

As said in https://github.com/tokio-rs/bytes/issues/461#issuecomment-763360588, I don't think it's possible without breaking changes. See also https://github.com/crossbeam-rs/crossbeam/pull/508#discussion_r427969049.

So now the question is a little bit political. Are authors interested to make bytes crate embedded devices friendly? Since this issue was know before first major release maybe "not make alloc optional" was considered decision?
I think breaking changes are not a problem here, since you can just simply increment major release.

The main problem is that we recently released v1 and don't want to release v2 right away.

Since this issue was know before first major release maybe "not make alloc optional" was considered decision?

I don't think there was such a decision. I knew about such an issue, but I wasn't noticed that bytes had a similar issue until  #461 reported.

There is a way to achieve embedded compatibility (and I hope MSRV 1.36) without breaking bytes API: jut move the traits only to a separate bytes-traits crate and reexport/implement them here. The embedded consumers can simply depend on that crate instead of bytes. I'm willing to make a PR for this.

There is a way to achieve embedded compatibility (and I hope MSRV 1.36) without breaking bytes API: jut move the traits only to a separate bytes-traits crate and reexport/implement them here. The embedded consumers can simply depend on that crate instead of bytes. I'm willing to make a PR for this.

Note that in this approach, it will break if the user runs cargo update after implementing the traits provided by the old version of bytes crate and the traits provided by bytes-traits crate.

@taiki-e isnt's it the same problem as having two different versions of a crate?

@Kixunil "the old version of bytes crate" meant the 1.x.y version that does not contain the changes you suggested.
They are different traits in the 1.x.y version that does not contain the changes you suggested, but they are the same trait in the version that contains the changes.

I don't think it's a problem though. Either you have two version of the bytes crate but the same problem would happen without reexport or you have a single version and then it's non-issue.
I think you're describing this situation, please LMK if you mean something else
assuming bytes_old -> bytes_new is a minor or patch release, bytes_new moves the trait to a separate crate

A depends on bytes_old

B depends on bytes_old

C depends on A and B, supplying A with types from B

B changes to implement the traits from bytes-traits and stops depending on bytes

C updates the version of B without updating bytes_old

C no longer compiles
In this case B is the one doing breaking change, not C.
B can also trivially improve it using the semver trick:

B_non_breaking depends on B_breaking AND bytes_new
B_breaking implements the change

Wouldn't it be possible to have alloc as a default feature flag the way that serde does it?
As I see it, the only people that would be affected by that change would be the no_std group which have set the default-features = false, and not the wider audience that uses std via the default features.

@nils-van-zuijlen Please read previous comments (https://github.com/tokio-rs/bytes/issues/479#issuecomment-776539743 and https://github.com/tokio-rs/bytes/issues/479#issuecomment-778177512).

@taiki-e I think I addressed that in my comment. Is there a specific scenario I'm missing?


[Accordion] renders components even when it's closed.

Does this library render components even when they are hidden? For example, ExpansionPanel. It appears that this component renders everything inside even when it's closed by default. What if you have components inside of there that have extensive functionality going on and you had 20 expansion panels doing the same thing and the user only opened one of them? Doesn't this seem inefficient  running through functionality of several components that may never even be seen by the user?
I am aware that I could potentially look at the onClick function and find out if the panel is expanded or not then render the component, but it seems like this should be a default behavior of the ExpandedPanel or any component that show/hides components.

[ x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
Only render components inside the ExpansionPanel when it's open. Unmount components inside the ExapansionPanel when it is closed.
Current Behavior
Renders component regardless if the ExpansionPanel is open or closed.
Steps to Reproduce (for bugs)
Check out the console.logs for the sandbox below. They kick off regardless of the ExpansionPanel being closed.
https://codesandbox.io/s/lyo2m9ky0q

@jbsmith969 This issue shares some root cause with #10183. You are free to change the behavior. The following option disables the rendering of the component in the DOM.
<ExpansionPanel CollapseProps={{ unmountOnExit: true }}>

https://codesandbox.io/s/p9z3jk639x

it seems like this should be a default behavior of the ExpandedPanel or any component that show/hides components.

This is an interesting point to discuss. It's a tradeoff. By not mounting the hidden content you will make the content unreachable for SEO and increase the responsiveness as more work is going to be needed by the browser to display the content at the click interaction. On the other hand, mounting everything makes to initial reconciliation of the page slower.
I'm happy to change the default behavior of the ExpansionPanel. Do you want to submit a pull request?

I would like to chip in here, i have a usecase where it is benefitial to have to content rendered all the time to make form submits easier (even if they are not visible). It's a settings page where to expansionPanel is used to seperate the form into sections (where some details are most of the time not really important).
Would be great if there would be a solution where it is up to the user to decide if the expansion panel content should render initially (i guess unmountOnExit is this option already?).
Besides that, if the use case of not rendering at first is more often used then it probably makes sense to make this the default behaviour and adapt the documentation to inform users about this.

@oliviertassinari  I had the same issue, and the CollapseProps works for me, thanks. Personally, I think not rendering children unless the panel is open is more intuitive.

Hey @oliviertassinari! Thanks for the response. Sorry, I must have missed that unmountOnExit prop when searching through docs. Do you think we could make that name a little more intuitive since it seems to also prevent rendering from your description? That may have been why I missed it. I'll give that prop a shot to see if that works. If I can find some time, I'll try to make some changes to the code and make a pull request. I'm leaning towards not rendering children by default and a prop to render children for cases like SEO and what @Loktor brought up.

Would be great if there would be a solution where it is up to the user to decide if the expansion panel content should render initially

@Loktor I agree, it's a problem we have already been facing and solved on the Modal side: #10572.

Besides that, if the use case of not rendering at first is more often used then it probably makes sense to make this the default behavior and adapt the documentation to inform users about this.

Yes, I do think that the unmounting should be the default behavior. You will most likely render many items with the ExpansionPanel component. It can greatly improve the initial rendering this way.

Sorry, I must have missed that unmountOnExit prop when searching through docs.

@jbsmith969 You won't find this key in our documentation. It's a property implemented by react-transition-group library.

If I can find some time, I'll try to make some changes to the code and make a pull request.

Oh great! I think that we should implement the same approach than with the Modal: a keepMounted property.

If no one has picked it up yet , I'd like to give this one a go

@oliviertassinari Don't we need to set {mountOnEnter :true} to prevent an ExpansionPanel from rendering hidden child components when it's first mounted? I don't see the point of using unmountOnExit here for most use cases.

mountOnEnter
By default the child component is mounted immediately along with the parent Transition component. If you want to "lazy mount" the component on the first in={true} you can set mountOnEnter. After the first enter transition the component will stay mounted, even on "exited", unless you also specify unmountOnExit.
type: boolean
default: false

unmountOnExit
By default the child component stays mounted after it reaches the 'exited' state. Set unmountOnExit if you'd prefer to unmount the component after it finishes exiting.
type: boolean
default: false
http://reactcommunity.org/react-transition-group/transition

If you use the unmount option, is the content still on the page for Readers? If the content is not on the page, then this is not an accessible option.  I solved this yesterday but looping through the links and toggling the tabIndex between -1 and 0, which seems to have the proper functioning, but it would be nice if this behavior was not only baked in but default.

Just an update, on version 4.2.1 uses TransitionProps
<ExpansionPanel TransitionProps={{ mountOnEnter: true }}>

We've added a section to our docs describing different tradeoffs:

The content of ExpansionPanels is mounted by default even if the panel is not expanded. This default behavior has server-side rendering and SEO in mind. If you render expensive component trees inside your panels or simply render many panels it might be a good idea to change this default behavior by enabling the unmountOnExit in TransitionProps: <ExpansionPanel TransitionProps={{ unmountOnExit: true }} />. As with any performance optimization this is not a silver bullet. Be sure to identify bottlenecks first and then try out these optimization strategies.

-- https://material-ui.com/components/expansion-panels/#performance

Thanks everyone for your amazing contribution! An idea to get the best of both worlds in this case:
unmountOnExit could be accompanied by a renderClosedContentForSEO or something of the rather. The function would build a long simple string with all the SEO juice goodness we want, and be hidden in some div, so only crawlers see it.
This way we don't render complicated DOM that is hidden, but do publish all the content we want for the crawlers
WDYT?

Thanks everyone for your amazing contribution! An idea to get the best of both worlds in this case:
unmountOnExit could be accompanied by a renderClosedContentForSEO or something of the rather. The function would build a long simple string with all the SEO juice goodness we want, and be hidden in some div, so only crawlers see it.
This way we don't render complicated DOM that is hidden, but do publish all the content we want for the crawlers
WDYT?

@odedbendov This sounds like cloaking, not great, but it can be implemented by unmounting the accordion when hidden, and rendering something else in place, visually hidden.

Any plans of having the same feature available for Joy-ui?
Or is there an elegant way of unmounting  on exit?

The child components still render even when the Accordion is not expanded.

@CalvinJamesHeath
child are rendered but visibility is hidden

@mib00038
I have big component tree nested inside many accordions, and its unefficitent because it slows down the app performance, is there a way to only render the accordion details when its expanded but without breaking the animation transition?
because if I add some simple logic inside the accordion like
<Accordion>
//code
{expaned === 'config' && (
<AccordionDetails>
//components
</AccordionDetails>
)}
<Accordion />

But that unfortunately breaks the smooth expanding transition.

@CalvinJamesHeath
As per the API docs here
If you render the Accordion Details with a big component tree nested inside, or if you have many Accordions, you may want to change this behavior by setting unmountOnExit to true inside the slotProps.transition prop to improve performance:
<Accordion slotProps={{ transition: { unmountOnExit: true } }} />
Does this help ?

Yeah I already had all that set. The AccordionDetails childs also get mounted even though the accordion is not expanded. I wanted to see if there was a way not to mount them to increase performance.

I agree with @CalvinJamesHeath , I think it might be related to this error message:
Warning: React does not recognize the `slotProps` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `slotprops` instead. If you accidentally passed it from a parent component, remove it from the DOM element.

Chrome suggests to use instead slotprops, which of course doesn't work. I was working with MUI v.5.11.2 and using
TransitionProps={{ unmountOnExit: true }}

works fine, but on v.5.11.15, this is deprecated and slotProps is not doing its job when using the suggested
slotProps={{ transition: { unmountOnExit: true } }}

A similar issue was reported here:
https://github.com/mui/mui-x/issues/10072

@CalvinJamesHeath As per the API docs here
If you render the Accordion Details with a big component tree nested inside, or if you have many Accordions, you may want to change this behavior by setting unmountOnExit to true inside the slotProps.transition prop to improve performance:
<Accordion slotProps={{ transition: { unmountOnExit: true } }} />
Also try moving your expaned logic into the Accordion expanded prop: ie <Accordion expanded={expaned === 'config'} >
Does that help ?

Setting slotProps={{ transition: { unmountOnExit: true } }}  worked perfectly in my case, thanks a ton! 🙌


Revert "[VP9e] Use vaSyncBuffer in VAAPIEncoder::QueryStatus"

This reverts commit fa8db613c8ec13fdf572777436b330138cf8ccb6.

@daleksan , please put the reason in git commit message

@daleksan , please put the reason in git commit message

Done: This fixes #2392

I'm about to merge it @daleksan but one QQ, will you prepare the same commit against master?


Adapt to repository migration

Change https://github.com/tarruda/libmpack references to
https://github.com/libmpack/libmpack.
Remove lua binding, which is now at https://github.com/libmpack/libmpack-lua.

Changes Unknown when pulling 08a4d8d9073f8522178ed1874dc67a808571b9b2 on migrate-repository into ** on master**.


project_tools.sh broken on MacOs

Explained in detail

I can submit a patch, but wanted to discuss the appropriate way. I suggest changing project_tools.sh to use python3, and checking for its existence, then changing add-line.py to print(...) instead of print.
Obviously there is more than one way to do things, but this seems to be the approach of least surprise and doesn't encourage users to install EOL software.
Thoughts?

This is also broken on Mac because of this
This requires editing the Podfile and a little dance with Xcode. There's probably a way to edit the .xcodeproj without using Xcode, but I haven't attempted to figure that out.


Update embedded LDAP to Apache DS 2.0.0-AM25

The current LDAP version 1.5.7 is not supported in Java 8. To make the product supported in java 11. we want to update the embedded LDAP version to 2.0.0-AM25

fixed with https://github.com/wso2-extensions/identity-userstore-ldap/pull/24


After upgrading to Org 9.5, C-c C-c in capture templates tries to add a heading tag.

What did you expect to happen?
C-c C-c in a capture should save it.
What actually happened?
C-c C-c in a capture tries to add a heading tag (via the new CRM interface).
Describe your attempts to resolve the issue
See first comment.
Steps to reproduce

Run doom upgrade
try saving a capture template

System Information
https://pastebin.com/FhDgrPHc

Not sure why, but in a capture template C-c C-c will try to add a headline tag (using the new CRM interface). If I run it in the body of the capture, I get "C-c C-c can do nothing useful here".
I found that opening my the target todo file and saving it fixes this. Workaround config:
(save-window-excursion
  (find-file my/org-roam-todo-file)
  (save-buffer))

Can't reproduce on vanilla doom. Closing.


Deployments via AWS Elasticbeanstalk Fail

This isn't working for me when deploying using ElasticBeanstalk and CodePipeline on AWS.
This is what I have for my Dockerfile, which was generated via this library.
FROM node:16-alpine
RUN apk update && apk add  build-base gcc autoconf automake zlib-dev libpng-dev nasm bash vips-dev
ARG NODE_ENV=development
ENV NODE_ENV=${NODE_ENV}
WORKDIR /opt/
COPY ./package.json ./yarn.lock ./
ENV PATH /opt/node_modules/.bin:$PATH
RUN yarn config set network-timeout 600000 -g && yarn install
WORKDIR /opt/app
COPY ./ .
RUN yarn build
EXPOSE 1337
CMD ["yarn", "develop"]

The build fails and I can't even get the logs printed out.
I'm using the latest Docker Image (Docker running on 64bit Amazon Linux 2/3.4.18) and deploying through CodePipeline.
I'm not doing any builds on the server. If ElasticBeanstalk sees a Dockerfile it will build without any issues.
My previous Dockerfile worked fine until they updated the dependencies in Strapi to require NodeJS 14.19+.
FROM strapi/base

WORKDIR /4track-strapi

COPY ./package.json ./
COPY ./yarn.lock ./
COPY ./providers/ ./providers

RUN yarn install

COPY . .

ENV NODE_ENV production
ENV ENV_PATH .env

RUN yarn build

EXPOSE 1337

CMD ["yarn", "start"]

Any help would be very much appreciated.

Thanks for your question.
one you are using is the strapi/base which is built for strapi 3.
The plugin is using Strapi 4 btw as there is a difference in folder structure. Though the dockerfile should work
Does this fail during the pipeline build, does it build locally ?
If it fails in the pipeline make sure your using the nodejs platform that is supported
https://docs.aws.amazon.com/elasticbeanstalk/latest/platforms/platform-history-nodejs.html

Thank you for the reply.
We are not using a NodeJS Image and the pipeline is not executing a build step. The build fails when it’s being deployed on Elasticbeanstalk. Elasticbeanstalk will recognize the Dockerfile and run it during deployment so it’s failing when the Dockerfile is run. Unfortunately I can’t even get the logs to generate so I’m unable to share those.
The strapi/base image worked for this up until the NodeJS version required changed to 14.9+.
Jameson W Parker

On Aug 17, 2022, at 3:53 AM, Simen Daehlin @.***> wrote:

Thanks for your question.
one you are using is the strapi/base which is built for strapi 3.
The plugin is using Strapi 4 btw as there is a difference in folder structure. Though the dockerfile should work
Does this fail during the pipeline build, does it build locally ?
If it fails in the pipeline make sure your using the nodejs platform that is supported
https://docs.aws.amazon.com/elasticbeanstalk/latest/platforms/platform-history-nodejs.html
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.

Eventually I got this to work.
This is what I ended up with in my Dockerfile.
FROM node:16-alpine

WORKDIR [root_directory_name]

RUN apk update && apk add  build-base gcc autoconf automake zlib-dev libpng-dev nasm bash vips-dev

COPY ./package.json ./
COPY ./yarn.lock ./

RUN yarn install

COPY . .

ENV NODE_ENV production
ENV ENV_PATH .env

RUN yarn build
EXPOSE 1337
CMD ["yarn", "start"]

Oh i see what you changed.
Glad you got this worked, I will close this ticket.
But it seems that it was the workdir then.


[release-1.10] test framework: move from IstioVersions to Revisions

This is an automated cherry-pick of #32518

@istio-testing: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


London|Phone Naing|Module-User-Focused-Data|Week1

Learners, PR Template
Self checklist

[✅ ] I have committed my files one by one, on purpose, and for a reason
[ ✅] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
[✅ ] I have tested my changes
[✅ ] My changes follow the style guide
[ ✅] My changes meet the requirements of this task

Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.

I did resolve all the issues

Have you checked the results after your changes?  I don't think they match the wireframe anymore


Allow Custom SSL-Certificates

I suggest to add a command-line option to allow setting a custom SSL-certificate.
ssl_context can be set with a touple of (certificate.pem, key.pem).
When using Let's Encrypt you are provided with fullchain.pem and privkey.pem.
I suggest a command-line option like this:
updog --ssl-cert fullchain.pem --ssl-key privkey.pem

This one can do it: https://github.com/patrickhener/goshs

Just modify main.py
   ssl_context = None
    if args.ssl:
        #ssl_context = 'adhoc'
        ssl_context=('/etc/letsencrypt/live/domain.com/cert.pem',
                     '/etc/letsencrypt/live/domain.com/privkey.pem')

Ipened a pull request for this feature here: https://github.com/sc0tfree/updog/pull/67


Change icon from the blue "Google Chrome" icon to something more unique to Ungoogled-Chromium (and less "Googley")?

Just a suggestion...
Thanks and keep up the good work.

Related: #759

maybe putting a U on the middle of the chromium icon,

I consider changing the icon to be rebranding the browser. I historically disagreed with rebranding because I think it sends a wrong message about what ungoogled-chromium is. However, I do see the value in adding some small indications that the browser is ungoogled-chromium and not Chromium.
I would be willing to have an option for (not require!) ungoogled-chromium builds to include small changes of this manner. Perhaps these changes would be suitable for contrib?

Well, at least shortcut icons can be changed when packaging, dunno if icons that appear inside chromium can, like the one in the about chromium page

or chromium://version

Otherwise, icons could be uploaded to the contrib repo, might need someone to polish them first though.

Was actually thinking something a bit more of a departure from the logo entirely - something entirely original, something that captures the spirit of the project instead of still being derivitive.

entirely original

But this project is a derivative in a large part.

entirely original

But this project is a derivative in a large part.

The decision to remove Google's code was original.  I was referring to honouring that, instead of the original project.

In the spirit of Elaston's comments (I hope), I had a very quick try at making an icon that's very obviously "Chromium", and still subtly "not Google".. I'm no visual designer so I'm sure somebody else will have a better idea

(I was first looking into turning the center circle into another shape, like a octagon, but it looked clunky and would probably be lost at small sizes. Then I followed jstkdng's idea of including a "U" somehow)

...something entirely original, something that captures the spirit of the project instead of still being derivitive.

For entirely original icon this project must have the entierly original name.
On my opinion the furthest changes could take a place - modify original  chromium icon.
Well, I like the chromium icon, so I think change the colors would be enough.

@jvzr
I like your design, though, that U is really subtle. What if you removed the center shape and had a giant U instead, like how you have now, but remove the upper border from the circle and just have a white border representing the U, also extending the shadows.

I've actually been thinking about this since I installed ungoogled-chromium a few months ago. I agree with @roshiajin-kunai that it should be green. It's clearly different and clearly chromium, just like the project. The chromium icon is a light blue, which is one of the three main colors we see (RGB) (over simplification); a light green is distinct from a light blue yet also RGB and recongnizably similar. It'd be interesting to see, perhaps, how a light green version of @jvzr 's design, which also incorporates the U, would look.

@jstkdng That was my original exploration but it didn't work at all, in my opinion:

@u9000-Nine Something like that? (I tried to be faithful to Chrome's original green hues)

Maybe once a name has been chosen for the project, then focus on a new logo? The project is becoming more and more popular by the day and will probably get Google's attention sooner than later.


Create shop and add shop items

Leave a comment or create and issue and mention this for suggestions on what to add to the supposed shop.

Add a profile function and have people be able to buy badges or cool show-off items. See Mantaro and Tatsumaki for examples.

Add a profile function and have people be able to buy badges or cool show-off items. See Mantaro and Tatsumaki for examples.

Perhaps, but I'll have to look into some image APIs to get things in some sort of format/template lol.


when I turn my switch on and leave the view controller and go back into it, if the switch is enabled it shows the disabled color

when I turn my switch on and leave the view controller and go back into it, if the switch is enabled it shows the disabled color and it's the same for the oopiste could I pay you to fix this please?

Which switch you are trying to use ?

YapAnimatedSwitch:
And here is my test project with your custom switch implemented, it's very simple and basic, let me know If it's me who is doing something wrong? https://github.com/recoveryawareness/UITableViewNoStoryboard/blob/main/UITableViewNoStoryboard/Source/ViewControllers/CustomSwitchesGalleryViewController.swift

thank you so much for fixing this issue, should I close the issue now?

yeah you can close it now. Thank you


Proposal: Smart Margins

The left, right, top, bottom margins rely on glyph bounds, which is fine for most work. There are times when it would be nice to be able to specify the y (in the case of left, right) where we want the measurement to be taken instead of the bounding box. I started writing this for a tool, but then realized that it might be useful in fontParts. Here's the idea (for left, right for now, but top, bottom are similar):

the y value is defined with a guideline
the guideline can be located at the font or glyph level.
glyph guidelines override font guidelines.
guidelines may be defined for use on both sides, the left or the right by setting the guideline name: margins, margin-left, margin-right`
side specific guidelines override both side guidelines.
if a side specific guideline is not defined, the base leftMargin or rightMargin value is used.

These would be accessible through properties, just like leftMargin and rightMargin. The names that popped into my head were smartLeftMargin and smartRightMargin but I don't really like the vagueness of smart. It implies magic but there is no magic in this. Maybe something like local*Margin? I don't know...
Here is a quick implementation:
from fontPens.marginPen import MarginPen

def getSmartMargins(glyph):
    font = glyph.font
    both = None
    left = None
    right = None
    # look for glyph level guidelines
    while any((both is None, left is None, right is None)):
        for guideline in glyph.guidelines:
            if guideline.name == "margins":
                both = guideline
            elif guideline.name == "margin-left":
                left = guideline
            elif guideline.name == "margin-right":
                right = guideline
        break
    # use font guidelines if there
    # glyph level guidelines are
    # not defined
    buffer = 10
    if all((font is not None, both is None, left is None, right is None)):
        buffer = font.info.unitsPerEm * 0.01
        while any((both is None, left is None, right is None)):
            for guideline in glyph.guidelines:
                if all((both is None, guideline.name == "margins")):
                    both = guideline
                elif all((left is None, guideline.name == "margin-left")):
                    left = guideline
                elif all((right is None, guideline.name == "margin-right")):
                    left = guideline
            break
    # calculate the left
    leftMargin = 0
    if all((left is None, both is None)):
        leftMargin = glyph.leftMargin
    elif any((glyph.contours, glyph.components)):
        if left is not None:
            y = left.y
        elif both is not None:
            y = both.y
        pen = MarginPen(glyphSet=glyph.layer, value=y)
        glyph.draw(pen)
        leftMargin = pen.getMargins()[0]
    # calculate the right
    rightMargin = 0
    if all((right is None, both is None)):
        rightMargin = glyph.rightMargin
    elif any((glyph.contours, glyph.components)):
        if right is not None:
            y = right.y
        elif both is not None:
            y = both.y
        pen = MarginPen(glyphSet=glyph.layer, value=y)
        glyph.draw(pen)
        rightMargin = glyph.width - pen.getMargins()[1]
    # done
    return (leftMargin, rightMargin)

def setSmartLeftMargin(glyph, value):
    oldValue = getSmartMargins(glyph)[0]
    diff = value - oldValue
    glyph.leftMargin += diff

def setSmartRightMargin(glyph, value):
    oldValue = getSmartMargins(glyph)[1]
    diff = value - oldValue
    glyph.rightMargin += diff

Would this be a good addition to fontParts or is this something better left to an extension or something like that?

Any thoughts @benkiel, @LettError , @typemytype?

I really like the idea of being able to approach margin values at a specific height. But that means there needs to be a way to record those heights somewhere in the glyph. Are guides the best medium? These can be angled - is that useful, or complicated?
Also how would this relate to angledMargins? In an italic, with italic margins set?
Would a y value, stored in glyph.lib suffice?
(I don't like glyph.lib solutions, there is an impermanence to them)

It could also be a named anchor, and you'd ignore the x value.

Anchor or guidelines would work. My first thought was anchor but I switched to guidelines because they are already visualized in editors with a line. Extensions could add visualization to anchors (something like a line from the anchor to the intersection in the outline). If we use guides, I'd document that angles should be ignored.
I tried to think about angled margins but my brain melted. I'm sure we can figure it out though.

FWIW, I was thinking how having same functionality for spacing Arabic glyphs a while ago. When I set the margin for many glyphs, a lot of time I want the reference for the margin to be taken from the same height for most glyphs and not the margin that is based on the glyph bounds.


Franklin County: Find town election websites and ballot information

https://www.maine.gov/local/county.php?c=franklin

Data goes in this spreadsheet: https://docs.google.com/spreadsheets/d/1dk58MD0qBAM37BDOZwKIz10hp5AARAIX8u_qvuDnYaI/edit#gid=0


block-size doesn't work

Hi Ted Yin,
I run the demo with (block-size=1, enable HOTSTUFF_ENABLE_BENCHMARK), and it works well:
# run server
$ ./scripts/run_demo.sh
# run client
$ ./scripts/run_demo_client.sh > hs1.txt 2>&1
# run thr_hist.py
$ cat hs1.txt | python3 ./scripts/thr_hist.py

# thr_hist.py output
[437, 420, 485, 458, 479, 493, 468, 469, 504, 491, 420, 439, 489, 483, 462,
475, 456, 460, 513, 515, 231]
lat = 8.476ms
lat = 8.201ms

But when the block-size set to 2, it comes:
$ ./scripts/run_demo.sh

$ ./scripts/run_demo_client.sh > hs2.txt 2>&1

$ cat hs2.txt | python3 ./scripts/thr_hist.py

# thr_hist.py output
[4, 4, 4, 4, 4, 4, 4, 4, 4, 4]
lat = 11658.689ms
lat = 12006.291ms

It falls down dramatically, and the stranger thing is yet to come:
I set the block-size to 8000, it comes:
$ ./scripts/run_demo.sh

$ ./scripts/run_demo_client.sh > hs8000.txt 2>&1

$ cat hs8000.txt | python3 ./scripts/thr_hist.py

# thr_hist.py output
[4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4]
lat = 11787.811ms
lat = 12012.320ms

I didn't figure out why is this happend.

It is normal because you're not loading the system with sufficient amount of pending commands, so the system gets "starved". It could be even worse if you increase the block size without proper increase in the load, since the current code has fix block size and doesn't have fancy heuristics to generate dummy blocks to always make a commit when it is idle (see the evaluation part of the paper for more details). On the other hand, the demo scripts are mostly for the purpose of a minimal setup that runs out of the box, and the logs are human readable, while it is not aimed at being a universal script that can be used to do a fully deployed experiment. To do a more serious one, you'll need to run more clients or try to let each client simulate more command requests --max-async in parallel. The client program code should be short and it is always welcome to contribute some documentation since I've been busy recently...


docs: Fix shell command highlight

3 aliases for this: bash, sh, zsh.

This aliases are for shell scripts. This snippets are not scripts. These are terminal (console) commands so it's the correct aliases from what I know.

This is no styling in docs right now
http://moox.io/statinamic/docs/setup/
See https://github.com/isagalaev/highlight.js/blob/master/src/languages/bash.js

It's an issue with the highlighter, not the syntax itself. For example on github it's fine https://github.com/MoOx/statinamic/blob/add524b5ae0f3907080c6049498fdb34c61d4ba1/docs/content/docs/setup.md#create-a-new-folder (even if there is not a lot of colors.

Github does support the console keyword https://github.com/github/linguist/blob/d9914307eb4dc306d8312d179cb75c78202f7033/lib/linguist/languages.yml#L3360-L3368

even if there is not a lot of colors

That's extracly how it will be after this PR. I'm fine with closing this PR (not much colors)

Maybe we should open one on highlight.js ? FYI, console and shell does not produce the same render from what I know.

Github calls it shell section.

FYI, console and shell does not produce the same render from what I know.

Yeah.

Closing in favor of https://github.com/isagalaev/highlight.js/issues/1126


provide way to create "installers" (.dmg, .msi, .deb etc)

see this thread for the original discussion: https://github.com/maxogden/electron-packager/issues/21#issuecomment-101751502
electron-packager only creates the executables, it doesn't create the installers. I think this is a good level of complexity for electron-packager, so I think someone else should write a e.g. electron-create-installer module or something similar that is a CLI tool that is Unix Philosophy friendly (like this module and the other electron-* modules I've been working on).
resources/existing solutions:

https://msdn.microsoft.com/en-us/library/aa372463(v=vs.85).aspx
https://github.com/Aluxian/Facebook-Messenger-Desktop/tree/master/assets-windows
https://github.com/atom/grunt-electron-installer
https://github.com/domderen/atom-shell-installer

+1, such a tool would be appreciated.

Existing tools for .dmg creation.
https://github.com/andreyvit/create-dmg
https://github.com/LinusU/node-appdmg

It would be nice if the installer creation could be run from one OS (as is currently the case with electron-packager), then one could use CI to automatically generate them for releases. Unfortunately, after searching for cross-platform support for creating .dmgs, it appears that results are mixed.

One of the ways I did this manually was from here.  These installers are much more user friendly.  Would love to be able to generate a .dmg or .msi file.

In OSX, diskutil can be run from the command line, so we could write a wrapper that shells out the commands.  Unfortunately, this approach wont be portable to Win/Linux.

We wrote automated installer generaters for windows and macos last week.
Can probably provide a PR at the weekend, if wished. :bowtie:

@stefanjudis Definitely. ;)

if wished.

I can haz?

@stefanjudis i'd rather have the installer code live in another tool, and not make this module any bigger (its already getting bloated). but sharing your code would be much appreciated :)

@maxogden
Fair enough. Currently it's in a private company repo. But we sure'ly can transfer it.
Any name suggestions for the project then? I see electron-packager is already taken. :)

electron-installer
electron-installer-generator
electron-distributor
electron-bundler
electron-builder
electron-emitter
electron-beam-cannon

Here we go. Will ping you guys on the weekend. :)
https://github.com/stefanjudis/electron-builder

I'll look forward, then. Thank you stefan!

Will tackle it tomorrow. :)
Arnaud<EMAIL_ADDRESS>schrieb am So., 24. Mai 2015 01:50:

I'll look forward, then. Thank you stefan!
—
Reply to this email directly or view it on GitHub
https://github.com/maxogden/electron-packager/issues/33#issuecomment-104955654
.

Hi,
I have built appdmg in Node.js which produces lovely looking dmg-images. We are currently tracking cross-platform here: https://github.com/LinusU/node-appdmg/issues/14#issuecomment-29070031
I think it certainly possible to get it working but there will be a lot of man hours behind it. We do create the .DS_Store files from scratch instead of using Apple Script which most other solutions do. The only large thing that is left is replacing hdiutil, for that we need something that writes an HFS+ file system which might be a bit complicated, although there are open source solutions in the wold.
appdmg is used as such from Node:
var appdmg = require('appdmg');
var ee = appdmg({ source: 'test/appdmg.json', target: 'test.dmg' });

ee.on('progress', function (info) {

  // info.current is the current step
  // info.total is the total number of steps
  // info.type is on of 'step-begin', 'step-end'

  // 'step-begin'
  // info.title is the title of the current step

  // 'step-end'
  // info.status is one of 'ok', 'skip', 'fail'

});

ee.on('finish', function () {
  // There now is a `test.dmg` file
});

ee.on('error', function (err) {
  // An error occurred
});

Instead of passing source: 'file-path' you can also pass opts: { ... } so it should be good to go :+1:

Guys, could anyone clarify, what's the recommended way right now?
AFAIK, for windows it's better to use grunt-electron-installer (official?)
for mac is it ok to use appdmg?
Another question:
Should we use same OS as a target? I mean windows to make windows installer, mac - for mac.

Guys, could anyone clarify, what's the recommended way right now?

A link to electron-builder was added to the README a couple of months ago. Take that as you will. electron-builder also uses appdmg to create .dmg files.

Should we use same OS as a target? I mean windows to make windows installer, mac - for mac.

DMG creation does not currently work on any other OS than OSX. (See: LinusU/node-appdmg#14.) Otherwise, a Windows installer can be created on any (supported) platform. (See electron-builder's README.)

@malept but is there any recommended way?  sorry if it's offtop

@havenchyk it depends on what you mean by "recommended". I personally use electron-builder for Windows installers. Need to figure out how to generate OSX DMGs with it too, even though I don't personally have a copy of OSX.
In fact, since electron-builder exists and is mentioned in the README, I'm going to close this issue. Per @maxogden, providing installers is outside the scope of electron-packager.

@malept sure, thanks for your answers here. If electron-builder is in the readme, it's enough for me

electron-complete-buidler can produce installers (auto-update ready, including Linux deb package), sign it on CI server and publish to GitHub releases.

Ouch. :(
@develar Why not contributing to electron-builder?

@stefanjudis Originally, electron-builder was used under the hood.
But then I released, that I need squirrel-windows installer to build auto-update ready windows app. So, now I use windows-installer to produce windows artefact. It is the main reason why electron-builder is not used.
So, electron-builder was used only to produce DMG. But... why I should use electron-builder if appdmg does the same? So, in the end, electron-builder was removed.

that I need squirrel-windows installer

This will be implemented soon when this https://github.com/electronjs/windows-installer is officially released and we already have a filed issue for that.
Linux installers are also included now.
The only thing that makes me sad, is the creation of a concurrent project which has several contributors and already gained some traction.
Contributing to an existent project doesn't increase noise for users ( like the confusion for windows installers - where I had to scan 5 projects that do the same ), reduces number of concurrent projects and helps existent projects.
As we'll implement the official squirrel thingy we'll end up with two similar projects. :(
Never the less. Good luck with that one.

@stefanjudis To be clear — electron-complete-builder is not yet another tool to produce installers, but tool to combine all existing tools to "just publish my electron" app.

As we'll implement the official squirrel thingy

In this case I will just switch back to use electron-builder again as before.
Do you want to integrate https://github.com/develar/electron-complete-builder#code-signing, https://github.com/develar/electron-complete-builder#build-version-management and https://github.com/develar/electron-complete-builder/wiki/Publishing-artifacts into electron-builder?
I ready to create pull requests and do so (e.g. #251, #255). But I think we should follow Unix Philosophy — Do one thing and do it well.
Do you agree with me or I am wrong? Sorry, but I don't want to have gigantic package.json as you suggest — https://www.npmjs.com/package/electron-builder#how-we-use-it-so-far See my app — https://github.com/develar/onshape-desktop-shell/blob/master/package.json Only one line "release": "npm run compile && build" and app published to GitHub releases.

@develar
Thanks for clarification and I'd love to collaborate. :) Let's move the discussion over to our projects to not create more noise here. :)

The recommended way to build installers (which also happens to use Electron Packager) is Electron Forge.

@malept why not electron-builder? is there any explanation?

There are several reasons for recommending Electron Forge:

It's a better option for developers starting out or creating new Electron apps (just run electron-forge init and it will create a new skeleton Electron app).
You can import existing Electron apps and it will convert it to the best of its ability (electron-forge import).
Electron Forge has more than one co-maintainer (bus factor), some of whom are quite prolific in the Electron community.
Given that this is an issue in the Electron Packager repository: Electron Forge uses Electron Packager, electron-builder has not for quite some time.
In addition to Electron Packager, Electron Forge uses several community-created modules to accomplish much of its tasks, and works with upstream to handle any relevant features/bugs reported in the Forge issue tracker. This also means that the surface area of Forge is much smaller than electron-builder.

There's a bunch of other reasons but they're not particularly relevant to this issue.

@malept well, while init and import options are pretty interesting, I still can't see the reason why you have created new product from the scratch. electron-builder is pretty mature and yes, @develar is the only maintainer, but he made this product as awesome as possible.
If TypeScript was a problem, project could be rewritten to ES2015+ in a couple days, btw @develar already solved a lot of problems in electron-builder and provided pretty interested solutions.
Sorry for this, I know that my comment doesn't relate to electron-packager and issue, but to me this situation looks terrible. Facebook hunted a lot of developers from other products to allow them to do awesome thing inside Facebook, but to my mind you and other developers from community ignored the problem with building application for a quite long time (It was painful experience before electron-builder, really), now you decided to kill electron-builder or provide "choice" (here should go image about 14 standards), it's unacceptable, IMO.

@havenchyk In the entire time I have contributed to Open Source I have never seen a project have to defend the reason for its existence.  That said, unfortunately based on where you seem to be taking this discussion, this will be the first.

I still can't see the reason why you have created new product from the scratch.

This is not the case, as @malept said in his original response we use community maintained modules to provide most if not all of forges functionality.  All forge actually does is wire everything up in an easy to use way.  Actually we even explain this in one of the first lines of our README.
Electron Forge unifies the existing (and well maintained) build tools for Electron
development into a simple, easy to use package so that anyone can jump right in
to Electron development.

To my mind you and other developers from community ignored the problem with building application for a quite long time

I'm not sure how to respond to this, are you somehow under the impression that @malept or I or any other community member was under an obligation of some kind to provide a tool such as -builder or -forge because to clarify, we were not.  The original methods for building an Electron application worked and weren't actually too difficult to understand, lots of the issues people were having were either due to out of date guides (Electron tools moves very quickly) or simply a lack of experience with node.js in general.  While I can agree that -builder simplifies the process for many people it does so in a way that people (@malept and I included) do not feel is the best way for the Electron community and we were sure that we could improve on it in a new tool as such we created -forge.

it's unacceptable, IMO.

I'm confused as to what you think is unacceptable, the fact that we made -forge or the fact we didn't provide a solution to the building problem for a long time.  These two issues you raise actually contradict each other.  I would however like to point out the Electron CoC in particular.
* Being respectful of differing viewpoints and experiences
* Gracefully accepting constructive criticism
* Focusing on what is best for the community

We are of the firm belief that electron-forge is the best direction for the electron-packager and electron community. We understand that some people will disagree with our ideas, opinions or even our code but we sincerely hope that you can accept our reasons and possibly even see what we are trying to achieve with -forge.

@havenchyk electron-builder kamikadzed itself. Orchestrating turned out not to be enough. Couldn't build IOS installers on Windows machines (I remember lots of issues notifying me via email subscription), and RPM's had to be rpmbuilt manually on Linux. So what it was for then.
@MarshallOfSound electron-packager is condemned, and sooner or later I should and need to learn the -forge tool?
Good luck, At least, thanks for electron-packager doing its work, as for installers, I could make it on my own.

@englishextra Electron Packager is fine to use by itself still, but if you need to create installers then Electron Forge is a good, ergonomic option. Particularly if you don't want to glue all the pieces together yourself.
To be clear, Electron Packager is not going anywhere. I'm still maintaining it (I just made a PR this week). It's a pretty significant dependency of Electron Forge. And it's going to stay outside of Electron Forge because, to repeat something I mentioned in a Forge ticket:

We're adhering to the Node community/UNIX convention where modules should ideally be created for one particular concept, and then meshed together in higher-level modules.

@malept electron-packager is my only concern. The rest will be worked out. Yeah-yeah I wouldn't be happy if it is absorbed by some -forge monster. Thanks for your work. Good tool.

@havenchyk electron-builder provides a lot of features that are not covered by forge or any other module. And unlikely will be covered. And targets. And can be used to just pack into distributable format already packed app.  Forge is just another user module, not official electron tool.
Star trend and download counts show what user wants to use. In any case such situation is good for user — competition.
In any case electron-builder is going to be splitted  into several packages (it is not required for users, because electron-builder is a lightweight and no need to reduce external npm deps (only archiver that is used only for squirrel.windows)).


Owon power supply models

Hi,
Do you know which Owon power supply models are supported?
Thanks you!

I think it should work with any that support scpi.
Though I've only tested against SPE6103


How to include inline js in AMP mode with nuxt

I want to use amp-script tag in my template for using external javascript.

you can use v-html to insert the content into  ''


tcp proxy: more trace logs

Risk Level: low (trace logs)
Testing: one unrelated test addition, making sure new connections can be established after a close
Docs Changes: n/a
Release Notes:  n/a
part of #15061

ping!


test: TestV3LeasePrmote flake

--- FAIL: TestV3LeasePrmote (10.51s)
v3_lease_test.go:76: unexpected lease exists

@jpbetz
can you help to reproduce this and get it fixed? thank you!

@xiang90 Digging in now. Is this flaking on Semaphore CI runs?

@jpbetz Yes.

maybe the machine was just slow. but i want to make sure we are not missing anything.

Thanks.
So far the test logic looks correct. I need to review the lease implementation a bit more closely and then I'll decide what to do.
I hate blindly increasing timeout limits on integration/e2e tests to try to keep them from flaking, so I might first add some more testing logic to probe for how long the lease does take to expire if it doesn't expire when the test expects so we can narrow down if this is a timing issue or not.

I hate blindly increasing timeout limits on integration/e2e tests to try to keep them from flaking, so I might first add some more testing logic to probe for how long the lease does take to expire if it doesn't expire when the test expects so we can narrow down if this is a timing issue or not.

100% agree.

As currently written, the test gives 1 second leeway when checking that the lease has expired.
Here are some pass rate numbers from running the test on my dev box with varying leeway on timing.
~0.3% pass rate with 300ms leeway
36% pass rate with 400ms leeway
98.4% pass rate with 500ms leeway
So it's not unreasonable to expect this to fail at a low rate on CI infrastructure a small fraction of the time. I'd expect it to fail at higher rate than on my dev box, since it's a dedicated machine with plenty of resources.
I'll update the test to check repeatedly for the lease to expire for up to 30 seconds, existing immediately with a PASS once the lease expires. This should result in this test running faster on average and be much less likely to flake.

@jpbetz

98.4% pass rate with 500ms leeway

will it approach to 100% if you increase the timeout to say 1.5 seconds? if it is not approach to 100%, i think something goes wrong. i cannot believe a few go routines cannot get scheduled within 1.5s.

Yes, I hit 100% pass rate at 750ms on my dev box before making the changes. I suspect the 1s timeout for the test was somewhere in the P99 range for pass rates on semaphore.

@jpbetz great. thank you.


Displaying the Tooltip component inside the FullscreenModal

For the Brand theme, the Tooltip component is not displayed inside the FullscreenModal component. The problem is related to the z-index for Tooltip.
Problem:

AC:

### Tasks
- [ ] Check how Tooltip is used inside all Paragon Modals components ([Brand Edx org theme](https://github.com/edx/brand-edx.org))
- [ ] Fix display issues

PR: https://github.com/openedx/paragon/pull/2621


codecs_available, fiters_available ordering

I would suggest making those tuples to keep the ordering intact. Is there any particular reason why sets are used? I don't think there are duplicate names in any of those lists.

I wonder if there is any reason to keeping the ordering intact.
I went with sets because I felt the main purpose of having them there was to test if a given codec was available. But... there any many uses so...
🤷♂

One could argue that the pythonic way is to ask forgiveness not permission :) So instead of checking whether something is available you just try to get it and if it fails, then do something about it.
And if we take filters for example, the order is pretty clear:

audio (filters / sources / sinks)
video (filters / sources / sinks)
multimedia (filters / sources)
And everything a-z inside groups. So there's some logic I guess...

There is some overlap in the input / output formats (aka demuxers / muxers), for these the set makes sense;


Write unit tests for the matrix structure kernels in the solver folder (which aren't covered yet)

Task:  Write unit tests for the matrix structure kernels in the solver folder which aren't covered yet.
Why:  Unit tests are a good, and this code has previously been covered by regression and integration testing primarily.
Done means:  All of these kernels have at least one unit test, preferably more if necessary to cover obvious variations in functionality.

Done with about half; aiming for day or two completion

Needs to be reviewed


vscode on Chromebook using networkshare not working

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.63.2
OS Version: ChromeOS 97.0.4692.77

Steps to Reproduce:

start vscode on Chromebook
open network share folder, via file->open folder
issue1: Side bar shows network folder but no files are shown
open file via  file->open file
change file and save
issue2: "Failed to save ... ENOTSUP, operation not supported on socket

Please see if you can find any logged output that could help us find the source of the issue:

run code --verbose from the command line and attach the output
in Code select Help | Toggle Developer Tools and select the Console
attach any output you see in the Console you can find

Thanks!

Thanks for your quick response!
Here's the requested log
vscode_verbose.log

@kbfifi thanks, this seems the issue:
Error: EINVAL: invalid argument, scandir '/mnt/chromeos/SMB/752b96118bc7a5f3490e9f951ce445989cc55c52051bd95bb40d92315effac35'

Can we conduct an experiment? Can you install node.js (14.x to match VSCode version), run node from the command line and run the following code:
fs.readdirSync('/mnt/chromeos/SMB/752b96118bc7a5f3490e9f951ce445989cc55c52051bd95bb40d92315effac35')

And see if you get any output?

Yes saw that too, but doesn make sense to me. Here's the result of your request:
kurt@penguin:~$ node -v
v14.18.3
kurt@penguin:~$ node
Welcome to Node.js v14.18.3.
Type ".help" for more information.

fs.readdirSync('/mnt/chromeos/SMB/752b96118bc7a5f3490e9f951ce445989cc55c52051bd95bb40d92315effac35')
Uncaught:
Error: EINVAL: invalid argument, scandir '/mnt/chromeos/SMB/752b96118bc7a5f3490e9f951ce445989cc55c52051bd95bb40d92315effac35'
at Object.readdirSync (fs.js:1047:3) {
errno: -22,
syscall: 'scandir',
code: 'EINVAL',
path: '/mnt/chromeos/SMB/752b96118bc7a5f3490e9f951ce445989cc55c52051bd95bb40d92315effac35'
}

Without the ability to read a folder, VS Code cannot show the contents. I suspect this is an issue with the file system driver.


Refresh Control Causes Sticky Header to Stay at Incorrect Position

Describe the bug
If a refreshcontrol is added to the collectionView, pulling to refresh will cause the sticky header to pin to incorrect position, instead of top of the screen
To Reproduce
Steps to reproduce the behavior:

Go to MagazineLayoutExample
Go to ViewController.swift
Inside viewDidLoad(), add collectionView.refreshControl = .init()
Run the project and pull to refresh, then scroll down
You will see the same behavior as shown in the attached gif

Expected behavior
The sticky header is expected to pin to the top even when the refresh control is active
Screenshots

Smartphone

Simulator: iPhone 8 Plus
OS: 13.2.2
Version: Latest (1.5.2)

Thanks for reporting this! I've created an alternate fix in #65 that fixes the root of the bug.


[backport v3.6-branch] Bluetooth: Controller: Few control procedure and compiler re-ordering fixes

@cvinayak This needs a description, references to the commits being backported, a bug issue report link etc.


[column - fix] statically fixed columns, cannot reorder

I would like to request a feature to fix column positions (not pin) on the left or right of the data grid.
Expected functionality would be that a columnDef would ensure that the placement of columns before (if fixed left) or after (if fixed right) including when dragging columns to new positions would not be allowed.
I believe there is some similar functionality in Example 1 of Grouping With Aggregation as seen here.

thanks for input, will stick on list, but no promises on if or when it gets in, as we are busy :)

tracked by AG-121
https://www.ag-grid.com/ag-grid-pipeline/

What's the status on this? I can't seem to find AG-121 in the pipeline anymore. I swear I saw it as a candidate for next release like a month ago. Now it's gone :(. I'm waiting for this feature.

Hi,
Thank you for raising this issue for us, at this moment we are reviewing how we process Feature Requests/questions that come through from GitHub.
As I am sure you are aware, we offer two products:
ag-Grid - this is entirely free to use in line with our MIT license
ag-Grid Enterprise - our commercial version which funds the development of both versions.
We currently have a very full pipeline of work which can be viewed here: https://www.ag-grid.com/ag-grid-pipeline/
This will be our priority for the coming months and as a result, we don’t have capacity to take feature requests/questions from GitHub, but you might find that yours has already been raised in our pipeline.
We will do a periodic review of GitHub issues for any bugs raised and these can also be tracked on our pipeline page.
Thanks for your understanding.
ag-Grid Team.

is there a solution for this issue


Fix compile issue when the library is used as dependency directly

Found this when using the dep directly in a project. Turns out that if you don't have the .version file present, it cries.
Repro steps:

mix new test
add avalanche
mix deps.get

Can also repro if you have avalanche locally and remove the .version file.
Error:
# test project name was `avalanche_version`
==> avalanche_version
Error while loading project :avalanche at /Users/paulo/dev/random/avalanche_version/deps/avalanche
** (File.Error) could not read file "/Users/paulo/dev/random/avalanche_version/deps/avalanche/.version": no such file or directory
    (elixir 1.14.1) lib/file.ex:358: File.read!/1
    /Users/paulo/dev/random/avalanche_version/deps/avalanche/mix.exs:9: (module)

:tada: This PR is included in version 0.11.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Email documentation suggestions

In /etc/zulip/settings.py, you might be able to clarify the instructions for setting up email in two ways.
First, the gmail instructions are a touch incomplete.  If you have 2FA enabled, the right move is to make an app-specific password, not to enable less secure access.  Mentioning that would point people in the right direction.
Second, the docs say to set email_password in /etc/zulip/zulip-secrets.conf.  They then say
With the exception of reading EMAIL_HOST_PASSWORD from
email_password in the Zulip secrets file, Zulip uses Django's
standard EmailBackend, so if you're having issues, you may want to
search for documentation on using your email provider with Django.
This is confusing.  EMAIL_HOST_PASSWORD has not been referenced before.  It's capitalized, which makes it seem important.  I totally read that as "Zulip reads EMAIL_HOST_PASSWORD from the secrets file", so I set it there and of course that didn't work.
I suggest omitting mention of EMAIL_HOST_PASSWORD entirely.  It's not clear why a user would need to know the name of the option that eventually gets set internally.   I feel a little silly for getting it wrong, but I do think users would benefit.

@h6pham8 thanks for the feedback!  This is much appreciated.

@jvasile is https://support.google.com/accounts/answer/185833?hl=en the right doc to point people to for app-specific passwords?

I just confirmed that doc is correct.  I'll merge a fix for this shortly.  Thanks for the feedback @jvasile!


Jest upgrade

Feature/Change Description
Describe changes made here, link to any issue that is addressed
Developer Checklist

[ ] Updated documentation or README.md
[ ] If adding new feature(s), added and ran unit tests
[ ] If create new release, bumped version number
[ ] Ran npm run style:fix for code style enforcement
[ ] Ran npm run lint:fix for linting
[ ] Ran npm audit to discover vulnerabilities

Great article for setting up Jest preview in Angular: https://sergeygultyayev.medium.com/angular-v16-surviving-the-preview-jest-793744b9eb31


fixes race condition in Searcher

fixes #1461
fixes a race condition in Searcher, by avoiding repeated calls to open_segment_readers and passing them instead as argument

@shikhar can you review https://github.com/quickwit-oss/tantivy/pull/1464

Codecov Report

Merging #1464 (2f5b89c) into main (67d94f5) will increase coverage by 0.01%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##             main    #1464      +/-   ##
==========================================
+ Coverage   94.07%   94.09%   +0.01%
==========================================
  Files         238      238
  Lines       44564    44523      -41
==========================================
- Hits        41922    41892      -30
+ Misses       2642     2631      -11

Impacted Files
Coverage Δ

src/core/searcher.rs
77.93% <85.71%> (+0.39%)
:arrow_up:

src/reader/mod.rs
92.94% <100.00%> (-0.05%)
:arrow_down:

src/fastfield/serializer/mod.rs
90.47% <0.00%> (-1.09%)
:arrow_down:

src/fastfield/writer.rs
90.80% <0.00%> (-0.29%)
:arrow_down:

fastfield_codecs/src/lib.rs
96.87% <0.00%> (-0.03%)
:arrow_down:

fastfield_codecs/src/linearinterpol.rs
99.54% <0.00%> (-0.01%)
:arrow_down:

fastfield_codecs/src/bitpacked.rs
100.00% <0.00%> (ø)

fastfield_codecs/src/multilinearinterpol.rs
100.00% <0.00%> (ø)

src/indexer/merger.rs
98.91% <0.00%> (+<0.01%)
:arrow_up:

fastfield_codecs/src/main.rs
1.01% <0.00%> (+0.06%)
:arrow_up:

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PSeitz aside from clippy nits, LGTM
I did have one unrelated change I was sneaking into my PR, that I wanted to ask about.
Is Relaxed memory order safe here? Both a load and store are happening, so AcqRel seems safer to me. And this is by no means a hot path so being conservative seems fair.
https://github.com/quickwit-oss/tantivy/blob/998b1263f6a28696ed35f685376cb612287fe840/src/reader/mod.rs#L212

Yeah, I think there could be scenarios where simultaneous reloads are triggered at the same time from multiple threads.

@shikhar I think we just want to ensure that the id delivered are unique, and Relaxed is sufficient for that...
That being said it is not a hot part of the code. We can use SeqCst and not sweat it.

@shikhar I think we just want to ensure that the id delivered are unique, and Relaxed is sufficient for that... That being said it is not a hot part of the code. We can use SeqCst and not sweat it.

I think it could be an issue when two threads increment, but due to weak fencing, we get two times the same value back. If now one of those callers has a new segment in their list, we have the same id to different SearcherGeneration.
It's very unlikely though, and on many platforms Relaxed is already AcqRel.

I think it could be an issue when two threads increment, but due to weak fencing, we get two times the same value back.

The memory orderings mostly determine how other memory accesses are ordered w.r.t. the atomic accesses, they do not affect the atomicity of an operation like fetch_add, i.e. multiple threads doing fetch_add(1, Ordering::Relaxed) will never see identical values (ignoring overflow).
However, their accesses to other memory locations that are shared with other threads will not be ordered w.r.t. the ID generation, e.g. their accesses to searcher_generation_inventory are do not necessarily reflect their accesses to searcher_generation_counter, meaning that a thread with lower ID might see the stores to the inventory of a thread with a higher ID.
While I suspect that this is not an issue, my personal choice would be Ordering::AcqRel as well just to capture any implicit dependencies which I do not see ATM. (I would suggest avoiding Ordering::SeqCst as mixing those two orderings can have unexpected effects and sticking to AcqRel is often preferable if global ordering is not required as it is simpler to  reason about the explicit pairings between acquire and release operations to the same memory address.)

It's very unlikely though, and on many platforms Relaxed is already AcqRel.

This is a very bad argument :). Also ARM is pretty popular.

we get two times the same value back

You cannot get two times the same value back... That's not what ordering is about.
...
Anyway let's defensively go for Ordering::AcqRel...

Thanks folks, I need to learn more about memory orderings :)


Fix Selector being overwritten when creating an instance of child UiObject2

This change is

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ko1in1u)

snippet_uiautomator/uiobject2.py line 465 at r1 (raw file):

    selector = self._selector.copy()
    selector.append('parent')
    return UiObject2(self._ui, selector, self._raise_error)

I think we can use _create_instance here: return self._create_instance('parent')
Code quote:
    selector = self._selector.copy()
    selector.append('parent')
    return UiObject2(self._ui, selector, self._raise_error)

Done.


Fix proxy error when connecting to https.

The previous refactor forgot to remove some of the code, causing the proxy error when connecting to https.

Coverage decreased (-0.4%) to 85.449% when pulling 6dc0cc98398f62465a48252e6f9705465dbebbab on fix-tls-failed into 7ecd4c8936034f8e0d751da4f3519728de7ba178 on master.

Coverage increased (+0.05%) to 85.927% when pulling 7f0910893e9d3086ac85047b5a25060dd2f93888 on fix-tls-failed into 7ecd4c8936034f8e0d751da4f3519728de7ba178 on master.

@chhsiao90 this is a quick fix, but the reason this problem occur is that I forgot to add the unit test for layer.tls. Orz
Sorry bout that.

LGTM
sorry for bring this bug into code :(

No, it's my bad. I have missed the unittest for this part and I should find out this regression when I review the code.
Thanks. :)


Bug: not able to disable fallback_for for buffer source.

In a recent update, the providers settings changed for the buffer-source, adding the fallback_for option.
While useful in principle, I personally prefer to have buffer to simply show its suggestions with lower priority instead of completely ignoring them in the presence of an LSP. I assumed that fallback_for could be disabled by passing an empty table:
sources = {
	providers = {
		{ "blink.cmp.sources.lsp", name = "LSP" },
		{ "blink.cmp.sources.path", name = "Path" },
		{ "blink.cmp.sources.snippets", name = "Snippets" },
		{
			"blink.cmp.sources.buffer",
			name = "Buffer",
			score_offset = -3,
			fallback_for = {}, -- empty to disable
		},
	},
},

But this is apparently not the case. With this config, I simply never get any buffer-suggestions. Whatever I tried, I could not figure out how to display buffer suggestions when there is also an LSP active.
A hacky workaround I found is to use fallback_for = { "Path" }, which effectively enables the buffer-source in most cases, since path does not return anything there is no /. But yeah, it's really a hacky workaround.

it appears completely leaving out fallback_for does the trick:
{
	"blink.cmp.sources.buffer",
	name = "Buffer",
	score_offset = -3,
},

I leave this issue open, since fallback_for = {} disabling the source completely nonetheless feels like a bug. Arguably it's maybe also a documentation issue, since it wasn't apparent from the default config, that you should simply leave out fallback_for


C++ CTRL-F5 always hits the invisible Breakpoint 1, main (argc=1, argv=0x7fffffffd648) the first time it runs!

Does this issue occur when all extensions are disabled?: Yes/No
Yes. Why the fxxk does it always hit this invisible breakpoint when there is none at all the first time CTRL-F5 is run!?!
=thread-group-added,id="i1"
GNU gdb (Ubuntu <IP_ADDRESS>40403-0ubuntu1) <IP_ADDRESS>40403-git
Copyright (C) 2024 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<https://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
    <http://www.gnu.org/software/gdb/documentation/>.

For help, type "help".
Type "apropos word" to search for commands related to "word".
Warning: Debuggee TargetArchitecture not detected, assuming x86_64.
=cmd-param-changed,param="pagination",value="off"

This GDB supports auto-downloading debuginfo from the following URLs:
  <https://debuginfod.ubuntu.com>
Enable debuginfod for this session? (y or [n]) [answered N; input not from terminal]
Debuginfod has been disabled.
To make this setting permanent, add 'set debuginfod enabled off' to .gdbinit.
Stopped due to shared library event (no libraries added or removed)
Loaded '/lib64/ld-linux-x86-64.so.2'. Symbols loaded.
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".

Breakpoint 1, main (argc=1, argv=0x7fffffffd648) at /usr/src/DataStructuresAlgorithms/Console/Console.cpp:11
11	{
Loaded '/lib/x86_64-linux-gnu/libtbb.so.12'. Symbols loaded.
Loaded '/lib/x86_64-linux-gnu/libstdc++.so.6'. Symbols loaded.
Loaded '/lib/x86_64-linux-gnu/libm.so.6'. Symbols loaded.
Loaded '/lib/x86_64-linux-gnu/libgcc_s.so.1'. Symbols loaded.
Loaded '/lib/x86_64-linux-gnu/libc.so.6'. Symbols loaded.
[New Thread 0x7ffff72006c0 (LWP 69236)]
[New Thread 0x7ffff66006c0 (LWP 69238)]
[New Thread 0x7ffff6c006c0 (LWP 69237)]
[New Thread 0x7ffff5a006c0 (LWP 69240)]
[New Thread 0x7ffff60006c0 (LWP 69239)]
[New Thread 0x7ffff48006c0 (LWP 69243)]
[New Thread 0x7ffff4e006c0 (LWP 69242)]
[New Thread 0x7ffff54006c0 (LWP 69241)]
[New Thread 0x7fffef8006c0 (LWP 69245)]
[New Thread 0x7fffefe006c0 (LWP 69244)]
[New Thread 0x7fffef2006c0 (LWP 69246)]
[New Thread 0x7fffee6006c0 (LWP 69248)]
[New Thread 0x7fffeec006c0 (LWP 69247)]
[New Thread 0x7fffee0006c0 (LWP 69249)]
[New Thread 0x7fffeda006c0 (LWP 69252)]

VS Code Version: 1.90.0
OS Version: Ubuntu 24.04

Steps to Reproduce:

Please file this on the extension for the debugger you're using


Backtick-quoted column name in SQL output from query with count_distinct

Cool project!
I used the prql-query CLI-tool v0.0.14 in the following examples.
The problem
When compiling:
prql target:sql.postgres
from developers
group team (
    aggregate [
        skill_width = count_distinct specialty,
    ]
)

to sql I get:
SELECT
  team,
  COUNT(DISTINCT `specialty`) AS skill_width
FROM
  developers
GROUP BY
  team

I did not expect the output to have a column name quoted with backticks (and neither did the database I sent it to, roapi).
In contrast
If we have a weird column name and backtick-quote it in the select statement of the prql:
from developers
select `weird name`

we get a column name with double-quotes as expected:
SELECT
  "weird name"
FROM
  developers

Possible culprit
Searching the codebase I found this line in prql-compiler/src/sql/std_impl.prql:
func count_distinct <scalar|column> column ->  s"COUNT(DISTINCT `{column}`)"
which contains backticks. Is there a good reason for this? None of the other functions in the file use backticks.

Nice report, very readable.
You've probably found the correct culprit and I don't know why backticks are here. Probably historical reason.

Hi @RalfNorthman ,
Thank you for the report. This is probably a bug in prql-query which is quite out of date with the main prql-compiler. I will look at updating that asap.
I will transfer the issue there in the meantime.


dart: 0.4 -> 1.16.1

Motivation for this change
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Update to the original PR #468. Package is still based on binary release.
I've been working with it for a day and it seems to be working. It is my first package,
so if you have any comments and suggestions for improvements, would be
glad to hear them.

No need to add unzip as a dependency and explicitly call it in unpackPhase.
The default unpackPhase will try to figure out the archive type and should do everything automagically for you if you set the src attribute of the derivation. (either move it down into mkDerivation { or use inherit src inside mkDerivation)

I think the assertion for system can be replaced with meta.platforms = [ "i686-linux" "x86_64-linux" ]

@groxxda default unpackPhase does not unzip it for me,
$ nix-env -f nixpkgs -i dart
replacing old ‘dart-1.16.1’
installing ‘dart-1.16.1’
download-from-binary-cache.pl: still waiting for ‘https://cache.nixos.org/i4fv222893f2dybhvxd19308z1sns8rx.narinfo’ after 5 seconds...
these derivations will be built:
/nix/store/a4zqnx92bj58j4c9mhyyxjl4q6bk5qdg-dart-1.16.1.drv
building path(s) ‘/nix/store/i4fv222893f2dybhvxd19308z1sns8rx-dart-1.16.1’
unpacking sources
unpacking source archive /nix/store/bpi2j1gri3w3hrxfw0zk132fvw6g2kfh-dartsdk-linux-x64-release.zip
do not know how to unpack source archive /nix/store/bpi2j1gri3w3hrxfw0zk132fvw6g2kfh-dartsdk-linux-x64-release.zip
builder for ‘/nix/store/a4zqnx92bj58j4c9mhyyxjl4q6bk5qdg-dart-1.16.1.drv’ failed with exit code 1
error: build of ‘/nix/store/a4zqnx92bj58j4c9mhyyxjl4q6bk5qdg-dart-1.16.1.drv’ failed

Looking at https://github.com/NixOS/nixpkgs/blob/master/pkgs/stdenv/generic/setup.sh#L497 suggests that it does not know about zips.

Sorry - you have to add unzip to buildInputs or better nativeBuildInputs. Unpacking should then happen without explicitly setting unpackPhase. Thanks to unzip/setup-hook.sh

So much magic ;) I fixed it according to your suggestions.


About Pretrained models of Cheng2020Anchor at high bit rates

The pretrained models of Cheng2020Anchor do not cover bit rates higher than 1 bpp (only 1-6 models). I try to train Cheng2020Anchor at high bit rates by increasing lambda or number of channels, but find the performance degrades severely compared with other methods. Do the developers find the same problem? Is it possible to include Cheng2020Anchor at higher bit rates (>1bpp) like other methods in the pretrained model?
I appreciate if the developers can give me some advice.

Hi, we provided the 6 sets of pretrained weights to reproduce the results presented in this bit-rate range in the original paper.
If you increase both the lambda and the number of channels it should be able to handle larger bit-rates, the base architecture is very similar to other publications. Can you try the a larger lambda 1 and use 192 output channels for the intermediate feature maps and 320 for the latent ?

Thank you for your reply! I tried exactly what you recommend but the performance was quite different from what I expected. I modified the Cheng2020Anchor class in order to adjust the latent. By using (N=192, M=320) and lambda 1, the converged performance of Cheng2020Anchor on Kodak is bpp: 2.34, psnr:40.98. For mbt2018, I use (N=192, M=320), lambda 0.5, the converged performance on Kodak is bpp: 2.39, psnr: 42.99.
By using (N=192, M=192), lambda 0.025,  the converged performance of Cheng2020Anchor on Kodak is bpp: 0.59, psnr:35.11, which is consistent with the original paper.
I don't know if I make mistakes or Cheng2020Anchor is not suitable for high bit-rates. Thus, I wonder if you met the same problem.
The modified class:
class Cheng2020Anchor(JointAutoregressiveHierarchicalPriors):
def __init__(self, N=192, M=192, **kwargs):
    super().__init__(N=N, M=M, **kwargs)

    self.g_a = nn.Sequential(
        ResidualBlockWithStride(3, N, stride=2),
        ResidualBlock(N, N),
        ResidualBlockWithStride(N, N, stride=2),
        ResidualBlock(N, N),
        ResidualBlockWithStride(N, N, stride=2),
        ResidualBlock(N, M),
        conv3x3(M, M, stride=2),
    )

    self.h_a = nn.Sequential(
        conv3x3(M, N),
        nn.LeakyReLU(inplace=True),
        conv3x3(N, N),
        nn.LeakyReLU(inplace=True),
        conv3x3(N, N, stride=2),
        nn.LeakyReLU(inplace=True),
        conv3x3(N, N),
        nn.LeakyReLU(inplace=True),
        conv3x3(N, N, stride=2),
    )

    self.h_s = nn.Sequential(
        conv3x3(N, M),
        nn.LeakyReLU(inplace=True),
        subpel_conv3x3(M, M, 2),
        nn.LeakyReLU(inplace=True),
        conv3x3(M, M * 3 // 2),
        nn.LeakyReLU(inplace=True),
        subpel_conv3x3(M * 3 // 2, M * 3 // 2, 2),
        nn.LeakyReLU(inplace=True),
        conv3x3(M * 3 // 2, M * 2),
    )

    self.g_s = nn.Sequential(
        ResidualBlock(M, N),
        ResidualBlockUpsample(N, N, 2),
        ResidualBlock(N, N),
        ResidualBlockUpsample(N, N, 2),
        ResidualBlock(N, N),
        ResidualBlockUpsample(N, N, 2),
        ResidualBlock(N, N),
        subpel_conv3x3(N, 3, 2),
    )

Closing stale issue. If you think it should remain open, feel free to reopen it.


Filters?

The documentation on this page mentions filters and it appears filters can be set in the Azure portal, however I haven't yet seen any documentation on how to use filters.  Can this page be expanded to include documentation on filters, or a link to any existing documentation?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e89c8e11-d8bf-7c62-1bd2-bfaf145d20ae
Version Independent ID: cac9d257-3328-0ed7-fa73-22be44bf84c5
Content: Azure App Configuration feature management
Content Source: articles/azure-app-configuration/concept-feature-management.md
Service: azure-app-configuration
GitHub Login: @yegu-ms
Microsoft Alias: yegu

@13daysaweek Thank you for the feedback!  We are investigating this and will get back to you shortly.

@13daysaweek, thanks for asking! Filter usage are documented in the following:

https://docs.microsoft.com/en-us/azure/azure-app-configuration/use-feature-flags-dotnet-core#mvc-filters

https://docs.microsoft.com/en-us/dotnet/api/microsoft.featuremanagement?view=azure-dotnet-preview

#please-close

@yegu-ms @kobulloc-MSFT can you please reopen this issue and look at how the documentation can be improved?
The following points are not clear and are not discussed in the documentation:

how can filters be combined?
IFeatureFilters and MVC filters are different things I believe.

How are they related?
How should they be implemented?
What filters are available out of the box?

I see that they are added in different ways and places:

services.AddMvc(options => {
        options.Filters.AddForFeature<SomeMvcFilter>(nameof(MyFeatureFlags.FeatureA));
    });

public void ConfigureServices(IServiceCollection services)
    {
        services.AddFeatureManagement()
                .AddFeatureFilter<PercentageFilter>();
    }

Could you please reopen this and clarify?

https://andrewlock.net/introducing-the-microsoft-featuremanagement-library-adding-feature-flags-to-an-asp-net-core-app-part-1/ seems to be a good blog about this

There is updated documentation in

https://github.com/Azure/AppConfiguration
https://github.com/microsoft/FeatureManagement-Dotnet

Also, some issues in those repos document some behavior, limitations and explanations.
It would be good if at least there was a link to those repos, and it would be better if the content of that would be available as updated tutorials/ articles on Microsoft Docs :)

We have added stories to our backlog to capture this work -- thanks very much for your feedback!
#please-close


Test and cleanup new Python folder structure

[ ] @prisalex  - can you edit your wmata script (now moved into the /python/scripts folder) to use appropriate paths to store data in {repofolder}/data/raw/wmata or somesuch, and to use the {repofolder}/python/housinginsights/secrets.json appropriately?

[ ] @salomoneb I moved your  script for PUD scraping into /python/scripts (instead of in the package under ingestion). Can you check for any relative import/writing issues associated with the move?

Hey @salomoneb can you take a look at this at some point? Should be quick. We will eventually need to integrate this script into the current ETL pipeline instead of having to run manually to make a flat file, but that requires a project-wide solution.


Request to add myself as a trusted collaborator

Hello guys,
After some time reviewing and create PRs for charts, I now feel blocked because of no ability to ok-to-test other people's PRs.
This is why I ask to be added as a Trusted Collaborator.
Here are a few of my contributions so far to charts.git:

PRs: https://github.com/helm/charts/pulls?utf8=✓&q=is%3Apr+is%3Aclosed+author%3Adesaintmartin+ (~30)
Issues: https://github.com/helm/charts/issues?utf8=✓&q=is%3Aissue+author%3Adesaintmartin+ (mostly "upgradability" issues)
Reviews: https://github.com/helm/charts/pulls?utf8=✓&q=is%3Apr+reviewed-by%3Adesaintmartin+ (~15)

Cheers!
cc @mattfarina @scottrigby

Up?

Sorry for the slow response.
You should have an invitation waiting for you to join as a collaborator.


Update the infra/core modules to AVM modules of "todo-python-mongo-aca"

Update the infra/core modules to AVM modules for todo-python-mongo-aca.

Modules not replaced by AVM.

Monitoring (applicationinsights-dashboard) : Missing the feature Microsoft.Portal/dashboards.
AVM issue link: https://github.com/Azure/bicep-registry-modules/issues/1130
APIM: Missing features Microsoft.ApiManagement/service/loggers and
Microsoft.ApiManagement/service/apis/diagnostics.
AVM issue link: https://github.com/Azure/bicep-registry-modules/issues/1124

Modules replaced by AVM.

Container app
Container environment
Container registry
Key Vault
Cosmos mongo
Azure loganalytics
Azure applicationInsights

Repoman Generation Results
Repoman pushed changes to remotes for the following projects:
Project: todo-python-mongo-aca
Remote: azure-samples-staging
Branch: pr/3956
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo-aca -b pr/3956

View Changes | Compare Changes

Project: todo-python-mongo-swa-func
Remote: azure-samples-staging
Branch: pr/3956
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/3956

View Changes | Compare Changes

Project: todo-python-mongo
Remote: azure-samples-staging
Branch: pr/3956
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo -b pr/3956

View Changes | Compare Changes

Project: todo-python-mongo-terraform
Remote: azure-samples-staging
Branch: pr/3956
You can initialize this project with:
azd init -t Azure-Samples/todo-python-mongo-terraform -b pr/3956

View Changes | Compare Changes


Experimental data

I would like to ask why your experimental data is not reflected in the paper, such as the success rate of 30s in the environment of road 4 and density 1，We look forward to hearing from you！

@zijinoier

Please kindly refer to our following work DiLu.
Specially, this issue https://github.com/PJLab-ADG/DiLu/issues/10
Thanks.


[CRASH] ATM7 Fresh Install - Crashes

Describe the bug
All the mods load, but when you try to join/create a world using a clean ATM7 pack install, the game crashes to console. I've also attached the latest.log that generates when it crashes.
To Reproduce
Steps to reproduce the behavior:

Install Fresh ATM7 Pack
Add in Rubidium, Extras & Dynamic Lights
Create New World
Game Crashes

latest.log

I was able to reproduce the crash using only Rubidium, Rubidium Extras, Rubidium Dynamic Lights, and Ars Noveau+dependencies.
Same issue as above, Creating a world and joining it causes the game to crash.
crash-2022-04-29_14.27.14-client.txt

I can replicate this issue as well with my instance of ATM7. Same crashlog.

It looks like all of these crashes relate to dynamic lighting on entities.  Can you see if disabling that option clears the crashes?  Might help the dev identify the root cause if they have not already.


Question regarding mapped variagles

GraphQL takes in Map<String, Object> mappedVariables as part of the execute() request.  When processing GraphQL JSON (content type: application/json), we are parsing out the variables as strings from the JSON itself.
This has worked fine for String, Enum types, but last week we ran into an issue when trying to process ZonedDateTime strings.  I ended up realizing that I had to convert the ZonedDateTime string into an actual ZonedDateTime object in order for the query to work with GraphQL.
Is there an easier way to handle this besides having to manually find and parse out ZonedDateTime variables from the query and replacing the value in the Map<String, Object> mappedVariables with an actual ZonedDateTime?
Here's an example GraphQL JSON query:
`[
{
"query": "mutation updateCoupon($application_id: String!, $id: String!, $status: CouponRuleStatusInput!, $name: String!, $allocation_method: AllocationMethodInput!, $amount: BigDecimal!, $custom_word: String!, $discount_type: String!, $ends_at: ZonedDateTime!, $entitled_collection_ids: [String]!, $entitled_product_ids: [String]!, $entitled_variant_ids: [String]!, $format: String!, $merge_field: String!, $starts_at: ZonedDateTime!, $suffix: String!, $valid_days: String!, $validity_type: ValidityTypeInput!) { coupon_rule(coupon_rule: {application_id: $application_id, id: $id, name: $name, status: $status, allocation_method: $allocation_method, amount: $amount, custom_word: $custom_word, discount_type: $discount_type, ends_at: $ends_at, entitled_collection_ids: $entitled_collection_ids, entitled_product_ids: $entitled_product_ids, entitled_variant_ids: $entitled_variant_ids, format: $format, merge_field: $merge_field, starts_at: $starts_at, suffix: $suffix, valid_days: $valid_days, validity_type: $validity_type}) { id name status allocation_method amount custom_word discount_type ends_at entitled_collection_ids entitled_product_ids entitled_variant_ids format merge_field starts_at suffix valid_days validity_type __typename }}",
"variables": {
"application_id": "15e58062-54d0-4614-8498-485ac7a4933b",
"id": "e3f69a41-6439-4522-9f18-a5083ad5b174",
"name": "50% off",
"status": "ACTIVE",
"allocation_method": "ACROSS",
"amount": 3,
"custom_word": "asdasd",
"discount_type": "Percent Off",
"ends_at": "2017-11-13T17:00:00.000Z",
"entitled_collection_ids": [],
"entitled_product_ids": [
  ],
  "entitled_variant_ids": [

  ],
  "format": "merge_field-custom_word",
  "merge_field": "firstName",
  "starts_at": "2017-10-04T16:00:00.000Z",
  "suffix": "33",
  "valid_days": "Sunday",
  "validity_type": "BETWEEN_SPECIFIC_DATES",
  "__typename": "CouponRule",
  "random_characters": "AUTOGENERATED",
  "prefix_1": "firstName",
  "prefix_2": "asdasd"
},
"operationName": "updateCoupon"

}
]`

GraphQL takes in Map<String, Object> mappedVariables as part of the execute() request.  When processing GraphQL JSON (content type: application/json), we are parsing out the variables as strings from the JSON itself.
This has worked fine for String, Enum types, but last week we ran into an issue when trying to process ZonedDateTime strings.  I ended up realizing that I had to convert the ZonedDateTime string into an actual ZonedDateTime object in order for the query to work with GraphQL.
Is there an easier way to handle this besides having to manually find and parse out ZonedDateTime variables from the query and replacing the value in the Map<String, Object> mappedVariables with an actual ZonedDateTime?
Here's an example GraphQL JSON query:
`[
{
"query": "mutation updateCoupon($application_id: String!, $id: String!, $status: CouponRuleStatusInput!, $name: String!, $allocation_method: AllocationMethodInput!, $amount: BigDecimal!, $custom_word: String!, $discount_type: String!, $ends_at: ZonedDateTime!, $entitled_collection_ids: [String]!, $entitled_product_ids: [String]!, $entitled_variant_ids: [String]!, $format: String!, $merge_field: String!, $starts_at: ZonedDateTime!, $suffix: String!, $valid_days: String!, $validity_type: ValidityTypeInput!) { coupon_rule(coupon_rule: {application_id: $application_id, id: $id, name: $name, status: $status, allocation_method: $allocation_method, amount: $amount, custom_word: $custom_word, discount_type: $discount_type, ends_at: $ends_at, entitled_collection_ids: $entitled_collection_ids, entitled_product_ids: $entitled_product_ids, entitled_variant_ids: $entitled_variant_ids, format: $format, merge_field: $merge_field, starts_at: $starts_at, suffix: $suffix, valid_days: $valid_days, validity_type: $validity_type}) { id name status allocation_method amount custom_word discount_type ends_at entitled_collection_ids entitled_product_ids entitled_variant_ids format merge_field starts_at suffix valid_days validity_type __typename }}",
"variables": {
"application_id": "15e58062-54d0-4614-8498-485ac7a4933b",
"id": "e3f69a41-6439-4522-9f18-a5083ad5b174",
"name": "50% off",
"status": "ACTIVE",
"allocation_method": "ACROSS",
"amount": 3,
"custom_word": "asdasd",
"discount_type": "Percent Off",
"ends_at": "2017-11-13T17:00:00.000Z",
"entitled_collection_ids": [],
"entitled_product_ids": [
  ],
  "entitled_variant_ids": [

  ],
  "format": "merge_field-custom_word",
  "merge_field": "firstName",
  "starts_at": "2017-10-04T16:00:00.000Z",
  "suffix": "33",
  "valid_days": "Sunday",
  "validity_type": "BETWEEN_SPECIFIC_DATES",
  "__typename": "CouponRule",
  "random_characters": "AUTOGENERATED",
  "prefix_1": "firstName",
  "prefix_2": "asdasd"
},
"operationName": "updateCoupon"

}
]`

Right now, variables are not dealt with properly, so you have to deserialize them properly yourself. I think the fix for this is already in master but not released. I will check this out again to make sure it's fixed.

@kaqqao Thanks for the info! If you could, let me know if the fix is released or not and I can give it a try.

0.9.4 has just been released. Please test if it fixes your issue.
I think this is the same as #19, and if that's the case, v0.9.4 contains the fix.

I have updated graphql-spqr to 0.9.4 and removed my code to manually parse them out and it is working now!  Thank you!


Bug: getDistance

Hello,
in the Readme and index.d.ts the method is defined as getDistances()
But the actual implementation is getDistance()

Hello @m-ruhl ,
Thank you, It should be fixed with 0.5.1 now

@Francesco-Voto thanks for the quick fix 👍