Feature request: Allow actions to override the agent answer

Is your feature request related to a problem? Please describe.
Right now actions are mostly seen as "side effect"  happening next to an answer sent by the agent.
There is no automated way to get the agent to call an action, interpret the result, and answer with that interpretation (which is what I would expect coming from OpenAI actions that are APIs that their runtime call and then get the result interpreted by the agent)
Right now if I ask my agent: what actions can you perform right now in the game?
1 - Agent response: { "user": "Miaoulechat", "text": "I can play, nap, or explore! What do you want to see?", "action": "LIST_GAME_ACTIONS" }
2 -Runtime processAction("LIST_GAME_ACTIONS"): { text: "I can play dice, roulette, blackjack" }
3 - Shown to user:
 ["◎ Agent: I can play, nap, or explore! What do you want to see?"]
 ["◎ Agent: I can play dice, roulette, blackjack"]

Describe the solution you'd like
There are two things that could be done.
The simple one would just have the action result override the answer from the agent (so in the previous example, the first text I can play, nap, or explore! What do you want to see? wouldn't even be sent to the client).
The complicated one, would have do a second back-and forth with the agent, after getting the action result, in order to interpret that result.
A) simple:
1 - Agent response: { "user": "Miaoulechat", "text": "I can play, nap, or explore! What do you want to see?", "action": "LIST_GAME_ACTIONS" }
2 -Runtime processAction("LIST_GAME_ACTIONS"): { text: "I can play dice, roulette, blackjack", type: "OVERRIDE_ANSWER" }
3 - Shown to user:
 ["◎ Agent: I can play dice, roulette, blackjack"]

here, simply adding a "type" (or any other field name) with value OVERRIDE_ANSWER to the action result, would tell the system to not send the agent answer, only the action result, to the client

B) complicated:
1 - Agent response: { "user": "Miaoulechat", "text": "I can play, nap, or explore! What do you want to see?", "action": "LIST_GAME_ACTIONS" }
2 -Runtime processAction("LIST_GAME_ACTIONS"): { data: ['dice', 'roulette', 'blackjack'], type: "ACTION_RESULT_INTERPRETATION" }
3 - Agent request: { prompt: "You were just asked 'what actions can you perform right now in the game?' which triggered the action 'LIST_GAME_ACTIONS' and the result was ['dice', 'roulette', 'blackjack']. Can you compose an answer knowing the question and the result?" }
4- Agent response: { "user": "Miaoulechat", "text": "I can play dice, roulette and blackjack"}
5 - Shown to user:
 ["◎ Agent: I can play dice, roulette and blackjack"]

here, there is a second message sent to the agent, telling it "this is what happened, this is the result, can you interpret it?". This would be done again through some "type"  (ACTION_RESULT_INTERPRETATION) on the action result, which would be some kind of "operation" to be done by the runtime.

Describe alternatives you've considered
Right now as an alternative, I go with the "simple" solution, and at the client level, if there is any message with a type: "OVERRIDE_ANSWER" I remove all other messages from the returned messages.
But this forces me to do a fork of all the clients to add that filter, when it could be done earlier in the runtime / pipeline.
Additional context
I'm comparing "actions" to OpenAI actions where the agent detects that an action is possible from the prompt and a list of actions that are submitted (it also detects parameters)
Then the agent call the API with those parameters
The API answers, and the agent interpret the result, create a constructed answer, and returns that answer.
It would be nice to be able to have a similar behavior for actions here

you could solve this at a more fundamental level by splitting agents into worker vs character types
worker agents would be all business - they'd just execute actions and return results directly, perfect for stuff like LIST_GAME_ACTIONS. no personality, no fluff, just data.
character agents would be the chatty ones that interpret results and add narrative flair.
you could even take a temperature-based approach to balance between these - low temps giving you more worker-like behavior with just the facts, while higher temps let the agent be more expressive and narrative in their responses.
this split would naturally handle both your scenarios:

simple case: worker agents automatically override their response with action results
complex case: character agents process action results and craft narrative responses

but if you want to move forward with your override/interpretation types approach first, that's totally workable too. you could handle it at the runtime level to avoid client mods.
the worker/character abstraction is there when you're ready to tackle the bigger architectural picture - it would make all of this stuff cleaner and more consistent in the long run

I do understand how I can go around this, but my goal here is to be able to have this feature integrated to my agents / characters, so they can automatically interpret actions results.
That's why I would like to make it a feature, not find a way to go around the fact it's not available.

I support this petition


Many A350-900 liveries (Livery Request)

I was so bored that I tried to think. But came up with a idea. I downloaded some A350 liveries in the game, and use them as a template to where I should put the logo and the text. And here is all the liveries. (I'll make a Part 2 with fewer liveries. And next I'll make B757-200 liveries only airliners with sharklets equipped).
Liveries I made:
Air Caraïbes
Air China
Air China (Star Alliance)
Air France
Azul
China Eastern
Ethiopian Airlines
Ethiopian Airlines (Star Alliance)
Finnair (Marimekko Kivet)
German Air Force
ITA Airways (Born To Be Sustainable)
Malaysia Airlines
Qatar Airways
Qatar Airways (One World)
Sichuan Airlines
Singapore Airlines (10,000th Airbus Aircraft)
Starlux
Thai Airways
Turkish Airlines (Aeroflot Hybrid)
Vietnam Airlines (Skyteam)
World2Fly

Asiana?

I was so bored that I tried to think. But came up with a idea. I downloaded some A350 liveries in the game, and use them as a template to where I should put the logo and the text. And here is all the liveries. (I'll make a Part 2 with fewer liveries. And next I'll make B757-200 liveries only airliners with sharklets equipped).
Liveries I made: Air Caraïbes Air China Air China (Star Alliance) Air France Azul China Eastern Ethiopian Airlines Ethiopian Airlines (Star Alliance) Finnair (Marimekko Kivet) German Air Force ITA Airways (Born To Be Sustainable) Malaysia Airlines Qatar Airways Qatar Airways (One World) Sichuan Airlines Singapore Airlines (10,000th Airbus Aircraft) Starlux Thai Airways Turkish Airlines (Aeroflot Hybrid) Vietnam Airlines (Skyteam) World2Fly

You Also Forgot The Asiana Airlines & Philippine Airlines!

Yeah and that's what I would do in part 2 + other airliners

I can't do Aeroflot and Asiana Airlines..

I can't do Aeroflot and Asiana Airlines..

Oh!

Why?

because it's too hard

because it's too hard

Would You Try The Cebu Pacific Version Of A350-900

I can, but new livery or old livery?

well looks like im not making any more A350-900 liveries becuase they are all made, on to the 757 and the 767

well looks like im not making any more A350-900 liveries becuase they are all made, on to the 757 and the 767

yeh sorry, I made most of them🗿💀

I can, but new livery or old livery?

New Livery!

ok


[Fix] fix a bug of showing kmeans losses

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
To fix the bug that occurs during showing k-means losses in the training processing.
TypeError: unsupported format string passed to numpy.ndarray.__format__

Modification
if verbose:
    print(f'k-means loss evolution: {losses:0}')

to
if verbose:
    print(f'k-means loss evolution: {losses}')

As losses is a numpy::ndarray.
BC-breaking (Optional)
None
Use cases (Optional)
None
Checklist
Before PR:

[v] Pre-commit or other linting tools are used to fix the potential lint issues.
[v] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[v] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[v] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

[v] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
[v] CLA has been signed and all committers have signed the CLA in this PR.

@Jiahao000 Sorry for the delay but currently I can hardly find out the problem in my modified tests/test_utils/test_clustering.py which cannot pass the codecov/patch.

@Jiahao000 It seems that my modified tests/test_utils/test_clustering.py is not tracked by codecov. Could someone authorized
add this change to the current unit test in codecov?

I think the reason might be the pytest.mark.skipif decorator in test_clustering.py, as the original code needs GPU to run.

@fangyixiao18 I remove the GPU restrict and see it would also lead to errors during the test. Besides, faiss generally requires GPU resources. What should I do to bypass all these problems?

@fangyixiao18 I remove the GPU restrict and see it would also lead to errors during the test. Besides, faiss generally requires GPU resources. What should I do to bypass all these problems?

Currently, the CI doesn't support GPU so I wrote the skipif decorator.
I think the unittest.mock would help to run unittest without GPU, would you like to help us to revise the unittest?

@fangyixiao18 I am not sure how to solve this problem even with unittest.mock without modifying multiple lines in utils/clustering.py. However, if I cluster those function calls related to faiss and use unitest.mock to bypass GPU usage, would codecov still show Added line #Lxxx was not covered by tests?

@Kaminyou Thanks a lot！Could you please run the pre-commit and check the codes to pass the lint check？

@fangyixiao18 Everything has been done. My coworker found a bug in isort config which make my code not able to pass the lint check. Please first deal with that PR and I will rebase and push again.

@fangyixiao18 @Jiahao000 Please check for my update.


Fix for Rails 5 undefined method `back_url'

After updated to Rails 5.1, I got this exception:
undefined method back_url'
Rails 5 has redirect_back, instead of redirect_to :back.

@ForestHeart looks it breaks the tests on travisci

@flyerhzm fixed.
travisci start to using Rails5, and there are small changes in rspec controller test for Rails5.

@ForestHeart thank you so much.


Georgia supported on Jelly Bean 4.2.2 ?

http://fontfamily.io/Georgia claims Georgia exists (green) on android 4.2.2.  Should be yellow.
I'm pretty sure it never existed in android, but there is an alias, which used to be DroidSerif and now (since 5.0?) became NotoSerif:
https://github.com/android/platform_frameworks_base/commit/a08f0f8f453bb192dd0c4cd25a5aeb05986805fc#diff-eddd3df16ecaba63bd2858a059863c19R85
Test just to be sure: http://codepen.io/cben/pen/ByvKNr =>
4.2: http://app.crossbrowsertesting.com/livetests/2806630/snapshots/z90115b8903e5f2677b8
5.0: http://app.crossbrowsertesting.com/livetests/2806828/snapshots/zdd9a6cbc735e27e833c
(can't say if Droid or Noto, ASCII looks the same)
real Georgia on OS X: http://app.crossbrowsertesting.com/livetests/2806637/snapshots/zab2c51057cc298bc90a
All I know about android font-families: http://stackoverflow.com/a/22555625/239657

Hm, your crossbrowsertesting links are 404-ing.
Nonetheless, I’m not yet convinced this is true.
http://jsbin.com/negugi/1
If it matches Droid Serif (which is only available in CSS as serif), the middle line would match perfectly on Android 4.2, which it doesn’t.

oops.  public links:
4.2: http://app.crossbrowsertesting.com/public/i866dfd0fa0b9da1/livetests/2806630/snapshots/z90115b8903e5f2677b8
5.0: http://app.crossbrowsertesting.com/public/i866dfd0fa0b9da1/livetests/2806828/snapshots/zdd9a6cbc735e27e833c
OSX: http://app.crossbrowsertesting.com/public/i866dfd0fa0b9da1/livetests/2806637/snapshots/zab2c51057cc298bc90a
Your test is more convincing, except the middle does line up perfectly for me:
4.2 on Sauce labs: https://saucelabs.com/bugs/dc7adf6059b14f278bd250cbd6f25ec7
physical 4.2.2 (BLU Advance 4.0):

also on 4.4.2 Lenovo Yoga Tablet B8080.
I've seen some rumors Samsung has changed some fonts in their android skins but haven't seen evidence.

Hmm.
http://app.crossbrowsertesting.com/public/i866dfd0fa0b9da1/screenshots/zb0d42ce84e522027013?size=small&type=windowed
Georgia == serif both on stock Nexuses and Samsung devices.  And to my eyes all look like Droid/Noto Serif.
But that's all with Chrome.
my 4.2.2 BLU phone with:

stock android browser also lines up the middle line.
in firefox all 3 lines look clean with no overlapping!  I believe FF uses its own fonts and apparently disregrads system font aliases?

What phone / browser did you test?
Googling suggests Samsung ships several UI fonts and lets you choose — including a "Samsung Sans"; but apparently there is no "Samsung Serif".  Not sure if those fafect only samsung apps or everyting.
And Samsung also mutated the stock browser...

My real-world device is a Samsung Galaxy SIII Mini GT-I8200L Android 4.2.2 (Jelly Bean).
FWIW I was able to reproduce this in browserstack on an emulated Google Nexus 4 (Android 4.2).

Also lines up on Nexus 5 (android 5.0.1) in Chrome.
Your first screenshot looks like (what google tells me) Samsung's browser
looks like; the second looks like stock android browser.
I suspect if you try Chrome on your SIII it will also show georgia as Droid
Serif.
I've added real Droid Serif to http://s.codepen.io/cben/debug/ByvKNr? (and
also tried WhatFont but it's pretty useless here...).
If you care to screenshot it (preferably on-device shot, long-press
Power+Home), we could try WhatTheFont and similar.

Yes, the original test screenshot I posted was from the stock Browser app. But in fact both Chrome and Firefox on my SIII show the same result as the original screenshot (none of the lines match up). Do you have any real 4.2 devices to test on? It might be an emulator inconsistency.

Hmm.
My real BLU Advance 4.0 phone (4.2.2), Lenovo Yoga Tablet B8080 (4.4.2) and Nexus 5 (5.0.1) all line up in middle line, both Chrome and stock.
But firefox (on the 4.2.2 BLU phone) does this:

I should admit that I don't know what exactly goes on and I'm only waving an accusing finger at the general direction of Samsung because it doesn't fit my assumptions :-)

Let’s revisit what my jsbin actually means, I think we are both a bit lost here :D For the purposes of this explanation let’s just look at the top two lines of the jsbin (not all three).
Two lines, 3 distinct cases:
Two mismatches (text looks jumbled and overlapping): the fallback is NOT used (Georgia is a unique font—supported).
Two matches (text looks normal, no overlaps): Georgia is not supported, fallback is used on both lines.
One mismatch, one match: Georgia is supported but is also aliased to the fallback that is a match.
SO, at the very least, we can confirm that Georgia is supported (in all cases) as your original comment pointed out. However, looks like some Androids alias serif and some don’t.

Good summary.

Two mismatches (text looks jumbled and overlapping): the fallback is NOT
used (Georgia is a unique font—supported).
There is still a remote chance that Georgia is aliased to something(*)
different than the the default serif.
I'm curious to see non-overlapping Georgia (esp. italic) vs serif
screenshot to see visually what each looks like.
(remembered a trick: AdobeBlank is a font covering all unicode with a blank
glyph.
used it in http://codepen.io/cben/full/ByvKNr so now if you see anything
at all, it's that font or alias but not fallback)

In any case, http://fontfamily.io/Georgia currently saying that 4.2.2
supported it while 4.4.2 dropped support and aliases to Droid Serif is
strange.
The variance is probably along manufacturers, not versions.
(*)I caught myself spelling that word "samsing" :-)

Found a good source for this: https://github.com/android/platform_frameworks_base/blob/master/data/fonts/fonts.xml#L15
It’s actually aliased to Noto Serif.


Assert in GetGltfObjectFromGlb

Describe the bug
After pulling the latest dev branch, the following assert fires upon loading in Unity:
chunk 1 & buffer 0 length mismatch
UnityEngine.Debug:Assert(Boolean, String)
Microsoft.MixedReality.Toolkit.Utilities.Gltf.Serialization.GltfUtility:GetGltfObjectFromGlb(Byte[]) (at Assets/MixedRealityToolkit/Utilities/Gltf/Serialization/GltfUtility.cs:258)
Microsoft.MixedReality.Toolkit.Utilities.Gltf.Serialization.<ImportGltfObjectFromPathAsync>d__4:MoveNext() (at Assets/MixedRealityToolkit/Utilities/Gltf/Serialization/GltfUtility.cs:116)
System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1:Start(<ImportGltfObjectFromPathAsync>d__4&)
Microsoft.MixedReality.Toolkit.Utilities.Gltf.Serialization.GltfUtility:ImportGltfObjectFromPathAsync(String)
Microsoft.MixedReality.Toolkit.Utilities.Gltf.Serialization.Editor.<OnImportGltfAsset>d__0:MoveNext() (at Assets/MixedRealityToolkit/Utilities/Gltf/Serialization/Importers/GltfEditorImporter.cs:16)
System.Runtime.CompilerServices.AsyncVoidMethodBuilder:Start(<OnImportGltfAsset>d__0&)
Microsoft.MixedReality.Toolkit.Utilities.Gltf.Serialization.Editor.GltfEditorImporter:OnImportGltfAsset(AssetImportContext)
Microsoft.MixedReality.Toolkit.Utilities.Gltf.Serialization.Editor.GlbAssetImporter:OnImportAsset(AssetImportContext) (at Assets/MixedRealityToolkit/Utilities/Gltf/Serialization/Importers/GlbAssetImporter.cs:13)
UnityEditor.Experimental.AssetImporters.ScriptedImporter:GenerateAssetData(AssetImportContext)

Looking at recent merge history, it seems as if this may have been caused by #5378.

@davidkline-ms, can you rollback the change?

@wiwei, I'll look into it.

@davidkline-ms did you get any insights into why this shows? I just hit this in an upgrade migration test with 8/10 preview build.

Is there a fix or workaround for this issue?

@kelsosharp Not yet. I think for this specific issue, we'll need to make some updates to our glTF logo file.
Are you hitting it with that, or in your own file? Is it causing a blocking issue for you?

@keveleigh Honestly I am not sure, this is a brand new project, and all I have done is to import MRTK and Nether, and this error is in my console, I am just coming back to using Unity after being away, so I am not sure this is going to block me or not.

so I am not sure this is going to block me or not.

It shouldn't! It should just show up the first time you import MRTK, then not show up again. It should be pretty benign, but we'll still look into cleaning it up.


Build fails on sm/Sanity.c

Error:
Command: inplace/bin/ghc-stage1 -Wall -hisuf debug_hi -osuf debug_o -hcsuf debug_hc -static -optc-DDEBUG -ticky -DTICKY_TICKY -i -i_build/stage1/rts -i_build/stage1/rts/build/autogen -Iincludes -I_build/generated -I_build/stage1/rts -I_build/generated -optc-I_build/generated -optc-fno-stack-protector -odir _build/stage1/rts -hidir _build/stage1/rts -stubdir _build/stage1/rts -optc-I_build/generated -optc-fno-stack-protector -optc-Iincludes -optc-I_build/generated -optc-I_build/stage1/rts -Werror -Wnoncanonical-monad-instances -optc-Werror=unused-but-set-variable -optc-Wno-error=inline -c rts/sm/Sanity.c -o _build/stage1/rts/c/sm/Sanity.debug_o -O0 -H64m -O -optc-Irts -optc-Wall -optc-Werror -optc-Wextra -optc-Wstrict-prototypes -optc-Wmissing-prototypes -optc-Wmissing-declarations -optc-Winline -optc-Waggregate-return -optc-Wpointer-arith -optc-Wmissing-noreturn -optc-Wnested-externs -optc-Wredundant-decls -optc-Wundef -optc-fno-strict-aliasing -optc-I_build/stage1/rts '-optc-DRtsWay="rts_debug"' -optc-O2 -optc-DDEBUG -optc-DTICKY_TICKY -Irts -Wno-deprecated-flags -Wcpp-undef

In file included from rts/sm/Sanity.c:17:0: error:
rts/sm/Sanity.c: In function ‘checkSanity’:

includes/Rts.h:101:12: error:
     error: ‘last’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
             if (predicate)                          \
                ^
    |
101 |         if (predicate)                          \
    |            ^

rts/sm/Sanity.c:484:40: error:
     note: ‘last’ was declared here
             StgCompactNFDataBlock *block, *last;
                                            ^~~~
    |
484 |         StgCompactNFDataBlock *block, *last;
    |                                        ^
cc1: all warnings being treated as errors
`gcc' failed in phase `C Compiler'. (Exit code: 1)
)

Output of configure:
Configure completed successfully.

   Building GHC version  : 8.3.20171201
          Git commit id  : bc761ad9c65c7aa62d38db39c59a6c0ae59c8ab8

   Build platform        : x86_64-unknown-linux
   Host platform         : x86_64-unknown-linux
   Target platform       : x86_64-unknown-linux

   Bootstrapping using   : /home/michal/local/bin/ghc
      which is version   : 8.2.1

   Using (for bootstrapping) : gcc
   Using gcc                 : gcc
      which is version       : 7.2.1
   Building a cross compiler : NO
   Unregisterised            : NO
   hs-cpp       : gcc
   hs-cpp-flags : -E -undef -traditional
   ar           : ar
   ld           : ld.gold
   nm           : nm
   libtool      :
   objdump      :
   ranlib       : ranlib
   windres      :
   dllwrap      :
   genlib       :
   Happy        : /home/michal/local/bin/happy (1.19.7)
   Alex         : /home/michal/local/bin/alex (3.2.3)
   Perl         : /usr/bin/perl
   sphinx-build : /usr/libexec/python2-sphinx/sphinx-build
   xelatex      :

Hadrian invocation:
> ./hadrian/build.sh --flavour=quick -j

The build with make works with the quick flavor, ./validate also finishes successfully. This it at https://github.com/ghc/ghc/commit/bc761ad9c6

@michalt Thanks! Looks like a missing warning suppression flag to me.
Let me try to reproduce on my machine and CI bots.

@michalt Sorry, can't reproduce locally or on CI. Could be gcc version specific?

@michalt Should be fixed by #487. Please reopen if not.


Add support for more node versions for Travis-CI

Currently, the only tested node versions are v6 and v7 (according to travis-ci). It's not very easy to add other versions without some errors encountered, mainly with danger-js (see #48 for attempts by me to solve this issue).
If future releases of alexa-app-server are to intentionally drop support for older versions of node, it's best to add a section in the README stating which versions are supported.

+1 on adding a section for which versions of node are supported


Opt HttpResponseSender move constructor

What problem does this PR solve?
Issue Number:
Problem Summary:
HttpResponseSender移动后，重置成员变量，合理一些。
What is changed and the side effects?
Changed:
Side effects:

Performance effects(性能影响):

Breaking backward compatibility(向后兼容性):

Check List:

Please make sure your changes are compilable(请确保你的更改可以通过编译).
When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

LGTM


Nest 10.x.x - Nest can't resolve dependencies of the DiscoveryService

When attempting to use this library with a new project generated with the 10.1.7 CLI, the following error is thrown
[Nest] 20824  - 07/06/2023, 5:03:20 PM   ERROR [ExceptionHandler] Nest can't resolve dependencies of the DiscoveryService (?, MetadataScanner). Please make sure that the argument ModulesContainer at index [0] is available in the DiscoveryModule context.

Potential solutions:
- Is DiscoveryModule a valid NestJS module?
- If ModulesContainer is a provider, is it part of the current DiscoveryModule?
- If ModulesContainer is exported from a separate @Module, is that module imported within DiscoveryModule?
  @Module({
    imports: [ /* the Module containing ModulesContainer */ ]
  })

Reverting to 9.x.x fixed the issue

I've got the same problem

same issue, help...

While I wait for the PR to hopefully get approved and merged, I have a temporary package up with the NestJS dependencies bumped to support NestJS 10 here
https://www.npmjs.com/package/@alecmmiller/pigeon-mqtt-nest

While I wait for the PR to hopefully get approved and merged, I have a temporary package up with the NestJS dependencies bumped to support NestJS 10 here https://www.npmjs.com/package/@alecmmiller/pigeon-mqtt-nest

I use the @alecmmiller/pigeon-mqtt-nest，but the same error occurred


remove wrapper output that's using cdt_name

AFAIU, we're not using this anywhere in conda-forge. The old plan was indeed to have a cdt_name that follows the glibc version (like manylinux does for its versioning), but we've since moved away from that.
IMO we can just drop these.
Based on #77; will be rebased once that's in
CC @conda-forge/core

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe/meta.yaml:

License exception is not an SPDX exception.

Documentation on acceptable licenses can be found here.

Thanks


ARROW-6672: [Java] Extract a common interface for dictionary builders

We need a common interface for dictionary builders to support more sophisticated scenarios, like collecting dictionary statistics.

Codecov Report

Merging #5486 into master will increase coverage by 19.73%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #5486       +/-   ##
===========================================
+ Coverage   69.97%    89.7%   +19.73%
===========================================
  Files         755      708       -47
  Lines       89329   108242    +18913
  Branches     1498        0     -1498
===========================================
+ Hits        62509    97101    +34592
+ Misses      26455    11141    -15314
+ Partials      365        0      -365

Impacted Files
Coverage Δ

cpp/src/arrow/testing/gtest_util.h
97.36% <0%> (-2.64%)
:arrow_down:

cpp/src/arrow/compute/kernel.h
60.57% <0%> (-2.11%)
:arrow_down:

cpp/src/plasma/thirdparty/ae/ae.c
70.75% <0%> (-0.95%)
:arrow_down:

cpp/src/arrow/result.h
91.3% <0%> (-0.37%)
:arrow_down:

cpp/src/arrow/table.h
100% <0%> (ø)
:arrow_up:

cpp/src/arrow/flight/server.h
100% <0%> (ø)
:arrow_up:

cpp/src/arrow/table_builder.h
100% <0%> (ø)
:arrow_up:

cpp/src/plasma/plasma.h
100% <0%> (ø)
:arrow_up:

cpp/src/arrow/flight/types.h
100% <0%> (ø)
:arrow_up:

cpp/src/gandiva/configuration.h
100% <0%> (ø)
:arrow_up:

... and 700 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35b6d07...287bdd1. Read the comment docs.


mWeb- Search -Focus and keyboard dismissed when start searching second user

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing https://github.com/Expensify/App/pull/11673
Action Performed:

Go to staging.new.expensifail.com
Log in with your account
Select Fub menu - Select New Group
Type the user in search filed
Tap on the user
Go back to the search field
Search second user

Expected Result:
Able to search second user without any issues
Actual Result:
Focus and keyboard dismissed when start searching second user
Workaround:
Unknown
Platform:

Where is this issue occurring?

Mobile Web

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/195627326-dc5721cc-40ef-4eff-81bd-e81bf70911c7.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

I reproduced this error on Chrome (Android), for some reason seems it happens when the search input loses the focus, it's focused again and the user types something.

Proposal
Root cause
We scrolled the list whenever we select an option or the options list is changed.
https://github.com/Expensify/App/blob/7044ab2b96067081c8f67191e51fa859dba66d91/src/components/OptionsSelector/BaseOptionsSelector.js#L198
We also settings the OptionList to dismiss the keyboard when the list is scrolled.
https://github.com/Expensify/App/blob/7044ab2b96067081c8f67191e51fa859dba66d91/src/components/OptionsList/index.js#L11
So every time the scroll position is changed the keyboard will be dismissed.
Solution
Remove keyboardDismissMode and replace it with onScroll callback. We will dismiss the keyboard only when the user is touch scroll the list not when we scroll the list programmaticly.
diff --git a/src/components/OptionsList/BaseOptionsList.js b/src/components/Opti
onsList/BaseOptionsList.js
index c8337b87a..3fe0d31b7 100644
--- a/src/components/OptionsList/BaseOptionsList.js
+++ b/src/components/OptionsList/BaseOptionsList.js
@@ -17,12 +17,15 @@ const propTypes = {
     /** Called when the user begins to drag the scroll view */
     onScrollBeginDrag: PropTypes.func,

+    onScroll: PropTypes.func,
+
     ...optionsListPropTypes,
 };

 const defaultProps = {
     keyboardDismissMode: 'none',
     onScrollBeginDrag: () => {},
+    onScroll: () => {},
     ...optionsListDefaultProps,
 };

@@ -229,6 +232,7 @@ class BaseOptionsList extends Component {
                     indicatorStyle="white"
                     keyboardShouldPersistTaps="always"
                     keyboardDismissMode={this.props.keyboardDismissMode}
+                    onScroll={this.props.onScroll}
                     onScrollBeginDrag={this.props.onScrollBeginDrag}
                     contentContainerStyle={this.props.contentContainerStyles}
                     showsVerticalScrollIndicator={false}

diff --git a/src/components/OptionsList/index.js b/src/components/OptionsList/in
dex.js
index 7db02df56..1e0d535b3 100644
--- a/src/components/OptionsList/index.js
+++ b/src/components/OptionsList/index.js
@@ -1,16 +1,48 @@
-import React, {forwardRef} from 'react';
+import React, {forwardRef, useEffect} from 'react';
+import {Keyboard} from 'react-native';
 import BaseOptionsList from './BaseOptionsList';
 import withWindowDimensions from '../withWindowDimensions';
 import {propTypes, defaultProps} from './optionsListPropTypes';
+import canUseTouchScreen from '../../libs/canUseTouchscreen';

-const OptionsList = forwardRef((props, ref) => (
-    <BaseOptionsList
-        // eslint-disable-next-line react/jsx-props-no-spreading
-        {...props}
-        ref={ref}
-        keyboardDismissMode={props.isSmallScreenWidth ? 'on-drag' : 'none'}
-    />
-));
+let isScreenTouched = false;
+
+const OptionsList = forwardRef((props, ref) => {
+    useEffect(() => {
+        const onTouchStart = () => {
+            if (!canUseTouchScreen()) {
+                return;
+            }
+            isScreenTouched = true;
+        };
+
+        const onTouchEnd = () => {
+            isScreenTouched = false;
+        };
+
+        document.addEventListener('touchstart', onTouchStart);
+        document.addEventListener('touchend', onTouchEnd);
+
+        return () => {
+            document.removeEventListener('touchstart', onTouchStart);
+            document.removeEventListener('touchend', onTouchEnd);
+        };
+    }, []);
+
+    return (
+        <BaseOptionsList
+            // eslint-disable-next-line react/jsx-props-no-spreading
+            {...props}
+            ref={ref}
+            onScroll={() => {
+                if (!isScreenTouched) {
+                    return;
+                }
+                Keyboard.dismiss();
+            }}
+        />
+    );
+});

 OptionsList.propTypes = propTypes;
 OptionsList.defaultProps = defaultProps;

Result
https://user-images.githubusercontent.com/25520267/195778763-3b15a659-fb31-4167-8283-422aec851b4d.mov
https://user-images.githubusercontent.com/25520267/195778841-3bc859d4-98d9-4774-b7c0-f7291e5f7449.mp4

@marcochavezf - does @mollfpr's proposal work here?

@mollfpr's proposal looks good to me, works on mWeb correctly
🎀👀🎀 C+ reviewed!
cc: @marcochavezf
The better approach would be to figure out how to disable onScroll callback when selecting an option, but I doubt that's viable

Thanks for the review @eVoloshchak and for the proposal @mollfpr! A few comments about the proposal:

I noticed keyboardDismissMode is removed, and historically had the value on-drag. Do we test it in other places where OptionsList is used? I'm a bit worried that this could cause a regression, but if it's working fine in other places or we can confirm that this is not necessary, then we're good.
We're not allowed to use hooks, could we update the proposal to use an alternative to useEffect?

Alternatively, I was wondering if another solution could be just setting keyboardDismissMode="none" for the search, thoughts?

I noticed keyboardDismissMode is removed, and historically had the value on-drag. Do we test it in other places where OptionsList is used? I'm a bit worried that this could cause a regression, but if it's working fine in other places or we can confirm that this is not necessary, then we're good.

On native keyboardDismissMode="on-drag" is replaced with onScrollBeginDrag but for web onScrollBeginDrag is not available while keyboardDismissMode="on-drag" is also dismiss the keyboard when we scroll the view programmatically. My proposal is mimicking the onScrollBeginDrag usage on native to dismiss the keyboard only when the user is doing the scroll. I also try the proposal on IOUParticipantsSplit and it's working fine.

We're not allowed to use hooks, could we update the proposal to use an alternative to useEffect?

We can convert the OptionsList/index.js from a functional component to a class component.

Alternatively, I was wondering if another solution could be just setting keyboardDismissMode="none" for the search, thoughts?

Unfortunately, the keyboard is not dismissed when we scroll the view by dragging the screen.
cc @eVoloshchak @marcochavezf

Since this one is getting more proposals I've closed the other and updated the job posting.
The job is posted here: https://www.upwork.com/jobs/~01f1aaaefeb1b37071

Done

I noticed keyboardDismissMode is removed, and historically had the value on-drag. Do we test it in other places where OptionsList is used? I'm a bit worried that this could cause a regression, but if it's working fine in other places or we can confirm that this is not necessary, then we're good.

I've tested it in other places, it mimics the previous behavior, so as long as all we need is to dismiss the keyboard on scroll, I think we're good
I'm not sure what's the correct behavior for each of the screens that use OptionsList, this one, for example, dismisses the keyboard after the user was selected, while this is not the case for the search screen.
https://user-images.githubusercontent.com/9059945/196765542-f4f1d3ec-98f5-401a-94b3-b2de95f6ad6f.mov
Both of these scenarios are unaffected by @mollfpr's proposal, so nothing should change.

Alternatively, I was wondering if another solution could be just setting keyboardDismissMode="none" for the search, thoughts?

We can, but the keyboard won't be dismissed when scrolling. Not sure if that's a big deal, but that would be inconsistent with the rest of the screens.
We could, however, wait for a better proposal since this one is a workaround technically

Issue not reproducible during KI retests. (First week)

@muttmuure Applied to the job, thanks!

bump @muttmuure

Hired both @rushatgabhane as reporter you also need to apply

@mollfpr has been paid. @rushatgabhane waiting for you to accept @eVoloshchak you still need to apply

Issue not reproducible during KI retests. (Second week)

@mollfpr has been paid. @rushatgabhane waiting for you to accept @eVoloshchak you still need to apply

Applied ✅

Rushat paid. Just waiting for Eugene to accept and get paid then we can close.

Everyone paid. Closing out


community: Migrate Vertex AI Search Retriever from v1beta to v1

PR Description
Hey team, this PR migrates the Vertex AI Search Retriever from v1beta to the stable v1 API.
Type
🧹 Refactoring
✅ Test
Changes
Key changes:

Updated imports from discoveryengine_v1beta to discoveryengine_v1
Removed unsupported v1beta features from VertexAISearchRetriever: embedding_spec, ranking_expression, relevance_threshold, personalization_spec, and natural_language_query_understanding_spec
Removed custom embedding functionality dependent on beta features

Testing

Modified corresponding tests to exclude beta feature tests for vertex_ai_search.

Thank you Team,

Hey @lkuligin ,
I've added all the changes to support both the stable and beta versions of vertex_ai_search and updated the corresponding tests.
The changes turned out to be larger than expected.
Please let me know if you have any comments or suggestions.
Thanks!

@lkuligin ,
The integration tests are failing, but I’m unable to see the CI log details. Could you help me check?
Thanks so much!

@lkuligin
Please let me know if everything looks good or if there’s anything else needed.
Thank you!

@lkuligin Thank you for the feedback! All the changes pushed.

@lgesuellip thanks for the changes! some linting issues remain, take a look, please (probably it's enough just to ignore the warnings for now).

Removed unsupported v1beta features from VertexAISearchRetriever: embedding_spec, ranking_expression, relevance_threshold, personalization_spec, and natural_language_query_understanding_spec

@lkuligin I just updated it! Thanks,


Imitating rfid cards

Hello guys!
Is it possible with this lib to imitate rfid cards. e.g. rfid cards have uid that is read to enter parking lot or whatever.  Could phone emit same signal to imitate rfid card? If so is it supported by both Android & iOS?
Thanks in advance.

Hi @mrados7 the feature you're looking for is generally called NFC card emulation, which is only available on Android (called HCE, or Host-based Card Emulation). Our library currently doesn't support it.


[Triton-MLIR] Add bfloat16 support for AMDGPU.

Add code to convert bfloat16 to and from float32 to enable elementwise op support for bfloat16.
This was done using LLVM intrinsics in order to avoid using the GCNBuilder construct.

Please provide the description. And perhaps update "test_core_amd.py" if there are previously failing tests which are now passing with the PR.

I enabled bfloat16 for test_bin_op in test_core_amd.py.


docs: update readme

Adds basic documentation for the CLI. Let me know if you want to go into more detail for each command, or if the docs included in the CLI are sufficient.

@strophy I've restructured the doc a bit. Please take a look. Also we need to accomplish "Register masternode" section. I would describe the whole process there: funding collateral, registering masternode, obtaining keys... where to use these keys and so on.


Display invisible character

Description
Zero width characters can be used in some programs or to fingerprint people.
See Zero-Width Characters - Invisibly fingerprinting text and Be careful what you copy: Invisibly inserting usernames into text with Zero-Width Characters.
Those characters are not rendered in anyway, making hard to detect them.
So we need an option to:

render invisible chars as their UTFx code (like in nvim <200b>
or to render any invisible char as one arbitrary chosen char like for whitespace

Invisible Character Visualizer seems to do that well so the feature can start from this plugin instead from scratch.
Second thing, the show whitespace feature of vscode is only displaying whitespaces and tabs but not CR and EOL like many editors.
For example in atom

Possible related issues and resources

View invisible characters #31291
Feature request: Show hidden characters like: space, tab, end of line, carriage return #18282
Invisible Character Visualizer https://marketplace.visualstudio.com/items?itemName=ShaneRay.InvisibleCharacterVisualizer, but this is for Visual Studio not for VS Code

Demo
VS Code (not even a clue there is something)

neovim (nvim)

xxd
$ xxd test
00000000: 436f 6e66 6964 656e 7469 616c 2041 6e6e  Confidential Ann
00000010: 6f75 6e63 656d 656e 743a 20e2 808c e280  ouncement: .....
00000020: 8be2 808b e280 8ce2 808b e280 8be2 808b  ................
00000030: e280 8ce2 808d e280 8ce2 808b e280 8be2  ................
00000040: 808c e280 8be2 808b e280 8be2 808b e280  ................
00000050: 8de2 808c e280 8be2 808b e280 8be2 808c  ................
00000060: e280 8ce2 808b e280 8ce2 808d e280 8ce2  ................
00000070: 808b e280 8be2 808c e280 8ce2 808c e280  ................
00000080: 8ce2 808b e280 8de2 808c e280 8be2 808b  ................
00000090: e280 8ce2 808b e280 8ce2 808b e280 8c54  ...............T
000000a0: 6869 7320 6973 2073 6f6d 6520 636f 6e66  his is some conf
000000b0: 6964 656e 7469 616c 2074 6578 7420 7468  idential text th
000000c0: 6174 2079 6f75 2072 6561 6c6c 7920 7368  at you really sh
000000d0: 6f75 6c64 6e27 7420 6265 2073 6861 7269  ouldn't be shari
000000e0: 6e67 2061 6e79 7768 6572 6520 656c 7365  ng anywhere else
000000f0: 2e0a                                     ..

May I suggest having a setting to only show the whitespace and invisible characters in selections? Sublime Text has this option and it's really useful, because by default it doesn't get in the way, but you can easily see the characters when you want to.
I actually modified one of the Code color themes to do this [1], but making it a setting would be better.
[1] https://github.com/Instagit/vscode-theme-monokai-dark-soda-whitespace

A setting to show invisible characters in selection but also a setting to show invisible characters globally.
Note that I'm talking about invisible characters as all non printable character not only whitespaces (space, tab, etc.).

I just waisted 20m debugging a url problem because I had a Unicode Decimal Code  preceding my absolute url causing it to be treated as a relative path.
Please allow us to enable rendering of these weird characters that no programmer ever wants in their code.

As in Atom would be great.
It's a must-have feature, I have trouble doing without.

I've just experienced a compile error caused by Unicode character U+202C and U+202D hiding in pasted C code. It's really hard to locate and remove them. Since it's a common operation for programmers to paste code from somewhere else, I think there is a good reason to make displaying invisible character an internal feature, not just a third party plugin.

I have just experienced that zero width characters are not being "placed" at the right place in the editor. I am inserting a u200b invisible character and writing it to disk in PHP, when I open the written file the character seems to be in the wrong position (moving the cursor through all the characters in the file), however it shows correctly place when I open the same file with SublimeText 3

https://github.com/eslint/eslint/issues/11752

I use Gremlins https://marketplace.visualstudio.com/items?itemName=nhoizey.gremlins
It works well

Yes, do this please, I spent the whole afternoon to find out a f*cking \u200b

Plugins:

https://marketplace.visualstudio.com/items?itemName=nachocab.highlight-dodgy-characters: very useful it highlight all all chars
https://marketplace.visualstudio.com/items?itemName=wengerk.highlight-bad-chars: no handy as you must specify which char you want to be highlighted
https://marketplace.visualstudio.com/items?itemName=nhoizey.gremlins: does highlight only a few chars such as whitespaces, etc. not all non printable

@noraj Thank you for the "Highlight Dodgy Characters" suggestion. Solved my issue quickly and simply.

I just waisted 20m debugging a url problem because I had a Unicode Decimal Code  preceding my absolute url causing it to be treated as a relative path.

Lucky guy, I wasted 2 days :-D

Any progress on this problem? I believe 0x200B is a horrible character and should be highlight as a warning.
Now my solution is to write an ESLint plugin banning it.

Waste for than 3 hours.
Kudos to this extension : https://marketplace.visualstudio.com/items?itemName=wengerk.highlight-bad-chars

👍 and +1 from me too.  I had some strange character in a file and VS code didn't show it, typing arrow keys mysteriously didn't move the cursor!  Should not have to resort to the good old 'od' command lol.

@noraj Thank you! Waste me a couple of hours to debug a rest call. The url looks good, but with the U+200c inside. With the extension you recommend, it is easy to figure out this kind of bugs.

+1
IntelliJ wins in terms of highlighting it.

This is an important security feature and should be built into vscode with the ability to toggle on/off just like word wrap.
I would also add a shortcut to the status bar on the bottom that shows how many hidden characters are on the page.
See article: https://certitude.consulting/blog/en/invisible-backdoor/

Isn't this fixed with #137719?

https://code.visualstudio.com/updates/v1_63#_unicode-highlighting

Thank You 👍🏼 🥇

Fixed with #137508.
Feel free to open issues for use-cases described in this issue that are not covered by that PR.


Training using pre-trained performanceRNN weights

How to load pre-trained performanceRNN model weights (.mag file with or without dynamics) to start learning from these weights?
I want to retrain performanceRNN on my small midi set (only 60 midi files, too little to learn from scratch)

You should be able to use this script to extract a checkpoint from one of our bundle files: https://github.com/tensorflow/magenta/blob/master/magenta/scripts/unpack_bundle.py
And then run performance_rnn_train pointing --run_dir at wherever the extracted checkpoint lives.

@iansimon Hi Ian, I am encountering the same issue and tried the method you suggested. However, it seems that the model is still training from the begining, i.e. it doesn't mention about restoring saved checkpoint as I will expect. Also, I noticed that runing performance_rnn_train, .index and .data files will be saved besides .meta and .ckpt files. I am not sure whether I will need those other two files while restoring checkpoint. Thank you!
Below is the output when runing  performance_rnn_train as you suggested,
INFO:tensorflow:Train dir: performance_rnn/run2\train
INFO:tensorflow:Starting training loop...
INFO:tensorflow:Create CheckpointSaverHook.
INFO:tensorflow:Saving checkpoints for 1 into performance_rnn/run2\train\model.ckpt.
while I am expecting something like this:
INFO:tensorflow:Restoring parameters from performance_rnn/run3\train\model.ckpt

Can you send me the exact command you entered?

Update on the issue.
SEQUENCES_TFRECORD=data/improv_rnn/jazz_xml2/training_lead_sheets.tfrecord
RUNDIR=improv_rnn/run6
improv_rnn_train
--config=chord_pitches_improv
--run_dir=${RUNDIR}
--sequence_example_file=${SEQUENCES_TFRECORD}
--hparams="batch_size=128,rnn_layer_sizes=[256, 256, 256]"
--num_training_steps=10
command: ls improv/run6/train
output:
checkpoint
events.out.tfevents.1511859596.DESKTOP-VTMLC08
graph.pbtxt
model.ckpt
model.ckpt.meta
model.ckpt-1.data-00000-of-00001
model.ckpt-1.index
model.ckpt-1.meta
Many thanks.
Yan

One step towards a fix is that after unpacking the bundle but before training you should create a file called "checkpoint" in improv_rnn/run6/train that looks like:
model_checkpoint_path: "/tmp/chords/run2/train/model.ckpt"
all_model_checkpoint_paths: "/tmp/chords/run2/train/model.ckpt"

But there seems to be some kind of checkpoint incompatibility with what's in the bundle; in fact even if you create a new bundle then unpack it and train you'll get variable name errors.  I'm looking into it now...

That's right. I tried adding checkpoint file but it doesn't work. Thank you for your help!
Regards,
Yan

Hello, sorry for bumping up this post. I also want to experiment with refining a pre-trained net and, thus, would like to know it the issue with checkpoints compatibility has been solved.

Hi, sorry for bumping up this post too. I am working with performance_rnn pre-trained models and I am in a similar stage that @zZyan was. I used the unpack_bundle function and then training the model but the parameters are not restored from the downloaded checkpoint. I tried the indications previously posted. Is there any workaround or any news about it @iansimon? Regards.

Amazingly, it looks like fine-tuning has never worked for our RNN models, or has at least been broken for years.  #1753 (in progress but the code should work right now) fixes this and supports fine-tuning from a bundle file for Performance RNN.

@iansimon Thank you very much, I just performed the training from a bundle file for Performance RNN and it seems that everything works as expected.


Header -> BodySemibold in stellar account input

The ticket was unclear on which text exactly needed to be changed. It sounded like the input text, but it was not set to "Header" - see e.g. https://github.com/keybase/client/blob/master/shared/common-adapters/input.desktop.js#L244

This seems to be outdated and someone else changed it already.


Support for synchronizing secrets from tenant to LB cluster

What this PR does / why we need it:
With this PR, we want to add the propagation feature of TLS certificates from the consumer to the load-balancing cluster. The design has been instead kept simple to avoid any over-engineering. Since, in the future, we want to lean towards sources such as vaults, external secrets, etc, managed by the administrators for their tenants.
In this feature, we are creating a new resource, SyncSecret, which is simply a wrapper over Kubernetes Secret. The custom resource helps us ensure that we are not exposing any secrets from the LB cluster to the tenants.
Example
Native Kubernetes Secret:
kind: Secret
apiVersion: v1
metadata:
  name: mongodb-credentials
stringData:
  mongodb-password: "123456"
  mongodb-root-password: "123456"
type: Opaque

Converted to a Sync Secret:
kind: SyncSecret
apiVersion: kubelb.k8c.io/v1alpha1
metadata:
  name: mongodb-credentials
stringData:
  mongodb-password: "123456"
  mongodb-root-password: "123456"
type: Opaque

The SyncSecret is then propagated to the tenant namespace in LB cluster for consumption.
Automation
This process can also be automated by enabling  the flagenable-secret-synchronizer for the CCM. This will enable a controller that automatically converts secrets labeled with kubelb.k8c.io/managed-by: kubelb to SyncSecrets in the tenant cluster.
Which issue(s) this PR fixes:

Fixes #23
What type of PR is this?

/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:

* `SyncSecret` resource has been introduced that can be used to synchronize a secret from tenant to LB cluster
* Secret synchronizer controller can be enabled by the flag `enable-secret-synchronizer` for CCM. Enable automatically converting Secrets labeled with `kubelb.k8c.io/managed-by: kubelb` to SyncSecrets.  This controller requires elevated access to secrets in the tenant cluster to perform CRUD operations.

Documentation:

TBD

/approve


Create a generator for the front end modules

Hi,
I just wanted to know if there is a specific generator has been used for the angular modules here.
Thanks.

Hi @shalkam,
In the beginning of the project I used generator-angular. The angular modules have changed a lot though, to it's no longer compatible, as stated in the README.
I'm working on an enhanced version in the develop branch, and I think it will be a nice addition to have generators for that structure.
Related: #171  #151 #139

This issue is created for the v0.x version of the project, which is no longer support nor maintained as of January 16th 2017. I'm therefore closing this issue.
All development effort will be put in the new version of the project that is named Colmena CMS.


Fix repon names in plugins.yaml

@dex80526: Updated the following 2 configmaps:

plugins configmap in namespace default at cluster default using the following files:

key plugins.yaml using file prow/plugins.yaml

job-config configmap in namespace default at cluster default using the following files:

key am-all-presets.yaml using file ``

In response to this:

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Update Nextcloud to 18.0.2

Hi @rvbuelow,
Is it okay if I merge your code into my repo ?
It seems that you've been able to add some improvements to the first draft I did and it could be beneficial to the whole community.

Hi @mtthp, hi @rvbuelow
I think it would be great to have on master repo. I am willing to contribute, too. Maybe jacques24681 can help, too (don't know how to integrate him in this discussion)

When do you want to merge this pull request?

Hi @mtthp
you're welcome to merge the changes.
Cheers

Sorry to answer this so late. As there aren't any great changes (mostly documentation), I decided to update the version myself in https://github.com/mtthp/hassio-addons/commit/c4f9bb48347e7ac2b7bdf3fcf0a5429e5f9ea0ea
Thanks anyway !


Error~ java.lang.NoClassDefFoundError - Unirest POST response

import com.mashape.unirest.http.HttpResponse;
import com.mashape.unirest.http.JsonNode;
import com.mashape.unirest.http.Unirest;
import com.mashape.unirest.http.exceptions.UnirestException;
import org.json.JSONException;
public class CheckInFacial extends AppCompatActivity {
ProgressBar progressBar;
TextView responseView;

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.activity_check_in_facial);

    progressBar = (ProgressBar) findViewById(R.id.progressBar);
    responseView = (TextView) findViewById(R.id.responseView);

    progressBar.setVisibility(View.VISIBLE);
    responseView.setText("Hi there");

    Button queryButton = (Button) findViewById(R.id.queryButton);
    queryButton.setOnClickListener(new View.OnClickListener() {
        @Override
        public void onClick(View v) {

            CheckInFacial cl2 = new CheckInFacial();
            cl2.post1();

        }
    });

}

public void post1(){

    try {
        HttpResponse httpResponse = Unirest.post("post website")
                .header("X-Mashape-Key", the key)
                .header("Content-Type", "application/x-www-form-urlencoded")
                .header("Accept", "application/json")
                .field("attributes", "all")
                .field("detector", "Aggressive")
                .field("limit", 64)
                .field("namespace", "Ben")
                .field("uids", "all")
                .field("urls", "http://www.url.com")
                .asString();

        System.out.println(httpResponse.getBody());

    } catch (UnirestException e) {
        e.printStackTrace();
    }

}

}

I receive an error during run time.
FATAL EXCEPTION: main
Process: benchinpteltd.benapp, PID: 10664
java.lang.NoClassDefFoundError: com.mashape.unirest.http.HttpMethod
at com.mashape.unirest.http.Unirest.post(Unirest.java:171)
at benchinpteltd.benapp.CheckInFacial.post1(CheckInFacial.java:59)
at benchinpteltd.benapp.CheckInFacial$1.onClick(CheckInFacial.java:43)
at android.view.View.performClick(View.java:4640)
at android.view.View$PerformClick.run(View.java:19421)
at android.os.Handler.handleCallback(Handler.java:733)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:146)
at android.app.ActivityThread.main(ActivityThread.java:5487)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:515)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1283)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1099)
at dalvik.system.NativeStart.main(Native Method)

How do I solve this? thank you!!

<dependencies>
	<dependency>
		<groupId>org.apache.httpcomponents</groupId>
		<artifactId>httpclient</artifactId>
		<version>4.3.6</version>
	</dependency>
	<dependency>
		<groupId>org.apache.httpcomponents</groupId>
		<artifactId>httpasyncclient</artifactId>
		<version>4.0.2</version>
	</dependency>
	<dependency>
		<groupId>org.apache.httpcomponents</groupId>
		<artifactId>httpmime</artifactId>
		<version>4.3.6</version>
	</dependency>
	<dependency>
		<groupId>org.json</groupId>
		<artifactId>json</artifactId>
		<version>20140107</version>
	</dependency>
	<dependency>
		<groupId>junit</groupId>
		<artifactId>junit</artifactId>
		<version>4.12</version>
		<scope>test</scope>
	</dependency>
	<dependency>
		<groupId>commons-io</groupId>
		<artifactId>commons-io</artifactId>
		<version>2.4</version>
		<scope>test</scope>
	</dependency>
	<dependency>
		<groupId>com.fasterxml.jackson.core</groupId>
		<artifactId>jackson-databind</artifactId>
		<version>${jackson.version}</version>
		<scope>test</scope>
	</dependency>
</dependencies>

I am confused, is it pom for android project? Where is Unirest dependency?

Hi Shashiranjan!
Sorry for the late reply and thanks for getting back.
I am new to this (android development) and I might not have explained it clearly in technical terms. My apology if that is so.
So I actually followed the link (http://blog.mashape.com/using-unirest-java-for-your-android-projects/)
to create a unirest.jar file. I'm having problems as mentioned on my thread title above.
Regarding your latest reply, that is an extract of the dependencies in pom.xml from the unirest file that I presumed that you might me looking for. Please correct me if you're looking for something else and the location to look for it.
Thank you so much.

@shashiranjan84 Sorry. Do you mind replying me please :(.. Or is it off working hours.

I have done very little development on Android so cant help you here much, it seems like you android project not able to find the Unirest jar. Its very difficult for me to tell what exactly doing wrong without seeing your code. Just try to create new Unirest jar with shaded HttpClient as described in blog and place it right place in android project. Searching further on google always helps

Hey @shashiranjan84 . Appreciate your reply!
Meantime I'll keep working on it! :)

Hi @shashiranjan84, Sorry to keep troubling you. But do you have the jar file for android that I can use for?

I agree this is a project problem, not something with Unirest specifically, You should make sure all the jars and classes are getting packaged together.


Performance measures for your Data Science/Machine Learning application 1.

Proposed title of the article
Performance measures for your Data Science/Machine Learning application 1.
Introduction paragraph (2-3 paragraphs):
While working on our models, we would at one point need to check their performance. This would include checking on the errors, the accuracy, biases, etc. We would do that in this article using a classification problem. Since we would look at them in depth, I will look at checking the errors using Cross-validation scores and the Confusion matrix in this part.
We will be using Python and Scikit-Learn.
Key takeaways:
The takeaways are checking the performance using:

Cross-validation scores.
Confusion matrix.

Moreover, we will look at using a Stochastic Gradient Classifier on a dataset.
References:
Please list links to any published content/research that you intend to use to support/guide this article.
BOOK: Hands-On Machine Learning with Scikit-Learn & TensorFlow CONCEPTS, TOOLS, AND TECHNIQUES TO BUILD INTELLIGENT SYSTEMS by Aurélien Géron.

@munubi254
Good afternoon and thank you for submitting your topic suggestion.
Your topic form has been entered into our queue and should be reviewed (for approval) as soon as a content moderator is finished reviewing the ones in the queue before it.

@munubi254
Sounds like an interesting topic - let me ping our resident ML expert to see how we can draw any more substance from this particular topic @lalith1403

@munubi254 Thanks for the topic suggestion. Can you clarify the purpose of the article. We tend to publish articles that are programmer-centric. Confusion matrix and cross-validation are small topics and well documented. We would love to hear from you about the unique aspect that you would bring with this article.
Probably, a project that uses these concepts to assess the performance and upgrade it by using these metrics as a navigating guide. I hope that makes sense.
Cc: @hectorkambow

Yes @lalith1403. I'll be doing that using a classification task based on
the MNIST dataset. Thereafter, I will do the performance measures using the
metrics.
On Wed, Aug 4, 2021, 21:15 Lalithnarayan C @.***> wrote:

@munubi254 https://github.com/munubi254 Thanks for the topic
suggestion. Can you clarify the purpose of the article. We tend to publish
articles that are programmer-centric. Confusion matrix and cross-validation
are small topics and well documented. We would love to hear from you about
the unique aspect that you would bring with this article.
Probably, a project that uses these concepts to assess the performance and
upgrade it by using these metrics as a navigating guide. I hope that makes
sense.
Cc: @hectorkambow https://github.com/hectorkambow
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/section-engineering-education/engineering-education/issues/3035#issuecomment-892869351,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ATOF26EXIZZYLJWJ2QBKO2TT3F7URANCNFSM5BAMUVEQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

MNIST dataset is a toy dataset and well documented throughout the net. We are looking to publish articles that are programmer-centric and unique. Thanks for the topic suggestion. We encourage you to submit a new topic form with a new idea. Thank you.
I will be closing this issue for now. Look forward to seeing your new idea. Ping me once done.


Mobile apps: "Connect" modules should open URLs in the same window, not in external browser

https://github.com/unaio/una-mobile-app/commit/28e5d2ea37f8314d167ec9ec77a60ad491695e97


Module Docs Update and Install Guide

I have updated the documentation on the modules so when you run a ansible-doc you now see you need port and protocol as a requirement. This caused me no end of trouble.. Until I read the code.
Also updated the install readme to include a non pip install option as the pip install didn't work in our environment.

The readme part I updated is slightly wrong, you need to copy the directory to the /usr/share/ansible/plugins/modules then run your pip install or else it will be linked to were you run the pip from which isn't great method. I am happy to update the readme with this before you commit or after. Give me a shout.

Thank you! However, module changes must originate from the templates residing within our sdk-generator repository. As the generator is a private repo, I will make these changes and submit a PR crediting it to you.

No problems buddy! Thanks for letting me know. I will close down the pull! I will get some scenario playbooks written shortly.


cannot download lean engine: git clone downloads wrong file

While trying to git clone the project, I get the wrong file.
Thanks

Hey @SadiqSAhmed! Suggest reading our documentation and using the lean CLI https://www.quantconnect.com/docs/v2/lean-cli it's meant to be user friendly, we can't give support to direct usages of lean engine

the file being cloned ('git clone https://github.com/QuantConnect/Lean.git') is wrong. it is not related to lean-cli or direct usage of the engine.
thnx


chore(readme): fixes bad link in the README.md

For doc

Background
Hit 404, while reading the docs

Change List

Fixes 404 link for webpack in the README.md

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Coverage increased (+2.6%) to 82.211% when pulling 738221717c9e2edcaa280a473b3329f4be174459 on pranshuchittora:docs-readme into b579f8ffe53858d1c20cef8b101cae31948b8523 on uber:master.

Thank you @Pessimistress for blazing-fast approval.
I am looking forward to contribute more, unfortunately, I am not able to find any good first issue. Can you pls label a few or suggest something easy.
Looking forward to it.


[README] --process-dependency-links deprecated

Olm bindings are now hosted on pypi. If libolm is already installed, it should be as simple as pip install .[e2e]. Personally, I would prefer removing that section from the README entirely until such a time as the e2e portions of the library are actually usable (if ever).

Closed by #299


Open Science history / framing

Perhaps an overarching "where have we come from, why is this important, where are we now" part, to help frame the rest of the 101. Lots of examples you can pull from here.

The history of Open Science is an interesting aspect, didn't think about that. Might shed more light on some current methods/principles. Thanks for the suggestion @kaythaney!

One of my favourite examples from history: https://en.wikipedia.org/wiki/Magdeburg_hemispheres#Demonstrations .


404 page not found

install on ubuntu 20 without errors,
after opening the url in the browser all i get is 404

Hi. What's the URL you're trying to access?
Could you also run this command and paste the output please? docker logs traefik

@nozimm I just extracted traefik service to a different compose file (docker-compose.traefik.yml). If you're not using a custom domain please try to start the stack without that.
# Main stack + Unprotected Torrenting
docker-compose -f docker-compose.yml -f docker-compose.torrents.yml up -d

And then, on your browser, go to http://localhost:8112 (you should see Deluge's Web UI).

The Problem was, that my server was only accessable through a custom subdomain. I tried it with another domain and not a subdomain, now it works. Thanks.

Excellent! I'm glad it's working now.


Bump color-eyre from 0.5.11 to 0.6.0

Motivation
https://github.com/ZcashFoundation/zebra/pull/3342 fails because it creates a duplicate dependency on tracing-subscriber.
Bump color-eyre and update tracing-subscriber too or add an exception for it
Specifications

Designs

Related Work

@conradoplg can we close this ticket and do the upgrade with the rest of tracing in #2953?

@conradoplg can we close this ticket and do the upgrade with the rest of tracing in #2953?

Sure!


browser windows are left behind after script terminates

I can make a PR that will exit opened windows, but I am not sure whatever this project is actively maintained

If you send a PR I'll probably just blindly merge it.
On Thu, Aug 23, 2018 at 10:41 AM, Mateusz Konieczny <
<EMAIL_ADDRESS>wrote:

I can make a PR that will exit opened windows, but I am not sure whatever
this project is actively maintained
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/DanMcInerney/search-google/issues/5, or mute the
thread
https://github.com/notifications/unsubscribe-auth/ABuspd9srkzwOaRd1XprpCYeniRk1Lfuks5uTttJgaJpZM4WJ5KE
.


readline() woes

When evaluating readline in the editor input is wonky -- you need to type a newline before the input you want to pass to readline.

I see this too (Win 10; julia-client 0.8.12-beta2). After hitting Ctrl-Enter on a line with readline() I need to switch to the REPL, type something (e.g., "1"), hit Enter, then my input, then Enter. Whatever I typed first gets evaluated (hence a space or the digit 1). Simply starting with a newline did not work.


[TA] Prepare for monthly patch release Aug 2022

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-ai-textanalytics


feat: add fuel-indexer

@bingcicle A few questions

Is the indexer binary installed automatically when I install fuelup?

I imagine it's installed in the same location as forc (for example)?

If I'm open fuelup and I want to change which version of the indexer binary I'm using, is that possible? If so, how would I do that?
If I'm on a prior version of fuelup (0.12) would I fuelup self update to upgrade to the fuelup version that supports the indexer binary? (when that version is released, anyway)


RFC regarding breaking API changes needed to implement Starfield support.

With the introduction of the v2 and v3 variants of the .ba2 format in Starfield, the archive format is no longer sufficient to discriminate between data format variants. Most functions now also require a compression_format to handle compression properly, which means that configuring inputs to functions has become overly obnoxious. As a result, I have taken the liberty to convert many functions to take some form of *_param. This offers users the flexibility to override only the fields they need, while leaving others untouched by leveraging designated initializers. Unfortunately, this has the undesired side effect of being the largest API break this library has had thus far. This issue stands as a forum for users to provide feedback on the new API changes: whether they like them/don't like them/think they could be better/etc.
For reference, the .ba2 format is described in detail here.

@Guekka Mentioning you on this issue, since I know you're waiting for me to implement Starfield support.

This looks good to me. I don't mind the API break
About the new API, it's good. I think that's exactly why designated initializers were introduced.
Are you sure zip should be the default for compression? I would use lz4 personally

The defaults are tuned for the first game that introduced the format. zlib compression was introduced in .ba2 v3 which is currently starfield only. v1 archives are compatible with starfield out of the box, so the defaults work for all games.

That makes sense

@Ryan-rsm-McKenzie So, I've finally updated CAO (beta) to use this version. Everything appears to work correctly. There's just one minor oddity: I do not see why chunk::decompress requires a compression_format. In my opinion, it would make more sense for it to be kept as internal state rather than putting the concern on the end user

Is there any reason for not always using lz4 with starfield?

@Ryan-rsm-McKenzie So, I've finally updated CAO (beta) to use this version. Everything appears to work correctly. There's just one minor oddity: I do not see why chunk::decompress requires a compression_format. In my opinion, it would make more sense for it to be kept as internal state rather than putting the concern on the end user

Individual chunks don't know whether they were compressed using zlib or lz4. This information is stored in the archive header, and you have to forward it along. Storing this information in the chunk could noticeably bloat an archive's in-memory size by several kb. Texture archives would be impacted the worst.

Is there any reason for not always using lz4 with starfield?

Technically the format permits compressing ba2 archives using lz4, but it's still not clear whether the game will actually load them correctly, or whether it assumes all general archives are compressed using zlib.

Some warnings with g++ (13)
bsa.log

Fixing this required a breaking change. I had to add an underscore after every conflicting name:
bsa::fo4::archive::meta_info{
  .format = bsa::fo4::format::general,
  .version = bsa::fo4::version::v1,
  .compression_format = bsa::fo4::compression_format::zip,
};
// ^^^ BEFORE / AFTER vvv
bsa::fo4::archive::meta_info{
  .format_ = bsa::fo4::format::general,
  .version_ = bsa::fo4::version::v1,
  .compression_format_ = bsa::fo4::compression_format::zip,
};

@Ryan-rsm-McKenzie I have now released CAO7 beta with starfield support. I think this branch can be merged 👍


Update CONTRIBUTING with Documentation

Pull Request Template
As per issue #537 - add to CONTRIBUTING.md a section for documentation
Description:
Add a section for documentation in CONTRIBUTING
Breaking Changes (if applicable):

List any breaking changes introduced by this PR.
Explain the rationale behind these changes and how they will impact users.

Additional Information:

Mention any relevant dependencies or external libraries used.
Include screenshots or code snippets (if necessary) to clarify the changes.

Checklist:

[x] I have formatted my code using  goimport  and  golangci-lint.
[x] All new code is covered by unit tests.
[x] This PR does not decrease the overall code coverage.
[x] I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

@aryanmehrotra - ready for another look

Ready for another review


Unable to send "id_token token" as one word to request expecting an array

Using latest (3.0.1) RestAssured, if I make a POST call using the method formParams and one of my request parameters is response_types (which allows multiple values) my value of id_token token gets send as two separate values in an array.
Here is what I'm sending, some of it might be generic values:
private static final String REDIRECT_URIS_KEY = "redirect_uris";
private static final String CLIENT_NAME_KEY = "client_name";
private static final String RESPONSE_TYPE_KEY = "response_types";

public static final String RESPONSE_TYPE_CODE = "code";
public static final String RESPONSE_TYPE_ID_TOKEN = "id_token";
public static final String RESPONSE_TYPE_ID_TOKEN_TOKEN = "id_token token";

Map<String, Object> requestParameters = new HashMap<>();
	requestParameters.put(REDIRECT_URIS_KEY, redirectUri);
	requestParameters.put(CLIENT_NAME_KEY, testName);
	requestParameters.put(RESPONSE_TYPE_KEY,
			Arrays.asList(RESPONSE_TYPE_ID_TOKEN_TOKEN));

Response response = RestAssured.given().formParams(requestParameters)
.and().contentType("application/json").when()
.post(MessageFormat.format(registrationUrl, testName)).peek();
This is what the server receives when I send a POST request using RestAssured.
response_types": [ "["id_token", "token"]" ] } when I intended it to be id_token token

Yes this is a known issue, see here. Work around is to not use a hashmap but rather specify each form parameter like this:
given().formParam(REDIRECT_URIS_KEY, redirectUri).formParam(CLIENT_NAME_KEY, testName).. ..

This still doesn't work when one of my parameters is multi-word, in my case "id_token token" it still sends it as two items "id_token", "token"

Hmm, are you saying that "id_token token" isn't URL encoded properly in the request?

The request ends up being:
1484845929.729 Init ===========================================
1484845929.729 HTTP request {
"endpoint": "registration",
"method": "POST"
}
1484845929.729 Request {
"name": "ClientRegistration"
}
1484845929.729 Request args redirect_uris=https%3A%2F%2Flocalhost%3A9031%2Fsp%2FeyJpc3MiOiJodHRwczpcL1wvcnAuY2VydGlmaWNhdGlvbi5vcGVuaWQubmV0OjgwODBcL3BpbmdmZWRlcmF0ZS5pZF90b2tlbi10b2tlblwvcnAtcmVzcG9uc2VfdHlwZS1pZF90b2tlbit0b2tlbiJ9%2Fcb.openid&client_name=rp-response_type-id_token%2Btoken_709490&response_types=id_token%20token
1484845929.73 RegistrationRequest {
"application_type": "web",
"client_name": "rp-response_type-id_token+token_709490",
"redirect_uris": [
"https://localhost:9031/sp/eyJpc3MiOiJodHRwczpcL1wvcnAuY2VydGlmaWNhdGlvbi5vcGVuaWQubmV0OjgwODBcL3BpbmdmZWRlcmF0ZS5pZF90b2tlbi10b2tlblwvcnAtcmVzcG9uc2VfdHlwZS1pZF90b2tlbit0b2tlbiJ9/cb.openid"
],
"response_types": [
"id_token",
"token"
]
}
RestAssured separated my id_token token request parameter which was supposed to be one value into two when it sent the request.

I was able to get it to work when I used the hash map of parameters in the body but not in the formParams part of the rest assured call, thanks for looking into it.


Namespace deletion stuck due to 1p finalisers

Your environment

Operator Version: 1password/onepassword-operator:1.0.1

Connect Server Version: 1password/connect-api:1.2.0

Kubernetes Version: v1.20.8-gke.900
What happened?

I had 3 deployments with secrets from the operator in a namespace. (using annotations)
I deleted the namespace which deleted everything i could find in the namespace
But the namespace itself is stuck due to: 'Some content in the namespace has finalizers remaining: onepassword.com/finalizer.secret in 3 resource instances'
What did you expect to happen?

The namespace to be deleted
Steps to reproduce

Notes & Logs

was able to clear it out using https://stackoverflow.com/questions/52369247/namespace-stuck-as-terminating-how-do-i-remove-it

Got the same issue, you can solve it via the following way:
kubectl edit <onepassword-item>
Remove the finalizer section.
kubectl edit <namespace>
Remove the finalizer section.
The issue should be gone.

Thanks @chfxr for the work around. Looks like some work needs to be done to ensure proper cleanup of resources

I was looking into that and unfortunately was not able to delete finalizers from the resources when deleting a namespace.
The reason why it stuck, is that the operator is removed first, and then the application is left with 1Password finalizer, and nothing can remove it.
There are several ways to mitigate it:

Remove all the resources first before deleting the namespace.
Remove finalizers manually by running kubectl edit <resource>.


More useful default lighting + remove alpha from lights

https://github.com/tangrams/tangram/pull/407

Fixed by https://github.com/tangrams/tangram-docs/commit/24ddb885209dae97041692512513177e89269fb8


[Misc]: Easier upgrade of Shuttle versions

Tooling for automating the upgrading of Shuttle CLI, libraries, and deployer.
Better warnings for when an upgrade is needed.

This issue is a part of the Product Feature Poll (all issues). React with :+1: if you want this feature. Comment if you have suggestions related to this feature.

The CLI now has an upgrade subcommand for self-upgrades.
The shuttle.dev API will also has a more explicit version checking system.


Reorganised tooling

There are
tools/docker
tools/install_deps
tools/release
tools/testing
tools/

tools/docs -> docs
which is way easier to reason about.

This pull request is too big. Let's split it.


Keypoint.draw_on_image() alpha arg & small changes to Polygon

Codecov Report

Merging #283 into master will decrease coverage by 0.01%.
The diff coverage is 92%.

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
- Coverage   94.02%   94.02%   -0.01%
==========================================
  Files          20       20
  Lines        8117     8138      +21
==========================================
+ Hits         7632     7651      +19
- Misses        485      487       +2


1.4.0-RC1: Bash shell will not echo after running sbt script

steps

Update build.properties to 1.4.0-RC1
Run sbt compile.
Once back at the shell prompt, run any other shell command, like ls.

problem

The shell will not echo characters typed at the shell prompt.
The shell does accept the characters and will run the command.
Hitting return will just repeat the prompt on the same line in the shell.

expectation
Shell prompt unharmed.
notes
Seems like #2963 is back. Running stty echo brings shell back to normal.

I see this behaviour as well,  but this sounds like a duplicate of the already-closed report at #5827?

Yea. It's a duplicate of https://github.com/sbt/sbt/issues/5827 for 1.4.0-RC1. Stay tuned for RC2.


Show change conditions button in support

Context
Show change conditions button in support even if the offer doesn't have conditions.

 Support: Show a 'change conditions' button even when there are no conditions

@tomas-stefano any chance of a quick screenshot?

@tomas-stefano any chance of a quick screenshot?

It will only show an empty row with the link.

@tomas-stefano any chance of a quick screenshot?

It will only show an empty row with the link.

Maybe we could add some text saying “No conditions added” to the middle column of the row?

No conditions adde

Done


Use device plugin image with release-v1 tag

fixes #92

Thanks for the fix! Yes, we should use release-v1 image.


Raw VM: (flat) network testing

[x] cross region GCE - GKE testing
[ ] cross region Bluemix testing
[ ]  vpn testing

This seems to be working - only pending work is checking on-prem, and double checking bluemix.

the vpn one I didn't get around to setup

@linsun is looking at bluemix setup for reachable podips

@linsun can you update

Raw VM flat testing. Did simple testing last week. MySQL running in VM on Bluemix. K8s in IBM cloud.
Most imp thing is to ping DNS and repos.  Costin and Lin to figure this out on hybrid slack

waiting for the deb file in the next release to try this.

@linsun @costinm @ldemailly  can you help test this out

ETA : today or tom

Need to add a patch. Need to try it with a real service.
costin and laurent to talk about this

@linsun @costinm @ldemailly do any of you know whats up with this?

I don’t know if lin was able to test or not sorry

we haven't been able to get flat networking working for us.  We'll have to document this as a limitation before we can sort that out in blue mix.

let's close this for now then.


[DONOTMERGE][WHITESPACE] workflow exercise

whitespace: do not merge. workflow exercise.

i'm training up a build engineer!

Can one of the admins verify this patch?

ok to test

Can one of the admins verify this patch?

ok to test

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34206/

Test build #129603 has finished for PR 29994 at commit 995d434.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129603/
Test PASSed.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34206/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34206/
Test PASSed.

test this please

Test build #131718 has started for PR 29994 at commit 995d434.

Test build #131718 has finished for PR 29994 at commit 995d434.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131718/

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36316/

test this please

Test build #131917 has started for PR 29994 at commit 995d434.

Test build #131917 has finished for PR 29994 at commit 995d434.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131917/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36514/

test this please
On Sat, Nov 28, 2020 at 5:18 PM UCB AMPLab<EMAIL_ADDRESS>wrote:

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36514/
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/apache/spark/pull/29994#issuecomment-735313911, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMIHLHH6YAMWBBXU6B7KPLSSGOOHANCNFSM4SKRWB4A
.

Test build #131958 has started for PR 29994 at commit 995d434.

Test build #131958 has finished for PR 29994 at commit 995d434.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/131958/

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36555/

test this please

Test build #132078 has started for PR 29994 at commit 995d434.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36677/

Test build #132078 has finished for PR 29994 at commit 995d434.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132078/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36677/

Build finished.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36677/

test this please

Test build #132161 has started for PR 29994 at commit 995d434.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36762/

Test build #132161 has finished for PR 29994 at commit 995d434.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132161/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36762/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36762/

Test this please
On Thu, Dec 3, 2020, 14:35 Apache Spark QA<EMAIL_ADDRESS>wrote:

Kubernetes integration test status failure
URL:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36762/
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/apache/spark/pull/29994#issuecomment-738386593, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMIHLBDZ3EMHKUWDZBVMT3STAHB3ANCNFSM4SKRWB4A
.

Test build #132399 has started for PR 29994 at commit 995d434.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36998/

Test build #132399 has finished for PR 29994 at commit 995d434.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132399/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36998/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36998/


Improper rendering when using First-Person Model

Describe the Bug
Extendo Grip, Creative Worldshaper and Potato Cannon have their GUI model/view model rendering while using the First-Person Model mod, causing them to appear twice. Engineer's Goggles render while using First-Person Model, causing them to appear from first-person while using the first person model in certain contexts (most notably, looking down. There may be other situations i haven't observed where this happens)
Reproduction Steps

Use Create and First Person Model together
Hold a Potato Cannon, Creative Worldshaper or Extendo Grip or equip a pair of Engineer's Goggles
Look downwards (or in other directions, haven't tried looking in other ways) for the Engineer's Goggles bug to occur; as mentioned before, the handheld items simply render as normal without disappearing when first-person model is active

Expected Result
The expected result was no rendering of aforementioned elements while using First-Person Model
Screenshots and Videos

Crash Report or Log
No response
Operating System
Windows 11
Mod Version
0.5.1d
Minecraft Version
1.20.1
Other Mods
First-Person Model, Create
Additional Context
No response

Same issue here

duplicate of #905


Code Generation failed on cookies with no expiration time set

Describe the bug
Code Generation failed when a request has cookies with no expiration time set.
To Reproduce

Get any existing request or create a new one
Click on "Cookie" -> "Manage Cookies"
Create a new cookie or modify an existing one. Set "Expires" to an empty string. For example: "foo=bar; Expires=null; Domain=typicode.com; Path=/"
Request -> Generate Code (Shift+Ctrl+G). "Generate Client Code" modal shows no code. Dev tools shows an error in a Console tab.

Expected behavior
A generated client code.
Screenshots

Desktop:

OS: Ubuntu 20.04
Installation Method: snap
App Version: 2020.5.2 2020-12-09

Same happens on :
OS: OSX BigSur
App Version 2021.1.1

Oh, interesting! This is related to #2908, and while that fix was included in the 2021.1 release, it doesn't apply any input validation preventing users from clearing the expiry field.

@matperez in my case code gen works with expiry set to null, can you check if it's fixed in the latest release?


Duplicated tags with ssr

Describe the bug
I have a website with ssr. On each +page.svelte I have a . On dev it's working fine. If I build and run on prod - I have duplicated tags
This is is how every +page.svelte looks like:
import {LL, locale} from "./../i18n/i18n-svelte"

<<<< body>>>>

<MetaTags
	title="{$LL.pageTitle.main()}"
	description="{$LL.pageDescription.main()}"
	languageAlternates="{getHeadLinks($page.url.pathname, $locale).alternate}"
	canonical="{`https://mywebsite.com/${$locale}${removeLocaleFromPath(
		$page.url.pathname,
		$locale
	)}`}"
/>

** FUNCTIONS**

let LOCALES = ["de", "en"]; // IMPORANT ADD NEW LANG
export const getHeadLinks = (url: string, locale: string) => {
	url = removeLocaleFromPath(url, locale);
	let alternate = [
		{ hrefLang: "x-default", href: `https://mywebsite.com/${url}` },
		{ hrefLang: "de", href: `https://mywebsite.com/de${url}` },
		{ hrefLang: "en", href: `https://mywebsite.com/en${url}` }
	];
	return { alternate: alternate };
};

export const removeLocaleFromPath = (path: string, locale: string) => {
	for (let i = 0; i < LOCALES.length; i++) {
		path = path.replace(`/${LOCALES[i]}/`, "/");
	}
	for (let i = 0; i < LOCALES.length; i++) {
		if (path === `/${LOCALES[i]}`) {
			path = "";
		}
	}
	return path;
};

If I run the build with js turned off - there is only one instance of meta tag. Tho if I turn it on - the second one appears. When I goto anotherpage one instance of metatag changes its urls, and the other doesn't. So seems like the metatags injected 2 times - on server side and on client side. How do I turn it off ?

Perhaps this is not a bug in svelte-meta-tags.
I don't know the details, but I think it is a bug in Svelte or SvelteKit, so I suggest you create an issue there.


Add onboarding Tour for the userinterface

Add an onboarding Tool to explain all important parts of the UI to new users

closed via #48


Fix: db_volume_delete

Fixes #73
Fix db_volume_delete() function, by changing type parameter of db_volume_action() call to files.

Thanks! can you also:

Increment version number to 0.2.6
add a note to NEWS.md for version 0.2.6

Then I'll give it a test

Thanks!


boost: Migrated to Manifest V3

Made minor changes to migrate Holodex Plus from manifest v2 to v3.
Should works on both Firefox and Chrome.

LGTM but need to polish some of these


KAFKA-4161: KIP-89: Allow sink connectors to decouple flush and offset commit

@ewencp for review

@ewencp updated as per feedback

LGTM, thanks!


🐛 Unable to Dismiss Numeric Keyboard: React Native

With no keyboard dismissal on outside touch built into the core UI, situations like this arise, where the user is unable to dismiss the numeric keyboard without tapping into another input and hitting "Return":

A simple solution to this is outlined here. It boils down to wrapping the UI in a TouchableWithoutFeedback with the prop onPress={Keyboard.dismiss}. For example, the showComponent functions used by the components in  aws-amplify/packages/aws-amplify-react-native/src/Auth could use this component to wrap the returned View. Styles from the Theme would still apply as desired.
If there is a way to implement this without overwriting all the UI components, I apologize for this issue. But, at the moment I see no such solution.

Closing as this is fixed in #530


Automatic pull requests to default branch of touched repository

Is your feature request related to a problem? Please describe.
Some of the repos we would like to keep in sync customize the workflows to a small extent.
It would be nice to keep the customizability but have a common basis that is up to date.
Describe the solution you'd like
It would be cool if the sync could open PRs upon pushing the workflow files to a specified branch
Describe alternatives you've considered
Currently, we bypass the problem by having a workflow inside the target repo that creates the PR upon pushes to the "workflow-sync" branch
Does that make sense to you?

@flxw
so what I understood is that you want this action to auto create a new pull request if any changes are found instead of pushing it directly right ?

Exactly, I think it would be useful if the changes could be pushed to a separate branch and then have a PR created towards the default branch. This way it is possible to keep customization while still having a "base in sync":

Action creates new branch, pushes changes
Action creates PR from new branch to default branch

It's possible with other means as I described but I think it could be a useful addition

@flxw thanks for the clarification.

@flxw based on your request i fully redeveloped this action from scrach .
the new version is faster compared to the current stable version and also includes 2 new features.

Option to push changes as a pull request
Copy file if not already exists in remote repository.

The new version is still in beta and you can give it a try by chaning the action's source branch to nodejs-fullrework
make sure to set PULL_REQUEST key to true if you want to push chages as pull request
      - name: Running Workflow Sync
        uses: varunsridharan/action-github-workflow-sync@main
        with:
+         PULL_REQUEST: true

And for the new file copy feature all you need to do is add ! before the = like below
WORKFLOW_FILES: |
  file1yml=file1.yml
  file2yml!=file2.yml

in the above config file1.yml will get overriten every time the action is triggered for that repo. but the file file2 will only be copied once if the file not eixsts.
please do give it a try and provide your feedback.


feat: unify upload form building

This PR introduces structs that are eerily similar to #300 , with the main difference being that the bulk of the changes target the publish process, since that's where the multipart form needs to be built. Hopefully it is clear how this can be extended to add KV Namespaces as Bindings. If it is not, feedback is appreciated!
Further work could be done to make the job of building the Assets to be the responsibility of the Project struct, but this is already pretty big. The best thing happening here is that the form is being built based on the Project, (type for now), which leaves room for that info to come from project config (i.e. project.kv_namespaces).
Steps taken:

WranglerJS build step no longer writes metadata.json file
Publish step no longer looks for metadata.json file in the filesystem (another "breaking" change)
Publish step generates form data based on Project
Data structures representing the parts of a Project we want to upload (Assets and its children), and how to translate them into the different parts of a Form (Files and Bindings).
all project types call the same form building logic, "assets" are configured per project.

the To<Type> pattern in here smells of a reimplementation of https://doc.rust-lang.org/std/convert/trait.Into.html that clones for you. I don't love this pattern as it is hiding clones behind a function call, and I wonder if having a top level type to represent a resource, and a binding type that implements From<Resource> with options in the necessary places would be better. Not necessarily reimplementing pull/#313, but just taking those parts from it.

what's tricky about the From trait is that it consumes the first resource, but in the case of wasm modules i actually need two things: a file and a binding. perhaps the wording "ToThing" is misleading? and/or the trait is overkill and we could just duck type? 🤷♀

rebased onto master. no merge conflicts.