I have a question.

I'm confused. Why are you using playwright? Is it because of Cloudflare? If so, you can simply bypass it so people don't have to install playwright. It's not difficult, and I do it all the time, lol.

Character uses a V2 cloudflare challenge, which requires JS, cookies

Character uses a V2 cloudflare challenge, which requires JS, cookies

I bypassed it without using either of those.

Mhm, sending a post request that's bypassed? With what?

Mhm, sending a post request that's bypassed? With what?

Yeah, have you ever heard of tls_client? Well, try it out next time before talking. It literally bypasses Character.AI's Cloudflare.

The day before yesterday I was able to bypass cloudflare using tls_client. The library is almost ready, today or tomorrow I will post an update

@st4rted Looks like no, i'm gonna check it out, thanks

The day before yesterday I was able to bypass cloudflare using tls_client. The library is almost ready, today or tomorrow I will post an update without Playwright

I pretty much already finished a version without playwright.

fixed on v0.8.0


Node detection broken in version 1.3.4

I updated to version 1.3.4 and it seems that the following basic behavior does not work anymore.
example code:
var platform = require('platform');

console.log(platform.name);
console.log(platform.version);

output:
null
null

Output of the same code with platform version 1.3.3:
Node.js
7.8.0

Nodejs-version:  7.6.0

To say that nothing works is an exaggeration. More accurately the Node detection doesn't work.

Yes you are right. I'm sorry for that.
Edited the issue

https://github.com/bestiejs/platform.js/commit/1218b048d6895c1f6da447d57ebb2c6239384e48
breaks this.
versions is :  { http_parser: '2.7.0',
  node: '7.9.0',
  v8: '5.5.372.43',
  uv: '1.11.0',
  zlib: '1.2.11',
  ares: '1.10.1-DEV',
  modules: '51',
  openssl: '1.0.2k',
  icu: '58.2',
  unicode: '9.0',
  cldr: '30.0.3',
  tz: '2016j' }

no nw or electron so it needs an 'else { } ' do the same old thing... (which is the else of if( typeof data.versions is object) )

Moved to #130.


Autostart Cassandra from Priam

I took a whack at having Priam auto-remediate a dead Cassandra. By default the starts are limited to once per hour.
I'm not sure the best way to test this, I tried testing it with Mocks but the rate limiter makes it tough to reliably test (threads, time, etc ...). Do we have a better way to do functional tests?

3.11 PR @ #630


Redo go mod -u for anything with a dep that has updated

kimono could update anything in the mono repo that has a dep on a package that just had its version bumped bumping those deps as well.

please assign to me


Server configuration

Defines Configuration class for the server
config can be changed in dolphin.properties file
Default values for properties

This change is

Coverage increased (+0.9%) to 25.08% when pulling 777f007569484107517c4e3ad61fda8792bc9f95 on server-configuration into 87c87e4c0cde75d0631ddabe1cfde5a50c56c261 on master.

Reviewed 9 of 9 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Add spatial network

Would be useful for teaching examples if nothing else! Can adapt from SimpleABM

Duplicate of #338


Opening file when no tab is open also opens the last file opened, in a temporary tab

Hello. The title might be confusing, so I will present the reproduction steps :
• open Visual Studio with the extension installed
• open any solution which contains at least 2 files
• open some file A using the extension's open file dialog
• close file A (ensure there are no tabs open)
• open some file B (different from A) in the same way as A
• notice as file B is opened in a regular tab, but then focus is switched right away to a temporary tab with file A (the last file opened)
This happens with the current latest version (1.14.0). Also (which might be useful to know) the focus after opening a file is on the file name in solution explorer (if it is visible), not on the newly opened tab (apparently only when opening a tab from a state where no tab is open).

Thanks for the report, I'll try to find some time to look into it.

I'm not seeing the temporary tab problem, but I am seeing the focus problem. I'll see if I can fix the focus issue and maybe that'll also fix your temporary tab issue.

I've reverted the change that fixed this issue because it was causing several other problems (see #8). I'm not sure what to do about this now.


Running Grunt is not changing the old query string in index.html

I am using the query string mechanism to bust the cache. Following is the snippet in my gruntFile.js
cacheBust: {
            taskName: {
                options: {
                    assets: ['app/**', 'assets/css/*', 'js/*', 'build/*', 'bower_components/**'],
                    queryString : true
                },
                src: ['index.html']
            }
        }

For the first time, when i run grunt then the query string is attached to each scource files in script tag like,
<script src="bower_components/jquery/dist/jquery.min.js?4a356126b9573eb7"></script>
*But, if I run grunt again, the query string is not changed. *

I'm assuming you are using the latest version?
Have a read through the discussion in #180 - should give you some insight as to why

I have the same issue. As you suggested in #180, I clean the target directory, copy the files and then process them, but when the files already have a hash in the name, the index file is not updated at all and points to non-existing files. Only when I remove the hash part, i.e.
style.34f39e34ac32.css -> style.css
the file is correctly updated with the new hash.
Settings are:
cacheBust: {
  taskName: {
    options: {
      assets: [
        'dist/css/*.css',
        'dist/js/*.js'
      ]
    },
    src: ['index.html']
  }
}

This is expected behaviour. The reason for copying your source files to another directory to do the processing is that the source files stay intact and are modified with the hashed value.
<!-- src/index.html -->
<link rel="stylesheet" href="style.css">

copy files to `dist/` folder and run the cache bust task

<!-- dist/index.html -->
<link rel="stylesheet" href="style.34f39e34ac32.css">

The dist/index.html file is the one that should be deployed to your production environment. It should not be copied back to the src/ folder. This way, on the next build/deployment, it will be changing the style.css file to style.34f39e34ac32.css again

That makes sense. I was expecting it to change the index file in place. Sorry and thanks for your time.

I am using grunt build to create the dist folder to be deployed.
Gruntfile file has following code
cacheBust: {            taskName: {             options: {                 assets: ['dist/client/app/vendor.js']             },             src: ['dist/client/index.html']         }     }
The vendor file gets copied and renamed vendor.0535875986f49276.js but the html file still points to vendor.js
<script src="app/vendor.js"></script>
What am I doing wrong?

Hi @flaurian, looks like you're missing the baseDir option. The file path shown in the output of your task should be something along the lines of:
Busted: dist/client/app/vendor.0535875986f49276.js

This means it will try to replace any reference of dist/client/app/vendor.js with dist/client/app/vendor.0535875986f49276.js, but from the snippet you've provided, the reference is app/vendor.js.
What we need to do is remove the dist/clients prefix from the references which can be done by setting a baseDir.
cacheBust: {
    taskName: {
        options: {
            baseDir: 'dist/client/',
            assets: ['app/vendor.js']
        },
        src: ['dist/client/index.html']
    }
}

This will mean that all references to assets are relative to the dist/client/ path

Thanks a lot for your quick reply.
It works like a charm!

Can grunt-cache-bust take source index.chtml instead of  index.html. Previously it does not seems to work.


running profile program

The profile command is unable to identify non-existent files and outputs an empty file with filename suffixed with [OPTION].  For instance, consider a fictitious file, foo.txt .
./profile config.toml foo.txt --stem
outputs
Running stemming algorithm  -> file saved as foo.stems.txt

I suppose it would be reasonable to check if the file exists. You can do this with a call to filesystem::file_exists() at the beginning of main. If you'd like to make a pull request I will merge it.

Hi @domarps, if you don't want to make the change I will take care of it and we can have it out in v2.0.1.


geoip update broken

Code of Conduct

[X] I agree to follow this project's Code of Conduct.

Submission validity

[X] This is not a personal support request, that should be posted on discussions community.
[X] I checked current issues and this request isn't a duplicate of an existing issue, opened or closed.

Self troubleshooting

[X] I've read the documentation and made sure to follow it.
[X] I've read the troubleshooting first steps and frequent issues guides.

Version
v 1.9.2
Description
gz geofile file empty error:
sudo php /var/www/yourls/user/plugins/geoip-update/cron.php

PHP Fatal error:  Uncaught UnexpectedValueException: internal corruption of phar "/var/www/yourls/user/plugins/geoip-update/GeoLite2-Country.tar.gz" (truncated entry) in /var/www/yourls/user/plugins/geoip-update/vendor/tronovav/geoip2-update/src/Client.php:315
Stack trace:
#0 /var/www/yourls/user/plugins/geoip-update/vendor/tronovav/geoip2-update/src/Client.php(315): PharData->__construct()
#1 /var/www/yourls/user/plugins/geoip-update/vendor/tronovav/geoip2-update/src/Client.php(186): tronovav\GeoIP2Update\Client->extract()
#2 /var/www/yourls/user/plugins/geoip-update/vendor/tronovav/geoip2-update/src/Client.php(113): tronovav\GeoIP2Update\Client->updateEdition()
#3 /var/www/yourls/user/plugins/geoip-update/run.php(26): tronovav\GeoIP2Update\Client->run()
#4 /var/www/yourls/user/plugins/geoip-update/cron.php(6): ozh_yourls_geoip2_update_client_run()
#5 {main}
  thrown in /var/www/yourls/user/plugins/geoip-update/vendor/tronovav/geoip2-update/src/Client.php on line 315

/var/www/yourls/user/plugins/geoip-update] #
-rw-r--r--  1 www-data www-data    0 May  2 07:47 GeoLite2-Country.tar.gz

Also updating via admin interface not working
Expectation
No response
Reproduction steps
No response
Context
No response

cat cron.php
// https://github.com/ozh/yourls-geoip-update/issues/2

-rw-r--r-- 1 www-data www-data 6455950 Apr 25 04:47 GeoLite2-Country.mmdb
-rw-r--r-- 1 www-data www-data      10 Apr 25 04:47 last-modified.txt
stopped working Apr 25

@un99known99 April 25 is almost exactly 2 years after your issue https://github.com/ozh/yourls-geoip-update/issues/2.
Are you sure your Maxmid private key is not just expired?

@LeoColomb  already tried that, requested new one - same ....

Did you also try to delete the file /var/www/yourls/user/plugins/geoip-update/GeoLite2-Country.tar.gz after you rotated the key?

@LeoColomb  yes, it is not there
root@pi[/var/www/yourls/user/plugins/geoip-update] # ll GeoLite2-Country.tar.gz
ls: cannot access 'GeoLite2-Country.tar.gz': No such file or directory

Ref https://github.com/tronovav/geoip2-update/issues/14

Closing in favor of:

https://github.com/tronovav/geoip2-update/issues/14
https://github.com/ozh/yourls-geoip-update/pull/8


Global configs and env files

A lot of configuration can be stored in a .env file to make the code a lot more flexible to different environments. Goal of this issue is to have a PR that sets up

a .env.example file with the possible values
a script that parses the .env and exposes a global configs object that other files can import to get the configs from the .env

Issue closed in #9


[New game]: Car racing

🎮 Game Request
Game logic and basic description
It is a 3D racing game using HTML, CSS, and
JavaScript. It sets up event listeners for keyboard input, initializes game variables and objects, and updates the game state in a loop. The game involves driving a car on a road,avoiding obstacles and other cars, and trying to complete laps as quickly as possible. The code also includes functionality for displaying a high score table and playing sound effects.
The code sets the background color, font family, and height of the body. It also defines the styles for the top UI elements such as the time, score, and lap counters. Additionally, it sets the styles for the tachometer at the bottom of the screen.
It has all the styles for a game interface, including the positioning and appearance of various elements such as the road, hero character, clouds, and high score display. It also includes animations for blinking text and transitions for opacity and timing.
Point down the features
It has all the styles for a game interface, including the positioning and appearance of various elements such as the road, hero character, clouds, and high score display. It also includes animations for blinking text and transitions for opacity and timing.
Select program in which you are contributing
No response
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

I have a great interest in games also. Assign this issue to me. I will try my best and build it as soon as possible.

Hey @Arnabhit  ! Thank you for raising an issue 💗 You have been assigned this issue you can start working on the issue 🎮

Sir have to assigned the issue to @Arnabhit.

Hey @Arnabhit ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Ultra Low Power deepsleep

Added Ultra Low Power mode (30uA sleep mode)
Wake by LoRa module, avoid watchdog wake every 8s
Added new method to read battery voltage, needed if VCC<2.5V
Updated documentation
Bug fix with button wake
Press button more than 2s to enable 1minute window to upload new sketch when in deepsleep

@johanstokking you want me to remove any use of printf, sprintf and snprintf, correct?

Requested changes are done

@hallard we try to keep dynamic memory allocations to a minimum, at least that's a goal!

removing printf is not a bad idea, I think it also save same pgm space (as soon as it's not used anywhere else in any lib)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Metadata widget: new code snippet tool tip is missing

1.0.0 rc0

Hover over + in code snippet widget:

vs

Hover over + in file browser:

Nice catch, we must have forgotten to add a tooltip for that button
@marthacryan this should be a quick fix?


Generate typescript declaration file.

Exposed functionality has jsdoc
Typescript generates declaration file from jsdoc for index.js
lib/index.d.ts is tracked as it's now part of contract for exported functionality and helps spotting changes to the contract.

Declarations are are not built as part of build script due to limited knowledge of yarn, as well as  leaving it to your choice if preferred to be part of build.

It appears I'm unable to run lint/formatting locally. No files found wiht the '**/.' glob. On windows

It appears I'm unable to run lint/formatting locally. No files found wiht the '**/.' glob. On windows

Argh sorry I am not using Windows, I wonder if there's a way to have a similar feature, did you find one?

@vvo @gregberge Removed the build generation for declaration and added a one manually. Works on my machine :D

Hey this was merged here: https://github.com/vvo/next-iron-session/pull/95
The commit comes from you, I had to fix the typings, I have no idea why I can't edit pull requests from contributors :D


fix up qkv.bias error when use qwen1.5-32b-gptq-int4

Thank you for the report. Could you share the model link to reproduce the issue?

Thank you for the report. Could you share the model link to reproduce the issue?

model link

Thank you for the sharing. I can reproduce the issue on the model, will fix it soon.

Hi @Tlntin, thanks for your contributing. We've merged your contribution into code base and will add you into contributor list.


python311Packages.vulture: 2.10 -> 2.11

Changelog: https://github.com/jendrikseipp/vulture/releases/tag/v2.11
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 282725 run on x86_64-linux 1

3 packages failed to build:

activitywatch
prospector
prospector.dist

94 packages built:

aw-watcher-afk
aw-watcher-afk.dist
bitwarden-menu
bitwarden-menu.dist
buku
buku.dist
cmake-format
cmake-format.dist
conan
conan.dist
cve-bin-tool
cve-bin-tool.dist
emacsPackages.python-isort
flitter
isort (python311Packages.isort)
isort.dist (python311Packages.isort.dist)
keepmenu
keepmenu.dist
nbqa
nbqa.dist
pokete
pylint (python311Packages.pylint)
pylint.dist (python311Packages.pylint.dist)
python311Packages.aiogithubapi
python311Packages.aiogithubapi.dist
python311Packages.avro-python3
python311Packages.avro-python3.dist
python311Packages.betterproto
python311Packages.betterproto.dist
python311Packages.diff-cover
python311Packages.diff-cover.dist
python311Packages.dragonfly
python311Packages.dragonfly.dist
python311Packages.flake8-import-order
python311Packages.flake8-import-order.dist
python311Packages.mypy-boto3-builder
python311Packages.mypy-boto3-builder.dist
python311Packages.pipdeptree
python311Packages.pipdeptree.dist
python311Packages.pylama
python311Packages.pylama.dist
python311Packages.pylint-celery
python311Packages.pylint-celery.dist
python311Packages.pylint-django
python311Packages.pylint-django.dist
python311Packages.pylint-flask
python311Packages.pylint-flask.dist
python311Packages.pylint-plugin-utils
python311Packages.pylint-plugin-utils.dist
python311Packages.pyls-flake8
python311Packages.pyls-flake8.dist
python311Packages.pyls-isort
python311Packages.pyls-isort.dist
python311Packages.pyls-memestra
python311Packages.pyls-memestra.dist
python311Packages.pyls-spyder
python311Packages.pyls-spyder.dist
python311Packages.pylsp-mypy
python311Packages.pylsp-mypy.dist
python311Packages.pylsp-rope
python311Packages.pylsp-rope.dist
python311Packages.pynput
python311Packages.pynput.dist
python311Packages.pytest-isort
python311Packages.pytest-isort.dist
python311Packages.pytest-pylint
python311Packages.pytest-pylint.dist
python311Packages.python-lsp-black
python311Packages.python-lsp-black.dist
python311Packages.python-lsp-ruff
python311Packages.python-lsp-ruff.dist
python311Packages.python-lsp-server
python311Packages.python-lsp-server.dist
python311Packages.setuptools-lint
python311Packages.setuptools-lint.dist
python311Packages.sigstore
python311Packages.sigstore-protobuf-specs
python311Packages.sigstore-protobuf-specs.dist
python311Packages.sigstore.dist
spyder (python311Packages.spyder)
spyder.dist (python311Packages.spyder.dist)
python311Packages.vulture
python311Packages.vulture.dist
remarkable-mouse
remarkable-mouse.dist
sqlfluff
sqlfluff.dist
streamdeck-ui
streamdeck-ui.dist
thonny
thonny.dist
todoman
todoman.dist
vimPlugins.vim-isort


My old project

I did a project for Minecraft Server in C# last year, but discontinued for time reason.
I upload it to Github just now, wondering if my code could help a little bit.
https://github.com/aianlinb/MCServerSharp
This project has a low level of completion and is not yet functioning properly.

Your project needs work, too.

It is using System.Drawing.Common, which is not cross-platform anymore.
https://docs.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/6.0/system-drawing-common-windows-only
--> Needs conversion to ImageSharp.

It is using PInvoke & AllowUnsafeBlocks for Kernel32 for example.
--> Needs extraction into Win32 class library, maybe find Linux and/or Mac equivalents.

It is not licensed clearly.
--> Needs explicit inclusion of a LICENSE file for MIT, preferably.

@xafero Done https://github.com/aianlinb/MCServerSharp/commit/5928cb8179841e2f2de3bf5ae8ef88d75fca8cb1
By the way, I just thought maybe it has part of the code that can provide reference or help, no plans to keep working on it.


Live

Docs Build status updates of commit 8bb162c:
:clock10: Pending: waiting for processors (12 builds ahead of you)
:warning: Docs Build is busy, currently there are 12 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 8bb162c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

windows-iotcore/develop-your-app/IoTCoreShell.md
:white_check_mark:Succeeded

windows-iotcore/learn-about-hardware/SoCsAndCustomBoards.md
:white_check_mark:Succeeded

windows-iotcore/windows-iot-enterprise.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Feature request: Add AES-GCM-SIV

AES-GCM-SIV offers an alternative to AES-GCM with improved nonce collision resistance, thus making it more suitable for AEAD scenarios where a random nonce is used than existing solutions such as AES-GCM.

I second this request.
From cryptographic point of view AES-GCM-SIV is much stronger/safer than AES-GCM.
Please add it.

This is now added to the lightweight API in the current beta at https://www.bouncycastle.org/betas

Thank you!
Looking forward to seeing it in the bcprov-ext.
P.S. "Improved nonce collision resistance" here means the difference between catastrophic failure if one collision occurs, and ability to reuse nonce values (practically) at will.

This is now also added as GCM-SIV in the latest beta for the JCE provider as well. See https://www.bouncycastle.org/betas for details.

I must say - thank you!

And thank you!

Thank you

A big thank you from my side as well.

Hi, sorry to raise this issue from the dead, but what is the algorithm identifier for AES-SIV? I've tried AES-GCM-SIV, AES-SIV, GCM-SIV etc to no avail. Each time I get
java.security.NoSuchAlgorithmException: No such algorithm: GCM-SIV


mediaType & content aren't required here

https://github.com/tumblbug/gatsby-source-workable/blob/17cb421e25c1b2ba6deecf0f7bee43f03d083081/src/gatsby-node.js#L25
You only add them when indicating to transformer plugins that there is raw content that they can transform.
Otherwise this looks great!

Thank for you for the feedback! :) I've removed the unnecessary mediaType.


How to set transparent SLKTextInputbar?

Hello, I set the clear background color for SLKTextInputbar but not work.
self.textInputbar.backgroundColor = [UIColor clearColor];
[self.textInputbar setBackgroundImage:[UIImage new] forToolbarPosition:UIToolbarPositionAny barMetrics:UIBarMetricsDefault];
self.textInputbar.translucent = NO;
Is anything I missing?
Thanks in advanced.

Answer my question by myself, set translucent to YES will solve this issue.
self.textInputbar.translucent = YES;


Extend rename transform to skip primitives

Is your feature request related to a problem? Please describe.
When using a number of different data sources, its nice to have a consistent name pattern between types under 1 source. Sometimes this can be handled by the prefix transform, but often you may want slightly more specific control
Describe the solution you'd like
Along side config value useRegExpForTypes, have a skipPrimitives key.
This can either be true, to skip all or an array to define the exact primitives to skip when renaming.
Example
transforms:
      - rename:
          mode: bare
          renames:
            - from:
                type: (.*)
              to:
                type: Banana$1
              useRegExpForTypes: true
              skipPrimitives: false
      - prefix:
          mode: bare
          value: v1_
          includeRootOperations: true

Which would result in
type Query {
  v1_user: v1_BananaUserProfile
}

type v1_BananaUserProfile {
  id: String!
}

In this above case, using the prefix plugin alone with value: v1_Banana would result in query v1_Bananauser which we dont want
Describe alternatives you've considered
Adding more configurability to prefix transform, or a stand alone plugin. Both I think arnt as nice as this option in the rename plugin.
Additional context

@ardatan, @gilgardosh, this sounds like a good enhancement to me.
Let us know your thoughts, I'd be happy to raise a PR if you are like this functionality.

Turned out the issue here was that wrap version of the transform had a bit more logic added to make sure default Scalar types are not renamed; but this was not applied to bare mode. This behaviour is applied by default without config.
The PR below fixes these issues, hence this ticket can be closed:
https://github.com/Urigo/graphql-mesh/pull/4693

Available in the latest release!


fix: maintain backward compatibility for asymmetric JWTs

What kind of change does this PR introduce?

Use the original value of GOTRUE_JWT_SECRET - no need to check for base64 decoding.
Don't include the kid claim if the kid is an empty string

What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

1 of 4 (25.0%)  changed or added relevant lines in 2 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 58.219%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/conf/configuration.go
0
1
0.0%

internal/api/token.go
1
3
33.33%

Files with Coverage Reduction
New Missed Lines
%

internal/conf/configuration.go
4
71.58%

Totals

Change from base Build<PHONE_NUMBER>7:
-0.02%

Covered Lines:
9162

Relevant Lines:
15737

💛  - Coveralls


pickling models with a PlainSerializer Annotated field

Initial Checks

[X] I confirm that I'm using Pydantic V2

Description
hi there,
i am struggling to pickle a model which has a PlainSerializer Annotated field. I'm using below snippet in a FastAPI app and want to use PlainSerializer to return JSONMaybeSecretStr field secret values to the frontend when models are serialised to JSON. We also perform some pickling of models in the backend.
thanks!
Example Code
import os
import pickle

from pydantic import BaseModel, SecretStr

from typing_extensions import Annotated
from pydantic.functional_serializers import PlainSerializer, WrapSerializer

class MaybeSecretStr(SecretStr):
    def _display(self) -> str:
        if os.getenv("SHOULD_LOG_SECRETS"):
            return self.get_secret_value()
        else:
            return super()._display()

# # get secret value when serialise to JSON - simplifies returning these fields from routes back to FE
JSONMaybeSecretStr = Annotated[
    MaybeSecretStr, PlainSerializer(lambda x: x.get_secret_value(), return_type=str, when_used="json")
]

class Model(BaseModel):
    field: JSONMaybeSecretStr

instance = Model(field=JSONMaybeSecretStr("super secret value"))

pickle.dumps(instance)  # raises _pickle.PicklingError: Can't pickle <function <lambda> at 0x000001BB8BA43E20>: attribute lookup <lambda> on __main__ failed

Python, Pydantic & OS Version
pydantic version: 2.6.0
        pydantic-core version: 2.16.1
          pydantic-core build: profile=release pgo=true
                 install path: C:\Users\hughesa\Miniconda3\envs\genie_py310\Lib\site-packages\pydantic
               python version: 3.10.13 | packaged by conda-forge | (main, Dec 23 2023, 15:27:34) [MSC v.1937 64 bit (AMD64)]
                     platform: Windows-10-10.0.22621-SP0
             related packages: email-validator-2.1.0.post1 fastapi-0.103.1 pydantic-settings-2.1.0 typing_extensions-4.9.0
                       commit: unknown

Try not to use lambda when using pickle. See this similar issue https://github.com/scikit-learn/scikit-learn/issues/9467

@aleks-sch,
Indeed, as @andresliszt suggested (thanks!), you can avoid using the lambda function in order to successfully pickle your instance:
import os
import pickle

from pydantic import BaseModel, SecretStr

from typing_extensions import Annotated
from pydantic.functional_serializers import PlainSerializer, WrapSerializer

class MaybeSecretStr(SecretStr):
    def _display(self) -> str:
        if os.getenv("SHOULD_LOG_SECRETS"):
            return self.get_secret_value()
        else:
            return super()._display()

def serializer(x: MaybeSecretStr) -> str:
    return x.get_secret_value()

# # get secret value when serialise to JSON - simplifies returning these fields from routes back to FE
JSONMaybeSecretStr = Annotated[
    MaybeSecretStr, PlainSerializer(serializer, return_type=str, when_used="json")
]

class Model(BaseModel):
    field: JSONMaybeSecretStr

instance = Model(field=JSONMaybeSecretStr("super secret value"))

dumped_data = pickle.dumps(instance)
loaded_instance = pickle.loads(dumped_data)
print(loaded_instance.field.get_secret_value())
#> super secret value

:slaps forehead: thanks guys! really should have read the error message more closely!
and sorry my first time upgrading from v1 to v2 and thought maybe a limitation of PlainSerializer or something


 may duplicate items.

Describe the bug
In a very simple case, items (single number in item view) get duplicated. Adding {" "} to item view removes duplication.
Leptos Dependencies
leptos = { git = "https://github.com/leptos-rs/leptos", features = ["serde", "nightly"] }
leptos_axum = { git = "https://github.com/leptos-rs/leptos", optional = true }
leptos_meta = { git = "https://github.com/leptos-rs/leptos", features = ["nightly"]}
leptos_router = { git = "https://github.com/leptos-rs/leptos", features = ["nightly"] }

To Reproduce
#[component]
pub fn TestComp(
    cx: Scope,
) -> impl IntoView {
    let (vector, _) = create_signal(cx, vec![0, 1]);
    view! {cx,
        <For
            each=vector
            key=|item| *item
            view=move |_cx, item| view!{cx,
                {item}
                // {" "} // adding this cures duplication
            }
        />
    }
}

Expected behavior
no duplication

Yes. Enclosing item in a div also fixes the behaviour.

This should be fixed by #1281. Just FWIW you can simplify a bunch:
view=move |_cx, item| view!{cx,
    {item}
}

is the same as
view=move |_cx, item| item


Sanitize crash logs

Task/Issue URL: https://app.asana.com/0/488551667048375/1206797327447163/f
Description
See asana task
Steps to test this PR
Code review and unit tests

#4275  👈
develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @aitorvs and the rest of your teammates on  Graphite


Runnin predict without cityscape

First, thanks for the new update.
I do not have access to Cityscape, how can I use the pre trained models on other images?
Not sure how to transform pics and how to input them to the net properly.
thanks
Tets

Hey,
You can feed any image into the network as follows:

Load the image into an RGB numpy tensor
Rescale the intensity values to [0, 1]
Make sure that the channel ordering is RGB and not BGR (opencv standard)
Reshape and dimshuffle the tensor to [1, 3, H, W] where H and W are the image height (rows) and width (cols), respectively.
Feed the tensor into the network.

Would it be possible to post an example of code. For passing a image for prediction.
    val, image =  read standard image RGB.
    predictions, loss = val_fn(??,??)

Hi @TobyPDE!
I tried to follow the steps you mentioned here but the predictions only get 2 classes (related with light pink and black colors).

I also printed the outout prediction matrix and, from what I understood, it should paint the segmented image with another colors.
[[[2 2 2 ..., 3 2 3]
  [2 2 2 ..., 3 2 3]
  [2 2 2 ..., 3 3 3]
  ...,
  [9 9 9 ..., 0 0 0]
  [8 9 9 ..., 0 0 0]
  [0 0 9 ..., 0 0 0]]]

Do you have any ideias why it gets like that?
With the best regards

@BBarbosa Hi, Can you show me your code here ?

@TobyPDE I have tried it . but it seems not work

Hi @daicoolb!
These are the files I have changed:

use mypredict.py instead of predict.py
replace the dltools/utility.py
replace train.py
replace dltools/architectures.py

I'm using OpenCV 3.3 because it gave me problems trying to load a video file with OpenCV 2.4.
Download files from here frrn.zip

@BBarbosa Thanks for your changes!
I have used your new scripts to predict my own data. The "predictions[0]" has now 3 dimensions instead of 2. For example:
(1, 800, 1280) vs (800, 1280)
Why is that?
And with the same input images, if using "mypredict.py" I got different results from what "predict.py" did. It seems the "image" you feed to "pred_fn(image)" is not the same "batch[0]" the author feed to "val_fn(batch[0], batch[1])".

@hans41 you're welcome.
Technically, (1,800,1280) and (800,1280) are equivalent.
With regard to the inputs images, i had problems feeding images to the network with the author's provider implementation. So, I managed to adapt one for my own following what @TobyPDE described here . The outputs may differ from mypredict.py to predict.py once there may be some pre-processing operations skipped.

@BBarbosa Nice. But my predicted results look quite strange. I used your "myprediction.py" without modifications, as following pre-processing steps:

Read: scipy.misc.imread
Resize: cv2.resize
Rescale: np.divide(image,255.).astype(np.float32, casting='unsafe')
Convert: utility.opencv2tensor(image)
Reshape: np.reshape
Is that correct? Thanks for your help!


Plugin always connects to localhost

This is very strange :
  private val config = ConfigFactory.parseString(
    """
        akka {
          persistence.journal.plugin = "akka-persistence-redis.journal"
        }
        akka-persistence-redis {
          redis {
            host = redis
          }
        }
        """.stripMargin
  ).withFallback(ConfigFactory.load())

  val system = ActorSystem("example", config)

 Connect to localhost/<IP_ADDRESS>:6379
[akka://example/user/RedisClient-$a] CommandFailed(Connect(localhost/<IP_ADDRESS>:6379,None,List(KeepAlive(true)),None,false)) because of Connection refused

I tried to expose even redis.host = redis to the global scope, but I just cannot make it to connect to hostname redis. Any idea?

ConfigFactory.load() resolves the default configuration before it is merged with your overridden one. So all substitution are already replaced. What you want is to resolve the configuration after the merge occurred.
If you want to override the reference.conf by a string in your code, you should merge with the unresolved default configuration. Something like:
private val config = ConfigFactory.parseString(
    """
        akka {
          persistence.journal.plugin = "akka-persistence-redis.journal"
        }
        akka-persistence-redis {
          redis {
            host = redis
          }
        }
        """.stripMargin
  ).withFallback(ConfigFactory.parseResources("reference.conf")).resolve()

However I would recommend to use the standard mechanism described in the documentation

What? I don't thinks so, it is just a fallback for the primary :
  private val config = ConfigFactory.parseString(
    """
        akka {
          persistence.journal.plugin = "akka-persistence-redis.journal"
        }
        akka-persistence-redis {
          redis {
            host = redis
          }
        }
        """.stripMargin
  ).withFallback(ConfigFactory.load())
  println(config.getString("akka-persistence-redis.redis.host"))

Prints redis

Yes, because the merge overrides the specific host key you are querying.
But the journal uses a substitution which default to to akka-persistence-redis.redis.redis which is resolved by the load method before the merge occurs.
Try:
 println(config.getConfig("akka-persistence-redis.journal.redis"))

Please try my solution ans you will see the difference. That’s just the way the config library works.

Hmm, I still can't make it work :
redis.conf :
akka {
  extensions = ["com.romix.akka.serialization.kryo.KryoSerializationExtension$"]
  persistence.journal.plugin = "akka-persistence-redis.journal"
}
akka-persistence-redis {
  redis {
    host = redis
  }
}

val system = ActorSystem("example", ConfigFactory.load("redis").withFallback(ConfigFactory.parseResources("reference.conf")).resolve())

Still connecting to localhost :-/

Still the same problem. load resolves, but the resolution mechanism does not allow to resolve substitution in reference that are overridden in application (or redis in your case) (see the documentation)
For your example to work, either provide your overloading in a reference.conf file and simply call Configfactory.load or try the solution I gave you, where we only parse (hence without resolving) all the configuration, then merge them, and finally resolve the result. Remember that load method do resolve things.
ConfigFactory.load("redis") parses, merges, and resolve all the reference.conf files in your classpath, then parses redis.conf, merges it with the already merged and resolved references.conf, and resolves the result. What you want is to merge before any resolution is performed and that’s exactly what my first solution does.
Another way to do it is to have a redis.conf file that looks like this:
akka {
  persistence.journal.plugin = "akka-persistence-redis.journal"
}
akka-persistence-redis {
  redis {
    host = redis
  }

 journal.redis = ${akka-persistence-redis.redis}
}

I see, :man_facepalming: I grasp the problem now, thank you for your help and patience @satabin


TypeError: Cannot read property 'message' of undefined

I made a minor change and now I'm receiving this.  According to the comp page it is building fine.  Seems to be something related to the emulator.  Any thoughts?

I've got the same situation. A couple of weeks ago the error accured too. Don't know what causes it


add feature issue #24 issue #47

I add the feature that able to choose mulitple options in "no" mode
What i done basicly just change WordSample -> List[WordSample]
The test unit will post just in few days

@piglei
Could you review my code? thx

This feature has been release in version 0.5.0. Thanks!


Fix id with partitionKey domain find query, fix #193.

Signed-off-by: Pan Li<EMAIL_ADDRESS>

Codecov Report

Merging #209 into master will increase coverage by 0.29%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
+ Coverage   79.46%   79.76%   +0.29%
==========================================
  Files          40       40
  Lines        1018     1023       +5
  Branches      140      142       +2
==========================================
+ Hits          809      816       +7
+ Misses        137      136       -1
+ Partials       72       71       -1

Impacted Files
Coverage Δ

...osmosdb/core/generator/AbstractQueryGenerator.java
86.07% <ø> (ø)
:arrow_up:

.../spring/data/cosmosdb/core/DocumentDbTemplate.java
83.01% <80%> (+0.72%)
:arrow_up:

...repository/support/SimpleDocumentDbRepository.java
98.48% <0%> (+1.51%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0da4573...6abbd3a. Read the comment docs.


Weird "rolling" font rendering issue

Description
There is some odd "rolling shutter" like glitch in rendering letters. Letters that fall into the same column inside the viewport will all be distorted in the same way (around the same "distance" when measured against the width of the letter's block).
Pictures speak better than words here, see below!
Environment

Contour Version or Git commit hash: Prelelease 0.2.0, Build 264
Operating System (name / distribution / version): Ubuntu 18.04.5 LTS
Contour configuration: JetBrains Mono font.
TERM environment variable: xterm-256color
Compiler version: GitHub

Steps to Reproduce
Type in letters to the terminal, at least 10-20 in a row.
Details
Look at the /s in the picture, noting the / that is part of the "current directory". Both / above and below it is broken in the same way. Similar to all the other broken glyphs. It seems to happen once roughly every 10 columns. Note also the l in loaded.

However, it is not restricted to the / letter. It seems the only determining factor on both the existence and the kind of the glitch is which column the glyphs was rendered to.

If you check the first s below the / so in the same column, that / is bogus, and so is the s in the same column. The s under a normal / (below the G in SIGINT) looks normal.
However, the N in SIGINT also looks broken in the middle, just like how in the same column both / and the l of self is also affected similarly.

Compare the bottom left corner of the / and the left side of the s with the other s. There is a few pixel wide glitch there, on both.

Now the / on the top right has a bit of a glitch, and so is the l which bottom right part is longer than the other l's (which / in the same column isn't glitching)

If you check the rightmost f here, it has a bit of a glitch to the left of the "trunk" of the f. And just in the same position above, the / has a bit of a glitch... at around 30% of the total "width" of the glyph.
The previous f on the left which has a clear / above it doesn't suffer from the glitch.

The 9s in the date are deterministically broken in that column. However, look at the number just before the / like 82/85 and 83/85. The 2 and 3 is broken, because they are in the same column.
What's more, in the bottom 5 lines, where the same column is now showing a / instead of a number (because the left number is 1 digit long only), it is the / that is broken. Look closer at the e in Pre-analysis and and the a in Starting, which fall onto the same column, they are bonkers too.
Just as how the column of c in clangsa, all the cs are broken. The y in Pre-analysis in the same column, and all the 1st letters of the filenames printed above, suffer from the glitch, at basically the same position inside the glyph.

Here's the previous image zoomed in and some of the affected columns highlighted.

thanks for the wrapup! :)

this also shows it quite cleary I think

If you change the font size, the pattern changes and appears in different locations, but it's still appearing.


[581] Shortest Unsorted Continuous Subarray

Codecov Report

Merging #57 (d210a1a) into master (b4c684b) will increase coverage by 1.0%.
The diff coverage is 100.0%.

Impacted Files
Coverage Δ

...lem/p0581_shortest_unsorted_continuous_subarray.rs
100.0% <100.0%> (ø)


Resolver: A dep is equivalent to one of the things it can resolve to.

This is a series of small changes to the resolver, each one on its own is not worth the cherne, but somehow all together we can add a new optimization rule. The result is that the test in #6283 is no longer exponencial (still a large polynomial, cubick?) and so N can be bumped from 3 to 20. This also means that we pass with all the cases reported in #6258. Resolution is NP-Hard, so we are moving the slow cases around. To reduce the chance that we will be flooded by new bad cases I run the 4 proptests overnight, and they did not find a new exponencial case.
I would recommend reviewing this commit by commit. As each change is pretty simple on its own, but the mixed diff is harder to follow. This is submitted as one big PR as that is @alexcrichton's preference.
A special thanks to @nex3, our conversation was important in convincing me that several of these changes would be needed even in an eventual PubGrub based system. And, the question "why would PubGrub not have a problem with #6283" was wat crystallized this optimization opportunity in my mind.

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

We are not seeing reports of performance problems from Cargos users. So I don't think it is worth committing changes that make the code harder to understand. Now, while it is fresh in my head, is the best time to add comments/docs. What could be made more clear?

Oh well so to be clear this is just a super tricky chunk of Cargo inherently, so I don't think this is really the fault of this PR or anything. What would be nice, however, would be a textual long-form description of what's going on somewhere, perhaps maintained in one location. The code could then liberally be commented with respect to that master description, and it'd be much easier to review the word changes (to make sure they make sense) and then cross-reference the code to make sure changes in the code match changes in the words.
In that sense there's not really a function or two I think that would benefit from more docs, but more like a "if everything had 10% more documentation it'd probably make it easier". In that sense if you can think of any comments to add that'd be great!

I definitely agree that we need to make progress to getting this (and the rest of cargos internals) better documented. Someday I'd love to have a coherent overall view of the resolver (maybe something as great as pubgrub's). Several people have asked me for a "formal specification". In the meantime we can try to find more places to insert explanatory material and try to make sure we are using consistent terminology.
We should try to add more type aliases. For example the inconsistently used terminology of "age" (added in this PR) should be a reference to the new type. That gives us a place to add a comment on how and why it is used. (I'll add a commit when I have a spare cycles.)
We should try to make more functions (even if there only used once) for similar reasons. In that way generalize_conflicting is better then the code inlined.
I think let's try to only merge PR's that leave the resolver better documented. Incremental progress can add up.

It is building for me locally....

Rebased on master. This time I even remembered to fetch first!

I think I've improve comments in several miner ways. Doing an updated overall design document is going to have to happen after pub/priv is working with whatever optimizations it takes to make that work.
How would you like to proceed?

I think this is good to go, and yeah holding off a design doc and such sounds good to me!
@bors: r+

:pushpin: Commit 91b5a9d323145e7c5787f1fa4562b91e2a0acb43 has been approved by alexcrichton

:hourglass: Testing commit 91b5a9d323145e7c5787f1fa4562b91e2a0acb43 with merge c866f48e400dc8e2451ae88ed9453b374fddf4a5...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: alexcrichton
Pushing c866f48e400dc8e2451ae88ed9453b374fddf4a5 to master...


Automate Local Image Pruning

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-7189
What this PR does / why we need it:

This PR helps us automatically prune local container images generated by make ci, so that we as developers do not run out of local disk space in our machines. Additionally it also does labeling for all the intermediate images in a multistage Docker file which could help us at the time of pruning.
Test plan for issue:

Run make ci-rp to produce aro-* images and later run make ci-clean to verify and validate whether it is pruning those images to free up our local disk space.
Is there any documentation that needs to be updated for this PR?


Don't require main in files verified via VS Code

Chanhee says there's a better way to handle this, on the server side, so I'll withdraw this pull request.

Fwiw, --crate-type=lib doesn't currently work (due to an interaction with erasure that we never could figure out), but it should be fixed soon when we transition to the new macro-based erasure strategy. /cc @Chris-Hawblitzel


Add Budapest, San Francisco to Prezi Locations

For reference: http://prezi.com/jobs#locations

Awesome! I appreciate your additions :)


Carthage

I don't anything about Carthage, but if someone wants to help by making this project Carthage-ready, that would be much appreciated.
Please help after #5 is done.

Fixed with cdd47b879aab01b4e49bdf8f8bced9f9ff00cf03


Fix IMGT typos

Thanks! I'll merge this once I fixed the CI in another PR.

Sounds good! Or if you want to fix these typos yourself and delete this PR that works for me too. I didn't think about the CI stuff when I started this.

No worries! I need to fix the CI anyway, the problem is that one of the upstream packages got updated and broke sth -- not your fault at all!


Preview Release CI fails on linux-cross

fails here (https://github.com/sparckles/Robyn/actions/runs/11433204331/job/31804822966?pr=989)
upstream issue thread ref: https://github.com/uraimo/run-on-arch-action/issues/155

@VishnuSanal , any update here? It feels like the bug has been fixed.

I have updated #977 -- let's see whether it passes.

any update here? It feels like the bug has been fixed.

I have updated #977 -- let's see whether it passes.

seems like not, the tests still fail.


ProductSearch recycler view do not show data

What

The recycler view of ProductSearchActivity doesn't show data

Why

The value of recycler view adapter is assigned to itself instead of the adapter declared in the class

Screenshot of code

@teolemon Hey can I raise a PR for this?

@teolemon is this repo active?

Seems to be an easy fix. Will try to fix it soon.


BUG: Error mounting a repo

Hi,
I created a repo in an Ubuntu 14.04 machine using latest go and master as of 3abff7928c614f794f00347061fe70563af7252f. restic version gives:
restic 0.1.0 (v0.1.0-171-g3abff79)
compiled at 2015-12-22 00:58:15 with go1.5.2

I can successfully mount this on the same box.
I then brew installed it on OSX, which gives:
restic 0.1.0
compiled at 2015-12-22 00:35:57 with go1.5.2

which gives the following error:
➜  ~  restic mount ResticMnt
json: cannot unmarshal object into Go value of type []*repository.packJSON

restic check on the ubuntu machine works fine but fails with the same error on osx.
It might make a difference but I interrupted the first backup. The second backup of the same directory worked. restic check reported lots of pack 022f240f2bbdd10e38845577f78da323a5f2dda0e8af9f23e69bd4d0f90dcdab: not referenced in any index. I then took a guess and restic rebuild-indexed the repo (from ubuntu) and then restic check worked fine.
Thanks!

Thanks for reporting, this seems to be a bug, there is some JSON that could not be parsed in the repo, that should not happen. Could you please build restic with debug support and run it with a debug log, as described here: https://github.com/restic/restic/blob/master/CONTRIBUTING.md#reporting-bugs
Then have a look in the debug log if you can see what's going on, maybe you can paste the relevant section. I might add some instructions based on what we can see from the log file.

Hey, did you maybe find the time to run restic again with a debug log?

Hiya - apologies no, not yet. It is on my TODO list. One mitigating factor might be that I used a very complex key which contained all sorts of fun characters… I will try and reproduce in the next 48 hours.

On 2 Jan 2016, at 12:48, Alexander Neumann<EMAIL_ADDRESS>wrote:
Hey, did you maybe find the time to run restic again with a debug log?
—
Reply to this email directly or view it on GitHub https://github.com/restic/restic/issues/378#issuecomment-168388613.

Great, that'll help a lot I hope :)

I haven't yet had chance to rebuild with debugs, but I can reproduce the error with the repo (created on Ubuntu and then copied and mounted on OSX) and the following key:
UKj@%n8wNCnJyMBZVIZnu7$0En#pCIVeGBp84e$SXF4@CG##ouU2KEr0n4a&9zG43dKYw4WIhw4Q9%#odGqgulpWDMp1d0vNB3
TGZ repo is: https://www.dropbox.com/s/mqk0s7qgm6muktv/restic-repo.tgz?dl=0
Don't worry - the key is temporary so no trade secrets :-).

Hm, I got the repo, but it seems the password is incorrect...

Ah, got it. Needed to copy the key from your comment's source ;)

Let me know if that is sufficient, if not I will do the rebuild with debug route.

As another data point - creating the repo on OSX works (as in it can be mounted) - the problem is only if it is created on Ubuntu.

Attached is the debug log from Ubuntu - I am unsure how to get the debug build on OSX as I installed it via brew.
Do you need anything else from me?
restic-debug.log.zip

Oh, I see. You created a repository with a recent version of restic, compiled from the master branch. Then you tried to mount the repo on OS X with the released version 0.1.0. In the meantime, the index format has changed, so the version on OS X is unable to read the index. This fails, and the error message is printed.
So, the solution is to also use a recent version of restic on OS X. You can build one yourself the same way as you did on Ubuntu, https://github.com/restic/restic#build-restic
That's the solution for your immediate problem, I agree that the error message is unhelpful and could be improved.
We always try to be backwards compatible (especially regarding released versions), but that does not include forwards-compatibility ;)

Well restic version reports "0.1.0" on both Ubuntu and OSX:
ubuntu:
./restic version
debug enabled
restic 0.1.0 (v0.1.0-171-g3abff79)
compiled at 2016-01-03 13:35:52 with go1.5.2```

OSX:

restic version
restic 0.1.0
compiled at 2015-12-22 00:35:57 with go1.5.2

Git log on Ubuntu is:

commit 3abff7928c614f794f00347061fe70563af7252f
Merge: 55d9c5f 2976df2
Author: Alexander Neumann<EMAIL_ADDRESS>Date:   Sun Dec 20 20:45:18 2015 +0100
Merge pull request #375 from restic/fix-suid

Backup and restore setuid/setgid/sticky bits

I don't know how to do `git log` on homebrew unfortunately.

Indeed, the base version is 0.1.0 in both cases, but the version on Ubuntu is 171 commits further advanced, as the string 0.1.0 is followed by -171. After release, development continued from that version on, so it is still included in the base version string.

Ah, the yak that is versioning :-). May I gently suggest that this sort of incompatibility should be a trigger for a different version.
Happy for this to be closed?

I'm happy, please close. I'm still not completely happy with the versioning scheme and I'll probably release 0.2.0 soon so that it's more obvious. When restic development has settled a bit I'll change the text of the readme and the manual so that user's are instructed to compile and use the latest release instead of the master branch (which should always be stable and safe to use, but may contain bugs).

Versioning with high velocity is a pain - either you don't version enough leading to this or you version too much leading to 0.3423.1 which is just silly. Good luck, and I look forward to seeing how restic progresses!
(Happy new year).

Thanks, you too a happy new year! Thanks for trying restic, and please keep reporting bugs, even small documentation errors or unclear error messages ;)


Kap 3.5.1 arm64 DMG still bundles x86 ffmpeg-static & gifsicle

macOS version:
ProductName:	macOS
ProductVersion:	12.0.1
BuildVersion:	21A559
Kap version:
3.5.1
Steps to reproduce
lipo -info /Applications/Kap.app/Contents/Resources/app.asar.unpacked/node_mdules/ffmpeg-static/ffmpeg
lipo -info /Applications/Kap.app/Contents/Resources/app.asar.unpacked/node_modules/gifsicle/vendor/gifsicle
Current behaviour
Non-fat file: /Applications/Kap.app/Contents/Resources/app.asar.unpacked/node_modules/ffmpeg-static/ffmpeg is architecture: x86_64
Non-fat file: /Applications/Kap.app/Contents/Resources/app.asar.unpacked/node_modules/gifsicle/vendor/gifsicle is architecture: x86_64
Expected behaviour
Expect arm64 ffmpeg binary.
Workaround
Symlink homebrew binaries as described here:
https://github.com/wulkano/Kap/issues/970#issuecomment-970097099
Edit: Ironically, brew install kap also bundles the x86 ffmpeg and gifsicle.

Seems like this may help solve the issue?
https://github.com/eugeneware/ffmpeg-static/issues/35#issuecomment-631003066
...at least in case of ffmpeg-static.

Bumping this, still the case for Kap 3.6.0


✏ Invert order of typing <-> typing_extensions

The description of the error message is not accurate.
Selected Reviewer: @adriangb

please review

please review

Superseded by #6370


Fix typings

This is the same change as #91 but was reverted in v2.1.6

I think there's something wrong, these types are creates automatically. i was wondering who reverted it, i just made a patch version but it removed it again. could you give it another look? @Setsun made the initial commit to support types but maybe there's something missing to tell the typegen tool that we need the exports, too.


0.1.7 pip install created deprecated electrum-personal-server-rescan

I installed eps 0.1.7 in a fresh jail, and noticed that it installed two scripts in /usr/local/bin:
electrum-personal-server
electrum-personal-server-rescan

Perhaps this is intentional to maintain backwards compatibility?

Yes it's for backward compatability.
If you run that script then it will output a warning: https://github.com/chris-belcher/electrum-personal-server/blob/master/electrumpersonalserver/server/common.py#L824-L825


Depend on io-uring version ^0.5.8

io-uring v0.5.8 handles the overflow of the cqueue so this bump on the dependancy fixes hangs caused when high frequency submissions fill the cqueue.
While we're at it, adds a unit test for such a hanging cqueue.

@Noah-Kennedy I know the unit test isn't structured to your liking. I'm happy to change it if you can give me more help with it. The  things I tried this morning didn't work, I suspect because the hang is really a thread block, otherwise I can't explain why my other versions just hung there indefinitely.

@Noah-Kennedy At least I can say it's nice to see this ci test passing, even with this unit test in. It wouldn't have passed with io-uring version =0.5.7.

Let's just merge this now and cleanup later.


Feature/invitation token 2

Extends the invitation functionality. Now, users will receive a mail with an invitation link. After clicking the link they can either log in or register an account incase they dont already have one.
Also closes #121 by adding the possibility of assigning a responsibility per invitation.

closes #9
closes #10
closes #121

closes #9
closes #10
closes #121


CIV-0000 DTSCCI-488: Investigation - Demo environment not showing Medical Repo…

…rt upload function
Before creating a pull request make sure that:

[ ] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ ] No

Closing and reopening the PR


Make Communicator and SensorManager objects singletons

No need for multiple objects. Make a singleton so that it is not required to be injected into all commands.

They should be singletons but still need to inject them for testing


Request: Add OneUI Widgets Adapter

Name: OneUI Widgets Adapter
GitHub: https://github.com/project-oneui/oneui-desktop-widgets
Description: Hey, I'm working on a windows project which creates desktop widgets in the OneUI Style. The OneUI Style is the newest design style of Samsung. And as I try to make the long configuration easier I would really appreciate if you could add the adapter. The port used for it is 8943.

Looking at the source, I don't see anything to interface with WebNowPlaying or anything listening on port 8943. Perhaps I'm missing something?
Also, your description recommends installing [WebNowPlaying-Redux-Spicetify(https://github.com/keifufu/WebNowPlaying-Redux-Spicetify) which is no longer maintained as my adapters read data from desktop players via a Windows API.

Im really sorry, I added the false repository. Here is the right one: https://github.com/project-oneui/oneui-desktop-widgets-service. I didnt know the spicetify plugin isnt maintained anymore gonna look into it

I see, the C# library doesn't have support for desktop players built-in. See more here.

The best would be to use NodeJS, as the main app is based on it, but I myself dont know anything besides C# and JS. + If I use a compatible library I wont need the Spicetify plugin if I understand correct?

It also seems like the Spicetify Plugin doesnt work for the most part. Out of the CoverURL, Title, Artist, Length, Duration: I can only use the Duration

You're making me want to create a js library now, xD.
Currently I got a C# and a Python library.
The python library has support for desktop players built-in on Windows.
The C# library doesn't as I had trouble building it when using Windows APIs in it, so the Rainmeter adapter has the source of the C# library copied and extends it with this implementation.
All this does is read metadata from Windows using the GSMTC API, which popular/modern players (Spotify Desktop included) report basic metadata such as Title, Artist, Duration, etc. to.

It also seems like the Spicetify Plugin doesnt work for the most part. Out of the CoverURL, Title, Artist, Length, Duration: I can only use the Duration

This makes sense as the Spicetify implementations are only compatible with older versions of the library using older communication protocols.

My first approach was this API. My big problem was that spotify adds "Spotify" as text on the bottom but it seems like you fixed this by cropping it. So I think I will try to replicate your code for my circumstances. Thanks for the help

Let me know if you need any help. Good luck!

Also, does this mean you want to only use GSMTC or WNP+GSMTC? If the first then i can close this issue.

Im gonna use GSMTC, because using the browser isnt really what I want for the users. So GSMTC is better for users.


Grammar issue

You state:
These security features allow you to build robust yet secure ASP.NET Core apps.
Is the 'yet' correct? Surely robustness and secureness do not counteract each other, shouldn't it be:
These security features allow you to build robust and secure ASP.NET Core apps?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d4d39ecf-0465-afd3-2384-aaafe9e8ea79
Version Independent ID: e9a58581-b565-25eb-49b3-4c93714f0940
Content: Overview of ASP.NET Core Security
Content Source: aspnetcore/security/index.md
Product: aspnet-core
Technology: aspnetcore-security
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Any chance you could PR this? At the top right of the article, select the Edit pen icon:

Select the pen icon again. Save.

Sure, let me take a look

Done

Fixed per https://github.com/dotnet/AspNetCore.Docs/pull/24413.
@markharwood101 ... Note for future reference that if you place the text Fixes #{ISSUE NUMBER}, where the placeholder {ISSUE NUMBER} is the issue number, at the top of the opening comment of the PR, GH will close the issue automatically when the PR merges. If you place Addresses #{ISSUE NUMBER} at the top, it cross-links the issue without closing it (i.e., you plan to return later and create one or more additional PRs for the issue, so you don't want to close it until the last PR is done ... the last one would get the Fixes line).
Thanks again for taking care of this issue, @markharwood101! :rocket:


Particles which only have a velocity but no acceleration don't collide properly

Tested versions
v4.2.2.stable.mono.official [15073afe3]
System information
Godot v4.2.2.stable.mono - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4080 (NVIDIA; <IP_ADDRESS>22) - AMD Ryzen 9 7950X3D 16-Core Processor (32 Threads)
Issue description
When a particle system has no set acceleration then the collision does not work unless particle speeds are high. See this video:
https://github.com/godotengine/godot/assets/327257/fc2a90f9-32ba-46cc-9e88-5bb2279ff6d7
The left particle system has no initial velocity and only set gravity to -5. The right particle system has an initial velocity of 3.  In both particle systems the particles have visually similar speeds, yet their collision behaviour is totally different. With a velocity of 3 the particles will just stick on the surface. Only if I increase the velocity the particles will actually behave similarly to the particle system with acceleration.
Steps to reproduce
Check the particles.tscn in the attached example project. Both particle systems are set up exactly the same, except that the left one uses acceleration while the right one uses velocity.
Minimal reproduction project (MRP)
collision_reproducer.zip

Here is another example. Note how the particles collide with the box when I use radial acceleration, but go right through the box when I use radial velocity.
https://github.com/godotengine/godot/assets/327257/711f119d-6632-47a4-8070-1ae86bede66c

I believe this is normal behavior - In the first example, the velocity emitter had Gravity set to 0, and a negative initial velocity: So when a particle collides with the box, it gets deflected - but there's no continuous force pushing it down the sides. Enabling gravity allows it to slide down the sides of the box as usual.
In the second example, it seems to be caused by setting a positive animated velocity - as the particle reaches the box, the collision should impart a 'reverse force' and prevent it from going through (and should set velocity to 0ish), but the animated minimum velocity forces the particle to keep moving through the box.  Animating directional velocity using the directional velocity curve also causes this issue.
I think for good collisions you need to be using the "velocity limit" curve to allow the particles to be stopped by collisions while still limiting its maximum velocity.

The root of this issue is the same as https://github.com/godotengine/godot/issues/87221
We currently have a part of the particle shader that removes the velocity of the particle if the length of the velocity is less than 3 and it collides with a surface. https://github.com/godotengine/godot/pull/87320 removes that section of code which will fix this issue as a result


Fix not possible to resolve conflict in code editor

Checklist

[x] I tested all changes and all related features with different users (student, tutor, instructor, admin) on the test server https://artemistest.ase.in.tum.de.

Motivation and Context

Resolves #1940
Description

The Resolve Conflict Button wasn't working for exam exercises.
Steps for Testing

Create an exam with programming exercises
Participate and edit a file in the online editor, save but don't commit
Clone the repository
Make local changes to the same file and push the repository (provoking a merge conflict)
Go to the online editor (you may have to click 'Refresh')
Click on "Resolve conflict"

Screenshots

What was the exact issue? Why did it state "Not found"?

There was an issue with the domain dependent service, it did not generate the correct url. I did not find the exact cause why this did not initialize correctly, so i wrote the resolve dialog similar to how the refresh button works. The reset function of the repository service is now called from the actions component and not from inside the modal, which somehow works.

@Component({
    selector: 'jhi-code-editor-resolve-conflict-modal',
    templateUrl: './code-editor-resolve-conflict-modal.component.html',
    styleUrls: ['./code-editor-resolve-conflict-modal.scss'],
    providers: [CodeEditorRepositoryFileService],
})
export class CodeEditorResolveConflictModalComponent {

This is the root cause. We provide another instance of CodeEditorRepositoryFileService which won't be properly set up, as we provide all domain dependent services in ExamCodeEditorStudentContainerComponent and the domain is set for those services. The refactoring of @schultek moves the service call to a component which uses the properly configured service instance.


Made Upload component UI-independent

Made Upload component UI-independent

Moved UI-related code from Upload.jsx in vulcan-forms-upload to UploadInner.jsx and UploadImage.jsx in vulcan-ui-bootstrap
Kept UploadImage.jsx separate so that it can be overridden with custom components that could, for example, show rounded corners for an avatar or allow cropping
Added several optional field schema properties next to inputProperties.presets:

dropzoneStyle: style attribute for the dropzone to set its size
imageStyle: style attribute for images to set their size
uploadImageComponentName: name of a component to use instead of UploadImage

Re-added the ability to save single images in String fields; otherwise Upload couldn't be used for Users.avatarUrl, for example

Outdated


Tweaks to fit my setup

Sorry for the spam @pfandrade, I opened the PR agains the wrong repo 🤦♂  my bad!


Vim starts continuously spawning git.exe processes in :Gdiff

environment

vim: latest

vim-airline: latest

OS: Windows 10

Have you reproduced with a minimal vimrc: kind of

What is your airline configuration: here is my minimal .vimrc
set nocompatible
filetype off
set rtp+=$HOME/vimfiles/bundle/Vundle.vim/
call vundle#begin('$USERPROFILE/vimfiles/bundle/')
Plugin 'tpope/vim-fugitive'
Plugin 'vim-airline/vim-airline'
call vundle#end()

actual behavior
Vim starts continuously spawning git.exe processes when I do :Gdiff.

I tried to see if caching the results of those commands helps, see 4d1a94, however I seem to have only caught half of infinite calls.


Expand Documentation on CLI Command Usage

This PR contains daily documentation updates based on the following suggestion: The code repository indicates that there are extensive CLI generation features available. However, details on these CLI commands and usage, particularly for the 'sublayer generate' feature and the 'new project' workflow, are not adequately covered in the documentation. Expand the documentation to include a detailed guide on how to utilize CLI commands, including step-by-step instructions and example commands.

links were made badly and the top section as well. should be resolved by the example coming next


⚠ ESPN has degraded performance

In 7a1a29c, ESPN (https://espn.com) experienced degraded performance:

HTTP code: 200
Response time: 1411 ms

Resolved: ESPN performance has improved in 9008f31.


Not Working on Dell RTX 2080

Stats show up in the log for Gminer, but not T-Rex. Tried latest stable and unstable

Duplicate of #32

Same as this one. Different card, the temperatures show in the log. They do NOT show in HiveOS

Hi,
while you have gminer running, can you please run this command and report the values? You may omit your own address:
curl http://<IP_ADDRESS>:42010/stat


VM setup issues

I had to use git clone rather than git pull (which gave an error)
the two vagrant plugin commands look like a single line, need to be separated by a line break
vagrant plugin installation is flaky - I had to run it a few times to actually get it to work, due to http errors. might want to note that if it fails one should try it again
on running the vagrant up command, I got this error:

DNab4029e9:fmri-analysis-vm poldrack$ vagrant up 2>&1 | tee -a provision.log
Bringing machine 'default' up with 'virtualbox' provider...
There are errors in the configuration of this machine. Please fix
the following errors and try again:
Atlas push:

Missing required configuration parameter 'token'. This is required for
Vagrant to securely communicate with your Atlas account.

To generate an access token, run 'vagrant login'.
I am not sure if there is a way to turn this off if a person doesn't want to upload to atlas.

Would probably be good to have separate instructions for people who just want to use the machine, and those who want to build it for redistribution.

fixed #2 by adding a semicolon


Emmet Go to matching pair not working

Issue Type: Bug
When editing an HTML file say

Placing the cursor on the /div at line:3 or the first div at line:1 and doing CTRL+SHIFT+p than Emmet Go to matching pair does not move the cursor.
In fact nothing happen, cursor stays on the div.
VS Code version: Code - OSS 1.45.1 (5763d909d5f12fe19f215cbfdd29a91c0fa9208a, 2020-05-17T22:31:53.325Z)
OS version: Linux x64 5.6.14-arch1-1

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz (8 x 3490)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: disabled_softwareskia_renderer: disabled_off_okvideo_decode: unavailable_offviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_off_okwebgl: enabledwebgl2: enabled

Load (avg)
0, 0, 0

Memory (System)
15.57GB (10.19GB free)

Process Argv
. --no-sandbox

Screen Reader
no

VM
0%

DESKTOP_SESSION
i3

XDG_CURRENT_DESKTOP
i3

XDG_SESSION_DESKTOP
i3

XDG_SESSION_TYPE
x11

Extensions (4)

Extension
Author (truncated)
Version

elm-ls-vscode
elm
0.10.2

elixir-ls
Jak
0.4.0

csharp
ms-
1.21.18

Go
ms-
0.14.3

It doesn't work for me either in JavaScript. Testest with extensions off. Seems like the feature is completely broken.
Version: 1.47.2
Commit: 17299e413d5590b14ab0340ea477cdd86ff13daf
Date: 2020-07-15T18:18:50.054Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.6.0

Cannot reproduce on 1.49.3.
@dstpierre I know it's been months, but I'm wondering whether you can go over those steps again and see if it's fixed on your end, after updating Code?

@rzhao271 yes I can confirm it's working now, thanks.


WIP: Integrate more consistent dictionary keys from lbryum

This patch integrates changes in lbryum pull request https://github.com/lbryio/lbryum/pulls .
Since the lbryum pull request changes dictionary key names of lbryum function outputs, we need to make the appropriate change in the Wallet code.

          1 Error

:no_entry_sign:
Please include a CHANGELOG entry.

          1 Message

:book:
See http://keepachangelog.com/en/0.3.0/ for details on good changelog guidelines

  Generated by :no_entry_sign: Danger


Update index.js

Automated Theme Preview
Hi, thanks for the theme contribution. Please read our theme contribution guidelines.
We are currently only accepting color combinations from any VSCode theme or themes with good colour combinations to minimize bloating the themes collection.

Also, note that if this theme is exclusively for your personal use, then instead of adding it to our theme collection, you can use card customization options.

:heavy_check_mark: Theme PR does adhere to our guidelines.
Test results

:heavy_check_mark: roser_pine

Result: :heavy_check_mark: All themes are valid.
Details
Roser_pine theme preview
title_color: #9ccfd8 | icon_color: #ebbcba | text_color: #e0def4 | bg_color: #191724
Preview Link


Backup detected as trojan

Hello,
I just found out about this project and decided to give it a try.
With the available docker-compose I just ran a simple try-out to my google drive but, as soon as I tried to download the file, Windows Defender flagged the file as a trojan.
Just to make sure this was not something on my end, I spined up a new virtual machine in my proxmox setup and tried again - it got flagged as well.
Here are the virus total scans:
https://www.virustotal.com/gui/url/d50bd452a48a43bb8a7d89ac8d8bc1092239672997375b571aeb8c58f294b4f5/detection
Now, I'm not entirely sure if this was caused by this project or by rclone (it is not the first time they get flagged as trojan/virus - but that was on their own .exe), so I'm just posting this here so someone can check this repository.
If it turns out this is something on my end (highly doubt it because, as I said, I tested this in two different setups) I sincerely apologize in advance.
Thank you very much!

Thank you for your feedback, I take security issues very seriously.
I attempted to download the backup file you provided, and Windows Defender also reported it as containing a trojan. However, the zip file only contains a few encrypted tar files and a sqlite3 file, with no executable files present. I'm not sure why it would be flagged as containing a trojan.
You mentioned being able to consistently obtain backup files flagged as trojans on multiple machines. I tried the same on my end without changing any environment variables and without logging into Vaultwarden. After performing the backup and downloading the file, indeed, it was also flagged as a trojan file. I downloaded the file and uploaded it via file upload, and it wasn't detected as a trojan on VirusTotal, which can be confirmed by comparing the body SHA-256 (url, by upload). Therefore, I believe this is a false positive, as I have been using this tool backup files for several years without encountering this issue.
Of course, I welcome code reviews of this tool, it is written in Shell and does not contain any remotely loaded content.


Update JS dependencies

Result of make npm-update. Only notable change is that updates now requires Node 10 and has been changed to a bundle, so its dependencies are no longer installed.

Codecov Report

Merging #10726 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #10726      +/-   ##
==========================================
+ Coverage   43.55%   43.57%   +0.01%
==========================================
  Files         589      589
  Lines       82662    82662
==========================================
+ Hits        36005    36016      +11
+ Misses      42185    42178       -7
+ Partials     4472     4468       -4

Impacted Files
Coverage Δ

modules/queue/workerpool.go
56.93% <0%> (-3.21%)
:arrow_down:

modules/queue/unique_queue_disk_channel.go
53.84% <0%> (-1.93%)
:arrow_down:

modules/log/event.go
64.61% <0%> (-1.03%)
:arrow_down:

models/gpg_key.go
53.95% <0%> (+0.52%)
:arrow_up:

services/pull/pull.go
35.88% <0%> (+0.88%)
:arrow_up:

services/pull/temp_repo.go
31.62% <0%> (+2.56%)
:arrow_up:

services/pull/patch.go
64.51% <0%> (+2.58%)
:arrow_up:

modules/git/command.go
89.56% <0%> (+2.6%)
:arrow_up:

services/pull/check.go
55.48% <0%> (+5.48%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37bd578...5dbd042. Read the comment docs.


reduce client close bookkeeping

Instead of carrying around a symbol for ownClient, just embed the Client passed in by the caller with a wrapper that disables invoking Close().

(fyi, I've now signed the CLA.)

There is only 1 fail out of 6 tests, but I don't believe it has anything to do with the code I changed...?

Thank you! 💯


Create a component to show missing data

A user annotating e.g. age on the annotation page should see a representation of all of the values we think are representing missing values in the columns that are "about" age.
data in:

list of columns (and their names) previously categorized as "about" age
the raw values from these columns
if available, the mappings for these raw values from the data dictionary
a list or index of unique values we think may represent missing data (this could also generated by a function inside the component)

behaviour:

[ ] the component shows me every value we consider to reflect "missing data" (e.g. table, list, ...)
[ ] together with these values, I can see the name of the column the value came from (e.g. "XX" could stand for missing data in one column but not in another)
[ ] there is an intuitive way for me to label a value as "not missing data". e.g. with a button that is right next to the value, or a checkbox, ...
[ ] when I complete the action to label a value as "not missing data" (e.g. press a button), it disappears from the values shown in the component

data out:

a list of values and the columns they came from, that reflect "missing data"

To discuss:

there should probably also be a way to undo this operation or declare values as "missing" in a standardized way
where should we keep track of these missing values?

@surchs Can you explain a bit more what you mean by the word "missing" for this component?

Yeah! So let's assume a column "Age" has the values ['11.0', '12', 'n/a', 'XXXX', '-', '14.1', '9999']. Then n/a, XXXX, -, and probably 9999 are likely to reflect a missing value or some entry error, rather than an actual age. We are unlikely to see so many different ways of describing "missing" data in one dataset, but it's not unlikely that there are several, e.g. because of typos (i.e. n/a and na) when data were entered by hand.
Particularly for continuous variables like age (where we cannot ask the user to annotate each unique value), we will want to make an educated guess about what values reflect "missing values". But I think we may get that wrong some times. And for this reason, there should be a small component that shows the user the values we consider to be "missing" values, and allows the user to tell us if any of them are instead "real" values - so we can include them in our transformation attempt.

🙏 Thank you.

if available, the mappings for these raw values from the data dictionary

@surchs Can you flesh this out a bit more?

The idea was here:

take the values we think reflect "missing data"
look them up in the data dictionary under the "levels" key for categorical data (see the BIDS specs for participants.json files)
if we find any descriptions for the values in the data dictionary, add them to the missing data component as a reminder for the user

Let's say:

we annotate the "Sex" category
a column called "participant_sex" was labeled as "about" Sex
one of the values in this column is "na"
we pull this out (through sheer foresight) as a suspected "missing value"
we look up "na" in the data dictionary for "participant_sex":

Let's say the data dictionary looks like this:
participants.json:
"participant_sex": {
        "Description": "the self reported gender of the participant",
        "Levels": {
            "m": "male",
            "f": "female",
            "na": "participant did't answer the question"

Then we could show the string "participant did't answer the question" together with the suspected "missing data" value "na" to the user in order to help them make a better judgment.
Now, realistically, this is not going to be very important often. Because values are most likely going to be either easily identifiable as missing even without the extra description, or - more likely - missing values will not have a description in the data dictionary. So in short: I would rate this feature as not very important for now

This is all good and clears things up, but just one more question.

we pull this out (through sheer foresight) as a suspected "missing value"

This sounds like we are going to have custom code for each of the categories that has some hardcoded/reg-exed means of determining if a value looks out of the ordinary.  Is that correct?

I think that's an open question. The way I think about it at the moment is that most categorical columns will have a number of unique values that we can just show the user in full. Then they can tell us which of these are "missing values". E.g. a diagnosis column with ['pd', 'ctl', 'na'] are three lines in a table. And if 'na' is the "missing value", the user would select "missing" from a dropdown or checkbox for this row.
Even if we have to handle many categories in a column (or set of columns), e.g. for "assessment tools", we still have to ask the user to annotate each category. So one or two extra categories for "missing" data are not going to break things.
The only place where this doesn't work is for numeric / continuous data. But as far as I can see, this is also the case where identifying missing values is going to be easier. E.g. "should be a number > can I cast it to a number > no > probably missing value" or "should be a number between 1 and 100 > this is a negative number > probably missing". etc.
I think we'll have to see if this is enough. If you have some ideas. Let me know what you think

It'll be tricky code, but definitely not impossible. I think the best way to do this is write out the types of data and then list expected values and expected missing values. This way we can write out a series of general tests in the form of methods that can be reused for each type of data (column values).

Yeah, I think that makes sense to me. And what I meant to add but didn't is: for some obvious cases (e.g. empty string, wrong data type, etc) where it makes sense to capture via regex, it might make sense to have category specific rules. But alternatively we can also choose to only show this component for categories with continuous data

Is there an expected range field(s) in BIDS that you are aware of that is akin to the 'Levels' field?

I'm not aware of that. I know you can provide "units" in the BIDS data dictionary. But I think value ranges are not part of BIDS to my knowledge. We should check that though, and if it really doesn't exist, this may end up being a useful contribution to BIDS.

Would we consider outliers for numeric data to be "missing"?

@surchs Also, can I expect the column data type to be given to this component or will I have to derive it via the input data?

@jarmoza, sorry, missed these:

Would we consider outliers for numeric data to be "missing"?

I think for now, no. But that's a good idea and we could keep it in mind for a later addition. Make an issue?

can I expect the column data type to be given to this component or will I have to derive it via the input data

Ah, I think that's what we ended up discussing on slack today, right? Yeah, I'd say we should could pass this to the component. The parent component (containing the category-specific annotation tab) can have the category type hard-coded and pass it along. Sound good?


update artist repository

update the repository to be use LINQ style and be more consistent with AlbumRepositoryImpl

Thanks!


Update Composer dependencies (2023-10-01-00-14)

Visual regression test passed!
View the visual regression test report


client/network: Use request response for block requests

Current situation
With https://github.com/paritytech/substrate/pull/6634 client/network offers a generic way to send requests and answer incoming responses. So far this feature is only exposed to higher level components via NetworkService::request. At the same time client/network uses custom protocols to do block, finality and light client requests.
Change
Instead of using custom protocol logic for block requests, piggy-back on the new RequestResponsesBehaviour.
Along side the above refactoring, the request sending control flow via RequestResponsesBehaviour is changed. Previously one would call send_request immediately getting a RequestId back. Eventually the RequestResponsesBehaviour would emit a RequestFinished event, with the response, tagged with the RequestId. Instead now send_request takes a oneshot::Sender, which the requester can poll to receive their reply. The RequestFinished is still emitted, but for statistic purpose (Prometheus) only.
I see the following benefits of this approach:

Simplified control flow for block requests. Previously (1) Protocol (in protocol.rs) would bubble up a block request event, then (2) Behaviour (in behaviour.rs) would pass back down the RequestId and eventually (3) Behaviour would pass down the response tagged with the RequestId. Now Protocol (in protocol.rs) bubbles up a block request containing a oneshot::Sender to receive the reply.

Unified response awaiting in a single place. For external requests via NetworkService::request pending responses were tracked in the NetworkWorker and send into the cached oneshot::Sender. Now pending responses are tracked in the RequestResponsesBehaviour behaviour, allowing other (non-external) logic (e.g. block request logic)  to make use of it as well.

Pull request status
This pull request is ready for a high level review. As described above it only tackles the block request handling for now. The finality request handling will be removed with https://github.com/paritytech/substrate/pull/7546. Once https://github.com/paritytech/substrate/pull/7546 merged I will adjust this pull request accordingly. I am currently working on porting the light client request handling to request responses. As that would be an isolated change, I don't think this pull request needs to be blocked on it.
This partially solves https://github.com/paritytech/substrate/issues/6968.

This pull request is ready for a high-level review. I have updated the pull request description.

We're thinking about modifying Justifications from Vec<u8> to Vec<(ConsensusEngineId, Vec<u8>)> to support sending and storing multiple Justifications per block, as it's needed by BEEFY. Now it's my understanding that we'd still keep the Vec<u8> at the network layer, but since it will still be a breaking change, do you think it makes sense to piggypack this change on these network changes?
CC: @andresilva

We're thinking about modifying Justifications from Vec<u8> to Vec<(ConsensusEngineId, Vec<u8>)> to support sending and storing multiple Justifications per block, as it's needed by BEEFY.
CC: @andresilva

@octol can you be more concrete which Justifications struct you are referring to? Are you planning to role out this breaking change by evolving the protobuf schema?

Now it's my understanding that we'd still keep the Vec<u8> at the network layer, but since it will still be a breaking change, do you think it makes sense to piggypack this change on these network changes?

Just to make sure there is no confusion, this pull request does not introduce a breaking change to the block request protocol. On the wire everything stays as is. Thus I am not sure what you mean by piggybacking. I do think that introducing your breaking change after this pull request makes the change easier as this pull request simplifies the logic.

We're thinking about modifying Justifications from Vec<u8> to Vec<(ConsensusEngineId, Vec<u8>)> to support sending and storing multiple Justifications per block, as it's needed by BEEFY.
CC: @andresilva

@octol can you be more concrete which Justifications struct you are referring to? Are you planning to role out this breaking change by evolving the protobuf schema?

This would be https://github.com/paritytech/substrate/blob/c180950de63dbdfaa11053a8a56f35e694ed9e36/primitives/runtime/src/lib.rs#L94
I think the idea is that the protobuf schema stays the same, but since it would be now encoded/decoded to Vec<(Id, Vec<u8>)> it  would break backwards compatibility

Now it's my understanding that we'd still keep the Vec<u8> at the network layer, but since it will still be a breaking change, do you think it makes sense to piggypack this change on these network changes?

Just to make sure there is no confusion, this pull request does not introduce a breaking change to the block request protocol. On the wire everything stays as is. Thus I am not sure what you mean by piggybacking. I do think that introducing your breaking change after this pull request makes the change easier as this pull request simplifies the logic.

My thinking was just to avoid too many breaking changes, make them together with this (if it makes sense), or directly afterwards. But yeah I agree this PR seems to make this change simpler

Had quick chat with @mxinden  and I think the conclusion was that the change I had in mind is probably orthogonal enough from this PR that it can be handled on its own, either before of after this PR. I created #7556  which also mentions that we can probably evolve the protobuf schema in a way that changing Justification might not be as breaking change as I thought

This pull request has been running on a sentry node for ~ 6h.
The block-request-handler task now shows up in the Service Tasks dashboard:

Dialing attempt errors seemed to have increased:

Same goes for incoming requests failing due to unsupported protocol:

I will investigate this further.

(#7478)
On Fri, Nov 27, 2020, 2:51 AM Addie Wagenknecht<EMAIL_ADDRESS>wrote:

@wheresaddie approved this pull request.
👍
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/paritytech/substrate/pull/7478#pullrequestreview-539800203,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARSJH45B34F5BQRVXQPJBIDSR5SAPANCNFSM4THTHU2Q
.

Update: Unable to reproduce the test timeouts locally with cargo test -p node-cli. Will continue investigation tomorrow.

On this pull request among others the test_connectivity test is failing. The test ensures multiple nodes, among those both full and light nodes, connect to each other. The failure can be reduced down to two nodes, one light and one full. The failure only occurs when setting V1Lazy as the substream upgrade protoco via .substream_upgrade_protocol_override(upgrade::Version::V1Lazy).
More concretely:

The light client dials the full node.

The full node tries to open a substream with the light client for the /paritytech/grandpa/1 protocol. Given that the V1Lazy upgrade is used the node does not wait for a response from the light client, but instead directly sends user data.

The light client receives the /paritytech/grandpa/1 protocol proposal and rejects the protocol by sending back a NotAvailable multistream-select message. Once send, it listens on the substream for further protocol suggestions. Instead of reading the next protocol suggestion it reads user data which it can not parse and thus it returns a InvalidMessage error.

The InvalidMessage error is injected into all ProtocolHandlers. The Substrate NotifsHandler does not provide the inject_listen_upgrade_error method, but the libp2p-request-response ProtocolHandler does. On handling an InvalidMessage error the libp2p-request-response ProtocolHandler closes the connection.

With the libp2p-request-response ProtocolHandler closing the connection, the light and the full node never connect and thus the test_connectivity test fails.

I have to put more thoughts into how to tackle this issue. Off the top of my head we could simply not have the libp2p-request-response ProtocolHandlerclose the connection on anmultistream-select InvalidMessage` error.

would be to pass the error to the right handler instead of all handlers

You can't do that. Considering that no protocol has been negotiated, we don't know which handler is appropriate.
My opinion would be to let the Swarm's internals handle this error by resetting the substream, rather than reporting it to a ProtocolsHandler.

https://github.com/paritytech/substrate/pull/7658 only fixed https://github.com/paritytech/substrate/pull/7478#issuecomment-736803765 not all of https://github.com/paritytech/substrate/pull/7478.

Could you try (if you haven't done so) to sync Polkadot from scratch with this PR?
We could ask the devops, otherwise I can also help as I have a Parity-provided dedicated server for testing.

@mxinden you can now merge master and check if my sync pr also fixes your problems here :see_no_evil:

@bkchr I will do that. Thank you for https://github.com/paritytech/substrate/pull/7733!

Feel free to merge if all the testing succeeded!

Feel free to merge if all the testing succeeded!

kusama-fullnode-uw1-1 finished syncing from scratch. Metrics look fine compared to canary node and node running upcoming release.
bot merge

kusama-fullnode-uw1-1 finished syncing from scratch. Metrics look fine compared to canary node and node running upcoming release.
bot merge

bot merge

bot merge

Missing approval from the project owner

@tomaka would you do me a favor? :slightly_smiling_face:

Missing approval from the project owner

@tomaka would you do me a favor? :slightly_smiling_face:

bot merge

bot merge


Add metanorma-ieee to cimas etc worfklows

And remove metanorma-mpfa, which we are now longer supporting

Done


First attempt at deploying Concourse in Kube

@razvan-moj ^ could you please correct the following?