Submit "Com2Sense" Task

@nuankw We are now requesting that task authors please include an explicit section in the README.md file called "data source", listing exactly where you got your data from (or explicitly state that you made it up yourself). Many thanks!

@akshat311 are one of the assigned reviewers for this task.  Please provide feedback and be sure to notify me with a formal accept or does not meet criteria by Tuesday June 22 (if you have not already done so).

@StellaAthena are one of the assigned reviewers for this task.  Please provide feedback and be sure to notify me with a formal accept or does not meet criteria by Tuesday June 22 (if you have not already done so).

I am one of the reviewers assigned to review this task.
Thank you for the submission! Overall, I have some hesitance I would like to you address before I make a recommendation one way or another.
Correctness

The README appears to be unfinished.
The task passes the necessary checks.
I have objections to some of the sentences. While I haven't read them all, I found enough objectionable ones

I disagree with the expected answer for some of them:

Peach and Zelda are both princesses. Thus they probably act in a similar manner to each other. (Expected: true)
The 200 pound weight was easier to lift than the 600 pound weight. (Expected: false)
The shift starts at midnight, be there at 12:00 (Expected: false)

Some tasks are ungrammatical, contain typos, or are awkwardly phrased:

Divorced Sam married Joan. Joan is less likely to be more knowledgeable in marriage laws than Sam.
If you are waiting for a butterfly breaking out of the cocoon, you'd better keep focused as the process only no longer than seconds..
When adjusting music volume levels to their max settings, it will improve a person's hearing.

Finally, some tasks appear to have significant cultural biases or are not going to be true indefinitely:

Working at minimum wage it will take Anita ten years to pay off her student loans.
Because the wedding started at 10 am , the guest expected it to be over by noon.
A person aged 20 is more likely to remember what happened in 2000 rather than a person aged 40.

Formatting

The formatting of the task appears to be good.

Specificity

I am happy with the specificity of this task.

Thoroughness

There does not appear to be any discussion of controlling for potential confounders and nuisance variables. In fact, the adversarial nature of the data generation could very plausibly introduce confounders as adversarial examples don't transfer well between transformers.

Difficulty

I am unsure about the difficult of this task. While many small models are shown to do quite poorly, UnifiedQA-3B does reasonably well. I would not be surprised to learn that a 175B parameter model score at or near human level performance.

Novelty

There appears to be minimal novelty in this task. It follows a widely used paradigm (SQuAD) and these exact questions were previously published. While this is not necessarily disqualifying, it does mean that there is little novelty here.

Justification

The justification is adequate, but not exceptional.

Size

I see no reason to think running this task will require excessive amounts of compute.

The amount of tasks we received this round is tremendous.  With so many tasks to review we have decided to extend the review period to Tuesday, June 29.
Reviewers: if the submitter has made revisions please be sure to notify me with a formal ”accept” or ”does not meet criteria” by Tuesday, June 29  (if you haven't already done so).
this is an automated message

@StellaAthena Thank you for the review! We will try our best to address the concerns.

Hi @StellaAthena thanks for your patience. Here is our response:
About Correctness
In response to the raised data issue, we think some of them are good catches and made some corrections accordingly, specifically

We removed the Princess Peach and Zelda example as this requires knowledge about video games which we think isn’t common enough (both characters are princesses in their games yet the settings are very different, thus the original label.)
We corrected the labels for “The 200 pound weight was easier to lift than the 600 pound weight” and its complement.
We found the original labels for “The shift starts at midnight, be there at/after 12:00” to be correct (False/True).
We changed: If you are waiting for a butterfly breaking out of the cocoon, you'd better keep focused as the process [only -> takes] no longer than seconds.
We found the sentence “A person aged 20 is more likely to remember what happened in 2000 rather than a person aged 40.” is annotated as “False” in our dataset.

We also appreciate all other raised issues on the data quality. However,  we want to argue that noises and errors are unavoidable for any dataset and the issues raised should not outweigh the merit of the dataset. Also, we think some noises in grammatical usage, spellings and phrasing often wouldn’t make these sentences significantly less understandable and current language models have shown some level of flexibility as well.
We collected this benchmark dataset via Amazon Mechanical Turk and found a majority of the MTurkers reside in the US. Therefore, even though we instructed the annotators to not create heavily culturally-dependent samples, we still see cases that require, besides the so-called universal human commonsense, some background understanding of American culture and social/living style or even specific occupational knowledge. For such cases, we used our best judgement to exclude the ones we found most universally inapplicable.
Lastly, the total number of collected complementary pairs is around 4.8k, where ~0.8k are discarded for not having sufficiently high quality.
About Thoroughness
There are many existing works using adversarial techniques during data creation which have shown that the adversarial/model-in-the-loop method is widely acceptable and effectively practiced to combat models exploiting spurious patterns in the data as well as incentivizing more challenging data samples.
Besides, our instructions including rules for bonus payment for high quality data creation and data quality check all ensured a diverse content.
We addressed the doubt of “adversarial examples don't transfer well between transformers” in the following response to Difficulty. In short, all the transformer-based models performed well below humans (95%+), and the performance of the similar sized models to the model installed during the data creation phase (RoBERTa-large), are shown to be roughly on par with one another.
About Difficulty
There are three points we would like to highlight:

Looking at the standard binary accuracy, it may seem that the best performing model, UnifiedQA-3B is doing reasonably well, compared to other models. However, as compared to some popular common sense benchmarks such as Social-IQA (https://leaderboard.allenai.org/socialiqa/submissions/public) and Physical-IQA (https://leaderboard.allenai.org/physicaliqa/submissions/public), the same UnifiedQA-3B model achieves over 85% and 79% accuracy, respectively, while it only achieves roughly 71% on our task. This justifies the difficulty of our task in the common sense domain (also these performances are closer to their respective human performance).
A more careful inspection of the previously provided leaderboards (from AI2), it is noticeable that from 3B model to 11B model, the performance gain was merely within the  3-5% gain. We thus doubt that the performance necessarily grows significantly with respect to the model size and/or the amount of training data (assuming contamination or data leak). And hence whether simply training an enormously large model  can reach the 96% human performance remains an non-trivial open question.
We emphasize on the pairwise accuracy metric throughout our work (which can also be found in our paper), where the best performing UnifiedQA-3B model only performs as high as 51% accuracy, which highlights a huge gap below the 95% human performance. These three points should justify how challenging our task is as well as our efforts to devise a benchmark which spans different domains and reasoning techniques for common sense reasoning/understanding.

About Novelty
We would like to clarify that the question format is, first of all, very different from SQuAD, which is a span-based question answering task with a reading passage, while ours, is a true/false statement to be judged with common sense reasoning abilities.
We also put forth to distinguish between two-choice question answering tasks in the multiple choice (MC) format to our formulation of pairwise accuracy, in which we require the model to “individually” judge each sentence of a complementary sentence pair and compute their joint pairwise accuracy. This examines if the model “truly” understands the common sense aspects that our questions are testing, rather than exploiting certain spurious patterns and “exam taking skills” to only need to single out the “relatively” more plausible answers. We have a comparison between the MC format and our formulation in Table 6 of our paper, which shows that the model indeed performs better when supplying the questions in an MC format.
Furthermore, to our best knowledge, we are the first to explicitly define common sense knowledge domains and in conjunction with reasoning techniques to define the categories of the question types, which in result would help more on in-depth and systematic probing of the model performance. Figure 5 and Table 9 in our paper are good references for this particular contribution. We would also like to emphasize that, “all of our questions” are created “from scratch” by our AMT turkers with the help from our carefully instructed guidance, which are unique and were not published at all, elsewhere.

Your task has been accepted in the initial review stage.  The next stage of this process is for us to assign your task a meta-reviewer for final review and merge.  An assigned meta-reviewer will follow-up by commenting on the PR should it need further revisions.

It's great to see some fixes coming through! I believe that 4c4653349b0c4e2 is still incorrect.

Hi @StellaAthena could you please specify the reason so that we can modify it? Thanks.

John has three plants and a tree while Simon has three dogs. It is likely that John's house is more difficult to manage than John's.
This sentence doesn’t make any sense. One is supposed to be Simon

Hi @nuankw! Thank you for your submission. I'm the meta-reviewer for this task.
I like the idea of this task and most of the examples are good, but I think the quality can generally be somewhat higher for many of the examples. I'm seeing many examples that are ambiguous or unclear, or which have issues, such as those indicated below. Could you please take a pass through as many of these as possible to address these classes of issues?
Dianne has a yoga class in 20 minutes and the gym is close by so she does 10 minutes of stretches instead of the 5 minutes to make the class on time.
This is marked as False, which I'm not sure I agree with. The gym is close by, so she could plausibly stretch for longer.
Joe's podcast is released around the same time as Adam's live radio. Kevin being a fan of both is likely to go for Adam at that time
This is labelled True, but that's not obvious. Kevin is a fan of both. He would only go to the live radio show if he also prefers to be in a live audience instead of at home.
Ron is a religious person, while Jess is an atheist, so Jess is likely to donate more to abortion clinic.
This is labelled True, which doesn't seem correct, and this also doesn't even seem like a good association to emphasize in this sort of benchmark.
Since it is morning, I will make a pot of coffee.
She didn't have a notebook or pencil for art class so she took some plain paper and paint instead.
This are labelled True, and are not True or False statements.
John has three plants and a tree while Simon has three dogs. It is likely that John's house is more difficult to manage than John's.
Identified by the reviewer above.
People prefers answering the phone than listening to voice mail for spam calls.
It is still profitable to sell one glasses and zero umbrella within one hour.
The shorter the classes are, the less likely student swill be distracted.
Jane was really tired after a long day's work, so intead of staying up trying to get things done, she would rather sleep early and wake up early to continue the work
Ungrammatical / unconventional English / typos

Hi @StellaAthena and @vedant thank you both for pointing out the issues and sorry for my late reply (notifications was sent to an email address I rarely use due to the amount of spams). We will try our best to give all the examples one more check, however it will take some time and I wonder if we need to meet some kind of a deadline (so that we can plan accordingly)?

@nuankw officially, the deadline is long past at this point. Per the README, your metric can be merged into the benchmark but will not be included in the paper. My understanding is that the plan is to have a living benchmark that grows over time, though you’ll need to talk to a Google employee like @chiafullo for confirmation.

I'm one of the benchmark organizers.
Meta-reviewers are still in the process of merging tasks into the
repository, though we hope to finish this week. If you are able to address
your meta-reviewer's concerns in the next couple days, or possibly over the
weekend, then it will still be possible to include your task. Next week
will likely be too late for your task to be included in the v1 analysis and
paper though.
Thank you for your submission!
On Wed, Aug 4, 2021 at 2:22 PM Stella Biderman @.***>
wrote:

@nuankw https://github.com/nuankw officially, the deadline is long past
at this point. Per the README, your metric can be merged into the benchmark
but will not be included in the paper. My understanding is that the plan is
to have a living benchmark that grows over time, though you’ll need to talk
to a Google employee like @chiafullo https://github.com/chiafullo for
confirmation.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/BIG-bench/pull/417#issuecomment-892983727, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AADZW4A73QKHUIGNHJGNJELT3GVRHANCNFSM4555CLBA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

@StellaAthena @Sohl-Dickstein Thank you for the information. We will go over all the data and address all the concerns including the ones listed above by the end of this week.

@googlebot I fixed it.

Hi @Sohl-Dickstein @StellaAthena @vedant, we scrutinized all the examples with very high standard and made improvements wherever we can, including all the cases mentioned earlier. We sincerely hope this addresses your quality concern. Thanks!


sdl2: Add patch fixing non-threaded emscripten build

Describe the pull request

What does your PR fix?

Fixes regression introduced by changeset 5e7cbdceacd2b3cb85e057963fdb605136805bd3 where emscripten builds of sdl2 that do not use threading will fail during linking time with
error: undefined symbol: emscripten_sync_run_in_main_runtime_thread_ (referenced by top-level compiled C/C++ code)

Source of the fix here: https://github.com/libsdl-org/SDL/pull/5773

Which triplets are supported/not supported? Have you updated the CI baseline?
emscripten, Yes

Does your PR follow the maintainer guide?

Yes

LGTM, thanks!


Are NINCO and "popular subsamples" disjoint?

Hi,
A very thorough and solid work! I was wondering if the samples of NINCO and its "popular datasets subsamples" are different and disjoint? For example, do the samples in "popular datasets/Species" also appear in NINCO?
Thanks

Thanks for the kind words!
There are indeed some overlaps between the two datasets, as some of the NINCO classes are based on hand-sorting classes from these popular datasets.
I did a quick search and found the following 8 samples that are in both. It looks to me like this should be all, but my search could have overlooked some.
Sample 37 NINCO_popular_datasets_subsamples/Places/Places_037_f_field_road_00000842.jpg
is also in NINCO as sample 1607 NINCO_OOD_classes/f_field_road/f_field_road_015_00000842.jpg
Sample 38 NINCO_popular_datasets_subsamples/Places/Places_038_f_field_road_00000994.jpg
is also in NINCO as sample 1610 NINCO_OOD_classes/f_field_road/f_field_road_018_00000994.jpg
Sample 39 NINCO_popular_datasets_subsamples/Places/Places_039_f_field_road_00001581.jpg
is also in NINCO as sample 1630 NINCO_OOD_classes/f_field_road/f_field_road_038_00001581.jpg
Sample 40 NINCO_popular_datasets_subsamples/Places/Places_040_f_field_road_00002212.jpg
is also in NINCO as sample 1638 NINCO_OOD_classes/f_field_road/f_field_road_046_00002212.jpg
Sample 50 NINCO_popular_datasets_subsamples/Places/Places_050_f_forest_path_00000583.jpg
is also in NINCO as sample 1696 NINCO_OOD_classes/f_forest_path/f_forest_path_008_00000583.jpg
Sample 51 NINCO_popular_datasets_subsamples/Places/Places_051_f_forest_path_00002066.jpg
is also in NINCO as sample 1733 NINCO_OOD_classes/f_forest_path/f_forest_path_045_00002066.jpg
Sample 114 NINCO_popular_datasets_subsamples/Places/Places_114_s_sky_00003512.jpg
is also in NINCO as sample 3039 NINCO_OOD_classes/s_sky/s_sky_043_00003512.jpg
Sample 679 NINCO_popular_datasets_subsamples/Species/Species_143_sarracenia_alata_12212875.jpg
is also in NINCO as sample 3197 NINCO_OOD_classes/sarracenia_alata/sarracenia_alata_033_12212875.jpg
Best,
Julian

Awesome. Thanks for the information!


terraform-providers: update 2022-03-14

Description of changes
Manual update as the oci provider currently breaks the update script, the repo has moved but the provider-source-address hasn't been updated on the registry.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@ofborg build terraform-full

@ofborg build terraform-full


feat: add boost.concept_check

add boost.concept_check
need skip url stability check

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (boost.concept_check) have been updated in this PR. Please review the changes.


OSX run.sh "*.raw: No such file or directory"

Hello
I get this error when running the python script run.sh
/Users/sean_feeley/usr/local/torch/install/bin/luajit: ...ley/usr/local/torch/install/share/lua/5.1/trepl/init.lua:389: ...ley/usr/local/torch/install/share/lua/5.1/trepl/init.lua:389: ...y/usr/local/torch/install/share/lua/5.1/cutorch/init.lua:2: cannot load '/Users/sean_feeley/usr/local/torch/install/lib/lua/5.1/libcutorch.so'
stack traceback:
	[C]: in function 'error'
	...ley/usr/local/torch/install/share/lua/5.1/trepl/init.lua:389: in function 'require'
	main.lua:12: in main chunk
	[C]: in function 'dofile'
	...ocal/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:150: in main chunk
	[C]: at 0x010729ee70
ls: *.txt: No such file or directory
/Users/sean_feeley/usr/local/torch/install/bin/luajit: ...ley/usr/local/torch/install/share/lua/5.1/trepl/init.lua:389: ...ley/usr/local/torch/install/share/lua/5.1/trepl/init.lua:389: ...y/usr/local/torch/install/share/lua/5.1/cutorch/init.lua:2: cannot load '/Users/sean_feeley/usr/local/torch/install/lib/lua/5.1/libcutorch.so'
stack traceback:
	[C]: in function 'error'
	...ley/usr/local/torch/install/share/lua/5.1/trepl/init.lua:389: in function 'require'
	process.lua:16: in main chunk
	[C]: in function 'dofile'
	...ocal/torch/install/lib/luarocks/rocks/trepl/scm-1/bin/th:150: in main chunk
	[C]: at 0x0101c58e70
ls: *.raw: No such file or directory

I am running on OSX.
Looking through the other Issues, I can see that the download script has been an issue before. I've run the download script multiple times to the same effect. Bellow is the structure of my vrn folder.
.
├── LICENSE
├── README.org
├── docker
│   ├── Dockerfile
│   └── installation.sh
├── download.sh
├── examples
│   ├── AFLW_image00046.jpg
│   ├── AFLW_image00095.jpg
│   ├── AFLW_image00190.jpg
│   ├── AFLW_image00656.jpg
│   ├── asj.jpg
│   └── scaled
├── face-alignment
│   ├── 2D-FAN-300W.t7
│   ├── LICENCE
│   ├── README.md
│   ├── facedetection.lua
│   ├── facedetection_dlib.lua
│   ├── main.lua
│   ├── opts.lua
│   └── utils.lua
├── output
├── process.lua
├── raw2obj.py
├── readvol.m
├── rendervol.m
├── run.m
├── run.sh
├── vis.py
└── vrn-unguided.t7

luarocks install cutorch should sort that out. You have an Nvidia GPU don't you?

Ah... that might be it.
My studio doesn't have any NVIDIA mac's so I think I'll need to a install a CENTOS 7 duel boot on one of our NVIDIA PCs.
Thanks for your quick response.


Can't run the client mode of example simple

It's a minor issue. cargo run --example simple can't run the client mode, as if matches.contains_id("server") is always true .
https://github.com/mcginty/snow/blob/009411d2035a77ece57b0a6873169de7693a0aa0/examples/simple.rs#L27-L36
After checking the source code of clap, it turns out the macro arg! always insert a SetTrue action to the arg which makes contains_id always return true.
https://github.com/clap-rs/clap/blob/cbc9c9dd44fc4be25c196213d508b9d2a9c282f3/clap_builder/src/macros.rs#L204C27-L204C27

Funnily enough my https://github.com/mcginty/snow/pull/175 cleanup PR would fix this as well.


Pathed setup

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

343 of 453 (75.72%)  changed or added relevant lines in 5 files are covered.
4 unchanged lines in 2 files lost coverage.
Overall coverage increased (+17.3%) to 45.026%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/rpc.rs
0
14
0.0%

src/engine/config.rs
68
86
79.07%

src/engine/blst.rs
267
299
89.3%

src/main.rs
0
46
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/rpc.rs
1
2.93%

src/main.rs
3
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
17.3%

Covered Lines:
353

Relevant Lines:
784

💛  - Coveralls


error after: Do you want to set up Aquarea Smart Cloud? > Config flow could not be loaded: {"message":"Invalid handler specified"}

I followed these steps:
Download the integration via (one of them):
Open your Home Assistant instance and open a repository inside the Home Assistant Community Store.
Go to HACS > Integrations > Look for "Aquarea"
Restart Home Assistant
Add integration via (one of them):
Open your Home Assistant instance and start setting up a new integration.
Go to "Settings" >> "Devices & Services", click "+ ADD INTEGRATION" and select "Aquarea Smart Cloud"
and here I cant pass the config flow error. its HA in a docker @ raspberry 4
Any thoughts?

I think a reboot fixed the issue!


No spacing between examples after Update-MarkdownHelpModule

Steps to reproduce
New-MarkdownHelp -Module $module -OutputFolder $moduleFolder -WithModulePage -AlphabeticParamsOrder
Update-MarkdownHelp $moduleFolder -AlphabeticParamsOrder

Expected behavior
###Example 1: Foo
PS C:\> Foo

This command does foo.
###Example 2: Bar
PS C:\> Bar

This command does bar.
###Example 3: Temp
Actual behavior
###Example 1: Foo
PS C:\> Foo

This command does foo.
###Example 2: Bar
PS C:\> Bar

This command does bar.
###Example 3: Temp
Note: I removed the spacing between '###' and 'Example' because markdown will convert it to look as it should, but when Get-HelpPreview is ran on the corresponding MAML, there is no spacing as seen above.
Environment data

v0.7.0

Thank you @cormacpayne for reporting the issue!
In regard to your Note, you can use markdown code snippets (with three backticks) to tell github to keep text as-is, without applying markdown formatter. For example
### Example 1: Foo

PS C:\> Foo
This command does foo.
### Example 2: Bar

PS C:\> Bar
This command does bar.
### Example 3: Temp

This is fixed per 15d62cb6044b779c5f7072daa4e25f73212d27c7


Update type annotations

Some improvements to type annotations as best I could work out.

This is still in draft state, right? @matthewdouglas
No rush, but happy to merge once ready.

Superseded by newer PRs.


[Docs] Fixing broken repository links

Fixes #9873

Can one of the admins verify this patch?

Looks good. Thanks for submitting!
@caisq: I've previously submitted a bug internally for this (b/37962228) since we would like the internal links to point to the internal code. However, I'd say fixing these broken links for now is a higher priority.

@nealwu, thanks for the review. Understood. Will merge this PR pending tests passing.

@tensorflow-jenkins test this please.

I couldn't add another commit here since I happened to have made this quickly on GH site so I made
another PR to address one last old link #9886

Just realized this PR was merged into the r1.1 branch rather than into master. I'm submitting another PR to revert this on the r1.1 branch as well: https://github.com/tensorflow/tensorflow/pull/9990

@nealwu Thank you. I noticed that some fixes already present on master were not on tensorflow.org which apparently was following at least branch r1.1 so I decided at the time submit to the latter to reflect these changes on the website tutorials.

I see. In the future it's typically best to submit to master first and then ask us to cherry-pick the changes into the appropriate release branch. That way we avoid the situation where we merge into the release branch but end up forgetting to merge into master.

Good to know, thank you for the insight!


Support Xcode 13

Motivation:
https://developer.apple.com/documentation/corebluetooth/cbservice/1434334-peripheral?changes=latest_minor
Weirdly enough, for macOS it's still unowned/unsafe.


Use topkg.

https://github.com/ocaml/opam-repository/pull/4938/files#r41636728

I will never do this unless I'm completely forced, so stop fooling myself.


Make reset betting streak much faster/lighter

no longer needs 4gb and runs in 5 seconds

pushed to dev to test


Don't automatically calculate diff between two branches in compare view

Gitea version (or commit ref): 1.3
Git version: n/a
Operating system: n/a
Database (use [x]):

[x ] PostgreSQL
[x ] MySQL
[x ] MSSQL
[x ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[ ] No

Log gist:

Description
When opening the compare-Page (to create a pull request or just compare two branches) the diff is calculated automatically.
If you're now changing one of the branches (head or base) gitea will automatically reload the page and calculate the diff again.
Depending on the amount of changes this may take a while.
Idea or suggestion would be to introduce a new "Calculate changes" button that triggers a page reload and thus prevents useless diff calculations on wrong selection of a branch or when you need to change both branch values.
In order to not break any existing workflows i'd suggust to calculate the diff when opening the page with two branches selected directly and just enable the calculate changes button when a branch is changed.
I did a first working prototype - please see attached screenshots.
Should I open a pull request for this or do you think this isn't a good idea?
Screenshots
Initial layout of the page (when opened with two branches the diff is displayed)

After a branch is changed the diff will be removed and just a short hint is displayed:

Hmm, maybe it's better to lazy load diff views like gh. which means user can click Create pull request button without waiting diff views loading.
/cc  @silverwind @CirnoT

I believe lazy loading would be the only acceptable solution here, this is huge part of UI and hiding it behind user-interacatable button is something I'd rather not do.

Loading the diff lazy sounds like a good alternative.
Maybe the manual diff calculation could reduce some server loads but the lazy loading feels more like the gh ui approach.

This current automatic diff calculation is painful when you want to create a PR that does not target the master branch, e.g. for a backport to a release branch. A huge diff is calculated against the master branch first. And the "merge into" dropdown seems unresponsive until the page has completely finished loading.

@sebastian-sauer
Did you do anything on your side in the end?

@jpraet
Sorry to bug you but any idea if this will make it to any of the future releases?
Large repos are still suffering from that and I don't see any way to improve that...
Cheers

In gitea 1.16 it eagerly loads the first MAX_GIT_DIFF_FILES (configurable in app.ini, defaults to 100), and has a "Show More" button to load the next 100 files. You could reduce the value of this parameter in your configuration.

Thank you!

Don't think this parameter can be changed (not seeing anything in the cheat sheet)

Sounds like #6900

We can split this configuration into two, one is for comparison, and the other is for pull request files. So that users could reduce the parameters to make compare faster in the first time load.
[git]
;MAX_GIT_DIFF_LINES = 1000
;;
;; Max number of allowed characters in a line in diff view
;MAX_GIT_DIFF_LINE_CHARACTERS = 5000
;;
;; Max number of files shown in diff view
;MAX_GIT_DIFF_FILES = 100


Proposals for new entries

Hi @umarcor I think that this issue can be used as a Pinned issue, to discuss to add new awesome projects.
To inaugurate it, what about:

[x] pp4fpgas (Parallel Programming for FPGAs) (a CC-BY-4.0 book about HLS).
[x] Mutation Cover with Yosys (MCY) (or maybe to be included as a reference for SBY?)
[x] LibreCores: el correo libre as a monthly publication.
[x] Also, I was thinking about RISC-V, as a whole (to avoid hundreds/thousands of entries ). I mean, to have the RISC-V entry, and a lot of references to related awesome projects.

[ ] chips4makers (#173)

I think that adding pp4fpgas is ok. MCY would fit as a reference inside Symbiyosys. LibreCores would fit as a reference inside Librecores. With regard to RISC-V, I'm not sure. I believe it should be split into multiple projects. The relevance is whether the project contains tools, cores, frameworks, etc. Not the specific architecture. That's a tag.

[ ] Princeton Reconfigurable Gate Array (web)

Hello @umarcor requested that I propose adding PipelineC to hdl/awesome.
I wasnt sure if that meant a pull request or comment here. I prepared what I think was requested: a markdown with some yaml
pipelinec.md
Thanks for the opportunity to share info about PipelineC!
Let me know if there is anything else you need

(I didnt know what to put in the 'Talk' field?)

It's the number of a "Discussion". I created https://github.com/hdl/awesome/discussions/228, so the number of the PipelineC "talk" is 228.

I wasnt sure if that meant a pull request or comment here. I prepared what I think was requested: a markdown with some yaml

A PR would be good, but this is ok as well. The effort is actually filling the metadata (which you, as the author, know better). That was nicely detailed. Thanks!

https://hdl.github.io/awesome/items/pipelinec/
https://github.com/hdl/awesome/commit/d6bde3b1dda99ca8f6f849d1760507d308b6d77a

Thanks for the opportunity to share info about PipelineC!

Thank you for building and sharing awesome projects!

Let me know if there is anything else you need

Feel free to share other awesome references you know, or to improve the descriptions/metadata of the items.
We try not to add "all of our own stuff", but either add projects from others, or wait until someone else asks us to add ours.

I would have definitely suggested Silice if it was not already there - and I poked the author of https://dfianthdl.github.io/ on Twitter just now - two of my favorite alternative HDLs - they have some fancier features than regular HDL, but aren't going all HLS on ya :+1:

https://www.pygears.org/ is an interesting project for sure.

@JulianDeepwave indeed! Wanna propose a PR? See e.g. https://github.com/hdl/awesome/commit/d6bde3b1dda99ca8f6f849d1760507d308b6d77a

https://www.pygears.org/ is an interesting project for sure.

Apologies for the duplicate comment - problem having git accounts for work and personal on same pc.
I should have some time to put together a markdown file - might try to reach out to the author of the pygears proj first

Hopefully ok if I give a basic markdown with some info:
pygears.md
hoping to get some pygears folks eyes on this to adjust the verbiage/contribute

@JulianKemmerer Thanks for sending me a message about this, I just made a pull request: https://github.com/hdl/awesome/pull/229
P.S I'm not a fully technical person so maybe I did something wrong here, let me know if I should change something :)


Added WriteConcern as a param for dataset

What changes are proposed in this pull request?
For Mongo write operations, WriteConcern is an argument that controls the process of write operations from the client side. Setting the value of w=0 for WriteConcern allows the client to terminate early without waiting for the rest of the clusters to confirm write operations.
For more information on WriteConcern: https://www.mongodb.com/docs/manual/reference/write-concern/
Similarly related, ReadConcern: https://www.mongodb.com/docs/manual/reference/read-concern/
How is this patch tested? If it is not, please explain why.

Manual test (✅ )

Release Notes
Is this a user-facing change that should be mentioned in the release notes?

[x] No. You can skip the rest of this section.
[ ] Yes. Give a description of this change to be included in the release
notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
What areas of FiftyOne does this PR affect?

[ ] App: FiftyOne application changes
[ ] Build: Build and test infrastructure changes
[x] Core: Core fiftyone Python library changes
[ ] Documentation: FiftyOne documentation changes
[ ] Other

Summary by CodeRabbit

New Features

Enhanced index creation with options for acknowledgment and completion wait, allowing users more control during index creation.
Improved handling of MongoDB write operations, providing greater flexibility in dataset management through customizable write concerns.

Bug Fixes

Resolved issues related to collection statistics retrieval by ensuring consistent application of write concerns.

Documentation

Updated method documentation to clarify the new parameters and their intended use.

We can set a global write concern argument her: https://www.mongodb.com/developer/products/mongodb/global-read-write-concerns/

@brimoor : setting WriteConcern(w=0) does what we want it to do, but I am still learning more about WriteConcern & ReadConcern :)
Normal index creation is slow for 10M dataset:
https://www.loom.com/share/3df7adf8ce0943d1b376a01fa4f07e22?sid=c87c3c15-0eca-416f-939c-051e61b0824f
Setting w=0 for WriteConcern allows the command to exit:
https://www.loom.com/share/9ec56cce87244656a5b1943d74ba03cb?sid=6d83e741-9747-469c-8508-0e43ea2efc2b
I also discovered certain operations, such as dataset.summary() will hang and wait until index creation is finished. Probably because we are running dataset.count() in the summary.


omsadmin.sh Option Breaking omsagent

While troubleshooting omsagent issues, one of the troubleshooting steps in multiple Microsoft documents suggests to execute omsadmin.sh -l to check the status of the agent. This is also executed in other scripts as well to check on the status and to see if it's onboarded/registered.
I found that executing omsadmin.sh is causing the omsagent to enter a non-stop restart loop, and it's returning that the omsagent is not running when it was:
mysql/b3f6985d-e4c6-45a8-b592-bfa515ebbeee:~# /opt/microsoft/omsagent/bin/omsadmin.sh -l
Primary Workspace: xxx-xxx-xxx-xxx-xxx    Status: Warning(OMSAgent Registered, Not Running)

mysql/b3f6985d-e4c6-45a8-b592-bfa515ebbeee:~# for i in $(seq 1 5); do cat /var/vcap/sys/run/omsagent/omsagent.pid && echo; sleep 5; done
13292
13452
13452
13615
13615

mysql/b3f6985d-e4c6-45a8-b592-bfa515ebbeee:~# for i in $(seq 1 5); do cat /var/vcap/sys/run/omsagent/omsagent.pid && echo; sleep 5; done
15845
16010
16010
16168
16168

When you execute omsadmin.sh -l, it sets LIST_WORKSPACES=1.
When this is set to 1, it executes the function list_workspaces.
list_workspaces executes show_workspace_status for the current workspace detected.
show_workspace_status then executes the SERVICE_CONTROL script:

$SERVICE_CONTROL is-running $ws_id

This variable refers to:

# Service Control script
SERVICE_CONTROL=/opt/microsoft/omsagent/bin/service_control

This file is a symlink to the omsagent-ctl script:

mysql/b3f6985d-e4c6-45a8-b592-bfa515ebbeee:~# ls -la /opt/microsoft/omsagent/bin/service_control
lrwxrwxrwx 1 root root 40 Dec 16 16:33 /opt/microsoft/omsagent/bin/service_control -> /var/vcap/jobs/omsagent/bin/omsagent-ctl

The is-running option for omsagent-ctl executes is_process_running function, which is pulled in from the utils.sh again.

is_process_running()
{
    PIDFILE=$1
    # Returns 1 if 'omsagent' is running, 0 otherwise
    [ -f $PIDFILE ] || return 0
    ps -p `cat $PIDFILE` | grep -q omsagent
    STATUS=$?

    # Kill PID file if we're not running any longer
    if [ $STATUS -ne 0 ]; then
        rm -f $PIDFILE
        return 0
    else
        return 1
    fi
}

This function pulls the PID from the pidfile and looks for omsagent.
If it's not found, it runs an rm on the pidfile, thus explaining the constant restarting of omsagent.
The problem here is the CMD being different, thus breaking grep -q omsagent:

mysql/b3f6985d-e4c6-45a8-b592-bfa515ebbeee:~# ps -p $(cat /var/vcap/sys/run/omsagent/omsagent.pid)
  PID TTY          TIME CMD
21420 ?        00:00:07 ruby

Two ways to fix this:

Modify the the grep to grep -q "omsagent\|ruby" which would check for either.

On normal systems the CMD line is omsagent, so I'm leaning against this.

Modify the startup script at /var/vcap/jobs/omsagent/bin/omsagent-ctl:

$RUBY_BIN $OMS_BIN -d $PID_FILE -o $LOG_FILE --no-supervisor -c $OMSAGENT_CONF --user omsagent --group omiusers

If we change the above startup execution and remove the $RUBY_BIN it'll stop showing ruby as the CMD.
There shouldn't be any issues removing the reference to $RUBY_BIN since the shebang is identical, and $OMS_BIN is executable

All that being said, going with option 1 and adjusting the grep -q would be the safest method.

Merged will close after we cut a release and test.

Looks like this was able to install post-merge.  Closing.


Natural breaks tidy up

Fixes # No issue associated with this.
Checklist

[ ] I have included examples or tests
[ ] I have updated the change log
[ ] I am listed in the CONTRIBUTORS file
[ ] I have cleaned up the commit history (use rebase and squash)

Changes proposed in this pull request:
Simple update to the FeatureScheme.cs to consistently recreate break values. This only affects symbology when computing breaks on very large data sets. In this case a random subsample of the data is used for the break calculation. This is unnerving to the end users when they see the break values change slightly each time they are recomputed. Using a common random seed here means that the same subsample will be used each time the same dataset is symbolized.

@danames please update the changelog and let me know when you're done so we can merge.

OK I think I did this right now... Hopefully :) I created an issue for this fix (#1242) then marked that in the change log which I also committed to this same branch. I may need to do a new pull request now that the change log is updated? Still learning Git...

@danames If you have a look at the Commits and the Files changed you'll see that your changes are already attached to this pull request.


Using AWS

Is it possible to use AWS Postgresql for this database?

Yes.

If you'd like more help, then that's OK, but you'll need to help us help you. Please include more details about what you've tried, what you expected to happen and what actually happen. Please also include as much details about your setup/environment as possible.

The issue I am currently having is I have created an RDS instance on AWS and am connecting to it from DataGrip, but when I try to import the data into Postgres, it fails halfway through. Should I not be using DataGrip? Should I use pgAdmin instead?

I don't know what DataGrip is. I'm sorry, but you're going to need to provide a lot more information. How does it fail? What output did you see? What commands did you run? What OS are you running nfldb on? How did you install it?

@bhavik3jain Have you read the installation instructions? They should work with any PostgreSQL installation.

I am running this on a mac, do you suggest I should do this entirely through command line interface?

Please follow the installation instructions. I can't help you otherwise because you're not giving enough details. Sorry.

@bhavik3jain This is what you want - http://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/PostgreSQL.Procedural.Importing.html
Through your Terminal/Command Line use the command:
psql
-f mydb2dump.sql
--host mypginstance.c6c8mntzhgv0.us-west-2.rds.amazonaws.com
--port 8199
--username myawsuser
--password password
--dbname mydb2
Thanks for the awesome resources, @BurntSushi I love this stuff.

Yes this is exactly what I needed. Thanks so much


Testing new Language Server

@MikhailArkhipov You might want to keep an eye on the following repo https://github.com/octref/vscode-language-server-e2e-test
Perhaps we can reuse something from there.

PTVS repo has bunch of LS tests we just need to separate test utility project into Windows/Core parts and add .NET Core tests to the LS project per https://github.com/Microsoft/PTVS/issues/4185.
However, the above may come useful as a semi-integration test.


EditableText.onSubmitted silently absorbs thrown errors

This error shows up with a TextField given an onSubmitted or a TextFormField given an onFormSubmitted. When an error is thrown within the passed method, the error is silently discarded. This appears to be from the MethodChannel._handleAsMethodCall try/catch that wraps the error in a platform message. Details are in this StackOverflow answer.
To reproduce:
import 'package:flutter/material.dart';

void main() => runApp(Test());

class Test extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: Center(
          child: TextField(
            textInputAction: TextInputAction.next,
            onSubmitted: (_) {
              print('before error');
              throw Exception('danger will robinson');
              print('after error');
            },
          ),
        ),
      ),
    );
  }
}

When the text in the field is submitted (by tapping the next button on the device keyboard for mobile or pressing the enter key for web/desktop), the log outputs the following:
flutter: before error

Result of flutter doctor -v:
[✓] Flutter (Channel stable, 1.20.3, on Mac OS X 10.15.6 19G2021, locale en-US)
    • Flutter version 1.20.3 at /Users/*****/Library/Flutter
    • Framework revision 216dee60c0 (2 weeks ago), 2020-09-01 12:24:47 -0700
    • Engine revision d1bc06f032
    • Dart version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/*****/Library/Android/sdk
    • Platform android-29, build-tools 28.0.3
    • ANDROID_HOME = /Users/*****/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.7)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.7, Build version 11E801a
    • CocoaPods version 1.8.4

[✓] Android Studio (version 3.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 25.0.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[✓] VS Code (version 1.49.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.14.1

[✓] Connected device (1 available)
    • Dev iPhone (mobile) • 65301ff37867fe1b1ef12a5793125d88c193d473 • ios • iOS 13.7

• No issues found!

This may be related to #16941.

I was able to reproduce on latest stable and master channel.
flutter doctor -v (stable)
[✓] Flutter (Channel stable, 1.20.4, on Mac OS X 10.15.6 19G2021, locale en)
    • Flutter version 1.20.4 at /Users/pedromassango/dev/SDKs/flutter_stable
    • Framework revision fba99f6cf9 (2 days ago), 2020-09-14 15:32:52 -0700
    • Engine revision d1bc06f032
    • Dart version 2.9.2

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.7)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.7, Build version 11E801a
    • CocoaPods version 1.9.3

[!] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2020.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 49.0.4
    • Dart plugin version 202.7319.5

[✓] VS Code (version 1.48.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.14.1

[✓] Connected device (1 available)
    • iPhone 11 Pro Max (mobile) • 3DA251B5-C982-48C8-8FF5-C4D1DB21ED89 • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-7 (simulator)

! Doctor found issues in 1 category.

flutter doctor -v (master)
[✓] Flutter (Channel master, 1.22.0-10.0.pre.221, on Mac OS X 10.15.6 19G2021 x86_64, locale en)
    • Flutter version 1.22.0-10.0.pre.221 at /Users/pedromassango/dev/SDKs/flutter_master
    • Framework revision fa646339d6 (7 hours ago), 2020-09-16 17:47:04 -0700
    • Engine revision 933f811d94
    • Dart version 2.10.0 (build 2.10.0-135.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.1)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.7)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.7, Build version 11E801a
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[!] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    ✗ Flutter plugin not installed; this adds Flutter specific functionality.
    ✗ Dart plugin not installed; this adds Dart specific functionality.
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2020.2.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 49.0.4
    • Dart plugin version 202.7319.5

[✓] VS Code (version 1.48.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.14.1

[✓] Connected device (4 available)
    • iPhone 11 Pro Max (mobile) • 3DA251B5-C982-48C8-8FF5-C4D1DB21ED89 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-13-7 (simulator)
    • macOS (desktop)            • macos                                • darwin-x64     • Mac OS X 10.15.6 19G2021 x86_64
    • Web Server (web)           • web-server                           • web-javascript • Flutter Tools
    • Chrome (web)               • chrome                               • web-javascript • Google Chrome 85.0.4183.102

! Doctor found issues in 1 category.
Process finished with exit code 0

It seems like these errors are being swallowed by this try/catch:
https://github.com/flutter/flutter/blob/549de844ed2c3af17e6a2cd359e33513b43c6293/packages/flutter/lib/src/services/platform_channel.dart#L429-L441
I've got a PR open with an idea for a fix, but I'm trying to validate it. https://github.com/flutter/flutter/pull/66851


Update readme and add RFC template.

Apologies I just mistyped and accidentally merged the PR. I reverted but we need to continue our discssion over here https://github.com/googlecartographer/rfcs/pull/2.
Sorry about that. I reconfigured the repo and master is now a protected branch.


Docs improvements

Found that the example code in the README needed a small fix, made some other minor improvements.

Thanks for fixing, I've merged both pulls


Question: How do I access Key Store Keys in a playbook?

Question
I have created a Key in the Keystore for a db-user-password and picked login with password while keeping the optional Login empty.
Now I need to access this key through a var in a Playbook to connect to a database.
The documentation is not showing how to do that, also #919 and #972 explain how to store it in the UI, but not how to reference the Key in a playbook.
Is this even possible?
I tried something like:
- name: Key Store access
  hosts: my_host

  tasks:
    - name: print key
      debug:
        msg: "{{ lookup('env', 'SECRET_KEY') }}"

Related to
Documentation

Same problem. We want to securely distribute ssh private keys across numerous servers. But stuck with unclear vault use cases.


Avoid multiples classpath scanning on actor spawning

Currently, if the client makes multiple requests to the spawn method, the sdk will repeatedly perform classpath scanning via the getEntities() method of the ActorClassGraphEntityScan class, searching for classes annotated with ActorEntity. This of course is completely unnecessary.
These multiple calls add unnecessary latency and ideally, calls to the getEntities method are avoided.

Closed by 3c57a2bf2d1627fe8fec657f2be6374130725d91
Results:
Start and Spawning one actor test
Before
2023-01-07 19:23:39.438  INFO 23970 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 325ms
2023-01-07 19:24:40.055  INFO 24088 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 598ms
2023-01-07 19:25:02.459  INFO 24212 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 316ms
2023-01-07 19:25:22.192  INFO 24333 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 449ms

After
2023-01-07 19:26:24.612  INFO 24465 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 15ms
2023-01-07 19:26:44.458  INFO 24576 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 22ms
2023-01-07 19:27:03.255  INFO 24676 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 22ms
2023-01-07 19:27:21.138  INFO 24791 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 30ms

Start and Spawning ten actor test
Before
2023-01-07 19:29:02.115  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Starting App using Java 17.0.1 on pop-os with PID 24909 (/home/sleipnir/workspaces/eigr/spawn-springboot-sdk/spawn-springboot-examples/target/classes started by sleipnir in /home/sleipnir/workspaces/eigr/spawn-springboot-sdk)
2023-01-07 19:29:02.119  INFO 24909 --- [           main] io.eigr.spawn.example.App                : No active profile set, falling back to 1 default profile: "default"
2023-01-07 19:29:04.164  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: AbstractActor
2023-01-07 19:29:04.166  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: joe
2023-01-07 19:29:04.717  INFO 24909 --- [           main] o.s.b.web.embedded.netty.NettyWebServer  : Netty started on port 8090
2023-01-07 19:29:04.844  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Started App in 3.227 seconds (JVM running for 3.766)
2023-01-07 19:29:04.852  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Let's spawning Actor concreteActor-0
2023-01-07 19:29:05.193  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: AbstractActor
2023-01-07 19:29:05.194  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: joe
2023-01-07 19:29:05.222  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 370ms
2023-01-07 19:29:05.223  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Let's spawning Actor concreteActor-1
2023-01-07 19:29:05.504  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: AbstractActor
2023-01-07 19:29:05.504  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: joe
2023-01-07 19:29:05.510  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 287ms
2023-01-07 19:29:05.510  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Let's spawning Actor concreteActor-2
2023-01-07 19:29:05.785  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: AbstractActor
2023-01-07 19:29:05.785  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: joe
2023-01-07 19:29:05.791  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 281ms
2023-01-07 19:29:05.792  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Let's spawning Actor concreteActor-3
2023-01-07 19:29:06.085  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: AbstractActor
2023-01-07 19:29:06.085  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: joe
2023-01-07 19:29:06.090  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 298ms
2023-01-07 19:29:06.090  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Let's spawning Actor concreteActor-4
2023-01-07 19:29:06.348  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: AbstractActor
2023-01-07 19:29:06.348  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: joe
2023-01-07 19:29:06.363  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 273ms
2023-01-07 19:29:06.363  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Let's spawning Actor concreteActor-5
2023-01-07 19:29:06.664  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: AbstractActor
2023-01-07 19:29:06.665  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: joe
2023-01-07 19:29:06.670  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 307ms
2023-01-07 19:29:06.671  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Let's spawning Actor concreteActor-6
2023-01-07 19:29:06.977  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: AbstractActor
2023-01-07 19:29:06.978  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: joe
2023-01-07 19:29:06.984  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 313ms
2023-01-07 19:29:06.984  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Let's spawning Actor concreteActor-7
2023-01-07 19:29:07.731  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: AbstractActor
2023-01-07 19:29:07.732  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: joe
2023-01-07 19:29:07.738  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 753ms
2023-01-07 19:29:07.743  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Let's spawning Actor concreteActor-8
2023-01-07 19:29:08.238  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: AbstractActor
2023-01-07 19:29:08.238  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: joe
2023-01-07 19:29:08.254  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 510ms
2023-01-07 19:29:08.254  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Let's spawning Actor concreteActor-9
2023-01-07 19:29:08.608  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: AbstractActor
2023-01-07 19:29:08.609  INFO 24909 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: joe
2023-01-07 19:29:08.630  INFO 24909 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 375ms

After
2023-01-07 19:31:07.036  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Starting App using Java 17.0.1 on pop-os with PID 25373 (/home/sleipnir/workspaces/eigr/spawn-springboot-sdk/spawn-springboot-examples/target/classes started by sleipnir in /home/sleipnir/workspaces/eigr/spawn-springboot-sdk)
2023-01-07 19:31:07.047  INFO 25373 --- [           main] io.eigr.spawn.example.App                : No active profile set, falling back to 1 default profile: "default"
2023-01-07 19:31:09.129  INFO 25373 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: AbstractActor
2023-01-07 19:31:09.131  INFO 25373 --- [           main] i.e.s.s.s.i.ActorClassGraphEntityScan    : Registering Actor: joe
2023-01-07 19:31:09.676  INFO 25373 --- [           main] o.s.b.web.embedded.netty.NettyWebServer  : Netty started on port 8090
2023-01-07 19:31:10.050  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Started App in 3.507 seconds (JVM running for 4.008)
2023-01-07 19:31:10.057  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Let's spawning Actor concreteActor-0
2023-01-07 19:31:10.076  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 18ms
2023-01-07 19:31:10.077  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Let's spawning Actor concreteActor-1
2023-01-07 19:31:10.080  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 3ms
2023-01-07 19:31:10.081  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Let's spawning Actor concreteActor-2
2023-01-07 19:31:10.086  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 5ms
2023-01-07 19:31:10.087  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Let's spawning Actor concreteActor-3
2023-01-07 19:31:10.091  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 4ms
2023-01-07 19:31:10.092  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Let's spawning Actor concreteActor-4
2023-01-07 19:31:10.097  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 5ms
2023-01-07 19:31:10.098  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Let's spawning Actor concreteActor-5
2023-01-07 19:31:10.103  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 5ms
2023-01-07 19:31:10.104  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Let's spawning Actor concreteActor-6
2023-01-07 19:31:10.107  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 3ms
2023-01-07 19:31:10.108  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Let's spawning Actor concreteActor-7
2023-01-07 19:31:10.113  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 4ms
2023-01-07 19:31:10.114  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Let's spawning Actor concreteActor-8
2023-01-07 19:31:10.117  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 3ms
2023-01-07 19:31:10.118  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Let's spawning Actor concreteActor-9
2023-01-07 19:31:10.125  INFO 25373 --- [           main] io.eigr.spawn.example.App                : Spawning Actor Time Elapsed: 7ms


SEGFAULT at runtime

segfault at runtime, need to find out what is causing this and refactor

Need to add const to functions where values passed should not change, this may help stabilize memory segmentation.

Need to pass by reference wherever possible, may also help stabilize memory segmentation.

modified all function params to pass by constant reference (const int& pid) etc.


feat: Support other currencies and measurements

Looks like hot garbage

Overall is this a win? Better functionality albeit hideous?

Too ugly, can't merge


Questions about IntegrationPoint

I am trying to develop a simple function that integrates a ParGridFunction over the entire pmesh.
Yes, ParLinearForm can be used to accomplish this simple task. I am developing some simple functions to get familiar with MFEM.
The following function gives correct integral results, however, I do not understand:

why does the IntegrationRule of order 2 * fe->GetOrder() - 1, instead of fe->GetOrder();
why const IntegrationPoint &ip = ir->IntPoint(dof); instead of const IntegrationPoint &ip = fe->GetNodes().IntPoint(dof);
why does const IntegrationPoint &ip = fe->GetNodes().IntPoint(dof); give 0 value for ip.weight

Thank you very much for your help.

double integ = 0.0;
const FiniteElement *fe;
ElementTransformation *T;
Array dofs;
int elndofs;
Vector vel;
FiniteElementSpace *fes = u.FESpace();
for (int i = 0; i < fes->GetNE(); i++){
fes->GetElementVDofs(i, dofs);
fe = fes->GetFE(i);
T  = fes->GetElementTransformation(i);
elndofs = fe->GetDof();
const IntegrationRule *ir = &(gll_rules.Get(fe->GetGeomType(), 2 * fe->GetOrder() - 1));
for (int dof = 0; dof < elndofs; dof++){
const IntegrationPoint &ip = ir->IntPoint(dof);
//       const IntegrationPoint &ip = fe->GetNodes().IntPoint(dof);
T->SetIntPoint(&ip);
integ += u(dofs[dof]) * ip.weight * T->Weight();
}
}
double global_integral = 0.0;
MPI_Allreduce(&integ,
&global_integral,
1,
MPI_DOUBLE,
MPI_SUM,
u.ParFESpace()->GetComm());

Hi @Watchmojo ,
I think you are confused between the nodes of the basis functions associated to the Lagrange polynomials, and the quadrature points and weights associated with the quadrature rule.

Hi @Watchmojo , I think you are confused between the nodes of the basis functions associated to the Lagrange polynomials, and the quadrature points and weights associated with the quadrature rule.

Thank you for the clarification. I thought that the basis function


Corrected tarball URL

Download fixed

This change makes no sense to me. Let's take 5.5.15 as example.
You are proposing to download the file https://github.com/WoltLab/WCF/archive/refs/tags/5.5.15 (because $REF is just the version number) but that won't work, because this Url requires the extension .tar.gz at the end, otherwise it leads to 404.
Now, if you do so, and use https://github.com/WoltLab/WCF/archive/refs/tags/5.5.15.tar.gz to download the archive, you may notice, that a redirect is performed. The target will now be https://codeload.github.com/WoltLab/WCF/tar.gz/refs/tags/5.5.15
Therefore, the correct, final Url is https://codeload.github.com/WoltLab/WCF/tar.gz/refs/tags/$REF, and not https://github.com/WoltLab/WCF/archive/refs/tags/$REF.
The question is: What did you set as WSC_VERSION?


Show full live photo size in inspect

Is your feature request related to a problem? Please describe.
When inspecting a live photo, it shows the size only of the .heic file, but not of the corresponding .mov file.
Describe the solution you'd like
Show the size like `2.32 MB (Photo)  |  4.21 MB (Live Video)
Describe alternatives you've considered
Finding the files in Finder and checking the size that way.

Good suggestion -- thanks!

If I do this for Live photos, might also want to do for RAW photos.

@all-contributors please add @infused-kim  for ideas

Done, implemented in 0.50.7

Works perfectly.
I love that it also shows the file paths now, which I think is also new.
Thank you so much for implementing it so quickly!


HDFS-9913. DistCp to add -useTrash to move deleted files to Trash

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
75
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1327
trunk passed

+1
compile
28
trunk passed

+1
checkstyle
21
trunk passed

+1
mvnsite
30
trunk passed

+1
shadedclient
787
branch has no errors when building and testing our client artifacts.

+1
javadoc
21
trunk passed

0
spotbugs
45
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
43
trunk passed

_ Patch Compile Tests _

+1
mvninstall
25
the patch passed

+1
compile
23
the patch passed

+1
javac
23
the patch passed

-0
checkstyle
16
hadoop-tools/hadoop-distcp: The patch generated 6 new + 136 unchanged - 0 fixed = 142 total (was 136)

+1
mvnsite
26
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
828
patch has no errors when building and testing our client artifacts.

+1
javadoc
19
the patch passed

+1
findbugs
51
the patch passed

_ Other Tests _

-1
unit
834
hadoop-distcp in the patch failed.

+1
asflicense
28
The patch does not generate ASF License warnings.

4297

Reason
Tests

Failed junit tests
hadoop.tools.contract.TestLocalContractDistCp

Subsystem
Report/Notes

Docker
Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-974/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/974

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux cf29b11bc491 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 0766186

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-974/1/artifact/out/diff-checkstyle-hadoop-tools_hadoop-distcp.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-974/1/artifact/out/patch-unit-hadoop-tools_hadoop-distcp.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-974/1/testReport/

Max. process+thread count
305 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-974/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
75
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
@author
0
The patch does not contain any @author tags.

+1
test4tests
0
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+1
mvninstall
1238
trunk passed

+1
compile
29
trunk passed

+1
checkstyle
21
trunk passed

+1
mvnsite
31
trunk passed

+1
shadedclient
774
branch has no errors when building and testing our client artifacts.

+1
javadoc
21
trunk passed

0
spotbugs
46
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
42
trunk passed

_ Patch Compile Tests _

+1
mvninstall
27
the patch passed

+1
compile
24
the patch passed

+1
javac
24
the patch passed

-0
checkstyle
16
hadoop-tools/hadoop-distcp: The patch generated 1 new + 136 unchanged - 0 fixed = 137 total (was 136)

+1
mvnsite
26
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedclient
811
patch has no errors when building and testing our client artifacts.

+1
javadoc
20
the patch passed

+1
findbugs
49
the patch passed

_ Other Tests _

+1
unit
892
hadoop-distcp in the patch passed.

+1
asflicense
34
The patch does not generate ASF License warnings.

4232

Subsystem
Report/Notes

Docker
Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-974/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/974

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 46a9b8f0b152 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 304a47e

Default Java
1.8.0_212

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-974/2/artifact/out/diff-checkstyle-hadoop-tools_hadoop-distcp.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-974/2/testReport/

Max. process+thread count
342 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-974/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

@steveloughran @jojochuang  Could you please help to review this commit?

Production code looks good other than a few minor issues; commented more on the tests.
Have you run any of the object store tests runs (abfs, s3a, etc.)? Not a blocker but I'd prefer this, as otherwise I'll end up doing it

Thanks @steveloughran  for patient review!!  I had ran and passed all mentioned object stores(abfs, azure, s3a,adl, aliyun) unit tests. I will update commits according to you suggestions soon.

OK, +1 from me

committed; extracted your email address from the .patch file so that you are credited as the author of the patch.

Update: JIRA playing up so can't close the issue.
But I'm also getting a failure on my test run
[INFO] Running org.apache.hadoop.fs.s3a.scale.ITestS3AConcurrentOps
[ERROR] Tests run: 9, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 223.958 s <<< FAILURE! - in org.apache.hadoop.fs.contract.s3a.ITestS3AContractDistCp
[ERROR] testUpdateUseTrashDeepDirectoryStructureToRemote(org.apache.hadoop.fs.contract.s3a.ITestS3AContractDistCp)  Time elapsed: 20.398 s  <<< ERROR!
java.io.FileNotFoundException: about to be deleted file: not found s3a://hwdev-steve-ireland-new/user/stevel/.Trash in s3a://hwdev-steve-ireland-new/user/stevel
	at org.apache.hadoop.fs.contract.ContractTestUtils.verifyPathExists(ContractTestUtils.java:942)
	at org.apache.hadoop.fs.contract.ContractTestUtils.assertPathExists(ContractTestUtils.java:920)
	at org.apache.hadoop.fs.contract.ContractTestUtils.assertDeleted(ContractTestUtils.java:704)
	at org.apache.hadoop.fs.contract.ContractTestUtils.assertDeleted(ContractTestUtils.java:686)
	at org.apache.hadoop.tools.contract.AbstractContractDistCpTest.distCpUpdateUseTrashDeepDirectoryStructure(AbstractContractDistCpTest.java:358)
	at org.apache.hadoop.tools.contract.AbstractContractDistCpTest.testUpdateUseTrashDeepDirectoryStructureToRemote(AbstractContractDistCpTest.java:233)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.io.FileNotFoundException: No such file or directory: s3a://hwdev-steve-ireland-new/user/stevel/.Trash
	at org.apache.hadoop.fs.s3a.S3AFileSystem.s3GetFileStatus(S3AFileSystem.java:2837)
	at org.apache.hadoop.fs.s3a.S3AFileSystem.innerGetFileStatus(S3AFileSystem.java:2726)
	at org.apache.hadoop.fs.s3a.S3AFileSystem.getFileStatus(S3AFileSystem.java:2620)
	at org.apache.hadoop.fs.contract.ContractTestUtils.verifyPathExists(ContractTestUtils.java:936)
	... 21 more

I'll look at this a bit more and decide whether we should fix this with rollback vs another iteration of the PR

OK, cause is that the test setup calls assertDeleted() to clean up the trash dir, and the CTU check there actually fails if the file doesn't exist before the delete. Which is actually something we should question.
For now: reverted this PR so everything will be working before the US wakes up. I know it's a quick fix but I'd be depending on others to review, etc, etc and the failing test will be around for 24h minimum.
@asagjj : Can you submit an updated PR with the delete setup something like:
    Path trashRootDir = remoteFS.getTrashRoot(null);
    remoteFS.delete(trashRootDir, true);
    ContractTestUtils.assertPathDoesNotExist(remoteFS, "trash",  trashRootDir )

We don't need to worry about the before state or the return value of delete, just that the dir isn't there.
Thanks

@steveloughran  Sorry about that, I didn't reproduce this failure in my enviroment. And since this pr is closed ,I open a new one to update the commit https://github.com/apache/hadoop/pull/1111

thx, I'll look at it tomorrow. I'll run the tests first just to make sure all is good.


Update go.mod

module declares

module declares

Without this pr you can't fetch this package at all with go mod.  Please merge asap.

Also since you've adding go.mod you should probably do a new tagged release.

I've added the tag.  Please verify (my git knowledge isn't the greatest :-( )

I believe you need to make the tag v1.2.0

Done.

Did you accidentally tag the wrong commit?  v1.2.0 is pointing to fe8f175 but 1.2.0 is pointing to 37ec4cb.  fe8f175 was before any of the go.mod stuff was added.  I'm also not 100% but you might need to remove the 1.2.0 tag?  Maybe not but might be confusing having 2 tags for the same version.

Drat. I didn't do a "git pull".
I removed and re-added the v1.2.0 tag.  PTAL

Perfect!
> go mod verify && go mod tidy
all modules verified
go: downloading github.com/StackExchange/wmi v1.2.0


identify the div number of the place where  occurs

Dear @ajaniak —

BUG. The sections svayambhu_06.19.02 through svayambhu_06.22.02 are affected by omissions, of varying extent, in two of the three witnesses. To my surprise, the  of the omission in witness #K is used to define the end of the omission in #L in the display below, and none of the apparatus entries occurring between  and  in #L show the autogenerated <rdg> "om. L" that is expected. Since the first  occurs in #K and we do get autogenerated "om. K" where we expect them, it seems that the code cannot handle the co-occurrence of two gaps in the same part of the text.

ENHANCEMENT. With the present display, we don't help the reader see in which section the   occurs.

Could we change the autogenerated lemma in the display to become something like this (after the above bug has been solved)?
kalih ... (§86) ikaṅ

The enhancement part is done. (and it should be already applied)
The bug is partially resolved : the fake lemma are generated correctly, but I still need to work on the Javascript to resolve the incorrect display regarding om and lac (larger gap).

I have updated the code to resolve the 1. The code might take several hours to be udpated and the pipeline will need to be then relaunched.
Here results from the tests

To follow on our conversion regarding the context when creating  §xx with <ptr> as well as for the lemma of larger gap.
I have look into it today, if the possibility to declare in the <teiHeader> using <refsDecl> is possible. It seems a complex solution and I don't think it will be easy to set up for most encoders without a XML-TEI expert. So I wonder for the longevity of the guide, if it is a good idea.
For the <ptr>, the context can be deduced from the content of @target since the encoder can provide the necessary level. I have updated the display this morning to match §xx, but we could fine a solution between the previous and the new to clear state the context: §name xx name standing for a label we could create based on @type and elements, i.e lg becoming stanza and xx being the number.
For the larger gap situation, I have added a few supplementary rules regarding the display of (§xx)

if the beginning and the end of the omission are in the same bloc container, we don't display the (§xx) in the lemma. Case in Candrakirana
if the beginning and the end of the omission are not in the same bloc container,

If the context is the dyad, only its number is given. Situation in svayambhu
If the context if a paragraph inside a div, the number of the main div and the paragraph are given, i.e. §11.3. Case in Candrakirana and Saṅ Hyaṅ Siksa Kandaṅ Karəsian

Since, the display offers satisfaying results for those files, I wonder if we could avoid using the solution we evoked with <refsDecl>.
For now, I have worked mostly for omission, and I will need to update the reformulation and lacunae at some point. If you agree with the first result and if it matches your expectations.

@ajaniak —
I have the feeling that all of this is now working fine. Could you convert your message of Jul 13 to a comment or draft new section in the EGD, for us to discuss later, and then close this thread?


StormBoltOutputCollector should not report on ack disabled

Is this consistent with storm?
When ack is disabled, the ack call will be skipped? or will be also called?

yes.  bolt.ack is actually called by applications. When ack is disabled, ack could be called but since the tuple tree is empty, there will be no ack messages. We don't skip ack but reporting ack, which is consistent with Storm.

this is already fixed #1631. Please file new issues if there are any concerns.


Protobuf transformer skeleton

Otherwise I did the test of the decorator check with the proto generation and it worked well on a smart contract


error message

Hello
thank you for your addon, it can be really very useful
However, I encountered a bug, the link below will normally allow you to see the message I got on the screen
Again thanks to you
cdlt
https://reho.st/view/self/2490cc5d73b44556ae3d6edb04ac07cb6aa72d68.jpg

What is that big node right behind the error in the second picture? Also, if you open the system console under "Window > Togle System console" there will be more debug info.

@etpourquoipas Ok, I just published a new version. Remove the version you have installed. Then download the latest version(follow step 1 in installation instructions) and try again. But if that big node is from some other add-on it's possible it still won't work. Also, the frame around the nodes at the top will not keep its size when pasted, I'm working on adding that soon.
And thank you for your using my add-on!😀👍

Hello and thank you for your answer
for the installation procedure there is a special way?
I downloaded the zip and installed this one via the preferences, it is version 1.2 is it?
the operation is problematic on version 2.83.1 and 2.9
below the report (link for 1 txt file) of the console, from opening blender, to using your addon
http://dl.free.fr/sM40zvFJs
cdlt

You have followed the correct installation, and yes it's version 0.1.2
I see what the problem is now. I did not know that nodes could be parented to frames. If you remove the frame in the top left it should work. and i will try to fix so frames are properly supported as soon as i can.

Hello to you
it works, I will remove the frame then
Again thanks to you
cdlt

@etpourquoipas
I just uploaded a new version 0.1.3. It should now be possible to copy nodes that are inside a frame. But when pasting the material the frame will not be in the same location as it was copied from. This is because of a circular dependency kinda problem. Where the location of the frame(if shrink is enabled) depends on the location of the nodes. But the nodes locations depend on the location of the frame.
Thank you for taking the time to report the bug.
Have a nice weekend

Great ! thank you !
by removing the frame, everything works correctly with 0.1.2!
thank you very much ! I will download the 1.3
cdlt


add variable coll support

Split on an arbitrary number of --split-- tags and build the HTML based on however many colls are found in the markdown. This should maintain backwards compatibility except for the div names.

Thanks for the feedback, I incorporated it in a pull request on the 00v3 branch.


fix AddRunningKubeSourceWithRevision return error when IstioOperator updated

fixes: #39599

@zirain: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
26e16a0cfa1c8a1f75b875ea66d95dc98a705922
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zirain was there an issue open on this? I like to understand a bit better what problems we are trying to fix.

@zirain was there an issue open on this? I like to understand a bit better what problems we are trying to fix.

https://github.com/istio/istio/issues/39599

replaced by https://github.com/istio/istio/pull/40727


Update issue templates

Updated Spike template

Did you mean to remove all the labels of the other templates? Also, I'm not entirely sure the newlines you injected into the YAML part of the Markdown will work.

No, not at all, the only template I changes was the Spike.


Please don't recommend depending on clap="~major.minor.patch"

Clap's README.md recommends depending on clap="~major.minor.patch", "to keep from being suprised of breaking changes".  However, any actual breakage that would prevent compiling code written against an old version of clap with a new version of clap would involve a major version bump, which a "compatible version" dependency like clap="major.minor.patch" would also prevent.  The only thing a "compatible version" dependency would allow would be a requirement on a new version of Rust or Cargo, which not every application needs to worry about.
Meanwhile, dependencies like "~major.minor.patch" mean that Linux distributions would have to package many different major.minor versions of clap to support various application dependencies on them.  Linux distributions will already avoid packaging a version of clap that requires a version of Rust or Cargo newer than the one they ship.
Based on this, please consider changing the recommendation in README.md to suggest using a "compatible version" dependency unless your application specifically needs to maintain support for versions of Rust older than Clap's compatibility policy (two versions older than stable).  This would significantly reduce the likelihood of having to package numerous versions of clap for Linux distributions.

I'll look at re-wording the readme. The primary point I want to get across is if someone is depending on on a pinned version of Rust, and clap's support moves past that pinned version. This will only happen in a minor version bump of clap, at a minimum.
Perhaps I could say use, ~major.minor.patch only if one is concerned about the minimum version of Rust sticking at a point lower than the compatibility policiy states (i.e. less than 2 stable releases back).

@kbknapp

Perhaps I could say use, ~major.minor.patch only if one is concerned about the minimum version of Rust sticking at a point lower than the compatibility policiy states (i.e. less than 2 stable releases back).

That's exactly what I'm requesting.


Is it possible to rotate a polar chart?

I'm looking at using Chart.js for a project where I need polar charts. In my testing, with data points per chart, the orientation of the 'thirds' is such that there's segment one on bottom, and one on either side. I'd like to be able to turn that by 1 'segment' clockwise so that the segment currently on the left moves to the top with two segments below, one left, one right.
Is this possible?
If not currently, would it be difficult to implement?
Thanks,
Scott
PS. Posting here because I couldn't find where else to go for support questions. Thanks.

Hi,
I would like to make a "1D" chart. I can more or less achieve this goal by making a radar chart with "only one direction" but the size of the graphe and the center of the line are not correct. More over I want this chart to be horizontal and I can't find a way to make it work. Where could I find help for that?
Thx for your help :)

Hi ya, any news on this enhancement, i have a current project that i would like to use this on?
Cheers Mick.

This is not yet done for the polar area chart, but it is done for the doughnut chart. It won't be too hard to implement

Sorry my mistake i meant to actually tag this comment on the ability to rotate the Radar Chart type, my mistake.

No problem, I think the fix is pretty much the same for both

Fixed in #2947 and releasing in v2.2.0


Delete Runs does not work anymore

Current behavior
Expected behavior

Deleting a run does now work again, but includes a reload.
This reload problem is tacked in this issue: https://github.com/tira-io/tira/issues/281


[Fetcher] Print exceptions prior to reporting for metrics

Summary
We now expose exceptionSampleRate via API - default is 0.1 - one among every 10 exceptions will be logged.
Why / Goal
Currently we don't log exceptions at all, which makes debugging difficult. This will make it so that by default we print a fraction of exceptions.
Test Plan

[ ] Added Unit Tests
[x] Covered by existing CI
[ ] Integration tested

Checklist

[ ] Documentation update

Reviewers
@hzding621 @qiyang0221

Close due to inactivity on it. We can reintroduce the sample rate later on.


Fixes GetHttpResponseData to return the correct entry from OutputBinding entries

In #987 we changed how we read the OutputBinding data. But the GetHttpResponseData extension method was not updated to reflect this change. Fixing that here.

/check-enforcer override


"Add" string not translated in component_method block

Describe the bug
For the clock related methods, AddYear, etc., we have the Add string hard-coded in the block definition rather than using a translation from the messages file. This makes it impossible for translators to change this text.
Affects

[ ] Designer
[x] Blocks editor
[ ] Projects Explorer
[ ] Companion
[ ] Compiled apps
[ ] Buildserver
[ ] Debugging
[ ] Other... (please describe)

Expected behavior
The "Add" string on the clock blocks should be translatable and present in blocklyeditor/src/msg/ai_blockly/messages.json.
Steps to reproduce

Add a Clock component
Add some of the Add* blocks in the blocks workspace
Change the language to anything other than English and note that the Add string will never change.

I want to work on this issue could you please assign me.


Using Trezor

Trezor
Trezor wallet is a hardware wallet designed for secure storage of cryptocurrencies. Similar to other hardware wallets, Trezor provides a physical device that stores the user's private keys offline, reducing the risk of exposure to online threats like hacking and malware.
For more information check the following link https://trezor.io/learn
Install NPM Packages
npm install @trezor/connect

Implementation Example
import TrezorApi from "trezor-connect";

const supportedNetworkURLs = {
<PHONE_NUMBER>: "https://staging-v3.skalenodes.com/v1/staging-fast-active-bellatrix"
};

const defaultNetwork = 1;

const Trezor = new TrezorConnector({
  api: TrezorApi,
  supportedNetworkURLs,
  defaultNetwork,
  manifestEmail<EMAIL_ADDRESS>  manifestAppUrl: "https://test.io/"
});

What is: Wallet
Language: Javascript, Typescript
Target: Web


Add L7 Antrea native NetworkPolicy support in controller

This PR add support for L7 Antrea native NetworkPolicy in the controller side.

Added support for passing L7Protocols to agent when processing ClusterNetworkPolicy and AntreaNetworkPolicy.
Added validation for Antrea native policy that checks L7Protocols is only used with Allow action, not used with toServices. When HTTP is set, then L4Protocol is only TCP or unset, and not with IGMP or ICMP.
Added UT.

/test-all


Library for numbers formatting

We have an internal guideline of how balance numbers should be formatted
https://github.com/gnosis/safe/wiki/How-to-format-amounts
It is beneficial if these formatting guidelines are implemented consistently throughout the interface but also in Safe Apps built by external developers.
We should expose this as a library to external developers so they can easily implement these number formatting rules.

So basically what we need to do is include this to safe apps sdk:
https://github.com/gnosis/safe-react/blob/development/src/logic/tokens/utils/formatAmount.ts

Maybe this could also be part of safe-react-components? Would be cool to have a component that turns an amount + token contract address into a fully formatted value, maybe even with the right token icon. Not sure if that's possible though.

@lukasschor I wouldn't include it in the components library, because in this case the developer would have to use react in order to reuse our  formatting logic and IMO number formatting is a framework-agnostic thing. Keeping in mind that we want to extend the sdk with helper methods (querying the tx, etc) I think adding an util function for formatting numbers there is a good idea.

Actually I meant that I wouldn't include the formatting logic ONLY in the component library. The component you described is a good idea and can be handy

@lukasschor ,
the app view in case of big amount in the balance from prod Mainnet:
safe - 0xf661107395729AFc8A027B976337B859A0847D8e
Macbook Chrome

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat


Update LittleFS to v2.4.2

Any news on updating the bindings with this PR?

The trouble is making sure downstream products don't break. We'd like to update and may do so soon.


[POAE7-2623] support ISNULL/ISNOTNULL in nextgen

What changes were proposed in this pull request?
move UOper out of Analyzer.h/Analyzer.cpp and support ISNULL/ISNOTNULL in UOper
Why are the changes needed?
expr codegen based on nextgen
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT
Which label does this PR belong to?

@jikunshang @bigPYJ1151 @spevenhe @kd97 Please help review again.


Remove boost dependency

I combine many commits in #23
now seem NICE :)

@liulanzheng here, try it again~

DCO compile error, please revert, I make a new PR later. @liulanzheng

Done.


:art: Enable strict type check and improve the project typing

Following https://github.com/Ousret/charset_normalizer/issues/182

Codecov Report

Merging #207 (370d9ee) into master (6155b6b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
- Coverage   89.88%   89.87%   -0.01%
==========================================
  Files          11       11
  Lines        1216     1215       -1
==========================================
- Hits         1093     1092       -1
  Misses        123      123

Impacted Files
Coverage Δ

charset_normalizer/api.py
86.76% <100.00%> (ø)

charset_normalizer/cd.py
96.34% <100.00%> (ø)

charset_normalizer/cli/normalizer.py
74.73% <100.00%> (-0.27%)
:arrow_down:

charset_normalizer/models.py
86.66% <100.00%> (ø)

charset_normalizer/utils.py
86.17% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Configurable shell timeouts

What would you like to be added:
An ability to set the timeout for shell tabs to force them stay open.
Why is this needed:
Sometimes when working with multiple shells to containers or nodes the inactive ones will close automatically, so you have to re-open those again and again.
It wold be nice to have a configurable timeout to keep the shell tabs open for a longer time. Preferably an ability to somehow pin the tab, so that it does not get closed at all.
Environment you are Lens application on:

Kubernetes distribution: Any
Desktop OS: Any

When this happens do you see any ERROR logs in the devtools?

The only thing that that I find is that we ping the websocket every 30 seconds, that probably can be configured.

When this happens do you see any ERROR logs in the devtools?

No errors are displayed.


Generalize so it can be used across projects

Either

encapsulated as script: variables supplied on command line
or, encapsulated as object: parameters supplied inside ruby

We now have objects and scripts so all the parts that matter can be passed from outside.


New talk status

Introduced new status for talks, so we dont display approved talks by default

Codecov Report

:exclamation: No coverage uploaded for pull request head (new-talk-status@d4d7d79).

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d83407c...d4d7d79. Read the comment docs.