custom status bar / nav bar colors?

the android status bar is always grey, which can look bad with custom header bar color. maybe the status bar color should either be semi-transparent or solid.
likewise, the nav bar is always black, which looks fine but might look better if it matched the footer bar more (but i am less bothered by this)

I have never seen the status bar turn grey when viewing this app on an Android 5+ devices.
what device show it?

Sony Xperia X Compact (Android 8.0.0)

current status bar color is same to "colorPrimaryDark", it is #303030 on light theme, or #222222 on dark theme. almost black.

maybe the status bar color should either be semi-transparent or solid.

In this case "transparent" has no meaning.
I think dark grey is one of solid color.

indeed I understand that there is a demand for customization.
However it will not offer the "Same as column header" option for the following reasons:

There may be cases where multiple columns are displayed simultaneously in tablet mode.
There may be no column.
This app switches columns frequently.

and also, there is no API to set foreground color of status/navigation bar.

some Android devices shows "light" navigations bar and its foreground is not white.

Galaxy S10+ light theme shows light gray navigation bar.

use setNavigationBarColor(white), the foreground is hard to be recognized.

It's possible to add an option to set the color, but that would require the user to be careful.

implemented at a1ca0165

5feb228d

5feb228d


Don't cache head/tail index in Consumer/Producer

I'm not sure whether this is an improvement or not.
The benchmarks are inconclusive on my machine.
The results might be different on a CPU with weak memory ordering, because the number of atomic loads increases.
Any comments?

I will test this tonight.

the non-cache version faster than the default one on my machine.

I think u could merge this because nobody uses ringbuffer with a very small buffer.

Thanks @zhenpingfeng!
I've also seen slight improvements in the two-threads benchmark.
However, some of the single-threaded benchmarks have shown quite strong regressions.
I'm not sure whether the results are reliable and I don't know which of the benchmarks are most relevant in practice.
But since the improvements are small and the regressions are big, I'm hesitating to merge this.
Have you also tried the single-threaded benchmarks?
What kind of CPU have you used, if I may ask?
I'm using a Intel(R) Core(TM) i5-7Y54 CPU.

Sorry for the late response.
I've run the benchmarks again on my Laptop in order to produce some plots.
The results are quite mixed. Most differences are within +-5%.
The following plots show a few bigger differences.
blue: this PR
red: base commit of this PR (cc4191f)
Some benchmarks improved quite a lot:
single-thread-single-byte/4-write:

single-thread-with-chunks/3-iterate-write:

While other benchmarks regressed quite a lot:
single-thread-with-chunks/1-pop:

single-thread-with-chunks/3-iterate-read:

Please note that single-thread-with-chunks/3-iterate-read has a huge regression while single-thread-with-chunks/3-iterate-write has a huge improvement. Strangely, single-thread-with-chunks/3-iterate-write-uninit shows no change (but I would have expected a similar behavior to single-thread-with-chunks/3-iterate-write).
Any ideas what could be the explanation for this?
The two-threads benchmarks (which I think might be the most relevant here), show only very small differences within the noise threshold:
two-threads/large:

two-threads/small:

In summary, the multi-threaded benchmarks show no difference, while the single-threaded ones show both big improvements and big regressions, which makes me think they are probably not very trustworthy.
Unless there is a good explanation for the results, I'm hesitating to merge this, because it might actually be a net negative.
Any theories that could explain the observations?
Any further benchmark results?

I think when u adding up the write and pop, the blue is [15.25ns+13.25ns=28.5ns] and the red is [19.6ns+11.5ns=31.1ns]. Also the iterate-write and iterate-read, the blue is [4.7us+6.75us=11.45us], the red is [9.6us+4.55us=14.15us]. So this pr still faster than the original one.

IMHO, Ordering::Acquire isn't required when reading tail by Producer, or reading head by Consumer, isn't it?

IMHO, Ordering::Acquire isn't required when reading tail by Producer, or reading head by Consumer, isn't it?

I'm not sure if I understand. Acquire isn't used in those situations, is it?
If you think that something should be changed, can you please make a PR, so that we can discuss it concretely?

Sorry, I looked at the wrong code, I'll have to look into this more closely ...

IMHO, Ordering::Acquire isn't required when reading tail by Producer, or reading head by Consumer, isn't it?

Yes, you are absolutely right @RamType0. Thanks for noticing this!
I've changed those operations to use Relaxed in e94a9d6b132c71608758ca1598f2b5942afdfe8d.
I also added comments in case somebody is wondering later why Relaxed was chosen.

I have decided to merge this. Some benchmarks are still inconclusive, but overall it tends to be an improvement. The two-thread benchmarks don't change.


Connection string issue with PublishSingleFile flag from shared project.

Issue Title
SQL server connection string not working when compiling application with command: dotnet publish /p:PublishSingleFile=true and connection string is in shared project
General
I have a worker project which has SQL related code in Shared project. Everything is working fine when running code from Visual Studio or compiling code without /p:PublishSingleFile=true flag. But with PublishSingleFile flag i get error when running application:
Unhandled exception. System.TypeInitializationException: The type initializer for 'Microsoft.Data.SqlClient.SqlConnection' threw an exception.
 ---> System.InvalidOperationException: Failed to read the configuration section for enclave providers. Make sure the section is correctly formatted in your application configuration file. Error Message: Configuration system failed to initialize
 ---> System.Configuration.ConfigurationErrorsException: Configuration system failed to initialize
 ---> System.Configuration.ConfigurationErrorsException: An error occurred loading a configuration file: Could not load type 'System.ComponentModel.AsyncCompletedEventArgs' from assembly 'System.Net.WebHeaderCollection, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. (C:\Users\user\AppData\Local\Temp\.net\app\5juw15bs.4n3\Config\machine.config)
 ---> System.TypeLoadException: Could not load type 'System.ComponentModel.AsyncCompletedEventArgs' from assembly 'System.Net.WebHeaderCollection, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
   at System.Configuration.ClientConfigurationHost.OpenStreamForRead(String streamName)
   at System.Configuration.Internal.DelegatingConfigHost.OpenStreamForRead(String streamName)
   at System.Configuration.ImplicitMachineConfigHost.OpenStreamForRead(String streamName)
   at System.Configuration.BaseConfigurationRecord.InitConfigFromFile()
   --- End of inner exception stack trace ---
   at System.Configuration.ConfigurationSchemaErrors.ThrowIfErrors(Boolean ignoreLocal)
   at System.Configuration.BaseConfigurationRecord.ThrowIfParseErrors(ConfigurationSchemaErrors schemaErrors)
   at System.Configuration.BaseConfigurationRecord.ThrowIfInitErrors()
   at System.Configuration.ClientConfigurationSystem.EnsureInit(String configKey)
   --- End of inner exception stack trace ---
   at System.Configuration.ClientConfigurationSystem.EnsureInit(String configKey)
   at System.Configuration.ClientConfigurationSystem.PrepareClientConfigSystem(String sectionName)
   at System.Configuration.ClientConfigurationSystem.System.Configuration.Internal.IInternalConfigSystem.GetSection(String sectionName)
   at System.Configuration.ConfigurationManager.GetSection(String sectionName)
   at Microsoft.Data.SqlClient.SqlConnection..cctor()
   --- End of inner exception stack trace ---
   at Microsoft.Data.SqlClient.SqlConnection..cctor()
   --- End of inner exception stack trace ---
   at Microsoft.Data.SqlClient.SqlConnection..ctor(String connectionString)
   at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerConnection.CreateDbConnection()
   at Microsoft.EntityFrameworkCore.Storage.RelationalConnection.get_DbConnection()
   at Microsoft.EntityFrameworkCore.Storage.RelationalConnection.OpenAsync(CancellationToken cancellationToken, Boolean errorsExpected)
   at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerDatabaseCreator.<>c__DisplayClass20_0.<<ExistsAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at Microsoft.EntityFrameworkCore.SqlServer.Storage.Internal.SqlServerExecutionStrategy.ExecuteAsync[TState,TResult](TState state, Func`4 operation, Func`4 verifySucceeded, CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Storage.RelationalDatabaseCreator.EnsureCreatedAsync(CancellationToken cancellationToken)
   at Microsoft.EntityFrameworkCore.Storage.RelationalDatabaseCreator.EnsureCreatedAsync(CancellationToken cancellationToken)
   at app.Worker.ExecuteAsync(CancellationToken stoppingToken)
   at Microsoft.Extensions.Hosting.Internal.Host.StartAsync(CancellationToken cancellationToken)
   at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.RunAsync(IHost host, CancellationToken token)
   at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.RunAsync(IHost host, CancellationToken token)
   at Microsoft.Extensions.Hosting.HostingAbstractionsHostExtensions.Run(IHost host)
   at app.Program.Main(String[] args)

Connection string used: (@"Server=DB;Database=db;Integrated Security=true;"); or with username and password combination: (@"Server=DB;Database=db;User Id=user;Password=Password1;");
Dotnet info:
.NET Core SDK (reflecting any global.json):
 Version:   3.0.100
 Commit:    04339c3a26

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.18985
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\3.0.100\

Host (useful for support):
  Version: 3.0.0
  Commit:  7d57652f33

.NET Core SDKs installed:
  2.1.801 [C:\Program Files\dotnet\sdk]
  2.1.802 [C:\Program Files\dotnet\sdk]
  2.2.401 [C:\Program Files\dotnet\sdk]
  3.0.100-rc1-014190 [C:\Program Files\dotnet\sdk]
  3.0.100 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.1.13 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.1.13 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.0.0-rc1.19457.4 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 2.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.11 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.13 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.0.0-rc1-19456-20 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 3.0.0-rc1-19456-20 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 3.0.0 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

@diego @ajcvickers for possible help on this one.

Please follow similar issue being discussed at: https://github.com/dotnet/SqlClient/issues/211
OR log a new issue at: https://github.com/dotnet/SqlClient/issues/

I don't believe the error is specific to SqlClient. There is probably an error in one of your config files (missing root element or something basic). Validate the machine.config at C:\Users\user\AppData\Local\Temp.net\app\5juw15bs.4n3\Config\machine.config (or wherever that is generated from in your error). SqlClient just happens to be the first thing looking for config information in your stack.

Hi,
Sorry didn't do enough of testing with different flags. Seems that it also needs /p:PublishTrimmed=true flag
I created minimal repro repo https://github.com/Jeremiad/Issue-3447-repro where this happens when trying to build Worker project with command: dotnet publish -r win-x64 -c Release /p:PublishSingleFile=true /p:PublishTrimmed=true

If you add a direct dependency on System.Configuration.ConfigurationManager to the Shared project in the repro, the error goes away. System.Configuration.ConfigurationManager is already a dependency of SqlClient so this doesn't seem like a SqlClient issue to me but perhaps something in the .NET SDK.

This happens to me in a completely standalone netcoreapp3.0 project, without any external references, compiled for linux-x64. If i trim it, I get the same error as in OP:
Could not load type 'System.ComponentModel.AsyncCompletedEventArgs' from assembly 'System.Net.WebHeaderCollection, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.

Ping @David-Engel . Any alternative ideas?

Figure out where the invalid app.config or machine.config is and fix it. I don't have any insight into where else those might be hiding in the above scenarios. Further error details (like the full stack trace in a previous comment) often provides a path.

I can confirm this was caused by  publishing with -p:PublishTrimmed=true and removing it solved the issue.
PublishTrimmed seems to buggy in ASP.Net Core 3.1

@kofifus
Same here, just happenned:
Unhandled exception. System.TypeLoadException: Could not load type 'System.ComponentModel.AsyncCompletedEventArgs' from assembly 'System.Net.WebHeaderCollection, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
   at Cero.CommandLine.CliSections..ctor(String[] args)
   at Cero.Program.Main(String[] args)
fish: “cero project qtile” terminated by signal SIGABRT (Abort)

I can confirm the same issue on .Net Core 3.1.300 under Windows 10.  Manually adding a reference to System.Configuration.ConfigurationManager did seem to resolve it.

I faced the same issue and after some trial and error attempts and reading the docs about Prevent assemblies from being trimmed, I solved my issue simply by upgrading the Microsoft.Data.SqlClient to version 2.0.0-preview4.20142.4 (at the time of writing).
Hoping this helps someone.

I face the same issue when I was using WebClient in a .net core 3.1 console app like this:
WebClient webClient = new WebClient();                 webClient.DownloadFile(myUri, @"myfilename");
After adding the nuget for System.Configuration.ConfigurationManager the problem resolved

I face the same issue when I was using WebClient in a .net core 3.1 console app like this:
WebClient webClient = new WebClient(); webClient.DownloadFile(myUri, @"myfilename");
After adding the nuget for System.Configuration.ConfigurationManager the problem resolved
This worked for me as well. My problem was not just the trimmed option, but being unable to use the "produce single file" option at all. In this project I was using the webclient and not the SQLClient... but I have had the problem with the trimmed option as well in a project that uses the SQL client. I will try adding this Nuget to that project as well and see if that helps.

It seems solutions have been provided to solve this issue. I am going to close this. But please let me know if I missed anything.


Cannot find OpenSSL's <evp.h>

Hello
When running phpbrew install 5.6.15 +mysql -- --with-openssl=/usr/include/openssl I get the following error in build.log: configure: error: Cannot find OpenSSL's <evp.h> and running ll /usr/include/openssl/ | grep "evp.h" i get:
-rw-r--r--  1 root root  52791 juni  11 17:32 evp.h

Who is the wrong here?
Running Ubuntu 14.04.3 64-bit with elementary OS 0.3.1 Freya.
OpenSSL version: OpenSSL 1.0.1f 6 Jan 2014

Samer error here while installing php 5.4.45 with Ubuntu 15.10 (x86)
$ phpbrew install php-5.4.45 +default -- --with-openssl=/usr/local/ssl/include/openssl

@hultberg did you try upgrading phpbrew and leveraging Openssl support?
$ phpbrew install 5.6.15 +default +mysql +openssl=/usr/include/openssl

As mentioned here on #111 I still get different errors though.

Thanks @ifthenelse, this worked:
$ phpbrew install 5.6.15 +default +mysql +openssl=/usr/include/openssl

My solution:
phpbrew install 5.6.15 +openssl which seems to install openssl independently
Running OSX:
Darwin Kernel Version 15.5.0: Tue Apr 19 18:36:36 PDT 2016; root:xnu-3248.50.21~8/RELEASE_X86_64

@jcrben .... it worked for me...thanks.

For the record anyone using ubuntu (I'm on 16.4), check you have libssl-dev  installed.  I didn't and installing this got me past that error configuring builds

I had this problem on Amazon Linux. None of the above solutions worked for me. So, after finding this solution on the mongo-php-driver project (https://github.com/mongodb/mongo-php-driver/issues/299#issuecomment-232673238), I was able to use the following to symlink the required files and get PHP to build with OpenSSL:
sudo bash -c "mkdir -p /usr/local/openssl/include/openssl/ && ln -s /usr/include/openssl/evp.h /usr/local/openssl/include/openssl/evp.h && mkdir -p /usr/local/openssl/lib/ && ln -s /usr/lib64/libssl.a /usr/local/openssl/lib/libssl.a && ln -s /usr/lib64/libssl.so /usr/local/openssl/lib/"

phpbrew install 7.1.3 +openssl=/usr/local/openssl/

I am not recommending this as a permanent solution, but it is the only work-around that allowed me to proceed with the build.

I had this issue as well. I was pointing to the executable of openssl, not the full folder.
BAD:
phpbrew install 7.1 +default +mysql +fpm +openssl=/usr/local/bin/openssl

GOOD:
phpbrew install 7.1 +default +mysql +fpm +openssl=/usr/local/Cellar/openssl/1.0.2l

FYI if anyone comes across this issue and is trying the wrong path.

For compilers to find openssl you may need to set:
export LDFLAGS="-L/usr/local/opt/openssl/lib"
export CPPFLAGS="-I/usr/local/opt/openssl/include"

from brew info openssl


Add a wiki: Pathologic Wiki

Link to origin wiki: https://pathologic.fandom.com/wiki/Pathologic_Wiki
Link to destination (independent) wiki: https://pathologic.wiki.gg/wiki/Pathologic_Wiki
The Pathologic Wiki has recently moved away from Fandom. I'm not sure if it was announced anywhere except for their Discord server (link to the message). Having a redirect to the new wiki would be really handy. Thank you!

Thanks for the submission! Added in v3.5.0, now available on both Chrome and Firefox.


AWS - Gameplay

For simple and short games, reading entire history and adding a move every time is okay.
For more complex games, provide a mechanism to save and load the entire game state - including the current step of the game coroutine (or just persist every "loop" and load actions that has been made after most recent loop).

Implementing the server on AWS as a Serverless application would be a incredibly big task. I have made a small POC proving that theoretically it can be possible using JavaScript. But I doubt that it would be worth the effort.
Currently it doesn't have much traffic so rewriting it would mainly cost a lot of time.
Once it would have much traffic I doubt it would be worth it because running it on a server is by far more efficient most likely, but I am willing to revisit the task at a later time.


animate the fill use the color of rgba, it will be the color of hex

demo http://codepen.io/anon/pen/YpmgOJ
when I use hover to change the text's fill color, the first line text I also use the fill-opacity to control the opacity, it is working fine.
the second line I use the rgba color, when the text animate, the fill color become the hex color
Am I wrong?

I love it, you're checking systematically the weak points ;-)
Seemingly another fault of snap.svg.
You still have the option to animate color and opaque separated, but snap.svg shouldn't change your values I think. But perhaps there is a reason that it's translated in hex-values ...

I changed your codepen a bit, so that the colors are the same and opacity is set in both lines, furthermore I included the dev-version instead of master:
http://codepen.io/dbruchmann/pen/ObKexq
but the second line changes the color different. Don't know in the moment how to track the calculated keyframes.
The difference is then only between rgb and rgba and the missing attribute  fill-opacity="0.1" in the second line.
Probably colors will change the same if rgb and rgba are accepted and not changed to hex.
@DmitryBaranovskiy is there any reason that snap.svg is converting the colors?

Fixed on dev.

Thanks!

nice
thanks @DavidBruchmann @DmitryBaranovskiy


[iOS] Polygon Click Event latLng returns undefined

Following the example provided in the documentation,
map.addPolygon( {
	'points': [
		new plugin.google.maps.LatLng( 41.79883, 140.75675 ),
		new plugin.google.maps.LatLng( 41.79567, 140.75845 ),
		new plugin.google.maps.LatLng( 41.79576, 140.75475 ),
		new plugin.google.maps.LatLng( 41.79883, 140.75673 )
	],
	'strokeColor': '#AA00FF',
	'strokeWidth': 5,
	'fillColor': '#880000'
}, function ( polygon ) {
	polygon.on( plugin.google.maps.event.OVERLAY_CLICK, function ( overlay, latLng ) {
		console.log( 'latLng >', latLng ) // returns undefined :(
	} );
} );

On iOS latLng returns undefined 😢
Plugin version installed from master branch.
Everything works properly on Android.

Is there any error log in native side?

If by native logs you mean Xcode debugger, no there were not any errors.

Thank you for long-long-time waiting.
The current version does not implement this feature in the iOS code.
(Since I was tired at the time)
However the next version resolve this issue.
(I have been implementing this feature).

This is solved in the plugin v2 beta.
https://github.com/mapsplugin/cordova-plugin-googlemaps/wiki/What-are-news-in-v2%3F#version-2x-events


Fix bug for for Sidecar's defaultEndpoint is IPv6 format

Please provide a description of this PR:
Fix issue#40245 for Sidecar's defaultEndpoint is IPv6 format
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@zhlsunshine: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
8fc5e17dabb3b825aefcf1edc87d2d097347c250
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhlsunshine: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
8fc5e17dabb3b825aefcf1edc87d2d097347c250
link
true
/test lint_istio

gencheck_istio
8fc5e17dabb3b825aefcf1edc87d2d097347c250
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

We need test other than just loosen validation

Sure, thanks for the comment, I will add the unit test for it.

There are two comments:

The API says Arbitrary IPs are not supported. Format should be one of <IP_ADDRESS>:PORT, <IP_ADDRESS>:PORT``
Implement not complete when build inbound cluster, https://github.com/istio/istio/blob/master/pilot/pkg/networking/core/v1alpha3/cluster.go#L445-L459

Hi @hzxuzhonghu, for 1, the doc will be changed as well, for 2, I submitted for it again. Thanks for your comments!

There are two comments:

The API says Arbitrary IPs are not supported. Format should be one of <IP_ADDRESS>:PORT, <IP_ADDRESS>:PORT``
Implement not complete when build inbound cluster, https://github.com/istio/istio/blob/master/pilot/pkg/networking/core/v1alpha3/cluster.go#L445-L459

Hi @hzxuzhonghu, for 1, the doc will be changed as well, for 2, I submitted for it again. Thanks for your comments!

https://github.com/istio/api/pull/2447

In response to a cherrypick label: new pull request created: #40342

/cherrypick release-1.14

@GregHanson: #40265 failed to apply on top of branch "release-1.14":
Applying: fix issue#40245 for Sidecar in ipv6 defaultEndpoint format
Applying: fix the lll go lint
Applying: add unit test for sidecar's defaultEndpoint
Applying: completed this fixing according to comments
Using index info to reconstruct a base tree...
M	pilot/pkg/networking/core/v1alpha3/cluster.go
Falling back to patching base and 3-way merge...
Auto-merging pilot/pkg/networking/core/v1alpha3/cluster.go
CONFLICT (content): Merge conflict in pilot/pkg/networking/core/v1alpha3/cluster.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0004 completed this fixing according to comments
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.14

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@GregHanson: new issue created for failed cherrypick: #40464

In response to this:

/cherrypick release-1.14

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


build.gradle: Clean digdag-ui build in 'clean' task

This PR makes minor change to remove digdag-ui build when 'clean' task is executed.

merging @frsyuki


mixing gcc-qt and wasm-aqt ?

Thank you very much for your work on Qt6.
I have a two questions:

are there any bad side effects to mix gcc-qt and wasm-aqt ?
can get_qt.sh be called only once for both ?

Hi @prudhomm ,

I don't really see any particular issue of mixing those images and actually wasm contains quite alot of gcc image deps
You will need to prepare the merge of both get_qt.sh - because they are installing a bit different libs, but yeah I don't see any issues with that - wasm image just will need some adjustment and a couple of additional tools to be a replacement for gcc image.
From CI perspective though I would not recommend to mix them - save of space is not that big and the image purpose should not be mixed for maintenance and environment clarity purposes. For example gcc bins should not require additional libs that is installed in wasm image and in theory they could contaminate gcc build environment with sudden unwanted dependencies.

Thanks a lot!
I will give a try.

@rabits it worked quite fine and we can build both desktop and wasm builds 👍🏻
thanks a lot for your work


Help with installation

Platform (Hardware/OS): Pi 3 Model B
Node version: 9.11.2
MagicMirror version: 2.4.1
Module version: 1.0.2
Description of the issue:
Hey, I would like some help installing the module.  I've tried numerous times, always kept getting one error or another. Decided to scrap the OS and start fresh in case I had changed some file I should not have while pursuing the error codes and their fixes.
On this last install I got an error at the end of the install:

Continued with the instructions putting it in the config file:
                {
                    module: 'MMM-voice',
                    position: 'bottom_bar',
                    config: {
                                microphone: 1,
                                keyword: 'MAGIC MIRROR',
                                timeout: 15,
                            }
                },

AND now my MM screen is blank (just black).
Checked the pm2 log and got back:
pi@raspberrypi:~/MagicMirror $ pm2 logs MagicMirror
[TAILING] Tailing last 15 lines for [MagicMirror] process (change the value with --lines option)
/home/pi/.pm2/logs/MagicMirror-error.log last 15 lines:
0|MagicMir |     at Object. (/home/pi/MagicMirror/modules/MMM-voice/node_helper.js:369:3)
0|MagicMir |     at Module._compile (module.js:642:30)
0|MagicMir |     at Object.Module._extensions..js (module.js:653:10)
0|MagicMir |     at Module.load (module.js:561:32)
0|MagicMir | { Error: Cannot find module 'pocketsphinx-continuous'
0|MagicMir |     at Module._resolveFilename (module.js:543:15)
0|MagicMir |     at Function.Module._resolveFilename (/home/pi/MagicMirror/node_modules/electron/dist/resources/electron.asar/common/reset-search-paths.js:35:12)
0|MagicMir |     at Function.Module._load (module.js:473:25)
0|MagicMir |     at Module.require (module.js:586:17)
0|MagicMir |     at require (internal/module.js:11:18)
0|MagicMir |     at Object. (/home/pi/MagicMirror/modules/MMM-voice/node_helper.js:14:13)
0|MagicMir |     at Object. (/home/pi/MagicMirror/modules/MMM-voice/node_helper.js:369:3)
0|MagicMir |     at Module._compile (module.js:642:30)
0|MagicMir |     at Object.Module._extensions..js (module.js:653:10)
0|MagicMir |     at Module.load (module.js:561:32) code: 'MODULE_NOT_FOUND' }
/home/pi/.pm2/logs/MagicMirror-out.log last 15 lines:
0|MagicMir | Module helper loaded: MMM-Remote-Control
0|MagicMir | No helper found for module: clock.
0|MagicMir | Initializing new module helper ...
0|MagicMir | Module helper loaded: calendar
0|MagicMir | Initializing new module helper ...
0|MagicMir | Module helper loaded: MMM-quote-of-the-day
0|MagicMir | No helper found for module: currentweather.
0|MagicMir | No helper found for module: weatherforecast.
0|MagicMir | No helper found for module: worldclock.
0|MagicMir | Initializing new module helper ...
0|MagicMir | Module helper loaded: MMM-MTA-NextBus
0|MagicMir | Whoops! There was an uncaught exception...
0|MagicMir | MagicMirror will not quit, but it might be a good idea to check why this happened. Maybe no internet connection?
0|MagicMir | If you think this really is an issue, please open an issue on GitHub: https://github.com/MichMich/MagicMirror/issues
0|MagicMir | Launching application.
Commenting it out of the config file got my page up and running again w/out the voice module. Any clue as to what to do?

From your logs it looks like you executed the installer as sudo. /root/MagicMirror/...
Thats why he can't find the directory because it doesn't exist. Your stuff is located at /home/pi/MagicMirror/...
Don't run the installer as sudo

Ok, I've been following the tips already given in  and arrived at this error in the debug log:
"pocketsphinx_continuous: error while loading shared libraries: libpocketsphinx.so.3: cannot open shared object file: No such file or directory"
Icon on screen says error undefined.
I am once again lost.

try this one https://forum.magicmirror.builders/topic/6939/mmm-voice-setup-but-magicmirror-wont-display/28

Thank you so much, that did it.
It is up and running, although still mocking me, it will activate, write out the commands I say, but does not execute any of them.

The debug shows it understands what I am saying, yet it does nothing.

I did get the icon to blink once, once, but it did not respond to the command that time either.

it will not run any command as long as you didn't select a mode https://github.com/fewieden/MMM-voice#select-mode

I'm sorry to be a pest, but could you further explain that to me?
I've tried saying "hide", "show", "wake", "go", "open" and "close" and have had no luck.

This module has the concepts of the different components:

wake word
mode
commands

The wake word needs to be said every time the listener is timed out.
The mode needs to be the first word (except the first word is the wake word then it needs to be second), but only needs to be said once. The current mode gets displayed next to the microphone icon. When you want to change the mode to a different mode (https://github.com/fewieden/MMM-voice/wiki/Supported-Modules), it has to be the first word again. Commands will only be detected for the module of the current mode, to avoid conflicts that two modules have the same commands.
Once you are in a mode the mirror is listening to your commands that get send to the related module, which is parsing the command and acts on it.
I hope it is now more clear for you.
As long as you are not able to enter the voice mode (text voice next to the mic icon), the mirror never will act on your commands.

Got it.  Thank you so much for your help.
Sorry for the delayed response, life got very hectic the past few days.


Arbitrary dim for slice

Add arbitrary dim support for slice op(https://github.com/tensorflow/tensorflow/issues/8873)
There is still a compiling problem. When build //tensorflow/core/kernel:slice_op_test，I got the following errors:
ERROR: /home/parallels/Desktop/github/tensorflow/tensorflow/core/kernels/BUILD:1153:1: Linking of rule '//tensorflow/core/kernels:slice_op_test' failed: gcc failed: error executing command /usr/bin/gcc -o bazel-out/local-opt/bin/tensorflow/core/kernels/slice_op_test '-Wl,-rpath,$ORIGIN/../../../_solib_k8/' -Lbazel-out/local-opt/bin/_solib_k8 -pthread '-fuse-ld=gold' -Wl,-no-as-needed ... (remaining 6 argument(s) skipped): com.google.devtools.build.lib.shell.BadExitStatusException: Process exited with status 1.
bazel-out/local-opt/bin/tensorflow/core/kernels/_objs/slice_op/tensorflow/core/kernels/slice_op.o:slice_op.cc:function tensorflow::SliceOp<Eigen::ThreadPoolDevice, Eigen::QInt8>::Compute(tensorflow::OpKernelContext*): error: undefined reference to 'void tensorflow::internal::SliceSimple<Eigen::ThreadPoolDevice, Eigen::QInt8>(Eigen::ThreadPoolDevice const&, tensorflow::Tensor*, tensorflow::Tensor const&, tensorflow::gtl::ArraySlice<long long> const&)'
bazel-out/local-opt/bin/tensorflow/core/kernels/_objs/slice_op/tensorflow/core/kernels/slice_op.o:slice_op.cc:function tensorflow::SliceOp<Eigen::ThreadPoolDevice, Eigen::QUInt8>::Compute(tensorflow::OpKernelContext*): error: undefined reference to 'void tensorflow::internal::SliceSimple<Eigen::ThreadPoolDevice, Eigen::QUInt8>(Eigen::ThreadPoolDevice const&, tensorflow::Tensor*, tensorflow::Tensor const&, tensorflow::gtl::ArraySlice<long long> const&)'
bazel-out/local-opt/bin/tensorflow/core/kernels/_objs/slice_op/tensorflow/core/kernels/slice_op.o:slice_op.cc:function tensorflow::SliceOp<Eigen::ThreadPoolDevice, Eigen::QInt32>::Compute(tensorflow::OpKernelContext*): error: undefined reference to 'void tensorflow::internal::SliceSimple<Eigen::ThreadPoolDevice, Eigen::QInt32>(Eigen::ThreadPoolDevice const&, tensorflow::Tensor*, tensorflow::Tensor const&, tensorflow::gtl::ArraySlice<long long> const&)'

It looks like there are some types which haven't be instantiated. However, I can't find that where are these type used. And simply add these instantiation is not a good idea. Could you give some help? @girving

Can one of the admins verify this patch?

I think the SliceSimple problem is that you are declaring instantiations for Slice in a file that defines SliceSimple.  But the place that uses Slice doesn't know that you've already instantiated it, so it instantiates it again (wasting code).  And the file that declares SliceSimple doesn't know that SliceSimple needs to be used outside of that file, so it does a locally visible instantiation (or perhaps inlines everything.
Bottom line: You should declare instantiations of stuff you define in that file, not other stuff.

Jenkins, test this please.

Why are we merging the cpu_impl files?  As I understand it, they take a long time so that's why we split them.

fixed compiling problem and pass python unit test

@girving could you test this code please?

Unfortunately I no longer work at Google, and am currently on vacation.
@drpngx: Can you take over?

Jenkins, test this please.
@girving yes, on it!

ERROR: /workspace/tensorflow/stream_executor/BUILD:39:1: undeclared inclusion(s) in rule '//tensorflow/stream_executor:cuda_platform':
this rule is missing dependency declarations for the following files included by 'tensorflow/stream_executor/cuda/cuda_event.cc':
  'bazel-out/local_linux-opt/genfiles/external/local_config_cuda/cuda/include/cuda.h'.

@drpngx seems the error is about latest changes in 'tensorflow/stream_executor/cuda/cuda_event.cc'. I update my code to master, Could you test it again? Thank you.

Jenkins, test this please.

@drpngx add impl_*.cc files back, pls review and run test

Jenkins, test this please.

Is there anything I need to do?

@aselle I've added some benchmark, Please take a look.

@aselle @drpngx can you please take another look?

@aselle @drpngx friendly ping

@aselle @drpngx ping?

Jenkins, test this please.

@drpngx uncollapse the for loop by Duff's device, pls take a look. Thank you.

Jenkins, test this please.

If you had some benchmarks for before/after, please report them here. That would help.

Yes, but I can't find the output of benchmark result. I read the rest log, there isn't benchmark result there. Could you tell me where to get the benchmark result? thanks.

@drpngx ping

We don't have a benchmark for slice. Can you create a program to run on a large number of random values, exercising both cases when the outer and inner loop have different sizes?

Jenkins, test this please.

Jenkins, test this please.

Could you rebase this PR on top of master?
Also, was the comment by @drpngx addressed?

sorry, removed line ">>>>>>>"

Jenkins, test this please.


now I use pandas==0.24.2,so how i used the modin on windows,thanks

now I use pandas==0.24.2,so how i used the modin on windows,thanks

Is there a specific reason for using pandas release which is 3 years old now?.. That said, latest Modin that supports that ancient pandas version is somewhere around 0.5.3 or 0.5.4, but that's missing a lot of features we put in during these 3 years.

some projects are coded using pandas==0.24.2,so if upgrade the pandas to latest version,there would be somewhere not compatible，so keep use pandas==0.24.2。
thanks


No way to clear market categories after selected in market creation

Need to add an x or someway to clear if a category is selected, so user doesnt need to go all the way back to the beginning to change it

there is now an x or enter into custom- closing


Add a new version of Dynosaur, Lumos Planning & Lumos Grounding

Hi,
I have updated the Dynosaur, Lumos Planning & Lumos Grounding according to the human-verified license, text source information. Please let me know if there're any issues.
Best,
Da

@WadeYin9712 this looks great! Please run the tests and let me know if there are any warnings or it passes everything?

Thank you! It passes all the test!


Support to set operation name which returns from server side

Many people use URI-include-parameters style URI, when this happen, compress mechanism in 3.2 will fail, even cost more memory than before. In order to resolve this, for HTTP, if our agent is at server side, it can return formatted-URI through HTTP response by instrument SpringMVC, like /product/order/{orderId}.
For doing this, we also need to support to set empty or null operation name when creating exit/entry span. This is a tricky solution provided by @pengys5 .
Further more, in some next version, we can use URI pattern recognition mechanism at collector side, and downstream the patterns for resolve this situations more complete.
cc @ascrutae

Provide getFeedback at entryspan, the plugin can choose to set them into the response head.

@pengys5 This relates to the service dependency tree. If an exit span is set the feedback, a field (isPeerTraced) is Boolean set value true, which means the peer node is being traced. So collector can ignore the relationship between the exit service and the entry service, because the peer will build this relationship by ref and entry. Otherwise, collector build the dependency relationship between these two.


Update examples to use the new SpatialRDD.spatialPartitioning(partitioner) API

Also, removed unused UserSuppliedXXXMapper classes.

Hi @mbasmanova , please do not remove the user supplied mappers. Those mappers are templates for users.

@jiayuasu , sorry, didn't realize that. I'll put them back in.


Server stalls indefinitely

Introduction
I have unfortunately not been able to arrive at a clear minimal reproducer (and will try more over next couple of days) but I frequently encounter a scenario where the server stops responding and all requests gets stuck in pending state. SQLPage becomes completely unusable for all pages/users until the server is restarted.
I do not see any error in the logs and the Memory/CPU usage stays low (~9.5 MB, ~0) and constant when/after this happens.
Some of our queries are expensive and we don't mind these pages taking long while we are iterating on the final outcome (I am able to run them from psql) but it would be ideal if this didn't impact the availability of the server as whole.
Screenshots

Expected behavior
Server should stay functional.
Version information

OS: Ubuntu
Database Postgres (RDS)
SQLPage Version main

This is concerning! Did you try to run SQLPage in debug mode (RUST_LOG=debug) to see where exactly it it stalls?
You can control logging with RUST_LOG=sqlpage=trace to get even more logging, but only from sqlpage, not dependencies.

I had tried debug before but that was not informative. After enabling trace I could see a message about pg pool getting exhausted
[2024-01-15T11:32:47.926Z TRACE sqlpage::webserver::http] Received item from database: Error(Unable to acquire a database connection to execute the SQL file. All of the 6 Postgres connections are busy.

    Caused by:
        pool timed out while waiting for an open connection)
[2024-01-15T11:32:47.927Z ERROR sqlpage::render] SQL error: Unable to acquire a database connection to execute the SQL file. All of the 6 Postgres connections are busy.

    Caused by:
        pool timed out while waiting for an open connection

This was strange because:

I had no idea where the 6 limit was coming from. The default pool size should be 50.
It never recovered from this, irrespective of connection timeout duration.

So I increased the pool size to 100 in sqlpage.json and this message disappeared.
However the problem remains. After a few dozen or so refreshes my server hangs - I can reproduce this locally too with a locally running postgres so likely not related to RDS or my front proxy config.

Where exactly does it stall ? You don't even see the initial log about the incoming http connection ?
What do you see on the database side ? How many connections do you see opened and are they busy ?

If I comment out the cache.insert(..) here this no longer happens.

Can you try to make a small docker composer reproduction, or add more trace logging to understand where it stalls ? It would be strange for the hashmap insertion to be what hangs.

Potentially relevant: https://github.com/xacrimon/dashmap/issues/233

Interesting ! Can you try replacing the dashmap with a simple RwLock<HashMap<...>> and report if this fixes the issue ? If so, can you make it a pr ?

std::sync::RwLock based impl was getting stuck too. But using tokio::sync::RwLock seems to resolve the problem.
PR: https://github.com/lovasoa/SQLpage/pull/193

Great that the issue is fixed. However, looking at the code, it seems that we don't really need to hold the lock across an async boundary, do we ?
It happens because of the if let, but we could cheaply clone the Cached object and immediately release the lock, couldn't we ?
I'm a bit hesitant to change the code again if I cannot reproduce the original issue locally. Do you think you could add a test in https://github.com/lovasoa/SQLpage/tree/main/tests that breaks with the old implementation and passes with the new one ?

Do you think you could add a test in https://github.com/lovasoa/SQLpage/tree/main/tests that breaks with the old implementation and passes with the new one ?

I am not too sure about me able to do this, but I'll try over the next week. My familiar with both rust and concurrent systems is quite nascent.

looking at the code, it seems that we don't really need to hold the lock across an async boundary...

We kind of do, because we update the access time in cache after verifying that the file has not been modified on disk (and this check is async).
To validate this though, I attempted a workaround which retains dashmap but drops the ref obtained from cache before the async call and reloads it from cache after it. This too seems to solve the problem.
Maybe its just that I am not used to low level programming, but this kind of limitation in a library appears to be a footgun in async heavy code.
Nevertheless, if you prefer to retain dashmap, here is an updated PR that retains dashmap and appears to work fine without stalling.


Version parsing regression for Go binaries

What happened:
Coming from Syft v1.9.0 to v1.10.0, Syft changed how it parses versions for Go binary main modules: cases where where it used to surface v1.2.3 (mapping exactly to the module's version) now show as 1.2.3, which is less correct. Ideally we'd keep the correct strings in place, and avoid introducing more change than necessary to existing behavior.
Note that non-main modules appear to still parse correctly (with v if the module itself has v).
What you expected to happen:
No change from v1.9.0 — previous behavior was correct here. 🙏
Steps to reproduce the issue:
(using zsh or similar)
$ syft -q =(curl -sL https://packages.wolfi.dev/os/aarch64/thanos-0.35.1-r3.apk | tar -Oxz usr/bin/thanos)
...
github.com/thanos-io/thanos                                                          0.35.1                                     go-module
github.com/themihai/gomemcache                                                       v0.0.0-20180902122335-24332e2d58ab         go-module
github.com/tklauser/go-sysconf                                                       v0.3.10                                    go-module
github.com/tklauser/numcpus                                                          v0.4.0                                     go-module
...

Here, github.com/thanos-io/thanos is the main module. And it doesn't have any versions/tags of 0.35.1 — see https://github.com/thanos-io/thanos/tags.
Anything else we need to know?:
Some discussion in the community Slack before filing this: https://anchorecommunity.slack.com/archives/C019BUXV7R6/p1722433767717669
Environment:

Output of syft version:

Application: syft
Version:    1.10.0
BuildDate:  2024-07-30T16:13:26Z
GitCommit:  a4b5dcd0df80f6a58c8610e25104647710c1da5d
GitDescription: v1.10.0
Platform:   darwin/arm64
GoVersion:  go1.22.5
Compiler:   gc

OS (e.g: cat /etc/os-release or similar): latest macOS

👋 Thanks @luhring - I think this regression is actually a case where the previous behavior you were seeing was a happy accident:
Here is the build data I extracted from thanos-io
ldflags = {string} "-X github.com/prometheus/common/version.Version=0.35.1 -X github.com/prometheus/common/version.Revision=086a698b2195adb6f3463ebbd032e780f39d2050 -X github.com/prometheus/common/version.Branch=HEAD -X github.com/prometheus/common/version.BuildUser=root@7cdd991973d2 -X github.com/prometheus/common/version.BuildDate=20240703-04:53:15  -extldflags '-static'"
mainModule = {string} "github.com/thanos-io/thanos"

Here syft was keying off of github.com/prometheus/common/version.Version=0.35.1 and associating it to thanos. If thanos is keeping their versioning inline with prometheus that is just another coincidence/convention syft was not determining but instead relying on.
When I examine the old path there was not a point where we would check if the main module matches the ldflags of what is passed in.
This is the PR that fixed this check:
https://github.com/anchore/syft/pull/3062
You can see in the old path a prefix of v is required before returning:
https://github.com/anchore/syft/blob/a4b5dcd0df80f6a58c8610e25104647710c1da5d/syft/pkg/cataloger/golang/parse_go_binary.go#L275-L286
In the new code path we do not return because of the mismatch and instead rely on our regex capture groups checking the contents of the binary:
https://github.com/anchore/syft/blob/a4b5dcd0df80f6a58c8610e25104647710c1da5d/syft/pkg/cataloger/golang/parse_go_binary.go#L217-L227
Here we return the same answer as the previously executed codepath, but this time without guaranteeing a prefix of v like the other block.
I think the initial fix is to first move all the concerns of a v prefix for all matched versions to a higher order function. Probably here after we've determined version != ""
https://github.com/anchore/syft/blob/a4b5dcd0df80f6a58c8610e25104647710c1da5d/syft/pkg/cataloger/golang/parse_go_binary.go#L180-L187
Happy to hear your thoughts though on the discovery here.
Do you think PR #3062 is correct?
Should syft fail to extract a version here given we're matching on pretty flimsy evidence on the content extraction as noted by the comment here:
https://github.com/anchore/syft/blob/a4b5dcd0df80f6a58c8610e25104647710c1da5d/syft/pkg/cataloger/golang/parse_go_binary.go#L217-L227


they aren't fake...

          they aren't fake...

Originally posted by @vaxerski in https://github.com/hyprwm/Hyprland/issues/5182#issuecomment-2010842012
Okay, I had no idea that the same error lines should apper multiple time in some cases indicating the same problem, but now I know thats expected behavior

i didnt mean to open a new issue. oopd


ipywidgets (4.1.1) doesn't display textbox

The below code is supposed to display a textbox when executed; it doesn't in Chrome and Opera and I have not seen a single browser where it does work. Additionally, there are no error messages.
This is using Python 2.7.10.
from ipywidgets import widgets
from IPython.display import display
text = widgets.Text()
display(text)

def handle_submit(sender):
    print text.value

text.on_submit(handle_submit)

Expected behaviour: see a text box in which I can type something.

This code works for me in IPython 4.0.1 using Python 2.7.11 and ipywidgets 4.1.0 but I've had a lot of trouble using widgets that "should" work so I sympathize. What version of IPython are you using? One thing that has helped me is to restart ipython and try again without any other code getting in the way.

@aragnon sounds like an install failure.  If you look in your web dev console you'll probably see "comm" related errors.  I've implement cross context version validation in https://github.com/ipython/ipywidgets/pull/303 , which should make problems like this noisy.  Let me know if you need further help debugging your installation.  When pip installing the widgets, try using --verbose to see what exactly is going on.


[SUPPORT] Flink DataStream API support Hive catalog

Tips before filing an issue

Have you gone through our FAQs?

Join the mailing list to engage in conversations and get faster support at<EMAIL_ADDRESS>

If you have triaged this as a bug, then file an issue directly.

Describe the problem you faced
I write to hudi table using Flink DataStream API, and I hope to manage metadata with hms.
The code I wrote is as follows, but I don't know how to import Hive catalog.

To Reproduce
Steps to reproduce the behavior:

write data with Flink DataStream API.
show tables on hms.

Expected behavior
The table can be seen in hms.
Environment Description

Hudi version : 0.13.0

Flink version :  1.14

Hive version : 1.2.1

Hadoop version : 2.7.6

Storage (HDFS/S3/GCS..) : HDFS

Running on Docker? (yes/no) : no

Additional context
I noticed that org.apache.hudi.util.HoodiePipeline initializes the TableEnvironment, but does not support the passing of parameters.
that currently hudi does not support writing data using api and synchronizing metadata to hms, is my understanding correct？

Stacktrace
Add the stacktrace of the error.

Yeah, we do not implement the API for custom catalog.

Thanks～


Add setter func for base.HasKind.kind

Added a setter for base.HasKind.kind

Fixes #312

@s-heppner please review


xds: handle wildcard TypeURI

Handle wildcard xDS proto.
Signed-off-by: edu<EMAIL_ADDRESS>
Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
No

Codecov Report

Merging #2938 (9624f10) into main (59d18f0) will decrease coverage by 0.06%.
The diff coverage is 5.88%.

@@            Coverage Diff             @@
##             main    #2938      +/-   ##
==========================================
- Coverage   65.18%   65.11%   -0.07%
==========================================
  Files         153      153
  Lines        6928     6946      +18
==========================================
+ Hits         4516     4523       +7
- Misses       2386     2397      +11
  Partials       26       26

Flag
Coverage Δ

unittests
65.11% <5.88%> (-0.07%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/envoy/ads/grpc.go
0.00% <0.00%> (ø)

pkg/envoy/ads/stream.go
5.34% <0.00%> (-0.49%)
:arrow_down:

pkg/envoy/types.go
0.00% <ø> (ø)

pkg/envoy/ads/response.go
72.52% <100.00%> (-0.32%)
:arrow_down:

cmd/cli/namespace_add.go
64.15% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d18f0...9624f10.


Finish pending tests for aroundAll

As part of #71 , I wrote some pending specs but forgot to finish writing them. Specifically, these ones. This issue is a reminder to finish those up when the dust settles.

Will wait for #77  to merge first, but this is the desired behavior:
describe("the aroundAll hook in multiples", () -> {

  it("each subsequent aroundAll nests inside those preceding", () -> {
    ArrayList<String> steps = new ArrayList<>();
    SpectrumHelper.run(() -> {

      aroundAll(block -> {
        steps.add("pre1");
        block.run();
        steps.add("post1");
      });

      aroundAll(block -> {
        steps.add("pre2");
        block.run();
        steps.add("post2");
      });

      it("first spec", () -> {
        steps.add("spec");
      });

    });

    assertThat(steps, contains("pre1", "pre2", "spec", "post2", "post1"));
  });

  it("fail if any aroundAll forgets to call the block", () -> {
    Result result = SpectrumHelper.run(() -> {

      aroundAll(block -> {
        block.run();
      });

      aroundAll(block -> {
      });

      aroundAll(block -> {
        block.run();
      });

      it("a spec", () -> {
      });

    });

    assertThat(result.getFailureCount(), is(1));
  });

});

These actually fail on master FWIW. They already pass on #77.


Skip begin_checkout event when completing payment or reload page on placed orders

Closes #394

What I did

How to test

Checklist

[x] Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
[x] Make sure to add/update documentation regarding your changes.
[x] You are NOT deprecating/removing a feature.

:tada: This PR is included in version 4.2.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Read the Docs defaulting to 0.10

Switching from latest to stable shows 0.11 in the changelog.

When renaming master to main, don't forget to tell readthedocs that you did it! :)

Had a sneaking suspicion that was the trigger. 😄  Had the same thing happen to me a couple of times.


chore(blueprints): upgrade karma-coverage-istanbul-reporter

I've just added threshold reporting to this lib which might be handy for some users 😄

Superseded by https://github.com/angular/angular-cli/pull/5237


checkpoint cannot be loaded

The checkpoint file in DQN/dqn/checkpoint seems to be invalid.
self.load_model() in agent_8.py returns the following error
[*] Loading checkpoints...
2019-07-23 16:57:57.724805: W tensorflow/core/framework/op_kernel.cc:1275] OP_REQUIRES failed at save_restore_v2_ops.cc:184 : Not found: Key prediction/7_lq_1/biases not found in checkpoint
Traceback (most recent call last):
  File "/anaconda3/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1278, in _do_call
    return fn(*args)
  File "/anaconda3/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1263, in _run_fn
    options, feed_dict, fetch_list, target_list, run_metadata)
  File "/anaconda3/lib/python3.6/site-packages/tensorflow/python/client/session.py", line 1350, in _call_tf_sessionrun
    run_metadata)
tensorflow.python.framework.errors_impl.NotFoundError: Key prediction/7_lq_1/biases not found in checkpoint
	 [[Node: save/RestoreV2 = RestoreV2[dtypes=[DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, ..., DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_FLOAT, DT_INT32], _device="/job:localhost/replica:0/task:0/device:CPU:0"](_arg_save/Const_0_0, save/RestoreV2/tensor_names, save/RestoreV2/shape_and_slices)]]

During handling of the above exception, another exception occurred:

etc...

dqn_model_ckpt-13400.data-00000-of-00001 seems to contain the model data. However, my attempt to load this as checkpoint is unsuccessful too.
 [*] Loading checkpoints...
 [!] Load FAILED: ./dqn/checkpoint
 [*] Created model with fresh parameters.

Sorry, the checkpoint file we upload is for agent_18.py. Its structure is a little different from the one in agent_8.py, which cause the loading failure.
Please use the agent_18.py as agent file


mouse without borders

Microsoft PowerToys version
0.87 and 0.86
Installation method
GitHub
Running as admin
Yes
Area(s) with issue?
Mouse Without Borders
Steps to reproduce
Hello,
Since upgrading to version 0.87, Souris sans frontière no longer works.
Removed 0.87, re-installed 0.86 and nothing.
Connection on the same network.
Generated a new key, nothing.....
In short, 5 hours of searching and nothing.
Everything was perfect until the update.
Bilou
Bonjour,
Depuis le passage à la version 0.87, Souris sans frontière ne fonctionne plus.
Suppression de la 0.87, ré-install 0.86 et plus rien.
Connexion sur le même réseau.
Génération d'une nouvelle clé, rien.....
Bref, 5h de recherche et rien.
Tout était parfait jusqu'à la mise à jour.
Bilou
✔ Expected Behavior
No response
❌ Actual Behavior
No response
Other Software
No response

Hi @bilou47190 , no changes were made to mouse without borders on 0.87.0. Can you please check if Firewall might be blocking mouse without borders? On Settings there's a button to try to add a rule to add it to the Firewall exceptions. /needinfo


Add Tomcat Container with REST API

Single Tomcat Container with Swagger and RADAR REST API

First solution RADAR-CNS/RADAR-RestApi@2ad6d95


Fullscreen doesn't work correctly with astraea example

I wanted to try pyglet but it seems like the full screen mode has some issues, at least with my current configuration:

Linux Mint 19.3 Cinnamon (x11)
Latest commit on the pyglet-1.5-maintenance branch (3bdaa237c0b60371c9326762daedcd6584f3bbc0)

Here's what I get after switching the astraea game example into full screen mode:

Hi, could you tell me what desktop environment this is with?
Also, are you using Wayland?
I'm not able to replicate it on my local machine (Arch, vanilla Gnome).

Hi, could you tell me what desktop environment this is with?

Sure, I'm using Cinnamon.

Also, are you using Wayland?

No, I'm running X11.

I'm not able to replicate it on my local machine (Arch, vanilla Gnome).

Thanks for taking the time to try to replicate :)

I ran Astraea a few times and I did see this happen, but only the first time it ran. None of my subsequent runs exhibited the issue. Does this happen if you run it more than once on your machine? I might have an idea which could help but I can't really test it since I only saw it happen once in ~20 runs.

Does this happen if you run it more than once on your machine?

I've tried that about 10 times on my machine and the problem occurred for each single try.

It's looking like the Astraea example will be retired, since it's quite full of legacy OpenGL code. It wouldn't be practical to update it for pyglet 2.0 (and modern OpenGL), and also it's lacking external documentation. Instead, the much more simplistic example/game should be considered it's replacement. It's not as fleshed out, but it's better suited as an example due to it's tutorial in the pyglet documentation.
Sorry for leaving this hanging so long!


want to make the :core subproject independent on the guava library

v0.9.3, the :core subproject depends on the guava library.
https://github.com/kazurayam/materialstore/blob/0.9.3/core/build.gradle
I want to make the :core dependent on no other external libraries to run.
Is it passible to more or remove the dependency on guava ?

I've found that it is very difficult (impossible) the make the :core project dependent on NO external libraries.
See com.kazurayam.materialstore.util.JsonUtil depends on Gson:
https://github.com/kazurayam/materialstore/blob/0.9.3/core/src/main/java/com/kazurayam/materialstore/util/JsonUtil.java

I checked what is included in the runtimeClasspath of the :core project
$ gradle -q :core:dependencies --configuration runtimeClasspath

------------------------------------------------------------
Project ':core'
------------------------------------------------------------

runtimeClasspath - Runtime classpath of source set 'main'.
+--- com.google.code.gson:gson:2.8.2
+--- commons-io:commons-io:2.11.0
+--- org.apache.httpcomponents:httpclient:4.5.1
|    +--- org.apache.httpcomponents:httpcore:4.4.3
|    +--- commons-logging:commons-logging:1.2
|    \--- commons-codec:commons-codec:1.9 -> 1.15
+--- org.apache.httpcomponents.client5:httpclient5:5.1.3
|    +--- org.apache.httpcomponents.core5:httpcore5:5.1.3
|    +--- org.apache.httpcomponents.core5:httpcore5-h2:5.1.3
|    |    \--- org.apache.httpcomponents.core5:httpcore5:5.1.3
|    +--- org.slf4j:slf4j-api:1.7.25
|    \--- commons-codec:commons-codec:1.15
+--- org.slf4j:slf4j-api:1.7.25
\--- com.google.guava:guava:31.1-jre
     +--- com.google.guava:failureaccess:1.0.1
     +--- com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
     +--- com.google.code.findbugs:jsr305:3.0.2
     +--- org.checkerframework:checker-qual:3.12.0
     +--- com.google.errorprone:error_prone_annotations:2.11.0
     \--- com.google.j2objc:j2objc-annotations:1.3

(*) - dependencies omitted (listed previously)

as checked https://github.com/kazurayam/materialstore/blob/0.9.3/core/src/main/java/com/kazurayam/materialstore/filesystem/Metadata.java I found :
import org.apache.http.NameValuePair;
import org.apache.http.client.utils.URLEncodedUtils;

got to https://github.com/kazurayam/materialstore/issues/281

I removed depencencies on httpclient# libraries completely


ressources/wiringPiWrap.c: No such file or directory

I was not able to import wiringPiNim.
When I imported it and compiled it, the following error appeared.

gcc: error: ressources/wiringPiWrap.c: No such file or directory
gcc: fatal error: no input files
compilation terminated.
CC: stdlib_dollars.nim
Error: execution of an external compiler program 'gcc -c  -w -fmax-errors=3   -I/usr/lib/nim -I/home/pi/project/apps/demo -o /home/pi/.cache/nim/test_d/wiringPiWrap.c.o ressources/wiringPiWrap.c' failed with exit code: 1

I then checked my .nimble folder and realized that just running nimble install wiringPiNim did not include the libraries I needed.
So, I created a pull request that solves this problem.

Related pull requests⏬
https://github.com/ThomasTJdev/nim_wiringPiNim/pull/4


CMake bug in pip installer for  canopy-sdk

Is this a new bug?

[X] I believe this is a new bug
[X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior
The pip installer for canopy-sdk fails.
Expected Behavior
I expect the pip installer to be work.
Steps To Reproduce
In the command prompt run: python -m pip install canopy-sdk
Relevant log output
Collecting sentencepiece<0.2.0,>=0.1.99 (from canopy-sdk)
  Using cached sentencepiece-0.1.99.tar.gz (2.6 MB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [47 lines of output]

 CMake Deprecation Warning at CMakeLists.txt:15 (cmake_minimum_required):
        Compatibility with CMake < 3.5 will be removed from a future version of
        CMake.

        Update the VERSION argument <min> value or use a ...<max> suffix to tell
        CMake that the project does not need compatibility with older versions.

      -- VERSION: 0.1.99
      CMake Error at CMakeLists.txt:23 (project):
        Generator

          NMake Makefiles

        does not support platform specification, but platform

          x64

        was specified.

      CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage
      CMake Error: CMAKE_CXX_COMPILER not set, after EnableLan

Environment
- **Windows 10**:
- **Python 3.12.1**:
- **Latest pip**:
- **CMake 3.28.1**:

Additional Context
My suspicion is that sentencepiece-0.1.99.tar.gz needs an earlier version of CMake., or sentencepiece is essentially (currently) incompatible with Python 3.12.1.  See https://github.com/google/sentencepiece/issues/932 .

@gaoptimize as stated before canopy currently has no support for Python 3.12. We are planning to add support for Python 3.12 in the upcoming months.


Add benchmarks for HTTP2 implementation

@Scottmitch
@nmittler
We need micro and macro benchmarks for the implementation. Lets use this issue to track discussion of what needs to be added and then we can fork out issues as necessary to track individual work items.
From the discussion on #3372 it seems like the underlying transport impl may be material to how writes are done.
Microbenchmarking seems appropriate for

cost of individual frame-writer methods
locking behavior over HPACK updates (perhaps that moves into the HPACK project)
flow-control accounting updates
state checking in encoder / decoder

macrobenchmarking seems appropriate for

Typical usage scenarios over various transports (OIO, NIO, native-EPoll, Local, domain socket)

stress testing seems appropriate for

Flow-control queue depth edge-cases
Flow-control pathological behaviors (small-windows, slow-server, slow-client)
Flaky client / server (random stream resets)
Large client connection counts and with periodic client churn

Thoughts?

@louiscryan - Sounds good.  The PR https://github.com/netty/netty/pull/3392 provides the 2 highest profile frame writer methods.  This PR may also provide good building blocks for many of the other benchmarks.  Are you interested in submitting PRs?

@louiscryan - I will be submitting a simple benchmark which exercises the priority tree.

I'll take this assignment for now...just so it doesn't get left behind.  No immediate plans to work on this however.

@louiscryan - Is this on your radar still?

Sort of. We wrote a bunch for GRPC which cover a great deal of what would be needed for HTTP2 so they act as a pretty good proxy. Its not a high priority for me right now to port those into Netty itself though.

@louiscryan slacker :beer: =P
Do you have a link to benchmarks or are these internal ?

They're all public
https://github.com/grpc/grpc-java/tree/master/benchmarks/src/jmh/java/io/grpc/benchmarks/netty


Add keyboard shortcut to show/hide the team bar

The team bar is rarely accessed, and most probably just use the cmd+1, cmd+2  shortcuts. This will allow us to free up some of that valuable horizontal screen space.

I am open to supporting this. Do you know if the official Slack clients have this shortcut/what it's Linux equivalent would be?

I do not see the equivalent in the Windows version. However, it's more useful there because it has notification badges on organization logos.

No, unfortunately, the official slack client does not support a show/hide feature.

@mathieumg Notification badges are planned in #39 but we were mostly waiting on the React refactor before adding more features to port
@distracteddev Hmm, that makes me more hesitant on this feature then =/
If we were to add that feature, the current sort order between teams for the sidebar is based on load order. I imagine that if we added this, then we would want something more consistent (e.g. alphabetical). Any idea what order the official clients sort teams by?

Notification badges are planned in #39 but we were mostly waiting on the React refactor before adding more features to port

Yeah I think I saw that, thanks for the reminder! :)

Any idea what order the official clients sort teams by?

I think it's the order you added the teams in, by default, but it can easily be overridden through drag and drop of the team icons.

@mathieumg Ah, alright. Thanks for the info =) I guess we will have to refine how we manage that data in future PRs =)

+1 for hide/show team toolbar functionality, either via menu or via shortcut. It will give extra screenwidth


Sign up and login page logo after clicking upon it it didn't redirect to home page

Description
Sign up and login page logo after clicking upon it, it didn't redirect to home page
Screenshots
https://github.com/TechNodes2-0/ElectiveHub/assets/125277258/4633c524-bed1-45f4-a2c5-b7d5cb6a4595
Additional information
it didn't redirect to home page
What browser are you seeing the problem on?
Chrome, Microsoft Edge
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I want to work on this issue. (optional)

hi @Yash636261 can you assign it to me under GSSOC 24 i want to work upon it.

assigning to you @RamakrushnaBiswal, you can start working on it.


Hyperparameter search on base models

Following up on the conversation here https://github.com/microsoft/mup/issues/11 since it wasn't related to the original issue.
How exactly should the learning rates be split up when doing hyperparameter search on the base model? You said input/hidden/output, but Table 8 groups all biases with input weights. Does the output bias also fall into the input/bias group? (it has finite fan-in and fan-out, unlike the other biases which have infinite fan-out)

Hi Davis,
Scaling-wise, all biases, including that of the output layer, should be scaled in the same way as the input layer if we are implementing muP in the style of Table 8. That is because the last layer is calculated as f(x) = Wx / fan_in + b, where the division by fan_in corresponds to the parameter multiplier. To make f(x) change by \Theta(1), the change to b needs to be \Theta(1) as well.
In terms of HP search, it's probably sufficient to just sweep the input/output/hidden split as Greg suggested since the learning rate for biases, unless it's too large and destabilizes the model, doesn't matter too much.

the last layer is calculated as f(x) = Wx / fan_in + b
Ah I had mistakenly implemented (Wx + b) / fan_in, so I was confused. Thanks for the pointers.


Release date/rough time estimate before React Router 6 will be released

Is it possible to have a rough time estimate before React Router 6 will be released? I noticed it has been in beta 0 since January.

Good question. I also want to know this. But @mjackson and @ryanflorence are kind of silent in the last weeks and months.

They're working on Remix, so who knows.

Don't let the pre-release tag stop you from using v6, it's an excellent release as-is! We have been using beta0 in production for a while now without any issues.

For those of you who don't follow Ryan on twitter, or missed it: https://twitter.com/ryanflorence/status/1317168547064238081 and https://twitter.com/ryanflorence/status/1317215384710250497
So what @Zertz said 👍

@beckerei Good news.

Release v6 won't change API.

sao it is been Lon long time..., next time I will think more before use react router next version, I was thinking they will release sooner.
btw good project.

Release v6 won't change API.
yeah, but the funny part is - before matching was built around path-to-regexp package, but in v6 they gonna use their own implementation instead of that package.

@plandem, "v6 won't change API" is a reference from the current beta to release candidate.

I hope it's okay to keep the thread updated with information from twitter.

Excited to get back to shipping React Router v6 stable soon. We know what it needs after using it to build Remix.
Better API, more features, and only 3.1kb over the network!
Far cry from v5 that's like 12kb or 14kb or something ridiculous (embarrassing?) like that.
https://twitter.com/ryanflorence/status/1337512362014752768

And some more

But we'll be bringing over some of the remix data loading APIs and other small features from Remix.
https://twitter.com/ryanflorence/status/1337517106007474176

@beckerei now @ryanflorence and @mjackson only have to merge the pending pull requests and change the confusing part with the root route definition. I mean, what the h**l is <Route path="/" /> and why is it not <Route path="" />? It's totally inconsistent!

I have multiple projects blocked by #7423 and #7216. Second one seems to have a solid pull request.
How about merging what is merge-able and releasing a new beta for now?

😑 Should probably be marked fresh, an issue asking for when v6 will be released shouldn't be auto-closed
by a bot just because people are waiting for an update.

😑 Should probably be marked fresh, an issue asking for when v6 will be released shouldn't be auto-closed
by a bot just because people are waiting for an update.

I agree

Recent tweet says hope is to release by Summer 2021. Also linked to transitions page referencing one of the remix features they intend to incorporate: https://gist.github.com/ryanflorence/fc67c2b689c5ecdca7185763a92f120a

@mjackson  i'm sure many developers would be thrilled to maintain this lib.
Can you open it to other maintainers ?

Hi Team,
Is there any update related to v6. Has been betav0 for more than an year now with no releases. Would be interested to contribute if required to speed up the release

They're working on Remix, so who knows.

If anything, the way they ignore everyone on this thread is not a good sign as to how they envision communication. I probaby won't touch Remix given how they lag this v6. Most people don't even know that the "dev" branch is the actual v6. And the readme is not giving any help either.

React is dead, pls move to vue with awesome vue router (with named routes & so on)

We are picking up work again on v6, should probably release within the next month or so. Thanks for your patience! It’s going to be the best work we’ve ever done on the router, I can promise you that.

Is it possible to fix a basename issue first of all? As it is a show stopper for many who try to move existing projects from v5/v4. I mean PR:
https://github.com/ReactTraining/react-router/pull/7462
May be do beta2 ASAP and other issues later?

We are picking up work again on v6, should probably release within the next month or so. Thanks for your patience! It’s going to be the best work we’ve ever done on the router, I can promise you that.

cool guys, you are now deleting the comments of others who were not so patient
I think I've seen everything now

Just an update on this, I'll be helping Michael on react-router full-time starting in a couple of weeks. A v6 major release is my top priority and I'm helping him organize/prioritize issues in the mean time. We appreciate your patience, but know that v6 stable is as crucial for Remix as it is for all of you, and we're very excited to roll it out soon. 🥳
I suspect you'll see one more beta with lots of known bug fixes, but we also need to finish up the docs so there's still a bit of work to be done. I'll try to keep this issue updated as we move in that direction.


Raw Data Array

Hello,
Example used: ULAIO1 (from ui)
I am trying to write data from an analog input into another file at 1000 Herz.
Right now my solution is using the variable eng_value to write. I tried finding out what the original array is where all the raw analog input data is being saved but cannot find it.
I know the a_in function is involved, but can't find where it draws the values from.
Thanks in advance,
Max

Thank you for your fast and helpful answer!
Next up I am trying to generate a column displaying a clock/timer (similiar to the count value, but relying on time). Is there a function in the Universal Library taking care of this? If threre was, I would be saving some time coding one myself.

Unfortunately there is no UL function for that.


adds fullWidth variant for radio buttons

Description

In order to render these new radio buttons that take up half the available width, I'm adding a new fullWidth prop to radio buttons.

looking good ✨  I'm a little concerned about the fixed height this has. lets make sure it will work for the implementation ie. per the design we want 2 lines of subtext but this cuts the 2nd line off
so maybe we use min-height instead and let it grow in height as it needs?


Fix the remaining handful of failing tests in tarball (stable) m4

Current list is:
Failed checks were:
./005.command_li:out ./006.command_li:out ./006.command_li:err ./137.include:err

#5: If I run:
echo | cat >&- 2>/dev/null
echo $?

from 'bash', I get 0 (this is not what is expected - the file descriptor &- should be invalid).
If I run the same sequence of 2 instructions from 'sh', I get 1.
If I run
m4 <test.m4, where test.m4 is:
syscmd(`echo | cat >&- 2>/dev/null')ifelse(sysval, `0',
       `errprint(` skipping: system does not allow closing stdout
')m4exit(`77')')dnl
changequote(`[', `]')dnl
syscmd([echo | ']__program__[' >&-])dnl
sysval

on my Mac, I get:
/usr/bin/m4: write error: Bad file descriptor
1

whereas on z/OS (either inside sh or inside bash) I get:
0

I thought this might be a more general problem where 'sysval' was not being correctly set, but this works:
esyscmd(`echo "jello" | grep "hello world' ")ifelse(sysval, `0',
       `errprint(` skipping: system does not allow closing stdout
')m4exit(`77')')dnl
sysval

(i.e. it prints out 1)

Note that there is a patch for the 'include' error but it is labeled as a 'gitpatch' and so won't be applied by default. This is because it is a .texi file and would require makeinfo (and therefore perl) to be able to build. Also - the 'right' fix is probably to either make m4 smarter and ignore the EDCxxxx message or have LE suppress it.

i think this one makes sense to put to the side for now until we get 'bash' built (since bash seems wrong here too).

Opening a defect against bash for this...
On z/OS I get:
echo | >&-

but on Mac I get:
echo | >&-
cat: stdout: Bad file descriptor

which seems right


Update links to the exact section and update 1 broken link

Summary

A few links were broken (ie, redirected back to the home page of the documentation section)
A few links redirected to a the relevant page but not to the exact section (ie, if someone wanted to know how about Integrity and Audit Controls, the link would go to "security.html" and not "security.html#integrity-and-audit-controls" (I suspect this happened as the pages/path were renamed from deployment to deploy for example which breaks the # value after the redirect happens).

Ticket Link
N/A
Similar to #4792, #4795 and #4804

Hello @arjitc,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.


Version of the software
0.2.5
Operating system
Windows 10
Browser / Native
Native
What happened?
I wanted to Import my Proxy file but it didnt work:
"InvalidOperationException The calling thread cannot access this object because a different thread owns it"
What can i do?
Relevant LoliCode if needed
No response

I have the same problem, I think it happened after the last update


Add testSelectActiveConnection test

Adds a test that selects the currently active connections.

Codecov Report

Merging #364 (031be75) into main (7524022) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #364   +/-   ##
=======================================
  Coverage   41.99%   41.99%
=======================================
  Files         117      117
  Lines        8091     8091
=======================================
  Hits         3398     3398
  Misses       4693     4693


Zinnia/admin/entry classes conflict with bootstrap

Actual behavior
expanding fieldsets are set to display none
Expected behavior
open, close
I did some digging and found that it would be a really simple change (at least here) to get it compatible
simply adding the 'in' class to each one of the field entries make it work as expected.
'classes': ('collapse', 'collapse-closed')}),
to
'classes': ('collapse in', 'collapse-closed')}),
Steps to reproduce the issue

override admin template, add bootstrap
/admin/zinnia/entry/add
click show on any fieldset

Specifications
I checked all three of your current branches, stylesheet collision would still occur
Disclaimer
Please read these questions carefully and answer honestly with an x
into all the boxes [ ]:

[ ] I have read the guidelines for contributing linked to above.
[x] I have checked for duplicate issues.
[x] This is not a support request.

Hello,
Do you have an example to reproduce the step one ?
In this way I can see the fix.

Sorry, I didn't see the reply until you closed it.
https://getbootstrap.com/docs/4.0/components/collapse/
bootstrap's collapse class  hides content where as your collapse class shows content.
The conflict is in admin/entry.py
https://github.com/Fantomas42/django-blog-zinnia/blob/develop/zinnia/admin/entry.py
and possibly other places, after having thought about it since creating the issue.
I fixed the issue personally by adding a second class 'in' and changing the css to be
.collapse.in { }

Not elegant in the least but it resolved the conflict in my particular situation.
Furthermore,  I don't think this would be trivial to fix because it would be a breaking change for anyone that has extended the fieldsets.


Sampler, LR fix and tests for sampler and models

I still have a handful of tests I plan to write, but I can add those in the next PR. Also note I pulled other changes elsewhere, so that I could work with the updated continuous ThompsonSampler.

I think what I will do is hopefully finishi running the Bayesian optimisation tests overnight/tomorrow and then put in a PR and merge those in first since those will have since been updated from when you merged them into your branch. And then this will allow me to just reject all of those files when merging this branch in to avoid dealing with the merge conflict that would arise.

I implemented most suggested changes. Thanks!

its a bit difficult to review this one (66 files) as it seems you have merged in latest trieste here, but it hasnt been done on the target branch

I assume that was my doing, as i worked towards amending the sampler to
take into account the new N x B x d inputs. Anything we can do on our end
to facilitate the work?
David
Le jeu. 14 avr. 2022 à 14:44, Hrvoje Stojic @.***> a
écrit :

its a bit difficult to review this one (66 files) as it seems you have
merged in latest trieste here, but it hasnt been done on the target branch
—
Reply to this email directly, view it on GitHub
https://github.com/clinton0313/trieste/pull/6#issuecomment-1099147141,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOYML5EKOSPEXLH6U5CP54DVFAHJTANCNFSM5S5L7SAA
.
You are receiving this because you authored the thread.Message ID:
@.***>

did you merge in smth from original trieste repo?
or perhaps, what was the branch you were on when you created a new branch? it should have had been the target branch
clinton_david/mcdropout

in the meantime perhaps you can tell me what files you were working on, just the sampler.py? any test file?

I merged your de-sampler update branch into mine, to account for changes
beyond our code re. the sampler. I was then mostly working on the sampler,
model tests and sampler tests these last few days.
El vie, 15 abr 2022 a las 8:49, Hrvoje Stojic @.***>)
escribió:

in the meantime perhaps you can tell me what files you were working on,
just the sampler.py? any test file?
—
Reply to this email directly, view it on GitHub
https://github.com/clinton0313/trieste/pull/6#issuecomment-1099899479,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOYML5BCZD65UDOQHDDKRUTVFEGRBANCNFSM5S5L7SAA
.
You are receiving this because you authored the thread.Message ID:
@.***>