SassCompiler messes with tests (and my head)

Hi @Taritsyn,
I'm currently trying to integrate DartSassHost into https://github.com/excubo-ag/WebCompiler/. I have one test failure on linux systems, which completely baffles me. I've reduced it now to this tiny case:

test.csproj

<Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
    <TargetFramework>net6.0</TargetFramework>
    <IsPackable>false</IsPackable>
  </PropertyGroup>
  <ItemGroup>
    <PackageReference Include="DartSassHost" Version="1.0.0-preview3" />
    <PackageReference Include="JavaScriptEngineSwitcher.ChakraCore" Version="3.9.1" />
    <PackageReference Include="JavaScriptEngineSwitcher.ChakraCore.Native.linux-x64" Version="3.9.1" />
    <PackageReference Include="JavaScriptEngineSwitcher.ChakraCore.Native.win-x64" Version="3.9.1" />
    <PackageReference Include="NUnit" Version="3.13.2" />
    <PackageReference Include="NUnit3TestAdapter" Version="4.0.0">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
    </PackageReference>
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.11.0-release-20210626-04" />
  </ItemGroup>
</Project>

test.cs

using DartSassHost;
using NUnit.Framework;
using JavaScriptEngineSwitcher.ChakraCore;
using System.IO;

namespace Namespace
{
    public class Class
    {
        [Test]
        public void Method()
        {
            File.WriteAllText("test.scss", "");
            var result = new DartSassHost.SassCompiler(new ChakraCoreJsEngineFactory())
                .CompileFile("test.scss");
            Assert.AreNotEqual("hello", "hello");
        }
    }
}

As you can see, this simply compiles an empty scss file (so nothing should go wrong with that, same happens when the file isn't empty). It then continues to check whether "hello" is not equal to "hello", which on Windows systems produces the expected output
Failed Method [70 ms]
Error Message:
   Expected: not equal to "hello"
But was:  "hello"

Stack Trace:
  at Namespace.Class.Method() in /src/test.cs:line 26

However, on linux, this happens:
The active test run was aborted. Reason: Test host process crashed

Test Run Aborted with error System.Exception: One or more errors occurred.
 ---> System.Exception: Unable to read beyond the end of the stream.
   at System.IO.BinaryReader.Read7BitEncodedInt() in System.Private.CoreLib.dll:token 0x60056bc+0x0
   at System.IO.BinaryReader.ReadString() in System.Private.CoreLib.dll:token 0x60056b2+0x6
   at Microsoft.VisualStudio.TestPlatform.CommunicationUtilities.LengthPrefixCommunicationChannel.NotifyDataAvailable() in Microsoft.TestPlatform.CommunicationUtilities.dll:token 0x6000026+0x8
   at Microsoft.VisualStudio.TestPlatform.CommunicationUtilities.TcpClientExtensions.MessageLoopAsync(TcpClient client, ICommunicationChannel channel, Action`1 errorHandler, CancellationToken cancellationToken) in Microsoft.TestPlatform.CommunicationUtilities.dll:token 0x6000064+0xa0
   --- End of inner exception stack trace ---.

Getting things to this stage, I would have thought this has nothing to do with DartSassHost. However, if you remove the compilation step, the behavior is as expected (i.e. test failure, rather than crash).
using DartSassHost;
using NUnit.Framework;
using JavaScriptEngineSwitcher.ChakraCore;
using System.IO;

namespace Namespace
{
    public class Class
    {
        [Test]
        public void Method()
        {
            File.WriteAllText("test.scss", "");
            //var result = new DartSassHost.SassCompiler(new ChakraCoreJsEngineFactory())
            //    .CompileFile("test.scss");
            Assert.AreNotEqual("hello", "hello");
        }
    }
}

Do you have any idea what's going on here?
Best regards,
Stefan

It seems to depend on the linux version used. I can reproduce this weirdness with the following dockerfile:
FROM mcr.microsoft.com/dotnet/sdk:6.0-focal

WORKDIR /src

COPY test.csproj .
RUN dotnet restore test.csproj

COPY test.cs .
RUN dotnet build --no-restore
RUN dotnet test --no-restore

Hello, Stefan!
Unfortunately, at the moment I do not have the ability to test this error. I will try to do this at the beginning of next week.
If I were you, I would try to do two things:

Run this example under .NET 5, because .NET 6 is still unstable
Replace the JavaScriptEngineSwitcher.ChakraCore  module by the JavaScriptEngineSwitcher.V8 module, because for the last two years there have been problems in work of the ChakraCore library under Linux on latest versions .NET Core.

I would also add the using statement to source code of this example.

Hi Andrey,
No worries, no need to rush into testing this.
What I've observed so far is:

occurs on net5.0 too, just doesn't display the exception message, just "Test host process crashed".
JavaScriptEngineSwitcher.V8 produces a different exception:

  Failed Method [347 ms]
  Error Message:
   DartSassHost.SassCompilerLoadException : During loading of Sass compiler error has occurred. See the original error message: “RangeError: Array buffer allocation failed
   at new M (DartSassHost.Resources.es6-polyfills.min.js:8:10976) -> ….name!=j})){for(y=(M=function(t){return _(this,M),new D(I(t))})[R]=D[R],p=A(D),h=0;p.length>h;)(g=p[…
   at DartSassHost.Resources.es6-polyfills.min.js:8:11073
   at DartSassHost.Resources.es6-polyfills.min.js:8:12556
   at DartSassHost.Resources.es6-polyfills.min.js:8:43928”.
  ----> JavaScriptEngineSwitcher.Core.JsRuntimeException : RangeError: Array buffer allocation failed
   at new M (DartSassHost.Resources.es6-polyfills.min.js:8:10976) -> ….name!=j})){for(y=(M=function(t){return _(this,M),new D(I(t))})[R]=D[R],p=A(D),h=0;p.length>h;)(g=p[…
   at DartSassHost.Resources.es6-polyfills.min.js:8:11073
   at DartSassHost.Resources.es6-polyfills.min.js:8:12556
   at DartSassHost.Resources.es6-polyfills.min.js:8:43928
  ----> Microsoft.ClearScript.ScriptEngineException : RangeError: Array buffer allocation failed
  ----> Microsoft.ClearScript.ScriptEngineException : RangeError: Array buffer allocation failed
  Stack Trace:
     at DartSassHost.SassCompiler.Initialize()
   at DartSassHost.SassCompiler.CompileFile(String inputPath, String outputPath, String sourceMapPath, CompilationOptions options)
   at Namespace.Class.Method() in /src/test.cs:line 14
--JsRuntimeException
   at JavaScriptEngineSwitcher.V8.V8JsEngine.InnerExecute(String code, String documentName)
   at JavaScriptEngineSwitcher.Core.JsEngineBase.ExecuteResource(String resourceName, Assembly assembly)
   at DartSassHost.SassCompiler.Initialize()
--ScriptEngineException
   at Microsoft.ClearScript.V8.SplitProxy.V8SplitProxyNative.ThrowScheduledException()
   at Microsoft.ClearScript.V8.SplitProxy.V8SplitProxyNative.Invoke(Action`1 action)
   at Microsoft.ClearScript.V8.SplitProxy.V8ContextProxyImpl.InvokeWithLock(Action action)
   at Microsoft.ClearScript.V8.V8ScriptEngine.ScriptInvoke[T](Func`1 func)
   at Microsoft.ClearScript.V8.V8ScriptEngine.Execute(UniqueDocumentInfo documentInfo, String code, Boolean evaluate)
   at Microsoft.ClearScript.ScriptEngine.Execute(DocumentInfo documentInfo, String code)
   at Microsoft.ClearScript.ScriptEngine.Execute(String documentName, Boolean discard, String code)
   at JavaScriptEngineSwitcher.V8.V8JsEngine.InnerExecute(String code, String documentName)
--ScriptEngineException
   at Microsoft.ClearScript.V8.SplitProxy.V8SplitProxyNative.ThrowScheduledException()
   at Microsoft.ClearScript.V8.SplitProxy.V8SplitProxyNative.Invoke[T](Func`2 func)
   at Microsoft.ClearScript.V8.SplitProxy.V8ContextProxyImpl.Execute(UniqueDocumentInfo documentInfo, String code, Boolean evaluate)
   at Microsoft.ClearScript.V8.V8ScriptEngine.ExecuteRaw(UniqueDocumentInfo documentInfo, String code, Boolean evaluate)
   at Microsoft.ClearScript.V8.V8ScriptEngine.ExecuteInternal(UniqueDocumentInfo documentInfo, String code, Boolean evaluate)
   at Microsoft.ClearScript.V8.V8ScriptEngine.<>c__DisplayClass103_0.<Execute>b__0()
   at Microsoft.ClearScript.ScriptEngine.ScriptInvokeInternal[T](Func`1 func)
   at Microsoft.ClearScript.V8.V8ScriptEngine.<>c__DisplayClass110_0`1.<ScriptInvoke>b__0()
   at Microsoft.ClearScript.V8.SplitProxy.V8SplitProxyManaged.InvokeHostAction(IntPtr pAction)

I would also add the using statement to source code of this example.

Sorry, which using statement?

RangeError: Array buffer allocation failed

Very similar to a lack of memory. Memory for ArrayBuffer in the V8 is allocated in a special way. In addition, an error occurred at the initialization stage of Sass compiler.
Maybe there is not enough memory allocated in the docker?

Sorry, which using statement?

I meant that you need to dispose resources manually, and not rely on finalization:
[Test]
public void Method()
{
    File.WriteAllText("test.scss", "");
    using (var sassCompiler = new DartSassHost.SassCompiler(new ChakraCoreJsEngineFactory()))
    {
        var result = sassCompiler.CompileFile("test.scss");
    }
    Assert.AreNotEqual("hello", "hello");
}

RangeError: Array buffer allocation failed

Very similar to a lack of memory. Memory for ArrayBuffer in the V8 is allocated in a special way. In addition, an error occurred at the initialization stage of Sass compiler.
Maybe there is not enough memory allocated in the docker?

This sounds unlikely to me, given my experience with far more involved docker images.

Sorry, which using statement?

I meant that you need to dispose resources manually, and not rely on finalization:
[Test]
public void Method()
{
    File.WriteAllText("test.scss", "");
    using (var sassCompiler = new DartSassHost.SassCompiler(new ChakraCoreJsEngineFactory()))
    {
        var result = sassCompiler.CompileFile("test.scss");
    }
    Assert.AreNotEqual("hello", "hello");
}

That's it! Both with ChakraCore and V8, adding the sassCompiler.Dispose() (or the using block) resolves the issue. I wonder what the actual problem is though...

I wonder what the actual problem is though...

Problem is lack of memory. Node.js version of Dart Sass has a very large size (sass.dart.js file weighs about 4 megabytes). Therefore, JS engines requires a large amount of memory to execute it. Manual disposing frees up memory almost instantly.
Same applies to the Autoprefixer Host library. Only there the JS file size is slightly smaller.

I'm not convinced that this is true. I can allocate 1GB within the test and not dispose it without any hiccup:
using NUnit.Framework;
using System;
using System.Diagnostics;
using System.Runtime.InteropServices;

namespace Namespace
{
    public class Class
    {
        [Test]
        public void Method()
        {
            var disposable = new Disposable(); // undisposed
            var proc = Process.GetCurrentProcess();
            Assert.LessOrEqual(1024 * 1024 * 1024, proc.PrivateMemorySize64);
            Assert.AreNotEqual("hello", "hello");
        }
    }
    public class Disposable : IDisposable
    {
        private readonly IntPtr ptr;
        public Disposable()
        {
            ptr = Marshal.AllocHGlobal(1024 * 1024 * 1024);
        }

        public void Dispose()
        {
            Marshal.FreeHGlobal(ptr);
        }
    }
}

Hello, Stefan!
Code from your last example will lead to native memory leak. If you don't believe me, then run a benchmark, which is located in attached file. In my benchmark, I allocate not 1GB, but only 2MB, so that it does not fail during execution. I got the following results:
|         Method |     Mean |     Error |  StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated | Allocated native memory | Native memory leak |
|--------------- |---------:|----------:|--------:|------:|------:|------:|----------:|------------------------:|-------------------:|
|    WithDispose | 303.7 ms |  58.86 ms | 3.23 ms |     - |     - |     - |      24 B |             2,097,152 B |                  - |
| WithoutDispose | 307.6 ms | 105.75 ms | 5.80 ms |     - |     - |     - |      24 B |             2,097,152 B |        2,097,152 B |

As for running the DartSassHost in conjunction with a JavaScriptEngineSwitcher.ChakraCore module under Linux, there really is an error here. Segmentation fault occurs during call of finalizer of the ChakraCoreJsEngine class. Moreover, such an error never occurs on Windows or macOS. It is absolutely certain that this error occurs in the ChakraCore library. Situation is complicated by the fact that Microsoft no longer supports this library, and community has not yet made its own release.
As for the JavaScriptEngineSwitcher.V8 module, there are no problems with it. Most likely, when running a large number of tests, you just ran out of memory. This happened due to the fact that there were many objects in the finalization queue, and memory simply did not have time to be cleared.
DisposableBenchmark.zip

Hi Andrey,

Code from your last example will lead to native memory leak.

Yes, but that's besides the point. You said that the problem of crashing tests was lack of memory. I only doubt that, because I can allocate much more memory (and not even clean it up) without any issue. In fact, I can even also allocate another GB in managed memory and still not run into any memory issue.

As for running the DartSassHost in conjunction with a JavaScriptEngineSwitcher.ChakraCore module under Linux, there really is an error here. Segmentation fault occurs during call of finalizer of the ChakraCoreJsEngine class. Moreover, such an error never occurs on Windows or macOS. It is absolutely certain that this error occurs in the ChakraCore library. Situation is complicated by the fact that Microsoft no longer supports this library, and community has not yet made its own release.

Okay, so the take away here is to ditch ChakraCore. Thanks for making it so trivial to switch between the engines! 🎉


clone of renamed root branch starts at rename

I'm running v0.28 with TFS client library <IP_ADDRESS> (64-bit) and encountered the following.
Assume i'm trying to clone $/myproduct/Trunk.
This is actually a rename of an older $/myproduct/Core/BranchMain (which has since been deleted)
When running git tfs clone on $/myproduct/Trunk it start the history at the moment of rename, cause the loss of history of the changes in its original branchname.
Any way to fix this or work around it?

There's not much you can do. I have the same situation in my repository. It gets really ugly really fast to fix these kinds of things.
One thing I'm fairly confident git-tfs is not doing is passing an option to TFS to retrieve deleted branches. I think if this could be done, then it may be possible to reconstruct this kind of history. I just haven't had time to look into it.


file upload with Express

Hi.
I am using Express middleware 'multer' and want to make array of uploaded file names.
exports.create = function(req, res) {
    var images = [];
    for (var i=0;i<req.files.file.length;i++) {
      images.push(req.files.file[i].name);
      console.log(req.files.file[i].name);
}

but, resulting images array is [undefined, "image1.jpg", "image2.jpg", .......].
printed log is as expected.
image0.jpg
image1.jpg
image2.jpg
what's the problem?
Thanks in advance.

I too need some help getting some form data plus files uploaded with multer middleware..

Can you post here the request headers and content that being sent to the server from your browser's debug tool.


Naive fix for Playlist returns empty list

YouTube has updated their links on playlist web pages from an href tag to a JSON object. Changed the _video_regex to match.

Hi @Bill0412, I got notified that you requested changes but I can't seem to find what you requested. Is there something that I need to do?
Apologies, this is literally my first pull request :P

Thank you so much! I've been pulling my hair out over this issue since I have no clue how pytube's backend works lol.

Okay, this is weird to ask, but where do I put my playlist link in this code? I've been programming for only 6 months so this code is enormous to me and I can't find where to put my playlist URL. Also, is there a line for choosing a path for where to save the files? Thank you!

Okay, this is weird to ask, but where do I put my playlist link in this code? I've been programming for only 6 months so this code is enormous to me and I can't find where to put my playlist URL. Also, is there a line for choosing a path for where to save the files? Thank you!

No worries. The code shown in this thread is a change made to the pytube library to fix a bug. Your own code then uses this library to let you interact with pytube.
To use the playlist:
playlist = Playlist(playlistURL)  Place this either in the main part of your program, or within the function in which it needs to be accessed. Doesn't really matter as long as you place it after
'from pytube import Playlist '
The playlist line above will get an array of URLs, each corresponding to a video in the playlist. You can view the urls with 'print(playlist)', and reference them with 'playlist[x]', with x being the index of the URL in the array. Remember that arrays start at 0!
Feel free to message me with any more questions so we don't clog up this thread.

Thank you very much for the fix!

Implemented a complete implementation, which should replace this fix. #687

Hi @Bill0412, I got notified that you requested changes but I can't seem to find what you requested. Is there something that I need to do?
Apologies, this is literally my first pull request :P

I meant that your pull request was really useful for me. You did an excellent job!
Hope the owner of the repository could adopt your pull request ASAP! Currently I've got to modify the code myself before each installation.

Apologies for the late replies. Since I think everything seems fixed, I'll be closing this.
Thanks @tooxo for the better fix. I haven't tried it out myself but I trust that it's far more durable. Glad it's been merged.


fixed serialization issues with maestro types

Used Result instead of ValidationNEL in Validator, as scalaz types have problems with kryo
Had to disable the accumulation of errors in Validator.all, as Result errors don't combine
Used Result instead of / in Tag, as scalaz tpyes have problems with kryo
Made serializer in LoadEx lazy, so that it doesn't get serialized
Moved DateTimeFormatter in Check.isDate outside of the function, and made it lazy, so it
doesn't have to be recreated for every row, but still doesn't interfere with serialization

NO TESTS YET: I still need to figure out what serialization tests look like. But I wanted to get some feedback on these changes in the meantime, as some of them might be a little controversial.

@stephanh are you happy with this now?

:+1:

Does this also address #353?

Yes, and #142, I think (although that arguably should have been closed when we switched APIs).

merged


Implement video.src media stream attachment via MutationObserver

<html>
	<head>
		<style>
			#v {
				width: 100px;
				height: 50px;
				background-color: green;
				z-index: 6;
			}
		</style>
<script>
//Observe of changes of the video element
var videoObserver = new MutationObserver(function(mutations) {
	//For each mutation
	mutations.forEach(function(mutation) {
		//Get video element
		var video = mutation.target;
		//Get BLOB from src
		var xhr = new XMLHttpRequest();
		xhr.open('GET', video.src, true);
		xhr.responseType = 'blob';
		xhr.onload = function () {
			var reader = new FileReader();
			reader.addEventListener("loadend", function() {
				console.log("MediaStream id: " + reader.result);
			});
			reader.readAsText(this.response);
		};
		xhr.send();
	});
 });

//Observes dom additions/deletion in document node and childrens
var observer = new MutationObserver(function(mutations) {
	//For each mutation
	mutations.forEach(function(mutation) {
		//Check if there has been addition or deletions of nodes
		if (mutation.type==='childList') {
			//Check added nodes
			for (var i=0; i<mutation.addedNodes.length; i++) {
				if (mutation.addedNodes[i].nodeName==='VIDEO') {
					console.log('added video element');
					//Add src observer
					videoObserver.observe(mutation.addedNodes[i],{
						childList: false,		// Set to true if additions and removals of the target node's child elements (including text nodes) are to be observed.
						attributes: true,		// Set to true if mutations to target's attributes are to be observed.
						characterData: false,		// Set to true if mutations to target's data are to be observed.
						subtree: false,			// Set to true if mutations to not just target, but also target's descendants are to be observed.
						attributeOldValue:false,	// Set to true if attributes is set to true and target's attribute value before the mutation needs to be recorded.
						characterDataOldValue:false,	// Set to true if characterData is set to true and target's data before the mutation needs to be recorded.
						attributeFilter: ['src']	//Set to an array of attribute local names (without namespace) if not all attribute mutations need to be observed.
					});
				}
			}
			//Check removed nodes
			for (var i=0; i<mutation.removedNodes.length; i++) {
				if (mutation.removedNodes[i].nodeName==='video') {
					console.log('removed video element');
				}
			}
		}
	});
});

observer.observe(document,{
	childList: true,		// Set to true if additions and removals of the target node's child elements (including text nodes) are to be observed.
	attributes: false,		// Set to true if mutations to target's attributes are to be observed.
	characterData: false,		// Set to true if mutations to target's data are to be observed.
	subtree: true,			// Set to true if mutations to not just target, but also target's descendants are to be observed.
	attributeOldValue:false,	// Set to true if attributes is set to true and target's attribute value before the mutation needs to be recorded.
	characterDataOldValue:false,	// Set to true if characterData is set to true and target's data before the mutation needs to be recorded.
	//attributeFilter		// Set to an array of attribute local names (without namespace) if not all attribute mutations need to be observed.
});

		</script>
	</head>
	<body>
		<video id="v" style="z-index:1;"></video>
	</body>
</html>

<script>
	var id = '123456';
	//Create Blob with id as data
	var stream = new Blob([id], {type : 'application/octet-stream'});

	//Get url from blob
	v.src = URL.createObjectURL(stream);
</script>

Phase Two! XD


docs: update windows release notes for 2024-07B

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Add windows image release notes for new AKS Windows images with 2024-07B. Reference: #[xxxxx].
Which issue(s) this PR fixes:

Fixes #
Requirements:

[x] uses conventional commit messages

[x] includes documentation
[ ] adds unit tests
[ ] tested upgrade from previous version

Special notes for your reviewer:
Release note:
none

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.021%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
2566

Relevant Lines:
3613

💛  - Coveralls


Merged CodeQL workflow into main workflow.

followup on https://github.com/apache/roller/pull/113
This is a workaround which ensures that the test reports end up in the correct workflow.
example:
JUnit reports of:
https://github.com/apache/roller/actions/runs/1627718913
ended up here:
https://github.com/apache/roller/actions/runs/1627718912
If there is just one workflow, they can't end up in the wrong one :)

looks like the CodeQL alerts are going to be reset (reported as new issues, while the old are removed) since the job is started from a different file.
but the aggregation is working: https://github.com/apache/roller/pull/114/checks

closing in favor of #119


What is the development status?

What is the development status?
The documentation page gives 404, I couldn't find the package on PyPI, and the repo didn't get any commit since last year.

we use it heavily in some internal projects...

we use it heavily in some internal projects...

That's great to hear. Will there be a release?


Fix deprecations warning

Dict module
Float.to_string/2

Thanks. Apologies for the delay in responding. I have closed this with commit #04cb8f here


[TODO] Download progress bar

add a download progress bar

I would consider this done, since that features has been implemented since August 2022 see 5c8601f2228cfadcc6751e04847434631a88e9ef

Closing issue, since feature has been implemented in 5c8601f2228cfadcc6751e04847434631a88e9ef


Duplicate key runtime error when creating/connecting to online repo

Hi all,
I get a duplicate key runtime error (cx_sy_itab_duplicate_key) when connecting to a certain online repository for a package with several sub-packages, see source code/call stack below.
History (as far as I remember): I had an online repository running for sub-package B of super-package A, which was running smoothly. Then I tried to add  an online repository for A (including all sub-packages), which failed because B was already connected to git. So I removed the repository for B and afterwards I tried to add the repository for A (including all sub-packages) again, and then the runtime error occurred. The online-repository for A was created, but the runtime error occurs every time I try to connect. I already tried to remove and add the repo for A again, but the issue is still there.
I have the feeling that some leftovers from the original repo for B or from the failed attempt to add the repo for A are causing trouble.
Any idea how this could be solved?
Best,
Jonathan

Hi Jonathan,
the root cause is related to OTR texts (object type SOTS). What is the value for iv_extra?
For a more detailed analysis, identify the package causing the problem. It's in ms_item-obj_name. Then look up table SOTR_HEADU for this package (field PAKET). This will give you the concepts (of the texts) which you can then lookup in SOTR_TEXTU. Fields CONCEPT, LANGU, and OBJECT should make a unique filename (=iv_extra). Maybe there are some special characters?
Best,
Marc

Thanks for the quick reply. There seems to be an issue with case sensitivity. In my case for the given package sotr_textu-langu has different values on DB, but some of these values only differ by case. E.g. there is an entry with SAP language code "D" (= iso code "DE" = German), but also another entry for "d" (= iso code "SH" = Serbo-croation); the same happens for C/c = Czech/Catalan.
In the file name and iv_extra the langauge code is always converted to lower case. Hence the clash.

Can you test https://github.com/abapGit/abapGit/pull/5381?

With #5381 it works without issues, thanks!
One general question: To test this correction, I just changed manually the few lines of code in the standalone abapgit program. But in case of larger changes this would be cumbersome. Is it possible to generate the standalone abapgit for a given pull request or commit?

yes, it is. In remote settings, simply pick the PR and save. Then you can pull the changes. After testing, go back to the settings and pick a branch like main and save. Pull to get back to the original source.


Migrate from Travis CI to Gitlab CI

Added .gitlab-ci.yml
Deleted .travis.yml

i guess the gitlab CI build will show up once it updates the mirror.
@Frost45 can you please make sure that the test files in each stage in this YAML file match the test files in the RSMTool gitlab yaml file - I might have forgotten to keep them in sync. Let's just make sure :)

i guess the gitlab CI build will show up once it updates the mirror.
@Frost45 can you please make sure that the test files in each stage in this YAML file match the test files in the RSMTool gitlab yaml file - I might have forgotten to keep them in sync. Let's just make sure :)

I've cross checked the test sets and they are the same btw


Unable to uncheck "Disabled" checkbox

I am using Traccar version 3.9.
I created user and disabled it using his account details.
Now I tried to enable account by unchecking the "Disabled" checkbox and it is not working.

The issue is already fixed in https://github.com/tananaev/traccar-web/issues/356.

Thanks.

Same issue holds good for "Admin" and "Readonly" checkboxes

It applies for all checkboxes. Please see the linked issue.


Call to a member function loadTemplate() on null

Just upgraded to Cake 3.5.8 and TwigView 4.2.6
My App breaks with 'Call to a member function loadTemplate() on null'
Error in: ROOT/vendor/wyrihaximus/twig-view/src/View/TwigView.php, line 188
For some reason the initialize()-Funktion in TwigView is not called.
Is this a CakePHP issue?
Using versions: 3.5.6 and 4.0.2 works just fine
I will investigate and post a solution if I find one ;-)

My bad ...
Missed parent::initialize() in my AppView class
Sorry!!

No problem, glad to hear you solved your issue :+1:


cudaCheckError() failed : no kernel image is available for execution on the device

Hi,
I am trying to run the code following the instructions. However, I get a cuda check error. Editing the make.sh won't help either.
....
INFO train_net_step.py: 230: 10022 roidb entries
INFO train_net_step.py: 231: Takes 2.30 sec(s) to construct roidb
INFO train_net_step.py: 367: Training starts !
INFO net.py:  52: Changing learning rate 0.000000 -> 0.000167
cudaCheckError() failed : no kernel image is available for execution on the device
...
I installed pytorch with conda and have a TitanV.
Thanks in advance

I have not met this problem before. But you can refer to here or try to use Docker.


configurable file uploader

Currently the upload service and file transmitter are hard-coded to localhost for testing purposes. We need to make it configurable, so e.g. including the automatic registration/login to seafile and building a secure connection to our server

Will change in future, also part of configuration management


Kadane's Algorithm| C++

Kadane's Algorithm -
what will change -
Type of Issue -
Please add/delete options that are not relevant.

[x] Adding New Code

Programming Language
Please add/delete options that are not relevant.

[x] C++

Self Check

Ask for issue assignment before making Pull Request.
Add your file in the proper folder
Clean Code and Documentation for better readability
Add Title and Description of the program in the file

:star2: Star it :fork_and_knife:Fork it :handshake: Contribute to it!
Happy Coding,

Can you assign me this issue?

Can I be assigned to work on this issue?


undercover-file-handler never called

Hi,
I'm setting up undercover in https://github.com/DamienCassou/hierarchy/pull/9. As you can see in the log, undercover can't find any coverage info:
UNDERCOVER: No coverage information. Make sure that your files are not compiled?

What am I doing wrong please?

I don't have anything compiled file (*.elc).
I reproduced the problem locally by:

deleting undercover.elc
adding message everywhere in its source code (poor-man debugger)
forcing the coverage with (setq undercover-force-coverage t)

What I see is that at the end of undercover--edebug-files, the file-name-handler-alist variable value is:
((/\(?:hierarchy\.el\)$ . undercover-file-handler) (\.gpg\(~\|\.~[0-9]+~\)?\' . epa-file-handler) (\(?:\.dz\|\.txz\|\.xz\|\.lzma\|\.lz\|\.g?z\|\.\(?:tgz\|svgz\|sifz\)\|\.tbz2?\|\.bz2\|\.Z\)\(?:~\|\.~[-[:alnum:]:#@^._]+\(?:~[[:digit:]]+\)?~\)?\' . jka-compr-handler) (\`/[^/]*\' . tramp-completion-file-name-handler) (\`/[^/|:][^/|]*: . tramp-autoload-file-name-handler) (\`/: . file-name-non-special))

but, undercover-file-handler never prints the message I put there.

Here are the changes I applied to undercover.el.
--- .cask/25.2/elpa/undercover-20161114.819/undercover.el	2017-03-23 10:13:50.820551685 +0100
+++ .cask.bak/25.2/elpa/undercover-20161114.819.bak/undercover.messages.el	2017-03-23 10:09:42.207369720 +0100
@@ -89,6 +89,7 @@

 (defun undercover--load-file-handler (file)
   "Handle `load' FILE operation."
+  (message "Loading file: %s" file)
   (let ((edebug-all-defs (undercover--coverage-enabled-p))
         (load-file-name (file-truename file))
         (load-in-progress t))
@@ -104,6 +105,7 @@

 (defun undercover-file-handler (operation &rest args)
   "Handle `load' OPERATION.  Ignore all ARGS except first."
+  (message "undercover-file-handler %s %s" operation args)
   (if (eq 'load operation)
       (condition-case nil
           (undercover--load-file-handler (car args))
@@ -114,9 +116,11 @@

 (defun undercover--edebug-files (files)
   "Use `edebug' package to instrument all macros and functions in FILES."
+  (message "undercover--edebug-files: %s" files)
   (when files
     (let ((regexp (->> files (regexp-opt) (format "/%s$"))))
-      (add-to-list 'file-name-handler-alist (cons regexp 'undercover-file-handler)))))
+      (add-to-list 'file-name-handler-alist (cons regexp 'undercover-file-handler))
+      (message "undercover--edebug-files: %s" file-name-handler-alist))))

 (setf (symbol-function 'undercover--stop-point-before)
       (lambda (before-index)
@@ -400,10 +404,12 @@
 (defun undercover-safe-report ()
   "Version of `undercover-report' that ignore errors."
   (ignore-errors
+    (message "Reporting...")
     (undercover-report)))

 (defun undercover-report-on-kill ()
   "Add `undercover-safe-report' to `kill-emacs-hook'."
+  (message "Adding kill hook")
   (add-hook 'kill-emacs-hook 'undercover-safe-report))

 ;;; Main functions:
@@ -462,10 +469,12 @@

 If running under Travic CI automatically generate report
 on `kill-emacs' and send it to coveralls.io."
-  `(undercover--setup
-    (list
-     ,@(--map (if (atom it) it `(list ,@it))
-              configuration))))
+  `(progn
+     (message "Measuring coverage...")
+     (undercover--setup
+      (list
+       ,@(--map (if (atom it) it `(list ,@it))
+                configuration)))))

 (provide 'undercover)
 ;;; undercover.el ends here

The output is:
$ cask exec ert-runner
Measuring coverage...
Adding kill hook
undercover--edebug-files: (hierarchy.el)
undercover--edebug-files: ((/\(?:hierarchy\.el\)$ . undercover-file-handler) (\.gpg\(~\|\.~[0-9]+~\)?\' . epa-file-handler) (\(?:\.dz\|\.txz\|\.xz\|\.lzma\|\.lz\|\.g?z\|\.\(?:tgz\|svgz\|sifz\)\|\.tbz2?\|\.bz2\|\.Z\)\(?:~\|\.~[-[:alnum:]:#@^._]+\(?:~[[:digit:]]+\)?~\)?\' . jka-compr-handler) (\`/[^/]*\' . tramp-completion-file-name-handler) (\`/[^/|:][^/|]*: . tramp-autoload-file-name-handler) (\`/: . file-name-non-special))
............................

Ran 28 tests in 0.015 seconds

Reporting...
Report files: nil
UNDERCOVER: No coverage information. Make sure that your files are not compiled?

Hi @DamienCassou, this bug happens because of your .ert-runner config. You load hierarchy.el in it.
So when you run undercover this file is already loaded and (require 'hierarchy) does nothing.
Replace .ert-runner  content with -L . and everything will work.

Btw, you can test undercover locally by using TRAVIS=true in your terminal

Sure, feel free to do it! :)

done


Update build-instructions-windows

The build instructions mistakenly said that you can find atom.exe under out\D instead of electron.exe. I fixed that and mentioned that the release build will be to out\R.

Thanks!


Function corresponding to "Heuristic" in the "Occlusion removal" option for RGB 3D pictures in Python

Required Info

Camera Model
D435

Firmware Version
<IP_ADDRESS>

Operating System & Version
Linux (Ubuntu 16)

Kernel Version (Linux Only)
4.15.0-66-generic

Platform
PC

Language
python

I am making a ".bag" viewer. I need to play a ".bag" file, and be able to switch between a color image and depth map in one window (and at the same time they should be in the same resolution)
I have a frame for depth (848x480) and color (1280x720).
And I need to combine them correctly (fit one image to another)
I tried to align the color in depth, they are combined, but I get a lot of "black spots" and offsets in my color image.
I think this would help me: https://github.com/IntelRealSense/librealsense/issues/2464
Is there any way to implement this in python?
Or is there any other way to correctly combine the two frames?

Hi @xaritonn,
You can refer to below post processing doc and apply the filters like hole filtering, etc.
https://dev.intelrealsense.com/docs/depth-post-processing
The Python API as follows.
https://intelrealsense.github.io/librealsense/python_docs/_generated/pyrealsense2.filter.html

@xaritonn , the use-case you describe is handled by the alignment processing block.
You can have it in both depth->color and color->depth ways available based on the application need. It has also been extensively discussed in multiple issues on this forum in the past, so look it up for insights.
The so-called black-spots you refer to are actually a desirable feature as during the process the pixel with no match in the target frame are removed to avoid fake results.(#5030
It is not clear what do you mean by  offset in my color image but it is possible related to a similar discussion in #5282.

The "Occlusion Removal" filter is implemented as a self-contained processing block but integrated with  the pointclound processing block only.
But since it is open-source there is no reason not to "borrows" and use it in additional use-cases as needed.

Thanks! Your answers have helped a lot.


V1.2.1

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-webservice.
I tried to re-render for you, but it looks like there was nothing to do.

I created an upstream PR (https://github.com/skvadrik/re2c/pull/256) to include the LICENSE file in the release tarball (it's only available in git currently).

Here are the files installed in the package:
├── bin
│   └── re2c
├── info
│   ├── about.json
│   ├── files
│   ├── git
│   ├── hash_input.json
│   ├── has_prefix
│   ├── index.json
│   ├── licenses
│   │   └── LICENSE
│   ├── paths.json
│   ├── recipe
│   │   ├── bld.bat
│   │   ├── build.sh
│   │   ├── conda_build_config.yaml
│   │   ├── LICENSE
│   │   ├── meta.yaml
│   │   └── meta.yaml.template
│   ├── repodata_record.json
│   └── test
│       └── run_test.sh
└── share
    ├── man
    │   └── man1
    │       └── re2c.1
    └── re2c
        └── stdlib
            └── unicode_categories.re

Thanks @isuruf for the review!


HUD side frames visible when they shouldn't

The HUD side frames might still be visible even if the option to hide them is enabled.
I can reproduce the issue by refreshing the same page multiple times, once in a while the side frames are still shown.

For info I havnt been able to reproduce this, so it could be a system dependant timing issue :/


Freemode plus centerSlides to center on active slide

I am trying to use the free mode and have set centermode to true but id does not seem to center on the active slide or snap to the active slide. Is there a way to make it use freemode but as you scroll or it stops it snaps to the active slide and centers it?

Sorry, that is why it is called free mode, it has no snaps

haha ok thanks for the quick reply! :)


-a -b & -g flags do not close the process

-a -b & -g flags do not close the process when the script finishes running. I suspect the chokidar watchers are holding it up, but closing them in a callback doesn't seem to work.

Did some testing, looks like it's the puppeteer browser not getting closed. Need to figure out where to close it in the script so that the last download is allowed to finish.


Enabling relativeURLs still results in absolute URL in OpenGraph and Twitter Card template

What version of Hugo are you using (hugo version)?

hugo v0.116.1

Does this issue reproduce with the latest release?
yes
  <link rel="canonical" href="./" />

    <link
      href="./index.xml"
      rel="alternate"
      type="application/rss+xml"
      title="my new hugo site"
    />

  <meta property="og:type" content="website" />
  <meta property="og:description" content="" />
  <meta property="og:title" content="my new hugo site" />
  <meta property="og:site_name" content="my new hugo site" />
  <meta property="og:image:type" content="image/jpeg" />
  <meta property="og:url" content="/" />
  <meta property="og:locale" content="en-us" />

  <meta name="twitter:card" content="summary" />
  <meta name="twitter:title" content="my new hugo site" />
  <meta name="twitter:description" content="" />
  <meta name="twitter:domain" content="/" />

The og:url and twitter:domain are supposed to be "./" as in

See https://gohugo.io/content-management/urls/#relative-urls
First, you really don't want to enable relativeURLs unless you are creating a serverless site, navigable via the file system.
Second, the relativeURLs search/replace only considers action, href, src, srcset, and url attributes, as documented.
Third, Hugo's builtin twitter_cards template does not write a "twitter:domain" meta element, so you must be using a custom template, perhaps provided by your theme.
Fourth, excluding scheme and host from twitter:domain or og:url doesn't make any sense. These should be absolute URLs (e.g., https://example.org/).
Finally, if you are using Hugo's built-in opengraph template, and you are seeing this...
<meta property="og:url" content="/" />

...it means that the baseURL in your site configuration is incorrect. See docs.


broken e2e tests

Why do we still have broken tests? Are we planning on releasing with broken tests, and if so why not just fix and/or remove them?

No I'm just asking what the broken tests are...I figured during development we would have broken tests, but not sure what's left that is broken - is it features that are coming in future releases? Bugs that got pushed?

Philosophically, tests represent an expression of requirements. To remove them when they don't work would be to say that we're altering requirements. To leave them says, "this is an unfinished work," and this very much is an unfinished work. In open source scenarios and under continuous integration testing as we do, we don't want to shy away from what remains to be done or what is unreliable, but rather leave it there.
Time ran out on tracking it down. Earlier in the cycle, their were broken tests that were tied to specific issues where the app was misbehaving with respect to voting and the "mine only" filter. Leaving those tests in allowed us to easily re-evaluate without even changing any test code whether the "fix was in."
As of today, there is one test marked as @broken. It sometimes works and sometimes doesn't so we consider it broken and that prevents us from tripping over it when we're evaluating whether or not our app works like we think it does.  Who knows, maybe one of our friendly neighborhood customers will fix it for us if we don't get around to it first. :wink:

Great, thanks. Is an issue logged related to the broken test?

The broken test:
https://github.com/marklogic/marklogic-samplestack/blob/10361e91ed616fad7f319825edfa278acab89169/specs/features/vote-on-question.feature#L17
@vote-on-question
Feature: Vote on Question

  Contributors may vote questions up or down. One may only vote on a question
  once. When an upvote is made to a quesiton, the author of the question
  gains reputation points. When a downvote is made to a  question, the author
  of the question loses reputation points.

  @broken @363
  Scenario: Mary votes for Joe's question
    Given I am "Mary"
    And I am using the brief seed data
    When I visit the "qnadoc" page with id "6c90b1cf-2cd8-4a8d-87ae-0c6d5182d301"
    And I focus on the question
    And the content contributor reputation is known as "reputation"
    And I vote it up
    Then the content contributor reputation is greater than "reputation"

The issue is that the test itself doesn't always see the updated contributor reputation. I just noticed that the issue number to which it is referenced (#363) is already closed, so it should probably have a new issue created and that issues id number tagged onto it.

Cross-posted. I should open a new issue and we should update the tag.

I added an issue for this broken test (#564).
I've converted your question to a task (which is to re-tag the broken test with @564 for tracking purposes.
Do you think this is worth doing another merge to the release candidate? It's easy for me to do and will have zero impact on the app, so I'm switching this to 8.0-1 to propose doing it now.

What would be in the merge? looks like you've tagged #564 for 8.0-2.

Correction of the issue number in the tag of the broken test.

Oh i get it - the re-tag. Yes that would be great for completeness. As long as it's not app-impacting I'm good with it.

This is ready to test. The only think to really test is that you can omit --tags="~@broken" and nonetheless the broken test  should still be skipped. No need to do this across platforms/browsers.

Ran e2e without the tag broken flag


TODO: docs

Partially resolved by d9ca4351dfaa311f7b2cb1aa7cc77035088dc7b7
Taking time to consider more here including examples and published rendered documentation before considering this done.


Discussion on CRTAF format

Do not merge this pull request. It is intended to serve as the beginning of a discussion.

A note about units. It would be nice if the standard could follow the FITS standard description of units, in particular compound unit strings. (See FITS standard section 4.3.)
Even better would be if the default units shown throughout this document, and in any sample atoms, would be a subset of that standard, where multiplications via * and exponents via ^. For example, instead of m3 s-1 K(-1/2) have m^3*s^-1*K^-(1/2). Both are valid in FITS and both will work fine in astropy, but the latter works out-of-the-box with Unitful in Julia, so it would be really nice if we could follow it.

A short comment to Tiago: what is always available is the A-value and that should be the default minimum. Within CHIANTI, we do have gf values sometimes but sometimes they are wrong or inconsistent. Future models will need forbidden transitions and in those cases the f values are not clearly definable. Often a transition is semi-forbidden or the A-value is the sum of A-values...  of course you could assume that all transitions are allowed and get the f value but that is dangerous. Better still would be to add an optional key to state what kind of transition we are talking about. Sometimes it is easy to say that it is an E1, or M2 or M1 or E2 etc.

As I told Chris, we need a new format and I am happy with this starting point. The key issue from the physics point of view is that we need initial and final-state resolved ionization and recombination rates. Given the framework it is trivial to do that, which is good.  I would also keep the RR and DR separate.  If the data include low transition-region ions (e.g. twice ionized) then the DR suppression starts to be non-negligible, and a zero-order correction is the sort of thing we released within CHIANTI, it could be a tabulated correction I could provide or a not-so-accurate  analytic way.

The current format is supposed to be structured, flexible but made for human viewing.  As future models could easily require a 100 states or more, to me the current format fails its purpose.  I would argue that a table of entries  for each process would be much easier to look at.   If a few transitions need rates or features that are very different from the rest, then one could yes still have them defined one by one perhaps.
What we should avoid is to spend one year discussing a format.  I was a member of vamdc and that happened, at the end a super-complicated XML format was designed to query the databases and return data, but it took almost the whole time of the grant...

Hi Giulio,
Thank you so much for your feedback, it is much appreciated.

A short comment to Tiago: what is always available is the A-value and that should be the default minimum. Within CHIANTI, we do have gf values sometimes but sometimes they are wrong or inconsistent. Future models will need forbidden transitions and in those cases the f values are not clearly definable. Often a transition is semi-forbidden or the A-value is the sum of A-values... of course you could assume that all transitions are allowed and get the f value but that is dangerous. Better still would be to add an optional key to state what kind of transition we are talking about. Sometimes it is easy to say that it is an E1, or M2 or M1 or E2 etc.

The standard (whether written or unwritten) in line formation codes (LTE and NLTE) is to provide the f-value or gf-value for each transition, also for the case of forbidden lines. But I think it would be fine to provide just Aul instead, since it is easy to convert.

The current format is supposed to be structured, flexible but made for human viewing. As future models could easily require a 100 states or more, to me the current format fails its purpose. I would argue that a table of entries for each process would be much easier to look at. If a few transitions need rates or features that are very different from the rest, then one could yes still have them defined one by one perhaps.

I am not sure which part of the format you are suggesting to replace with a table. Is the levels, the transitions (e.g. radiative_bound_bound), or the collisional rates? If it is the collisional rates, indeed this could be simplified a bit since in many processes they don't change for a range of lines. Perhaps a way forward could be to have an identifier for the each transition (as in atomic_levels, which work like a python dictionary, while the transitions are like a python list), so one could specify a rate recipe for a range of lines? If you could provide a simple example, we can work at sketching a possible solution.

I guess it depends on what you want to use the format for. If a general database for atomic data, maybe simpler tables are the way to go. This format is aimed at radiative transfer codes. From a look at atoms I typically use, most transitions have different coefficients for e.g. collisional excitation (whether CE or the dimensionless Omega is used), radiative recombination, and some recipes for dielectronic recombination. In these cases, it is not so much overhead to have them defined per transition.
About the radiative data, I don't think we should store it in a table. Of course a table is much easier to read (both human and computer), but a big downside is its inflexibility. The YAML format suggested here is a compromise between readability (e.g. pure table) and flexibility (e.g. the XML you mentioned, which has a huge overhead). Adding new information to a table, e.g. a new type of line broadening, would mean adding another column and therefore breaking compatibility with all software. One would have to update even atoms where that new column would not apply. It would also break reproducibility: make it much harder to run an updated version of a code with an old atom.
The suggested YAML format is not as easy on the eyes as cleaner tables, but it has two big advantages (for me): the ability of adding more fields in the future, and referencing levels from a keyword (e.g. lev1 instead of a number). The latter makes it easy to remove levels from atoms (something we do often to simplify calculations). With current MULTI-based format this is a major pain to do by hand: the numbers for potentially many transitions would have to be edited in many places. Sometimes it is also nice to experiment by adding or removing some of the physics from the atoms. Outsourcing this to tables of comprehensive data would make that more difficult.

I think there are good arguments on both sides here.
Addressing the easy points first:

A_ul vs f: I don't particularly mind. I'm happy to extend the high-level format so that it requires at least one of the two to be present.
Splitting out the upwards and downwards processes for ionisation/excitation is sensible. We can have a default true case to maintain the default balance as it is currently used.

As for the comment on spending a long time standardising. Honestly, I'd rather not rush a standard release and get trapped by it later. People are welcome to work in intermeditate formats and bring them in when CRTAF supports their needs. I reckon we can get a sensible structure quite quickly though.
Regarding table definitions, I very much see both points of view, and I will propose somewhat of a compromise I think can be made to work for all of us. I will need to think about implementation technicalities for this, but it can be made to work.
The idea is to provide an extension for the high-level file called something along the lines of CompressedSchema and would be used something like:
lines:
  type: CompressedSchema
  schema: [["transition", ["string", "string"]], ["f_value", "number"], ["wavelength_grid.n_lambda", "number"], ["wavelength_grid.delta_lambda.value", "number"]]
  defaults:
    type: Voigt
    wavelength_grid:
      type: Linear
      delta_lambda:
        unit: nm
  entries:
   - [[i_2, i_1], 0.4162, 201, 0.01]
   - [[i_3, i_1], 0.0791, 151, 0.01]
   - [[i_3, i_2], 0.6407, 201, 0.02]
   - [[i_4, i_2], 0.1193, 151, 0.02]

Following the extension, this definition would replace itself with a set of 4 different lines following the spec. As such, this kind of complex mainpulation would be handled only by libraries designed for interacting with the high-level representation. Consumers of the simplified format would be unaffected. There is also nothing stopping this being mixed and matched with definitions in the exiting format.
Additionally, Giulio and I discussed the potential for very large files when the simplified format is used with large atoms. In non-lte codes, this is unlikely to ever be an issue, but I can see how the bandwidth and parsing requirements could potentially be an issue for optically thin work. I see two primary paths there, either dumping the yaml to json (since by design we are avoiding the problematic parts of yaml with references etc) and storing it in an easily queriable SQLite database, or simply dumping the simplified structure to something like hdf5. I'm not personally convinced that the optional compression of hdf5 will do an amazing job of compressing this kind of thing given the number of different records, and it will likely be useful to bolt on existing compression over the top (e.g. xzip), but this would require an additional layer to handle tidily loading individual files without decompressing the entire blob.


Set dynamic datasource interval to default when collect rules are empty

Signed-off-by: Subbarao Meduri<EMAIL_ADDRESS>

/approve
/lgtm

/restart-required

/retest

/lgtm


Version: 1.56.0 (system setup)
Commit: cfa2e218100323074ac1948c885448fdf4de2a7f
Date: 2021-05-04T22:09:06.405Z
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19041

Thanks for the feedback. This is intentional as not every icon is aligned to the center due to pixelation, so some icons are off-center.

So there was no background for hovered buttons in the previous version.


fix TypeErrors in calls to connection close

When running under PHP7, following excpetion occurs:

PHP Fatal error:  Uncaught TypeError: Argument 1 passed to Wrench\Connection::close() must be of the type integer, object given, called in .\vendor\wrench\wrench\lib\ConnectionManager.php on line 22

This pull request replaces close calls with object $connection->close($e); to correct calls with int $connection->close(Protocol::CLOSE_UNEXPECTED);

Nice, thanks


clear() was updated in the atoms, please update them in MDEdgeDriver

Hi folks,
This pull request https://github.com/SeleniumHQ/selenium/pull/11504 updated how clear() works in the atoms, it could be a good idea to update the atoms in MSEdgeDriver.
Would that be possible?
Thank you,

Hi @bwalderman
I've create one over there as well. I will close this one then. Thanks!


Use network file with mask for switchEffect()

Is there any way to use file from url instead of using only assets in switchEffect method  ?
await _deepArController.switchEffect(
Config.deepArConfig.cameraMode, "assets/look2");

I am storing AR files in Firebase Storage as it suppose that there will be a lot of them, and later won't be necessary to rebuild app if I want to add new files cause app will pull them from firestore and storage
thats why i want to use url (similar to Image.asset() and Image.network() use files from different paths)
If not there could be ability to use path containing  (await getApplicationDocumentsDirectory()).path -  not only assets
so I can get file from url myself, write it to documents directory and use its path in switchEffect method

Oh ok understood.
That's a legit use case.
This plugin author is not very active for upgrading this plugin i guess.
So may be we should fork and make changes according to our need. And may be create a different plugin out of it and upgrade with time for the community.
I am also currently working with this plugin.


Remove extraneous closing brackets

Modal example had a few extra closing brackets that are not valid HTML.

Hi @jeffbaumes,
Thank you, nice find.
I changed the branch as this PR will be merged in dev first.
I also replicated your changes into ./docs/src/modal.html (see the contributing process)
Your contribution will be merged in the next release.

Preview here: https://picocss.github.io/pico/docs/modal.html


Support for AWS TransitGateway and TransitGatewayAttachment

What problem are you facing?
in my team we spin up clusters per default with internal load balancers + we have multiple clusters in different AWS accounts.
to make them available to the corp intranet + to VPN users etc. we are doing some transit gateway peering afterwards to make a cluster:

availability  to the internal network/routing
ensure visibility  to other parts of the infrastructure(CI/CID) in different AWS accounts
enable the new cluster to also reach other pieces of infra. like CI/CD, services in other clusters or RDS instances
also: we create a 2nd VPC in the same account which contains only RDS instances for better separation of concerns(well, that may not matter)

currently we need to run dedicated pipeline tasks after the cluster creation to apply terraform code which is doing the necessary TGW peering.
we are currently using SAP gardener as our cluster lifecycle management tool. gardener provides CRD's to CRUD the clusters.
argoCD is our tool to apply those manifests against a management(seed) cluster.
argoCD is also our tool of choice for applying additional landscape deployments like prometheus-operator, nginx etc.
now if we want to do the TGW peering we need to go one step back and involve some tooling(tekton pipelines) to apply the terraform code against the AWS account.
How could Crossplane help solve your problem?
would be super cool to also deploy those infrastructure changes/resources via argoCD and kubernetes manifests.
see: https://crossplane.slack.com/archives/C01718T2476/p1601571788009400
and: https://kubernetes.slack.com/archives/CD6U2V71N/p1601564676059800
i think you get the idea. :)
thanks in ahead for considering this feature request.

@HerrmannHinz Thank you for describing your request in detail! 0.13 will be released this week, so I believe we can discuss this feature for 0.14. Though if you'd like to, you can contribute by implementing them by following our guides. We'd be more than happy to help you guide along and merge the PR to upstream.

Provider Development Guide: https://crossplane.io/docs/master/contributing/provider_development_guide.html
Implementing a managed resource (GCP PubSub) live: https://www.youtube.com/watch?v=rvQ8N0u3rkE&t=7s

@muvaf wow nice, good news and thanks for the heads up.
will check out the docs and the tutorial. maybe i can manage it myself to implement it. but please do not wait for me. ;)

@HerrmannHinz please look at #831 tgw & tgw-vpc-attachment currently working in my PR - one open point with code-gen but in general it is working ;)


Switching database doesn't work.

Issue Type: Bug
I have two databases. They have the exact same tables and columns. When I switch between them in a "select top 1000" query it always returns the rows for the database that I right-clicked "select top 1000" on
Azure Data Studio version: azuredatastudio 1.25.1 (e7eacc32c0d20bd4da843320c3bfac231b308c98, 2020-12-11T01:59:24.271Z)
OS version: Windows_NT x64 10.0.18363

@mees- I wasn't able to repro this issue.  I used the query select * from sys.tables and used the database drop-down in the query editor to switch between databases.  The query returned the tables for the selected table.
Am I missing something else in the repro?  You may try using USE databasename in your SQL scripts as a workaround (this is basically what the drop-down does).

@kburtram I have also not been able to reproduce this bug since I first encountered it. When I first noticed it I was very sure that I was looking at the wrong data. As I said, I haven't had the issue since the first time.

Closing older issues without a recent repro on current builds.  Please let us know if you're still being impacted by this issue.  Thanks!


feat(behavior_path_planner): update pull out

Description

Add several pull out methods with an interface class.

shift pull out

https://user-images.githubusercontent.com/39142679/187872468-6d5057ee-e039-499b-afc7-fe0dc8052a6b.mp4
old

geometric pull out

this can be used in a smaller space than shift pull out

https://user-images.githubusercontent.com/39142679/181024707-3e7ca5ee-62de-4334-b9e9-ded313de1ea1.mp4

backed pull out start pose search -> backward driving -> geometric pull out (disabled by default)

this can be used in a much smaller space

https://user-images.githubusercontent.com/39142679/181025149-8fb9fb51-9b8f-45c4-af75-27572f4fba78.mp4
Related links

update geometric_parallel_parking and pull_over

https://github.com/autowarefoundation/autoware.universe/pull/1534

launcher

https://github.com/tier4/autoware_launch/pull/439

docs

https://github.com/autowarefoundation/autoware.universe/pull/1587

Tests performed

psim and real vehicle

shift pull out

https://user-images.githubusercontent.com/39142679/184056591-f2733cf7-630b-43a3-9261-95bd8651ebb1.MOV
https://user-images.githubusercontent.com/39142679/184056607-c216c7fe-fa95-42b6-99c2-a238aaa8807e.mp4

geometric pull out

https://user-images.githubusercontent.com/39142679/184056623-0b89ab97-3aaf-4740-88ad-cce9bbc862e7.MOV
https://user-images.githubusercontent.com/39142679/184056626-894db53e-ad65-40ef-bd30-f40651c8934c.mp4

backed pull out start pose search -> backward driving -> geometric pull out (disabled by default)

https://user-images.githubusercontent.com/39142679/183327472-6102a155-66e1-4130-a3c0-8f7ab0aa5b9c.MOV
Notes for reviewers

Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@yukkysaito @TakaHoribe
Could you please review this PR?:pray:

From the advice that it is not good on public roads to stop in the middle of the road for geometric_pull_out,
I have added an option to depart on shift_path as much as possible, even when driving back.
search_priority: "efficient_path"
https://user-images.githubusercontent.com/39142679/187919149-e97b9cfc-c646-46fd-a14e-300bd22954d6.mp4


HADOOP-17433. Skipping network I/O in S3A getFileStatus(/) breaks ITestAssumeRole.

ran ITestAssumeRole against s3 ireland in IDE and then from cli with/without s3guard

FYI @mukund-thakur @bgaborg

FYI @mukund-thakur @bgaborg

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 24s

trunk passed

+1 :green_heart:
compile
0m 45s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 30s

trunk passed

+1 :green_heart:
mvnsite
0m 44s

trunk passed

+1 :green_heart:
shadedclient
16m 38s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 33s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
1m  7s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  3s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 35s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
0m 35s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
checkstyle
0m 20s

the patch passed

+1 :green_heart:
mvnsite
0m 34s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 56s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 28s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
1m  7s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 17s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

78m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2600/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2600

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux a6994c95d252 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d21c1c65761

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2600/1/testReport/

Max. process+thread count
536 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2600/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 24s

trunk passed

+1 :green_heart:
compile
0m 45s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
checkstyle
0m 30s

trunk passed

+1 :green_heart:
mvnsite
0m 44s

trunk passed

+1 :green_heart:
shadedclient
16m 38s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 33s

trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+0 :ok:
spotbugs
1m  7s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  3s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 35s

the patch passed

+1 :green_heart:
compile
0m 35s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javac
0m 35s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
checkstyle
0m 20s

the patch passed

+1 :green_heart:
mvnsite
0m 34s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
14m 56s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 20s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04

+1 :green_heart:
javadoc
0m 28s

the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

+1 :green_heart:
findbugs
1m  7s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 17s

hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

78m 56s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2600/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2600

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux a6994c95d252 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d21c1c65761

Default Java
Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2600/1/testReport/

Max. process+thread count
536 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2600/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

LGTM +1

LGTM +1

thanks; merged

thanks; merged


break machine with 9.0.3

when trying to use a pick on a machine it crashes client
http://pastebin.com/N7Fm0cT7
basic cable not a prob but pretty much any machine that i have tried

Update to #277 :)


Documentation difference based on package version

Hi.
Would there be different documentation for 1.* and 2.* versions? Coz now you can search only by 'build' age
P.S. great package ;)

There's almost no difference between 1.x and 2.x. For 2.x I just removed code that was marked as deprecated and made some minor changes to support Laravel 7. So the docs should be fine for both versions.

oh, thanks

@lindyhopchris
Hi, how about ^2.0 stability? When is 2.0.0?
Thanks for the work!


Jerky horizontal movement of cards when a card is dismissed in gridview

When I am dismissing a card in single column Card-views, the other cards get sorted perfectly. But when I dismiss a card in multi-column view, the cards move abruptly (horizontally) ?
Example : If there are two columns of cards (having a left card and a right card), if I dismiss the left card, the right card abruptly takes the place of the left card (no animation at all). However, if I dismiss the right card, the card below the dismissed card moves smoothly (vertically upwards) ? Any fixes on horizontal animation?

The library was made with only a single column layout in mind. The animation would have to be fixed on the performDismiss method.
If you do that, please make a pull request. If not, I'll work on it in the future.
Thanks for reporting.

I have no idea how to fix this. Kindly, fix it yourself asap. Help would be appreciated.

I'll close this as it's out of the scope of this library. Updated the README making it clear that this is a simple solution for a single column list. There are other well-maintained libraries that do much more, such as https://github.com/h6ah4i/android-advancedrecyclerview. Anyway, thanks for the feedback.


Table selectable columns

Package
filament/filament
Package Version
v2.11
Laravel Version
v8.83.7
Livewire Version
v2.10.4
PHP Version
PHP 8
Bug description
the selectable column feature seems not to be working on relations:
Tables\Columns\TextColumn::make('type.name')
->label(__('Type'))
->sortable()
->toggleable(true, true)
->searchable(),
Others works fine but not this one:
Please see the video :
https://user-images.githubusercontent.com/604907/164388469-b86676dc-1ba1-4884-8ca7-554a8339abf5.mp4
Steps to reproduce
No response
Relevant log output
No response

I experience the same issue on Laravel v9.9.0 / LiveWire v2.10.5


BUG?: <silent> mappings don't work

I ported the following snippet of vimscript:
tnoremap <silent><ESC><ESC> <C-\><C-n><Cmd>close<CR>

To this snippet of lua:
tnoremap({
  '<silent><ESC><ESC>',
  function()
    vim.api.nvim_win_close(0, {})
  end
})

Which doesn't work, the following however does:
tnoremap({
  '<ESC><ESC>',
  function()
    vim.api.nvim_win_close(0, {})
  end
})

It seems therefore that silent doesn't work in mappings or that this is intentional but not yet documented given the (possibly, since it's a merge request in plugin form :)) WIP nature of the plugin.

If I read the code correctly, then something like this should do it.
tnoremap({
  '<ESC><ESC>',
  function()
    vim.api.nvim_win_close(0, {})
  end,
  silent = true
})

Yes, you should use silent as a paremeter, not as part of the map. Thanks @rudotriton :)


Update Angular 2 Auth Post to use access_token

@brunokrebs good call - after updating the library to latest I was able to make it work without having to write the custom factory. Thanks!
Post should be ready to merge now.


metrics no kubernetes_namespace label，but use namespace in grafana-dashboard.json

Pre-requisites

[X] I have double-checked my configuration
[X] I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
[X] I have searched existing issues and could not find a match for this bug
[ ] I'd like to contribute the fix myself (see contributing guide)

What happened/what did you expect to happen?
Argo Workflows metrics no kubernetes_namespace label, but the kubernetes_namespace is used in grafana-dashboard.json: https://github.com/argoproj/argo-workflows/blob/main/examples/grafana-dashboard.json#L159C20-L159C40
In this case, the namespace in the dashboard will cause confusion to users.
I don't know if it's because it hasn't been developed yet or if the kubernetes_namespace was deleted on purpose.
If it hasn't been developed yet, we can develop it. If the kubernetes_namespace was deleted on purpose, we should be update grafana-dashboard.json.
metrics:

argo_workflows_count (https://github.com/argoproj/argo-workflows/blob/main/workflow/metrics/util.go#L170)
argo_workflows_operation_duration_seconds_bucket
argo_workflows_queue_adds_count
argo_workflows_queue_latency_sum
argo_workflows_queue_latency_count
log_messages

I have created 2 workflow CR，one is in default namespace, one is in another namespace, but count is 2 if I select default namespace，some confusion.

Version
latest
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
no need

Logs from the workflow controller
no need

Logs from in your workflow's wait container
no need

The grafana json there hasn't been touched for ages and is very stale.
The most up to date dashboard is this: https://grafana.com/grafana/dashboards/20348-argo-workflows-metrics/ which is linked elsewhere in the argo docs.
However, your issue is actually that the namespace in the query refers to the namespace of the Workflow controller, not the running workflow. The updated dashboard tries to help clarify this by making the dropdown more explicit:

https://github.com/argoproj/argo-workflows/issues/12589 adds the namespace to some metrics, and would allow some of what you're after. Please comment on that issue regarding whether that fits your needs.

@tico24 Thanks.  The WF Controller Namespace can help to monitor how many workflows each workflow controller processes, it is more meaningful.

Closing as it seems like all questions were answered here and the link to the non-example Grafana dashboard was given as well as links to other metrics issues.


pycpd package citation

Hello,
I am using pycpd in my work and want to acknowledge pycpd package by citing it.
Apart from the original CPD paper by Myronenko and Song, is there any publication associated with the implementation of CPD (pycpd package)?
Thank you,
Bramsh

@gattia if you are willing to do the leg work and be the first author on this I am game. I can review it as a second author.
I have a partially torn MCL and ACL injury and am barely functional right now.

@siavashk Sorry to hear about the knee! I'm glad that it's only partially torn - hopefully, the recovery is quick.
As for the paper, that sounds great. I don't think the JOSS papers are very long. I'll take a peak at the requirements and things and I'll put something together in the coming weeks.

Sounds good!

@siavashk I have been preparing the JOSS submission. The list of requirements for the submission can be found here: https://joss.readthedocs.io/en/latest/review_checklist.html
The only thing that is missing at the moment is more explicit documentation. I think just building automated docs from the docstrings would be sufficient.
I've already made a pull request for adding a code of conduct (another requirement).
If you can take a peak at the compiled PDF paper that I've drafted (here) that would be great. The paper and bibliography files can be updated as you see fit. Please do feel free to edit as much as is necessary.
Im not sure what I did... but I somehow ended up making the JOSS changes on a weird branch that is behind the master branch. I don't think this is an issue because technically we are allowed to just delete this branch after the review - if we wish.

Thanks @gattia. I will review it. I have covid on top of my injury so it will be a couple of days before I can review it.

@siavashk I hope the recovery has gone smoothly! Just checking in here to see if you've had a chance to review this.

@gattia I merged the pull request. I thought that was it! Sorry, I will review it today.
I am doing well. I had two months of physiotherapy but now I am back on my feet again. Thank you for asking. :)

@gattia Looks well. Just one minor comment:
"However, no open-source python version previously existed." should be "However, to the best of our knowledge, no open-source ..."

@BramshQamar its been a while since you posted! but we now have a paper that you can cite - while this project might be passed, please keep it in mind for future work. (checkout the readme for the DOI/Link, or you can visit here https://joss.theoj.org/papers/10.21105/joss.04681)
Thanks @siavashk for all the wor on the repository at large, and getting the paper out! 🎉🥳🍾


chore(deps): update renovate/renovate docker tag to v37.262.1

This PR contains the following updates:

Package
Update
Change

renovate/renovate (source)
minor
37.238.0 -> 37.262.1

Release Notes

renovatebot/renovate (renovate/renovate)
v37.262.1
Compare Source
Bug Fixes

deps: update ghcr.io/containerbase/sidecar docker tag to v10.3.4 (#28048) (143bdf4)

v37.261.0
Compare Source
Features

bitbucket: Enable HTTP cache for issues (#28030) (4c8d3d4)

v37.260.0
Compare Source
Features

bitbucket: Enable HTTP cache for PR list and json fetch (#28024) (fcffdc9)

v37.259.0
Compare Source
Features

config: Add @babel/eslint-parser to ESLint packages Presets (#28014) (0e16efa)
platform/gitea: autodiscover repos by namespace (#26821) (0dfea67)

Miscellaneous Chores

deps: update actions/cache action to v4.0.2 (#28026) (5d4f190)

Continuous Integration

Revert "codecov-action" back to v3 (#28029) (740d8e9)

v37.258.0
Compare Source
Features

http: Switch to pluggable HTTP cache implementation (#27966) (8596967)

v37.257.0
Compare Source
Features

http: Add pluggable HTTP cache implementation (#27998) (4f70ff1)

Bug Fixes

manager/pipenv: better artifacts handling of deprecated python (#28023) (9902cf4)
manager/poetry: limit fallback poetry constraint (#28022) (6ed22b9)

Code Refactoring

Compact HTTP cache stats (#28011) (5e02f6e)

v37.256.2
Compare Source
Miscellaneous Chores

deps: update dependency @types/lodash to v4.17.0 (#28020) (b900884)
deps: update dependency @types/semver to v7.5.8 (#28015) (d314dda)

Build System

deps: update opentelemetry-js monorepo (#27769) (bfff3de)

v37.256.1
Compare Source
Miscellaneous Chores

deps: update linters to v7.3.1 (#28013) (7d0d593)

Build System

deps: update dependency semver to v7.6.0 (#27255) (b881173)

v37.256.0
Compare Source
Features

eslint-plugin-node to eslint-plugin-n (#26907) (af31adb)

Bug Fixes

bitbucket: Use schema for repo result validation (#27855) (b0ea915)
yarn: add COREPACK_ENABLE_UNSAFE_CUSTOM_URLS to env (#28009) (12377e4)
yarn: improve yarn proxy configuration (#27984) (814d2ec)

Documentation

document support for fine-grained pat (#27346) (f4a96f8)

Miscellaneous Chores

deps: update linters to v7.3.0 (#28005) (a442f24)

Tests

Don't use classes outside of opentelemetry public API (#28012) (d5a8184)

v37.255.0
Compare Source
Features

platform: re-attempt platform automerge on github and gitlab  (#26567) (ebf0c7b)

Documentation

nuget: add hint for protocol version in NuGet.config (#27933) (de9608b)

v37.254.0
Compare Source
Features

config: expose topLevelOrg, templateOrg to templates (#27997) (e500e50)

Miscellaneous Chores

deps: update github/codeql-action action to v3.24.8 (#28002) (ae1f9b8)
deps: update linters to v7.2.0 (#28004) (e2aa68f)

Code Refactoring

http: Remove unused HTTP etag caching implementation (#28000) (c258041)

v37.253.1
Compare Source
Bug Fixes

config/replacements: require semver for renovate slim image tag removal (#27991) (bcfaca4)

v37.253.0
Compare Source
Features

terragrunt: add support for gitlab-tags datasource (#27903) (5c14579)

v37.252.1
Compare Source
Bug Fixes

deps: update ghcr.io/containerbase/sidecar docker tag to v10.3.3 (#27987) (b37086f)

Documentation

update references to renovate/renovate to v37.252.0 (#27979) (a4a92d2)

Miscellaneous Chores

deps: lock file maintenance (#27982) (737375c)
deps: update containerbase/internal-tools action to v3.0.67 (#27978) (0a97391)
deps: update containerbase/internal-tools action to v3.0.68 (#27981) (2e1d8f2)
fix nuget typo (#27976) (5b8fb1f)
use node 20 for .nvmrc (#27970) (a5167f5)

Continuous Integration

Shallow clone "codecov.yml" for coverage uploads (#27973) (b29b012)
Upgrade "codecov-action" to v4.1.0 (#27974) (ab27756)

v37.252.0
Compare Source
Features

versioning: Add Unity3D (#27307) (28e0123)

Bug Fixes

gitlab: Don't delete report_approver and  code_owner approval rules (#27963) (92ab91b)

v37.251.0
Compare Source
Features

instrumentation/reporting: add report option (#26087) (481aa21)

v37.250.1
Compare Source
Bug Fixes

deps: update ghcr.io/containerbase/sidecar docker tag to v10.3.1 (#27968) (8dc9705)

v37.250.0
Compare Source
Features

Http cache stats (#27956) (5d7372f)

Code Refactoring

manager/helmfile: use schema for yaml parsing (#27539) (d0878d9)

Tests

manager: manager need to exports updateDependency or extractPackageFile when exporting extractAllPackageFiles (#27954) (5075318)

v37.249.3
Compare Source
Bug Fixes

datasource: remove unnecessary PyPI changelog URL overrides (#27725) (42ee263)

v37.249.2
Compare Source
Bug Fixes

workers/repository: Pass correct lock files when updating a dependency in multiple input files (#27898) (a5193da)

v37.249.1
Compare Source
Bug Fixes

sbt: export extractPackageFile() for confirmIfDepUpdated() (#27953) (6cb7c81)

Code Refactoring

Extract "HttpStats" utility class (#27944) (fd8684b)

v37.249.0
Compare Source
Features

config: make skipInstalls user-configurable (#27949) (3e97024)

v37.248.0
Compare Source
Features

expose branch depTypes for templating (#27948) (55205fb)

v37.247.0
Compare Source
Features

allow packageScope in template compilation and add packageScope in maven datasource (#27925) (397dda5)

Bug Fixes

azure: Support exact branch merge policies. (#27918) (1554cc6)

Build System

deps: update dependency azure-devops-node-api to v12.5.0 (#27938) (5f4af40)

v37.246.2
Compare Source
Bug Fixes

datasource/npm: mark all releases deprecated if latest deprecated (#27875) (c1517aa)

Documentation

gitlab: Add coloring info (#27907) (b4dc29b)

Code Refactoring

Package cache stats utility (#27936) (998705d)

v37.246.1
Compare Source
Bug Fixes

update license (#27937) (4d53870)

v37.246.0
Compare Source
Features

platform/bitbucket: autodiscoverProjects (#27845) (11b3c59)

Code Refactoring

Create utility for stats collection and reporting (#27919) (9c06813)

v37.245.0
Compare Source
Features

presets/replacements: rollup terser plugin became scoped (#27929) (a4e90f9)

v37.244.1
Compare Source
Bug Fixes

templates: compile groupSlug (#27927) (8fc50ca)

Miscellaneous Chores

deps: update dependency @types/node to v18.19.22 (#27920) (caec49d)
deps: update dependency @types/node to v18.19.24 (#27922) (744e949)

v37.244.0
Compare Source
Features

github-actions: add support for version tag prefixes (#27882) (27eb84f)

v37.243.0
Compare Source
Features

kustomize: support OCI helm charts (#27163) (91bf759)

v37.242.0
Compare Source
Features

kustomize: support registry aliases (#27911) (b92afa4)

v37.241.1
Compare Source
Bug Fixes

cache: Revert "refactor: Initialize caches before repository init" (#27908) (eb5f0a7)

Documentation

best practices: fix styling (#27905) (fc14189)
improve auto actions (a9d30b0)

Miscellaneous Chores

deps: update devcontainers/ci action to v0.3.1900000348 (#27904) (45787c8)
log warning if Repository cache is invalid (#27910) (bc4d090)

Build System

deps: update dependency @opentelemetry/instrumentation-bunyan to v0.36.0 (#27909) (9062fa2)

v37.241.0
Compare Source
Features

manager/gradle: add support for new header used by gradle-consistent-versions plugin (#27895) (291defc)

Documentation

reduce experimental flags (a765822)

Miscellaneous Chores

deps: update github/codeql-action action to v3.24.7 (#27893) (4b91ad4)

Code Refactoring

config: use enum for config type (#27891) (49971b9)
Initialize caches before repository init (#27897) (06d751e)

v37.240.1
Compare Source
Bug Fixes

deps: update ghcr.io/containerbase/sidecar docker tag to v10.3.0 (#27888) (5f7e61d)

Miscellaneous Chores

deps: update dependency @swc/core to v1.4.6 (#27886) (421eec3)

v37.240.0
Compare Source
Features

replacements: add mem to memoize rename (#27847) (af5b08f)

Miscellaneous Chores

deps: update dependency @swc/core to v1.4.4 (#27883) (6aec35e)
deps: update peter-evans/create-pull-request action to v6.0.2 (#27884) (a2ed4f0)

v37.239.0
Compare Source
Features

github-actions: support ratchet comments (#27846) (3b4b7f1)

Miscellaneous Chores

deps: update actions/checkout action to v4.1.2 (#27876) (7001356)

v37.238.2
Compare Source
Bug Fixes

merge-confidence: escape all slashes within a package name (#27873) (2b03c2c)
sbt: url resolution failures for sbt (#27856) (d329c8a)

Miscellaneous Chores

renovate: drop unused package rule (#27868) (e74bbd4)

v37.238.1
Compare Source
Bug Fixes

config: update registryAliases schema and managers (#27866) (30281b7)

Miscellaneous Chores

sort config types (480b11f)

Code Refactoring

config file parsing (#27863) (cda68de)

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 5.3.8 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[feature request] Set color and font size of every day title

I would like to change the color and the font size of every day title (today, 14.Mai / monday, 15. Mai / etc.)

Do you mean e.g. 7 different settings for each day of week?

In v.3.0.5 (currently in Beta, see #320) different text shadings implemented for past, today and future. I.e. for Today you may change now not only background color, but text color also.


"validationError": "Error in $.destinations: expected NonEmpty a, encountered Object"

Hi.
Is that "a" supposed to be "array?" and also what does this mean? Ive done is_object on everything and its all false so no objects in sight...
This happens when trying to send a transaction to /api/v1/transactions and  /api/v1/transactions/fees

Hi,
NonEmpty a is the same as NonEmpty x. x and a are variables like for example in sqrt(x) or sin(a) or foo=a+x
NonEmpty a means non empty list of some element of type a without saying at this point what a is.
I guess this message says there was an error when validating data that has been received.
It is not directly related to running is_object on the client side.

I dont understand why a request to the transactions end point to make a transaction (post) is any different than on to say create a wallet (post) or create an account (post) or address (also post). They all require similar input, a mix of arrays and strings. So I really dont undertstand why there is suddenly a error. seriously the only difference is that it wants 2 arrays, source and destination and create wallet only wants one. i just dont get it. i would really appreaciate some actual help instead of snarky comments or restating of the documentation, just come on man, i need help. this has been a problem for like a week.

Hello,  I'm not a PHP expert but i think your destinations is only one address/amount pairs while it should be an array of address/amount pairs..A transaction can pay to a list of receivers.

Hello, I'm not a PHP expert but i think your destinations is only one address/amount pairs while it should be an array of address/amount pairs..A transaction can pay to a list of receivers.

I think i understand what your saying, the documentation does only refer to it as sending to multiple people at once and never just a 1-to-1 transaction its always 1-to-many (ie, an array of destinations).
So I thought it would be ok to send it to one person just using a single element array (a sender and the amount), but clearly that didnt work.
So how do you send to a single person?
Should I just include a second or third blank or empty transaction to make it a group thing?
All I want for Christmas is better API documentation... hahah

My approach for doing this in PHP would be to download the curl examples from the documentation and print the output  of json_encode($post_fields) to stdout. Both must have exactly the same structure.
If there are nested blocks of {...{...}..} in the example the request must have exactly the same structure.


Add HumanTool class for agent-human interaction

This pull request introduces a new HumanTool class that extends the base Tool class. The purpose of this class is to allow agents to seek guidance from a human when they are stuck or unsure of what to do next.
Key changes include:

A new HumanTool class has been added to represent the tool for agent-human interaction.

This enhancement will enable the agent to better handle situations where its knowledge or capabilities are insufficient by allowing it to seek assistance from a human.

Hey I don't quite understand this one - it just echoes back what the agent calls the tool with?

@jacoblee93 It was ported from the python version

Seems like there's some other components in the Python version to make it functional: https://github.com/hwchase17/langchain/blob/master/langchain/tools/human/tool.py
Could you add them and add an integration test?


All hex address values should be wrapped as HexAddress

Due to https://github.com/go-yaml/yaml/issues/847, we have a wrapper type for hex addresses that will explicitly quote them as strings: https://github.com/hyperledger/firefly-cli/blob/main/pkg/types/hex_address.go
This is used sparingly right now, but should be used for all hex addresses output by the CLI.

Hi,
Can I start working on it?

is this issue still open , i can look into it


loosing sync

it keeps switching beetween two blockchains, one with height 29 and the other 259539 so always loosing sync unable to farm

It's because #2.


problems with running $go run . on Ubuntu 18.04

I am trying to run
$ go run main.go because $ go run . does not work
Anyway I am getting compilation error from Golang:
# command-line-arguments
./main.go:124:21: undefined: FrontendPath

This is coming from that line in main.go:
//Conditional compilatiion for dev and prod
	path, exe, args := FrontendPath()

Any suggestions why ?

That is why you should use

go run .

So that go takes all .go files in that directory in account.
What is the problem with

go run .
?

I go the message:
$ go run .
go run: no go files listed

There may be a problem with your go runtime.
What go version are you on?

OK. I got the pink window :):
$go get ./...
$go build .
$./gotron

my go version
go version go1.10.4 linux/amd64