LayerNorm casts input to float32 regardless of dtype

    x = jnp.asarray(x, jnp.float32)
Is this intentional? The LayerNorm module casts the input to float32 but casts other parameters to dtype, then multiplies them together. Naively it seems to me that this would be less efficient than casting the input to dtype.

Empirically we find that normalization layers (in particular computing moments) is somewhat sensitive to numerical precision issues. So we use float32 precision instead of float16/bfloat16 in half precision modules to avoid instability issues. Note that computing moments is not a big part of compute & memory compared to linear/conv modules so impact on performance is small.

Thanks for that explanation!


A particular search term returns a result count, but the wrappers are empty

I am using Chewy 7.2.7 with ES 7.17.8, Ruby 2.7.5 and Rails 5.2.x.  I have recently upgraded from Chewy 6 and ES 6.x  Recreated the indexes from scratch, and search is generally working as expected.
However, a particular single-word search term with nothing special about it as far as I can tell does not work as expected: the total results reported are 18, but .each yields [], as does .wrappers.  On the other hand, .first does provide a correct result object, and .first(5) provides five correct objects.
I have reviewed the changelog to see if there was something I missed (I did rename the Chewy::Type classes to be just the index etc.), but couldn't find anything that could explain this.
Again, on other search terms, iteration with .each does work, and .wrappers are non-empty.
Is there any explanation that comes to mind for this?  Many thanks in advance.

I'm finding more and more search terms where this is the case. (Despite recreating the indexes again.)
What might be the reason a ModelIndex class doesn't populate the .wrappers or work with .each some of the time? (In some search terms, the first page (25 results) is displayed correctly, but any subsequent pages, though they exist according to the total, have no .wrappers or .each, but are correct and accessible via .first(n).

I have upgraded my app to Rails 6.1 and Ruby 3.2.1, but the behavior is unchanged.
Would it be possible for @pyromaniac or one of the other maintainers to offer thoughts on what might be causing this behavior, where results are correct, .total_pages is correct, but .wrappers is [] on page 2 and onwards with Kaminari?

Further finding:
when a search has, say, 285 result pages (at 25 results per page), some pages load fine, including 1, 2, and 285 (the last one), and others with empty .wrappers as above (pages 281, 284). This behavior is consistent for this particular search.
(my index is fresh and up to date, verified with rake chewy:reset)

Unfortunately, the persistence of this issue is forcing me to ditch Chewy in favor of plain Elasticsearch. :(

In a last-ditch effort, I traced into Chewy and into elastic-transport, and have found the problem:
"type"=>"illegal_argument_exception", "reason"=>"The length [1134481] of field [fulltext] in doc[7882]/index[manifestations_1678539023000] exceeds the [index.highlight.max_analyzed_offset] limit [1000000]. To avoid this error, set the query parameter [max_analyzed_offset] to a value less than index setting [1000000] and this will tolerate long field values by truncating them."}

This Elastic error was indeed introduced in 7.x, so explains this happening after my upgrade.  It being a function of document size explains the apparent randomness of its occurrence, but consistently for particular search terms.
It seems to me that this error is somehow ignored or missed by Chewy, which just returns those pages without results. So while I will solve my issue by changing the setting, I do believe there is a Chewy issue here as well.
Thoughts?

(for anyone who's run into this and is looking for a quick fix, adding the max_analyzed_offset parameter to the highlight method solves the issue.)
index.highlight(max_analyzed_offset: 999000, fields: {fulltext: {}})


Install required font on Linux CI run

LGTM

LGTM

Now Linux builds are green again.

LGTM

[ERR] InstallFonts: /usr/bin/cp: cannot create regular file '/usr/local/share/fonts/NotoColorEmoji.ttf': Permission denied
[ERR] InstallFonts: /usr/bin/chmod: cannot access '/usr/local/share/fonts/NotoColorEmoji.ttf': No such file or directory
[ERR] Restore: WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

Error received.
Job: https://github.com/nissl-lab/npoi/actions/runs/5414928093/jobs/9844367929?pr=1110

Also this Windows job failed: https://github.com/nissl-lab/npoi/actions/runs/5414928093/jobs/9844367805?pr=1110

Generally you want to look at the summary page and what tests failed: https://github.com/nissl-lab/npoi/actions/runs/5414928093/attempts/2?pr=1110 . Tests fail when code changes in a way that tests haven't predicted it.


add repo-url arg

these changes enable terrascan to accept the url of repository being scanned and reflects the url in the scan summary.

@cesar-rodriguez , should we also capture branch info to uniquely identify the repository branch?


chore: run the project through prettier

And this is how Tomas became the single biggest contributor :))
Lets get it in. I don't want my small changes to look intimidating because of the formatting :))


merge conflict: Error in console when opening compare

Testing #27549

create a file as described in https://github.com/Microsoft/vscode/issues/27288#issuecomment-304138928
open the dev tools
click on 'Compare Changes'

Console says:
[Extension Host] An error occured while running command merge-conflict.compare TextEditor disposed

@jrieken Like in #27584 this is an empty edit that was not used by the editor command. In this case the command opens another editor and that appears to dispose the current editor before the empty edit is applied. Should the empty edit just be ignored in this case?

(Thanks @pprice for the analysis.)

Verifying this got different problem on the same steps. This what happens after 'Compare Changes' are triggered:

@chrmarti is it because I simulated merge conflict as in https://github.com/Microsoft/vscode/issues/27288#issuecomment-304138928?

Can reproduce with an untitled file. Also in 1.13. I'll open a new issue for that.


New version: Microsoft.PowerShell version <IP_ADDRESS>

Duplicate of: https://github.com/microsoft/winget-pkgs/pull/95159
Just trying to see if this one will work against internal pipeline issues the other was running into.

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?

[x] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Runs into the same internal validation error


Can't read ontologies into Protege

What are the steps to import these ontologies into Protege? I've been struggling with XML catalog and null pointer exceptions.

Hi @jlloganiii ,
We are working on making these network accessible so a user can retrieve the ontology files by pointing at the ontology's IRI.
For now, the way I've found Protege will work is to:

git-clone this repository.
Open uco-master/uco.ttl with Protege.
Protege will complain about some ontology IRIs not being accessible, and ask you to resolve them yourself with a local file reference.  This will be a couple clicks per .ttl file, but will populate the file uco-master/catalog-v001.xml.  Keep that file around in your checkout - Protege uses it to remember the IRI--file associations.  You won't need to do these clicks again as long as that file's present.

It does not seem like that file can be version-controlled for the general convenience of Protege users, because the file paths it logs are absolute paths, including user shell name.  To be even feasible to consider tracking, there would need to be some mechanism to define a variable in the XML to enable pathing relative to the catalog file's location; and even then, UCO's ontology committee would need to consider supporting the catalog as an artifact to the benefit of (to my knowledge) a sole tool.  I don't speak for the committee, but that is the hill up which a proposal would need to climb.
We hope for this issue to be moot soon, for Protege and for other tools, once the ontologies are network accessible.
Meanwhile, if you are interested in documentation more pleasing to the eye than raw Turtle data, you can find a render of UCO 0.6.0 here:
https://unifiedcyberontology.org/releases/0.6.0/docs/index.html

We have a potential resolution for this matter (tracking on UCO's Jira: OC-180).  Does this file happen to work for you?
https://github.com/DrSnowbird/UCO/blob/master/catalog-v001.xml

Hello @jlloganiii ,
UCO now deploys web-retrieval ontology resources that should load with Protégé.
Issue 449 has been filed to make offline Protégé interaction an option.

I just stumbled across this Issue and saw it's still open.  With the resolution of #449 , I believe this is resolved.  Please do re-open if you have any outstanding issues.


Non-boundary offset should be consistent relative to line direction

@jschleuss reported this issue, which is a regression from 0.11.x to 0.12.0.
I suspect this may be a casualty of the dual-sided boundary labels (https://github.com/tangrams/tangram/pull/516), where the offset direction sometimes has to flip internally. However, that should only affect labels explicitly marked as left/right.
For "normal" line labels (those not explicitly marked as left/right), a positive offset should always push the label down/below relative to the line, and a negative offset should always push it up/on top.
Here are Jon's examples:
0.12.1 - incorrect - mixed offsets above/below:

0.11.x - correct all offsets above:

Here's a test I created in Play as well to verify:
v0.12.1: https://mapzen.com/tangram/play/?scene=https%3A%2F%2Fmapzen.com%2Fapi%2Fscenes%2F4%2F482%2Fresources%2Fbasic.yaml#16.72917/37.84889/-122.29377
v0.11.x: https://mapzen.com/tangram/play/?lib=https://mapzen.com/tangram/0.11/tangram.min.js&scene=https%3A%2F%2Fmapzen.com%2Fapi%2Fscenes%2F4%2F482%2Fresources%2Fbasic.yaml#16.72917/37.84889/-122.29377

Ongoing work here for a fix: https://github.com/tangrams/tangram/tree/label-offset

Fixed in #545, pending release in v0.12.2

Release in v0.12.2


Does Anko DSL Preview Plugin supports IntelliJ 2016.3?

Hello, I am using IDEA 2016.3 Ver,
It throws Incompatible error when I try to install dsl preview plugin.
When it supports 2016.3 version??

I tried before, can't use

I just recently discovered Anko and was very excited about it, until I found out that preview plugin doesn't work with IDEA 2016.3. Been using that version from day one and definitely not about to go to older one.
It's sad to see that plugin is still not supported for IDEA released over a month ago (November 22), especially considering that Anko is made by the same company as IDE itself...

Duplicate of #202

See also #314.


Article needs to be updated

The solution explained here is different than what comes with the Bot Framework template and the details mentioned here- https://github.com/Microsoft/BotBuilder-Samples/issues/1080. The new Bot Framework (and its dependent) libraries and the solutions explained over the docs are not in sync for a while. I have experienced several issues recently.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c6606cce-8a4e-587b-ded2-bd775a4cd7c7
Version Independent ID: 6f637bca-8cc0-a526-4cbd-9c5f9f94ca2b
Content: Create advanced conversation flow using branches and loops - Bot Service
Content Source: articles/v4sdk/bot-builder-dialog-manage-complex-conversation-flow.md
Service: bot-service
Product: bot-framework
GitHub Login: @JonathanFingold
Microsoft Alias: v-jofing

@Souvik04 interesting. So which way is the correct one? The docs are outdated but the examples aren't?

Many of the topics assume you are starting from the VSIX template. However, some explicitly updated how the accessors were registered in Startup.cs. All the topic code worked at the time of writing, and we're trying to keep up with the dev team as it makes changes to the SDK, tools, and templates.

PS. The recommendation for designing .NET bots is changing ASP.NET Core MVC. This will have an impact on the best practice for setting up state for your bots. Once 4.3 is released, we'll work on updating the docs. The dev team will be working on updating the samples, so there will be a little bit of churn until bot are up to date.


Large File not encoded

My previous issue regarding to mkv extensions is solved. Thank you.
But now i have another issue. unfortunately encode stop. following error
will display.
An uncaught Exception was encountered
Type: FFMpeg\Exception\RuntimeException
Message: Encoding failed
Filename:
/home/mamimovies/public_html/mami_movies/vendor/php-ffmpeg/php-ffmpeg/src/FFMpeg/Media/AbstractVideo.php
Line Number: 106
Backtrace:
File:
/home/mamimovies/public_html/mami_movies/vendor/aminyazdanpanah/php-ffmpeg-video-streaming/src/Media.php
Line: 82
Function: call_user_func_array
File:
/home/mamimovies/public_html/mami_movies/vendor/aminyazdanpanah/php-ffmpeg-video-streaming/src/Export.php
Line: 59
Function: __call
File:
/home/mamimovies/public_html/mami_movies/application/controllers/Convert.php
Line: 50
Function: save
File: /home/mamimovies/public_html/mami_movies/index.php
Line: 292
Function: require_once
I have large file for i.g more then 1GB
My current code is following.
$filename= 'kasoor.mp4';
$v11=FCPATH.'assets/images/VCMobile/kasoor/'.$filename;
$foldername = pathinfo($filename, PATHINFO_FILENAME);
$newfile = FCPATH .'assets/images/VCMobile/'.$foldername.'/Leikhamton.m3u8';
$config = [
       'ffmpeg.binaries'  => '/usr/bin/ffmpeg',
       'ffprobe.binaries' => '/usr/bin/ffprobe',
       'timeout'          => 0, // The timeout for the underlying process
       'ffmpeg.threads'   => 12,   // The number of threads that FFMpeg should use
  ];
  $ffmpeg = Streaming\FFMpeg::create($config);
  $video = $ffmpeg->open($v11);
  $rep_2 = (new Representation())->setKiloBitrate(1024)->setResize(640 , 360);
  $video->HLS()
           ->X264()
           ->setHlsTime(10)
           ->addRepresentation($rep_2)
           ->setHlsAllowCache(false)
           ->save();
 echo "success";
 exit;

I did't find any solution pls help me.
Thank You.

Try to change the following code in /home/mamimovies/public_html/mami_movies/vendor/php-ffmpeg/php-ffmpeg/src/FFMpeg/Media/AbstractVideo.php  on line 106:
if (null !== $failure) {
    throw new RuntimeException('Encoding failed', $failure->getCode(), $failure);
}

To:
if (null !== $failure) {
    throw new RuntimeException($failure->getMessage(), $failure->getCode(), $failure);
}

After that, run the code again to see the command that executes in your server/computer.
You will get an error like this:
Fatal error: Uncaught Alchemy\BinaryDriver\Exception\ExecutionFailureException: ffmpeg failed to execute command: /usr/bin/ffmpeg -y -i /path/to/file/kasoor.mp4 ...

The command is:
/usr/bin/ffmpeg -y -i /path/to/file/kasoor.mp4 ...

Try to execute the command in your terminal(or command prompt) to see the FFmpeg error.
In the end, reverse the code you have changed.
I cannot help you with such little provided information. Sorry!

Thank you form informs its help.


Test refactoring

Make sure that:

[X ] You have read the contribution guidelines.
[X ] You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
[X ] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
[X ] You submit test cases (unit or integration tests) that back your changes.

Problem:
The Exception Handling test smell occurs when the test outcome is manually determined through pass or fail method calls, dependent on the production method throwing an exception generally inside a try/catch block. This refactoring proposal aims to make the exception catching a responsibility of the test framework which is already provided by its API. Also, without using try/catch blocks, tests can be more straightforward and possibly more comprehensible and maintainable.
Solution:
We propose using JUnit's exception handling to automatically pass/fail the test instead of writing custom exception handling code. In this particular case, we added the possibly throwable object to test method signature and removed the redundant fail method call and message.
Result:
Before:
try {             HostAndPort.of("gmail.com", -1);             fail("Expected IllegalArgumentException");         } catch (IllegalArgumentException expected) {         }
After:
assertThrows(IllegalArgumentException.class, () -> {             HostAndPort.of("gmail.com", -1);         });

Closing this pull request without merge. We left some comments to address and there was no follow-up.


        Parameters
        ----------
        platform : str
            Platform type which should be defined in MicroTVMTemplateProject.

        Returns
        -------
        str :
            Path to template project directory for platform.
        """
        if platform not in MicroTVMTemplateProject.list():
            raise ValueError(f"platform {platform} is not supported.")

        microtvm_template_projects = None
        for path in libinfo.find_lib_path():
            template_path = os.path.join(os.path.dirname(path), "microtvm_template_projects")
            if os.path.isdir(template_path):
                microtvm_template_projects = template_path
                break
        else:
>           raise MicroTVMTemplateProjectNotFoundError()
E           tvm.micro.build.MicroTVMTemplateProjectNotFoundError
python/tvm/micro/build.py:106: MicroTVMTemplateProjectNotFoundError

I'm wondering if @areusch @mehrdadh can you help troubleshoot this? It is not present in the current main, so I assume it was fixed, but I couldn't track it down when searching for closed/merged PRs. Any idea?
For visibility I'm tagging the Release Schedule #13586

i can't reproduce this locally, but i notice that the release branch CI is merging main back in so I wonder if there is a collision there? could you say more about how you're invoking this? we did recently change the way the CRT is built in main.
From https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-cpu/detail/v0.11.0/2/pipeline:

It seems to be merging origin/main, specifically this commit. And I think that brings in https://github.com/apache/tvm/pull/13812/files, which requires jenkinsfile changes that aren't present in the v0.11.0 branch.
So I think this is likely a problem with our release branch CI, not an actual bug. I think we should rerun the release branch tests without merging, and then declare victory. I'm trialling a fix to the Jenkinsfile here that hopefully will allow us to bypass the merge on non-main branches.

OK, so I'll validate that the tests failing here are not failing with your trial run. If they pass, then I'll push the Release Candidate and we can, for now, declare that as an issue with CI.

Closed via https://github.com/apache/tvm/pull/14121


ngtcp2: 0.6.0 -> 0.7.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/ngtcp2/versions.
meta.description for ngtcp2 is: "ngtcp2 project is an effort to implement QUIC protocol which is now being discussed in IETF QUICWG for its standardization."
meta.homepage for ngtcp2 is: "https://github.com/ngtcp2/ngtcp2"
meta.changelog for ngtcp2 is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.7.0 with grep in /nix/store/7zhb6sdapfj9frqbdfyfgqk7661fhn8d-ngtcp2-0.7.0
found 0.7.0 in filename of file in /nix/store/7zhb6sdapfj9frqbdfyfgqk7661fhn8d-ngtcp2-0.7.0

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
curlHTTP3
ngtcp2

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/7zhb6sdapfj9frqbdfyfgqk7661fhn8d-ngtcp2-0.7.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A ngtcp2 https://github.com/r-ryantm/nixpkgs/archive/1fb76f3e262906b9f444cd9e84d7b1264c7acf83.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/7zhb6sdapfj9frqbdfyfgqk7661fhn8d-ngtcp2-0.7.0
ls -la /nix/store/7zhb6sdapfj9frqbdfyfgqk7661fhn8d-ngtcp2-0.7.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

curlHTTP3
ngtcp2

Maintainer pings
cc @Izorkin for testing.

@ofborg build curlHTTP3


After installing howdy, computer doesn't lock on lid closed

Hello, I was able to install and use howdy successfully on my laptop. However, the computer doesn't lock after the lid is closed!
I know this is because of howdy, because I uninstalled it, and after a restart, the lock-on-lid-closed worked fine. I reinstalled it, and after the reboot, it doesn't work! I haven't even set howdy up in any PAM files.
I currently have it uninstalled, because I want my computer to lock when I close the lid, but I am willing to test fixes.

I've searched for similar issues already, and my issue has not been reported yet.
Linux distribution (if applicable): I am running arch linux, with the kde-plamsa unstable branch.
Howdy version (sudo howdy version): 2.6.1

comparing systemd-inhibit commands, it appear that the UPower dependency is probably the culprit.

Upower is a dependency of kio, so I will be opening a kde bug report to see if this is their problem.

https://bugs.kde.org/show_bug.cgi?id=450855

It appears that this is a known issue with upower that only happened two days ago. So if anyone comes across this bug, it is due to upower versions 0.99.15-1 to 0.99.16-1


Interoperability with externally hosted project content pages

Is your feature request related to a problem? Please describe
To make up for the fact that Metagrid doesn't contain a CMS unlike CoG, projects will still need to manage pages.  This was requested by Laura at the ESGF-XC without objections
Describe the solution you'd like
Each project search page should have a clear link to the project's landing page.  The database and API could manage the urls for each project.
In addition, we should be able to give out targeted links so a project-specific search can be directly accessible.  These links may also be embedded into CoG for transition purposes to get users to try Metagrid.
eg. https://yourdomain.org/metagrid?project=CMIP6

Just a note, it seems like adding CMS capabilities to metagrid may be possible: https://docs.django-cms.org/en/3.0.8/how_to/integrate.html


[IOTDB-2602] Add the new feature of the null value filter to support filtering based on partial columns

You can see the details in JIRA.

Coverage increased (+0.001%) to 67.827% when pulling 9f436249bb42243e4ab1798d7b19faf8c6a71d90 on zjx1230:feature_iotdb_2602 into 5286d42d5bc5e2befcf3a254163e7c0d3394d286 on apache:master.


Problem using nodejs 8.9.4 & npm 5.6.0

💥 Proposal
Update documentation in getting started > installation.
My node version is 8.9.4, npm version is 5.6.0.
When I run command docusaurus-init in my environment, there is no doc folder, and only package.json file in the website folder.
So, Looks like it need to modify documentation.
It is run well in over node.js 9.0 version.
Thank you ✋
Have you read the Contributing Guidelines on issues?
👌 Yes

PR is welcome :hand:

Thx, I'll fix getting started documentation typo from Node >=8 to Node >=9, And Pull request. Thank you!! 👍

We will support Node >=10, not Node 9. Anyway let's only close this after the PR is merged.

Okay. I understand. (compatible for current Node.js LTS versions)
Thank you ✋


feat: add interaction id into execute response(#1788)

Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn would you mind reviewing this PR, it is a backport of #1788

I am a little surprised that the response is allowed to be updated. We may revisit this in the app sec review for any risks.

We may need to add a flag to indicate if it is a internal call or from restful, if internal, it should be able to update any fields. Adding the response field into allowedList should be a temp solution.

I am a little surprised that the response is allowed to be updated. We may revisit this in the app sec review for any risks.

@Zhangxunmt , I remember we planned to control allowed fields for REST API. Seems the control is on transport action now.

@SuZhou-Joe  Github CI failed

@SuZhou-Joe Github CI failed

Checking that.

I am a little surprised that the response is allowed to be updated. We may revisit this in the app sec review for any risks.

The current logic is to create the a memory message first with response is empty, then add trace memory message and finally update the response of the memory message created in the first step.

I am a little surprised that the response is allowed to be updated. We may revisit this in the app sec review for any risks.

The current logic is to create the a memory message first with response is empty, then add trace memory message and finally update the response of the memory message created in the first step.

Thanks, now I see. We should enable more strict allow list in the rest layer. The response shouldn’t be updated from apis.

@ylwu-amzn @Zhangxunmt CI fixed and please help to reapprove, thanks.


Allow specifying sort criteria on Table viz

Coverage increased (+0.03%) to 69.147% when pulling 6e2a924e822309dc542b43c21281b7c226934325 on mistercrunch:table_sort_by into 8223729e1ebee9fa0a1116c736037f750e8b2578 on apache:master.

LGTM


fix(modal): not possible to disable close

Pull request checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)
[x] Build (yarn build) was run locally and any changes were pushed
[ ] Unit tests (yarn test) were run locally and passed
[ ] Visual Regression Tests (yarn visual-regression) were run locally and passed
[x] Linting (npm lint) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

[x] Bug fix
[ ] Feature
[ ] Refactoring (no functional changes, no API changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

GitHub Issue Number: #848
What is the new behavior?

-Prevent the Dialog to close on press on ESC (even if the user has clicked on the Dialog)
Does this introduce a breaking change?

[ ] Yes
[x] No

Testing

Other information

@maheshchandra10 thanks for your PR, but what are you trying to achieve here? You changed just a documentation snippet.

@maheshchandra10 I close the PR because there is

no interaction after PR opend
PR does nothing regarding the mentioned issue
pipeline is broken


Fix not logging 3D gesture z component correctly in Gesture Detection example

Thanks to @Wumpf, we identified a problem in the 3D view and fixed it. It was a typo (y instead z) and made the view look 2D instead of 3D.

What
Checklist

[x] I have read and agree to Contributor Guide and the Code of Conduct
[x] I've included a screenshot or gif (if applicable)
[x] I have tested the web demo (if applicable):

Using newly built examples: app.rerun.io
Using examples from latest main build: app.rerun.io
Using full set of examples from nightly build: app.rerun.io

[x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
[x] If applicable, add a new check to the release checklist!

PR Build Summary
Docs preview
Examples preview
Recent benchmark results
Wasm size tracking

(skipped ci on this for obvious reasons)


Alembic 1.4.2 breaks pip-compile 5.2.1

Environment Versions

OS Type: Ubuntu
Python version: Python 3.8.1
pip version:  pip 20.1.1 from /home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip (python 3.8)
pip-tools version: pip-compile, version 5.2.1

Steps to replicate

pip install pip-tools==5.2.1
Create an empty directory, put a requirements.in with alembic==1.4.2 as the only content in it
Switch in that directory and execute pip-compile

Expected result
With alembic==1.4.1 I get the following requirements.txt. I expected something similar:
#
# This file is autogenerated by pip-compile
# To update, run:
#
#    pip-compile
#
alembic==1.4.1            # via -r requirements.in
mako==1.1.3               # via alembic
markupsafe==1.1.1         # via mako
python-dateutil==2.8.1    # via alembic
python-editor==1.0.4      # via alembic
six==1.15.0               # via python-dateutil
sqlalchemy==1.3.18        # via alembic

Actual result
$ pip-compile
    ERROR: Command errored out with exit status 1:
     command: /home/math/.pyenv/versions/3.8.1/bin/python3.8 /home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip install --ignore-installed --no-user --prefix /tmp/pip-build-env-27xtrkc1/overlay --no-warn-script-location --no-binary :none: --only-binary :none: -i https://pypi.org/simple -- 'setuptools>=40.8.0' wheel
         cwd: None
    Complete output (44 lines):
    Traceback (most recent call last):
      File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/runpy.py", line 193, in _run_module_as_main
        return _run_code(code, main_globals, None,
      File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/runpy.py", line 86, in _run_code
        exec(code, run_globals)
      File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip/__main__.py", line 26, in <module>
        sys.exit(_main())
      File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip/_internal/cli/main.py", line 73, in main
        command = create_command(cmd_name, isolated=("--isolated" in cmd_args))
      File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip/_internal/commands/__init__.py", line 104, in create_command
        module = importlib.import_module(module_path)
      File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/importlib/__init__.py", line 127, in import_module
        return _bootstrap._gcd_import(name[level:], package, level)
      File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
      File "<frozen importlib._bootstrap>", line 991, in _find_and_load
      File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
      File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
      File "<frozen importlib._bootstrap_external>", line 783, in exec_module
      File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
      File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip/_internal/commands/install.py", line 24, in <module>
        from pip._internal.cli.req_command import RequirementCommand, with_cleanup
      File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip/_internal/cli/req_command.py", line 16, in <module>
        from pip._internal.index.package_finder import PackageFinder
      File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip/_internal/index/package_finder.py", line 21, in <module>
        from pip._internal.index.collector import parse_links
      File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip/_internal/index/collector.py", line 14, in <module>
        from pip._vendor import html5lib, requests
      File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip/_vendor/requests/__init__.py", line 114, in <module>
        from . import utils
      File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip/_vendor/requests/utils.py", line 25, in <module>
        from . import certs
      File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip/_vendor/requests/certs.py", line 15, in <module>
        from pip._vendor.certifi import where
      File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip/_vendor/certifi/__init__.py", line 1, in <module>
        from .core import contents, where
      File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip/_vendor/certifi/core.py", line 12, in <module>
        from importlib.resources import read_text
      File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/importlib/resources.py", line 11, in <module>
        from typing import Iterable, Iterator, Optional, Set, Union   # noqa: F401
      File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/typing.py", line 1357, in <module>
        class Callable(extra=collections_abc.Callable, metaclass=CallableMeta):
      File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/typing.py", line 1005, in __new__
        self._abc_registry = extra._abc_registry
    AttributeError: type object 'Callable' has no attribute '_abc_registry'
    ----------------------------------------
Traceback (most recent call last):
  File "/home/math/.pyenv/versions/3.8.1/bin/pip-compile", line 8, in <module>
    sys.exit(cli())
  File "/home/math/.local/lib/python3.8/site-packages/click/core.py", line 764, in __call__
    return self.main(*args, **kwargs)
  File "/home/math/.local/lib/python3.8/site-packages/click/core.py", line 717, in main
    rv = self.invoke(ctx)
  File "/home/math/.local/lib/python3.8/site-packages/click/core.py", line 956, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/math/.local/lib/python3.8/site-packages/click/core.py", line 555, in invoke
    return callback(*args, **kwargs)
  File "/home/math/.local/lib/python3.8/site-packages/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/piptools/scripts/compile.py", line 444, in cli
    results = resolver.resolve(max_rounds=max_rounds)
  File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/piptools/resolver.py", line 169, in resolve
    has_changed, best_matches = self._resolve_one_round()
  File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/piptools/resolver.py", line 274, in _resolve_one_round
    their_constraints.extend(self._iter_dependencies(best_match))
  File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/piptools/resolver.py", line 380, in _iter_dependencies
    dependencies = self.repository.get_dependencies(ireq)
  File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/piptools/repositories/local.py", line 74, in get_dependencies
    return self.repository.get_dependencies(ireq)
  File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/piptools/repositories/pypi.py", line 228, in get_dependencies
    self._dependencies_cache[ireq] = self.resolve_reqs(
  File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/piptools/repositories/pypi.py", line 181, in resolve_reqs
    results = resolver._resolve_one(reqset, ireq)
  File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip/_internal/resolution/legacy/resolver.py", line 362, in _resolve_one
    abstract_dist = self._get_abstract_dist_for(req_to_install)
  File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip/_internal/resolution/legacy/resolver.py", line 314, in _get_abstract_dist_for
    abstract_dist = self.preparer.prepare_linked_requirement(req)
  File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip/_internal/operations/prepare.py", line 487, in prepare_linked_requirement
    abstract_dist = _get_prepared_distribution(
  File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip/_internal/operations/prepare.py", line 91, in _get_prepared_distribution
    abstract_dist.prepare_distribution_metadata(finder, build_isolation)
  File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip/_internal/distributions/sdist.py", line 38, in prepare_distribution_metadata
    self._setup_isolation(finder)
  File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip/_internal/distributions/sdist.py", line 66, in _setup_isolation
    self.req.build_env.install_requirements(
  File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip/_internal/build_env.py", line 199, in install_requirements
    call_subprocess(args, spinner=spinner)
  File "/home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip/_internal/utils/subprocess.py", line 241, in call_subprocess
    raise InstallationError(exc_msg)
pip._internal.exceptions.InstallationError: Command errored out with exit status 1: /home/math/.pyenv/versions/3.8.1/bin/python3.8 /home/math/.pyenv/versions/3.8.1/lib/python3.8/site-packages/pip install --ignore-installed --no-user --prefix /tmp/pip-build-env-27xtrkc1/overlay --no-warn-script-location --no-binary :none: --only-binary :none: -i https://pypi.org/simple -- 'setuptools>=40.8.0' wheel Check the logs for full command output.

Hello @MartinThoma,
Thanks for the issue! Possible related to https://github.com/pypa/pip/issues/8272.

@MartinThoma
Can't reproduce this bug.

See details

user@host:~$ docker run --rm -it python:3.8 bash

root@c775c83ce43b:/# uname -a
Linux c775c83ce43b 5.3.0-1034-azure #35~18.04.1-Ubuntu SMP Mon Jul 13 12:54:45 UTC 2020 x86_64 GNU/Linux

root@c775c83ce43b:/# pip --version
pip 20.1.1 from /usr/local/lib/python3.8/site-packages/pip (python 3.8)

root@c775c83ce43b:/# pip-compile --version
pip-compile, version 5.2.1

root@c775c83ce43b:/# cat requirements.in
alembic==1.4.2

root@c775c83ce43b:/# pip-compile -v
Using indexes:
  https://pypi.org/simple

                          ROUND 1
Current constraints:
  alembic==1.4.2 (from -r requirements.in (line 1))

Finding the best candidates:
  found candidate alembic==1.4.2 (constraint was ==1.4.2)

Finding secondary dependencies:
  alembic==1.4.2 not in cache, need to check index
  Collecting alembic==1.4.2
    Downloading alembic-1.4.2.tar.gz (1.1 MB)
       |████████████████████████████████| 1.1 MB 9.2 MB/s
    Installing build dependencies ... done
    Getting requirements to build wheel ... done
      Preparing wheel metadata ... done
    Saved /root/.cache/pip-tools/pkgs/alembic-1.4.2.tar.gz
  alembic==1.4.2            requires Mako, python-dateutil, python-editor>=0.3, SQLAlchemy>=1.1.0

New dependencies found in this round:
  adding ['mako', '', '[]']
  adding ['python-dateutil', '', '[]']
  adding ['python-editor', '>=0.3', '[]']
  adding ['sqlalchemy', '>=1.1.0', '[]']
Removed dependencies in this round:
------------------------------------------------------------
Result of round 1: not stable

                          ROUND 2
Current constraints:
  alembic==1.4.2 from https://files.pythonhosted.org/packages/60/1e/cabc75a189de0fbb2841d0975243e59bde8b7822bacbb95008ac6fe9ad47/alembic-1.4.2.tar.gz#sha256=035ab00497217628bf5d0be82d664d8713ab13d37b630084da8e1f98facf4dbf (from -r requirements.in (line 1))
  Mako (from alembic==1.4.2->-r requirements.in (line 1))
  python-dateutil (from alembic==1.4.2->-r requirements.in (line 1))
  python-editor>=0.3 (from alembic==1.4.2->-r requirements.in (line 1))
  SQLAlchemy>=1.1.0 (from alembic==1.4.2->-r requirements.in (line 1))

Finding the best candidates:
  found candidate alembic==1.4.2 (constraint was ==1.4.2)
  found candidate mako==1.1.3 (constraint was <any>)
  found candidate python-dateutil==2.8.1 (constraint was <any>)
  found candidate python-editor==1.0.4 (constraint was >=0.3)
  found candidate sqlalchemy==1.3.18 (constraint was >=1.1.0)

Finding secondary dependencies:
  python-editor==1.0.4 not in cache, need to check index
  Collecting python-editor==1.0.4
    Downloading python_editor-1.0.4-py3-none-any.whl (4.9 kB)
    Saved /root/.cache/pip-tools/wheels/python_editor-1.0.4-py3-none-any.whl
  python-editor==1.0.4      requires -
  mako==1.1.3 not in cache, need to check index
  Collecting Mako==1.1.3
    Downloading Mako-1.1.3-py2.py3-none-any.whl (75 kB)
       |████████████████████████████████| 75 kB 1.3 MB/s
    Saved /root/.cache/pip-tools/wheels/Mako-1.1.3-py2.py3-none-any.whl
  mako==1.1.3               requires MarkupSafe>=0.9.2
  sqlalchemy==1.3.18 not in cache, need to check index
  Collecting SQLAlchemy==1.3.18
    Downloading SQLAlchemy-1.3.18-cp38-cp38-manylinux2010_x86_64.whl (1.3 MB)
       |████████████████████████████████| 1.3 MB 50.0 MB/s
    Saved /root/.cache/pip-tools/wheels/SQLAlchemy-1.3.18-cp38-cp38-manylinux2010_x86_64.whl
  sqlalchemy==1.3.18        requires -
  alembic==1.4.2            requires Mako, python-dateutil, python-editor>=0.3, SQLAlchemy>=1.1.0
  python-dateutil==2.8.1 not in cache, need to check index
  Collecting python-dateutil==2.8.1
    Downloading python_dateutil-2.8.1-py2.py3-none-any.whl (227 kB)
       |████████████████████████████████| 227 kB 74.3 MB/s
    Saved /root/.cache/pip-tools/wheels/python_dateutil-2.8.1-py2.py3-none-any.whl
  python-dateutil==2.8.1    requires six>=1.5

New dependencies found in this round:
  adding ['markupsafe', '>=0.9.2', '[]']
  adding ['six', '>=1.5', '[]']
Removed dependencies in this round:
------------------------------------------------------------
Result of round 2: not stable

                          ROUND 3
Current constraints:
  alembic==1.4.2 from https://files.pythonhosted.org/packages/60/1e/cabc75a189de0fbb2841d0975243e59bde8b7822bacbb95008ac6fe9ad47/alembic-1.4.2.tar.gz#sha256=035ab00497217628bf5d0be82d664d8713ab13d37b630084da8e1f98facf4dbf (from -r requirements.in (line 1))
  Mako (from alembic==1.4.2->-r requirements.in (line 1))
  MarkupSafe>=0.9.2 (from Mako==1.1.3->alembic==1.4.2->-r requirements.in (line 1))
  python-dateutil (from alembic==1.4.2->-r requirements.in (line 1))
  python-editor>=0.3 (from alembic==1.4.2->-r requirements.in (line 1))
  six>=1.5 (from python-dateutil==2.8.1->alembic==1.4.2->-r requirements.in (line 1))
  SQLAlchemy>=1.1.0 (from alembic==1.4.2->-r requirements.in (line 1))

Finding the best candidates:
  found candidate alembic==1.4.2 (constraint was ==1.4.2)
  found candidate mako==1.1.3 (constraint was <any>)
  found candidate markupsafe==1.1.1 (constraint was >=0.9.2)
  found candidate python-dateutil==2.8.1 (constraint was <any>)
  found candidate python-editor==1.0.4 (constraint was >=0.3)
  found candidate six==1.15.0 (constraint was >=1.5)
  found candidate sqlalchemy==1.3.18 (constraint was >=1.1.0)

Finding secondary dependencies:
  markupsafe==1.1.1 not in cache, need to check index
  Collecting MarkupSafe==1.1.1
    Downloading MarkupSafe-1.1.1-cp38-cp38-manylinux1_x86_64.whl (32 kB)
    Saved /root/.cache/pip-tools/wheels/MarkupSafe-1.1.1-cp38-cp38-manylinux1_x86_64.whl
  markupsafe==1.1.1         requires -
  mako==1.1.3               requires MarkupSafe>=0.9.2
  sqlalchemy==1.3.18        requires -
  alembic==1.4.2            requires Mako, python-dateutil, python-editor>=0.3, SQLAlchemy>=1.1.0
  python-editor==1.0.4      requires -
  python-dateutil==2.8.1    requires six>=1.5
  six==1.15.0 not in cache, need to check index
  Collecting six==1.15.0
    Using cached six-1.15.0-py2.py3-none-any.whl (10 kB)
    Saved /root/.cache/pip-tools/wheels/six-1.15.0-py2.py3-none-any.whl
  six==1.15.0               requires -
------------------------------------------------------------
Result of round 3: stable, done

#
# This file is autogenerated by pip-compile
# To update, run:
#
#    pip-compile
#
alembic==1.4.2            # via -r requirements.in
mako==1.1.3               # via alembic
markupsafe==1.1.1         # via mako
python-dateutil==2.8.1    # via alembic
python-editor==1.0.4      # via alembic
six==1.15.0               # via python-dateutil
sqlalchemy==1.3.18        # via alembic

I only vaguely remember this one. I think it was related to https://github.com/pypa/pip/issues/7874 ? (I cannot reproduce this bug anymore as I have no longer access to the codebase where it happened)

I suggest to close it until somebody can reproduce it. Would that be fine?

I'll close this then. Thanks!


Accessibility: Cannot focus out of the integrated terminal

Testing #6654

click into the integrated terminal
try to Tab out, does not work
in other places (editor) we use ctrl+m as a toggle between the widget trapping focus or not

Need https://github.com/sourcelair/xterm.js/issues/118 to be pushed for this.


Adapter status is Unknown

Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[x] iOS

Version of OS(s) listed above with issue
11.3
Version of Library
6.0
Expected Behaviour
Scanning
Actual Behavior
System.ArgumentException: Your adapter status is Unknown
throwing Line:
bleAdapter.Scan().Subscribe(scanResult =>  {      Debug.WriteLine("ScanResult changed: " + scanResult.Device.Name); });
bleAdapter is:
IAdapter bleAdapter = CrossBleAdapter.Current;
When using the Scan Extra Method, i'm able to scan one time. But on the next scan it also throws with the same exception.
var serviceUuidList = new List<Guid> { SERVICE_ID };

bleAdapter.ScanExtra(new ScanConfig { ServiceUuids = serviceUuidList })
        .Distinct(sr => sr.Device.Uuid)
        .TakeUntil(Observable.Timer(timeSpan)).Finally(() =>
 {
    logger.Debug("Stop Scan"); bleAdapter.StopScan();
 });

`

You are scanning before the adapter is ready to take requests.  This is why I provide Adapter.WhenStatusChanged.  ScanExtra works on top of this which is why it works.  Are you sure the 2nd scan exception is "Your adapter status is Unknown".  I'd expect it to possibly be "You already have a scan in progress" or something similar.  I notice you also aren't storing the subscription to your Scan call either.  If you are manually cancelling scans, you need to dispose of the subscription before starting a new one.
Please try to give code external to my library.  Simply reiterating stuff that I've seen isn't helpful.

Hallo Ritchi, Thanks for your fast Response!
You are right, the 2nd scan exception is: "There is already an existing scan".
I don't store the scan subscription because i'm using takeUntil to automatically get rid of the subscription.
Let me try to explain what i'm doing:
I have a ViewModel called DeviceListViewModel with a simple ObservableCollection of Custom Ble Devices and a Scanbutton in the toolbar. Now, when pressing the ScanButton, i clear the Device List, make sure that Bluetooth on the Mobile Device is enabled and then i call the Scan Method from my
Bluetooth Manager class, which is a simple wrapper for bluetooth related functions (For Scan i just filter for my custom devices).
When pressing the Scan Button in the toolbar, below method gets called:
async Task ScanButton_ClickedAsync()
        {
            if (_scanSub != null)
            {
                _scanSub.Dispose();
            }
            LabelNoDevicesIsVisible = false;

            Device.BeginInvokeOnMainThread(() => UserDialogs.Instance.ShowLoading());

            DeviceList.Clear();

            SelectedDevice = null;

            var mobileDeviceManager = DependencyService.Get<IMobileDeviceManager>();

            if (!mobileDeviceManager.IsBluetoothEnabled())
            {
                var confirmationResult = await UserDialogs.Instance.ConfirmAsync("Enable Bluetooth?", "Bluetooth disabled", "Ok", "Cancel");
                if (confirmationResult)
                {
                    var deviceManager = DependencyService.Get<IMobileDeviceManager>();
                    if (deviceManager.EnableBluetooth())
                    {
                        UserDialogs.Instance.Toast("Bluetooth has been enabled");
                    }
                    else
                    {
                        Device.BeginInvokeOnMainThread(() => UserDialogs.Instance.HideLoading());
                        LabelNoDevicesIsVisible = true;
                        return;
                    }
                }
                else
                {
                    Device.BeginInvokeOnMainThread(() => UserDialogs.Instance.HideLoading());
                    LabelNoDevicesIsVisible = true;
                    return;
                }
            }
            Debug.WriteLine("Bluetooth Enabled ");

            _scanSub = BluetoothLEManager.Instance.Scan(TimeSpan.FromSeconds(3))
                .Select(scanResult => new CustomBleDevice(scanResult.Device, scanResult.AdvertisementData))
                .Finally(() => {
                if (DeviceList.Count == 0)
                {
                    LabelNoDevicesIsVisible = true;
                }
                Device.BeginInvokeOnMainThread(() => UserDialogs.Instance.HideLoading());
            }).Subscribe(customBleDevice =>
            {
                if (PersistenceManager.GetMyDevicesList().Where(device=>device.ID == customBleDevice.ID).Count() != 0)
                {
                    zaBleDevice.ListStatus = "added";
                }
                DeviceList.Add(customBleDevice);
            });
        }

The Scan Method in the Bluetooth Manager class just filters the devices:
            var serviceUuidList = new List<Guid> { SERVICE_ID };

            return CrossBleAdapter.Current.ScanExtra(new ScanConfig { ServiceUuids = serviceUuidList })
                .Distinct(sr => sr.Device.Uuid)
                .TakeUntil(Observable.Timer(timeSpan))
                .Finally(()=> { logger.Debug("Stop Scan");});

I tried with and without stop scan, but on the second Scan i get, like you said, "There is already an existing" scan.
I hope it is more clear now. Looking forward for your response.

The auto-dispose methods don't always fire right away.  You really should manage those disposals yourself.  Also, iOS may not throw the breaks on scanning immediately, so you may need to give a brief pause before starting your next scan.
PS - you don't need to do this.  I manage the thread for you in my other library (stay on topic for this library though pls):
Device.BeginInvokeOnMainThread(() => UserDialogs.Instance.ShowLoading());

I completely refactored my Code so that every subscription gets disposed but it's still not working even after waiting a couple of minutes before scanning again.

I guess you'll have to debug with the library.  I run all of my unit tests from a fresh (scan, find device, stop scan, connect to device, do test) and they all run fine.
Please don't just add "it's not working" as it adds no value to the discussion.  What did you refactor, how, did you look at the lib code to see what may be tripping up for you, etc.

You are right, "it's not working" doesn't add value to the discussion, sorry for that.
When using "true" as the last parameter, i'm able to scan as often as i want, on iOS.
On Android i get:
"Callback cannot be null" exception the 2nd time scanning.
I will look at my Code again, seems like the subscription doesn't get disposed correctly or the StopScan method doesn't get called. In any case the problem seems to be on my side.
Thank you for your time!

StopScan was meant to be an emergency brake.  If you call it, existing scans will likely implode like you are seeing.  This is why I default ScanExtra(restart) to false.
I'll take a peak at the android side, but not sure anything will materialize from it


JavaScript autocomplete for private class methods

VSCode Version: 1.50.0
OS Version: Ubuntu 18.04.5

class Test {

  #test = '';

  #foo() {
    console.log(this.#test);
  }

  bar() {
    this.#foo();
  }
}

When i enter this. inside bar method in the list of suggested options there are only #test and __#31431@#foo which results in this["__#31431@#foo"]
It would be nice to have in suggested options #foo and on select this option it turned out to this.#foo()

/duplicate of #106351


Serial number changed

          Very interesting! Turns out that when your SmartEVSE is turned on, it calculates a 5 digit serial number from the MAC address, and uses that to put up the AP for wifi configuration. And later on it calculates a 4 digit serial number from a pre-programmed value. To prevent confusion I disabled the second number, but now you say the second one is on the physical label, my conclusion is that I made the wrong decision....

1.5.2RC.zip
Would you be so kind to test the included firmware.bin (spiffs.bin has not changed); it should give you back your "old" serial number, and hopefully it still gets recognized by the HomeAssistant component....
Originally posted by @dingo35 in https://github.com/serkri/SmartEVSE-3/issues/85#issuecomment-1375477614

Seeing the serial number change with 1.5.1 and 1.5.2. Was 3426, now 5264. The router reports smartevse-3426 but can only be reached by smartevse-5264.

What does the physical label on your smartevse say as a serial number?

Already looked for that yesterday: there is no label. But from the first day the number has been: 3426 (had a note of that in my node-red node).

You probably need to have some patience to have mDNS processed the change.
Note that the formal mDNS address would be  <SmartEVSE-3426.local> , noting upper and lowercase.
The fact that your smartevse can be reached by <smartevse-5264[.lan|.local]> is a strange behavior that stims from the original firmware; we just want to stay compatible.

I which direction is that change going to happen? Will the SmartEVSE be reachable by SmartEVSE-3426.local in the end you expect?
SmartEVSE-3426 has always been the hostname reported by my router, so why does it not resolve? (rhetoric). As fas as I know SmartEVSE-3426.local has never worked before, I've always used the IP address because of that. Until lately...I saw the other hostname in the HA integration.
I'm not attached to any of these numbers, but it is nice to be sure what is (and remains) correct because otherwise some of my flows will break when the hostname does not resolve.


Compiler should not crash with stack trace for simple syntax error

Currently if we compile MML like this simple (note that - is at wrong place):
1 e0g0-b4.

It results in:
Exception in thread "main" dev.atsushieno.mugene.MmlException: (unknown) (152, 40) : error: no viable alternative at input '0.0'
	at dev.atsushieno.mugene.MmlCompiler.reportOnConsole(mml_compiler_main.kt:70)
	at dev.atsushieno.mugene.MmlCompiler.access$reportOnConsole(mml_compiler_main.kt:41)
	...

But that's absurd. It should report simple syntax error instead.

Now we do not crash like ^ anymore:

(unknown) (1, 7) : error: no viable alternative at input '0.0'


Earth photos

Added .earth_photos command
Closes issue #174
Description
Added a .earth_photos command by using the unsplash api
Reasoning
An approved issue I was assigned to.
Screenshots

Additional Details
Please add environment variable UNSPLASH_KEY and set it to the key for an unsplash app created on their API
Did you:

[x] Join the Python Discord Community?
[x] If dependencies have been added or updated, run pipenv lock?
[x] Lint your code (pipenv run lint)?
[x] Set the PR to allow edits from contributors?

Hi there, I ran the linter but it seems to not have returned the errors that are showing on the server check.

What command did you run?

@Xithrius  pipenv run lint

If you haven't already, try running pipenv run precommit, and then pipenv run lint.

I'm re-running it now.

@Xithrius I ran pre-commit, it's buffering on Flake8 right now

By installing the precommit hook, committing will be blocked until you fix all of its complaints.

@Xithrius it didn't complain when run but checks failed on github action. Flake8 passed now.

@Xithrius @HassanAbouelela so as I'm seeing it, I need to do the following:
[ ] Switch to aiohttp
[ ] Remove unneeded modules
[ ] Change docstrings
[ ] Reformat embeds
[ ] Make sure stuff complies with the unsplash API
Give me a day or two and I'll try to fix these!

This PR is looking good so far, but it is not in compliance with the unsplash API, so I am blocking it. The rules it violates are:
API Guidelines, Technical Guidelines Section, Point 2: "you must send a request to the download endpoint". See here for a more complete review of how this should be done.
API Guidelines, Technical Guidelines Section, Point 3: "..your application must... contain a link back to their Unsplash profile."
Note: all the API requirements are recorded here. I hate to ask this because you already did the work, but is this API really worth using when we have to jump through this many hoops?

Probably not but I'll do it anyway because I've done a lot of it already

@HassanAbouelela The issues you presented should be fixed.

@ChrisLovering self.bot.http_session only works once.

@ChrisLovering never mind, fixed

I've dismissed my review for now, as it seems we are now in compliance with the API's requirements. I tried to make sure we meet them to the best of my ability, but I am not a lawyer. If someone is more legally inclined, or if someone has time to sort through a bunch of requirements, I'd appreciate a second set of eyes looking over: https://help.unsplash.com/en/articles/2511245-unsplash-api-guidelines.

@ChrisLovering i have made the changes requested.

it seems pipenv failed install on the lint check, should I re-commit or will someone re-run it?

It seems I forgot to lock, fixing now.

Alright, lint passed!

@Shivansh-007 I've fixed everything over in my repo

@Shivansh-007 it seems some of this is outdated, as the logging thing no longer exists as shown here

@Shivansh-007 it seems some of this is outdated, as the logging thing no longer exists as shown here

Which logging thing are you talking about?

@Shivansh-007 it seems some of this is outdated, as the logging thing no longer exists as shown here

Which logging thing are you talking about?

You said something about it in the change requested directly below here

sorry, two under the linked comment

@Shivansh-007 it seems some of this is outdated, as the logging thing no longer exists as shown here

Which logging thing are you talking about?

You said something about it in the change requested directly below here

I never said anything about logging, I asked you to remove the wrapper I.e. UnClient_id = Tokens.unsplash_key  and use Tokens.unsplash_key directly.

oh im dumb

@Shivansh-007 all changes have been made

@ChrisLovering made the requested changes

Thanks @ChrisLovering !

@Shivansh-007 all changes made

Thanks! Looks Good To Me!

No problem!

Made a quick update to the info at the top, make sure to take a look as it is important for api verification

to the people merging this:
It should take 5-10 business days for unsplash to review an application

Storing these here for the application, but I have the raw versions too.

awesome! thanks for the animations

@Kronifer The token is ready, please update the app name to Sir Lancebot (I believe in code that would be Sir%20Lancebot

@HassanAbouelela thats done!

awesome!


Installing pip pyfast error

I have installed the pyfast using pip but it gives an error when I try to import:

I have installed all the requirements, I have CUDA, cuda-toolkit installed already. I am using ubuntu 23.10

I have not tested FAST on Ubuntu 23 yet.
But based on the output here, there seems to be some compatibility issues here.
Note to self: libcairo.so.2 on ubuntu 20.04 doesn't have the pixman_image_set_dither symbol either.. Is this an issue related to the pixman library?
Can you provide me the output of ldd /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/libFAST.so
This should list the libraries it is trying to load.

THank you for the prompt response. There was no libFAST.so file but libFAST.so.4, here is the output
linux-vdso.so.1 (0x00007ffce91e4000)
	libOpenCL.so.1 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/libOpenCL.so.1 (0x00007fd97de00000)
	libQt5Core.so.5 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/libQt5Core.so.5 (0x00007fd97d400000)
	libQt5Gui.so.5 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/libQt5Gui.so.5 (0x00007fd97ca00000)
	libQt5Widgets.so.5 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/libQt5Widgets.so.5 (0x00007fd97c000000)
	libQt5OpenGL.so.5 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/libQt5OpenGL.so.5 (0x00007fd97bc00000)
	libQt5Multimedia.so.5 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/libQt5Multimedia.so.5 (0x00007fd97b800000)
	libQt5Network.so.5 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/libQt5Network.so.5 (0x00007fd97b400000)
	libz.so.1 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/libz.so.1 (0x00007fd97b000000)
	libOpenIGTLink.so.3 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/libOpenIGTLink.so.3 (0x00007fd97ac00000)
	librealsense2.so.2.40 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/librealsense2.so.2.40 (0x00007fd979e00000)
	libtiff.so.5 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/libtiff.so.5 (0x00007fd979a00000)
	libopenslide.so => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/libopenslide.so (0x00007fd979600000)
	libdcmdata.so.13 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/libdcmdata.so.13 (0x00007fd979000000)
	libdcmimgle.so.13 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/libdcmimgle.so.13 (0x00007fd978a00000)
	libofstd.so.13 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/libofstd.so.13 (0x00007fd978600000)
	libhdf5_cpp.so.103 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/libhdf5_cpp.so.103 (0x00007fd978200000)
	libJKQTPlotterSharedLib_Release.so.4.0.0 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/libJKQTPlotterSharedLib_Release.so.4.0.0 (0x00007fd977c00000)
	libOpenGL.so.0 => /lib/x86_64-linux-gnu/libOpenGL.so.0 (0x00007fd97ea25000)
	libGLX.so.0 => /lib/x86_64-linux-gnu/libGLX.so.0 (0x00007fd97e9f3000)
	libX11.so.6 => /lib/x86_64-linux-gnu/libX11.so.6 (0x00007fd97e0c2000)
	libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fd97e9ec000)
	libstdc++.so.6 => /lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007fd977800000)
	libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fd97dd15000)
	libgomp.so.1 => /lib/x86_64-linux-gnu/libgomp.so.1 (0x00007fd97e999000)
	libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fd97e975000)
	libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fd977400000)
	/lib64/ld-linux-x86-64.so.2 (0x00007fd97ea6d000)
	libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fd97e96e000)
	libglib-2.0.so.0 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/libglib-2.0.so.0 (0x00007fd977000000)
	libGL.so.1 => /lib/x86_64-linux-gnu/libGL.so.1 (0x00007fd97e03b000)
	libssl.so.1.1 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/libssl.so.1.1 (0x00007fd976c00000)
	libcrypto.so.1.1 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/libcrypto.so.1.1 (0x00007fd976600000)
	libusb-1.0.so.0 => /lib/x86_64-linux-gnu/libusb-1.0.so.0 (0x00007fd97e01d000)
	libjpeg.so.8 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/libjpeg.so.8 (0x00007fd976200000)
	libpixman-1.so.0 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/libpixman-1.so.0 (0x00007fd975e00000)
	libcairo.so.2 => /lib/x86_64-linux-gnu/libcairo.so.2 (0x00007fd97beb9000)
	libgdk_pixbuf-2.0.so.0 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/libgdk_pixbuf-2.0.so.0 (0x00007fd975a00000)
	libopenjp2.so.7 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/libopenjp2.so.7 (0x00007fd975600000)
	libsqlite3.so.0 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/libsqlite3.so.0 (0x00007fd975200000)
	libxml2.so.2 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/libxml2.so.2 (0x00007fd974e00000)
	libpng16.so.16 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/libpng16.so.16 (0x00007fd974a00000)
	libgobject-2.0.so.0 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/libgobject-2.0.so.0 (0x00007fd974600000)
	libgio-2.0.so.0 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/libgio-2.0.so.0 (0x00007fd974200000)
	liboflog.so.13 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/liboflog.so.13 (0x00007fd973e00000)
	libhdf5.so.103 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/libhdf5.so.103 (0x00007fd973800000)
	libQt5Svg.so.5 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/libQt5Svg.so.5 (0x00007fd973400000)
	libJKQTMathTextSharedLib_Release.so.4.0.0 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/libJKQTMathTextSharedLib_Release.so.4.0.0 (0x00007fd973000000)
	libJKQTCommonSharedLib_Release.so.4.0.0 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/libJKQTCommonSharedLib_Release.so.4.0.0 (0x00007fd972c00000)
	libQt5PrintSupport.so.5 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/libQt5PrintSupport.so.5 (0x00007fd972800000)
	libGLdispatch.so.0 => /lib/x86_64-linux-gnu/libGLdispatch.so.0 (0x00007fd97c948000)
	libxcb.so.1 => /lib/x86_64-linux-gnu/libxcb.so.1 (0x00007fd97d3d6000)
	libpcre.so.3 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/../lib/libpcre.so.3 (0x00007fd972400000)
	libudev.so.1 => /lib/x86_64-linux-gnu/libudev.so.1 (0x00007fd97d3a5000)
	libfontconfig.so.1 => /lib/x86_64-linux-gnu/libfontconfig.so.1 (0x00007fd97c8fa000)
	libfreetype.so.6 => /lib/x86_64-linux-gnu/libfreetype.so.6 (0x00007fd97bb34000)
	libXext.so.6 => /lib/x86_64-linux-gnu/libXext.so.6 (0x00007fd97dd00000)
	libXrender.so.1 => /lib/x86_64-linux-gnu/libXrender.so.1 (0x00007fd97e010000)
	libxcb-render.so.0 => /lib/x86_64-linux-gnu/libxcb-render.so.0 (0x00007fd97dcf2000)
	libxcb-shm.so.0 => /lib/x86_64-linux-gnu/libxcb-shm.so.0 (0x00007fd97e95d000)
	libgmodule-2.0.so.0 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/../lib/libgmodule-2.0.so.0 (0x00007fd972000000)
	libicuuc.so.60 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/../lib/libicuuc.so.60 (0x00007fd971c00000)
	liblzma.so.5 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/../lib/liblzma.so.5 (0x00007fd971800000)
	libffi.so.6 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/../lib/libffi.so.6 (0x00007fd971400000)
	libselinux.so.1 => /lib/x86_64-linux-gnu/libselinux.so.1 (0x00007fd97d378000)
	libresolv.so.2 => /lib/x86_64-linux-gnu/libresolv.so.2 (0x00007fd97d366000)
	libmount.so.1 => /lib/x86_64-linux-gnu/libmount.so.1 (0x00007fd97be6d000)
	libQt5Xml.so.5 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/../lib/libQt5Xml.so.5 (0x00007fd971000000)
	libXau.so.6 => /lib/x86_64-linux-gnu/libXau.so.6 (0x00007fd97d360000)
	libXdmcp.so.6 => /lib/x86_64-linux-gnu/libXdmcp.so.6 (0x00007fd97c8f2000)
	libcap.so.2 => /lib/x86_64-linux-gnu/libcap.so.2 (0x00007fd97c8e6000)
	libexpat.so.1 => /lib/x86_64-linux-gnu/libexpat.so.1 (0x00007fd97b7d5000)
	libbz2.so.1.0 => /lib/x86_64-linux-gnu/libbz2.so.1.0 (0x00007fd97b7c2000)
	libbrotlidec.so.1 => /lib/x86_64-linux-gnu/libbrotlidec.so.1 (0x00007fd97b3f3000)
	libicudata.so.60 => /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/../lib/../lib/libicudata.so.60 (0x00007fd96f400000)
	libpcre2-8.so.0 => /lib/x86_64-linux-gnu/libpcre2-8.so.0 (0x00007fd97b358000)
	libblkid.so.1 => /lib/x86_64-linux-gnu/libblkid.so.1 (0x00007fd97b31d000)
	libbsd.so.0 => /lib/x86_64-linux-gnu/libbsd.so.0 (0x00007fd97b308000)
	libbrotlicommon.so.1 => /lib/x86_64-linux-gnu/libbrotlicommon.so.1 (0x00007fd97b2e5000)

I think there is an incompatibility between libpixman bundled with FAST, and the libcairo on your system.
Which is a bit strange since both have the same SO version on ubuntu 18 as in ubuntu 23.
There are two quick hacks you can try if you are up to it:

Try to move the file /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/./../lib/../lib/libpixman-1.so.0 away from its folder
If that dosesn't work, move the libpixman file back, and add the files in this zip file to /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/lib/ libcairo2.zip

I need to setup a machine with ubuntu 23 to investigate this further. Thanks for reporting this!

The first solution gives me core dumped error:

Second hack did not change anything

More compatibility issues then.. Qt this time.
You can try to do export QT_DEBUG_PLUGINS=1, before running python.
There might be an error message there that gives more meaning why it is not able to load Qt.

I think this is the problem?
Got keys from plugin meta data ("xcb")
QFactoryLoader::QFactoryLoader() checking directory path "/home/baran/micromamba/envs/image_classification/bin/platforms" ...
Cannot load library /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/plugins/platforms/libqxcb.so: (libxcb-xinerama.so.0: cannot open shared object file: No such file or directory)
QLibraryPrivate::loadPlugin failed on "/home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/plugins/platforms/libqxcb.so" : "Cannot load library /home/baran/micromamba/envs/image_classification/lib/python3.10/site-packages/fast/plugins/platforms/libqxcb.so: (libxcb-xinerama.so.0: cannot open shared object file: No such file or directory)"
qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.

I have run the command: sudo apt install libxcb-xinerama0 and it imported successfully, Lets see if it is usable after all.

I have run the command: sudo apt install libxcb-xinerama0 and it imported successfully, Lets see if it is usable after all.

Ok, great. Let me know how it goes.
I will have to add this dependency to the requirements in the documentation.

Update:
This issue was introduced in Ubuntu 23.10. FAST works on Ubuntu 23.04.
Removing libpixman-1.so.0 makes FAST work on Ubuntu 23.10.
Will try to remove libpixman from the build


Create additional query parameters for protucts api limit and offset

Description
Create additional query parameters for protucts api
Fixes #92
How to test?
Pull the Branch,
Run: npm run dev ,
Make a call to the api/fetch fx. /api/products?limit=5&offset=3
Checklist

[x] I have performed a self-review of my own code
[x] I have followed the name conventions for CSS Classnames and filenames, Components names and filenames, Style filenames, if you are in doubt check the the project README.MD and here https://github.com/HackYourFuture-CPH/curriculum/blob/master/review/review-checklist.md
[x] I have commented my code, particularly in hard-to-understand areas, if you code was simple enough mark the box anyway
[x] I have made corresponding changes to the documentation, if you code was simple enough mark the box anyway
[x] This PR is ready to be merged and not breaking any other functionality

It's working as it should with the API call and the example you provided above, but I cannot check it in the swagger. I think, maybe you can provide the parameters for the swagger as well.


Fix screen resolution distortion bug.

Certain screen resolutions like 1360x768 do not display correctly. Maybe related to VBE mode max pixel clock, refresh rate, or another parameter of the modes? Ideal fix will allow full-resolution full-color support of all offered resolutions.

May get resolved by: https://github.com/Zeal-Operating-System/ZealOS/pull/161


[new feature] enable deep linking

Is your feature request related to a problem? Please describe.
A NFT receiver, without web3 wallet, should have the least steps to claiming the NFT.
Describe the solution you'd like
Deep linking: https://medium.com/@trustwallet/mobile-dapps-with-deep-linking-and-trust-wallet-6a4712b9b9a4

this is for trust wallet. what is the main priority? trust wallet or Imtoken?

@SoIidarity the imToken syntax is 'imtokenv2://navigate/DappView?url=https://radi.cards/r/0x9209.....'
Like it is at the moment, when the user opens the claim link, it will propose a bunch of wallet options. So we can implement the trust wallet syntax for their link, and the imToken systax in their link.


Fixed login with --cred got hang

#346
This is the migration of IOS app login

Thank you @821wkli !

#346
This is the migration of IOS app login

thank you, it is working again

Thank you, it works

it works, save my day. thank you!

Thanks

Is it still working for you?
I'm getting some error when trying to login (https://github.com/821wkli/safaribooks/blob/login_fix/safaribooks.py#L477-L488)
[#] Unhandled Exception: Expecting value: line 1 column 1 (char 0) (type: JSONDecodeError)

If I add print(response.text) just before trying to decode as JSON I can see the next body:

<TITLE>Access Denied</TITLE>

Access Denied

You don't have permission to access "http://api.oreilly.com/api/v1/auth/login/" on this server.

Reference #18.8b7a7b5c.1708962162.62e9acfa

not working anymore. refer #351 for manual walk around.

Is it still working for you? I'm getting some error when trying to login (https://github.com/821wkli/safaribooks/blob/login_fix/safaribooks.py#L477-L488)
[#] Unhandled Exception: Expecting value: line 1 column 1 (char 0) (type: JSONDecodeError)

If I add print(response.text) just before trying to decode as JSON I can see the next body:

<TITLE>Access Denied</TITLE>

Access Denied

You don't have permission to access "http://api.oreilly.com/api/v1/auth/login/" on this server.

Reference #18.8b7a7b5c.1708962162.62e9acfa

not working anymore. refer #351 for manual walk around.

Is it still working for you? I'm getting some error when trying to login (https://github.com/821wkli/safaribooks/blob/login_fix/safaribooks.py#L477-L488)
[#] Unhandled Exception: Expecting value: line 1 column 1 (char 0) (type: JSONDecodeError)

If I add print(response.text) just before trying to decode as JSON I can see the next body:

<TITLE>Access Denied</TITLE>

Access Denied

You don't have permission to access "http://api.oreilly.com/api/v1/auth/login/" on this server.

Reference #18.8b7a7b5c.1708962162.62e9acfa

I've tried setting the cookies manually but it still didn't work

What I find works for me is to
pip install browser_cookie3

add
import browser_cookie3

to safaribooks.py and change
        if not args.cred:
            if not os.path.isfile(COOKIES_FILE):
                self.display.exit("Login: unable to find `cookies.json` file.\n"
                                  "    Please use the `--cred` or `--login` options to perform the login.")

            self.session.cookies.update(json.load(open(COOKIES_FILE)))

to
        if not args.cred:
            # if not os.path.isfile(COOKIES_FILE):
            #     self.display.exit("Login: unable to find `cookies.json` file.\n"
            #                       "    Please use the `--cred` or `--login` options to perform the login.")

            # self.session.cookies.update(json.load(open(COOKIES_FILE)))
            self.session.cookies.update(browser_cookie3.chrome())

Then, if I log in using Chome and run the script without providing credentials, it works.

thank you @teticio, worked for me,


fix(versions): update Activiti/activiti-cloud-application-chart versions into master

UpdateBot pushed helm dependency: example-cloud-connector to: 7.1.55

UpdateBot commands:
updatebot push-version --kind helm example-cloud-connector 7.1.55

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.jenkins-x-bot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

UpdateBot commands:
updatebot push-version --kind make CONNECTOR_ACTIVITI_CLOUD_DEPENDENCIES_VERSION 7.1.46

UpdateBot commands:
updatebot push-version --kind helm activiti-cloud-audit 7.1.53

UpdateBot commands:
updatebot push-version --kind helm activiti-cloud-query 7.1.54

UpdateBot commands:
updatebot push-version --kind make QUERY_ACTIVITI_CLOUD_DEPENDENCIES_VERSION 7.1.46

UpdateBot commands:
updatebot push-version --kind helm example-runtime-bundle 7.1.69

UpdateBot commands:
updatebot push-version --kind make RB_ACTIVITI_CLOUD_DEPENDENCIES_VERSION 7.1.46

UpdateBot commands:
updatebot push-version --kind helm activiti-cloud-notifications-graphql 7.1.49

UpdateBot commands:
updatebot push-version --kind make NOTIFICATIONS_ACTIVITI_CLOUD_DEPENDENCIES_VERSION 7.1.46


Update star-calling-assist

Forgot to set auto call and auto update to be enabled by default on fresh installs, been causing confusion.

Note that you cannot retroactively change a warning for a plugin, and so you may not be able to use it as a way to show agreement with a privacy policy.


[WIP] Create "learning" page to organize docs

not ready for review

[X] Closes #2302
[X] I am familiar with the contributing guidelines
[ ] ~Tests added~
[ ] ~Updates entries in docs/sphinx/source/reference for API changes.~
[ ] Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
[X] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
[ ] Pull request is nearly complete and ready for detailed review.
[ ] Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

#2302 for discussion

One limitation: visible main header section titles is currently limited to five headers, so the last one is now kept under "more"
Can this maximum be changed?
If not, I suggest swapping the order of "whatsnew" and "contributing". Having whatsnew at the end seems more intuitive to me, so I'd like to suggest this anyway even if all sections are listed upfront (no "more" list)

@kandersolar sure np I remember 😅 you're too fast 😂

Would it make sense to get rid of index.rst and have the User Guide link go straight to Package Overview?

In my view, it's not a bad idea and it'd probably work well for me personally. The downside I see is for users who navigate by or like to view the subsubsections of each subsection. This makes me lean slightly away from the change, but does anyone navigate/view docs like this...?


Error filename logging with tf.logging.warn

Please make sure that this is a bug. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): windows 7
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 1.13.1
Python version: 3.7.0

You can collect some of this information using our environment capture script
You can also obtain the TensorFlow version with
python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
Describe the current behavior
stdout prints
tf_logging.py:warn - test warn
<stdin>:<module> - test warning

Describe the expected behavior
stdout prints
<stdin>:<module> - test warn
<stdin>:<module> - test warning

Code to reproduce the issue
import logging
import sys
h = logging.StreamHandler(sys.stdout)
formatter = logging.Formatter("%(filename)s:%(funcName)s - %(message)s")
h.setFormatter(formatter)
log = logging.getLogger()
log.addHandler(h)
import tensorflow as tf
tf.logging.warn("test warn")
tf.logging.warning("test warning")

Other info / logs
since the logging.warn of python3 is the wrapper of logging.warning, code is here,
this adds one frame making the get_caller(4) of tf.logging miss the warn method.

Added PR #27871 for the fix.


Bogus ":1:1 - error intersect-non-model: Cannot intersect non-model types (including union types)." error message.

The following code gives me a mysterious error:
import "@cadl-lang/rest";

using Cadl.Http;

model Foo {
  name: string;

  size: int32;
}

model Empty {};

model SomeError {};

interface LifetimeOperations<
    TResource,
    TRepeatableRequests=Empty,
    TError=SomeError>
{

    read(): TResource | { @statusCode _: 200; } & TError;
}

@route("/xxx")
interface X mixes LifetimeOperations<{},
    {}>{};

Diagnostics were reported during compilation:

<unknown location>:1:1 - error intersect-non-model: Cannot intersect non-model types (including union types).

Playground Link
Swapping out the default value for the TError parameter to {} makes things compile.

Simplified repro

I think this is the same problem as https://github.com/microsoft/cadl/issues/387


Feature to convert text to link or link to text

Currently novel.sh doesn't support feature to convert text to actual link e.g. "Twitter" word to actual twitter link.

This looks AWESOME! It does need a couple of visual UI tweaks but please do make a PR and we can iterate on it 😄

Alright! Let's do it


Add support for TLS_RSA_WITH_AES_128_GCM_SHA256

1. What version of Caddy are you using (caddy -version)?
0.10.2
2. What are you trying to do?
openssl s_client -cipher AES128-GCM-SHA256 -connect mysite.com:443
3. What is your entire Caddyfile?
	tls /etc/caddy/ssl/mysite-bundle.crt /etc/caddy/ssl/mysite.key
	root /home/caddy
}

4.  Please paste any relevant HTTP request(s) here.
openssl s_client -cipher AES128-GCM-SHA256 -connect mysite.com:443
6. What did you expect to se
---
New, TLSv1/SSLv3, Cipher is AES128-GCM-SHA256
Server public key is 2048 bit
Secure Renegotiation IS supported
Compression: NONE
Expansion: NONE
SSL-Session:
    Protocol  : TLSv1.2
    Cipher    : AES128-GCM-SHA256

7. What did you see instead (give full error messages and/or log)?
140106362275744:error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure:s23_clnt.c:744:
---
no peer certificate available
---
No client certificate CA names sent
---
SSL handshake has read 7 bytes and written 99 bytes
---
New, (NONE), Cipher is (NONE)
Secure Renegotiation IS NOT supported
Compression: NONE
Expansion: NONE
---

8. How can someone who is starting from scratch reproduce the bug as minimally as possible?
Just run openssl s_client -cipher AES128-GCM-SHA256 -connect yourcaddysite.com:443

That cipher suite is blacklisted: https://http2.github.io/http2-spec/#BadCipherSuites

Hmm, yup, Francis is right. TLS_RSA_WITH_AES_128_GCM_SHA256 (0x9c) is on the blacklist. I don't see a productive reason to add this to Caddy. Thanks for the feature request though!


Remove the transparent margins from Google Play logo on README.md

Uh, nice! I wanted to do this but got lazy lol Thanks!

Uh, nice! I wanted to do this but got lazy lol Thanks!

 I know this feeling :sweat_smile: , the small details can be quite overwhelming when finishing a project.
The good part of it being open source is that we can help with some of them!


added leetcode solution for Candy

Related Issue
Closes #683
Description
keetcode problem 135 solution added
Type of PR

[ ] Bug fix
[X] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Checklist

[X] I have performed a self-review of my code.
[X] I have read and followed the Contribution Guidelines.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers, screenshots, and videos after making the changes.
[X] I have commented my code, particularly in hard-to-understand areas.

@Ajay-Dhangar the code has been updated based on the suggestion

@mahek0620, to calculate the score for your leaderboard, you'll need to add something to those files and then try it out at the bottom. Below is the code you need to include for your author profile in the documentation:
---

Authors:

{['github_username'].map(username => (
 <Author key={username} username={username} />
))}

@Ajay-Dhangar Do i need to create new PR because this PR is closed I can't edit any file and also can you mention the files which I need to change


devcontainer build returns 0 even after failure

Building a Dockerfile that includes an error - e.g. "forget" \ at the end of a continuation line - fails but devcontainer returns the success error code (0).
$ devcontainer build --image-name sagebionetworks/challenge-devcontainer:test
[497 ms] Start: Run in Host: /home/tschaffter/.vscode-remote-containers/bin/b3318bc0524af3d74034b8bb8a64df0ccf35549a/node /home/tschaffter/.vscode-remote-containers/dist/dev-containers-cli-0.245.2/dist/spec-node/devContainersSpecCLI.js build --workspace-folder /home/tschaffter/dev2/tschaffter/challenge-registry/tools/devcontainers/challenge-devcontainer --log-level info --log-format json --image-name sagebionetworks/challenge-devcontainer:test
[581 ms] remote-containers 0.245.2.
[712 ms] Start: Run: docker buildx build --load --build-arg BUILDKIT_INLINE_CACHE=1 -f /tmp/vsch-tschaffter/container-features/0.245.2-1661698018485/Dockerfile-with-features -t sagebionetworks/challenge-devcontainer:test --target dev_containers_target_stage --build-arg imageVersion=bullseye-20211220-slim --build-arg devcontainerVersion= --build-context dev_containers_feature_content_source=/tmp/vsch-tschaffter/container-features/0.245.2-1661698018485 --build-arg _DEV_CONTAINERS_BASE_IMAGE=dev_container_auto_added_stage_label --build-arg _DEV_CONTAINERS_IMAGE_USER=root --build-arg _DEV_CONTAINERS_FEATURE_CONTENT_SOURCE=dev_container_feature_content_temp /home/tschaffter/dev2/tschaffter/challenge-registry/tools/devcontainers/challenge-devcontainer/.devcontainer
[+] Building 1.1s (6/6) FINISHED
 => [internal] load build definition from Dockerfile-with-features         0.0s
 => => transferring dockerfile: 3.44kB                                     0.0s
 => [internal] load .dockerignore                                          0.0s
 => => transferring context: 2B                                            0.0s
 => resolve image config for docker.io/docker/dockerfile:1.4               0.8s
 => CACHED docker-image://docker.io/docker/dockerfile:1.4@sha256:443aab4c  0.0s
 => [internal] load build definition from Dockerfile-with-features         0.0s
 => [internal] load .dockerignore                                          0.0s
error: failed to solve: rpc error: code = Unknown desc = failed to solve with frontend dockerfile.v0: failed to solve with frontend gateway.v0: rpc error: code = Unknown desc = dockerfile parse error on line 58: unknown instruction: &&
[2169 ms] Error: Command failed: docker buildx build --load --build-arg BUILDKIT_INLINE_CACHE=1 -f /tmp/vsch-tschaffter/container-features/0.245.2-1661698018485/Dockerfile-with-features -t sagebionetworks/challenge-devcontainer:test --target dev_containers_target_stage --build-arg imageVersion=bullseye-20211220-slim --build-arg devcontainerVersion= --build-context dev_containers_feature_content_source=/tmp/vsch-tschaffter/container-features/0.245.2-1661698018485 --build-arg _DEV_CONTAINERS_BASE_IMAGE=dev_container_auto_added_stage_label --build-arg _DEV_CONTAINERS_IMAGE_USER=root --build-arg _DEV_CONTAINERS_FEATURE_CONTENT_SOURCE=dev_container_feature_content_temp /home/tschaffter/dev2/tschaffter/challenge-registry/tools/devcontainers/challenge-devcontainer/.devcontainer
[2169 ms]     at HS (/home/tschaffter/.vscode-remote-containers/dist/dev-containers-cli-0.245.2/dist/spec-node/devContainersSpecCLI.js:256:1490)
[2169 ms]     at processTicksAndRejections (internal/process/task_queues.js:93:5)
[2169 ms]     at async Cu (/home/tschaffter/.vscode-remote-containers/dist/dev-containers-cli-0.245.2/dist/spec-node/devContainersSpecCLI.js:255:2801)
[2170 ms]     at async $P (/home/tschaffter/.vscode-remote-containers/dist/dev-containers-cli-0.245.2/dist/spec-node/devContainersSpecCLI.js:360:12358)
[2170 ms]     at async jP (/home/tschaffter/.vscode-remote-containers/dist/dev-containers-cli-0.245.2/dist/spec-node/devContainersSpecCLI.js:360:10865)
[2173 ms] Exit code 1

$ echo $?
0

I initially spotted the issue in our CI workflow, which was not stopping after devcontainer build had failed.

Thanks for the issue. I think this is also only repro'ing the "vscode" edition of the CLI (https://github.com/devcontainers/cli/issues/145#issuecomment-1232083188)

This is fixed in the latest versions of Remote-Containers (0.251.0 and 0.252.0-pre-release).


Fix parser for helper scripts to support USM API as input

Description
Generators for Compile-time API can't work with USM API, because func_parser, that they all use, doesn't understand dependencies parameter with default value dependencies = {}
The fix will make func_parser support this parameter correctly.
This is a helper scrip so it won't affect build and tests.

Hi @vmalia Did you try other scripts as well? I wonder if they already work and only this one is broken.

@mmeterel , do you see that some script still doesn't work correctly after this fix?
Previously all scripts didn't work, because they all use this func_parser to get the list of functions, and this parser skips USM API because of the issue that this fix is for.

@mkrainiuk I did not test the scripts myself. I will probably use them when I add future backends.


Add support for a mandatory-copy-propagation pass.

It is currently disabled so this commit is NFC.
MandatoryCopyPropagation canonicalizes all all OSSA lifetimes with
either CopyValue or DestroyValue operations. While regular
CopyPropagation only canonicalizes lifetimes with copies. This ensures
that more lifetime program bugs are found in debug builds. Eventually,
regular CopyPropagation will also canonicalize all lifetimes, but for
now, we don't want to expose optimized code to more behavior change
than necessary.
Add frontend flags for developers to easily control copy propagation:
-enable-copy-propagation: enables whatever form of copy propagation the current pipeline runs (mandatory-copy-propagation at -Onone, regular copy-propation at -O).
-disable-copy-propagation: similarly disables any form of copy
propagation in the current pipelien.
To control a specific variant of the passes, use
-Xllvm -disable-pass=mandatory-copy-propagation
or -Xllvm -disable-pass=copy-propagation instead.
The meaning of these flags will stay the same as we adjust the
defaults. Soon mandatory-copy-propagation will be enabled by
default. There are two reasons to do this, both related to predictable
behavior across Debug and Release builds.

Shortening object lifetimes can cause observable changes in program
behavior in the presense of weak/unowned reference and
deinitializer side effects.

Programmers need to know reliably whether a given code pattern will
copy the storage for copy-on-write types (Array, Set). Eliminating
the "unexpected" copies the same way at -Onone and -O both makes
debugging tractable and provides assurance that the code isn't
relying on the luck of the optimizer in a particular compiler
release.

@swift-ci test

@swift-ci smoke test


chore: modify the 'release' workflow to include Javadoc

as title

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4ecec68) 0.00% compared to head (4887ead) 0.00%.
Report is 3 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #257   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files          75      75
  Lines        2568    2568
  Branches      278     278
======================================
  Misses       2568    2568

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

After this change, 'release' action failed again, and I still don't know what the problem is.

After this change, 'release' action failed again, and I still don't know what the problem is.

the deploy lacks of asc files, the signed files with GPG.
I see you configed OSSRH_USER and OSSRH_PASSWORD and GPG_PASSWORD in the release.yml.  looks like you missied GPG username?
you can try this action:
  - name: Deploy Release to Maven package
    uses: samuelmeuli/action-maven-publish@v1
    with:
      nexus_username: ${{ secrets.OSSRH_USER }}
      nexus_password: ${{ secrets.OSSRH_PASSWORD }}
      gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }}
      gpg_passphrase: ${{ secrets.GPG_PASSPHRASE }}

Let's see how it goes now via https://github.com/nebula-contrib/ngbatis/pull/258 @CorvusYe @Nicole00

I recreated a release to make the changes work, but it failed. The same configuration snapshot and v1.1.5 can be successful, not because the version is beta end, right?
@wey-gu @Nicole00


aws config

Documentation is missing on how to provide .aws/ config

Please use env file: https://github.com/aws/aws-mwaa-local-runner/pull/149


Failed prop type: The prop rows of ForwardRef(TextareaAutosize) is deprecated. Use rowsMin instead

Recently, I've updated Material UI from '4.11.4' to '4.12.1' and got a few warnings about deprecation props. I fixed them all but one. When I use the multiline and rows props in the TextField component, I get the error:
Warning: Failed prop type: The prop `rows` of `ForwardRef(TextareaAutosize)` is deprecated. Use `rowsMin` instead.
    in ForwardRef(TextareaAutosize) (created by ForwardRef(InputBase))
    in ForwardRef(InputBase) (created by WithStyles(ForwardRef(InputBase)))
    in WithStyles(ForwardRef(InputBase)) (created by ForwardRef(Input))
    in ForwardRef(Input) (created by WithStyles(ForwardRef(Input)))
    in WithStyles(ForwardRef(Input)) (created by ForwardRef(TextField))
    in div (created by ForwardRef(FormControl))
    in ForwardRef(FormControl) (created by WithStyles(ForwardRef(FormControl)))
    in WithStyles(ForwardRef(FormControl)) (created by ForwardRef(TextField))
    in ForwardRef(TextField) (created by WithStyles(ForwardRef(TextField)))
    in WithStyles(ForwardRef(TextField)) (created by Test)
    in Test
    in Unknown (created by Context.Consumer)
    in Route (created by Nn)
    in Switch (created by Nn)
    in Nn (created by Un)
    in Un (created by Qn)
    in main (created by Qn)
    in Bt (created by Qn)
    in div (created by Qn)
    in Qn (created by App)
    in App
    in Router (created by BrowserRouter)
    in BrowserRouter

When I replace the rows with rowsMin, it says that this prop doesn't exist.
My code:
import React from 'react'

import {TextField as TF} from '@material-ui/core';

export const Test = () => {
  return (
    <TF
      name="name"
      label='Name'
      helperText="Text field example"
      multiline
      rows={3}
      maxRows={3}
      onChange={(val)=>{ console.log('onChange', val) }}
      />
  )
}

package.json:
"dependencies": {
    "@date-io/date-fns": "^1.3.13",
    "@material-ui/core": "~4.12.1",
    "@material-ui/icons": "^4.9.1",
    "@material-ui/lab": "^4.0.0-alpha.56",
    "@material-ui/pickers": "^3.2.10",
    ...
}

I'm having this issue as well.

Fixed in https://github.com/mui-org/material-ui/pull/27293 will release on monday.

the fix is not working. Im still getting the error in 4.12.2