Fixes HMR when used as a global decorator

@Coobaha thanks so much! We would love to get a test added for this case. Is that something you could do? 😸

@johnthepink 👍

@Coobaha awesome! I'll get this released!

Published!

@Coobaha beautiful!


fix invalid memory panic when release db in high concurrency of chaincode query

Signed-off-by: wuqiaomin<EMAIL_ADDRESS>Type of change

Bug fix

Description
In the condition of high concurrency of chaincode query, peer will crash after TXSimulator finish SimulateProposal, because queryExecutor's dbItr release db again and the function AddInt32 in Release will panic.
Hence, inspect whether db is nil before dbIter release db.

I'm not sure I understand the scenario - but it seems to me we're fixing the effect (nil pointer) rather than the cause (why that pointer is not valid). @manish-sethi - your thoughts?

Not exactly this but I had come across something in these lines that caused a test flake. In that case, it was a race condition between Iterator opening and closing of goleveldb. This was fixed in this commit.
This reported issue seem some other concurrency issue inside goleveldb, because we are not calling DB close ever in a regular running peer. Full panic stack trace will be helpful here.
Also, as @cendhu mentioned, if it turns out to be an issue that cannot be controlled from outside by changing the way we use the APIs and needs a fix in goleveldb, the fix should be submitted to goleveldb repo and we can upgrade the goleveldb.
I think that this PR can be closed and the bug and potential solution be discussed in a Jira.

It's important to add that it is an occasional phenomenon in the case of high concurrency and high CPU and memory rate of utilization, and no sooner panic hit than peer restart.
Related Jira issue has been created.
So I close this PR.


Provide a custom table header.

Is it possible to create a custom table header and provide it to the table? Right now the table header does not look good on mobile devices and I wanted to create my own.

It depends on what you mean by custom table header. You can customize the toolbar with customToolbar and you can pass in components for the title as well as override any class styles.

I have tried modifying the toolbar. It works fine on desktop, but it is harder to get right on mobile. What do you think if I get a PR out to add this feature?

I think I'd need to understand the problem in more detail before I decide that a PR would be a good thing. Here is it how it looks on iPhone X in Chrome's mobile view emulator:

That looks ok to me. If what you see is different, can you explain how this comes about? I may also need to see an example in codesandbox.

I think in the example you gave it looks good. The problem starts when the header only has 1 or 2 icons.

Try adding flex: none to MUIDataTableToolbar-actions and let me know if that resolves it. If so, I'll open a PR, as I think the nested flex behavior might be causing issues.

I tried this but I still can not get it the icons to align properly. The table is taking more width than the viewport and the icons are being moved the viewport.
An option to place a custom header will useful because some tables have complex headers or need to be customized in a special way.

I need a codesandbox to see what you're doing, otherwise, there is no way I can help, as I don't see your issue on my machine on in the examples. Also, not sure about the need for custom header. Everything in the header can already be customized with styles and components of your choosing.

The only way I'm able to re-create this is if I input a compontent as the title:
<MUIDataTable title={

Table Prefix - Really long

table header, table header

} data={data} columns={columns} options={options} />

However, it looks like it's solvable with some styling:
<MUIDataTable title={

Table Prefix - Really long

table header, table header

} data={data} columns={columns} options={options} />


Split evaluataion data into two lists, list.eval and list.validate

If the ratio is 90:10 then

list.train is 90%
list.test is 10%

list.test is split into two equal parts

list.eval is 5%
list.validate is 5%

A 2nd list for validation should not be needed. Tesseract already uses list.eval for the validation:
At iteration 27453/48040/48082, Mean rms=0.589%, delta=2.793%, char train=9.8%, word train=17.46%, skip ratio=0.1%,  New worst char error = 9.8
At iteration 26336, stage 1, Eval Char error rate=13.930723, Word error rate=22.55628 wrote checkpoint.

I think the first CER value of 9.8 % is the accuracy on the training data while the second CER value of 13.9 % is the accuracy on the evaluation data.

A 2nd list for validation should not be needed. Tesseract already uses list.eval for the validation:
At iteration 27453/48040/48082, Mean rms=0.589%, delta=2.793%, char train=9.8%, word train=17.46%, skip ratio=0.1%,  New worst char error = 9.8
At iteration 26336, stage 1, Eval Char error rate=13.930723, Word error rate=22.55628 wrote checkpoint.

I think the first CER value of 9.8 % is the accuracy on the training data while the second CER value of 13.9 % is the accuracy on the evaluation data.

I think the first CER value of 9.8 % is the accuracy on the training data
while the second CER value of 13.9 % is the accuracy on the evaluation data.

Yes, that's correct.
The reason for adding a third list was that list.eval is evaluated while
lstmtraining is running and results might be in the training process to
improve results.
Having the a 3rd list and using it later for lstmeval helps validate that
the training CER, evaluation CER are similar to the validation CER on
images not at all seen during training process.
When the training set is very large and representative, then the numbers
are similar, but in some cases there are wide differences.
I will share some recent graphs.
On Fri, Jan 15, 2021 at 1:16 AM Stefan Weil<EMAIL_ADDRESS>wrote:

@Shreeshrii https://github.com/Shreeshrii, according to your plots it
looks like there is a difference between "evaluation" and "validation". How
does a plot change if you exchange list.eval and list.validate and run
the training again?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tesseract-ocr/tesstrain/pull/217#issuecomment-760434663,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABG37I3IM555OXIOEC6KLVTSZ5CXZANCNFSM4U7BESLA
.

--

भजन - कीर्तन - आरती @ http://bhajans.ramparivar.com

I think the first CER value of 9.8 % is the accuracy on the training data
while the second CER value of 13.9 % is the accuracy on the evaluation data.

Yes, that's correct.
The reason for adding a third list was that list.eval is evaluated while
lstmtraining is running and results might be in the training process to
improve results.
Having the a 3rd list and using it later for lstmeval helps validate that
the training CER, evaluation CER are similar to the validation CER on
images not at all seen during training process.
When the training set is very large and representative, then the numbers
are similar, but in some cases there are wide differences.
I will share some recent graphs.
On Fri, Jan 15, 2021 at 1:16 AM Stefan Weil<EMAIL_ADDRESS>wrote:

@Shreeshrii https://github.com/Shreeshrii, according to your plots it
looks like there is a difference between "evaluation" and "validation". How
does a plot change if you exchange list.eval and list.validate and run
the training again?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tesseract-ocr/tesstrain/pull/217#issuecomment-760434663,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABG37I3IM555OXIOEC6KLVTSZ5CXZANCNFSM4U7BESLA
.

--

भजन - कीर्तन - आरती @ http://bhajans.ramparivar.com

How does a plot change if you exchange list.eval and list.validate and run the training again?

@stweil I have not tried that. I will test and report.

How does a plot change if you exchange list.eval and list.validate and run the training again?

@stweil I have not tried that. I will test and report.

When the training set is very large and representative, then the graphs are similar for both list.eval and list.validate.
Hence closing this PR as not needed.

When the training set is very large and representative, then the graphs are similar for both list.eval and list.validate.
Hence closing this PR as not needed.


Add TypeScript typings

Hi Eric,
I would like to use saveSvgAsPng in my TypeScript project. It requires typings - special bindings for external JS library allowing to access it from TypeScript code. There are two ways to provide typings for JS library: place it inside project or in separate repository. First way is preferred. Some more details you can find by link: https://github.com/typings/typings/issues/322
I suppose saveSvgAsPng has quite simple and stable API so it will not be difficult to maintain typings inside package. I've created pull-request with it: #85
Please let me know what do you think about it. Thanks

I recommend you create a separate repo. This project does not depend on TypeScript in any way. I don't want to update this project whenever TypeScript syntax or conventions change, and I won't be able to help anyone who has a question or problem with the TypeScript typings.
If you create a separate repo for TypeScript typings, I will happily accept a pull request to the Readme that tells users where it is.


Remove SHA1 signing

Make the appropriate changes to sign only with SHA2 certs. See microbuild email on this topic for cert names to use.

What needs to change exactly? We don't have direct SHA references
        <Authenticode Condition="%(Extension) == '.nupkg'">NuGet</Authenticode>
        <Authenticode Condition="%(Extension) != '.nupkg'">Microsoft</Authenticode>

Microsoft needs to change to Microsoft400


mpm event/worker/prefork: late(r) children stop on restart.

Extended to all unix MPMs (event, worker and prefork).

Committed to trunk (https://github.com/apache/httpd/commit/243c5fad0a8da9a1008681ac60f5b981de6c18d6)


Detect if digest of any version is different from digests from existing reviewers.

Seems like a quick and easy way to automatically check any corruption / tampering.
Probably another variant on VerificationStatus would do.

Already implemented.


Incorrect Target Account Result Returned When Executing hedera_signAndExecuteQuery on https://wc.hgraph.app/

Describe the bug A clear and concise description of what the bug is.
To Reproduce Steps to reproduce the behavior:

Go to 'https://wc.hgraph.app/'
Input necessary field and process "Initialize WalletConnect" for both "dApp" and "Wallet" on the page.
Connet dApp to Wallet
Input necessary field as following and proceed "4. hedera_signAndExecuteQuery".

Account ID: 0.0.398606
Payment account id: the account connected to dApp from the wallet as a signer.

Proceed request and check the query result.

Expected behavior A clear and concise description of what you expected to happen.
The account for the result from the query should be the account Id in the field named "Account ID", in this case, 0.0.398606.
Screenshots If applicable, add screenshots to help explain your problem.
The account for the result from the query is the payment account Id in the field named "Payment account id", in this case.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context Add any other context about the problem here.

Describe the bug A clear and concise description of what the bug is.
To Reproduce Steps to reproduce the behavior:

Go to 'https://wc.hgraph.app/'

Input necessary field and process "Initialize WalletConnect" for both "dApp" and "Wallet" on the page.

Connet dApp to Wallet

Input necessary field as following and proceed "4. hedera_signAndExecuteQuery".

Account ID: 0.0.398606
Payment account id: the account connected to dApp from the wallet as a signer.

Proceed request and check the query result.

Expected behavior A clear and concise description of what you expected to happen. The account for the result from the query should be the account Id in the field named "Account ID", in this case, 0.0.398606.
Screenshots If applicable, add screenshots to help explain your problem. The account for the result from the query is the payment account Id in the field named "Payment account id", in this case.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context Add any other context about the problem here.

Thanks for flagging this issue. I believe the issue is that the latest signer in the array was being pulled instead of what was provided in the params. The PR we are currently testing should resolve this.

I am closing this issue out as the newest canary release resolves this issue and can be tested on the docs: https://hwc-docs.hgraph.app/demos


Performance Issues in Large Instances

I've noticed stuttering and generally poor performance after spending some time and a large instance (60-80 people) with more than one override zone. I want to say it feels like a memory leak as it gets worse over time but not able to say for certain as the only way to replicate it is in an actual instance.
It doesn't seem to happen if there aren't any override zones so I would bet the issue is somewhere in there.

Thanks for letting me know, which version are you using? 0.8 or older? 1.0?

I did some investigation and I found out that this is most likely caused by excessive logging on my part.
In this example I have 100 players entering a zone all at once for example and it allocates >100 Mb of memory just for logging and the array stuff I am doing.
That is obviously sub-optimal to not say bad.

I will address this issue before I release 1.0 officially.

I managed to address the issue and removed a large chunk of allocations: down from 115Mb for 100 players down to 9Mb:

There certainly is still some room for improvement as I have not yet transitioned to the new DataLists and DataDictionaries.

Resolved in 1.0.0-rc.1


increase number of concurrent git operations allowed

motivation: better performance
changes: increase the max number of concurrent git operations to 3/4 of active CPUs

@swift-ci smoke test


Change the scope for spring-data-hadoop-util from provided to default

Resolves #153

Cherry picked per https://github.com/spring-cloud/spring-cloud-stream-app-starters/commit/de601ddca77a2f699926bccdf39ab829acf5e2b4


Three New Color Schemes added.

This PR closes the following issues:-
closes #5
Changes made:-

Added amber.css file.
Added khaki.css file.
Added indigo.css file

I won't close the issue because we can always use more!


WIP: Added timezone checking and comments on PRs

Testing this out with a comment to see if it takes action

Is @manishapriya94 awake?

Will close this if it continues not to work as intended, trying to trigger a response within the PR here.  If it works, will remove WIP label!

is @abirismyname awake?

Is @abirismyname awake?


Can you provide the implementations for the motivation?

Thanks for the great work.
However, I am very interested in the motivation and DG experiments you have provided.
Can you share the code for that, too?
(AutoEncoder experiment for Visualization and the experiments for the PACS dataset)
Thanks!

I am interested in Domain Generalization too. Could you please provid the PACS code? thank you so mush! @onuriel


Do not assert that task schema has a specific number of tasks

I have an explanation for #19824. It's a side effect of the way our testing infrastructure works.

We have different executers (embedded, forking, parallel, configCache, noDaemon and some others).
We have different distributions (full distributions and partial distributions) that is roughly based on the dependencies of the project we're testing.
We use these executers for different levels of feedback. e.g., QuickFeedback is based on the embedded executer. PullRequestFeedback uses forking and configCache. Those different executers require different distributions.

For all executers except noDaemon, we use a partial distribution. You can see that here:
https://ge.gradle.org/s/jez6oqga4au4k/timeline?details=ruowzi5zbkota&expanded=WyIwLjExNjkiXQ&show=Predecessors&task-path=forkingInteg
noDaemon uses a full distribution. You can see that here:
https://ge.gradle.org/s/l7ohrd6cwgoju/timeline?details=6fjfqdy5mxagi&expanded=WyIwLjEyNDciXQ&show=Predecessors&task-path=noDaemonInte
For the most part, if you were missing something important from the distribution, the test would fail. But the wrapper, help and build-init plugins are special in the way they're automatically applied to a build/project. We look for classes with a particular type and if they exist, we end up applying plugins. If they don't exist, we don't find them.
So up until the noDaemon tests ran, we were running with a partial distribution and that distribution did not include build-init or wrapper plugins, so they were not applied to the project in the test. That's why there are extra tasks when running with noDaemon.
It seems like there are a few tests that have adjusted expectations due to this. In this particular case, we don't really need to know that all the tasks are in the schema. I think checking for the tasks that are declared in the project plus a few well known tasks (e.g., help) are good enough.
This makes it one less place we have to touch whenever we rename/remove/add a task that applies to all projects.

@bot-gradle test this

OK, I've already triggered the following builds for you:

PullRequestFeedback build

@bot-gradle test rfr

OK, I've already triggered the following builds for you:

ReadyForRelease build

@bot-gradle test and merge

OK, I've already triggered a build for you.


implement Stochastic RSI #132

Fixes #132 .
Changes proposed in this pull request:

implement Stochastic RSI Indocator

Yep! Thank you boy. ;)


Blazor Workshop haunts edge browser - firefox is ok

I was able to get the blazor workshop running.
But now it won't get away in edge.
Steps to reproduce

create a directory - for example Bakery2022 (the name does not matter)
change into that directory and run dotnet new webapp and dotnet build and dotnet run
expected: a new webapp is shown (see screenshot of firefox)
actual: in edge i tries to load the blazor workshop, in firefox it works as expected

Could anyone help me please to ghostbust the blazor pizza workshop from my edge?
In other words what do i have to do or delete so that edge will show the current run webapp?

After the deletion of serveral cached objects (Cached images and files and others) under (see edge settings the problem went away.


add support for python 3.11

several existing dependencies do not work with 3.11

Surely this situation is a bit better these days? Could we even consider adding 3.12 support / unpinning this package?


feat: Add OGP to package page

If you merge this PR, you can show package thumbnail in SNS such as X and Discord.
Example thumbnail (@std/path):

This is great work overall, and I'm happy to see this. As far as design, however, I want to be sure we're very thorough.
Most importantly, I'd like to see tests across a wide range of packages. What happens when the package namespace and title are wider than the image, for example? Will the version number and "latest" badge wrap to a new line? If they do, will it push other content down? Are there any scenarios where text could overlap?
Same for the description; how does it flow when a package has very long text? Does it still look right when the package doesn't work with as many things, or has a different score or publish date?
Then, aesthetically, there are a few nitpicks I think we could tighten up before this is fully ready (see the below image to help illustrate):

The spacing around the edges of the image are inconsistent (left and bottom spacing are the same, top is a little bigger, and right is much bigger)
The package name, version, and "latest" badge don't quite line up visually. Ideally, I'd like to see the bottom baseline of the text align with the bottom of the pill shape of the badge.
That "latest" badge has a lot more padding on top than on bottom. Ideally, the text should be vertically centered inside it.
All the text on the left edge should align (either bring everything to the left to line up with the @, or move the package name to the right to line up with everything else)
Can we space the three stat columns (Published/JSR Score/Works with) a little more evenly? Right now there's a lot of unused space between the first and second columns
I think all three columns should be left-aligned. Right now, it looks like "Published" and "JSR Score" are center-aligned, and "Works-with" is right-aligned, and I think just making them all left-aligned would be better for consistency.
Should the "4 days ago" text be center-aligned with the score and logos, instead of having them all top-aligned? I could go either way on this one.

I don't know exactly how easy or difficult all of this is given that we're just rendering an image on the fly, but I think the more of these we can address, the better the final outcome will be. :)

@josh-collinsworth, thank you for your advice!
I worry about OGP design, so your advice is very helpful.
I'll improve it, following your advice.

@josh-collinsworth, I fixed some.
Could you tell me what do you think?:

Max name (scope: 20 chars, name: 32 chars)

@nakasyou That's looking much better.
Question: how can I see these generated images on the site? The social share preview seems to still be the default image when I'm attempting to see the preview locally.

@josh-collinsworth

Question: how can I see these generated images on the site? The social share preview seems to still be the default image when I'm attempting to see the preview locally.

OGP was in conflict with the default of app.tsx, so I fixed it.
Also, OGP URL has to be absolute URL. Should I add code that switching to jsr.test when Development mode?

Also, OGP URL has to be absolute URL. Should I add code that switching to jsr.test when Development mode?

Yes, that'd be great - if you grep for API_ROOT you can see how to wire through an env var that contains the domain being served. To inject the env var in production, you can add "FRONTEND_ROOT" = "https://${var.domain_name}" in frontend_envs in cloud_run_frontend.tf. If you need help with this, let me know and I can do it :)
You can then default the frontend root to http://jsr.test if no env var is passed (like we do for API_ROOT).

Hi @lucacasonato, thank you for advice.
OGP URL has been changed to the code that uses FRONTEND_ROOT.

To inject the env var in production, you can add "FRONTEND_ROOT" = "https://${var.domain_name}" in frontend_envs in cloud_run_frontend.tf. If you need help with this, let me know and I can do it :)

It's difficult for me to do it. And even if I could do it, I may destroy environment. So could you do it, please?

Sure!

One more change I'd like to see: it seems how descriptions are truncated a little too aggressively now. Even packages with very short descriptions are getting cut off.
Could we at least allow the description to wrap to two lines or so? Maybe even move the three columns down a little if we need to?

@josh-collinsworth, sorry for late.
Could you tell me what about you think?

@nakasyou This is looking really good! I have two remaining nitpicks, but I think only one is immediately important.
First, and more importantly: can we prevent text from wrapping mid-word in the description? This isn't great for legibility, and it could also cause some unwanted "words" to appear where they shouldn't. (e.g., A package to create a beautiful butt on) 🙈

And second, less importantly: when the package title wraps to a new line, is it possible to keep the version aligned?

I'm much less worried about the second item; I think that can be an edge case we clean up later. But the first is bound to affect quite a few packages, and potentially cause confusion or unwanted appearance.

Hi @josh-collinsworth, thank you for reviewing.
I resolved first problem, I'm working to resolve the second problem.

@josh-collinsworth, I fixed second problem, that was a bug.

@nakasyou Looks like CI is picking up some formatting issues. deno fmt should fix them.

@josh-collinsworth

Love this and appreciate the work you've put into it. I think this can and should be shipped. 👍

Thank you! I'm glad.

One minor note: it looks like there may be an issue with non-English glyphs. Still, I think we should ship this as-is and file that for future improvements.

I think it is font and line-breaking problem, i see.

deno fmt should fix them.

I run deno fmt. Please re-run workflow for it.

@nakasyou Sorry, looks like there's still one more CI issue:

@josh-collinsworth I'm sorry that I missed checking well, I fixed it.


Update Firebase SDK to Version 10.22.0, to support iOS privacy manifest

Firebase has update SDK to support iOS privacy manifest. Please refer to the following link for more information: https://github.com/firebase/firebase-ios-sdk/releases/tag/10.22.0.

Updated to the latest version
https://github.com/defold/extension-firebase/releases/tag/2.0.1
iOS privacy manifest part will be implemented with this issue https://github.com/defold/defold/issues/8378


RHOARDOC-1393: Fixed Thorntail artifactId in the docs

Partially resolves RHOARDOC-1393

[x] Have you followed the guidelines in our Contributing document?
[x] [v2] Have you created a JIRA and used it in the commit message?
[ ] [v4] Have you created a GitHub Issue and used it in the commit message?
[x] Have you checked to ensure there aren't other open Pull Requests for the same issue?
[x] Have you built the project locally prior to submission with mvn clean install?

Windows failures are (obviously) unrelated.


Unable to disable default features in Wasmtime dependencies

I am interested in building Wasmtime against a Cranelift with all architectures disabled except for the target architecture.
From my research, it seems that the way to accomplish this would be to re-export the desired architecture feature in Wasmtime's cargo.toml:
riscv = ["cranelift-codegen/riscv"]
(For reference, the feature belongs to cranelift-codegen, whose features can be found in its cargo.toml file.)
However, cranelift-codegen's default configuration enables all architectures to begin with, so in order to re-apply only the desired one, I would need to disable the default features in Cranelift and then enable only the desired one by re-exporting the feature, as outlined above.
The Rust-official method to accomplish this is to use the --no-default-features flag, as outlined here. However, as I discovered today, the Wasmtime repository is set up as a workspace (rather than a package), and the flag is non-functional on workspaces -- it only works on packages.
cranelift-codegen is not a workspace by itself, so I also tried using the inline default-features = false option (example of that here); however, that didn't seem to work either.
Given this seems to be an upstream issue, I was wondering if there would be any guidance around this at all.

One important thing to note as well here is that Cargo unions dependencies for crates, and by default all dependency edges enable the default feature. That means to disable a default feature then every single crate depending on another must disable the default feature. I think that may be why inline default-features = false didn't work perhaps?
FWIW this practically means that heavily depended on crates (those with a good number of incoming dependency edges) are very difficult to disable default features. If that's the case it may best to not actually enable any architectures by default in cranelift-codegen and instead allow top-level projects to specify. (and perhaps having a feature for all-architectures or something like that).
I think overall there's two possible solutions here:

Leave all architectures enabled by default, but all crates depending on cranelift-codegen (and transitively) need to disable default features and then reexport the feature necessary to enable each architecture.
Instead remove the default feature from cranelift-codegen and replace it with a non-default "enable everything" feature, and then require crates to enable at least one feature to enable a backend.

@alexcrichton There might be a third option. My intuition tells me that it is not a good one, but I can't put my finger on why. Maybe you could clarify this.
We could write a build.rs which detects whether or not any architecture features are manually defined. If some are defined, the build.rs would do nothing. If none are defined, it could manually enable default options.

Ah unfortunately I don't think that would be possible because build.rs would presumably be written in cranelift-codegen but doesn't have access to the Cargo.toml of all files depending on cranelift-codegen. A build.rs file knows that features are activated, but it doesn't know how features are activated.

Option 2 seems like the ideal way forward (from our point of view, at least); it would definitely simplify things for us. I think it also fits better with Rust's idea that "features should be additive".

@mbestavros
Does this mean Wasmtime is available for riscv-cross-compiling? THX

While Cranelift has basic risc-v support, it is nowhere near complete enough to be usable with Wasmtime.

This has been fixed by https://github.com/bytecodealliance/cranelift/pull/853, right?

I believe so; and the crate and feature structure has changed so much in the past five years anyway that any current problems can have new issues filed.


Upgrade to use typescript instead of javascript and use game-ci images

Changes
-Upgrade to using typescript instead of javascript and use game-ci images instead of gableroux images
Checklist

[x] Read the contribution guide and accept the code of conduct
[x] Readme (updated or not needed)
[x] Tests (added, updated or not needed)

LGTM


Poll app is no longer posting reactive cards in chat. Dev tools in chrome show error below

0.2-angular-jquery.min-92954a0.js:114 2022-05-10T16:44:58.939Z value not found in enum type. value:

our org is also noticing same issue, none of the Poll are sent on chat, this issue is also noticed on Survey and Checklist
we found that Microsoft is retiring "MS Forms" in chat and meeting and will introduce as "Polls" (with s), is this the reason these apps are affected?
https://www.microsoft.com/en-in/microsoft-365/roadmap?filters=&filters=&searchterms=84567

Thanks, it appears to have started working again? Did something change?


tf.data.experimental.snapshot segfault when using repeat and prefetch

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Centos 7
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: N/A
TensorFlow installed from (source or binary): 2.4.0
TensorFlow version (use command below): 2.4.0
Python version: 3.7.7
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: N/A
GPU model and memory:

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
Using the following simple script, we can see a segmentation fault:
import tensorflow as tf
import numpy as np
dataset = tf.data.Dataset.from_tensor_slices(np.random.rand(16, 1024))
dataset = dataset.apply(
    tf.data.experimental.snapshot('snapshot'))
dataset = dataset.shuffle(buffer_size=16)
dataset = dataset.batch(16)
dataset = dataset.repeat()
dataset = dataset.prefetch(1)
def run(dataset):
    iterator = iter(dataset)
    for _ in range(30):
        next(iterator)
for _ in range(10):
    run(dataset)

If we run it with Tensorflow 2.4.0 (or Tensorflow 2.4.1), the output is:
...
2021-05-04 11:04:17.989897: I tensorflow/compiler/mlir/mlir_graph_optimization_pass.cc:116] None of the MLIR optimization passes are enabled (registered 2)
2021-05-04 11:04:17.990504: I tensorflow/core/platform/profile_utils/cpu_utils.cc:112] CPU Frequency:<PHONE_NUMBER> Hz
Segmentation fault (core dumped)

If either of snapshot or repeat or prefetch is removed, this would not occur.
Describe the expected behavior
The expected behavior is that there would not be a segmentation fault
Contributing - Do you
want to contribute a PR? (yes/no): - yes
Briefly describe your candidate solution
(if contributing):
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
import tensorflow as tf
import numpy as np
dataset = tf.data.Dataset.from_tensor_slices(np.random.rand(16, 1024))
dataset = dataset.apply(
    tf.data.experimental.snapshot('snapshot'))
dataset = dataset.shuffle(buffer_size=16)
dataset = dataset.batch(16)
dataset = dataset.repeat()
dataset = dataset.prefetch(1)
def run(dataset):
    iterator = iter(dataset)
    for _ in range(30):
        next(iterator)
for _ in range(10):
    run(dataset)

Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
Analyzing the core dump, this is the truncated stack trace:
#0  0x00007fa2236c08af in tensorflow::data::experimental::SnapshotDatasetV2Op::Dataset::Iterator::Reader::~Reader() ()
   from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#1  0x00007fa2236c0971 in tensorflow::data::experimental::SnapshotDatasetV2Op::Dataset::Iterator::Reader::~Reader() ()
   from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#2  0x00007fa2236c04aa in tensorflow::data::experimental::SnapshotDatasetV2Op::Dataset::Iterator::~Iterator() ()
   from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#3  0x00007fa2222eefee in tensorflow::data::MapDatasetOp::Dataset::Iterator::~Iterator() ()
   from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#4  0x00007fa222335867 in tensorflow::data::ShuffleDatasetOpBase::ShuffleDatasetBase::Iterator::~Iterator() ()
   from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#5  0x00007fa2222c13a9 in tensorflow::data::BatchDatasetOp::Dataset::Iterator::~Iterator() ()
   from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#6  0x00007fa22232b529 in tensorflow::data::RepeatDatasetOp::Dataset::ForeverIterator::~ForeverIterator() ()
   from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#7  0x00007fa223e7e385 in tensorflow::data::PrefetchDatasetOp::Dataset::Iterator::~Iterator() ()
   from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#8  0x00007fa223771615 in tensorflow::data::experimental::(anonymous namespace)::MaxIntraOpParallelismDatasetOp::Dataset::Iterator::~Iterator() ()
   from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#9  0x00007fa2222fb665 in tensorflow::data::ModelDatasetOp::Dataset::Iterator::~Iterator() ()
   from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#10 0x00007fa223e441ab in std::_Sp_counted_ptr_inplace<tensorflow::data::IteratorResource::State, std::allocator<tensorflow::data::IteratorResource::State>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() ()
   from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#11 0x00007fa21d44b1f6 in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() ()
   from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#12 0x00007fa223e4dc62 in tensorflow::data::IteratorResource::~IteratorResource() () from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#13 0x00007fa223e4dd51 in tensorflow::data::IteratorResource::~IteratorResource() () from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#14 0x00007fa2199ac086 in tensorflow::ResourceMgr::ResourceAndName::~ResourceAndName() () from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/../libtensorflow_framework.so.2
#15 0x00007fa2199ae73f in tensorflow::ResourceMgr::DoDelete(std::string const&, unsigned long long, std::string const&, std::string const&) ()
   from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/../libtensorflow_framework.so.2
#16 0x00007fa2199aeb89 in tensorflow::ResourceMgr::Delete(tensorflow::ResourceHandle const&) ()
   from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/../libtensorflow_framework.so.2
#17 0x00007fa223e4f684 in tensorflow::data::DeleteIteratorOp::DoCompute(tensorflow::OpKernelContext*) ()
   from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#18 0x00007fa223e444b1 in tensorflow::data::HybridAsyncOpKernel::Compute(tensorflow::OpKernelContext*) ()
   from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#19 0x00007fa22396409b in tensorflow::KernelAndDeviceOp::Run(tensorflow::ScopedStepContainer*, tensorflow::EagerKernelArgs const&, std::vector<absl::lts_2020_02_25::variant<tensorflow::Tensor, tensorflow::TensorShape>, std::allocator<absl::lts_2020_02_25::variant<tensorflow::Tensor, tensorflow::TensorShape> > >*, tensorflow::CancellationManager*, absl::lts_2020_02_25::optional<tensorflow::EagerRemoteFunctionParams> const&) ()
   from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#20 0x00007fa22391f359 in tensorflow::EagerKernelExecute(tensorflow::EagerContext*, absl::lts_2020_02_25::InlinedVector<tensorflow::TensorHandle*, 4ul, std::allocator<tensorflow::TensorHandle*> > const&, absl::lts_2020_02_25::optional<tensorflow::EagerRemoteFunctionParams> const&, std::unique_ptr<tensorflow::KernelAndDevice, tensorflow::core::RefCountDeleter> const&, tensorflow::GraphCollector*, tensorflow::CancellationManager*, absl::lts_2020_02_25:
:Span<tensorflow::TensorHandle*>) () from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#21 0x00007fa2239202c0 in tensorflow::ExecuteNode::Run() () from /home/ashahab/dev/tensorflow-build_trunk/tmp/tf-venv/lib/python3.7/site-packages/tensorflow/python/_pywrap_tensorflow_internal.so
#22 0x00007fa22395d14f in tensorflow::EagerExecutor::SyncExecute(tensorflow::EagerNode*) ()

@ashahab
I was able to reproduce the issue in  TF v2.4.1, TF2.5rc1 and TF-nightly(2.6.0). Please find the gist here and let us know if it helps. Thanks!

@UsharaniPagadala I think this is a race condition. I don't know about the execution environment of the notebook and whether it allows true multi-threading.
Here are the steps I followed on a 12-core Azure nv12 box:
$pip install tensorflow=2.4.1
$python segfault.py
...
2021-05-05 04:57:51.915818: I tensorflow/compiler/jit/xla_gpu_device.cc:99] Not creating XLA devices, tf_xla_enable_xla_devices not set
2021-05-05 04:57:51.915930: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1261] Device interconnect StreamExecutor with strength 1 edge matrix:
2021-05-05 04:57:51.915948: I tensorflow/core/common_runtime/gpu/gpu_device.cc:1267]
2021-05-05 04:57:51.966764: I tensorflow/compiler/mlir/mlir_graph_optimization_pass.cc:116] None of the MLIR optimization passes are enabled (registered 2)
2021-05-05 04:57:51.967255: I tensorflow/core/platform/profile_utils/cpu_utils.cc:112] CPU Frequency:<PHONE_NUMBER> Hz
Segmentation fault (core dumped)

Let me know if you follow the above steps you don't see the segfault.

@jvishnuvardhan
I was able to run the code in tf2.4, tf2.5rc1 and tf-nightly .Please find the gist here.Thanks

Thanks for the link. I can also reproduce the issue.

@yangustc07  Were you able to see the segmentation fault?

Yes, I can see the segmentation fault and I'm working on a fix. Inputs are welcome if you have more information.

@yangustc07 Thanks for reproducing the issue.
Yes I have more inputs.
This is caused only when we combine these five: snapshot, shuffle, batch, repeat, and prefetch. I have been unsuccessful in removing any of these to narrow the problem.
I added some logging where snapshot Reader was getting an input reference: input_->Ref() and where it was returning the reference: input_->UnRef().
All threads except one will first execute input_->Ref() and then execute input_->UnRef() (I logged the thread ids). However, the last thread invokes input_->UnRef() without doing the prior input_->Ref(). It's trying to invoke input_->UnRef() on a null(0) input_.

Thanks for the input. I can fix the issue with this code:
SnapshotDatasetV2Op::Dataset::Iterator::Reader::~Reader() {
+ // input_->Unref();
}

  // We need to take a reference here as we will use the input_ and
  // its iterator.
+ // input_->Ref();

Status SnapshotDatasetV2Op::Dataset::Iterator::Reader::GetNextInternal(
    IteratorContext* ctx, std::vector<Tensor>* out_tensors,
    bool* end_of_sequence) {
  mutex_lock l(mu_);
+ if (!input_impl_) {
+   *end_of_sequence = true;
+   return Status::OK();
+ }
  return input_impl_->GetNext(ctx, out_tensors, end_of_sequence);
}

I still need to understand it better. Can you try it and see if it fixes your code?

Tried to debug more. The reason one thread does not call input_->Ref() is SnapshotDatasetV2Op::Dataset::Iterator::Reader::Initialize returns a cancelled error somewhere. In that case, the destructor shouldn't call input_->UnRef(), and there shouldn't be any calls to Reader::GetNextInternal().

Yang, your earlier solution of commenting out ref and unref does not seem
safe to me, and may result in memory leaks.
On Wed, May 5, 2021 at 6:28 PM Yang Chen @.***> wrote:

Tried to debug more. The reason one thread does not call input_->Ref() is
SnapshotDatasetV2Op::Dataset::Iterator::Reader::Initialize returns a
cancelled error somewhere. In that case, the destructor shouldn't call
input_->UnRef(), and there shouldn't be any calls to
Reader::GetNextInternal().
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/48903#issuecomment-833158741,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFISPOVBXPH7F5DAKPRRRDTMHWENANCNFSM44DJOMUA
.

Yes, I have updated the comment earlier. I have a better fix now.

Yeah I think the fix can handle the cancellation.
On Wed, May 5, 2021 at 7:59 PM Yang Chen @.***> wrote:

Yes, I have updated the comment earlier. I have a better fix now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensorflow/issues/48903#issuecomment-833188464,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAFISPKJQLJYY7EPEZCHVJDTMIA2LANCNFSM44DJOMUA
.

@yangustc07 do you have a fix?

Yes, I just submitted https://github.com/tensorflow/tensorflow/commit/858a5698a7b4ee95befa2e9c3d7aaa0a8170ec54. I'm trying to see why it changes my commit message to "internal change." The original description was:
[tf.data] Fix snapshot segfault when using repeat and prefetch.

Fixes: https://github.com/tensorflow/tensorflow/issues/48903.

`input_->MakeIterator` refs the dataset in
https://github.com/tensorflow/tensorflow/blob/a9cf3a0e4b419630f0183b0cc4e48e0641a62721/tensorflow/core/framework/dataset.cc#L679. So
we don't need to call `input_->Ref()`. Otherwise, if
`SnapshotDatasetV2Op::Dataset::Iterator::Reader::Initialize` returns an error,
`input_->Ref()` isn't called, but the destructor still calls `input_->Unref()`.

If `InitializeIterator` returns an error, the iterator_ needs to be reset to
nullptr. Otherwise, if GetNextInternal is called a second time,
`iterator_->GetNext` may dereference a null `input_impl_`.


Create documentation for the project

Given that more people are coming to the project we should start writing a bit more documentation and putting it all in one place.
I was think that maybe we could try to use GitHub Pages to write all the documentation and gather the useful link so that then I could ask Mr. RIP to crate a short link that could be easy to remember.

UPDATE: since yesterday https://rip-comm.github.io/sossoldi/ is working and we can use it as a landing page for our project 🎉
Moving forward there are certainly lots of things that we can improve, as discussed on Discord here are a few task pages that would be really useful:

[ ] Coding styles: for all the rules or best practices of our project
[ ] DB Structure
[ ] Setup + How to contribute and open a PR (this is partially implemented but we might want to improve it, for example we should make sure that we are all using the same version of Flutter)
[ ] Roadmap/Mission: we could add a page with what this project is about and why we are working on it
[ ] Reusable widget list: so that everyone knows what's already there and doesn't have to write everything from scratch
[ ] Folder Structure
[ ] How to contribute to the Documentation

As always if anyone would like to work on some of them you can comment here and then open a PR when you are ready.
If you don't know how GitHub Pages work don't worry it's pretty simple, you can just use .md files and link them as you would do normally, once those changes are merged in the main branch then the page will update automatically in a few seconds. To test the page inside your fork you need to activate them inside your fork (here is a guide) and then you will have your personalised link (ex. https://theperu.github.io/sossoldi/)


[RFC][WIP][DO NOT MERGE!] rootless networking

not ready to be used, this is to start a discussion around an usermode network configuration.
It is based on this tool: https://github.com/giuseppe/slirp-forwarder
It internally uses libslirp, we might want to use the version from qemu, but that requires more work.
Also I discovered there is already another attempt at creating a slirp tool for rootless networks: https://github.com/AkihiroSuda/slirp4netns and we can probably collaborate together for it.
this is how a container looks like, there is nothing requiring root privileges or suid applications to configure the network:
``console
$ bin/podman run --rm -ti alpine ifconfig -a
lo        Link encap:Local Loopback
LOOPBACK  MTU:65536  Metric:1
RX packets:0 errors:0 dropped:0 overruns:0 frame:0
TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
collisions:0 txqueuelen:1000
RX bytes:0 (0.0 B)  TX bytes:0 (0.0 B)
tap0      Link encap:Ethernet  HWaddr 36:FF:87:4E:54:26
inet6 addr: fe80::34ff:87ff:fe4e:5426/64 Scope:Link
UP BROADCAST RUNNING  MTU:1500  Metric:1
RX packets:2 errors:0 dropped:0 overruns:0 frame:0
TX packets:6 errors:0 dropped:0 overruns:0 carrier:0
collisions:0 txqueuelen:1000
RX bytes:1180 (1.1 KiB)  TX bytes:992 (992.0 B)
$ pkill dhclient; pkill slirp-forwarder; rm /tmp/net # delete any leftover

Commit 1 looks fine. Commit 2 is probably better off happening entirely in cmd/podman and directly changing the spec we pass into libpod.

I'm closing this PR in favor of https://github.com/projectatomic/libpod/pull/1145
The other experimental change will be added later and it'll probably use https://github.com/AkihiroSuda/slirp4netns


[Planting Flow] If you back out of login you can plant without an account

I found a bug, maybe major, where you can plant a tree without an account.
How I found it was by accident. I was mapping out the "planting" flow, and how it works. I clicked on planting and when i got redirected, I pressed the back button to go back to the map. Once I was back on the map, the planting feature was present, and was able to move the tree pin, and input information.

@zoobot found a major bug in the planting flow.

@zoobot found a major bug in the planting flow.

Do tell! Can you make an issue for it?

added it to the description. but you cannot complete the task of planting. Once you input information, and press "Plant new tree" it disappears off the screen.

screen-capture.webm

@zoobot the bug is obvious from the times I tried it. So the issue arises from the planting pin appearing before you login. If you back out after a certain period of time, the pin disappears. So its only if you are fast I believe since one time it didn't work when i tried it.


But in my current application I'm receiving 4 imagesfrom the backend at one time. Because this is not that easy I decided to send those images as base64 images in a json object. I'm not able to store the base64 data as image in the frontend (because browsers don't allow me to do that) so I need to find a direct way to convert base64 image to svg.
Is there any possibility to do this?
Greetings,
Thomas

Hi,
I'm happy to hear that you find imagetracerjs useful. :)
Please clarify what you mean by "I'm not able to store the base64 data as image in the frontend (because browsers don't allow me to do that)" ? If the client browser supports Data URIs and Canvas then you can probably do something like this:
// Let's say you got the JSON object with the 4 Base64 strings from the server, which looks something like this:
// jsonobj = [ 'abcBlabla...' , 'bcdBlabla...' , 'cdeBlabla...' , 'defBlabla...' ];

// Tracing the first Base64 encoded image from jsonobj
ImageTracer.imageToSVG(

	'data:image/jpeg;base64,'+jsonobj[0], // Image source: Data URI with Base64; you might need 'data:image/png;base64,'  instead

	function(svgstr){ ImageTracer.appendSVGString( svgstr, 'svgcontainer' ); }, // What to do with the result SVG string: append to a container <div>

	'Posterized2' // How to trace: 'Posterized2' option preset
);

If you can't do this, then you get (JPEG or PNG or similar) bytestreams when you Base64 decode the JSON strings. So you need some JavaScript library that can decompress these into ImageData (which is basically raw RGBA pixel data as a byte array + width and height). Then you can trace the ImageData object.
You might consider tracing the images on the backend (this is possible if you can use Node.js or Java on the server) and sending the SVG strings in the JSON object (no Base64 encoding needed).
Best wishes,
András

Please reopen this issue if this doesn't work.

Thank you for your clarifications. If I can check your example if it works for me, I'll will write you. In the beginning I thought your framework is not able to parse a base64 string and only reads from files. And I couldn't fing anything by googling about how to store multiple images as files without the user noticing it which I think shouldn't be possible so I won't have image files but only those base64 images.
Thanks for the idea of converting on the backend side. I'll test this, too.


Radio buttons

The 'Radio button example' doesn't allow saving of a new selection in the demo but will reflect the value from 'Category' field in the table if the page is reloaded.

Yes, it does. What it does not do, is refreshing the page to synchronise the value with "Category" as it is the same field, but presented differently. It is the same if you change the value of the "Category" the "Radio button example" is not updated, until you refresh the page. Could you give it a try again ?

Works as you rightly said. I have tested successfully in Firefox and in Chrome incognito, my regular Chrome must require a restart as it's still failing there. Thanks for checking!

Thanks for testing


feat: negative/positive look-ahead/behind, non-consuming surrounding context parsers, negation parsers

There are multiple things described in this issue, but I think it's better to keep them close.
I'm doing some free text parsing migrating from the regular expressions based solution. I faced an issue that I couldn't fully specify the surrounding context. when is the only parser that could work with context but documentation doesn't say anything whether it consumes input or not (I assume it does which raises a question how it is different from sequence). Also when allows to specify preceding context only and I'm not sure what should I use to specify the context after the target parser.
It would be nice to have non-consuming parser (context) and negation parser (not) so it would be possible to specify surrounding context e.g.
// context(before, target, optional after)

const helloWorld = string('hello world');
const strictHelloWorld = context(
    not(letter()),
    helloWorld,
    not(whole())
);

const parser1 = sequence(any(), strictHelloWorld, any());
const parser2 = sequence(any(), helloWorld, any());

run(parser1).with('1hello worldA'); // result.isOk = true, value = ['1', 'hello world', 'A'];
run(parser1).with('Ahello world1'); // result.isOk = false

run(parser2).with('1hello worldA'); // result.isOk = true, value = ['1', 'hello world', 'A'];
run(parser2).with('Ahello world1'); // result.isOk = true, value = ['A', 'hello world', '1'];

Also it would be nice to have some default non-consuming parsers such as wordBoundary. What is more this will require polyfilling JS \b since it's not unicode friendly.
More examples can be found in the codesandbox.

Hey, thanks for the feedback and suggestions! I've already started working on lookahead/backtracking combinators and playing around with non-consuming parsers in general, so your use cases and thoughts will be a great help for sure.
I have to take care of some personal stuff though, so I'll get back to this and other issues on weekends-holidays.

Thank you for your work, I really appreciate it!
I've just realized that I forgot to save changes in the codesandbox and provided you with incorrect samples. Now it should work: codesandbox.

I took a glance at your examples and can tell you right away what the problem is: the missing g flag in regular expressions. This "caveat" is mentioned in the docs, as well as the other one.
Under the hood regexp parser uses RegExp.exec (for speed) and resets lastIndex to parsing position, so yeah, use the g flag.
As for the word boundaries... Well, it's sad it doesn't work, but I believe this should be handled on the library consumer's side, as this seems as rather specific issue with regular expressions in JS. Besides, nothing stops you from either wrapping regexp parser and providing it with a fixed regular expression, or even writing a custom parser (this actually should be documented, hopefully I'll be able to spare some time for that).
Ultimately, I would like to keep the core of the library as small as possible.

As for the other stuff in the issue, I'll reply later and link a PR.

Oh, adding g flag actually resolved the issue. I was thinking all this time that I must not use g flag, seems like I missread it.
What concerns word boundaries it was my desire to completely migrate from regexps and I'm just fine to implement it myself! I do not expect that this library will cover all the features of regular expressions. And if there will be such a need I guess it should be done through an extension package e.g. sigma/extra or something like that.

Returning to the first part of the issue...

I believe the context combinator you suggested will be essentially attempt(takeMid(before, target, after)) or lookahead(takeMid(before, target, after)). Both will be rip-offs of try and lookAhead from Parsec respectively.

The not combinator is kinda tricky, not only because it can't be typed correctly without ugly casts, but also because I have no clear understanding on how to properly integrate it into the existing wiring. I'll leave it for now, will be added as a separate issue to backlog.

The when combinator was originally conceived to allow creating parsers dynamically, not statically (like sequence). See the example below.
when(context, parser)

It is consuming if context is consuming and it will call parser callback only if context succeeds. Why? Because allowing to produce something on failure would be virtually a way for performing recovery, which I want to be a separate combinator's responsibility. Also I kinda regret of not giving it a better name, like chain, but I already had chainl at the moment which provides completely orthogonal functionality, so it would be confusing.
Also I have to admit that the example in the docs is hilariously bad, will be fixed. A more elaborate example would look like this:
const Parser = when(takeLeft(letters(), whitespace()), ({ value }) => {
  switch (value) {
    case 'integer': return integer()
    case 'string': return letters()
    case 'bracketed': return takeMid(string('('), letters(), string(')'))
    // TODO: Add `success` and `failure` helpers.
    default: return failure('Expected integer, string or bracketed string.')
  }
})

console.log(run(Parser).with('integer 42'))

// {
//   isOk: true,
//   pos: 10,
//   value: 42
// }

console.log(run(Parser).with('string Something'))

// {
//   isOk: true,
//   pos: 16,
//   value: 'Something'
// }

console.log(run(Parser).with('bracketed (Something)'))

// {
//   isOk: true,
//   pos: 21,
//   value: 'Something'
// }

console.log(run(Parser).with('unknown input'))

// {
//   isOk: false,
//   pos: 8,
//   expected: 'Expected integer, string or bracketed string.'
// }

The not combinator is kinda tricky, not only because it can't be typed correctly without ugly casts, but also because I have no clear understanding on how to properly integrate it into the existing wiring. I'll leave it for now along with context, will be added as separate issues to backlog.

The idea must be silly but what if we restrict the use of not parser only for work with contexts (lookahead/behind) and make it return boolean? So its only responsibility would be to answer the question whether the input was matched or not which is the only thing that lookahead/behind requires in regexp world.
I know that it conflicts with the overall API design but maybe it's not needed to make it work the way other parsers do. It may be just fine to make it work as a support function for lookahead/behind functionality only.

Hm-m, that could work, thanks for the idea! I'll have to add names or some other identification means for parsers and combinators, but I'll need to add it anyway for future tracing/debugging features.


Fix RMB erasing of tiles

Fixes https://github.com/godotengine/godot/pull/93747#issuecomment-2201788521

Thanks!


How to change path in terminal

@ivankravets
I want to change the path in terminal my default path is i am usin windows 8.1

c:\users(username)\desktop

i want to change it to

c:\users(username)\AppData\Local\atom\bin

cd ..
to go up a directory
cd Appdata\Local\atom\bin
to go down to the desired directory
it's easy to remember if you know cd stands for change directory.

@RomanADavis I do not want to use cd command when ever i open the terminal the default path should be
_

c:\users(username)\AppData\Local\atom\bin

_

I'm pretty sure that the terminal is setup to run in the project directory. It would be cool if we could change the default behavior, though.


Handle 'previous build was cancelled' appropriately

Currently, if the previous build was cancelled, this action fails. See e.g.: https://github.com/gap-system/gap/runs/2768861576?check_suite_focus=true
I will add a quick fix for this (the easiest fix will mean that a build after a cancellation will always notify; probably not we want long term).
Longer term, we should decide on the most appropriate behaviour. I think this is probably choosing the 'last status' to be the most-recent non-cancelled build.

My temporary fix is in 8aa058826ca437c38db4da71fdc11147fa5fd0c7


Fixes for Freshness Pass: 79612

Purpose

Code fixes by Jingjing Li related to freshness pass here: https://github.com/MicrosoftDocs/azure-docs-pr/pull/235110

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type
What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

It does not. The step to upload the code into the portal remains the same.

@dpwatrous Hopefully you have perms here and can review. This code update is part of that whole batch freshness endeavor from last month.


Rename i2s_get_period to i2c_get_period.

The i2s_get_period() function name is probably a typo and should be called i2c_get_period().

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Merged in https://github.com/espressif/esp-idf/commit/d8fb30c930ba10ed7054d5f8669a230d95053245, thanks!


Rewrite gesture support

So this is never fun, but ultimately Hammer got us more trouble than it solved.

Hard to manage events attached to dom without hacks.
Hard to understand gesture dependencies.
Did not play nice with other events, leading to hard to solve bugs (for example with draggable).

I rewrote a simple version of hammer with most events we need.

Sorry to hear that! :( I remember thinking some time ago about how Hammer would introduce a huge dependency to Framer, but i guess I got excited when I saw all the examples that I was testing were working. So the good news are that this dependency is not there any more.

Can I help wrap this up? Testing, debugging...

Yep, same here. I initially thought it was better to build on it too. But sometimes the accumulation of issues leads you here :-)
I'd love you to do a sanity check on this PR when I finish it and test it a bit.

Sure! ping me when it's ready

We'll start the merge so we can ship betas

PING @jchavarri

Man, this release is going to be huge! it's very clear when you see the code that it's been an intense sprint. Reimplementing Hammer in less than 2 days, :white_check_mark: !  :clap: :clap:
Things I like as a user:

Edge events (I could use it for that "framered" UINavigationController I had around)
Force touch
The gesture events have an API under "Framer control", which means it can be documented and used more by users
layer.pinchable!

One last thing, on the Beta, the main cursor and the secondary one for pinching have a different size. I guess you are aware, but just in case...

Hey that is odd I'll look into this!


Experimental: Dynamic Block Rate API

yay

closed in favor of https://github.com/KlimaDAO/klimadao/pull/224


Remark is inaccurate

For the record, on Android at least, unfocusing the control does NOT call the Completed event. It looks like it's only called when pressing the "Done" button on the keyboard.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b3caddb8-c64a-35a7-bc31-f2b2533c4788
Version Independent ID: 968674b4-7c3f-11e9-ca7a-6c30f02a4dc9
Content: Editor.Completed Event (Xamarin.Forms)
Content Source: docs/Xamarin.Forms/Editor.xml
Product: xamarin
Technology: xamarin-forms
GitHub Login: @dotnet-bot
Microsoft Alias: dotnetcontent

Microsoft support for Xamarin will end on May 1, 2024 for all Xamarin SDKs including Xamarin.Forms. In preparation for this, all issues and PRs in this repository are being closed.
.NET MAUI is the replacement for Xamarin.Forms, and its API docs are built from /// in the dotnet/maui repository. Therefore, any issues with the .NET MAUI API docs should be opened in that repository.


String weight calculation

Hey, firstly I just wanted to say that your tension calc is awesome, especially the multi-scale support (I'm getting my hands on some multi-scale Ormsby Goliaths soon 😎).
I was helping my friend @jortronq learn about some front-end JavaScript tech, and were writing our own string tension calculator as a learning exercise. We referred to this repo quite a bit as an example of how to do certain things.
One thing we couldn't figure out is how you arrived at your calculation for string density / unit weight. I notice in this commit you switched from hard-coded weight values, to deriving weight from gauge and a plain/wrapped flag.
I was wondering what these coefficients are, and how you arrived at them:
let coefs = (gauge[gauge.length - 1] == 'P') ?
    [ -.000176520934, .0840206843, -16.01839853, 1656.456428,
        -96731.24564, 3248319.241, -58293798.41, 432468921.1 ] :
    [ -.002123403683, .4863557681, -46.19498733, 2403.599196,
        -74026.84724, 1389623.565, -15576312.23, 95696503.28, -247760614.2 ];

Cheers!

Hi,
Thanks for your interest. I consider the architecture of this little app very good, it's a good showcase of modular ES6. Oh and those headless Ormsby Goliath are awesome indeed.
Anyway, these values are the coefficients to high-degree polynomial functions. I found them empirically after performing a polynomial regression on the curves from the points, considering string density and unity weight relationship. They're not absolutely correct, but they got pretty close on my math modeling simulation. I don't remember the exact calc details, but I remember it was just this.
Cheers.

Ah okay, I thought it might have been something like that. So if I understand, you took the existing weights, gauges, and string types as data points, and using a tool of some kind you were able to find a curve that closely approximated a fit for those data points?

Pretty much that. The "tool" in question is the polynomial regression.

Cool, that makes sense to me. Thanks for the clarification!


Update cluster ssh to not deactivate for non docker clusters

#1499  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Symbol not found: _clock_gettime  on attempt to ls bucket contents after successful mount

I encountered this error on ls /mnt/bucket:
dyld: lazy symbol binding failed: Symbol not found: _clock_gettime
  Referenced from: /usr/local/bin/s3fs
  Expected in: /usr/lib/libSystem.B.dylib

dyld: Symbol not found: _clock_gettime
  Referenced from: /usr/local/bin/s3fs
  Expected in: /usr/lib/libSystem.B.dylib

using the homebrew built version.
See details here https://github.com/s3fs-fuse/s3fs-fuse/issues/468
I compiled manually from source using
./autogen.sh
./configure --with-gnutls
make

and the version built in that manner works correctly. Seems like there's something specific about the homebrew environment that is problematic or homebrew script.
My brew doctor is clean.

Please try rebuilding it.
brew uninstall s3fs
brew instal -dvs s3fs

Result is the same.
 GNU
checking dependency style of clang++... none
checking for gcc... clang
checking whether we are using the GNU C compiler... yes
checking whether clang accepts -g... yes
checking for clang option to accept ISO C89... none needed
checking whether clang understands -c and -o together... yes
checking dependency style of clang... none
checking s3fs build with nettle(GnuTLS)... no
checking s3fs build with OpenSSL... no
checking s3fs build with GnuTLS... yes
checking s3fs build with NSS... no
checking for pkg-config... /usr/local/opt/pkg-config/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for common_lib_checking... yes
checking compile s3fs with... GnuTLS-gcrypt
checking for gcry_control in -lgnutls... no
checking for gcry_control in -lgcrypt... yes
checking for DEPS... yes
checking gnutls is build with... gcrypt
checking for malloc_trim... no
checking for library containing clock_gettime... (cached) no
checking for clock_gettime... (cached) no
checking pthread mutex recursive... PTHREAD_MUTEX_RECURSIVE
checking for git... yes
checking for .git... no
checking github short commit hash... unknown
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating src/Makefile
config.status: creating test/Makefile
config.status: creating doc/Makefile
config.status: creating config.h
config.status: executing depfiles commands
==> make install
Making install in src
clang++ -DHAVE_CONFIG_H -I. -I..  -D_FILE_OFFSET_BITS=64 -D_DARWIN_USE_64_BIT_INODE -I/usr/local/Cellar/libtasn1/4.9/include -I/usr/local/Cellar/nettle/3.3/include -I/usr/local/Cellar/gnutls/3.4.16/include -I/usr/local/include/osxfuse/fuse -I/usr/include/libxml2    -g -O2 -Wall -D_FILE_OFFSET_BITS=64 -c -o s3fs.o s3fs.cpp
clang++ -DHAVE_CONFIG_H -I. -I..  -D_FILE_OFFSET_BITS=64 -D_DARWIN_USE_64_BIT_INODE -I/usr/local/Cellar/libtasn1/4.9/include -I/usr/local/Cellar/nettle/3.3/include -I/usr/local/Cellar/gnutls/3.4.16/include -I/usr/local/include/osxfuse/fuse -I/usr/include/libxml2    -g -O2 -Wall -D_FILE_OFFSET_BITS=64 -c -o curl.o curl.cpp
clang++ -DHAVE_CONFIG_H -I. -I..  -D_FILE_OFFSET_BITS=64 -D_DARWIN_USE_64_BIT_INODE -I/usr/local/Cellar/libtasn1/4.9/include -I/usr/local/Cellar/nettle/3.3/include -I/usr/local/Cellar/gnutls/3.4.16/include -I/usr/local/include/osxfuse/fuse -I/usr/include/libxml2    -g -O2 -Wall -D_FILE_OFFSET_BITS=64 -c -o cache.o cache.cpp
clang++ -DHAVE_CONFIG_H -I. -I..  -D_FILE_OFFSET_BITS=64 -D_DARWIN_USE_64_BIT_INODE -I/usr/local/Cellar/libtasn1/4.9/include -I/usr/local/Cellar/nettle/3.3/include -I/usr/local/Cellar/gnutls/3.4.16/include -I/usr/local/include/osxfuse/fuse -I/usr/include/libxml2    -g -O2 -Wall -D_FILE_OFFSET_BITS=64 -c -o string_util.o string_util.cpp
clang++ -DHAVE_CONFIG_H -I. -I..  -D_FILE_OFFSET_BITS=64 -D_DARWIN_USE_64_BIT_INODE -I/usr/local/Cellar/libtasn1/4.9/include -I/usr/local/Cellar/nettle/3.3/include -I/usr/local/Cellar/gnutls/3.4.16/include -I/usr/local/include/osxfuse/fuse -I/usr/include/libxml2    -g -O2 -Wall -D_FILE_OFFSET_BITS=64 -c -o s3fs_util.o s3fs_util.cpp
clang++ -DHAVE_CONFIG_H -I. -I..  -D_FILE_OFFSET_BITS=64 -D_DARWIN_USE_64_BIT_INODE -I/usr/local/Cellar/libtasn1/4.9/include -I/usr/local/Cellar/nettle/3.3/include -I/usr/local/Cellar/gnutls/3.4.16/include -I/usr/local/include/osxfuse/fuse -I/usr/include/libxml2    -g -O2 -Wall -D_FILE_OFFSET_BITS=64 -c -o fdcache.o fdcache.cpp
clang++ -DHAVE_CONFIG_H -I. -I..  -D_FILE_OFFSET_BITS=64 -D_DARWIN_USE_64_BIT_INODE -I/usr/local/Cellar/libtasn1/4.9/include -I/usr/local/Cellar/nettle/3.3/include -I/usr/local/Cellar/gnutls/3.4.16/include -I/usr/local/include/osxfuse/fuse -I/usr/include/libxml2    -g -O2 -Wall -D_FILE_OFFSET_BITS=64 -c -o common_auth.o common_auth.cpp
clang++ -DHAVE_CONFIG_H -I. -I..  -D_FILE_OFFSET_BITS=64 -D_DARWIN_USE_64_BIT_INODE -I/usr/local/Cellar/libtasn1/4.9/include -I/usr/local/Cellar/nettle/3.3/include -I/usr/local/Cellar/gnutls/3.4.16/include -I/usr/local/include/osxfuse/fuse -I/usr/include/libxml2    -g -O2 -Wall -D_FILE_OFFSET_BITS=64 -c -o addhead.o addhead.cpp
clang++ -DHAVE_CONFIG_H -I. -I..  -D_FILE_OFFSET_BITS=64 -D_DARWIN_USE_64_BIT_INODE -I/usr/local/Cellar/libtasn1/4.9/include -I/usr/local/Cellar/nettle/3.3/include -I/usr/local/Cellar/gnutls/3.4.16/include -I/usr/local/include/osxfuse/fuse -I/usr/include/libxml2    -g -O2 -Wall -D_FILE_OFFSET_BITS=64 -c -o gnutls_auth.o gnutls_auth.cpp
clang++ -DHAVE_CONFIG_H -I. -I..  -D_FILE_OFFSET_BITS=64 -D_DARWIN_USE_64_BIT_INODE -I/usr/local/Cellar/libtasn1/4.9/include -I/usr/local/Cellar/nettle/3.3/include -I/usr/local/Cellar/gnutls/3.4.16/include -I/usr/local/include/osxfuse/fuse -I/usr/include/libxml2    -g -O2 -Wall -D_FILE_OFFSET_BITS=64 -c -o test_string_util.o test_string_util.cpp
clang++  -g -O2 -Wall -D_FILE_OFFSET_BITS=64   -o s3fs s3fs.o curl.o cache.o string_util.o s3fs_util.o fdcache.o common_auth.o addhead.o  gnutls_auth.o  -L/usr/local/Cellar/gnutls/3.4.16/lib -L/usr/local/lib -losxfuse -lcurl -lxml2 -lgnutls -lgnutls -lgcrypt
clang++  -g -O2 -Wall -D_FILE_OFFSET_BITS=64   -o test_string_util string_util.o test_string_util.o  -lgnutls -lgcrypt
make[2]: Nothing to be done for `install-data-am'.
 .././install-sh -c -d '/usr/local/Cellar/s3fs/1.80/bin'
  /usr/bin/install -c s3fs '/usr/local/Cellar/s3fs/1.80/bin'
Making install in test
make[2]: Nothing to be done for `install-exec-am'.
make[2]: Nothing to be done for `install-data-am'.
Making install in doc
make[2]: Nothing to be done for `install-exec-am'.
 .././install-sh -c -d '/usr/local/Cellar/s3fs/1.80/share/man/man1'
 /usr/bin/install -c -m 644 man/s3fs.1 '/usr/local/Cellar/s3fs/1.80/share/man/man1'
make[2]: Nothing to be done for `install-exec-am'.
make[2]: Nothing to be done for `install-data-am'.
==> Cleaning
Fixing /usr/local/Cellar/s3fs/1.80/bin/s3fs permissions from 755 to 555
==> Finishing up
ln -s ../Cellar/s3fs/1.80/bin/s3fs s3fs
ln -s ../../../Cellar/s3fs/1.80/share/man/man1/s3fs.1 s3fs.1

Please try this diff
diff --git a/Formula/s3fs.rb b/Formula/s3fs.rb
index ad748cd..346576d 100644
--- a/Formula/s3fs.rb
+++ b/Formula/s3fs.rb
@@ -16,6 +16,8 @@ class S3fs < Formula
   depends_on :osxfuse

   def install
+    inreplace "src/cache.cpp", "clock_gettime", "s3fs_clock_gettime"
+
     system "./autogen.sh"
     system "./configure", "--disable-dependency-tracking", "--with-gnutls", "--prefix=#{prefix}"
     system "make", "install"

@jbarlow83 did that work?

That fixes it, thanks.

I just ran into this very same problem.  Any ETA on fixing it permanently?

This is an upstream bug. The sooner it gets reported upstream, the sooner it will be fixed.

Already was reported upstream.
https://github.com/s3fs-fuse/s3fs-fuse/issues/468

@AlexThurston then I guess you'll have to ask upstream there.

This formula was imported into homebrew/core. If it's still a problem: please rereport it there. Thanks!


CPU support

swapped out CUDA params for CPU support

Hi @esteininger, I am new to this repo, so maybe this is a naive question, does it work with CPU? I mean, with this patch, is it able to generate a response in a reasonable time? And does it work for both training and inferencing?
BTW, I don't think the owner of this repo would accept this kind of functionality change. If it works with CPU, maybe making the behaviour controlled by an optional parameter specified somewhere (command line, or environment variable, or configuraiton file) is a better approach. Just my two cents.


Remove refresh button confusion

The icons for list refresh and recent activity both contain a refresh style circular arrow that can be confusing
There's an additional circular arrow like icon (backup/restore) on the endpoint page
These should be updated so it's clear which is refresh

Closed via #4352, less confusion with refresh & recent. Backup/restore now looks alright against recent


Adding Mapua Malayan Colleges Mindanao

Please include Mapua Malayan Colleges Mindanao as a valid school institution

nltu.txt

@princeoncada First stage of verification passed, official domain is mcm.edu.ph as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@princeoncada Pull request merged. Thank you.


Autocomplete results on profile page centre aligned, but should be in grid layout or similar

@TanSA05 I think you wrote the original implementation? Or was it @TheChirpyWitch? Want to tackle this? It should be fairly straight forward :). Looks like float gets used in the CSS?
@CloCkWeRX Thanks so much for opening all of these issues and all the PRs you did! This is an awesome thing to wake up to.


migrate to pytest

Coverage decreased (-9.1%) to 84.966% when pulling 8ff837c146c21877f8b1bcd20ae86d184f96db6c on phobson:pytest into a3ae0cd5db0fcdf96974603bebf64e5b23fcbe1e on Geosyntec:master.

Coverage decreased (-9.1%) to 84.966% when pulling c0b6e36ea5ff69421a16670c4b6dac2de7b2d6e5 on phobson:pytest into a3ae0cd5db0fcdf96974603bebf64e5b23fcbe1e on Geosyntec:master.

Coverage decreased (-9.1%) to 84.966% when pulling 7e87ba04d1ea1287516c34f7c175b29592e6addb on phobson:pytest into a3ae0cd5db0fcdf96974603bebf64e5b23fcbe1e on Geosyntec:master.

Coverage decreased (-9.1%) to 84.966% when pulling 7170fa9aa35dee88a678db0a5905bf6c60a4caf8 on phobson:pytest into a3ae0cd5db0fcdf96974603bebf64e5b23fcbe1e on Geosyntec:master.

Coverage decreased (-9.1%) to 84.966% when pulling 7caaa7abb923329ac0c2b7bf171d6246c0fe9264 on phobson:pytest into a3ae0cd5db0fcdf96974603bebf64e5b23fcbe1e on Geosyntec:master.

Coverage decreased (-9.0007%) to 85.078% when pulling 4b1eeba07530acd5251a094d7e3f93c4459cb112 on phobson:pytest into a3ae0cd5db0fcdf96974603bebf64e5b23fcbe1e on Geosyntec:master.


Added support for tags in ssh_config in the form of '@tag1 @tag2'.

In order to better manage large numbers of hosts in ssh_config it would be beneficial be able to tag them with project names etc. Now in the 'Host' section of ssh_config one can add a line that starts with a "#" followed (without a spacebar) by a list of tags eg. #@tag1 @tag2.

The storm list command now displays apart from [custom_options] also a [tags] section if flag '-t' is supplied.
New storm list-tag <tag> command was added,  that displays only Hosts tagged with specific tag, or all tags if no tag is supplied

The test of 'storm list' command was modified to cover this new functionality.
I did not touch the web interface since I do not use. Those changes do not interfere with it nor change the behaviour of the storm list (or any other command) if ssh_config does not contain lines in a form of<EMAIL_ADDRESS>An example ssh/config like that:
    ### default for all ##
    Host *
         ForwardAgent no
         ForwardX11 no
         ForwardX11Trusted yes
         User nixcraft
         Port 22
         Protocol 2
         ServerAliveInterval 60
         ServerAliveCountMax 30
         LocalForward 3128 <IP_ADDRESS>:3128
         LocalForward 3129 <IP_ADDRESS>:3128

    ## override as per host ##
    Host server1
         #@private
         HostName server1.cyberciti.biz
         User nixcraft
         Port 4242
         IdentityFile /nfs/shared/users/nixcraft/keys/server1/id_rsa
         IdentityFile /tmp/x.rsa

    ## Home nas server ##
    Host nas01
         #@private
         HostName <IP_ADDRESS>
         User root
         IdentityFile ~/.ssh/nas01.key

    ## Login AWS Cloud ##
    Host aws.apache
         #@projectx
         HostName <IP_ADDRESS>
         User wwwdata
         IdentityFile ~/.ssh/aws.apache.key

    ## Login to internal lan server at <IP_ADDRESS> via our public uk office ssh based gateway using ##
    ## $ ssh uk.gw.lan ##
    Host uk.gw.lan uk.lan
         #@projectx @uk @gw
         HostName <IP_ADDRESS>
         User nixcraft
         ProxyCommand  ssh<EMAIL_ADDRESS>nc %h %p 2> /dev/null

    ## Our Us Proxy Server ##
    ## Forward all local port 3128 traffic to port 3128 on the remote vps1.cyberciti.biz server ##
    ## $ ssh -f -N  proxyus ##
    Host proxyus
        #@projectx
        HostName vps1.cyberciti.biz
        User breakfree
        IdentityFile ~/.ssh/vps1.cyberciti.biz.key
        LocalForward 3128 <IP_ADDRESS>:3128

Produces such output for the storm list -t command:
 Listing entries:

   (*) General options:
	  forwardx11: no
	  localforward: 3128 <IP_ADDRESS>:3128, 3129 <IP_ADDRESS>:3128
	  protocol: 2
	  user: nixcraft
	  forwardagent: no
	  forwardx11trusted: yes
	  serveralivecountmax: 30
	  serveraliveinterval: 60
	  port: 22
    aws.apache -> wwwdata@<IP_ADDRESS>:22
	[custom options] identityfile=~/.ssh/aws.apache.key
	[tags] @projectx

    nas01 -> root@<IP_ADDRESS>:22
	[custom options] identityfile=~/.ssh/nas01.key
	[tags] @private

    proxyus -> breakfree@vps1.cyberciti.biz:22
	[custom options] identityfile=~/.ssh/vps1.cyberciti.biz.key localforward=3128 <IP_ADDRESS>:3128
	[tags] @projectx

    server1 -> nixcraft@server1.cyberciti.biz:4242
	[custom options] identityfile=/nfs/shared/users/nixcraft/keys/server1/id_rsa,/tmp/x.rsa
	[tags] @private

    uk.gw.lan uk.lan -> nixcraft@<IP_ADDRESS>:22
	[custom options] proxycommand=ssh<EMAIL_ADDRESS>nc %h %p 2> /dev/null
	[tags] @projectx, @uk, @gw

The storm list-tag projectx gw command returns:
 Listing entries for tag @projectx

    aws.apache -> wwwdata@<IP_ADDRESS>:22
	[custom options] identityfile=~/.ssh/aws.apache.key

    uk.gw.lan uk.lan -> nixcraft@<IP_ADDRESS>:22
	[custom options] proxycommand=ssh<EMAIL_ADDRESS>nc %h %p 2> /dev/null

    proxyus -> breakfree@vps1.cyberciti.biz:22
	[custom options] identityfile=~/.ssh/vps1.cyberciti.biz.key localforward=3128 <IP_ADDRESS>:3128

Listing entries for tag @gw

    uk.gw.lan uk.lan -> nixcraft@<IP_ADDRESS>:22
	[custom options] proxycommand=ssh<EMAIL_ADDRESS>nc %h %p 2> /dev/null8

awesome.
@berkerpeksag can you find time to review this?

any chance to become a contributor to this project and integrate it myself? :)


gradle-wrapper.jar verification fails when stored via git-lfs

If the jars are stored with git-lfs the checksum will fail, the lfs flag needs to be added
    steps:
      - uses: actions/checkout@v4
        with:
          lfs: true  # gradle-wrapper.jar verification will fail without this

otherwise there will be a mismatch, for example gradle 8.10
❯ sha256sum gradle-wrapper.jar
2db75c40782f5e8ba1fc278a5574bab070adccb2d21ca5a6e5ed840888448046  gradle-wrapper.jar

action error:
✗ Found unknown Gradle Wrapper JAR files:
 f629a612b54373f56f950e11394850bb65f87dd68d7731fcde2b99564dcfbf78 app/gradle/wrapper/gradle-wrapper.jar
Error: Error: At least one Gradle Wrapper Jar failed validation!

Not really a bug, posting this for reference. Maybe a check could be added to display a more useful error message?

Thanks for the report. We can at least update the documentation for this case.
A PR would be welcome :).

@LivingWithHippos Looking at the docs for actions/checkout, am I right in thinking that if you intend on running the Gradle build you would always need to add the lfs: true option?
It looks like the wrapper would fail to execute if you omit this option.

If you set jars to be managed with git lfs in your repository gradle will always fail without that flag. It will compute the hash of the pointer files instead of the jars.

Thanks. My point is that if someone is using setup-gradle with the automatic wrapper validation, then they are likely to already be including lfs: true in their workflow. Without this, any Gradle execution will fail, even without wrapper validation.
I wonder why lfs: false is the default for actions/checkout?


Custom Presentation

Exhibits should support being presented in custom ways. For example, consumers may be creating an exhibit which houses an alert, popover, or sheet.

Resolved by previous changes to context creation + layout providing.
Documented in #52


Refactor Ray Workload creation for Workload metrics Ray Workload test

closes RHOAIENG-7422

Added Ray cluster CR file to create a ray cluster workload
Deleted existing ray cluster setup via codeflare sdk tests
Adjusted the Get Memory Requested method based on the requested resource for Ray Cluster

tests passed in ci rhods-ci-pr-test/2780/


Review impact of MLJBase 1.0

MLJBase 1.0 has just been released. As MLJBase is used in testing, and the most current release will usually be adopted, there may be some breakages to tests of the current package, if MLJBase measures are used in testing.
See the migration guide for details.
It is highly unlikely /src code will need to be changed.

I don't think I use MLJBase measures in testing. Neither tests nor the guides break here.

Could you also check your notebooks? If you are using MLJBase without MLJ, you will need to add StatisticalMeasures.jl to the Project.tom., if you want to update the Manifest to use the latest MLJBase.
If you are using MLJ, then no change is needed now, or likely needed after a pending update to synch with MLJBase 1.0.

In the notebooks where I use MLJBase, only machine and transform are used. Generally, notebooks that are explicit in the docs just use MLJ.


Comment popup styles

Features:

Add styles for popup window on:
~ Image
~ Font colors
~ Form elements
~ Comments section

Add styles for buttons.

Author:
@Luiscarlosvd

Hi @Luiscarlosvd     🙋♂,
Good job so far!
You have done well reaching this point of the milestone 🤝 But there are some things that you can kindly improve for your code but you are almost there!

Top highlight 🎯

The Pull Request follows the GitHub Flow ✅
The PR title and description are professional and descriptive ✅
Linters are working properly ✅

Suggested changes

[x] Everything is great!

Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers, and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Update Dockerfile

Node 20 is needed for plexamp 4.10 and above
installation complains uid 2002, change to 2000

changes on dockerfile discussed here: https://github.com/hifiberry/hifiberry-os/issues/544#issuecomment-2104164196
further more: a short description in the UI „how to claim / enter the token“ would be useful…

UID should stay 2002, but this requires some changes in the extension manager that will be included in the next HBOS alpha.


Extended keyboard not working on full screen

Please consider making a Pull Request if you are capable of doing so.
App Version:
2020.3.1 Standard Edition
Affected Device(s):
OnePlus 7 Pro Oxygen OS 10.3.8 (Android 10)
Describe the bug
The extended keyboard (row on top of the keyboard) does not show up when the app is on full screen. It does appear when not in full screen, and it appears when clicked tab with AnySoftKeyboard (as it selects the first button).
To Reproduce
Steps to reproduce the behavior:

Go to settings and under Application enable Full screen.
Ensure that you have Extended keyboard enabled under Editor settings
Open a file and click to start editing, the top row won't show up
If you have AnySoftKeyboard, with a top bar that includes the tab key, try clicking on it, and you'll see that it selects the tab button of the top row, showing it.

Expected behavior
It should simply show up as it does when not in full screen, full screen should not affect it

I found out that the same problem was described earlier in issue #35, so I am closing this one


Minor Fixes on README

name: Minor Fixes on README
about: Minor Fixes on react-moralis README documentations
New Pull Request
Checklist

[x] I am not disclosing a vulnerability.
[x] My code is conform the code style
[x] I have made corresponding changes to the documentation
[x] I have updated Typescript definitions when needed

Issue Description

Missing account and chainId on useMoralis docs
Wrong links for useNFTBalances in Table of contents

Solution Description

Adding account and chainId to useMoralis
Fixing the useNFTBalances link to the right one

:tada: This PR is included in version 0.3.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Workflows are referencing vulnerable actions

Hello, there!
As part of the university research we are currently doing regarding the security of Github Actions, we noticed that one or many of the workflows that are part of this repository are referencing vulnerable versions of the third-party actions. As part of a disclosure process, we decided to open issues to notify GitHub Community.
Please note that there are could be some false positives in our methodology, thus not all of the open issues could be valid. If that is the case, please let us know, so that we can improve on our approach. You can contact me directly using an email: ikoishy [at] ncsu.edu
Thanks in advance

The workflow build-ci.yml is referencing action ilammy/msvc-dev-cmd using references v1.9.0. However this reference is missing the commit 74a501b which may contain fix to the vulnerability.

The vulnerability fix that is missing by actions' versions could be related to:
(1) CVE fix
(2) upgrade of vulnerable dependency
(3) fix to secret leak and others.
Please consider updating the reference to the action.
If you end up updating the reference, please let us know. We need the stats for the paper :-)

Already Fixed:
https://github.com/adxeproject/buildware/blob/main/.github/workflows/build-ci.yml#L158


Add use case for removeAssignees

Codecov Report

Merging #171 (acff762) into master (a419d96) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #171   +/-   ##
=========================================
  Coverage     68.75%   68.75%
  Complexity      597      597
=========================================
  Files           107      107
  Lines          1984     1984
  Branches        224      224
=========================================
  Hits           1364     1364
  Misses          537      537
  Partials         83       83

Impacted Files
Coverage Δ
Complexity Δ

.../address/logic/commands/ClearAssigneesCommand.java
0.00% <ø> (ø)
0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a419d96...acff762. Read the comment docs.


According to the readme can not run

According to the readme can not run, as follows:
python examples/example_multiagent.py
Traceback (most recent call last):   File "examples/example_multiagent.py", line 8, in <module>     placeholder_env = BattlesnakeEnv(n_threads=4, n_envs=16) TypeError: Can't instantiate abstract class BattlesnakeEnv with abstract methods env_method, get_attr, set_attr

Looks like this is incompatible with stable-baselines since 2.5.1. Try pip install stable-baselines==2.5.0
The plan I currently have for this repo is to move to Tensorflow 2.0 which has its own implementations of the learning algorithms that gym-battlesnake is currently borrowing from stable-baselines.


Add more middleware

As I want JsonMapper to support as many use case as possible I invite you to add a new middleware covering a use case we have missed. Due to the use of middleware even less common use cases can easily be added.

Closing issue as it does not attract any contributors


Add the ability to change the directory from which to create the archive

Current behavior
Currently it adding some files to a tar archive will always include the entire folder structure.
Suggested enhancement
Allow the user to set a different working directory for the tar operation (not the output) in order to allow flattening the folder structure in the archive.
This can be achieved using the -C option as suggested in the PR

[!Note]
-C, --directory=DIR
Change to DIR before performing any operations. This
option is order-sensitive, i.e. it affects all options
that follow.

Additional context
No response

:tada: This issue has been resolved in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Track addition types

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-2 of 2 (0.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 28.545%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

queuelogic/logic.go
0
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
914

Relevant Lines:
3202

💛  - Coveralls


weave.works domain no longer in use?

Apparently the domain has expired and now it is serving phisy looking content. Should links to weave.works be scrubbed from the website and other parts of the documentation?

Yes.

I'm on it


Top menu Breadcrumbs disappear when an anchor is selected

Hi,
It seems the top breadcrumbs disappear when I select a section, here is an example, in a test page I created 2 sections:

This is displayed correctly in the URL does not have a #my_section in the end. But if A section is selected, this happens:

As you can see, the upper section (breadcrumbs and Edit) is gone :'(

Hi.
When you click a section in the TOC, the content is scrolled to where the section is. I think you can scroll up to the top and breadcrumbs are there. If you can't scroll I need to investigate it.

Unfortunately, we can not scroll up ^^;
On Mon, Dec 4, 2023, 18:01 Masaki Yasutake @.***> wrote:

Hi.
When you click a section in the TOC, the content is scrolled to where the
section is. I think you can scroll up to the top and breadcrumbs are there.
If you can't scroll I need to investigate it.
—
Reply to this email directly, view it on GitHub
https://github.com/my17560/dokuwiki-template-readthedokus/issues/75#issuecomment-1838206288,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA3BAGYMH64DY4KX3ZZL4ALYHWNPRAVCNFSM6AAAAABAFKBWCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZYGIYDMMRYHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

That's weird, it never happened to me. Did you clean install Dokuwiki? Are you using some plugins?

Yes we are using quite a few plugins, I can investigate that too, but I am
not sure I have the bandwidth to do a clean install anytime soon ^^;
On Mon, Dec 4, 2023, 18:08 Masaki Yasutake @.***> wrote:

That's weird, it never happened to me. Did you clean install Dokuwiki? Are
you using some plugins?
—
Reply to this email directly, view it on GitHub
https://github.com/my17560/dokuwiki-template-readthedokus/issues/75#issuecomment-1838219076,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA3BAG23MD7RVWZJSZMHRN3YHWOJPAVCNFSM6AAAAABAFKBWCSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZYGIYTSMBXGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi,
here is the list of plugins we have installed on our production environment:
(ls lib/plugins):
clipboardutils
codeclipboard
comment
config
const
diagrams
diffpreview
do
drawio
edittable
extension
fastwiki
folded
gitlabapi
google_maps
ifauthex
iframe
imgpaste
include
index.html
indexmenu
info
logviewer
markdowku
move
newpagetemplate
nspages
pagelist
plantumlparser
popularity
revert
safefnrecode
sectiontoggle
sqlite
struct
styling
templatepagename
upgrade
userhomepage
usermanager
userpage
wrap

I am not sure if that would help ^̂^;
let us know :)

That's quite a lot! I've installed all those plugins but sadly I couldn't reproduce the situation…Maybe depends on the plugin settings?
Is the sidebar shown when breadcrumbs are displayed correctly? If not, user custom styles might be the cause.
I’ll continue to investigate to reproduce the bug but it is better to test on your site, by disabling all the plugins or disabling user custom styles if possible.

Hi, thanks for the hard work, I am thinking it might be in js code:
Here are steps to reproduce it at least on my end:

Create a page with several sections (the page itself must be longer that can be displayed in one page)
Edit one of the sections (e.g. using fastwiki)
save
you will be redirected to http://wiki/your/page#anchor (anchor being the section editted)

From there the top header is hidden.
If you directly connect onto the page itself: http://wiki/your/page#anchor (no editting required) the same behavior happens too.
I think the (maybe) impactful plugins would be markdown and fastwiki, but I doubt it.
Also, in the script.js:
/* DOKUWIKI:include js/readthedokus.js */

var dokus;
document.addEventListener("DOMContentLoaded", function() {
        if (document.body.id === "dokuwiki__top") {
                dokus = new ReadtheDokus();
                dokus.run();
        }
});

If I disabled the code here, the problem does not show up (still investigating).

The function called _jumpToAnchor() is called to jump to the section. That must be conflicting with something.
Are there any errors shown in Developer Mode's console when you click?

Might be related, but I do have an error here:
Failed to execute 'write' on 'Document': It isn't possible to write into a document from an asynchronously-loaded external script unless it is explicitly opened.
(anonymous) @ js.php?t=readthedokus&tseed=f5699ab5b0f63b30408d6a692b33949e:9

on the following line
document.write('');

From a grep in the code, that was in the folded plugin, but even after disabling it, while the message is gone, the header problem still remains.

Looking in the debugger, and adding a breakpoint in the _jumpToAnchor method, I see the following line seems to change the offsetHeight to 0:
        location.href = hash;

Seems after executing that line the header is gone.

For information, for now I just comment this line to fix this issue … (which works) ^^;

I think I found the issue (even though the cause is not clear):
if my footer.html I had a code like this:

    My Disclaimer here

in the header.html I had a style css to add a padding-top of 1.6em to the inner div. Removing that or replacing it with a margin-top instead fixes the issue.
So, I am going with this :)