Generated markdown is not compatible with Test Summary Action

I think one of the main purposes for that report was using it on Action, not sure if this should be reported as a bug or not tho.

Could you post the content of your report?

I have searched on their repo and I found nothing :/
My md starts so:
# detekt

## Metrics

* 128 number of properties

* 70 number of functions

What should we do here? The markdown seems fine. Should this be reported to the action itself? Maybe it's a bug on its side and if it's not they will point out what's the problem in our markdown.

I can't even found the log message in their source code 🫠
So we are totally blocked and there is no other way than asking them.

https://github.com/test-summary/action/issues/10

I googled the error message and it seems to be coming from a Node lib called xml2js, which was odd because you're feeding markdown to the action, not XML.
Then I looked at the action's README, which says it takes XML or TAP format and generates markdown output.
So unless I've misunderstood, the action doesn't take markdown input at all, so there's nothing for detekt to change here. It doesn't make sense to use detekt output as an input to that action.
@JavierSegoviaCordoba can you please confirm?

You are totally right, I read the Detekt feature request about the Markdown report and thought I had to use a markdown file instead of an XML file.
https://github.com/detekt/detekt/issues/4826

Additionally, the detekt.xml file is not compatible with the summary action.
Error: unknown test file type for 'build/reports/detekt/detekt.xml'

Maybe I can create a different issue

I think you should instead use the $GITHUB_STEP_SUMMARY variable rather than using the test-action report: https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/#create-summaries


Catalog-import should be more generic to support multiple Git providers

Regarding @backstage/catalog-import:

i confirmed the same basic import functionality is working with Bitbucket Server. I do think we need to make the verbiage of the plugin a bit more generic and ideally specific to the integration in use given in the app-config, given someone using Bitbucket wouldn't benefit from all the GitHub verbiage 😀

Anything that makes reference to GitHub maybe keep it generic for now and update to something like from "your repository" until we can have it changed to integration.bitbucket = Bitbucket or integration.gitlab = GitLab etc... The Start tracking your component in "Backstage" verbiage should also be updated to "my app" in the app-config, believe that's in the register-component... thoughts?

Originally posted by @regicsolutions in https://github.com/backstage/backstage/pull/3782#issuecomment-751716202

I am taking a look at this. However, my react skills are limited to bear with me. So it can be assigned to me for the time being.

I am taking a look at this. However, my react skills are limited to bear with me. So it can be assigned to me for the time being.


[161] Setup targets with Tuist

Resolves https://github.com/nimblehq/ios-templates/issues/161
What happened

Update Tuist template to have following targets:

<ProjectName>
<ProjectName>UnitTests
<ProjectName>UITests

Insight

Add unit and UI tests example files.
We will need a script to update the folder name later. For example, update ProjectNameTests to be DemoTests

Proof Of Work

Please remove 2 directories Resources and Sources at the root directory since it empty now.

Please remove 2 directories Resources and Sources at the root directory since it is empty now.

@phongvhd93 Do you mean ProjectName/Resources and ProjectName/Sources? There are no empty Resources and Sources directories at the root directory on my local. 😅


Fix for issue 2082 - problems when running tests in VS

@ajcvickers Fix for #2082.

:sheep::it:

Fixes checked in with commits 3325df4 & 5bbd6e0.


Browser signature is different when the script is deployed on different hosts

Would it be possible to generate a unique browser signature regardless of hosts where the script it run?
E.g. Localhost: Signature_A
Server A: Signature_A
Also, it would be great if there is an api to know the browser being used by the clients.
Thank you in advance.

Try the Usage with local storage option
https://github.com/successtar/browser-signature#usage-with-local-storage-implementation


[HWORKS-731] Raise error if deployment cannot be created

@javierdlrm - can you also bump the version?

@javierdlrm - can you also bump the version?

@SirOibaf done


LoopReducer is not type safe

@nweber-gh @laszlopandy
I've always been confused by the type LoopReducer.
export interface LoopReducer<S, A extends Action = AnyAction> {
  (state: S | undefined, action: A, ...args: any[]): S | Loop<S, A>;
}

which typically leads to a reducer like this
type MyActionTypes = ActionType1 | ActionType2;

const MyReducer: LoopReducer<MyState, MyActionTypes> = (state = initState, action) => {
  switch(action.type){
    case actionTypes.TYPE_1:
      return handleType1(state, action); //infers that action is ActionType1

    case actionTypes.TYPE_2:
      return handleType2(state, action); //infers that action is ActionType2

	default:
	  return state; //why doesn't typescript complain about this?
  }
};

The part that is confusing to me is that it defines the actions it expects to take (A), even though reducers need to handle all actions. How does it know what to do in the default case if you're telling it that no actions you pass will hit that default case?
It turns out that when you do a union type, typescript implicitly adds | never to the end of it, and that's what the type of action is if you reach the default case. And since it's never, typescript doesn't care what you do since it assumes you'll never reach that code. If you changed the default case to return action, typescript would not complain. It would assume it was type safe
because the bad return type was unreachable.

I looked back the PR where we added this originally (#210), and in hindsight I think this is what caused the confusion that lead to #244. We originally had one Action type in the generic, but it was for the returned actions, not the passed in actions. We started using it instead to describe the passed in actions, and we lost the parameter for the returned actions.
It looks like this was all done to allow Typescript to infer the types of the actions based on the switch statement. If we switch the type back to AnyAction, that no longer works and we need to cast the action before passing it to the handler.
return handleType1(state, action as ActionType1)
Is there some typescript magic that either of you can think of that would allow us to fix this without forcing everyone to cast the actions every time they pass them to a handler? One idea I had was if there was a utility type that was similar to union and intersection types, but a "difference" type. By that I mean for Diff<A,B>, it's a type that fits in A but not B. Then I would do something like this.
type MyTypesStrict = MyActionType1 | MyActionType2;
export type MyActionTypes = MyTypesStrict | Diff<AnyAction, MyTypesStrict>;

Then it seems the default case would no longer be never but instead of any type of action besides the ones I cared about. Not sure if that would allow for type inference or if it's even possible. I thought Exclude<T,U> would help but it just returns never when I try to use it with these parameters.
If we can't figure out a solution to make it so you can actually infer the types, I think we may need to force everyone cast even though that is annoying. I think being not typesafe is not really an option in the long run (and since we have a major upgrade coming soon, now is the time do it). Though I also noticed that even if we change the type of action in LoopReducer back to AnyAction, you can just say
const MyReducer: LoopReducer<MyState, MyActionTypes> = (state: MyState = initState, action: MyActionTypes) => {...}

and it will go back to the old behavior. Is there a way to make that a type error? Or is that an explicit override of the type system and there's nothing we can do about it?
EDIT: Typescript would complain if you tried to do something like return 123. But if you return something with a type of never, it won't complain because it assumes it's impossible to get there.

I also am realizing now that this issue is independent of redux loop and that redux does the same thing. I'm going to look around and see if anyone has said anything about redux in general

I filed https://github.com/reduxjs/redux/issues/3792

the original discussion that lead to this pattern being added to redux is here https://github.com/reduxjs/redux/pull/2563#discussion_r133624376

Update. we also don't complain if you forget a default statement altogether, which is probably worse.

AFAIK TypeScript doesn't complain if you put a default even if the code is unreachable. I'm not sure the exact reason for this but probably it's because it is good practise, and it allows you to put an assertNever(value) there to force exhaustiveness.
Regardless I agree with your concerns. The issue here is that in reality the switch should not be exhaustive. Reducers aren't necessarily supposed to handle all actions, only the ones they care about. And even if they do, redux enforces this by passing the special '@@redux/INIT...' at the beginning.
So the type annotations in your example indicate to typescript "only this action type can be passed", whereas in reality anything with a type attribute can be passed to a reducer and it's just supposed to ignore the values it doesn't know. We can express this in TypeScript with | { type: string } but then TypeScript doesn't do code completion on the action type. I guess it just things because it can be any string there's no point in auto-completion.
I'm using VSCode and so far I haven't found a way to tell TypeScript that the action can be any object with a type while also giving auto-completion on the list of known types. If we figure that out I think we'll be close to a solution.
Regarding your other question:

and it will go back to the old behavior. Is there a way to make that a type error?
Yes, if in the definition of LoopReducer we specify that action type as | { type: '@@redux/INIT' }, then any function which specifies action: MyActionType will fail with a type mismatch.

interesting idea idea with the extra fake action type! cc @nweber-gh
export interface LoopReducer<S, A extends Action = AnyAction, B extends Action = never> {
  (state: S | undefined, action: A | {type: '@@REDUX/DONOTUSE'}, ...args: any[]): S | Loop<S, B>;
}

That does seem to address the issue. i like that. Are there any downsides to this solution besides the weirdness and the fact that we have a magic constant string? I feel like the only way to actually make this go wrong from a user perspective is to explicitly handle the DONOTUSE action, which is fine.
Do you want to mention this solution in https://github.com/reduxjs/redux/issues/3580 @laszlopandy ? There's an issue about this for vanilla redux too.
I spoke with @nweber-gh (we work together btw) and before you suggested this solution we were thinking it made sense to just deprecate the current LoopReducer type by renaming it to LoopReducerDeprecated and then making a new one that used AnyAction as the type (which would have type safety but no inference). This is better though so thank you for suggesting it.

closing this since it's being dealt with in #244


get_distance() doesn't give allways the good result

Hello,
I use leaflet-gpx and I have an issue: get_distance() doesn't give allways the good result:
I join a zipped folder with my script and some gpx to visualize the issue.
get_distance() gives the good distance (12 km) for the track SSS.gpx.
I changed a bit this track and added some waypoints, which gives SSS_wpt.gpx.
get_distance() gives now 18 km, which is wrong.
I loaded SSS_wpt.gpx in Visorando or VisuGpx: they both give the good result: 12 km.
I tried to remove all the waypoints, which gives SSS_wpt2.gpx but get_distance() gives allways a bad result: 18 km.
In fact elevation_gain() and elevation_loss() give also the good results for SSS.gpx and bad results with SSS_wpt.gpx.
NB: To visualize a track (for example SSS.gpx), you need to type: carte.html?track=gpx/SSS.gpx
Regards,
André
folder_issue.zip

The problem is related with the elements  of the gpx file as it can be seen from the two join gpx files.
 gives the elevation of the point.
test.zip
It's the same track in the two files. The computed distance (260 m) is correct for test.gpx but not in test2.gpx (11 km).
The difference is that in test2.gpx I've deleted some  elements.
I suppose that you consider the elevation is equal to zero when there is no  element; so there is a big difference of altitude.
You should ignore the elevation when  is not present.
Thanks for your work,
André

It's difficult to compute a good and accurate distance from a GPX without a much more complex algorithm. I can look into the elevation gain/loss thing though.


switch from Node v5.x.x to Node v6.x.x

This addresses the test failure noted in #248.
As can be seen in the diff, we currently have a guard which prevents doctests from being run in Node v0.10.x (which doesn't support arrow functions). It's completely reasonable to run doctests in just one environment, since their purpose is to keep the documentation up to date rather than guarantee compatibility across Node versions. I suggest the latest stable version if we're to choose just one.
I hope these changes obviate the need to mention a version in CONTRIBUTING.md, as it would be easy for such a note to become out of date. Let's merge this pull request then discuss in #248 whether to add a note.

👍


[bug] Looking up a deactivated widget's ancestor is unsafe.

when I go back from my screen that exception fires Looking up a deactivated widget's ancestor is unsafe.
The issue happens on the disposing state, try to dispose the screen somehow and you will catch the exception in the console

the bug is coming from that part, when I commented it every thing worked well.

For me, the line that causes this is line #434 in nested_inner_scroll_coordinator.dart. Commenting out this line fixes the problem, but it doesn't seem like a good solution since the inner scroll position isn't being detached any more.


Implement the Plan Caching page

Migrate all flags, notes, and links over from the v6 PDF and the POC Markdown repo into the Plan Caching page.

Work complete, closing issue


Advisor currency setting

[Enter feedback here]
How do I change the currency that the recommendations display in, rather than USD, please? ACM is set to display in the currency I want. I’m an owner and have ACM rights.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 9a8bd5c1-bdc5-34ba-9b18-2783f5239228
Version Independent ID: 172d0699-eb3f-18b0-340b-d40a6a6aa823
Content: Cost recommendations - Azure Advisor
Content Source: articles/advisor/advisor-reference-cost-recommendations.md
Service: advisor
GitHub Login: @ikhapova
Microsoft Alias: ikhapova

@pthomas848
Thanks for your feedback! We will investigate and update as appropriate.

@pthomas848 Please refer to my post here - https://learn.microsoft.com/en-us/answers/questions/773930/different-currency#answer-774177

Thanks for the feedback. I am able to get ACM GUI to display in my local/billing currency. But Azure Advisor cost recommendations in the GUI display in USD, which I would like to change to my billing currency.  Hope this clarifies my request.

@pthomas848 There are few places in which the recommendations could be surfaced – would you send us a screenshot of the issue you are referencing?

@pthomas848 We haven't heard back from you, so we will now close this issue. If this remains an issue, please reply and we will gladly continue the discussion.

Apologies for the delay. Here is a screenshot

@pthomas848 Change of reporting currency is not supported in Advisor. Cost savings are shown as is – in the currency they were generated by downstream systems.
You can submit a feature request and we will consider during planning.
Please, use this link -   Azure Advisor · Community


PEP 541: Transfer ownership of unmaintained django-pygment from unknown owner to  @stefantalpalaru

Hi,
I would like to start process of transfering ownership of the name django-pygment from  an unknown PyPI package owner to the current maintainer — @stefantalpalaru.
The current PyPI package is not maintained since the first upload in 2013.
As I understand from the discussion in the Pull Request (https://github.com/odeoncg/django-pygments/pull/12#issuecomment-485014055) project was uploaded to PyPI by unknown person who maybe was not related to the  django-pygment.
The project main author, Stefan Talpalaru, maintains now this project in  the stefantalpalaru / django-pygments repo using github account @stefantalpalaru.
Project contributors agree with authorship and conditions.
References #1506.

Thanks, @shurph! My PyPI account is: https://pypi.org/user/stefantalpalaru/

One of the first parts of the PEP that governs name transfers, PEP541, is to attempt to contact the project owner. I've emailed the address we have on file for tavein, the owner of the project.

I'm that unknown owner (Jason contacted me via email) and have nothing against transferring ownership of django-pygments to Stefan. The reason why I took ownership of the project in the first place is that it was abandoned then.

@tavein Thanks for responding! In order to do so, please log into your pypi.org account and add stefantalpalaru as another owner. When that's done, @stefantalpalaru should get an email notification, and could then log in and remove the tavein account as an owner if desired.

@tavein Thanks for responding! In order to do so, please log into your pypi.org account and add stefantalpalaru as another owner. When that's done, @stefantalpalaru should get an email notification, and could then log in and remove the tavein account as an owner if desired.

done

Thank you. New version released: https://pypi.org/project/django-pygments/0.3/


Proofread "which query should I use" guide

https://github.com/kentcdodds/react-testing-library/issues/301
Need to be clearer about the relative accessibility of the queries

Closed in 8ace7dede2bf445fd845c1bcb515ce9b1a684d45


Bug: rounding's collision

Good day to you!
I have settings for default rounding, an have rules for some windows
But i have collision for that class of windows

can't reproduce:

config?

config
```
# ---------------------------
#           general
# ---------------------------
$monL=DP-1
$monR=HDMI-A-1
monitor=$monL,1280x1024@60,0x0,1
monitor=$monR,1280x1024@60,1281x0,1
workspace=$monL,name:term
workspace=$monR,name:web
input {
kb_layout=us,ru
kb_options = grp:win_space_toggle
kb_rules=evdev
follow_mouse=1
natural_scroll=1
}
general {
sensitivity=0.9
main_mod=SUPER
layout=dwindle
gaps_in=5
gaps_out=10
border_size=1
col.active_border=0xfae9aa82
col.inactive_border=0x00000000
# cursor_inactive_timeout=2
damage_tracking=none
no_border_on_floating=1

}
bezier=overshot,0.42,0,0.58,1
animations {
enabled=1
}
animation=windows,1,3,default,popin 30%
animation=workspaces,1,3,default,fade
animation=fadeSwitch,1,4,default
animation=border,1,5,default
dwindle {
pseudotile=1 # enable pseudotiling on dwindle
special_scale_factor=0.95
preserve_split=1
force_split=2
}
misc {
disable_hyprland_logo=1
mouse_move_enables_dpms=1
}
input:touchpad {
disable_while_typing=1
natural_scroll=1
}
gestures {
workspace_swipe=1
workspace_swipe_fingers=2
workspace_swipe_distance=50
}
DECORATIONS

decoration {
rounding=25
multisample_edges=1
active_opacity=0.97
inactive_opacity=0.92
fullscreen_opacity=1
blur=0
}
windowrule=rounding 0,util
</details>

Is that maybe the shadow? try turning off shadows.

yes, turned off shadows and problem solved
thank you!

but then comes a question:
is it normal that shadows didn't respect ruled roundings?

no, it's a bug, and now that i look at my screenshot i can also see it

fixed in 6cae44e2c0254e959ad05e4f2d98576cb6b82258

Thank you!


[Event Request] codeunit 5870 "Calculate BOM Tree" - OnBeforeTempItem

Hi, would it be possible to get an event OnBeforeTempItem codeunit 5870 "Calculate BOM Tree", like this :
                    TempItemAvailByDate."Variant Code" := "Variant Code";
                    if LocationSpecific then
                        TempItemAvailByDate."Location Code" := "Location Code";

                    Clear(AvailableToPromise);
                    OnBeforeTempItem(BOMItem);
                    TempItemAvailByDate."Available Qty" :=
                      AvailableToPromise.QtyAvailabletoPromise(BOMItem, "Gross Requirement", "Scheduled Receipts", "Needed by Date", 0, ZeroDF);

    [IntegrationEvent(false, false)]
    local procedure OnBeforeTempItem(BOMItem: Record Item)
    begin
    end;

Thanks!

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


[KIECLOUD-97] Propagate OpenShiftStartupStrategy related changes to KIE APB, and Operator

a) Remove "KIE_SERVER_USE_SECURE_ROUTE_NAME"
b) Remove "secure-" prefix from templates and change to base name for https routes
c) Add "insecure-" prefix http routes
Signed-off-by: Evan Zhang<EMAIL_ADDRESS>Thanks for submitting your Pull Request!
Please make sure your PR meets the following requirements:

[x] Pull Request title is properly formatted: [RHDM-XYZ] Subject
[x] Pull Request contains link to the JIRA issue
[x] Pull Request contains description of the issue
[x] Pull Request does not include fixes for issues other than the main ticket
[x] Attached commits represent units of work and are properly formatted
[x] You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
[x] Every commit contains Signed-off-by: Your Name<EMAIL_ADDRESS>- use git commit -s

@errantepiphany @spolti @ricardozanini
This PR is submitted as per our discussion.


Fix/15954: Move debounce.cancel to both add attachment and comment text

Details

Currently, we only cancel debounce to save drafts if we send text only, but this logic is also needed when we add an attachment. So we need to move this.debouncedSaveReportComment.cancel();  to both add attachment flow and comment text flow
Fixed Issues

$ https://github.com/Expensify/App/issues/15954
PROPOSAL: https://github.com/Expensify/App/issues/15954#issuecomment-1486464385
Tests

Copy a file/image
Open any report and enter some text
Then paste a file/image into the compose box immediately
Pressing enter 2 times
Verify that the text entered in step 2 isn't displayed in composer and only displayed one time in chat

[x] Verify that no errors appear in the JS console

Offline tests

Same above
QA Steps

Copy a file/image
Open any report and enter some text
Then paste a file/image into the compose box immediately
Pressing enter 2 times
Verify that the text entered in step 2 isn't displayed in composer and only displayed one time in chat

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://user-images.githubusercontent.com/113963320/230376171-a42cf2fc-dab3-4331-b4eb-b36c06193a4d.mp4

Mobile Web - Chrome

https://user-images.githubusercontent.com/113963320/230376154-ccbdcb5c-f619-4127-8b91-3f32596ed2fb.mp4

Mobile Web - Safari

https://user-images.githubusercontent.com/113963320/230376441-45587f63-02e4-44c8-9041-e553df56d200.mp4

Desktop

https://user-images.githubusercontent.com/113963320/230376134-3423b98c-8f45-4564-916f-99cf5190a08a.mp4

iOS

https://user-images.githubusercontent.com/113963320/230381114-367a33dc-f193-4ae1-a6c9-bd9bd81ebbe1.mp4

Android

https://user-images.githubusercontent.com/113963320/230376114-93d3285e-a1af-489c-98a3-3282d3cc9c05.mp4

@grgia @parasharrajat One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@parasharrajat Friendly bump, help to review again please
cc @grgia

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.0-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.0-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Test for broken links in readme and docs

Description
With restructuring of project folders, some links in README.md became broken and we didn't notice. We need a way to automatically test for this.

https://github.com/gaurav-nelson/github-action-markdown-link-check maybe this can help !

https://github.com/gaurav-nelson/github-action-markdown-link-check maybe this can help !

yep, already started playing with that.


Server-Side AuthTokens/Sessions

Hey Mike!  For applications requiring social integration with FB/Twitter, etc... server-side auth token generation is needed.  What are your thoughts on either:

Sending the authToken to the client on socket connection (less secure), which can be then used to filter rows per your examples.

Extending server-side validations (so client needn't know its own auth token) to automatically filter only rows containing the authToken for specific queries, eg:

// client observe
myMessages: new QueryRequest({r.table('messages'), validateAuthToken: true, changes: true, initial: []})

// server validate
r.table('messages')
 .changes({include-initial: true})
 .filter(r.row('authToken').eq(session.authToken))  // automatically filtered

Is this already possible?
 I don't quite follow how it's possible for a client not to store any sort of authToken, or else how would the server confirm the client is logged in?
If you just mean ordinary authentication (not OAuth with a third-party provider), the chat example app shows how to do authentication. There are a few separate ajax routes to do bcrypt for login/signup, but in general the client sends the authToken at the beginning of the websocket connection, the server validates it on session creation, and then the server knows which user is currently connected on all queries in the session. I don't believe this is insecure, since as long as you use https/wss, that's the traditional way of authenticating with cookies or HTTP authentication headers.
If you're thinking of OAuth, then it depends a lot on the use case, but we'd have to write custom logic to request the access token from the third party provider, and either store it on the server or send it back to the client. If we store it on the server, we still need a way of knowing that a particular client is authenticated with us. If we don't send the client any kind of authToken to store, then they'd have to re-authenticate with OAuth every time they reconnect. We can send the client an internal authToken to store (like in the chat example) so the client doesn't know our OAuth access token.
Not sure if that's what you were asking about, so let me know a more concrete example if I'm misunderstanding.

Yes, the client will store a server-generated token.  This would be compatible with OAuth and many npms like express-cookie-session.  Rather than send that token to the client via an additional HTTP/GET request, would it be possible to send it over the websocket on connection?
It would be clean to have a backwards compatible way of pulling this off.  If the authToken is inside the sessionPromise, then that whole session object could be sent-- thoughts?

I think I see what you're getting at, but I'm still having trouble understanding the exact use case. Could you describe what you imagine the messages sent back and forth between client and server would look like, so I can better understand how it might fit in?

Absolutely and thank you for following:

client connects to server, gets cookie'd session (eg. express-cookie-session)
client rethink-websocket-client connects to server
server immediately sends session (returned from sessionCreator) over the websocket (includes authToken)
client makes rethinkdb queries using authToken

I sent a pull-request for a simple change to pass websocket headers through to the sessionCreator, so it can be securely matched up with a cookie'd session:
https://github.com/mikemintz/rethinkdb-websocket-server/pull/13
The remaining bit is sending that session over the websocket to the client.  Any thoughts on the cleanest integration?

I get that people may want to use cookies instead of url params to pass the session key. I just made a couple comments on your PR, but otherwise good to merge.
I agree it's a bit tricky to send session data back to the client. I have some thoughts, but it's a lot of complexity which seems like it can be solved by just having the developer add a single ajax route that looks at the cookie and returns session data to the client. I expect most production apps are going to have to have a few out-of-band ajax routes like this anyway, e.g. for bcrypt. Would having that ajax route solve your particular use case? Are there other use cases that it doesn't work for? Or is it just for the convenience of not having to define separate routes?
I don't think it makes sense to always send the session (from sessionCreator) to the client, since it may have sensitive data the server doesn't want the client to have, e.g. the full User object.
For your particular use case, I think it makes more sense to have the server send the client the userId instead of the authToken, since the userId is what they would use in queries to filter to only the data they should have access to. Of course that depends on your particular schema, but generally the sensitive information will only be stored once, associated with the less sensitive userId which is stored everywhere else.
You'd also mentioned having the server automatically modify queries to filter for authToken. Is that equivalent to https://github.com/mikemintz/rethinkdb-websocket-server/issues/12 ? If so, let's continue that particular discussion there, since that sounds like a very different approach.

Exactly-- userId would be best (or any bit of non-sensitive user-identifying data to start a session) and it'd be much faster to reuse the socket for sending that back to the client in a single shot on connection.  Do you think mimic'ing a ReQL query result on the way up to the client would be the best tactic?
Yes, mividtim's automatic filters precisely describe 2. above!

I think the cleanest way to reuse the socket to send back information would be having before-execute query callbacks like in https://github.com/mikemintz/rethinkdb-websocket-server/issues/2 and also add support for sending back "fake" query results.
For example, here's some pseudo-code we might want to allow in the whitelist:
r.db('fake').table('fake').insert(RP.ref('command')).intercept((refs, session) => {
  const command = refs.command;
  if (command.cmdType === 'getUserId') {
    const resultRows = [{userId: session.userId}];
    return Promise.successful(resultRows);
  } else if (command.cmdType === 'encryptPassword') {
    [...]
  }
  return Promise.reject('invalid command');
});

Then in rethinkdb-websocket-client, one could write something like:
runQuery(r.db('fake').table('fake').insert({cmdType: 'getUserId'})).then(rows => {
  const userId = rows[0].userId;
  this.setState({userId: userId});
});

Does that kind of API (along with your PR) work for the use case? If so, let's continue discussing it at https://github.com/mikemintz/rethinkdb-websocket-server/issues/2


MauiGoogleMaps issues running on Physical IOS Devices

VERSIONS

Maui.GoogleMaps - 5.0.1 - Directly Cloned from: https://github.com/themronion/Maui.GoogleMaps.git
.NET SDK - .net framework 4.8.09037

IDE

[ ] Rider
[x] Visual Studio
[ ] Visual Studio for Mac

PLATFORMS

[ ] Android
[x] iOS

ACTUAL BEHAVIOR
// Write about of your problem
I built your Maui Google Maps Sample, Solution: "Xamarin.Forms.GoogleMaps" in Visual Stuido Comunity 2022 17.7.4. Works fine on Physical Android Devices, Emulated Android Devices, and on IOS Simulator Devices; however running on an IOS Physical Device (iPhone 11 IOSv16.5.1) I run into the Error Below, in Summary it's missing the TapContract.dll and Contracts.dll. If you have any advice on this issue it would be much appreciated!

Note: I have installed my own Google Maps Platform License Key.

2023-11-20 16:52:50.428 Xamarin.PreBuilt.iOS[2929:1056249] Could not resolve assembly Microsoft.VisualStudio.DesignTools.TapContract, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null. Details: Could not load file or assembly '/var/mobile/Containers/Data/Application/DCCDA259-547D-4A1F-92F6-88C9A6A89F38/Documents/MauiGoogleMapSample.content/Microsoft.VisualStudio.DesignTools.TapContract.dll' or one of its dependencies.

2023-11-20 16:52:50.425 Xamarin.PreBuilt.iOS[2929:1056249] Could not resolve assembly Xamarin.HotReload.Contracts, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null. Details: Could not load file or assembly '/var/mobile/Containers/Data/Application/DCCDA259-547D-4A1F-92F6-88C9A6A89F38/Documents/MauiGoogleMapSample.content/Xamarin.HotReload.Contracts.dll' or one of its dependencies.

ACTUAL SCREENSHOTS/STACKTRACE
<img width="1219" alt="GoogleMapsError" src="https://github.com/themronion/Maui.GoogleMaps/assets/151581287/3d883ce1-c746-4d70-be88-e9ea7e9d7d66">

EXPECTED BEHAVIOR
Expected to run application on Physical IOS Devices when selecting the "Basic Map" Button. Button Highlights; however does not respond. This is true for all Buttons not just the "Basic Map" Button.

HOW TO REPRODUCE
Clone your Github in Windows VS Studio and Build and Deploy on a Physical IOS Device.
https://github.com/themronion/Maui.GoogleMaps.git

Hot reload sucks, please try on a real macbook


Prompt for language pack only in English

Testing #52960

VSCode Version: 1.25 build for testing
OS Version: High Sierra

The test item mentions it should also be in the OS language. That does not seem to be the case.

This is because the language pack for French doesn't have the required strings.
For that matter, almost none of the core language packs have the required strings.
@danyeh,
The required translations are in the built-in language support but not in the language pack extensions.
https://github.com/Microsoft/vscode/search?q=installAndRestartMessage&unscoped_q=installAndRestartMessage
https://github.com/Microsoft/vscode-loc/search?q=installAndRestartMessage&unscoped_q=installAndRestartMessage
Can you ensure that these strings get into the language packs?

@danyeh Following language packs are not missing translations for those necessary strings which we show to user to install the language pack before installing it.

de

"vs/platform/node/minimalTranslations": {
	"searchMarketplace": "Marketplace durchsuchen",
	"installAndRestart": "Installieren und neu starten"
}

es

"vs/platform/node/minimalTranslations": {
    "searchMarketplace": "Buscar en Marketplace ",
    "installAndRestart": "Instalar y Reiniciar"
}

fr

"vs/platform/node/minimalTranslations": {
    "searchMarketplace": "Rechercher dans le Marketplace",
    "installAndRestart": "Installer et Redémarrer"
}

it

"vs/platform/node/minimalTranslations": {
    "searchMarketplace": "Cerca nel Marketplace",
    "installAndRestart": "Installa e riavvia"
}

-zh-tw: No translations at all
Only zh-cn has translations for all strings.

@sandy081 When users choose zh-cn or zh-tw we fall back to zh-hans or zh-hant respectively. The pack for zh-hans has the required translations, zh-hant doesnt.

According to loc schedule, we will cover all strings by end of day July 3rd. And publish language pack afterward.

When users choose zh-cn or zh-tw we fall back to zh-hans or zh-hant respectively. The pack for zh-hans has the required translations, zh-hant doesnt.

Fallback is only for extension name and locale id contributed by respective extensions still should be zh-cn and zh-tw.

As of today, we have zh-cn, fr, it, ja, ko language pack loc completed and published in Marketplace.

Thanks @danyeh for the update.

zh-cn: This needed fix from our side

fr

it

ja

ko

Remaining language pack loc completed and published in Marketplace - de, es, ru, zh-tw.

Verified all core language packs showing recommendation prompt in their respective languages.


Cannot find module './config/npm-config'

Can't run atom-beauify says failed to activate.

... edit style.css
...

Atom Version: 1.12.9
Electron Version: 1.3.13
System: Microsoft Windows 10 Home
Thrown From: atom-beautify package, v0.29.16
Stack Trace
Failed to activate the atom-beautify package
At Cannot find module './config/npm-config'

Error: Cannot find module './config/npm-config'
    at Module._resolveFilename (module.js:455:15)
    at Module._resolveFilename (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\electron.asar\common\reset-search-paths.js:35:12)
    at Function.Module._resolveFilename (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\module-cache.js:383:52)
    at Function.Module._load (module.js:403:25)
    at Module.require (module.js:483:17)
    at require (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\native-compile-cache.js:50:27)
    at Object.<anonymous> (C:\Users\davidtaylorjr\.atom\packages\atom-beautify\node_modules\winston\lib\winston\config.js:48:17)
    at Module._compile (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\native-compile-cache.js:103:30)
    at Object.value [as .js] (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\compile-cache.js:201:21)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (module.js:483:17)
    at require (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\native-compile-cache.js:50:27)
    at Object.<anonymous> (C:\Users\davidtaylorjr\.atom\packages\atom-beautify\node_modules\winston\lib\winston\common.js:15:14)
    at Module._compile (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\native-compile-cache.js:103:30)
    at Object.value [as .js] (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\compile-cache.js:201:21)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (module.js:483:17)
    at require (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\native-compile-cache.js:50:27)
    at Object.<anonymous> (C:\Users\davidtaylorjr\.atom\packages\atom-beautify\node_modules\winston\lib\winston.js:24:26)
    at Module._compile (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\native-compile-cache.js:103:30)
    at Object.value [as .js] (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\compile-cache.js:201:21)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (module.js:483:17)
    at require (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\native-compile-cache.js:50:27)
    at file:///C:/Users/davidtaylorjr/.atom/packages/atom-beautify/src/logger.coffee:10:13
    at Object.<anonymous> (file:///C:/Users/davidtaylorjr/.atom/packages/atom-beautify/src/logger.coffee:4:18)
    at Object.<anonymous> (file:///C:/Users/davidtaylorjr/.atom/packages/atom-beautify/src/logger.coffee:1:1)
    at Module._compile (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\native-compile-cache.js:103:30)
    at Object.value [as .coffee] (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\compile-cache.js:201:21)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (module.js:483:17)
    at require (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\native-compile-cache.js:50:27)
    at Object.<anonymous> (file:///C:/Users/davidtaylorjr/.atom/packages/atom-beautify/src/beautifiers/index.coffee:6:10)
    at Object.<anonymous> (file:///C:/Users/davidtaylorjr/.atom/packages/atom-beautify/src/beautifiers/index.coffee:1:1)
    at Module._compile (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\native-compile-cache.js:103:30)
    at Object.value [as .coffee] (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\compile-cache.js:201:21)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (module.js:483:17)
    at require (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\native-compile-cache.js:50:27)
    at Object.<anonymous> (file:///C:/Users/davidtaylorjr/.atom/packages/atom-beautify/src/beautify.coffee:9:15)
    at Object.<anonymous> (file:///C:/Users/davidtaylorjr/.atom/packages/atom-beautify/src/beautify.coffee:2:1)
    at Module._compile (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\native-compile-cache.js:103:30)
    at Object.value [as .coffee] (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\compile-cache.js:201:21)
    at Module.load (module.js:473:32)
    at tryModuleLoad (module.js:432:12)
    at Function.Module._load (module.js:424:3)
    at Module.require (module.js:483:17)
    at require (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\native-compile-cache.js:50:27)
    at Package.module.exports.Package.requireMainModule (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\package.js:747:27)
    at Package.module.exports.Package.activateNow (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\package.js:174:16)
    at C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\package.js:827:25
    at Function.module.exports.Emitter.simpleDispatch (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\node_modules\event-kit\lib\emitter.js:25:14)
    at Emitter.module.exports.Emitter.emit (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\node_modules\event-kit\lib\emitter.js:129:28)
    at CommandRegistry.module.exports.CommandRegistry.handleCommandEvent (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\command-registry.js:240:20)
    at C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\command-registry.js:3:59
    at KeymapManager.module.exports.KeymapManager.dispatchCommandEvent (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\node_modules\atom-keymap\lib\keymap-manager.js:587:16)
    at KeymapManager.module.exports.KeymapManager.handleKeyboardEvent (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\node_modules\atom-keymap\lib\keymap-manager.js:382:22)
    at WindowEventHandler.module.exports.WindowEventHandler.handleDocumentKeyEvent (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\window-event-handler.js:106:36)
    at HTMLDocument.<anonymous> (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\window-event-handler.js:3:59)

Commands
     -8:05.1.0 atom-live-server:start-3000 (atom-text-editor.editor.is-focused)
     -0:23.8.0 core:select-all (atom-text-editor.editor.is-focused)
     -0:15 core:backspace (atom-text-editor.editor.is-focused)
     -0:13.4.0 core:save (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "autoHideMenuBar": true,
    "telemetryConsent": "limited",
    "themes": [
      "atom-dark-ui",
      "seti-syntax"
    ]
  }
}

Installed Packages
# User
atom-beautify, v0.29.16 (inactive)
atom-live-server, v1.2.5 (active)
atom-monokai, v0.10.4 (inactive)
auto-detect-indentation, v1.3.0 (active)
bootstrap3-snippets, v0.1.2 (active)
color-picker, v2.2.3 (active)
console-log, v1.9.0 (active)
css-snippets, v1.1.0 (active)
emmet, v2.4.3 (active)
file-icons, v2.0.7 (active)
git-plus, v7.0.4 (active)
git-time-machine, v1.5.4 (inactive)
highlight-selected, v0.11.2 (active)
javascript-snippets, v1.2.1 (active)
linter, v1.11.18 (active)
linter-csslint, v1.3.3 (active)
linter-erb, v1.0.3 (active)
linter-htmlhint, v1.3.1 (active)
linter-javac, v1.9.4 (active)
linter-jshint, v3.0.2 (active)
linter-jsonlint, v1.3.0 (active)
linter-perl, v0.8.0 (active)
linter-php, v1.3.1 (active)
linter-python, v3.0.5 (active)
linter-ruby, v1.2.4 (inactive)
monokai-dark, v1.3.0 (inactive)
pigments, v0.37.0 (active)
seti-syntax, v1.0.1 (active)
atom-dark-syntax, v0.27.0 (inactive)
atom-dark-ui, v0.52.0 (active)
atom-light-syntax, v0.28.0 (inactive)
atom-light-ui, v0.45.0 (inactive)
base16-tomorrow-dark-theme, v1.3.0 (inactive)
base16-tomorrow-light-theme, v1.3.0 (inactive)
one-dark-ui, v1.6.2 (inactive)
one-light-ui, v1.6.2 (inactive)
one-dark-syntax, v1.5.0 (inactive)
one-light-syntax, v1.5.0 (inactive)
solarized-dark-syntax, v1.0.5 (inactive)
solarized-light-syntax, v1.0.5 (inactive)
about, v1.7.0 (active)
archive-view, v0.62.0 (active)
autocomplete-atom-api, v0.10.0 (active)
autocomplete-css, v0.13.1 (active)
autocomplete-html, v0.7.2 (active)
autocomplete-plus, v2.31.4 (active)
autocomplete-snippets, v1.11.0 (active)
autoflow, v0.27.0 (inactive)
autosave, v0.23.1 (active)
background-tips, v0.26.1 (active)
bookmarks, v0.42.0 (active)
bracket-matcher, v0.82.2 (active)
command-palette, v0.39.0 (inactive)
deprecation-cop, v0.54.1 (active)
dev-live-reload, v0.47.0 (active)
encoding-selector, v0.22.0 (active)
exception-reporting, v0.40.0 (active)
find-and-replace, v0.202.2 (inactive)
fuzzy-finder, v1.4.0 (active)
git-diff, v1.1.0 (active)
go-to-line, v0.31.0 (inactive)
grammar-selector, v0.48.2 (active)
image-view, v0.60.0 (active)
incompatible-packages, v0.26.1 (active)
keybinding-resolver, v0.35.0 (active)
line-ending-selector, v0.5.0 (active)
link, v0.31.2 (inactive)
markdown-preview, v0.158.8 (active)
metrics, v1.1.2 (active)
notifications, v0.65.1 (active)
open-on-github, v1.2.1 (inactive)
package-generator, v1.0.1 (inactive)
settings-view, v0.243.1 (active)
snippets, v1.0.4 (active)
spell-check, v0.68.4 (active)
status-bar, v1.4.1 (active)
styleguide, v0.47.2 (active)
symbols-view, v0.113.1 (inactive)
tabs, v0.103.0 (active)
timecop, v0.33.2 (active)
tree-view, v0.210.0 (active)
update-package-dependencies, v0.10.0 (active)
welcome, v0.35.1 (active)
whitespace, v0.35.0 (active)
wrap-guide, v0.38.2 (active)
language-c, v0.54.0 (active)
language-clojure, v0.22.1 (active)
language-coffee-script, v0.48.0 (active)
language-csharp, v0.13.0 (active)
language-css, v0.40.1 (active)
language-gfm, v0.88.0 (active)
language-git, v0.15.0 (active)
language-go, v0.43.0 (active)
language-html, v0.47.1 (active)
language-hyperlink, v0.16.1 (active)
language-java, v0.24.0 (active)
language-javascript, v0.122.0 (active)
language-json, v0.18.3 (active)
language-less, v0.29.6 (active)
language-make, v0.22.2 (active)
language-mustache, v0.13.0 (active)
language-objective-c, v0.15.1 (active)
language-perl, v0.37.0 (active)
language-php, v0.37.3 (active)
language-property-list, v0.8.0 (active)
language-python, v0.45.1 (active)
language-ruby, v0.70.2 (active)
language-ruby-on-rails, v0.25.1 (active)
language-sass, v0.57.0 (active)
language-shellscript, v0.23.0 (active)
language-source, v0.9.0 (active)
language-sql, v0.25.0 (active)
language-text, v0.7.1 (active)
language-todo, v0.29.1 (active)
language-toml, v0.18.1 (active)
language-xml, v0.34.12 (active)
language-yaml, v0.27.1 (active)

# Dev
No dev packages

I would recommend trying this from the command line apm install atom-beautify and let me know how this works out.

That is how I installed it to start. I install everything from CLI
On 1/4/2017 11:55:35 PM, Austin Cheney<EMAIL_ADDRESS>wrote:
I would recommend trying this from the command line apm install atom-beautify and let me know how this works out.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [https://github.com/Glavin001/atom-beautify/issues/1444#issuecomment-270563971], or mute the thread [https://github.com/notifications/unsubscribe-auth/AJ7DfY_X8so_kK1HrCssP9wlpFCc6VPrks5rPHfGgaJpZM4LbUt1].

Would you mind trying one more time to see if it catches any missing dependencies.

at Module._resolveFilename (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\electron.asar\common\reset-search-paths.js:35:12)

at Function.Module._resolveFilename (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\module-cache.js:383:52)

Looking at this it appears to be an Electron issue with this file: https://github.com/electron/electron/blob/master/lib/common/reset-search-paths.js
I recommend you ask over there as it looks to be out of Atom-Beautify's control. Please link back to this issue so others who are experiencing this Electron bug can follow along. Thanks!

Ok I submitted the issue there, hopefully they will figure it out.
On 1/5/2017 11:13:11 AM, Glavin Wiechert<EMAIL_ADDRESS>wrote:
at Module._resolveFilename (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\electron.asar\common\reset-search-paths.js:35:12)
at Function.Module._resolveFilename (C:\Users\davidtaylorjr\AppData\Local\atom\app-1.12.9\resources\app.asar\src\module-cache.js:383:52)
Looking at this it appears to be an Electron issue with this file: https://github.com/electron/electron/blob/master/lib/common/reset-search-paths.js [https://github.com/electron/electron/blob/master/lib/common/reset-search-paths.js]
I recommend you ask over there as it looks to be out of Atom-Beautify's control. Please link back to this issue so others who are experiencing this Electron bug can follow along. Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [https://github.com/Glavin001/atom-beautify/issues/1444#issuecomment-270683262], or mute the thread [https://github.com/notifications/unsubscribe-auth/AJ7DfU_xWmUt0mdMu4mctzb_8DfbX17qks5rPRaOgaJpZM4LbUt1].

@Glavin001 just an update. I did a global install of Winston using NPM and it resolved the issue. Package workign great.

Strange. Glad to hear it is working now though!


⚠ Digital Ocean - https://status.digitalocean.com/ has degraded performance

In a9299c0, Digital Ocean - https://status.digitalocean.com/ (https://status.digitalocean.com/api/v2/status.json) experienced degraded performance:

HTTP code: 200
Response time: 214 ms

Resolved: Digital Ocean - https://status.digitalocean.com/ performance has improved in a96d302 after 1 day.


[BUG] Error adding entities for domain water_heater with platform hive

Describe the bug
Following update to HA 2022.7.2, I've started seeing the following in my logs:
Logger: homeassistant.components.water_heater
Source: custom_components/hive/water_heater.py:78
Integration: Water Heater (documentation, issues)
First occurred: 09:05:32 (2 occurrences)
Last logged: 09:05:32

Error adding entities for domain water_heater with platform hive
Error while setting up hive platform for water_heater
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 397, in async_add_entities
    await asyncio.gather(*tasks)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 457, in _async_add_entity
    if entity.unique_id is not None:
  File "/config/custom_components/hive/water_heater.py", line 78, in unique_id
    return self._unique_id
AttributeError: 'HiveWaterHeater' object has no attribute '_unique_id'

As a result the entity for Hot Water is unavailable.
To Reproduce
Steps to reproduce the behaviour:

Update HA to 2022.7.2

Expected behaviour
Available Hot Water entity, controllable through HA
Screenshots

Desktop (please complete the following information):

OS: Windows 11 Home (build 22000.739)
Browser Microsoft Edge
Version 103.0.1264.49 (Official build) (64-bit)

Additional context
Home Assistant 2022.7.2
Supervisor 2022.07.0
Operating System 8.2
Frontend 20220707.0 - latest
Hive Custom Component 2022.7.1

I'm also seeing this too

Me too

Same here. No Hot Water Entity available.

Please can this be retested 2022.7.2 has been released to address this

I am on core 2022.7.3 and still same. Added in as new from scratch and same result.

Worked for me, water heater in now working fine
HA2022.7.3

Did you remove

Worked for me, water heater in now working fine
HA2022.7.3

What steps did you take to fix it, or you just left it to update to 2022.7.3?
As I removed it on 2022.7.2, added in again and no help. Now Im on 2022.7.3 and same. I wonder should I remove repository from HACS and add as brand new?
Thank you.

I just clicked on update in HACS and restarted

Please can this be retested 2022.7.2 has been released to address this

No change for me on 2022.7.3. If you need any more logs or data give me a shout.

@virtusas have you upgraded trough hacs to hive custom component version 2022.7.2

@virtusas have you upgraded trough hacs to hive custom component version 2022.7.2

Yep. Just now updated, restarted and same :(

@virtusas have you upgraded trough hacs to hive custom component version 2022.7.2

Back in action. Deleted again, redownloaded repository installed as normal. And came back now.
Thank you kindly.

Closing this as the issue seems to be fixed


Add agenda item to discuss renewal criteria for Intubation projects a…

…nd criteria for considering Emeritus status
Requested by @hogstrom
Signed-off-by: John Mertic<EMAIL_ADDRESS>

@hogstrom Can you confirm this captures what you are proposing?

Matt - since you can't make today's meeting should we move to next month's meeting?

Yes please, thanks John.
Matt Hogstrom
<EMAIL_ADDRESS>+1-919-656-0564
PGP Key: 0x90ECB270
Facebook https://facebook.com/matt.hogstrom  LinkedIn https://linkedin/in/mhogstrom  Twitter https://twitter.com/hogstrom
“It may be cognitive, but, it ain’t intuitive."
— Hogstrom

On Oct 11, 2019, at 12:59 AM, John Mertic<EMAIL_ADDRESS>wrote:
Matt - since you can't make today's meeting should we move to next month's meeting?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/openmainframeproject/tsc/pull/66?email_source=notifications&email_token=AAWFPJ3I2CXVWJPCS6UZHVTQN5NQPA5CNFSM4IY6ERH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEA5BXJI#issuecomment-540679077, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWFPJ7LFRKNTJJDCDZMYGDQN5NQPANCNFSM4IY6ERHQ.

Great! Closing this as I've added it to the agenda.


Roll Engine from 86dacc0aad71 to 0cbaa809d5cb (1 revision)

https://github.com/flutter/engine/compare/86dacc0aad71...0cbaa809d5cb
2021-06-17<EMAIL_ADDRESS>Disable Skia reduceOpsTaskSplitting option (flutter/engine#26568)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

AutoRoller is stopped; closing the active roll.


How to replace google-services.json file in the project root before build?

I am currently trying out the Build feature to build my Android app.
I have to replace google-services.json file in the project root folder before the build starts. How do I do that? I tried the following steps:

Added my google-services.json file contents in an Environment Variable in the Build configuration
Wrote an appcenter-pre-build.sh script to read this environment variable's contents and copy them to an empty file and rename it to google-services.json

But, Somehow, I dont see this script getting triggered before the build starts. Can you please let me know if I am missing anything here or please let me know how to solve this.

@prakashvadrevu The comments feature of our documentation is intended to enable customers to suggest changes to the docs or ask clarifying questions about the docs.
App Center support is provided directly from within the App Center portal. Any time you need help, just click the blue chat button in the lower-right corner of any page and our dedicated support team will respond. For additional information, see the App Center Help Center.

Thank you @jwargo! I will ask the support team.


Black screen using remote apps with three monitor setup using /multimon without /span

Describe the bug
With a three monitor setup, using the /multimon flag without using /span produces a black window when accessing a remote app. This occurs no matter what the remote app specified is. The remote app shows correctly when /span is specified with /multimon.
(I noticed this as well with my old dual monitor setup, but you could fix it by either reconnecting or pressing CTRL+SHIFT+ESC to open task manager for a second)
To Reproduce

Run xfreerdp with /app flag, specifying a remote app to open.
Add /multimon flag and execute command (seems to cause an intermittent issue on dual monitors, a permanent issue on triple monitors).

Expected behavior
The remote app window should be shown properly.
Screenshots
Image is of Microsoft Word (but all apps do the same thing):

** Application details

Version of FreeRDP: 2.0.0-rc4
Command line used: xfreerdp /v:servername /u:DOMAIN\\username /p:password /app:"||WINWORD" -sec-nla /multimon
output of /buildconfig:
Build configuration: BUILD_TESTING=OFF BUILTIN_CHANNELS=ON HAVE_AIO_H=1 HAVE_EXECINFO_H=1 HAVE_FCNTL_H=1 HAVE_INTTYPES_H=1 HAVE_JOURNALD_H=TRUE HAVE_MATH_C99_LONG_DOUBLE=1 HAVE_POLL_H=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK=ON HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIB=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK_SYMBOL= HAVE_SYSLOG_H=1 HAVE_SYS_EVENTFD_H=1 HAVE_SYS_FILIO_H= HAVE_SYS_MODEM_H= HAVE_SYS_SELECT_H=1 HAVE_SYS_SOCKIO_H= HAVE_SYS_STRTIO_H= HAVE_SYS_TIMERFD_H=1 HAVE_TM_GMTOFF=1 HAVE_UNISTD_H=1 HAVE_XI_TOUCH_CLASS=1 WITH_ALSA=ON WITH_CCACHE=ON WITH_CHANNELS=ON WITH_CLIENT=ON WITH_CLIENT_AVAILABLE=1 WITH_CLIENT_CHANNELS=ON WITH_CLIENT_CHANNELS_AVAILABLE=1 WITH_CLIENT_COMMON=ON WITH_CLIENT_INTERFACE=OFF WITH_CUPS=ON WITH_DEBUG_ALL=OFF WITH_DEBUG_CAPABILITIES=OFF WITH_DEBUG_CERTIFICATE=OFF WITH_DEBUG_CHANNELS=OFF WITH_DEBUG_CLIPRDR=OFF WITH_DEBUG_DVC=OFF WITH_DEBUG_KBD=OFF WITH_DEBUG_LICENSE=OFF WITH_DEBUG_MUTEX=OFF WITH_DEBUG_NEGO=OFF WITH_DEBUG_NLA=OFF WITH_DEBUG_NTLM=OFF WITH_DEBUG_RAIL=OFF WITH_DEBUG_RDP=OFF WITH_DEBUG_RDPDR=OFF WITH_DEBUG_RDPEI=OFF WITH_DEBUG_REDIR=OFF WITH_DEBUG_RFX=OFF WITH_DEBUG_RINGBUFFER=OFF WITH_DEBUG_SCARD=OFF WITH_DEBUG_SND=OFF WITH_DEBUG_SVC=OFF WITH_DEBUG_SYMBOLS=OFF WITH_DEBUG_THREADS=OFF WITH_DEBUG_TIMEZONE=OFF WITH_DEBUG_TRANSPORT=OFF WITH_DEBUG_TSG=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_WND=OFF WITH_DEBUG_X11=OFF WITH_DEBUG_X11_CLIPRDR=OFF WITH_DEBUG_X11_LOCAL_MOVESIZE=OFF WITH_DEBUG_XV=OFF WITH_DIRECTFB=OFF WITH_DSP_EXPERIMENTAL=OFF WITH_EVENTFD_READ_WRITE=1 WITH_FAAC=OFF WITH_FAAD2=OFF WITH_FFMPEG=OFF WITH_GFX_H264=OFF WITH_GPROF=OFF WITH_GSM=ON WITH_GSSAPI=OFF WITH_GSTREAMER_0_10=OFF WITH_GSTREAMER_1_0=ON WITH_ICU=ON WITH_IPP=OFF WITH_JPEG=ON WITH_KRB5=ON WITH_LAME=OFF WITH_LIBRARY_VERSIONING=ON WITH_LIBRARY_VERSIONING=ON WITH_LIBSYSTEMD=ON WITH_MACAUDIO=OFF WITH_MACAUDIO=OFF WITH_MACAUDIO_AVAILABLE=0 WITH_MANPAGES=ON WITH_MBEDTLS=OFF WITH_OPENH264=OFF WITH_OPENSLES=OFF WITH_OPENSSL=ON WITH_OSS=ON WITH_PAM=ON WITH_PCSC=ON WITH_PROFILER=OFF WITH_PULSE=ON WITH_SAMPLE=OFF WITH_SANITIZE_ADDRESS=OFF WITH_SANITIZE_ADDRESS_AVAILABLE=1 WITH_SANITIZE_MEMORY=OFF WITH_SANITIZE_MEMORY_AVAILABLE=1 WITH_SANITIZE_THREAD=OFF WITH_SANITIZE_THREAD_AVAILABLE=1 WITH_SERVER=ON WITH_SERVER_CHANNELS=ON WITH_SERVER_INTERFACE=ON WITH_SMARTCARD_INSPECT=OFF WITH_SOXR=OFF WITH_SSE2=ON WITH_THIRD_PARTY=OFF WITH_VALGRIND_MEMCHECK=OFF WITH_VALGRIND_MEMCHECK_AVAILABLE=1 WITH_WAYLAND=ON WITH_X11=ON WITH_X264=OFF WITH_XCURSOR=ON WITH_XDAMAGE=ON WITH_XEXT=ON WITH_XFIXES=ON WITH_XI=ON WITH_XINERAMA=ON WITH_XKBFILE=ON WITH_XRANDR=ON WITH_XRENDER=ON WITH_XSHM=ON WITH_XTEST=ON WITH_XV=ON WITH_ZLIB=ON Build type:          RelWithDebInfo CFLAGS:              -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -g -fPIE -pie -DNDEBUG -fPIC -Wall -Wno-unused-result -Wno-unused-but-set-variable -Wno-deprecated-declarations -fvisibility=hidden -Wimplicit-function-declaration -Wredundant-decls -g -DWINPR_DLL Compiler:            GNU, 8.2.1 Target architecture: x64
OS version connecting to: Windows Server 2016 Standard
Log output from a run with /log-level:trace:
xfreerdp_debug.log

Desktop (please complete the following information):

OS: openSUSE Tumbleweed

Additional context
I've tried all the other common fixes for the black screen issue (logging out/back in, /gdi flag, CTRL+SHIFT+ESC, playing around with effects flags, etc.) with no luck.

I'm running into this problem, too. With /multimon and /span on a three monitor system it seems to work, however maximizing always maximizes on the third monitor.
xfreerdp /u:User /v:<IP_ADDRESS> +auto-reconnect +home-drive -wallpaper /app:"C:\Program Files\Microsoft Office\Office16\WINWORD.EXE" /multimon /span

What was the fix for this? I'm experiencing the exact same problem in 2023 (using winapps as an overlay). If I do both /mulitmon and /span then maximizing will maximize the window across all 3 monitors at once


Wifi shield DNS does not resolve on Chrome Android

Bug: openbci-xxxx.local/ does not resolve on Chrome Android but pinging the IP address works.

How do we get zeroconf working on android?


Migrate the existing Google Doc to here

Project
The Maturity Matrix is currently in a Google Doc and we need to migrate the content across to markdown files in this repository
https://docs.google.com/document/d/1wa2lliXQeH6HE1JHqwjTFuVndRUXzxGlbYXRtTQxF5o/edit
Actions

[x] @aecurrie close all open comments
[x] @aecurrie lock Google Doc for further contributions
[ ] Add banner to Google Doc redirecting to GitHub
[x] Identify which content is the actual Maturity Model and which is context
[x] Agree how we are going to store the model content in markdown
[x] Create markdown files from Google Doc

Content has been migrated and GitHub Pages setup: https://green-software-foundation.github.io/green-software-maturity-matrix/gsmm/

Hey @osamajandali could you setup a DNS entry for maturity-matrix.greensoftware.foundation for the GitHub pages site above please?

Hey @russelltrow
I've add the DNS entry, should work now.
FYI, there is a docs template that is pre-configure and pre-styles with GSF branding, you can find it here https://github.com/Green-Software-Foundation/doc-template

@aecurrie could you add a banner to your Google Doc redirecting people to the GSF version please

Banner added to Google doc redirecting here


Properties sanitizer

:bulb: Motivation and Context
Some SDKs have a sanitize_properties method, others property_denylist (which is just a deny list instead of giving the flexibility of adding, redacting, or removing properties).
This is similar to sanitize_properties but as a callback that is run before the event is cached or sent over the wire.
The user can redact, remove, or add any properties.
This would work for automatic events as well since it runs for every single event and not only manually captured events.
The downside is that the user can mess up with properties that may cause a bug on the backend or something.
:green_heart: How did you test it?
:pencil: Checklist

[X] I reviewed the submitted code.
[X] I added tests to verify the changes.
[ ] I updated the docs if needed.
[X] No breaking change or entry added to the changelog.

Personally I like it. I think sanitize properties is the right terminology (certainly as good as any other)

Alright, added tests and updated the usage markdown, will cut a version :)

For context, there was a workaround before:
PostHog.capture("testEvent", properties = mapOf("\$device_name" to "removed"))
This would work for manually captured events, but it'd not work for automatically captured events nor events that don't contain the properties param eg identify.


Enable go mod

It will be better we do a release and github action test.
I've add some simple tests too.
p.s. This cool project should be listed in awesome-go https://github.com/avelino/awesome-go

Looks very reasonable to me, thanks a lot for your contribution

FYI I added a Github workflow to run your tests and made a release as well.


[Fixes #2519] Injected authorizationService typo

Fixes #2519

Hi @rtpHarry, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

@rtpHarry Thanks for the correction.


add ci badge

lgtm

minor point - we usually have the build status above the title - but lgtm either way.


Override settings on project level

I tried to edit my project settings JSON file like this to enable autoformat on save only on this specific project but it does not work.
I think i missed something and i did not write the good identifier... Somebody help me?
project.sublime-project
{
  "settings": {
    "jscsformatter_tools": {
      "format_on_save": true
    }
  }
}

I have never specified plugin specific settings like this on a project level. It is surprising that there seems to be no documentation about this online.
If the format you are showing works, perhaps try "jscs-formatter" : { instead of "jscsformatter_tools": { shrug

The only way I know how to do per-project settings is via an external configuration file (similar to .jscsrc) defined in the project.
You could parse one's .jscsrc and just look for an extra field to dictate the format_on_save value. That's not a great habit to get into (unless all plugin settings are contained within a jscsformatter object). If editor integration spans beyond Sublime Text, this extra setting could be reused.

Closing as this seems like something related to Sublime and not this package specifically


boards: arm: add olimex_lora_stm32wl_devkit

Add board definitions for Olimex LoRa STM32WL DevKit.

The build failure is unrelated to this PR and will be fixed with #47557.

Rebased to fix CI and add partitions to dts.

Hey @martinjaeger, since the device is a module + carrier board I would suggest splitting some of the dts nodes in a module include file, so that a user could include that in a custom board and not have to duplicate the radio frontend and clock config. This is pretty much the same setup as the Seeed E5 module so you may look into it as a reference (https://github.com/zephyrproject-rtos/zephyr/blob/main/dts/arm/seeed/lora-e5.dtsi). What do you think?

I've seen that, but for me it was actually more confusing than helpful. The linked .dtsi basically only contains the LoRa chip part, but not e.g. pin assignments for UART, SPI and other peripherals which would also belong to the module. Also it is in a folder where I'd usually expect SOC devicetree definitions, but not board-related information.
I prefer to have the entire dev kit + module spec in one place, so that one just has to copy one folder and modify it for a custom board.

I've seen that, but for me it was actually more confusing than helpful. The linked .dtsi basically only contains the LoRa chip part, but not e.g. pin assignments for UART, SPI and other peripherals which would also belong to the module. Also it is in a folder where I'd usually expect SOC devicetree definitions, but not board-related information.
I prefer to have the entire dev kit + module spec in one place, so that one just has to copy one folder and modify it for a custom board.

Well but UART/SPI etc do not belong to the module, those pins so happen to be mapped to uart/i2c/spi devices in the specific carrier board but the WL55 has load of options for those pins that a carrier board designer may take. The radio frontend and clock (and the LED in this case I think), on the other hand, are part of the module, so there's no other possible configuration for it that a carrier board designer can take.

Alright, moved the module dtsi part out of the board spec.


overflow-x and overflow-y properties overridden by combining of rules

Just ran into this issue. When given this input:
.item {
    overflow: visible;
    overflow-x: hidden;
}

.item2 {
    overflow: visible;
}

cssnano will produce this output:
.item{overflow-x:hidden}.item,.item2{overflow:auto}

Where the second rule overrides the first one and produces a different result to the unoptimized css.

My output is this, but it's a bug nonetheless:
.item{overflow-x:hidden}.item,.item2{overflow:visible}

I'm fairly sure that this is a duplicate of https://github.com/ben-eb/postcss-merge-rules/issues/13, you may work around by disabling rule merging; {mergeRules: false}.


Add NetCDF3 dtype coercion for unsigned integer types

xr.Dataset.to_netcdf does not seem to support writing data with unsigned integer dtypes, uint32, uint64 etc.. This seems to be the case for both scipy-based output formats, NETCDF3_CLASSIC and NETCDF3_64BIT.
It seems like dtype coercions for int64 and bool are done automatically for NetCDF3 in the xarray.netcdf3 module.
Shouldn't data of signed dtypes then also be coerced, i.e. to their signed equivalent?
MCVE Code Sample

import numpy as np
import xarray as xr

da = xr.DataArray(np.array([1,2,3], dtype='uint64))

# The following all fail:
da.to_netcdf("foo")  # default format: scipy NETCDF3_CLASSIC
da.to_netcdf("bar", format='NETCDF3_64BIT')
da.astype('uint32').to_netcdf("baz")
da.astype('uint16').to_netcdf("spam")

# This works:
da.astype('int64').to_netcdf("working64")  # is coerced
da.astype('int32').to_netcdf("working32")  # works natively

Importantly, this is with the netcdf4 python package not being installed, in which case that package would be used for writing rather than scipy's netcdf.
Expected Output
NetCDF3 file is written with an appropriately coerced data format, e.g. as done with int64.
Alternatively, writing data fails for all dtypes that would natively be unsupported, including int64 and bool.
Problem Description
Given that the infrastructure for coercion is already in place, it seems more consistent to me to apply coercion to all cases where it would lead to to_netcdf method calls succeeding rather than failing, not only to int64 and bool.
Ideally, coercion would happen towards another unsigned integer type.
However, writing uint32 seems not to be possible, so it's not a 64bit/32bit issue.
While the NetCDF Format Specification declares as only unsigned integer type NON_NEG, which I presume to be equivalent to uint32, writing unsigned integers seems not possible via scipy's NetCDF3 writer. Thus, the only viable coercion, as far as I see, would be to signed equivalents.
I see no new cast safety implications here, because the existing coerce_nc3_dtype function already checks if the original and cast arrays compare equivalently.

It seems like extending the _nc3_dtype_coercions dict (and extending tests) is all that needs to be done here?
Suggestion: Add all uint types supported by numpy:
_nc3_dtype_coercions = {
    "int64": "int32",
    "bool": "int8",
    "uint64": "int32",
    "uint32": "int32",
    "uint16": "int16",
    "uint8": "int8",
}

This sounds reasonable to me


[BUG] Connect-PnPOnline not working using a service principal

Notice
Many bugs reported are actually related to the PnP Framework which is used behind the scenes. Consider carefully where to report an issue:

Is the issue related to the cmdlet itself, its parameters, the syntax, or do you suspect it is the code of the cmdlet that is causing the issue? Then please continue reporting the issue in this repo.

I am trying to use:
$connection = Connect-PnPOnline -Url $destinationUrl -ClientId $clientId -ClientSecret $clientSecret -Tenant $tenantId
And get the error:
Parameter set cannot be resolved using the specified named parameters. One or more parameters issued cannot be used together or an insufficient number of parameters were provided.
The documentation I've seem seems to indicate this is all that is needed, so I'm wondering if this is a bug?
Reporting an Issue or Missing Feature
Please confirm what it is that your reporting
Expected behavior
Please describe what output you expect to see from the PnP PowerShell Cmdlets
Actual behavior
Please describe what you see instead. Please provide samples of output or screenshots.
Steps to reproduce behavior
Please include complete script or code samples in-line or linked from gists
$installed = Get-Module -Name PnP.PowerShell -ListAvailable
If (!$installed) { Install-Module PnP.PowerShell }
Import-Module PnP.PowerShell

$destinationUrl = "<SP Site URL>"
$clientId = "<client ID>"
$clientSecret = "<client secret>"
$tenantId = "<tenant ID>"

$connection = Connect-PnPOnline -Url $destinationUrl -ClientId $clientId -ClientSecret $clientSecret -Tenant $tenantId

What is the version of the Cmdlet module you are running?
(you can retrieve this by executing Get-Module -Name "PnP.PowerShell" -ListAvailable)
2.12.0
Which operating system/environment are you running PnP PowerShell on?

[X] Windows
[ ] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

Try without -Tenant parameter, that seems to work for me:


TypeError: Cannot read property 'normalModuleFactory' of undefined

Getting this issue when trying to run webpack after installing the package and adding it to the plugins. Referencing this function compiler.hooks.normalModuleFactory.tap
Webpack version 3.1.0
Webpack-dev-server 2.7.1
Not sure if that is enough context or not.

Hello! This plugin currently requires Webpack 4+.

I misunderstood the webpack 4 requirement based on the peer deps in the project's package.json.  Thanks for clarifying.

@developit
https://github.com/GoogleChromeLabs/worker-plugin/blob/7706c013d59378cda76eb1e9922f07af945fe7f1/package.json#L79
so v3 should work

Apologies, I'd incorrectly indicated webpack@3 compatibility there.  If anyone really needs webpack 3 support, it's been fixed.

Can't figure out what I'm doing wrong here...
λ npm run dev

><EMAIL_ADDRESS>dev C:\Users\[...]\svgproto
> preact watch

TypeError: Cannot read property 'normalModuleFactory' of undefined
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>dev: `preact watch`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>dev script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      C:\Users\[...]\AppData\Roaming\npm-cache\_logs\2019-07-11T06_17_26_947Z-debug.log

C:\Users\[...]\svgproto (master -> origin)
λ npm list webpack
<EMAIL_ADDRESS>C:\Users\[...]\svgproto
+--<EMAIL_ADDRESS>| `-- UNMET DEPENDENCY<EMAIL_ADDRESS>`--<EMAIL_ADDRESS>
npm ERR! missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>
C:\Users\[...]\svgproto (master -> origin)
λ yarn list webpack
yarn list v1.16.0
warning Filtering by arguments is deprecated. Please use the pattern option instead.
├─<EMAIL_ADDRESS>│  └─<EMAIL_ADDRESS>└─<EMAIL_ADDRESS>Done in 0.79s.

so what the solution for this ?

Looks like you need to upgrade webpack.


refactor ipsec function

Pull Request

[ ] Make sure you have followed Kube-OVN Code Style.

What type of this PR
Examples of user facing changes:

Features

Bug fixes

Docs

Tests

Which issue(s) this PR fixes
Fixes #(issue-number)

Could you lease add an e2e test case for this feature? I'm working on security: run as non-root user, which may break this function.

Could you please add an e2e test case for this feature? I'm working on security: run as non-root user, which may break this function.

e2e case will be added

@changluyi 大佬，我感觉有些err log 还是就近打印更好些，后面有空麻烦补充下


added support for VNC Authentication using OpenSSL

This pull request is a mixture of more or less unrelated topics:

cmake
clang-format
Win32 fix
VNC Authentication
...

Could you please split this pull request so that the different topics can be discussed and decided separately ?

Concerning password/servername: bot are global settings and can't differ between servers or clients - at least not with the implementation provided. Then I would prefer not to copy them to every instance and use the getter of the VNC namespace, when needed.


Turn on skipLibCheck for js-only inferred project and external project

Fixes #8947

The drawback of implementing this approach in updateGraph is that there are no way to override this behavior. Specifically setting skipLibCheck will not work.
The alternative approach is to run this logic in each place updateGraph is called, which might be messier code but we do know when to honor the given options and when to use the default value.

Pinging @mhegazy @vladima


ctrl-z doesn't undo anymore

ctrl-z doesn't undo anymore but ctrl-y does now.
My keybindings are set to ctrl-z

My keymap file is empty.
The issue persists if I run atom in safe mode.
I also deleted my .atom folder and the issue is still there.
I'm runnning atom on arch linux
$ atom --version
Atom    : 1.12.7
Electron: 1.4.12
Chrome  : 53.0.2785.143
Node    : 6.5.0

Unfortunately I cannot tell you how to reproduce the issue because it was all of a sudden there (I didn't update atom, I didn't reboot my system, I was working on a project and all of a sudden ctrl-z didn't work anymore).
In any other program ctrl-z still works so it's not a system wide problem.

Electron : 1.4.12

Thanks for reaching out!
We've determined that this issue is being caused by the use of an unofficial build or distribution of Atom. Often these customized versions of Atom are modified versions of the Stable branch of Atom with mismatched versions of built-in components. These updated components are taken from the Beta channel or master branch and then injected into the Stable version and a new Atom package is generated. Because of the way Atom is constructed, using these mismatched components can cause mysterious and hard-to-diagnose problems. You can find out more about why we chose to not support unofficial distributions here.
You may want to subscribe to https://bugs.archlinux.org/task/50357 for updates.


Response behaviour with model which has several extends sub models

Information

Version: 5.6
Type: Issue

Description
Hi,
I have a model A with properties a1, a2
I have a model B which extends Model A with properties b1, b2
I have a model C which extends Model B with properties c1, c2
When I return an array of object of Model C, I got only properties of Model A and B.
If I use Express legacy method res.json(obj), I got all expected properties.
Is someone already got this behaviour ?
Thanks

hello @nirio69510
Did you use @Property decorator over each property ?
Here the doc about models: http://tsed.io/docs/model.html#example
See you,
Romain :)


Toggle task status will broken the reference id

Normally it should be like this:

But with toggle list plugin:

Yes, the current version will cause this issue. I will add this feature in the next version.

Hey, version 1.2.3 now includes this feature. Please let me if it functions properly for you.

Hey, version 1.2.3 now includes this feature. Please let me if it functions properly for you.

It's working perfectly now, thank you~~


Report data sources

Implemented #80 - summarize provenance on init.
Prints a summary of data sources on initialization, so that analyses using the cohort data are earmarked with the version of data used for analysis.

LGTM! Merge away on Travis 📗

Coverage increased (+0.8%) to 59.688% when pulling 1ef740d492b19515484646be1f1346568898c1f6 on report-coverage into 44a00594b159b961d41b9dd1ee8fab007113f2f9 on master.


chore: Add page load trace with resource, paint and navigation spans

Description
Implemented a page load performance tracking system using telemetry, capturing key metrics such as Largest Contentful Paint (LCP) and First Contentful Paint (FCP).
Enhanced telemetry data to include browser information and unique session IDs for improved diagnostics.
Fixes #Issue Number
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation
/ok-to-test<EMAIL_ADDRESS>:mag: Cypress test results

[!TIP]
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10130813688
Commit: 96203a27dc7ec2e7c50f5efd0b5bfa02624388bb
Cypress dashboard.
Tags: @tag.Sanity
Spec:
Sun, 28 Jul 2024 10:30:54 UTC

Communication
Should the DevRel and Marketing teams inform users about this change?

[ ] Yes
[ ] No

Summary by CodeRabbit
Summary by CodeRabbit

New Features

Implemented a page load performance tracking system using telemetry, capturing key metrics such as Largest Contentful Paint (LCP) and First Contentful Paint (FCP).
Enhanced telemetry data to include browser information and unique session IDs for improved diagnostics.

Improvements

Updated New Relic agent to utilize more advanced performance monitoring features, enhancing application insights by tracking page view events.

Bug Fixes

Resolved type definition issues associated with the integration of the new New Relic agent configuration.

/build-deploy-preview skip-tasks=true

@dvj1988 Is the pageLoad telemetry disabled for self hosted instances and can be conditionally switched on for it ?

@dvj1988 Is the pageLoad telemetry disabled for self hosted instances and can be conditionally switched on for it ?

Yes, This is implemented as a plugin to our OTLP implementation. So when we switch on OTLP the page load metrics also will get enabled.


fixup the bpfman-csv

Fixup the csv file
Move the custom SCC into each application since the CSVs do not support holding the SCC type unfortunately

see https://github.com/operator-framework/operator-lifecycle-manager/issues/2847

Close in favor of https://github.com/bpfman/bpfman-operator/pull/19


Release 2.0.0

@rultor release it; the tag is 2.0.0.

@rultor release it; the tag is 2.0.0.

@rafamizes OK, I will release it now. Please check the progress here

@rultor release it; the tag is 2.0.0.

@rafamizes Done! FYI, the full log is here (took me 2min)

Thanks, Brow!


Update to support angular 1.3

The current library supports 1.2. Now that angular 1.3 is out officially, would be great to get it working on angular 1.3.

The biggest issue is what @bensquire is referring to about the modal backdrops not having their backdrop.

@bensquire , @ilanbiala it is an issue related to bootstrap 3.3, as mentioned on #2925 here is a quick workaround:
.modal-backdrop{
bottom: 0
}

There seems to be a problem with placement/position of  tooltips, and popovers. It has something to do with the changes to angular.isDefined which works differently in AngularJS 1.2 & 1.3
Here are a few directives to patch the issues by setting defaults
        // Bootstrap UI fixes after upgrading to Angular 1.3
        .directive('tooltip', function() {
            return {
                restrict: 'EA',
                link: function(scope, element, attrs) {
                    attrs.tooltipPlacement = attrs.tooltipPlacement || 'top';
                    attrs.tooltipAnimation = attrs.tooltipAnimation || true;
                    attrs.tooltipPopupDelay = attrs.tooltipPopupDelay || 0;
                    attrs.tooltipTrigger = attrs.tooltipTrigger || 'mouseenter';
                    attrs.tooltipAppendToBody = attrs.tooltipAppendToBody || false;
                }
            }
        })

        .directive('popover', function() {
            return {
                restrict: 'EA',
                link: function(scope, element, attrs) {
                    attrs.popoverPlacement = attrs.popoverPlacement || 'top';
                    attrs.popoverAnimation = attrs.popoverAnimation || true;
                    attrs.popoverPopupDelay = attrs.popoverPopupDelay || 0;
                    attrs.popoverTrigger = attrs.popoverTrigger || 'mouseenter';
                    attrs.popoverAppendToBody = attrs.popoverAppendToBody || false;
                }
            }
        })

a billion

:+1:

+1

@antoinepairet or one of the project maintainers, can you please lock this ticket to prevent the "+1" noise? I'd like to subscribe to this issue to track progress, but the "+1" messages add nothing to the conversation.

Keep an eye out for the 0.13 release @robbyt. We're working around the clock to address all 1.3 related issues.
We cannot prevent comments in an issue thread.

Just FYI, after upgrade Bootstrap to v3.3.4 for CSS ONLY, the modal-backdrop issue goes away automatically, for more: twbs/bootstrap#15881

The pagination control from angular bootstrap ui does not work with angular 1.3. Any thoughts on this ?

@AnirbanKundu - being worked on.

I solved the issue by taking the templates from ui-bootstrap-tpls and loading all templates  into a templateCache in a separate module. In that way, I had complete control of the html templates and injected few styles wherever required.

What do you think about shipping a pre-release for 0.13.0, e.g., 0.13.0-beta.1?
I'm currently using the latest release (0.12) with angular 1.3 and the overall experience is quite bad. The current master seems to play nicely with angular 1.3 already. If there are still a few issues/PRs: no worries, it's a pre-release – that's what developers should expect! :smiley:

+1 for @andrenarchy's suggestion.

+1

Ill discuss this with the rest if the team and see what we can do.

+1 for @andrenarchy's suggestion here aswell.

@rvanbaalen good! Publishing a pre-release may also decrease the continuous inflow of (duplicate) issues for 0.12. Most of them are probably fixed already in the master branch but it's not easy to use the master branch in a bower/npm-based project (since you have to build it manually).

For future releases we will consider publishing beta's and so on. Right now we're so close to releasing 0.13 (just 8 issues to go) that it doesn't make sense to go through the process of releasing a beta.

I can only spot 1 open issue for 0.13 right now: this one! \o/
Good to hear that you plan to publish pre-releases in the future.

Nice! Can we expect 0.13 before the end of the weekend?

That depends on what we're all doing this weekend ;-) but I suppose it's safe to say you can expect it before the end of next week.

That is great news -- thank you! One more question: when Angular 2 goes RTM, will ui-bootstrap keep being maintained for Angular 1.x as long as Angular 1 has new releases?

We still have to discuss such plans. It is quite some work to maintain two different repos as you can imagine. But given our huge community I would say there is no way around it :wink:
Note that this is just my opinion and not the one of the team. We will publicly discuss this matter when the time comes.

This email was sent from my iPhone and therefore subject to typos and other inaccuracies.

On 2 mei 2015, at 09:38, dcominottim<EMAIL_ADDRESS>wrote:
That is great news -- thank you! One more question: when Angular 2 goes RTM, will ui-bootstrap keep being maintained for Angular 1.x as long as Angular 1 has new releases?
—
Reply to this email directly or view it on GitHub.

0.13.0 is now released. Closing. :smile:

+1

Awesome! Is anyone of the core team living in Berlin so I can buy you a beer/coffee/...? :smile:


containerized-lifecycle-3.1/4.11-visual-studio-tools-for-docker

Summary
Update images to VS 2019

Referenced consolidated PR addresses these changes. Closing this now. Feel free to reopen if you find any discrepancies.


Allow custom component to adjust allowed children

Hello,
In the linter it loops over each component (such as mj-column) and confirms that the component is allowed to be there.
But from what I can see there doesn't seem to be a way to say mj-custom-component is allowed to be placed inside a mj-column.
It would be nice if there was a way to this child could be part of what parents, rather then what children a parent can have.
Thanks,

It would be a bit confusing API wise to support both way IMO ?

Is there anyway to edit the existing components? Like can I add components to mj-column "registry"?

When you call the function it will append it to currently registered dependencies

@iRyusa which function are you referring to?
registerComponent(MjImageHover)

That one?

 Let's call this solved, my apologies I did not see this before. I think this method is perfectly fine.


Fix testnet/mainnet config to reflect the correct celes/uceles units

Currently, our deployment of BDJuno uses celes and uceles interchangeably. This is due to a confusion in the devnet-2 genesis file generation, where the units are not properly defined.
In upcoming networks, we will have a correct genesis and thus the configuration in the README will need to be updated to reflect the correct changes.

done


Openplanner.1.15 OpenDrive import feature

Added an importer for basic OpenDrive Maps.
An tested example map is given in this repository:
https://github.com/arminstr/map_resources

Moved to 1.15.opendrive branch.


Strict error

I am not sure if this is the same as issue #1 but when I do the following:
use const nspl\args\string;
use function nspl\args\expects;

expects(string, 1);

I get:
PHP Strict error:  Only variables should be passed by reference

Thanks, this is fixed. I also turned on E_STRICT for the test to not miss similar errors in future.


Pass string to setAuthConfig instead of a file (path)

I have a situation where I can not pass a file to setAuthConfig. Curently this is required as setAuthConfig is doing a file_exist on the input. I am working in a docker environment and it would really be a nice feature if I could pass the authentication key as a (base64) encoded string. This way we can load the key through an environment variable without the need of saving the key in a file on the server.

this can be closed as you can also pass an array to setAuthConfig.  My bad...

In php how can i format the json object to an array that will be accepted.  I have the same issue, I do not wish to write a file, rather I have it in string variable.    Ive tried a few things, and could use a pointer on what the Array must be like using php.     using a json credentials file from disk, all connects fine, but when converting to using the variable value version converted to var_dumps .. json_decode... i am getting file not found, or attribute does not match.

json_decode('json string', true)