[FLINK-12141] [API/Type Serialization System] Allow @TypeInfo annotation on POJO field declarations

What is the purpose of the change
Allow @TypeInfo annotation on POJO field declarations.
Brief change log

*allow @TypeInfo annotation on POJO field *
add a testcase in TypeInfoFactoryTest.java
change the function analyzePojo to make it can analyze POJO field  with @TypeInfo annotation

Verifying this change
This change is already covered by existing tests, such as TypeInfoFactoryTest.
This change added tests and can be verified as follows:
testWithFieldTypeInfoAnnotation

Added unit test for POJO field declarations with @TypeInfo annotation

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving):  no
The serializers: yes
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper:  no
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? yes
If yes, how is the feature documented? JavaDocs

@flinkbot approve-until consensus

@twalthr it would be great to merge this PR if you think the changes are good.
To me it looks good, but I am much less experienced with the type system.

@flinkbot approve consensus

I went ahead and rebased this commit onto the latest master. I also improved a few things such as:

reduce code duplication with the existing TypeInfoFactory handling (this also adds a couple of validity checks for the annotation and the type that the TypeInfoFactory returns)
extended the tests (overriding a class-defined TypeInfoFactory works, types without generics work)

I would consider this my review, but if any of the people involved in this thread wants to take a second look that would be great.


Google Maps Marker labelOrigin option is missing

I try to set the label position to make it displayed above the marker icon in Google Maps but it seems this option is missing from current version.
What I want to setup is something like this in plain javascript:
var marker = new google.maps.Marker({
	position:{lat: item.lat, lng:item.lng},
	label: {
		text: item.phone,
		color: '#000',
		fontWeight: 'bold',
		fontSize: "11px"
	},
	icon:{
		url: "/images/final_images/hotline.png",
		labelOrigin: new google.maps.Point(22, -8)
	}
});

labelOrigin allows us to set the label position. Please show me guide to add this option in angular-maps package.
Thanks and best regards,
Dat

I have fixed this issue myself. The solution is set it up like this:
<x-map #xmap id="sos-map-container" [Options]="mapOptions">
        <x-cluster-layer [GridSize]="150" [ClusteringEnabled]="true"
                         [UseDynamicSizeMarkers]="true"
                         [DynamicMarkerBaseSize]="18"
                         [DynamicMarkerRanges]="clusterColorRanges" >
            <x-map-marker
                *ngFor="let marker of markers | keyvalue"
                [Latitude]="marker.value.location.latitude"
                [Longitude]="marker.value.location.longitude"
                [Title]="marker.value.label"
                [IconUrl]="{url: marker.value.icon, labelOrigin: labelPosition}"
                [Label]="marker.value.label"
                (MarkerClick)="showTeamMembers($event, marker.value.data)">
          <x-map-marker>
....

The key is [IconUrl] can be an object, not just an url.


Fix parse error in Catalog Items tree

options is not defined, should be @type
@martinpovolny ..well, this is it :)

@himdel : thx!

close in favor of #3255


Turn off monitor via alexa and GPIO relay

Hello
I would like to use your module to turn off the monitor via a relay connected to the raspberry GPIO with a notification or command via alexa.
I thought about installing the MMM-PIR-Sensor module but I can't figure out how to notify the module to activate the relay.
Is it possible to do this?
Thank you

Hello
the MMM-PIR-Sensor module doesn't describes it but according to the main file the monitor should wake up when you send the notification SCREEN_WAKEUP.  If you use that I think you should define a delay after that the monitor turns off. That should work but I can't test it.

Hello
the MMM-PIR-Sensor module doesn't describes it but according to the main file the monitor should wake up when you send the notification SCREEN_WAKEUP.  If you use that I think you should define a delay after that the monitor turns off. That should work but I can't test it.


Add minifier

https://github.com/nearform/node-clinic-bubbleprof/blob/master/debug/visualize-all.js needs to generate the debug output.

PTAL

Comment addressed.


Spelling Error

"RefreshReuested" should be "RefreshRequested"
Refreshing
When the user releases the visualiser past the threshold, it's in the Refreshing state.
When this state is entered, the RefreshReuested event is raised. This is the signal to start the app's content refresh. The event args (RefreshRequestedEventArgs) contain a Deferral object, which you should take a handle to in the event handler. Then, you should mark the deferral as completed when your code to perform the refresh has completed.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 72402dbb-b344-ad50-4c8d-7a36e00e59e3
Version Independent ID: 1176d342-0cfd-3c26-a71b-7f0c69a0e511
Content: Pull-to-refresh - UWP app developer
Content Source: windows-apps-src/design/controls-and-patterns/pull-to-refresh.md
Service: unspecified
GitHub Login: @jwmsft
Microsoft Alias: jimwalk

Fixed. Thanks for reporting the error.


API publish can be done with invalid endpoint url

Description:
API publish can be done with the invalid endpoint url for sandbox and production.
Suggested Labels:
Product Scenario
Affected Product Version:
APIM 2.6
OS, DB, other environment details and versions:
DB: H2
Steps to reproduce:

Design API in API publisher
Implement API with invalid production or sand box endpoint url (Ex: testurl)
Publish the API

Closing the issue as this is older than 3 years. Please reopen if the issue is valid still.


Why does wait() throw?

Why does wait throw an error or return a value instead of returning a result? This makes it very hard to use wait while continuing to process signals.

wait() was supposed to be the end of a chain of async transforms - kind of a bridging between Interstellar and the usual Swift error handling, just as flatMap also takes a throwing function to get into the Interstellar world. Do you see any use case for waiting and then continuing to process something?

I think an example of usage would come in very handy. I understand how it works now but it took me a while to get it.


Heroku example does not work in Firefox

Getting a TypeError: this.getDOMNode(...).parentNode.createShadowRoot is not a function when loading the page.
http://caniuse.com/#feat=shadowdom
Might need to detect and use webkitCreateShadowRoot() instead as seen here:
http://soledadpenades.com/2014/01/02/shadow-dom-in-firefox/
Edit: looks like Firefox Nightly with a flag is required to use :(

Will definitely add that :+1: although I would also recommend using the WebComponents polyfill, which should make ReactShadow available in all browsers.
If you're interested in React + WebComponents, maybe you'd also like Maple that I created after ReactShadow, which covers a lot of the downfalls in this module – albeit more complex.


Can't start dev server - babel-preset-react error

Bug Report
Installed Docz. Created MDX file. Ran Docz dev. Receive error.
To Reproduce

Clone my repo

npm run docs

Install Docz npm i docz -D on pre-existing project

Add to scripts package.json

Ran docz dev

Loads nearly completely

See error

Module build failed (from ./node_modules/happypack/loader.js):
Error: Plugin/Preset files are not allowed to export objects, only functions. In /Volumes/WEEDPORNDAILY/Development/React/design-syste
m-jss/node_modules/babel-preset-react/lib/index.js
    at createDescriptor (/Volumes/WEEDPORNDAILY/Development/React/design-system-jss/node_modules/@babel/core/lib/config/config-descrip
tors.js:178:11)
    at items.map<EMAIL_ADDRESS>:109:50)
    at Array.map (<anonymous>)
    at createDescriptors (/Volumes/WEEDPORNDAILY/Development/React/design-system-jss/node_modules/@babel/core/lib/config/config-descri
ptors.js:109:29)
    at createPresetDescriptors (/Volumes/WEEDPORNDAILY/Development/React/design-system-jss/node_modules/@babel/core/lib/config/config-descriptors.js:101:10)
    at passPerPreset (/Volumes/WEEDPORNDAILY/Development/React/design-system-jss/node_modules/@babel/core/lib/config/config-descriptors.js:58:96)
    at cachedFunction (/Volumes/WEEDPORNDAILY/Development/React/design-system-jss/node_modules/@babel/core/lib/config/caching.js:33:19)
    at presets.presets (/Volumes/WEEDPORNDAILY/Development/React/design-system-jss/node_modules/@babel/core/lib/config/config-descriptors.js:29:84)
    at mergeChainOpts (/Volumes/WEEDPORNDAILY/Development/React/design-system-jss/node_modules/@babel/core/lib/config/config-chain.js:315:26)
    at /Volumes/WEEDPORNDAILY/Development/React/design-system-jss/node_modules/@babel/core/lib/config/config-chain.js:278:7
    at buildRootChain (/Volumes/WEEDPORNDAILY/Development/React/design-system-jss/node_modules/@babel/core/lib/config/config-chain.js:68:29)
    at loadPrivatePartialConfig (/Volumes/WEEDPORNDAILY/Development/React/design-system-jss/node_modules/@babel/core/lib/config/partial.js:57:55)
    at Object.loadPartialConfig (/Volumes/WEEDPORNDAILY/Development/React/design-system-jss/node_modules/@babel/core/lib/config/partial.js:82:18)
    at Object.<anonymous> (/Volumes/WEEDPORNDAILY/Development/React/design-system-jss/node_modules/docz-core/node_modules/babel-loader/lib/index.js:105:26)
    at Generator.next (<anonymous>)
    at step (/Volumes/WEEDPORNDAILY/Development/React/design-system-jss/node_modules/docz-core/node_modules/babel-loader/lib/index.js:3:221)

 @ multi<EMAIL_ADDRESS>./.docz/app/index.jsx

Here's a link to my repo's Docz branch:
https://github.com/whoisryosuke/design-system-jss/tree/feat/docz
Expected behavior
Dev server to actually run.
Environment

OS: OSX 10.13.4
Node/npm version: Node 9 / NPM 6.4.0

Additional context/Screenshots
I ended up at this issue:
https://github.com/pedronauck/docz/issues/300
I noticed that I didn't have the latest version of Babel (like recommended by some users). I replaced my old Babel with all Babel 7 packages, and I still received the error.

@whoisryosuke this happen because we have some babel plugin/preset that's using an older version of babel, deleting your node_moduels or yarn.lock can resolve this maybe... If this doesn't fix your bug, try to see if the version of your babel-preset-react is using babel 7 🙏

@pedronauck Good advice. Fixed it!

Nuked node_modules
npm i
And probably the coup-de-grace: Updating .babelrc with the new preset definitions (@babel/preset-env vs env).


Intermittent issue seen on SPARC platform with test ipc_send_recv_pipe

Version: 1.42.0
Platform: SunOS 5.11 <IP_ADDRESS>.0 sun4v sparc non-virtualized

While testing libuv on SPARC (SPARC-T4-2) running Solaris 11.4
test ipc_send_recv_pipe is seen to intermittently fail.
Versions tested include v1.41.0, v1.41.1 and v1.42.0.
The stack trace on failure is:
(dbx) where
current thread: t@1
  [1] __lwp_sigqueue(0x0, 0xa00bcbd6fb0, 0x6, 0x0, 0xffffffffffffffff, 0x0), at 0x7fffff0e26b0
  [2] raise(0x6, 0xffffffff7fff8750, 0x5, 0x5, 0x0, 0x0), at 0x7fffff02ba64
  [3] abort(0x1, 0x1210, 0x0, 0x1000, 0x7fffff224000, 0x9b), at 0x7ffffeffaa24
=>[4] read_cb(handle = 0x1003624f0, nread = <value unavailable>, rdbuf = <value unavailable>) (optimized), at 0x1000bbd20 (line ~323) in "test-ipc-send-recv.c"
  [5] uv__read(stream = 0x1003624f0) (optimized), at 0x7ffff1533d6c (line ~1192) in "stream.c"
  [6] uv__stream_io(loop = <value unavailable>, w = 0x100362578, events = 8U) (optimized), at 0x7ffff153410c (line ~1316) in "stream.c"
  [7] uv__io_poll(loop = 0x7ffff1700140, timeout = -1) (optimized), at 0x7ffff153be9c (line ~311) in "sunos.c"
  [8] uv_run(loop = 0x7ffff1700140, mode = UV_RUN_DEFAULT) (optimized), at 0x7ffff151f1c0 (line ~389) in "core.c"
  [9] run_ipc_send_recv_helper(loop = <value unavailable>, inprocess = <value unavailable>) (inlined), line 398 in "test-ipc-send-recv.c"
  [10] ipc_send_recv_helper() (optimized), line 410 in "test-ipc-send-recv.c"
(dbx)

Note that:

attempts to truss(1) the test cause it to pass.
intermittent is between 30-50% of the time when running the test
in a loop on a system that is quiescent.

Looking into a possible cause I believe the issue is with the test itself.
As the stack shows, uv_read called the test's call-back function;
the specific line is src/unix/stream.c'uv__read:1192, shown here with some context:
    1162          if (!is_ipc) {
    1163        do {
    1164          nread = read(uv__stream_fd(stream), buf.base, buf.len);
    1165        }
    1166        while (nread < 0 && errno == EINTR);
    1167      } else {
    1168        /* ipc uses recvmsg */
    1169        msg.msg_flags = 0;
    1170        msg.msg_iov = (struct iovec*) &buf;
    1171        msg.msg_iovlen = 1;
    1172        msg.msg_name = NULL;
    1173        msg.msg_namelen = 0;
    1174        /* Set up to receive a descriptor even if one isn't in the message */
    1175        msg.msg_controllen = sizeof(cmsg_space);
    1176        msg.msg_control = cmsg_space;
    1177
    1178        do {
    1179          nread = uv__recvmsg(uv__stream_fd(stream), &msg, 0);
    1180        }
    1181        while (nread < 0 && errno == EINTR);
    1182      }
    1183
    1184      if (nread < 0) {
    1185        /* Error */
    1186        if (errno == EAGAIN || errno == EWOULDBLOCK) {  /* SJM Yes, errno 11 : EAGAIN */
    1187          /* Wait for the next one. */  /* SJM does it really wait? */
    1188          if (stream->flags & UV_HANDLE_READING) {  /* SJM, yes this flag is set */
    1189            uv__io_start(stream->loop, &stream->io_watcher, POLLIN);  /* SJM Does not appear to wait */
    1190            uv__stream_osx_interrupt_select(stream); /* SJM NOP */
    1191          }
    1192          stream->read_cb(stream, 0, &buf);    /* <---- SJM */

Thus we can deduce that uv__recmsg() / recvmsg() returned a negative
result and the errno was 11, EAGAIN (which on Solaris is the same as
EWOULDBLOCK).  The call to stream->read_cb (uv_read_cb) as shown
explicitly passes in nread as 0.
Documentation (uv_stream_t — Stream handle — libuv documentation) states
This is equivalent to EAGAIN or EWOULDBLOCK under read(2).

The call-back routine does not check for nread == 0, and so erroneously
continues until an assertion is hit.
Modifying the test to simply return when nread == 0 prevents assertions,
and the test passes.  Though I have not confirmed that it the right
solution and seek advice or confirmation.
Thanks.

Your analysis sounds right. Does this diff fix the flakiness?
diff --git a/test/test-ipc-send-recv.c b/test/test-ipc-send-recv.c
index 12d4e332..18e8d2e2 100644
--- a/test/test-ipc-send-recv.c
+++ b/test/test-ipc-send-recv.c
@@ -309,7 +309,9 @@ static void read_cb(uv_stream_t* handle,
   }

   pipe = (uv_pipe_t*) handle;
-  do {
+  ASSERT_EQ(pipe, &ctx2.channel);
+
+  while (uv_pipe_pending_count(pipe) > 0) {
     if (++read_cb_count == 2) {
       recv = &ctx2.recv;
       write_req = &ctx2.write_req;
@@ -318,10 +320,6 @@ static void read_cb(uv_stream_t* handle,
       write_req = &ctx2.write_req2;
     }

-    ASSERT(pipe == &ctx2.channel);
-    ASSERT(nread >= 0);
-    ASSERT(uv_pipe_pending_count(pipe) > 0);
-
     pending = uv_pipe_pending_type(pipe);
     ASSERT(pending == UV_NAMED_PIPE || pending == UV_TCP);

@@ -344,7 +342,7 @@ static void read_cb(uv_stream_t* handle,
                   &recv->stream,
                   write2_cb);
     ASSERT(r == 0);
-  } while (uv_pipe_pending_count(pipe) > 0);
+  }
 }

 static void send_recv_start(void) {

There are probably more places in the test suite where we don't anticipate nread == 0.

Thanks for confirmation.  I applied your patch and confirm it does
address the issue.
Ran the test through a couple of thousand times and no errors seen.
ipc_send_recv_pipe 2>&1 >> log || (( e++ )); done; print $e
0
$

--
Stace


Report listener count to root node to display accurate stat in extension

There are 2 ways this could be implemented.

Could just get node count from tree from signalling server. This is pretty straightforward

Could just have each node report its client count to parent and root node would get the total count recursively. This is better for a more decentralized approach but more complex to implement than simply returning tree size from backend

same as #172


[Wind Waker HD] Added Picto-Box workaround

Added workaround for 'Lenzo's Research Assistant' quest. Lezlo will now accept any picture shown. Works with USA and EUR versions.

Oh, this is awesome! What did you meant with the readme though? Loadline shouldn't be any different then the wud copies, and there aren't any updates. Just curious.


Plunker Demo

It would be great if you can provide demo on plunker, thanks :)

I know I am working on it :-)

I have managed to create a simple demo.
I would really appreciate some help with it, but for now it is OK.
http://plnkr.co/edit/bUVVQu

Great news ! How i can help you ?

@sireneweb if you know how to fix the issues I have mentioned in other post:

moment library can not be used in app.ts
datetimepicker dirty import is required for library to be imported

it would be most helpful 👍


ext_event example panics on linux

Here is the error message:
DEBUG [druid::localization] available locales [fr-CA, de-DE, en-US], current en-US
DEBUG [druid::localization] resolved: [en-US]
INFO  [druid_shell::platform::gtk::application] gtk: Activated application
thread '<unnamed>' panicked at 'GDK may only be used from the main thread.', <::std::macros::panic macros>:2:4

Can confirm on Manjaro GNU/Linux with GTK 3.24.14 on master (currently 000d554cdd06887c750658794dfe97495ff70362)
Backtrace: https://gist.github.com/ForLoveOfCats/7146f826205937ed7a2738d4c84a992b

I think this might be a bug in gtk-rs. Looking at the source, it seems like we're correctly calling the function that maps to gdk_threads_add_idle (see https://developer.gnome.org/gdk3/stable/gdk3-Threads.html) but there seems to be an overly aggressive assert that we're on the main thread, even though I believe the threads functions don't require that.
File an issue on gtk-rs, and they can either confirm my analysis, or tell us what we're doing wrong? This seems like something that other people are likely to have bumped into.

this is fixed in #550, just waiting on review.


Scroll speed too fast on macbook

Scrolling on mac is way too fast. Scrolling 1cm on the touchpad brings you to the bottom of the page. I haven't tested this with a mouse or on windows so the problem might happen there too.
I am using a macbook air 2012 (mavericks)

pretty bump :)

Hi
I think this problem has been caused by that delta value is not worked to scroll event.
The easiest solution is to reflect the scroll speed to the scroll event by adding delta_x and delta_y to InputEventMouseButton.
For exmaple,
v_scroll->set_val( v_scroll->get_val()+(v_scroll->get_page()/8)*delta_y );
However, the mouse button events and the mouse scroll events is different originally.
So, I think the best solution is to add the InputEventMouseWheel that has delta_x and delta_y, and replacing all the scroll events.

Hi guys,
I'm not sure if I did it right, but the way I fixed this issue is simply by adding line which detects if the editor runs in hidpi and, if so, then the scroll value is adjusted. Basically I have to do it for each control which uses scroll, so it feels more like a hack than a real solution, but if you can confirm that it is a good enough way to fix this, I can write those lines and submit.

the problem is that if you connect a mouse, it works properly so I don't
want to change any code.
If OSX has a delta value for these events, we could implement some sort of
accumulator and convert it to scroll events
On Sun, Jun 26, 2016 at 8:39 AM, UgisBrekis<EMAIL_ADDRESS>wrote:

Hi guys,
I'm not sure if I did it right, but the way I fixed this issue is simply
by adding line which detects if the editor runs in hidpi and, if so, then
the scroll value is adjusted. Basically I have to do it for each control
which uses scroll, so it feels more like a hack than a real solution, but
if you can confirm that it is a good enough way to fix this, I can write
those lines and submit.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/492#issuecomment-228597044,
or mute the thread
https://github.com/notifications/unsubscribe/AF-Z20LIgA6zAwCzGxfNRjEkHYT97wHDks5qPmT-gaJpZM4CBZQD
.

Ok, I see. Since I'm a stack overflow kinda coder it's out of my league, but still I'll take a look. Thanks for the hint!

Not critical for the upcoming 2.1, so moving to the next milestone.

Fixed by 304a1f5.

I still have this problem with the latest Version 1.16.0 (1.16.0) even though I had set trackpad's scrolling speed slower.

the scrolling is just like "scrolling - on" and "scrolling - off". No matter how fast you actually scroll on your touch pad, the speed at wich the editor window scrolls is always the same.
My abilities as a coder ar by far not enough to contribute to godot, but can somebody else maybe change the implementation to more "natural" scrolling where scrolling speed on the touch pad corresponds to the scrolling speed of the window?

@Foxomat Does it work better if you disable Text Editor → Open Scripts → Smooth Scrolling in the Editor Settings?

@Calinou Thank you, it really makes it better. Although its still not quite as smooth as scolling in e.g. a browser window, i am really satisfied with it.


⚠ Bofrost.be has degraded performance

In 0d12bfd, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1000 ms

Resolved: Bofrost.be performance has improved in 2919af9 after 6 minutes.


Fixed #30880 -- Optimized _tx_resource_for_name() function

The function _tx_resource_for_name() in the file manage_translation.py uses if else statement to return the Transifex resource name.
I replaced that if else statement with a ternary operator. It allows us to replace simple if statements with a single line expression and increases code readability by reducing number of lines of code.

Closing per ticket.

Thanks for the correction. I did it by mistake.


Does rust crypto support certificate validation?

Will this project ever have such a feature? I would get rid of OpenSSL crate and library at all if such a feature were implemented.

@vityafx This crate operates at a lower layer than certificates. The webpki crate does certificate validation.

Thanks. I have just thought this crate is something like OpenSSL in pure rust. It seems it is not. Thank you for your fast response.


treewide: Fix indentation in strings

The indentation stripping semantics of strings are fairly bad and have a few gotchas where the resulting string has not the intended indentation. This commit fixes most if not all such instances in Nixpkgs.
I tried to strive a balance between keeping the diff small and reformatting/refactoring the code to look better. In general, reformatting should be left to Nixfmt.
Note that this causes a lot of rebuilds by design. All changes need to be thoroughly vetted and reviewed for correctness. There is no automatic way to prove correctness.
List of files to fix generated by running
https://gerrit.lix.systems/c/lix/+/2092 on Nixpkgs and looking at the warnings.

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

I took out some big packages, but this still has 36000 rebuilds. I've taken out some obvious candidates but I'm a bit at a loss now, so I'd appreciate any hints as to what may be causing these rebuilds.

 The emscriptenPackages failures look like an unrelated dependency failure to me (CC @jtojnar @qknight). The datadog-agent failure is mine and will be fixed with the next push (I fell for the exact same syntax gotcha again which I was trying to fix …)

@ofBorg eval


Bug: Taskbar Overlaps App in Full Screen Mode

Description
When entering full screen mode, part of the app is displayed beneath the taskbar.
Switching to the dev version <IP_ADDRESS> did not resolve the issue.

Steps To Reproduce
Press F11 or use command palette to enter full screen mode
Requirements
The app should display above the taskbar, or the taskbar should hide
Files Version
<IP_ADDRESS>
Windows Version
10.0.19045.3693
Log File
debug.log

Thanks for the report, this was supposed to have been fixed in #13207 so we'll have to investigate why it's back.

Does it also overlap when the taskbar is at the bottom of the screen?

Does it also overlap when the taskbar is at the bottom of the screen?

Yes, it occurs regardless of where the taskbar is positioned on the screen.

I've noticed that commenting out the changes made in #13207 resolves this issue. This suggests that the problem is the opposite of #10767. I think it would be helpful to determine whether to display the taskbar by detecting the user's "Automatically hide the taskbar in desktop mode" setting.

@Qin-shihuang would you like to work on this?

@yaira2 thanks for asking.  I've already opened a PR #14300. However I'm new here so I'm not sure where to place the new method. I would appreciate any suggestions on coding styles and the project's structure. Thank you for your patience.


Use MF2 parser to identify webmention types

When receiving a webmention, Transformative uses Nokogiri to scan through and find a.u-like-of links within the source HTML.
@myfreeweb's sweetroll uses rel=like-of and links within .u-like-of blocks. Webmentions from Greg that are correctly marked-up as likes are currently treated as plain mentions. Their reposts and replies are probably treated the same way.
The code should detect webmention types using the (new) Ruby MF2 parser.
(NB I've switched to the new MF2 parser and can now pick up their relative URLs and store as absolutes.)

@myfreeweb This should now be fixed in 676176376ec347b832d0bfb692227e3996e0efe4. Would you mind sending another like to help me test?

yeah it works now! even delete-undelete (http 410) worked. nice

Wonderful! Many thanks for your help again, Greg.


New command: Compare backup files

Using go-jwlm compare <left-backup> <right-backup> it is possible to compare two backup files to see if their contents are equal, even if the order of entries might be different. This is mainly meant for debugging (or rather ensuring that there is no bug 😅), but might be useful for other use cases.
Also fixed a tiny bug (not everything was printing to Stdio in merge command) & removed a forgotten debug statement.
Changes:

🐛 mergeCmd: Not everything printing to Stdio
Remove forgotten debug statements
CMD: Compare two backups

Coverage decreased (-1.02%) to 80.705% when pulling 49cf2323380c10cebf967bd0341acfabd3f0e766 on cmd_compare into 596c7112c90d384a180bc4d0a961f5fc58e7cea8 on master.


UIPFI-19: Update filters & search to match ui-inventory

https://issues.folio.org/browse/UIPFI-6
https://issues.folio.org/browse/UIPFI-18
https://issues.folio.org/browse/UIPFI-19
https://issues.folio.org/browse/UIPFI-20

This PR references the four interrelated stories listed above, all of which involve updating the search and filter pane to match the options presented in ui-inventory. The major challenge turned out to be adapting the inventory filter code, which presumes the use of <SearchAndSort>, to make use of the plugin's searchAndSortQuery function.
To avoid large swathes of redundant code, the approach taken here is to identify common files that can be refactored out of both repositories (this and ui-inventory) into a shared component repo, as has been done with things like stripes-erm-components. In this draft version, there is a new, top-level Imports directory. This, confusingly, contains an imports subdirectory that holds the reusable files to be extracted to a common repo (this will eventually be removed from the plugin repo). The FilterRenderers subdirectory contains imported but modified code that can't be easily extracted, unfortunately; but it's probably worth keeping it labeled as Imports to indicate its origin.
I'm pausing at this stage, before creating the common repository and extracting imports, to solicit feedback on what I have wrought thus far.

Test errors found. See https://jenkins-aws.indexdata.com/job/folio-org/job/ui-plugin-find-instance/job/PR-88/1/

Test errors found. See https://jenkins-aws.indexdata.com/job/folio-org/job/ui-plugin-find-instance/job/PR-88/2/

yarn run v1.22.4
$ eslint .
/home/jenkins/workspace/rg_ui-plugin-find-instance_PR-88/project/Imports/imports/utils.js
3:3  warning  'forOwn' is defined but never used  no-unused-vars
/home/jenkins/workspace/rg_ui-plugin-find-instance_PR-88/project/test/bigtest/network/config.js
213:1  error  Block must not be padded by blank lines  padded-blocks
✖ 2 problems (1 error, 1 warning)
1 error and 0 warnings potentially fixable with the --fix option.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Test errors found. See https://jenkins-aws.indexdata.com/job/folio-org/job/ui-plugin-find-instance/job/PR-88/3/

@Baroquem Hello, thank you. I see that story https://issues.folio.org/browse/UIPFI-20 have status "IN PROGRESS". Could you please clarify we can start review or we need wait until current story will be moved to "IN CODE REVIEW" (something will be changed in current pull request)?

yarn run v1.22.4
$ eslint .
/home/jenkins/workspace/rg_ui-plugin-find-instance_PR-88/project/test/bigtest/network/config.js
213:1  error  Block must not be padded by blank lines  padded-blocks
✖ 1 problem (1 error, 0 warnings)
1 error and 0 warnings potentially fixable with the --fix option.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Test errors found. See https://jenkins-aws.indexdata.com/job/folio-org/job/ui-plugin-find-instance/job/PR-88/4/

@Baroquem Thank you, nice job.
How i understood this plugin used in several modules (ui-inventory, ui-receiving and ui-receiving).
Many paths added to manifest (Imports/imports/DataProvider.js).

Could you please double check should we add changes in okapiInterfaces?
What permission should have user for use current plagin in ui-inventory, ui-receiving and ui-receiving (BE can return error " permission is required" when we use api call)?
Should we add bigtest or jest test?
...
CC: @zburke @mkuklis


Admin APIs & Redis store

[x] View consumer information
[x] Edit consumer information
[ ] view consumer credit requests
[x] add credits to consumer
[x] reduce credits to consumer
[x] login into marketplace
[ ] Setup redis for storing course search results

Will be completed EOD - Khalid

Consumer Credit Requests and Redis for storing search results will by tomorrow

Redis store will be closed today


Added built-in support for typescript

With this backpack will work on Node.js projects written in TypeScript without any additional settings.

Closing... See #26


Emmet takes way too much disk space

VS Code 1.12 for macOS was 188MB, while 1.13 is 235MB. That's a 25% increase of the overall size just for Emmet. The download itself grew from 63MB to 72MB.

Although they are cool features, this seems like a very high price to pay for them.
Related to #28874 (I didn't want to hijack that one)
cc @Microsoft/vscode

related https://github.com/Microsoft/vscode/issues/29054

@joaomoreno  Actually, the root cause is #29054 which I assigned to you :) Thoughts?

Great to know! Let's close this then! 👍

Though #29054 is still a valid issue, the specific case of emmet bloating up was due to having typescript and vscode as dev dependency
Fixed with https://github.com/Microsoft/vscode/commit/6e366b8f9026bb65a250f0a7bca27dafad9439bd Now the size of the emmet folder under extensions is reduced to 3.6 MB


Wrong visibility in impl_parse_for_custom_keyword macro ?

Hello,
I wasn't able to compile my project because of private field in:
macro_rules! impl_parse_for_custom_keyword {
    ($ident:ident) => {
        // For peek.
        impl $crate::__private::CustomToken for $ident {
            fn peek(cursor: $crate::buffer::Cursor) -> $crate::__private::bool { // Error need to change to $crate::__private::buffer::Cursor
                if let $crate::__private::Some((ident, _rest)) = cursor.ident() {
                    ident == $crate::__private::stringify!($ident)
                } else {
                    false
                }
            }

            fn display() -> &'static $crate::__private::str {
                $crate::__private::concat!("`", $crate::__private::stringify!($ident), "`")
            }
        }

        impl $crate::parse::Parse for $ident {
            fn parse(input: $crate::parse::ParseStream) -> $crate::parse::Result<$ident> {
                input.step(|cursor| {
                    if let $crate::__private::Some((ident, rest)) = cursor.ident() {
                        if ident == $crate::__private::stringify!($ident) {
                            return $crate::__private::Ok(($ident { span: ident.span() }, rest));
                        }
                    }
                    $crate::__private::Err(cursor.error($crate::__private::concat!(
                        "expected `",
                        $crate::__private::stringify!($ident),
                        "`",
                    )))
                })
            }
        }
    };
}

Check the comment.
Hope this could help.

The code above looks correct to me. What was the error?

When compiling winit, it told me to replace $crate::buffer::Cursor by syn::buffer::Cursor, but I replaced by $crate::__private::buffer::Cursor.
But it is strange because $crate::buffer::Cursor is public, so I will close the issue as I resolve it by myself and hope it is a one time bug during compilation !


Fixed adding the verdaccio user into the group

Type: bug
The following has been addressed in the PR: There was a typo in the command creating the verdaccio user

Description: This exceptionally huge change makes it possible to use the image without chowning the whole volume in an init-container as mentioned in #238. :)
To be able to use it just make a change in your deployment file, add this to your PodSpec (101 is the verdaccio group id)
"securityContext": {
    "fsGroup": 101
}

Resolves #238
BUT
There is still a problem while trying to use the image like this:
docker run -it -v ~/test:/verdaccio/storage verdaccio/verdaccio:latest
I believe that it's a problem on Docker side.

How this will impact the nonkubernetes users?

This  change should not impact them anyhow. They wasn't able to use the image before this. They either have to run this without persistence, or have to set the permissions for the attached folder on the host.

Now I see it. I'm still a 🐋er newbie 😄 . Thanks for the explanation.


Add warning message for implicit meta endorsement policy failure

Type of change

Improvement to logging

Description
Many users are unable to troubleshoot endorsement policy failures.
This change shifts a debug message to a warning message so that peer
will log the reason for the endorsement policy failure.
E.g. the following warning message will now help users troubleshoot the
reason for the failure:
"Evaluation Failed: Only 0 policies were satisfied,
but needed 2 of [ Org2MSP/Endorsement Org1MSP/Endorsement ]"
Also, the policy name is now added to associated error messages,
so that users know where to change the policy.
Signed-off-by: David Enyeart<EMAIL_ADDRESS>

Ok, it just looked so good in my single org channel logs :-)


Is a Swagger spec available?

The documentation says that the Java and Python libraries in this repo are based on Swagger. Is there a Swagger JSON or YAML spec that could be used to generate a client in another language?
My current CM install doesn’t expose API Explorer/Swagger UI under the Support menu; just has API Documentation.

Cloudera Manager API client released with Cloudera Manager 6.0, not the one in this repo, is indeed generated using Swagger.
You can find more information about new Swagger based Cloudera Manager API Client here
https://cloudera.github.io/cm_api/docs/python-client-swagger/
On a running Cloudera Manager instance, swagger input specification json is available at http://:7180/static/apidocs/ui/swagger.json
In future for those who don't have access to a running Cloudera Manager instance, we'll link the swagger input specification from static site http://cloudera.github.io/cm_api/docs/releases/

https://github.com/OAI/OpenAPI-Specification/blob/master/versions/2.0.md#operationObject
The Spec isn't valid.
operationId must be Unique Globally.
arch@9d46dd2d-1178-ce83-cbc4-d396e4a24060 ~/g/s/g/b/go-cdm ❯❯❯ ./swagger_linux_amd64 generate  client swagger.json                                                                                ✘ 1
2020/04/10 14:24:30 validating spec /home/arch/go/src/git.bdf-cloud.iqvia.net/bdf-cloud/go-cdm/swagger.json
The swagger spec at "/home/arch/go/src/git.bdf-cloud.iqvia.net/bdf-cloud/go-cdm/swagger.json" is invalid against swagger specification 2.0. see errors :
- "readRoleConfigGroups" is defined 3 times
- "deleteRole" is defined 3 times
- "updateRoleConfig" is defined 3 times
- "readHistory" is defined 2 times
- "readRoleConfigGroup" is defined 3 times
- "listRoleTypes" is defined 3 times
- "startCommand" is defined 7 times
- "readRoles" is defined 6 times
- "createRoles" is defined 3 times
- "zooKeeperCleanupCommand" is defined 2 times
- "getFullLog" is defined 3 times
- "updateConfig" is defined 6 times
- "getStandardError" is defined 3 times
- "getStandardOutput" is defined 3 times
- "jmapHisto" is defined 2 times
- "updateServiceConfig" is defined 3 times
- "readRoleConfig" is defined 3 times
- "inspectHostsCommand" is defined 2 times
- "restartCommand" is defined 7 times
- "stopCommand" is defined 7 times
- "rollingRestart" is defined 2 times
- "getStacksLogsBundle" is defined 3 times
- "readService" is defined 3 times
- "firstRun" is defined 2 times
- "updateRoleConfigGroup" is defined 3 times
- "lsof" is defined 2 times
- "getClientConfig" is defined 2 times
- "exitMaintenanceMode" is defined 8 times
- "jmapDump" is defined 2 times
- "autoConfigure" is defined 3 times
- "readAuthRolesMetadata" is defined 2 times
- "autoAssignRoles" is defined 3 times
- "jstack" is defined 2 times
- "queryTimeSeries" is defined 2 times
- "getMetrics" is defined 5 times
- "zooKeeperInitCommand" is defined 2 times
- "readConfig" is defined 5 times
- "readServiceConfig" is defined 3 times
- "readRole" is defined 3 times
- "listActiveCommands" is defined 8 times
- "enterMaintenanceMode" is defined 8 times
- "getKerberosInfo" is defined 2 times
- "getStacksLog" is defined 3 times

That example was wit go-swagger.
It seems https://github.com/swagger-api/swagger-codegen is a little bit less strict on following the API standard and resulted in something that needed less modication's before becoming usable.


reorganize tests so that cargo test passes

Before, tests that used unstable features were mixed in. That meant that cargo test by itself didn't pass, which would send a weird signal. It's still the case that cargo test --features unstable is the right way to run the tests though.

Probably should add a bare cargo test to travis too.

@cuviper yeah I was thinking the same. Also I like how I broke the unstable tests. =)


(Update) SonarQube PDF Report Setting

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: ________. Customer needed to make changes on the SonarQube side to resolve the issue.  Added reference to the documentation
Jira/GitHub Issue numbers (if any): ______.  https://harnesssupport.zendesk.com/agent/tickets/74169
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://6749e653cdc2eccd42f8278b--harness-developer.netlify.app


Support new artifact type

https://github.com/oci-playground/artifact-spec

Fixed upstream and merged into this fork.


Unicode::UTF8 missing

Any ideas what I am missing?
root@server:~# curl https://convos.by/install.sh | sh -                                     % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1186    0  1186    0     0   1783      0 --:--:-- --:--:-- --:--:--  1783
mkdir: cannot create directory 'convos': File exists
> /usr/bin/curl -s -L https://github.com/Nordaaker/convos/archive/stable.tar.gz | /bin/tar xz -C convos --strip-components 1
> /usr/bin/perl convos/script/convos install
>>> /usr/bin/perl /root/convos/script/cpanm -n -l /root/convos/script/../local -M https://cpan.metacpan.org Mojo::IRC
--> Working on Mojo::IRC
Fetching https://cpan.metacpan.org/authors/id/J/JH/JHTHORSEN/Mojo-IRC-0.45.tar.gz ... OK
Configuring Mojo-IRC-0.45 ... OK
==> Found dependencies: Unicode::UTF8
--> Working on Unicode::UTF8
Fetching https://cpan.metacpan.org/authors/id/C/CH/CHANSEN/Unicode-UTF8-0.62.tar.gz ... OKConfiguring Unicode-UTF8-0.62 ... OK
Building Unicode-UTF8-0.62 ... FAIL
! Installing Unicode::UTF8 failed. See /root/.cpanm/work/1529973851.1104/build.log for details. Retry with --force to force install it.
! Installing the dependencies failed: Module 'Unicode::UTF8' is not installed
! Bailing out the installation for Mojo-IRC-0.45.
cpanm failed!
root@server:~#

GitMate.io thinks the contributor most likely able to help you is @jhthorsen.
Possibly related issues are https://github.com/Nordaaker/convos/issues/309 (Missing /LIST command), https://github.com/Nordaaker/convos/issues/130 ([ missing in nicks), https://github.com/Nordaaker/convos/issues/23 (AssetPack missing preprocessors), https://github.com/Nordaaker/convos/issues/274 (Placeholder: Improve / add missing information to https://convos.by), and https://github.com/Nordaaker/convos/issues/266 (Installation on CentOS7 fails on missing Time::Piece).

I don't know, but maybe you can look in /root/.cpanm/work/1529973851.1104/build.log to see what's going on? I found that log file by looking at the lines starting with "!" in your output.

I had to install gcc to overcome this error. The error is somewhat non descriptive, when you look in the build log it complains about a missing C compiler.
I also had to install (in a LXC container so it might be not needed on a full blown VM):

make
libnet-ssleay-perl
libcrypt-eksblowfish-perl

Might be useful to document this somewhere?

Going to replace this with #392.


content cleanup

General content cleanup for getting started:designers

Thanks for going in and making this updates Clay!

@alisonjoseph Should be good to go.


Aaru fails with exit code 1 if Ipmlab is run from PyPi package

This happens under Linux Mint 19.3. No useful info from Aaru log/error log.
However, everything works fine when running Ipmlab from local script (launcher in Git repo). I suspect this has something to do with Aaru trying to write to stdout/stderr (which is shown in terminal for local script), and fact that stdout and stderr are not captured. But capturing stdout/stderr leads to the problems described here:
https://github.com/KBNLresearch/ipmlab/issues/16

Update - if the packaged version of Ipmlab is launched from the terminal Aaru works as expected. So issue is definitely caused by Aaru's stdout/stderr handliing.

Update, changed call to Aaru to this:
p = sub.Popen(args, stdout=sub.PIPE, stderr=sub.STDOUT)
for line in io.TextIOWrapper(p.stdout, encoding="utf-8"):
     logging.info(line)

Result (from Ipmlab log file):
2022-09-14 19:41:01,490 - INFO - aaru 5.3.1

2022-09-14 19:41:01,490 - INFO - Copyright © 2011-2022 Natalia Portillo

2022-09-14 19:41:01,490 - INFO -

2022-09-14 19:41:01,772 - INFO - Output image format: Raw Disk Image.

2022-09-14 19:41:01,846 - INFO - Unhandled exception: System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.

2022-09-14 19:41:01,846 - INFO -  ---> System.ArgumentOutOfRangeException: Count cannot be less than zero. (Parameter 'count')

2022-09-14 19:41:01,847 - INFO -    at System.String.Ctor(Char c, Int32 count)

2022-09-14 19:41:01,847 - INFO -    at Aaru.Progress.ClearCurrentConsoleLine()

2022-09-14 19:41:01,847 - INFO -    at Aaru.Progress.UpdateStatus(String text)

2022-09-14 19:41:01,847 - INFO -    at Aaru.Core.Devices.Dumping.Dump.Start() in /home/claunia/Development/Aaru/Aaru/Aaru.Core/Devices/Dumping/Dump.cs:line 214

2022-09-14 19:41:01,847 - INFO -    at Aaru.Commands.Media.DumpMediaCommand.Invoke(Boolean debug, Boolean verbose, String cicmXml, String devicePath, Boolean resume, String encoding, Boolean firstPregap, Boolean fixOffset, Boolean force, Boolean metadata, Boolean trim, String outputPath, String options, Boolean persistent, UInt16 retryPasses, UInt32 skip, Byte speed, Boolean stopOnError, String format, String subchannel, Boolean private, Boolean fixSubchannelPosition, Boolean retrySubchannel, Boolean fixSubchannel, Boolean fixSubchannelCrc, Boolean generateSubchannels, Boolean skipCdiReadyHole, Boolean eject, UInt32 maxBlocks, Boolean useBufferedReads, Boolean storeEncrypted, Boolean titleKeys)

2022-09-14 19:41:01,847 - INFO -    --- End of inner exception stack trace ---

2022-09-14 19:41:01,847 - INFO -    at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor, Boolean wrapExceptions)

2022-09-14 19:41:01,847 - INFO -    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

2022-09-14 19:41:01,847 - INFO -    at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters)

2022-09-14 19:41:01,847 - INFO -    at System.CommandLine.Invocation.ModelBindingCommandHandler.InvokeAsync(InvocationContext context)

2022-09-14 19:41:01,847 - INFO -    at System.CommandLine.Invocation.InvocationPipeline.<>c__DisplayClass4_0.<<BuildInvocationChain>b__0>d.MoveNext()

2022-09-14 19:41:01,847 - INFO - --- End of stack trace from previous location where exception was thrown ---

2022-09-14 19:41:01,847 - INFO -    at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<UseParseErrorReporting>b__19_0>d.MoveNext()

2022-09-14 19:41:01,847 - INFO - --- End of stack trace from previous location where exception was thrown ---

2022-09-14 19:41:01,847 - INFO -    at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass14_0.<<UseHelp>b__0>d.MoveNext()

2022-09-14 19:41:01,847 - INFO - --- End of stack trace from previous location where exception was thrown ---

2022-09-14 19:41:01,848 - INFO -    at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass22_0.<<UseVersionOption>b__0>d.MoveNext()

2022-09-14 19:41:01,848 - INFO - --- End of stack trace from previous location where exception was thrown ---

2022-09-14 19:41:01,848 - INFO -    at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass21_0.<<UseTypoCorrections>b__0>d.MoveNext()

2022-09-14 19:41:01,848 - INFO - --- End of stack trace from previous location where exception was thrown ---

2022-09-14 19:41:01,848 - INFO -    at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<UseSuggestDirective>b__20_0>d.MoveNext()

2022-09-14 19:41:01,848 - INFO - --- End of stack trace from previous location where exception was thrown ---

2022-09-14 19:41:01,848 - INFO -    at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<UseParseDirective>b__18_0>d.MoveNext()

2022-09-14 19:41:01,848 - INFO - --- End of stack trace from previous location where exception was thrown ---

2022-09-14 19:41:01,848 - INFO -    at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<UseDebugDirective>b__10_0>d.MoveNext()

2022-09-14 19:41:01,848 - INFO - --- End of stack trace from previous location where exception was thrown ---

2022-09-14 19:41:01,848 - INFO -    at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<RegisterWithDotnetSuggest>b__9_0>d.MoveNext()

2022-09-14 19:41:01,848 - INFO - --- End of stack trace from previous location where exception was thrown ---

2022-09-14 19:41:01,848 - INFO -    at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass12_0.<<UseExceptionHandler>b__0>d.MoveNext()

Possibly (un?)related :
https://github.com/robotframework/robotframework/issues/4173

Todo: make minimal demo script that demonstrates the issue.

Update, in Windows, Ipmlab launches Aaru in a separate console Window (which closes automatically upon completion:

A bit ugly, but at least it works.

Another twist to this - in Windows, setting "shell=True" gets rid of the the terminal (in Linux this won't even run!):
 # Run Aaru as subprocess
 p = sub.run(args, shell=True)

Opened Aaru issue for this:
https://github.com/aaru-dps/Aaru/issues/749

Fixed now in Aaru:
https://github.com/aaru-dps/Aaru/issues/749


The historic data is not correct for stocks. Data does not match with Yahoo Finance website also. Website is showing correct data.

Are you up-to-date?
Yes
Does Yahoo actually have the data?
Yes, And the data on the website looks accurate.
Are you spamming Yahoo?
I'm trying to find ATH of all the stocks within Nifty 500 index.
Still think it's a bug?
Yes, For example, below is the code to find ATH of INFY.NS. Since, I know that it made it's ATH around 17 Jan 2022. I am using time range to get the data -
`
import yfinance as yf
stock = yf.Ticker("INFY.NS")
history = stock.history(start="2022-01-05", end="2022-01-20")
yf.enable_debug_mode()
print("Yahoo Finance Version", yf.version)
print("***********")
print(history)
print("All time HIGH", history["High"].max())
print("All time HIGH Date", history[history["High"] == history["High"].max()].index[0])
`
Output shows
`
Yahoo Finance Version 0.2.24

                              Open         High          Low        Close    Volume  Dividends  Stock Splits

Date
2022-01-05 00:00:00+05:30  1810.738793  1813.502575  1753.557568  1757.989136   6995719        0.0           0.0
2022-01-06 00:00:00+05:30  1742.121151  1742.121151  1715.436582  1732.400391   6449205        0.0           0.0
2022-01-07 00:00:00+05:30  1730.160822  1749.745437  1721.917288  1729.064941   4834389        0.0           0.0
2022-01-10 00:00:00+05:30  1729.732011  1782.052854  1727.825970  1763.802490   7857560        0.0           0.0
2022-01-11 00:00:00+05:30  1767.852894  1782.148200  1763.230768  1768.424683   5142287        0.0           0.0
2022-01-12 00:00:00+05:30  1781.099914  1800.255602  1772.618009  1789.248169   5362535        0.0           0.0
2022-01-13 00:00:00+05:30  1815.503807  1822.651460  1778.669547  1807.689087  14277630        0.0           0.0
2022-01-14 00:00:00+05:30  1793.584466  1842.188509  1792.631446  1838.709961   7688506        0.0           0.0
2022-01-17 00:00:00+05:30  1847.477856  1862.106697  1839.805995  1848.383179   5262464        0.0           0.0
2022-01-18 00:00:00+05:30  1831.800470  1853.624660  1821.650780  1830.513916   3690315        0.0           0.0
2022-01-19 00:00:00+05:30  1825.987220  1825.987220  1775.334158  1779.336914   5747770        0.0           0.0
All time HIGH 1862.1066965763564
All time HIGH Date 2022-01-17 00:00:00+05:30
`
It says the ATH is 1862.1066965763564 but actually the ATH is 1953.90 . The website shows it correct - https://finance.yahoo.com/quote/INFY.NS/history?period1=1641340800&period2=1642636800&interval=1d&filter=history&frequency=1d&includeAdjustedClose=true
As I see the Open, High, Low, Close data is shown wrong by the yfinance module.

history returns dividend-adjusted price.

set auto_adjust = False , like :
history = stock.history(start="2022-01-05", end="2022-01-20", auto_adjust = False)


access-control-allow-origin settings are too lose by default

Version
nuxt-security: 0.11.0
nuxt: 3.2.3
Reproduction Link
nuxt-security.vercel.app
Steps to reproduce

What is Expected?
The module gives me full security out of the box.
a) Don't set this header at all leaving the default browser behavior
or
b) Require the user to set this value or at least throw warnings when it's not set
What is actually happening?

The documentation website just shows how to use the module but does not use it as having these Security middlewares are not necessary for static Markdown website ;)

I see, makes sense. I made an assumption that it's not only docs but also a demo. In this case please consider this task as a feature request instead of a bug.

This will be released with upcoming 0.12.0 version

Released in https://github.com/Baroshem/nuxt-security/releases/tag/v0.12.0


[MM-23635] Only load bot icon url when it's been updated

Summary
The new sidebar was missing some logic from the old one that was causing some issues with loading bot icon images. The logic has been fixed in this PR.
This one isn't easy to reproduce, but with this fix you shouldn't see issues loading the icons for bot users like the GitHub and JIRA bots.
Ticket Link
https://mattermost.atlassian.net/browse/MM-23635

Creating a new SpinWick test server using Mattermost Cloud.

Mattermost test server created! :tada:
Access here: https://mattermost-webapp-pr-5200.test.mattermost.cloud

Account Type
Username
Password

Admin
sysadmin
Sys@dmin123

User
user-1
User-1@123

Test server destroyed


[Deprecation] helm/kube/terraform schematic in ComponentDefinition

Introduction
We have four ComponentDefinition schematics defined, which are helm/kube/terraform/CUE. The three schematics other than CUE now have some shortcomings and are able to be unified to CUE. This issue propose to deprecated helm/kube/terraform schematic in ComponentDefinition.
Limitations

Both the helm/kube/terraform introduce some hard coded logic to render resources in vela core. With CUE schematic these rendering logic will be eliminated and move to definition layer.
From v1.2, many useful Application features is built on CUE schematic based ComponentDefinition. And not it's hard to align for other types. For example data passing between components is totally based on CUE.

Functionality and Replacement

helm schematic is built for delivery Helm Chart. This capability has beed separated to fluxcd Addon. In this addon, helm type ComponentDefinition is built by CUE schematic.
kube is buit for delivery Kubernetes objects. This capability has been implemented by built-in k8s-objects type ComponentDefinition.
terraform is built for delivery terraform-controller Configuration. This need some extra work to migrate to CUE schematic.

Before start, we need a proposal about how to achieve this and keep the compatiblity. The compatiblity to end user which means let the application yaml related still work, is very important.


Improve wording for Turkish

"Bulanık" is an accepted term for fuzzy.
/cc @bitigchi

LGTM.

Thank you!


[publish] Blog on JDBCToBigQuery

@sjlva For the next time, request you not to work on stuff already assigned to others.
Please check the github issues for open items.

@shashank-google and @nehamodgil I'm sorry! I did not realize it was assigned to nehamodgil. 😳
It will not happen again.


Issues with Opera browser regarding modals

Hello, i'm submitting here an issue i experience recently. Hope someone can help me with this one.
I experience an issue whenever i use:
$('#my-modal').modal('show')
for Firefox, it's working the way it should be... but for Opera (or maybe other web-kit browsers?)
it shows the backdrop, but not the modal window... It just dims the whole window w/o the modal.
i use the options:
backdrop: "static", keyboard: true
and i figured out i need the option :
show: true
to make it work with Opera, but whenever i use that option
it doubles the backdrop in other browsers (i.e. Firefox)
to be specific, when i close the modal, it shows another backdrop which has no more modal window
it just stays dimmed.

could you create a jsfiddle demonstrating this problem, thanks!

<offtopic>
Opera is not WebKit browser. It uses it's own engine - Presto. ;-)
</offtopic>

@flurrry Can you update with a jsfiddle?

I can't reproduce this with 1.4. My guess is it was related to the animation event being dropped like in firefox. Closing unless you can provide a non working jsfiddle - thanks!

@flurrry : double check how you declare your modal. I have had the same problem with a Q&D implementation (I have initialized the modal in a click callback).
I hope it can helps :)

Hello @fat,
Sorry I can't really create a good jsfiddle example for this, as I mostly use PHP codes in the modal snippet.
I tried but it won't show in the result window.
You may check out the syntax I use: http://jsfiddle.net/xc5UZ/2/
I replaced the some of the php functions with some comments.
NOTE: I am using the modal as a pop-up when a specific cookie is "not found", after the modal is closed, the cookie will be created.
*I am not really familiar with jsFiddle, so I don't know if I made the correct set-up to match the example...

closing for now - have you tried updating to the latest modal js?

Yes I have. Still no luck. Maybe I should use false on backdrop, which will solve the problem having double backdrops.


yaml comments do not take effect in one case

How to recurrence
step 1: Create a new simple chart.
helm create demo
step 2: Render chart templates locally and display the output.
helm template demo
This step will render correctly.
step 3: Comment the entire service.yaml file in templates folder and render again.
The service.yaml file is as follows:
# apiVersion: v1
# kind: Service
# metadata:
#   name: {{ include "demo.fullname" . }}
#   labels:
#     {{- include "demo.labels" . | nindent 4 }}
# spec:
#   type: {{ .Values.service.type }}
#   ports:
#     - port: {{ .Values.service.port }}
#       targetPort: http
#       protocol: TCP
#       name: http
#   selector:
#     {{- include "demo.selectorLabels" . | nindent 4 }}

Render chart templates again, it will not render as expected, the result is as follows:
# Source: demo/templates/service.yaml
# apiVersion: v1
# kind: Service
# metadata:
#   name: release-name-demo
#   labels:
#
    helm.sh/chart: demo-0.1.0
    app.kubernetes.io/name: demo
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/version: "1.16.0"
    app.kubernetes.io/managed-by: Helm
# spec:
#   type: ClusterIP
#   ports:
#     - port: 80
#       targetPort: http
#       protocol: TCP
#       name: http
#   selector:
#
    app.kubernetes.io/name: demo
    app.kubernetes.io/instance: release-name

Output of helm version: v3.9.0
Output of kubectl version: v1.16.14
How should I achieve the desired comment effect, or is this a persistent bug？

I have encountered the same situation before, and this is how I resolved it. I used the {{- /* */}} comment syntax.
reference  https://helm.sh/docs/chart_best_practices/templates/#helm
{{- /*
apiVersion: v1
kind: Service
metadata:
  name: {{ include "demo.fullname" . }}
  labels:
    {{- include "demo.labels" . | nindent 4 }}
spec:
  type: {{ .Values.service.type }}
  ports:
    - port: {{ .Values.service.port }}
      targetPort: http
      protocol: TCP
      name: http
  selector:
    {{- include "demo.selectorLabels" . | nindent 4 }}
*/}}

I hope it is helpful to you.

To expand @Ithrael 's answer -- Helm is still rendering the template. And at the template phase, the "yaml comments" are just part of the input template text.
Then the template engine converts:
#   labels:
#     {{- include "demo.labels" . | nindent 4 }}

As you see, into:
#   labels:
#
    helm.sh/chart: demo-0.1.0
    app.kubernetes.io/name: demo
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/version: "1.16.0"
    app.kubernetes.io/managed-by: Helm

@Ithrael is correct, you need to use template comment syntax to avoid the template rendering.


Sponsorship Carousel V2

As the final sponsorship design, we want a multi-window automatic scrolling carousel. This would appear with multiple images at one time appearing to seamlessly go off screen and then re-appear on the other side. It should be smooth.
This library has potential: https://github.com/YIZHUANG/react-multi-carousel but hasn't been updated in a while, so it might be best to use regular bootstrap.
This ticket is meant for developers with a little bit of ITWS background.
Also - please split this into multiple commits when working! This will be slightly on the longer side.

If you have any questions about the design reach out to confirm before you start working on it to prevent wasted dev time.

Note that the sponsorship design was updated by the Technology team and this issue can be closed.


attach_elb_log_delivery_policy also needed for ALB

Description
The document implies that only attach_lb_log_delivery_policy = true is needed for ALB logging, but actually attach_elb_log_delivery_policy = true is also needed. (NLB would requires attach_lb_log_delivery_policy = true only)
Code Snippet to Reproduce
module "s3_logs_lb" {
  source = "terraform-aws-modules/s3-bucket/aws"

  bucket = "test"
  acl    = "log-delivery-write"

  attach_lb_log_delivery_policy = true
}

module "alb" {
  source  = "terraform-aws-modules/alb/aws"
  version = "~> 6.0"
...

  access_logs = {
    bucket = module.s3_logs_lb.s3_bucket_id
    prefix = "alb"
  }
...
}

Expected behavior

Everything works fine.
Actual behavior

Failed in creating the ALB.
Terminal Output Screenshot(s)

Error: failure configuring LB attributes: InvalidConfigurationRequest: Access Denied for bucket: test. Please check S3bucket permission
...
with module.alb.aws_lb.this[0]

Additional context

According to https://docs.aws.amazon.com/elasticloadbalancing/latest/classic/enable-access-logs.html#attach-bucket-policy, arn:aws:iam::elb-account-id:root shall be allowed to do s3:PutObject.

Thanks for this, I was starting to tear my hair out.

Fixed in 53ac7dd
v2.6.0 has been just released.


verify that defaults were set from /etc/resolv.conf

https://github.com/kubernetes/kubernetes/issues/14394#issuecomment-145648734

@miekg


Mac Build doesn't run with cannot find module error.

Hello,
I've created demo desktop application with asp.net core 2.2 on mac machine. I've created a build for mac os. I've got the issues on run the build :
Uncaught Exception:
Error: Cannot find module '/Applications/electron.net.host.app/Contents/Resources/bin/electron.manifest.json'
Require stack:

/Applications/electron.net.host.app/Contents/Resources/app.asar/main.js
at Module._resolveFilename (internal/modules/cjs/loader.js:717:15)
at Function../lib/common/reset-search-paths.ts.Module._resolveFilename (electron/js2c/browser_init.js:7552:16)
at Module._load (internal/modules/cjs/loader.js:622:27)
at Module._load (electron/js2c/asar.js:717:26)
at Function.Module._load (electron/js2c/asar.js:717:26)
at Module.require (internal/modules/cjs/loader.js:775:19)
at require (internal/modules/cjs/helpers.js:68:18)
at Object. (/Applications/electron.net.host.app/Contents/Resources/app.asar/main.js:20:26)
at Module._compile (internal/modules/cjs/loader.js:880:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:892:10)

did you execute the electronize init command in your project?

Hi Gregor,
Thanks for reply.
I have already done this then I have created a build. After your reply I have type it again as shown below:

Test: demo mac$ electronize init
Adding our config file to your project...
Config file already in your project.

@robertmuehsig can you please test it with your mac.

Hi @GregorBiswanger, I think @robertmuehsig has not responded since August 2019, can you please check with him and reply as soon as possible.
Thanks In advance.

unfortunately I don't have a mac to test it.. Robert is currently very busy with his family.. but please try to get help from the community, if no one answers there, please let me know again..
https://gitter.im/ElectronNET/community
if you have solved your problem please let me know and close the issue

Hi @GregorBiswanger ,
Thanks for reply :)
I've created new web application and created build successfully.


[Incident] Spawn failed on nasa-veda

Summary
Trying to start a session on https://nasa-veda.2i2c.cloud/ repeatedly fails with "Spawn failed: Could not create pod prod/jupyter-j08lue". Other users report the same.

Impact on users
Users cannot create a session.
Pls note - this is not time critical today (4th of September) due to the U.S. holiday.
Important information

Hub URL: https://nasa-veda.2i2c.cloud/

Tasks and updates

[x] Discuss and address incident, leaving comments below with updates
[x] Incident has been dealt with or is over
[ ] Copy/paste the after-action report below and fill in relevant sections
[ ] Incident title is discoverable and accurate
[ ] All actionable items in report have linked GitHub Issues

After-action report template
# After-action report

These sections should be filled out once we've resolved the incident and know what happened.
They should focus on the knowledge we've gained and any improvements we should take.

## Timeline

_A short list of dates / times and major updates, with links to relevant comments in the issue for more context._

All times in {{ most convenient timezone}}.

- {{ yyyy-mm-dd }} - [Summary of first update](link to comment)
- {{ yyyy-mm-dd }} - [Summary of another update](link to comment)
- {{ yyyy-mm-dd }} - [Summary of final update](link to comment)

## What went wrong

_Things that could have gone better. Ideally these should result in concrete
action items that have GitHub issues created for them and linked to under
Action items._

- Thing one
- Thing two

## Where we got lucky

_These are good things that happened to us but not because we had planned for them._

- Thing one
- Thing two

## Follow-up actions

_Every action item should have a GitHub issue (even a small skeleton of one) attached to it, so these do not get forgotten. These issues don't have to be in `infrastructure/`, they can be in other repositories._

### Process improvements

1. {{ summary }} [link to github issue]
2. {{ summary }} [link to github issue]

### Documentation improvements

1. {{ summary }} [link to github issue]
2. {{ summary }} [link to github issue]

### Technical improvements

1. {{ summary }} [link to github issue]
2. {{ summary }} [link to github issue]

Thanks for letting us know!  I'll create a corresponding support ticket and we'll take a look at it tomorrow.

Thank you for reporting this @j08lue, the incident should now be resolved! I've replied from the 2i2c support as well.

Confirmed, thanks!


Improve error handling

[ ] Improve error handling
[x] Add action button to ErrorView Done by #329
[x] Update i18n Done by #329

Closes #306

Closing now... , see https://github.com/thorchain/asgardex-electron/issues/306#issuecomment-671499458


Data entry RE improvement: Haughty Obstinacy

Haughty Obstinacy should get a Rule Element added to it, to convert failures to crit fails on Coerce actions.
Use the Self-Loathing feature of the Mitflit as inspiration.
It would also be nice to come up with some predicate for "If you roll a success on a saving throw against a mental effect that attempts to directly control your actions, you critically succeed instead."... but that's not really a specific trait.

This is not currently possible with the RE framework.


Customizable CharsetDecoder in AsyncCharConsumer

Some servers doesn't specify Content-Type header, while sending response in UTF-8. This change will allow to consume such servers responses properly.
Also, this will allow to specify content-type specific default charset. For example, application/json rfc requires unicode representation, so for json-responses UTF-8 can be used as the default charset.

bump

Patch committed with minor tweak to SVN trunk
http://svn.apache.org/r1657868
Oleg

Thanks a lot


Update example docs

Hi,
I think that the command used in the example is wrong
./webcachesim trace.txt LRU 30 0 10

Cheers,
Nick

Yes, you're right, that's old syntax for a previous version.
Correct syntax would be:
./webcachesim test.tr 0 LRU 30

We're actually currently working on another revision of the interface and a few new features. If there's interest we can update the code.
In any case, I'll just update the examples.

Updated the examples, and added an example request trace. For now, we're staying with the simple interface.


Positioning bugs out on changing size of steps.

I'm having this issue that i would greatly appreciate some help with.
I'm using a custom step extending NgFlowchartStepComponent, the component looks as so to start with

After adding some elements to said component it resizes to fill these elements. However it's positioning gets misaligned as so

Moving the step fixes alignment.

I've tried calling reRender on canvas when the size changes however i can not seem to fix it.
How can I fix this without moving the step?

Not that it helps you resolve the problem, but this has always been an issue. Without some sort of fix, it is recommended to keep your steps the same size once rendered.

Understood. However, a call to NgFlowchartCanvasDirective.getFlow().render() re-renders the page correctly. Is it not possible to detect step size changes?


Issue-69 SQFormDialogStepper expose a way to reset/clear steps values

Resolves #69
Currently, in the SQForm we have the SQFormResetButtonWithConfirmation that will reset all of the values of the form. We need to have a way to do something similar to that in the stepper. We can not use the SQFormResetButtonWithConfirmation component because it will reset all steps values and not just the current step. If we want to give the ability to reset the current steps values should there be a button in the footer or just a function that we call that is triggered by a consumer adding something like a TextButton to the body of the step?
Also using SQFormResetButtonWithConfirmation it just reset values to initialValues, if there is already a value present, it will reset to it, like in current loom we have address1: 'test' in initialValues so on clicking reset address1 is always set to test but we want it that address is cleared it should not have previous values it should empty the fields.
https://www.loom.com/share/5ca3e9797fd94c5a8e1f60e9ef641974

@umerjamal100 when you push up a new commit make sure you pick the right commit style.  In this case it should be "new feature".  This will make your commit message start with feat:  and that will tell our CI/CD pipeline to create a new tag of the library before it deploys.  Let me know if you have any questions on this.

@umerjamal100 when you push up a new commit make sure you pick the right commit style.  In this case it should be "new feature".  This will make your commit message start with feat:  and that will tell our CI/CD pipeline to create a new tag of the library before it deploys.  Let me know if you have any questions on this.

We need to add a notes MD file to describe this component and how to use it.  You can follow some of the other examples in the project.

We need to add a notes MD file to describe this component and how to use it.  You can follow some of the other examples in the project.

:tada: This PR is included in version 2.11.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.11.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


New Icon (v1.55) garbled under Big Sur M1 Mac mini

OS: macOS 11.2.3 (20D91)
Device: Mac mini (M1, 2020)
Desktop: Benq 24' inch 1080P
New Icon (v1.55) garbled under Big Sur M1 Mac both for apple scallion version and universal version.
But interestingly, there's no problem with my 13-inch M1 Macbook air, and it's this problem under the M1 Mac mini on my 24-inch external display.
The following example of icon garbled comes from Mac mini:
This is the installation package downloaded from the official website, you can see that after unziping its little icon is garbled:

This is the introduction to this unzipping installation package, you can see that the small icon is in disarray but the large icon is correct:

This is the display of the launch desk page, the same small icon is wrong but the big icon is correct:

VS Code version: Code 1.55.0 (c185983a683d14c396952dd432459097bc7f757f, 2021-03-30T16:07:58.402Z)
OS version: Darwin arm64 20.3.0
Remote OS version: Linux x64 4.15.0-20-generic

System Info

Item
Value

CPUs
undefined

GPU Status
2d_canvas: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
1, 1, 2

Memory (System)
8.00GB (0.11GB free)

Process Argv
--crash-reporter-id aebaf2e0-6548-4ea1-8ed8-5823f58efc9c

Screen Reader
no

VM
0%

Item
Value

Remote
SSH: g1080

OS
Linux x64 4.15.0-20-generic

CPUs
Intel(R) Core(TM) i7-6950X CPU @ 3.00GHz (20 x 3803)

Memory (System)
125.82GB (63.43GB free)

VM
0%

Extensions (25)

Extension
Author (truncated)
Version

bracket-pair-colorizer-2
Coe
0.2.0

remote-containers
ms-
0.166.0

remote-ssh
ms-
0.65.1

remote-ssh-edit
ms-
0.65.1

remote-wsl
ms-
0.54.6

vscode-remote-extensionpack
ms-
0.20.0

svg-preview
Sim
2.8.3

markdown-preview-github-styles
bie
0.1.6

path-intellisense
chr
2.3.0

EditorConfig
Edi
0.16.4

prettier-vscode
esb
6.3.1

code-runner
for
0.11.3

todo-tree
Gru
0.0.209

rainbow-csv
mec
1.8.1

vscode-filesize
mkx
3.1.0

python
ms-
2021.3.680753044

vscode-pylance
ms-
2021.3.4

jupyter
ms-
2021.5.702919634

cpptools
ms-
1.2.2

korofileheader
OBK
4.8.5

indent-rainbow
ode
7.5.0

svg-preview
Sim
2.8.3

tabnine-vscode
Tab
3.2.16

vscode-wakatime
Wak
5.0.1

markdown-all-in-one
yzh
3.4.0

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244:30276681
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30259475
pythonvsnew554:30281908
pythontbcf:30265426
openwsldoc:30282072
vspre833cf:30267465
pythonptprofiler:30281270
vshan820cf:30276953
pythondataviewer:30283453

And dragging the '/Applications/Visual Studio Code.app/Contents/Resources/Code.icns' file in the package file to the small icon in the upper left corner of the software's introduction page still doesn't solve the problem.

Same on Catalina (10.15.7), on an Intel MacBook Air. Dock icon fine, but smaller icon garbled.
![Screenshot 2021-04-01 at 06 49 28](https://user-images.githubusercontent.com/1935268/113249358-71730a80-92b6-11eb-83ab-5947d79c37a2.png
Version: 1.55.0
Commit: c185983a683d14c396952dd432459097bc7f757f
Date: 2021-03-30T16:01:05.981Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 19.6.0

Duplicate of #118754, #106429

macOS Big Sur 11.2.3 (20D91)

normal in dock
distorted in Finder toolbar

vscode info
Version: 1.55.0
Commit: c185983a683d14c396952dd432459097bc7f757f
Date: 2021-03-30T16:01:05.981Z (1 day ago)
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 20.3.0

Duplicate of #118754, #106429

Not sure it’s a duplicate of #106429 as it is just the icon affected for me.

@robjwells I agree with you and that's why I included #118754. Which had been marked as a duplicate of #106429

I can see the garbled icon too (macOS ARM).

@misolori this is just the icon, nothing else for me. And only in the menu such as here:

Same for me, got it on my Macbook (Catalina) and Mac Mini (Big Sur). Noticed it when I used the "open with".

Same here. Fresh install or not.
MaxBook Air M1.

Same issue here. Intel mac on Big Sur.
Seems only to be the smaller icons that are distorted.

@misolori this not an issue on the users' device but on the icn files we have shipped.
* Download https://github.com/microsoft/vscode-distro/raw/distro/quality/stable/resources/darwin/code.icns
* iconutil -c iconset -o /tmp/vscode.iconset ~/Downloads/code.icns
* 16x16, 32x32 and 48x48 are not correct however their 2x counterparts (hiDPI templates) are fine, that is why only certain set of users are seeing this issue.

@deepak1556 thanks for investigating this, marking as a candidate and will work on a fix for this.

same on mojave

The same issue here on macOS 11.2.3

I see the same issue on macOS 10.14.6 within Spotlight:

same issue on macOS 10.15.7

I've got updated icon files, can someone who's encountering this issue verify that these work?
Steps

Download and extract this zip file
Right-click on VS Code from finder > Get Info
Drag the new code.icns file into the top left of the Get Info window
Restart the dock by running  killall Dock from the terminal

I've got updated icon files, can someone who's encountering this issue verify that these work?
Steps

Close VS Code
Download and extract this zip file
Right-click on VS Code from finder > Get Info
Drag the new code.icns file into the top left of the Get Info window
Restart the dock by running  killall Dock from the terminal
Open VS Code

It is working fine now, I'm on Big Sur 11.2.3

I've got updated icon files, can someone who's encountering this issue verify that these work?
Steps

Close VS Code
Download and extract this zip file
Right-click on VS Code from finder > Get Info
Drag the new code.icns file into the top left of the Get Info window
Restart the dock by running  killall Dock from the terminal
Open VS Code

It works for me! Thank You !

I once had the same issue with a drive icon.

I've got updated icon files, can someone who's encountering this issue verify that these work?
Steps

Close VS Code
Download and extract this zip file
Right-click on VS Code from finder > Get Info
Drag the new code.icns file into the top left of the Get Info window
Restart the dock by running  killall Dock from the terminal
Open VS Code

Yes, does work, if you use this link you can pick which icons you like

I tried @DeveloperWOW64's solution and it only fixed the program but not the files that are able to be opened with VSCode.

@DeveloperWOW64 @heismauri let's please keep this issue focused on the official VS Code icons.

I tried @DeveloperWOW64's solution and it only fixed the program but not the files that are able to be opened with VSCode.

This is a MacBook Air (13-inch, 2017) running MacOS Catalina 10.15.7

There is a way to solve the file icons, I think

in the /Applications/Visual Studio Code.app/Contents/Resources/ are there any corrupted icns files that look similar to the him-ultimate.py icon?

Since a few people have already confirmed that the new fix works, going to lock this issue to reduce the noise. Thanks everyone in reporting this, will close this issue once the PR has been merged.

For verification:

cd into the directory that has the icns files
run iconutil -c iconset -o ~/Desktop/code-temp.iconset Code.icns to deconstruct icns file (this will create a folder on your desktop)
Open folder and verify that all icons appear normally without any glitches

Merged https://github.com/microsoft/vscode/commit/91fa7f030d2da54f381be16cd1855798a091727d


test webhook

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

Hi @adelina-t. Thanks for your PR.
I'm waiting for a  or e2e-win member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

/test pull-kubernetes-e2e-win

/test pull-kubernetes-e2e-win-fast


feat(GraphQL): add timing to Stakes query

Fixes/Implements Granola-Team/mina-indexer#751

Clippy is complaining: https://buildkite.com/granola/mina-indexer/builds/921#018f1648-9261-4b1f-a8d5-8a04da3022dc/22-75


Implement update state method

func updateState(_ newState: State) async -> Void { method now updates state. And it also calls transitionState to send some events. Implement all this to state machine.

This is no longer needed when using state machine.


Implement test env metrics node driver; test bugfixes

Closes https://github.com/rancher/opni/issues/1269
Fixes https://github.com/rancher/opni/issues/1270

Requires https://github.com/rancher/opni/pull/1282


/tmp/ride.log collision when multiple users using the same host and running ride.py in unix enviroments

In UNIX environments, if multiple users are runing ride.py from different VNC sessions, etc. on the same host, after the first session has created /tmp/ride.log, any other user trying to run ride.py will get a stack trace due to permissions denied error on /tmp/ride.log as the permissions are set by the first user running that file.  This is traced to code in robotide/context/logger.py in the '_init_' and '_output' methods of the 'Syslog' class.
As a workaround for UNIX environments, maybe prepend the ride.log filename with either the running userid or the PID of the ride.py process to create unique /tmp/*ride.log files per user or per session.

Please submit this to RIDE's tracker.

https://github.com/robotframework/RIDE/issues/1520


WIP: Adding a panel now loads it properties

Fixes #1172
openNewPanelDialog deals with newly added panels, it now calls the load member of the panel to load it's properties.
To do that I needed to have access to the RViz config file so I added a new member to the class holding the data structure. loadDisplayConfig fills this data member so that it is available later.
Fixes https://gitlab.com/InstitutMaupertuis/ros_additive_manufacturing/issues/127

You can easily test this PR with this package: https://gitlab.com/InstitutMaupertuis/rviz_plugin_load_bug

Let's say your panel is configurable and subscribes to topics to display their values (https://gitlab.com/InstitutMaupertuis/topics_rviz_plugin).

The topics to subscribe to are stored in the RViz config so that you don't have to re-configure the panel each time you launch RViz.
When you delete and add the panel again you don't expect your configuration to be lost.

With this configuration I have to subscribe to the topics after the load function has loaded everything that needs to be displayed (eg: https://gitlab.com/InstitutMaupertuis/topics_rviz_plugin/blob/melodic/src/display_topics.cpp#L72-73).
I understand that in the case the configuration is not right then the only option is to edit the RViz config file by hand which is not nice.
If my explanation is not clear please ask me for more details
Any ideas on how to fix this issue?

After thinking about it I think @rhaschke is right, it will not possible to add a "default" value panel anymore and that is a problem.
Closing as I don't think it is something that we want to do :)

When you delete and add the panel again you don't expect your configuration to be lost.

Here I would strongly disagree. When I delete a panel, I am fine with loosing its config.
If you don't want to loose the config, why would you delete the panel in first place?


Update your application id to add the Broker redirectUri if you haven't already

Hello :wave: I'm Tyler from the VS Code team. We noticed that this extension overrides the built-in Microsoft authentication EntraID application id. We wanted to inform you that VS Code will start acquiring auth sessions from the OS via the native token broker. On Windows, this will use WAM.
In order to support this and prevent downtime in your extension, all public client applications must include the broker redirectUri. Simply add this redirect Uri to your app registration in the Public Client section of the Azure portal:
ms-appx-web://Microsoft.AAD.BrokerPlugin/<your-client-id>

That's it! :tada: This will ensure that your extension continues to work seamlessly with the new authentication flow. If you have any questions or concerns, please don't hesitate to reach out to us. We're here to help! :smile:

Thank you @TylerLeonhardt! We will make this change ASAP. Is there a date when this will go into effect?

January. Although there is a setting that is opt-in that gets the new behavior so it is possible to be broken right now if you don't have this updated already.

"microsoft-authentication.implementation": "msal",

And don't forget to restart VS Code.
You must be on Windows x64 for the broker to be used.


feat: support for internationalisation

Implementation for #25.

:tada: This PR is included in version 2.3.0 :tada:
The release is available on:

Chrome Web Store
GitHub release

Your semantic-release bot :package::rocket:


get_digraph removes only one edge among multiple parallel edges

https://github.com/gboeing/osmnx/blob/677d13f56fa4894d51e07d502b1513f677262015/osmnx/utils_graph.py#L343
Consider the following code, for get_digraph.  I think it is incorrect.
  # identify all the parallel edges in the MultiDiGraph
   parallels = ((u, v) for u, v, k in G.edges(keys=True) if k > 0)

   # remove the parallel edge with greater "weight" attribute value
   for u, v in set(parallels):
       k, _ = max(G.get_edge_data(u, v).items(), key=lambda x: x[1][weight])
       to_remove.append((u, v, k))

   G.remove_edges_from(to_remove)

It apparently removes only one edge from each set of parallel edges.  This works in the case that the u-v pair has two parallel edges, but in the case that the u-v pair has three or more parallel edges, it won't --- after removing just one edge, the node pair (u, v) will still have  parallel edges.  I would have expected the code to instead delete all u-v edges except the one with minimum weight.
Am I missing something?

I think I see your reasoning here. So, rather than removing only the max k value from the edges, we should remove all but the min k value from the edges?

That makes sense to me, yes.

Right. Would you like to open a PR to contribute this?

I'm willing but don't know what that means.  I can suggest code if that would help.

Sure. Proposed code to resolve this would be useful.

Maybe replace the inner loop as follows?
  # identify all the parallel edges in the MultiDiGraph
   parallels = ((u, v) for u, v, k in G.edges(keys=True) if k > 0)

   # keep the parallel edge with minimum "weight" attribute value
   for u, v in set(parallels):
       k, _ = min(G.get_edge_data(u, v).items(), key=lambda x: x[1][weight])
       to_remove.extend((u, v, k1) for k1, _ in G.get_edge_data(u, v).items() if k1 != k)

   G.remove_edges_from(to_remove)

I haven't compiled or tested this code.

I think there is another bug, namely, in the identification of parallel edges here:
   # identify all the parallel edges in the MultiDiGraph
   parallels = ((u, v) for u, v, k in G.edges(keys=True) if k > 0)

It seems to me that the condition checked (existence of (u, v, k) with k > 0) is neither necessary nor sufficient for the graph to have a parallel edge.  I think it's possible that (u, v) can have just one edge, but with k > 0 (e.g. after another edge has been deleted).  I'm not sure about this, but I think I am encountering this case in my code.
Here is a possible patch:
       parallels = ((u, v) for u, v in G.edges(keys=False) if len(G.get_edge_data(u, v)) > 0)

I am not a networkx expert though, so caveat emptor.

@nealeyoung this should be fixed now via #826 if you'd be so kind as to take a look.


Added custom toasts

The toasts, as the Dialogs can have a custom template, and also they can receive a promise, so they've should have optional params too see example

Thanks for your efforts @flick36
Unfortunately I think that's too much to be included out of the box..
Custom toasts aren't that frequent.. and where you might need to use a custom toast, I don't think you'd need to use more than 1 (in most scenario)
Same for this PR jadjoubran/laravel-ng-artisan-generators#29

@flick36 I was just looking for this feature! Thank you so much! :+1: :smile:

@shiruken1 sure man, no problem.

Yeah generating less files on a dialog would work if you want 👍


update md_dqn

Description
Add DQN Multi-discrete Policy. Tested with sumo env
Related Issue
TODO
Add PPO and Rainbow
Check List

[ ] merge the latest version source branch/repo, and resolve all the conflicts
[ ] pass style check
[ ] pass all the tests

Codecov Report

Merging #51 (bf0218c) into main (54eb8aa) will decrease coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
- Coverage   88.94%   88.59%   -0.36%
==========================================
  Files         349      349
  Lines       25967    25673     -294
==========================================
- Hits        23097    22745     -352
- Misses       2870     2928      +58

Flag
Coverage Δ

unittests
88.59% <ø> (-0.36%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

ding/worker/collector/marine_parallel_collector.py
70.04% <0.00%> (-19.82%)
:arrow_down:

ding/entry/tests/test_parallel_entry.py
45.45% <0.00%> (-4.55%)
:arrow_down:

.../collector/tests/test_marine_parallel_collector.py
91.37% <0.00%> (-3.54%)
:arrow_down:

ding/envs/env_manager/subprocess_env_manager.py
80.87% <0.00%> (-2.55%)
:arrow_down:

ding/utils/tests/test_k8s_launcher.py
91.66% <0.00%> (-2.22%)
:arrow_down:

ding/entry/tests/test_serial_entry.py
77.04% <0.00%> (-2.22%)
:arrow_down:

ding/utils/tests/test_system_helper.py
80.00% <0.00%> (-1.82%)
:arrow_down:

ding/worker/collector/comm/flask_fs_collector.py
87.61% <0.00%> (-1.77%)
:arrow_down:

ding/rl_utils/tests/test_ppg.py
27.50% <0.00%> (-1.77%)
:arrow_down:

ding/rl_utils/tests/test_gae.py
61.90% <0.00%> (-1.74%)
:arrow_down:

... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54eb8aa...bf0218c. Read the comment docs.


Start minimized at runtime via either an internal setting or via a command line argument

I would like to start minimized. What is the ETA for the next release of UCR? This feature request was mentioned in the Discord group as far back as April and it was stated a new release was coming with the ability to start minimized, but it has not been added yet, almost a year later.

Hi! I'm using UCR for a while and this would be cool, as I am using the  commandline arguments to change profiles, I want UCR to be hidden.


Major Update

This is the major update of cycle bot since v0.1. After much thought,
I will now be primarily focusing on:

[ ] Working boosts System

[ ] Temporarily buff someone's stats
[ ] Spell system @Codemonkey51

[ ] Inspired by the bots, you can use this for enhanced buffs at the cost of a 25% chance of backfiring

[ ] Obtainable through items or drops only. Can be crafted.

[ ] Rebalancing many many things
[ ] Add many many new items
[ ] Add prestige @alanlichen once you get to 1T cycles I will consider actually implementing
[x] Redesign deteriorating code
[x] Improve code quality through eslint

edit: prestige is being added when it is.

Just for reference currently i have 390m cycles

lol nice

ok i'll put this into the next update, there's a few more things yet to add

Ok

by the way
what do you think about the chests
do they give too many items

I haven't tried them yet, in 30 min I can test

lemme test on discord now

It's a good amount!


Disable notifications

How to disable notifications on the Day planner, as I'm using it on a smart phone and it keeps distracting from what I plan to do. E.g. when I'm taking notes and changing and the notifications keep popping up it's quite disturbing is there any way to block the more doable the notifications if not can it be added to the feature request
thank you!

How to disable notifications on the Day planner, as I'm using it on a smart phone and it keeps distracting from what I plan to do. E.g. when I'm taking notes and changing and the notifications keep popping up it's quite disturbing is there any way to block the more doable the notifications if not can it be added to the feature request
thank you!

The way to stop notifications is to disable mermaid gantt in the plug-in options!
Once you are happy with your Notes in it, if you wish you can toggle it back.
It's a pretty nice workaround till it makes it to the feature list one day.
Happy days!

So the Gant chart cannot stay on the notes if you keep editing them. Must stay on a separate file.
Thank you all for replies.
Solved to me the notification annoyance.

Closing this as stale.


Mentioning somebody while editing a message doesn't show suggesting menu

I edited a message to mention one of my colleagues. The list with suggested users doesn't show up after typing a @ and the first letter. It works in the compose text area for new messages.

There's a tricky UX issue that we'll need to think about, which is what should the system do if you edit an old message to @-mention someone -- does it deliver them a new notification about a message that could be months old ?
Currently our solution to this is we don't supporting adding @-mentions to existing messages for this reason, which is why there's no autocomplete for mentions in the edit box (while there is for e.g. emoji).
The solution right now if you want to get someone's attention on a message you've already sent is to send a new message @-mentioning them and referring them to your previous message.
I'm open to supporting adding @-mentions when editing if someone has a good solution to the UX issues here.

Is the tricky part that you could double notify users that were already mentioned before? Do I get this right? Or is the issue only that the notification is about a old message?

No we can easily check if the person was already mentioned so that's not an issue -- it's just the issue with notifications about an old message.  If someone wanted to change this, I think it wouldn't be too hard to trigger a notification that's a bit different from the normal "new message" ones for the case of "someone edited a past message to @-mention you"

Ah, I see... Thanks for clearing up.

We've now changed message editing so that, in many realms, the window for editing an old message is only a few minutes long. In cases where the edit is necessarily within only a few minutes of the original message by dint of that short editing window, I'd love to be able to more easily @-mention a colleague while editing my original message.
I like the idea of the notification saying "[user] edited [this message], originally posted/last edited [timestamp/date], to mention you".

This would be great for someone to take up. Ping us on chat.zulip.org before starting, to nail down the exact behavior desired.

Some quick notes on how this should work:
The backend can check whether the user in question has read the message yet in do_update_message.  If they haven't, it can just update the message and proceed happily.  If the user has already read the message, then we need to notify the user, maybe with a "you have a new mention" email / desktop notification (depending on the user's configuration).