[Refactor] Report Settings Page to use Form component

@puneetlath, @mollfpr
Details

Refactor the Report Settings Page form to use Form.js.

Fixed Issues
$ #13915
https://github.com/Expensify/App/issues/13915#issuecomment-1368255827
Tests / QA Steps
Test 1

Open Any room
Go to settings of that room and try saving the name without any change
Verify you don't see any error

Test 2

Choose Any Room
Go to settings of that room
Clear the room name input and click Save
Verify that this error occur : Please enter a room name
Enter used room name and verify that this error occur : A room with this name already exists
Verify that this error occur at bottom ; Please fix the errors in the form before continuing.
Click on fix the errors and verify that the room name input is focused
Enter a valid room name and click save then close settings screen
Room Updated successfully
Verify that this text appears on the chat body : You renamed this room from #old to #new

[ ]   UI looks as it did before the refactor
[x]   Values can be added and edited
[x]   Errors are highlighted correctly (input border)
[x]   Error messages show up correctly
[ ]   Draft values are saved properly
[x]   Form alerts are displayed correctly
[x]   Clicking the fix the errors link focuses the first input with error
[x]   No duplicate submission of the form occurs (when it's already submitting)
[x]   Verify that no errors appear in the JS console

Offline tests
Test 1

Choose Room go to settings
Change the room name
Click Save
Verified that the form can be submitted and the button is enabled

Test 2

Open account in offline browser
Open same account on another online browser
Add new room on the online browser name it to newRoomTest and then close the browser
Go back to offline browser and continue there
Open an existing room and go to setting
Change the room name to newRoomTest
Click Save and verified that the form can be submitted and the button is enabled
Verify that the room header on the chat page changed to #newRoomTest
Now go from offline to online (same browser)
Verify that there is red Dot Indicator appears on chat header
Go to settings of that room
Verify that this error occur A room with this name already exists.
Click close button of that error and verify that the error dismissed
Verify that room name input holds the old room name value

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://user-images.githubusercontent.com/36869046/210188166-cf93d31b-824d-41ad-9b56-e1f327cb9cc4.mov

Mobile Web - Chrome

https://user-images.githubusercontent.com/36869046/210190051-dea082d9-88e2-4b15-8113-88858af35945.mov

Mobile Web - Safari
https://user-images.githubusercontent.com/36869046/210190411-18b475a7-8a9b-44e5-a030-11de5b4ac87a.mp4

Desktop
https://user-images.githubusercontent.com/36869046/210188230-b8c0842b-509a-47cb-8978-9986c1b130d7.mov

iOS
https://user-images.githubusercontent.com/36869046/210188514-49b0f110-bff5-4098-a6b3-db6a2a74ed93.mp4

Android
https://user-images.githubusercontent.com/36869046/210189435-e28cafc7-c367-4f95-82f2-811696e7f592.mov

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Testing now…

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Tested well on the online and offline cases and updated the checklist. There's an issue on mWeb/Chrome where the text disappears but I think I remember somewhere that we have a similar problem.

Tested well on the online and offline cases and updated the checklist. There's an issue on mWeb/Chrome where the text disappears but I think I remember somewhere that we have a similar problem.
cc @puneetlath @jasperhuangg

@mollfpr the reviewer checklist check is failing. Can you double-check you have the latest checklist?

@puneetlath we have two reviewer checklists , maybe 1st one is failing

@puneetlath I just copied again the reviewer checklist.

@jasperhuangg would you mind updating or deleting your checklist?

@puneetlath Thanks for the bump, I saw my review hadn't been addressed so I didn't start testing, but looks like there's been a lot of movement with this, nice! I've since deleted my checklist.

Gonna give this one last test, and if everything checks out I'll approve + merge 👍

🚀 Deployed to staging by @jasperhuangg in version: 1.2.48-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @luacmartins in version: 1.2.48-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @luacmartins in version: 1.2.49-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Unison language specification/examples

Hi,
I found your project and the lamdu project which seem to go a bit in the same interesting direction. Unison seems to have a slightly bigger goal with this whole networking etc. But I am wondering, did you specify the supported language somewhere?
Basically the same issue as https://github.com/lamdu/lamdu/issues/39
Daniel

No, there's no spec at the moment and the language is still very much in flux so I think it would be premature to start on one. :) The core language is less interesting to me than the overall platform and I'm more focused on getting the platform further along before diving too far into improving the language. I'm also hoping to make transparent Unison node upgrades part of the platform (this isn't written up anywhere yet), so there isn't as much pressure to get version 1 of the language perfect.
At the moment, the language is:

The lambda calculus, plus let and let rec bindings
The type system is an implementation of this paper

So not very exciting, but enough to write some useful programs and get all the pieces of the platform working together.
I should do a (somewhat speculative) blog post about generally where I see the core language going though. I'm going to leave this issue open until then.


Sync staging and prod

This PR syncs prod with staging so that its up to date with the latest features deployed on staging.
@luccasmmg @steveoni we need these three secrets added for the prod env

secrets.PROD_FRONTEND_NEXTAUTH_URL
secrets.PROD_NEXT_PUBLIC_GTM_ID
secrets.PROD_NEXT_PUBLIC_HOTJAR_ID

secrets.PROD_FRONTEND_NEXTAUTH_URL
This one is the same url as the actual frontend ex in dev its https://wri.dev.frontend.datopian.com
The other ones only stephen knows

This PR syncs prod with staging so that its up to date with the latest features deployed on staging.
@luccasmmg @steveoni we need these three secrets added for the prod env

secrets.PROD_FRONTEND_NEXTAUTH_URL
secrets.PROD_NEXT_PUBLIC_GTM_ID
secrets.PROD_NEXT_PUBLIC_HOTJAR_ID

@MuhammadIsmailShahzad we don't have any for prod. you can use the staging one for now.  we will need to ask them to provide one

@mpolidori Added here https://github.com/wri/wri-odp-secrets/blob/main/k8s-secrets/prod/wri-prod-migration-app-envvars.yaml and https://github.com/wri/wri-odp/pull/436/commits/5524c0b5d79eb8df7a368c207186bd59f5cbba6e

@steveoni ok using STAGING values for now. We can update once we have PROD values.


Add more dwarf version driver tests

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves #NNNNN, fix apple/llvm-project#MMMMM.

@swift-ci smoke test

@swift-ci smoke test


Verify nested component stuctures

Verify all use cases of nested component directory stuctures.
ie.
components
|-- c1
|--subcomp1a
|--subcomp1aa
|--subcomp1ab
|--subcomp1b
|-- c2

Just throwing this out there. It seems to work smoothly https://github.com/michaeljacobdavis/lazo-demo/tree/nested-components.
I also tested it on expo, and didn't have any problems.
@jstrimpel Are you aware of anything that would prevent this from working? Would this conflict with anything coming up?

Not that I can think of. I'm a bit hesitant to list it as a feature since
it will likely conflict with any packaging solution we open source. Also,
people will expect the same for the models. Have you looked at the
LAZO.files maps to make sure everything is still being found by the scanner?
On Wednesday, January 14, 2015, Michael Davis<EMAIL_ADDRESS>wrote:

Just throwing this out there. It seems to work smoothly
https://github.com/michaeljacobdavis/lazo-demo/tree/nested-components.
I also tested it on expo, and didn't have any problems.
@jstrimpel https://github.com/jstrimpel Are you aware of anything that
would prevent this from working? Would this conflict with anything coming
up?
—
Reply to this email directly or view it on GitHub
https://github.com/walmartlabs/lazojs/issues/173#issuecomment-69982404.

@jstrimpel No problem. LAZO.files has all the sub component pieces. I might try it this sprint on a section of the app and let it soak to see if I run into anything.


Allow Users to Control the URL the Binary Exports Span Data To

Right now it's hard-coded to point to http://localhost:4318/v1/traces since that's where it expects a local OpenTelemetry collector to be listening.
However I'm assuming folks might want to point the binary to export to deployed collectors not on their machine.

This one should just be creating a new CLI parameter for this and propagating it to the point where the hard-coding is currently happening and conditionally using it I think.

 Allow for consumers to pass their own endpoint pointing at the OTEL collector


feat: add courseaccessrole events

Description: Creates new data class and events for publishing information about the creation or removal of an LMS CourseAccessRole. We are not planning to account for the roles and permissions changes at this point, events would be based on how roles currently work.
This will be consumed by edx-exams to sync access to instructor tools and actions on the API.
Author concerns: These events will be used instead those added by https://github.com/openedx/openedx-events/pull/267. I plan to remove those in a separate PR since there is no plan to use those event definitions or supporting data classes.
Merge checklist:

[ ] All reviewers approved
[ ] CI build is green
[ ] Version bumped
[ ] Changelog record added
[ ] Documentation updated (not only docstrings)
[ ] Commits are squashed

Post merge:

[ ] Create a tag
[ ] Check new version is pushed to PyPI after tag-triggered build is
finished.
[ ] Delete working branch (if not needed anymore)

thanks @felipemontoya. I don't have write access to merge this. Is that something you can do or do I need to ping a specific maintainer?

Done: https://github.com/openedx/openedx-events/releases/tag/v9.4.0


#8788: Support fp32 dest acc en to moreh_linear OP

This PR adds the DeviceComputeKernelConfig parameter to operations like these functions.

moreh_linear
moreh_linear_backward
moreh_matmul
moreh_matmul_backward
moreh_bias_add_backward

This change will allow us to provide kernel configuration settings optionally during function calls.

@davorchap @TT-BrianLiu Would you please review this PR?

This PR adds the DeviceComputeKernelConfig parameter to operations like these functions.

moreh_linear

moreh_linear_backward

moreh_matmul

moreh_matmul_backward

moreh_bias_add_backward

This change will allow us to provide kernel configuration settings optionally during function calls.

@yugaoTT please take a look

Dear code owners @TT-BrianLiu, @tt-aho, @mywoodstock,
Would you please review this PR?
(CC @sangwon-chae)


added another solution of TwoSum in java

I added another (2nd) solution of TwoSum (leetcode-solution-curation\Algorithms\Easy\1_TwoSum) in the Java programming language. I used this code in solving the problem from my LeetCode account and it also got accepted.
I have also added necessary comments for better understanding to others.

Hi @FahimFBA
Thank you so much for your effort, really appreciate it! 😃
However, the basic idea of your solution is exactly same as this. Thus, I cannot accept this solution as a different approach.
You can provide a different solution using -

Two Pointer approach
Hash Map

Hi @FahimFBA
Thank you so much for your effort, really appreciate it! 😃
However, the basic idea of your solution is exactly same as this. Thus, I cannot accept this solution as a different approach.
You can provide a different solution using -

Two Pointer approach
Hash Map

I get it 😀
I'll try to submit those which haven't been added here yet now. Thanks a lot 😀


taskbar not display project name

Issue Type: Feature Request
taskbar and dockbar only display  "Code" ,how to config to show project or fordle name on taskbar icon title
VS Code version: Code 1.41.1 (26076a4de974ead31f97692a0d32f90d735645c0, 2019-12-18T14:57:51.166Z)
OS version: Darwin x64 19.2.0

@5dao the project name is usually presented in the title bar. Can you please be more preceise what you expect to see?

yes，mac dock hover tips

Perhaps a duplicate of #84195

@5dao can you provide a screen shot showing what you are missing where.

@5dao can you provide a screen shot showing what you are missing where.

thinks.

Thanks.

@5dao
Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

@5dao
Can you try to reproduce with our nightly insider builds? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

Thanks,Thanks all vscode !developers , @dbaeumer @bpasero @gjsjohnmurray


feat(event_area): copy log event to clipboard

fix #45

Codecov Report

Merging #48 (2a686a0) into master (46d7ab7) will decrease coverage by 0.36%.
The diff coverage is 26.66%.

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   69.32%   68.95%   -0.37%
==========================================
  Files          27       27
  Lines        1542     1556      +14
  Branches      300      307       +7
==========================================
+ Hits         1069     1073       +4
- Misses        294      304      +10
  Partials      179      179

Impacted Files
Coverage Δ

src/app.rs
69.29% <ø> (ø)

src/ui/event_area.rs
63.26% <26.66%> (-2.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d7ab7...2a686a0. Read the comment docs.


Datepicker selects day before with Australian timezone

case 332397

Unable to reproduce. Seems to be a something very specific to location.


bug fix for "Error: Unknown network" per Issue #1461

https://github.com/bitpay/bitcore/issues/1461

sorry wrong branch

Coverage remained the same at 83.315% when pulling 56523c7f9e1e1810a6b18040466d3a5b3e22b7de on nohea:master into 15de4716f72f4c65e802506249265546df846c7c on bitpay:master.


Update CircleCI notifications

See https://app.circleci.com/pipelines/github/lightstep/otel-launcher-java/22/workflows/c084e9e3-cdf5-4204-bceb-08038122be09 - it shows we are still running well after renaming this repo, yet I can't see any status indicator anywhere. Would you mind digging into this @malafeev ?

@carlosalberto looks fine, I added circleci badge to readme in #6

Closed via #6


[DO NOT MERGE] CI_test

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

none

/retest

/retest

/test all

@yutongz: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/pilot-presubmit.sh
c05f4db261ec7722734b6a28ec50581b11992259
link
/test pilot-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


add rendering of custom icon

Allow for use of custom icon passed through as a prop which is a function returning the icon. The custom icon can be manipulated using css classes to place it where needed, add animation or any other form of cutomization.

thank you for your contribution. I am currently trying to upgrade packages and documentatino based on your previous PR however having problem with rollup. Hopefully I will soon have it sorted.


Accessory not responding

Back again with another issue.
I tried to get it running on a Pi Zero running the homebridge image instead of using my 'desktop' raspi, now my purifier shows up in HK, but all I get from it is: "Not responding".
I've tried running the post-install steps, but still nothing.
Here's the log:
`Got SIGTERM, shutting down Homebridge...
[HB Supervisor] OS: Linux 5.4.51+ arm
[HB Supervisor] Node.js v12.18.2 /usr/local/bin/node
[HB Supervisor] Homebridge Path: /usr/local/lib/node_modules/homebridge/bin/homebridge
[HB Supervisor] UI Path: /usr/local/lib/node_modules/homebridge-config-ui-x/dist/bin/standalone.js
[HB Supervisor] Delaying Homebridge startup by 20 seconds on low powered serverLoaded config.json with 0 accessories and 2 platforms.
Loaded plugin<EMAIL_ADDRESS>Registering platform 'homebridge-config-ui-x.config'
Loaded plugin<EMAIL_ADDRESS>Registering platform 'homebridge-philips-air.philipsAir'
Loading 2 platforms...
[Config] Initializing config platform...
[Config] Running in Service Mode
[Philips Air] Initializing philipsAir platform...
[Philips Air] Initializing platform accessory Purifier...
[Philips Air] Unable to load firmware info: Error: spawnSync python3 ETIMEDOUT
[Philips Air] Unable to load status info: Error: spawnSync python3 ETIMEDOUT
[Philips Air] Unable to load filter info: Error: spawnSync python3 ETIMEDOUT
Setup Payload:
X-HM://0024N25LG8K8K
Enter this code with your HomeKit app on your iOS device to pair with Homebridge:
┌────────────┐
│ 7XX-XX-XX6 │
└────────────┘

Homebridge is running on port 5XX8.`
I tried to increase the time-out from 5 to 30 seconds, that takes away the load Errors, but other than that the result is still the same.

Sounds like python3 or some other dependency might not be installed correctly? How did you install the plugin?

I ran the command in the cli as described in the readme
Sent with GitHawk

Did any errors occur during install? Are you sure you used --unsafe-perm?
If so, you could try going through the manual install steps: https://github.com/Sunoo/philips-air#manual-post-install-steps

I don't recall any errors, and I already ran the manual post install.
I tried running the install and post install again to see what comes up.
What stands out:

When I run the 'normal' install again, it keeps telling me it has updated 1 package, every time.

When running the post install, on step 3, (CoAPthon3 update) it tells me this:
Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple Collecting git+https://github.com/Tanganelli/CoAPthon3@89d5173 Cloning https://github.com/Tanganelli/CoAPthon3 (to revision 89d5173) to /tmp/pip-req-build-bi50626m Did not find branch or tag '89d5173', assuming revision or ref. Building wheels for collected packages: CoAPthon3 Running setup.py bdist_wheel for CoAPthon3 ... done Stored in directory: /tmp/pip-ephem-wheel-cache-ruehs1ry/wheels/63/8f/99/012c8b6374fe3a573d1106deeac84fa79e12b5be12fa19d457 Successfully built CoAPthon3 Installing collected packages: CoAPthon3 Found existing installation: CoAPthon3 1.0.1   Uninstalling CoAPthon3-1.0.1:     Successfully uninstalled CoAPthon3-1.0.1 Successfully installed CoAPthon3-1.0.1

That's expected. If you wanted to do a full reinstall, you have to sudo npm uninstall -g homebridge-philips-air first.
And CoAPthon always throws that during installation. I tried to find a way to tell it that is expected, but there didn't seem to be a way to do that.

I tried that, then reinstalled. Same result.
It did save the settings and config, but nothing noteworthy in the output as far as I can tell:

<EMAIL_ADDRESS>postinstall /usr/local/lib/node_modules/homebridge-philips-air/node_modules/philips-air
node postinstall.js

$ apt-get install -y python3-pip git
Reading package lists... Done
Building dependency tree
Reading state information... Done
git is already the newest version (1:2.20.1-2+deb10u3).
python3-pip is already the newest version (18.1-5+rpt1).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
$ pip3 install -U py-air-control git+https://github.com/Tanganelli/CoAPthon3@89d5173
Looking in indexes: https://pypi.org/simple, https://www.piwheels.org/simple
Collecting git+https://github.com/Tanganelli/CoAPthon3@89d5173
Cloning https://github.com/Tanganelli/CoAPthon3 (to revision 89d5173) to /tmp/pip-req-build-1l20ivvv
Did not find branch or tag '89d5173', assuming revision or ref.
Requirement already up-to-date: py-air-control in /usr/local/lib/python3.7/dist-packages (2.1.0)
Requirement already satisfied, skipping upgrade: pycryptodomex>=3.4.7 in /usr/local/lib/python3.7/dist-packages (from py-air-control) (3.9.8)
Building wheels for collected packages: CoAPthon3
Running setup.py bdist_wheel for CoAPthon3 ... done
Stored in directory: /tmp/pip-ephem-wheel-cache-lzo4yq08/wheels/63/8f/99/012c8b6374fe3a573d1106deeac84fa79e12b5be12fa19d457
Successfully built CoAPthon3
Installing collected packages: CoAPthon3
Found existing installation: CoAPthon3 1.0.1
Uninstalling CoAPthon3-1.0.1:
Successfully uninstalled CoAPthon3-1.0.1
Successfully installed CoAPthon3-1.0.1
Checking /etc/sysctl.conf for net.ipv4.ping_group_range...
net.ipv4.ping_group_range already set:
net.ipv4.ping_group_range=0 1000
net.ipv4.ping_group_range=0 1000

<EMAIL_ADDRESS>added 9 packages from 9 contributors in 78.66s

Huh, that all looks good, let me do some digging to see what I can figure out.

The logs now do show a spawn sync error, I've tried googling that, but none the wiser...

[Config] Homebridge restart request received
[Config] No restart command defined, killing process...
[HB Supervisor] Stopping services...
[HB Supervisor] OS: Linux 5.4.51+ arm
[HB Supervisor] Node.js v12.18.2 /usr/local/bin/node
[HB Supervisor] Homebridge Path: /usr/local/lib/node_modules/homebridge/bin/homebridge
[HB Supervisor] UI Path: /usr/local/lib/node_modules/homebridge-config-ui-x/dist/bin/standalone.js
[HB Supervisor] Delaying Homebridge startup by 20 seconds on low powered server
[HB Supervisor] Starting Homebridge with extra flags: -I
[HB Supervisor] Started Homebridge v1.1.2 with PID: 1859
[Config] Homebridge Config UI X v4.25.2 is listening on :: port 8581
Loaded config.json with 0 accessories and 2 platforms.
Loaded plugin<EMAIL_ADDRESS>Registering platform 'homebridge-config-ui-x.config'
Loaded plugin<EMAIL_ADDRESS>Registering platform 'homebridge-philips-air.philipsAir'
Loading 2 platforms...
[Config] Initializing config platform...
[Config] Running in Service Mode
[Philips Air] Initializing philipsAir platform...
[Philips Air] Initializing platform accessory Purifier...

You never shared your config, so I can’t write up the exact command for you, but have you tried reading from your purifier using airctrl?

It's the same as in my previous issue ;), but I've inserted it below anyway.
No I haven't, how do I use airctrl?

{
"bridge": {
"name": "Homebridge C086",
"username": "0X:XX:XX:XX:XX:X6",
"port": 5XX8,
"pin": "7XX-XX-XX6"
},
"accessories": [],
"platforms": [
{
"name": "Config",
"port": 8581,
"platform": "config"
},
{
"devices": [
{
"name": "Purifier",
"ip": "<IP_ADDRESS>",
"protocol": "coap",
"sleep_speed": true
}
],
"name": "Philips Air",
"timeout_seconds": 30,
"platform": "philipsAir"
}
]
}

Oh right, sorry about that. I'm juggling a lot of open issues across several projects. Thanks for reposting it.
From the terminal, run airctrl  --ipaddr <IP_ADDRESS> --protocol coap, and let me know what happens.

Don't be sorry, I'm the one that feels like a pain in the rear coming up with issues ;)
Below the response, it then get stuck on that.

Give up on message From None, To ('<IP_ADDRESS>', 5683), CON-6970, POST-vV, [Uri-Path: sys, Uri-Path: dev, Uri-Path: sync, ] B965EB45...8 bytes
Traceback (most recent call last):
File "/usr/local/bin/airctrl", line 10, in
sys.exit(main())
File "/usr/local/lib/python3.7/dist-packages/pyairctrl/airctrl.py", line 448, in main
c = CoAPCli(device["ip"], debug=args.debug)
File "/usr/local/lib/python3.7/dist-packages/pyairctrl/airctrl.py", line 15, in init
self._client = CoAPAirClient(host, port, debug)
File "/usr/local/lib/python3.7/dist-packages/pyairctrl/coap_client.py", line 80, in init
self._sync()
File "/usr/local/lib/python3.7/dist-packages/pyairctrl/coap_client.py", line 91, in _sync
self.client_key = self.client.post("/sys/dev/sync", self.syncrequest).payload
AttributeError: 'NoneType' object has no attribute 'payload'

Okay, well at least now we have an error message. The best approach might be to open an issue with that project, but let me see what I can figure out first.
Are you sure the unit is using CoAP? You could try airctrl --ipaddr <IP_ADDRESS> --protocol plain_coap or airctrl --ipaddr <IP_ADDRESS> --protocol http and see if either of those work any better. I'm vaguely remember confirming that your unit doesn't use HTTP though.

I've tried all three already to no end.
Response using plain_coap:

Give up on message From None, To ('<IP_ADDRESS>', 5683), CON-48366, EMPTY-None, [] No payload

Response using http:

Exchanging secret key with the device ...
Traceback (most recent call last):
File "/usr/lib/python3.7/urllib/request.py", line 1324, in do_open
encode_chunked=req.has_header('Transfer-encoding'))
File "/usr/lib/python3.7/http/client.py", line 1244, in request
self._send_request(method, url, body, headers, encode_chunked)
File "/usr/lib/python3.7/http/client.py", line 1290, in _send_request
self.endheaders(body, encode_chunked=encode_chunked)
File "/usr/lib/python3.7/http/client.py", line 1239, in endheaders
self._send_output(message_body, encode_chunked=encode_chunked)
File "/usr/lib/python3.7/http/client.py", line 1026, in _send_output
self.send(msg)
File "/usr/lib/python3.7/http/client.py", line 966, in send
self.connect()
File "/usr/lib/python3.7/http/client.py", line 938, in connect
(self.host,self.port), self.timeout, self.source_address)
File "/usr/lib/python3.7/socket.py", line 727, in create_connection
raise err
File "/usr/lib/python3.7/socket.py", line 716, in create_connection
sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/bin/airctrl", line 10, in
sys.exit(main())
File "/usr/local/lib/python3.7/dist-packages/pyairctrl/airctrl.py", line 444, in main
c = HTTPAirCli(device["ip"])
File "/usr/local/lib/python3.7/dist-packages/pyairctrl/airctrl.py", line 100, in init
self._client = HTTPAirClient(host, debug)
File "/usr/local/lib/python3.7/dist-packages/pyairctrl/http_client.py", line 108, in init
self.load_key()
File "/usr/local/lib/python3.7/dist-packages/pyairctrl/http_client.py", line 156, in load_key
self._get_key()
File "/usr/local/lib/python3.7/dist-packages/pyairctrl/http_client.py", line 119, in _get_key
with urllib.request.urlopen(req) as response:
File "/usr/lib/python3.7/urllib/request.py", line 222, in urlopen
return opener.open(url, data, timeout)
File "/usr/lib/python3.7/urllib/request.py", line 525, in open
response = self._open(req, data)
File "/usr/lib/python3.7/urllib/request.py", line 543, in _open
'_open', req)
File "/usr/lib/python3.7/urllib/request.py", line 503, in _call_chain
result = func(*args)
File "/usr/lib/python3.7/urllib/request.py", line 1352, in http_open
return self.do_open(http.client.HTTPConnection, req)
File "/usr/lib/python3.7/urllib/request.py", line 1326, in do_open
raise URLError(err)
urllib.error.URLError: <urlopen error [Errno 111] Connection refused>

I’d recommend taking the output of those 3 commands and opening an issue on py-air-control: https://github.com/rgerganov/py-air-control

Done.
I am running a AC1214/10 though, so I'm a bit confused as to which does what for which model.

Right, so I tried to run the airctrl soap command again a while later, now the response is this:

[name]                        Name: Living Room
[type]                        Type: AC1214
[modelid]                     ModelId: AC1214/10
[swversion]                   Version: 2.0.0
[om]                          Fan speed: 2
[pwr]                         Power: ON
[cl]                          Child lock: False
[aqil]                        Light brightness: 0
[uil]                         Buttons light: OFF
[mode]                        Mode: night
[pm25]                        PM25: 31
[iaql]                        Allergen index: 6
[aqit]                        Air quality notification threshold: 10
[ddp]                         Used index: IAI
[fltt1]                       HEPA filter type: NanoProtect Filter Series 3 (FY2422)
[fltt2]                       Active carbon filter type: NanoProtect Filter AC (FY2420)
[fltsts0]                     Pre-filter and Wick: clean in 265 hours
[fltsts1]                     HEPA filter: replace in 4705 hours
[fltsts2]                     Active carbon filter: replace in 2305 hours
[ota]                         Over the air updates: no
[Runtime]                     Runtime: 0.91 hours
[WifiVersion]                 WifiVersion<EMAIL_ADDRESS>[ProductId]                   ProductId: dca8c9d2f2ab11e8a1e3061302926720
[DeviceId]                    DeviceId: 1c02e184da5a11eaa4baeadb19baab40
[StatusType]                  StatusType: localcontrol
[ConnectType]                 ConnectType: Localcontrol

Still the same result in HK though

Interesting, I wonder why that command only works sometimes for you...

Well, as Philips' own app isn't working consistently as well, that might be a result of the purifiers connection dropping out for some reason.

Sounds like that’s the root of the problem. Get the official app working first, and I think it should work in the plugin.

Right, so it seems that connection has held steady overnight, but the response is still #https://github.com/Sunoo/homebridge-philips-air/issues/31#issuecomment-674232092


applied pep8 rules

applied style for most of locations reported by this line:
find . -name '*.py' -not -path '*/.*' -exec pep8 {} --max-line-length 160 --ignore E701 \;

@tfoote - can you take a look here?

hmm - the tooling proposed to merge towards ros:master but the checker seems to choke because there is no ros:master.
galactic might be the default on ros: - but of course there are also e.g. humble or rolling.
:-/

Is there any proposal here to add in an enforcer for this choice of formatting style? Doing a pass on the code is all well and good (if one agrees with the choice of formatter, which I have no opinion on in this case) but unless a linter is plugged in  to review PRs moving forward then it won't stick - and if it's not enforced then philosophically I lean against  changing the existing code even if it is a functional no-op.

**Validate rosdistro / rosdistro / rosdep checks (3.8) (pull_request) ** Failing after 12m

just a short blink here - not sure if that is "good" already or if this is relevant here... but there are checks:
"Validate rosdistro / rosdistro / rosdep checks (3.8) (pull_request) Failing after 12m"

PEP8 is the base "standard"

That's fine. It's not what I was trying to comment on. I'm saying - "if you want to enforce a code formatting standard on this repository, then add automated tooling that enforces it". Pytest is being run on the repo in the PR checker, so maybe a pytest that checks pep8 formatting for the repo? Or if that has issues then at least a separate Github Action?

It is useful to conform with the standard. Though there's overhead to general refactors in terms of maintainability. So I agree with Emerson's suggestion that to take this effort we should also add the linter such as flake8 to the unit tests.
Picking one off the top of my head rosdep has an example: https://github.com/ros-infrastructure/rosdep/blob/master/test/test_flake8.py

Thanks for the PR!
It looks like it's been a little while, and there's now a merge conflict. I'll close this for now, but we can reopen once there's a unit test to make sure the style sticks.


Cannot test errors from GetRole to differentiate role not existing from more general errors

After calling AuthRoleAPI.GetRole, and receiving a response where err != nil, I have no (sane) way of differentiating situations where err != nil due to the requested role not existing, and cases where err != nil due to a more generic error.
Below is an example of a function where I attempted to gain this functionality by repurposing IsKeyNotFound to test the error. Adding a IsRoleNotFound would solve this problem, though I don't know how scalable that is.
import (
	etcd "github.com/coreos/etcd/client"
)

//
// ...
//

func ensureDefaultUserRole() error {
	roleAPI := etcd.NewAuthRoleAPI(etcdClient)
	_, err := roleAPI.GetRole(context.TODO(), defaultUserRole)
	if err == nil {
		return nil

	} else if !etcd.IsKeyNotFound(err) {
		return errors.Wrap(err, "Failed to get default user role")
	}

	err = roleAPI.AddRole(context.TODO(), defaultUserRole)
	if err != nil {
		return errors.Wrap(err, "Failed to create default user role")
	}
	_, err = roleAPI.GrantRoleKV(context.TODO(), defaultUserRole, defaultUserRWPaths, etcd.ReadWritePermission)

	if err != nil {
		return errors.Wrap(err, "Failed to grant default user role")
	}
	return nil
}

@mitake Can you please take a look?

@xiang90 @bluepeppers sure, I'm looking at the problem. I'll reply soon.

@bluepeppers 's idea of adding IsRoleNotFound() seems to be good to me. But currently it is hard because the error code isn't propagated well. It is because both of the server and the client library don't marshal and unmarshal error code:

server side: https://github.com/coreos/etcd/blob/master/etcdserver/api/v2http/httptypes/errors.go#L31
client side: https://github.com/coreos/etcd/blob/master/client/auth_user.go#L115

@xiang90 if the ignoring of the error code isn't intentional, marshaling/unmarshaling the code would be ok for the idea because it doesn't break compatibility of APIs. How do you think?


Update versions (with one other small clarification)

This build https://travis-ci.org/travisbrown/circe/jobs/86886404 which should use Scala 2.10.6 compiles with 2.11.7. I think you are also hitting https://github.com/scoverage/sbt-scoverage/issues/146

:+1:

@fthomas Oh, ouch! I guess the best thing to do is roll back to 1.2.0 for now?

@travisbrown That is what I did in refined.

@fthomas Thanks for catching that! I've just pushed a fix.

Current coverage is 68.61%

Merging #72 into master will not affect coverage as of 15190e2

Powered by Codecov. Updated on successful CI builds.


Manage outreach plan for states to offer OTC

Summary - We are receiving OTC data; here’s how you can access it, if you want it
Personalized based on status
-How they want OTC data (or not)
-Whether they have web receiver or not
How they want file named, if different from default (https://app.zenhub.com/workspaces/prime-data-hub-5ff4833beb3e08001a4cacae/issues/cdcgov/prime-data-hub/1245)
Check if PHDs want the files delivered to staging or test folders first, or straight to prod


[FEAT] Automatic updates should be enabled by default

A side effect of moving away from uBlue is the loss of its enabling the rpm-ostreed-automatic.timer and flatpak-user-update.timer. If we want automatic updates enabled by default, these may need to be active. Some desktop environments provide systems for automatic updates via rpm-ostree and/or flatpak, and may not need the timers.
Describe the benefit this feature would provide to the project
Automatic updates or at least update checks appear to be the norm for PCs. I'd wager most users expect them to be enabled by default.
Describe the solution you'd like
I recommend simply enabling said timers on all images. On certain desktops it may be redundant, and may preempt some of the features of said desktops, but it would make certain updates are occurring regularly.
Describe alternatives you've considered
Images whose desktops do not already provide automatic update checks (and execution or notification) for rpm-ostree and/or flatpak should ship with the rpm-ostreed-automatic.timer and/or flatpak-user-update.timer enabled. It would be vital to verify which desktops reliably provide automatic updates for both rpm-ostree and flatpak.
Declaration

[x] I declare that I have read the README and my feature request is in-scope.

We install ublue updates services from config already. What gaps are you seeing?

The rpm-ostreed-automatic.timer, flatpak-user-update.timer and flatpak-system-update.timer are all preset disabled. in order to enable automatic updates these need to be enabled (except in certain DEs).
The ujust toggle-updates command allows users to conveniently enable all of them. perhaps yafti should offer to run it, or at least it should be added to the post-install instructions.
My initial issue mistakenly suggested the flatpak-user-update.timer was missing, but that was a mistake on my part. I also assumed the move away from uBlue caused the change in functionality, but that's not the only possible explanation.

Let me pull up a fresh VM. Regardless we can fore enable all of them in the build

https://github.com/secureblue/secureblue/commit/b66a70eb600f002c08586c9ccf6c2a24c8607249


Go to Definition refers to VSCode node_modules instead of project's node_modules

Issue Type: Bug
I'm working on an Angular 9 project and was working on a feature where I needed the bind() method. Currently we have Typescript 3.7.5 which has the following interface in their Function interface:
bind(this: Function, thisArg: any, ...argArray: any[]): any;

This made the return type as any which led to an error in my editor. I thought this was a mistake since this was a "resolved" issue (https://github.com/microsoft/TypeScript/issues/212) in a 2018 PR (https://github.com/microsoft/TypeScript/pull/27028) of a previous TypeScript version. (Still don't know why in this 3.7.5 version bind() returns any if it was resolved 2 years ago but that's another issue...)
So, I tried deleting node_modules, and (just to experiment) I tried ⌘+Clicking on the bind() method and it redirected me to the node_modules/typescript definition inside VSCode app contents. You can see the path in this image.
VSCode refering to it's node_modules typescript version definition:

This made the initial error disappeared (which is bad) and that's because VSCode has a different TypeScript version: "typescript": "^4.1.0-dev.20201018" which has a different interface for bind() and actually returns the method's type correctly:
bind<T>(this: T, thisArg: ThisParameterType<T>): OmitThisParameter<T>;

Then I did an npm install to get my project's node_modules again, I tried ⌘+Clicking again but now it always refers to VSCODE node_modules instead of the project's node_modules.
I've opened multiple Angular projects and does the same thing.
Also, I disabled all extensions and this still happens.
Steps to Reproduce:
I can't reproduce the issue because I can't make it work in order to make it happen again but starting from step 3 this is what I did:

Create an Angular project with TypeScript 3.7.5 (Setup 1/2)
Run npm install (Setup 2/2)
Write a function which has a bind method (although I think it could be any Typescript definition)
⌘+Click Should work well and refer to the project's node_modules
Delete node_modules folder
⌘+Click again and should refer to VSCode node_modules
Try npm install and ⌘+Click again and should still refer to VSCode node_modules

VS Code version: Code 1.51.1 (e5a624b788d92b8d34d1392e4c4d9789406efe8f, 2020-11-11T01:11:34.018Z)
Commit: e5a624b788d92b8d34d1392e4c4d9789406efe8f
Date: 2020-11-11T01:11:34.018Z
Electron: 9.3.3
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS version: Darwin x64 19.6.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledwebgl: enabledwebgl2: enabled

Load (avg)
1, 2, 2

Memory (System)
64.00GB (44.52GB free)

Process Argv
-psn_0_53261 --crash-reporter-id 3470d9bf-740d-480c-9373-b5fb05183146

Screen Reader
no

VM
0%

Extensions: none

Sexy Lady daddy
On Sat, Nov 14, 2020, 7:13 AM Luis Gerónimo<EMAIL_ADDRESS>wrote:

Issue Type: Bug
I'm working on an Angular 9 project and was working on a feature where I
needed the bind() method. Currently we have Typescript 3.7.5 which has the
following interface in their Function interface:
bind(this: Function, thisArg: any, ...argArray: any[]): any;
This made the return type as any which led to an error in my editor. I
thought this was a mistake since this was a "resolved" issue (
microsoft/TypeScript#212
https://github.com/microsoft/TypeScript/issues/212) in a 2018 PR (
microsoft/TypeScript#27028
https://github.com/microsoft/TypeScript/pull/27028) of a previous
TypeScript version. (Still don't know why in this 3.7.5 version bind()
returns any if it was resolved 2 years ago but that's another issue...)
So, I tried deleting node_modules, and (just to experiment) I tried ⌘+
Clicking on the bind() method and it redirected me to the
node_modules/typescript definition inside VSCode app contents. You can see
the path in this image.
VSCode refering to it's node_modules typescript version definition
https://imgur.com/wPjTOf4
This made the initial error disappeared (which is bad) and that's because
VSCode has a different TypeScript version: "typescript":
"^4.1.0-dev.20201018" which has a different interface for bind() which
actually returns the return type correctly:
bind(this: T, thisArg: ThisParameterType): OmitThisParameter;
Then I did an npm install to get my project's node_modules again, I
tried ⌘+Clicking again but now it always refers to VSCODE node_modules
instead of the project's node_modules.
I've opened multiple Angular projects and does the same thing.
Steps to Reproduce:
I can't reproduce the issue because I can't make it work in order to make
it happen again but starting from step 3 this is what I did:

Create an Angular project with TypeScript 3.7.5 (Setup 1/2)
Run npm install (Setup 2/2)
Write a function which has a bind method (although I think it could
be any Typescript definition)
⌘+Click Should work well and refer to the project's node_modules
Delete node_modules folder
⌘+Click again and should refer to VSCode node_modules
Try npm install and ⌘+Click again and should still refer to VSCode
node_modules

VS Code version: Code 1.51.1 (e5a624b788d92b8d34d1392e4c4d9789406efe8f, 2020-11-11T01:11:34.018Z)
Commit: e5a624b788d92b8d34d1392e4c4d9789406efe8f
Date: 2020-11-11T01:11:34.018Z
Electron: 9.3.3
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS version: Darwin x64 19.6.0
System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 1, 2, 2
Memory (System) 64.00GB (44.52GB free)
Process Argv -psn_0_53261 --crash-reporter-id
3470d9bf-740d-480c-9373-b5fb05183146
Screen Reader no
VM 0% Extensions: none
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/110631, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARXOUAJCRHY5ZN7KCI3KCITSPZX6RANCNFSM4TVQKLWQ
.

/needsMoreInfo
What is value for typescript.tsdk for this workspace?
You are referring to built-in TS type in lib.es5.d.ts that will be used from currently active TS instance for VSCode which will be different from one in node_modules unless configured in this way.
By default VS Code will use built-in TS version and therefore all TS provided types will refer to built-in libs.
If you want to use local TS definition you need to use local TS version: see https://code.visualstudio.com/docs/typescript/typescript-compiling#_using-the-workspace-version-of-typescript
Please be aware that if you use local TS version 3.7.5 you won't have have any TS checks/suggestions/refactorings that are available only in 3.8+

By default VS Code will use built-in TS version and therefore all TS provided types will refer to built-in libs.
If you want to use local TS definition you need to use local TS version: see https://code.visualstudio.com/docs/typescript/typescript-compiling#_using-the-workspace-version-of-typescript

Thank you, changing it to the local 3.7.5 now I see the error I used to have, which is good because that's the same error I see when building the app.
That means typescript.tsdk was using the built-in TS version. (And I didn't have any specification for that so it was using the default.)
But there is something I don't get and it's driving me crazy.
I've checked up with my teammates and they are using the built-in TS version just like you said VS Code does that by default. So I now realize that I was using the built-in TS version too before and during this issue. BUT I notice a difference.
Just to give some context again, there's 2 bind() type definitions:

VS Code built-in TS version (which returns type correctly):

Local 3.7.5 TS version (which returns any as type):

I asked a teammate to make a method using the bind() and hovering on it to see the return type and see which type definition it's referring to. This is how it's showing to him and it's how it showed to me before the issue (Second definition):

And this is how it's showing to me now (First definition):

And we both have the 4.0.3 Typescript version.
Why is this a problem?
Well, I'm using @ngrx/effects and they expect a not unknown return type method. Now that VS Code it's referring to it's TS version, I don't get that warning on my editor in my *.effects.ts but when building the app it detects the error. So this makes me insecure when writing code thinking maybe I'm not seeing errors I will see when building the app.
Hope I could explain my problem. Thank you!

I've solved it. Just deleted that extra line in VS Code built-in TS definition.
What I'm thinking is that I may have put that line myself and therefore fooling myself after. I just don't remember doing that... I may need a rest.
But, well... I think it's solved and learned something new about VS Code. Always thought it used the local node_modules.
Still have the doubt about why is the bind method returning any but that's definitely not an issue with VS Code.

Please be aware that if you use local TS version 3.7.5 you won't have have any TS checks/suggestions/refactorings that are available only in 3.8+

Also, Is there documentation about what you said over here? Just to know more about those features. I saw the link but didn't see specification about using TypeScript 3.8 or higher for these VS Code features.
Thanks!

Ok, after some research I've found out that in order to have strict type for bind, call and apply methods you need to set the strictBindCallApply flag as true in your tsconfig.json file inside  the compilerOptions key. TypeScript 3.2 Handbook
And that's the version in which the 2018's PR I mentioned was accepted. So all makes sense now.
I leave it here in case someone is lost like me in the future.

Closing since this sounds like the expected behavior


L1 Q5: Alternative Representation of Point

Q5: Provide another way to represent the x- and y- coordinates of Point. Modify the distanceTo method so as to make use of this new representation. Will this affect how the client uses Point?
class Point {
      private final double distance;       // distance here refers to the distance from point to origin
      private final double theta;
      Point (double distance, double theta) {
            this.distance = distance;
            this.theta = theta;
      }
      double distanceTo (Point p) {
             double x = this.distance * Math.cos(this.theta) - p.distance * Math.cos(p.theta);
             double y = this.distance * Math.sin(this.theta) - p.distance * Math.sin(p.theta);
             return Math.sqrt(x * x + y * y);
      }
      public String toString() {
             return "(" + this.distance + ", " + this.theta + ")";
      }
}

Yes, the client will need to convert all cartesian coordinates to polar coordinates.

But if you are the circle, nothing ever changes. That's why you go use Tell-Don't-Ask: in case someone has a brilliant idea to do an alternative implementation of a dependent class, there is minimal changes except just changing how I input a Point and pass into a Circle.

This is an interesting way of implementing Point! But, I agree with the above comment. I think how the client creates a point will change (eg inputting distance and theta instead of providing x and y coordinates) but how the client uses the Point class should stay the same. For example, how the method contains(Point point) in the Circle class uses a Point object does not change. The contains(Point point) method uses the distanceTo method from the Point class but Circle does not need to know how distanceTo is implemented, it just needs to know what distanceTo does, hence so long as distanceTo is implemented correctly, the contains(Point point) method should work properly as well.

Good observations...  If creating a Point necessitates taking in two double values, then whether the two values specifies $(x,y)$ cartesian coordinates or $(d,\theta)$ polar coordinates must be specified as part of the documentation.
Now suppose we fix it as cartesian coordinates, can the properties of Point be only defined with two double variables?  That's what the question is asking.

I think a coordinate can be represent by using the pair data structure. Pair<double, double> point.

Woah.. you predicted our first recitation question!  But other than Point<Double,Double>, how can we represent with whatever we have come across in the first lecture?

ImList can also be used to represent a point as it can store more than 1 value.


Build Hotel Page

Describe the feature
Hotel Page

Add a hotel listing page with top hotels.
Display hotels in a tile style with gradient design matching the website theme.
Sort hotels by:

Location (city)
Price
Rating
Other filters as needed

Include clickable links for each hotel to navigate to the location on Google Maps.
Make necessary design and layout changes for smooth integration.
Open to suggestions for more features and improvements.
Happy to contribute! @PriyaGhosal please assign me the task

Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@PriyaGhosal please assign me the task


Update all links to the specification to point at the 1.21.0 release

Now that the specification is released, we can point at stable files and update on-release.

Update specification-link-script to point at 1.21.0
Update all specification links to 1.21.0
Add link to "current specification version" for this repository in the README.  This is a temporary solution before we can get better automation/tracking of specification links.

Previously, this was impossible as some files had moved around in the 1.21.0 release.

@tigrannajaryan Good question.
I think updating to the latest OTEL specification MAY involve changes to this set of documents, depending on how the specification changed.  I'm not sure it's always a "routine" thing.  I am happy to add it over there though, as a step that we try to make routine and only bail if it needs work. WDYT?

@tigrannajaryan Good question.
I think updating to the latest OTEL specification MAY involve changes to this set of documents, depending on how the specification changed. I'm not sure it's always a "routine" thing. I am happy to add it over there though, as a step that we try to make routine and only bail if it needs work. WDYT?

Yeah, I hope it is mostly going to be a routine update, but even if it is not it will be visible in the form of a PR in this repo which can be debated if needed.


Add initial vale configuration and apply editorial changes to documentation

Fixes

Fixes #3566 by @dhruvkb
Description

I've picked this work up from @ngken0995 so that Ken can focus on other PRs.
When we originally started looking into Vale, we were misinformed about how it worked. We thought that you had to commit the styles files to the repository. However, that's not the intended way of using Vale. Instead, the Vale documentation instructs you to git-ignore all "synced" configuration files, and only commit custom configuration files. This allows us to avoid introducing big long lists of offensive terms into the monorepo. Those files would still appear if you ran vale sync from within the new .vale directory. But that is not necessary to do, not even when developing the Vale configuration, because everything can run from within the built docker image. For normal usage, we'll rely on a published docker image that includes the latest Openverse Vale configuration. You can see this staged in the pre-commit configuration as a new hook that I've left commented out. You can try this hook out locally by building the openverse-vale using just .vale/build. You can also run it (which automatically builds each time, because the build is short enough to allow for this and it helps iteration go faster): just .vale/run documentation/api. That will run the Openverse Vale configuration against the documentation/api directory.
The configuration only applies to Markdown files, with a comment in the Vale configuration explaining why this is the case.
The pre-commit hook also excludes project proposals and changelogs. Changelogs are automatically generated, and as such, I don't think they should be linted for editorial content. For example, if a PR title doesn't pass Vale, I don't think it's accurate to change the title in the changelog. That's my personal judgement, but if other folks want to run Vale there, I would also think that's fine and wouldn't push against it.
The project proposals, on the other hand, are complex. They raise a lot of errors in Vale and are the bulk of our documentation, line-by-line. They are also not "living" documents, that we make changes to over time. Once they're in, they're more or less meant to stay as-is, with changes to the project reflected in the project threads (that's my understanding). Going back and making retroactive editorial changes to those files doesn't feel right to me. On the other hand, if folks do want to do that, then I also wouldn't push back here, I'd just ask that it gets done in a separate PR.
This configuration is just a starting point, and we can incorporate additional rules in the future, if we like, even from other style guides. Red Hat's guide in particular has a lot of compelling options, including scentence complexity checks and a much better passive voice check than the other ones I've seen.
After we merge this PR and publish the first openverse-vale image, we'll need a fast-follow PR to uncomment the pre-commit hook so that we start linting things in CI :tada:.
Testing Instructions

Run just .vale/run documentation/api, as well as against other directories in the documentation that should be linted by Vale. Make changes that will cause issues with Vale and confirm they raise errors as you expect. Confirm no unnecessary errors are present.
Read over the Vale configuration and through the Vale documentation to confirm that it all makes sense and is appropriate for our project.
Checklist

[x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[N/A] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.
[x] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

An alternative to using a published image is to run the vale linting step using just .vale/ci that builds the image and then runs it with the configuration we need. That would make it easier to test the CI configuration locally too, without needing to duplicate the CLI args between pre-commit and the justfile.

Okay, I've updated the PR with the following:

Check Markdown files outside of documentation. As part of this I cleaned up the glob configuration in .vale/justfile to make it slightly easier to read and maintain (though not by much, due to limitations in the glob syntax and just/scripting while avoiding too much complexity)
Check MDX files as Markdown
Check admonitions
Fix a lot of false positives by updating Openverse.TermCasing to ignore path-like phrases

@obulat @dhruvkb I think this PR needs a review from one of y'all to be able to get merged? I can't understand why else the existing 2 approvals wouldn't be sufficient.


Key file format

Rather than expecting a custom format
AccessKeyId=XXXX
SecretKey=XXXX

the tool could parse the format of ~/.aws/credentials
[profile_name]
aws_access_key_id =  xxx
aws_secret_access_key = xxx

Thanks for the suggestion, @noraj. I've created a pull request that implements your suggestion.
I believe the custom format was used initially because supported credentials are not limited to AWS API keys only but also include Google Cloud Storage API keys.
Now both formats will be accepted so it's easier to import the keys in their default format.

@0xSobky You're right I forgot Azure and GCP. Supporting both was the way to go.


Make search_node url optional input to parse_instance_ids

#20

Wait how did this get merged....ughhhh, this is a mess.


any support in PageServerLoad?

I was trying to redirect to home when user is already logged in

You cannot use request as an argument to redirect, it must be the whole event.
This may be unrelated, but usually you import PageServerLoad from ./$types, not the parent as you illustrate.

I think I will try something out first


float radius = (renderCamera.GetAltitude() * Eegeo::Math::Tan(renderCamera.GetFOV()));

float radius = (renderCamera.GetAltitude() * Eegeo::Math::Tan(renderCamera.GetFOV()));
Oc has a corresponding API?

Hi @dululu522 - it looks like you've taken this code from https://github.com/eegeo/eegeo-example-app/blob/master/src/Search/SdkModel/SearchQueryPerformer.cpp#L21
Are you trying to find a suitable radius to use for a search service? If this is the case, you could consider using a hard wired value for now.

Write a hard the value of the search result is bad, there is no corresponding oc version of the API likeeegeo-example-app?

Hi - could you explain what you are trying to achieve please?
Are you trying to display search results on an eeGeo map using the Objective-C ios-api?

Hi-
I want to like float radius = (renderCamera GetAltitude () * Eegeo: : Math: : Tan (renderCamera. GetFOV ()));This method based on the current to determine the search radius of the lens？


vertical form has margin-bottom 9px on inputs, causes help block to be pushed down more than on horizontal

Default vertical forms need the following css as well, otherwise the help block is moved down too much
.form-search input, .form-inline input, .form-horizontal input, .form-search textarea, .form-inline textarea, .form-horizontal textarea, .form-search select, .form-inline select, .form-horizontal select, .form-search .help-inline, .form-inline .help-inline, .form-horizontal .help-inline, .form-search .uneditable-input, .form-inline .uneditable-input, .form-horizontal .uneditable-input {
    display: inline-block;
    margin-bottom: 0;
}

Screenshot

Take a look at the latest updates to the 2.0.2-wip branch.  Some work was done to address this in another ticket and it may have included the change necessary to accomplish what you're looking for.  If so, you can probably close this ticket.  Otherwise, it might need to be updated as the above css might no longer be applicable.


Capability rename for reaction feature

Purpose

Rename for the capability API for reaction feature.

Does this introduce a breaking change?

[x] Yes
[ ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

LGTM


Make first release in Github.

I guess this will be done when it's done, no need to have a GitHub issue for it.


Update VEP

Updated to v83.
Failed on test in instalaltion but processing test outside shell scripts generates no errors. Support from ensembl claims installation is ok.
Validated and PASSED v 83


The node exporter should be listening <IP_ADDRESS> instead of pod ip

Fix the issue that node exporter crash when deploying
into the node without internal ip.
Related issue:
https://github.com/rancher/rancher/issues/19665

LGTM


DOC: current doc about MLX-LM is wrong

URL
https://python.langchain.com/docs/integrations/chat/mlx/
Checklist

[X] I added a very descriptive title to this issue.
[X] I included a link to the documentation page I am referring to (if applicable).

Issue with current documentation:
Ran all cells in the notebook and the very last one got me an error:
TemplateError: System role not supported
Idea or request for content:
Provide a working example.

Hello, are you working on this? If not, I am happy to take this task!

Try to fix this in https://github.com/langchain-ai/langchain/pull/28884


Segmentation fault

Prerequisites

[ ] Put an X between the brackets on this line if you have done all of the following:

Checked that your issue isn't already filed.

Specifically, check out the wishlist, open RFCs,
or feature requests.

Reduced the issue to a self-contained, reproducible test case.

I'm not sure how to reduce the source to a minimal example. The problematic code depends on a lot of other code in my repository. If there are any suggestions, I'm happy to try. In the meantime, I'll give instructions on how to reproduce the problem using my repository.
Description
The theorem acie.aeq.subst_comp.fresh_not_mem in my repository causes a segmentation fault. (In other words, you can comment out all of the other code in that file, and Lean will segfault.)
Steps to Reproduce

git clone https://github.com/spl/alpha-conversion-is-easy.git acie
cd acie
git checkout 0289f84656af61aea5ebb9c0f0f47749a102b35e
lean src/aeq/properties.lean

Expected behavior:
Compile with errors.
Actual behavior:
Segmentation fault: 11
Reproduces how often:
Always
Versions
$ uname -rs  # macOS Sierra 10.12.5
Darwin 16.6.0
$ lean --version
Lean (version 3.3.1, commit 426a9064bfbc, Release)

This issue is holding me back, so I thought I'd take a look at it. Any help would be appreciated.
I built lean with -DCMAKE_BUILD_TYPE=DEBUG. This is what I saw:
$ ./lean/bin/lean src/aeq/properties.lean
LEAN ASSERTION VIOLATION
File: /Users/leather/projects/alpha-easy/lean/src/library/type_context.cpp
Line: 1303
idx < m_tmp_data->m_eassignment.size()
(C)ontinue, (A)bort/exit, (S)top/trap, Invoke (G)DB
/Users/leather/projects/alpha-easy/src/aeq/properties.lean:67:0: error: type mismatch at application
  (λ {X : vs V} (e : exp X), Π {Y : vs V}, exp.subst X Y → exp Y) (exp.rec e_1 e_2 e_3)
term
  exp.rec e_1 e_2 e_3
has type
  Π (n : exp a), (λ {X : vs V} (e : exp X), Π {Y : vs V}, exp.subst X Y → exp Y) n
but is expected to have type
  exp a
C
LEAN ASSERTION VIOLATION
File: /Users/leather/projects/alpha-easy/lean/src/util/buffer.h
Line: 96
idx < size()
C

This repeats ad infinitum. I'm not yet sure what it means, but I'll study it more.
As an aside, on macOS when built with clang, should lldb be invoked instead of gdb?
G
INVOKING GDB...
sh: gdb: command not found
ERROR STARTING GDB...

I seem to be able to work around this issue by using rw instead of simp. See
https://github.com/spl/alpha-conversion-is-easy/commit/1e6ffc641c1223ff3286868ca2764ad36752a5c2:
-      simp [dif_neg (vname.ne_if_mem_and_not_mem (vname.map_of_subset _ x) (fresh X))]
+      rw [dif_neg (vname.ne_if_mem_and_not_mem (vname.map_of_subset _ x) (fresh X))],

I haven't investigated this issue in detail, but it might be related to #1863. See if providing all implicits fixes the issue.

Indeed, it looks like filling the underscore works:
      simp [vname.ne_if_mem_and_not_mem (vname.map_of_subset (vset.prop_subset_refl _) x) (fresh X)],

works for me. Closing as dupe of #1863

Thanks, @digama0.


Adding Node Address Creation Transaction

Problem
Need Node Address Creation Transaction to test solo with network upgrade
Solution
Implement Node Address Creation Transaction
Alternatives
No response

hey @JeffreyDallas ! This is a duplicate of https://github.com/hashgraph/hedera-sdk-js/issues/2335. Closing as duplicate.


Add support for Sound System

Should update also rx-openwebnet

Version 2.10.0 and 2.11.0 add this feature


732 notif collab resolve

The prior PR for this branch left out the case of a collaboration request being denied, where the request notif should be resolved. That is addressed here. The code changes fall into three categories:

Adding a new notification type called NotificationType.collab_denied, including email templates. However, it is configured in Notification.NOTIFICATION_DEFAULTS to send notifications neither by rest api nor email, meaning this notif is by default never sent to a user. We've decided in discussions not to send notifications on a collab denial, but it is convenient to have this as a proper notification type because then the request is_resolved logic is consistent across all events. Additionally, we or admin users may choose to send these notifs in the future by changing these config fields.

Adding a test for denying a collaboration request, which was not previously covered. This new test in tests/modules/collaborations/resources/test_collaboration_patch.py also checks for proper notification resolution.

Many of the diffs here are from renaming instances of collab.DECLINED to collab.DENIED. We were inconsistent in the usage of those two terms; I have standardized on DENIED since that is the usual counterpart to 'approved'.

\rebase

/rebase


Installing to a custom directory doesnt work on linux

I am following the installation instructions here https://console.bluemix.net/docs/cli/reference/ibmcloud/download_cli.html#other-links-to-further-explore-ibm-cloud-cli
These are the commands I am using
wget -O IBM_Cloud_CLI_0.9.0_linux_amd64.tgz https://public.dhe.ibm.com/cloud/bluemix/cli/bluemix-cli/0.9.0/binaries/IBM_Cloud_CLI_0.9.0_linux_amd64.tgz
tar -xvzf IBM_Cloud_CLI_0.9.0_linux_amd64.tgz
export PATH=$PATH:/my/current/directory/IBM_Cloud_CLI

Any suggestions ??

found the issue, had to do chmod +x IBM_Cloud_CLI/ibmcloud


RFC: What do you think about TRAX?

We're thinking how to make the next T2T much better. One thing that came up is using JAX and gin config and we've prototyped TRAX:
https://github.com/tensorflow/tensor2tensor/blob/master/tensor2tensor/trax
If you're interested, please take a look. Run one of the examples, try to change something, train on your data, make your own model, tweak things. If you had trouble doing things in T2T before, let us know if that looks like it'd help!
TRAX is very early and it lacks features and has bug - we know that and we'll be correcting the small things as we go. But we'd love to think about higher-level things that may be easier to address at this stage, before the design stabilizes. Especially if you had trouble doing things in T2T before, let us know if that looks like it'd help!

Hello Lukasz,
Current problem #1 - TF1.0
I simply do not like the graph API of TF1, and I think any move away from it is a good thing, so TF2.0-T2T and JAX-T2T should both do the trick. As T2T is pretty complex and a lot of questions need to be answered by going through the code, the hard-to-follow graph execution did not really help.
Current problem #2 - Estimators
Being able to just load and use a T2T model within an application, without using a complex tf-serving approach, was also really hard to do. The Estimator-Interface is the main problem here, as it is reloading the whole model for each predict call. I really hope TF2.0-T2T and JAX-T2T will allow to work around Estimators more seamlessly.
TRAX - What I like
Well, the whole code looks really clean and easy to follow. In theory, it should solve all my issues with T2T
TRAX - What I dislike
I do not like the idea of using yet another framework for T2T. While JAX seems cool and gains traction, wouldn't it be a better idea to base the rewrite on TF2.0?
I understand that a seamless transition from current T2T to a TF2.0 backed version is not possible. So rewriting big parts of the framework might be needed, perhaps even a start from scratch.
But then, if you plan to rewrite a lot of the code anyway (for the TRAX version), why not bundle the resources, start from scratch and use an eager TF2.0 approach?
I think in the long term T2T will not benefit from multiple branches that need to be maintained separately. Especially if one of them is still heavily relying on TF1.0 and graph mode, and the other is relying on a quite small framework like JAX.
Thoughts?

I've used Autograd in the past for some research, and found it to be really inefficient and ended up walking away from it to use pytorch, which had huge speed ups.
As a more concrete example, at one point I encountered the backwards pass of autograd consuming 20gb of memory, which ended up being fixed with PR.
I mention the above to add support to @f-lng's comment, that adding another framework for t2t would make maintaining t2t harder, since bugs would inevitably arise that stem from the underlying framework.
OTOH, I think it's important to note that T2T's mission in part is to make deep learning more accessible. I'm not familiar enough with TF2.0 to understand if migrating to it would help this goal. What are your thoughts on that @lukaszkaiser / @f-lng?

@etragas-fathom I do think that TF2.0 would serve the mission of making it more accessible, because model execution / codeflow is simplified with the eager programming style and model creation is simplified with the keras API.
I might be biased here, as I only touch TF if I can not get around it (e.g. for T2T), and always found Keras to be a pretty good alternative, especially if you are doing engineering, not research.
I think a proper TF2.0 based T2T would be perfect, but if TRAX is the way to go, it might be a better approach to simply drop the TF backend alltogether and focus on the TRAX version.

The problem with TF 2.0 at least for now is that when you want speed (use @tf.function or functional Keras mode) you're back in TF 1.0 graph-mode land. With shape bugs, large stack traces and all, and it feels as hard to debug as TF 1.0 or harder.
With JAX the speed problem of autograd is gone (I'm just training a Transformer LM as fast as T2T and a Resnet just a little slower). But other bugs may re-surface with more use, we'll need to see, I guess.
Please keep adding comments so we know what to look out for!

Well, if you guys say TF 2.0 is not a good fit for T2T (yet?), then I guess TRAX is a good alternative, as the code looks very clean and the rewrite is easy to follow :-)
Btw, is there already a beam search decoding implemented and documented? I would love to give it a try.

Perhaps not a hugely insightful comment, it's a shame that this makes installing recent versions of t2t non-trivial under Windows (see https://github.com/tensorflow/tensor2tensor/issues/1507).

I would like TRAX to be independent a repo/package. I don't want to install tensorflow if possible, but T2T depends on it.

As on 6c7c601b8c4429dcc81ab3ec828daddea5ff2b67 it seems like TRAX has been moved to it's own repo, but although it's not clear to which one though.

https://github.com/google/trax
On Mon, Oct 28, 2019, 7:51 AM Alexander<EMAIL_ADDRESS>wrote:

As on 6c7c601
https://github.com/tensorflow/tensor2tensor/commit/6c7c601b8c4429dcc81ab3ec828daddea5ff2b67
it seems like TRAX has been moved to it's own repo, but although it's not
clear to which one though.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/tensor2tensor/issues/1478?email_source=notifications&email_token=AAIUEFSJPBZUFXW3WCH33A3QQ34ARA5CNFSM4G4IZMA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECNEX4Y#issuecomment-546982899,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIUEFSKAIECAUVAWPOHQXTQQ34ARANCNFSM4G4IZMAQ
.

@afrozenator @lukaszkaiser
Could you tell me the advantage of JAX over PyTorch? Does JAX provide any tool with which Transformer and Reformer becomes faster for the reason other than the fact that JAX probably has better support of TPU?

@lukaszkaiser
I am not sure wheater or not I should post it here. I feel what you said is totally correct. To me, Keras and TF are really complicated and mess in their Graph API.
I hold Trax will be as readable as Pytorch on building a more complicated model.
Here is an example of Pytorch on Unet, which is readable and beautiful.
https://gist.github.com/Hsankesara/e3b064ff47d538052e059084b8d4df9f#file-unet-py
`
import torch
from torch import nn
import torch.nn.functional as F
import torch.optim as optim
class UNet(nn.Module):
def contracting_block(self, in_channels, out_channels, kernel_size=3):
block = torch.nn.Sequential(
torch.nn.Conv2d(kernel_size=kernel_size, in_channels=in_channels, out_channels=out_channels),
torch.nn.ReLU(),
torch.nn.BatchNorm2d(out_channels),
torch.nn.Conv2d(kernel_size=kernel_size, in_channels=out_channels, out_channels=out_channels),
torch.nn.ReLU(),
torch.nn.BatchNorm2d(out_channels),
)
return block
def expansive_block(self, in_channels, mid_channel, out_channels, kernel_size=3):
        block = torch.nn.Sequential(
                torch.nn.Conv2d(kernel_size=kernel_size, in_channels=in_channels, out_channels=mid_channel),
                torch.nn.ReLU(),
                torch.nn.BatchNorm2d(mid_channel),
                torch.nn.Conv2d(kernel_size=kernel_size, in_channels=mid_channel, out_channels=mid_channel),
                torch.nn.ReLU(),
                torch.nn.BatchNorm2d(mid_channel),
                torch.nn.ConvTranspose2d(in_channels=mid_channel, out_channels=out_channels, kernel_size=3, stride=2, padding=1, output_padding=1)
                )
        return  block

def final_block(self, in_channels, mid_channel, out_channels, kernel_size=3):
        block = torch.nn.Sequential(
                torch.nn.Conv2d(kernel_size=kernel_size, in_channels=in_channels, out_channels=mid_channel),
                torch.nn.ReLU(),
                torch.nn.BatchNorm2d(mid_channel),
                torch.nn.Conv2d(kernel_size=kernel_size, in_channels=mid_channel, out_channels=mid_channel),
                torch.nn.ReLU(),
                torch.nn.BatchNorm2d(mid_channel),
                torch.nn.Conv2d(kernel_size=kernel_size, in_channels=mid_channel, out_channels=out_channels, padding=1),
                torch.nn.ReLU(),
                torch.nn.BatchNorm2d(out_channels),
                )
        return  block

def __init__(self, in_channel, out_channel):
    super(UNet, self).__init__()
    #Encode
    self.conv_encode1 = self.contracting_block(in_channels=in_channel, out_channels=64)
    self.conv_maxpool1 = torch.nn.MaxPool2d(kernel_size=2)
    self.conv_encode2 = self.contracting_block(64, 128)
    self.conv_maxpool2 = torch.nn.MaxPool2d(kernel_size=2)
    self.conv_encode3 = self.contracting_block(128, 256)
    self.conv_maxpool3 = torch.nn.MaxPool2d(kernel_size=2)
    # Bottleneck
    self.bottleneck = torch.nn.Sequential(
                        torch.nn.Conv2d(kernel_size=3, in_channels=256, out_channels=512),
                        torch.nn.ReLU(),
                        torch.nn.BatchNorm2d(512),
                        torch.nn.Conv2d(kernel_size=3, in_channels=512, out_channels=512),
                        torch.nn.ReLU(),
                        torch.nn.BatchNorm2d(512),
                        torch.nn.ConvTranspose2d(in_channels=512, out_channels=256, kernel_size=3, stride=2, padding=1, output_padding=1)
                        )
    # Decode
    self.conv_decode3 = self.expansive_block(512, 256, 128)
    self.conv_decode2 = self.expansive_block(256, 128, 64)
    self.final_layer = self.final_block(128, 64, out_channel)

def crop_and_concat(self, upsampled, bypass, crop=False):
    if crop:
        c = (bypass.size()[2] - upsampled.size()[2]) // 2
        bypass = F.pad(bypass, (-c, -c, -c, -c))
    return torch.cat((upsampled, bypass), 1)

def forward(self, x):
    # Encode
    encode_block1 = self.conv_encode1(x)
    encode_pool1 = self.conv_maxpool1(encode_block1)
    encode_block2 = self.conv_encode2(encode_pool1)
    encode_pool2 = self.conv_maxpool2(encode_block2)
    encode_block3 = self.conv_encode3(encode_pool2)
    encode_pool3 = self.conv_maxpool3(encode_block3)
    # Bottleneck
    bottleneck1 = self.bottleneck(encode_pool3)
    # Decode
    decode_block3 = self.crop_and_concat(bottleneck1, encode_block3, crop=True)
    cat_layer2 = self.conv_decode3(decode_block3)
    decode_block2 = self.crop_and_concat(cat_layer2, encode_block2, crop=True)
    cat_layer1 = self.conv_decode2(decode_block2)
    decode_block1 = self.crop_and_concat(cat_layer1, encode_block1, crop=True)
    final_layer = self.final_layer(decode_block1)
    return  final_layer`

@lukaszkaiser Trax takes extremely long time to be imported, which makes it very uncomfortable to debug.