Error: Sorry,  you must provide a valid 'client_id' for open source version

Hi,
i am using your example with the opensource version of inbox, and it gives me this error.
{"reason"=>"Sorry,
 you must provide a valid `client_id`. The `client_id` request parameter should be the App ID of your application in the Inbox Developer Portal.",
 "error"=>"access_denied"}

i am connecting to the server with the following code.
def login
		inbox = Inbox::API.new(nil, nil, nil, 'http://localhost:5555/')
	  user_email =<EMAIL_ADDRESS>	  callback_url = url_for(:action => 'login_callback')
	  redirect_to inbox.url_for_authentication(callback_url, user_email)
	end

the rails console is showing, that the app still tries to connect to inboxapp.com
Processing by MailsController#login as HTML
Redirected to https://www.inboxapp.com/oauth/authorize?client_id=&trial=false&response_type=code&scope=email&login_hint=john@test.com&redirect_uri=http://lvh.me:3000/mails/login_callback

why would it redirect to inboxapp.com? why isn't it using my local opensource version?

Hi Silab,
The rails example uses our hosted API. Here's what your controller should be doing when using the opensource API:
def logged_in
      inbox = Inbox::API.new(nil, nil, nil, 'http://localhost:5555/')
      # There's no need to authentify the user --- there's no access control in the opensource version.
      @first_message = inbox.namespaces.first.messages.first.snippet
end

If you want to add an user inbox, you'll have to do it from the command line. Login to your vagrant box, and run bin/inbox-auth<EMAIL_ADDRESS>from the /vagrant directory.
Karim

Hi,
thx for the reply. so how can access the inboxes of different users? say i have authenticated many users, now i want to show every user his emails. how would i do this this the open source version? if you could provide me with a short code snippet would be awesome.
regards
--
Silab Kamawall
<EMAIL_ADDRESS>
Am 28.01.2015 um 15:49 schrieb Karim Hamidou<EMAIL_ADDRESS>Hi Silab,
The rails example uses our hosted API. Here's what your controller should be doing when using the opensource API:
def logged_in
inbox = Inbox::API.new(nil, nil, nil, 'http://localhost:5555/')
# There's no need to authentify the user --- there's no access control in the opensource version.
@first_message = inbox.namespaces.first.messages.first.snippet
end
If you want to add an user inbox, you'll have to do it from the command line. Login to your vagrant box, and run bin/inbox-auth<EMAIL_ADDRESS>from the /vagrant directory.
Karim
—
Reply to this email directly or view it on GitHub https://github.com/inboxapp/inbox-ruby/issues/8#issuecomment-71846132.

It's super easy with the namespaces collection:
inbox.namespaces.each do | namespace |
    puts namespace['email_address']
end

See the README for more examples.


WACK App Prelaunch Test fails in 1.1.8

Any app built in Release with T10 with .NET Native fails the Windows App Certification Kit (WACK) App Prelaunch Test. Used to work in 1.1.4, I made a direct jump to 1.1.8, so can't comment on other versions.

I have mentioned this in #725 , that the Prelaunch issue was present in all versions above 1.1.4.

I am still using v1.1.4 and Prelaunch works just fine.

That's the point. It works in 1.1.4. I can confirm that. Also with versions higher than 1.1.4, I'm facing more crashes. Possibly due to the Rx inclusions as mentioned in #725.

@kenshinthebattosai it does not fail. Today I published beta version of app, no WACK errors, latest T10 version from nuget. I can notice a major performance degradation when app is compiled in release mode with .NET Native ARM. But I doesn't sure it's because of T10, it seems like a platform issue, looks like exceptionally poor quality of ARM native generated code. Same app deployed as debug .NET managed IL assembly perform much better. But it's another issue.
So, in fact WACK does not fail with T10 (i tested it today and successfully sent app package to the store). Maybe, it's because I do not use splash screen on startup.

@Opiumtm  I've just run WACK on my latest build with T10 1.1.5 from nugget (also removed splash just to check) and still fails. It is possible that the issue is fixed in version 1.1.7 or 1.1.8 but unfortunately I can't use that because #725 , however, doesn't seem like...

@barptad So, title

WACK App Prelaunch Test fails in 1.1.8

is wrong. In 1.1.8 version (current version on nuget) WACK does not fail.
I tested it with current version - it successfully pass WACK tests.

And I just tested it today and I do get the WACK Prelaunch Test fails with 1.1.8.

I've done some more investigation looking into the crash dump. Does the following mean anyting to anyone?
0:005> !mrt100sos.pe -ccw 0x000001dcffb11c60
Exception object: 000001dcdf421f80
Exception type:   System.ArgumentException
Message:          Argument_AddingDuplicate. For more information, visit http://go.microsoft.com/fwlink/?LinkId=623485
InnerException:
StackTrace (generated):
IP               Function
00007ffeeec3030e MyApp_7ffeee340000!$62_System::Collections::Generic::Dictionary$2<$0_MyApp::Models::Pages,System::__Canon>.Insert+0x29e
00007ffeeec30570 MyApp_7ffeee340000!$62_System::Collections::Generic::Dictionary$2<$0_MyApp::Models::Pages,System::__Canon>.Add+0x10
00007ffeeee6f639 MyApp_7ffeee340000!$0_MyApp::App.InitializeNavigation+0x29
00007ffeeee6f844 MyApp_7ffeee340000!$0_MyApp::App.OnInitializeAsync+0x64
00007ffeeee31289 MyApp_7ffeee340000!$61_Template10::Common::BootStrapper::d__77.MoveNext+0x119
0000000000000001
00007fff0ad35fc1 SharedLibrary!System::Runtime::ExceptionServices::ExceptionDispatchInfo.Throw+0x21
00007fff0ad36238 SharedLibrary!$13_System::Runtime::CompilerServices::TaskAwaiter.ThrowForNonSuccess+0x58
00007fff0ad361d3 SharedLibrary!$13_System::Runtime::CompilerServices::TaskAwaiter.HandleNonSuccessAndDebuggerNotification+0x43
00007fff0ad36187 SharedLibrary!$13_System::Runtime::CompilerServices::TaskAwaiter.ValidateEnd+0x17
00007fff0ae7d81b SharedLibrary!$13_System::Runtime::CompilerServices::ConfiguredTaskAwaitable::ConfiguredTaskAwaiter.GetResult+0xb
00007ffeeee31f92 MyApp_7ffeee340000!$61_Template10::Common::BootStrapper::d__53.MoveNext+0x172
`

After spending the better part of a day debugging this issue, I think I finally tracked Down the bug and I've created PR #782 which seems to fix it.

Resolved.

Super. Thanks


Downgrade the goleak version to one that is compatible with the go version

The Golang version, along with some dependencies, has been upgraded here. However, in a later commit, the Golang version was downgraded again to 1.18 without the dependencies.
Currently, the CI will fail when running tests due to this error
# go.uber.org/goleak/internal/stack
../../../.asdf/installs/golang/1.18/packages/pkg/mod/go.uber.org/goleak@v1.3.0/internal/stack/stacks.go:123:26: undefined: errors.Join
../../../.asdf/installs/golang/1.18/packages/pkg/mod/go.uber.org/goleak@v1.3.0/internal/stack/stacks.go:256:26: undefined: strings.CutPrefix
note: module requires Go 1.20

@samber

Ok, thanks for your help. I was struggling with that issue earlier today.


Update snakeyaml to 1.30

Updates org.yaml:snakeyaml from 1.28 to 1.30.
Release Notes - Release Notes - Release Notes - Release Notes - Release Notes - Release Notes - Release Notes - Release Notes - Release Notes - Release Notes - Release Notes - Release Notes - Changelog - Changelog - Changelog - Changelog - Changelog - Changelog - Changelog - Changelog - Changelog - Changelog - Changelog - Changelog
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.yaml", artifactId = "snakeyaml" } ]

labels: library-update, commit-count:1

Codecov Report

Merging #265 (0148199) into master (1ffa7cc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   96.19%   96.19%
=======================================
  Files           4        4
  Lines         105      105
  Branches        4        6    +2
=======================================
  Hits          101      101
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ffa7cc...0148199. Read the comment docs.

Superseded by #315.


HIVE-27829 : New command "Show Processlist" to display current operations and related details in Hiveserver2

What changes were proposed in this pull request?
This PR introduces a new command "Show Processlist" which displays the operations running on Hiveserver2 and provides session and operation details. This is similar to the MYSQL SHOW PROCESSLIST implementation.
Why are the changes needed?
This command will help troubleshoot issues with the Hiveserver2, especially stuck queries. We can understand the load on a given HS2 instance and identify inappropriate connections to terminate them.
Does this PR introduce any user-facing change?
Yes, attaching sample output for the command

0: jdbc:hive2://localhost:10000> show processlist;
+------------+------------+-------------------+---------------------------------------+--------------------------+------------------------+----------------------------------------------------+-----------+-------------------+-------------------+---------------+-----------------+
| User Name  |  Ip Addr   | Execution Engine  |              Session Id               | Session Active Time (s)  | Session Idle Time (s)  |                      Query ID                      |   State   | Opened Timestamp  | Elapsed Time (s)  |  Runtime (s)  |      Query      |
+------------+------------+-------------------+---------------------------------------+--------------------------+------------------------+----------------------------------------------------+-----------+-------------------+-------------------+---------------+-----------------+
| hive       | <IP_ADDRESS>  | mr                | 6cdf027f-90e1-48af-b4d8-a11aac71ca1b  | 154                      | 19                     | rtrivedi_20240624193743_fb4b2bf8-a02a-4b76-a92c-4e3ee4bb6e9e | FINISHED  |<PHONE_NUMBER>493     | 102               | 83            | show tables     |
| hive       | <IP_ADDRESS>  | mr                | 43945f54-d65c-424d-b523-08e7675d8223  | 165                      | 67                     | rtrivedi_20240624193826_42bff3ed-fb8d-4478-9500-fc6ff2173041 | RUNNING   |<PHONE_NUMBER>721     | 59                | Not finished  | show databases  |
+------------+------------+-------------------+---------------------------------------+--------------------------+------------------------+----------------------------------------------------+-----------+-------------------+-------------------+---------------+-----------------+
2 rows selected (4.149 seconds)

Is the change a dependency upgrade?
No
How was this patch tested?
Manually tested
Added Test class -  mvn test -Dtest=TestHiveCommandOpForProcessList

Is this an administrator level command? Should the common user see this information?
I am afraid this would lead to permission/authorization issues.

@zhangbutao Is your concern that we are showing "query string" ? or even the query id as well? I share your concern on the query string. Any query cancellations are authorized but we should also confirm that unauthorized users arent able to kill other user's queries. Other than that, I do not see an issue from showing the query IDs. Do you

@zhangbutao Is your concern that we are showing "query string" ? or even the query id as well? I share your concern on the query string. Any query cancellations are authorized but we should also confirm that unauthorized users arent able to kill other user's queries. Other than that, I do not see an issue from showing the query IDs. Do you

@nrg4878 Yes, the main concern is "query string" and "query id". If we currently already have ways to prevent unauthorized users from killing or seeing the "query string" and "query id". I think the new command is also cool. :)

@nrg4878 @zhangbutao We authorize kill query operation with SERVICE_NAME object. In case authorization is disabled, Hiveserver2 process owner should have kill privileges. So, I believe it is safe to display "query Id" . I agree we should avoid query display in this command.

Sample output after remove query String-

0: jdbc:hive2://localhost:10000> show processlist;
+------------+------------+-------------------+---------------------------------------+--------------------------+------------------------+----------------------------------------------------+----------+-------------------+-------------------+---------------+
| User Name  |  Ip Addr   | Execution Engine  |              Session Id               | Session Active Time (s)  | Session Idle Time (s)  |                      Query ID                      |  State   | Opened Timestamp  | Elapsed Time (s)  |  Runtime (s)  |
+------------+------------+-------------------+---------------------------------------+--------------------------+------------------------+----------------------------------------------------+----------+-------------------+-------------------+---------------+
| hive       | <IP_ADDRESS>  | mr                | 66df357a-90bf-43cb-847f-279aa6df1c24  | 113                      | 7                      | rtrivedi_20240709124106_d0f00d7a-6fab-4fcd-9f41-d53bb296275d | RUNNING  |<PHONE_NUMBER>774     | 16                | Not finished  |
| hive       | <IP_ADDRESS>  | mr                | 7daa873e-bb46-462e-bc38-94cb8d3e7c17  | 83                       | 29                     | rtrivedi_20240709124106_2dc53c4c-e522-4aed-a969-3d48ac01ba81 | RUNNING  |<PHONE_NUMBER>774     | 17                | Not finished  |
+------------+------------+-------------------+---------------------------------------+--------------------------+------------------------+----------------------------------------------------+----------+-------------------+-------------------+---------------+

@dengzhhu653 @saihemanth-cloudera Could you please review?

Thanks @saihemanth-cloudera and @deniskuzZ for the review. Sorry, I missed these earlier.

@rtrivedi12, please check sonar report


Fix race in log

A race has been detected in #1441 relating to getting log levels.
This PR protects the GetLevel and GetStacktraceLevel calls with a mutex.
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

To resolve the data race, the lock has to still be added into write loglevel in internalResetLevel.

The data race problem is one goroutine read MultiChannelledLog.level but another write MultiChannelledLog.level. So I think you should add lock on https://github.com/go-gitea/gitea/blob/a7fe58b84574dffdb2a0bcdbce32d661225bbc8d/modules/log/event.go#L375

It's already locked.
https://github.com/go-gitea/gitea/blob/a7fe58b84574dffdb2a0bcdbce32d661225bbc8d/modules/log/event.go#L197-L210
https://github.com/go-gitea/gitea/blob/a7fe58b84574dffdb2a0bcdbce32d661225bbc8d/modules/log/event.go#L390-L394

OK simple testing suggests that a RWMutex would be faster in the case of a lot of calls to GetLevel.

Looks like this might be exposing another race in the test.

Hmm... I think there might be no non-racey way to assert the batch_length so I'm going to remove that.

make lgtm work


Use calendar widget to pick date when creating events

From @pafcu on July 11, 2014 12:5
It would simplify the UI somewhat if the user could pick the date of an event using some sort of calendar widget instead of simply filling in the date using the boxes now presented. See e.g. http://jqueryui.com/datepicker/
This would get rid of several fields in the UI, and make the description of the date format unnecessary.
Copied from original issue: friendica/red#532

From @friendica on September 5, 2014 5:42
fixed in commit 92e4448993ed22e

From @pafcu on October 16, 2014 14:15
Clicking on the calendar button next to the date field brings up a "popup" with the same field. Pressing on the calendar button next to this field does open up the calendar widget. Is there a reason for opening the popup instead of just directly showing the calendar widget the first time you click?

From @friendica on October 16, 2014 19:20
There is no reason. I was not familiar with the details of the bootstrap datetime picker and was hoping somebody would work through that bit and make it a single click. I was just trying to get rid of the hacky select boxes.


repository 'https://github.com/LizardByte/homebrew-homebrew/' not found

Describe the Bug
@**** ****** % brew tap LizardByte/homebrew
==> Tapping lizardbyte/homebrew
Cloning into '/opt/homebrew/Library/Taps/lizardbyte/homebrew-homebrew'...
Username for 'https://github.com': BlackdeerY
Password for<EMAIL_ADDRESS>remote: Repository not found.
fatal: repository 'https://github.com/LizardByte/homebrew-homebrew/' not found
Error: Failure while executing; git clone https://github.com/LizardByte/homebrew-homebrew /opt/homebrew/Library/Taps/lizardbyte/homebrew-homebrew --origin=origin --template= --config core.fsmonitor=false exited with 128.
Expected Behavior
No response
Additional Context
No response

Duplicate of #5


check the impact of dynamic calls when query concurrent calls are executed

check the impact of dynamic calls when query concurrent calls are executed.

closed via #222 and https://github.com/line/lbm-sdk/pull/590.


When will Android Embedding Plugin version be available?

Running "flutter pub get" in ttukttak...                            3.2s
The plugin external_app_launcher uses a deprecated version of the Android embedding.
To avoid unexpected runtime failures, or future build failures, try to see if this plugin supports the Android V2 embedding. Otherwise, consider removing it since a future release of Flutter will remove these deprecated APIs.
If you are plugin author, take a look at the docs for migrating the plugin to the V2 embedding: https://flutter.dev/go/android-plugin-migration.
Process finished with exit code 0

The support for Android V2 embedding is now available in external_app_launcher: ^2.0.2


Add a license to the project

Add a license to the project to clarify the conditions of usage.

The project is now under MIT license


Add a link for users to send a verification email

For https://github.com/wellcomecollection/wellcomecollection.org/issues/8179
See Slack discussion here: https://wellcome.slack.com/archives/CUA669WHH/p1660549048977179
When you first land on the page:

Which becomes:

Then either:

Or:

I'd like a review from @DominiqueMarshall on the copy, and devs on the code.

Do the "Please verify your email address... Didn't get an email?" sentences need to remain on these two? I think it would be more understandable if only the text in bold was on these

I think it would be more understandable if only the text in bold was on these

Something like this?


Document testing practices

Most of the frameworks don't show how to test your controllers or forms.
Good to have a testing page in documentation.

Thanks for the suggestion @harikt! I have taken the liberty to change the title to make it easier for me to skim the list

sure @mvriel .
Looking forward to see what you are coming up with :+1:  .


Expose a static method which can generate a JSON schema (using genson…

…) for a notification from the queues table, and can be accessed via a new endpoint. Also add some method comments
Signed-off-by: Samuel Dacanay<EMAIL_ADDRESS>What this PR does / why we need it: Proposes a solution for #490 where the genson package is used to create a JSON schema from an example notification json (should be the same payload as what is used in actual webhook notifications), and expose that schema via a new system endpoint: /system/webhook_schema
Which issue this PR fixes: fixes #490
Special notes:
Endpoint View & Test from Swagger UI (endpoint has since been updated to /webhooks/schema). I decided to structure it this way due to the fact that this change dovetails with #489 and it will make sense to have another endpoint to perform the test

This needs some more work, so we can make sure to have a comprehensive list of the different JSON Schemas that are possible. Actually, it appears there could be a different schema for each event type

Interesting idea @dakaneye , though I'm not sure an API is necessary for this unless it is dynamic based on runtime configuration, which it shouldn't be. I'd actually prefer to make the schemas more rigid internally so that inputs for the notification queue and just document that schema via the swagger.json. There can still be an API involved to test the webhooks. I think there is a lot of value in a POST /system/webhooks/<type>/test capability to help test integrations, so that could also have a GET option for the schema as well but not a hard requirement.

Going to close this for now as I'll be in an intermediate state working things through for a bit.


Update PowerShell Az Modules to 9.0.1

Description
Update installed Powershell Az Module, from 7.5.0 to 9.0.1.
The 7.5.0 is seven months old, and version 9.x is out (1 month ago).
At the moment 9.1.1 is available, but because it's less than 1 day old (at the moment of writing) I prefer to pin to 9.0.1 which has been released one month ago.

/azp run windows2019,windows2022,ubuntu2004,ubuntu2204

@olandese main idea is correct, but devil in the details. Please wait a bit I'll come back with instructions if you want to continue work on that.

@erik-bershel glad to help! :)

@olandese so.
I suggest doing it all at once:

It is necessary to split changes for different OS into different pull requests.
You should not move the current version to the packaged version until there is a separate request from the community for this - we try to save space on virtual machines as much as possible. (main issue in the end)
It is highly undesirable to remove required fields from pull requests that were automatically suggested.
It is advisable to keep pull request names consistent with current practice.

I believe the best way would be to close this one and make two new pull requests with edits in mind. Like these: https://github.com/actions/runner-images/pull/6551, https://github.com/actions/runner-images/pull/6536, https://github.com/actions/runner-images/pull/6481
I understand that this looks like nitpicking. If you don't want to mess with it, then I can issue new pull requests myself.

No problem, I will do that,
You are absolutely not nitpicking, every repo has its own "housekeeping" rules :)


Equivalent of array_init ?

I used the array_init crate for my last project, and I was wondering how to implement that behavior in this crate.
The more idiomatic way would probably be to take a range, convert it into a fixed iterator, and map it but I don't know if there is a better way.
How could this pattern be implemented/included in your crate ?

The problem with ranges is that their length is not known at compile time and thus they can not safely implement IntoIteratorFixed. However I do believe something like (not tested):
let res: [i32; 4] = array_init::from_iter(0..4).unwrap();
assert_eq!(res, [0, 1, 2, 3]);

But for iter_fixed perhaps something like #16 would be useful?

That's exactly what I wanted !
Otherwise, would it be possible to create a fixedRange type that would be compatible with this crate ?

Sure, what about something like this?
use std::ops::Range;
use iter_fixed::{IntoIteratorFixed, IteratorFixed};

// NOTE: The const arguments are START and COUNT unlike Range
// which is on the form first..end . This is needed to avoid requiring the
// unstable feature `const_evaluatable_checked`
#[derive(Clone, Copy)]
struct FixedRange<const START: usize, const COUNT: usize>;

unsafe impl<const START: usize, const COUNT: usize> IntoIteratorFixed<COUNT>
    for FixedRange<START, COUNT>
{
    type Item = usize;

    type IntoIter = Range<usize>;

    fn into_iter_fixed(self) -> iter_fixed::IteratorFixed<Self::IntoIter, COUNT>{
        // Safety: START..(START + COUNT) will always yield COUNT values
        unsafe { IteratorFixed::from_iter(START..(START + COUNT)) }
    }
}

fn main() {
    let a: [usize; 3] = FixedRange::<1, 3>.into_iter_fixed().collect();

    assert_eq!(a, [1, 2, 3]);
}

However if IntoIteratorFixed is the only reason for the type then perhaps something like:
fn fixed_range<const START: usize, const COUNT: usize>() -> IteratorFixed<Range<usize>, COUNT> {
    // Safety: START..(START + COUNT) will always yield COUNT values
    unsafe { IteratorFixed::from_iter(START..(START + COUNT)) }
}

let b: [usize; 3] = fixed_range::<1, 3>().collect();
assert_eq!(b, [1, 2, 3]);

would be more convenient

And to be clear, there is always the escape hatch,  unsafe IteratorFixed::from_iter which can be used for any iterator. However the caller is responsible for guaranteeing that the iterator will yeild N items


Internet Explorer "details" view, XPathResult is undefined

library -> details button click => infinite progress, console says "XPathResult is undefined"
Original Bugzilla:
https://app.devzing.com/Readium/bugzilla/show_bug.cgi?id=56

Suggested fix: migrate from Jath to https://github.com/ilinsky/jquery-xpath

Note that even after fixing the IE browser sniffing using:
if(window.navigator.userAgent.indexOf("Trident") >= 0 || navigator.userAgent.indexOf("MSIE") >= 0 || typeof WScript != "undefined" ) {
	m_browser = 'msie';
}

...there is still a fatal error:
Object doesn't support property or method 'setProperty'
For more information about Jath issues in IE (including lack of support for prefixed XML namespaces), see:
https://github.com/dnewcome/jath/issues/20
and
https://github.com/dnewcome/jath/issues/17

Pull Request: https://github.com/readium/readium-js-viewer/pull/285


Temporary middleware fix

Temp middleware fix
What user problem are we solving?
Currently, the Routes are outputting an error since an h3 is a child inside one of the Route's. In addition, the latest additions in middleware.py are always outputting a User is not authenticated error.
What solution does this PR provide?
This PR provides temporary relief by reverting and adapting an old version of middleware.py from here that works and fixed the routes.
Other minor changes:

Removed duplicate App.css imports
Resolved Wiki key warning

Testing Methodology
Tested on Iris in dev
Any other considerations

did u test this? @farisdurrani

we do not need explicit /health route @farisdurrani


Pip install

Before PR is merged, pip install git+git://github.com/CLARIAH/grlc will not work.
Instead, test using:
pip install git+git://github.com/c-martinez/grlc.git@pipInstall

Once this works, we can add grlc to pypi, and we will be able to install by doing pip install grlc ;-)

@albertmeronyo -- ready to merge. As soon as we merge this, I can create the release tag and register to PyPI -- then we can finally do pip install grlc ;-)

Thanks a ton @c-martinez !


Add LICENSE.md for MIT license

Hi, I am familiar with your project and I noticed that it does not have a license. I would like to suggest that you add a license to your project so it can be freely used, modified, repurposed, or shared by the open source community. You can find information on various licenses here. To choose the right license for your project, check out choosealicense.com.
I see in the README.md that you mention MIT. It seems like you are considering applying this license, but GitHub currently doesn't recognize these references in your repository. To apply this license in a way that the community can recognize, you can add a file in the root directory of your default branch named LICENSE.md containing your license.

Thanks, done!


refactor(pirateship): pspurchaseditem to stateless function component

replace by https://github.com/brandingbrand/flagship/pull/500


fix: combobox empty input should not be replaced by selected value when typing

📝 Description
On Vue and Svelte, empty input will be replaced by selected value when typing.
⛳ Current behavior (updates)
Empty value is replaced by selected value in combobox.connect function call. Because Vue and Svelte call combobox.connect each time state is updated in derive and do not have defaultValue concept like in react, empty input value keep being replaced while typing.
🚀 New behavior
Do not replace empty value with selected value while typing.
💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
Svelte combobox example is not yet available in this branch, but you can run the e2e-vue tests to check this fix.

Good catch @izznatsir
I'm merging this with #1323 to keep it in a single PR.


HDDS-11926. Use "name" in bucket info JSON for links, same as regular buckets

What changes were proposed in this pull request?
Change the bucket-name for bucket info/ls for linked buckets from bucketName to name, to keep it consistent with source buckets info/ls output
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11926
How was this patch tested?
 If it has a single commit, GitHub uses the commit's message by default, not the PR title.


merge disease (OGMS_0000031) and disease (DOID:4)

The definitions for disease (OGMS_0000031) and disease (DOID:4) are the same. We should only use one of the classes.
cc @yongqunh @sivaramarabandi @linikujp

This is a good point. For DOID, does the disease mean 'human disease' only?
cc @yongqunh @sivaramarabandi @linikujp

As far as I can tell, DOID's definition of disease is not restricted to only humans. If we want/need, we can (of course) make a "human disease" specific class.

@Lynn Schriml @.***>
Lynn, please clarify if DOID's disease includes non-human disease.
Thanks,
Asiyah
On Tue, Jun 8, 2021 at 10:54 AM Bill Duncan @.***>
wrote:

As far as I can tell, DOID's definition of disease
http://www.ontobee.org/ontology/DOID?iri=http://purl.obolibrary.org/obo/DOID_4
is not restricted to only humans. If we want/need, we can (of course)
make a "human disease" specific class.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CIDO-ontology/cido/issues/17#issuecomment-856838708,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACCPEPM75SWGPJTUYRIJLN3TRYVJLANCNFSM4TBC2QVA
.

Hello Asiyah,
the DO term 'disease', DOID:4, is not specific to any organism.
The ontology, Human Disease Ontology, only includes human diseases.
Previous discussions with OGMS - agreed to keep it agnostic of organism,
thus to enable reuse, and to avoid proliferation of: organism name - disease
OGMS adopted the DO's 'disease' definition, but created a new ID for the
term.
OGMS used to xref the DOID:4, but looking again, it no longer has the xref.
Based on all of this, I believe you can merge the OGMS and DO terms.
Cheers,
Lynn
On Tue, Jun 8, 2021 at 11:26 AM Asiyah Yu Lin @.***> wrote:

@Lynn Schriml @.***>
Lynn, please clarify if DOID's disease includes non-human disease.
Thanks,
Asiyah
On Tue, Jun 8, 2021 at 10:54 AM Bill Duncan @.***>
wrote:

As far as I can tell, DOID's definition of disease
http://www.ontobee.org/ontology/DOID?iri=http://purl.obolibrary.org/obo/DOID_4
is not restricted to only humans. If we want/need, we can (of course)
make a "human disease" specific class.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/CIDO-ontology/cido/issues/17#issuecomment-856838708,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACCPEPM75SWGPJTUYRIJLN3TRYVJLANCNFSM4TBC2QVA
.

--
Lynn M. Schriml, Ph.D.
Associate Professor
Institute for Genome Sciences
University of Maryland School of Medicine
Department of Epidemiology and Public Health
670 W. Baltimore St., HSFIII, Room 3061
Baltimore, MD 21201
P:<PHONE_NUMBER> |  F:<PHONE_NUMBER>
@.***


Fix restoring the libxml error handling

The setting should be restored to its previous value, not be set to false.

Thank tou @stof


fixes button order

Describe your PR
Order of buttons in /businesses was wrong
Should be:

Business type
Zip code
Need

Current oder:

Need
Business type
Zip code

Related to #
Fixes #
Pages/Interfaces that will change
/businesses
Screenshots / video of changes
Drop some screenshots of the before and after of your work here. Better yet, take a screen recording using a tool like Loom

Steps to test

go to /businesses
check order of buttons for filtering/searching
verify buttons work the same despite order

Additional notes

 Business page filter order


Respond with error message if operation fails

For example: I didn't specified location in provisioning parameters, it would return:

$ cf create-service azure-sqldb basic sqlsql
Creating service instance sqlsql in org IP.xip.io_ORGANIZATION / space azure as admin...
FAILED
Server error, status code: 502, error code: 10001, message: The service broker rejected the request to http://asb.IP.xip.io/v2/service_instances/ace140b2-79dc-4ed3-bacb-c4eba0eb67dc?accepts_incomplete=true.
Status Code: 400 Bad Request, Body: {}

Relative line:
https://github.com/Azure/azure-service-broker/blob/master/pkg/api/provision.go#L225
See bold, user only knows that it is a bad request but what's the reason in details? User needs to use cf logs asb --recent to find out that.
At worst, some other polling operations are working at the same time, maybe it's a little hard to find the corresponding error message. (PS, such an error is printed to stdout, is it expected?)

2017-11-17T02:03:31.02+0000 [APP/PROC/WEB/0] OUT time="2017-11-17T02:03:31Z" level=debug msg="bad provisioning request: validation error" field=location instanceID=ace140b2-79dc-4ed3-bacb-c4eba0eb67dc issue="invalid location: \"\""

Anyway, it's better to always respond with error message if operation failed.

👍  I ran into this as well. This is the catalog response I get when forgetting to set a required param:
{
      "metadata": {
        "name": "noparams",
        "namespace": "default",
        "selfLink": "/apis/servicecatalog.k8s.io/v1beta1/namespaces/default/serviceinstances/noparams",
        "uid": "d4d93910-e509-11e7-926b-0242ac110006",
        "resourceVersion": "1214",
        "generation": 1,
        "creationTimestamp": "2017-12-19T22:13:24Z",
        "finalizers": [
          "kubernetes-incubator/service-catalog"
        ]
      },
      "spec": {
        "clusterServiceClassExternalName": "azure-mysqldb",
        "clusterServicePlanExternalName": "standard800",
        "clusterServiceClassRef": {
          "name": "997b8372-8dac-40ac-ae65-758b4a5075a5"
        },
        "clusterServicePlanRef": {
          "name": "08e4b43a-36bc-447e-a81f-8202b13e339c"
        },
        "parameters": {},
        "externalID": "cc138095-0826-49a9-a739-023a8666e2b9",
        "updateRequests": 0
      },
      "status": {
        "conditions": [
          {
            "type": "Ready",
            "status": "False",
            "lastTransitionTime": "2017-12-19T22:13:25Z",
            "reason": "ProvisionCallFailed",
            "message": "ClusterServiceBroker returned a failure for provision call; operation will not be retried: Error provisioning ServiceInstance of ClusterServiceClass (K8S: \"997b8372-8dac-40ac-ae65-758b4a5075a5\" ExternalName: \"azure-mysqldb\") at ClusterServiceBroker \"osba\": Status: 400; ErrorMessage: \u003cnil\u003e; Description: \u003cnil\u003e; ResponseError: \u003cnil\u003e"
          },
          {
            "type": "Failed",
            "status": "True",
            "lastTransitionTime": "2017-12-19T22:13:25Z",
            "reason": "ClusterServiceBrokerReturnedFailure",
            "message": "Error provisioning ServiceInstance of ClusterServiceClass (K8S: \"997b8372-8dac-40ac-ae65-758b4a5075a5\" ExternalName: \"azure-mysqldb\") at ClusterServiceBroker \"osba\": Status: 400; ErrorMessage: \u003cnil\u003e; Description: \u003cnil\u003e; ResponseError: \u003cnil\u003e"
          }
        ],
        "asyncOpInProgress": false,
        "orphanMitigationInProgress": false,
        "reconciledGeneration": 1,
        "deprovisionStatus": "Required"
      }
    },

Side Note: What's up with all the odd characters (\u003) coming back in the message?


Options

Mark Vertex as optional to run. So, if it fails, that possibly (depends on graph edges), endure will Init and Serve all other Vertices (Disabled Node)
Option to disable topological sort in the flavor of user-defined order.

Duplicate of #9


Selenide could log every step in debug mode

It is useful in case of any mysterious behavior.
For example, for line
$(languageDrpdwn).shouldHave(text("Java"))

it should write a log message Element <option>Javascript</option> contains text "Java".
How to run
Option 1: from command line
 -Dselenide.debug=true
Option 2: by test annotation
@Test @Debug
public void myTest() {...}

both JUnit and TestNG could be supported

A draft version of this functionality was released in Selenide 2.16
See usage example in IntegrationTest:
  @Rule
  public TestRule prettyReportCreator = new PrettyReportCreator();


Include pronunciation in csv export, import

Missing field, needed.

oversight, fixed!

Launched in 3.2.4.


chore: Only run annotation fixing below 3.11.

This causes foo: bool to automatically infer as default=False. As written currently, bool is automatically inferred as non-required, which necessitates there be a default.
I'm not sure whether I think this is ultimately preferable to removing the required=False inference, and instead having the behavior that the defaultedness of the field is the only indicator of whether it's required.
The reason that was introduced in the first place was because --bool, as a simple flag can only set something to True, and having it be required by default may be somewhat weird. However you certainly can specify Annotated[bool, Arg(long=['--bool', '--no-bool'])] and arrive at a place where a required bool might make sense.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

3 of 3 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1779

Relevant Lines:
1779

💛  - Coveralls


ConnectionPool user and password

Hello, I am using the RethinkDB c# driver API. I am looking to see if is possible to user user and password in the database connect using the ConnectionPool? I know I can use user and password properties when creating a single connection. Any help would be greatly appreciated.

Wrong repo? This is for rethinkdbdash not a C# driver.
On Thu, Aug 18, 2016, 14:10 alana1<EMAIL_ADDRESS>wrote:

Hello, I am using the RethinkDB c# driver API. I am looking to see if is
possible to user user and password in the database connect using the
ConnectionPool? I know I can use user and password properties when creating
a single connection. Any help would be greatly appreciated.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/neumino/rethinkdbdash/issues/279, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABZOu_Qn0szX6uMeAdNtRo7s-lEfLy8Qks5qhMpOgaJpZM4Jn63b
.


Wrong unbound-checkconf path for Centos and Scientific 6

Hello,
It seems that path /sbin/unbound-checkconf does not fit neighter Centos nor Scientific linux (release 6), instead it is /usr/sbin/unbound-checkconf . Maybe you can fix this $validate_cmd value in params.pp?

https://github.com/xaque208/puppet-unbound/pull/100

Thank you for the report.


Commands no longer visible with /

@shereefb commented on Fri Jun 17 2016
http://screencast.com/t/bJZ79bX8vBZ
related #116

Fixed via config (colors).


Wrong task url in the @mention notifications

Hello,
I received this notification of a @mention:

The URL/Link is: https://maproulette.org/challenge/38938/task/18086
But this link is wrong and not working. In  fact:

38938 is not the challenge id, it is the project id
18086 is not the task id, it is the project id
and the task id is missing

Can you please fix this? The correct link should be something like so:
https://maproulette.org/project/38938/challenge/18086/task/987654321
Have a nice day :heart:

Thank you for reporting!


EnableOpenSource VSIX does install in VS2015 CTP 5

Build and Debug F# OSS using deployment.sln does not actually install the EnableOssDebug vsix.

Is the title a typo? Did you mean "does not install"?

This may be a separate issue, but I just got a few errors after following the instructions in DEVGUIDE.md (basically build vsintegration, run debug\net40\bin\EnableOpenSource.vsix)
I think the DEVGUIDE.md must be missing a step somehow.  I'll try to dig into it
This error in the F# Interactive window:
Exception details:
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.IO.FileNotFoundException: Could not load file or assembly 'FSharp.Compiler.Server.Shared, Version=<IP_ADDRESS>55, Culture=neutral, PublicKeyToken=f536804aa0eb945b' or one of its dependencies. The system cannot find the file specified.
   at Microsoft.VisualStudio.FSharp.Interactive.Session.createSessionProcess()
   at Microsoft.VisualStudio.FSharp.Interactive.Session.restart@402.Invoke(Unit unitVar0)
   at Microsoft.VisualStudio.FSharp.Interactive.Session.createSessions@440-5.Microsoft-VisualStudio-FSharp-Interactive-Session-Sessions-Restart()
   at Microsoft.VisualStudio.FSharp.Interactive.FsiToolWindow..ctor()
   --- End of inner exception stack trace ---
   at System.RuntimeTypeHandle.CreateInstance(RuntimeType type, Boolean publicOnly, Boolean noCheck, Boolean& canBeCached, RuntimeMethodHandleInternal& ctor, Boolean& bNeedSecurityCheck)
   at System.RuntimeType.CreateInstanceSlow(Boolean publicOnly, Boolean skipCheckThis, Boolean fillCache, StackCrawlMark& stackMark)
   at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean skipCheckThis, Boolean fillCache, StackCrawlMark& stackMark)
   at System.Activator.CreateInstance(Type type, Boolean nonPublic)
   at System.Activator.CreateInstance(Type type)
   at Microsoft.VisualStudio.Shell.Package.CreateToolWindow(Type toolWindowType, Int32 id, ProvideToolWindowAttribute tool)
   at Microsoft.VisualStudio.Shell.Package.FindToolWindow(Type toolWindowType, Int32 id, Boolean create, ProvideToolWindowAttribute tool)
   at Microsoft.VisualStudio.Shell.Package.Microsoft.VisualStudio.Shell.Interop.IVsToolWindowFactory.CreateToolWindow(Guid& toolWindowType, UInt32 id)
   at Microsoft.VisualStudio.Platform.WindowManagement.WindowFrame.ConstructContent()

and this when I open an F# script

(I didn't have VS2015 CTP5 installed, will try that now)

This was fixed with:  https://github.com/Microsoft/visualfsharp/issues/188

I need to revert the description.

The fix integrates FSI into the F5 build experience.  It doesn't integrate the compilers yet.

Merged fix for FSI and opened new issue to integrate the compilers.


fix: tekton v0.45.0 compatibility, enable integration-service tests

Description
update tests to match w/ tekton API v0.45.0 + enable integration-service tests
Issue ticket number and link
RHTAPBUGS-203
Type of change

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
CI 🤷
Checklist:

[X] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

/test all

/test redhat-appstudio-e2e

/test redhat-appstudio-e2e

/test redhat-appstudio-e2e

/test redhat-appstudio-e2e

/hold


add additionalVolumes and additionalVolumeMounts to helm chart

Fixes issue #950.

@brunocous the docs need updating to include the new values.yaml options https://github.com/actions-runner-controller/actions-runner-controller/blob/master/charts/actions-runner-controller/README.md, otherwise LGTM

Updated the docs. Well the workflow did not run because it requires approval: "First-time contributors need a maintainer to approve running workflows. Learn more."

https://www.githubstatus.com/incidents/98jx6ncp3s4z I'm guessing the PR workflow for charts isn't firing because there is an active incident against PRs atm.


Make interactive mode print to stderr

If interactive mode prints all output needed for interaction to stderr instead, then examgen can be used in interactive mode from Vim too, e.g.:
:.! examgen -d *.tex -t topic1 topic2 ... topicN -i

to have examgen's output inserted into the current line in the buffer.  And that line is probably between \begin{questions} and \end{questions}.

This cannot be done as suggested.  Vim uses stdin for piping the current line into examgen, so we cannot do anything interactively.
Another attempt is to use :read! examgen -d *.tex -t topic1 topic2 ... topicN -i instead.  However, this doesn't work for interactive commands either.


separate transfer queue to active and standby processor

separate queue ack mgr into separate file
UT in next PR

Coverage decreased (-0.1%) to 64.701% when pulling c42b31dee73f034ea26d2e851a1cd32fad64e625 on transfer-Q-ack-x into 41fcd038d55e1af7149119adf29363398820a5c7 on master.


Fix missing symlink

Some symlinks are missing in the beRi environment
ex:
bin, etc, modules, share, lib, in the <root>\lib\R folder

https://github.com/datasnakes/renv/commit/74ebe637592cf135a69dc4fe89311dbbbedca516 also addresses this with the include directory.


Bump Rails, Rack and jQuery Rails for security fixes

Vulnerabilities addressed:

CVE-2015-3225
https://groups.google.com/forum/#!topic/rubyonrails-security/gcUbICUmKMc
CVE-2015-1840
https://groups.google.com/forum/#!topic/rubyonrails-security/XIZPbobuwaY
CVE-2015-3227
https://groups.google.com/forum/#!topic/rubyonrails-security/bahr2JLnxvk

Also adds a workaround for - CVE-2015-3226
https://groups.google.com/forum/#!topic/rubyonrails-security/7VlB_pck3hU

Updated.


Soory, but How to install

Hello,
Sorry but I can't install, do you have a procedure to follow ?
Thanks a lot,
Regards,
DaFray31

Hey DaFray31,
the installation is fairly easy. You need to grab the most recent version from https://files.jinya.de/cms/stable/ current is 15.0.0 and put the contents of the zip on your webserver and point the domain to the installation directory.
A short side note, Jinya is currently only in German, an English version will be added with version 16.0.0.
Greetings
Knerd

I put the zip in the web server's folder, except that when I go to the public folder, I get a 500 error (same when I try to access index.php). (on Brave browser, but on Firefox i have blank page)
Also if you want I can help you to translate it into French.
I'm looking forward to hearing from you,
DaFray31

You need to extract the zip to the web server folder and point the domain to {installDir}/public. That should give you the install wizard when you access it.
And yeah a french translation would be great :)

Exactly, that's what I do and I always get a 500 error !

Which php version are you using? Jinya requires version 7.4.

Nothing's changed :/
if you want I can give you access to my host.

The errors I find in my server logs are :
Sat Mar 21 20:37:13.692322 2020] [authz_core:error] [pid 21343:tid<PHONE_NUMBER>4256] [client _ip_] AH01630: client denied by server configuration: /home/jamamamchs/public_html/src/

Also mt .htaccess is :
<IfModule mod_authz_core.c>
    Require all granted
</IfModule>
<IfModule !mod_authz_core.c>
    Order deny,allow
    Allow from all
</IfModule>

Jinya provides its own .htaccess to set several properties. Maybe that could cause the issue.


interface/routes: let plugin reconfigure routes after startup

Hi,
tried to setup loadbalancing via multiple Wireguard gateways. Works fine so for, but when the system reboots, the routes are added before the interface has an ip address. After startup of Wireguard I can call
configctl interface routes configure
And everyting works.
Now I'm wondering where I could place this since it has to be set with every Save cause the interface goes down, but also somewhere within rc script since at startup the reconfigure action of the plugin is not called.
setup.sh does not work since it's called before startup, initscript is not clean, perhaps there's a rc.conf variable to use for templating?

yes [start] action, after service start via rc.d

Thx, forgot about start action :)

Sorry, in start action it does not fix it when the system comes up (= start in rc script, not actions)

https://github.com/opnsense/plugins/commit/bbd15177f7ecb1f3e


Already have package.json file in the root (default Magento package.json for grunt)

Hi
Thank you for the extension. I am trying it out on my Magento store.
However, I am stuck on the step where I have to copy package.json.sample-aws to package.json because I already have Magento's package.json file for grunt.
How should I handle this?

Hi @VivekShingala
You could simply remove your old package.json and rename new one or just copy content from the package.json.sample-aws to the your package.json.

Hi @VivekShingala
You could simply remove your old package.json and rename new one or just copy content from the package.json.sample-aws to the your package.json
Also need to remove your node_modules directory before run npm i


Fixed #422 Issues with dateFormatter docs

@rxaviers sir, @jzaefferer sir,
I have fixed Points 1,3,4,5,6 of issues mentioned in #422 . Please review and let me know the changes and final decision of Point 2 mentioned in the same issue.

@jzaefferer do you suggest any comment to express the "..."? Should we drop it?

Awesome thanks

@jzaefferer sir @rxaviers sir,
Lets finalize and land this fix. Thank you.

Just the one comment issue, rest looks good. Need one more follow-up ticket from #422 before that can be considered fixed.

Just the one comment issue, rest looks good. Need one more follow-up ticket from #422 before that can be considered fixed.

Let's have this PR landed saying "Ref #422". The two follow-up tickets from #422 can be fixed in upcoming PRs.

@rxaviers sir, @jzaefferer sir,
Made the comment change.

@jzaefferer sir, @rxaviers sir,
Please review it and let me know the changes. Thank you. :)

LGTM. Thanks


Fix gaps in type inference

This is a 'kitchen sink' issue for various small things we don't currently handle in type inference :smile:
All of these involve changing infer_expr in ty.rs; some also need improvements to the AST defined in ast.rs / grammar.ron, and it may make sense to wait for hir::Expr (#386) for these.

[x] handle tuple expressions (TupleExpr), e.g. (1, 2, 3)
[x] handle array expressions like [1, 2, 3]
[ ] handle array repeat expressions like [1; 99] (same; note that we currently ignore the length of an array in type inference.)
[x] handle unary - and ! at least for primitive types (see also #390)
[x] handle string and byte string literals
[x] handle char and byte literals
[x] handle int/float literals -- these are a bit more complicated, since we need to use a type variable to infer the exact type, and fall back to the default (i32 / f32?) if we can't infer another type

Hi @gfreezy, I'd suggest starting with tuples. Basically you need to do the following things:

the AST for tuples currently doesn't provide access to the tuple elements, so you need to add that. The AST is generated from grammar.ron; there's a line there saying

        "TupleExpr": (),

you need to add something like collections: [["exprs", "Expr"]] and then run cargo gen-syntax.

in infer_expr there's a match arm for TupleExpr that currently always returns Ty::Unknown; you need to go through the tuple element expressions here, call infer_expr on each of them, collect the resulting inferred types into a Ty::Tuple, and return that as result.
in ty/tests.rs, add a test for this which has some tuple expressions. These tests compare the current inference results against files in ty/tests/data/ which are written the first time each test is run. So before the change, the file will say that the tuple expressions have inferred type [unknown]; afterwards, they should have the correct tuple types.

Once #386 is done, the big match expression in infer_expr will match on a hir::Expr instead of a ast::Expr, but apart from that, this should work the same.

It seems that array repeat expressions like [1; 99] are already implemented. Can this issue be closed? @flodiebold

Hm. Actually, I think they're kind of working accidentally, because we just ignore the repeat number and treat them as an array expression with one element (so we handle [1; 99 as [1]). We should still add proper handling for them (i.e. give them their own Expr variant and handle that in inference).

I wonder what would be the best way to handle the array repeat expressions when the expression is a more complex expression rather than a simple usize, e.g.
const fn foo() -> usize { 6 }
let y = [0u32; 6];
let w = [0u32; { 3 + 3 }];
let x = [0u32; foo()];

All should be inferred to be
const fn foo() -> usize { 6 }
let y: [u32; 6] = [0u32; 6];
let w: [u32; 6] = [0u32; { 3 + 3 }];
let x: [u32; 6] = [0u32; foo()];

This seems like it would require some evaluation during inference.
I guess to start with at least inferring a simple usize expression should be relatively simple ?
Additionally, don't all arrays have a fixed length e.g. ?
let x = [1, 2, 3];
// is the same as
let x: [i32; 3] = [1, 2, 3]

Meaning we could have a new Expr variant but a single Ty variant with a length/expression that would evaluate to a length

@vipentti We currently completely ignore array lengths, because const evaluation would be a whole other can of worms, and they're not that interesting for our current use cases (it's unlikely that [u32; 14] will have different methods to complete than [u32; 15]). Our array type doesn't even have a stored length. So to handle array repeat expressions for now, we'd run type inference on the repeat count, but we wouldn't try to evaluate it in any way.

What kind of inference result would we like to get for
let y = [0u32; 6];
let w = [0u32; { 3 + 3 }];

Something like
y = [u32; <inferred>?];
w = [u32; <inferred>?];

See here -- our array types don't contain any length. So the inferred type currently just looks like [u32] (but it's not a slice).

See here

Broken link.

Try now ;)

I think this issue can be closed

Indeed.


Added Android and IOS app to present on the main page footer

Added Android and IOS app to present on the main page footer

I am not interested in doing this. I do not wish to advertise someone else's mobile app on my website, sorry.


Fix https://github.com/mozilla/thimble.mozilla.org/issues/1492

It looks like the more specific overflow-y was what really needed to get reset.  This fixes if for me locally.

@gideonthomas r?

r+


Extra space on top and bottom of the dropdown button

There is extra space on top and bottom of the dropdown button when I use the DropdownButtonFormField2 and seem like cannot be removed.

add isDense: true contentPadding: EdgeInsets.zero for the decoration parameter.
add padding for the button using buttonPadding and use buttonHeight to increase the button's height.


Add separate "install" task

As part of testing, I'd like to go install all the things before actually starting the services. This avoids services all trying to come up and connect to shared resources at a time when the CPU is already under massive contention.

👍


Feature Request: Implement Failure Track

One thing I always have trouble remembering to do is record my misses on the failure track. I noticed that Mark Your Failure and Learn From Your Failures are listed in the initial commit of moves. In order of importance, I think it would very helpful to have a failure track which:

Can be adjusted manually like the bond track
Reports failure track progress when the character info is printed
Automatically tracks misses on moves and progress moves
Automatically applies new experience and clears the progress per the Learn From Your Failures move

I just pushed a series of commits to master:

Failure track for characters (visible in the print screen when failures are > 0)
Possibility to increase/decrease failure
And your Numbers 3 + 4

Please checkout latest master, rebuild and test. In the next days I will also commit the missing man page changes.

Wow, that was fast. Thanks. It looks like it's working great. I like the "You didn't fail enough, yet!" when you have less than 6.0
The only issue is a small one, when you Learn From Your Failures on a miss, it reports increasing failure by 0.5 because you failed a progress move, but then it silently clears the track as per the move.
Perhaps the resetting of the track should be printed in the output so there is no confusion.

I pushed a commit that fixes the confusing output on a miss of the "learn from your failure" move.

Looks to be working great. Thanks


python 2.7 and 3.5 compatibility

I ran nosetests using 3.5 today and found two major incompatibility errors in the code:

the built-in function xrange does not exist in python 3. Instead, the function range (which creates a static list in python 2) works like xrange in python 3 (where it produces a generator instead). We could in principle replace xrange with range entirely, however, if someone uses python 2.7 and if they generate a very large list with, say, a billion entries, they might run into memory errors. It's unlikely, but not impossible to happen
one of the tests uses func_defaults, which does not exist in python 3, either (the python 3 syntax is __defaults__).

We need to make a policy decision on how to deal with these problems. I'd rather not have the code break in either python 2.7 or python 3.5. @jdswinbank suggested we could check for the existence or xrange in the __init__ file and define range there, or, if this happens quite often, we could use a tool to help us make the code compliant to both.
My first instinct is to look at it on a case-by-case basis for now, and if we get swamped with problems, we might switch to an automatic tool. Thoughts?

Hi,
What I usually do to write python2/3 compatible is to use the module python-future to import the new builtin types and behavior, for example range, print() and division.
The imports change the behavior on python2 to be similar to python3, and it doesn't change anything if called from python3. The bad thing is having to add the future module to the dependencies.
the defaults attribute also works on python2.7x, so changing func_defaults to default should do the trick.
By the way, if I can help in any other way to the project let me know :wink:

Hi,
A few comments:

I opened PR #18 to fix the __defaults__ incompatibility.
I just noticed that python has now the modules __future__ and future_builtins in the standard library. Unfortunately the range function is not included in any of them, but this is useful to know for future development. Maybe it would be a good practice to import everything and keep the code as python3-ish as possible.
The xrange calls only appears in the test code and nowhere else in the main branch. If we can be sure that the tests doesn't have issues with memory we could just change them all to 'range' instead. Unless you intend to use 'xrange' in the main code in the future.

Actually, xrange is used in the rebin_log function of the powerspectrum module so my last comment above is not valid :no_mouth:

Just to keep notice: tests functions and the new significance level method still uses xrange which does not exist in python 3.

We should make a policy decision on whether we focus development on Python 2 or Python 3. I still mostly write Python 2, but I think astropy encourages Python 3 compatible development, which I think we should probably follow. Comments?

I'm trying to force myself to change to Python 3, and so far the only reason I was not completely able to was to interact with pyXspec or Sherpa. If this was a democracy I would vote for a Python 3 focus. :smile:

Also on this page, things like isinstance(norm, str) are not compatible between Python 2 and 3. A possible solution is suggested here: http://stackoverflow.com/questions/11301138/how-to-check-if-variable-is-string-with-python-2-and-3-compatibility
try:
  basestring
except NameError:
  basestring = str

Another way to do this might be using string_types from six, or create an is_string function. In MaLTPyNT, I do that as:
def is_string(s):
    """Portable function to answer this question."""
    PY3 = sys.version_info[0] == 3
    if PY3:
        return isinstance(s, str)  # NOQA
    else:
        return isinstance(s, basestring)  # NOQA

In general, a good reference is good ol'Astropy: https://astropy.readthedocs.org/en/latest/development/codeguide.html

Re the xrange vs range discussion: in my opinion, it's better to just use range. In Py3, it will use an iterator and usually execute a little faster (as it does'nt allocate a list). Since we are evolving towards Py3, the fact that Py2 is a little slower should not count too much.

I agree. Though we might want to supply a warning if the user supplies a very huge number to range in Py2 that it might be very slow/create memory problems?

I'm going to start working on making the code Py2 and Py3 compatible, unless someone else is already on that.

Great, can you also run it trough pep8 or other linter? My text editor, for example, always complain about the number of blank lines before classes or starting comments with ## instead of #. I think it is a good idea to stick to pep8

Yes, I will do that, too.

Agreed. Astropy recommends following pep8, BTW.

One major missing thing in Stingray is a ubiquitous use of the __future__ functions.
At the very least, we should use
from __future__ import print_function, division, absolute_import

everywhere.

The print function has changed in Python 3. Whereas in the API I hope we'll not use print, in scripts it might be useful.

Division of an integer by an integer gives a float in Python 3, an integer in Python 2. Very subtle bugs come out of this in Python 2.

Importing modules from the same package using relative paths has changed in Python 3. When the codebase grows and we have more modules, it will become a problem.

That was the first thing I added. I need to tweak a little more before doing a pull request, but it's in the works.

Some comments from my side :

While we should prefer writing good Python 3 code, it is not very hard to keep supporting Python 2.7
Use of __future__ module is always encouraged.
If there are situations when range() can create memory issues, we can either raise a warning, or add the following at the top of the module

if sys.version[0] < '3'
    range = xrange

Always use list(range(X)) for generating list.

That's all. :)

As I said above, a good reference is the Astropy's code guidelines: https://astropy.readthedocs.org/en/latest/development/codeguide.html

I checked for any dependencies that might be blocking the transition to python 3

Any suggestions on how to figure out which indirect dependencies are causing a problem?

You can remove emcee and corner from the .travis.yml file (for now). We might need it later, but it's not a requirement at the moment.

@dhuppenkothen Should we close this? We are working pretty well on Python 3.5 now :)

Yes, let's close


Add support to export merged env to filesystem via cli.

fix #200
dynaconf list -o path/to/file.yaml --output-flat

Hi @austinnichols101 can I get a review

@rochacbruno sorry for the delay - been dealing with hurricane prep.

@austinnichols101 thanks for feedback, and I hope you are safe from the hurricane.

@austinnichols101 I'll merge this one, and then open a new issue with your idea to turn _store to a DynaBox as moving to a case-less first level may be a breaking change.


[FEATURE] Separate refresh interval for KNN segment merge

Is your feature request related to a problem?
Yes, One of our use case is we have a big document json in an index, that has different text and other fields for filtering and aggregation, opensearch is our source of truth for the data we support via API. We also have a vector field in the same index, and we index the whole document everytime there is a change in some fields in the document, which essentially causes a segment creation after a refresh and eventually a segment merge. I have seen quite a few hot threads that take 100% of CPU during lucene segment merge and also during reindexing to rebuild the hnsw graph. My proposal is we dont need to refresh the graph as often as we refresh our json that has other fields.
Why we have it in the same index is another question, but primarily we use a hybrid search with knn and bm25 and also do some pre & post-filtering and aggregations on the other json fields we have. Hence its faster since we dont have to do multiple requests to achieve the same result.
  "dynamic_templates": [
    {
      "knn_vector_fields_500": {
        "match_mapping_type": "*",
        "match_pattern": "regex",
        "match": "tdp_500.*",
        "mapping": {
          "type": "knn_vector",
          "dimension": 500,
          "method": {
            "name": "hnsw",
            "space_type": "innerproduct",
            "engine": "faiss",
            "parameters": {
              "ef_construction": 200,
              "m": 35
            }
          },
          "index_options": {
            "type": "int8_hnsw"
          }
        }
      }
    }
  ]

100.7% (503.4ms out of 500ms) cpu usage by thread 'opensearch[7835d6139be7922149a306404451262b][[gyg_activity_option_no_6][0]: Lucene Merge Thread #7659]'
     10/10 snapshots sharing following 21 elements
       org.opensearch.knn.jni.FaissService.createIndex(Native Method)
       org.opensearch.knn.jni.JNIService.createIndex(JNIService.java:41)
       org.opensearch.knn.index.codec.KNN80Codec.KNN80DocValuesConsumer.lambda$createKNNIndexFromScratch$4(KNN80DocValuesConsumer.java:190)
       org.opensearch.knn.index.codec.KNN80Codec.KNN80DocValuesConsumer$$Lambda$9857/0x000000010240fa80.run(Unknown Source)
       java.base@17.0.6/java.security.AccessController.executePrivileged(AccessController.java:776)
       java.base@17.0.6/java.security.AccessController.doPrivileged(AccessController.java:318)
       org.opensearch.knn.index.codec.KNN80Codec.KNN80DocValuesConsumer.createKNNIndexFromScratch(KNN80DocValuesConsumer.java:189)
       org.opensearch.knn.index.codec.KNN80Codec.KNN80DocValuesConsumer.lambda$addKNNBinaryField$2(KNN80DocValuesConsumer.java:134)
       org.opensearch.knn.index.codec.KNN80Codec.KNN80DocValuesConsumer$$Lambda$9856/0x000000010240f630.createIndex(Unknown Source)
       org.opensearch.knn.index.codec.KNN80Codec.KNN80DocValuesConsumer.addKNNBinaryField(KNN80DocValuesConsumer.java:141)
       org.opensearch.knn.index.codec.KNN80Codec.KNN80DocValuesConsumer.merge(KNN80DocValuesConsumer.java:209)
       app//org.apache.lucene.index.SegmentMerger.mergeDocValues(SegmentMerger.java:178)
       app//org.apache.lucene.index.SegmentMerger$$Lambda$6908/0x0000000101c87d20.merge(Unknown Source)
       app//org.apache.lucene.index.SegmentMerger.mergeWithLogging(SegmentMerger.java:298)
       app//org.apache.lucene.index.SegmentMerger.merge(SegmentMerger.java:140)
       app//org.apache.lucene.index.IndexWriter.mergeMiddle(IndexWriter.java:5158)
       app//org.apache.lucene.index.IndexWriter.merge(IndexWriter.java:4698)
       app//org.apache.lucene.index.IndexWriter$IndexWriterMergeSource.merge(IndexWriter.java:6450)
       app//org.apache.lucene.index.ConcurrentMergeScheduler.doMerge(ConcurrentMergeScheduler.java:639)
       app//org.opensearch.index.engine.OpenSearchConcurrentMergeScheduler.doMerge(OpenSearchConcurrentMergeScheduler.java:120)
       app//org.apache.lucene.index.ConcurrentMergeScheduler$MergeThread.run(ConcurrentMergeScheduler.java:700)

What solution would you like?
Can we have a separate refresh interval for knn, which by default works as it is now, but can be configured to be refreshed periodically based on that parameter. Since reindexing the graph is essentially generating and rebuild the vertices for that node. Since we have a write heavy use case, we want to reduce the chances of that happening, and we are okay with less accurate "semantic" search for a period.
What alternatives have you considered?
We have built a delta layer during writes to not write if there is no change in any fields, but considering we have a lot of fields, even a small change in one of the fields, causes it to reindex and essentially reindex the node in the graph, even if the vector hasnt changed.
Do you have any additional context?
Added the logs

Any support & direction here would be appreciated, I can pick up the change post discussion :)

thanks @jmazanec15 .
Maybe something around the DocValueConsumer

@Dharin-shah right now as Jack is mentioning there is no solution provided by downstream system (Lucene) to just create data structures like graphs, inverted index etc for some fields.
Now one thing that we need to understand here is Lucene segments are immutable so even if we delay the graph creation but if graphs are not created by the time segments are written on the disk this will lead to more catastrophic issues.
Some suggestions from my side:

I would probably move towards a smaller refresh interval if you are using higher refresh interval with periodic force merge. This will ensure that a lot of documents containing the graphs are not accumulated.
Another solution can be move to Lucene engine. With 2.13 release of OS Lucene will support Dot product and vector apis of Java. What Lucene engine comes with is something called as Incremental graph builds. So, rather than creating graph index at refresh, Lucene engine will create graphs during indexing only. This will reduce the time taken during refresh.
Another thing can be we implement incremental graph creation with Faiss engine. There is big heavy lifting needs to be done here. Let me add a GH issue around this.

thanks @navneet1v

I would probably move towards a smaller refresh interval if you are using higher refresh interval with periodic force merge. This will ensure that a lot of documents containing the graphs are not accumulated.

The current problem is that we do quite frequent merges and segment creation, due to 30sec refresh interval. We have a write heavy workload.

here is Lucene segments are immutable so even if we delay the graph creation but if graphs are not created by the time segments are written on the disk this will lead to more catastrophic issues.

ofcourse yeah, since we use Faiss, is the hnsw graph not indexed separately? we would be fine if the graph is not reindex or the rebuilt for some time

I guess the fundamental problem is that graph reindexing takes up quite a lot of CPU resources, so perhaps addressing that might be better than complex processes

ofcourse yeah, since we use Faiss, is the hnsw graph not indexed separately?

no, its not.

@Dharin-shah I was thinking about the feature you have been asking, one way I can see we might achieve something similar is by adding a setting which can say if the number of vectors is greater than a certain value in the segment then we will create the graphs otherwise we will not create the graph.
Lets say the limit is 1000 vectors. If a segment has more than 1K vectors we will create HNSW graph otherwise we will not create HNSW graph. During search if HNSW graph is present we will do the graph based search otherwise we can do exact search on the vectors which are stored. As segments will start to merge during indexing graphs HNSW graphs will be created when number of vectors threshold goes above 1K.
The only problem I can see with this, during background merges there will be spikes in CPU utilization, but it will same without this feature too. Hence I see for write heavy this can help.
Let me know your thoughts.
cc: @jmazanec15

Like the idea @navneet1v. I have a question,  if we are avoiding graph creation for smaller segments do you think this will be effective as I feel creating graphs for smaller segments may not be computationally expensive and overall impact might be low?

if we are avoiding graph creation for smaller segments do you think this will be effective as I feel creating graphs for smaller segments may not be computationally expensive and overall impact might be low?

Yes creating small graphs is computationally inexpensive, this is a case of heavy write traffic. The graphs will be created and thrown away as segments gets merged. In this case as the traffic was mainly of write I can put a higher value min number of vectors required to create graph and achieve a good write throughput. We will not be avoiding all the spikes in CPU util but atleast with this, we can increase the write throughput with occasional dip throughput when condition to create graphs is met.
Another extreme of this solution is, you completely stop the graph creation till you are indexing and then enable the graph creation during after wards and hit force merge api to recreate the segments and graphs. But that extreme is not going to work in the use case provided by @Dharin-shah. Hence I proposed some intermediate solution that still aligns with the creating graphs during force merges.

@Dharin-shah Are you trying to avoid 100% CPU usage or reduce how often the HNSW graph is constructed? Increasing the refresh time will only help with the second goal. If your goal is to avoid high CPU usage, we could focus on 1. incremental graph construction during ingestion(lucene support this) and 2. slowing down the graph construction process to prevent CPU exhaustion. For the second goal, we could reuse existing graph during merge(lucene support this)
Could you switch to lucene engine and see how it works for your case?

Gotchya, yep that makes sense, will try this out and report

@Dharin-shah the feature for delaying the graph creating is added in 2.18 and will be released with 2.18 . Would you be interested in testing the feature and provide your feedback.
ref: https://github.com/opensearch-project/k-NN/issues/1942

Resolving this issue as I think this feature should resolve the issue: https://github.com/opensearch-project/k-NN/issues/1942


Publish Epinio on Rancher Marketplace

Discussed in https://github.com/epinio/epinio/discussions/1183

Originally posted by agracey January 20, 2022
We should add Epinio to the Rancher Marketplace sooner rather than later.
I'll be setting up a call shortly with the team that maintains the catalog to see if anything additional needs to be done.
In the meantime, here are a few resources on process and requirements:

https://github.com/rancher/charts/blob/release-v2.6/docs/developing.md#introducing-a-new-package
https://github.com/rancher/charts/blob/release-v2.6/docs/developing.md#making-changes-to-packages
https://confluence.suse.com/display/EN/Feature+Charts+Helm+Requirements

We got questions.yaml now: https://github.com/epinio/helm-charts/releases/tag/epinio-0.6.0

We do not seem to have fulfilled all the requirements yet
(My take based on reading https://confluence.suse.com/display/EN/Feature+Charts+Helm+Requirements)

Missing an app-readme.md
We have a CRD in the epinio chart

Ok, that looks to be something we can handle in the submission, via a patch to the epinio chart.

Our image references are not in rancher format.
We do not use the rancher helpers for a custom registry

:warning: this is not about the registry used by epinio for the app images.
This is about the registry where the epinio image itself is pulled from.

Something to look into in the near? future:

UI: Charts will require creating a custom UI page for deploying as we are moving away from questions.yml.

And later on that page

Questions.yml Deprecation

@agracey ^ What do you know about this ?

This issue depends on #1305

Work is done in PR https://github.com/rancher/charts/pull/1814

Created EIO request - https://github.com/rancherlabs/eio/issues/997

Blocked by: https://github.com/epinio/epinio/issues/1680

rancher/helm-controller:v0.12.1 needs to be mirrored too

@andreas-kupries explained that this is included as a helm asset so this is not a blocker.

rancher/helm-controller:v0.12.1 needs to be mirrored too

@andreas-kupries reminder ;)

rancher/helm-controller:v0.12.1 needs to be mirrored too

@andreas-kupries reminder ;)

@jimmykarily Can you tell me where it was needed ? Would like to make note of that in the image-mirror PR to-be

And based on the results of https://hub.docker.com/search?q=mirrored-helm-controller, i.e. nothing was found I will have to make an EIO request also. (In contrast to https://hub.docker.com/search?q=mirrored-coreos-flannel)

rancher/helm-controller:v0.12.1 needs to be mirrored too

@andreas-kupries reminder ;)

@jimmykarily Can you tell me where it was needed ? Would like to make note of that in the image-mirror PR to-be

https://github.com/epinio/helm-charts/blob/3ece8553d285058bd2cfa7feb62b9e57a51f3b86/chart/epinio/templates/helm-controller.yaml#L49

It makes me wonder if the condition here works as expected: https://github.com/epinio/helm-charts/blob/3ece8553d285058bd2cfa7feb62b9e57a51f3b86/chart/epinio/templates/helm-controller.yaml#L1
I mean, I was testing on a "rancher cluster", the whole file should have been skipped (?)

Latest PRs, i.e.

https://github.com/rancher/charts/pull/2135
https://github.com/rancher/charts/pull/2126

are merged. With this Epinio is released in to the Rancher v2.6 Marketplace.


Take FB quick reply payload rather than text as input

Status (please check what you already did):

[x] made PR ready for code review
[x] reformat files using black (please check Readme for instructions)
[x] signed CLA

Hey @lahsuk, thanks for this fix! This doesn't actually address the issues you said were closed in the issue (that's an output channel problem), so I removed that, but this is also a very useful contribution. 🙂

I see.
I send quick replies using custom_json so I, wrongly, assumed that it was a problem after the quick reply buttons were clicked.

@lahsuk sorry, I should have been clearer, what you did, whether you meant to or not, was find a bug that is difficult to find, since it doesn't usually break anything. Currently, the input channel takes the "text" (i.e. the title) of the quick reply button, instead of the payload, as input. Your fix makes it correctly take the payload as input. We would still love to merge your contribution after you add your fix to the changelog!

Okay.
It's my first time contributing so I was quite confused. Thank you for clarifying. 😅

Thank you for your first contribution @lahsuk! 🚀Congrats on joining our group of > 300 contributors 🙂

Thanks for the warm welcome @erohmensing . 🙏
Hope I can make some more contributions in the coming months. ✨


Error LLaMAForCausalLM/layers/0/attention/PLUGIN_V2_GPTAttention_0:

python build.py --model_dir Mistral-7B-Instruct-v0.1 \
                --dtype bfloat16 \
                --use_gpt_attention_plugin bfloat16 \
                --use_inflight_batching \
                --paged_kv_cache \
                --remove_input_padding \
                --use_gemm_plugin bfloat16 \
                --output_dir saved/1-gpu/

I got this error.
the main branch tensorRT-LLM ,it does not support "use_inflight_batching"?
LLaMAForCausalLM/layers/0/attention/PLUGIN_V2_GPTAttention_0: could not find any supported formats consistent with input/output data types
[12/06/2023-05:15:03] [TRT] [E] 9: [pluginV2Builder.cpp::reportPluginError::24] Error Code 9: Internal Error (LLaMAForCausalLM/layers/0/attention/PLUGIN_V2_GPTAttention_0: could not find any supported formats consistent with input/output data types)
[12/06/2023-05:15:03] [TRT-LLM] [E] Engine building failed, please check the error log.
[12/06/2023-05:15:03] [TRT-LLM] [I] Config saved to saved/1-gpu/config.json.
Traceback (most recent call last):
  File "/root/workspace/llama/build.py", line 839, in <module>
    build(0, args)
  File "/root/workspace/llama/build.py", line 785, in build
    assert engine is not None, f'Failed to build engine for rank {cur_rank}'
AssertionError: Failed to build engine for rank 0

Can you share the branch you use? If you don't use the latest main branch, please take a try.

thanks. it's wrong with branch. I change it to the v0.7.1 or v0.6.1. it works well


Notes for IE9-11 on document.readyState are misleading

The notes for IE9-11 on document.readyState are misleading. The notes are:

Only supports 'complete'.
Internet Explorer 9 and 10 have bugs where the 'interactive' state can be fired too early before the document has finished parsing.

Note 1 is linked to IE8, IE9-10 and IE11 but as far as I can tell only applies to IE8.
Notes 2 is linked to IE9-10 and IE11 but as far as I can tell only applies to IE9-10. This one is less problematic as at least the note clarifies which browsers are affected.
This means that the popover for IE11 suggests that it doesn't support 'complete', and shows the unrelated IE9-10 issue:

The browser compatibility table on MDN makes it clearer:

I'm not sure if this is an issue with the source data in https://github.com/mdn/browser-compat-data or with the way caniuse interprets the notes, so apologies if this is in the wrong place – happy to raise the issue over there or raise a PR if someone can give me a pointer as to how to make the note only apply to IE8.

Thanks for finding this! I've looked into it a bit and I believe in this case the issue needs to be fixed from the source data side...the Only supports 'complete'. note is accompanied with "version_added": "8" which generally means it applies to that version and above. I'll write up a BCD PR with suggested fixes and see if folks there agree.

Ah that's ace, thank you! Can't believe that's your first PR on browser-compat-data 😄
I did wonder if that was the way to do it – will keep an eye on that PR and see how it resolves, and in the future if I spot similar things I might be able to help fix it myself!

The PR was merged, and the table has now been updated with correct info, so closing this issue.


Updates specific to Al-Jamiah

[ ] Create page
[ ] Orange area (or whatever alternative is decided upon)
[ ] Add papers
[ ] Share on socmed

Paper is under review


target.json inherits from git doesnt appear to support branches

Its obviously ideal to store features in branches, so something like this is expected
    "nordic-nrf51822-16k-gcc": "jacobrosenthal/target-nrf51822#fota-dat"

but when I use that I get
Jacobs-MacBook-Air:BLE_HeartRate jacobrosenthal$ yt target
redbearlab-nrf51822-gcc,* missing
Jacobs-MacBook-Air:BLE_HeartRate jacobrosenthal$ yt link-target redbearlab-nrf51822-gcc
info: /Users/jacobrosenthal/Downloads/ble-examples/BLE_HeartRate/yotta_targets/redbearlab-nrf51822-gcc -> /usr/local/lib/yotta_targets/redbearlab-nrf51822-gcc -> /Users/jacobrosenthal/Downloads/redbearlab-nrf51822-gcc
Jacobs-MacBook-Air:BLE_HeartRate jacobrosenthal$ yt target redbearlab-nrf51822-gcc
info: get versions for nordic-nrf51822-16k-gcc
Traceback (most recent call last):
  File "/usr/local/bin/yt", line 4, in <module>
    yotta.main()
  File "/usr/local/lib/python2.7/site-packages/yotta/main.py", line 239, in main
    status = args.command(args, following_args)
  File "/usr/local/lib/python2.7/site-packages/yotta/target.py", line 131, in execCommand
    target, errors = c.satisfyTarget(t)
  File "/usr/local/lib/python2.7/site-packages/yotta/lib/component.py", line 580, in satisfyTarget
    update_installed = update_installed
  File "/usr/local/lib/python2.7/site-packages/yotta/lib/target.py", line 95, in getDerivedTarget
    type = 'target'
  File "/usr/local/lib/python2.7/site-packages/yotta/lib/access.py", line 352, in satisfyVersion
    return satisfyVersionByInstalling(name, version_required, working_directory, type=type)
  File "/usr/local/lib/python2.7/site-packages/yotta/lib/access.py", line 294, in satisfyVersionByInstalling
    v = latestSuitableVersion(name, version_required, _registryNamespaceForType(type))
  File "/usr/local/lib/python2.7/site-packages/yotta/lib/access.py", line 145, in latestSuitableVersion
    remote_component.availableTags(),
  File "/usr/local/lib/python2.7/site-packages/yotta/lib/github_access.py", line 249, in availableTags
    ) for t in self._getTags()
  File "/usr/local/lib/python2.7/site-packages/yotta/lib/github_access.py", line 221, in _getTags
    self.tags = _getTags(self.repo).items()
  File "/usr/local/lib/python2.7/site-packages/yotta/lib/github_access.py", line 69, in wrapped
    return fn(*args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/yotta/lib/github_access.py", line 99, in _getTags
    repo = g.get_repo(repo)
  File "/usr/local/lib/python2.7/site-packages/github/MainClass.py", line 200, in get_repo
    "%s%s" % (url_base, full_name_or_id)
  File "/usr/local/lib/python2.7/site-packages/github/Requester.py", line 169, in requestJsonAndCheck
    return self.__check(*self.requestJson(verb, url, parameters, headers, input, cnx))
  File "/usr/local/lib/python2.7/site-packages/github/Requester.py", line 210, in requestJson
    return self.__requestEncode(cnx, verb, url, parameters, headers, input, encode)
  File "/usr/local/lib/python2.7/site-packages/github/Requester.py", line 247, in __requestEncode
    status, responseHeaders, output = self.__requestRaw(cnx, verb, url, requestHeaders, encoded_input)
  File "/usr/local/lib/python2.7/site-packages/github/Requester.py", line 271, in __requestRaw
    requestHeaders
  File "/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 1001, in request
    self._send_request(method, url, body, headers)
  File "/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 1035, in _send_request
    self.endheaders(body)
  File "/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 997, in endheaders
    self._send_output(message_body)
  File "/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 850, in _send_output
    self.send(msg)
  File "/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 812, in send
    self.connect()
  File "/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 1204, in connect
    HTTPConnection.connect(self)
  File "/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/httplib.py", line 793, in connect
    self.timeout, self.source_address)
  File "/usr/local/Cellar/python/2.7.9/Frameworks/Python.framework/Versions/2.7/lib/python2.7/socket.py", line 553, in create_connection
    for res in getaddrinfo(host, port, 0, SOCK_STREAM):
socket.gaierror: [Errno 8] nodename nor servname provided, or not known
Jacobs-MacBook-Air:BLE_HeartRate jacobrosenthal$

Merging my changes into master seems to work
    "nordic-nrf51822-16k-gcc": "jacobrosenthal/target-nrf51822"

Also looks like yt command line doesnt support github at all for targets?
Jacobs-MacBook-Air:BLE_HeartRate jacobrosenthal$ yt target<EMAIL_ADDRESS>error: Invalid target<EMAIL_ADDRESS>Jacobs-MacBook-Air:BLE_HeartRate jacobrosenthal$ yt target git@github.com:jacobrosenthal/target-nrf51822.git
error: Invalid target: "git@github.com:jacobrosenthal/target-nrf51822.git"
Jacobs-MacBook-Air:BLE_HeartRate jacobrosenthal$ yt target git@github.com:jacobrosenthal/target-nrf51822.git#fota-dat
error: Invalid target: "git@github.com:jacobrosenthal/target-nrf51822.git#fota-dat"
Jacobs-MacBook-Air:BLE_HeartRate jacobrosenthal$ yt target jacobrosenthal/target-nrf51822.git#fota-dat
error: Invalid target: "jacobrosenthal/target-nrf51822.git#fota-dat"
Jacobs-MacBook-Air:BLE_HeartRate jacobrosenthal$ yt target jacobrosenthal/target-nrf51822.git
error: Invalid target: "jacobrosenthal/target-nrf51822.git"

Related issue:
in my redbearlab-nrf51822-gcc target, I inherit from a fork of nordic's targets (but they have multiple within that repo)
    "nordic-nrf51822-16k-gcc": "jacobrosenthal/target-nrf51822"

Normally when I link, a yt install appears to be run for me, but it doesnt happen here. Manually running it doesnt fetch all the required dependencies and a yt build fails
Jacobs-MacBook-Air:BLE_HeartRate jacobrosenthal$ yt link-target redbearlab-nrf51822-gcc
info: /Users/jacobrosenthal/Downloads/ble-examples/BLE_HeartRate/yotta_targets/redbearlab-nrf51822-gcc -> /usr/local/lib/yotta_targets/redbearlab-nrf51822-gcc -> /Users/jacobrosenthal/Downloads/redbearlab-nrf51822-gcc
Jacobs-MacBook-Air:BLE_HeartRate jacobrosenthal$ yt target redbearlab-nrf51822-gcc
info: get versions for nordic-nrf51822-16k-gcc
info: download<EMAIL_ADDRESS>from GitHub jacobrosenthal/target-nrf51822
info: get versions for mbed-gcc
info: download<EMAIL_ADDRESS>from the public module registry
Jacobs-MacBook-Air:BLE_HeartRate jacobrosenthal$ yt install
info: get versions for ble
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for ble-nrf51822
info: download<EMAIL_ADDRESS>from the public module registry
Jacobs-MacBook-Air:BLE_HeartRate jacobrosenthal$

However if Isolate the target Im attempting to inherit from into its own repo
    "nordic-nrf51822-16k-gcc": "jacobrosenthal/nordic-nrf51822-16k-gcc"

It still doesnt install automatically yt install for me like a published targed would, but it DOES install everything and build successfully
Jacobs-MacBook-Air:BLE_HeartRate jacobrosenthal$ rm -rf yotta_*
Jacobs-MacBook-Air:BLE_HeartRate jacobrosenthal$ yt link-target redbearlab-nrf51822-gcc
info: /Users/jacobrosenthal/Downloads/ble-examples/BLE_HeartRate/yotta_targets/redbearlab-nrf51822-gcc -> /usr/local/lib/yotta_targets/redbearlab-nrf51822-gcc -> /Users/jacobrosenthal/Downloads/redbearlab-nrf51822-gcc
Jacobs-MacBook-Air:BLE_HeartRate jacobrosenthal$ yt target redbearlab-nrf51822-gcc
info: get versions for nordic-nrf51822-16k-gcc
warning: Github repository "jacobrosenthal/nordic-nrf51822-16k-gcc" has no tagged versions, default branch will be used
info: download nordic-nrf51822-16k-gcc@ from GitHub jacobrosenthal/nordic-nrf51822-16k-gcc
info: get versions for mbed-gcc
info: download<EMAIL_ADDRESS>from the public module registry
Jacobs-MacBook-Air:BLE_HeartRate jacobrosenthal$ yt install
info: get versions for ble
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for ble-nrf51822
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for mbed-drivers
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for mbed-hal
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for cmsis-core
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for ualloc
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for minar
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for core-util
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for compiler-polyfill
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for mbed-hal-nordic
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for mbed-hal-nrf51822-mcu
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for mbed-hal-mkit
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for cmsis-core-nordic
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for cmsis-core-nrf51822
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for dlmalloc
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for minar-platform
info: download<EMAIL_ADDRESS>from the public module registry
info: get versions for minar-platform-mbed
info: download<EMAIL_ADDRESS>from the public module registry
error: ble-nrf51822 does not meet specification ^1.0.0 required by mbed-hal-nrf51822-mcu
Jacobs-MacBook-Air:BLE_HeartRate jacobrosenthal$

The limited command-line support for complex installation sources like branch is a known issue, but I think it should work OK in inherits: in the target.json file.
Note that in this case, the nordic targets are not one-per-repository, so there will not be a target.json file at the root of the repository, which is what yotta expects when downloading from github. So perhaps that is why you had a problem?
For now you will need to use yotta link-target to use your custom target version.


Handle information about the time and position possibly sent from a host

This ability will be required e.g. for sync_beats or delay_beats. From the frontend PoV it has to link to LV2 Time, JACK master clock or VST3 PPQ position.
See also #311

In LV2 it can have some complication, I suggest referring to DPF.
https://github.com/DISTRHO/DPF/blob/fb3cd6372592f37b064f770adfccc02dead5f1ae/distrho/src/DistrhoPluginLV2.cpp#L335
What's the behavior when host stops the playback?
is one supposed to pass a 0 to the tempo API of sfizz?

I... guess?
Although I would expect the host to just stop calling the render function in this case?

I need a way to move this button....

For the delay effect it needs to receive BBT info.
It has syncing functions which trigger an advance of the delay every N beats.
There are also *_beats opcodes in regular SFZv2.

I'm closing this since the API accommodates it now. It's more a matter of implementing opcodes that use it, and we can track this separately.


Extend the handler for other events: Ready

The current event handler system is only implemented for Message and Reaction(Add/Remove) events and needs to be extended to the other events used by the bot.
The steps required for this should be common for all events:

[ ] Create a new file for the event in src/event-distribution/events
[ ] Implement 4 details for the event (have a look at the other events for inspiration):

[ ] An interface for the options
[ ] A type defining the function parameters for the handler function
[ ] A function that adds a new handler in the preset structure so it can be retrieved later
[ ] A function that extracts information the distributor uses to determine which handlers should be run

[ ] Update src/event-distribution/events/index.ts to include the above things
[ ] Update src/index.ts to call the distribution with the bot itself.

This issue tracks progress of the process of adding the Ready event.

Closed in #346


Non nullable variables should allow default values

Expected Behavior
Queries should be able to define non-nullable variables with default variables.  This is currently prevented by the check here:
https://github.com/async-graphql/async-graphql/blob/759fb0e594606aecf4a239b00d6f3f8aeb22d885/src/validation/rules/default_values_of_correct_type.rs#L32-L36
The formal specification for how variables are processed is described here: https://spec.graphql.org/October2021/#sec-Coercing-Variable-Values
In short, in GraphQL non-nullable means the value can't be null, but isn't directly related to weather or not the variable must be provided by the user:
This leads to some non-intuitive behavior:

A non-nullable variable with a default value is optional, and will error if the variable is explicitly passed as null
A nullable varaible with a non-null default value can still be explicitly set to null, overwriting the default value

This same logic applies to defaults provided in the schema for arguments (https://spec.graphql.org/October2021/#sec-Coercing-Field-Arguments)
The relevant part of the JS reference implementation is here: https://github.com/graphql/graphql-js/blob/main/src/execution/values.ts#L94-L105
This checks for a default value BEFORE before checking for non-nullablity, and will only error if the field is both non-nullable and does not provide a default value
Actual Behavior
Any query that defines a default value for a non-nullable variable errors
Steps to Reproduce the Problem

Define a schema that has a non-nullable argument
Write a query with a non-nullable variable with a default value
Execute the query, without providing any variables

Specifications

Version:
Platform:
Subsystem:

Here's a quick example of this working using the reference graphql-js implementation: https://stackblitz.com/edit/typescript-5qrssw?file=index.ts

Could you be so kind to share a snippet of the source code, that raises the error above?

Here's a simple reproduction: https://github.com/hayes/repro-async-graphql-non-null-vars/blob/master/src/main.rs


spelling error in code

In floor(::ArbComplex{128}) at src/libarb/ArbComplex.jl:347,  there is a florr which should be a floor, currently the dispatcher cannot find the right function.

thanks -- fixed in master -- will register new


TLF sync config change notifications from kbfs to GUI

gofmt issues in proto for 1.12...

Looks good in Go-land other than my comment.  Not sure about the JS line so a react-hacker should look.

After rebasing CI passes again.


Container is not collapsing when empty

Describe the bug
I've a dashboard RPi that is always displaying a HA dashboard with the battery card.
Recently I witnessed that the battery card was empty after I changed the batteries due to the filter. But the space was not used by the entity on the right side of the card.
I'll try to reproduce the issue later at home of make a foto of the dashboard.
How to reproduce

Create a dashboard (new default kind).
Add a full-width section
Add a battery card that conditionally displays battery entities.
Add cards to the left and right.
Make the battery card display an entity
Make the battery card display no entities
Now there is a gap between the two surrounding cards but the battery card is not displayed.

Expected behavior

YAML configuration

# please paste here your card config (before backticks below; do not remove them)

Entity debug data

Dev console errors

Screenshots

Version

Here now a screenshot:

Or maybe that's an issue of the section layout?


phpunit as required dependency

Why is PHP unit an dependency for this package. In 'dev' mode, sure but why in non dev mode?

Thanks for noticing, I just tagged 1.0.2 where this is fixed.

@slootjes 👍