Ceiling(NaN()) causes an overflow

Describe the bug
The result of Lg with a non-positive parameter is NaN, so running the following program will cause overflow. The part of the output is shown below:

Unhandled exception. System.OverflowException: Arithmetic operation resulted in an overflow.

To Reproduce
namespace NISLNameSpace {
	open Microsoft.Quantum.Intrinsic;
	open Microsoft.Quantum.Math;

	@EntryPoint()
	operation main() : Unit {
		let nIdxRegQubits = Ceiling(Lg(-1.0));
		// same as:let nIdxRegQubits = Ceiling(NaN());
		Message($"{nIdxRegQubits}");
	}
}

Expected behavior
Maybe a range check can be used to avoid it.
System information
operating system : Ubuntu 22.04 LTS
dotnet version : 6.0.400
QDK : 0.25.228311

It seems this API effect other APIs, one can be seen in https://github.com/microsoft/QuantumLibraries/issues/570; if give targetError a value of 0.0, an overflow behavior will occur. It might be better to fix Ceiling rather than other high-level APIs.

Thanks @weucode for filing this. It would be better to return NaN in this case. The function is implemented in Microsoft/qsharp-runtime (see https://github.com/microsoft/qsharp-runtime/blob/15a54935a2f9ac5cac798385bb3b4952deae3496/src/Simulation/QSharpFoundation/Math/Math.qs#L506), so I am transferring the issue to that repository.


Set up users that have access to admin page

We have /admin, which will have buttons for import/export & admin swaps.
Create the accounts to access this.
Small version: single password to access the admin page
How do we want to create the admins?

For branch tracking purposes maybe we consider this a sub-issue of #11 ??
I'll push the initial admin branch and link to it in that ticket. Then log this work as a first priorty task in that issue

Current solution is to have an admins table.
@Index01 We will need to find a way to export and share the passwords for a production instance

This should be werking from the last PR, #11
add user to the /samples/exampleStaff.csv, mark is_admin true then run the pop_res.py script

@Index01 can we close this?

Good enough, closing!


cherry-pick(build): enable auto build for arm64 binaries (#371)

refactor build script and ci scripts to work on multiple platforms. Only on amd64, the unit tests and integration tests will be run. On all other platforms, the binary and docker images will be built
and pushed.
Signed-off-by: Akhil Mohan<EMAIL_ADDRESS>

Codecov Report

Merging #380 into v0.4.x will decrease coverage by 0.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           v0.4.x     #380      +/-   ##
==========================================
- Coverage   52.18%   51.74%   -0.44%
==========================================
  Files          52       52
  Lines        2545     2545
==========================================
- Hits         1328     1317      -11
- Misses       1110     1118       +8
- Partials      107      110       +3

Impacted Files
Coverage Δ

cmd/ndm_daemonset/probe/eventhandler.go
46.05% <0%> (-7.9%)
:arrow_down:

cmd/ndm_daemonset/probe/udevprobe.go
61.83% <0%> (-3.82%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b18203...f4ab1f3. Read the comment docs.


Revert "Datadog logs (#928)"

This reverts commit 67ca357f527c5a1f38abed9adeb787c8123dea13.
What changed? Why?
Notes to reviewers
How has it been tested?

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1

🟡 Heimdall Review Status

Requirement
Status
More Info

Reviews

🟡
0/1

Denominator calculation

Show calculation

1 if user is bot
0

1 if user is external
0

From .codeflow.yml

1

Additional review requirements

Show calculation

Max
0

0

From CODEOWNERS

0

Global minimum
0

Max

1

1

1 if commit is unverified
0

Sum
1


Empty Files not working when moving Mmap

Hi, there seems to be an issue when, a Mmap is created and then moved on an empty file.
I get an "The volume for a file has been externally altered so that the opened file is no longer valid." error under windows.
You can add this to the tests to reproduce. It works without the closure.
I also noticed the offset test is not working on Windows.
use std::fs::File;
/// Checks that a 0-length file will not be mapped when moved.
#[test]
fn map_empty_file_copy() {
    let tempdir = tempdir::TempDir::new("mmap").unwrap();
    let path = tempdir.path().join("mmap");

    let file = OpenOptions::new()
        .read(true)
        .write(true)
        .create(true)
        .open(&path)
        .unwrap();

    let get_mmap = |file:&File| -> Mmap {
        unsafe { Mmap::map(&file).unwrap() }
    };

    let mmap = get_mmap(&file);
}

I don't think you can memory map an empty file.

I see, there is already a test for this. Is there a way to append to a file via mmap?


luci-app-wol sends a wrong etherwake command.

The problem is very simple but caused me many hours of work to figure it out:
luci-app-wol is just the GUI for etherwake commands BUT it sends commands with MAC addresses in capital letters 1A:2B:3C:D4:E5:F6 but my pc wakes up only if it receives the command with the MAC in lowercase 1a:2b:3c:d4:e5:f6 so the solution is pretty simple, make luci-app-wol send the command with the lowercase MAC address

I think you don't know how wake on LAN works. Wake on LAN using a protocol called magic packet. The MAC address in magic packet is raw bytes, instead of ASCII text. So there's no upper or lower case.
I think it's a bug of etherwake. You can use Wireshark to check if the packet is actually sent.

@ysc3839 I totally agree with you, that's crazy. You don't know ho many hours of work I spent to resolve the issue. I used wireshark, I used the tcpdump command on my freenas to see if packet arrived, i used so many tools to try to understand why this windows program was ALWAYS able to wake my freenas pc but luci-app-wol isn't.
I of course went in ssh and wrote so many commands like:
/usr/bin/etherwake -D -b "1A:2B:3C:D4:E5:F6"
/usr/bin/etherwake -D -i "br-lan" -b "1A:2B:3C:D4:E5:F6"
/usr/bin/etherwake -D -i br-lan -b 1A:2B:3C:D4:E5:F6
/usr/bin/etherwake 1A:2B:3C:D4:E5:F6 -D
and at least 100 other that don't make any sense, i was able to see the packet with wireshark, they arrived to my freenas, seen with tcpdump, but they never woke it up!
Untill I used this command:
/usr/bin/etherwake -i br-lan 1a:2b:3c:d4:e5:f6
this command up here just works, any other command does not.
Please believe me and save the same amount of time spent figuring it out to the next guy :)


double-beep: Watch sobatpokerku99.blogspot.com

double-beep requests the watch of the watch_keyword sobatpokerku99\.blogspot\.com. See the MS search here and the Stack Exchange search here.

sobatpokerku99\.blogspot\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Makyen in Charcoal HQ


[api/v1][query_obj] add default prequeries array

This PR only affects the embeddable charts /api/v1/query endpoint. I'm working on adding react <ChartDataProvider /> components in @superset-ui and when I use the new (non-legacy) WordCloudPlugin together with SuperChart + ChartClient I get the following stack trace from Python in the Superset App:
POST /api/v1/query/ => {"datasource":{"id":3,"type":"table"},"queries":[{"granularity":"ds","metrics":[{"label":"sum__num"}],"groupby":["name"]}]}
2019-03-14 17:24:21,854:ERROR:root:'NoneType' object has no attribute 'append'
Traceback (most recent call last):
  File "/Users/chris_williams/dev/superset/superset/common/query_context.py", line 206, in get_df_payload
    query_result = self.get_query_result(query_obj)
  File "/Users/chris_williams/dev/superset/superset/common/query_context.py", line 82, in get_query_result
    result = self.datasource.query(query_object.to_dict())
  File "/Users/chris_williams/dev/superset/superset/connectors/sqla/models.py", line 861, in query
    query_obj['prequeries'].append(sql)

This is because prequeries is not passed for this chart, and there is no default on the Python side. This PR adds a default and updates the type, I think it's an optional List of Dicts, setting the default to {} errored downstream as something was trying to append to it 😄 so maybe it was typed wrong?
@xtinec @conglei @kristw

Thanks for fixing this!

Codecov Report

Merging #7039 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #7039   +/-   ##
=======================================
  Coverage   64.45%   64.45%
=======================================
  Files         421      421
  Lines       20524    20524
  Branches     2245     2245
=======================================
  Hits        13229    13229
  Misses       7168     7168
  Partials      127      127

Impacted Files
Coverage Δ

superset/common/query_object.py
26.31% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ca2cc1...1931911. Read the comment docs.


Getting error to run transcription

Hi,
I'm trying to run this sample but I'm getting this error when I start the transcription (for both file and microphone)
Error Domain=WebSocket Code=403 "Invalid HTTP upgrade" UserInfo={NSLocalizedDescription=Invalid HTTP upgrade}
So far I tried it only in XCode Simulator for iPhone 6/7. Is it expected to work in the simulator or do I need a real device to test ?

Hi @leandrodvd. I think this issue is related to the transition from HTTP to WebSockets. It cropped up frequently during early development of Speech to Text, but seemed to disappear when we moved to newer versions of the Starscream WebSockets library.
Would you mind trying to run your code several more times? Is this a consistent issue or intermittent? If intermittent, is it relatively common or relatively rare?
If you run into this problem often, then perhaps there are upstream changes to the Starscream WebSockets library that we should integrate into the SDK.

Just a note that we've updated the Watson Swift SDK to use the latest version of Starscream. This issue should be resolved.


Carefully read Eric Bellm's material

Could you give us some URLs ?

In the project description
https://github.com/lsst-uk/lasair/projects/7

14/JUL/21

@RoyWilliams says this is done


Fix compat with tiled API changes.

Description
Update usage of ArrayAdapter.
Motivation and Context
Tiled made backward-compatible changes in https://github.com/bluesky/tiled/pull/537. The databroker adapter was not fully updated to account for this. The issue went un-caught because it only occurs on a codepath where a databroker handler returns a Dask Array. This is not tested.
How Has This Been Tested?
I tested this interactively by looking at two pieces of real beamline data:

https://tiled-demo.blueskyproject.io/ui/browse/bmm/raw/5631b9e1-b07d-4455-ae85-36e9a84ab7dc/primary/data/I0
https://tiled-demo.blueskyproject.io/ui/browse/fxi/raw/1b0b4d73-6d87-43ab-8d62-ed035c51b9b4/primary/data/Andor_image

...using current main (broken) and this PR.
There should be a unit test but that would actually be a pretty big addition to the current Databroker test harness, and we are in a rush to land this before the resumption of operations.

An unrelated recently-merged PR, https://github.com/bluesky/databroker/pull/638, broke main. That PR was so old that that the CI determination got stale. A lesson there is to re-run CI on old PRs.
The last 3 commits here clean that up.


Big cookies do not work

We came across this issue when having gangway use UAA which gave us quite large tokens.
When the securecookie is bigger then 4k (which seems to be the maximum cookie size on all major browsers) then the cookie is not stored. When /callback then redirects to /commandline the loginRequired middleware "fails" and redirects back to /, we never hit /commandline.
If we switch from the session store from CookieStore to FilesystemStore the whole flow seems to work and we end up hitting the commandlineHandler.
Things we could do to help here:

when the cookie is ~4k have gangway log a warning
make the session store configurable (let users switch between CookieSession and FilesystemSession and potentially others)

Same problem for me, message:
securecookie: the value is too long

Switched to Kuberos, working fine

Let me see if I can make this configurable @hoegaarden.

I somewhat clumsily solved this in #80 by creating multiple cookies and putting the tokens in their own.


Added GridContainer documentation

Thanks! It looks like your text editor removed all trailing spaces, which makes the diff a bit difficult to read (and likely hard to cherry-pick for the 2.0 branch). Could you rebase to add your changes without stripping trailing spaces?


Energycoin update to 1.5.1

https://bitcointalk.org/index.php?topic=1028941.msg14874949#msg14874949

will get an updated binary for the users and will get updated for the coming release.

Updated Energycoin Binaries to 1.5.1:
https://github.com/BitcoinFullnode/ROKOS-OK-Bitcoin-Fullnode/commit/9e5f84fd940464f768d43eab50ad7126c9b69d02
Instructions on how to update the ROKOS System with it over the tutorials section of this github.


No keyboard event data on web (Android).

Hello!
I have an app, which has a TextFormField as an input, and I'm trying to use it with an onSubmit callback. It works on desktop (the callback function is called), however, on Android, nothing happens after pressing the "Enter"/"Submit" button on the virtual keyboard.
I tried to use RawKeyListener, but on Android, the event data is always null/blank. This is shown on the screenshot I attached.
The issue is only present on Android web browsers, as far as I can tell. I tried it on stable, beta and master channels.
Casting the event data to RawKeyEventDataAndroid doesn't help either.
Steps to Reproduce
...
FocusNode keylistener = new FocusNode();
...
RawKeyboardListener (
   focusNode: keylistener,
   onKey: (event) {
      debugPrint(event.toString);
   }
)
...

Expected results: Prints data like keyId, keyLabel etc..
Actual results: The values of these variables are null.

Hi @mattee12
Can you please provide your flutter doctor -v  and a complete reproducible minimal code sample
Thank you

Sorry, I created this issue on my phone.
Doctor
[✓] Flutter (Channel master, 1.24.0-8.0.pre.374, on Linux, locale en_US.UTF-8)
    • Flutter version 1.24.0-8.0.pre.374 at /opt/flutter
    • Framework revision 183f0e797a (3 weeks ago), 2020-11-26 19:12:28 +0100
    • Engine revision 20caf54969
    • Dart version 2.12.0 (build 2.12.0-76.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /home/kolonics/Android/Sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /opt/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • CHROME_EXECUTABLE = /usr/bin/google-chrome-stable

[✓] Android Studio
    • Android Studio at /opt/android-studio
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] Connected device (2 available)
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome 87.0.4280.88

• No issues found!

Code
import 'package:flutter/material.dart';

void main() {
  runApp(
    MaterialApp(
      home: Main(),
    ),
  );
}

FocusNode keylistener = new FocusNode();
TextEditingController controller = new TextEditingController();

List<Widget> messages = new List<Widget>();

void printMsg(String val){
  messages.add(Text(val));
}

class Main extends StatefulWidget {
  @override
  MainState createState() => MainState();
}

class MainState extends State<Main> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: Center(
          child: ListView(
              children: messages +
                  [RawKeyboardListener(
                    focusNode: keylistener,
                    autofocus: true,
                    onKey: (event){
                      setState(() {
                        printMsg(event.toString());
                      });
                    },
                    child: TextFormField(
                      controller: controller,
                      onFieldSubmitted: (String val){
                      },
                    ),
                  )]
          )
      ),
    );
  }
}

I did some research and this is not a Flutter issue, it doesn't work even in plain JavaScript.
A simple 'onkeydown' callback returns the keyCode 13, and the key Unidentified.


Python ctx package

https://python-security.readthedocs.io/pypi-vuln/index-2022-05-24-ctx-domain-takeover.html
https://isc.sans.edu/forums/diary/ctx+Python+Library+Updated+with+Extra+Features/28678/
https://sockpuppets.medium.com/how-i-hacked-ctx-and-phpass-modules-656638c6ec5e

Resolved with 8305aa2


AngularJS Hash Bang Urls and Query Parameter ordering

According to AngularJS documentation, it states that a hash bang URL is in this format:
http://foo.com/#!/bar?baz=23

This indicates that the hash fragment is between the path and the query parameters of the URL. It's DOMAIN - HASH FRAGMENT - QUERY PARAMETER
However on Google AJAX Crawling Specification, when it converts a hash bang URL into the _escaped_fragment_ format for the purposes of indexing and then converts it back for search results, it instead places the hash fragment after the query parameter. (See the Search Results section)
http://foo.com/?baz=23#!/bar

This indicates DOMAIN - QUERY PARAMETER - HASH FRAGMENT.
It seems that both are a valid URL structure (try it on a browser with any non SPA application). However if you are using this URL format on any AngularJS site, the site correctly ascertains the path, however it "forgets" the query parameters.
So if you go to http://docs.angularjs.org?key=value#!/guide, it turns into http://docs.angularjs.org/guide. As you can see it forgets the query parameters. If I'm using the Google AJAX specification, then this would result in search results having URLs that don't work properly as their query parameters gets dropped.
I did some testing with both urls which has illuminated the problem:
Case 1: Using DOMAIN - HASH - QUERY PARAMETER (AngularJS format) (http://example.com/#!/path?key=value), the query parameters never gets received by the server, but it is remembered on the client side. It's also available in $location.search().
Case 2: Using DOMAIN - QUERY PARAMETER - HASH (Google's format) (http://example.com/?key=value#!/path), the query parameter gets received by the server (as it is not after the #), but it is forgotten on the client side. It's also not available in $location.search().
Perhaps a solution can be made for case 2. So that when there is query parameter and then hash fragment, AngularJS can correctly remember the query parameter and shift it to the end of the URL (if converting to HTML5 urls) and also make it accessible with $location.search(). Case 1 cannot be solved due to the URL standards as everything after the # is not sent to the server.

This is also breaking google analytics campaign tracking when linking to hashbang URLs.
Let's take a URL like domain.com/#!/path?utm_campaign=blah. If you go to this URL and print out window.location.search, there is nothing there.
If you use the DOMAIN QS HASH version like domain.com?utm_campaign=blah#!/path, the query string is in window.location.search. The problem is that DQS breaks the routin
This is also breaking google analytics campaign tracking when linking to hashbang URLs.
Let's take a URL like domain.com/#!/path?utm_campaign=blah. If you go to this URL and print out window.location.search, there is nothing there.
I'm assuming that google analytics is going to use whatever it finds in window.location.search for its campaign tracking.
If you use the DOMAIN QS HASH version like domain.com?utm_campaign=blah#!/path, the query string is in window.location.search. The problem is that DQS breaks the routing when in html5 mode.

Is there any update on this? I am having the same problem as what "timomall" has reported on 9 Dec 2014.

There are too different concepts here:

On one hand we have the query part of the URL (that comes before the hash fragment). This is also visible to the server (i.e. it is part of a request) and is not used by Angular for it's client-side routing (in the default hashbang mode).

On the other hand, the hash fragment (which is used by Angular for it's client-side routing) may contain a "query-like" part which typically is part of the hash fragment (and is ignored by the server). This is the part that Angular uses (and makes available under $location.search()).
As far as the browser is concerned, though, this is just part of the hash fragment and totally different (and independent) from the actual query part of the URL (if any).

In order to avoid confusing crawlers, one should probably encode that second "query-like" part of the hash fragment, when using an _escaped_fragment_ URL.
--
In any case, the Google AJAX Crawling Specification has been deprecated since October 2015.
Closing as I don't believe there is anything we can fix on the Angular side of things.

My problem is not with the crawler at all. My code was using the non-HTML5 mode and we have URLs given to external customers which are of the form https://abcd.efgh?utm_campaign=abcd#/abcd/12. Now, if I turn on HTML5 mode and the external customer tries to use the URL already with them, the URL changes in the browser to just https://abcd.efgh/abcd/12. The query parameter of utm_campaign is completely lost.
How can I get angularjs to preserve the query parameter so that the URL becomes https://abcd.efgh/abcd/12?utm_campaign=abcd when somebody tries to use the old URL?

@nmandya, I suspect it is a server cofiguration issue. But you can't really mix URL styles (hashbang and html5 mode) and have things work as expected, I'm afraid.
In https://abcd.efgh?utm_campaign=abcd#/abcd/12, Angular is only concerned with the part after #, namely /abcd/12. It sees it as:
$location.path()   === '/abcd/12'
$location.search() === {}
$location.hash()   === ''

The equivalent of the above in html5 mode is indeed https://abcd.efgh/abcd/12.
The "problem" is that in hashbang mode, there is the query part of the URL (before the #), which Angular is not concerned with and the query part of the client-side routing (after the #) which Angular "sees" and interacts with. In html5 mode there is only one query path.
So you can't really use the hashbang mode URLs in html5 mode (unless you do some server-side transformation maybe, converting ?utm_campaign=abcd#/abcd/12 to #/abcd/12?utm_campaign=abcd).

My problem is that IE10 auto-rewrites "https://host/#hash?search=..." to "https://host/?hash&search=..." so our Angular2 routing is all broken.

If it's a Angular2 issue, you should raise it on https://github.com/angular/angular.
Although it sounds more like a IE10 issue...

Hi there, hate to comment on a closed, old issue, but the fact is that the URI RFC (RFC3986) is pretty clear that the fragment identifier comes after the query string.  The way the non-html5 mode of Angular's location service works is to lose the query portion of the URL if it appears prior to the fragment.  I have a small patch to the location service that fixes this issue.  I'm in the process of submitting a pull request for it. Hopefully it will help someone.

Why AngularJS supports hashbang ? Can it be solved in future ? It just does not work with server side php ,especially post methods .

For support questions, please, use one of the appropriate support channels.
Thx!


[UIE-78] add eslint and prettier

Adds airBnB styles, prettier and properly functioning stylechecks. More info here: https://docs.google.com/document/d/1Pi11vy_sjJXahG5o-qHfec3mEQd0q7F2jJqaApV1Bvw/edit#

Our plan for getting this out is to take the following steps in order:

Merge/rebase onto latest dev revision
run lint command, fix any errors manually, commit
add the previous commit hash from step 2 to the .git-blame-ignore-revs file and commit
Push up and at that point CI should be passing and we can merge

Our plan for getting this out is to take the following steps in order:

Merge/rebase onto latest dev revision
run lint command, fix any errors manually, commit
add the previous commit hash from step 2 to the .git-blame-ignore-revs file and commit
Push up and at that point CI should be passing and we can merge

Since this repo uses squash and merge on PRs, you'll have to do that in two separate PRs. The commit has to ignore won't be known until after the PR is merged and a commit on the dev branch is created.

moved to https://github.com/DataBiosphere/terra-ui/pull/3902


Share Extension does nothing on iOS

I followed the steps exactly as given on the pub page, and the Share Extension for iOS used to work perfectly before, and now, without changing anything, it no longer works.
Tapping on the app icon in the share sheet makes the screen go darker as if the modal sheet is about to show, and then just fades back away and nothing happens. This issue is persisting on all iOS/iPadOS devices I've tried with. Works as expected on Android, though.
Here's a screen recording of what's happening: https://www.icloud.com/iclouddrive/0c4noRvFmGRz4H7bJwBP9xI-w
Anyone know a fix?

Fixed it by following the steps on the README.md on this repo. The pub package is outdated, needs an update.

@pixelsnis  I am facing the same issue, can you tell me what was exactly the problem and how you fixed it.


feature: Custom import file validation

Description
This is a feature addition for cases where you want to customize the validation of import files by adding a custom validation method.

Visual changes

Functional changes

[ ] Code style has been fixed by running the composer cs command.
[ ] Changes have been tested to not break existing functionality.
[x] Documentation is up-to-date.

Hi, thanks for your contribution. However, this API doesn't really work in a similar way to any of our other APIs, we don't often require users to extend classes to configure them like this. I would suggest you contribute a new method ->fileRules() to the existing action class, which users can call and pass through new rules. Then you can store these in a property on the action, and then call a getter method for that property when defining the form to merge the rules in. We would accept a new PR using this approach :)


Astro.props entry in the API Reference page

Discussed in https://github.com/withastro/docs/discussions/630

Originally posted by @ekafyi May 23, 2022
Would it be a good idea to add an entry for Astro.props in https://docs.astro.build/en/reference/api-reference ?
While it has been briefly addressed in https://docs.astro.build/en/reference/api-reference/#data-passing-with-props, people may not know that eg. Astro.props contain the HTML element tag property, which can be used to render an element polymorphically, as discussed in https://discord.com/channels/830184174198718474/830184175176122389/977974602431086632

Originally posted by @delucis May 23, 2022
Great idea! We should definitely include Astro.props on that page.
About dynamic tag rendering: there's nothing “special” about a tag prop so I'm not sure this would go there. You could name your prop is or as for example and it would also work. All that needs to happen is for you to use a variable that is a string, so that could come from a prop or something else:
---
const El = 'div'
---
<El>Hello!</El>

Originally posted by @sarah11918 May 23, 2022
This does seem like a huge ommision, since it's something EVERYBODY uses! Great call, @ekafyi !
I think this rises to the level of "Issue", if you'd like to make one so it gets on the task list.

Just updating: I have asked in core-docs channel whether someone is willing to provide some content for this.

v1 triage call notes:

We should definitely add Astro.props to the API Reference!

Splitting out the dynamic tag name technique to a separate issue: #1180 (lower priority)

Just chatted with @bholmesdev about this and how to balance it with the MDX tasks remaining for v1.0. Any chance that @sarah11918 or @delucis could do the work to create the basic Astro.props reference section using the content that already exists here: https://docs.astro.build/en/core-concepts/astro-components/#component-props
And then Ben could come in to fill in any info still missing?

Closing this, as done. PRs welcome if it needs to change!


Update docker and cri-o to include the sirupsen fix.

Update docker to https://github.com/moby/moby/commit/cc4da8112814cdbb00dbf23370f9ed764383de1f.
Update cri-o to https://github.com/kubernetes-incubator/cri-o/commit/63a218a45844fd912f482dc85f9cc149e68e0e57.
Fixes https://github.com/kubernetes-incubator/cri-containerd/issues/106.
Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

LGTM


Test transaction writing exceptions and errors

Closed because this is already done in tests/test_parsers/test_parsing_errors.py


[Bug]: Compile Errors

Version
System:
OS: macOS 15.0
CPU: (8) arm64 Apple M1 Pro
Memory: 555.02 MB / 16.00 GB
Shell: 5.9 - /bin/zsh
Browsers:
Chrome: 130.0.6723.70
Safari: 18.0
npmPackages:
@rsbuild/core: ^1.0.1-beta.6 => 1.0.18
@rsbuild/plugin-sass: ^1.0.1-beta.6 => 1.0.4
@rsbuild/plugin-vue2: ^1.0.1-beta.6 => 1.0.1
Details
Very strange problem, after migration, at least dozens of files cannot be compiled, I don't know where the problem lies

The configuration of rsbuild.config.mjs is as follows

Reproduce link
https://gitee.com/An_ordinary_day/rspack.git
Reproduce Steps
run cnpm i && cnpm dev

The Rsbuild Vue 2 plugin only supports Vue >= 2.7.0, Please upgrade to Vue 2.7 and try again. see https://github.com/web-infra-dev/rspack/issues/6768

The Rsbuild Vue 2 plugin only supports Vue >= 2.7.0, Please upgrade to Vue 2.7 and try again. see web-infra-dev/rspack#6768

Thanks, solved it


Is direct graph management possible?

Hello,
Thanks a lot for bringing the Gremlin power to JS, incredible work! :) I guess that I have more a question than an issue.
Is it possible to perform management operations on the graph, like adding property fields or indices? I saw that it's possible to make use of conventional Gremlin object names (as g and graph); the conventional name for management object in gremlin console is 'mgmt', but
const uuid = await gremlinmgmt.makePropertyKey('uuid').dataType(UUID.class).cardinality(Cardinality.SINGLE).make();
returns "No such property: mgmt for class: Script5 (Error 597)".
Do I miss something obvious, or it's just not available at the moment?
(Using JanusGraph 0.2.0-hadoop2 with janusgraph-cassandra-es default config)
Thank you once again :)

Hello, thanks for the kind words!
Unless you're using session mode and already instantiated the management instance before, I think you need to instantiate the management instance in the same query. This should help:
const uuid = await gremlin`
  mgmt = graph.openManagement();
  mgmt.makePropertyKey('uuid').dataType(UUID.class).cardinality(Cardinality.SINGLE).make();
`;

Hopefully this helps. Note: I slightly edited your code snippet for formatting reasons.


functional tests: set gcc version to 4.8

An updated to Semaphore's platform caused the default version to be 4.6,
which broke the systemd build.

:/ lgtm

Gosh, it seems I can't type today (updated -> update)


Single file when getting T_hist without any tracking

Generates a single file when getting T_hist without any tracking

related to #16

Something is wrong with the final output file. While simulation is running, the output looks as would be expected (i.e., unique x,. y, z, and T values for each row), however, just before the simulation finishes, the output file gets updated with something like this:
x,y,z,0.003536,0.007071
-0.001,-0.001,-0.001,1273.000000,1273.000001
-0.001,-0.001,-0.0005,1273.000000,1273.000055
-0.001,-0.001,0,1273.000000,1273.000246
-0.001,-0.0005,-0.001,1273.000000,1273.000070
-0.001,-0.0005,-0.0005,1273.000001,1273.006309
...
# looks normal for a few hundred points
...
0.0025,0.006,-0.001,1273.000000,1273.000000
0.0025,0.006,-0.0005,1273.000000,1273.000000
0.0025,0.006,0,1273.000000,1273.000000
-0.001,-0.001,-0.001,1273.000000,1273.000001
-0.001,-0.001,-0.001,1273.000000,1273.000001
-0.001,-0.001,-0.001,1273.000000,1273.000001
-0.001,-0.001,-0.001,1273.000000,1273.000001
-0.001,-0.001,-0.001,1273.000000,1273.000001
...
# every row is identical until the end of file, except for the couple rows below
...
-0.001,-0.001,-0.001,10.003,-0.0,1273.000001
...
-0.001,-0.001,-0.001,1273.00,-0.001,1273.000
...

Last commit fixes the file name for output, but still having issue with each rank writing values for all global points instead of local points.


Feature Request: t3-env CLI

t3-env is great for managing environment variables.
However, there's a gap when it comes to command-line operations like drizzle-kit db:push.
Currently, we use dotenv-cli to load environment variables:
$ dotenv -- drizzle-kit push:mysql

This method lacks a safety check for the loaded variables.
If we created a CLI for t3-env, it could safely load, transform, and verify these variables:
$ t3-env -- drizzle-kit push:mysql
# Loads and transforms environment variables
# Throw errors if there's an issue
# If no issues, execute the command

Can i implement it in rust?

Can i implement it in rust?

I don't have much experience with Rust, might be a bit overkill for simple feature like this, but I guess so? @juliusmarminge

Well, we could create this with typescript too.

Yeah, TS would be better, CI is a lot easy to setup.

Can you setup the environment to me? I wanna work it :D

@juliusmarminge, how can I send the project to you?

You make a PR

@moliveiraz are you working on this? If not, I could take it :)


Comparision with Google Jax & Nvidia Apex

Could BMTrain use together with the tools like Jax or Apex, or any comparisions or experiments plan with these tools? Thanks

No, BMTrain currently only supports pytorch. The compatibility of BMTrain with apex has not been tested yet.


pull request for e2e test at 01/04/2017 05:26:17

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Psychrometric chart #1

Add option to have all points NOT colored by a varaible (just orange) and make it the default

time and data filter should not be applied on loading
(currently on loading "apply time filters" is checked)

-hour range default should be 1 to 24
(currently on loading is 6 to 20)

Add option to have all points NOT colored by a varaible (just orange) and make it the default

@giobetti are these two issues? I have implemented the one in which the chart is colored by None in efa39b03167aa2d1dd91c62d63424a7ff73f759c.
Please close this issue and open a new one for the other issue.


2.4.2 seems to not load config_file

I downloaded via wget the most recent release and tried to run it with a provided config_file which results in an error message that max_size isn't set.
finally I tried version 2.4.1 and bazel-remote starts as expected.
Ubuntu 22.04 lts amd64

Thanks for reporting this- I landed a fix (#694) and will rush out another release. I will follow up with a test to avoid breaking this again when I have a bit more time.

Please try 2.4.3 ...


Easy way to configure padding around elements?

Hi,
Excellent theme!
However, I was wondering if there is an easy way (without editing scss files) to configure the padding around elements.

There is not. This is something purely done via CSS.

Okay, so there are no helper classes that can be used here. Does this seem like a good idea for a future release? In my opinion helper classes (like the existing classes: wide) can greatly simplify certain common customization like padding and font configuration without having the user to touch any CSS.


It is impossible to accurately set multimesh custom data in compatibility renderer

Tested versions
Godot v4.4.dev unknown - Windows 10.0.19045 - GLES3 (Compatibility) - NVIDIA GeForce RTX 4050 Laptop GPU (NVIDIA; <IP_ADDRESS>70) - 13th Gen Intel(R) Core(TM) i5-13500HX (20 Threads)
(this is 4.4-dev1 compiled with debug symbols)
System information
Godot v4.4.dev unknown - Windows 10.0.19045 - GLES3 (Compatibility) - NVIDIA GeForce RTX 4050 Laptop GPU (NVIDIA; <IP_ADDRESS>70) - 13th Gen Intel(R) Core(TM) i5-13500HX (20 Threads)
Issue description
Multimesh's custom data allows you to store custom data to customize multimesh instances.
In the vulkan renderers, you get:

4 32-bit floats in a Color variant
Easily stored in a PackedFloat32Array, it is simply [r, g, b, a]
Allows up to 128 bits of custom data

In compatibility, you get:

4 16-bit floats in a Color variant
Allows up to 64 bits of custom data

I tried to examine buffer myself to see how they were stored, but couldn't figure it out, so I went into the source code to try and figure it out.
Via godot/drivers/gles3/storage/mesh_storage.cpp:
void MeshStorage::_multimesh_instance_set_custom_data(RID p_multimesh, int p_index, const Color &p_color) {
	MultiMesh *multimesh = multimesh_owner.get_or_null(p_multimesh);
	ERR_FAIL_NULL(multimesh);
	ERR_FAIL_INDEX(p_index, multimesh->instances);
	ERR_FAIL_COND(!multimesh->uses_custom_data);

	_multimesh_make_local(multimesh);

	{
		float *w = multimesh->data_cache.ptrw();

		float *dataptr = w + p_index * multimesh->stride_cache + multimesh->custom_data_offset_cache;
		uint16_t val[4] = { Math::make_half_float(p_color.r), Math::make_half_float(p_color.g), Math::make_half_float(p_color.b), Math::make_half_float(p_color.a) };
		memcpy(dataptr, val, 2 * 4);
	}

	_multimesh_mark_dirty(multimesh, p_index, false);
}

It seems simple enough. Four 16-bit floats are laid out consecutively in memory, which can then be copied directly into the buffer.
The multimesh buffer (atleast from what is exposed), uses a PackedFloat32Array.
When custom data is enabled, it allocates four indexes per custom data.
In compatibility, it should only use the first two out of the four indexes, while in Vulkan, it should use them all.
But that is where the issue lies - there is no way for us to directly modify the bits like we can in the Forward+ renderer.
We don't have access to the uint16 array of data, all data have stuff happen to it before we can input any raw data.
Steps to reproduce

Use custom data in the MultiMesh custom data that relies on bit-specific values, which is very useful in my project as I can combine up to 64 bits/ 8 bytes of custom data into one single multimesh instance.
Notice that when used in Compatibility, unlike the Forward+ renderer this data gets messed up due to the conversions to 16-bit floating point numbers

Minimal reproduction project (MRP)
I've set up two different example projects. The instance shown here is four cubes in one single mesh
Project 1: Forward+ Renderer
In this example, everything works exactly as it should, as it doesn't have any 16-bit-float bit-packing to do like in the Compatibility renderer.

It effectively and easily allows the packing of 4 different colors into one MultiMesh custom data. This project serves as a functional example of what I am trying to do.
MultimeshBitsForward.zip
Project 2: Compatibility Renderer
Similar to the one above, but it only uses two colors.

No matter the input data, the data gets malformed and lost.
MultimeshBitsCompatibility.zip

try this
https://bit.ly/4e4zLlq
select the desired compiler in the installer

try this ////// select the desired compiler in the installer

Can you not? this has nothing to do with godot and is probably a scam

Probably can't write directly to the buffer, try modifying a local vector then submit the whole thing to the multimesh
var data := multimesh.buffer
data[12] = packed_colors[0]
data[13] = packed_colors[1]
multimesh.buffer = data

Probably can't write directly to the buffer, try modifying a local vector then submit the whole thing to the multimesh
var data := multimesh.buffer
data[12] = packed_colors[0]
data[13] = packed_colors[1]
multimesh.buffer = data

I thought this too when testing, but it doesnt seem to actually be the case:

Okay, here's what's going on.
transform3d:float32[12]
color:float32[4]
custom:float32[4]

The buffer stores the instance data as float32 regardless of the actual driver. So forward+ or compatible, the data is the same.
But in the case of the gles3 driver, when uploading to the GPU, it copies the buffer, compressing the color and custom components as float16.
https://github.com/godotengine/godot/blob/8120e0324a48190f58616378746d517e4ad40965/drivers/gles3/storage/mesh_storage.cpp#L1927-L1932
Bad ending
The design has been chosen as an abstraction layer, and it's unlikely the rendering team will support a change to bypass that abstraction. This technically leaves only 11 bits of lossless data, integer range of [-2048, 2047] per rgba component for gles3 driver.
Now what?
Depends on what you wanted to use the data for. I'll be happy to help find workarounds.

If it's just the rendering server then I reckon that might be accepted, something like multimesh_set_buffer_raw(RID, PackedByteArray). Please open a proposal if you wish to see this go further.
The block scale, can that be read from the transform matrix itself? (assuming they're axis aligned of course)

The limitation is that we ran out of vertex attributes in the compatibility renderer. Many OpenGL implementations are limited to 16 attributes. Our options were to:

Allow full floating point color and disable custom, or
Pack color and custom using 16 bit floats.

We chose the latter.
To be honest though, doing bit packing and unpacking hackery was never part of our intended use-case for custom. It has always been seen as a way to provide custom floating point data to the shader. You are using the system for something it was never intended to deal with. That isn't wrong per se, but ultimately, you are suggesting that we change an existing system to accommodate something it was never designed to do.

If it's just the rendering server then I reckon that might be accepted, something like multimesh_set_buffer_raw(RID, PackedByteArray). Please open a proposal if you wish to see this go further.
The block scale, can that be read from the transform matrix itself? (assuming they're axis aligned of course)

Great point on my specific usecase, using MODEL_MATRIX in my shader instead of passing it, thank you, i'll look into it

The limitation is that we ran out of vertex attributes in the compatibility renderer. Many OpenGL implementations are limited to 16 attributes. Our options were to:
1. Allow full floating point color and disable custom, or

2. Pack color and custom using 16 bit floats.

We chose the latter.
To be honest though, doing bit packing and unpacking hackery was never part of our intended use-case for custom. It has always been seen as a way to provide custom floating point data to the shader. You are using the system for something it was never intended to deal with. That isn't wrong per se, but ultimately, you are suggesting that we change an existing system to accommodate something it was never designed to do.

Understood. Would some sort of function to set the buffer raw like huwpascoe suggested for the RenderingServer be considered if I submitted it as a proposal? Or is the whole concept something that never would be added?

Understood. Would some sort of function to set the buffer raw like huwpascoe suggested for the RenderingServer be considered if I submitted it as a proposal? Or is the whole concept something that never would be added?

I think that a raw byte buffer could be doable!

Understood. Would some sort of function to set the buffer raw like huwpascoe suggested for the RenderingServer be considered if I submitted it as a proposal? Or is the whole concept something that never would be added?

I think that a raw byte buffer could be doable!

I'll go ahead and close this now, I made a new proposal issue:
https://github.com/godotengine/godot-proposals/issues/10650


Task 65/cmake packaging

Renamed UnicornEngine to UnicornRenderer
Configured CMake for packaging library, headers, data and dependencies
Added version information to library
Fixed some errors in code in order to build and link UnicornRenderer library

Approve


'dmlc-core/libdmlc.a' failed when complie xgboost

I make the latest xgboost for anaconda python 2.7 in windows 10 and met the following error messages:
/usr/bin/sh: -c: line 0: syntax error near unexpected token (' /usr/bin/sh: -c: line 0: cd dmlc-core; C:/Program Files (x86)/mingw64/bin/make libdmlc.a config=C:/xgboost/config.mk; cd C:/xgboost'
Makefile:101: recipe for target 'dmlc-core/libdmlc.a' failed
make: *** [dmlc-core/libdmlc.a] Error 1
make: *** Waiting for unfinished jobs....
I once make xgboost successful. This time I want to update the latest xgboost so I used the same steps while I met the errors. I have try other ways to and still not solve it. The attached file is the full error message.
errors.txt

I am the same error with you

same here, on amzn1.x86_64

Such issue was fixed recently #2619
@PINGYANG-PY you seem to have have Amazon linux, not windows, so it cannot really be the same issue. Use the latest source, and raise an issue if problem persists and you cannot find a solution.


Allow webhooks to be created even if the service is not answering with 20X

Currently you have to have a webhook service up and running in order to create the actual webhook on the Flagsmith side. We should change this to allow users to create the webhook, but warn them on creation that the service is currently not reachable on their side.

hello @dabeeeenster could you please expand on this. I'll love to work on this

Thanks @haszankauna ! I'm actually not sure if this is something that needs API work too or can be achieved purely from the front end javascript - maybe either @kyle-ssg or @matthewelwell can provide additional input here?

Hello @kyle-ssg Could you please provide some input o this?

If I'm not mistaken, the only reason why the screenshot in the issue description throws an error is because it's an invalid URL syntactically. The error is coming back from the API.
If I were to try this with a valid URL that doesn't exist I believe this works fine unless I'm missing something?

Hello @dabeeeenster could you please look to this?

Hi @haszankauna thanks for the interest here. As @kyle-ssg mentioned, there is actually no issue here. I am closing this issue based on that.

Hmm - so its validating the actual DNS name, so things like this https://null/213123 are not allowed. But there might be setups/networks where that domain resolves. So I think the UI is being over-eager here?

what will you suggest @dabeeeenster
cc: @matthewelwell

Trying the above out I can see that the FE attempts no form of validation before sending the request and the error comes back from the API(attached). If we have to adjust any URL validation then a change would have to be made on the API.


Add option to prune files when indexing

Fixes #183
I need to add tests before merging.

Tests added and passing @angus-g
Can you take a look?
One other question, should pruning be on by default? I haven't done so, but could easily do it. I can't imagine a scenario where I would want a file that doesn't exist on disk to remain in the DB, but maybe my imagination is a bit limited.

Looks fine to me. I don't see a problem with pruning by default, especially if that makes more sense to you as somebody who'd actually be doing the indexing. I agree that any situation where you wouldn't want to either doesn't exist, or is very contrived!

Ok. I'll change to default.

Hmmm ... maybe I won't
============================================ short test summary info ============================================
FAILED test/test_indexing.py::test_broken - KeyError: 'output000/test.nc'
FAILED test/test_indexing.py::test_empty_file - KeyError: 'output000/empty.nc'
FAILED test/test_indexing.py::test_update_nonew - KeyError: 'output000/test.nc'
FAILED test/test_indexing.py::test_reindex_noupdate - KeyError: 'output000/test.nc'
FAILED test/test_indexing.py::test_update_newfile - KeyError: 'test1.nc'
FAILED test/test_indexing.py::test_single_broken - KeyError: 'output000/test.nc'
FAILED test/test_indexing.py::test_longnames - KeyError: 'output000/test2.nc'
FAILED test/test_indexing.py::test_multiple_experiments - KeyError: 'test1.nc'
FAILED test/test_indexing.py::test_same_expt_name - KeyError: 'test1.nc'
FAILED test/test_indexing.py::test_metadata - KeyError: 'test1.nc'
FAILED test/test_indexing.py::test_broken_metadata - KeyError: 'test1.nc'
FAILED test/test_indexing.py::test_distributed - KeyError: 'output000/test.nc'
FAILED test/test_indexing.py::test_prune_broken - KeyError: 'output000/test.nc'
FAILED test/test_indexing.py::test_prune_nodelete - KeyError: 'test1.nc'
FAILED test/test_indexing.py::test_prune_delete - KeyError: 'test1.nc'
FAILED test/test_indexing.py::test_index_with_prune_nodelete - KeyError: 'test1.nc'
FAILED test/test_indexing.py::test_index_with_prune_delete - KeyError: 'test1.nc'
ERROR test/test_querying.py::test_valid_query - KeyError: 'output000/ocean.nc'
ERROR test/test_querying.py::test_invalid_query - KeyError: 'output000/ocean.nc'
ERROR test/test_querying.py::test_warning_on_ambiguous - KeyError: 'output000/ocean.nc'
ERROR test/test_querying.py::test_query_times - KeyError: 'output000/ocean.nc'
ERROR test/test_querying.py::test_chunk_parsing_chunked - KeyError: 'output000/ocean.nc'
ERROR test/test_querying.py::test_chunk_parsing_contiguous - KeyError: 'output000/ocean.nc'
ERROR test/test_querying.py::test_chunk_parsing_unchunked - KeyError: 'output000/ocean.nc'
ERROR test/test_querying.py::test_get_experiments - KeyError: 'output000/ocean.nc'
ERROR test/test_querying.py::test_get_ncfiles - KeyError: 'output000/ocean.nc'
ERROR test/test_querying.py::test_get_variables - KeyError: 'output000/ocean.nc'
ERROR test/test_querying.py::test_get_frequencies - KeyError: 'output000/ocean.nc'
============================= 17 failed, 8 passed, 30 warnings, 11 errors in 16.92s =============================

Not sure I can be bothered figuring out all the logic of what and what should not be missing

@angus-g I have incorporated all the file filtering logic into a single block. Can you confirm that iterating over expt.ncfiles and comparing to the found file paths is functionally equivalent to the query you had before?

Cool! Happy to merge if you're happy?


TypeError: {} is not a function

I am... Reporting a bug or issue
Expected behavior:
Should build
Observed behavior:
TypeError: {} is not a function. (In '{}("")', '{}' is an instance of Object)
How to reproduce:
Using package versions
"prop-types": "^15.5.8",
"react": "^15.4.2",
"react-dom": "15.4.2",
"react-sketchapp": "^1.0.0",
"react-test-renderer": "15.4.2",
"webpack-shell-plugin": "^0.5.0"

Build this
class Document extends React.Component {
  render() {
    <Artboard name="Test">
      <View>
         <Text>Sign up</Text>
      </View>
    </Artboard>
  }
}

const onRun = () => {
  render(<Document />, context.document.currentPage());
};

module.exports = onRun;

Sketch version:
48.2
Please attach screenshots, a zip file of your project, and/or a link to your github project

@mathieudutour I'm running into the same issues every now and then but couldn't track down the original cause. I'm using a monorepo with yarn workspaces enabled as well, just as @joevbruno . But re-yarn doesn't work everytime. Any clue what where I can start investigating?

I'm not using yarn and I'm thinking it's an issue with yarn

@weaintplastic just to clarify, I'm not using yarn workspaces - I am using yarn and lerna.

@joevbruno oh alright, sorry. I was assuming you use yarn workspaces.
@mathieudutour Thanks so much for the fast reply. I'll continue to investigate. I'll keep you guys posted if I should come to any result.

yeah but it's probably yarn messing up the node_modules. When you do a skpm create, it will run npm install so if you run yarn on top of it, it will probably break things. Happy to accept a PR to skpm to support yarn

actually I just use the @skpm/builder and didn't even use the skpm create back then (but was using the template).

It might be some environment thing and webpack. When it breaks index.js declares nodeFs like this
var nodeFs = {}("");

when it is working the declaration is
var nodeFs = {};

I've also been getting this error. Unfortunately, I have not been able to simply remove and replace node_modules to get it working.
I'm using yarn workspaces (w/o lerna). If I only install packages for react-sketchapp/examples/basic-setup-typescript under a single workspace (e.g. packages/a), it works fine. But, if I install any packages under another workspace (e.g., packages/b), it will fail.
However, I have pinpointed the issue. When i install packages from a new workspace, some code changes in node_modules/yoga-layout/build/Release/nbind.js. var nodeFS = {} becomes var nodeFS = {}("").
So, it seems like the problem must be between yoga-layout and yarn workspaces.

Seems like the latest javascript build v1.8.0 fixed this issue: https://github.com/facebook/yoga/issues/642#event-1396878128. So, it should just be an issue of react-sketchapp updating yoga-layout to 1.8.0, ... which it seems has already been done, just not in an official release 😔

Will this get fixed when new release of react-sketchapp is out?

Yes

On 14 Mar 2018, at 04:25, Phạm Dương Nhật Nam<EMAIL_ADDRESS>wrote:
Will this get fixed when new release of react-sketchapp is out?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Remove lock for Anthropic tokenizer

Fixes #1570.
The Anthropic tokenizer was previously thread hostile. The Anthropic library has been updated to a version that has a thread-safe tokenizer, so we can remove the lock now.

Apparently the lock is still necessary, possibly due to the Hugging Face wrapper that we use.


How to configure hooks.json with two hooks

I am trying to define 2 hooks in the hooks.json file.
What is the correct syntax for this? I can't get it to work and the examples don't mention two hook id's in a single file.
I am trying to do something like this in my hooks.json file:
[
  {
    "id": "webhook",
    "execute-command": "/var/scripts/webhook.sh",
    "command-working-directory": "/var/webhook",
  }
 {
    "id": "webhook2",
    "execute-command": "/var/scripts/webhook2.sh",
    "command-working-directory": "/var/webhook"
  }
]

You are missing a comma , in between the objects [ {...}, {...} ] :-)

Could have known it! Anyways, thank you very much! It solved my issues :-)
This webhook utility is great!

You're welcome :-) Glad you found it useful!


Project was not running due to misdetection in ProcessRunner GetExePath - empty netcoreapp folders

Describe the bug
I followed the tutorial and added several projects to my solution. All services were picked up correctly, started and showing up in the dashboard. One project seemed to run into an error though.

The logging of the service in question looked like this:
[<redacted>_cd5160ac-a]:dotnet "C:\Users\bkons\source\repos\<redacted>\<redacted>\bin\Debug\netcoreapp2.2\<redacted>.dll"
The folder it is trying to run from has no files inside of it, which will lead to a failing dotnet command.
I had a look at the source and saw that you only take the first netcoreapp folder you can find, and assume that this is ok, but for one project it was not.
I have a working fix which involves iterating over all tmfs. Tests are still working and the service is running afterwards. I don't know whether this solution is good, but I would like to contribute.
Feel free to have a look at it
https://github.com/btastic/tye/commit/0b1d86146f39b31c93d4b8dcab3dedcaacffe481
To Reproduce
Create an empty netcoreapp2.1 and netcoreapp2.2 folder in bin\debug and a valid netcoreapp3.1 or netcoreapp3.0 folder in bin\debug. The current code will take the first tfms regardless of a valid / found executable and return it.
Further technical details
tye version from master at commit 8b81b3d4
platform is windows 10

That's a fine solution until we have msbuild more deeply integrated into run scenarios.

This is fixed with https://github.com/dotnet/tye/pull/188


Add graphics from presentation to git

Add the graphics from the presentation to git
Issue fix: #301

Fair point, adjusted it :)


Al0604 codecop rule Implict With with a Testfield

Describe the bug
Using v7.0.372460 and a Testfield rule AL0604 has some unexpected behavior.
To Reproduce
On a record add Rec.Testfield("Field name");
Expected behavior
This should be allowable with rule AL0604 as no explicit with is implied however this still gives a AL0604 error, to remove the error you have to use Rec.Testfield(Rec."Field Name"); This is inconsistent with other syntax relating to a record.

Yeah, that just seems wrong.


Not NULL terminated buffer

From the snippet below, if the hooked function does not properly calculate the input length, there will be some memory leak.
    } else if (modsecReadResponse != NULL) {
        unsigned int readcnt = 0;
        int is_eos = 0;
        char buf[8192];
        while(!is_eos)  {
            modsecReadResponse(r, buf, 8192, &readcnt, &is_eos); <-- here

            if(readcnt > 0) {
                char *tmp = (char *)apr_palloc(r->pool, readcnt);
                memcpy(tmp, buf, readcnt);
                e = apr_bucket_pool_create(tmp, readcnt, r->pool, r->connection->bucket_alloc);
                APR_BRIGADE_INSERT_TAIL(bb_in, e);
            }
        }

@fakhrizulkifli
Thanks for your contribution :)
Any particular reason why the issue was closed prior to discussion / analysis from the community?


fix(deps): update module github.com/vektah/gqlparser/v2 to v2.5.19

This PR contains the following updates:

Package
Type
Update
Change

github.com/vektah/gqlparser/v2
require
patch
v2.5.17 -> v2.5.19

Release Notes

vektah/gqlparser (github.com/vektah/gqlparser/v2)
v2.5.19
Compare Source
What's Changed

When format a doc without description, don't add new line between args by @fredzqm in https://github.com/vektah/gqlparser/pull/327
feat(gqlerror): optimize Error method perfomance by @dienvt in https://github.com/vektah/gqlparser/pull/328
Bump the actions-deps group in /validator/imported with 7 updates by @dependabot in https://github.com/vektah/gqlparser/pull/329
Update yaml.v2 to yaml.v3 by @StevenACoffman in https://github.com/vektah/gqlparser/pull/331

New Contributors

@dienvt made their first contribution in https://github.com/vektah/gqlparser/pull/328

Full Changelog: https://github.com/vektah/gqlparser/compare/v2.5.18...v2.5.19
v2.5.18
Compare Source
What's Changed

[SECURITY PROBLEM] Implement a configuration option to disable the suggestion feature when a GraphQL query fails by @tomoikey in https://github.com/vektah/gqlparser/pull/319
Bump @babel/cli from 7.24.8 to 7.25.6 in /validator/imported in the actions-deps group by @dependabot in https://github.com/vektah/gqlparser/pull/315
Bump the actions-deps group in /validator/imported with 6 updates by @dependabot in https://github.com/vektah/gqlparser/pull/323
Bump golangci/golangci-lint-action from 6.1.0 to 6.1.1 in the actions-deps group by @dependabot in https://github.com/vektah/gqlparser/pull/322
Add exported function to remove rules by @ldebruijn in https://github.com/vektah/gqlparser/pull/316
Bump the actions-deps group in /validator/imported with 2 updates by @dependabot in https://github.com/vektah/gqlparser/pull/324
Add an option to format GQL without description by @fredzqm in https://github.com/vektah/gqlparser/pull/325
Update to go v1.21 by @StevenACoffman in https://github.com/vektah/gqlparser/pull/326

New Contributors

@tomoikey made their first contribution in https://github.com/vektah/gqlparser/pull/319
@ldebruijn made their first contribution in https://github.com/vektah/gqlparser/pull/316

Full Changelog: https://github.com/vektah/gqlparser/compare/v2.5.17...v2.5.18

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

⚠ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

any of the package files in this branch needs updating, or
the branch becomes conflicted, or
you click the rebase/retry checkbox if found above, or
you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:
File name: dagger/go.sum
Command failed: go get -d -t ./...
go: -d flag is deprecated. -d=true is a no-op
go: dagger/navecd imports
	dagger/navecd/internal/dagger: package dagger/navecd/internal/dagger is not in std (/usr/local/go/src/dagger/navecd/internal/dagger)


Double Chests

The cooking table can't see both inventories of a double chest, just the one whose side it's adjacent to.

This will be fixed by the new multiblock kitchen system (#43) coming in the next version.

The multiblock kitchen in version 1.0.92+ now uses the Fridge for item storage, so this is no longer.


Any plans for a Vanilla JS version of this script?

Hi @tabalinas ,
Joomla is for future versions 'migrating' their built in jquery scripts to Vanilla JS. There is some logical reasoning behind that (speed among other things). Now that I know that, I see / hear / read more developers are making that 'switch', before I didn't pay any attention I think.
Do you by any chance have any plans to also create a Vanilla JS version of jssocials?

Yes, this makes sense.

@tabalinas any news?


Making label field required in BottomNavigationBarItem

Description
In this PR, I have made the field label required for BottomNavigationBarItem. Having not given this field, it gives failed assertion error, so making field required to prevent this.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[x] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[x] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

Thank you @HansMuller for requesting a review :)


Updated Ukrainian translation

Also hanged locale name to be "ua"

Previous translation had a lot of errors and looked like a translation from Russian

Also, why are some things non-translatable?
For example "Cannot add a word when no language is selected." is marked as non-translatable

Sure, will do

Do you want me rebasing to version-28 and putting new translation in the \app\src\main\res\values-ua\ ?

Do you want me rebasing to version-28 and putting new translation in the \app\src\main\res\values-ua\ ?

Yes, this is the correct path now.

@WallK, I am not sure if you want to continue working in this PR or open a new one, but whatever you choose, could you also change the "" key to "Key Repeat Protection" or "Accidental Key Repeat Protection", whatever sounds better in Ukrainian? I will change it in all other languages.
Sorry for the last minute change, but I think this is a bit more clear than "Multi-press protection".

Rebase closed the PR automatically (???)
I already translated something along the lines of "Accidental Key Repeat Protection" because "Multi-press protection" didn't make a nice sentence in Ukrainian, glad we thought alike

Ok, I was to hasty and the real language code is "uk", sorry
I guess you should rename the folder back...


Add CI for native windows support

See original issue on GitLab
In GitLab by [Gitlab user @jonathanmaw] on Oct 8, 2019, 14:11
Background
NOTE: This is based on the assumption that win32 refers to the windows API, not running on a 32-bit Windows system, as there is some ambiguity.
There is an ongoing effort (#1021) to add native windows support to buildstream, and a need to ensure that this support doesn't bit rot, or at least where functionality breaks it is known exactly when this happens.
The proposed solution is to set up a CI runner and CI jobs to exercise the currently-implemented functionality.
Work has apparently been made to support:

bst init
bst help
bst workspace list (possibly)

And there are currently experimental branches to allow bst build for import elements.
Task description

[x] Manually set up a Windows system to run CI jobs in native Windows

[x] Install Python and Pip
[x] Install BuildStream's pip dependencies
[x] Install a native windows gitlab runner

[x] Produce automated instructions to spin up a runner from scratch

There is already a script to spin up a runner at gitlab.com/jonathanmaw/wsl-setup-script that can be modified, though if there's spare time it might be worth looking into other tools (ansible or packer scripts?)

[ ] Add gitlab CI for native windows to exercise bst init and `bst help functionality.

Using tox or pytest is not necessary, but will be simpler if tox or pytest "just work" (modulo nearly every test failing).
If these steps prove to be time-consuming, these tests should be set to only run on master,
otherwise we will block buildstream's CI.

[x] Install the experimental branches of buildbox-common and buildbox-casd in native windows.

Building these is likely to be highly time-consuming.

[x] Produce automated instructions for buildbox-common and buildbox-casd installation.

It must be relatively easy to specify different refs of buildbox-common and buildbox-casd, so
upgrading to the latest version of these (e.g. when there are more fixes) is easy.

[ ] Add gitlab CI for native windows to exercise bst build on import elements.

It must be relatively easy to disable this or make it optional.

Acceptance Criteria

When CI runs against master, tests are run to check windows 10 support for:

bst init
bst help
bst build of an import element.

The test for bst building an import element can be easily disabled.

In GitLab by [Gitlab user @jonathanmaw] on Oct 14, 2019, 15:17
marked the task Manually set up a Windows system to run CI jobs in native Windows as completed

In GitLab by [Gitlab user @jonathanmaw] on Oct 14, 2019, 15:17
marked the task Install Python and Pip as completed

In GitLab by [Gitlab user @jonathanmaw] on Oct 14, 2019, 15:17
marked the task Install BuildStream's pip dependencies as completed

In GitLab by [Gitlab user @jonathanmaw] on Oct 14, 2019, 15:17
marked the task Install the experimental branches of buildbox-common and buildbox-casd in native windows. as completed

In GitLab by [Gitlab user @jonathanmaw] on Oct 14, 2019, 15:30
Rather than follow my checklist in precise order, it was more expedient to follow the instructions in #1154 (and the additional notes in https://gitlab.com/snippets/1902536), to put together a command-line version of those instructions, then convert them to commands in an Autounattend FirstLogon script (i.e. https://docs.microsoft.com/en-us/windows-hardware/customize/desktop/unattend/microsoft-windows-shell-setup-firstlogoncommands).
Having gotten as far as installing buildstream with native windows support, I have hit a roadbump where the commands appear to be run (they're all present in C:\Windows\Panther\UnattendGC\setupact.log), but they don't seem to have had the required effect (the only effects I could find was that chocolatey is installed; and the path to buildbox-casd has been added to PATH, but that directory doesn't exist).
I am now trying to extract logging information for what went wrong.

In GitLab by [Gitlab user @jonathanmaw] on Oct 15, 2019, 13:04
It looks like the place where things started going wrong is that the PATH environment variable being set by chocolatey's installer was for a different user than the one that was running the unattend scripts.
I will try to get it working by using the full paths to the executables.

In GitLab by [Gitlab user @jonathanmaw] on Oct 16, 2019, 12:45
Using full paths to executables is working well.
I was encountering a problem where installing the chocolatey package for visualstudio2017buildtools and visualstudio2017-workload-vctools was timing out after spending 45 minutes apparently idle. The solution to this was to remove the "--install-recommended" option from the installer, since we probably don't need everything it can install.

In GitLab by [Gitlab user @jonathanmaw] on Oct 16, 2019, 14:57
It turns out there was one part of visual studio that was missing, Microsoft Visual C++. The chocolatey package vcredist2017 appears to be its equivalent.

In GitLab by [Gitlab user @jonathanmaw] on Oct 16, 2019, 15:01
Another problem was that installing gitlab-runner from chocolatey with the "/Service" parameter enabled would cause the installation to fail, because it failed to install a service for gitlab-runner.
This appears to be done by calling gitlab-runner install, so I can run that separately and see what the errors are from that.

In GitLab by [Gitlab user @jonathanmaw] on Oct 17, 2019, 17:38
marked the task Install a native windows gitlab runner as completed

In GitLab by [Gitlab user @jonathanmaw] on Oct 17, 2019, 17:38
marked the task Produce automated instructions to spin up a runner from scratch as completed

In GitLab by [Gitlab user @jonathanmaw] on Oct 17, 2019, 17:38
marked the task Produce automated instructions for buildbox-common and buildbox-casd installation. as completed

In GitLab by [Gitlab user @jonathanmaw] on Oct 17, 2019, 17:42
I finally have automatic configuration to spin up a windows VM that has all of the dependencies required to install buildstream, and registers itself with gitlab.
Next up:

Modify buildstream's CI script to perform the tests for us.

(nice-to-have) Figure out why bst build on import elements is failing (looks to be the same symptoms as https://gitlab.com/BuildStream/buildstream/issues/1154#note_228835376)

In GitLab by [Gitlab user @jonathanmaw] on Oct 21, 2019, 17:40
I've encountered some annoying syntax issues while trying to get environment variables set for all users for the packages that were installed, which has been a bit of a drag, as I was sure I'd already put that to bed.
In between that, however, the runner does work (https://gitlab.com/BuildStream/buildstream/-/jobs/327145384), but is having some problems with cython at the moment.

In GitLab by [Gitlab user @traveltissues] on Oct 22, 2019, 09:05
tbf this should probably install bb-common and bb-casd pinned by refs, is that what currently happens [Gitlab user @jonathanmaw]?

In GitLab by [Gitlab user @jonathanmaw] on Oct 22, 2019, 10:27
Currently I install it as part of the runner setup, since AIUI it's very time-consuming.

In GitLab by [Gitlab user @jonathanmaw] on Oct 22, 2019, 17:47
A possibility raised today is that building buildbox-common and buildbox-casd might not take as long as previously thought. If this turns out to be true, then it would make more sense to include the compilation of buildbox-common and -casd in gitlab-ci, instead of runner setup.

In GitLab by [Gitlab user @jonathanmaw] on Oct 22, 2019, 17:50
Also, while chasing the problem of gitlab-ci installing buildstream, the error seems to be unrelated to cython - the generated file does exist. I suspect that the problem is that gitlab-ci was running as system, rather than a user.
I am currently testing whether that is actually the cause.

In GitLab by [Gitlab user @jonathanmaw] on Oct 24, 2019, 14:41
By manually installing gitlab-runner using chocolatey, and specifying that it should create a gitlab-runner user, I managed to have more success - the compilation stage succeeded, but it failed to download one of buildstream's dependencies (ujson) due to an SSL certificate problem  (either ssl was misconfigured for that user or the certificates were missing).
Following on from that, I tried to get gitlab-runner to install a service running as the default user ("user"). Unfortunately, the process of giving a user permission to start services is non-trivial (chocolatey can do it, but in the unattend script fails to install the service for a reason I couldn't easily track down).
After a hunch brought on by this comment, I tried gitlab-runner run from the desktop session instead of an ssh session, and the runner started normally.
Given that this is also how we start gitlab-runner in the WSL runner, this should at least be quite simple.

In GitLab by [Gitlab user @jonathanmaw] on Oct 28, 2019, 18:00
I think I have made all the changes I need for .gitlab-ci.yml (https://gitlab.com/BuildStream/buildstream/commits/jonathan/win32_ci), but I still end up with breakages in my automatic runner setup, which mean every successful test run so far has required manual intervention.
The specific obstacles I am currently grappling with:

The only way I've found to be able to automatically start a gitlab-runner is to install a shortcut into a user's "startup" directory (i.e. C:\Users\user\AppData\Roaming\Microsoft\Windows\Start Menu\Programs\Startup).

This part is fine, but configuring the unattend script to perform the command fails. I think the only way I'll get it to work in a meaningful period of time will be to write a powershell script and run that, instead of inlining the commands.

I also have to attach a powershell script as the profile script (in C:\Users\user\Documents\WindowsPowerShell\Profile.ps1).

This involves invoking some powershell commands, which, if they turn out to have the same problems as the "Startup" script, will involve another attached script.

Currently, installing buildstream when not all of its dependencies have been downloaded fails due to missing/misconfigured SSL certificates. This only happens within the gitlab-runner, not when installed via the command-line.

The solution to this is to do that installation during runner setup, which requires the profile script to be installed (otherwise as soon as something needs to be compiled, it fails to find the necessary build tools).

In GitLab by [Gitlab user @jonathanmaw] on Oct 29, 2019, 10:02
The shortcut in a "startup" directory and the installation of a "profile" script are now working as planned.
The installation of buildstream dependencies is almost working, too. The only thing left to do is to track down why windows-curses wasn't installed.

In GitLab by [Gitlab user @jonathanmaw] on Oct 29, 2019, 14:06
The latest build (https://gitlab.com/BuildStream/buildstream/-/jobs/336151651) was accomplished with no manual intervention in the VM.
Things remaining to do:

Possibly move the build and install of buildbox-common and buildbox-casd into gitlab-CI, since they only take a couple of minutes apiece. It turns out that it takes longer to print the output of building them than it does to build them, thanks to a huge amount of warnings being printed.
Have the installation script pushed somewhere public.
Submit a MR for the .gitlab-ci.yml changes.

In GitLab by [Gitlab user @jonathanmaw] on Oct 29, 2019, 17:04
Having looked at how buildbox-casd is installed in the WSL runner, I'm less certain it can be safely built as part of gitlab-ci, or at the very least not in the time available.
In the WSL tests, a statically-compiled buildbox-casd binary is extracted and added to PATH.
I haven't looked up how to statically-compile a binary using Windows tools, so I'm not confident in how to do that.
The alternative is to simply install buildbox-common and buildbox-casd, but without a clear way to delete the old versions, we'd be installing newer versions over the top of older versions and hoping that doesn't lead to misleading successes / failures.

In GitLab by [Gitlab user @jonathanmaw] on Oct 30, 2019, 14:53
mentioned in merge request !1678

In GitLab by [Gitlab user @marge-bot123] on Oct 31, 2019, 15:57
closed via merge request !1678

In GitLab by [Gitlab user @marge-bot123] on Oct 31, 2019, 15:57
mentioned in commit 5c2fe471d9eda5b1924fc9a376d81b14c556e2d4


create signed certs with let's encrypt (ACME) by default

Mentioned elsewhere (#239, deploy/gce/deploy.go), but the Let's Encrypt CA wasn't public yet.
I think the main obstacle is that an ACME client needs to be able to serve things on ports 80 and 443 for verification. Some non-root are options listed here. setcap on (newish) Linux is a decent option. But for GCE etc this isn't an issue.
The certs expire after 3 months, so the server needs to refresh them periodically.
Inspiration:

https://github.com/mholt/caddy does it by default (http/2 too, thanks Brad!)
https://github.com/dkumor/acmewrapper

A super simple alternative would be to make sure that camlistored notices and rotates when the cert file changes on disk. Then, an external process could keep the cert updated (for example, Caddy), and camlistored could just use it.

There's a pending CL to add acmewrapper support: https://camlistore-review.googlesource.com/#/c/6137/1
I left some comments there.

Awesome, I should have searched the CLs. Maybe I'll keep this open anyway.

rsc has written one too:
https://godoc.org/rsc.io/letsencrypt

I am using rsc's and it works great. I use setcap to let me bind to port 443. My patch is hacky and says "if httpCert == "autoLetsEncrypt" then use rsc's package, otherwise do the normal thing".
I was planning on cleaning up the hackiness and posting a CL.

Related but different: #805 (for camlistore.org the website)


No apk available for download?

Hi,
Do you provide the apk? I'm still using race-control-tv from other forks, but yours seems to be the most advanced.

Hi, I published the app on Google Playstore (links on Readme file), do you have a special need for the apk itself ?

Thanks Leonardo. I'm trying to install it on my NVIDIA Shield, but the race-control-tv does not appear in the store. I'm thinking in side-loading it, as I already did with other apks.

What is the android version of your device / the country you are located?
I released an update yesterday to the store lowering the api level from 26 to 21 to support fire tvs, it might appear now, but it might also be that I did not release the app in your country, so then I have to fix that

Ps. the apk is now available at the releases page.


[Bug] Video link cannot be found

Describe the bug
The video link of "Exploring a repository" in Step 1 as shown in the screenshot cannot be found as the video is deleted.
Screenshots

در تاریخ پنجشنبه ۲۳ مارس ۲۰۲۳، ۶:۰۳ Racheal Chek @.***>
نوشت:

Describe the bug
The video link of "Exploring a repository" in Step 1 as shown in the
screenshot cannot be found as the video is deleted.
Screenshots
[image: image]
https://user-images.githubusercontent.com/74939355/227075825-4b8e7144-aff7-4723-b952-44616f592d94.png
—
Reply to this email directly, view it on GitHub
https://github.com/skills/introduction-to-github/issues/346, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/A6O6Y2Y4EI5N24RIMJBD3ZTW5OR63ANCNFSM6AAAAAAWER46IA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

The YouTube account has been deleted.
Deleted videos
:tv: Video: Exploring a repository
:tv: Video: Branches
:tv: Video: Introduction to pull requests
:tv: Video: Understanding the GitHub flow  can be substituted with :tv: Video: GitHub Actions - Supercharge your GitHub Flow (This is rather for skills/hello-github-actions)?

Thanks for reporting this! We are working on this internally 💖

Looking forward!!! Thanks 😊

Update: These links have been removed for now. Thank you again for reporting!

A video is still referenced here
https://github.com/skills/introduction-to-github/blob/f1aa28228428c58081bbb258dd0bac48f9c84a42/README.md?plain=1#L223
There is no video linked below, at least I was unable to find it.


Use CSS 2d/3d "transform" rather than "left" and "top"

I had a look at the "mirror" element and saw that dragula currently uses the CSS left and right properties to "attach" it to the mouse cursor.
It'll probably be much more performant to use transform: translate3d(x,y,0) or transform: translate(x,y) and fall back to left and right (for older browsers, e.g. IE7/8).

Sure. Closing as a dupe of #210 . Feel free to PR

Sorry for the duplicate. I would do a pull request, but it seems that there is already a pending pull request in #210, that didn't get accepted or declined (https://github.com/romainbessugesmeusy/dragula/commit/2c24df3d9fa712f55b7328de6a3669bfe62a3534)


Save king desync

Reported by c0pper#6086 on Discord

so on my screen saving the king is an instant option but because i dont click every square in between, it doesn’t register on your end

I actually think I fixed this already


Permit user of Reader objects in templates

In the case where we need to use a reader to avoid buffering large amounts of data in memory, there appears no way to use this reader in a go template.
This issue was raised before here:
https://github.com/golang/go/issues/25160
In summary, it was dismissed on the basis of "most people don't need this".  I would like to contest this. There are a lot of things "most people don't need" but what if the reason for the need is an important edge case (i.e. applications processing large data sets). Surely there are some people processing applications that operate over large data sets?

I'm not sure what you are asking for.   Issue #25160 ended by suggesting opening a proposal for the change.  Do you want to do that?  Indicate exactly what you think should be added to the text/template API.  Thanks.

@zaddok See also the discussion of the proposal at #29165. Unless some of the concerns there are addressed in this issue, I don't understand what change should be made to Go.

At a high level, it would be good to not have to (for example) load a 10mb array into memory so that a template can range over it to build a html or text document (that may also end up being 10mb). It would be desirable if a template could range over a Reader object that returns elements one by one.
I am not so interested in prescribing a particular implementation, just trying to work out how to handle requests that trigger high memory usage in my app server.


Uncomment BPDM API call

Can you be more specific ?  are you referring to our external call service in java?

Yes.
Please refere here
Currently, we launch the static data response from here. Uncomment the invoke service in externalBpdm service class.

so this done on
https://github.com/catenax-ng/tx-vas-country-risk-backend/commit/5ca94633e35d4c0afc04e84557af77b0674556f4

Maybe no.
Here you remove the invoke service call and load dummy json directly from the resource file. Before removing this line invoke service having call of BPDM service.
What's the use of that service and why still not call the actual BPDM API instand of loading dummy json?

The service exists because it will be called directly once the other side is ready.
I don't want to remove all the logic just to do it again later.
As soon as the other side has the data ready for me to receive, I will simply replace the line with dummy data with the commented line that I removed. That's why the logic remains the same, the calls remain the same, with only the exchange of one line for another. It doesn't make sense to me to change what is already programmed for the use cases we have.

One more and last question,
When we really expect the fully working functionality?

We currently don't have any specific dates set. As of today, any new functionality in this app is taking a backseat, as the external service is being developed with top priority.


Use travis_wait for "wine test_dash.exe" call to fix timeouts

This PR reverts the previous attempts to fix Travis timeouts for the "wine test_dash.exe" call and uses "travis_wait 30" to fix it again.
Was there any reason travis_wait was not used before?

ACK, verified Travis log output on Windows builds for latest commit.

Was there any reason travis_wait was not used before?

Unsure, but more likely just that nobody knew about it.

FYI , the reason for this PR is that I kept getting timeouts in the dashevo repo. I'll later pull this into dashevo through a full develop merge.


[NTR] Intratelencephalic Projecting Glutamatergic Neuron

Note - please check that the term does not already exist (check OLS: https://www.ebi.ac.uk/ols/ontologies/cl)
Preferred term label:
Intertelecenphalic Projecting Glutamatergic Neuron
Synonyms
IT projecting neuron
Definition (free text, please give PubMed ID in format PMID:XXXXXX)
Glutamatergic neuron that sends projections to structures of telencephalic origins.
DOI:10.1101/2<IP_ADDRESS>3129
Parent cell type term (check the hierarchy here https://www.ebi.ac.uk/ols/ontologies/cl):
glutamatergic neuron
What is the anatomical structure that the cell is a part of? Please check Uberon: https://www.ebi.ac.uk/ols/ontologies/uberon
http://purl.obolibrary.org/obo/UBERON_0000956 - Cerebral Cortex
Your nano-attribution (ORCID)
Any additional notes or concerns
Related to xref:(ILX:0770100) *describes the IT projecting phenotype, not the neuron itself
Related to #827

Alternatively, we could follow (ILX:0770100) and have it as a projection phenotype that we can subclass the cell types in?

Alternatively, we could follow (ILX:0770100) and have it as a projection phenotype that we can subclass the cell types in?


Thickening fonts

The KaTeX fonts look thin compared to MathJax. Here's an example:
  S[n]=S[n-1]+\frac{3}{2}S[n-2]+f(n)S[n-3]

which renders as follows:
KaTeX (font size reduced) on https://khan.github.io/KaTeX/

MathJax on https://arachnoid.com/latex/

Is there any way to improve this? The ones from KaTeX look wimpy, weak, made out of tin, compared to the MathJax ones that look robust as though Donald Knuth himself cast them out of steel. (sorry for the hyperbole) There are other minor differences in spacing and behavior but those don't bother me as much as the typeface.

At larger fonts this is less of an issue

I remember noticing this too when switching from MathJax to KaTeX.  I do think that slightly higher weight looks better on screens, though what looks best also depends a lot on text font surrounding the math.
Related to #624 and the plan (which I can't find at the moment) to switch from raster conversion to vector conversion to generate the fonts.

more examples (this one from my work laptop:

\( K_m = K_e\sqrt{\frac{3}{2R}} \)  (motor constant, N·m/√W)

\( \tau_e = L / R \) (electrical time constant, s)

\( \tau_{m1} = J / K_m{}^2 \) (mechanical time constant, s)

\(\xi = L_q / L_d \) (saliency ratio)

KaTeX:
https://cdn.rawgit.com/jason-s/c913d7810ea9a72138eadbe3f87135dd/raw/dfbba51a989db940bb341669210acf19350cace1/katex695.html

MathJax:
https://cdn.rawgit.com/jason-s/c913d7810ea9a72138eadbe3f87135dd/raw/37cf37aa54b4c83fe3c80e5fa013cab764173a3b/katex695-mathjax.html

One of the goals of KaTeX is to be as LaTeX compliant as possible.  Both KaTeX's and MathJax's output is readable.  I hesitate to make our fonts thicker just to be like MathJax.

I hesitate to make our fonts thicker just to be like MathJax.

It's not "just to be like MathJax", it's to be more readable on the web. When I find PDFs or Postscript files of LaTeX documents on the web, I groan. They look great on paper. They look poor on a screen, due to limited resolution.
Here is another sample: https://gist.github.com/jason-s/816b732498b9d356013ae4283bac6ffc along with some screenshots (Lenovo P51 + Win7 + Chrome or Acrobat DC)
PDF screenshots:
125%:

110%:

100%:

90%:

80%:

KaTeX 0.9.0:
125%:

110%:

100%:

90%:

80%:

MathJax:
125%:

110%:

100%:

90%:

80%:

Here are some side-by-sides: (from left to right, KaTeX 100%, Adobe Reader 125%, MathJax 100% -- the Adobe Reader is doing scaling, not re-rendering, so I wanted to show something comparable in size)

A couple of specific observations:

The 1, 2, 3, R (in 3/2R) and infinity in KaTeX look narrower (horizontally smaller) than in LaTeX or MathJax
The minus signs in KaTeX look thinner than in LaTeX or MathJax (I know, thanks, Mr. HTML Rendering Model, for antialiasing)

@jason-s To add to this discussion, I've been experimenting using MathJax fonts with KaTeX processing to achieve slightly heavier (and thus more readable) math.
You may be interested in this comparison page, which shows both fonts (and renderings) in different sizes:
https://www.intmath.com/cg3/katex-mathjax-fonts-outside.php
When I first did this some months ago, the MathJax fonts seemed to be quite a lot darker (like your screen shot), but not as much now. Not sure what I changed to get that outcome.
Notes:
(1) One problem with MathJax fonts (which you may be able to see depending on your OS/browser/screen setup) is that the top line of the equals sign and the bottom line of the ≥ sign are often fuzzy, e.g. middle table, 17.1px:

(2) The dots of the division sign in KaTeX font seems a bit out of alignment in certain font sizes, e.g. middle table, 16.5px:

(3) Vertical lines (like square brackets, absolute values and the plus sign) are often very light in both fonts, and almost disappear when viewing the screen at certain oblique angles.

It's not "just to be like MathJax", it's to be more readable on the web. When I find PDFs or Postscript files of LaTeX documents on the web, I groan. They look great on paper. They look poor on a screen, due to limited resolution.

@jason-s That's a fair point.  I wonder how many people are printing things rendered using KaTeX?  We could have two separate sets of fonts, one for rendering to a screen and another for use when printing.

@mbourne that division sign is awful.  I'm not sure what would compel a rendering engine to change a glyph so radically when rendering it.  :(

As a workaround, how about adding the following CSS to make the text thicker?
@media screen {
    .katex {
        text-shadow: 0 0 currentColor;
    }
}

Here is a comparison on Chrome 85 on Windows 10:

I'm not sure if it improves the legibility, though. Subpixel rendering does not seem to be working well with it.

same issue here.
i would replace \frac with \above{0.8pt}, for example.


Flow: fix VirtualizedList issues, remove few no longer valid suppressions

Summary
This PR fixes few suppressed Flow issues in VirtualizedList component.
I have also removed few no longer valid Flow suppressions in ActivityIndicator and ReactNativeTestTools.
Changelog

[General] [Fixed] - Flow: fix few issues in VirtualizedList,
[General] [Removed] - Flow: remove few no longer valid suppressions in ReactNativeTestTools
Test Plan
Successful run of yarn flow check.

I had to revert the ActivityIndicator suppression because Flow check fails on the CI (but work locally).
This might be something to check out and verify. Is it possible that CI uses different version of Flow?

@lunaleaps Thank you for the review, I have applied the suggested changes.


Update service.yaml

This is for two instance in a namespace

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[ ] DCO signed
[ ] Chart Version bumped
[ ] Variables are documented in the README.md
[ ] Title of the PR starts with chart name (e.g. [stable/mychartname])

Hey @wisekaa03 , thx for the PR. Could you pls bump the chart version and sign-off?


MAIN B-21073

INT PR
Agility ticket
Summary
For the last twenty years I have been working on this BL item and its beautiful personality and quirks. After fighting a timeout issue likely due to so many concurrency issues happening when building addresses (and also adding countries to the db), I updated the db-truncate file to NOT clear the test db of re_countries data so we can retain that and avoid unnecessary inserts into the test database when building test data.
OKAY.
So the point of this BL item was to add a single source of truth for country information, which required a re_countries table with populated data.
In addition to adding that data, we had to then refactor how we are handling country data in the backend and adding the Country object to the struct and then making that data accessible to the UI.
This PR does the following:

adds migration file that adds the re_countries table and refactors the addresses table to use the id column of the re_countries in the new country_id column - drops the country column
updates relevant Go structs
adds/updates a buncha Eager/EagerPreload instances to use "Addresses.Country" now that the Country object holds the necessary data
updates the Address definition for Swagger to only be two characters (we will handle this later on when international rolls out)
defaults all created addresses to have a US country
updates all tests (roughly 3 million tests)

How to test

Run make server_run and see the migrations run
Check your database and you should now see a re_countries table, as well as the addresses table having a removed country column and added country_id column
Open up the application and console log some addresses
You should be able to see the Country object attached to the addresses
Check any situation/process where Country is important

Test coverage on client failed.
Last run: Tue 08 Oct 2024 04:42:19 PM UTC
Refer to this report to see coverage details for the client app.
Documentation for test coverage can be found at this link.

Test coverage on client failed.
Last run: Fri 11 Oct 2024 08:04:08 PM UTC
Refer to this report to see coverage details for the client app.
Documentation for test coverage can be found at this link.

Test coverage on client failed.
Last run: Fri 11 Oct 2024 08:31:14 PM UTC
Refer to this report to see coverage details for the client app.
Documentation for test coverage can be found at this link.


Replace instances of envvar TRAVIS with CI

Fixes #360

@untitaker: Do you have a bot that adds the in progress label, or did you ninja-add it in less than one second?

That's waffle.io, also runs at khal. I'm just trying it out.

This will not suffice btw, usage of TRAVIS is also scattered across all testserver repos in the vdirsyncer org.
Build will go green anyway because both envvars exist.

Thanks!