SDSPI driver may erroneously use half-duplex mode when sharing with another SPI device, totally failling (IDFGH-5392)

Environment

Development Kit:      Adafruit Huzzah32
Module or chip used:  ESP32-WROOM-32
IDF version: v4.2.1
Build System:         CMake (PlatformIO)
Compiler version (run xtensa-esp32-elf-gcc --version to find it):
// 1.22.0-80-g6c4433a
Operating System:     Linux
Using an IDE?: PlatformIO with vscode.
Power Supply: USB

Problem Description
EDIT: I have found the problem. There is a bug inside the driver when the device sharing the bus with the SD card operated in half-duplex mode. In this case, after a transaction is made with the half-duplex device, the SDSPI driver's transactions are made in half-duplex mode as well, completely breaking everything. I trust someone who understands how the hardware SPI peripheral on the ESP32 is implement can fix this problem.
Old description:
I think I've found a subtle bug in the SDSPI interface when sharing with another SPI device, but I I need a bit of help to understand how something is going wrong inside the SDSPI/SPI driver. (I'm connecting my ESP32 to this board (https://www.adafruit.com/product/3357), on which an SD card and VS1053 audio chip share the same SPI bus.) Note throughout that what I'm trying to do here does work with arduino-esp32 SD-card interface.
I've looked all over message boards and in issues on this repo and others, and I think there are some traces of people having a problem very similar to this after the changes to esp-idf making sharing an SDSPI device with other SPI devices were merged, with people eventually giving up or going silent.
I have logic analyzer traces at the bottom while hopefully helps to understand what is happening. The problem arises in the following situation:

Call spi_bus_initialize() to set up the bus,
Call esp_vfs_fat_sdspi_mount() to configure the SD card and mount it (which because of nuances of the SD SPI spec must be done before anything else),
At this point, performing a directory listing in the mounted directory works.
Call spi_bus_add_device() to register the other device (in my case an audio chip), where the driver will manage CS asserting for us. Perform a single SPI transaction with spi_device_polling_transmit() where we exchange 48 bits on the bus.
At this point, performing a directory listing in the mounted directory will always fail. The following error is consistently emitted (this is on verbose log level):

V (4483) sdmmc_cmd: sending cmd slot=1 op=17 arg=4be000 flags=1c50 data=0x3ffbe7f4 blklen=512 datalen=512 timeout=1000
V (4493) sdspi_host: sdspi_host_start_command: slot=1, CMD17, arg=0x004be000 flags=0x5, data=0x3ffbe7f4, data_size=512 crc=0x1b
V bus_lock: dev 5 acquired.
D (4503) spi_master: device5 locked the bus
V bus_lock: SPI dev changed from 0 to 5
V (4513) spi_master: polling trans
V (4513) spi_master: polling trans done
V (4523) spi_master: polling trans
V (4523) spi_master: polling trans done
V (4533) spi_master: polling trans
V (4533) spi_master: polling trans done
V (4533) spi_master: polling trans
V (4543) spi_master: polling trans done
V (4543) spi_master: polling trans
V (4543) spi_master: polling trans done
V (4553) spi_master: polling trans
V (4553) spi_master: polling trans done
V (4553) spi_master: polling trans
V (4563) spi_master: polling trans done
V (4563) spi_master: polling trans
V (4573) spi_master: polling trans done
V (4573) spi_master: polling trans
V (4573) spi_master: polling trans done
D (4583) sdspi_host: poll_data_token: received 0x40 while waiting for data
V (4583) spi_master: polling trans
V (4593) spi_master: polling trans done
D (4593) spi_master: device5 release bus
V (4603) bus_lock: dev 5 released.
D (4603) sdspi_host: sdspi_host_start_command: cmd=17 error=0x108
D (4603) sdmmc_cmd: cmd=17, sdmmc_req_run returned 0x108
E (4613) sdmmc_cmd: sdmmc_read_sectors_dma: sdmmc_send_cmd returned 0x108
E (4623) diskio_sdmmc: sdmmc_read_blocks failed (264)
D (4623) vfs_fat: vfs_fat_readdir_r: fresult=1

On the other hand, performing a directory listing will work again if I immediately unmount the SD card and then remount it again.
One problem is that the log line sdspi_host: poll_data_token: received 0x40 while waiting for data appears to be nonsense---here is a logic analyser output taken immediately after the SPI transaction to the audio chip:

On the other hand, here is a logic analyser output taken when I comment out the SPI transaction to the audio chip:

There are a few curious differences between the two:

Recall that in the SD SPI protocol when a READ_SINGLE_BLOCK command is issued we have to poll the SD card, expecting 0xFF over and over, until we get a 0xFE. Then the next bytes start being data. On the ESP32 there is then a much longer SPI transaction initiated by the SDSPI driver to read the rest of the waiting 512-byte block.
In the successful logic analyser trace you can see three "bursts"; the first is issuing the command, the second is the the first poll after the command was issued, during which at some point we got back a 0xFE, and the third is a much longer (depicted thicker) burst where we get the rest of the data.
But now, in the other logic analyser trace (the one where we have the problem) we see multiple strange things. First, the SDSPI driver error log means that it read 0xFFs until it encountered a 0x40 which it did not expect (it was expecting a 0xFE). This is already very strange, because the logic analyser dump of the SPI data transmitted during the transaction:

FF FF FF FF FF FF FF 00 FF FF FF FF FF FF FF FF
FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF
FF FF FF FF 90 5D 00 1C 80 18 40 18 C0 1A C0 03
C0 22 8C 00 0C 00 0C 40 0B 80 1B 40 1C 00 00 00
0C C0 00 00 15 14 90 50 D2 CC 0C 0C 53 54 0C C8
00 0D C9 15 55 D4 55 D4 40 00 08 D5 55 D4 51 81
AB 3E 54 80 10 5D 00 1C 80 18 40 18 C0 1A C0 03
C0 1A 8C 00 0C 00 0C 80 0B 80 1B 40 1C 00 00 00
0C C0 00 00 15 14 90 50 D2 CC 0C 0C 93 54 0C C8
00 27 88 D5 55 D4 55 D4 40 00 08 D5 55 D4 40 C0

does not even contain a 0x40 in an obvious place. (Note that showhow the logic analyser has gotten confused and is one bit out of sync for this hex dump, so you actually have to left shift all of the hex dump by one bit. This is why we see 0x90 instead of 0xFE, if we left shift by 1 everything is fixed.)
Next, and also very strange, is that by my reading of the "bad" logic analyser trace, the SDSPI driver must be reading the 0x40 during the very last "burst" (SPI transaction) depicted, but we can see that before this point plenty of data which was not 0xFF has already transmitted by the SD card. I also have no idea why this is happening: (after reading the code, especially poll_data_token() in components/driver/sdspi.c, it seems clear that the driver will abort as soon as the 0x40 is read, only stopping to transmit an additional 8-bits of binary 1s in the abort path, to get the SD card to release MISO).
My hope is that someone who understands the SD card driver could explain what is going on. As I said above, all of this does work when I use the adruino-esp32's SD library, which as I understand it actually reimplements a lot of the SD card SPI protocol (using spi_master directly), and this is why I believe this is a bug in esp-idf (if I did not have this working example I would still just be confused).
Thank you for very much for your help.

Extra info: It seems that in the "bad" version, the READ_SINGLE_BLOCK transaction has twice as many clock pulses:
Bad:

Good:

I also don't have any idea why this double-length thing is happening, since it seems to me that the code (https://github.com/espressif/esp-idf/blob/1d7068e4be430edd92bb63f2d922036dcf5c3cc1/components/driver/sdspi_host.c#L667) has a fixed length for that transaction. I suppose it seems like the "good" case is either not reading at all, or reading in full-duplex mode instead of half-duplex?

Yes, communicating with the other device on the bus using full duplex mode fixes this problem. There is a bug inside the SPI driver handling the duplex mode somewhere.

Yes, I submitted a fix for this to the ESP32 forum several months ago.
[image: IOSiX Logo]
Robert Vogt IV
CEO
IOSiX, LLC ᐧ www.iosix.com
1300 Tefft Ct #1
Saline MI, 48176
855.623.1939 ext. 700
On Fri, Jun 11, 2021 at 3:04 PM Keeley Hoek @.***>
wrote:

Yes, communicating with the other device on the bus using full duplex mode
fixes this problem. There is a bug inside the SPI driver handling the
duplex mode somewhere.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/espressif/esp-idf/issues/7138#issuecomment-859782432,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAUXMBZDGGEAKSR6KT465GDTSJM33ANCNFSM46RE43FA
.

@iosix That's great to hear. Did you submit a pull request? Was the fix backported to idf v4.2?

I’m pretty sure no one bothered to do anything with it, but here it is:
https://www.esp32.com/viewtopic.php?t=13719
Robert Vogt IV
CEO
IOSiX, LLC
1300 Tefft Ct #1
Saline, MI  48176
P: +1-855-OBD-1939
C: +1-734-730-9690
@.***

On Jun 12, 2021, at 9:02 AM, Keeley Hoek @.***> wrote:

@iosix That's great to hear. Did you submit a pull request? Was the fix backported to idf v4.2?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks for the detailed report, we will look into.

Dear @khoek, I have created a similar test using examples\peripherals\lcd\tjpgd and examples\storage\sd_card\sdspi. Created two tasks, one for displaying image on LCD and the other for writing/read-verify patterns to a file with fat-fs. This test runs indefinitely. One of the tasks will be using SPI master for communicating with the respective device.

Please see if this helps.

Thanks for reporting, would you please help share if any updates for the issue? Thanks.

No response from the reporter for few weeks, closing the issue. Please, feel free to reopen if needed


Auto-Expand All Rows

Is it possible to auto expand all rows?  Currently it seems like you have to pass in an object which contains the rows you wish to expand. Instead, I'd prefer the ability to have everything expanded, while giving the user the option to collapse certain sections.

It is possible to expand all rows. You would need to map through all of the visible rows and create a key-value for each one.
{0: true, 1: true, 2: true, 3: true, ....}

There aren't any future plans to support the inverse for now.

What's the proper value for this? props.expander or props.expanderRows? I want to implement a toggle collapse on all items on the table, how can this be doable?

Check the section in the doco called Controlled State Overrides

Thanks for replying so fast! I did check that, but then I'd have to manage the entire behavior of the table on my own, is that the only way?

react-table is very light weight (deliberately designed that way) to make it perform well and to provide the greatest flexibility (as these things very quickly turn into implementation quirks). So, yes, that is the only way. However, I think you will find that the amount of work required is not quite as extreme as "the entire behaviour".
You don't have to implement Filtering, Sorting, Column Sizing, Paging, and the actual rendering of the expanded rows.  In this case, you only have to manage the state of the expanded rows externally.

Sounds like a fair trade. I just thought that there were another way, I've seen about expandedRows prop but maybe it was just a wrong prop. I will work it out. Thanks a lot!

Just a quick simple solution for those looking to map the expanded columns:
this.state.expandedColumns = this.state.columns.map(x => true);
Then in the / component expanded={this.state.expandedColumns}
I put the mapping in the constructor after the columns state was declared, but is there any benefit to putting it in a componentWillMount, etc, instead?

Firstly, doing that type of initialisation in the constructor is fine (apparently componentWillMount is being deprecated in V17 of React).
However, I think the rest of your solution has a few misunderstandings that need clearing up.

expanded is actually a nested structure that is used for both plain SubComponent expansion as well as for expanding nested pivot rows and it uses the view index of the row (which in the simplest case is 0 through to the number of displayed rows minus 1 (0 to visibleRows.length-1)
mapping the columns as you have done will only work when the number of columns is equal to or greater than the number of displayed rows (there is no relationship between a column and the expanded object
by only providing epxanded (and not also providing onExpandedChange) the feedback loop of the users changes (i.e. clicking on the row toggle icon) is broken and the linese can't be changed

@gary-menzel , I've about 15 columns to be pivoted and then there are about 50 rows displayed on the table. and all the pivoted groups are auto-expanded.
I'm generating a nested structure to have all these rows expanded and is passed down to the table component as props. Generating the nested structure often goes out of memory and crashes the browser.
Is there any other way I can auto expand all the pivoted columns? (I would not want the user to collapse/expand them anyway)

Late to the party, but we solved this using defaultExpanded prop and these set of functions.  Note I'm using Lodash here to map and groupBy but definitely possible to remove those dependencies if you want:
import groupBy from 'lodash/groupBy';
import map from 'lodash/map';

const getAllExpandedData = (data, [pivotBy, ...rest]) => {
  if (rest.length === 0) {
    return map(groupBy(data, pivotBy), value => value);
  }
  return map(groupBy(data, pivotBy), value => {
    return getAllExpandedData(value, rest);
  });
};
const arrayToObjectWithIndices = array => array.reduce((acc, value, index) => {
  acc[index] = isArray(value) ? arrayToObjectWithIndices(value) : true;
  return acc;
}, {});

export const getExpandedPivotedIds = (reportData, pivotBys) => {
  return arrayToObjectWithIndices(getAllExpandedData(reportData, pivotBys));
};

// in component
const pivotBy = ['foo','bar','baz']
return <ReactTable data={data}
  pivotBy={pivotBy}
...
defaultExpanded={getExpandedPivotedIds(data, pivotBy)}
/>

Hope it helps!

Here is the (probably way overcomplicated way) I got this to work:
`class ReactTable extends Component {
constructor(props) {
super(props);
this.state = {
data: [],
expandedRows: [],
};
}
getData() {
this.setState(() => ({
data: getDataInfo,
expandedRows: getDataInfo.map((x) => true),
}));
});
}
componentDidMount() {
this.getData();
}
render() {
const { data, expandedRows } = this.state;
return (
<ReactTable
data={data}
columns={columns}
expanded={expandedRows}
onExpandedChange={(newExpanded, index) => {
if (newExpanded[index[0]] === false) {
newExpanded = {};
} else {
Object.keys(newExpanded).map((k) => {
newExpanded[k] = {};
});
}
this.setState({
...this.state,
expandedRows: newExpanded,
});
}}/>
`
defaultExpanded wouldn't work for me, even if I simply put in {0: true, 1: true} etc.

defaultExpanded isn't work for me too, so I created a new function by going with @jessicabyrne's code.
        <ReactTable
          data={data}
          columns={this.columns}
          expanded={expandedRows}
          onExpandedChange={(newExpanded, index) => {
            this.setState((oldState) => {
              const itemIndex = index[0];
              const isExpanded = oldState.expandedRows[itemIndex];
              const expandedList = [...expandedRows];
              expandedList[itemIndex] = !isExpanded;
              return {
                expandedRows: expandedList
              };
            });
          }}
        />

df

How to auto expand all rows in antd table , defaultExpandAllrows only works for first render after refresh it is getting closed

How to auto expand all rows in antd table , defaultExpandAllrows only works for first render after refresh it is getting closed

useTable(
  {
    columns,
    data,
    autoResetExpanded: false,
  })

How to auto expand all rows in antd table , defaultExpandAllrows only works for first render after refresh it is getting closed

useTable(
  {
    columns,
    data,
    autoResetExpanded: false,
  })

Typescript does complain about autoResetExpanded
Argument of type '{ columns: []; data: []; autoResetExpanded: boolean; }' is not assignable to parameter of type 'TableOptions'.
Object literal may only specify known properties, and 'autoResetExpanded' does not exist in type 'TableOptions'.


Rendering multi-volume works

Who it's for
Collections researchers
Problem to be solved
We can't currently render works with multiple volumes, or in the IIIF world, multiple manifests.
We also can't filter multi-vol books out from the current e-book filter, which has meant a temporary solution that is already past its sell-by date (#4333)
https://wellcomecollection.org/works/pscn63yg?query=darwin

TODO

[x] Change alert text to July 2019
[ ] UX Design work to consider work preview and viewer

Considerations

We need to design for missing volumes. Not all volumes of every m-v work have been digitised

Would this apply to multi-section manuscripts? Who would be good person to follow up to get a sense of these items and how they are currently represented on WL.org?

Me, probably?
As far as how the data structure is created, Christy, Harkiran and Ashley.
As far as subject expertise goes, Elma is your woman.
Not all manuscripts have multiple parts.
Single:
https://wellcomelibrary.org/item/b18934717
Multiple:
https://wellcomelibrary.org/item/b19553146
https://wellcomelibrary.org/item/b19241380
Full list from catalogue: http://search.wellcomelibrary.org/iii/encore/search/C__Sdigwms__Ff%3Afacetlocations%3Aelro%3Aelro%3AOnline%3A%3A__Orightresult?lang=eng&suite=cobalt

I'm going to move these comments into a new issue ⬆

10 July
Here's the wireframe based on the team discussion yesterday. I reviewed with @GarethOrmerod. He's going to explore

Preview of multi-volume book
Preview of multi-volume book (partially digitised work)
Preview CTA
View List/Detail: controls and labels

Links to design updates relating to Design Review 11.07.19
Desktop:
zpl://screen?sid=5d27595b6ca7dc9d9b17dfa1&pid=5aab926b4b6efde01259e959
zpl://screen?sid=5d27595b66f79c9d6409ed8f&pid=5aab926b4b6efde01259e959
Mobile:
zpl://screen?sid=5d27595b22ffa26afacf66a6&pid=5aab926b4b6efde01259e959

@GarethOrmerod Here's the exploration for the view controls. Let's chat on Monday.

As of 12/7/19:

Volumes
Number of things

1
248199

2
2762

3
696

4
379

5
182

6
103

7
55

8
47

9
24

10
19

11
9

12
12

13
6

14
2

15
6

16
7

17
1

18
9

19
2

20
3

22
2

27
1

28
1

29
1

35
1

36
2

38
1

43
1

55
1

59
1

67
1

6425
1

@jennpb Thanks for getting this data. Does it include just materials available in the current API or other work types like journals? Do you know which work has 6425 volumes?

This is the entirety of the collection that's been digitised, so archives, video, audio, journals, manscripts, books, etc. We only have one journal digitised, and that's the 6425 Chemist and Druggist.
Tom has just alerted me to the fact that we do have some videos that are multiple-manifestations, where the video is one and the transcript is another. We'll need to accommodate this somewhere.
For the avoidance of further confusion, I've changed 'volumes' to 'Manifestations' (that's in the IIIF).


Exec tachikoma update<PHONE_NUMBER>3433

:hamster::hamster::hamster:   Strategy none
Powered by Interval Pull Request as a Service - Tachikoma.io Announcement: 2015-06-28 Updated permissions - Tachikoma.io

Coverage remained the same at 68.0% when pulling b27d235b9a6c763c7eec14841024479688aa6cca on pazjacket:tachikoma/update-20160529163433 into 0c477cea399180e0dc0455b31d685efdbee0f3af on sanemat:master.


operator: cleanup unused consts

Please provide a description of this PR:

@hanxiaop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-istiodremote_istio
8b7f7577213fe67e4e77ddb64216669916940a01
link
true
/test integ-pilot-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-istiodremote


Prevent setting a dictionary value to nil as this crashes on iOS 7

We're currently seeing a lot of crashes exclusively on iOS 7 in XCDYouTubeVideo.m:28. This happens during the parsing of the query string. The call to - stringByRemovingPercentEncoding fails and dictionary[key] = value is called with a nil value, which isn't safe on iOS 7.
Fatal Exception: NSInvalidArgumentException
0  CoreFoundation                 0x2e4dff83 __exceptionPreprocess
1  libobjc.A.dylib                0x38c90ccf objc_exception_throw
2  CoreFoundation                 0x2e41b8f3 -[__NSDictionaryM setObject:forKey:]
3  ADW                            0x3f9f1b XCDDictionaryWithQueryString (XCDYouTubeVideo.m:28)
4  ADW                            0x3fa9e9 -[XCDYouTubeVideo initWithIdentifier:info:playerScript:response:error:] (XCDYouTubeVideo.m:112)
5  ADW                            0x3fc349 -[XCDYouTubeVideoOperation handleVideoInfoResponseWithInfo:response:] (XCDYouTubeVideoOperation.m:175)
6  ADW                            0x3fcb95 -[XCDYouTubeVideoOperation handleJavaScriptPlayerWithData:response:] (XCDYouTubeVideoOperation.m:258)
7  ADW                            0x3fc0d5 -[XCDYouTubeVideoOperation handleConnectionSuccessWithData:response:requestType:] (XCDYouTubeVideoOperation.m:156)
8  ADW                            0x3fbfed __53-[XCDYouTubeVideoOperation startRequestWithURL:type:]_block_invoke91 (XCDYouTubeVideoOperation.m:127)
9  CFNetwork                      0x2e0f93d5 __49-[__NSCFLocalSessionTask _task_onqueue_didFinish]_block_invoke
10 Foundation                     0x2ee243c7 -[NSBlockOperation main]
11 Foundation                     0x2ee145ab -[__NSOperationInternal _start:]
12 Foundation                     0x2eeb876d __NSOQSchedule_f
13 libdispatch.dylib              0x39178ded _dispatch_queue_drain$VARIANT$up
14 libdispatch.dylib              0x39179297 _dispatch_queue_invoke$VARIANT$up
15 libdispatch.dylib              0x3918b88d _dispatch_root_queue_drain
16 libdispatch.dylib              0x3918bb21 _dispatch_worker_thread2
17 libsystem_pthread.dylib        0x392babd3 _pthread_wqthread
18 libsystem_pthread.dylib        0x392baa98 start_wqthread

Thanks for catching this! Could you please provide a video identifier which triggers this behavior? I'd like to see on which input stringByRemovingPercentEncoding is failing to make sure ignoring the value is the best thing to do.

As you can imagine, this was a tough one to reproduce. Stupidly enough, once reproduced, I forgot to add a video identifier that triggered this to our internal bug ticket. What I do know, is that 100% of the crashes were caused due to an invalid xtags key. I was unable to find sufficient information about the meaning of that key. The videos played after the proposed fix was applied, which was good enough for us.


fix; Properly ingest Binary View types without variadic buffers

closes https://github.com/apache/arrow-nanoarrow/issues/634

Good point - yes the builder starts with n_array = 2. I'll take a look at that


cloud appname.saltcorn.com is still on 0.9.5.beta.7 but the Github is already on  0.9.5.beta.10.

Hopefully some issues I have with beta.7 are solved on beta.10 ;-)
Any news when cloud saltcorn.com will be upgraded to 10?
Anyway, keep up the fantastic work you and the team are doing to further improve Saltcorn!

and running the newest again!


enhancement: 4423 switch sending back data from server to res.json() …

remove usage of res.send() in preference of res.json() and res.end()
Hey, I just made a Pull Request!

:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)

I noticed our linting is enforced by @spotify/eslint module. Unsure of where to add a custom eslint plugin if we wanted to enforce/warn the usage of res.send()


Show HTML tag on TOC, not escaping them

🐛 Bug Report
TOC content doesn't show header as they show on H2/H3 tags.
As I mentioned in #1671 TOC content doesn't show HTML tags, TOC has escaped these HTML tags.
In that issue, I just said that localhost is different from the website. But my real problem is could the TOC allow HTML tag, not escape them ?
Have you read the Contributing Guidelines on issues?
YES
To Reproduce
Expected behavior

Actual Behavior

Reproducible Demo
(Paste the link to an example repo, including a siteConfig.js, and exact instructions to reproduce the issue.)
fork-demo

the way to fix it
and I find the way to fix it.
just change code
from
<Link hashLink={heading.hashLink} content={heading.content} />
to
<Link hashLink={heading.hashLink} content={heading.rawContent} />
It seems the master branch is on developing v2.x, so I think maybe open a pull request to fix this is not a very good way.
I think this maybe also help for #1011 .
Thank you for creating this project ^_^.

This can now be closed as it's fixed @yangshun

Oh, wait, actually, no; I'm wrong there. @leavesster can you check with the current master of docusaurus as to whether the change in #1762 has the desired results for you?

Oh, wait, actually, no; I'm wrong there. @leavesster can you check with the current master of docusaurus as to whether the change in #1762 has the desired results for you?

I'm glad to try. In #1671 I said It only render wrong headers on my website, so I will produce it on my website.
I'm unfamiliar with dependencies with GitHub URL (not the whole git repo, only a directory in it).
I've read the npm document. And I could not find a way to add a URL (not git homepage, just https://github.com/facebook/docusaurus/tree/master/packages/docusaurus-1.x) to package.json ？
It just failed, and give me this message:
https://github.com/facebook/docusaurus/tree/master/packages/docusaurus-1.x: Extracting tar content of undefined failed, the file appears to be corrupt: "Invalid tar header. Maybe the tar is corrupted or it needs to be gunzipped?

I read package.json It seems
urls-as-dependencies only support tarball.
And Git URLs as Dependencies only support the whole git, not a directory in git.
I want to know if you have any idea of testing unreleased but already on website package?
If there is no way I can use unreleased package. I think I can release a forked package tomorrow to check if it ok.

@leavesster We just published v1.13.0, see if upgrading to that fixes your problems!

@leavesster We just published v1.13.0, see if upgrading to that fixes your problems!

It works. Thank you ^_^


Add Pokemon to list of uncountables

Hey! 👋 Thanks for this awesome module 🙏
The plural of Pokémon is not Pokémons, so I've added it to the list of uncountables.
✌

Coverage remained the same at 100.0% when pulling 36799eff287b05a26d0ca0ac00fc37a5e9ab0662 on hugomd:patch-1 into 9be3a260f7bb6aa4d30eeab2473f5715f555812b on blakeembrey:master.

Happy to merge this, but should we also handle it with the "é"?

Coverage remained the same at 100.0% when pulling e33a495890bf682e8ee5fe9cae945fa695633660 on hugomd:patch-1 into 9be3a260f7bb6aa4d30eeab2473f5715f555812b on blakeembrey:master.

@blakeembrey I've added an extra case for "é", and some tests, although I'm not sure if the test cases are in the right place.. If they're not, happy to fix, other than that should be good to merge 👍
Thanks for making this project 🙏

Coverage remained the same at 100.0% when pulling 06f45ab7dd84215f3dc0f8812871f492b6163ac8 on hugomd:patch-1 into 9be3a260f7bb6aa4d30eeab2473f5715f555812b on blakeembrey:master.


Public member functions & trait impls are missing for wildcard useed module

If one does a wildcard use of an internal module, such as use xx::* this will include public types and functions in that module, but it will miss any member functions or trait implementations of types inside that module if the module is not public.
Example
Given this code:
mod a {
    pub mod a1 {
        #[derive(Copy, Clone)]
        pub struct Test {}

        impl Test {
            pub fn test2() {}
        }

        pub fn test1() {}
    }
}

pub use a::*;

this generates this output which is missing the test2 member function and the derived clone member function:
pub fn api_test::a1::test1()
pub mod api_test
pub mod api_test::a1
pub struct api_test::a1::Test

but it should be:
pub fn api_test::a1::Test::clone(&self) -> api_test::a1::Test
pub fn api_test::a1::Test::test2()
pub fn api_test::a1::test1()
pub mod api_test
pub mod api_test::a
pub mod api_test::a1
pub mod api_test::a::a1
pub struct api_test::a1::Test
pub struct api_test::a::a1::Test

if one change mod a to pub mod a then the member functions are correctly included both under the a module and from the use a::* statement.

Thank you for reporting! I reduced the code as much as I could and reported as https://github.com/rust-lang/rust/issues/102583. Maybe there are follow-up problems, but let's take them one at a time.

thanks!

The upstream bug has been fixed in nightly-2022-10-30. Here is the output after rustup update nightly:
$ cargo public-api
impl RefUnwindSafe for api_test::a1::Test
impl Send for api_test::a1::Test
impl Sync for api_test::a1::Test
impl Unpin for api_test::a1::Test
impl UnwindSafe for api_test::a1::Test
pub fn api_test::a1::Test::clone(&self) -> api_test::a1::Test
pub fn api_test::a1::Test::test2()
pub fn api_test::a1::test1()
pub mod api_test
pub mod api_test::a1
pub struct api_test::a1::Test

that looks correct, right? In your expected output, you also had
pub mod api_test::a
pub mod api_test::a::a1
pub struct api_test::a::a1::Test

but since mod a is not pub, we should not expect that also in the output.

ah yes that looks correct! thanks!
do a new release soon with that new nightly?

@repi No need for a new release, just do rustup update nightly. After that, cargo public-api will use the latest nightly with the latest fixes, including this one!
I don't think I want to bump the minimum required nightly version since the rustdoc JSON format has not changed. In general it is a good idea to always just latest nightly to make sure one gets the latest fixes.
So I'll close this issue now. Thanks for confirming it is fixed!

ah nice! didn't realize it was just a minimum version, thought it was a pinned one. but we have pinning on our side that I'll try and update and see.

some of our public API listing snapshots now contain 3000 lines of symbols instead of 1200 lines, so a lot were missing from us in the past. great to have this fixed!


Select language screen

At no point during creation of the account can you choose the langugage. You cannot assume that the user knows english (predefined langugage)

not a feature yet. planned for later


Failed to run the tflite model on Interpreter due to Internal Error

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): YES
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 20.04 LTS
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary): binary
TensorFlow version (use command below): 2.3.0-dev20200617
Python version: 3.7.6
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version: 10.2
GPU model and memory:

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
I am trying to run a neural machine translator on android. The model runs perfectly on my jupyter notebook but when I used the generated tflite model to get predictions on android, it throws the error java.lang.IllegalArgumentException: Internal error: Failed to run on the given Interpreter: tensorflow/lite/kernels/concatenation.cc:73 t->dims->data[d] != t0->dims->data[d] (8 != 1) Node number 84 (CONCATENATION) failed to prepare.
This is strange because I have provided the exact same input dimensions as I did in my jupyter notebook.
As the error pointed, there was something wrong with dimensions at node 84. So I went ahead and visualised the tflite file using Netron. I have zoomed the concatenation node, you can find the pic of the node along with input and output dimensions here. You can find the whole generated graph here.
As it turns out, the concatenation node at location 84 isn't actually concatenating, you can see this from the input and output dimensions. It just spits out a 1X1X1 matrix after processing 1X1X1 and 1X1X256 matrix. But is this responsible for the crash? Is the node computing correctly?
Also, could anyone please explain me what does the error mean by t->dims->data[d] != t0->dims->data[d] what is d?
Describe the expected behavior
The tflite model should be able to make predictions
Standalone code to reproduce the issue
Please find the tflite file here. You can reproduce the error using the following snippet on android once you have the Interpreter tfLite initialised:
        HashMap<Integer, Object> outputVal = new HashMap<>();
        for(int i=0; i<2; i++) outputVal.put(i, new float[1][5]);
        float[][] inp_test = new float[1][8];
        float[][] enc_hidden = new float[1][1024];
        float[][] dec_input = new float[1][1];
        float[][] dec_test = new float[1][8];

        tfLite.runForMultipleInputsOutputs(new Object[] {inp_test,enc_hidden, dec_input, dec_test},outputVal);

My gradle dependencies:
dependencies {
    implementation fileTree(dir: 'libs', include: ['*.jar'])

    implementation 'androidx.appcompat:appcompat:1.1.0'
    implementation 'org.tensorflow:tensorflow-lite:0.0.0-nightly'
    implementation 'org.tensorflow:tensorflow-lite-select-tf-ops:0.0.0-nightly'
    // This dependency adds the necessary TF op support.
    implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
    testImplementation 'junit:junit:4.12'
    androidTestImplementation 'androidx.test.ext:junit:1.1.1'
    androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0'
}

Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
Here is the code for the model:
It is highly inspired by this guide: https://www.tensorflow.org/tutorials/text/nmt_with_attention

Tx = 8
def Partial_model():
    outputs = []
    X = tf.keras.layers.Input(shape=(Tx,))
    partial = tf.keras.layers.Input(shape=(Tx,))
    enc_hidden = tf.keras.layers.Input(shape=(units,))
    dec_input = tf.keras.layers.Input(shape=(1,))

    d_i = dec_input
    e_h = enc_hidden
    X_i = X

    enc_output, e_h = encoder(X, enc_hidden)

    dec_hidden = enc_hidden
    print(dec_input.shape, 'inp', dec_hidden.shape, 'dec_hidd')
    for t in range(1, Tx):
        print(t, 'tt')
      # passing enc_output to the decoder
        predictions, dec_hidden, _ = decoder(d_i, dec_hidden, enc_output)
#         outputs.append(predictions)
        print(predictions.shape, 'pred')
        d_i = tf.reshape(partial[:, t], (-1, 1))
        print(dec_input.shape, 'dec_input')

    predictions, dec_hidden, _ = decoder(d_i, dec_hidden, enc_output)
    d_i = tf.squeeze(d_i)

    outputs.append(tf.math.top_k(predictions, 5))

    return tf.keras.Model(inputs = [X, enc_hidden, dec_input, partial], outputs = [outputs[0][0], outputs[0][1]])

class Encoder():
  def __init__(self, vocab_size, embedding_dim, enc_units, batch_sz):
    self.batch_sz = batch_sz
    self.enc_units = enc_units
    self.embedding = tf.keras.layers.Embedding(vocab_size, embedding_dim)
    self.gru = tf.keras.layers.GRU(self.enc_units,
                                   return_sequences=True,
                                   return_state=True,
                                   recurrent_initializer='glorot_uniform')

  def __call__(self, x, hidden):
    x = self.embedding(x)
    output, state = self.gru(x, initial_state = hidden)
    print(output.shape, hidden.shape, "out", "hid")
    return output, state

  def initialize_hidden_state(self):
    return tf.zeros((self.batch_sz, self.enc_units))

class BahdanauAttention():
  def __init__(self, units):
    self.W1 = tf.keras.layers.Dense(units)
    self.W2 = tf.keras.layers.Dense(units)
    self.V = tf.keras.layers.Dense(1)

  def __call__(self, query, values):
    # query hidden state shape == (batch_size, hidden size)
    # query_with_time_axis shape == (batch_size, 1, hidden size)
    # values shape == (batch_size, max_len, hidden size)
    # we are doing this to broadcast addition along the time axis to calculate the score
    print(query.shape, 'shape')
    query_with_time_axis = tf.expand_dims(query, 1)
    # score shape == (batch_size, max_length, 1)
    # we get 1 at the last axis because we are applying score to self.V
    # the shape of the tensor before applying self.V is (batch_size, max_length, units)
    print("2")
    score = self.V(tf.nn.tanh(
        self.W1(query_with_time_axis) + self.W2(values)))
    print("3")

    # attention_weights shape == (batch_size, max_length, 1)
    attention_weights = tf.nn.softmax(score, axis=1)

    # context_vector shape after sum == (batch_size, hidden_size)
    context_vector = attention_weights * values
    context_vector = tf.reduce_sum(context_vector, axis=1)

    return context_vector, attention_weights

class Decoder():
  def __init__(self, vocab_size, embedding_dim, dec_units, batch_sz):
    self.dec_units = dec_units
    self.embedding = tf.keras.layers.Embedding(vocab_size, embedding_dim)
    self.gru = tf.keras.layers.GRU(self.dec_units,
                                   return_sequences=True,
                                   return_state=True,
                                   recurrent_initializer='glorot_uniform')
    self.fc = tf.keras.layers.Dense(vocab_size)

    # used for attention
    self.attention = BahdanauAttention(self.dec_units)

  def __call__(self, x, hidden, enc_output):
    # enc_output shape == (batch_size, max_length, hidden_size)
    context_vector, attention_weights = self.attention(hidden, enc_output)

    print(context_vector.shape, 'c_v', attention_weights.shape, "attention_w")

    # x shape after passing through embedding == (batch_size, 1, embedding_dim)
    x = self.embedding(x)

    # x shape after concatenation == (batch_size, 1, embedding_dim + hidden_size)
    print(x.shape, 'xshape', context_vector.shape, 'context')
    expanded_dims = tf.expand_dims(context_vector, 1)
    x = tf.concat([expanded_dims, x], axis=-1)

    # passing the concatenated vector to the GRU
    output, state = self.gru(x)

    # output shape == (batch_size * 1, hidden_size)
    output = tf.reshape(output, (-1, output.shape[2]))

    # output shape == (batch_size, vocab)
    x = self.fc(output)

    return x, state, attention_weights

The snippet I used to generate the tflite file:
converter = tf.lite.TFLiteConverter.from_keras_model(partial_model)
tflite_model = converter.convert()

with tf.io.gfile.GFile('goog_nmt_v2.tflite', 'wb') as f:
f.write(tflite_model)

And this is the error log:
2020-06-29 01:16:38.290 8824-8824/com.example.inmt_offline E/AndroidRuntime: FATAL EXCEPTION: main
    Process: com.example.inmt_offline, PID: 8824
    java.lang.IllegalArgumentException: Internal error: Failed to run on the given Interpreter: tensorflow/lite/kernels/concatenation.cc:73 t->dims->data[d] != t0->dims->data[d] (8 != 1)
    Node number 84 (CONCATENATION) failed to prepare.

        at org.tensorflow.lite.NativeInterpreterWrapper.run(Native Method)
        at org.tensorflow.lite.NativeInterpreterWrapper.run(NativeInterpreterWrapper.java:158)
        at org.tensorflow.lite.Interpreter.runForMultipleInputsOutputs(Interpreter.java:343)
        at com.example.inmt_offline.MainActivity.runModel(MainActivity.java:207)
        at com.example.inmt_offline.MainActivity.access$400(MainActivity.java:30)
        at com.example.inmt_offline.MainActivity$1.onClick(MainActivity.java:83)
        at android.view.View.performClick(View.java:7870)
        at android.widget.TextView.performClick(TextView.java:14970)
        at android.view.View.performClickInternal(View.java:7839)
        at android.view.View.access$3600(View.java:886)
        at android.view.View$PerformClick.run(View.java:29363)
        at android.os.Handler.handleCallback(Handler.java:883)
        at android.os.Handler.dispatchMessage(Handler.java:100)
        at android.os.Looper.loop(Looper.java:237)
        at android.app.ActivityThread.main(ActivityThread.java:7814)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1068)

For Concat, every dims of inputs and output except axis should be the same.
The dim at axis of output is equal to the sum of all input dims at axis.
Could you printout the dims of the input in:
x = tf.concat([expanded_dims, x], axis=-1)

I tried to run the goog_nmt_v2.tflite, it seems to be OK.

@anuragshukla06
Is this still an issue.Please, close this thread if your issue was resolved.Thanks!


Eliminate Boost.UTF dependency

Use CATCH instead of the Boost.UTF for the test rig.  This will simplify user requirements, as well as reduce the complexity of the AppVeyor and Travis CI configurations.

Fixed in 2c997e5.

Kamino cloned this issue to demianmnave/CML


How to send the pdf back to the nodejs server?

I have a nodemailer server at the backend where I can attach a pdf file. Is there a way I can send the generated pdf to the backend?

Hi @Greensahil, hopefully our responses in #5 helped. As I mentioned there, I strongly recommend using a server-side solution - you can setup wkhtmltopdf on your server and call it using PHP/etc, it will produce better results than html2pdf.
Let me know if that resolves your issue, thanks!


The SDK cannot import my project

hi i want to ask
Where is the sdk .aar file?
Or how to import line sdk into my own project,
I followed the documentation teaching without success.
gratitude

Hi, @hong199906
You can refer to the new sample app about how to import the sdk library.

close due to no further information.


Wrong transliteration of letters "ъ" and "ь".

In the Bulgarian language, we have a letter "Ъ" (capital, U+042A) and "ъ" (small, U+044A). It sounds like mixture between "A" and "O" in English. Commonly it is transliterated as "A" or "a". Currently, the library transliterates it as "'", which is wrong and does not stand for any sound (phoneme).
The same issue is with letter "ь" (similar to Russian soft sign U+044C). It has no capital case and is always used before "о". Currently it also is transliterated as ' (wrong).
To do:

"Ъ" and "ъ" should be transliterated as "A" and "a"
"ь" should be skipped in any case without subsequent "o" and when it stands before "о", both letters, e.g. "ьо" should be transliterated as "yo"

Examples:
Петър -> Petar (now is Pet'r.)
България -> Balgariya (now is B'lgariya)
Кольо -> Kolyo (now is Kol'o)

AnyAscii transliterates individual characters with no additional context. These characters in Bulgarian are encoded the same as the soft and hard signs in Russian and are used by other languages also. As AnyAscii does not know the language a Cyrillic text is written in, it uses a Russian-focused transliteration.
Here are the transliterations used for all Cyrillic characters: https://github.com/anyascii/anyascii/blob/master/input/tables/cyrillic.tsv
If you know your Cyrillic text is Bulgarian you should use a Bulgarian-specific Romanization library/function first and then use AnyAscii after if it is still necessary.

Thanks for the answer @hunterwb .
I understand char-to-char strategy, but I think using "Russian-focused transliteration" is basically wrong. There are many languages that use Cyrillic (even Mongolia!) and there is no reason to use Russian as kind of "right" or "standard". Moreover, in translated text you get unpronounceable symbols and in the end you have kind of encoding, rather real transliteration.
IMHO, the purpose of transliteration is to allow someone who can't read given alphabet to use one that he can read. And (may be more important), to use non-latin litters in systems that support only ASCII (original 7-bit). From that perspective, using characters such ` ' " etc. isn't meet the goals of transliteration.
And by the way, St. Cyril (Cyrillic is named after him) has nothing in common with Russia and alphabet was introduced years before even Kiev was established. Matter of fact is that St. Cyril and Methodius are authors of Glagolitic script. Cyrillic was developed some 50 years after St. Cyril died, by unknown his disciple(s) in Second Bulgarian Empire. I understand that Russian is much more widely used, but that does not change the fact that Cyrillic was developed by Bulgarians, for the administrative and religious needs of the Bulgaria. Some Polynesian tribe may decide to use Greek alphabet, but that shouldn't change the meaning of Greek letters as they were developed for Greek language. Even that tribe by some coincidences have bigger population. The correct transliteration for ɑ (alpha) would be A, as Greeks always pronounced that letter.


Enabling and disabling zoom in Winforms

Hi,
I have a question about zooming: I can zoom a chart using mouse wheel, or I can drag with the mouse, while pressing the central button OR pressing SHIFT + left button.
My issue is: may I disable zooming with the mouse wheel, but keeping enabled the zooming by dragging?
I found in FormPlot.Configure the properties enableZooming and enableScrollWheelZoom and thought that setting the latter to false would make the trick; but, alas, it disable also the dragging.
Is there a way to solve my problem? I would be happy also having some advice to solve it by myself without make a mess (maybe placing then a PR... :) )

Hi @dprevato, it sounds like you wish to disable the mouse scrollwheel function while preserving all click-and-drag functions.
I just tested this, and if you run this configuration (without any other configuration) I think it gives you the effect you're looking for.
formsPlot1.Configure(enableScrollWheelZoom: false);

Let me know if I misunderstood your issue, or if this does the trick! 👍

Hi @swharden , I tried but I found that tha line does not disable zooming with the scrollwheel, but also disable it by dragging; with that disabled, no zoom at all :)

Issue closed, I will open another one more specific


Small bug.

Just realised it couldn't fit my full name when I died:(

Thanks for reporting, indeed it's on battlefield one, but I will fix it


add configFileOverride to code validator

Currently is it impossible to specify where the .validatorrc can be found with the codevalidator. This minor change will allow the user to specify where the .validaterc is.
Currently without this change is it difficult for us to use IBM validator as the .validaterc might not be in a parent repository. The use case in our case is that we want to upload both a open api spec and a .validaterc to a separate service that validates the open api spec.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

This is a good idea!
I'm going to fully review this in the next two days. I want to make sure to fully consider if we should provide docs/tests with this change.

A bit complicated to describe how to add a test, so I opened #331, which adds on to this initial PR!

#331 merged


Update Cargo.lock

Motivation

Solution

PR Checklist

[ ] Added Tests
[ ] Added Documentation
[ ] Breaking changes

LGTM, Did you manually change this?

nope, auto regenerated when I switched to main


[XI-6368] Enhance results page

Description
This PR enhances the results table by:

Commit 1: Introducing collapse/expand functionality for table rows. Truncates questions text to 1 line in the collapsed state
Commit 2: Including question's answers
Commit 3: Indicating the last user's answer

It also includes tests (commit 4) and improves the responsiveness (commit 5)
See mobile view

Decisions / Choices I made

Markdown styles are reset to maintain the same font size and for the collapsed state they adopt the paragraph style (no colors, font weight, underlines...)

collapsed
expanded

The Answers component has now a size "s" variant, where spacing is reduced.
To ensure there aren't elements with the same id in a page, we add a prefix the answers id.

Checklist

[x] All checks pass successfully
[x] All related commits are squashed together
[x] The changes are properly documented / the relevant documentation is updated (if applicable)
[x] Appropriate labels are added to this pull request

As discussed, let's try to implement without reusing the Answers component:

We don't need inputs here because we don't have any interaction anymore
Could just be a list in a new component with props

Color codes and text with "correct" / "incorrect" as before
Selections make it bold, aria-label (?) "selected" (?), or use dot or circle icon

Resulting duplication of CSS is fine
Check if using an <article> makes sense here: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/article


Key reader mode

It would be convenient if the command line tool could output the keycode (or alias) of key that user has just pressed. Then I can throw away the above char and just type something like khd -r (for read), press the keys and see what I need to put into the config file. Fish does something similar with fish_key_reader.

https://github.com/koekeishiya/cev

@dominiklohmann Thanks for the tip! I still think it would be ergonomic to have this included in the khd (+ ability to output modifiers and key aliases).


adds logo

Signed-off-by: Diana Lease<EMAIL_ADDRESS>

Coverage remained the same at 91.151% when pulling 2279683fecff0667f1aa5690dec2ebeb16e224b3 on mg-update-logo into 7ba6b8fc36be5a822f7d4339fa95254a6f09acf2 on master.


[WIP] Remove OwnershipMixin from ServiceTemplate model

https://bugzilla.redhat.com/show_bug.cgi?id=1335640

we have no set ownership screen in UI and self_service user behaviour was applied on ServiceTemplate model
add back ServiceTemplate to direct RBAC
now we can use tenant's ancestor strategy independently if self_service user is logged or not.

@miq-bot assign-label wip

@miq-bot add_label wip

@dclarizio Can you take a look at this change? The OwnershipMixin was removed from ServiceTemplate and `Service~ classes because there is no Ui available, as far as we can tell, for setting ownership on those objects. And, having the mixin included affects RBAC for those objects. So, this change fixes the reported  BZ and the original   BZ for which Libor made the first set of changes.

@dclarizio if you are OK I will add some others specs.

@lpichler We determined that it was working as designed. I've updated the BZ (https://bugzilla.redhat.com/show_bug.cgi?id=1335640) with that info. So this PR should not be merged. But, we will still need to roll back the first change for BZ https://bugzilla.redhat.com/show_bug.cgi?id=1296671 that removed ServiceTemplate from RBAC.


chore(deps): upgrade dependencies

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-main" workflow

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a6b9313) 100.00% compared to head (9f2c3e8) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #76   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines           53        53
  Branches        21        21
=========================================
  Hits            53        53

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Change to upd.exe and watchdog2 in inno installer for testing

Here you go @gabriel. Tested building an installer but haven't run it. Note you can build this on the jenkins machine by entering the client branch name in the build with parameters pate.

trying it out now on jenkins configed with branch

Can we make the watchdog2 log to a keybase.start.log file (that file name is convention we use and sent on log send):
keybase --log-file=%APPDATA%/Keybase/keybase.start.log --log-format=file -d ctl watchdog2
yes the args need to come before ctl watchdog2 since they are "global" options

Needed to merge with master to get latest stuff

OK check it

lg2m


Actually log foreign peer ID on connection upgrage fail

This fixes the absolutely useless error context added in d0cf82eca293fbc45b6325d5e54df633844cb49b.

bors r+


chore: update foundry-compilers to 0.3.13

I don't see any solutions to upgrade this particular file to version 0.3.13 in this repository.
https://github.com/matter-labs/foundry-zksync/blob/13497a550e4a097c57bec7430435ab810a6d10fc/Cargo.lock#L4546
This is exactly what is not a duplicate. https://github.com/matter-labs/foundry-zksync/issues/341 only fixed:
https://github.com/matter-labs/foundry-zksync/blob/13497a550e4a097c57bec7430435ab810a6d10fc/Cargo.toml#L141
@dutterbutter

As per @elfedy's comment, we moved to a custom fork (with the intent of merging with upstream eventually), so this isn't relevant anymore.


Get the status of the files downloaded or are in progress of downloading

I'm kind of annoyed by myself asking all these question which may be silly. Because I'm kind of new to rust. And thanks to people like you I find the community really helpful and kind. This time I want to ask about if it is possible to get the status of files which are in progress or even if I which files are downloaded like a vector of statuses 🤞🤔. So that I can show the child progress bar with the file name, or if you figure out that if we can disable child progress bars, then showing the currently downloading file name in the main progress bar. Thank you in advance man you did helped me a lot 🙏🙏

The with-report example shows one way to use the download report. That may help you a little.
However the report is only made available at the end of the download process. Returning the statuses as it goes might be possible, but that would require changing the Trauma design.


Added a property of mem

This looks generally useful to me.
Since the property doesn't have a trigger there's little change that it interferes with existing code.

I added this because it was needed to verify the stability of merge sort, which is in my other PR.


Using with lora

Hello,
I imagine I can't just monkeypatch the pww pipeline with loras. Can you point me to what exactly needs to be adjusted in this repo to make them compatible with your lora library.
Thank you for your help!

I guess you can trianed by LORA and "Mergigng Full model with LoRA and changing to original CKPT format" as described in his repo.
This results in ckpt in the original format and should be compatible with PwW as usual.


feat(SDK): implement internal Unity VR support

Unity supports basic VR functionality without the need for any
third party SDK. A new SDK bridge has been added that hooks into
this internal Unity VR support so VRTK can be used for any device
that Unity supports.
The InputManager has been update to have the default axis information
required for the axes on the controllers to work correctly.

There are still issues with this PR.
The velocity and angular velocity of the controllers isn't working correctly.
There seems to be a lot of lag when attempting to check the grip button press.


Possible to use multiple Reynolds number airfoil data?

I was browsing the documentation and saw that multiple Reynolds number airfoil data, and interpolation between these, is not yet supported. Is this in progress on a branch, or is there some discussion on what needs to be done, etc.?

This has been merged into OpenFAST/dev, so I think it can be closed, @rafmudaf.


[Alternity RPG] Add 5 missing Weapon Data rows and Function field to Computer programs

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

New Sheet Details

The name of this game is: <   >  (i.e. Dungeons & Dragons 5th Edition, The Dresden Files RPG)

The publisher of this game is: <   > (i.e. Wizards of the Coast, Evil Hat)

The name of this game system/family is: <   > (i.e. Dungeons & Dragons, FATE)

[x] I have followed the Character Sheets Standards when building this sheet.

[ ] This sheet has been made on behalf of, or by, the game's publisher.
[ ] This game is not a traditionally published game, but a copy of the game rules can be purchased/downloaded/found at: <   >
[ ] This sheet is for an unofficial fan game, modification to an existing game, or a homebrew system.

Changes / Description

Added 5 more Weapon Data rows to complete the changes made in #10457
Added Function field to Computer programs list to allow the player somewhere to detail what a program actually does

Character Sheet Info Roll20 Internal Use only.


Implement dplyr::lead() and dplyr::lag() functions

Your fantastic package motivated me to revisit Julia after more than 5 years of abstinence - please keep going :)
Would be great if Tidier.jl  could support the computation of lagged or leading values in data frames. For instance, for the typical financial application, I'd want to compute returns over different horizons like this:
using Tidier, MarketData

prices = yahoo(:AAPL, YahooOpt(period1 = DateTime(2020, 1, 1), period2 = DateTime(2021, 12,31))) |> DataFrame

prices = @chain prices begin
    @clean_names()
end

returns = @chain prices begin
    @arrange(timestamp)
    @mutate(ret1m = adj_close / lag(adj_close) - 1, ret12m = adj_close / lag(adj_close, 12) - 1)
end

I guess there is some workaround using ShiftedArrays.jl but I can't seem to make it work with my limited Julia experience 😞

Thank you @christophscheuch for the kind words and for the suggestion!
Can you try calling them with preceding tilde, like this: @mutate(ret1m = adj_close / ~lag(adj_close) - 1, ...
If that works let us know (and I can explain why). If not, I'll take a look. Agree that we should have this functionality natively supported with Tidier.jl, whether or not we can borrow the implementation from ShiftedArrays.jl.
I am also posting the dplyr implementation here as a placeholder in case we want to just base our implementation off of that: https://github.com/tidyverse/dplyr/blob/main/R/lead-lag.R
Key things for our implementation:

needs to handle missing values
need to add these functions to the do-not-vectorize list (which is why the ~ may be required at the moment).

Thanks for the quick response! So I tried the following to simply construct a lagged variable:
returns = @chain prices begin
    @mutate(adj_close_lag = ~lag(adj_close))
end

I get the following error messages:
ERROR: MethodError: no method matching lag(::Vector{Float64})
Closest candidates are:
  lag(::TimeArray{T, N, D, A} where {D<:TimeType, A<:AbstractArray{T, N}}) where {T, N} at C:\Users\...\.julia\packages\TimeSeries\vYT6q\src\apply.jl:9
  lag(::TimeArray{T, N, D, A} where {D<:TimeType, A<:AbstractArray{T, N}}, ::Int64; padding, period) where {T, N} at C:\Users\...\.julia\packages\TimeSeries\vYT6q\src\apply.jl:9

Unfortunately, I do not know anything about these array types in Julia, so I'm lost :/

Have no fear. We will look into this and sort it out!

Ok, I figured out the issue.
While the MarketData package exposes a lead() and lag() function for time series data, this is actually not the same lead() and lag() function inside of ShiftedArrays.jl.
And if you include using ShiftedArrays in your code, even this doesn't work because lead() and lag() aren't exported to the namespace (akin to package internal functions in R).
This pattern is a bit more common in Julia because it's intended to protect your namespace. You would still be able to access the non-exported functions by writing ShiftedArrays.lag() after writing using ShiftedArrays. This it the same reason why you have to type Pkg.add() to add a package (if not using the package manager console) even after typing using Pkg.
So tl;dr: here's a solution that will work for now. Add the following code to the top of your script:
using ShiftedArrays: lead, lag

Then, if you use ~lead() and ~lag() to reference them, this will work for now.
In an update in the near future, we'll directly add support for these functions within Tidier.jl and will remove the need for the tilde. The reason the tilde is needed for now is that Tidier.jl is "auto-vectorizing" lead() and lag(), which we don't want. You can read more about this here: https://kdpsingh.github.io/Tidier.jl/dev/examples/generated/UserGuide/autovec/
Adding the tilde to the front prevents this auto-vectorization. In the next update, we will add these functions to our "do-not-vectorize" list, which will remove the need for a tilde. Additionally, I plan to expose a function that will allow users to manually add functions to that list.

Indeed this works and I learned somethin - thanks a lot for the explanation! So for completeness, this code snippet now calcualtes returns :)
using ShiftedArrays: lag, lead
using Tidier, MarketData

prices = yahoo(:AAPL, YahooOpt(period1 = DateTime(2020, 1, 1), period2 = DateTime(2021, 12,31))) |> DataFrame

prices = @chain prices begin
    @clean_names()
end

returns = @chain prices begin
    @mutate(ret = adj_close / ~lag(adj_close) - 1, )
end

Note to self: I need to update the auto-vectorization docs to give an example when functions should not be auto-vectorized inside of @mutate(). This would be a good example of that, as would ntile().
While we will generally try to automate this, users need to understand this when using custom functions that have written inside of Tidier verbs.

This is now fixed in #82. lag() and lead() are re-exported from ShiftedArrays.jl. This implementation supports an optional argument to indicate how many values to shift by and includes an optional keyword argument to specify the default value to fill in instead of missing.
Both functions are now included in the do-not-vectorize list, so there's no more need to use a tilde.
I'll close this issue out after updating the docs for @mutate to include an example of lag/lead and updating the auto-vectorization page to explain when tildes should be used inside of user-created functions within @mutate().


GTR2 rendering issue d3d9

Please describe your issue as accurately as possible. If you run into a problem with a binary release, make sure to test with latest master as well.
With d3d9 after commit 338f6dfb0efe6536c5954ae0d6fba60809952da8 I see rendering issues, black areas in first screen grab, the second one is there for comparison.

Software information
Name of the game, settings used etc.
GTR2 d3d9
System information

GPU: nvidia 780ti
Driver: nvidia binary 460.56
Wine version: 6.2 staging
DXVK version:  latest git db69ade7e7a7d460fef8893d8bb5c1922fa8ba64
and a0cf5926d89a812b9932e793e34e036fe68c6230

Apitrace file(s)
to follow if required
Log files

d3d9.log:
GTR2_d3d9.log
GTR2_d3d9-working.log

d3d11.log:

dxgi.log:

Thanks for bisecting this. Please do provide that apitrace so we can reproduce the issue and try to fix it.

api trace
https://mega.nz/file/DggmAYYL#1ZkpyN_aKuyA2jh00LwAPvFg3ZYkzNilhjEtXdtpsjA
I didn't get any incorrect rendering with this is that expected ?

Did you drive to a spot where the issue usually shows up? The trace is very short and the majority of time is spent in the menu so I cant really see anything.

Yes I got as far as the end of the pit lane frame rate made the game uncontrollable. But there were black patches in the mid and far distance when I was running git latest. The issue is always in the mid to far distance.

alternate api trace using spectator cam. 2 laps on board with an ai car. Definitely shows black artefacts with affected dxvk versions.
https://mega.nz/file/rlgxFSwC#a1thLW43MuI1LjiRGNoL0jewS85x5HkjOaNfWqa6rR4

It's always on the kerbs and off to the sides never on track, don't know whether that helps at all.

Fixed.

Big thank you to the all who work on dxvk

<3


feat!: remove getUTXO & getAddressSummary rpc methods

Issue being fixed or feature implemented

getUTXO & getAddressSummary methods are deprecated. We don't need them anymore.
What was done?

Removed getUTXO & getAddressSummary rpc methods
How Has This Been Tested?

Unit tests
Breaking Changes

getUTXO & getAddressSummary rpc methods are removed
Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added or updated relevant unit/integration/functional/e2e tests
[x] I have made corresponding changes to the documentation

For repository code-owners and collaborators only

[x] I have assigned this pull request to a milestone

We blocked by https://github.com/dashevo/wallet-lib/pull/119


MNT: rerender

Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #10.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.

[ ] Bump the build number if needed

Fixes #10

@conda-forge-admin please rerender


add missing use for Encode and Decode traits

Hi, without this use i was getting:
error: cannot find derive macro `Decode` in this scope
 --> /home/fgimenez/workspace/substratekitties/runtime/src/substratekitties.rs:7:18
  |
7 | #[derive(Encode, Decode, Default, Clone, PartialEq)]
  |                  ^^^^^^

error: cannot find derive macro `Encode` in this scope
 --> /home/fgimenez/workspace/substratekitties/runtime/src/substratekitties.rs:7:10
  |
7 | #[derive(Encode, Decode, Default, Clone, PartialEq)]
  |          ^^^^^^

error[E0277]: the trait bound `substratekitties::Kitty<<T as srml_system::Trait>::Hash, <T as srml_balances::Trait>::Balance>: _IMPL_DECODE_FOR_Event::_parity_codec::Decode` is not satisfied
  --> /home/fgimenez/workspace/substratekitties/runtime/src/substratekitties.rs:15:1
   |
15 | / decl_storage! {
16 | |     trait Store for Module<T: Trait> as KittyStorage {
17 | |         OwnedKitty: map T::AccountId => Kitty<T::Hash, T::Balance>
18 | |     }
19 | | }
   | |_^ the trait `_IMPL_DECODE_FOR_Event::_parity_codec::Decode` is not implemented for `substratekitties::Kitty<<T as srml_system::Trait>::Hash, <T as srml_balances::Trait>::Balance>`

error[E0277]: the trait bound `substratekitties::Kitty<<T as srml_system::Trait>::Hash, <T as srml_balances::Trait>::Balance>: _IMPL_DECODE_FOR_Event::_parity_codec::Encode` is not satisfied
  --> /home/fgimenez/workspace/substratekitties/runtime/src/substratekitties.rs:15:1
   |
15 | / decl_storage! {
16 | |     trait Store for Module<T: Trait> as KittyStorage {
17 | |         OwnedKitty: map T::AccountId => Kitty<T::Hash, T::Balance>
18 | |     }
19 | | }
   | |_^ the trait `_IMPL_DECODE_FOR_Event::_parity_codec::Encode` is not implemented for `substratekitties::Kitty<<T as srml_system::Trait>::Hash, <T as srml_balances::Trait>::Balance>`

Thanks!

Thanks for the contribution!


Create a timeline

Add a list of all your activities, achievements, work experience. Add as much info as you can remember. In case you don't have working experience tell about your pet-projects or student projects. Don't be shy :)

I like to work on front-end projects. But I also like to create games, that's why I am seeking a full-stack career


[content-type] Change deprecation level of APPLICATION_JS to WARNING

Fixes #1837

Should we update the value of the old Enum too? So both set the ContentType to text/JavaScript which seems to be the newer standard? Would this be considered a breaking change or rather a fix?

I think that this class could be cleaned up in 6.x if needed as atm any change of those defaults could be considered as a little bit risky. Because it was approved, I'm reporting the fact that the latest change lead to incompatibility at sources level and I know that's something tipsy probably didn't want to do. We had similar case in the past and despite of several changes under the hood, we never decided to break the API.

Thanks, this was definitely not the intention 😞


go version: parse 1.6rc1

The current 'go version' in fedora rawhide is '1.6rc1'. This version
string doesn't get correctly parsed by the configure script and it
terminates saying, "configure: error: *** go is too old (go version
go1.6rc1 linux/amd64".
This fixes the parsing to accept several version format. Tested with:

go version go1.5.3
go version go1.5
go version go1.6rc1

Based on a patch from: Lokesh Mandvekar<EMAIL_ADDRESS>Closes https://github.com/coreos/rkt/pull/2056

/cc @lsm5
I didn't change the preferred version 1.5.

Merging it despite the failure on semaphore. It is clear that configure checks passed and the failure is unrelated.


ClassyFire Server Down

Hi,
the ClassyFire server connected to GNPS and used by your script (posted on the following page https://pypi.org/project/pybatchclassyfire/ and redirecting to this GitHub repository) is down:
https://gnps-classyfire.ucsd.edu
Can you fix this?
Find attached the txt version of the script, with the the link to the server inside.
pybatchclassyfire.txt
Thanks

When making query requests I'm getting internal server errors, and similarly through the web portal the classification doesn't seem to be working still.
However, making individual queries with e.g. r = requests.get('http://classyfire.wishartlab.com/entities/%s.%s' % (inchikey, return_format),                      headers={                          "Content-Type": "application/%s" % return_format})
seems to work.


Update did:jwk resolve test vectors

Added README to describe inputs and outputs of did:jwk test vectors
Removed didResolutionResult from output. Inclusion of this property left room to believe that the resolve implementations should contain a literal didResolutionResult property
added didDocumentMetadata to output where missing. Note: on success, this will always be an empty object for did:jwk
added didResolutionMetadata to output where missing. Note: on success, this will always be an empty object for did:jwk

great point @decentralgabe we should definitely do that. will update the PR to reflect

Do we want to consider canonicalizing the public key before Base64URL encoding?
per the spec:

Canonicalization such as JCS is not required but may be helpful if the resulting DID isn't going to be stored in its serialized form.

Do we want to consider canonicalizing the public key before Base64URL encoding?
per the spec it is optional:

Canonicalization such as JCS is not required but may be helpful if the resulting DID isn't going to be stored in its serialized form.

I thought that would be part of creation, but I believe this PR is only for resolution

Do we want to consider canonicalizing the public key before Base64URL encoding?
per the spec it is optional:

Canonicalization such as JCS is not required but may be helpful if the resulting DID isn't going to be stored in its serialized form.

I thought that would be part of creation, but I believe this PR is only for resolution

It is but this PR's resolution results are based on not-canonicalizing the public key.  As a result, if a web5-* implementation does canonicalization it will fail this vector.

Do we want to consider canonicalizing the public key before Base64URL encoding?
per the spec it is optional:

Canonicalization such as JCS is not required but may be helpful if the resulting DID isn't going to be stored in its serialized form.

I thought that would be part of creation, but I believe this PR is only for resolution

It is but this PR's resolution results are based on not-canonicalizing the public key. As a result, if a web5-* implementation does canonicalization it will fail this vector.

I'm a bit confused still, hoping you can help me understand.
Are you suggesting that resolution should canonicalize the encoded JWK before putting it in the did document? I.e. something like the following
resolve("did:jwk:<foo>").didDocument.verificationMethod[0].publicKeyJwk == canonicalize(decode64url("<foo>"))

Canonicalization was removed from the latest draft, so I would advise against it https://github.com/quartzjer/did-jwk/pull/21/files

Canonicalization was removed from the latest draft, so I would advise against it https://github.com/quartzjer/did-jwk/pull/21/files

Excellent insight!   Thanks @decentralgabe.  Makes the decision easy.

updated vectors to include supported cryptographic algorithms - secp256k1 & Ed25519


waiting for SSH timeout

Hi, tried the faster-bootstrap option with packer, and it cannot connect to the EC2 via SSH.
I verified the AWS account, the packer key was created during the process.
bash build-ami.sh -6 -a "ami-3548444c hvm root /dev/sda1" eu-west-1 centos75 "Centos75_CDH6_v1"
Found packer version: Packer v1.3.1
Using AMI ami-3548444c for OS centos75
amazon-ebs output will be in this color.

==> amazon-ebs: Prevalidating AMI Name: Centos75_CDH6_v1<PHONE_NUMBER>
    amazon-ebs: Found Image ID: ami-3548444c
==> amazon-ebs: Creating temporary keypair: packer_5bb206bc-135a-7f5a-5712-714372ff9080
==> amazon-ebs: Creating temporary security group for this instance: packer_5bb206bd-45ac-3adb-cbf2-7f661dff62b6
==> amazon-ebs: Authorizing access to port 22 from <IP_ADDRESS>/0 in the temporary security group...
==> amazon-ebs: Launching a source AWS instance...
==> amazon-ebs: Adding tags to source instance
    amazon-ebs: Adding tag: "Name": "Packer Builder"
    amazon-ebs: Instance ID: i-04c1d16a17f8a63c9
==> amazon-ebs: Waiting for instance (i-04c1d16a17f8a63c9) to become ready...
==> amazon-ebs: Using ssh communicator to connect: <IP_ADDRESS>
==> amazon-ebs: Waiting for SSH to become available...
==> amazon-ebs: Timeout waiting for SSH.
==> amazon-ebs: Terminating the source AWS instance...
==> amazon-ebs: Cleaning up any extra volumes...
==> amazon-ebs: No volumes to clean up, skipping
==> amazon-ebs: Deleting temporary security group...
==> amazon-ebs: Deleting temporary keypair...
Build 'amazon-ebs' errored: Timeout waiting for SSH.

Any ideas what is wrong with the input parameters? Thanks

Resolved by setting the correct VPC and subnet ID's


Unable to save more than two watch-only/xpub accounts

I'm doing a watch-only wallet with five accounts. Every account has its own xpub.
When I add the third account and exit and reopen the wallet, the second account has vanished.
Here are my steps for reproduction:
Create New Wallet
Settings Single Signature / Native Segwit
Script Policy (wpkh(Account1)
Keystore 1 - Xpub Watchonly Wallet
Label - Account1
Master fingerprint 00000000
Derivation m/84/0'/0'
xpub: xpub....firstaccountsxpub
Apply ...  Labeled from Account#0 - Account#2
After Closing Account#1 has vanished again
Give it a third try.
When coming to the third account:
Choose an account to add -- Account#1 ==> Leads to Account#1=Account#2
Hope that helps to find the error.

Thanks for the bug report! Fixed in ee992b7.


Openlayer 4.4.1 GeoJSON VT mapInteraction select problem

Hi,  I have project
I try OL 4.4.1 with geoJSON VT,

but when select feature only partially, not all
many duplicate label

example http://<IP_ADDRESS>:8111/gis_v2/
example selectlayer: Batas Kecamatan Sukoharjo
please help me
thank you

This is all expected and due to the nature of vector tiles.
You can improve selection by relying on ol.Feature#getId() instead of using ol.interaction.Select if same features have same ids on different tiles. You could avoid duplicate labels by adding label points to your vector tiles, instead of labeling polygons directly.

Can you give me example using improve selection by relying on ol.Feature#getId()

See https://github.com/openlayers/openlayers/issues/5248#issuecomment-211878312.

I have this:
`        vectorLayer[iddata] = new ol.layer.VectorTile({
source: sumber,
style: function(feature, resolution) {
var myStyle = new ol.style.Style({
placement: "point",
textAlign: "center",
textBaseline: "middle",
fill: new ol.style.Fill({
color: feature.get("fill_color")
}),
stroke: new ol.style.Stroke({
color: feature.get("stroke_color"),
width: 1
}),
text: new ol.style.Text({
text: resolution < 30 ? feature.get(datalabel) : "",
font: "12px Arial",
fill: new ol.style.Fill({
color: "#F7DA1A"
}),
stroke: new ol.style.Stroke({
color: "#333",
width: 2
}),
textAlign : "center",
})
});
return myStyle;
}
    });`

@antochoy, you should add the code in singleclick event.
vectortileLayer.change();
The change method will render again.


DOM elements added outside of preact gets removed on re-render

Hello. I've been trying to replace React / React-DOM with preact / preact-compat on an existing project of mine. This project uses react-mdl fpr the UI. Everything works fine, however, there's an issue with the drawer button.
The button is added after the page is rendered by material-design-lite's own JS. Because of that, if there's a state change that triggers a re-render for the parent of that element, preact removes it. This does not happen with React, however.
I believe this is kind of like #39 and #405 from preact.
I made a small demo reproducing the bug. You can get it here. Just npm install and npm start (uses webpack-dev-server).
PS: I realize this can be worked around by isolating the component and making sure it never re-renders, but I'm reporting since I believe this could improve preact-compat compatibility with other React projects.
Thanks for the great work!

There is preact-mdl which you might want to use
But preact shouldn't remove any dom elements not added by it since version 7

@ForsakenHarmony I'm aware of preact-mdl, but this is an existing project. I'll probably migrate someday, but not today :) Thanks for the heads-up.
Yeah, I read that on one of the bug reports, however I believe it still happens in this case.

Since I'm not familiar with the inner workings, I'd welcome a more detailed explanation of what's happening if you're willing to shed some light on the issue. But, if you think it's a bit out of reach to fix right now, I'll work around it or slowly migrate to preact-mdl.
Thanks!

Hmm - it looks like react-mdl have a pretty specific fix for this that involves actually modifying the MDL source: https://github.com/react-mdl/react-mdl/commit/36b40dfb51eea887d5b1bdcb6ad21eb5f05f40a3
Discussion here: https://github.com/react-mdl/react-mdl/issues/143
Not sure why those wouldn't work in Preact, nothing is really different there..


Updating dependencies

:tada: This PR is included in version 2.2.5 :tada:
Your semantic-release bot :package::rocket:


Help with ExtData Template

Received an email about ExtData from Mariusz Pagowski (@mpagowski) of NOAA

I work at NOAA with a model called UFS-Aerosols which is derived from NASA's GOCART2G. I am trying to make the model read (emission) files at hourly intervals
coded in ExtData.rc . I followed a template used for 24h interval and changed it from
# -------------|-------|-------|--------|----------------------|--------|--------|-------------|----------|
#  Import      |           |          | Regrid  |        Refresh            | OffSet | Scale  | Variable On |   File   |
#  Name       | Units | Clim  | Method |     Time Template    | Factor | Factor |     File          | Template |
# -------------|-------|-------|--------|----------------------|--------|--------|-------------|----------|

...

BC_ANTEBC1 NA  N Y %y4-%m2-%d2t12:00:00 none none BC       ExtData/nexus/CEDS/v2019/%y4/CEDS.2019.emis.%y4%m2%d2.nc

to
BC_ANTEBC1 NA  N Y %y4-%m2-%d2t%h2:00:00 none none BC       ExtData/nexus/CEDS/v2019/%y4/CEDS.2019.emis.%y4%m2%d2%h2.nc

plus other attempts with _%h2%n2 etc. but failed to solve the problem as the code crashes and I cannot decipher the correct format.
First, will the code read consecutive emission files every 24 hours for forecasts longer than a day when configured as in the original formulation above?
Or read only initially for the first hour and keep emissions constant forever. Then, is it possible to make the code read emissions at hourly intervals during a forecast
and how to format it properly?
I asked at NOAA but did not find a solution.

@mpagowski Was this ever fixed/solved for you?

Yes, I understand how it works
On Fri, Sep 22, 2023 at 6:07 AM Matthew Thompson @.***>
wrote:

@mpagowski https://github.com/mpagowski Was this ever fixed/solved for
you?
—
Reply to this email directly, view it on GitHub
https://github.com/GEOS-ESM/MAPL/issues/2250#issuecomment-1731386964,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFOU6SYTCQBBUMRE653RYYDX3WERTANCNFSM6AAAAAA2TM6TCI
.
You are receiving this because you were mentioned.Message ID:
@.***>


Undefined content

Versions prior to 2.0 return “Undefined” as section titles:

No you're out of order!
jk, I'll fix that


Receive Telegram messages using async long polling

Description:
Receive Telegram messages using async long polling
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Checklist:
If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

@balloob Thanks for reviewing. This is a good learning experience (... and I have a lot to learn..)... I will walk through all your suggestions as soon as I get to it.
@scipioni I am going to change this according Balloob's suggestions. However, I am not able to do the webhook testing part. Are you willing to help me out here as soon as I have updated the code ?


#4 and #5 Completed

@rultor merge

@rultor merge

@driver733 OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@driver733 Oops, I failed. You can see the full log here (spent 2min)
Your branch is up-to-date with 'origin/master'.
+ '[' true == true ']'
+ git checkout __rultor
Switched to branch '__rultor'
Your branch is up-to-date with 'fork/#4'.
+ git rebase master
First, rewinding head to replay your work on top of it...
Applying: #4 and #5 Completed
Using index info to reconstruct a base tree...
M	src/main/java/com/driver733/vkmusicuploader/post/UploadVerification.java
M	src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/AttachmentCachedAudio.java
M	src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/AttachmentWallPhoto.java
M	src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/CachedAudioAddQuery.java
Falling back to patching base and 3-way merge...
Removing src/test/java/com/driver733/vkmusicuploader/wallpost/attachment/support/mp3filefromfile/basictag/package-info.java
Removing src/test/java/com/driver733/vkmusicuploader/wallpost/attachment/support/mp3filefromfile/basictag/BasicTagTest.java
Removing src/test/java/com/driver733/vkmusicuploader/wallpost/attachment/support/mp3filefromfile/advancedtag/package-info.java
Removing src/test/java/com/driver733/vkmusicuploader/wallpost/attachment/support/mp3filefromfile/advancedtag/AdvancedTagFromMp3FileTest.java
Removing src/test/java/com/driver733/vkmusicuploader/wallpost/attachment/support/message/MessageTest.java
Removing src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/support/mp3filefromfile/bytearray/package-info.java
Removing src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/support/mp3filefromfile/bytearray/fallback/package-info.java
Removing src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/support/mp3filefromfile/advancedtag/package-info.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/support/TransportClientCached.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/support/CachedAudioAddQuery.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/mp3filefromfile/package-info.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/mp3filefromfile/bytearray/fallback/package-info.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/mp3filefromfile/bytearray/fallback/FallbackByteArrayImage.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/mp3filefromfile/bytearray/fallback/Fallback.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/mp3filefromfile/bytearray/ByteArrayImageFromFile.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/mp3filefromfile/bytearray/ByteArrayImageFromAdvancedTag.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/mp3filefromfile/bytearray/ByteArray.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/mp3filefromfile/basictag/BasicTagFromMp3File.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/mp3filefromfile/basictag/BasicTag.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/mp3filefromfile/advancedtag/package-info.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/mp3filefromfile/advancedtag/AdvancedTagVerifiedAlbumImage.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/mp3filefromfile/advancedtag/AdvancedTagFromMp3File.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/mp3filefromfile/advancedtag/AdvancedTag.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/message/package-info.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/message/messagepart/package-info.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/message/messagepart/ID3v1AnnotatedSafe.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/message/MessageBasic.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/message/Message.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/AttachmentWallPhoto.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/AttachmentCachedAudio.java
Auto-merging src/main/java/com/driver733/vkmusicuploader/post/UploadVerification.java
Applying: #4 and #5 Completed
Using index info to reconstruct a base tree...
M	src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/support/CachedAudioAddQuery.java
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/support/CachedAudioAddQuery.java deleted in #4 and #5 Completed and modified in 6dbcfc34c0529edb0ac87e48e3795fb1a2ce7500. Version 6dbcfc34c0529edb0ac87e48e3795fb1a2ce7500 of src/main/java/com/driver733/vkmusicuploader/wallpost/attachment/support/CachedAudioAddQuery.java left in tree.
error: Failed to merge in the changes.
Patch failed at 0002 #4 and #5 Completed
The copy of the patch that failed is found in: .git/rebase-apply/patch

When you have resolved this problem, run "git rebase --continue".
If you prefer to skip this patch, run "git rebase --skip" instead.
To check out the original branch and stop rebasing, run "git rebase --abort".

'cid' file is absent, container wasn't started correctly

Coverage increased (+1.9%) to 21.234% when pulling d843bc5b046718bdb4400592fca826d8ecaaef17 on #4 into 0820c7d72569ffa9fcfba7a487567c1609ad040d on master.


Fix all GraphML Issues

 Issue by jexp
Sunday Jun 24, 2018 at 21:53 GMT
Originally opened as https://github.com/neo4j-contrib/neo4j-apoc-procedures/issues/840

[x] https://github.com/neo4j-contrib/neo4j-apoc-procedures/issues/775

[x] https://github.com/neo4j-contrib/neo4j-apoc-procedures/issues/721

[x] https://github.com/neo4j-contrib/neo4j-apoc-procedures/issues/567

[x] https://github.com/neo4j-contrib/neo4j-apoc-procedures/issues/556

[x] https://github.com/neo4j-contrib/neo4j-apoc-procedures/issues/548

[x] https://github.com/neo4j-contrib/neo4j-apoc-procedures/issues/546

[x] https://github.com/neo4j-contrib/neo4j-apoc-procedures/issues/489

[x] https://github.com/neo4j-contrib/neo4j-apoc-procedures/issues/478

[x] https://github.com/neo4j-contrib/neo4j-apoc-procedures/issues/466

[x] https://github.com/neo4j-contrib/neo4j-apoc-procedures/issues/438

[x] https://github.com/neo4j-contrib/neo4j-apoc-procedures/issues/206

[x] https://github.com/neo4j-contrib/neo4j-apoc-procedures/issues/139

@ncordon if this is fixed, what version of neo-4j would it show up in.  Currently have  issue https://github.com/neo4j-contrib/neo4j-apoc-procedures/issues/478 (see above) in neo4j Version 1.5.0 (<IP_ADDRESS>)


Question again: Can I combine different backup files (.bck)?

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
I have two backup files (bck) with different periods.
Can these two be restored to one teslamate?
The teslamate1.bck file that I backed up from 2021-2022 (700mb)
There is a teslamate2.bck file that backed up data from 2022-2023 by installing teslamate again.
I installed a new teslamate and restored teslamate1.bck 1 bck as guided.
Restored normally.
After that, execute the following command for another period of bck file.
So how to finish that? Thanks!
Expected Behavior
No response
Steps To Reproduce
No response
Relevant log output
none

Screenshots
No response
Additional data
No response
Type of installation
Docker
Version
v.1.27.3

I'm not a maintainer, but I think you'd get more help if you posted this as a Discussion on this repo since this isn't an issue/bug with Teslamate.

I'm not a maintainer, but I think you'd get more help if you posted this as a Discussion on this repo since this isn't an issue/bug with Teslamate.

Ok thanks, I've start a new discussion because I found the previous discussion had no solution.


error during installation

Describe the bug
When installing the softare using pip install upgrade I get the following error:
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
hologram 0.0.15 requires jsonschema<4.0,>=3.0, but you have jsonschema 4.17.3 which is incompatible.
To Reproduce
Steps to reproduce the behavior:

Python version 3.10.8 dbt version 1.4.5
run pip install dbterd --upgrade

Expected behavior
installation without errors

Hi @marcNY thanks for raising this up!
For the initial check, I think that looks like an issue with dbt core 1.4 top pin dependencies has been impacting to the 3rd party tools so far.
dbt core 1.4.6 should resolve it. Can you try to upgrade your dbt to 1.4.6 now, and try the installation again. I will look into it deeper if it's sill persisted. Thanks

Hi @marcNY just wanted to check if the issue was still happened?

Closed as inactive


Error window emerge when try to add a vocabulary translate

I'm mapping some datasets to publish but when clicking in the option for translation in the dcterms:type (Just for proving) send the error window I show below:

with the dcterms: description was no problem.

Thank you for reporting this bug @RicardoOrtizG. We'll fix it


Test to keep scaling and DA-BEAT projects in sync

Resolves L2B-7838

We have to wait until fluence, fraxtal, oevnetwork and apechain have corresponding DA-BEAT entries assigned ;p


The build is broken

In master.
#132 is some progress: it updates the URL of BrowserMob Proxy. (10 out of 44 tests fail there too, though; probably because of updated npm packages. I can look into that once master is fixed.)

(…or @dontcallmedom :)

just answered on #132 :))


Page updates fail when page properties are read only.

Submitting page changes breaks when the page contains properties that are read only, such as formula and created_by.
Version: HEAD
Traceback (most recent call last):
  File ".../notional/examples/props.py", line 40, in <module>
    notion.pages.update(page)
  File ".../notional/notional/session.py", line 249, in update
    data = self().update(page.id.hex, **diff)
  File ".../notional/.venv/lib/python3.9/site-packages/notion_client/api_endpoints.py", line 164, in update
    return self.parent.request(
  File ".../notional/.venv/lib/python3.9/site-packages/notion_client/client.py", line 155, in request
    return self._parse_response(response)
  File ".../notional/.venv/lib/python3.9/site-packages/notion_client/client.py", line 111, in _parse_response
    raise APIResponseError(response, body["message"], code)
notion_client.errors.APIResponseError: body failed validation. Fix one: body.properties.Created By.title should be defined, instead was `undefined`. body.properties.Created By.rich_text should be defined, instead was `undefined`. body.properties.Created By.number should be defined, instead was `undefined`. body.properties.Created By.url should be defined, instead was `undefined`. body.properties.Created By.select should be defined, instead was `undefined`. body.properties.Created By.multi_select should be defined, instead was `undefined`. body.properties.Created By.people should be defined, instead was `undefined`. body.properties.Created By.email should be defined, instead was `undefined`. body.properties.Created By.phone_number should be defined, instead was `undefined`. body.properties.Created By.date should be defined, instead was `undefined`. body.properties.Created By.checkbox should be defined, instead was `undefined`. body.properties.Created By.relation should be defined, instead was `undefined`. body.properties.Created By.files should be defined, instead was `undefined`.

Currently, updating pages simply grabs the page properties and submits them back...  The API doesn't like when those properties are view only.
Possible options:

Find a way to filter specific data types in the property export.
Track changed properties and only send those.
Require caller to specify which properties to update.


Script to build docker images locally

I was following the instructions to build the docker file locally by following the tutorial on here.
However the command for docker build was failing. I noticed failures in building the docker files for all available runtimes. The reason being the expected dependent files/folders were not available in the docker context. The Gradle builds would essentially pass as they are copying the dependencies before building the docker. For example https://github.com/apache/openwhisk-runtime-python/blob/master/core/python3Action/build.gradle#L25
To solve this problem, I had brainstormed multiple solutions, I came up with this one as it does not affect any dependencies on the dockerfile. The gradle builds should be able to pass as they were earlier.
Solution:

Create a script that would take in two arguments

Runtime folder name - The runtime that needs to be built
Docker Image tag - Name of the docker image

Example command ./tutorials/local_build.sh -r python3Action -t action-python-v3.7:1.0-SNAPSHOT

The script tries to mimic the Gradle files by copying the dependent folder/files, building the docker file and then deleting the dependent folders/files. I have updated the tutorial document with the same instructions. This PR would help anyone trying to build the runtime images locally.

@meenakshimadugula95 Apart from specific review comments... Could we also, in this PR, update the top-level README to better inform people what they will find when referencing the "Docker" build path and also perhaps simplify (correct) the "two ways to build" section which is confusing IMO.

@mrutkows thank you for the comments. I have modified the tutorial file so that it is better structured and easily readable. Please review this while I edit the top level readme.

I have correct the top level readme to reflect the two option to build python runtimes. Please take a look and review