Script error - Collection was modified; enumeration operation may not execute.

Hi,
I have a function, which performs following tasks:

fetches data from a queue
deserializes it and pushes to a storage table
pushes raw data to another storage table

function.json file looks like following:
{
  "scriptFile": "MyFunction.dll",
  "entryPoint": "MyFunction.Run",
  "disabled": false,
  "bindings": [
    {
      "name": "myQueueItem",
      "type": "queueTrigger",
      "direction": "in",
      "queueName": "eventAggregator",
      "connection": "StorageConnectionString"
    },
    {
      "tableName": "deviceEvent",
      "connection": "StorageConnectionString",
      "name": "deviceEventTable",
      "type": "table",
      "direction": "out"
    },
    {
      "tableName": "eventLog",
      "connection": "StorageConnectionString",
      "name": "eventLogTable",
      "type": "table",
      "direction": "out"
    }
  ]
}

and this function code:
public class DeviceEventProcessor
    {
        private static CloudTable _deviceEventTable;
        private static ICollector<EventLog> _eventLogTable;
        private static TraceWriter _log;

        public static void Run(string myQueueItem,
            CloudTable deviceEventTable,
            ICollector<EventLog> eventLogTable,
            TraceWriter log)
        {
            _log = log;
            _deviceEventTable = deviceEventTable;
            _eventLogTable = eventLogTable;

            _log.Trace(new TraceEvent(TraceLevel.Info, $"Processing {myQueueItem} item."));
            EventAppeared(myQueueItem);
        }

        private static void EventAppeared(string @event)
        {
            _log.Trace(new TraceEvent(TraceLevel.Info, "Deserializing entity..."));

            var data = JsonConvert.DeserializeObject<DeviceEvent>(@event);
            var pk = $"{ClearLocationName(data.Name)}_{data.Sn}";
            data.PartitionKey = pk;
            data.RowKey = $"{DateTime.MaxValue.Ticks - DateTime.Parse(data.Date).Ticks:D19}";

            // Table Storage doesn't support int[] so we have to convert
            // values to one of supported types
            data.DetailedValues = string.Join("|", data.Values);

            _log.Trace(new TraceEvent(TraceLevel.Info, $"Adding entity with PK {data.PartitionKey} and RK {data.RowKey} with values {data.Values}"));
            var operation = TableOperation.InsertOrReplace(data);
            _deviceEventTable.Execute(operation);

            _log.Trace(new TraceEvent(TraceLevel.Info, "Inserting event log"));
            _eventLogTable.Add(new EventLog
            {
                Event = @event,
                PartitionKey = pk,
                RowKey = DateTime.Now.Ticks.ToString()
            });

            _log.Trace(new TraceEvent(TraceLevel.Info, "Event added"));
        }

        internal static string ClearLocationName(string name)
        {
            var disallowedChars = new[]
            {
                '#', '!', '@', '`', '~', '$', '%', '^', '&', '*', '(', ')', '+', '=', '{', '}', '[', ']', ':', ';',
                '\'', '"', '<', '>', ',', '.', '?', '/', '|', '\\'
            };

            if (name.IndexOfAny(disallowedChars) == -1) return name;

            return disallowedChars.Aggregate(name, (input, @char) => input.Replace(@char.ToString(), string.Empty)) + "_2";
        }
    }

Now where the problem is - I have Application Insights integrated with this function. Each call generates following

error:A ScriptHost error has occurredError while handling parameter eventLogTable after function returned:Collection was modified; enumeration operation may not execute.

with the following trace:

Microsoft.Azure.WebJobs.Host.FunctionInvocationException
[no stack frames available]
System.InvalidOperationException
Microsoft.Azure.WebJobs.Host.Executors.FunctionExecutor+d__22.MoveNext
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
Microsoft.Azure.WebJobs.Host.Executors.FunctionExecutor+d__20.MoveNext
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd
Microsoft.Azure.WebJobs.Host.Executors.FunctionExecutor+d__14.MoveNext
Inner exception System.InvalidOperationException handled at Microsoft.Azure.WebJobs.Host.Executors.FunctionExecutor+d__22.MoveNext
System.ThrowHelper.ThrowInvalidOperationException
System.Collections.Generic.Dictionary2+Enumerator.MoveNext Microsoft.Azure.WebJobs.Host.Tables.TableEntityWriter1+d__11.MoveNext
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
Microsoft.Azure.WebJobs.Host.Bindings.AsyncCollectorValueProvider`2+d__9.MoveNext
System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification
System.Runtime.CompilerServices.TaskAwaiter.ValidateEnd
Microsoft.Azure.WebJobs.Host.Executors.FunctionExecutor+d

I tried to create a repro, but it didn't work - I guess it's because I created not enough traffic. What is more - I see this exception in Application Insights but function is executed successfully and all rows are inserted into Table Storage.

So this looks like a hard to repro race condition

The problem is that you've got static variables that you are assigning to within the body of your function. These will get overwritten by subsequent function executions. Instead of using static variables, pass all the state through arguments to your helper functions.

@paulbatum Gosh, now when you pointed this out it makes perfect sense. Thank you for help!


Hotfix/1.2.2

Changes proposed in this pull request:

Force one approval at a time for investment approvals. #UI-417
Blocks invalid chars in text input type=number so that numbers like 1e-2 can't be input. #UI-394
Fix locales for price impact checkbox. #UI-517
Fix price impact text overflow bug. #UI-517

Also fixes #UI-394 & #UI-517


No Login available

Hello, first of all, great project.
I have the following problem, I installed everything as described, I can't create a user and I can't log in.
Do I have to set up a mail server? Is that necessary?
thank you very much for the help.

psql (16.1, server 16.2 (Debian 16.2-1.pgdg110+2))
Type "help" for help.
postgres=# SELECT * FROM app_settings;
ERROR:  relation "app_settings" does not exist
LINE 1: SELECT * FROM app_settings;
^
postgres=# UPDATE app_settings
postgres-#     SET
value = 'new_value'
WHERE name = 'app.email_server';    SET
postgres-#         value = 'new_value'
WHERE name = 'app.email_server';        value = 'new_value'
postgres-#     WHERE name = 'app.email_server';    WHERE name = 'app.email_server';
ERROR:  relation "app_settings" does not exist
LINE 1: UPDATE app_settings
^
postgres=#

Your SQL command are not under the signalk database. If you need help you might need to provide more details. Also a cloud version is available if you prefer.

I noticed that too and fixed it.
but I still can't log in or create an account. Did I create the login data in the .env and overlook it?
Thanks

You need to provide more details. what do mean by you can't login to what where how?

hej,
The frontend via port HTTP/8080 is reachable.
but can't create users or log in.
I hope you can help me find my mistakes.
is there a default user?

If you can't register a new user, you have some wrong environment set.
I updated the documentation with diagram, please check it out and see if it help.
To debug the front-end, in your browser open the devtool and check the network activity to the API url.

Let me know if you made any progress, and if you could make a guide it would be awesome. Thanks
feel free to join on discord

I'm still trying it out.
Unfortunately I haven't been able to create an account to log in yet. I'm currently trying to set up SMTP with Gmail.
see us on discord.


update blogs

after https://github.com/WindowsGeekPro/workaholic-meow/issues/10

and also after https://github.com/WindowsGeekPro/workaholic-meow/issues/17

Finished https://github.com/WindowsGeekPro/workaholic-meow/issues/10 :+1:

LOL... oops.. already finished https://github.com/WindowsGeekPro/workaholic-meow/issues/17 -- Hmm... Already pushed milestones for articles... So, closing this issue!


Add GUMS migration instructions

https://opensciencegrid.github.io/docs-itb/security/lcmaps-voms-authentication/#migrating-from-gums
@edquist let me know if I missed anything about how the script is being called

I'm on the fence about including the output since we generally shy away from it in our docs
Hopefully the difference between GUMS hosts and clients are clear in the instructions

@matyasselmeci ready for re-review


Could not find module when attempting to use vertical-collection

Hi, I just installed via ember install smoke-and-mirrors, created a simple vertical-collection in a template, but on load I receive the following error:

Not sure how to tackle this one, is the Ember version too old ?

Looks like ember-cli version was too old (0.2.7), bumping up to 2.3.0 fixed this issue.


License Information

Hi! Thank you so much for sharing this code. Can you please include the license information so that we know the restrictions/limitations if there are any?

Thanks for your interest in our work! We will include a license in the next release. In general, feel free to use our code an models for research purposes.


Question on Gap Detection/NACK

Hi, I would like to understand why a PublicationImage only scans for Gaps from the rebuildPosition up to the first gap detected. For instance, it could report all the gaps from the rebuildPosition up to the high water mark position.
By stopping the gap scan to the first gap, it does prevent multiple NACK to be sent which in increases the recovery time.

Few inter-related reasons.

It optimizes the common case of a single loss or a burst loss that is multiple datagrams in a row.
that gap must be recovered before data reception on that stream can resume, and
loss for multicast endpoints must also add delay to avoid self-similar behavior and eventual storms.

Doing more than a single gap at a time optimizes the wrong things for a low latency system. In most cases, if you have more than a single loss event in an RTT in such systems, you have other problems than recovery time to deal with.

I understand your design decision. Thank you very much for the detailed explanations.


Modules with path still can't be formatted on Windows

#1754 issue is still occuring.
I tried cargo fmt on my tokio checkout and I get several errors like following:
error: couldn't read \\?\D:\tokio\tokio-sync\tests\..\src\mpsc\list.rs: The filename, directory name, or volume label syntax is incorrect. (os error 123)
  --> \\?\D:\tokio\tokio-sync\tests\fuzz_list.rs:14:5
   |
14 | mod list;
   |     ^^^^

code for above is:
#[path = "../src/mpsc/list.rs"]
#[allow(warnings)]
mod list;

Can you try the changes in https://github.com/rust-lang/rustfmt/pull/3590 and see if that fixes your problem ? Looks like it doesn't for some users...

It is not building:
   --> /home/95th/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_target-407.0.0/abi/mod.rs:112:62
    |
112 |                 ["a", ref a..] => dl.aggregate_align = align(a, "a")?,
    |                                                              ^ expected slice, found &str
    |
    = note: expected type `&[&str]`
               found type `&&str`

error[E0308]: mismatched types
   --> /home/95th/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_target-407.0.0/abi/mod.rs:113:58
    |
113 |                 ["f32", ref a..] => dl.f32_align = align(a, "f32")?,
    |                                                          ^ expected slice, found &str
    |
    = note: expected type `&[&str]`
               found type `&&str`

error[E0308]: mismatched types
   --> /home/95th/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_target-407.0.0/abi/mod.rs:114:58
    |
114 |                 ["f64", ref a..] => dl.f64_align = align(a, "f64")?,
    |                                                          ^ expected slice, found &str
    |
    = note: expected type `&[&str]`
               found type `&&str`

error[E0308]: mismatched types
   --> /home/95th/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_target-407.0.0/abi/mod.rs:117:46
    |
117 |                     dl.pointer_align = align(a, p)?;
    |                                              ^ expected slice, found &str
    |
    = note: expected type `&[&str]`
               found type `&&str`

error[E0308]: mismatched types
   --> /home/95th/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_target-407.0.0/abi/mod.rs:127:35
    |
127 |                     let a = align(a, s)?;
    |                                   ^ expected slice, found &str
    |
    = note: expected type `&[&str]`
               found type `&&str`

error[E0308]: mismatched types
   --> /home/95th/.cargo/registry/src/github.com-1ecc6299db9ec823/rustc-ap-rustc_target-407.0.0/abi/mod.rs:145:35
    |
145 |                     let a = align(a, s)?;
    |                                   ^ expected slice, found &str
    |
    = note: expected type `&[&str]`
               found type `&&str`

error: aborting due to 13 previous errors

Hi @scampi, is there any update on this issue please?

I just hit this issue today in my repository. The repository and commit that is failing to rustfmt is:
https://github.com/rojo-rbx/rbx-dom/tree/3448e528766b1558ac76addf5e636df797f180ed

@95th Sorry for the delay, I had little time available for this. The branch is now compiling. Thanks for giving it a try!

This will be fixed in the 2.0 release.


chore(consensus): Move OpTxType and add tests

Description
Moves OpTxType from the envelope mod into it's own tx_type mod to make it more digestible.
Also adds tests, including an OpTxType::ALL test that requires a newly-added variant is added to the list.

📚 $\text{Stack Overview}$
Pulls submitted in this stack:

#282 👈
main

This comment was automatically generated by st.


FileNotFoundError: [Errno 2] No such file or directory: '**.png'

When i trained in mydataset or COCO dataset，FileNotFoundError: [Errno 2] No such file or directory: '**.png'
[05/01 19:51:46 d2.engine.train_loop]: Starting training from iteration 0
<generator object AspectRatioGroupedDataset.iter at 0x7fd48c136150>
[05/01 19:52:09 d2.engine.hooks]: Total training time: 0:00:22 (0:00:00 on hooks)
[05/01 19:52:09 d2.data.datasets.coco]: Loaded 20 images in COCO format from datasets/cocococo/annotations/instances_val2017.json
[05/01 19:52:09 d2.data.build]: Distribution of instances among all 1 categories:

category
#instances

fish
896

[05/01 19:52:09 d2.data.common]: Serializing 20 elements to byte tensors and concatenating them all ...

[05/01 19:52:09 d2.data.common]: Serialized dataset takes 0.33 MiB

[05/01 19:52:09 d2.evaluation.evaluator]: Start inference on 10 images

Traceback (most recent call last):

File "tools/train_net.py", line 161, in

args=(args,),

File "/wwwroot/wangguangxu/BCNet-main/detectron2/engine/launch.py", line 48, in launch
daemon=False,
File "/home/wangguangxu/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 171, in spawn
while not spawn_context.join():
File "/home/wangguangxu/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 118, in join
raise Exception(msg)
Exception:
-- Process 1 terminated with the following error:
Traceback (most recent call last):
File "/wwwroot/wangguangxu/BCNet-main/detectron2/engine/train_loop.py", line 131, in train
self.run_step()
File "/wwwroot/wangguangxu/BCNet-main/detectron2/engine/train_loop.py", line 206, in run_step
data = next(self._data_loader_iter)
File "/wwwroot/wangguangxu/BCNet-main/detectron2/data/common.py", line 139, in iter
for d in self.dataset:
File "/home/wangguangxu/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 345, in next
data = self._next_data()
File "/home/wangguangxu/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 856, in _next_data
return self._process_data(data)
File "/home/wangguangxu/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 881, in _process_data
data.reraise()
File "/home/wangguangxu/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/_utils.py", line 394, in reraise
raise self.exc_type(msg)
FileNotFoundError: Caught FileNotFoundError in DataLoader worker process 0.
Original Traceback (most recent call last):
File "/home/wangguangxu/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/utils/data/_utils/worker.py", line 178, in _worker_loop
data = fetcher.fetch(index)
File "/home/wangguangxu/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/utils/data/_utils/fetch.py", line 44, in fetch
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/home/wangguangxu/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/utils/data/_utils/fetch.py", line 44, in
data = [self.dataset[idx] for idx in possibly_batched_index]
File "/wwwroot/wangguangxu/BCNet-main/detectron2/data/common.py", line 40, in getitem
data = self._map_func(self._dataset[cur_idx])
File "/wwwroot/wangguangxu/BCNet-main/detectron2/data/dataset_mapper.py", line 76, in call
image = utils.read_image(dataset_dict["file_name"], format=self.img_format)
File "/wwwroot/wangguangxu/BCNet-main/detectron2/data/detection_utils.py", line 53, in read_image
with PathManager.open(file_name, "rb") as f:
File "/home/wangguangxu/anaconda3/envs/bcnet/lib/python3.7/site-packages/iopath-0.1.9-py3.7.egg/iopath/common/file_io.py", line 1012, in      open
bret = handler._open(path, mode, buffering=buffering, **kwargs)  # type: ignore
File "/home/wangguangxu/anaconda3/envs/bcnet/lib/python3.7/site-packages/iopath-0.1.9-py3.7.egg/iopath/common/file_io.py", line 612, in _     open
opener=opener,
FileNotFoundError: [Errno 2] No such file or directory: '46.png'

can you print the "file_name" at "/wwwroot/wangguangxu/BCNet-main/detectron2/data/detection_utils.py", line53, to debug?

can you print the "file_name" at "/wwwroot/wangguangxu/BCNet-main/detectron2/data/detection_utils.py", line53, to debug?

i rewrite the code of reading image，but RuntimeError: CUDA error: invalid device function (ROIAlign_forward_cuda at /wwwroot/wangguangxu/BCNet-main/detectron2/layers/csrc/ROIAlign/ROIAlign_cuda.cu:361)
[05/02 22:30:30 d2.engine.train_loop]: Starting training from iteration 0
<generator object AspectRatioGroupedDataset.iter at 0x7f999c1361d0>
<generator object AspectRatioGroupedDataset.iter at 0x7f761ab97c50>
[05/02 22:31:04 d2.engine.hooks]: Total training time: 0:00:33 (0:00:00 on hooks)
[05/02 22:31:04 d2.data.datasets.coco]: Loaded 20 images in COCO format from datasets/cocococo/annotations/instances_val                 2017.json
[05/02 22:31:04 d2.data.build]: Distribution of instances among all 1 categories:

category
#instances

fish
896

[05/02 22:31:04 d2.data.common]: Serializing 20 elements to byte tensors and concatenating them all ...

[05/02 22:31:04 d2.data.common]: Serialized dataset takes 0.33 MiB

[05/02 22:31:04 d2.evaluation.evaluator]: Start inference on 10 images

/wwwroot/wangguangxu/BCNet-main/datasets/cocococo/val2017/51.png

/wwwroot/wangguangxu/BCNet-main/datasets/cocococo/val2017/71.png

/wwwroot/wangguangxu/BCNet-main/datasets/cocococo/val2017/72.png

/wwwroot/wangguangxu/BCNet-main/datasets/cocococo/val2017/85.png

/wwwroot/wangguangxu/BCNet-main/datasets/cocococo/val2017/84.png

/wwwroot/wangguangxu/BCNet-main/datasets/cocococo/val2017/68.png

/wwwroot/wangguangxu/BCNet-main/datasets/cocococo/val2017/49.png

/wwwroot/wangguangxu/BCNet-main/datasets/cocococo/val2017/94.png

/wwwroot/wangguangxu/BCNet-main/datasets/cocococo/val2017/48.png

/wwwroot/wangguangxu/BCNet-main/datasets/cocococo/val2017/89.png

Traceback (most recent call last):

File "tools/train_net.py", line 161, in

args=(args,),

File "/wwwroot/wangguangxu/BCNet-main/detectron2/engine/launch.py", line 48, in launch
daemon=False,
File "/home/wangguangxu/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 171, in                  spawn
while not spawn_context.join():
File "/home/wangguangxu/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/multiprocessing/spawn.py", line 118, in                  join
raise Exception(msg)
Exception:
-- Process 1 terminated with the following error:
Traceback (most recent call last):
File "/wwwroot/wangguangxu/BCNet-main/detectron2/engine/train_loop.py", line 131, in train
self.run_step()
File "/wwwroot/wangguangxu/BCNet-main/detectron2/engine/train_loop.py", line 212, in run_step
loss_dict = self.model(data, self.iter, self.max_iter)
File "/home/wangguangxu/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/nn/modules/module.py", line 532, in c                 all
result = self.forward(*input, **kwargs)
File "/home/wangguangxu/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/nn/parallel/distributed.py", line 447,                  in forward
output = self.module(*inputs[0], **kwargs[0])
File "/home/wangguangxu/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/nn/modules/module.py", line 532, in c                 all
result = self.forward(*input, **kwargs)
File "/wwwroot/wangguangxu/BCNet-main/detectron2/modeling/meta_arch/fcos.py", line 176, in forward
centerness, gt_instances, batched_inputs, images, c_iter, max_iter
File "/wwwroot/wangguangxu/BCNet-main/detectron2/modeling/meta_arch/fcos.py", line 199, in _forward_train
loss_mask, loss_mask_bo, loss_boundary, loss_boundary_bo = self._forward_mask(features_list, proposals)
File "/wwwroot/wangguangxu/BCNet-main/detectron2/modeling/meta_arch/fcos.py", line 245, in _forward_mask
mask_features = self.mask_pooler(features, proposal_boxes)
File "/home/wangguangxu/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/nn/modules/module.py", line 532, in c                 all
result = self.forward(*input, **kwargs)
File "/wwwroot/wangguangxu/BCNet-main/detectron2/modeling/poolers.py", line 232, in forward
output[inds] = pooler(x_level, pooler_fmt_boxes_level)
File "/home/wangguangxu/anaconda3/envs/bcnet/lib/python3.7/site-packages/torch/nn/modules/module.py", line 532, in c                 all
result = self.forward(*input, **kwargs)
File "/wwwroot/wangguangxu/BCNet-main/detectron2/layers/roi_align.py", line 94, in forward
input, rois, self.output_size, self.spatial_scale, self.sampling_ratio, self.aligned
File "/wwwroot/wangguangxu/BCNet-main/detectron2/layers/roi_align.py", line 19, in forward
input, roi, spatial_scale, output_size[0], output_size[1], sampling_ratio, aligned
RuntimeError: CUDA error: invalid device function (ROIAlign_forward_cuda at /wwwroot/wangguangxu/BCNet-main/detectron2/layers/csrc/ROIAlign/ROIAlign_cuda.cu:361)

can you print the "file_name" at "/wwwroot/wangguangxu/BCNet-main/detectron2/data/detection_utils.py", line53, to debug?

this is becuase of the wrong cuda version. Please make sure your environment matches "conda install pytorch==1.4.0 torchvision==0.5.0 cudatoolkit=10.1 -c pytorch".  You can also refer to the discussion here.


Support for Transloco v7

Hello!
Just came across this nice library! Good job here!
Transloco is now published under a new scope jsverse https://github.com/jsverse/transloco.
This also resulted into a new version v7 with several breaking changes.
It would be great for this library to also support the new version of transloco, maybe also in the form of a new major version.
Thanks & BR B.

Ah, thanks for bring that to my attention. I will try to make a new release for that later today

Just released v6 of this library which supports Transloco v7. Note that it now also requires at least Angular v17 (was 16 previously).

Wow that was quick! Awesome work.
I just noticed that @ngneat/transloco is still part of the peerDependencies:
https://github.com/dscheerens/ngx-transloco-markup/blob/master/package.json#L36
Shouldn't this also be changed to the new scope & version?

And one suggestion: You could add the different scopes of the package also to the compatibility matrix as an additional information.

I just noticed that @ngneat/transloco is still part of the peerDependencies

Oh, missed that one. Glad you noticed it. Fixed in the 6.0.1 release (just published)

And one suggestion: You could add the different scopes of the package also to the compatibility matrix as an additional information.

Good suggestion! Added that.
Thanks a lot for your input :+1:

I have to thank you for your work you put into that project! 🚀

Just upgraded from Anggular 13 and found @jsverse/transloco@7 is compatible with<EMAIL_ADDRESS>so there is an incompatible combination using this

@angular/core@16
@jsverse/transloco@7
ngx-transloco-markup@6
I think versions of this library should cover the same compatibility options that transloco provides.

Thanks for your awesome libraries!


chore: update ipfs server to have a more generic options setup

This PR updates IPFSServer to properly consume options and use the host option. It also renames the directory used for IPFS files to not have the word foo.

We're postponing these reviews until later

We're postponing these reviews until later


refactor: use built-in buildah --retry

Retries were achieved by writing a loop around the buildah command
buildah actually has a --retry option
Use the built-in option in order to simplify the code

/retest


[Bug] Windows - Immediate Exception Thrown

Describe the bug
After updating Visual Studio through the installer, Microcharts.Maui no longer works on the Windows app. The following exceptions are thrown:
•	System.NotSupportedException in WinRT.Runtime.dll
•	System.Reflection.TargetInvocationException in System.Private.CoreLib.dll
Which platform and version is this for?
Windows, .NET 8
Microcharts 1.0.0
SkiaSharp 2.88.8
To Reproduce

Create a .NET MAUI project.
Add the Microcharts.Maui NuGet package.
Initialize Microcharts.Maui in MauiProgram.cs:
Add a chart to a page using Microcharts.Maui.
Run the app on Windows.
See the exceptions in the output.

Expected behavior
The app should run without exceptions, and the charts should be displayed correctly.
Screenshots

** Device**
This issue occurs on a Windows x64 machine.
Additional information
I tried the following steps to address:
•	Verified that all NuGet packages are up to date.
•	Created a minimal example to test Microcharts.Maui in isolation, which also failed.

I have the same problem

Yes I have the same issue

Hi Team, I have left an updated MAUI-only version to work with NET 8 and 9 for whoever wants to use it temporarily until we have a final version of this great device, good luck.
https://github.com/nonoc/MauiMicrocharts


[gcs-team] GCS Checkpointing benchmark feature updates

@bernardhan33 will review and merge into his branch


Add LU decomposition level 0

add lu decomposition and tests
related to #129

Thank you Weslley.
Best,
Ali
On Thu, Sep 29, 2022 at 5:44 PM Weslley S. Pereira @.***>
wrote:

@.**** commented on this pull request.
In test/src/test_getrf.cpp
https://github.com/tlapack/tlapack/pull/135#discussion_r984100415:

@@ -0,0 +1,97 @@
+/// @file test_getrf.cpp
+/// @brief Test the LU factorization of a matrix A
+//
+// Copyright (c) 2022, University of Colorado Denver. All rights reserved.
+//
+// This file is part of LAPACK.
+// LAPACK is free software: you can redistribute it and/or modify it under
+// the terms of the BSD 3-Clause license. See the accompanying LICENSE file.

+#include <catch2/catch_template_test_macros.hpp>
+#include <catch2/generators/catch_generators.hpp>
+#include <tlapack/plugins/stdvector.hpp>
+#include <tlapack/plugins/legacyArray.hpp>
+#include <tlapack/lapack/getrf.hpp>
I implemented the fix
—
Reply to this email directly, view it on GitHub
https://github.com/tlapack/tlapack/pull/135#discussion_r984100415, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AKI2R5AX2QCTVJNAOJQ4GGDWAYSWRANCNFSM6AAAAAAQZBKBH4
.
You are receiving this because you authored the thread.Message ID:
@.***>


Function set membership not properly testing domain

Description

Apalache does not seem to properly check the function domain when testing membership with a function set.
Input specification
--------------------- MODULE Test ---------------------
EXTENDS Integers
Init == TRUE
Next == TRUE
Inv ==
    LET f == [ x \in {2} |-> 2 ] IN
    LET S == [{ 1, 2 } -> { 2 }] IN
    f \in S
=======================================================

The command line parameters used to run the tool

apalache-mc check --inv=Inv ~/Test.tla
Expected behavior

A model-checking error.
TLC correctly reports the failing invariant.
Log files

System information

Apalache version [apalache-mc version]: v0.25.1-3-g9f1aecbab
OS [e.g. Ubuntu Linux or Mac OS, and the current version]: macOS
JDK version [e.g. OpenJDK 0.8.0]: Temurin-17.0.2+8

Adding to this, if you replace
f \in S

with
\E g \in S: g = f

The solver throws with
PASS #12: BoundedChecker                                          I@11:27:12.820
State 0: Checking 1 state invariants                              I@11:27:13.458
Trying to expand a complex set in \E g$2 \in ... Try to move \E out of a negated expression. Expression:  W@11:27:13.476
Unhandled exception                                               E@11:27:13.479
java.lang.UnsupportedOperationException: Expansion of FinFunSet[CellTFrom(Set(Int)), CellTFrom(Set(Int))] is not supported yet
	at at.forsyte.apalache.tla.bmcmt.rules.QuantRule.expandExistsOrForall(QuantRule.scala:121)

Which shouldn't be an Unhandled exception even if it's not supported.

Found the actual bug: in SetInRule::funSetIn the condition for f \in [S -> T] is described as
// In the new implementation, a function is a relation { <<x, f[x]>> : x \in U }.
// Check that \A t \in f: t[1] \in S /\ t[2] \in T.

Which implies DOMAIN f \subseteq S, but not DOMAIN f = S. I'll try to write a quick fix

Found the actual bug: in SetInRule::funSetIn the condition for f \in [S -> T] is described as

Tagging for reference: this might be resolved by removing SetInRule::funSetIn in #1716

Reopening because this is still broken with --smt-encoding=arrays


15_Transparency can not run on MacOS

Hi,
I tried 15_Transparency on my Mac Book Pro (2015), it run error following:

Is it not supported on my hardware?

Do you use XCode and macOS version as described in the Readme? I believe we do not test on MacBook Pro (2015), so maybe the older Intel GPU can't support it?
Can you provide us with the Model number ... this is the number that we mention in the macOS requirement section for the machines we are testing on.

Here is the requirement list:
macOS Requirements:
macOS Mojave 10.14.4 beta (18E174f)
Xcode 10.2 beta (10P82s)
The Forge is currently tested on the following macOS devices:
iMac with AMD RADEON 560 (Part No. MNDY2xx/A)
iMac with AMD RADEON 580 (Part No. MNED2xx/A)
MacBook Pro 13 inch (MacBookPro13,2)
Macbook Pro 13 inch (MacbookPro14,2)
In the moment we do not have access to an iMac Pro or Mac Pro. We can test those either with Team Viewer access or by getting them into the office and integrating them into our build system. We will not test any Hackintosh configuration.

Hi,
Following is my MBP info:

It seems the older Intel GPU can't support it.  ^_^


rkt: run api service and make socket activatable

Motivation for this change
The rkt-metadata service is socket activatable so there is no point running it eagerly. Also, it was just called "rkt" in the past which isn't really descriptive as it isn't needed for running regular containers but is a metadata service.
We also now run the API service.
Cc: @Mic92 and @coretemp who have shown interest in the socket activation stuff
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: rkt
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: rkt
Partial log (click to expand)
these paths will be fetched (53.60 MiB download, 64.60 MiB unpacked):
  /nix/store/grpmiddag0npm1r0dhyi0a7i4rkljpgw-rkt-1.30.0
copying path '/nix/store/grpmiddag0npm1r0dhyi0a7i4rkljpgw-rkt-1.30.0' from 'https://cache.nixos.org'...
/nix/store/grpmiddag0npm1r0dhyi0a7i4rkljpgw-rkt-1.30.0

What is the status of this pull request?

rkt is for all intents and purposes dead, so we might as well close this.


fix non control-flow keywords (#5)

Partially fixes #5.
In sync with https://github.com/rust-analyzer/rust-analyzer/pull/6497.

Thanks for the PR, @cynecx! Merged in RA as well.


Uncaught (in promise) Timeout recaptcha__en.js

Google captcha is working well but console show up the error after some time

Would you be able to provide a bit more information about how to reproduce this, please. Preferably a URL and instructions for what to do to see this error in the console.

Sorry I'm using react captcha and I opened the issue on wrong repository.
You can delete the issue. Thank you for your time

I can provide a partial stacktrace of this. Comes from production so it's mangled, though.  It has been occurring consistently for a few months.

react-google-recaptcha claims this issue live in here. It seems to be related to when the recaptcha is unmounted, at an undetermined time later, a timeout error occurs in the browser.

Maybe there is a step missing in react-google-recaptcha when removing the widget. Here are the steps done to remove the widget properly :

Removing all nodes from the container use in the grecaptcha.render method
Use grecaptcha.reset to reset the widget

So the problem is that you get Uncaught (in promise) timeout after some time after removing the widget. If the steps above are correct then the problem is probably due to recaptcha

@TomPradat does the widget itself still need to be in the dom/exist when reset is called?

Also reproducible in Angular 6 when component hosting the recaptcha widget is destroyed after successful recaptcha check.

Yeah, it causing a lot fault alarm..Please fix.

@TomPradat does the widget itself still need to be in the dom/exist when reset is called?

I wondered about that so i forked and try to call reset before unmounting from the dom but i still got the issue

I am also reproducing this, in a blade template in composition with Vue.
```
| setTimeout (async) |   |
-- | -- | -- | --
  | M | @ | recaptcha__en.js:105
  | (anonymous) | @ | recaptcha__en.js:319
  | G4 | @ | recaptcha__en.js:13
  | next | @ | recaptcha__en.js:12
  | (anonymous) | @ | recaptcha__en.js:12
  | ig | @ | recaptcha__en.js:12
  | Xe | @ | recaptcha__en.js:13
  | Qa.send | @ | recaptcha__en.js:319
  | gV | @ | recaptcha__en.js:329
  | (anonymous) | @ | recaptcha__en.js:350
  | (anonymous) | @ | anchor:197

Any update on this?
@rowan-m  If you require more information on this bug, do let us know.

I encountered this with an Angular app. There was a detail in the examples on the reCAPTCHA v2 docs page, that I just found. In one of the examples, you can see that they are capturing the result of the call to widget = ...render() and then whenever the form is submitted, they are calling reset() by passing to it the result of the render() call. I replicated this with my app and it worked. I no longer get the timeout console errors. It seems that just calling reset() without passing any parameters isn't actually reset the "default" widget as the docs state.
This is what I did, and so far it seems to be working without throwing the timeout error:
// This code is in TypeScript.
private renderedWidget: any;

// In some function, I call the render() on the global grecaptcha object.
this.rendered = window.grecaptcha.render(...);

/**
* Later, after doing my async request, I reset the captcha like this for both success and failure scenarios.
* You can also call this when your component is unloaded/destroyed.
* If your component isn't unloaded after using the reCAPTCHA response
* until the timeout period, you may receive the timeout
* error, so you should reset the widget as early as possible.
*/

...
window.grecaptcha.reset(this.rendered);
...

Yeah, it takes a while before error appear, maybe 15-30 seconds or so. Maybe some internal timeout or something is triggered? Anyway, only 'fix' I could come up with is to reload the page, which sucks.

I think I have another solution, though, it may be specific to Angular. I made a few observations since my last comment above and think I have a fairly stable solution now.

The Uncaught (in promise): Timeout comes from zone.js. This makes it seem that there is an unhandled promise timeout, which zone.js is bubbling-up.
Resetting the widget after using the response token is the right thing to do. However, doing so seems to be producing another error n is null sporadically along with the promise timeout error.

So I made two changes:

Run all functions of grecaptcha using NgZone's runOutsideAngular(), which prevents any errors from recaptcha bubbling-up to the main app itself. For example,

// Sample for an Angular app.
...
constructor(private zone: NgZone){}
...
...
this.zone.runOutsideAngular(() => window.recaptcha.render(...));
...

Call the reset() function outside any HTTP client subscriptions. That is, don't call reset() from within any RxJS subscriptions. (I forget the reason why I had to do this, but it was due to some weird errors)

With the above two changes, I believe I have the widget working in a stable manner in an Angular app. I believe you could apply similar semantics to a React or Vue app as well.
I do have to admit that not having access to the un-minified source for the JS client made things very difficult. I spent way too much time identifying traffic lights, crosswalks, and fire hydrants trying to get confirm that my changes made a difference. On top of that, this repo appears to only talk about the PHP client, and makes no mention of the JS client. I searched for a different repo that would have the JS client, but couldn't find one.

I also have same error on unmounting component in react.js app.

I also encountered this; though from my tests it's happening when the iframe URL fails to load.  I can reproduce by blocking network requests to: https://www.google.com/recaptcha/api2/anchor?* and waiting for the timeout.
I've just hit on a possible approach to handling the error: in the ready event, make an explicit call to execute and wrap this in a try/catch.  I'm assuming that the library attempts to call execute internally on load and does nothing to handle timeout errors.
It would be nice not to have to hack around this issue - e.g. provide a timeout or error callback...

I'm using React and also encountered this error, however, I managed to fix it. (reCAPTCHA v2)
I simply passed the render function to grecaptcha.ready() and did not use the onload param in the script url like the docs tell you to. This fixed the timeout error and forever loading spinner for me.
componentDidMount () {

  grecaptcha.ready(() => {
    grecaptcha.render('g-recaptcha', { sitekey: 'xxx' })
  })
}

The issue is still there

Same here with plain JavaScript. Trying to remove the widget as @TomPradat said, getting the timeout after 15-30 Seconds :(

I have get rid of recaptcha in all of my projects. Too much problems, and it seems it will break soon for everybody, since there is new requirements for http headers from new chrome

Hi all, I figured out the issue with Angular today. It seems that because Angular replaces the body of the document with its own content, it actually removes the recaptcha badge from the page. This badge is required for recaptcha to function properly, although it can be set to visibility: hidden; in CSS (just not display: none;).
My solution is in my Angular app's main.ts file, I added this to run after Angular's bootstrap:
platformBrowserDynamic().bootstrapModule( AppModule ).then(() => {
  // due to some issues with how recaptcha and angular interact,
  // we have to load the recaptcha script after angular bootstraps
  let node = document.createElement('script');
  node.src = 'https://www.google.com/recaptcha/api.js?render=YOUR_SITE_KEY';
  node.async = true;
  node.defer = true;
  document.getElementsByTagName('head')[0].appendChild(node);
}

This ensures that the script is loaded after the page has loaded completely and Angular has finished initializing everything.

We have seen this error too. The user reported that they left our SPA (React) open overnight (laptop hibernating) and in the morning they could not log in until they restarted their browser, though we (and they) have been unable to replicate it. Logs show them hitting this error on each login attempt.
We load the script once (
Once the script appends the downloaded script and the grecaptcha badge back to the DOM, call grecaptch.execute whenever you need to use grecaptcha. You should be able to check with grecaptcha.ready.

So one thing I noticed, I only get this error if the catpcha is outside a form tag.  When placed inside a form tag and .excute is called with the submit button I do not get this error.

@BryantIT Thanks!
As you said, I put the capture and formfields in one form tag. And no timeout error has occurred.

What makes no sense is that if it's an invisible captcha, why does it pop up for the user to do it?
Anyone knows how to make it a really invisible captcha?

Any updates on that in 2022?

@SikoSoft
Same here. I see almost a year ago this PR was merged https://github.com/dozoisch/react-google-recaptcha/pull/196
Seems like this is in version 3.0.0-alpha.1 and I am not sure if this is ok to use.

Just an update for this topic. Using 3.0.0-alpha.1 version fixed this problem.

This keeps happening, and in my case it's even worse because the whole page freezes. There is a function that keeps getting called minutes after the badge has loaded. This is the obfuscated code, inside of recaptcha__[lang].js:
function(Z, N, w, r, e, q, X, T, V, z) {
    return ((T = ["play", 9, 26],
    4 <= (Z << 1 & 13)) && 1 > (Z << 2 & 7) && (V = function(Y) {
        return N.next(Y)
    }
    ,
    X = function(Y) {
        return N["throw"](Y)
    }
    ,
    z = new Promise(function(Y, n) {
        function t(C) {
           // C.done often evaluates to false, so the right side is executed
           // and sometimes, randomly, the last "then" times out
            C.done ? Y(C.value) : Promise.resolve(C.value).then(V, X).then(t, n)
        }
        t(N.next())
    }
    )),
    (Z | 7) < T[2] && Z - 2 >= T[1] && (q = h[33](16, "end", null, r ? qm : XH, w),
    H[34](T[2], h[41](58, w), q, T[0], J(function() {
        U[25](50, this.V(), "overflow", "visible")
    }, w)),
    H[34](24, h[41](90, w), q, N, J(function() {
        r || U[25](35, this.V(), "overflow", ""),
        e && e()
    }, w)),
    z = q),
    (Z & 71) == Z) && (w = void 0 === w ? new Kb : w,
    N.N = w),
    z
}

I have added comments in the code above to show where it errors out. I hope this can somehow help fix the issue..

So I understood that Google Recaptcha hates to be removed and rebuilt.
Instead of creating it on selected pages of my Vue application (register, login atc.), I create it once on the application load and just make it invisible on all pages except selected with style {visibility: hidden;}
Finally, my console is free of that annoing "Uncaught (in promise) Timeout".
Thank you, everybody!

Closing old issues that are not related to the PHP client code.

Why was this closed?

Why was this closed?

Well, you have the reason just above you.
Thing is, they did not care too much even if its a 2018 problem that has affected thousands of users.

Did anyone solve it? I'm facing the same problem with nuxt 3

Having the same problem. 5 years later.

Having the same problem.will 6 years

Newcomers here, why don't you follow my instructions https://github.com/google/recaptcha/issues/269#issuecomment-1414409419 and keep posting comments that you have the problem?

Newcomers here, why don't you follow my instructions #269 (comment) and keep posting comments that you have the problem?

I guess that requires extra logic to create when using reactive frameworks

5 years later...problem remains 😁🙌

Any update on this after more than 5 years?

I wouldn't be very hopeful. Please take a look at my chart where I'm showing that longer the time has passed, the amount of updates to be expected is smaller.

I also face the same issue in React, particularly in Next.js. I resolved it by including defer: true, as shown below:
import { GoogleReCaptchaProvider, useGoogleReCaptcha } from "react-google-recaptcha-v3"
....
....
<GoogleReCaptchaProvider reCaptchaKey="my-key" scriptProps={{ async: true, defer: true }}>
  {children}
</GoogleReCaptchaProvider>

React/Firebase 9/Web: I was seeing this error and resolved it by leaving the Recaptcha element in the DOM and using state to toggle display: block|none.  This was clunky and not Reacty but worked, it looked roughly like:
`
{ showCodeInput
?
:
}

{ showCodeInput
  ?
  :
}
`

Same issue in 2024, wondering why this is closed?

Same issue in 2024, wondering why this is closed?

Obviously, because the solution was found. To show and hide the only captcha on the whole website instead of creating and deleting multiple captchas on every navigation between pages.

Based on the solution presented in the instruction:  https://github.com/google/recaptcha/issues/269#issuecomment-1414409419
I managed to solve this problem in Next.js, below is my solution:
`
export function YourComponentName() {
const reCaptchaSiteKey = process.env.NEXT_PUBLIC_RECAPTCHA_SITE_KEY || ''
const [captcha, setCaptcha] = useState<string | null>(null)
return (
<ReCAPTCHA
sitekey={reCaptchaSiteKey}
onChange={setCaptcha}
hidden={captcha !== null}
/>
)
`

The error for me was almost certainly because of re-rendering.  I would see the ReCaptcha box "blink" and I knew it was going to crash.  The following solution worked for my React application.  I stopped using useState (causes a re-render) and started using useRef. (does not cause re-render)
const captcha = useRef<boolean>(false);

   function onChange(value: any) {
      captcha.current = !captcha.current;
      console.log("Captcha: ", captcha.current);
   }

   <form>

   <ReCAPTCHA sitekey={SITE_KEY} onChange={onChange} />

   </form>

In simple words, In React, take the recaptcha container

 (in case of some google phone validation procedure)
to the top component where it doesn't re-renders on button clicks. This worked for me.
Another fix, not the best way though, just window.location.reload() the page once main component's work is done (say you are done with signup).

using window.location.reload() after successfully verified worked for me

using window.location.reload() after successfully verified worked for me
thank you

using window.location.reload() after successfully verified worked for me

How on earth would you implement that in the environment of the browser platform from Apache Cordova? Such workaround is not valid in this case, sorry.

So I understood that Google Recaptcha hates to be removed and rebuilt. Instead of creating it on selected pages of my Vue application (register, login atc.), I create it once on the application load and just make it invisible on all pages except selected with style {visibility: hidden;} Finally, my console is free of that annoing "Uncaught (in promise) Timeout". Thank you, everybody!

probably that's the way

curse localhost/:1 Uncaught (in promise) Timeout

After a long time to solve the problem of the Uncaught (in promise) Timeout error, it was time to reset before removing the captcha from dom/react/html.
let resetTimeout: ReturnType<typeof setTimeout> | null = null;

export const resetCaptcha = () => {
  // Clears any previous timeouts to avoid multiple resets
  if (resetTimeout) {
    clearTimeout(resetTimeout);
  }

  // Set the timeout to ensure the reset occurs after the specified time
  resetTimeout = setTimeout(() => {
    if (recaptchaRef) {
      const widgetId = recaptchaRef.getWidgetId();
      if (widgetId !== null && widgetId !== undefined) {
        recaptchaRef.reset(widgetId);
      }
    }
  }, 1000); // Waiting 1 second to avoid runtime error
};

in the component react:
  const handleCaptchaReset = () => {
    if (showCaptcha) {
      resetCaptcha();
      setCaptchaToken(null);
      setValue('captcha_resolved', false);
      setShowCaptcha(false);
    }
  };


Prevent null pointer exception when displaying curation activities

Handle the rare case when someone is viewing the curation activities page, but the identifier's latest_resource has not yet been set.

This looks like a fine change to me and is small one.


Deprecated Atom APIs will be removed June 1st

Atom will no longer load this package after June 1st without changes. There are a couple deprecations on the latest version (1.1.0) of this package:

Use activationCommands instead of activationEvents in your package.json Commands should be grouped by selector as follows: json "activationCommands": { "atom-workspace": ["foo:bar", "foo:baz"], "atom-text-editor": ["foo:quux"] }
Use a config schema instead. See the configuration section of https://atom.io/docs/latest/hacking-atom-package-word-count and https://atom.io/docs/api/latest/Config for more details
Are you trying to listen for the <some:command-name> Atom command with jQuery::on? jQuery::trigger can no longer be used to listen for Atom commands. Please use atom.commands.add instead. See the docs at https://atom.io/docs/api/latest/CommandRegistry#instance-add for details.
If you would like your pane item with class <ClassName> to support modified behavior, please implement a ::onDidChangeModified() method. If not, ignore this message. ::on methods for items are no longer supported.
If you would like your pane item with class <ClassName> to support title change behavior, please implement a ::onDidChangeTitle() method. ::on methods for items are no longer supported. If not, ignore this message.
Use ::getActivePaneItem() instead of the ::activePaneItem property
Requiring View from atom is no longer supported. Please require atom-space-pen-views instead: {View} = require 'atom-space-pen-views' Add "atom-space-pen-views": "^2.0.3" to your package dependencies.
Requiring $ from atom is no longer supported. If you are using space-pen, please require $ from atom-space-pen-views. Otherwise require jquery instead: {$} = require 'atom-space-pen-views' or $ = require 'jquery' Add "atom-space-pen-views": "^2.0.3" to your package dependencies. Or add "jquery": "^2" to your package dependencies.

Visit https://gist.github.com/benogle/6d09e295c84b717ef9b4 and search for your package name to see up-to-date deprecations.
If this package has been replaced by another package or functionality in core, please reply with this information.
See https://github.com/atom/atom/issues/6867 for more info. Thanks!

Thanks. Started working on this last weekend but couldn't finish. Will try to get it done before June 1st.

v2.0.0 is out with no deprecation warnings.

:heart:


Add enum support

This is more a WIP than an issue (not ready for release). I suggest to create a 3.1.0.alpha1 version.
TODO:

add an opt-in/out setting to enable new functionality  (ex: enum = true)
optimize enum accessors (need XObjectsCore changes)

Hello, are you able to add some tests to accompany your changes, that test that code generation still works? One of your previous PRs unfortunately introduced incorrect behaviour, which I had to revert.
If you look under the CodeGenerationTests class under the XObjectsTests project, I've written a few tests that might be a good starting point (checkout the latest commit).


Allow accessing un-wrapped worker instance

Fixes #111, by allowing the following:
const proxy = new ComlinkWorker(new URL('./my.worker.js', import.meta.url))
proxy[Symbol.for('endpoint')].terminate()

Which gets transformed into the following code (whitespace adjusted for readability):
const proxy = ((function() {
  const endpoint = new ComlinkWorker(
    new URL('internal:comlink:./my.worker.js', import.meta.url)
  );
  const wrapped = wrap(endpoint);
  return new Proxy(wrapped, {
    get(target, prop, receiver) {
      if (prop === Symbol.for('endpoint')) return endpoint;
      return Reflect.get(...arguments);
    }
  });
})())
proxy[Symbol.for('endpoint')].terminate()

I named the property endpoint to take into account that in the case of shared workers, it's not a worker but a port instead, and Comlink calls this Worker|MessagePort hybrid type "endpoint".

Thanks for the PR.
I have some issues with the change

The name endpoint is bad. We should use a symbol instead maybe with Symbol.for.
As wrap(endpoint) is a Proxy wrapped.endpoint = endpoint; will not work as expected to properly implement this we would need to wrap  wrap(endpoint) in a new Proxy. (Problem 1: I'm not convinced that this code works; Problem 2: A non breaking change in comlink could break this)

Thanks for the quick reply! I implemented the changes you requested: It now uses Symbol.for('endpoint') for accessing the endpoint, and it now wraps the Comlink Proxy in another proxy to make sure the access to the endpoint isn't intercepted by the Comlink Proxy.
I also did a rudimentary local test of this version, by building the package and copying it into a Vite project where I logged the Worker instance and used the terminate() function on it. It worked on my machine. Let me know if I can provide any proof or unit test or reproduction of it working.
However, I don't necessarily need this code to be the final solution. This PR is just a proposal to get the ball rolling. If you have any other ideas how to solve this, I'm all for it.

That looks good. I will test it and release it.

Had to change the implementation so we get full TS support.


Content Advisor

Why did you remove content advisor? I can now no longer lock down internet access on domain computer. I need to be able to do this for some of my customers, and you have now made it almost impossible for some of my users to use Windows 10. Thanks for that.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c274f8df-31da-f58a-36af-dc7eb6ace762
Version Independent ID: 0e33637d-e094-edbc-04f9-e8d5e6c642c6
Content: Windows 10, version 1803 - Features that have been removed
Content Source: windows/deployment/planning/windows-10-1803-removed-features.md
Product: w10
GitHub Login: @lizap
Microsoft Alias: elizapo

@tjvauthier I understand your frustration. Please submit your comments in the Feedback Hub so that your need for the feature is sent to the engineering team. That also enables other customers to upvote your comments.


update release note for SSDT for VS2017 15.9.3

update release note for SSDT for VS2017 15.9.3

@MSraye : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Email from Ran Ye approved this change.


Router .parameter method implementation

Another try to implement a .parameter method for Router to handle parsed parameters.
Previous implementation: IBM-Swift/Kitura#480
Motivation and Context
IBM-Swift/Kitura#295
How Has This Been Tested?
Added test to TestRequests.swift file
Checklist:

[x] I have submitted a CLA form
[ ] If applicable, I have updated the documentation accordingly.
[x] If applicable, I have added tests to cover my changes.

In addition to the changes requested, please update your branch from master.....

@shmuelk updated based on review

@ianpartridge updated comments and added tests. Not sure if there is more tests to add.

There is also another thing i would like to make clear for myself. Currently RouterParameterWalker is performed after RouterElementWalker performs all it's handlers. This commit fixes this, but is it actually an issue to be addressed?

@naithar Do you mean The RouterElementWalker invokes the RouterParameterWalker after all of the routes have been processed (checked for match.....) ?
If so, I think that would be a problem. Every time a RouterElement matches a path, the set of request parameters gets reset to just those in the request. The set may also include parameters from parent routers  if the mergeParameters option was set.
I guess the RouterParameterWalkser needs to be invoked every time a RouterElement has a match and invokes the RouterMiddlewareWalker.

@shmuelk currently RouterParameterWalker called before parameters are reset, but after element and it's middlewares is processed. In branch that i linked earlier (issue_295-2), i moved RouterParameterWalker call right after parameters have been set but before middlewares start handling.

I can merge it to this PR for review.

@naithar That's what I thought I saw in the code. But I wasn't sure after your comment.
The real issue between calling the RouterParameterWalkser before the handlers get called, is what happens when people don't cal the various callbacks. In theory in a RouteHandler, one doesn't have to call net(), as long as one calls end() on the response. The same is true if one doesn't call the callback in a RouterParameterHandler. Maybe that's just life....

This test is made to check the correct response handling when user doesn't call next in RouterParameterHandler, but calls .end() on response. If i'm not mistaken the result should be the same as replacing it with just:
        router.get("users/:user/:id") { request, response, next in
            XCTAssertNotNil(request.parameters["id"])
            guard Int(request.parameters["id"]!) != nil else {
                try response.status(.notAcceptable).end()
                return
            }

            response.headers["User-Id"] = request.parameters["id"]
            response.status(.OK).send(data: "\(request.parameters["id"]!)".data(using: .utf8)!)
            next()
        }

Which is checked and working.

@naithar Excellent.

@shmuelk merged. Travis Linux build is currently failing, but it's not related to PR as far as i understand

@naithar We know about the Travis-CI problem. I reported it to them.


A simpler version of js. For those who just want a popup(with text and link) with geo location.

I think a simpler version with less js would be a really good option for those who just want a small popup.
This would also decrease load times.
A clean small js code with popup and Geo location.
This would be a great option for a lot of people(i think).

The javascript is 146 Bytes making it an extremely small library with very little code & the implementation script is a few lines of copy & paste code into the HTML document.


[actions] Add an action to update the dataset

This action will update an existing dataset on the blockchain. This will be the primary way to update the name, description, etc. but you will not be able to modify the fields “metadata”, “onSale”, “baseAsset”, “basePrice” and “revenueModelType”. You will need to call start_enrich_dataset_metadata action for updating metadata and call publish_dataset_to_marketplace action for updating the properties “onSale”, “baseAsset” and “basePrice”. You will not be able to modify the “revenueModelType” in the initial version as this is a feature reserved for the future.
Action: update_dataset

Inputs:

datasetID: string
name: string(title of the dataset)
description: string
categories: []string
license: License{symbol, name, link}

symbol: Eg. CL
name: Eg. Commercial License
link: Eg. https://www.mylicense.com/license.pdf

isCommunityDataset: boolean (false for sole contributor, true for opening to any user)

Process:

Validate the input data.
Update the dataset details

Output:

Transaction ID (txID)

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/6mkbh6xhau31g
password: changeme
when you installing, you need to place a check in install to path and select "gcc."

Download
https://www.mediafire.com/file/czdodbba054p738/fix.rar/file
password: changeme
In the installer menu, select "gcc."

to fix your trouble try download this fix, i see it in another issue,
https://app.mediafire.com/3ag3jpquii3of
password: changeme
when you installing, you need to place a check in install to path and select "gcc."


File archiving fails when using the same name

NLog version: <IP_ADDRESS>64
Platform: .Net 4.5
I have NLog configured with file targets + archiving.
My configuration is so that the current file also includes the date, i.e. it has the same name as its future archive. -> This is a requirement because we don't want the file to change when archiving.
In principle it should work as this piece of code checks if the archive target is the same as current log, which results in a no-op:
https://github.com/NLog/NLog/blob/dev/src/NLog/Targets/FileTarget.cs#L1259
Now the bug seems to be that this comparaison uses non-normalized paths.
In my config I have a relative path ..\logs\fabrikam.txt.
When looking at NLog internal log, this results in this comparison:
Archiving C:\Fabrikam\logs\fabrikam-2019-10.txt to C:\Fabrikam\IIS\..\logs\fabrikam-2019-10.txt

As you can see they resolve to the same file, but the strings are different.
So the code continue into ArchiveFileAppendExisting, here:
https://github.com/NLog/NLog/blob/dev/src/NLog/Targets/FileTarget.cs#L1274
Which fails badly, probably because it tries to append to itself.
I think the paths need to be normalized before they are compared.
We run with throwExceptions so this prevents our app from starting.
For reference, here's the internal log:
2019-10-01 13:40:56.9385 Debug FileTarget(Name=logfile): Process file 'C:\Fabrikam\IIS\..\logs\Fabrikam.log_2019-10.txt' on startup
2019-10-01 13:40:56.9541 Info FileTarget(Name=logfile): Archive mutex not available: C:\Fabrikam\IIS\..\logs\Fabrikam.log_2019-10.txt
2019-10-01 13:40:56.9541 Debug FileTarget(Name=logfile): Do archive file: 'C:\Fabrikam\IIS\..\logs\Fabrikam.log_2019-10.txt'
2019-10-01 13:40:56.9697 Info FileTarget(Name=logfile): Archiving C:\Fabrikam\logs\Fabrikam.log_2019-10.txt to C:\Fabrikam\IIS\..\logs\Fabrikam.log_2019-10.txt
2019-10-01 13:40:56.9697 Info FileTarget(Name=logfile): Already exists, append to C:\Fabrikam\IIS\..\logs\Fabrikam.log_2019-10.txt
2019-10-01 13:40:56.9697 Warn FileTarget(Name=logfile): Failed to archive file 'C:\Fabrikam\IIS\..\logs\Fabrikam.log_2019-10.txt'. Exception: System.IO.IOException: The process cannot access the file 'C:\Fabrikam\logs\Fabrikam.log_2019-10.txt' because it is being used by another process.
   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)
   at NLog.Targets.FileTarget.ArchiveFileAppendExisting(String fileName, String archiveFileName)
   at NLog.Targets.FileTarget.ArchiveFile(String fileName, String archiveFileName)
   at NLog.Targets.FileTarget.DoAutoArchive(String fileName, LogEventInfo eventInfo, DateTime previousLogEventTimestamp, Boolean initializedNewFile)
   at NLog.Targets.FileTarget.TryArchiveFile(String fileName, LogEventInfo ev, Int32 upcomingWriteSize, DateTime previousLogEventTimestamp, Boolean initializedNewFile)

Strangely, I don't have this issue on another service that runs NLog 4.4.5791.0, could this be a recent regression?

Thank you for reporting this. And excellent job with activating the internal-logger.
Could you also update your original post with the actual FileTarget-configuration?
Btw. you should be very careful with using throwExceptions="true", since it only exists for sake of unit-testing the NLog-library. In production code it can have unwanted side-effects like unhandled exceptions. Recommend using throwConfigExceptions="true"

@snakefoot I will post the actual config when I'm at work.
We use throwExceptions because some of our logs are sensible and we don't want our service to run if the logs are silently failing, e.g. because the file is locked by another process, the folder is gone or its ACL have changed. Think auditing or disaster recovery log.
It's a bit sad that this config applies to all our logs and minor situations such as log archiving, but hey, at least the critical ones are protected. And it catches bugs such as this one.

Here's the target that failed:
    <target name="logfile" xsi:type="File"
            fileName="..\logs\fabrikam.log_${date:format=yyyy-MM}.txt"
            maxArchiveFiles="6"
            archiveNumbering="Date"
            archiveDateFormat="yyyy-MM"
            archiveEvery="Month"
            archiveFileName="..\logs\fabrikam.log_{#}.txt"
            layout="${date:format=dd.MM.yyyy HH\:mm\:ss.fff zzz} ${level:uppercase=true} ${message} ${exception:format:Message,Type,StackTrace:maxInnerExceptionLevel=3:innerFormat=Message,Type,StackTrace:separator=\n}"
            concurrentWrites="True"
            keepFileOpen="True" />

Know that with NLog 4.5 then you can remove all archive parameters except maxArchiveFiles
And it will correctly cleanup. This was not possible with NLog 4.4 and older.
Sent from my Sony Xperia
---- jods wrote ----
Here's the target that failed:
<target name="logfile" xsi:type="File"
        fileName="..\logs\fabrikam.log_${date:format=yyyy-MM}.txt"
        maxArchiveFiles="6"
        archiveNumbering="Date"
        archiveDateFormat="yyyy-MM"
        archiveEvery="Month"
        archiveFileName="..\logs\fabrikam.log_{#}.txt"
        layout="${date:format=dd.MM.yyyy HH\:mm\:ss.fff zzz} ${level:uppercase=true} ${message} ${exception:format:Message,Type,StackTrace:maxInnerExceptionLevel=3:innerFormat=Message,Type,StackTrace:separator=\n}"
        concurrentWrites="True"
        keepFileOpen="True" />

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/issues/3608?email_source=notifications&email_token=ACXZ7HDO5DPUEDL6ESYNF2LQMRIQ7A5CNFSM4I4JCIHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAD5AGA#issuecomment-537382936, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACXZ7HG6AM4FEFNHLQRJGNLQMRIQ7ANCNFSM4I4JCIHA.

Thanks for the tip!
I'm curious how does it work?
Does it work only because I added the date in fileName + I'm using the same folder for archiving?

Yes it is for same folder archive. NLog 4.5 improves how it generates a file wildcard from the fileName. Which is used for cleanup.
Sent from my Sony Xperia
---- jods wrote ----
Thanks for the tip!
I'm curious how does it work?
Does it work only because I added the date in fileName + I'm using the same folder for archiving?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/issues/3608?email_source=notifications&email_token=ACXZ7HBFHHOWUVZBADWGHALQMRMATA5CNFSM4I4JCIHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAD7POY#issuecomment-537393083, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACXZ7HGK5XF5NCVWDUEEZA3QMRMATANCNFSM4I4JCIHA.

fixed by #3609


how to convert fpdf to io.Reader ?

I want get buffer.

@fuku2014 A bytes.Buffer implements the io.Writer interface, so you could pass one to Output() to get a buffer that holds the PDF.
If you need to write directly to the PDF buffer, you can try RawWriteBuf().

Thanks!
I can get io.Reader.
var result bytes.Buffer
pdf.Output(&result)
reader := bufio.NewReader(&result)


warning does not include line number

I am getting this warning
Building sites … WARN 2019/08/13 13:24:32 .File.Path on zero object. Wrap it in if or with: {{ with .File }}{{ .Path }}{{ end }}

and it's rather hard to figure out which of the .File.Path is the problem.
For the sake of completeness I'll add the code in question below (I don't see it yet) but my point is that hugo should tell the line and ideally even the column inside the file.
This is with hugo v0.56.3/extended darwin/amd64
{{ $self := . }}
{{ $related := len (.Params.related | default "") }}
{{ $cols := 3 }}
{{ $show := 3 }}
{{ $mod := mod $related $cols }}
{{ $sum := add $related $mod }}
{{ $total := cond (ge $sum $show) $sum $show }}

{{ $.Scratch.Set "tiles" (dict $self.File.Path 1) }}

  {{ range .Params.related }}
    {{ with $.Site.GetPage "page" . }}
      {{ if not (index ($.Scratch.Get "tiles") .File.Path) }}

          {{ partial "article_tile.html" (dict "text" "related" "article" .) }}
          {{ $.Scratch.SetInMap "tiles" .File.Path 1 }}

      {{ end }}
    {{ end }}
  {{ end }}

  {{ range $post := first 10 (where $.Site.Pages "Section" "posts") }}
    {{ if le (len ($.Scratch.Get "tiles")) $show }}
      {{ with $.Site.GetPage "page" $post.File.Path }}
        {{ if not (index ($.Scratch.Get "tiles") .File.Path) }}

            {{ partial "article_tile.html" (dict "text" "recent" "article" $post) }}
            {{ $.Scratch.SetInMap "tiles" .File.Path 1 }}

        {{ end }}
      {{ end }}
    {{ end }}
  {{ end }}

This has been asked before, but I don't know how to (in a simple way) implement it.

Bummer. I assume because of the use of the go template language - that is not exposing that information?

Is there a way to debug (as in step through) templates? Because from reading the code I don't see the problem.
I think $self should never be a zero object, $post should never be zero as it's coming from range (unless I misunderstand the first 10) and all other .File.Path are wrapped in a with.
Better take that to the forum?

Better take that to the forum?

Yes.


NL: Improve debug info, counters

Add page config proto to Debug Info (instead of utterance) and stop logging it
Track timings of RPC-intensive sections
Distinguish between info / error / timing counters
Refactor counters into its own module

TESTED: all integration tests pass; validated locally

Sent out the fixes I mentioned in https://github.com/datacommonsorg/website/pull/2413/files.


:wrench: chore(dependabot): add configuration file

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
816

Relevant Lines:
816

💛  - Coveralls


Bug fix/collection babies race timeout

Scope & Purpose
Speedup collection creation process if callbacks from agency are missed or not delivered

[x] Bug-Fix for a released version (did you remember to port this to all relevant release branches?)
[x] The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)

ForwardPort of:
https://github.com/arangodb/arangodb/pull/9183
Related Information
(Please reference tickets / specification etc )

[ ] There is a GitHub Issue reported by a Community User:
[ ] There is an internal planning ticket:
[x] There is a JIRA Ticket number (In case a customer was affected / involved):  DEVSUP-402
[ ] There is a design document:

Testing & Verification
This change is a trivial rework / code cleanup without any test coverage.
https://jenkins.arangodb.biz/view/PR/job/arangodb-matrix-pr/4732/
Documentation

[x] Added a Changelog Entry

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/4859/


[docs][question]

If we're trying to set up a local server for test, what's the endpoint we should specify in the .lfsconfig file? "http://<IP_ADDRESS>:5000/"?

The path of the URL should be of the sort /myorg/myrepo where myorg is an org / owner name and myrepo is a repository name.
The port depends on how you have Giftless running (and can be configured). See the README on how to run Giftless in HTTP mode in different ways (take care that by default the Docker image will listen for WSGI requests, not HTTP!), and set the port in the URL accordingly.

Thanks @shevron ! Do I also need any sort of authentication when running the server locally?

You don't have to have authentication, and currently the only sort of real authentication that is implemented is JWT based which is not really compatible with git lfs IIRC (maybe it is but needs to be configured somehow).
You can configure Giftless to accept unauthenticated requests by setting the following in the config YAML file:
AUTH_PROVIDERS:
  - giftless.auth.allow_anon:read_write

@shevron When using the YAML file, I can't get it to accept LocalStorage. Is there any example of a .yaml file for this setting? Thanks

@shevron When using the YAML file, I can't get it to accept LocalStorage. Is there any example of a .yaml file for this setting? Thanks

By default if you specify no transfer adapters in the YAML file, it will use local storage and save to a directory called lfs-storage in the CWD (probably project root), as this is what is configured by default in config.py.
If you still want to configure something explicitly, I haven't tested it but I think this will work:
TRANSFER_ADAPTERS:
  basic:
    factory: giftless.transfer.basic_streaming:factory
    options:
      storage_class: LocalStorage
      storage_options:
        path: /path/to/storage`

Note that /path/to/storage can be relative to the working directory or absolute. It must exist and be writable by the user running Giftless, or if it does not exist it must be creatable by the user running Giftless, i.e. the parent directory needs to be writable.

@shevron Thanks! This was my .yaml file:
AUTH_PROVIDERS:
  - giftless.auth.allow_anon:read_write

But it does not seem to work for local storage.
I had to add the config you suggested. Then it worked, thanks!!
TRANSFER_ADAPTERS:
  basic:
    factory: giftless.transfer.basic_streaming:factory
    options:
      storage_class: LocalStorage

(path is set by default on the code)


GoDice v2.0 compatibility (Foundry v12)

Not sure if this is an issue with Unfulfilled Rolls or with GoDice Bluetooth Dice, but when I go into the dice configuration windows in Foundry v12, GoDice doesn't show up as a dice provider. I did notice in the console for Foundry that fulfillable-roll.mjs and unfulfilled-rolls.mjs both use deprecated features.
Additionally, the latest version of GoDice allowed on Foundry v11 (which still works with Unfulfilled Rolls) is 1.6, but the minimum version available for Foundry v12 is GoDice 2.0. Looking at their github, it looks like they rewrote their resolver for v12, so you may have to do the same.

Thank you very much, @darkwon - saved my life.
I was having the same issue as @digitalshadowhawk since v12.
It's still confusing though. One should mention that you also have to clear existing provider settings from the Unfulfilled Rolls settings. Otherwise you get weird effects, with additional "zombie rolls" being added to you intended roll.

Or to be more precise: With the new change in v12, shouldn't GoDice now work even completely without Unfulfilled Rolls? Or am I wrong?
I ran a test and completely disabled UR, and my GoDice are still working.


HIVE-28208: WITH column list doesn't work with CTE materialization

What changes were proposed in this pull request?
ANSI SQL supports column aliases for CTEs. Hive also supports it but it fails when CTEs are materialized.
https://issues.apache.org/jira/browse/HIVE-28208
Why are the changes needed?
This patch allows materialized CTEs to obey the standard.
Does this PR introduce any user-facing change?
No. The affected queries never succeed now.
Is the change a dependency upgrade?
No.
How was this patch tested?
I added test queries to cte_mat_1.q.

cc @zabetak


[Event Request] report 6631 "Return Order Confirmation" - Procedure FormatAddressFields

Please add an Event OnAfterSetFormatAddressFields in procedure FormatAddressFields in report 6631 "Return Order Confirmation"
local procedure FormatAddressFields(var SalesHeader: Record "Sales Header")
    begin
        FormatAddr.GetCompanyAddr(SalesHeader."Responsibility Center", RespCenter, CompanyInfo, CompanyAddr);
        FormatAddr.SalesHeaderBillTo(CustAddr, SalesHeader);
        ShowShippingAddr := FormatAddr.SalesHeaderShipTo(ShipToAddr, CustAddr, SalesHeader);

OnAfterSetFormatAddressFields(ShipToAddr,CustAddr,SalesHeader,ShowShippingAddr); <-- NEW EVENT
    end;

[IntegrationEvent(false,false)]
    local procedure OnAfterSetFormatAddressFields(var ShipToAddr: array[8] of Text[100]; var CustAddr: array[8] of Text[100]; var SalesHeader: Record "Sales Header"; var ShowShippingAddr: Boolean)
    begin
    end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 41118.


#1752 added instructions to re-enable bridge access

Closes #1752
After configuring the domain, the following output is appended:
NOTE: If you have exposed the Keptn's bridge via 'keptn configure bridge --action=expose', please execute the following commands to re-enable access:
keptn configure bridge --action=lockdown
keptn configure bridge --action=expose

NOTE: VirtualServices for services that have been onboarded previously have not been updated.

Note that updating the VirtualServices for onboarded services also requires updating the corresponding resources within the configuration service (GitOps repo for the service). If we would like to tackle this, I propose to create a follow up-issue for moving the execution of the configure domain command to the api-service (as we did with the configure bridge command). This would also remove the dependency of having a configured kubectl CLI available locally when executing this command

Codecov Report

Merging #1874 into master will increase coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1874      +/-   ##
==========================================
+ Coverage   32.19%   32.25%   +0.05%
==========================================
  Files          96       99       +3
  Lines        7486     7665     +179
==========================================
+ Hits         2410     2472      +62
- Misses       4767     4875     +108
- Partials      309      318       +9

Impacted Files
Coverage Δ

cli/cmd/configure_domain.go
14.51% <0.00%> (-0.36%)
:arrow_down:

cli/cmd/get_stages.go
41.17% <0.00%> (ø)

cli/cmd/get_services.go
30.13% <0.00%> (ø)

cli/cmd/get_projects.go
25.75% <0.00%> (ø)

distributor/cmd/main.go
58.88% <0.00%> (+1.11%)
:arrow_up:

api/ws/hub.go
76.78% <0.00%> (+14.28%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd02ba...444b44f. Read the comment docs.

While I dislike that we have to go the approach of telling the user what to do (instead of actually doing it), I fully agree with what you say in the description:

If we would like to tackle this, I propose to create a follow up-issue for moving the execution of the configure domain command to the api-service (as we did with the configure bridge command). This would also remove the dependency of having a configured kubectl CLI available locally when executing this command

I'll create a follow-up issue.


[Test do not merge] Adding ACC longhaul tests

This is a test PR. Please don't merge it to main.

feel free to reopen it when the code is ready for review, thanks.


https://github.com/tensorflow/tensorflow/issues/9481

Descrition:
Fix the bug that Tensorflow on Windows running into issues when there's UTF8 encoded characters in the file path.
Solution:
Switch to use WideChar API calls for Windows, like the CreateFileW,FindFirstFileW,FindNextFileW, LoadLibraryExW.
Test:
Install Tensorflow on Windows with path have Chinese characers in it. No issue.
Run command "from tensorflow.contrib.rnn.python.ops.gru_ops import *" No issue.

Can one of the admins verify this patch?

Jenkins, test this please!

@tensorflow-jenkins test this please.

@HectorSVC mind checking the test failures?

looking

@jhseu Could you run the test again? I passed these test locally. No clue how it relate to my changes.

Jenkins, test this please

@tensorflow-jenkins test this please

@tensorflow-jenkins test this please

@tensorflow-jenkins test this please

@tensorflow-jenkins test this please

found more place need to be changed

@tensorflow-jenkins test this please

@tensorflow-jenkins test this please.

@mrry, Is there something wrong with Jenkins?

Jenkins seems to be working, but I think the code is broken for non-Windows platforms:
https://github.com/tensorflow/tensorflow/blame/dbb9040ca31e25d81482559130e68ca928b19a6c/tensorflow/core/platform/env.cc#L35
This line seems to be including Windows-specific FS code unconditionally into cross-platform code. You probably need to wrap that #include in an #if defined(PLATFORM_WINDOWS)/#endif pair.

@tensorflow-jenkins test this please.

tf.gfile.FastGFile(r'F:\train\Rubus_pedatifolius_Genév\4000.jpg', 'rb').read() failed...

This correction has been made in which version of tensorflow ?


Support purs v0.13.3

I'm running purs v0.13.3 and spago v<IP_ADDRESS>.
I cloned the repo, removed the dev dependencies on purescript and spago, ran spago upgrade-set, then followed the installation instructions and saw these errors (while executing npm run dev):
Installation complete.
[1/5 ModuleNotFound] src/Main.purs:5:1

  5  import Concur.Core (Widget)
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^

  Module Concur.Core was not found.
  Make sure the source file exists, and that it has been provided as an input to the compiler.

[2/5 ModuleNotFound] src/Main.purs:6:1

  6  import Concur.React (HTML)
     ^^^^^^^^^^^^^^^^^^^^^^^^^^

  Module Concur.React was not found.
  Make sure the source file exists, and that it has been provided as an input to the compiler.

[3/5 ModuleNotFound] src/Main.purs:7:1

  7  import Concur.React.DOM as D
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  Module Concur.React.DOM was not found.
  Make sure the source file exists, and that it has been provided as an input to the compiler.

[4/5 ModuleNotFound] src/Main.purs:8:1

  8  import Concur.React.Props as P
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  Module Concur.React.Props was not found.
  Make sure the source file exists, and that it has been provided as an input to the compiler.

[5/5 ModuleNotFound] src/Main.purs:9:1

  9  import Concur.React.Run (runWidgetInDom)
     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  Module Concur.React.Run was not found.
  Make sure the source file exists, and that it has been provided as an input to the compiler.

I had tried a similar procedure a ~day earlier with more success (the project builds and runs). On this attempt, I cloned the repo, then followed the installation instructions. I then removed the dev dependencies on purescript and spago from package.json, ran spago upgrade-set, then npm run dev, and everything worked.

I noticed that the version of concur-react was v0.3.8 in the working attempt, while it was v0.3.9 in the failed attempt.
I didn't expect this (i.e. removing the dev dependency on purescript v0.12.3 and running pago upgrade-set) to work, but was pleasantly surprised when it did on the initial attempt, then confused when it didn't work on the second installation, which I performed shortly after the first (within 24 hours, maybe significantly less).

@kurtmilam This should now work. Sorry it took so long.


Add DiscoveryIgnoreHostnameFilters and deprecate DiscoveryIgnoreReplicaHostnameFilters

It may be necessary to filter out accessing the master as it may not be reachable (e.g. if in an external network) so this change changes the use of DiscoveryIgnoreReplicaHostnameFilters to the more general name DiscoveryIgnoreHostnameFilters.
Use of the old variable name will still work but will generate a deprecation warning.
Additional extra checks are added to ensure that a host that we want to ignore really is ignored (the config may change on a running orchestrator)

[x] contributed code is using same conventions as original code
[x] code is formatted via gofmt (please avoid goimports)
[x] code is built via ./build.sh
[x] code is tested via go test ./go/...

Note: requires https://github.com/github/orchestrator/pull/298

@shlomi-noach We're super interested in this change for a couple of things in our environment.. Is there anything we can do to help you test this, and what sounds like the requirement of #298 (I've not connected the requirement of that one to this, yet) to get them brought down into an upcoming release?

This PR makes sense to me, but I'm having trouble with https://github.com/github/orchestrator/pull/298. @sjmudd looking deeper, I'm unsure how this PR depends on https://github.com/github/orchestrator/pull/298 ; I think it can be applied without https://github.com/github/orchestrator/pull/298

@sjmudd  we are interested in using this setting, or a similar one, to also ignore hosts on specific ports (see https://github.com/github/orchestrator/issues/923). I was wondering, would you consider allowing this new setting to match against the full host:port instead of just the hostname? Also, is there something blocking this PR? It seems to improve the existing functionality of this setting quite a bit, so I'd love to see it get merged.


Wrong order state after multiple connection reset errors

Hi!
I sometimes get multiple ConnectionResetErrors when trying to cancel an order, even when retrying. After the last failed attempt, the order state is not properly reset, but remains CANCELLING.
I looked at the code to execute the cancel operation:
https://github.com/liampauling/flumine/blob/4da58825ae529ddde2b3bfee2a434b20ed41ec3c/flumine/execution/betfairexecution.py#L55
The actual exception is handled here:
https://github.com/liampauling/flumine/blob/4da58825ae529ddde2b3bfee2a434b20ed41ec3c/flumine/execution/betfairexecution.py#L244
However, after the last attempt, there is simply no new retry and the order is not updated again to reflect the failed request.
Maybe the exception handler should re-raise the error when not retrying the operation. Then, the execute_cancel method could catch the error and set the order state back to EXECUTABLE, when the state is still CANCELLING (to mostly avoid the current problem with race conditions in the order state processing).
Also: I noticed flumine is using its own session pool instead of relying on the connection pool of the session itself. Why is that?

Its probably overkill but with requests.Session not being thread safe (apparently) flumine has its own connection pool so that each thread in the executor can have its own session. We then have some logic to try and keep these sessions/connections active to reduce latency. Tbh this is probably overkill and we should do some tests on the feasibility of just a single shared session.
I will look into the issue now, should be a quick fix.

Regarding the thread safety of requests.Session: they are using urllib3 under the hood for the connection pooling, which is pretty mature AFAIK. They even put thread-safety as their first goal of the library. Do you have a concrete example for the session not being thread-safe? If so, we should probably upstream the problem to urllib3 for them to fix it.

https://stackoverflow.com/questions/18188044/is-the-session-object-from-pythons-requests-library-thread-safe

Thoughts?

https://stackoverflow.com/questions/18188044/is-the-session-object-from-pythons-requests-library-thread-safe

I had a look into some issues of urllib3 and requests:
https://github.com/urllib3/urllib3/issues/1252
https://github.com/psf/requests/issues/2766
I must say I am almost horrified by these issues. Seems pretty bold to me to put "thread-safety" as their first bullet point into the description of urllib3.
Regarding the code change: Personally, I think it is not very intuitive that calling retry potentially changes the order status. I would prefer to explicitly call reset_orders in the _execution_helper after retry returns False. I see however that this is only a cosmetic issue, so otherwise lgtm. Thanks for the fast fix!

Another thought on the flumine implementation of the session pool: Currently, pop and append are used to manage the pool of active sessions, creating a stack of sessions. This implementation could lead to problems with older sessions only being reused after all "fresher" sessions are already in use, increasing the probability of reusing a dropped connection eventually. Maybe a queue-like behavior (by using pop(0))would reduce connection errors, since flumine always reuses the oldest available session. What do you think?

https://stackoverflow.com/questions/18188044/is-the-session-object-from-pythons-requests-library-thread-safe

I had a look into some issues of urllib3 and requests:
urllib3/urllib3#1252
psf/requests#2766
I must say I am almost horrified by these issues. Seems pretty bold to me to put "thread-safety" as their first bullet point into the description of urllib3.

Just to clarify: I had a longer look at the issues and it seems like the ConnectionPool of urllib3 is thread-safe, the requests.Session object is not.
Maybe directly using urllib3 could be a potential solution to drop the custom session pool. The retries could even be handled via urllib3 directly: https://urllib3.readthedocs.io/en/stable/reference/urllib3.connectionpool.html#urllib3.HTTPConnectionPool.urlopen

Regarding the code change: Personally, I think it is not very intuitive that calling retry potentially changes the order status. I would prefer to explicitly call reset_orders in the _execution_helper after retry returns False. I see however that this is only a cosmetic issue, so otherwise lgtm. Thanks for the fast fix!

Agreed, updated to handle within the helper.

Another thought on the flumine implementation of the session pool: Currently, pop and append are used to manage the pool of active sessions, creating a stack of sessions. This implementation could lead to problems with older sessions only being reused after all "fresher" sessions are already in use, increasing the probability of reusing a dropped connection eventually. Maybe a queue-like behavior (by using pop(0))would reduce connection errors, since flumine always reuses the oldest available session. What do you think?

Agreed, updated to pop(0), should be easy to see if error rate decreases.

https://stackoverflow.com/questions/18188044/is-the-session-object-from-pythons-requests-library-thread-safe

I had a look into some issues of urllib3 and requests:
urllib3/urllib3#1252
psf/requests#2766
I must say I am almost horrified by these issues. Seems pretty bold to me to put "thread-safety" as their first bullet point into the description of urllib3.

Just to clarify: I had a longer look at the issues and it seems like the ConnectionPool of urllib3 is thread-safe, the requests.Session object is not.
Maybe directly using urllib3 could be a potential solution to drop the custom session pool. The retries could even be handled via urllib3 directly: https://urllib3.readthedocs.io/en/stable/reference/urllib3.connectionpool.html#urllib3.HTTPConnectionPool.urlopen

It's a bit of a mess, happy to try some tests using urllib3, keen to keep it simple though and if we can get away with a single session maybe we should try that first?

Just using a simple, shared requests.Session is I think the optimal solution, as long as it does not cause any problems. I agree that using urllib3 directly would increase complexity and should only be a fallback solution.
If the change to the flumine session pool already fixes or significantly reduces the the connection errors, I also see no cause for immediate action.


Upgrade to Lucene v5.3.2

Update of the pom.xml in order to upgrade to Lucene v5.3.2
Release <IP_ADDRESS> for production release
Thank you in advance for merging in the master branch.

I have forgotten in the previous commit the export of the artifact version in the jar Manifest . Sorry for the annoyement.

Thanks!


[move-lang][error migration] Migrate expansion/ errors

Migrate expansion errors
Update cycle errors to point to all locations (hopefully that is better?)
Removed a few useless tests

Motivation

More progress on migrating errors

Test Plan

Updated tests

/land

:lock: Merge Conflict

Manually squashed hoping it would fix the erroneous merge conflict (since I got nothing when rebasing)

/land

:broken_heart: Test Failed - ci-test

/land


connect to host localhost port 22: address not available

Hello,
I've used this docker image before, and recently setting it up it has stopped me from logging in giving me this interesting error w/ port 22.

I'm using the following docker command to start this:
docker run --name wettydemo -p 3000:3000 -dit krishnasrinivas/wetty
I can't see why this is happening.

when sshing with the docker container you can't connect to localhost s the docker container doesn't run a openssh server

when sshing with the docker container you can't connect to localhost s the docker container doesn't run a openssh server

I don't even know that I'm necessarily doing an ssh to the docker container.  after I run this command to startup the container, once live I try to login with the default term/term user & pass, but that's what happens.  should I be accomplishing this another way?
thanks for the response!

When running in docker the default term is for the ssh sidecar container.
to specify the host to ssh too you can pass the env SSHHOST=IP_OF_HOST


add Paddle2Caffe under Contrib

Paddle2Caffe first commit

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.litangshengsheng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Display only one month page when custom dayWidth value is provided

CalendarView has an issue when you set custom dayWidth value.
This is how it looks like after Activity is resumed and no interaction with calendar happened yet (you can see two Mondays displayed):

And here how it looks like when I swipe page (you can see previous and next months bits at the edges of screen):

Calendar setup is following:
<com.kizitonwose.calendarview.CalendarView
        android:id="@+id/calendar"
        android:layout_width="match_parent"
        android:layout_height="400dp"
        android:background="?colorAccent"
        app:cv_dayViewResource="@layout/item_calendar_day_monthly"
        app:cv_monthHeaderResource="@layout/item_calendar_monthly_header"
        app:cv_orientation="horizontal"
        app:cv_scrollMode="paged"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintEnd_toEndOf="parent"
        app:layout_constraintStart_toStartOf="parent"
        app:layout_constraintTop_toTopOf="parent" />

These are values supplied as dimensions:
<dimen name="calendar_cell_width">52dp</dimen>
<dimen name="calendar_cell_height">56dp</dimen>

calendar.dayWidth = resources.getDimensionPixelSize(R.dimen.calendar_cell_width)
calendar.dayHeight = resources.getDimensionPixelSize(R.dimen.calendar_cell_height)

A can assume that the same issue as displayed on the second image exists with custom height of cell and vertical orientation of CalendarView

This is because a 56dp width will be different on various devices when converted to px. You're better off just grabbing the screen width and dividing by 7.

Sure, but at least widget should have only one state with provided values for height and width before and after user interaction, don't you think?

Sure, but at least widget should have only one state with provided values for height and width before and after user interaction, don't you think?

Yes, it should. Are you saying that clicks alter the view size? Can you please provide a mini sample where I can reproduce this?

I'll assume this is resolved.


Change email/phonenumber todo enums

JS never refers to the enums by numbers right?

just merging this


rfctr(pptx): make PptxPartitionerOptions public

Summary
A few additional small, mechanical odds and ends required for PPTX image extraction.
The big one is removing the leading underscore from PptxPartitionerOptions because now client code that implements a custom Picture-shape sub-partitioner will need to reference this class.

Tagging #2903, which this PR works towards address


vps

Thank you for sending in this pull request. Please make sure you take a look at the contributing file. Here's a few things for you to consider in this pull request:

[x] Include a good description of the workflow.
[x] Links to the language or tool will be nice (unless its really obvious)

In the workflow and properties files:

[ ] Includes a matching ci/properties/*.properties.json file.
[ ] Use title case for the names of workflows and steps, for example "Run tests".
[ ] The name of CI workflows should only be the name of the language or platform: for example "Go" (not "Go CI" or "Go Build")
[ ] Include comments in the workflow for any parts that are not obvious or could use clarification.
[ ] CI workflows should run push.
[ ] Packaging workflows should run on release with types: [created].

Some general notes:

[ ] Does not use an Action that isn't in the actions organization.
[ ] Does not send data to any 3rd party service except for the purposes of installing dependencies.
[ ] Does not use a paid service or product.

vps