Angular 9 application error after redirect from successful Azure B2C login

Library

[ ]<EMAIL_ADDRESS>or<EMAIL_ADDRESS>[X]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>[X]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Framework

[X] Angular
[ ] React
[ ] Other

Description
We are trying to integrate the existing Angular 9 application with existing custom policy in B2C tenant. We are using the sample code from the B2C integration sample and getting redirected to Azure and were able to login. The application fails after the redirect with the message listed below.
Error Message
EXCEPTION: Error: Uncaught (in promise): BrowserAuthError: interaction_in_progress: Interaction is currently in progress. Please ensure that this interaction has been completed before calling an interactive API.
BrowserAuthError: interaction_in_progress: Interaction is currently in progress. Please ensure that this interaction has been completed before calling an interactive API.
at BrowserAuthError.AuthError [as constructor] (index.es.js:503)
at new BrowserAuthError (index.es.js:6627)
at<EMAIL_ADDRESS>(index.es.js:6670)
at<EMAIL_ADDRESS>(index.es.js:9843)
at PublicClientApplication. (index.es.js:9286)
at step (index.es.js:74)
at Object.next (index.es.js:55)
at index.es.js:48
at new ZoneAwarePromise (zone-evergreen.js:960)
at __awaiter (index.es.js:44)
at resolvePromise (zone-evergreen.js:798)
at resolvePromise (zone-evergreen.js:750)
at zone-evergreen.js:705
at step (index.es.js:47)
at index.es.js:48
at new ZoneAwarePromise (zone-evergreen.js:960)
at __awaiter (index.es.js:44)
at<EMAIL_ADDRESS>(index.es.js:10051)
at MsalService.loginRedirect (azure-msal-angular.js:48)
at AppComponent.login (app.component.ts:147)
MSAL Configuration
The policy name - B2C_1A_ARW_ECSDEV_SIGN_UP_SIGNIN_V1
application client_id - 8d19f993-c776-4209-a9c3-913fcbc048a2
Reproduction steps
Application files will be provided via secure files transfer.
Expected behavior
Application is using the token provided from Azure B2C.
Identity Provider

[ ] Azure AD
[ ] Azure B2C Basic Policy
[X] Azure B2C Custom Policy
[ ] ADFS
[ ] Other

Browsers/Environment

[X] Chrome
[ ] Firefox
[ ] Edge
[ ] Safari
[ ] IE
[ ] Other (Please add browser name here)

Regression

[ ] Did this behavior work before?
Version:

Security

[ ] Is this issue security related?

Source

[ ] Internal (Microsoft)
[ ] Customer request

I enabled logging as suggested and only got 1 additional line added the output
[Thu, 07 Jan 2021 00:43:10 GMT]<EMAIL_ADDRESS>: Info - Emitting event: msal:loginStart
core.js:40846 Angular is running in the development mode. Call enableProdMode() to enable the production mode.
exception-handler.service.ts:10 EXCEPTION: Error: Uncaught (in promise): BrowserAuthError: interaction_in_progress: Interaction is currently in progress. Please ensure that this interaction has been completed before calling an interactive API.
BrowserAuthError: interaction_in_progress: Interaction is currently in progress. Please ensure that this interaction has been completed before calling an interactive API.
at BrowserAuthError.AuthError [as constructor] (index.es.js:503)
at new BrowserAuthError (index.es.js:6627)
at<EMAIL_ADDRESS>(index.es.js:6670)
at<EMAIL_ADDRESS>(index.es.js:9843)
at PublicClientApplication. (index.es.js:9286)
at step (index.es.js:74)
at Object.next (index.es.js:55)
at index.es.js:48
at new ZoneAwarePromise (zone-evergreen.js:960)
at __awaiter (index.es.js:44)
at resolvePromise (zone-evergreen.js:798)
at resolvePromise (zone-evergreen.js:750)
at zone-evergreen.js:705
at step (index.es.js:47)
at index.es.js:48
at new ZoneAwarePromise (zone-evergreen.js:960)
at __awaiter (index.es.js:44)
at<EMAIL_ADDRESS>(index.es.js:10051)
at MsalService.loginRedirect (azure-msal-angular.js:48)
at AppComponent.login (app.component.ts:148)
client:52 [WDS] Live Reloading enabled.

I enabled logging as suggested and only got 1 additional line added the output
[Thu, 07 Jan 2021 00:43:10 GMT]<EMAIL_ADDRESS>: Info - Emitting event: msal:loginStart
core.js:40846 Angular is running in the development mode. Call enableProdMode() to enable the production mode.
exception-handler.service.ts:10 EXCEPTION: Error: Uncaught (in promise): BrowserAuthError: interaction_in_progress: Interaction is currently in progress. Please ensure that this interaction has been completed before calling an interactive API.
BrowserAuthError: interaction_in_progress: Interaction is currently in progress. Please ensure that this interaction has been completed before calling an interactive API.
at BrowserAuthError.AuthError [as constructor] (index.es.js:503)
at new BrowserAuthError (index.es.js:6627)
at<EMAIL_ADDRESS>(index.es.js:6670)
at<EMAIL_ADDRESS>(index.es.js:9843)
at PublicClientApplication. (index.es.js:9286)
at step (index.es.js:74)
at Object.next (index.es.js:55)
at index.es.js:48
at new ZoneAwarePromise (zone-evergreen.js:960)
at __awaiter (index.es.js:44)
at resolvePromise (zone-evergreen.js:798)
at resolvePromise (zone-evergreen.js:750)
at zone-evergreen.js:705
at step (index.es.js:47)
at index.es.js:48
at new ZoneAwarePromise (zone-evergreen.js:960)
at __awaiter (index.es.js:44)
at<EMAIL_ADDRESS>(index.es.js:10051)
at MsalService.loginRedirect (azure-msal-angular.js:48)
at AppComponent.login (app.component.ts:148)
client:52 [WDS] Live Reloading enabled.

@mg-arrow Can you email me the application files along with steps to reproduce the error?

@mg-arrow Can you email me the application files along with steps to reproduce the error?

Jo,
I've attached the important files using the secure transfer link provided by Ray.
The application is very large and some parts of the application contain sensitive information, which I would not be able to share. Plus you would not be able to run it because application is using our on prem APIs.
Is it possible to have follow up call later today using Teams and I will show you the whole flow.
Thanks a lot for your help
Regards
Mikhail
Mikhail Goncharov
Enterprise Architect
T: +1<PHONE_NUMBER>|M: +1<PHONE_NUMBER>
E<EMAIL_ADDRESS>Arrow Electronics | arrow.com
From: Jo Arroyo<EMAIL_ADDRESS>Sent: Thursday, January 7, 2021 12:41 PM
To: AzureAD/microsoft-authentication-library-for-js<EMAIL_ADDRESS>Cc: Mikhail Goncharov<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: [External] Re: [AzureAD/microsoft-authentication-library-for-js] Angular 9 application error after redirect from successful Azure B2C login (#2835)
CAUTION: This email originated from outside of the organization. This message might not be safe, use caution in opening it. If in doubt, do not open the attachment nor links in the message.
@mg-arrowhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmg-arrow&data=04|01|mgoncharov%40arrow.com|726a3bd31ad24128a5c808d8b3443642|0beb0c359cbb4feb99e5589e415c7944|1|0|637456452839907315|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=2eWydgELztLU5XEqKLUWCxuUbFu6LGlNvd6VrMhYcCA%3D&reserved=0 Can you email me the application files along with steps to reproduce the error?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzureAD%2Fmicrosoft-authentication-library-for-js%2Fissues%2F2835%23issuecomment-756338136&data=04|01|mgoncharov%40arrow.com|726a3bd31ad24128a5c808d8b3443642|0beb0c359cbb4feb99e5589e415c7944|1|0|637456452839917310|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=%2Bvc7QqTxff%2FkXnk8K5EjrNvbvFRw8pRoOkhvVOdeSe0%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACCLVECKV74IDB625GTZZKLSYYE6DANCNFSM4VX7HANQ&data=04|01|mgoncharov%40arrow.com|726a3bd31ad24128a5c808d8b3443642|0beb0c359cbb4feb99e5589e415c7944|1|0|637456452839927304|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=edRpfsLq%2BuRIZOs%2F8VGHE0iQcH2ccH%2FoPKWcAm0UkQw%3D&reserved=0.

Jo,
I've attached the important files using the secure transfer link provided by Ray.
The application is very large and some parts of the application contain sensitive information, which I would not be able to share. Plus you would not be able to run it because application is using our on prem APIs.
Is it possible to have follow up call later today using Teams and I will show you the whole flow.
Thanks a lot for your help
Regards
Mikhail
Mikhail Goncharov
Enterprise Architect
T: +1<PHONE_NUMBER>|M: +1<PHONE_NUMBER>
E<EMAIL_ADDRESS>Arrow Electronics | arrow.com
From: Jo Arroyo<EMAIL_ADDRESS>Sent: Thursday, January 7, 2021 12:41 PM
To: AzureAD/microsoft-authentication-library-for-js<EMAIL_ADDRESS>Cc: Mikhail Goncharov<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: [External] Re: [AzureAD/microsoft-authentication-library-for-js] Angular 9 application error after redirect from successful Azure B2C login (#2835)
CAUTION: This email originated from outside of the organization. This message might not be safe, use caution in opening it. If in doubt, do not open the attachment nor links in the message.
@mg-arrowhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmg-arrow&data=04|01|mgoncharov%40arrow.com|726a3bd31ad24128a5c808d8b3443642|0beb0c359cbb4feb99e5589e415c7944|1|0|637456452839907315|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=2eWydgELztLU5XEqKLUWCxuUbFu6LGlNvd6VrMhYcCA%3D&reserved=0 Can you email me the application files along with steps to reproduce the error?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzureAD%2Fmicrosoft-authentication-library-for-js%2Fissues%2F2835%23issuecomment-756338136&data=04|01|mgoncharov%40arrow.com|726a3bd31ad24128a5c808d8b3443642|0beb0c359cbb4feb99e5589e415c7944|1|0|637456452839917310|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=%2Bvc7QqTxff%2FkXnk8K5EjrNvbvFRw8pRoOkhvVOdeSe0%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACCLVECKV74IDB625GTZZKLSYYE6DANCNFSM4VX7HANQ&data=04|01|mgoncharov%40arrow.com|726a3bd31ad24128a5c808d8b3443642|0beb0c359cbb4feb99e5589e415c7944|1|0|637456452839927304|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=edRpfsLq%2BuRIZOs%2F8VGHE0iQcH2ccH%2FoPKWcAm0UkQw%3D&reserved=0.

@mg-arrow Thanks for the files. It looks like the check on lines 129-130 of app.component.ts may be causing the interaction in progress error. Can you try removing it and seeing if you still have errors?

@mg-arrow Thanks for the files. It looks like the check on lines 129-130 of app.component.ts may be causing the interaction in progress error. Can you try removing it and seeing if you still have errors?

I used the original code without the lines 129-130 in the app.component.ts file but this way application did not redirect to the B2C login screen and nothing was happening.
I've added lines
if (!this.loggedIn)
this.login();
to force login in case user is not logged in yet.

I used the original code without the lines 129-130 in the app.component.ts file but this way application did not redirect to the B2C login screen and nothing was happening.
I've added lines
if (!this.loggedIn)
this.login();
to force login in case user is not logged in yet.

@mg-arrow Have you tried using the MsalGuard (which will handle checking if the user is logged in and redirect them to login if not)?

@mg-arrow Have you tried using the MsalGuard (which will handle checking if the user is logged in and redirect them to login if not)?

Yes, MsalGuard is setup on the routing to protect main route of of the application.
I think I sent you all the routing details.
Let me know if you need additional info.

Yes, MsalGuard is setup on the routing to protect main route of of the application.
I think I sent you all the routing details.
Let me know if you need additional info.

@mg-arrow If your app is using the MSAL Guard for the main route, why do you have the logic to manually invoke loginRedirect on page load (as the MSAL Guard should do this for you)?

@mg-arrow If your app is using the MSAL Guard for the main route, why do you have the logic to manually invoke loginRedirect on page load (as the MSAL Guard should do this for you)?

This is the reason we added the code on app.component.ts to force the redirect (see above)
Do you recommend to place it in the different place ?

This is the reason we added the code on app.component.ts to force the redirect (see above)
Do you recommend to place it in the different place ?

Closing as this issue as a fix for redirects has been released, and continuing communication is being handled with the customer offline. Future questions regarding redirects should open a new issue.


[Bug]: Features page covers more than features

Version

[X] I'm using version 1.7.0

Known issues

[X] I've checked Known issues

Existing issues

[X] I've checked Existing issues

What operating system are you using?
Windows
Operating System Version
Windows 10
Reproduction steps
This does not report a behavioral bug.
Expected Behavior
This does not report a behavioral bug.
Actual Behavior
This does not report a behavioral bug.
Relevant log output
No response
Preferences
No response
Additional information
The Features page of Stretchly's website covers features, but also contains considerable offtopic content, including at least the Contributors, Humans and Tools and License sections.
Code of Conduct

[X] I agree to follow this project's Code of Conduct

How would you solve it? I pretty much copied the contents of Readme from Girhub

Right :-/
I guess the strategy's first step could be to identify all content which is out of place and start with the easy parts.
The Development section could move to a new page titled Development. That page could include the Development and Contributors section (as well as the contents currently in the Report an issue page, if you want to keep navigation minimal).
The Humans and Tools section could first be structured, cleaned up and formatted before determining what should go where, but much can visibly move to the Research page. As for License (and probably Default behavior), it could probably stay there given a wider title (perhaps Description).

I've simply renamed it to "About". It's much more easier to maintain everything for me if it's on single page and same as Readme.


Add Dockerfile for production Erlang release

Unlike the 2.0-dev build, which results in a fully-connected 3 node cluster inside the container, this Dockerfile builds a minimal Erlang release using reltool, installs that release into /opt/couchdb, and runs just the one single Erlang VM. Orchestrating a cluster of these is out of scope.
I'm neither a Debian nor a Dockerfile pro at this point, and there are certainly some idiosyncrasies to work out. Nevertheless, this seems like a good start down a path towards a Docker build for running 2.0 in production. What do you think?

I get an error that the _users database doesn't exist when I try to run with this config.
...
15:41:54.976 [error] CRASH REPORT Process chttpd_auth_cache with 0 neighbours exited with reason: {database_does_not_exist,[{mem3_shards,load_shards_from_db,"_users",[{file,"src/mem3_shards.erl"},{line,282}]},{mem3_shards,load_shards_from_disk,1,[{file,"src/mem3_shards.erl"},{line,270}]},{mem3_shards,load_shards_from_disk,2,[{file,"src/mem3_shards.erl"},{line,286}]},{mem3_shards,for_docid,3,[{file,"src/mem3_shards.erl"},{line,85}]},{fabric_doc_open,go,3,[{file,"src/fabric_doc_open.erl"},{line,38}]},{chttpd_auth_cache,ensure_auth_ddoc_exists,2,[{file,"src/chttpd_auth_cache.erl"},{line,184}]},...]} in gen_server:terminate/6 line 737
...

This look interesting :)
Could you move the COPY and VOLUME instructions below the RUNs and group the different RUN instructions into a big one? The reason is docker's layering. Each RUN gets committed into a layer and thus subsequent clean up operations don't actually lower the size of the image.
Example:
RUN wget 100MB-file.bin
RUN rm 100MB-file.bin

The resulting image would still need to download the layer with then 100MB file.
RUN wget 100MB-file.bin \
 && rm 100MB-file.bin

The file gets added and deleted in the same layer :)
These are the idiosyncrasies you were talking about ;)

Heya, I could have sworn I was watching this issue and wondering if I was going to get any feedback. Oops!
@considerate, yes I noticed this as well. There's a bit of a trick with the creation of _users; you want to wait until the cluster is joined so that the the DB is spread across the nodes correctly. I don't have that orchestration baked in at the moment. Will have to think if there's a better way.
@klaemo correct, no official tags yet, just wanting to be ready. Thanks for the Docker layering 101 primer :), I'll address the issues you outlined.

OK @klaemo, that dropped the image size as reported by Docker Hub from 438 MB down to 221 MB :+1:

Super cool!
@kocolosk would you be willing to help maintain this, once it's merged?
One thing left to consider is naming: while this dockerfile might be ready for production, CouchDB 2.0 isn't yet, so calling it 2.0-prod might be misleading at this point. Maybe 2.0-single or something along those lines?

If anyone is interested in playing around with single-instance Couch2 while waiting for this PR to land then I've created an image with @kocolosk's work here: https://hub.docker.com/r/chrisfosterelli/couchdb2/

@kocolosk Hey I've noticed that you have a volume configured for /var/lib/couchdb, but Couch doesn't seem to be storing data there or respecting the config option.
I found the data is instead located in /opt/couchdb/data/

Also, what is couchdb.config for? I don't see it referenced anywhere in the Dockerfile.

This has been merged as part of #56
Thanks for your work on this @kocolosk :)


cmd/govim: don't force 'syntax on' in the plugin's defaults

I use vim without syntax highlighting. After installing govim, it was turned back on.
This temporary fix works for me:
diff --git a/plugin/govim.vim b/plugin/govim.vim
index 6c87915..1ea9133 100644
--- a/plugin/govim.vim
+++ b/plugin/govim.vim
@@ -13,7 +13,7 @@ set balloondelay=250
 set ballooneval
 set balloonevalterm
 set updatetime=500
-syntax on
+" syntax on

 " TODO these probably doesn't belong here?
 let g:govim_format_on_save = "goimports"

Thanks for the report


HealthCheck fix for Datastax Java Driver 3.x

The system_schema keyspace is not available anymore in Datastax Java Driver 3.0 so the validation query fails with the current master.
Changed it to "SELECT key FROM system.local"

That's strange, as the test is working fine: https://github.com/composable-systems/dropwizard-cassandra/blob/master/src/test/java/systems/composable/dropwizard/cassandra/CassandraHealthCheckIntegrationTest.java#L41
I have a few questions:

What version of Cassandra are you finding issues with?
What versions of Cassandra will the new validationQuery work on?
If this doesn't work on all versions of Cassandra, is there a different query we can use that's more universally supported?

It looks like the query you've provided might be more performant if just for the fact that it brings back less data.

Hi,

I've tested it against Cassandra 2.1.13, with 2 different clusters and results were the same each time, which is consistent with the fact that the system_schema.keyspace table does not exist anymore (replaced by system.schema_keyspaces). I can't find in which version it actually vanished.

The new validationQuery will work with both Cassandra 2.x and 3.x

Unless the Cassandra team breaks the local table which provides all basic informations of the local node (unlikely but as possible as any other table) we should be fine with this one

Sounds good if it works on both C* 2.x and 3.x. Thanks for the PR.

The 3.0.1 release should be available soon with this change.


CS: Computer Science

https://100js.jonsam.site/CS/开始上手
100 days to enhance your skills on JavaScript.

When two or more process cooperates with each other, their order of execution must be preserved otherwise there can be conflicts in their execution and inappropriate outputs can be produced.
A cooperative process is the one which can affect the execution of other process or can be affected by the execution of other process. Such processes need to be synchronized so that their order of execution can be guaranteed.


Added WaitForBackupCompletion() API in Backup driver and its

implementation.

@disrani-px addressed review comments.

@stgleb / @raviprasadsn / @disrani-px ,
In the latest commit, added WaitForRestoreCompletion() similar to WaitForBackupCompletion(). Also made both the APIs to accept backupName/restoreName and orgID instead of direct request objects.


OpenAIChatCompletionChoiceMessageContentItemModel.imageUrl Not working properly

Following code:
String encodedImage = await loadImage(imageFile);
final message = OpenAIChatCompletionChoiceMessageModel(
  content: [
    OpenAIChatCompletionChoiceMessageContentItemModel.imageUrl(
      'data:image/jpeg;base64,$encodedImage',
    ),
  ],
  role: OpenAIChatMessageRole.user,
);
final chatCompletion = await OpenAI.instance.chat.create(
  model: 'gpt-4-turbo',
  seed: 0,
  messages: [message],
  temperature: 1,
  maxTokens: 512,
);

Throws:
RequestFailedException (RequestFailedException(message: Invalid type for 'messages[0].content[0].image_url': expected an object, but got a string instead., statusCode: 400))

Solved by changing OpenAIChatCompletionChoiceMessageContentItemModel method:
/// This method used to convert the [OpenAIChatCompletionChoiceMessageContentItemModel] to a [Map<String, dynamic>] object.
  Map<String, dynamic> toMap() {
    return {
      "type": type,
      if (text != null) "text": text,
      if (imageUrl != null) "image_url": imageUrl,
    };
  }

Into:
/// This method used to convert the [OpenAIChatCompletionChoiceMessageContentItemModel] to a [Map<String, dynamic>] object.
  Map<String, dynamic> toMap() {
    return {
      "type": type,
      if (text != null) "text": text,
      if (imageUrl != null) "image_url": {"url": imageUrl},
    };
  }

Following https://platform.openai.com/docs/guides/vision
If you need a pull request for this let me know :)
(Just noticed there is already a pull request for this)

I believe the issue is resolved in #166, will update the package also today, can you check?

Yes, I can check it. I was also looking at adding the "detail" parameter so that people can manually switch between the "low" and "high" image processing schemes provided by OpenAI. From what they say the "auto" value is default: it decides automatically based on input image size. I still think we need manual control though. Being sure about input tokens pricing can be important.


maxLineLengthHeader feature

Comments can contain long urls, also table markdown, that cannot be shortened
We should provide an automatic exception for these in the line length limit.

Might be better to have the ability to specify a separate limit rather than totally ignore long lines in comment blocks.
Or perhaps something that can detect when it is a single long "word" that is exceeding the line limit.  That would handle the example of the long URL in the comment block.

@sasutils - I like your idea of ignoring a "word" (ie, string without a space)!  Thanks for the suggestion!

On retrospect, the single word idea won't work as we also need it to work for table markdown (where each row must be on one line, and can contain spaces)
So your first idea is on the table.  A new config option maxLineLengthHeader (to work only with the header section) that will default to max(maxLineLengthHeader,maxLineLength)

via Hubstaff
User: Sabir Hassan
Project: SASjs lint - https://app.hubstaff.com/projects/2310878
Date Range: 01/09/23 - 01/10/23
Work session total: 9:19:59
Billable: Yes
Grand total: 9:19:59


[WIP] Verify data source connection command

Still a little bit WIP, needs verification of all data sources, and I will also go through each data source and try to see whether there is a more meaningful query to run in each.

Select 1 seems reasonable in all data sources, I added a skipif for spark_df as it doesnt really work with regular CLI anyway. Also added a fail test for the cli command. Ready for review now.


NoDaemon Java11 Openjdk Windows (persistentCache) fails on release branch

See https://builds.gradle.org/viewType.html?buildTypeId=Gradle_Check_NoDaemon_Java11_Openjdk_Windows_persistentCache&branch_Gradle_Check_NoDaemon_Java11_Openjdk_Windows=release&tab=buildTypeStatusDiv
@blindpirate investigated and confirmed it's another JDK argument file parser bug. Similar to https://bugs.openjdk.java.net/browse/JDK-8210810

I pushed a workaround https://github.com/gradle/gradle/commit/238bd408f99ee4da81a4090adf857db7ceeeb6ab by simply renaming the test case.

For those who may be googling, (and also for my own clarification), I assume this is what started causing this sudden sealing violation: package jdk.internal.jimage is sealed failure in the current release of openjdk11-openj9. Please correct me if I'm misguided.
Debug output in Gitlab CI with gradle 5.0-rc-5 and kotlin-dsl on the adoptopenjdk/openjdk11-openj9:alpine-slim image:
./gradlew assemble --stacktrace --debug --scan
...
02:32:43.132 [DEBUG] [org.gradle.cache.internal.DefaultFileLockManager] Lock acquired on daemon addresses registry.
02:32:47.520 [DEBUG] [org.gradle.internal.operations.DefaultBuildOperationExecutor] Build operation 'Load build' completed
02:32:47.537 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]
02:32:47.538 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] FAILURE: Build failed with an exception.
02:32:47.538 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]
02:32:47.538 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] * What went wrong:
02:32:47.538 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Could not open cache directory 4x2w3na12fz5beul6a9kbeu76 (/builds/my/package/.gradle/caches/5.0-rc-5/gradle-kotlin-dsl/4x2w3na12fz5beul6a9kbeu76).
02:32:47.538 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] > sealing violation: package jdk.internal.jimage is sealed
02:32:47.538 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]
02:32:47.538 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] * Try:
02:32:47.538 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]  Run with --scan to get full insights.
02:32:47.540 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]
02:32:47.541 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] * Exception is:
02:32:47.547 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] org.gradle.cache.CacheOpenException: Could not open cache directory 4x2w3na12fz5beul6a9kbeu76 (/builds/builds/my/package/.gradle/caches/5.0-rc-5/gradle-kotlin-dsl/4x2w3na12fz5beul6a9kbeu76).
02:32:47.547 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at org.gradle.cache.internal.DefaultPersistentDirectoryStore.open(DefaultPersistentDirectoryStore.java:80)
02:32:47.547 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at org.gradle.cache.internal.DefaultPersistentDirectoryStore.open(DefaultPersistentDirectoryStore.java:42)
02:32:47.547 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at org.gradle.cache.internal.DefaultCacheFactory.doOpen(DefaultCacheFactory.java:94)
02:32:47.547 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at org.gradle.cache.internal.DefaultCacheFactory.open(DefaultCacheFactory.java:68)
02:32:47.548 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at org.gradle.cache.internal.DefaultCacheRepository$PersistentCacheBuilder.open(DefaultCacheRepository.java:117)
02:32:47.548 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at org.gradle.kotlin.dsl.cache.ScriptCache.cacheDirFor(ScriptCache.kt:67)
02:32:47.548 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at org.gradle.kotlin.dsl.provider.StandardKotlinScriptEvaluator$InterpreterHost.cacheDirFor(KotlinScriptEvaluator.kt:253)
...
02:32:47.595 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:55)
02:32:47.595 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Caused by: java.lang.SecurityException: sealing violation: package jdk.internal.jimage is sealed
02:32:47.595 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at java.base/jdk.internal.jrtfs.JrtFileSystemProvider$JrtFsLoader.loadClass(JrtFileSystemProvider.java:147)
02:32:47.595 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at java.base/jdk.internal.jrtfs.SystemImage.open(Unknown Source)
02:32:47.595 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at java.base/jdk.internal.jrtfs.JrtFileSystem.<init>(Unknown Source)
02:32:47.595 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at java.base/jdk.internal.jrtfs.JrtFileSystemProvider.newFileSystem(Unknown Source)
02:32:47.595 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at java.base/jdk.internal.jrtfs.JrtFileSystemProvider.newFileSystem(JrtFileSystemProvider.java:127)
02:32:47.595 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at java.base/jdk.internal.jrtfs.JrtFileSystemProvider.newFileSystem(JrtFileSystemProvider.java:106)
02:32:47.595 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at org.jetbrains.kotlin.cli.jvm.modules.CoreJrtFileSystem$handlers$1.fun(CoreJrtFileSystem.kt:40)
...

@ParkerM I'm afraid the problem you encountered has nothing to do with this issue. This issue (#7811) is simply caused by https://bugs.openjdk.java.net/browse/JDK-8210810 (I'm 100% sure because I submitted this bug report and I fixed this issue for JDK). I have no idea what's going on with your project, but it can't be https://bugs.openjdk.java.net/browse/JDK-8210810 because it only happens on Windows.
It would be great if you can create a reproducible sample of your problem. We'd be glad to investigate and fix it (if it's a bug).

Example here with gradle 5.0: https://travis-ci.com/ParkerM/gradle-jdk11openj9-bug
Docker for windows gives the same error seen in Travis CI here: https://travis-ci.com/ParkerM/gradle-jdk11openj9-bug/builds/92637796

@ParkerM seems like it's a bug in openjdk11-openj9:jdk-<IP_ADDRESS>-alpine-slim. I've created an issue https://github.com/AdoptOpenJDK/jitwatch/issues/293

@blindpirate Awesome reproduction! I've been messing with different configurations for a while and have been able to consistently reproduce the error among different images. (typically the jdk.internal.jimage is sealed error, though it does change under certain circumstances. See the build history for examples of this error.)
I tried using phusion/baseimage with the jdk11-openj9 binaries from AdoptOpenJDK and got the exact same error for the project. I then tried compiling from sources in phusion/baseimage using the instructions from eclipse.org here, cleaned up and rebuilt the image using my generated release and still got the exact same error. I tried with -Xint to rule out JIT/AOT issues and got the same results, only in slow motion. I can't seem to reproduce the error outside of docker.
The hotspot image also threw an error around the same execution stage when I tried it, so it's difficult to determine if the issue lies with gradle/kotlin-dsl, openj9, or jdk11 in general (or perhaps a profound case of PEBKAC). The official Oracle JDK image seemed to work fine when I tried it for a sanity check. The strange occasional changes in the thrown error are what sort of made me think it could be related to the classpath issue.
If you end up locating the correct location for the issue please let me know and I can add any context if needed. Apologies for the noise.

Here it is: https://github.com/AdoptOpenJDK/openjdk-docker/issues/87


150 첨부파일 저장

Closes #150

Codecov Report

Merging #151 (2f5d3dc) into main (5728114) will decrease coverage by 0.72%.
The diff coverage is 8.00%.

@@             Coverage Diff              @@
##               main     #151      +/-   ##
============================================
- Coverage     39.08%   38.35%   -0.73%
- Complexity      172      174       +2
============================================
  Files            92       97       +5
  Lines          1044     1069      +25
  Branches          9       10       +1
============================================
+ Hits            408      410       +2
- Misses          635      658      +23
  Partials          1        1

Impacted Files
Coverage Δ

...ain/attachment/exceptions/AttachmentErrorCode.java
0.00% <0.00%> (ø)

...attachment/exceptions/FileSaveFailedException.java
0.00% <0.00%> (ø)

...cia/domain/attachment/facade/AttachmentFacade.java
5.88% <0.00%> (-1.81%)
:arrow_down:

...ation/payload/response/SaveAttachmentResponse.java
0.00% <0.00%> (ø)

...a/domain/attachment/service/AttachmentService.java
14.28% <14.28%> (ø)

.../attachment/presentation/AttachmentController.java
50.00% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5728114...2f5d3dc. Read the comment docs.


[azidentity] Make env var constants public

Feature Request
I'm wondering why these azidentity constants are private, so I'm asking to make them public so they can be used in applications:
const (
	azureAuthorityHost             = "AZURE_AUTHORITY_HOST"
	azureClientCertificatePassword = "AZURE_CLIENT_CERTIFICATE_PASSWORD"
	azureClientCertificatePath     = "AZURE_CLIENT_CERTIFICATE_PATH"
	azureClientID                  = "AZURE_CLIENT_ID"
	azureClientSecret              = "AZURE_CLIENT_SECRET"
	azureFederatedTokenFile        = "AZURE_FEDERATED_TOKEN_FILE"
	azurePassword                  = "AZURE_PASSWORD"
	azureRegionalAuthorityName     = "AZURE_REGIONAL_AUTHORITY_NAME"
	azureTenantID                  = "AZURE_TENANT_ID"
	azureUsername                  = "AZURE_USERNAME"

	organizationsTenantID   = "organizations"
	developerSignOnClientID = "04b07795-8ddb-461a-bbee-02f9e1bf7b46"
	defaultSuffix           = "/.default"
	tenantIDValidationErr   = "invalid tenantID. You can locate your tenantID by following the instructions listed here: https://docs.microsoft.com/partner-center/find-ids-and-domain-names"
)

source: https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azidentity/azidentity.go#L29

I'm wondering why these azidentity constants are private

The environment variable constants are private because they're typically used to configure applications externally, for example in Kubernetes manifests, and they're easy to copy from the package documentation. So, they've seemed more like clutter than useful public API. Can you describe your use case for setting them programmatically?

to avoid having fixed strings and use constants in applications :)

But what does your application do with them? I'm curious about your scenario because to me it seems unusual for application code to read or set these variables. azidentity reads them where appropriate and they're typically set outside the application.

eg for msgraph-sdk-for which doesn't use azidentity so i have to read environment variables to setup azure environment support.
fine if you want to hide them and just keep them in documentation, just though it might be a good idea to keep them public as i don't see a reason to hide them.

I don't want to derail the conversation, but which msgraph SDK are you using?  If it's this one, there is support for azidentity.

Yes I'm talking about this sdk and yes it's using azidentity but without the automatic Azure environment configuration. If you want AzureChina support you have to do all the stuff in your applications.
My idea was to use constants and was wondering why you're setting these as private and if there is a reason for it. Avoiding typos, having autocompletion instead of digging through the documentation, getting the list of available environment variables which azidentity uses etc.

I see, thanks for clarifying.  Maybe we need to improve support for non-public clouds via env config (presumably this would alleviate the need for the constants to be exported, and also make it easier on SDK users to use non-public clouds).
Generally speaking, we try to export the minimum viable public surface area.  We do this mainly for versioning tolerance; once it's public, we can't change/remove it as we don't want any breaking changes.  This allows us to add/export it later if consumers ask for it (i.e. you can always add it later, but you can't take it back).

Thank you for taking the time to propose and discuss this. I'm marking the issue addressed because at this time we don't plan to export these constants, but please feel free to continue the discussion here if you have more to add. For my part, I believe exporting these constants would be convenient for your scenario, however it doesn't strictly require them and I'm not certain this is a common scenario.


getting invalid_grant with onedrive python sdk code flow authentication

I am using the following codes to do authentication for my onedrive app:
import onedrivesdk
redirect_uri = 'http://localhost:5000/onedriveauth'
client_secret = 'my_client_secret'
client_id='my_client_id'
api_base_url='https://api.onedrive.com/v1.0/'
scopes=['wl.signin', 'wl.offline_access', 'onedrive.readwrite']
http_provider = onedrivesdk.HttpProvider()
auth_provider = onedrivesdk.AuthProvider(
http_provider=http_provider,
client_id=client_id,
scopes=scopes)
client = onedrivesdk.OneDriveClient(api_base_url, auth_provider, http_provider)
auth_url = client.auth_provider.get_auth_url(redirect_uri)
Ask for the code
print('Paste this URL into your browser, approve the app's access.')
print('Copy everything in the address bar after "code=", and paste it below.')
print(auth_url)
code = raw_input('Paste code here: ')
access_token=client.auth_provider.authenticate(code, redirect_uri, client_secret)
But I keep getting invalid grant error.  Can someone explain what I am doing wrong?  Thanks.

I had a similar error, and I solved it using including the redirect_uri in the app registration.

I got the same issue. Thank you hanahana1618, your solution worked like a charm.

Hi @hanahana1618 , I have tried to add the localhost URL in the Microsoft application. But somehow it didn't open the authentication page. It gives me the proxy error in the Chrome browser.
Any idea what would be an issue ?
After changing localhost URL in the code, I'm getting below error.

Thank you for reaching out and for your patience. This SDK is being officially deprecated. See #209 for more information


Piriform.Recuva version 1.54.120

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[ ] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Note that this installer always crashes at the end of the setup, but it should install and run normally.

Automatic Validation ended with:

Installation failed with exit code -1978335226
2024-08-26 00:31:16.610 [CLI ] ShellExecute installer failed:<PHONE_NUMBER>
2024-08-26 00:30:37.966 [CLI ] ShellExecute installer failed:<PHONE_NUMBER>

Automated error analysis suggests -1978335226 may mean Running ShellExecute failed
Automated error analysis suggests<PHONE_NUMBER> may mean Converted to hexadecimal (C0000005) possibly Access Violation. (This is occasionally seen in PRs despite the install otherwise being successful. Should it be added as an InstallerSuccessCode or similar here?)
(Automated response - build 888.)

Is there any chance to review this manually?

Automatic Validation ended with:

Installation failed with exit code -1978335226
2024-08-26 18:06:16.635 [CLI ] ShellExecute installer failed:<PHONE_NUMBER>

Automated error analysis suggests -1978335226 may mean Running ShellExecute failed
Automated error analysis suggests<PHONE_NUMBER> may mean Stack overflow / exhaustion.
(Automated response - build 889.)

Automatic Validation ended with:

Installation failed with exit code -1978335226
2024-08-26 18:06:16.635 [CLI ] ShellExecute installer failed:<PHONE_NUMBER>

Automated error analysis suggests -1978335226 may mean Running ShellExecute failed
Automated error analysis suggests<PHONE_NUMBER> may mean Stack overflow / exhaustion.
(Automated response - build 889.)

Verify:


Gordon/implement distance utilities rebase

a failed attempt to create a cleaner diff view after merger of feature into feature branch


Fullscreen's there, gutters toggle as well. Cook your own distractionfree! :man_cook:


Fix invalid aliasing and uninit memory in CodedOutputStream

See the explanations and discussion in #592.

It looks to me like Miri approves of this, and I can't find anything wrong with it by eye (not that I'm any good at that). You should run cargo miri test if you can in CI with -Zmiri-tag-raw-pointers. It's nice to have a good grasp of the rules, but running a checker lets you not worry about messing up in the future.
You construct the buffer pointer to a slice by using the implicit conversion from &mut to *mut. I personally hate these implicit conversions and I'm slowly campaigning to get lints added against them. They make it too easy to use &mut when you don't need to. In this case, you can call ptr::slice_from_raw_parts_mut which is actually how slice::from_raw_parts_mut is implemented.
Using a pointer to a slice is an uncommon choice. I suppose it's nice that you get bounds checking on access into it, just in case the manual bounds checks end up incorrect. But if we're worried about speed a lot here, you could use a normal raw pointer. Of course keeping it associated with its length is not always elegant, so either choice makes sense to me.
I'm not sure "we own the buffer" is a very helpful safety comment. The standard in the compiler is to document what the requirements of the unsafe interface you're using, and explain how you're making sure that those requirements are followed. I'm not saying I have a much better suggestion to replace this with, but the requirement you need to uphold is that the pointer is valid. So maybe something like "This type creates this pointer from a slice then never modifies the pointer or the backing array"?

You should run cargo miri test if you can in CI with -Zmiri-tag-raw-pointers

It already does that https://github.com/stepancheg/rust-protobuf/blob/3a54a7a4a65fcf1527f6f6a369a2eab10a9dad62/.github/workflows/ci.yml#L279

Thanks!


Replace CSS CR LF with LF

This pull request derives from #366. So needs to be handled after that.

The line ending of test/test-report.css in the repository may be (and actually is) CR LF.
When it's loaded into the test result HTML, the HTML has line endings mixed with CR LF and LF.
This pull request always replaces CR LF in CSS with LF.
I manually tested the pull request and verified these things:

xspec.bat -c tutorial\coverage\demo.xspec generates demo-coverage.html and demo-result.html which are essentially the same as the current master (cfcbdf2b99d6a113de07bc1c9f7a59a397db2f6a) and that the HTML files no longer mix CR LF and LF.
ant -lib "saxon9ee.jar" -Dxspec.xml=tutorial\coverage\demo.xspec -Dxspec.coverage.enabled=true generates the same demo-coverage.html and demo-result.html as the ones generated by xspec.bat except for timestamp.
java -cp "xmlcalabash.jar" com.xmlcalabash.drivers.Main -i source=tutorial/coverage/demo.xspec -p xspec-home=file:///[XSpec]/ -o result=tutorial/coverage/demo-result.html src\harnesses\saxon\saxon-xslt-harness.xproc generates demo-result.html which is essentially the same as the current master.

@cirulls
Merged this bug fix.


Add possibility to set custom buckets for histograms

Histograms in Prometheus have default buckets ranges, which are suited for HTTP requests.
I would like to use them to measure tasks which can last up to one hour, so I've added a possibility to define custom buckets.

I've worked around this directly in master. Thank you for the PR :)


Proposal: copy request headers from initial conn into redirect/navigate conn

We encounted a problem where the request headers set before the initial visit/2 are not present in subsequent redirects. Could there be a configuration that always copies request headers to the next request, or a way to inject a before redirect callback that could allow us to modify the conn ahead of time. Also there is an option for Phoenix.ConnTest.recycle/2 that instructs which request headers to carry forward when recycling the conn, so it would be great to have a way to set that option. https://hexdocs.pm/phoenix/Phoenix.ConnTest.html#recycle/2
Linked is a gist using phoenix_playground that demonstrates a failure case.
https://gist.github.com/joeytrapp/35c984a67cf2eb6eb0f6f4b3ef9e060f

The only case I can think up for not wanting the request headers to always all be copied would be if the initial request had some specialized headers that subsequent requests wouldn't have when the browser followed a redirect. This case wouldn't affect us, so I don't have a specific scenario.


Move onchain users stats higher up the page [JS]

Easy, but blocked on #189

Updated with latest version. Users appear at top of page now.


Three Way Merge Sort in C++ [GSSOC'21]

I can implement Three Way Merge Sort in C++ as part of GSSOC'21. Kindly assign this issue to me

I want to work on this issue using C++. Kindly assign me .

@raksha009  Kindly assign this issue to me.


How hard would it be to adapt this abstraction to MySQL?

Hey 👋 ,
I'm one of the developers who worked on https://github.com/snaplet/postgres-wasm, I'm super happy to see that our work helped and that you were able to pull this off to make it usable! I added a shoutout to this project in the README. 😍
I see that you wrote an entire network adapter for it which I suppose is at the emulator level, so I'm wondering how hard it would be to have MySQL running in the browser now.
Again, congrats, mad work!

Thanks for adding this to the README, very much appreciated! I haven't tried MySQL (or anything else but Postgres), but yes, it should be possible. The network stack is a minimal implementation of TCP and UDP, and anything that runs on those should theoretically work.
Do you guys have a specific use case in mind?

Do you guys have a specific use case in mind?

The main use case to me is integration/e2e tests with in-memory databases. But I guess a network adapter wouldn't be needed in a Node.js environment. 🤔
We already have SQLite and PostgreSQL now with your project and PGlite, so I guess MySQL will be the only missing one from the big 3. 😄
Anyway, I don't want to pollute your issues, so I'll close that. I joined your Discord. 👍


Fix compilation with --cfg doc

Fixes #383
Does this fix your issue @fpoli?

Yes, thank you. With this revision cargo doc works fine. What I used to test is:
mkdir new-test-crate
cd new-test-crate
cargo init
cargo add --git https://github.com/rust-lang/socket2.git --rev 7b1e1ad841ffdb754ce534dc817c749d8211cc1d
RUSTDOCFLAGS="--generate-link-to-definition -Zunstable-options" cargo +nightly doc

Without the --rev 7b1e1ad841ffdb754ce534dc817c749d8211cc1d the last command fails, as reported in https://github.com/rust-lang/socket2/issues/383.


Fix bug in execpath.ts

A small bug fix - execpath.ts was using process.execPath() instead of process.execPath in Bun and Node. Also, execPath's return type was set to Promise<string> when it should have been string.

Nice 👍


Argon deleting things

I'll try and gather up some evidence but this is extremely annoying and can break games, maybe I'm just not using this correctly but this hasn't been an issue before. I noticed when duplicating an object in the workspace is deleted the dupe, and just other random important things too. I've tried Client, Server, and none but i don't really understand what's going on.

Could you please provide more details on what exactly happens or create a repro?

Closing this issue due to inactivity, feel free to reopen it.


build: docker compose for backend.

We can use docker-compose to run the PostgreSQL database and backend server on two connected Docker files, making it easier to set up a dev environment for the backend. Something like this:
version: '3'
services:
  postgres:
    image: postgres:latest
    environment:
      POSTGRES_DB: zenohub
      POSTGRES_USER: myuser
      POSTGRES_PASSWORD: mypassword
      PGDATA: /var/lib/postgresql/data/pgdata
      POSTGRES_INITDB_ARGS: "--data-checksums"
    volumes:
      - postgres-data:/var/lib/postgresql/data
  python-server:
    build: .
    ports:
      - "5000:5000"
    depends_on:
      - postgres
    environment:
      DB_HOST: postgres
      DB_USER: myuser
      DB_PASSWORD: mypassword

This sounds like a very good idea to me. Could setup the DB and add env vars automatically. Could also probably remove the database.ini in that case since we can just set env variables in Docker.

I'd suggest running the DB in a different docker because when actually deploying them we'd want to deploy on different servers, and using docker compose might complicate things.

I was thinking we only use docker compose for local development. We keep the dockerfiles as is for the production deployment setup on terraform.

Agh this gets a little complicated with live development and pushing changes to the docker server... Not sure if its worth it.
The biggest pain points I see for development are:

Setting up the SQL tables and getting postgres running
Setting all the right environment variables

Maybe there's a better way of fixing this without Docker which adds a lot of complexity on its own...


[ADAM-1039] Add basic support for Sample record.

Resolves #1039.
Arguably, a bit of work to do.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1322/Build result: FAILUREGitHub pull request #1077 of commit a981d39658927a68ef3227f8993b37348b459210 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prb > /home/jenkins/git2/bin/git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git -c core.askpass=true fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1077/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a --contains a30c661490c18049c80471e48f4be1c0965f0fe9 # timeout=10 > /home/jenkins/git2/bin/git rev-parse remotes/origin/pr/1077/merge^{commit} # timeout=10Checking out Revision a30c661490c18049c80471e48f4be1c0965f0fe9 (origin/pr/1077/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f a30c661490c18049c80471e48f4be1c0965f0fe9First time build. Skipping changelog.Triggering ADAM-prb ? 2.6.0,2.11,1.5.2,centosTriggering ADAM-prb ? 2.6.0,2.10,1.5.2,centosTouchstone configurations resulted in FAILURE, so aborting...Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1323/
Test PASSed.

LGTM
@jpdna the join here is on Sample.sampleId (source), can you confirm that is what you were after originally?

Rebased!

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1351/
Test PASSed.

@jpdna the join here is on Sample.sampleId (source), can you confirm that is what you were after originally?

Yes - LGTM

Merged commit 4b6e107c442a55e3229b45a3990473224f856228.
Thank you, @fnothaft!


CLI for even more power

Usage: racko

Thank you elia, this is going to enable the real racko's power.


Lyro merge

As discussed on IRC.

I've looked at the changes. They look good, I just have one question: why did you remove the Quassel support?

Because it dead since 2014 and nobody used it.
We can revert it when its updated.

Ok, if Quassel is dead then I'm OK with removing the support. Merging this PR now. Thank you guys for your awesome work.
I plan to look into updating the design of the app pushing the updated version to the store.


Display the count of row

SQL Operations Studio Version:
0.29.3

Steps to Reproduce:
Make a Select, Delete, Update or anything request on your table
I would like see the count of row affected by a transaction, (to be sure I do not do a stupidity) but I don't know where is this information :(

Thanks, this is where I looked but it was not displayed.
I restarted my pc and since then appears :)


Support Python 3.8

@kmuehlbauer - can we revert back to supporting Python 3.8? According to the Python PEPs, we have another year or so until we need to move onto 3.9 for the minimum supported version
https://endoflife.date/python
The Py-ART CI is failing this morning due to not being able to support 3.8

Nevemind @kmuehlbauer - I checked into it more, and it looks like we are nearing the end of support there, with the Xarray related merged PR
https://github.com/ARM-DOE/pyart/pull/1384
I am working on updating our CI accordingly. Closing!

@mgrover1 Yes, I was following the tracks of xarray which also drop 3.8.


Fixed: Remove duplicate event handler for collapsible in modals

Fixed: Remove duplicate event handler for collapsible in modals
OF-13169
When a modal opens, we search for interactive elements
and trigger jQuery plugins/behaviors in bindObservers
function. This function searches for HTML elements and
starts needed behavior, using this logic:
$(wrappingElement).find(selector).each([behavior]);
This means that all 'selector' in 'wrappingElement'
initially present in the page will be triggered.
When we open a modal, we call bindObservers again
within the modal, to trigger interactive elements
which are in the modal.
For collapsible (and some others behaviors), we use
$(wrappingElement).on('click', doStuff);
...but the jQuery 'on' method also affects
DOM elements that are dynamically added to the
page, like modals content. So for these behaviors,
event handlers for interactive elements are created
twice. So when we click on the "+" of a collapsible
in a modal, "toggleCollapsiblePanel" is called twice,
and the collapsible section is open and closed right
away

Thanks Florian,
I tested but did not review seriously, hopefully there will be no regressions.
If ever we will handle them. We use CTR https://www.apache.org/foundation/glossary#CommitThenReview)

OK @JacquesLeRoux !


Removed Wunderground from the list

Removed the Wunderground API since they are no longer offering free keys

Thank you for taking the time to work on a Pull Request for this project!
To ensure your PR is dealt with swiftly please check the following:

[x] Your submissions are formatted according to the guidelines in the contributing guide
[x] Your additions are ordered alphabetically
[x] Your submission has a useful description
[x] The description does not end with punctuation
[x] Each table column should be padded with one space on either side
[x] You have searched the repository for any relevant issues or pull requests
[x] Any category you are creating has the minimum requirement of 3 items
[x] All changes have been squashed into a single commit

Thanks!


New version: Coder.Coder version 0.25.0

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] This PR only modifies one (1) manifest
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.4 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

🤖 cc: @deansheather @matifali


SliverGeometry is not valid: The "layoutExtent" is negative.

════════ Exception Caught By rendering library ═════════════════════════════════════════════════════
The following assertion was thrown during performLayout():
SliverGeometry is not valid: The "layoutExtent" is negative.

The RenderSliver that returned the offending geometry was: RenderSliverOverlapAbsorber#e405e relayoutBoundary=up1 NEEDS-LAYOUT NEEDS-PAINT
...  needs compositing
...  parentData: paintOffset=Offset(0.0, 490.2) (can use size)
...  constraints: SliverConstraints(AxisDirection.down, GrowthDirection.forward, ScrollDirection.idle, scrollOffset: 0.0, remainingPaintExtent: 0.0, crossAxisExtent: 414.0, crossAxisDirection: AxisDirection.right, viewportMainAxisExtent: 712.0, remainingCacheExtent: 90.9 cacheOrigin: 0.0 )
...  geometry: SliverGeometry(scrollExtent: 0.0, hidden, layoutExtent: -56.0, maxPaintExtent: 56.0, hasVisualOverflow: true, cacheExtent: -56.0)
...    scrollExtent: 0.0
...    hidden
...    layoutExtent: -56.0
...    maxPaintExtent: 56.0
...    hasVisualOverflow: true
...    cacheExtent: -56.0
...  handle: SliverOverlapAbsorberHandle(56.0null)
When the exception was thrown, this was the stack:
#0      SliverGeometry.debugAssertIsValid.<anonymous closure>.verify (package:flutter/src/rendering/sliver.dart:711:9)
#1      SliverGeometry.debugAssertIsValid.<anonymous closure> (package:flutter/src/rendering/sliver.dart:720:13)
#2      SliverGeometry.debugAssertIsValid (package:flutter/src/rendering/sliver.dart:745:6)
#3      RenderSliver.debugAssertDoesMeetConstraints (package:flutter/src/rendering/sliver.dart:1198:21)
#4      RenderObject.layout.<anonymous closure> (package:flutter/src/rendering/object.dart:1621:19)
...

When the exception was thrown, this was the stack:
#0      SliverGeometry.debugAssertIsValid.<anonymous closure>.verify (package:flutter/src/rendering/sliver.dart:711:9)
#1      SliverGeometry.debugAssertIsValid.<anonymous closure> (package:flutter/src/rendering/sliver.dart:720:13)
#2      SliverGeometry.debugAssertIsValid (package:flutter/src/rendering/sliver.dart:745:6)
#3      RenderViewportBase.layoutChildSequence (package:flutter/src/rendering/viewport.dart:422:34)
#4      RenderViewport._attemptLayout (package:flutter/src/rendering/viewport.dart:1334:12)
...
                                         You can include small examples inline if they're enclosed by backticks, or just provide a public link to a github "gist" - https://gist.github.com/.
Please provide your flutter doctor -v output.
This is a question better suited for StackOverflow, since probably there is no anything wrong with Flutter itself, but related to implementation. Please consider to post it there as well as help there may come faster.

Hello @ishizhen !
Without additional information, we are unfortunately not sure how to resolve this issue. We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the issue, if you have any more information for us; we will reopen it right away!
Thank you for your contribution.
P.S. If anyone still experience the same problem, please file a new issue with the information required in the template.
All system setups can be slightly different so it’s always better to open new issues and reference related issues.

@Piinks thank you so much for work on this. Now we dont have this issue in release, but have this issue in debug builds.
Output for my flutter doctor:
🙏  <ॐ>
╰─~ flutter doctor -v                                                                                [19:19:03]
[✓] Flutter (Channel beta, 1.23.0-18.1.pre, on Linux, locale en_IN)
    • Flutter version 1.23.0-18.1.pre at /home/raveesh/Dev/Tools/flutter
    • Framework revision 198df796aa (2 weeks ago), 2020-10-15 12:04:33 -0700
    • Engine revision 1d12d82d9c
    • Dart version 2.11.0 (build 2.11.0-213.1.beta)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /home/raveesh/Android/Sdk
    • Platform android-29, build-tools 30.0.2
    • Java binary at: /home/raveesh/Dev/Tools/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Chrome - develop for the web
    • Chrome at google-chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /home/raveesh/Dev/Tools/android-studio
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2020.2)
    • IntelliJ at /home/raveesh/Dev/Tools/idea-IC-202.6948.69
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.50.1)
    • VS Code at /usr/share/code
    • Flutter extension version 3.15.1

[✓] Connected device (2 available)
    • Web Server (web) • web-server • web-javascript • Flutter Tools
    • Chrome (web)     • chrome     • web-javascript • Google Chrome 86.0.4240.111

• No issues found!

Hi @raveesh-me can you please file a new issue with a runnable sample of code that reproduces this issue? Thanks!


fixing typo in available command line options

Category

[x] Content fix
[ ] New article
Related issues: fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?
Fining typo in help and command line section and arguments

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/spfx/toolchain/scaffolding-projects-using-yeoman-sharepoint-generator.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

thx Stefan, appreciated.


Clipboard Space

Using the clipboard button adds and extra space at the very end of the command once executed. This sometimes creates issues when trying to execute a multi step command (See https://docs.osmosis.zone/developing/keys/tmkms.html#prepare-tmkms-dependencies the rust command for an example)

Fixed


Background color for next/prev page row

Is it possible to specify in some way which background color should be on the row with first/prev/next/last page row?
In my application now it defaults to white with a black background on the next/last page buttons. I have tried all kinds of things in css etc to change that black background, but no luck. See attached screenshot.

Hello,
for now there is no possibility to change pagination css styles. I will add this feature into next bigger release which will coming this week (I hope on wednesday or thursday)

With new verison of nuget you can use:
builder.AppendCssClasses(conf =>
{
    conf.FooterCssClasses.FooterWrapper = "cssClassName";
});


Wrong XML in the example or misleading description of  tag

The  tag is used to describe parameters. If such a tag is used, the documentation generator must verify that the specified parameter exists and that all parameters are described in documentation comments. If such verification fails, the documentation generator issues a warning.

This comment and D.3.9. example made me think that name attribute in <param> tag are mandatory, however, in D.5. section <param> tags do not have name attribute

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: db74e905-523c-dae9-f741-af5e52785a9c
Version Independent ID: c9b7c7a1-0584-b6e6-95cd-5276788fdda0
Content: Documentation comments - C# language specification
Content Source: standard/documentation-comments.md
Product: dotnet-csharp
Technology: csharp-spec
GitHub Login: @dotnet-bot
Microsoft Alias: wiwagn

@jskeet
The sample in D.5 should change. It should include the name attribute on the param element.
You can assign this to me and set the C# 8 milestone. It shouldn't slow down the C# 7 standardization, but it's a rather easy fix.


improvement do not cooldown tablet without cold data

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall


backports.pp: correct example

The example treated this like a defined type, but it's a class.

@kenyon Thanks for the fix :)
Will merge it now


Invalid message error with Etcher

Etcher version: version 1.0.0-Beta.16
Operating system and architecture: Windows 7 Professional (32 Bit)
Do you see any meaningful error information on DevTools?
Nothing opens when I press  Ctrl+Alt+I,

I am using Etcher to Flash an ISO file of Zorin OS and  errors occur. See the attached screen dump

Hm, that's really strange. I can't spot any issue on the JSON object being presented. I'll install Windows 7 and give it a go and see if I can reproduce over here.

@jviotti there are two JSON objects there. Is it possible that two messages are being combined in the data stream?

I don't know, (don't think your question was at me). I need more RAM, the
reason I am trying to install Zorin OS. I will reinstall Etcher and try
again.
On Nov 25, 2016 11:57 PM, "Wasabi Fan"<EMAIL_ADDRESS>wrote:

@jviotti https://github.com/jviotti there are two JSON objects there.
Is it possible that two messages are being combined in the data stream?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/resin-io/etcher/issues/898#issuecomment-263026410,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AWpRmqa9_YQ7EhP5HvK4ubXBLQ-7Mfddks5rB1nagaJpZM4K8rf-
.

The Etcher program resolved. I installed more RAM and Etcher Flashed the ISO file with no problem, indicating it was a RAM problem. However I can't install Zorin OS as there is no folder on my desktop when I reboot with this Flash Drive flashed by Etcher. I know it is a Zorin issue, but can anybody advise me what to do?

I see now there is a way I can ask for help on the Zorin site. Going to do this now.

I installed more RAM and Etcher Flashed the ISO file with no problem, indicating it was a RAM problem.

I doubt its a RAM problem. Its probably an sporadic throttling issue of the IPC communication between the CLI and the GUI as @WasabiFan pointed out. I'll try to trigger this issue myself here.

If @Agmka is indeed running low on RAM, then maybe his system was swapping heavily (i.e. really high IO load), and that's why the GUI missed one of the IPC messages and tried consuming two at once?
Given that it looks like the JSON objects are printed one-per-line, maybe this issue would be resolved by splitting the IPC message on newlines, and only trying to parse the last line as a JSON object?

I sent a fix here: https://github.com/resin-io/etcher/pull/997. See the commit body for an explanation of the underlying issue.
@lurch Do you think it makes any difference to emit different messages for each line encountered here instead of just emitting the last one?
If the machine is having issues processing IPC messages at a fast rate, emitting every message might cause the machine to keep missing more messages.

Okay, I ended up only emitting the last one, since missing progress state events doesn't have any negative effect, and there is no advantage on processing multiple progress state objects coming at almost the same time.

Is it "guaranteed" that e.g. we won't get a progress message after an error message?
With
progress X
progress Y

then it's obviously fine to only send the last progress Y message, but with
error Z
progress Y

then we wouldn't want to miss the error message by only sending the progress message?

Great observation! I'll send a PR fixing this in a minute.


StaticGraphEmbedding

Thank you for your contributions. I am confusing about the function of StaticGraphEmbedding, and I do not find the implementation of this function. May be I ignore some what or where can I find this function? Thank you for your help!

Hi, here you have the code for this class:
https://github.com/TorchSpatiotemporal/tsl/blob/main/tsl/nn/base/embedding.py
In practice, this object provides an identifier for each node in the form of trainable parameters (different for each node).

Thank you for your help!


linux-sgx: allow to open files with arbitrary pathes in the sandbox using IPFS.

Hello,
A limitation of the current implementation of SGX IPFS in WAMR prevented to openof files which were not in the current directory. This restriction is lifted and can now open files in paths, similarly to the WASI openat call, which takes into account the sandbox of the file system.
Under the scenes, SGX IPFS retrieves the path of the symbolic link of the file descriptor using /proc/self and resolves the path of the opened file using readlink.
Cheers

Hey @wenyongh,
Thanks for your insights! I have reviewed, commented and applied the changes.
Let me know if you have other feedback or concerns.
Cheers

@JamesMenetrey Thanks a lot! It is much better now, I will merge the PR after the CI checks finish.


Update/ rewrite webconsole to recent dependency versions

Hi,
I am currently trying to add some features to the webconsole that we find interesting.
While I am just starting to learn React JS development, I noticed that almost all used dependencies are outdated, which does not allow me to integrate new features easily.
I was wondering if it would be helpful to re-write the webconsole frontend, using a better integration of the used tools (babel, webpack, eslint and so on), and also make the used configuration files easier to understand. I am working on this currently because it helps me understand the code better, and I can open a PR to share my changes later.
Please contact me if you consider this a helpful contribution!
Best,
Laura

Hi @LaumiH
Thanks for your message.
I think your contribution is helpful to the free5GC project.
You can create the pull request directly and we will arrange the developer, who has responsible for   frontend development, to review these changes.
Thanks again.

Hi @ianchen0119,
thank you for your reply!
I have almost completed my work on this issue.
There are also a few new features I would like to share with you (in a separate PR).
As the original webconsole code is basically not existing any more (I updated almost everything), I have written a concise summary on all the changes I have made, and the decisions behind them. This will hopefully help merging the PR.
I will prepare a PR as soon as I have a mergeable version.
Cheers,
Laura

@LaumiH @ianchen0119 we have another implementation of the webconsole.  let us share it as well.

@kishiguro
Thanks for you contribution!

@LaumiH @ianchen0119 Just made PR https://github.com/free5gc/webconsole/pull/47
Major difference is it uses typescript and material UI for the implementation.
typescript's API type definition is generated from openapi YAML.

As PR #43 was rejected, I close this issue, because #47 is no refactoring with newer dependency versions. Please open a new issue for the different goal of using TypeScript and Material UI.


python312Packages.quart: 0.19.5 -> 0.19.6

https://github.com/pallets/quart/blob/refs/tags/0.19.6/CHANGES.rst
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 313024 run on x86_64-linux 1

2 packages marked as broken and skipped:

python311Packages.vllm
python311Packages.vllm.dist

2 packages failed to build:

dyndnsc
dyndnsc.dist

18 packages built:

dep-scan
dep-scan.dist
python311Packages.aioprometheus
python311Packages.aioprometheus.dist
python311Packages.json-logging
python311Packages.json-logging.dist
python311Packages.quart
python311Packages.quart-cors
python311Packages.quart-cors.dist
python311Packages.quart.dist
python312Packages.aioprometheus
python312Packages.aioprometheus.dist
python312Packages.json-logging
python312Packages.json-logging.dist
python312Packages.quart
python312Packages.quart-cors
python312Packages.quart-cors.dist
python312Packages.quart.dist


Fix iterator over symbol when multiple children have the same name

Description
In the current version of MXNet iterating over grouped symbol containing duplicates is impossible:
>>> import mxnet as mx
>>> a = mx.sym.Variable('data')
>>> b = a + a
>>> for c in b.get_children();
>>>    pass
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/runner/.local/lib/python3.6/site-packages/mxnet/symbol/symbol.py", line 93, in <genexpr>
    return (self[i] for i in self.list_outputs())
  File "/home/runner/.local/lib/python3.6/site-packages/mxnet/symbol/symbol.py", line 517, in __getitem__
    raise ValueError('There are multiple outputs with name \"%s\"' % index)
ValueError: There are multiple outputs with name "data"

This PR fixes that.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)

@ptrendx Thanks for fixing this.
@mxnet-label-bot Add [Symbol, backend, pr-awaiting-review]

LGTM

@Roshrini @sandeep-krishnamurthy  could you help merge this?


Be more tolerant about under-defined spatial viewport state

Don't crash when the saved editor state contains fewer viewports than currently supported.
Currently the spatial viewport will crash with an index out of bounds error when the state that is being set contains settings for fewer than 4 viewports.
The change should have no consequences for "normal" set_state usage, but increases the usefulness of #26535 since it allows the settings for just the first viewport to be changed.

I refactored the change a bit. Converted the error into a warning and only apply the state of as many viewports as are supported.

Thanks!

Cherry-picked for 3.1.1.


CLI: lint Redshift DDL?

Not sure how we would do this:

Use a live Redshift database?
Strip Redshift-specific DDL and use a local Postgres?
...?

Migrated


Error:

Getting this error...Would you be able to provide assistance?
In my system.config file I added the following:
map{
'angular2-contextmenu':       'node_modules/angular2-contextmenu/angular2-contextmenu.js'
},
packages{
'angular2-contextmenu':{
"defaultExtension":'js'
},
}
Then included the ContextMenuModule inside of app.module.ts.
This error occurs when I implement you examples defined here and here
Error: (SystemJS) XHR error (404 Not Found) loading http://localhost:3000/node_modules/angular2-contextmenu/src/contextMenu.options
Error: XHR error (404 Not Found) loading http://localhost:3000/node_modules/angular2-contextmenu/src/contextMenu.options
at XMLHttpRequest.wrapFn [as _onreadystatechange] (http://localhost:3000/node_modules/zone.js/dist/zone.js:698:29)
at ZoneDelegate.invokeTask (http://localhost:3000/node_modules/zone.js/dist/zone.js:265:35)
at Zone.runTask (http://localhost:3000/node_modules/zone.js/dist/zone.js:154:47)
at XMLHttpRequest.ZoneTask.invoke (http://localhost:3000/node_modules/zone.js/dist/zone.js:335:33)
Error loading http://localhost:3000/node_modules/angular2-contextmenu/src/contextMenu.options as "./src/contextMenu.options" from http://localhost:3000/node_modules/angular2-contextmenu/angular2-contextmenu.js
at XMLHttpRequest.wrapFn [as _onreadystatechange] (http://localhost:3000/node_modules/zone.js/dist/zone.js:698:29)
at ZoneDelegate.invokeTask (http://localhost:3000/node_modules/zone.js/dist/zone.js:265:35)
at Zone.runTask (http://localhost:3000/node_modules/zone.js/dist/zone.js:154:47)
at XMLHttpRequest.ZoneTask.invoke (http://localhost:3000/node_modules/zone.js/dist/zone.js:335:33)
Error loading http://localhost:3000/node_modules/angular2-contextmenu/src/contextMenu.options as "./src/contextMenu.options" from http://localhost:3000/node_modules/angular2-contextmenu/angular2-contextmenu.js

I don’t understand SystemJS very well at all.  Updating that demo has been on my todo list for a long time, but I haven’t done it because I get lost every time I look at the system js config file.  If you want to give me a primer on how system js works, I’d be happy to help you with any issues with the angular2-contextmenu library itself.

On Mar 2, 2017, at 2:50 PM, Jerrid Matthews<EMAIL_ADDRESS>wrote:
Getting this error...Would you be able to provide assistance?
In my system.config file I added the following:
map{
'angular2-contextmenu': 'node_modules/angular2-contextmenu/angular2-contextmenu.js'
},
packages{
'angular2-contextmenu':{
"defaultExtension":'js'
},
}
Then included the ContextMenuModule inside of app.module.ts.
This error occurs when I implement you examples defined here http://plnkr.co/edit/wpJXpEh4zNZ4uCxTURx2?p=preview and here https://github.com/isaacplmann/angular2-contextmenu/blob/master/README.md
Error: (SystemJS) XHR error (404 Not Found) loading http://localhost:3000/node_modules/angular2-contextmenu/src/contextMenu.options http://localhost:3000/node_modules/angular2-contextmenu/src/contextMenu.options
Error: XHR error (404 Not Found) loading http://localhost:3000/node_modules/angular2-contextmenu/src/contextMenu.options http://localhost:3000/node_modules/angular2-contextmenu/src/contextMenu.options
at XMLHttpRequest.wrapFn [as _onreadystatechange] (http://localhost:3000/node_modules/zone.js/dist/zone.js:698:29 http://localhost:3000/node_modules/zone.js/dist/zone.js:698:29)
at ZoneDelegate.invokeTask (http://localhost:3000/node_modules/zone.js/dist/zone.js:265:35 http://localhost:3000/node_modules/zone.js/dist/zone.js:265:35)
at Zone.runTask (http://localhost:3000/node_modules/zone.js/dist/zone.js:154:47 http://localhost:3000/node_modules/zone.js/dist/zone.js:154:47)
at XMLHttpRequest.ZoneTask.invoke (http://localhost:3000/node_modules/zone.js/dist/zone.js:335:33 http://localhost:3000/node_modules/zone.js/dist/zone.js:335:33)
Error loading http://localhost:3000/node_modules/angular2-contextmenu/src/contextMenu.options http://localhost:3000/node_modules/angular2-contextmenu/src/contextMenu.options as "./src/contextMenu.options" from http://localhost:3000/node_modules/angular2-contextmenu/angular2-contextmenu.js http://localhost:3000/node_modules/angular2-contextmenu/angular2-contextmenu.js
at XMLHttpRequest.wrapFn [as _onreadystatechange] (http://localhost:3000/node_modules/zone.js/dist/zone.js:698:29 http://localhost:3000/node_modules/zone.js/dist/zone.js:698:29)
at ZoneDelegate.invokeTask (http://localhost:3000/node_modules/zone.js/dist/zone.js:265:35 http://localhost:3000/node_modules/zone.js/dist/zone.js:265:35)
at Zone.runTask (http://localhost:3000/node_modules/zone.js/dist/zone.js:154:47 http://localhost:3000/node_modules/zone.js/dist/zone.js:154:47)
at XMLHttpRequest.ZoneTask.invoke (http://localhost:3000/node_modules/zone.js/dist/zone.js:335:33 http://localhost:3000/node_modules/zone.js/dist/zone.js:335:33)
Error loading http://localhost:3000/node_modules/angular2-contextmenu/src/contextMenu.options http://localhost:3000/node_modules/angular2-contextmenu/src/contextMenu.options as "./src/contextMenu.options" from http://localhost:3000/node_modules/angular2-contextmenu/angular2-contextmenu.js http://localhost:3000/node_modules/angular2-contextmenu/angular2-contextmenu.js
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/isaacplmann/angular2-contextmenu/issues/53, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0lQNxJgtH3NxA1__MTZuiE17dl7RI9ks5rhx2VgaJpZM4MRciU.

SystemJS is essentially a package manager. It looks for a main file (index or in this case angular2-contextmenu.js) and performs the necessary linkages in the JS file. Now, I'm not experienced yet w/ Angular to know how Angular handles these compilations. However basically it seems as though it exports the compiled packages to a System.config variable.
Hmm, would it be possible to try another alternative? If I were to import your source code to my project would be possible to simply drop the folders in or are there other dependancies needed?

There aren't any package dependencies, other than Angular itself.  I know you can use SystemJS with Angular, but I don't know how it sets everything up.
It may be that I need to bundle the library in a special way to allow people to import it with SystemJS (as opposed to webpack).  There are lots of different options for module output (CommonJS, UMD, others?).  I stopped tinkering with my build process once I got it to work for webpack.
Build process is not fun.

No it's not :( ... I was able to just now successfully import just your files in the src folder...The webpage atleast loads now. However, when I click the button I get an error. Let me investigate and I'll post to you.

Ok, so when I click the link nothing pops up. I'm using the example code from the demo here:
http://plnkr.co/edit/wpJXpEh4zNZ4uCxTURx2?p=preview
When I click the link the view doesn't popup, however the callback function fires but this code doesn't show the popup.
this.contextMenuService.show.next({
actions: this.menuOptions,
event: $event,
item:item
});

So your onContextMenu function is called, but the angular2-contextmenu doesn't actually show.  This demo actually uses an old method of triggering the context menu, so that only makes things messier.  Here is the new syntax.

Have you included <contextmenu></contextmenu> somewhere in the component template?
What is this.menuOptions?  Have you tried putting <template> tags inside of <contextmenu> instead of using the actions property of the contextMenuService?
Can you look at the DOM to see if the context menu is added, but isn't being shown because of css problems?

I forgot to include: . However, the menu displays at the top of the page and not where I clicked. How would I go about making the contextmenu appear where the user left clicked? Would this require modifying CSS or is there an attribute property?

What is the $event that is being passed in?  Is it a MouseEvent?

yes

The context menu should automatically be placed at the point { $event.clientX, $event.clientY }
Can you verify that the event has correct clientX and clientY values?

And can you send me your SystemJS config so that I can get an updated plunker working?

As for the Dropdown location: I think the X,Y values are relative to the Container that the box is being clicked in rather than global values. For instance the click location is X: 224 Y: 345 and the window shows up at top:345 and left:224, but the actual click location is not there, so it's not adding the global position. Is what it seems.
SystemJS.config has the following attributes, and this was what I included to the "map" and "packages" field. However, the error I originally pasted was the result of this. I do know that this is prettymuch the propper config, but there's some files that aren't included in the main file "angular2-contextmenu.js."
map{
'angular2-contextmenu': 'node_modules/angular2-contextmenu/angular2-contextmenu.js'
},
packages{
'angular2-contextmenu':{
"defaultExtension":'js'
},
}

I've been working on bugs like this for the last month or two.
I'll need to know the css properties on all the ancestors of the  element.  Specifically, any position or transform properties.
And what version of angular2-contextmenu are you using?

Hmm, is there a way for me to mod the context menu css to float center screen?

Yep.  Like this:
.angular2-contextmenu .dropdown-menu {
  top: 50vh !important;
  left: 50vw !important;
  margin-top: -100px !important; // half the height of the menu
  margin-left: -50px !important; // half the width of the menu
}

Thanks...I decided to do something else:

In your file contextMenu.component, removing "adjustX" and "adjustY" for mouseLocation makes the panel show up exactly where I click...I'm now trying to add a left/right side offset so that I can have the panel open on right side vs the left side of the button click.

In other words, when I click the button and lets say the buttons' on the right side of the page, the panel expands and it's off the screen. So if I add a feature that offset's it "left" location then that solves the problem.


mark bad NISTs as bad in gregor auth

they were just being sent up repeatedly
fail to find the original bug that mike found, but add more debugging

Output looks like:
2018-04-26T13:27:17.586220-04:00 ▶ [DEBU keybase nist.go:98] 64c NISTFactory#NIST: returning existing NIST (expires conservatively in 3.350910359s, expiresAt: 2018-04-27 17:27:10.937428 -0400 EDT m=+100843.164397089) [tags:API=SA5qIjX4BEht]
2018-04-26T13:27:17.957900-04:00 ▶ [DEBU keybase nist.go:98] 67b NISTFactory#NIST: returning existing NIST (expires conservatively in 2.979213179s, expiresAt: 2018-04-27 17:27:10.937428 -0400 EDT m=+100843.164397089) [tags:API=6ZKUprvCzG8a]
2018-04-26T13:27:18.352608-04:00 ▶ [DEBU keybase nist.go:98] 6aa NISTFactory#NIST: returning existing NIST (expires conservatively in 2.584487552s, expiresAt: 2018-04-27 17:27:10.937428 -0400 EDT m=+100843.164397089) [tags:API=vt_pEJKe11UH]
2018-04-26T13:27:18.711850-04:00 ▶ [DEBU keybase nist.go:98] 6d9 NISTFactory#NIST: returning existing NIST (expires conservatively in 2.225229964s, expiresAt: 2018-04-27 17:27:10.937428 -0400 EDT m=+100843.164397089) [tags:API=GRBA_Ykn7-nd]
2018-04-26T13:27:22.998042-04:00 ▶ [DEBU keybase nist.go:101] 715 NISTFactory#NIST: NIST expired (conservatively) 2.061140708s ago, making a new one (expiresAt: 2018-04-27 17:27:10.937428 -0400 EDT m=+100843.164397089) [tags:API=OBiGIcaWvmdM]
2018-04-26T13:27:22.998088-04:00 ▶ [DEBU keybase nist.go:212] 716 + NIST#generate [tags:API=OBiGIcaWvmdM]
2018-04-26T13:27:22.998230-04:00 ▶ [DEBU keybase nist.go:107] 717 - NIST#generate -> ok [tags:API=OBiGIcaWvmdM]
2018-04-26T13:27:22.998277-04:00 ▶ [DEBU keybase nist.go:112] 718 NISTFactory#NIST: Installing new NIST; expiresAt: 2018-04-27 17:27:22.998127 -0400 EDT m=+100855.225641033 [tags:API=OBiGIcaWvmdM]
2018-04-26T13:27:23.402678-04:00 ▶ [DEBU keybase nist.go:98] 749 NISTFactory#NIST: returning existing NIST (expires conservatively in 9.595433177s, expiresAt: 2018-04-27 17:27:22.998127 -0400 EDT m=+100855.225641033) [tags:API=lrDgSvX9mej-]
2018-04-26T13:27:23.752421-04:00 ▶ [DEBU keybase nist.go:98] 778 NISTFactory#NIST: returning existing NIST (expires conservatively in 9.245674449s, expiresAt: 2018-04-27 17:27:22.998127 -0400 EDT m=+100855.225641033) [tags:API=WJ2Saw_j3aGb]


DB Migrate with .dump

Laravel Version: 8.22.1
PHP Version: 8.0.2
Database Driver & Version: MySQL 5.7

Description:
When using Manage Service for MySQL and trying to perform migrations, have error
ERROR 3159 (HY000): Connections using insecure transport are prohibited while --require_secure_transport=ON.

Hi there,
Thanks for reporting but it looks like this is a question which can be asked on a support channel. Please only use this issue tracker for reporting bugs with the library itself. If you have a question on how to use functionality provided by this repo you can try one of the following channels:

Laracasts Forums
Laravel.io Forums
StackOverflow
Discord
Larachat
IRC

However, this issue will not be locked and everyone is still free to discuss solutions to your problem!
Thanks.


ShopifyAPI::Fulfillment.new says ActiveResource::ResourceInvalid (Failed.)

I am creating a new fulfilment against order in ruby
 fulfill = ShopifyAPI::Fulfillment.new( :params => {:order_id => t.shopify_order_id})
          fulfill.tracking_numbers = tracking_numbers
          fulfill.tracking_company = shipping_company
          fulfill.tracking_urls = tracking_links
          fulfill.prefix_options = { :order_id => t.shopify_order_id }
          fulfill.save

fulfill.errors.full_messages.to_sentence is returing nill and
2.5.0 :014 > fulfill.save
 => false
2.5.0 :015 > fulfill.save!
Traceback (most recent call last):
        9: from bin/rails:6:in `<main>'
        8: from bin/rails:6:in `require'
        7: from /var/rails/sendoso/shared/bundle/ruby/2.5.0/gems/railties-<IP_ADDRESS>/lib/rails/commands.rb:17:in `<top (required)>'
        6: from /var/rails/sendoso/shared/bundle/ruby/2.5.0/gems/railties-<IP_ADDRESS>/lib/rails/commands/commands_tasks.rb:39:in `run_command!'
        5: from /var/rails/sendoso/shared/bundle/ruby/2.5.0/gems/railties-<IP_ADDRESS>/lib/rails/commands/commands_tasks.rb:68:in `console'
        4: from /var/rails/sendoso/shared/bundle/ruby/2.5.0/gems/railties-<IP_ADDRESS>/lib/rails/commands/console.rb:9:in `start'
        3: from /var/rails/sendoso/shared/bundle/ruby/2.5.0/gems/railties-<IP_ADDRESS>/lib/rails/commands/console.rb:110:in `start'
        2: from (irb):15
        1: from /var/rails/sendoso/shared/bundle/ruby/2.5.0/gems/activeresource-4.1.0/lib/active_resource/base.rb:1288:in `save!'
ActiveResource::ResourceInvalid (Failed.)

How do I fix these issue. This process is creating webhook for other store but on specific store its generating issue

same issue. any idea?

in my case
However, if an order is refunded or if any of its individual line items are refunded, then the order can't be fulfilled.

You have to provide a location_id when you create a fulfillment.

You need a location_id.  My issue is that orders aren't even passing location_id's for some reason anymore (maybe an update)... From my understanding, we need to create a fulfillment service but I am unsure how to do this

@brandnamewater how do you get your orders? On my side I use
ShopifyAPI::Order.find(:all, params: {limit: 250, created_at_min:min_creation_date, created_at_max:max_creation_date, page: page, financial_status: "paid", fulfillment_status: "unshipped", fields: "id,name,email,**location_id**,created_at,note,discount_codes,shipping_address,line_items,customer"})
the location_id gets returned properly. Did you succeed to fulfill your order? I'm having similar problem even tough I have the correct location_id.

UPDATE

I added write_orders in my shopify_app.rb:
config.scope = "read_orders, write_orders, read_products"
I uninstalled and re-installed the app to have the correct permissions (Dont know if there is a better way).
The location_id in my case is always the same, if it is not listed in your order data, make sure your address and locations are properly set in the Shopify Admin. One other way to find your location_id (if you only have one and know for sur it will never change) is to go in an order page and copy the url of the Mark as fullfilled button, it should give you something like /admin/orders/15137750057/fulfill_and_ship?fulfill_only=true&fulfillment_service_handle=manual&location_id=7878869050&requires_shipping=true

here is my final ruby code
     f = ShopifyAPI::Fulfillment.new(           :order_id => ORDER_ID,           :location_id => LOCATION_ID,           :notify_customer => true         )         #f.tracking_numbers = tracking_numbers         #f.tracking_company = shipping_company         #f.tracking_urls = tracking_links         f.prefix_options = { :order_id => ORDER_ID }         f.save
Hope this helps!

Orders do NOT have a location ID useful for all fulfillments. If you look that up, the order location ID is where an order was placed which could have zero to do with where the items sold come from to be fulfilled. Answers here that insinuate the order location ID is interesting are missing the main point for fulfillments. Items have a location ID that is not necessarily the same as the order location ID.
At the order level, you get a variant ID for a line item. You use that to get the variant's inventory_item_id. With that you can get the correct location ID of the inventory item to make a fulfillment. When you use the location_id of the order, that is the location where the order was placed, which could mean WWW, POS or anything else with a location.
Just a PSA or FYI...


500

We're sorry. There seems to be an error(HTTPcode500)servererror-manifestunknownmanifestunknownIf this error is invalid. please file a ticket on our Github repo.

Looks like the image that you're trying to run does not have a :latest tag, so you will have to specify a specific tag to use; here's the steps to do so (steps below are for the elasticsearch image, but the steps are similar for the image you're using):

Click on the ... button to view the image's details

Click on the Selected tag: latest to open the "tag selection" window

Click the tag / version of the image you want to run

Click the (X) to close the tag selector window

Click on the Create button to pull the image and start the container
Closing this issue because I don't think this is a bug, but feel free to continue the conversation 👍


style: increase the width of the table in mobile view

Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.

[x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
[x] Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
[x] Check the commit's or even all commits' message styles matches our requested structure.
[x] Check your code additions will fail neither code linting checks nor unit test.
[ ] I have added necessary documentation (if appropriate)

Linked Issues
Fixes #366
Description
Please describe your pull request.
❤Thank you!
Post merge checklist

[ ] Follow steps from the guidelines for contributing to this repository.
[ ] If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

@anish-patro good job but issue already resolved.