Web: custom string interning

In the web, we use wasm-bindgens intern feature to cache strings on the js/rust boundary. However, this approach forces us to come up with a list of strings at compile-time. Instead, we should implement our own interning feature that uses a bloom filter and a configurable amount of cached elements, or some sort of better heuristic (like length). The time to cache/uncache is pretty significant in benchmarks, and it's unnatural to tell users to pre-populate the string cache if they want good performance.

This is an interesting issue to research. Its important to define 'good' performance and goals ahead: is it average or worst-case?

This is an interesting issue to research. Its important to define 'good' performance and goals ahead: is it average or worst-case?
I've traced the example projects and some of my own pet projects. Almost all good candidates (by most frequent appearance) for interning already were part of the builtin predefined cache. This is generally because applications have few repetitive content (text and class names). I assume, that having a smart automatic interning algorithm would reduce overall performance.
However the rules above don't apply for applications with large lists, tables and highly repetitive content. Given, that we'll be tracing DomEdits, we can tell tags and attributes apart from user text and values. The former are probably already interned, the latter require more analysis. And this is an opportunity for reducing worst case performance (no predictions on average), so the main goal would be high adaptiveness and flexibility. For example, detecting that we're in the middle (or better at the start) of rendering a large table with repetitive text and styles.
web-sys is already looking up every string in a hashmap if string interning is enabled (if only we could supply it with pre-calculated hashes 😢).
A good approach with high adaptiveness would be having a sliding window counting the most frequent string among the last X requests. As soon as a string appears more than 2 or 3 times, it should be interned. And then easily be replaced if its not in the window.  I'll experiment around before giving any detailed results.

This is an interesting issue to research. Its important to define 'good' performance and goals ahead: is it average or worst-case?
I've traced the example projects and some of my own pet projects. Almost all good candidates (by most frequent appearance) for interning already were part of the builtin predefined cache. This is generally because applications have few repetitive content (text and class names). I assume, that having a smart automatic interning algorithm would reduce overall performance.
However the rules above don't apply for applications with large lists, tables and highly repetitive content. Given, that we'll be tracing DomEdits, we can tell tags and attributes apart from user text and values. The former are probably already interned, the latter require more analysis. And this is an opportunity for reducing worst case performance (no predictions on average), so the main goal would be high adaptiveness and flexibility. For example, detecting that we're in the middle (or better at the start) of rendering a large table with repetitive text and styles.
web-sys is already looking up every string in a hashmap if string interning is enabled (if only we could supply it with pre-calculated hashes 😢).
A good approach with high adaptiveness would be having a sliding window counting the most frequent string among the last X requests. As soon as a string appears more than 2 or 3 times, it should be interned. And then easily be replaced if its not in the window.  I'll experiment around before giving any detailed results.

It's a very exciting problem! We can do a lot of work to bridge the gap between Rust and JS frameworks until WASI types are supported and UTF8 JS strings are accepted naturally.
Our DomEdits are a tad naive in recognizing lists... hence why template support would be interesting.
I would love to see some prototypes of different heuristics. It might be worth wiring up the few benchmarks we have into CI/CD to get a sense of performance on every push and plot that over time.
Pre-hashing, bloom filters, tries, and other techniques would be very interesting to explore and I'd love to see any prototypes you might come up with. Hopefully the string cache code is simple enough to root around in.

This is a somewhat solved problem with templates now. We have a fixed list of strings and then the templates are always made once.

Any reason why you didn't simply create or use a utf16 crate such as utf16string?
Granted, the non-web platforms use utf8 but could that difference be resolved via a trait or type alias?

Any reason why you didn't simply create or use a utf16 crate such as utf16string?
Granted, the non-web platforms use utf8 but could that difference be resolved via a trait or type alias?

This doesn't appear to be the case https://jsbench.me/ptllv2ek5d/1. Sledgehammer bindgen helps with string conversion

Somewhat terse response...I presume you are saying that converting from utf8 to utf16 and vice versa within Javascript is sufficiently performant. However, though that may be the case and indeed my suggestion might amount to premature optimization; nonetheless,  avoiding the need for conversion in the first place seems inherently more performant. 😀
It would also be a great demonstration and exploitation of Rust fantastic trait based abstraction mechanism.
In any event, you know best. I am really a novice. Thanks for your attention 🙂.

Somewhat terse response...I presume you are saying that converting from utf8 to utf16 and vice versa within Javascript is sufficiently performant. However, though that may be the case and indeed my suggestion might amount to premature optimization; nonetheless,  avoiding the need for conversion in the first place seems inherently more performant. 😀

Sorry, I was trying to get something out in between meetings before I forgot. I thought this seemed promising so I created a benchmark. I would have expected converting a utf16 array to a JavaScript string to be faster because you don't have to change encodings. If you run the benchmark in my last message it seems to be slower instead. I'm not entirely sure why? Maybe the uft16 version is just copying more memory?
Part of this is due to the types of string operations we do. I suspect that adding two strings already in JavaScript would be faster than adding them in rust and then converting the arrays to a JavaScript string but most of Dioxus' code would require the strings to start in rust code so it is difficult to avoid the conversation.
We do a few things to be faster with string conversion:

We dynamicly cache the most recently used string for elements, attributes, etc by hashing the pointer
We combine all strings on the rust side into one long string and then only call decode once in the JavaScript side. This is the main thing that sledgehammer-bindgen does faster
We use hyristics to choose a string decoding algorithm

Perhaps I was nieve in thinking that the Javascript runtime could accept the byte array as a proper reference to a utf16 string without decoding or other gymnastics. If that were possible and it didn't perform any subsequent reallocation then I expect performance would be better. Of course, in the general  case we would creating Javascript types in the interface buffer and perhaps bumping the specification of WASM, something that's out of scope.
Thanks again for your attention.


[Bug]: Expired databases can still be selected for multi database changes

ODC version
odc430
OB version

What happened?

What did you expect to happen?
Invalid databases cannot be selected for multi database changes
How can we reproduce it (as minimally and precisely as possible)?

Anything else we need to know?
No response

Fixed In Commit ffbf2c9250018c2aef3f11dbf83c70f0c7fa8824
------
陈朝俊
Tue Jun 4 20:45:13 2024 +0800

You can still choose when there are issues with the database

Fixed In Commit c1771da43ce0fb4f57ced3c7211e057475dd25ac
------
陈朝俊
Thu Jun 6 16:20:14 2024 +0800

pass


Naming of unmaintained track roads

Any chance they could just be called track roads? The addition of "unmaintained" is misleading because some of them can be paved. Plus they are technically maintained by the people that use them. I also seem to remember the wiki saying something about how calling them track roads is due to their purpose and not condition. Although I don't see it on there now.

Sorry, but this issue is settled and I'm not willing to change the name.  We have really good reasons for why highway=track is called that, as a result of a lot of prior discussion.
see https://github.com/openstreetmap/iD/issues/4092#issuecomment-306639206


Server receives only one sent message

In my test project I have a WSS-websocket server and a WSS-client. I make several connections to several endpoints to the server. For each client connection I start a new thread managing this connection. When I try to send some messages in a loop to the server, the server only reveives one message. When I call a send_close() in the onmessage-functor in the client, the server receives all messages sent by the client. Is there a way to receive all messages without calling send_close() each time when a message was sent back?

okay, I think I introduced some trouble by overloading the operator<<() and using it across threads. After I have put the code of the stream-operator into a usual function it worked.


MudChip: SelectedState.Value = false but Selected = true

Things to check

[x] I have searched the existing issues for this bug
[x] To rule out a caching problem I made sure the bug also happens in an incognito tab

Bug type
Component
Component name
MudChip
What happened?
We use MudChipSet with MudChips. MudChipSet has SelectionMode="SelectionMode.MultiSelection". Funcionality we wish to have is to have a chipset with multiselection but we don't want to allow the user to deselect the last chip (kind of mandatory selection in combination with multiselect).
We have SelectedValuesChanged handler on chipset where we check if count of items in underlying collection is 1 and at the same time is new value to be set is 0. If so we know last chip was selected and we wish to return before rewriting the underlying collection.
Razor:

we bind Selected property of the chip

 <MudChipSet T="Guid" SelectionMode="SelectionMode.MultiSelection" CheckMark="false"
    SelectedValues="_selectedPeopleIds" SelectedValuesChanged="_selectedPeopleChanged">
     <div>
         @foreach (var person in _people)
         {
             <MudChip T="Guid" Selected="_selectedPeopleIds.Any(x => x == person.Id)" Variant="Variant.Text" Color="Color.Primary"<EMAIL_ADDRESS><EMAIL_ADDRESS>         }
     </div>
 </MudChipSet>

handler:
private void _selectedPeopleChanged(IReadOnlyCollection<Guid> newValue)
    {
        if (newValue.Count() == 0 && _selectedPeopleIds.Count == 1)
        {
            StateHasChanged();
            return;                                  //this return prevents setting _selectedPeopleIds to empty collection
        }

        _selectedPeopleIds = newValue.ToList();
    }

When we deselect last chip the result is that Selected property on chip is set to true, but SelectedState.Value is set to false and as  result chip shows as deselected on UI although chipSet has value of the last deselected chip.
SelectedState.Value get toggled in MudChip.razor.cs in OnClickAsync method /await SelectedState.SetValueAsync(!SelectedState.Value);/ but Selected is set to true as result of binding.
Demo:
https://try.mudblazor.com/snippet/ckmykLcKeghKyfeN
Expected behavior
We think SelectedState.Value should reflect value of Selected property.
Reproduction link
https://try.mudblazor.com/snippet/ckmykLcKeghKyfeN
Reproduction steps

In demo select a chip
Then deselect the same chip
Notice in div below there is value of chipSet which is value of the chip itself but the chip as such is deselected

Relevant log output
No response
Version (bug)
7.4.0
Version (working)
No response
What browsers are you seeing the problem on?
Chrome
On which operating systems are you experiencing the issue?
Windows
Pull Request

[ ] I would like to do a Pull Request

Code of Conduct

[X] I agree to follow this project's Code of Conduct

The problem is that you are breaking the two-way binding of SelectedValues. Blazor expects a two-way binding to update the outside variable. If you mess with this outside of the component the component can't do anything about it because it doesn't get an update.
Here is a workaround: https://try.mudblazor.com/snippet/mYGyOrmKicoTPpYl
Basically the solution is to allow the list to become empty. Then kick of an immediate second render that will set it back to the last element. I see no clean way to make such a behavior configurable in the chipset component so the workaround will have to do for now.

On second thought, with a SelectionChanging event which can be cancelled, this could be solved without the flickering of the workaround @ScarletKuro. Similar to what we discussed about the OnClosing event for Overlay.

Here is a workaround: https://try.mudblazor.com/snippet/mYGyOrmKicoTPpYl

The requirement for a delay is a bit annoying, though I completely agree that interfering with two-way binding is not ideal. Generally, you would want to set the value as is and then handle your logic.
However, I wonder if using the SetValueAfterEventCallbackAsync from https://github.com/MudBlazor/MudBlazor/pull/9397 would actually eliminate the need for the delay.

However, I wonder if using the SetValueAfterEventCallbackAsync from #9397 would actually eliminate the need for the delay.

Nvm, this does not give any difference in this case. I guess it would require this indeed:

On second thought, with a SelectionChanging event which can be cancelled, this could be solved without the flickering of the workaround @ScarletKuro. Similar to what we discussed about the OnClosing event for Overlay.

Yeah. I think that calling StateHasChanged in an active render pass doesn't cause a new render and thus doesn't lead to assigning the changed parameters IMO. That's why the delay is essential. If you remove it the workaround won't work.

This works too: https://try.mudblazor.com/snippet/cOGeurQqWSunGBPQ
Doesn't remove the flicker, but less noticeable. And sometimes it doesn't flicker when blazor decides not to re-render, probs something to do with the internal DidChange.

yeah, the statehaschanged before the delay was superficial. nice find with Task.Yield(). I have learned something new. It flickers the same I would say however.

This one doesn't flicker at all: https://try.mudblazor.com/snippet/mumokBcUCezMYpTR
Weird how it doesn't require a StateHasChanged at all. I don't really understand what is going on ;)

Weird how it doesn't require a StateHasChanged at all.

I'm more wondering why ya all put StateHasChanged if blazor will automatically call StateHasChanged after the EventCallback is ended, that's the default Blazor behavior.

My script was using async void that needed it. I just noticed that you changed it to async Task. Clever ;)

However, I wonder if using the SetValueAfterEventCallbackAsync from #9397 would actually eliminate the need for the delay.

Nvm, this does not give any difference in this case. I guess it would require this indeed:

Nvm again, I'm retarded. The SetValueAfterEventCallbackAsync does help to some degree. I was applying it to MudChip rather than MudChipSet, but the SelectedValues come from MudChipSet 🤦🏽♂.
The reason why I said at some degree is that it also requires removing StateHasChanged from:
https://github.com/MudBlazor/MudBlazor/blob/f3170833e41a52c3fcd3981bbf20402c42900d26/src/MudBlazor/Components/Chip/MudChip.razor.cs#L34-L38
After removing StateHasChanged, you won't need the delay or Task.Yield. Now, I'm uncertain whether SetValueAfterEventCallbackAsync should be the default or if we need to fine-tune each component individually.
To be honest I don't really understand the need of StateHasChanged here? If they use two way binding they will eventually get re-render, if single binding then I don't think it requires the re-render as this is handler, I would expect blazor to re-render anyway after the SetParametersAsync automatically.

To be honest I don't really understand the need of StateHasChanged here?

We'll have to try it out. I didn't sprinkle StateHasChange over the code just for good measure like in the beginning when I was a Blazor noob ;) ... so it might be necessary. But who knows, I might have made a mistake or it is a remnant of old code from my noob days. Chip / ChipSet was the first component I contributed to this library.


When running serve, an error occurs with the error message:Cannot use 'inmport.meta' outside a module

Describe the bug
When running serve, an error occurs with the error message:Cannot use 'inmport.meta' outside a module

Reproduction
When running serve, an error occurs with the error message:Cannot use 'inmport.meta' outside a module
System Info
npm run serve

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A, please open a GitHub Discussion instead.
[X] The provided reproduction is a minimal reproducible of the bug.

I also encountered the same problem just now. It is normal after returning to version 0.22.0

same issue~ already relegated to v0.22.0

y ahora qué rompieron ????

Still present in 0.22.2
C:\Users\Tina\work\Place\node_modules\unplugin-vue-components\dist\chunk-YPBVGE6A.js:110
var _require = typeof _chunkEZUCZHGVjs.__require === "undefined" ? _module.createRequire.call(void 0, import.meta.url) : _chunkEZUCZHGVjs.__require;

                               ^^^^

SyntaxError: Cannot use 'import.meta' outside a module
    at Object.compileFunction (node:vm:360:18)
    at wrapSafe (node:internal/modules/cjs/loader:1049:15)
    at Module._compile (node:internal/modules/cjs/loader:1084:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1174:10)
    at _require.extensions.<computed> [as .js] (file:///C:/Users/Tina/work/Place/node_modules/vite/dist/node/chunks/dep-71eb12cb.js:62910:17)
    at Module.load (node:internal/modules/cjs/loader:998:32)
    at Module._load (node:internal/modules/cjs/loader:839:12)
    at Module.require (node:internal/modules/cjs/loader:1022:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (C:\Users\Tina\work\Place\node_modules\unplugin-vue-components\dist\vite.js:3:24)
    ```

I also upgraded to 0.22.2 and have the import.meta problem.

v0.20.0 is the latest one that still works

v0.20.0 is the latest one that still works

0.21.2 works as well for me


Media Queries compile error

Can't compile project when using media queries. Am I doing something wrong?
Code:
<Styled @bind-Classname="@ExtraSmallOnlyClass">
    @media (min-width:0px) and (max-width:599.95px) {
        display: none;
    }
</Styled>

Error:
1>...\Component1.razor(2,6,2,11): error CS0103: The name 'media' does not exist in the current context

Based on docs: https://blazorstyled.io/media

Because the @ sign is the razor symbol, you need to “encode it” by putting two @ signs: @@media

Oh, thanks. Will you update the docs or can I close the issue?

I will close it. I have an issue already open to review all the docs for accuracy when I publish the next version


[CT-786] enable specifying policy tag by name instead of id

Describe the feature
enable users to specify bq policy tags by name (eg. CUSTOMER_EMAIL) instead of id (eg. projects/123/locations/eu/taxonomies/456/policyTags/789)
proposed implementation: create new bq specific configuration taxonomy:
dbt_project.yml
models:
  my_project:
    taxonomy: 'projects/123/locations/eu/taxonomies/456'

schema.yml
models:
  - name: customers
    columns:
      - name: email
        policy_tag_names:  # not `policy_tags`. if both specified, error? or ignore `policy_tag_names`?
          - 'CUSTOMER_EMAIL'  # would resolve to `projects/123/locations/eu/taxonomies/456/policyTags/789` when applied

Additional context

we have 150+ different policy tags
we allow anyone to bootstrap a new 'data-platform' environment, which includes a copy of the taxonomy with all the tags. an environment could belong to a person, or be shared between a team, or anyone (uat/prod). currently we have ~50 environments

Describe alternatives you've considered
opt 1:
this works, but is difficult for a user to set up when they start a project and difficult to migrate projects through environments
dbt_project.yml
vars:
  PT_CUSTOMER_EMAIL: 'projects/123/locations/eu/taxonomies/456/policyTags/789'
  PT_CUSTOMER_NAME: 'projects/123/locations/eu/taxonomies/456/policyTags/987'
  ...  # +150 more

schema.yml
models:
  - name: customers
    columns:
      - name: email
        policy_tags:
          - "{{ var('PT_CUSTOMER_EMAIL') }}"

op 2:
im not sure if this is possible cos dbt noob...
create a mapping macro that uses the bq api to look up policy tag id?
dbt_project.yml
vars:
  TAXONOMY: 'projects/123/locations/eu/taxonomies/456'

schema.yml
models:
  - name: customers
    columns:
      - name: email
        policy_tags:
          - "{{ policy_tag(var('TAXONOMY'), 'PT_CUSTOMER_EMAIL') }}"

Who will this benefit?

people who want immediate context as to what policy tag is on each column
people who have many taxonomies / tags

Are you interested in contributing this feature?
not running dbt in prod yet, but possibly, yes!

@ben-marengo-msmg Thanks for opening, and for the thoughtful writeup!
If I understand you right, the ask here is motivated by the BigQuery capability around policy tags, but it isn't a material change to the actual implementation of that capability. Instead, the ask is for for dbt to store a mapping object between human-friendly names (to be referenced elsewhere in the project), and the ID that needs to be sent to BigQuery behind the scenes.
Some mix of the proposed alternatives (opp 1 + opp 2) is what I would have in mind, leveraging existing capabilities around dbt vars + env vars. Specifically, something like:
# dbt_project.yml
vars:
  TAXONOMY: 'projects/123/locations/eu/taxonomies/456'
  PT_CUSTOMER_EMAIL: 'policyTags/789'
  PT_CUSTOMER_NAME: 'policyTags/987'
  ...  # +150 more

And then:
models:
  - name: customers
    columns:
      - name: email
        policy_tags:
          - "{{ var('TAXONOMY') ~ var('PT_CUSTOMER_EMAIL') }}"

The appeal of using vars is that the values are checked into version control, though still can be overridden via CLI flag (--vars). For values that are more likely to differ across environments, you could set and reference them via env_var instead.
Unfortunately, the specific implementation proposed in opp 2 won't work (a policy_tag macro), since custom macros can't be referenced within yaml file configuration today (with a few exceptions, namely hooks). I agree that feels like a more ergonomic way of "constructing" the policy tag ID, including the repeated boilerplate, so that vars can be responsible for just the parts that actually differ between tags/environments. That's a larger initiative, one we definitely know about, which would require nontrivial work within dbt-core to support. I'm inclined to close this issue for now, but record it as one more valid use case for supporting "static" macros in configuration.
For my part, I've found policy tags very very difficult to debug (#31), and I'd like to avoid baking more complex logic into dbt-bigquery—where it's hidden behind the scenes, and trickier for users to debug—until we have a firmer grip around the existing functionality.

hey @jtcohen6 - do you think there'd be any way to do either of these 2 options?

since custom macros can't be referenced within yaml file configuration today (with a few exceptions, namely hooks)

i think youre implying that hooks could be used to modify the schema.yaml/configuration at runtime?

No, sorry - I mentioned hooks only in the context of, pre/post/on-run-* hooks being the one type of configuration that can take a macro as an argument. It wouldn't be possible to use those to dynamically update configuration mid-run.

is there a pre-runtime hook that i can write to list the tags in that taxonomy and load them as variables?

As in, by making a Google client API request? That's something we'd need to add support for in the adapter plugin.
It's also a bit of an anti-pattern in dbt today — we don't allow for setting configuration based on the dynamic result of a database query / API request — but maybe there'd be a way to factor this sensibly? The user supplies the taxonomy name + the list of tags, then at runtime, dbt fetches the full policy tag IDs and applies them?

alternatively, is there a compile-time hook i could use to replace the 'human readable' names ('PT_CUSTOMER_EMAIL') in the models.columns.policy_tags array with the ids ('projects/123/locations/eu/taxonomies/456/policyTags/789')

I don't think so. This is why I mentioned macros above.
Given that the policy tags are also executed via client (Python) method, there's also no runtime macro returning SQL that you could override, to replace the human-readable names with real IDs at the moment of policy tag application. I don't think that's a great practice in general, but it does offer a workaround for many configurations on other data warehouses. Unfortunately, applying policy tags isn't something that BigQuery supports via SQL — or doesn't yet, at least.


Customized title caption buttons not retaining inactive styling

Describe the bug
In my WinUI 3 app, I have a fully customized title bar. If I click away from the window, the foreground for the caption buttons fades as expected. When moused over while the window is still inactive, the background/foreground changes as expected, but when moving the mouse away again, the foreground returns to the active brush instead of reverting back to the inactive brush, even though the window is still inactive.
Steps to reproduce the bug
This can also be seen in the WinUI 3 Gallery App:

Open the app
Click away from the window (the caption button foregrounds take on their inactive styling)
Move the pointer over a caption button to see its background/foreground change
Move the pointer away from the button(s) to see that the foreground doesn't return to the inactive styling

Expected behavior
On an inactive window, the caption buttons should return to inactive styling if moused over and then moused away from (assuming the window hasn't otherwise been made active).
Screenshots
No response
NuGet package version
WinUI 3 - Windows App SDK 1.2.3: 1.2.230118.102
Windows version
Windows 11 (22H2): Build 22621
Additional context
No response

Seeing this too  on the WinUI 3 Gallery App...

This is still an issue in Windows App SDK 1.3.2 (1.3.230602002)

has been fixed in winappsdk 1.4.
closing the issue. If you continue to see the issue in some scenario, comment here and I will re-open the bug


chalk.enabled=true or { enabled: true} does not work when color support is initially detected as false

Environment
Chalk: 2.3.0
Node.js: 6.12.0 and 8.9.3
Issue
chalk.js
const chalk = require('chalk');
chalk.enabled = true;
console.log(chalk`{green hello}`);

--or--
const chalk = new require('chalk').constructor({ enabled: true });

If you run chalk.js as:
node chalk.js

The output is a green hello.
If you run this in a clean environment (which causes supports-color to report that colors are not supported):
env -i node chalk.js

The output is a un-colored hello.
Details
I traced this to https://github.com/chalk/chalk/blob/master/index.js#L177, where this.enabled is false, and this is builder. It seems like, somehow, the initial value for enabled is not getting changed or is not filtering down to the enabled property defined on builder.
As expected, using the environment variable FORCE_COLOR or the --color parameter does work, as it gets enabled to the right value, initially.
Interestingly, running it as (to force it on from the start):
env -i node chalk.js --color

...and then doing:
chalk.enabled = false;

...does actually turn it off. Now I'm thinking there's some issue with truthy and falsy. I'm not sure.
Aside
It would definitely be easier for me to dig more on this if there weren't so much indirection in the way this is implemented :innocent:; but, I'm sure some or most of that is necessary to get this to work so cleanly.

Thanks for opening this well-written ticket. Even if you're not able to submit a fix, it would be helpful if you could submit a failing test to make it easier for us or others to look into it.

@sindresorhus To make sure I understand what you're asking for:
You want me to write a test that passes (using the .failing thing) for the bug I'm reporting that would normally have an affirmative test that would currently be failing due to it not doing what's expected?

@nazrhyn Correct :)
By the way, we mock to control supports-color since Travis likes to change the environment at random times, causing our tests to be non-determinant.
Up until about 4 or 5 months ago, we didn't have any tests :D

Hah! Yeah, I definitely understand the need to mock required external dependencies. My comment was just that the result was static, so it's not covering the cases.
Any preference as to what file to put this in? It's probably more of a core issue than an issue with the tagged template literal support. I'll also likely have to change the way you're mocking that require so that I can change what it returns.

@nazrhyn Feel free to put it in core :)

Notes

resolve-from is a little funny. Something like https://github.com/boblauer/mock-require might be a bit simpler/clearer. (Though, I understand you're using your own stuff.)

Your test runner doesn't seem to have a construct for grouping tests other than files. In Mocha, if I wanted to run something to build up a single test or set of tests, I'd use a construct like this:
describe('outer grouping', function () {

    it('some test', function () {});

    describe('inner grouping', function () {

        before('build-up before tests in this group', function () {
            // stuff
        });

        it('group test', function () {});

        after('tear-down after tests in this group', function () {
            // stuff
        });

    });

});

The nested describe creates another "group" inside which the before / beforeEach / after / afterEach run.
In this case, I'd like to have a test or a few tests where the mocked return from supports-color is different. Not sure how to do that with AVA.

Actions
So, what I did was create another file where color is not supported. If you guys understand AVA better, maybe there's a nicer solution for this.
Created pull request: https://github.com/chalk/chalk/pull/235

chalk.level  is 0 when supports-color reports that colors are not supported. This makes output un-colored.
const chalk = require('chalk')
chalk.enabled = true
chalk.level = 3
console.log(chalk`{green hello}`)

outputs green text.
It seems not good to have un-colored output when chalk.enable is true , but I am not sure how to make it better.

Mirefly is correct, this is actually intended functionality. Is there a use-case for having .enabled anymore, honestly? That'd be a breaking change though and nobody needs another major version.
The only other option to make this more 'developer friendly' would be to use a property setter to Math.max(this.level, 1) upon setting enabled to true, for example.

@nazrhyn I meant that .level = 0 is effectively .enabled = false.

Hmm. I guess I'm still missing the part about how to force it on from inside the code after color support has already been detected as off. Are you saying that setting .level to a non-zero value should also force it on in that case?

Ohh, I see. You have to do both? I'm not sure why I wasn't parsing that. Tested that, and it works.
It really does sound like enabled should be deprecated, and level should just control this. I suppose setters for both would be needed to avoid the breaking change, but where to put the actual value is always a problem in JavaScript...
Anyway, it sounds like this issue is invalid, then. At the very least, adding something into the documentation would be helpful. Would you like me to submit a PR for that? I can also remove the failing test (or add one that verifies that it can be turned on by setting both level and enabled).

Would you like me to submit a PR for that?

Surely :)

It would surely make sense to only use level instead of having to set both level and enabled (as @nazrhyn pointed) because it seems redundant and overly-complex to use two variables that do the same thing.
If there's a real need to keep enabled then having it as a setter/getter that would only depend on whether level !== 0 and not a separate field (such as enabled) then it would make it easier on both internal and external sides.

@sindresorhus thoughts?

Would you like me to submit a PR for that?

Surely :)

@Qix- Submitted https://github.com/chalk/chalk/pull/308

Yeah, I think we should remove .enabled for Chalk 3. PR welcome.

Oh yeah, chalk 3 :D Perfect.

@issuehunt has funded $234.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.

@kazup01 has cancelled @issuehunt's funding for this issue.(Cancelled amount: $234.00) See it on IssueHunt

@issuehunt has funded $40.00 to this issue.

Submit pull request via IssueHunt to receive this reward.
Want to contribute? Chip in to this issue via IssueHunt.
Checkout the IssueHunt Issue Explorer to see more funded issues.
Need help from developers? Add your repository on IssueHunt to raise funds.


Is LedisDB Production Ready?

I am wondering, is ledisdb production ready? I have a use case where LedisDB is a perfect candidate for my storage needs.

Hi @clangley, I know some people and company have already used it in production, but I am still not sure whether it can be production ready or not.
But you can have a try, your feedback is very welcome for its improvement. Thank you :-)

its been solid for us for over a year of a 10GB data set (rocksdb), on a service doing 100 to 200 req/sec, of which every request would hit ledisdb and its been a rock.

:-)
I am very surprised that I have been developing it for more than a year !!!

If I can be a bit nosey can @clangley @pkieltyka tell me why you chose this db over redis?
thanks!

long-term data persistence and a data set that can grow > 100GB

ledisdb isn't the default choice over redisdb, but if you have those two requirements above.. large data set, where keys are greater than memory, and you want the dataset to be stored in a proper on-disk storage engine, then ledisdb is a much better choice, with still great performance (but not as good as redis since thats all in-memory).

+1
I found Ledis about 4 days ago -- My redis was exceeding 16GB and crashing a $200 server. I downloaded it at 10am, played with it until 10pm (load testing it up to 50GB dataset four times, excellent response speeds for my sparse dataset, no changes to my redis code, 0 errors and only 500mb RAM in use), implemented in production by 4am, monitored health until 8am, and since then I have been sitting by the pool. I know it'll take me 2 months to grow to 50GB and I'm confident I don't have to worry until then.
TLDR: I switched my production machines to Ledis in less than a day, saved $150/mo on hardware, and solved my "redis is crashing all the time" problem. I feel good about it; where can I send a donation?

:-)
Thanks @linked , your feedback is the most motivation for me to improve it.

I would very much like to donate, to provide even more motivation.

@linked How do you backup and restore your ledisdb? Does #176 resolved?

We need some showcase on doc.


Add a license

It's unclear how this project is licensed.

Thanks for pointing out. My plan is to add the MIT license. Let me know if it would work for you (since some of the code contributions are yours), and I'll add it.

MIT license works for me. :-)


[WIP] #155 Implement mechanism to check all tracked comics/sources for new chapter/pages

See commit messages for detail
Note: Currently, this MR is lacking:

UI/UX refinement
Integration of one new error message in strings.js
Dedicated Tests for the support modules + multi-sources update check (only the relevant sources should have the readable class)

There is also a point to discuss:

Whether all comics/sources should be checked, or should we skip checking the sources known to have newer chapters available.
Upon receiving a tracking notification in the SidePanel, only the current comic/source couple is checked for newer chapters/pages, and not the other sources for the current comic. Maybe we should  add this ?

closes #155

As agreed offline, on the UI/UX side, we'll do:

Suppress the "source check start" event, since we'll not be displaying anything while the source is being checked. Also, we already have the refresh button which will be updated to indicate the ongoing check
Add a CSS Class to make the refresh button rotate during the update check process
Use an icon (with a label to make things more explicit) instead of a background color to express the availability of new chapters/pages
The icon of the refresh button should ideally be switched to something like the rotating arrows (\f1f2 in the awesome Font, not available in our woff2 file at the moment)

merging as feature is ready.
Tests will be added later on, once we've written the necessary tooling


HTML Formatter adding extra new lines between

Issue Type: Bug
If you have a textarea tag and the closing tag is on a separate line, each time you run the formatter (I have format on save enabled) it will add extra new lines between the opening and closing tags.
The number of new lines doubles each time the formatter is run.
VS Code version: Code 1.27.1 (5944e81f3c46a3938a82c701f96d7a59b074cfdc, 2018-09-06T09:21:47.222Z)
OS version: Linux x64 4.4.0-134-generic

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz (4 x 3392)

GPU Status
2d_canvas: unavailable_softwarechecker_imaging: disabled_offflash_3d: unavailable_softwareflash_stage3d: unavailable_softwareflash_stage3d_baseline: unavailable_softwaregpu_compositing: unavailable_softwaremultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: unavailable_softwarevideo_decode: unavailable_softwarevideo_encode: unavailable_softwarewebgl: enabled_readbackwebgl2: unavailable_off

Load (avg)
1, 0, 0

Memory (System)
10.86GB (1.98GB free)

Process Argv
/usr/share/code/code --unity-launch

Screen Reader
no

VM
100%

Extensions: none

I'm not able to reproduce with this sample
<html>

<body>
	<textarea name="" id="" cols="30" rows="10">
		sdfsdf
	</textarea>
</body>

</html>

@samshareski  Can you provide a small sample where the problem shows?

@aeschli
Your example doesn't reproduce on my machine either. It seems to only happen if the textarea closing tag is on a new line and there's no text in between the opening and closing tags like so
<html>

<body>
	<textarea name="" id="" cols="30" rows="10">
	</textarea>
</body>

</html>

But the bug occurs for any number of new line characters between the tags.

Fixed in the latest jsbeautify.


Feature not in preview anymore

Hello,
we just received an email from AZure service updates ( Date 10/28/2020)
"General Availability: Azure Spot on Azure Kubernetes Service"
Hence, please remove mention of "public preview" from this page

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5fc40e8e-558d-171c-2fd9-82b67f89d221
Version Independent ID: 9a757f12-cf86-2095-0f6a-37397024e3a5
Content: Preview - Add a spot node pool to an Azure Kubernetes Service (AKS) cluster - Azure Kubernetes Service
Content Source: articles/aks/spot-node-pool.md
Service: container-service
GitHub Login: @mlearned
Microsoft Alias: mlearned

Thanks for the issue, I've assigned it to the doc author to take a look.


[QUESTION] How to read only specified columns on import?

Versions

PHP version: 7.2.7
Laravel version: 5.7
Package version: 3.1

Description
Hello!
I have a file with hundreds of columns, but I need only dozen. I know the sequence numbers of needed columns. How could I specify columns numbers before reading the file? It could greatly reduce memory usage.
Important:

before reading, not after;
to specify needed columns, not unneeded.

Thanks!

+1 for this feature, finding myself running out of memory/timeouts on imports ToCollection and a range should greatly assist with that.

yea T^T we need this kind of feature.... will be great if we have.

+1 for this feature, finding myself running out of memory/timeouts on imports ToCollection and a range should greatly assist with that.

I had the same issue, so I implemented a ColumnLimit concern, and it seems to fix the memory problem we stumbled upon: https://github.com/Maatwebsite/Laravel-Excel/compare/3.1...KristofMorva:column-limit
Sadly I won't have time to write the tests and submit a PR, but feel free to use it / submit a PR based on it.
Cheers!


Realtime Action Status update for pending workflows

Is your feature request related to a problem? Please describe.
I am trying to use the extension to get real time feedback on the CI to see if the tests are passing are not. I am frustrated that I have to click the refresh button, it prevents me from focusing on something else as it runs.
Describe the solution you'd like
I would love it if when I click the refresh button, if there are any workflows that are not in a terminal state (not started, pending, queued...) the extension would poll the api every second to get a refreshed status until the action/workflow reached a terminal status.
Additional context
I have seen this: https://github.com/github/vscode-github-actions/issues/126 and I can understand how that could be a big undertaking. I am trying to suggest a focused way of getting feedback real time on something I am working on. I am ok, telling the extension "start watching" so that api don't get overflown or we don't constantly poll the api when the extension is opened.
ideally you could subscribe to a websocket 😏  but not sure if that's even possible
Also the yellow spinners make it look like it is polling when it is not

Seems related to https://github.com/github/vscode-github-actions/issues/229

I second this issue, it's very annoying to have to click that refresh button. There should be some polling.

I also find this very frustrating. There's also no way to update the statusbar actions status, which makes it basically useless.


Add turbiniactl logs command to pull stackdriver logs

Now that we are logging to stackdriver we should make an easy way to pull/view the logs from stackdriver.  Ideally we would be able to filter based on the node (server vs. worker, and possibly individual workers).

Fixed by #667

Fixed by #667


HBASE-27867 Close the L1 victim handler race

When we evict a block from L1 and move it to L2 there is a brief window of time where we have removed the block from the L1 map and yet the victim handler has not completed execution. Some read-your-write use cases can be significantly impacted even though the window is small. Victim handling can be made atomic with respect to the unmapping operation. The upside is there will be no L1+L2 misses during the transition. The downside is if the victim handler takes a long time to execute – currently they are all very fast, so only a theoretical risk – then other removals or insertions in L1 can block until it completes.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

I checked out the branch I pushed and ran mvn spotless:apply and there were no differences.
$ mvn spotless:apply
....
$ git status
(no changes)

The test issue is not a unit test failure and does not appear to be related to this change. Looks like we may need to do a zombie cleanup.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.1.0:test
(secondPartTestsExecution) on project hbase-server:
There was a timeout in the fork

Rebased.

@Apache9 please let me know if you have any more concerns or nits. I plan to merge this tomorrow.


Update to NET8

This pull request adds .NET 8 Targests (is needed vor Xcode 15 support and has Go-Live License).
https://devblogs.microsoft.com/dotnet/announcing-dotnet-maui-in-dotnet-8-rc-1/
This removes the .NET 6 Mobile Targets (because they are already End of Life)
https://dotnet.microsoft.com/en-us/platform/support/policy/maui
Currently it needs Visual Studio 2022 17.8 Preview 2 to work for Mobile Platforms.
Uno Tizen/UWP Sample removed because there is now no .NETStandard2.0 Target.
Uno 5.0 with .NET 8 Targets is currently in Preview until this gets a Release this Pull Request will stay in WIP

Should I increase the .net core 3.1 targets to .net 6 in this pull request because .net core 3.1 and .net 5.0 are already end of life.

I am not sure. My idea was to release a v4 which was updated to the recent releases around .NET8 but would have no other changes. So, just adding .NET 8 and maintain support for everything we already had (btw, this PR removes some older frameworks, so that is not compatible with that idea, but we will need to update for v5). But I am not really sure how that would work out for platforms like MAUI which could have breaking changes. Can we support both MAUI 7 and 8? Also I am not so sure what the added value is of adding support for .NET 8 in the core components if you do not update the dependency to of the UI components.
So, I don't know what the approach is, but I do know what I want:

Keep supporting v4 for quite a while, in it's current form. So, bring out patches, and add little or no new stuff, and break nothing. If it helps to update for .NET 8 we should do that.
Come up with a new release shortly after the .NET 8 releases which supports it. It should not take another year to support 8. We should keep up with the cadence of those releases.

Perhaps we need a release a v5 that is updated for .NET 8 and has breaking changes, no other changes, so there is little we need to test and can release soon. Refactoring work we had in mind for v5 should go in a v6.

I had to remove .net 6 iOS/android/... targets because they don't compile anymore in . Net 7 a deprecation warning was issued. I have to investigate if it is an error as warning problem - if yes, than I can readd the targets.
Uno.ui .net 8 is definitely a breaking change because .netstandard 2.0 was removed and with it uwp.

Concerning the support of core libraries. With .net 8 there are two different support timelines. .net 6 has long term support for core libraries. For example mapsui.
The mobile/maui/uno/ios/android... have only support for 6 months after major release meaning .net 6 is already end of life and .net 7 may 2024.
So this means the core libraries have a different support cycle than some ui libraries.

With the updates in mapsui . Net 7 mapsui should work on .net 8 (tried it for Maui for uno I don't know yet will try when official . Net 8 release comes out)

Conclusion to the .net 3.1 removal as long as it compiles I'll keep it.

With the updates in mapsui 4.1, mapsui should work on .net 8 (tried it for Maui, for uno I don't know yet will try when official . Net 8 release comes out)

Thanks for the research!
Alright, then not a lot needs to change from the original plan. The current version works at least with MAUI 8, so thats fine, we can support it for a while.
For Mapsui v5 .NET 6 should be the lowest supported version, so that tooling becomes easier, build scripts become simpler and we can use new C# language features.
https://mapsui.com/documentation/roadmap.html

Found a way for targeting .NET 8 without breaking changes implementing it now for maui. Afterwards for uno

Things done: readded back removed uno and maui targets should now work with the .net 8 framework.

https://www.nuget.org/packages/Uno.WinUI/5.0.19 👀 🤫

https://www.nuget.org/packages/Uno.WinUI/5.0.19 👀 🤫

Thanks for the info.
@pauldendulk
So I think this Pull request is ready to be merged


add multitrack conference remove old conference structure

https://github.com/ant-media/Ant-Media-Server/issues/4626

When will this be merged?

@AlbinNewSeed , Its currently under review , it may take some time to get merged.


Initial release

Various commits not intended to be merged until it's decided Moe is ready for release.

Codecov Report

Merging #43 (d46556f) into master (30c748a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   98.59%   98.59%
=======================================
  Files          24       24
  Lines        1142     1142
=======================================
  Hits         1126     1126
  Misses         16       16

Flag
Coverage Δ

integration
61.55% <ø> (ø)

unit
90.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


[Example/Notebook] Jupyer Notebook Server and Client Example Contain Old Code Leads Error

What happened + What you expected to happen
In FedScale/examples/notebook, the server and client contain old code "from fedscale.core.logger.execution import args" which suppose to be in new form "import fedscale.core.config_parser as parser" -> args = parser.args
Versions / Dependencies
FedScale 0.5, pip install -e .
Reproduction script
It happened when I tried to run the example code in jupyter notebook after installation. So it would be great to fix it to not to confuse new users.
Issue Severity
Low: It annoys or frustrates me.

@IKACE Hi, Yile. Can you please fix this due to the last commit? #175 Thanks!


Guess the colour using RGB coordinates game

I am a GSSoC23 contributor.
Kindly assign me this issue.
A basic game with 3 (or 6) options for choosing which will be the best colour for the closest match for the asked RGB coordinates.
@Shreyaar12 @cleveranu @Dharmesh177 @artimanputra

I am already working on this. Please assign me this issue, so that I can create a PR asap.


Is there any way to run it in MAC OS ?

I am getting below error
Node - v18.7.0
Npm - 8.15.0
Python 3.10.6

Hi @ChetnaSingh007 as you can see here https://github.com/bigcommerce/checkout-js/blob/master/package.json#L8 we support node v14 and npm v6 as of now. So can you try again with the above versions please.


Wrong sudo command in ConfigureVisibilityOnHost for OS X

#{self.class.sudo} should just be #{sudo}.

Merged via pull request #232


fix codecov and precommit

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.70%. Comparing base (3ab41eb) to head (bc83e57).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #264   +/-   ##
=======================================
  Coverage   77.70%   77.70%
=======================================
  Files          11       11
  Lines        1722     1722
=======================================
  Hits         1338     1338
  Misses        384      384


SDFG Editing

This continues work started by @tobiasae in #18.

[x] Add library nodes
[x] Add states
[x] Add general nodes
[x] Add map scopes
[x] Add consume scopes
[x] Edges
[x] ~Add connectors~ The current interface is enough for the time being, other connectors should be automatically added by adding edges in Phase 2
[x] Delete elements / edges

This requires SDFG element property editing to be useful, tracking #40.

@phschaad remember to update submodule after webclient is merged.
Seems like there is a merge conflict here too


Chrome extension does not add "view source" button on Android doc

I don't know how much is copied/forked from Roman Nurik's extension. But your Chrome extension listing says:

Adds a 'view source' link next to the SDK class name for class reference pages on developer.android.com. Clicking this link navigates to the relevant source file on android.googlesource.com.

And for me it does not work. It does on Roman's extension.
Is this a bug, a missing feature?

Can you post a screenshot? It's working for me. Here's a screenshot of it that's used for the Chrome listing: https://github.com/JakeWharton/SdkSearch/blob/master/frontend/chrome-extension/store/screenshots/2.png

Sorry my bad. Roman's extension put a big bordered button on the page, and yours is too well integrated in it. I missed it.
Thanks!


testing: new make command for testing in clean db

Note
You will need a new variable in your local .env file, NODE_ENV=local
It's still not 100% ideal, but I do think it helps to have that separation between automated test db and dev db. This will ensure that you have a clean slate to work with everytime you run the local testing setup command

Seems to work well, just one comment regarding the issues I had while getting setup. Happy to approve once that's updated.
Can you also add NODE_ENV=local to the .env.example file.


Retrieve multiple documents from Firestore with getAll()

Hello,
In the Google Firestore doc there is a method called getAll used to retreive multiple documents.
Link to doc: https://cloud.google.com/nodejs/docs/reference/firestore/1.1.x/Firestore#getAll
It seems there is no such thing in AngularFirestore. It would be very kind of you to add this in future releases.. Is this planned ?
The only workaround I found is using RxJs CombineLatest:
orQuery(){

    const $one = this.afs.collection("posts", ref => ref.where("blogId","==","1")).valueChanges();
    const $two = this.afs.collection("posts", ref => ref.where("blogId","==","2")).valueChanges();

    return combineLatest($one,$two).pipe(
        map(([one, two]) => [...one, ...two])
    )
}
getOr(){
    this.orQuery().subscribe(data => console.log(data))
}

Thanks !

Hey there @phpgeekfr, good catch. The @google-cloud/firestore sdk is the administrative module, meant to be run on a backend server, it has a couple features that we don't have.
We use the client-side Firestore SDK (firebase/firestore) which is documented here. This has many features the administrative SDK lacks ;) I can't speak to the roadmap on that project.
The workaround you found is the correct was to do it in AngularFire. We're working on rxjs pipes to do things like this more easily in rxfire, stay tuned.


Error while running sanity test

When i am running python tests/square_test.py i am getting below error
traceback (most recent call last):
  File "tests/square_test.py", line 61, in <module>
    main()
  File "tests/square_test.py", line 47, in main
    dirt_pixels = get_dirt_pixels().eval()
  File "/miniconda3/envs/py2/lib/python2.7/site-packages/tensorflow_core/python/framework/ops.py", line 798, in eval
    return _eval_using_default_session(self, feed_dict, self.graph, session)
  File "<USER_HOME>/miniconda3/envs/py2/lib/python2.7/site-packages/tensorflow_core/python/framework/ops.py", line 5407, in _eval_using_default_session
    return session.run(tensors, feed_dict)
  File "<USER_HOME>/miniconda3/envs/py2/lib/python2.7/site-packages/tensorflow_core/python/client/session.py", line 956, in run
    run_metadata_ptr)
  File "<USER_HOME>/miniconda3/envs/py2/lib/python2.7/site-packages/tensorflow_core/python/client/session.py", line 1180, in _run
    feed_dict_tensor, options, run_metadata)
  File "<USER_HOME>/miniconda3/envs/py2/lib/python2.7/site-packages/tensorflow_core/python/client/session.py", line 1359, in _do_run
    run_metadata)
  File "<USER_HOME>/miniconda3/envs/py2/lib/python2.7/site-packages/tensorflow_core/python/client/session.py", line 1384, in _do_call
    raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.InvalidArgumentError: No OpKernel was registered to support Op 'Rasterise' used by node Rasterise/RasteriseBatch (defined at <USER_HOME>/miniconda3/envs/py2/lib/python2.7/site-packages/tensorflow_core/python/framework/ops.py:1748) with these attrs: [channels=1, width=128, height=128]
Registered devices: [CPU, XLA_CPU, XLA_GPU]
Registered kernels:
  device='GPU'miniconda3

         [[Rasterise/RasteriseBatch]]

I am using tensorflow==1.15.0 and tensorflow-gpu==1.15.0 and python 2.7

This is not an issue with DIRT; rather, tensorflow cannot see your gpu.

This is not an issue with DIRT; rather, tensorflow cannot see your gpu.


could you give a description file about the meaning of each part of the output file?

I have found docs for .bcd files here: https://github.com/liamadvance/smm2-documentation
Any docs for .btl files?


FYI - speedup r10k puppetfile install with g10k

Hi  @dylanratcliffe and @GeoffWilliams
This is a speedup FYI - not sure where to put it...
Thanks for onceover - a very cool tool @GeoffWilliams introduced us to. I am hooking onceover into our CI system and on new PRs and merges, a whole new copy of modules needs to be deployed via r10K. This can be quite tedious as have made great progress speeding it up with the nice parallel option
I have had some success using g10k prepping the control repo. g10k isn't a drop in replacement and doesn't like the forge directive or module names with hyphens that are in git (assumes they are from the forge), but it does locally cache modules, which means setup is ~5 seconds, and not a couple of minutes
There is some jiggery pokery but it gets me to where I need as this needs to happen after deploy.rb but there's no easy way to jump in. Here's what our makefile looks like for spec tests
ONCEOVER_DIR=.onceover/etc/puppetlabs/code/environments/production

	mkdir -p ${ONCEOVER_DIR} && \
	sed -e '/^forge/d' -e 's#saz-rsyslog#saz/rsyslog#' -e 's#martyewings-agent_run_with_tags#martyewings/agent_run_with_tags#' Puppetfile.onceover > ${ONCEOVER_DIR}/Puppetfile.g10k && \
	cd .onceover/etc/puppetlabs/code/environments/production && \
	/usr/local/bin/g10k -usemove -puppetfile -puppetfilelocation ./Puppetfile.g10k
	bundle exec onceover run spec --skip_r10k --puppetfile Puppetfile.onceover --parallel --format documentation

Regards
John

Hey John!
I've used a local forge in the past (artifactory pro) which has given a massive speedup. I've also hacked around with a ../modules directory full of checked out modules from git which can then be copied into onceover via Makefile like this:
onceover:
	# assumes you have all required modules checked out at ../modules - COPY
	# them all to `site` which is in the modulepath so that our local modules
	# can be found. needed because R10K and onceover dont support local modules
	# and/or symlinks at the module level
	# check all syntax + lint
	bundle exec onceover run codequality --no_docs
	PATH=spec/mock:$$PATH bundle exec onceover run spec --puppetfile Puppetfile.onceover

# useful to fix too many levels of symlinks error after running PDK
clean:
	rm -rf .onceover

For me, this was a really easy and fast way to work with modules on a workstation where stuff is under active development - appreciate this might not be that useful to you. Onceover does do some caching of downloaded modules but I bet these are being lost between test runs in your CI environment. If your containerised it might be worth finding the cache and making it a volume. There is also an r10k.conf file you can create to configure a global cache too - depending how far down the rabbit hole you want to go.
The extract you shared looks pretty good - I looked at the g10k issue you shared and there's a workaround in there. I would probably handle this by saying to remove the hyphen from forge modules downloaded from git (never even noticed this was allowed before):
mod "rsyslog",
  :git => "https://github.com/saz/puppet-rsyslog",
  :ref => "DEADBEEFDEADBEEF"

This stanza would be correctly deployed by both r10k/Code Manager and g10k. Failing that your options are sed tricks or fixing g10k to account for the longer syntax.
g10k detection and use might be a cool onceover speedup too but like you said there are subtle differences at the moment.

Hi @GeoffWilliams
Thanks for taking a look
We just got Artifactory Pro, but are a little way off using it to mirror forge modules, but yes that is the simplest choice
As you say - the hack you suggested isn't going to work too well, and containerizing the CI is even more work!
The only reason we have hyphens in module names is for local forks of forge modules while waiting for PRs to be looked at, so may be confusing when we go back, but that will be probably what we will do. Swings and roundabouts
Would be great even if r10k could download in parallel, the issue isn't seen as important

https://github.com/puppetlabs/r10k/issues/54
https://tickets.puppetlabs.com/browse/RK-298

@johnwarburton r10k can download in parallel! (as of very, very recently) and I agree that the clone time is a huge, huge pain in the ass. This PR: https://github.com/dylanratcliffe/onceover/pull/226 implements support for adding an r10k config file which lets you set the number of threads. I've tested it on Mac and it's amazing but it's failing tests on Windows but I haven't been able to work out why. If you can point me at what's going on I'll fix it and release the new functionality which will solve your problem

Hi @dylanratcliffe
Thanks for taking a look at this. Our use case in in a Jenkins CI pipeline so we need onceover to run very quickly.
The fact you can use r10k pulling stuff down in parallel is good (better than before), but the caching of forge module downloads is what I am looking for. If PR #226 allows a fully working r10k config file, then it might help, but documentation around R10K caching is thin and somewhat confusing as to what is supported (https://tickets.puppetlabs.com/browse/RK-61, https://github.com/puppetlabs/r10k/pull/729). g10k caches the tgz as well as unpacked tgz so I would have to test timings, but at the moment, g10k is "blindingly fast"

r10k should now be able to run in parallel by placing the following in spec/r10k.yaml:
---
pool_size: 10

This requires 3.16.0 As per the r10k docs

Thanks @dylanratcliffe  - will take a look when I get back to work later in the week


allow pages to hide title while still setting one (for seo)

Description

page.title is not just used by layout.html  but also by our SEO plugin.
There is a desire on our intro page to not show the page title but still provide one to google SEO.
This PR makes that possible
Related issues/PRs

Todos

[ ] Tests
[ ] Documentation
[ ] Release note

Release Note

None required

Deploy preview for calico ready!
Built with commit 0188c71c15f01987259881c1bc14b24f013df753
https://deploy-preview-2899--calico.netlify.com


Change YCSB Data to 100 Bytes, Possible?

I would like to send 100 bytes, how can I achieve this with YCSB?

Any details or information would be great.  I wanted to use 100 byte packets to take our CPU higher during ycsb runs.  I know run_benchmark has this option as byte count 100 is done on command line as S:100, can YCSB do this as well?


Update release notes for 13.1

Just add the single ohai deprecation

Should https://github.com/chef/chef/pull/6156 get added too? i missed adding it to the release notes in my PR


Update gerrit kube app to support new fabric8/docker image (env vars / volumes)

Update gerrit kube app to support new fabric8/docker image (env vars / volumes) :

Add missing env vars (create-user-plugin, java-job changing the permissions)
Define the volumes (keys to be imported)
Change link to gogs service
Update doc to explain how to copy the public keys to be imported (jenkins, sonar, ...) using our vagrant vm host

Code submitted with the PR - https://github.com/fabric8io/quickstarts/pull/477


remove uses of removePosArg from the tree

Motivation

I have a long-term goal of making Send nodes functionally immutable with respect to the number of arguments they contain -- you are free to modify the arguments themselves, but not to add or remove arguments.  If you want to do that, you'll have to figure out how to copy the relevant Send node and use it instead.  (This could wind up being expensive, I suppose, but looking at the places we use the *PosArg family of arguments already on Send, I don't think any of them are hotspots -- with the possible exception of MK::Helpers::Assign.)
removePosArg gets in the way of that goal, and we can rewrite code to not use removePosArg, so let's do that.
Test plan

See included automated tests.

What’s the point of the goal? Trees are in general quite mutable

What’s the point of the goal? Trees are in general quite mutable

The rationale is to dispense with the InlinedVector for storage of the args and store the arguments directly as part of the Send object.  This will make sends smaller and definitely save space for the common case of zero/one arg sends.  It is roughly speaking space-neutral for other even arg counts, and slightly smaller for other odd arg counts.


Disable when ?

Great tool! Most minifiers for ASP.NET are wired to disable themselves when compilation debug="true" in web.config. Any chance that's on the roadmap? Thanks!

Its not but you can easily disable it in several ways. [This Wiki](See https://github.com/mwrock/RequestReduce/wiki/How-can-I-disable-RequestReduce%3F)


Support to enable kubeapi extra admission plugins

This would allow users to specify alpha admission controllers and adds extra configuration knobs for me to maintain. I maintain that those responsible enough to evaluate non-default admission controllers can also be responsible for carrying a patch with those customizations. I wouldn't want to expose such an option in Typhoon either - people add/remove plugins they shouldn't and file issues on me when things break.
I've turned down similar requests for the same reasons.


Delete hackathon.md

I can't see it anywhere so I think it's leftover and can be removed. Anyone aware of this being used?

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/f5062994701a339024d9799c61416f6b4951d659/

@sploiselle, do you think we'll need this file for future hackathons?

We aren't currently using it and it could be trivially re-added in the future. Think this is fine to delete. LGTM.


New db to speed up full text queries and library updates

All the .json.gz and .json.stock files have been processed into three compressed tables/files, downloadable as a single 20MB tar archive; these tables are copied directly into IndexedDB without decompression. The database update now takes ~150ms + time to download a 20MB file.
Running queries on IndexedDB for full text search previously took around 15 seconds for "Select". These queries on this new db take around 2 seconds for "Select", and act on the compressed tables. Note: the query takes ~1.5 seconds, but an extra variable amount of time is lost to allow aborting the query, and yielding to the UI.
The code to process the .json.gz/.stock.json files is in javascript, and takes around 15 seconds to complete.
I'm currently using gzip for compression. I tried with lz4, which was 3x faster, until I changed any of the code to allow streaming decompression. Could be worth looking at in future, when lz4 is natively supported by browsers.

First, let me say a huge thank your for the work you are putting into this and the other related PR. I really like it and appreciate it.
I have, however, one suggestion to make. I suggest removing [generateJsonlinesDatabaseFiles.js](https://github.com/yaqwsx/jlcparts/pull/114/files#diff-4afa54d033975e4da9f76722851b166de044d8bca7ebfcd6d9221d0113600563). And also removing the old JSON files. Having them is just an extra burden, inefficiency, and overall messy IMHO (why keep something we don't need?). Also, having data processing in two languages is an extra maintenance burden.
We have a SQLite DB that has all the components stored in a raw format. From that, we generate the per-category JSON files. We already have a library abstraction that hides the DB and allows you to operate in "part" and "category" terms. The whole generator is in https://github.com/yaqwsx/jlcparts/blob/1a412750247bfa9ecb4fffc9617286025f2decd7/jlcparts/datatables.py#L351-L384
I have two suggestions:

let's generate whatever format you need in Python by rewriting the datafiles generating. This is the preferred option.
let's discard the original datatables and let your script operate on top of the SQLite (not so preferred).

What do you think?

First, let me say a huge thank your for the work you are putting into this and the other related PR. I really like it and appreciate it.

Most welcome. I have been using your page quite often recently, and I love it, so thank you for creating it.

I have, however, one suggestion to make. I suggest removing [generateJsonlinesDatabaseFiles.js](https://github.com/yaqwsx/jlcparts/pull/114/files#diff-4afa54d033975e4da9f76722851b166de044d8bca7ebfcd6d9221d0113600563). And also removing the old JSON files. Having them is just an extra burden, inefficiency, and overall messy IMHO (why keep something we don't need?). Also, having data processing in two languages is an extra maintenance burden.

If we remove the generateJsonlinesDatabaseFiles.js file, and put the processing in the python script, then there's no need for the original subcategory JSON files to be created. If they're not used by anything else, then of course, they can go.
I wrote it in js, as it's easier for me, as I don't program in python. I can add it to the python script; it shouldn't be too complex.

We have a SQLite DB that has all the components stored in a raw format. From that, we generate the per-category JSON files. We already have a library abstraction that hides the DB and allows you to operate in "part" and "category" terms. The whole generator is in
https://github.com/yaqwsx/jlcparts/blob/1a412750247bfa9ecb4fffc9617286025f2decd7/jlcparts/datatables.py#L351-L384
I have two suggestions:

let's generate whatever format you need in Python by rewriting the datafiles generating. This is the preferred option.
let's discard the original datatables and let your script operate on top of the SQLite (not so preferred).

What do you think?

I think the first option is the best (i.e. change output format of the generator), as it's a simple change and leverages your existing code, which has proven to work, and handles a bunch of edge cases.

The python script has been updated to generate the single output file, without creating the *.json.gz and *.stock.json file, and the javascript file has been nuked.

@yaqwsx Is there anything further I should do to with this PR (or the others)?

It's my turn; I'll review them ASAP. I just ran out of my time allocated for the OSS projet's maintenance as there was a lot of work on KiKit with the recent release of KiCAD v8.

Ok, no worries. I'm not trying to push you (I can use my test site), I just wasn't sure if I'd done it wrong.
I did notice the auto-merge of the different PRs makes bad merges (they touch similar parts of the same files). If you can say which PRs you want to include, I can rebase those ones on each other, sequentially, and correct the bad merges.


Unsupported chains pops up after SIWE signing

What problem does this new feature solve?
What I mean is that this situation arises after integrating SiweConfig.
The current issue is that the sign dialog pops up without checking if the chainId is supported. Moreover, there are no hooks or callbacks provided for customizing the sign, which leads to a situation where after signing, it checks for unsupported chains, prompts to switch chains, and then requires signing again. This is unreasonable and unfriendly.
Describe the solution you'd like
Before executing the Siwe signature, it is necessary to check if the chainId is in the chains list. If it is not in the list, prompt to switch the chain first, or automatically switch to the default chain before executing the signature.

Duplicated. Copied 👍

is this solved? im having issues as well and if the chain is not supported i get this


(Feature) - 1029 Improve Polling behaviour

Closes #1029
Description

Adds exponential-backoff dependency for implementing backoff in case that a request fail
Also converts all the "fetch methods" to singleton to avoid call an API before the last request finish

We could probably in another pr improve this and maybe try the library that @nicosampler suggested :) but at least for now I think it solves our current problem

Travis automatic deployment:
https://pr1047--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1047--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1047--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1047--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1047--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1047--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1047--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1047--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1047--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1047--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1047--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1047--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1047--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1047--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1047--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1047--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1047--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1047--safereact.review.gnosisdev.com/app

Travis automatic deployment:
https://pr1047--safereact.review.gnosisdev.com/app


Lock pinecone to major version

I don't think so -- we're currently using v2.2.4 on the Framework, but when installing for integration tests it pulls the newer v3.


Allow enter key on multiple inputs.

Disabling keyboard auto-save behavior when dealing with multiline fields. Makes sense to me to allow multi-lines in a textarea.

Thanks for the PR! This looks fantastic — I'll merge it today.


HV-972 Avoid dependency on ASM4 (upgrade groovy-jsr223)

https://hibernate.atlassian.net/browse/HV-972

HV-5-MASTER #686 SUCCESS
This pull request looks good

Thx!


Does dehydrated fully support IDN's 'Internationalized Domain Names)?

Does dehydrated fully support IDN's 'Internationalized Domain Names)?
Let's Encrypt does as of Oct 20, 2016, but we still don't have this functionality with Aegir (Drupal) BOA. Is this working, please?
Best,
Ed

Since IDNs are stored as punycode this shouldn't be a problem, just enter the corresponding punycode domains in your config and you should be good to go.


VRAM Requirements

Hello,
nice idea. Any idea what would be the VRAM requirement for 7B version?

Hello,
nice idea. Any idea what would be the VRAM requirement for 7B version?

I think it's about 8G for 7B model, and about 12G for 13B model.


✨ [Test Issue]: FossIndia Demo

Created for Foss Indis Demo

The demo is done. Closing the issue.


Request: Provide git tags and/or GH Releases for crates-io releases

What is the problem your feature solves, or the need it fulfills?
At the moment, there are no git tags or GH releases that match the release on crates.io.
I am starting work on river, and I expect we may need to track the upstream pingora repo, and it would be good to be able to track an issues or PR fixes to ensure river is not impacted.
Describe the solution you'd like
I believe<PHONE_NUMBER>018c4d0ab990166dd020338ae292dc corresponds with https://crates.io/crates/pingora/0.1.0, it would be good to confirm this, and ensure that tags/releases happen in the future
Thank you!

I add the 0.1.0 tag now. Future release will have changelog and tags.

The latest stable changes are tagged and (github) released. They will go out to crates.io soonish

We have a plan in place to make sure are putting out regular releases, so I am closing this as "fixed" and it should stay fixed in the future


Check for empty git config

This fixes #858

@mislav Hmm...I tried to accept the CLA, but I'm getting:

Could you check? The URL with the error page is https://cla.github.com/401025/accept/jingweno

Hi @jingweno, sorry about the issue. I'm working on it right now.

@jingweno can you try again, the URL should be: https://cla.github.com/github/hub/accept/jingweno
Thanks!

@bkeepers It works. You're fast :+1:

Looks good thanks! :+1:


[WIP - DO NOT MERGE] wip: allow a very narrow function conversion

TODO: I still need to fix some migrator test failures and examine what
existing tests to see if there are other useful tests to include here.

@swift-ci Please smoke test

@swift-ci Please test source compatibility

@slavapestov @rjmccall I still need to make another pass over the tests to see if I need to add additional tests, see if the behavior when generics are involved makes sense, and fixup a couple migrator tests, but so far this seems like a reasonable way to allow a very narrow exception to get back some of the usability of closures that accept multiple arguments being used in places that expect to call closures that except a tuple.

@bitjammer Have you seen this assertion failure in the migrator code before? I would expect that some errors & fixits would no longer be present as a result of my changes, but not that the migrator code would run into assertions as a result.
Command Output (stderr):
--
/Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/swift/test/Migrator/Inputs/never_compiles_safely_exits_breaking_code.swift:1:15: warning: when calling this function in Swift 4 or later, you must pass a '()' tuple; did you mean for the input type to be '()'?
func foo(_ f: (Void) -> ()) {}
              ^~~~~~
              ()
Assertion failed: (FD >= 0 && "File not yet open!"), function preferred_buffer_size, file /Users/buildnode/jenkins/workspace/swift-PR-osx-smoke-test/branch-master/llvm/lib/Support/raw_ostream.cpp, line 624.

Yes, that means that (usually) we forgot to make the destination directory for the migrated swift or remap file. I'm guessing you made something compile that didn't before? That's why the test is continuing on into the migrator and emitting migrated contents. I think that test will need to be updated to some other code that can't compile (and doesn't have proactive fix-its that the migrator can try to pick up before actually doing the migration).

To be clear, the test is not supposed to rm -rf/mkdir because it's not supposed to make it to emitted migrated stuff. It just needs to be updating to something else that still doesn't compile.

@swift-ci Please smoke test

@swift-ci Please test source compatibility

@swift-ci Please test source compatibility

I'd rather we did this by going back to the Swift 3.1 behavior instead of adding new unproven semantics.

Something like this: https://github.com/apple/swift/pull/10257

@bitjammer David, my change here backs out https://github.com/apple/swift/commit/726adfb83e281db520e51e7d5dc64cce794fd6e1 because it no longer seems necessary with this update to the type checker since we no longer emit that fixit for these cases. I also updated never_compiles_safely_exits_breaking_code.swift as a result as well, but I think that was from a different commit.
Do these look okay?

@swift-ci Please test source compatibility

As long as you feel that the diagnostic won't come up in other cases which would be surprising during migration, it's fine by me if you want to remove that filter.

@swift-ci Please test source compatibility

@swift-ci Please test source compatibility

@swift-ci Please smoke test

@swift-ci Please smoke test


Returns null when trying to crawl

$ sitemap-generator https://forum.colemak.com/
null

$ sitemap-generator -d https://forum.colemak.com/
Site "https://forum.colemak.com/" could not be found

Ubuntu 16.04 x64
NodeJS 6.3.0
<EMAIL_ADDRESS><EMAIL_ADDRESS>Other subdomains on the same server seem to work OK:
$ sitemap-generator -d https://chat.colemak.com/
[ OK ] https://chat.colemak.com/
Added 1 pages, ignored 0 pages, encountered 0 errors.

Duplicate of the below:
https://github.com/lgraubner/sitemap-generator/issues/4

Duplicate of the below:
https://github.com/lgraubner/sitemap-generator/issues/2


Support for inverse cosine/sine ect in run.

Inverse trygionometry.
Id love for there to be support for inverse Cosine and sine and tangent.
Or if there is already a code for that id like to know it.
Edit:
Thx 4 the fast response.

So do you want a new PowerToy for this?

It's for PowerToys Run

Oh i saw it

you can, =arcsin(1)

i was only using 1 c 🤦


Unique G14Control plan name error after deleting plan

After deleting a G14Control plan, when I try to create a new plan with the same name, I get a "Plan names must be unique" error, even though the plan is deleted.
This issue could be related to #31.
My workaround is similar to what I mentioned in #31. I click on a different tab and go back to the Plans tab.
I am currently running version 0.1.37.

I have just fixed this issue. I was able to recreate it and debug and now it should work :)

I have just fixed this issue. I was able to recreate it and debug and now it should work :)


Error on running line 169 (TaskClassifST)

https://github.com/konstantinschellenberg/EO-College_Slangbos/blob/0894c896f698ce3ee10e89d460df766b02ab4848/R/01_modelling.R#L169
Hi,
First off, thanks for the tutorial.
I keep getting the following error on running line 169:
Error in .__Task__initialize(self = self, private = private, super = super,  :
Assertion on 'feature types' failed: Must be a subset of {'logical','integer','numeric','character','factor','ordered','POSIXct'}, but is {'integer','sfc_POINT','numeric','factor'}.
I am using the dataset provided in the course. I even tried re-installing R version 4.1.2 but the error persists.
Any insights on what could be causing this?

Hi nhambi-r,
thanks for posting this issue! I was out of office lately, thus I could not response to your inquiry here - I'm sorry.
The error arises from changes in the API of the mlr³ sub-package mlr3spatiotempcv > 1.0.1 (most recent is 2.0.1, see here)
The problem can be shifted around when installing the spatial backend lib mlr3spatiotempcv from github via remotes::install_github("mlr-org/mlr3spatiotempcv") (it is Version <IP_ADDRESS>00 then) since the bug apparently only exists in the CRAN version.
I've posted an issue to the package dev team - you can follow the discussion here.
Thanks for following my tutorial and keep my updated on any other comments or issues.
Best,
konstantinschellenberg


pilot.validation.istio.io does not allow FQDNs

Bug description
Pilot does not allow the use of FQDNs in .spec.http.route[*].destination[*].host.  It's imperative that FQDNs are usable here as kube-dns will treat it as a relative domain, try to find it in the local root domains it knows about, before discovering it is an FQDN.
Helm output:
Error: UPGRADE FAILED: admission webhook "pilot.validation.istio.io" denied the request: configuration is invalid: 2 errors occurred:
Step #4:     * domain name "test.test.test.root.org." invalid (label "" invalid)
Step #4:     * domain name "test.test.two.root.org." invalid (label "" invalid)

This article provides more details why FQDNs are valuable: https://www.revolgy.com/blog/debugging-kube-dns-and-using-fqdns
This PR seems similar, but affects a different part of the VirtualService: https://github.com/istio/istio/pull/6483
Affected product area (please put an X in all that apply)
[x] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[x] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Expected behavior
To be able to use an FQDN
Steps to reproduce the bug
End any domain that is can be an FQDN with a . as a VirtualService's destination.
Version (include the output of istioctl version --remote and kubectl version)
istioctl version --remote
client version: 1.2.1
citadel version: 1.2.5
galley version: 1.2.5
ingressgateway version: 1.2.5
ingressgateway version: 1.2.5
ingressgateway version: 1.2.5
pilot version: 1.2.5
pilot version: 1.2.5
policy version: 1.2.5
policy version: 1.2.5
telemetry version: 1.2.5
telemetry version: 1.2.5

kubectl version
Client Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1", GitCommit:"b7394102d6ef778017f2ca4046abbaa23b88c290", GitTreeState:"clean", BuildDate:"2019-04-19T22:12:47Z", GoVersion:"go1.12.4", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.9-gke.15", GitCommit:"b48a8d693e191192e27c2f807daa51b54d0b0a61", GitTreeState:"clean", BuildDate:"2019-08-12T17:49:30Z", GoVersion:"go1.10.8b4", Compiler:"gc", Platform:"linux/amd64"}

How was Istio installed?
Helm charts
Environment where bug was observed (cloud vendor, OS, etc)
GKE
Additionally, please consider attaching a cluster state archive by attaching
the dump file to this issue.

Related: https://github.com/istio/istio/pull/14405 which should allow this.. not sure whats going wrong. Please provide the exact VS you applied

Oh its only in istio 1.3

So we upgraded to istio 1.3 and ended up receiving 503s when using FQDNs.

can you send the exact config you applied and the resulting envoy config?

@howardjohn will do! Have some other stuff to look into first.

When it works
One destination is an address outside the cluster that has Istio running on it. I will have to check with my team mate with regards to what that means.
istioctl proxy-config cluster -n istio-system istio-ingressgateway-556bdf7fb7-8dmns
api.external.vm.domain              443       -          outbound      STRICT_DNS
auth.namespace.svc.cluster.local   3822      -          outbound      EDS

apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  creationTimestamp: "2019-09-16T06:39:36Z"
  generation: 10
  name: api-vs
  namespace: istio-system
  resourceVersion: "439167243"
  selfLink: /apis/networking.istio.io/v1alpha3/namespaces/istio-system/virtualservices/ctp-istio-projects-ws
  uid: c02db44b-d84c-11e9-88b9-42010a840097
spec:
  gateways:
  - istio-api-gateway
  hosts:
  - api.domain.one
  - api.domain.two
  http:
  - route:
    - destination:
        host: api.external.vm.domain
        port:
          number: "443"
      weight: "50"
    - destination:
        host: api.namespace.svc.cluster.local
        port:
          number: "3822"
      weight: "50"

I've discovered the core of it. Bit of an Istio novice here.
So I knew about the Virtual Service, and the Destination Rule, but what I did not know was that there was a Service Entry that defined my external hosts for Istio. No more 503s, but I need to get to the bottom of some extreme sluggishness now.


CNV-28248: Display CPU and memory from VMI on VM Details page

📝 Description
For VMs created from InstanceTypes the CPU and memory on the VM Details page is currently being read from the InstanceType, which leads to a mismatch on the VM Details page if the Instancetype is updated. The value circled on the graph shows the actual value.
🎥 Screenshots
The InstanceType used to create the VM starts off having 1 CPU and 4GiB of RAM. Between the "Before InstanceType update" and "After InstanceType update" screenshots, that InstanceType is edited to have 2 CPU and 2GiB of RAM.
Before
Before InstanceType update

After InstanceType update

After
Before InstanceType update

After InstanceType update

/lgtm
/retest

/retest


Remove standard js, use eslint

This undoes parts of https://github.com/ManageIQ/manageiq-ui-service/pull/886, removing the standard js linter and replacing it with eslint, same as ui-classic.
The new eslint config is:

globals and ignore from standard js config
eslint defaults,
eslint-config-angular,
disable a bunch of angular rules which were failing - all of these are essentially "use angular version of whatever you're using" and make little sense in the context of a react future
disable no-unused-vars - we should have this enabled and set to ignore underscore-prefixed names, but currently there are 71 places with this issue

That brings us to a minimal default config which currently passes validation.
Enabling all the same rules ui-classic has would mean mass-converting everything again, little point to that IMO.
But we can now add/remove rules on a case by case basis :).
(And trailing commas or semicolons are OK by default now.)

Cc @mzazrivec


34 - Create the table of the design system

What this PR does / why we need it:
This PR add the table element of the design system which is the Bootstrap 5 table with striped rows.
Which issue(s) this PR closes:

Closes #34

Special notes for your reviewer:
I only included the table to display data with is the one provided by Bootstrap.
There is another table being used in the Dataverse for the files management with contains filtering and search features. I think this logic is out of the scope of this design system table so I didn't included here. The table for the files management could be develop in the issue for creating the File tab of the Dataset page because we may need to do a research to decide if it makes sense to do this table adoc or to use a library for this task. We could decide then if it makes sense to add it to the design system.
Suggestions on how to test this:
npm run storybook
Go to the Docs page in the Storybook for the Table element to see it rendered
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
None
Is there a release notes update needed for this change?:
Table added to the design system
Additional documentation:
https://docs.google.com/document/d/1OxCQO7B-yJaMWRl8EzuflcSmIaCmVSs19aoD83PjPmA/edit#heading=h.x2qrlcdwtvag

@MellyGray can you please resolve the merge conflicts?

@kcondon done!


setTimeout does not fire in order

import { setTimeout } from "k6/experimental/timers";

export default () => {
	setTimeout((_) => console.log("one"), 100);
	setTimeout((_) => console.log("two"), 101);
};

If you run this with multiple iterations you would expect you wll always get
one
two

but you sometimes get them in reverse.
The specification on this has this very strangely specified but if the source  of the task is the same they should be in order.
So even if in the above the timeouts were the same it still should fire in the order that they were added.
This might be a very tiny problem for some cases, but makes subtle problems from the things I had to test.

Blocked on #8


Enum keys can conflict with Python Keywords

I'm generating a client for a GraphQL definition that includes an enumeration with the key None. It appears to be coming from here:
https://github.com/jhnnsrs/turms/blob/1de3aebf828a18d1199a2007006777572124ce12/turms/plugins/enums.py#L81
It seems like doing an iskeyword check similar to this would fix it:
https://github.com/jhnnsrs/turms/blob/1de3aebf828a18d1199a2007006777572124ce12/turms/registry.py#L110
I think any existing places where this is happening would already be producing invalid code so I'm pretty sure the change is non-breaking.
I'm happy to submit a PR if the proposed fix sounds good. WDYT?
Thanks!

Hey @josephlewis42  I am super sorry, this one completely got lost on the way :-( but is actually resolved now and should work in v.0.6.0. Hope this didn't bother you too long


Add ref test for sprite and support nested bitfields in static data

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 17 (23.53%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.009%) to 68.537%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

decompiler/IR2/Form.cpp
0
4
0.0%

decompiler/util/data_decompile.cpp
2
6
33.33%

decompiler/IR2/bitfields.cpp
2
7
28.57%

Totals

Change from base Build<PHONE_NUMBER>:
-0.009%

Covered Lines:
38942

Relevant Lines:
56819

💛  - Coveralls


Add A* algorithm in python

The A* algorithm is one of the most effective path finding algorithms used to find the shortest path between two points

Go ahead🚀

Please assign to me

@shubhamnag14 Do you still want to work on this?

i have made on this PR..kindly check it..do the needful

mention PR no.

#199


create login

Need a Login
Need a login to make sure who can have some roles
next-auth github

[x] create a new login branch
[x] install and configure a github login with https://next-auth.js.org/

next-auth with a database

[x] configure an email login, creating tables for postgres (https://next-auth.js.org/adapters/typeorm/postgres)
[ ] create a custom adapter: https://github.com/semantix-engagement-hub/adapters

https://github.com/nextauthjs/adapters for hasura
https://next-auth.js.org/tutorials/creating-a-database-adapter -

using auth0


Feature: add support for API Gateway authorizers

Resolves #2749

Coverage decreased (-0.02%) to 94.106% when pulling 40208363be6a8d29a315c6801683d6ea6cdf350c on jrbeilke:feature-apigw-authorizers into 100dbd529f174f18d579a1dcc066d55409f2e38f on spulec:master.

Looks great; thanks for your work!