Unity 2022.2 Android JDK not found

Bug description
I'm unable to build my game for android due to this error:
DisplayProgressbar: Detect Java Development Kit (JDK)
UnityException: JDK not found
Java Development Kit (JDK) directory is not set or invalid. Please, fix it in Edit / Unity -> Preferences -> External Tools
UnityEditor.BuildPipeline:BuildPlayerInternalNoCheck(String[], String, String, BuildTargetGroup, BuildTarget, Int32, BuildOptions, String[], Boolean)
UnityEditor.BuildPipeline:BuildPlayerInternal(String[], String, String, BuildTargetGroup, BuildTarget, Int32, BuildOptions, String[]) (at /home/bokken/build/output/unity/unity/Editor/Mono/BuildPipeline.bindings.cs:481)
UnityEditor.BuildPipeline:BuildPlayer(String[], String, String, BuildTargetGroup, BuildTarget, Int32, BuildOptions, String[]) (at /home/bokken/build/output/unity/unity/Editor/Mono/BuildPipeline.bindings.cs:359)
UnityEditor.BuildPipeline:BuildPlayer(BuildPlayerOptions) (at /home/bokken/build/output/unity/unity/Editor/Mono/BuildPipeline.bindings.cs:323)
UnityEditor.BuildPipeline:BuildPlayer(String[], String, BuildTarget, BuildOptions) (at /home/bokken/build/output/unity/unity/Editor/Mono/BuildPipeline.bindings.cs:318)
BuildCommand:PerformBuild() (at Assets/_Project/Scripts/Editor/BuildCommand.cs:227)
(Filename: Assets/_Project/Scripts/Editor/BuildCommand.cs Line: 227)

We're using the unityci/editor:2022.2.5f1-android-1 image.
How to reproduce

Use the unityci/editor:2022.2.5f1-android-1 image to build a game for Android.

Expected behavior

The build pipeline is able to locate and correctly setup the JDK, and successfully builds the application. Example log from the unityci/editor:2021.3.9f1-android-1 image:
DisplayProgressbar: Detect Java Development Kit (JDK)
Android PostProcess task "Detect Java Development Kit (JDK)" took 313.5795 ms

Additional details
The 2022.2.0 update introduced a few breaking changes for Android:

Android: Android SDK must have cmdline-tools component installed now. Unity will ignore tools component.
Android: Default gradle templates have changed significantly with new Gradle and AGP versions. Gradle templates in existing projects will have to be recreated based on new default templates when upgrading projects created with previous Unity versions.
Android: Implemented a new system to generate Android manifests internally.
Android: JDK 11 is now required to build Android apps.
Android: Removed Editor UI option that previously allowed you to choose between R8 and Proguard tools to minify code. The new AGP version doesn't have an option to minify using proguard, so R8 is always used instead.
Android: Unity uses Android Gradle Plugin 7.1.2 by default.
Android: Unity uses Gradle 7.2 by default.
Android: Upgraded to using Android NDK r23b. Default linker is now lld which fixes issues with large projects and IL2CPP.
From the official 2022.2.0 changelog

I guess that the JDK 11 bump broke something in the CI image.

This is a duplicate of https://github.com/game-ci/unity-builder/issues/489


Fix bad go build options for darwin; updated docs

Signed-off-by: David Chung<EMAIL_ADDRESS>

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "work-0503" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354207688
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.


Add-stops modification: allow multiple reroutes within a single modification?

When you add stops to a route, you often need to modify both directions of that route. It feels weird to create multiple modifications on the same route just to handle both of the opposing directions.

The problem is that multiple directions tend to have completely different stops (on opposite sides of the street etc.). Fixing conveyal/r5#114 will help, but I'm thinking we may also need to specify start and end stops of a reroute as arrays, and allow reroutes to be applied backwards.

@abyrd my position on this is that rerouting both directions of a route simultaneously is complicated and prone to error, so I'd be in favor of closing this. Thoughts?

Let me know if this is still desirable @abyrd, otherwise I'll close it.

This is probably not necessary. I think the core issue is re-use of the frequency entries. It would be nice to define the service in both directions at once. But the inherent complexity of creating two modifications instead of one is not that terribly different.


empty layouts/datatables_css.blade.php & layouts/datatables_js.blade.php

While running the below command:
> php artisan infyom.publish:layout

Both the files are empty layouts/datatables_css.blade.php & layouts/datatables_js.blade.php
Composer.json require
"require": {
        "php": "^7.3|^8.0",
        "doctrine/dbal": "~2.3",
        "fideloper/proxy": "^4.4",
        "fruitcake/laravel-cors": "^2.0",
        "guzzlehttp/guzzle": "^7.0.1",
        "infyomlabs/laravel-generator": "8.0.x-dev",
        "infyomlabs/laravel-ui-stisla": "^3.0",
        "infyomlabs/stisla-templates": "^1.0",
        "laravel/fortify": "^1.7",
        "laravel/framework": "^8.12",
        "laravel/tinker": "^2.5",
        "laravel/ui": "^3.0",
        "laravelcollective/html": "^6.2",
        "unisharp/laravel-filemanager": "^2.2",
        "yajra/laravel-datatables": "^1.5",
        "yajra/laravel-datatables-oracle": "~9.0"
    },
"require-dev": {
        "facade/ignition": "^2.5",
        "fakerphp/faker": "^1.9.1",
        "laravel/sail": "^1.0.1",
        "mockery/mockery": "^1.4.2",
        "nunomaduro/collision": "^5.0",
        "phpunit/phpunit": "^9.3.3"
    },

Edit: I found this issue only in stisla templates.

ok @rebootcode will look into this issue and fix it if it exists.
Thanks for reporting.

Hii @rebootcode
We have checked and it's empty for purpose, as in the future we are going to add data table listing support, at that time we will write related code into these files.
Thanks for reporting.
We are closing this issue as of now.


Fix term log level limiter when log-file option set

referenced here: https://github.com/rustic-rs/rustic/discussions/907#discussioncomment-7264998

github killed it on branch rename, sorry


Tutorials are largely outdated

A lot of the tutorials are unfortunately outdated due to recent improvements in MCMCChains, e.g. https://github.com/TuringLang/Turing.jl/issues/1411.
I'm opening an issue here so as to bring attention to the, well, issue.

I think maybe it would help to 1) add separate environments for different tutorials (so people can reproduce it even though it is based on an older version of some package) and 2) use CI tests and builds for the tutorials.

100%. But for (2), we likely have to move away from Jupyter notebooks, right? Which, honestly, would be it's own benefit.

And regarding (1), I would say that ideally we'll always have the tutorials work with the most recent release of Turing, since people will look to this for inspiration when writing their own code.
Maybe we should run Pkg.status() at the beginning or end of every notebook too, so that people can view the dependencies.

Maybe we should run Pkg.status() at the beginning or end of every notebook too, so that people can view the dependencies.

That's how it is done in SciML: https://github.com/SciML/SciMLTutorials.jl An appendix is added automatically to every tutorial which shows the packages and Julia version that was used to run it

That's how it is done in SciML

Nice :+1:  And they use jmd as the "base" file?

Yes. And then notebook, HTML, and PDF files are generated with Weave.

Super-dope. Would it be a good idea to just try and duplicate their approach?

Yes, I think that would be great. In particular also thinking about https://github.com/SciML/RebuildAction which we use over at SciML to rebuild tutorials automatically (together with CompatHelper for individual environments this helps to figure out any possible issues).

Yeah I just noticed that; awesome stuff! Cool, well I'm very down for doing that.

All of this is a great idea. I hate the way the tutorials currently work -- they're difficult to write in, difficult to automate, and often out-of-date. Switching to a more general jmd approach is something I'm all for.

Super cool idea.

I've now updated all the tutorials to work with the new system (which is in a separate branch jmd-staging, which we'll merge into master when everything is ready for a full update).
Do have a look:) We also need an updated script to publish the tutorials. One approach could be to just generate the markdown from the jmd file and then use the current Jekyll setup. Maybe that's a good place to start?

One approach could be to just generate the markdown from the jmd file and then use the current Jekyll setup. Maybe that's a good place to start?

Yes, I think that's what we should do (at least initially). IMO we should not update too many things in one step :slightly_smiling_face:

@cpfiffer I might have some questions for you about the documentation setup later, because right now I'm trying to run it locally but using a different branch of TuringTutorials, and I swear I'm loosing hair as I type. It for some reason refuses to render the the pages, despite the markdown files being available in _tutorials/ on the top-level (I messed around with the copy_tutorials method to do so). It's on the jmd-staging branch if  you want to have a go yourself. You generate markdown just by doing
julia --project -e "using Pkg; Pkg.instantiate(); using TuringTutorials; TuringTutorials.weave_folder(\"introduction\", (:github, ))"

while in the project folder.

Do the rendered markdown files have YAML headers? Because otherwise they won't render. The old tutorials code would handle this automatically:
https://github.com/TuringLang/TuringTutorials/blob/38257ab7036575c63113a5b5556c8cd5fd20cb31/weave-examples.jl#L27

Aaah, that might be it

Btw, a small update: I can get the tutorials to render but the formatting is completely broken. Honestly don't understand why, as the output is standard markdown.

Do you have a reproducible example?

Well, it's quite annoying to replicate but here it is:

] dev TuringTutorials and checkout tor/jmd-weaving
Go to ~/.julia/dev/TuringTutorials and run julia --project -e "using TuringTutorials; TuringTutorials.weave_folder("introduction", (:github, ))" for testing
Change the md_path in copy_tutorial in Turing/docs/make-utils.jl to HOME/.julia/dev/TuringTutorials (you have to replace HOME manually)
julia --project make.jl
bundle exec jekyll serve

Should it be tor/jmd-files? I can't find tor/jmd-weaving

Nah, tor/jmd-weaving should be there. Alternatively, you could try jmd-staging which should also work.

I finally managed to obtain a local preview of the docs, and formatting seems to be fine? It took me a while to figure out that the new setup (or maybe just my weird way of changing make-utils.jl) leads to different paths, and I had to go to http://localhost:4000/dev/tutorials/01-introduction/ instead of just following the links to the first tutorial. So math rendering and text formatting seems fine, it seems there's just some problem with the images and gifs (they are copied to the docs folders but instead of displaying them some text is shown on the page).

Regular code output works fine though.

Really? On my end it looks super-strange. Hmm, well, that's good news!
Yeah, I think we have to change where the figures are outputed.

Btw, I realized I had a mistake in the step-by-step guide above. You also need to make sure that the files are "lifted" to the top-level in _tutorials, i.e. copy_tutorial needs to be
function copy_tutorial(tutorial_path)
    isdir(tutorial_path) || mkpath(tutorial_path)
    # Clone TuringTurorials
    tmp_path = tempname()
    mkdir(tmp_path)
    # clone("https://github.com/TuringLang/TuringTutorials", tmp_path)

    # Move to markdown folder.
    md_path = joinpath("/home/tor/.julia/dev/TuringTutorials/", "markdown")

    # Copy the .md versions of all examples.
    try
        @debug(md_path)
        # recursively find files and copy to top-level in `tutorial_path`
        for (curr_dir, dirs, files) in walkdir(md_path)
            for file in files
                full_path = joinpath(md_path, curr_dir, file)
                target_path = joinpath(tutorial_path, file)
                println("Copying $full_path to $target_path")
                cp(full_path, target_path, force=true)
                if endswith(target_path, ".md")
                    # remove_yaml(target_path, "permalink")
                    fix_header_1(target_path)
                    fix_image_path(target_path)
                end
            end
        end
        index = joinpath(@__DIR__, "src/tutorials/index.md")
        cp(index, tutorial_path * "/index.md", force=true)
    catch e
        rethrow(e)
    finally
        rm(tmp_path, recursive=true)
    end
end

But now it works nicely for me to!
A couple of issues:

Stuff like {julia; eval = false} at the beginning of code-blocks doesn't seem to be supported by Jekyll (it's apparently supported by Github though).
Figures aren't referenced correctly (as @devmotion also mentioned)
Naming convention is different. Personally I quite like the convention from SciMl, where you have folders representing different categories. But at the same time, just to get this done asap, it might be preferable to just change the weave-process to use a flattened structure.

"Fixed" (2) and (3) locally, but (1) I can't seem to be able to fix. Even tried using what's supposed to be GFM markdown parsers in Jekyll, but none of them actually handle {julia; eval = false} correctly.

Also there's a question of whether or not we really want to change the filenames and thus the links to the tutorials, given that there probably is a fair bit of links to the tutorials out in the wild.

Figures aren't referenced correctly (as @devmotion also mentioned)

Also there's a question of whether or not we really want to change the filenames and thus the links to the tutorials, given that there probably is a fair bit of links to the tutorials out in the wild.

I guess probably the easiest might be to change the out_dir and set the fig_path arguments in the weave command.

I guess probably the easiest might be to change the out_dir and set the fig_path arguments in the weave co

Actually only need to change out_dir, and yeah, that's exactly what I did:)

Hi, I am just following the step-by-step in Bayes Logistic tutorial on the Turing.jl's website. But I run into an error in the prediction step. Does this have anything to do with the outdated tutorial or something I miss out in the set up? I'm using Julia 1.5.2 and the latest Turing.jl.
julia> predictions = prediction(test, chain, threshold)
ERROR: type AxisArray has no field value
Stacktrace:
 [1] getproperty(x::AxisArrays.AxisArray{Float64, 2, Matrix{Float64}, Tuple{AxisArrays.Axis{:iter, StepRange{Int64, Int64}}, AxisArrays.Axis{:chain, UnitRange{Int64}}}}, f::Symbol)
   @ Base ./Base.jl:33
 [2] prediction(x::Matrix{Float64}, chain::Chains{Float64, AxisArrays.AxisArray{Float64, 3, Array{Float64, 3}, Tuple{AxisArrays.Axis{:iter, StepRange{Int64, Int64}}, AxisArrays.Axis{:var, Vector{Symbol}}, AxisArrays.Axis{:chain, UnitRange{Int64}}}}, Missing, NamedTuple{(:parameters, :internals), Tuple{Vector{Symbol}, Vector{Symbol}}}, NamedTuple{(), Tuple{}}}, threshold::Float64)
   @ Main ./REPL[38]:3
 [3] top-level scope
   @ REPL[40]:1

@torfjelde Any updates on this issue?

Sorry for the delay; submission deadline a couple of days ago.

Naming convention is different. Personally I quite like the convention from SciMl, where you have folders representing different categories. But at the same time, just to get this done asap, it might be preferable to just change the weave-process to use a flattened structure.

This should be the only issue to resolve I think. It's just a question of whether we want a flat structure, and revert the names to the old one, or if we also revamp the project structure in the process.

IMO it would be nice to move away from the flat structure but we don't have to do this right away if it is more difficult. However, as far as I understand, it would be even simpler to not have a flat structure, and in this case I would suggest to change it as part of the updates.
As mentioned earlier, probably different webpages/Google/twitter posts/etc. still link to the tutorials using the flat structure, so it might be good to add manual redirects from the old locations for a while.

However, as far as I understand, it would be even simpler to not have a flat structure, and in this case I would suggest to change it as part of the updates.

Correct + we definitively need non-flat structure for the jmd files so that we can have a Project.toml file for the different tutorials. Right now we just "flatten" the structure in copy_tutorials, which is fine IMO. But then the "numbering" of the names doesn't make much sence, e.g. linear-regression/01.jl and hidden-markov-models/01.jl will both be moved to the same file, which of course can cause issues (stupid example, but you get the idea).
Maybe we should just have a "flat" structure in the sense that in TuringTutorials.jl we have tutorials/01-introduction/, tutorials/02-linear-regression/ and then we use the directory-names as the end of the URL?

As mentioned earlier, probably different webpages/Google/twitter posts/etc. still link to the tutorials using the flat structure, so it might be good to add manual redirects from the old locations for a while.

Great idea :+1: We should do this regardless, as I've done some renaming (which I think is justified, e.g. moving to 01 rather than 1 in the beginning of the tutorial name).

Stuff like {julia; eval = false} at the beginning of code-blocks doesn't seem to be supported by Jekyll (it's apparently supported by Github though).

Also, this is an issue. Ideally we'd have the same rendering as Github, but in the meantime I guess we just try to use regex to remove the braces from those?

For the braces, can't we just have Weave convert .jmd => .md instead? I thought this would be a requirement to get the plots and stuff generated, since we need markdown files anyway for the website.

For the braces, can't we just have Weave convert

Seems like it's considered valid markdown because this is all talking about the markdown generated using Weave.jl :confused:

Oh, my bad. I misunderstood.

Gentle bump - any progress on this @torfjelde? Anything that we could help with?

Sorry, haven't made any progress on this, but the remaining bit is the above, i.e. I'm having trouble with the rendering of the output generated by Weave.jl. Also not particularly familiar with Jekyll, so I was trying out different rendering engines to see why Github manages to render it correctly while our engine can't. And I got super-confused because even the Github Flavoured Kramdown (https://kramdown.gettalong.org/parser/gfm.html) wouldn't even do it correctly :confused:
So really, any help with figuring out how to do this properly would be appreciated. I'll also have another go.

I'm not sure exactly how weave is being called, but historically I set weave(...; doctype="github") which handled all the rendering crap. I ran into the same issue and it sucked.

This is using weave(...; doctype="github"): https://github.com/TuringLang/TuringTutorials/blob/024be8669e251b3590a0eaffb2a0a1068b20d4c5/src/TuringTutorials.jl#L48-L54
So this is where it gets weird. It seems that Github supports braces at the beginning of code-blocks, e.g. {julia} rather than julia, but Jekyll doesn't (even when using GFM parser above).
Does anyone know how e.g. SciML deals with this? Or do they just render the actual HTML directly from jmd rather than using an intermediate renderer like Jekyll?

Does anyone know how e.g. SciML deals with this? Or do they just render the actual HTML directly from jmd rather than using an intermediate renderer like Jekyll?

Looking here, it seems that all of the outputs are generated (regular markdown, html, ipynb) in the main repo, and the links from the README are to plain HTML (one example) without any styling. I'm not sure if the notebooks live somewhere else too, but I haven't seen a place where they have the tutorials integrated into the docs with consistent styling the way that Turing currently does it.
Have you tried manually doing a regex find/replace (^```\{julia\} => ```julia) in the markdown to see if that renders?

and the links from the README are to plain HTML (one example) without any styling

Yeah that's what I gathered too.

Have you tried manually doing a regex find/replace (^\{julia\} => julia) in the markdown to see if that renders?

Nah, and that's of course a possible solution. I just felt like there ought to be a better way :confused: The braces could also include more stuff than just julia, as it's used by jmd to indicate whether or not to evaluate etc. But it should still be possible to write a simple regex to find+replace.

Nah, and that's of course a possible solution. I just felt like there ought to be a better way

Totally agree, was just thinking it might be good to check whether that's the only thing causing issues.
I'm a bit confused though - it looks like weave can output markdown without braces (eg. see here). Is it just dependent on what the input jmd style is?

The braces could also include more stuff than just julia

And Weave can handle that without braces
Or are you saying that Jekyll needs the braces and you can't find a way to render without them?

But it should still be possible to write a simple regex to find+replace.

If this is something you'd like help with, I kinda love regex puzzles :-)

I'm a bit confused though - it looks like weave can output markdown without braces (eg. see here)

Okay, so that's a bit strange. Because when I used weave(...; doctype="github"), lines such as https://github.com/JunoLab/Weave.jl/blob/c9fc740d72dbbd2f0b950f98efedc5ab71f17e3e/examples/FIR_design.jmd#L25-L26 did indeed show up in the generated document. It might be because I added braces {...} around the setup, but that should be supported: http://weavejl.mpastell.com/stable/chunk_options/#Syntax.
Hmm, I'll give it another go and see if it works properly now.

If this is something you'd like help with, I kinda love regex puzzles :-)

Haha, I'll keep that in mind!

Just some random thing I discovered (but I guess I should play around with it first to get a better feeling for the problem): have you tried to use redcarpet instead of kramdown? Maybe that can handle GFM in a better way, see e.g. https://stackoverflow.com/questions/13464590/github-flavored-markdown-and-pygments-highlighting-in-jekyll/13614020#13614020.

I guess this looks better: https://github.com/github/jekyll-commonmark-ghpages
And I found this issue: https://github.com/gettalong/kramdown/issues/503 In the end it was resolved/circumvented with a regex :smile:

@torfjelde I switched to CommonMark and I couldn't observe any problems with the code blocks when following your steps in https://github.com/TuringLang/TuringTutorials/issues/86#issuecomment-705063442. Apart from the figures for which you said it is sufficient to specify out_dir, http://<IP_ADDRESS>:4000/dev/tutorials/01-introduction/ looked fine (somehow there's an import problem when displaying the TuringTutorials information at the bottom of the page, but maybe that's a problem with my weird local setup).
So the only changes that I applied were:
Adding
group :jekyll_plugins do
  gem 'jekyll-commonmark'
end

to Turing/docs/Gemfile and replacing markdown: kramdown with markdown: CommonMark in Turing/docs/_config.yml

Ah, super neat! I'll give that a go too!

Okay, so the issue with commonmark is that the maths gets messed up  (plus we seem to lose code highlighting, though this might just be a config somewhere?) :confused: Are you not also seeing the same thing @devmotion ?

Ah, so it seems that kramdown actually does some conversion of maths, e.g. $$...$$ within sentences are converted into \(...\) while if $$...$$ is on it's own line then is converted into \[...\]. Commonmark does nothing to these and so mathjax cannot tell the difference between inline and display maths.

Oh I always assumed the standard for inline math is $...$. Isn't that how you usually write inline math in Weave? Or is it only generated by Weave in the GFM output?

I think the solution is to add:
<script>
 MathJax = {
   tex: {
     inlineMath: [['$', '$'], ['$$', '$$']]
   }
 };
</script>

to docs/_includes/headers.html and use the CommonmarkGhPages renderer :+1:
This way the renderer won't do anything with maths-environments (which is honestly preferable, given the "confusing" behavior of kramdown where it will convert the $$...$$ differently depending on context).

Another rendering issue that arises:

Using kramdown, \\ at the end of a line as used in \begin{align} ... \end{align}, is correctly not escaped.
Using commonmark, \\ at the end of a line as used in \begin{align} ... \end{align}, is escaped, thus leading to \ instead.

Essentially none of the renders does exactly what we want, but the union of the their features would have been perfect..
Anyways, this I just fixed by replacing \\ at the end of a line in the markdown output. It's not perfect, e.g. \begin{align} a \\ b \end{align} will not be replaced accordingly, but at this point I don't care anymore:) On the bright side it forces the tutorial writer to format their latex nicely!
One question though: should we maybe instead overload https://github.com/JunoLab/Weave.jl/blob/b5ba227e757520f389a6d6e0f2cacb731eab8b12/src/WeaveMarkdown/markdown.jl#L8-L17 and do the replace call there? This would ensure that we only perform replacements inside of latex-blocks.

I've now made it so that each tutorial has it's own directory, thus allowing deps to be specified for each tutorial + it's not always that it makes sense with the previous categorisation. All of this requires some changes to Turing/docs/make.jl of course but minor ones.
The final part is to ensure that gif's are handled correctly. At the moment, only PNGs works. I'll have another look later this week unless someone else figures this out before me :+1:

Here's the branch of Turing I'm using to copy the docs over from local TuringTutorials: https://github.com/TuringLang/Turing.jl/tree/tor/doc-updates

One question though: should we maybe instead overload<EMAIL_ADDRESS>and do the replace call there?

That would yield an additional "Method overwritten" warning? Or do you propose to make a PR to Weave?

It would, but what is two warnings to a program which already has one warning? :upside_down_face:
I'm not sure how I'd turn it into a PR for Weave. Ideally you'd be able to dispatch differently for the markdown-parsing based on the format used, e.g. GithubMarkdown. But unclear to me how you'd go about doing that (other than copy-pasting everything from Markdown and adding another thing to dispatch on).

Are the gif's still problematic?

Yeah. In the current setup, we generate folders for each tutorial which contains the files. With the current weave-setup we put all the files in a figures folder. Having thought about it I think it's best to just stick with the current approach (one folder for files related to each tutorial) which is also possible with weave. But for non-png related files, we have to save by hand, e.g.
anim = @animate for i = 1:n
    # ...
end

together with
fname = "anim.gif"
fpath = joinpath(WEAVE[:fig_path], fname)
savefig(fpath, anim)
fpath

with chunk-options (http://weavejl.mpastell.com/stable/chunk_options/#Weave-Chunk-Options) echo = false, results = "markup". I haven't tried this, but hopefully something like this ought to do the trick. Though it's annoying...
Also, I think I forgot to push some of my local changes which are on my computer back in Cambridge (I'm back home in Norway atm). It was only stuff to flatten the project-structure, but still.

Sounds like this should be fixed upstream... Maybe one could add a dispatch here https://github.com/JunoLab/Weave.jl/blob/c9fc740d72dbbd2f0b950f98efedc5ab71f17e3e/src/WeaveMarkdown/html.jl#L23-L44, similar to https://github.com/JunoLab/Weave.jl/blob/c9fc740d72dbbd2f0b950f98efedc5ab71f17e3e/src/plots.jl#L94-L110

Yeah, looks like you're right. I'll have a look.

Actually, is it just a matter of adding a method like https://github.com/JunoLab/Weave.jl/blob/c9fc740d72dbbd2f0b950f98efedc5ab71f17e3e/src/plots.jl#L89-L91 for MIME"image/gif"?

I thought not, since when I generated the webpage I ended up with outputs like "Plots.AnimatedPlot....". Therefore I assumed that just the type is printed when converting to markdown instead of adding the  tag, as implemented in the plots.jl file linked above. But maybe I'm wrong.

Hey I thought it would be good to revive this issue as it is obviously very needed :D
@torfjelde What still needs to be done?

Maybe we should run Pkg.status() at the beginning or end of every notebook too, so that people can view the dependencies.

That's how it is done in SciML: SciML/SciMLTutorials.jl An appendix is added automatically to every tutorial which shows the packages and Julia version that was used to run it

To bounce back on this, we could add a little warning at the beginning of each tutorial saying "Check that you are using the correct version of Turing for this tutorial (see end of Tutorial), if it does not work with the latest version of Turing please open an issue"

Sorry, I haven't been looking at this for ages now. It first got postponed because the computer I had access to here back in Norway had very limited RAM, and so it was a hassle to do any development on this. Got an upgrade recently though, so I'll have a look again :+1:

Hey I thought it would be good to revive this issue as it is obviously very needed :D
@torfjelde What still needs to be done?

If I remember correctly, the following issues remain:

How do we deal with plots? See the last couple of comments above.
Need to flatten the project-structure, which I already did but then left those changes in Cambridge :upside_down_face:

But I figured out a fix to (1) this morning, so now I'll address (2) and try to generate everything; hopefully I'll have a working PR today!

By the way, why don't we use Literate.jl instead of Weave.jl, Literate handles plots nicely I think.

Hey @theogf! Yeah you, you who are now suggesting that we use Literate.jl instead of Weave.jl after I've gone through hell to get this stuff working.

Hahaha can't argue with that! :laughing::laughing::laughing: (although it would be easier to switch now :eyes: )
More seriously can I help you with the branch? Is there something to modify on each tutorial?

No but on a serious note, Weave.jl handles plots nicely too. But Weave.jl respects the MIME-type, and that is messed up for gifs for some reason, and so Weave.jl treats it as text rather than a file.
And more generally, I think both Weave.jl and Literate.jl are very much the same when it comes to features but Weave.jl is more mature, is under JunoLabs and thus we'd expect it to me maintained, and finally, and this is the main reason why we went with Weave.jl in the first place, jmd is a super-straightforward conversion from our current setup since we can just take the markdown files and convert to jmd while Literate.jl is a completely different approach AFAIK.

More seriously can I help you with the branch? Is there something to modify on each tutorial?

So right now I think the PRs https://github.com/TuringLang/TuringTutorials/pull/102 and https://github.com/TuringLang/TuringTutorials/pull/103 should be good to get things working. The next step is to make sure that everything renders correctly on the website (@cpfiffer pls halp). I have a working branch of Turing that manages to do this locally, but need to ensure that this is also the case for the actual website.
After all that, I think we should really just go through the tutorials to:

Update dependencies.
Make sure everything is working correctly.

Oh ok so the idea is to work on jmd-staging until everything is ready and then push to master.

Exactly :+1:

Plus the changes need to happen elsewhere.

So the only thing that remains now is making sure that all tutorials actually work. There are some that are just failing, e.g. regression tutorial fails because of https://github.com/JuliaStats/RDatasets.jl/issues/117. I'll go through, fix the ones I can and list the ones that are still todo, then I'll make another PR.

I will make a new PR for the BNN tutorial (I will try to include GPU support for vi this time)

Another issue I'm currently running into is that the footer thingy we have at the end of the tutorials suddenly stopped working. When I do:
julia --project -e "using TuringTutorials; TuringTutorials.weave_folder(\"00-introduction\", (:github, ))"

it complains that TuringTutorials is not available which it clearly is, unless Weave is now evaluating in the file in a different scope? If so, no one sent me that memo!

So seems like it actually does: https://github.com/JunoLab/Weave.jl/blob/196d4ca7ce80e65f7365642218c43a8c94d5f286/src/run.jl#L41-L42.
But how about changing
using TuringTutorials
TuringTutorials.tutorial_footer(WEAVE_ARGS[:folder],WEAVE_ARGS[:file])

to
isdefined(Main, :TuringTutorials) && Main.TuringTutorials.tutorial_footer(WEAVE_ARGS[:folder],WEAVE_ARGS[:file])

?
This way one can still weave the files "outside" of TuringTutorials, but it will do the right thing if TuringTutorials is exposed in Main.

Yeah, I love it!

Wow, I don't think I've ever seen anyone that enthusiastic about changing footers before! I guess it makes sense, eh Mr. Footman?
Anyways, things are running fine now. Just waiting for the diff-eq tutorial to finish bobbing and weaving then I'll make a PR with the generated markdown files?

Getting there: https://github.com/TuringLang/TuringTutorials/pull/105 and https://github.com/TuringLang/TuringTutorials/pull/106.
Is there anything else that needs to be done?

Could you maybe have a check that everything is fine @cpfiffer ? Just checkout the tor/doc-updates branch for Turing.jl and do ] add TuringTutorials#jmd-staging to docs, then it should just work.

Don't need to check every tutorial, but mainly that the setup makes sense

Looks fine to me. We can test it live by pushing the jmd-staging branch and then switching over from TuringLang/turing.ml, where the site currently lives. It'll be a good way to check to see if the site builds correctly without having to keep the site live if something is off.

Sounds good!

Aight, so now it's ready to go!
Need to merge https://github.com/TuringLang/TuringTutorials/pull/109 and then https://github.com/TuringLang/TuringTutorials/pull/111 for TuringTutorials, and then finally https://github.com/TuringLang/turing.ml/pull/7 over at turing.ml.

Is there anything remaining for us to completely move over to jmd staging at this point?
AFAIK the only thing that's left-over is fixing the maths in the non-tutorial sections over at https://github.com/TuringLang/turing.ml/. Once that's done, do we just deploy to /dev?

Yeah, that sounds about right. I'll try to fit in the time this week to get the turing.ml stuff ready to go.

Hey there, I have started to make some changes to the HMM Tutorial, addressing some of the issues around it. How do you re-create the markdown files after changing the jmd files?
I have based the work off the jmd-staging branch here, hope that's all right. I thought that should be fairly up-to-date.


[SPARK-31055][DOCS] Update config docs for shuffle local host reads to have dep on external shuffle service

What changes were proposed in this pull request?

with SPARK-27651 we now support host local reads for shuffle, but only when external shuffle service is enabled. Update the config docs to state that.
Why are the changes needed?

clarify dependency
Does this PR introduce any user-facing change?

no
How was this patch tested?

n/a

@attilapiros

Test build #119402 has started for PR 27812 at commit 33b1ff4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24139/
Test PASSed.

Test build #119402 has finished for PR 27812 at commit 33b1ff4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119402/
Test PASSed.

Test build #119421 has finished for PR 27812 at commit 8767795.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119421/
Test PASSed.

@dongjoon-hyun @HyukjinKwon if you have time for a quick review


Create a SAM template with Powertools support bake in

Is your feature request related to a problem? Please describe.

No
Describe the solution you'd like

I'd like to use 'sam init' to create a java project which comes with Powertools included.
Describe alternatives you've considered

Maybe it should live in the SAM project? I think it would also do well here so it can be maintained in the same release cycles.
Additional context

An example would be the Python SAM template - https://github.com/aws-samples/cookiecutter-aws-sam-python

Hey @msailes do we want a cookiecutter or a maven archetype?

A SAM cookiecutter would be best to start with. But I'd definitely take a maven archetype as well!

@msailes would this be possible just extracting the example/ directory from this repository and make a cookie cutter out of it?

@msailes would this be possible just extracting the example/ directory from this repository and make a cookie cutter out of it?

@vitodegiosa Yes that could be used as a starting point. But it will require some cleaning on terms of removing some of the extra logic and probably having separate cookie cutter project with maven and gradle

@msailes would this be possible just extracting the example/ directory from this repository and make a cookie cutter out of it?

@vitodegiosa Yes that could be used as a starting point. But it will require some cleaning on terms of removing some of the extra logic and probably having separate cookie cutter project with maven and gradle

@pankajagrawal16 I have something ready to go. Single cookie cutter project with possibility to select maven or gradle for dependency management and including only core utilities (metrics, logging, tracing). Should I create a new repo in awslabs? Should we agree on the name of the repo? cookiecutter-aws-sam-powertools-java? Too long?

@vitodegiosa Great to hear. I would recommend putting in aws-samples instead along with other cookiecutter templates ?

When it comes to naming, I am quite ok with long names as well, as long as it follows similar naming convention like others. Finally it will be replaced with names customers choose anyways during sam init. What do you think ? @vitodegiosa

done https://github.com/aws-samples/cookiecutter-aws-sam-powertools-java

Thanks for the contribution again @vitodegiosa 🙌


Add macOS Deployment Target.

Fix "Module file's minimum deployment target is OS X v10.13".

Ah, can't believe I missed that. Thanks!


Docs - add feature docs explaining how to use the library

Closes #4

@tomkerkhove , is there something wrong with the docs? Like, a syntax error or so? Or is it bc there's no pre-section with --- style: default ---?

Can you:

Configure the sidebar navigation?

Added a link here.

Move it from preview to the final docs for now since it's our first version?

Hmm, it's placed under ./docs/preview bc it's not yet fully released yet, not bc it is the first version.

Move README.md to Home.md

Yes, renamed that.

Move it from preview to the final docs for now since it's our first version?

Hmm, it's placed under ./docs/preview bc it's not yet fully released yet, not bc it is the first version.

Problem is that it won't work with this model of docs as it's not using the same approach as with Arcus (see preview)

Move it from preview to the final docs for now since it's our first version?

Hmm, it's placed under ./docs/preview bc it's not yet fully released yet, not bc it is the first version.

Problem is that it won't work with this model of docs as it's not using the same approach as with Arcus (see preview)

Ok, done that.

Nitpick but let's use logic-app in URLs rather than logicapp to make it more readable since they are two separate words


Update Sentry.FinchClient

Just some totally optional changes. Also, just wanted to say I really enjoyed the latest blog post on sentry+finch and the project as a whole looks super interesting too, cheers! :D

Hey @wojtekmach thank you!
I'll revise the blog post as this is a much nicer implementation.


Error while setting up tapo

Hi, I am getting this in logs:
Logger: homeassistant.components.switch
Source: custom_components/tapo/switch.py:40
Integration: Switch (documentation, issues)
First occurred: 4:52:27 AM (2 occurrences)
Last logged: 4:52:27 AM
Error while setting up tapo platform for switch
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 289, in _async_setup_platform
await asyncio.shield(task)
File "/config/custom_components/tapo/switch.py", line 24, in async_setup_entry
_setup_from_coordinator(coordinator, async_add_devices)
File "/config/custom_components/tapo/switch.py", line 40, in _setup_from_coordinator
if coordinator.data.model.lower() in SUPPORTED_DEVICE_AS_SWITCH:
AttributeError: 'NoneType' object has no attribute 'model'

Version 1.6.1 should fix this issue or log more detailed error


Add metric owner of Burrow in label

This metric that return in the endpoint of burrow, show the consumer owner of Partition of each topic.
The metric appear like this in the label:
(...){(...), owner="/<IP_ADDRESS>", (...)}

@shamil you review this MR?


Checkered background for transparent images in image viewer

So, I get why, but I don't know, I really like that it keeps the transparent backgrounds transparent. It's like a good use case for actually having a transparent background.

@YaManicKill, thoughts?

@astorije Keep in mind that black images on transparent background do not show up at all in the image viewer.

Yeah, so @xPaw just shared https://openclipart.org/image/2400px/svg_to_png/151735/1311627658.png with me on IRC and in this case, yeah, it feels like we have to do that.
Ah, too bad, I did like quite a lot the black background :man_shrugging:


refactor: simpler import from fs/promises

Types of changes

[ ] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

node v14 added a simpler import path for fs promises: fs/promises
Checklist:

[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly. (PR: #)
[x] I have added tests to cover my changes (if not applicable, please state why)
[x] All new and existing tests are passing.

Codecov Report
Base: 66.25% // Head: 66.25% // No change to project coverage :thumbsup:

Coverage data is based on head (946ae4b) compared to base (d48efa6).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x   #10877   +/-   ##
=======================================
  Coverage   66.25%   66.25%
=======================================
  Files          93       93
  Lines        4090     4090
  Branches     1156     1156
=======================================
  Hits         2710     2710
  Misses       1115     1115
  Partials      265      265

Flag
Coverage Δ

unittests
66.25% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

packages/cli/src/utils/serve.js
72.41% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

This reduces node.js support. i don't think is necessary for Nuxt 2...

We have already dropped support for versions of Node before 14 with some of our other dependencies.


Playback failed on jioTV

Environment

Add-on name: Jiotv
Add-on version: 2.0.0
Kodi version: e.g. Kodi 19
Operating system version/name : LibreElec

It was working after logging in again

I have the same problem I have to re-login every 15 or 30 days later
did that happen to you just once or is it still happening?? @dgbkn


java.io.EOFException: Unexpected end of ZLIB input stream

Hi there
Got this exception with ZIP files created in macos. Successful unzip it in android shell without any errors.
W/System.err: net.lingala.zip4j.exception.ZipException: java.io.EOFException: Unexpected end of ZLIB input stream
W/System.err: Caused by: java.io.EOFException: Unexpected end of ZLIB input stream
W/System.err:     at
W/System.err:     at net.lingala.zip4j.tasks.AsyncZipTask.execute(AsyncZipTask.java:36)
W/System.err:     at net.lingala.zip4j.ZipFile.extractAll(ZipFile.java:437)

Do you get this issue on an Android? If yes, can you specify which version you of Android you see this issue on? There were some previous issues reported on Android version 4.4, which had something to do with an issue on that version of Android.

Yes, Android 6.0
I created used old method for unzip it and it works -
`    @Throws(IOException::class)
fun unzip(zipFile: File, targetDirectory: File) {
val zis = ZipInputStream(BufferedInputStream(FileInputStream(zipFile)))
try {
var ze: ZipEntry?
var count: Int
val buffer = ByteArray(8192)
while (true) {
ze = zis.nextEntry
if (ze == null) break
            val file = File(targetDirectory, ze.name)
            val dir = if (ze.isDirectory) file else file.parentFile
            if (!dir.isDirectory && !dir.mkdirs())
                throw FileNotFoundException("Failed to ensure directory: " + dir.absolutePath)
            if (ze.isDirectory)
                continue
            val fout = FileOutputStream(file)
            fout.use { fout ->
                while (true) {
                    count = zis.read(buffer)
                    if (count == -1) break
                    fout.write(buffer, 0, count)
                }
            }
        }
    } finally {
        zis.close()
    }
}`

Can you send me a sample zip file?

Also please post the code you used. I am not an Android guy, I hope I can figure out a way to reproduce the, especially that you say that it works fine in Android shell.

Can you try with the latest v2.2.6? There is a bug fix done which might be related to this issue.

Closing issue as there is no further feedback on this.


Disable build tests by default in CMake and enable them in make file

This PR disable tests in the CMakeLists.txt and enable them in the Makefile with the option JSON11_BUILD_TESTS .
This will make the integration of json11 on other projects with CMake easier, especially on iOS, since it crashes it the tests are enabled.
http://stackoverflow.com/questions/37880180/error-creating-ios-static-library-using-cmake

Automated message from Dropbox CLA bot
@4brunu, it looks like you've already signed the Dropbox CLA. Thanks!

@artwyman  I reverted the Makefile as you suggested. If you have any more suggestions please let me know.


VP: future development

VP potential future development ideas:

Add the ClinVar ID when available (and link) ... see screenshot 1 for an example of where this link should be (under the allele registry link).
MANE transcripts v2 (support filtering on all MANE transcripts, see https://github.com/ClinGen/clincoded/issues/2257 for mockups).
Add LOVD data and  filter (from Sharon)
Allow users to filter across any subpopulation from a single filter (ie. select for ANY gnomAD subpopulation that meets certain criteria or popMax) (from Deb)
Suggestion is to nest the Population filters in the "add filter" modal so users first select "gnomAD v[x] population" and then can select their subpopulation(s). (from Deb)
Enable the VP to replace the current Variant Prioritization reports sent to VCEPs and the "curating ClinVar" project
Add BayesDel (Request from Melissa for BRCA exchange)

Decided at 7/1/21 meeting: Monthly data updates are OK for launch, weekly or real-time is ideal.
VP user interview feedback is being collected here:
https://docs.google.com/document/d/127YxDpWoG0IvDZJNDx0W2f0TH_UX9S5P-nUImdaB5SI/edit?usp=sharing


Introducing friendlier API for retrieving validation errors

As mentioned in issue #249 the API for retrieving validation errors is rather cumbersome.
To solve this problem I've introduced a new req.getValidationErrors() method which is async by default and returns errors as part of the promise resolution. This makes it easier to write readable code, especially when coupled with generators, and keeps code consistent when switching between sync/async.
For example, using generators with the new method code is now written as such:
var errors = yield req.getValidationErrors();

if (errors) {
  res.send('There were errors');
} else {
  res.send('All is well');
}

Wow, amazing work!
I will later review it with more attention.
At a first glance, I think this could be the start of v3.0.0.


Scroll down issue

When testing with some customized codes, speedcoder scrolls the window, but sometimes the window scrolls down so fast that we cannot see the line we are typing.

this is fixed now. please check.
There should be no problem if the code is less than 350 lines.


ADD: Adding new aerosol dataset for testing for piecharts and percentages.

thanks @zssherman - looks good to me!


Remove RuntimeDirectory from osbuild-composer.service

This line
https://github.com/osbuild/osbuild-composer/blob/859bc0ad2ed8814fa7ca42c79f93e4b22a09d87f/distribution/osbuild-composer.service#L9
can be safely removed if /run/osbuild-composer and /run/weldr contain only the sockets from osbuild-composer.socket
Is it the case @larskarlitski, @teg ?

Discussed this in chat. RuntimeDirectory can be removed for now.


Diamond shape

Adds support for diamond shape.

 :) Thanks for the great library! :+1:

:)
btw. I found out that drawing square on rotated canvas takes about the same time but is a little less code:
canvas.save();
canvas.rotate(45, rawX, rawY);
canvas.drawRect(rawX - pointRadius, rawY - pointRadius, rawX + pointRadius, rawY + pointRadius, pointPaint);
canvas.restore();

Nice! :D


ID-79

onboarding page: once user  submit the form then it will goto the main

No need to have ... email and mobile


Improve the Chinese Readme to synchronize with the English Readme.

The Chinese Readme is incomplete and contains some grammar errors. I have modified some sentences and supplemented the missing parts by referring to the English Readme.
Change the prompt in the code to English, as the Mistral in the example does not support Chinese.

Thank you! We do not speak Chinese so we used the translator


Add example of self disabling button while server processes click event

How to get a callback from server once server responded on a button click

This question has been asked so many times. We need to add an example of such button to this project.
https://github.com/Starcounter/Starcounter/issues/3858#issuecomment-251078202

@Joltrix please take this issue when you get tired/border by other projects.

@miyconst Is this okay?
I added "an extra button" with a delay, just to kinda display (slower) what's happening. Because the server responds to fast sometimes, so it feels like nothing happened.
And is the "text" okay? Or do you want me to provide more information about how it works? (I tried to keep it as short as possible, to make it similar to the other "entrys"

Looks good to me, except the float: leftstyles. Can you style it with flex or make one button on a line?

Okay, will try to fix it :)

Fixed in StarcounterSamples/KitchenSink/0ab4415

Thanks @Joltrix, merged. Now you can remove the branch.


0.8.2 breaks Nissan Leaf (no longer recognized)

Describe the bug
After installing 0.8.2 and ensuring Community Features is enabled, OpenPilot no longer properly recognizes my 2018 Nissan Leaf, and goes into dashcam-only mode.
How to reproduce or log data

Install 0.8.2
Enable Community Features
Try to use on a 2018 Nissan Leaf.

Expected behavior
In 0.8.1 it worked fine.
Device/Version information (please complete the following information):

Comma 2
Dongle ID: e4d79cf6b8b19a0d
Route: e4d79cf6b8b19a0d|2021-02-28--08-56-44
Timestamp: Whole time
Version: 0.8.2
Car make/model: 2018 Nissan Leaf

Small update after some testing - the issue has been narrowed down to the new CAR.LEAF_IC fingerprints. Removing the first first  CAR.LEAF_IC fingerprint from /selfdrive/car/nissan/values.py makes my 2018 Nissan Leaf come out of dashcam mode.

From discord, this is the fingerprint that @willemcvu has collected from his leaf
2: 5, 42: 6, 264: 3, 361: 8, 372: 8, 384: 8, 389: 8, 403: 8, 459: 7, 460: 4, 470: 8, 520: 1, 569: 8, 581: 8, 634: 7, 640: 8, 644: 8, 645: 8, 646: 5, 658: 8, 682: 8, 683: 8, 689: 8, 724: 6, 758: 3, 761: 2, 783: 3, 852: 8, 853: 8, 856: 8, 861: 8, 944: 1, 976: 6, 1008: 7, 1011: 7, 1057: 3, 1227: 8, 1228: 8, 1261: 5, 1342: 1, 1354: 8, 1361: 8, 1459: 8, 1477: 8, 1497: 3, 1549: 8, 1573: 6

Merging the two LEAF_IC fingerprints doesn't fix @willemcvu's case. Since this was a regression for an existing supported car, we'll remove the new, conflicting fingerprint, which I believe is @razem-io's. This specific case can be fixed by finding an alternate seatbelt signal so that we can merge the LEAF and LEAF_IC cars. The longer term fix is to get firmware fingerprinting support for Nissan. Perhaps you're interested in this, @avolmensky? Here's a recent PR for VW firmware fingerprinting as an example.

Sure, I will just use my fork in the meantime. I am pretty sure that there is no other seatbelt signal. A friend and I did alot of tests to check every signal for correlation programmatically. We did not find anything else.

Can someone explain to a Noob such as myself how I can go about getting my Comma Two functioning again on my LEAF Plus?  I am stuck in dashcam mode and am not sure of how to edit fingerprints, or anything like that.  In need of a YouTube walk through if possible!

Removed the conflicting fingeprint in 90d6bcc8e9fdb12116c1dbd30af2514f514e4e4b.
@razem-io we could also merge the two if we had a signal to differentiate them. maybe there's a unique CAN message only for the IC model? You could also give implementing firmware fingerprinting a shot. That shouldn't be too hard and would benefit Nissan support in openpilot as a whole.

Fingerprinting V2 is currently being tested here: https://github.com/razem-io/openpilot/tree/nissan-fpv2-0.8.6


Update CI to test pysynphot_etc

Updating CI workflow for fork.  I removed the workflow for pushing to pypi, since we don't plan on having public releases.  I was also testing whether or not I needed to update the CI workflow for the new project name, but it was not necessary.  The last change was a change to the project settings (so you won't see it in "Files changed") to add a codecov token.  So once this PR is merged, there will be a codecov report for the fork.

There's still CI usage.  You can see the test report in the "Checks" tab above.  Part of this PR was to test and make sure that the testing was still happening in the fork, and it is.


Update index.md

there is 6 instance of hackingesports in the list

@onixldlc That's awesome thats for cleaning it up -- but it's actually a bug. Do you think you want to try to squash it?
My suspicion is that because the list contains both hackingesports and hackingesports_eng and there's a bug somewhere in  GetTwoWeekStreamActivity.py#L61-L70 -- it's causing hackingesports to be duplicate when the automation runs every eight hours.


Redirected to login page. Use --login.

HTTP redirect from https://www.instagram.com/explore/tags/motorcyclephotos/ to https://www.instagram.com/accounts/login/
Get hashtag #motorcyclephotos: Redirected to login page. Use --login.
Errors or warnings occurred:
Get hashtag #motorcyclephotos: Redirected to login page. Use --login.
After downloading so much photos i got this error. İ logined it won't working.

I just started using this library recently but I'm getting the same error message. I successfully logged in already but keep getting this error:
raise LoginRequiredException("Redirected to login page. Use --login.")
instaloader.exceptions.LoginRequiredException: Redirected to login page. Use --login.

I just started using this library recently but I'm getting the same error message. I successfully logged in already but keep getting this error:
raise LoginRequiredException("Redirected to login page. Use --login.")
instaloader.exceptions.LoginRequiredException: Redirected to login page. Use --login.

I was able to get Hashtags by logging in and using load_session_from_file(MYUSERNAME) prior to fetching any hashtags.

I was able to get Hashtags by logging in and using load_session_from_file(MYUSERNAME) prior to fetching any hashtags.

Welcome to the community! Please see Reporting Bugs for how to report a bug. There is little chance to understand an issue if the requested information is missing.

Welcome to the community! Please see Reporting Bugs for how to report a bug. There is little chance to understand an issue if the requested information is missing.

Also in my case if I try to download without the login it gives me an error but if I use the login it works perfectly.
i tried to upgrade instaloader but nothing has changed.

Also in my case if I try to download without the login it gives me an error but if I use the login it works perfectly.
i tried to upgrade instaloader but nothing has changed.

Any other way to get the hashtags without login > 🗡

me too


🐞 Bug: Clicking 'Update Project' button displays 404 Not Found screen

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
After clearing the name input and pressing 'Update Project,' an error message appears. And after that we again press "Update Project" button then 404 not found screen shows up.
Video of Bug:
https://github.com/CircuitVerse/CircuitVerse/assets/77102885/374e7920-a85b-4f19-936b-33ea169ec228
Steps To Reproduce

Go to https://circuitverse.org/simulator (After login)
Save the Project .
In Edit Project page , clear the Name input field .
Press "Update Project" button.(A error message will appear)
Then press again "Update Project" button.
See the error that 404 not found screen appears

Expected Behavior
After pressing 'Update Project,' it should display an error message instead of going to the 404 Not Found screen.
Screenshots
NA
Device Information [optional]
- OS:
- Browser:
- version:

Additional context
NA
Are you working on this issue?
Yes

please assign me this issue

Hey @tanmoysrt can i work on this issue

Hello @tanmoysrt can you please confirm if @shauryag2002 is still working on it?

Hey @tanmoysrt , need your help! So, when I hit 'Update Project' with an empty project name, it just kicks me back to the same URL without the '/edit' part. Any ideas on how to make it stay there when an error pops up?

Hello, if this issue is not being worked upon by anyone, I would like to take this up.

Hi @shauryag2002 I am working on this as it's been more than a month now


Improve access logging

Use Cases

[ ] Customize access log format per service (some custom format or JSON for example, liquid templating).
[x] Ability to disable access log conditionally per service. (https://github.com/3scale/apicast/pull/856)
[x] Ship logs to syslog. (https://github.com/3scale/apicast/pull/858)
[x] Configure location of the access log file (for native deployments). (closes https://github.com/3scale/apicast/issues/650)

Details
access_log directive offers if to enable/disable logging by setting a variable to 0/1 - this can be used to enable/disable logging by a policy.
It is possible the path parameter of the access_log directive can be a variable too and can be controlled from within a policy. Then we should consider using open_log_file_cache  to files opened.
Syslog can be either achieved by setting syslog: path to the access_log directive, or we have to reuse https://github.com/nmasse-itix/apicast-logger to offer syslog from a policy.
Custom formats can be defined by log_format directive pointing just to a variable that is later populated by a policy.

@mikz looks like this would cover https://github.com/3scale/apicast/issues/650 as well?  ("Configure location of the access log file (for native deployments)." part)

@mayorova Indeed.

Conclusion from my research:

syslog has to be set when the gateway starts and is global for all services. So it either logs to a file (stdout) or syslog.

Logging format can be customized, but it is pretty unpredictable because of nginx escaping the result. This can be turned off in nginx 1.13.10 but we have 1.13.6. We would have to wait for next OpenResty release to properly support this.

We can enable/disable logging per service easily.

So, regarding the format, we decided to wait for the next release of OpenResty (see @mikz comment above). Enabling/Disabling the service can be done with the policy introduced in #856 , and APIcast can be configured to log to syslog using an ENV.
I think there's nothing else we need to do for 2.3, so I'll remove this issue from the milestone. cc/ @andreumasferrer

ACK. Will update THREESCALE-1148 accordingly.

hi @mikz  Is it possible to expect this feature as a policy?

Done in https://github.com/3scale/APIcast/pull/1089


ILoggerStructure should not have a Format method

The purpose of the interface is not to string-ify the object... That's what the Func<object,exception,string> formatter is for.

Fixed already: https://github.com/aspnet/Logging/pull/167


"vision_msgs" not find

The first compilation showed that autorccar_interfaces did not exist. Based on the issue, I downloaded autorccar_interfaces from your autoRCcar_indoor main project, placed it in the src directory of my workspace, and recompiled it
The second compilation shows a missing vision_msgs file, as follows:
Starting >>> autorccar_interfaces
Starting >>> lio_sam
--- stderr: autorccar_interfaces
CMake Error at CMakeLists.txt:13 (find_package):
By not providing "Findvision_msgs.cmake" in CMAKE_MODULE_PATH this project
has asked CMake to find a package configuration file provided by
"vision_msgs", but CMake did not find one.
Could not find a package configuration file provided by "vision_msgs" with
any of the following names:
vision_msgsConfig.cmake
vision_msgs-config.cmake

Add the installation prefix of "vision_msgs" to CMAKE_PREFIX_PATH or set
"vision_msgs_DIR" to a directory containing one of the above files.  If
"vision_msgs" provides a separate development package or SDK, be sure it
has been installed.

Failed   <<< autorccar_interfaces [4.46s, exited with code 1]
Aborted  <<< lio_sam [10.9s]
Summary: 0 packages finished [14.7s]
1 package failed: autorccar_interfaces
1 package aborted: lio_sam
2 packages had stderr output: autorccar_interfaces lio_sam

The first compilation showed that autorccar_interfaces did not exist. Based on the issue, I downloaded autorccar_interfaces from your autoRCcar_indoor main project, placed it in the src directory of my workspace, and recompiled it The second compilation shows a missing vision_msgs file, as follows:
Starting >>> autorccar_interfaces Starting >>> lio_sam --- stderr: autorccar_interfaces CMake Error at CMakeLists.txt:13 (find_package): By not providing "Findvision_msgs.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "vision_msgs", but CMake did not find one.
Could not find a package configuration file provided by "vision_msgs" with any of the following names:
vision_msgsConfig.cmake
vision_msgs-config.cmake

Add the installation prefix of "vision_msgs" to CMAKE_PREFIX_PATH or set "vision_msgs_DIR" to a directory containing one of the above files. If "vision_msgs" provides a separate development package or SDK, be sure it has been installed.
Failed <<< autorccar_interfaces [4.46s, exited with code 1] Aborted <<< lio_sam [10.9s]
Summary: 0 packages finished [14.7s] 1 package failed: autorccar_interfaces 1 package aborted: lio_sam 2 packages had stderr output: autorccar_interfaces lio_sam

Hello, now the latest situation is that I first colcon build autorccar_interfaces, which can be successfully compiled. However, after adding LIO-SAM_MID360_ROS2 to the workspace and then performing colcon build, there will still be an error that "autorccar_interfaces" cannot be found, as follows:
Starting >>> autorccar_interfaces
Starting >>> lio_sam
Finished <<< autorccar_interfaces [0.81s]
--- stderr: lio_sam
** WARNING ** io features related to pcap will be disabled
CMake Error at CMakeLists.txt:31 (find_package):
By not providing "Findautorccar_interfaces.cmake" in CMAKE_MODULE_PATH this
project has asked CMake to find a package configuration file provided by
"autorccar_interfaces", but CMake did not find one.
Could not find a package configuration file provided by
"autorccar_interfaces" with any of the following names:
autorccar_interfacesConfig.cmake
autorccar_interfaces-config.cmake

Add the installation prefix of "autorccar_interfaces" to CMAKE_PREFIX_PATH
or set "autorccar_interfaces_DIR" to a directory containing one of the
above files.  If "autorccar_interfaces" provides a separate development
package or SDK, be sure it has been installed.

Failed   <<< lio_sam [3.93s, exited with code 1]
Summary: 1 package finished [4.19s]
1 package failed: lio_sam
1 package had stderr output: lio_sam

The first compilation showed that autorccar_interfaces did not exist. Based on the issue, I downloaded autorccar_interfaces from your autoRCcar_indoor main project, placed it in the src directory of my workspace, and recompiled it The second compilation shows a missing vision_msgs file, as follows:
Starting >>> autorccar_interfaces Starting >>> lio_sam --- stderr: autorccar_interfaces CMake Error at CMakeLists.txt:13 (find_package): By not providing "Findvision_msgs.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "vision_msgs", but CMake did not find one.
Could not find a package configuration file provided by "vision_msgs" with any of the following names:
vision_msgsConfig.cmake
vision_msgs-config.cmake

Add the installation prefix of "vision_msgs" to CMAKE_PREFIX_PATH or set "vision_msgs_DIR" to a directory containing one of the above files. If "vision_msgs" provides a separate development package or SDK, be sure it has been installed.
Failed <<< autorccar_interfaces [4.46s, exited with code 1] Aborted <<< lio_sam [10.9s]
Summary: 0 packages finished [14.7s] 1 package failed: autorccar_interfaces 1 package aborted: lio_sam 2 packages had stderr output: autorccar_interfaces lio_sam

Hello, now the latest situation is that I first colcon build autorccar_interfaces, which can be successfully compiled. However, after adding LIO-SAM_MID360_ROS2 to the workspace and then performing colcon build, there will still be an error that "autorccar_interfaces" cannot be found, as follows: Starting >>> autorccar_interfaces Starting >>> lio_sam Finished <<< autorccar_interfaces [0.81s] --- stderr: lio_sam ** WARNING ** io features related to pcap will be disabled CMake Error at CMakeLists.txt:31 (find_package): By not providing "Findautorccar_interfaces.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "autorccar_interfaces", but CMake did not find one.
Could not find a package configuration file provided by "autorccar_interfaces" with any of the following names:
autorccar_interfacesConfig.cmake
autorccar_interfaces-config.cmake

Add the installation prefix of "autorccar_interfaces" to CMAKE_PREFIX_PATH or set "autorccar_interfaces_DIR" to a directory containing one of the above files. If "autorccar_interfaces" provides a separate development package or SDK, be sure it has been installed.
Failed <<< lio_sam [3.93s, exited with code 1]
Summary: 1 package finished [4.19s] 1 package failed: lio_sam 1 package had stderr output: lio_sam

In the case of no, the header file contains
include <pcl_conversions/pcl_conversions.h>, but the file or directory cannot be found

Hello, @makanov001
I have fixed the errors and created a new repository with all the necessary packages for execution
Try using the following repository.
https://github.com/UV-Lab/LIO-SAM_MID360_ROS2_PKG


Use getBoundingClientRect to get element's offset

Atm you ask for .offsetLeft and .offsetTop on each parent element, which each triggers a reflow and leads to layout thrashing. When switching to .getBoundingClientRect() you minimize the amount to a single reflow.
(https://gist.github.com/paulirish/5d52fb081b3570c81e3a)

Sounds like a good catch. Thanks! I'll definently take a look.

@herschel666 I just remembered why I used offsetTop and offsetLeft here. The difference is that getBoundingClientRect return values that take into consideration elements transforms. And what I actually need here is to check elements' positions like there is no transform applied yet.
I didn't want to calculate elements positions and then apply initial state (before animation) to them, in order to keep it as simple as possible I set initial state right in CSS. And because of that I needed a solution to calculate proper offsets and make sure that they are not impacted by initial transforms.
And this function makes it perfect:
var offset = function(el) {
    var _x = 0;
    var _y = 0;

    while (el && !isNaN(el.offsetLeft) && !isNaN(el.offsetTop)) {
        _x += el.offsetLeft - (el.tagName != 'BODY' ? el.scrollLeft : 0);
        _y += el.offsetTop - (el.tagName != 'BODY' ? el.scrollTop : 0);
        el = el.offsetParent;
    }

    return {
        top: _y,
        left: _x
    };
};

Unfortunately I don't see a possibility to change offsets to getBoundingClientRect() as this will cause behavioral issues.
Thank you for your contribution!


Turn off Github Actions for project forks

What happened:

Done! I've changed the project settings to enable actions only for this repository.

@nfnt thanks for the quick fix 😄

Have to re-open because my "quick fix" didn't fix anything and made things worse.

omg noooo 😱 rm -rf / and restart lol

Yeah, I misunderstood an project option there.
Can't you disable Actions in your fork?

Oh yea I see an option in my fork repo, I didn't know I had this power 🔋

Looks like this can't be changed automatically when forking. I.e. a fork will have Actions enabled by default and would have to manually disable them if needed. So let's close this again, as I don't think that something can be done from our side here.


Get-recipient -Filter "IsSecurityPrincipal -eq '$True'" - This does not work

The information on this page is wrong. It says IsSecurityPrincipal is something that can be filtered on within recipient filters.
PowerShell disagrees.
Get-recipient -Filter "IsSecurityPrincipal -eq '$True'" | measure-object

Cannot bind parameter 'Filter' to the target. Exception setting "Filter": ""IsSecurityPrincipal" is not a recognized filterable property.
"IsSecurityPrincipal -eq 'True'" at position 1."
At C:\Users\<username>\AppData\Local\Temp\tmp_isu03o23.i12\tmp_isu03o23.i12.psm1:30935 char:9
+         $steppablePipeline.End()
+         ~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : WriteError: (:) [Get-Recipient], ParameterBindingException
    + FullyQualifiedErrorId : ParameterBindingFailed,Microsoft.Exchange.Management.RecipientTasks.GetRecipient

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3762ada1-99d6-fa6d-fbd7-524003f8c3b2
Version Independent ID: 03e801b7-fa14-b5fb-8600-131c9e73292f
Content: Filterable properties for the RecipientFilter parameter
Content Source: exchange/docs-conceptual/recipientfilter-properties.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@EngineerHGH, the topic that's reference by this issue is about the RecipientFilter parameter, and your code example that generated the error contains the Filter parameter. The topic about the Filter parameter is here:
https://docs.microsoft.com/powershell/exchange/filter-properties
In that topic, the entry for IsSecurityPrincipal says this:

Property name
LDAP display name
Available on cmdlets
Value
Comments

IsSecurityPrincipal
n/a
Get-LinkedUser  Get-User
Boolean ($true or $false)
For example, Get-User -Filter 'IsSecurityPrincipal -eq $false'.

So I think we're OK?

@EngineerHGH Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


chore: Superchain Crate

📚 $\text{Stack Overview}$
Pulls submitted in this stack:

#100 👈
main

This comment was automatically generated by st.


Show on another screen if current is full screened

Prerequisites

Please check that your issue isn't already filed: https://github.com/kmikiy/SpotMenu/issues?utf8=✓&q=

It isn't.
Description
I have a Macbook and I usually use it with a second screen attached. I frequently full screen the apps in the second screen to make use of the whole real estate.
When a full screened app in a screen is focused, SpotMenu is only visible in that screen's top bar but the top bar itself is not visible because, well, it is full screened.
Perhaps an option to choose to "show SpotMenu on another screen (when exists) if the focused screen is full screened" would fix this and it'd definitely work for me.
Steps to Reproduce

Connect a second screen to your computer.
Open Spotify, open SpotMenu.
Start playing a music.
Open another app in one of the screens, and full screen it. The app should be the only thing visible in that whole screen.
Check your other screen's top bar. The SpotMenu is not there, unless you focus that screen.

Versions
SpotMenu version: 1.9.0
MacOS version: 10.14.6

I have the same issue, although you don't have to full screen an app to see this, you can also see it just by having a second monitor plugged in. I have 3 monitors and SpotMenu is only ever visible on the monitor currently in focus. The space for it is there on all the monitors, but on non-focused monitors the space is just empty. I can see the icons to the left and right of it, but SpotMenu itself is just gone.
What it looks like on the monitor in focus:

What it looks like on any monitors not in focus:

now that macbooks have a notch, this is a dealbreaker for me since I'm often focused on my macbook but want to know what is now playing - this never fits on my mbp screen so I would always want it on the other screens.


TypeError when config.yml requests a missing widget: Cannot read property 'validate' of undefined

Describe the bug
Error when config.yml requests a missing widget

TypeError: Cannot read property 'validate' of undefined

To Reproduce

In a working config.yml, capitalize the first letter of a stock widget.
Reload the page and make a new item in the collection you just updated.
See error.

Example:
  - name: page
    label: Page
    folder: /
    create: true
    fields:
      - { name: path, label: Path }
      - { name: title, label: Title }
      - { name: description, label: Description }
      - { name: body, label: Body, widget: Markdown } # Danger!

(This also applies to fields in a list, etc.)
Expected behavior

Replace the invalid widget with an error that says the widget could not be found

For bonus points, if widget.toLowercase() exists, suggest using that

Some sort of "Invalid configuration" warning on the main page

Applicable Versions:

Netlify CMS version: 2.10.23
Git provider: GitHub
OS: macOS Mojave
Browser version: Chrome 79

CMS configuration
https://github.com/exultrochester/exultrochester.org/blob/master/admin/config.yml
Additional context
I first encountered this problem while adding collections[name=conference][name=speakers][name=image] in the above config.

I ran into this today as well, typoed a widget name. Thanks for explaining how to fix this error @edbrannin :+1:

Had this problem today as well. An error like proposed would have been very helpful


covert SVDLinear dtype

If the data types are not converted appropriately, the following errors may occur:
File "/home/user/miniconda3/lib/python3.11/site-packages/transformers/models/llama/modeling_llama.py", line 691, in forward
    query_states = self.q_proj(hidden_states)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/user/miniconda3/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1518, in _wrapped_call_impl
    return self._call_impl(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/user/miniconda3/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1527, in _call_impl
    return forward_call(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/user/miniconda3/lib/python3.11/site-packages/peft/tuners/adalora/layer.py", line 175, in forward
    result += (dropout(x) @ (lora_A * lora_E).T @ lora_B.T) * scaling / ranknum
               ~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
RuntimeError: expected mat1 and mat2 to have the same dtype, but got: c10::Half != float```

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.


[Extension Bug]

Extension – Dash

Author: @RSO

Description

Steps To Reproduce

Installed Dash extension
Access Dash within Raycast
Error

The current behavior
Error: Command failed: defaults read com.kapeli.dashdoc docsets | plutil -convert json -r -o /private/tmp/b61cedd53b9dac38797f2184840e4742.json -
2021-11-20 12:07:14.300 defaults[40254:7519100]
The domain/default pair of (com.kapeli.dashdoc, docsets) does not exist
2021-11-20 12:07:14.300 defaults[40254:7519100]
The domain/default pair of (com.kapeli.dashdoc, docsets) does not exist
ChildProcess.exithandler:node:child_process:397:12
ChildProcess.emit:node:events:390:28
maybeClose:child_process:1064:16
Socket.:child_process:450:11
Socket.emit:node:events:390:28
Pipe.:node:net:672:12
The expected behavior
To show Dash docs
Raycast version
Version:

Thanks for reporting! Did the extension work before, or has it always been like this for you?
Also, can you maybe share how you have installed Dash on your machine? I'm currently aware of two different types of Dash installs that result in different locations, it could be that you're on a third 🤔 .


Add support for Kafka 2.5.0 and Go 1.14

🥗

Hi @bai - can we get a release of burrow soon with this 2.5.0 support?

@seallison done https://github.com/linkedin/Burrow/releases/tag/v1.3.4, thanks for raising this. Binaries should be ready in a couple minutes.


Remove | any from apiGatewayProps

Issue #, if available:
n/a
Description of changes:
Adding  | any to the type for apiGatewayProps in the aws-apigateway-lambda construct was removing intellisense. Not sure why it was in there. This shouldn't be a breaking change for anyone who has validly-defined props, unless I'm missing something...

AWS CodeBuild CI Report

CodeBuild project: codebuildgithubautobuildPro-fkVQbXRiQi6A
Commit ID: 25ca234129e8505679084ef1fd0d5be6b7bbf82b
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

The | any is there purposefully. It allows someone to specify any subset of a props object without having to specify all required properties (which are usually specified in default properties or through the overall architecture of the construct). We realize that it disrupts type convenience, but made the design decision to favor the ability to specify any set of attributes on a properties object.

Sorry, I left out one key piece of information, when taking a second look at your code I was reminded. In Typescript, Partial<> is a great alternative and we investigated it a few weeks back when someone else suggested it. The problem occurs when we use JSII to create the NPM, PyPi, Maven and .NET interfaces for constructs. The Partial operator creates a Mapped Type in Typescript and JSII does not support Mapped Types at this time.
We've opened an issue requesting Mapped Type support on their repo, you can go there and register your support.

@biffgaut thank you for the response, I suspected there was a reason for it! I've put a 👍 on that issue, for the little that's worth.

FWIW - when someone pointed out partial<> we were very excited, as do value the type checking that was lost.


Add Windows URI handling

@hoffmabc this recreates the branch that was merged too early.

I've tested this and it looks good. One thing to note is it only works for installed apps. Anyone running manual installs will not benefit from this.


[wip] add a switch for metricscache

add a switch to turn on/off metricscache
In some scenarios, the customers do not turn on healthmgr/dhalion, so the metricscache does not have consumer. This PR add a switch to turn if off.

Just a general question: is there a test to test configuration settings?


IDE-specific derived resources

IDEA: Let's check whether we need the *.iml in version control.
When we change pom.xml, it's getting updated.
Find best practices.
https://intellij-support.jetbrains.com/hc/en-us/articles/206544839

[ ] IDEA: *.iml
[ ] IDEA: general storage
[x] Eclipse: .settings
[ ] Eclipse; other

Caused by #245

Sharing user dictionaries is not implemented fully yet in IDEA
https://youtrack.jetbrains.com/issue/WI-36432?p=IDEA-121886


Fix the example in the README

The change fixes the example in the README.
ObtainCertificate returns a map of "failures" and not a standard error as second return value.

Oops, thanks!


Updates to visual studio generator selection

Howdy!
Per the discussion in #12 I'm proposing the following update.
I'm happy to make any changes and corrections.

Hrm... wait a sec... this worked fine and then it didn't.
I got some strange juju trying to build later and I'm trying to triage what on earth the change could possibly have been because all things considered the determination was working as expected. O.o

Building with 0.1.17 from crates.io works if I specify the generator manually. Building from path or from git fails with:
Build output:
error: failed to run custom build command for `nanomsg-sys v0.7.0 (file:///C:/projects/nanomsg.rs/nanomsg_sys)`
Process didn't exit successfully: `C:\projects\nanomsg.rs\target\debug\build\nanomsg-sys-94fa98c2d827f080\build-script-build` (exit code: 101)
--- stdout
running: "cmake" "\\\\?\\C:\\projects\\nanomsg.rs\\nanomsg_sys\\nanomsg" "-G" "Visual Studio 14 2015 Win64" "-DNN_STATIC_LIB=ON" "-DNN_ENABLE_DOC=OFF" "-DNN_TESTS=OFF" "-DCMAKE_INSTALL_PREFIX=C:\\projects\\nanomsg.rs\\target\\debug\\build\\nanomsg-sys-94fa98c2d827f080\\out" "-DCMAKE_C_FLAGS= /nologo /MD" "-DCMAKE_CXX_FLAGS= /nologo /MD" "-DCMAKE_BUILD_TYPE=Release"
-- The C compiler identification is MSVC 19.0.23918.0
-- Check for working C compiler using: Visual Studio 14 2015 Win64
-- Check for working C compiler using: Visual Studio 14 2015 Win64 -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detected nanomsg ABI v5.0.0
-- Looking for pthread.h
-- Looking for pthread.h - not found
-- Found Threads: TRUE
-- Looking for InitializeConditionVariable
-- Looking for InitializeConditionVariable - found
-- Performing Test NN_HAVE_GCC_ATOMIC_BUILTINS
-- Performing Test NN_HAVE_GCC_ATOMIC_BUILTINS - Failed
-- Configuring done
-- Generating done
-- Build files have been written to: C:/projects/nanomsg.rs/target/debug/build/nanomsg-sys-94fa98c2d827f080/out/build
running: "cmake" "--build" "." "--target" "install" "--config" "Release" "--"
Microsoft (R) Build Engine version 14.0.25123.0
Copyright (C) Microsoft Corporation. All rights reserved.

Build started 7/18/2016 6:47:44 PM.
Project "C:\projects\nanomsg.rs\target\debug\build\nanomsg-sys-94fa98c2d827f080\out\build\install.vcxproj" on node 1 (default targets).
Project "C:\projects\nanomsg.rs\target\debug\build\nanomsg-sys-94fa98c2d827f080\out\build\install.vcxproj" (1) is building "C:\projects\nanomsg.rs\target\debug\build\nanomsg-sys-94fa98c2d827f080\out\build\ZERO_CHECK.vcxproj" (2) on node 1 (default targets).
PrepareForBuild:
  Creating directory "x64\Release\ZERO_CHECK\".
  Creating directory "x64\Release\ZERO_CHECK\ZERO_CHECK.tlog\".
InitializeBuildStatus:
  Creating "x64\Release\ZERO_CHECK\ZERO_CHECK.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(171,5): error MSB6001: Invalid command line switch for "cmd.exe". Illegal characters in path. [C:\projects\nanomsg.rs\target\debug\build\nanomsg-sys-94fa98c2d827f080\out\build\ZERO_CHECK.vcxproj]
Done Building Project "C:\projects\nanomsg.rs\target\debug\build\nanomsg-sys-94fa98c2d827f080\out\build\ZERO_CHECK.vcxproj" (default targets) -- FAILED.
Done Building Project "C:\projects\nanomsg.rs\target\debug\build\nanomsg-sys-94fa98c2d827f080\out\build\install.vcxproj" (default targets) -- FAILED.

Build FAILED.

"C:\projects\nanomsg.rs\target\debug\build\nanomsg-sys-94fa98c2d827f080\out\build\install.vcxproj" (default target) (1) ->
"C:\projects\nanomsg.rs\target\debug\build\nanomsg-sys-94fa98c2d827f080\out\build\ZERO_CHECK.vcxproj" (default target) (2) ->
(CustomBuild target) ->
  C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(171,5): error MSB6001: Invalid command line switch for "cmd.exe". Illegal characters in path. [C:\projects\nanomsg.rs\target\debug\build\nanomsg-sys-94fa98c2d827f080\out\build\ZERO_CHECK.vcxproj]

    0 Warning(s)
    1 Error(s)

Time Elapsed 00:00:00.61

--- stderr
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_BUILD_TYPE
    CMAKE_CXX_FLAGS

thread '<main>' panicked at '
command did not execute successfully, got: exit code: 1

build script failed, must exit now', c:/Users/phote/.cargo\git\checkouts\cmake-rs-79f579515df22732\master\src\lib.rs:496
note: Run with `RUST_BACKTRACE=1` for a backtrace.

Tried this using both alexcrichton/cmake-rs as well as my fork at photex/cmake-rs.

Ah well, looks like I'm getting bit by this https://github.com/alexcrichton/cmake-rs/commit/ca0989c5dd9d191d7d5811851b41a72be64fc925
Reverting that commit things work fine again for me.

Thanks for the PR! Perhaps this could vendor some windows registry code like gcc-rs does to avoid relying on executing an external command?

I'd be happy to do that. I honestly started doing that but wasn't sure if this was better. Meanwhile, some parts of gcc-rs that I could start with weren't public and I didn't want to also rope that in.
If it's all the same to you I'll just use the win32 api directly then.

@photex if you copy this file and then ensure it only compiles on Windows, that should provide all we need I believe.

Since I wasn't able to use cmake-rs at all from git due to a previously merged commit I included a fix in this commit. I'm happy to roll that into a separate PR though. It seems to only have broken builds on windows.
I moved the canonicalization of the path into the function referenced by the comment.
I was able to build my fork of nanomsg.rs using a developer shell as well as a vanilla shell.

Awesome, looks great to me, thanks!


[8.x] Make it easy to output an empty line on the CLI

Right now, you can create an empty line on the CLI with:
$this->line('');

This PR makes passing that empty string optional.
$this->line();

I think this may be a breaking change if someone is extending the method? Also we have the newLine method 😄

TIL the newLine method 🙂
I don't think adding a default value is breaking (adding typehints is).

TIL adding a default is a breaking change 😃


Add support for command HSTRLEN

Add support for the HSTRLEN command in DiceDB similar to the HSTRLEN command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.
Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.
For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@HassanAarzoo assigned, thanks for contributing.

Hi @lucifercr07,
Since @HassanAarzoo is working on #646, let me take this.
Thanks

Hi @lucifercr07,
Since @HassanAarzoo is working on HEXISTS, let me take this.
Thanks

Assigned @c-harish


nvm

I've been at this for hours now, install the correct scripts, nothing works. Popup says it couldn't find the configuration file?

Please delete this comment and show some respect for the work that has been done here.

huh? wouldn't you be annoyed if you spent a day trying to get something working? also what is that supposed to mean, this is a really weird issue cus i downloaded all of the required scripts.

No idea what was said here, but going to assume it wasn't exactly positive. Modifying macOS is difficult; feel free to let me know when you yourself create something more impressive.

No idea what was said here, but going to assume it wasn't exactly positive. Modifying macOS is difficult; feel free to let me know when you yourself create something more impressive.

it wasnt working and then it did work but not fully
it said that the config file could not be found
i ended up stopping using it because whenever i opened an app it would arrange it annoyingly
the app is not good for 8+ windows open, the grid looks very off
i decided to just use mosaic on setapp
i was very annoyed, i tried to get the program to work for 12+ hours only to find the thing that would make it work was a hidden file (found through cmd+full-stop)
only for it to not work as expected and just make window management more difficult

i ended up stopping using it because whenever i opened an app it would arrange it annoyingly

This can be customized in various ways, but I assume you didn't like the default behaviour.

the app is not good for 8+ windows open, the grid looks very off

Tiling is usually used in combination with workspaces, the amount of windows for each workspace varies depending on your screen size of course.
As for the rest of your issues, they can all be resolved by following the introduction in the wiki: https://github.com/koekeishiya/yabai/wiki/Configuration#configuration-file
This is a piece of software that is supposed to be highly configurable and scriptable, but also panders to a certain paradigm, which probably didn't click with how you want things to be, and that's fine. You probably had different expectations going into this.

multiple desktops on my computer, or workspaces, makes it lag and having 4+ desktops makes the cpu spike on idle to 60%. i'm using an m1 pro aswell, so this is pretty strange behaviour for a chip this powerful.


🧑💻 : Can try to implement a vs computer mode in TTT

:red_circle: Tic tac toe game :
:red_circle: Enhancement Aim - Adding a VS computer mode :
:red_circle: Changes :  1. Creating a VS computer logic in tic tac toe game
2. Will try to create a button to switch modes
Screenshots 📷
 N/A

✅ Details to Include When Taking the Issue:
Name : Nivesh Chaudhary
Participant Role : GSSOC , Hacktoberfest

Happy Contributing! 🚀
Wishing you all the best on your open source journey. Enjoy! 😎

already present in project


full rename of Project and Namespaces to SManager

this will do for now
we can build and we are "fact" checking our coding


Account Settings Page; sync AuthContext across browser tabs

Fixes #92
Added the capability to:

Update account information (email + username)
Allow for sync of login and session information across different browser tabs (1 tab logs in, other tab logs in as well)
Delete account
Add another functionality for admins to assign/unassign new admins
Allow changes from external tabs to be updated (e.g. user made admin is reflected automatically through a backend check that runs every 2000ms)

Testing done:
Basic delete account functionality:

Delete User A account
User A should be logged out. Logging in again with User A details should yield User not found error. User A should be able to sign up again as a new account

Integration testing to ensure the delete account works well with the matching service:

Enter User A into match queue. Queue should be [ User A ]
In new tab, delete User A account
User A should be logged out and deleted from match queue as a result (queue should be [])

Demo screenshots:

LGTM! but why we allowing users to change their email if its a unique identifier haha

wait i thought we agreed that the ID was the unique identifier

LGTM! but why we allowing users to change their email if its a unique identifier haha

wait i thought we agreed that the ID was the unique identifier

yeahyeah as in like we are identifying users based on their id but it seems a bit odd to let them change their email because i thought it was another form of a unique identifier but its not a big issue


Label text color: and markup

Hello,
It appears that color: (0, 0, 1, 1) in KVLang doesn't work on a Label which uses markup.
Thanks for reading!

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/11881992-label-text-color-and-markup?utm_campaign=plugin&utm_content=tracker%2F42681&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F42681&utm_medium=issues&utm_source=github).

I cannot reproduce this with:
    Label:
        text: '[color=#fffff]aaa[/color]ccc'
        color: (0, 0, 1, 1)
        markup: True

Any hints?

BoxLayout:
    ToggleButton:
        id: tog
        text: 'Toggle Me'
    Label:
        text: 'hello'
        markup: True
        color: (1, 1, 1, 1) if(tog.state == 'normal') else (0, 0, 1, 1)

Workaround is to put the color in the markup:
        text: '[color=%s]hello[/color]' % get_hex_from_color(self.color)

Thanks @kived, the bug report makes sense now. :-P

Sorry dessant - as kived pointed out, my original example included a ToggleButton ;-)

Sorry dessant - as kived pointed out, my original example included a ToggleButton ;-)

@Cheaterman it's ok :D


Save usage data as sensor attribute data instead

Hi @Tmbao, thanks for making this available.  My use case is very close, but not the same as yours - I have sensors for power and energy flow which are available in real time and populate my energy dashboard, but I would still like to get the Amber usage information into my home assistant instance for additional analysis (as it is what is actually being billed).
I've tried to access the usage information directly from the API, but unfortunately the structure doesn't work well with the restful sensor because the json is a list (of dictionaries) rather than a dictionary itself.
Is there an easy way to save the usage information from the API as attributes of a sensor, rather than insert them into the home assistant statistics (either directly, or by simplifying your custom_component)?  Attributes something like the structure pasted at the end of this post would be useful as it can be graphed directly with apex charts-card and is also easily manipulated in templates or python scripts.
Thanks, Fred
Usage:
  - type: Usage
    duration: 30
    date: "2023-12-08"
    endTime: "2023-12-07T14:30:00Z"
    quality: billable
    kwh: 0.191
    nemTime: "2023-12-08T00:30:00+10:00"
    perKwh: 23.55448
    channelType: general
    channelIdentifier: E1
    cost: 4.4989
    renewables: 6.199000000000001
    spotPerKwh: 7.85292
    startTime: "2023-12-07T14:00:01Z"
    spikeStatus: none
  - type: Usage
    duration: 30
    date: "2023-12-08"
    endTime: "2023-12-07T15:00:00Z"
    quality: billable
    kwh: 0.209
    nemTime: "2023-12-08T01:00:00+10:00"
    perKwh: 23.34667
    channelType: general
    channelIdentifier: E1
    cost: 4.8795
    renewables: 6.45
    spotPerKwh: 7.65591
    startTime: "2023-12-07T14:30:01Z"
    spikeStatus: none
  - type: Usage
    duration: 30
    date: 2023-12-08
    endTime: "2023-12-07T15:30:00Z"
    …

Hi Fred, I think the challenge of sensors is that it's supposed to record real-time data rather than historical data, so it would be tricky to insert historical data to the sensors. Amber usage is published daily and that's also way longer than the usual refresh period of sensors. Probably a workaround is to just have a dummy sensor that refresh every few minutes but does effectively nothing and is only for carrying rolling historical usage attributes 🤔

Hi @tmbao thanks for the response and thoughts.  I solved my problem by taking the API data in via a bit of a convoluted path, I'm sure if I knew more it could be done far more elegantly.  The data eventually ends up being stored in a sensor's attributes, which has a size limit.  I mostly want it just for yesterday's data for graphing purposes and the data is small enough to fit.
What I probably need to do, if I want to make use of a larger set of historical usage info, is learn how to store (and retrieve) data in a structure better suited for this task (maybe a small local database, a local file, a google sheet etc).