Upstream emissions

Move the co2 emission tracking from the current state of downstream tracking (downstream emissions: from use of products and end-of-life treatment (e.g. disposal)) to upstream tracking (upstream emissions: from raw materials (coal, oil)
Reason:

atm technologies which extract co2 from a store to consume it receive money and therefore the capex and the prices to the buses these technologies attend to are influenced (e.g. FT)
shifting the co2 tracking upstream alters the carriers / technologies which are being affected: now gas, oil and coal are directly restricted and pay higher prices than before

This change should not:

alter system costs
alter technology capacity, generation, ....

The only thing that should change are the marginal prices:

co2 atmosphere should be 0
oil, coal, lignite and gas prices should increase

ToDO:

take care of the constraint on German CO2 emissions in the current downstream cap -> constraint German gas/oil/coal/sequestration usage
remove "co2 atmosphere" bus an all links to it

One diff in 2040 is present for the hydrogen production:
For downstream we have:
weqwe

sdasd
''

What have I tested?

[ ] model is running in 3H resolution
[ ] upstream and downstream constraints lead to the same co2 emissions both if you count them up or downstream
[ ] comparing upstream and downstream models

Comparison of 365H models:

Seems that the constraint on e-fuel imports/exports might be throwing things off. Possibly we should rewrite it to comply with how e-fuels are accounted in Ariadne, or even remove it altogether

A fairly straightforward way to ensure that all e-fuels are actually CO2-neutral would be to add the additional constraint that CO2 Sequestration has to be at least as high as sequestration from fossil sources

When comparing the downstream and upstream models and not restricting the e-fuel import / export the behaviour in 2040 is very similar. However now there is a difference in the hydrogen trade in 2045:
Hydrogen Trade in 2045
Trade-Secondary-Energy-Hydrogen-Volume

Trade-Secondary-Energy-Hydrogen-Volume-Exports

Trade-Secondary-Energy-Hydrogen-Volume-Imports

Trade-Secondary-Energy-Liquids-Hydrogen-Volume

Trade-Secondary-Energy-Liquids-Hydrogen-Volume-Exports

Trade-Secondary-Energy-Liquids-Hydrogen-Volume-Imports


Not resetting text after a bold element when using LegacyComponentSerializer

When converting a parsed JSON component to legacy formatting, the bold flag doesn't get reset properly. Therefore causing them to go beyond where they are meant to.
This is similar to https://github.com/KyoriPowered/adventure/issues/195 which was fixed with https://github.com/KyoriPowered/adventure/commit/059904899f74134139b62c47e1fcdf9306df6c29 but it still happens with this json and the bold flag
Version: 4.1.1 (adventure-api), 4d8a67d798 (adventure-text-serializer-gson), adventure-text-serializer-legacy (0599048)
Note: I have tested this with the latest commit in the repo with no change
Conversion code:
https://github.com/GeyserMC/Geyser/blob/master/connector/src/main/java/org/geysermc/connector/network/translators/chat/MessageTranslator.java#L80-L88
public static String convertMessage(String message, String locale) {
        Component component = GsonComponentSerializer.gson().deserialize(message);

        // Get a Locale from the given locale string
        Locale localeCode = Locale.forLanguageTag(locale.replace('_', '-'));
        component = RENDERER.render(component, localeCode);

        return LegacyComponentSerializer.legacySection().serialize(component);
}

JSON input:
{"text":"","extra":[{"text":"","extra":[{"text":"[","color":"gray"},{"text":"H","color":"yellow"},{"text":"]","color":"gray"},{"text":" ","color":"white"},{"text":"GUEST","color":"#b7b7b7","bold":true}]},{"text":"","extra":[{"text":" ","bold":true},{"text":"»","color":"blue"},{"text":" ","color":"gray"}]},{"text":"","extra":[{"text":"rtm516","color":"white"},{"text":": ","color":"gray"},{"text":"","color":"white"}]},{"text":"","extra":[{"text":"This is an amazing bedrock test message","color":"white"}]}]}

Legacy output:
§7[§eH§7]§f §7§lGUEST§r§l §9»§7 §frtm516§7: §fThis is an amazing bedrock test message

Json display: (Java, before conversion)

Legacy display: (Bedrock, after conversion)

That is indeed the correct behaviour (for Java). A legacy color character after a formatting character will reset the formatting therefore a reset character is not necessary there. This seems to be a different behaviour between Bedrock and Java.

Ah, thanks for pointing this out. I found a solution to make it more act like Java formatting when sent to bedrock.
legacy = legacy.replaceAll("\u00a7([0-9a-f])", "\u00a7r\u00a7$1");


Revert removal of strtree deprecation warning

Resolves #1444

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 4 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 85.824%

Totals

Change from base Build<PHONE_NUMBER>:
0.01%

Covered Lines:
3009

Relevant Lines:
3506

💛  - Coveralls


Upgrade to react-native-web v0.19.9

Details

Deprecated props

nativeId replaced with id prop
focusable replaced with tabIndex prop
pointerEvents replaced with pointerEvents style property
selectable replaced with userSelect style property
keyboardType replaced with inputMode prop
there are values which didn't have a replacement with the new prop used on native currently, visible-password and ascii-capable they then keyboardType will still be used on native files.
returnKeyType replaced with enterKeyHint prop
editable replaced with readOnly prop
numberOfLines replaced with rows prop for TextInput component
accessibility* replaced aria* props
We may use some accessibility* props in order to prevent some 3rd part libraries from breaking.
for example @testing-library/react-native: using aria-label instead of accessibilityLabel will cause the testing library from getting the component using queryByLabelText
textAlignVertical prop replaced with verticalAlign style

Deprecated style properties/values

transform array value to space-separated string functions. e.g. transform: 'scale(2)'
there are limitations using the space-separated string functions with Animated components, some transforms are still using array values more info: https://github.com/necolas/react-native-web/issues/2528
resizeMode style replaced with resizeMode prop

Breaking changes based on the usages in the codebase

[change]  is position:relative by default.
[change] Add task queue for InteractionManager.

More information can be found on this release note
Fixed Issues

$ https://github.com/Expensify/App/issues/16660
PROPOSAL: https://github.com/Expensify/App/issues/16660#issuecomment-1666425053
Tests

No Specific test cases

[ ] Verify that no errors appear in the JS console

Offline tests

QA Steps

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Replaced the fork package with upstream version.

Replaced

keyboardType prop with inputMode
We will have usages for which do not have equivalent values, for native. ascii-capable and visible-password
https://github.com/Expensify/App/pull/24482/files#diff-9d6b0cc89c7cab66ac4042ac0549bfc66ddc9e7a182b6b5dbbf7f687328f10b5R760-R763
editable prop with readOnly
numberOfLines prop with rows
nativeID prop with id
focusable prop with tabIndex with values 0 and -1
pointerEvents prop with pointerEvents style
accessibility* prop with aria-*
As of my investigation aria-* props are not supported yet in react-native-testing-library for example to query the components such as queryAllBy* methods.
as a result of it using accessibilityLabel for now.
accessibilityRole with role
eslint-plugin-react-native-a11y do not recognize role only recognizes accessibilityRole. I am seeing the code and planning to raise a PR to make it support aria-* and role props. this is specifically for fixing lint errors.
transform array values to spaced values
Though we can replace non animated styles without any issue, template literal with animated values will not work. it is working only with array values. we can reach out to SWM how we can use it with spaced values from react-native-reanimated please correct me if i am wrong.
textAlignVertical prop with verticalAlign style.

Patch for https://github.com/Expensify/react-native-web/pull/2 https://github.com/Expensify/react-native-web/pull/2 even though the code looks quite outdated.
Additionally added a fix inside the patch for the following issue which was caused by scaleY(-1)
https://github.com/Expensify/App/issues/16660#issuecomment-1666444603
@aimane-chnaif I hope i haven't missed a detail. thanks!

I'm comfortable using patch files as long as we have created an upstream PR and actively try to get that merged 👍🏼
@getusha can you please also create an issue in https://github.com/FormidableLabs/eslint-plugin-react-native-a11y as well so that you can link the PR to it and others will be able to easily find it. That way we can more easily tell if it's resolved by another PR as well

We haven't necessarily have a formal process around this yet, but our thinking is that the contributor that adds the patch is meant to be responsible for getting the change merged upstream, then upgrading the dependency to remove the patch ASAP.

Oof I forgot that Expensify/react-native-key-command isn't a fork of a 3rd-party dependency, but an original library of ours created by @azimgd. Reviewing https://github.com/Expensify/react-native-key-command/pull/31 right now...

@aimane-chnaif added patch for eslint-plugin-react-native-a11y https://github.com/Expensify/App/pull/24482/commits/916bff09978a9784ed47c334bca28bf0e88fcc48 and lint is still failing it might be related to eslint cache. I am going to remove WIP and start testing. thanks!

@aimane-chnaif @roryabraham It's ready for review!

@getusha Looks like you left a lot of accessibilityLabel prop. Can you tell me the reason for the same?
I think you should make all of them aria-label for consistency.

@getusha Looks like you left a lot of accessibilityLabel prop. Can you tell me the reason for the same?

@shubham1206agra please check my comment here

@getusha Looks like you left a lot of accessibilityLabel prop. Can you tell me the reason for the same?

@shubham1206agra please check my comment here

Ok
But there are a lot of accessibility props left if we ignore accessibilityLabel.
Can you identify them and fix them?

[ ] [change] Deprecate Touchable* components. Use Pressable.
[ ] [change] Deprecate Button component. Use Pressable.
[ ] [change] Deprecate StyleSheet.compose(). Use style array syntax.
[ ] [change] Deprecate accessibility* props. Use aria-* and role props.
[ ] [change] Deprecate nativeId prop. Use id prop.
[ ] [change] Deprecate focusable props. Use tabIndex prop.
[ ] [change] Deprecate pointerEvents prop. Use pointerEvents style.
[ ] [change] Deprecate selectable prop. Use userSelect style.
[ ] [change] Deprecate fontVariant style array values. Use space-separated string values.
[ ] [change] Deprecate textAlignVertical style. Use verticalAlign style.
[ ] [change] Deprecate transform style array values. Use space-separated string functions.
[ ] [change] Deprecate non-standard logical styles, e.g., 'marginStart'.
[ ] [change] Deprecate  style resizeMode. Use resizeMode prop.
[ ] [change] Deprecate  style tintColor. Use tintColor prop.
[ ] [change] Deprecate  prop keyboardType. Use inputMode prop.
[ ] [change] Deprecate  prop returnKeyType. Use enterKeyHint prop.
[ ] [change] Deprecate  prop editable. Use readOnly prop.
[ ] [change] Deprecate  prop numberOfLines. Use rows prop.
[ ] [change] Deprecate BackHandler API.

Copy this checklist and use this. It will be easier for you to verify/handle all the changes.

@aimane-chnaif I have doubts about one change
[change] Deprecate non-standard logical styles, e.g., 'marginStart'.
Should we ignore this change as it might break cross-platform support?

@aimane-chnaif I have doubts about one change [change] Deprecate non-standard logical styles, e.g., 'marginStart'.
Should we ignore this change as it might break cross-platform support?

[x] borderEndEndRadius is equivalent to borderBottomEndRadius.
[x] borderEndStartRadius is equivalent to borderBottomStartRadius.
[x] borderStartEndRadius is equivalent to borderTopEndRadius.
[x] borderStartStartRadius is equivalent to borderTopStartRadius.
[x] marginInlineStart is equivalent to marginStart.
[x] marginInlineEnd is equivalent to marginEnd.
[ ] marginBlockStart is equivalent to marginTop.
[ ] marginBlockEnd is equivalent to marginBottom.
[ ] marginBlock is equivalent to marginVertical.
[ ] marginInline is equivalent to marginHorizontal.
[ ] paddingInlineStart is equivalent to paddingStart.
[ ] paddingInlineEnd is equivalent to paddingEnd.
[ ] paddingBlockStart is equivalent to paddingTop.
[ ] paddingBlockEnd is equivalent to paddingBottom.
[ ] paddingBlock is equivalent to paddingVertical.
[ ] paddingInline is equivalent to paddingHorizontal.
[ ] inset is equivalent to top & bottom & right & left.
[ ] insetBlock is equivalent to top & bottom.
[ ] insetBlockEnd is equivalent to bottom.
[ ] insetBlockStart is equivalent to top.
[ ] insetInline is equivalent to right & left.
[ ] insetInlineEnd is equivalent to right or left.
[ ] insetInlineStart is equivalent to right or left

This is the checklist if we want to make this change.
I think we should not make this change.
What are your thoughts @aimane-chnaif @getusha ?

@aimane-chnaif incase you missed my comment: https://github.com/Expensify/App/pull/24482#issuecomment-1678853696
lint is passing locally.

lint error log:

> eslint . --max-warnings=0 --cache --cache-location=node_modules/.cache/eslint
it's using the cache

@aimane-chnaif all checks have passed now.

@aimane-chnaif fixed conflicts, will fix them as they come.

@aimane-chnaif Fixed.

@aimane-chnaif friendly bump for a review.

Hey, I've just had a quick look at this PR (because my issue is on HOLD on it).

I've found an issue. The ReportScreen content is centered instead of at the bottom.

Main
Staging
This PR

@kosmydel thanks for bringing this up here! i also identified this previously i thought i fixed it, pushed the changes now check it again.

transform array values to spaced values

Though we can replace non animated styles without any issue, template literal with animated values will not work. it is working only with array values. we can reach out to SWM how we can use it with spaced values from react-native-reanimated please correct me if i am wrong.

accessibilityLabel

aria-label not being supported by react-native-testing-library for querying components

numberOfLines (many cases)

numberOfLines is deprecated for TextInput on the release notes, so i changed it only for the text input. i believe the remaining is only applied on Text components.
rows={numberOfLines}

selectable (BaseHTMLEngineProvider)

Since it was an external component i assumed it might be a custom prop which will be used, i will check again and see if we can pass stylings to the component.

BUG1: no skeleton, search input label is not activated even though focused

@aimane-chnaif thanks for the review!
I  Identified the bug, it causes some sort of delay across most of the components/pages i am investigating the root cause from react-native-web

@aimane-chnaif fixed all bugs related to web, working on the native issues 🙇

Though we can replace non animated styles without any issue, template literal with animated values will not work. it is working only with array values. we can reach out to SWM how we can use it with spaced values from react-native-reanimated please correct me if i am wrong.

Update: i noticed a PR Animated support for string transforms. https://github.com/necolas/react-native-web/pull/2546
I will try again following the examples.

BUG7: keyboard shows unnecesarily

@aimane-chnaif unable to reproduce this one.
https://github.com/Expensify/App/assets/75031127/5f3551f5-47b0-4041-ad0f-e0a603cbad14

@aimane-chnaif Can you help me merge this PR?
https://github.com/necolas/react-native-web/pull/2569

I think you can review it. But I think you need to merge so that the warning can be solved when using a skeleton.

BUG6. Console warning

@aimane-chnaif i am not sure why we are giving the accessibilityRole 'text' for TextInputs and also there is no equivalent for it in the new role prop. i think we can safely remove it what do you think?

@aimane-chnaif for example here: https://github.com/Expensify/App/blob/34d4e54055c3fee2a04e2fc11af82fe454197ff9/src/components/AmountTextInput.js#L52

@aimane-chnaif addressed all native/web bugs asked questions on some,

Received false for a non-boolean attribute collapsable.
If you want to write it to the DOM, pass a string instead: collapsable="false" or collapsable={value.toString()}.

i think it will be removed by this PR collapsable doesn't seem to do anything on the web.
regarding transform values it is not working for native when using Animated components, using the array value instead of writing platform specific code.
commented here: https://github.com/necolas/react-native-web/issues/2528#issuecomment-1694252876
Other than that i believe other warnings/errors are coming from external packages.
Please let me know if i missed anything 🙇

What I reported https://github.com/Expensify/App/pull/24482#issuecomment-1688962269 is caused by this PR, not happening on main. So you fixed all of them except blockers?

what i am saying is there is no code in the codebase that will trigger the error currently. However, after upgrading to the latest (rnw) version, the error may arise due to the packages utilizing deprecated values.
should we replace all deprecated values from every package that is causing the warnings/errors and patch it here?

@aimane-chnaif for example we don't have any pointerEvents prop in our branch, but the warning exists, here is an example of external libraries using the deprecated value.
https://github.com/search?q=repo%3Areact-navigation%2Freact-navigation pointerEvents%3D&type=code

Just confirming here, we don't need to fix all deprecation warnings in all our 3rd party libs. We should at least create issues in those libs to inform the maintainers of the deprecation though.
The only time we'll need to patch or upgrade 3rd party libs is for any previously-deprecated APIs that have been completely removed in RNW 0.19

I know we're in a merge freeze currently, but it seems like this PR has fallen out of date. We should work on resolving conflicts here so it doesn't fall too far out of date

@aimane-chnaif @roryabraham fixed the conflicts.
i have a quick question, do you have any idea why we are applying freeze after the first navigation?
https://github.com/Expensify/App/blob/c3ec03b1b6e2a16b0ec07c335b94b2aacabee83e/src/libs/Navigation/FreezeWrapper.js#L37-L38

No idea. @adamgrzybowski do you know why?

@getusha @roryabraham I think this part about freezing screens more than one screen below the current. Not sure how it's connected to the "first navigation" though.

@getusha @roryabraham I think this part about freezing screens more than one screen below the current. Not sure how it's connected to the "first navigation" though.

@adamgrzybowski strangely it was causing some functionalities to have a delay, like focus of an input, showing the skeleton ui etc. These issues only arise after navigating to different reports, not during the initial page load.
check the video here: https://github.com/Expensify/App/pull/24482#issuecomment-1688969057

@getusha Yeah that's strange 😄 I could look at this on Monday with @WoLewicki if you want. He may have more context about the freeze wrapper

@adamgrzybowski Thank you! I was able to resolve the issue using InteractionManager but was wondering if there might be a better solution available.
https://github.com/Expensify/App/pull/24482/files#diff-af092d20142155f8d72dbdab8fe6ab3fa658bdb820b5a72b8a296fea3500f2eaR39

@getusha do those issues happen only when navigating back? Also does it happen always or on some specific flows only? Would be nice to get some more context, maybe it also can happen on main.

@getusha do those issues happen only when navigating back? Also does it happen always or on some specific flows only? Would be nice to get some more context, maybe it also can happen on main.

@WoLewicki the issue will start to happen when you navigate to another chat and then navigate anywhere e.g. open Search page, there is a noticeable delay. i checked and not able to reproduce it on main.

@WoLewicki

Open app
Navigate to any other chat
Click on the search icon or navigate to other chats

https://github.com/Expensify/App/assets/75031127/93ca50bb-cb1b-4c62-8f67-1fed924f603f

@getusha please fix conflict

@aimane-chnaif fixed.

@WoLewicki any updates on this?

Ok I investigated it a bit on your branch and there seems to be some problems with applying freeze and starting the animation of RHP at the same time since the renders etc are all being dispatched in the correct time. The fix you applied should be a good for the start, but I spotted that if you do multiple changes of reports fast enough and then immediately click the e.g. search button, it will still cause a lag then from time to time. But it does not happen all the time, so I think we should leave your workaround for now not to block the merge and take care of the issue in a follow up.
I am afraid the problem comes from how the new features of React 18 and its integration with Suspense which is used in react-freeze.
Are we OK with such a solution for now @getusha @roryabraham ?

I think we should leave your workaround for now not to block the merge and take care of the issue in a follow up.

I investigated a bit more and didn't find anything, I think we should do this, what do you think @roryabraham?

If this fix is good for now, when can we expect to get it merged?

Yes, let's include the workaround to get this over the finish line ASAP

@aimane-chnaif just merged main 🙇

Use the links below to test this build in android and iOS. Happy testing!

:test_tube::test_tube: Use the links below to test this build in android and iOS. Happy testing! :test_tube::test_tube:

android :robot:
iOS :apple:

https://ad-hoc-expensify-cash.s3.amazonaws.com/android/24482/index.html
https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/24482/index.html

desktop :computer:
web :spider_web:

https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/24482/NewExpensify.dmg
https://24482.pr-testing.expensify.com

@getusha did you find anything in your testing? It'd be great to get this out this week!

@aimane-chnaif found a bug, its a flicker when sending a message. i will push the fix.
https://github.com/Expensify/App/assets/75031127/d3b6318c-aef5-45b9-96f7-0a2da7606254

After the fix:
https://github.com/Expensify/App/assets/75031127/f2551e55-d558-4f06-940b-2faa6f60848a

I am up for anything which will help getting this out faster, but not sure how we can break this up to multiple PRs, do you mean to use some feature branch?

Hey Everyone, I thought of helping out with testing here. IMO, we should break this PR into multiple. It is just quite big and not testable. I am afraid that we will miss issues.

@parasharrajat I agree, this is a significant change, and there have been many changes from react-native-web. It's easy to introduce bugs on the web because of all these changes. If we choose to split it into several PRs, it might help us find bugs faster, but the downside is that it will take longer than addressing everything in one go. I suggest running a complete regression test on this PR, probably from applause if we can? We can use your idea to apply fixes carefully from expensify/react-native-web what do you think?

@getusha Please add bullet points for each type of change in the details. Then I will try to help you break it down on multiple PRs.

If we decide to go this way, i will provide detail on what changed. thank you 🙇

Did we fix all the bugs we found so far? Should we create a new build and share it with QA for the regression testing then? cc @roryabraham

@parasharrajat added some details https://github.com/Expensify/App/pull/24482#issue-1847992219

:test_tube::test_tube: Use the links below to test this build in android and iOS. Happy testing! :test_tube::test_tube:

android :robot:
iOS :apple:

https://ad-hoc-expensify-cash.s3.amazonaws.com/android/24482/index.html
https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/24482/index.html

desktop :computer:
web :spider_web:

https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/24482/NewExpensify.dmg
https://24482.pr-testing.expensify.com

Thanks @hoangzinh!

Bug 1: App crashes when editing Report welcome message

Fixed, and pushed the changes.

Bug 2: Console error when opening RHN

The onyx related error is kind of strange, i have a quick fix for that on react-native-onyx but investigating why it started happening on this PR only.

@parasharrajat @roryabraham fixed conflicts

So what next, guys? When we're going to do the next round of testing?

@aimane-chnaif pulled main.

@getusha If possible, can you please bump react-native-web to 0.19.9 as this fixes couple of issues?
cc @aimane-chnaif

It just consists of
https://github.com/necolas/react-native-web/pull/2576
https://github.com/necolas/react-native-web/pull/2558

@getusha If possible, can you please bump react-native-web to 0.19.9 as this fixes couple of issues?

@shubham1206agra thanks for pointing this out.

:test_tube::test_tube: Use the links below to test this build in android and iOS. Happy testing! :test_tube::test_tube:

android :robot:
iOS :apple:

https://ad-hoc-expensify-cash.s3.amazonaws.com/android/24482/index.html
https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/24482/index.html

desktop :computer:
web :spider_web:

https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/24482/NewExpensify.dmg
https://24482.pr-testing.expensify.com

@roryabraham @mountiny @aimane-chnaif @getusha @parasharrajat
This build seem to be really broken. We are not able to enter text in multiple places. Team will be logging issues, but this seems to be the biggest blocker
e.g
Login screen - unable to enter email
WS - Unable to enter ws name
WS - Unable to enter bank info
Room - cant seem to write an optional message in room
etc...

@mvtglobally is the issue reproducible on native also? thank you 🙇

@getusha we did not test Native, Web/mWeb is deffinitely broken
@aimane-chnaif  You can login if you dont navigate away from default and start entering email immediately after page loads

:test_tube::test_tube: Use the links below to test this build in android and iOS. Happy testing! :test_tube::test_tube:

android :robot:
iOS :apple:

https://ad-hoc-expensify-cash.s3.amazonaws.com/android/24482/index.html
https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/24482/index.html

desktop :computer:
web :spider_web:

https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/24482/NewExpensify.dmg
https://24482.pr-testing.expensify.com

@getusha @aimane-chnaif @mountiny  Are we good to resume?

@getusha @aimane-chnaif @mountiny Are we good to resume?

@mvtglobally yes, please don't forget to do "Empty Cache and Hard Reload".

@aimane-chnaif Hard Reload or Empty Cache and Hard Reload

We are still getting the issue? Does the build need deploy or smth ? https://github.com/Expensify/App/assets/43995119/895685dc-88f7-42f2-bf1e-2a4ebd9f02f0

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Login - Abracadabra page is not displayed when trying to login with email link in new tab
Action Performed:

Go to https://24482.pr-testing.expensify.com/
Try to log in with any user you have access to.
Go to email inbox for the magic link email.
Copy the magic link and change it to 24482.pr-testing.expensify.com.
Open new tab and go to the formatted link.

Expected Result:
Abracadabra page should be displayed
Actual Result:
Abracadabra page is not displayed., instead the user is directly logged in
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] Windows / Chrome
[ ] MacOS / Desktop

Version Number: 1.3.77-3 PR:24482
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/aa2806e3-9868-4c6b-bf22-db0afb9a034c
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Request money - No "Map" icon when using Distance tab
Action Performed:

Access https://24482.pr-testing.expensify.com/
Sign into a valid account
Press "+" > Request money > Distance tab
Input Start & Finish points

Expected Result:
User expects to see a map icon that updates in real time
Actual Result:
There is no map icon in special build
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] Windows / Chrome
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.77-3 PR:24482
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Chat - App crashes if no emoji matching the search is found in the emoji picker
Action Performed:

Open Desktop App or go to https://24482.pr-testing.expensify.com/
Login with any account
Open any chat
Open Emoji Picker
In the search field type the name of the emoji that cannot be found

Expected Result:
User receives a message that nothing was found
Actual Result:
App crashes
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] Windows / Chrome
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.77-3 PR:24482
Reproducible in staging?: No
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/0c2f925c-df4e-4d44-845d-1346831da390
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Login - Abracadabra page is not displayed when trying to login with email link in new tab

Access to fetch at 'https://staging.expensify.com/api?command=AuthenticatePusher' from origin 'https://24482.pr-testing.expensify.com' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.
Based on the above console error, the issue might be related to the URL rather than being a direct bug from this PR cc @aimane-chnaif @roryabraham @mountiny

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

mWeb - Request Money - Page blinks and switches between Scan-Manual-Scan tabs
Action Performed:

Navigate to https://24482.pr-testing.expensify.com/
Click on the "Global action" button
Click on "Request money"
Request Money page is open

Expected Result:
There should be no visual or functional errors
Actual Result:
Request Money page blinks and switches between Scan-Manual-Scan tabs (the issue is more noticeable when opening the page for the first time)
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.77-3 PR:24482
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/115492554/5b444b9a-32d1-4976-9311-493a412f523e
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
View all open jobs on GitHub

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Web - Invite members - Checkbox Select all - Deselect all is lagging
Action Performed:
Precondition: User has already invited few members to the Workspace

Open https://24482.pr-testing.expensify.com/
Navigate to Workspace>Members
Click on Select all checkbox
Click on Deselect all checkbox

Expected Result:
User should be able to change Select all - Deselect all fast and smoothly. There should be no lagging
Actual Result:
When click on Select all button there is a waiting time till User can use Deselect all butto
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.77-3 PR:24482
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/115492554/7351a17e-7c37-4750-94a1-597fb0fcae56
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
View all open jobs on GitHub

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Web - Status - Emoji picker appears next to RHP
Action Performed:

Go to https://24482.pr-testing.expensify.com/
Go to Settings > Profile > Status > Status.
Click on the emoji icon..

Expected Result:
Emoji picker appears below the emoji picker button.
Actual Result:
Emoji picker appears next to RHP.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.77-3 PR:24482
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/115492554/da0b71cd-62c1-4638-97df-c57b7f74b827
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
View all open jobs on GitHub

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Web - Room - Room name in the header shows room members instead of room name
Action Performed:

Go to https://24482.pr-testing.expensify.com/
Go to + > Send message > Room.
Enter room name and select a workspace that has members.
Create the room.
Go to the room chat.

Expected Result:
The room name in the header shows the room name.
Actual Result:
The room name in the header shows the room members instead.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.77-3 PR:24482
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/115492554/22a388af-9ba8-4861-b404-77e5ca32fd76
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
View all open jobs on GitHub

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Web - Settings - Workspace settings becomes unresponsive & grayed out when toggle Online-Offline
Action Performed:

Open https://24482.pr-testing.expensify.com/
Navigate to Preferences
Activate the Force offline toggle
Go back to Workspace Settings Page
Navigate to Preferences
Deactivate the Force offline toggle
Go back to Workspace Settings Page

Expected Result:
When navigate back to Workspace Settings Page ( Step 4 & 7) all section should be responsive
Actual Result:
Workspace settings screen becomes unresponsive & grayed out when toggle Online-Offline
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.3.77-3 PR:24482
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/115492554/0935984f-061b-45c4-a4a3-aeedd9b3bbd6
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
View all open jobs on GitHub

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Web - Login -Only the first five reports are displayed on LHN first after login
Action Performed:

Go to https://24482.pr-testing.expensify.com/
Log in with an account that has many chats on LHN.

Expected Result:
After login, all the chats will appear altogether in LHN.
Actual Result:
After login, only the first five reports are displayed on LHN first.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.77-3 PR:24482
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/115492554/49cc0833-6a07-4415-9a31-9c20de77c24b
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
View all open jobs on GitHub

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Log in - Logo appears cropped
Action Performed:

Go to https://24482.pr-testing.expensify.com/

Expected Result:
Logo is displayed in full
Actual Result:
Logo is displayed in 1/4 part
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.77-3 PR:24482
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

https://github.com/Expensify/App/assets/78819774/60e273cc-892c-4491-929d-8583e2e781b3
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
View all open jobs on GitHub

QA is completed

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Close account - There is no notification that account successfully closed
Action Performed:

Go to https://24482.pr-testing.expensify.com/
Login with any account
Go to Settings -> Security -> Close account
Enter your default contact method -> Close account -> Confirm

Expected Result:
The notification that account successfully closed appears
Actual Result:
There is no notification that account successfully closed
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: 1.3.77-3 PR:24482
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/78819774/71adec78-8440-41e5-ba46-0289419d0e21
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @
View all open jobs on GitHub

a total of 12 bugs, already started addressing each. thanks @mvtglobally!

Issue Tracker
in progress
Login - Abracadabra page is not displayed when trying to login with email link in new tab
https://github.com/Expensify/App/pull/24482#issuecomment-1747657695
Request money - No "Map" icon when using Distance tab
https://github.com/Expensify/App/pull/24482#issuecomment-1747669635
Chat - When scrolling through a long chat, a loop occurs and the chat history rewinds
https://github.com/Expensify/App/pull/24482#issuecomment-1748441622
mWeb - Request Money - Page blinks and switches between Scan-Manual-Scan tabs
https://github.com/Expensify/App/pull/24482#issuecomment-1748463816
Web - Room - Room name in the header shows room members instead of room name
https://github.com/Expensify/App/pull/24482#issuecomment-1748515432
Web - Chat - There is some delay in refocusing the composer when entering emojis
https://github.com/Expensify/App/pull/24482#issuecomment-1748632679
Web - Login -Only the first five reports are displayed on LHN first after login
https://github.com/Expensify/App/pull/24482#issuecomment-1748637525
Log in - Logo appears cropped
https://github.com/Expensify/App/pull/24482?notification_referrer_id=NT_kwDOBHjiV7M3MzY0NTI1Njc3Ojc1MDMxMTI3#issuecomment-1748805154
Fixed
Chat - App crashes if no emoji matching the search is found in the emoji picker [Fixed] ✅
https://github.com/Expensify/App/pull/24482#issuecomment-1747703238
Web - Invite members - Checkbox Select all - Deselect all is lagging [Fixed] ✅
https://github.com/Expensify/App/pull/24482#issuecomment-1748498453
Web - Status - Emoji picker appears next to RHP [Fixed] ✅
https://github.com/Expensify/App/pull/24482#issuecomment-1748504781
Web - Settings - Workspace settings becomes unresponsive & grayed out when toggle Online-Offline ✅
https://github.com/Expensify/App/pull/24482#issuecomment-1748624299

@aimane-chnaif @parasharrajat provided a list of bugs along with their status, i will be updating the list.

Some issues like this one are related to the change on InteractionManager, i believe it to be directly related to the task queue introduced here https://github.com/necolas/react-native-web/pull/2425, just noticed a callback inside runAfterInteractions gets triggered delayed or never trigger at all. we have to be careful how we use InteractionManager. cc @ntdiary

Great suggestion from Rajat, lets get those threads going

@mountiny @parasharrajat opened the slack discussion for 4 bugs we encountered, i will try to collect as much as information and tag other contributors/engineers who might have a context related to the bug. thank you!

Triggered a new build

:test_tube::test_tube: Use the links below to test this build in android and iOS. Happy testing! :test_tube::test_tube:

android :robot:
iOS :apple:

https://ad-hoc-expensify-cash.s3.amazonaws.com/android/24482/index.html
https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/24482/index.html

desktop :computer:
web :spider_web:

https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/24482/NewExpensify.dmg
https://24482.pr-testing.expensify.com

:test_tube::test_tube: Use the links below to test this build in android and iOS. Happy testing! :test_tube::test_tube:

android :robot:
iOS :apple:

https://ad-hoc-expensify-cash.s3.amazonaws.com/android/24482/index.html
https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/24482/index.html

desktop :computer:
web :spider_web:

https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/24482/NewExpensify.dmg
https://24482.pr-testing.expensify.com

Not sure if it was already submitted, but I cannot enter my email when logging in, words without @ seem to work fine:
https://github.com/Expensify/App/assets/32481228/4b7117c4-9b41-4b93-a794-263a13bcb795

@WoLewicki not able to enter an email or only the autofill is not working?

Only the autofill.

Hmm so not sure what can cause it. Maybe more people could check if they can/can't reproduce it?

For documentation. I started to take a look into the following issues:
Abracadabra login page not shown
https://github.com/Expensify/App/pull/24482#issuecomment-1747657695
This issue seems like a regression on react-native-web. On the previous version the NavigationContainer would correctly return false upon app start and the deep linking navigation would get queued. After the update, the navigation ref returns true but if one tries to immediately navigate the action is dropped. A simple workaround, for now, is adding a delay into the deep link handler to allow the navigation container to be able to take navigation commands.

Only the first 5 items are shown on the LHN
https://github.com/Expensify/App/pull/24482#issuecomment-1748637525
Had a quick discussion with @getusha about this one. It seems like some changes to RN-web make the batched rendering of lists a bit slower. The solution is easy, increase the number of initially rendered rows:
https://github.com/Expensify/App/blob/1c85ebeb55ffe81bf0cfa64665b4dc6625b94683/src/components/LHNOptionsList/LHNOptionsList.js#L87
However, this causes a minor performance regression. IMO there workaround for this since we need to render more rows on the first pass. I would just accept the performance hit on this one.

However, this causes a minor performance regression. IMO there workaround for this since we need to render more rows on the first pass. I would just accept the performance hit on this one.

Can you be more specific on what is the difference here? We are making good progress so would be not ideal to get a bigger set back here. Is there some video comparison or some benchmarking of these changes?
Overall though if these are the last things holding us from the merge I think we should go ahead. @roryabraham what do you think? I am not sure if another QA round is necessary

Can you be more specific on what is the difference here? We are making good progress so would be not ideal to get a bigger set back here. Is there some video comparison or some benchmarking of these changes?

@getusha ran the performance tests and I think there was a 42ms difference when he increased the list size to ~10.

Trying to draw this to a close: https://expensify.slack.com/archives/C05LX9D6E07/p1698960210222689

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:

Android :robot:
iOS :apple:

https://ad-hoc-expensify-cash.s3.amazonaws.com/android/24482/index.html
https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/24482/index.html

Desktop :computer:
Web :spider_web:

https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/24482/NewExpensify.dmg
https://24482.pr-testing.expensify.com

:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube:

Android :robot:
iOS :apple:

https://ad-hoc-expensify-cash.s3.amazonaws.com/android/24482/index.html
https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/24482/index.html

Desktop :computer:
Web :spider_web:

https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/24482/NewExpensify.dmg
https://24482.pr-testing.expensify.com

@aimane-chnaif for BUG-4 are you testing it locally or on build url?

Merged over the reassure tests failing as that was known given we had to increase the number of oLHN rows rendered initially

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@aimane-chnaif Can you post them in in Slack in open source in a thread so we could get people working on them?

@mountiny i can raise a PR for https://github.com/Expensify/App/pull/24482#issuecomment-1799325935
I am unable to reproduce this @aimane-chnaif

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.96-6 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

⬆ is a lie

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.96-15 🚀

platform
result

🤖 android 🤖
failure ❌

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.98-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.98-5 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Just a note that there was a minor regression related to this upgrade: https://github.com/Expensify/App/issues/31101

BUG3: console error: BackHandler is not supported on web and should not be used. No need to fix here but for tracking purpose

Coming from #31487, @react-navigation/native also prints BackHandler error, we have fixed it by upgrading its version. :)

Nice job fixing patch conflict 😄


[Aliases] Change wizard's initialisation to new dimension

Context
This stems out from trying to get dimensions right in https://github.com/bloomberg/cartodb/pull/183
I think you know best the implications, @tylerparsons. Review or discard.
Thanks :)

Assumed fix on Bloomberg side


[narando] add new extractor

Please follow the guide below

You will be asked some questions, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your pull request (like that [x])
Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

[x] At least skimmed through adding new extractor tutorial and youtube-dl coding conventions sections
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Bug fix
[ ] Improvement
[x] New extractor
[ ] New feature

Description of your pull request and other information
This implements an extractor for narando as specified in #18252 .  This also adds an extractor for [narando:player], which can be used in the future for sites which embed the narando player.

Thanks for reviewing the code and suggesting improvements, I've implemented them.

@dstftw Can you please take a look at this again?  I've also added thumbnail extraction.


Add DataArrayCoarsen.reduce and DatasetCoarsen.reduce methods

As suggested by @dcherian, this was quite similar to rolling; it was useful in particular to follow how the tests were implemented there.

[x] Closes #3741
[x] Tests added
[x] Passes pre-commit run --all-files
[x] User visible changes (including notable bug fixes) are documented in whats-new.rst
[x] New functions/methods are listed in api.rst

Thanks for the review @mathause!  Let me know if things look good from your end now.

Hello @spencerkclark! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file xarray/core/rolling.py:

Line 962:24: W291 trailing whitespace
Line 963:81: W291 trailing whitespace
Line 964:82: W291 trailing whitespace
Line 965:83: W291 trailing whitespace


[Feature]: Individual Grid Setpoint that is not Zero

Contact Details
No response
Description
Hello, I think not all want to set the gird setpoint to zero. I think it's good that everyone can set their own grid setpoint and I would like this feature to be built in.
Suggested Solution

Alternatives
No response
Additional Context
No response

Hi @mrstackit , right now the dynamic-ess algorithm is (ab-)using the grid-setpoint user setting because it had no other setpoint. This is being fixed right now as part of migrating Dynamic-ESS into VRM; no longer requiring Node-RED.
And most likely we'll also update the Node-RED implementation to use the new control points.

We've just published a new release, that is more incorporated into the Venus OS and follows the target SOC instead of setting a setpoint and a less than ideal way of idling the battery.
As this uses a different approach, you will need to:

update Venus OS (to 3.10 or above)
update the victron-dynamic-ess node to version 0.1.1
update the example flow
reconfigure the Dynamic ESS node (as it uses VRM portal ID instead of the Site ID)

More information can be found in the release notes and README.md


[BEAM-168] Remove uses of deprecated API

R: @lukecwik @davorbonaci
any lgtm will do. Since this is not removing the Deprecated API itself, can not cause any breakages a'la BEAM-168

LGTM (please self merge).


Add Project basic function

[x] Make a new file: ProjectSideBar.tsx in client/component/projects. Basic addProject function works. Please see Additional Notes below.

[x] install @types/uuid package to generate id fot ProjectId in ProjectSideBar.tsx

[x] in sideBar.tsx : import ProjectSideBar, add ProjectName to props, add useState for shoeProjectSideBarModal

Additional Notes:

basic addProject function works. There will be more logics to be added to handle some input edge cases.

The button no longer works once merge conflicts were resolved. Please fix the button.


Increased object spawning

Increase the object spawning rate slightly as the player keeps on playing the game and progressing.

Scrapped as this doesn't make sense having when there's level difficulties, which I didn't think of earlier.
Instead, additional work have been done on the player controller and a visual fix for the spikes.


Standardizing on codeblocks throughout

I think I found everything.

Adding cla: yes label, as the PR author is a googler at the time of this PR was created.


Back button

A link in the component is ok, but when we hit a back button, the link does not work anymore. Is this a known issue?

Can you provide more details so I can diagnose?

What are you using for history support? Hash or pushState?
Is the link intended to navigate to a registered route?
Is this across all browsers, or just certain ones?

No response from @adcoolguy, closing.


WARNING: CPU:0 [LOST XXX EVENTS  spew to screen

i would recommend  redirecting ioperf-snoop stderr output to >/dev/null, otherwise gui window would get scrambled by errors like shown in the screenshot.
maybe stderr could be captured separately and errors being printed in the status bar at the bottom/top.
iosnoop-perf -s 2>/dev/null| ./dsk-visualize.sh /dev/sda

Thanks for debugging, I've added redirection of stderr to /dev/null, as you suggested.


Rename to alert_generator

Signed-off-by: Richard Hartmann<EMAIL_ADDRESS>

Why renaming sounds like 2 different things. We would still need to test the AM interfaces.

The initial name was a mistake, this one matches what @codesome intends to implement.
A distinct Alertmanager test suite would also make sense, but I don't currently know of anyone planning to do the work. It might be possible to get people hours onto this EOY or early 2022.
We can put in another shim if you want.


MTL absorbers are complex when they have superclasses

This may be simpler than I think but I started to try and write the CanonicalEffect code for my PandocMonad class. PandocMonad has a superclass constraint of MonadError PandocError m that is, somewhere in Pandoc there is
class (MonadError PandocError m) => PandocMonad m where ...
and that seems to cause some weirdness:
-The ReifiedConstraint1 instance wouldn't compile, complaining about a functional
dependency.

I'm not sure how to write the superclass instance on ConstrainedAction PandocMonad itself, which I think looks like:

instance (Monad m
         , P.Reifies s' (P.Dict1 (MonadError PA.PandocError) m)) => MonadError PA.PandocError (P.ConstrainedAction PA.PandocMonad m s') where
  throwError e = P.ConstrainedAction $ throwError_ (P.reflect $ P.Proxy @s') e
  catchError x f = P.ConstrainedAction
    $ catchError_ (P.reflect $ P.Proxy @s') (P.action x) (P.action . f)

but throwError_ and catchError_ are not in scope.  Might just be an export issue?  But also feels like I'm just not seeing this clearly.
I haven't dug in yet so this is sort of preliminary but I wanted to signpost it here so I/we remember to document this and however we solve it, if it warrants explanation.

Maybe reflection can be of some inspiration:
https://github.com/ekmett/reflection/blob/49d1d6ad2355f4cb2061bff0c744feb8841cd6e1/examples/Constraints.hs#L75-L83

Okay.  Figured that out, I think.  Harder than the reflection example but that's likely because my brain frizzes a bit every time I see "Sub Dict" and it takes me a while to uncross the wires.
Anyway, solved it by (for the sake of documenting the process):

Adding throwError_ and catchError_ to the Dict1 associated data type
Using them to create the instance above.
Filling the canonical dictionary bit of this with throw and catch from Polysemy.Error.

Which all makes sense.
But now life is full of Oprhan instances!  GHC says:
Orphan instance: instance P.ReifiableConstraint1 PA.PandocMonad
    To avoid this
        move the instance declaration to the module of the class or of the type, or
        wrap the type with a newtype and declare the instance on the new type.
    |
195 | instance P.ReifiableConstraint1 PA.PandocMonad where
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^...

src/Knit/Effect/PandocMonad.hs:222:1: warning: [-Worphans]
    Orphan instance:
      instance (Monad m, P.Reifies s' (P.Dict1 PA.PandocMonad m)) =>
               MonadError PA.PandocError (P.ConstrainedAction PA.PandocMonad m s')

222 | instance (Monad m
    | ^^^^^^^^^^^^^^^^^...

src/Knit/Effect/PandocMonad.hs:229:1: warning: [-Worphans]
    Orphan instance:
      instance (Monad m,
                MonadError
                  PA.PandocError (P.ConstrainedAction PA.PandocMonad m s'),
                P.Reifies s' (P.Dict1 PA.PandocMonad m)) =>
               PA.PandocMonad (P.ConstrainedAction PA.PandocMonad m s')

229 | instance (Monad m
    | ^^^^^^^^^^^^^^^^^...

src/Knit/Effect/PandocMonad.hs:262:1: warning: [-Worphans]
    Orphan instance:
      instance P.Members '[P.Error PA.PandocError, Pandoc] r =>
               P.IsCanonicalEffect PA.PandocMonad r

Should i re-define all the absorb types locally to avoid this? I could then still get a working absorbPandocMonad which would compose.
GHC is not wrong.  I suppose we don't want different people making different "canonical" effects for, e.g., PandocMonad.  I could imagine scrapping the whole CanonicalEffect class and just writing each "absorb" function separately.  That's just sugar.  But the other two?
Hmm.  I'll keep thinking...

Here's a thought, which ties into another thing I've been thinking about.
We write each absorber in its own module, each exporting only the constraint-monomorphic abosrber.  And we name/organize them like

Polysemy.ConstraintAbsorber.MonadReader
Polysemy.ConstraintAbsorber.MonadState
etc.

It's a small amount of code replication, though we could use TH or something to write the boilerplate, which would genuinely be identical each time.  Since we don't export the classes, no orphan instances!  And it solves another problem which is that the module organization for anything not in that MTL module was going to be inconsistent with it.  But now they could all be consistent.
But it would move a bunch of code around now.  And make it slightly harder to write new ones.
I'm working on it a little.  Trying to make non-typeclass-driven using and absorb.  Then each absorber module can make a wrapper, a dictionary and a reified instance, none of which are exported, re-use the zoo's harsh and magical using and export a constraint-monomorphic absorber.  Might be a reasonable compromise.
Is it worth my making a PR so you can see what I have in mind? If we're going to re-organize modules, sooner is better, right?
Or maybe you have another idea for the orphans?

Sounds reasonable! I'd love to see a PR!

Closing since I found my way through.  But we should keep an eye out for non-trivial examples of absorbers we can write as examples.


UI error message seen when launching docker install for the first time

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

Do a docker install of rancher - command - docker run -d --privileged --restart=unless-stopped -p 80:80 -p 443:443 rancher/rancher:master-head

Access the rancher server URL. Given in the password and select Default View (first option)

Click on Next. Login fails with the following error.

Clicked on logout and login back.

User was able to login as admin successfully

Expected Result:
User should not be seeing "Cannot read property 'endsWith' of undefined" error while logging in
Other details that may be helpful:
Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): master-head - commit id: 343b8e19c
Installation option (single install/HA): single

gz#16875

Anyone found a fix for this?
I'm also seeing a similar issue on microk8s installing rancher with helm. Have tried both rancher-latest and rancher-stable The admin account can login fine, but any other accounts cannot. When logging in with another user you get the "Cannot read property 'endsWith' of undefined" error, clicking "reload" will then bring up a form to change the server URL, clicking save on this takes you back to the "Cannot read property 'endsWith' of undefined" error

is there any working versions at the moment?
faced the same problem with microk8s

首次启动很慢，需要耐心等待。密码查看可以使用命令：  docker exec -it   container-id reset-password

您的邮件本人已经收到，稍后回复你！或者致电：17600562066


update(cmake): bumped falcoctl to v0.7.1.

What type of PR is this?
/kind release
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

update(cmake): bumped falcoctl tool to v0.7.1.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.37.0

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [Andreagit97,FedeDP,LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


BIP353 address parser

feat: I implemented within the sdk the function to parse a BIP353 address and extract the corresponding bolt12 or lnurl-pay offer. To achieve that I needed a dns-resolver and I decided to use trust-dns-resolver crate.
feat: I edited the cli accepted inputs to be able to understand also a pay_code.
The idea behind my implementation is to use the already provided section regarding the final payment adding before that a parser layer to intercept BIP353 addresses and resolve it.

I tried to resolve all of your comment in the breez-sdk-greenlight repo inside the following PR https://github.com/breez/breez-sdk-greenlight/pull/1149.
I think this PR could be keep active because it requires some code that it is implemented inside the other one


Made AccordionItem toggleable through "isExpanded"

Related to this issue: https://github.com/equinor/design-system/issues/677
This change lets users change the AccordionItem expanded state from outside the component, by programatically changing the isExpanded-prop.

@imp-dance Could you please change your base branch from develop to typescript, and add this edit to the updated AccordionItem.tsx file as we are going to merge typescript into the develop branch soon 😅

@pomfrida I made a new PR for typescript branch, so closing this one 👍


Error when using Az k8s-configuration on mac

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az k8s-configuration flux create
Errors:
The command failed with an unexpected error. Here is the traceback:
Cannot load native module 'Crypto.PublicKey._ec_ws': Trying '_ec_ws.cpython-310-darwin.so': cannot load library '/Users/cf9536/.azure/cliextensions/k8s-configuration/Crypto/Util/../PublicKey/_ec_ws.cpython-310-darwin.so': dlopen(/Users/cf9536/.azure/cliextensions/k8s-configuration/Crypto/Util/../PublicKey/_ec_ws.cpython-310-darwin.so, 2): image not found.  Additionally, ctypes.util.find_library() did not manage to locate a library called '/Users/cf9536/.azure/cliextensions/k8s-configuration/Crypto/Util/../PublicKey/_ec_ws.cpython-310-darwin.so', Trying '_ec_ws.abi3.so': cannot load library '/Users/cf9536/.azure/cliextensions/k8s-configuration/Crypto/Util/../PublicKey/_ec_ws.abi3.so': dlopen(/Users/cf9536/.azure/cliextensions/k8s-configuration/Crypto/Util/../PublicKey/_ec_ws.abi3.so, 2): image not found.  Additionally, ctypes.util.find_library() did not manage to locate a library called '/Users/cf9536/.azure/cliextensions/k8s-configuration/Crypto/Util/../PublicKey/_ec_ws.abi3.so', Trying '_ec_ws.so': cannot load library '/Users/cf9536/.azure/cliextensions/k8s-configuration/Crypto/Util/../PublicKey/_ec_ws.so': dlopen(/Users/cf9536/.azure/cliextensions/k8s-configuration/Crypto/Util/../PublicKey/_ec_ws.so, 2): image not found.  Additionally, ctypes.util.find_library() did not manage to locate a library called '/Users/cf9536/.azure/cliextensions/k8s-configuration/Crypto/Util/../PublicKey/_ec_ws.so'
Traceback (most recent call last):
  File "/usr/local/Cellar/azure-cli/2.33.1/libexec/lib/python3.10/site-packages/knack/cli.py", line 231, in invoke
    cmd_result = self.invocation.execute(args)
  File "/usr/local/Cellar/azure-cli/2.33.1/libexec/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 556, in execute
    self.commands_loader.load_arguments(command)
  File "/usr/local/Cellar/azure-cli/2.33.1/libexec/lib/python3.10/site-packages/azure/cli/core/__init__.py", line 515, in load_arguments
    self.command_table[command].load_arguments()  # this loads the arguments via reflection
  File "/usr/local/Cellar/azure-cli/2.33.1/libexec/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 313, in load_arguments
    super(AzCliCommand, self).load_arguments()
  File "/usr/local/Cellar/azure-cli/2.33.1/libexec/lib/python3.10/site-packages/knack/commands.py", line 104, in load_arguments
    cmd_args = self.arguments_loader()
  File "/usr/local/Cellar/azure-cli/2.33.1/libexec/lib/python3.10/site-packages/azure/cli/core/commands/command_operation.py", line 125, in arguments_loader
    op = self.get_op_handler(self.op_path)
  File "/usr/local/Cellar/azure-cli/2.33.1/libexec/lib/python3.10/site-packages/azure/cli/core/commands/command_operation.py", line 59, in get_op_handler
    handler = import_module(mod_to_import)
  File<EMAIL_ADDRESS>line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/Users/cf9536/.azure/cliextensions/k8s-configuration/azext_k8s_configuration/providers/FluxConfigurationProvider.py", line 38, in <module>
    from ..validators import (
  File "/Users/cf9536/.azure/cliextensions/k8s-configuration/azext_k8s_configuration/validators.py", line 18, in <module>
    from Crypto.PublicKey import RSA, ECC, DSA
  File "/Users/cf9536/.azure/cliextensions/k8s-configuration/Crypto/PublicKey/ECC.py", line 58, in <module>
    _ec_lib = load_pycryptodome_raw_lib("Crypto.PublicKey._ec_ws", """
  File "/Users/cf9536/.azure/cliextensions/k8s-configuration/Crypto/Util/_raw_api.py", line 308, in load_pycryptodome_raw_lib
    raise OSError("Cannot load native module '%s': %s" % (name, ", ".join(attempts)))
OSError: Cannot load native module 'Crypto.PublicKey._ec_ws': Trying '_ec_ws.cpython-310-darwin.so': cannot load library '/Users/cf9536/.azure/cliextensions/k8s-configuration/Crypto/Util/../PublicKey/_ec_ws.cpython-310-darwin.so': dlopen(/Users/cf9536/.azure/cliextensions/k8s-configuration/Crypto/Util/../PublicKey/_ec_ws.cpython-310-darwin.so, 2): image not found.  Additionally, ctypes.util.find_library() did not manage to locate a library called '/Users/cf9536/.azure/cliextensions/k8s-configuration/Crypto/Util/../PublicKey/_ec_ws.cpython-310-darwin.so', Trying '_ec_ws.abi3.so': cannot load library '/Users/cf9536/.azure/cliextensions/k8s-configuration/Crypto/Util/../PublicKey/_ec_ws.abi3.so': dlopen(/Users/cf9536/.azure/cliextensions/k8s-configuration/Crypto/Util/../PublicKey/_ec_ws.abi3.so, 2): image not found.  Additionally, ctypes.util.find_library() did not manage to locate a library called '/Users/cf9536/.azure/cliextensions/k8s-configuration/Crypto/Util/../PublicKey/_ec_ws.abi3.so', Trying '_ec_ws.so': cannot load library '/Users/cf9536/.azure/cliextensions/k8s-configuration/Crypto/Util/../PublicKey/_ec_ws.so': dlopen(/Users/cf9536/.azure/cliextensions/k8s-configuration/Crypto/Util/../PublicKey/_ec_ws.so, 2): image not found.  Additionally, ctypes.util.find_library() did not manage to locate a library called '/Users/cf9536/.azure/cliextensions/k8s-configuration/Crypto/Util/../PublicKey/_ec_ws.so'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az k8s-configuration flux create

Expected Behavior
Environment Summary
macOS-11.6.2-x86_64-i386-64bit, Darwin 20.6.0
Python 3.10.2
Installer: HOMEBREW

azure-cli 2.33.1

Extensions:
k8s-configuration 1.4.1
connectedk8s 1.2.2
k8s-extension 1.0.4
azure-devops 0.23.0
ssh 1.0.0

Dependencies:
msal 1.16.0
azure-mgmt-resource 20.0.0

Additional Context

route to CXP team

The problem is using Python 3.10, while the k8s-configuration extension requires 3.8 when azure-cli requires 3.10.
And you cannot install azure-cli of older version than 2.33 ( the extension requires 2.16-2.29 )

Hello @chenfli
Please try the below suggestion...Ref

Running pip3 install pycryptodome in the pipeline