Configure the maximum number of Editor Groups

https://github.com/microsoft/vscode/issues/10859 was accidentally closed as a duplicate of https://github.com/microsoft/vscode/issues/9872 but the latter is about total tabs not the number of groups of tabs. It would be useful if opening 'side by side' could just alternate between two open groups

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Keep the Table Of Content when append to existing WIKI file

Azure DevOps Extensions
WIKI Updater
Is your feature request related to a problem? Please describe.
I would like to append my relase notes to an existing WIKI file, at the beginning of the file.
But on the first line I have the Table of Content : [[TOC]]
I would like to insert my release notes juste after the TOC.
[[_TOC_]]
# 2022-06-16 : Front Release 610 / Back Release 499

**Fonctionnalités:**
- #8931

**Bugs:**
- #9933

**Refactoring:**
- #8721

# 2022-03-21 : Front Release 606 / Back Release 487

**Fonctionnalités:**
- #8700

**Bugs:**
- #8552

Describe the solution you'd like
A new parameter to skip (and keep) the n first lines of the existing file.
Describe alternatives you've considered
Appending at the end of the file : but then the newest release notes is at the end of the file and we have to scroll the TOC to find it. It would be better UX to have the newest first.
Additional context
No response

I think your suggestion of 'skipping the first n lines' of the file will work. But I think I prefer a flag to 'inject the TOC' which removed any existing TOC (and and replace_ and adds a new one at the top of the file. I think this will be more robust.
Does that work for you?

would be perfect yes, thx !

Shipped as 1.41.5


Re-enable daily-data.spec e2e

Due to a slew of errors in Pagination, we had to disable a handful of tests within daily-data.spec. This ticket is, after we make UsePagination updates and fix the table using that pagination, to re-enable and fix these tests.
Blocked by: https://app.zenhub.com/workspaces/web-experience-607d9d5e68b95200150fec37/issues/gh/cdcgov/prime-reportstream/14238
Acceptance Criteria

[ ] Re-enable all daily-data.spec e2e tests and make them work properly
[ ] Convert tests to POM

Per Penny in Slack, Redundant for #15211.
Closing.


Allow the evaluator to add its results to an ORT file

Please have a look at the individual commit messages for the details.

This change is

Merging this despite the unrelated AppVeyor failure as other checks already completed successfully.


Update Copyright text in all files

Below is the text to use:
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

Done by @jeremymeng in #197


Nuimo reconnect

Precondition: vanilla onboarding
Description:
After a onboarded first nuimo, go out of range
and reconnect when back in range.
The nuimo reconnects sometimes but at certain point
stops reconnecting.

Solved with https://github.com/getsenic/senic-hub/pull/424


upgrade go 1.21 implement lint updater

Description
Upgrades Go version to 1.21.0 and updates GH actions to use go.mod instead of a hard-coded Go version. Also modifies golangCI to implement lint version updater.
Fixes #998
Quick checks:

[x] There is no other pull request for the same update/change.
[ ] I have written unit tests.
[x] I have made sure that the PR is of reasonable size and can be easily reviewed.

@simonl2002 acceptance issue


decompile: OOM on some contracts

Component
Heimdall (Core)
Have you ensured that you are up to date?

[X] Bifrost
[X] Heimdall

What version of Heimdall are you on?
heimdall 0.7.2
Operating System
Linux
Describe the bug
Installed with bifrost -v main 2 minutes ago
Got OOM on 128Gb RAM server, similar to https://github.com/Jon-Becker/heimdall-rs/issues/167
$ heimdall decompile --skip-resolving --rpc-url=https://rpc.ankr.com/eth 0x9baa53dD2aB408D9135e549831C06E5c6407bF1d
27-12-2023 17:19:24.081323070  info: ⠴ executing '0x01ffc9a7'
Killed

thank you for raising! i will investigate tonight

also wanted to mention that i really appreciate you opening all these issues, it really helps me improve the toolkit ;)

All the issues I submitted originated from the evmole benchmarks. After https://github.com/Jon-Becker/heimdall-rs/issues/167 fix, I successfully processed the largest1k dataset. Currently, I am attempting to run heimdall-rs on the random50k dataset, which has led to the discovery of new issues. There will probably be more, I will try to find time to send not only issues, but also MRs with fixes ;)


Update @since attributes for Mongoid client methods

Those methods had the word session instead of client in versions prior mongoid 5.0.0.
Thus it is irritating to say that the method default_client is available since version 3.0.0, since I can't call it in versions 3.0.0 or 4.0.0.

my bad, wrong repo


[DOCS] Extra bullet point in CONTRIBUTING.MD

Description
There is a extra bullet point, in CONTRIBUTING.MD
Screenshots

Wow, you just created your first issue on this project, that's so cool. Make sure to wait till you are allowed to work on this before you do and when you are allowed to, don't forget to mention this issue in your pull request [Automated]

i didn't notice that, you can work on it if you want

:tada: This issue has been resolved in version 1.11.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


fix(ci): adjust xwin timeout and revert xwin jobs being disabled

Summary
Reverts #8181 and #8182.
The fix is in b849f0f, which extends the run timeout to allow xwin to download the Windows SDK files, which can take 10+ minutes.
Closes https://github.com/rust-cross/cargo-xwin/issues/127
Test Plan
Existing CI should pass.
Notes
xwin jobs will take a long time the first time due to cache re-warming.

Thanks a bunch of identifying this issue!

I wonder if we should even be using xwin for the main Clippy job since it's ~as fast with the native setup?

I think the gain is more-so on the windows-latest-xlarge vs ubuntu-latest / costs and the speed that the job takes to start (total job speeds).
The runs perform the same, I mentioned it here https://github.com/astral-sh/uv/pull/3600#issuecomment-2113857365
iirc, I did compare windows-latest vs ubuntu-latest (not xlarge) and it was about 30s slower. xlarge was about the same for clippy.


Docusaurus2: Better favicon support

🚀 Feature
Support for adding multiple favicons/icons to a Docusaurus site. Ideally, a site should have different PNG icon sizes, a .ico favicon, and Apple Touch Icons, while Docusaurus only allows you to add one favicon file to your site.
Have you read the Contributing Guidelines on issues?
Yes
Motivation
Sites should look good on all platforms. Having different sizes of icons, as well as icons for things such as Desktop Shortcuts and website downloads, is important to a well-developed site.
Pitch
This isn't an absolutely necessary feature, and I'm not sure it should be included in the Docusaurus Core, but it would be good for SEO and UI.

I would love to create a plugin, based on https://realfavicongenerator.net, that takes a config object and a user-provided icon and automatically generates multiple different icons for different browsers and platforms, and includes them in the HTML head.

move it to https://v2.docusaurus.io/feedback
Sent with GitHawk


Dynamic lambda caching?

Does the dynamic lambda do some sort of caching? This results in the same "random" string every time. Works as a function node but then isn't selected or over writable.
local charset = "ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"
math.randomseed(os.clock())
local function randomString(length)
    local ret = {}
    local r
    for _ = 1, length do
        r = math.random(1, #charset)
        table.insert(ret, charset:sub(r, r))
    end
    return table.concat(ret)
end

dl(1, l.TM_FILENAME:upper():gsub("%.", "_") .. "_" .. randomString(6), {}),

The variables in the snippet environment (like TM_IFILENAME) keep the value for the snippet expansion, so maybe you could use l.RANDOM_HEX

l.RANDOM_HEX does work. Is there a way to reset the variables and allow a function call to work each time?

This also works but isn't as clean.
d(1, function(args, snip)
    return sn(
        nil,
        {
            i(
                1,
                snip.env.TM_FILENAME:upper():gsub("%.", "_")
                    .. "_"
                    .. randomString(6)
            ),
        }
    )
end, {}),

l.RANDOM_HEX does work. Is there a way to reset the variables and allow a function call to work each time?

Although this is a bit convoluted, you could override the __concat-metamethod on some table and pass that:
local charset = "ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789"
math.randomseed(os.clock())
local function randomString(length)
    local ret = {}
    local r
    for _ = 1, length do
        r = math.random(1, #charset)
        table.insert(ret, charset:sub(r, r))
    end
    return table.concat(ret)
end

local o = setmetatable({}, {
	__concat = function(x)
		return x .. randomString(6)
	end
})

ls.setup_snip_env()

ls.snip_expand(s("", {
	dl(2, l._1 .. o, 1), i(1), t"texttext"
}))

I think adding functions to (dynamic)lambda is a bit unnecessary, at that point one might just as well use regular dynamic/functionNode.


Replace Dark / Light button with the icons

Replace check box with icons using bootstrap

Please assign me

Please assign me this issue


fix: allow data with the same name as components

fixes #3411

This seems to break component type narrowing and fail the #3138 test of the latest commit: dc2432f4fe89e03209e3a6cdcec1a56a32f9f8f4

🤔 I'll take a look

Failing with another error :(

After thinking about it, I think this operation should not be done in Vue language tools, let's wait: https://github.com/vuejs/core/pull/3399
Thank you for your hard work!


fix: remove reference to kaoto-next styles

This fixes an issue with the build once you pull in the latest changes from @kaoto-next/ui.

Looks good to me.


Adding in support for a "No Project" setting for gcp:project, fixes #1168

fixes #1168

I like DisableGlobalProjectWarning much more then project: "No Project".
Can you please link the issue you are addressing and explain your fix in the PR body. If users see that the underlying issue is fixed, they should understand at minimum how to apply the fix for themselves.

Absolutely, will do.

@rshade have you had a chance to look at this again? Happy to help push this over the line!

Closing in favor of #2701


Remote typechecking

Hey there,
A key feature (while HHVM is broken on OS X) that would make Hack so much easier to work with is to take advantage of the client-server architecture the typechecker has.
Currently, I run HHVM in a Docker container (in a Boot2Docker VM) on an OS X host, and this works well enough (I can run the type checker through ssh and get the output in the console). It would be amazing if vim-hack could do the same: give it an SSH command that it will execute it's calls to hh_client/hh_server through.
Is this possible through Vim? I'm honestly unsure.

Is this possible through Vim? I'm honestly unsure.

So, I don't know the answer to the actual issue you're filing here -- @mxw probably does and can comment when he sees it. However, there are a couple of other options:

Write your code in a shared folder between the host and VM, so you can run hh_client directly on OS X with the existing support. (The issues with hh_server and shared folders only comes up when you are editing on a different machine than where hh_server is running.) Not necessarily great, but not super difficult to set up, and it should work right now :)
Over the next few months, I want to add a small hh_client into HHVM itself, so you can, for example, just poke it over an admin port and get your type errors that way, so hh_server can just run in the VM but tools like vim can have an easy way to get info out. This isn't built yet, and won't be for a while, but if doing the ssh thing in vim is hard, it might be worth just waiting for this.

I've had success pointing nuclide at https://github.com/fredemmott/nuclide-customization/blob/master/docker-hh_client instead of a real hh_client, similar would probably work for vim-hack

resolved by #40; this functionality is now provided via the LSP - see https://github.com/hhvm/vim-hack/blob/master/README.md for instructions.
If you're using LanguageClient-neovim, you can set the executable to something like ssh foo hh_client


Interesting, but incomplete docs.

Hey, this looks really cool.
Would it be possible to add some example usage, and maybe explain some more about what a scenario is in this context.

Thank you

Hi @data-envoy, yeah @tg666 did a lot of good work here. The documentation is in progress and we are currently working on other interesting projects. Below I attach the work in progress. If you want, you can start a PR.
For better UI testing, I recommend using the CMP administration that Crawler integrates, see https://github.com/68publishers/consent-management-platform. It's better than sending requests via Postman etc.
Docs
Script Samples
The following scenarios trigger the first 100 URLs found on the homepage, after clicking the consent modal - one accepts all, the other rejects all:
The following scenarios do the same, but open the settings modal and select only the specified category:
Basic Config Structure
{
  "options": {},
  "scenes": {
    "<scene name>": [
      {
        "action": "<action name>",
        "options": {}
      }
    ]
  },
  "entrypoint": {
    "url": "<url>",
    "scene": "<scene name>"
  }
}

Options
None of the options are required, but it is recommended to set at least maxRequests to avoid crawling the entire website. Here is a list of options:
A dot . indicates a nested object.

Option
Required
Default
Description

maxConcurrency
no
automatic
Maximum concurrency, the crawler automatically scales the pool, but it may not always estimate correctly, so there is an option to limit it from above to ensure server capability.

maxRequests
no
-
Maximum number of requests. It can be slightly exceeded as already started requests are allowed to finish after reaching the limit.

maxRequestRetries
no
0
How many times a single request can be retried if it fails or returns a negative status code.

viewport.width
no
?
Width of the viewport, default value is unknown.

viewport.height
no
?
Height of the viewport, default value is unknown.

session.maxPoolSize
no
1000
Maximum number of browser sessions.

session.maxSessionUsageCount
no
-
Maximum number of times a single browser session can be used.

session.transferredCookies
no
-
Array of cookie names to be transferred from the previous request.

waitUntil
no
networkidle0
One of the values "load", "domcontentloaded", "networkidle0", or "networkidle2". See https://pptr.dev/api/puppeteer.puppeteerlifecycleevent for details.

Scenes
A script consists of individual "scenes". One is always the main scene that is executed first - defined in the entrypoint. Others are used for instructions on subsequent sub-pages, or one scene can call another, etc.
A scene is essentially an array of actions.
Entrypoint
Only two required attributes

url → where to start
scene → the name of the scene to start with

Actions
click
click - clicks on an element

Option
Required
Default
Description

selector
yes
-
CSS selector or Xpath

button
no
"left"
"left" or "right" - mouse button

clickCount
no
1
Number of times to click

delay
no
0
Delay after each click

xpath
no
false
Specifies if the selector is xpath

clickWithRedirect
clickWithRedirect - clicks on an element (typically a link) and waits for redirection

Option
Required
Default
Description

selector
yes
-
CSS selector or Xpath

delay
no
0
Delay after click

xpath
no
false
Specifies if the selector is xpath

waitUntil
no
"networkidle0"
One of the values "load", "domcontentloaded", "networkidle0", or "networkidle2". See https://pptr.dev/api/puppeteer.puppeteerlifecycleevent for details.

collectCookies
collectCookies - collects cookies from the page, no options required
delay
delay - processing waits for the specified time before continuing

Option
Required
Default
Description

delay
yes
-
Delay in milliseconds - 1000 = 1s

enqueueLinks
enqueueLinks - finds links on the page and adds them to the request queue

Option
Required
Default
Description

strategy
yes
-
One of the values "all", "same-hostname", "same-domain", "same-origin", or "manual"

scene
yes
-
Name of the scene to be executed after the page is loaded

urls
yes, if strategy is manual
-
Array of URLs, simply used for manually running specific URLs

selector
no
a
CSS selector, can be used to find links only within a specific element by setting it to .my-element, for example

exclude
no
[]
Array of regular expressions, if a link matches any of them, it is skipped

limit
no
-
Maximum number of links to be found

baseUrl
no
-
Base URL for relative links. Usually not necessary to set, as it resolves automatically from the original URL. However, if we were to navigate to a page from a completely different website (e.g., from google), it needs to be set, otherwise it would resolve as http://google.com/

enqueueLinksByClicking
enqueueLinksByClicking - same purpose as enqueueLinks, but the links are added to the queue by clicking on them

Option
Required
Default
Description

scene
yes
-
Name of the scene to be executed after the page is loaded

selector
yes
-
CSS selector of the link to be clicked

focus
focus - focuses on the specified element

Option
Required
Default
Description

selector
yes
-
CSS selector of the element

hover
hover - hovers the mouse over the specified selector

Option
Required
Default
Description

selector
yes
-
CSS selector of the element

keyboardPress
keyboardPress - presses a specific key

Option
Required
Default
Description

key
yes
-
Key name, see https://pptr.dev/api/puppeteer.keyinput for available options

runScene
runScene - executes a "sub-scenario"

Option
Required
Default
Description

scene
yes
-
Name of the scenario

runSceneConditionally
runSceneConditionally - executes a scenario if a condition is met

Option
Required
Default
Description

condition
yes
-
Object defining the condition

thenRun
yes
-
Name of the scenario to execute if the condition is true

elseRun
no
-
Name of the scenario to execute if the condition is false

The condition has a structure similar to actions { "type": "", "options": {} }.
Currently, only one condition is implemented, see the Conditions section.
screenshot
screenshot - takes a screenshot

Option
Required
Default
Description

name
yes
-
Name of the screenshot (not the file name, but the displayed name)

select
select - selects a value from a select box

Option
Required
Default
Description

selector
yes
-
CSS selector of the element

value
yes
-
Value to be selected

type
type - types a value into an input/textarea

Option
Required
Default
Description

selector
yes
-
CSS selector of the element

value
yes
-
Value to be typed

delay
no
-
Delay between typing each character

waitForSelector
waitForSelector - waits until the specified element appears on the page. If it is not found before the timeout, processing of the page fails

Option
Required
Default
Description

selector
yes
-
CSS selector of the element

hidden
no
false
If set to true, waits until the element becomes invisible (display: none or visibility: hidden)

visible
no
false
If set to true, waits until the element becomes visible

Todo I forgot to include the option to set the timeout in the description, so by default it is set to 30 seconds.
Other supported actions that are not used in CMP:
collectData
collectData - collects data from the page. Options include an object where the keys are the names of the individual values, and under each key is an object with options, e.g.
{
  "action": "collectData",
  "options": {
    "page_title": {
      /* ... */
    },
    "images": {
      /* ... */
    }
  }
}

For each key, the options are:

Option
Required
Default
Description

strategy
yes
-
One of the values "static", "selector.innerText", or "selector.attribute"

value
yes, if the strategy is static
-
Any value to be saved

selector
yes, if the strategy is selector.innerText or selector.attribute
-
CSS selector

attribute
yes, if the strategy is selector.attribute
-
Name of the HTML attribute

multiple
no
false
Specifies if there are multiple values - if set to false, only the first element is searched, if true, all elements are searched and the value is stored as an array.

setIdentity
setIdentity - sets an "identity" for the collected data. It is always called before calling collectData

Option
Required
Default
Description

strategy
yes
-
One of the values "static", "selector.innerText", or "selector.attribute"

identity
yes, if the strategy is static
-
Any value (identity)

selector
yes, if the strategy is selector.innerText or selector.attribute
-
CSS selector

attribute
yes, if the strategy is selector.attribute
-
Name of the HTML attribute

Conditions
isElementVisible
isElementVisible - returns true if the element exists on the page and is visible

Option
Required
Default
Description

selector
yes
-
CSS selector

Oh wow, that looks super helpful! It sould be enough to try things out. Sorry, I don't have time right now to make a PR, but maybe in the future. Thank you


Quick-fix to add an import leaves // ignore: comment on the wrong line

Quick-fix to add an import doesn't respect // ignore: implementation imports comment.

Generally I think it would be reasonable for the quick fix to keep all existing comments grouped with the associated import even if the comment does not have semantic meaning as in the case of ignore: comments.

https://dart-review.googlesource.com/c/sdk/+/45526


Update log directory

Addresses https://github.com/aspnet/AspNetCore/issues/7316.
The issue is that the log directory for functional test logs is by default $(RepoRoot)artifacts\log\ but our ci configuration publishes artifacts\logs\ instead.
There's a bunch of different ways to fix this:

Change the directory in ci.yml
Change the default functional test log from artifacts\log to artifacts\logs
Set an environment variable to override the default log output dir.

I opted for 1. but can easily go with another approach, especially if artifacts/logs/ is a better conventionl.

+1, this contributes to #7280 (convert to arcade) as artifacts/log/ is the Arcade convention.
Can we take this a step further and update everything to use this folder? Add this to build/repo.props to override the KoreBuild default:
<LogOutputDir>$(ArtifactsDir)log\</LogOutputDir>


Chrome throwing "Connection Not private" when clicking on email button

Trying to send emails with verify button. On chrome it throws an error that my connection is not private. Any idea how I can fix this?

Hello @tomjohnburton,
Thanks for submitting a GitHub issue! We are very sorry that you are running into this problem. In order to better serve you, as this does not present itself as a library specific issue, we would like to ask that you reach out to our support team at https://support.sendgrid.com.
Thank you!
SendGrid DX Team


Take a look at kubespray hardening guide

What should be investigated.
What technology/product/concept should be investigated?
We should go through the hardening guide in kubespray and take a look if there's some new updates we can do to the default config to improve our security posture.
By taking a quick look there seems to be some things that we might want to have, e.g. tls_min_version, some new admission like EventRateLimit etc.
What artifacts should this produce.
How should the knowledge gathered from this task be captured.

Updated default configs (if any found)

Duplicate of https://github.com/elastisys/compliantkubernetes-kubespray/issues/213


Pretrained model add "name" to table

add field name to pretrained model (kind of nickname for model)
add migrations for pretrained models for each of the domains, using a CSV file (I will fill in some pretrained models)

@fracpete How do you want to specify the data field for the model (contains the model's file data)?

@fracpete How do you want to specify the data field for the model (contains the model's file data)?

Is this the purpose of #44?

The files for the pretrained models should use the same backend as the datasets, so you never store the model data itself in the database (some of the models are several 100MB). And yes, the facade (#44) would allow us to defne a large model zoo, without taking up any disk space (only the ones you actually use will get downloaded).

add field name to pretrained model (kind of nickname for model)

This is implemented in commit be3eeee4dfe60649812f19c9501eed518fab493e

add migrations for pretrained models for each of the domains, using a CSV file (I will fill in some pretrained models)

This is implemented in commit fc3b755f864974874e21314cc97e143a5a533027


[DOC] Please resurrect the targeted 'Integrate django CMS into an existing project' page.

Description
It would be a tremendous asset to update/bring back the Integrate django CMS into an existing project
, separately from the install by hand section, which assumes project creation. I suspect there are quite a few potential adopters (like myself) out there who already have established projects and want to begin integrating Django-CMS, rather than creating a new project. This has the added benefit of giving such users exposure and recruiting them into the fold.
Having a distinct page that directly, quickly and with less mental gymnastics on their part than the install by hand page asks of them addresses their needs clearly would raise the profile of Django-CMS. And help them (and me) out. :D
Screenshots
N/A
Additional information (CMS/Python/Django versions)
From what I can tell, this page disappeared after version 3.0.12 of Django-CMS.
Do you want to help fix this documentation issue?

[ ] Yes, I want to help fix this issue and I will join #workgroup-documentation on Slack to confirm with the team that a PR is welcome.

[x] No, I only want to report the issue.

thx @changeling our voluntary documentation workgroup will look into it.

Thank you, @NicolaiRidani. This is the single most useful thing I'd like to see, a streamlined integration flow, to try Django-CMS on one of my own sites as a potential blog backend. I really appreciate how responsive y'all are.

Has this issue been addressed?

@changeling not yet as far as I'm aware.

Any progress on this?

No, so far not. Would you like to give it a stab?


build: configure Angular v18 in Renovate via shared config

#594  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @davidlj95 and the rest of your teammates on  Graphite


[$250] Default rooms are not grayed out when creating a new workspace while offline

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Sign in with any account
Go offline
Click the green plus at the bottom, New workspace. Or if you already have a workspace click the avatar in the header to open the settings, click on a workspace, click the 3 vertical dots at the top, New workspace.

Expected Result:
The default rooms, #admins, #announce, and the workspace expense chat should be grayed out in the LHN and on the search page. When navigating to any of these rooms the whole room should be grayed out (50% opacity).
Actual Result:
The default rooms are not grayed out (50% opacity).
Workaround:
Ignore it
Platform:

All platforms

Web
iOS
Android
Desktop App
Mobile Web

Version Number: v1.2.18-10
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/26260477/198112025-cf40f3df-9dbb-4ceb-b93b-bd8a97156a69.mov
Expensify/Expensify Issue URL:
Issue reported by: @neil-marcellini
Slack conversation:
View all open jobs on GitHub

Not overdue, engineering triage!

@grgia - Are you recommending the External label on this? Did you triage it as an engineer or am I to triage it as a CM?

Internal job posting: https://www.upwork.com/ab/applicants/1587582985521102848/suggested

External job posting: https://www.upwork.com/jobs/~01cf8f22223f210999

Hey @strepanier03, just dropping a note as a reminder to keep the pressure on to find a contributor and get this one closed out. This was just posted a few days ago so not much more you can do at this moment, but let's get clear on your question for @grgia (above):

@grgia - Are you recommending the External label on this?

Adding the daily label back btw! There's more recent context in slack here for reference.

Proposal
Problem
In https://github.com/Expensify/App/blob/0724337138a4d80f6603074cc9af5c186cb524ec/src/libs/ReportUtils.js#L817-L852
when build the optimistic data for default chat report (admin, announce) we don't set pendingFields for them so In https://github.com/Expensify/App/blob/0724337138a4d80f6603074cc9af5c186cb524ec/src/components/LHNOptionsList/OptionRowLHN.js#L102
and https://github.com/Expensify/App/blob/0724337138a4d80f6603074cc9af5c186cb524ec/src/components/OptionRow.js#L136
the pendingAction is null
=> the logic that enable opacity is not applied
Solution
In https://github.com/Expensify/App/blob/0724337138a4d80f6603074cc9af5c186cb524ec/src/libs/ReportUtils.js#L817
I'll add pendingFields with createChat ='add'
        statusNum: 0,
        visibility,
+        pendingFields: {
+            createChat: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
+        }
    };

https://user-images.githubusercontent.com/113963320/200283688-86463677-4c6c-4c08-b906-a16b5a3e0bdd.mp4

@eVoloshchak - Looks like there is a proposal to review for this.
When you get a chance please review and if you are okay with the solution ping the CME Monil so they can give their sign off as well.

when build the optimistic data for default chat report (admin, announce) we don't set pendingFields for them

@tienifr, thanks for the proposal, makes sense

I'll add pendingFields with createChat ='add'

This is indeed resolving the issue. Only thing I'm afraid of is that it will introduce issues with chat creation. @tienifr, we're calling buildOptimisticChatReport in a couple of places, is adding pendingFields to all of them safe?

@eVoloshchak we're using buildOptimisticChatReport in 4 places: announceChatData, adminsChatData, expenseChatData, policyReport.
As we can see the result above when pendingFields of announceChatData, adminsChatData, expenseChatData are updated to null when we go online.
Here is the evidence of creating new policyReport:
https://user-images.githubusercontent.com/113963320/200779111-921de183-d7b4-4a51-adec-1a7ef7f80742.mp4

@tienifr thank you for checking this

we're using buildOptimisticChatReport in 4 places: announceChatData, adminsChatData, expenseChatData, policyReport.

Correct me if I'm wrong, but I can see it being used in 9 places (in requestMoney, createSplitsAndOnyxData, getOrCreateChatReport, etc)

@tienifr - Just a friendly bump to response to the comment from @eVoloshchak here. Thanks
I am out of the office tomorrow. If there is an urgent need on this GH from a BugZero team member, please post in #expensify-open-source for assistance.

Hi @eVoloshchak We are using buildOptimisticChatReport in 8 places
In /Expensify/App/src/libs/ReportUtils.js

line 901: announceChatData  (for creating workspace )
line 917: adminsChatData  (for creating workspace )
line 929: expenseChatData   (for creating workspace )
(But after using buildOptimisticChatReport in 3 above places, we update directly to Oynx and don't update pendingField and it causes this issue)

In /Expensify/App/src/libs/actions/IOU.js
4. line 63: chatReport (for creating request money )
5. line 245: groupChatReport (for creating split bill)
6. line 331: oneOnOneChatReport (for creating split bill)
In /Expensify/App/src/libs/actions/Report.js
7. line 569:    newChat = ReportUtils.buildOptimisticChatReport(formattedUserLogins); (for opening and entering chat)
8. line 1057: const policyReport = ReportUtils.buildOptimisticChatReport(...) (for creating room)
--> In 5 above places (4->8) after using buildOptimisticChatReport in 3 places, we update pendingFields: {createChat: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD} before syncing to Oynx
So I suggest 2 solutions to this problem
Solution 1
We only update pendingField in the first 3 places (1-->3)
the sample PR: https://github.com/Expensify/App/pull/12664
I tested and it worked correctly
https://user-images.githubusercontent.com/113963320/201303589-cd0defcf-3aba-4be3-bd48-acaa35874e5d.mp4
Solution 2
In https://github.com/Expensify/App/blob/0724337138a4d80f6603074cc9af5c186cb524ec/src/libs/ReportUtils.js#L817
I'll add pendingFields with createChat ='add'
        statusNum: 0,
        visibility,
+        pendingFields: {
+            createChat: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,
+        }
    };

and remove updating pendingFields manually in other places (4-->8)
The sample PR: https://github.com/Expensify/App/pull/12663
I tested it in all places and it worked correctly
https://user-images.githubusercontent.com/113963320/201309120-bcde4ab6-b26a-439e-b96c-e791d7c4dbe9.mp4

Solution 1
We only update pendingField in the first 3 places (1-->3)
the sample PR: #12664

I like @tienifr proposal
I think we should go with the first solution since it adds pending actions only for the rooms we need to be greyed out
@MonilBhavsar, could you help me out, are there any default rooms besides #admins and #announce?
The issue description states The default rooms, #admins, #announce, and the workspace expense, which implies there are other default rooms

@MonilBhavsar - Just a friendly bump on @eVoloshchak's comment.
Based on the recreation video in the OP post though, I think the "workspace expense" room is the one named "Workspace", right above the admin and announce rooms.

If you agree with the proposal and hiring @tienifr, just let me know and I'll take care of the next steps.

Will check tomorrow for an update.

Sorry missed this.
Default rooms include - Workspace room, #admins, #announce and domain default group. In this specific issue, I think we'll be taking into account Workspace room, #admins and #announce as they are related to a Workspace

@MonilBhavsar, thank you!
In that case Solution 1 of @tienifr's proposal looks good to me
🎀👀🎀 C+ reviewed!

The job post is here, please apply and I'll monitor for applications.
@tienifr - As a reminder, I wanted to link to the new process change regarding PR merge and bonuses here. You can read more about it in the CONTRIBUTING.md as well.

Thanks @strepanier03, I've applied to the job, the PR will be ready by November 18

@strepanier03 I was left to review the proposal 😅

I also like the proposal 1 👍

Hi @eVoloshchak @MonilBhavsar I just created PR for this issue: https://github.com/Expensify/App/pull/12664 please help to review it

Aaah, sorry about that @MonilBhavsar! I misunderstood where the conversation was at and thought you were on board with the solution because of the discussion about the rooms. I will wait for more explicit approval from the CME moving forward.

@eVoloshchak and @MonilBhavsar - The PR from @tienifr has been submitted and is needing review.

Hi @eVoloshchak  This PR is created 4 days ago, please help to review it. Thanks

Hi, @tienifr!
I've found a bug and left a comment on the PR, please check it out

PR is merged!

Waiting for deploy...

Thank you for the updates @MonilBhavsar - I'll continue following along until I can take further action.

On staging, will check again tomorrow.

Still on staging.

I am OoO for jury duty tomorrow. If immediate action is needed on this GH please post in #expensify-open-source for assistance, thank you.

Not overdue, was deployed to staging 13 days ago

The associated PR was deployed to production earlier last week in this release. Not sure why i didn't post the message here. We can do the checklist manually and close this issue as it has already been 7 days since it was deployed to production

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.2.31-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/12664

If no regressions arise, payment will be issued on 2022-12-02. :confetti_ball:
After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

[ ] External issue reporter
[ ] Contributor that fixed the issue
[ ] Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@eVoloshchak / @MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@eVoloshchak / @MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@eVoloshchak / @MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@strepanier03] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here:

@tienifr and @eVoloshchak - Please apply for the job here. I'll check back tomorrow and accept/pay as applicable.

I'll work on the TR, this seems like a good thing to test for if we're not already.

Not sure what happened but the job posting is closed now and I can't reopen it.

I made a new posting for @tienifr and @eVoloshchak to apply for, please do that here and I'll check in again to accept and pay.

@eVoloshchak @MonilBhavsar - The three tasks below from the checklist still need to be handled.

[ ]  [@eVoloshchak / @MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
[ ]  [@eVoloshchak / @MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ]  [@eVoloshchak / @MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

@strepanier03 I've applied to the job
Thanks!

Thank you both, offers sent and will check tomorrow.

@eVoloshchak and @MonilBhavsar - Any chance the rest of the checklist can be wrapped up before the end of the week?

Paid @tienifr, thank you!

The PR that introduced the bug has been identified. Link to the PR:

I think it's https://github.com/Expensify/App/pull/10723, but i wouldn't say it 'introduced' the bug

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

It seems it was the expected result at the time judging by how pendingAction  was added for some chats, but not these specifically

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

We have an item in the checklist that should have prevented this: I turned off my network connection and tested it while offline to ensure it matches the expected behavior. Not sure we can catch this type of bug sooner with anything but thorough testing

Thank you @eVoloshchak- I'll update the OG checklist with your comments for clarity.
I've also paid your contract in UpWork.

I won't get to the regression test stuff until next week.

Thank you @MonilBhavsar for that, I was having a hard time prioritizing.
That was the last bit before closing so I agree and will wrap this up.


HDDS-4793. Allow recon access /dbCheckpoint in ozonesecure-om-ha

What changes were proposed in this pull request?
Add<EMAIL_ADDRESS>to ozone.administrators in ozonesecure-om-ha as suggested by the error message:
om1_1 | ERROR om.OMDBCheckpointServlet: Permission denied: User principal<EMAIL_ADDRESS>does not have access to /dbCheckpoint.
om1_1 | This can happen when Ozone Manager is started with a different user.
om1_1 | Please append<EMAIL_ADDRESS>to OM 'ozone.administrators' config and restart OM to grant current user access to this endpoint.

https://issues.apache.org/jira/browse/HDDS-4793
How was this patch tested?
cd hadoop-ozone/dist/target/ozone-1.1.0-SNAPSHOT/compose/ozonesecure-om-ha
KEEP_RUNNING=true ./test.sh
docker-compose logs om1 om2 om3 | grep Checkpoint
...
om1_1 | [...] INFO om.OMDBCheckpointServlet: Received request to obtain OM DB checkpoint snapshot
om1_1 | [...] INFO db.RDBCheckpointManager: Created checkpoint at /data/metadata/db.checkpoints/rdb_rdb_checkpoint_1612468871049 in 15 milliseconds
om1_1 | [...] INFO om.OMDBCheckpointServlet: Time taken to write the checkpoint to response output stream: 30 milliseconds
om1_1 | [...] INFO db.RocksDBCheckpoint: Cleaning up RocksDB checkpoint at /data/metadata/db.checkpoints/rdb_rdb_checkpoint_1612468871049

https://github.com/adoroszlai/hadoop-ozone/runs/1833972692

Thank You @adoroszlai for the contribution and for identifying the issue.

Thanks @bharatviswa504 for reviewing and committing it.


Testflightnotif

Name of the PR
:recycle: Current situation & Problem
Describe the current situation (if possible, with an exemplary (or real) code snippet and/or where this is used)
Please link any open issue that is addressed with this PR
:bulb: Proposed solution
Describe the solution and how this affects the project and internal structure
:gear: Release Notes
Add a summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented if it appends or changes the public interface.
:heavy_plus_sign: Additional Information
Provide some additional information if possible
Related PRs
Reference the related PRs
Testing
Are there tests included? If yes, which situations are tested, and which corner cases are missing?
Reviewer Nudging
Where should the reviewer start? Where is a good entry point?
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

[ ] I agree to follow the Code of Conduct and Contributing Guidelines.

lgtm!

@riyakaru Thank you for the PR!
It would also be great if you can change the firebase emulator settings in PAWSModules/Sources/PAWSSharedContext/FeatureFlags.swift back to the following state:
public static let useFirebaseEmulator = true


Update GitHub token regex in sample config

The format of GitHub tokens changed back in April.  This PR updates the regex given in the sample config to match, based on  the information here and here.

Codecov Report

Merging #108 (083d7a4) into master (d724f18) will increase coverage by 27.56%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #108       +/-   ##
===========================================
+ Coverage   44.45%   72.01%   +27.56%
===========================================
  Files           9       10        +1
  Lines         893      897        +4
  Branches      134      134
===========================================
+ Hits          397      646      +249
+ Misses        495      197      -298
- Partials        1       54       +53

Impacted Files
Coverage Δ

src/tinuous/_version.py
100.00% <0.00%> (ø)

src/tinuous/util.py
86.36% <0.00%> (+6.81%)
:arrow_up:

src/tinuous/config.py
92.63% <0.00%> (+18.94%)
:arrow_up:

src/tinuous/github.py
51.00% <0.00%> (+20.50%)
:arrow_up:

src/tinuous/base.py
87.30% <0.00%> (+25.39%)
:arrow_up:

src/tinuous/travis.py
63.63% <0.00%> (+35.45%)
:arrow_up:

src/tinuous/appveyor.py
76.19% <0.00%> (+44.04%)
:arrow_up:

src/tinuous/__main__.py
55.38% <0.00%> (+55.38%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d724f18...083d7a4. Read the comment docs.

Interesting, I have managed to miss/not spot the change -- it is good news though since makes it easier to avoid false positives. Thank you!


cannot run with cmd code in readme.md

the inference code starts with ./cell_segmentation/inference/cell_detection.py but no such python file in the project.
and the only file named with similar struct ./nuclei_detection/inference/nuclei_detection.py has no main code.
if the true inference starting file is ./run_inference_wsi.py, pls correct ur readme.

Same question. the script of run_interence_wsi.py reports '''
requests.exceptions.ProxyError: (MaxRetryError("HTTPSConnectionPool(host='huggingface.co', port=443): Max retries exceeded with url: /timm/fastvit_s12.apple_in1k/resolve/main/model.safetensors (Caused by ProxyError('Unable to connect to proxy', SSLError(SSLEOFError(8, 'EOF occurred in violation of protocol (_ssl.c:997)'))))"), '(Request ID: a9fd552a-49a6-4f32-9187-ef3b32fe1b8e)')
'''

the inference code starts with ./cell_segmentation/inference/cell_detection.py but no such python file in the project. and the only file named with similar struct ./nuclei_detection/inference/nuclei_detection.py has no main code. if the true inference starting file is ./run_inference_wsi.py, pls correct ur readme.

I'm going to update the repository, thanks.

Same question. the script of run_interence_wsi.py reports ''' requests.exceptions.ProxyError: (MaxRetryError("HTTPSConnectionPool(host='huggingface.co', port=443): Max retries exceeded with url: /timm/fastvit_s12.apple_in1k/resolve/main/model.safetensors (Caused by ProxyError('Unable to connect to proxy', SSLError(SSLEOFError(8, 'EOF occurred in violation of protocol (_ssl.c:997)'))))"), '(Request ID: a9fd552a-49a6-4f32-9187-ef3b32fe1b8e)') '''

Probably the problem is in timm package. I'll check soon.


checkout current file at commit

close #914

added git: checkout current file at commit in the command palette
added a new action checkout current file at commit in log panel for the current file.

Actually, shall we deprecate git: checkout current file and replace it with git: checkout current file at commit?

I never used it myself...  from the name it sounds like it would "checkout the file at current HEAD (i.e reset staged changes)".
Does git: checkout current file offer any other functionality other than git: checkout current file at commit ?

Agreed then, if anything leaving both is just confusing.

I've removed the original git: checkout current file and added a confirmation dialog.


Windows build seems successful but no binary produced

I run "script\build"  followed "https://github.com/atom/atom/blob/master/docs/build-instructions/windows.md", but I cann't found Program Files directory.
Here is my cmd execution info
E:\code\atom\atom>script\build
Node: v0.10.34
npm: v1.4.28
Python: v2.7.8
Installing build modules...
Installing apm...
Installing modules done
Deduping modules done
Running "download-atom-shell" task
E:\code\atom\atom>

It looks like it didn't complete, can you run script\build --stack to get more output?

Well, I tried "script\build --stack", it does give me some error infomation
E:\code\atom\atom>script\build --stack
Node: v0.10.34
npm: v1.4.28
Python: v2.7.8
Installing build modules...
Installing apm...
Installing modules done
Deduping modules done
Running "download-atom-shell" task
Error: CERT_UNTRUSTED
  at SecurePair.<anonymous> (tls.js:1381:32)
  at SecurePair.emit (events.js:92:17)
  at SecurePair.maybeInitFinished (tls.js:980:10)
  at CleartextStream.read [as _read] (tls.js:472:13)
  at CleartextStream.Readable.read (_stream_readable.js:341:10)
  at EncryptedStream.write [as _write] (tls.js:369:25)
  at doWrite (_stream_writable.js:226:10)
  at writeOrBuffer (_stream_writable.js:216:5)
  at EncryptedStream.Writable.write (_stream_writable.js:183:11)
  at write (_stream_readable.js:602:24)
  at flow (_stream_readable.js:611:7)
  at Socket.pipeOnReadable (_stream_readable.js:643:5)
  at Socket.emit (events.js:92:17)
  at emitReadable_ (_stream_readable.js:427:10)
  at emitReadable (_stream_readable.js:423:5)
  at readableAddChunk (_stream_readable.js:166:9)
  at Socket.Readable.push (_stream_readable.js:128:10)
  at TCP.onread (net.js:529:21)

But I don't know how to solve it.

It's a bug of node v0.10.34, see node v0.10.34 causes untrusted cert errors.
Just update node to v0.10.35+ to fix this problem

Also notice that the output location of build binary is "%ProgramFiles%\Atom"(It's "C:\Program Files\Atom" for me) system path, not in the current directory.
Instructions
# Use the `Git Shell` app which was installed by GitHub for Windows. Also Make
# sure you have logged into the GitHub for Windows GUI App.
cd C:\
git clone https://github.com/atom/atom/
cd atom
script/build # Creates application in the `"%ProgramFiles%\Atom"` directory

Closing this out since it was resolved as a node issue fixed by upgrading versions.


iOS Consumables stuck in unfinished state

If you are creating an issue for a BUG please fill out this information. If you are asking a question or requesting a feature you can delete the sections below.
Failure to fill out this information will result in this issue being closed. If you post a full stack trace in a bug it will be closed, please post it to http://gist.github.com and then post the link here.
Bug Information
Version Number of Plugin:  <IP_ADDRESS> (and using latest from GitHub)
Device Tested On: iPhone 5s
Simulator Tested On: N/A
Version of VS: VS 2017 v15.4.4
Version of Xamarin:  <IP_ADDRESS>
Steps to reproduce the Behavior
Start purchase of a consumable and have an exception prevent the library from calling the FinishTransaction.  This leaves the consumable in a Purchased state in the store.  When the user attempts to purchase again they receive the Apple message "This In-App Purchase has already been bought.  It will be restored for free.".  After the user clicks ok, the InAppBillingPlugin library never completes the Task.  The user is not able to re-purchase this consumable.
The item is returned from GetPurchasesAsync call even though it is a consumable.
I modified the RestoreAsync method in the iOS InAppBillingImplementation class to call the FinishTransaction.  This removed the consumable item from the user and allowed it to be purchase again.  However, I don't think this is the correct approach.
Expected Behavior
It would be nice if the call to PurchaseAsync could detect the orphaned transaction, complete it, then pass the purchase details back to the calling application.
I tried my best to set breakpoints all over the implementation class but could not find any callbacks from the AddPayment call.  The handler doesn't seem to be called in this scenario.
So, if my expected behavior isn't possible, it would be nice if the calling application had the option to "consume / finalize transaction" for this item after calling GetPurchasesAsync similar to the Android implementation.
Actual Behavior
No information is returned to the application about the purchase when calling PurchaseAsync.  The task never completes.
When calling GetPurchasesAsync, the consumable item comes back with the following info:
{ProductId:coin500 | AutoRenewing:False | State:Purchased | Id:1000000363989250}

Can verify this happens to me as well.

I have the same issue as well.

I have this problem too...

I have the same problem.
This is quite a main issue as when iOS prompt user to add a new payment method it stucks the purchased item in this pending state.

Ok so I managed to find a workaround.
When my app starts, I check if there is an item with the PurchaseState.Purchased in the list returned by GetPurchasesAsync, if there is, I activate the product on my server.
Then in order to make the item disappear from the purchased products list for the AppStore Account, I finish the transaction. To do so, I downloaded the library and wrote a new method :
public async override Task<bool> FinishTransaction(InAppBillingPurchase purchase)
		{
			var purchases = await RestoreAsync();

			if (purchases == null)
				return false;

			var transaction = purchases.Where(p => p.TransactionIdentifier == purchase.Id).FirstOrDefault();
			if (transaction != null)
				SKPaymentQueue.DefaultQueue.FinishTransaction(transaction);

			return true;
		}

In my code, I do:
var purchases = await CrossInAppBilling.Current.GetPurchasesAsync(ItemType.Subscription);

            if (purchases.Where(p => p.State == PurchaseState.Purchased).Any())
            {
                var purchase = purchases.Where(p => p.State == PurchaseState.Purchased).FirstOrDefault();

                // Activate the item on my server

                var finished = await CrossInAppBilling.Current.FinishTransaction(purchase);
            }

It's also happening to me.
The weird part is that no one from the project has commented here.
Is this project dead?

Me and my employers have actually left Xamarin and are now developing with Flutter.io!

hey @meepou how does my PR look for this? I added FinishTransaction so you can manually finish it if needed

Looking nice, thank you James. It allows us to be able to manage those weird unfinished states !
Keep up the good work
As I said, unfortunately, I rewrote my whole implementation of InAppPurchases directly with StoreKit. I had an issue when a user had no payment method on its account, it would redirect to the AppStore to add a payment method and the item was "lost" (because it is a non-renewing subscription).

Thanks, James. You made my day.
Looking forward to seeing this fix in action.
BR

I'm working on another issue and noticed that the Beta version of the plugin now has these FinishTransaction methods in the interface which need to be implemented. Why and what do we need to do in those methods? In our case we are selling consumables that we then  verify with our servers. Do we need to use FinishTransaction now instead of using IInAppBillingVerifyPurchase.VerifyPurchase(...)? I didn't see any documentation in the Beta version of the Nuget package I downloaded or the website. I appreciate any insight you can offer.


PHP 8.2 & 8.3 support

Hello,
I'm intrigued by your package, it seems promising! However, I've noticed that it currently supports PHP 8.1, which is slated to stop receiving security updates after November (source: https://www.php.net/supported-versions.php). Are there plans to extend support for PHP versions 8.2 and 8.3 in the future?
Kind regards,
Bas

Had a too quick look. ^8.0 || ^8.1 allows for version 8.2


Dye Sim not working

Hello!
I just downloaded the updated version of your Dye Simulator DCTL (from commit no. 9918e12), only to find that it was not working properly. All the UI params showed up just fine, but neither the dye density nor observer charts appeared when turned on, and the entire screen was rendered black (surrounded by a tiny white border, as if the whole screen had a negative value - for the hell of it, in the next node I raised the offset by 1000, only to find zero change to the image.)
I use your DCTLs through your DCTL Interpreter Fuse; and the "Explicitly Typecast Built-In Functions" button in Fusion's Inspector tab (which I find helps certain DCTLs run properly) did nothing to help here.
I redownloaded an older version of the DCTL (commit no. 2a18759) to check - and sure enough, it works fine. The issue must be from commit no. 9918e12.
P.S. what were the dimensions of the image you were using when you created/tested the DCTL? The charts rescale depending on the size of the image, making using them quite frustrating 😅

Can you describe your OS and system specs? Cuda or OpenCL or metal?

Ok looks like I was able to reproduce the issues on OpenCL. I've made adjustments to most of my DCTLs to improve OpenCL compatibility, so go ahead and redownload the dye simulator and it should work for you.
A couple further notes:

In OpenCL, the DCTL Interpreter Fuse currently can't run DCTLs that require sampling other pixels in the frame. This is because OpenCL has restrictions on how you can use the __TEXTURE__ type that is broken with the way I ported those over to the Fuse DCTL variant.
Please just switch to CUDA or Metal if you can. Nobody tests their DCTLs on OpenCL because most Resolve users have an Nvidia GPU or a macbook, and in either platform CUDA or Metal are the preferred systems. Most code works just as well on both of those platforms and it's OpenCL that has a bunch of problems where it can't run code that works fine on other platforms.


11/16 PM Publish

Learn Build status updates of commit ee3cd69:
:warning: Validation status: warnings

File
Status
Preview URL
Details

api/index.md
:warning:Warning
View
Details

api/index.md

Line 22, Column 50: [Warning: xref-not-found] Cross reference not found: 'microsoft.quantum.libraries'.
Line 17, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/python/qsharp-core/qsharp' will be broken in isolated environments. Replace with a relative link.
Line 18, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/qsharp/api/iqsharp-magic/' will be broken in isolated environments. Replace with a relative link.
Line 19, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/rest/api/azurequantum/' will be broken in isolated environments. Replace with a relative link.
Line 20, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://learn.microsoft.com/azure/templates/microsoft.quantum/workspaces?tabs=bicep&pivots=deployment-language-arm-template' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Learn Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel


js in widjets.py do not works after minification

More troubleshooting information needed. Please post the generated HTML/JS before and after minification, Django version, full tracebacks, models, etc. Closing but feel free to reopen when you add that information. Thanks!


Upgrade plug

Based on a recent vulnerability discovered in Plug, we should hardcode the version of plug used to be 1.3.2 or greater. Full details of the vulnerability are at https://groups.google.com/d/msg/elixir-lang-core/cL9OLMT1DHQ/gWQt_d5_DAAJ

Even though we're not directly affected, we should do it. Will you open a PR?


Fix/account creation validation bug

fixes #62

Coverage increased (+0.03%) to 92.43% when pulling f10c3f49bc5a0d9b298828899e4784ed1366018c on fix/account-creation-validation-bug into 453f6bfa7469156b6aa7f42ddc2886c68583f5b2 on master.


HW2: adding project link and resolving conflicts

closing as it looks like Github might have made a mistake in determining the merge base


No alert message while deleting customer with pending or processing order from admin end.

Bug report
Title
No alert message while deleting customer with pending or processing order from admin end.
Preconditions
1. framework Version. Master

Steps to reproduce
1. step1: place an order for any customer and then visit customer grid at admin end and try to delete customer from delete icon

Expected result
should get alert message
Actual result:
no message

fixed in master


rootless run

when i'm start rootless k3s i have many errors like:
Nov 23 03:05:00 central01.z1.unistack.org k3s[31842]: E1123 03:05:00.255469   31931 remote_runtime.go:105] RunPodSandbox from runtime se
rvice failed: rpc error: code = Unknown desc = failed to create containerd task: failed to mount rootfs component &{overlay overlay [wor
kdir=/home/vtolstov/.rancher/k3s/agent/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/218/work upperdir=/home/vtolstov/.ran
cher/k3s/agent/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/218/fs lowerdir=/home/vtolstov/.rancher/k3s/agent/containerd/
io.containerd.snapshotter.v1.overlayfs/snapshots/1/fs]}: operation not permitted: unknown
Nov 23 03:05:00 central01.z1.unistack.org k3s[31842]: E1123 03:05:00.255557   31931 kuberuntime_sandbox.go:68] CreatePodSandbox for pod
"helm-install-traefik-bkxjh_kube-system(af9b4646-2469-4f66-8d5f-333ba77feb82)" failed: rpc error: code = Unknown desc = failed to create
 containerd task: failed to mount rootfs component &{overlay overlay [workdir=/home/vtolstov/.rancher/k3s/agent/containerd/io.containerd
.snapshotter.v1.overlayfs/snapshots/218/work upperdir=/home/vtolstov/.rancher/k3s/agent/containerd/io.containerd.snapshotter.v1.overlayf
s/snapshots/218/fs lowerdir=/home/vtolstov/.rancher/k3s/agent/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/1/fs]}: operation not permitted: unknown

i'm use fedora 31 as host system

You need to specify native snapshotter on Fedora, but k3s lacks config option
https://github.com/rancher/k3s/issues/924

thanks, i'm read this issue, but not understand how to deal with it?
Also i'm use containerd before 1.3, so automatic snapshotter configuration not works for me

k3s server --rootless --snapshotter=native should work

Closing - as @AkihiroSuda said the fix is to use a recent release with --snapshotter flag support and use the native snapshotter.


ionic2 app build prod failed with angular2-mqtt

Hi, first of all thanks for your awesome lib, because it is quite hard to find mqtt lib for angular2. Currently I am testing it with Ionic2 and trying to build an Android App for it. Everything is working fine until I got the following error when I was running the command ionic build android --prod
can't resolve module<EMAIL_ADDRESS>from<EMAIL_ADDRESS>[09:30:36]  build prod failed: can't find symbol KeyRegistry exported from module
<EMAIL_ADDRESS>[09:30:36]  ionic-app-script task: "build"
[09:30:36]  Error: can't find symbol KeyRegistry exported from module
<EMAIL_ADDRESS>Error: can't find symbol KeyRegistry exported from module<EMAIL_ADDRESS>    at ReflectorHost.findDeclaration (/home/beng/ionic_app/myLoRa/node_modules/@angular/compiler-cli/src/reflector_host.js:173:23)
    at /home/beng/ionic_app/myLoRa/node_modules/@angular/compiler-cli/src/codegen.js:137:46
    at Array.forEach (native)
    at extractProgramSymbols (/home/beng/ionic_app/myLoRa/node_modules/@angular/compiler-cli/src/codegen.js:120:10)
    at CodeGenerator.codegen (/home/beng/ionic_app/myLoRa/node_modules/@angular/compiler-cli/src/codegen.js:57:29)
    at /home/beng/ionic_app/myLoRa/node_modules/@ionic/app-scripts/dist/aot/aot-compiler.js:51:34

When I am running the command ionic build android without "--prod" the compilation is okay. Hope you can give some insights on this issue because I am quite new to angular2 and I might miss something.
Below is my code.
import { Component } from '@angular/core';
import { NavController } from 'ionic-angular';
import { MqttConnectionState, MqttService } from 'angular2-mqtt';

@Component({
  selector: 'page-home',
  templateUrl: 'home.html',
})

export class HomePage {
  mqtt: any = null;
  mqtt_state: boolean = false;
  chart: any = null;
  options: any = null;

  constructor() {
      this.mqtt = new MqttService({
        hostname: 'broker.mqttdashboard.com',
        port: 8000,
      });

      this.mqtt.state.subscribe((value)=>{
          switch(value){
            case MqttConnectionState.CLOSED:
              this.onLostConnection();
              break;
            case MqttConnectionState.CONNECTED:
              this.onConnected();
              break;
          }
      });

      //register subscription callback
      this.mqtt.observe("bengchet/ionic2").subscribe((resp)=>{
        var json = JSON.parse(resp.payload.toString());
        this.chart.series[0].addPoint(parseFloat(json.value));
      });
    }

    onConnected(){
      console.log('Connected to broker');
      //publish some message
      //this.mqtt.unsafePublish("bengchet/ionic2","Hello world 2",{qos:1});
    }

    onLostConnection(){}

    ionViewWillEnter(){
    	this.options = {
    		chart: { type: 'spline' },
            title : { text : 'simple chart' },
            series: [{
                data: [],
            }]
        };
    	setInterval(()=>{
          let json = new Json((Math.random() * 10).toFixed(2));
          this.mqtt.unsafePublish("bengchet/ionic2", JSON.stringify(json), {qos: 1});
        }, 5000);
    }

    saveInstance(chartInstance) {
    	this.chart = chartInstance;
    }
}

export class Json{
  constructor(private value: any){}
}

Thanks.

Which  version of ionic do you use?

Maybe it's because ionic uses angular 2.2.1 and angular2-mqtt uses angular ^2.4.1
I will have a look and see, if I could set a lower version without problems.

I also found this, using google with the actual error message
https://forum.ionicframework.com/t/build-error-cant-find-symbol-keyregistry/72811/3
Maybe this helps.

Hi thanks for reply. This is the package.json I am using.
"dependencies": {
    "@angular/common": "2.2.1",
    "@angular/compiler": "2.2.1",
    "@angular/compiler-cli": "2.2.1",
    "@angular/core": "2.2.1",
    "@angular/forms": "2.2.1",
    "@angular/http": "2.2.1",
    "@angular/platform-browser": "2.2.1",
    "@angular/platform-browser-dynamic": "2.2.1",
    "@angular/platform-server": "2.2.1",
    "@ionic/storage": "1.1.7",
    "angular2-highcharts": "^0.4.1",
    "angular2-mqtt": "^1.5.0",
    "ionic-angular": "^2.0.0-rc.5",
    "ionic-native": "2.2.11",
    "ionicons": "3.0.0",
    "rxjs": "5.0.0-beta.12",
    "sw-toolbox": "3.4.0",
    "web-mqtt-client": "^1.3.0",
    "zone": "^0.3.4",
    "zone.js": "0.6.26"
  },

I have followed the instructions according to the link provided. But the problem still exists. May be the instructions didn't show how to install latest angular? It just shows npm install ionic-angular@latest, I don't know if it is the same as the 'angular' you are mentioning.

Does the new version 1.5.1 fix your problem?

Yes, totally fixed the problem. Many thanks!


Installation issue

Hello
It seems that this bundle can no longer be installed from scratch since the package litipk/php-exceptions has been removed from github
  - Installing litipk/php-exceptions (0.1.3): Downloading (connecting...)
   Downloading (failed)
   Failed to download litipk/php-exceptions from dist: The "https://api.github.com/repos/Litipk/php-exceptions/zipball/6271c3d5c51dab8bb64e4ac796b018574b477750" file could not be downloaded (HTTP/1.1 404 Not Found)
    Now trying to download from source
  - Installing litipk/php-exceptions (0.1.3): Cloning 6271c3d5c5

  [RuntimeException]
  Failed to clone https://github.com/Litipk/php-exceptions.git via https, ssh protocols, aborting.

To me it seems like switching to version 0.8 of php-bignumbers would solve the issue but I'm not sure if it's entirely compatible

Yes, this just bit us too. Working on a solution.

We've fixed the dependency with the 5.1.3 tag.


why my GPU do not work when i am Inferencing

my cuda is Cuda  11.1 RTX3090,do not support cuda 11.1?


when use CircularProgressIndicator or RefreshProgressIndicator, the usage of CPU is very high

Steps to Reproduce

create 'lib/main.dart' file

import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key key}) : super(key: key);
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Test CircularProgressIndicator'),
      ),
      body: Center(
        child: Container(
            color: Colors.red,
            width: 45.0,
            height: 45.0,
            child: CircularProgressIndicator()
          ),
      )
    );
  }
}

open Android Emulator, then flutter run

waiting seconds, CPU usage jump to more than 100%

Logs

flutter doctor

[✓] Flutter (Channel stable, v1.0.0, on Mac OS X 10.14 18A391, locale zh-Hans-CN)
    • Flutter version 1.0.0 at /Users/cixiu/flutter/flutter
    • Framework revision 5391447fae (3 months ago), 2018-11-29 19:41:26 -0800
    • Engine revision 7375a0f414
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.3)
    • Android SDK at /Users/cixiu/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • ANDROID_HOME = /Users/cixiu/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    • ios-deploy 1.9.4
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 31.3.3
    • Dart plugin version 182.5124
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[✓] VS Code (version 1.31.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 2.23.0

[✓] Connected device (1 available)
    • Android SDK built for x86 • emulator-5554 • android-x86 • Android 9 (API 28) (emulator)

i have checked #21445, but whether it's Android or IOS, the problem still exists。

Is this a release build on a real device or a debug build in a simulator/emulator?

Could also be #13203 but I think that was mainly reproduce on iOS simulator.

@zoechi it's appear both ios-simulator and android-emulator in debug build.

I'm closing this as duplicate of #13203 then.


Collapse blocks with no transactions

ref
Collapse blocks when there are no transactions present within the block

That was my initial feedback, I think the ideal situation if possible is to not segregate the transactions view by blocks at all. (though a "hide empty blocks" feature on the blocks view would make sense at some point) but just to focus on listing the most recent N transactions (plus pagination) with block number in the table, like Etherscan's txs pages does (Slack ref).

${TENDERMINT_URL}tm/tx_search?query="tx.height<[CURRENT BLOCK ID]"&per_page="10"&order_by="desc"
Should deliver the required data, but does not and 502s on testnet

@barnabee initial suggestion added, and I'll look further at what Dex has raised and attempt the continuous TXs list when testnet failures are resolved


MYSQL monitor by number row return

📑 I have found these related issues/pull requests
N/A
🏷 Feature Request Type
Change to existing monitor
🔖 Feature description
Add up/down base on number row return from MYSQL
✔ Solution
Count row return > 0
❓ Alternatives
No response
📝 Additional Context
No response

Really need this one!!!!!


Show composing a Python app into AppHost as a resource

Scenario:

ASP.NET Core API frontend (e.g. Blazor SSR)
Python (e.g. FastAPI) backend
Frontend talks to the backend
Backend talks to a PostgreSQL database
Both apps should be composed into AppHost project so that service endpoint from backend is injected into environment of frontend
Backend should have connection string of database injected into environment variables

+1 for this polyglot programming language combination model.

@DamianEdwards Is this sample available now?

@goldytech no we'll wait until dotnet/aspire#4142 goes in before adding this sample.

@DamianEdwards Thanks for sharing this update. I'm looking forward to it in version 8.1!


Updated with topic skeleton

the outline looks good to me. however the sizing of all the headers is all funky, reformat all the headers to what makes sense to you.


feature - iqkeyboard ui

Github Issue URL/Tags (required)
What's this PR do? Please give a technical summary (required)

[x] iqkeyboard ui
[x] add shadow item view cell

Any references (stackoverflow …) (optional)

:+1: There are no linter violations.


Scripts in Google Assistant are cached by name and changes are not propagated

Home Assistant release with the issue:
0.77.3
Last working Home Assistant release (if known):
N/A
Operating environment (Hass.io/Docker/Windows/etc.):
Hassbian
Component/platform:
scripts + google assistant
Description of problem:
When you create a script and sync it to Google Assistant as device, edits to that script are not propagated to Google Assistant. Only by renaming the alias of the script does the new functionality get pushed to Google Assistant.
Steps to reproduce:

Create a script with alias test_script and name "Test Script" that does something like publish an event
Sync script/devices with Google Assistant
Say "Ok google activate Test script"
You should see the event appear in the log
Change Test Script to publish a different event but leave the name and alias the same
Restart Hass/reload scripts and re-sync to Google Assistant
Say "Ok google activate Test Script"
You see another old event and not the new event you expect
Rename Test Script to Test Script 2
Reload scripts and re-sync to Google Assistant
Activate Test Script 2 with google home
Correctly see the new event and not the old one

I do not have this issue.  Any time I modify an existing script the new sequence is completed.  You also don't need to resync to google assistant if the entity ID did not change.

@dshokouhi oops apologies, that actually seems to be working for me even though I thought it wasn't before. The problem seems to be more nuanced and I can still reproduce by modifying some of my current scripts which are a bit more complicated. I'll see if I can get another minimal repro that actually works.

Make sure to post the yaml examples as well

Hmm I'll be honest I've been trying to repro again for 15 minutes now and I can't seem to do it... I was convinced I was hitting a bug somewhere in here but I'm going to chalk it up to human error. Will re-open if I hit this issue again!


Add flag for toggling daemon mode

We added this feature for our own use and thought we would send it upstream incase it is useful to other.
The DAEMON configuration option toggles whether to start a run loop or execute run() once and exit.
DAEMON will default to true persisting current behaviour.
This allows the tool to be run "once-off" such as in CRON jobs or build pipelines.

Hey @johnjcsmith
thank you for the contribution, much appreciated.
Would you mind adjusting the indentation to tabs to be consistent with the rest of the code base?
We might want to introduce a .editorconfig and convert to spaces, wdyt @TierMobility/tier-operations ?

Thanks for taking a look. Indentation fixed and merged calls to viper.GetBool("DAEMON").

Any chance this could get merged? We'd be interested in running this tool in a CRON job

Hey @johnjcsmith,
sorry for the delay on this one. This LGTM :tada:


Approve is not shown when changing coins

Need to have USDT and USDC in the wallet and non have been approved.
Go to EARN for USDT, the approve button should be there - all good.
Go change the asset to USDC, The Approve button should be there but the EARN button is.
User is able to add try to add to savers but will get an error as the contract is no approved.

Need to do more detailed testing in sub release.


docs: Add OpenTripPlanner to community category

Hi folks,
Please feel free to merge these OpenTripPlanner mailing lists to the  Community category.
Cheers!

Thanks @dancesWithCycles!


couldn't open Project on amazon sagemaker studio lab

Describe the bug
Amazon Sagemaker studio lab is not opening jupyter notebook. It is loading indefinitely at Preparing project run time after that i am getting There was a problem when starting the project runtime. This should be resolved shortly. Please try again later. It's been almost a week and it still hasn't been resolved. Even though I tried shifting the runtime from CPU to GPU but issue still persists. Any help would be appreciated.
The error i am getting is

Hi - sorry you're running into this issue, we're taking a look.

I have also encountered this problem, which still exists at present.

I deleted my account and re-created it, which took around 5 minutes for them to accept my request for the second time. If need instance then this is the only approach I could find. I had not received any updates from this issue after a week, so I recreated my instance.

I see - really sorry you're running into that. I've created a ticket with the team, but I'll close this issue for now since there is a known workaround.

Hello, I can't open project on amazon sagemaker. When I am clicking the 'open project' button, it is loading indefinitely, and I can't do anything with the files. I have restarted my project, browser, laptop, cleared cache, tried from other browsers, changed the env from GPU to CPU but nothing did work. Can you please take a look into my account and resolve the issue? Thanks!


Add iteration_cost() and non_zero_number() methods to the API

iteration_cost() will provide a cost for row- or column-wise iteration. This can be weighted differently for file access.
non_zero_number() will report the proportion of non-zero elements when sparse() is true.
Primarily useful for DelayedBind, to give better choices of prefer_rows() and sparse() for complex bound matrices.

Closed by ee833d16e0ce97a07624e46239aa196b12f6e681.


Fixed format of DS links

Changed format of downstream CP link to Asciidoc because Kramdoc does not convert links in comments.
Signed-off-by: Avital Pinnick<EMAIL_ADDRESS>

@sradco Ready for review.


multibit.spvchain error

Since I started up multibit, I am getting an error and this is the log:
The user data directory is "C:\Users*****\AppData\Roaming\MultiBit".
The installation directory is "C:\Program Files (x86)\MultiBit-0.5.15".
Unable to load blockchain "C:\Users**\AppData\Roaming\MultiBit\multibit.spvchain". The error was "org.jboss.netty.channel.ChannelException Failed to create a selector.".
Opening wallet "C:\Users**\AppData\Roaming\MultiBit\multibit.wallet"...
... done.
Opening wallet "C:\Users**\AppData\Roaming\MultiBit\free.wallet"...
... done.
Opening wallet "C:\Users***\AppData\Roaming\MultiBit\free2.wallet"...
... done.
(replaced username with ****** for privacy reasons)
Can you please help me fix this? I have tried shutting down multibit, deleting multibit.spvchain and then restarting but that doesn't work. I am really keen on using multibit so I hope you can fix the problem :(

same problem on  0.5.18


SidebarCollapsibleCard: Improve Sortable interactions

SidebarCollapsibleCard: Improve Sortable interactions

This update fixes Sortable's handling of child item keys. Sortable now respects unique keys, and uses ID props if specified.
SidebarCollapsibleCard gains 2 new hooks: onSortStart and onSortEnd that fire when the component is being sorted. The react-sortable-hoc did NOT provide any callback methods for these hooks for the DraggableHandle, only at the Container level. So I had to come up with a creative solution to get this to work.
The two props allow for SidebarCollapsibleCard to be better integrated into Sortable.
Collapsible gains 2 new props: durationOpen and durationClose, that fallback to duration. This allows you to pass in different timings for the animation, allow for a smoother collapse experience with SidebarCollapsibleCard.
Resolves: https://github.com/helpscout/blue/issues/74 https://github.com/helpscout/blue/issues/71

Coverage remained the same at 100.0% when pulling 4ee966434dacce8904bdeac68e66794869b5ec8b on SidebarCollapsibleCard/improve-sorting into 05b5784a1314173b498389535796ac8fe1b0c6ee on master.


Add filling of test players on tournament creation in the GUI

Prefill with x amount of players. Maybe use fako for neatness?

Merged to master yesterday.


IGAPP-873: Add back function for change location

Tested on ios & android!

Removing the CLEAR_CITY action leads to opening of the last opened city after a restart of the app. Perhaps this is not so easy after all... Also the header should not be shown if there is no back button. Otherwise it leads to content vanishing behind the header

Opening the last opened city after app restart is not the expected behavior?
Hiding the header the header if there is no GoBack fkt should not be the problem

Removing the CLEAR_CITY action leads to opening of the last opened city after a restart of the app. Perhaps this is not so easy after all... Also the header should not be shown if there is no back button. Otherwise it leads to content vanishing behind the header

Opening the last opened city after app restart is not the expected behavior? Hiding the header the header if there is no GoBack fkt should not be the problem

It is (last != currect), but the problem now occuring is:
Opening city1 -> Change city -> Open city2 -> close app -> reopen app -> city1 is opend, but it should be city2.

I mean if you click on change location it shows the landing page and city selection (which was probably intended because I want to change the city). If I close the app now and I am back to the city I was previously, that is not really intuitive imo. This also leads to some other problems like not unsubscribing from push news, not clearing the settings/resource cache and so on. So probably the current solution (which was oc proposed by me) of keeping the previous city open in the background does not work and we may have to pass a separate action to execute on the back arrow press.

I mean if you click on change location it shows the landing page and city selection (which was probably intended because I want to change the city). If I close the app now and I am back to the city I was previously, that is not really intuitive imo. This also leads to some other problems like not unsubscribing from push news, not clearing the settings/resource cache and so on. So probably the current solution (which was oc proposed by me) of keeping the route of the previous city open in the background does not work and we may have to pass a separate action to execute on the back arrow press.

I moved the CLEAR_CITY fkt to goToCategory if you click on a city on the Landing page instead of clearing instantly when opening the landing page. Please test again


Conformation prompt

Severely needed, just like the one quit to menu/desktop have.

In the config editor set ConfirmationDialogEnabled to true, there will be a confirmation when clicking the buttons or using the reset key.

Oh, my bad! Don't know how I missed that.


Add docs for expansion-panel and accordion

We currently are missing documentation for expansion-panel / accordion. This needs:

[ ] An overview file (expansion.md)
[ ] At least two examples (typically one simple and one more in-depth)

The style of the overview should align with existing docs.

@jelbourn, there's an issue with expansion-panel. When you select, for the first time, an md-tab that have an expansion inside, it's shown expanded and a little messed up: #5269
If it's put in the examples tab, this issue will mess with it (plunker: http://plnkr.co/edit/q6kXPH?p=preview), unless some kind of workaround is used along with it.


Inclusion of Related Resources (include params) on POST/PATCH requests

At the end of Inclusion of Related Resources JSONAPI spec section it's mentioned:

Note: This section applies to any endpoint that responds with primary data, regardless of the request type. For instance, a server could support the inclusion of related resources along with a POST request to create a resource or relationship.

In the current JR implementation, I think that only FindOperation and ShowOperation support the include params. Correct?
Would it make sense to add support on other endpoints?
If have the case where we want to create an object and get related resources in the response. Something like: POST /articles?include=author.articles (create an article and get all existing articles from the same author).
Am I getting the spec wrong?

Actually, the case is that JR already supports using include in POST/PATCH requests, too. I am able to confirm that from the current (ce94ced08c3f) master version, and on v0.7.0, too. https://github.com/venuu/jsonapi-authorization even authorizes such includes properly. master version of JR has a bug, I think, in where it doesn't pass the params[:include_directives] properly downstream to processors. See https://github.com/venuu/jsonapi-authorization/pull/24#issuecomment-229958455 for more details if you're interested — I'm gonna open up a new issue here for this particular case, though, and try to fix it.


Can we use Caffe2 for iOS/CoreML?

Recently, Apple announced  CoreML support in their iOS devices. The developer can convert their trained models to Core ML as following:

Converting Trained Models to Core ML:
https://developer.apple.com/documentation/coreml/converting_trained_models_to_core_ml

The below content is models and third-party tools supported by Core ML Tools.  In case of Caffe2, How can we use Core ML Tool?

Model type: Neural networks
Supported models: Feedforward, convolutional, recurrent
Supported tools: Caffe, Keras 1.2.2

CoremlTools 0.3.0
https://pypi.python.org/pypi/coremltools
Core ML is an Apple framework which allows developers to simply and easily integrate machine learning (ML) models into apps running on Apple devices (including iOS, watchOS, macOS, and tvOS). Core ML introduces a public file format (.mlmodel) for a broad set of ML methods including deep neural networks (both convolutional and recurrent), tree ensembles with boosting, and generalized linear models. Models in this format can be directly integrated into apps through Xcode.

+1 Has anyone tried yet?

I’ve used CoreML extensively. I don’t think it has much use for Caffe2.
Specifically it aims to supplant Caffe2 on iOS devices. Most people, self
included, will just convert their Caffe models to CoreML and skip Caffe2
entirely. Perhaps in the future there will be a Caffe2 to CoreML converter
which would be useful because we could use Caffe2’s distributed training
and then use CoreML to run on iOS devices.
That said CoreML is backed by metal performance shaders that now support
hardware acceleration for everything Caffe2’s operators need. So they could
be used to have hardware acceleration on iOS and MacOS for Caffe2.
– Mike
On Thu, Jul 13, 2017 at 7:24 PM Barry Lachapelle<EMAIL_ADDRESS>wrote:

+1 Has anyone tried yet?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/caffe2/caffe2/issues/869#issuecomment-315228476, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AC2ETdaRSaI8mMjfbyGmL4uC7yZEG7kiks5sNqc-gaJpZM4OFA5D
.

\CC: @myungjoo , @jijoongmoon


Supporting API 14

Hi,
I'll love to use your library but I'd need it to work with API 14. Is there any hope to make it work with API 14?
I'd just need a simple DatePickerDialog, if I force the use of the library in my manifest... would it crash my app?
Thanks in advance

the same

I also need to support API 14. I don't want to miss 10% of my users

+1

+1,
any update on this ?

@fncapps @connonfodder @tuhin10 @WasimMemon SublimePicker now supports API 14 & above.

Thanks!!
I'll begin using it as soon as I can!

@fncapps You are welcome. Any feedback will be much appreciated!


Cannot access https://egiintel.jfrog.io/ui/repos/tree/General/librealsense

I am trying to use librealsense to develop an Android app, and followed the instructions of the Android support and the Java example. It seems that I need to download the lib from https://egiintel.jfrog.io/ui/repos/tree/General/librealsense. But this link requires a login and I found it nowhere to register an account. How could I obtain the *.so and *.aar files? Many thanks.

Hi @II-Matto  You should be able to build the RealSense Android wrapper and its AAR with Gradle or with Android Studio using the instructions at the link below.
https://github.com/IntelRealSense/librealsense/tree/master/wrappers/android

@MartyG-RealSense Thanks for your prompt reply. Does this mean that I have to build the AAR myself and cannot directly download one?

At the moment the only option seems to be to be to build the AAR.
I will raise the issue of the JFrog login with Intel.  Thanks very much for the report!

@MartyG-RealSense Many thanks!


Change return type of CanExecuteChanged only for MUX.Input.ICommand

Fixes #597
Microsoft.UI.Xaml.Input.ICommand is mapped to System.Windows.Input.ICommand. The CanExecuteChanged events on those two types aren't exactly the same, so there is a special case in the code generation to fix up the type mapping. This was introduced in #112.
The check for this special case is currently too broad: it will apply to any event named "CanExecuteChanged" of type "EventHandler", even if that event is part of some unknown-to-cswinrt type that is not mapped to System.Windows.Input.ICommand. (I hit this with the WUX.Input.ICommand type in system XAML--since system XAML is not supported, its types should be treated as unknown-to-cswinrt everywhere.)
This PR makes the check more specific, so it affects only the mapped MUX type.

thanks @mcooley - with this change, what does CanExecuteChanged get projected to for Windows.UI.Xaml.Input.ICommand?

@asklar on Windows.UI.Xaml.Input.ICommand, CanExecuteChanged will be EventHandler<object> instead of EventHandler.

/azp run

@manodasanW could you take a look? LGTM.

/azp run


First step to remove JNI header dependency

Revisited all the structs to make sure their layout matches JNI spec. This is the first (and pretty much the only) step to get rid of header dependency.

@vegansk, what do you think?

@yglukhov, it's cool! Sorry for the long waiting, the crazy end of the year


Blog - basic and more...

Produced a basic example of the use of the blog plugin. Added use of authors file because I imagine a lot of people will want this.
Will produce some more complex examples and as part of this will probably revisit this one, so not asking for a review yet. Feel free to comment, though.
Also, I created a little meta.yml file. Not sure if you had already thought about creating the index pages. Hope this is useful, if not LMK.

Before I forget, the one other use case I had on my list was a stand-along blog (as described in your blog post announcing the plugin, right?) - any other ones?

Oh, and I'd drop the date from the filenames or users might think that it is mandatory.

Just realised the RSS is causing a warning because it is not in the nav - will try and fix

Also, let me know if you want me to un-draft this once the above question is resolved so you can merge. I still need to do the blog-only site but need to do a couple of other things now.

Already undrafted it, as I thought you were ready. Once I approved it, you can also merge it (I think you should be able to, being a collaborator). If you feel that you made changes that need re-review, just re-request it ☺ I'm going to groom the examples from time to time, but for the time being you can go ahead and merge it if approved.


[SPARK-48016][SQL] Binary Arithmetic operators should include the evalMode when makeCopy

What changes were proposed in this pull request?

Currently, the following query will throw DIVIDE_BY_ZERO error instead of returning null
SELECT try_divide(1, decimal(0));

This is caused by the rule DecimalPrecision:
case b @ BinaryOperator(left, right) if left.dataType != right.dataType =>
  (left, right) match {
 ...
    case (l: Literal, r) if r.dataType.isInstanceOf[DecimalType] &&
        l.dataType.isInstanceOf[IntegralType] &&
        literalPickMinimumPrecision =>
      b.makeCopy(Array(Cast(l, DataTypeUtils.fromLiteral(l)), r))

The result of the above makeCopy will contain ANSI as the evalMode, instead of TRY.
This PR is to fix this bug.
Why are the changes needed?

Bug fix in try_* functions.
Does this PR introduce any user-facing change?

Yes, it fixes a long-standing bug in the try_divide function.
How was this patch tested?

New UTs
Was this patch authored or co-authored using generative AI tooling?

No

I am starting a new approach in https://github.com/apache/spark/pull/46286.
Fixing the makeCopy can be tricky. The test failure in CanonicalizeSuite seems a bit complicated to fix.


Not working with webpack config resolve.alias

I setup storyshots for the first time. While react storybook works, storyshots does not respect the resolve aliases in my webpack config. I believe I have a very standard setup
Package versions:
react: 15.6.2
jest: 21.0.2
webpack 3.6.0
@storybook/addon-storyshots: 3.2.12
@storybook/react: 3.2.11

/Storyshots.test.js
import initStoryshots from '@storybook/addon-storyshots';

initStoryshots();

/webpack.config.dev.js snippet
  resolve: {
    extensions: ['.js', '.jsx'],
    alias: {
      components: path.resolve(__dirname, 'src/components/'),
      containers: path.resolve(__dirname, 'src/containers/'),
      utils: path.resolve(__dirname, 'src/utils/'),
    },
  },

/.storybook/webpack.config.js
const projWebpack = require('../webpack.config.dev');
module.exports = (sbConfig, type) => {
  sbConfig.resolve.alias = projWebpack.resolve.alias;
  return sbConfig;
}

Error output
 FAIL  ./Storyshots.test.js
  ● Test suite failed to run

    Cannot find module 'components/FullscreenCarousel' from 'index.jsx'

      at Resolver.resolveModule (node_modules/jest-resolve/build/index.js:191:17)
      at Object.<anonymous> (src/components/ListingCarousel/index.jsx:15:27)

Can anyone see anything wrong here?

Actually, looks like Jest setup issue.
Should be nothing to do with Storyshot

It is a Jest configuration issue. I solved it by adding the following to my package.json:
"jest": {
  "moduleNameMapper": {
    "^components(.*)$": "<rootDir>/src/components$1"
}