Create schematic symbols Micro controller

Create schematic symbols and pin outs for stm32 controllers

Have found a kicad symbol and foot print already defined for the STM32F103C8TX.
Adding


Unsupported Media Type

I pass username and password as key/value pairs in body and tried setting  headers to Content-Type multipart/form-data o Content-Type   application/json  but always get the following error
 {
 "error": "Unsupported Media Type",
   "message": "FST_ERR_CTP_INVALID_MEDIA_TYPE: Unsupported Media Type:
   multipart/form-data; boundary=--------------------------620015652671895359303014"
}

From postman I set raw body with object below and type as JSON(application.json)
{
username:'test',
password:'test'
}


Update access_token procedure

Add access token request scope and NF service consumre authentication verification
Change NRF access token signing method from constant secret to RSA asynchronous encryption

@eggegg31415
Please rebase this PR with the latest commit.
Some packages are already renamed, so please help fix the conflicts with new packages and APIs.
Thanks.

Hi,
Can you please describe how the TLS certificates are generated? I wrote a small bash script to do it:
NFS=("nrf" "amf" "ausf" "smf" "n3iwf" "pcf" "udm" "udr" "nssf")

openssl genrsa -out root.key 2048
openssl req -x509 -new -nodes -key root.key -sha256 -days 1825 -out root.pem

for i in "${NFS[@]}"
do
   openssl genrsa -out $i.key 2048
   openssl req -new -key $i.key -subj "/C=US/ST=NC/O=free5gc Inc./CN=$i" -addext "subjectAltName = DNS:$i,URI:$i.free5gc.org:NF_INSTANCE_ID_HERE1:NF_INSTANCE_ID_HERE2" -out $i.pem
   openssl x509 -req -extfile <(printf "subjectAltName=DNS:$i,URI:$i.free5gc.org:NF_INSTANCE_ID_HERE1:NF_INSTANCE_ID_HERE2") -in $i.pem -CA root.pem -CAkey root.key -CAcreateserial -out $i.pem -days 500 -sha256
done

However, lines
https://github.com/free5gc/nrf/blob/518919ac94aaf59e3e5cbd70531cabd74919235f/internal/sbi/producer/access_token.go#L198-L206
specify that the NF Instance ID needs to be in the TLS certificate. As far as I can tell, in all NFs (amf, ausf, udr, ...) the nf instance ID is determined at runtime. How can this NF Instance ID be embedded in the TLS certificate without changing the certificate for every NF launch?
This is the error I am seeing:

nrf              | 2022-09-01T17:02:33Z [ERRO][NRF][Token] Certificate verify error: NF Instance Id mismatch (Expected ID: f287408f-351d-4e31-9be1-6dfa73a7330f Received ID: NF_INSTANCE_ID_HERE2) (/go/src/free5gc/NFs/nrf/internal/sbi/producer/access_token.go:201 github.com/free5gc/nrf/internal/sbi/producer.AccessTokenScopeCheck)

@eggegg31415 could you help reply @swthorn 's question.
Thanks.


NSLogging tests are failing.

The following unit-tests fail consistently on my dev box.
NSLogging_NSLoggingWideBasicTests::Test [Failed]
NSLogging_NSLoggingNSStringBasicTests::Test [Failed]
NSLogging_NSLoggingWideFormatTests::Test [Failed]
NSLogging_NSLoggingNSStringFormatTests::Test [Failed]
NSLogging_NSLogTests::Test [Failed]
I've repro'd this on the MS/develop branch.
Repro steps:
git clean -fdx
init.cmd
.tools\nuget restore build\build.sln
msbuild /p:configuration=debug /p:platform=x86 build\build.sln
run the tests in either powershell or the command line:

 run-unitests.ps1
 te *.unittests.dll

The tests pass if I run them in proc te.exe foundation.windowsonly.unittests.dll /inproc.

I take that back, they passed because they were all blocked. No UWP execution inproc.

If you are building debug locally, this would fail unless you build the tools project locally as well.  The debug hooks are only available on debug builds, so if you restore tools package, this will fail.
I am leaving the tests as is, so we get coverage for the logging pipeline in our build server.

That's a weird developer experience.  I and many others build debug.  And, our process mandates we run UT's locally before submitting a PR.  Now we will have to take extra time to go back and build release just to run UT's.
Also, how would an external developer figure out that debug UT"s are expected to fail?
I'd much prefer to disable these tests in debug.
Or change our process (we can add a script) to build all the necessary bits to run tests in debug and release.

Also, wouldn't this be considered a regression?  this is something we were clearly able to do before.
Now, we are saying UT's with debug bits don't work.

If you build the tools.sln locally, this would work fine. The "Right" thing would be to move these tests to the logging project (part of tools.sln) - that is what these tests are testing anyway.

Can we file a task to move the tests then if that is the right solution?

@pradipd this is the task :).

I am just going to disable these tests.  Right now, in release mode, it isn't doing any validation and in debug mode, it requires the tools project to be built in debug mode as well.


Aure Cli 2.37: Storage blob url:  the result url has "/" at the end, and in case of SAS token is used, the url becomes an invalid one.

Related command
az storage blob url
Describe the bug
The url generated by "az storage blob url" has "/" at the end, which makes the generated URL be invalid if sas token is used. See example below.
It works correctly with 2.36.
To Reproduce
15:02:22 [0] $ az version
{
"azure-cli": "2.36.0",
"azure-cli-core": "2.36.0",
"azure-cli-telemetry": "1.0.6",
"extensions": {}
}
15:02:28 [0] $ az storage blob url --account-name batchasrdev --container-name basic-e2e-encrypted --name "" --sas-token "se=2022-06-01T14%3A29%3A00Z&sp=rl&sv=2021-06-08&ss=b&srt=cos&sig=a"
https://batchasrdev.blob.core.windows.net/basic-e2e-encrypted/?se=2022-06-01T14%3A29%3A00Z&sp=rl&sv=2021-06-08&ss=b&srt=cos&sig=a"
15:03:52 [0] # az version
{
"azure-cli": "2.37.0",
"azure-cli-core": "2.37.0",
"azure-cli-telemetry": "1.0.6",
"extensions": {
"application-insights": "0.1.16"
}
}
15:03:58 [0] # az storage blob url --account-name batchasrdev --container-name basic-e2e-encrypted --name "" --sas-token "se=2022-06-01T14%3A29%3A00Z&sp=rl&sv=2021-06-08&ss=b&srt=cos&sig=a"
"https://batchasrdev.blob.core.windows.net/basic-e2e-encrypted?se=2022-06-01T14%3A29%3A00Z&sp=rl&sv=2021-06-08&ss=b&srt=cos&sig=a/"
Expected behavior
The "/" at the end should be removed, so that the generated SAS url is a valid one.
Environment summary

Additional context

storage


Add container image support for Multus

This change adds the build manifest for the Multus container image.
https://github.com/SUSE/avant-garde/issues/1809

@rktidwell : Please make Makefile a soft-link to ../.images.Makefile similar to other images.

I was looking in github at the source and it doesn't render the contents of a symlink, so I misunderstood what was happening. Should be fixed now.


[WEBSITE-551] Enable return of objects without types

Will enable to return of blank nodes and other objects with no type

Coverage remained the same at 100.0% when pulling 58593c1eb75dc5221f854a9f09c3f905cc3b3fc5 on katylouise:katylouise/website-551_return-a-z-letters into e8b9ee0b44bad6e74d2fcaa35b6d4694352e006f on ukparliament:master.


chore: deprecate /superset/filter/... endpoint, migrate to apiv1

SUMMARY

Deprecates /superset/filter/<datasource_type>/<datasource_id>/<column_name>/ endpoint
Creates a new, more REST-ful endpoint to replace it

/api/v1/datasource/<datasource_type>/<datasource_id>/column/<column_name>/values/

Other improvements include better test coverage, better error handling, and an openapi spec
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Hi! Should we use dataset name instead of datasource in the new v1 API?

Hi! Should we use dataset name instead of datasource in the new v1 API?

Hi there! I think it makes sense to have a /datasource blueprint/namespace in the v1 API since datasets are a type of datasource, but there can be other types as well.
There are several "datasource APIs" in this file that I think can be moved here as well for 3.0.
It is somewhat confusing, but I think it would be more confusing to put all these under /dataset


[Bug]:  Docker Cannot find module '@remix-run/server-runtime'

Which Remix packages are impacted?

[X] remix (Remix core)
[ ] create-remix
[ ] @remix-run/architect
[ ] @remix-run/cloudflare-workers
[X] @remix-run/dev
[ ] @remix-run/express
[ ] @remix-run/netlify
[ ] @remix-run/node
[ ] @remix-run/react
[ ] @remix-run/serve
[ ] @remix-run/server-runtime
[ ] @remix-run/vercel

What version of Remix are you using?
1.1.1
What version of Node are you using? Minimum supported version is 14.
17
Steps to Reproduce
I'm running remix using the following docker file

Expected Behavior
I t should run as expected It
Actual Behavior
It throws this error

I manually added to dependencies @remix-run/server-runtime and @remix-run/node and it seems to be working fine


Add the additional "worker_name" property to browserObject (fix #5)

\cc @inikulin @AlexanderMoskovkin

FPR

lgtm

lgtm

We need to publish new version I guess

We need to publish new version I guess

@churkin please publish it. testcafe-browserstack is published from you npm account. BTW, We need to update the version before publishing

@AlexanderMoskovkin  done


Add tooltips

Search, Settings and Logout icons should have tooltips when hovered over for a second or so.

Tooltips added in #102  :smile:

Great stuff!
Further enhancement, for tooltips on:

Exclamation symbol
Question mark symbol
PR
"Mark all repo as read" tick icon

Even more tooltips added on #126


Account Usages api calls

function needed to grab account usage quick view.

Added, now just need to output as human friendly format instead of json

Ill want to explore these endpoints too:
https://api.openai.com/v1/usage
https://api.openai.com/dashboard/billing/credit_grants

Will revisit when my current free credit line ends or is exhausted. Not sure credits will mean much after.

Having it report current month's usage + hard limit subscription status.
Happy with this.


Brandon Ling - FW102 Onboarding

Contains the onboarding tasks for 102 including the queue and tasks.
I included the screenshot of 101 hello world in my discord thread, though it is not in this PR.

Closing, please see comment on 103


User-friendly dashboard that can be used by non-experts in different application fields (Dash)

NOTES:

The modifications I have made are all in the dashboard folder (kooplearn\dashboard)
I have added python files needed to run the dashboard (such as featuremap_example.py)
I have modified the utils.py file, as well as the entire contents of the app.py file

HOW TO USE:

Before launching the dashboard, make sure that all the python libraries required to run the dashboard are installed (pip install -r .\kooplearn\dashboard\requirements.txt).
To launch the dashboard from the main "kooplearn" folder, run the command "python .\kooplearn\dashboard\app.py".
The dashboard allows the user to control the various parameters of models and datasets, and visualize results in the form of graphs.
On the dashboard, you can navigate through the different types of filters and graphs.
IMPORTANT: After modifying the various parameters, always click on the "Update Plots" button to visualize the results.

Thanks for the contribution @zbakhm!


Export transactions history to the file

Export in CSV format, according to the order that in the wallet
Share via share menu
Save file (Open question for Android about permissions)

The export file should look like this

Actual:

Сolumns "transaction fee" and "transaction ID" not true.

checked


Python Edge driver; Cannot find MSEdge binary

Using the example code provided in the README, I receive the error WebDriverException: Message: unknown error: cannot find MSEdge binary
Edge version:  Version 84.0.522.15 (Official build) beta (64-bit)  (and corresponding webdriver)
Python version: 3.8
msedge-selenium-tools==3.141.1
selenium==3.141.0
Code to reproduce:
from msedge.selenium_tools import Edge, EdgeOptions

webdriver_location = "C:\\Path\\To\\msedgedriver.exe"

options = EdgeOptions()
options.use_chromium = True
driver = Edge(options=options, executable_path=webdriver_location)

My only thought is perhaps that this doesn't work with the beta build?

Fixed by adding the following
options.binary_location=r'C:\Program Files (x86)\Microsoft\Edge Beta\Application\msedge.exe'

:)

(WSL2)
Hey, I feel like I recreated the error you were having but for me your fix isn't working
webdriver_location = '/mnt/c/WebDriver/bin/msedgedriver.exe' options = EdgeOptions() options.use_chromium = True options.binary_location = '/mnt/c/Program Files (x86)/Microsoft/Edge/Application/msedge.exe'
webdriver_location = 'C\\WebDriver\\bin\\msedgedriver.exe' options = EdgeOptions() options.use_chromium = True options.binary_location = 'C\\Program Files (x86)\\Microsoft\\Edge\\Application\\msedge.exe'
I have tried both ways and none works, and i have all of those folder in path.
Error:
´selenium.common.exceptions.WebDriverException: Message: 'C\WebDriver\bin\msedgedriver.exe' executable needs to be in PATH. Please download from http://go.microsoft.com/fwlink/?LinkId=619687´

(WSL2)
Hey, I feel like I recreated the error you were having but for me your fix isn't working
webdriver_location = '/mnt/c/WebDriver/bin/msedgedriver.exe' options = EdgeOptions() options.use_chromium = True options.binary_location = '/mnt/c/Program Files (x86)/Microsoft/Edge/Application/msedge.exe'
webdriver_location = 'C\\WebDriver\\bin\\msedgedriver.exe' options = EdgeOptions() options.use_chromium = True options.binary_location = 'C\\Program Files (x86)\\Microsoft\\Edge\\Application\\msedge.exe'
I have tried both ways and none works, and i have all of those folder in path.
Error:
´selenium.common.exceptions.WebDriverException: Message: 'C\WebDriver\bin\msedgedriver.exe' executable needs to be in PATH. Please download from http://go.microsoft.com/fwlink/?LinkId=619687´

Thank you, your variant works in Edge Can v,87.0.656.0


Permissions Issues when Copying Folders from Mounted archive

Hiya
Recently my partners laptop stopped booting and I used Clonezilla to make an image of the failing SSD to attempt data recovery.
I've connected to the NAS on a Windows machine, and used clonezilla-util to get everything running using the Mount a Clonezilla archive in Windows option as it seemed the most native experience for my partner to go through and grab what she needs.
We seem to be able to copy over induvidual files no issue.
But, when we try to copy over folders, we get the follwing message:

When we hit continue, we get this message:

I've tried to resolve this by giving the user Full Control of the destination folder, no luck.
I'm figuring this all out as I go so if I have missed something or if anyone has any solutions I'm all ears! :)
Thanks for this handy utility!

Update:
I ended up grabbing the .img file for the partition with all the user data and mounting it with OSFMount which helped me quickly learn that I didn't have permission to access the user folder.
I dismounted it as I had it in Read-Only mode and unticked it so I could write as well, gave my user permissions and presto! So far so good when it comes to accessing and copying folders over!
I imagine there's a way to use the original login info for the user on the original drive as opposed to forcefully giving all the permissions to the new user info on the new drive but I'm a bit fresh to this and went for the hard and fast option but if anyone can enlighten me on this I'd love to know.
Also, if anyone has any better suggestions than my approach to this I'm all ears.
Thankfully this was a little 128GB drive, if this was larger I'd be in a bind!

Thanks Nishy, it's great you successfully recovered files :)
Interesting about OSFMount.
Did you happen to try the Mount as Image files approach? I think 7-Zip may ignore the permissions of the files, allow you to copy easily.
Cheers,
Fidel

Heya thanks for getting back to me!
I did try Mount as Image Files and had a similar issue unfortunately

I did notice this when trying to mount this on a Mac with the help of Paragon - NTFS for Mac

So it could be the fact that it's hibernated playing a role here.
Not sure how to even go about taking it out of hibernation without being able to boot into it in the first place 😅
Either way, slowly learning things from this and also discovered that my partner actually used OneDrive so a bunch of her sentimental/important stuff is already backed up!


re-enable --checked

Re-enable --checked - fix https://github.com/flutter/flutter/issues/3850.

LGTM


Initial attempt at static deploy to github pages

First stab at a deploy to Github Pages. This is necessarily temporary during development and will not be where our site lives. Notably, we should be able to reuse this infrastructure in the future regardless of:

Whether we continue with gatsby or another static site framework, or
Whether we post to gh pages

Unfortunately this is blocked for now -- gatsby build is failing.
This is due to two factors, as far as I can tell so far:

The previously-mentioned Trussworks SSR bug (1250)
gatsby-plugin-intl appears to have introduced some dynamism which needs to be tracked down - we're seeing error Building static HTML failed for path "/es/" during the latest build

I will track these down today and remove the draft keyword


i am having difficulty trying to start developing using flutter on windows 10

Steps to Reproduce
1 installed flutter extracted to my users/username/developments/sdks folder
2 added to path bin directory
3 did launch flutter doctor
4 istalled android studio command line tools from tools android sdk folder using cmd utility
5 accepted linenses (y,y,y,....) using cmd line utyility
Logs
since first launch of flutter doctor this message persists

flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 3.0.0, on Microsoft Windows [Version 10.0.19044.1706], locale ru-RU)
[√] Android toolchain - develop for Android devices (Android SDK version 33.0.0-rc4)
[√] Chrome - develop for the web
[☠] Visual Studio - develop for Windows (the doctor check crashed)
    X Due to an error, the doctor check did not complete. If the error message below is not helpful, please let us know
      about this issue at https://github.com/flutter/flutter/issues.
    X Exception: Bad UTF-8 encoding (U+FFFD; REPLACEMENT CHARACTER) found while decoding string: [
        {
          "instanceId": "9dfab431",
          "installDate": "2022-04-06T09:00:28Z",
          "installationName": "VisualStudio/16.11.14+32428.217",
          "installationPath": "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\BuildTools",
          "installationVersion": "16.11.32428.217",
          "productId": "Microsoft.VisualStudio.Product.BuildTools",
          "productPath": "C:\\Program Files (x86)\\Microsoft Visual
          Studio\\2019\\BuildTools\\Common7\\Tools\\LaunchDevCmd.bat",
          "state":<PHONE_NUMBER>,
          "isComplete": true,
          "isLaunchable": true,
          "isPrerelease": false,
          "isRebootRequired": false,
          "displayName": "Visual Studio Build Tools�2019",
          "description": "Visual Studio Build Tools �������� �����⢫��� ᡮ�� ᮡ�⢥���� � �ࠢ�塞�� �ਫ������ �� ���� MSBuild ���
          �ᯮ�짮����� �।� Visual Studio IDE. �������� ࠧ�� ��ਠ��� ��⠭���� ��������஢ � ������⥪ Visual C++, ATL, MFC �
          �����প� C++/CLI.",
          "channelId": "VisualStudio.16.Release",
          "channelUri": "https://aka.ms/vs/16/release/channel",
          "enginePath": "C:\\Program Files (x86)\\Microsoft Visual
          Studio\\Installer\\resources\\app\\ServiceHub\\Services\\Microsoft.VisualStudio.Setup.Service",
          "installedChannelUri": "https://aka.ms/vs/16/release/channel",
          "releaseNotes": "https://docs.microsoft.com/en-us/visualstudio/releases/2019/release-notes-v16.11#16.11.14",
          "thirdPartyNotices": "https://go.microsoft.com/fwlink/?LinkId=660909",
          "updateDate": "2022-05-12T00:19:32.0987311Z",
          "catalog": {
            "buildBranch": "d16.11",
            "buildVersion": "16.11.32428.217",
            "id": "VisualStudio/16.11.14+32428.217",
            "localBuild": "build-lab",
            "manifestName": "VisualStudio",
            "manifestType": "installer",
            "productDisplayVersion": "16.11.14",
            "productLine": "Dev16",
            "productLineVersion": "2019",
            "productMilestone": "RTW",
            "productMilestoneIsPreRelease": "False",
            "productName": "Visual Studio",
            "productPatchVersion": "14",
            "productPreReleaseMilestoneSuffix": "1.0",
            "productSemanticVersion": "16.11.14+32428.217",
            "requiredEngineVersion": "<IP_ADDRESS>063"
          },
          "properties": {
            "campaignId": "20",
            "channelManifestId": "VisualStudio.16.Release/16.11.14+32428.217",
            "nickname": "",
            "setupEngineFilePath": "C:\\Program Files (x86)\\Microsoft Visual Studio\\Installer\\setup.exe"
          }
        }
      ]
      .  Kindly follow up there for more info.
Thank you


Implicite wait

Does $("") method wait implicite for the element to appear? I guess it does but wanna be sure.
I think should is overengineering in this case right?
$("select[name='swimlanes']").should(Condition.exist).exists();
Sorry for the noob questions.

$(„“) does not do any search at all! It just defines locator of element.
but .should* all wait Configuration.timeout ms (it is not the same technology as in implicity Selenium-Waits, though.It is better one! But in general it works like implicit wait, yes.
$(„…“).should(Condition.exist); // no .exists() at the end
Better to static import Condition.*, then you have
$(element).should(exist), $(element).shouldBe(visible), $(element).shouldHave(text(„Ahoi“)) etc.
with nice readability.

Am 26.01.2017 um 11:24 schrieb apreg<EMAIL_ADDRESS>Does$("") method wait implicite for the element to appear? I guess it does but wanna be sure.
I think should is overengineering in this case right?
$("select[name='swimlanes']").should(Condition.exist).exists();
Sorry for the noob questions.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/codeborne/selenide/issues/460, or mute the thread https://github.com/notifications/unsubscribe-auth/AGQ4YErri9hUD59aOIJ-KUPkeRCpDIMeks5rWHRTgaJpZM4LufBj.

`  /**

Find the first element matching given CSS selector
@param seleniumSelector any Selenium selector like By.id(), By.name() etc.
@return SelenideElement
*/
public static SelenideElement $(By seleniumSelector) {
return getElement(seleniumSelector);
}`
I'm confused.
The problem for me with your proposed solution is that I need to give back a boolean but should gives back the element itself. So my final goal is to check whether an element is present with a little waiting.

Thank you it is indeed inconsistency in the docs! But it doesn’t search, believe me.
We’ll change this javadocs for better with new version!
Why do you need to get boolean back? Don’t you want to check if element is there?
use element.shouldBe(visible) for the most cases.
If you really want to wait more than standard for your apps (4-5 secs is typical for the most apps), you can do with
element.waitUntil(visible, 30000); // it is the same as shouldBe, but waits up to 30 seconds

Am 26.01.2017 um 11:36 schrieb apreg<EMAIL_ADDRESS>` /**
Find the first element matching given CSS selector
@param https://github.com/param seleniumSelector any Selenium selector like By.id(), By.name() etc.
@return https://github.com/return SelenideElement
*/
public static SelenideElement $(By seleniumSelector) {
return getElement(seleniumSelector);
}`
I'm confused.
The problem for me with your proposed solution is that I need to give back a boolean but should gives back the element itself. So my final goal is to check whether an element is present with a little waiting.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/codeborne/selenide/issues/460#issuecomment-275357383, or mute the thread https://github.com/notifications/unsubscribe-auth/AGQ4YAFMwCprJYow_9s34Zc373GPmWKrks5rWHdDgaJpZM4LufBj.

I believe you ;)

Defining SelenideElement doesn’t trigger the search in DOM yet, so you can save the locators in variables for later use at any place. With a SelenideElement instance, you can either do action with it (click, setValue etc.) or check a condition: shouldHave(text("abc")). Both will trigger the search of the elements in DOM.

Why do you need to get boolean back? Don’t you want to check if element is there?

In my pageobject there are helper methods which give back boolean for what I can assert and give custom error message in the test spec class.
So If I get it correctly if I want to wait for an element I should use should or waitUntil or maybe action like click.
I know I have other options too but these are the most prefered ones. To check whether the title is correct I use this method:
Wait().until(ExpectedConditions.titleContains("New View"));
To check page source I use this:
Wait().until(new Function<WebDriver, Boolean>() {
            @Nullable
            @Override
            public Boolean apply(@Nullable WebDriver input) {
                return source().contains(textToContain);
            }
        });

@apreg Please don't call exists() and return boolean. It's just nonsense.
Look, we have 2 options:

The element exists. In this case $("...").should(exist).exists(); always returns true.
The element doesn't exist. In this case ``$("...").should(exist)` throws an exception.

So, your method will never return false. And this is good. You test will either work or fail. Green or red. That's enough.
If you want to use custom error message in case of test failure, you can do it like this:
$("#lastLogin").should(exist.because("Last login should be shown for security reasons"));


Prod beta release

Rebase prod-beta with master

Codecov Report

Merging #2047 (33d9683) into prod-beta (1656095) will decrease coverage by 0.43%.
The diff coverage is 64.84%.

@@              Coverage Diff              @@
##           prod-beta    #2047      +/-   ##
=============================================
- Coverage      71.22%   70.79%   -0.44%
=============================================
  Files            372      403      +31
  Lines           6829     7341     +512
  Branches        1464     1567     +103
=============================================
+ Hits            4864     5197     +333
- Misses          1941     2118     +177
- Partials          24       26       +2

Impacted Files
Coverage Δ

src/api/costModels.data.ts
100.00% <ø> (ø)

src/api/costModels.ts
90.90% <ø> (ø)

src/api/forecasts/awsOcpForecast.ts
40.00% <ø> (ø)

src/api/forecasts/azureOcpForecast.ts
40.00% <ø> (ø)

src/api/orgs/org.ts
100.00% <ø> (ø)

src/api/providers.ts
85.71% <ø> (ø)

src/api/queries/query.ts
34.54% <ø> (ø)

src/components/charts/costChart/costChart.tsx
9.37% <ø> (ø)

...omponents/charts/dailyCostChart/dailyCostChart.tsx
7.89% <ø> (ø)

...ponents/charts/dailyTrendChart/dailyTrendChart.tsx
8.21% <0.00%> (-0.42%)
:arrow_down:

... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1656095...33d9683. Read the comment docs.


<EMAIL_ADDRESS>shows no errors in VS Code

TypeScript Version:  2.8.0-dev.20180322
VS Code Version: 1.21.1
Typescript does not seem to be sending VS Code information about compile errors in the latest build. I confirmed this after restarting VS Code and testing with a clean project. I'm reproducing it with just
const a: string = 123; // should have an error, none shows up in VS Code

but anything that should result in a compiler error reproduces it. Running tsc from the command line shows a compile error as expected so it's only in VS Code that it doesn't seem to work. It's also specific to today's release, 2.8.0-dev.20180321 from yesterday works as expected.
I created a gist of my VS Code logs from tsserver starting up with typescript.tsserver.trace set to verbose:
Here is the log where it doesn't work: Link
For comparison here is the equivalent log from 2.8.0-dev.20180321 where it works: Link

looks like a duplicate of https://github.com/Microsoft/TypeScript/issues/22790, should be fixed by https://github.com/Microsoft/TypeScript/pull/22791

👍 That’s actually a duplicate of this but no difference 🙂


What is the project template used for teams recording bot

Hi,
I would like to know the project template that is used for teams recording bot project. Please help with this information, thanks in advance.

The Console Template with the .Net Framework 4.7.2

just create  .net core console application then go and change targetframework inside proj file to 4.8


"Timeout error"

Hello, I'm writing you this e-mail because I've an important problem with the kinect, when I launch my program which uses the kinect (a visual studio solution compilated executable), I have the error "A timeout has occured when waiting for data".
I have the following software components and drivers :

the kinect driver "avin2-SensorKinect-28738dc"
the version <IP_ADDRESS> of OpenNI
the version <IP_ADDRESS> of Nite Bin

I tried different versions of everything (drivers, openNI and nite) but the error is stil there.
If you have any idea or if you can help me to solve this problem, I thank you very much and I'm wainting for your response.
cordially,
Vince

Does it still happen with the last stable version that was release last week?
Ziv.


content: deprecate --userspace instrumentation

What type of PR is this?
/kind content
Any specific area of the project related to this PR?
/area documentation
What this PR does / why we need it:
This PR  deprecates --userspace instrumentation
Which issue(s) this PR fixes:
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Andreagit97
Once this PR has been reviewed and has the lgtm label, please assign vjjmiras for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold
for 0.36

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, leogr
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS [leogr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/unhold


Closing All Tabs Will Break Lite XL

When all tabs are closed, only the status bar remains in the middle of the screen. The only way to recover from this state is by restarting the window or closing the application.

I've had several problems with tabs since version 1.6.10.

What plugins do you have installed? Maybe you should try running the editor without any user plugins and see if it's still broken.

Please check the plugins you have installed. This maybe a bug in lite-xl but I am not able to reproduce the problems you are reporting.

This appears to be an issue with a plugin. I'll try figuring out which one it is. Is there a specific function I should look for?

This issue seems to be caused by the Console plugin .

I looked into this and it seems like it only happens when both treeview.lua and console are enabled. I think treeview.lua is a plugin from my friend but I'm not sure.

Definitely some problem here. I'm experiencing the same behavior. So I decided to removed Console plugin and start again using cmd.exe

I guess this should be reopened if there is a problem in a plugin, since I see no Issue tracker in either plugins and franko/console repositories in case it's not an issue with the treeview.

In my case it was caused by a plugin from my friend.

Not sure which one it was, but going back to default plugins fixed it for me as well.

If you ever find a way to reproduce this problem I will be glad to work on that. I am sure there is a real bug lurking in lite-xl but I need a way to reproduce the problem.

If you ever find a way to reproduce this problem I will be glad to work on that. I am sure there is a real bug lurking in lite-xl but I need a way to reproduce the problem.

 Just a precision, you mean the original rxi/plugin or its adaptation for lite-xl, from franko/console ?

That's helpful, thank you. Just a precision, you mean the original rxi/plugin or its adaptation for lite-xl, from franko/console ?

That's a good question... Checking shell history it was with your adaptation. Ok, I re-enabled console with a fresh clone from your repo and I'm not getting the same issue on master branch, it only happens on dev branch.

I've had this issue as well - while using the terminal plugin.
How to reproduce:

Terminal: New
Open any file inside (one or more)
Terminal: Toggle
Close all file (I've used Ctrl+W, might not be the same for clicking on tab cross/close button)

This should have been fixed with #526. Could you test with master?

I am assuming #526 has fixed this. Please re-open if it hasn't.


gsc build fails for any distro workload on a Ubuntu 24.04 host system

Description of the problem
gsc build fails for any distro workload on a Ubuntu 24.04 host system
As per gsc requirement pip3 install docker jinja2 tomli tomli-w pyyaml when we try to install these libraries, it fails with below errors.
pip3 install docker jinja2 tomli tomli-w pyyaml
error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try apt install
    python3-xyz, where xyz is the package you are trying to
    install.

    If you wish to install a non-Debian-packaged Python package,
    create a virtual environment using python3 -m venv path/to/venv.
    Then use path/to/venv/bin/python and path/to/venv/bin/pip. Make
    sure you have python3-full installed.

    If you wish to install a non-Debian packaged Python application,
    it may be easiest to use pipx install xyz, which will manage a
    virtual environment for you. Make sure you have pipx installed.

    See /usr/share/doc/python3.12/README.venv for more information.

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 668 for the detailed specification.

Ubuntu adopted PEP 668 from 23.04 , which dictates that pip can no longer install packages managed by the distro's general-purpose package manager, hence we use apt-get. Above listed requirement are installed via apt, versions are mentioned below
docker: 5.0.3
jinja2 : 3.1.2
tomli : 2.0.1
tomli-w : 1.0.0
pyyaml : 6.0.1
Steps to reproduce

https://github.com/gramineproject/gsc/tree/master/test#building-sample-images
Expected results
./gsc build -nc --insecure-args bash-test test/ubuntu20.04-bash.manifest
Building unsigned graminized Docker image `gsc-bash-test-unsigned` from original application image `bash-test`...
Warning: Duplicate key `loader.env.PATH`. Concatenating values from `<merged test/ubuntu20.04-bash.manifest and ubuntu/entrypoint.manifest.template>` and `<bash-test image env>`.

Reading package lists...

Building dependency tree...

Reading state information...
coreutils is already the newest version (8.30-3ubuntu2).
The following additional packages will be installed:
  automake autotools-dev binutils binutils-common binutils-x86-64-linux-gnu
  ca-certificates cpp cpp-9 dirmngr dpkg-dev fakeroot file g++ g++-9 gcc gcc-9
  .....
  .....
  .....
  ....
  ...
  Step 29/29 : ENTRYPOINT ["/bin/bash", "/gramine/app_files/apploader.sh"]

 ---> Running in 93e57c7507b4
 ---> d734a23fb3fc
Successfully built d734a23fb3fc
Successfully tagged gsc-bash-test-unsigned:latest
Successfully built an unsigned graminized Docker image `gsc-bash-test-unsigned` from original application image `bash-test`.

Actual results
Error:
./gsc build -nc --insecure-args bash-test test/ubuntu20.04-bash.manifest
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/docker/api/client.py", line 214, in _retrieve_server_version
    return self.version(api_version=False)["ApiVersion"]
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/docker/api/daemon.py", line 181, in version
    return self._result(self._get(url), json=True)
                        ^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/docker/utils/decorators.py", line 46, in inner
    return f(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/docker/api/client.py", line 237, in _get
    return self.get(url, **self._set_request_timeout(kwargs))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/requests/sessions.py", line 602, in get
    return self.request("GET", url, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/requests/sessions.py", line 589, in request
    resp = self.send(prep, **send_kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/requests/sessions.py", line 703, in send
    r = adapter.send(request, **kwargs)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/requests/adapters.py", line 486, in send
    resp = conn.urlopen(
           ^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 791, in urlopen
    response = self._make_request(
               ^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/urllib3/connectionpool.py", line 497, in _make_request
    conn.request(
TypeError: HTTPConnection.request() got an unexpected keyword argument 'chunked'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/intel/jenkins/workspace/local_ci_graphene_gsc/gsc_dev_repo/./gsc", line 12, in <module>
    sys.exit(main(sys.argv))
             ^^^^^^^^^^^^^^
  File "/home/intel/jenkins/workspace/local_ci_graphene_gsc/gsc_dev_repo/./gsc.py", line 680, in main
    return args.command(args)
           ^^^^^^^^^^^^^^^^^^
  File "/home/intel/jenkins/workspace/local_ci_graphene_gsc/gsc_dev_repo/./gsc.py", line 284, in gsc_build
    docker_socket = docker.from_env()
                    ^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/docker/client.py", line 96, in from_env
    return cls(
           ^^^^
  File "/usr/lib/python3/dist-packages/docker/client.py", line 45, in __init__
    self.api = APIClient(*args, **kwargs)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/docker/api/client.py", line 197, in __init__
    self._version = self._retrieve_server_version()
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/docker/api/client.py", line 221, in _retrieve_server_version
    raise DockerException(
docker.errors.DockerException: Error while fetching server API version: HTTPConnection.request() got an unexpected keyword argument 'chunked'

Same problem. Install requests version 2.31.0 until it will be fixed
pip3 install requests==2.31.0 docker jinja2 tomli tomli-w pyyaml

pip can no longer install packag

We can no longer install packages via pip

Does it work if you install these packages from apt?

Does it work if you install these packages from apt?

All the packages are installed via apt

Root cause of the issue:
GSC uses Docker SDK for python for building the docker images which internally makes use of requests and urllib3 for connections with docker service.
Ubuntu 24.04 installs python3-urllib3=2.0.7 and python3-requests=2.31.0 versions which are not compatible as described here. This compatibility issue is fixed in Docker SDK for python version `6.1.0 with PR 3116 but Ununtu 24.04 installs Docker SDK for python version 5.0.3 which doesn't have the fix in it, hence we see the issue.

There are three approaches to fix this issue, @dimakuv @mkow, Please suggest which one suits better:

Force docker sdk fo python installation with pip using command: pip3 install docker --break-system-packages
Build/install  manually from source code:

git clone --branch 7.0.0 https://github.com/docker/docker-py.git
cd docker-py
python3 setup.py build
sudo python3 setup.py install

Test:
$ python3
Python 3.12.3 (main, Apr 10 2024, 05:33:47) [GCC 13.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import docker;
>>> client = docker.from_env()

Note: setup.py is not available after version 7.0.0 which break above command (build/install). I created an issue here for the same.

Wait for the python3-docker package upgrade to >=6.1.0 until Gramine announses support for ubuntu 24.04. This would automatically fix the issue. I have created a bug for ubuntu here

Gramine and GSC currently don't claim official support for Ubuntu 24.04. So I think we can safely wait for option 3 -- this bug should be fixed in Ubuntu itself, and looks like there is no easy workaround for GSC at the moment.
So my suggestion is to sit and wait for ~2 months. If nothing happens in this time frame, then we should revisit this issue.

@dimakuv @aneessahib @jkr0103
As we approach the Gramine 1.8 release and prepare for the official support of Ubuntu 24.04, we have been anticipating some resolution from the Ubuntu package manager regarding this issue. However, since I am still able to reproduce the problem, should we start considering alternative solutions to address this issue?

@anjalirai-intel The fix is currently in progress:

https://bugs.launchpad.net/ubuntu/+source/python-docker/+bug/2065348
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1073196

Given this, I would still prefer for this to be fixed in Ubuntu 24.04. From my understanding, the fix is very close to be available in Ubuntu 24.04.

There is duplicate big reported here which have current status about the bug:

Fixed in the development version that is the Oracular
Fix have been uploaded for Noble and is now in the SRU review queue

The bug is not being fixed as of yet, and the release date of Gramine v1.8 and GSC v1.8 is getting closer.
I propose to continue with solutions 1 (pip install) or 2 (manual install) from here: https://github.com/gramineproject/gsc/issues/202#issuecomment-2134551321
@woju What could you recommend? Maybe there's another solution to circumvent the bug in Ubuntu 24.04 with respect to this package?

The "correct" thing to do from Python POV would be to package gsc as a Python distribution, then instruct people to install it (and it's requirements that can't be installed from Linux distro's package manager) into virtual environment (virtualenv or venv). "Correct" is scarequoted, because this would require full reorganisation of the repository and God forbid if someone would be packaging a Python app, then user will be dealing with two different venvs at the same time, and that would almost guarantee that people will confuse those (unless they'd have expert knowledge about what package goes where, which they probably don't have because gsc is meant to be easy).
So people would do something like this:
python3 -m venv --system-site-packages ./venv
./venv/bin/activate
pip3 install .
gsc ...

There's also a hybrid approach that we can do right now: instruct people to get a venv, but run the script as we currectly do:
python3 -m venv --system-site-packages ./venv
./venv/bin/activate
pip3 install 'docker>=6.1.0'
./gsc ...

This will be also confusing to two kinds of people: 1) those who don't know python: wtf is venv; and 2) those who know python: why we don't install this package into venv.
Of those available ways, I suggest in order: 1) We wait as long as possible for Ubuntu to release those packages. If they can't make it before we want to release gsc, then 2) for now write in README that people install docker-py into venv and run gsc from activated venv. That's the least amount of work for us. If someone objects against that and say they want to install gsc into venv, then 3) we reorganise the GSC repo. That'd be some work (mainly because we also need to package templates), but overall doable and not very complicated. Worse, it'd be yet more work downstream if someone maintains internal GSC fork because IDK, maybe they have some changes to the templates or something like that.

Thanks @woju. The hybrid approach (where Python's venv inherits all system packages but only installs docker package via pip3) seems like the simplest workaround for now.
@anjalirai-intel @jkr0103 Could you test this approach? It should be enough to execute Woju's snippet to test it:
python3 -m venv --system-site-packages ./venv
./venv/bin/activate
pip3 install 'docker>=6.1.0'
./gsc ...

If this indeed works fine, then I propose to add a section on How to run on Ubuntu 24.04 in README and ReadTheDocs, with this bash snippet and short explanation (and a link to the to-be-fixed bug description). For ReadTheDocs, we have the Limitations section, so should be reasonable to add there: https://gramine.readthedocs.io/projects/gsc/en/latest/#limitations

If you add such a section, can you title it "... on Ubuntu 24.04 (and any recent distro compliant with PEP 668)"? It's not Ubuntu problem per se, eventually all distros (their recent versions) will need this or similar procedure.

For ReadTheDocs, we have the Limitations section, so should be reasonable to add there

I feel users might miss it if we add it to the limitations section as it's towards the end of document, also this is still a temporary workaround until fix is upstreamed.

Thanks @woju. The hybrid approach (where Python's venv inherits all system packages but only installs docker package via pip3) seems like the simplest workaround for now.
@anjalirai-intel @jkr0103 Could you test this approach? It should be enough to execute Woju's snippet to test it:
python3 -m venv --system-site-packages ./venv
./venv/bin/activate
pip3 install 'docker>=6.1.0'
./gsc ...

If this indeed works fine, then I propose to add a section on How to run on Ubuntu 24.04 in README and ReadTheDocs, with this bash snippet and short explanation (and a link to the to-be-fixed bug description). For ReadTheDocs, we have the Limitations section, so should be reasonable to add there: https://gramine.readthedocs.io/projects/gsc/en/latest/#limitations

@dimakuv We tried the venv experiment with Ubuntu 20.04 and Ubuntu 24.04 distro for bash workload, we were able to run the workloads, No issue seen with venv environment

then user will be dealing with two different venvs at the same time, and that would almost guarantee that people will confuse those

TBH, with a properly packaged application, they would be able to install gsc with pipx (as the externally-managed-environment error message says): pipx install gsc. It would live in a pipx-managed isolated venv, and users wouldn't need to know about venvs at all.

Wait for the python3-docker package upgrade until Gramine announses support for ubuntu 24.04. This would automatically fix the issue. I have created a bug for ubuntu here which is in confirmed state now.

Fix is upstreamed now for nobel. We can take back the venv workaround pushed with PR#214 and instruct to do sudo apt update && sudo apt install python3-docker --upgrade

@jkr0103 Feel free to submit a corresponding PR.


Validation fails for a ListField containing an EmbeddedDocumentField

Using ListFields which contain an EmbeddedDocument is messed up by the recent changes. See the test case below:
from django.test import TestCase
from mongoengine import EmbeddedDocument, StringField, EmbeddedDocumentField, Document, ListField
from rest_framework_mongoengine.serializers import DocumentSerializer

class EmbeddedThing(EmbeddedDocument):
    test_field = StringField()

class EmbeddingThing(Document):
    embedded_thing = ListField(EmbeddedDocumentField(EmbeddedThing))

class EmbeddingSerializer(DocumentSerializer):
    class Meta:
        model = EmbeddingThing

class EmbeddingTestCase(TestCase):
    def test_validation(self):
        serializer_in = EmbeddingSerializer(data={'embedded_thing': [{'test_field': 'Test'}]})
        assert serializer_in.is_valid()

Console output:
tests/test_5listembedded.py:22: in test_validation
    assert serializer_in.is_valid()
rest_framework_mongoengine/serializers.py:131: in is_valid
    field = self.fields[name]
/usr/lib/python3.5/site-packages/rest_framework/utils/serializer_helpers.py:137: in __getitem__
    return self.fields[key]
E   KeyError: 'embedded_thing.child'

This is misfeature of DRF.
The field should be declared as:
embedded_thing = ListField(child=EmbeddedDocumentField(EmbeddedThing))

I opened issue in DRF repo: https://github.com/tomchristie/django-rest-framework/issues/3681

I tried to change my code according to your suggestion, but unfortunately it still fails. I also noticed a potential namespace overlap for the ListField, so I updated my test case as can be seen below:
from django.test import TestCase
from mongoengine import Document, EmbeddedDocument
import mongoengine.fields as me_fields
from rest_framework_mongoengine.serializers import DocumentSerializer, EmbeddedDocumentSerializer
import rest_framework.fields as drf_fields

class EmbeddedThing(EmbeddedDocument):
    test_field = me_fields.StringField()

class EmbeddingThing(Document):
    embedded_thing = me_fields.ListField(me_fields.EmbeddedDocumentField(EmbeddedThing))

class EmbeddedSerializer(EmbeddedDocumentSerializer):
    class Meta:
        model = EmbeddedThing

class EmbeddingSerializer(DocumentSerializer):
    embedded_thing = drf_fields.ListField(child=EmbeddedSerializer())

    class Meta:
        model = EmbeddingThing

class EmbeddingTestCase(TestCase):
    def test_validation(self):
        serializer_in = EmbeddingSerializer(data={'embedded_thing': [{'test_field': 'Test'}]})
        assert serializer_in.is_valid()

Can you tell me what I am doing wrong?

Can you provide what result do you get?

Sure, sorry that I forgot in the first place.
===================================================================== test session starts =====================================================================
platform linux -- Python 3.5.0, pytest-2.8.3, py-1.4.30, pluggy-0.3.1
rootdir: /home/rumpf/django-rest-framework-mongoengine, inifile:
collected 69 items

tests/test_0dumb.py ...
tests/test_1basic.py ...ss.................
tests/test_1validation.py ...
tests/test_2geo.py s
tests/test_3embedded.py .............
tests/test_3reference.py ..........s.........
tests/test_4compound.py ......
tests/test_5listembedded.py F

========================================================================== FAILURES ===========================================================================
______________________________________________________________ EmbeddingTestCase.test_validation ______________________________________________________________
tests/test_5listembedded.py:35: in test_validation
    assert serializer_in.is_valid()
rest_framework_mongoengine/serializers.py:131: in is_valid
    field = self.fields[name]
/usr/lib/python3.5/site-packages/rest_framework/utils/serializer_helpers.py:137: in __getitem__
    return self.fields[key]
E   KeyError: 'embedded_thing.child'
======================================================= 1 failed, 64 passed, 4 skipped in 0.38 seconds ========================================================

Weird.
Working on it.

It's related to compound fieds validation.
Will fix ASAP.

Fixed for the simple case you provided.
(Still not sure about recursive/deep nested embeddings/lists)
Also, in mongoengine 0.9,
you may use mongoengine.fields.EmbeddedDocumentListField(document_type, **kwargs) as a shortcut of combination of {List/Embedded}Fields.
Also, in DRF,
you may use field = SomeSerializer(many=True) for such stuff.
Also, in DRFM
you may skip both embedded serializer and embedded field declaration (unless you need to tweak them). The DocumentSerializer can generate them implicitly (unless depth=0).
See your testcase


Feedback and question

Hi,
It's great to see your project finally registered and I also noticed your new Gattino plotting. I can't understand how productive you are.
A.
Your doc could mention R (and Python) more prominently, since I see it supported too:
"Here is an example from OlivePy, the python Cell"
I'm looking forward to trying out your project more, it seems to simply just work, after a (one-time, I guess) small delay.
Since this is a Julia project, Python users would need to set it up. I'm a Julia user first, and unlike Pluto which (kind of) Julia only, I think it's great you support more. I'm thinking it might draw in more Python and R users; to call Julia, reuse both ways. Possibly a really good setup for them could be done with a python package using JuliaCall from PythonCall.jl, at least when the protect more polished.
I'm curious, did you reuse much of Pluto (or its dependencies), since I can't see that done? Do you support importing all Pluto files, since they are plain Julia code? They have features that are based on JavaScript, so I'm not sure, maybe all of their features on from Jupyther just work?
I've seen people argue against (Python) notebooks, for some reasons, mostly that I recall, not being reactive, or reasons not applying to Pluto nor your project, except maybe if importing.
A.
There were slight editing/cursor and display issues:
A = [1 2;3 4]
2×2 Matrix{Int64}: 1 2 3 4
A^2.1
2×2 Matrix{ComplexF64}: 8.24768+0.02953im 11.8464-0.0135078im 17.7695-0.0202617im 26.0172+0.00926826im
[I could copy paste if highlighting from the result up, but strangly not if highlighting my code A, and "down" if you understand.]
I meant to type, ^2 and did, but sometimes ² which I could do with the keyboard (by accident, with same keys on my Icelandic keyboard), and it does display, but see concole error in C. on it.
B.
When using first there was a slight wait, I thought frozen explained by:
 ◓ olive
  ✗ olive
  0 dependencies successfully precompiled in 2 seconds. 3 already precompiled.
  1 dependency errored. To see a full report either run `import Pkg; Pkg.precompile()` or load the package
     Cloning git-repo `https://github.com/ChifiSource/Olive.jl`
  0 dependencies successfully precompiled in 3 seconds. 3 already precompiled.
  1 dependency errored. To see a full report either run `import Pkg; Pkg.precompile()` or load the package

[that error seemingly didn't stop me, at least not yet.]

A ( I )
This certainly would not be a bad idea -- I plan to expand this documentation (and rewrite some sections) into an eventual documentation that hosts Olive. The thing is that languages are added to Olive via an extension. OlivePy is cited as an example because this package is nearly done. And yelp, it ties the objects from all languages in together -- just as the tomlvalues cells do for data into Julia. There are just a few things left to do on that project, mainly some fixes for the ability to open .py files (rather than just using python in a .jl file) and updates to the syntax highlighter.
I did not use any Pluto tech-stack. Pluto files are not regular Julia files, though they do contain normal Julia code; they contain special characters which denote cells and a list of cells with their evaluation order at the top. Fortunately, IPyCells checks if a .jl file contains Pluto cells, Olive cells, or just regular Julia text -- so reading Pluto is in fact supported.
Writing to pluto... not so much.
A (II)
Hmm.. If I understand this correctly, you mean you are able to select from the end of the text but not the start? I will try to replicate the issue on my machine tomorrow. The error C seems to be coming from the fullstack parser -- I will look into making some updates to fix both of those. Thank you for bringing these to my attention :)
B
The line that this code comes from just does Pkg.add("Pkg"). This error might be some sort of fluke or something. I am not exactly sure how I could replicate this, or if solving such an issue falls into my hands. I will make sure to look into it a bit more before writing it off though.
Thanks for the issue and letting me know all of this, as well as the feedback ! Have a wonderful rest of your day 👍🏻

@emmaccode I can replicate the same error!
On the other hand, one recommendation from my side:
Skip the initial setup
Like Pluto, it'd be better if all stuff related to Olive went (by default) into .julia/olive_notebooks folder, and within the notebook, we had the option to save the notebook somewhere else if we actually wanted to.

Thanks a lot for your efforts on this project. ^^

I edited my comment to what I meant to say:

I've seen people argue against (Python) notebooks, for some reasons, mostly that I recall, not being reactive

I suppose most people in Python or R would just use what they are used to from their ecosystems, even if non-ideal, though there may exist some reactive notebooks there I do not know of. And Julia people would use Pluto (for reactivity), so it's unclear why they would use your project. Except for e.g. Python and R with. I'll look it over more, there are probably a not more features I'm overlooking.

I did not use any Pluto tech-stack. Pluto files are not regular Julia files, though they do contain normal Julia code; they contain special characters which denote cells

It's intriguing you wrote from scratch. It may be a pro and a con. I know of Pluto (and Neptune), though I don't use notebooks much. I've just tried a bit, and will see if I like yours better. Most users would want to know pros and cons of yours vs. other options, as users, but for you I would have thought helpful to reuse much code, less duplication, and then Pluto could even have reused your code.

closing this :)


Bugcrowd email+password login is broken

I am aware that the login workflow with bugcrowd doesn't work right now.
This is due to recent platform changes that moved the authentication to identity.bugcrowd.com.
Please use the _bugcrowd_session token as of now and pass it to the -t flag in bbscope bc.
Thanks

the tool doesn't fetch private programs on BC @sw33tLie

its not reliable at all over 20 private and public ones the tool didn't catch..

Hey @molitona, can you share here one public program that the tool didn't catch?
Thank you :)

oh sorry @sw33tLie  after re-checking they were "Joinable ones" not public but, for private programs (invite+joinable) the tool didn't catch +20 of them yesterday, what reason?

Hey, I don't see any obvious reason as of now.
Do you have telegram/discord/twitter so that we can find out why this happens privately?
Thanks

Hi, this should be fixed

hello @sw33tLie ,
sorry for late resp
with _bugcrowd_session lastest version
https://bugcrowd.com/bugcrowd
https://bugcrowd.com/foxycart
https://bugcrowd.com/freedomofpress
https://bugcrowd.com/statuspage
https://bugcrowd.com/whmcs
are not catched
used cmd:
bbscope bc -b -o u -t "XXX"

Hi,
there was an issue when iterating through the handle pages, sometimes the bugcrowd API doesn't return the correct total pages so I've changed the code and i don't trust that number anymore.
Could you check if now you get more programs?

it works fine now, all programs fetched. thanks!


caretPositionFromPoint

Can you add support for document.caretPositionFromPoint

It's not yet supported...???

It's not yet supported...???

It's supported in Gecko: https://searchfox.org/mozilla-central/source/dom/base/Document.h#3658

Available at https://caniuse.com/#feat=mdn-api_documentorshadowroot_caretpositionfrompoint


python3 default support & solving python3 buffer migration problems

python3 support has problems to buffer migration issues.
By following this official guide: http://python3porting.com/problems.html#bytes-strings-and-unicode
problems with byte and str buffers like the example below are solved.
Before doing these changes the hello world example would have produced errors while monitoring like the one below:
▶ make monitor
MONITOR
--- idf_monitor on /dev/ttyUSB0 115200 ---
--- Quit: Ctrl+] | Menu: Ctrl+T | Help: Ctrl+T followed by Ctrl+H ---
ets Jun  8 2016 00:22:57

rst:0x1 (POWERON_RESET),boot:0x13 (SPI_FAST_FLASH_BOOT)
configsip: 0, SPIWP:0xee
clk_drv:0x00,q_drv:0x00,d_drv:0x00,cs0_drv:0x00,hd_drv:0x00,wp_drv:0x00
mode:DIO, clock div:2
load:0x3fff0018,len:4
load:0x3fff001c,len:5552
ho 0 tail 12 room 4
load:0x40078000,len:0

Traceback (most recent call last):
  File "/home/sniper/esp/esp-idf/tools/idf_monitor.py", line 571, in <module>
    main()
  File "/home/sniper/esp/esp-idf/tools/idf_monitor.py", line 505, in main
    monitor.main_loop()
  File "/home/sniper/esp/esp-idf/tools/idf_monitor.py", line 269, in main_loop
    self.handle_serial_input(data)
  File "/home/sniper/esp/esp-idf/tools/idf_monitor.py", line 305, in handle_serial_input
    self.handle_serial_input_line(self._read_line.strip())
  File "/home/sniper/esp/esp-idf/tools/idf_monitor.py", line 313, in handle_serial_input_line
    self.lookup_pc_address(str(m.group()))
  File "/home/sniper/esp/esp-idf/tools/idf_monitor.py", line 403, in lookup_pc_address
    if not "?? ??:0" in translation:
TypeError: 'str' does not support the buffer interface
make: *** [monitor] Error 1

Also, since all buffers are figured out for python3, I think python3 should be the default interpreter for monitoring.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi,
I just used your patch as basis to verify if my WSL patch would work with python3. While trying it, I found the following potential issues:
Have you tried the patch with python 2? I see very strange output here:
$ make monitor
MONITOR
--- idf_monitor on /dev/ttyS3 115200 ---
--- Quit: Ctrl+] | Menu: Ctrl+T | Help: Ctrl+T followed by Ctrl+H ---
['e']['t']['s'][' ']['J']['u']['n'][' '][' ']['8'][' ']['2']['0']['1']['6'][' ']['0']['0'][':']['2']['2'][':']['5']['7']['\r']['\n']['\r']['\n']['r']['s']['t'][':']['0']['x']['1'][' ']['(']['P']['O']['W']['E']['R']['O']['N']['_']['R']['E']['S']['E']['T'][')']
...

I further noticed that the getkey_patched function will need some tweaking, too (when actively used; the original used sets unichr = chr when running on python3, if I understand it correctly).
Last, but not least:
If I enter a non-ASCII character (example: German Umlaut ä), this is just not forwarded to the serial port with the python 2 version. With your patch and python3, I see the following:
esp32> ä

Traceback (most recent call last):
  File "/home/enrik/esp-idf/tools/idf_monitor.py", line 571, in <module>
    main()
  File "/home/enrik/esp-idf/tools/idf_monitor.py", line 505, in main
    monitor.main_loop()
  File "/home/enrik/esp-idf/tools/idf_monitor.py", line 269, in main_loop
    self.handle_serial_input(data)
  File "/home/enrik/esp-idf/tools/idf_monitor.py", line 305, in handle_serial_input
    self.handle_serial_input_line(self._read_line.strip())
  File "/home/enrik/esp-idf/tools/idf_monitor.py", line 312, in handle_serial_input_line
    for m in re.finditer(MATCH_PCADDR, line.decode('utf-8')):
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xc3 in position 133: invalid continuation byte

Cheers,
Enrik

Hi @supernlogn ,
Sorry, I missed that you'd pushed more commits to this branch.
Unfortunately this PR branch doesn't work for me in either Python 2 or Python 3. (I get NameError: global name 'u' is not defined in both). Can you take another look, please?

It works for me in python3, but I use python3.4.3
Please do the experiment below and tell me the outcome,
so I can fix it for other python versions:
▶ python
Python 2.7.6 (default, Nov 23 2017, 15:49:48)
[GCC 4.8.4] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> u"asdasdasd"
u'asdasdasd'
>>>

~
▶ python3
Python 3.4.3 (default, Nov 28 2017, 16:41:13)
[GCC 4.8.4] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> u"asdasdasd"
'asdasdasd'
>>>

~
▶ python --version
Python 2.7.6

~
▶ python3 --version
Python 3.4.3

Thank you very much!

Code below fixes issues mentioned by projectgus above.
  def handle_key(self, key):
       if self._pressed_menu_key:
           self.handle_menu_key(key)
           self._pressed_menu_key = False
       elif key == self.menu_key:
           self._pressed_menu_key = True
       elif key == self.exit_key:
           self.console_reader.stop()
           self.serial_reader.stop()
       else:
           try:
               key = self.translate_eol(bytes(key, 'utf-8'))
               self.serial.write(key)
           except serial.SerialException:
               pass # this shouldn't happen, but sometimes port has closed in serial thread
           except UnicodeEncodeError:
               pass # this can happen if a non-ascii character was passed, ignoring

   def handle_serial_input(self, data):
       # this may need to be made more efficient, as it pushes out a byte
       # at a time to the console
       try:
           for b in data.decode('utf-8'):
               s = bytes(b,'utf-8')
               self.console.write_bytes(s)
               if s == b'\n': # end of line
                   self.handle_serial_input_line(self._read_line.strip())
                   self._read_line = b""
               else:
                   self._read_line += s
               self.check_gdbstub_trigger(s)
       except UnicodeDecodeError:
           pass

@projectgus  I have successfully changed the code as you suggested and also tested it.
In the tests I have used Greek and Latin characters in the terminal.
Also, I checked it in python3.5 and python2.7.
Also I updated my repo so It can be automatically merged.
I can upload the tests if you need them.
Thanks to everyone for your suggestions!


Add translations for Solar state

Solar State is just n Number.
For Example State 209. Should be "Kollektortemperatur zu gering"
(Therminator)

To fix: add so_state to strings.json, de.json and en.json similar to the other states.


Orphaned Language Generation Code

Describe the bug
LG code is orphaned when a "send response" widget is deleted.  That process may result in having (for example) errors such as unbalanced multi-line quotations.
Version
Version 1.1.1
Browser

Chrome 80.0.3987.165
OS

Windows
To Reproduce
Steps to reproduce the behavior:

create an empty bot
create a "send response" with something like - ``` (don't close the multi-line quote)
delete the widget
note that the lg code persists, even though an uncompleted multi-line should throw an error

Expected behavior
Deleting the "send response" widget should delete the code
Workaround
Use edit mode in the LG script to remove orphaned code

@boydc2014 can someone on your team look into this?

Sure, assigning @zhixzhan  on this.

Hi @marktab. Sorry for the blocking. This is indeed a LG bug. I have a PR to fix it in dotnet library and would have a fix in js library soon.  Before the update is merged into main and Composer, I suggest that you can add a newline after "```" to skip this issue as the workaround. Thanks.

This issue has been fixed on SDK side. It supposed to work when update LG version in Composer to the latest.

Thanks @Danieladu

Close it for it has been fixed in the latest sdk

Close it for it has been fixed in the latest sdk


Make the Scheduler adjust the steps taken relative to the gradient accumulation steps

Let the AcceleratedScheduler handle gradient accumulation steppage
What does this add?
This PR adjusts the logic in the AcceleratedScheduler to take into account gradient accumulation steps.
Who is it for?
Closes https://github.com/huggingface/accelerate/issues/1170
Closes https://github.com/huggingface/accelerate/issues/1160
Why is it needed?
Currently a behavior does not exist that will automatically "cut" the LR scheduler of a user if they pass in gradient_accumulation_steps, so unless they are careful and adjust their LR scheduler beforehand, they're not actually stepping properly with the lr scheduler.
What parts of the API does this impact?
User-facing:
None, explicitly
Internal structure:
AcceleratedScheduler's step function now will run n*num_processes where n==gradient_accumulation_steps to account for the difference.
To test performance, I ran the equivalent training of gradient_accumulation_steps==2 on a bs of 16, and a regular batch size of 32, with negligible performance differences (accuracy += 0.5%, F1 of 0.3). Likely due to batch norm layers
Usage Example:
When building the Accelerator, pass in adjust_scheduler_to_accumulation (default False) to enable this behavior:
    accelerator = Accelerator(
        cpu=args.cpu,
        mixed_precision=args.mixed_precision,
        gradient_accumulation_steps=2,
        adjust_scheduler_to_accumulation=True,
    )

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@sgugger good for review, a few notes:

You'll notice that in the test for grad_sync changes, for it to pass (and for everywhere to pass in general), having accelerator use the new stepped scheduler to True is used, and on every script we have this behavior of what should exist is what we've advertised using. As such, I think it would be good to change the default to True not False here, as users are expecting one thing rather than the other
Should we keep gradient_accumulation_steps as an arg in Accelerator? I'm leaning towards yes if we change the default to True for reasons above, though we can also just keep it there for usability. (In my eyes, users would likely not need to adjust the other param, hence we only need to expose gradient_accumulation_steps there


Handle de-select when selecting a non-visible object

Selecting a non-visible object in the tree view would not deselect the previously selected object in the 3D view, this PR fixes this use-case.

Thanks @martinRenou


AC and Spells not importing right

I am using 1.0.9 on Foundry 7.10.  prepared spells and effects that work with AC calculation are not syncing right.  what do I need to do on my end to get this working again?  Do I need to rule back to a previous version or something in the settings?

Please can you explain your issue a bit more and give an example? In addition can you upload a screen shot of the settings you're using on the Active Effects tab of the importer screen?

I might be able to clarify @Silzin 's error report, as I was experiencing similar issues with AC using the exact same versions of the Module and Foundry.
I performed a series of tests using all 8 Active Effect Option checkboxes, and I was able to get things to "work" using only the following options selected, and all others blank:

Generate Active Effects for Equipment
Generate Active Effects for Character Features/Racial Traits/Feats/Backgrounds
Retain Active Effects

So, that's the tl;dr of how to fix it.
Here are the specific issues I was having with the ddb-importer and examples of how to reproduce them:

Create a character with the Unarmored Defense feature in D&D Beyond.  Pull it over using the ddb-importer whilst either (1) selecting none of the Active Effect Option checkboxes, or (2) selecting only the Generate Active Effects for Equipment and Generate Active Effects for Character Features/Racial Traits/Feats/Backgrounds checkboxes.  Observe that the character is not getting the +2 AC bonus.

Create a character with the Disciple of Life feature in D&D Beyond.  Pull it over using the ddb-importer whilst either (1) only selecting the Copy Active Effect from DAE Compendiums checkbox, or (2) selecting the Retain Active Effects option, or (3) selecting both of them.  Observe that, when casting healing spells, the bonus (2+ spell level) is applied twice (when it should only be applied once).

Create a character and equip them with a shield (no other armor) in D&D Beyond.  Pull it over using the ddb-importer whilst either (1) selecting none of the checkboxes, or (2) selecting only the Retain Active Effects checkbox, or (3) selecting the Generate DAE Override ACs and the Copy Active Effect from DAE Compendiums and the Retain Active Effects checkboxes.  Observe that equipping or removing the shield has no effect on AC.  Now, open up a Compendium and add some armor (any type), and equip that.  The AC changes.  Now, try equipping the shield along with the Compendium armor.  No AC change.

(addendum to the above test)  If you were to only select Copy Active Effect from DAE Compendiums and Retain Active Effects in the test above, the Shield changes AC on its own.  And the Compendium armor changes AC on its own.  But equipping the two of them together results in an erroneous AC.

These are but a handful of test conditions that produce errors when moving characters from D&D Beyond to Foundry.  There are still about 20 or 30 more permutations that I haven't tested yet.
Regards,

@theMagius0 I suspect you are experiencing some desired/expected results here.
It sounds like you have "Auto calculate AC" and "Auto calc base AC" set in the Dynamic Active Effects settings page. As per the FAQ and help page, these settings are not compatible with DDB Importer. If it is set then DAE will adjust the base AC and try and calculate the AC based on the equipment attached.
Retain Active Effects will copy over any existing effects on a character, so may explain some of the activity you are seeing as effects from previous imports are retained.
Unarmored Defense If no options are selected on the Active Effects tab the AC imports successfully. Please make sure that DAE has not placed an AC Effect on the character.
Disciple of Life if you are only selecting "Copy Active Effect from DAE Compendiums" then this is the expected behaviour as DDB Importer does not understand what effects are already loaded in DAE and if it is not generating them itself will add the extra to the appropriate spells on import. This is expected behaviour (even if it's not what you might expect)
The AC issues are the exact behaviour when another module(DAE) adds AC. It does this when items are added to the characters sheet.

Sorry for not getting back to you.  I think you to hit it.  I have experimented a lot and I think my first fix was just not use any Auto AC and set it my self.  But now the DDB importer Auto AC is working with active effects.  but I do not use the Auto AC stuff in DAE.

Sincere apologies, @MrPrimate , but apparently I'm still not doing something correctly.
I have unchecked the two (2) boxes regarding AC calculation in Dynamic effects using After Effects settings.

If I have a Cleric with the Disciple of Life feature, I'm seeing the bonuses (2 + spell level) calculated twice in the chat window for the roll, when they should only be calculated once.

If I have a Sorcerer use her Shield spell, I'm not seeing any effect on AC whatsoever.

I've looked at the FAQ located at: https://github.com/MrPrimate/ddb-importer/blob/main/FAQ.md.
Can you please direct me to the 'help' page?
Thx,

@theMagius0 can you provide a character URL and a screenshot of the settings your using during import on the Active Effects tab?

Cleric URL is here: https://www.dndbeyond.com/profile/theMagius/characters/52514332.
Sorcerer URL is here: https://www.dndbeyond.com/profile/theMagius/characters/52514710
All Active Effect Options are unchecked because selecting some of them were yielding even stranger results than when I left them all unchecked (e.g. Shield spell would only show Concentration--not the Shield icon itself).
Is there a detailed tutorial on each of the Active Effect Options, by chance?  Perhaps I've not selected the correct permutation to achieve the result I'm looking for?
Or, perhaps I should be removing (unchecking) the DAE module whilst using the ddb-importer?  And then enable the DAE after characters have been imported into Foundry?  Would this yield better results?
Thx,

@theMagius0 it sounds like there are effects on your character already that are being transferred across.
The shield spell will only apply the effect when cast and you need a module like midi qol to do this for you.
You can see my importing these characters with the effects correctly:
https://cdn.discordapp.com/attachments/862745177521258528/862745238904373308/shield.webm
https://cdn.discordapp.com/attachments/862745177521258528/862745252497588264/d-o-life.webm

Appreciate you looking into this, sir.
I suppose it must be something else in my Foundry setup which is causing these errors, then.
I'll try and investigate on my end.
You may close this issue at your convenience.
Thx,

@theMagius0 if you struggle to resolve folks in the discord might be able to help you figure it out.


w07d02

comfort: 4
completeness:4

Good job on this hw, I encourage you to try the bonus when you have some time, or just think about how you might incorporate a swatch conceptually. :+1:


U38/t134 separate render objects

The objects in the scene have been split into:
static objects
have no copies and are essentially read only during runtime
game objects
used on the CPU and are updated each tick
render objects
copies of relevant data from the game objects taken at the end of each CPU tick

Denied pull request due to a bug where the program freezes in debug mode.
Reviewed by Samuel


Get autocomplete for function signature

Add this simply to the returned result of autocomplete plus
Potentially as a snippet (https://github.com/atom-community/autocomplete-plus/wiki/Provider-API): If your suggestion defines an anonymous snippet, you can provide the snippet here and it will be inserted via the snippets package

Add this simply to the returned result of autocomplete plus

FWIW a hover tooltip is quite useful even for now.

I am thinking of using this : https://github.com/atom/atom-space-pen-views#selectlistview

Could you please elaborate on how is your proposed solution different from a simple tooltip, like it's depicted above?
Also, that tooltip is not yet implemented, is it? I can see a tooltip for identifiers, but I can't get one on function signatures. So when you say "a hover tooltip is quite useful even for now", do you mean "would be useful", or do you mean "it already exists" but I don't know how to get it?

Also wait for https://github.com/atom-community/autocomplete-plus/pull/245

that tooltip is not yet implemented, is it?

It is if you hover over the bar identifier you will get that tooltip. Also for functions : https://github.com/TypeStrong/atom-typescript#type-information-on-hover

"a hover tooltip is quite useful even for now"

Yes, right now. But issue is with overloads its not so pretty. Definitely need work in this.

:+1:

is this issue still active?
I have the same problem atm.
using atom-typescript 11.0.3

Any update? That's the only reason keeping me from going back from vs-code.

@basarat Any news?


Refactor property handling in subclasses

@GuillaumeGomez Let's get this in before more merge conflicts happen :) I have more plans with this but that can come iteratively.

https://github.com/gtk-rs/examples/pull/335 is needed in addition for the examples to pass

I'll change things a bit more first. For properties I think this can be improved a bit further, and for signals I also have an idea.

Superseded by https://github.com/gtk-rs/gtk-rs/pull/31


Move to github.com/Shmew

Thanks @Shmew for volunteering as maintainer Feliz.MaterialUI! And thank you @cmeeren for all your work on it and for being proactive about finding someone. Much appreciated.
This PR updates links to the github repo and docs.
The repository defails will also need to be edited to use the new github pages url.

Don't forget to edit the repository details.

Whoops, thank you!


Safe intrinsics RFC

Allow intrinsics to be marked as safe, overriding the implicit unsafe from being in an extern block.
Rendered

Should we instead make intrinsics safe by default and then add an unsafe for transumute etc?

I'm marking this as T-lang, since I feel like the approach to intrinsics is fundamentally a language decision, but obviously this impacts libs too.
cc @rust-lang/lang @rust-lang/libs

I feel like intrinsics and lang items serve very similar purposes and I am not convinced we should have both of them. It feels like we could remove all intrinsics and replace them with lang items, which can assume arbitrary signatures -- we could then have the compiler have particular semantics when it calls a lang item. Frequently, I would imagine, the body of those lang items would be irrelevant, as the compiler will supply it (perhaps just panic!("should be generated directly by trans")). We could then choose to stabilize lang items like any other thing that we stabilize.

@nikomatsakis
This would rather mess the plan for SIMD intrinsics.

I agree that it's somewhat annoying that safe intrinsics have to be declare unsafe, but having to write a wrapper generally seems like it's just a bit of an annoyance. Two thoughts:

Are there numbers for the technical impact of just reexporting intrinsics vs writing wrappers for them? We've seen wins in the past, but not all intrinsics are that commonly called.
Could you elaborate on the problem with the likely/unlikely intrinsics? Not being able to implement an intrinsic is pretty strong motivation, but I'm unclear on the details here.

@alexcrichton
LLVM does not notice expect (used by likely/unlikely) unless they occur very close to the value's actual use - wrappers break this. An (at-first extremely limited) #[inline(rust_mir)] would solve this at the cost of some implementation work. Opportunistic MIR inlining (which me and @eddyb are thinking of doing) would also solve this if made to recognize unlikely.

@arielb1

This would rather mess the plan for SIMD intrinsics.

True, though I guess I've never been crazy about that plan anyway. That said, you can imagine handling SIMD intrinsics through some other attribute like #[simd_operation(add)] applied to a fn.

That said, you can imagine handling SIMD intrinsics through some other attribute like #[simd_operation(add)] applied to a fn.

...or just allow a "simd" lang item to be defined any number of times.

It seems a bit strange to me to have hundred/thousands of lines code like
#[simd_operation(x86_mm_sad_epu8)]
fn x86_mm_sad_epu8(x: u8x16, y: u8x16) -> u8x16 { panic!() }

What if you tie unsafety to the calling convention rather than whether it is in an extern block, so that "rust-call" methods are safe by default?

@huonw

It seems a bit strange to me to have hundred/thousands of lines of code like
#[simd_operation(x86_mm_sad_epu8)]
fn x86_mm_sad_epu8(x: u8x16, y: u8x16) -> u8x16 { panic!() }

Good case for a macro? We probably want one anyway, since libraries that re-declare these intrinsics will need a similar array of such declarations.
Anyway, taking a step back, clearly I'm proposing something somewhat orthogonal to this RFC, except that:

this RFC marches intrinsics one step closer to being stabilized, so deciding if we like the general way we are handling intrinsics seems important.
lang items already can be public, exported, safe, unsafe, whatever, so this proposal encompasses this RFC and then some. A growing array of attributes like #[safe], used to tweak various aspects of intrinsics we want to change, doesn't appeal to me. Being able to just make any declaration, of any kind, special seems like it addresses that.

@nikomatsakis If we stop using extern {} blocks for intrinsics, would we remove generics from them?
That made me think of the following possible strategy for C++ FFI. Somewhat offtopic, but I wanted to write it down:
extern "C++" {
    fn vector_push<T>(v: *mut stl::vector<T>, x: T) {
        v->push_back(x);
    }
}

I believe @mystor's crate is somewhat similar, although implemented via a plugin.

@eddyb, rust-cpp is similar in idea (body of code is C++, types declared in Rust & translated using simple-ish set of rules), however definitely doesn't support generics, or anything complicated, yet (I imagine that that would take more compiler support/hackery) ^.^ (sorry about off-topic)

@rfcbot fcp close
I move that we close this RFC. Not because I disagree with the sentiment: I think we will want to eventually have both safe and stable intrinsics. However, I would like to change the way we achieve that: I think it'd be better to just merge the idea of "intrinsics" and "lang items" -- so that an intrinsic is just a function with a suitable attribute.
I think the usual form would be as follows (hat tip to @eddyb):
#[lang name="special"]
fn special(x, y, z) -> T {
    special(x, y, z)
}

Having the fn calls itself is basically a convenient hack. This way, the compiler can detect direct calls to special and give them particular semantics. Indirect calls, if we decide to support them, fall out naturally from just treating special as an ordinary function -- since it contains a direct call, that inner call will be translated specially. (If we wish to prohibit indirect calls for some particular intrinsic, we can do it by prohibiting that particular lang item from being reified into a fn ptr.)

@nikomatsakis I'm in favor of a merger between lang items and intrinsics. This is a question we'll want to be thinking about as part of the recent work on SIMD, of course.

Having the fn calls itself is basically a convenient hack. This way, the compiler can detect direct calls to special and give them particular semantics. Indirect calls, if we decide to support them, fall out naturally from just treating special as an ordinary function -- since it contains a direct call, that inner call will be translated specially. (If we wish to prohibit indirect calls for some particular intrinsic, we can do it by prohibiting that particular lang item from being reified into a fn ptr.)

That's basically how <i32 as Add<i32>>::add etc. work?

@arielb1 Yeah, I think it's effectively the exact same idea.

The RFC bot seems to be stuck, but at this point the final comment period has elapsed. Nothing has changed since the earlier summary, so I'm going to go ahead and close the RFC. Let's revisit with a merger with lang items.
Thanks, @Aatch, for the RFC!

Is there an issue tracking the idea to merge "intrinsics" and "lang items"?

@dtolnay I don't think they'll ever be merged since they represent opposite directions of communication between the compiler and libraries. However, I still think #[intrinsic = "..."] (akin to #[lang = "..."]) is a good path to take here.
I'm not sure on the status, although something I should point out is that we could probably experiment with them in parallel with the old intrinsics, and reuse most of the implementation.


Mock Symfony Form 'query_builder' with Mockery

Guys,
I'm having a bit of trouble with the m::on() method when mocking a closure within an array value.
There's more of a description here

This has been resolved and I have posted my answer on the stack overflow question page.


doc: libuv does not touch uv_loop_t.data

Mea culpa, I forgot to update the documentation in commit ff0ae10
("unix: preserve loop->data across loop init/done") from July 2016.

I agree but libuv-on-unix used to clobber the field.  I phrased it this way to emphasize it doesn't anymore.


Need to close stream process?

I'm experiencing something very strange and can't find a solution, so thought I'd check to see if I was missing something.
I have an interface where users can set parameters and then download data files from our system.  I set this up to stream from the database request back through the API to the front end, and was using an older version of json2csv on the front end to synchronously catch the resulting data and make it into a file for download.  However, it was having issues with bigger files, and I decided to upgrade my json2csv to the current version and implement the Transform streaming in my API.  It is setup like this (a little differently from your docs for brevity, but I think I did this right):
import json2csv from 'json2csv'
const Json2csvTransform = new json2csv.Transform

// code ...

return inputStream
      .pipe(JSONStream.stringify())
      .pipe(Json2csvTransform)
      .pipe(res)
      .on('error', e => next(`Error: ${e}`))
      .on('finish', () => console.log("Streaming of file is now complete."))

However, when I added the ".pipe(Json2csvTransform)" to my streaming setup, I ran into an issue.  Files now download more quickly, and I don't have an issue with larger files anymore, which is great ... but I can no longer make another file request immediately after I finish downloading a file.  My logs tell me that the process runs, but no data returns ... until a few moments after everything completes, when my logging of data in my pipe finally returns the result I was expecting (by now, the code has all run with no results, so no file is created).  This registers as a failure for the user on the front-end, however.  Or, if I wait a few minutes, then I can successfully download again, but just not after one download completes.  File size and amount of data has no effect on this phenomenon.
If I comment out the ".pipe(json2csv)", everything goes back to normal and I can download files one after the other.  It's almost as if there's some part of the process that is not closing after the first file successfully downloads, and the error is only happening when I enable json2csv.  Has anyone come across something like this before, or have any idea what the cause might be?
I'm using the latest version of json2csv and am working in Node 8.9.1 and Chrome 65.

Have you tried creating a new Transform instance for every request?

  I had the Transform instance being created outside the request code.  Pulling it down a few lines eliminated the issue.  Thank you SO much!


Powershell Embedded C# code fails when using different "{" convention

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
I have a Powershell script with embedded C# code.
Being used to use the more compact "function {" programming convention for curly braces, I modified it by only moving { from below to next after the function name, like this:
Set-StrictMode -Version Latest
$ErrorActionPreference = 'Stop'
$CSharpCode = @'
...

public static SafeFileHandle GetConIn() {
    SafeFileHandle fileHandle = CreateFileW("CONIN$", GENERIC_READ, FILE_SHARE_READ, IntPtr.Zero, OPEN_EXISTING, 0, IntPtr.Zero);
    if (fileHandle.IsInvalid)
    {
        throw new System.ComponentModel.Win32Exception();
    }
    return fileHandle;
}
...
}
'@

$NativeMethods = Add-Type -Language CSharp -MemberDefinition $CSharpCode -Name NativeMethods -Namespace Console -PassThru -UsingNamespace 'Microsoft.Win32.SafeHandles' -ErrorAction SilentlyContinue
...

The script then fails with:
 $ .\get_console_mode_gist.ps1
Add-Type: C:\Users\xxxx\PowerShell\get_console_mode_gist.ps1:39
Line |
  39 |  … veMethods = Add-Type -Language CSharp -MemberDefinition $CSharpCode - …
     |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | Cannot add type. Compilation errors occurred.

Expected behavior
To not make a difference on where I put my `{}`'s.

Actual behavior
Fails due to placement of the `{}`s.

Error details
No response
Environment data
Name                           Value
----                           -----
PSVersion                      7.2.1
PSEdition                      Core
GitCommitId                    7.2.1
OS                             Microsoft Windows 10.0.19042
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Visuals
No response

You example ends with:
}
...
}
``
there is an extra parenthesis.

@iSazonov  I was not pasting the full code! (Added ... to show there is more, but completely irrelevant for the issue.

First convention fails. Why?

On further look it seem that compilation fails for any change at all to the C# code snippet.
Can someone explain why that is?

ok sorry, I missed the point of App Domain's.


Remove username and password

As we already have api keys management in B2B site I think we should to remove username and password fields from api.
let client = new Trustpilot(
  {
    apiKey: 'YOUR-API-KEY',
    secret: 'YOUR-SECRET',
    username: 'YOUR-TRUSTPILOT-B2B-USERNAME', // <-remove this
    password: 'YOUR-TRUSTPILOT-B2B-PASSWORD' // <-remove this
  });

Note: this is breaking change and release number should be updated accordingly to follow semver.

This package is not only used for our b2b site. Other users outside of TP are also using this module, and username and password are needed in cases, when they want to access the private endpoints.
However, I would like to see the AccessProvider was more modular, so it was possible to change to a different provider. Say a b2b AccessProvider which could accept an apiKey and an accessToken, and that provider could also handle refreshToken communication if needed.
Another example could be, another simpler AccessProvider, that only allowed accessing public API endpoints.

@anjmao Does Bardur's answer it? Can I close the issue?

@martinbuberl guess we can close this issue.


[Hotfix] Update registration prompts

Purpose
Update registration prompts and behaviors to match introduction of retractions/embargoes into production.
Changes

Update the preregistration prompt.
Update the post-registration make public prompt.
Remove make public functionality for registrations pending an embargo

Side Effects
N/A
Notes:
Closes-issue: #3286 and #3287

Sure can!
On Wed, Jun 24, 2015 at 10:42 AM, Steven Loria<EMAIL_ADDRESS>wrote:

Merged #3291 https://github.com/CenterForOpenScience/osf.io/pull/3291.
—
Reply to this email directly or view it on GitHub
https://github.com/CenterForOpenScience/osf.io/pull/3291#event-339013927
.

--
Harry Rybacki - Developer, Center for Open Science
Research: http://scinet.osf.io
Blog: http://rybacki.io
[image: http://github.com/harryrybacki]
http://github.com/HarryRybacki [image:
https://twitter.com/HarryRybacki] https://twitter.com/HarryRybacki [image:
http://www.linkedin.com/in/HarryRybacki/]
http://www.linkedin.com/in/HarryRybacki/ [image:
https://plus.google.com/+HarryRybacki]
https://plus.google.com/+HarryRybacki

@sloria upon further inspection I found that I had already made sure this wasn't possible on the back end. https://github.com/CenterForOpenScience/osf.io/blob/develop/website/project/model.py#L2408-L2411


[BUG] - Divider not work in vertial orientation when parent height is dynamic

NextUI Version
2.4.2
Describe the bug
maybe 'h-full' class only works  when the parent has a defined height.
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
not define height in parent
Expected behavior
divider need stretch to fill the parent height when parent's height not defined
Screenshots or Videos
No response
Operating System Version
macOS
Browser
Chrome

Can you share some code?

NextUI Components

Beautiful, fast and modern React UI library.

    <Divider className="my-4" />

Blog

      <Divider orientation="vertical" />

Docs

      <Divider orientation="vertical" />

Source

this code from Divider's doc, I remove h-5 in the div with id no-height

Hi @nealsun  this is not the bug, please try this snippet as I have tried working fine for me

Blog

        <Divider
          className="my-4 bg-[#A9ACA9] w-1 rounded-full mx-4 h-5/6"
          orientation="vertical"
        />

Docs

        <Divider
          className="my-4 bg-[#A9ACA9] w-1 rounded-full mx-4 h-5/6"
          orientation="vertical"
        />

Source

here is the result

@ShahirZain , the snippet you provided set the height h-12 in parent div explicitly. If children's height depend on the content which I generate dynamic that I can't set the height accurately. So remove the h-12, it‘s not work;

Hi @nealsun, try this code, am sure it will help.

NextUI Components

Beautiful, fast and modern React UI library.

<Divider className="my-4" />

Blog

  <Divider orientation="vertical" flexItem />

Docs

  <Divider orientation="vertical" flexItem/>

Source

@aditya-shrimali, no, divider still got 0 height.

@nealsun this was nothing, you just forgot to add bg color on dark background. Try this code

NextUI Components
Beautiful, fast and modern React UI library.

Blog

Docs

Source

@nealsun It was nothing, you just forgot to add bg colour on dark background. Use this line for the divider:  <Divider orientation="vertical" className="bg-white" flexItem />.

It's not a colour issue, I checked the element in chrome. and where is the `flexItem' prop defined?

Go through the official documentation, and try the background color thing

@nealsun It was nothing, you just forgot to add bg colour on dark background. Use this line for the divider:  <Divider orientation="vertical" className="bg-white" flexItem />.

It's not a colour issue, I checked the element in chrome. and where is the `flexItem' prop defined?

@aditya-shrimali can you share the link? Thanks a lot.

@nealsun https://mui.com/material-ui/react-divider/

@aditya-shrimali Sorry, I'm talking about nextui, not mui.

@nealsun Thanks for providing the code. A vertical divider has h-full class which means it sets the height to 100% of its parent, as long as the parent has a defined height.


Add toolsversion to shim so we can read it from VS.

Add toolsversion to shim so we can read it from VS. This makes it easier to warn for breaking changes, when the language service script is updated.

:+1:

:+1: