Browser location bar doesn't reflect the change of a route.push('/mynewroute')

Describe your issue:
using route.push('/mynewroute') change the effective route state but doesn't affect location bar.

If I add history.pushState({}, null, '/newroute') the location bar chnage and reflects teh new route

Can you reproduce the issue?
https://plnkr.co/edit/mzPkS7SFt2eS2wkyqK67

On which browser/OS does the issue appear?
Windows 10/ chrome 77, but I guess it's on all platform

Which version of Riot/route does it affect?
4.0.0-beta.1

How would you tag this issue?

[ ] Question
[X] Bug
[ ] Discussion
[ ] Feature request
[ ] Tip
[ ] Enhancement
[ ] Performance

Fixed in 4.0.0-beta.2


Safari on iOS not support?

Since Safari mobile not support document.registerElement:
https://developer.mozilla.org/en-US/docs/Web/API/Document.registerElement
So an error will be thrown here:
https://github.com/erikringsmuth/app-router/blob/master/src/app-router.js#L13

Most browser's don't support it yet. Hence, the polyfill https://github.com/WebComponents/webcomponentsjs.

got it


Feature discussion: Add option :namespaced

I'm using dry-transaction and dry-container in my current project. Usually I create transactions in nested namespaces like: Api::V1::Customer::Authenticate.
So when I configure the Transaction I would like to give it a namespaced option.
Usage:
module Api
  module V1
    module Customer
      module Authenticate

        register :step_one, -> input { } # those are registered as 'api.v1.customer.authenticate.step_one'
        register :step_two, -> input { }

        Transactions = Dry::Transaction(
          container: MyApp::Container,
          namespaced: 'api.v1.customer.authenticate')
          {
            try :step_one, catch: MyApp::OhNo
            tee :notificate_something, with: 'notifiers.customer.authenticated_bro'
            map :step_two
          }
      end
    end
  end
end

Not that when :with is used it should ignore the current namespace so we can access other dependencies registered within the container.
Could this be accomplished differently?
I know that I could just call step 'api.v1.customer.authenticate.step_one' but it's a bit verbose...

@mrbongiolo Sorry for my delayed response here. Just wanted to check whether your usage is still the same as you described, or did you find a way to improve things?

@timriley I have not looked over this option lately, as I'm using one container per operation, yeah I know. But I guess this would still help when working with a single app container and multiple levels of namespaced calls.

Closing due to inactivity. I think most people seem fine with the behaviour as-is :)


Text jumping when difference in textSize so big.

I have a problem with text jumping when difference between textSize and selectedTextSize 2 times. Can we make text size changes smooth when scrolling up and down?
How to reproduce:
numberPicker.setTextSize(30); numberPicker.setSelectedTextSize(60);

Also found the same with settings
app:np_selectedTextSize="24sp"
app:np_textSize="19sp"
Any updates on that?


[Snyk] Security upgrade mysql from latest to 8-oraclelinux8

This PR was automatically created by Snyk using the credentials of a real user.Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

app-java/docker/Dockerfile.mysql

We recommend upgrading to mysql:8-oraclelinux8, as this image has only 29 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

614
Use of a Broken or Risky Cryptographic Algorithm SNYK-ORACLE8-LIBGCRYPT-2939537
No Known Exploit

614
NULL Pointer Dereference SNYK-ORACLE8-OPENSSL-2579494
No Known Exploit

614
Improper Certificate Validation SNYK-ORACLE8-OPENSSL-2579569
No Known Exploit

614
Information Exposure SNYK-ORACLE8-OPENSSLLIBS-3368726
No Known Exploit

614
Double Free SNYK-ORACLE8-OPENSSLLIBS-3368727
No Known Exploit

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Use of a Broken or Risky Cryptographic Algorithm
🦉 NULL Pointer Dereference

done


In memory caching lead to crash

Issue
In the context of doing topic modeling experiments, @m09  and myself tried to use Gitbase to parse all blobs in tagged references of a given repository, in order to extract all identifiers, comments and literals. However, we have not been able to successfully use Gitbase to do so, and have had to switch to doing the parsing client side.
The reason for that is that, when querying Gitbase, we see the following behavior:

An increase in memory usage.
No decrease after time goes by.
When all available memory is consumed, an increase in block I/O and a quasi stagnation of the memory consumed by Gitbase at 99.999 ... %, indicating heavy use of Swap memory.
Server crash if the query goes on for too long past that point.

We still see the same behavior when retrieving only the blob contents from Gitbase, however the memory consumed is not an issue, as it is much less then when parsing UASTs. We have inferred that there was some caching going one, and after talking about the issue on the dev-processing channel, we tried to disable the caching - however it changed nothing. Javi told us that the caching we had disabled was for go-git cache, so it is probably something else.
What we don't understand is why we cannot get rid of the behavior, i.e. why once a blob has been parsed and returned client side it seemingly remains in memory.
Steps to reproduce
Launch gitbase and babelfish containers:
docker run -d --rm --name bblfshd --privileged -p 9432:9432 -m 4g bblfsh/bblfshd:v2.14.0-drivers
docker run -d --rm --name gitbase -p 3306:3306 --link bblfshd:bblfshd -e BBLFSH_ENDPOINT=bblfshd:9432 -m 2g -v /path/to/repos:/opt/repos srcd/gitbase:latest

With /path/to/repos pointing to a repository, for instance pytorch. Then, open two more terminals to monitor what's happening with docker stats, and run queries like this one for example for pytorch, using for example the mySQL client:
   SELECT
        cf.file_path,
        cf.blob_hash,
        LANGUAGE(cf.file_path) as lang,
        uast_extract(uast(f.blob_content, LANGUAGE(cf.file_path), '//uast:String'), "Value")
    FROM repositories r
        NATURAL JOIN refs rf
        NATURAL JOIN commit_files cf
        NATURAL JOIN files f
    WHERE r.repository_id = 'pytorch'
        AND is_tag(rf.ref_name)
        AND lang ='Python'

You should see the memory usage of the gitbase container increase sharply until hitting 2 GB, then a heavy increase in BLOCK I/O, and finally the container will crash.

From the top of my head, some things that you must to do to try to mitigate the problem:

You are limiting memory usage to 2gb, then if suddenly a huge file is loaded into the cache, the container will crash. Add a filter on where clause to limit the size of processed files, per example to 10M or so.
You are processing all the references for all the repositories. If that is not intended and you want to only process HEAD, add a filter on where clause to just use HEAD references on all repos.
Do not process the file if it is binary. Add IS_BINARY to where clause.

Thanks for the quick advice @ajnavarro :bowing_man:
As @r0mainK mentioned we mitigated the problem already (by using gitbase for blobs and using the bblfsh python client to then extract UASTs). This is good enough for now but we will need to scale up this effort though in the future.

Also, if the problem is only when parsing UASTs, you can change GITBASE_UAST_CACHE_SIZE env from 10k as default to a lower number.

@ajnavarro unfortunately, still on the same example (Python files in Pytorch's tagged references):
mysql> SELECT COUNT((t.blob_hash, t.file_path)) FROM (
    ->    SELECT DISTINCT
    ->         cf.blob_hash,
    ->         cf.file_path,
    ->         LANGUAGE(cf.file_path) as lang
    ->     FROM repositories r
    ->         NATURAL JOIN refs rf
    ->         NATURAL JOIN commit_files cf
    ->         NATURAL JOIN files f
    ->     WHERE r.repository_id = 'pytorch'
    ->         AND is_tag(rf.ref_name)
    ->         AND lang ='Python' ) t;
+-----------------------------------+
| COUNT((t.blob_hash, t.file_path)) |
+-----------------------------------+
|                              4211 |
+-----------------------------------+

mysql> SELECT COUNT((t.blob_hash, t.file_path)) FROM (
    ->    SELECT DISTINCT
    ->         cf.blob_hash,
    ->         cf.file_path,
    ->         LANGUAGE(cf.file_path) as lang
    ->     FROM repositories r
    ->         NATURAL JOIN refs rf
    ->         NATURAL JOIN commit_files cf
    ->         NATURAL JOIN files f
    ->     WHERE r.repository_id = 'pytorch'
    ->         AND is_tag(rf.ref_name)
    ->         AND lang ='Python'
    ->         AND NOT IS_BINARY(f.blob_content)
    ->         AND f.blob_size < 1000000
    ->     ) t;
+-----------------------------------+
| COUNT((t.blob_hash, t.file_path)) |
+-----------------------------------+
|                              4211 |
+-----------------------------------+

As you can see, the issue does not seem to be mitigated using these additional clauses, as they don't apply. Furthermore, the intent is to process all files out of tagged references, not only the HEAD - hence the is_tag clause.
Additionally, the issue is that even when we try to separate large queries into smaller ones in order to parse less blobs per query, for example parsing language by language or ref by ref, since the memory is not released it ended up changing nothing.

@ajnavarro so setting GITBASE_UAST_CACHE_SIZE=0 seemed to make things better, I was able to parse all 4211 python blobs, however I could still see the memory increase to the limit - just lower. When I tried parsing all blobs from tagged references (after restarting the container and setting the memory to 4GB), it maxed memory then crashed after parsing 4393 blobs (out of 20k blobs).
It seems there is some other caching going on, that is neither controlled by this variable or (I guess), GITBASE_CACHESIZE_MB, since it defaults to 512MB. That or some kind of memory leak, although I wouldn't know.

@r0mainK we have several LRU caches based on the number of elements, not on the total size of these elements. We should have a look into that and find ways to homogenize how to set limits to cache more user-friendly.

Okay great, well anyway as Hugo said for the moment we are bypassing Gitbase - even though that comes with it's share of problems - but ideally we would like to only use Gitbase, so I'll be looking forward to trying to solve this issue with these limits if you find the time :)

This will probably be fixed by https://github.com/src-d/gitbase/issues/929

Currently there's a PR #957 adding it to gitbase. When it's merged and released let's give it a try to see if this is solved.

I just tested this with the gitbase image built from master, using the same set up described by @r0mainK but adding -e MAX_MEMORY=1024 to the gitbase container to limit the cache memory to 1GiB and it seems to work. The memory usage of the gitbase container did not exceed ~1.3GiB, the block I/O did not go crazy and the query actually finished.
It is not yet released, but you can take an early look if you need it, @r0mainK.

@r0mainK apparently it's already released in v0.24.0-beta3. Can you give it a try and see if it works for you?

Just FYI @r0mainK comes back from holidays next monday.

No problem @m09

UPDATE: beta3 does not fix the error, we're cutting a rc1 version with the complete fix.

Released! You can use this version to test: https://github.com/src-d/gitbase/releases/tag/v0.24.0-rc1

I just tested, so for the query above it seems to be working, I saw on docker stats that the memory usage stagnates around 1.13 GB after hitting the limit :+1:
For the query above, which requires some caching before returning the result:
   SELECT
        cf.file_path,
        cf.blob_hash,
        LANGUAGE(cf.file_path) as lang,
        count(uast_extract(uast(f.blob_content, LANGUAGE(cf.file_path), '//uast:String'), "Value"))
    FROM repositories r
        NATURAL JOIN refs rf
        NATURAL JOIN commit_files cf
        NATURAL JOIN files f
    WHERE r.repository_id = 'pytorch'
        AND is_tag(rf.ref_name)
        AND lang ='Python'
    GROUP BY lang, cf.file_path, cf.blob_hash;

The memory stagnated at about 1.26 GB, but still finished. It did not increase even after subsequent queries. So yeah, looks good guys :)

Yes I think you can. I believe there is still some leaking, as depending on the query the amount of memory still can go over the hard limit set in environment variables. However it is nothing compared to before so imo this is resolved.

It's very hard to accurately ensure it does not go over the hard limit, so it's more of a soft limit. But should not be much bigger than the limit that has been set.

Closing the issue as resolved then. Thanks!


KeyManagerFactory not supported when using openssl 1.0.2 at runtime

PR #368 was supposed to enable KeyManagerFactory when the dynamically linked netty-tcnative binary is used with openssl 1.0.2 at runtime, but I'm finding that it is still not working for me.
Expected behavior
KeyManagerFactory is supported when using the dynamically linked netty-tcnative binary with openssl 1.0.2 at runtime.
Actual behavior
KeyManagerFactory is NOT supported when using the dynamically linked netty-tcnative binary with openssl 1.0.2 at runtime.
At runtime, with debug logging enabled, I see the following log entries:
19:40:22.263 DEBUG [io.netty.handler.ssl.OpenSsl] - Initialize netty-tcnative using engine: 'default'
19:41:34.240 DEBUG [io.netty.handler.ssl.OpenSsl] - netty-tcnative using native library: OpenSSL 1.0.1e-fips 11 Feb 2013
19:41:34.885 DEBUG [io.netty.handler.ssl.OpenSsl] - KeyManagerFactory not supported.

The log statement indicates that it is using OpenSSL 1.0.1e-fips, but that version of OpenSSL is not installed on this machine.
Is the version reported the version that the netty-tcnative binary was compiled against?
When I step through in a debugger, I can see that when OpenSsl is detecting if KeyManagerFactory is supported here,
SSL.setCertificateChainBio throws this exception (which is caught here):
java.lang.Exception: Error setting certificate chain (error:00000000:lib(0):func(0):reason(0))
        at io.netty.internal.tcnative.SSL.setCertificateChainBio(Native Method)
        at io.netty.handler.ssl.OpenSsl.<clinit>(OpenSsl.java:200)

Steps to reproduce
Use the Dockerfile mentioned below to reproduce.
Otherwise, create an environment similar to what I have mentioned in the versions section below, and just attempt to use KeyManagerFactory.
Minimal yet complete reproducer code (or URL to code)
Here's a Dockerfile that creates an Docker image that duplicates my environment and runs a test:
https://gist.github.com/philsttr/f3db79e88ac2c93e46ba289000d389cc
Copy the Dockerfile into an empty local directory, then...
docker build --tag netty-tcnative-test .
docker run -it --rm netty-tcnative-test

Output will look similar to the following
++ cat /etc/redhat-release
CentOS Linux release 7.6.1810 (Core)
++ uname -a
Linux 3433339e5227 4.9.49-moby #1 SMP Fri Dec 8 13:40:02 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
++ java -version
openjdk version "11.0.2" 2019-01-15
OpenJDK Runtime Environment 18.9 (build 11.0.2+9)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.2+9, mixed mode)
++ rpm -qa openssl apr
apr-1.4.8-3.el7_4.1.x86_64
openssl-1.0.2k-16.el7.x86_64
++ ls -1 netty-buffer-4.1.33.Final.jar netty-codec-4.1.33.Final.jar netty-common-4.1.33.Final.jar netty-handler-4.1.33.Final.jar netty-tcnative-2.0.20.Final-linux-x86_64-fedora.jar
 netty-transport-4.1.33.Final.jar
netty-buffer-4.1.33.Final.jar
netty-codec-4.1.33.Final.jar
netty-common-4.1.33.Final.jar
netty-handler-4.1.33.Final.jar
netty-tcnative-2.0.20.Final-linux-x86_64-fedora.jar
netty-transport-4.1.33.Final.jar
++ java -cp '*:.' -Djava.util.logging.config.file=logging.properties NettyTest
Feb 22, 2019 1:14:35 AM io.netty.handler.ssl.OpenSsl <clinit>
FINE: Initialize netty-tcnative using engine: 'default'
Feb 22, 2019 1:14:35 AM io.netty.handler.ssl.OpenSsl <clinit>
FINE: netty-tcnative using native library: OpenSSL 1.0.1e-fips 11 Feb 2013
Feb 22, 2019 1:14:35 AM io.netty.handler.ssl.OpenSsl <clinit>
FINE: KeyManagerFactory not supported.
Feb 22, 2019 1:14:35 AM io.netty.handler.ssl.OpenSsl <clinit>
FINE: Supported protocols (OpenSSL): [SSLv2Hello, SSLv3, TLSv1, TLSv1.1, TLSv1.2]
Feb 22, 2019 1:14:35 AM io.netty.handler.ssl.OpenSsl <clinit>
FINE: Default cipher suites (OpenSSL): [TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384, TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256, TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, TLS_ECDHE_RSA_WITH_
AES_128_CBC_SHA, TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA, TLS_RSA_WITH_AES_128_GCM_SHA256, TLS_RSA_WITH_AES_128_CBC_SHA, TLS_RSA_WITH_AES_256_CBC_SHA]
OpenSsl.supportsKeyManagerFactory()=false

Versions

what
version

netty
4.1.33.Final

netty-tcnative
2.0.20.Final (linux-x86_64-fedora)

openssl
1.0.2k-16.el7

apr
1.4.8-3.el7_4.1

centos
7.6.1810

openjdk
11.0.2

Closing.  Meant to open this under netty-tcnative

https://github.com/netty/netty-tcnative/issues/434


missing continue on loop

here's the follow up from c8f8cc37e3467a1bf72315f404d145f9fa15a625

@cferdinandi can you look at this PR as well?


Support for ltx-video-2b-v0.9.1

Thank you for sharing
0.91 has a smaller volume, but replacing it directly will result in an error. We hope it can be supported.

@Jandown
Here you go
https://youtu.be/L8hkDNPacFw

@Jandown
Here you go  给你 https://youtu.be/L8hkDNPacFw

Thanks


I can't change "urls" file path

Newsboat version (copy the output of newsboat -v or the first line of git show):
Newsboat r2.25 - https://newsboat.org/
Copyright (C) 2006-2015 Andreas Krennmair
Copyright (C) 2015-2021 Alexander Batischev
Copyright (C) 2006-2017 Newsbeuter contributors
Copyright (C) 2017-2021 Newsboat contributors
Newsboat is free software licensed under the MIT License. (Type `/snap/newsboat/5003/usr/local/bin/newsboat -vv' to see the full text.)
It bundles:

JSON for Modern C++ library, licensed under the MIT License: https://github.com/nlohmann/json
optional-lite library, licensed under the Boost Software License: https://github.com/martinmoene/optional-lite
expected-lite library, licensed under the Boost Software License: https://github.com/martinmoene/expected-lite

Newsboat r2.25
System: Linux 5.11.0-37-generic (x86_64)
Compiler: g++ 7.5.0
ncurses: ncurses 6.1.20180127 (compiled with 6.1)
libcurl: libcurl/7.58.0 OpenSSL/1.1.1 zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1 (+libidn2/2.0.4) nghttp2/1.30.0 librtmp/2.3 (compiled with 7.58.0)
SQLite: 3.22.0 (compiled with 3.22.0)
libxml2: compiled with 2.9.4
Config file (copy from ~/.newsboat/config or ~/.config/newsboat/config):
config is nowhere to be found as it installs itself in a weird place - namely : $HOME/snap/newsboat/
From there we have :
$ cd ~/snap/newsboat/
~/snap/newsboat$ ls
5003  common  current
~/snap/newsboat$ ls -l
total 8
drwxr-xr-x 3 cypher cypher 4096 paź  5 20:16 5003
drwxr-xr-x 2 cypher cypher 4096 paź  5 20:16 common
lrwxrwxrwx 1 cypher cypher    4 paź  5 15:52 current -> 5003
~/snap/newsboat$ cd 5003/
~/snap/newsboat/5003$ ls
~/snap/newsboat/5003$ ls -l
total 0
~/snap/newsboat/5003$ cd ../common/
~/snap/newsboat/common$ ls
~/snap/newsboat/common$ ls -l
total 0
~/snap/newsboat/common$

Steps to reproduce the issue:

install newsboat with snap

try to change urls path with "-u"

EFFECT :
~/.newsboat$ newsboat -u '$HOME/.newsboat/urls'  Starting Newsboat r2.25... Loading configuration...done. Opening cache...done. Loading URLs from $HOME/.newsboat/urls...Error: failed to read URLs from file "$HOME/.newsboat/urls": Failed to open file: Permission denied (os error 13)

Other info you think is relevant:
The dafault path is : $HOME/snap/newsboat/5003/.newsboat/urls
Which does not exist, but the program works once I manually create it.
EDIT:
My new file has all needed permissions ofc. I even tried with 777 to be sure.

Our Snap is sandboxed and can't access the rest of the system, so the error with -u is the correct behaviour. It's also right that you have to create the file manually (for reasons unrelated to Snap).
I admit that I treat Snap as a bit of a second-class platform, and no-one stepped up to patch the app to support Snap better, so there we are. Patches welcome!


Add hostpath-csi storage class

Short description:
Add hostpath-csi storage class.

Please update the commit message; this repo is not tied to CNV.

/approve

/verified


Symlink'ed files deployment with 6.0.0?

Hi,
I just switched to Modulus-CLI version 6.0.0 and figured out I now have to use the Meteor runtime in Modulus.
I am happy the new deployment process performs demeteorization server-side, so it takes much less network usage.
But it seems the code sent to the server does not contain symlink'ed files, therefore it can no longer access my private npm repositories in node_modules root folder (it could be any arbitrary path actually).
Please is there an easy command to make the deploy tool send symlink'ed files as well?
In 5.x the demeteorization was done on my machine, so it could access symlink'ed files as if they were standard files.
Thank you in advance for your precious help!

To be more specific, it looks like symbolic links to direct files do work, but not if the symbolic link is on a parent folder.

Any solution to this issue?  I encountered this with the latest modulus cli version 6.5.  My project, with symlinks to local packages works fine locally but when I tried to "modulus deploy", got this error:
While selecting package versions:
error: unknown package in top-level dependencies: xxx
unknown package in top-level dependencies: yyy

Similar discussion here: Is it possible to use packages from a package folder outside of the app folder? #109

@kvo68 Thanks for reviving this issue, I will try to look into some solutions. I believe the relevant code would be here.
In #109, the issue seems to be relative paths that are defined in code, so I doubt a single fix will address both problems..

Closing due to Xervo service shut down :-(


about instances_train_sub.json of dataset

Thanks for interesting works. I have a question about the dataset. I download the label of the dataset which has "train.json" but not instances_train_sub.json. Where can I download the sub json?

They are the same, just rename the the "train.json"

@Epiphqny , i believe these are the splits that you create for tuning hyperparamters. Would you mind share this file with us?


Fix variables in filter not found

Attempt to fix issue whereby a parameter inside a FILTER, CONCAT etc. clause (see https://github.com/CLARIAH/grlc/issues/322#issuecomment-796003965) is removed by rdflib.

Hi @richardhadden,
I just came across this fix. Does it work? It would be fantastic if you could contribute upstream!

Hi @richardhadden,
I just came across this fix. Does it work? It would be fantastic if you could contribute upstream!

It seems to work. RDFLib seems to find all SPARQL variables at some stage, but the translateQuery function filters out those in FILTER clauses — so the fix involves manually calling some of the internal functions from RDFLib to just find but not filter the variables.
I need to check that it works properly for building the Swagger documentation as well, then will contribute upstream.

Great, many thanks for looking into this!


hi,How to shut down blowup,help me

hi,How to shut down blowup,help me

You can use the jQuery.off() method.
$("your-element").off()


ToggleSwitchForm does not work with Turbo Responses

Hi there,
in our application we are currently introducing a ToggleSwitchForm and we want the response to change a bit of state in the page. We are using turbo streams. The response we get is a proper turbo-stream response but since the request does not originate from a proper form request but instead a fetch request, turbo does not trigger.
See
https://github.com/primer/view_components/blob/ae8dbe23040ded74fab853ac3dc2068711c625f1/app/components/primer/alpha/toggle_switch.ts#L161-L172
In my opinion we have 2 options to tackle this:

We allow to pass a parameter into the ToggleSwitchForm that adds a data attribute to tell the component that it is rendered in a turbo context and then change the fetch request to include headers: { Accept: "text/vnd.turbo-stream.html" } and when we have the response we trigger Turbo.renderStreamMessage(response.text()). But I am not sure if you want to tie your implementation to Turbo this closely.
Another option would be that instead of building a fetch request, we add hidden form inputs for the CSRF token and the value, fill those and then trigger a form.submit() to have the request be executed as a normal form submission.

I'll be happy to submit a PR for either solution if you let me know which one is the preferred way.

Hey @klaustopher thanks for bringing this up! We have that XMLHttpRequest header in there because a number of the actions in the GitHub monolith check request.xhr?. We haven't considered other headers or request patterns until now 😅

We allow to pass a parameter into the ToggleSwitchForm that adds a data attribute... But I am not sure if you want to tie your implementation to Turbo this closely.

primer/view_components is already very much tied to Rails, so I don't see much of an issue in adding a parameter to ToggleSwitchForm, eg. turbo: true. I do wonder tho if it would make sense to add an accept: param instead to make the header itself customizable.

Another option would be that instead of building a fetch request, we add hidden form inputs for the CSRF token and the value, fill those and then trigger a form.submit() to have the request be executed as a normal form submission.

That's an interesting idea. I actually kind of like this better because it doesn't get all fancy with fetch and instead just relies on the platform. Would you be inclined to submit a PR for this one?

I'll do a PR, give me some time :)


Dropdowns and other field types

Hi!
This might already be possible, but since there's nothing about it in the readme, I still need to ask!
Having different field types would be really useful. The main thing I can think about now is dropdowns with predefined values.
It could look something like this:
{{dropdown:'option1', 'option2', 'option3'}}
Then when creating a file from that template, we'd be able to choose between options.
Other field types could be nice too, like date (with a calendar popping up to select the date/time), number with range...

I agree 300% with you @Lulullia !!!!!!!!

Definitely possible, and I had this idea in mind - I'm not much of a UI person, so I'm happy for pull requests or fragments that would help make that all work.

Hello! First of all, thank you @mo-seph for the great work so far!
Another idea would be implement special types like date, date/time, time, boolean and integer, all of them with special inputs.

There's a version in development that supports forms like this: {{suit:choice:hearts:spades:diamonds:clubs}} to get a dropdown with a choide between hearts, spades, diamonds and clubs. I had a look at using SearchComponent to find other notes, and another one for times, but I haven't found any other useful bits of ui - any pointers welcome!


Keys format for signature & digest algorithm

The keys sent for the signature & digest algorithm are not in the correct format.
See pull-request #39  for details.

Thanks, a new release (2.4.7) with the fix is now available.


Switch to actual upstream Descheduler policy

We currently have our own config API in the operator that differs from the upstream Descheduler API. For example, the operator needs to be configured with a strategies  field like:
apiVersion: operator.openshift.io/v1beta1
kind: KubeDescheduler
metadata:
  name: config
  namespace: openshift-kube-descheduler-operator
spec:
  strategies:
    - name: "RemoveDuplicates"
    - name: "RemovePodsHavingTooManyRestarts"
      params:
       - name: "PodRestartThreshold"
         value: "10"
       - name: "IncludingInitContainers"
         value: "false"

which just gets internally translated into:
apiVersion: "descheduler/v1alpha1"
kind: "DeschedulerPolicy"
strategies:
  "RemoveDuplicates":
     enabled: true
  "RemovePodsHavingTooManyRestarts":
     enabled: true
     params:
       podsHavingTooManyRestarts:
         podRestartThreshold: 10
         includingInitContainers: false

So, while our own API is slightly simpler in its definition, in practice it must be manually converted which adds complexity to the codebase. It also means that we need to constantly update our own operator code to support new strategies and parameters as they are added upstream meaning double the work for us to add a new feature upstream.
In addition, it is also confusing to users that the config API is different when using our operator vs running the descheduler on their own which could inhibit adoption of the operator. It would be much simpler to simply have to point to upstream docs for configuring the descheduler.
This is why I propose a field called policy in the operator spec, which would point to a configmap containing an actual descheduler policy (along with an optional field namespace, which defaults to openshift-config). This would match the design of the scheduler operator which has a Policy field that points to a configmap with a regular scheduler policy (see the OpenShift docs on how to deploy the scheduler operator with a custom policy. This would be the exact same design).
I think we will still need to support the current v1beta1 config API until it can be fully deprecated, but this shift will save us effort and reduce potential failure points.

/cc @ingvagabund @soltysh

+1 towards simplifying the configuration through the operator and making it more aligned with how it's done in the scheduler operator.

It's definitely something we should do before we GA the descheduler, probably when transitioning descheduler config to openshift/api.

Updated main description with links to WIP PRs to start work on this change:

openshift/api#740
openshift/client-go#160
#138

Based on discussion in the openshift/api PRs, I don't think our requirements and status as an OLM operator fit within the constraints of the core OpenShift api. I've opened a PR to make this change within our repo, as well as some other minor updates (like upgrading our CRD to apiextensions/v1 and adding more build tooling) Please see https://github.com/openshift/cluster-kube-descheduler-operator/pull/148
I will be updating the PRs to the other repos with this explanation and closing them.


Include given name in welcome message

📝 Changed routes:

/

(view full size)

Commit 9bd415797c372d598310995a4d228307cceb91b7 (https://onetap-q9mlrsfmi.preview.descope.org).


MAINT: stats: fix NumPy DeprecationWarnings

Reference issue
gh-18781
What does this implement/fix?
gh-18781 reported a NumPy DeprecationWarning that seems like it should cause CI failures but doesn't. I'm using this PR to explore why and fix it.

@stefanv @jarrodmillman any idea why this test is passing on all platforms despite gh-18781?

I see that these are being listed as warnings at the bottom of the logs, but does anyone know why they are not errors and why the warnings don't show up for every other test that they occur in?

I've stuck with a similar problem before. From the warnings docs

The disposition of warnings can vary based on the warning category, the text of the warning message, and the source location where it is issued. Repetitions of a particular warning for the same source location are typically suppressed.

Not sure but maybe relevant.

You may need to remove error from the filters
[pytest]
filterwarnings =
    error

and then look for the warnings in the logs. The warnings were we originally saw this went away when I added error here:
https://github.com/scipy-lectures/scipy-lecture-notes/pull/631

Should I test whether high-level DeprecationWarnings cause errors, just to be sure? It looks like specific DeprecationWarnings are manually ignored in pytest.ini, so I imagine they did in the past, but maybe something changed?

Should I test whether high-level DeprecationWarnings cause errors, just to be sure? It looks like specific DeprecationWarnings are manually ignored in pytest.ini, so I imagine they did in the past, but maybe something changed?

Worth checking, but from my tests it looks like they should, and only the ones in NumPy are not surfaced.

Weird that it's platform-dependent

If CI comes back green, I think this is ready to go.  https://github.com/scipy/scipy/pull/18785#pullrequestreview-1511844704 suggests how it can be reviewed.

It looks like the failure is related to this: https://github.com/cython/cython/issues/5504

When I temporarily cherry-pick this PR into maintenance/1.11.x branch, the number of "silent NumPy deprecation warnings" drops from 4661 to 50, which is the same number of silent warnings as the main branch. So, I'm inclined to mark this PR for backporting.

I tried to deal with the remaining 50 in gh-19034, but it seems to be a can of worms transiting through f2py. Still, this is a big improvement.


Dropped support for Python 3.4

Coverage remained the same at 36.692% when pulling 467118ca353f761fb0f57e636d6b07794517822d on andy/drop-py34 into 3f9f95cb01b428c77fbb944ff0635381586e3f7a on master.


feat(koa): add requestHook support

The requestHook support allows custom span handling per middleware
layer on requests.
Which problem is this PR solving?

Adds requestHook support so users can add custom handling on spans per middleware layer on requests.

Short description of the changes

It's inspired by how requestHook is implemented in other instrumentations
The requestHook user-defined function is called any time a patched middleware runs and if the function exists.

Checklist

[x] Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@luismiramirez friendly ping because the lint is failling

@vmarchaud Linter issues addressed!


Changing state on CommunityToolkit Popup OnClosed method doesn't update the view

I was working on a Popup that contains a CollectionView. The collection view contains a list of countries. When choose a country, and click on Done Button, the selected country is returned as the result of the Popup. I update the Result State but it doesn't update on the view and the Button to show the Popup doesn't work when clicked.
https://github.com/adospace/reactorui-maui/assets/29815096/d5340d03-5b87-4c6c-8eb9-83cf8a93b150
Here is the project:
Project37.zip

Hi @cris-m, sorry for the late reply. I've verified that the PopupHost you used was not updated with the latest version of MauiReactor and your specific use case (I'm about to update the Popup control on the test app of the MauiReactor solution).
Please remove the PopupHost class as it's not required but directly create the Popup control as follows:
class MainPageState
{
    //this is only required to prevent opening the popup twice on user double tap
    public bool IsShown { get; set; }

    public CountryInfo? Result { get; set; }

    public ObservableCollection<CountryInfo> Countries { get; set; } = [];

    //SelectedCountry must be a state property here (not a field of the class) because we want it maintained
    //after a SetState call
    public CountryInfo? SelectedCountry {get; set;}
}

partial class MainPage : Component<MainPageState>
{
    private CommunityToolkit.Maui.Views.Popup? _popup;

    [Inject]
    private ICountryInfoService _countryService;

    protected override void OnMounted()
    {
        State.Countries = new ObservableCollection<CountryInfo>(_countryService.GetCountriesInfo());
        State.Result = _countryService.GetRegionInfoByName("Congo - Kinshasa");

        base.OnMounted();
    }

    public override VisualNode Render()
        => ContentPage(
                Grid([
                    Label(State.Result?.EnglishName)
                        .HorizontalTextAlignment(TextAlignment.Center),

                    Button("Choose Country")
                        .HCenter()
                        .VCenter()
                        .GridRow(1)
                        .OnClicked(ShowPopup),

                    new Controls.Popup(r => _popup = r)
                    {
                        Grid([
                            Grid([
                                Button("Cancel", () => _popup?.Close())
                                    .CornerRadius(0),
                                Button("Done", () => _popup?.Close(State.SelectedCountry))
                                    .CornerRadius(0)
                                    .GridColumn(1)
                            ])
                            .ColumnSpacing(10)
                            .Rows("*")
                            .Columns("* *")
                            .Padding(10),
                            new CollectionView()
                                .GridRow(1)
                                .OnSelected<CollectionView, CountryInfo>(OnSelectedItem)
                                .SelectionMode(MauiControls.SelectionMode.Single)
                                .ItemsSource(State.Countries, RenderItem)

                        ])
                        .Rows("Auto *")
                        .Columns("*")

                    }
                    .OnClosed((s,e) => SetState(s =>
                    {
                        s.IsShown = false;
                        s.Result = (CountryInfo?)e.Result;
                    }))
                ])
                .Rows("* *")
                .Columns("*")
                .RowSpacing(20)
                .VCenter()
            );

    void ShowPopup()
    {
        if (ContainerPage != null && _popup != null && !State.IsShown)
        {
            State.IsShown = true;
            ContainerPage.ShowPopup(_popup);
        }
    }

    VisualNode RenderItem(CountryInfo? country)
        => Border(
            Label(country?.EnglishName)
            .TextColor(Colors.Black)
            .HorizontalTextAlignment(TextAlignment.Center)
        )
        .Padding(5);

    void OnSelectedItem(CountryInfo? selectedCountry)
    {
        SetState(s => s.SelectedCountry = selectedCountry);
    }
}

Let me know if it's now working for you too.

I have remove the PopupHost and test the solution.  The solution work, the state is update but I got the following error:
'Popup' does not contain a definition for 'OnClosed' and no accessible extension method 'OnClosed' accepting a first argument of type 'Popup' could be found (are you missing a using directive or an assembly reference?).
When the Popup is closed, the button OnClicked doesn't work.

this is working for me:
Project37.zip

Thanks you for the support, I had problem of namespaces. the problem have been fixed


FileTarget logging broken when ASF running as a service

I'm not sure if this is NLog bug or bad setup (probably the latter), but currently file target seems to be broken when ASF is run as a service.
I'm not sure why because service is running with admin priviledges, and previous method (from ASF <IP_ADDRESS>) worked fine, so it's something to do with NLog in <IP_ADDRESS>. Thing is, it works fine when ASF is not run as a service, and there are no exceptions being thrown during my tests, even with ThrowExceptions and ThrowConfigExceptions enabled, so it seems cool.
If somebody has any idea what is happening, I'd appreciate, as I've just started using NLog myself. I have no clue what is the reason for that at the moment.

A log file does not seem to be generated even when not running as a service.

Yup, which is weird because ASF was fine writing to a log a moment ago :fearful:
I screwed up something and I don't know what, hm.

Ha, solved it.

Hello JustArchi,
First I want to thank you for your wonderful bot! I had used it for quite some time without any problem. However, as I recently reconfigured it as a systemd service it cannot write log file any more. I read another issue post #292, created the NLog.config file and specified the output filename as '/asf/log.txt' but still got no luck. Could you help me? Thanks in advance!

Don't hijack other issues and post in appropriate place - https://github.com/JustArchi/ArchiSteamFarm/blob/master/CONTRIBUTING.md
You're not reporting ASF bug.


How to hide Title Bar and prevent close

I don't know how to hide the Title bar and prevent close button in new window
Is there anyone tell me the way or wait for a new release version to do this ?

@wenchaosong did you figure it out how to hide the title bar? I am facing the same issue

no

IIRC I'm using the window_manager package with the desktop_multi_window package
window_manager lets you hide the title bar - https://pub.dev/documentation/window_manager/latest/window_manager/WindowOptions/windowButtonVisibility.html
note there might be some setup work to get things compatible:
https://github.com/MixinNetwork/flutter-plugins/issues/137
I don't remember all the details, but it's definitely possible

IIRC I'm using the window_manager package with the desktop_multi_window package
window_manager lets you hide the title bar - https://pub.dev/documentation/window_manager/latest/window_manager/WindowOptions/windowButtonVisibility.html
note there might be some setup work to get things compatible:
https://github.com/MixinNetwork/flutter-plugins/issues/137
I don't remember all the details, but it's definitely possible
CC @wenchaosong @Azurba


[Feature Request]: JSON mode

Is your feature request related to a problem? Please describe.
Agent currently does not output JSON object as instructed. Given now gpt-4-turbo supports JSON mode, it would be great to incorporate this into Autogen.
Describe the solution you'd like
Add parameter response_format={ "type": "json_object" } in llm_config of an agent.
Additional context
No response

I have been able to get json output to work using "response_format":{ "type": "json_object" } in the llm config as you described. Was it not working? Can you provide an example?

@jackgerrits In my case, the output is always the JSON structure being encapsulated within double quotes and escaped with backslashes () like this:
"{\n  "name": "Alice",\n  ....\n}"
so it will be interpreted as a single string value rather than a JSON object.
I have JSON mentioned in the prompt of the agent, and added "response_format":{ "type": "json_object" } in llm config.

You can use json.loads: https://docs.python.org/3/library/json.html

this is expected behavior , you'll have to escape and unescape json regularly when using text models


feat: add semantic package

This brings over the semantic package from osv-detector along with the related generators that generate fixtures based on the versions listed in all current OSVs for the related ecosystem.
Relates to #81

Tests are now failing because of the new nuget and Alpine ecosystems - I'll have to look into their version comparison logics and ensure there's an appropriate comparator (nuget is because of #132)

Thanks! I wonder if it's also worth making this an internal package for now, to give us more flexibility when it comes to making changes later (and not break semver rules)?


Apps built for website using self-signed SSL only show white screen

I tried this with several subdomains I have which use self-signed SSL certificates and none will load within the app. I don't get an 'add exception' screen or anything, the app just loads a blank screen and stays that way.
Would be great to have an option to allow the use of self-signed certificates.

Same for me.

Hi, is there a website or something that I can test this on? It might be possible to pass an argument to chromium as per https://discuss.atom.io/t/trusting-a-self-signed-certificate/12332

Hi @jiahaog
Yes, any site with a self signed certificate. For example :
jeo@brs:~$ nativefier --app-name "TestSSL"  "https://lacoloc.fr"
Packaging app for platform linux x64 using electron v0.36.4
App built to /home/jeo/TestSSL-linux-x64
jeo@brs:~$ ./T
Téléchargements/   TestSSL-linux-x64/
jeo@brs:~$ ./TestSSL-linux-x64/TestSSL
jeo@brs:~$

Give me a blank app.

I's also seeing this problem with self-signed certs, blank apps.

This should be fixed in the next release of nativefier, I've tested it on https://lacoloc.fr and it seems to work fine.

@jiahaog Thanks!

It's working fine in 6.6.2 !

I can still see a blank page for the above "https://lacoloc.fr" URL on Ubuntu 16.04 x64, Nativefier 7.3.1, Electron 1.1.3. Do I need to update anything else?

I can still see a blank page for the above https://lacoloc.fr` URL on Ubuntu 16.04 x64, Nativefier 7.3.1, Electron 1.6.7. Do I need to update anything else?

@AnrieetteC no, same here, it's a regression. Re-opening the issue.

Any word on this bug?

+1, This gives me a blank page on my proxmox admin page with console error: net::ERR_INSECURE_RESPONSE

same problem here, Dynamic DNS Service which links to my raspberry.

Same problem with a certificate who has expired.

Since this is still open, and I found this thread while trying to find a workaround for this exact issue, checking out nativefier --help helped. ;)
Try building like so: nativefier --name 'Name of App' 'AppUrl.com' --insecure --ignore-certificate
You may want to attempt only --ignore-certificate and see if that suites your needs first.
This allows us to ignore the fact that the self-signed cert is insecure and load the web page anyway. I've found this quite useful for creating apps around internal web GUIs without fussing over a CA.
I would only advise using these options if the target URL is within your local network (and you're reasonably certain your local network is secure)!
Given the above is it possible this behavior is not a bug but a feature? Secure by default is certainly the way to go.

I think @blechinger 's advice is correct here and will be closing.

Do these flags still work?
Still getting a blank scree but it's fine via safari


Metajo 1 crashes when you gain control of a character

Tested in RetroArch 1.13 with the np2kai 0.86 core.
Steps to reproduce:

Run Metajo.
Start a new game.
Agree to go through the tutorial.
When the star pops up on the ground, the game will hang before you get to see the action selection menu.

Curiously, if you make a save state in RetroArch at any point before gaining control of the character, and immediately load the same save state, the game will let you play just fine.

This bug is caused by bug around FP exception flags.
I wrote a patch for fix it. If you cannot use patch, workaround is exist.
Workaround
Write  FPU_TYPE=2 (or FPU_TYPE=1) into configuration file.
(Using dosbox based floating point routine instead of softfloat)

@amuramatsu thank you, these seem to work like a charm.

Thanks your report!
fpumul_softfloat.c was rebased DOSBox's one.
Now exception_x87 is used.
Does the same problem occur in the current version?


Doesn't work with aiomqtt 2.0.0

Quick fix is to update requirement.txt to have aiomqtt==1.2.1
Longer fix is to follow https://sbtinstruments.github.io/aiomqtt/migration-guide-v2.html

Thank you @normanr ! I merged in the temporary fix.
Interestingly, I noticed that pip install on a python 3.7 is not picking up aiomqtt 2.0.0, which is probably why I never saw this issue.
For convenience, I started a vm using Vagrant: vagrant up
$ vagrant ssh
(env) vagrant@mqtt2kasaVM:~$ pip list
Package            Version
------------------ -------
aiomqtt            1.1.0
anyio              3.7.1
asyncclick         <IP_ADDRESS>
asyncio-throttle   1.0.2
exceptiongroup     1.2.0
idna               3.6
importlib-metadata 6.7.0
paho-mqtt          1.6.1
pip                23.3.2
pydantic           1.10.14
python-kasa        0.5.1
PyYAML             6.0.1
setuptools         47.1.0
sniffio            1.3.0
typing_extensions  4.7.1
zipp               3.15.0
(env) vagrant@mqtt2kasaVM:~$ python --version
Python 3.7.17
(env) vagrant@mqtt2kasaVM:~$ pip install aiomqtt==1.2.1
ERROR: Ignored the following yanked versions: 0.17.0
ERROR: Ignored the following versions that require a different python version: 1.2.0 Requires-Python >=3.8,<4.0; 1.2.1 Requires-Python >=3.8,<4.0; 2.0.0 Requires-Python >=3.8,<4.0
ERROR: Could not find a version that satisfies the requirement aiomqtt==1.2.1 (from versions: 0.1.0, 0.1.1, 0.1.2, 0.1.3, 1.0.0, 1.1.0)
ERROR: No matching distribution found for aiomqtt==1.2.1
(env) vagrant@mqtt2kasaVM:~$ pip install aiomqtt==2.0.0
ERROR: Ignored the following yanked versions: 0.17.0
ERROR: Ignored the following versions that require a different python version: 1.2.0 Requires-Python >=3.8,<4.0; 1.2.1 Requires-Python >=3.8,<4.0; 2.0.0 Requires-Python >=3.8,<4.0
ERROR: Could not find a version that satisfies the requirement aiomqtt==2.0.0 (from versions: 0.1.0, 0.1.1, 0.1.2, 0.1.3, 1.0.0, 1.1.0)
ERROR: No matching distribution found for aiomqtt==2.0.0

Thanks! Using an ordered comparison <= is better than equality ==, but I wonder if the comparable operator ~= (with the earliest compatible version) should be used instead. That way it'll pick up any bug fixes.
ref: https://packaging.python.org/en/latest/specifications/version-specifiers/#id4

fwiw, Python 3.7 support was dropped in https://github.com/sbtinstruments/aiomqtt/pull/246 which is probably why it didn't detect it.


Change numberTranslator format

Change the time format to T.SSS SSS SSS where T is in seconds. Make sure
each group of digits SSS is zero-padded.
Signed-off-by: Patrick Tasse<EMAIL_ADDRESS>

Abandoned, replaced by https://github.com/theia-ide/theia-trace-extension/pull/139.


Fury java version java.lang.NegativeArraySizeException

Thank you for reporting the problem!
Please make sure what you are reporting is a bug with reproducible steps.
Describe the bug
fury version: 0.1.0
jdk version: java 11
Description:  java.lang.NegativeArraySizeException occurred when serialize list
stack print:
java.lang.NegativeArraySizeException: -2035644744
at io.fury.memory.MemoryBuffer.ensure(MemoryBuffer.java:1877)
at io.fury.memory.MemoryBuffer.grow(MemoryBuffer.java:1871)
at io.fury.resolver.MapRefResolver.writeRefOrNull(MapRefResolver.java:68)
at io.fury.Fury.writeRef(Fury.java:280)
at io.fury.serializer.CollectionSerializers$CollectionSerializer.writeElements(CollectionSerializers.java:138)
at io.fury.serializer.CollectionSerializers$CollectionSerializer.write(CollectionSerializers.java:115)
at io.fury.serializer.CollectionSerializers$CollectionSerializer.write(CollectionSerializers.java:65)
at io.fury.Fury.writeData(Fury.java:483)
at io.fury.Fury.writeRef(Fury.java:283)
at io.fury.Fury.serialize(Fury.java:233)
at io.fury.Fury.serialize(Fury.java:181)

@tonysmz could you provide the reproduction code?

@tonysmz could you provide the reproduction code?

Sorry I can't, the List has more than 14M records from database, it can be serialized by jdk, but it very slow.

@tonysmz could you provide the reproduction code?

Sorry I can't, the List has more than 14M records from database, it can be serialized by jdk, but it very slow.

The data deserialized by fury must be the data serialized by fury, rather than jdk serialized data. Fury compatibility is the user api level, rather than binary level

I mean the jdk can serialize over 14M rows ArrayList without any error, but it's slowly, fury can't with the below error:
ava.lang.NegativeArraySizeException: -2035644744
at io.fury.memory.MemoryBuffer.ensure(MemoryBuffer.java:1877)
at io.fury.memory.MemoryBuffer.grow(MemoryBuffer.java:1871)
at io.fury.resolver.MapRefResolver.writeRefOrNull(MapRefResolver.java:68)
at io.fury.Fury.writeRef(Fury.java:280)
at io.fury.serializer.CollectionSerializers$CollectionSerializer.writeElements(CollectionSerializers.java:138)
at io.fury.serializer.CollectionSerializers$CollectionSerializer.write(CollectionSerializers.java:115)
at io.fury.serializer.CollectionSerializers$CollectionSerializer.write(CollectionSerializers.java:65)
at io.fury.Fury.writeData(Fury.java:483)
at io.fury.Fury.writeRef(Fury.java:283)
at io.fury.Fury.serialize(Fury.java:233)
at io.fury.Fury.serialize(Fury.java:181)

A minimal reproduction won't need 140m items, Maybe post your class def and mock some data will reproduce the failure. We need the reprod code to find out the root cause

@tonysmz any update on this?


Undeploy command

Add a command to undeploy CNA
Description
npm run undeploy runs the following two commands:

npm run undeploy:ui removes all deployed files in s3
npm run undeploy:actions wraps aio runtime deploy undeploy

Related Issue

Motivation and Context
Undeploy command is crucial for integration tests and cleaning up resources

How Has This Been Tested?
Manual testing => Need to add integration tests when travis CI is configured to deploy a test app.

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

@moritzraho Can you pull in changes from master. That will make sure Travis build runs of this PR as well.

@sandeep-paliwal thanks for the review, travis build completed


AutoCreate.None should do absolutely nothing?

From a user question a week or two, don't do any kind of schema checks. If it fails, it fails. Caveat emptor? Or do we use yet another enum value?

I would agree... None would indicate to me that it does not do any kind of schema checks.  If you added a new enum value, what would it be? NoSchemaChecks?

This is done in the 2.0 branch, I'm going to go ahead and close it.


Switch to package:dart_flutter_team_lints

[x] I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

❌ test/utf8_test.dart: nullptr.length (failed)
  Unsupported operation: Operation 'length' not allowed on a 'nullptr'.
  package:ffi/src/utf8.dart 61:7  Utf8Pointer._ensureNotNullptr
  package:ffi/src/utf8.dart 24:5  Utf8Pointer.length

Looks like you broke the code by removing types 🤣


Support for different directions of the layout

Would it be possible to add support for different layout directions? Typically, users want the resulting tree to be oriented left-right or top-down, and I don't see any option to change the direction like in the other tree layouts in Cytoscape. Thank you.

Hi! Thank you for the suggestion! This is certainly something we are considering.
@chuckzel, will you have time to look at this, or should I try to address it?

I will add support for this in the coming weeks. If you need the functionality sooner, it is possible to use sizeGetter and transform options for this. For example, these options result in a left-right layout:
opts: {
   sizeGetter: (n) => {
       const dims = n.layoutDimensions();
       return { w: dims.h, h: dims.w };
   },
   transform: (n, pos) => ({ x: pos.y, y: pos.x })
}

Awesome, thank you!

Thank you very much! We are okay with waiting a few weeks for this feature. Thanks for this great layout; we can't wait to include it in our app.

Sorry for the longer wait, direction option is now added in 0.2.0
direction: "LR" | "RL" | "TB" | "BT" = "TB";  // the direction of the tree, left to right, right to left, top to bottom, bottom to top

Awesome! Thank you very much. I was rather occupied with other projects, so I'm glad you had time to look into this :)


Add README.md

Signed-off-by: Lukas Kral<EMAIL_ADDRESS>This PR adds/edits README.md to contain basic information about test-clients repo, with list of configuration, that can be set for each client.

LGTM. Very minor feedback provided.


FOUNDATIONS: Add Refugee

Closes #9

@bramburn Because those tests are part of TDD, the only way to build a foundation service is through those tests.


question: Email Support?

First off, kudos this is an excellent product, thank you so much for making this OSS available to all.
Question:
I see that there's configuration for notifications, is that specific to notfying users when they log in, or is there a way to have emails sent out for scheduling changes and/or upcoming events on the schedule? I didn't see any SMTP configuration so I thought it would prudent to ask. It seems like this would be a nice productivity add.
Thanks again.
-gs

is there a way to have emails sent out for scheduling changes and/or upcoming events on the schedule

That's exactly what notifications are for. You can see more in the user guide.
If you look at the example configuration there's a messengers section where you can configure which messengers to use to send out notifications. The supported list of messengers can be seen here. Right now it's slack, microsoft teams, rocket chat and Iris. If you're already running Iris then I would suggest just configuring it to use that. If you want to use SMTP that will require a new class to be added to support it, but it should be pretty easy to implement if you're interested.

awesome, thanks so much for the speedy reply.
I just realized this project may also have iCal support? That would do exactly what I need.... Is there any documentation on how to access iCal ? I gather its similar to the rest API?

Also for anyone else looking to solve for email:
Teams supports Email Notifications so once you get the messages into teams it should be straight forward enough to get an Outlook message

@minhaz1 if I may trouble you for one last question, I'm trying to get the Microsoft Teams integration working and I am not getting anywhere.
I've set config.yaml values to:
notifier:
skipsend: False
default_modes:
- "teams_messenger"
messengers:

type: teams_messenger
webhook: (*** the webhook I got from MS Teams messenger connectors -> webhooks ***)

notifications:
default_times:
- 1
- 86400
- 604800
Then setup several events and reminders tests and see nothing at all in the logs or in MS Teams messenger.
Then I tried with inserting rows into user_contact with mode_id = 5 and the destination value set to the same webhook URL that I used in the config.yaml and that also made no difference.
Any ideas about what I may be missing?


Sliders don't appear in dark mode in the Gallery

As the title says. I think currently the slider color is very dark, but it should likely be blue or purple or something.

Should it be changed in the material/theme_data.dart or just in flutter_gallery?

Just in the gallery itself, which I believe mostly uses its own theme and colors


Chore/add sleep time param

This PR adds support for overriding sleep_time param

Codecov Report
All modified lines are covered by tests :white_check_mark:

Comparison is base (873e161) 87.63% compared to head (027e4b0) 87.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   87.63%   87.63%
=======================================
  Files          68       68
  Lines        5118     5118
=======================================
  Hits         4485     4485
  Misses        633      633

Flag
Coverage Δ

unittests
87.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Is it possible to get a working compilation for CPUs not suporting avx instructions?

So I have an old cpu and I guess the neither the provided executable nor my own compilations work because it doesn't support avx instructions. Is there any way to make a compilation for old CPUs?

Just run make build on your old hardware, it should build it for your hardware.


Add a logging tool

Context
Currently, there is no logging = (
Current Behavior/Workaround
Just using console.log for debug purposes.
Ideal behavior
Use something like:
Winston: A versatile logging library that allows for custom log levels, transports (where your logs are sent), and even multiple simultaneous loggers. Transports include console output, file output, and more.
Bunyan: Another versatile logging library. One of Bunyan's notable features is its support for "structured logging", a logging approach where logs are written in a machine-readable format (usually JSON). This can be very useful for searching and analyzing your logs.
Morgan: A HTTP request logger middleware for Node.js. It simplifies the process of logging requests to your application. It's very useful in combination with other loggers like Winston and Bunyan, especially when you're building a web server or application.
Things to consider
Which functions should be logging information? How will we handle different logging levels (INFO, DEBUG, ERROR)

Duplicate of closed issue, https://github.com/jsolly/GeoAsteroids/issues/190


Add support for project-level estimated_cell_count

There's an estimated cell count associated with the project as well as with individual cell suspensions.
The web service will provide both values and leave it to the presentation layer (e.g. the Data Browser) as to how to present this information.
One possibility is to present the project estimated call count if it's non-zero, and otherwise use the sum of the cell suspension cell counts.

@hannes-ucsc : "The hits part is already implemented in Azul and work can progress in data browser to integrate with that. The summary part is still in the works (DataBiosphere/azul#3521)."

@hannes-ucsc : "@danielsotirhos to improve description to reflect the actual implementation. Once he's done, we'll move back to Sprint and reassign @MillenniumFalconMechanic ."


[simplify] remove searcher client caching

Summary
This caching is not necessary. When I test for the elapsed time in evaluating
the endpoint and client object, it is 18.428µs.
How was it tested?
ran devbox info go that exercises this code path.

Current dependencies on/for this PR:

main

PR #1187   👈

This comment was auto-generated by Graphite.


BEAMS3D: Minor bugfix and improvements for DISTNORM

Minor improvements to how distnorm works.

I tested a W7X case with no collisions (12 Particles, same initial conditions, no losses) and there does seem to be a quite subtle difference in the distribution. I wonder if it is because of the change in the toroidal indexing?
The plots are generated with the 'denf2d' flag of the plot_beams function, which calculates the plotted data as follows:
dist = squeeze(trapz(beam_data.paxis,trapz(beam_data.Vaxis,trapz(beam_data.Waxis,sum(beam_data.dist_prof,1),6),5),4));
I've confirmed that the axis arrays are the same, but maybe the definition was not consistent before these fixes?

Exactly.  This was a bug was with respect to how the toroidal angle was being calcualted in the distribution normalization.  Shouldn't affect NFP=1 configurations but does affect stellarators.  Thankfully this only affected the 5D distribution function which wasn't really used in any published results.


Avoids runing osd being marked out

This PR prevents running osd from being marked out if running osd id is
provided to the osd removal job template.
Signed-off-by: Servesha Dudhgaonkar<EMAIL_ADDRESS>

Please squash your commits.

yep squashing it

It looks like you reverted instead of squashed.

yeah. Fixing it

One more squash

okay

@xenolinux After you test the template by installing the private OCS build, could you post the template spec here for review? For example, the output of oc get template ocs-osd-removal -o yaml. Thanks!

Your commit message has 2 sign-off, one is enough

Changed back to one sign-off

@xenolinux After you test the template by installing the private OCS build, could you post the template spec here for review? For example, the output of oc get template ocs-osd-removal -o yaml. Thanks!

Okay. I will post it

Can you add a better commit message that explains what you did?

Sure

/retest

/override ci/prow/ocs-operator-e2e-aws


When will you npm publish v1.4?

closing, duplicate of #1191. currently the milestone is set to feb 28th.


[vdb] offer .gz version

Like v5, we need to offer vdb6 in both .xz and .gz format.

vdb is available in zstd format.


Allow extending PreparedGroupOperation

It'll allow users to create their own Group Operations.
Also, later we will provide implementation of group operation for StorIOSQLite with transaction support
@nikitin-da PTAL

:+1:


requirements-doc: add PyYAML which removes dependency on -base v2

This is "version 2" of #31239 rebased after #32593 which made many of the comments and discussions in #31239 obsolete.
3 commits, the main one:
This means a light requirements-doc.txt is enough for doc writers. See
previous discussions in PR #31199 and PR #31239
Also add comment that a west-less doc build is possible since the
spurious, indirect dependency on west was removed by commit
a56e1fa52d63a0 ("scripts: runners: bossac: handle edtlib ImportError")
which removed the zephyr_ext_common import from bossac.py.
Pro tip/note to self: changes to bossac.py do not trigger a fast, incremental doc build. Instead: touch doc/guides/west/build-flash-debug.rst does it (for bossac.py)

6f65ddc is not relevant anymore since the introduction of warnings_filter plugin.

I gave the github job yet another name because this (and other?) west warning(s) still escapes warnings_filter just like it escaped before.

@gmarull ping?


rustup: fix computing of the file download URI

If the source length didn't perfectly match the length of the default
source (https://static.rust-lang.org), the computed URI would be wrong.
e.g:
original URL:
https://static.rust-lang.org/dist/2021-03-25/rustc-1.51.0-x86_64-unknown-linux-gnu.tar.gz
with source = "https://short.org":
https://short.orgst-lang.org/dist/2021-03-25/rustc-1.51.0-x86_64-unknown-linux-gnu.tar.gz
with source = "https://a.very.long.mirror.url.rust.mirror.org":
https://a.very.long.mirror.url.rust.mirror.orgustc-1.51.0-x86_64-unknown-linux-gnu.tar.gz
This commit provides a better heuristic to get the URI, in the lack of
proper URL parsing.

Oh my, I can't believe I forgot about this! 😅
Thank you for the fix!


ceph-deploy: Disable timeout for pkg install/remove procedures

Do not timeout too early, here. If we use the pkg command to install
e.g. ceph-selinux or some other package with long post script we can
easily timeout in 5 minutes, disabling the timeout completely for the
pkg install procedure makes this much more safe.
The same holds for pkg removal.
Signed-off-by: Boris Ranto<EMAIL_ADDRESS>

Can one of the admins verify this patch?

ok to test

The new patch should cover Alfredo's comment.
btw: When looking at the code, while timeout usually takes precedence over global_timeout, it won't do so if timeout is 0 or None because of this line in remoto code:
timeout = timeout or global_timeout
I'd probably go as far as consider it a bug (or design flaw) in remoto/underlying libraries.

@alfredodeza can you merge this please?

@borix @ktdreyer there is one last thing here, the commits need to be reworded:
https://github.com/ceph/ceph-deploy/blob/master/CONTRIBUTING.rst#commits

Rebased with the updated commit message.


Update layered_repository/README.md

Just a description of the current state.

Looks good, thanks. I added a commit to reword a few things and fixed some minor typos. You can squash it before pushing.

Thank you for editing!


What is dangerous about mounting home writeable?

In the default config, there is:
mounts:
  - location: "~"
    # CAUTION: `writable` SHOULD be false for the home directory.
    # Setting `writable` to true is possible, but untested and dangerous.
    writable: false

I was wondering what kinds of failure modes we should expect from a writeable home, and if any data loss has ever been observed. It would help users evaluate the risks. E.g. am I only worried about individual files being corrupted if errors occur? Or my entire home being deleted by some freak mounting issue? I appreciate this may deliberately err on the side of caution and failures are not well-known, but any info would be great. Thank you :)

I believe this is just being cautious in general. In a way any software can cause catastrophic data loss.
Just as a point of reference, both Rancher Desktop and Colima (both of which use Lima under the hoods) have switched to mounting the home directory as writable for practical considerations.
@AkihiroSuda Will we ever change the default setting for Lima? If we want to, what would be the condition to enable this? If we say we don't trust sshfs, then we obviously will have to wait until we switch to something else. But otherwise I'm not sure what we would be waiting for.

What is the main use case for mounting the home directory ? Is it to access credentials from ~/.docker and ~/.ssh ?
Or is to access the current project files, which are just assumed to be stored somewhere under the home directory ?
Just wondering, seems like most the files that I edit are under /home/anders.linux rather than the remote /home/anders
Even if read-only, there are still the security and performance implications of exporting the home directory from the host.

In a way any software can cause catastrophic data loss.

I think data loss on the virtual machine is to be "expected"...
Not so on the host itself, which could be assumed to be separate.
Think it was even worse before* though, when all users were exported.

as in Docker Toolbox

@AkihiroSuda Will we ever change the default setting for Lima? If we want to, what would be the condition to enable this? If we say we don't trust sshfs, then we obviously will have to wait until we switch to something else. But otherwise I'm not sure what we would be waiting for.

We may reconsider the default after we get virtio-9p-pci.


Add ref information to upload request

Adds "ref" parameter extracted from git pre-push hook into the upload
request. This way servers with branch access permissions can enforce
them before large objects are transfered.
Issue: #845

Thanks for resurrecting #850. That slipped through the cracks during the holiday break. I'm trying to put out a v1.1.1 bug fix release this week, and then I want to start looking at new things like this.
Compared to #850, I like that this gets the ref from existing data, instead of another git call.
I'm not thrilled about passing an extra string argument to functions like NewUploadQueue(). Some kind of meta struct like in #850 would be preferable. However, it does seem kind of silly if Refs is the only property. But, it would give us a place to potentially add more metadata properties in the future.
I think the refs given to the fetch command should be passed to the DownloadQueue as well. But I don't think there's any way to support this in the standard LFS workflow that uses the git smudge filter. Git runs the smudge filters during checkout, which is after the git pull (if there even was one). Therefore it doesn't know the remote ref.

I've added UploadMetadata struct as you suggested. Also move "ref" property from the root of upload request object to the "meta" property. The "meta" (and "ref") will be only appended when there is something set.

Why keep it specific to uploads? You should be able to pass the same info from a git lfs fetch call, right? If the lfs server is going to look at the ref on uploads to verify authorization, it seems like it should for downloads too. Though I suppose the server could maintain a mapping of oids to remote refs.

I can add this to the fetch as well, but IMO this should be also verified on the server. Relaying only on the client data is not secure, since it is easy to craft malicious payload, through guessing the OID is hard.
One can say that that keeping branch-oid mapping is the implementation detail of server and LFS client should not impose that.

One can say that that keeping branch-oid mapping is the implementation detail of server and LFS client should not impose that.

100% agreed :+1:. Also, LFS won't be collecting that info when called through the smudge filter, so it may not be there anyway.
Thanks for the patch. This should make it into v1.2.0: #844

Thanks, that is awesome! :dancer:
When v1.2.0 is planned to be released?

I don't have a strict schedule. #844 has what I'd like to do for that release.  Though if it's taking too long, I may decide to cut a release with what I have at the time :)

I'm not crazy about how this makes the LFS push invoked by the pre-push hook semantically different to using git lfs push. Seems that a perfectly valid git lfs push would now fail if the server requires ref information, while a pre-push hook invoked version that does the same thing would succeed. Could lead to some odd support edge-cases?
Also the argument against passing refs for fetch was that client-side data can't be trusted, but that applies to pre-push too; I could easily craft my local branch state to include any branches I wanted and the pre-push hook will happily supply that to the server while uploading the LFS objects, even if the actual git push would be rejected, because by nature it happens before any other validation. If it's just to avoid wasting upload time on mistakes then fair enough but I hope no-one interprets it as a security feature.

I'm not crazy about how this makes the LFS push invoked by the pre-push hook semantically different to using git lfs push.

Ah yeah, we should be able to send the same data for a git lfs push.

I could easily craft my local branch state to include any branches I wanted and the pre-push hook will happily supply that to the server while uploading the LFS objects, even if the actual git push would be rejected, because by nature it happens before any other validation.

I think the idea is that their git server has special privileges for certain branches. It should authenticate based on the user AND the fetched ref. Though I imagine most LFS servers will ignore it.

I think the idea is that their git server has special privileges for certain branches. It should authenticate based on the user AND the fetched ref. Though I imagine most LFS servers will ignore it.

We are mostly concerned about push operations when we wold like to prevent users from pushing large files "to branches" that they  don't have access to. This is a optimization that people won't waste time waiting for the huge blob to upload only just to know that they have access for particular branch.

It should authenticate based on the user AND the fetched ref.

Yeah, my point is that the user can basically make up any ref they like, with a bit of local branch fudging & the correct git push call, and the the pre-push hook will just pass it in the request. So it's not really valid as an authorisation test. But @dluksza has confirmed it's really just to avoid them wasting their time with the LFS upload associated with a git push that subsequently gets rejected.

@dluksza: Yo, we didn't forget about this :) I really wanted this to work with git lfs push --all, so I had to update the scanner code: #1040. #1071 is a PR on top of that which includes this PR.
It's still kind of a mess now, but should be ready next week :)

Good to know that this change was not forgotten :) Looking forward for this change being merged.

@dluksza and @sinbad: would love your feedback on this:
So, this PR has no tests, and I caught a nasty bug in here. Now, testing this is pretty tricky (and I didn't even mention it in this PR), so I won't hold that against you. Here's the first pass of tests:
https://github.com/github/git-lfs/commit/620c94b9886452ef952244870238410fda6288f5
These tests are a little weird. Normally, the test lfs server doesn't even bother checking the ref. So, I added failsMetaCheck() that only fails if both are true:

An object OID matching the content meta-test exists. This tells the test server to verify the given ref.
An object OID matching the content meta-test: {full-ref} (example: meta-test: refs/heads/master) does not exist.

Nice thing is that these tests caught the fact that the strings.HasPrefix args are swapped. I noticed the tests were failing with:
Fails meta check with: {refs/heads/refs/heads/master}

I fixed it by changing it to strings.HasPrefix(ref, "refs/"), which also allows full tag refs too.
The tests pass on top of this PR, after it's been applied to #1128. I tested all the scenarios I could think of that work. Two that didn't work that I want to follow up on:

git lfs push with a tag
git lfs fetch with a tag

I'm not positive how we'd fix this, but that can come in another commit. I think we'd just have to attempt to expand ref names (master => refs/heads/master, v1.0 => refs/tags/v1.0) based on the local refs, erroring if there are any ambiguities. Maybe look into branch tracking stuff too.

I'm not positive how we'd fix this, but that can come in another commit. I think we'd just have to attempt to expand ref names (master => refs/heads/master, v1.0 => refs/tags/v1.0) based on the local refs, erroring if there are any ambiguities.

I'm still a bit uncomfortable with this feature being somewhat unreliable and locally exploitable. Leaving aside wilful exploitation, it also adds context in some cases but not all (e.g. pushing oids), and the context it sends is somewhat inconsistent currently - when invoked via pre-push it will send the remote branch name (because its passed the destRef), when invoked via git lfs push it will send the local branch name because it only uses the local ref. Sure most people use identical names for local/remote branches, but some don't.

Maybe look into branch tracking stuff too.

This would address that last point, but remember the answer can be different depending on the context (pull vs push). We only have code for the pull case right now because that's all we've needed, we haven't needed to derive a remote branch for push cases before. That's a bit more complex, you need to check the push.default config because it's only the same as pull when that's upstream or simple. It also depends on whether you're pushing to the remote you're tracking too.
I dunno, obviously this feature is useful in specific cases right now, I'm just a bit uncomfortable with things that are only reliable on the 'happy path'. In this case the bad outcome is only that the ref information given to the server might not be correct in odd cases, so I guess so long as we put a big red flag on this to say it's advisory only, can be manipulated by a smart user if they decide to, and may have some rare edge cases. Puts my teeth on edge a little but I can live with it ;)

+1 for expanded refs
For me it is all client facing REST-like API that one can try to exploit. The lfs-server URL and protocol are know, one can easily craft upload and download request with wrong oid and size. Same goes for the meta-data.
Server implementors must be aware of that. But wouldn't say that meta-data are less trusted in the worse case one would upload blob's and git data would be rejected (same as it is right now).
This is just a simple optimization for the end users so that they don't need to wait for the blob's being uploaded and then got access deny from the git server.

This PR is sorely in need of an update. I'll push an updated PR that fixes the merge conflicts. I have a few items I'd like to see before shipping in v1.4 or v1.5:

Ensure we're always sending full server side refs: refs/tags/v1.0, refs/heads/master. Never client ref names.

Integration tests that test git lfs push, git lfs fetch on repos where the local and remote branches don't match.

Allow additional properties in the json schema :)
"meta": {
  "type": "object",
  "properties": {
    "ref": {
      "type": "string"
    }
  },
  "required": [],
  "additionalProperties": true
}

Closing this, it's too far behind to merge. I've got an updated version though: #1456


Add new options (hdri, tcmalloc, svt-av1), improve install methods

What does this PR do?
This is still a draft PR containing a few changes and additions to imei.
New options:

--with-tcmalloc - Alternative memory allocator
--disable-hdri - Passes --disable-hdri to ImageMagick: improves conversion time
--with-svtav1 - Disables libaom default AV1 encoder, enabling SVT-AV1 instead - Faster encoder at the cost of file size

checkinstall changes:
I noticed a few make errors in the logs and realized cmake lacks make uninstall. So, the system got tainted with leftovers even when --build-only was set.
The only alternative I found was to set --fstrans AND --install to yes when --build-only was set. fstrans=yes ensures checkinstall doesn't touch our real filesystem, and --install=yes instructs it to install the newly compiled package... it's a bit contradictory, but it's a requirement to compile all the libraries. After everything is ready, these packages are removed again.
Test Plan
Well, it's an ongoing task. I'll provide more details soonish.
Related PRs and Issues
There are a few. I'll check them later.
Have you read the Code of Conduct?
[x] I have read the Code of Conduct

Summary by CodeRabbit

New Features

Introduced a new function for automating the installation of the SVT-AV1 library.
Added command-line options for enhanced configurability, including support for the SVT-AV1 encoder, TCMalloc, and HDRI.
Enhanced version information retrieval from both GitHub and GitLab.

Bug Fixes

Improved handling of installation options to ensure correct library configurations.

Documentation

Updated README to include SVT-AV1 version information.

svt-av1 also requires an update of https://github.com/SoftCreatR/imei/blob/main/update_version_info.sh

Huh, I found other serious issues with checkinstall + fstrans=yes... :disappointed:
I spent a few hours trying to workaround these issues, but things started to get way too complicated. I'll revert the fstrans changes tomorrow and think of another way to ensure all file dependencies are correctly installed.


First SQL commit.

@duftler please review.

Closing and will submit a new PR from newly-forked repo.


How themes are handled

Hi!
I am using sameersbn redmine for quite a while but still can not fully figure out how themes are handled. Inside the container they are located where supposed to in pubic/themes but is the content of this directory gets always recreated especially when some plugins (for example Redmine-X's) create their own theme? I do not seem to be able to find 'themes' with any content in the local filesystem...

Installing themes is described here: https://github.com/sameersbn/docker-redmine#installing-themes

Closing, reopen if you have further questions


[SPARK-50091][SQL] Handle case of aggregates in left-hand operand of IN-subquery

What changes were proposed in this pull request?
This PR adds code to RewritePredicateSubquery#apply to explicitly handle the case where an Aggregate node contains an aggregate expression in the left-hand operand of an IN-subquery expression. The explicit handler moves the IN-subquery expressions out of the Aggregate and into a parent Project node. The Aggregate will continue to perform the aggregations that were used as an operand to the IN-subquery expression, but will not include the IN-subquery expression itself. After pulling up IN-subquery expressions into a Project node, RewritePredicateSubquery#apply is called again to handle the Project as a UnaryNode. The Join will now be inserted between the Project and the Aggregate node, and the join condition will use an attribute rather than an aggregate expression, e.g.:
Project [col1#32, exists#42 AS (sum(col2) IN (listquery()))#40]
+- Join ExistenceJoin(exists#42), (sum(col2)#41L = c2#39L)
   :- Aggregate [col1#32], [col1#32, sum(col2#33) AS sum(col2)#41L]
   :  +- LocalRelation [col1#32, col2#33]
   +- LocalRelation [c2#39L]

sum(col2)#41L in the above join condition, despite how it looks, is the name of the attribute, not an aggregate expression.
Why are the changes needed?
The following query fails:
create or replace temp view v1(c1, c2) as values (1, 2), (1, 3), (2, 2), (3, 7), (3, 1);
create or replace temp view v2(col1, col2) as values (1, 2), (1, 3), (2, 2), (3, 7), (3, 1);

select col1, sum(col2) in (select c2 from v1)
from v2 group by col1;

It fails with this error:
[INTERNAL_ERROR] Cannot generate code for expression: sum(input[1, int, false]) SQLSTATE: XX000

With SPARK_TESTING=1, it fails with this error:
[PLAN_VALIDATION_FAILED_RULE_IN_BATCH] Rule org.apache.spark.sql.catalyst.optimizer.RewritePredicateSubquery in batch RewriteSubquery generated an invalid plan: Special expressions are placed in the wrong plan:
Aggregate [col1#11], [col1#11, first(exists#20, false) AS (sum(col2) IN (listquery()))#19]
+- Join ExistenceJoin(exists#20), (sum(col2#12) = c2#18L)
   :- LocalRelation [col1#11, col2#12]
   +- LocalRelation [c2#18L]

The issue is that RewritePredicateSubquery builds a Join operator where the join condition contains an aggregate expression.
The bug is in the handler for UnaryNode in RewritePredicateSubquery#apply, which adds a Join below the Aggregate and assumes that the left-hand operand of IN-subquery can be used in the join condition. This works fine for most cases, but not when the left-hand operand is an aggregate expression.
This PR moves the offending IN-subqueries to a Project node, with the aggregates replaced by attributes referring to the aggregate expressions. The resulting join condition now uses those attributes rather than the actual aggregate expressions.
Does this PR introduce any user-facing change?
No, other than allowing this type of query to succeed.
How was this patch tested?
New unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.

cc @cloud-fan

cc @agubichev @andylam-db


Proposal for different fix to 2.10 regression

Description
Fixes Airflow 2.10 regression / compat
Related Issue(s)
This is a fix for #1161, and is designed to be a different proposal to the changes in #1162.
Ultimately the issue that popped up in 2.10 relates to how the MRO was impacted by the Mixin class.
The simplest, most robust fix to make the MRO work properly is to make each mixin a subclass of BaseOperator. This doesn't require the unintuitive hack of needing an __init__() call to shuffle the MRO around, and it makes things more easily maintainable going forward, I think.
A note: This PR is merging to test-af-2.10, not main.
Tested for 2.10.
I also removed an unnecessary __init__ for the DbtTestMixin while I was at it.
Checklist

[x] I have made corresponding changes to the documentation (if required)
[x] I have added tests that prove my fix is effective or that my feature works

One more thing, after all of this gets resolved, we should either do this for each minor version from 1.3+, or alternatively put an upper bound on each previously released version as patch releases. I believe based on the Slack that there are a lot of users on 1.3 still.

cc: @pankajkoti we should include this in 1.6.0

we should either do this for each minor version from 1.3+, or alternatively put an upper bound on each previously released version as patch releases.

I'm not sure about this at the moment, but I'm open to hearing what others think. The user who has reported this issue using Cosmos 1.5.1.

I believe based on the Slack that there are a lot of users on 1.3 still.

Which Slack are you referring to?

Also, the CI is not running on this PR, possibly because the base branch is not main.

I'm merging this to branch test-af-2.10 to validate the CI check

Look like CI is not happy

@pankajastro That's weird. 😕 I did run tests locally for 2.10 and it worked, but I see now that 2.4 tests break.
Let's rollback on the other PR and we can merge this if/when it is ready. There is a higher criticality to just releasing a fix than there is to fixing it in a "good way."
Sorry for making this so complicated.

RE: upgrading other versions-- Fair enough, we won't backport then.
My one concern was that Airflow issues like this can be annoying because if a user upgrades their Airflow, downgrading Airflow to rollback a change can be very annoying because of the Postgres db requiring a downgrade, so if they are stuck on an old Cosmos version for some reason and they upgrade Airflow, now they have 2 problems.

Which Slack are you referring to?

Official Airflow slack, dbt channel.


📦 Updated to Minecraft 1.19.3

Updated mod to Minecraft 1.19.3 and cleaned a few things up.
I could tackle a larger project next if that would help, though I wouldn't want to work on something that's already being updated.

I will give this a test soon. Everything looks good so far just from briefing looking over the code.

Hey @Autovw, I've already contact you on Discord but going to post this here anyway. I am currently relicensing Golden Hopper to a more suitable license. I would like your permission to relicense your contributions to Golden Hopper under MIT.

I've already given my permission via Discord, but sure. That's fine with me.


about from outside_code.libmise import MISE

Hello, Rundi,
I would like to ask, what is the meaning of using MISE in your code. And can you briefly describe some extra information about it?
Thanks very much!!!

At first I thought it could be faster (adaptive sampling) as described by the OccNet paper, so I use it. But later I found in practice it seems to still evaluate all points in the space, thus using MISE is not necessary.

thanks


feat/audio input

Is your feature request related to a problem? Please describe.
Is there a way to load audio files directly into Unstructured?
Describe the solution you'd like
There are lots of documents in organisations that non text based and it would be useful to be able to break these down and search these (i.e. Audio Vectors)
Describe alternatives you've considered
I don't really want to transcribe the audio first if I can get away with it
Additional context
Add any other context or screenshots about the feature request here.

Closing this issue. We're not going to support audio in the OSS lib, but do plan to add support for audio files to our API.


std.functional.memoize: Ability to clear the cache

aurelien.fredouelle+dlang (@AurelC2G) reported this on 2019-05-11T08:51:53Z
Transfered from https://issues.dlang.org/show_bug.cgi?id=19859
Description
Other common implementations of memoize usually allow to reset the cache. For example, this is quite common in python:

@memoize
def square (x):
  return x*x

square(2)
square(3)

square.cache.clear()

It would be helpful if we could accomplish the same with std.functional.memoize.

aurelien.fredouelle+dlang commented on 2019-05-12T12:01:54Z
Just tried implementing this by making memoize a struct with a static opCall: https://github.com/dlang/phobos/compare/master...AurelC2G:19859-memoize-cache-clear

However I ran into bug #18289, so this doesn't work as-is.

Any suggestions?


Revert scriptt

Had to revert the update index script. @tomleb3.
With your commit the substring of ' was not working properly.

Makes sense. I'll handle it. Script could probably be made less brittle.

Makes sense. I'll handle it. Script could probably be made less brittle.

Makes sense. I'll handle it. Script could probably be made less brittle.

Yeah.. The scipt was not to beuatiful, but wanted to release it fast..
We should also install prettier to standarise some styles.

Alright, I'll probably get around to further fixups later today.
Btw, in the repo settings, you can enable the option to automatically delete merged branches.
Not a must but I usually enable it in my projects to avoid branch pollution lmao


Feature: cancellation tokens

What exactly happens when my FS implementation takes too long?
Right now I am doing async calls and explicitly call .Result, which blocks the current thread until result is completed.
But I am not passing any cancellation tokens to them, because I don't get any from Dokan, so the calls can essentially last forever.
What do you think is the best option, have Dokan generate cancellation tokens matching its own expectation of when the calls should complete, or just create my own and set the same timeout value as I pass to DOKAN_OPTIONS.TimeOut?

The best option is to create your own cancellation token with the same timeout as you pass to Dokan. That will avoid lots of unnecessary work by called methods when the request from Dokan has timed out anyway.


Add FR to translation list

Depends on FR translations

https://github.com/jocmp/capyreader/blob/main/app/src/main/res/xml/locales_config.xml

I've juste translated using weblate.
Thanks for your nice app!

Thanks @eliovir! I'll include them in the next release.


Firefox opens but does not load any page

Hello Everyone,
I am running Robot Framework RIDE in testing machine.
Automatic testing was going smoothly with Firefox 31
Recently my firefox gets updated automatically and all my test cases are getting failed.
By reverting to Firefox 31 it works.
I don't know what really happened after updating firefox.
It looks like there is a problem in patching with selenium library and firefox.
Could  someone please tell how to resolve this problem ?
Where to get information about Selenium & Firefox Patch management?
Any help will be greatly appreciated.
Thank you
Hasmukh Maniya

There is usually a lag in between the time Firefox is released and when selenium supports that version. Most people I know tend to turn off auto-updates so this breakage doesn't occur. To see what version is supported I view the CHANGES log.  Note sometimes there is a further lag for native actions (see [old] documentation about native events). So be aware of what each selenium version provides and doesn't provide.

Thank you @emanlove
Actually I wanted to know whether is there any specification mentioned patches with the versions of Selenium and Firefox browser ?

@hasmukh, what version of firefox are you running now?

I am using FireFox 31 on one machine and Firefox 31 ESR on second machine.

There has not been activity for this issue for long time and we are planning to close the old issues if they are not anymore valid ones. If you feel that this is still valid issue, could you send an update. If update is not received in a month, we will assume that this is not anymore an issues and we will close this issue.


Evaluate replacing Commander with ArgumentParser in Benchmarks

Apple recently unveiled the ArgumentParser library for easing the parsing of command-line options. The Benchmarks target currently uses Kyle Fuller's Commander to provide a clean interface for command-line options.
ArgumentParser provides an intriguing alternative, and seems to have growing support behind it, so we would like to examine if it is practical and desirable to switch from Commander to ArgumentParser within the Benchmarks target. Ideally, we would like to maintain the same command-line options and interface as exists now, so that Benchmarks won't change its interaction with internal test runners.
If Benchmarks could be converted to use ArgumentParser instead, while maintaining the same interface, and the code for doing so looked reasonable, I think we'd welcome a PR that made this change.

I started to play with ArgumentParser when it was announced and tried to use it in this repo .. I was not aware that @BradLarson had created this Issue here ..  but if it is of any help for you @shabalind .. I published what I ended up with here: https://github.com/vguerra/swift-models/commit/3c4e2cc68311c1b7ef9bcdb723d2ea748e30a160

@vguerra Do you mind opening a PR, the changes look like a fix for this issue! 👍

sure @shabalind .. I pushed https://github.com/tensorflow/swift-models/pull/357


Add C/C++ ecs benchmarks for reference

why, not? Just to make people aware of alternatives, and to give a glimpse of them. Also some of them have ports or bindings to sharp so I guess it's relatable. And, no, I'm not trying to convince anyone to use one over the other
Here one I've found https://github.com/abeimler/ecs_benchmark

Sure why not, as long as it's simple to integrate with the others :) (and I'm not the one doing it haha)


Origin/Pivot Point of Node Position

Hello, I looked around and didn't seem to see any reference material on the topic for Viro.
I was wondering what the origin point / pivot point of a node was. Is it the center of the node, bottom left, top right? Specifically when the geometry is a text element.
Thank you

Hi @browniefed,
The default pivot is the center of the object.
If you want to change the pivot, check out setRotationPivot() on the Node.java object:
https://developer.viromedia.com/virocore/reference/com/viro/core/Node.html#setRotationPivot(com.viro.core.Vector)
Hope that helps,

Andy

Thanks for the information


change enum to @IntDef

How authors feel about changing ActivityEvent and FragmentEvent from enums to @IntDef?
Not a big improvement, but ints are smaller than objects.

No thanks. I'd rather stick with enums.


Cannot erase command properly in integrated terminal (Oh My Zsh)

If you use integrated terminal and type a command, and tab to navigate your project, and then try to erase the entire command, it will not erase the first letter.

How are you "erasing the entire command"?

If the first letter is just stuck there and isn't part of the next command that's run I think this is a zsh bug as I've repro'd it in other terminals.


cmd/digest: import crypto algorithms

the digest cli does not work if we do not import this two packages,
tested in go1.9. basically, we have to make several algorithms to
be available by calling crypto.RegisterHash in init functions.

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "algo-import" git@github.com:zhouhaibing089/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

LGTM