[SPARK-39647][CORE] Register the executor with ESS before registering the BlockManager

What changes were proposed in this pull request?
Currently the executors register with the ESS after the BlockManager registration with the BlockManagerMaster.  This order creates a problem with the push-based shuffle. A registered BlockManager node is picked up by the driver as a merger but the shuffle service on that node is not yet ready to merge the data which causes block pushes to fail until the local executor registers with it. This fix is to reverse the order, that is, register with the ESS before registering the BlockManager
Why are the changes needed?
They are needed to fix the issue which causes block pushes to fail.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added a UT.

@mridulm @zhouyejoe @Ngone51 Please help review

The fix is neat. Overall LGTM.

Can one of the admins verify this patch?

Took a quick look, the change looks good to me.
+CC @attilapiros, since you had touched this codepath reasonably recently.

@otterc GA failed

@otterc GA failed

This below test failed. I don't think it is related to this change.
info] *** 1 TEST FAILED ***
[error] Failed: Total 3385, Failed 1, Errors 0, Passed 3384, Ignored 9, Canceled 2
[error] Failed tests:
[error] 	org.apache.spark.scheduler.HealthTrackerIntegrationSuite

I have retrigerred the jenkins job..

The same test in HealthTrackerIntegrationSuite failed again
 Bad node with multiple executors, job will still succeed with the right confs *** FAILED *** (20 seconds, 47 milliseconds)
[info]   java.util.concurrent.TimeoutException: Futures timed out after [20 seconds]
[info]   at scala.concurrent.impl.Promise$DefaultPromise.ready(Promise.scala:259)
[info]   at scala.concurrent.impl.Promise$DefaultPromise.ready(Promise.scala:187)
[info]   at org.apache.spark.util.ThreadUtils$.awaitReady(ThreadUtils.scala:334)
[info]   at org.apache.spark.scheduler.SchedulerIntegrationSuite.awaitJobTermination(SchedulerIntegrationSuite.scala:276)
[info]   at org.apache.spark.scheduler.HealthTrackerIntegrationSuite.$anonfun$new$9(HealthTrackerIntegrationSuite.scala:92)

It seems unrelated to this change

@otterc Could you push an empty commit to retrigger the tests?

All the tests pass now @Ngone51 @mridulm

Merging to master and branch-3.3

Merged to master and branch-3.3
Thanks for fixing this @otterc !
Thanks for reviewing @attilapiros, @zhouyejoe, @Ngone51 and @weixiuli :-)

BTW, do you think we can have this at branch-3.2 ?

Good question @dongjoon-hyun, I was not sure about 3.2 actually - I was assuming it wont be relevant there (since this change is relevant mostly in context of push based shuffle). But after looking at an internal PR by @otterc, I believe you are right - we should merge it to 3.2 as well.

Now that 3.2.2 vote has passed, can you create a PR against branch-3.2 for this change @otterc ? Thx


Jesse: Watch zevendevelopment.com

Jesse requests the watch of the watch_keyword zevendevelopment\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

zevendevelopment\.com has been seen in 1 true positive, 0 false positives, and 1 NAA.

Approved by Jeff Schaller in Charcoal HQ


System Requirement for Flyway Enterprise Server

Which version and edition of Flyway are you using?
flyway-7.12.1
Dear Team - Could you please help me to collect information How to set up an enterprise server for Flyway with standard system requirements? The most steps explained at Flyway documentation site looks like a setup process for a personal laptop.
If this is not the latest version, can you reproduce the issue with the latest one as well? (Many bugs are fixed in newer releases and upgrading will often resolve the issue)
NA
Which client are you using? (Command-line, Java API, Maven plugin, Gradle plugin)
All of them - Command-line, Java API, Maven plugin, Gradle plugin
Which database are you using? (Type & version)
Microsoft SQL Server 2012
Which operating system are you using?
Windows 2012
What did you do? (Please include the content causing the issue, any relevant configuration settings, the SQL statement(s) that failed (if any), and the command you ran)
NA
What did you expect to see?
NA
What did you see instead?
NA

There are no special requirements, Flyway installs and operates in the same manner if it is a server, workstation or laptop.

Closed until further interest

Hi Julia,
Could you please help to resolve the below flyway issue?
https://stackoverflow.com/questions/68921553/cannot-open-database-flyway-requested-by-the-login-the-login-failed
On Thu, Aug 12, 2021 at 5:19 PM Julia Hayward @.***>
wrote:

There are no special requirements, Flyway installs and operates in the
same manner if it is a server, workstation or laptop.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/flyway/flyway/issues/3251#issuecomment-897573877, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ABCIJBZ4BGDOLMP2Y7SSR7LT4OYN5ANCNFSM5B5PIKKQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

--
Thanks & Regards,
Vinod Soni
+91-989969444
+1-502-299-0641


Spellcheck Integration

Is your proposal related to a problem?
When multiple users are updating descriptions or enriching dictionary terms we see a reasonable frequency of spelling mistakes (we maybe also need to find team members who can spell 🤦)
Describe the solution you'd like
Ideally an integrated spell check solution (be it browser whatever) where within description fields there would be an underlining of mistakes for the user to fix.

Hey @clintjb ! Thanks for noticing. We will enable default native browser spellcheck for the textarea fields. Like this

Perfect, yes think native browser is more than adequate 👍


Fix for bottom sheet fling/snap/settle bugs

There are several bugs related to snapping back to the anchor state:

In Google Maps the anchor state is sticky - the Backdrop Element needs to be pulled down at least 50% before the Bottom Sheet collapses. If it is pulled less than 50% the Bottom Sheet snaps back to the anchor. The behavior of the lib is different - as soon as the Backdrop Element is pulled down even a tiny amount and released, the Bottom Sheet collapses rather than snapping back. Please see video:
https://vimeo.com/200534893

Similarly to 1), going from anchor state to expanded should require making the Backdrop half-way shut. Currently dragging up from anchor state by an infinitesimal amount and the lifting the finger is enough to expand the Bottom Sheet. Please see video:
https://vimeo.com/200536226

Current lib behavior does not take fling velocity into account.

Current lib behavior does not force stop at anchor state.

Pull request for all fixes here. Please let me know if you come across any bug with this.
https://github.com/miguelhincapie/CustomBottomSheetBehavior/pull/27

I guess we are missing something in what he did in one of those commit related to fling.
Someone from my last company show me the app behavior in one smartphone with an old version of this library and the new one (he download my app from the market and that one has the last commit). In old one I tried like 12341234 times reproduce the issue related to "jump" anchor_point and get from collapsed to expanded in one shoot but I couldn't. Meanwhile in the news one was easy to reproduce it.
So I guess we are missing a little logic behind those changes.

Sorry - I am not clear on what the issue is. Are you saying the 'stop at anchor' worked BEFORE PR#27 and doesn't work AFTER PR#27?

In somehow yes, I mean, like I said, I tried so many times in an old version of the lib and I couldn't reproduce "jump state" behavior (It could be I didn't try in the right way... no idea). But what I'm sure is that was easy to reproduce it using last version of the lib, so I'm guessing we are missing some logic in the new fling behavior.

Can you take a look at my fork and see if everything works? I've made many changes over the past few days.
https://github.com/vit001/CustomBottomSheetBehavior

My phone died unfortunatelly so I am stuck with the emulator for a couple of days , very clunky... :(

OK, I see the issue - I have my BottomSheet in a Horizontal ViewPager (another layer of NestedScrollingParent), so some of the code doesn't work the same in your lib demo. I am going to push out my Horizontal ViewPager code as a lib so you can take a look, and maybe you'll find use for the paging ability as well ... :)

yeah, because all the different configurations you can have with this lib, I'm going to make 2 or 3 demos plus the principal one. It sounds good having integration with that lib you are going to release.
note: I don't like how it sounds when you say "in your lib" :D. I mean, I just started this lib but it has grown because @akaN44 and you... so it's better if you say "our lib".

@miguelhincapie - Still working on a clean demo and fixing toolbar, but you can check out https://github.com/vit001/CustomBottomSheetBehavior - the paging and scrolling works perfrect for me.
https://vimeo.com/203024083
By the way, if you don't want the horizontal pager functionality, you can always provide an adapter with only one item.


Updates to service defaults article

We need to augment the Service Defaults (SD for short from here on out in this issue) article to document how folks could roll their own custom SD project. Specifically useful for supporting projects like the Worker, which uses the Worker SDK instead of the Web SDK, or console or executable projects, which don't have access to the ASP.NET Core libraries (nor would there be any need to add those to these style of projects via add-refs).
There's a sample in the aspire-samples repo here demonstrating a solution with multiple SD projects. Some things to point out when looking at this sample:

The app defaults project avoids referencing ASP.NET Core
The service defaults project is more like the one we drop in for File -> New Aspire project creations, referencing ASP.NET Core
The service defaults project is marked with the IsAspireSharedProject property.

In our article update, we should tweak the code view of the SD csproj so that we have a tab view. One tab should show an "aspnet core-dependent" Service Defaults project. The other tab should show the "aspnet core-independent" version. This way people have copyable source in the docs for either scenario. We need to take care in the non-aspnetcore one to also include the IsAspireSharedProject property. This property could be used by developers to identify multiple options for the SD project they want projects to use. We'll need to support this so non-aspnetcore customers have guidance on how to build their own custom SD projects.

There's a sample in the aspire-samples repo here demonstrating a solution with multiple SD projects.

I only see a single SD project in this sample. And the AppDefaults project isn't marked with IsAspireSharedProject.
If we're tweaking the article to show tabs, are we planning on introducing a new .NET Aspire template for AppDefaults? Or something like that, which would avoid the FrameworkReference?

We aren't planning at this time on adding a non-aspnetcore dependent service defaults project template. The doc is more to inform folks that it's possible should they need to do it. Whilst I don't mind the idea of a second template, I really prefer the stance of showing folks what they could do.
As to the IsAspuireSharedProject, we're thinking of changing the name to IsAspireDefaultsProject, but that's not yet locked. I'll update this issue once it is. And, we are working on supporting multiple defaults projects in the tooling experience.

@BillHiebert and @phenning - if/when the property name changes, please make sure to have me or one of us update this so @IEvangelist knows what to call it in the docs.


Added new links

Fixes Issue

Changes proposed

Screenshots

Note to reviewers

Don't commit package.json also resolve the conflicts

It appeared on git status, that's why I added it

Can I remove it?

@Oyebolade why did you close the PR?


selinux: document how to put enforce mode on

We have it in advisory mode, now tell users how to enable it.
@mjg59 could you take a swing at this?

Other bonus topics:

Enabling SELinux for Docker Daemon
Enabling SELinux for rkt (coming soon)

Closing due to inactivity.


FIX: Raw.filter() picks=None include seeg

The previous raw.filter did not include seeg channels by default, and I didn't find any test of the picking behavior.

Travis is sad at you because dict comprehension doesn't work on Py26. You can instead do dict((key, val) for key, val in zip(whatever)).

Otherwise LGTM

close in favor in #2950


U1 - View neighborhoods (5 pts)

As a user, I want to be able view different neighborhoods along York Road so that I am more familiar with the area

commit 4db4ad3f00a734b410ead18fe688b2191d847f49


Reduce image size by 29.74% through lossless compression algorithm

We may consider introducing the ImgBot robot into the project to perform lossless compression on the pictures in the project to improve access efficiency. In the future, ImgBot will automatically create a PR similar to this for newly added pictures. FYI, https://github.com/marketplace/imgbot.


enable goerr113 linter

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, renaming)
[x] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?

Issue Number: #941
What is the new behavior?

Other information

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.65%. Comparing base (836562e) to head (9217667).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1147       +/-   ##
===========================================
- Coverage   67.69%   39.65%   -28.05%
===========================================
  Files         297      296        -1
  Lines       29909    29773      -136
===========================================
- Hits        20246    11805     -8441
- Misses       8742    17550     +8808
+ Partials      921      418      -503

Flag
Coverage Δ

?

go-1.21.x
41.20% <ø> (-28.09%)
:arrow_down:

go-1.22.x
39.64% <ø> (-28.03%)
:arrow_down:

integration
?

macOS
?

ubuntu
39.65% <ø> (+0.01%)
:arrow_up:

unit
39.65% <ø> (-0.02%)
:arrow_down:

windows
?

ydb-23.3
?

ydb-24.1
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[bug] World UVs incorrect on certain surfaces

Note that this is likely an incorrectly implemented or not implemented material property, as other world textures align perfectly.
Also in addition to the screenshots above, the grass textures are extremely stretched (this may be an internal issue in BSPParser)

Most of these were fixed by #32, however displacement textures are still horribly stretched
There does seem to be a texture scale attribute but it's not on the materials

Fixed in 0a0dd63c35e1418edb18a06f5e19c72c4c7d7bff


Very large proto file takes a long time to compile

Contains a large number of message proto file, compiled very slowly

Do you have an example file I can test with? How many messages are defined in the proto?

https://github.com/fireyang/exprotobuf_performance
40 message and 3 enum; Add a new message every time recompile all

Thanks! I'll take a look as soon as possible

similar experience here w/ https://gist.github.com/dweinstein/5c2fa9a197974ee0fcf766e67d683854

It looks like the bulk of the time is split between gpb parsing and the Elixir compiler - ultimately there isn't much I can do to ease this with the current architecture.
I'm not sure if there is anyway to generate the Elixir source such that compilation is meaningfully faster (at least from a clean state), however one approach would be to generate Elixir source files, and which are then subsequently compiled. This is how one consumes gpb directly, and I am interested in going that route, because it would be much easier to ensure that only those things which actually changed are recompiled.
I'm considering a rewrite of exprotobuf for that reason, amongst others, but time is elusive, so I haven't been able to take a good crack at it yet.

@bitwalker Would you please consider to use enif_protobuf? It looks it is at least (3 times faster)[https://github.com/jg513/enif_protobuf#performance] than gbp


add delay after etcd start

add some time after etcd start to wait it start complete. To avoid etcdctl fail if not start complete.

Coverage increased (+2.8%) to 77.901% when pulling 7e540ad6828805702fac52dffc0030c4398c6206 on xyl_add_delay_for_ci into 0a57813a6a78422b0ca22f9df0a12c1281190ac3 on master.


[iOS]: Call rings just for 2-3 seconds when app is terminated.

I am using FCM to signal calls. As iOS doesn’t show silent Notification in terminated state, I am using 2 silent notification at a time. First one awakes the app 2nd one triggers executable code. (Though it could be uncertain).
The problem is, the call rings only for 2-3 seconds and stops automatically. It actually returns "Call Failed"

up

Any update on this? I have been facing the same issue?

Same here as well, this has become serious issue for out application

We have the same issue, it also only happens on production builds, in debug all is fine and the app works as expected.

I think, make sure call complete.
https://github.com/hiennguyen92/flutter_callkit_incoming/blob/2c42076c7c873be7645399c0ac72d9e2b1b68fbf/example/ios/Runner/AppDelegate.swift#L87

We are receiving our notification via FCM, so we have only Flutter code at that point.
we then call
await FlutterCallkitIncoming.showCallkitIncoming(callKitParams);
from the notification handler, which then fails the first time, the notification shows up and disappears again.
Doing it a second time right away, does the same, but the notification stays on screen.

@hiennguyen92 we are still a bit stuck on this issue.
I tried to contact you via E-Mail and my boss via LinkedIn, we would like to get you involved into taking onto the issue directly (as a consultant).
It would be great if you could reply to our inquiries.


Add @types for better typescript support

Now Vetur throws an error when accessing this.$colorMode:
Property '$colorMode' does not exist on type 'CombinedVueInstance...'

A solution could be to define the $colorMode object in @types

Maybe creating a module.d.ts file:
import Vue from 'vue'
declare module 'vue/types/vue' {
  interface VueColorMode extends Vue {
    value: string
    preference: Boolean
    unknown: string
  }
  interface Vue {
    $colorMode: VueColorMode
  }
}

I tried to make a PR @Atinux but Idk how to add the definition file in the build :(
Thanks in advance

Hey @xavism
Thank you for your help on this, I think we need to so something similar to https://github.com/nuxt/http/tree/dev/types
And then add the files in the package.json, see https://github.com/nuxt/http/blob/dev/package.json#L12

@Atinux It doesn't seem this is done yet. It might be a good idea to add the types field to package.json and reference the type declarations there. I send #52 for this.

The error still occurs under nuxt 3 & "@nuxtjs/color-mode": "^3.0.1"


Add a server-specific compatibility check to api_get_server_settings.

This is a continuation of the changes proposed in #10924 (which corresponds to zulip/zulip-mobile#3158; it adds the boolean value is_compatible (edit: renamed to is_incompatible) to the result returned from /server_settings.
@timabbott @gnprice

Hm, I think is_incompatible probably better aligns with the check, which currently looks for ZulipInvalid. (I'll update that~)

I'm working on adding to / modifying the tests.
There's also some logic that should be added, as discussed to with Greg, to modify the server's behavior of responding with the 500 status code when an incoming request to /compatibility or /server_settings has no User-Agent header.

This is ready for more review!

I edited the commit messages of the first two commits and then merged them.  For the third commit, can you check what current versions of the mobile app do if they gets a 400 error in the server_settings response?  If it's bad, we might want to instead just use a default value for User-agent if not provided.

Also @akashnimare can you check whether the Electron app sends User-agent when doing /server_settings calls?

Hmm, is there any easy way to get this?

Well, we've gotten a form of answer when I deployed this to chat.zulip.org: Some client clearly requests /server_settings without setting an HTTP_USER_AGENT.  Just added some logging that should reveal which one it is.

(I think in any case, this answers our question: We should return data for such clients, not break them)

OK I merged the 3 commits ending with b7127a395b94e50440a55ad970e796e23d51d74d to fix this in the only reasonable way given that we have clients that are not sending User-Agent.

@akashnimare I'm not sure what's going on, but when I tested the desktop app master again my development environment with these changes, it logged this:
2018-12-11 19:29:15.669 INFO [zr] <IP_ADDRESS>       GET     200 150ms (md: 24ms/1) (db: 3ms/3q) /api/v1/server_settings (unauth via Unspecified)
(Suggesting that for a request to /server_settings, it wasn't setting User-Agent).  It's possible something is wrong with my new logging, but I do see Mozilla as the client if I try calling /server_settings from the JS conosle in a browser).  Worth investigating...

Hm, from looking at the codepaths on mobile, the User-Agent header is included with every request that's sent via the apiFetch module, which was introduced 2 years ago with https://github.com/zulip/zulip-mobile/commit/9d9720c74ccf0aebb35a51e018ced676dbc7970a and hasn't been modified.
On mobile, currently the only place where a call to /server_settings is made is on the RealmScreen, which corresponds to the same piece of UI for an "Add new organization" page. I tried excluding the User-Agent header from the params passed in apiFetch; I haven't observed any difference in terms of how the UI behaves.

I tested the mobile app with the dev server, commenting out the User-Agent property in headers returned from getFetchParams:
  headers: {
    'Content-Type': contentType,
    // 'User-Agent': userAgent,
    ...(auth.apiKey ? { Authorization: getAuthHeader(auth.email, auth.apiKey) } : {}),
  },

The development environment logged this:
2018-12-11 22:11:50.323 INFO [zr] <IP_ADDRESS>        GET     200  20ms (db: 9ms/2q) /api/v1/server_settings (unauth via ZulipMobile)

which suggests maybe I'm missing something in my analysis? Somehow, User-Agent is still sent.

@jackrzhang well, I think mobile is doing the right thing and desktop is not, so I'm not sure we should expect anything to be wrong with your analysis?

So for desktop app, yeah it doesn't send User-Agent when adding a server but it does send it once the server is added as shown in image above or when using console. This is because the desktop app uses a npm module for making a request to fetch the setting when adding server whereas otherwise the request would be send by chromium so it has User-Agent set.

@priyank-p cool, can you open an issue in zulip-electron for setting User-agent in that npm module's configuration?  We probably want to make sure we do that.

The User-Agent issue was resolved via https://github.com/zulip/zulip-electron/issues/611.


Upgrade gems

:watch: on Travis

:disappointed:

:watch: :watch: :watch:

@jcoyne Foo!  I merged Valerie's, which conflicts with yours.  Can you rebase?

@cam156 rebased


Cargo.lock not updated for 0.1.4 release

The Cargo.lock mentions 0.1.3 instead of 0.1.4 for at the 0.1.4 tag.
This prevents the compilation from working:
++ env CC_x86_64-unknown-linux-gnu=/nix/store/bfbp3ypd9nm3fapz634gvvs738blrl0y-gcc-wrapper-12.2.0/bin/cc CXX_x86_64-unknown-linux-gnu=/nix/store/bfbp3ypd9nm3fapz634gvvs738blrl0y-gcc-wrapper-12.2.0/bin/c++ CC_x86_64-unknown-linux-gnu=/nix/store/bfbp3ypd9nm3fapz634gvvs738blrl0y-gcc-wrapper-12.2.0/bin/cc CXX_x86_64-unknown-linux-gnu=/nix/store/bfbp3ypd9nm3fapz634gvvs738blrl0y-gcc-wrapper-12.2.0/bin/c++ cargo build -j 8 --target x86_64-unknown-linux-gnu --frozen --release
error: the lock file /build/source/Cargo.lock needs to be updated but --frozen was passed to prevent this
If you want to try to generate the lock file without accessing the network, remove the --frozen flag and use --offline instead.

Ick, I haven't touched this project in 2 years and I've been mad going at it trying to update the lower hanging fruit. Let me try to fix that.

Repushed a tag, release, and master and so on. I think it'll build and all but let me know if that doesn't work or not.

Indeed it works fine.
However, when running the program, I have Error: LatencyTestClosestError.
With RUST_LOG=trace it gives:
Retrieving speedtest.net configuration...
[2023-02-26T11:49:31Z INFO  speedtest_rs::speedtest] Downloading Configuration from speedtest.net
[2023-02-26T11:49:31Z TRACE reqwest::blocking::wait] (ThreadId(1)) park without timeout
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] (ThreadId(2)) start runtime::block_on
[2023-02-26T11:49:31Z TRACE reqwest::blocking::wait] wait at most 30s
[2023-02-26T11:49:31Z TRACE reqwest::blocking::wait] (ThreadId(1)) park timeout 29.999994655s
[2023-02-26T11:49:31Z DEBUG reqwest::connect] starting new connection: http://www.speedtest.net/
[2023-02-26T11:49:31Z TRACE mio::poll] registering event source with poller: token=Token(0), interests=READABLE | WRITABLE
[2023-02-26T11:49:31Z TRACE want] signal: Want
[2023-02-26T11:49:31Z TRACE want] signal found waiting giver, notifying
[2023-02-26T11:49:31Z TRACE want] poll_want: taker wants!
[2023-02-26T11:49:31Z INFO  speedtest_rs::speedtest] Downloaded Configuration from speedtest.net
[2023-02-26T11:49:31Z INFO  speedtest_rs::speedtest] Parsing Configuration
[2023-02-26T11:49:31Z TRACE reqwest::blocking::wait] wait at most 30s
[2023-02-26T11:49:31Z TRACE reqwest::blocking::wait] (ThreadId(1)) park timeout 29.99994772s
[2023-02-26T11:49:31Z TRACE reqwest::blocking::wait] (ThreadId(1)) park timeout 29.995546706s
[2023-02-26T11:49:31Z TRACE reqwest::blocking::wait] (ThreadId(1)) park timeout 29.99551688s
[2023-02-26T11:49:31Z TRACE mio::poll] deregistering event source from poller
[2023-02-26T11:49:31Z TRACE want] signal: Closed
[2023-02-26T11:49:31Z TRACE want] signal found waiting giver, notifying
[2023-02-26T11:49:31Z TRACE want] poll_want: closed
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] closing runtime thread (ThreadId(2))
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] signaled close for runtime thread (ThreadId(2))
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] (ThreadId(2)) Receiver is shutdown
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] (ThreadId(2)) end runtime::block_on
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] (ThreadId(2)) finished
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] closed runtime thread (ThreadId(2))
[2023-02-26T11:49:31Z INFO  speedtest_rs::speedtest] Parsed Configuration
Retrieving speedtest.net server list...
[2023-02-26T11:49:31Z INFO  speedtest_rs::speedtest] Download Server List
[2023-02-26T11:49:31Z TRACE reqwest::blocking::wait] (ThreadId(1)) park without timeout
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] (ThreadId(4)) start runtime::block_on
[2023-02-26T11:49:31Z TRACE reqwest::blocking::wait] wait at most 30s
[2023-02-26T11:49:31Z TRACE reqwest::blocking::wait] (ThreadId(1)) park timeout 29.999995284s
[2023-02-26T11:49:31Z DEBUG reqwest::connect] starting new connection: http://www.speedtest.net/
[2023-02-26T11:49:31Z TRACE mio::poll] registering event source with poller: token=Token(0), interests=READABLE | WRITABLE
[2023-02-26T11:49:31Z TRACE want] signal: Want
[2023-02-26T11:49:31Z TRACE want] signal found waiting giver, notifying
[2023-02-26T11:49:31Z TRACE want] poll_want: taker wants!
[2023-02-26T11:49:31Z TRACE mio::poll] deregistering event source from poller
[2023-02-26T11:49:31Z TRACE want] signal: Closed
[2023-02-26T11:49:31Z TRACE want] poll_want: closed
[2023-02-26T11:49:31Z INFO  speedtest_rs::speedtest] Downloaded Server List
[2023-02-26T11:49:31Z INFO  speedtest_rs::speedtest] Parsing Server List
[2023-02-26T11:49:31Z TRACE reqwest::blocking::wait] wait at most 30s
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] closing runtime thread (ThreadId(4))
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] signaled close for runtime thread (ThreadId(4))
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] (ThreadId(4)) Receiver is shutdown
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] (ThreadId(4)) end runtime::block_on
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] (ThreadId(4)) finished
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] closed runtime thread (ThreadId(4))
[2023-02-26T11:49:31Z INFO  speedtest_rs::speedtest] Parsed Server List
Testing from SFR (<IP_ADDRESS>)...
Selecting best server based on latency...
[2023-02-26T11:49:31Z INFO  speedtest_rs] Five Closest Servers
[2023-02-26T11:49:31Z INFO  speedtest_rs::speedtest] Testing for fastest server
[2023-02-26T11:49:31Z TRACE reqwest::blocking::wait] (ThreadId(1)) park without timeout
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] (ThreadId(6)) start runtime::block_on
[2023-02-26T11:49:31Z INFO  speedtest_rs::speedtest] Fastest Server @<PHONE_NUMBER>3709551615000ms : None
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] closing runtime thread (ThreadId(6))
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] signaled close for runtime thread (ThreadId(6))
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] (ThreadId(6)) Receiver is shutdown
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] (ThreadId(6)) end runtime::block_on
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] (ThreadId(6)) finished
[2023-02-26T11:49:31Z TRACE reqwest::blocking::client] closed runtime thread (ThreadId(6))

Yeah there's something causing that. I'll open a new issue on that. It's oddly hard to repro sometimes but does pop up in GHA workflows .too


[Power] Fix for undefined symbol brcm_pm_init

https://jenkins.code.rdkcentral.com/job/github-triggered/1245/ started

https://jenkins.code.rdkcentral.com/job/github-triggered/1258/ started


Add area type icon

Area type - Software Engineering:

Area type - Security-related Software Engineering:

Known issue: if hover over an area card, I changed opacity to 10, therefore the tooltip and the info, assess icons are not really visible anymore. Maybe open another PR to fix the hover logic (maybe hover opacity to 0, keep the info and assess icons visible, and add area type icon legend somewhere)?

We should disable the hover effect completely.
The three buttons on the top right should always remain visible so that once the user clicks the eye to see the artefacts they can still see the icons.

We should disable the hover effect completely.
The three buttons on the top right should always remain visible so that once the user clicks the eye to see the artefacts they can still see the icons.

So disable the hover effect, and keep three icons always visible, only clicking on the eye icon will show the artifacts underneath?

We should disable the hover effect completely.

The three buttons on the top right should always remain visible so that once the user clicks the eye to see the artefacts they can still see the icons.

So disable the hover effect, and keep three icons always visible, only clicking on the eye icon will show the artifacts underneath? I can try to do it in this pr

Yes. Pretty much


Cannot understand how to get image_id or other info form private repository

BUG REPORT INFORMATION
Description
We use docker private repository on docker hub, when have more the 10 images.
We want to get docker images info from docker hub for able to compare builded and currently presented images on docker hub.
I try to use curl for get auth token by running commands which i find in google.
It looks like:
UNAME="exampleuser"
UPASS="examplepass"
PRODUCT="examplecompany"
REPOSITORY="$PRODUCT"
SERVICE="exampleservice"

Im try to get tokens by following ways:
TOKEN=$(curl -u $UNAME:$UPASS "https://auth.docker.io/token?service=registry.docker.io&scope=repository:$REPOSITORY:pull&account=$UNAME" | jq -r .token)

TOKEN=$(curl -u $UNAME:$UPASS "https://auth.docker.io/token?service=index.docker.io&scope=repository:$REPOSITORY:pull&account=$UNAME" | jq -r .token)

TOKEN=$(curl -u $UNAME:$UPASS "https://auth.docker.io/token?service=registry.docker.io&scope=repository:$REPOSITORY:pull&account=$UNAME&offline_token=true" | jq -r .token)

TOKEN=$(curl -u $UNAME:$UPASS "https://auth.docker.io/token?service=registry.docker.io&scope=repository:$REPOSITORY:$SERVICE:pull&account=$UNAME&offline_token=true" | jq -r .token)

TOKEN=$(curl -u $UNAME:$UPASS "https://auth.docker.io/token?service=registry.docker.io&scope=repository:$REPOSITORY:$SERVICE&account=$UNAME&offline_token=true" | jq -r .token)

In all cases i get some token, the try to get manifest from my private repository, by following ways:

REPO="$PRODUCT/$SERVICE"
TAG=latest
REGISTRY=https://registry-1.docker.io/v2

URI="$REGISTRY/$REPO/manifests/$TAG"
echo URI=$URI
MANIFEST="`curl -skL -o /dev/null -D- $URI`"
CHALLENGE="`grep "Www-Authenticate" <<<"$MANIFEST"`"
if [[ CHALLENGE ]]; then
    IFS=\" read _ REALM _ SERVICE _ SCOPE _ <<<"$CHALLENGE"
    echo REALM is $REALM
    echo SERVICE is $SERVICE
    echo SCOPE is $SCOPE
    TOKEN="`curl -skL "$REALM?service=$SERVICE&scope=$SCOPE"`"
    IFS=\" read _ _ _ TOKEN _ <<<"$TOKEN"
    echo TOKEN is $TOKEN
    MANIFEST="`curl -isk -X GET -H "Authorization: Bearer $TOKEN" $URI`"
    echo "RESPONSE is $MANIFEST"
fi

curl -s -D - -H  "Authorization: Bearer ${TOKEN}" -H "Accept: application/vnd.docker.distribution.manifest.v2+json" https://index.docker.io/v2/repositories/$PRODUCT/$SERVICE/manifests/latest

Always get
RESPONSE is HTTP/1.1 401 Unauthorized
Content-Type: application/json; charset=utf-8
Docker-Distribution-Api-Version: registry/2.0
Www-Authenticate: Bearer realm="https://auth.docker.io/token",service="registry.docker.io",scope="examplecompany/exampleservice:pull",error="insufficient_scope"
Date: Wed, 15 Mar 2017 16:15:52 GMT
Content-Length: 155
Strict-Transport-Security: max-age=31536000

{"errors":[{"code":"UNAUTHORIZED","message":"authentication required","detail":[{"Type":"repository","Class":"","Name":"examplecompany/exampleservice","Action":"pull"}]}]}

How to correct get all needed for me info from docker hub?
When i try to get tags via
REPO_LIST=$(curl -s -H "Authorization: JWT ${TOKEN}" https://hub.docker.com/v2/repositories/${PRODUCT}/?page_size=10000 | jq -r '.results|.[]|.name')

I no have a problems.
Also, i cannot find any work way for do what i want.
Steps to reproduce the issue:

Have a private images on hub.docker.com
Get Auth token
Try to get manifest info or other image info from hub.docker.com

Describe the results you received:
{"errors":[{"code":"UNAUTHORIZED","message":"authentication required","detail":[{"Type":"repository","Class":"","Name":"examplecompany/exampleservice","Action":"pull"}]}]}

Describe the results you expected:
Json which contain information of currently presented on docker hub images.

The discussion on https://github.com/docker/docker/issues/29257#issuecomment-266121974 is probably related here

Hey @westsouthnight , maybe this script can help you: https://gist.github.com/cirocosta/fb6b90cb7651ff21eda4838a73e3710b  .
It doesn't use -u to perform the basic authentication when retrieving the token but I tested with a private repository and adding -u to get_token() { indeed works: with a private registry I can retrieve the registry only if -u is used.
  curl \
    -u user:pass \
    --silent \
    "https://auth.docker.io/token?scope=repository:$image:pull&service=registry.docker.io" \
    | jq -r '.token'

Let me know if that helps 👍

Let me close this issue, as the GitHub issue tracker is not really intended as a general support forum,
but for reporting bugs and feature requests. For other type of questions, consider using one of;

https://forums.docker.com
the Docker community Slack channel (register here: http://dockr.ly/community)
StackOverflow

This question is also not directly related to the source code in this repository, but to Docker Hub (and authentication used there). But feel free to continue the conversation 👍


Requested resource could not be found

Environment details:
I'm running on Ubuntu 18.04, java 11 and Openwhisk 1.0.0.
Steps to reproduce the issue:
I followed the documents in the repo.
Build and run Openwhisk server with ./gradlew :core:standalone:bootRun.
Download wsk from https://s.apache.org/openwhisk-cli-download.
Then I set corresponding api key and auth following the CLI documentation
I tried to create an action using
wsk -v action create hello hello.js
Provide the actual results and outputs:
╰─❯ wsk -v action create hello hello.js
REQUEST:
[PUT]   http://<IP_ADDRESS>:3232/api/v1/namespaces/_/actions/hello?overwrite=false
Req Headers
{
  "Authorization": [
    "Basic MjNiYzQ2YjEtNzFmNi00ZWQ1LThjNTQtODE2YWE0ZjhjNTAyOjEyM3pPM3haQ0xyTU42djJCS0sxZFhZRnBYbFBrY2NPRnFtMTJDZEFzTWdSVTRWck5aOWx5R1ZDR3VNREdJd1A="
  ],
  "Content-Type": [
    "application/json"
  ],
  "User-Agent": [
    "OpenWhisk-CLI/1.0 (2021-04-01T23:49:54.523+0000) linux amd64"
  ]
}
Req Body
{"namespace":"_","name":"hello","exec":{"kind":"nodejs:default","code":"function main(params) {\n    var name = params.name || 'World';\n    return {payload: 'Hello, ' + name + '!'};\n}\n"}}

RESPONSE:Got response with code 404
Resp Headers
{
  "Content-Length": [
    "96"
  ],
  "Content-Type": [
    "application/json"
  ],
  "Date": [
    "Thu, 22 Apr 2021 05:51:54 GMT"
  ],
  "Server": [
    "akka-http/10.1.11"
  ],
  "X-Request-Id": [
    "3y3HpPuQMqQszy1dCB1sR86bEBwi0jww"
  ]
}
Response body size is 96 bytes
Response body received:
{"code":"3y3HpPuQMqQszy1dCB1sR86bEBwi0jww","error":"The requested resource could not be found."}
error: Unable to create action 'hello': The requested resource could not be found. (code 3y3HpPuQMqQszy1dCB1sR86bEBwi0jww)
Run 'wsk --help' for usage.

Whenever I do any other actions such as wsk api list, I get the same message.
Could anyone help me?

Check the controller logs, look for 3y3HpPuQMqQszy1dCB1sR86bEBwi0jww in the logs and see what the system error is.

[2021-04-23T10:53:28.109Z] [INFO] [#tid_0Q8EMATRbzuhUaml55cS9KQxF3jzQkFR] PUT /api/v1/namespaces/_/actions/hello overwrite=false
[2021-04-23T10:53:28.110Z] [INFO] [#tid_0Q8EMATRbzuhUaml55cS9KQxF3jzQkFR] [BasicHttpService] [marker:http_put.404_counter:1:1]

This is the server log of the wsk action create request.
Is it because I didn't specify any namespace?
(the request from playground has the namespace whisk.system.)
Also the debug log of wsk action create request is here.
Response body size is 96 bytes
Response body received:
{"code":"6jAODvczdyE86HCua75dZXbcJBXud6Qa","error":"The requested resource could not be found."}
[o/whisk.PrintResponseInfo]:536:[Inf] Response body received (ASCII quoted string):
"{\"code\":\"6jAODvczdyE86HCua75dZXbcJBXud6Qa\",\"error\":\"The requested resource could not be found.\"}"
[/whisk.parseErrorResponse]:551:[Inf] HTTP failure 404 + body
[/whisk.parseErrorResponse]:566:[Inf] HTTP failure 404; server error The requested resource could not be found. (code 6jAODvczdyE86HCua75dZXbcJBXud6Qa)
[k.(*ActionService).Insert]:230:[Err] s.client.Do() error - HTTP req http://<IP_ADDRESS>:3232/api/v1/namespaces/_/actions/hello?overwrite=false; error 'The requested resource could not be found. (code 6jAODvczdyE86HCua75dZXbcJBXud6Qa)'
[ommands.actionInsertError]:970:[Err] Client.Actions.Insert(&whisk.Action{Namespace:"_", Name:"hello", Version:"", Exec:(*whisk.Exec)(0xc00053e3f0), Annotations:whisk.KeyValueArr(nil), DelAnnotations:[]string(nil), Parameters:whisk.KeyValueArr(nil), Limits:(*whisk.Limits)(nil), Error:"", Code:0, Publish:(*bool)(nil), Updated:0}, false) error: The requested resource could not be found. (code 6jAODvczdyE86HCua75dZXbcJBXud6Qa)
[-cli/commands.ExitOnError]:1193:[Inf] err object type: *whisk.WskError
[-cli/commands.ExitOnError]:1204:[Err] Got a *whisk.WskError error: &whisk.WskError{RootErr:(*errors.errorString)(0xc000570540), ExitCode:148, DisplayMsg:true, MsgDisplayed:false, DisplayUsage:true, DisplayPrefix:true, ApplicationError:false, TimedOut:false}
error: Unable to create action 'hello': The requested resource could not be found. (code 6jAODvczdyE86HCua75dZXbcJBXud6Qa)
Run 'wsk --help' for usage.

Sorry for confusing.
It was about misconfigured apihost.


Editing variable from object to primitive value, expand arrow isn't removed

Testing https://github.com/Microsoft/vscode/issues/64003

Debug this code, set a BP on the console.log:

setInterval(() => {
    let x = { a: 1 };
    console.log(x);
}, 1000);

Expand the x object
Edit x to a primitive value like 123
x still has the expand arrow in the variables pane

The expand arrow goes away correctly in 1.29

@joaomoreno this looks like an issue with the tree.
If the element with the same ID after a refesh no longer has children the expando is left behind.
Assigning to you also if you have time to investigate.

Pretty sure it's the same as #64074, but let's see.


fix: Add images job badges to README

Why the changes were made
Have a easier way to see failed images job.
How to test the changes made
To review check https://github.com/mateusoliveira43/oadp-operator/blob/fix/images-job-badges/README.md
Check if all related repositories to OADP master branch were added.

/lgtm


Newest release update issue due to bad source code link.

I tried updating ungoogled-chromium-bin on my arch install but it gave me this error message:
==> ERROR: Failure while downloading https://github.com/ungoogled-software/ungoogled-chromium-archlinux/releases/download/125.0.6422.60-1/ungoogled-chromium-125.0.6422.60-1-x86_64.pkg.tar.zst
This piqued my curiosity and I decided to investigate the error myself. Turns out, the actual link on the releases page here on the github page is https://github.com/ungoogled-software/ungoogled-chromium-archlinux/releases/download/125.0.6422.60/ungoogled-chromium-125.0.6422.60-1-x86_64.pkg.tar.zst, while in the PKGBUILD (as shown in the error) it is https://github.com/ungoogled-software/ungoogled-chromium-archlinux/releases/download/125.0.6422.60-1/ungoogled-chromium-125.0.6422.60-1-x86_64.pkg.tar.zst
You may not notice the difference, but the link on the github releases page actually lacks the package release (125.0.6422.60) while the PKGBUILD link has the release as well (125.0.6422.60-1) meaning the links are ever so slightly different, causing the error
I hope you are able to fix this issue soon

same issue here (obviously) I'd love to see this resolved as well, thank you :)

argh sorry, got the tag name wrong. I'll push a fix

thx a lot :)

not sure if aur helpers can handle the manual fix, a build for -2 is running tho

I think I figured out the reason for this and an easy fix that doesn't involve any AUR or PKGBUILD changes.
If you go to the tags, you'll notice the latest release doesn't have the format (pkgver-pkgrel) like in the PKGBUILD, but simply (pkgver). All the previous releases have the (pkgver-pkgrel) format as their names except this one. Here's screenshots to explain what I mean:
Latest release:

The release before it:

PKGBUILD before and after:

Simply revert the PKGBUILD to what it was but add "-1" at the end of the release name on github and that should solve the issue 100% and not cause any inconsistency with previous releases


Added docs for functions in mobject_update_utils

Overview: What does this pull request change?

Added docstrings for:

:meth:always_rotate
:meth:always_shift
:meth:turn_animation_into_updater

Added typehints to above functions

Links to added or changed documentation pages

https://manimce--3325.org.readthedocs.build/en/3325/reference/manim.animation.updaters.mobject_update_utils.html

Reviewer Checklist

[ ] The PR title is descriptive enough for the changelog, and the PR is labeled correctly
[ ] If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
[ ] If applicable: newly added functions and classes are tested

@behackl done!


assertThat(String) is not touching ComparableAssert

Summary
Using assertj library I cannot check an order of strings.
Example
This is possible
assertThat(10).isBetween(9, 11);

But such a thing is impossible at the moment
assertThat("ab").isBetween("aa", "ac");

It is possible, but you have use an (ugly) cast:
assertThat((Comparable) "ab").isBetween("aa", "ac");

let's try to add isBetween to AbstratCharSequenceAssert, I think that should solve the problem.

I'm actually making StringAssert implementing ComparableAssert (can't do it for AbstractCharSequenceAssert as a CharSequence does not implement Comparable).


Load balancer using Haproxy & Varnish

Need to review test for load balancer on my local branch "proxy"
Changing :

Varnish dockerfile
Haproxy dockerfile
Change the network setup on docker-compose.yml
Add variable environment Varnish & Haproxy on env-example file

How to run?
docker-compose build && docker-compose up -d nginx mysql hhvm balancer proxy proxy2 phpmyadmin


PLT-8206 - Add GET endpoint to import contracts

This PR adds an endpoint to the Marlowe Playground to import compressed JSON contracts from other apps (in particular from Marlowe Runner). The endpoint is called importContract and takes the compressed JSON of the contract as the parameter contract.
Pre-submit checklist:

Branch

[ ] Tests are provided (if possible)
[x] Commit sequence broadly makes sense
[x] Key commits have useful messages
[x] Relevant tickets are mentioned in commit messages
[x] Formatting, materialized Nix files, PNG optimization, etc. are updated

PR

[x] Self-reviewed the diff
[x] Useful pull request description
[x] Reviewer requested

Really cool. Thanks a lot!


Fix update of statistic for LFC/prefetch

Problem
See #9199
Summary of changes
Fix update of hits/misses for LFC and prefetch introduced in https://github.com/neondatabase/neon/commit/78938d1b591b33d23495a0edb8b123cc5cac6a27
Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] If it is a core feature, I have added thorough tests.
[ ] Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
[ ] If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

[ ] Do not forget to reformat commit message to not include the above checklist

Thanks! Looks good to me as far as it goes. I haven't tested this. And we don't have any tests for these counters. It's hard to write good tests for things like this, but it'd be nice to have at least something. Currently, if EXPLAIN (PREFETCH) outright crashes, our tests wouldn't catch even that.
After these fixes, what is the difference between the getpage_prefetch_requests_total and getpage_prefetch_misses_total? If I'm reading the control-flow right, getpage_prefetch_misses + getpage_prefetch_discards_total == getpage_prefetch_requests_total.

@MMeent can better answer this question. But I think that it is not true now. getpage_prefetch_discards_total counts only pages which  prefetch requests are deteriorated (page is updates since prefetch request). But if some page is prefetched but then not access and after some times just replaced in ring buffer, then it is not considered now as discarded. May it should be considered, may be not... I think that is is separate category: unused prefetch requests.
In this case the following formula should be true:
getpage_prefetch_misses + getpage_prefetch_discards_total + getpage_prefetch_unused_total + getpage_prefetch_discards_total == getpage_prefetch_requests_total


Inpage QMAL doesn't work when there is only 1 anime result in DB

When the request to MyAnimeList returned only 1 anime, the script doesn't work and displays an "undefined : undefined" in the anime name box in inpage QMAL.

Fixed.


Digital Twin Registry Release 23.12 Compliance Acceptance Criteria

Release Compliance 23.12
Source in Catena-X Confluence + Expert Contacts here. (Source only accessible for Catena-X Consortia members in current transition phase)

[x] Gaia-X compliance confirmed by dedicated expert.

Obtain approval from CX Gaia-X expert(s), prior to Gate review.
Provide info as early as possible; expect optimization loops based on feedback
=> check linked PDF summary for requirements (Source only accessible for Catena-X Consortia members in current transition phase).

Contact:

Release Mangement

[x] GDPR compliance confirmed
(personal data; Data Protection & Privacy DPP)

assessment must be completed via Catena-X GDPR questionnaire (Source only accessible for Catena-X Consortia members in current transition phase.)
either the product/service doesn`t process any relevant data,
or - in case the assessment reveals potential issues - a more severe "Data Privacy Impact Assessment" shall be conducted (if applicable: robust mitigation actions must be completed)
Provide evidence for GDPR compliance prior to Gate review. Previous assessments remain valid, as long as approach to handling of personal data was not changed.

Contact:

Release Mangement

[ ] Interoperability Check
Acceptance criteria are fulfilled as described in in the following area on confluence: Interoperability Quality Gate Requirements (Source only accessible for Catena-X Consortia members in current transition phase.)

Approval will be documented centrally by Expert(s)

Obtain approval from Interoperability experts prior to Gate review.

Therefore consult the regular office hours as early as possible; expect optimization loops based on feedback. (Source only accessible for Catena-X Consortia members in current transition phase.)
Contact:

SYSTEM ARCHITECT2

[ ] Data Sovereignty Check
Acceptance criteria are fulfilled as described in in the following area on confluence:

Data Sovereignty Guardrails for Release 3.2 (Source only accessible for Catena-X Consortia members in current transition phase.)
Approval will be documented centrally by Expert(s)
Obtain approval from Data Sovereignty experts prior to Gate review: Experts will schedule a review with your team.

Expect optimization loops based on feedback.
Contact:

SYSTEM ARCHITECT3,
SYSTEM ARCHITECT4

[x] Confirmation of published CX Standards
Product Owner confirms:

The FOSS product under review is compliant to all relevant Catena-X Standards which are already published on the Association website.
Failure to do so may ultimately make the reference implementation useless, as the mandatory CX Certification cannot be accomplished.

[x] Verification of foreseen CX Standards
Product Owner confirms:

The content of upcoming CX Standardization Requests (STAN) has been reviewed and feedback was provided to the responsible PCA/BDA. As per current status, the FOSS product under review will be compliant as soon as the CX Standard is published. (Info here) (Source only accessible for Catena-X Consortia members in current transition phase.)
Minimum: PCA/BDA have finalized all release-relevant Standardization Requests (STAN). Those have passed the CX Association`s technical committee (TC4S) and are pre-published on the website. Opt-out period in progress.
Best case: Association Board approval available and CX Standard is published on website.

Release Mangement

[ ] **Gaia-X compliance **:
No changes since Release 23.09.
Gaia-X compliance is not relevant for the decentral Digital Twin Registry.

Release Mangement

[ ] GDPR compliance:
No changes since Release 23.09.
Catena-X GDPR Declaration and Requirements_V23.12_DTR.xlsx

SYSTEM ARCHITECT2

[ ] Interoperability Check:
Interoperability was ensured to Release 23.09. Since then no changes have been made.

Confirmation of published CX Standards
Yes, confirmation that the Digital Twin Registry under review is compliant to all relevant Catena-X Standards which are already published on the Association website, especially the CX-0002.

Verification of foreseen CX Standards
Yes, confirmation that the content of upcoming CX Standardization Requests (STAN) has been reviewed and feedback was provided to the responsible PCA/BDA. As per current status, the Digital Twin Registry under review will be compliant as soon as the CX Standard is published. (Info here) (Source only accessible for Catena-X Consortia members in current transition phase.)

Hi @kelaja,
for the points:

Interoperability Check
Data Sovereignty Check
Confirmation of published CX Standards
Verification of foreseen CX Standards

The Expert is not defined / Expert Github account is not known, pls forward to expert. Many thanks!

Hi @bs-sili
Interoperability Check -> @HiHenrik
Data Sovereignty Check -> tbd
Confirmation of published CX Standards -> self assessed, thx @thomas-henn
Verification of foreseen CX Standards -> self assessed, thx @thomas-henn

@kelaja
Data Sovereignty Check has been updated.

@kelaja
Interoperability Check:
Acceptance criteria are fulfilled as described in in the following area on confluence:
https://confluence.catena-x.net/display/PL/Interoperability+Office+Hours+Backlog+-+QGate+Prep


[FEATURE] Automatically attach the volumes for trimming filesystem

Is your feature request related to a problem? Please describe (👍 if you like this request)
Shuo Wu
Now Longhorn will automatically attach the volumes for backup and snapshot related jobs if necessary. But yes, it's not applied to trim jobs.

https://rancher-users.slack.com/archives/CC2UQM49Y/p1716456195612299
Describe the solution you'd like

Describe alternatives you've considered

Additional context

cc @shuo-wu


add UCv3 commerce frame-src hosts for free trial

requested by the DC Web team @ladutko and @gyeung

Codecov Report

Merging #340 (9505642) into stage (6a1dbd5) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            stage     #340      +/-   ##
==========================================
+ Coverage   94.21%   94.29%   +0.08%
==========================================
  Files          26       26
  Lines        2646     2649       +3
==========================================
+ Hits         2493     2498       +5
+ Misses        153      151       -2

Files Changed
Coverage Δ

acrobat/scripts/contentSecurityPolicy/dev.js
100.00% <100.00%> (ø)

acrobat/scripts/contentSecurityPolicy/prod.js
100.00% <100.00%> (ø)

acrobat/scripts/contentSecurityPolicy/stage.js
100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Crash after navigating to another fragment and navigating up (back) using the android Navigation component.

There is a crash when I navigate to another fragment and then navigate back to the stepper. I am using android Navigation component.
at ernestoyaquello.com.verticalstepperform.VerticalStepperFormView.restoreFromState(VerticalStepperFormView.java:1069)

Something goes wrong in this line in the VerticalStepperFormView.java file:

I am afraid this is likely happening because of your specific configuration and not because of a problem in the library, as I just verified that the library works when used with the navigation component. I have tested a few cases:

Navigating to a fragment with the form.
Navigating from a fragment with the form before the form is completed.
Navigating from a fragment with the form after the form is completed.

Judging by your error, there is something wrong with the restoration, but I am not sure what that could be. Would you mind attaching here a sample app where the error is reproducible? It would be very helpful.

I'm gonna send a sample application, thanks.

Given that I couldn't reproduce the problem and that there has been no activity here for a while, I will now close this issue. Please feel free to send the sample application if you are still interested!


[FEATURE] Implement Disk gRPC Service in Instance Manager for collecting SPDK disk statistics from SPDK gRPC service

Is your feature request related to a problem? Please describe (👍 if you like this request)
According to the design and discussion with @shuo-wu, we need to implement a Disk gRPC Service in Instance Manager for

Collecting SPDK disk (lvstore) statistics from SPDK gRPC service
Requesting to create a lvstore
...

node controller -> disk monitor -> disk service -> spdk service

Describe the solution you'd like
A clear and concise description of what you want to happen
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

cc @shuo-wu

Hi @derekbit ,
I tested with SLES ami-0dd7f664cbd69840b, following instructions the environment check script passed, but when I try attach a SPDK volume to a node, the volume stuck at attaching status (no matter created from UI or dynamic provision) .

Environment check result
ip-172-31-88-0:/home/ec2-user # bash -c "$(curl -sfL https://raw.githubusercontent.com/longhorn/longhorn/master/scripts/environment_check.sh)" -s -s
[INFO]  Required dependencies 'kubectl jq mktemp' are installed.
[INFO]  All nodes have unique hostnames.
[INFO]  Waiting for longhorn-environment-check pods to become ready (0/3)...
[INFO]  All longhorn-environment-check pods are ready (3/3).
[INFO]  MountPropagation is enabled
[INFO]  Checking iscsid...
[INFO]  Checking multipathd...
[INFO]  Checking packages...
[INFO]  Checking nfs client...
[INFO]  Checking x86-64 SSE4.2 instruction set...
[INFO]  Checking nvme-cli...
[INFO]  Checking kernel module nvme_tcp...
[INFO]  Checking kernel module uio_pci_generic...
[INFO]  Checking hugepage...
[INFO]  Cleaning up longhorn-environment-check pods...
[INFO]  Cleanup completed.

Longhorn SPDK setting
k get setting -A | grep spdk
longhorn-system   spdk-hugepage-limit                                               1024                                               24m
longhorn-system   spdk                                                              true                                               24m

Longhorn manager log, can see many error occured
ip-172-31-88-0:/home/ec2-user # k logs longhorn-manager-9k6m7 -n longhorn-system | grep error
time="2023-06-05T09:57:22Z" level=warning msg="Error getting webhook health endpoint https://localhost:9501/v1/healthz" error="Get \"https://localhost:9501/v1/healthz\": dial tcp [::1]:9501: connect: connection refused"
time="2023-06-05T09:57:24Z" level=warning msg="Error getting webhook health endpoint https://localhost:9502/v1/healthz" error="Get \"https://localhost:9502/v1/healthz\": dial tcp [::1]:9502: connect: connection refused"
time="2023-06-05T09:57:26Z" level=warning msg="Error getting webhook health endpoint https://localhost:9502/v1/healthz" error="Get \"https://localhost:9502/v1/healthz\": dial tcp [::1]:9502: connect: connection refused"
time="2023-06-05T09:57:31Z" level=warning msg="Failed to create disk service client" error="failed to get disk service client:  instance manager is in , not running state"
time="2023-06-05T09:57:31Z" level=warning msg="Failed to clean up all mount points" controller=longhorn-backup-target cred= error="failed to get engine client proxy:  instance manager is in , not running state" interval=5m0s node=ip-172-31-83-231 url=
time="2023-06-05T09:58:00Z" level=warning msg="Failed to clean up all mount points" controller=longhorn-backup-target cred= error="failed to get engine client proxy: instance-manager-7cd0221ec45a716ed204c7b2d346952a instance manager is in starting, not running state" interval=5m0s node=ip-172-31-83-231 url=
time="2023-06-05T09:58:01Z" level=warning msg="Failed to create disk service client" error="failed to get disk service client: instance-manager-7cd0221ec45a716ed204c7b2d346952a instance manager is in starting, not running state"
time="2023-06-05T10:00:24Z" level=info msg="Instance manager state is updated from running to error after syncing with the pod" controller=longhorn-instance-manager instanceManager=instance-manager-7cd0221ec45a716ed204c7b2d346952a node=ip-172-31-83-231 nodeID=ip-172-31-83-231
time="2023-06-05T10:00:24Z" level=error msg="Failed to receive next item in instance watch" controller=longhorn-instance-manager error="rpc error: code = Canceled desc = context canceled" instance manager=instance-manager-7cd0221ec45a716ed204c7b2d346952a node=ip-172-31-83-231
time="2023-06-05T10:00:25Z" level=info msg="Instance manager state is updated from error to starting after syncing with the pod" controller=longhorn-instance-manager instanceManager=instance-manager-7cd0221ec45a716ed204c7b2d346952a node=ip-172-31-83-231 nodeID=ip-172-31-83-231
}. Err: connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:8500: connect: connection refused"
time="2023-06-05T10:00:25Z" level=error msg="Failed to sync Longhorn instance manager longhorn-system/instance-manager-7cd0221ec45a716ed204c7b2d346952a" error="failed to sync instance manager for longhorn-system/instance-manager-7cd0221ec45a716ed204c7b2d346952a: failed to get Version of Instance Manager Process Manager Service Client for instance-manager-7cd0221ec45a716ed204c7b2d346952a, state: running, IP: <IP_ADDRESS>, TLS: false: failed to get version: rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing: dial tcp <IP_ADDRESS>:8500: connect: connection refused\""
}. Err: connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:8500: connect: connection refused"
time="2023-06-05T10:00:25Z" level=error msg="Failed to sync Longhorn instance manager longhorn-system/instance-manager-7cd0221ec45a716ed204c7b2d346952a" error="failed to sync instance manager for longhorn-system/instance-manager-7cd0221ec45a716ed204c7b2d346952a: failed to get Version of Instance Manager Process Manager Service Client for instance-manager-7cd0221ec45a716ed204c7b2d346952a, state: running, IP: <IP_ADDRESS>, TLS: false: failed to get version: rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing: dial tcp <IP_ADDRESS>:8500: connect: connection refused\""
}. Err: connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:8500: connect: connection refused"
time="2023-06-05T10:00:25Z" level=error msg="Failed to sync Longhorn instance manager longhorn-system/instance-manager-7cd0221ec45a716ed204c7b2d346952a" error="failed to sync instance manager for longhorn-system/instance-manager-7cd0221ec45a716ed204c7b2d346952a: failed to get Version of Instance Manager Process Manager Service Client for instance-manager-7cd0221ec45a716ed204c7b2d346952a, state: running, IP: <IP_ADDRESS>, TLS: false: failed to get version: rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing: dial tcp <IP_ADDRESS>:8500: connect: connection refused\""
}. Err: connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:8500: connect: connection refused"
E0605 10:00:25.783198       1 instance_manager_controller.go:257] failed to sync instance manager for longhorn-system/instance-manager-7cd0221ec45a716ed204c7b2d346952a: failed to get Version of Instance Manager Process Manager Service Client for instance-manager-7cd0221ec45a716ed204c7b2d346952a, state: running, IP: <IP_ADDRESS>, TLS: false: failed to get version: rpc error: code = Unavailable desc = connection error: desc = "transport: Error while dialing: dial tcp <IP_ADDRESS>:8500: connect: connection refused"
time="2023-06-05T10:00:25Z" level=error msg="Dropping Longhorn instance manager longhorn-system/instance-manager-7cd0221ec45a716ed204c7b2d346952a out of the queue" error="failed to sync instance manager for longhorn-system/instance-manager-7cd0221ec45a716ed204c7b2d346952a: failed to get Version of Instance Manager Process Manager Service Client for instance-manager-7cd0221ec45a716ed204c7b2d346952a, state: running, IP: <IP_ADDRESS>, TLS: false: failed to get version: rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing: dial tcp <IP_ADDRESS>:8500: connect: connection refused\""
time="2023-06-05T10:00:30Z" level=warning msg="Failed to clean up all mount points" controller=longhorn-backup-target cred= error="failed to get engine client proxy: instance-manager-7cd0221ec45a716ed204c7b2d346952a instance manager is in starting, not running state" interval=5m0s node=ip-172-31-83-231 url=
time="2023-06-05T10:03:22Z" level=error msg="Error syncing Longhorn engine" controller=longhorn-engine engine=longhorn-system/vol1-e-3b39f903 error="failed to sync engine for longhorn-system/vol1-e-3b39f903: failed to create instance: rpc error: code = Unknown desc = failed to start SPDK engine: rpc error: code = Unknown desc = failed to load device info after starting NVMe initiator vol1: cannot find a valid nvme device with subsystem NQN nqn.2023-01.io.longhorn.spdk:vol1-e-3b39f903 and address :" node=ip-172-31-83-231
time="2023-06-05T10:03:22Z" level=info msg="Event(v1.ObjectReference{Kind:\"Engine\", Namespace:\"longhorn-system\", Name:\"vol1-e-3b39f903\", UID:\"b3685278-dd31-4f78-9e2f-82aefb7e9ad8\", APIVersion:\"longhorn.io/v1beta2\", ResourceVersion:\"2412\", FieldPath:\"\"}): type: 'Warning' reason: 'FailedStarting' Error starting vol1-e-3b39f903: failed to create instance: rpc error: code = Unknown desc = failed to start SPDK engine: rpc error: code = Unknown desc = failed to load device info after starting NVMe initiator vol1: cannot find a valid nvme device with subsystem NQN nqn.2023-01.io.longhorn.spdk:vol1-e-3b39f903 and address :"
time="2023-06-05T10:03:23Z" level=warning msg="Instance vol1-e-3b39f903 is state error, error message: "
time="2023-06-05T10:07:13Z" level=debug msg="2023/06/05 10:07:13 http: TLS handshake error from <IP_ADDRESS>:48274: EOF"
time="2023-06-05T10:08:12Z" level=debug msg="Requeue volume due to error <nil> or Operation cannot be fulfilled on replicas.longhorn.io \"pvc-acee54a0-638c-45b5-9a99-df8645103e26-r-89ce02c8\": the object has been modified; please apply your changes to the latest version and try again" accessMode=rwo controller=longhorn-volume frontend=blockdev migratable=false node=ip-172-31-83-231 owner= state= volume=pvc-acee54a0-638c-45b5-9a99-df8645103e26
time="2023-06-05T10:08:32Z" level=error msg="Error syncing Longhorn engine" controller=longhorn-engine engine=longhorn-system/pvc-acee54a0-638c-45b5-9a99-df8645103e26-e-b8884686 error="failed to sync engine for longhorn-system/pvc-acee54a0-638c-45b5-9a99-df8645103e26-e-b8884686: failed to create instance: rpc error: code = Unknown desc = failed to start SPDK engine: rpc error: code = Unknown desc = failed to start NVMe initiator pvc-acee54a0-638c-45b5-9a99-df8645103e26 within 5 * 3sec retrys" node=ip-172-31-83-231
time="2023-06-05T10:08:32Z" level=info msg="Event(v1.ObjectReference{Kind:\"Engine\", Namespace:\"longhorn-system\", Name:\"pvc-acee54a0-638c-45b5-9a99-df8645103e26-e-b8884686\", UID:\"148564a2-ee0a-40d7-9e1a-cfc1ed495b35\", APIVersion:\"longhorn.io/v1beta2\", ResourceVersion:\"3009\", FieldPath:\"\"}): type: 'Warning' reason: 'FailedStarting' Error starting pvc-acee54a0-638c-45b5-9a99-df8645103e26-e-b8884686: failed to create instance: rpc error: code = Unknown desc = failed to start SPDK engine: rpc error: code = Unknown desc = failed to start NVMe initiator pvc-acee54a0-638c-45b5-9a99-df8645103e26 within 5 * 3sec retrys"
time="2023-06-05T10:08:33Z" level=warning msg="Instance pvc-acee54a0-638c-45b5-9a99-df8645103e26-e-b8884686 is state error, error message: "
time="2023-06-05T10:13:51Z" level=debug msg="2023/06/05 10:13:51 http: TLS handshake error from <IP_ADDRESS>:56444: EOF"
time="2023-06-05T10:14:40Z" level=debug msg="Requeue volume due to error <nil> or Operation cannot be fulfilled on replicas.longhorn.io \"pvc-60b61df9-cbdb-4893-8445-6e4c5a29644b-r-a2ea6f50\": the object has been modified; please apply your changes to the latest version and try again" accessMode=rwo controller=longhorn-volume frontend=blockdev migratable=false node=ip-172-31-83-231 owner= state= volume=pvc-60b61df9-cbdb-4893-8445-6e4c5a29644b
time="2023-06-05T10:15:01Z" level=error msg="Error syncing Longhorn engine" controller=longhorn-engine engine=longhorn-system/pvc-60b61df9-cbdb-4893-8445-6e4c5a29644b-e-e5d88338 error="failed to sync engine for longhorn-system/pvc-60b61df9-cbdb-4893-8445-6e4c5a29644b-e-e5d88338: failed to create instance: rpc error: code = Unknown desc = failed to start SPDK engine: rpc error: code = Unknown desc = failed to start NVMe initiator pvc-60b61df9-cbdb-4893-8445-6e4c5a29644b within 5 * 3sec retrys" node=ip-172-31-83-231
time="2023-06-05T10:15:01Z" level=info msg="Event(v1.ObjectReference{Kind:\"Engine\", Namespace:\"longhorn-system\", Name:\"pvc-60b61df9-cbdb-4893-8445-6e4c5a29644b-e-e5d88338\", UID:\"2b58837b-02ce-4a14-bef3-d456d63bbe88\", APIVersion:\"longhorn.io/v1beta2\", ResourceVersion:\"3803\", FieldPath:\"\"}): type: 'Warning' reason: 'FailedStarting' Error starting pvc-60b61df9-cbdb-4893-8445-6e4c5a29644b-e-e5d88338: failed to create instance: rpc error: code = Unknown desc = failed to start SPDK engine: rpc error: code = Unknown desc = failed to start NVMe initiator pvc-60b61df9-cbdb-4893-8445-6e4c5a29644b within 5 * 3sec retrys"
time="2023-06-05T10:15:02Z" level=warning msg="Instance pvc-60b61df9-cbdb-4893-8445-6e4c5a29644b-e-e5d88338 is state error, error message: "

supportbundle_1433d744-ea58-470a-8504-cae8289b47d5_2023-06-05T10-16-04Z.zip
So far I tested on Ubuntu 22.04 ami-053b0d53c279acc90, the,volume lifecycle (creation, attachment, detachment and deletion), degraded volume, block disk management worked well, only orphaned replica management not tested yet, thank you.

nvme-cli in ubuntu 22.04 is v1.x, and v2.x in SLES. The outputs of nvme list -v -o json are different...
We follow v1.x's format. The error is due to a parsing error.
@innobead @shuo-wu any idea for this isse?

v1.1.x

./nvme list -v -o json
libhugetlbfs: ERROR: Line too long when parsing mounts
{
  "Devices" : [
    {
      "Subsystem" : "nvme-subsys0",
      "SubsystemNQN" : "nqn.2023-01.io.longhorn.spdk:pvc-5a6abf13-b225-4cef-825c-27a690143274-e-b0352c83",
      "Controllers" : [
        {
          "Controller" : "nvme0",
          "Transport" : "tcp",
          "Address" : "traddr=<IP_ADDRESS> trsvcid=20006",
          "State" : "live",
          "HostNQN" : "nqn.2014-08.org.nvmexpress:uuid:ec28c0e7-2793-565d-9c2f-02d2c5b24dee",
          "HostID" : "aac8e3b4-fcdd-4645-a976-f754f969e4e6",
          "Firmware" : "23.05",
          "ModelNumber" : "SPDK bdev Controller",
          "SerialNumber" : "00000000000000000000",
          "Namespaces" : [
            {
              "NameSpace" : "nvme0c0n1",
              "NSID" : 1,
              "UsedBytes" : 0,
              "MaximumLBA" : 0,
              "PhysicalSize" : 0,
              "SectorSize" : 1
            }
          ]
        }
      ],
      "Namespaces" : [
        {
          "NameSpace" : "nvme0n1",
          "NSID" : 1,
          "UsedBytes" :<PHONE_NUMBER>,
          "MaximumLBA" : 524288,
          "PhysicalSize" :<PHONE_NUMBER>,
          "SectorSize" : 4096
        }
      ]
    }
  ]
}

v2.x

derek-sles-pool1-7ab2cea3-bvtvc:/home/ec2-user # nvme list -v -o json
libhugetlbfs: ERROR: Line too long when parsing mounts
{
  "Devices":[
    {
      "HostNQN":"nqn.2014-08.org.nvmexpress:uuid:ec28c0e7-2793-565d-9c2f-02d2c5b24dee",
      "HostID":"aac8e3b4-fcdd-4645-a976-f754f969e4e6",
      "Subsystems":[
        {
          "Subsystem":"nvme-subsys0",
          "SubsystemNQN":"nqn.2023-01.io.longhorn.spdk:pvc-5a6abf13-b225-4cef-825c-27a690143274-e-b0352c83",
          "Controllers":[
            {
              "Controller":"nvme0",
              "SerialNumber":"00000000000000000000",
              "ModelNumber":"SPDK bdev Controller",
              "Firmware":"23.05",
              "Transport":"tcp",
              "Address":"traddr=<IP_ADDRESS>,trsvcid=20006",
              "Namespaces":[
              ],
              "Paths":[
                {
                  "Path":"nvme0c0n1",
                  "ANAState":"optimized"
                }
              ]
            }
          ],
          "Namespaces":[
            {
              "NameSpace":"nvme0n1",
              "NSID":1,
              "UsedBytes":-2147483648,
              "MaximumLBA":524288,
              "PhysicalSize":-2147483648,
              "SectorSize":4096
            }
          ]
        }
      ]
    }
  ]
}

Just found that we should not add -v (verbose) option, but the output of v2.x is pretty weird...

v1.x

derek-sles-pool1-7ab2cea3-bvtvc:/home/ec2-user/nvme-cli # ./nvme list -o json
libhugetlbfs: ERROR: Line too long when parsing mounts
{
  "Devices" : [
    {
      "NameSpace" : 1,
      "DevicePath" : "/dev/nvme0n1",
      "Firmware" : "23.05",
      "Index" : 0,
      "ModelNumber" : "SPDK bdev Controller",
      "SerialNumber" : "00000000000000000000",
      "UsedBytes" :<PHONE_NUMBER>,
      "MaximumLBA" : 524288,
      "PhysicalSize" :<PHONE_NUMBER>,
      "SectorSize" : 4096
    }
  ]
}

v2.x

# nvme list -o json
libhugetlbfs: ERROR: Line too long when parsing mounts
{
  "Devices":[
    {
      "NameSpace":1,
      "DevicePath":"/dev/nvme0n1",
      "Firmware":"23.05",
      "ModelNumber":"SPDK bdev Controller",
      "SerialNumber":"00000000000000000000",
      "UsedBytes":-2147483648,
      "MaximumLBA":524288,
      "PhysicalSize":-2147483648,
      "SectorSize":4096
    }
  ]
}

Can we install nvmcli v1 on SLES instead?

Can we install nvmcli v1 on SLES instead?

Yes, users can compile and install nvme-cli by themselves only support v1?
If yes, there is a breaking change. Not confident with v2.x when saw the weird numbers in the output...

Can we install nvmcli v1 on SLES instead? v1 vs v2 seem breaking changes.

Yes, users can compile and install nvme-cli v1 by themselves.
There is a breaking change. Not confident with v2.x when saw the weird numbers in the output...

Is it possible to install nvmcli in the instance manager image instead of relying on the host? Do we have similar concerns like iscsiadm?

Is it possible to install nvmecli in the instance manager image instead of relying on the host? Do we have similar concerns like iscsiadm?

@shuo-wu Do you have any concern?

P.S. Just noticed from nvmecli v2 separates the code to app/CLI and https://github.com/linux-nvme/libnvme, so will the static binding to the lib in our SPDK go lib be an option in the future? then we don't need to rely on the host dependency?

Does libnvme still have a similar issue if we still use the lib/util in the host namespace?

Update test result
Environment:

Ubuntu 22.04
v1.27.2+k3s1
longhorn master (longhorn fa04ba, longhorn-manager 73dab7)
SPDK setup steps

Below function worked properly without problem

[x] Volume life cycle (creation, attachment, detachment and deletion)
[x] Degraded volume.
[x] Block disk management
[x] Orphaned replica management

For the nvme-cli breaking change issue, I think we can only support nvme-cli v1.x for now.
We can investigate the two methods later

Can the issue be resolved by libnvme?
Can spdk_tgt be in IM pod?

WDYT? @innobead @shuo-wu

Hi @derekbit ,
In Red Hat 8 (ami-035782eed0f5ba992), nvme vervion=1.16, also encountered the attaching stuck situation. Thank you.
[root@ip-172-31-93-135 ec2-user]# cat /etc/*-release
NAME="Red Hat Enterprise Linux"
VERSION="8.8 (Ootpa)"
ID="rhel"
ID_LIKE="fedora"
VERSION_ID="8.8"
PLATFORM_ID="platform:el8"
PRETTY_NAME="Red Hat Enterprise Linux 8.8 (Ootpa)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:8::baseos"
HOME_URL="https://www.redhat.com/"
DOCUMENTATION_URL="https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8"
BUG_REPORT_URL="https://bugzilla.redhat.com/"

REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 8"
REDHAT_BUGZILLA_PRODUCT_VERSION=8.8
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="8.8"
Red Hat Enterprise Linux release 8.8 (Ootpa)
Red Hat Enterprise Linux release 8.8 (Ootpa)
[root@ip-172-31-93-135 ec2-user]# nvme version
nvme version 1.16

supportbundle_e02bcfe8-bfdd-4720-91b3-514e6c07acf8_2023-06-07T08-30-07Z.zip

Hi @derekbit ,
In Red Hat 8 (ami-035782eed0f5ba992), nvme vervion=1.16, also encountered the attaching stuck situation. Thank you.
[root@ip-172-31-93-135 ec2-user]# cat /etc/*-release
NAME="Red Hat Enterprise Linux"
VERSION="8.8 (Ootpa)"
ID="rhel"
ID_LIKE="fedora"
VERSION_ID="8.8"
PLATFORM_ID="platform:el8"
PRETTY_NAME="Red Hat Enterprise Linux 8.8 (Ootpa)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:8::baseos"
HOME_URL="https://www.redhat.com/"
DOCUMENTATION_URL="https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/8"
BUG_REPORT_URL="https://bugzilla.redhat.com/"

REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 8"
REDHAT_BUGZILLA_PRODUCT_VERSION=8.8
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="8.8"
Red Hat Enterprise Linux release 8.8 (Ootpa)
Red Hat Enterprise Linux release 8.8 (Ootpa)
[root@ip-172-31-93-135 ec2-user]# nvme version
nvme version 1.16

supportbundle_e02bcfe8-bfdd-4720-91b3-514e6c07acf8_2023-06-07T08-30-07Z.zip

For the RHEL case, the output is different, although we use nvme-cli v1.16.
We shall not use -v (verbose) for this command.
# nvme list -v -o json
{
  "Devices" : [
    {
      "Subsystem" : "nvme-subsys0",
      "SubsystemNQN" : "nqn.2023-01.io.longhorn.spdk:pvc-ad369a37-47e6-44aa-b9b8-0f87467bcd42-e-5d6614be",
      "Controllers" : [
        {
          "Controller" : "nvme0",
          "Transport" : "tcp",
          "Address" : "traddr=<IP_ADDRESS> trsvcid=20001",
          "State" : "live",
          "HostNQN" : "nqn.2014-08.org.nvmexpress:uuid:ec2e13a1-4269-0624-9a71-2782f4d4f550",
          "HostID" : "6cb1d726-42f1-4476-a460-630f28116480",
          "Firmware" : "23.05",
          "ModelNumber" : "SPDK bdev Controller",
          "SerialNumber" : "00000000000000000000",
          "Namespaces" : [
            {
              "NameSpace" : "nvme0n1",
              "NSID" : 1,
              "UsedBytes" :<PHONE_NUMBER>,
              "MaximumLBA" : 524288,
              "PhysicalSize" :<PHONE_NUMBER>,
              "SectorSize" : 4096
            }
          ]
        }
      ]
    }
  ]
}

cc @shuo-wu

I see, the main difference is about the namespace part... Annoying... We can do some adjustment for the parsing but I am not sure if there are more differences from other distro/versions

Yes, annoying.
I've tried nvme list -o json and nvme list-subsys <device> -o json. The results look consistent across nvme-cli v1.12-v1.16.

I see, the main difference is about the namespace part... Annoying... We can do some adjustment for the parsing but I am not sure if there are more differences from other distro/versions

Yes, annoying. I've tried nvme list -o json and nvme list-subsys <device> -o json. The results look consistent across nvme-cli v1.12-v1.16. Not sure if there are more differences from other distros yet.

I can try this way first. WDYT? @innobead @shuo-wu

Sure. If the JSON format output is consistent, let's do try this first.

@derekbit It seems all fixed here, let's move this to ready-for-testing again to let @chriscchien finish the testing. Thanks.

@chriscchien Please help check it again. Thank you.


Page scrolling does not work

Steps to reproduce:

go to https://microsoft.github.io/monaco-editor/;
hover over the editor;
try to scroll the page down;
it is not possible.

It will be nice if after the scroll bar reached the bottom (or the top) of the editor then a page scroll bar is used.

I think that would be the natural behavior if the event was propagated.
Compare e.g. with the scolling behavior here https://codemirror.net/demo/complete.html

Dup of #69 which just got fixed.


Fix silly typo in readme

In reads that end with a whim,
A typo fixed, a happy sight,
Corrections made, a happy land,
Words' embrace in a happy space.


Fix: Update column width calculation

Old method: compared row.length to previous largest row size, and replace if larger.
New method: accounts for non-string rows by calling row.toString() for non-null rows. Now, if a cell has non-string contents, it won't compare undefined, but the actual length.
Other fixes:

bumps the extra padding from 10 -> 12. Even with the new calculations, "North Highlands" rows were still getting weirdly displayed (probably a variable-width font issue).
moves TableCreator node into the io category.

Works great on the NFL data with all its missing values as well!


Design Document of kube-mesos-framework refactor.

Provide the design document for kube-mesos-framework refactor project.

Update the design doc address, I'm still working on it :). Please feel free to share your ideas if any.


lnav: add prql support

Added PRQL support for lnav.
PRQL support was introduced recently and for recent builds you would get a
✘ error: PRQL is not supported in this build

when you tried querying.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[X] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[X] (Package updates) Added a release notes entry if the change is major or breaking
[X] (Module updates) Added a release notes entry if the change is significant
[X] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

@ofBorg eval
You need to rebase btw., the package has been moved to by-name.

Thanks for the support Atemu!

How would I verify whether prql support works?

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 349284

x86_64-linux

:white_check_mark: 2 packages built:

lnav
lnav.debug

You can execute a PRQL query using the existing database prompt (press ;). A query is interpreted as PRQL if it starts with the from keyword. After from, the database table should be provided. The table for the focused log message will be suggested by default. You can accept the suggestion by pressing TAB. To add a new stage to the pipeline, enter a pipe symbol (|), followed by a PRQL transform and its arguments. In addition to the standard set of transforms, lnav provides some convenience transforms in the stats and utils namespaces. For example, stats.count_by can be passed one or more column names to group by and count, with the result sorted by most to least.

https://lnav.org/2024/03/29/prql-support.html
In a version with no support you get
✘ error: PRQL is not supported in this build

Fixed.

It still does not build.
error: builder for '/nix/store/1ji2immm5l9mfn19fr4y04qfq01yds6c-cargo-deps-vendor-staging.drv' failed with exit code 1;
       last 2 log lines:
       > Running phase: unpackPhase
       > variable $src or $srcs should point to the source
       For full logs, run 'nix-store -l /nix/store/1ji2immm5l9mfn19fr4y04qfq01yds6c-cargo-deps-vendor-staging.drv'

Fixes output derivation are never rebuilt unless their name or their hash changes. Notably build instructions can change without invalidating the cache. This is because this way you can fetch sources manually in whatever way you see fit even if the original source has long disappeared from the internet.

btw if seems that you force pushed commits identical to what they were before, maybe you forgot to git add?

sorry, bad rebasing

This smells like an old SDK issue. The fix would therefore likely be to require a newer SDK. The mechanisms to implement this changed recently, so please look that up.

Does bumping the sdk mean that we cannot backport this PR to 24.11 as it's a breaking change (and we should only backport the commit making gpm optional)?

I don't think we should backport this in any case.

@ofborg build lnav

x86_64-darwin appears to still be broken. Could you just test this locally via pkgsx86_64Darwin until it works?

I guess it's clang 19 problem so it should fail on aarch64-darwin too.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 349284

x86_64-darwin

:x: 1 package failed to build:

lnav

aarch64-darwin

:white_check_mark: 1 package built:

lnav

Thanks @ofalvai!
I did run into another problem trying to cross-compile locally but I'm not confident in my ability to do that.
Used nix-build -A pkgsCross.x86_64-darwin.lnav
Got a ld: symbol(s) not found for architecture arm64 for the rustc dep.
https://gist.github.com/pcasaretto/b8dfb811586ca03999964734cb300f3e

I'm not sure cross-compilation fully works between two Darwin archs, but you can use Rosetta for testing with the --system x86_64-darwin flag

You can also use pkgsx86_64Darwin btw.


Svelte - Receiving diagnostic message for reactive statements

Check for existing issues

[X] Completed

Describe the bug / provide steps to reproduce it
I'm using a package that enables custom reactive statements that use the syntax $m:  instead of svelte's $: . For example:
<script>
  // other code here
  $m: todos = Todos.find().fetch()
</script>

{#each todos as todo (todo._id)}
  <Todo {todo} />
{/each}

I see the diagnostic message "Could not find name 'todos'. Did you mean 'Todos'?"
Is there a way to prevent this diagnostic message from displaying since the syntax is valid?
Environment
Zed: v0.96.3 (stable)
OS: macOS 13.2.1
Memory: 16 GiB
Architecture: aarch64
If applicable, add mockups / screenshots to help explain present your vision of the feature
No response
If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.
No response

@mikayla-maki Thanks for adding svelte support! Do you know of anything I can do on my end to resolve this issue? Maybe something in Zed settings? If not, can I provide a bribe to add a fix to Zed? :) I'm sure it's probably not a top priority but would greatly appreciate you taking a look.

Hi Jamauro, thanks for the laugh :)
What package are you using? And do you have a code snippet / repo I could use to reproduce the issue?

Here's a quick repro: https://github.com/jamauro/zed-repro
I'm using https://github.com/zodern/melte. Here's some more info on the custom $m label it creates: https://github.com/zodern/melte#tracker-statements. Behind the scenes, it looks like it relies on melte-complier to handle the $m label here.
Thanks so much for taking a look!

My guess is that this will eventually be solved when these Svelte-related packages migrate to Svelte 5.
If there’s a way to silence the diagnostic messages though, please let me know.


Manually kick off a build

I'd like to use 0.4 at my company, but I can't (and wouldn't want to) open up a public port on my machine to receive callbacks.  Is it possible to get a button or shell command that kicks off a build against the latest revision of a repo?

@cjb data must be pushed to Drone via a post-commit hook. Drone is intended to be installed on a server with an open port to accept hooks. You could however, manually invoke the /api/hook endpoint with a payload that is compatible with the GitHub hook payload. You can get sample GitHub payloads in the GitHub UI by going to your repository settings, webhooks & services section, and clicking on existing webhooks. You would need to include the access_token when invoking the hook. You could do this with cron or curl, etc.
This isn't something we're going to build into Drone, but you are definitely free to reverse engineer the HTTP endpoint to fulfill your use case.