Safari not loading

Using last version of vivus. In Safari on PC, Mac, Ios page can't load with draw script, some svg icons are working, but some breaks the page.  For example https://jsbin.com/quvakiqivo/edit?html,js,output. What it can be connected with?

Your SVG is the issue. The path elements for the 'cove' seems too complex for Safari (which could be simplified, I don't know why there's so many points to define them). When it call the method getTotalLength() on these paths, my Safari crashes, litterally.
I made a copy of your jsbin without the coves, and it run as it should be.
https://jsbin.com/wafehupaja/1/edit?html,js,output
Try to redraw these path with your graphic editor, or simplify these paths with SVGOMG


Meteor.isServer dead blocks

The different files in sandstorm-app-market/app/client/collections/ contains if (Meteor.isServer) blocks in which allow and deny rules are defined. Since these files are in a client/ directory these allow and deny rules are not enforced.
This can't be exploited because all database queries are executed inside meteor methods, so I guess you could just remove these dead block altogether.

Yeah, the app market code went through some turbulence shortly before launch. We were originally storing the app index inside Mongo and having the submission process go through a UI built into the app market, but then I got really scared of what would happen if there were any security bugs in the app market that could allow people to rewrite Mongo entries, so I built a whole new pipeline where the market and index are separate apps and the market receives the app index as a read-only JSON blob. So now only reviews are stored in the market's Mongo. There's a lot of vestigial code around as a result of all this.

The fact that we miss a good mutation model in Meteor (and that allow/deny vs methods both have tradeoffs) is a bit sad. I tried something new and it feel like a good solution to me, I hope to write a blog post about the underlined ideas of this pattern next week.

My general feeling is that methods should always be preferred over allow/deny, because methods capture specific actions / intent, making them much easier to review, especially for security concerns. My main problem with methods is that they aren't object-oriented; essentially the server is one big object implementing all the methods. Eventually we hope to move from DDP to Cap'n Proto RPC, at least in Sandstorm proper.
Let me know when the blog post is written. I'll be interested to read it.


Added functions for drawing springs and rectangles.

Partially addresses #136.

The test failure here is due to this regression in SymPy: https://github.com/sympy/sympy/issues/14958


Move async to graphql-java-async project

Moved all async specific changes to graphql-java-async project.

@bmsantos what do you think about waiting for https://github.com/graphql-java/graphql-java/issues/336 first?

That's a possibility. But, in my opinion, I would separate the two. What I mean is that I would continue as it is. Then, whenever #336 is implemented, then create a new issue to move graphql-java-async into the new multi-module project.

This will allow you to start closing the open async tickets like this one and the one open in graphql-java #283.


ddl file not found for XGBoost framework?

hey .ddl file is not found in lib/ inside xgboost package.I have downloaded windows version of xgboost but cant find native .ddl lib file for xgboost how to solve this?

The upstream XGBoost4J artifact only contains binaries for Linux and macOS. As noted in the docs you'll need to compile it yourself to make it work with Windows. Internally we build XGBoost 1.0.0 for Windows and it works just fine. You might also be able to use the Windows jars from Criteo, but they only have 1.1.0 and we've not tested that combination.

so how can i use xgboost for now and test it out.i ve downloaded jars from criterio .?

Add them to your classpath, or as a maven/gradle dependency in whatever project you are building.

i have added to my maven ...same error is happening..Jars have diffrent class name and giving me no configurable implemented error. i m using win64 jar . wht should i do now?

What's the exact stack trace and error message, and what does your classpath look like?

this is the stack trace
Exception in thread "main" Property Exception component:'xgboost' - Class ml.dmlc.xgboost4j.java.XGBoost does not implement Configurable. com.oracle.labs.mlrg.olcut.config.PropertyException: Component: xgboost, Class ml.dmlc.xgboost4j.java.XGBoost does not implement Configurable. 	at com.oracle.labs.mlrg.olcut.config.ConfigurationManager.getPropertySheet(ConfigurationManager.java:1227) 	at com.oracle.labs.mlrg.olcut.config.ConfigurationManager.innerLookup(ConfigurationManager.java:1367) 	at com.oracle.labs.mlrg.olcut.config.ConfigurationManager.lookup(ConfigurationManager.java:1357) 	at com.oracle.labs.mlrg.olcut.config.ConfigurationManager.lookup(ConfigurationManager.java:1300) 	at MachineLearningWithTRIBUO.TribuoML.DecisionTree(TribuoML.java:72) 	at MachineLearningWithTRIBUO.TribuoML.main(TribuoML.java:243)
heres my SS you can see left xgboost4j_2.1.1-xxxxxxxxxxx.jar

If you want to use XGBoost with the configuration system then you should use Tribuo's XGBoost classes, XGBoostClassificationTrainer or XGBoostRegressionTrainer. They wrap the XGBoost4J classes and provide a Tribuo style interface. This isn't an issue with your classpath, it's an issue with the configuration file pointing at the wrong class.

previously i was using the same XGBoostClassificationTrainer.heres my SS:

Heres my original error after trying this config json xgboost :
java.io.FileNotFoundException: File /lib/xgboost4j.dll was not found inside JAR. 	at ml.dmlc.xgboost4j.java.NativeLibLoader.createTempFileFromResource(NativeLibLoader.java:126) 	at ml.dmlc.xgboost4j.java.NativeLibLoader.loadLibraryFromJar(NativeLibLoader.java:69) 	at ml.dmlc.xgboost4j.java.NativeLibLoader.initXGBoost(NativeLibLoader.java:41) 	at ml.dmlc.xgboost4j.java.XGBoostJNI.<clinit>(XGBoostJNI.java:34) 	at ml.dmlc.xgboost4j.java.DMatrix.<init>(DMatrix.java:109) 	at org.tribuo.common.xgboost.XGBoostTrainer.convertExamples(XGBoostTrainer.java:309) 	at org.tribuo.classification.xgboost.XGBoostClassificationTrainer.train(XGBoostClassificationTrainer.java:142) 	at org.tribuo.classification.xgboost.XGBoostClassificationTrainer.train(XGBoostClassificationTrainer.java:62) 	at org.tribuo.Trainer.train(Trainer.java:44) 	at MachineLearningWithTRIBUO.TribuoML.DecisionTree(TribuoML.java:119) 	at MachineLearningWithTRIBUO.TribuoML.main(TribuoML.java:243) Exception in thread "main" java.lang.ExceptionInInitializerError 	at ml.dmlc.xgboost4j.java.DMatrix.<init>(DMatrix.java:109) 	at org.tribuo.common.xgboost.XGBoostTrainer.convertExamples(XGBoostTrainer.java:309) 	at org.tribuo.classification.xgboost.XGBoostClassificationTrainer.train(XGBoostClassificationTrainer.java:142) 	at org.tribuo.classification.xgboost.XGBoostClassificationTrainer.train(XGBoostClassificationTrainer.java:62) 	at org.tribuo.Trainer.train(Trainer.java:44) 	at MachineLearningWithTRIBUO.TribuoML.DecisionTree(TribuoML.java:119) 	at MachineLearningWithTRIBUO.TribuoML.main(TribuoML.java:243) Caused by: java.lang.RuntimeException: java.io.FileNotFoundException: File /lib/xgboost4j.dll was not found inside JAR. 	at ml.dmlc.xgboost4j.java.XGBoostJNI.<clinit>(XGBoostJNI.java:37) 	... 7 more Caused by: java.io.FileNotFoundException: File /lib/xgboost4j.dll was not found inside JAR. 	at ml.dmlc.xgboost4j.java.NativeLibLoader.createTempFileFromResource(NativeLibLoader.java:126) 	at ml.dmlc.xgboost4j.java.NativeLibLoader.loadLibraryFromJar(NativeLibLoader.java:69) 	at ml.dmlc.xgboost4j.java.NativeLibLoader.initXGBoost(NativeLibLoader.java:41) 	at ml.dmlc.xgboost4j.java.XGBoostJNI.<clinit>(XGBoostJNI.java:34) 	... 7 more

You need to download the win64 jar. You downloaded the one without a type specifier which looks like it's only got a Linux binary in it.

okk it solved...thanks for your support


Fix data race in service test

📝 Summary
This PR fixes data race in service test.
It closes #241.
⛱ Motivation and Context
It removes concurrent read and write of the mock relays handler RegisterValidator by introducing a setter for the handler instead of just raw write on the structure field.
📚 References
.

✅ I have run these commands

[x] make lint
[x] make test-race
[x] make run-mergemock-integration
[x] go mod tidy

Codecov Report

Merging #242 (839292e) into main (6ebbc05) will increase coverage by 0.28%.
The diff coverage is 76.47%.

@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
+ Coverage   84.19%   84.47%   +0.28%
==========================================
  Files           5        5
  Lines         601      612      +11
==========================================
+ Hits          506      517      +11
  Misses         71       71
  Partials       24       24

Flag
Coverage Δ

unittests
84.47% <76.47%> (+0.28%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

server/mock_relay.go
86.84% <76.47%> (+1.02%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Thanks!


Pivot to standard MDX

When working with the standart mdx implementation, the problem that arose was that we have to define the shiki related logic inside the next.config.mjs file. I managed to get it working in this PR and will continue to work on it, but this is a decision we have to think about.
So far, no other issues arose, so I will continue to work on this and we will see where we land. I think that working with the installation docs for each component can be a little bit more tricky so we will see.

@ChcJohnie check this out. I feel like we have this working.
We need to clean the code a bit, but other than that I feel like this usage of the mdx files is better. What do you think?

Regarding the frontmatter, next/mdx does not support it out of the box, they offer an alternative - exporting objects from mdx - more info here. Or using gray-matter.
For me the big pros of using mdx are the following:

that we no longer have to create scope of components + variables in the page.tsx file
we can also drop the dependencies key in the componentTypes object - we control what we show in the mdx file itself
related to the above point above - we can use async components in mdx, making it more usable and flexible.

However both cons mentioned by @ChcJohnie are fair and we have to take them into consideration.
Idea: We could possibly drop the rehype-pretty-code plugin all together and just use a component to render the code the way we like with our @lib/shiki, I think that should be possible


Custom colors make dropdown backgrounds black

foo [bar v] :: #fff

The background of the dropdown is black for all custom colors

This also happens with boolean slots
boolean <> ::#fff


Unable to pick electrodes in raw.to_data_frame() method

I try to convert few electrodes to dataframe from raw data. I use the method to_data_frame() but I can't get it work if I select electrodes in no order. For instance this is working:
raw.to_data_frame(picks=[0, 1, 2], stop=10)

But this doesn't:
raw.to_data_frame(picks=[0, 1, 3], stop=10)

I get the following error:

.../lib/python2.7/site-packages/mne/io/base.pyc in to_data_frame(self, picks, index, scale_time, scalings, copy, start, stop)
170                 idx = [picks[i] for i in range(len(picks)) if types[i] == t]
171                 print idx
--> 172                 if len(idx) > 0:
173                     data[:, idx] *= scaling
174         else:
IndexError: index 3 is out of bounds for axis 1 with size 3

Thank you!

Looks like a bug. I'll see what I can do...


Question

Sorry to write this as an issue, but couldn't find any other resources on how to use the mod. As far as I can tell, the most is installed correctly, and on the bottom left of the menu it says "World Host Online", but any time me or friends go to add friends in the multiplayer menu, when we type in a username it is greyed out. Unsure if this is user error, or something else I need to set up? Thanks for the help.

If your friend's user is not found, the button will be grayed out. If you're certain you're typing the name correctly, Mojang's name servers might be down.

It turns oit the name servers were the issue. Thanks! Amazing mod!


fix: css-loader esModule translate error

目前原文档是如下描述：
You can enable a CommonJS modules syntax using:
与当前翻译结果不符

[ ] Read and sign the CLA. PRs that haven't signed it won't be accepted.
[ ] Make sure your PR complies with the writer's guide.
[ ] Review the diff carefully as sometimes this can reveal issues.
[ ] Do not abandon your Pull Request: Stale Pull Requests.
Remove these instructions from your PR as they are for your eyes only.

Thanks 🌹


Question: how to use neoconf API to get self-defined configs/fields?

Hi, I'm trying to understand the API doc: https://github.com/folke/neoconf.nvim#-api.
But still have some questions:

Where does the Neoconf defined? I copied the sample but my neovim reports: there's no Neoconf defined, it's nil value.
I add some configs to global ~/.config/nvim/neoconf.json (see below), but cannot get it with API: require('neoconf').get('myconfig.perf.file.maxsize'), nvim reports the returned value is nil:{
  "myconfig": {
    "perf.file.maxsize": 1024
  }
}

maybe dot refers to object, better off with this? :
{
  "myconfig": {
    "perf": {
      "file":{
        "maxsize": 1024
      }
    }
  }
}

thank you! @ogios  it solves my issue!


Error: parse error: premature EOF

spark_install_find(version = '2.1.1', hadoop_version = '2.7')
**Error: parse error: premature EOF

                 (right here) ------^**

sessionInfo()
R version 3.3.2 (2016-10-31)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows >= 8 x64 (build 9200)

locale:
[1] LC_COLLATE=Norwegian Bokmål_Norway.1252  LC_CTYPE=Norwegian Bokmål_Norway.1252    LC_MONETARY=Norwegian Bokmål_Norway.1252 LC_NUMERIC=C
[5] LC_TIME=Norwegian Bokmål_Norway.1252
attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base
other attached packages:
[1] sparklyr_0.5.6-9016
loaded via a namespace (and not attached):
[1] Rcpp_0.12.11     dbplyr_1.1.0     plyr_1.8.4       bindr_0.1        base64enc_0.1-3  tools_3.3.2      digest_0.6.12    jsonlite_1.5     tibble_1.3.3     nlme_3.1-128
[11] lattice_0.20-34  pkgconfig_2.0.1  rlang_0.1.1      psych_1.6.9      shiny_1.0.3      DBI_0.7          rstudioapi_0.6   curl_2.3         parallel_3.3.2   bindrcpp_0.2
[21] dplyr_0.7.1      httr_1.2.1       stringr_1.1.0    rappdirs_0.3.1   rprojroot_1.2    grid_3.3.2       glue_1.1.1       R6_2.2.0         foreign_0.8-67   reshape2_1.4.2
[31] tidyr_0.6.0      magrittr_1.5     backports_1.0.4  htmltools_0.3.5  assertthat_0.2.0 mnormt_1.5-5     mime_0.5         xtable_1.8-2     httpuv_1.3.3     stringi_1.1.2
[41] lazyeval_0.2.0   broom_0.4.2

@shoreshgithub try devtools::install_github("rstudio/spark-install")

Thanks kevinykuo for quick reply.
it solved my problem when I am going to Connect spark from jupyter notebook,now With Your solution I am able to install spark 2.1.1 and conncet spark inside jupyter notebook With R kernel
but still I cannot Connect spark With Rstudio ,Connection takes long time without any response
R version 3.3.2 (2016-10-31)
Platform: x86_64-w64-mingw32/x64 (64-bit)
Running under: Windows >= 8 x64 (build 9200)
locale:
[1] LC_COLLATE=English_United Kingdom.1252  LC_CTYPE=English_United Kingdom.1252
[3] LC_MONETARY=English_United Kingdom.1252 LC_NUMERIC=C
[5] LC_TIME=English_United Kingdom.1252
attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base
other attached packages:
[1] dplyr_0.7.1         sparklyr_0.5.6-9016
loaded via a namespace (and not attached):
[1] Rcpp_0.12.11     dbplyr_1.1.0     plyr_1.8.4       bindr_0.1        base64enc_0.1-3  tools_3.3.2
[7] digest_0.6.12    jsonlite_1.5     tibble_1.3.3     nlme_3.1-128     lattice_0.20-34  pkgconfig_2.0.1
[13] rlang_0.1.1      psych_1.6.9      shiny_1.0.3      DBI_0.7          rstudioapi_0.6   yaml_2.1.14
[19] curl_2.3         parallel_3.3.2   bindrcpp_0.2     httr_1.2.1       stringr_1.1.0    rappdirs_0.3.1
[25] rprojroot_1.2    grid_3.3.2       glue_1.1.1       R6_2.2.0         foreign_0.8-67   reshape2_1.4.2
[31] tidyr_0.6.0      magrittr_1.5     backports_1.0.4  htmltools_0.3.5  assertthat_0.2.0 mnormt_1.5-5
[37] mime_0.5         xtable_1.8-2     httpuv_1.3.3     config_0.2       stringi_1.1.2    lazyeval_0.2.0
[43] broom_0.4.2

@shoreshgithub fixed with https://github.com/rstudio/sparklyr/commit/e88632e06aa2ff65cc85f7cb2b175bcf88018282, thanks for opening this issue!


change the case of H in  HighlightText to uppercase to comply with ex…

…isting naming convention

I think the reason why the H was lower case is due to the camel case naming convention. However, since this is a string and not a variable, I think you made the right call in making it uppercase so that things are more consistent


_includes/cli.md: fix flag descriptions with < and >

fixes https://github.com/docker/docker.github.io/issues/11331
replaces / closes https://github.com/docker/docker.github.io/pull/12064
Some flag descriptions contain point-brackets to indicate required options, e.g.:
--ssh stringArray   SSH agent socket or keys to expose to the build (format: default|<id>[=<socket>|<key>[,<key>]])

When rendering those options as HTML, those options were not visible as
they were rendered as a HTML element.
Given that flag-descriptions are not expected to have MarkDown or HTML
formatting, we can HTML-escape them to prevent this.
This patch escapes the flag-descriptions using liquid's esacape command.
Before this patch:

After this patch:

@usha-mandya @StefanScherer PTAL

@usha-mandya @StefanScherer PTAL

Hmm, Netlify failed; doesn't look related, but not sure how to restart it
Gem::RemoteFetcher::FetchError: bad response Gateway Error 502 (https://rubygems.org/gems/ruby2_keywords-0.0.2.gem)
  /opt/buildhome/.rvm/rubies/ruby-2.3.6/lib/ruby/site_ruby/2.3.0/rubygems/remote_fetcher.rb:274:in `fetch_http'
  /opt/buildhome/.rvm/rubies/ruby-2.3.6/lib/ruby/site_ruby/2.3.0/rubygems/remote_fetcher.rb:292:in `fetch_path'
  /opt/buildhome/.rvm/rubies/ruby-2.3.6/lib/ruby/site_ruby/2.3.0/rubygems/remote_fetcher.rb:327:in `cache_update_path'

Hmm, Netlify failed; doesn't look related, but not sure how to restart it
Gem::RemoteFetcher::FetchError: bad response Gateway Error 502 (https://rubygems.org/gems/ruby2_keywords-0.0.2.gem)
  /opt/buildhome/.rvm/rubies/ruby-2.3.6/lib/ruby/site_ruby/2.3.0/rubygems/remote_fetcher.rb:274:in `fetch_http'
  /opt/buildhome/.rvm/rubies/ruby-2.3.6/lib/ruby/site_ruby/2.3.0/rubygems/remote_fetcher.rb:292:in `fetch_path'
  /opt/buildhome/.rvm/rubies/ruby-2.3.6/lib/ruby/site_ruby/2.3.0/rubygems/remote_fetcher.rb:327:in `cache_update_path'

close/reopen didn't seem to trigger it again; let me rebase/push

close/reopen didn't seem to trigger it again; let me rebase/push

All green now; @StefanScherer @usha-mandya ptal 🤗

All green now; @StefanScherer @usha-mandya ptal 🤗

All green now; @StefanScherer @usha-mandya ptal 🤗

All green now; @StefanScherer @usha-mandya ptal 🤗


Fix typo in Etherscan API key env field

Description

Additional Information

[x] I have read the contributing docs (if this is your first contribution)
[x] This is not a duplicate of any existing pull request

Related Issues
Closes #{issue number}
Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.
Your ENS/address:

Hey @lukaw3d just noticed that on prod we actually have NEXT_PUBLIC_MAINNET_ETHERSCAN_API_KEY setup we have it wrong in networks.ts
https://github.com/BuidlGuidl/abi.ninja/blob/d0ebfcb4129e7031e2e4379af44b422b994b20d3/packages/nextjs/utils/scaffold-eth/networks.ts#L46
Could you update networks.ts instead? And revert changes to .env.example?

:scream: yep


Q: Sharing a link to the 30th, 60th, 90th ckpts?

Hi @frederick0329 !
I was wondering if you had considered sharing the 30th, 60th, and 90th Resnet 50 checkpoints you are using in the notebook. Without them, like karasepid in another issue/thread, I'm sometimes confused about the shape of some of the variables/fields used. If the checkpoints were made available, then it would be straightforward for us to just step through the notebook code and print out those shapes.
Could the checkpoints perhaps be shared from a Google drive, or whatever online storage works best for you?
Thanks for considering this request!
Best regards, -- Phil

I'm really sorry<EMAIL_ADDRESS>Checkpoint release requires Google's legal approval and I don't think I will be able to do that. To validate the shapes, I think you can simply comment out weight loading and use 3 random inits.

No worries, @frederick0329 .
Using 3 random inits is exactly what I've been doing to familiarize myself with the notebook code. The results are (obviously) meaningless but I am at least able to confirm tensor shapes.
Thank you for sharing the rational for not distributing the checkpoints though.


Add statistics

We have a Piwik instance running, so let's use it's reporting API to observe direkt calls to the API (which might not come from our website).
node.js plugins

https://github.com/fvdm/nodejs-piwik
https://github.com/fhemberger/piwik-tracker

Tasks

[ ] evaluate the two plugins, decide
[ ] integrate it for all paths logging information about date, time, user-ID, ... and what more?

I'm not convinced that piwik should be integrated in our services. A cleaner solution would be to use nginx's log files, i.e. https://piwik.org/log-analytics/. This would a) not introduce more dependencies into the services and b) centralize the connection between API access and analytics.

I see your point, and Piwik Log Analytics look promising.
Another alternative would be collecting and analysing the logs with the ELK stack. This would require us to log the relevant information, though!
@JanKoppe Is it currently the case that all "timed" events (start of X, end of X) are written to the log? These statements must also be connected, for example via a request identifier. And the "end" statements should/must include a field saying "execution took X ms". Right?

No, as of now the execution time for a request is not logged. I'm pretty sure that this is possible with nginx though, should be done for the access_log. Also, we could extend the middleware in the microservices, that logs every request (i.e. `GET request for …). Should be doable.

I agree and updated the first comment accordingly.


tools: remove hack/tools go mod dependencies and add those in the makefile

Description
tools: remove hack/tools go mod dependencies and add those in the makefile
remove the go mod file from the hack directory to make it simpler.
cc @invidian
Why is this needed
Fixes partially https://github.com/tinkerbell/cluster-api-provider-tink/issues/10 which i will do a follow up PR after this one
How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:
I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

/lgtm
/approve


Add Threlte studio

Topic
threlte
Description
Was just showcased in the summit.
Describe the solution you'd like
No response

Currently Threlte Studio is still in the works and not available to the public yet. Even their @next version does not contain it apparently.

Project is now using the svelte-add name again. Issue moved: https://github.com/svelte-add/svelte-add/issues/342


RFP - weasel-(traditional-chinese/hong-kong-chinese)

Current Maintainer
@chtof

[ ] I am the maintainer of the package and wish to pass it to someone else;

I DON'T Want To Become The Maintainer

[x] I have followed the Package Triage Process and I do NOT want to become maintainer of the package;
[x] There is no existing open maintainer request for this package;

Checklist

[ ] RFM - Weasel (but defaults to "Simplified, China" instead of "Traditional, Hong Kong")

Existing Package Details

Package URL: https://chocolatey.org/packages/weasel
Package source URL: https://github.com/rime/weasel

Date the maintainer was contacted (in YYYY-MM-DD):
How the maintainer was contacted:

Please use the correct template when you are opening an issue in this repository, as well as only request 1 package in each issue.
Please fix the items mentioned by the bot, otherwise we will most likely close this issue in 7 days.

@AdmiringWorm apologies but I would like to raise an issue regarding a package behaving differently from a direct download from the site, and I hope that this can be addressed somehow, since the template is confusing.

@BrandonKMLee that is not what this repository is.
This repository is for requesting new packages that people want, as well as part of the triage process of getting new maintainers of existing packages.
For issues regarding specific packages, you need to contact the maintainer of that package (either using Contact Maintainers, the disqus comments or through their source repository).
For that specific package, I believe the maintainer prefer using their source repository here: https://github.com/chtof/chocolatey-packages.
I will be closing this issue, as it seems your request don't align with what this repository is intended to be used for.


Possible bug with Smart-Smiles translate Atom that without hydrogen

Describe the bug
When I try to translate Atom without hydrogen between Smart-Smiles, I find RDkit will change the molecular Structure.
To Reproduce
When the atom is not fully bonded and connected to more than one hydrogen， it works well:
print(Chem.MolToSmiles(Chem.MolFromSmarts( '[#6]-[#7H1]')))#get C[NH]
print(Chem.MolToSmiles(Chem.MolFromSmarts( '[#6]-[#6H1]')))#get[CH]C
print(Chem.MolToSmiles(Chem.MolFromSmarts( '[#6]-[#6H2]')))#get[CH2]C
print(Chem.MolToSmiles(Chem.MolFromSmarts( '[#8H1]')))#get[OH]
print(Chem.MolToSmarts(Chem.MolFromSmiles( 'C[NH]')))#get[#6]-[#7H]
print(Chem.MolToSmarts(Chem.MolFromSmiles( '[OH]')))#get[#8H]

When the atom is not fully bonded and not connected to any hydrogen， it works wrong:
print(Chem.MolToSmiles(Chem.MolFromSmarts( '[#6]-[#7H0]'))) #get CN
print(Chem.MolToSmiles(Chem.MolFromSmarts( '[#6]-[#6H0]'))) #get CC
print(Chem.MolToSmiles(Chem.MolFromSmarts( '[#6]-[#6H0]'),allHsExplicit=True) ) #get [CH3][CH3]
print(Chem.MolToSmiles(Chem.MolFromSmarts( '[#8H0]'))) #get O
print(Chem.MolToSmarts(Chem.MolFromSmiles( 'C[N]'))) #get [#6]-[#7]
print(Chem.MolToSmarts(Chem.MolFromSmiles( '[O]'))) #get [#8]
print(Chem.MolToSmarts(Chem.MolFromSmiles( '[C]'))) #get [#6]

this code also not works:
print(Chem.MolToSmiles(Chem.MolFromSmarts( '[#6]-[#8&H0]')))#get CO
print(Chem.MolToSmiles(Chem.MolFromSmarts( '[#6]-[#8!H]')))#get CO
print(Chem.MolToSmiles(Chem.MolFromSmarts( '[#6]-[#8&!H]')))#get CO
print(Chem.MolToSmiles(Chem.MolFromSmarts( '[#6]-[#8X1]')))#get CO
print(Chem.MolToSmiles(Chem.MolFromSmarts( '[#6]-[#8&X1]')))#get CO
print(Chem.MolToSmiles(Chem.MolFromSmarts( '[#6]-[#8v1]')))#get CO
print(Chem.MolToSmiles(Chem.MolFromSmarts( '[#6]-[#8&v1]')))#get CO

Expected behavior
I want translate some smarts wo smiles then get C[N],C[O],C[C]
Configuration (please complete the following information):

RDKit version: 2021.03.2
OS: win10 20H2
Python version (if relevant): 3.8
Are you using conda? yes
If you are using conda, which channel did you install the rdkit from? conda

Additional context
Well,match part can work well
m = Chem.MolFromSmiles('OCC[O]')
print(m.GetSubstructMatches(Chem.MolFromSmarts('[O&!H]')))#get ((3,),)
Draw.MolToImage(m,highlightAtoms=m.GetSubstructMatches(Chem.MolFromSmarts('[$([OH0])]'))[-1])

@jingxingzhi : It's not possible to convert a molecule constructed from SMARTS into SMILES in a lossless way. We do the best we can, but the SMARTS parser adds query information to the molecule which doesn't get translated into the SMILES output.
Many, many SMARTS, like C[N,O,S], can't be translated into SMILES at all.
We might be able to help more and provide alternate ideas if you describe why you want to do this.

@jingxingzhi：不可能将SMARTS构造的分子无损地转化为SMILES。我们会尽力而为，但是SMARTS解析器会将查询信息添加到未翻译为SMILES输出的分子中。
像一样的许多许多SMARTSC[N,O,S]根本无法翻译成SMILES。
如果您描述为什么要这样做，我们也许可以提供更多帮助并提供其他想法。

Thanks a lot.
actualy
I was try to write an reaction and it will creats atom which is not fully bonded(Free radicals)
just like COC→[CH3]+C[O]
but when i write:
AllChem.ReactionFromSmarts('[#6]-[#8:1]-[#6:2]>>[#6H3].[#6]-[#8X0]')

it not works as I expected
rxn = AllChem.ReactionFromSmarts('[#6]-[#8:1]-[#6:2]>>[#6H3].[#6]-[#8X0]')
abc=Chem.MolFromSmiles('COC')
reactants = (abc,)
res=rxn.RunReactants(reactants)
try:
    Draw.MolsToGridImage([abc]+list(res[0]))
except:
    pass
Draw.MolsToGridImage([abc])
print(res[0][0])
Draw.MolsToGridImage([Chem.MolFromSmiles(Chem.MolToSmiles(res[0][0])),Chem.MolFromSmiles(Chem.MolToSmiles(res[0][1]))])

I can not get C[O]

if I write：
Draw.MolsToGridImage([res[0][0],res[0][1]])

it will show
RuntimeError                              Traceback (most recent call last)
<ipython-input-162-0a73e9137d75> in <module>
----> 1 Draw.MolsToGridImage([res[0][0],res[0][1]])

C:\ProgramData\Anaconda3\lib\site-packages\rdkit\Chem\Draw\IPythonConsole.py in ShowMols(mols, maxMols, **kwargs)
    195       if prop in kwargs:
    196         kwargs[prop] = kwargs[prop][:maxMols]
--> 197   res = fn(mols, drawOptions=drawOptions, **kwargs)
    198   if kwargs['useSVG']:
    199     return SVG(res)

C:\ProgramData\Anaconda3\lib\site-packages\rdkit\Chem\Draw\__init__.py in MolsToGridImage(mols, molsPerRow, subImgSize, legends, highlightAtomLists, highlightBondLists, useSVG, returnPNG, **kwargs)
    609                           highlightBondLists=highlightBondLists, **kwargs)
    610   else:
--> 611     return _MolsToGridImage(mols, molsPerRow=molsPerRow, subImgSize=subImgSize, legends=legends,
    612                             highlightAtomLists=highlightAtomLists,
    613                             highlightBondLists=highlightBondLists, returnPNG=returnPNG, **kwargs)

C:\ProgramData\Anaconda3\lib\site-packages\rdkit\Chem\Draw\__init__.py in _MolsToGridImage(mols, molsPerRow, subImgSize, legends, highlightAtomLists, highlightBondLists, drawOptions, returnPNG, **kwargs)
    552           setattr(dops, k, v)
    553           del kwargs[k]
--> 554     d2d.DrawMolecules(list(mols), legends=legends or None, highlightAtoms=highlightAtomLists,
    555                       highlightBonds=highlightBondLists, **kwargs)
    556     d2d.FinishDrawing()

RuntimeError: Pre-condition Violation
	getExplicitValence() called without call to calcExplicitValence()
	Violation occurred on line 199 in file Code\GraphMol\Atom.cpp
	Failed Expression: d_explicitValence > -1
	RDKIT: 2021.03.2
	BOOST: 1_74

@jingxingzhi you have to map the atoms in the reaction if you want things to work correctly.
You also should always sanitize the results which come back from reactions (this is mentioned in the docs: https://rdkit.org/docs/GettingStartedInPython.html#chemical-reactions)
Here's an example:
In [6]: rxn = AllChem.ReactionFromSmarts('[#6:3]-[#8:1]-[#6:2]>>[#6H3:3].[#6:2]-[#8H0:1]')

In [7]: ps = rxn.RunReactants((Chem.MolFromSmiles('COC'),))

In [9]: for p in ps: Chem.SanitizeMol(p[0])

In [10]: [Chem.MolToSmiles(p[0]) for p in ps]
Out[10]: ['[CH3]', '[CH3]']

In [11]: for p in ps: Chem.SanitizeMol(p[1])

In [12]: [Chem.MolToSmiles(p[1]) for p in ps]
Out[12]: ['C[O]', 'C[O]']

Notice that the output molecules have the radicals you were looking for.

@jingxingzhi you have to map the atoms in the reaction if you want things to work correctly.
You also should always sanitize the results which come back from reactions (this is mentioned in the docs: https://rdkit.org/docs/GettingStartedInPython.html#chemical-reactions)
Here's an example:
In [6]: rxn = AllChem.ReactionFromSmarts('[#6:3]-[#8:1]-[#6:2]>>[#6H3:3].[#6:2]-[#8H0:1]')

In [7]: ps = rxn.RunReactants((Chem.MolFromSmiles('COC'),))

In [9]: for p in ps: Chem.SanitizeMol(p[0])

In [10]: [Chem.MolToSmiles(p[0]) for p in ps]
Out[10]: ['[CH3]', '[CH3]']

In [11]: for p in ps: Chem.SanitizeMol(p[1])

In [12]: [Chem.MolToSmiles(p[1]) for p in ps]
Out[12]: ['C[O]', 'C[O]']

Notice that the output molecules have the radicals you were looking for.

Thats really help,I truly appreciate your support during this work.
I'm just curious why the previous conversion method didn't work，so I read the SmilesWrite.cpp and the SmartsWrite.cpp.
I find in SmilesWrite.cpp there was "needsBracket", while SmartsWrite.cpp does not has that.
If the needsBracket Atom was incorrectly labeled as "AtomHasImplicitH"or"AtomHCount"  ?
'''
if (needsBracket) {    res += "[";  }
if (isotope && (isomericSmiles || (atom->hasOwningMol() &&                                     atom->getOwningMol().hasProp(                                         common_properties::_doIsoSmiles)))) {    res += std::to_string(isotope);  }  // this was originally only done for the organic subset,  // applying it to other atom-types is a fix for Issue 3152751:  if (!doKekule && atom->getIsAromatic() && symb[0] >= 'A' && symb[0] <= 'Z') {    symb[0] -= ('A' - 'a');  }  res += symb;
res += atString;
if (needsBracket) {    unsigned int totNumHs = atom->getTotalNumHs();
'''
Chem.MolFromSmiles(Chem.MolToSmiles(Chem.MolFromSmarts('[#8H1]')))

Chem.MolFromSmiles(Chem.MolToSmiles(Chem.MolFromSmarts('[#6]-[#8H0]')))

You can see this issuewas only appeared when Atom radicals has 0 H,if there is a better way to deal with this problem？
I think may support he mutual transformation of A and B can be help ,just like find Atom that "needsBracket" , re-count thenum of H and accept [#numH0]?
thank you for your help.


Generated an empty chunk message when there is no js or css included in html

Describe the bug
There is a message Generated an empty chunk upon vite build when html files have no included js or css files.
This can especially bloat build log if there are a lot of multipage html files. eg. files that have only inline styles, or don't use included js.
Reproduction
https://stackblitz.com/edit/vitejs-vite-b1ed5d
Steps to reproduce
run vite build
System Info
ystem:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.20.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.4.2 - /usr/local/bin/npm
    pnpm: 8.6.3 - /usr/local/bin/pnpm
  npmPackages:
    vite: ^4.4.5 => 4.4.7

Used Package Manager
npm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Probably related to https://github.com/vitejs/vite/issues/13436

@patak-dev seems to be fixed now in v4.4.9 👍

Thanks for testing this back @lubomirblazekcz!


Combines image & markdown changes

Description & motivation
Added changes from matt-winkler-patch-1 and matt-winkler-patch-2 to this new branch per Drew's / Amy's comments. This one has the images and markdown changes in the same PR.
Will remove the other two branches.

@drewbanin added your suggested name change commit. Thanks for help on this (and @amychen1776)!

@drewbanin added your suggested name change commit. Thanks for help on this (and @amychen1776)!


[BUG] Cannot Copy And Paste In File Explorer And Taskbar Search Box - Fixed

Describe the bug
After applying the 'Set-Additional.cmd' can no longer copy and paste into the File Explorer and taskbar Search Bar boxes.
The fix is below.
If anyone has an issue where they cannot copy/paste into the File Explorer and taskbar Search Icon search boxes after running 'Set-Additional.cmd', here is the fix.
From the 'Services.json' remove the below.
{
        "Name":  "WSearch",
        "Description":  "Windows Search",
        "ServiceName":  "WSearch",
        "Status":  4,
        "StartType":  2,
        "SetStatus":  "Disabled"
    },

And from the Set-Additional.ps1 remove this.
# Disable Clipboard history, its synchronization service and any Remote Desktop redirection.
        If ($Build -ge 17763)
        {
            If (!(Test-Path -Path "HKLM:\SOFTWARE\Policies\Microsoft\Windows\System")) { New-Item -Path "HKLM:\SOFTWARE\Policies\Microsoft\Windows\System" -ItemType Directory -Force | Out-Null }
            Set-ItemProperty -Path "HKLM:\SOFTWARE\Policies\Microsoft\Windows\System" -Name AllowCrossDeviceClipboard -Value 0 -Force
            Set-ItemProperty -Path "HKLM:\SOFTWARE\Policies\Microsoft\Windows\System" -Name AllowClipboardHistory -Value 0 -Force
            If (!(Test-Path -Path "HKLM:\SOFTWARE\Microsoft\Terminal Server Client")) { New-Item -Path "HKLM:\SOFTWARE\Microsoft\Terminal Server Client" -ItemType Directory -Force | Out-Null }
            Set-ItemProperty -Path "HKLM:\SOFTWARE\Microsoft\Terminal Server Client" -Name DisableClipboardRedirection -Value 1 -Force
            If (!(Test-Path -Path "HKCU:\Software\Microsoft\Clipboard")) { New-Item -Path "HKCU:\Software\Microsoft\Clipboard" -ItemType Directory -Force | Out-Null }
            Set-ItemProperty -Path "HKCU:\Software\Microsoft\Clipboard" -Name EnableClipboardHistory -Value 0 -Force
            Set-ItemProperty -Path "HKLM:\SYSTEM\CurrentControlSet\Services\cbdhsvc" -Name Start -Value 4 -Force
        }

        # Uninstall Cortana.
        If ($Build -ge 19041) { Get-AppxPackage -Name *Microsoft.549981C3F5F10* | Remove-AppxPackage -AllUsers | Out-Null }

I think you can keep search service disabled as it is in Services.json. Not sure about that cortana one though, it depends on the version of win10 (ie LTSC makes no diff), but later on cortana was decoupled?
You only prolly need to change the clipboard sections in that registry grouping ie AllowClipboardHistory to 1, EnableClipboardHistory to 1, not sure about the cbdhsvc, but you can try.

I think you can keep search service disabled as it is in Services.json. Not sure about that cortana one though, it depends on the version of win10 (ie LTSC makes no diff), but later on cortana was decoupled?
You only prolly need to change the clipboard sections in that registry grouping ie AllowClipboardHistory to 1, EnableClipboardHistory to 1, not sure about the cbdhsvc, but you can try.


Document fields

At the moment, our config.yml file has documentation for every node type in the syntax tree. However, there is little to no documentation for the individual fields on the nodes. This is a crucial piece of information for understanding how the nodes should be used and what they represent. Therefore, we would like to document each field on each node, and surface that documentation to the end user.
This issue serves as a meta-issue for that work. Each node is listed below, and should be checked off when all of its fields are completely documented.
In terms of style we are very much not looking for "this is the receiver of the method call". Instead we are looking for "this can be nil or a node that represents a non-void expression". Generally we want to avoid tautological statements, and instead favor more useful comments. Examples are encouraged — where applicable — and should begin with 4 spaces. See https://github.com/ruby/prism/blob/c790abd3bd288f2dbcba985ba2b41b5e84d68619/config.yml#L717-L729 for an example.
Importantly, we do not want to document any flags fields. These already have their own documentation on the flags itself, so we don't want to duplicate it.

[ ] AliasGlobalVariableNode
[ ] AliasMethodNode
[ ] AlternationPatternNode
[x] AndNode
[ ] ArgumentsNode
[ ] ArrayNode
[ ] ArrayPatternNode
[x] AssocNode
[x] AssocSplatNode
[ ] BackReferenceReadNode
[ ] BeginNode
[ ] BlockArgumentNode
[ ] BlockLocalVariableNode
[ ] BlockNode
[ ] BlockParameterNode
[ ] BlockParametersNode
[ ] BreakNode
[ ] CallAndWriteNode
[ ] CallNode
[ ] CallOperatorWriteNode
[ ] CallOrWriteNode
[ ] CallTargetNode
[ ] CapturePatternNode
[ ] CaseMatchNode
[ ] CaseNode
[ ] ClassNode
[ ] ClassVariableAndWriteNode
[ ] ClassVariableOperatorWriteNode
[ ] ClassVariableOrWriteNode
[ ] ClassVariableReadNode
[ ] ClassVariableTargetNode
[ ] ClassVariableWriteNode
[ ] ConstantAndWriteNode
[ ] ConstantOperatorWriteNode
[ ] ConstantOrWriteNode
[ ] ConstantPathAndWriteNode
[ ] ConstantPathNode
[ ] ConstantPathOperatorWriteNode
[ ] ConstantPathOrWriteNode
[ ] ConstantPathTargetNode
[ ] ConstantPathWriteNode
[ ] ConstantReadNode
[ ] ConstantTargetNode
[ ] ConstantWriteNode
[ ] DefNode
[ ] DefinedNode
[ ] ElseNode
[ ] EmbeddedStatementsNode
[ ] EmbeddedVariableNode
[ ] EnsureNode
[x] FalseNode
[ ] FindPatternNode
[ ] FlipFlopNode
[x] FloatNode
[ ] ForNode
[x] ForwardingArgumentsNode
[x] ForwardingParameterNode
[ ] ForwardingSuperNode
[ ] GlobalVariableAndWriteNode
[ ] GlobalVariableOperatorWriteNode
[ ] GlobalVariableOrWriteNode
[ ] GlobalVariableReadNode
[ ] GlobalVariableTargetNode
[ ] GlobalVariableWriteNode
[x] HashNode
[ ] HashPatternNode
[ ] IfNode
[ ] ImaginaryNode
[ ] ImplicitNode
[x] ImplicitRestNode
[ ] InNode
[ ] IndexAndWriteNode
[ ] IndexOperatorWriteNode
[ ] IndexOrWriteNode
[ ] IndexTargetNode
[ ] InstanceVariableAndWriteNode
[ ] InstanceVariableOperatorWriteNode
[ ] InstanceVariableOrWriteNode
[ ] InstanceVariableReadNode
[ ] InstanceVariableTargetNode
[ ] InstanceVariableWriteNode
[x] IntegerNode
[ ] InterpolatedMatchLastLineNode
[ ] InterpolatedRegularExpressionNode
[ ] InterpolatedStringNode
[ ] InterpolatedSymbolNode
[ ] InterpolatedXStringNode
[ ] KeywordHashNode
[ ] KeywordRestParameterNode
[ ] LambdaNode
[ ] LocalVariableAndWriteNode
[ ] LocalVariableOperatorWriteNode
[ ] LocalVariableOrWriteNode
[ ] LocalVariableReadNode
[ ] LocalVariableTargetNode
[ ] LocalVariableWriteNode
[ ] MatchLastLineNode
[ ] MatchPredicateNode
[ ] MatchRequiredNode
[ ] MatchWriteNode
[x] MissingNode
[ ] ModuleNode
[ ] MultiTargetNode
[ ] MultiWriteNode
[ ] NextNode
[x] NilNode
[ ] NoKeywordsParameterNode
[ ] NumberedParametersNode
[ ] NumberedReferenceReadNode
[ ] OptionalKeywordParameterNode
[ ] OptionalParameterNode
[x] OrNode
[ ] ParametersNode
[ ] ParenthesesNode
[ ] PinnedExpressionNode
[ ] PinnedVariableNode
[ ] PostExecutionNode
[ ] PreExecutionNode
[ ] ProgramNode
[x] RangeNode
[ ] RationalNode
[x] RedoNode
[ ] RegularExpressionNode
[ ] RequiredKeywordParameterNode
[ ] RequiredParameterNode
[ ] RescueModifierNode
[ ] RescueNode
[ ] RestParameterNode
[x] RetryNode
[ ] ReturnNode
[x] SelfNode
[ ] SingletonClassNode
[x] SourceEncodingNode
[ ] SourceFileNode
[x] SourceLineNode
[ ] SplatNode
[ ] StatementsNode
[ ] StringNode
[ ] SuperNode
[ ] SymbolNode
[x] TrueNode
[ ] UndefNode
[ ] UnlessNode
[ ] UntilNode
[ ] WhenNode
[ ] WhileNode
[ ] XStringNode
[ ] YieldNode

Taking up IntegerNode

For visibility, I've opened #2135 which adds documentation for fields on HashNode, AssocNode and AssocSplatNode.

@kddnewton We can actually mark the nodes which doesn't have any fields as done right?

Yes you're right, I just marked them all as completed.

@kddnewton calling dibs on ArrayNode

@MatheusRich

@kddnewton calling dibs on ArrayNode

That one already has an open PR. But the others should be good!

Should've looked at the PRs too. Taking UnlessNode instead, then.

Taking BreakNode now.

Taking YieldNode now.

@tenderlove I think we might want to keep this issue open.


Sub Requests triggered by DatasetReference are not cacheable correctly

In headless situation, caching is very important, especially for requests triggered to the backend.
In my project, I use fetchByFilter to get some objects.
To prevent making too much request to the backend I rely on the cache mechanism of NextJS: https://nextjs.org/docs/app/building-your-application/data-fetching
I pass a fetchOptions object with the information about the caching to fetchByFilter. e.g.:
    fetchOptions: {
      next: {
        tags: ["my-tag"],
        revalidate: 3600,
      },
    },

NextJS will cache the response of the fetch for one hour. The next calls will be served from the cache instead of from the backend. It works well.
If the returned objects contains some DatasetReference. Sub requests will be triggered internally by the fsxa-api library.
However the fetchOptions param is lost and not passed by the original fetchByFilter call.
This makes caching of sub request impossible.
I was able to check that by adding some extra logging.
FSXARemoteApi.js
    FSXARemoteApi.prototype.fetchByFilter = function (_a, mapper) {
        console.log('Fetch by filter');
        console.log(_a.fetchOptions);

The produced log:
$ npx ts-node index-countries.ts
Fetch by filter
{ next: { tags: [ 'my-tag' ], revalidate: 3600 } }
Fetch by filter
undefined
Fetch by filter
undefined
Fetch by filter
undefined
Fetch by filter
undefined
Fetch by filter

Is there a way to make sure the fetchOptions is pass to sub fetchByFilter calls?

There is currently no way to get fetchOptions propagated to subsequent requests. And I doubt that it would be a good idea to have these propagated by default.
You can e.g. opt-out of automatic reference resolving (by setting the depth to zero) and do then the resolving yourself (including your desired options).
But we may accept a patch as long as it is non-breaking (ie with an opt-in flag).


support token reload for istio-kubeconfig secret

https://docs.google.com/document/d/1Mt-RzOf2nny2D1j8BFM78M2ZvRLwCISWzbRWZvx-6qE/edit#heading=h.xw1gqgyqs5b
an initial version to get some feedback

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
4593de3a26b319bd04fbc0df72ba61e70b6f1b78
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
4593de3a26b319bd04fbc0df72ba61e70b6f1b78
link
/test release-notes_istio

integ-security-k8s-tests_istio
4593de3a26b319bd04fbc0df72ba61e70b6f1b78
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
4593de3a26b319bd04fbc0df72ba61e70b6f1b78
link
/test release-notes_istio

integ-security-k8s-tests_istio
4593de3a26b319bd04fbc0df72ba61e70b6f1b78
link
/test integ-security-k8s-tests_istio

gencheck_istio
4593de3a26b319bd04fbc0df72ba61e70b6f1b78
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
4593de3a26b319bd04fbc0df72ba61e70b6f1b78
link
/test release-notes_istio

integ-security-k8s-tests_istio
4593de3a26b319bd04fbc0df72ba61e70b6f1b78
link
/test integ-security-k8s-tests_istio

gencheck_istio
4593de3a26b319bd04fbc0df72ba61e70b6f1b78
link
/test gencheck_istio

integ-pilot-k8s-tests_istio
4593de3a26b319bd04fbc0df72ba61e70b6f1b78
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
4593de3a26b319bd04fbc0df72ba61e70b6f1b78
link
/test integ-security-k8s-tests_istio

gencheck_istio
4593de3a26b319bd04fbc0df72ba61e70b6f1b78
link
/test gencheck_istio

integ-pilot-k8s-tests_istio
4593de3a26b319bd04fbc0df72ba61e70b6f1b78
link
/test integ-pilot-k8s-tests_istio

release-notes_istio
550c18e6ea7b397c4c4c3eb6d0f499ac245d60f0
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-notes_istio

unit-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-notes_istio

unit-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test unit-tests_istio

release-test_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-test_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-notes_istio

unit-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test unit-tests_istio

release-test_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-test_istio

lint_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-notes_istio

unit-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test unit-tests_istio

release-test_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-test_istio

lint_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test lint_istio

integ-distroless-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-distroless-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-notes_istio

unit-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test unit-tests_istio

release-test_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-test_istio

lint_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test lint_istio

integ-distroless-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-notes_istio

unit-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test unit-tests_istio

release-test_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-test_istio

lint_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test lint_istio

integ-distroless-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-notes_istio

unit-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test unit-tests_istio

release-test_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-test_istio

lint_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test lint_istio

integ-distroless-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-operator-controller-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-notes_istio

unit-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test unit-tests_istio

release-test_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-test_istio

lint_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test lint_istio

integ-distroless-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-notes_istio

unit-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test unit-tests_istio

release-test_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-test_istio

lint_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test lint_istio

integ-distroless-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-notes_istio

unit-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test unit-tests_istio

release-test_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-test_istio

lint_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test lint_istio

integ-distroless-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-notes_istio

unit-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test unit-tests_istio

release-test_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-test_istio

lint_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test lint_istio

integ-distroless-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-multicluster-k8s-tests_istio

analyze-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test analyze-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test unit-tests_istio

release-test_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-test_istio

integ-distroless-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-multicluster-k8s-tests_istio

analyze-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test analyze-tests_istio

release-notes_istio
03bc6403dcd69a6efb5ee0ce3cd5f37ae043f79f
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-test_istio

integ-distroless-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-distroless-k8s-tests_istio

integ-security-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-security-k8s-tests_istio

integ-pilot-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-pilot-k8s-tests_istio

integ-operator-controller-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-multicluster-k8s-tests_istio

analyze-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test analyze-tests_istio

release-notes_istio
03bc6403dcd69a6efb5ee0ce3cd5f37ae043f79f
link
/test release-notes_istio

gencheck_istio
03bc6403dcd69a6efb5ee0ce3cd5f37ae043f79f
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-test_istio

integ-security-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-multicluster-k8s-tests_istio

analyze-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test analyze-tests_istio

gencheck_istio
03bc6403dcd69a6efb5ee0ce3cd5f37ae043f79f
link
/test gencheck_istio

release-notes_istio
63cfc3dd6f47334a6d622103eeb4670a485998e5
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-test_istio

integ-security-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-security-k8s-tests_istio

integ-operator-controller-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-operator-controller-tests_istio

integ-ipv6-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-multicluster-k8s-tests_istio

analyze-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test analyze-tests_istio

release-notes_istio
63cfc3dd6f47334a6d622103eeb4670a485998e5
link
/test release-notes_istio

gencheck_istio
63cfc3dd6f47334a6d622103eeb4670a485998e5
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-test_istio

integ-security-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-security-k8s-tests_istio

integ-ipv6-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-ipv6-k8s-tests_istio

integ-telemetry-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-multicluster-k8s-tests_istio

analyze-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test analyze-tests_istio

release-notes_istio
63cfc3dd6f47334a6d622103eeb4670a485998e5
link
/test release-notes_istio

gencheck_istio
63cfc3dd6f47334a6d622103eeb4670a485998e5
link
/test gencheck_istio

unit-tests_istio
63cfc3dd6f47334a6d622103eeb4670a485998e5
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-test_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test release-test_istio

integ-security-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-security-k8s-tests_istio

integ-telemetry-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-telemetry-k8s-tests_istio

integ-multicluster-k8s-tests_istio
2f5b7dcb89926463d203bb9ddacf644c16fd118b
link
/test integ-multicluster-k8s-tests_istio

gencheck_istio
63cfc3dd6f47334a6d622103eeb4670a485998e5
link
/test gencheck_istio

unit-tests_istio
63cfc3dd6f47334a6d622103eeb4670a485998e5
link
/test unit-tests_istio

release-notes_istio
24d3c05e172c328ff574b82a0494d9df60afa0f8
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn @hzxuzhonghu @linsun Thanks for the review! I moved the controller into a separate remotekubeconfigcontroller to watch the isito-kubeconfig secret now and will  guard the mount once we have the externalIstiodflag landed.

/test release-notes_istio

@irisdingbj: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
24d3c05e172c328ff574b82a0494d9df60afa0f8
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@irisdingbj: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@irisdingbj: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
24d3c05e172c328ff574b82a0494d9df60afa0f8
link
/test release-notes_istio

integ-helm-tests_istio
24d3c05e172c328ff574b82a0494d9df60afa0f8
link
/test integ-helm-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This is still required, cc @nikita15p


Updates for gamlerhart: Simpler & Faster

Check List:

[x] Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
[x] All formatting changes by the build are committed
[x] Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
[ ] Output matches that of calculate_average_baseline.sh
[ ] For new entries, or after substantial changes: When implementing custom hash structures, please point to where you deal with hash collisions (line number)

On my 6 core / 12thread laptop

Execution time: 5-6 seconds
Execution time before: 7-8 seconds

For the hash collisions, nothing new, but I never pointed it out:
Its handled in doAdd. There is the loop around the probe counter, which is increased on a non-matching collision.
It probes the map linearly.
Not implemented is any hash-map resizing

PS: Also updates the rounding bugfix.

00:05.705 now.


chore(ci): clean up

Clean rollup config

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


read nimbus config from env variables

I think it's a good idea to to be able to set some of the streamparse configurations in environment variables, instead of config.json file.

Coverage decreased (-0.03%) to 44.444% when pulling 15337cebe0658dc74e10aa8891a72145f1bc3a0c on aminalaee:nimbus_env_config into 6e8c4d891535a83d734419206bc52192e51872b9 on Parsely:master.

Coverage remained the same at 44.472% when pulling 3624d05bc8a797a3ebc533b2324b33b44c40fbe2 on aminalaee:nimbus_env_config into 6e8c4d891535a83d734419206bc52192e51872b9 on Parsely:master.

Coverage decreased (-0.03%) to 44.472% when pulling 66a4b67aebe63fc3a294ed42780526cdc2b8b503 on aminalaee:nimbus_env_config into<PHONE_NUMBER>2ebd4f5e192f22346b48b4ecffb493 on Parsely:master.

Thanks for the PR. I imagine some people will want to add support for more environment variables to override configs in the future.


Feed UI

Cleanup the feed UI

Finished this up (for now) with https://github.com/slashkudos/kudos-web/commit/3c12569b11e630da22a0ce0681169fbb417b62d4


Add vkbasalt package from AUR

This PR adds the vkbasalt package from AUR. vkBasalt is a Vulkan post processing layer to enhance the visual graphics of games, which can be optionally enabled per game. More information about it is here:
https://github.com/DadSchoorse/vkBasalt

This package is failing to build for me right now.
install: cannot stat 'build/libvkbasalt64.so': No such file or directory
==> ERROR: A failure occurred in package().
    Aborting...

Even then, I am unsure about whether we should include this. Is it disabled by default? Does it have any effect on games if it is disabled? I have no experience using this.

@alkazar Yeah, I noticed the same issue. If CXXFLAGS is set in the environment, part of the default in vkBasalt/src/makefile are ignored:
https://aur.archlinux.org/packages/vkbasalt/?O=10&PP=10#comment-727397

Even then, I am unsure about whether we should include this. Is it disabled by default? Does it have any effect on games if it is disabled? I have no experience using this.

I wanted to include it in a PR for consideration, but I'm fine if you wanted to exclude it. By default, vkbasalt is disabled unless you configure the launch options with ENABLE_VKBASALT=1 %command%. You can see the post-processing effects it can provide to games here:
https://www.youtube.com/watch?v=hSlaGkbTRi8


Add back the mistakenly removed SetCurrentClientCertDetails code.

The code added to the sidecar inbound listener in PR #9178 has been removed - mistakenly, I believe - by #9016. Here is the diff.

Thanks to @somcsel for catching this, I included a unit test to catch and prevent this in the future. for more background about this code, see #8263
Signed-off-by: Yangmin Zhu<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: yangminzhu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ostromart
If they are not already assigned, you can assign the PR to them by writing /assign @ostromart in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
927ebee880d127904607f50b0966c3df2f136bc1
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
927ebee880d127904607f50b0966c3df2f136bc1
link
/test e2e-dashboard

prow/istio-pilot-multicluster-e2e.sh
927ebee880d127904607f50b0966c3df2f136bc1
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rshriram Could you review this? Thanks!
/test e2e-dashboard

@GregHanson or @vadimeisenbergibm could you help review this?  Seems reasonable to add it back.

I guess people may be busy with Kubecon this week (and if so have fun!)
I created issue #10395 to make the Ingress Gateway set the full certificate data into the XFCC header and would appreciate your further discussion there.

@rshriram @vadimeisenbergibm Could you review this? Thank you.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rshriram, yangminzhu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

pilot/pkg/networking/OWNERS [rshriram]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
927ebee880d127904607f50b0966c3df2f136bc1
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
927ebee880d127904607f50b0966c3df2f136bc1
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests


sinatra-flash not working with shotgun

See issue at https://github.com/SFEley/sinatra-flash/issues/7
I believe with the versions in your Gemfile it works just as you say, but I had newer versions of everything and it only worked with rackup.
Thanks for the awesome example.

Hi, I believe this issue is still open. I'm experiencing the same problem with flash and shotgun and since your exemple really helped me, i guess it would be neat to have it fixed.
Thanks a bunch and great work!

Hey @JimiSpire and @fetmar I finally fixed this.
I found an answer on StackOverflow and updated the readme and code to make it work.


Fixed the null on name bug in Google OAuth2

The bug was because the user data wasn't being fetched anywhere after logging in from the Firestore but was used in the widget tree, so I have fixed this problem by fetching it on Dashboard.
My github auth code was commented in the latest commit in the master branch, is there any bug in it?

Fixes #275

@rish07 Good and no issues in GitHub Auth, I added the ClIent data in the secret file and added it in gitignore, which is causing issue to the new contributors and with the GitHub Action. as the import is invalid now. If you have a better approach to handle the secrets, I am all ears.

@rish07 Good and no issues in GitHub Auth, I added the ClIent data in the secret file and added it in gitignore, which is causing issue to the new contributors and with the GitHub Action. as the import is invalid now. If you have a better approach to handle the secrets, I am all ears.

@himanshusharma89 sure, I'll reply if I can get a solution.


Threshold now meets criteria

Threshold previously only exceeded criteria, now it can meet or succeed as explained on line 247

Coverage increased (+0.01%) to 91.73% when pulling 6af731e310a636f8941d834bbf3f0cd9638b60a5 on shealavington:patch-1 into 2ccff6a4fde9a975b70975567c2793bdf72d3085 on google:master.

Coverage increased (+0.01%) to 91.73% when pulling 6af731e310a636f8941d834bbf3f0cd9638b60a5 on shealavington:patch-1 into 2ccff6a4fde9a975b70975567c2793bdf72d3085 on google:master.

@googlebot I signed it!

:man_shrugging:

@rowan-m I would consider this some important logic... 🤔

@rowan-m Please update doc-block documentation then as the information provided is invalid, the float must be > threshold.
    /**
     * Provide a threshold to meet or exceed in verify()
     * Threshold should be a float between 0 and 1 which will be tested as response >= threshold.
     *
     * @param float $threshold Expected threshold
     * @return ReCaptcha Current instance for fluent interface
     */


Flutter web+wasm app fails to load when referencing strokeMiterLimit

Steps to reproduce
Create a new blank app:
$ flutter create wasmtest
$ cd wasmtest
$ vim lib/main.dart

Patch lib/main.dart to reference strokeMiterLimit, e.g.:
import 'dart:ui';
// .. snip ..
  @override
  Widget build(BuildContext context) {
    final paint = Paint();
    print('${paint.strokeMiterLimit}');  // Add these lines
    return MaterialApp(
// .. snip

Build:
flutter build web --wasm

Serve the app (e.g. as described at https://docs.flutter.dev/platform-integration/web/wasm#serving-wasm-locally.
Visit the app in Chrome, and observe that the app fails to load, with this message printed in console:
main.dart.mjs:689 Uncaught (in promise)
LinkError: WebAssembly.instantiate(): Import #537 "skwasm" "paint_getMiterLimit": function import requires a callable
    at Module.instantiate (main.dart.mjs:689:38)
    at async f._loadWasmEntrypoint (flutter_bootstrap.js:1:2259)
instantiate	@	main.dart.mjs:689

Expected results
Able to reference strokeMiterLimit in a wasm build.
Actual results
App fails to load and error message is printed to console:
main.dart.mjs:689 Uncaught (in promise)
LinkError: WebAssembly.instantiate(): Import #537 "skwasm" "paint_getMiterLimit": function import requires a callable
    at Module.instantiate (main.dart.mjs:689:38)
    at async f._loadWasmEntrypoint (flutter_bootstrap.js:1:2259)
instantiate	@	main.dart.mjs:689

Code sample
Code sample
import 'package:flutter/material.dart';
import 'dart:ui';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    final paint = Paint();
    print('${paint.strokeMiterLimit}');
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple),
        useMaterial3: true,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

// Rest of example app omitted for brevity.

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[√] Flutter (Channel stable, 3.22.2, on Microsoft Windows [Version 10.0.19045.4529], locale en-US)
    • Flutter version 3.22.2 on channel stable at C:\Users\username\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 761747bfc5 (2 weeks ago), 2024-06-05 22:15:13 +0200
    • Engine revision edd8546116
    • Dart version 3.4.3
    • DevTools version 2.34.3

[√] Windows Version (Installed version of Windows is version 10 or higher)

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\username\AppData\Local\Android\sdk
    X cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    X Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.2.0)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.2.32505.173
    • Windows 10 SDK version 10.0.20348.0

[√] Android Studio (version 2022.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)

[√] VS Code, 64-bit edition (version 1.90.0)
    • VS Code at C:\Program Files\Microsoft VS Code
    • Flutter extension version 3.90.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [Version 10.0.19045.4529]
    • Chrome (web)      • chrome  • web-javascript • Google Chrome 126.0.6478.115
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 120.0.2210.121

[√] Network resources
    • All expected network resources are available.

! Doctor found issues in 1 category.

Hi @tdenniston, it would appear that this has been fixed on the master channel. The app loads just fine with the code changes on the master for me. Can you confirm if this is the same for you as well?

Thanks @danagbemava-nc, tested on the master channel (3.23.0-13.0.pre.292) and it is indeed fixed. Appreciate it!


CoMTask

@Saeed-Mansouri Answering your mc_rtc-related question about the CoMTask:

As you can see below, it seems that this->eval() returns a cross-product of the com error and dimweight.

The corresponding eigen function, cwiseProduct(), is a component-wise product rather than a cross-product. Check out the function documentation for details.

Original issue:

Hi Dr. Caron,
I added a new PositionTask to control pelvis position in the z-direction to have more natural walking. Also, I changed dimweight of CoMTask to {0.5, 1., 0.} and {0., 0., 1.} was set for the new PositionTask. However, I found that the third array of "com" element in the CoMTask of gui didn't change at all. I tried to find that what value returned for "com" element.
void CoMTask::addToGUI(mc_rtc::gui::StateBuilder & gui)
{
  TrajectoryTaskGeneric<tasks::qp::CoMTask>::addToGUI(gui);
  gui.addElement({"Tasks", name_},
                 mc_rtc::gui::Point3D("com_target", [this]() { return this->com(); },
                                      [this](const Eigen::Vector3d & com) { this->com(com); }),
                 mc_rtc::gui::Point3D("com", [this]() { return (this->com() - this->eval()).eval(); }));
}

As you can see below, it seems that this->eval() returns a cross-product of the com error and dimweight. However, I couldn't understand the physical interpretation of this process. I will appreciate it if you could explain it.
template<typename T>
Eigen::VectorXd TrajectoryTaskGeneric<T>::eval() const
{
  if(selectorT_)
  {
    return selectorT_->eval().cwiseProduct(trajectoryT_->dimWeight());
  }
  return errorT->eval().cwiseProduct(trajectoryT_->dimWeight());
}

Thanks for reporting an issue. We are solving a weighted QP, where each task has a given weight. In addition to that, you might want a bit more control, and individually control the weights for each dimesion of a task: this is the role of dimWeight. For instance you can do:
comTask->weight(1000); // comTask has a weight of 1000
comTask->dimWeight({1,1,0.5}; x=1000, y=1000, z=500

mc_rtc::gui::Point3D("com", [this]() { return (this->com() - this->eval()).eval(); }));

I believe the intent here was to avoid the extra cost of computing the CoM twice (once in the Tasks library, and once in mc_rtc wrapper) by subtracting the task error to the current CoM target. Without dimWeight, this would be true, however you are right, and this implementation is wrong when dimWeight != Eigen::VectorXD::Ones()! With this formula, we are only subtracting a percentage of the actual CoM position error, and not the full error.
Below is an example showing the issue with a CoMTask with dimWeight={1,1,0.1}:

Dashed red: CoM computed with robot().com (calling rbd::computeCoM(mb, mbc)
Blue is the CoM computed with this->com() - this->eval()).eval() (which is what we log)

On the right side, I increased the weight of the posture task to ensure that the CoM task would not converge to its target.

We can come up with a simple fix that:

Exposes the computed CoM from Tasks::CoMTask
Uses it in mc_tasks::CoMTask wrapper instead of the current implementation

Nice catch!


[Bug]: Rename "Configure Model Server" to "Add Model Server"

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
In v2.10.0 we introduced the ability to have multiple model servers... this sorta makes the button "Configure model server" awkward when it can lead to "configuring" multiple.
Expected Behavior
Rename the button, the modal and any thing else that might say "configure" to "add".
Steps To Reproduce

Have model serving installed
Create a project
View Model Serving section

Workaround (if any)
No response
What browsers are you seeing the problem on?
No response
Open Data Hub Version
v2.10.0

Anything else
No response

/assign


Remove flags from gwa config set commands

It seems unnecessary and potentially confusing that we support both config set [key] and config set --[key] (as a flag) for all the values you can set.
This results in the internal docs being oddly duplicative:

Fix:

Remove the keys as available flags.
Remove [flags] from example usage.

@ikethecoder are you on board with this change?


Replace AngularJS with VueJS

Using AngularJS would've been really neat, however with the deadline approaching it might be easier to switch to a different framework. VueJS should do nicely.
It's possible we'll switch back to AngularJS once 1.0 Final is out and we start working on 1.1, but that will be discussed on a more appropriate date.

Since getting dialogs working proved to be a little more difficult than I thought, DraiWiki 1.0 is now using jQuery instead.


Remove 0.5 code

Roger's https://github.com/mlcommons/modelbench/pull/747
Barbara's https://github.com/mlcommons/modelbench/pull/743


New Database Object Connection and Privilege Checks added

Hi,
from the feedback of my Beta Testers I made these changes to exasol:
*) new Object Type Connections is now supported
*) added "visibleif" checks to verify the user has sufficient privileges to access the meta tables for users, connections and roles objects.
*) Reformat source using dbeaver formatter
Kind Regards
Karl

Looks good!


Text color issue after update to Compose Material3 version 1.2.0-beta02

Fixed in Compose Material3 version 1.2.0-rc01


Ability to suppress timestamps when useColors is false - maintains backwards compatibility

To provide the option to disable printing of timestamps when userColours is false.  Will maintain the default behaviour if its not set for backwards compatibility.
Reasons for this change have been mentioned in some comments already -  the need to disable the double logging of timestamps in systems that already print timestamps.
https://travis-ci.org/rynmsh/debug

Coverage increased (+2.4%) to 75.155% when pulling ae63f4f908f36fa8c105b843df0c36c6a9f86a93 on rynmsh:master into 13e1d068e9265b2c9a160ba242a6be200b9811f0 on visionmedia:master.

Closing in favor of #582. Please comment there.


core_LogVerbose detrimental to performance even when disabled

Verbose output is handled with calls to core_LogVerbose.  When verbosity is disabled it still requires invoking the function and checking the __SBT_VERBOSE flag (and executing a return).
In small scale it's almost imperceptible, but in larger tests I saw the following times:
No core_LogVerbose lines at all:  32s
core_LogVerbose in place, but disabled:  39s
core_LogVerbose in place, and enabled:  48s
As a performance feature, a script in bin should comment/uncomment these calls entirely.

New testing with 1,000,000 iterations on a single thread of an Intel i7 4790:

With __SBT_VERBOSE=true (output to terminal):  87 micro-seconds per invocation
With __SBT_VERBOSE=true (output to /dev/null):  75 micro-seconds per invocation
With __SBT_VERBOSE=false:  25 micro-seconds per invocation
With false && core_LogVerbose (short-circuit avoidance):  7 micro-seconds per invocation

This shows a performance degradation of ~18 micro-seconds compared to avoiding the function call entirely.  It then shows a performance hit of another 50 micro-seconds if we actually want to run the function (log something).  Finally, another 12 micro-seconds to actually display the output.
Based on the above information it would take approximately 50,000 invocations to result in 1 second of time loss from the performance hit.
For now, this is an acceptable performance hit.  Especially since the user is able to resolve this themselves.  Ultimately, only the user could solve this because the whole loss in the function call.
Marking closed / wontfix.


Description

@AhmedCode99 Hi as you are the maintainer of this homework, I believe you have access to writing on the "About" section of this repository.
In my point of view, it will be good to describe in brief on our HW3G5 repository.

where can i find that?

on the main page of repo.

Done


optimize.root_scalar "converged" to the wrong root

I encountered the following strange error in a calculation and I'm not sure why.
import numpy as np
from scipy.optimize import root_scalar

f = lambda x: 100*np.exp(-0.03*x)
sol = root_scalar(lambda x: f(x)-100, x0=150, x1=75)
assert sol.converged, "Cannot find the root."
sol.root, f(sol.root)-100

Obviously the root is 0, but root_scalar found it to be 150 and thought it had converged. I understand that the choices of x0 and x1 are not optimal, but I'm puzzled why root_scalar thought it had found the root.
Scipy/Numpy/Python version information:
1.6.3 1.20.2 sys.version_info(major=3, minor=9, micro=4, releaselevel='final', serial=0)

Hi @mikeduan, thank you for opening an issue. But this feel more like a question and we don't have the bandwidth for that here. I would suggest to ask on StackOverflow for instance. Still, if there is a bug, feel free to add more information.
As for your issue, the secant method is used when only provided with x0, x1 and a function. The secant method is not guaranteed to converge and in this case the starting points where quite far. I mean, just making a plot of your function and doing the method by hand and it's clear that you're troubling it.

@tupui Thanks for the prompt reply! I'm not sure I would call it a bug, but it certainly surprised me. I thought that the algorithm would have checked if f(root) was indeed close to 0 before setting the converged flag 🙂

True although "close to 0" is very subjective. It converged to the right side due to the shape of the function and your starting points. This is a parametrization issue here.

@tupui Will it be a good idea for root_scalar (and probably root too) to have a ytol option so that the function will only report converged or successful when abs(f(sol.root)) <= ytol if ytol is set? It will simplify some codes and cause fewer surprises.

Why not. I will let optimize maintainers weight in for this. @pvanmulbregt @andyfaff what do you think about this?

@tupui @NuCO-UNM I agree with this suggestion. Please see my proposal for adding fatol (and probably frtol) in https://github.com/scipy/scipy/issues/6379#issuecomment-1364748484.


[HOTFIX] Add both cache and count back to Butterfree

Why? :open_book:
It was necessary to add cache and count back to Butterfree, since some odd behaviour was observed after their removal.
What? :wrench:
Added both cache and count back.

What kinds of odd behaviors start to happen? Just curious about it, maybe I can help

What kinds of odd behaviors start to happen? Just curious about it, maybe I can help

There's an obvious impact which is the increase in time to compute the pipeline since we removed cache. The odd behaviours are the following: for some pipelines validation was breaking due to an empty dataframe or difference between count of lines, however this was not happening for all pipelines, just for some. Besides, we forgot to remove all actions, as it's possible to see here.


Conf rework

A more sensible scheme for auto-guessing configuration and overriding where necessary.
This still requires docs and tests; posting now for any comments.

Notice that commits history looks a bit ... odd. Will clean at merge time.

@quasiben : I am trying to make the way to provide configuration parameters to hdfs3 and knit much more straight forwards. In fact, I am considering having knit depend on hdfs3.
What do you think of the scheme here? It needs docs, but the idea is to take values from

xml files in locations given by environment variables, or typical locations, or local dir (in that order); also sets LIBHDFS3_CONF if anything was found, before the .so is imported. If no file was found anywhere, you get {'host': 'localhost', 'port': 8020}.
xml file explicitly passed to hdfs3.conf.hdfs_conf()
direct editing of hdfs3.conf.conf, which is the dict made automatically
dict of values passed to the constructor (looks like produced by hdfs3.conf.conf_to_dict())
key/values passed in the constructor to override specific values (port=None)

If autoconf=False, the first three steps are skipped. In this case, if you don't pass at least host=, you get an error, not even the default localhost.

This looks really good.  I do have one question, when would a user edit hdfs3.conf.conf vs configuring with the constructor?
Also, I can see why you would want to share this bit of config code with knit but I would advise against it unless you see knit doing more things with hdfs3 on the python side rather than raw hdfs calls on the jvm side

edit hdfs3.conf.conf vs configuring with the constructor

Perhaps so that it can be done once in a setup script and then it persists in the global without having to send the parameter again? It could be a possibility that doesn't get mentioned in the doc if you think it's confusing.
Another thought on this: the import of the .so could be delayed until a HDFileSystem tries to connect, giving more opportunity to do any editing, and allowing import of hdfs3 without the risks of forking.
Question: some users probably do HDFileSystem(host, port) without keywords; do you think I should accept a 2-element *args to account for the possibility?
On hdfs3 in knit: I already reference it here to only upload environments if required. I am thinking that hdfs3's ability to generate hdfs delegation tokens may be the best way to get around permission issues, although the scala client can presumably do that too (if it somehow gets ticket caches etc., from the default config files).