Problems to re-resynchronize one channel after updating to 0.12.0-beta.rc6

Background
Updated to lnd 0.12.0-beta.rc6. After this I have problems to re-resynchronize one channel to node01.fulmo.org
Your environment
lnd 0.12.0-beta.rc6
Linux 5.10.5-v8+ #1392 SMP PREEMPT Sat Jan 9 18:56:30 GMT 2021 aarch64 GNU/Linux
bitcoind 0.21
Tor version <IP_ADDRESS>-rc
everything proxied over tor
Steps to reproduce
Have a channel to node01.fulmo.org. Updated to lnd 0.12.0-beta.rc6. Start LND
Expected behaviour
Channel should re-resynchronize
Actual behaviour
Channel does not re-resynchronize
Tell us what happens instead
LND reports error during synchronisation. Log shows following:
2021-01-23 10:49:27.812 [INF] SRVR: Established connection to: 024a8228d764091fce2ed67e1a7404f83e38ea3c7cb42030a2789e73cf3b341365@<IP_ADDRESS>:9735
2021-01-23 10:49:27.812 [INF] SRVR: Finalizing connection to 024a8228d764091fce2ed67e1a7404f83e38ea3c7cb42030a2789e73cf3b341365@<IP_ADDRESS>:9735, inbound=false
2021-01-23 10:49:27.818 [INF] PEER: Legacy channel open with peer: 024a8228d764091fce2ed67e1a7404f83e38ea3c7cb42030a2789e73cf3b341365, downgrading static remote required feature bit to optional
2021-01-23 10:49:27.904 [INF] PEER: NodeKey(024a8228d764091fce2ed67e1a7404f83e38ea3c7cb42030a2789e73cf3b341365) loading ChannelPoint(XXXXXXXXXXXXXXXX:0)
2021-01-23 10:49:27.906 [INF] HSWC: Removing channel link with ChannelID(XXXXXXXXXXXXXXXX)
2021-01-23 10:49:27.906 [INF] HSWC: ChannelLink(XXXXXX:1241:0): starting
2021-01-23 10:49:27.906 [INF] HSWC: Trimming open circuits for chan_id=XXXXXX:1241:0, start_htlc_id=110
2021-01-23 10:49:27.906 [INF] HSWC: Adding live link chan_id=XXXXXXXXXXXXXXXX, short_chan_id=XXXXXX:1241:0
2021-01-23 10:49:27.906 [INF] CNCT: Attempting to update ContractSignals for ChannelPoint(XXXXXXXXXXXXXXXX:0)
2021-01-23 10:49:27.906 [INF] PEER: Negotiated chan series queries with 024a8228d764091fce2ed67e1a7404f83e38ea3c7cb42030a2789e73cf3b341365
2021-01-23 10:49:27.906 [INF] HSWC: ChannelLink(XXXXXX:1241:0): HTLC manager started, bandwidth=XXXXXXXXXXXXXXXX mSAT
2021-01-23 10:49:27.907 [INF] HSWC: ChannelLink(XXXXXX:1241:0): attempting to re-resynchronize
2021-01-23 10:49:27.961 [INF] PEER: unable to read message from 024a8228d764091fce2ed67e1a7404f83e38ea3c7cb42030a2789e73cf3b341365@<IP_ADDRESS>:9735: EOF
2021-01-23 10:49:27.961 [INF] PEER: disconnecting 024a8228d764091fce2ed67e1a7404f83e38ea3c7cb42030a2789e73cf3b341365@<IP_ADDRESS>:9735, reason: read handler closed
2021-01-23 10:49:28.061 [INF] HSWC: Removing channel link with ChannelID(XXXXXXXXXXXXXXXX)
2021-01-23 10:49:28.062 [INF] HSWC: ChannelLink(XXXXXX:1241:0): stopping
2021-01-23 10:49:28.062 [WRN] HSWC: ChannelLink(XXXXXX:1241:0): error when syncing channel states: link shutting down
2021-01-23 10:49:28.062 [INF] HSWC: ChannelLink(XXXXXX:1241:0): exited

See my comment in #4941: https://github.com/lightningnetwork/lnd/issues/4941#issuecomment-768005048
The fulmo node is so old, that it doesn't understand a new safety feature created to make recovery of channel funds in a disaster scenario easier.

See my comment in #4941: https://github.com/lightningnetwork/lnd/issues/4941#issuecomment-768005048
The fulmo node is so old, that it doesn't understand a new safety feature created to make recovery of channel funds in a disaster scenario easier.


Button functionality

Add JS code so that text pops up when the mouse passes over the first button.

Are you going to add this button functionality for all the buttons? If so, let's make more dynamic scroll() and clear() functions by passing in the elementId and innerText.


⚠ Bofrost.be has degraded performance

In 74881d5, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2837 ms

Resolved: Bofrost.be performance has improved in c9fb83d.


Zoneminder: Fixed undefined index error

Description:
Error with zoneminder camera monitors.
17-04-28 00:04:21 DEBUG (Thread-1) [homeassistant.components.camera.zoneminder] Updating camera state for monitor 2
17-04-28 00:04:21 ERROR (MainThread) [homeassistant.helpers.entity] Update for camera.front_door fails
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/helpers/entity.py", line 225, in async_update_ha_state
    None, self.update)
  File "uvloop/future.pyx", line 230, in __iter__ (uvloop/loop.c:110600)
  File "uvloop/future.pyx", line 432, in uvloop.loop.BaseTask._fast_wakeup (uvloop/loop.c:113980)
  File "uvloop/future.pyx", line 101, in uvloop.loop.BaseFuture._result_impl (uvloop/loop.c:108900)
  File "/usr/local/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/src/app/homeassistant/components/camera/zoneminder.py", line 110, in update
    if status_response['success'] is False:
KeyError: 'success'

Related issue (if applicable):
fixes #7260

Hi @bah2830,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Are you sure "success" is the correct string?  When I GET the URL "api/monitors/alarm/id:%i/command:status.json" this is the response I receive:
{'status': '0'}
I'm using ZoneMinder 1.30.0.

@duffrecords you may be correct. I didn't change the existing check as I'm unable to get my zoneminder's api to respond to that call and confirm if the check is even valid to begin with, which is why I found the issue. My zoneminder returns a 404 to that call so I was getting exceptions filling up my logs.

What version of zoneminder. This fixed exceptions on older versions.
Get Outlook for iOShttps://aka.ms/o0ukef

From: Brent Hughes<EMAIL_ADDRESS>Sent: Friday, May 5, 2017 5:47:58 AM
To: home-assistant/home-assistant
Cc: Sytone; Mention
Subject: Re: [home-assistant/home-assistant] Zoneminder: Fixed undefined index error (#7340)
@duffrecordshttps://github.com/duffrecords you may be correct. I didn't change the existing check as I'm unable to get my zoneminder's api to respond to that call and confirm if the check is even valid to begin with, which is why I found the issue. My zoneminder returns a 404 to that call so I was getting exceptions filling up my logs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/home-assistant/home-assistant/pull/7340#issuecomment-299455548, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABVak0sPehvVc3lfPBDXo9f6DSuy7g56ks5r2xp-gaJpZM4NK6Pu.

@duffrecords is correct

What version of zoneminder. This fixed exceptions on older versions.

This "fixed" exceptions (I intentionally didn't support 2 year old ZM with major security holes) by adding a condition which is never true therefore breaking the whole point of that code.

I'm using version 1.30.2 and like @duffrecords that api call returns {"status": "0"} for me so I don't ever expect success to be a property returned.


Bleak Exception on macOS BigSur (M1)

Running the provided example file on an M1 mac running Big Sur, I am getting the following exception:
Traceback (most recent call last):
  File "/Users/omi/Workspaces/TAPPlayground/example.py", line 1, in <module>
    from tapsdk import TapSDK, TapInputMode
  File "/opt/homebrew/lib/python3.9/site-packages/tapsdk/__init__.py", line 10, in <module>
    from tapsdk.backends.macos.TapSDK import TapMacSDK as TapSDK
  File "/opt/homebrew/lib/python3.9/site-packages/tapsdk/backends/macos/TapSDK.py", line 8, in <module>
    from bleak import BleakClient
  File "/opt/homebrew/lib/python3.9/site-packages/bleak/__init__.py", line 54, in <module>
    raise BleakError("Bleak requires the CoreBluetooth Framework")
bleak.exc.BleakError: Bleak requires the CoreBluetooth Framework

I looked over at bleak's issues to see if this was a problem with their support for BigSur and found this thread. Tried installing a higher version of bleak(0.10.0) than what is required by tap (0.5.1), but as expected ran into conflicts as it looks like that version is not backwards compatible.
Traceback (most recent call last):
  File "/Users/omi/Workspaces/TAPPlayground/example.py", line 1, in <module>
    from tapsdk import TapSDK, TapInputMode
  File "/opt/homebrew/lib/python3.9/site-packages/tapsdk/__init__.py", line 10, in <module>
    from tapsdk.backends.macos.TapSDK import TapMacSDK as TapSDK
  File "/opt/homebrew/lib/python3.9/site-packages/tapsdk/backends/macos/TapSDK.py", line 10, in <module>
    from bleak.backends.corebluetooth.discovery import discover
ModuleNotFoundError: No module named 'bleak.backends.corebluetooth.discovery'

Using bleak==0.9.1 as recommended in that thread yields this
Traceback (most recent call last):
  File "/Users/omi/Workspaces/TAPPlayground/example.py", line 1, in <module>
    from tapsdk import TapSDK, TapInputMode
  File "/opt/homebrew/lib/python3.9/site-packages/tapsdk/__init__.py", line 10, in <module>
    from tapsdk.backends.macos.TapSDK import TapMacSDK as TapSDK
  File "/opt/homebrew/lib/python3.9/site-packages/tapsdk/backends/macos/TapSDK.py", line 11, in <module>
    from bleak.backends.corebluetooth import CBAPP as cbapp
ImportError: cannot import name 'CBAPP' from 'bleak.backends.corebluetooth' (/opt/homebrew/lib/python3.9/site-packages/bleak/backends/corebluetooth/__init__.py)

Using bleak==0.9.1 as recommended in that thread yields this
Traceback (most recent call last):
  File "/Users/omi/Workspaces/TAPPlayground/example.py", line 1, in <module>
    from tapsdk import TapSDK, TapInputMode
  File "/opt/homebrew/lib/python3.9/site-packages/tapsdk/__init__.py", line 10, in <module>
    from tapsdk.backends.macos.TapSDK import TapMacSDK as TapSDK
  File "/opt/homebrew/lib/python3.9/site-packages/tapsdk/backends/macos/TapSDK.py", line 11, in <module>
    from bleak.backends.corebluetooth import CBAPP as cbapp
ImportError: cannot import name 'CBAPP' from 'bleak.backends.corebluetooth' (/opt/homebrew/lib/python3.9/site-packages/bleak/backends/corebluetooth/__init__.py)

I am getting the same error with bleak requiring the CoreBluetooth Framework using the macOS Tap-strapSDK. Have you had any progress fixing this issue?

Na. I dug into this a bit but hit a wall. Ended up using a spare raspberry pi for tap development.
The linux environment worked well without any hiccups.

Okay, thanks ill try linux

@omkarkarande
The sdk was updated to support the latest bleak release (0.12.1).
Please take a look at release 0.5.0 and see if it resolves your issue.

closing due to inactivity


EOFError: Ran out of input

Getting an error in iam_dataset.py file in this line:
df = pickle.load(open(fn, 'rb'))

What is the error message?

df = pickle.load(open(fn, 'rb'))
EOFError: Ran out of input
This is the error message sir

I believe this happens when the jupyter notebook does not download the IAM dataset correctly.
To mitigate this, delete everything in dataset/iam-database then run the following in your terminal.
from ocr.utils.iam_dataset import IAMDataset
test = IAMDataset("form_original", train=False)

After this has completed, you should be able to run the rest of the notebook.

Thank u... It works


empty bodies are valid in testset

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   76.81%   76.81%
=======================================
  Files           6        6
  Lines         509      509
=======================================
  Hits          391      391
  Misses        114      114
  Partials        4        4

Impacted Files
Coverage Δ

src/tr1d1um/conversion_utils.go
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61aca0a...ba92c46. Read the comment docs.

@shilpa24balaji I just added the unit tests for cases like {}


Inconsistent decoding

Your crate decodes some keys into DecodedKey::RawKey objects. The enum that you provide containing keys has a Backspace variant, but, using QEmu as my example, a backspace is decoded into unicode U+0008, and as a DecodedKey::Unicode.

That's because I understood 0x08 to be the ASCII value for Backspace, like 0x09 is the ASCII value for Tab. I only used DecodedKey::RawKey when there wasn't a clear mapping to an ASCII (or Unicode) value (e.g. there's no ASCII or even Unicode value corresponding to the Windows key). If you'd rather have raw key events (i.e. the KeyCode enum you mention that includes KeyCode::Backspace, plus an indication of whether the key was pressed or released), you can avoid calling process_keyevent and handle the key events yourself.

Then can we remove the Backspace variant of the enum, as it is not used, and only use ASCII Backspace

It is used if you take KeyEvents and don't decode them.
I can see your point though. I could create a new enum called UndecodableKeys or something. It would include Home, PageUp, etc, but not A, +, or Backspace. You can then match exhaustively without overlaps.


RStudio version is out of date

The current RStudio version is pinned at 1.2.5042 but the latest is 1.4.
https://github.com/SwissDataScienceCenter/renkulab-docker/blob/7df1a7204497439b1c934248804fdacad94ab1b5/docker/r/Dockerfile#L33

There are a few nice upgrades, for example using renv instead of packrat as the default package manager.

The fix would need testing.

There does not yet seem to be a reliable fix - but it is a (well) known issue now: see
https://github.com/2i2c-org/external/issues/12

If you want to use RStudio 1.4.x, you need to set the RSESSION_PROXY_RSTUDIO_1_4 environment variable. This adds additional parameters to the execution of server.

https://github.com/jupyterhub/jupyter-rsession-proxy

there is soon going to be a release of jupyter-rsession-proxy to fix the issue with RStudio1.4, see jupyterhub/jupyter-rsession-proxy#97 and jupyterhub/jupyter-rsession-proxy#107


[tomlplusplus] Add new port

Describe the pull request
This PR adds a port for the tomlplusplus library.
Furthermore, as tomlplusplus installs a CMake configuration file generated by meson, it also fixes the vcpkg_fixup_cmake_targets function  to correctly deal with CMake configuration files generated by meson, see https://github.com/mesonbuild/meson/issues/6955 for more info.

What does your PR fix?
Fix https://github.com/microsoft/vcpkg/issues/10667 .

Which triplets are supported/not supported? Have you updated the CI baseline?
I would expect all the triplets to work fine, so I think it is not necessary to update the CI baseline.

Does your PR follow the maintainer guide?
Yes

fyi @marzer @GiulioRomualdi

Oh, nice! @traversaro any chance you could update this PR to sync with the current HEAD of toml++? I've been doing some bugfixing and maintenance stuff over the last few days that I've just locked in as minor release v1.2.3.

Oh, nice! @traversaro any chance you could update this PR to sync with the current HEAD of toml++? I've been doing some bugfixing and maintenance stuff over the last few days that I've just locked in as minor release v1.2.3.

Done! For reference, unless there are some changes in the build system, updating to a new version is just a matter of update the version in the CONTROL and portfile.cmake files, and the hash in the portfile.cmake file.

@traversaro Nice, thanks for the info!

/azp run

/azp run

/azp run

@traversaro Thanks for your PR!
tomlplusplus installation failed in following triplets:
arm-uwp
arm64-windows
x64-uwp
x64-linux
x64-osx
Is this result expected? If yes, could you please update the vcpkg/scripts/ci.baseline.txt; if not, could you please fix this issue?

That is indeed not expected, at least x64-linux was tested explicitly and it was working fine, I will check the CI logs.

@Cheney-W I tried the port for x64-linux locally on Ubuntu 18.04 and it works fine. How can I get the artifacts with the log error? They seem not to be available in https://dev.azure.com/vcpkg/c1ee48cb-0df2-4ab3-8384-b1df5a79fe53/_build/results?buildId=34726 .

@traversaro You could get the log with following steps:

Thanks @Cheney-W ! The x64-linux failure message is:
-- Downloading https://github.com/marzer/tomlplusplus/archive/v1.2.3.tar.gz...
-- Extracting source /ci/myagent/_work/3/s/downloads/marzer-tomlplusplus-v1.2.3.tar.gz
-- Using source at /ci/myagent/_work/3/s/buildtrees/tomlplusplus/src/v1.2.3-915b44652d
CMake Error at scripts/cmake/vcpkg_find_acquire_program.cmake:340 (message):
  Could not find meson.  Please install it via your package manager:

      sudo apt-get install meson
Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_meson.cmake:94 (vcpkg_find_acquire_program)
  ports/tomlplusplus/portfile.cmake:9 (vcpkg_configure_meson)
  scripts/ports.cmake:90 (include)

So I guess this is something that should be addressed on the CI machine, if you think it is not feasible I will mark  x64-linux`  as a a failing triplet.

@traversaro
I tried to install tomlplusplus in my side, and I got the following error after installed meson, I used Ubuntu 18.04.4 LTS (GNU/Linux 5.0.0-1036-azure x86_64)
vcpkg/buildtrees/tomlplusplus/config-x64-linux-dbg-out.log:
The Meson build system
Version: 0.45.1
Source dir: vcpkg/buildtrees/tomlplusplus/src/v1.2.3-915b44652d
Build dir: vcpkg/buildtrees/tomlplusplus/x64-linux-dbg
Build type: native build
meson_options.txt:1:0: ERROR: Unknown type feature.
A full log can be found at vcpkg/buildtrees/tomlplusplus/x64-linux-dbg/meson-logs/meson-log.txt

vcpkg/buildtrees/tomlplusplus/x64-linux-dbg/meson-logs/meson-log.txt:
Build started at 2020-04-30T06:01:55.176244
Main binary: /usr/bin/python3
Python system: Linux
The Meson build system
Version: 0.45.1
Source dir: vcpkg/buildtrees/tomlplusplus/src/v1.2.3-915b44652d
Build dir: vcpkg/buildtrees/tomlplusplus/x64-linux-dbg
Build type: native build
meson_options.txt:1:0: ERROR: Unknown type feature.

@Cheney-W meson needs to be version 0.47 or higher
(See https://mesonbuild.com/Build-options.html)

In that case, probably indeed it  make sense to mark x64-linux as unsupported (at least for the CI) and mark it as supported when the CI gets updated to use Ubuntu 20.04 .

@traversaro
About x64-linux, I agree to add tomlplusplus:x64-linux=fail to vcpkg/scripts/ci.baseline.txt.
About other failed triplets, could you please fix them?

@traversaro
About x64-linux, I agree to add tomlplusplus:x64-linux=fail to vcpkg/scripts/ci.baseline.txt.
About other failed triplets, could you please fix them?

Sorry for the delay. I checked the other triplets and they seems to be failing due to missing support for cross-compilation in https://github.com/microsoft/vcpkg/blob/5deea3b975fe62990973d73a102de818d83ba20c/scripts/cmake/vcpkg_configure_meson.cmake . I would soon look into that and either fix it or add them to the list of expected failures.

@Cheney-W for the time being I just explicitly disabled the unsupported platforms,  and the relative issues are:

https://github.com/microsoft/vcpkg/issues/11230
https://github.com/microsoft/vcpkg/issues/6645

As on Linux the port can be successfully installed if you have a recent  meson (for example if you  are on a recent distro or you installed meson via pip) I added it to the ci.baseline.txt, but i did not explicitly disabled build on  Linux via vcpkg_fail_port_install .

@traversaro Thanks for your reply!
Could you please add linux into vcpkg_fail_port_install first? You could add some comments about the meson issue in linux before the vcpkg_fail_port_install line. And we will remove linux from vcpkg_fail_port_install once the issue https://github.com/microsoft/vcpkg/issues/11230 and https://github.com/microsoft/vcpkg/issues/6645 is fixed.
BTW, could you please add Supports into the control file?

@traversaro Thanks for your reply!
Could you please add linux into vcpkg_fail_port_install first? You could add some comments about the meson issue in linux before the vcpkg_fail_port_install line. And we will remove linux from vcpkg_fail_port_install once the issue #11230 and #6645 is fixed.
BTW, could you please add Supports into the control file?

Done in https://github.com/microsoft/vcpkg/commit/ddf14285c401a8c396f1ab8a4cc683f2344bf549 .

/azp run

Blocked by CI issue, there is  PR: https://github.com/microsoft/vcpkg/pull/11545 trying to fix this issue.

Blocked by CI issue, there is PR: #11545 trying to fix this issue.

Thanks!

I may be wrong, but the CI failures seems not to be related with this PR.

I rebased the PR on the latest master, and updated it to the latest tomlplusplus release 1.3.0 ( https://github.com/marzer/tomlplusplus/releases/tag/v1.3.0 ).

x64_osx CI faiilure seems to be unrelated to the content of the PR.

/azp run

/azp run

/azp run

@BillyONeal
qwt:x64-windows failed due to download the source failed, I have tested it in my local machine and it could be installed successfully.
So could you please help remove the tomstone of qwt?

Yeah, sorry, I wanted to have a solution that let you target individual hashes for this before the end of the day today but ran out of time (I'm almost asleep as I type this). For now you can push a commit that changes https://github.com/microsoft/vcpkg/blob/250e35a961f6faea691e2266613e671a61bb3ab6/scripts/azure-pipelines/azure-pipelines.yml#L7 to true (and then remove it before merging) or queue a prbuild that does that in the web interface.

/azp run

/azp run

I have no idea about what is going on, but thanks a lot @Cheney-W @BillyONeal for the work!

It looks like your 'meson related workaround' breaks other ports.

@BillyONeal what're the chances of the linux build servers getting a newer version of meson, per https://github.com/microsoft/vcpkg/pull/10786#issuecomment-621695450?

@BillyONeal what're the chances of the linux build servers getting a newer version of meson, per #10786 (comment)?

If someone contributes an edit to provison-image.ps1 that does it, the VM will eventually be updated with it

Sorry, I meant .sh: https://github.com/microsoft/vcpkg/blob/master/scripts/azure-pipelines/linux/provision-image.sh

Ah, thanks. That seems pretty straight-forward. I might do that myself.

It looks like your 'meson related workaround' breaks other ports.

Thanks for the feedback, I look into this in the next days.

It looks like your 'meson related workaround' breaks other ports.

Thanks for the feedback, I look into this in the next days.

Do you have any indication on the ports that are broken? I looked in the CI logs, but most ports seems to be failing due to a GitHub HTTP response error, see:
-- Downloading https://github.com/fmtlib/fmt/archive/19bd751020a1f3c3363b2eb67a039852f139a8d3.tar.gz...
-- Downloading https://github.com/fmtlib/fmt/archive/19bd751020a1f3c3363b2eb67a039852f139a8d3.tar.gz... Failed. Status: 22;"HTTP response code said error"

Do you have any indication on the ports that are broken? I looked in the CI logs, but most ports seems to be failing due to a GitHub HTTP response error, see:
-- Downloading https://github.com/fmtlib/fmt/archive/19bd751020a1f3c3363b2eb67a039852f139a8d3.tar.gz...
-- Downloading https://github.com/fmtlib/fmt/archive/19bd751020a1f3c3363b2eb67a039852f139a8d3.tar.gz... Failed. Status: 22;"HTTP response code said error"

Hmm admittedly I didn't look closely at most of the results, I just noticed that there are more failures than would be normally explained by transient network issues.

Do you have any indication on the ports that are broken? I looked in the CI logs, but most ports seems to be failing due to a GitHub HTTP response error, see:
-- Downloading https://github.com/fmtlib/fmt/archive/19bd751020a1f3c3363b2eb67a039852f139a8d3.tar.gz...
-- Downloading https://github.com/fmtlib/fmt/archive/19bd751020a1f3c3363b2eb67a039852f139a8d3.tar.gz... Failed. Status: 22;"HTTP response code said error"

Hmm admittedly I didn't look closely at most of the results, I just noticed that there are more failures than would be normally explained by transient network issues.

I triggered a re-build, and the amount of failed ports decreased, so I guess they were failing  for a reason unrelated to the PR.
There are still some failures, but as far as I can see they seems to be unrelated to the PR.

FYI: https://github.com/microsoft/vcpkg/pull/12224

There are still some failures, but as far as I can see they seems to be unrelated to the PR.

I rebased on the top of the latest master to check if this CI port failures are consistent or not.

The arm_uwp build is failing because the
The error is:
CMake Error at C:/agent/_work/1/s/scripts/buildsystems/vcpkg.cmake:405 (_find_package):
  Could not find a package configuration file provided by "ryml" with any of
  the following names:

    rymlConfig.cmake
    ryml-config.cmake

  Add the installation prefix of "ryml" to CMAKE_PREFIX_PATH or set
  "ryml_DIR" to a directory containing one of the above files.  If "ryml"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  CMakeLists.txt:132 (find_package)

and it seems unrelated to this PR.

@traversaro It's repeatable on rerun and bitserializer uses vcpkg_fixup_cmake_targets which you're editing here.

@traversaro It's repeatable on rerun and bitserializer uses vcpkg_fixup_cmake_targets which you're editing here.

I  will look into that, but it seems unlikely that the vcpkg_fixup_cmake_targets of bitserializer call influences that failure, that is happening in the previous  command of the portfile. It could be nevertheless caused by one use of  vcpkg_fixup_cmake_targets  in one of its dependencies. However, at a first glance it seems that there is something strange happening to the ci.baseline.txt file in https://github.com/microsoft/vcpkg/pull/10786/commits/fa0e518059abf2dd9ed08bdef0c7ed43f417fbf8, that list all lines as modified, probably an artifact of some merge/rebase.

However, at a first glance it seems that there is something strange happening to the ci.baseline.txt file in fa0e518, that list all lines as modified

That indeed looks messed up and is another reason this isn't ready to merge.

Hi @LilyWangL , thanks for resolving the conflicts. I see that the CI is now passing, but I don't know if all that changes in ci.baseline.txt were intentional or not.

@traversaro
All that changes in ci.baseline.txt are not intentional , because ci.baseline.txt recent have a lot of changes, we just merge the master version to your branch.

@traversaro
All that changes in ci.baseline.txt are not intentional , because ci.baseline.txt recent have a lot of changes, we just merge the master version to your branch.

Thanks, I will cleanup the ci.baseline.txt then.

@traversaro  You don't need to do anything, now you just have to wait for this PR to be merged.

@Cheney-W It seems your editor is trying to change the line endings on ci.baseline.txt causing every line to be edited...

Looks like the original line endings on ci.baseline.txt is LF, but after applied the suggestion commit, It becomes CRLF.

/azp run

I merged the branch with master.

@traversaro FYI: https://github.com/marzer/tomlplusplus/releases/tag/v2.0.0
(I'm unlikely to make another release for a decent while since I have other things I need to catch up on)

@traversaro FYI: https://github.com/marzer/tomlplusplus/releases/tag/v2.0.0
(I'm unlikely to make another release for a decent while since I have other things I need to catch up on)

Thanks. To be honest I was trying to get this through as it is, and then once it goes through just do a PR with the new release, that should have much less spurious CI problems, as what is making the CI for this PR so flaky is that it includes a modification to vcpkg_fixup_cmake_targets.cmake, that triggers a re-build of ~600/700 ports.

Yeah that's fair. I'm happy to do the v2.0.0 PR myself once this one goes through.

The CI is now failing with a few magnum-plugins failures, I do not know if it is related but hopefully those will be fixed by https://github.com/microsoft/vcpkg/pull/12458 .

/azp run

Thanks a lot @strega-nil !

Thanks to you @traversaro :)


Terminal move to right button is missing

VSCode Version: 1.29.1
OS Version: Linux

Steps to Reproduce:

Open VS Code
Open Terminal
[,|] button to move to right (or to bottom) is not there.

Does this issue occur when all extensions are disabled?: Yes

+1

@faultfactory you can use workbench.action.togglePanelPosition and bind it to a keyboard shortcut.


Build and maintain a stand-alone AR button that can be used separately from

Feature Request:
Provide the ability to launch directly to SceneViewer as a link from any element, rather than embedding the entire Model Viewer on the page. (Similar to how iOS AR Quick Look works).
For example, support the ability to have an HTML href element that can link straight into SceneViewer.
Benefits:

Model preview doesn't need to be loaded unless user really wants to view it, so less bandwidth consumed.
Reduces amount of space required on page.
Easier to integrate into existing pages that might not have the space or need for an embedded 3D model.

👍 thanks for the feature request!
I agree, I think there is room in this space for an <model-button> element of some kind that does this. To throw in my own two cents: I think it would be cool if such a button could also load <model-viewer> as a fallback (if desired) in the case that Quick Look or Scene Viewer are not available.
It would be pretty easy to implement such a magic button (especially if you borrowed some of the code in our project). That said, I'm not sure that this behavior belongs in <model-viewer> in particular. I would almost want it to be a separate web component that lives in parallel with <model-viewer>.
Just some thoughts :) thanks again for the request!

Good food for thought. Thanks. I see what you mean about this could be a separate web component to <model-viewer>. Makes sense.

Note that you can "hack" that right now already by having javascript auto-click the AR button after it's available.
If you click on this link on a supported mobile device it will bring you right into AR on iOS and Android:
https://infinitygames-kids-galicnik.glitch.me/
Or (and that's how we're actually using it) scan this QR Code:

Downside of course is that a) it will still load the GLB file into browser memory b) on iOS you get the double hit with GLB + USDZ. Upside is the aforementioned fallback, unsupported devices will just display the model-viewer model.

Note that you can "hack" that right now already by having javascript auto-click the AR button after it's available.

I hacked it to dispatch a click event onto the "default-ar-button" but android crashed everytime about a fullscreen request. Could you explain how you got around that?

@drewwiskus to fix the error you need to include the Fullscreen API polyfill, see https://github.com/GoogleWebComponents/model-viewer/blob/master/POLYFILLS.md
But, I can also tell you that you are seeing that because Scene Viewer is failing to launch. A common reason for this is that models are required to be hosted on a secure https origin (and localhost does not work). Let me know if changing that helps!

I needed this for one of my projects, and decided to quickly implement a component for this: https://leoncvlt.github.io/ar-button/
I would love to contribute to model-viewer and have this as part of the package but after looking at the source for a bit I sadly figured my typescript knowledge is not up to task yet 🙃Might have to dedicate a few weekends to that.

This is fairly easy now, and the multiple downloads is solved with WebXR.


Update to starter colab notebook for lm-eval-harness

There has been a refactor of lm-eval-harness a few months ago. The starter colab notebook for lm-eval-harness, linked to from this section has to be slightly updated to reflect this.
Instead of
!python lm-evaluation-harness/main.py \
    --model gpt2 \
    --tasks truthfulqa_gen \
    --device 0

we have
!lm-eval --model hf --model_args pretrained=EleutherAI/Pythia-70m --tasks truthfulqa_gen --device 0

thanks, I'd be glad if you submitted a PR!

thanks, I'd be glad if you submitted a PR!

will do that!


app2luggage.rb fails

When trying to create a package on 10.9.5 for Prizmo 2 with the command line
sudo app2luggage.rb --application "/Applications/Prizmo.app" --package-id "Prizmo 2"  --reverse-domain com.creaceed.prizmo2
I get
/System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- ftools (LoadError)
    from /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/lib/ruby/2.0.0/rubygems/core_ext/kernel_require.rb:55:in `require'
    from /usr/local/bin/app2luggage.rb:30:in `<main>'

Thanks!

The issue you are having is because you are using the macOS supplied ruby and running as sudo will point to that. As of right now I'm running macOS 10.12.3 and I have it working just fine. All I did was install Ruby for my account and is the preferred method. Just follow this guide on how to get setup: Ruby Setup macOS
After that you will need to most likely install additional gems. The gems I installed were trollop & ftools. Once I had this the dependancies went away and app2luggage worked fine. You won't need to run this elevated at this point since everything is configured under your account. Hope this helps out.


Renamed and Improved Product File

Changed the name of Product.JS file to Product.JSON
Removed , after every description from Product.Json file

@JasonDsouza212 Please check this.


wireplumber 0.5.1 / pipewire 1.0.5

I know you're busy but, I just wanted to ping and ask if it was possible to update pipewire / wireplumber to the recent versions. Especially wireplumber has very useful fixes for bluetooth profile switching.
Thanks!

Yes I will do this weekend.

If it isnt too much trouble could you enable for kubuntu/ubuntu 24.04?

@the-nic  Done. Please sync

@souravdas142 ,
Not pushing, just curious about Pipewire 1.2x and libcamera 0.3.x. I'm interested in this because Linux 6.10 includes an Intel IPU6 Driver for modern web cameras.
Thank you for your work!


refactor: loans cleanup

This will affect metadata, meaning clients may get subxt errors

I was considering this but I'm not sure whether we can just set the market state to "Pending" instead, when we want to halt the market. Good to check with a test.

I was considering this but I'm not sure whether we can just set the market state to "Pending" instead, when we want to halt the market. Good to check with a test.

I didn't think about the possibility of wanting the halt the market, but to be fair halting is not possible with the current code anyway, right? Barring a raw storage write

Not really a prio right now, better not to change things needlessly rn


[REQUEST]The input sequences must be in the same length when using pipeline parallelism for all batches?

When the input sequences are variable length, the tensor between pipeline stage is cut to a shape same as the first batch data's shape

I see

Hi， is there any answer to the issue?


Add option to include severity in table output

Add an optional --include-severity flag to include a severity column when using table or markdown output, when severity is present in the OSV schema.

Sure, test added.
From an end user perspective, it would be useful to also have the numeric score computed in the same column, for a quicker overview. Let me know if this sounds good.

Thanks for working on this @giovanni-bozzano!
Unfortunately we want to be very careful with what we add to the table output as we want to keep the horizontal width down, and also keep the number of CLI flags limited.
Converting CVSS:3.1/AV:L/AC:L/PR:N/UI:N/S:U/C:L/I:L/A:L into a single numeric score will help, but it also loses a decent amount of information.
A more long term solution is to create a markdown/text based output format, which is more suitable for adding additional information like severity info, fixed versions...etc, We are currently developing this as part of #57, currently estimated to be completed this quarter.
For now a workaround would be to parse the json output to get the severity value.

Discussed this a bit more with the team, something similar to this could work showing only the computed scores in the table, and only showing the full string (or a subset of it) in the text output I was describing above so if the user wants more info they can get it.
We can use https://github.com/goark/go-cvss to compute the score relatively easily, if you can replace the current full severity string with just the score it would be great!

Thanks for the change! Agreed with adding to the documentation to clarify that this is the base severity score.
I think now that it's reasonably short, we can remove the include-severity flag and just always show the severity column. (Does mean a couple of the tests in main_test.go will need to be updated)

CC @hayleycd to see where we can fit this in our current docs.

I removed the flag and renamed the column to "CVSS". Tests have been changed accordingly.

So what determines if the severity score is CVSS v2 or CVSS v3? (Clarifying so I can update the docs)

Inside each OSV entry the severity looks like this:
  "severity": [
    {
      "type": "CVSS_V3",
      "score": "CVSS:3.1/AV:N/AC:H/PR:L/UI:R/S:U/C:H/I:H/A:H"
    }
  ],

The type field shows what version is used, currently the schema defines only two options, v3 and v2: https://ossf.github.io/osv-schema/#severity-field
As for why you would choose one over the other I think it's just newer advisories use cvss v3, and older ones use v2.

So there is nothing specific to this code, it will just pull the cvss (whether version 2 or 3) from the OSV entry?

Yep


Add encryption to SACC file

Related to #58
Add encryption and decryption functionalities for SACC files.

Encryption and Decryption:

Add generate_encryption_key, encrypt_data, and decrypt_data methods in src/smokescreen/datavector.py.
Modify save_concealed_datavector method to encrypt the SACC file before saving.
Add decrypt_sacc_file function in src/smokescreen/datavector.py.

Main Function:

Update main function in src/smokescreen/__main__.py to handle encryption and decryption.
Add decrypt, encrypted_file_path, and encryption_key_path arguments to the main function.

Tests:

Add tests for generate_encryption_key, encrypt_data, and decrypt_data methods in tests/test_datavector.py.
Add tests for the modified save_concealed_datavector method.
Add tests for decrypt_sacc_file function.

Documentation:

Add a section in docs/source/usage.rst to document the encryption and decryption functionalities.

Dependencies:

Add cryptography as a dependency in pyproject.toml and environment.yml.

Needs testing if the Fernet lib actually works with sacc!

For more details, open the Copilot Workspace session.

There are some unecessary files generated by the test with copilot spaces that should be removed before mergning

pytest results:
FAILED tests/test_datavector.py::test_save_concealed_datavector - AttributeError: 'Sacc' object has no attribute 'to_fits'. Did you mean: 'load_fits'?
FAILED tests/test_datavector.py::test_decrypt_sacc_file - AttributeError: type object 'Sacc' has no attribute 'from_fits'

Unsure if we can actually encrypt a fits file with this library. Maybe we need to encrypt the data instead. Needs further investigation.


1.0 fix: undef in array creation

Fix for 1.0. This adds undef to empty array constructors.

CI fail seems to be unrelated.

In my eyes this should be merged as fast as possible, followed by tagging a new release so that things work for people on 1.0.


nw.js 0.13 compatibility

Quick question for ya, since I can't seem to find any info on the matter.
Does this support building with nw.js 0.13 or will support for that be added once it comes out of beta? I am looking to upgrade a node app I am working on to 0.13 but need to be sure I can still build executables.
Thanks! :)

Hey!
As it stands, there isn't support for nw.js 0.13.0 in Web2Exe. I was waiting for 0.13.X to come out of beta, but feel free to file a feature request issue for nw.js 0.13.X support and I might be able to integrate it earlier :)

Thank you for your quick response. Hopefully I filed the request correct and I look forward to 0.13 support. You have a great program here. :)


Compatible with Iron Router 1.0+

Update to work with newer versions of Iron Router.
IronLocation.set is deprecated - changed to Iron.Location.go

Cool on the Iron.Location.go.
I'm 99% certain the onRun should stay an onRun. I actually had an issue open over on iron-router. Why do you think it should be onBeforeAction?

Yeah, I don't think that's supposed to be there. I'll amend that.

I take back my last statement. I tried using onRun instead of onBeforeAction, and it seems that using onRun causes whatever post you edit first to always be the post you get taken to when trying to edit any other post afterwards. Here's a quick demo showing that Session.get("postId") does not update to match @params.id:


fix Disable scan sharing for NAAJ

Proposed changes
Issue Number: close #xxx

run buildall

run buildall

run buildall

run buildall


Implement SIMD detection on macOS-gcc; complain if no SIMD detection

Verified that this compiles and runs on macOS El Capitan with homebrew gcc. I don't believe clang compiles at the moment so not sure if it works for that.
Also added an #error if SIMD checking is missing. Autotools already causes configure to fail if there is no SIMD implementation, so if Makefiles are generated something is wrong.

Also added an #error if SIMD checking is missing.

This is not the desired behavior. There is (slow) fallback function that runs when no simd is found. This #else code will prevent its execution.

Autotools already causes configure to fail if there is no SIMD implementation

Are you sure? This should not happen.

I don't believe clang compiles at the moment so not sure if it works for that.

If you can test with clang on macOS and report issues, if any, please do it.

I looked into what compilers provide the __get_cpuid() built-in intrinsic - GCC (including mingw) and clang. Microsoft's compiler has an equivalent named __cpuid(). It doesn't matter what OS we're running on, so after establishing we're on x86, it's better to check for the compiler than exhaustive list all platforms. I changed it to reflect this.
I believe the #error should stand. Code that lacks an implementation for a specific compiler should be a build error. This should be better than silently building an inferior tesseract. In any case only compilers outside of GCC, clang, mingw, Microsoft C++ and Intel C++ (which behaves like GCC on Linux and Microsoft on Windows) should hit the #error so anything left is quite rare.

@stweil, what are your thoughts on this?

I think the patch is good and only requires a small clean-up (removing the __MINGW32__ test).
It builds fine with clang on macOS.
I also suggest to squash all commits before applying them.

I'm stuck without a full dev environment for a few days and can't do this
easily. I support the change @stweil proposed if anyone else wants to do
it.
On Sat, Jan 21, 2017 at 03:50 Stefan Weil<EMAIL_ADDRESS>wrote:

@stweil requested changes on this pull request.
In arch/simddetect.cpp
https://github.com/tesseract-ocr/tesseract/pull/661#pullrequestreview-17805561
:

@@ -26,7 +26,7 @@
#endif // x86 target

#if defined(X86_BUILD)
-# if defined(linux) || defined(MINGW32)
+# if defined(GNUC) || defined(MINGW32)
Testing GNUC is sufficient, as MinGW also uses gcc, so the test for
MINGW32 can be removed.
In arch/simddetect.cpp
https://github.com/tesseract-ocr/tesseract/pull/661#pullrequestreview-17805561
:

SIMDDetect::SIMDDetect() {
#if defined(X86_BUILD)
-# if defined(linux) || defined(MINGW32)
+# if defined(GNUC) || defined(MINGW32)

Here the test for MINGW32 can also be removed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/tesseract-ocr/tesseract/pull/661#pullrequestreview-17805561,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABvcM6qnB-Jkgoh25PwsvTfrWJMBWYnmks5rUfD9gaJpZM4Lje3X
.

@jbarlow83, is this commit fine for you? If yes, I'd make a pull request for it. I kept the original date and you as the author.

Looks good. Thanks.
On Mon, Jan 23, 2017 at 04:45 Stefan Weil<EMAIL_ADDRESS>wrote:

@jbarlow83 https://github.com/jbarlow83, is this commit
https://github.com/stweil/tesseract/commit/fa677f1ba183c6265fb11a14328dca6b8dd34368
fine for you? If yes, I'd make a pull request for it. I kept the original
date and you as the author.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/tesseract-ocr/tesseract/pull/661#issuecomment-274479222,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABvcM2_5wQaMJ4kFW1pKXi54dIC6kYjYks5rVKDWgaJpZM4Lje3X
.


[Bug]: > Component > Bottom Sheet

Prerequisites

[X] I have searched the backlog for duplicate or closed feature requests

Your test device
iPhone 13
OS Version
16.5
App version
0.12.0 QUALIF
Describe the issue
On the expanding bottom sheet, when you open launch the component via the button the 'Close' text button in the left side of the navigation bar is displayed in the native iOS colour blue, for both themes, in light and dark mode.
Expected Behavior
The 'Close' text button in the left side of the navigation bar should be displayed in the colour orange for Orange theme.


grafana-purafa-flasharray-overview.json v1.0.3 updates

Several minor updates:

Fixes Issue#51 where table utilisation gauge does not reflect percentage value
Changes Pure Storage logo for one which works for both light and dark modes
Fixed inconsistency with some colour formatting
Shortened some table column names to fit column widths

Updates to README.md to reflect latest tested software versions.

Fixes Issue #51


Delete target pools and forwarding rules with -q in guestbook.sh

Without -q gcloud prompts for confirmation before deleting rules, failing the e2e suite on local runs. This PR also adds checks for a default compute/region setting, without which gcloud will fail even with -q because it doesn't know which region to use.

PTAL


⚠ Turnos 24x7 has degraded performance

In 3f6d59d, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 2795 ms

Resolved: Turnos 24x7 performance has improved in e5fcfbd.


Add default look of PersonCard when there is no Nok details available

resolves #44

Codecov Report

Merging #45 (9e8231f) into master (e85e0f1) will decrease coverage by 6.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master      #45      +/-   ##
============================================
- Coverage     72.15%   66.12%   -6.04%
  Complexity      399      399
============================================
  Files            70       73       +3
  Lines          1232     1343     +111
  Branches        125      143      +18
============================================
- Hits            889      888       -1
- Misses          311      422     +111
- Partials         32       33       +1

Impacted Files
Coverage Δ

.../java/seedu/address/logic/commands/NokCommand.java
0.00% <0.00%> (ø)

.../seedu/address/logic/parser/AddressBookParser.java
88.88% <0.00%> (-11.12%)
:arrow_down:

...a/seedu/address/logic/parser/NokCommandParser.java
0.00% <0.00%> (ø)

src/main/java/seedu/address/model/person/Nok.java
0.00% <0.00%> (ø)

...c/main/java/seedu/address/model/person/Person.java
91.11% <0.00%> (-6.51%)
:arrow_down:

src/main/java/seedu/address/ui/PersonCard.java
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 651047d...9e8231f. Read the comment docs.


PitchShift

Feature request: PitchShift effect, i.e. that could be applied to an input source / media element source node. If you ever have time for it, this would be awesome!

Yes this would be amazing!

This would be amazing, but i really don't know how i could accomplish this with the current Web Audio API and high performance / no ScriptProcessorNode philosophy of Tone.
I'm going to close this and we can potentially reopen it when the AudioWorker node arrives and this might seem more feasible.
For now, you can pitch shift samples, but this is simple playbackrate pitch shifting and not really full-blown pitch shifting.


Please add license for clarity (suggesting MIT here..)

Great library.  For most it would be helpful to declare a license - I have proposed MIT for simplicity here but its your call of course.

Thanks @AppleWatchHipster  I think MIT license fits perfect here.


Error: VipsOperation: class "icc_transform" not found

When converting from CMYK images, I'm getting this:

2015-04-29T19:49:51.349Z - debug: Image metadata format=jpeg, width=400, height=200, space=cmyk, channels=4, hasProfile=false, hasAlpha=false
2015-04-29T19:49:51.368Z - warn: Error response Error: VipsOperation: class "icc_transform" not found
at Error (native)

sharp v0.10.0, Node.js v0.12.2, ImageMagick 6.8.9, vips 7.40.2.
Any suggestions?

My best guess is that libvips was compiled without LCMS support - see https://github.com/jcupitt/libvips/#lcms2-lcms

That solved it!  Thanks.


Can't use Let’s Encrypt certificate

I run Open Distro for Elasticsearch in Docker container with Docker compose.
When I mount self-signed certificates and CA, Elasticsearch works as expected.
When I mount Let’s Encrypt certificates, I get errors:
[2019-05-22T15:33:17,757][ERROR][c.a.o.s.s.DefaultOpenDistroSecurityKeyStore] [es01] Your keystore or PEM does not contain a key. If you specified a key password, try removing it. If you did not specify a key password, perhaps you need to if the key is in fact password-protected. Maybe you just confused keys and certificates.
...
Caused by: org.elasticsearch.ElasticsearchSecurityException: Error while initializing transport SSL layer from PEM: java.lang.IllegalArgumentException: File does not contain valid private key: /usr/share/elasticsearch/config/node-key.pem
...
Caused by: java.lang.IllegalArgumentException: File does not contain valid private key: /usr/share/elasticsearch/config/node-key.pem

Kibana as well as test Nginx and Apache containers work fine with the same pem files.
Here are some validations to show that certificates are fine.
Openssl verify returns OK:
openssl verify -verbose -CAfile lets_root_chain.pem fullchain.pem
fullchain.pem: OK

lets_root_chain.pem is a concatenation of isrgrootx1.pem.txt (ISRG Root X1 (self-signed)) and letsencryptauthorityx3.pem.txt (Let’s Encrypt Authority X3 (Signed by ISRG Root X1)).
fullchain.pem and privkey.pem are the pair:
openssl x509 -noout -modulus -in fullchain.pem | openssl md5
openssl rsa -noout -modulus -in privkey.pem | openssl md5
(stdin)= 8e3628a899bce3a92471e5c99dcbc62c
(stdin)= 8e3628a899bce3a92471e5c99dcbc62c

I've tried both wildcard and single host certificates. And of course the key has no password.
elasticsearch.yml
...
# Transport layer TLS
opendistro_security.ssl.transport.pemcert_filepath: node-cert.pem
opendistro_security.ssl.transport.pemkey_filepath: node-key.pem
opendistro_security.ssl.transport.pemtrustedcas_filepath: root-ca.pem
opendistro_security.ssl.transport.enforce_hostname_verification: false

# REST layer TLS
opendistro_security.ssl.http.enabled: true
opendistro_security.ssl.http.pemcert_filepath: node-cert.pem
opendistro_security.ssl.http.pemkey_filepath: node-key.pem
opendistro_security.ssl.http.pemtrustedcas_filepath: root-ca.pem
...

docker-compose.yml
...
    volumes:
      - es-data01:/usr/share/elasticsearch/data
      - ./elasticsearch.yml:/usr/share/elasticsearch/config/elasticsearch.yml
      - ./internal_users.yml:/usr/share/elasticsearch/plugins/opendistro_security/securityconfig/internal_users.yml
      - ${SSL_CERT}:/usr/share/elasticsearch/config/node-cert.pem
      - ${SSL_KEY}:/usr/share/elasticsearch/config/node-key.pem
      - ${SSL_CA}:/usr/share/elasticsearch/config/root-ca.pem
...

.env:
SSL_CA=./lets_root_chain.pem
SSL_CERT=./fullchain.pem
SSL_KEY=./privkey.pem

reporting same issue.

Something I ran into with TLS is that ODFE doesn't support some format of certificates. I'm not sure if Lets's Encrypt will support this format for the server key.
IMPORTANT: Convert these to PKCS#5 v1.5 to work correctly with the JDK. Output from
this command will be used in all the config files.
https://aws.amazon.com/blogs/opensource/add-ssl-certificates-open-distro-for-elasticsearch/

reporting same issue.

Same problem for cfssl on EC PRIVATE KEY

Facing the same issue

same problem with ssl cert (rsa-4096) generated with cfssl

installed standalone security plugin to ECK image, met the same problem with ECK generated self-signed certs

Facing the same issue, with letsencrypt as well comodo certificates. Verified the cert manually on SSL verify which shows success. mean while container failed to pass healthcheck
Caused by: org.elasticsearch.ElasticsearchSecurityException: Error while initializing transport SSL layer from PEM: java.lang.IllegalArgumentException: File does not contain valid certificates: /usr/share/elasticsearch/config/elk-crt.pem
at com.amazon.opendistroforelasticsearch.security.ssl.DefaultOpenDistroSecurityKeyStore.initSSLConfig(DefaultOpenDistroSecurityKeyStore.java:364) ~[?:?]
at com.amazon.opendistroforelasticsearch.security.ssl.DefaultOpenDistroSecurityKeyStore.(DefaultOpenDistroSecurityKeyStore.java:164) ~[?:?]
at com.amazon.opendistroforelasticsearch.security.ssl.OpenDistroSecuritySSLPlugin.(OpenDistroSecuritySSLPlugin.java:207) ~[?:?]
at com.amazon.opendistroforelasticsearch.security.OpenDistroSecurityPlugin.(OpenDistroSecurityPlugin.java:223) ~[?:?]
at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?]
at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) ~[?:?]
at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?]
at java.lang.reflect.Constructor.newInstance(Constructor.java:490) ~[?:?]
at org.elasticsearch.plugins.PluginsService.loadPlugin(PluginsService.java:605) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.plugins.PluginsService.loadBundle(PluginsService.java:556) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.plugins.PluginsService.loadBundles(PluginsService.java:471) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.plugins.PluginsService.(PluginsService.java:163) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.node.Node.(Node.java:339) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.node.Node.(Node.java:266) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.bootstrap.Bootstrap$5.(Bootstrap.java:212) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:212) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:333) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:159) ~[elasticsearch-6.7.1.jar:6.7.1]
... 6 more
Caused by: java.lang.IllegalArgumentException: File does not contain valid certificates: /usr/share/elasticsearch/config/elk-crt.pem
at io.netty.handler.ssl.SslContextBuilder.keyManager(SslContextBuilder.java:265) ~[?:?]
at io.netty.handler.ssl.SslContextBuilder.forServer(SslContextBuilder.java:90) ~[?:?]
at com.amazon.opendistroforelasticsearch.security.ssl.DefaultOpenDistroSecurityKeyStore.buildSSLServerContext(DefaultOpenDistroSecurityKeyStore.java:747) ~[?:?]
at com.amazon.opendistroforelasticsearch.security.ssl.DefaultOpenDistroSecurityKeyStore.initSSLConfig(DefaultOpenDistroSecurityKeyStore.java:351) ~[?:?]
at com.amazon.opendistroforelasticsearch.security.ssl.DefaultOpenDistroSecurityKeyStore.(DefaultOpenDistroSecurityKeyStore.java:164) ~[?:?]
at com.amazon.opendistroforelasticsearch.security.ssl.OpenDistroSecuritySSLPlugin.(OpenDistroSecuritySSLPlugin.java:207) ~[?:?]
at com.amazon.opendistroforelasticsearch.security.OpenDistroSecurityPlugin.(OpenDistroSecurityPlugin.java:223) ~[?:?]
at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?]
at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) ~[?:?]
at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?]
at java.lang.reflect.Constructor.newInstance(Constructor.java:490) ~[?:?]
at org.elasticsearch.plugins.PluginsService.loadPlugin(PluginsService.java:605) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.plugins.PluginsService.loadBundle(PluginsService.java:556) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.plugins.PluginsService.loadBundles(PluginsService.java:471) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.plugins.PluginsService.(PluginsService.java:163) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.node.Node.(Node.java:339) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.node.Node.(Node.java:266) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.bootstrap.Bootstrap$5.(Bootstrap.java:212) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:212) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:333) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:159) ~[elasticsearch-6.7.1.jar:6.7.1]
... 6 more
Caused by: java.security.cert.CertificateException: found no certificates in input stream
at io.netty.handler.ssl.PemReader.readCertificates(PemReader.java:98) ~[?:?]
at io.netty.handler.ssl.PemReader.readCertificates(PemReader.java:64) ~[?:?]
at io.netty.handler.ssl.SslContext.toX509Certificates(SslContext.java:1071) ~[?:?]
at io.netty.handler.ssl.SslContextBuilder.keyManager(SslContextBuilder.java:263) ~[?:?]
at io.netty.handler.ssl.SslContextBuilder.forServer(SslContextBuilder.java:90) ~[?:?]
at com.amazon.opendistroforelasticsearch.security.ssl.DefaultOpenDistroSecurityKeyStore.buildSSLServerContext(DefaultOpenDistroSecurityKeyStore.java:747) ~[?:?]
at com.amazon.opendistroforelasticsearch.security.ssl.DefaultOpenDistroSecurityKeyStore.initSSLConfig(DefaultOpenDistroSecurityKeyStore.java:351) ~[?:?]
at com.amazon.opendistroforelasticsearch.security.ssl.DefaultOpenDistroSecurityKeyStore.(DefaultOpenDistroSecurityKeyStore.java:164) ~[?:?]
at com.amazon.opendistroforelasticsearch.security.ssl.OpenDistroSecuritySSLPlugin.(OpenDistroSecuritySSLPlugin.java:207) ~[?:?]
at com.amazon.opendistroforelasticsearch.security.OpenDistroSecurityPlugin.(OpenDistroSecurityPlugin.java:223) ~[?:?]
at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[?:?]
at jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) ~[?:?]
at jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[?:?]
at java.lang.reflect.Constructor.newInstance(Constructor.java:490) ~[?:?]
at org.elasticsearch.plugins.PluginsService.loadPlugin(PluginsService.java:605) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.plugins.PluginsService.loadBundle(PluginsService.java:556) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.plugins.PluginsService.loadBundles(PluginsService.java:471) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.plugins.PluginsService.(PluginsService.java:163) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.node.Node.(Node.java:339) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.node.Node.(Node.java:266) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.bootstrap.Bootstrap$5.(Bootstrap.java:212) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.bootstrap.Bootstrap.setup(Bootstrap.java:212) ~[elasticsearch-6.7.1.jar:6.7.1]
at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:333) ~[elasticsearch-6.7.1.jar:6.7.1]

Same issue here. I was following this guide, end up with

io.netty.handler.codec.DecoderException: javax.net.ssl.SSLHandshakeException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target

Same issue here. I was following this guide, end up with

io.netty.handler.codec.DecoderException: javax.net.ssl.SSLHandshakeException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target

Please provide full stack trace here.

Please provide full stack trace here.

Sorry, full stack trace is gone. I changed certificate file permissions and the error was gone. I'm not 100% sure that the problem was with permissions.
I use Docker, certificates folder is binded from host machine. I end up with a+rx permissions for the certificates folder, not sure if they are too open. I also tried o+rx, but I got

Exception in thread "main" org.elasticsearch.bootstrap.BootstrapException: java.nio.file.AccessDeniedException: /usr/share/elasticsearch/config/my-certificates-folder
Likely root cause: java.nio.file.AccessDeniedException: /usr/share/elasticsearch/config/my-certificates-folder
at java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:90)
at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111)
at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:116)
at java.base/sun.nio.fs.UnixFileAttributeViews$Basic.readAttributes(UnixFileAttributeViews.java:55)
at java.base/sun.nio.fs.UnixFileSystemProvider.readAttributes(UnixFileSystemProvider.java:149)
at java.base/sun.nio.fs.LinuxFileSystemProvider.readAttributes(LinuxFileSystemProvider.java:99)
at java.base/java.nio.file.Files.readAttributes(Files.java:1840)
at java.base/java.nio.file.FileTreeWalker.getAttributes(FileTreeWalker.java:225)
at java.base/java.nio.file.FileTreeWalker.visit(FileTreeWalker.java:276)
at java.base/java.nio.file.FileTreeWalker.next(FileTreeWalker.java:373)
at java.base/java.nio.file.Files.walkFileTree(Files.java:2837)
at org.elasticsearch.common.logging.LogConfigurator.configure(LogConfigurator.java:220)
at org.elasticsearch.common.logging.LogConfigurator.configure(LogConfigurator.java:129)
at org.elasticsearch.bootstrap.Bootstrap.init(Bootstrap.java:354)
at org.elasticsearch.bootstrap.Elasticsearch.init(Elasticsearch.java:170)
at org.elasticsearch.bootstrap.Elasticsearch.execute(Elasticsearch.java:161)
at org.elasticsearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:86)
at org.elasticsearch.cli.Command.mainWithoutErrorHandling(Command.java:127)
at org.elasticsearch.cli.Command.main(Command.java:90)
at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:126)
at org.elasticsearch.bootstrap.Elasticsearch.main(Elasticsearch.java:92)

After that I went a+rx, and there were warnings like

[WARN ][c.a.o.s.OpenDistroSecurityPlugin] [node1] Directory /usr/share/elasticsearch/config/my-certificates-folder has insecure file permissions (should be 0700)
[WARN ][c.a.o.s.OpenDistroSecurityPlugin] [node1] Directory /usr/share/elasticsearch/config/my-certificates-folder/another-folder has insecure file permissions (should be 0700)
[WARN ][c.a.o.s.OpenDistroSecurityPlugin] [node1] Directory /usr/share/elasticsearch/config/my-certificates-folder/another-folder/domain.com has insecure file permissions (should be 0700)
[WARN ][c.a.o.s.OpenDistroSecurityPlugin] [node1] File /usr/share/elasticsearch/config/my-certificates-folder/another-folder/domain.com/fullchain1.pem has insecure file permissions (should be 0600)

Same issue here when using step-ca which defaults to using ECDSA keys.
/cc @mikemaxey @maraino @dopey

/cc @mikemaxey @maraino @dopey for an option on step ca certificate to choose the private key format?

@QuingKhaos I've added an issue for this some time ago https://github.com/smallstep/cli/issues/387, and now I think we should be providing PKCS#8 keys by default.

Just encase anyone else experiencing this basically 2 issues with LE certs and opendistro-es
First is private key type: Fix is:
  privateKey:
    encoding: PKCS8

Second is the lack of ca.crt in cert-manager LE secrets.  This can be worked around by setting the ...CASubPath: tls.crt technically at this point to my understand your validating the cert is the cert vs it signed by the ISRG Root X1 but it does allow es to start with LE certs and then those certs be externally valid in the browser.
Full Example
elastic-example-com.yaml
---
apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
  name: elastic-example-com
  namespace: elastic
spec:
  commonName: elastic.example.com
  dnsNames:
  - 'elastic.example.com'
  privateKey:
    encoding: PKCS8
  secretName: elastic-example-com-tls
  issuerRef:
    name: letsencrypt
    kind: ClusterIssuer

values.yml
---
elasticsearch:
  ssl:
    transport:
      enabled: true
      existingCertSecret: elastic-example-com-tls
      existingCertSecretCertSubPath: tls.crt
      existingCertSecretKeySubPath: tls.key
      existingCertSecretRootCASubPath: tls.crt
...
...
    opendistro_security.nodes_dn:
      - 'CN=elastic.example.com'
...

Maybe it will help someone to setup Let's Encrypt on Opensearch host:

Convert privkey to pkcs8 format:

openssl pkcs8 -topk8 -nocrypt -in privkey.pem -out privkey-pkcs8.pem

Check what identrust signed it:

openssl x509 -noout -subject   -in chain.pem

In my case result was:
subject=C = US, O = Let's Encrypt, CN = R3

Download CA pem key (it is available here: https://letsencrypt.org/certificates/ ) - my was R3:

curl -SL https://letsencrypt.org/certs/isrgrootx1.pem > isrgrootx1.pem

Set proper configuration in opensearch.yml

plugins.security.ssl.transport.pemcert_filepath: /usr/share/opensearch/config/certs/fullchain.pem
plugins.security.ssl.transport.pemkey_filepath: /usr/share/opensearch/config/certs/privkey-pkcs8.pem
plugins.security.ssl.transport.pemtrustedcas_filepath: /usr/share/opensearch/config/certs/isrgrootx1.pem
plugins.security.ssl.http.pemcert_filepath: /usr/share/opensearch/config/certs/fullchain.pem
plugins.security.ssl.http.pemkey_filepath: /usr/share/opensearch/config/certs/privkey-pkcs8.pem
plugins.security.ssl.http.pemtrustedcas_filepath: /usr/share/opensearch/config/certs/isrgrootx1.pem

Do not forget to change/replace admin_dn param. You can check the value by typing:

openssl x509 -subject -nameopt RFC2253 -noout -in fullchain.pem | sed 's/subject= //g' | sed 's/subject=//g'

then add/replace it to the opensearch.yml file:
plugins.security.authcz.admin_dn:
  - CN=mydomain.com

@danpawlik
I am trying to do the same but it is not working, even with your description.
I got my Let's Encrypt cert files via the cert-manager in a kubernetes cluster.
Since it is not working there, I tried to get it running in a docker-compose where I copied the certificate files (tls.crt and tls.key) to.
But even locally I have a mistake in my config.
Can you explain what is part of the fullchain.pem and chain.pem ?

@danpawlik
I am trying to do the same but it is not working, even with your description. I got my Let's Encrypt cert files via the cert-manager in a kubernetes cluster. Since it is not working there, I tried to get it running in a docker-compose where I copied the certificate files (tls.crt and tls.key) to. But even locally I have a mistake in my config.
Can you explain what is part of the fullchain.pem and chain.pem ?

fullchain.pem is a concatenation of cert.pem and chain.pem in one file. and chain.pem contains the intermediate certificate.
Maybe it is worth to try if its working with container deploy and then try on k8s.
You can use 'ansible-role-elastic-recheck' role available on softwarefactory-project.io.

Thank you, then my two files are correct.
Is it important that only the root-ca is in the file set to: pemtrustedcas_filepath?
I'm currently trying to set it up with the certs from k8s in a docker-compose.
Tried different settings, but I will try yours next.
Here is the link to the Post:
https://discuss.opendistrocommunity.dev/t/k8s-define-ssl-certificates-via-secrets/7523/17?u=skunz


[QUERY] Use ArmClient with sovereign cloud

Library name and version
Azure.ResourceManager 1.0.0-beta.7
Query/Question
We need to manually specify endpoint in 3 different place in order to switch ArmClient to sovereign cloud (AzureChinaCloud, etc.)
var credential = new AzureCliCredential(new AzureCliCredentialOptions { AuthorityHost = AzureAuthorityHosts.AzureChina});
var resourceManagerEndpoint = "https://management.chinacloudapi.cn";
var armClient = new ArmClient(new Uri(resourceManagerEndpoint), tokenCredential, new ArmClientOptions{ Scope = resourceManagerEndpoint});

Is this the correct way to do this?
Are there any class like Microsoft.Azure.Management.ResourceManager.Fluent.AzureEnvironment which help user handle all the endpoint?
Environment
No response

Thank you for your feedback.  Tagging and routing to the team member best able to assist.

I found a related issue which already has a PR for it.
https://github.com/Azure/azure-sdk-for-net/issues/26635

yes, this will be supported soon

@hachiang-msft The change has been applied in latest Azure.ResourceManager: https://www.nuget.org/packages/Azure.ResourceManager/


Feature: Allow Sprite to be a circle

Drawing and collision done.
Closes #317.

Awesome feedback all around. I figured there were going to be deeper parts of the system that needed to be touched, thank you for laying it all out so nicely!

Looking into these points, I wonder if it may be easier to use width and height throughout like the current objects and only check for radius in draw and collision and maybe keep it updated.

Possibly as a first pass that might be OK. Without the GameObject handling the radius, any collision checks that involve scale would be off. But I can take care of that in another PR if you just want to add the initial work of letting a sprite have radius and drawing a circle instead of a square.

@crhallberg Do you need any help with the pr?

I'm just busy at the moment. I'll take a look soon and let you know!

Didn't hear back from you, so went ahead and did the work in a differnet pr.
Completed in https://github.com/straker/kontra/pull/404


Won't build under latest anaconda under windows

Building wheels for collected packages: ujson, rcssmin, rjsmin
Running setup.py bdist_wheel for ujson: started
Running setup.py bdist_wheel for ujson: finished with status 'error'
Complete output from command C:\Users\Administrator\Anaconda2\python.exe -u -c "import setuptools, tokenize;file='c:\users\admini~1\appdata\local\temp\pip-build-j41vlk\ujson\setup.py';exec(compile(getattr(tokenize, 'open', open)(file).read().replace('\r\n', '\n'), file, 'exec'))" bdist_wheel -d c:\users\admini~1\appdata\local\temp\tmpqnczdlpip-wheel- --python-tag cp27:
running bdist_wheel
running build
running build_ext
building 'ujson' extension
error: Microsoft Visual C++ 9.0 is required (Unable to find vcvarsall.bat). Get it from http://aka.ms/vcpython27

Failed building wheel for ujson
Running setup.py clean for ujson
Running setup.py bdist_wheel for rcssmin: started
Running setup.py bdist_wheel for rcssmin: finished with status 'error'
Complete output from command C:\Users\Administrator\Anaconda2\python.exe -u -c "import setuptools, tokenize;file='c:\users\admini~1\appdata\local\temp\pip-build-j41vlk\rcssmin\setup.py';exec(compile(getattr(tokenize, 'open', open)(file).read().replace('\r\n', '\n'), file, 'exec'))" bdist_wheel -d c:\users\admini~1\appdata\local\temp\tmplg5r3xpip-wheel- --python-tag cp27:
running bdist_wheel
running build
running build_py
creating build
creating build\lib.win-amd64-2.7
copying .\rcssmin.py -> build\lib.win-amd64-2.7
running build_ext
building '_rcssmin' extension
error: Microsoft Visual C++ 9.0 is required (Unable to find vcvarsall.bat). Get it from http://aka.ms/vcpython27

Failed building wheel for rcssmin
Running setup.py clean for rcssmin
Running setup.py bdist_wheel for rjsmin: started
Running setup.py bdist_wheel for rjsmin: finished with status 'error'
Complete output from command C:\Users\Administrator\Anaconda2\python.exe -u -c "import setuptools, tokenize;file='c:\users\admini~1\appdata\local\temp\pip-build-j41vlk\rjsmin\setup.py';exec(compile(getattr(tokenize, 'open', open)(file).read().replace('\r\n', '\n'), file, 'exec'))" bdist_wheel -d c:\users\admini~1\appdata\local\temp\tmpr0igptpip-wheel- --python-tag cp27:
running bdist_wheel
running build
running build_py
creating build
creating build\lib.win-amd64-2.7
copying .\rjsmin.py -> build\lib.win-amd64-2.7
running build_ext
building '_rjsmin' extension
error: Microsoft Visual C++ 9.0 is required (Unable to find vcvarsall.bat). Get it from http://aka.ms/vcpython27

Failed building wheel for rjsmin
Running setup.py clean for rjsmin
Failed to build ujson rcssmin rjsmin
Installing collected packages: setuptools, Django, django-admin-bootstrapped, django-appconf, Pillow, pilkit, django-imagekit, django-bootstrap-markdown, django-bootstrap-markdown-editor, django-bootstrap-tags, django-bootstrap3, rcssmin, rjsmin, django-compressor, django-contrib-comments, sqlparse, django-debug-toolbar, markdown, django-markdown, django-markupfield, django-pagedown, django-password-strength, django-xmlrpc, django-pingback, django-taggit, pygments, colored-traceback, nanomsg, netifaces, ujson, pymongo, python-gflags
Found existing installation: setuptools 20.2.2
Cannot remove entries from nonexistent file c:\users\administrator\anaconda2\lib\site-packages\easy-install.pth
You are using pip version 8.1.0, however version 8.1.1 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.
Administrator@DESKTOP-AQAAUP8 MINGW64 ~/Documents/python/qblog (master)

installing   http://aka.ms/vcpython27 and running from the repective visual studio command line seems to have fixed it.


proposal: Go 2: Add a new operator to pass error between calls.

Go Programming Experience
Experienced
Other Languages Experience
Go, C, Scala, Kotlin
Related Idea

[ ] Has this idea, or one like it, been proposed before?
[ ] Does this affect error handling?
[ ] Is this about generics?
[ ] Is this change backward compatible? Breaking the Go 1 compatibility guarantee is a large cost and requires a large benefit

Has this idea, or one like it, been proposed before?
No.
Does this affect error handling?
No.
It just simplifies the syntax of passing error and avoid most if err != nil { return 0, nil, error } statements which don't really handle the errors.
Is this about generics?
No.
Proposal
It is really a pain when write codes about analysis intensive tasks (such as compilers) in current Go version. The codes around passing errors take much!
Add a new operator or use existing token to simplify if err != nil { return ...(zero values)..., err } to reduce the codes around error checking, passing and handling.
Language Spec Changes
A new operator.
This operator allows hiding received error (from callee) in user code and passing the error to the caller if the error is not nil.
Informal Change
Old style:
func PerfectSubroutine() (int, int) {
	...

	return resultA, resultB
}

func Subroutine() (int, int, error) {
	..., ... := PerfectSubroutine()

	...

	..., err := ...()
	if err != nil {
		return 0, 0, err // It is a pain!
	}

	return ..., ..., nil
}

func Foo() (int, int, error) {
	a, b, err := Subroutine()

	if err != nil {
		return 0, 0, err // It is a pain!
	}

	...

	c, d, err := Subroutine()

	if err != nil {
		return 0, 0, err // It is a pain!
	}

	...

	e, f, err := Subroutine()

	if err != nil {
		return 0, 0, err // It is a pain!
	}

	// ..., err := Subroutine()
	// ..., err := Subroutine()
	// ..., err := Subroutine()

	...

	return resultA, resultB, nil
}

func main() {
	...

	a, b, err := Foo()
	switch err := err.(type) {
	case nil:
	case AError:
		...
	case BError:
		...
	default:
		...
	}

	...
}

New style:
func PerfectSubroutine() (int, int) {
	...

	// The operator is denied when the last return value type is not error.

	// ILLEGAL: the caller's last return value type is not error.
	// ..., ... := Subroutine()!!!

	return resultA, resultB
}

func Subroutine() (int, int, error) {

	// ILLEGAL: the callee's last return value type is not error.
	// ..., ... := PerfectSubroutine()!!!

	..., ... := PerfectSubroutine()

	...

	... := ...()!!!
	// if err != nil {
	// 	return 0, 0, err
	// }

	return ..., ..., nil
}

func Foo() (int, int, error) {

	// NOTE: Here "err" refers to an error interface instance managed by the compiler and hidden from the user code.

	a, b, /* , err */ := Subroutine()!!!
	// if err != nil {
	// 	return 0, 0, err
	// }

	...

	c, d /* , err */ := Subroutine()!!!
	// if err ...

	...

	e, f /* , err */ := Subroutine()!!!
	// if err ...

	// ... := Subroutine()!!!
	// ... := Subroutine()!!!
	// ... := Subroutine()!!!

	...

	return resultA, resultB, nil
}

func main() {
	...

	a, b, err := Foo()
	switch err := err.(type) {
	case nil:
	case AError:
		...
	case BError:
		...
	default:
		...
	}

	...
}

Is this change backward compatible?
Yes.
Orthogonality: How does this change interact or overlap with existing features?

Simplify error passing at the language level.
The change improves the quality of codes.
Passing the occurred error through the last return value (and is type of error) with an operator.

Would this change make Go easier or harder to learn, and why?
Easier.
Reducing the monotonous "if err != nil``" blocks that don't really handle but pass errors makes the main logic clear.
Cost Description

No runtime change.
Choose and add this operator to lexer/scanner.
Add new nodes about it to the AST.

Performance Costs
Compile time cost changes slightly. Almost no runtime cost.
Prototype
Write a new implementation of "go/ast.Expr" for this operator, which wraps "go/ast.CallExpr".
Possible implementations to translate the node:

Generate/transform to "go/ast.BranchExpr" with "go/ast.ReturnStmt" inside.
... := Callee()!!! => ..., err_or_else := Callee(); if err_or_else !=  nil { return ..., err }
Translate the node in native way.

This is just the try proposal (#32437) with !!! instead of try().

This seems like a duplicate of an earlier proposal that was explored in detail, and is thus a likely decline. Leaving open for four weeks of final comments.

I suggest this. But if the developers of the Go language think about it, I think it could be quite possible to implement it. I have an idea how to additionally simplify error handling in Go, but without add new keywords and obey backward compatibility in Go also for mixed use of old and new style, only need create a special type like swap err type to special type for compiler.
In addition to err != nil, it is better to also have the possibility of err.(failure) and err.(success). The D programming language has scope guard functions for this purposes.
For example, defer in Go already performs a role similar to scope(exit) in the D programming language.
defer f.Close() in Go is the same as scope(exit) f.Close() in D
Go lacks scope(failure) and scope(success) or their analogues, but if you do it in Go it will return the error value to the upper scope. It would be much more convenient and beautiful than trying to do an analogue of try.
This is we have now:

func work(n string) error {
        f, err := os.Open(n)
        if err != nil {
                log.Fatal(err)
                return err
        }
        defer f.Close()

        _, err = f.Stat()
        if err != nil {
                log.Fatal(err)
                return err
        }
        return nil
}

func main() {
        n := "/tmp/myfile.txt"
        err := work(n)
        if err != nil {
                log.Fatal(err)
        }
}

It would be nice if Go could do something like this:
package main

import (
        "log"
        "os"
)

func work(n string) error {
        f, err.(failure) := os.Open(n)
        defer f.Close() // Not executed after err.(failure) != nil
        _, err.(failure) = f.Stat()
        return nil // Not executed after err.(failure) != nil
}

func swork(n string) (string, error) {
        f, err.(failure) := os.Open(n) // If err.failure != nil then string value returns automatically as "" value
        defer f.Close() // Not executed after err.(failure) != nil
        _, err.(failure) = f.Stat()
        return "", nil // Not executed after err.(failure) != nil
}

func main() {

        n := "/tmp/myfile.txt"

        //err.(failure) := work(n) // failure in this case automatically generates panic, because this is main thread
        err := work(n) // classic error handling
        if err != nil {
                log.Fatal(err)
        }

        //s, err.(failure) := swork(n) // failure in this case automatically generates panic, because this is main thread
        s, err := swork(n) // classic error handling
        if err != nil {
                log.Fatal(err)
        }
       fmt.Println(s)

}

No change in consensus, so declined.
— rfindley for the language proposal review group


Microsoft Language Server Protocol support

Add support for LSP
This is still early stage, but can provide diagnostics via hlint, and apply the hints via codeAction requests.
It is being developed against

vscode using https://github.com/alanz/vscode-hie-server
emacs using https://github.com/alanz/lsp-haskell

Travis sucks, time limit.
It passed here: https://travis-ci.org/alanz/haskell-ide-engine/builds/224722639
and here: https://circleci.com/gh/alanz/haskell-ide-engine/32
And I propose we move to circleci, which has configurable time limits


Typescript error

Hi, my code is:
<JoditEditor
  config={{readonly: false}}
/>

i i get this error: Type '{ readonly: false; }' is missing the following properties from type 'Config': iframe, commandToHotkeys, license, preset, and 56 more.ts(2740)

how can i fix?
thank you.

I'm sure this isn't the best solution, but I left out config and tabIndex from the component attributes and it renders.  My project runs Typescript so it also error until I added experimentalDecorators: true in my tsconfig.json file.

@adamayd hi,
this is not a solution for me, i need set some config.
looking at source code i can find file index.d.ts, this file import typescript interface IJodit from Jodit in line 2
import { IJodit } from "jodit";
looks the problem is not in this repo but in the main Jodit repo types definition, anyone can confirm that?

I'm sure this isn't the best solution, but I left out config and tabIndex from the component attributes and it renders. My project runs Typescript so it also error until I added experimentalDecorators: true in my tsconfig.json file.

Yes I had to update the tsconfig.json as well but I don't want to specify all 56+ configs :/

How is this still an Issue 5 months later ? I just added this package to my project cause IJodot is really nice, but this wrapper as so many type missconfiguration.

Ok, i see just installed this editor and as i can see old bug still not fixed, piece of crap... next...

Same here, fresh installation and problems...

Same here, the config object requires a lot of information that is not necessary

Hi every one!
I get it working, just get default config and spread it with custom configs:
import { IJodit, Jodit } from "jodit"
const config: IJodit['options'] = { ...Jodit.defaultOptions, theme: 'dark' }

It works for me!

Hi every one!
I get it working, just get default config and spread it with custom configs:
import { IJodit, Jodit } from "jodit"
const config: IJodit['options'] = { ...Jodit.defaultOptions, theme: 'dark' }

it works!

If you want to use "toolbarAdaptive" configuration attribute, you will get TypeScript error: 'toolbarAdaptive' does not exist in type 'Config'
https://github.com/jodit/jodit-react/issues/32

Hello,
I had got the same error.
So to add some config, i used the 'any' type.
const config: any = {
  readonly: false,
  placeholder: 'Start typings...',
  height: 500,
  style: { backgroundColor: 'red' },
}

To put the config on the component without errors.
<JoditEditor
    ref={editor}
    config={config}
    value={description}
    onBlur={(newContent) => setDescription(newContent)}
    onChange={(newContent) => setDescription(newContent)}
/>

Like this you can use the component normally during waiting them fixes.


runtime error: invalid memory address or nil pointer dereference

View details in Rollbar: https://app.rollbar.com/a/magneticstain/fix/item/IP-2-CloudResource/12
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 422, in rollbar-go.(*Client).ErrorWithStackSkipWithExtras
  File<EMAIL_ADDRESS>line 415, in rollbar-go.(*Client).ErrorWithStackSkip
  File<EMAIL_ADDRESS>line 537, in rollbar-go.(*Client).LogPanic
  File<EMAIL_ADDRESS>line 576, in rollbar-go.(*Client).WrapWithArgs.func1.1
  File "/usr/local/go/src/runtime/panic.go", line 920, in runtime.gopanic
  File "/usr/local/go/src/runtime/panic.go", line 261, in runtime.panicmem
  File "/usr/local/go/src/runtime/signal_unix.go", line 861, in runtime.sigpanic
  File "/usr/local/go/src/net/http/client.go", line 194, in http.(*Client).deadline
  File "/usr/local/go/src/net/http/client.go", line 608, in http.(*Client).do
  File "/usr/local/go/src/net/http/client.go", line 590, in http.(*Client).Do
  File<EMAIL_ADDRESS>line 966, in apiv1.(*instancesRESTClient).AggregatedList.func1.1
  File<EMAIL_ADDRESS>line 82, in v2.invoke
  File<EMAIL_ADDRESS>line 50, in v2.Invoke
  File<EMAIL_ADDRESS>line 956, in apiv1.(*instancesRESTClient).AggregatedList.func1
  File<EMAIL_ADDRESS>line 1002, in apiv1.(*instancesRESTClient).AggregatedList.func2
  File<EMAIL_ADDRESS>line 139, in iterator.(*PageInfo).fill
  File<EMAIL_ADDRESS>line 118, in iterator.(*PageInfo).next
  File<EMAIL_ADDRESS>line 1729, in apiv1.(*InstancesScopedListPairIterator).Next
  File "/home/josh/Code/ip-2-cloudresource/gcp/plugin/compute/compute.go", line 49, in compute.SearchResources
  File "/home/josh/Code/ip-2-cloudresource/gcp/gcp.go", line 29, in gcp.GCPController.SearchGCPSvc
  File "/home/josh/Code/ip-2-cloudresource/search/search.go", line 117, in search.Search.doAccountLevelSearch
  File "/home/josh/Code/ip-2-cloudresource/search/search.go", line 151, in search.Search.runSearchWorker
  File "/usr/local/go/src/reflect/value.go", line 596, in reflect.Value.call
  File "/usr/local/go/src/reflect/value.go", line 380, in reflect.Value.Call
  File<EMAIL_ADDRESS>line 579, in rollbar-go.(*Client).WrapWithArgs.func1
  File<EMAIL_ADDRESS>line 582, in rollbar-go.(*Client).WrapWithArgs
  File<EMAIL_ADDRESS>line 649, in rollbar-go.WrapAndWait
  File "/usr/local/go/src/runtime/asm_amd64.s", line 1650, in runtime.goexit
runtime.errorString: runtime error: invalid memory address or nil pointer dereference

Fixed as part of #393


Increased the code coverage from 92.6% to 96%

Why?
There was less code coverage because of one if condition that was never reached.
What?
Was trying to add the test cases but getting deadlocks like the https://github.com/fatih/semgroup/pull/2
How?

Just moved the multiple if condition to OR operator
Fixed a small spelling mistake.

I couldn't push to your PR, but I opened another one with the fixes. Thanks for letting me know.

https://github.com/fatih/semgroup/pull/4

I made sure to acknowledge you in the release logs, FYI: https://github.com/fatih/semgroup/releases/tag/v1.1.0


Migrate Traefik Configuration To Environment Variables

Currently overriding / extending the traefik.yml configuration is difficult. This PR proposes migrating the Traefik configuration from the .yml file to environment variables. This should improve both the extendability and maintainability of attempting to extend the Traefik config. Such as, but not limited to configuring plugins or certificate resolvers.
I've found there are 2 main pain points to the current approach.

You have to overwrite and maintain the whole configuration file, even for a single value change.
You have to edit the source file, since the svc up command replaces any modifications under $HOME/.warden/etc/traefik/traefik.yml See Here

Note: May be considered a breaking change. Since any custom changes to the traefik.yml by users would have to be reimplemented via the ENV approach. Due to Traefik static config approaches being mutually exclusive.

Example Use Case
Say you want to enable debug logging for Traefik. With the environment variable approach you can create a docker compose file in the warden home directory with the following contents.
# ~/.warden/docker-compose.yml
services:
  traefik:
      TRAEFIK_LOG_LEVEL: DEBUG

Or if you want to define a certificate resolver such as LetsEncrypt to sign your certs. It can again be defined in the users home directory with the following docker compose file. See this issue of someone attempting a similar thing and having to override the source file
# ~/.warden/docker-compose.yml
services:
  traefik:
    volumes:
      - acmedata:/acme
    environment:
      CF_DNS_API_TOKEN: xxx
      CF_ZONE_API_TOKEN: xxx
      TRAEFIK_CERTIFICATESRESOLVERS_LETSENCRYPT: true
      TRAEFIK_CERTIFICATESRESOLVERS_LETSENCRYPT_ACME_EMAIL<EMAIL_ADDRESS>      TRAEFIK_CERTIFICATESRESOLVERS_LETSENCRYPT_ACME_STORAGE: /acme/acme.json
      TRAEFIK_CERTIFICATESRESOLVERS_LETSENCRYPT_ACME_CASERVER: https://acme-staging-v02.api.letsencrypt.org/directory
      TRAEFIK_CERTIFICATESRESOLVERS_LETSENCRYPT_ACME_DNSCHALLENGE: true
      TRAEFIK_CERTIFICATESRESOLVERS_LETSENCRYPT_ACME_DNSCHALLENGE_PROVIDER: cloudflare
volumes:
  acmedata:

Thank you for the work on this @SamJUK !! I see no issues with this PR.
If we didn't want to wait until Warden 1.0 (or 0.15) to push this change we could add a Warden flag that is WARDEN_USE_TRAEFIK_ENV_CONFIG that if set to 1 then the config file is this new style, but if not set is the old way. Then also send a message to stderr which states that the Traefik static file config has been deprecated and will be removed in a future version and people should start switching to WARDEN_USE_TRAEFIK_ENV_CONFIG now.
Thoughts @navarr ?


[Feature] The app list displays the Chinese name and user of the app

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
With more and more apps, you can't tell what business it is from the English name, and you can't tell who it belongs to when the operation fails
Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[x] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

The Chinese name can be written in application name, so only the user name is displayed；中文名可以再application name中写，所以只剩余展示用户名称


Make sentry settings overridable

I want to merge this change because it makes sentry settings overridable by separate settings file.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-4599 Patch saleor core to make sentry settings overridable

will first put 3.0


Add a vector style line

Description
as mentioned by @ericpre in https://github.com/matplotlib/matplotlib/issues/22682#issuecomment-1159468557

I am wondering if it would be possible to extend it to also fix https://github.com/matplotlib/matplotlib/issues/9608, by introducing a "vector widget": the line would need to be changed to an arrow style and the order of the selected point will kept, i.e. not sorted numerically.

This is a good idea and would be nice to implement here. Could either be done as a styling option to the current line, or it could be a separate object that inherits and modifies behavior.

Labelling as a good first issue because this hopefully shouldn't be too involved with matplotlib callbacks and mostly be about styling an arrow. Also I'll be happy to work with anyone who comes across this and wants to give it a go.


Add an image manually to the cache.

I needed to add an image manually to the cache and saw this issue referenced here: https://github.com/pinterest/PINRemoteImage/issues/284
It seems to work, but is there anything I am missing?

I'll squash these commits later. ^

No need to squash, GitHub makes that easy :) Thanks for the contribution!


Contact state estimation

Hi, in deploying NMPC in a real robot, would it be better to not use the plantar force as a judgment of the contact state, but directly use the time series used in defining the gait within OCS2 as a judgment of the contact state, as the robot I am using that I built myself feels that the plantar force calculated through the electric current is very noisy.

Hello, when deploying NMPC on actual hardware platforms, do you use the gait timing sequences defined in OCS2 to determine contact states? Could you explain how to properly connect the defined timing sequences with ground contact states?


fix: caching of GeometryType in StyleContext

did not work since the switch from constants to strings

Looks good to me


Disable whitelisting before enabling pre / public sales

If a presales or public sales is enabled while whitelisting is enabled, it leaves the dapp in an invalid state. On the left, I enabled public sales when whitelisting was enabled. The sales status shows whitelisting only and public sales price. On the right, it was corrected.
I'm open to discussion because it could be argued that this is a user error and they should know to disable whitelisting before pre/public sales. So this may be more of a convenience and guarding against user error.

Before
After

Hi @basememara, this can be useful but as you said the collection owner would have no clue both sales are open at the same time... I mean, not that users complaining about the issue can be considered a good feedback 😅 but at least it can let them know that people will still be able to mint at the whitelist price if they do that from Etherscan.
Anyway I think this is probably a fix that we should merge and then I can focus on something else to give owners some feedback about what's happening.
Thank you for this, I'm gonna review it asap.

I think throwing an error instead of automatically making a change is better, especially since the whitelist-close script could involve a lot more than contract.whitelistMintEnabled() in the future.
Now running yarn public-sale-open while a whitelisting is open throws an error:
error Please close the whitelist sale before opening a public sale.


Did you add tests for your changes?
no, this is a quick fix for an experimental feature
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
nothing

/cc @sokra

/cc @sokra

Thanks


No relative path/No quotes around path with spaces

The Makefile that is generated does not add quotes around paths and/or does use relative paths.
After executing on my Win10 machine, the following command for generating the makefile:
   mbed export -vv -i GCC_ARM -m NUCLEO_F091RC --profile debug

Where mbed --version returns 1.8.3
The makefile shows (project name and username replaced with <...>):
INCLUDE_PATHS += -I../c:/Users/<user>/Mbed Programs/<project>/mbed-os
ASM_FLAGS += -c:/Users/<user>/Mbed Programs/<project>/mbed-os

This filed compilation, I had to add the quotes:
INCLUDE_PATHS += -I../"c:/Users/<user>/Mbed Programs/<project>/mbed-os"
ASM_FLAGS += -I"c:/Users/<user>/Mbed Programs/<project>/mbed-os"

Notice however that the first path is a mix of an absolute and a relative path.
Most pats are relative like this:
INCLUDE_PATHS += -I.././mbed-os/usb/device/utilities/events

So it seems that the makefile should have read the following instead:
INCLUDE_PATHS += -I.././mbed-os
ASM_FLAGS += -I"././mbed-os"

Or similar, or determine the absolute path from the Makefile path.
Another issue exists with
C_FLAGS += .\mbed_config.h

Compiling using c:\cygwin64\bin\make, produced the error message that the file .mbed.config.h could not be found.
Changing that to
C_FLAGS += ./mbed_config.h

Fixed that.  Most paths are using forward slashes ("/"), but this path was an exception.  I guess this should change.
On a sidenote, I personnaly avoid using spaces in path names, it's a pity "Mbed studio" generates the program in "Mbed Programs" with a space.

Internal Jira reference: https://jira.arm.com/browse/IOTBTOOL-378

Thank you for raising this issue. Please note we have updated our policies and
now only defects should be raised directly in GitHub. Going forward questions and
enhancements will be considered in our forums, https://forums.mbed.com/ . If this
issue is still relevant please re-raise it there.
This GitHub issue will now be closed.

IMHO these are defects.
Reasons:

The default path including the space "Mbed programs" is proposed by the tool itself;
As a result the generated Makefile is invalid for certain steps.
Inconsistency (backward slash instead of a forward slash) breaking the makefile is a defect.
The suggestions were only there to indicate how this can be solved.

I am not using MBED anymore at this time - I am not reporting this issue more than I am now.

Apologies, this was closed in error by the automated bot - re-opening.

Internal Jira reference: https://jira.arm.com/browse/IOTBTOOL-459

Closing this as it has been stale for over 2 years to clean up my issues list.


Add audio node base widgets

This will allow creating and connecting multiple audio node widgets wrapped from Tone.js.
TODO:

[x] implement connecting Tone.js audio nodes to each other via the _in_nodes and _out_nodes traits of AudioNode
[x] Add convenient methods connect, disconnect, fan and chain (same API than Tone.js) to avoid directly manipulating the _in_nodes and _out_nodes traits
[x] Add a Destination widget to represent the main output (speakers). It's a singleton on the server side, it can be accessed with the ipytone.get_destination() function exposed in the public API.
[x] add a convenient to_destination method (like in Tone.js) to directly connect any audio node widget to the destination node
[x] add SourceNode base widget, at least with start and stop methods.
[x] add Python tests (let's add JS tests later)

I think this PR is ready now. I think it clears up the path for adding a lot of Tone audio sources, instruments and effects.
@davidbrochart, I'll leave it open for a bit in case you want to have a look. Suggestions are welcome!

Thanks for your comments @davidbrochart ! That makes a lot of sense!

:+1: