Applying the limit on one product only

is there any option to set orders limit for specific product only?

Hi @ValeryKuz,
This has come up before, and it's something of a different paradigm: instead of counting down the number of orders to accept before turning off checkout (which this plugin does), limiting orders based on a single product would likely be best-accomplished by an automatically-renewing inventory.
 Once you're out of bagels, you no longer want people to be able to buy them (as they're out of stock) but you don't want to prevent them from purchasing other baked goods (donuts, muffins, etc.).
Limit Orders, meanwhile, is designed to turn off the entire checkout process once a certain number of orders has been reached. Going back to the bakery example, it would be perfect for a bakery that says "we have limited staff and can only prepare 100 online orders in a day, regardless of what delicious treats are in the orders".
A better approach for your use case would likely be a plugin/script to automatically reset the inventory on a particular product on a schedule (e.g. "refresh the bagel inventory every day at 7am"). We've discussed building such a plugin, but sadly it isn't something that we've gotten around to yet.

Tnx for the detailed answer!
On Mon, 28 Jun 2021 at 20:10, Steve Grunwell @.***>
wrote:

Hi @ValeryKuz https://github.com/ValeryKuz,
This has come up before
https://wordpress.org/support/topic/can-this-applied-to-single-products/,
and it's something of a different paradigm: instead of counting down the
number of orders to accept before turning off checkout (which this plugin
does), limiting orders based on a single product would likely be
best-accomplished by an automatically-renewing inventory.
 Once you're out
of bagels, you no longer want people to be able to buy them (as they're out
of stock) but you don't want to prevent them from purchasing other
baked goods (donuts, muffins, etc.).
Limit Orders, meanwhile, is designed to turn off the entire checkout
process once a certain number of orders has been reached. Going back to the
bakery example, it would be perfect for a bakery that says "we have limited
staff and can only prepare 100 online orders in a day, regardless of what
delicious treats are in the orders".
A better approach for your use case would likely be a plugin/script to
automatically reset the inventory on a particular product on a schedule
(e.g. "refresh the bagel inventory every day at 7am"). We've discussed
building such a plugin, but sadly it isn't something that we've gotten
around to yet.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nexcess/limit-orders/issues/66#issuecomment-869860918,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOQ6QH7SM2DYBRCOOTFAEULTVCUIVANCNFSM47NOJHLA
.


legacy: hepdata removal

INCOMPATIBLE Removes legacy hepdata module. (addresses #3233)

Signed-off-by: Samuele Kaplun<EMAIL_ADDRESS>

@kaplun  please add Reviewed-by: me, rebase and :shipit:

Done.

Mmh. wait there are some copyrights not updated.

OK really done


Don't keep CALLER balance as U256::MAX

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[ ] Foundryup

What version of Foundry are you on?
No response
What command(s) is the bug in?
No response
Operating System
No response
Describe the bug
Here, we set the balance of CALLER and other addresses  to U256::MAX to make sure they can execute deploys.
https://github.com/foundry-rs/foundry/blob/7e12adbc30d56174320d12be52f94a34d7405c69/forge/src/runner.rs#L69-L71
A few lines below, we set the balances to the user-specified initial balance.
https://github.com/foundry-rs/foundry/blob/7e12adbc30d56174320d12be52f94a34d7405c69/forge/src/runner.rs#L128-L131
However, CALLER is left out of there, so if a fuzz test chooses the CALLER address and that test sends ETH to that address, the test reverts with balance overflow.
Proposed fix is to set the CALLER balance after L132 to either 0, or to self.initial_balance. I believe either should be suitable since CALLER isn't used afterwards AFAIK.
This is partially related to #2322 in that I don't think the default balance of an account should ever be kept at U256::MAX, so in that PR I'd suggest using the default self.initial_balance that's typically used instead.

Unsure, I don't know what that address is being used for. I think it's for script?

Reopened because I don't think it resolved https://github.com/foundry-rs/foundry/issues/2390#issuecomment-1189526352

Yep, thanks. Interestingly, @jferas and I both did not see fuzz failures with either of those two addresses until recently, but I don't recall seeing a change that would cause them to start being included in the fuzz dict.
So I think the scope of this issue may be three items:

Reduce the initial balance of 0x3fAB184622Dc19b6109349B94811493BF2a45362 to something smaller.
Make these addresses constants
Decide if these addresses should really be in the fuzz dict or not

Hmm, I think self.sender and self.test_address could both be valid inputs(?) and should not be excluded. For CALLER I think we should just reduce the balance of that account to 0.

Hmm, I think self.sender and self.test_address could both be valid inputs(?) and should not be excluded.

Yea I think I lean this way also, just want to make sure they have more realistic default balances in that case

For CALLER I think we should not have any balance on it before it is actually used - as far as I remember it is only used to call failed() on the test contracts?

Ah ok, yea that seems like a reasonable approach to me then. Perhaps we keep the balance zero, set it to nonzero to call failed(), then reset back to zero after the call?

Ah ok, yea that seems like a reasonable approach to me then. Perhaps we keep the balance zero, set it to nonzero to call failed(), then reset back to zero after the call?

Yea that's what I meant

0x3fAB184622Dc19b6109349B94811493BF2a45362

Does it still have issues with the latest version? Current master branch should handle that.
https://github.com/foundry-rs/foundry/blob/f0fa5da3c53858dbf9ac602ffeb633e15c39b9a3/evm/src/executor/mod.rs#L108-L120

The ask is to set it to 0 again after deployment :smile:

Closed by https://github.com/foundry-rs/foundry/pull/2322 and https://github.com/foundry-rs/foundry/pull/8331


Set a "experimental: true" flag for CLI command generation YAML

Similar to #673, having an expermiental: true flag would be helpful for further standardizing the config and instead having the parser/code generator do the heavy lifting in adding details to the command description and other areas.

Looks like this is already done, closing. @yuandrew please reopen if you disagree/had something else in mind.


Add links to places for questions

There was only one link to the mailing-list from the entire docs website, buried in kb/how-to/rewrite-branch-for-coding-style.md. There should be a prominent one, easy to discover from the front page.
While at it, mention the Discord server as well.

I think accepting the suggestion has somehow failed the DCO check.

Yeah, I thought github was now supporting it... I'm force-pushing to fix that.

Yeah, I thought github was now supporting it... I'm force-pushing to fix that.

I thought so too. I blame github for this as well :)


Camera visualization

Hi, thank you for your insightful work!
Have you tried to visualize the camera trajectories and view directions?

Hi Kaizhi, you can use the tool we provided here to do that!


Revise gettext.translation.lgettext as it is deprecated

Per the Python 3 Docs, the gettext funcionts lgettext is deprecated since version 3.8, and will be removed in version 3.10.
https://docs.python.org/3/library/gettext.html#gettext.lgettext
Spyder uses gettext.translation.lgettext to get the translation strings, in spyder/config/base.py. This code should be revised to avoid Exception in the near future.

I think this can be closed; lgettext is no longer used.


dgraph: 20.07.1 -> 20.07.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/dgraph/versions.
meta.description for dgraph is: "Fast, Distributed Graph DB"
meta.homepage for dgraph is: "https://dgraph.io/"
meta.changelog for dgraph is: ""
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 20.07.2 with grep in /nix/store/xjq6algx8s2p1jnfzpgppvjs6gqa8cam-dgraph-20.07.2

directory tree listing: https://gist.github.com/dac6161068c31a94091b6fe7435701f9

du listing: https://gist.github.com/b47699660aa66d60724b79449fc2d023

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
dgraph

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/xjq6algx8s2p1jnfzpgppvjs6gqa8cam-dgraph-20.07.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A dgraph https://github.com/r-ryantm/nixpkgs/archive/f1182f83fe087c0d098762ea9106582e84f10f52.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/xjq6algx8s2p1jnfzpgppvjs6gqa8cam-dgraph-20.07.2
ls -la /nix/store/xjq6algx8s2p1jnfzpgppvjs6gqa8cam-dgraph-20.07.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

dgraph

Maintainer pings
cc @sigma @kalbasit for testing.

Result of nixpkgs-review pr 102233 run on x86_64-darwin 1

1 package built:

dgraph


using context.call or forward between Luis based dialogs

Hello,
I am trying to call a a Dialog that has Luis intent from within the root dialog which also has Luis.
context.Call(new Class1(), ResumeAfterDialog);
When I call Class1() it only shows a message I have in ResumeAfterDialog(), it is as if it doesn't stay in the child dialog Class 1.
Is there an equivalent of MessageReceivedAsync using LUIS? Is it the "None", "" Luis intents?
Any help is greatly appreciated

There is a LuisDialog class that you may find useful. Take a look at this sample: https://github.com/Microsoft/LUIS-Samples/blob/master/documentation-samples/tutorial-web-app-bot/csharp/BasicLuisDialog.cs
for an example of how to extent that class and use the LuisIntent attribute.

Are you using a single LUIS model?  If yes, why do you need multiple LuisDoalogs, what is your scenario?

Is there an equivalent of MessageReceivedAsync using LUIS? Is it the "None", "" Luis intents?

no

@JasonSowers , it's using the same LUIS model. My scenario is that I have a bot that offers 2 areas of support, Tech and HR for example. However I have a root dialog with LUIS that determines the intent of the user and then depending on the utterance, it "directs" the conversation to the corresponding area of support which are in separate classes.
If a user write about HR support, then the intent would be something containing hr support utterance which the bot reads it and then directs to the hr support class. In that class, then the user asks or type something that either triggers the qna dialog or some other service.

I do know of a way to have multiple LuisDialogs for the same model, but I have never tried.  I think you are going to have to use a single LuisDialog and let that dialog route things accordingly.  You can still do exactly what you want as you can have an intent call any other dialog/service/class/etc.

Closing the issue assuming it as resolved. Please reopen a new issue if it still persists.


Will it work with NestJs using Fastify?

[Nest] 76   - 10/24/2019, 9:16:33 AM   [ExceptionsHandler] response.set is not a function +807ms
TypeError: response.set is not a function
at RateLimiterInterceptor.<anonymous> (/usr/src/service/service-api/node_modules/nestjs-rate-limiter/dist/rate-limiter.interceptor.js:126:26)

It throws this error.

I'll take a look.
I only tested with the default express implementation. I'll take a look at Fastify and try and identify the issue and at minimum make a note in the README

Until this repository supports fastify, anybody who wants to use this package on fastify can install from https://github.com/feednext/nestjs-rate-limiter with npm i --save feednext/nestjs-rate-limiter#build. Nothing changed for usage wise, @RyanTheAllmighty take a look at what I have changed and implement it to this package when you have time. I think you should take parameter on initialization like 'express' or 'fastify' and do the job conditionally in interceptor.

Also, custom error message support added

Moved to #17


Solidity Coverage Runner

We need a github runner to ensure that solidity-coverage always passes.

/cib


[Bug]: Does not work on Waterfox

Describe the bug
Attempting to go to youtube with the theme enabled on Waterfox results in an error page telling me my browser is outdated, and how to enable layout.css.has-selector.enabled. Waterfox does not have this exact setting, instead having:

Screenshots
No response
What browser are you using?
Waterfox Version G5.1.8 (64-bit)
What version of AdashimaaTube are you using?
No response

The :has() pseudo class selector was introduced in Firefox 10 but Waterfox is based on Firefox ESR 102 which doesn't have the ability to enable the "has" selector.


remove unused netcore 2.2 era nuget

Removed Microsoft.AspNetCore.Authentication.Abstractions 2.2.0 dependency.
It's not needed for build & runtime.

LGTM, thanks


"Flickering" and missing headlines

Hard to describe in words, please see the attached screenshot, and then I will try to explain in words.
Saw the screenshot? Great.

There are some headings missing, between lines 76 and 298. They are definitely there, I remember entering them and I can see them when doing cat file.org.
Line 298, the background of the heading looks "garbled" on the left side.
After line 311 there are some strange thingies.
And many more strange "flickering" that are hard to describe in words.

Here the org file to reproduce it: https://pastebin.pl/view/6d3fc321.
Neovim version 0.7.2.
A requested, I am reopening this issue from here: https://github.com/nvim-orgmode/orgmode/issues/378.

For 2 and 3 please see what I wrote in the other ticket.
For 1, this is actually a bug in Neovim. I have reported it here https://github.com/neovim/neovim/issues/19557
I suspect it also causes 4

For 2 and 3 please see what I wrote in the other ticket.

I will do it asap today.

For 1, this is actually a bug in Neovim. I have reported it here neovim/neovim#19557 I suspect it also causes 4

Very interesting! It seems like something that should have been discovered as a bug in Neovim a long time ago, as soon as this feature was introduced in Neovim. Very interesting.

This happens because your font does not support the default character for headlines.nvim. You can either change/patch your font, or use a different character.

I prefer to change the font I am using.

Can you please provide a font name that you know that definitely works?
I should change the font in my terminal settings, right? Not in Neovim, correct?
This is what I currently have in my Alacritty config:

font:
  normal:
    family: Consolas
    style: Regular

Yes, the font in the terminal.
I am using the nerd font patched version of Fira Code.
https://github.com/ryanoasis/nerd-fonts/tree/master/patched-fonts/FiraCode

Yes, the font in the terminal. I am using the nerd font patched version of Fira Code. https://github.com/ryanoasis/nerd-fonts/tree/master/patched-fonts/FiraCode

Interestingly, their README says that my terminal of choice, Alacritty, is not supported. Here is the link: https://github.com/ryanoasis/nerd-fonts/tree/master/patched-fonts/FiraCode#terminal-compatibility-list.
Perhaps, maybe, you know of some other font that will work with headlines.nvim?

I think it's only the ligatures that won't work, alacritty just doesn't support those.
https://github.com/alacritty/alacritty/issues/50
You should still be able to use the font

This happens because your org headline highlight groups have a background color. https://github.com/akinsho/org-bullets.nvim uses that color for the bullets, but the background color of virtual text overwrites the highlight of the headline from headlines.nvim.

I am sorry, I don't understand any of it. Can you please explain it again using different words?

This happens because your font does not support the default character for headlines.nvim. You can either change/patch your font, or use a different character.

I configured Alacritty to use Fira Code and problem #3 still occurs.

They do?

orgmode.nvim takes the colors from your colorsheme. So if that has background colors, it will have too.

Wait, this plugin supposes to add the background color to the headlines, is it not?

It is. This is a bit complicated. You have the first level of highlights from your colorscheme. Then this plugin adds highlights to change the background color of the headline. But then, org-bullets adds the bullets to the headlines, and they have background color too. org-bullets has the highest priority, so it overwrites the background color from this plugin.
To fix this, you have to remove the background highlight from those highlight groups.

I don't use Alacritty myself, it's possible it just can't display that character. You can still just use a different character, like the one I posted in the original issue.

This happens because your font does not support the default character for headlines.nvim. You can either change/patch your font, or use a different character.

I've decided to permanently move to kitty+Fira Code, and problem number 3 is gone. Thank you :-)

for i = 1, 40, 1 do
    vim.cmd(string.format("highlight OrgHeadlineLevel%d guibg=NONE", i))
end

I did that, and problem number 2 still exists. Suggestions please :-)

Location matters, you need to do this after your colorscheme loads, but before org-bullets setup

Location matters, you need to do this after your colorscheme loads, but before org-bullets setup

Problem number 2 still remains, but much less in quantity. I will blame the Neovim bug you mentioned :-)

I solved problem 1 by setting the conceallevel to 1, strange how that works

@nyngwang the squares are related to the font used in your terminal. Seems that FiraCode would work.
I personally use Nerd Font Hack and configured like this to get rid of the squares (using lazy.nvim):
return {
	"lukas-reineke/headlines.nvim",
	dependencies = "nvim-treesitter/nvim-treesitter",
	opts = {
		markdown = {
			fat_headline_lower_string = "▔",
		},
	},
}

@lukas-reineke Thanks for the plugin! May I suggest to mention the font "requirement" somewhere in the README.md?


Improvements in the left quantifiers checker

Refactoring of the checker strategy.
Check is performed only for commutative operators.

Coverage increased (+0.9%) to 77.231% when pulling 926b67b1c41d70c3663dc787fa48b389c8fb10f4 on left-quantifiers into fccfb401f66f4abd3144d99ea9b752562b0a99d0 on master.

Coverage increased (+1.0%) to 77.301% when pulling 2898874b6e36ca2075754647c1e85e0568463ca0 on left-quantifiers into fccfb401f66f4abd3144d99ea9b752562b0a99d0 on master.

Coverage increased (+1.0%) to 77.301% when pulling 3e5c9c3fccbfbd8d3aac0e542624d3fe9e5e3e30 on left-quantifiers into fccfb401f66f4abd3144d99ea9b752562b0a99d0 on master.

Coverage increased (+1.0%) to 77.335% when pulling 2a148bb550268258508870281c33d9bb4d79c03d on left-quantifiers into fb68c8ba4f9be2e3f43ed1f6b596396bf9b105f6 on master.

Great! Thanks!


Text along polyline looks not good on mobile devices

We have a couple of mobile apps for mountain biking and hiking trails. Users request the trail name along the polyline, so we tried your plugin.
Due to the screen size on mobile devices the trail name along the path looks quite weird, letters overlap or are spread out or single letters rotate etc.
Is there an option or recommendation to draw the text in a more readable way along a path?

There might be a couple of strategies. One of them could be to add an invisible line that would be a simplified version of the trail geometry, and show the text on this one.

The last master is 2 years old, is this really what you meant?

No sorry I meant #31 :|

It doesn't improve much, just at high zoom level. So we will look at other strategies.

Thanks, please share your findings!
We would be pleased to review and merge any contribution!

By the way I have just deleted the master branch as it was completely out-of-date

@bardu It would be great if you could provide a jsfiddle for example with your polylines and text causing problems

It's not ideal yet as in Google Maps for mobile, but these setting are better for zoom level 13+
polyline.setText(trail.name, {center: true, offset: -10, attributes:{'letter-spacing': '.8em','spacing': 'auto', 'glyph-orientation-vertical': 'inherit', 'glyph-orientation-horizontal': 'inherit'}})

BTW, how can I remove the text from the polyline?

Well, should better read the doc.
polyline.setText(null);


HttpError

After linking the Amazon account, I saw the confirmation that my 'amazon alexa cookie was successfully retrieved' However, it did not show up in the logs. I tried uninstalling and reinstalling the plugin and now recieving a HttpError. Unable to load the localhost:2345 page now.
I did have an issue with the wrong IP address, which was later fixed in the configuration.

8/31/2023, 4:10:11 PM] Homebridge v1.6.1 (HAP v0.11.1) (Homebridge 632D) is running on port 51319.
[8/31/2023, 4:10:11 PM] [HomebridgeAlexaSmartHome] Failed to initialize. Error: You can try to get the cookie manually by opening http://<IP_ADDRESS>:2345/ with your browser.
at /var/lib/homebridge/node_modules/homebridge-alexa-smarthome/node_modules/alexa-cookie2/alexa-cookie.js:390:38
at Server. (/var/lib/homebridge/node_modules/homebridge-alexa-smarthome/node_modules/alexa-cookie2/lib/proxy.js:379:30)
at Object.onceWrapper (node:events:627:28)
at Server.emit (node:events:513:28)
at emitListeningNT (node:net:1774:10)
at processTicksAndRejections (node:internal/process/task_queues:81:21)
[8/31/2023, 4:10:11 PM] [HomebridgeAlexaSmartHome] After initialization - HttpError(Error getting smart home devices. Reason: Cookie invalid, Renew unsuccessful)
[8/31/2023, 4:15:12 PM] [Homebridge UI] Changes to config.json saved.
[8/31/2023, 4:30:53 PM] [Homebridge UI] Changes to config.json saved.
[8/31/2023, 4:41:40 PM] [Homebridge UI] Homebridge restart request received
[8/31/2023, 4:41:40 PM] [Homebridge UI] UI / Bridge settings have not changed; only restarting Homebridge process
[8/31/2023, 4:41:40 PM] [Homebridge UI] Sending SIGTERM to Homebridge
[8/31/2023, 4:41:40 PM] Got SIGTERM, shutting down Homebridge...
[8/31/2023, 4:41:45 PM] [HB Supervisor] Homebridge Process Ended. Code: 143, Signal: null
[8/31/2023, 4:41:50 PM] [HB Supervisor] Restarting Homebridge...
[8/31/2023, 4:41:50 PM] [HB Supervisor] Starting Homebridge with extra flags: -I -P /var/lib/homebridge/node_modules --strict-plugin-resolution
[8/31/2023, 4:41:50 PM] [HB Supervisor] Started Homebridge v1.6.1 with PID: 17150
[8/31/2023, 4:41:52 PM] Loaded config.json with 0 accessories and 2 platforms.
[8/31/2023, 4:41:52 PM] Loaded 0 cached accessories from cachedAccessories.
[8/31/2023, 4:41:52 PM] ---
[8/31/2023, 4:41:52 PM] Loaded plugin<EMAIL_ADDRESS>[8/31/2023, 4:41:52 PM] Registering platform 'homebridge-alexa-smarthome.HomebridgeAlexaSmartHome'
[8/31/2023, 4:41:52 PM] ---
[8/31/2023, 4:41:52 PM] Loading 2 platforms...
[8/31/2023, 4:41:52 PM] [HomebridgeAlexaSmartHome] Initializing HomebridgeAlexaSmartHome platform...
Setup Payload:
X-HM://00241BD6RA51K
Enter this code with your HomeKit app on your iOS device to pair with Homebridge:
[8/31/2023, 4:41:53 PM] [HomebridgeAlexaSmartHome] Failed to initialize. Error: You can try to get the cookie manually by opening http://<IP_ADDRESS>:2345/ with your browser.
at /var/lib/homebridge/node_modules/homebridge-alexa-smarthome/node_modules/alexa-cookie2/alexa-cookie.js:390:38
at Server. (/var/lib/homebridge/node_modules/homebridge-alexa-smarthome/node_modules/alexa-cookie2/lib/proxy.js:379:30)
at Object.onceWrapper (node:events:627:28)
at Server.emit (node:events:513:28)
at emitListeningNT (node:net:1774:10)
at processTicksAndRejections (node:internal/process/task_queues:81:21)
[8/31/2023, 4:41:53 PM] [HomebridgeAlexaSmartHome] After initialization - HttpError(Error getting smart home devices. Reason: Cookie invalid, Renew unsuccessful)
[8/31/2023, 4:41:53 PM] Homebridge v1.6.1 (HAP v0.11.1) (Homebridge 632D) is running on port 51319.
[8/31/2023, 4:44:36 PM] [HomebridgeAlexaSmartHome] After initialization - HttpError(Error getting smart home device state. Reason: Timeout)
[8/31/2023, 4:45:30 PM] [Homebridge UI] Changes to config.json saved.
[8/31/2023, 4:46:26 PM] [Homebridge UI] Homebridge restart request received
[8/31/2023, 4:46:27 PM] [Homebridge UI] UI / Bridge settings have not changed; only restarting Homebridge process
[8/31/2023, 4:46:27 PM] [Homebridge UI] Sending SIGTERM to Homebridge
[8/31/2023, 4:46:27 PM] Got SIGTERM, shutting down Homebridge...
[8/31/2023, 4:46:32 PM] [HB Supervisor] Homebridge Process Ended. Code: 143, Signal: null
[8/31/2023, 4:46:37 PM] [HB Supervisor] Restarting Homebridge...
[8/31/2023, 4:46:37 PM] [HB Supervisor] Starting Homebridge with extra flags: -I -P /var/lib/homebridge/node_modules --strict-plugin-resolution
[8/31/2023, 4:46:37 PM] [HB Supervisor] Started Homebridge v1.6.1 with PID: 17339
[8/31/2023, 4:46:38 PM] Loaded config.json with 0 accessories and 2 platforms.
[8/31/2023, 4:46:38 PM] Loaded 0 cached accessories from cachedAccessories.
[8/31/2023, 4:46:38 PM] ---
[8/31/2023, 4:46:38 PM] Loaded plugin<EMAIL_ADDRESS>[8/31/2023, 4:46:38 PM] Registering platform 'homebridge-alexa-smarthome.HomebridgeAlexaSmartHome'
[8/31/2023, 4:46:38 PM] ---
[8/31/2023, 4:46:38 PM] Loading 2 platforms...
[8/31/2023, 4:46:38 PM] [HomebridgeAlexaSmartHome] Initializing HomebridgeAlexaSmartHome platform...
Setup Payload:
X-HM://00241BD6RA51K
Enter this code with your HomeKit app on your iOS device to pair with Homebridge:
┌────────────┐
│ 342-36-547 │
└────────────┘

[8/31/2023, 4:46:39 PM] Homebridge v1.6.1 (HAP v0.11.1) (Homebridge 632D) is running on port 51319.
[8/31/2023, 4:46:56 PM] [HomebridgeAlexaSmartHome] After initialization - HttpError(Error getting smart home device state. Reason: Timeout)
[8/31/2023, 4:50:25 PM] [Homebridge UI] Starting terminal session
[8/31/2023, 4:50:35 PM] [Homebridge UI] Terminal session ended.
[8/31/2023, 4:50:35 PM] [Homebridge UI] Homebridge restart request received
[8/31/2023, 4:50:35 PM] [Homebridge UI] UI / Bridge settings have not changed; only restarting Homebridge process
[8/31/2023, 4:50:35 PM] [Homebridge UI] Sending SIGTERM to Homebridge
[8/31/2023, 4:50:35 PM] Got SIGTERM, shutting down Homebridge...
[8/31/2023, 4:50:40 PM] [HB Supervisor] Homebridge Process Ended. Code: 143, Signal: null
[8/31/2023, 4:50:45 PM] [HB Supervisor] Restarting Homebridge...
[8/31/2023, 4:50:45 PM] [HB Supervisor] Starting Homebridge with extra flags: -I -P /var/lib/homebridge/node_modules --strict-plugin-resolution
[8/31/2023, 4:50:45 PM] [HB Supervisor] Started Homebridge v1.6.1 with PID: 17406
[8/31/2023, 4:50:46 PM] Loaded config.json with 0 accessories and 2 platforms.
[8/31/2023, 4:50:46 PM] Loaded 0 cached accessories from cachedAccessories.
[8/31/2023, 4:50:46 PM] ---
[8/31/2023, 4:50:46 PM] Loaded plugin<EMAIL_ADDRESS>[8/31/2023, 4:50:46 PM] Registering platform 'homebridge-alexa-smarthome.HomebridgeAlexaSmartHome'
[8/31/2023, 4:50:46 PM] ---
[8/31/2023, 4:50:46 PM] Loading 2 platforms...
[8/31/2023, 4:50:46 PM] [HomebridgeAlexaSmartHome] Initializing HomebridgeAlexaSmartHome platform...
Setup Payload:
X-HM://00241BD6RA51K
Enter this code with your HomeKit app on your iOS device to pair with Homebridge:
[8/31/2023, 4:50:47 PM] Homebridge v1.6.1 (HAP v0.11.1) (Homebridge 632D) is running on port 51319.
[8/31/2023, 4:51:05 PM] [HomebridgeAlexaSmartHome] After initialization - HttpError(Error getting smart home device state. Reason: Timeout)
[8/31/2023, 4:51:24 PM] [Homebridge UI] Changes to config.json saved.
[8/31/2023, 4:51:24 PM] [Homebridge UI] Running Command: npm uninstall --save homebridge-alexa-smarthome
[8/31/2023, 4:51:36 PM] [Homebridge UI] Running Command: /opt/homebridge/lib/node_modules/homebridge-config-ui-x/plugin-upgrade-install.sh homebridge-alexa-smarthome 0.1.0 /var/lib/homebridge/node_modules
[8/31/2023, 4:51:57 PM] [Homebridge UI] Changes to config.json saved.
[8/31/2023, 4:53:13 PM] [Homebridge UI] Homebridge restart request received
[8/31/2023, 4:53:14 PM] [Homebridge UI] UI / Bridge settings have not changed; only restarting Homebridge process
[8/31/2023, 4:53:14 PM] [Homebridge UI] Sending SIGTERM to Homebridge
[8/31/2023, 4:53:14 PM] Got SIGTERM, shutting down Homebridge...
[8/31/2023, 4:53:19 PM] [HB Supervisor] Homebridge Process Ended. Code: 143, Signal: null
[8/31/2023, 4:53:24 PM] [HB Supervisor] Restarting Homebridge...
[8/31/2023, 4:53:24 PM] [HB Supervisor] Starting Homebridge with extra flags: -I -P /var/lib/homebridge/node_modules --strict-plugin-resolution
[8/31/2023, 4:53:24 PM] [HB Supervisor] Started Homebridge v1.6.1 with PID: 17517
[8/31/2023, 4:53:25 PM] Loaded config.json with 0 accessories and 2 platforms.
[8/31/2023, 4:53:25 PM] Loaded 0 cached accessories from cachedAccessories.
[8/31/2023, 4:53:25 PM] ---
[8/31/2023, 4:53:25 PM] Loaded plugin<EMAIL_ADDRESS>[8/31/2023, 4:53:25 PM] Registering platform 'homebridge-alexa-smarthome.HomebridgeAlexaSmartHome'
[8/31/2023, 4:53:25 PM] ---
[8/31/2023, 4:53:25 PM] Loading 2 platforms...
[8/31/2023, 4:53:25 PM] [HomebridgeAlexaSmartHome] Initializing HomebridgeAlexaSmartHome platform...
Setup Payload:
X-HM://00241BD6RA51K
Enter this code with your HomeKit app on your iOS device to pair with Homebridge:
[8/31/2023, 4:53:26 PM] Homebridge v1.6.1 (HAP v0.11.1) (Homebridge 632D) is running on port 51319.
[8/31/2023, 4:53:44 PM] [HomebridgeAlexaSmartHome] After initialization - HttpError(Error getting smart home device state. Reason: Timeout)
[8/31/2023, 4:54:33 PM] [Homebridge UI] Changes to config.json saved.
[8/31/2023, 4:56:43 PM] [Homebridge UI] Changes to config.json saved.
[8/31/2023, 4:59:11 PM] [Homebridge UI] Homebridge restart request received
[8/31/2023, 4:59:11 PM] [Homebridge UI] UI / Bridge settings have not changed; only restarting Homebridge process
[8/31/2023, 4:59:11 PM] [Homebridge UI] Sending SIGTERM to Homebridge
[8/31/2023, 4:59:11 PM] Got SIGTERM, shutting down Homebridge...
[8/31/2023, 4:59:16 PM] [HB Supervisor] Homebridge Process Ended. Code: 143, Signal: null
[8/31/2023, 4:59:21 PM] [HB Supervisor] Restarting Homebridge...
[8/31/2023, 4:59:21 PM] [HB Supervisor] Starting Homebridge with extra flags: -I -P /var/lib/homebridge/node_modules --strict-plugin-resolution
[8/31/2023, 4:59:21 PM] [HB Supervisor] Started Homebridge v1.6.1 with PID: 18245
[8/31/2023, 4:59:23 PM] Loaded config.json with 0 accessories and 2 platforms.
[8/31/2023, 4:59:23 PM] Loaded 0 cached accessories from cachedAccessories.
[8/31/2023, 4:59:23 PM] ---
[8/31/2023, 4:59:23 PM] Loaded plugin<EMAIL_ADDRESS>[8/31/2023, 4:59:23 PM] Registering platform 'homebridge-alexa-smarthome.HomebridgeAlexaSmartHome'
[8/31/2023, 4:59:23 PM] ---
[8/31/2023, 4:59:23 PM] Loading 2 platforms...
[8/31/2023, 4:59:23 PM] [HomebridgeAlexaSmartHome] Initializing HomebridgeAlexaSmartHome platform...
Setup Payload:
X-HM://00241BD6RA51K
Enter this code with your HomeKit app on your iOS device to pair with Homebridge:
┌────────────┐
│ 342-36-547 │
└────────────┘

[8/31/2023, 4:59:23 PM] Homebridge v1.6.1 (HAP v0.11.1) (Homebridge 632D) is running on port 51319.
[8/31/2023, 4:59:41 PM] [HomebridgeAlexaSmartHome] After initialization - HttpError(Error getting smart home device state. Reason: Timeout)
[8/31/2023, 5:30:37 PM] [Homebridge UI] Changes to config.json saved.
[8/31/2023, 5:30:37 PM] [Homebridge UI] Running Command: npm uninstall --save homebridge-alexa-smarthome
[8/31/2023, 5:30:53 PM] [Homebridge UI] Running Command: /opt/homebridge/lib/node_modules/homebridge-config-ui-x/plugin-upgrade-install.sh homebridge-alexa-smarthome 0.1.0 /var/lib/homebridge/node_modules
[8/31/2023, 5:31:12 PM] [Homebridge UI] Changes to config.json saved.
[8/31/2023, 5:32:47 PM] [Homebridge UI] Homebridge restart request received
[8/31/2023, 5:32:47 PM] [Homebridge UI] UI / Bridge settings have not changed; only restarting Homebridge process
[8/31/2023, 5:32:47 PM] [Homebridge UI] Sending SIGTERM to Homebridge
[8/31/2023, 5:32:47 PM] Got SIGTERM, shutting down Homebridge...
[8/31/2023, 5:32:52 PM] [HB Supervisor] Homebridge Process Ended. Code: 143, Signal: null
[8/31/2023, 5:32:57 PM] [HB Supervisor] Restarting Homebridge...
[8/31/2023, 5:32:57 PM] [HB Supervisor] Starting Homebridge with extra flags: -I -P /var/lib/homebridge/node_modules --strict-plugin-resolution
[8/31/2023, 5:32:57 PM] [HB Supervisor] Started Homebridge v1.6.1 with PID: 18895
[8/31/2023, 5:32:58 PM] Loaded config.json with 0 accessories and 2 platforms.
[8/31/2023, 5:32:58 PM] Loaded 0 cached accessories from cachedAccessories.
[8/31/2023, 5:32:58 PM] ---
[8/31/2023, 5:32:59 PM] Loaded plugin<EMAIL_ADDRESS>[8/31/2023, 5:32:59 PM] Registering platform 'homebridge-alexa-smarthome.HomebridgeAlexaSmartHome'
[8/31/2023, 5:32:59 PM] ---
[8/31/2023, 5:32:59 PM] Loading 2 platforms...
[8/31/2023, 5:32:59 PM] [HomebridgeAlexaSmartHome] Initializing HomebridgeAlexaSmartHome platform...
Setup Payload:
X-HM://00241BD6RA51K
Enter this code with your HomeKit app on your iOS device to pair with Homebridge:
┌────────────┐
│ 342-36-547 │
└────────────┘

[8/31/2023, 5:32:59 PM] Homebridge v1.6.1 (HAP v0.11.1) (Homebridge 632D) is running on port 51319.
[8/31/2023, 5:33:17 PM] [HomebridgeAlexaSmartHome] After initialization - HttpError(Error getting smart home device state. Reason: Timeout)
Show the Homebridge logs here, remove any sensitive information.

Plugin Config:
{
"bridge": {
"name": "Homebridge 632D",
"username": "0E:69:7F:F9:63:2D",
"port": 51319,
"pin": "",
"advertiser": "avahi"
},
"accessories": [],
"platforms": [
{
"name": "Config",
"port": 8581,
"platform": "config"
},
{
"auth": {
"refreshInterval": 4,
"proxy": {
"clientHost": "<IP_ADDRESS>",
"port": 2345
}
},
"devices": [],
"amazonDomain": "amazon.com",
"language": "en-US",
"debug": false,
"platform": "HomebridgeAlexaSmartHome"
}
]
}
Screenshots:

Environment:

Plugin Version: homebridge-alexa-smarthome v0.1.0
Homebridge Version: [v1.6.1]
Node.js Version: [v18.16.0]
NPM Version:
Operating System: Raspbian

I see a Timeout error in there. One thing you could try is explicitly providing the list of device names you want to link in the plugin config.

See that worked, thanks so much Joey!
On Thu, Aug 31, 2023 at 6:07 PM Joey Hage @.***> wrote:

I see a Timeout error in there. One thing you could try is explicitly
providing the list of device names you want to link in the plugin config.
—
Reply to this email directly, view it on GitHub
https://github.com/joeyhage/homebridge-alexa-smarthome/issues/20#issuecomment-1701971295,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFSOTJLMAZTWJCW6YLDQVMTXYEYMFANCNFSM6AAAAAA4G2NIVI
.
You are receiving this because you authored the thread.Message ID:
@.***>

You’re welcome!


url /pub/job backwards compatibiltiy

Hi @LookACastle
Regarding the fatman -> job degreasing, we had discussed backwards compatibility. This has been interpreted in the widest possible terms in the Lab and hence people have scripts calling the api endpoints, e.g. /pub/fatman///health, like so:
curl -X 'GET' \   '<dev url>/pub/job/<name>/<version>/health' \   -H 'accept: application/json'
which now fail with:
{"detail":"Not Found"}
I suspect this is due to the api endpoint no longer being hosted at /pub/fatman but only at /pub/job.
Should we add backwards compatibility here?

Fortunately, mount_at_base_path can accept multiple base path patterns as an argument:
https://github.com/TheRacetrack/plugin-python-job-type/blob/04bf59634ee23645d46eb16099304c7593905f67/python3-job-type/python_wrapper/racetrack_commons/api/asgi/proxy.py#L6
So changing this line
https://github.com/TheRacetrack/plugin-python-job-type/blob/04bf59634ee23645d46eb16099304c7593905f67/python3-job-type/python_wrapper/job_wrapper/api.py#L97 should do the trick.

Is there a test we could have somewhere that would have caught this detail?

It's possible. There's a decent chance such a test would've had the endpoint it was contacting renamed as well though.

Turns out the unit test wasn't checking against any base path. Now it's covered https://github.com/TheRacetrack/plugin-python-job-type/pull/14/commits/924638233aab47ab0f6c2fce10f66573a5825336


Support for CSI in Docker Managed Volume Plug-ins

This patch updates the Docker Managed Volume Plug-ins with support for CSI. If CSI_ENDPOINT is set to simply rexray.sock then the Docker module will be disabled and the CSI module will multiplex incoming connections to a gRPC server for CSI requests and a no-op Docker server in order to fulfill the contract for managed docker volume plug-ins.
Configuration
CSI support in the managed Docker plug-in is configured with environment variables:

Name
Default
Description

CSI_ENDPOINT

The endpoint used by the CSI module. Examples include:tcp://*:8080unix:///tmp/csi.sockIf set to just rexray.sock then the Docker module is disabled and the CSI module will multiplex incoming connections to a gRPC server for CSI requests and a no-op Docker server in order to fulfill the contract for managed docker volume plug-ins.

X_CSI_DRIVER
libstorage
The name of the CSI plug-in used by the CSI module. If X_CSI_NATIVE is set to a truthy value the default value for X_CSI_DRIVER becomes csi-vfs.

X_CSI_NATIVE
false
A flag that disables the CSI to libStorage bridge.

Codecov Report

Merging #1012 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1012      +/-   ##
==========================================
+ Coverage   34.16%   34.19%   +0.03%
==========================================
  Files          36       36
  Lines        2901     2901
==========================================
+ Hits          991      992       +1
+ Misses       1807     1806       -1
  Partials      103      103

Impacted Files
Coverage Δ

libstorage/api/types/types_localdevices.go
86.3% <0%> (+1.36%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80032b7...eecd717. Read the comment docs.


Unable to compile android template with qurobulet module.

On Windows, there are no errors with it, and if I remove the module, then the export android template is created without errors. Can this be fixed somehow? Sorry in advance for my English.

Thanks for letting me know about this! I haven't tried building android templates since this module was first released in 2020, so I've probably missed some breaking changes in Godot. I likely won't get to look into this until this weekend, but at that point I'll give compiling an android template a shot and fix any issues run into.

I've made some pre-built binaries for editors and templates on various platforms for Godot 3.4.4, including android templates. They can be found here: https://github.com/quinnvoker/godot-qurobullet/releases/tag/v1.1-godot-3.4.4


docs: Add tlsextraip + tlsextradomain to sample config

Include missing example configs for tlsextraip and tlsextradomain in sample-lnd.conf.
This is useful for users wishing to connect to lnd from a remote client.

Might be worth adding a note telling users they have to remove their old tls.key and tls.cert if they have already run the client and setting these configs?

can add "(old tls files must be deleted if changed)"

Added 👍

cool, LGTM! Could you squash the changes into a single commit? :)

Done :)


Updated security release archive with missing entries.

@carltongibson It looks like an update to the security release archive was missed. I've checked the release process in case it was missing and something needed amending, but I did find it here as point 3.
Hope these commits do the trick. They will need backporting as appropriate.

Hey Nick. Not so much missed as still on my envelope. Thanks for this. Yes!

Not so much missed as still on my envelope.

Sorry!

No, no problem! I’m very happy for the input. (It was on the list to be knocked off, but I wouldn’t have got to it until right now without your help so all for the good.)
Nice to know people are paying attention. Do keep it up. 🙂
Thanks!


-L flag in rgbasm has been deprecated and removed

-L flag in rgbasm has been deprecated and removed.
With rgbasm v0.8.0, -L is not recognized.
The previous use of -L seems to be the default behaviour.

Didn't #94 handle this?

There are still uses of -L around

https://github.com/gbdev/gb-asm-tutorial/pull/98 addresses an instance in Part II.
There's also -L in the asciinema recording in https://gbdev.io/gb-asm-tutorial/part1/hello_world.html

Found another in gb-asm-tutorial/galactic-armada/Makefile:
ASMFLAGS := -L


Minor README fixes

What should we add?
In README.md sometimes if the user directly copy-pastes the example code written, it might not work as expected. Two places where I found this were:

In README.md for the "Without and With Covalent" example, result = ct.get_result(dispatch_id), here since the default value of wait parameter is False, this might not give the expected result because it didn't wait for the calculation to complete. So, simply changing it to result = ct.get_result(dispatch_id, wait=True) will do the trick.

In the same file, ideally we would like to increase the width of the Without and With Covalent table, using some markdown magic in order to fit the dispatch_id = run_experiment.dispatch in one line.

In covalent_ui/README.md the port number is mentioned as 48008 whereas now the UI server runs at 47007 by default.

Hello can I solve this issue @kessler-frost .


⚠ Bofrost.at has degraded performance

In f77f2ae, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1840 ms

Resolved: Bofrost.at performance has improved in 645d2b3 after 13 minutes.


Bug Report: Plug-in crashing when docking with beta

Describe The Bug:
I installed the 3.0.0-beta2 version to see if it would resolve an issue that I was having where the plugin would fail to connect to iRobot if my Roomba 960 died during a job (the only way to restore functionality was to restart homebridge). The update went as expected and I saw the old device disappear and a new one appear in HomeKit (as expected). However, while it appears the plugin is able to connect to the iRobot platform and get the name of my Roomba (Roomberto), it fails to get its state or any of the metadata usually on the "devices" tab in Homebridge UI config. I also noticed a few additional errors which I have included in the logs below.
Other than the issue described above, the device was working as expected with v2.1.16 of the plugin.
To Reproduce:
Update plugin to 3.0.0-beta2.
Expected behavior:
The new device would appear in HomeKit with the correct status and is able to be controlled via HomeKit buttons and automations.
Logs:
[15/02/2022, 08:42:01] [HB Supervisor] Homebridge Process Ended.  The read handler for the characteristic 'On' was slow to respond! See https://git.io/JtMGR for more info.
[2/15/2022, 8:43:09 AM] [homebridge-irobot] This plugin slows down Homebridge. The read handler for the characteristic 'On' didn't respond at all!. Please check that you properly call the callback! See https://git.io/JtMGR for more info.
[2/15/2022, 8:43:14 AM] [homebridge-irobot] This plugin slows down Homebridge. The read handler for the characteristic 'On' was slow to respond! See https://git.io/JtMGR for more info.
[2/15/2022, 8:43:20 AM] [homebridge-irobot] This plugin slows down Homebridge. The read handler for the characteristic 'On' didn't respond at all!. Please check that you properly call the callback! See https://git.io/JtMGR for more info.

Config:
{
            "name": "iRobot",
            "email": "*****",
            "password": "*****",
            "manualDiscovery": false,
            "lowBattery": 20,
            "offAction": "stop:dock",
            "status": "phase:run",
            "sensors": [
                {
                    "type": "contact",
                    "condition": "binFull:true"
                }
            ],
            "platform": "iRobotPlatform",
            "_bridge": {
                "username": "0E:A2:87:18:C3:2A",
                "port": 42855
            }
        }

Node Version:
v16.14.0
NPM Version:
8.3.1
Homebridge Version:
1.4.0
Plugin Version:
<EMAIL_ADDRESS>Operating System:
Raspberian

I will try to fix the custom UI soon. In version 3 I store variables in different areas and I didn't update the UI yet.

I will try to fix the custom UI soon. In version 3 I store variables in different areas and I didn't update the UI yet.

OK, so that is just a cosmetic issue that isn't impacting the ability to correctly pull the state? As it stands, the device is present in the Home app, but it is labeled "No Response". Let me know if you need any additional logs and/or have anything you want me to try with that issue.

My devices are doing the same thing because the Roomba’s can only have one connection at a time and I can’t remember the trick I used last time to get them to accept connections from a new device. I will let you know when I find it

In the 2.1.16 "latest" version, I can get my 980 and J7 to both install and work. However, this only happens if I do the full manual install for both of them. However, the 980 would disconnect at the completion of every cleaning and would only reconnect if I rebooted the plugin bridge. I tried to install the Beta 5 version, and it wouldn't work. I tried it from a fresh install and an update from the latest version, and only the 980 would connect. I manually added in the code with the missing options from the 2.1.16 version, and I still couldn't get it to work.
Here's the setup for the 2.1.16 I was able to get working, but it didn't work with the Beta 5:
{
    "name": "iRobot",
    "email": "",
    "password": "",
    "roombas": [
        {
            "name": "Rupa",
            "blid": "",
            "password": "",
            "autoConfig": false,
            "ip": "",
            "model": "980",
            "info": {
                "sw": "v2.4.16-126",
                "serialNum": "",
                "mac": "FO:03:8C:E1:46:65",
                "ver": 2,
                "sku": "R980020"
            }
        },
        {
            "name": "Martha",
            "blid": "",
            "password": "",
            "autoConfig": false,
            "ip": "",
            "model": "J7+",
            "multiRoom": true,
            "info": {
                "sw": "v1.2.12",
                "serialNum": "",
                "mac": "50:14:79:b3:fb:02",
                "ver": 2,
                "sku": "j75x020"
            }
        }
    ],
    "manualDiscovery": true,
    "lowBattery": 20,
    "offAction": "pause:dock",
    "status": "phase:run",
    "eveStatus": "inverted:cycle:clean",
    "bin": "filter:contact",
    "ignoreMultiRoomBin": true,
    "hideStuckSensor": false,
    "disableMultiRoom": false,
    "platform": "iRobotPlatform"
}
I'm stuck in the same situation as a couple days ago and having to just run the Roomba2 plugin, which requires two versions to account for the cipher difference between the two robots. I'd welcome any suggestions as I much prefer your plugin over the other one, especially since you're actively updating it.

I will fix this beta error later today (hopefully) but I won’t have access to testing until tonight

Just a quick update... I noticed beta10 was released and gave it a shot on Saturday... unfortunately, my issues persist. I will say that every once in awhile it will show as "battery low" in the Home app and sometimes I am able to start it running, but if I try to stop it the plugin crashes. I can try to grab those logs if that would be helpful.
[2/20/2022, 10:36:07 PM] [iRobot] [Roomberto] Failed To Update State:  Roomba Offline [2/20/2022, 10:36:19 PM] [iRobot] [Roomberto] Failed To Fetch Robot Status  Roomba Offline [2/20/2022, 10:36:19 PM] [homebridge-irobot] This plugin threw an error from the characteristic 'On': Unhandled error thrown inside read handler for characteristic: undefined. See https://git.io/JtMGR for more info.

Those betas are broken. I will go over and publish a new beta real quick

I just published a new beta that fixes this

Updated this morning and the device appears as expected in Home app... the following shows up in logs, but I was able to start the Roomba with no issue.
[2/21/2022, 8:17:38 AM] [homebridge-irobot] This plugin slows down Homebridge. The read handler for the characteristic 'On' was slow to respond! See https://git.io/JtMGR for more info. [2/21/2022, 8:17:38 AM] [homebridge-irobot] This plugin slows down Homebridge. The read handler for the characteristic 'Status Low Battery' was slow to respond! See https://git.io/JtMGR for more info. [2/21/2022, 8:17:38 AM] [homebridge-irobot] This plugin slows down Homebridge. The read handler for the characteristic 'Battery Level' was slow to respond! See https://git.io/JtMGR for more info. [2/21/2022, 8:17:38 AM] [homebridge-irobot] This plugin slows down Homebridge. The read handler for the characteristic 'Charging State' was slow to respond! See https://git.io/JtMGR for more info. [2/21/2022, 8:17:38 AM] [homebridge-irobot] This plugin slows down Homebridge. The read handler for the characteristic 'Contact Sensor State' was slow to respond! See https://git.io/JtMGR for more info.
However, when I stopped my test job, it threw the following error (I have the plugin configured to "stop + dock".
[2/21/2022, 8:19:53 AM] [iRobot] [Roomberto] stoping... [2/21/2022, 8:19:58 AM] [iRobot] [Roomberto] docking... UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "Roomba Offline". [21/02/2022, 08:19:58] [iRobot] Child bridge process ended [21/02/2022, 08:19:58] [iRobot] Process Ended. Code: 1, Signal: null [21/02/2022, 08:20:05] [iRobot] Restarting Process... [21/02/2022, 08:20:06] [iRobot] Launched child bridge with PID 6209 [2/21/2022, 8:20:07 AM] Registering platform 'homebridge-irobot.iRobotPlatform' [21/02/2022, 08:20:07] [iRobot] Loaded homebridge-irobot v3.0.0-beta.11 child bridge successfully [2/21/2022, 8:20:07 AM] Loaded 1 cached accessories from cachedAccessories.0EA28718C32A. [2/21/2022, 8:20:07 AM] [iRobot] Loading accessory from cache: Roomberto [2/21/2022, 8:20:07 AM] [iRobot] Logging into iRobot... [2/21/2022, 8:20:07 AM] Homebridge v1.4.0 (HAP v0.10.0) (iRobot) is running on port 42855. [2/21/2022, 8:20:08 AM] [iRobot] Restoring existing accessory from cache: Roomberto

That is weird. I will have to add a catch block to fix this. Try setting your Roomba to pause and dock, maybe your Roomba enters a low power type mode when it doesn't have a job active

Just a quick update... I switched to manually configure my Roomba and it has been responsive and showing correct status in the Home app. I am still having an issue where the "Stop and Dock" off action causes the plugin to crash, but I believe it is the same as I reported above (and it sounds like can be addressed in the future).
[23/02/2022, 08:06:01] [I’m Home] Setting switch to true
[2/23/2022, 8:06:05 AM] [iRobot] [Roomba] stoping...
[2/23/2022, 8:06:10 AM] [iRobot] [Roomba] docking...
UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "Roomba Offline".
[23/02/2022, 08:06:10] [iRobot] Child bridge process ended
[23/02/2022, 08:06:10] [iRobot] Process Ended. Code: 1, Signal: null

Just wanted to add a little more information... I had changed the configuration to "pause and dock" as previously suggested and it had worked well for a little bit of time. However, today it  threw the same error and the plugin crashed. I think it may have something to do with when the Roomba doesn't make it back home before the battery dies. My assumption is that since the Roomba is "dead", the plugin is unable to fetch a new status since it is offline.
That could be completely wrong of course. 😆
[3/9/2022, 10:42:36 AM] [iRobot] [Roomba] Failed To Fetch Robot Status
Roomba Offline
[3/9/2022, 10:42:36 AM] [homebridge-irobot] This plugin threw an error from the characteristic 'On': Unhandled error thrown inside read handler for characteristic: undefined. See https://git.io/JtMGR for more info.
[3/9/2022, 10:42:36 AM] [iRobot] [Roomba] pausing...
UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "Roomba Offline".
[09/03/2022, 10:42:36] [iRobot] Child bridge process ended
[09/03/2022, 10:42:36] [iRobot] Process Ended. Code: 1, Signal: null
[09/03/2022, 10:42:37] [Guest Mode] Setting switch to false
[09/03/2022, 10:42:37] [Security System] Target mode (Off)
[09/03/2022, 10:42:37] [Security System] Current mode (Off)
[09/03/2022, 10:42:42] [hue-deconz] Power 31: set homekit status fault from 0 to 1
[09/03/2022, 10:42:42] [hue-deconz] Consumption 32: set homekit status fault from 0 to 1
[09/03/2022, 10:42:43] [iRobot] Restarting Process...
[09/03/2022, 10:42:45] [iRobot] Launched child bridge with PID 23125
[3/9/2022, 10:42:45 AM] Registering platform 'homebridge-irobot.iRobotPlatform'
[09/03/2022, 10:42:46] [iRobot] Loaded homebridge-irobot v3.0.0-beta.12 child bridge successfully
[3/9/2022, 10:42:46 AM] Loaded 1 cached accessories from cachedAccessories.0EA28718C32A.
[3/9/2022, 10:42:46 AM] [iRobot] Loading accessory from cache: Roomba
[3/9/2022, 10:42:46 AM] [iRobot] Logging into iRobot...

Please try the latest beta:

Unfortunately, I am not able to get the new device configuration interface to work... it just spins. I tried holding down the clean button until my Roomba chimes to clear any connections, but that didn't seem to help. Will continue trying to get it to work.

I will look into this, was it on the add devices page after you put in an email and password that it just spins?

It never asks for my email and password; I get the "Settings" screen where it asks for the "Name" and "Log Level". When I click on the "Devices" button, the view switches and I see a gear icon that never stops spinning so I cannot interact with any of the buttons on that page. Hopefully that helps; I can provide screenshots if needed.

Could you open up the browsers console and see if their are any errors

Didn't see anything too crazy... got this one when I clicked "Settings" on the plugin screen, but nothing else. Tried in both Safari and Edge.
Error while parsing the 'sandbox' attribute: 'allow-downloads' is an invalid sandbox flag.

The allow-downloads warning is generated by homebridge, could you please try hitting command+option+e in Safari then reloading the page and trying again?

Unfortunately, no change in functionality but I did get one more error message.
Unhandled Promise Rejection: TypeError: plugin.showIntro is not a function. (In 'plugin.showIntro()', 'plugin.showIntro' is undefined)
I am able to save the base configuration (below), but then HB will throw errors on restart (I assume because the setup isn't actually complete).

{
"name": "iRobot",
"logLevel": 3,
"autoConnect": true,
"alwaysShowModes": false,
"platform": "iRobotPlatform"
}

Errors:

[02/01/2023, 12:11:45] TypeError: this.config.accessories is not iterable
at iRobotPlatform.discoverDevices (/usr/local/lib/node_modules/homebridge-irobot/src/platform.ts:101:38)
at HomebridgeAPI. (/usr/local/lib/node_modules/homebridge-irobot/src/platform.ts:60:12)
at HomebridgeAPI.emit (node:events:525:35)
at HomebridgeAPI.signalFinished (/usr/local/lib/node_modules/homebridge/src/api.ts:275:10)
at Server.start (/usr/local/lib/node_modules/homebridge/src/server.ts:190:14)
[02/01/2023, 12:11:46] Got SIGTERM, shutting down Homebridge...
[02/01/2023, 12:11:46] AssertionError [ERR_ASSERTION]: Cannot generate setupURI on an accessory that isn't published yet!
at Bridge.Accessory.setupURI (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/src/lib/Accessory.ts:994:11)
at Server.setServerStatus (/usr/local/lib/node_modules/homebridge/src/server.ts:155:45)
at Server.teardown (/usr/local/lib/node_modules/homebridge/src/server.ts:199:10)
at signalHandler (/usr/local/lib/node_modules/homebridge/src/cli.ts:93:12)
at process.emit (node:events:513:28)
at process.emit (/usr/local/lib/node_modules/homebridge/node_modules/source-map-support/source-map-support.js:516:21)

I think I know where the plugin.showIntro error is and will fix it soon, I’ll keep you posted

plugin.showIntro error patched v4.0.0-beta.3. (Note: After updating you may have to do the command+option+e followed by a browser refresh. This forces safari not to used the last cached file)

It never asks for my email and password; I get the "Settings" screen where it asks for the "Name" and "Log Level". When I click on the "Devices" button, the view switches and I see a gear icon that never stops spinning so I cannot interact with any of the buttons on that page. Hopefully that helps; I can provide screenshots if needed.

Just found the bug, patched it in v4.0.0-beta.4

Looks like I got the "Devices" screen to work, but I had to save the "settings" configuration first, and then reopen and select "Devices"... if I didn't do it in that order I got the continuously spinning gear. Have to put my daughter down for a nap and will come back to see if I run into anything else.

Looks like it is working... I did get the following error messages after configuring the Roomba, but it has not appeared (yet?) on subsequent reboots.

[02/01/2023, 13:49:20] [homebridge-irobot] This plugin threw an error from the characteristic 'Status Low Battery': Unhandled error thrown inside read handler for characteristic: Cannot read properties of undefined (reading 'batPct'). See https://homebridge.io/w/JtMGR for more info.
[02/01/2023, 13:49:20] [homebridge-irobot] This plugin threw an error from the characteristic 'Battery Level': Unhandled error thrown inside read handler for characteristic: Cannot read properties of undefined (reading 'batPct'). See https://homebridge.io/w/JtMGR for more info.
[02/01/2023, 13:49:20] [homebridge-irobot] This plugin threw an error from the characteristic 'Charging State': Unhandled error thrown inside read handler for characteristic: Cannot use 'in' operator to search for 'cleanMissionStatus' in undefined. See https://homebridge.io/w/JtMGR for more info.

The device that gets exposed is a TV accessory... is that the expected behavior in v4.0?  Basic functionality seems to work, will require me to rethink a few of the automations I used (I think). Will update if any issues are seen over the next few days!

That shouldn’t reappear, I forgot to set default values to use if the Roomba isn’t connected yet but after the initial connection it will store the last state
The TV is intentional as it allows more customization for the robot, the options dynamically change based off of the robots current state.
Automations should work fine, just make sure that in the automation you change the option to whatever you want

Here’s a video of the scene I use demonstrating the options. (Pay attention to what it shows under the accessory name once opened)
https://user-images.githubusercontent.com/75853497/210270945-01793a5b-b3ad-48a3-90d4-cd795b9b6bc5.MOV

I’d recommend turning the Always Show Modes option on during scene/automation setup so that you don’t have to turn the Roomba on the see the dock options. (Note: once the scene is setup, even if the robot is not ready for that command it will still be sent. (Ex. If you run an empty bin scene while your Roomba is running it will play an error tone even though you can’t see the option in the home app)

Awesome thanks will reference this as I rebuild them later this evening. The interface is pretty slick once you understand what is being done! Will report back if I find any errors or issues.

👍, also if you didn’t figure out already, the big power button at the top is what connects and disconnects from the robot

So far basic testing has been successful and I have not had any connectivity errors so far. :)
I have been able to recreate all of my automations using the new accessory except one... I had a dummy switch that would "turn on" when the Roomba started. This allowed me to use a conditional on my "leaving" automation that prevented the Roomba from starting again if it had already run earlier in the day. I'm pretty sure I can't make an automation that says if Roomba status equals "Clean Everywhere", turn on "Vacuum Ran Today" switch. Gonna have to think on this one a bit...

Unfortunately, the one drawback of setting it up as a TV is that HomeKit won’t let third-party apps see it, I plan to make a workaround for this in the near future
I also intend to re-add the ability to expose a contact sensor for bin-full, running, etc.

Some additional datapoints from this morning... I've found that the 960 doesn't always make it back to its base before the battery dies. Looking at these logs, the battery appears to have died this morning at 10:25:00. My "I'm Home" automation tried to return it to the dock, but the device was unavailable (because the battery died). It repeated the disconnected message every second until I found the Roomba and placed it on its base so it could start charging... good news is that it seems to have reconnected successfully (this didn't always seem to work 100% of the time with previous plugins 🥳).
Not sure if they need addressed, but I did get two "this plugin slows down Homebridge" messages at [03/01/2023, 10:49:28] (shown below). This might be a byproduct of the device having no power, but wanted to post them just in case.

[03/01/2023, 09:16:38] [I’m Home] Setting switch to false
[03/01/2023, 09:16:41] [iRobot] Roomberto: Cleaning Everywhere
[03/01/2023, 10:25:00] [iRobot] Roomberto: Stopped
[03/01/2023, 10:25:10] [iRobot] Roomberto: Unavailable
[03/01/2023, 10:25:10] [iRobot] Roomberto: Disconnected
[03/01/2023, 10:25:11] [iRobot] Roomberto: Disconnected
[03/01/2023, 10:49:18] [I’m Home] Setting switch to true
[03/01/2023, 10:49:18] [iRobot] Roomberto: Connecting...
[03/01/2023, 10:49:18] [iRobot] Roomberto: Unavailable
[03/01/2023, 10:49:18] [iRobot] Roomberto: Disconnected
[03/01/2023, 10:49:18] [iRobot] Roomberto: Connecting...
[03/01/2023, 10:49:18] [iRobot] Roomberto: Connecting...
[03/01/2023, 10:49:18] [iRobot] Roomberto: Unavailable
[03/01/2023, 10:49:18] [iRobot] Roomberto: Disconnected
[03/01/2023, 10:49:18] [iRobot] Roomberto: Failed to pause
[03/01/2023, 10:49:18] [iRobot] Roomberto: Disconnected
[03/01/2023, 10:49:18] [iRobot] Roomberto: Paused
[03/01/2023, 10:49:19] [iRobot] Roomberto: Disconnected
[03/01/2023, 10:49:19] [iRobot] Roomberto: Disconnected
[03/01/2023, 10:49:20] [iRobot] Roomberto: Disconnected
[03/01/2023, 10:49:22] [iRobot] Roomberto: Disconnected
[03/01/2023, 10:49:23] [iRobot] Roomberto: Disconnected
[03/01/2023, 10:49:24] [iRobot] Roomberto: Disconnected
[03/01/2023, 10:49:25] [iRobot] Roomberto: Disconnected
[03/01/2023, 10:49:26] [iRobot] Roomberto: Disconnected
[03/01/2023, 10:49:27] [iRobot] Roomberto: Disconnected
[03/01/2023, 10:49:28] [homebridge-irobot] This plugin slows down Homebridge. The write handler for the characteristic 'Active Identifier' on the accessory 'Roomberto E783' didn't respond at all!. Please check that you properly call the callback! See https://homebridge.io/w/JtMGR for more info.
[03/01/2023, 10:49:28] [homebridge-irobot] This plugin slows down Homebridge. The write handler for the characteristic 'Active' on the accessory 'Roomberto E783' didn't respond at all!. Please check that you properly call the callback! See https://homebridge.io/w/JtMGR for more info.
[03/01/2023, 10:49:28] [iRobot] Roomberto: Disconnected
... continued every second until ...
[03/01/2023, 10:51:35] [iRobot] Roomberto: Disconnected
[03/01/2023, 10:51:39] [iRobot] Roomberto: Connected

There might be more to the above... I left and came home again (this time the Roomba did not run while I was gone). My "I'm Home" automation tells the Roomba to "Go Home". In this case, the plugin disconnected and the Roomba showed "No Response" in HomeKit until I restarted the plugin. My guess is that it didn't like me sending the "go home" when it wasn't needed (because it was already home). Is there a logging level that I can enable that might provide additional info to confirm this?
I might be able to workaround this once the contact sensors are re-implemented (ie. conditionals on my automations), but if there is a cleaner way to do it, I'd prefer giving that a shot.


Publish to Modrinth

Publish and setup auto-deployment to the Modrinth platform

To reassess once the platform becomes more stable and/or out of beta.

becomes more stable

It is not unstable, if that is what you're implying.


added custom descriptions  to Degree, Hour and JulianDay

Looks much prettier ;-)

One day, one will have to introduce generic decimal/sexagesimal transformations. Could be a useful representation of those numbers. But that could wait for a 2.1.


Add cli flag to only export completed tasks

I don't really see the usecase for that in the export-subcommand atm but the code lgtm, can you elaborate why you think this feature is useful?

I don't really see the usecase for that in the export-subcommand

😳 I was really surprised that it only exported the open tasks.
If I export data from a program I expect it to export all data it has.
So I actually I would per default export the open and the completed tasks
and add --open and --completed flags if one wants to only export a subset.

If you export your emails from your email app you don't expect it to only export your unread emails either, would you?  ^^

So I actually I would per default export the open and the completed tasks
and add --open and --completed flags if one wants to only export a subset.

Yeah, that sounds like the right way to do it, feel free to open another PR for the additional flag and changing the default output (or include it into this one).
Therefore I will merge your PR once you fix the two things I mentioned in my review.

Anything I can help you with to get this PR ready for merge @adius ?

Not sure if this is the most beautiful solution,
but the limited Wunderlist API doesn't make things easy…

Thanks for taking a look again and implementing the additional flag right away.
I'm not sure about changing the default, though. What do you think, @wayneashleyberry ?

From my side I'd leave these filters out of the export command. Export was only ever intended to give you all of your data, what you then choose to do with it is up to you.
There are many tools available such as jid and jq which provide excellent filtering for json.
Here is an example of filtering only your starred tasks from a full export using jq.
wunderline export | jq '.data.lists[].tasks[] | select(.starred == true)'

Hey @adius, I'm going to close this pull request. I appreciate you pointing out that completed tasks weren't being exported, but I've opted for a simpler implementation.

Merged in https://github.com/wayneashleyberry/wunderline/pull/105 and published as v4.4.4.
Please let me know if you're happy @adius. I've also updated the readme with examples for filtering out the exported data.

Looks good, Thanks!


The method AugmentedModel::wrapModelAccessor resolves Attribute getter without passing params $value and $attributes

Description
On this line AugmentedModel.php#L189 the attribute getter is called without passing any params. This causes the method to break when one of those params is required.
Changing the method to something like this resolves the issue:
$attributes = $this->data->getAttributes();
return ($attribute->get)($attributes[$handle], $attributes);

Before I open an PR I wanted to check if this was setup like this intentionally.
Steps to reproduce

Create a model with an Attribute that uses a getter whit an value, for example:

 public function slug(): Attribute
    {
        return Attribute::make(
            set: function($input) {
                $slug = Str::slug($input);
                $found = 0;
                while (Club::where('slug', '=', $slug)->count()) {
                    $found++;
                    $slug = Str::slug($input . "-{$found}");
                }

                return $slug;
            },
            get: fn (?string $value) => $value,
        );
    }

Do something that creates the AugmentedModel. For example in a entry that has a Runway model ($my_model) linked trough an BelongsTo field.

{{ $my_model->value() }}

calling ->value() causes the method to break as it is creating the AugmentedModel.
Environment
Environment
Laravel Version: 11.20.0
PHP Version: 8.3.12
Composer Version: 2.7.7
Environment: local
Debug Mode: ENABLED
Maintenance Mode: OFF
Timezone: UTC
Locale: nl
Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: CACHED
Drivers
Broadcasting: log
Cache: file
Database: mysql
Logs: stack / single
Mail: smtp
Queue: sync
Session: file
Livewire
Livewire: v3.5.4
Sentry
Enabled: MISSING DSN
Environment: local
Laravel SDK Version: 4.8.0
PHP SDK Version: 4.9.0
Release: NOT SET
Sample Rate Errors: 100%
Sample Rate Performance Monitoring: NOT SET
Sample Rate Profiling: NOT SET
Send Default PII: DISABLED
Statamic
Addons: 6
Sites: 2 (Nederlands, Engels)
Stache Watcher: Enabled
Static Caching: Disabled
Version: 5.22.0 PRO
Statamic Addons
alt-design/alt-redirect: 1.3.2
alt-design/alt-seo: 1.2.1
alt-design/alt-sitemap: 1.2.2
doefom/currency-fieldtype: 1.4.1
statamic-rad-pack/runway: dev-morphmany
statamic/eloquent-driver: 4.15.2
Statamic Eloquent Driver
Asset Containers: file
Assets: eloquent
Blueprints: file
Collection Trees: eloquent
Collections: file
Entries: eloquent
Forms: file
Global Sets: file
Global Variables: eloquent
Navigation Trees: eloquent
Navigations: file
Revisions: file
Sites: file
Taxonomies: file
Terms: eloquent
Tokens: eloquent

I think we just didn't consider attributes with params - if you are happy to open a PR with tests for it please do.

Opened PR #629


Basic Documentation on how to use this in a Rails app

It would be really helpful to see a few lines of documentation to describe how to use this tool in a Rails app with rich text trix editor.
Without any documentation, it's really not useful even though the plugin looks great.

It is basically download repository and extract it to your rails project and add require("richtext") to /javascript/packs/application.js

Hello @lazaronixon,
Thank you for your work on this extension ! Where exactly should we extract the repository in our project ? Anywhere in the repo ? Or somewhere like /javascript/packs/ ? I can't figure it out but I need your extension so badly !
Thanks

You should extract it on root directory

You should extract it on root directory

Okay, just did it... But I'm getting this error Module not found: Error: Can't resolve 'richtext' in '/Users/robeen/dev/tourcrib/app/javascript/packs' any idea what's wrong ?
Here is my file structure :

tourcrib
...
trix-extensions
...

Thanks for your help

Okay, I kinda managed to make it work... My only issue now is that when I save, the trix editor strips the <h2-6> tags as well as the style="" attributes. Even tho I added :
Rails.application.config.after_initialize do
   ActionText::ContentHelper.allowed_attributes.add 'style'

   ActionText::ContentHelper.allowed_tags.add 'h2'
   ...
end

Do you have any idea what's up ?

Agreed. This needs "how-to" text to be generally useful. I'll see if I can figure it out.

@r-obeen
if you just use it does not work?
In my case, it worked very well.
Rails.application.config.after_initialize do
   ActionText :: ContentHelper.allowed_attributes << 'style'
end

Hey, I can confirm that this after_initialize does not work in Rails <IP_ADDRESS>
If I just do ActionText::ContentHelper.allowed_attributes << 'style' in a config/initializers/action_text.rb (or wherever) it works.
But if I use the after_initialize do ... end it does not work! :)


event.originalEvent is of type MouseEvent when touching

[x ] I've looked at the documentation to make sure the behavior is documented and expected
[x ] I'm sure this is a Leaflet code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
[ x] I've searched through the issues to make sure it's not yet reported

Steps to reproduce
Steps to reproduce the behavior:

setup a basic map like jsfiddle
open with touch device and tap on the (empty) map
inspect browser console logs

Expected behavior
The logged event.originalEvent should be of type TouchEvent as documented here
Current behavior
The logged event.originalEvent is of type MouseEvent
Environment

Leaflet version: 1.5.1
Browser (with version): iOS Safari 12.3.1
OS/Platform (with version): iOS

Additional context

Minimal example reproducing the issue
jsfiddle
Please create an example using https://leafletjs.com/edit.html or any other jsfiddle-like site.

[x ] this example is as simple as possible
[x ] this example does not rely on any third party code

Behaviour as expected. In that jsfiddle you're listening for the click event, which is always a MouseEvent, as per https://developer.mozilla.org/en-US/docs/Web/API/Element/click_event . Compare with https://developer.mozilla.org/en-US/docs/Web/API/Element/touchstart_event
I suggest watching the "getting touchy" presentation to understand why touch-only stuff fire mouse events: https://invidio.us/watch?v=bBdQkhm1DvI and https://patrickhlauke.github.io/getting-touchy-presentation/#

@IvanSanchez The leaflet docs says that click-event is a Leaflet MouseEvent which should point to The original DOM MouseEvent or DOM TouchEvent that triggered this Leaflet event. and that is obviously not the case. After all I cannot listen to a 'touchstart' event on the leaflet map, but I need the actual DOM Touchevent to check for the Touch.touchType

The leaflet docs says that click-event is a Leaflet MouseEvent [...] and that is obviously not the case.

Yes it is. The DOM click event is what triggers the Leaflet click event.
Whenever you tap on a touchscreen, there are several DOM events going on there (in different order depending on the browser):

mousedown → triggers a Leaflet mousedown event
touchstart → doesn't trigger any map event
pointerdown → doesn't trigger any map event
click → triggers a Leaflet click event
mouseup → triggers a Leaflet mouseup event
touchend → doesn't trigger any map event
pointerup → doesn't trigger any map event

So A, B, C, D, E happen at once, and C triggers F, and F has a reference to C. And you say "But I want F to have a reference to B instead!", to which the answer is "no, that's no how things work".
Seriously, "getting touchy". Watch it.

I need the actual DOM TouchEvent to check for the Touch.touchType

Then L.DomEvent.on(map.getContainer(), 'touchstart touchmove touchend', handler).

Thank you very much for the feedback @IvanSanchez. L.DomEvent.on(map.getContainer(), 'touchstart touchmove touchend', handler). is what I was looking for.


Create common CRD validate and mutating webhook for all operator

If the spec of tfjob is invalid, we should reject the request when creating and also set default when create tfjob.  we can use the k8s webhook to do this. And also we can replace the unstructured informer code.

cc @gaocegege  @johnugeorge @richardsliu

It is a good idea. I think we need it.

Personally, I think we should use validation webhook instead of the unstructured informer in the code.

@gaocegege Yes. agree with that. I think we can use one webhook server for all the operator to do validate or set default value,  WDYT?

Personally, SGTM.
WDYT @johnugeorge @richardsliu

LGTM.  However, we should not take this up in this release as we are late.

Yeah, I think so

@gaocegege @johnugeorge @richardsliu So we need create a new repository for the webhook, then I can start the webhook work.

We need a detailed proposal to persuade the community to open a new repo.

Just wondering why do we need a separate repo for webhook?

I think we need a proposal first, then we can discuss it and decide if we need a repo for it.
@wackxu Are you interested in the proposal? I can co-work with you if you are busy.

Just wondering why do we need a separate repo for webhook?

We may want to add validate webhook for all operators and we have about six operators, so I think use one operator for all operators and we can use some switch to let user to choose which webhook to use.

I think we need a proposal first, then we can discuss it and decide if we need a repo for it.
@wackxu Are you interested in the proposal? I can co-work with you if you are busy.

I am busy with some internal work recently. You can start write the proposal and I can help review and implement the code.

@wackxu Maybe we could have a meeting later to make sure that we are on the same page.

@gaocegege yes, we can talk more details in the slack.

@wackxu Are you planning to take this up?

Related: https://github.com/kubeflow/tf-operator/issues/1026

@johnugeorge Sorry for the delay, Yes I will but we need a new repo for it first.

@johnugeorge Should we take this on for 0.7?

@wackxu Why do you need a separate repo for it?

@johnugeorge I think we should add webhook for all operators. If we do not put them in a single repo, then we should add webhook for each operator separately. It is not convenient for user that use multiple operator to deploy and maintain.

We can use switch to control which webhook is turned on. If user only use one operator such as tf-operator, then he can only turn on the tf webhook switch. It is convenient for user to manage these operator webhook.

@wackxu @johnugeorge Is there any update? I think it is an important feature.

@gaocegege  This is not yet taken up

/area gsoc

/cc @carmark
I think we can reuse this repo to keep the webhook if needed. https://github.com/kubeflow/crd-validation

Do we still need to create our validation webhook? It looks like Kubernetes custom resources now allow schemas to be specified using OpenAPI in which case valdiation will happen automatically.
https://kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/#specifying-a-structural-schema
Related: kubeflow/katib#1170

Do we still need to create our validation webhook? It looks like Kubernetes custom resources now allow schemas to be specified using OpenAPI in which case valdiation will happen automatically.
https://kubernetes.io/docs/tasks/access-kubernetes-api/custom-resources/custom-resource-definitions/#specifying-a-structural-schema
Related: kubeflow/katib#1170

This seems like a good idea. Only thing to watch for is this feature is supported only K8S Cluster version 1.16 and above!


Run Command Shortcut (Ctrl + .) does't work anymore on Linux

Since the last update (0.5.11) the (Ctrl + .) command shortcut to open the "Run Command" page doesnt work anymore. The other Shortcut (Ctrl + /) still works fine.
When I use (Ctrl + .) on Linux it prints the letter "e" while using Firefox. No problem when using Vivaldi (Chrome based browser).
On Windows it works on Firefox as expected.

Could you try this? Switch to the edge build, and put this in your SETTINGS page:
shortcuts:
- command: "{[Open Command Palette]}"
  key: "Ctrl-."

On my Linux Firefox (118.0.1) Ctrl-. works fine. But perhaps it's a keyboard type issue? Not sure what changed here.

Sadly that didnt change anything.
I tried incognito mode (didnt change anything).
I also tried to another key (Ctrl-e and Ctrl-y) for the command palette, neither of which were working Firefox or vivaldi.
Meanwhile Ctrl-. works consistently on vivaldi (even when it was changed to another key, not sure if this is intendet)
I am running Firefox 121.0.1

Odd. However with the settings change I described you can assign it to any other key you like.

Ok I tested it on a similar linux pc with firefox, there it worked like intended. Seems like a weird problem with my setup.

I found a solution, so if anyone else runs into the same problem, take a look here:
https://superuser.com/questions/1687342/what-is-my-x11-doing-with-ctrl-period-and-how-can-i-disable-it
tldr: keyboard shortcut from gnome overwrites seems to catch ctrl+. before firefox (apparently doesn't happen for chromium). To disable run:

gsettings set org.freedesktop.ibus.panel.emoji hotkey "@as []"

fixed the issue


Add power on method to call a service

I want to call an HA service to power on the TV instead of using the WOL method provided. In my case, I am using HA in the Kubernetes environment where the WOL does not reach the LAN where the TV is, and instead of that, I use the rest_command service.
I previously used the official integration, where I can configure turn_on_action to call that service. This MR will make it equivalent to that configuration. Even you could remove the WOL implementation, and the user could rely on the Wake On LAN HA integration by calling its service.

Could you rebase this?

Could you rebase this?

Sure! Done.

Just to mention that Home Assistant official integrations with similar needs are adopting the trigger mechanism, where you can implement your own automation for.
Example, triggers when the TV is requested to power on:
platform: samsungtv.turn_on
entity_id: media_player.samsung_tv


Powershell missing from RHEL 9 Repository

Describe the problem you are experiencing.
PowerShell is not in the Repository for RHEL 9 (https://packages.microsoft.com/rhel/9/)
Describe any possible solutions that you would like to see.
Add PowerShell to the repository like it is for 7 and 8 so we can properly support/patch PowerShell on Linux systems.

Hi @mbrownewu, the Linux packaging team owns the package.microsoft.com platform but we don't build/maintain/publish packages to packages.microsoft.com. Please file an issue at https://github.com/PowerShell/PowerShell/issues.


Plans to support Forge?

Curious if this is something you're working on. I may be able to chip away at it.
I would also appreciate any pointers if there is already a forge mod that does this for 1.18 that I'm missing!

Sorry, but I have too many problems with loading the same mixins on Forge. That's why I decided not to release the Forge version. You can use the shared part and try to create it yourself, I allow.


Add Tenable Plugin Info to References

Is your feature request related to a problem? Please describe
Tenable Vulnerability Scanner use so called Plugins to check a given host for the existence of Vulnerabilities.
Plugins can be thought of as a Script telling the scanner "Connect to port X, check for the Version string Y and if found do Z" These Plugins do have a unique Id and the plugin content can change over time. In every scan export, the Plugin Id, Published Date and Modified Date are contained.
After importing the Scan information, the Information which Plugin Id and the date values of the Plugin are discarded so there is no possibility to check from Defect Dojo which Plugin Version was used to find the Vulnerability. This information could be valuable when investigating to find out exactly why and how the scanner detected a given vulnerability
Describe the solution you'd like
The Scan Plugin Information should be added to the References section of a given Vulnerability when a Tenable scan is imported. Format wise this could be appended as a new line like:
<Tenable Plugin Information: ID: 12345, Published: 01/01/24, Modified: 01/01/24>

Thank you very much :)
Had an implementation pretty much at the ready, but hesitated because i did not manage to get the unittests to run in my environment

Thank you very much :) Had an implementation pretty much at the ready, but hesitated because i did not manage to get the unittests to run in my environment

https://github.com/DefectDojo/django-DefectDojo/pull/11143


Add French translation

You were too fast :)

Oh, I'm sorry! I thought that maybe it takes you longer than that.


Move Tab to the First Position

When working on a large project with many files, tabs often end up in a somewhat random order, and frequently, two tabs of interest are separated by many other tabs (which we don't want to close).
I would like to be able to automatically/instantly move a selected tab so that it becomes the first on the left (or right).
For example, in the attached screenshot, if there are several tabs open between the "en.json" and "de.json" tabs, it could be very time-consuming and inconvenient to manually drag them next to each other if there are many tabs in between (inconvenient because it requires precision; for example, if the mouse moves incorrectly, the tabs stop scrolling).

If there were an option to automatically move the current tab to the left (so that it becomes the first tab), I could open "de.json" and move it to the left, then select "en.json" and move it to the left as well. This would allow me to quickly place both tabs next to each other as I want, so I can work with them without wasting time manually dragging them with the mouse.

Such a tab-moving option could be added, for example, in the tab's context menu.
Thank you and best regards.

Did you try pinning them, even if only temporarily?

@gjsjohnmurray oh pinning - I see - this is what I looking for. Thank you


[incubator-kie-issues-1259] RestWorkItemHandler logger set to debug

The logging output from RestWorkItemHandler generates too many logs which is not helpful. Changed  the log level from info to debug.
Closes: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3559

Link https://github.com/apache/incubator-kie-kogito-runtimes/pull/3559 does not exist

Issue link updated.


Suggested feature: geoshell import support

Suggesting geoshell import support if possible.

Yes please, currently trying to figure out a workflow for getting geometry shells into unreal with working skin weights & morph targets. Thinking I'll have to export out to blender and either fix there or import back into DAZ.
If it's possible for the plugin to do it that would be great.

@Faydd what steps exactly did you do to do that? I need to know until/unless DTU supports geoshells seeing that literally every makeup and tattoo set for Daz is geoshells now! Will DTU ever support geoshells?!?! I find it funny that this hasn’t been addressed given how much geoshells are being used for almost everything these days causing a disadvantage to dtu and unreal engine users. It’s alienating us (or at least me) due to this


Update dependencies in setup.py

@dflanigan this should fix the erratic availability of the fixtures.

Fixes #19

Thanks, Za !


Cas gene predict

Hi，
I wonder if the option “--cas True” is valid on the premise that the CrisprcasIdentifier is installed?
Regards

CRISPRcasIdentifier should be placed in the corresponding folder (described in the readme). Then --cas True will give you the prediction of the case genes and the corresponding summary


[provisioning] Integrate local provisioning orchestrator with remote database

This PR adds functionality to integrate the local provisioning orchestrator script with a Google Cloud Firestore database. It adds a new script called update_remote_db.py, updates the orchestrator itself, and adds documentation in the form of a README and requirements.txt file.
The new orchestrator workflow is as follows:

After running the provisioning flow, the orchestrator still writes the device record to a local SQLite database
Afterwards, the orchestrator will attempt to upload all records in the local SQLite database, deleting each one from the local DB on success
If records remain in the local DB after provisioning, a message is printed indicating to the user that they need to run update_remote_db.py to upload the additional records

update_remote_db.py takes in a path to the local database and will attempt to upload all records to the remote DB, removing each from the local DB on success.
In both cases, if a duplicate entry is detected in the remote database, the user will be prompted with the ability to skip the entry, overwrite the remote entry, or remove the entry from the local DB.
The Firestore database structure is fairly simple. It contains a single "collection" called devices, which contains "documents" keyed by device ID. Each document is a flat structure with keys and values that map directly to the SQL schema used for the local database.

We can ignore the kokoro error here just FYI.