Exit pilot-agent on Envoy error

Consider a case where Envoy is going OOM.

Envoy dies, but kubernetes still reports things are good and 2/2 ready.
Repeat a few times.

At somepoint due to backoff, envoy is dead for 2 minutes. The readiness
probe won't fail for at least a minute, so there is 1min where traffic
is coming and we are not even attempting to handle it.

Meanwhile, the operator has no clue what is going on, because Kubernetes
doesn't know envoy is crashing
Alternatively, if we exit when envoy crashes:

The readiness probe fails immediately

The user can clearly see envoy is crashing

Kubernetes handles backoff for us

We don't have to handle the complexity.

Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@howardjohn: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test unit-tests

racetest_istio
754b59277fa42680be210d71c914c6a233735000
link
/test racetest

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test unit-tests

racetest_istio
754b59277fa42680be210d71c914c6a233735000
link
/test racetest

integ-security-local-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test integ-security-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test unit-tests

racetest_istio
754b59277fa42680be210d71c914c6a233735000
link
/test racetest

integ-security-local-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test integ-security-local-tests

integ-pilot-local-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test integ-pilot-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test unit-tests

racetest_istio
754b59277fa42680be210d71c914c6a233735000
link
/test racetest

integ-security-local-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test integ-security-local-tests

integ-pilot-local-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test integ-pilot-local-tests

integ-mixer-k8s-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test unit-tests

racetest_istio
754b59277fa42680be210d71c914c6a233735000
link
/test racetest

integ-security-local-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test integ-security-local-tests

integ-pilot-local-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test integ-pilot-local-tests

integ-mixer-k8s-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test integ-mixer-k8s-tests

codecov_istio
754b59277fa42680be210d71c914c6a233735000
link
/test codecov

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn doesn't this make effectively turn all of the retry logic into dead code? Can we remove it all?

@costinm @kyessenov PTAL as well

Good point about cleaning up. I need to fix a few things up for this I'll
make sure I handle that as well. Thanks!
On Wed, Oct 2, 2019, 10:40 PM Liam White<EMAIL_ADDRESS>wrote:

@liamawhite commented on this pull request.
In pkg/envoy/agent.go
https://github.com/istio/istio/pull/17460#discussion_r330870074:

@@ -219,10 +220,9 @@ func (a *agent) Run(ctx context.Context) {
if status.err == errOutOfMemory {
log.Warnf("Envoy may have been out of memory killed. Check memory usage and limits.")
}

		// NOTE: due to Envoy hot restart race conditions, an error from the

		// process requires aggressive non-graceful restarts by killing all

		// existing proxy instances

		a.abortAll()

		// If Envoy is killed, we will kill the whole pilot-agent process. This allows Kubernetes to handle

		// the restart and we don't need to worry about

		os.Exit(1)

Are we sure everything else is cleaned up? Cleaning up doesn't matter on
Kube but does in VMs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/17460?email_source=notifications&email_token=AAEYGXIFJKGMHMNKPUXC4LLQMWAWXA5CNFSM4I3LQP72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGXIPYI#pullrequestreview-296650721,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEYGXOAQZBE5GC5Z65IOATQMWAWXANCNFSM4I3LQP7Q
.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test unit-tests

racetest_istio
754b59277fa42680be210d71c914c6a233735000
link
/test racetest

integ-security-local-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test integ-security-local-tests

integ-mixer-k8s-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test integ-mixer-k8s-tests

codecov_istio
754b59277fa42680be210d71c914c6a233735000
link
/test codecov

lint_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test integ-mixer-k8s-tests

codecov_istio
754b59277fa42680be210d71c914c6a233735000
link
/test codecov

lint_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test lint_istio

unit-tests_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test integ-mixer-k8s-tests

lint_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test lint_istio

unit-tests_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test unit-tests_istio

e2e-bookInfoTests-trustdomain_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-trustdomain_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
754b59277fa42680be210d71c914c6a233735000
link
/test integ-mixer-k8s-tests

lint_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test lint_istio

unit-tests_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test unit-tests_istio

e2e-bookInfoTests-trustdomain_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-trustdomain_istio

pilot-e2e-envoyv2-v1alpha3_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test pilot-e2e-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test lint_istio

unit-tests_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test unit-tests_istio

e2e-bookInfoTests-trustdomain_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-trustdomain_istio

pilot-e2e-envoyv2-v1alpha3_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test pilot-e2e-envoyv2-v1alpha3_istio

pilot-multicluster-e2e_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test pilot-multicluster-e2e_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test lint_istio

unit-tests_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test unit-tests_istio

e2e-bookInfoTests-trustdomain_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-trustdomain_istio

pilot-e2e-envoyv2-v1alpha3_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test pilot-e2e-envoyv2-v1alpha3_istio

pilot-multicluster-e2e_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test pilot-multicluster-e2e_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio-add-on
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-trustdomain_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-trustdomain_istio

pilot-e2e-envoyv2-v1alpha3_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test pilot-e2e-envoyv2-v1alpha3_istio

pilot-multicluster-e2e_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test pilot-multicluster-e2e_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio-add-on
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

lint_istio
2ab9f3fecf166f31eb36d6a587322ea382348c7c
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-trustdomain_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-trustdomain_istio

pilot-multicluster-e2e_istio
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test pilot-multicluster-e2e_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio-add-on
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

lint_istio
2ab9f3fecf166f31eb36d6a587322ea382348c7c
link
/test lint_istio

pilot-e2e-envoyv2-v1alpha3_istio
2ab9f3fecf166f31eb36d6a587322ea382348c7c
link
/test pilot-e2e-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3_istio-add-on
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

lint_istio
2ab9f3fecf166f31eb36d6a587322ea382348c7c
link
/test lint_istio

pilot-e2e-envoyv2-v1alpha3_istio
2ab9f3fecf166f31eb36d6a587322ea382348c7c
link
/test pilot-e2e-envoyv2-v1alpha3_istio

pilot-multicluster-e2e_istio
2ab9f3fecf166f31eb36d6a587322ea382348c7c
link
/test pilot-multicluster-e2e_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3_istio-add-on
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

pilot-e2e-envoyv2-v1alpha3_istio
2ab9f3fecf166f31eb36d6a587322ea382348c7c
link
/test pilot-e2e-envoyv2-v1alpha3_istio

pilot-multicluster-e2e_istio
2ab9f3fecf166f31eb36d6a587322ea382348c7c
link
/test pilot-multicluster-e2e_istio

unit-tests_istio
57c7ebf2767c2f27dc614ae7524539b0b8960b3e
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3_istio-add-on
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

pilot-multicluster-e2e_istio
2ab9f3fecf166f31eb36d6a587322ea382348c7c
link
/test pilot-multicluster-e2e_istio

unit-tests_istio
57c7ebf2767c2f27dc614ae7524539b0b8960b3e
link
/test unit-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
57c7ebf2767c2f27dc614ae7524539b0b8960b3e
link
/test pilot-e2e-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3_istio-add-on
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

unit-tests_istio
57c7ebf2767c2f27dc614ae7524539b0b8960b3e
link
/test unit-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
57c7ebf2767c2f27dc614ae7524539b0b8960b3e
link
/test pilot-e2e-envoyv2-v1alpha3_istio

pilot-multicluster-e2e_istio
57c7ebf2767c2f27dc614ae7524539b0b8960b3e
link
/test pilot-multicluster-e2e_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3_istio-add-on
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

unit-tests_istio
57c7ebf2767c2f27dc614ae7524539b0b8960b3e
link
/test unit-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
57c7ebf2767c2f27dc614ae7524539b0b8960b3e
link
/test pilot-e2e-envoyv2-v1alpha3_istio

pilot-multicluster-e2e_istio
57c7ebf2767c2f27dc614ae7524539b0b8960b3e
link
/test pilot-multicluster-e2e_istio

integ-security-k8s-tests_istio
57c7ebf2767c2f27dc614ae7524539b0b8960b3e
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3_istio-add-on
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

pilot-e2e-envoyv2-v1alpha3_istio
57c7ebf2767c2f27dc614ae7524539b0b8960b3e
link
/test pilot-e2e-envoyv2-v1alpha3_istio

pilot-multicluster-e2e_istio
57c7ebf2767c2f27dc614ae7524539b0b8960b3e
link
/test pilot-multicluster-e2e_istio

integ-security-k8s-tests_istio
57c7ebf2767c2f27dc614ae7524539b0b8960b3e
link
/test integ-security-k8s-tests_istio

gencheck_istio
60c90cc573817e96b1b42c5a417cb5fee8777254
link
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3_istio-add-on
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-framework-k8s-tests_istio
60c90cc573817e96b1b42c5a417cb5fee8777254
link
/test integ-framework-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3_istio-add-on
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-framework-k8s-tests_istio
60c90cc573817e96b1b42c5a417cb5fee8777254
link
/test integ-framework-k8s-tests_istio

e2e-simpleTestsMinProfile_istio
60c90cc573817e96b1b42c5a417cb5fee8777254
link
/test e2e-simpleTestsMinProfile_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3_istio-add-on
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-framework-k8s-tests_istio
60c90cc573817e96b1b42c5a417cb5fee8777254
link
/test integ-framework-k8s-tests_istio

e2e-simpleTestsMinProfile_istio
60c90cc573817e96b1b42c5a417cb5fee8777254
link
/test e2e-simpleTestsMinProfile_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
60c90cc573817e96b1b42c5a417cb5fee8777254
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3_istio-add-on
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

e2e-bookInfoTests-envoyv2-v1alpha3_istio
60c90cc573817e96b1b42c5a417cb5fee8777254
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-security-k8s-tests_istio
60c90cc573817e96b1b42c5a417cb5fee8777254
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3_istio-add-on
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-security-k8s-tests_istio
60c90cc573817e96b1b42c5a417cb5fee8777254
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3_istio-add-on
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-security-k8s-tests_istio
60c90cc573817e96b1b42c5a417cb5fee8777254
link
/test integ-security-k8s-tests_istio

lint_istio
9a2081d30313834d47536cb2defdd4732133b757
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3_istio-add-on
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-security-k8s-tests_istio
60c90cc573817e96b1b42c5a417cb5fee8777254
link
/test integ-security-k8s-tests_istio

lint_istio
9a2081d30313834d47536cb2defdd4732133b757
link
/test lint_istio

integ-framework-k8s-tests_istio
9a2081d30313834d47536cb2defdd4732133b757
link
/test integ-framework-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Ensure that exit code of envoy is propagated thru agent.
Quitquitquit makes the proxy exit normally, would be nice for it to restart then.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3_istio-add-on
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-mixer-k8s-tests_istio
3de82f0fa4ba42ce60989fc954f8fdef00ced4ab
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-bookInfoTests-envoyv2-v1alpha3_istio-add-on
b8d0ceb435e63217276c40f0d00bc533c6cb5462
link
/test e2e-bookInfoTests-envoyv2-v1alpha3_istio

integ-mixer-k8s-tests_istio
3de82f0fa4ba42ce60989fc954f8fdef00ced4ab
link
/test integ-mixer-k8s-tests_istio

integ-telemetry-k8s-tests_istio
3de82f0fa4ba42ce60989fc954f8fdef00ced4ab
link
/test integ-telemetry-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Update calogica/dbt_date version.

During maintenance update to dbt-expectations version 0.9.0 I get an message about dbt_date having an update available.

I think it does not update itself due to this:
packages:
  - package: calogica/dbt_date
    version: [">=0.8.0", "<0.9.0"]

Now in my mind, updating the underlying package would work. However #271 did an update a few weeks ago and I'm not sure its safe to just update the dbt_date package. I have tested this myself without finding any issues during install.
My suggestion is to just do it like so:
packages:
  - package: calogica/dbt_date
    version: [">=0.9.0", "<0.10.0"]

I made an PR #278 with this change, would love some feedback if this is correct or not.

Hi, this is intentional, please see #275


White screen on Linux when clicking the Git button

I'm attempting to use the encrypted Git feature and am seeing a white screen come up in the client instead.
my log id: 27548d96c958cf57ac380f1c

Keybase GUI Version: 1.0.34-20171006000413+5fe91ae13

We will investigate first thing.  Can you do a ‘keybase log send’ ?
On Fri, Oct 6, 2017 at 8:11 AM Matthias Niess<EMAIL_ADDRESS>wrote:

Keybase GUI Version: 1.0.34-20171006000413+5fe91ae13
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/8864#issuecomment-334737208,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA05_w22ZKAP8dkq4ab9qkbubZQhLgZZks5sphjbgaJpZM4PwCMH
.

Log ID: 52e5f51f980733162205cd1c

Thanks. Cc @oconnor663
On Fri, Oct 6, 2017 at 8:14 AM Matthias Niess<EMAIL_ADDRESS>wrote:

Log ID: 52e5f51f980733162205cd1c
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/8864#issuecomment-334737895,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA05_ziQJd5Qx_xgVZSCl5h9YLONZ_5dks5sphmngaJpZM4PwCMH
.

Dupe of #8872 and now fixed in master

(fix should be out already if you upgrade to latest)

Confirming fix.

I am confirming the fix as well.
On Mon, 9 Oct 2017, 10:37 am Matthias Niess<EMAIL_ADDRESS>wrote:

Confirming fix.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/keybase/client/issues/8864#issuecomment-335212277,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABvKdqxb2qfmiK8ItZUfSDfokdouRRhPks5sqkvHgaJpZM4PwCMH
.


Export diagrams generates broken diagrams

Description
When using the Export to PNG or Export to SVG feature, diagrams seem broken compared to the rendered version.
For example, when using the Internet Banking System example, the System Context export looks like this:

I also noticed some issues with the puppeteer script which generates several times the same diagram instead of the right ones (System Context is actually the System Landscape for example).
Steps to reproduce

curl -o workspace.dsl https://raw.githubusercontent.com/structurizr/dsl/a97141682dffd8b5104cedd7155e1a87be2d5fb6/src/test/dsl/big-bank-plc.dsl
docker run -it --rm -p 8080:8080 -v $PWD:/usr/local/structurizr -e STRUCTURIZR_WORKSPACE_PATH=. structurizr/lite
Export to PNG

Screenshot

Code sample
No response
Configuration
Using structurizr/lite:latest Docker image (Digest: sha256:5012d4f04198afd22cda992660ce12873bd7fc29fcc124d00462c2e6ca8e3bdb)
Severity
Major
Priority
I have no budget and there's no rush, please fix this for free
More information
No response

By the way, I'm using Chrome 119.0.6045.105 for the manual exports.


Extremely similar charter to Ibis

For about 3.5 years we have been developing a unified expression-based front end system for SQL systems as well as pandas: https://github.com/ibis-project/ibis. I suspect there are ripe opportunities for collaboration on this
cc @cpcloud @kszucs

Closing this. Feel free to reopen if the discussion should continue.


Old API no longer authenticating?

As of July 23, 3:45 am PDT, PyEcoNet suddenly stopped being able to authenticate for me.  Each auth attempt results in:
ERROR:pyeconet.api:Authentication request failed, please check credintials. 400
I am still able to access the EcoNet app, although I understand it uses a different API.
Is anyone else having success authenticating?  Or is this the moment of "this library could stop working at any time, without warning"?  Or is it a matter of updating (or finding anew) the magic value for BASIC_HEADERS?
How's the new_api branch coming along? :)

Looks like requests 2.24.0 might be the culprit.  I don't see this issue with requests 2.23.0.

The old API is no longer supported. New API is fully functional now.


Show better ui if trying to register a duplicate/existing username

Right now the progress bar hangs and no msg is shown.
Jack feel free to assign to me if you like - I put it in your queue just because you've been in and out of there recently.

Assigned to you :)

I'll add some error messaging into the final design for the new sign-up and login pages (the ones with the pretty pictures)

Don't you have something more important to do today, @Newportkiwi?  Whatcha doin on Github at a time like this??

Just taking a break outside, we're a few hours yet from any action.

Hey @tinybike, given that we are overhauling the login flow post launch, I aimed to solve this as simply as possible to get the job done. That said I had a rough time with it, and spent more time on it than I had hoped, mainly reverse engineering logic and how/when it effected state. At the end I couldn't escape all the side-effects, my solution works, but I'm not happy with how it's implemented: 338a8702f858e8a315903ca1e9945db04b4f4f1c
Would you mind verifying that it does not cause unintended behavior I did not account for.
Also, this makes a great example relating back to our discussion the other day about component-state, would be great to chat about it again post-launch.
All the best.


HTTPError('400 Client Error: Bad Request for url:

getting this error , also getting like 10 pings per second for this domain from AMCREST doorbell 'drs.zencamcloud.com'
[cont-init.d] 00-banner.sh: exited 0.
[cont-init.d] 01-log-level.sh: executing...
[cont-init.d] 01-log-level.sh: exited 0.
[cont-init.d] done.
[services.d] starting services
[services.d] done.
16/02/2023 16:23:18 [INFO] App Version: 1.0.14
16/02/2023 16:23:18 [INFO] Fetching camera details...
16/02/2023 16:23:22 [INFO] Device type: AD110
16/02/2023 16:23:22 [INFO] Serial number: XYZ
16/02/2023 16:23:22 [INFO] Software version: 1.000.00AC009.0.R
16/02/2023 16:23:22 [INFO] Device name: Front_Doorbell_AD110
16/02/2023 16:23:22 [INFO] Writing Home Assistant discovery config...
16/02/2023 16:23:22 [INFO] Fetching storage sensors...
Trying again due to error: HTTPError('400 Client Error: Bad Request for url: http://<IP_ADDRESS>:80/cgi-bin/storageDevice.cgi?action=getDeviceAllInfo')
Trying again due to error: HTTPError('400 Client Error: Bad Request for url: http://<IP_ADDRESS>:80/cgi-bin/storageDevice.cgi?action=getDeviceAllInfo')
Trying again due to error: HTTPError('400 Client Error: Bad Request for url: http://<IP_ADDRESS>:80/cgi-bin/storageDevice.cgi?action=getDeviceAllInfo')
16/02/2023 16:23:24 [WARNING] Error fetching storage information 400 Client Error: Bad Request for url: http://<IP_ADDRESS>:80/cgi-bin/storageDevice.cgi?action=getDeviceAllInfo
16/02/2023 16:23:25 [INFO] Listening for events...
`

image

Got the same error. You ever resolve this?

Do you have an SD card in the device?  There is another Closed Issue that states if you do not have an SD card in the device, it will throw the error.  If you are able to add this Variable either to the docker config or through Unraid, that will fix the issue.
https://github.com/dchesterton/amcrest2mqtt/issues/47#issuecomment-1076320433


Hide reward and like count if it's equal to 0

It's not necessary to show rewards or like counter or comment counter for post and comments if it's equal to 0.
Before

After

I can take a crack at this, if you'd like!

Sure, thanks a lot!
If you have problems take a look at our contributing guide. If you need any help don't hesitate to ask it there or on our Discrod (#contributing channel).

Will do! Thanks!


The latest version of NGen.cpp causes a build error on UCS machines (Linux)

In build ngen with the latest master, it produces an error on UCS machines due to a missing "std" on line 298.
Current behavior
/home/shengting.cui/ngen_9.11.23/ngen/src/NGen.cpp: In function ‘int main(int, char**)’:
/home/shengting.cui/ngen_9.11.23/ngen/src/NGen.cpp:298:16: error: ‘make_unique’ was not declared in this scope
       router = make_unique<routing_py_adapter::Routing_Py_Adapter>(t_route_config_file_with_path);
                ^~~~~~~~~~~
/home/shengting.cui/ngen_9.11.23/ngen/src/NGen.cpp:298:16: note: suggested alternative:
In file included from /opt/rh/devtoolset-8/root/usr/include/c++/8/memory:80,
                 from /home/shengting.cui/ngen_9.11.23/ngen/include/realizations/catchment/Formulation_Manager.hpp:4,
                 from /home/shengting.cui/ngen_9.11.23/ngen/src/NGen.cpp:8:
/opt/rh/devtoolset-8/root/usr/include/c++/8/bits/unique_ptr.h:842:5: note:   ‘std::make_unique’
     make_unique(_Args&&...) = delete;```

## Expected behavior
No error output

at
1.

## Screenshots

For reference: https://github.com/NOAA-OWP/ngen/blob/b749e0fd0d3766349f368d2a5eaa31003601b5fe/src/NGen.cpp#L298

It appears this occurs only when NGEN_ROUTING_ACTIVE is turned on.

Curiously, I wasn't getting this on clang with NGEN_ROUTING_ACTIVE enabled... but after rebasing the branch I was on I get it now. In any case, yes this should have std:: stuck on the front of it (just not sure why now).
Related, @PhilMiller did you spare your wrath from https://github.com/NOAA-OWP/ngen/blob/b749e0fd0d3766349f368d2a5eaa31003601b5fe/test/realizations/catchments/Bmi_Testing_Util.hpp#L59 and https://github.com/NOAA-OWP/ngen/blob/b749e0fd0d3766349f368d2a5eaa31003601b5fe/test/realizations/catchments/Bmi_C_Pet_IT.cpp#L23 in #603 on purpose? Those are sticking around after the zombie apocalypse. Whether Bmi_C_Pet_IT.cpp belongs where it is is debatable, but at least all the code it's testing is still in use.

Fixed by #636

Related, @PhilMiller did you spare your wrath from
https://github.com/NOAA-OWP/ngen/blob/b749e0fd0d3766349f368d2a5eaa31003601b5fe/test/realizations/catchments/Bmi_Testing_Util.hpp#L59
and
https://github.com/NOAA-OWP/ngen/blob/b749e0fd0d3766349f368d2a5eaa31003601b5fe/test/realizations/catchments/Bmi_C_Pet_IT.cpp#L23
in #603 on purpose? Those are sticking around after the zombie apocalypse. Whether Bmi_C_Pet_IT.cpp belongs where it is is debatable, but at least all the code it's testing is still in use.

Documenting from Slack:
I left some of the test code alone as less impactful for the substantial effort. The test .cpp file won't hurt anything else. I neglected that there's a .hpp file, which maybe should be cleaned up.


MacOS ARM64 native binaries

What is the problem?

On Apple processor chips m1/m2 ARM64, it seems recheck fallsback to java implementation.
While it achieves the end goal, I was wondering if you can provide native ARM64 binaries or even use x64 emulation (unclear if that would be better than java runtime)
How to fix the problem?

Provide recheck-macos-arm64 package
Try x64 emulation ?

Binaries are built by GitHub Actions. However, GH Actions does not support arm macos runner for now.
Related issue: https://github.com/github/roadmap/issues/528
Note that you could use JVM backend on arm macos if JVM is installed. It runs as fast as native (or faster than native due to JIT compile.)

Github actions now supports arm macos https://github.blog/2023-10-02-introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/, any chance to get an update on this ticket?

As far as I know it is a paid feature. I don't make any profit from recheck, so I can't use it.

Good news https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/


Pass data to frontend JavaScript

Okey, we have I "minor" issue here.
For quite long time JavaScript didn't have access to Kotsu data, and it still doesn't have.
It is the only remaining element of Kotsu (as far as I remember) which lack such crucial connection.
Unfortunately, solution isn't that easy and related to the fact that frontend JavaScript is the only element which doesn't compile to anything completely (technically, it compiled with babel and bundled, but it still runs in browser), and this means that we can not easily dump into it anything we'd like.
For instance, Nunjucks or Sass doesn't care about size of data we feed to it, it will compile to static html or CSS which will inline needed portions of data anyway. But it's whole another story with JS...
So, what issues do we have?

If you try to import any data file, it will, well, remain in bundle. Initial Kotsu data is small, but our large projects have quite large data, with lots of entries (250kb). Just dare to import data index file, and it will grab ALL of it, even if you intended to use in JS only few properties.

Even if we slice data into smaller files, it still will work only occasionally, since some data slices may end up quite large anyway (like, products data), while other will be absurdly small.

Some data files (especially data index file) aren't just json or yaml files — they are full-fledged JS files with external dependencies on Grunt, Lodash and Node. This is required to get data from Grunt instance, and rest of dependencies related to i18n — it needs some code to allow merging of properties for different locales (so far it is the only dirty way to localize data).
We can (and probably, should) minimize amount of dependencies in data, but still sooner or later some project might require advanced functionality in data, and it would be much easier (and appropriate) to implement within external dependency rather than data itself.
Besides, sealing off dependency on Grunt will also disconnect data from Grunt instance... which is, obviously, a problem, since it makes data transferring more problematic.
But, in general, I'd say it is minor problem in comparison with size issue. Even if our data was dump yaml file, in large project it would anyway lead to issues with enormously large JS bundles only because of tons of unused data imported inside.

It worth noting that SystemJS json plugin imports only used slices of data into project. So, if you do
import { version } from 'package.json'

It will import indeed only version property. Which is handy.
Unfortunately, it won't work for JS files, and in general doesn't sound like ultimate solution.

Another solution would be to look on... babel macros:

babel-plugin-preval
Or raising and more generic babel-macros

For example, in case of prevel it will allow to encapsulate Node-related code into prevel function right within Kotsu frontend JavaScript. That code can make any required loads, dependencies resolutions and manipulations to data and export only needed for frontend slice. After babel transform, it will result only in footprint, which we directly declared as exported within prevel function.
Some more information can be read in CRA issue #2730, where originated idea of babel-macros.

[ ] preval seems to be not working well with JSPM right now nor on it's own, nor via babel-macros: https://github.com/jspm/jspm-cli/issues/2335

Another alternative is something like here https://github.com/gatsbyjs/gatsby/issues/1781#issuecomment-322475987, with GraphQL.
While fun and modern, seems like an overkill.

Added a bit wonky ability to consume data at fronted by compiling source/scripts.js to JSON with Grunt, and then passing it to JSPM via @data mapping.
Not ideal, but works.
See https://github.com/LotusTM/Kotsu/commit/881176ce800612fb97454c811cc27c5dea6e3d12
I still think that preval would be a more intuitive solution.


Add an argument to collect C stack from ucontext

Related to this issue https://github.com/jvm-profiling-tools/async-profiler/issues/321
For some old Linux kernel (CentOS 6.5 Final), native stack can't get retrieved correctly from perf event. So I add an argument to swtich to walk stack using ucontext.
Tested on CentOS 6.5 Final, kernel version 2.6.32-696.3.2.el6.x86_64.

There is already cstack option for choosing how to walk native stack. I think it's better to reuse this one. One more similar option would be confusing.
Meanwhile I'll get an image of the above OS version for testing.

Antother choice is check the value of "u64 nr = ring.next();" in PerfEvents::getNativeTrace, if nr <= 1 then switch to use ucontext, then we don't need modify the arguments.

I installed exactly the same kernel version and could reproduce the problem.
However, what I found interesting, is that the problem happens only with PERF_COUNT_SW_CPU_CLOCK counter (event=cpu). With event=cycles, call stacks are fine, including the kernel stack.
So, the suggested alternative is to use event=cycles. It is semantically the same as event=cpu, but provides higher accuracy and also shows kernel stacks.

Thanks for your suggestion, very helpful!
But after to use event=cycles, I still find some weird stack trace (using my HeapOOM example)
SpinPause;apic_timer_interrupt_[k];smp_apic_timer_interrupt_[k];local_apic_timer_interrupt_[k];hrtimer_interrupt_[k];__run_hrtimer_[k];tick_sched_timer_[k];update_process_times_[k];run_local_timers_[k];hrtimer_run_queues_[k] 1

Most stack trace is correct, so I think is ok to swtich to cycles for daily use.
Another phenomenon is that when using event=cycles, the result is quite different. When I use async-profiler to profile my Hadoop job, it shows jit complier consumes lots of CPU time when profiling using event=cpu or event=itimer. After swtich to event=cycles, almost no compiler consumption reports.
In my understanding, event=cycles and event=cpu are sematically the same, both of them are reporting CPU consumption. But why the huge difference?

With the default interval, cycles produces much more samples than cpu or itimer. This might explain the difference. Try larger interval (-i 10ms) and increase the frame buffer size (-f 10m).
Also, if you run the application under unprivileged user, make sure kernel.perf_event_mlock_kb sysctl option is large enough. 8KB per thread is required. E.g. if your application has 500 threads, perf_event_mlock_kb should be at least 4000 (the default value is 516). This is not needed when the application runs under root.

Thanks for your help, I think stack walking using ucontext is useless now.


2021-06-18 v. 3.6.6: including pt-BR translation

Added:

values-pt-BR\strings.xml with Brazilian Portuguese translation

Updated:

Language.java to include Brazilian Portuguese

Checklist
Common

[ ] I am ran the app before creating PR
[ ] I am ran all tests before creating PR

UI

[ ] I am ran the app for visual checks.

Logic

[ ] I am tested basic app functionality.

Changes
Describe all changes here:

First;
Added support to Brazilian Portuguese language.

Comments
I tried to run the application with my changes, but I'm not an Android developer and couldn't build it, even trying to follow your build instructions.
Looks like build.graddle needs to be updated also to include 'pt-BR' in resConfigs. I didn't change it.

When I tried to build the app, I found the two errors pointed in your build process. About the error downloading the gradle-6.7.1-all.zip I could solve by downloading the graddle package to my computer and making this change:
diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties
index 9fe8d05..3ad474e 100644
--- a/gradle/wrapper/gradle-wrapper.properties
+++ b/gradle/wrapper/gradle-wrapper.properties
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
-distributionUrl=https://services.gradle.org/distributions/gradle-6.7.1-all.zip
+distributionUrl=file:/C:/Users/itamarc/Downloads/gradle-7.1-all.zip
The other error was the one I couldn't solve, since I never used graddle:

Exception is:
org.gradle.api.GradleScriptException: A problem occurred evaluating project ':app'.

@itamarc Can you post error message? Also, try to configure project with this guide.

@itamarc Can you post error message? Also, try to configure project with this guide.

I did read your guide and I have the local.properties file in place.
Running gradlew build with --debug parameter I think I've found the problem:
2021-06-20T18:05:02.086-0300 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] >
com.android.builder.errors.EvalIssueException: SDK location not found. Define location with an ANDROID_SDK_ROOT
environment variable or by setting the sdk.dir path in your project's local properties file at 'D:\Itamar\Estudos\hash-
checker\local.properties'.

I don't have the Android SDK installed. As I mentioned, I'm not an Android developer. If you can point out to me what the minimum package I need to install to make the build process work, I can install it and try the build.

@itamarc I'm reviewed your Pull Request and all works. I'm merge your changes soon.

@itamarc Thanks for help.

@itamarc, thanks a lot. I'm added you to Contributors list in README.md.


"Table" cell no longer shows the correct page number

We're supposed to see an indicator of what page we're on in a multi-page Table, and to be able to edit it in a textbox. We seem to have lost this behavior during refactoring.

can you show a screenshot of a working version?

The idea is you have the arrows to switch pages and a text box to type the row number if you want.

Do you have an example of how we can build a multi-page table, for the playground? I'd like to spin something up where I can test this live

see d78ac0988d50eb9bf6e80398b07a62587ba3d1f2


Gyrokinetic electrostatic field that does not evolve in time

I added a small flag to fix the potential at t=0 and never evolve it on subsequent time steps. It's only 4 lines of code. Regression tests pass on CPU and the code builds just fine.

I discussed using the update_field flag for this feature with Jimmy on Friday. Although it sounded like a good idea at first, further investigation revealed that this flag also removes the field diagnostics for each frame, which is important. Although the field at the initial conditions is the same as the future frames, this data will not get written because writing the data is immediately before the time stepping loop, after the initial conditions are determined.

This test produces a field that does not evolve in time. The plot below is the DG coefficients of the field at the beginning and end of the unit test.


Textinput - _key_down() method now more readable, separated deletion and insertion / action keys handling

As we fixed issue #5469 with @emomicrowave, we noticed the _key_down() method needs some refactoring (because of repetitive self.delete_selection() calls) so we tried to make a clearer separation between deleting text when selected and other key handling.

@BoyanH Could you please rebase the branch against master so that it contains only your commits? Thanks! :)

@KeyWeeUsr Sorry for the mess I did, but I don't think that would be a good idea. I think I need to open a further issue.
I wanted to write some tests today, but I saw you already did, so I rebased this branch to test everything and wrote some further tests, fixed a small mistake I did.
Thing is, I found out that, on selection, when the shift is released and a cursor in the other direction is pressed, the cursor doesn't jump to the other side of the selection.
I would like to commit the test and solution (hopefully), in 30 minutes or so. Then you could look at it more easily and if you want to, I could create a cleaner branch.

The branch contains changes that either are already included in the master branch or aren't yours, therefore it's quite a good idea to rebase the branch (git rebase master) :)
Re the new found selection issue, I think it should be in a separate PR together with appropriate tests, so that if somebody wants to go back in the history doesn't need to guess what happened where. This PR was about refactoring the conditions (ref the original post), therefore leave the PR as it was in the original state and further changes open in another pull request(s).

Solves #5490

@KeyWeeUsr thanks for the suggestions, I rebased this branch on master now and removed the further tests and fixes that don't belong here

Thanks for PR and splitting it to parts! 🍡


Update cryptography dependency?

Can the dependency on cryptography be updated to something after 42.0.0?

Thank you!


What does it do?
Describe the technical changes you did.
Why is it needed?
Describe the issue you are solving.
How to test it?
Provide information about the environment and the path to verify the behaviour.
Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request

I've installed the alpha in Strapi and everything seemed fine.


v4 beta docs site broken in production

Hey guys,
I found a bug on the site. I'm having trouble figuring it out myself, but the error appears to be that canGo is not a function in FakeBrowser.render. In fact all the props but location are undefined.
https://github.com/ReactTraining/react-router/blob/v4/packages/react-router-website/modules/components/FakeBrowser/index.js#L64
So possibly Route.js needs const { canGo, goBack, go, goForward } = history and those added to the props variable. I tried editing it locally but it wouldn't recompile or reload my code so I can't test it.

Version
4
Test Case
https://reacttraining.com/react-router/
Steps to reproduce
Site shows "." for the fake browser code tester and this error:
index.js:81 Uncaught TypeError: canGo is not a function
    at render (index.js:81)
    at Route.render (Route.js:91)

Fixed! Sorry about that. I broke it earlier when I rebuilt our home site without realizing it would break the router site.

@tylermcginnis The docs are down again for me. I see a loading screen forever and a JS error:
Uncaught TypeError: Cannot set property '_key' of null
    at r (main.js:4)
    at main.js:31

@ryross Do a hard refresh (hold shift) and you'll see a coming soon page. It looks like the last build is stuck in cache.


Fix #1983: Warn if @ScalaJSDefined overrides js names differ.

Review by @sjrd.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2725/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3516/
Test FAILed.

Jenkins, retest this please

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2731/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3523/
Test PASSed.

Here are a few more things to try:
class A {
  def foo: Int = 5
}

trait B extends A {
  @JSName("bar")
  def foo: Int
}

class C extends B

class A {
  @JSName("bar")
  def foo: Int = 5
}

trait B extends A {
  def foo: Int
}

class C extends B

class A[T] {
  @JSName("bar")
  def foo(x: T): T = x
}

class B extends A[Int] {
  override def foo(x: Int): Int = x
}

trait A[T] {
  @JSName("bar")
  def foo(x: T): T = x
}

class B extends A[Int] {
  override def foo(x: Int): Int = x
}

class A[T] {
  @JSName("bar")
  def foo(x: T): T = x
}

trait B extends A[Int] {
  def foo(x: Int): Int

class C extends B {
  override def foo(x: Int): Int = x
}

class A[T] {
  def foo(x: T): T = x
}

trait B extends A[Int] {
  @JSName("bar")
  def foo(x: Int): Int

class C extends B {
  override def foo(x: Int): Int = x
}

That's all.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2741/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3535/
Test FAILed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2742/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3536/
Test PASSed.

That's all (+ squash the commits)

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2750/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3545/
Test PASSed.

Modulo squashing, LGTM

Squashed

LGTM

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2751/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3546/
Test PASSed.

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2753/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3548/
Test FAILed.

retest this please

Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/2758/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/3553/
Test PASSed.


Clean and upgrade smart contracts to 0.5.5+ versions

Can you elaborate @rbval ? Do you mean 0.4.4?

Talking about Solidity's compiler and smart contract versions. 0.5.5 is the current newest one, our smart contracts are in 0.4.24 version. @gaieges

Relevant when we start the audit process.  Additional features, security fixes. Requires us to make code changes to the .sol files.
Likely need to get away from the python solidity stuff, and use node or go instead (separate task)

We decided to go with a wrapper library that supports 0.4.24 for python for now. An implementation with local abis together with s3 might be something we do next.


onImageForAnalysis prevents video recording on iOS

Steps to Reproduce
Add onImageForAnalysis callback to example app. It can be as simple as
onImageForAnalysis: (image) async {
  print('######################');
  print(image.toInputImage());
  print('######################');
}

Expected results
Video is recorded and available for playback after pressing the "Stop" button.
Actual results
I get the following error in logs
[VERBOSE-2:dart_vm_initializer.cc(41)] Unhandled Exception: PlatformException(VIDEO_ERROR, video is not recording, , null)
#0      CameraInterface.stopRecordingVideo (package:camerawesome/pigeon.dart:983:7)
<asynchronous suspension>
#1      VideoRecordingCameraState.stopRecording (package:camerawesome/src/orchestrator/states/video_camera_recording_state.dart:87:20)
<asynchronous suspension>

I cannot stop video recording due to this error.
About your device

Brand
Model
OS

Apple
iPhone 11
17.1.1

Your flutter version
Flutter 3.13.9 • channel stable • https://github.com/flutter/flutter.git
Framework • revision d211f42860 (6 weeks ago) • 2023-10-25 13:42:25 -0700
Engine • revision 0545f8705d
Tools • Dart 3.1.5 • DevTools 2.25.0

Could you post your code?
Were you actually recording a video while performing analysis?

Hi @g-apparence. I've already posted it. It is literally only that 5 lines of additional code added to CameraAwesomeBuilder.awesome in main file of example. That's it. Nothing more. I don't see any sense in duplicating all of the code for these 5 lines.
You can even leave this function empty to reproduce the issue: onImageForAnalysis: (image) async {}.

@g-apparence additional note about video recording: I'm using the built in functionality of CameraAwesomeBuilder.awesome widget. Here is video recording of the screen. When I press stop button, I get the error I've mentioned in the issue description.
https://github.com/Apparence-io/CamerAwesome/assets/27166027/4d8d4cdd-da0b-45e3-84e8-05fe4c0c0b8b

Will make a try and tell you.
Sorry for delay

Hi @g-apparence. I decided to dig a bit deeper and added some prints to video_camera_state.dart and it throws an error when onImageForAnalysis is present. Since await CamerawesomePlugin.recordVideo(captureRequest); is wrapped in try block it is not visible in logs.
flutter: PlatformException(VIDEO_ERROR, can't record video when image stream is enabled, , null)
flutter: #0      CameraInterface.recordVideo (package:camerawesome/pigeon.dart:899:7)
<asynchronous suspension>
#1      VideoCameraState.startRecording (package:camerawesome/src/orchestrator/states/video_camera_state.dart:48:7)
<asynchronous suspension>

Maybe that will help.

Hi @g-apparence. Don't want to be pushy, just want to know if it is something that can be fixed relatively quickly or I should switch to camera plugin on iOS devices for now. Thanks.

Hi sorry, I have a lot of work on the ApparenceKit Supabase support.
I'm not sure that it is a problem with camerawesome or that this should not be possible on all devices.
I have to take time and try this on all the devices I have for CamerAwesome.
Also I'm always open for contribution if you wanna help me on this.

I'm not good at native development especially Objective-C. So I'm not sure how to fix it. Also I'm not sure if I'll have time to dig into native iOS part in the nearest since I have multiple projects.

Are there any updates on this?


Switch detection procedure

Hi @hclimente ,
working with spada i do like the results. But since you said in a previous issue that the current version of spada is a 'complete re-implementation of the software used in the paper', I wondered whether the switch detection conditions are still the same ones, as describes in the paper.
For example in the paper it is stated that :
'We only kept those cases for which the tumor isoform PSI was higher than the normal isoform in the tumor sample and the normal isoform PSI in the normal sample was higher than the value for the tumor isoform'
However in my analysis, spada reported the situation seen below as a switch, even though in both samples the normal isoform had a bigger psi (y axis = psi).

So are the switch detection criteria now (in the current spada version) still the same as described in the paper ?  Your advice would be greatly appreciated.
Thanks!

Thanks for your feedback.
Indeed, I did not implement that check in spada. For reference, these are the criteria that a switch must meet:

"Big enough" delta PSI change in both normal and tumor isoforms.
Gene not-differentially expressed.
Gene expression higher than the specified threshold in both cases and controls.


"CodeChecker server --postgresql" still create sqlite db

Starting with:
CodeChecker server   --force-authentication -w /var/lib/jenkins/.codechecker --postgresql --dbname codechecker_config --dbport 5432 --dbusername codechecker_user   --not-host-only --verbose debug
[16:15:21] {DATABASE HANDLER} [25340] <140409333311232> - database.py:219 from_cmdline_args() - Using PostgreSQL:
[16:15:21] {SERVER} [25340] <140409333311232> - server.py:453 main() - Connecting to product configuration database.
[16:15:21] {DATABASE HANDLER} [25340] <140409333311232> - database.py:370 connect() - Connecting to database...
[16:15:21] {DATABASE HANDLER} [25340] <140409333311232> - database.py:373 connect() - Checking if database is running at [localhost:5432]
[...]
[16:15:21] {SERVER} [25340] <140409333311232> - server.py:496 connect() - Connecting database for product 'firefox'
[16:15:21] {SERVER} [25340] <140409333311232> - server.py:500 connect() - Configuring schema and migration...
[16:15:21] {DATABASE HANDLER} [25340] <140409333311232> - database.py:231 from_cmdline_args() - Using SQLite:
[16:15:21] {DATABASE HANDLER} [25340] <140409333311232> - database.py:233 from_cmdline_args() - Database at /var/lib/jenkins/.codechecker/firefox.sqlite
[16:15:21] {DATABASE HANDLER} [25340] <140409333311232> - database.py:284 check_db_version() - Database version is compatible.

in this step-by-step guide it is describe how to store your results in postgres db.
https://github.com/Ericsson/codechecker/blob/master/docs/postgresql_setup.md
The database is not created automatically as before (and as currently in sqlite), you must create it before you start the server.

--postgresql in the server's argument specifies that the configuration database resides on a Postgres server.
The firefox.sqlite is created because the product database is specified to be at said location. CodeChecker cmd products add also take a --sqlite and --postgresql (and --db-*) arguments which specify from where the analysis database is to be mounted from.

@whisperity, in that case it is very confusing which database is controlled by which option. I think, if someone wants to use postgres, probably it is a good idea to use it for all databases by default unless explicitly specified otherwise.

It is well-documented in the help and in the written documentation. It is also logical as I explained above, the server takes the server's argument, while product add takes the product's.
Once a connection is set up in a particular way in the configuration database, it is used as it is. On the web interface, the SQLite/PostgreSQL distinction is made by the user.
You can't easily make it default if the server runs in PSQL mode, because it would result in an extra round (on the command-line) to query what mode the server runs in. Also, nothing ever guarantees that run databases are in the same database server as the config database. Setting up a SQLite product takes only one variable, while PSQL takes up to 5.

It is well-documented in the help and in the written documentation. It is also logical as I explained above

Probably from your perspective but as an external user who just want to run it, I find that unexpected and not following a principle of least astonishment

How should we design it? Should we straight-up prohibit the usage of SQLite databases for analysis results if the configuration database is PostgreSQL and vica-versa?

yes, or having a single step to configure the database(s).
I guess in most of the cases, people who will run codechecker will only use it for one product (and probably on the same system)

Simply starting CodeChecker server with no extra arguments at all (and assuming an empty ~/.codecheker directory) will automatically do that single step to configure a single Default product, especially aimed at the simplest use case ever.
If PSQL mode prohibits an SQLite database's existence, then we will end up with breaking a use case where, for example, a run database is residing in some shared storage location. The ability of having multiple products added to the same server opened up many new configuration options, unfortunately or not.


pycryptodome version conflicts

Home Assistant release with the issue:
0.91 (and older)
Last working Home Assistant release (if known):
Operating environment (Hass.io/Docker/Windows/etc.):

Hass.io, possibly others
Component/platform:

zha, broadlink, maybe more
Description of problem:
https://github.com/home-assistant/home-assistant/pull/16238 states that pycryptodome < 3.6.6 has a security vulnerability, and so it pins the version for pycryptodome at >= 3.6.6. However, the dependencies for some components require older versions; the package python-jose-cryptodome is a frequent offender. This creates issues where the platform cannot be setup because its dependencies could not be installed.
Related issues:

~~https://github.com/home-assistant/home-assistant/issues/22726~~ fixed by https://github.com/home-assistant/home-assistant/pull/22552
https://github.com/home-assistant/home-assistant/issues/22722
https://github.com/home-assistant/home-assistant/issues/18592
https://github.com/home-assistant/home-assistant/issues/17929
https://github.com/home-assistant/home-assistant/issues/17843

I have this issue, as reported in #22722, However I'm not using androidtv, I'm not sure which component it is that I am using that is setting the pycryptodome requirement, but its affecting zha. Is there anyway I can track down the guilty component? I'm running hass.io. Thanks

0.91.3
[homeassistant.components.broadlink.switch] Failed to connect to device
pip3 install --upgrade pycryptodome==3.3.1
broadlink 0.9 has requirement pycryptodome==3.4.11, but you'll have pycryptodome 3.3.1 which is incompatible.
pip3 install --upgrade broadlink
Collecting pycryptodome==3.4.11 (from broadlink)
python-jose-cryptodome 1.3.2 has requirement pycryptodome<3.4.0,>=3.3.1, but you'll have pycryptodome 3.4.11 which is incompatible.

I confirm the same problem on my side

https://github.com/home-assistant/home-assistant/issues/23461 is also affected, it seems.

For the broadlink library it will be solved when a new pypi package is released: https://github.com/mjg59/python-broadlink/pull/242

I guess it fixed for Broadlink.
(I have also started to parse to the broadlink library from pycryptodome to cryptography)


[1.22] p. 285 - About validating /etc/sudoers

Hey, thanks for your great work and for making it free!
I have one suggestion about page 285:
"validate" can be used for "lineinfile" as well, not just for the  "copy" module. You could remove the whole paragraph about "using caution with lineinfile" and just show how validate could be used for both modules.

@lustoerk - Good catch! I never realized validate could be passed to lineinfile until just now. I thought maybe it was added somewhat recently, but glancing through Ansible's git history, it's been there at least six years!
I'll have this fixed in the next version of the book, 1.23. Thanks again!


capistrano2 integration breaks on capistrano 2.9.0 with ruby 1.8.7 and rollbar 1.2.7

/usr/lib/ruby/1.8/net/http.rb:560:in `initialize': can't convert Hash into String (TypeError)
        from /usr/lib/ruby/1.8/net/http.rb:560:in `open'
        from /usr/lib/ruby/1.8/net/http.rb:560:in `connect'
        from /usr/lib/ruby/1.8/timeout.rb:53:in `timeout'
        from /usr/lib/ruby/1.8/timeout.rb:101:in `timeout'
        from /usr/lib/ruby/1.8/net/http.rb:560:in `connect'
        from /usr/lib/ruby/1.8/net/http.rb:553:in `do_start'
        from /usr/lib/ruby/1.8/net/http.rb:542:in `start'
        from /usr/lib/ruby/1.8/net/http.rb:440:in `start'
        from /var/lib/gems/1.8/gems/rollbar-1.2.7/lib/rollbar/capistrano.rb:35:in `load_into'
        from /var/lib/gems/1.8/gems/capistrano-2.9.0/lib/capistrano/configuration/execution.rb:139:in `instance_eval'
        from /var/lib/gems/1.8/gems/capistrano-2.9.0/lib/capistrano/configuration/execution.rb:139:in `invoke_task_directly_without_callbacks'
        from /var/lib/gems/1.8/gems/capistrano-2.9.0/lib/capistrano/configuration/callbacks.rb:27:in `invoke_task_directly'
        from /var/lib/gems/1.8/gems/capistrano-2.9.0/lib/capistrano/configuration/execution.rb:89:in `execute_task'
        from /var/lib/gems/1.8/gems/capistrano-2.9.0/lib/capistrano/configuration/execution.rb:101:in `find_and_execute_task'
        from /var/lib/gems/1.8/gems/capistrano-2.9.0/lib/capistrano/callback.rb:38:in `call'
        from /var/lib/gems/1.8/gems/capistrano-2.9.0/lib/capistrano/configuration/callbacks.rb:128:in `trigger'
        from /var/lib/gems/1.8/gems/capistrano-2.9.0/lib/capistrano/configuration/callbacks.rb:128:in `each'
        from /var/lib/gems/1.8/gems/capistrano-2.9.0/lib/capistrano/configuration/callbacks.rb:128:in `trigger'
        from /var/lib/gems/1.8/gems/capistrano-2.9.0/lib/capistrano/configuration/callbacks.rb:29:in `invoke_task_directly'
        from /var/lib/gems/1.8/gems/capistrano-2.9.0/lib/capistrano/configuration/execution.rb:89:in `execute_task'
        from /var/lib/gems/1.8/gems/capistrano-2.9.0/lib/capistrano/configuration/execution.rb:101:in `find_and_execute_task'
        from /var/lib/gems/1.8/gems/capistrano-2.9.0/lib/capistrano/cli/execute.rb:46:in `execute_requested_actions_without_help'
        from /var/lib/gems/1.8/gems/capistrano-2.9.0/lib/capistrano/cli/execute.rb:45:in `each'
        from /var/lib/gems/1.8/gems/capistrano-2.9.0/lib/capistrano/cli/execute.rb:45:in `execute_requested_actions_without_help'
        from /var/lib/gems/1.8/gems/capistrano-2.9.0/lib/capistrano/cli/help.rb:19:in `execute_requested_actions'
        from /var/lib/gems/1.8/gems/capistrano-2.9.0/lib/capistrano/cli/execute.rb:34:in `execute!'
        from /var/lib/gems/1.8/gems/capistrano-2.9.0/lib/capistrano/cli/execute.rb:14:in `execute'
        from /var/lib/gems/1.8/gems/capistrano-2.9.0/bin/cap:4
        from /usr/local/bin/cap:19:in `load'
        from /usr/local/bin/cap:19

Also ran in to this problem, with version 1.4.5 of the Rollbar gem.
Problem is here https://github.com/rollbar/rollbar-gem/blob/master/lib/rollbar/capistrano.rb#L35 since ruby 1.8.7 doesn't support the passing of an options hash to Net::HTTP.start.
It would probably work if you were to replace this
Net::HTTP.start(uri.host, uri.port, :use_ssl => true) do |http|
  http.request(request)
end

with something in the vein of this
http = Net::HTTP.new(uri.host, uri.port)
http.use_ssl = true
http.request(request)

I tried exactly that via a bundle open on the gem and it worked successfully, although I didn't check how well any other ruby versions would take to it.
In the meantime, anyone else with the problem could backport 1.9.2's Net::HTTP.start to 1.8.7. I've put a close approximation of it here https://gist.github.com/DMA57361/eddf18def093a33bcc1c. I just require it the deploy.rb file before rollbar and everything works a treat.

@DMA57361 thanks for the details of the error, hope we can solve this soon.


config always overwritten with default

No matter if Hilbish already has a config in $HOME, itll overwrite it with the default config

The file is overwritten here. I think a quick fix would be to check if the file exists, if not create it, if so load it and if there’s any errors either skip the lines or use the default. I’m not well versed in go but someone could easily fix this.


add "feedback" site

@Martin-Kuhl

One thing, from my side. I am currently separating the knowledge base. This will propably be up and running in like 10-30 minutes. So i would prefer not merging/adding any new content here.
Then we can:

Test new knowledge base
Change links in web-components to direct to new knowledgebase .
delete docs logic from main page


feat(headset_velocity): add methods to get velocities for headset

The DeviceFinder and SDK classes provide methods to receive the
velocity and angular velocity of controllers. This change adds methods
to retrieve those velocities of the headset. The controller velocity
methods of the VRTK SteamVR SDK have been updated to only return
velocities of controllers, not the headset, because SteamVR uses
indexes for all the tracked objects.

See #805.

Is this ready for me to final test and merge now?


JS TypeError in split and remove action

When working with two segments and splitting one of them, this error is raised after the 2part is removed:

Steps to reproduce

Load file: sector-musgogenesis-inferior-la-pedriza-desde-el-tranco.gpx
Load file: el-tranco-placa-del-emilio.gpx
Split segment "el-tranco-placa-del-emilio.gpx"
Remove "el-tranco-placa-del-emilio.gpx_part1"

Files to reproduce
bug135.zip

Alternative reproduction

Load island_1.gpx
Load island_2.gpx
Split island_2.gpx
Remove island_1.gpx_part1


[TASK] Expose a function for fetching Chain Id and Chain Type

We should have a public function that returns these types: https://github.com/webb-tools/protocol-substrate/blob/main/pallets/linkable-tree/src/lib.rs#L111-L115

We do. They should be exposed on the Inspector trait.
On Thu, Feb 17, 2022 at 6:11 AM Filip Lazovic @.***>
wrote:

We should have function that returns these types:
https://github.com/webb-tools/protocol-substrate/blob/main/pallets/linkable-tree/src/lib.rs#L111-L115
—
Reply to this email directly, view it on GitHub
https://github.com/webb-tools/protocol-substrate/issues/162, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ADELLF7O7SZ6VLRQXMEVHQLU3TJXLANCNFSM5OULIPHQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


[WIP] Doc updates

inline transactions
running multi-nodes

:white_check_mark: Build AElf <IP_ADDRESS>61 completed (commit https://github.com/AElfProject/AElf/commit/d6c4ca4fab by @samfrb)


Remove redundant Redis mentions

Signed-off-by: Igor Egorov<EMAIL_ADDRESS>

PR was closed automatically due to change of branch name. Now it conforms to https://github.com/hyperledger/iroha/wiki/Iroha-working-agreement#243-feature


Avoid redundant tuple layer for ExpandedName::from_static

Since the method has to be called explicitly, the tuple layer serves no functional purposes.
This split in API conventions has precedence in the standard library, e.g. HashMap::retain accepting a two-argument closure versus impl FromIterator for HashMap expecting key-value pairs.
cc @WhyNotHugo

Thanks!

Makes perfect sense :+1:

FWIW, the first argument could be Option<&str> to allow creating ExpandeNames with no namespace too.

FWIW, the first argument could be Option<&str> to allow creating ExpandeNames with no namespace too.
Want me to send a patch for that?

https://github.com/RazrFalcon/roxmltree/pull/100#discussion_r1246946216

@WhyNotHugo For consistency, I guess we can add Option<&str> too.

Another possible option is:
    pub const fn from_static_without_namspace(name: &'static str) -> Self {
        Self {
            uri: None,
            name,
        }
    }

The naming is horrible, but I can't think of anything better.
FWIW: I only need the existing variant; I'm only suggesting the Option variant for completeness' sake. But it's also perfectly fair to omit it until somebody actually needs it.

Yes, the name is too long. Too bad Rust doesn't have named arguments like Swift.
I would suggest adding Option anyway, otherwise the current constructor is partial.


Build a release binary for multiple platforms

See rust cli docs and ripgrep for pointers.

Release notes: https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes#configuring-automatically-generated-release-notes


Playing a song from a list ?

I am trying to play a song from a list (I have a list of songs, and ListTile.builder( ).. and I cannot seem to pass an index from a list.. until now, I have to write audioCache.loop('music/songName.mp3');  instead of  audioCache.loop('songs[index].songName');
The problem is: My PlayAudio( ) function (where audioCache is located) is a void, so I cannot pass an index trough a void function. When I try, it gives me an error saying that Function has to be void.
Is there any solution to this problem?
 (To make a player for every single song, so if I have 20 songs, I have to copy 20 time my player.dart file and change the name of the song to every single one of them.
Thank you for your time reading this Issue message.
Greetings from Europe.

Hi Nemanja,
From your explanation, this is not an issue with this plugin but however an
issue regarding your projects architecture or how you are trying to play
the songs. Have you ever played with flutter providers? This comes in handy
when try to notify things all around your app and they work perfectly. With
this you can create a global list to hold your songs, add to that list and
it changes everywhere in your application in real time. Use it to track the
current stuff and even more. And you can hence play any song at any index
when and where ever you want
Check it’s documents here
https://pub.dev/packages/provider
If you have any questions feel free to ask.
Best Regards,
Mua
On Sat, 12 Sep 2020 at 23:33 Nemanja Cvetkovic<EMAIL_ADDRESS>wrote:

I am trying to play a song from a list (I have a list of songs, and ListTile.builder(
).. and I cannot seem to pass an index from a list.. until now, I have
to write audioCache.loop('music/songName.mp3'); instead of
audioCache.loop('songs[index].songName');
The problem is: My PlayAudio( ) function (where audioCache is
located) is a void, so I cannot pass an index trough a void function. When
I try, it gives me an error saying that Function has to be void.
Is there any solution to this problem?
 (To make a
player for every single song, so if I have 20 songs, I have to copy 20 time
my player.dart file and change the name of the song to every single one of
them.
Thank you for your time reading this Issue message.
Greetings from Europe.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/luanpotter/audioplayers/issues/626, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD4X4XWOMWW3ELSMBHDEFPLSFPZMZANCNFSM4RKBVUOA
.
--

MUA N. LAURENT: Lead Software Engineer
Akivas Inc. https://akivas.com/
Makepe Rhone Poulenc, Douala
Phone: (237) 670-518-086

@NemanjaCvetkovic1993 your problem is that you are doing
audioCache.loop('songs[index].songName')

instead of
audioCache.loop(songs[index].songName)

this is a very simple dart question, not even flutter, much less related to this plugin, so I will close this issue.


Record how long crc startup takes on each run.

Track time between each commmand; from crc setup to crc start and crc stop.

Be sure to look at cluster operators status before that. If there are not all green, the cluster is not ready and most of the time this is what happens.

Be sure to look at cluster operators status before that. If there are not all green, the cluster is not ready and most of the time this is what happens.

There was no consensus on how to check for the status and what to report.

We can measure both, time until  crc start finishes, and time until oc get co is all green.

It is now logged in segment.

It is now logged in segment.

Keeping this open for a while longer, but see gbraad's question from previous comment:

If this data is available and shared, please close the issue.


Question: Is it safe to create more than one Analytics object with different configuration?

Wanting to know if it's OK to create two instances of the main Analytics class in a single application. I understand this is not recommended, but is it supported? We have case where we need to send some events to a separate pipeline.
Thanks for listening.

yep. that's totally ok. in fact, that's one of the main factors we take into account when architect this SDK over the old android one.

This is great! Thank you for quick response - and supporting this!. FYI: Asked same question for Apple SDK here: https://github.com/segmentio/analytics-swift/issues/235


add support for numbers alignment in table output (#1202)

previously numbers alignment was hardcoded to 'right'. This change adds
the ability to set a configuration value 'numbers.align' in the
formatting section of the config to alter the format of the table output.

Thanks for your interest in Rally and your PR! We'll start the review process shortly.
@elasticmachine test this please

Hi! Thank you for this.  For the race subcommand things work as I would expect, but I wanted to note that when I use Rally's compare subcommand I get a failure, and it prints an error if the configuration is not defined:
[ERROR] Cannot compare. No value for mandatory configuration: section='reporting', key='numbers.align'

From the log:
Traceback (most recent call last):
  File "/Users/rick.boyd/dev/rally/esrally/config.py", line 178, in opts
    return self._opts[self._k(scope, section, key)]
KeyError: (<Scope.application: 1>, 'reporting', 'numbers.align')

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/rick.boyd/dev/rally/esrally/rally.py", line 774, in dispatch_sub_command
    reporter.compare(cfg, args.baseline, args.contender)
  File "/Users/rick.boyd/dev/rally/esrally/reporter.py", line 48, in compare
    ComparisonReporter(cfg).report(
  File "/Users/rick.boyd/dev/rally/esrally/reporter.py", line 315, in __init__
    self.numbers_align = config.opts("reporting", "numbers.align")
  File "/Users/rick.boyd/dev/rally/esrally/config.py", line 183, in opts
    raise exceptions.ConfigError(f"No value for mandatory configuration: section='{section}', key='{key}'")
esrally.exceptions.ConfigError: No value for mandatory configuration: section='reporting', key='numbers.align'

Good catch. I have addressed the issue you raised. Please let me know if there is anything else.

wonderful! thank you @cmanning09. This code functions as I'd expect, and as you indicated in the initial commit it addresses #1202 nicely.
I have one more ask/iteration of you: this functionality should be documented.  please consider whether it will be supported similarly to the reporting.format key, in that it's only documented as the CLI --report-format flag (in which case more code would be required), or if users should always specify it in the [reporting] section of their local .ini.  Note that the documentation for that section states This section defines how metrics are stored. and so would need to be updated for the new meaning.
Thank you!

I addressed your concern by adding support through CLI flags for both race and compare subcommands. Is there anything else?

Beautiful! I've tested it and it works as expected.  Please add the documentation and then I think we're all set. (Should be in docs/command_line_reference.rst)

@cmanning09, just as an update: I am having trouble getting this branch to pass our internal CI.  I don't believe this is due to your code, so please bear with me.  Once tests pass cleanly I will merge this one in

@elasticmachine update branch

@elasticmachine run tests


Add intervention to 1.0.1

Intervention to be added to 1.0.1 see intervention feature branch and start with TSVs.
Three statement templates - start with TSV definitions
What we want to record:

Create activity (verbcreate)

Mode (email/text/telephone intenal list and institution cnan have their own)
Reason (match traffic-light list?) Subtypes if insitituion has their own etc
Timestamp
Weighting (1-5 severity)
Tutor (tutor id)
Start dates, end dates (leave these to 1.0.2)
2 Closed activity (verb close)
Item id
Tutor id
Verb that they closed it

Updated activity (verb updated)
Item id
Tutor id
Add Note
Change sevitory
Type (note or sevitory)
Verb updated

Double check. whay these categories, how do they fit in to what adam/tribal already have
hold off on json templates etc until confirmation

I'm just about to commit a first stab at  'notes'. There are a few ways this could work, but I think working out which is the most practicle depends what exactly notes are (are they a jisc thing or more general?) and how they will be analysed. This is what I've commited so far:

Create: A note (http://xapi.jisc.ac.uk/intervention/note) is created (Verb: http://activitystrea.ms/schema/1.0/create)
Update: A note with the same object.id to the inital note is updated (Verb: http://xapi.jisc.ac.uk/update)
-Close:  The note is closed (http://xapi.jisc.ac.uk/close).

Other ways:

Create: A note ("http://xapi.jisc.ac.uk/intervention/note") is created (Verb: http://activitystrea.ms/schema/1.0/create)
Update: A note with a different ID to the inital note  is created ( and the parentnote is uses context.contextactivities.parent to show which note is updated.
-Close:  The parent note is closed .

In each of these I've put the student that the note is about as the actor and included the instructor in  context.constructor. I think we've had conversations about this before with marking and the such?

Re the actor:
I do like the idea of having the student as the actor, from the POV of LA, because it always puts the student in the same place, making for consistent query formation and data processing. For assessments this was OK because we could use verbs like submitted and scored. In the current case, I fear we'd end up with either:
a) broken subject-verb-object semantics if subject = student and verb=create
b) a convoluted pseudo-verb for "had something created about"
So... it might be the lesser of two carbuncles to make the staff member be the agent.
Re object id continuity vs parent id:
I see 2 things to identify, the "case" and individual "notes". The case is opened and closed, and maybe updated (e.g. change category). The notes capture comment and interaction modality. I think the continuity here is in the case id, i.e. == the object.id. xAPI statement ids OK for individual notes.
Avoidance of context parent makes for easier data handling.
So... the way I'm now seeing this is to model the process as create/update/close a case and add a note to a case. Update is exactly the same template as create (except different verb) but adding a note is just a comment. This would leave the data processor to figure out what changed in an update and whether that is important (e.g. change in severity). An alternative would be to mint verbs for things like change of severity, which seems OTT at present.

Weekly call:
Follow adams ideas

Person creating note should be actor.
Open case - add comments - close case. Case is parent, notes belong to case


Remove traits for disguised types without children

Part of https://github.com/gtk-rs/gir/issues/760

Thanks!