Including a shape on schema-defined computed links

I couldn't find an issue for this UnsupportedFeatureError: including a shape on schema-defined computed links is not yet supported , so creating one as a feature request.

I guess for the most cases, this would be useful with stored computeds https://www.edgedb.com/roadmap#caching (thinking of something like statistical computeds in a type obtained from traversing other types and combining some stuff from them)

Elvis was trying to solve this a while back with a grand unification of computeds and aliases (https://github.com/edgedb/edgedb/tree/computables-are-aliases) that ran into a bunch of snags and has now hopelessly bitrotted.
It's probably worth revisiting fresh.

Yeah, I think much (if not all) of the behaviour is achievable using globals and aliases

@msullivan Can we get this feature when free object typings land? I couldn't really understand why this is prohibited so I'm probably mistaken by assuming that problem was type/cardinality inference


protonvpn-cli: 3.12.0 -> 3.13.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for protonvpn-cli is: "Linux command-line client for ProtonVPN"
meta.homepage for protonvpn-cli is: "https://github.com/protonvpn/linux-cli"
meta.changelog for protonvpn-cli is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.13.0 with grep in /nix/store/qb0pd9kvavp8d45ym457pxxwg1fd5z27-protonvpn-cli-3.13.0
found 3.13.0 in filename of file in /nix/store/qb0pd9kvavp8d45ym457pxxwg1fd5z27-protonvpn-cli-3.13.0

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
protonvpn-cli

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/qb0pd9kvavp8d45ym457pxxwg1fd5z27-protonvpn-cli-3.13.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A protonvpn-cli https://github.com/r-ryantm/nixpkgs/archive/8e4dd2f3716d471f87fa2bd98f172d6a5f341e48.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/qb0pd9kvavp8d45ym457pxxwg1fd5z27-protonvpn-cli-3.13.0
ls -la /nix/store/qb0pd9kvavp8d45ym457pxxwg1fd5z27-protonvpn-cli-3.13.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

protonvpn-cli

Maintainer pings
cc @WolfangAukang for testing.

Do not merge until #191761 is fixed.

Result of nixpkgs-review pr 191530 run on x86_64-linux 1

1 package built:

protonvpn-cli


Create a composer package

It would be great (and appreciated) if you could create a composer package for this library. Thank you!

@pda Would you be willing to accept that pull request and maybe even put this on packagist?
I'd be happy to take the project over if you no longer have the time. I haven't seen another PHP consistent hasher out there.

:+1:

This is now on packagist at https://packagist.org/packages/flexihash/flexihash


Apis Structure, including IEEE and ArXiv compatibility

The basic structure of the Api has been implemented.

When you've fixed the tests (based on removing the axelbib stuff) and general clean up after our meeting I'd like to look through this before it's merged in (just in case you were going to merge without waiting for me to look at it).

I am not sure why there is a conflict. I tried to go around it but I couldn't make it work.


remove parent route after creating new resource

My API looks like the following:
/jobs/xxx/invoices - POST (create a new invoice against a job)
/service-calls/xxx/invoices - POST (create a new invoice against a service call)
/invoices - GET, PUT/PATCH, DELETE (view, edit, update an invoice regardless of what it is attached too)

After I save/create a new invoice I don't want it to be a nested resource anymore. Currently I am just setting parentResource = null and this seems to work but just wanted to check if this is the best way.

+1
When II POST to restangular resource got using restangular.get('user',111111) using User.post('app',{}) i get back an object that has no parent. (checking via parentResource property)
I confirmed that when using restangular 1.4 I get the expected user parent, we will be happy to provide further info if needed

+1 (but not exactly)
Please check my question on SO: http://stackoverflow.com/questions/36344618/how-do-i-perform-specific-parentless-requests-using-restangular-in-a-neat-way


Anyone interested in documentation?

We welcome all opinions on the verification of familiar people and the understanding of beginners. #492

Focus for Participation

document structure https://github.com/zdharma/zinit/pull/492#discussion_r615809299
better sentence suggestion
any mistake(like type, indent, ....)


onPartialSend

Are you requesting a feature, reporting a bug or ask a question?
How to implement this method?
It is actually don't work for me
Provide the test code and the tested page URL (if applicable)
Tested page URL:
Test code
///<reference path="../../../node_modules/survey-react/survey.react.d.ts"/>
import * as React from 'react';
import { Survey, defaultBootstrapCss } from 'survey-react';

export default class KidsSurvey extends React.Component<any, any> {
    public state: any;
    constructor(props: any) {
        Survey.cssType = 'bootstrap';
        defaultBootstrapCss.navigationButton = 'btn btn-primary';
        super(props);
        this.state = {
//have some json with 3 pages
            surveyJSON: ....
        };
    }

    render() {
        if (this.state.surveyJSON) {
            return <Survey json={this.state.surveyJSON}
                           onComplete={this.sendDataToServer}
                           sendResultOnPageNext={true}
                           onPartialSend={this.testsdf}
            />;
        }
        return
Loading...
;
    }

    testsdf(data: any) {
//cant even get there!!!!
        console.log(2222);
        console.log(data);
    }
   sendDataToServer(data: any){
   //this works fine!!!!
  }
}

Specify your

browser: chrome
browser version: latest
surveyjs platform (angular or react or jquery or knockout or vue): react
surveyjs version:0.12.30

Actually I just need some callback on each page. It would be awesome to set this callback via page parameter
"pages" : [ { "name": "page1", "onComplete": "callbackName", "onValidate": "callbackName", "doNext": "callbackName", ]
Something like this maybe

@Iphoning Please use "sendResultOnPageNext" in the JSON. We do not process "sendResultOnPageNext" as react attribute.
Thank you,
Andrew


remove default -trusted-servers IP

The default trusted-servers IP is no longer is use. This results in unnecessary queries that will timeout if gochinadns is started without this flag (e.g. when used as a drop-in for the original chinadns).

LGTM, thanks for your contribution!


Create Core API and Implementation

Core API and entry point to the Kontinuity Catapult.  Defines high-level capabilities intended to be called by outside clients; designed to be additionally exposed as a web endpoint.
This is where we need to determine the inputs for what we need to:

Fork a GitHub repo into a user's namespace
Create an OpenShift project for the user
Set up the project with the right template (pipeline build config), repo reference
Register with GitHub a webhook to point to the OpenShift project

Also this will define the output for what we return to callers

Location of the new Project in OpenShift
...etc

This task simply to set up the API and a first-pass impl.  Further work and iterations done here may be completed in new, finer-grained issues.  For now let's just give ourselves a place to work so we can hook things together.  The web pieces will expose this API as a RESTful (or at least HTTP, to be determined) service.

ba7a87f


Update README.md

Hello,
Not having an empty set in adapter.sockets function will raise a "is not iterable" error.

Thanks! :+1:


Help Building from Source

Hello,
Trying to build turbodbc from source (no pip), but having the error:
In file included from src/turbodbc_python/python_result_set.cpp:1:0:
include/turbodbc_python/python_result_set.h:4:31: fatal error: pybind11/pybind11.h: No such file or directory
Sorry there is not as much detail because I have to dictate error messages and output by hand as the system is on a standalone network.
The following is installed:
RHEL 7.6
Python 3.7
Pybind11 2.4.3
libboost-all-dev
unixodbc-dev
python-dev
Any thoughts on what I can do next?

This is possibly happening because you have not downloaded the git submodules. Please run in your local checkout:
git submodules init
git submodules update

I'm assuming that requires internet access to this project. If so, I'm on a stand alone network so that make it challenging. Are the submodules in the latest tar.gz?

No, they aren't. I would suggest to clone with submodules where you have internet and copy over all files then to your standalone network. Alternatively, a PR to use pre-installed pybind11 is always welcomed.


Adding Role Member should reload Members

I added myself as a member here, there was a confirmation, but the list of members did not reload:

cc @gib

Thank you @krallin, I know exactly when/where I introduced this yesterday. Running too fast / loose.


Cw xray

There are two changes here:

c7n/resources/init.py  - added line to import xray.py
c7n/resource/xray.py - support for Xray filter and action.

@eprparadocs you checked in some changes to sphere11/salactus/other tools can you remove those to keep the scope of this PR smaller?

Fixed the lint issue, and now flake8 passes all the changes in account.py. Tested the code against AWS and the filter returns the "correct stuff" (per Sonny).


chore: import repository https://github.com/adithya180498/vertx-rest-prometheus.git

this commit will trigger a pipeline to generate the CI/CD configuration which will create a second commit on this Pull Request before it auto merges

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adithya180498: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

verify
fbbc8d0f20f03af4cf6644d7b468aca960c1da96
link
/test verify

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Bug in select when one channel closed

this example work fine in 0.31.1 and failed in 0.32.1:
ch1 = Channel(Int32).new
ch2 = Channel(Int32).new

spawn do
  sleep 0.1
  ch1.send(1)
  ch1.close
end

spawn do
  sleep 0.2
  ch2.send(2)
  ch2.close
end

2.times do
  select
  when v = ch1.receive
    puts "ch1 - #{v}"
  when v = ch2.receive
    puts "ch2 - #{v}"
  end
end

ch1 - 1
Unhandled exception: Channel is closed (Channel::ClosedError)
  from /Users/kostya/Downloads/crystal-0.32.1-1/src/channel.cr:542:7 in 'default_result'
  from /Users/kostya/Downloads/crystal-0.32.1-1/src/channel.cr:269:9 in 'select_impl'
  from /Users/kostya/Downloads/crystal-0.32.1-1/src/channel.cr:390:12 in 'select'
  from 2.cr:17:3 in '__crystal_main'
  from /Users/kostya/Downloads/crystal-0.32.1-1/src/crystal/main.cr:97:5 in 'main_user_code'
  from /Users/kostya/Downloads/crystal-0.32.1-1/src/crystal/main.cr:86:7 in 'main'
  from /Users/kostya/Downloads/crystal-0.32.1-1/src/crystal/main.cr:106:3 in 'main'

after reading this https://gist.github.com/bcardiff/289953a80eb3a0512a2a2f8c8dfeb1db, i tried receive?, but it just return nil forever. I think this error should only raise when all channels closed.

I don't like that there's not a way to do this? Is go really the same?

The equivalent to go's is to use receive? that would return nil on close. But that will not play nice for nillable message types.

@bcardiff but that would return nil immediately. Is there no way to ignore closed channels in select statements?

Right. Using receive? is not enough.
While working on #8304 I recall that we thought/decide that executing a select over an already closed channel was a bit of a smell. If it is already closed you should not do a select. If it happens to become closed while waiting it is useful to know about that event. But that left out the chance to dynamically build the list of channels to listen (unless the non-public Channel API is used).
Together with the above, we wanted to unify some behaviors.
We have
ch = Channel(Int32).new
ch.close
ch.receive  # raise: Channel is closed (Channel::ClosedError)

and
ch.receive? # => nil

So on blocking and non-blocking select over a closed channel, we have something similar
select
when a = ch.receive
  a
end # raise: Channel is closed (Channel::ClosedError)

select
when a = ch.receive?
  a
end # => nil

Maybe the behavior of ch.receive? on select should be equivalent to return nil only when the channel is closed while waiting so to signal de closing action. But is odd that outside the select that will return immediately.
I liked that select; when S; end is the same as S, which is the current semantics in 0.32.

Usage of select is sync state while receive data from multiple channels, its normal that some of them can be already closed. I think it should raise error only when all channels closed.

Perhaps receive_select_action(allow_closed: true)?

@kostya you mean to raise if all the channels are closed from the beginning and the select is blocking. Plus trigger the when branch when the channel is closed while waiting?
What do you suggest for non-blocking select? trigger the else if all are closed or raise (even if receive? is used)
(maybe @firejox will want to join the conversation).
@RX14 let's focus on semantics first. But I would like to avoid parameters within the select/when

Comparing things with Go. The following code executes the c1 or c2 branch without guarantee. So an already closed channel triggers the blocking select also in Go.
package main

import (
	"fmt"
	"time"
)

func main() {
	c1 := make(chan int)
	c2 := make(chan int)

	close(c1)
	go func ()  {
		c2 <- 2
	}()
	time.Sleep(500 * time.Millisecond) // ensure c2 has a message

	go func() {
		fmt.Println("a")

		select {
		case m, x := <-c1:
			fmt.Println("c1 ", m, x)
		case m, x := <-c2:
			fmt.Println("c2 ", m, x)
		}

		fmt.Println("z")
	}()

	time.Sleep(500 * time.Millisecond) // wait for the select
	fmt.Println("done")
}

@bcardiff the semantics for what i proposed would be that you can specify a parameter which means recieve wouldn't raise when that channel is closed when used in select, unless all channels were closed.

Here are the relevant tests for Go's select over closed channels:
https://github.com/golang/go/blob/master/test/chan/select3.go#L194-L216
Selects with closed channels behave like ordinary operations: receive doesn't block while send panics; Channels thus behave the same whatever if they're running inside a select or not.
Yet, if multiple channels are ready (before blocking), select will choose a channel to read/write from/to at random, which may allow to read from channel A while channel B is closed if running inside a loop (with a sleep(0) to avoid burning/blocking the current thread)?

I agree with @bcardiff: there shouldn't be any parameter to select.

I was going to propose to allow nil to receive and send on select as a way to turn off channels subscriptions.
It sounded weird but... https://dave.cheney.net/2013/04/30/curious-channels (Jump to "A nil channel always blocks").
Ideas?

Alternatives:

Create a NilChannel or similar to avoid polluting Nil
Just create a new channel in the loop and never send messages.

ch1 = Channel(Int32).new
ch2 = Channel(Int32).new

spawn do
  sleep 0.1
  ch1.send(1)
  ch1.close
end

spawn do
  4.times do
    sleep 0.2
    ch2.send(2)
  end
  ch2.close
end

nil_channel = Channel(Int32).new

while ch1 != nil_channel || ch2 != nil_channel
  select
  when v = ch1.receive?
    if v
      puts "ch1 - #{v}"
    else
      ch1 = nil_channel
      puts "ch1 closed"
    end
  when v = ch2.receive?
    if v
      puts "ch2 - #{v}"
    else
      ch2 = nil_channel unless v
      puts "ch2 closed"
    end
  end
end

I think the ignoring behavior is a bug in 0.31.1. The case of closing channel during select is not well implemented in 0.31.1, so the select ignores the closed channel. If we change the length of sleeping time and the times of the select. The program will raise the exception as #8231 or hang forever.
Besides, I think the new feature is unneeded. We can just maintain available channels on each select until there is no available channel.

Ok. Looks like need to rethink how to use 'close' on channels. And actually not use it in my cases. I used it like in sockets, just close when it not needed (in sockets to free descriptors). If i remove close from example it works as expected. So if i would create millions of short-living channels (for timeouts for example), and not closing them, and its ok for GC, so i guess i not going to use it.

We are all learning and trying to get better here :-)
We can create a NilChannel that can be probably even a struct, not inheriting Channel, and implement the _select_action methods for it to work on select. That would be slightly better for the GC.
But also you can have a single (per each type) of the current channels also.


[AutoPR] vmwarecloudsimple/resource-manager

Created to accumulate context: vmwarecloudsimple/resource-manager

(message created by the CI based on PR content)


feature req: translation export list of translations made.

So. If one translates blend shapes, animations which make use of it will be broken. Its not too hard to fix manually,
but it would be nice if, after hitting the 'translate' button, it would also export a list of translations made, maybe
something like:
mesh/object,original,translated

and so on so one could more easily 'translate' the animations you may have.

Unfortunately I think you are shouting into the void here, cats has not been updated in several months and will most likely never be updated again. There are forks and unofficial versions out there which are though.

Do you happen to have a suggested fork/version, then? I'm currently on blender-3.6 (at least while I have to do cats-related work), honestly can't remember which development version I grabbed to make it work.

My own: https://github.com/Yusarina/Cats-Blender-Plugin-Unofficial-
I was gonna link a couple of others however it looks like there not been updated anymore.


[otp_ctrl/doc] WIP Incremental updates to documentation

This PR is WIP and contains incremental documentation updates for the OTP controller.
In particular, the following details have been added/changed:

updates to OTP macro interface and error codes
the LC partition has been moved to the end of the address map
detailed FSM state diagrams have been addded
updates in the main block diagram
small fixes here and there

I'll put this up for review once the documentation has fully converged.
Also, this currently partially depends on hjson updates in #3416.

@mcy FYI
This PR is not entirely finished yet, but it contains a couple of updates to the OTP programmer's guide and the OTP address map.
The remaining changes are mostly design internal details (FSM descriptions, etc) that are probably not of interest to you.

yes i think that makes sense. We probably want this to be an owner specific
decision anyways.
On Wed, Sep 23, 2020 at 10:02 PM Michael Schaffner<EMAIL_ADDRESS>wrote:

@msfschaffner commented on this pull request.
In hw/ip/otp_ctrl/doc/_index.md
https://github.com/lowRISC/opentitan/pull/3456#discussion_r494040050:

@@ -649,14 +649,18 @@ Typical programming sequences are explained at the end of the Programmer's guide
The OTP controller initializes automatically upon power-up and is fully operational by the time the processor boots.
The only initialization steps that SW should perform are:

-1. Check that the OTP controller has successfully initialized by making sure that {{< regref STATUS >}} is IDLE and not in an ERROR state.
-2. Program and lock down the frequency of periodic background checks in HW.
+1. Check that the OTP controller has successfully initialized by reading {{< regref STATUS >}}. I.e., make sure that none of the ERROR bits are set, and that the DAI is idle ({{< regref STATUS.DAI_IDLE >}}).
this introduces the following changes with respect to the previous version:

the maximum period is now defined using a bitmask instead of an
exponent, since it is easier to handle like that in HW.
the checks are opt-in now (previously, they have been enabled by
default)
the checks can now be triggered on-demand as well for scenarios
where the periodic background checks are left disabled.
an optional timeout counter is added to ward against physical
tampering attempts that leave the OTP-internal bus in a wedged state.

these changes have been introduced since there may be a need to leave the
automatic background checks disabled if it later turns out that they are 1)
flaky for some reason (they shouldn't be), 2) they become a reliability
issue since they may lead to more wear of the physical OTP device than
anticipated (again this shouldn't be the case, but we want to stay on the
safe side and provide this option).
if mask ROM is going to set this up, it may make sense to put this
configuration into OWNER_SW_CFG.
WDYT?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/3456#discussion_r494040050,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSRODNG6UWOETZG23PDSHLHGPANCNFSM4RPZYX5Q
.

Note that this PR has become dependent on #3633. Only the last commit in this PR is relevant.
I am currently adding updating the details related to key derivation, and will put this up for review, once finished.

Ok, most of the documentation updates are in now. Here is again a summary of what has changed:

Updates to OTP macro interface
Add detailed FSM state diagrams for partitions, as well as LCI, KDI and DAI
Address map updates (the LC partition has been moved to the end)
Document initialization sequence for periodic checks
Updates in the main block diagram
Update links, remove several TODOs
Updates for interface signals, blockdiagram and scrambling keys
Updated error codes and description
Updated scrambling docs, added RAW unlock token hashing function

There are only a few TODOs left in the doc now, and they are mostly related to interfaces and clock synchronization. I am going to look at this now as I instantiate the OTP controller in the top-level.

Rebased onto master - the other commits should be gone now.

Thanks for all the comments. I'll merge this now to make progress (but let me know on this PR if there is something that needs to be amended). The documentation updates related to asynchronous transitions and clock muxing will come in a separate follow up PR.


Fix Zeno visualizer on tasks like GSM8k

GSM8k is an example of a task that didn't work well with zeno at all (unfortunately my first experience too, via tinygsm8k...), as it contains multiple filters (thus generating multiple rows with the same doc_id) and metrics that aren't possible to aggregate via mean (thus previously not at all visible in the results in zeno, which was super confusing).

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Petr Baudis seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


could it export GLTF file or  generate to model file in three.js?

if the plug-in support export gltf ，that is amazing

That would need a gltf extension. I will look into this..

I've been able to export models with a shader to gltf / glb using the blender gltf exporter

I've been able to export models with a shader to gltf / glb using the built in blender gltf exporter

so cool,could you share that?


Spike Tooling Container

User Story:
As a DevOps engineer I want to have a tooling container to run workloads. The container will be used to have a consistent experience across the team.
Acceptance Criteria:
The container must be able to run the following tools

Terraform
kubectl
aws cli
aws vault
helm

To do:

compare benefits and drawbacks of standard docker container and VSCode Devcontainer
come to a decision of which tool better suits the team

More requirements:

The container must be able to mount to local filesystem to access authentication data such as ~/.aws, ~/.ssh
The container must be able to access existing repositories from local PC through mount points
Suggested approach:
VSCode devcontainer -- Documentaiton: https://code.visualstudio.com/docs/devcontainers/containers

Having a tooling container where common tools are installed and used by every member of the team.
James recommended a tool that should also be considered for running Github actions locally as part of tooling standardisation --> https://github.com/nektos/act
Useful repo:
https://github.com/ministryofjustice/hmpps-engineering-tools

This should be used in the pipeline as well

2 options, 1. standard docker container and 2. VSCode Devcontainer

Time Box : 2 days

Container:
https://github.com/ministryofjustice/nvvs-containers
Implementation:
https://github.com/ministryofjustice/staff-device-dns-dhcp-infrastructure/pull/297
Some usage documentation on both repos to be concluded.


Game logic

Adds first layer of game logic.
Can move square around on screen with arrow keys.

:shipit:


Simplified Payment Verification (SPV)

As a user, I want to be able to verify payment from a "simple device", such as a phone, without relying on having to download the full blockchain state and validate everything.
This will be addressed by making a block verifiable, then providing a Merkle Path within this block.

CC @MichaelKim20 @TrustHenry : Since we have both Merkle path verification and block signature, I think all that is needed is the implementation on your side. When do you think you can get to it ?

So questions that this bring:

Does Stoa have the required APIs for us ? Currently we have the API in Agora, but we want clients to interact with Stoa.
Does Stoa expose a way to only get the block header ?
What policy do we apply in the client for block header retention ?
How much consensus rules can we and should we check in the client (most important question) ?
Provided an implementation that does periodic polling on a hash, how much story point would an implementation be ?


Fix LibvirtStorageAdaptor.java

Description

I fixed createNetfsStoragePool() function in LibvirtStorageAdaptor.java.
The current implementation of createNetfsStoragePool() does not unmount already mounted pool in non-English environment so I edited it to check the pool is already mounted using mountpoint command and unmount the pool if already mounted.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):
How Has This Been Tested?
I got the following output in agent.log in a KVM hypervisor host:
2018-06-06 19:51:26,059 INFO  [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-5:null) (logid:293e0c5c) Attempting to unmount old mount at /mnt/00ec8deb-14b2-3264-bd61-4bf38f4bccc5
2018-06-06 19:51:26,090 INFO  [kvm.storage.LibvirtStorageAdaptor] (agentRequest-Handler-5:null) (logid:293e0c5c) Succeeded in unmounting /mnt/00ec8deb-14b2-3264-bd61-4bf38f4bccc5

This output indicates already-mounted mountpoint /mnt/00ec8deb-14b2-3264-bd61-4bf38f4bccc5 is successfully unmounted.

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
Testing
[ ] I have added tests to cover my changes.
[ ] All relevant new and existing integration tests have passed.
 I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2094

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@DaanHoogland Yes, I understand, we check for "already mounted" in the code.
However, my main point is, why do we manually unmount. Destroying the pool in libvirt should make sure the mountpoint is gone.

so @wido your objection is to Script.runSimpleBashScript("umount -l " + targetPath);? I would agree to that but it is not part of this change. Do you propose to change this change to deal with that in one go?

Hmm, yes, I understand you. It would be better if libvirt would handle all this, but it's indeed not part of this PR.

@DaanHoogland The current implementation detects "already mounted" in e.toString() but e.toString() is language configuration dependent. In Japanese environment, it gives "すでにマウントされています" instead of "already mounted" and the KVM agent doesn't unmount the pool.

Trillian test result (tid-2735)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 23346 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2696-t2735-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 63 look OK, 4 have error(s)
Only failed tests results shown below:

Test
Result
Time (s)
Test File

ContextSuite context=TestDeployVirtioSCSIVM>:setup
Error
0.00
test_deploy_virtio_scsi_vm.py

test_03_vpc_privategw_restart_vpc_cleanup
Error
120.44
test_privategw_acl.py

test_05_rvpc_multi_tiers
Failure
355.42
test_vpc_redundant.py

test_05_rvpc_multi_tiers
Error
378.29
test_vpc_redundant.py

test_hostha_enable_ha_when_host_in_maintenance
Error
3.47
test_hostha_kvm.py

yes @cl-k-takahashi we understand that.
@wido do you accept the change as is?

Test LGTM, merging this based on code reviews and test results, as well as manual testing of mountpoint tool on centos6, centos7 and ubuntu 16.04/18.04.


[BEAM-11936] Fix errorprone warnings

Fixed errorprone warnings listed here:
UnusedVariable: The presence of an unused variable may indicate a bug. This check highlights private fields and parameters which are unused and can be safely removed without considering the impact on other source files.
For reference https://errorprone.info/bugpatterns

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Hi @TheNeuralBit, would you help me to review this?

Thanks that helps a lot! I just took a look at #15821. Let's get that one merged then come back here.

Hi @TheNeuralBit, I've removed most of the unused variables, including unused LOGs, this PR is ready to review.

Run Java PreCommit

Run Java PreCommit

Run Java PreCommit

Run SQL PreCommit

Run Java PreCommit

Run Java PreCommit

I looked this over, but I still haven't gotten through everything. I would like to actually review all the changes closely since these have the potential to break users. But that's going to make it really hard to get this in... by the time I'm done looking it all over there will surely be merge conflicts. I think we should try to break this up a little bit to avoid merge conflicts, and make it easier for multiple people to review.
I just proposed #16010 which adds a configuration variable suppressUnusedVariable: true to every build.gradle. If you're ok with it, we could merge that change, and then you'd be able to send a few PRs that enable the unused variable warning for a few related packages at once (e.g. one for all SQL extensions, one for all IOs, one for all runners). We should be able to distribute the reviews for those PRs, and get them merged quick enough to avoid conflicts. What do you think?

I am ok with breaking up this PR into smaller ones.

@TheNeuralBit I've already split this PR into:

Extensions #16033
Extensions-SQL #16034
Runners #16035
IO #16036
Core, examples, harness #16037

We can continue the review of those PRs.
PS. I've fixed the last suggestions on the new corresponding PR.

Perfect, thank you! I've tagged some appropriate reviewers for each PR.


Simple question: how to make required fields handled by resolvers only?

Note: If your question is regarding the AWS Amplify Console service, please log it in the
official AWS Amplify Console forum

** Which Category is your question related to? **
gql-compile
** What AWS Services are you utilizing? **
amplify-cli -> appsync
** Provide additional details e.g. code snippets **
Here's my schema:
type Post {
   id: ID!
   title: String!
   createdAt: AWSDateTime!
}

I want to understand if there is anything I can do to prevent the generated schema from making the input type like this:
Generated Schema:
input CreatePostInput {
  id: ID .  <-- it did the right thing by not generating "ID!"  How did it do this?
  title: String!
  createdAt: AWSDateTime!  <-- Doh! How can I avoid the "!" like id field?
}

I want this mutation to work with my schema, and I'd like to know what the recommended approach is.
mutation MyMutation {
   createPost(input:
     {title: "I want to work"}) {
     id
   }
 }

The resolver enforces the default value for "createdAt" with the below generated code.  Another thing I really don't understand, is how it came up with "updatedAt" in addition to "createdAt".  All my schema specified was the "createdAt", but it came up with "updatedAt" all on its own.  More distressing than that even, is "updatedAt" doesn't appear in dynamodb after running "createPost" mutation (successfully).  So what on earth is going on with the "updatedAt" field?
$util.qr($context.args.input.put("createdAt", $util.defaultIfNull($ctx.args.input.createdAt, $util.time.nowISO8601())))
$util.qr($context.args.input.put("updatedAt", $util.defaultIfNull($ctx.args.input.updatedAt, $util.time.nowISO8601())))
$util.qr($context.args.input.put("__typename", "Post"))


Race condition when Reset during Hold

See https://github.com/gnea/grbl/issues/76#issuecomment-269563213 for details

Fixed and verified


Corece Callback is not invoked

Describe the bug
Corece Callback is not invoked
To Reproduce
Steps to reproduce the behavior:

Add following code to AvaloniaObjectTests_Coercion
     [Fact]
     public void Coerce_AttachedProperty()
     {
         var numberOfCall = 0;
         AttachedPropertyOwnerCoerce.CoerceDoubleCallback = (_) => numberOfCall++;
         var class1 = new Class1();

         class1.SetValue(AttachedPropertyOwnerCoerce.DoubleProperty, 101.1d);

         Assert.Equal(1, numberOfCall);
         Assert.Equal(100d, AttachedPropertyOwnerCoerce.GetDouble(class1));
     }

     private class AttachedPropertyOwnerCoerce
     {
         public static readonly AttachedProperty<double> DoubleProperty =
             AvaloniaProperty.RegisterAttached<AttachedPropertyOwnerCoerce, Class1, double>("Double",coerce: CoerceDouble);

         public static Action<AvaloniaObject> CoerceDoubleCallback;

         public static double GetDouble(Class1 control) => control.GetValue(DoubleProperty);
         public static void SetDouble(Class1 control, double value) => control.SetValue(DoubleProperty, value);

         private static double CoerceDouble(AvaloniaObject instance, double value)
         {
             CoerceDoubleCallback?.Invoke(instance);
             var o = (Class1)instance;
             return Math.Clamp(value, 50d, 100d);
         }
     }

Run Coerce_AttachedProperty test

See error

Expected behavior
Corece Callback is  invoked
Screenshots
(none)
Desktop (please complete the following information):

OS: any
Version: 11.0.0-preview7

Additional context
Add any other context about the problem here.
Validate Callback is invoked

AvaloniaProperty.RegisterAttached creates an AttachedProperty object and tells it about TOwner. That's type which is registering the attached property, i.e. AttachedPropertyOwnerCoerce in the sample code above.
But when the value is set, metadata for the target AvaloniaObject is resolved. In this case, the target object is a Class1. Because Class1 is not compatible with AttachedPropertyOwnerCoerce, no metadata is found and the default metadata is used. Due to #10572, this default metadata object no longer includes the coercion method.
Is it correct to create the attached property with TOwner? Giving it THost instead would fix this bug. I'm not sure why the property object would ever need to know about TOwner, which does not have to be an AvaloniaObject and is often static.

AttachedPropertyOwnerCoerce is common scenario and it use to extend the behavior of DependencyObject.
TOwner is where the Set* and Get methods are defined.
What is the advantage of TOwner deriving from AvaloniaObject?

I'm talking above about the internal behaviour of RegisterAttached. There is nothing wrong with the test class you posted.

I'm talking above about the internal behaviour of RegisterAttached. There is nothing wrong with the test class you posted.

sorry, i misunderstanding. Can you give me how to search to try and fix the problem?


Allow custom templates for reports

It would be great if I could pass in a path to an .erb file which would then be used to create the report in stead of the standard file. Or is there a way to customize the output other than forking the gem and changing the templates?

Hi,
We're trying to de-emphasize the report-generation bits of License Finder, as that tends to be the piece that needs the most customization.
Have you tried using the report functionality to emit CSV and use that as a data source for your report templating engine? That's what I'd do; and let us know if there's additional information we can provide in the CSV in order to fill out your report.
Please let us know how you get on!

I ended up forking and changing the template to my needs. Adding another step in between seems overly complicated to me.

@eikes Rather than forking, it's actually pretty easy to write a script that does what license_finder report does, but with a different ERB template.  Use the code in this gist as a starting point.

That's neat. Thank you @mainej

@eikes ... I made a small update so custom ERB reports are easier.  See the revised gist.  You'll have to pin to the master branch on github.


Add SwiftLint to list of users

Also sort the list and apply more consistent style.

@swift-ci Please test


MAPREDUCE-7295 Add support for a read-only history server

2270

 Quality gate: Failed
2 Issues

 1 Vulnerabilities
 1 Code issues

Details


Feature/epmlabsbrn 827 UI add tabs blog

EPMLABSBRN-XX
Description:

add menu 'More...' item with sub-links
contact and info has no dedicated page yet

Hi @marklekin! Thank you for contribution! For future css updates, please refer to https://tailwindcss.com/ as we trying to use it instead of plain css.


Extension fails to run in large workspaces that aren't fully Terraform

Hello, I am seeing the following issue
Could not run the infracost cmd in the /Users/ddulic/Work/work-project-name directory. This is likely because of a syntax error or invalid project. See the Infracost Debug output tab for more information. Go to View > Output & select "Infracost Debug" from the dropdown. If this problem continues please open an issue here: https://github.com/infracost/vscode-infracost.

debug: initializing workspace
debug: running Infracost in project: /Users/ddulic/Work/work-project-name
debug: running Infracost cmd INFRACOST_CLI_PLATFORM=vscode infracost breakdown --path "/Users/ddulic/Work/work-project-name" --format json --log-level info
error: Infracost cmd error trace Error: Command failed: INFRACOST_CLI_PLATFORM=vscode infracost breakdown --path "/Users/ddulic/Work/work-project-name" --format json --log-level info
[91mError:[0m No valid Terraform files found at the given path, try a different directory

Try setting --path to a Terraform plan JSON file. See [4;1mhttps://infracost.io/troubleshoot[0m for how to generate this.

I am assuming that the issue is that I have a large workspace where not all projects are Terraform projects.
This should not prevent the extension from running.
Reinstalling the expansion doesn’t resolve the issue.
I am able to run infracost breakdown --path . directly in the Terraform projects to get the output, but the extension still doesn’t work.
Running infracost breakdown --path . in the top-level folder housing all the projects works as intended and skips the folders that aren’t TF.

hey @ddulic, thanks for raising this issue.
So the extension should be fine running in a workspace where not all projects are Terraform projects. At this point the extension is just a UI wrapper for the binary, so it's a bit weird that you can run infracost breakdown --path . in the /Users/ddulic/Work/work-project-name from your terminal and it be fine. I've got a few follow up questions to hopefully debug what's going on here:

could you run infracost breakdown --path  /Users/ddulic/Work/work-project-name --format json --log-level info where the /Users/ddulic/Work/work-project-name is the real file path show in the Infracost debug log. Does this succeed?
If you answer no to the above could you run infracost breakdown --path  /Users/ddulic/Work/work-project-name --format json --debug-report and upload the infracost-debug-report.json created here.
If yes to point 1 could you try and open one of the valid terraform projects under /Users/ddulic/Work/work-project-name as a VSCode workspace and see if Infracost can work within it?
Could you write a shallow tree output of the /Users/ddulic/Work/work-project-name and post it here? Highlighting which folders are root Terraform projects e.g.:

/Users/ddulic/Work/work-project-name/
    folder/
    myfolder/
    myproject/ # tf project
    infra/
         dev/ #tf project
         prod/ #tf project

Thanks

Thanks for the prompt reply @hugorut!

it's a bit weird that you can run infracost breakdown --path . in the /Users/ddulic/Work/work-project-name from your terminal and it be fine.

Actually, that was just me confirming that I can run infracost directly in Terraform projects, and it works, just to clarify that the CLI tool is working.
When I attempt to run it in the folder that is causing the extension to crash I get the following:
~/Work/work-project-name
❯ infracost breakdown --path .
Error: No valid Terraform files found at the given path, try a different directory

Try setting --path to a Terraform plan JSON file. See https://infracost.io/troubleshoot for how to generate this.

Just wanted to clarify that.

So /Users/ddulic/Work/work-project-name is not a TF Project. Would you still like me to run all the debug steps?

@ddulic does /Users/ddulic/Work/work-project-name have any terraform projects in? If so how many nested folders deep are these? I think the maximum level of folder nesting we check is 5 layers deep.
If these are less than 5 folders deep, yes please I'd love if you could run the debug steps. Thanks


filter_vep_transcript_csqs does not work for passing list of CSQ terms

There is a bug here: https://github.com/broadinstitute/gnomad_methods/blob/019865838f993841a540e0b29d8d2f3b1333b1b8/gnomad/utils/vep.py#L788
The most_severe_consequence field is a top level vep field, at the same level as transcript_consequences, so the way this is currently built does not work as the function looks for most_severe_consequence inside of transcript_consequences here. All other vep fields that get worked on in this function are within transcript_consequences so they work.

I missed that https://github.com/broadinstitute/gnomad_methods/blob/019865838f993841a540e0b29d8d2f3b1333b1b8/gnomad/utils/vep.py#L273 needs to be run first -- should add a note this function wont run without it


Setup the A* Path Planning Algorithm in Gazebo

Feature
Setup the A* Path Planning Algorithm (or others if there is a better one) in Gazebo.
TODO

[ ] 1) figure out the topics that this node subscribes and publishes to
[ ] 2) establish/ensure connection to this node and its subscribed topics
[ ] 3) test using system described in https://github.com/CPFL/Autoware/issues/1110

@sumjos can you please take a look at these items?  Thanks!

Alright. I am going to start on these tasks.

the branch is here


Don't sort env variables

Details
What steps did you take and what happened:
use the app-template with the env vars:
env:
  # -- Config dir
  DATA_FOLDER: "config"
  A_FOLDER: "sometest"

This will lead to a e.g. deployment with:
env:
  - name: A_FOLDER
    value: sometest
  - name: DATA_FOLDER
    value: config

Env var sorting breaks dependent environment variables of kubernetes.
What did you expect to happen:
Don't change the order of env vars.
Anything else you would like to add:
Additional Information:

Thanks for reporting this! I'll be sure to include this in an upcoming version.

I've just completed most of the work on the upcoming version and took another look at this. It looks like it's not something I can easily solve though :(
As soon as the underlying Helm Go code touches the values it automatically sorts the keys and the original order is lost. Because in Go the order of dict keys is considered irrelevant there's no proper (default) way available to keep the ordering.

Hey you guys should checkout this helm issue and this medium article discussed in the helm issue

and this medium article discussed in the helm issue

Holy... that is one gnarly way to solve the issue. My mind is blown.

Yep... that is a huge find, thank you! I will add this to the next version for sure


Content group cards – text should span 90% width

Detailed description

Describe in detail the issue you're having.
The spec states that the text within the cards should only span 90% of the card container width, currently it spans 100% width.
Spec

Current

Is this a feature request (new component, new icon), a bug, or a general
issue?

Is this issue related to a specific component?
ContentGroupCards pattern

What did you expect to happen? What happened instead? What would you like to
see changed?
Update cards so text spans 90% container width instead of 100%

What browser are you working in?
Chrome

What version of the IBM.com Library are you using?
ContentGroupCards

What offering/product do you work on? Any pressing ship or release dates we
should be aware of?
Web simplification

Steps to reproduce the issue

Step one
Step two
Step three
etc.

Additional information

Screenshots or code
Notes

@RaphaelAmadeu Hi Raph, this bug is a low severity, but apparently it is an easy fix.  Can you fix this while you are working on the pattern in this sprint?

@RobertaJHahn Hi Roberta, sure thing, I can fix this in this sprint.


[no OPENSSL_SUPPRESS_DEPRECATED in apps] Remove deprecated calls from apps/dhparam.c

From point 2 of the Technical Items still to be done list:
The apps are the minimum bar to measure feature completeness for the EVP interface: rewrite them so they do not use internal nor deprecated functions (except speed, engine, list, passwd -crypt and the code to handle the -engine CLI option).
That is, remove the suppression of deprecated define.

@mattcaswell: Was this fixed?

Yes.


fix: update gitignore

Updates .gitignore to ignore .nyc_output

This is same as #164, I am happy to close mine and merge this one :)


Add count, remove functionality to systems

This adds a couple flags to systems: --count and --lastCheckinBefore, which will show a plain count of systems filtered, and allow filtering by lastCheckin date, respectively.
It also adds the ability to unregister/remove systems, provided the same filtering abilities as with listing systems.

I totally forgot this exists. Thanks for the updates :smile:

@StephenBrown2 I haven't used this in a long time, would you be interested in adding some tests?  I really should have added them for the start but got busy :( and should have added GHA + goreleaser to make the binaries

Thanks for the merge!
Sadly, I probably don't have time for tests right now, though of course they are often helpful. If I find myself adding more to it, I'll try to add tests at that point.

It does look like GoReleaser failed though... https://github.com/flynshue/rhsm-cli/actions/runs/10475685459/job/29012891297


How to measure and display the metric values for evaluating

Hi,
I would like to retrain the model and am interested in understanding how to measure and display the metric values such as Correlation Coefficient (CC), Structural Similarity Index (SIM), Normalized Scanpath Saliency (NSS), and Kullback-Leibler divergence (KL). Could you please provide a step-by-step guide on how to achieve and show the metrics?
Thank you!

Hi,
Please find the evaluation code in this repo: https://github.com/cvzoya/saliency
Best


List users by organization #455

Purpose
List users only by org.
Ticket
https://github.com/toladata/TolaDataV2/issues/455

Coverage increased (+0.07%) to 50.736% when pulling 5c3f61e5cf866ae02d4d9608df64dba2cf5d67f2 on Menda:455-wflvl2-approval-tab into 387e4bcebe3d627657eecba53f0af1b2181f62e0 on toladata:master.


When all points have the same value, only the dot does not show the lines

When all points have the same value, only the dot does not show the lines，Eagerly looking forward to your reply，Thank You Very Much.

This is a weird bug I just encountered with. When the float value of all the PointValues in a List are the same, the line doesn't show up.

Yes, it is very strange, thank you for your reply, I wish a wonderful day！

I am having the same problem.. Did you come across a solution?

My solution has some limitations，Is such that：

I'm also facing the same issue. Is there any solution?

Look the Picture up！

How i can change this code if i am using library as a dependencies inside gradel.


df: remove trailing spaces in rightmost column

This pull request includes the changes from pull request #3880 and from the (now reverted) pull request #3423. I hope that the changes from the former will prevent the catastrophic failures caused by the latter, and I'm just creating this pull request to see if the build succeeds.
cc @cakebaker

I think this is a success:
Warning: Congrats! The gnu test tests/df/total-verify is no longer failing!


find_node not functional

find_node from GDScript does not seem to work as intended.  The first issue is that the find_node binding seems to include a copy/paste error in node.cpp:1842, binding to get_node instead of find_node.
The second issue is a little harder.  When I debug the engine in gdb while stepping over the find_node call, I can see the recursion search for and find a matching node, and return a pointer to the node.  The pointer seems valid until it is returned and assigned to the Variant type in the language binding, and then I don't know enough to continue following.  However, after the GDScript step-over is complete for the find_node call, the godot debugger shows the return of find_node as 0.
I have created an example project that demonstrates this.  To reproduce:

Set a breakpoint on the GDscript find_node call, test.gd:9.  Run the project.
Attach GDB to the child process.
Set a breakpoint on Node::find_node and continue GDB.
Press step-over in the godot debugger.
Once the GDB breakpoint is hit, step though the until the first recursion returns the matching node, to see that it is found.
Continue GDB so that the Godot debugger step can continue.
Examine the returned value in the editor; it is zero.

http://fazjaxton.net/files/test3.zip

Fixed by 1630f0a.


(400) Bad Request when inserting a point with an integer field or a string field

I have this error when I try to insert a point containing an integer field or a string field.
auto db = influxdb::InfluxDBFactory::Get("http://<IP_ADDRESS>:8086?db=MY_TEST_DB");
db->createDatabaseIfNotExists();
db->write(influxdb::Point{"cpu"}.addField("value", 5));
// db->write(influxdb::Point{"cpu"}.addField("value", "5")); // <-- or with a string

terminate called after throwing an instance of 'influxdb::InfluxDBException'
  what():  Request failed: (400) Bad Request
Aborted (core dumped)

I don't know what's causing it, all I can say is that I can correctly fetch data or insert double values in the database.
I'm using :

influxdb-cxx 0.7.1
cpr 1.10.4
influxdb 1.8.10
gcc/g++ 11.4.0
cmake 3.22.1
in a Kubuntu 22.04.3 Virutal Machine

Thanks in advance for your help.

Oof, just read this https://github.com/offa/influxdb-cxx/issues/161#issuecomment-1407473549, and now it works fine...
I guess next time I'll read all the issues before posting one :')
Is there an explanation of why a new database is needed? I don't want to run into this bug again in production.

Is there an explanation of why a new database is needed? I don't want to run into this bug again in production.

The problem back then wasn't related to a new database but using different types on the same measurement (if I remember correctly).

Oh yes! I did that without realising it.
Perhaps it would be a good idea to improve the exceptions to make them more explicit?

Exception code and message are provided by CPR and thrown as a new type. It would be possible to get some additional information from the response which would look like this:

{"error":"partial write: field type
conflict: input field "value" on measurement "x" is type string, already
exists as type integer dropped=1"}

It might be  somewhat verbose, but would help to identify the underlying issue :+1:.


Remove Oliver Ferrigni

Unfortunately, I don't have the bandwidth to honor this commitment. Grateful for the time I was associated with this project.

Feel free to redo from a DCO signed-off committer.

❤ ❤ ❤ Thanks for all of your contributions to Chef!

👎 You can never truly leave!

 <3

This was done in d56b86d0d91dba13caa66778d43787e6d9ffeb85.


more 6.9 support

every PySide import fixed
i'm not sure, but i think that aliases like QtCore.Slot = QtCore.pyqtSlot should be located in cute.py

@hardboost I added the QtCore.Slot = QtCore.pyqtSlot alias to Cute. Let me know if this does the trick for you - https://github.com/tmr232/Cute/blob/pyside-extra/cute.py#L53
I think I'll wait with a new version of cute until the migration of DIE is done, though.

@tmr232 i'm already know that this trick works. i meant that compatible aliases from my commits https://github.com/hardboost/DIE/blob/c49abf94505d551d0fcf75b58857bb8a0b06f358/DIE/UI/ValueViewEx.py#L5-L11 should be resolved by cute.py, but i'm not sure about it.


screenToGeo()

Is there a plan to implement screenToGeo()?
Or is there a workaround for using it?

Can you send a PR implementing this method?


Set KES for TPraosStandardCrypto to be SimpleKES Ed25519DSIGN 14

This will be replaced with the SumNKES soonish, but in the meantime we
need a KES for the testnet that does not have enormous keys or
signatures. We also actively want a short KES period for the testnet to
get people used to the idea of cycling their hot keys.

bors r+

bors r+


Needs a License.

Might I recommend MIT?

doh! I missed https://github.com/svpernova09/meatings/blob/master/license.md.  Is that for the whole project?


Change InputFile map in SimulationInputs to attributes

Get rid of get_inputs() and list_inputs() methods. Remove dictionary storing objects. Add attributes that store the objects.

No worries! Thanks for taking it on and let me know if you have any questions.


INT_InteractionProcessor_TEST : testBulkInteractionInsert Failure

Greetings,
While running test classes in my developer org, I ran across some errors in the EASY test class suite related to running SELECT SQL queries in for loops, which generated the following error:

I took the time to fix some of the errors, but these coding examples that are cocontrary to Apex best practices may need to be addressed throughout the EASY code-base.

I've attached the corrected Apex classes related to failed test:
INT_InteractionProcessor_TEST.txt
INT_InteractionMappingService.txt
INT_InteractionProcessor.txt

@softwareangel This is actually part of the codebase from the Interactions for Student Recruitment project. Can you submit this as an issue on their Github? I can update it in EASY once they make changes. Just trying to keep things in-sync.

Oh Wow.  I understand the need to keep everything organized.  I will
re-submit to them.
That sheds light on another suggestion: most unmanaged sources prefix
objects, classes and triggers with a notation as identitfiers. I would
suggest EASY_ and ISR (I assume they use an INT_ prefix).
Thanks.
On Tue, Dec 18, 2018, 9:07 PM Kyle Schmid<EMAIL_ADDRESS>wrote:

@softwareangel https://github.com/softwareangel This is actually part
of the codebase from the Interactions for Student Recruitment
https://github.com/SFDO-Community/Interactions-for-Student-Recruitment
project. Can you submit this as an issue on their Github? I can update it
in EASY once they make changes. Just trying to keep things in-sync.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/SalesforceFoundation/EASY-Open-Source-Solution/issues/7#issuecomment-448443149,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ArW6Om2lxSbYjqtw-hBQaY-yprhfZNN1ks5u6Z9PgaJpZM4ZVCpS
.

Sounds good. And yes, I agree on the prefixes. We should have done that from the beginning but it was an afterthought. Don't want to break existing implementations at this point, however.

This issue can be closed.
(1) I fixed the INT_InteractionProcessor_TEST errors.
(2) In my tailored version of EASY, the unmanaged sources, objects, classes and triggers were prefixed with a notations EASY_ and ISR (with the INT_ prefix).


Loop editing

Add new loops by double-clicking
Resize loops by dragging
Change loop iteration count (click to select the loop & then edit in the bottom panel?)

Basic add new loop button implementation in #61


Update referenced Kafka topic names to lower-case

Migrate all Kafka topic name references to lower-case, instead of camelCase.
This includes orderCommands at a minimum for the kc-order-ms components.
Other topics may be referenced directly in scripts and should be verified to be hyphenated lower-case and not camelCase.

PR submitted for review by @jbcodeforce and @jesusmah
Incidental code changes pushed to refarch-kc and refarch-reefer-ml as well.


impl Clone for RawIntoIter, and add table access methods

This adds the ability to find and erase elements in a RawTable while
it is being consumed using RawIntoIter. This may be useful in contexts
where a RawTable is being destructed bit-by-bit, interleaved by user
operations.
Specifically, this is (I think) what I'd need for
https://github.com/jonhoo/griddle/issues/1 and
https://github.com/jonhoo/griddle/issues/2.
Please do double-check my implementation here, as I am not
completely sure I got the corner cases right.

I also wonder if it should be possible to Clone the remaining elements out of the RawIntoIter. Not entirely sure how to accomplish that though.

Actually, never mind Clone. It can be done using into_iter.iter().cloned().collect().

I added a Clone impl, though it definitely needs to be looked over.
I think one remaining challenge is how to construct a rayon parallel iterator from a RawIntoIter (since we don't have a RawTable to give it). That can probably be punted for now though.

A fun side-effect here is that this enables hash_map::IntoIter to be Clone if we wish it to be :)

The test failures seem to be failure to pull some Docker image due to rate limiting?

I can't help but feel that this is the wrong approach to take. I think that rather than adding more features to RawIntoIter, you should instead be using RawIter directly.

That was my original instinct too, but there are so many invariants to uphold that it didn't feel feasible to present a more general API without exposing a lot of internal state. I'll do some more thinking tomorrow to see if I can come up with something better though.
I think there are two main "parts" to this:
First is to give users of the raw APIs the ability to mutate a RawTable while iterating over it. The user can always re-start the iterator, but if the way they mutate is, say, consume every element the iterator yields, then re-starting is very expensive; it needs to search for the first non-empty bucket, which is closer and closer to the end. Unfortunately, implementing a general-purpose RawIter::refresh efficiently is difficult for two reasons:

You don't know whether items should change — it should change only if there's an insert/remove after the position of the iterator, but not before.
When reloading the current group, you can't distinguish between an insertion in the same group prior to the current iteration point (which should not be yielded by the iterator), and an insertion in the same group after the current iteration point (which should be yielded). This is because the iterator (currently) doesn't keep any state beyond the cached bitmask, and it only knows that the leftmost non-yielded 1 is the next item it was going to yield.

Thinking about it some more, I think maybe these could both be solved by having such a hypothetical RawIter::refresh take a &Bucket representing "the change to update the iterator to reflect". Using that, the iterator can check how that bucket changed by checking its current state (and assume it was toggled), and it can in turn use that to patch the current group state appropriately.
The second challenge is to find a way to enable users to efficiently "resume" an iterator after a RawTable is cloned. This requires rewiring a bunch of internal iterator state, and is what most of the code in the RawIntoIter::clone impl is doing. I suppose we could instead expose that through a RawIter::resume_in(&mut self, &RawTable), though it would be super unsafe (but maybe that's okay).
I think with those two added methods, I might be able to do what I need. It won't be quite as efficient as what's in this PR at the moment, but it might be workable. So, how would you feel about a PR that added the following:
impl RawIter {
  /// Refresh the iterator such that an insert or removal for the given bucket is reflected.
  ///
  /// If the bucket was inserted into, the iterator _may_ yield the given bucket next
  /// even if it already yielded a bucket with a lower index.
  ///
  /// This method must be called after one such modification is made.
  /// Calling this method after inserting *and* removing from the bucket,
  //// in either order, may corrupt the iterator state.
  pub unsafe fn refresh_reflect(&mut self, b: &Bucket);

  /// Resume this iterator in the same location in another table.
  ///
  /// The given table must have the same layout as the iterator's previous table.
  pub unsafe fn resume_in(&mut self, table: &RawTable);
}

I'll try to hack that together tomorrow and see if that's sufficient for what I need in griddle.

I'm curious about the reasons why you would need this functionality.

Why are you inserting elements into the table while iterating through it?
Why do you need to resume an iterator after a table is cloned? In griddle you could just "flush" the second table on clone and reset the iterator.

Why are you inserting elements into the table while iterating through it?

I'm not, but I am removing from the table while iterating over it. This is why I only implemented erase/remove for RawIntoIter in this PR — it's much simpler to handle just removals. The reason I have to be able to do removals is in case someone removes a key from the map which has not yet been moved from the old table to the new one. It needs to be removed from the old table, and the iterator I'm keeping over that old table also needs to be updated to reflect that removal.
If we only want to support refreshing for removals, then we could just have a RawIter::refresh_removal(&Bucket). It would still need to take a &Bucket though to determine whether the items count should change.

Why do you need to resume an iterator after a table is cloned? In griddle you could just "flush" the second table on clone and reset the iterator.

I suppose that's true. My thinking here was that a Clone should not require that you also finish the resize, but maybe you're right that that's silly. If someone clones the map, then they'll have to walk the map to clone its elements anyway (well, modulo Copy), so perhaps collapsing the second table into the first isn't such a bad incremental cost.
One unfortunate aspect of this is that Clone takes &self, so I would only be able to do the collapse in the newly created map, but not in the original map. So the "flush" still has to happen twice. But that's no worse than what happens with this PR.

Closing in favor of #175.


Script Error

Hello,
I am using Scribus 1.5.5 on a Windows 10 laptop and received this error when I tried the "Next_Record.sla" file that came with the download (it's in the "Example" folder):

Traceback (most recent call last):
File "", line 10, in
File "C:\Program Files\Scribus 1.5.5\share\scripts\ScribusGenerator.py", line 401, in
main_wrapper(sys.argv)
File "C:\Program Files\Scribus 1.5.5\share\scripts\ScribusGenerator.py", line 388, in main_wrapper
main(argv)
File "C:\Program Files\Scribus 1.5.5\share\scripts\ScribusGenerator.py", line 379, in main
root.mainloop()
File "C:\Program Files\Scribus 1.5.5\python\lib\lib-tk\Tkinter.py", line 1129, in mainloop
self.tk.mainloop(n)
File "C:\Program Files\Scribus 1.5.5\python\lib\lib-tk\Tkinter.py", line 1545, in call
self.widget._report_exception()
File "C:\Program Files\Scribus 1.5.5\python\lib\lib-tk\Tkinter.py", line 1297, in _report_exception
root.report_callback_exception(exc, val, tb)
File "C:\Program Files\Scribus 1.5.5\python\lib\lib-tk\Tkinter.py", line 1900, in report_callback_exception
traceback.print_exception(exc, val, tb)
File "C:\Program Files\Scribus 1.5.5\python\lib\traceback.py", line 125, in print_exception
print_tb(tb, limit, file)
File "C:\Program Files\Scribus 1.5.5\python\lib\traceback.py", line 67, in print_tb
'  File "%s", line %d, in %s' % (filename, lineno, name))
File "C:\Program Files\Scribus 1.5.5\python\lib\traceback.py", line 13, in _print
file.write(str+terminator)
IOError: [Errno 9] Bad file descriptor

Hello.
The error text (IOError: [Errno 9] Bad file descriptor) looks to me like the script cannot write something to some file.
The only file it should be trying to write something to at that stage is the log file, which should be C:/users/yourself/.scribusGenerator.log. So I guess the location of this log file is actually wrong or pointing to a directory that is not accessible.
Could you please redownload ScribusGenerator to another directory where you're sure your user has write access? Like in your Documents folder, and run it from there.
If that works it should point that the issue lies in the location of the log file being wrong for Win10.
In that case please edit the file C:\Program Files\Scribus 1.5.5\share\scripts\logging.conf, on line 22 and change '~/.scribusGenerator.log' to 'c:\temp\scribusGenerator.log', and try again running the script like you did on the first time (the one leading to the error).
If that does not solve the issue please copy paste the content of your C:/users/yourself/.scribusGenerator.log file here, it should help finding the issues.
Thanks.

any improvement ?

Hi Berteh,
Executing the script from my "Downloads folder" worked. When I tried
executing it from the Scribus share\scripts folder, it wouldn't do
anything. I couldn't find the logging.conf file to edit, but I suppose that's
not an issue if the script can be executed (as long as it's from another
location).
Thank you!
On Fri, 19 Jun 2020 at 18:18, Berteh<EMAIL_ADDRESS>wrote:

any improvement ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/berteh/ScribusGenerator/issues/156#issuecomment-646879303,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANHHWNEMFOEX64NSMQUAL5LRXPP2ZANCNFSM4NPAHPUA
.

Thanks for the report.
I tried to explain the location problem better in the documentation; kindly have a look and propose a better wording if you have suggestions.
The Next_Record.sla is meant to use the examples/Business_Card.csv data file... but any other would do too.

I am having the same problem. here is the error I get. I have the script in my download folder on windows. Can you help?
Traceback (most recent call last):
File "", line 11, in
File "", line 21, in
ModuleNotFoundError: No module named 'Tkinter'

@egdedudette Which version of Scribus are you using?


[Renderers/HTML] Text wrapping causes cascade of auto generated ID changes

Trying text selection in https://www.nicbarker.com/clay . especially in "Renderer & Platform Agnostic" & "Integrated Debug tool" section.
https://github.com/user-attachments/assets/76fdb069-b91e-4a4f-809b-df1a5bee59f4

I just checked and discovered that the issue is due to the following element in the High Performance section.
It's rapidly updating the DOM, which causes elements to shift, leading to the text selection problem.

I'll look into issue more to fix it. could you assign me this.

Thanks for reporting! I already have a solution for this one that just needs to be built 🙂

@nicbarker does canvas renderer support text selection too?

@anggaaryas Not at present no, text selection needs to be implemented from scratch 🙂

@nicbarker Any chance you could mention some of the details about how you'll fix this? Just curious from the standpoint of that I haven't actively given any thought to it myself. Thanks for the awesome library!

@campbell-reid-displayr Of course 🙂
In summary, every element in a clay UI hierarchy has a unique ID. These IDs are either generated from string hashes by using CLAY_ID(), or automatically generated based on the parent ID and child index if no ID is provided.
This works great for mapping onto HTML, because we can create a unique HTML element corresponding to each unique clay ID, and only update the HTML element if the corresponding clay element changes.
When clay wraps text onto new lines, it does so by generating multiple render commands, each rendering one line of text.

@nicbarker Thanks for the summary. I look forward to seeing the changes! On another note, I've been studying the Odin bindings a bit, and I've never written a binding for another language before; I'm thinking I may look into the feasibility of writing a C# binding.


HBASE-23680 RegionProcedureStore missing cleaning of hfile archive

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  8s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
6m  2s
master passed

+1 :green_heart:
compile
0m 59s
master passed

+1 :green_heart:
checkstyle
1m 30s
master passed

+1 :green_heart:
shadedjars
5m  0s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 39s
master passed

+0 :ok:
spotbugs
4m 56s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 54s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 31s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

-1 :x:
checkstyle
1m 28s
hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
5m  4s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
21m 15s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 44s
the patch passed

+1 :green_heart:
findbugs
5m 19s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
162m 28s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 27s
The patch does not generate ASF License warnings.

232m  6s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1022

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 5005aba1ecec 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1022/out/precommit/personality/provided.sh

git revision
master / 2e0edacf72

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/1/artifact/out/diff-checkstyle-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/1/testReport/

Max. process+thread count
5234 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  6s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  1s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 55s
master passed

+1 :green_heart:
compile
0m 57s
master passed

+1 :green_heart:
checkstyle
1m 29s
master passed

+1 :green_heart:
shadedjars
5m  4s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
master passed

+0 :ok:
spotbugs
4m 58s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 57s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 30s
the patch passed

+1 :green_heart:
compile
1m  0s
the patch passed

+1 :green_heart:
javac
1m  0s
the patch passed

+1 :green_heart:
checkstyle
1m 30s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
5m 47s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
22m 16s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 42s
the patch passed

+1 :green_heart:
findbugs
5m 44s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
160m 45s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

232m  7s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1022

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux eac4126ecc34 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1022/out/precommit/personality/provided.sh

git revision
master / 79e799ab7b

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/2/testReport/

Max. process+thread count
4961 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/2/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Add a TTL config for deleting the archived HFiles.
On why we put all things on the WAL filesystem, partly because that I want to put all the data under a single directory, which can hide the internal implementation details about procedure store, and easy to replace the old implementation with another implementation.
And another thing is about performance. The WAL filesystem is HDFS, and the HFile storage, if not the same one, is usually S3 or some other object storages, which are very slow, usually. And usually the size of the procedure store will be small, I think the cost is also fine.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 10s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 55s
master passed

+1 :green_heart:
compile
0m 59s
master passed

+1 :green_heart:
checkstyle
1m 32s
master passed

+1 :green_heart:
shadedjars
5m  2s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
master passed

+0 :ok:
spotbugs
4m 59s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 58s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 31s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

-1 :x:
checkstyle
1m 31s
hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-1 :x:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

+1 :green_heart:
shadedjars
5m  1s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m 41s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 36s
the patch passed

+1 :green_heart:
findbugs
5m  5s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
166m 32s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 27s
The patch does not generate ASF License warnings.

230m 24s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1022

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux baf803cc327b 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1022/out/precommit/personality/provided.sh

git revision
master / 4ad12e03b8

Default Java
1.8.0_181

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/3/artifact/out/diff-checkstyle-hbase-server.txt

whitespace
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/3/artifact/out/whitespace-eol.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/3/testReport/

Max. process+thread count
4967 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/3/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  4s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 56s
master passed

+1 :green_heart:
compile
0m 59s
master passed

+1 :green_heart:
checkstyle
1m 31s
master passed

+1 :green_heart:
shadedjars
5m  1s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
master passed

+0 :ok:
spotbugs
4m 49s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
4m 47s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 37s
the patch passed

+1 :green_heart:
compile
0m 57s
the patch passed

+1 :green_heart:
javac
0m 57s
the patch passed

+1 :green_heart:
checkstyle
1m 28s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
4m 59s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
17m  6s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1 :green_heart:
javadoc
0m 35s
the patch passed

+1 :green_heart:
findbugs
5m  2s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
154m 48s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 26s
The patch does not generate ASF License warnings.

217m 44s

Subsystem
Report/Notes

Docker
Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1022

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux d13a4b4c0e5b 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1022/out/precommit/personality/provided.sh

git revision
master / 4ad12e03b8

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/4/testReport/

Max. process+thread count
4915 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1022/4/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Ping @saintstack

On why we put all things on the WAL filesystem, partly because that I want to put all the data under a single directory, which can hide the internal implementation details about procedure store, and easy to replace the old implementation with another implementation.
And another thing is about performance. The WAL filesystem is HDFS, and the HFile storage, if not the same one, is usually S3 or some other object storages, which are very slow, usually. And usually the size of the procedure store will be small, I think the cost is also fine.

I like that this goes on the WAL filesystem and I think the justification is good. I went to check the docs to make sure the reasoning is spelled out as well there. Looks like the ref guide does not have details about the new procedure store and still has a bunch of stuff about the old one. Is there a JIRA I can watch to review when those docs are up?


[potential issue] several alerts displaying problem

When a new alert must be presented as a result of selecting any action button on a previous one, it becomes impossible because action handler executes before AlertViewController is dismissed.
Warning: Attempt to present <UIAlertController: 0x7fb07a1bba00>  on <...IssueDetailViewController: 0x7fb07a883400> which is already presenting (null)
If action.handler was executed in AlertViewController.completionHandler that would solve the issue. Not sure if this sequence of action.handler execution will fit all the cases to update current logic with this one

Actually, as far as I remember, the similar issue occurred with native UIAlertController too.
I think it can be fixed by dismissing alert manually instead of automatic dismiss. I will try to push updates in the near few days. Btw, if you have any proposal feel free to open pull request :)

@piechart Version 1.1.0 released. It contains fix for this issue.

@piechart Please take a look at this paragraph in readme file https://github.com/AntonPoltoratskyi/NativeUI#edge-cases


Fix incorrect segment position after manifest update

I observed quite a lot of assertion failure Assertion failed: SegmentReferences are incorrect for a multiple period DASH, and encountered some rare player stuck.
Before the stuck happen, there was console log that suggest the stuck is due to not being able to find segment from position number:
segment doest not exist: currentPeriod.startTime=1216.3484667 position=5
I found that the issue was caused by incorrect position number of segment references after segment merge on manifest update.
When the segment reference from the newer manifest get merged, the position number is left untouched. However, it may have changed due to removal of previous segments from the period. Please see the attached diagram, the segment number changed from 5 to 1 after manifest update. Consequently, any attempt to locate the next segment by position would fail.

After patching the player with corrected position number, the assert failures no longer occur.
The segments in my manifest are not aligning close to the period boundaries, so may be a corner case that other users may not see the same issue.
Please check my code diff, thanks.

I signed it!

Can you please provide an example manifest that reproduces your issue?  We calculate the position based on the segment numbers in the manifest, which should not change.  When there is a manifest update, the same segments should have the same segment number and media times.  If you are removing segments, then you should update attributes like startNumber so we calculate the correct segment number.
If this is a bug on our part, then it will mess with other parts, like calculation of SegmentTemplate when using $Number$, so this would not be the preferred fix.

@albertcsm Can you provide an example manifest?  Otherwise we are going to close the PR.

OK, I will provide two versions of the manifest that has segments removed for retention

I wasn't able to reproduce the issue at this moment, actually it is not easy to hit the issue.
Anyway, I attached the sample manifests from my encoder. The two manifests are consecutive snapshot of the manifest, with 4 seconds between them. Some segments from period 17 were removed in the second manifest.
manifest-5159.txt
manifest-5202.txt

Your content is bad.  The reason you are not seeing more problems is because you use $Time$ in the URL template; if you used $Number$, more problems would appear.
The encoder is removing segments from the list without updating the startNumber attribute.  This means that the segment numbers of the segments in the update don't match their segment numbers in the original.  Your encoder should be setting the startNumber attribute so we can calculate the segment number correctly.
For example, in the audio stream, the first segment initially starts at<PHONE_NUMBER>.  Since there is no startNumber, it has a segment number of 1.  Then the next segment starts at<PHONE_NUMBER> and has a segment number of 2.  Then in the next update, the first segment listed starts at<PHONE_NUMBER>, so it has a segment number of 1.  A segment must have the same segment number for the whole presentation.

@TheModMaker I am not sure if startNumber is really required for $Time$ based mpd. I see that another sample asset in Shaka (Wowza / Big Buck Bunny (Live)) also removes segments from MPD in the same way, and there is also no startNumber.
big-buck-bunny-1.txt
big-buck-bunny-2.txt

I have added a unit test, please check, thanks.

@TheModMaker Oh yes, thanks for pointing out, I was making the change over a mounted folder on a Windows desktop... I have fixed it and added the PR link.

I'm running tests right now.  Assuming they pass, we'll wait for final approval from @TheModMaker.  Thanks!

The fix has been cherry-picked for v2.1.6.


[Removal]: please help me out of Denylist

Hotspot Name
Blunt Plastic Swift
Hotspot b58 Address
11B4yWYHVpAqq45pjgmWL8Nx8jsw37uAJHmHqxH2AuRkyK9Nvvs
Discord Handle
No response
Hotspot Manufacturer
PantherX
Removal Reason
I bought a used Denylist hotspot
Modifications
Yes
Extra forwarders
No
Extra antennas
No
Additional Information
I bought a used Denylist hotspot
it has been redeployed
Had to use a VPN service in my country

see comments in #1147

We have taken into account this removal request in the next iteration of the denylist. It may take some time before it's processed. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.


chore(ci): Disable Redis e2e until we drop Python 3.7

Issue number: #3651
Summary
Changes
Disabling Redis e2e tests.
User experience

Please share what the user experience looks like before and after this change

Checklist
If your change doesn't seem to apply, please leave them unchecked.

[x] Meet tenets criteria
[x] I have performed a self-review of this change
[ ] Changes have been tested
[ ] Changes are documented
[ ] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3c63c24) 95.56% compared to head (916ccb0) 95.52%.
 Consider uploading reports for the commit 9d6edb6 to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3652      +/-   ##
===========================================
- Coverage    95.56%   95.52%   -0.05%
===========================================
  Files          213      213
  Lines         9961     9961
  Branches      1824      850     -974
===========================================
- Hits          9519     9515       -4
- Misses         329      331       +2
- Partials       113      115       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Alpha release

Reduced phalcon syntax errors from 30 to 16
Fixed completion bug when invoking AC in method definition block

@AsterAI Could you take a look

@sergeyklay  done

Thank you


low recall accuracy

test_nsg_optimized_search_recall.cpp.tar.gz
I'm trying to reproduce your benchmark on sift1M dataset. I adjusted the parameters of kNN graph and search. However I failed to improve the recall accuracy to 0.993。
[root@cdsl-gpu-a07 tests]# ./test_nndescent ../../sift/sift_base.fvecs sift.50NN.graph 50 70 10 10 100
data dimension: 128
recall : 0.0003
iter: 0
recall : 0.002
iter: 1
recall : 0.0221
iter: 2
recall : 0.1011
iter: 3
recall : 0.2899
iter: 4
recall : 0.511
iter: 5
recall : 0.6378
iter: 6
recall : 0.6833
iter: 7
recall : 0.6955
iter: 8
recall : 0.6987
iter: 9
1000000
Time cost: 40.4963
[root@cdsl-gpu-a07 tests]# ./test_nsg_index ../../sift/sift_base.fvecs ../../efanna_graph/tests/sift.50NN.graph 256 100 sift.50NN.nsg
100:34:2:0
indexing time: 102.874
[root@cdsl-gpu-a07 tests]# ./test_nsg_optimized_search_recall ../../sift/sift_base.fvecs ../../sift/sift_query.fvecs sift.50NN.nsg 100 1 ../../sift/sift_groundtruth.ivecs
34
search time: 9.37674
Compute recalls
R@1 = 0.9906
R@10 = 0.9906
R@100 = 0.9906
The attached is code of test_nsg_optimized_search_recall, which's based on test_nsg_optimized_search.cpp and (faiss repo) demo_sift1M.cpp.
As a reference, the nmslib HNSW sample code gived recall accuracy 0.999 on sift1M with 500 queries.
What I need is exact 1NN search on big dataset. And it's fine to comprise on R@1 and performance a bit.
Could you help me?
Thanks!

I cannot reproduce your results. It seems normal here on my computer.
I tried the 50nn graph as you do, below are the results.
./tests/test_nndescent ../sift/sift_base.fvecs ../sift/sift_50.nndgraph 50 70 10 10 100
./tests/test_nsg_index ../sift/sift_base.fvecs ../sift/sift_50.nndgraph 300 50 ../sift/sift_50.nsg
./tests/test_nsg_optimized_search ../sift/sift_base.fvecs ../sift/sift_query.fvecs ../sift/sift_50.nsg 100 1 ../sift/sift.1nn
search time: 3.23324
R@1:
./validate_K sift/sift.1nn sift/sift_groundtruth.ivecs 1
res dim : 1 gt dim : 100
0.9905
R@10:
./validate_K sift/sift.1nn sift/sift_groundtruth.ivecs 10
res dim : 1 gt dim : 100
1.00
R@100:
/validate_K sift/sift.1nn sift/sift_groundtruth.ivecs 100
res dim : 1 gt dim : 100
1.00
more detailed report and our evaluation code have been sent to your email.
you may try the same 10,000 queries of SIFT1M dataset on HNSW rather than 500 for comparison.
Because we don't know which 500 queries you were using.

L=1000
./tests/test_nsg_optimized_search ../sift/sift_base.fvecs ../sift/sift_query.fvecs ../sift/sift_50.nsg 1000 1 ../sift/sift.1nn
search time: 25.4909
R@1:
./validate_K sift/sift.1nn sift/sift_groundtruth.ivecs 1
res dim : 1 gt dim : 100
0.9944
R@10:
./validate_K sift/sift.1nn sift/sift_groundtruth.ivecs 10
res dim : 1 gt dim : 100
1.00
R@100:
/validate_K sift/sift.1nn sift/sift_groundtruth.ivecs 100
res dim : 1 gt dim : 100
1.00


Spiky Bracers - Using the relic and then updating the card, in some cases, does not reduces the cost further

This happen because some cards are simply not upgraded with a cost-reduction. They are upgraded with a new absolute cost.


nameList should be valuesList and entriesList in Object.values and Object.entries, respectively

The spec draft currently uses nameList in step 3 of Object.values and Object.entries. That should probably be changed to match the contents.

Oops, thanks, fixing now.


Cannot show image

When I try demo "SliderTests" in my ios react native project, the slider shows no image.

Try replacing http:// with https://

Add require.
Example:  <ImageSlider images={[ require(' URL IMAGE ')}]
:)


fix auth0 undefined issue

auth0 object was being shown undefined in app.js as it was looking for auth0.js in node_modules/auth0/build in web/index.js.  node_modules/auth0/dist fixes this.

Thanks @faisal-nstu , this change was already present in the v2.0 branch which I just merged. The PR should show as conflicting but GH must have it cached or something.


disableUnderline is not working in TextField (multiline)

Expected Behavior
disable underline in textarea when apply disableUnderline={true} in TextField (multiline)
Current Behavior
underline still visible when apply disableUnderline={true} in TextField (multiline)
Version: 1.0.0-beta.23

The TextField component does not have a disableUnderline property.  The Input component, which is wrapped by TextField, does.  You need to pass disableUnderline to Input via InputProps.  Please see this codesandbox for a working example.
This is not an issue with material-ui.  Please reserve the submission of an issue for situations where you've searched the issues on GitHub and reviewed the documentation for the component in question.  In the future, if you're not sure about some functionality or you're stuck, please post such questions on StackOverflow.


[Feature Request] Add role name to the structure log default fields

Add role to the structure log default fields. So that it's easier to distinguish fullnode and validator

This is something that we could probably implement using a similar mechanism as tracings spans.