Fix "New message" button shows when resolving an actionable mention whisper

Details

Resolving an actionable mention whisper causes the "New message" button to shows up.
Fixed Issues

$ https://github.com/Expensify/App/issues/49824
PROPOSAL: https://github.com/Expensify/App/issues/49824#issuecomment-2378602701
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Open a room or create a new one with at least 25 messages
Mention a user that is not in the room
After receiving the concierge whisper, close (switch) and reopen the room
Press "Do nothing" on the whisper
Verify there is no floating "New message" button shows

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/b9217ef4-1667-445a-b703-3bd1db1cf386

Android: mWeb Chrome

iOS: Native

https://github.com/user-attachments/assets/06c2dde7-5088-4fcb-a140-a2d873508d2c

iOS: mWeb Safari

https://github.com/user-attachments/assets/035cdd09-f63c-4d69-9072-328b8e0bcee1

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/b2401e4d-e8a2-407d-8f83-aff9c66d8fb9

MacOS: Desktop

https://github.com/user-attachments/assets/96254b2f-063b-441a-8438-760ff8aa23d7

Can't send message on android mweb.
https://github.com/user-attachments/assets/952553dd-25be-4b94-bb9f-5ee5c02a3eda

I'm able to repro it by simply reopening the report. Here is what happens:

Send a user mention that is not part of the room
A whisper shows as the last action, but the report lastVisibleActionCreated is not updated (BE issue)
Close and reopen the report, the updated report lastVisibleActionCreated is received from OpenReport
Resolve the whisper, we optimistically update the lastVisibleActionCreated to the previous action, that is the user mention, but the last action is still the whisper, which what we are fixing here.
Close and reopen the report, OpenReport sends the resolved whisper created as the report lastVisibleActionCreated.

Since we don't include the whisper as the last action anymore, the new message shows.
I think BE shouldn't send the resolved whisper created as the report lastVisibleActionCreated.

However, if that's the expected behavior, then we shouldn't optimistically update the lastVisibleActionCreated to the previous action when resolving whisper (step 4).

I'm able to repro it by simply reopening the report. Here is what happens:

Send a user mention that is not part of the room
A whisper shows as the last action, but the report lastVisibleActionCreated is not updated (BE issue)
Close and reopen the report, the updated report lastVisibleActionCreated is received from OpenReport
Resolve the whisper, we optimistically update the lastVisibleActionCreated to the previous action, that is the user mention, but the last action is still the whisper, which what we are fixing here.
Close and reopen the report, OpenReport sends the resolved whisper created as the report lastVisibleActionCreated.

I'm not able to reproduce this locally, can we try again?

Still happens for me.
https://github.com/user-attachments/assets/e3abefd3-fa7b-42fe-9562-7ae024895777
The new message doesn't show because the room has less than 25 messages. I forgot to add more messages before recording.
https://github.com/Expensify/App/blob/66cf824036a51183d73dab2cc621901e43fe3196/src/pages/home/report/ReportActionsList.tsx#L637
Here is the video with the new message shows.
https://github.com/user-attachments/assets/ae42b585-3114-4ee4-b656-bf0dea66fd92

@youssef-lr just in case you missed the above comment ☝

It's still reproducible. Here is the thread.

hi @paultsimura! The backend changes do NOT currently cover this case - I only updated the behavior when receiving the whisper, not when resolving it. I can look into that too, but I wasn't aware of it at the time

Checking

A whisper shows as the last action, but the report lastVisibleActionCreated is not updated (BE issue)

This is resolved

Close and reopen the report, OpenReport sends the resolved whisper created as the report lastVisibleActionCreated.

This is not.


function error not propagated to debug when executed in subflow

I have a function node with the following code:
msg.topic = "abc." +
    msg.get("xyz") + "." +
    msg.payload;
return msg;

That code contains an error since i changed flow.get("xyz") to msg.get("xyz"), which is wrong.
(function : (error) "TypeError: msg.get is not a function")
However, when this function node is executed as part of a subflow, i don't get an error in the debug panel, while i get the error in the debug panel, when the function node is executed directly in a flow.

Hi - there was a template you were shown when raising the issue, it would help if you could fill that out. Specifically, information about the environment you're running in:
### What are the steps to reproduce?

### What happens?

### What do you expect to happen?

### Please tell us about your environment:

- [ ] Node-RED version:
- [ ] node.js version:
- [ ] npm version:
- [ ] Platform/OS:
- [ ] Browser:

With 0.19, I have put that code in a Function inside a Subflow and when it is triggered I get the error in the debug sidebar - so based on what you've described, I cannot reproduce it.
Do you have any Catch nodes on the same tab is your Subflow instance node? If there is, that node will be catching the error which stops it from being otherwise logged.

What are the steps to reproduce?
flow follows at the end of this post
What happens?
described above
Besides that: Node-Red is awesome! BIG THANKS!
What do you expect to happen?
same behavior, either by directly placing the 2 nodes (function + read) or by using the subflow
Please tell us about your environment:

[] Node-RED version: 0.19
[ ] node.js version: 8.11.3
[ ] npm version:
[ ] Platform/OS: Windows 8, 64 bit
[ ] Browser: Chrome

[{"id":"d7865612.27b3d8","type":"subflow","name":"read timplan data","info":"","category":"","in":[{"x":40,"y":40,"wires":[]}],"out":[{"x":380,"y":40,"wires":[{"id":"d7865612.27b3d8","port":0}]}]},{"id":"e00f805a.e00e4","type":"key-value-read","z":"d7865612.27b3d8","store":"17fb9375.3ee4cd","key":"","name":"","x":270,"y":40,"wires":[[]]},{"id":"814a36a7.b25b28","type":"function","z":"d7865612.27b3d8","name":"","func":"msg.topic = "timeplans." + \n    msg.get("timeplan") + "." + \n    msg.payload;\nreturn msg;","outputs":1,"noerr":0,"x":150,"y":40,"wires":[["e00f805a.e00e4"]]},{"id":"17fb9375.3ee4cd","type":"key-value-store","z":"","filepath":"shuttercontrol.json","namespace":"","name":"shuttercontrol"},{"id":"9071e536.b47118","type":"inject","z":"8b6c3371.fa7ea","name":"","topic":"","payload":"plan1","payloadType":"str","repeat":"","crontab":"","once":true,"onceDelay":0.1,"x":90,"y":40,"wires":[["afec1c34.779fe"]]},{"id":"afec1c34.779fe","type":"ui_dropdown","z":"8b6c3371.fa7ea","name":"","label":"Zeitplan","place":"Select option","group":"14ca7f6e.0847e1","order":1,"width":"0","height":"0","passthru":true,"options":[{"label":"Plan 1","value":"plan1","type":"str"},{"label":"Plan 2","value":"plan2","type":"str"}],"payload":"","topic":"","x":240,"y":40,"wires":[["748a1996.607a48"]]},{"id":"88fcda85.477928","type":"change","z":"8b6c3371.fa7ea","name":"","rules":[{"t":"set","p":"payload","pt":"msg","to":"active","tot":"str"}],"action":"","property":"","from":"","to":"","reg":false,"x":140,"y":160,"wires":[["ca09f446.73ae28"]]},{"id":"476387a4.7ff3f8","type":"inject","z":"8b6c3371.fa7ea","name":"","topic":"","payload":"plan2","payloadType":"str","repeat":"","crontab":"","once":false,"onceDelay":0.1,"x":90,"y":80,"wires":[["afec1c34.779fe"]]},{"id":"748a1996.607a48","type":"change","z":"8b6c3371.fa7ea","name":"","rules":[{"t":"set","p":"timeplan","pt":"flow","to":"payload","tot":"msg"}],"action":"","property":"","from":"","to":"","reg":false,"x":430,"y":40,"wires":[["88fcda85.477928"]]},{"id":"7dc1f1ee.8c238","type":"change","z":"8b6c3371.fa7ea","name":"","rules":[{"t":"set","p":"topic","pt":"msg","to":"active","tot":"str"}],"action":"","property":"","from":"","to":"","reg":false,"x":530,"y":160,"wires":[["a816d64.67ebd28"]]},{"id":"7e2ee4b4.1e776c","type":"subflow:d7865612.27b3d8","z":"8b6c3371.fa7ea","name":"","x":340,"y":160,"wires":[[]]},{"id":"40735ca5.35eee4","type":"key-value-read","z":"8b6c3371.fa7ea","store":"17fb9375.3ee4cd","key":"","name":"","x":390,"y":220,"wires":[["7dc1f1ee.8c238"]]},{"id":"ca09f446.73ae28","type":"function","z":"8b6c3371.fa7ea","name":"","func":"msg.topic = "timeplans." + \n    msg.get("timeplan") + "." + \n    msg.payload;\nreturn msg;","outputs":1,"noerr":0,"x":270,"y":220,"wires":[["40735ca5.35eee4"]]},{"id":"14ca7f6e.0847e1","type":"ui_group","z":"","name":"Zeitplanung","tab":"88436355.2df0f","disp":true,"width":"8","collapse":false},{"id":"88436355.2df0f","type":"ui_tab","z":"","name":"Zeitplanung","icon":"dashboard"}]

The 'read' node is from that plugin: node-red-contrib-key-value-store

It took me a while to figure it out.... but then I spotted it.
Your Function node inside the Subflow is not wired to the subflow input node.... its just sat on top of the wire that goes straight from input to output.
Ooops 😉

ugh! That's right! Sorry for stealing your time!
'Was just a try for checking node-reds bug response time. It's impressive  ;) :P

👍


@infernus/cef

hey bro i have a problem with that
when i'm trying to emit event to show player a ui server giving that [dev:server] [2024-05-26T00:19:34+0300] [Info] [sampgdk:w] Invalid buffer size
can i have your discord to show problem properly? didnt find any yours contacts
p.s
on calling event
CefEvent.onInitialize(({ player, success, next }) => {
  if (!player) return next();

  if (success) {
    new Cef({
      player,
      browserId: 1,
      url: "http://localhost:7779",
      hidden: false,
      focused: true,
    });
  } else {
    player.sendClientMessage(
      -1,
      "Ahh to bad you cannot see our new cool interface ...",
    );
  }

  return next();
});

its getting [dev:server] [2024-05-26T01:53:36+0300] [Info] [sampgdk:w] Invalid buffer size
but if we are calling like in docs samp-cef it works(pawn)

try using the latest<EMAIL_ADDRESS>with the polyfill of cef available in infernus-starter.
can you specifically post the code of emitEvent?

recreated a project with 0.1.0 semp cef
Now it works but so stange. it shows me only when i press and only after when i going to window mode and back

example

This is really strange. The case I provide is always shown. Have you tried to develop your current cef code by pawn? I think it may be a problem at the sa client level.
The orm library like prisma is not fully supported by samp-node at present.
I have tried to use typeorm, and I almost always encounter blocking terminal execution every time I start, which is strange, but press enter, but this is obviously not suitable for actual production environments.
The blocking problem is not caused by infernus and needs to be solved by samp-node authors.

yep i tried it works normally :D, so i can provide to u a zip file with that to test by your self, maybe its trouble in my client? cef 1.4.1

Sure, I used 1.4.1 too

can i have your discord or telegram to provide? or for you will be easyli to get invited to repo?

discord: dockfries2233


test/connectivity: Add a bit more logging around Hubble connections

When connections to hubble fail, there currently isn't enough information to debug the issue after-the-fact. So, add in a few more debug lines to try and get to the bottom of the problem.
Also, bump the connection timeout from 10 to 30 seconds.
Signed-off-by: Casey Callendrello<EMAIL_ADDRESS>

Needed to add a waitgroup just to stop some misleading log ordering. It doesn't have any correctness implications.


Support <details> and <summary>

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details

Hi @sidx1024,
Unfortunately at this point I don't have the capacity to add support for additional elements. Thank you for raising this issue though. I will definitely work on this once I get back to the project.
Cheers,
Mateusz


Have you tried using the star-shaped feature points detector ?

I really liked your work and your contribution to the calibration of cameras.
I would like to ask about images with incomplete detection, in the documentation you referred to the works of "Thomas Sheps - Why having 10,000 parameters in your camera model is better than twelve", have you tried using their detector to determine corners ?

Hi, @dkogan
Thanks for the boofcv detector, I had never heard of it before, thanks to you I learned more.
I used the star detector from here and added some code to convert corners to .vln format.
During the experiment, I took 100 shots of the star template, performed the detection with the Star Detector, and converted the result to .vnl format.
Show corners
For calibration I used the command:
mrcal-calibrate-cameras --corners-cache MainCorner.vnl --lensmodel LENSMODEL_SPLINED_STEREOGRAPHIC_order=3_Nx=30_Ny=20_fov_x_deg=150 --focal 1250 --object-spacing 0.012 --object-width-n 17 --object-height-n 24 './frames/*.png'
The program gave the following error:

I assumed that the problem may lie in the small number of angles found in the image, and therefore I selected the 5 most successful shots for verification and repeated the calibration.
The error is gone ! :)
Show Model
An example of an undistorted image of the resulting model:

My question is, can the program give that error because of the large number of undetected corners ?

Hi. Thanks for doing the work to test this! I'm currently improving the documentation, and this data will help me do that. Thanks!
The error you're seeing (non-positive-definite JtJ matrix in CHOLMOD) usually results from some variable in the optimization having zero effect on the problem. When the solver sees that, it tries to correct by adding a bit of L2 regularization to pull everything towards 0, but it's not a "fix", and the root cause should be addressed. The tool needs to be clearer about what's happening, and I can sorta improve that.
Here's what's happening in your case:

The optimization runs to completion
The solver looks for outliers (simply defined as poorly-fitting observations for now), and throws them out. In your case, for some observation this threw away all or almost all of the observed points.
The optimization runs again, ignoring the outliers
Due to the outlier rejection, there's a chessboard observation in the solve with no points (all have been thrown out). So the variables that control where this chessboard is in space no longer have any effect on the solution, and you get your problem

A simple workaround is to disable the outlier rejection: mrcal-calibrate-cameras --skip-outlier-rejection ....
If I do that, the errors go away, but the resulting residuals are very poor: mrcal-show-residuals-board-observation \ --from-worst camera-0.cameramodel 0-5 pulls up the 6 worst-fitting images, and we see that the worst one is REALLY bad, but the rest are fine. This tells me that it's likely that this one image has some kind of problem. The bad image is frame_252.png. If we get rid of that image and re-solve, the errors disappear. So maybe the detections are out-of-order in that image (rotated or mirrored). Or maybe the seeding algorithm got confused about something. Can you please double-check the detections for that image? If you tell me they look OK, I'll look a bit deeper.
And two more notes:

The FOV in your splined model is far too high. It doesn't break anything, but it puts a lot of the splined surface beyond where your lens can see, which wastes that complexity. Try something like LENSMODEL_SPLINED_STEREOGRAPHIC_order=3_Nx=12_Ny=9_fov_x_deg=75
The MainCorner.vnl you sent isn't a .vnl: it's missing the header. Prepend # filename x y level to that data, and it becomes a vnl, and you can do stuff like

< MainCorner.vnl \
  vnl-filter -p filename --has x \
| vnl-uniq -c \
| vnl-filter -p count \
| feedgnuplot --histo 0 --binwidth 10

and
< MainCorner.vnl \
  vnl-filter -p filename --has x \
| vnl-uniq -c \
| vnl-sort -gk count

I looked deeper into this, and found a bug in my code. This caused issues in the initialization of incomplete chessboard views, which triggered the problem in this report. Fixed here: https://github.com/dkogan/mrcal/commit/be69d9ed72a97287c87f15773d451ce7033e0758. I'm about to commit another patch to improve diagnostic printing in such cases as well. I'm closing the report.

Hello @dkogan
Thank you for your answer to my question, you helped me a lot.
I am glad that I was able to help this project.
Detection on image frame_252.png ok.

Hi. Yes the detection of frame 252 was OK. The problem was caused by the bug that is fixed in the git.
What's your experience with the detector? Did it work OK? Can you share the complete set of code you used to run it over your images?
Would you mind if I used your MainCorner.vnl data in the documentation for mrcal? It would be a good example of using other corner detectors with mrcal.

Hi, @dkogan
Of course, I have no objections, use the data.
At the moment I can't check how good this template is. I would like to check, but now I have other tasks. I have a robot manipulator that can help very well in collecting a sample of images, and I will definitely reach this stage soon.
My template is printed on plastic and is not perfectly smooth.
PDF: pattern_resolution_17x24_segments_16_apriltag_0 (1).pdf
Pattern Model: pattern.txt
(I couldn 't upload a format file here .yaml, so changed it to .txt, if you want to use this model inside the program, change the file format to .yaml)
To run the detector, I used a program from an open repository. To use it, you need to install all the dependencies suggested in the documentation.
To start the detector, I used the following command: ./camera_calibration —pattern_files PATH/pattern.yaml —image_directories PATH/imgDir —dataset_output_path PATH/features.bin —refinement_window_half_extent 20 —no_cuda_feature_detection
In the near future, I will rewrite the detector for my project (for C++ and Opencv) and make it independent of the main program presented in the author's repository. When I manage to implement this, I would be happy to share it with you.


[TC Components] -> [Vue UI]

TC Components
A library of high-quality ready to use Vue.js components that will help you speed up your development workflow. Including 29 components and 4 layouts. Highly customizable.
Link: https://components.timos.design/
Checklist:

[x] I have performed a self-review of submitted resource and its follows the guidelines of the project.

Also, add only one resource link to the site. Looks like you are pointing to subdomains from one website.

See this: https://github.com/bradtraversy/design-resources-for-developers/pull/653#issuecomment-706499179_


(catalog-module-unprocessed): Align knex dependency

Otherwise, the types are mismatching and backstage cannot build in certain cases
Hey, I just made a Pull Request!
After upgrading backstage to 1.15.0, we tried to integrate this module into our catalog. But this doesn't work properly due to type errors. Since all the internal packages are setting the version ^2.0.0 in the package.json but this module uses the latest (2.4.2), it seems that something is incorrect and the type complains.
When setting this lines in our catalog.ts file:
const unprocessed = new UnprocessedEntitesModule(
  await env.database.getClient(),
  router,
);

The output is the following:
$ yarn tsc
yarn run v1.22.19
$ tsc
packages/backend/src/plugins/catalog.ts:391:5 - error TS2345: Argument of type 'import("/home/ivgo/backstage/backstage/node_modules/knex/types/index").Knex<any, any[]>' is not assignable to parameter of type 'import("/home/ivgo/backstage/backstage/plugins/catalog-backend-module-unprocessed/node_modules/knex/types/index").Knex<any, any[]>'.

391     await env.database.getClient(),
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

plugins/catalog-backend-module-unprocessed/src/module.ts:40:11 - error TS2345: Argument of type 'import("/home/ivgo/backstage/backstage/node_modules/knex/types/index").Knex<any, any[]>' is not assignable to parameter of type 'import("/home/ivgo/backstage/backstage/plugins/catalog-backend-module-unprocessed/node_modules/knex/types/index").Knex<any, any[]>'.
  The types of 'raw(...).transacting' are incompatible between these types.
    Type '(trx: import("/home/ivgo/backstage/backstage/node_modules/knex/types/index").Knex.Transaction<any, any[]>) => import("/home/ivgo/backstage/backstage/node_modules/knex/types/index").Knex.Raw<any>' is not assignable to type '(trx: import("/home/ivgo/backstage/backstage/plugins/catalog-backend-module-unprocessed/node_modules/knex/types/index").Knex.Transaction<any, any[]>) => import("/home/ivgo/backstage/backstage/plugins/catalog-backend-module-unprocessed/node_modules/knex/types/index").Knex.Raw<any>'.
      Types of parameters 'trx' and 'trx' are incompatible.
        Type 'import("/home/ivgo/backstage/backstage/plugins/catalog-backend-module-unprocessed/node_modules/knex/types/index").Knex.Transaction<any, any[]>' is not assignable to type 'import("/home/ivgo/backstage/backstage/node_modules/knex/types/index").Knex.Transaction<any, any[]>'.
          The types of 'query(...).client.config.client' are incompatible between these types.
            Type 'string | typeof import("/home/ivgo/backstage/backstage/plugins/catalog-backend-module-unprocessed/node_modules/knex/types/index").Knex.Client | undefined' is not assignable to type 'string | typeof import("/home/ivgo/backstage/backstage/node_modules/knex/types/index").Knex.Client | undefined'.
              Type 'typeof Client' is not assignable to type 'string | typeof Client | undefined'.

40           await database.getClient(),
             ~~~~~~~~~~~~~~~~~~~~~~~~~~

Found 2 errors in 2 files.

Errors  Files
     1  packages/backend/src/plugins/catalog.ts:391
     1  plugins/catalog-backend-module-unprocessed/src/module.ts:40
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

After this change, the command is not failing anymore.
This is blocking us to start using this plugin, since the yarn tsc is required to build our backstage image.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] ~Added or updated documentation~
[ ] ~Tests for new functionality and regression tests for bug fixes~
[ ] ~Screenshots attached (for UI changes)~
[x] All your commits have a Signed-off-by line in the message. (more info)

Not really needed. If you're facing a similar issue, in our case it was due to a duplicated block in the yarn.lock. We had 2 entries for the<EMAIL_ADDRESS>versions, which was causing some issues in our end. Not sure why this happened, but just a heads-up for others facing the same


[misc] Add 'az version'

Inspired by #11425
Add preview command az version show to show the versions of Azure CLI modules and extensions in JSON format, so that the output can be passed to downstream command or script for easy parsing.
> az version show
This command is in preview. It may be changed/removed in a future release.
{
  "azure-cli": "2.0.78",
  "azure-cli-command-modules-nspkg": "2.0.3",
  "azure-cli-core": "2.0.78",
  "azure-cli-dev-tools": "0.1.1",
  "azure-cli-nspkg": "3.0.4",
  "azure-cli-telemetry": "1.0.4",
  "azure-cli-testsdk": "0.2.4",
  "extensions": {
    "application-insights": "0.1.1"
  }
}

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[x] I adhere to the Command Guidelines.

one small suggestion here is that can we format the output when running with -o table

can we add test for your command to check the output instance?

https://github.com/Azure/azure-cli/pull/11680#issuecomment-570147481
Yes. Please see previous comments.

https://github.com/Azure/azure-cli/pull/11680#issuecomment-570147764
Thanks for the suggestion. Added as requested.

#11680 (comment)
Yes. Please see previous comments.

but when I run az version -o table, extensions information is lost, is this expected?

#11680 (comment)
Yes. Please see previous comments.

but when I run az version -o table, extensions information is lost, is this expected?

Yes. Because extensions is not the at the first layer of the json.


Package autocomlete do not work for local repository or "nuget/package-ids?partialId" returns 404

When using Package Manager Console, say Install-Package, and than pressing tab, autocomplete of available packages stopped to work for my local package repository only .
In Fiddler I see this request, which returns 404:
http://localhost/NuGetServer/nuget/package-ids?partialId=&includePrerelease=False
(while http://localhost/NuGetServer/nuget works)
I tried moving the NuGetServer app to different servers, tried autocomplete from different dev machines, created NuGetServer app from scratch (with both 2.8.6 and 2.10.3 NuGet.Server packages). Nothing helped
The problem originally found in VS2015.
VS2013 works, but it gets 404 for this requests too. This works as it sends another request right after:
http://localhost/NuGetServer/nuget/Packages()?$orderby=DownloadCount desc,...
which return required data
Other functionality, like NuGet UI for project, is working and show all packages available in repository
I think it something that happened on my side. But have no idea what can it be as I tested different server and client machines. May be it's client configuration... How can I debug this problem?
Thanks

The autocomplete endpoint is not available in NuGet.Server. @rrelyea I guess this fallback is not in the VS2015 client?

I understand this is a bug in client of VS 2015. Right?

@rrelyea can you check if this is in client?

This issue was moved to NuGet/Home#2896


Unit tests for load models

looks good! Just a question on the brew test... do we really need to set np.random.seed(3) twice?

The results changed because of the ransom spit if the seed is not set, so it seems it is reset after each run


How to set constraints for the arguments

How can I set constraints for the parameter updating, for example, restricting the gamma parameters of PReLU within range [0,1]? Is it possible to do this within existing MXNet framework?

you can try modifying the operator or optimizer

@piiswrong Thank you. On the operator side, I add the clipping code in the Forward() function, but it seems that the clipped gamma is not synced on the kvstore. I will try to do this on the optimizer side.

This issue is closed due to lack of activity in the last 90 days. Feel free to reopen if this is still an active issue. Thanks!


Example in readme and UPM

Im aware that a UPM related pr was already opened and then closed in #5, the closing comment stated that there are too many changes. So ill describe the changes here because the file change log looks bigger than what was actually done.

package.json was added

All information here is based on whats already on the upstream repo

Directories were moved up

Core, DefaultAttributes, DefaultUI are at the root now

SerializeReferenceUIExample was renamed to Samples~

This allows the example to be seen by UPM as samples that can be imported (image below)

The readme was updated to include instructions to install and a clear example of how to use and implement

At the moment, the git url in the installation to add the package is pointed at my fork, It'll be changed so that it points to this repo once it gets merged.

This would be a great addition! Please merge!

Any chance of this getting merged? I'd like to try out the library.

Thanks for PR!
And sorry for that it has taken so long to merge it.


[v2] @supports query always results to true, if there´s a nested @media query

Version
2.0.0-17
Reproduction
https://www.webpackbin.com/bins/-Kji-ewR2MGAKe_s1IPJ
Steps to reproduce
see example above
Expected Behavior
@supports not (display: block) should result to false and content should be ignored.
Title color should be palevioletred.
Actual Behavior
@supports not (display: block) results to true and content is being included.
Title color is green.

@ThySultan This seems to be a problem with Stylis :) https://www.webpackbin.com/bins/-Kji2D_tAEbrLoEipsCh

Landed a patch in v2.0.5.


Add visual regression tests

Closes #39

This change is

Just as a general comment, in case we ever want to publish the diff report for failed tests from Travis, we might need to do something like this: https://docs.travis-ci.com/user/uploading-artifacts/

Review status: 0 of 13 files reviewed at latest revision, 4 unresolved discussions.

.gemini.yml, line 11 at r1 (raw file):
Previously, limonte (Limon Monte) wrote…
Edge and Safari will be really great here.

Safari does not (still) work to some selenium driver issues, edge however I was able to get working (although they say it doesn't)
edge:
    desiredCapabilities:
      browserName: "MicrosoftEdge"
      platform: "Windows 10"
      version: "14.14393"

.gemini.yml, line 14 at r1 (raw file):

  chrome:
    desiredCapabilities:
      browserName: "chrome"

We might want to add platform: "Windows 10" – I think they run XP by default :volcano:

.gemini.yml, line 20 at r1 (raw file):
Previously, limonte (Limon Monte) wrote…
50 is the Firefox latest currently, it should be supported by Saucelabs

There's also some limitations to this, 47 seems to be the latest version working together with Gemini.

Comments from Reviewable

Review status: 0 of 13 files reviewed at latest revision, 4 unresolved discussions.

.gemini.yml, line 14 at r1 (raw file):
Previously, Saulis (Sauli Tähkäpää) wrote…
We might want to add platform: "Windows 10" – I think they run XP by default :volcano:

Done.

.gemini.yml, line 20 at r1 (raw file):
Previously, Saulis (Sauli Tähkäpää) wrote…
There's also some limitations to this, 47 seems to be the latest version working together with Gemini.

Updated to 47

Comments from Reviewable

Reviewed 10 of 11 files at r1, 2 of 3 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

Comments from Reviewable


Low entropy after boot (reading from /dev/random blocks)

Hi,
I just faced the problem, brand new enclave has zero entropy:
cat /proc/sys/kernel/random/entropy_avail
0

which cause block when reading from  /dev/random early after boot.
What about adding some entropy from NSM RNG at boot stage?
Another question: which preferred workaround to use right now?

Options for getting entropy were shared in https://github.com/aws/aws-nitro-enclaves-sdk-c/issues/41. Closing this issue as well, as it is the same topic.


[Feature Request] Dynamic interval for auto advance mode

Is your feature request related to a problem? Please describe.
Possibility to set a time interval for "auto advance" mode.
It would be interesting that the user can only change the slider if the auto-advance mode is enabled
Describe the solution you'd like
For example, create an slider below the auto advance toggle, to select the time between each word.

E.g: Material UI Slider

I already created a drafted PR. I am still working at it and I think I will finish it tomorrow.


500 Unknown Error with no details when trying to download a report from dfareporting v4

Environment details

OS type and version: Windows 10
Python version: 3.7.9
pip version: 22.0.3
google-api-python-client version: 2.52.0

Steps to reproduce

Add profileId, reportId and credentials to code snippet below and run
Observe 500 error

Code example
import os
import json
import time
from io import FileIO

from googleapiclient import http
from google.oauth2 import service_account
from googleapiclient.discovery import build

report = {
    "criteria": {
        "dateRange": {
            "relativeDateRange": None,
            "startDate": "2022-07-04",
            "endDate": "2022-07-04",
        }
    }
}

REPORT_ID = ''  # Report Id (int)
PROFILE_ID = ''  # Profile Id (int)

def get_report(service):
    """Runs a report and waits for it to be ready"""
    report_response: dict = (
        service.reports().run(profileId=PROFILE_ID, reportId=REPORT_ID).execute()
    )
    print(json.dumps(report_response, indent=4))
    file_id = report_response["id"]
    report_response: dict = (
        service.reports()
        .files()
        .get(profileId=PROFILE_ID, reportId=REPORT_ID, fileId=file_id)
        .execute()
    )
    time.sleep(5)

    while report_response["status"] != "REPORT_AVAILABLE":
        report_response: dict = (
            service.reports()
            .files()
            .get(profileId=PROFILE_ID, reportId=REPORT_ID, fileId=file_id)
            .execute()
        )
        time.sleep(5)
    print(json.dumps(report_response, indent=4))
    print(f"API URL to retrieve file: {report_response.get('urls').get('apiUrl')}")
    return report_response

def download_report(service, file_path, report_file):
    """Retrieves a ready report file"""
    out_file = FileIO(str(file_path), mode="wb")
    request = service.files().get_media(
        reportId=report_file["reportId"],
        fileId=report_file["id"],
    )

    downloader = http.MediaIoBaseDownload(out_file, request, chunksize=32 * 1024 * 1024)
    download_finished = False

    while download_finished is False:
        _, download_finished = downloader.next_chunk()

    print(
        f"File {report_file['id']} downloaded to {os.path.realpath(str(out_file.name))}"
    )
    return str(out_file.name)

if __name__ == "__main__":
    # Insert code to load service account credentials

    oauth_credentials = service_account.Credentials.from_service_account_info(
        campaign_manager_secrets
    )
    service = build(
        "dfareporting",
        "v3.5",
        credentials=oauth_credentials,
        cache_discovery=True,
    )

    report_file = get_report(service)
    file_path = download_report(service, "./campaign_manager_report.csv", report_file)
    print(f"File was downloaded: {file_path}")

Output of code snippet
{
    "kind": "dfareporting#file",
    "etag": "\"08fTcNjAfGpA5iZbj4pqeKSxfZQ\"",
    "reportId": "<removed-for-snippet>",
    "id": "<removed-for-snippet>",
    "lastModifiedTime": "1657293406000",
    "status": "PROCESSING",
    "fileName": "<removed-for-snippet>",
    "dateRange": {
        "kind": "dfareporting#dateRange",
        "startDate": "2022-07-07",
        "endDate": "2022-07-07"
    }
}
{
    "kind": "dfareporting#file",
    "etag": "\"lHjvsbj0FTJKOmBHFJQYhcw7xaY\"",
    "reportId": "<removed-for-snippet>",
    "id": "<removed-for-snippet>",
    "lastModifiedTime": "1657293407000",
    "status": "REPORT_AVAILABLE",
    "fileName": "<removed-for-snippet>",
    "format": "CSV",
    "dateRange": {
        "kind": "dfareporting#dateRange",
        "startDate": "2022-07-07",
        "endDate": "2022-07-07"
    },
    "urls": {
        "browserUrl": "https://www.google.com/reporting/downloadFile?id=<removed-for-snippet>:<removed-for-snippet>",
        "apiUrl": "https://www.googleapis.com/dfareporting/v4/reports/<removed-for-snippet>/files/<removed-for-snippet>?alt=media"
    }
}
API URL to retrieve file: https://www.googleapis.com/dfareporting/v4/reports/<removed-for-snippet>/files/<removed-for-snippet>?alt=media

Traceback (most recent call last):
  File "campaign_manager_test.py", line 93, in <module>
    file_path = download_report(service, "./campaign_manager_report.csv", report_file)
  File "campaign_manager_test.py", line 64, in download_report
    _, download_finished = downloader.next_chunk()
  File ".venv\lib\site-packages\googleapiclient\_helpers.py", line 130, in positional_wrapper
    return wrapped(*args, **kwargs)
  File ".venv\lib\site-packages\googleapiclient\http.py", line 780, in next_chunk
    raise HttpError(resp, content, uri=self._uri)
googleapiclient.errors.HttpError: <HttpError 500 when requesting https://dfareporting.googleapis.com/dfareporting/v4/reports/<removed-for-snippet>/files/<removed-for-snippet>?alt=media returned "Unknown Error.". Details: "[{}]">

Stack trace
Traceback (most recent call last):
  File "campaign_manager_test.py", line 93, in <module>
    file_path = download_report(service, "./campaign_manager_report.csv", report_file)
  File "campaign_manager_test.py", line 64, in download_report
    _, download_finished = downloader.next_chunk()
  File ".venv\lib\site-packages\googleapiclient\_helpers.py", line 130, in positional_wrapper
    return wrapped(*args, **kwargs)
  File ".venv\lib\site-packages\googleapiclient\http.py", line 780, in next_chunk
    raise HttpError(resp, content, uri=self._uri)
googleapiclient.errors.HttpError: <HttpError 500 when requesting https://dfareporting.googleapis.com/dfareporting/v4/reports/<removed-for-snippet>/files/<removed-for-snippet>?alt=media returned "Unknown Error.". Details: "[{}]">

This started happening suddently, with no code changes as far as I can tell, using v3.5. Upgraded to v4 to see if it was related to some deprecation but same result.
A 500 error with no error message. Could it have something to do with the API download URL link in the get report response being:
https://www.googleapis.com/dfareporting/v4/reports/REPORT_ID/files/FILE_ID?alt=media
But the python library is trying to retrieve it from:
https://dfareporting.googleapis.com/dfareporting/v4/reports/REPORT_ID/files/FILE_ID?alt=media

Hi @robinstauntoncollins ,
Did you got solution for this error?, i am also facing same issue.
Thanks

@krishnadw2 Nope. But still early days.

I believe that this error occurs when trying to access the report (or retrieve the status of the report) before it has completed and reached the REPORT_AVAILABLE status.

I don't thin this is due to status of the report. I have a daily job which runs at same time and it was running fine till July 5th.
From July5th something changed ,throwing httperror 500.

I don't think it's because of the status of the report. Just that's where I encountered it. I have since also encountered 500 errors when trying to download the report with REPORT_AVAILABLE status.

My job is failing at the exact point. Did you find any solution for this?

No solution. But one workaround is to use exponential backoff retries for example with tenacity. Seems to work eventually. Also, if you're downloading files you can pass an integer to the next_chunk method with for the amount of times to retry.


Mouse right-click comment and uncomment code menu

I would like to have the following feature: Mouse right-click comment and uncomment code menu for a line and multiple lines.
Thank you,
Ernest

i did not see any answer in (#81663) post. what is the plan for it?

hello vs code community!
let's vote all for it. we're tired of many shortcuts’ keyboards in vs code already - LET'S ALL VOTE IN 2020!
thank you all,
ernest

I was also looking for such a feature. Upvoted +1

I was also looking for such a feature. Upvoted +1


Provide an is_network_error method on reqwest::Error

I would like to have an easy way to determine whether an error is a network error or not. Currently I'm not quite sure how exactly to do this, so it would be nice, if such a method could be added.

Seems reasonable! What sorts of cases would you think would be a network error? Just TCP errors? DNS? HTTP?

TCP or DNS, yes. HTTP, no.

Hey, I was taking a look at https://github.com/seanmonstar/reqwest/blob/master/src/error.rs. It is my first around here and although I've been following rust for four years I'm still a newbie. Would you be able to provide some guidance as to where I should look at? Thanks!

I'd like to second this. I need to know if an HTTP GET failed due to failing to make a TCP connection. (Ideally I'd also like to know if there was a TLS error.) These are importantly distinct cases for my application from redirect, status, or timeout.


Can't find rules of tslint-microsoft-contrib when installed as peer.

It seems like tslint-clean-code can't find the tslint-microsoft-contrib rules directory, when it's installed as a peer-dependency.
Changing tslint.json line 3 from "node_modules/tslint-microsoft-contrib" to "tslint-microsoft-contrib" fixes that, but not sure if it would then still find it inside of node_modules.

I have not personally experienced this issue yet.
Pull Requests welcome!

Can confirm that tslint-clean-code does not work at all since tslint can't find the contrib rules. As they are only defined as a dev dependency of clean-code, they don't get installed when clean-code is used as a dependency of other projects. Installing the contrib rules myself does not solve the issue (since clean-code looks into its own node_modules directory).

I checked my other projects using this package and this is how I was using it:
{
  "rulesDirectory": [
    "./node_modules/tslint-microsoft-contrib",
    "./node_modules/tslint-clean-code/dist/src"
  ],
  "extends": [
  ],
  "rules": {
    // List all of the specific rules...
  }
}

Are you all using something like the following?
{
  "extends": "tslint-clean-code"
}

This explains why I have not yet experienced the problem.

Yup, I simply have it in my extends list:
"extends": ["tslint:recommended", "tslint-react", "tslint-config-prettier", "tslint-plugin-prettier", "tslint-clean-code"],

I think I am going to adopt tslint-eslint-rules way of doing things: https://github.com/buzinas/tslint-eslint-rules/blob/master/index.js
// unopinionated extensable tslint configuration
// loads rules for extending packages, but does not enable any
module.exports = {
    rulesDirectory: "./dist/rules",
};

Thus, using extends as @Nimelrian and others are doing would result into the rulesDirectory being added for tslint-clean-code however not enabling any of the rules -- which I prefer.
This also removes the requirement for tslint-microsoft-contrib as it should have only been a requirement for this repository when contributing and not a requirement for those using tslint-clean-code and not wishing to use tslint-microsoft-contrib.
Pull Request coming soon!

Here's my PR: https://github.com/Glavin001/tslint-clean-code/pull/34
Please take a look and 👍 and/or comment! I will wait for some feedback before merging and publishing.

Published to v0.2.2


Using etcd 3.0.15 in bootstrap images.

That way unit tests (that now require etcd 3.0+) pass.

LGTM


Write example and docs for C++ component adaptors

How to convert your own Position and Color types to rerun types

Duplicate to #3964


fix: syntax error on table search query

Mariadb doesn't support -> operator on queries. I'm changed -> operator to json_extract function.
I'm tested Mariadb 10.x and MySQL 5.x versions and working correctly

Thanks


add instruction documentation

Actually, this seems very confused. This change was merged a while back. See the docs: https://sphinxcontrib-youtube.readthedocs.io/en/latest/usage.html#installation

weird, sorry for the noise. I guess I have some version issues in my local computer.


lagging the server....

hey there
this is what my sf showed me

that is why I am reporting it here plz fix it I really need this plugin
btw an opinion since it gives u free carbon plz make it way harder to build
tnx

it is also happening with me in 1.18.1 paper https://streamable.com/jkr8mu

@RIPISDRAD @SideLo98 Hi there, thank you both for your bug report. I would need a proper Spark profile in order to look into more detail about this issue. You can follow this lovely message sent by WalshBot in the Slimefun Discord server related to Spark profiling:

Also, I would be thankful if you could fill the Bug report issue template correctly next time.


Segfault on startup due to background

The background image is loaded up, and then mysteriously destroyed just a moment later. This causes a segfault, and Way Cooler terminates. Tested as of 034dcbe (current master), on Arch Linux 64bit.
WORKAROUND: Set the color in the configuration file to be empty, and it should work as the background will then not load.

Duplicate of #115 || fixed in 21bd2c4 ?

Not dup, but was mentioned. This is a separate issue.


add Qubit to users

Thanks for an awesome project :)

Hi @jibs!
This is awesome! I'm very glad Finch is used to build such cool things like Qubit!
Do you mind to share a bit of detail (since which version do you use Finch, what modules do you use etc.) so I and other Finch developers could understand the priorities of our adopters?

I've merged it. Thanks @jibs!

Sorry for the delay :)
Sure - we're using a bunch of different versions - vast majority is 0.6.0 at the moment. Primarily finch is augmenting a lot of the internal routing stuff we wrote at Qubit (we've been using finagle for a while so there is a lot of this code). There have been some tiny contributions back by us but we hope to make this more substantial as finch gets more traction here.
Thanks again!

Thanks @jibs! This is grreat!


External Search in HTML columns

Issue Type

[x] Question

Specs
What version are you using?
2.19.1
What browser?
Chrome 80.0.3987.163
Expected Behavior
External search to filter data in columns with Html: true
Actual Behavior
It searches only for text fields and the text inside any HTML tag does not gets filter via external search.
Steps to Reproduce the Problem
Attached v-model to an input box with <input  v-model="searchTerm"  />
In Vue Component add the following settings:
<vue-good-table
        :columns="columns"
        :rows="rows"
        :pagination-options="pagination"
        :search-options="{enabled: true,externalQuery: searchTerm}"
      >

This works for the columns/rows which has plain text value but does not filter the table results for some text wrapped in lets say an anchor tag or div's
Is there a workaround for this?
Thanks!
PS: Awesome work. One of the best Vue plugins i have used.

hey @contriveitup, filtering text out of HTML for the filter would not be in the scope for native filtering functionality because HTML structure could be complex. For your use-case, it'd make more sense to use a row template where you can provide a field value that would then be searchable.
https://xaksis.github.io/vue-good-table/guide/advanced/#custom-row-template
Closing.


Update README.md

Updating the request params as the names changed in newer version of Kong (^0.10.0).
Reference : https://github.com/Mashape/kong/pull/1970
@shashiranjan84

Won't merge until 0.10 is released. And then this should also include updating the defaults to 0.10 release.
@Amal-V can you update the PR to include that?

This change was already implemented. Closing this.


chore(master): release 0.8.0

:robot: I have created a release beep boop
0.8.0 (2023-10-05)
⚠ BREAKING CHANGES

highlights: redesign of highlighting approach (#1449)

Features

highlights: redesign of highlighting approach (#1449) (f688d23)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/vscode-neovim/vscode-neovim/releases/tag/v0.8.0 :sunflower:


[Request] Allow custom sender adresses

At the moment it's only possible to select a sender address from predefined identities. I would like to be able to enter a custom one. The reason is that I use a lot mail extensions and creating/maintain them as separate identities is simply not feasible.

I agree, that's a rather advanced feature, but very useful for power users and fans of catch-all e-mail addresses.

Duplicate of #935


stainless-cli login indefinitely running

I am attempting to build documentation for a Stainless API, but logging in with "stainless-cli login" is indefinitely running with no page navigation to OAuth.
I cloned the package and built it from source, and tried moving the  stainless-linux binary to another directory and tried running it from the "build" directory, but both have failed.

Hmm ok @mhbtz1. I'll take a look tonight. It most likely has something to do with rod (the automated browser package I'm using) not working. Thanks!

Also, I am currently running this on Ubuntu 22.04 LTS, if this helps.

Update: ran this in WSL Ubuntu (I ran it in native Ubuntu before), and encountered a different error where the login window opened up but it was corrupted (i.e. pixels were not aligned).


More web options (HTTP version, encoding, transfer body, follow request)

bro needs to set http version 💀

i think some doc comments would help out a bunch of these cuz theyre kinda ambiguous as to what they do

sure

@Cvolton any thoughts


希望补充 ivorysql.datetime_ignore_nls_mask 相关测试用例

Enhancement
文档中简述了该参数的功能，但在实测中并没发现该如何正确使用它，希望补充一些测试用例，以供参考。

I couldn't agree more !!!
For this enhancement, I created a PR with one commit in IvorySQL docs project
If you have any suggestion, welcome to leave comments in my commit, thanks a lot @shawn0915

https://docs.ivorysql.org/en/ivorysql-doc/v3.2/v3.2/15#ivorysql-datetime_ignore_nls_mask

We will add some test cases in IvorySQL oracle regression test

Some datetime_ignore_nls_mask test cases have been added into IVORY_REL_3_STABLE, the PR is #656.
Issue is closed now.


Mandatory courses: Code not aligned in the correct column when course group is not expanded

I think this is working correctly actually as the filter is used for filtering codes that appear only when group is expanded.


fix 'read full changelog' link on about page

Issue:
Clicking it didn't do anything because the Link component cancels by default.
What I did
Made the link actually work.
How to test
Click the link on the about page and make sure the full changelog opens.

LGTM! Thanks @zsalzbank 🙏


Pathways panel in target profile page shows error instead of diagram

When I open the target profile page for a gene that has pathways available, say BRAF, and open the Pathways panel, I see the following error message where I'd expect a diagram:

This occurs both on the public platform and on local deployments.

@LucaFumis, any ideas what could be going wrong here?

@fedde-s we've had a chat with the people from Reactome about this (benefits of being in the same building!) and it seems to be a CORS issue. www.reactome.org is a 301 redirect to reactome.org and reactome.org has Access-Control-Allow-Origin:* but www.reactome.org doesn't. So when javascript served from www.targetvalidation.org makes a request to www.reactome.org there is a redirect response without the CORS header, and the browser blocks following it. It's unclear why this has happened today or what has changed - Reactome will investigate more next week. Also next week @LucaFumis will check the calls the webapp makes and update them all to be directly against reactome.org

That was based on the suggestion to remove 'www' from Reactome URLs, but actually introduced an error in the batch search results. This is now fixed in commit 8de31d987915548449c9262cae506eb57ceba057
I'll merge and tag that and push a mini release out.

@LucaFumis, will there be a release tag for 3.12.3 on GitHub when it's ready?

Hi @fedde-s, yes I've just merged and sorted out the tags.
There is a 3.12.3 tag in GitHub
Quay: 3.12.3 (also tagged as 19.04.7)
@ElaineMcA the mini release is now live; I've updated the log.

This implements the quick fix as suggested by Reactome (i.e. removing the "www" from calls).
I believe they're investigating in parallel so there might be the need for further changes but for the time being this should work.

Fix confirmed: I see a diagram again.


Unable to create GH branches from Jira issue

We have integrated 4 of our GitHub (cloud) organizations with our "jciproducts" Jira instance.
The GitHub configuration page shows that all 4 organizations have been configured and the backfill status shows "finished".
When we try to create a new GitHub branch through the GitHub panel from a new Jira issue - we can only see a very limited number of repos (less than 50, where we should have thousands to choose from).
I have tried to enter the repo name via "org/repo" nomenclature, but had no success .. it seems the only repos that are being found are the limited number of repos that are being shown pre-populated when I select the down arrow on that Repository selection via 'Create Branch' > 'Repository'.
I have verified on the GitHub side, that the 'github-for-jira' app was configured for "all" repos (on all 4 orgs).
How can we use this integration for all repos?
-Rudi.
Ps. going the other route, i.e. adding the Jira issue key on GH commits seems to integrate just fine - it's the path coming from Jira that doesn't seem to work properly
(adding @anadivats for visibility)

I have the same problem when I created the branches and the list of repositories have a small pre-list but cannot search to the GitHub organization of all the repositories in Search. The Seach loops and unable to find any other repositories outside of the list.

:( same issue here

Same issue here :(

We are also having this issue with our org but it is not impacting everyone. It seems those with Admin rights in Github see all of the repos without issue and others can't search/filter the repos.

Hey @rfriedel @uskpea @imirandad @qschmick thanks for your requests and your patience!
We acknowledge the problem and working on a fix. Please stay tuned!

Hey @rfriedel @uskpea @imirandad @qschmick , this should be fixed now. Sorry for the inconvenience!
One thing to note though: the list of repos will contain only those that the current GitHub user (that is currently signed in in github.com)  has access to. This is done for a security reasons.
Closing the issue, please feel free to reopen in case you have any other questions/concerns .

@bgvozdev - is there any reinitializing / reindexing required from our end?  We still do not seem to be able to see all repos (verified that user has r/w permissions on the repo)?
I do see lots of 500 status errors (Developer Tools > network) when I type my desired repo name into the Create Branch  GitHub panel .. so something is not looking right.

@bgvozdev Thank you, working for our users now.

That's weird @rfriedel , would you mind to provide your jira hostname?

Hey @rfriedel , thanks for your patience. We have fixed a bunch of issues with the feature recently, particularly, if a user didn't have access to a single connected org (albeit it might've had access to other orgs), the repo search would fail for them.
Would you mind to give it another go and let us know if this is fixed for you or you still experience issues? Thanks!

Hi @rfriedel , sorry to hear that there's still no success. I've checked logs related to your installation once again (for the search repos feature) and still see just permission errors.
Could you please double-check that the user you are currently logged in can find these repos in GitHub at all? It is very easy to do:

open the issue view, click on "Create Branch" and enter the search string that presumably should've returned repos you were looking for
in a notepad, construct a search query as following: search-term org:org-name-the-wanted-repo-is-expected-to-be-in org:currently-logged-into-github-username in:name. For example, in my case, if I'm looking for a repository in Atlassian org that has test in name, and my currently logged in user is bgvozdev. Therefore the search string would be  test org:Atlassian org:bgvozdev in:name . That's exactly the query that the app is using to ask GitHub for the repos. (Please note that the org must be connected on "GitHub for Jira" admin page, because this is how the org name makes it way into the search string.)
encode it using some online tool  to convert the search string into a query parameter. In my case, I received test+org%3AAtlassian+org%3Abgvozdev+in%3Aname
open a new tab and enter the following URL: https://github.com/search?q=YOUR-ENCODED-SEARCH-STRING-FROM-STEP-3 . For me the resulting string would be https://github.com/search?q=test+org%3AAtlassian+org%3Abgvozdev+in%3Aname

Could you please confirm that you are able to find the repos form a connected org you were looking for using this method? Thank you.

I was "experimenting" with the URL encoded search strings that you explained above.
My initial attempts of finding particular repos on the Atlassian Jira Issue side .. and via GitHub (GH) URL failed equally.  While creating some new test repos I was forced to authenticate to GH via SSO and 2FA, once authenticated I was able to find my test repos from the Jira Issue GH panel and the GH URL.  So the search does require an authenticated user (token) .. so it seems.
This might be problematic on our end as we do have different user credentials for different orgs. We currently have (integrated with) 2 orgs with public managed user accounts (public GH handle) and 2 orgs with Enterprise Managed User (EMU) accounts .. so I always have to switch identities depending on what org I wish to access.
I noticed on my initial repo search from the Jira Issue GH panel, my public GH handle was pre-populated on the top right corner of that screen .. the link underneath Change GitHub login does not seem to trigger anything on my end that would allow me to change my user identity.
What should be our next steps, or usage workflow? Looks like we'd need to force an auth user session before we could query anything from the Jira side.
I also noticed that the Backfill displayed data seems to get stale and does not pick up new repos that were added .. until I manually kick of the backfill. I noticed that one of our orgs showed like a 1 year old repo count ..
This might be related.

Hi @bgvozdev - back again... sorry!
After initially having this handled on #1833, we're back to having some users with Write access in the GH repository getting Internal Server Error when trying to get results back from the following URL that the Create Branch page uses:
https://github.atlassian.com/github/create-branch/owners/SomeGitHubOrganization/repos/SomeRepository/branches?jiraHost=https%3A%2F%2Fsomeorg.atlassian.net
We've had the user reauthenticate on both GH and Jira side, but no dice on a fix.
Any chance you can peek in our organization logs and see if we are missing something?

Hi guys, just to give an update we are actively working on this ticket now. So one big problem is user have different credentials for different orgs via SSO, hence the feature is not working as expected. Work around to switch between orgs is not convenience. We are trying to use app token instead of user token to do the thing. But need to sort out some critical path for security purpose first since app token comes with greater power :)
I don't have an accurate ETA right now, but will try to give an update in two weeks time.

So we are facing the same 500 error and for some reason I am able to create a branch in github for one project but not for the other one. I am logged in using the same account and nothing has changed. maybe this helps in debugging the issue. we will also use the workaround suggested above for the time being. The project where I cant create the branches is a migrated project from our on prem installation.

One other thing that may help. so It fails to load branches for some repos but if I change the repo to a project that I had created, there is no error. so it may likely related to repo access. however I can create branches in the repos that dont work and I am admin of the github organization too

Got the 500 error as well. I'm able to select the repository from my org, but it doesn't find a valid branch:

My suspicion is that this is somehow related to us using an Enterprise account (but with GitHub Cloud, not self-hosted) and the repository being owned by an Organization in this Enterprise account. I'm owner for bot the org and the enterprise.

I am able to load branches of some of the repos and unable to do so for the
others. All these repos are in a GitHub organization account and I am the
owner of the gh organization.
On Fri, Apr 28, 2023, 12:18 AM Andre Rabold @.***>
wrote:

Got the 500 error as well. I'm able to select the repository from my org,
but it doesn't find a valid branch:
[image: jira-github-issue]
https://user-images.githubusercontent.com/1548229/234968618-bb4a2099-b6ac-40fc-ad54-25c8e29e3bdd.png
My suspicion is that this is somehow related to us using an Enterprise
account (but with GitHub Cloud, not self-hosted) and the repository being
owned by an Organization in this Enterprise account. I'm owner for bot the
org and the enterprise.
—
Reply to this email directly, view it on GitHub
https://github.com/atlassian/github-for-jira/issues/1845#issuecomment-1526224576,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AICB5JHGKW6FBYQTYT3CNW3XDLA75ANCNFSM6AAAAAAUATNUGY
.
You are receiving this because you commented.Message ID:
@.***>

We have this issue as well. We can find the repositories, but we cannot fetch the branches. We had a trial account, and now have a  paying enterprise account since last week. We have changed nothing with regards to authorization. No new users have been added.

Having the same issue

Having the same issue

I am also having the same issue. we could make branches under the github organizations before. we have other projects under the same organizations and connected with jira, which we can create new branches from. But for some reason, can't make new branches.

Just as a feedback, I did reconnect (disconnect and re-allowed) the GitHub Account (from within Jira global app admin) and it solved.
Possible cause: we'd recently upgraded from a trial plan to a paid one through an Atlassian partner. That's my best guess based on other comments.

Yes, that did the trick for me as well. Same setup: from trial to paid plan. Just reconnected, and now it works again.

@bgvozdev , @gxueatlassian - the behavior has improved noticeably, thank you.  I am able to find any repo (with updates created after last backfill start date) across our GHEC and GH EMU orgs (different user credentials). We have to run more in-depth testing for branch creation/association but so far this looks very promising.

We had the same issues around being able to select the repos but then get the error when it tries to load the branches
I disconnected/uninstalled the JIRA app from GitHub and then reinitatied the connection from JIRA and now the integration and branch creation is working again.
Still unsure as to what caused it to stop working as a week or so ago we did not have this issue.

Same problem here. About a week ago, the developers noticed that you could no longer make branches through jira.
We had to uninstall github for jira and then reinstall it. And now everything works as it should.
Would have been nice if this hadn't been needed.

+1
I also uninstalled and installed Github for Jira, but I still get the 'Create branch link expired' error..
The issue started happening to us today. Any updates?

Hi this should be fixed now. Can you try again? Thanks.

+1
I also uninstalled and installed Github for Jira, but I still get the 'Create branch link expired' error..
The issue started happening to us today. Any updates?

Hi this should be fixed now. Can you try again? Thanks.

Works now. Thanks :)

We have added additional changes that should support this issue , hopefully this resolves any outstanding problems for this particular problem :)


Service role added

Added service engineer role description.
this is a (very) rough first draft

Not sure if we want to add here formal requirements:

Good communication skills in Dutch and English (German is a plus)
Good understanding of WIndows OS environment.

Not sure if we want to add here formal requirements:

Good communication skills in Dutch and English (German is a plus)
Good understanding of Windows OS environment

I think those things are worth mentioning, as they are base skill requirements.

@SjorsJansen @robend any additional input from your side?


Can we have scalable responsive progress bar

Can we have scalable responsive progress bar
Progress bar which can load on json data having some text for each stage, and should display current stage of the progress with highlited color

Please use the issue template for feature requests or else this will be closed.

This is likely a component we will not create as it does not fall within the material design spec.  However, you should be able to use the current mat-progress-bar within a custom component you create to perform the desired function.
In the future please use the issue/feature request template provided.


BiocAsia2021 sticker

@LiNk-NY created the sticker for BiocAsia2021.
See https://github.com/Bioconductor/BiocStickers/issues/148#issuecomment-752842413
(Thanks @LiNk-NY )

I'm sorry @LiNk-NY. I reopened this issue.
I became more aware of the "message" of BioC Asia 2021 as I have discussed with the plan of it.
The message is "overcoming the lanuguage barriers".
Therefore, I came to want to add an expression that suggests "diversity of languages" in addition to "Japan" to this sticker.
Therefore, I am very sorry to you (@LiNk-NY), but I will also propose a sticker at https://github.com/Bioconductor/BiocStickers/issues/148#issuecomment-752842413 .
I am sorry to ask you a favour.

@LiNk-NY Please allow me to confirm with the sticker imported into BiocStickers. (https://github.com/Bioconductor/BiocStickers/tree/master/events/BiocAsia2021)
I'm sorry I couldn't reflect all your requests. (https://github.com/Bioconductor/BiocStickers/issues/148#issuecomment-907249339)

Thank you for doing that.
No worries!
All the best,
Marcel


ffmpeg: 6.0 -> 6.1

Description of changes

➡ ffmpeg 6.1 release notes
ℹ I had to run nix shell nixpkgs-dev#ffmpeg-headless (where nixpkgs-dev points to a local clone of this repo) several times before the ffmpeg was built. This was due to test failures in the llvm and libopus package.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

ffmpeg-6 (and the -headless and -full) variants compile for me on x86_64 NixOS, due to lack of some nvidia library:
ERROR: cuvid requested, but not all dependencies are satisfied: ffnvcodec

duplicates #270429


tests: mem_slab: disable test on qemu_x86_coverage

This test is getting stuck on this platform on 30% of PRs, disable
for now while we investigate

is this still needed?


Incompatibility with aws-cdk >= 2.167.0

Due to a change in the used JavaScript AWS SDK from v2 to v3, newer aws-cdk versions (2.167.0) are currently incompatible and will produce an error like this:
 ❌  Environment aws://000000000000/us-east-1 failed bootstrapping: InvalidClientTokenId: The security token included in the request is invalid.
...

We're working on a fix to make newer versions compatible with LocalStack.
In the meantime the last compatible version of aws-cdk is 2.166.0.
We'll update the issue here once this has been resolved!

Same issue for here, this is the error that gets reproduced.
 ❌  Environment aws://000000000000/us-east-1 failed bootstrapping: Error: read ECONNRESET
    at TLSWrap.onStreamRead (node:internal/stream_base_commons:216:20) {

Downgrading aws-cdk to<EMAIL_ADDRESS>works as mentioned in the bug title.
npm install -g aws-cdk-local<EMAIL_ADDRESS>

We've published an updated version to NPM now. Please upgrade to aws-cdk-local>=2.19.0 for support for aws-cdk versions >=2.167.0


Auto-format files with prettier, add vscode settings, fixes #281

The Issue

https://github.com/ddev/ddev.com/issues/281

How This PR Solves The Issue

added .vscode/settings.json and .vscode/extensions.json to git
performed npx prettier --write . to auto-format all files
added github action prettier test (npx prettier --check .) to test.yml to block wrongly formatted PRs in future
added new section about Prettier and EditorConfig to README.md

Manual Testing Instructions
Review rendered at https://pr-format-prettier.ddev-com-front-end.pages.dev/

check build output and subpages for errors

Automated Testing Overview
Maybe use https://ddev.com/blog/ddev-diffy-introduction/ for visual comparison? haven't had time for that yet. https://github.com/garris/BackstopJS is an open source alternative
Related Issue Link(s)

https://github.com/ddev/ddev.com/issues/281

Release/Deployment Notes

Thanks!  A quick look around on https://pr-format-prettier.ddev-com-front-end.pages.dev/ didn't show trouble.

I briefly checked some blog posts and didn't notice any errors/bug as well.
Good to go from my side 👍

https://8c9417f6.ddev-com-front-end.pages.dev//resources/featured-sponsors-darkmode.svg
https://8c9417f6.ddev-com-front-end.pages.dev/resources/featured-sponsors.svg
https://pr-format-prettier.ddev-com-front-end.pages.dev//blog/rss.xml
Those 3 seems to be working as expected and I did not find any glaring issues while browsing around. It's all good from my side.

Let's see how we do with this. Thanks @mandrasch !


Stokes I tqdm fix

Fix for #93
I'll note that fitting now seems very slow (with or without tqdm). Something might have gone wrong in the rollback @Cameron-Van-Eck

I think the change in speed may be due to changes I made in the default settings rather than anything in the code itself.
Previously the default was to use 10 cores. I'm a bit leery of making the default to grab so many cores, since I worry about if there's any risk of problems for users who run the defaults in an environment where they can't (or aren't supposed to) grab all those cores. So I changed the default from 10 to 1, so that users who actually look at the flags can increase it to any value they consider appropriate.
I'm not sure the change of reading in the full data cube initially will change much -- in the tests I was doing this morning, it was pretty steady at 100% CPU use, so I don't think it's IO bound?

Hmm strange. I was bumping up the ncores from the CLI. All processes were sitting around 60% or less. Could be an IO issue on my end. Would be able to test on on your end?

I've tested on my laptop. Good news: tqdm is running fine with the multiprocessing, so that issue is solved.
Neutral news: run time is about the same as the old progress bar (but it's good to have the same one used across the whole package).
I don't have a strong sense of how long it took to run before, so I can't notice any differences in speed. I only reverted to the most recent pre-tqdm version of this tool, so unless you did something to speed it up during the tqdm switch-over, I can't see how the speed would change, other than me messing with the default parameters. Aside from the change in default number of cores, I changed the default threshold from positive (absolute flux threshold) to negative (sigma-thresholding). That may add a few extra calculations, but I wouldn't have thought it would be many.
I think we're good to merge this in, unless you want to test some more things?

Ok cool - Yeah I think the speed is a separate issue! I'll keep playing with improvements if I can. One big thing is that I think passing the whole cube to each worker is a big slow down.


Delayed update

I have two Xiaomi devices running Kiwi: on the newest, running Android 12, Google Play updated Kiwi to 111 about 1 week ago; on the other, running Android 10, rooted, I had some Kiwi updates via GP in the last days, but version ia still 107.
Why?

It seems Kiwi has some problem with updating via Google Play again. Google Play show me 107 fom fall last year, Apkmirror has 111 for download.

What device / androif version do you have?

I have both a Galaxy S21 FE as well as an old Nokia 5, the issue persists on both devices. It may be the same issue again that Playstore in some regions is not updated, like we had with the German Playstore in the past (see issue https://github.com/kiwibrowser/src.next/issues/650)

thanks, updated via apkmirror

update in GP came today


Names sometimes display in wrong script/language

This issue seems to be coming from the bibcard API and displaying in the Primo author card, so I'm not sure if this is the correct repo for reporting. But we've noticed in test implementations that some author names are returning results in other languages/scripts. Examples include F. Scott Fitzgerald (http://viaf.org/viaf/100254195, Arabic), James Joyce (http://viaf.org/viaf/44300643, Arabic), and Walt Whitman (http://viaf.org/viaf/2478331, Cyrillic). Running the names directly through the bibcard API returns the same result.

Hi @jpastva - thanks for reporting your issue! It seems that the language handling is not quite working for LC requests. I've removed the language from the request and it seems to me to work better (checked on a full record in our test instance)
Can you let us know how it looks from your side?

@jweisman I tested the above mentioned authors, and the names are now returned in the expected script. I'll keep an eye out for any other unusual behaviors, but it looks like you fixed it. Thanks for the quick response, we're looking forward to implementing this!

Good to hear- thanks for the feedback. Let us know if you see any other strange behavior.


Extract to component is broken

Hi Team
Extracting a piece of jsx takes forever to ask for the path then some more secs to ask for the file name and does it, does not do anything else, does not create the file

Hey @acostaf.
What's your OS?

Can you post the origin file and the snippet you are trying to extract?

@acostaf can you please post the whole file? Is the repo public?

Hey @borislit, interestingly Extract Component never worked for me either (installed glean a last week). I just created a new react app to test, but its still broken.
Basically it creates and empty file but never moves the code.
Can you describe steps to reproduce the issue, the origin code and the snippet you are trying to extract?


story: provide lean context config

We want to provide defaults for the lean context.
We will do this programmatically by creating a function isLean, which checks whether the <html> element has the sbb-lean css class.
The default value for the relevant properties is set that way: public accessor size: 's' | 'm' | 'l' = isLean() ? 's' : 'm';

I would say no for now, even if it is an inconvenience. My goal would be to define the default via CSS and not via js, but that would probably be part of the css refactoring.

Ok, then I can open a draft pr 👍
another question: do we need some kind of testing/visual testing/something for Manuel?
eg. on Storybook the default is usually overridden, so i have tested the behavior only via console;
should I created a home-lean demo page? or specific stories for each component that I changed?

Hm, maybe as you suggested a home-lean demo page? I think that should be enough for now.


A mix of real bugs and build warnings fixes

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


date: Adds support for datetime for parameter -d

This resolves issue #5177.
The PR adds a new enum  HumanDuration(Duration), HumanDateTime(DateTime) and uses  parse_datetime::parse_datetime::from_str  to support datetime if relative time cannot be parsed.
For example we can now parse date -d "@0", date -d "1992-02-12" and date -d "2012-01-01 14:00".
Furthermore tests are added for tests/by-util/test_date.rs.

Cool! I don't think we need 2 variants. Basically parse_datetime should always return a DateTime. If it parses a relative time, it should add that to the current time.

@tertsdiepraam thank you for your comment, would you recommend to change  parse_datetime so it accepts relative time? I can do that, just want to confirm first.

In theory yes, but there's a lot happening there already. Let's start here to get the issue fixed and look at getting that change to parse_datetime later. Does that sound good?

@tertsdiepraam okay, so you want me to fix the comments by the bot for now only?

Hmmm, actually you're right. I didn't think this through. Yes, parse_datetime should do both absolute and relative in one function. Sorry for the confusion :)

@tertsdiepraam okay no problem. Thanks for clarification.

Looks like touch is failing because the new parse_datetime version. I think we could make touch depend on a separate version and then fix that in another PR. cargo deny will complain, but we can temporarily add parse_datetime to the deny.toml list of ignored crates to fix that.

No activity for a while, closing!
Feel free to reopen when ready


Is the libray support translation between Ed25519 and Curve25519?

Hi, thanks for the library, a great implementation of Ed25519.
I'm try to find a way to convert Ed25519 public key(or private key) to Curve25519, like libsodium here.
https://github.com/jedisct1/libsodium/blob/927dfe8e2eaa86160d3ba12a7e3258fbc322909c/src/libsodium/crypto_sign/ed25519/ref10/keypair.c#L46-L83
The API of 2 library has lots of differences, could you please give some suggestions about this?

No need for this, so close this.


Skeema pull on a table with system versioning

Describe the bug
When I run skeema pull, a table with system versioning is not being generated (the .sql file is deleted if it is already there)
Environment

Skeema version: [v1.9.0]
Database vendor, version, OS/platform: [MariaDB 10.6.10 running on AWS]

To Reproduce
Maria db with at least one table that has system versioning on;  run skeema pull;  see if that table is in the .sql files created
Expected behavior
That table should be in the list, and the sql for the create should include the system versioning information
Additional context
I did find this in your documentation (copied below), but it doesnt' really describe the behavior I am seeing.  Do I need to add an option with the skeema pull?  Can you tell me why it may be skipping this table altogether?
From your website:
Unsupported for ALTER TABLE
Skeema can CREATE or DROP tables using these features, but cannot ALTER them. The output of skeema diff and skeema push will note that it cannot generate or run ALTER TABLE for tables using these features, so the affected table(s) will be skipped, but the rest of the operation will proceed as normal.
spatial indexes
sub-partitioning (two levels of partitioning in the same table)
general tablespaces (explicit TABLESPACE clauses other than innodb_system or innodb_file_per_table)
*MariaDB’s system versioned tables / bitemporal tables / application time periods
some features of non-InnoDB storage engines
You can still ALTER these tables externally from Skeema (e.g., direct invocation of ALTER TABLE or pt-online-schema-change). *Afterwards, you can update your schema repo using skeema pull, which will work properly even on these tables.
(this is what I did, updated it outside of Skeema; but when I did the pull the file disappeared altogether.  I tried adding a new table with system versioning, and the table did not get a .sql file on the skeema pull)
THANKS!

Thank you for the report. Please see #187 for the root cause: despite using CREATE TABLE syntax, system-versioned tables have a nonstandard value in information_schema.tables.table_type, so Skeema effectively does not see them at all when it queries information_schema.tables to see which tables exist.
You're correct that the Skeema docs are mistaken on this point, sorry about that. They've been updated now to reflect the current situation: system-versioned and bitemporal tables are ignored entirely, whereas tables using application-time periods aren't supported for diff/push but do show up in init/pull/format.
Closing since the feature request for system-versioned tables is tracked in #187. Unless the level of demand for system-versioned tables increases (especially among Skeema Premium users), the most likely path forward would be either a pull request (if a third party company can implement the support end-to-end) or a sponsored development contract (if a company is willing to pay for the necessary dev time).

btw if you want to create the .sql file manually while also preventing skeema pull from deleting it, ignore-table should hopefully work properly for that use-case, but I haven't tested with this particular scenario of system-versioned tables.

Minor quality-of-life improvements for system-versioned tables in today's release of Skeema v1.11.1:
Upon encountering a CREATE TABLE ... WITH SYSTEM VERSIONING statement among the *.sql files, Skeema will now log a warning, and will otherwise ignore the table (same behavior as if it had matched the ignore-table option). This means skeema pull will no longer delete the CREATE statement from the file.
Otherwise though, system-versioned tables (including bitemporal tables) are still completely unsupported, and won't even be introspected or dumped from the server. No ETA for a fix yet, but this remains a good potential area for a community PR.


theme color don't on macOS Mojave

theme color don't on macOS Mojave

Now work fine after reinstall