Hotelator Frontend: Full site and functionalities + Styles.

Hi dear reviewer, welcome to our final project, @Kumilachew-g, @Tadessejemal1 and I (@angeluray) are more than happy to receive your feedback ✋🏼
Project progress check ✅

Project team member roles established for each member, and divided tasks in a fair way.
Followed communication skills, and multiple meetings throughout the week for checking overall progress.
Created ERD.
Created a Rails API-only project, with its controllers, models, and routes.
Created API documentation in a human-readable way.
Deployed API successfully.
Integrated API with React project.
Added the Logo of the application(this works as a back button as well)
Added registration feature.
Added the user logs in to the website feature using email and password.
Added navigation panel, so the user can see links to:

Hotels that we selected as a theme.
"Reserve" form.
"My reservations".
"Add hotel" (the link is visible to everybody).
"Delete hotel" (the link is visible to everybody).

Added a main page component that displays all hotels available.
Added Detail and Detail form component for allowing users to click a Hotel, see the description, and reserve from that page. (If the user makes a reservation from details, the city and the hotel are already pre-filled in the form)
Added the My reservations component to show all the reservations made by a user.
Added Reserve component to reserve a Hotel, where based on the city/country that you select you will be able to see all the hotels available.
Added Add and Delete hotel component, when the user clicks the "Delete hotel" link in the navigation panel they can see a list of all items with title and "Delete" button, and when the user clicks "Add hotel" a new form is displayed with the user input prefilled. Users can create a new one by adding city, hotel, room type, and date.
Added linters and made sure that everything woks correctly.
Changes made doing remote work, asynchronously.
Created README file.

Frontend repository pull-request ✅

Hotelator frontend pull-request

Note: This project would still be a work in progress for us, since being a developer means improving our current piece of work and making it better, and more efficient. All your feedback will be appreciated 💯, thank you for taking the time to review the project.

Added tests for components based on the review.


LangVersion in solution with C# and VB projects

The docs mention using a Directory.Build.props file to configure the LangVersion of multiple projects. However, in a solution with both C# and visual basic projects, the possible LangVersion values for C# are incompatible with those for VB. For example, if I try setting the C# LangVersion to 8.0 (which is required to enable NRT in .NET framework), I will get a build error in the VB projects.
It would be nice if the docs could mention this possible issue, and provide a solution if one exists. For example, is there a condition that can be placed on the PropertyGroup that only evaluates to true for C# projects?
As a workaround, I put all VB projects in a separate directory with an empty Directory.Build.props file.
Relevant docs:
https://github.com/dotnet/docs/blob/26e2e8bedfa72ae518de2b7e617850dd2c6d9d77/docs/csharp/language-reference/configure-language-version.md#configure-multiple-projects
https://github.com/dotnet/docs/blob/26e2e8bedfa72ae518de2b7e617850dd2c6d9d77/docs/visual-basic/language-reference/configure-language-version.md#configure-multiple-projects
edit by @billwagner: Add document block.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 5694e62b-c756-1f62-4014-2ceafa54c011
Version Independent ID: 3f01c378-22e4-197c-a862-ab4a924506c7
Content: C# language versioning - C# Guide
Content Source: docs/csharp/language-reference/configure-language-version.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

closing and reopening to run the labeler


Update limit order bot vyper contract for uniswap v3 variants

Background
We want to launch limit order, momentum, stop loss and dca bots for uniswap v3 variants.
Done when
https://github.com/VolumeFi/limit-order-bot-vyper-uniswap-v3

[ ] Vyper smart contract is updated to check the message sender
[ ] Vyper smart contract has  relevant fixes that were done for limit order bot v2  (except for charging fees as that will be done separately)

@webelf101 is this done?


Add changelog for v0.7.2 (#1617)

Issue #, if available:
Description of changes:
Manual cherry pick of #1617
Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm


feat(entity): add support for pagination in query entities #388

@bobeal can you check this commit to return allowed entities as per the specific access policy.


Adds support for new Gopro hero format.

This is great, thanks!

@sebnil It looks like there is a third prefix 'GX' for HEVC encoding in the newer models. I have added this in a07edaf05327d1ae7d1a2d4be8c53e6a5f070c81.

No worries! Just strange that GoPro names their files in this roundabout way.


Update location of coco2jsonl conversion script

Moved to new location in the azureml-examples repository as reflected in the above change

@vadthyavath
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off

The link for the conversion script was already updated in another PR, so we'll close this one. Thanks!


[python] Add the switch to disable server interactions

Problem
Commissioning with Python script on raspberry pi might fail due to failure of BLE connection establishment.
This is an issue of Raspberry Pi's BT & WiFI CoEx.
Change overview
This PR adds a switch to disable server interactions, which will reduce mdns traffic on WiFi interface.
Testing
Manaully tested with Raspberry Pi

Approved for 1.0: platform specific change (python) and fixes testing support on raspberry pi. code does not affect SDK functionality.


Email Alias not up to date with membership list

https://github.com/nodejs/email/blob/master/iojs.org/aliases.json#L108-L115
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
vs
Bryan Hughes (nebrius - Community Committee Chair)
Jenn Turner (renrutnnej - Community Committee Secretary)
Tierney Cyren (bnb - Community Committee Secretary)
Ashley Williams (ashleygwilliams)
Emily Rose (Amorelandra)
Gregor Martynus (gr2m)
JP Wesselink (jpwesselink)
Michael Dawson (mhdawson)
Myles Borins (MylesBorins)
Rachel White (rachelnicole)
Tracy Hinds (hackygolucky)
William Kapke (williamkapke)
Michelle Garrett (msmichellegar)

It was created stemming from: #89
Only those that chimed in were added to the list. I wasn't added because I missed the moment.
Fix: https://github.com/nodejs/email/pull/61

FWIW, we were not able to get the emails of everyone on the list. Just submitted: https://github.com/nodejs/community-committee/pull/126

Created a PR for @jpwesselink at https://github.com/nodejs/email/pull/68  - only need to add @msmichellegar now 😁


Fix transformations between normal and lognormal parameters

Fixes a math error in calc_normal_style_pars_from_lognormal_pars.

[x] Tests for new functionality/models or Tests to reproduce the bug-fix in code.
[x] Update CHANGELOG.md with major/minor changes.

Codecov Report

Merging #1076 (acdb2c1) into master (b36b8f8) will increase coverage by 0.07%.
The diff coverage is 90.74%.

@@            Coverage Diff             @@
##           master    #1076      +/-   ##
==========================================
+ Coverage   73.60%   73.68%   +0.07%
==========================================
  Files          68       68
  Lines       10477    10487      +10
==========================================
+ Hits         7712     7727      +15
+ Misses       2765     2760       -5

Impacted Files
Coverage Δ

HARK/distribution.py
82.98% <82.75%> (+1.21%)
:arrow_up:

HARK/tests/test_distribution.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b36b8f8...acdb2c1. Read the comment docs.


Support for Host totals

document : https://docs.datadoghq.com/api/?lang=bash#host-totals
GET https://api.datadoghq.com/api/v1/hosts/totals
Example Request
api_key=<YOUR_API_KEY>
app_key=<YOUR_APP_KEY>

curl -G "https://api.datadoghq.com/api/v1/hosts/totals" \
     -d "api_key=${api_key}" \
     -d "application_key=${app_key}"

Example Response
{"total_up":1750,"total_active":1759}

Implemented in https://github.com/zorkian/go-datadog-api/pull/267 - closing this issue now.


Move file write responsibility from Compiler to main

It'll be pretty hard to integrate into other repositories if the output is always called "output.cpp" :^)

hmm this isn't baked enough. Needs a default binary dir.

There we go. Now with yoinking a command line parser library to parse out --binary-dir or -o, and defaulting to $PWD/build.

Hello!
One or more of the commit messages in this PR do not match the Jakt code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

It werks! :^)


bech32, cardano-{address,tx} release executables don't work on macOS without nix

Context
https://input-output-rnd.slack.com/archives/GBT05825V/p1599837130089800?thread_ts=1599834710.084500&cid=GBT05825V

Information
-

Version
multiple ?

Platform
macOS

Installation
Github Release

Steps to Reproduce

Download and extract a release archive
otool -L ./cardano-address (and cardano-addres, bech32)

Expected behavior
The dylib paths are relative to @executable_path, like for cardano-wallet
./cardano-wallet:
	/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1226.10.1)
	@executable_path/libz.dylib (compatibility version 1.0.0, current version 1.2.11)
	@executable_path/libsodium.23.dylib (compatibility version 27.0.0, current version 27.0.0)
	@executable_path/libiconv.dylib (compatibility version 7.0.0, current version 7.0.0)
	@executable_path/libgmp.10.dylib (compatibility version 15.0.0, current version 15.0.0)
	@executable_path/libffi.7.dylib (compatibility version 9.0.0, current version 9.0.0)

Actual behavior
otool -L ./cardano-address
./cardano-address:
	/nix/store/f573hx6rga70hx5xjqrvqa58jkdxdl91-Libsystem-osx-10.12.6/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1226.10.1)
	/nix/store/p95rm5rlv4fmi0k81nr0l29ax57dw1r0-zlib-1.2.11/lib/libz.dylib (compatibility version 1.0.0, current version 1.2.11)
	/nix/store/m3yqw7xcmhvd0cmm3jh3b469kxf3yhfp-libiconv-osx-10.12.6/lib/libiconv.dylib (compatibility version 7.0.0, current version 7.0.0)
	/nix/store/hrmqighslwzk32rmz00k1lw5k53f5jr3-gmp-6.2.0/lib/libgmp.10.dylib (compatibility version 15.0.0, current version 15.0.0)
	/nix/store/w1v69v7w418nvsc3rxndp4cq59110bzj-libffi-3.3/lib/libffi.7.dylib (compatibility version 9.0.0, current version 9.0.0)

Reported by @piotr-iohk to cause the binaries to be un-runnable on a macOS without nix installed.

Resolution

QA

@rvl I guess we need something like this
https://github.com/input-output-hk/cardano-wallet/blob/b83fcc428276e39f3970cfa4602a29209d82ec7b/nix/package-cardano-node.nix#L35
for what was added in https://github.com/input-output-hk/cardano-wallet/pull/1857


help with including the library

how can i use this library in google chrome console
or seleniem
as I am a c# programmer

Are this still relevant ? if not can you close your issue please ?

Are this still relevant ? if not can you close your issue please ?

not fixed yet

not fixed yet

firstly why do you need to run it in a browser ?

firstly why do you need to run it in a browser ?


Allow Deletion of Invalid Index

Currently if an index fails to load it can not be deleted.  Force a delete from the database if it fails to load.


Report metrics for suggest anomaly detector

Description
This PR implements a small enhancement for the suggest anomaly detector feature, we add feedback button to the flyout of suggest anomaly detector, when users click the button, it will call the metric report API in the core plugin usageCollection. And when LLM gives suggested parameters successfully, a generated metric is reported, when the suggested detector is created, a created metric is reported.
Another change is that we check the feature flag before register the SuggestAnomalyDetector action to Discover, if the feature flag is disabled or the whole assistant capability is disabled, no action will be registered.
Some UI change:

Issues Resolved
https://github.com/opensearch-project/anomaly-detection-dashboards-plugin/issues/816
Check List

[x] New functionality includes testing.

[ ] All tests pass

[ ] New functionality has been documented.
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jackiehanyang ,please help to review this PR when you're available, thanks, this change doesn't target for 2.17.

@gaobinlong thanks for the change! Just curious, besides this feedback button, are we collecting usage metrics for this flyout? For example, the number of detectors created via this flyout, or errors that occurred on this flyout.

@gaobinlong thanks for the change! Just curious, besides this feedback button, are we collecting usage metrics for this flyout? For example, the number of detectors created via this flyout, or errors that occurred on this flyout. If not, do we have plans to add these business metrics?

Thanks, except the feedback metrics, we already add generated metric which reports that LLM has given the suggested parameters successfully, and created metric which reports that the suggested detector has been created successfully, but we haven't collect the failures metrics for this flyout, I'll consider this suggestion seriously and implement it later.
reportMetric(SUGGEST_ANOMALY_DETECTOR_METRIC_TYPE.GENERATED);
reportMetric(SUGGEST_ANOMALY_DETECTOR_METRIC_TYPE.CREATED);


Revised per comments from Piyush

@alkohli

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Changed save button on edit resource options to reload iframed page [#100175262]

Adds an optional redirect_to url parameter to the external resource edit url that if present is used as the redirect url on a successful save instead of the external resource show page.  The short form then sets this value to the iframed edit page when the popup is loaded.

If this reloads the iframed page, then I think that might result in lost work. If an author is editing a section and then decides to click that button. Can you make it work so the iframe is not reloaded and the dialog is just closed?

The only way to do it would be to switch the popup contents to an iframe - right now it is a overlayed div.  The same redirect logic would work - it would just redirect to a new page that would call a function in the parent window to close the popup.

Couldn't you use js to submit the form and then close the dialog? So no
redirects are need. Rails has "remote_form_for" that handles submitting the
form with js.
--
from my phone
On Aug 7, 2015 5:20 PM, "Doug Martin"<EMAIL_ADDRESS>wrote:

The only way to do it would be to switch the popup contents to an iframe -
right now it is a overlayed div. The same redirect logic would work - it
would just redirect to a new page that would call a function in the parent
window to close the popup.
—
Reply to this email directly or view it on GitHub
https://github.com/concord-consortium/rigse/pull/137#issuecomment-128836333
.

Closing after pushing up a different PR to fix the issue.


tools/image-info: don't convert raw images

After change to image-info [1], which shows the format version for qcow2
images, the image-format changed from string to a dictionary. However
the open_image() function still compares it with string. This causes
raw images to be converted by the script again to raw format. This
change fixes the issue, so that raw images are not converted, but used
as they are.
[1] https://github.com/osbuild/osbuild-composer/commit/5937b9adca96ea4ffcb0865c75ca3e80c5b9b100
Signed-off-by: Tomas Hozza<EMAIL_ADDRESS>This pull request includes:

[ ] adequate testing for the new functionality or fixed issue
[ ] adequate documentation informing people about the change such as

[ ] create a file in news/unreleased directory if this change should be mentioned in the release news
[ ] submit a PR for the guides repository if this PR changed any behavior described there: https://www.osbuild.org/guides/

The integration tests in Schutzbot failed due to unavailable resources in GCP, the change is not related to GCP in any way. The rest passed. The Gitlab CI "almost passed", there is just the Base: aws/rhel-8/aarch64 test pending and it gets stuck every time I restarted it. I would call the CI a PASS and merge this fix...


Codestyle fixes

Fixed based on the output of the static code analysis (redundant usings, vars)
No functionality changes

this is really nice, but, can we do it more slowly?
Please start with projects that no one is working on, so that the other devs don't have to do too many merging.
I hope this has been done automatically. If it hasn't not, I'll review it as is.

Closing since it makes sense to split this PR into several small ones that cause less disruption


instead of filtering errors, mark them as unfixable

Instead of filtering unsupported errors can we mark them as unfixable so that we can still see what they are?

Done.


MaxListenersExceededWarning with many connections

I am receiving these error messages when there are many connections to the service:
(node:55048) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 close listeners added to [Socket]. Use emitter.setMaxListeners() to increase limit
(node:54039) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 unpipe listeners added to [Socket]. Use emitter.setMaxListeners() to increase limit
(node:54039) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 drain listeners added to [Socket]. Use emitter.setMaxListeners() to increase limit
(node:54039) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 error listeners added to [Socket]. Use emitter.setMaxListeners() to increase limit
(node:54039) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 finish listeners added to [Socket]. Use emitter.setMaxListeners() to increase limit

Here is the code I am using:
var net = require('net')
var frame = require('frame-stream')
var port = 8888

var leader_node = null

function send_to_leader(message) {
  var encode = frame.encode()
  encode.pipe(leader_node)
  console.log('sending response:', message)
  encode.write(message)
}

function on_close(socket) {
  console.log('connection closed')
  if (socket == leader_node) {
    leader_node = null
  }
}

function on_message(socket, message) {
  console.log('new message:', message)
  ...
  send_to_leader(message)
}

net.createServer(function(socket) {
  socket.pipe(frame.decode()).on('data', function(buf) {
    on_message(socket, buf.toString())
  })
  socket.on('close', function() {
    on_close(socket)
  })
}).listen(port, function() {
  console.log('server ready!')
})

Is my code wrong? Does frame-stream support many concurrent incoming connections?

Hi @kroggen. Try creating only a single encoding frame stream for leader_node.

Hi David,
It worked!
Thank you for your help! =)


Problems reverting doPrint with fromArray

I'm trying to cache schema, first I made an SchemaPrinter::doPrint but when try to restore it using AST::fromArray everything goes well but query return an error.
This is my schema generation class, there you can see the generation and later restore process, also schema exported file.
This is the output when use cache schema
{
    "errors": [
        {
            "debugMessage": "Cannot return null for non-nullable field query.search.",
            "message": "Internal server error",
            "extensions": {
                "category": "internal"
            },
            "locations": [
                {
                    "line": 5,
                    "column": 5
                }
            ],
            "path": [
                "search"
            ]
        }
    ]
}

Any idea?

When printing schema, resolvers are unset. You should reassign them in the typeConfigDecorator


test(pubsub): add tracing enabled tests for blocking publisher

Part of https://github.com/googleapis/google-cloud-cpp/issues/13250

This change is

use old admin client

Q. Why is that a feature?

Not a feature... maybe a bug. It builds with the handwritten admin api but not the generated one.

use old admin client

Q. Why is that a feature?

Not a feature... maybe a bug. It builds with the handwritten admin api but not the generated one.

Maybe this:
https://github.com/googleapis/google-cloud-cpp/blob/c4633e735d7277cd18c6b0babf9160c6f76c329e/generator/generator_config.textproto#L2603-L2621
is missing one of these?
https://github.com/googleapis/google-cloud-cpp/blob/c4633e735d7277cd18c6b0babf9160c6f76c329e/generator/generator_config.textproto#L2628

Gonna revert the commit on https://github.com/googleapis/google-cloud-cpp/pull/13241, and update the PR after this is merged


Improvement: element positioning on page

Description
Elements are currently hard coded in their positioning which prevents the implementation of new panels (like the shortcut panel)

Width of the different panels needs to be consistent between each other
Graph should be visible under the panel
Graph should be interactive on all areas that are not covered by panels (beside gap between panels)
When too many panels are on screen to be displayed, it should be possible to scroll to see the hidden panels

Great thoughts and suggestions, backing 100%.

Addressed with #54


API v1: how to get all environments?

When using an Environment keypair, https://rancher.url/v1/projects returns a collection where the data array contains all the environments.
When using an Account keypair (hoping to list all environments), the data array is empty.
This happens when issuing cURL calls to the API (or via superagent). In the browser, the data array is populated as expected.
Is this a bug, or am I doing something wrong?

With an API key belonging to an environment (project), the only project it is authorized to is itself so /v1/projects is always a collection of 1 project.
With a user/account key, the response is the 0 or more projects which the user is a member of.  This is shown in the UI as the Environment dropdown choices.
If the account is an admin, you can additionally add ?all=true to get back all (unremoved) projects instead of just the ones you're a member of.  This is shown in the UI as the manage environments screen.

@vincent99 Thank you, ?all=true was the trick.
My account is an admin, but project membership is not explicit - we use GitHub teams for access control. This probably why I wasn't getting any environments back.

Github teams membership should work, with the caveat that the account has to have logged in through the UI once to get it's github auth token put into place.  If the account has never logged in then we won't be able to get info about the user's teams/orgs.


Refactoring Dimensioned objects for uniform API

This is a major refactor of HoloViews to provide a common interface for multi-dimensional objects in HoloViews. For that reason it touches almost every aspect of HoloViews. While all the notebooks now work and the unit tests have been updated a number of features have not been fully tested or still need to be updated, this includes:

Titles
Legends
Reduce, sample, collate
Support for value dimensions in the Pandas interface

Ok. I'm happy with all this. Lots of changes but I do think it will be worth it!


How  to use version_8.2.0   Web Browser Collects Data

Please answer these questions before submitting your issue.

Why do you submit this issue?
[Question ] Question or discussion
[ ] Bug
[ ] Requirement
[ ] Feature or performance improvement

Question

What do you want to know?

Bug

Which version of SkyWalking, OS and JRE?

Which company or project?

What happened?
If possible, provide a way to reproduce the error. e.g. demo application, component version.

Requirement or improvement

Please describe your requirements or improvement suggestions.

Why are you keeping submitting duplicate issue? Search first.


User status always stays onlkne

User status always says online (green) even the user is idle or offline.

I can confirm that. I do show correct status in the members list but in the sidebar menu it shows wrong status for each user.

@mmarif4u Do you still get this issue on the sidebar? It's supposed to be solved already. If you are experiencing this specific issue I'd like to ask you to open another issue describing how to reproduce it.

@ccfiel I had myself this issue with one of my test users. It got stuck on the online status. It's on the queue to investigate but I suspect something went really wrong on server-side. I'll be talking to the guys as soon as I can about that.

@leonardoaramaki i can create another issue if needed, but i feel it is the same issue which i just noticed too. Example screens for your ref.
The member list shows almost correct statuses excluding one(mine) which is yellow, which is suppose to be green(see the next screen).


[Documentation] Archive package is documented on https://api.flutter.dev but not exposed by SDK

I needed to unzip a file for in a Flutter app. Googling led me to this Flutter API documenation yet it seems that the archive library is not actually exported inthe public Flutter SDK?
I then realised I needed to make use of the archive package from pub.dev but it was quite a confusing experience, even as an experienced Flutter dev.
It would be nice if the Flutter API docs didn't include libraries that aren't made available by the SDK or maybe even better make the archive package be an export by the SDK, but I guess that takes on a big responsibility for the SDK making it a supported public SDK API.

Hey @sfshaza2, any ideas who we should poke on this? I'm assuming this is generated somewhere. I believe we shouldn't be exposing APIs that are implementation only, but it may be hard to figure out what is implementation vs what is exposed.
Thoughts?


[WIP] Add routes rake task to display annotated routes

This PR adds in a rake task to render out a list of annotated routes using roda-route_list.
The task itself currently does a number of things and I have left it as a single procedure so we can discuss what is happening without having to look in multiple places.
Example annotation:
# route[optional_name]: GET|POST /segment/:param
Example output:
              Name Methods   Path
             admin GET, POST /admin
     example_route GET       /example
        blog_posts GET       /posts
         blog_post GET       /posts/:id
blog_post_comments GET       /posts/:id/comments

Nice work getting this in place, @dNitza! Solving this has been something that's been nagging at me for a while (look at the timestamp on #5!).
I remember trying roda-route_list way back in the day and feeling dissatisfied with how it had to use a file to store its data. I felt like this would let things get out of sync. But I guess Jeremy Evans has probably thought this through a little more than me and since this plugin exists, we should actually commit to trying it for a while 😄
If we're going to do this, then I think there are a few other things we should handle:

Actually put the route list plugin into our sub-apps, so we can use the listed_route helper in our routes for redirecting, etc.
Allow access to this listed_route helper through a dry-view context object (you'll need dry-view master for this right now), so that we can generate routes from inside our templates (which is where we need it half the time).

Then, as a bonus, something like this would be nice:

Make a smarter, more convenient route builder that allows us to pass whole objects to it, so we can e.g. pass a "product" to a product route helper, and it'd generate a URL using both product.id and product.slug as required

I should note that this actually lines up with one of the things I suggested @solnic tackle as he gets started this week. @solnic, this issue might be worth checking in on :)

Oh neat! Yeah the file thing was a bit weird to me too which is why I didn't look into listed_route much more. I think if we wanted to use that helper for navigation within our apps, we would need to regenerate the routes list .json each time we boot / deploy / make a request in dev mode. But, I think if we can tackle the syncing issue (especially in dev), then yeah, I think that taking advantage of listed_route in our routes is a great way to go.


NaN values with low amount of data points

The dashboard needs a little work. I have no idea how it is possible to have 0% accuracy on 56 readings.

Also, the number of data readings stored is always directly below the first character. This look great until you name a room something large. I.e. Beer pong room. Then the number of data readings directly overlap the accuracy readings.

I am doing a few experiments using different families. The kttest family is one of the smaller data sets. The https://cloud.internalpositioning.com/view/dashboard/knewtek_test family is the experiment where I put the phone on a roomba to wonder each of the rooms. The knewtek_test family has plenty of data points (18971 currently). I mentioned the kttest family because that was the one that I could show the bug that I found.

@Thomas499 I'm not sure that this is a bug. I'll have to think about it, but realistically the accuracy of 0% should prompt the user to do more learning, which is necessary in the case here. Practically speaking this isn't usually going to be enough fingerprint data to actually use the system.

13 datapoints per location is plenty for the original find app to work. My biggest concern was that in all cases each location had at least 9 points of data to use in training and 3 points of data to use in testing. Out of 12 test data (3 data points each for testing * 4 locations) not one of them was correct.
To put that into perspective, if you have multiple choice quiz where you fill in a, b, c, or d. Even if you randomly pick one you should get 25% correct. If you do this three times and don't get any correct, then even if you are picking randomly, statistically you should have more than 0% accuracy.
No matter how many times I calibrate that data, which picks new training data and testing data each time, it is always 0%.
I believe it is likely that this is a bug. - I will be happy to add more data points to if if you want me to. But then if it is a bug adding more data might hide the bug. - Let me know your thoughts.

Heres another example using a larger data set.

If there are 735 data points for second floor bathroom, then why is there also 0% accuracy for that location?

Out of 12 test data (3 data points each for testing * 4 locations) not one of them was correct

This is not quite true. 0% does not mean incorrect nessecarily - the problem was that it couldn't actually predict any measurements because there were NaN values in parts of the confusion matrices. Its more precise to say that there is no information from your test data, because there is too little data.
Even though your accuracy is 0%, the learning could still work. Do you have any gauge on how well it works, even with these few data points? The accuracy is only an estimation of how it performs in the real-world, and is meant to give you an indicator of what to further strengthen with more learning. In the end, what matters is how well it performs in the real world (which is hard to measure unless you dedicate a lot of time).
Your second example is different, I believe. Could you share that dataset with me?

"In the end, what matters is how well it performs in the real world" - I agree.
"which is hard to measure unless you dedicate a lot of time" - I disagree. well depending on by what you mean by measure. It does not take a lot of time to make simple observations.
Seriously, take your find3 app and go into a few rooms and see if the predictions are correct. My observations this morning are find3 is only 20-50% correct.
I will send you a primitive apk that allows the original find and find3 to run within the same app if you want to use it to make observations on which is actually more accurate.
"Your second example is different, I believe. Could you share that dataset with me?"
https://cloud.internalpositioning.com/view/dashboard/knewtek_short

@Thomas499 As I thought, the second scenario is indeed different.
The problem with your database is that it has too many points that are not evenly distributed. Specifically, the problem comes from these lines: https://github.com/schollz/find3/blob/c4179188acb406e70322dede4f44a4865b529661/server/main/src/api/calibration.go#L81-L83. Those lines basically truncate usesr who have data > 1000 points to only doing learning on a random subset of 1000 points.
Why wouldn't I do learning on all of the data? Space is an issue. To compute the learning on your dataset it required 15 GB of RAM. However, after computing with all your data I can see that the accuracy improves greatly (88% -> 94%).
I assumed that most users will do the same amount of learning in each place. If so, then the random subsampling wouldn't matter because it randomly truncates points. However, your dataset has ~2000 datapoints in one location and <100 in another location, so the truncation disfavors the smaller locations. The solution to this is to either remove the truncation entirely, or do truncation only on specific locations.
Would it be useful to have a flag to disable this random subsampling (so you can use the whole dataset)? I will not be able to enable this on the public server because I can't afford that space to everyone (for free).

@schollz

I assumed that most users will do the same amount of learning in each place.
Bad idea, larger rooms will take longer and require more readings in different places of the room. Also, places that the user uses to charge the phone will also likely be subject to more readings.

I have two recommendations based on your previous response.

If the 1000 limit is reached, start deleting older samples which are closest together based on the timestamps they were inserted. - remember what I said about doors opening and closing, and different humidity level. This method will be much more effective than simply capping the samples after first 1,000. Using this method, it really wouldn't even be necessary to include the flag. 1,000 samples should be plenty. The more spaced out they are the better. - It might also be beneficial to start the deletion selection from rooms that have vastly more readings than the others.

Why not evenly distribute the random truncate points from each location? i.e. make a rule if a location accounts for 15% of total readings or whatever, then 15% of the random truncate points must come from that location. - This would correct the mistake of assuming each location would have equal number of training data and would eliminate the disfavoring smaller locations issue.

I am curious to find out more why 15GB of RAM is a concern of yours. For the learning process, I can understand that much may be needed, but that only happens when the person selects the calibrate machine learning option which does not happen often and will not happen after user finishes training. When the location identification code runs, this type of processing power will not be used (correct me if I am wrong). To me, it does not seem like the RAM issue should really be much of a concern. Now if you were using neural networking, where the a.i. constantly learns and corrects itself, I can see the processing requirement being more of an issue.
What concerns me the most about the 15 GB of RAM statement you made is that android p is programmed to identify indoor location with accuracy of 1 to 2 meters, without the use of a server. I seriously doubt they would put that as a built in feature if it required 15GB of RAM on each phone.

Would be useful.
This is already what is happening.

Using a high amount of memory (15GB) is a concern for two reasons.

Personal reasons. I run a public server, for free. The learning is activated anytime there are new learning fingerprints inserted. The server is run on a computer that I use for other things. There are hundreds of users so there is learning happening all the time. Not every learning takes 15GB, but I don't want random people taking up all the RAM on my computer.
FIND3 can run on a Raspberry Pi, which is very useful for people who want to setup a cheap server.

Thus, a flag might be most useful. So if someone does have a system dedicated that they wish to use with thousands of datapoints, they can.

What concerns me the most about the 15 GB of RAM statement you made is that android p is programmed to identify indoor location with accuracy of 1 to 2 meters, without the use of a server. I seriously doubt they would put that as a built in feature if it required 15GB of RAM on each phone.

You're right. Note that Android P has a entirely different system of internal positioning. They use specialized WiFi cards that have much higher time accuracy so they can do time-of-flight analysis to determine accurate distances to routers. These type of chips are rare in the consumer world, so I'm not sure how widely applicable Android P will be (hopefully very much so). Of course, they don't need 15GB of RAM, since they can directly measure the distances with a simple formula and then triangulate themselves.

This is already what is happening.

Your previous comments suggested otherwise.

I assumed that most users will do the same amount of learning in each place. If so, then the random subsampling wouldn't matter because it randomly truncates points. However, your dataset has ~2000 datapoints in one location and <100 in another location, so the truncation disfavors the smaller locations.

Personal reasons. I run a public server, for free. The learning is activated anytime there are new learning fingerprints inserted. The server is run on a computer that I use for other things. There are hundreds of users so there is learning happening all the time. Not every learning takes 15GB, but I don't want random people taking up all the RAM on my computer.

On the public server side, instead of the flag to disable the 1,000 cap only for private servers would you consider using a timestamp to act as the flag? The way I see it, you are on a 8 to 14 time hour difference based on the timing of your normal responses. You aren't going to use your computer between the hours of 11pm and 6am. Tweaking of hours as needed. I am not going to train during the hours of 11pm and 6am EST. This means I (and others in my region) will not likely be a noticeable drain on your RAM.
Or cap the RAM usage allowed by the public server. That's the logical thing to do.
By the way It is very nice of you to host this on your own computer as the server. However, that's probably why the find3 server is down right now.

@Thomas499 That's a good idea. I encourage you to fork the repo and add that as a pull request!

Closed because of https://github.com/schollz/find3/issues/66#issuecomment-382998197


chore(admin) remove unneeded code from endpoints.generate_endpoints

Summary
Just removes a few lines of code that were not used for anything. Something that was left there before that part of code was refactored (it used to be recursive).

Nice!


Retarget all projects to .net 5.0 rc

.net 5 is production ready.

@jacobmsft You also will need to update the pipeline to use .NET 5.
Here's an example snippet
steps:
- task: UseDotNet@2
  displayName: 'Install .NET Core SDK'
  inputs:
    version: 5.0.x
    performMultiLevelLookup: true
    includePreviewVersions: true # Required for preview versions

from https://docs.microsoft.com/en-us/azure/devops/pipelines/ecosystems/dotnet-core?view=azure-devops

This needs the pipeline work alongside it.

good point

@daalcant can you double check my pipeline work?

@gfs Looks mostly fine to me. I'm not a fan of "Use Pre-Release .NET SDK" defaulting to true. IMO should default to false and be set via the respective parameter. If the team is fine with it then I am too though.

Half a dozen of this six of another. I'm fine changing it to be the other way it'll just mean we have to update core pipeline instead of the templates when 5.0 is official released. Either way we need to update it in multiple places.

.NET Core 5 should be GA pretty soon, so I think it's ok to jump on the latest release. We're only telling developers they need to use a release candidate if they want to compile OSS Gadget - the platform-specific releases should work fine.
But I also don't feel super strong about waiting until GA to make this switch.

I'm in favor of moving forward without changes then.


Build on Ubuntu and use msconvert

Hi all,
I use a docker image based on Ubuntu 20.04 for datascience (with Python, R, Julia, JupyterLab, slurm) and would like to install Proteowizard to convert .d files to .mzML with msconvert. I downloaded the source, bjam build which includes vendor reader support, then put the unzipped pwiz-src-3_0_22067_6471540 folder inside the mounted volume of my docker image. From inside the image, I ran ./quickbuild.sh to build Proteowizard.
Once the build is done (after more than an hour), I don't understand what to do for the 6th point of the instructions link:
6) For convenience, adjust your "PATH" environment variable to include your ProteoWizard tools directory, so that the command line tools may be run from any directory.
I also don't get how to use msconvert once the build is done :(
PS :
I am not even sure the build went well, I got the following message at the end :
...failed updating 3 targets...
...skipped 270 targets...
...updated 1601 targets...
At least one pwiz target failed to build.

And during the build, I got many lines starting with ...skipped , especially the following ones about msconvert :
...skipped <p/home/jovyan/work/Proteowizard_source/pwiz-src-3_0_22067_6471540/build-linux-x86_64/pwiz_tools/commandline/gcc-9/release/link-static/runtime-link-static/threading-multi>msconvert for lack of <p/home/jovyan/work/Proteowizard_source/pwiz-src-3_0_22067_6471540/build-linux-x86_64/pwiz/data/identdata/gcc-9/release/link-static/runtime-link-static/threading-multi>libpwiz_data_identdata.a...
...skipped <p/home/jovyan/work/Proteowizard_source/pwiz-src-3_0_22067_6471540/build-linux-x86_64/gcc-release>msconvert for lack of <p/home/jovyan/work/Proteowizard_source/pwiz-src-3_0_22067_6471540/build-linux-x86_64/pwiz_tools/commandline/gcc-9/release/link-static/runtime-link-static/threading-multi>msconvert...
gcc.link /home/jovyan/work/Proteowizard_source/pwiz-src-3_0_22067_6471540/build-linux-x86_64/pwiz_tools/sld/gcc-9/release/link-static/runtime-link-static/threading-multi/short_dump
gcc.compile.c++ /home/jovyan/work/Proteowizard_source/pwiz-src-3_0_22067_6471540/build-linux-x86_64/pwiz_tools/commandline/gcc-9/release/link-static/runtime-link-static/threading-multi/msdir.o

I also spotted these ones :
gcc.compile.c++ /home/jovyan/work/Proteowizard_source/pwiz-src-3_0_22067_6471540/build-linux-x86_64/pwiz/data/identdata/gcc-9/release/link-static/runtime-link-static/threading-multi/IdentData.o
g++: fatal error: Killed signal terminated program cc1plus
compilation terminated.

Would there be a way to install/build only msconvert and not the entire Proteowizard tool ?
Thanks so much in advance for your help !
Maxime

Hi Maxime,
The build did not succeed, but that doesn't matter because you want vendor support and native Linux builds don't provide that. You need to include Wine in your docker image and like we do with the official ProteoWizard Docker container:
https://github.com/ProteoWizard/container/blob/master/Dockerfile
Unless you want to rebuild your container to use Ubuntu 16.04 (the official update to 20.04 got reverted because it wasn't passing all tests), I think you best bet may be to have your docker container call our official Docker container when you want to run msconvert. Whether you do that with Docker-in-Docker or some kind of compose set up is up to you.

Hi Matt,
Thanks you for your helpful answer. After a few days to find a solution, I decided my initial idea was not the best way to use your container so I'll go with an other way !
Thanks again !

I'm glad you found a way to solve your problem!


sailsjs.org is down

The main website is down and an application error is displayed.

Someone must have pushed the button, as its back online now.

Yep, sorry about that. We've been updating the website recently. Thanks for pointing this out.


ReflectionException

What is the easiest way to figure out which file was being parsed when a ReflectionException occurs? (sometimes it can be ambiguous and a simple "search" won't suffice.)

You can try and call the generate command with the '-v' parameter. It
should give you some more helpful exception information.
William Andreozzi<EMAIL_ADDRESS>schrieb am Sa. 1. Okt. 2016 um
01:16:

What is the easiest way to figure out which file was being parsed when a
ReflectionException occurs? (sometimes it can be ambiguous and a simple
"search" won't suffice.)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mpociot/laravel-apidoc-generator/issues/107, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAxHTAqPRftjADW0x4a_gJiMQcKUmWnAks5qvZg8gaJpZM4KLl4b
.

--
Marcel Pociot
http://www.marcelpociot.com
https://github.com/mpociot
http://twitter.com/marcelpociot

that worked - thanks.


Create merge_queue.md

Adds information on the merge queue, to be used for announcement. Will update to final doc after the merge project is complete.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I signed the CLA.
[ ] I listed at least one issue that this PR fixes in the description above.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] I followed the breaking change policy and added Data Driven Fixes where supported.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

I need to check in the images quickly elsewhere. We have wiki image storage in flutter/assets-for-api-docs


[Task]: Update Debezium test container back to latest

What needs to happen?
To fix #32936 the test container version for debezium/example-postgres was moved to a hard-coded version instead of latest, as the latest tag was no longer present on their container registry. This should be remedied once a latest container is tagged at https://hub.docker.com/r/debezium/example-postgres/tags
Issue Priority
Priority: 2 (default / most normal work should be filed as P2)
Issue Components

[X] Component: Python SDK
[X] Component: Java SDK
[X] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam YAML
[ ] Component: Beam examples
[ ] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Infrastructure
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

fixed by #32926


Missing TestCaseResult.failureDetails[i].message/stack

🐛 Bug Report

Unable to get testCaseResult.failureDetails[i].message and testCaseResult.failureDetails[i].stack properties in a custom reporter implementing Reporter.onTestCaseResult.
To Reproduce
The issue is reproduced only when tests are running in parallel. Not reproduced when running with --runInBand.
Steps to reproduce the behavior:

One of tests should be failing. Have tests suitable for running in parallel according to shouldRunInBand implementation. For example, have more than 20 test files.
Add a custom reporter accessing testCaseResult.failureDetails[0].message

// my-reporter.js
class MyReporter {
  onTestCaseResult(test, testCaseResult) {
    if (testCaseResult.status === 'failed') {
      const failure = testCaseResult.failureDetails[0];
      console.log();
      console.log('testCaseResult.failureDetails[0].message exists: ' + (failure.message != null));
      console.log('testCaseResult.failureDetails[0].stack exists: ' + (failure.stack != null));
    }
  };
}

module.exports = MyReporter;

Run tests with the custom test reporter jest --reporters my-reporter.js.

Expected behavior

Expected output:
testCaseResult.failureDetails[0].message exists: true
testCaseResult.failureDetails[0].stack exists: true

Actual output:
testCaseResult.failureDetails[0].message exists: false
testCaseResult.failureDetails[0].stack exists: false

Link to repl or repo (highly encouraged)

Please see https://repl.it/@sergey_simonchik/missing-TestCaseResult-failureDetails-message-and-stack
envinfo

$ npx envinfo --preset jest
npx: installed 1 in 0.921s

  System:
    OS: Linux 4.15 Linux Mint 19 (Tara)
    CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
  Binaries:
    Node: 14.16.0 - ~/.nvm/versions/node/v14.16.0/bin/node
    Yarn: 1.22.5 - /usr/bin/yarn
    npm: 6.14.11 - ~/.nvm/versions/node/v14.16.0/bin/npm
  npmPackages:
    jest: 26.6.3 => 26.6.3

Curious, the issue is reproduced with<EMAIL_ADDRESS>and not reproduced with<EMAIL_ADDRESS>or higher. Couldn't find related issue/commit, so it might be fixed unintentionally in v27. If the fix is backporable to v26, it'd be great to include it in the next v26 release!
This issue causes https://youtrack.jetbrains.com/issue/WEB-49052 (a workaround will be implemented in IntelliJ/WebStorm).

@SimenB Do you have any idea what can cause it?

I assume it's related to #10577. A fix landed or 27 but has been reverted. So I would assume it's now failing again if you install next.5?
The issue is serialization of objects across workers

@SimenB You're right, it's failing now with 27.0.0-next.7.


Order analyzer tests by package name, not name

@selmanj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
ee09d45f6528ef157088af4ced769027455dad59
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@selmanj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
5643e1ef02a972c49782af75525d2a2c298a9db5
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Open Source : 6.45 Explain everything related to astro

Description 📜
Open Source : 6.45 Explain everything related to astro
NOTE 👇
Please put your doc 6.Popular_Projects with the name 6.45_astro.md

Domain
Open Source
Type of Contribution
Documentation
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of this project.

Created  PR, please review @Aryamanz29


pyvespa model integration

Are there any plans to make it simpler for users to utilize any type of ml model (cnn, rnn, gnn, etc.) they want with Vespa during inference?
pyvespa is a useful tool to integrate ml models with the Vespa engine, but it still feels limited. For example in sequence-classification-task-with-vespa-cloud it is only able to load huggingface text models. Are there any plans in the future to create a wrapper for users to implement their own models with customizability for pre/postprocessing in pyvespa? I say this because having ml developers rewrite pre/postprocessing in java is not a fun experience. Could this also be possible when the model is running inference within the content cluster? I am finding that loading embeddings directly into Vespa is painless but trying to load models into Vespa causes some pains.
Thanks.
References

ml.py
sequence-classification-task-with-vespa-cloud

The biggest requirement today to export models to Vespa via a simpler API is the availability of an ONNX converter. The issue with pre/postprocessing is that they are often not included in the ONNX file when we export the pipeline.
For example, the tokenizer part of the text models is not included in the .onnx file when exporting a sequence classification pipeline. This means that we need to implement the tokenizer in Java (faster) or in python (slower). The pyvespa example implements the tokenizer via python. I think this is useful when ML developers are experimenting with Vespa (that is why pyvespa was created) but you would probably need to provide a Java implementation when using your app in production.
Now, back to your question. When you mention wrappers for users to implement their own models, would it be acceptable for the pre/postprocessing to run in python for experimentation, or do you expect those wrappers to somehow be included in the app via a java implementation?

I think this is the meat of how live model inferencing is done [ vespa/application.py ], please correct me if I am wrong.
Basically, preprocessing is applied outside the vespa endpoint. Is this slower than if the preprocessing was done within the endpoint?
Also if documents were stored in vespa as raw text, could the predict method above be applied to those documents or would a custom java plugin need to be written?

Currently, there is no way to run python code in Vespa. Instead, you need to create Java searchers to run code on the container cluster.
There is no way to deploy general python ML code unless it is possible to export it to ONNX.
We could work on wrappers to run more general ML code in pyvespa like pre and post-processing, but this would happen outside Vespa.
Example of general ML processing outside Vespa includes writing pre-processing steps in a PyTorch pipeline before feeding the data to a Vespa app. See how to generate image embedding to use in a text-image app
I am not aware of a Java and python benchmark that compares performance between Java and Python for document and query processing.


Adding service fabric api version 2020-12-01-preview.

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of “no breaking changes
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[x] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask<EMAIL_ADDRESS>(or NullMDR in github) for additional help.

*** /openapibot sdkautomation ***

Can one of the admins verify this patch?

Thanks for copying the existing version before doing the change. New API's are looking good, signing off from ARM side.

@alexgshaw there is a conflict for this PR. Could you please fix it so we could do further review?

@alexgshaw long time no updates for this thread, is this PR still valid?

Hi, yes the PR should still be valid. I was interning at Microsoft when I made this PR. I'll email some members of my team to see if they can take it over. Sorry for the delay, and thanks for your help!
@a-santamaria could you help with this?

@alexgshaw sorry for the delay. I have taken your branch and rebased with master to fix the conflicts and update the paths here #11614. @njuCZ I'm closing this pr so we can follow up in the new one I created.


More general ProductDomain support (#42)

Fixes #42. Note that its not quite as general as it could be due to hitting https://github.com/JuliaLang/julia/issues/31861

The tests were failing in Julia v0.7 due to a stack overflow. It seems at this point not worth it to support Julia v0.7 anymore. Any one (apart from @MikaelSlevinsky) object to requiring Julia v1.0?

I don't mind requiring Julia v1.0


[SPARK-17551][SQL] complete the NULL ordering support in DataFrame APIs

What changes were proposed in this pull request?
This PR is to complete the feature - NULLS FIRST | LAST in sorting for DataFrame/Dataset APIs.
How was this patch tested?
New DataFrame test case are added.

Test build #65421 has started for PR 15107 at commit 69a9d8a.

@hvanhovell

Test build #65421 has finished for PR 15107 at commit 69a9d8a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65421/
Test PASSed.

Merged build finished. Test PASSed.

@rxin any opinion about this?

@xwu0226 Can you please close this, please? @hvanhovell already added you as the contributor in another PR, which has been merged. Thanks!


go mod packages updates in the driver and operator

Pull request checklist

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[ ] Feature Enhancement
[ ] Test Automation
[x] Code Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Community Operator listing
[x] Other (please describe):  Go packages have been updated to latest.

What is the current behavior?

What is the new behavior?

There are changes in the controller  and manager functions of the operator. Need to be validation

How risky is this change?

[ ] Small, isolated change
[ ] Medium, requires regression testing
[x] Large, requires functional and regression testing

Image: quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:gomodpackagetest_v1

HI @badri-pathak can you please do the same for operator too in the same PR ?

Images:
quay.io/badri_pathak/ibm-spectrum-scale-csi-operator:gomodpackagetest_v4
quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:gomodpackagetest_v4

@badri-pathak Please fix the travis build errors

Images:
quay.io/badri_pathak/ibm-spectrum-scale-csi-operator:gomodpackagetest_v4
quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:gomodpackagetest_v5


refactor(value_type): value_type to test_value_type

Codecov Report
Patch coverage: 75.00% and project coverage change: +0.23 :tada:

Comparison is base (b53e7cb) 90.53% compared to head (7f27d25) 90.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   90.53%   90.76%   +0.23%
==========================================
  Files          31       31
  Lines        2187     2188       +1
==========================================
+ Hits         1980     1986       +6
+ Misses        207      202       -5

Impacted Files
Coverage Δ

excelalchemy/core/alchemy.py
86.12% <71.42%> (+0.84%)
:arrow_up:

excelalchemy/__init__.py
100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Update color scheme & better support of Python

Update the color scheme to 2019.1.
Fix issues with Python language support to match other editors.

The PR was closed automatically by GitHub while resolving #180 because the develop branch was deleted and master is now the default branch. I'll reopen this PR as soon as all migration steps are completed.


AU Base Patient snippet - mother's maiden name extension comment fix

https://github.com/robstwd/fhir-snippets/blob/main/snippets/FHIR-Patient-examples.code-snippets#L126
This is an international extension not AU Base

Fixed via 1b07bf2a424259fa5b8cb857bc31c8c6276fe67a


VRRP traffic dropped by Cilium - CT: Unknown L4 protocol

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?

No response
Cilium Users Document

[X] Are you a user of Cilium? Please add yourself to the Users doc

Code of Conduct

[X] I agree to follow this project's Code of Conduct

This looks like a dup of https://github.com/cilium/cilium/issues/18347? Could you follow-up on the same issue?

Definitely related but not dup of the initial issue. I propose to retitle the issue; hostfirewall enabled/disabled has no effect on this issue in 1.15 and other protocols are impacted as well. seem to be a regression as it was working in my setup in 1.14

I just can confirm that this are two different bugs. One is related to host firewall (#18347) and this one is related to bpf masquerade somehow.
What can I observe:

use keepalived with LAN ip4 - it's all OK
use keepalived with WAN ip4 - I can see 2-4 vrrp packets after keepalived start, depending on nodes/ips and after that packets are dropped. After keepalived restart I can see again 2-4 vrrp packets.

This is all related to setup without host firewall. I'm preparing PR right now for the fix, but don't know if it's right way (I'm not cilium maintainer).

@sbocahu, can you please tell what other protocols are impacted as well ? Is this also a multicast traffic ?

@kvaster OSPF is reported to be impacted as well: https://github.com/cilium/cilium/issues/18347#issuecomment-1752492445

OSPF is also based on multicast. But I should say that my fix is only for host multicast traffic without hostfirewall enabled.

I'm considering using hostFirewall in the future however for the time being I'ld be glad to upgrade to 1.15 so thank you very much @kvaster. Hope a new minor fixing this soon :) !

I think I see what's up. This might have been introduced by https://github.com/cilium/cilium/pull/26501.  Can you attach your sysdump / cilium config to confirm whether that matches up?
Would you be able to reproduce on latest main, and potentially test a PR?

https://github.com/cilium/cilium/pull/31820 is my current thinking. But I wouldn't expect it to help with HostFW enabled ...

@julianwiedmann , I can test on latest main without any problm. Will do it tomorrow and will get back. Also testing PR is not a problem aswell.

@julianwiedmann , I've made a check. The problem is gone with latest main.

@julianwiedmann , I've made a check. The problem is gone with latest main.

excellent, thank you!

This issue has been fixed and integrated into 1.15.3 or 1.15.4
thanks !


single-line block comments incorrectly indented

Issue Type: Bug
create ts/js file:
class foo {
  /* */
}

place cursor to right of */
hit return
you get:
class foo {
/* */

}

VS Code version: Code 1.36.1 (2213894ea0415ee8c85c5eea0d0ff81ecc191529, 2019-07-08T22:56:38.504Z)
OS version: Darwin x64 18.6.0

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz (8 x 2900)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: enabledoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_deferred_display_list: disabled_offskia_renderer: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
2, 2, 2

Memory (System)
16.00GB (1.20GB free)

Process Argv
--disable-extensions

Screen Reader
no

VM
0%

Extensions disabled

I can't repro this, @JonathanMEdwards can you still see this?

Yes, still happens, exactly as described.
CPUs	Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2600)
GPU Status	2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg)	3, 2, 2
Memory (System)	16.00GB (1.04GB free)
Process Argv	-psn_0_11037318
Screen Reader	no
VM	0%

Extension
Author (truncated)
Version

npm-intellisense
chr
1.3.0

gitignore
cod
0.6.0

vscode-npm-script
eg2
0.3.11

latex-workshop
Jam
8.8.0

theme-dark-plus-contrast
k3a
0.1.101

debugger-for-chrome
msj
4.12.6

deepdark-material
Nim
3.2.1

vscode-jest
Ort
3.1.1

vscodeintellicode
Vis
1.2.6

markdown-all-in-one
yzh
2.7.0

This is due to the limited architecture (regex based indentation rules and only support limited code styles), we may want to consider using formatters if they exist for indenation adjustment (if interested, we can discuss in https://github.com/microsoft/vscode/issues/19847).
For this particular issue, you can set editor.autoIndent to advanced to disable the regex based indentation adjustment or use auto formatting (editor.formatOnType, editor.formatOnPaste). As we don't have an easy good-enough fix for it, we close it for now and explore better solutions through issues like (https://github.com/microsoft/vscode/issues/19847, https://github.com/microsoft/vscode/issues/34621 or https://github.com/microsoft/vscode/issues/66235).

Closing this in favor of the other issues mentioned as I don't think it's possible to fix this without some new APIs


Cloud functions python template error uploading functions

When using any of the examples provided to deploy functions the python template inlines all the code (compressed and codified) in a single command as shown here
https://github.com/GoogleCloudPlatform/deploymentmanager-samples/blob/bc2979c9a55c1d65b2626248426a5d29f243d5b4/examples/v2/cloud_functions/python/cloud_function.py#L38
And also here
https://github.com/GoogleCloudPlatform/deploymentmanager-samples/blob/bc2979c9a55c1d65b2626248426a5d29f243d5b4/community/cloud-foundation/templates/cloud_function/upload.py#L79-L80
This works for the small three line functions provided, (less than 100 LOC main.py file) it produces the following error:
- code: RESOURCE_ERROR
  location: /deployments/my-deployment/resources/upload-function-code
  message: '{"ResourceType":"gcp-types/cloudbuild-v1:cloudbuild.projects.builds.create","ResourceErrorCode":"400","ResourceErrorMessage":{"code":400,"message":"invalid
    build: invalid .steps field: build step 0 arg 2 too long (max: 4000)","status":"INVALID_ARGUMENT","statusMessage":"Bad
    Request","requestPath":"https://cloudbuild.googleapis.com/v1/projects/my-project/builds","httpMethod":"POST"}}'

Which means that this cmd variable we defined above is longer than 4k characters.
Deploying extra infrastructure to copy files as suggested here
https://github.com/GoogleCloudPlatform/deploymentmanager-samples/issues/40#issuecomment-339759328 produces a big overhead in development time and makes the deployment unnecessarily complex. You would have to write a:

python template to deploy small functions (as mentioned above, big functions wont fit).
cloud function to copy the files.
function call resource to call the function with the inline text for each file (this can turn into a composite type or another template)
cloudbuild pipeline resource to zip the files in the bucket
cloud function resource, finally, to deploy the comprssed code.

On the other hand I could copy the files by downloading them from the repository itself as suggested here https://stackoverflow.com/a/49751362, but this will make the deployment "gitlab dependant". I would need a different template for each type of repository (and a Docker image to deploy the zip utility, another dependency).
resources:
  - name: my-build
    action: gcp-types/cloudbuild-v1:cloudbuild.projects.builds.create
    metadata:
      runtimePolicy:
      - CREATE
    properties:
      steps:
      - name: gcr.io/cloud-builders/git
        args: ['clone', 'git clone https://gitlab-ci-token:{{ properties ['GITLAB_CI_TOKEN']<EMAIL_ADDRESS>      - name: gcr.io/{{ env['project'] }}/zip
        args: ['–r', 'function.zip', 'function_folder']
      - name: gcr.io/cloud-builders/gsutil
        args: ['cp',  'function.zip', gs://my-bucket/ ]
      timeout: 120s

Could there be an alternative for moving files with no extra template/config files?

I know why this is designed like it is. Every deploy would be easy to reprifucr
It's jus2t tremmendously

Right now I'm using gitlab, bundling the function folder , providing it as an artifact and coping it with a cloud build pipeline to a bucket

Please note, that there are many other limitations, like text-only files, strict asci, etc.
This is just a demo, you shouldn't use it as-is in your deployments.

To work around this, I split content into chunks:
    chunk_length = 3500
    content_chunks = [content[ii:ii+chunk_length] for ii in range(0,len(content), chunk_length)]
    # use `>` first in case the file exists
    cmds = ["echo '%s' | base64 -d > /function/function.zip;" % (content_chunks[0].decode('ascii'))]
    # then use `>>` to append
    cmds += [
        "echo '%s' | base64 -d >> /function/function.zip;" % (chunk.decode('ascii'))
        for chunk in content_chunks[1:]
    ]

I then expanded the build steps by mapping cmds to an intermediate array:
    zip_steps = [
        {
            'name': 'ubuntu',
            'args': ['bash', '-c', cmd],
            'volumes': volumes,
        } for cmd in cmds
    ]
    build_step = {
        'name': 'upload-function-code',
        'action': 'gcp-types/cloudbuild-v1:cloudbuild.projects.builds.create',
        'metadata': {
            'runtimePolicy': ['UPDATE_ON_CHANGE']
        },
        'properties': {
            'steps': zip_steps + [{
                'name': 'gcr.io/cloud-builders/gsutil',
                'args': ['cp', '/function/function.zip', source_archive_url],
                'volumes': volumes
            }],
            'timeout':
            '120s'
        }
    }

This modification allowed the deploy to succeed.

Thought my organization uses GCP extensively we don't rely on DM anymore. Terraform it is


Use internal-discovery and http for talking to overlord/coordinator leaders

This patch introduces class DruidLeaderClient to facilitate interaction with coordinator and overlord leaders. Please see the javadoc on class for more information.
Above class is intended to discover all coordinator or overlord nodes from internal discovery and then interact with the leader by depending upon the existing redirection feature and getLeader endpoint provided by them.
However, to retain backward compatibility and to allow rolling upgrade, it first tries to find the coordinator or overlord node in external discovery which shall be removed in future.
All the other classes that used to interact with coordinator or overlord leaders have been updated to use DruidLeaderClient.

👍


Making A separate send message section[GSSOC'23]

why do you want to add this section so that I can understand?
after it I will assign it to you.


I got stuck while installing.

I am a beginner and please don't mind if I am wrong but I can't tun npm install here. Please tell me how can I move forward.
Image

I also tried "npm install react-native-macos" but didn't worked.

 Also use yarn, it should fix the error.

Yes I understand that I cant run macos.
But I can run android and web version on my pc right ?
So I am doing npm install for installing all the dependencies for starting and this is giving me error.
Is there a mistake I am doing?

Please look into stackoverflow, I don't use windows and don't recommend as well.


Lighthouse improvements

Non blocking css
Gzip
SSL

Added GZip and embedded CSS.
SSL is not yet required.


Is there a way to set temperature per request without modifying whole client via Client Registry?

          Is there a way to set `temperature` per request without modifying whole client via `Client Registry`?

Originally posted by @pySilver in https://github.com/BoundaryML/baml/issues/892#issuecomment-2536579238

No, there's no way to do this right now, unfortunately. We'll keep this in the backlog!


Add tweet mode parameter to relevant functions

Adding the tweet_mode parameter to functions that return tweets allows for specifying the "extended" tweet mode, which is how Twitter delivers the new longer tweets without truncating them. It will also allow for specifying "compat" mode when extended becomes the default.

Surely this is the best way to add support to the extended mode without breaking legacy code.
If @meteochu agrees, it looks good to me! 💯

Like I said, I still prefer using an enum approach, so that the implementation on the Swift side would feel more native. What we can do is having...
enum TweetMode {
    case default
    case extended
    case other(String) // in case twitter adds more in the future...

    var stringValue: String? {
        switch self {
        case .default:
            return nil
        case .extended:
            return "extended"
        case .other(let string):
            return string
        }
    }
}

// ...then your implementation can simply change to
parameters["tweet_mode"] ??= tweetMode.stringValue

This allows for the same flexibility while making it native.

Hey @meteochu, I think I see what you mean now. Xcode didn't like default being used like that, so I changed it to defaultValue, and added compat as an option to provide a clean way to force the current default so nothing changes when Twitter makes extended the default.
Hopefully this is more like what you were thinking. I do think it seems much better than making everyone sift through the Twitter docs to figure out how to use the tweet_mode parameter. Let me know if you have any more thoughts on this latest version!

@meteochu, sounds good. I just made that change.

@meteochu, that makes sense. No need for two different ways to specify a nil value - I made that change throughout the code.

Would love to see this get merged; using it currently on my dev branch! Two nitpicks though:
First of all, IMO intent might be clearer if tweetMode were an optional field, the default case were removed, and stringValue were made non-optional. Passing nil more obviously communicates that you're not sending that parameter to Twitter than .default, which could be interpreted to mean either sending nothing or sending the text "default" until you look at the source code.
Second, all REST endpoint methods that return tweet objects should receive the tweet mode parameter, such as postTweet, retweetTweet, unretweetTweet, destroyTweet, etc.

By Swift styling design, .default is almost always a reserved keyword in an enum that refers to a "default" case. This will also allow for future-proofing if and when the default changes a couple years from now. I do agree that the remaining endpoints should include the tweet mode parameter; I will review this PR again once that is done.

Fair enough!

I made another pass through the methods and hopefully got them all this time - I think the 2 favorite methods were the only outstanding methods @zachrwolfe did not mention.

LGTM, thank you for your contributions. This PR will now be merged.


Antrea CLIs to dump agent-info and pod-interface

Describe what you are trying to solve
Antrea needs some CLIs for troubleshooting and debugging. I am going to implement agent-info and pod.
Describe the solution you have in mind
The CLIs look like:

antctl agent-info
antctl get pod-interface [podName]

Thanks Zhechent.
IMO, the status command you proposed is too generic, could you please describe it more?

Agreed. I have updated it.

Two antctl commands have been added.


Complete README and check the structure of the package

Updated the README with all sections.
Closed in cbf4ef03d983bdc3f0e473a514a83e67ec530d30.


[MXNET-1398] Enable zero-copy from numpy to MXNet NDArray

Description
This PR allows users to convert numpy's NDArray without copying content data. This is achieved by converting numpy's NDArray to DLManagedTensor, which is introduced in https://github.com/dmlc/dlpack/pull/38. We expect that this would help users reduce major performance bottleneck when this conversion is conducted frequently.
See also: #14244.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[x] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[x] Changes are complete (i.e. I finished coding on this PR)
[x] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[x] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[x] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[x] Rewrite NDArray::FromDLPack to make it resource safe.
[x] Add DLManagedTensor and its deleter via ctypes that allows C++ side deletes it.

Comments
Nothing.

@reminisce @wkcn Could you help review? Thanks!

@reminisce Hey I have already addressed your comments. Could you review again? Thanks!

Merged. Thank you!


Modify other constants based on decreased block time

Context
Originally posted by @jcstein in https://github.com/celestiaorg/celestia-app/pull/3953#discussion_r1794537751
Problem
The constant GoalBlockTime is used:

To determine Mempool TTLDuration
To determine Evidence MaxAgeNumBlocks
To determine x/ibc MaxExpectedTimePerBlock

#3882 proposes decreasing block times from 12 to 6 seconds.
Proposal
Re-evaluate if those constants need to be modified if we decrease block time from 12 to 6 seconds.

Mempool TTL duration
// TTLDuration, if non-zero, defines the maximum amount of time a transaction
// can exist for in the mempool.
//
// Note, if TTLNumBlocks is also defined, a transaction will be removed if it
// has existed in the mempool at least TTLNumBlocks number of blocks or if it's
// insertion time into the mempool is beyond TTLDuration.
TTLDuration time.Duration `mapstructure:"ttl-duration"`

Currently
ttl-duration = "1m15s"

which is 12.5 blocks. Since we also have
ttl-num-blocks = 5

we don't need to modify this value.
Evidence MaxAgeNumBlocks
consensus.evidence.MaxAgeDuration =<PHONE_NUMBER>000000 (21 days)
consensus.evidence.MaxAgeNumBlocks = 120960

120960 blocks * 12 seconds per block = 1451520 seconds = 16.8 days
120960 blocks * 6 seconds per block = 725760 seconds = 8.4 days
we don't need to modify this parameter because evidence is only considered expired after 21 days and 120960 blocks (see here). Since 21 days remains intact, evidence won't be pruned prematurely.
x/ibc MaxExpectedTimePerBlock
TBD


[Error] Missing URL

Hello.
look at the results of "aquatone," some URLs in the "test" file are missing.
Why??
My command line
cat test | ./aquatone

Thanks.

They timeout see -scan-timeout


Really always call finalisers for embedded fields

This fixes a case overlooked in 087ebc7. In that commit, the finaliser of an embedded field was only called if the parent object (or actor) had an explicit finaliser. This change adds implicit finalisers to objects that must finalise an embedded field, including recursively.
PS: If this gets merged before the pending release this shouldn't get a changelog entry since it is covered by the one from #1586.

This seems to fail with the same out-of-memory error as #1614. Once #1621 is merged, the problem should be fixed for both PRs.

I've rebased on latest master to pick up the changes merged from #1621.

I've rebased on latest master after the merge of #1677.

The new tests are causing a segfault on Linux and I can't reproduce it. I'll try to investigate.

The tests are passing. I've also made the changes you requested @jemc.


English translation.

Thanks for the request. I have added the fix for simplesearch/SimplesearchPlugin.php. The translations i will use later. I have added a translator class which i try to establish first. After this i will translate all the content. I'll keep you informed.

Thanks, it's a really nice project the only problem is the docs in german language, but for only one developer it's a really great project, thanks for share.


redesign contact form

Added a form container with a semi-transparent background and rounded corners.
Adjusted input fields and Added hover effects on the submit button.
Changed the background image to blend well with the page theme.

I have created a more eyecatching design, can i add it as contact page??

Hi,
Just a quick reminder: as per our guidelines, you need to raise an issue and get assigned to it before submitting a PR.
Please raise the issue first next time. This helps us avoid overlap and keeps things organized.
I am not merging this PR for now as it is assigned to someone else.  #5
Will review both after she completes it. (the priority will be given as first come first serve method.)

Hi, Just a quick reminder: as per our guidelines, you need to raise an issue and get assigned to it before submitting a PR. Please raise the issue first next time. This helps us avoid overlap and keeps things organized.
I am not merging this PR for now as it is assigned to someone else. #5 Will review both after she completes it. (the priority will be given as first come first serve method.)

Okk sure!!


[BUG] Event Issued Part #2 & More

Hello again, @qxb3!
I have finally reached the stage in my project where I use your library (which works almost as it should), however there are still some other issues:

'typing' event is not firing;
'stoppedtyping' event is not firing;
'connected' property seems to never be updated - with the following code I loop forever in the while-loop after I refresh the page and the client has not closed:

import * as config from '../configs/general.config.js';
import OmegleClient from 'omegle.js'
import {WebSocketServer} from 'ws';
import Axios from 'axios';

const client = new OmegleClient();
const wss = new WebSocketServer({port: config.app.wssport, host: config.app.host});

export async function renderRoute(request, reply){
  Axios.get('https://chatserv.omegle.com/status').then(function (r2){
    if(request.query.commontopics){
      initializeOmegleClient(config.app.language.iso6392, request.query.commontopics.split(','));
    }else{
      initializeOmegleClient(config.app.language.iso6392, []);
    }
    return reply.render('chat', {'id': 0, 'users': r2.data.count, 'language': config.app.language.name, 'url': config.app.url});
  }).catch(function () {
    if(request.query.commontopics){
      initializeOmegleClient(config.app.language.iso6392, request.query.commontopics.split(','));
    }else{
      initializeOmegleClient(config.app.language.iso6392, []);
    }
    return reply.render('chat', {'id': 0, 'users': '...', 'language': config.app.language.name, 'url': config.app.url});
  });
}

export async function initializeOmegleClient(language, topics){
  wss.on('connection', function connection(ws){
    console.log('OM+ | New WebSocket connection established.');
    client.on('connected', () => ws.send('{"status": "connected"}'));
    client.on('disconnected', () => ws.send('{"status": "disconnected"}'));
    client.on('typing', () => ws.send('{"status": "typing"}'));
    client.on('stoppedtyping', () => ws.send('{"status": "stoppedtyping"}'));
    client.on('message', (message) => ws.send('{"status": "messagereceived", "message": "' + message + '"}'));

    if(topics.length >= 1){
      console.log('OM+ | Connecting to Omegle with topics: ' + topics);
      client.connect({lang: language, topics: topics})
    }else{
      if(client.connected == true){
        client.disconnect()
        while(client.connected == true){
          console.log('OM+ | Disconnecting from Omegle...');
        }
        client.connect({lang: language});
      }else{
        client.connect({lang: language})
      }
    }
    ws.on('close', function close(){
        console.log('OM+ | WebSocket connection closed.');
    });
});
}

1: Fixed
2: Fixed
3: Based on my tests the connected property is working fine

Hi and thanks yet again! I will run a few more tests and then report any issues to you.

sure! that would be appreciated :)


Fix bug where state and nonce were wrong in query params

Resolves issue #5

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cfryanr
To complete the pull request process, please assign
You can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Keep all intermediate exceptions to provide call traces

I don't know if this is abandonware but we found it useful.
The PR adds one feature to retain intermediate stack traces.
We also want to use it with deps.edn via git SHAs rather than a central repo

I'm no longer actively using it, but I'm happy to merge and release.
On Sat, 24 Nov 2018, 11:07 Ray McDermott<EMAIL_ADDRESS>wrote:

I don't know if this is abandonware but we found it useful.
The PR adds one feature to retain intermediate stack traces.
We also want to use it with deps.edn via git SHAs rather than a central
repo
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/nervous-systems/glossop/pull/1#issuecomment-441359924,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYuKxcVU3x6hxBS0iNOOiSdoKkmi_QOks5uySiGgaJpZM4YxYAx
.

Great - thanks.
Have you found something better or is there another reason you no longer
use it?
On 24 November 2018 at 12:55:38, Moe Aboulkheir<EMAIL_ADDRESS>wrote:

I'm no longer actively using it, but I'm happy to merge and release.
On Sat, 24 Nov 2018, 11:07 Ray McDermott<EMAIL_ADDRESS>wrote:

I don't know if this is abandonware but we found it useful.
The PR adds one feature to retain intermediate stack traces.
We also want to use it with deps.edn via git SHAs rather than a central
repo
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<
https://github.com/nervous-systems/glossop/pull/1#issuecomment-441359924>,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ABYuKxcVU3x6hxBS0iNOOiSdoKkmi_QOks5uySiGgaJpZM4YxYAx
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/nervous-systems/glossop/pull/1#issuecomment-441362600,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHWdQc_YJYHYjJjhFPh2NLkmpVElAo1ks5uyTO6gaJpZM4YxYAx
.

I switched to using promises (e.g. promesa) for single deferred values, and
if I'm using core.async as intended - for dataflows - I may use separate
error channels, depending on the use case.  That said, I don't think there
is anything fundamentally wrong with the primitives in this library, and
there are definitely circumstances where I'd reach for it.
On Sat, Nov 24, 2018 at 2:04 PM Ray McDermott<EMAIL_ADDRESS>wrote:

Great - thanks.
Have you found something better or is there another reason you no longer
use it?
On 24 November 2018 at 12:55:38, Moe Aboulkheir<EMAIL_ADDRESS>wrote:

I'm no longer actively using it, but I'm happy to merge and release.
On Sat, 24 Nov 2018, 11:07 Ray McDermott<EMAIL_ADDRESS>wrote:

I don't know if this is abandonware but we found it useful.
The PR adds one feature to retain intermediate stack traces.
We also want to use it with deps.edn via git SHAs rather than a central
repo
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<
https://github.com/nervous-systems/glossop/pull/1#issuecomment-441359924
,
or mute the thread
<

https://github.com/notifications/unsubscribe-auth/ABYuKxcVU3x6hxBS0iNOOiSdoKkmi_QOks5uySiGgaJpZM4YxYAx

.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<
https://github.com/nervous-systems/glossop/pull/1#issuecomment-441362600>,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAHWdQc_YJYHYjJjhFPh2NLkmpVElAo1ks5uyTO6gaJpZM4YxYAx
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/nervous-systems/glossop/pull/1#issuecomment-441370167,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYuKzLCrNfe3GQ0TpubMFtLEN0lP-Hwks5uyVHfgaJpZM4YxYAx
.


PowerToys.Peek.UI.exe CPU startup

Microsoft PowerToys version
0.70.1
Installation method
GitHub, PowerToys auto-update
Running as admin
Yes
Area(s) with issue?
Peek
Steps to reproduce
Windows 10 LTSC N 21H2

startup Windows 10 > Task Manager > "PowerToys.Peek.UI.exe" usage CPU 0-1%

manual click kill process "PowerToys.Peek.UI.exe" > use Peek with Explorer, after focus process will be CPU 0%

!!! option "Automatically close the Peek window after it loses focus" work only after manual kill process "PowerToys.Peek.UI.exe"
✔ Expected Behavior
startup Windows process "PowerToys.Peek.UI.exe" usage CPU 0%
❌ Actual Behavior
startup Windows process "PowerToys.Peek.UI.exe" usage CPU 0-1%
Other Software
No response

Closing this in favor of #27294 since that issues have more relevant informations.
/dup #27294


[Feature Request]: Add multi-filter single key solution

Feature Description
This is following up on what the bot suggested in this ticket: https://github.com/run-llama/llama_index/issues/9627.
I need functionality for multi-filter, single-key with chroma in particular. Something like this, for example:
key="Month", value=["September", "October"] with an OR filter condition and an IN operator
As far as I understand, this is not currently supported.
I have the following working solution and am hoping this or something similar could be merged into the repo:

vector_stores/types.py

class MetadataFilter(BaseModel):
    key: str
    value: Union[StrictInt, StrictFloat, StrictStr, List[Union[StrictInt, StrictFloat, StrictStr]]]
    operator: FilterOperator = FilterOperator.EQ

vector_stores/chroma.py

def _transform_chroma_filter_operator(operator: str) -> str:
    """Translate standard metadata filter operator to Chroma specific spec."""
    if operator == "!=":
        return "$ne"
    elif operator == "==":
        return "$eq"
    elif operator == ">":
        return "$gt"
    elif operator == "<":
        return "$lt"
    elif operator == ">=":
        return "$gte"
    elif operator == "<=":
        return "$lte"
    elif operator == "in":
        return "$in"
    else:
        raise ValueError(f"Filter operator {operator} not supported")

vector_stores/chroma.py

def _to_chroma_filter(
    standard_filters: MetadataFilters,
) -> dict:
    """Translate standard metadata filters to Chroma specific spec."""
    filters = {}
    filters_list = []
    condition = standard_filters.condition or "and"
    condition = _transform_chroma_filter_condition(condition)

    if standard_filters.filters:
        for filter in standard_filters.filters:
            if filter.operator:
                operator = _transform_chroma_filter_operator(filter.operator)
                # Handle list values for 'in' operator
                if filter.operator == FilterOperator.IN and isinstance(filter.value, list):
                    filters_list.append({filter.key: {"$in": filter.value}})
                else:
                    filters_list.append({filter.key: {operator: filter.value}})
            else:
                # Assuming default behavior for filters without an explicit operator
                filters_list.append({filter.key: filter.value})

    if len(filters_list) == 1:
        # If there is only one filter, return it directly
        return filters_list[0]
    elif len(filters_list) > 1:
        # Combine multiple filters based on the specified condition
        filters[condition] = filters_list

    return filters

And then this gets initialized like this:

metadata_filters = MetadataFilters(
    filters=[
        MetadataFilter(key="Month", value=["September", "October"], operator=FilterOperator.IN)
    ],
    condition=FilterCondition.OR
)

The functionality this doesn't support yet is something like this:
key="Day", value=[7, 14] with an AND filter and operators [GTE, LTE].
Would love to have that functionality as well and then need to extend it to the other vector stores.
Thanks again
Reason
No response
Value of Feature
No response

@mphipps2 for this specific case
key="Day", value=[7, 14] with an AND filter and operators [GTE, LTE].

I think you can do 2 metadata filters? one is for day >=7 and the other is for day <=15
but feel free to help do some refactoring if current logic does not support your use case.


--diff option

We have black checks in our CI to verify that any PRs/pushes are compliant. It would be nice to be able to include blacken-docs in these checks, but I don't want the CI steps to modify any code. Having a --diff option similar to black would be a nice feature that would show in our CI what needs to change.

Via pre-commit you can hook up pre-commit run --all-files --show-diff-on-failure (such that every tool doesn't have to independently implement this)

Yup. The CI check is more there as a sanity check to police ourselves and contributors to make sure we don't have anything slip through.

Actually, I think I misread that comment. I'll take a look and see if that does what I had in mind.

If you're looking for prior art, here's how tox-dev/tox does this

Precommit hooks should do what we need. Closing this out.


Too much recursion error when searching for Gallus gallus metadata

https://www.ebi.ac.uk/gxa/sc/search/metadata/Gallus gallus
The error happens whenever you search for a species in the metadata search box.
For example: liver.
Species are not passes to the controller.

Created PR for this issue, hence closing the issue.


Make the dispatcher socket be connectable by anyone.

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed, 1 unresolved discussion (waiting on @worxli)

c/dispatcher/dispatcher.c, line 353 at r1 (raw file):

        }
    }
    mode_t old_mask = umask(0111);

Add a comment here. E.g.: /* Use 0666 for socket permissions */.

Comments from Reviewable

Review status: all files reviewed, 1 unresolved discussion (waiting on @kormat)

c/dispatcher/dispatcher.c, line 353 at r1 (raw file):
Previously, kormat (Stephen Shirley) wrote…
Add a comment here. E.g.: /* Use 0666 for socket permissions */.

Done.

Comments from Reviewable

Reviewed 1 of 1 files at r2.
Review status: :shipit: complete! all files reviewed, all discussions resolved

Comments from Reviewable