Dangerous permissions are being auto granted even on android M and above.

Whatever dangerous permission I add in Android Manifest file and run the app in emulator or mobile having SDK version >= M, I get that permission automatically. Even if I manually switch off the permission I PermissionsAndroid.request() returns true for that permission. I am following the example code from ReactNative docs. I am using exact code sample and haven't added anything extra.

Hey, thanks for reporting this issue!
It looks like your description is missing some necessary information. Can you please add all the details specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported.
I am going to close this, but feel free to open a new issue with the additional information provided. Thanks!

For someone else with the same problem reported here, I managed to solve this problem by changing android:targetSdkVersion at AndroidManifest.xml file to 23 or higher and targetSdkVersion at build.gradle file to 23 or higher.

@franciscocpg I want to target my app to lower versions also (Kitkat and above). Is there any solution for that?

Yes, just set minSdkVersion
More info:
https://developer.android.com/guide/topics/manifest/uses-sdk-element.html


Simpler null parsing

I noticed that null was generating way too much code. This cleans things up a bit. Not 100% about the fullMatch thing.

@arj03 full match means it'll match the null string fully. you need to check that the next 4 chars are n,u,l,l in that one.
You can use the cmp helper for that, https://github.com/mafintosh/turbo-json-parse/blob/master/lib/ops.js#L47

Sorry disregard that. This is fine.

The fullMatch: false option is allowing the parser to make unsafe shortcuts by not fully parsing the input by expecting the input to be wellformed.

@arj03 tweaked it for you

Thank you :heart:


slow loading issue

Sorry to bother you Andy im using your colorfull example with the jumping slimes , im getting slow load times ,when loading new chunks , is this normal or I should upgrade to your latest build thanks , the reason i didnt upgrade is because I didnt see your updates before ,and I added so much code , it will be a pain to upgrade thanks

Hi, I hate to bring bad news but that demo is reeeally old, I should put a note in the readme. To move to the current engine, you could try just updating the noa dependency and then fixing all the migration issues that occur, but I think it would probably be easier to start with a blank world in the current engine, and then copy over each feature you need.
Generally the best way to make a game on noa is to start by cloning the noa-examples repo, and then hacking on the world inside docs/hello-world. That is pretty much the absolute minimal world, so there's nothing to remove, and a clean slate to build on.

Andy when I remove the topwater that I added , its a material with a game.on(tick) wich creates a water animation , the speed is good now , I guess no water animation for me wath do you think

I see, were you maybe changing the water's voxel ID (with setBlock) every tick? That would be very slow, as when voxel IDs change the engine has to re-mesh the entire chunk.
I haven't tried doing animated textures, but it should be possible. When you register a block material with noa, you can pass in a Babylon JS material, and then that material will be used for those voxels:
var blockmat = new StandardMaterial('', scene)
noa.registerMaterial(name, color, textureURL, texHasAlpha, blockmat)

or something like that. Then, later on at runtime if you dynamically change that material's settings it should affect any mesh using the material, including any voxel terrain meshes using that block material.
Hope that makes sense. I'm not sure if there's any Babylon call you have to do when dynamically changing a material's texture, there might be a markDirty or something (as I believe there used to be in three.js).


Revise bundle and chunk distribution in mapper

In order to improve performance, we took advantage of the fact that each SS2 bundle has only one cell. So, the work that the mapper currently does is pretty trivial: it just distributes a fixed set of bundle uuids to each worker. But 10x bundles will violate that assumption, and the mapper is going to have to check for bundle size and distribute some number of chunks to each worker.

https://github.com/HumanCellAtlas/matrix-service/blob/mckinsel-10x-mapper-docs/docs/10x_mapper_design.md


neo v0.8.0 compatible

Fixes https://github.com/NeuralEnsemble/elephant/issues/253

Coverage decreased (-0.01%) to 75.511% when pulling 7e71250333212f818ebc8cf246d74b01afea8400 on INM-6:neo-v0.8.0 into c78af7ea6cff3645bab306393349aa7d89f05a13 on NeuralEnsemble:master.

Need to wait till NeuralEnsemble/python-neo#746 is resolved and released with a new version.

I'm not quite sure how the NeuralEnsemble/python-neo#746 impinges on elephant.
In that issue, you mention functions called "cut_segment_by_epoch" and "seg_time_slice". Are these elephant functions that are intended to be dropped in the next elephant release because their job is now handled in Neo 0.8.0, but because the performance is unsatisfactory you don't want to drop elephant's implementations yet? I'm having trouble finding them in elephant.
Sorry I'm not understanding!

Some Elephant users have developed and since then have been using these functions that now became a part of neo. But since I know them, I can mention this behavior and caution all other users in the following Elephant release.
As you probably saw, it's not only about cut_segment_by_epoch and seg_time_slice. And this is only one example I ran, I'm not sure how other examples are affected. But true, it should not harden the development and it's better to make minor releases often than waiting for a change.
Let's merge it.

Added todos for the fix of https://github.com/NeuralEnsemble/python-neo/issues/749


typo in readme

Great example @dgeb thanks for building this!
I have a few questions with orbit and ember

Does Orbit schema is designed to be reopened, augmented in a dynamic manner? I found ED pretty limiting in terms of dynamic models and metaprogramming... Something in the lines of

  let userAttrs = this.store.schema.getModel('user').attributes;
  this.store.schema.getModel('user').attributes = { oneNewAttr: { type: 'string' }, ...userAttrs}

  let owner = getOwner(this);
  owner.factoryFor('data-model:user').class.reopen({
	randomNumber: computed('fullName', function() {
            return `The random number for `${this.fullName} is ${Math.random() * 80}`;
	})
  });

This tells me that Orbit jsonapi serializer will pick up new attrs
https://github.com/orbitjs/orbit/blob/b3515b116bd50859fece7452fb8d44411ba21097/packages/%40orbit/jsonapi/src/jsonapi-serializer.ts#L369
Because every serialization will iterate over the current schema model, I'm unsure though if the orbit jsonapi deserializer also handles this dynamic schema nature.
This is something ED doesn't handle at the moment, if you reopen a model to add a few dynamic DS.attr() the serializer and deserializer won't pick up them, to be honest, I'm unsure why, I had to hack around it

Can a Source be used in draft manner, let's say an IndexedDB draft.js Source? and sync to a jsonapi source, manually?
Can some strategies apply only to some models

Thanks for the awesome work!

First of all, thanks for fixing that typo, @betocantu93!
Let me try to answer your questions:

Does Orbit schema is designed to be reopened, augmented in a dynamic manner?

Each Orbit Schema is both versioned and can be upgraded. This gives all sources the opportunity to respond to an upgrade. For instance, an IndexedDBSource might update its tables as part of a schema upgrade.
Ember-orbit adds the model layer on top of the schema. To dynamically upgrade a model, I might upgrade the schema first, then register a new model class (e.g. data-model:planet) over the top of the old one. I actually haven't tested this, and it could be made a bit more ergonomic, but it should work.

Can a Source be used in draft manner, let's say an IndexedDB draft.js Source?

Do you mean https://draftjs.org ? Or do you mean the concept of a draft, i.e. edit, mode?

Can some strategies apply only to some models?

Implement a filter method on strategies (see the auto-generated comments) and return a truthy value to have the strategy be applied, or falsy to ignore the strategy for this particular request.

@dgeb thanks for the answer

Do you mean https://draftjs.org ? Or do you mean the concept of a draft, i.e. edit, mode?

I meant the concept of drafting models, currently we use ember-local-storage and have 2 versions of the same model, one meant to get saved in localStorage while drafting (i.e. while offline) and the other model is just a normal ED model using a remote.
i.e. models/improvement-report.js and models/improvement-report-local.js
When we sync, we first copy recursively (i.e. relationships) the contents of models/improvement-report-local.js to a normal models/improvement-report.js and save it.
We would like to overly simplify this, and I think Orbit has the answer for us at Prysmex One idea is to have an IndexedDB Source exclusively to store data-models drafts, and sync them manually when online.
Or perhaps I can just filter the strategies in some manner and keep it simplier with only an IndexedDB backup Source, but this repo definitely gives me a playground

@betocantu93 I would recommend that you explore the Orbit concept of "forking", as described here.
A fork will allow you to edit not just a single record, but any records and relationships, in isolation. Because memory sources use immutable data, you're able to start with all the data and relationships immediately in the fork, and there's no copying involved.
When trying out forking with ember-orbit, you'll want to ensure that models from one store don't mix with those from a fork. This is because the data could diverge (just like git branches) and it could get confusing.
You can also configure a local storage or indexeddb source together with your fork, give it a unique name, and backup data from the fork to the browser storage source. You could perhaps create a unique coordinator and strategies to manage the synchronization or you could do it directly with events - your choice. Either way, you'll want some sort of coordination that lasts just as long as the drafts themselves.

this repo definitely gives me a playground

Great - that was my intention :)


feat: update default version of ArgoCD to 2.2.1 from 2.1.7, correct which directory is added to the PATH for re-using the cached ArgoCD binary; closes

Description

correct which directory is added to the PATH for re-using the cached ArgoCD binary; closes #8
update dependencies to latest (dev deps only)
update default version of ArgoCD to 2.2.1 from 2.1.7

Motivation and Context

Closes #8

How Has This Been Tested?

CI checks and re-run workflows multiple times to check caching

Screenshots (if appropriate):

:tada: This PR is included in version 1.6.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[cherry-pick][branch-2.0] Fix null pointer error of column upserted (#6764)

What type of PR is this：

[x] bug
[ ] feature
[ ] enhancement
[ ] refactor
[ ] others

Which issues of this PR fixes ：

Fixes #6697
Problem Summary(Required) ：

Jump out of current for loop if segment iterator is a nullptr. Otherwise, the columns upserted will throw a null pointer error.

run starrocks_be_unittest

run starrocks_fe_unittest

branch-2.0 will not crash because those crash code snippet was not added yet, this null pointer actually exists, but was not be triggered. Be careful since there is potential risk once another PR which will trigger this bug merged into branch-2.0 in the future.


[ffmpeg] Fix using of deprecated macro.

These changes fix the using of AV_CODEC_CAP_INTRA_ONLY macro, which was fully deprecated from ffmpeg from release 6.0. To be able to build with the latest version of ffmpeg we need to use AVCodecDescriptor.props instead.

@bjuncek
Hi! Could you review this please?

@pmeier
Hi! Could you look at this change please?

Sorry @kobrineli but this seems to be breaking a bunch of tests  https://hud.pytorch.org/pr/pytorch/vision/7790#15518486554
2023-08-01T13:15:51.5334730Z test/test_videoapi.py::TestVideoApi::test_frame_reading_mem_vs_file[video_reader-RATRACE_wave_f_nm_np1_fr_goo_37.avi-video] Fatal Python error: Segmentation fault

I don't think we support ffmpeg 6, and in general I wouldn't recommend relying on those video decoders, sorry. There's plenty of unadressed edge-cases and ffmpeg conflicts happen all the time. We hope to be able to provide a better video decoding suite for pytorch soon, but there's no definite ETA for now.

@NicolasHug
Alright, no problem
Then I close the PR


service builder template created in workspace contains settings.gradle

settings.gradle should never be included anywhere but the root project

https://github.com/gamerson/liferay-blade-tools/pull/156

almost the same time .... I sent the pr .. :)

@david-truong How about our servicebuilder template settings.gradle file which contains include project configuration? rename it or move include configuration.

We only need to remove it for workspace builds which will automatically
include projects.  Don’t need to rename it or move include configurations
On Thu, Mar 3, 2016 at 10:12 PM Lovett Li<EMAIL_ADDRESS>wrote:

@david-truong https://github.com/david-truong How about our
servicebuilder template settings.gradle file which contains include project
configuration? rename it or move include configuration.
—
Reply to this email directly or view it on GitHub
https://github.com/gamerson/liferay-blade-tools/issues/153#issuecomment-192090964
.

@david-truong is this fixed now?

should be ;-)
On Fri, Mar 4, 2016 at 10:14 AM Gregory Amerson<EMAIL_ADDRESS>wrote:

@david-truong https://github.com/david-truong is this fixed now?
—
Reply to this email directly or view it on GitHub
https://github.com/gamerson/liferay-blade-tools/issues/153#issuecomment-192339549
.

do we have a unit test for it?

Yep
On Fri, Mar 4, 2016 at 10:30 AM Gregory Amerson<EMAIL_ADDRESS>wrote:

do we have a unit test for it?
—
Reply to this email directly or view it on GitHub
https://github.com/gamerson/liferay-blade-tools/issues/153#issuecomment-192344220
.


Investigate dates pattern feedback

Background
A user provided feedback on the dates pattern via the Discussions board #22.
Issue
User feedback provided:

This component contains invalid html and is therefore breaking web standards. The min and max attributes are not valid on input type of text and considering that browser validation is recommended to be turned off there's little value in having them. Self closing tags are also invalid /> and should be removed.

Tasks

[x] Investigate the issue and research the relevant standards
[x] Decide whether changes need to be made to the pattern
[x] If so, raise a ticket outlining the work required
[ ] PM to update the user

Definition of Done

[ ] We know whether we will makes changes to this pattern
[ ] A ticket(s) is raised to cover the work required
[ ] The user has been updated

On inputs that have the type param set to "number" we override that with "text" due to a bug with Firefox and Safari (https://bugzilla.mozilla.org/show_bug.cgi?id=1398528). So we should remove the min and max attributes for inputs that have this type.
For the self closing tags, this is not invalid HTML so we don't need to make that change.

I have updated the user with the outcome of this ticket.


Dev

Description

Integrate Mitiq into OpenQAOA to allow error mitigation techniques to take place during the execution of the QAOA. We have created a wrapper focusing on the ZNE technique following a similar structure to the SPAM Twirling wrapper.
This is a project born from the Quantum Open Source Foundation Mentorship program
New dependency to add: Mitiq
Fixes #207

Checklist

[x] I have performed a self-review of my code.
[x] I have commented my code and used numpy-style docstrings
[ ] I have made corresponding updates to the documentation.
[x] My changes generate no new warnings
[ ] I have added/updated tests to make sure bugfix/feature works.
[x] New and existing unit tests pass locally with my changes.

Type of change
Please delete options that are not relevant.

[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update

How Has This Been Tested?
We have been testing the wrapper with the Max Cut problem but we need help on defining unit-tests. What will be the best test to add?

Hi! As I mentioned in the description, we need some help defining the unit tests for the integration. At the moment, we are running multiple tests with the Max Cut problem using a noise model, and different parameters of the ZNE

Hi @KilianPoirier,
All the comments have been addressed, and the dev branch has been merged. We have added two tests similar to the SPAM wrapper, it is still necessary to add a couple more, and we plan to do it next week. I think you can now review all these changes.
The example notebook is a good idea. Do we do that in this PR or create another one?
Thanks!

Hi @KilianPoirier,
I have added mitiq to the requirements, but the tests are still waiting for approval. Some of the previous errors were related to that issue.
We are going to work on the example notebooks and the rest of the tests.
Thanks!

Hi @victor-onofre ,
Thanks for updating the requirements.
Good news, the tests are passing! Let me know when you implement your own tests and the example notebook.

Hi @KilianPoirier! We have push an update with the example notebook and the tests. Now is ready for another review.
Thanks!

Hey @victor-onofre , it seems the regular tests are failing now.
It is most likely due to the use of images in your example notebook. Can you try copying the images directly in the notebook without using PIL?
I believe that if the notebook is ran correctly and the image is resolved, the image itself will be tracked in the notebook without a need to import it.
I will also have a look at the docs and let you know if I find anything.


Install CoreMLHelpers via pods

use https://github.com/hollance/CoreMLHelpers/blob/master/CoreMLHelpers.podspec

moved https://github.com/kenmaz/SRCNNKit/issues/1


Throw previous error if there's a timeout

Right now, code like this will actually throw the error 'RetryOperation timeout occurred' which originates in node-retry. It should throw the error I made ("HI" + Math.random()), but doesn't because of a timeout error.
import * as retry from 'async-retry'

async function throwsErrors(){
  await delay(1000)
  throw new Error("HI" + Math.random())
}

retry(
  async (bail, attempt) => {
      await throwsErrors()
  } , {
    maxRetryTime: 100,
    minTimeout: 2,
    randomize: true,
    retries: 100,
    onRetry: console.log
  }
).then(console.log)

async function delay(milliseconds: number) {
  return new Promise(resolve => setTimeout(resolve, milliseconds))
}

I made an issue in node-retry that describes why this happens in detail, but the gist is that if you call retryOperation.retry(err) and there's a timeout error, node-retry drops err. I'm not sure if this is something that node-retry needs to support or if it's something that you can/should handle here.

We created this PR on node-retry, though I'm not sure how long it'll take until it gets looked at
https://github.com/tim-kos/node-retry/pull/71

Has anyone had a chance to look at this?


remove all support for python 3.6

Issue #, if available:
#704

I think this PR is okay to merge as long as the e2e test passes.

Taken care of in PR #732 for v5.1.0


Insertion Sort

❗Write Code in Only One Language (CPP, C, Java, Python)
Give File Name :  ✅ In respective language folder
📑 DESCRIPTION
Problem Title

Problem Statement:
Explain the problem
Note:
If any
Input Format:
Input format here

Output Format:
Output format here

Example
Example

Sample Input 1
Sample input 1

Sample Output 1
Sample output 1

Sample Input 2
Sample input 2

Sample Output 2
Sample output 2

Constraints
Constraints and complexity

Link of Problem If Copied from Some Site

Please assign this issue to me.
I've already made a Pr but you rejected it asking me to create an issue for it and then solve it.
Thank you.

The issue template is supposed to be used as a framework to create the issue.
You need to fill in all the fields and enter all required details to create a valid problem statement.
Refer to  CONTRIBUTING.md for more details.


SSL / TLS error with apache-http Dockerfile

Hello,
I had a SSL/TLS problem with the apache-http Dockerfile.
When i launched the docker build -t apache-http-win:latest (i called my image apache-http-win because i have linux apache image), i had the following error:
PS D:\docker-data\apache-http-win> docker build -t apache-http-win:latest .
Sending build context to Docker daemon   2.56kB
Step 1/6 : FROM mcr.microsoft.com/windows/servercore
 ---> ea9f7aa13d03
Step 2/6 : LABEL Description="Apache" Vendor="Apache Software Foundation" Version="2.4.23"
 ---> Using cache
 ---> ad49d4af1b13
Step 3/6 : RUN powershell -Command      $ErrorActionPreference = 'Stop';        Invoke-WebRequest -Uri https://www.apachelounge.com/download/VC14/binaries/httpd-2.4.23-win64-VC14.zip -OutFile c:\apache.zip ;         Expand-Archive -Path c:\apache.zip -DestinationPath c:\ ;       Remove-Item c:\apache.zip -Force
 ---> Running in c1bdf1b29820
Invoke-WebRequest : The request was aborted: Could not create SSL/TLS secure
channel.
At line:1 char:34
+ ... e = 'Stop'; Invoke-WebRequest -Uri https://www.apachelounge.com/downl ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (System.Net.HttpWebRequest:Htt
   pWebRequest) [Invoke-WebRequest], WebException
    + FullyQualifiedErrorId : WebCmdletWebResponseException,Microsoft.PowerShe
   ll.Commands.InvokeWebRequestCommand

To resolve the problem, you should add the following line:
[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12;
to each powershell command to add support to TLS 1.2
For the apache lounge version, the download link is broken. The new one is:
https://home.apache.org/~steffenal/VC14/binaries/httpd-2.4.38-win64-VC14.zip
After adding TLS support and changing the httpd URL, everything works fine :-)
Do i create i pull request for this issue ?
Frederic

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Entity Inventories

Add support for entity inventories:

[x] -Add support for minecart inventories

[ ] -Add support for horses/donkeys/llamas with chests (you need to open their inventories via shift click)

[x] -Maybe villager/wandering trader inventories

After a crazy long amount of time, I've started working on this feature!
Here is Minecart inventories working:
https://user-images.githubusercontent.com/57331134/180334281-ed1c56cc-adc0-49d2-afd6-5d569acfe1d0.mp4
I still need to filter entities, right now it shows tabs for every single one (the furnace Minecart does not need a tab, for example)

Just going to document the issues with this so far so they're tracked:
Each type of entity gets only one tab: (here's two famers)

Detection method adds every entity that has a use interaction (I think?) - allays have been noted, here's an unemployed villager:

Villager method has no context sensitivity:

This sleeping villager wont be woken by clicking the tab (that's a completely seperate use action that needs to occur first)
Instinctively - villagers have so much additional context and settings that they're probably better implemented as a sub-type of EntityTab instead of just Simple.


Karate-Gatling - failed response validation not marking requests as KO in some cases

Consider running the following test:
Feature:

  Background:
    * url 'http://date.jsontest.com'

  @name=test1
  Scenario:
    Given path 'foo'
    When method get
    Then status 404

A GET to http://date.jsontest.com/foo returns 200, so the status match line fails. In the test report the request is marked as "KO". This is the expected behaviour.
I want to have the construction and sending of a request as a reusable feature. I then want to call this from another feature and then validate the status/response there.
Consider test2:
  @name=test2
  Scenario:
    When def result = call read('classpath:examples/test.feature@name=bar')
    Then match result.responseStatus == 404

  @name=bar
  Scenario:
    Given path 'foo'
    Then method get

As with the previous test, the status match line fails. However in the test report the request is marked as "OK".
Test3 and test4 which call test1 and test2 respectively give the same results as test1 ("KO") and test2 ("OK") respectively:
  @name=test3
  Scenario:
    * def result = call read('classpath:examples/test.feature@name=test1')

  @name=test4
  Scenario:
    * def result = call read('classpath:examples/test.feature@name=test2')

It therefore appears that a request is marked as "KO" only if the response validation failure occurs within the same scenario as the request is made. I expected that a failed match statement would always mark the request before it as "KO" regardless of how it was structured.
These examples can be run using:
mvn test -D gatling.simulationClass=examples.TestSimulation1
mvn test -D gatling.simulationClass=examples.TestSimulation2
mvn test -D gatling.simulationClass=examples.TestSimulation3
mvn test -D gatling.simulationClass=examples.TestSimulation4

Issue found using 0.9.9.RC2 but also present on 0.9.6.
Example projects attached.
myproject-0.9.9.RC2.zip
myproject-0.9.6.zip

@theathlete3141 had a quick look and can't understand it. see if you can submit a PR in the next week or 2 else we'll probably release 1.0 without this.

@theathlete3141 had a quick look and can't understand it. see if you can submit a PR in the next week or 2 else we'll probably release 1.0 without this.

I noticed something similar takes place when "retry until" is involved with Gatling.  In these instances, all but the last retry attempt results in an OK (the last is flagged a OK or KO depending on whether or not the test ultimately passed or failed).  So, for example, if you set the retry count to 5, and run constantUsersPerSec(1) during (1 second), if the test is retried and failed all 5 times, you'll see 4 OKs and 1 KO added to the results.
My thought was, we should probably only register a single OK or KO in these instances, based on the last retry attempt, but I could also see an argument for recording each attempt in the count...but if each attempt is recorded, I would think all attempts leading up to the final should count as KOs.

closing as wontfix PR-s welcome


Restricted value range for "always valid" enumeration types

The Always_Valid aspect of enumeration types is too permissive in some cases. One example would be the EtherType of Ethernet frames, where all values must be greater or equal to 1536. For this case giving an allowed value value range would be the better solution.

As an alternative to extending the Always_Valid attribute, we could also consider to allow enumerations to be a subtype of scalar types. The scenario above could be realized like this:
type Ether_Type_Base is range 1536 .. 65535 with Size => 16;
type Ether_Type is new Ether_Type_Base with
   (ET_IPv4 => 16#0800#,
    ...);


⚠ Bofrost.de has degraded performance

In f954215, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1514 ms

Resolved: Bofrost.de performance has improved in 7c8fbdb.


Handling multiple Set-Cookie in the response

Multiple Set-Cookie in Http response are not handled in Android project.
Test project:
https://github.com/farcasclaudiu/TestModernHttpClient
it behaving the same even with the initial Paul McBets ModernHttpClient. :(

Also. I have tested on iOS, the situation is the same :(

I will take a look.

Is it handled in other platforms?

Correcting this in next release.


removed Fixnum reference

Since the Ruby-2.4.0 release, Fixnum and Bignum are combined into Integer class. This fix is to remove all Fixnum reference.

@gerrywastaken Any chance we can merge this PR?

I also get warning without #293 patch.
My environment is as follows:
$ ruby -v
ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-darwin14]

$ gem list awesome_print

*** LOCAL GEMS ***

awesome_print (1.7.0)

Warning has occurred as follows:
$ irb
irb(main):001:0> require 'awesome_print'
=> true
irb(main):002:0> ap 123
123
=> nil
irb(main):003:0> ap [123]
/Users/murakami/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/awesome_print-1.7.0/lib/awesome_print/formatters/base_formatter.rb:31: warning: constant ::Fixnum is deprecated
[
    [0] 123
]
=> nil
irb(main):004:0>

Here is related news.
Feature #12005: Unify Fixnum and Bignum into Integer - Ruby trunk - Ruby Issue Tracking System
https://bugs.ruby-lang.org/issues/12005

Thanks @jamespdo I'll need to figure out the build issue first then I can merge. Cheers for this. :)
cc: @irobayna.
@murakamit I'm not sure what you are saying here. Indeed this pull request solves a problem. If you do not apply it, if the fix is not applied it is expected you will still have the issue. I might be misunderstanding you.

Associated issue: https://github.com/awesome-print/awesome_print/issues/299

Merged, cheers for the fix. :)

This is still in place in the currently published gem (1.7.0) is there going to be a new release or should we be pointing to master when installing this gem?

@gerrywastaken can you release new version which include this merge? or release 1.7.1 to patch if its not ready?


Homepage: Alert banner about the urgency of the upgrade?

I was expecting the git-scm.com homepage to convey some sort of urgency about this upgrade  - maybe something to the effect of a flashing red alert/banner, explaining the situation? Am I not seeing it because I'm on a Linux, or ...?

This no longer seems to be an issue and should be closed.
If I'm mistaken, please correct me, because I have no context for this whatsoever.


Feature/net validator

Fixes validator issue
Change default behavior to validate network by default
Remove validate arg and replace with --no-validate to disable network validation
Adds new status to session when validating

New status needs to be added to UI. UI currently shows no status during validation but continues to work as expected if page is refreshed after validation ends.

I'm not sure I believe there is a real need for network validation involving a faux device anymore. It is a very rare case that the network services do not function correctly and are now quite stable. For an additional 1:30 on each Testrun, I do not think it adds that much value.
Also, when I have tested this PR, the faux dev reported a failure in ping to google.com and ntp sync failed for some reason. Despite there being network failures reported (though not in practice), this did not have an effect on Testrun. Surely we would want to prevent the user going any further if it was not successful?
Anyway, I think the best approach would be to have network validation not run by default but for us to setup an automated GitHub action that verifies all network services work as expected.

We have had two instances of updates/upgrades to underlying packages that have broken internet access and/or installations that are incomplete that this check could give the warning to a user about something being wrong. I don't think it should be abandoned, but maybe switched back to an optional  --validate option so we can instruct testers to run it in validation mode to try to pull out additional issues about what services might be misbehaving.
Not sure what failures you are experiencing with it but since this one has been sitting a while, it might need some updates to correct depending on what they are.
The reason we can't do the automated github actions alone is the same reason we can't do internet based testing in that environment, until that is resolved, it can't be relied on as a comprehensive solution.

We have had two instances of updates/upgrades to underlying packages that have broken internet access and/or installations that are incomplete that this check could give the warning to a user about something being wrong. I don't think it should be abandoned, but maybe switched back to an optional --validate option so we can instruct testers to run it in validation mode to try to pull out additional issues about what services might be misbehaving.
Not sure what failures you are experiencing with it but since this one has been sitting a while, it might need some updates to correct depending on what they are.
The reason we can't do the automated github actions alone is the same reason we can't do internet based testing in that environment, until that is resolved, it can't be relied on as a comprehensive solution.

I agree with going with the optional --validate so that we can ask manufacturers to do this on demand for troubleshooting. The issue I was having (maybe just not implemented) is that even if some of the services don't work, the output does not seem to be any different (except for the JSON). We should have a clear command line output that states which services are not working and any troubleshooting detail.

Default behavior is now switched to validator disabled and only runs when requested.  No system is in place to check these results as I believe we have now decided this will be more of a diagnostic tool when issues are reported.
Since this also adds a new status, the UI still needs to be updated to handle the new status because it will appear broken during the validator state and requires a browser refresh once complete.

@jboddey UI updated to resolve the new validator status correctly.

@jhughesbiot  I tested this feature and during the validation the UI is not showing the status, it is showing a blank page. After the validation step I refreshed the page and it continued to work as expected.
The test duration was 14m 59s
The backend logs:


feat: region parameter support

Adds the region optional parameter to the plugin.
This allows the AWS region to be set in a fashion that's compatible with all AWS SDK and CLI versions. It is not strictly required for role assumption, but experience with the cultureamp/aws-assume-role plugin suggests that this is a highly useful feature.
It has the added benefit of easing the transition from one plugin to another significantly. The Culture Amp plugin has been the recommended plugin for some time: as companies begin to invest into moving towards OIDC, this will make the transition simple.
Also, for those companies that are seeking to automate the change from one plugin to another (as we are), this makes it dead easy.
Closes #10.

[!IMPORTANT]
Depends on #12 (addition of unit tests): it's expected that this PR will be merged first.

The primary reason is to set the region for the build.
I think I get what you're driving at here. I will move the region setting to be after the sts call, so it uses the default global endpoint.
If a regional STS endpoint was needed, it could be supported with a different parameter.

tbh I wasn't driving at a particular outcome, I was mostly curious about your goals to help understand the propose changes :)

tbh I wasn't driving at a particular outcome

Sorry for jumping to conclusions!
Putting it before was a change in behaviour from the other plugin, and I wasn't sure about it anyway.
I'm glad for your questioning, and I've shifted it afterwards. If changing the sts endpoint was desired, we could support that separately.


Token Invalid - no way to refresh except of deinstall

I don't see a option to reffresh the token and i installed it forgott ab-ou**-/t it....

Just restart the addon, should give you a new one.


Running DA_paper examples: successes and errors

Hi,
I'm running through the full set of DA_paper examples from a successfully built mlptrain-ace environment.  Here are my results so far:

training/implicit worked marvelously.  The calculation went to completion.

training/explicit is running without any issues so far.

uphill.py and pes.py error out with:
Traceback (most recent call last):
File "/cluster/home/tanoury/Duarte-codes/mlp-train/examples/DA_paper/2D_pes/pes.py", line 12, in
from mlptrain.md import _convert_ase_traj
ModuleNotFoundError: No module named 'mlptrain.md'

fes.py (in 1d_fes) errors out due to not finding 'endo_in_water_ace_wB97M.json':The above exception was the direct cause of the following exception:

Traceback (most recent call last):
File "/cluster/home/tanoury/Duarte-codes/mlp-train/examples/DA_paper/1d_fes/fes.py", line 40, in
us.run_umbrella_sampling(irc,
File "/cluster/home/tanoury/Duarte-codes/mlp-train/mlptrain/sampling/umbrella.py", line 454, in run_umbrella_sampling
window_traj = window_process.get()
File "/cluster/home/tanoury/miniconda3/envs/mlptrain-ace/lib/python3.9/multiprocessing/pool.py", line 771, in get
raise self._value
julia.core.JuliaError: Exception 'SystemError: opening file "./endo_in_water_ace_wB97M.json": No such file or directory' occurred while calling julia code:
D = load_dict("./endo_in_water_ace_wB97M.json")
All the best,
Jerry

Hi,
Still plugging away at running your code in my environment.
I was able to get around some of the above errors by editing some of the scripts on my own copy (not sure if the specific workaround/edits are the correct way to address the errors??).

I was able to fix the uphill.py and pes.py errors by copying md.py from mlptrain/sampling directory ro mlptrain directory.  pes.py then gave me another error:
File "/cluster/home/tanoury/Duarte-codes/
explicit_training_error.txt
explicit_training_error.txt
mlp-train/examples/DA_paper/2D_pes/pes.py", line 256, in
@mlt.utils.work_in_tmp_dir(copied_exts=['.xml', '.json'])
TypeError: work_in_tmp_dir() got an unexpected keyword argument 'copied_exts'

I was able to fix this by changing 'copied_exts' to 'copied_substring'
After I made these changes, the subsequent errors were:
julia.core.JuliaError: Exception 'SystemError: opening file "./endo_in_water_ace_wB97M.json": No such file or directory' occurred while calling julia code:
D = load_dict("./endo_in_water_ace_wB97M.json")
I presume this json file would be the actual mlp from the explicit training.

Upon trying  endo_ace_ex.py ( located in DA_paper/training/explicit) again, got a long error readout.  See attached file.

All the best,
Jerry


SyntaxError: Missing parentheses in call to 'print'

Hello, I'm trying to run the SmartMirror Py for the first time and I'm getting this error. (line 201-202) I am new to this. Please help.
            if location2 == ", ":
                self.location = "Cannot Pinpoint Location"
                self.locationLbl.config(text="Cannot Pinpoint Location")
            else:
                self.location = location2
                self.locationLbl.config(text=location2)
    except Exception as e:
        traceback.print_exc()
        print "Error: %s. Cannot get weather." % e

    self.after(600000, self.get_weather)

Disclaimer, have not used this project at all.
However, that sounds awfully like you're using python 3 and the project is written in python 2.
Try using python from the command line instead of python3, if you're using the latter. If not, it gets a bit more complicated - I'd suggest googling "changing default python for "

In python 2, print statement did not require parantheses but in python 3, it is more like a function and require "( )". Just use ( ) and then change imports from Tkinter to tkinter. Then the code should run just fine in python 3 as well.


Dash change 2

"claim Pool Emissions" button not linked -- straight to tx?
--> first change on new dash (more coming)

#42


C# markup like maui?

Can we have support for C# markup?
xml is really hard to read and without a vscode designer which may take a while it makes it difficult to test alternetui out.
I did try to create my ui with C# but ran into lots of errors and crashes due to me not using the right properties in the right context.
It shouldn't be too hard to support if there is a c# markup library out there that can bind to xml.
If it is too much work I can try to use c# again

I am not sure I understand this issue correctly.  Could you please give more details, provide some examples? How form.uixml, from.g.cs, form.cs should look like?

@generalloki https://learn.microsoft.com/en-us/dotnet/communitytoolkit/maui/markup/markup

Idea is great. We will think about it. I personally like c# markup better than xml markup. And to make Alternet.UI c# markup compatible with Maui would be great.  I will post here an update if we decide to work on this.

I am moving this discussions


autoprefixer: Replace color-adjust to print-color-adjust. The color-adjust shorthand is currently deprecated

"postcss-loader": "^7.0.0",

How can i fix this problem?
console warning
autoprefixer: Replace color-adjust to print-color-adjust. The color-adjust shorthand is currently deprecated

Please follow the warning mesage and change color-adjust on print-color-adjust in yout source code

@ktsangop autoprefixer is not dependecy of postcss-loader, angular CLI uses this plugin, if you got this warning it means you have color-adjust in your source code (you have code in your dependecies check it, also other plugins before autoprefixer can generate code and late postcss throw a warning on code, double check it)

@alexander-akait sorry that was my bad I misread the yarn why output.
The package that depends on autoprefixer is postcss-preset-env which does have the deprecated color-adjust.


Relicense to MIT or Apache 2.0.

I'd like to relicense this plugin to be compatible with Bevy.
I'm not going to be super formal about this. If all contributors agree by commenting on this issue, I'll merge this PR and relicense. If not, I'll rewrite the necessary code if the solution is not the obvious/only way to do a thing.
CC @rightfulerror @Silcet @jakobhellermann
Thanks!

TL;DR LGTM
I think it is great that you are trying to make it compatible with Bevy. Also, I'm ok with the license change ;)
For the rest of you, if you want to look into the licenses before agreeing I'd recommend these links:
https://tldrlegal.com/license/mit-license
https://tldrlegal.com/license/apache-license-2.0-(apache-2.0)
In my understanding, the main difference is that with Apache 2.0 they can't use the trademark and they have to include NOTICE and state the changes they make to the code if they redestribute. Otherwise, it looks the same.

I'm okay with the license change 👍

Thanks everyone! Still waiting on @rightfulerror.

Yep, I'm absolutely fine with this!

Excellent, thanks everyone!


fix(material/snack-bar): fix Firefox/JAWS not reading out snackbar me…

…ssage
Add role="alert" to snackbar container.
Known issue: JAWS does not read out aria-live region unless it has role="alert"
https://bugzilla.mozilla.org/show_bug.cgi?id=1453673
Fixes https://github.com/angular/components/issues/21137

cc @zelliott
I'm concerned this might have unintended consequences. One issue I see is that role="alert" is always treated as "assertive", which means they interrupt other content. I believe the default snackbar politeness should be "polite". Without testing I wouldn't know for sure, but I'd also wonder if having both aria-live and role="alert" would lead to double announcements.
The Firefox bug you point to also seems like the issue is somewhat inconsistent? It might be better to leave the snackbar as-is and leave this as a known Firefox + JAWS bug outside of our responsibility.

cc @zelliott
I'm concerned this might have unintended consequences. One issue I see is that role="alert" is always treated as "assertive", which means they interrupt other content. I believe the default snackbar politeness should be "polite". Without testing I wouldn't know for sure, but I'd also wonder if having both aria-live and role="alert" would lead to double announcements.
The Firefox bug you point to also seems like the issue is somewhat inconsistent? It might be better to leave the snackbar as-is and leave this as a known Firefox + JAWS bug outside of our responsibility.

cc @haywoodsloan as the resident snackbar expert I defer all snackbar questions to :)

cc @haywoodsloan as the resident snackbar expert I defer all snackbar questions to :)

When I worked on #20487 I switched the snackbar from using role="alert" or role="status" to aria-live="assertive" and aria-live="polite". When testing JAWS, NVDA, VoiceOver, and ChromeVox I found aria-live gave more consistent behavior between the SRs. I did most of that testing on Chrome though.
I wouldn't recommend setting role="alert" statically as that does imply aria-live="assertive" and could cause unexpected behavior if aria-live="polite" is explicitly set. Could consider setting role="alert" when aria-live="assertive" and role="status" when aria-live="polite". I haven't tested having both set myself, but have seen recommendations to use both for maximum compatibility.
The only report I've seen of setting both role and aria-live causing issues is here: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Live_Regions#preferring_specialized_live_region_roles. Potentially causing double speaking on VoiceOver on iOS, but that might be a fair tradeoff to support Firefox + JAWS better.

When I worked on #20487 I switched the snackbar from using role="alert" or role="status" to aria-live="assertive" and aria-live="polite". When testing JAWS, NVDA, VoiceOver, and ChromeVox I found aria-live gave more consistent behavior between the SRs. I did most of that testing on Chrome though.
I wouldn't recommend setting role="alert" statically as that does imply aria-live="assertive" and could cause unexpected behavior if aria-live="polite" is explicitly set. Could consider setting role="alert" when aria-live="assertive" and role="status" when aria-live="polite". I haven't tested having both set myself, but have seen recommendations to use both for maximum compatibility.
The only report I've seen of setting both role and aria-live causing issues is here: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Live_Regions#preferring_specialized_live_region_roles. Potentially causing double speaking on VoiceOver on iOS, but that might be a fair tradeoff to support Firefox + JAWS better.

We have precedent for only doing certain behaviors based on the platform (e.g. Firefox only) specifically for screen-reader issues like this. @annieyw we could explore using Platform to only add role="alert" or role="status" as appropriate for Firefox only.

We have precedent for only doing certain behaviors based on the platform (e.g. Firefox only) specifically for screen-reader issues like this. @annieyw we could explore using Platform to only add role="alert" or role="status" as appropriate for Firefox only.

Changed to only adding role for Firefox and added unit tests.

Changed to only adding role for Firefox and added unit tests.

Looks like the API gold needs to be updated

Looks like the API gold needs to be updated


AVRO-3650: [C++] Fix build on Manjaro

What is the purpose of the change
Fix the build on distros with a newer boost library or compiler - AVRO-3650.
Upgrades C++ version from 11 to 17 - AVRO-3610
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
(More accurately, it now builds.)

Thank you, @jmccl !


Update pom on helloworld-servlet

Coverage remained the same at 0.0% when pulling e3cd14f79295014fecc3e9a1a07316bd9871bd44 on helloworld into 59edcc2ce702cc7b5eb18617d8faff06cdebe974 on master.

LGTM once travis passes.

Coverage remained the same at 0.0% when pulling 8c38f252dd4527abb4bb74e2b5a28ab255a09ac4 on helloworld into 59edcc2ce702cc7b5eb18617d8faff06cdebe974 on master.


[Bug]: Enable/Disable quotes wrap with frontmatter fields setting does not seems to work as expected

Contact Details
No response
What happened?
When the "Enable/Disable quotes wrap with frontmatter fields" setting is disabled, it still wrap frontmatter fields with quotes. Furthermore, it also does it to inline field. I also noticed that updating a field A (inline in this case) will make the plugin wrap in double quotes a field B (in YAML) for the same note... Here's a video that displays the whole thing. Note that I had also disabled this setting in the plugin options. I also did test it when enabled just in case and still, same outcome.
https://user-images.githubusercontent.com/80559262/196019285-10aae317-f03e-4526-82ea-e29975b9c8dd.mp4
What platform were you using?
Desktop
Version of the plugin
2.7.2
Relevant log output
No response
Are you using the latest version of the plugin in your Obsidian vault?

[X] I have verified that I am on the latest version

Are you check if there is a similar issue?

[X] I have verified that there are not similar issues

even if the option it’s disabled there are cases when we need to wrap with quotes the yaml to prevent possible errors
the wrap was used because the value contains : and its a potential yaml breaker
On the other hand, the inline field should not be necessary to wrap it, I will investigate the reason

the wrap was used because the value contains : and its a potential yaml breaker

I see ! I did not think about this but it makes sense.

On the other hand, the inline field should not be necessary to wrap it, I will investigate the reason

Awesome, thanks a lot !


Create separate entry points for different builds

We can distinguish two different build types:

Builds that output a single file. This is the case for our amd/umd/system js files.
Builds that output a file per module. This is the case for the es6 build and the output to the 'lib' folder for npm.

We now have a single typescript entry point when building our source files, namely src/index.ts. However, we cannot have a single entry point that is optimized for both of the build types described above. Some example differences between the builds:

We would want to include the ts-helpers module in our single-file output and add the noEmitHelpers flag in the typescript compiler because this will make our bundle size smaller. It is however not possible to use this flag in our lib/es6 output, because we need the guarantee that the helpers are included on every imported module.
In the single file builds, we want to export modules that are not a dependency of the default exports so they are still reachable from the outside. This does not make sense in the other builds, because these modules are already exported as a separate file.

How would we name these entry files to prevent any confusion?

As an addition, builds that output a file per module (typescript-npm and typescript-es6) have a difference on it's own.
The current index.ts acts as a entry point for easy convenience. import ... from "seng-module", where default and named exports can be accessed. Other files not referenced from this main file need to be imported from "seng-module/lib/...".
As this affects the bundle size when this module is used in another project, we don't want to reference too much files in there; as a rule of thumb we should only add files that are imported in general use cases of the module, and/or files that are internally referenced by the default export class itself (as that doesn't influence the bundle size).
Other files (that can be used standalone, or are optional plugins for the main file) are not referenced by the index.ts, and are currently not compiled and moved to the output folder. (There is no Dummy.js in the output folders.)
The only other option besides referencing them in the index.ts (what we do not want) is to include them in the "files" section of the tsconfig.json.
With TypeScript 1.x this should be done per-file, but in TypeScript 2.0 they finally introduced globbing in the "include" section of the tsconfig.json.
It looks like for those cases, using that method is the only option.
And I think that the systemjs target built with tsc can use the same 'main' file as the other targets being built with webpack.
So to conclude, I think we end up with 3 methods:

index.ts for npm and es6 targets (for default export and convenience named exports)
"files" or "include" to also compile and move other files
lib.ts (or other name) as an entry for single-file-output libs (used by webpack and typescript-system`)


Variable_value to work with other rule types than value metadata check against the define-xml

To support further development of custom rules, I would like to request (as discussed during CORE Rules Office Hours (2024) meeting) following:
Currently, the variable_value name only works in combination with rule type = value metadata check against the define-xml
Can we also make this work with other rule types not using the define-xml? It would be interesting to check the values of all variables for certain data issues. For example: Check that there are no leading or trailing spaces, non-ASCII or non-printable characters or '.' in a value.
Thanks!
Els

This would also be helpful with Adam 17  --- we need the metadata to check the record_data_type but also need to check the variable_value to check the length of the actual value


Issue 359 spanish decimal format

🗃 Github Issue: Decimal bug for Spanish number format. (Replace all "," for "." on user input when sending or receiving seeds, this will allow Spanish users to enter decimal values. Only ONE "," or ONE "." will be allow as user input and it would be use for the decimal value)
#359
✅ Checklist

[x] Github issue details are up to date for people to QA.
[x] I have tested all my changes.

🕵♂ Notes for Code Reviewer
Spanish number Format For Receive feature Before:
User input: 99,99 - Expected output: 99.99  - Actual result: Nothing happens and user is unable to click next
Spanish number Format For Receive feature Fix:
User input: 99,99 - Expected output: 99.99  - Actual result: 99.99
🙈 Screenshots
For all UI changes

description 1
description 2

img1
img2

👯♀ Paired with
"nobody"

@gguij004  did u take a look at Niks comment?

code looks good. Build is failing tho


Add tag/remark to ranked outlier search filters

Codecov Report
Attention: 85 lines in your changes are missing coverage. Please review.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files
Coverage Δ

src/graphql/triage/response.rs
69.37% <100.00%> (ø)

src/graphql/outlier.rs
2.02% <0.00%> (-0.32%)
:arrow_down:

:loudspeaker: Thoughts on this report? Let us know!


⚠ Bofrost.at has degraded performance

In 61d7312, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1611 ms

Resolved: Bofrost.at performance has improved in 1ab1d70 after 39 minutes.


OCPBUGS-6016: UpdateStrategy RegistryPoll with nil Interval

Description of the change:
Adds protection against a nil-pointer panic when an UpdateStrategy with nil value for RegistryPoll Interval is supplied. Also adds a unit test to ensure that the code does not panic but instead returns an error when this situation is encountered.
Motivation for the change:
OCPBUGS-6016

/jira refresh

/approve

/lgtm


KeyError: 'edit-time' when parsing json

Some of my exported json nodes don't have edit-times or emails 🤷♂.
Adding default values into the containers.py file (line 113) makes it run cleanly.
return cls(page['title'], child_block_objects, page.get('edit-time',''), page.get('edit-email',''))
Not submitting as a patch as I have a feeling you might be using edit-time somewhere, so you might want to set it high or low depending on it's use.
For reference, here's the original error:
2020-07-05 11:53:03,426 - INFO - Loading Roam Graph
Traceback (most recent call last):
  File "/Users/john/Library/Python/3.7/bin/ankify_roam", line 10, in <module>
    sys.exit(main())
  File "/Users/john/Library/Python/3.7/lib/python/site-packages/ankify_roam/cli.py", line 77, in main
    func(**args)
  File "/Users/john/Library/Python/3.7/lib/python/site-packages/ankify_roam/cli.py", line 17, in add
    roam_graph = RoamGraph.from_path(path)
  File "/Users/john/Library/Python/3.7/lib/python/site-packages/ankify_roam/roam/containers.py", line 23, in from_path
    return cls.from_json(path)
  File "/Users/john/Library/Python/3.7/lib/python/site-packages/ankify_roam/roam/containers.py", line 31, in from_json
    return cls(roam_pages)
  File "/Users/john/Library/Python/3.7/lib/python/site-packages/ankify_roam/roam/containers.py", line 12, in __init__
    self.pages = [Page.from_dict(p, self) for p in pages]
  File "/Users/john/Library/Python/3.7/lib/python/site-packages/ankify_roam/roam/containers.py", line 12, in <listcomp>
    self.pages = [Page.from_dict(p, self) for p in pages]
  File "/Users/john/Library/Python/3.7/lib/python/site-packages/ankify_roam/roam/containers.py", line 113, in from_dict
    return cls(page['title'], child_block_objects, page['edit-time'], page['edit-email'])
KeyError: 'edit-time'

Weird that those attributes aren't always there. Thanks for pointing this out and for the solution!


Fix for #2813 (scene.drillPick breaks scene.pickPosition)

Fixes #2813
I don't know if this is the best solution, but I decided to take a guess.
Essentially, drillPick was setting the show property of primitives to false, then calling pick, which executes some commands to update the frame state. But when drillPick sets the show property back to true, it doesn't do that same update. So if pickPosition is called during the same frame, it thinks the primitives are still hidden.

This adds a very expensive operation.  I suspect it is overkill.  @bagnell please advise.

The depth buffer should only be copied during the render pass. I added a fix in #2862. Closing.


Enable extraction of APKs

We currently don't seem to be extracting APKs from backups.

I've been digging around on seedvault's repo, and it turns out all apks are unencrypted inside the backup folder (they even keep the correct apk mimetype in linux), all seedvault does is encrypt their filename. The following golang code should correctly get the new filename:
h := sha256.Sum256([]byte(metadataMeta.Salt + "APK" + packageName + suffix))
encrypted_name := base64.RawURLEncoding.EncodeToString(h[:])

The suffix variable is an empty string for non split apks, while split apks will have an empty suffix for the "base" apk and all the others will use the name value that is found inside of the metadata.
From there it's just a matter of copying and renaming the correct files. I know nothing of golang (above code is my first dive in it) , so can't make a pr and hope it's up to standard, but hopefully this info helps you/someone.


fix(client): fix server address allowing https

Use Psr7\Uri (from guzzle dependencies) to build PushGateway::$address, allowing support of https

Hi @Gounlaf look at that PR: https://github.com/Jimdo/prometheus_client_php/pull/107 I think it will be better to move guzzle client configuration outside of PushGateway class

Close in favor of #107


Management Service in west US

The management service is deployed in the west US region.  It would be great to have this mentioned and clarified in the article. This comes as a surprise for customers with data residency requirements. As an example on provisioning the service from Azure Portal in the Canada Central region, all components (App Service, App Insights, etc.) are provisioned in Canada Central except the "Cognitive Service" which is always deployed in West US.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7cb10c01-db1f-1c61-f5cd-857df2b7fbd8
Version Independent ID: 3ef184f7-6288-caec-ea33-f3d5dadd8965
Content: What is QnA Maker? - Azure Cognitive Services
Content Source: articles/cognitive-services/QnAMaker/Overview/overview.md
Service: cognitive-services
Sub-service: qna-maker
GitHub Login: @tulasim88
Microsoft Alias: tulasim

@mpsingh24 Thanks for the feedback. We are investigating into the issue and will update you shortly.

@tulasim88 The documentation for the available regions of QnAMaker shows it is available in canada central and the portal allows us to create the service in this region but when the service is deployed it only points to westus. Here are the screen shots of the same:
While creating:

After creating:

Could you please confirm if this is expected functionality?
If Yes, can we document the same?
If No, can you please pass this issue to the product group?
@mpsingh24 Thanks for highlighting the issue.

@RohitMungi-MSFT @mpsingh24   - thanks for the feedback. the top location drop down is going away soon, this is a new change in the create service. By design we have the management service of QnA Maker only available in West US. this is only used for the portal & for initial data processing. no customer data is stored in this West US service.
We can explicitly document this new change.
@diberry - as FYI . We should make this note in the doc https://docs.microsoft.com/en-us/azure/cognitive-services/qnamaker/how-to/set-up-qnamaker-service-azure

Doc change is #in-progress

#please-close


[EASI-4598] GRB reviewer email notifications

EASI-4325 EASI-4598
Description

Adds logic for handling emails around the GRB Review start date.
Fixes email script sender not sending emails with only CC/BCC addresses.
Adds functional helpers for slices.

How to test this change

Start/Seed app and visit this intake
Open mailcatcher
Add a reviewer, no emails.
Start the review, see email go out to current reviewers. (Note: Mailcatcher files all addresses under the "To")
Add a reviewer, that reviewer should receive an individual email.
Fire off this mutation to see error when trying to start a review after one has already been started:

mutation startReview {
  startGRBReview(input: {
  	systemIntakeID: "5af245bc-fc54-4677-bab1-1b3e798bb43c"
  })
}

PR Author Checklist

[x] I have provided a detailed description of the changes in this PR.
[x] I have provided clear instructions on how to test the changes in this PR.
[x] I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

It's best to pull the branch locally and test it, rather than just looking at the code online!
When approving a PR, provide a reason why you're approving it

e.g. "Approving because I tested it locally and all functionality works as expected"
e.g. "Approving because the change is simple and matches the Figma design"

Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

2470e05

Lo and Behold, I went ahead and refactored to just use lo.


Exchange Administrator required to access Custom Mailbox.

Article assumes that the administrator has an "Exchange Administrator" role assigned via the O365 Admin Center.
Administrators that do not necessarily have "Exchange Administrator" roles - like a "Security Administrator" (they are administrators too), defined solely in the Office 365 Security & Compliance Center, still sees the User Submissions page, but no "Custom Mailbox" tab.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e53205b5-8850-42b6-0b0c-8a61b7ef7776
Version Independent ID: 0a9e7903-ce3c-e877-e6b3-b45d09642308
Content: Specify a mailbox for user submissions of spam and phishing messages - Office 365
Content Source: microsoft-365/security/office-365-security/user-submission.md
Service: o365-seccomp
GitHub Login: @chrisda
Microsoft Alias: chrisda

@jadesolis,I added Exchange Administrator to the permissions call-out.
Thanks for the feedback.
Closing

The following statement still does not appear accurate:

Th option of Organization Management OR Hygiene Management in Exchange Online still doesn't grant access to the "Custom Mailbox" tab.

In the absence an Exchange Online Administrator role, Organization Management AND Hygiene Management are both required in Exchange Online.
The Organization Management (role group) is actually made up of  several other roles; it would have been more appreciated if the articled listed the minimum RBAC roles required in EOL

@jadesolis, I hear you, but we've found it easier to list the role groups (which, confusingly, are called 'roles' in Azure AD), because that's where you actually add/remove members. Sometimes, we'll say, "Access is controlled by the  role, which is typically assigned to the , , and  role groups..." which I could potentially do in this case.
Membership in both the Organization Management AND Hygiene Management role groups in ExO should not be required. The Hygiene Management role group gives you the Transport Hygiene, View-Only Configuration, and View-Only Recipients roles. By default, all of these roles are already assigned to the Organization Management role group in ExO. There are only a small number of unrelated roles that aren't assigned to Organization Management by default in ExO (if memory serves: Address Lists, Mailbox Import Export, Mailbox Search, and Reset Password).
So what would you like the permissions blurb to say?

"Membership in both the Organization Management AND Hygiene Management role groups in ExO should not be required." - Apparently this does not hold true, hence the feedback.

@jadesolis, let me put it another way: have you done any role group customization that would account for those three roles from Transport Hygiene not being assigned to Organization Management?

@chrisda No, and immaterial. 'Organization Management' is no the issue here.
As it stands, 'Hygiene Management' in itself doesn't give you access to the 'Custom Mailbox tab.'

@jadesolis, I'll refer to my question a couple of posts ago: If the statement about permissions is still incorrect, what would you like it to say?

@chrisda I will refer to my response a couple of posts back:
In the absence an Exchange Online Administrator role, Organization Management AND Hygiene Management are both required in Exchange Online.

@jadesolis, I did my own testing. I used a Global Admin to take these actions:

I specified a reporting mailbox at https://protection.office.com/userSubmissionsReportMessage. If you don't do this step, no one, including Global Admins, sees the Custom mailbox tab at https://protection.office.com/reportsubmission.

I added an ordinary user to the Organization Management role group in the Exchange admin center (EAC).

Custom mailbox tab on https://protection.office.com/reportsubmission = YES
Access to User submissions at https://protection.office.com/userSubmissionsReportMessage = YES

I added a different ordinary user to the Hygiene Management role group in the EAC.

Custom mailbox tab on https://protection.office.com/reportsubmission = NO (entire page is blank)
Access to User submissions at https://protection.office.com/userSubmissionsReportMessage = NO (entire page is blank)

I added a different ordinary user to the Organization Management role group in the Security & Compliance Center (SCC).

Custom mailbox tab on https://protection.office.com/reportsubmission = NO
Access to User submissions at https://protection.office.com/userSubmissionsReportMessage = YES

Adding this same user to the Hygiene Management role group in the EAC and logging off/on had no effect (same results).

I added a different ordinary user to the Security admin role in the Microsoft 365 admin center (MAC).

Custom mailbox tab on https://protection.office.com/reportsubmission = YES
Access to User submissions at https://protection.office.com/userSubmissionsReportMessage = YES

I added a different ordinary user to the Exchange admin role in the MAC.

Custom mailbox tab on https://protection.office.com/reportsubmission = NO (entire page is blank)
Access to User submissions at https://protection.office.com/userSubmissionsReportMessage = NO (entire page is blank)

Adding this same user to the Organization Management role group in the SCC and logging off/on had no effect (same results).

I'll update both this topic AND the topic where you actually click on the Custom mailbox tab (https://docs.microsoft.com/microsoft-365/security/office-365-security/admin-submission) accordingly.


Can't make the call from Angular code, CORS issue

Almost all the step are correct, thanks for the very details information. But in the last step, I got the error message as below.
 XMLHttpRequest at 'https://login.windows.net/91dde955-43a9-40a9-a406-694cffb04f28/oauth2/authorize?response_type=code+id_token&redirect_uri=https%3A%2F%2Ftodo-backend-ares.azurewebsites.net%2F.auth%2Flogin%2Faad%2Fcallback&client_id=657cb573-45bf-450f-b1e4-c9c0f59ad38a&scope=openid+profile+email&response_mode=form_post&nonce=ad0064fe62e44aaa9a16a6adb220f785_20201109074453&state=redir%3D%252Fapi%252FTodo' (redirected from 'https://todo-backend-ares.azurewebsites.net//api/Todo') from origin 'https://todo-frontend-ares.azurewebsites.net' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 28fe407c-980d-6dfc-305c-63202534bf48
Version Independent ID: 09bed06c-ca37-a511-b4a4-0028e76f8919
Content: Tutorial: Authenticate users E2E - Azure App Service
Content Source: articles/app-service/tutorial-auth-aad.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@chenxizhang - Thanks for posting the query. Our team is looking into it and will get back to you shortly.

any update?

@chenxizhang Can you please try to go to the CORS blade for your web app and create a setting for *. While we don't recommend this setting, for testing purposes, this will help us verify if there is an issue with the domains that you have allowed.
We look forward to your reply.

@BryanTrach-MSFT  I think this error message mean that we can't access the "https://login.windows.net", how we can set the CORS of this site?

@chenxizhang Can you please navigate to portal.azure.com and then select your backend app and then select the CORS blade of the backend app. Please ensure that there is the front end app allowed as shown in the below example.

@BryanTrach-MSFT  Thanks, we already do this settings.

@chenxizhang I'm not sure why this is happening based on my research of your error. It sounds like you have the necessary CORS configuration setup.
We'd like to assist you further. Can you please reach out to<EMAIL_ADDRESS>with your subscription ID and the URL of this post so we can help you further?
We look forward to your reply.
(Since we are taking this offline we will close out this thread and work with you over email.)

I'm having this exact issue. Was there any resolution?


CDI menu graphics missing

RG353V/VS
My fav theme is ES-THEME-ARKOS-CARBON but the CDI menu gfx are missing. I've uploaded the files in case you want to update the theme too.
To rectify this -
use these files in the .zip
cdimono1.zip
etc\emulationstation\themes\es-theme-arkos-carbon\art\logos
place cdimono1.png

etc\emulationstation\themes\es-theme-arkos-carbon\art\background
place cdimono1.jpg

and it looks like this

Excellent.  I've created a pull request with Jetup's git to have this added.  Thanks for the submission on this. :)


Changed how DNS Lookup for local root peers works

Description
Part one of fix for #4563 . This fixes the way we store DNS lookup results.

Please include CHANGELOG entry, not that that your change requires a major bump of ouroboros-network.


Validation issues - can we get some features back?

Describe the bug

Users are NOT able to expand the incomplete error message in the Language Generation inline editor.

Users are NOT able to expand the incomplete error message in the Language Understanding inline editor.

Users are able to expand the incomplete error message but need a link pointing to the Adaptive Expressions reference doc.

Version
Latest master branch
Browser

[x] Chrome

OS

[x] Windows

To Reproduce
Steps to reproduce the behavior:

Produce an error on purpose in the LG/LU inline editor
Click on the generated error message
See error

Expected behavior

Should allow users to expand the error message.
Should provide corresponding reference docs for syntax.

Additional
What we used to have:

lg

lu

Expressions

@beyackle Do you have thoughts on this? I know that this change was introduced to address some a11y issues, but I don't have all the context. Could you take a look at this and recommend an approach?

If I remember right, the approach we decided on was to get rid of the reveal arrow and just have the message be expanded all the time (the messages are never so long that this would be a problem; boxes below them just get pushed downward). So the problem here is that they're showing up shrunk in the first place.

@beyackle can you investigate to see why parts of the elements are hidden?

Just noticed that PR doesn't also add the docs link to the Condition field. I'll fix that.

addressed via https://github.com/microsoft/BotFramework-Composer/pull/2811

This isn't done yet - there still needs to be a fix to the need for a link to the Adaptive Expressions doc. I have a PR for that too that I'll link here.


"No healthy upstream" when using PVC

When creating a new tensorboard with a PVC mounted at mnt/tfboard, I get the error "no healthy upstream" when trying to connect to the board.
If I shell into the container, I can see that the tensorBoard is running perfectly fine:
microk8s.kubectl exec -it $(microk8s.kubectl get pods -nrob | grep ^demo- | awk '{ print $1 }' | tail -n 1) -nrob -- bash
root@demo-7498d9d94-zk5gw:/# curl -s localhost:6006/ | head -n 17
<!doctype html><!--
@license
Copyright 2016 The TensorFlow Authors. All Rights Reserved.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

    http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
--><meta charset="utf-8">
<title>TensorBoard</title>

Did this error persist?  I have a feeling if you refreshed the page a few moments later it would work.
If I am right, the reason for this is the same as this issue where that the notebook controller follows whether a container on the pod ready, not whether all required containers are ready.  This is a common problem with notebooks, where the connect button will go green slightly before the notebook server is actually presenting the page.  If you're quick, you'll get this error.
I don't think this is a heavy lift to fix, but it would be a fix upstream


filter function

Updates:

Migrated filter function as an option in agent options.
Fixed the merge issue which introduced the abi variable in the existing test cases.
Migrating the decoder to utils


Run tests on the CI

Tests were not run on Github actions. And Travis seems to not be triggered for some time now...

Fix #1256

Fix #1256

We actually need to rethink JS testing in bqplot.
Due to the recent transition to Webpack 5, and due to all the test modules we rely on (karma-chai, karma-mocha) that didn't follow the webpack 5 update, this will actually be difficult. We'll need to find another way to test without those modules.

We actually need to rethink JS testing in bqplot.
Due to the recent transition to Webpack 5, and due to all the test modules we rely on (karma-chai, karma-mocha) that didn't follow the webpack 5 update, this will actually be difficult. We'll need to find another way to test without those modules.

I guess Galata will be the answer to this


Print Datree version before beginning run

This would make it easier to report issues to datree main repo and fill in the version number in the issue template, as well as to see the version in the link to the github actions build when provided in the ticket.

I agree, but I think it will make more sense to open it as a new issue on Datree's main repo.
But I wonder if it should print on each run or only after installation...?

It needs to print version on each run for CI purposes.
This will make it easier for you when you are sent links to output/logs or CI runs in GitHub Actions or some other public hosted provider as you'll be able to see the version in the log.
The reason I've raised this here is that for local datree runs you can just put the version command in the bug report, but for CI links or logs it's better to have it always available.
Also, when a user is using this action-datree, they can't modify it to run the datree version command in their CI pipeline, which is why this needs to be done here.

yep, that makes sense.
@hadar-co can we also print the helm plugin version if someone is using this option with the action?

Fixed:)

Confirmed, this now shows the version before the run, thanks.


Issue #12: document.body may be null:

Use safe approach to locate the body element

That's excellent, thanks for digging up a fix!


test against xarray master

It would be mutually beneficial for xclim to test against xarray master, I think. This would help with things like #270, #280 and https://github.com/pydata/xarray/issues/3402.
What do you think?

Definitely. This would solve a lot of problems (or at least let us know further in advance what might be coming).

@Zeitsperre Would it be possible to keep our current test suite as is (for our docker/conda releases where we can freeze dependencies), and add a "bleeding edge" case that would pull the  xarray master ? A failure on the bleeding edge branch would not block our own releases, but would help us diagnose upcoming issues and provide feedback to xarray devs.

That's pretty much what I had in mind. I was going to set a new the tox environment that reinstalls xarray with the master branch.

This sounds great. Thanks guys. And also thank you for reporting issues and contributing pull requests upstream

I agree to all of this ... we'll stay ahead of the curve and help xr devs catch some bugs earlier at the same time,

I can get to this this afternoon. Thanks again for the suggestion @dcherian !


Remove version: GIGABYTE.GigabyteControlCenter version <IP_ADDRESS>

[Automated] It returns code over 400 in all urls
Microsoft Reviewers: Open in CodeFlow

URL: https://download.gigabyte.com/FileList/Utility/GCC_<IP_ADDRESS>.zip
Response status code does not indicate success: 404 (Not Found).
(Automated message - build 896)

Hi @Exorcism0666,
This manifest has the highest version number for this package. Is it available from another location? (This might be in error if the version is switching from semantic to string, or string to semantic.)
(Automated response - build 896.)


mxnet2caffe2？

look forward to this part  mxnet2caffe,
（1） is it mxnet2caffe2?      mxnet--->onnx--->caffe2？
（2）is there a android demo?
（3）cpu performance  of readme  refers to  a phone?
thanks for your work.

@aa12356jm

@aa12356jm
(1) mxnet2caffe is in plan (not mxnet2caffe2 or mxnet->onnx->caffe2). But you can try.

@aa12356jm
(1) mxnet2caffe is in plan (not mxnet2caffe2 or mxnet->onnx->caffe2). But you can try.
(2) This repo. is mainly to provide basic algorithms now. Android demo maybe to provide in the future if my time is free.
(3) CPU performance in readme is intel cpu.

@becauseofAI thanks


Handle missing prefixes more elegantly

Currently we are just catching (thanks @c-martinez ) errors when the query uses undeclared prefixes. This is very common.
At the moment the backend fails silently, and simply no OpenAPI spec is rendered for the offending query prefixes. Using the UI to at least show some error (and suggestions for fixing) would be a great addition.
Another option would be to intelligently try to guess the prefix, by e.g. keeping a hard-coded list of common prefixes, issuing a request to prefix.cc, etc.

There is now a warning about missing prefixes in #337

I don´t like the idea of intelligently guessing prefixes, because it changes the query behaviour. For example if you take the same query and run it directly against the SPARQL endpoint, you would get a different result. I don't think grlc should make such changes to queries.
Can we close this issue?


Setting up Prisma in a hoisted environment (pnpm, npm workspaces)

Internal context: https://prisma-company.slack.com/archives/C5Z9TH6N9/p1624327195329300

For some more context, here's how to set up a project with pnpm https://github.com/millsp/prisma-pnpm-workspace. There are two important things:

Generation
This ensures that the client is generated in the sub-project's node_modules folder. Otherwise it would get generated in the root / hoisted node_modules (for both app1 & app2) and two clients could overwrite each other.
Imports
Because @prisma/client is hoisted in the root folder and reused by app1 & app2 (symlinked in their respective node_modules), we cannot resolve types or any nearby generated client. Thus it has to be imported this way.

The main purpose of this doc is to help users that would like to generate more than one client while working in a hoisted environment (in this case, a pnpm workspace).

Meaning: If you use pnpm or similar, and just have 1 generated Client, you can do what exactly?

This should be added to the Development environment section

@millsp is this still the case?

Yes this is something a lot of people having multi-service monorepos run into. There's one thing that I would change though: the custom output into node modules, I'd just make it a custom output in the project folder and use a gitignore not to include the files.

👋 we're cleaning up our backlog of issues and are closing everything older than two years. If you still feel that this issue is relevant, please feel free to re-open and our team will take a look. Thank you!


node requirement

After failed twice when doing npm install with<EMAIL_ADDRESS>I found that package needs node >= 6.4 to build up.
So I think that it would be great to indicate specific node version that package required ( node >= 6.4 ) in README file.

package.json lists:
  "engines": {
    "node": ">=8.2"
  },

package.json lists:
  "engines": {
    "node": ">=8.2"
  },


Update pikchr.c from master branch

It looks like the html-defense branch is actually the one we want, though I don't remember exactly why I picked that. If you can explain why you'd want us to switch to the master branch I can reopen this.


How to use MediaProjection to capture screen in a Service?

As we know, we can use Android MediaProjection API to capture screen in an Activity, but I want to capture screen in a thread of a Service. But Android Service has no onActivityResult() method that MediaProjection need to do something. It seems that we can only call MediaProjection API like belows:
startActivityForResult(mProjectionManager.createScreenCaptureIntent(), REQUEST_CODE);
Is there a way to use MediaProjection in an Android Service?

Yes, it is possible  just request permission in activity and then put result to bundle and start service. See example below:
extras.putInt(EXTRA_RESULT_CODE, resultCode);
extras.putParcelable(EXTRA_DATA, data);
startService(YourService.newIntent(this, extras));
finish()

@gbuyan Thanks for your reply. But my app has no activity but only a service called by JNI, How to use MediaProjection in this case?


Names

Lots of rename, plus a stealth refactor sneaked in there, and a TODO to remind us we should do a higher-level interface to PlaneWaveBasis. Fixes https://github.com/mfherbst/DFTK.jl/issues/49.
I began with PWBasis, but it sounded strange (PWB is weird) so I went with PlaneWaveBasis. @mfherbst you've been pretty careful to avoid excessive abbreviation, and I think that's a good idea so let's keep that. If you agree let's merge this one to avoid too much conflict; I'll resolve the conflicts in the other PRs.

Merci :smile:

Heh, I don't care that much but OK :p I remember seeing at some point some tooling to enforce style rules, we should probably do that at some point.

Agree ... but that's by far not the first on my TODO list.


Error running nitro enclave allocator

Error message:
[ec2-user@ip-172-16-1-154 ~]$ sudo systemctl status nitro-enclaves-allocator.service
● nitro-enclaves-allocator.service - Nitro Enclaves Resource Allocator
   Loaded: loaded (/usr/lib/systemd/system/nitro-enclaves-allocator.service; disabled; vendor preset: disabled)
   Active: failed (Result: exit-code) since Fri 2021-04-16 17:26:37 UTC; 2s ago
  Process: 3569 ExecStart=/usr/bin/nitro-enclaves-allocator (code=exited, status=1/FAILURE)
 Main PID: 3569 (code=exited, status=1/FAILURE)

Apr 16 17:26:37 ip-172-16-1-154.ec2.internal systemd[1]: Starting Nitro Enclaves Resource Allocator...
Apr 16 17:26:37 ip-172-16-1-154.ec2.internal nitro-enclaves-allocator[3569]: /usr/bin/nitro-enclaves-allocator: line 130: /sys/module/nitro_enclaves/parameters/ne_cpus: No such file or directory
Apr 16 17:26:37 ip-172-16-1-154.ec2.internal nitro-enclaves-allocator[3569]: cat: .tmp_file: No such file or directory
Apr 16 17:26:37 ip-172-16-1-154.ec2.internal nitro-enclaves-allocator[3569]: rm: cannot remove '.tmp_file': No such file or directory
Apr 16 17:26:37 ip-172-16-1-154.ec2.internal nitro-enclaves-allocator[3569]: Error: The CPU pool file is missing. Please make sure the Nitro Enclaves driver is inserted.
Apr 16 17:26:37 ip-172-16-1-154.ec2.internal systemd[1]: nitro-enclaves-allocator.service: main process exited, code=exited, status=1/FAILURE
Apr 16 17:26:37 ip-172-16-1-154.ec2.internal systemd[1]: Failed to start Nitro Enclaves Resource Allocator.
Apr 16 17:26:37 ip-172-16-1-154.ec2.internal systemd[1]: Unit nitro-enclaves-allocator.service entered failed state.
Apr 16 17:26:37 ip-172-16-1-154.ec2.internal systemd[1]: nitro-enclaves-allocator.service failed.

Running on m5.xlarge Amazon Linux.

Never mind, I had to click the 'Enable Enclave' option when launching a new EC2 instance. It's not available by default.


Unicode support in terminal

Issue Type: Feature Request
Hey guys, do you have any plans on adding unicode (UTF-X) support in VSCode terminal? It would facilitate the displaying of some words with graphic signs. Thanks!
VS Code version: Code - Insiders 1.42.0-insider (35116fa958d6622df1c31b4d84810b999a858170, 2020-01-27T18:00:58.077Z)
OS version: Windows_NT x64 10.0.18362
Remote OS version: Linux x64 3.10.0-957.27.2.el7.x86_64

UTF-8 is supported and encourages, is your $LANG variable set correctly? What makes you say it doesn't work?

Hi Tyriar.
I'm from Brazil. The $LANG variable is set correctly (pt_BR.UTF-8).
I've checked and UTF-8 is actually supported. I'm sorry for the mistake.
Let me explain better: I use the "screen" command to avoid having many windows opened. So when I use "special" Portuguese characters, like ã and ç, inside the "screen" command, they appear wrongly. But when I use them outside the "screen", they appear correctly.
This doesn't happen when I use the terminal from Bitvise ssh client.
So now I'm not sure if the problem is with VSCode, or my "screen".

It sounds like the problem is with screen if they appear normally in your regular shell. Maybe it's not picking up or supporting the encoding correctly?


postgres: fix to force to install libpq5 package for python2-psycopg2 on CentOS 7

Which issue(s) this PR fixes

Fixes #64
Additional comments

Installation of libpq5 package needs to enable EPEL repository on CentOS 7.
Agreements

[x] I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004.
[x] I hereby agree to grant TOSIT a copyright license to use my contributions.

I could not find libpq5 in the Centos / RHEL repos, I think it's a debian package why would we add this here?

libpq5 package come from postgresql-common repository, same for python2-psycopg2. We do not use RHEL packages for PostgreSQL.

libpq5 package come from postgresql-common repository, same for python2-psycopg2. We do not use RHEL packages for PostgreSQL.

My bad, i searched on the edge-01 of getting started which do not have the postgres repo.


expcertificates: fix bug renewing certificates automatically near expiry

What this PR does / why we need it:
This PR fixes certificate renewal near expiry when running with the new 'experimental' certificate controllers introduced in v0.15.
The 'scheduled work queue' concept has been modified to use a passed-in 'clock' which we can easily manipulate during integration tests.
I've then also added an integration test to exercise this case so we can be sure it's working.
Which issue this PR fixes: fixes #2978
Special notes for your reviewer:
This is best reviewed commit-by-commit.
I've aimed to keep things nice and separated to make it clear at each stage along the way what's going on.
I also opted to add two new fields to the Certificate resource's status: status.notAfter and status.renewalTime. These are computed and set/managed by the readiness controller. The 'trigger' controller then makes use of these status fields to decide whether to trigger a renewal or not.
Release note:
experimental certificates controllers: fix automated certificate renewal

/kind bug
/milestone v0.16
/priority critical-urgent

/retest

It seems to me that afterFunc and the mockAfter helper might no longer necessary with the new clock attribute of the scheduler.

Agreed - we don't need this fake afterFunc implementation any more from what I can tell. It'd be a good bit of /kind cleanup to go and fix this up. Given this was quite unrelated to the actual issue we're solving in the PR, I figured it'd be easiest to just adjust the existing logic around the new clock instead for now.

Please merge when you're happy with it.

Can you add a /lgtm? 😄

Lemme help:
/lgtm


Tor support

It would be a good idea to have a separate instance of Farside strictly for Tor versions of instances. Some basic things needed to implement this:

[ ] Separate services file that only contains services with Tor instances
[ ] Redis updates to store separate key-val pairing of Tor instances, separate from their non-Tor counterparts
[ ] Env var to enable Tor support
[ ] Add separate workflow for auto updating available Tor instances

How about I2P support as well?

I think it would also make sense for the tor version to (only) be avaliable as an onion service

If it goes online, it would mean all Tor users would be blocked off, so why not onion and clearnet?

I would be curious if there are Freenet, GNUnet, or other "darknet" hosted proxy services out there..

probably, but the demand for it would be very low/nonexistent since almost nobody has heard of them


Adding CMakeSettings.json file

Allows to switch:

x86/x64
Debug/Release

Without restarting Visual Studio / regenerating solution. (need to open directory, rather than solution file, in VS)

Is this required for the CI run? I had deliberately left out the CMakeSettings.json file from the repository, since it contains user-specific settings, e.g. regarding building documentation etc. Also, I hate having the build directory inside the source tree, so my buildRoot and installRoot entries are different. I've also got a reference to the vcpkg toolchain file in there.
Is there an argument for including it in the repository?

It is not required for CI (hence separate PR). Having this file committed to repository will allow developers to select from 4 configurations - x86-Debug, x86-Release, x64-Debug, x64-Release - in Visual Studio without having to:

exit VS
run cmake to regenerate projects/solution
open Visual Studio again.

This is purely a convenience feature for Visual Studio

Added CMakePresets.json instead, see:

https://docs.microsoft.com/en-US/cpp/build/cmake-presets-vs?view=msvc-160
https://devblogs.microsoft.com/cppblog/cmake-presets-integration-in-visual-studio-and-visual-studio-code/

The idea behind this PR is to avoid having every developer setting up CMakeSettings.json for themselves (which might be tricky for some). CMakePresets.json has the advantage of storing default configuration + allowing custom CMakeUserPresets.json which advanced users can customize for themselves

Closing to remediate local build issues

@DarkWanderer Is is possible to configure the defaults to put the build directory default to be outside the source tree (or maybe  just leave it blank?). If I understand @mschweiger correctly, the major concern with using defaults is that the build directory would be inside the source tree.
Regarding the other concern, what about even just leaving the default fields blank? The way, developers would still need to fill in settings in before building. I understand that sort of defeats the purpose of the presets file in the first place, but this would still allow developers to have all four build configurations (x86 Debug, x86 Release, x64 Debug, x64 Release) all in the same solution, if I understand correctly -- which, to be honest, is the big thing that I like :).

What is the issue with having build artifacts inside the source directory, given that it's ring-fenced (all items are in subdirectories of out/build)? To be honest it feels strange to me to have build artifacts outside source dir, given that basically any language build process produces something which is inside the source dir by default

Let me rephrase this: I appreciate that this question is essentially matter of taste and do not claim that a particular way is unconditionally better. My suggestion comes from a standpoint that adding CMakePresets allows for new capabilities, while also helping to:

streamline process for new contributors (they will not have to generate CMakeSettings.json)
improve CI consistency (at the moment parameters are passed externally via command line)
add capability for "remote" Linux development in future

In my opinion, having a default of building within source directory is the "least friction" option, while capability to build outside of source dir is retained, for cases where it is a concern
Of course, the decision is ultimately with you

FWIW, I don't feel strongly about this either way, and I agree it's a matter of personal taste. I'm going to close this PR for now since @mschweiger prefers the build settings as they currently are and this PR has been open for 22 days. We can always reopen this in the future if this resurfaces.


Staged changes not showing the correct diff

Issue Type: Bug
Stage a change to a file, and open the diff -- it the change isn't staged it will work, but if it is staged the diff is the same on both sides.
This started in today's insiders build.


Use Git LFS for large binary assets

Overview
We should move the repository to using Git LFS for large binary data.
Updating the .gitattributes file to add the following file types:

*.ai
*.dds
*.fbx
*.gif
*.jpg
*.obj
*.mp3
*.mpg
*.png
*.psd
*.svg
*.tif
*.tga
*.ttf
*.wav

Do users have to install this?
https://git-lfs.github.com/

Yes, or use a git client that has it embedded.

Which large binary data files in the core Toolkti make this necessary?

Any/All binary files (.dlls, .unitypackage, etc)
Any/All files over 2MB
See https://docs.microsoft.com/en-us/vsts/git/manage-large-files
Generally this is a common and standard practice, and makes the repo much smaller and responsive in the git client.


Sql component should save db object on Init instead of creating a new

Description
Save the db object during Init() so it can be used for operations - don't recreate it every time.
Also fixes an issue when using grpc - the data should not be marshalled if it's already []byte.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #397, #398
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[ ] Created/updated tests
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

What happens if db client is disconnected? In this case, reconnection is required. So I would create helper method to check if existing client connection is valid first and then use the existing connection. otherwise, I would reconnect it first.

I don't think the user needs to manage that themselves:
https://golang.org/pkg/database/sql/#Open
The returned DB is safe for concurrent use by multiple goroutines and maintains its own pool of idle connections. Thus, the Open function should be called just once. It is rarely necessary to close a DB.

Also it looks like everything internally calls the conn() method which will manage connections for you:
https://golang.org/src/database/sql/sql.go?s=46419:46453#L1133

lgtm