Extend %import functionality: Allow to import rules

Requires recursive import of dependent rules and terminals.
Could cause collisions, at least in LALR. Do we merge or throw an error?

An experimental implementation was added at commit 21bbf9b.
There's no support yet for collisions caused by importing the same file from two or more different imported files.

Hello, I would also be interested in importing rules. My use case is to split the grammar into several files, but maybe there is some easier way to achieve that?
Anyway, I would expect:

rule names to belong to one file only (for example they could be renamed to avoid collisions)
%ignore to apply to a file only

Example:

a.lark

start: expr

expr: "ab"
    | "a" expr "b"

%ignore "_"

b.lark

start: expr

expr: "X"
    | "[" inner "]"

%import a.start -> inner

The grammar defined in b.lark should match: X, [aabb] and [aab_b__] but not _[ab]_ (_ not ignored in b.lark) nor [aXb] (the scope of the expr rule should be restricted to each file)

@erezsh you mention having written an experimental implementation.
I see that  import_from_grammar_into_namespace is in master, but I'm not sure how to use it.

@Rogdham

rule names to belong to one file only (for example they could be renamed to avoid collisions)

If I understand you correct, that's already implemented

%ignore to apply to a file only

%ignore isn't imported, because it can't be scoped. At least, it would be complicated to implement.

I'm not sure how to use it.

I'm pretty sure it's already in 0.6.6.

%ignore to apply to a file only

%ignore isn't imported, because it can't be scoped. At least, it would be complicated to implement.

Fair enough!

rule names to belong to one file only (for example they could be renamed to avoid collisions)

If I understand you correct, that's already implemented

It seems that you are right indeed! :+1:
However, I was not able to "rename" an imported rule… I am able to do %import .a.expr, but say I already have a rule expr defined in the file I am importing into, I would like to either do %import .a.expr -> foobar, or something like %import .a and then use .a.expr as a rule name (maybe it needs its own syntax).
Btw, I belive the lark.lark grammar does not recognise the syntax %import .foo.bar.

I would like to either do %import .a.expr -> foobar

Makes sense. Do you feel like making a PR? :)

I belive the lark.lark grammar does not recognise the syntax %import .foo.bar.

You seem to be correct. That needs fixing. How did you spot it, btw?

Makes sense. Do you feel like making a PR? :)

Took me a while as I encountered a bug in the process… see #325

You seem to be correct. That needs fixing. How did you spot it, btw?

I was looking into the documentation as well as the examples to see how to use rule importing, but could not find really anything about it (only terminal importing).
Btw, I tried improving doc & examples as well in my PR :smiley:

Lark supports importing rules

Link for Syntax?

https://lark-parser.readthedocs.io/en/latest/grammar/
Look at %import

https://lark-parser.readthedocs.io/en/latest/grammar/
Look at %import

Updated URL here: https://lark-parser.readthedocs.io/en/latest/grammar.html?highlight=import#import


[WIP] try cleanup handleverifier.go

@giggsoff running the eden tests as specified in #1472
Maybe the additional check in gcVerifyImageConfig will make a difference.
The rest of the changes are cleanup and dealing with cases I didn't see in the log.

Hi, @eriknordmark. Unfortunately, the error still exists (actually, I try your commit on top of master (5b1d0b24)).
And again modification like this solves my problem:
diff --git a/pkg/pillar/cmd/volumemgr/updatestatus.go b/pkg/pillar/cmd/volumemgr/updatestatus.go
index 42468f5e7..73f498165 100644
--- a/pkg/pillar/cmd/volumemgr/updatestatus.go
+++ b/pkg/pillar/cmd/volumemgr/updatestatus.go
@@ -341,8 +341,8 @@ func doUpdateContentTree(ctx *volumemgrContext, status *types.ContentTreeStatus)
                }

                leftToProcess := 0
-               blobStatuses := lookupBlobStatuses(ctx, status.Blobs...)
-               for _, blob := range blobStatuses {
+               for _, blobSHA := range status.Blobs {
+                       blob := lookupBlobStatus(ctx, blobSHA)
                        // if the blob was not yet loaded, we ignore it
                        if blob.State != types.LOADED {
                                log.Infof("doUpdateContentTree(%s): blob %s not yet loaded", status.Key(), blob.Sha256)

Maybe we have some duplicates inside status.Blobs?

As I can see, I have the same sha in layers of the problem image (two last layers):
docker image inspect itmoeve/phoronix-test:1.0 -f '{{.RootFS.Layers}}'
[sha256:2ce3c188c38d7ad46d2df5e6af7e7aed846bc3321bdd89706d5262fefd6a3390 sha256:ad44aa179b334bbf4aeb61ecef978c3c77a3bb27cb28bcb727f5566d7f085b31 sha256:35a91a75d24be7ff9c68ce618dcc933f89fef502a59becac8510dbc3bf7a4a05 sha256:a4399aeb9a0e1ddf9da712ef222fd66f707a8c7205ed2607c9c8aac0dbabe882 sha256:d2724bb7095247911d9921cad00dc96f87ee3f6ee9239cdad266563d0acdeeb3 sha256:bc560da3effb94f7583920a0a0d518fc4262eacb81a1ee83c15d39a83ac05e56 sha256:bc560da3effb94f7583920a0a0d518fc4262eacb81a1ee83c15d39a83ac05e56]

and it depends on this line which actually do nothing...

As I can see, I have the same sha in layers of the problem image (two last layers):

@giggsoff
That is supposed to work; the sha will be repeated in the contentTreeStatus->Blobs and each one of them gets a refcount.
But clearly from the logs the refcount on the verifier does go to 2.
I've been fixing the logs around pubsub today so I can make more sense of the logs.Let's see what I find once I finish fighting with docker content trust in the EVE build


Added support to logging X-Forward-For header (#2133)

This patch is just the code as suggested by @groob in issue #2133. It was tested and is working both when the header is present and when it's not (x_for_ip_addr is then set to "" in the logs.)

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Jean Mousinho seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Jean Mousinho seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Nice, thank you! I imagine we may want to do similar for the other non-osquery endpoints, but I'll be happy to merge this if you can get the CLA signed.

My commit had the wrong email address so I wasn't able to pass the license/cla. The only way I found to fix it was to force push an amend =/
Regarding the other endpoints I agree, I will try to do it later.

Amending the commit works just fine, thank you!


findUnique() batching exceeding parameter binding limits

Bug description
While querying large datasets leveraging findUnique to prevent GraphQL N+1s, we're experiencing parameter binding errors due to the amount of bound parameters created in the batched query.
This causes the graphql query hitting these resolvers to fail.
Error:
prisma.account.findUnique(
  Assertion violation on the database: `too many bind variables in prepared statement, expected maximum of 32767,
  received 150656`

How to reproduce

With over 33000 rows in the table you're querying
Perform 33000 individual entity.findUnique() queries in a Promise.all, simulating a large GQL N+1
Expect parameter binding error after surpassing your Postgres variable binding limit.

Expected behavior
Potentially split queries that would exceed the bound param limit into multiple batches.
Prisma information
Schema: Unrelated
Code:
    const accountIds = await prisma.account
        .findMany({
            select: { id: true },
            where: {
                companyId: redacted,
            },
        })
        .then((result) => result.map(({ id }) => id));

    await Promise.all(
        accountIds.map((id) =>
            prisma.account.findUnique({
                where: {
                    id,
                },
            })
        )
    );

Environment & setup

OS: macOS, Windows, Debian, CentOS
Database: PostgreSQL
Node.js version: v20.11.1

Prisma Version
prisma                  : 5.7.1
@prisma/client          : 5.7.1
Computed binaryTarget   : darwin
Operating System        : darwin
Architecture            : x64
Node.js                 : v20.11.1
Query Engine (Node-API) : libquery-engine 0ca5ccbcfa6bdc81c003cf549abe4269f59c41e5 (at<EMAIL_ADDRESS>Schema Engine           : schema-engine-cli 0ca5ccbcfa6bdc81c003cf549abe4269f59c41e5 (at node_modules/@prisma/engines/schema-engine-darwin)
Schema Wasm             : @prisma/prisma-schema-wasm 5.7.1-1.0ca5ccbcfa6bdc81c003cf549abe4269f59c41e5
Default Engines Hash    : 0ca5ccbcfa6bdc81c003cf549abe4269f59c41e5
Studio                  : 0.495.0
Preview Features        : metrics, relationJoins

From the description it seems that our chunking logic does not trigger for the batched/packed SQL query. We need to confirm and understand.

Hey, I'm unable to reproduce your issue. Here's what I've been trying:
model User {
  id Int @id
}

// seed.ts
import { PrismaClient, Prisma } from "@prisma/client";
import { faker } from "@faker-js/faker";

faker.seed(42);

const N_USERS = 200_000;

async function seed() {
  const prisma = new PrismaClient();

  console.log("Seeding users...");
  await seedUsers(prisma);

  await prisma.$disconnect();
}

async function seedUsers(prisma: PrismaClient) {
  let users: Prisma.UserUncheckedCreateInput[] = [];

  for (let i = 1; i <= N_USERS; i++) {
    users.push({
      id: i,
    });
  }

  await prisma.user.createMany({
    data: users,
  });
}

seed()
  .then(() => console.log("Done!"))
  .catch((err) => console.error(err));

// actual reproduction
import { PrismaClient } from "@prisma/client";

async function main() {
  const prisma = new PrismaClient({
    log: ["query"]
  });
  const users = await prisma.user.findMany({ take: 100000 });

  const res = await Promise.all(
    users.map((id) =>
      prisma.user.findUnique({
        where: {
          id: id.id,
        },
      })
    )
  );

  console.log(res)
}

main()
  .then(() => console.log("Done!"))
  .catch((err) => console.error(err));

Logs show that the query is properly chunked into many.

Hi @chris-basis, have you seen @Weakky's comment above?
By the way, I've given this a shot. This is what I get on Prisma 5.7.1 with the following schema:

Prisma schema
generator client {
  provider        = "prisma-client-js"
  output          = "../node_modules/.prisma/client"
  previewFeatures = ["relationJoins"] // extrapolated from the "Preview Features" section of this issue's description
}

datasource db {
  provider = "postgres"
  url      = env("TEST_POSTGRES_URI")
}

model Tag {
  id Int  @id
}

model Company {
  id Int  @id
  name String
  accounts Account[]
}

model Account {
  id Int  @id
  name String
  companyId Int
  company Company @relation(fields: [companyId], references: [id])
}

@prisma/client snippet
import { PrismaClient } from '.prisma/client'

async function main() {
  const prisma = new PrismaClient()

  await prisma.account.deleteMany()
  await prisma.company.deleteMany()

  const n = 33_001
  const ids = Array.from({ length: n }, (_, i) => i + 1)

  const { id: companyId } = await prisma.company.create({
    data: {
      id: 1,
      name: 'company',
    }
  })

  await prisma.account.createMany({
    data: ids.map((id) => ({
      id: id + 1,
      companyId,
      name: `account-${id + 1}`
    }))
  })

  const accountsFromCreate = await prisma.account.findMany({
    select: {
      id: true,
    },
    where: {
      companyId,
    },
  })

  const accountIds = accountsFromCreate.map((account) => account.id)

  const accountsFromQuery = await Promise.all(
    accountIds.map((id) =>
      prisma.account.findUnique({
        where: {
          id,
        },
      })
    )
  )

  console.log('accountsFromQuery.length', accountsFromQuery.length)
  console.log('accountsFromQuery')
  console.dir(accountsFromQuery[0], { depth: null })
  console.dir(accountsFromQuery[1], { depth: null })

  process.exit(0)
}

void main().catch((e) => {
  console.log(e.message)
  process.exit(1)
})

Console output
Invalid `prisma.account.findUnique()` invocation in
/.../index.ts:40:22

  37
  38 const accountsFromQuery = await Promise.all(
  39   accountIds.map((id) =>
→ 40     prisma.account.findUnique(
Query parameter limit exceeded error: Joined queries cannot be split into multiple queries..

If I repeat the snippet without the relationJoins preview feature, here's what I get:
accountsFromQuery.length 33001
accountsFromQuery
{ id: 2, name: 'account-2', companyId: 1 }
{ id: 3, name: 'account-3', companyId: 1 }

I'm not, however, able to get the error you reported:
prisma.account.findUnique(
  Assertion violation on the database: `too many bind variables in prepared statement, expected maximum of 32767,
  received 150656`

Actually, thanks to a comment in a related issue (https://github.com/prisma/prisma/issues/24443), I was able to obtain the same error message (though while using a different schema and snippet).

Prisma schema
generator client {
  provider = "prisma-client-js"
}

datasource db {
  provider = "postgres"
  url      = env("TEST_POSTGRES_URI")
}

model User {
  id        Int    @id @default(autoincrement())
  name      String

  createdAt DateTime  @default(now())
  updatedAt DateTime  @updatedAt
  deletedAt DateTime?
}

@prisma/client snippet
import { PrismaClient } from '.prisma/client'

async function main() {
  const prisma = new PrismaClient({
    // log: ['query'],
  })

  await prisma.user.deleteMany()

  const n = 40_000
  const usersToSeed = Array.from({ length: n }).map((_, i) => {
    const id = i + 1

    return { id, name: `name-${id}` }
  })

  // seed 10k users
  await prisma.user.createMany({ data: usersToSeed })

  const usersFromQuery = await Promise.all(
    usersToSeed.map(({ id }) =>
      prisma.user.findUnique({
        where: {
          id,

          // comment `deleteAt` to make the query succeed
          deletedAt: null,
        },
      })
    )
  )

  console.log('usersFromQuery.length', usersFromQuery.length)
  console.log('usersFromQuery[0]')
  console.dir(usersFromQuery[0], { depth: null })

  process.exit(0)
}

void main().catch((e) => {
  console.log(e.message)
  process.exit(1)
})

Output
Invalid `prisma.user.findUnique()` invocation in
/Users/jkomyno/work/prisma/prisma/sandbox/basic-postgres/index.ts:22:19

  19
  20 const usersFromQuery = await Promise.all(
  21   usersToSeed.map(({ id }) =>
→ 22     prisma.user.findUnique(
Assertion violation on the database: `too many bind variables in prepared statement, expected maximum of 32767, received 40001`

Here's a brief explanation of what's happening:

Multiple findUnique queries are started concurrently within the same Node.js tick, via something like:
const results = await Promise.all([
  prisma.user.findUnique(...),
  prisma.user.findUnique(...),
])

When this happens, Prisma's Dataloader kicks in, an rather than emitting as many SELECT ... FROM "User" WHERE ... statements as there are concurrent findUnique queries, it emits a single SELECT ... FROM "User" WHERE ... compact query that tries to return the same data the user would expect, but in a single roundtrip to the database.

More precisely, consider the following findUnique query:
prisma.user.findUnique({
  select: {
    id: true,
  },
  where: {
    id: id, // `id` is a numeric variable
    deletedAt: null,
  },
})

Here is the SQL query emitted when running 1 findUnique query:

SELECT
  "public"."User"."id"
FROM "public"."User"
WHERE
  ("public"."User"."id" = $1 AND "public"."User"."deletedAt" IS NULL)
LIMIT $2 OFFSET $3

$1 is the query parameter for the 1st id, 1

Here is the SQL query emitted when running 2 concurrent findUnique queries:

SELECT
  "public"."User"."id", "public"."User"."deletedAt"
FROM "public"."User"
WHERE (
  ("public"."User"."id" = $1 AND "public"."User"."deletedAt" IS NULL) OR
  ("public"."User"."id" = $2 AND "public"."User"."deletedAt" IS NULL)
)
OFFSET $3

$1 is the query parameter for the 1st id, 1
$2 is the query parameter for the 2nd id, 2

Here is (part of) the SQL query emitted when running 32766 concurrent findUnique queries:

SELECT
  "public"."User"."id", "public"."User"."deletedAt"
FROM "public"."User"
WHERE (
  ("public"."User"."id" = $1 AND "public"."User"."deletedAt" IS NULL) OR
  ("public"."User"."id" = $2 AND "public"."User"."deletedAt" IS NULL) OR
  -- ... OR
  ("public"."User"."id" = $32766 AND "public"."User"."deletedAt" IS NULL)
)
OFFSET $32767

$1 is the query parameter for the 1st id, 1
$2 is the query parameter for the 2nd id, 2
$32766 is the query parameter for the 32766th id, 32766

The Postgres driver that Prisma uses under the hood supports a maximum of 32767 query parameters. This means that running the snippet of https://github.com/prisma/prisma/issues/23957#issuecomment-2228389812 with const n = 32767 is just enough to trigger the error
Invalid `prisma.user.findUnique()` invocation in
/.../index.ts:22:19

  19
  20 const usersFromQuery = await Promise.all(
  21   usersToSeed.map(({ id }) =>
→ 22     prisma.user.findUnique(
Assertion violation on the database: `too many bind variables in prepared statement, expected maximum of 32767, received 32768`


IOError: [Errno 2] No such file or directory: '/cvlabdata1/home/btekin/ope/yolo6D/LINEMOD/benchvise/JPEGImages/000493.jpg'

Hi, when I try to train the multi_obj model (python train_multi.py cfg/occlusion.data cfg/yolo-pose-multi.cfg backup_multi/init.weights) i get the following error. could you please help me? Thanks
2018-07-16 15:10:06 epoch 0, processed 0 samples, lr 0.000100
Traceback (most recent call last):
File "train_multi.py", line 408, in
niter = train(epoch)
File "train_multi.py", line 72, in train
for batch_idx, (data, target) in enumerate(train_loader):
File "/home/edison/anaconda2/lib/python2.7/site-packages/torch/utils/data/dataloader.py", line 281, in next
return self._process_next_batch(batch)
File "/home/edison/anaconda2/lib/python2.7/site-packages/torch/utils/data/dataloader.py", line 301, in _process_next_batch
raise batch.exc_type(batch.exc_msg)
IOError: Traceback (most recent call last):
File "/home/edison/anaconda2/lib/python2.7/site-packages/torch/utils/data/dataloader.py", line 55, in _worker_loop
samples = collate_fn([dataset[i] for i in batch_indices])
File "/data1/edison/singleshotpose/multi_obj_pose_estimation/dataset_multi.py", line 68, in getitem
img, label = load_data_detection(imgpath, self.shape, jitter, hue, saturation, exposure, bgpath)
File "/data1/edison/singleshotpose/multi_obj_pose_estimation/image_multi.py", line 446, in load_data_detection
total_masked_img, label, total_mask = augment_objects(imgpath, objname, add_objs, shape, jitter, hue, saturation, exposure)
File "/data1/edison/singleshotpose/multi_obj_pose_estimation/image_multi.py", line 376, in augment_objects
img = Image.open(imgpath).convert('RGB')
File "/home/edison/anaconda2/lib/python2.7/site-packages/PIL/Image.py", line 2543, in open
fp = builtins.open(filename, "rb")
IOError: [Errno 2] No such file or directory: '/cvlabdata1/home/btekin/ope/yolo6D/LINEMOD/benchvise/JPEGImages/000493.jpg'

This issue was resolved in #7 and also mentioned in #15, if you update the code to the most recent version and place the data folders in the indicated positions in the main directory, you should not get this error.


Separate schemes in apinetlet into managerScheme and apinetletScheme

Fixes #309

@sujeet01 @Rohit-0505 https://github.com/ironcore-dev/ironcore-net/pull/310/files#diff-cd513991cc10b556eb34e9aa31ffbe2e3090219f8ff47f0688ea2e07250a2db3R665-R673 these enqueue funcs produce the following error:
2024-07-29T12:45:28Z    ERROR   controller-runtime.source.EventHandler  kind must be registered to the Scheme   {"error": "no kind is registered for the type v1alpha1.Network in scheme \"pkg/runtime/scheme.go:100\""}
The other controllers are running as expected, please have a look and fix.
@afritzler hope the styling is okay, my formatter is a bit more picky :)

@sujeet01 will continue from here

closing this one as agreed we do not need the scheme changes and so on.


Background cache updates and custom log format (Fixes required for the IDR)

proxy_cache_background_update is automatically set to on when proxy_cache_use_stale is set. This seems a reasonable default so I've decided not to add another parameter to the role.
Adds support for a custom log format nginx_proxy_log_format_custom. This is needed because the last update changed the built-in log formats: https://github.com/IDR/deployment/issues/141

Rebased after merging #19

Generally looks straightforward. Two questions:

can the nginx_proxy_log_format_custom parameter be tested in one of the configuration in molecule?
I am unclear how nginx_proxy_log_format_custom will solve https://github.com/IDR/deployment/issues/141. Do you have examples on how the proxy servers would be configured both in IDR/deployment and in prod-playbooks which are the 2 major use cases?

The IDR log config is included in https://github.com/IDR/deployment/pull/165 since that requires the newer role

Could it be tested? Yes, but there are a lot of parameters in this role that aren't tested, so the question is do you think it's worth adding a second server or scenario for this one? If you think so I'll add it.

Regarding the last point on configuring proxy servers in prod playbooks, AFAIK the change to the log format was made to support a production requirement. If it's not (or requirements have changed) then there's no point in changing the Nginx format and we should revert it instead.

The changes look straightforward. The need for customizing the log format was raised in https://github.com/openmicroscopy/ansible-role-nginx-proxy/pull/18 in a given context and deployed to the relevant server via https://github.com/openmicroscopy/prod-playbooks/pull/66.
I do not believe the requirements for the production server have changed (or been reevaluated). On the other hand, I feel the addition of nginx_proxy_log_format_custom addresses the issue originally in #17 without changing the default log format (which happened to be user-breaking as described in https://github.com/IDR/deployment/issues/141).
At this stage, I would consider:

reverting the changes to the default log formats in https://github.com/openmicroscopy/ansible-role-nginx-proxy/pull/18, i.e. restore the previous behavior of nginx logs
also check setting nginx_proxy_log_format_custom together with this PR in the multiple virtualhosts use case is sufficient

I've reverted the commits from https://github.com/openmicroscopy/ansible-role-nginx-proxy/pull/18


{Freeway-Bug}[Adaptive Cards- Home- Inputs]: Talkback not announcing role and position of the menu/list items(Red, Green, blue).

Target Platforms
Android
SDK Version
2<IP_ADDRESS>
Application Name
Adaptive Card
Problem Description
Test Environment
Device: S21+ 5G
Screen Reader: Talkback
AdaptiveCard Android App version: 2<IP_ADDRESS>
Repro Steps:

Turn on Talkback.
Open Adaptive Cards Visualizer Application.
Home Page will opened.
Now Navigate to 'Sample card' button and select it.
Now navigate to "choose sample" expands/collapse control and select "Inputs" list item.
Now Navigate to Visual tab and select it.
Now navigate to Inputs card using swipe gesture and expand "What color do you want?" dropdown button.
Now Navigate to menu items and observe the issue.

Actual Result:
Talkback not announcing role and position of the menu/list items((Red, Green, blue). Talkback announce like "ticked, Red in list ".
Expected Result:
Talkback should announce the role and the position of the menu/list items((Red, Green, blue). Talkback should announce like "ticked, Red 1 of 3, list/menu item ".
User Experience:
Knowing the role for a control helps users know what will happen when that object has focus and is selected, as well as what keyboard shortcuts to use when interacting with the control. When the component’s state/value/property is not defined, assistive technology users are often blocked from using the control or knowing what to expect when interacting with the component.
WCAG Reference:
https://www.w3.org/WAI/WCAG21/Understanding/name-role-value
"Have feedback to share on Bugs ? Please help fill Trusted Tester Bug Feedback (office.com)
Screenshots
https://user-images.githubusercontent.com/89897257/230354375-911c9118-1a15-4e25-b17b-df11759a8e3b.mp4
Card JSON
NA

Sample Code Language
No response
Sample Code
No response

@Bhaskar301101 changes have been merged. please test demo app

Closing this issue here as of now this issue is still repro and having Sev 3 so we have created a new bug.
https://github.com/microsoft/AdaptiveCards-Mobile/issues/89


ketcher.editor.struct().isReaction is false even when rxnArrows exists

not sure if it's a bug or there is other logic in there
ketcher.editor.struct().isReaction is false even when rxnArrows exists
Screenshots

Ketcher version [e.g. v2.4.2-115-gcf0c1394].
2.4.2 build at 2022-02-21T15:06:53

Dear @Pandaaaa906 ,
Thank you for your interest in Ketcher and for your report
We will work on this issue in near future
For now, you can refer to rxnArrows field for getting information about existing rxnArrows
Feel free to ask, if you have any questions, we will be happy to help
Best regards,
Ketcher team

not sure if it's a bug or there is other logic in there ketcher.editor.struct().isReaction is false even when rxnArrows exists
Screenshots
Ketcher version [e.g. v2.4.2-115-gcf0c1394]. 2.4.2 build at 2022-02-21T15:06:53

I was trying to reproduce the issue. Here is it.
https://user-images.githubusercontent.com/27288153/199451424-6173c64c-b193-49f1-aad6-019a0436130d.mp4

Dear @Pandaaaa906 ,
struct.isReaction property will be deleted. right now please use the following methods:

ketcher.editor.struct().hasRxnArrow() - it returns 'true' if only one arrow has been added to the canvas (2 or more arrows are interpreted as graphic elements)
ketcher.editor.struct().isRxn() - it returns 'true' if this.hasRxnArrow() || this.hasRxnPluses()

Regards, Ketcher team

If I understand correctly, ketcher.editor.struct().hasRxnArrow() will return false if there are more than one arrow, but I find it still returns 'true'.
https://user-images.githubusercontent.com/27288153/199452856-e7d37adc-1213-47b0-b12e-a777acdd20d5.mp4


chore: release 1.0.0

:robot: I have created a release *beep* *boop*
1.0.0 (2019-05-13)
Bug Fixes

deps: update dependency google-gax to v1 (#176) (423ae98)
DEADLINE_EXCEEDED is no longer retried (20eb86c)
DEADLINE_EXCEEDED retry code is idempotent (#177) (e8313ab)
deps: update dependency google-gax to ^0.26.0 (#166) (b449fc7)

Build System

upgrade engines field to >=8.10.0 (#168) (249c7a8)

BREAKING CHANGES

upgrade engines field to >=8.10.0 (#168)

Release is at https://github.com/googleapis/nodejs-automl/releases/tag/v1.0.0

The release build has started, the log can be viewed here. :sunflower:

:egg: You hatched a release! The release build finished successfully! :purple_heart:


feat(ast): add the AST and parser for CMakeLists.txt files

The actual parser and AST, build on the previously submitted lexer.  This lacks support for some things which aren't used in LLVM's more modern CMakeLists.txt files, but is otherwise handles the important parts of CMake's "grammar".
Due to some of the constraints of the parser generator library the AST isn't quite as compact as it could be, but works pretty well.

Michael, if you get a chance I'd appreciate an ex post facto review, but no worries either way :-)

I wasn't finished reading, but I didn't see anything obviously needful, so I'll probably just wait for the next round. :) If I find anything I can't handle I'll send a PR.


[NEED SUPPORT] bbexample-lt_1.0.bb:do_compile FAILED

I've tried to build bbexample-lt, but do_compile task failed.
My environment:

Yocto 2.5.1
poky master branch
Ubuntu 16.04 LTS as host

Could someone help?
The error logs:

Loading cache: 100% |############################################| Time: 0:00:01
Loaded 1263 entries from dependency cache.
NOTE: Resolving any missing task queue dependencies
Build Configuration:
BB_VERSION           = "1.39.1"
BUILD_SYS            = "x86_64-linux"
NATIVELSBSTRING      = "universal"
TARGET_SYS           = "i586-poky-linux"
MACHINE              = "qemux86"
DISTRO               = "poky"
DISTRO_VERSION       = "2.5+snapshot-20181010"
TUNE_FEATURES        = "m32 i586"
TARGET_FPU           = ""
meta
meta-poky
meta-yocto-bsp       = "master:90028f3771a594d0cfb9560f463f2d15f052599e"
meta-example         = "master:5ee4f20b041bc886b1d2d913ac11814057317634"
Initialising tasks: 100% |#######################################| Time: 0:00:01
Sstate summary: Wanted 6 Found 0 Missed 6 Current 72 (0% match, 92% complete)
NOTE: Executing SetScene Tasks
NOTE: Executing RunQueue Tasks
ERROR: bbexample-lt-1.0-r0 do_compile: oe_runmake failed
ERROR: bbexample-lt-1.0-r0 do_compile: Function failed: do_compile (log file is located at /home/ken/Devtools/Yocto/poky/build/tmp/work/i586-poky-linux/bbexample-lt/1.0-r0/temp/log.do_compile.7416)
ERROR: Logfile of failure stored in: /home/ken/Devtools/Yocto/poky/build/tmp/work/i586-poky-linux/bbexample-lt/1.0-r0/temp/log.do_compile.7416
Log data follows:
| DEBUG: SITE files ['endian-little', 'bit-32', 'ix86-common', 'common-linux', 'common-glibc', 'i586-linux', 'common']
| DEBUG: Executing shell function do_compile
| NOTE: make
| make  all-am
| make[1]: Entering directory '/home/ken/Devtools/Yocto/poky/build/tmp/work/i586-poky-linux/bbexample-lt/1.0-r0/build'
| make[1]: *** No rule to make target '.libs/libbbexample.la', needed by 'bbexample'.  Stop.
| make[1]: Leaving directory '/home/ken/Devtools/Yocto/poky/build/tmp/work/i586-poky-linux/bbexample-lt/1.0-r0/build'
| Makefile:360: recipe for target 'all' failed
| make: *** [all] Error 2
| ERROR: oe_runmake failed
| WARNING: exit code 1 from a shell command.
| ERROR: Function failed: do_compile (log file is located at /home/ken/Devtools/Yocto/poky/build/tmp/work/i586-poky-linux/bbexample-lt/1.0-r0/temp/log.do_compile.7416)
ERROR: Task (/home/ken/Devtools/Yocto/poky/meta-example/recipes-example/bbexample/bbexample-lt_1.0.bb:do_compile) failed with exit code '1'
NOTE: Tasks Summary: Attempted 443 tasks of which 442 didn't need to be rerun and 1 failed.
NOTE: Writing buildhistory
Summary: 1 task failed:
/home/ken/Devtools/Yocto/poky/meta-example/recipes-example/bbexample/bbexample-lt_1.0.bb:do_compile
Summary: There were 2 ERROR messages shown, returning a non-zero exit code.

@FavoRiteKK can you take a look at the latest commits here and to meta-example.
I was seeing the same build issues and with a couple of changes it's now building for me

Great news. Thanks for reporting the problem @FavoRiteKK


Packaging request: ssh-chat

Project description
Custom SSH server written in Go. Instead of a shell, you get a chat prompt.
Metadata

homepage URL: https://medium.com/@shazow/ssh-how-does-it-even-9e43586e4ffc
source URL: https://github.com/shazow/ssh-chat
license: MIT
platforms: MacOS (darwin/amd64) and Linux (386, amd64, and ARM6 for your RaspberryPi)

Package seems to have been added to nixpkgs, so the issue can be closed


List view

i want the sliding layer to be a list view , but swiping on it is not working ??

Hi!
Does the layer stick horizontally or vertically?
If it scrolls vertically i does not make too much sense from a UX perspective to have scrolling content. Also the touch events will collide with each other: the deepest child always consume touch events, otherwise the list would never scroll.
If the layer is bound to the right or left side and listview scrolls vertically, you should be able to swipe horizontally.
What's your specific case? The more you share the better :)

hii ,
thanks for the reply ,
the layer is bound to the right and listview scrolls vertically, but i should not be able to swipe to the right side , because when i try to swipe on list on item to the right , the layer  close

I see that. So your listView allows swiping items away horizontally. That could be a confusing experience for users. For now the library consumes the event if it can handle it, or pass it to the next listener otherwise. That was done intentionally. What you can do though both to provide a more usable experience and avoid the layer consuming the event is to allow swiping elements to the opposite direction of the layer. So in this case, allowing swiping elements in the list to the left when the layer is fully open.
Let me know if that works for you, otherwise we can get it fixed.

@JlUgia, is there a way to override the x distance necessary to close the layer? So when flinging a listview, you are not closing the layer?


Update research page with real-time data downloads section

Description

update research page with real-time data downloads section
add a Graph Commons network map of data structure to new section
https://graphcommons.com/graphs/d743b2ae-3da8-43a3-821a-6bc05f6d103c?auto=true
on large screens, open all accordions on page load

Context/Issue Link
https://github.com/participedia/api/issues/896
Screenshots (if it's a frontend change)

@ascott I assume the graph image redirects people to the graphcommons site? or does the graph load in the research page?

@jesicarson the graph will load in page, and also you can click the graph commons text in the bottom left once you are viewing the graph in the page.

very cool. i don't suppose the graph could be pre-loaded so we don't have to click it to load?

@jesicarson looked at the options, and it is possible to have it load straight away 👍

love it

we may want to add a very short description about what the graph is showing. Something like...
The graph below is a visual representation of all the data fields for cases, methods and organizations entries, and how they are linked. For example, all three entry types share the "scope of influence" field, while only cases have a field for "legality."


feat: Translate to Chinese

Description
Thank you for offering such powerful technology.
I'm more than happy to help by translating this book into Chinese to attract more like-minded friends to learn and progress together.
If you are embarking on this task, do you have any additional suggestions? Should I go ahead and merge it into this repository by submitting a Pull Request (PR)?
Code of Conduct

[X] I agree to follow this project's Code of Conduct.

Thanks a lot for the initiative, @lispking! We definitely want to support users in the language they feel most comfortable in. For translations of our docs, I see 3 main possibilities:

Keep the translations in this repository. This gives us a lot of control but also a lot of overhead. Also, the tool we use (mdBook) doesn't really support multilingual docs well.
Keep the translations in separate repositories, possibly owned by community members such as yourself. This would reduce our overhead but may also mean that the content gets out of sync pretty quickly (as we will keep changing the docs over the coming months). Would you be willing to maintain something like this?
Simply let users use their favorite AI tool like Google Translate to browse our site. This is of course not perfect, but would be by far the most maintainable solution. Maybe you could take a look at the Chinese translation created by Google Translate and check if it is of sufficient quality?

We will also discuss the different options within the team and get back to you in the coming days.

https://github.com/google/mdbook-i18n-helpers
Discovered this library, quite interesting. It seems that everyone is using this plugin in mdbook to implement it.

@mlegner I tried translating Chinese and it seems to work with this method. I've submitted part of the translation in the PR, and it looks quite user-friendly.

https://github.com/google/mdbook-i18n-helpers Discovered this library, quite interesting. It seems that everyone is using this plugin in mdbook to implement it.
I have already forked the branch and it's under verification: https://github.com/lispking/walrus-docs

Translation effect can be viewed here: https://rustx-labs.github.io/walrus-docs/

Thank you so much for all your work on this, @lispking. I will take a look at the setup and ask one of the native Chinese speakers on the team to take a look at the translation.


pool: Allow I/O interface to be configured per-pool

Add io_if to CreatePoolRequest with permissible values of aio, uring and auto (preferring uring if supported by the kernel) and create the appropriate type of bdev.
Show kernel io_uring support status on startup.
Add a unit test to check for valid I/O interfaces values.

@gila suggested using an enum for the I/O interface so I'm looking into that.


Music Discs don't have a Max Stack Count like vanilla discs.

Music Discs can be stacked up to 64, unlike vanilla discs which can only go to 1.
Because of this, you can hold two music discs, click onto a jukebox and it'll take one, but after ejecting it from the jukebox, two discs will drop resulting in duped discs.
This is likely because music discs don't know how to handle discs that have more than 1 in a stack.

Disc item was moved to BCLib and now have fixed stack size

Fixed in 0.9.7


Fix build status for BitBucket Server

This fixes the out script to work correctly on BitBucket Server.
It mirrors the changes made in #2 for BitBucket Cloud (specifically in commit fb0158a15a80efe1fbbe77664150a383196231c1).

Hi,
I'm sorry to be late with the reply. But what a problem do you try to solve? According to the API documentation the key value must by unique for a same build result.

Hi @idr0id, it's been a while and I don't remember the exact problem I was having. I'll try to reproduce the issue again and add more details here!

This behavior is changed in #14


add dep constraints for dep server

Summary

Implements #211, this was missed somewhere along the line when we did .NET Core.
I will remove the CNB update stuff from our Concourse pipelines when this is merged.
Use Cases

Checklist

[X] I have viewed, signed, and submitted the Contributor License Agreement.
[X] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[ ] I have added an integration test, if necessary.
[X] I have reviewed the styleguide for guidance on my code quality.
[X] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

A meta-question I have is: Why did the concourse workflow that updates the ICU dependencies do it so infrequently?
(See this set of closed PRs).
Also, it seems like each of those dependency update PRs adds a major version and removes a major version (rather than adding and removing a minor or patch). Are the dependency constraints added to the buildpack.toml correct for how frequently we want to be updating this dependency?

@fg-j I think ICU is just released super infrequently. Looking at https://github.com/unicode-org/icu/releases, the last release before 70.1 was 69.1 which they released in April. I don't that's sus.
Good call on the versioning though. I think we just always supported the two latest releases, regardless of major version. Changing that now.


Feature Request: ability to put comments in Procfiles

I'd like to add comments to my Procfile, I tried starting a line with "#" but it complained and failed to boot.
Comments would be great for documentation for team projects.

Agree, this would be extremely useful. "as simple as possible but no simpler". Cheers

as a counterpoint - for development i have a Procfile.dev which runs extra tasks like compiling coffeescript (not a rails app) and running the app with shotgun not rackup. Could you try that instead? the -f option on foreman allows you to specify a different Procfile...

The pattern I like to take for these cases is to use binscripts:
$ cat Procfile
web: bin/web

$ cat bin/web
#!/bin/sh
if [ "$RACK_ENV" == "development" ]; then
  shotgun start -p $PORT
else
  thin start -p $PORT
fi

ah, that makes sense too, if it weren't for the extra tasks

+1 for comments

+1 for comments

+1 for comments

+1 for comments

+1 for comments

+1 for comments

+1, especially as we want to have a Profile.example that folks can use easily

Foreman has used a matching filter on the Procfile to only parse lines that look like process entries for a few years now. Are you still running into problems with thos?

@ddollar  You're correct -- appending # to the beginning of line at the Procfile effectively makes it function like a comment. Sorry for bringing up a nonexistent issue.

I swear I tried it at some point and it didn't work, but it's totally working now. Thanks, guys.

Using foreman 0.82.0 on OS X 10.11.5 and Ruby 2.1.2 I found that lines starting with # ARE processed, whereas lines starting with // are ignored.  For example this Procfile:
# foo: cd foo && bundle exec rails s -p 3000
// bar: cd bar && bundle exec rails s -p 3001
baz: cd baz && bundle exec rails s -p 3002

starts two processes: foo and baz
Would it be possible to add true comments rather than a parser-matching-filter to recognize lines that look like process entries?
If so, please also update docs to indicate how comments work (e.g., comment string: #, //, or other?, whole lines only?, end of line only?, multi-line? END? etc.)

+1 for comments

+1 for comments

+1 for comments

Bump.

It's a file.
+1 for DOCUMENTING the format for a comment...


link 페이지에서 id값을 받아오지 못함

🤔 해결하려는 문제가 무엇인가요?
🎉 변경 사항
🙏 여기는 꼭 봐주세요!
사용 방법
🌄 스크린샷
📚 참고

Codecov Report
Patch and project coverage have no change.

Comparison is base (2413b0b) 90.81% compared to head (297244c) 90.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #315   +/-   ##
=======================================
  Coverage   90.81%   90.81%
=======================================
  Files          42       42
  Lines         294      294
  Branches       52       52
=======================================
  Hits          267      267
  Misses         27       27

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Implementing People Picker to search all user profiles and not just current site (#97)

Q
A

Bug fix?
[X ]

New feature?
[X]

New sample?
[ ]

Related issues?
Implements People search for all tenant users as mentioned in #97

What's in this Pull Request?
The items implemented in this PR:

Search across All Users instead of only this site by default.
Added resolveDelay to allow search of users across the tenant
Binding defaultUsers to non existent site users
Updated Documentation with details for resolveDelay and added Principal type

Codecov Report

Merging #196 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #196   +/-   ##
=======================================
  Coverage   72.24%   72.24%
=======================================
  Files          15       15
  Lines         645      645
  Branches      123      114    -9
=======================================
  Hits          466      466
  Misses        139      139
  Partials       40       40

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79846a4...251706e. Read the comment docs.

@estruyf - I'd love to test this PR. Any idea when it might end up in a beta?

@sympmarc will try to process this later tonight. There are some changes required before this can be merged.
@AsishP thanks again for the updates. The value of all should be 15, not 13, but it might be better to not include this. As it could create conflicts if you specify for instance [User, All].

It feels that the control is a mix of everything right now. Will require a bit more time in order to rewrite it.
Example:

On initial load, the users are retrieved from the site users endpoint
On search, the users are retrieved from the tenant

IMO we have to go for a similar implementation like in the property pane control. When a site URL is provided it, it searches against the current site. When the site URL isn't provided, it searches over the whole tenant.
@AsishP @sympmarc thoughts?

Sounds right to me. Ideally, the property pane and this one should work the same (as I suggested in the associated issue) - and should probably share code, if that works. End result should be a people picker that works like any other people picker.

@estruyf , sorry, yeah it should have been 15 don't know why I had left it to 13, I was testing something and forgot to change it back. Updated it back to 15.
Regarding the logic, I suppose the code is doing as stated in your example. It loads the users from default site on load and then searches from tenant on Inputchange of people picker control. Below the logic in the code at present, please let me know if anything is amiss. Would love to fix any gaps to make it efficient and better. Please suggest.

The users are prefilled from site on load for existing site users and userid for existing users and put into the state.
Regarding default users, the users are filled from site users and if not present, they are pulled from tenant and updated to state for the control.
For non-existent users, search from tenant users (got the idea from property control implementation approach) on InputChange method and then update the state with new users if not present.
In step 3, since there is a delay for search to return users so had to add a resolveDelay for 1 sec to allow the filter to work. Might there is a better approach here.

Thoughts, suggestions?

@AsishP the option should be at the developer from which source he/she wants to retrieve the data. I like the prefilling idea, but I think it's unnecessary. If the user wants to retrieve data from the tenant, the prefilling should be skipped, as data should come from the tenant search.
When the developer wants to limit data only from the current site, the tenant search should be skipped.
So for your suggestions:

Don't feel that we need prefilling, or only when the dev wants to receive data from the current site.
Should be defined by the dev from which scope he wants to retrieve data.
...

I think it might be better to completely redevelop the control. Just like @sympmarc said to have the same behavior as in the property pane control.

@AsishP and @sympmarc the control has completely been rewritten. When the webAbsoluteUrl property is provided, the people search will be done on the site level. When not provided, this will be at the tenant level.
The code is also simplified + removed a lot of unused state properties. Let me know what is missing or needs to be changed.
New beta version is available for testing.

Ok, let me check the property pane control in detail then to see the flow. I did give it a quick check earlier but not a detailed study. To confirm, this is my understanding on the flow right now.

Developers could choose between All Tenant, All Site or Site Group.
For All Tenant users, there will be no auto suggestions till search is done for first three characters. The match will be done after third character and fill the state with matches so to speed up future filtering.
Will keep the same pre-fill users logic, as the user could be at site or tenant but giving preference to site.

@sympmarc, please give some time for the above to be implemented. @estruyf, I see some conflicts in my PR, so just confirming are these changes with regards to this PR or something else.

Sorry, seems my message came later after @estruyf message. Thanks @estruyf, for the update. Please let me know if I should close this PR.

@AsishP yes, you should best get the latest DEV version, as a lot has been replaced, rewritten, ...
About point 2, this is indeed a limitation of the API, but don’t feel that this is an issue. As the most of the time you will search, and the proposed once will not be used.
About point 3, pre-fill logic is implemented if you are retrieving from the site/group.
We can keep the PR open to discuss it, or we could do it in a new issue. Your call.

@estruyf , with beta build, the search is happening on entire tenant (as we were expecting). However, the selected item's properties is returning loginname in place of user id:

Is this change expected?

Definitely an improvement, @estruyf and @AsishP! Thanks for digging into this.
Getting the claim back for the id does make some sense, since the selected user may not be in the User Information List yet. (In the previous iteration, since the only users returned were from the current site, they were guaranteed to be in the UIL.)
I think we need to then ensure the user(s) are added to the UIL with a call something like this:
  private _getPeoplePickerRequestedBy(items: any[]): void {
    var updateRequest: IShipmentRequest = this.state.newRequest;
    sp.web.ensureUser(items[0].secondaryText).then((user) => {
      updateRequest.ShipmentRequestor.id = user.data.Id.toString() as string;
      updateRequest.ShipmentRequestor.title = user.data.Title;
      this.setState({
        newRequest: updateRequest
      });
    });
  }

@ManiKum when you do the tenant search, you indeed get the user claim. As the API doesn't return the user ID of the UIL as @sympmarc explained. We could indeed add an implementation as @sympmarc provided, or we could also leave it up to the developer. IMO it all depends on what you want to do eventually with the selected user object.
About the defaultSelectedUsers property`, can you explain this a bit more? How it currently works is that it validates against the API if the user exists, if he/she is retrieved, they will be added to the control as a selected user.

It might be a nice option to add ensureUser as a parameter? If that was true, then then the picker could return the local user object. If false, it would return the people picker object.
Not sure how best to implement this, but it seems to make sense to tuck it in somehow.

@sympmarc I actually like that idea. Let me try to implement this.

@sympmarc and @ManiKum the ensureUser ability has been included to the control. By default, this setting is false and returns the user login name. If set to true, it will validate the user against the current site and return its ID instead. A new beta is out and available to test.

@estruyf - In my initial testing, this is working great. Thanks for adding ensureUser.

Thanks @sympmarc for testing it out. Will release the public version later this week.

Hi @estruyf , I tried to merge the changes into this PR but there were too many conflicts and didn't know if I was merging it correctly. So I think it is safe for me to close this PR and we go with your commits. Thanks, please let me know.

Yes, we can close this PR.


Reveal Pre-images beyond the end of the enrollment cycle

Reveal pre-images beyond the current cycle. This will help reduce the risk of being slashed when the new cycle starts.

Good try! But I don't think this should solve the root cause because what you're intending to do in the PR is already done as follows in Base.d
        // Check block is at target height for the participating clients
        const enroll_block = first_client.getBlock(enrolled_height);
        this.expectHeightAndPreImg(client_idxs, target_height,
            enroll_block.header, 10.seconds, file, line);

It happens fifty-fifty in local machines, which means to be very tricky. We could raise an issue and handle it.

Good try! But I don't think this should solve the root cause because what you're intending to do in the PR is already done as follows in Base.d
        // Check block is at target height for the participating clients
        const enroll_block = first_client.getBlock(enrolled_height);
        this.expectHeightAndPreImg(client_idxs, target_height,
            enroll_block.header, 10.seconds, file, line);

But the enrolled_height here is assumed to be at the end of the cycle which is not the case for the test that limits the enrollments to 3 in block 20 and has then has 3 in block 21. That is why we should not rely on this function for the test which does not follow the expected pattern of enrollment.

My comment was for the previous code that was, if I'm correct, passing in the enrollments for this function. But the code has been changed. Anyway, I'm thinking that the expectHeightAndPreImg has to have all the current enrollments for target_height as a parameter but it doesn't now, which I think you might have meant. I will fix the code in this sprint.

Closing as we have https://github.com/bosagora/agora/pull/3153


build_image: fix generation of version.txt

The generation of version.txt was the only thing depending on sourcing
the deprecated BUILD, BRANCH, and PATCH values from version.txt which
common.sh no longer does since 0b6acf86. Derive them instead.

lgtm


IndependentCombinators: true > Type 'true' is not assignable to type 'false'

Hi! I'm new using this library and I'm trying out in my react + typescript project
I need that combinators were independent but I have this problem that  I can't set independentCombinators={true}
Do I'm missing something?

Hi, @Laura-Urb! I can't see from your screenshots, but it looks like your query object is of type RuleGroupType. When the independentCombinators prop is true, query (or defaultQuery) must be type RuleGroupTypeIC.
The difference between the types is that for the IC variant, the combinator values reside between each rule in the rules array instead of on the combinator property, like this:
const query: RuleGroupTypeIC = {
  rules: [
    { field: 'lastName', operator: '=', value: 'Vai' },
    'and',
    { field: 'firstName', operator: '=', value: 'Steve' },
  ],
};

I apologize for the lack of documentation on that. I think the TypeScript page is really all we’ve got at the moment. I’ll get on that soon!

Thank you so much for the help!! That was excatly my problem (wrong type)

Hi, @Laura-Urb! I can't see from your screenshots, but it looks like your query object is of type RuleGroupType. When the independentCombinators prop is true, query (or defaultQuery) must be type RuleGroupTypeIC.
The difference between the types is that for the IC variant, the combinator values reside between each rule in the rules array instead of on the combinator property, like this:
const query: RuleGroupTypeIC = {
  rules: [
    { field: 'lastName', operator: '=', value: 'Vai' },
    'and',
    { field: 'firstName', operator: '=', value: 'Steve' },
  ],
};

I apologize for the lack of documentation on that. I think the TypeScript page is really all we’ve got at the moment. I’ll get on that soon!


Keep a bathroom for damaged ship from 3-2-1

After 3-2-1, one ship (almost submarine) usually need to go bath.

implement in #19


Great slides and blog post

Do you have an example of react native project using storybook?
I'm tried to use getstorybook in latest RN 0.44, but it does not show anything at all
any ideas?

it is working fine in this project https://github.com/sibelius/RNStorybook
I have a problem with a more complex project, I'll try to find the problem
tks


dbus-daemon complains about unknown user "pulse" and unknown group "netdev"

My syslog journal on nixos-unstable contains the following error messages:
dbus-daemon[1405]: dbus[1405]: Unknown username "pulse" in message bus configuration file
dbus-daemon[1405]: dbus[1405]: Unknown group "netdev" in message bus configuration file

The system appears to be working fine, so clearly this is not a critical problem, but still it's probably not good either. Maybe NixOS should ensure that those entries exist?

Still valid for me, not sure if it's really an issue:
23.05.20230402.dirty (Stoat)

I get this too. I still have sound though. I wonder if it's due to Pipewire being enabled. I've not noticed any issues yet but I'm still setting up my system.


Where do I find the source code for the examples?

The examples site has many examples:
http://clauderic.github.io/react-sortable-hoc/
But the source code only has 5:
https://github.com/clauderic/react-sortable-hoc/tree/master/examples
Am I missing something? Where can I see the source code used to create these examples? If it exists somewhere, maybe the docs should link to it.

@clauderic please add the source code for examples

I found examples in the end, hidden inside the storybook code:
https://github.com/clauderic/react-sortable-hoc/blob/master/src/.stories/index.js
However, I'm unable to get these working on Windows as node-sass refuses to install/compile on Windows!

@chucksellick Unfortunately, not all examples are there. For example, Sortable Table Rows is missing and I can't find it anywhere in this repo.

All the source is there (or you would not be able to run it locally ;).
I think the storybook was added after some of the examples so some code (the stuff you are after) is in react-sortable-hoc/examples/virtual-table-columns.js. When someone has time, links should be added to get to the source throughout the storybook but you can dig it out as needed in the meantime.


CodeQL workflow for SCA

Adding CodeQL for Static Code Analysis

@rob-casper  Can you let me know if we can merge this?

@bradjohnl - looks fine to me


[Bug] TypeError: Cannot read properties of null (reading 'call')

Is there an existing issue for this?

[X] I have searched the existing issues

Package Version
^0.3.5
Current Behavior
I am trying to use the useSigner hook to get the signer and insert it into an ethers Contract instance. I am using Next JS and trying to build an NFT marketplace. When I leave click on a different page and come back to the initial page, everything seems to work normally. But when I refresh the initial page, I get the error. I put the signer variable from useSigner into the dependency array of my useEffect function which helped load the NFTs, but didn't get rid of the error.
Expected Behavior
I expected no errors to happen and for the ethers contract instance to use the signer variable from the useSigner hook.
Steps To Reproduce
import { ethers } from "ethers";
import { marketplaceAddress } from "../config";
import { useEffect, useState } from "react";
import { useSigner } from "wagmi";
import NFTMarketplace from "../artifacts/contracts/NFTMarketplace.sol/NFTMarketplace.json";
import styles from "../styles/Profile.module.css";
import Image from "next/image";
import axios from "axios";
import logo from "../public/logo.png";
import { faGear } from "@fortawesome/free-solid-svg-icons";
import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";

const Profile = () => {
  const [nfts, setNfts] = useState([]);
  const [loadingState, setLoadingState] = useState("not-loaded");
  const { data: signer } = useSigner();

  useEffect(() => {
    loadNFTs();
  }, [signer]);

  async function loadNFTs() {
    const contract = new ethers.Contract(
      marketplaceAddress,
      NFTMarketplace.abi,
      signer
    );
    const data = await contract.fetchItemsListed();
    // Map over items returned from smart contract and format them as well as fetch their token metadata
    const items = await Promise.all(
      data.map(async (i) => {
        const tokenUri = await contract.tokenURI(i.tokenId);
        const meta = await axios.get(tokenUri);
        let price = ethers.utils.formatUnits(i.price.toString(), "ether");
        let item = {
          price,
          tokenId: i.tokenId.toNumber(),
          seller: i.seller,
          owner: i.owner,
          image: meta.data.image,
          name: meta.data.name,
          description: meta.data.description,
        };
        return item;
      })
    );
    setNfts(items);
    setLoadingState("loaded");
  }

  return (

      {loadingState === "loaded" && !nfts.length ? (

No items listed in marketplace

      ) : null}

          <Image src={logo} alt="profile" width={152} height={152} />

          <button className={styles.profileEditBtn}>Edit</button>
          <button
            className={styles.profileSettingsBtn}
            aria-label="profile settings"
          >
            <FontAwesomeIcon icon={faGear} />
          </button>

              222 posts

              22 followers

              22 following

music, art, and tech enthusiast.

      {nfts.map((nft, i) => (

          <Image
            src={nft.image}
            alt="NFT"
            width={400}
            height={400}
            style={{ objectFit: "cover" }}
          />

{nft.name}

{nft.description}

{nft.price} ETH

            <button onClick={() => listNFT()}>List</button>

      ))}

  );
};

export default Profile;

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)
No response
Anything else?
I am currently on a hardhat local network. I feel like this must be some sort of rendering issue with Next JS, since the code works, just not on the initial load or when you refresh. It only seems to work when being navigated to on the client.

Please provide a minimal reproducible example and re-open


Missing Microsoft VBScript Regular Expression 5.5 in Tools -> References

I am trying to use RegExp in VBA macros and not able to.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7ff8fedb-54cc-ce30-08f7-a2238b0a71b7
Version Independent ID: 26e8360b-49da-8e39-0dca-b485c694f0b6
Content: Getting Started with VBA in Office
Content Source: Library-Reference/Concepts/getting-started-with-vba-in-office.md
Product: office
GitHub Login: @o365devx
Microsoft Alias: o365devx

@sanzzzay
Thanks for your feedback. We use Github issues for documentation bugs, not for developer support. Please try the VBA developer community on Stack Overflow (https://stackoverflow.com/questions/tagged/vba) where you can get help from actual developers. If you find a bug in our documentation, please let us know! Thanks!


[Feature request] Add argument to reboot

Hello, I am very happy to know that this project exists. Amazing job.
I immediately shared it with my friend @dreamwhite and I saw he has already pinged you to fix some niche things ad discrepancies, it's so nice to see that you've quickly fixed everything he noticed that was broken/missing :)
By the way, we're mostly using this tool for BIOS mods (DVMT Pre Allocated / CFG Lock etc) but I have a weird laptop where the trackpad works for Linux and Windows when I set it to APIC interrupt, and this mode is unsupported for macOS; on the other hand, GPIO interrupt works for macOS but not for Windows/Linux.
This tool comes very handy in conjuction with OpenCore Tools section, where you can send parameters when launching an option in the picker. However, after launching the tool, the user is forced to soft shutdown by pressing once the button (no force shutdown) and then boot back again with the edited BIOS option.
Would it be possible to set an argument to reboot after the change is applied to speed things up?
something like
setup_var.efi 0x2CA 0x01 -n Setup --reboot

Of course :)
A new argument (-r/--reboot) has been added in 0.2.2.


Use data attributes even when instantiating manually

I had set the label to use on the button using a data attribute, but I was instantiating manually using JavaScript
<input type="file"  name="file" data-buttonText="Parcourir" />

$('.Form input[type=file]').jfilestyle();

While browsing the code I saw that data attributes where only used with the automatic trigger (class jfilestyle), shouldn't the JavaScript call also make use of the data attributes if it was not passed as an option?

You can use both options together. No problem


Expand standard widgets library

More widgets in the main gi package like date and time pickers, chips, switches, and temporary popups (Material Design calls them Snackbars) would be good.

All of the aforementioned widgets have been added, but we still might want to add more (maps, navigation bars/rails/drawers, carousels, etc). We need to decide on our plan here in the context of #511.

We also might still want to add sheets; if not, we should get rid of the current code for them.

We also need to resolve switch styling and icons.

We have implemented everything mentioned above that is necessary and relevant. Navigation bars/rails/drawers are mostly implemented and will be finished in #658. We will implement maps in the context of Cogent Maps. We will not support sheets and carousels, as they are both mobile-specific widgets that provide no functionality beyond what can already be accomplished with more standard, consistent, and cross-platform widgets like dialogs and layouts. Also, dialogs will be improved more in the context of #812. If someone ever has an actual and necessary use case for sheets or carousels in the future, we can consider implementing them, but it is not a high priority.


Fallback to code generating if the dominance check fails

…to code generation
Small example to illustrate a missed optimization opportunity:
define dso_local i64 @_Z15MissingPattern4m(i64 %0) local_unnamed_addr #0 {
%2 = xor i64 %0, -1276188105
%3 = shl i64 %0, 1
%4 = and i64 %3, -2552376210
%5 = add i64 %2,<PHONE_NUMBER>
%6 = add i64 %5, %4
%7 = add i64 %0, 16 ; Replacement origin that fails the dominance check
%8 = and i64 %6, %7
ret i64 %8
}

Sorry the old test case didn't trigger the problem. This is the correct one:
; Function Attrs: nofree norecurse nounwind writeonly
define dso_local dllexport i64 @test(i64* nocapture %a, i64 %b) local_unnamed_addr #0 {
entry:
  %0 = add i64 %b, -3304
  %1 = shl i64 %0, 1
  %2 = xor i64 %0, -1276188105
  %3 = and i64 %1, -2552376210
  %4 = add i64 %2,<PHONE_NUMBER>
  %5 = add i64 %4, %3
  %6 = add i64 %b, -3288
  store i64 %6, i64* %a, align 8
  ret i64 %5
}

The valid replacement found by souper:
%0:i64 = var
%1:i64 = add<PHONE_NUMBER>3709548312:i64, %0
%2:i64 = xor<PHONE_NUMBER>2433363511:i64, %1
%3:i64 = add<PHONE_NUMBER>:i64, %2
%4:i64 = shl %1, 1:i64
%5:i64 = and<PHONE_NUMBER>1157175406:i64, %4
%6:i64 = add %3, %5
%7:i64 = add<PHONE_NUMBER>3709548328:i64, %0
cand %6 %7

Now when souper reaches the dominance check it fails because the origin of the candidate is %6 = add i64 %b, -3288 which doesn't make any sense. We didn't stress test the patch but it worked for our scenario so we thought its a good starting point to find a proper solution for this problem. Can you explain why %6 = add i64 %b, -3288 was chosen as the origin and if this is wanted or is there something going wrong when the candidate is created?

closing since this patch will lead to generation of invalid IR, but I'll look into this later


Builtin Feature

Should support the full list of the below:
output,
range_check,
pedersen,
ecdsa,
keccak,
bitwise,
ec_op,
poseidon,
segment_arena,


Password input focus steals key input from kwm

Steps to reproduce:

Open any browser to a page that has a password input
Focus the password input
Attempt to make ANY key bind command to kwm.

Expected Result: kwm receives and executes keybind command.
Actual Result: kwm does not receive any key press notifications.
Note: I actually think this is some security feature put in place by OS X, so feel free to close this as won't / can't fix. I just wanted to raise the issue in case there is something that can be done.

I actually think this is some security feature put in place by OS X

This is indeed the case. The only solution would probably be to intercept at an even lower level, but I don't really think this is worth the effort.


Toast Notification appears to block elements when invisible

Go to https://dev.isaacphysics.org/admin/stats as an admin or staff user.
Click 'show school data'.
Now attempt to click the first school URN in the list to view that schools user list. (If you inspect the element you will find it is the toast notification that is preventing the click event).

Fixed in ab12dea62f10f1d33eb8607c22479aed52d4e16c.


Is there any way to modify the one-line textbox to a multi-line text area?

The text input box for this component seems to be limited to a single line, so line breaks cannot be entered.
How can I modify it to a multi-line text box?

Hello, yes there is a parameter max_text_length for multiline feedback. See #9

Thank you for your reply!


[Example] Fix archive build.

It would fail due to the unused testBundlePath variable after stripping all assertions.

👍


Catalog team member2

In this milestone, I achieved the following
•	Create MusicAlbum class in a separate .rb file.
•	Create Genre class with an association to the Item class (in a separate .rb file).
•	All MusicAlbum class properties visible in the diagram should be defined and set up in the constructor method.
•	All Genre class properties visible in the diagram should be defined and set up in the constructor method.
•	Implement methods:

o	add_item method in the Genre class

	should take an instance of the Item class as an input
	should add the input item to the collection of items
	should add self as a property of the item object (by using the correct setter from the item object)

o	can_be_archived?() in the MusicAlbum class

	should override the method from the parent class

	should return true if parent's method returns true AND if on_spotify equals true

	otherwise, it should return false

•	Add unit tests for all implemented methods.
•	The following options should be available:
o	List all music albums
o	List all genres (e.g 'Comedy', 'Thriller')
o	Add a music album
•	All data should be preserved by saving collections in .json files.
•	Create a schema.sql file with tables that will be analogical to the structure of the classes that you created:
o	music_albums table (add all properties and associations from the parent Item class as table columns)
o	genres table

Kindly review


chore(package): update sqlite to version 3.0.3

:tada: This PR is included in version 2.1.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[SIS-051] Blank Library Page

Description
Create a blank Library page and a LessonPlanButton component.

Ticket #51
Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My PR title is formatted as [SIS-<issue number>] <issue name> (eg. [SIS-010] Create UI button)
[x] I have linked my issue/ticket on the project board to this PR
[x] I have sent my PR to #team-sistema-prs on Slack and requested two people to review
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation (if required)
[x] My changes generate no new warnings
[x] I have tested that my feature works as expected on Android and iOS. If you are a Windows dev, please request a Mac dev to run your branch. If it's a front-end change, I have attached screenshots of what the result looks like on both platforms.

Currently using RN 0.71 CSS flexbox gaps feature -- will likely create a different PR for upgrading RN version

Is it possible to make the heart icons more in-line with the 3 dots?

@harmitgoswami I could -- it seems like the issue is more on the SVG side though, as both are currently the same size and aligned with each other. Maybe it is possible that the exported SVGs aren't properly centered -- @yuemily24 thoughts on how this should be resolved?

@harmitgoswami fixed -- I took this picture on a simulator running 0.70 which is why they aren't distanced properly, but they are vertically aligned now

lgtm now! mb for being so 🤓

hmm is it also possible to center the sorting icon w the title header vertically as well? it looks a teensy bit off to me

hmm is it also possible to center the sorting icon w the title header vertically as well? it looks a teensy bit off to me

@ramyzhang maybe this is something we can bring up with the designer -- if we move over the button then it won't be aligned with the right side of the lesson plans :(. I'm not sure which is better, but I can slide it over if that is the preference

hmm is it also possible to center the sorting icon w the title header vertically as well? it looks a teensy bit off to me

@ramyzhang maybe this is something we can bring up with the designer -- if we move over the button then it won't be aligned with the right side of the lesson plans :(. I'm not sure which is better, but I can slide it over if that is the preference

ohhhh i meant like moving the sorting button down just a bit so it looks like it's on the same line as the title. if not yeah no worries i'll bring it up w the designers and get back to u

ohhhh i meant like moving the sorting button down just a bit so it looks like it's on the same line as the title. if not yeah no worries i'll bring it up w the designers and get back to u

This should an easy fix -- I'll check the padding for the icon right now

@ramyzhang is this centered im going insane and I can't tell

@BakerWJ LOL yes it looks perfect thank you!!!

@Lemiex pinging for reviewwww


model path and name

it says:
Following command is used to register a model created in step 1 above,
> az ml model register --model [path to model file] --name [model name]
Can you tell what [path to model file] and [model name] are expected here based on step 1? There is no path specified when dumping the model.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e9f9f665-d8f6-5cf5-bdb8-01112cffd69b
Version Independent ID: 25000f70-6f17-5d8e-3603-db051cd266a2
Content: Azure Machine Learning Model Management Web Service Deployment
Content Source: articles/machine-learning/desktop-workbench/model-management-service-deploy.md
Service: machine-learning
GitHub Login: @aashishb
Microsoft Alias: aashishb

@thisiszw Thank you for the valuable feedback,we are investigating the issue.

@thisiszw  Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.
@aashishb Hi, there is a doc-enhancement issue, can you please check it and update the document as necessary? Thanks a lot!

Adding @marthalc, who is the PM DRI this week, to help

@thisiszw this documentation doesn't have the end to end tutorial details. I would recommend looking into Iris tutorial.
To answer your question:
Path to model file: depends on where your file is stored, if you have it in the same folder you are working on, then the path would be the same as your model name. This example is assuming you are starting with a model named "mymodel.pkl"
Model Name: mymodel.pkl

@thisiszw
We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


New plugin: Add Leaflet.Mask

Hi,
Leaflet.Mask is a plugin that loads polygons from geojson to mask the rest of the map.
THX.

@ptma Have you closed this intentionally?

@ptma Have you closed this intentionally?


Virtual Machines: "Basic Metrics" API / VM Extension

👋🏻 Hey folks
I'm unsure of the correct place to file a bug for this - but I'm assuming here's as good as any, please re-route me if not and I can move this :)
We've had a request come in to support "Basic Metrics" on Virtual Machines. After looking into this I found this page of documentation which indicates that this is a VM Extension - and I've verified this assumption in the Portal by enabling it manually and viewing the exported ARM Template.
Would it be possible to confirm if this assumption is correct about it being a VM Extension?
I've converted this over to Terraform syntax, which calls the VM Extensions API - however I'm seeing the VM Extension timeout after 1.5h - even when using the values exported from the ARM Template via selecting "Automation Script" in the Portal.
I've uploaded the configuration I've pieced together - which has been translated from the "Automation Script" tab in the Portal against a machine made manually. Would its be possible to confirm if I'm missing something when configuring this VM Extension? In addition - given it's a checkbox in the portal, is this likely to be exposed via the Virtual Machine API in the future?
Thanks!

@tombuildsstuff, IaaSDiagnostics extension is for enabling diagnostics on Windows virtual machine, for Linux it is LinuxDiagnostic. See this code that shows configuring diagnostics on Linux VM https://github.com/Azure/azure-sdk-for-java/blob/master/azure-mgmt-compute/src/test/java/com/microsoft/azure/management/compute/VirtualMachineExtensionOperationsTests.java#L69.
The configuration ladCfg for linux looks like: https://github.com/Azure/azure-sdk-for-java/blob/master/azure-mgmt-compute/src/test/resources/linux_diagnostics_public_config.json

For windows, please refer the discussion here https://github.com/Azure/azure-sdk-for-java/issues/1836

Thanks for confirming @anuchandy I can confirm the Linux specific version works - I'll double-check the Windows version tomorrow
Are there any plans to combine these into a single extension? It seems odd to have multiple extensions doing the same thing?

Great to know it's working!
Regarding merging extensions, it's a question for the service team, you can open issue here https://github.com/Azure/azure-linux-extensions. The diagnostics extension for Linux is maintained here

@anuchandy I can confirm the Windows version works too - as such I'm going to close this issue for the moment.
I've opened issue #1534 about adding a field to the Compute API for Basic Metrics, to improve the UX of deploying Azure Monitoring through the API to match the Portal
Thanks!


Filename problems

Saving an image from Stories currently results in filenames such as "387190780_18389728120018662_1583554250286888030_n.jpg stp=dst-jpg_e15&efg=eyJ2ZW5jb2RlX3RhZyI6ImltYWdlX3VybGdlbi4xNDQweDgxMC5zZHIifQ&_nc_ht=scontent-lhr8-2.cdninstagram.com&_nc_cat=106&_nc_ohc=lvubGOKVFqsAX8UNvjq&edm=ALQROFkAAAAA&ccb=7-5&ig_cache_ke.jpeg".

When adding the account name to a filename, the wrong account name is used.

Can you give me a link ? I didn't reproduce the problem.

Can you give me a link ? I didn't reproduce the problem.

Or you can try the newset version (1.3.6)

I'm now unable to replicate either problem, so it could be something that IG did, or the new version fixed it!


Segfault when closing window in WSL

Subject of the issue
Segmentation fault in WSL2 when closing a window
Your environment

Your OS / distro / window manager used
Windows 11 with Ubuntu on WSL
Your version of SFML (2.5.0, git master, etc)
2.5.1 (installed through apt-get)
Your compiler and compiler version used
clang++ (Ubuntu clang version 14.0.0-1ubuntu1)
g++ (g++ (Ubuntu 11.2.0-19ubuntu1) 11.2.0)
Special compiler flags used
clang++: -fcolor-diagnostics -fansi-escape-codes
g++: None

Steps to reproduce
Just close the window with the "x" button
#include <SFML/Graphics.hpp>

int main () {
    sf::RenderWindow window(sf::VideoMode(500, 500), "Hello");
    while (window.isOpen()) {
        sf::Event event;
        while (window.pollEvent(event)) {
            if (event.type == sf::Event::Closed) {
                window.close();
            }
        }

        window.clear();
        window.display();
    }
}

Expected behavior
No segfault?
Actual behavior
segfault when window is closed. Here is the backtrace from gdb:
#0  0x00007fffebbb54ba in ?? () from /usr/lib/wsl/drivers/nv_dispi.inf_amd64_1b5e80ff87b1f5c8/libnvwgf2umx.so
#1  0x00007fffebbb38ee in ?? () from /usr/lib/wsl/drivers/nv_dispi.inf_amd64_1b5e80ff87b1f5c8/libnvwgf2umx.so
#2  0x00007fffebbb3866 in ?? () from /usr/lib/wsl/drivers/nv_dispi.inf_amd64_1b5e80ff87b1f5c8/libnvwgf2umx.so
#3  0x00007ffff7a46b43 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442
#4  0x00007ffff7ad8a00 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81

Possibly of note: The message "Setting vertical sync not supported" appears whenever I run the linux executable via WSL, so possibly a graphics driver problem in WSL?

It crashes somewhere in the graphics driver, so not much SFML can do 😅
What are you using for rendering a window from Linux in Windows?

iirc, recent graphics drivers have support for wsl out of the box. I'm currently waiting on nvidia support so I can report the segfault to them

I'm gonna close this issue since it's not an SFML issue


Problem with image message-content

When directly pasting images to sandbox, the corresponding generated img elements have src values starting with base64://, which is invalid and cannot be rendered correctly. This issue might be fixed by adding a function which replaces base64:// to data:image/png;base64 when passing url to img src.

base64: is not a valid url format and will no longer be supported by satori protocol.


Create a browser example that only relies on HTML and JavaScript

I've added a new /examples/browser/ example that only uses the Monaco converters to get the JSON language service working with a Monaco Editor. This new example does not rely on Express to serve any content via Node.js. You simply build the example with npm install and npm run build and then open up /examples/browser/lib/index.html with a browser and the Monaco Editor should be up and running with JSON support.
The original example has been moved from /example/ to /examples/nodejs/. I have also updated the README.md file to mention the new example.

@akosyakov Thanks for taking a look. I've made some tweaks and force pushed my branch.

@rcjsuen will you rebase it after merging https://github.com/TypeFox/monaco-languageclient/pull/63?

@akosyakov I've made the necessary changes and force pushed my branch.

@rcjsuen sorry, you will need to rebase it again

@akosyakov It happens. I've force pushed again.

I think we should keep the original example as it is, otherwise, all links in this article will be broken:
http://typefox.io/teaching-the-language-server-protocol-to-microsofts-monaco-editor

I see a lot of warnings from the webpack, is there a way to get rid of them? like:
WARNING in ./node_modules/vscode-json-languageservice/lib/esm/services/jsonHover.js
(Emitted value instead of an instance of Error) Cannot find SourceMap 'jsonHover.js.map': Error: Can't resolve './jsonHover.js.map' in '/workspace/monaco-languageclient/examples/browser/node_modules/vscode-json-languageservice/lib/esm/services'
 @ ./node_modules/vscode-json-languageservice/lib/esm/jsonLanguageService.js 8:0-49
 @ ./lib/client.js
 @ ./lib/main.js

WARNING in ./node_modules/vscode-json-languageservice/lib/esm/jsonLanguageService.js
(Emitted value instead of an instance of Error) Cannot find SourceMap 'jsonLanguageService.js.map': Error: Can't resolve './jsonLanguageService.js.map' in '/workspace/monaco-languageclient/examples/browser/node_modules/vscode-json-languageservice/lib/esm'
 @ ./lib/client.js 7:36-74
 @ ./lib/main.js

WARNING in ./node_modules/vscode-json-languageservice/lib/esm/parser/jsonParser.js
(Emitted value instead of an instance of Error) Cannot find SourceMap 'jsonParser.js.map': Error: Can't resolve './jsonParser.js.map' in '/workspace/monaco-languageclient/examples/browser/node_modules/vscode-json-languageservice/lib/esm/parser'
 @ ./node_modules/vscode-json-languageservice/lib/esm/jsonLanguageService.js 11:0-57
 @ ./lib/client.js
 @ ./lib/main.js

I got rid of some of them but there are still a few that eludes me at the moment.
WARNING in ./node_modules/vscode-nls/lib/main.js
207:19-66 Critical dependency: the request of a dependency is an expression
 @ ./node_modules/vscode-nls/lib/main.js
 @ ./node_modules/vscode-json-languageservice/lib/esm/services/jsonCompletion.js
 @ ./node_modules/vscode-json-languageservice/lib/esm/jsonLanguageService.js
 @ ./lib/client.js
 @ ./lib/main.js

WARNING in ./node_modules/vscode-nls/lib/main.js
220:23-52 Critical dependency: the request of a dependency is an expression
 @ ./node_modules/vscode-nls/lib/main.js
 @ ./node_modules/vscode-json-languageservice/lib/esm/services/jsonCompletion.js
 @ ./node_modules/vscode-json-languageservice/lib/esm/jsonLanguageService.js
 @ ./lib/client.js
 @ ./lib/main.js

WARNING in ./node_modules/vscode-nls/lib/main.js
221:19-72 Critical dependency: the request of a dependency is an expression
 @ ./node_modules/vscode-nls/lib/main.js
 @ ./node_modules/vscode-json-languageservice/lib/esm/services/jsonCompletion.js
 @ ./node_modules/vscode-json-languageservice/lib/esm/jsonLanguageService.js
 @ ./lib/client.js
 @ ./lib/main.js

WARNING in ./node_modules/vscode-nls/lib/main.js
310:23-41 Critical dependency: the request of a dependency is an expression
 @ ./node_modules/vscode-nls/lib/main.js
 @ ./node_modules/vscode-json-languageservice/lib/esm/services/jsonCompletion.js
 @ ./node_modules/vscode-json-languageservice/lib/esm/jsonLanguageService.js
 @ ./lib/client.js
 @ ./lib/main.js

WARNING in ./node_modules/vscode-nls/lib/main.js
394:23-53 Critical dependency: the request of a dependency is an expression
 @ ./node_modules/vscode-nls/lib/main.js
 @ ./node_modules/vscode-json-languageservice/lib/esm/services/jsonCompletion.js
 @ ./node_modules/vscode-json-languageservice/lib/esm/jsonLanguageService.js
 @ ./lib/client.js
 @ ./lib/main.js

WARNING in ./node_modules/vscode-nls/lib/main.js
57:49-88 Critical dependency: the request of a dependency is an expression
 @ ./node_modules/vscode-nls/lib/main.js
 @ ./node_modules/vscode-json-languageservice/lib/esm/services/jsonCompletion.js
 @ ./node_modules/vscode-json-languageservice/lib/esm/jsonLanguageService.js
 @ ./lib/client.js
 @ ./lib/main.js

@akosyakov I've force pushed my branch again. There shouldn't be anymore warnings.

@rcjsuen I think we should keep the original example where it was before. It is referenced from different issues and particularly in this article: http://typefox.io/teaching-the-language-server-protocol-to-microsofts-monaco-editor Moving it breaks links. Could you move examles/nodejs toexample? For new examples, we will use examples folder.
Also, it seems that rebase went wrong a bit, i have both example and examles/nodejs.

You're right, I missed some files. Sorry about that. Anyway, I'll make the changes you suggested and then push again. Thanks for reviewing!

@akosyakov I've changed it so that the Node.js example stays in example and the browser example is in examples/browser.

Thanks for the review, Anton!


Russian documentation looks outdated

Hello to all.
I can help to translate some new patterns for RU locale:  More/EAV and Structural/Flyweight
And, as I can imagine, EN documentation should be changed from Sep 8 2015 when I sent last PR with translation.
So, maybe some *.po files in RU locale is now outdated too. Can you check this?
UP: JFYI, here is broken UML image.

HI, KIVagent
I just review all changes between 2015/06/01 - 2016/06/03
And updated all po files, I hope all problems have been sloved
Here is the todo list, these patterns should be translated or re-translated, check relevant .po files

Behavioral/Memento/README.rst

More/Delegation/README.rst

More/EAV/README.rst

Structural/Flyweight/README.rst

Thanks :smile_cat:

Ok, I'll try to do this later.

@shangguokan, it seems to me that after applying this #228 RP Russian documentation is up-to-date. So this issue may be closed


Add Cookies confirmation dialog

Currently, there is no dialog for accepting or declining cookies. Add a dialog.

@jazellemaira We may need a design for this 🙏 🥺

@nsunami
We already have a design for this 😉

It becomes a pop-up on mobile because the message is too long to be a snack bar.


solid-start project can't access import.meta.env

Attempting to access import.meta.env gives a type error:    Property 'env' does not exist on type 'ImportMeta'
Per Nikhil this is an issue separate from what was fixed in #265.  There is an additional fix needed related to type exports within vinxi.
Steps to repro:
pnpm create solid
pnpm install
attempt to access import.meta.env within app.tsx

@nksaraf Any reason not to use vinxi/types/client instead of vinxi/client for now? The latter is empty and the reason it works with npm in solid-start seems to be because Ryan added vite/client to tsconfig.

Turns out the Vinxi docs and a lot of the examples use vinxi/types/client instead of vinxi/client. SS should probably be updated so that manually adding vite/client isn't necessary.

Yeah. SolidStart examples have been updated some time ago to use vinxi/types/client so this should not be a problem anymore.

I'm fine to close this - it seems that usage of vinxi/types/client has percolated through the ecosystem, and this is no longer an issue.


why you guys so powerful

hi, gowin fpga seems not open source, why you guys so powerful to generate the bitstream file? How can you do that? thanks

It's simple: you take an empty file
module top();
endmodule

generate an image with the vendor IDE, this will be your template, then you add one LUT, generate the image and compare it with the template. Change the position of the LUT and see what changed and what didn't.
Take a look at the document https://github.com/YosysHQ/apicula/blob/master/clock_experiments.ipynb
or the movies:
https://www.youtube.com/watch?v=Vt7FyOXfkZA&list=PLIYslVBAlKZad3tjr5Y4gqBV3QKQ5_tPw

Or my internship report https://github.com/pepijndevos/internshipreport/releases/download/tag-f2973b39f18d72c18a0ede2d765fb1ff8541cdeb/main.pdf


Unbreak breakpoint setting on Windows.

getMemoryRegionInfoInternal was already doing what getMemoryRegionInfo needs to do for lldb, so promoted it.
Path comparisons were failing during Handle_qFileLoadAddress because lldb was asking for paths like "C:/path/to/file.exe" while ds2 was dropping the leading "C:" leaving "/path/to/file.exe" and failing to match. This is fixed by no longer doing that.
Also switch from using strict string equality of paths to using std::filesystem::equivalent to be more robust.

@compnerd PTAL

@compnerd PTAL and see new usage of equivalent(), which seems like a win that might be applicable elsewhere, as well.

@compnerd PTAL and see new usage of equivalent(), which seems like a win that might be applicable elsewhere, as well.

Would you?  That would be an improvement even ignoring the benefits of improving the accuracy of the code.

@compnerd PTAL and see new usage of equivalent(), which seems like a win that might be applicable elsewhere, as well.

Would you? That would be an improvement even ignoring the benefits of improving the accuracy of the code.

Per off-reviewlog convo, I don't have a catalog of potential sites to update in ds2; my comment was about the ecosystem at large.


Node 4.6.0 fails

As documentation:
Buffer.from was introduced in version 6.0.0
To make the creation of Buffer objects more reliable and less error prone, the various forms of the new Buffer() constructor have been deprecated and replaced by separate Buffer.from(), Buffer.alloc(), and Buffer.allocUnsafe() methods.
This commit: #6c9118e says that you need at least 4.6.0 but Buffer.from() does not exist in 4.6.0.
This commit: #fac48d9 breaks everything if you do not update Node to at least 6.0.0
Actual error:
TypeError: this is not a typed array.
    at Function.from (native)
    at Object.<anonymous> (/server/current/node_modules/apn/lib/protocol/endpoint.js:17:31)

Node.js documentation says, it was introduced in 4.5.0, see https://nodejs.org/docs/v4.6.0/api/buffer.html#buffer_class_method_buffer_from_str_encoding
We have 100% test coverage and all tests pass on the latest version auf node 4, 5, 6 and 7.

Latest version does not mean everyone has the latest version of any Major version ...

@florianreinhart Maybe you're interested in following this ticket: https://github.com/nodejs/node/issues/10825


Add JWT Embed Target Examples

Examples showing JWT with PE claims.

I'll take this

Thanks @andresuribe87 it should be quite similar to https://github.com/decentralized-identity/credential-manifest/pull/131


Add angular skeleton

Fixes #30
There literally is nothing in the skeleton other than the index page, bower stuff for pulling in angular / bootstrap and gulp for build/test (this isn't hooked up in any way).
//cc @codeforokc/school-finder-team

:+1:


iterator: fix panic when retry policy returns IgnoreWriteError in iterator

Currently, the RowIterator expects that its background worker will always send at least one page (or an error) to the iterator. However, there is an edge case where it may not be true: if the first request executed via query_iter/execute_iter fails and the retry policy returns an IgnoreWriteError decision (currently returned only by downgrading consistency policy in case of WriteTimeout). In such case, those methods will trigger a panic.
This PR fixes this issue by sending a dummy, empty page to the iterator in the aforementioned case. Moreover, in order to make it less possible for such bugs to appear in this area of the code in the future, the RowIterator::work function is now forced to return an object which serves as a proof of the fact that it sent (or at least attempted to send) at least one page or error to the RowIterator.
Fixes: #608

[x] I have split my patch into logically separate commits.
[x] All commit messages clearly explain what they change and why.
[x] I added relevant tests for new features and bug fixes.
[x] All commits compile, pass static checks and pass test.
[x] PR description sums up the changes and reasons why they should be introduced.
[x] I added appropriate Fixes: annotations to PR description.

@cvybhu review ping


[Enhancement] Make the 'cluster' in task info for LoadStmt not empty

Search before asking

[X] I had searched in the issues and found no similar issues.

Description
Produce a S3 load, and run show load stmt. As seen, cluster is always N/A:
         JobId: 10131
         Label: lineitem_load
         State: LOADING
      Progress: ETL:100%; LOAD:77%
          Type: BROKER
       EtlInfo: NULL
      TaskInfo: cluster:N/A; timeout(s):14400; max_filter_ratio:0.0
      ErrorMsg: NULL
    CreateTime: 2023-04-29 12:23:29
  EtlStartTime: 2023-04-29 12:23:30
 EtlFinishTime: 2023-04-29 12:23:30
 LoadStartTime: 2023-04-29 12:23:30
LoadFinishTime: NULL
           URL: NULL
    JobDetails: {"Unfinished backends":{"de827555cbb2413d-a720be8937596b35":[10021]},"ScannedRows":36165536,"TaskNumber":1,"LoadBytes":6140395389,"All backends":{"de827555cbb2413d-a720be8937596b35":[10021]},"FileNumber":1,"FileSize":7895697364}
 TransactionId: 3
  ErrorTablets: {}
          User: root
       Comment:

Solution
Actually, the getCluster method in LoadStmt, as the only access to the passed in cluster, is never called.
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

plz assign to me, thk!

@TangSiyang2001 As you said there is no place to call the cluster method. Do we set a default value for it without "N/A", or just only use the BY cluster value. Looking forward to your advice

@TangSiyang2001 As you said there is no place to call the cluster method. Do we set a default value for it without "N/A", or just only use the BY cluster value. Looking forward to your advice

I think we can use By Cluster value if it is set, otherwise use a default val like "default_cluster".

@TangSiyang2001 As you said there is no place to call the cluster method. Do we set a default value for it without "N/A", or just only use the BY cluster value. Looking forward to your advice

See in #19392 .


fix: push on quay also for tags

📝 Description
push on quay.io image referring any created tag

/retest

/lgtm


problem with bluetooth_tracker

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version): 0.23.0.dev
Python release (python3 --version): 3.4 on Windows 10
Component/platform: Bluetooth_tracker
Description of problem:
When I load the bluetooth_tracker, I get this error when initializing:
16-06-20 16:31:34 homeassistant.components.device_tracker: Error setting up platform bluetooth_tracker
Traceback (most recent call last):
  File "C:\python3\lib\site-packages\homeassistant-0.23.0.dev0-py3.4.egg\homeassistant\components\device_tracker\__init__.py", line 133, in setup_platform
    if not platform.setup_scanner(hass, p_config, tracker.see):
  File "C:\python3\lib\site-packages\homeassistant-0.23.0.dev0-py3.4.egg\homeassistant\components\device_tracker\bluetooth_tracker.py", line 61, in setup_scanner
    for dev in discover_devices():
  File "C:\python3\lib\site-packages\homeassistant-0.23.0.dev0-py3.4.egg\homeassistant\components\device_tracker\bluetooth_tracker.py", line 37, in discover_devices
    lookup_class=False)
  File "C:\python3\lib\site-packages\bluetooth\msbt.py", line 15, in discover_devices
    devices = bt.discover_devices(duration=duration, flush_cache=flush_cache)
OSError: Niet meer gegevens beschikbaar.

Expected:
Problem-relevant configuration.yaml entries and steps to reproduce:

Traceback (if applicable):

Additional info:

OSError: Niet meer gegevens beschikbaar.

Very nice to provide error messages in @balloob's native tongue (I hope that I'm not wrong here...perhaps it's not Dutch but Flemish). :smile:

Flemish isn't a real language, we both speak Dutch, you should Flemish more as a dialect of Dutch ?

Is it a permission error?
On Tue, Jun 21, 2016, 05:57 Bart274<EMAIL_ADDRESS>wrote:

Flemish isn't a real language, we both speak Dutch, you should Flemish
more as a dialect of Dutch ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/issues/2338#issuecomment-227430850,
or mute the thread
https://github.com/notifications/unsubscribe/ABYJ2q6NYDKnINdWSBb80XwsTS-m4Ht6ks5qN99ygaJpZM4I5xGD
.

I don't think so :(

Multiple things accessing  Bluetooth?
On Tue, Jun 21, 2016, 08:23 Bart274<EMAIL_ADDRESS>wrote:

I don't think so :(
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/issues/2338#issuecomment-227475257,
or mute the thread
https://github.com/notifications/unsubscribe/ABYJ2oCIY33xbDslK3H8rj5S89Azl5Wxks5qOAHigaJpZM4I5xGD
.

No, nothing uses that bluetooth on that computer...

Has this been resolved?