Review the existing guidance in light of the legislative changes

What
Review the accessibility guidance with regards to the new legislative changes.
Why
To ensure our guidance aligns with this change.
Done when

[ ] Guidance reviewed
[ ] Any updates required are recorded

Covered by this issue


Suggestion: BiS Legendary items should be 1000 ilevel

Where a Legendary is chosen as BiS could we please always see the 1000 ilevel version? Otherwise it doesn’t look like the slot is filled simply because my equipped item is > ilevel than the original item when it dropped.

Working on this. Trying to find out where in the code the item link is created so I can apply the correct bonusId.


Notice: Undefined index: settings

Issue description:
All of a sudden start receiving four notices at the top of every page.
The notices display the text:
Notice: Undefined index: settings in /home/mark8395/public_html/wp-content/plugins/kirki/core/class-kirki-field.php on line 232
Not sure if it's just happening to me and if there is any known way to fix.
Version used:
3.0.20 not tried with develop branch yet I will update post if I see any changes.
Tried with develop branch and it's trowing even more errors:
Notice: Kirki_Field::__construct è stato richiamato in maniera scorretta. Typo found in field - setting instead of settings. Leggi Debugging in WordPress per maggiori informazioni. (Questo messaggio è stato aggiunto nella versione 3.0.10.) in /home/mark8395/public_html/wp-includes/functions.php on line 4146
Using theme_mods or options?
Mix of both  for different things, 99% are theme mods
Code to reproduce the issue (config + field(s))
N/A
I restored from yesterday's backup and everything works fine, not sure if I should try to re-apply the update or wait

I'm guessing you were previously using a pretty old version...
In v3.0 some warnings were added in case we detect the developer is doing some things wrong. Older versions just automatically corrected the issues and didn't provide any feedback. What changed recently is the added warnings. It looks like you're using setting instead of settings. It has always been settings and that's what we have in the docs everywhere since we just follow the WP API on that part. Accepting setting was something we just added because a lot of people were doing that - either on purpose or just a typo. The warning added in v3+ just lets you know if you're using something like that... Your controls will still work, but it's just something you should fix and rename setting to settings in all your fields as they should be.
Let me know if that fixes your issue! 👍

Hi Aristath,
Thanks a lot for your reply.
Actually I was using the latest version and I have 'settings' everywhere a part from the active callbacks where I use:
'active_callback'  => array( 		array( 			'setting'  => 'xxx_panels_show_date', 			'operator' => '==', 			'value'    => '1', 		), 	),
I have actually found out what was causing the problem even if I am not sure of why.
The notices started to appear at the exact time when some modification where applied (by some 3rd party support staff, without letting me know) to my config.php file in order to extend the max execution time.
I restored from yesterday's backup and updated to the latest version and everything seems fine now.
Sorry to have bothered you.

hmmmm, that's weird...
use of setting in active_callback is ok.
Changint the max_execution time should not have any impact on Kirki. to be honest this is a bit of a puzzle. At least it's ok for you now... If however this happens again then please let me know so that we can further investigate!!

Thank you very much for your kind reply again Aristath.
I am a little bit confused too for the relation between the wp-config changes and the notices but unfortunately it is the only plausible explanation since no other modifications were applied and reverting back to just before the changes were made fixed the problem.
If you are interested I could privately send you the exact code that was applied to my config file but I would prefer not to put it on github because it would disclose the name of the company providing the support and I don't think it would be correct to associate them with an error since they were just trying to help.


TypeError: Cannot read properties of undefined (reading 'set')

(node:539) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 ready listeners added to [Client]. Use emitter.setMaxListeners() to increase limit
(Use node --trace-warnings ... to show where the warning was created)
(node:539) DeprecationWarning: MessageEmbed#addField is deprecated and will be removed in the next major update. Use MessageEmbed#addFields instead.
TypeError: Cannot read properties of undefined (reading 'set')
at Object.execute (/home/runner/ticket-bot/handlers/commands/commands.js:16:29)
at Client. (/home/runner/ticket-bot/bot.js:71:54)
at Client.emit (node:events:525:35)
at WebSocketManager.triggerClientReady (/home/runner/ticket-bot/node_modules/discord.js/src/client/websocket/WebSocketManager.js:387:17)
at WebSocketManager.checkShardsReady (/home/runner/ticket-bot/node_modules/discord.js/src/client/websocket/WebSocketManager.js:370:10)
at WebSocketShard. (/home/runner/ticket-bot/node_modules/discord.js/src/client/websocket/WebSocketManager.js:200:16)
at WebSocketShard.emit (node:events:513:28)
at WebSocketShard.checkReady (/home/runner/ticket-bot/node_modules/discord.js/src/client/websocket/WebSocketShard.js:181:12)
at module.exports [as READY] (/home/runner/ticket-bot/node_modules/discord.js/src/client/websocket/handlers/READY.js:26:9)
at WebSocketManager.handlePacket (/home/runner/ticket-bot/node_modules/discord.js/src/client/websocket/WebSocketManager.js:354:31)

It seems like that you have some problems with the slash commands. Make sure 2 things!

Not to use same command names for both slash and message commands
Make sure you have a valid slash command configuration.

i've checked im just used  your full src jus edited config files but im getting this error idk that becoz im using win to run the bot

I'll fix it in next update.

happens to me as well... just launched the bot and i cant use anything. i suggest to fix this and give some tutorial on this bot its very complicated and no understanding exactcly what each thing does and how it works

Yes this code is not friendly to edit and use. Just let me know what all the features you are expecting here or I'll just simplify the ticket bot code alone


Video Demonstration for all Ros2 Tutorials

Concept

For all the tutorials we must have a video at the bottom of the page that show
how you can perform the above tutorial.
Previous Experience

I saw a lot of beginners show resistance to linux/terminal . I posted a video  in ROS1 Noetic Nodes tutorial  , People really loved it and even reached out to me to produce more .
Process

It would be great for starters to have a video to follow by utilizing contents of written tutorials + some additional explanation .
Who will do it ?

I can do it , I mean i will be really happy to give back to ROS2 for what good it has brought in to my career.
If any one would like to join in -> I  will be great full .

@clalancette  here take a look into this video -> youtube_video

Let me know about it . Currently it is unlisted

Your welcome


Enables running NUnit2 tests from dotnet cli

Enables running NUnit2 tests from VS 2019 and dotnet cli
Upgrades the minimum NUnit2 version to v2.7.1
Adds reference to NUnitV2.Core package
Removes References directory

@aivascu  BTW, I just noticed that we violated SemVer in this PR. We changed the supported NUnit version. It’s not allowed, as this update could potentially break some environments.
I would want us to be very strict about it and change it in major updates only.

@zvirja I didn't make a release yet.
I can revert the changes and reopen the PR for the v5 branch.

I would suggest that to play safe, unless you have strong opinion against it. Sorry for the inconvenience 😕


LAPAR paper

Hi,
Could you please share the link to the pdf file of LAPAR paper?
Thanks!

Thanks for your interest. I will release it in a few weeks.


Remove validate decorator related documentation

Fixes issue #705
Signed-off-by: Aayush Kasurde<EMAIL_ADDRESS>

Merging in this PR and updating http://bottlepy.org/docs/dev/tutorial_app.html would be really appreciated!  Thanks!


Change property hint range for camera attributes exposure multiplier

The current range hint max of 2048 is just absurd too high. In the default scene, an exposure multiplier of about 50 blows up to a completely white screen. I was watching somebody try out Godot 4.1 on a Discord stream when they changed this value and were surprised that most of the slider was completely useless.
This PR changes the range hint to have a max of 8, but also adds or_greater so any value can still be typed in.

Thanks!

Cherry-picked for 4.1.2.


Fix missing typed_ast when using python 3.7.

Closes https://github.com/microsoft/vscode-black-formatter/issues/114

@paulacamargo25 Can you review this PR please, the code here might be something that can be re-used in the debugger package.


The cli-plugin-eslint need upgrade babel-eslint to ^10 and eslint to ^5

Version
3.0.5
Node and OS info
node v8.10.0 / yarn 1.9.4 / macos 10.12.6
Steps to reproduce
when using nullish-coalescing-operator in code, vue-cli-service lint throw error because of eslint
this.empty2 ?? 'empty2'

What is expected?
Expected eslint run ok
What is actually happening?
Error: unreachable
at CodePathState.popChoiceContext (/Users/luxueyan/bitmain/data-tag-frontend/node_modules/@vue/cli-plugin-eslint/node_modules/eslint/lib/code-path-analysis/code-path-state.js:444:23)
at processCodePathToExit (/Users/luxueyan/bitmain/data-tag-frontend/node_modules/@vue/cli-plugin-eslint/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:434:19)

Upgrade eslint (babel-eslint) version is ok

I'm not aware of this operator, can you link to some info? google didn't help.

https://babeljs.io/docs/en/babel-plugin-proposal-nullish-coalescing-operator

...and you have added that proposal to your babel config?

Yes! But it  throws error yet. When I update the eslint and babel-elint to latest in the cli-plugin-eslint package, it works!


Feature/909 proxy delegatecall

Description
The intention of this PR is to validate if an address is a contract or EOA before calling the delegatecall
Tested
Test added in proxy.ts calling _setAndInitializeImplementation with a EOA address.
Other changes
The isContract function shouldn't be called from a constructor. Calling this function from a constructor will return 0 independently if the address given as parameter is a contract or EOA
Related issues
Fixes #909 , #910, #911
Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.

Hmm, looks like the end-to-end tests still did not run. @aaitor maybe you need to merge in master to pick up https://github.com/celo-org/celo-monorepo/pull/1255?


Release v0.28.0

Consolidate usage of named sorting (#736).
Remove redundant retries for token refreshes as they're already handled in httpclient (#729).
Skip auth, config loading, and rate limits when fixture transport is present in the config (#739).
Generate SDK to latest OpenAPI specification with bugfix (#742).

API Changes:

Added AzureWorkspaceInfo field for provisioning.Workspace.
Added provisioning.AzureWorkspaceInfo.
Changed UpdateConfig method for w.ServingEndpoints workspace-level service with new required argument order.
Changed ServedEntities field for serving.EndpointCoreConfigInput to no longer be required.
Changed Create method for a.AccountIpAccessLists account-level service with new required argument order.
Changed Replace method for a.AccountIpAccessLists account-level service with new required argument order.
Changed Update method for a.AccountIpAccessLists account-level service with new required argument order.
Changed Create method for w.IpAccessLists workspace-level service with new required argument order.
Changed Replace method for w.IpAccessLists workspace-level service with new required argument order.
Changed Update method for w.IpAccessLists workspace-level service with new required argument order.
Changed IpAddresses field for settings.CreateIpAccessList to no longer be required.
Changed IpAddresses field for settings.ReplaceIpAccessList to no longer be required.
Removed ListId field for settings.ReplaceIpAccessList.
Changed Enabled field for settings.UpdateIpAccessList to no longer be required.
Changed IpAddresses field for settings.UpdateIpAccessList to no longer be required.
Changed Label field for settings.UpdateIpAccessList to no longer be required.
Removed ListId field for settings.UpdateIpAccessList.
Changed ListType field for settings.UpdateIpAccessList to no longer be required.

OpenAPI SHA: d3853c8dee5806d04da2ae8910f273ffb35719a5, Date: 2023-12-14

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3741ed8) 17.87% compared to head (fa3f9d0) 17.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #745   +/-   ##
=======================================
  Coverage   17.87%   17.87%
=======================================
  Files         103      103
  Lines       14159    14159
=======================================
  Hits         2531     2531
  Misses      11422    11422
  Partials      206      206

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Nightly passed on previous commit, the changes here are CHANGELOG updates so not running nightly before releasing.


Update CSS and JS

Ensure all CSS and JS CDN files in template/header  are latest version.

Still some header scripts that need updated, e.g. Bootstrap and Swiper,

Updated and Wwiper scripts moved to homeview


I would like to know, how can I use the filter in RtpService.kt?

Good evening, first I want to thank you for the project.
I would like to know, how can I use the filter in RtpService.kt?

Closing as inactive.


add some socket functions and a SOCKET type for windows

This PR adds a few of the socket functions for windows. Some targets use the stdcall calling convention for these functions, so I put them in an extern "system" block (see the nomicon).

r? @gnzlbg
(rust_highfive has picked a reviewer for you, use r? to override)

@gnzlbg I would like a review of this code!  Feedback welcome.
It's unclear to me why this nightly linux build is failing. There is another PR that is failing for what seems to be similar reasons.

@bors: r+
Thanks!

:pushpin: Commit b9d86a6e8aad5710f3f05b0a0d107346d364a1e6 has been approved by alexcrichton

:hourglass: Testing commit b9d86a6e8aad5710f3f05b0a0d107346d364a1e6 with merge aa36e1b3e29641efe03a656bff433eb81d4c3a91...

:broken_heart: Test failed - status-travis

FWIW the failures are spurious, i've reported them to the docs team yesterday, but with christmas going on, progress is slow. I'll try to review this by the end of the week.

@gnzlbg no worries. Happy holidays!

@bors: retry
Different spurious failure this time though!

:hourglass: Testing commit b9d86a6e8aad5710f3f05b0a0d107346d364a1e6 with merge 26ffb5c10aeb2b9e60ab19972e3e64ebd8be74e1...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 26ffb5c10aeb2b9e60ab19972e3e64ebd8be74e1 to master...

Weren't these removed a long time ago from libc due to them being not part of the CRT and just normal windows system library stuff?

These definitions are not part of the UCRT though!

Well, this is even more awkward now that 0.2.46 was published with this change.
@alexcrichton What is the official word on this? Is libc expanding in scope to cover things that are not in the CRT, or was this just an oversight that warrants a yank + revert + publish?

Thanks @retep998 for pointing out. I misunderstood that this was a requirement (my bad! 😢 ).
RFC 1291 says this about libc on windows:

This library is currently intended to be distinct from the winapi crate as well as bindings to common system DLLs found on Windows, so the current scope of libc will be pared back to just what the CRT contains.

We can probably just avoid new bindings in the future, this isn't really worth a revert I think.


Date

Would it be possible to add a date option? Although that is not consistent with APA 7 format, it's really useful for distinguishing different versions of preprints.

Where would you want the date to appear?

I would put it centered below the affiliations and above the author note, in the format of "November 1, 2024".

I have added a draft-date option to the example.qmd file. If false, it does nothing. If true, it will return today's date. If it is text, it will return the text (e.g., a date other than today).
The feature works in docx, html, and typst, but not pdf. The pdf version is not entirely under my control. It is formatted primarily by the apa7 LaTeX package, and it adheres to APA 7 style very strictly. We might be able to trick the apa7 package into inserting the date elsewhere (e.g., below the author note or after the keywords),
I will not document the feature until I know that the implementation is what you had in mind. Let me know.

That's perfect, thank you!
For the PDF, would the "Note" field be a good placement option (displaying above the "Authornote")? That's where I put it when I used Rmarkdown and the papaja package. But I don't know if apaquarto already uses that field.


Add docker image with publishing

Fixes

https://github.com/davegallant/docker-groovy-lint/issues/2

Proposed Changes

Add Dockerfile
Add Docker Hub publishing via github actions

Notes
These changes would require:

secrets added to this repository (secrets.DOCKER_USERNAME and secrets.DOCKER_PASSWORD)
github actions (local and third party actions) enabled on the repository

As it stands now, the image would be published under: https://hub.docker.com/r/nvuillam
Docker publishing with github actions tested here: https://hub.docker.com/layers/davegallant/npm-groovy-lint-test/5.4.0/images/sha256-f5c98b40cb83955893da8b43c69bd9357947000da18cdb8690d78e00c2653cf8?context=explore

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   93.19%   93.19%
=======================================
  Files          73       73
  Lines        1895     1895
=======================================
  Hits         1766     1766
  Misses        129      129

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b40d374...72f74c0. Read the comment docs.

I see this PR is still draft, are you waiting from me just to add docker hub credentials, or do you need to make other updates ?

I see this PR is still draft, are you waiting from me just to add docker hub credentials, or do you need to make other updates ?

Credentials are needed. The rest should work as expected.

any tip about where I can put that ? I'm used to Jenkins & CircleCI but new to GH Actions :)

found it, nevermind ^^

Merged, + updated ... the image seems to be correctly built, I've not tested it, plz tell me if there is any issue :)
Many thanks for your contribution :) :)


Auto Suggestions Does not work

Visual Studio code does not give any suggestions after the update.
I reinstalled vscode, it worked perfectly fine. But late after reopening , it went back to the old state.

/needsMoreInfo
What language are you using? Do you see any notifications or error messages?


Update free-courses-hi.md

What does this PR do?
Adding blockchain course from Youtube
For resources
https://www.youtube.com/watch?v=ERAxd8gl1Eg&t=12378s&ab_channel=HarkiratSingh
Why is this valuable (or not)?
This is latest video on blockchain and helps a lot for learning blockchain from a expert.
How do we know it's really free?
Yes , It absolutely free  .
For book lists, is it a book? For course lists, is it a course? etc.
It is a course based on blockchain .
Checklist:

[✔ ] Read our contributing guidelines.
[ ✔] Search for duplicates.
[✔ ] Include author(s) and platform where appropriate.
[ ✔] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[ ✔] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

you should really start with a fresh branch


Don't return to the beginning of the rows after reviewing non-matches in a reconciled column

Is your feature request related to a problem or area of OpenRefine? Please describe.
It's frustrating to have a project with thousands of rows that I need to reconcile and not being able to navigate it easily.
Describe the solution you'd like
When going through a reconciled column to look at suggestions for non-matches, if I select Match this item to this and all identical cells I get returned to the start of the rows. Then I have to page through to get back where I was. Selecting Match this item to this cell leaves me where I am. I'd like this functionality for the other option as well.
Describe alternatives you've considered
I'm also submitting an issue to have the ability to better navigate thousands of rows/records.
Additional context
My current project. If I choose to match all 5 at once, I get returned to row 1.

Hi! Thanks for the report. I agree this behaviour is annoying. See #33 for possible workarounds.

Closing as duplicate of #33.  We'll add notes on possible new "Reconcile Mode" to #33


Add transaction record map

@fluidvanadium 's original hack was to add a native type that could have a foreign trait zcash_client_backend::data_api::InputSource implemented on it.
I've used a wrapper pattern with Deref and DerefMut implementations to all the "current" interface to be extended with the new interface (InputSource) while staying back compatible with the existing usage patterns.
This PR also pulls in the implementation of InputSource on TransactionRecordMap (I kept the same name as @fluidvanadium for the wrapper.)

For the record all of the significant work in this PR was @fluidvanadium 's, I just cleaned it a little.

OK, I stand by my original argument.  This type is added to provided an implementer for a foreign trait.
I vote we add this to dev, and I can hack on adding the functionality necessary to add the trait as a subsequent separate PR.


[IO] Add warning in torchvision.io if seeking for a pts out of the video. Silent error otherwise

PR w.r.t. this issue: https://github.com/pytorch/vision/issues/2460

Thanks for the PR @JuanFMontesinos. The linter is failing with
./torchvision/io/video.py:155:76: E225 missing whitespace around operator
./torchvision/io/video.py:156:18: E225 missing whitespace around operator
./torchvision/io/video.py:156:54: E202 whitespace before ')'
./test/test_io.py:186:5: E301 expected 1 blank line, found 0
./test/test_io.py:192:5: E301 expected 1 blank line, found 0

Could you address this?


Use msgctxt to disambiguate Poedit's own _() strings

This is a follow-up for the discussion in:
https://crowdin.com/translate/poedit/3/en-he#1311
Some strings can have double meaning*, and in some languages (Hebrew included) translating them in one way won't be accurate for other instances of the same string.
*Not necessarily. Strings can be translated differently while having the same meaning, but having different translation for the same string may be needed for other purposes. See the explanation in the link above for an example.

Quoting:

I see there's only one occurrence of this string here, but it's being used more than once in Poedit.
Can you please add another "Save" entry for translation? One for the main UI ribbon and another one for all the others.
The reason I'm asking this is because the "Save changes" dialog has 3 buttons, including "Save" and "Don't save" which are opposites to each other, and translating both of them in a consistent way makes the "Save" translation in the main UI look inconsistent with the rest of the strings in the same ribbon. Hope that makes sense.
@vslavik I was afraid you'd ask me to get into details :(
In hebrew, there are differences in how you write (and say) verbs for male and female. Most hebrew translators, including myself, prefer to translate verbs (and sentences) as "genderlessly" as possible, when possible. So in this case instead of "שמור", we use the general form of the verb (שמירה) that can be used for both male and female (same for "Open"- פתיחה instead of פתח, "Update"- עדכון instead of עדכן and so on).
The downside of it is that you can't say something like "don't שמירה" (as in "Don't save" button in the "Save changes" dialog), so I have to revert back to "שמור", which means I'm either way breaking the consistency of the other translations in the same section.

Isn't this solved by using contexts? https://www.gnu.org/software/gettext/manual/html_node/Contexts.html

(requires msgctxt support in wx)

(requires msgctxt support in wx)

Unblocked by https://github.com/wxWidgets/wxWidgets/pull/530


http2Client.notifyError

What did you do?
GETTING STARTED
What did you expect to see?
configuring prometheus to monitor itself
What did you see instead? Under which circumstances?
2017/11/21 11:33:04 transport: http2Client.notifyError got notified thatthe client transport was broken EOF.
2017/11/21 11:33:04 transport: http2Client.notifyError got notified thatthe client transport was broken EOF.
2017/11/21 11:33:04 transport: http2Client.notifyError got notified thatthe client transport was broken EOF.
2017/11/21 11:33:05 transport: http2Client.notifyError got notified thatthe client transport was broken EOF.
2017/11/21 11:33:05 transport: http2Client.notifyError got notified thatthe client transport was broken EOF.
Environment
Mac OsX

System information:

Darwin 16.7.0 x86_64

Prometheus version:
prometheus, version 2.0.0 (branch: HEAD, revision: 0a74f98628a0463dddc90528220c94de5032d1a0)
build user:       root@615b82cb36b6
build date:       20171108-07:15:39
go version:       go1.9.2

Alertmanager version:
insert output of alertmanager --version here (if relevant to the issue)

Prometheus configuration file:

# my global config
global:
  scrape_interval:     15s # Set the scrape interval to every 15 seconds. Default is every 1 minute.
  evaluation_interval: 15s # Evaluate rules every 15 seconds. The default is every 1 minute.
  # scrape_timeout is set to the global default (10s).

# Alertmanager configuration
alerting:
  alertmanagers:
  - static_configs:
    - targets:
      # - alertmanager:9093

# Load rules once and periodically evaluate them according to the global 'evaluation_interval'.
rule_files:
  # - "first_rules.yml"
  # - "second_rules.yml"

# A scrape configuration containing exactly one endpoint to scrape:
# Here it's Prometheus itself.
scrape_configs:
  # The job name is added as a label `job=<job_name>` to any timeseries scraped from this config.
  - job_name: 'prometheus'

    # metrics_path defaults to '/metrics'
    # scheme defaults to 'http'.

    static_configs:
      - targets: ['localhost:9090']

Alertmanager configuration file:

insert configuration here (if relevant to the issue)

Logs:

level=info ts=2017-11-21T03:33:04.480720551Z caller=main.go:215 msg="Starting Prometheus" version="(version=2.0.0, branch=HEAD, revision=0a74f9862
8a0463dddc90528220c94de5032d1a0)"level=info ts=2017-11-21T03:33:04.480796657Z caller=main.go:216 build_con
text="(go=go1.9.2, user=root@615b82cb36b6, date=20171108-07:15:39)"level=info ts=2017-11-21T03:33:04.480827863Z caller=main.go:217 host_deta
ils=(darwin)level=info ts=2017-11-21T03:33:04.482914403Z caller=main.go:314 msg="Star
ting TSDB"level=info ts=2017-11-21T03:33:04.482961351Z caller=web.go:380 component=
web msg="Start listening for connections" address=<IP_ADDRESS>:9090level=info ts=2017-11-21T03:33:04.482954596Z caller=targetmanager.go:71 c
omponent="target manager" msg="Starting target manager..."
level=info ts=2017-11-21T03:33:04.494202679Z caller=main.go:326 msg="TSDB started"
level=info ts=2017-11-21T03:33:04.494246169Z caller=main.go:394 msg="Loading configuration file" filename=prometheus.yml
level=info ts=2017-11-21T03:33:04.496043133Z caller=main.go:371 msg="Server is ready to receive requests."
2017/11/21 11:33:04 transport: http2Client.notifyError got notified thatthe client transport was broken EOF.
2017/11/21 11:33:04 transport: http2Client.notifyError got notified thatthe client transport was broken EOF.
2017/11/21 11:33:04 transport: http2Client.notifyError got notified thatthe client transport was broken EOF.
2017/11/21 11:33:05 transport: http2Client.notifyError got notified thatthe client transport was broken EOF.
2017/11/21 11:33:05 transport: http2Client.notifyError got notified thatthe client transport was broken EOF.

Do you have any weird network setup? Such as say a firewall in the way of Prometheus talking to itself?

I can link the network，I'm starting with docker now ==

@Luncher check http_proxy and https_proxy environment variables, I met the same problem and it turned out to be these variables.

Sounds like a network issue on the user's end.

@Luncher Could you please let me know what was the problem with http_proxy setting?
I have them in place but I still get the same error.
Thanks!

@nani2say The problem, for me, was the presence of the http_proxy environment variable. To get around the issue, I set no_proxy=**<IP_ADDRESS>**,<IP_ADDRESS>,localhost

@acheaito - Thanks for letting me know. Did you replace http_proxy with no_proxy ?
I am asking because I don't want to loose the benefit of http_proxy in my environment. may be a stupid question but I would appreciate your response.
Thanks!

@nani2say - no_proxy works together with http_proxy. It's a mechanism for specifying hosts that the system should not use the proxy for. Connections to all other hosts still goes through the proxy.

@acheaito that makes sense. Thank you!

no_proxy didnt work for me. Worked for me by switching to <IP_ADDRESS> as the web listen address. Suspecting something to do with ipv6 as well - the error is pretty arbitrary though.


Move connection setup logic for JDBCIO WriteFn to @startBundle to lim…

…it parallel calls to datasource.getConnection()
Please add a meaningful description for your change here

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

run beam_performanceTests_jdbc

Run Java JdbcIO Performance Test

Run Java JdbcIO Performance Test

Run Java JdbcIO Performance Test

Run Java JdbcIO Performance Test

Run Java JdbcIO Performance Test

Run Java JdbcIO Performance Test

Run Java JdbcIO Performance Test

Run Java JdbcIO Performance Test

r: @Abacn

I see,the cause is that the test did not retry create table. Can we utilize the backoff pattern here? https://github.com/apache/beam/blob/840d66a15020b5cf19c27784cb88c31b07979532/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java#L2345

Run Java JdbcIO Performance Test

Seems like org.postgresql.util.PSQLException is not caught by the catch (SQLException) https://ci-beam.apache.org/job/beam_PerformanceTests_JDBC/7101/console however PSQLException extends SQLException. Not sure why

The try-with-resource statement does not catch the exception thrown in the parenthesis, I think. Replace to the simple try { getConnection } would work.

it appears that it should catch the exception: https://stackoverflow.com/questions/15895227/try-with-resources-must-i-throw-or-catch-the-close-methods-exceptions

Run Java Precommit

Run Java PreCommit

@Abacn can you take another look at this?


Implement callvirt opcode correctly

Currently, the WebAssembly importer treats call and callvirt identically, but there are two important differences:

callvirt should check the this parameter and throw a NullReferenceException if it's null (or trap if exception handling doesn't work yet).
callvirt should dispatch virtual methods. The runtime includes some of the dispatch logic, but some probably needs to be handled in codegen as well.

callvirt should be handled in:
https://github.com/dotnet/corert/blob/e6d0a9398e3d8fc83d047cccda302ed13610f190/src/ILCompiler.WebAssembly/src/CodeGen/ILToWebAssemblyImporter.cs#L528
Depends on #4505 since this involves calls into the runtime.

@davidwrighton, @hippiehunter has made progress on slot-based dispatch at https://github.com/hippiehunter/corert/commit/7d041087d4863bdde2da1358aca7db8a37d6fb80 , but he had to modify object writing to make it work. Would you mind taking a look and filling in the blanks about how slot-based dispatch is supposed to use the data we have from the object writer?

The logic in the ObjectEmitter which handles references to virtual methods and sets values for the getslot variables is quite questionable.

Virtual methods can exist as symbol references in several ways.

From a VTable
In multiple entries in a single vtable (Unusual, but possible. See handling for MethodImpl metadata)
Directly called (a call instruction on a virtual method can point directly at a method
In a jump stub or other such item
In reflection tables

Thus, generating these getslot global values is a bit odd. as they may not be properly useful.
Also abstract methods are callable, but don't have WebAssemblyMethodCodeNode

The more correct solution is to convince the compiler to know exactly what the offsets are with code that is aware of vtable layout, not a modification of general symbol references which may be inaccurate.
There are 3 possible approaches:

Know exactly what the vtable offsets are before generating code

Done by either always emitting full vtables, or by running some sort of scanner that predicts the behaviors of the code generator closely enough to predict vtable shape. (This is what we do now in CoreRT compilation)

Run all virtual calls through helper functions generated in the graph

If you look at how the ReadyToRun stubs worked in the not too distant past for virtual calls, this is how they were done.

Have the code reference some global variable that is updated as the vtable shape becomes known

I believe this is the approach you are taking. However, where you identify the real vtable layout is a bad place to do so as it is inaccurate due to the existence of multiple ways that the method could be referenced.

Given the constraints and capabilities of the LLVM code generator, I believe your approach is generally the correct way to implement, but you are getting the vtable layout incorrectly.
What you should do:
Instead of generating the getslot variable data during symbol reference emission, you should explicitly generate getslot data after expanding the dependency graph, but before telling LLVM to actually generate webasssembly. I believe that you should generate the getslot variables for all entries of an EEType directly in the WebAssemblyObjectWriter as the code emits the EEType. For instance, in EmitObject, after the call to ShouldSkipEmittingObjectNode, check to see if the node is an EEType node, and if so, emit the slot info for each entry in the vtable.
Do something like...
if (node is EETypeNode)
{
TypeDesc t = ((EETypeNode)node).Type;
int iSlot = GetVTableSlotsCount(factory, t.BaseType);
foreach (MethodDesc m in factory.VTable(t).Slots)
{
// set _getslot variable to sizeof(EEType) + iSlot * pointer size
iSlot++;
}
}
int GetVTableSlotsCount(NodeFactory factory, TypeDesc type)
{
if (type == null) return 0;
int slotsOnCurrentType = factory.VTable(type).Slots.Count;
return slotsOnCurrentType + GetVTableSlotsCount(factory, type.BaseType);
}

I've tried your suggestion before and after removing the offset change for __SYMBOL -> __REALBASE below is what I've found without making any offset changes to __SYMBOL
//(__EEType_HelloWasm_TestDerivedClass___REALBASE + 12 bytes)
@__EEType_HelloWasm_TestDerivedClass___SYMBOL = internal constant i32* bitcast (i8* getelementptr (i8, i8* bitcast ([13 x i32*]* @__EEType_HelloWasm_TestDerivedClass___REALBASE to i8*), i32 12) to i32*)

@__EEType_HelloWasm_TestDerivedClass___REALBASE = global [13 x i32*]
[
 i32* bitcast (i8* getelementptr (i8, i8* null, i32 -8) to i32*),
 i32* bitcast (i8* getelementptr (i8, i8* null, i32 4) to i32*),
 i32* bitcast (i8* getelementptr (i8, i8* null, i32 1) to i32*),
 i32* bitcast (i8* getelementptr (i8, i8* null, i32 2097152) to i32*),
 i32* bitcast (i8* getelementptr (i8, i8* null, i32 12) to i32*),
 i32* bitcast ([13 x i32*]* @__EEType_HelloWasm_TestClass___REALBASE to i32*),
 i32* bitcast (i8* getelementptr (i8, i8* null, i32 4) to i32*),
 i32* bitcast (i8* getelementptr (i8, i8* null, i32 -2049279568) to i32*),
 i32* bitcast ([2 x i32*]* @__typemanager_indirection to i32*),
 i32* bitcast (void (i8*, i8*)* @HelloWasm_TestDerivedClass__ToString to i32*),
 i32* bitcast (void (i8*, i8*)* @Object__Equals to i32*),
 i32* bitcast (void (i8*, i8*)* @Object__GetHashCode to i32*),
 i32* bitcast (void (i8*, i8*)* @HelloWasm_TestDerivedClass__TestVirtualMethod to i32*)
]

 ObjectLayoutInWASM = [@__EEType_HelloWasm_TestDerivedClass___SYMBOL, ActualData]

 //based on the above math this is where __SYMBOL points
 @__EEType_HelloWasm_TestDerivedClass___SYMBOL = i32* bitcast (i8* getelementptr (i8, i8* null, i32 2097152) to i32*)

 iSlotForTestVirtualMethod = 4
 //the math here is working with funcPtr**
 (*ObjectHeader) + (sizeof(EEType)/sizeofPointer) + iSlot = i32* bitcast ([2 x i32*]* @__typemanager_indirection to i32*)

So the resulting function pointer ends up not pointing to @HelloWasm_TestDerivedClass__TestVirtualMethod
for this to work there must be different math done in converting the iSlot number to the actual offset from @__EEType_HelloWasm_TestDerivedClass___SYMBOL and possibly we should be using __REALBASE as our EEType* instead of __SYMBOL.

If it helps this:
https://github.com/dotnet/corert/blob/712f557b8d1d087b29510e201d2a075f1813c867/src/ILCompiler.Compiler/src/Compiler/DependencyAnalysis/Target_X64/X64ReadyToRunHelperNode.cs#L32
is where we generate the assembly helpers to do virtual dispatch in the absence of the scanner phase in x64 RyuJIT.
I haven't looked at the commit in detail, but the lack of calls to EETypeNode.GetVTableOffset is suspicious.

you are correct EETypeNode.GetVTableOffset was the key to solving the entire thing

So if we "solv[ed] the whole thing" 3 months ago, with a fix that's been merged, why is this issue still open?  Is there still more to do on it?

@hippiehunter, I finally got module initialization merged, so your interface dispatch change should work now.

@morganbr
I've rebased with the current changes but im still running into a problem with DispatchResolve.FindInterfaceMethodImplementationTarget returning null. I updated https://github.com/hippiehunter/corert with my current attempts if you want to take a look at it.

Do you have an idea of where it gets disconnected? Looking at the text form of the bc file, it looks like we're now emitting InterfaceDispatchMaps that are aggregated into DispathMapTableStart. Looking through FindmplSlotInSimpleMap, it looks like the indirections are eetype->DismatchMap, DispatchMp->_dispatchMap and then DispatchMapEntry->_usImplMethodSlot.

@hippiehunter, I found the bugs and have a PR to fix them in #5735. Once that's in, your changes should work.

@hippiehunter, the fixes are merged. You should be able to go ahead with your changes now (your test passed combined with my changes).

Closing based on https://github.com/dotnet/corert/pull/5748. I'll open a new issue for null checks.


Fix README.md nested list formatting.

Currently "Shutdown" is not part of the list.

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! :smile:

@zhe-thoughts did you sign the CLA?

+1


Add proof of concept for saving/restoring app-db

This is not to be merged, but opening for discussion. It would be useful to be able to save a snapshot of app-state to be able to restore from later on, either within the same browser session or in a later one.
Current goals:

Serialise state and reload it within the same browser session
Serialise state and reload it against the same version of the application, but in a different session.

Out of scope:

Saving state from remote users and loading it into a debugging build
Exporting state
This working on different versions of code.

I found two issues immediately with the serialisation approach I have taken:

Some objects in app-db are not deserialisable, e.g. deftypes that haven't got a custom printer/reader.
In the todomvc example, there is a spec for the maps being ordered maps. However an ordered map serialised with prn is indistinguishable from a standard map and will cause a spec exception.

Both of these show that ser/de is likely to be the big blocker for this being a useful feature. I'm interested in hearing about other options here which can handle a wider range of datatypes than EDN.
One possibility is to use Transit and allow users to extend our transit readers and writers. I would probably prefer something more automatic but less compatible, like storing the memory representation and then reading it back. This is likely to be challenging for a variety of reasons though.
Another likely issue is being able to do some sort of pre and post initialisation, e.g. to synchronise localstorage, get new auth tokens, e.t.c.

We now have the ability to walk backwards and forwards through state snapshots. Trying to reinstate the app-db state from localstorage is pretty difficult due to serialisation, for diminishing returns. Closing this for now.


fix: also change DATABASE_ID to ELECTRIC_DATABASE_ID

Missed this when working on https://github.com/electric-sql/electric/issues/1927

We can merge this now & they can then change it / add docs when they get to it.


x/tools/cmd/guru: Callers seem broken in Go 1.11.2

What version of Go are you using (go version)?

$ go version
1.11.2

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/usernameLibrary/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/username/go/src"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/Cellar/go/1.11.2/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.11.2/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/username/go/src/xxx/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/7m/cnr_fyw56jnf9rvr65jhnbnh0000gn/T/go-build227458918=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
I typed :GoCallers in vim ,it reported "vim-go: guru: couldn't load packages due to errors: runtime/internal/sys, runtime, runtime/internal/atomic and 1 more".

What did you expect to see?
the callers of a function.
What did you see instead?
vim-go: guru: couldn't load packages due to errors: runtime/internal/sys, runtime, runtime/internal/atomic and 1 more
and it seemed to have parsing packages in $GOPATH/pkg/mod/...

Thank you for filing this bug @dongfengkuayue!
It would be nice to see perhaps the whole error mentioned in
What did you see instead?
vim-go: guru: couldn't load packages due to errors: runtime/internal/sys, runtime, runtime/internal/atomic and 1 more

Kindly paging @alandonovan

@dongfengkuayue - Could you mention the exact steps to get the error without vim-go being involved ? It would be great if you can upload a sample repo or show us a file which throws an error which guru is executed on it. Thanks.


nixos/sdcard: make firmware partition offset configurable

Different boards using u-boot SPL require to write to different
locations. Sometimes, the 8MiB gap isn't sufficient - rk3399 boards
write to 0x16384 for example, which is at 8MiB, thus overriding the
fat32 partition with the SPL.
Motivation for this change
NixOS on Helios64
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

The designed way to handle this is to delete the FIRMWARE partition, if you're installing the firmware (U-Boot) imperatively after the fact.
It's only needed for the Raspberry Pi. If the filesystem label allowed it, it would have been named "Firmware for the Raspberry Pi family of hardware only"
Though really the plan is to stop relying on smushing the firmware hapazardly into a block device. Work is underway for that. Given that it is done in my off time, it's not progressing much, but that is what Tow-Boot really is about.

With that said, we could add yet another feature to the bespoke image builder. It might benefit those who build images with U-Boot already installed into the image...
Though really, a better solution for those users would be to also not add the useless FIRMWARE partition.

A bit more off-topic here.
As for the Helios64, here's my vendor-flavoured Tow-Boot WIP tree. It's based on the huge patch dumped into Armbian by the vendor.
This is what is installed to SPI on my machine. Since it's installed to SPI, there is no need to modify any disk image. Even more convenient, you can dd the extlinux.conf basd image without modifications to USB, and it'll boot! From there you can nixos-install into the eMMC, without worrying about leaving space for the firmware (U-Boot).
Note that if you do so, you'll need to mark the rootfs (or /boot partition if you make one for some reason) as "legacy bootable" with GPT, "bootable" with MBR.

Accidental "keep baud" commit inclusion here :)

I included your proposed text changes.

The designed way to handle this is to delete the FIRMWARE partition, if you're installing the firmware (U-Boot) imperatively after the fact.
It's only needed for the Raspberry Pi. If the filesystem label allowed it, it would have been named "Firmware for the Raspberry Pi family of hardware only"
Though really the plan is to stop relying on smushing the firmware hapazardly into a block device. Work is underway for that. Given that it is done in my off time, it's not progressing much, but that is what Tow-Boot really is about.
With that said, we could add yet another feature to the bespoke image builder. It might benefit those who build images with U-Boot already installed into the image...
Though really, a better solution for those users would be to also not add the useless FIRMWARE partition.

The tooling here right now is the de-facto in-nixpkgs standard to create a image that can be dd'ed to an sdcard. It's exposed as config.system.build.sdImage, and all the config options are in the sdImage namespace.
Adding an option to increase the gap, to make that sdcard image building framework usable for rk3399, while staying consistent with the current stayl isn't much of a code burden.
I think in the long term, we should move the raspberrypi-firmware partition stuff to a sdImage.raspberryPiFirmware namespace - but that's probably part of a larger discussion on the interface, about how the profiles in nixpkgs are organized, and should maybe delayed until there's a stable interface used from things like Tow-Boot.
Right now, this is a minimal invasive fix for a problem to make the standard tooling more compatible, which is why I'd really like to see this merged. I can also change this PR to change the gap to 16MiB unconditionally if you prefer that over introducing the option ;-)

Accidental "keep baud" commit inclusion here :)

fixed.

Yes, sorry if it sounded more negative than intended.
What you wrote here sounds about like I think. It's fine to bring in this change, but huh, I'd really like to live in the future where we finally overhaul that issue with disk images, and then the ARM boot story.
And yes, that change is fine here, given that it's not invasive.

Yes, sorry if it sounded more negative than intended.

All good :heart:

What you wrote here sounds about like I think. It's fine to bring in this change, but huh, I'd really like to live in the future where we finally overhaul that issue with disk images, and then the ARM boot story.

Yes. I do have some opinions, and would love to discuss them - but I still need to set up Matrix properly, so it might take some time. You're gone from IRC entirely, right?

And yes, that change is fine here, given that it's not invasive.

Thanks for making that clear. So I'll hit the green button once ofborg is through.


Add CSV Download button

Test: https://aqua-csv.surge.sh
Closes #500
Works towards #501

1
2

Points of discussion:

The dailySST dates differ a lot from all other points. This means (most of the time) most rows don't have dailySST defined for a given timestamp (timestamps are precise and frequent because of the frequency of spotters and hobo sensors). Is this ok? Or should we always try fill dailySST with the closest match.

@Ry-DS With your latest changes, if I select a range that also has spotter data, this is how it looks like on desktop:

@Ry-DS With your latest changes, if I select a range that also has spotter data, this is how it looks like on desktop:

Thanks for the catch! What reef id was that so I can open it on my end?

@Ry-DS With your latest changes, if I select a range that also has spotter data, this is how it looks like on desktop:

Thanks for the catch! What reef id was that so I can open it on my end?

Unfortunately it's a local reef of mine to which I have added manually a spotter id, so that I could test this behavior.

@Ry-DS With your latest changes, if I select a range that also has spotter data, this is how it looks like on desktop:
--image snipped--

Thanks for the catch! What reef id was that so I can open it on my end?

Unfortunately it's a local reef of mine to which I have added manually a spotter id, so that I could test this behavior. The bug is still there 🙁

hmm, I'll try recreate this somehow on my end :+1:

@Ry-DS With your latest changes, if I select a range that also has spotter data, this is how it looks like on desktop:
--image snipped--

Thanks for the catch! What reef id was that so I can open it on my end?

Unfortunately it's a local reef of mine to which I have added manually a spotter id, so that I could test this behavior. The bug is still there slightly_frowning_face

hmm, I'll try recreate this somehow on my end

Make sure to run a backfil in order to get spotter data. This is just running the command yarn backfill-spotter-data -d 300 (backfill 300 days of data).

@tleraj let me know if you still face this issue. I managed to replicate it by hard coding 4 columns. Thanks again for letting me know :tada:

@Ry-DS Card alignment issue fixed :wink:

@Ry-DS I have a point for discussion here. When I select maximum range, the chart gets stuck at loading for a long time (an issue not met in the latest deployment of use-time-series here). What I think that causes this behavior, is that we read a very big chunk of data from redux (useSelector(reefTimeSeriesDataSelector)) in two places now, and on the second place (the csv button component) we also process this data in order to create the csv. I think we should try and pass this data to <DownloadCSVButton ... /> component via props (so that we get rid of the second read from redux), and if that doesn't work, then we should figure out another approach. Let me know what you think :slightly_smiling_face:

@Ry-DS I have a point for discussion here. ...snipped

Fixed the performance issues. Good catch !


LIIKUNTA-584 | feat: update to HDS v3.1.0, use Header in Navigation component

Description
Testable at (PR #534):

https://liikunta-pr534.dev.hel.ninja/
https://harrastukset-pr534.dev.hel.ninja/
https://tapahtumat-pr534.dev.hel.ninja/

feat: update to HDS v3.1.0, use Header in Navigation component
From HDS v3.0.0 release notes:

Breaking

[Navigation] Removed, use new Header instead
[Footer] Redesigned and rebuilt
[StatusLabel, Tag] Rectangular versions removed
[LinkBox] Property name withBorder changed to border
[Koros] Renamed variants Wave to Vibration and Storm to Wave
...
Changed
[Koros] Rename koros flipHorizontal to flipVertical

steps:

update hds-(core|design-tokens|react) from ^2.17.0 to ^3.1.0
icons

export IconEuroSign
export IconAtSign
export IconCalendarEvent
export IconWhatsapp
export HDS v2 icon names as aliases for v3 icons for backward
compatibility
sort icon exports alphabetically

replace RoundedTag with Tag because
"[StatusLabel, Tag] Rectangular versions removed"
rename flipHorizontal to fipVertical because
"[Koros] Rename koros flipHorizontal to flipVertical"
rename hero.module.scss's &.wave to &.vibration because
"[Koros] Renamed variants Wave to Vibration and Storm to Wave"
rename hero.module.scss's &.storm to &.wave because
"[Koros] Renamed variants Wave to Vibration and Storm to Wave"
switch react-helsinki-headless-cms's Navigation component to use
HDS v3's Header because
"[Navigation] Removed, use new Header instead"

deprecate variant property from NavigationProps as unused

sources:

HDS v3 migration guide:

https://hds.hel.fi/getting-started/tutorials/migrate-to-3.0.0/

HDS releases v3.0.0 and v3.1.0:

https://github.com/City-of-Helsinki/helsinki-design-system/releases

/tag/v3.0.0
/tag/v3.1.0

refs LIIKUNTA-584
Issues
Closes
LIIKUNTA-584
Related
Testing
Automated tests
Manual testing

checkout PR's branch locally
yarn
yarn storybook

Screenshots
Additional notes

Rebased on main and force pushed


genes/proteins in Orphanet should have gene/protein category labels

I think this was fixed with this commit? https://github.com/RTXteam/RTX-KG2/commit/8b0eab5beba734509622a8d7c22731cccd9596bf
closing


A question about the duration

Hi, I am learning your code recently, but I got a question about the note's duration.
While I see a duration extract from midi file, is this duration the phoneme duration? or a word duration?
and is the groudtruth duration label predicted by an model ? not from some alignment tool like mfa?
Thanks!!

Dear zfishbone01,
Hello,

The duration is the length of a syllable. And I premised the front and end of several frames of the syllable duration are the duration of an onset and a coda. However, in the case of Korean, both phoneme and grapheme are always in single C, single V, and single C form(CVC), so phoneme and grapheme match positionally, but other languages do not. If the language you are using has a structure in which multiple graphemes are combined to form a single phoneme, it is recommended to configure it based on phonemes.

The private data I used was hand-predicted data with DAW. However, HiFiSinger's original paper used MFA, so it is recommended to use MFA.


add dim checks

Added a timedim parameter and additional checks for make sure that the dimensions are (time, y, x).

Codecov Report

Merging #20 (e4fc848) into main (ffb9dcf) will decrease coverage by 0.78%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   94.41%   93.62%   -0.79%
==========================================
  Files           4        4
  Lines         197      204       +7
==========================================
+ Hits          186      191       +5
- Misses         11       13       +2

Flag
Coverage Δ

unittests
93.62% <91.66%> (-0.79%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

ocetrac/model.py
91.15% <71.42%> (-1.38%)
:arrow_down:

tests/test_model.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb9dcf...e4fc848. Read the comment docs.


feature: encrypt code snippets with a password

New button "Set password"

Field "Password" with animation

The recent codes have a state in encryption

Password page

Invalid password status

Thanks 👍


Python 3 support

Any plans?

Python 2 is getting rapidly deprecated. It would be helpful to support python 3 before python 2 support is gone.

The google repo version now supports python 3, would it be possible to update this to the newest version of the original Google project?


dataiter = dataloader.next() is giving an attribute error that next attribute isn't found

I'm using a Windows 10 Pro OS and in the data loader, dataiter.next() isn't working.
Exception has occurred: AttributeError 'DataLoader' object has no attribute 'next'   File "C:\Users\xxx\Desktop\xxxx\xxxxx\code\pytorchbasics\datasetanddataloaderclass.py", line 40, in <module>   datatiter = dataloader.next()

However, If anyone's facing some run time errors, when starting to print the features and labels after the data loader step, add if name == 'main': , and after dataiter,  use  data = next(datatiter) if dataiter.next() isn't working. Not sure if this is the same for all, but I use VS Code on a Windows OS and I was getting a run time error without a name =  main and an attribute error for next.
Hope it's helpful, you can also refer https://stackoverflow.com/questions/18204782/runtimeerror-on-windows-trying-python-multiprocessing, for understanding the runtime error  and https://stackoverflow.com/questions/74289077/attributeerror-multiprocessingdataloaderiter-object-has-no-attribute-next, to understand the error with dataiter.next()

after dataiter, use data = next(datatiter) if dataiter.next() isn't working.
Reference:
https://stackoverflow.com/questions/74289077/attributeerror-multiprocessingdataloaderiter-object-has-no-attribute-next, to understand the error with dataiter.next()


Examples in help info for command send is incorrect

Run the below command after installing latest version of vegawallet
vegawallet command send -h
The examples displayed in the help are incorrect - they should state "command send" rather than "send command"
Muthus-MBP:repos muthupandianvadivelu$ vegawallet command send -h
Send a command to a Vega node via the gRPC API. The command can be sent to
any node of a registered network or to a specific node address.

The command should be a Vega command formatted as a JSON payload, as follows:

'{"commandName": {"someProperty": "someValue"} }'

For vote submission, it will look like this:

'{"voteSubmission": {"proposalId": "some-id", "value": "VALUE_YES"}}'

Usage:
  vegawallet command send [flags]

Examples:
  # Send a command to a registered network
  vegawallet send command --network NETWORK --wallet WALLET --pubkey PUBKEY COMMAND

  # Send a command to a specific Vega node address
  vegawallet send command --node-address ADDRESS --wallet WALLET --pubkey PUBKEY COMMAND

  # Send a command with a log level set to debug
  vegawallet send command --network NETWORK --wallet WALLET --pubkey PUBKEY --level debug COMMAND

  # Send a command with a maximum of 10 retry
  vegawallet send command --network NETWORK --wallet WALLET --pubkey PUBKEY --retries 10 COMMAND

Tested OK in latest version
Muthus-MBP:vega muthupandianvadivelu$ vegawallet command send -h
Send a command to a Vega node via the gRPC API. The command can be sent to
any node of a registered network or to a specific node address.

The command should be a Vega command formatted as a JSON payload, as follows:

'{"commandName": {"someProperty": "someValue"} }'

For vote submission, it will look like this:

'{"voteSubmission": {"proposalId": "some-id", "value": "VALUE_YES"}}'

Usage:
  vegawallet command send [flags]

Examples:
  # Send a command to a registered network
  vegawallet command send --network NETWORK --wallet WALLET --pubkey PUBKEY COMMAND

  # Send a command to a specific Vega node address
  vegawallet command send --node-address ADDRESS --wallet WALLET --pubkey PUBKEY COMMAND

  # Send a command with a log level set to debug
  vegawallet command send --network NETWORK --wallet WALLET --pubkey PUBKEY --level debug COMMAND

  # Send a command with a maximum of 10 retry
  vegawallet command send --network NETWORK --wallet WALLET --pubkey PUBKEY --retries 10 COMMAND


Force option

ref: https://github.com/kamontia/git-fixup/issues/3

I'll recreate PR from another branch.


How to run scrapy code + splash in heroku ? docker container in heroku

Your best bet is to modify the splash Dockerfile as shown here https://stackoverflow.com/a/47414276/2020214
And then push the docker image to Heroku as shown here https://stackoverflow.com/a/46068133/2020214

Probably something related to that Docker image issued in 2018 :thinking:

Anybody get a solution here?


Temporarily disable RestClientStats tests.

Until #142 is addressed, to avoid blocking the test suite.

One test fails due to the second comment at #142 , the other due to #143 . Should be considered passing.

Ok, LGTM

Why didn't you amend the commit?

Sorry, should asked it before saying LGTM.

@ricardopereira Yeah, could've done that... Github gives some friction abut that though.

Great


Do not trip on new warn before read feature

Upstream privatebin introduced this new feature  https://github.com/PrivateBin/PrivateBin/pull/1237
If the fragment contains a prefix character - , then the ui is supposed to warn before actually getting paste, as the paste may be burn on read.
source
This character can trip our reading of the bs58key. So, strip the prefix if found.

Greetings,
thank you for spotting and fixing this, I did not know about that feature. I saw that you made a comment upstream. I'll be merging this since the current upstream implementation is a dash. Something to keep an eye on I figure.
Thank you for your contribution
Best Regards
Mydayyy


Add Phrase Fallback Value

Not seeing it a ton, but have noticed this error a few times in the Lambda logs. Looks like we need to fallback to empty String if the phrase is undefined.
{
    "errorMessage": "Cannot read property 'split' of undefined",
    "errorType": "TypeError",
    "stackTrace": [
        "module.exports (/var/task/util/translator.js:2:24)",
        "Object.Translate (/var/task/index.js:46:24)",
        "emitNone (events.js:106:13)",
        "AlexaRequestEmitter.emit (events.js:208:7)",
        "Object.TranslateIntent (/var/task/index.js:42:10)",
        "emitNone (events.js:106:13)",
        "AlexaRequestEmitter.emit (events.js:208:7)",
        "AlexaRequestEmitter.EmitEvent (/var/task/node_modules/alexa-sdk/lib/alexa.js:216:10)",
        "AlexaRequestEmitter.ValidateRequest (/var/task/node_modules/alexa-sdk/lib/alexa.js:181:23)",
        "AlexaRequestEmitter.HandleLambdaEvent (/var/task/node_modules/alexa-sdk/lib/alexa.js:126:25)"
    ]
}

Upon looking at the log date/time of these errors...I think this might have been me testing the skill and not an actual error users were experiencing. Closing for now...will reopen if I see this happening again.


How does kserve rayserve actual intergration work?

I was wondering how kserve's ray serve integration actually works? When I think of using ray serve, I think of using Ray Cluster via KubeRay under the hood. That said, is kserve simply using ray as a python package? If so, does the integration behave similarly to the multiprocessing package?

same question here


FEAT: Implement infer_types dataframe algebra operator

The Pandas infer_objects function (as well a the infer_objects option of convert_dtypes) can both be made more efficient by implementing the infer_types dataframe algebra operator.

(see also: #4675, which may possibly get addressed by this, and #2924, which seems to be for tracking algebra operators but likely hasn't been updated for a while)


Potential for memory leak via setState.

Summary:
A recent change to fix css transitions in Safari seems to have created the potential for a race condition (or memory leak as the React warning points out). The relevant state change was moved into a requestAnimationFrame callback, but there is no guarantee that the component will still be mounted by the time the callback executes. The error message I am seeing is:
Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.
    ModalPortal@https://f02nn.csb.app/node_modules/react-modal/lib/components/ModalPortal.js:70:20
    Modal@https://f02nn.csb.app/node_modules/react-modal/lib/components/Modal.js:73:20

(Note I have removed the rest of the stack as it contains references to closed-source code).
Steps to reproduce:
So far I have only been able to reproduce this issue using tests, which is where I first encountered the issue. A simple test to open and close the modal triggers the warning, though the test does not fail:
import { render, screen, waitFor } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import "@testing-library/jest-dom";
import Modal from "react-modal";
import App from "./App";

it("Opens and closes the modal", () => {
  const { container } = render(<App />);
  Modal.setAppElement(container);

  userEvent.click(screen.getByText("Open"));
  expect(screen.getByRole("dialog")).toBeInTheDocument();

  userEvent.click(screen.getByText("Close"));
  expect(screen.queryByRole("dialog")).toBeNull();
});

I have created a codesandbox to illustrate the issue (see below). Note that with codesandbox the console error for the tests will appear in the "Browser" tab, not the "Tests" tab for some reason.
https://user-images.githubusercontent.com/1218900/120699739-0983a080-c46e-11eb-84bb-9368611c8764.mov
Expected behavior:
The warning does not appear.
Link to example of issue:
https://codesandbox.io/s/react-modal-memory-leak-f02nn
Additional notes:
One solution might be to add an isMounted check to the requestAnimationFrame callback. If I have more time later I can try adding that check.

Hi @adriantrunzo Is till can reproduce the warning when upgrading to latest version of react-modal on the codesandbox example. I have the same warning in my tests so I'm interested if anyone is aware of a fix or workaround.


Simple belongs_to breaks resource index page

I have something like this:
defmodule MyApp.Order do
  schema "orders" do
    belongs_to :user
  end
end

defmodule MyApp.User do
  schema "users" do
    has_many :orders
  end
end

When I load the index page for orders, I get this:
** (UndefinedFunctionError) function nil.__struct__/0 is undefined or private
        nil.__struct__()
        ExAdmin.Helpers.get_resource_field/3
        (elixir) lib/enum.ex:1184: Enum."-map/2-lists^map/1-0-"/2
        lib/ex_admin/helpers.ex:98: ExAdmin.Helpers.map_relationship_fields/3
        lib/ex_admin/helpers.ex:208: ExAdmin.Helpers.build_single_field_type/5
        lib/ex_admin/helpers.ex:134: ExAdmin.Helpers.build_field/4
        lib/ex_admin/themes/admin_lte2/index.ex:187: anonymous fn/4 in ExAdmin.Theme.AdminLte2.Index.build_table_body/4
        (elixir) lib/enum.ex:1623: Enum."-reduce/3-lists^foldl/2-0-"/3
        lib/ex_admin/themes/admin_lte2/index.ex:186: anonymous fn/5 in ExAdmin.Theme.AdminLte2.Index.build_table_body/4
        (elixir) lib/enum.ex:1184: Enum."-map/2-lists^map/1-0-"/2
        lib/ex_admin/themes/admin_lte2/index.ex:174: ExAdmin.Theme.AdminLte2.Index.build_table_body/4
        lib/ex_admin/themes/admin_lte2/index.ex:54: ExAdmin.Theme.AdminLte2.Index.paginated_collection_table/2
        lib/ex_admin/themes/admin_lte2/index.ex:155: ExAdmin.Theme.AdminLte2.Index.batch_action_form/6
        lib/ex_admin/themes/admin_lte2/index.ex:14: ExAdmin.Theme.AdminLte2.Index.wrap_index_grid/1
        lib/ex_admin/index.ex:267: ExAdmin.Index.default_index_view/3
        web/controllers/admin_resource_controller.ex:27: ExAdmin.AdminResourceController.index/3
        web/controllers/admin_resource_controller.ex:1: ExAdmin.AdminResourceController.action/2
        web/controllers/admin_resource_controller.ex:1: ExAdmin.AdminResourceController.phoenix_controller_pipeline/2
        (my_app) lib/my_app/endpoint.ex:1: MyApp.Endpoint.instrument/4
        (my_app) lib/phoenix/router.ex:261: MyApp.Router.dispatch/2

I'm using the current master (880e511cf3e67081cd727b809eb115eb31a57966), since the release version specifies a version of scrivener that doesn't support postgrex 0.13.

Looks like the issue was that I needed to register my User model as with ExAdmin. Maybe we could add an error to make this case less confusing?

@RobinClowers same error here. Do you remember how you solved it?
I did added to config.exs the:
config :ex_admin,
  module: MyApp,
  modules: [
    MyApp.ExAdmin.Dashboard,
    MyApp.ExAdmin.ModelThatFails,
    MyApp.ExAdmin.User
  ]

@augnustin I think adding the User module is all I did, sorry I'm not more help...

Solved my issue by registering the belongs_to model associated, reported in #459


Spike: ICA API?

read docu and/or ask Vlad

https://ica.illumina.com/ica/api/swagger/index.html
https://illumina.gitbook.io/ica/reference/r-api

In my mind, the connection to the app could look like this:
1.

create a connector:  https://help.ica.illumina.com/project/p-connectivity/service-connector

possible to connect with phone?

in lib/login/pages/cubit.dart > signInAndLoadUserData(), use this connector

create an API token
use API token to access API: https://ica.illumina.com/ica/api/swagger/index.html#/User


Estimate Action Count in Statistics

Exract from #19474
As #19474 appears completely stalled. This PR simply changes the statistic generation to only estimate counts for the Action table. I still believe that estimates would be appropriate for a number of other results - most likely the comment count.
Fix #17506
Signed-off-by: Andrew Thornton<EMAIL_ADDRESS>

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@468387e). Click here to learn what that means.
The diff coverage is 0.00%.

:exclamation: Current head be7d37c differs from pull request most recent head efdbe63. Consider uploading reports for the commit efdbe63 to get more accurate results

@@           Coverage Diff           @@
##             main   #19775   +/-   ##
=======================================
  Coverage        ?   47.27%
=======================================
  Files           ?      957
  Lines           ?   133339
  Branches        ?        0
=======================================
  Hits            ?    63034
  Misses          ?    62654
  Partials        ?     7651

Impacted Files
Coverage Δ

models/db/context.go
70.10% <0.00%> (ø)

models/statistic.go
0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 468387e...efdbe63. Read the comment docs.

On second thoughts perhaps this shouldn't be backported.


optimize metric aggregate

Please answer these questions before submitting your issue.

Feature or performance improvement

Requirement or improvement

the metric aggregate take a lot of time and the es server have a high load for it. because every metric need to query the minute, hour, month data, and update the query data.
so i think we can chage the mode to improve performance
first we can load the minute data to memory or file (if we loss of some real time for it)
second we can use a hour timer and day timer to calculat the hour data and day data then save it.

There is a mechanism called session to do things like this.

second we can use a hour timer and day timer to calculat the hour data and day data then save it.

This will cause OOM, so we can't do this.

There is a mechanism called session to do things like this.

second we can use a hour timer and day timer to calculat the hour data and day data then save it.

This will cause OOM, so we can't do this.


fix choose another template button and insert tooltips

Please check this new branch. Thanks! :)

well done


Localization support

Checklist

[X] There are no similar issues or pull requests for this yet.

Is your feature related to a problem? Please describe.
It would be very cool to implement localization support for different languages
Describe the solution you would like.
No response
Describe alternatives you considered
No response
Additional context
No response

https://github.com/jowilf/starlette-admin has quite a good localization system, I'd recommend checking it.


Just add the  and run it

Challenge http://freecodecamp.com/challenges/waypoint-house-our-page-within-a-bootstrap-container-fluid-div has an issue. Please describe how to reproduce it, and include links to screenshots if possible.

A reset fixed the issue. Sorry for any inconvenience.

No problem @kostisJP!
Take a look at the Bug Posting Guidelines for the future.  Resetting is the first recommended step :smile:


Repeated notification for finished campaign

I am not sure if this is the correct repository to post this issue.
I think the issue is following:
If you have worked on a campaign that has finished, the campaign gets new tasks added, and then finished again, you always get a notification.
So whenever I log in,  I get some notifications which are irrelevant.

Got it. One solution would be to reset notifications for a challenge whenever it is finished. So you wouldn't get any more unless you complete another task after new tasks are added. Would that solve the issue for you?

I am having the same issue.

One solution would be to reset notifications for a challenge whenever it is finished.

How can i reset notifications for a challenge? Where do i find this option?

@mvexel This is a possible candidate for inbox / messaging overhaul.


Add a missing case to the incremental parse fuzzer

Thanks for fixing this.
Missed it with the last few changes to that PR to split out the core type section.


Added a new HTML CSS book PDF english

Hacktoberfest notes:

due to volume of submissions, we may not be able to review PRs that do not pass tests and do not have informative titles.
please read our contributing guidelines
be sure to check the output of Travis-CI for linter errors
if this is your first open source contribution, make sure it's not your last!

What does this PR do?
Add Resource(s) | Remove Resource(s) | Add info | Improve Repo
For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[x] Not a duplicate
[x] Included author(s) if appropriate
[x] Lists are in alphabetical order
[ ] Needed indications added (PDF, access notes, under construction)

Wouldn't this belong under the HTML & CSS section?
You've out it in the table of contents.

Wouldn't this belong under the HTML & CSS section?
You've put it in the table of contents.

I have generated a new pull request for the changes :)

Awesome, I see it here! https://github.com/EbookFoundation/free-programming-books/pull/4294
Perhaps close this PR ahead of time then since it's now a duplicate.

Awesome, I see it here! #4294
Perhaps close this PR ahead of time then since it's now a duplicate.

Closed all the Invalid PR's, Waiting for the new ones to be approved and merged :) #4296 #4295 #4294 #4291


Language selection

When All is selected in the language selector, the graph is not updated. Also when the a language is selected and cleared (i.e. the language selector is empty, the graph does not reflect any changes back to default

Hi Ben,
I tried a lot of ways but not found a way to fix this up. I also tried to implement my own js to select a default value to the filter but it only selects for windows load option.
I guess this is bug with crosstalk already reported
Link - https://github.com/plotly/plotly.R/issues/1346


Cache video url - then get it from cache again?

I download a video from a URL, and then i cache the Data to the cache using Cache.
Then later on I want to play that video i cached, so i check if it's cached, which it is, but then I put the Data into an url like (videoData being the NSData from the cache):
let url = URL(dataRepresentation: videoData as Data, relativeTo: nil)!
If i then try to play the video using the url, it's not working. Help please?
I know one could store the file locally, and the find the path to that file, but that defeats the purpose of caching a video using this library, because then you can't control expiration date etc.
And I see that the cached files get a .cache file type, so I can't reference the path directly as a .mp4 file and play it from the cached folder.

Hello Daniel,
I'm running into the same issue. What I ended up doing as a temporary fix is to get the video data from the cache, then save it to the user temp directory as an MP4 file and getting the url for that instead.
if let cachedVideoData = cache.object(forKey: videoUrl.absoluteString.sanitizeKey()) {
  let tempVideo = File<NSData>(path: Path.userTemporary + "temp.mp4")
  try! tempVideo.create()
  try! tempVideo.write(cachedVideoData, atomically: true)
  // use tempVideo.path.url
}

I'm using FileKit, but this can be done in the same way with FileManager
I don't really like this solution, but it will have to do for the time being.


Add linalg.qr to ChainerX

This is work-in-progress pull request!
This PR adds QR decomposition providing bindings to cuSOLVER's QR decomposition on GPU and to LAPACK on CPU.
With reference to #6423  and #6764

QR decomposition is working now correctly.

Currently blocked by #7791

The tri* routines have now been merged. Could you rebase/update this PR?

TODO:
With shape (N, 0) and mode='complete' cuSOLVER does not return the same result as LAPACK for q matrix (it should be the identity matrix). The solution is to handle this case explicitly separately.

Jenkins, test this please.

LGTM, thanks for the long running PR! Let's just check the CI.

Jenkins CI test (for commit 1874f05f658808ae357648f8f1a6c4caec916ec9, target branch master) failed with status FAILURE.

Seems like we need to fix an edge case for empty inputs https://jenkins.preferred.jp/job/chainer/job/chainer_pr/1873/

Seems like we need to fix an edge case for empty inputs https://jenkins.preferred.jp/job/chainer/job/chainer_pr/1873/

I don't know what is causing this. The error is not reproduced on my computer with CUDA 10.1
From CUDA changelog:

In earlier releases, cuBLAS GEMM calls might randomly crash when running multiple host threads sharing one cuBLAS handle despite adhering to recommended usage in Thread Safety. This bug affects cuBLAS in earlier CUDA releases, and is fixed in CUDA 10.1.
This bug affects cuSOLVER dense linear algebra functionality in CUDA 10.0, and is fixed in CUDA 10.1. An internal routine (LARFT) in cuSOLVER dense linear algebra has a race condition if the user stream is not null. Although this routine is not in the cuSOLVER public API, it affects all routines based on householder reflection, including ORGBR, ORMTR, ORGTR, ORMQR, ORMQL, ORGQR AND SYEVD, SYGVD.

ChainerX implementation of QR decomposition calls ORGQR, which is in the list of affected routines. That might or might not cause our troubles. Anyway, I've added an early return for the case of an empty input array.

Thanks for the fix, let me verify it. As for the release note citation above, I also read it but we aren't using non-null streams AFAIK.

Removing test-and-merge as merging is blocked until the release on Thu.

Jenkins, test this please.

Jenkins CI test (for commit cdbd6be420394ca8982d5bd884f28437f75a1484, target branch master) failed with status FAILURE.

Still seeing failures on Jenkins. Could it be for non-"complete" cases?

I suppose the reason for failure was complete mode && m==0 which was not covered by an early return.

Jenkins, test this please.

Jenkins CI test (for commit 0dbea62b33b8583c8580ff4eee2f39dd55e6cf2f, target branch master) failed with status FAILURE.

Jenkins, test this please.

Jenkins CI test (for commit f3141d16b5a8b54dcc8492f453857fa66a7eb427, target branch master) succeeded!

Jenkins, test this please.

Thanks for the long running PR as always, LGTM!


Create 'by-discriminate' tactic

Test case? It may be easiest to just change one of the existing examples to use this. eg, look in Tactics-inversion.rkt

merged https://github.com/stchang/cur/commit/f4bdf64fa8d0584e7be336120c2a89e3c2788e47


Automatically log errors when program fails

Programs should convert the error code into the #[msg("<msg>")] string and log it via msg!.

potential spec (not sure if it could actually work like this) which builds on some of the ideas of @cqfd 's PR but includes file and line information and more dynamic errors that show what exactly went wrong.

create an AnchorError and an AnchorResult<(), AnchorError>

AnchorError is a struct with a msg:String field, an error_code:u64 field, a line number field, and a file field
implements From and ProgramError implements From
autogenerated derive(Accounts) code will throw AnchorErrors showing exactly on which accounts and how a constraint was violated
inside-handler user code will use an error! macro that takes a string and an error code and creates an AnchorError that also includes the line number and file name

if dispatch returns an error

anchor logs the error information once in human readable form
and once in base64 encoded form
converts the anchorerror back into a programerror and returns it

I would also suggest merging #789 and #823 for one issue that fully designs and implements proper error reporting, I think that will be easier to develop and better designed

open question: how do we make error msgs dynamic?
e.g. error #msg[..] could be defined with "{}" syntax like format!. the new error creation macro then takes args that fill the {}

another feature that could be added as part of this milestone: more require statements
e.g. require_mut(account), require_signer(account), require_owner(account, owner) etc.
This is useful for instructions that use remaining_accounts

We should talk more about specification of this issue
The following code
pub fn initialize(ctx: Context<Initialize>) -> AnchorResult<()> {
        error!(MyError::SomeError)
}

results in the following logs
Program log: AnchorError thrown in programs/compute/src/lib.rs:9 in program: Fg6PaFpoGXkYsidMpWTK6W2BeZ7FEfcYkg476zPFsLnS. Error Code: SomeError. Error Number: 6000. Error Message: Some error has been thrown.

which is the type of error (AnchorError vs ProgramError). The file and line. The ErrorCode/ErrorName, the error number, and the error message.
This information seems pretty good to me.  Im going to adjust the error msgs to make them dynamic so then youd have even more freedom. I added the program id so errors are useful even if CPIs are happening
the question is, what's the best way to log this? I think we should definitely provide an option to just log it like this. It's very useful for developing and would also be useful info in the explorer. But maybe there should be an option to turn this off.
but imo we also need something more machine friendly. We could do what events do and encode and then log the encoded error as well.
Also, the error msg above costs ~ 14K compute units which is pretty expensive. However, about 12K of those come from turning the public key into a string. This is not necessary because we can hardcode the string somewhere.

Note that logging the program id is redundant, because it can be easily inferred when looking at the log context (every CPI shows the program being invoked).
The machine readable / structured error would be useful (and preferred) for funneling error messages to the client, rather than what we do now which is parse error codes. Defining a error type that is logge din the same way we do events sounds good.
E.g.
#[derive(AnchorSerialize, AnchorDeserialize)]
pub struct ErrorEvent {
  line: u64,
  msg: String,
  code: u32,
  ...
}

One question is do we want to add a unique header to such an error event like we do for regular events. I think so, so that we can parse it from the logs easily. Something simple like sha256("internal:error")[..4] as the discriminator with the new header. Might be good to do this as a separate change, since it will also require client plumbing.
Related https://github.com/project-serum/anchor/issues/126#issuecomment-815466853.


feature/oobaboga: Fixing merge from main

Hi, this is a new PR from a new user-level fork to account for a github bug preventing edits by maintainers on a PR made from an organization-level fork (see that final comment on last PR)
This PR is only an attempt at merging upstream's main for final integration of the oobabooga connector into main branch. Last set of commits made CompleteRequestSettings.MaxTokens Nullable (#450f1d3a11eb95d6975da33f581d3997bed42906), which broke this connector.
Making TextCompletionRequest.MaxNewTokens fixed the issue. Note that Oobabooga defaults max tokens to 200

@shawncal , it seems we fixed the pr name at the same time, sorry about that, feel free to rename it as you wish


On Microsoft Site - link below doesn't work

To whom it may concern:
I have been doing research and the following link does not work.
https://docs.microsoft.com/en-us/windows/device-security/auditing/security-auditing-overview
Thanks,

@DerekLedbetter Where's your link from (that links to your link)?


add xattrs support to fs

First step in solving #599. This adds xattr support to fs.FullFS interface, as well as the two implementations.
It does not check for the various namespaces, as I didn't see much value in it here. Generally, that is something done at a higher level.
It does not yet use them when reading/writing tar streams. That will be next phase.\
Obviously includes unit tests

Let's wait for #26 to go in, and for me to include that race condition handling, before we merge this. Will move this to draft until that is done.

Now ready for review. I added using the lock for when accessing the xattrs map, as that, too, could lead to race conditions


Reset resource after exiting edit page without saving.

When editing a resource via the default edit view changes will stay on the resource even when navigating away. The changes are not persisted and are gone when the user refreshes but not when navigating to a different page. This might give the impression the resource is saved to the server and can lead to unintentional data loss.
We should make it so that when the user leaves the edit page the resource gets refreshed so it shows its state from before it was edited.

Some thoughts:
Form fields (in the edit page) should not update the Resource in the Store. The fact that the store is updated, instead of some local value, is at the heart of this issue.
A refresh after navigating away should fix OPs issue, but it does not fix the underlying issue.
Perhaps the useValue hook deserves some additional thoughts. Live updates (before the commit is signed / accepted) are useful for having a responsive, fast app, but a value should not be set in a Form before the "save" button is pressed, I think.

I don't really see an issue with the store being updated. It makes it relatively simple to work with complex shared data throughout the app. Using some kind of clone of the resource or a separate object with values kind of goes against the read/write nature of resources and AtomicData.
Refreshing the resource when the edit form unmounts is also a lot simpler and completely bypasses other issues like dealing with serverside updates of the resource that can introduce merge conflicts with the cloned data.


Update dlp-on-premises-scanner-get-started.md

should be on-premises instead of Endpoint DLP since this is on-prem DLP doc

@chrfox please review

Docs Build status updates of commit e1bc4a2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/compliance/dlp-on-premises-scanner-get-started.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit ab05469:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-365/compliance/dlp-on-premises-scanner-get-started.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Roll Flutter Engine from fd56b7ee87f0 to 61efd9aaa2e7 (1 revision)

https://github.com/flutter/engine/compare/fd56b7ee87f0...61efd9aaa2e7
2022-11-12<EMAIL_ADDRESS>Roll Dart SDK from 190040da0bc8 to 996fe4d7ea9a (2 revisions) (flutter/engine#37552)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Mobile camera issue

Mobile users are currently experiencing a bug where the camera starts spinning uncontrollably at a random point in the game.

Mobile users are currently experiencing a bug where the camera starts spinning uncontrollably at a random point in the game.

Apparently this still occurs on PC as well

I can tell you this is caused by self.activeTransparencyController:Update(dt) which is called in CameraModule.Update now requiring that dt parameter.
Also, it got worse when :ApplyVRTransform was removed.
I'm opening a separate issue and pull request for the CameraInjector that resolves this. Until that's set, you can find the fix here:
https://devforum.roblox.com/t/wall-stickgravity-controller/432598/379


Furnace variables & configuration should be centralized

Most web frameworks have centralized configuration, even if it's at least nominally listed in the documentation in at least one central location.
Perhaps the same could be done for Furnace to make it easier to tweak/tune.

What kind of configuration are you thinking?  Database configuration?  Routes?

I was thinking about things like:

enabling benchmark logging (IN: http.server t benchmark? set-global)
setting log levels (httpd defaults to DEBUG loglevel)
changing log output location
database configuration
thread pool configuration (e.g. configuring max. # connections)

All of the above can be configured by setting the relevant slots/symbols, but it requires reading Furnace source. This isn't a bad thing, but it would certainly help things if at least some of this information could be centralized. To scratch this itch, I was thinking of a "Furnace cheatsheet" that lists most of the above in a help article as a first step.


Bug: HRESULT::ok() losing vital information

(windows crate, v0.43.0)

The constants S_OK and S_FALSE are both success codes. Probably 99% of COM methods return S_OK when they succeed; but do not let this fact mislead you. A method might return other success codes

(https://learn.microsoft.com/en-us/windows/win32/learnwin32/error-handling-in-com)
I'm calling AssocQueryStringW(). The C function returns HRESULT S_FALSE in the first pass where you query the required buffer size. The Rust crate function's source ends with FnReturningHresult(...).ok(). This HRESULT::ok() is defined:
pub const fn ok(self) -> Result<()> {
    if self.is_ok() {
        Ok(())
    } else {
        Err(Error { code: self, info: None })
    }
}

So, S_OK, S_FALSE and all other possible success results are lumped together into the unit type value (). But I'd need to react on S_OK and S_FALSE differently.
BTW, in std, the only function named ok() I can find is Result::ok(), and it returns an Option<...>, not a Result<...>.

This is supported via the CanReturnMultipleSuccessValuesAttribute attribute, but it seems this is missing for this function. I'll transfer this issue to the Win32 metadata repo for resolution.
If you can comment on any other related functions that may also be affected, they can fix it all in one go. Thanks for reporting!


#687 - Allow symbols in props

WIP
fixes #687

Nice work, @mcorbanini! Great to see this PR come in.

Hmm, I just re-ran the build after updating master. 1.3.0 released fine fro, all tests passing in IE9+ but seems one of the tests here is failing in IE10? Maybe worth re-running after you've finished any work you have left.

lgtm once the build's green

2 optional comments, lgtm 🎉

LGTM

LGTM

let's try this again: lgtm

LGTM

I've reran these tests numerous times now - BrowserStack seems to time out every single time - maybe some connection timeout needs to be increased?

:shipit:

lgtm

wohoo!


[Bug] Fix bug that prevented custom tables/grids with column referral

Description
Closes https://github.com/mckinsey/vizro/issues/435 and https://github.com/McK-Internal/vizro-internal/issues/747
We now send the full DF during the build phase (instead of an empty pd.DataFrame). This could have performance consequences for very large DFs, but on the grand scheme of things I think it probably the better solution.
And alternative would be to send an empty DF with the columns present, but that may lead to other bugs down the road.
Screenshot
Notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
I have not referenced individuals, products or companies in any commits, directly or indirectly.
I have not added data or restricted code in any commits, directly or indirectly.

Thanks for fixing so quickly! 🚀  What "potential bugs down the road" do you imagine? I actually like the alternative solution approach - it's also the one we've implemented on VizX actually. I think it did not lead to any major bugs, and the performance issue was more severe.

Thanks for fixing so quickly! 🚀 What "potential bugs down the road" do you imagine? I actually like the alternative solution approach - it's also the one we've implemented on VizX actually. I think it did not lead to any major bugs (as far as I remember), and the performance issue was more severe.

So of the top of my head I could imagine that someone not only refers to a column, but also a specific row. This then would fail, as there are no rows present.
This seems to be a case of a wider range of things where people refer or rely on the size of the data, or generally anything regarding the original DF they provide.
One could argue that it is bad design to write a custom grid/table like that, but the confusion of the user showed that people simply do not expect the data to be different at any point from what they originally provide

Do we know how other tools deal with this? e.g. do they load in the data in batches? or do they always load in the entire dataset?

So the AgGrid for example has the opportunity to enable batch loading in infinite scroll, but I think that defeats a little bit the point. In principle we are not converned with loading the entire data, that is what we do anyway once the page loads with all filters/parameters etc. It is simply this initial building that immediately gets overwritten.
Ideally we would want to just create an entirely different loading component (like for graph), but it has been shown (see comment above the build lines in both table and grid) that having different settings for the objects causes problems (the case we observed was the pagination setting). Remember the long discussion we had where you said, just write "Do not change this line" :). So this is related to that.

Thanks for clarifying!

I would like to review this so please don't merge yet 🙂