TimeStamp ConvertToUtc not working

Hi,
I'm struggling with setting my timestamp column to UTC time. Can you guys see any issue with this code?
private static ColumnOptions GetColumnOptions()
{
    var columnOptions = new ColumnOptions
    {
        Store = new Collection<StandardColumn>(),
        TimeStamp =
        {
            ConvertToUtc = true,
            ColumnName = "Created"
        },
        AdditionalDataColumns = new Collection<DataColumn>
        {
            new DataColumn
            {
                DataType = Type.GetType("System.DateTime"),
                ColumnName = "Created",
                AllowDBNull = false
            },
            .............
        }
    };
    return columnOptions;
}

Now I have refactored the code, but still aint getting the UTC timezone 🙁
private static ColumnOptions GetColumnOptions()
{
    var columnOptions = new ColumnOptions
    {
        Store = new Collection<StandardColumn>
        {
            StandardColumn.TimeStamp,
        },
        TimeStamp =
        {
            ConvertToUtc = true,
            ColumnName = "Created"
        },
        ...........
    };
    return columnOptions;
}

Ended up solving it like this:
_logger = _logger.ForContext("Created", DateTime.Now.ToUniversalTime())

This sounds like a bug, let's leave this open. #86 might be related.

@jansoren I'm trying to triage/fix old bugs.
The two configurations you posted won't compile. Timestamp has a private setter, so you can't reference it in your initializer code, it has to be initialized by a member of the same class (the constructor, in this case).
Was that what you meant by "not working"?

The posted code isn't valid and the OP indicated he pursued a different solution, so closing this one out.

Is it possible to set the Timestamp column in UTC?  Is this still a bug?

@brianbarnett316 Yes, it works. I have added tests to the project that ensure timestamp UTC conversion. Please make sure to use 5.1.4 or a newer version of the sink and you have to take care  that the data type of your SQL server table column matches the datatype you have configured in the column options. If there is a mismatch you run into troubles as explained here:
https://github.com/serilog/serilog-sinks-mssqlserver#timestamp

Thanks @ckadluba.  Where can I find what has changed between 5.1.3 and 5.1.4?

https://github.com/serilog/serilog-sinks-mssqlserver/releases

If I wanted to keep the datatype as DateTime, does the ConvertToUtc option work?  This is what I would like to use.

Yes, it should work. If you have any problems with this, please attach your code and config that produces the problem and any further details as specified in the issue template.
https://github.com/serilog/serilog-sinks-mssqlserver/blob/dev/.github/ISSUE_TEMPLATE.md

I am unable to get ConvertToUTC working when trying to format the Timestamp for the MSSqlServer sink.
Currently I have the following versions of Serilog installed:
Serilog - 3.1.1
Serilog.AspNetCore - 8.0.1
Serilog.Settings.Configuration - 8.0.0
Serilog.Sinks.MSSqlServer - 6.6.0
I'm using .NET Framework 7
Here is my json config:
"Serilog": {
  "MinimumLevel": "Warning",
  "Using": [
    "Serilog.Sinks.Console",
    "Serilog.Sinks.File",
    "Serilog.Sinks.MSSqlServer"
  ],
  "WriteTo": [
    { "Name": "Console" },
    {
      "Name": "File",
      "Args": {
        "outputTemplate": "{Timestamp:yyyy-MM-dd HH:mm:ss.fff zzz} [{Level}] {Message}{NewLine}{Exception}",
        "path": "C:\\Temp\\ewms-log-.txt",
        "rollingInterval": "Day",
        "retainedFileCountLimit": "10"
      }
    },
    {
      "Name": "MSSqlServer",
      "Args": {
        "connectionString": "<myConn>",
        "tableName": "Logs"
      },
      "restrictedToMinimumLevel": "Error",
      "columnOptionsSection": {
        "timeStamp": {
          "columnName": "TimeStamp",
          "convertToUtc": true
        }
      }
    }

  ]
}

With this configuration there is no Utc conversion being done.
Any help would be VERY appreciated. Thank you!

Hello @BryanKwiat!
Can you provide a simple but complete sample application to demonstrate your problem?

Hello @BryanKwiat!
Can you provide a simple but complete sample application to demonstrate your problem?

I cannot provide a sample application unfortunately. But I can show you that it's logging, so I know that Serilog is working in general, just not converting the date.

The last entry was at 13:14, which is the server time of 1:14 PM, which is the non-UTC time.

Is your server creating those log entries doing so using the utc timezone?

Those entries are the Server Time, not UTC.

Which timezone is configured on the server machine?

It's set to UTC-03:00 Salvador. I don't have control over that though because they're managed by the VM System Admin.

UTC is not about formatting a timestamp (e.g. how it is written) at all. UTC is a timezone.

For what it's worth:
UTC is not a timezone. GMT is the +0 timezone, UTC is the time without any timezone information. Big difference, data-wise.

I just want to convert from 1:14 PM UTC-3:00 to UTC

So, to be clear. The server timezone is UTC-3:00. It writes a log entry at 1:14 PM in its local time. If you enable ConvertToUtc it should actually write 4:14 PM UTC to the database. But it still writes 1:14 PM. Do I understand this correct?

Yes, correct.
On Thu, Feb 29, 2024 at 3:50 AM Christian Kadluba @.***>
wrote:

I just want to convert from 1:14 PM UTC-3:00 to UTC
So, to be clear. The server timezone is UTC-3:00. It writes a log entry at
1:14 PM in its local time. If you enable ConvertToUtc it should actually
write 4:14 PM UTC to the database. But it still writes 1:14 PM. Do I
understand this correct?
—
Reply to this email directly, view it on GitHub
https://github.com/serilog-mssql/serilog-sinks-mssqlserver/issues/87#issuecomment-1970677848,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BGRDNGA2XBF5U7UEXGJMXPLYV3VVZAVCNFSM4DP4VIKKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJXGA3DONZYGQ4A
.
You are receiving this because you were mentioned.Message ID:
@.***>

I just tried to reproduce your issue with the program in samples/WorkerServiceDemo. First I used it with the default appsettings.json.
"timeStamp": {
  "columnName": "Timestamp",
  "convertToUtc": false
},

The timestamps show 23:18 which is my local time (UTC+1:00).

Then I changed the settings.
"timeStamp": {
  "columnName": "Timestamp",
  "convertToUtc": true
},

When I ran the program with convertToUtc: true, the timestamps show the UTC time (22:20). In the LogEvent column you can see the corresponding timestamp also in the local time (23:20).

This is the schema of the logevents table.

The ConvertToUtc setting works as expected. I cannot reproduce your problem using the sample app.

Strange. I don’t know what I’m doing wrong? Can I see where in the
appsettings you’re putting it? Maybe I’ve got it in the wrong place?
On Thu, Feb 29, 2024 at 5:30 PM Christian Kadluba @.***>
wrote:

I just tried to reproduce your issue with the program in
samples/WorkerServiceDemo. First I used it with the default
appsettings.json.
"timeStamp": {
"columnName": "Timestamp",
"convertToUtc": false
},
The timestamps show 23:18 which is my local time (UTC+1:00).
grafik.png (view on web)
https://github.com/serilog-mssql/serilog-sinks-mssqlserver/assets/10721825/7b993c68-4bf5-4b9a-8846-ec78939c73a8
Then I changed the settings.
"timeStamp": {
"columnName": "Timestamp",
"convertToUtc": true
},
When I ran the program with convertToUtc: true, the timestamps show the
UTC time (22:20). In the LogEvent column you can see the corresponding
timestamp also in the local time (23:20).
grafik.png (view on web)
https://github.com/serilog-mssql/serilog-sinks-mssqlserver/assets/10721825/1042d11a-113d-4848-b086-101f9ecb2e67
This is the schema of the logevents table.
grafik.png (view on web)
https://github.com/serilog-mssql/serilog-sinks-mssqlserver/assets/10721825/55cd0d66-478f-4156-b540-cd8813aae8d4
The ConvertToUtc setting works as expected. I cannot reproduce your
problem using the sample app.
—
Reply to this email directly, view it on GitHub
https://github.com/serilog-mssql/serilog-sinks-mssqlserver/issues/87#issuecomment-1972080978,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BGRDNGHM63KC2YGPAEIPCBTYV6VZHAVCNFSM4DP4VIKKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJXGIYDQMBZG44A
.
You are receiving this because you were mentioned.Message ID:
@.***>

Sure!
{
  "Logging": {
    "LogLevel": {
      "Default": "Information",
      "Microsoft": "Warning",
      "Microsoft.Hosting.Lifetime": "Information"
    }
  },
  "Serilog": {
    "Using": [ "Serilog.Sinks.MSSqlServer" ],
    "MinimumLevel": "Debug",
    "WriteTo": [
      {
        "Name": "MSSqlServer",
        "Args": {
          "connectionString": "Server=localhost;Database=LogTest;Integrated Security=SSPI;Encrypt=False;",
          "sinkOptionsSection": {
            "tableName": "LogEvents",
            "autoCreateSqlDatabase": true,
            "autoCreateSqlTable": true,
            "useSqlBulkCopy": false
          },
          "restrictedToMinimumLevel": "Information",
          "columnOptionsSection": {
            "addStandardColumns": [ "LogEvent", "TraceId", "SpanId" ],
            "removeStandardColumns": [ "MessageTemplate", "Properties" ],
            "timeStamp": {
              "columnName": "Timestamp",
              "convertToUtc": true
            },
            "additionalColumns": [

Thank you! It’s a mystery why it’s not working. I believe I have all the latest nuget packages installed. Bryan KwiatkowskiSoftware EngineerWWC Global, a Pequot @.*** more about The Pequot Community of Companies at: commandholdingspqt.comOn Feb 29, 2024, at 5:37 PM, Christian Kadluba @.***> wrote:
Sure!
{
"Logging": {
"LogLevel": {
"Default": "Information",
"Microsoft": "Warning",
"Microsoft.Hosting.Lifetime": "Information"
}
},
"Serilog": {
"Using": [ "Serilog.Sinks.MSSqlServer" ],
"MinimumLevel": "Debug",
"WriteTo": [
{
"Name": "MSSqlServer",
"Args": {
"connectionString": "Server=localhost;Database=LogTest;Integrated Security=SSPI;Encrypt=False;",
"sinkOptionsSection": {
"tableName": "LogEvents",
"autoCreateSqlDatabase": true,
"autoCreateSqlTable": true,
"useSqlBulkCopy": false
},
"restrictedToMinimumLevel": "Information",
"columnOptionsSection": {
"addStandardColumns": [ "LogEvent", "TraceId", "SpanId" ],
"removeStandardColumns": [ "MessageTemplate", "Properties" ],
"timeStamp": {
"columnName": "Timestamp",
"convertToUtc": true
},
"additionalColumns": [
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Can you run your program locally on your developer machine to rule out a misconfiguration of the timezone setting on the server?


e.config is not iterable

Does this occur consistently?
Repro steps:

Action: azureVirtualMachines.openInRemoteSsh
Error type: TypeError
Error Message: e.config is not iterable
Version: 0.3.0
OS: darwin
OS Release: 20.1.0
Product: Visual Studio Code
Product Version: 1.52.1
Language: en

Call Stack
extension.bundle.js:209:105977
fulfilled extension.bundle.js:209:105181
processTicksAndRejections task_queues.js:94:5

Could you please provide repro steps?
Also could you try hitting F1 >Remote-SSH: Open Configuration File and confirm that you have a config file for your .ssh folder?

So I first added a SSH key, and then clicked "connect to host via remote ssh".
Yes, I have a config file and I can use "Remote-SSH: connect to host..." to login to the VM, but I cannot connect to it by right click and then  "connect to host via remote ssh" directly.

Could you let me know what version of Remote-SSH that you're using?  And then try updating the extension if you are out of date?

The version is v0.65.1. Since I just started using it and everything was installed recently, it's not very likely that it is out of date.

Okay, thanks for confirming.  I just wanted to verify because they added parameters to the Remote-SSH: connect to host command recently in this PR: https://github.com/microsoft/vscode-remote-ssh/commit/85ad8193c3bdbf65ab494c1771f6fd0166298498

@nturinski there's only one place we reference .config in our code, so this should be pretty easy to investigate: https://github.com/microsoft/vscode-azurevirtualmachines/blob/main/src/commands/openInRemoteSsh.ts#L34

Hi! not sure if this helps, but I bumped into the same issue.

Hi @itchingpixels and @Jing25
We just released an update to the extension that should resolve this problem!  Please update and let me know if you run into any other issues 😊
Happy coding 🎉


changed logging level from info to debug to avoid server normal behav…

…ior going into other logging tools (like fluentd servers).
Please @amhester, @bradserbu, @juankinetica, @PedroKinetica, take a look at this!
I'm changing the log level to avoid sending internal nodus information to logstash (when we configure lumberjack in nodus).

ok, fine by me

Looks good to me :+1:

so changing all info to debug so it doesn't go to lumberjack,  im cool with it :dancer:


chore: upgrade qwik to latest

Upgraded qwik to latest.
There's a bug with rendering the app in cypress due to a modified path to the @vite asset. It was working by accident before, but stopped after this PR https://github.com/BuilderIO/qwik/pull/5234. Until this is properly fixed on the qwik side, we need to patch the @builder.io/qwik package so that __cypress/src/@vite/ asset path is also recognized (simply modified the regex to match the whole pathname instead of its beginning)
Additionally removed the pnpm workspace configuration so that all dependencies are managed from the root package.json. Right now there's a mess with versions of dependencies, daisyui even has different major versions specified.

Thanks @dmitry-stepanenko ! 🙏


KSECURITY-2360 KAFKA-16210: Update jose4j to 0.9.4 (#15284)

Cherrypick https://github.com/confluentinc/kafka/pull/1103

Following failed. DistributedHerderTest fails locally even again 3.4. Rest all are flakes.


Error when trying to acquire a credential.

Hello, I have been testing the OID4VCI libraries with the issuer front-end available at: https://ssi.sphereon.com/demo/issuer.
I have been trying to request a demo credential (Sphereon Guest Credential) following the guide about  OpenID4VCI Client.
Every step goes smoothly until I try to acquire the credential. The error I am encountering is the following:
Error: Retrieving a credential from https://ssi.sphereon.com/pf3/credentials for issuer https://ssi.sphereon.com/pf3 failed with status: 500
I'll let the code I am using in case I am forgetting something.
const client = await OpenID4VCIClient.fromURI({ uri: uri, clientId: 'test-clientID' })
const metadata = await client.retrieveServerMetadata()

//2. Adquire acces token from authorization server endpoint
const accessToken = await client.acquireAccessToken({})

//3. Create DID needed for later proof of possession
const { keys, didDocument } = await did.jwk.generate({
  type: 'secp256k1', // 'P-256', 'P-384', 'X25519', 'secp256k1'
  accept: 'application/did+json',
  secureRandom: () => {
    return crypto.randomBytes(32)
  },
})
const edPrivateKey = await jose.importJWK(keys[0].privateKeyJwk)

async function signCallback(args: Jwt, kid?: string): Promise<string> {
  if (!args.payload.aud) {
    throw Error('aud required')
  } else if (!kid) {
    throw Error('kid required')
  }
  return await new jose.SignJWT({ ...args.payload })
    .setProtectedHeader({ alg: args.header.alg })
    .setIssuedAt(+new Date())
    .setIssuer(kid)
    .setAudience(args.payload.aud)
    .setExpirationTime('2h')
    .sign(edPrivateKey)
}

const callbacks: ProofOfPossessionCallbacks<DIDDocument> = {
  signCallback: signCallback,
}

const credentialResponse = await client.acquireCredentials({
  credentialTypes: 'GuestCredential',
  proofCallbacks: callbacks,
  format: 'jwt_vc_json',
  alg: Alg.ES256K,
  kid: didDocument.verificationMethod[0].id,
  jti: v4(),
})
console.log(credentialResponse.credential)

The URI value I am using is generated when a credential option is selected and a QR code is generated. I simply copy the URL and insert it into the code. The URL always looks like this: openid-credential-offer://?credential_offer=%7B%22grants%22%3A%7B%22urn%3Aietf%3Aparams%3Aoauth%3Agrant-type%3Apre-authorized_code%22%3A%7B%22pre-authorized_code%22%3A%22wzUetZE7ytnS8n4ZwbLHwG%22%2C%22user_pin_required%22%3Afalse%7D%7D%2C%22credentials%22%3A%5B%22GuestCredential%22%5D%2C%22credential_issuer%22%3A%22https%3A%2F%2Fssi.sphereon.com%2Fpf3%22%7D

Hi @ismapolis
I have been looking into your issue. You can see your code incorporated into a test here: https://github.com/Sphereon-Opensource/OID4VCI/blob/9f4eca6130a045e20999506c1ded96abddcd9f41/packages/client/lib/tests/SphereonE2E.spec.test.ts#L119
The above code also automatically creates a new offer, so you do not have to copy paste anything ;)
First of all probably good for you to know for next time is that you can include the following line to get more information about any errors and/or payloads:
debug.enable('*')
// or debug.enable('sphereon:*')

Then you would get this response payload on your console:
sphereon:openid4vci:http error status: 500, body:
  sphereon:openid4vci:http {"error":"invalid_request","error_description":"invalid_jwt: JWT not valid yet (issued in the future) iat:<PHONE_NUMBER>145"}

The issue is that in your code you are using +new Date() for the issuedAt value, but that should be devided by 1000 (seconds vs milliseconds) for JWTs. If you just call it with setIssuedAt() it will automatically use current date
After fixing that some small other errors occured which had to do with some values in the JWT sign callback missing. You need to provide a kid header as well as set the correct typ ('openid4vci-proof+jwt')


iOS 7 compatibility

I use this library on iOS 7. Everything works except the NSCalendar.dateByAddingUnit: method is unavailable on iOS 7. I implemented a NSCalendar.dateByAddingDuration: extension method to fallback to NSCalendar.dateByAddingComponents: when required, otherwise it will just use NSCalendar.dateByAddingUnit:

@mattijsf Thank you for great job!

@mattijsf I have released 0.2.2!


Handle better inf with p parameter in SqPNorm

Fixes #178

Handles p=1.0 for SqPNorm (tested and also added to pointclouds notebook.
Allows p=1.0 for PNorm but fails when applying transport, which requires Legendre transform.

Codecov Report

Merging #189 (67fbf4c) into main (c00bc12) will decrease coverage by 7.05%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
- Coverage   89.26%   82.20%   -7.06%
==========================================
  Files          51       52       +1
  Lines        5234     5243       +9
  Branches      529      531       +2
==========================================
- Hits         4672     4310     -362
- Misses        434      785     +351
- Partials      128      148      +20

Impacted Files
Coverage Δ

src/ott/_version.py
77.77% <ø> (ø)

src/ott/geometry/epsilon_scheduler.py
83.33% <ø> (ø)

src/ott/geometry/geometry.py
88.88% <ø> (ø)

src/ott/geometry/graph.py
81.81% <ø> (ø)

src/ott/geometry/low_rank.py
95.00% <ø> (ø)

src/ott/geometry/pointcloud.py
71.09% <ø> (ø)

src/ott/geometry/segment.py
62.22% <ø> (ø)

src/ott/initializers/linear/initializers.py
95.78% <ø> (ø)

src/ott/initializers/linear/initializers_lr.py
92.48% <ø> (ø)

src/ott/initializers/nn/initializers.py
91.13% <ø> (ø)

... and 74 more


added some animations

I added some subtle animations on the buttons using Framer motion.

This looks great! Are you adding animations for the cards too?

Hey @janaSunrise I added for the cards before but the cards are getting out of the screen :(

Ahh, Got it. No issues 😁

Hey @max-programming I have added the changes requested :)

@avneesh0612 This is great! Thanks!

@all-contributors please add @avneesh0612 for design


Version number typo correction

Proposed changes
Corrected a minor typo.
Unreleased project version (optional)

Related issues (optional)

Thanks, @ibnesayeed :)


bench job uses a deprecated Node.js version

https://github.com/tauri-apps/tauri/actions/runs/10675496915


As a developer, I want the SQL database on Azure, so it's production ready

Text from lecture:
See for example this guide: https://learn.microsoft.com/en-us/azure/azure-sql/database/single-database-create-quickstart?view=azuresql&tabs=azure-portal
Configure your Chirp! applications that are deployed to Azure App Service, i.e., your applications in production, to target this Azure SQL database.
The name of your database server is bdsagroup-chirpdb, where  is replaced with your group number.
Remember to configure your Azure SQL Server to use SQL Login with a username and password to use for your connection string.
Note: The demo using Entra ID Groups and Managed Identity is not posible with your Azure Subscription on the ITU tenant. This is why we switch back to legacy SQL Login.
Acceptance criteria:

The database is on a database server on Azure.
The name of the database server is bdsagroup1-chirpdb

all criteria are fulfilled


server: move register_global to EventLoopHandle

Coverage remained the same at 49.357% when pulling fca7e9cd4ec73f69bdf56ef382bad785d92ceb2a on vberger:master into 263c0af97ea6a0eb2b4616bef11a0138001d7df4 on Smithay:master.

Coverage remained the same at 49.357% when pulling fca7e9cd4ec73f69bdf56ef382bad785d92ceb2a on vberger:master into 263c0af97ea6a0eb2b4616bef11a0138001d7df4 on Smithay:master.

Coverage remained the same at 49.357% when pulling fca7e9cd4ec73f69bdf56ef382bad785d92ceb2a on vberger:master into 263c0af97ea6a0eb2b4616bef11a0138001d7df4 on Smithay:master.


Move to ESLint external config "eslint-config-xo-space" ?

What do you think about use https://github.com/sindresorhus/eslint-config-xo-space  who extends eslint-config-xo with two spaces indentation ?

I believe we discussed this early on in the switch to ESLint and XO wasn't going to work for us.  I forget the exact reasons but you can probably track down the comments.


Generated css declares fonts multiple times (Roboto, NotoSans)

Note: for support questions, please use one of these channels:
https://forum.ionicframework.com/
http://ionicworldwide.herokuapp.com/
Short description of the problem:
Generated app.md.css and app.wp.css (the only ones the reference external fonts, have the font declarations repeated 21 times each inflating the file size, especially if you want to embed some of the smaller font files as data-urls.
What behavior are you expecting?
Each font-face should be declared only once.
Steps to reproduce:

Create a v2 ionic app
Build it
Check out the generated CSS.

I believe the culprit is the use of @at-root in default.wp.scss and default.md.scss. I don't think node-sass (on which gulp-sass depends) understands it.
// Noto Sans Font
@at-root {
  @import "../fonts/noto-sans";
}

I
Other information: (e.g. stacktraces, related issues, suggestions how to fix, stackoverflow links, forum links, etc)
Which Ionic Version? 1.x or 2.x
2.x
Run ionic info from terminal/cmd prompt: (paste output below)

@jimitndiaye Good Catch! Thanks for pointing this out!

Thank you for finding this! It was caused by importing the global mode file in each component. I removed these imports from all of the components and confirmed it only includes the fonts once now. This will be fixed in the beta.5 release. Thanks again! :smile:

So since we want to be able to individually import components, the globals file needs to be imported in each component. I've reverted the previous commit and instead moved the font import up to the components.<mode>.scss file.

The latest change, while reducing the problem (down to 5 references to Roboto, for instance), did not eliminate it. Still my app.md.css has gone down to 946 KB (down from over 7 MB) so my thanks for that.

I am only seeing 4, one for each font-weight:
@font-face {
  font-family: "Roboto";
  font-style: normal;
  font-weight: 300;
  src: local("Roboto Light"), local("Roboto-Light"), url("../fonts/roboto-light.ttf") format("truetype"), url("../fonts/roboto-light.woff") format("woff"); }

@font-face {
  font-family: "Roboto";
  font-style: normal;
  font-weight: 400;
  src: local("Roboto"), local("Roboto-Regular"), url("../fonts/roboto-regular.ttf") format("truetype"), url("../fonts/roboto-regular.woff") format("woff"); }

@font-face {
  font-family: "Roboto";
  font-style: normal;
  font-weight: 500;
  src: local("Roboto Medium"), local("Roboto-Medium"), url("../fonts/roboto-medium.ttf") format("truetype"), url("../fonts/roboto-medium.woff") format("woff"); }

@font-face {
  font-family: "Roboto";
  font-style: normal;
  font-weight: 700;
  src: local("Roboto Bold"), local("Roboto-Bold"), url("../fonts/roboto-bold.ttf") format("truetype"), url("../fonts/roboto-bold.woff") format("woff"); }

Are you seeing something different?


Broken Link Pass

Using: http://www.deadlinkchecker.com/

So... just curious why are we keeping 2.x documentation?
It's missing critical security updates, if anything we want people to move to the latest version rather than helping them stay on the out-of-date build...

@esethna I think we can remove the 2.x documentation now.
@it33 that was back from when we had to do all those large v3.0 changes and you asked for us to keep a link for people still on v2.x.

+1 once comments are addressed.

Updated

Holding off on merging this PR as it might cause conflicts with some larger community PRs being reviewed right now.

+1


Line Breaks And Comments Not Preserved Correctly Outside

Line breaks and comments are not preserved correctly, see below.
 You can disable pretty-printing in the output to get closer to the original text - but that's not what jsoup is about.

@jhy thank you for your response. Let me add some explanation for this. First, I am talking about the case with pretty-printing disabled so to get the output closer to the original. Second, please look closer to the output, then you see the positions of comments are wrong for  and . Comment positions are crucial because some tools use comments to mark things. For example, Adobe DreamWeaver uses  to mark library items, and  to mark used templates. So I wish Jsoup will output them correctly.


Dxlevel

hi if it's not too much to ask, can you make the cheat support dxlevel 81?

just lower your gamma

hm

thanks

I'm saying that the cheat does not support dxlevel 81

and so far they haven't removed the cheat detection and when i inject it it still comes all unconfigured

I'm saying that the cheat does not support dxlevel 81

why are you even using dxlevel below 90?
at this point the cheat should have a notification, whenever someone has dxlevel below 90

I'm saying that the cheat does not support dxlevel 81

why are you even using dxlevel below 90? at this point the cheat should have a notification, whenever someone has dxlevel below 90

This would be smart. It's not super obvious what went wrong unless you know about dxlevels in the first place

when i inject fedoraware it comes with everything disabled

yesterday he was normal

when i inject fedoraware it comes with everything disabled

Should probably be its own issue, but yeah i also experience this

when i inject fedoraware it comes with everything disabled

its because baan changed every var to be disabled by default in this commit
just make your own config and save it

no


Applied fixes from StyleCI

This pull request applies code style fixes from an analysis carried out by StyleCI.

For more information, click here.

Coverage remained the same at 78.378% when pulling 2da629cdeefd985257f0471a769f17971d16471b on analysis-qvyx9O into 025e666a341b82569500dfca2b21500a45d57632 on master.

Coverage remained the same at 78.378% when pulling 2da629cdeefd985257f0471a769f17971d16471b on analysis-qvyx9O into 025e666a341b82569500dfca2b21500a45d57632 on master.


Wrapping strategies for function calls

I would like to define the formatting strategy for function calls. It does not currently exist in the style guide
Basic idea
Method 1:
very_long_module_name::this_is_a_really_long_function(arg1,
                                                      arg2,
                                                      arg3,
                                                      "this is a raw s\
                                                       tring and is ter\
                                                       ible")

should instead be Method 2:
very_long_module_name::this_is_a_really_long_function(
    arg1, arg2, arg3,
    "this is a raw string and is terible")

rustfmt currently uses the Method 1 way too often. I'm not sure the right balance here. Like @joshtriplett said in #47   , you really want to define "simple". IMO "simple" would be:

If the function and all args fit within the line length, just do that.
Otherwise use Method 1 if Method 1 only takes up two lines
Otherwise use Method 2:

arguments always start on their own indented line
arguments are listed normally as long as they don't go over the line length limit
any argument that would go over the line length limit goes on it's own line
anything over 25 characters goes on it's own line

Dup of #65


Package restored failed for PCL targetting .NET46 & UWP

Hi, I cannot install the System.Reactive package into PCL targetting .NET46 & UWP:
Version conflict detected for System.Collections.
ClassLibrary1 (>= 1.0.0) -> System.Reactive (>= 3.0.0) -> System.Reactive.PlatformServices (>= 3.0.0) -> System.Collections (>= 4.0.11)
ClassLibrary1 (>= 1.0.0) -> Microsoft.NETCore.Portable.Compatibility (>= 1.0.0) -> Microsoft.NETCore.Runtime (>= 1.0.0) -> Microsoft.NETCore.Runtime.CoreCLR-x86 (>= 1.0.0) -> System.Collections (= 4.0.10).
System.Reactive.Interfaces 3.0.0 is not compatible with .NETPlatform,Version=v5.0.
System.Reactive.Core 3.0.0 is not compatible with .NETPlatform,Version=v5.0.
System.Reactive.Linq 3.0.0 is not compatible with .NETPlatform,Version=v5.0.
System.Reactive.PlatformServices 3.0.0 is not compatible with .NETPlatform,Version=v5.0.
Some packages are not compatible with .NETPlatform,Version=v5.0.
Package restore failed for 'ClassLibrary1'.
Package restore failed. Rolling back package changes for 'ClassLibrary1'.
Any ideas?

Installing Rx-main works fine

Hi @bezysoftware, you need at least the 5.2.0 UWP metapackage to use any .NET Core/NET Standard libraries. My guess is that you have either 5.0.0 or 5.1.0.
Unfortunately, they had to delist the 5.2.0 package due to a couple of bugs. There's a tracking issue here: https://github.com/dotnet/cli/issues/3189 and the referenced issues do have workarounds. I believe they'll have a fix out soon (5.2.1?)

I see, you are right, I tried upgrading to latest UWP package (5.1.0) but that didn't help :) Didn't know 5.2.0 was pulled, thanks for letting me know

The UWP 5.2.1 package has been pushed to NuGet.org. Closing this out now, please re-open if there's still an issue.

This works now in projects targeting UWP alone, but in a PCL targeting UWP + NET4.6 I'm still not able to install this.
Restoring packages for 'ClassLibrary1'.
Restoring packages for c:\users\bezysoftware\documents\visual studio 15\Projects\ClassLibrary1\ClassLibrary1\project.json...
Version conflict detected for System.Collections.
ClassLibrary1 (>= 1.0.0) -> System.Reactive (>= 3.0.0) -> System.Reactive.PlatformServices (>= 3.0.0) -> System.Collections (>= 4.0.11)
ClassLibrary1 (>= 1.0.0) -> Microsoft.NETCore.Portable.Compatibility (>= 1.0.0) -> Microsoft.NETCore.Runtime (>= 1.0.0) -> Microsoft.NETCore.Runtime.CoreCLR-x86 (>= 1.0.0) -> System.Collections (= 4.0.10).
System.Reactive.Interfaces 3.0.0 is not compatible with .NETPlatform,Version=v5.0.
System.Reactive.Core 3.0.0 is not compatible with .NETPlatform,Version=v5.0.
System.Reactive.Linq 3.0.0 is not compatible with .NETPlatform,Version=v5.0.
System.Reactive.PlatformServices 3.0.0 is not compatible with .NETPlatform,Version=v5.0.
Some packages are not compatible with .NETPlatform,Version=v5.0.
System.Linq.Expressions 4.1.0 provides a compile-time reference assembly for System.Linq.Expressions on DNXCore,Version=v5.0, but there is no run-time assembly compatible with win7-x86.
System.Linq 4.1.0 provides a compile-time reference assembly for System.Linq on DNXCore,Version=v5.0, but there is no run-time assembly compatible with win7-x86.
System.Net.NetworkInformation 4.0.0 provides a compile-time reference assembly for System.Net.NetworkInformation on DNXCore,Version=v5.0, but there is no run-time assembly compatible with win7-x86.
System.Text.RegularExpressions 4.1.0 provides a compile-time reference assembly for System.Text.RegularExpressions on DNXCore,Version=v5.0, but there is no run-time assembly compatible with win7-x86.
Some packages are not compatible with DNXCore,Version=v5.0 (win7-x86).
System.Linq.Expressions 4.1.0 provides a compile-time reference assembly for System.Linq.Expressions on DNXCore,Version=v5.0, but there is no run-time assembly compatible with win7-x64.
System.Linq 4.1.0 provides a compile-time reference assembly for System.Linq on DNXCore,Version=v5.0, but there is no run-time assembly compatible with win7-x64.
System.Net.NetworkInformation 4.0.0 provides a compile-time reference assembly for System.Net.NetworkInformation on DNXCore,Version=v5.0, but there is no run-time assembly compatible with win7-x64.
System.Text.RegularExpressions 4.1.0 provides a compile-time reference assembly for System.Text.RegularExpressions on DNXCore,Version=v5.0, but there is no run-time assembly compatible with win7-x64.
Some packages are not compatible with DNXCore,Version=v5.0 (win7-x64).
Package restore failed for 'ClassLibrary1'.
Package restore failed. Rolling back package changes for 'ClassLibrary1'.
========== Finished ==========

If the PCL package targets 4.5.1 + UWP it works

Can you post your project.json file? Something is wrong in it as there shouldn't be any dnxcore50 references in it anymore.

{
"supports": {
"net46.app": {},
"uwp.10.0.app": {}
},
"dependencies": {
"Microsoft.NETCore": "5.0.0",
"Microsoft.NETCore.Portable.Compatibility": "1.0.0"
},
"frameworks": {
"dotnet": {
"imports": "portable-net452+win81"
}
}
}
This is what it looks like right after creating the PCL project

That looks like the "old" PCL project template. I'll file a bug/blog about the fact you really shouldn't be using this method anymore.
My suggestion is to right-click the project and click the "Target .NET Platform Standard" instead. You can use 1.3 for net46+ or net 1.4 for .net 4.6.1+. Either support UWP.
Then, remove the contents of the supports section and make sure to use the netstandard.library 1.6.0 metapackage.
In your UWP project, use the 5.2.2 version of the UWP package to use any netstandard-based library.

Ok, but how does it then work with libs which don't target netstandard? (e.g. Lex.db, mvvm light libs...)
I found out I can simply add an imports section into my project.json  which allows to pkg to install, but is that the right thing to do?

Adding an imports statement is usually the wrong thing to do -- it's there as an escape hatch/compatibility mechanism.
What are you trying to do?

That was more a general question - as a lib author, what are my options when I want to switch to netstandard, but some of the packages I depend on are not targeting netstandard, only old PCL profiles.
One such lib I have is FirebaseDatabase.net - for streaming changes I use Rx, for offline data persistence I use Lex.DB (EF feels like an overkill, I need something super simple, which Lex.DB is). Currently it is a PCL lib, but I would like to target netstandard, but can't because lex.DB doesn't have netstandard versiom (yet).

But as for the original combination of UWP + NET46 - I use this in my apps to make the common platform-independent parts unit-testable in a traditional Unit Test Project, which targets .net 4.6. Otherwise I would have to use the UWP Test Project which cannot use any of the mocking frameworks

To answer your issue, it's still the wrong set of targets/based off an old template. I'd recommend creating a new portable class library project and then switching it to a .NET Standard based PCL (there's no file->new template for it). Be sure to use the regular portable class library project type, not the .NET Core specific ones (your project file should be a csproj).
My blog post has details:
https://oren.codes/2016/06/23/portable-is-dead-long-live-netstandard/
From there, you can reference your project from any compatible project type -- UWP can target NET Standard 1.4 and earlier; .NET 4.6 can do 1.3 (.net 4.6.1 can do 1.4).
For your UWP project, just make sure you use the 5.2.2 version of the Microsoft.NETCore.UniversalWindowsPlatform package as that's the one required when using .net standard-based libraries.


[Tests] Deno requires gid access

https://github.com/CycloneDX/cdxgen/actions/runs/6209670942/job/16857151302#step:28:3615
 Deno requests sys access to "gid".
├ Requested by `Deno.gid()` API.
├ Run again with --allow-sys to bypass this prompt.

The below line could be updated to add the missing permission
https://github.com/CycloneDX/cdxgen/blob/master/ci/Dockerfile-deno#L73
--allow-sys=uid,systemMemoryInfo,gid

PR: https://github.com/CycloneDX/cdxgen/pull/563

Thank you so much! If you use the word "Fixes" etc., in the comment, the associated issue would automatically get closed.


How to hide back button on Embedded Sending View

Hi all,
Is it possible to somehow hide the back button on 'Embedded Sending View' when using CreateSenderView method?

No, since the back button is controlled by the browser.
Instead of embedding the entire sending view, you can implement the features needed by your sending use case and enable the sender to use your application exclusively.
Unfortunately this isn't practical if your senders need to tag the documents with fields.
What is your use case?
PS. This type of question is best asked on StackOverflow using the docusignapi tag

Thank you @LarryKlugerDS for your answer.
I got your idea, but unfortunately, our use case is that the end-user uploads the document and should be able to specify exactly the place where a sign should be. For this, we are using tagging experience in embedded flow.
In detail, our use case is simple: upload a new document, then specify a place for tags and send. Then other users (for whom were sent the document) will be able to sign it. All these operations happen inside our app.

Thank you for the follow-up, @disist ,
We have an enhancement request in our system that would cover your use case. Please ask your DocuSign contact to add your company information to enhancement EC-1868. That will help raise the feature's priority.

Thank you @LarryKlugerDS for the answer and ticket creation.
Let me clarify a bit of what " back button" is, that be on the same page

Is it correct on your side and in ticket (EC-1868) description?

Thank you @LarryKlugerDS for the answer and ticket creation.
Let me clarify a bit of what " back button" is, that be on the same page

Is it correct on your side and in ticket (EC-1868) description?

Hi @disist ,
Thank you for the added information.
Yes, the EC-1868 ticket should still cover your use case. The goal is to enable developers to select the specific features of the Send / Edit workflows that they want to enable their users to have access too.
In your use case, you want the user to just be able to "tag" the document with the location of the signing fields, right?
Thanks,
Larry

Hi @disist ,
I have similar use case as yours.
I have one question.
I am redirecting to url https://demo.docusign.net/Member/StartInSession.aspx?StartConsole=1&t=8c3c6e18-cba4-4c2e-be54-bf49700d20d5&DocuEnvelope=69508f28-9bcd-4f8e-ba53-9bcaf92c2d25&send=1
then it automatically redirected to https://appdemo.docusign.com/prepare/69508f28-9bcd-4f8e-ba53-9bcaf92c2d25 but I want to one step forward to  https://appdemo.docusign.com/prepare/69508f28-9bcd-4f8e-ba53-9bcaf92c2d25/add-fields .
And after user set the sign location and click on send then automatically close this.
Is there anyway to implement this?
If you have any POC code can you please share with me?
Thanks,
Sunil

You want to open the sending view in the tagger? And then return to your application?
Checkout the code examples with workflow 11.
The API call is https://developers.docusign.com/esign-rest-api/reference/Envelopes/EnvelopeViews/createSender
The code example is https://github.com/docusign/code-examples-csharp

Hi LarryKlugerDS,
Thanks you very much for quick turnaround.
My use case is exactly same as Disist's.
I want to open sending in an iFrame then as soon as user click on send button, I should close the iFrame with the response.
I followed below process:
await envelopesApi.CreateConsoleViewAsync(accountId,null);
I got URL in response as https://demo.docusign.net/Member/StartInSession.aspx?StartConsole=1&t=f6d342dc-ac96-4195-a3a4-bd9871b4e1ba
Then I called await envelopesApi.CreateEnvelopeAsync(accountId, envelopeDefinition);
Here I got envelopeID then I combined both responses and created new URL as below and added in iFrame https://demo.docusign.net/Member/StartInSession.aspx?StartConsole=1&t=f6d342dc-ac96-4195-a3a4-bd9871b4e1ba&DocuEnvelope=2d168f33-3789-465e-9316-37f9ed0a0345&send=1
Now I got redirected to below page but I want to get to next page which come when you click on next button.

Then Final page as below where user add fields and click SEND after this I want to close this iFrame and get response.

Thanks,

Hi LarryKlugerDS,
Thanks you very much I am able to achieve above functionality.
Now just issue to disable back button.
Is this fixed?
or is there any proposed deadline for this?
Thanks,
Sunil


Update github actions.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.84%. Comparing base (0262682) to head (d64499e).
Report is 35 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   71.47%   73.84%   +2.36%
==========================================
  Files          21       20       -1
  Lines         887      864      -23
  Branches      103       98       -5
==========================================
+ Hits          634      638       +4
+ Misses        188      161      -27
  Partials       65       65

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Solo.io/updating portal plugin

Hey, I just made a Pull Request!
This is an update to the Gloo Platform Portal plugin's repository link.
:heavy_check_mark: Checklist

[ ] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[X] All your commits have a Signed-off-by line in the message. (more info)

Thanks :tada:


Copy Directory implemenation causing an error

Could you please provide Copy directory method implementation to copy from folder1 to folder2 in same ftp remote server.
When tried to copy folder in remote server paths it worked for few files and later encounter with errors such as below
i.e timeout trying to read data from socket
And also getting an error sometimes : unable to read the data from  transport connection and an existing connection forcibly closed by remote host when having multiple files from folder
I kindly request your assistance in providing a resolution for this matter.
I tried to implement like below code:
copy directory implementation:
_ftpClient is IAsyncFtpClient .
await ConnectAsync()
await CopyFilesRecursivelyAsync(sourceRemotePath, destRemoatePath, CancellationToken cancellationToken = default)
private async Task CopyFilesRecursivelyAsync(string sourcePath, string destinationPath, CancellationToken cancellationToken = default)
{
var files = await _ftpClient.GetListing(sourcePath, token: cancellationToken).ConfigureAwait(false);
foreach (var file in files)
{
if (file.Type == FtpObjectType.File)
{
// Copy  file from the source remote server to the destination remote server
var destinationFilePath = Path.Combine(destinationPath, file.Name);
using (var sourceStream = await _ftpClient.OpenRead(file.FullName))
using (var destinationStream = await _ftpClient.OpenWrite(destinationFilePath)) // tried with uploadstream as well
{
await sourceStream.CopyToAsync(destinationStream);  // error after sometime timeout issue
}
}
else if (file.Type == FtpObjectType.Directory)
{
// Create the directory on the destination server
var destinationDirPath = Path.Combine(destinationPath, file.Name);
if (!await IsDirectoryExistsAsync(destinationDirPath).ConfigureAwait(false))
await CreateDirectoryAsync(destinationDirPath).ConfigureAwait(false); ;
			await CopyFilesRecursivelyAsync(file.FullName, destinationDirPath).ConfigureAwait(false);
		 }
	  }
   }

Good idea.

I have also tried with two ftpClients i.e source and destination remote client servers
Below code works fine for around 50 files (each 60kb approx) of total 150 files and failed remaining files.
Error encounterd is "### Timed out trying to read data from the socket stream")
please let me know which property to increase timeout to avoid this error.
I kindly request your assistance in providing a resolution for this matter.
Implemented code with two ftpclients:
using IAsyncFtpClient ftpClient1 = new AsyncFtpClient(ftpServer, username, password);
using IAsyncFtpClient ftpClient2 = new AsyncFtpClient(ftpServer, username, password);
if (!ftpClient1.IsConnected)
{
await ftpClient1.Connect();
//Also setting setworking directory
}
if (!ftpClient2.IsConnected)
{
await ftpClient2.Connect();
//Also setting setworking directory
}
await CopyFilesRecursivelyAsync(ftpClient1, ftpClient2,remoteSourceDirPath, remoteDestDirPath).ConfigureAwait(false);
private async Task CopyFilesRecursivelyAsync(IAsyncFtpClient asyncFtpClient1, IAsyncFtpClient asyncFtpClient2, string sourcePath, string destinationPath)
{
var files = await asyncFtpClient1.GetListing(sourcePath).ConfigureAwait(false);
foreach (var file in files)
{
if (file.Type == FtpObjectType.File)
{
// Copy  file from the source remote server to the destination remote server
### 	 var destinationFilePath = Path.Combine(destinationPath, file.Name);
await using (var sourceStream = await asyncFtpClient1.OpenRead(file.FullName).ConfigureAwait(false))
{
await asyncFtpClient2.UploadStream(sourceStream, destinationFilePath, existsMode: FtpRemoteExists.Overwrite, createRemoteDir: true).ConfigureAwait(false);
};
	  }
	  else if (file.Type == FtpObjectType.Directory)
	  {
		 // Create the directory on the destination server
		 var destinationDirPath = Path.Combine(destinationPath, file.Name);
		 if (!await asyncFtpClient1.DirectoryExists(destinationDirPath).ConfigureAwait(false))
			await asyncFtpClient1.CreateDirectory(destinationDirPath).ConfigureAwait(false); ;
		 await CopyFilesRecursivelyAsync(asyncFtpClient1, asyncFtpClient2,file.FullName, destinationDirPath).ConfigureAwait(false);
	  }
   }
}

And also getting an error sometimes : unable to read the data from transport connection and an existing connection forcibly closed by remote host when having multiple files from folder

Please provide a verbose log of this error.

Error Logs: Hoping it might help below logs
FluentFTP.Exceptions.FtpException: Error while uploading the file to the server. See InnerException for more info.
---> System.AggregateException: Additional error occured while trying to resume uploading the file 'ftpfolder/dev/invoices-staging/bvk/copy3/20230704_28_SCC CSV file.8/Invoice4198.pdf' at position 0 (Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host..) (Malformed PASV response: 0)
---> System.IO.IOException: Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host..
---> System.Net.Sockets.SocketException (10054): An existing connection was forcibly closed by the remote host.
at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.CreateException(SocketError error, Boolean forAsyncThrow)
at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ReceiveAsync(Socket socket, CancellationToken cancellationToken)
at System.Net.Sockets.NetworkStream.ReadAsync(Byte[] buffer, Int32 offset, Int32 count, CancellationToken cancellationToken)
at FluentFTP.FtpSocketStream.ReadAsync(Byte[] buffer, Int32 offset, Int32 count, CancellationToken token)
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at FluentFTP.FtpSocketStream.ReadAsync(Byte[] buffer, Int32 offset, Int32 count, CancellationToken token)
at FluentFTP.FtpDataStream.ReadAsync(Byte[] buffer, Int32 offset, Int32 count, CancellationToken token)
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at FluentFTP.FtpDataStream.ReadAsync(Byte[] buffer, Int32 offset, Int32 count, CancellationToken token)
at FluentFTP.AsyncFtpClient.UploadFileInternalAsync(Stream fileData, String localPath, String remotePath, Boolean createRemoteDir, FtpRemoteExists existsMode, Boolean fileExists, Boolean fileExistsKnown, IProgress1 progress, CancellationToken token, FtpProgress metaProgress)    at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)    at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread)    at System.Runtime.CompilerServices.TaskAwaiter.<>c.<OutputWaitEtwEvents>b__12_0(Action innerContinuation, Task innerTask)    at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining)    at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)    at System.Threading.Tasks.Task1.TrySetResult(TResult result)
at FluentFTP.AsyncFtpClient.OpenWrite(String path, FtpDataType type, Int64 fileLen, CancellationToken token)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread)
at System.Runtime.CompilerServices.TaskAwaiter.<>c.b__12_0(Action innerContinuation, Task innerTask)
at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining)
at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)
at System.Threading.Tasks.Task1.TrySetResult(TResult result)    at FluentFTP.AsyncFtpClient.OpenDataStreamAsync(String command, Int64 restart, CancellationToken token)    at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)    at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread)    at System.Runtime.CompilerServices.TaskAwaiter.<>c.<OutputWaitEtwEvents>b__12_0(Action innerContinuation, Task innerTask)    at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining)    at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)    at System.Threading.Tasks.Task1.TrySetResult(TResult result)
at FluentFTP.AsyncFtpClient.OpenPassiveDataStreamAsync(FtpDataConnectionType type, String command, Int64 restart, CancellationToken token)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread)
at System.Runtime.CompilerServices.TaskAwaiter.<>c.b__12_0(Action innerContinuation, Task innerTask)
at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining)
at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)
at FluentFTP.AsyncFtpClient.Execute(String command, CancellationToken token)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread)
at System.Runtime.CompilerServices.TaskAwaiter.<>c.b__12_0(Action innerContinuation, Task innerTask)
at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining)
at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)
at FluentFTP.AsyncFtpClient.GetReplyAsyncInternal(CancellationToken token, String command)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread)
at System.Runtime.CompilerServices.TaskAwaiter.<>c.b__12_0(Action innerContinuation, Task innerTask)
at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining)
at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)
at FluentFTP.AsyncFtpClient.GetReplyAsyncInternal(CancellationToken token, String command, Boolean exhaustNoop, Int32 timeOut)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread)
at System.Runtime.CompilerServices.TaskAwaiter.<>c.b__12_0(Action innerContinuation, Task innerTask)
at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining)
at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)
at System.Threading.Tasks.Task1.TrySetResult(TResult result)    at FluentFTP.FtpSocketStream.ReadLineAsync(Encoding encoding, CancellationToken token)    at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)    at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread)    at System.Runtime.CompilerServices.TaskAwaiter.<>c.<OutputWaitEtwEvents>b__12_0(Action innerContinuation, Task innerTask)    at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining)    at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)    at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.SetExistingTaskResult(Task1 task, TResult result)    at FluentFTP.FtpSocketStream.ReadAsync(Byte[] buffer, Int32 offset, Int32 count, CancellationToken token)    at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)    at System.Runtime.CompilerServices.AsyncTaskMethodBuilder1.AsyncStateMachineBox1.MoveNext(Thread threadPoolThread)    at System.Runtime.CompilerServices.TaskAwaiter.<>c.<OutputWaitEtwEvents>b__12_0(Action innerContinuation, Task innerTask)    at System.Threading.Tasks.AwaitTaskContinuation.RunOrScheduleAction(Action action, Boolean allowInlining)    at System.Threading.Tasks.Task.RunContinuations(Object continuationObject)    at System.Threading.Tasks.Task1.TrySetResult(TResult result)
at System.Threading.Tasks.ValueTask1.ValueTaskSourceAsTask.<>c.<.cctor>b__4_0(Object state)    at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.InvokeContinuation(Action1 continuation, Object state, Boolean forceAsync, Boolean requiresExecutionContextFlow)
at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.OnCompleted(SocketAsyncEventArgs _)
at System.Threading._IOCompletionCallback.PerformIOCompletionCallback(UInt32 errorCode, UInt32 numBytes, NativeOverlapped* pNativeOverlapped)
--- End of stack trace from previous location ---
--- End of inner exception stack trace ---
at FluentFTP.FtpSocketStream.ReadAsync(Byte[] buffer, Int32 offset, Int32 count, CancellationToken token)
at FluentFTP.FtpDataStream.ReadAsync(Byte[] buffer, Int32 offset, Int32 count, CancellationToken token)
at FluentFTP.AsyncFtpClient.UploadFileInternalAsync(Stream fileData, String localPath, String remotePath, Boolean createRemoteDir, FtpRemoteExists existsMode, Boolean fileExists, Boolean fileExistsKnown, IProgress1 progress, CancellationToken token, FtpProgress metaProgress)    --- End of inner exception stack trace ---    at FluentFTP.AsyncFtpClient.ResumeUploadAsync(String remotePath, Stream upStream, Int64 remotePosition, IOException ex, CancellationToken token)    at FluentFTP.AsyncFtpClient.UploadFileInternalAsync(Stream fileData, String localPath, String remotePath, Boolean createRemoteDir, FtpRemoteExists existsMode, Boolean fileExists, Boolean fileExistsKnown, IProgress1 progress, CancellationToken token, FtpProgress metaProgress)
---> (Inner Exception #1) FluentFTP.Exceptions.FtpException: Malformed PASV response: 0
at FluentFTP.Client.BaseClient.BaseFtpClient.GetPassivePort(FtpDataConnectionType type, FtpReply reply, String& host, Int32& port)
at FluentFTP.AsyncFtpClient.OpenPassiveDataStreamAsync(FtpDataConnectionType type, String command, Int64 restart, CancellationToken token)
at FluentFTP.AsyncFtpClient.OpenDataStreamAsync(String command, Int64 restart, CancellationToken token)
at FluentFTP.AsyncFtpClient.OpenAppend(String path, FtpDataType type, Int64 fileLen, CancellationToken token)
at FluentFTP.AsyncFtpClient.ResumeUploadAsync(String remotePath, Stream upStream, Int64 remotePosition, IOException ex, CancellationToken token)<---

we are using ftpserver with this WS_FTP PRO (IP SWITCH)

Great! Thanks.
Look at the log - right very near the beginning:
...
...
Command:  STOR WebsiteTestFiles/dev/Invoices-staging/bvk/copy3/20230704_28_VK CSV file.8/Invoice4196958.pdf
Status:   Waiting for response to: STOR WebsiteTestFiles/dev/Invoices-staging/bvk/copy3/20230704_28_VK CSV file.8/Invoice4196958.pdf
Response: 150 Uploading in BINARY file WebsiteTestFiles/dev/Invoices-staging/bvk/copy3/20230704_28_VK CSV file.8/Invoice4196958.pdf [69ms]
Status:   Uploaded 82872 bytes
Status:   Closing/Disposing FtpSocketStream(data connection)
Status:   Waiting for response to: STOR WebsiteTestFiles/dev/Invoices-staging/bvk/copy3/20230704_28_VK CSV file.8/Invoice4196958.pdf
Response: 226 Transfer completed [252ms]
Status:   Closing/Disposing FtpSocketStream(data connection)

# OpenRead("/non-prod-ftp/WebsiteTestFiles/dev/Invoices-staging/bvk/copy1/20230704_28_VK CSV file.8/Invoice4197082.pdf", Binary, 0, 0)

# GetFileSize("/non-prod-ftp/WebsiteTestFiles/dev/Invoices-staging/bvk/copy1/20230704_28_VK CSV file.8/Invoice4197082.pdf", -1)
Status:   Socket has stale data - prior to command execution
Status:   The stale data was:
Stale:    226 Transfer completed
Warning:  Reconnect needed due to stale data present on control connection
Status:   Command stashed: SIZE /non-prod-ftp/WebsiteTestFiles/dev/Invoices-staging/bvk/copy1/20230704_28_VK CSV file.8/Invoice4197082.pdf
Status:   Closing/Disposing FtpSocketStream(control connection)

# Connect(True)
Warning:  Reconnect (Count: 193)
Status:   FluentFTP <IP_ADDRESS>(.NET 6.0)
Status:   Connecting to IP #1= ***:21
Status:   Waiting for a response
Response: 220 ftp.server.biz X2
...
...

Ok, the log is not from the beginning. I can see the following things that worry me:
Status:   Socket has stale data - prior to command execution
This happens often, so many reconnects (many, this one is number 193) later on in the log.
I think I see a possible problem here but need to research it.
There is a 226 Transfer completed from the previous RETR command that is not being waited for correctly.
I will check this for a while. I wonder what is causing this. Perhaps I will have special "tests" for you to perform in order to find out about this - I hope you will be able to do that.
Note: Of course an API for copying a directory would be a nice enhancement. But your implementation should also work and not fail with this error.

See also #1242 Same problem, same solution

@FanDjango ,
Thank you for your prompt response.
As suggested, I will remove the obsolete OpenRead and try using the download code provided below.
 await using (var sourceStream = await asyncFtpClient1.OpenRead(file.FullName).ConfigureAwait(false))
			 {
				await asyncFtpClient2.UploadStream(sourceStream, destinationFilePath, existsMode: FtpRemoteExists.Overwrite, createRemoteDir: true).ConfigureAwait(false);
			 };

You must also replace the OpenRead with DownloadStream, it is also obsolete.


Update relayer_operation_instructions.md

added scripts to the path to dev-env

For contributor use:

[ ] Updated the Unreleased section of CHANGELOG.md with the issue.
[ ] If applicable: Unit tests written, added test to CI.
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Updated relevant documentation (docs/) and code comments.
[ ] Re-reviewed Files changed in the Github PR explorer.

my error it was already there,

my error it was already there,


[SPARK-24391][SQL] Support arrays of any types by from_json

What changes were proposed in this pull request?
The PR removes a restriction for element types of array type which exists in from_json for the root type. Currently, the function can handle only arrays of structs. Even array of primitive types is disallowed. The PR allows arrays of any types currently supported by JSON datasource. Here is an example of an array of a primitive type:
scala> import org.apache.spark.sql.functions._
scala> val df = Seq("[1, 2, 3]").toDF("a")
scala> val schema = new ArrayType(IntegerType, false)
scala> val arr = df.select(from_json($"a", schema))
scala> arr.printSchema
root
 |-- jsontostructs(a): array (nullable = true)
 |    |-- element: integer (containsNull = true)

and result of converting of the json string to the ArrayType:
scala> arr.show
+----------------+
|jsontostructs(a)|
+----------------+
|       [1, 2, 3]|
+----------------+

How was this patch tested?
I added a few positive and negative tests:

array of primitive types
array of arrays
array of structs
array of maps

Test build #91189 has started for PR 21439 at commit b601a93.

Can one of the admins verify this patch?

Test build #91189 has finished for PR 21439 at commit b601a93.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91189/
Test FAILed.

Test build #91191 has finished for PR 21439 at commit 02a97ac.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91191/
Test PASSed.

better to add tests in json-functions.sql?

Can we also accept primitive arrays in to_json?

cc @gengliangwang

Test build #91350 has started for PR 21439 at commit 9d0230a.

Test build #91350 has finished for PR 21439 at commit 9d0230a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91350/
Test FAILed.

retest this please.

Test build #91356 has started for PR 21439 at commit 9d0230a.

@maropu For now it is impossible to specify schema for from_json if it is not StructType. The PR https://github.com/apache/spark/pull/21472 solves the problem.

Test build #91356 has finished for PR 21439 at commit 9d0230a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91356/
Test PASSed.

What kind of tests would you expect in json-functions.sql. Probably you would expect tests
that are different from added to JsonExpressionsSuite.scala.
IIUC there is no strict rule there and we tend to put SQL related tests in SQLQueryTestSuite.

Can one of the admins verify this patch?

Test build #91668 has started for PR 21439 at commit e321e37.

Test build #91668 has finished for PR 21439 at commit e321e37.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91668/
Test PASSed.

Merged build finished. Test PASSed.

@maropu I need changes from this PR https://github.com/apache/spark/pull/21550 (or this https://github.com/apache/spark/pull/21472) to write SQL tests for ArrayType

@maropu @gengliangwang I added SQL tests. Please, take a look at the PR again, please.

Test build #91874 has started for PR 21439 at commit ce9918b.

Test build #91874 has finished for PR 21439 at commit ce9918b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91874/
Test PASSed.

@maropu @gengliangwang May I ask you to look at the PR one more time.

Test build #92480 has started for PR 21439 at commit fced8ec.

Test build #92708 has finished for PR 21439 at commit f3efb1b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92708/
Test PASSed.

@gatorsmile May I ask you to look at the PR.

@gatorsmile Could you tell me, please, what does prevent the PR from getting merged?

I guess it is still controversial to have this new behavior with the new option.

I set the option to the value which keep current behavior. So, it should be absolutely compatibly with current implementation

Test build #92981 has started for PR 21439 at commit 82d4fd5.

Test build #92986 has started for PR 21439 at commit 758d1df.

Test build #92986 has finished for PR 21439 at commit 758d1df.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92986/
Test PASSed.

@gatorsmile @gengliangwang @maropu The change doesn't break existing behavior. I set new option to the value which preserve backward compatibly. The PR just extend existing implementation and supports arrays of any types. May I ask you to look at the PR again.

Test build #93393 has started for PR 21439 at commit 2746d35.

Test build #93396 has started for PR 21439 at commit bc3a2dd.

Test build #93393 has finished for PR 21439 at commit 2746d35.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93393/
Test PASSed.

Merged build finished. Test PASSed.

Test build #93396 has finished for PR 21439 at commit bc3a2dd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93396/
Test PASSed.

How does it relate to https://github.com/apache/spark/pull/19492?

Test build #93499 has started for PR 21439 at commit 39a0a4e.

Test build #93499 has finished for PR 21439 at commit 39a0a4e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93499/
Test PASSed.

Test build #93734 has started for PR 21439 at commit 021350b.

Test build #93734 has finished for PR 21439 at commit 021350b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/93734/
Test PASSed.

Is there anything for now which blocks the PR?

@gatorsmile @HyukjinKwon May I ask you to look at the PR one more time.

@HyukjinKwon Are there any chances the PR will be merged? or I should close it?

@gatorsmile Could you look at the PR, please.

LGTM

Test build #94655 has started for PR 21439 at commit 74a7799.

Test build #94655 has finished for PR 21439 at commit 74a7799.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94655/
Test FAILed.

retest this please

Test build #94659 has finished for PR 21439 at commit 74a7799.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94659/
Test FAILed.

retest this please.

Test build #94666 has started for PR 21439 at commit 74a7799.

LGTM too.

Test build #94666 has finished for PR 21439 at commit 74a7799.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94666/
Test FAILed.

retest this please

Test build #94677 has started for PR 21439 at commit 74a7799.

Test build #94677 has finished for PR 21439 at commit 74a7799.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94677/
Test FAILed.

retest this please

Test build #94680 has started for PR 21439 at commit 74a7799.

Test build #94680 has finished for PR 21439 at commit 74a7799.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94680/
Test PASSed.

Merged to master.

I think R side is not update for this yet. @huaxingao would you like to do that?

Sure. I will work on it. Thanks for letting me know. @viirya


first-timers-only: Add test spec to make sure named variables only match single words

first-timers-only
This issue is tagged first-timers-only. It is only for people who have never contributed to open source before, and are looking for an easy way take their first steps.
Thank you for your help :heart:
The Issue
The test specs do not currently test to make sure commands with named variables (e.g. annyang.addCommands({'Time for some :description heroics': myFunction});) only match a single word.
Named variables should match any sentence with exactly one word replacing the named variable (e.g. :description), such as: 'Time for some thrilling heroics', but not 'Time for some thrilling and fun heroics' or 'Time for some heroics'
The tests described inside describe("annyang.addCommands", function() {…}); in test/spec/BasicSpec.js include a number of tests for other uses of addCommands(), and should be used as a template for your code.
Add a test spec that tests that the following code matches the correct commands only: annyang.addCommands({'Time for some :description heroics': function() {}});
It should be very similar to the test spec for it('should match commands with named variables')
Contributing to annyang

[x] Fork the repository from the annyang GitHub page.
[x] Clone a copy to your local machine with $ git clone git@github.com:YOUR-GITHUB-USER-NAME/annyang.git
[x] Make sure you have node.js and npm installed on your machine. You can use this guide for help.
[x] Install all of annyang's development dependencies with npm. $ cd annyang; npm install
[x] Run grunt to make sure everything runs smoothly $ grunt
[x] Code, code, code.
[x] Run $ grunt after making changes to verify that everything still works and run the build process. Alternatively, you can just run $ grunt watch once, and leave that process running. It will continuously run all the tests and build the files every time you make a change to one of annyang's files. It will even beep if you make an error, and help you debug it.:+1:
[x] Before committing your changes, the last step must always be running $ grunt. This makes sure everything works, and all files are kept up to date with your changes.
[x] Once you've made sure all your changes work correctly, and committed all your changes, push your local changes back to github with $ git push -u origin master
[x] Visit your fork on GitHub.com (https://github.com/YOUR-USER-NAME/annyang) and create a pull request for your changes.
[x] Makes sure your pull request describes exactly what you changed and references this issue (just include the issue number in the title like this: #49)

About the tests
annyang is tested using Jasmine.
BasicSpec.js contains a series of spec groups (e.g. describe('a spec group', function() {})) which each contain 1 or more specs (e.g. it('should do stuff', function() {})). Some of the spec groups also contain some code which runs before each spec (beforeEach(function() {})).
To simulate Speech Recognition in the testing environment, annyang uses a mock object called Corti which mocks the browser's SpeechRecognition object. Corti also adds a number of utility functions to the SpeechRecognition object which simulate user actions (e.g. say('Hello there')), and allow checking the SpeechRecognition's status (e.g. isListening() === true).

I would like to pick it up. Will update you with results tomorrow.

Great! Let me know if you need any help.

Fixed by @evaldosantos in #151


Do not define to Board type here.

This type is already defined in the file board.go

Note: Before this is merged we should check whether the type should be provided in that file or whether it should be part of the solution the student writes. (Depends on how the tests are set up etc.)


Smooth scrolling not supported everywhere

Need to test on mobile and on Safari

https://developer.mozilla.org/en-US/docs/Web/API/Element/getBoundingClientRect

https://github.com/thebuilder/react-intersection-observer is the best


Enable the use of self-hosted LLMs

This PR introduces several fixes and features that enable the use of other, open-ai api compatible, LLMs such as those served by the Ollama framework.
Most notably:

Make use of the api endpoint
Add a --dry-run option to exec that prints the answer without executing it
Enable setting up the system prompts through env var & cli arg

@artivis thanks 👍 you are the 1st contributor 🥇 i will definitely look at the fix.

@artivis i added the minor patch to fix the problem with verification.sh script. after building, verification for all container images, i will take this in.


chore: update packages

Just keeping packages up to date. Tests pass locally.

Looks like deploy is failing on netlify's node version 10:12:44 AM: error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "^12.22.0 || ^14.17.0 || >=16.0.0". Got "12.18.0"

@ivanoats Thank you for your contribution! I appreciate it! I just had to rename the .nvmrvc file that you made to .nvmrc for Netlify to pick it up correctly. Hope you don't mind! : )

@ivanoats Thank you for your contribution! I appreciate it! I just had to rename the .nvmrvc file that you made to .nvmrc for Netlify to pick it up correctly. Hope you don't mind! : )

Haha, thanks so much. My eyes are not always reliable 👀


Initial support of writable_search from quickfix

Related to #6.
So, at the moment it just allows to call writable_search#Parse() from quickfix window and it will properly create new buffer with writable_search.
I'm not really happy with the code (it seems hacky to me). I just wanted to show the progress and hear your thoughts on this.
P.S. Includes some slight refactoring of parser which makes diff noisy :)

I think it looks pretty good so far. The parsing seems to work, although updating the lines doesn't change the original. But I guess you're probably working on that next :). I also very much appreciate the tests, keep up the good work :).

@AndrewRadev Thanks, I'll get back with updates soon.

I'm a little bit confused about how to make file save working. It seems to me that I have to define b:command to make ftplugin work correctly, but it's hacky to me.
Do you have any suggestions on how to implement it or refactor existing code?

Hmm, I definitely think some restructuring is in order.
One problem I run into immediately is that parent_buffer is not the buffer of the original file, but the writable search buffer. I should think of either renaming it or documenting it a bit. Probable the former, "parent_buffer" doesn't really seem right now that I think about it. Maybe I need a word for that. "Common buffer"? "Result buffer"? I'm open to suggestions.
However, fixing this means taking the new writable search buffer's id. But, in the quickfix example, running writable_search#Parse() needs to first run the parsing code, and then open a new buffer. So it's a bit of a chicken and egg situation.
In the "normal" path, I think this is the sequence of events:

:WritableSearch -- the main entry point
writable_search#Start(query, count) -- this takes a query and prepares it for the command (or uses a default)
s:NewBuffer() -- opens a new empty buffer (only if it's not already in a result buffer)
s:Grep(query) -- runs the query
writable_search#Parse() -- parses the result buffer and renders the new, parsed result. Basically a wrapper for:
let b:proxies = writable_search#parser#Run(), followed by
writable_search#Render()

For the quickfix case, you've modified the writable_search#parser#Run() function (or its helper functions, actually), and this looked fine to me to begin with, but now I realize it's probably a bad idea. The parser expects to be in a buffer with the grep results already there.
So, I think we need a new, parallel branch of code that runs the quickfix stuff. First of all, we don't need #Start(), since that takes a search query, and we don't need that. So maybe it could work like this:

:WritableSearchFromQuickfix -- the main entry point (maybe with a different name, or maybe :WritableSearch in the quickfix buffer could trigger this?)
s:NewBuffer()
writable_search#ParseQuickfix(), which calls:
let b:proxies = writable_search#quickfix#Parse(), followed by
writable_search#Render()

I don't like the slightly inconsistent naming -- writable_search#parser#Run vs writable_search#quickfix#Parse, so maybe writable_search#quickfix_parser#Run? Not sure, I'd appreciate your thoughts on this.
In any case, I think if you move the contents of the helper method to their own file, and you make a new function #ParseQuickfix, which is almost identical to #Parse (maybe with different names), that could work out.
What do you think?

I've already said that the code is pretty hacky, so the restructuring you propose will eliminate that. I'll try to do that and will let you know once it's ready.
Thanks for your comment!

Hello again :). I've managed to add quickfix support myself at some point (finally got around to it!). Because of this, I guess I'll close the PR for the moment. Thank you very much for your work regardless, it pushed me to put in the effort, if nothing else. And I definitely like the functionality myself :).

Thank you for adding this feature, it's really useful!


ci(node): Updated actions to use node 14

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


How can I integrate the touch?

Hello!
The html5 draggable is used here.
You can try to find a polyfill, which can be included during the export.

archived


I am curious about the cause of Unity mujoco crash.

hello. After installing the mujoco plugin in Unity, I was able to load the model successfully, but a crash occurred while playing, the engine shut down, and I was able to check the following log. Could you possibly predict what could be the cause using this log?
=================================================================
Managed Stacktrace:
  at <unknown> <0xffffffff>
  at Mujoco.MujocoLib:mj_defaultVFS <0x000db>
  at Mujoco.MjVfs:.ctor <0x0017a>
  at Mujoco.MjEngineTool:LoadModelFromString <0x000ba>
  at Mujoco.MjScene:CompileScene <0x000da>
  at Mujoco.MjScene:CreateScene <0x00d32>
  at Mujoco.MjScene:Start <0x000a2>
  at System.Object:runtime_invoke_void__this__ <0x00187>

=================================================================

Can you try loading the model in simulate and see if you still get the crash?

It works fine in the simulator.

The crash phenomenon has disappeared. The cause seems to be that the crash occurred because the simulator version was not set to 3.2.0 when applying version 3.2.0 this time.


Set the default value of NODE_ENV to production when building with Vite

Closes: #8364
When building using remix vite:build in v2.4.1, NODE_ENV is set to development, increasing the build size.
So, I modified the default value of NODE_ENV to be production when building with vite.

Interesting find! I think this fix (forcing process.env.NODE_ENV on Remix side) would make sense on its own, but I investigated a little deeper so let me share as an extra context.
First, this doesn't seem to happen when running directly vite build (i.e. it gives jsx-runtime-NroC4D4D.js 8.09 kB like in your 2nd screenshot) (Also relevant Vite doc https://vitejs.dev/guide/env-and-mode.html#node-env-and-modes), so I was looking at what's happening in remix vite:build.
It looks like when when Remix calls vite.resolveConfig for internal purpose before doing vite.build here:
https://github.com/remix-run/remix/blob/438a9b3abc068306c78508388e68cf20ad1d7cae/packages/remix-dev/vite/build.ts#L28-L31
Vite seems to force process.env.NODE_ENV = defaultNodeEnv where defaultNodeEnv is development in this case:
https://github.com/vitejs/vite/blob/19e3c9a8a16847486fbad8a8cd48fc771b1538bb/packages/vite/src/node/config.ts#L417
Once this happens, following vite.build would end up with process.env.NODE_ENV replaced by "development" for client bundling even if mode is "production", which is done by Vite's internal vite:define plugin here https://github.com/vitejs/vite/blob/5684fcd8d27110d098b3e1c19d851f44251588f1/packages/vite/src/node/plugins/define.ts#L18-L23
I think alternative fix would be to set 3rd/4th argument for defaultMode and defaultNodeEnv like:
let viteConfig = await vite.resolveConfig(
    { mode, configFile, root },
    "build",
    "production",
    "production"
  )

I verified this by patching remix locally and it gives jsx-runtime-NroC4D4D.js 8.09 kB.

@doinki Thanks for raising this issue, and thanks @hi-ogawa for digging into this. I've just merged #8365 which implements the fix suggested above since it ensures that the Vite config is resolved in the correct context.


[BEAM-8424] Prevent Java 11 VR tests from timeouting

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

R: @Ardagan , @boyuanzz
Could you take a look? I am changing the timeout values of all dataflow VR tests and keeping them equal for Java11 equivalents (that wasn't the case).
I'm also not sure if this is ok that the tests sometimes take more than 4 hours. Typically they take about 3h -  3h 30min. I imagine that this might be cumbersome for devs to wait that long but maybe this is the only way... Do you think we should mitigate this somehow?

Run seed job

R: @Ardagan , @boyuanzz
Could you take a look? I am changing the timeout values of all dataflow VR tests and keeping them equal for Java11 equivalents (that wasn't the case).
I'm also not sure if this is ok that the tests sometimes take more than 4 hours. Typically they take about 3h - 3h 30min. I imagine that this might be cumbersome for devs to wait that long but maybe this is the only way... Do you think we should mitigate this somehow?

Thanks for handling that! From my understanding, it should be okay for a PostCommit test running that long. We can merge it first to prevent timeout issue. For further work, we could discuss more on whether we want to split this test target in order to decrease test time.

Sounds good. Thanks!


Use the normal hyperkube image in integration tests

It seems we're using an image Dug manually built with just kubectl in it for these tests, but it's a manually updated image and super out of date. Now that we're not running on Travis anymore it should be fine to just pull the latest hyperkube image and use that

docker run -it --rm duglin/kubectl version
Client Version: version.Info{Major:"1", Minor:"6+", GitVersion:"v1.6.6-dirty", GitCommit:"7fa1c1756d8bc963f1a389f4a6937dc71f08ada2", GitTreeState:"dirty", BuildDate:"2017-06-30T12:23:06Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}

Pretty good compatibility.

/lifecycle frozen

all that code was related to the api-server which is not used anymore and it was removed by this PR: https://github.com/kubernetes-sigs/service-catalog/pull/2720


Move HostProcessReloadHandler to the correct package

I noticed this while looking at the other OSHs in the "deployment" package.

Linux Build 1613 is now running using a merge of a9eea1c336173ab880676bb320d7f0dc14268900

Windows Build 1257 is now running using a merge of a9eea1c336173ab880676bb320d7f0dc14268900

Core - Full Integration Build 864 is now running using a merge of a9eea1c336173ab880676bb320d7f0dc14268900

Windows Build 1257 outcome was SUCCESS using a merge of a9eea1c336173ab880676bb320d7f0dc14268900
Summary: Tests passed: 3108, ignored: 66 Build time: 0:20:58

Linux Build 1613 outcome was FAILURE using a merge of a9eea1c336173ab880676bb320d7f0dc14268900
Summary: Tests failed: 1 (1 new), passed: 3107, ignored: 66 Build time: 0:23:28
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.domain.AdminOnlyModeTestCase.testAdminOnlyMode: <no details avaliable>

Core - Full Integration Build 864 outcome was SUCCESS using a merge of a9eea1c336173ab880676bb320d7f0dc14268900
Summary: Tests passed: 2858, ignored: 414, muted: 1 Build time: 0:48:56

retest this please

Linux Build 1626 is now running using a merge of a9eea1c336173ab880676bb320d7f0dc14268900

Windows Build 1266 is now running using a merge of a9eea1c336173ab880676bb320d7f0dc14268900

Core - Full Integration Build 873 is now running using a merge of a9eea1c336173ab880676bb320d7f0dc14268900

Windows Build 1266 outcome was SUCCESS using a merge of a9eea1c336173ab880676bb320d7f0dc14268900
Summary: Tests passed: 3108, ignored: 66 Build time: 0:20:23

Linux Build 1626 outcome was SUCCESS using a merge of a9eea1c336173ab880676bb320d7f0dc14268900
Summary: Tests passed: 3108, ignored: 66 Build time: 0:22:58

Core - Full Integration Build 873 outcome was FAILURE using a merge of a9eea1c336173ab880676bb320d7f0dc14268900
Summary: Tests failed: 1 (1 new), passed: 2857, ignored: 414, muted: 1 Build time: 0:51:10
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.ejb.remote.jndi.RemoteEJBJndiBasedInvocationTestCase.testRemoteSLSBInvocation: <no details avaliable>


Undesirable redirect to the main branch result when checking a PR

Thank you for the work on current-bench! Here is a small quirk I noticed and I didn't see any report about it.
For one of my PR, here is the link I get to check the benchmarks:
https://autumn.ocamllabs.io/ocaml-ppx/ocamlformat/pull/1609
But clicking on this link redirects to (the main branch):
https://autumn.ocamllabs.io/ocaml-ppx/ocamlformat?worker=autumn&image=ocaml/opam:debian-11-ocaml-4.13
And to go on the results for the relevant PR I have to scroll down the list on the left and click on:
https://autumn.ocamllabs.io/ocaml-ppx/ocamlformat/pull/1609?worker=autumn&image=ocaml/opam:debian-11-ocaml-4.13
Would it be possible to directly go to that page instead?
(As a bonus I would love to have the log to check whether the -99% is due to a failure of ocamlformat or not but I'm sure people already asked for this)

Ah, yes this is not intended!! Thanks for the report @gpetiot!
Also, we have a partial log here: http://autumn.ocamllabs.io:8081/job/2022-01-28/110849-ocluster-build-87cd3f
Does that help at all? We used to have a more comprehensive log, I think we can try to enable that again. Thanks again!

Also, we have a partial log here: http://autumn.ocamllabs.io:8081/job/2022-01-28/110849-ocluster-build-87cd3f Does that help at all? We used to have a more comprehensive log, I think we can try to enable that again. Thanks again!

Thanks I didn't notice this link, I think it could be made more noticeable (e.g. using the same style blue+underline for the link, and personally I think that the name of the build "110849-ocluster-build-87cd3f" only adds some "noise" and is not very useful for the end user, the link could just be named "execution logs").
This log is a bit rough indeed, if there was a more comprehensive log it wouldn't be a bad thing I think, if that doesn't involve too much work for the maintainers of course.
Would it be possible to add an optional field in the JSON object that current-bench expects, e.g. each result item would have the fields {name; metrics; output} (or log), the contents of this last field would just be printed verbatim in the log.

The redirection is fixed by #289 (so it works now :))

Thanks I didn't notice this link, I think it could be made more noticeable (e.g. using the same style blue+underline for the link, and personally I think that the name of the build "110849-ocluster-build-87cd3f" only adds some "noise" and is not very useful for the end user, the link could just be named "execution logs").

Ah yes, a nice idea! I'll open a new issue re. this.

Would it be possible to add an optional field in the JSON object that current-bench expects, e.g. each result item would have the fields {name; metrics; output} (or log), the contents of this last field would just be printed verbatim in the log.

yes this also should be doable! :) Will open another issue re this.
Thanks for all the feedback, we really appreciate it! :)

This log is a bit rough indeed, if there was a more comprehensive log it wouldn't be a bad thing I think, if that doesn't involve too much work for the maintainers of course.

For a long time we did not support debug logs so that's probably why ocamlformat make bench output is so concise... It's now possible to print all the debug information that you need during the execution of make bench (as long as your debug messages doesn't look like json!) This is intended for in depth debugging as you still have to check the logs for investigation.
Regarding adding an output or log field in the json, the individual metrics support a "description" field that might be useful if you wanted to associate a short message to explain the results. The description will show up in the UI near its graph so it's a lot more visible than the output logs (but it also has a lot less room!)
Currently the json produced by ocamlformat looks like:
{
  "results": [
    {
      "name": "ocamlformat numeric:conventional (source.ml)",
      "metrics": {
        "monotonic-clock": 42268412,
        "minor-allocated": 5240680.666666666,
        "major-allocated":<PHONE_NUMBER>3333334
      }
    },
    ...
  ]
}

The extended new format of the json can look like:
{
  "results": [
    {
      "name": "ocamlformat numeric:conventional (source.ml)",
      "metrics": [
        {
          "name": "monotonic-clock",
          "value": 42268412,
          "units": "s",
          "trend": "lower-is-better",
          "description": "A Short Message!"
        },
        ...
      ]
    },
    ...
  ]
}

(The fields units, trend and description are optional)
@gpetiot > Does either of this helps? :)

For a long time we did not support debug logs so that's probably why ocamlformat make bench output is so concise... It's now possible to print all the debug information that you need during the execution of make bench (as long as your debug messages doesn't look like json!) This is intended for in depth debugging as you still have to check the logs for investigation.

Regarding adding an output or log field in the json, the individual metrics support a "description" field that might be useful if you wanted to associate a short message to explain the results. The description will show up in the UI near its graph so it's a lot more visible than the output logs (but it also has a lot less room!)

Great, I will give a try to make make bench more verbose, the description field will probably not be enough, we probably need to check the output of formatted code, or maybe a list of pass/failed checks but that still wouldn't fit in the description.


Updated Setup Lab02

Issue #, if available: Setup Lab02 to be idempotent
Description of changes: To reuse resources if exist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Merge Ruben's updates


[AutoRelease] t2-compute-2024-03-14-04054(can only be merged by SDK owner)

https://github.com/Azure/sdk-release-request/issues/2048
Recording test success
BuildTargetingString
azure-mgmt-compute
Skip.CreateApiReview
true

issue link:https://github.com/Azure/sdk-release-request/issues/2048


[Conversation] allow null value for subject.

Can you use nullOrString instead please? I know I did use the null check somewhere else, don't hesitate to fix it here too :) .

done

Thanks @aitboudad !


[Bug] [chunjun-core] Fix the problem that oss's secret should be hidden

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
当对象存储作为数据源提供服务时，其密码明文显示，需要隐藏。
What you expected to happen
当对象存储作为数据源提供服务时，其密码明文显示，需要隐藏。
How to reproduce
当对象存储作为数据源提供服务时
Anything else
No response
Version
master
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

completed


Incorrect TID T1334.005 changed to T1134.005

uspected SID-History injection (external ID 1106) referenced technique T1334.005 which should be T1134.005.

@batamig
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Thank you for your feedback! I'm tagging an SME to approve this fix.
@danaim1, can you take a look before we merge this PR?

#sign-off


[issue] Shows bug with empty tuple promotion

We ran into this bug in production and I'm not too sure how to fix it. The :send promotes the [] to Array<%bot> and then iterates over the %bot, but in this case it would never enter the block so it should just skip over checking it with an empty tuple. (Our case was obviously more complex but I boiled it down here)

RDL has a notion of "raw" generic types where the parameters are not instantiated. I'm surprised that [] is getting promoted to Array<%bot>. It really should be staying as just Array, I think, and then the each call should somehow ignore the parameters.
I suspect this idea I have about how this should work is not actually fully implemented. I have a feeling it worked in a version a while back but then probably got broken in this way when I beefed up support for generics. I'll try to take a look and think about how this should be implemented.


Set proper owner reference api version

What type of PR is this?
/kind bug
What this PR does / why we need it:
The resource created by the controller do not get cleaned after the cert has been issued and the route is deleted.
Which issue(s) this PR fixes:

Fixes #149
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

/ok-to-test

/approve

/retest

looks like openshift ci has changes log artifacts location so unit job needs https://github.com/openshift/release/pull/17662

https://github.com/openshift/release/pull/17662 merged
/retest


Factory::getEntityWithId()

In policy check, we often need to check if primary key is same or exists in an array
public function canUpdate(IdentityInterface $user, Article $article)
{
    return $user->id == $article->user_id;
}

This PR try to fill primary key even if it's not a persist call.
The second test (getEntitieswitId()fail due toDataCompiler::createPrimaryKeyOffset()` create only id on first entity but i really don't known why :(.

Hi @Erwane ,
thanks for your contribution. I do not think that it is the role of the factories to provide an ID to non-persisted entities.
How does your test involving the canUpdate method look like? It might be able to write it differently. Feel free to open an issue for that.