Add simple example app using apollo react client

Would love to contribute to this. I'm no python expert, but I have a server I'm working on privately that I've generalized to a schema and added a mutation using sqlAlchemy -> graphene -> flask. It just needs subscriptions. As for the client, that is where I can be more of an assistance. As much as it would be easier for me to create a React Native project-- and that would be cool, I think people aren't going follow as easily as a web React. I think we could probably hack it together over a weekend.

Thanks!  I was working on a simple chatapp...could finish it up over a weekend probably, but my priority right now is getting the tests added.   I haven't had much time the last few weeks since I initially published this, but trying to make time to at least start adding tests.  Then shift to the simple app and python 3 integration.  That said...the README includes all the core code for the server and a react component (using apollo client).  That was actually the first component of the chatapp I was going to build.  If you copy that code and build your server, you will have a real-time component (using subscriptions).  I'd be happy to help anyway I can if you want to try a pull request and don't want to wait until I get to the app example.

Great, I'll give it a shot and let you know. One question. How would I replace pubsub with something like mySQL? Thanks.

Cool.  I'll commit the chatapp code this weekend under a dev branch and let you know when that's done.  I'm no Redis expert either, but for this use case, we are only using the pubsub feature--which is internal to the implementation of the subscription service.  For the chatapp model / persistence, I'm using Flask-SqlAlchemy.  Redis on a Mac it is pretty simple (replace Homebrew with particular distro package manager on linux).
Using Homebrew:
$ brew install redis
In a separate process start redis:
$ redis-server
For redis-py:
$ pip install redis
Build you subscription server.

Awesome, thanks. I'm starting to understand the role Redis plays better. I have a few things to attend to this weekend so no rush. It seems like a UI for the chat app will be pretty simple. Maybe it would actually be cool to implement it in Native with this

I added another branch 'chatapp', that has folders with initial server code, some client code, and image mockups.  This is very rough and doesn't include any security / auth or anything like that.  My plan was to build something simple to showcase the subscription features and integration with graphene server and apollo client library. The client code only has one component at this point...which was mainly used for testing the graphql subscription packages.  It is just the start of a simple app...

Hi Heath, thanks for the library! I've been testing it with your chatapp branch. I'm getting the error "Subscription timed out - no response from server". Would you have any hints on what might be wrong? The /graphql endpoint is working fine.

Sure thing...give me a bit and I'll shoot out an update.  I have it working fine on my setup, but I was testing pretty extensively before I published the master branch, so I could have something config'ed / installed that I didn't include in chatapp branch. I was in a rush yesterday to push it and didn't try testing it in afresh project environ.  I'll do that in a bit and shoot out any changes that may need to be made.

Didn't have time to fix this last night, but I just pushed a commit that fixes it.  When Flask-SqlAlchemy recently updated to version 2.2 they made a change to where the db object now has to be used within an app_context.  Here is the version change and specifically on commit #461.  I had previously tested this with 2.1 and it was working.  Regardless, I added an app_context within the subscription resolver function and that fixed it...or you could use flask-sqlalchemy < 2.2 with the previous code.  Once you install your npm packages for the client code and pip install the requirements file for the server, don't forget to load a python interpreter and:
>>> from api import db
>>> db.create_all()
The currently implemented React component looks for any additional users being added (AddUser) -- so just load a graphiql session in your browser (http://localhost:5000/graphql) and add a new user to test.

Awesome! Thank you very much. I'll test it tonight :)


Deploy goal fails (hangs) when using non-default output directory (e.g. with MicroProfile starter config)

On v3.5.1, with config like that generated by the MP starter:
          <plugin>
            <groupId>io.openliberty.tools</groupId>
            <artifactId>liberty-maven-plugin</artifactId>
            <version>${openliberty.maven.version}</version>
            <executions>
              <execution>
                <id>package-server</id>
                <phase>package</phase>
                <goals>
                  <goal>create</goal>
                  <goal>install-feature</goal>
                  <goal>deploy</goal>
                  <goal>package</goal>
                </goals>
                <configuration>
                  <outputDirectory>target/wlp-package</outputDirectory>
                </configuration>
              </execution>
            </executions>

the app deploy fails.  It hangs with repeated messages:

[INFO] CWWKM2013I: The file ....\target\wlp-package\demo\logs\messages.log being validated does not exist.

In trying to recreate I was confused why it wasn't happening more consistently.
As it turns out, in DeployMojoSupport.java we do a check
    protected void verifyAppStarted(String appFile) throws MojoExecutionException {
        if (shouldValidateAppStart()) {

and we only bother validating the app started message if the server is already up and running, which it won't be typically when running dev mode (unless it was brought down abruptly).
RECREATE
So to sum it up, to recreate:

gen from MP starter using above config
mvn liberty:dev
Add some dummy LMP config to force a redeploy, e.g.

           <configuration>
                  <outputDirectory>target/wlp-package</outputDirectory>
                  <dummy>dummy</dummy>
                </configuration>
              </execution>

        </executions>

As a separate issue I wonder why the MicroProfile starter is using non-default output dir.  Will look into that separately.

@Emily-Jiang According to this Liberty doc, it is the server dir. And according to LMP doc, for the package goal and install-feature goal, it is the ${project.build.directory}/liberty-alt-output-dir dir.

@Emily-Jiang According to this Liberty doc, it is the server dir. And according to LMP doc, for the package goal and install-feature goal, it is the ${project.build.directory}/liberty-alt-output-dir dir. The rest of the LMP goals would default to the WLP_OUTPUT_DIR.

Thanks @cherylking for the explanation! It is allowed not to use the default dir, right? My point is that the MP starter configuration should work though. By the way, I created the pom.xml in MP Starter and I specified it so that I know where to find the output.

@Emily-Jiang Right, it should work to specify it, but Scott was just questioning why the default was not used by the starter.

Just tacked on the "after server is killed" to the issue title... in dev mode we'd rarely need to deploy against a started server, so the most likely way to hit this in dev mode is if the server wasn't stopped cleanly.

I'm going to close this issue.  Now that we understand it better, it's clearer to view the breakdown we get in the other, separate issues:

Logging to non-default outputDirectory doesn't work in dev mode - https://github.com/OpenLiberty/ci.maven/issues/1684
Problem w/ deploy after server killed - https://github.com/OpenLiberty/ci.maven/issues/1696
Desire to fix the MP starter to avoid the first problem here: https://github.com/eclipse/microprofile-starter/pull/484


Added padding to all the containers such as genre , pricing etc.

Related Issue
(in dark mode only )
This PR addresses the improper padding of containers due to which  the cards were not looking aligned
Fixes:  #1042
Description
The top and bottom padding for the containers such as genre section, pricing section etc. has not been given due to which the cards were not aligned in proper manner . So I added the required padding for all the containers and due to this addition the navbar was also getting the same padding so to fix it I styled the navbar padding to 0 using inline styling in html file
Issue number: #1042

Type of PR

[x] Bug fix
[x] Feature enhancement

Screenshots / videos (if applicable)
Before

After

Checklist:

[x] I have made this change from my own.
[x] My code follows the style guidelines of this project.
[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generate no new warnings.
[x] I have tested the changes thoroughly before submitting this pull request.
[x] I have provided relevant issue numbers and screenshots after making the changes.

Conflicting files
assets/css/style.css
Please see the conflicts highlighted in the image above. Resolve the conflicts in the mentioned files. Ensure you pull all the latest changes before pushing your feature/bug fixes to the main branch. After resolving the conflicts, please open a new PR for review.
Thank you!


Promise is not returned from Velocity() in IE10.

Velocity() returns null instead of a promise in IE10, although animation works.
Example jsfiddle that breaks in IE10:
http://jsfiddle.net/q59rwwg9/
Example code:
var slice = Array.prototype.slice;
var elems = slice.call(document.getElementsByTagName('div'));

Velocity(
    elems,
    'callout.shake'
).then(function() {});

Hehe... I was getting ready to do some whining but realized that the "polyfill" I was using was not defining the Promise global.. as a polyfill should..
Fixed with
window.Promise = window.Promise || require('es6-promise');

OL, nevermind.
with Promise on the window:

And with Promise defined explicitly on Velocity using
var velocity = require('velocity');
var Promise = require('es6-promise');
velocity.Promise = Promise;

Gives me this:

and

Aahaha... I'm a dummy =) woooow. you gotta do Promise = require('es6-promise').Promise with the es6-promise package.
=) Carry-on..


Added omitempty to storage structs

Adding omitempty to the JSON metadata of the storage struct fields significantly cuts down the size of the marshaled JSON when a hook is persisting state to a database.
I've left it out on fields that, in my experience, never have the default value; but if you feel it should be consistent on all fields, I can add it to the rest.

My bad, I forgot to run tests and it appears some test expects the missing fields to exist.

This looks good to me, thank you @snej! Apologies for the long wait.


Cannot override Lua icon color

My configuration:
devicons.setup({
      -- NOTE: override the icon
      override_by_extension = {
        java = { icon = "", color = "#e46368", name = "Java" },
        [".gitignore"] = { icon = "", color = "#428850", name = "GitIgnore" },
        js = { icon = "", color = "#f7cd6d", name = "JavaScript" },
        json = { icon = "", color = "#f7cd6d", name = "JSON" },
        ts = { icon = "󰛦", color = "#87b2e2", name = "TypeScript" },
        html = { icon = "", color = "#de7558", name = "Html" },
        rb = { icon = "", color = "#ef757c", name = "Rb" },
        rake = { icon = "", color = "#ef757c", name = "Rake" },
        rakefile = { icon = "", color = "#ef757c", name = "RakeFile" },
        jbuilder = { icon = "", color = "#f7cd6d", name = "Jbuilder" },
        lua = { icon = "", color = "#37c88e", name = "Lua" }
      },
      color_icons = true,
      default = false,
      strict = true,
})

NvimTree:

I expected the DevIconLua should be green as same as the highlight color you guys can see in the photo but it's still have the default color. Other icons seem work fine.

Execute setup for web-devicon before you execute nvim-tree setup.
What's that plugin that shows the rgb colours after the #? That looks incredibly useful!

Raised #464
Added to readme: https://github.com/nvim-tree/nvim-web-devicons?tab=readme-ov-file#my-setup-overrides-are-not-applied

Execute nvim-web-devicons setup before you execute nvim-tree setup.
What's that plugin that shows the rgb colours after the #? That looks incredibly useful!

Thanks for the fast response!! 😊 it's from https://github.com/brenoprata10/nvim-highlight-colors

Execute nvim-web-devicons setup before you execute nvim-tree setup.
What's that plugin that shows the rgb colours after the #? That looks incredibly useful!

I added these property to the plugin which expected Lazy.nvim will load and setup it first, but still didnt work....Not only my nvim-tree, but also bufferline-nvim or incline-nvim and maybe other plugin did not catch the color

Incline-nvim:

bufferline:

UPDATE:
I have got the DevIconLua to change the color, but I have to do an extra line of code after the setup method:
devicons.set_icon({
     java = { icon = "", color = "#e46368", name = "Java" },
     [".gitignore"] = { icon = "", color = "#428850", name = "GitIgnore" },
     js = { icon = "", color = "#f7cd6d", name = "JavaScript" },
     json = { icon = "", color = "#f7cd6d", name = "JSON" },
     ....
})

Dont really know why but it work for me for now

Great news!
#464 should resolve these sorts of problems.

Great news!
#464 should resolve these sorts of problems.

Cool, will try this out

@alex-courtis

Great news!
#464 should resolve these sorts of problems.

#464 seems to be an issue, not a PR. Is there any PR that solves this that I can try out?

I'm having a similar issue where sometimes the color of the override is set to white, even though I've set some other color.
Here's a minimal config that reproduces the issue:

Click to expand
local lazypath = vim.fn.stdpath('data') .. '/lazy/lazy.nvim'
if not vim.loop.fs_stat(lazypath) then
vim.fn.system({
  'git',
  'clone',
  '--filter=blob:none',
  'https://github.com/folke/lazy.nvim.git',
  '--branch=stable', -- latest stable release
  lazypath,
})
end
vim.opt.rtp:prepend(lazypath)

vim.keymap.set('n', '<c-q>', vim.cmd.quit)

require('lazy').setup({
  {
    'nvim-tree/nvim-web-devicons',
    opts = {
      override = {
        md = {
          icon = 'THIS TEXT IS SOMETIMES WHITE',
          color = 'red', -- The text should be red, not white
          name = 'Markdown'
        },
      },
    }
  },
  {
    'romgrk/barbar.nvim',
    dependencies = 'nvim-tree/nvim-web-devicons',
    opts = {},
  }
})

To reproduce

Open a markdown file with nvim -u path/to/config/above
The text THIS TEXT IS SOMETIMES WHITE is sometimes white, and sometimes red (which it should be)

The issue seems to occur with about a 50% chance.

I'm having a similar issue where sometimes the color of the override is set to white, even though I've set some other color.

Sometimes is the key. Lazy's ordering is nondeterministic.
Can you try with another plugin manager or call setup yourself afterwards, in the correct order?


swift 3.0 package error

Ubuntu 14.04
Swift 3.0
ubuntu-trusty-64$ swift build
Cloning https://github.com/qutheory/vapor.git
git clone --recursive --depth 10 https://github.com/qutheory/vapor.git /home/vagrant/Swifts/vapor-3.0/Packages/vapor
Segmentation fault (core dumped)

Which Swift 3.0 snapshot are you using?

swift-DEVELOPMENT-SNAPSHOT-2016-03-24-a

That's the proper installation. What type of machine? If it hasn't started trying to build the project yet when it's crashing, it must be an issue with Swift on your system.

I was having this same issue occur, and found it to be that git was not installed on the system prior to running the vapor build command.


Dev/xarray base

Refactor to use XArray for inputs/outputs/backends

To-Do before merging:

Update README
Fix tests

@StevePny Tests and readme are updated. The main things still to do for the xarray refactor are:

Work on updating docstrings
Fix/standardize notation between da cyclers, which you flagged above.

I think we could merge this before doing that work, just so that all the xarray functionality is all in main for us to pull from. But if you'd rather we wait until they're done, I could get to these two things some time this week.


Update nf-sysinfoapi-getintegrateddisplaysize.md

Corrected info, the function is located in onecore.lib
Without onecore.lib, calling this function results in undefined symbol. Also, defining _WIN32_WINNT is not necessary to make use of this function.

#sign-off


docs: fix typos

found some small typos here and there

@pr-o can you check the CI error

@pr-o can you check the CI error

Aha! just fixed it.


Feature/unr 4328 who should have authority apis

Description
Adding APIs to be able to query who should have authority on a specific position (also needs a class, defaults to AActor) to LBS and ASpatialFunctionalTest

Decided that it wouldn't be done.


[YUNIKORN-1797] K8Shim: Implement scoped logging

Add API support for scoped logging to the Kubernetes shim and admission controller. This will allow for fine-grained logging control per-subsystem.
What type of PR is it?

[ ] - Bug Fix
[ ] - Improvement
[x] - Feature
[ ] - Documentation
[ ] - Hot Fix
[ ] - Refactoring

Todos

[ ] - Task

What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1797
How should this be tested?
All shim log messages should now go to the "k8shim" logger, and admission logs to the "admission" logger. Future PRs will move individual subsystems to even more specific loggers.
Screenshots (if appropriate)
Questions:

[ ] - The licenses files need update.
[ ] - There is breaking changes for older versions.
[ ] - It needs documentation.

Looks good, I'll examine this in my IDE in more detail tomorrow just to have a slightly better understanding.

Ok, I did a re-review. Some parts are not entirely clear, it's difficult to understand what happens without comments. You can also consider using Example* functions which documents how the new logger approach should be used (filtering, parent loggers, etc).

I'll try to add some more comments but I don't see the need for example functions. The original JIRA demonstrates this, and eventually all log statements will use the new form. Essentially:
log.Logger().Info(...) becomes log.Log(log.LogName).Info(...)
Everything else remains the same. The specific loggers will be subsystem-specific, and probably added to the codebase as we segregate things out. I don't want to do a high-level "dump everything by package" translation as I'd like there to be some thought given to organizing our loggers.
The existing log.Logger() call remains in place for backwards compatibility. Depending on context (admission controller, shim, or core), this becomes equivalent to either log.Log(log.Admission), log.Log(log.K8Shim) or log.Log(log.Core) respectively.
Finally, log.RootLogger() provides the old behavior, but this is only exposed for initial configuration (i.e. passing the log reference to the core from the shim).

Updated PR (rebased on master) and addressed review comments. Added significant comments throughout, and additional test cases.


新增后台运行模式，更新go.mod

PR types

PR changes

Describe

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.0 out of 2 committers have signed the CLA.:x: luoyuedong:x: PeyChouYou have signed the CLA already but the status is still pending? Let us recheck it.


Provide helper for asserting redirection

Inertia uses 409 as the status code for redirection. When writing tests in Laravel with
$this->post('/', headers: ['X-Inertia' => true])->assertRedirect('/redirected');

The test will fail because Laravel relies on $this->isRedirect() to validate whether the request returned a redirect. The isRedirect() method belongs to Symfony and it doesn't consider 409 as a valid status code, which means this always fail.

Heya. We removed our master branch. Feel free to re-attempt this to 1.x!


[BUG]  Activity Launcher won't run

Describe the bug / 描述一下这个错误
app called activity launcher will always crashed during loading list app
To Reproduce / 复现步骤
Steps to reproduce the behavior:

install the activity launcher
try to run it
wait for activity launcher loading
activity launcher crashed

Expected behavior / 预期的行为
Activity Launcher should work well like previous version 2.1.0
Screenshots / 截图
N/A
Mobile Phone Info / 手机信息
Realme 5i
Android 10 Realme UI 1.0
RMX2030
Logcat / 日志

app like scoop not working
(either it's xposed module or the app itself)

no logcat for blackbox i didn't catch it via adb
i didn't have any pc

Additional context / 额外内容
issues is related to scoop because for logcat app crashlog inside bb app like scoop is required meanwhile that app not working idk which one is wrong the app or xposed module itself
APK

Just tested, working normally.

Make sure you are using the newest version.
The logcat file under download folder.

Just tested, working normally.

Make sure you are using the newest version.
The logcat file under download folder.

is on 2.1.3 latest version :
(bruh 🗿🗿🗿🗿)

I didn't see any error stack info about blockbox. sorry, I think you only can figure out yourself now.


DocuSign Admin Portal

Newbie Here: I'm walking thru this setup and I added the Docusign App to my environment. I don't see an Docusign Admin Portal ( I don't know the Url)   and I don't know what administrator account that I use? To do this walk - thru do I need to be already using Docusign?
step I'm stuck at
In a different web browser window, login to your DocuSign admin portal as an administrator.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 40756c7c-63eb-10f8-c8c4-17b57877bb7f
Version Independent ID: 9de82050-9230-0236-c246-b2fd273888ce
Content
Content Source
Service: active-directory

@charliebrownCTL You are correct, one of the prerequisites listed in the doc is "A DocuSign single sign-on enabled subscription". Once you are signed up with Docusign you should have the appropriate portal and credential information from them.


Related resource stack doesn't close when saved

Description
If you have a resource with a relationship field, and you open it in the CP, and save, the stack doesn't close, you have to hit esc.
Would be great if the stack closed when saved.
Steps to reproduce

have a resource with a relationship to another resource
open the relationship resource in the CP, a stack panel opens
save the opened resource
Note the stack doesn't close

Environment
Environment
Application Name: Zakat Foundation of America
Laravel Version: 10.48.10
PHP Version: 8.3.6
Composer Version: 2.7.1
Environment: local
Debug Mode: ENABLED
URL: zakat.test
Maintenance Mode: OFF
Cache
Config: NOT CACHED
Events: NOT CACHED
Routes: NOT CACHED
Views: CACHED
Drivers
Broadcasting: log
Cache: statamic
Database: mysql
Logs: daily
Mail: smtp
Queue: sync
Session: file
Statamic
Addons: 12
Antlers: runtime
Sites: 3 (zakat.org (EN), zakat.org (AR), zfinstitute.com (ZFI))
Stache Watcher: Disabled
Static Caching: Disabled
Version: 4.57.3 PRO
Statamic Addons
aryehraber/statamic-captcha: 1.10.0
edalzell/forma: 3.0
jacksleight/statamic-bard-mutator: 2.3.0
jonassiewertsen/statamic-livewire: 2.12.0
statamic-rad-pack/runway: 6.6.5
statamic/seo-pro: 5.4.4
transformstudios/events: 5.4.3
transformstudios/front: 2.0.4
transformstudios/github: dev-main
transformstudios/neon: dev-feature/cf-static-cache
transformstudios/review: 4.1.4
transformstudios/simple: dev-feature/cf-static-cache

I've added the missing 'x' button to the publish form so you can use that to close the publish form.
I haven't made the stack close after saving since that's not something Statamic Core does (yet). Feel free to FR/PR it into Core and we can consider adding it to Runway.


Error message on valid dynamic import

This bug is the same as #70806 (but this one is closed and I cannot folllow-up on it).
I've just upgraded from Angular 7 to Angular 8, which now supports dynamic import for lazy-loaded modules :

{
                path: 'task', loadChildren: () => import('../tasks/tasks.module').then(m => m.TasksModule)
            },

which gives the error :
Dynamic import is only supported when '--module' flag is 'commonjs' or 'esNext'.ts(1323)
This is because the tsconfig file in my source code directory is named tsconfig.app.json instead of tsconfig.json
However this is the Angular naming convention so I cannot change it.
Could this be handled by VSCode  ?

Try creating a tsconfig.json that uses extends to share the settings fromtsconfig.app.json :
{
    "extends": "tsconfig.app.json"
}

Why is this issue closed? The answer commented above does not work.


PGET Enhancements

Use cobra.Command and viper to handle CLI arguments and load from ENV where beneficial
add --resolve argument
add --connect-timeout argument

Still TODO: restructure pget into more logical functions (maybe even packages) for testing
Implement HTTP pipeline and multiplexing
Maybe: Coalesce multiple invocations of pget into a single background downloader.

Still todo:
--manifest of many files to download (file or STDIN with - argument)
Consider: https://github.com/curl/curl/issues/5774 for pget downloading behavior.
implement tests.

it might be nice to split this up into multiple PRs, one keep the exact same functionally but restructuring you want, and (an)other PR(s) for the functionality changes

Now that I have the code a bit more structured, I can split this into some separate PRs. Let me get the last bit in this thread completed [one more] and I'll consolidate:

Current behavior + Cobra.Command + Viper
New client code + new flags
New backend code [next commit]
Manifest support [Pending PR]


Feature Request: support for CoNLL format

Hello mlcroissant community,
I am looking for support of CoNLL format, which is widely used in NLP domain. Please see here for a long-existing StackOverflow thread explaining the format.
https://stackoverflow.com/questions/27416164/what-is-conll-data-format
What has been tried
An example of Croissant metadata
I found an example of the metadata format
https://github.com/mlcommons/croissant
It seems the example can only be adapted to regular tabular data, which has the first row as column names.
Existing Croissant Editor
I tried to use Croissant Editor on HuggingFace to derive the metadata, but the web interface keeps popping this error:

The error indicates lack of support for CoNLL format.
Any example mlc card for CoNLL dataset or API support will be greatly helpful. Thanks in advance!

Hi,
CoNLL uses at TSV format for its files. This can be described in Croissant similarly to the CSV examples, e.g., :
https://github.com/mlcommons/croissant/blob/main/datasets/1.0/movielens/metadata.json
For the data files, you need to specify: encoding_format="text/tab-separated-values" on FileObject.
The Croissant editor should figure things out automatically if you upload the data files one by one.
Best,
Omar

Thanks Omar for the suggestion!
To my best knowledge, CoNLL is not a strictly TSV file (yes, it's indeed tab separated):

CoNLL does not necessarily have column names, this is the major problem I have after uploading the file into Croissant Editor. I will have to manually add column names, but it's unclear how the added names will be associated with the columns.
CoNLL may have empty lines to as separators between sentences, while in regular TSV files, empty strings are interpreted as empty fields. I am not sure how empty lines in CoNLL files are parsed.


[Example] Simple PageIndicator for iOS and Android

If anyone is looking for a simple page indicator which is working on Android and iOS: here it is.
Code: https://pastebin.com/uBQuWczK

https://github.com/callstack/react-native-pager-view/blob/master/example/src/PaginationDotsExample.tsx


Nuxt 3: How to auto import all the Drawer components?

Hi, could you please provide docs in the README file on how to auto import all the drawer components?

Currently there's no Nuxt module for auto-importing Drawer component yet.


Line Editor shouldn't allow creating rotated two-point lines

Currently, two-point lines must always be unrotated. (angle=0)
With Line Editor, we can techniically create a rotated two-point line, which leads to unexpected behaviors.
Cc @dwelle

Slightly related: #1673

This is gonna be fun :)

If we go that path, I'd suggest normalizing two-point lines like this:
{
  angle: angle, // variable
  points: [[0, 0], [width, 0]],
  width: width,
  height: 0,
}

But, this is going to be a big change. Rotation handle might not be very easy to grab for long lines.
I guess @vjeux is one of who take seriously about normalizing two point lines?

That ship has sailed on my end, do whatever you feel is good :)

In that case, we can simply support angle for two-point lines. That would simplify things. (We give up normalization. We sort of did with diamonds and 45-degree-rotated rectangles.)

The ideal goal for DX is no element.points.length === 2 checks.
However, this means we "resize" straight lines, so I don't think it's easy to implement shift-locking for straight lines, which is bad in UX.
Maybe, we just enable rotate handle for two-point lines for now.

Or, make the line editor prohibit deleting points less than three.

@dwelle What do you think?

Or, make the line editor prohibit deleting points less than three.

I wouldn't go that path as it's non-intuitive and prevents several use cases (e.g. you're toying with a 3-point line and decide you want to get rid of the middle point).
If we removed, it'd still just be a temp solution as I don't think we'd want to retain this arbitrary limitation. As such, let's just fix the problem at hand instead of hacking it further.

Three perspectives:

Should we keep normalizing two-point lines/arrows, or introduce `angle?
Is showing rotate handle for all two-point/arrows a bit weird?
Can we totally remove element.points.length === 2 checks?

Should we keep normalizing two-point lines/arrows, or introduce `angle?
[...]
Can we totally remove element.points.length === 2 checks?
[...]
Is showing rotate handle for all two-point/arrows a bit weird?

I think this is the way to go. One ring to rule them all. You can check how the behavior/feel be like here: https://excalidraw.com/#json=5934494666194944,GQinJzlXGA4-d2_lkaPDLg

One problem though: not sure what will happen with SHIFT angle locking of 2-point lines after that change. Wouldn't wanna give it up :(.

Exactly what I said in one of my previous comments. 😄

https://excalidraw.com/#json=6031004795928576,J1agJhYLd6A0ELo81o9_fA
If we are ok with this rotate handle.

Exactly what I said in one of my previous comments.

Missed/forgot :sweat_smile:, but I don't quite understand what you mean by:

However, this means we "resize" straight lines, so I don't think it's easy to implement shift-locking for straight lines, which is bad in UX.

If we are ok with this rotate handle.

I think it's fine. Comes with the territory.

I almost mean the same as what you said.
If we were removing the 2-point special logic, it would be impossible to implement SHIFT locking on resize. I thought it's "bad in UX", but I guess it's worth giving up. SHIFT locking can probably be implemented when creating a new line.

I'm not sure we have to give it up if we retained the special 2-point logic just for the SHIFT locking. We'd have to account for rotation though.

What would you do if the line is already rotated? Does SHIFT locking base on the scene canvas or the rotated element?
If you added the special 2-point logic, you'd end up again with inconsistent behavior with rotating 2-point line and the equivalent 3-point straight line.

I'd just move the edge point with respect to the scene so that it's positioned at a given angle (accounting for rotation so that the angle stays the same).

On second thought, I think we should not support SHIFT angle locking on resize handles at all.

SHIFT locking on resize handle is used for width:height=1:1 for most shapes, and exception for 2-point lines is just confusing (UX, DX)
You can't distinguish 2-point lines and 3-point straight lines, and the behavior should be the same (UX)

So, my proposition is we should support SHIFT angle locking in line editor, which is more intuitive and SHIFT locking on resize handle keep the same behavior for all shapes.

SHIFT locking on resize handle is used for width:height=1:1 for most shapes, and exception for 2-point lines is just confusing (UX, DX)

I've taken this under consideration and arrived at the fact that proportion scaling of 2-point lines doesn't make sense (and would work identical if you SHIFT-locked to the same angle you're trying to proportionally resize)

You can't distinguish 2-point lines and 3-point straight lines, and the behavior should be the same (UX)

True, but that's somewhat of an edge case.

At least we should support SHIFT locking during creation of 2-point line (as you suggested above somewhere).
Either way, you make good points --- it's just that I think SHIFT locking for lines is very valuable. But I'm willing to let it go if it won't make sense anymore. We'll see what others think. /cc @vjeux @xixixao


Correctly record creation stacktrace in ResourceLeakDetector.

Motivation:
We missed to correctly record the stacktrace of the creation of an ResourceLeak record. This could either have the effect to log the wrote stacktrace for creation or not log a stacktrace at all if the object was dropped on the floor after it was created.
Modifications:
Correctly create a Record on creation of the object.
Result:
Fixes https://github.com/netty/netty/issues/7781.

@trustin this should fix your problem reported in #7781

@carl-mastrangelo this was introduced by one of your refactorings in ResourceLeakDetector.

(no blame....)


Deployed to heroku ok but application crashes on launch

Everything edployed to heorku without error, but when I try to open the app from within the heroku web interface I'm told there is an Application Error.

Thanks

You should try https://github.com/emedvedev/slackin-extended. Do note that there's a bug with many users in both repos.

Thanks, I didn't know about that.  I gave it a try but am getting a build failure from now ./slackin-extended.
04:06:44 PM | WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules/fsevents):
04:06:44 PM | npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})
04:06:44 PM | added 736 packages from 900 contributors and audited 4673 packages in 9.507s
04:06:44 PM | found 0 vulnerabilities
04:06:44 PM | Running "npm run build"
04:06:44 PM | ><EMAIL_ADDRESS>build /zeit/219c027a
04:06:44 PM | > node-sass --output-style compressed --precision 6 scss/ -o assets/
04:06:45 PM | Rendering Complete, saving .css file...
04:06:45 PM | Wrote CSS to /zeit/219c027a/assets/main.css
04:06:45 PM | Wrote 1 CSS files to /zeit/219c027a/assets/
04:06:45 PM | Error: No output directory named "public" found.
04:06:45 PM | More details: https://zeit.co/docs/v2/advanced/platform/frequently-asked-questions#missing-public-directory
04:06:45 PM | at validateDistDir (/zeit/55cfbb27218c985e/.build-utils/.builder/node_modules/@now/static-build/dist/index.js:308:15)
04:06:45 PM | at Object.build (/zeit/55cfbb27218c985e/.build-utils/.builder/node_modules/@now/static-build/dist/index.js:503:13)
04:06:45 PM | at <anonymous>
04:06:45 PM | at process._tickDomainCallback (internal/process/next_tick.js:228:7)
04:06:45 PM | worker exited with code 20 and signal null
04:06:47 PM | done

You should ask in the other repo :) I don't use Zeit myself

I deployed successfully after a few tries.
Check if your reCaptcha keys are right


Forbid contravariant variable types, in addition to covariant variable types, in function signature

Environment data

Language Server version: 2021.4.2
OS and version: Windows 7
Python version (& distribution if applicable, e.g. Anaconda): 3.8.8 Anaconda

Sample code
from __future__ import annotations

from typing import TypeVar

T = TypeVar("T")
T_co = TypeVar("T_co", covariant=True)
T_contra = TypeVar("T_contra", contravariant=True)

def func_0(x: T, y: T) -> T:
    ...

# Faulty in input and has warnings in inputs.
def func_1(x: T_co, y: T_co) -> T_co:
    ...

# Faulty in output but has no warnings.
def func_2(x: T_contra, y: T_contra) -> T_contra:
    ...

x = int(0)  # type: int
y = str("")  # type: str

a = func_0(x, y)  # type: int | str
b = func_1(x, y)  # type: int | str
c = func_2(x, y)  # type: int | str

Expected behavior
According to PEP 484 (https://www.python.org/dev/peps/pep-0484/#covariance-and-contravariance):

Note: Covariance or contravariance is not a property of a type variable, but a property of a generic class defined using this variable. Variance is only applicable to generic types; generic functions do not have this property. The latter should be defined using only type variables without covariant or contravariant keyword arguments.

Covariant or contravariant type variables, used in functions, either in input or output, get marked as faulty.
Alternative expected behavior
Covariant type variables are allowed only in output but not input, while contravariant type variables are allowed only in input but not output.
In this ways, rule becomes consistent between functions and class methods.
Actual behavior
Covariant type variables are forbidden in input, but contravariant type variables are allowed in both input and output.
This behavior is the same as mypy, but I don't think it's right.

Thanks for the bug report. There was already a check in place for this condition, but it contained a bug where it missed some cases (in particular, cases where the contravariant TypeVar's scope was defined by the function itself rather than a containing class). This will be fixed in the next release.


Unable to import provider in go project - package is outdated

Describe the bug
Unable to go get the provider. It also appears to be very outdated: Version: v1.2.4 Latest https://pkg.go.dev/github.com/jfrog/terraform-provider-artifactory
go get github.com/jfrog/terraform-provider-artifactory
go: downloading github.com/jfrog/terraform-provider-artifactory v1.12.0
go get<EMAIL_ADDRESS>parsing go.mod:
        module declares its path as: gopkg.in/resty.v1
                but was required as: github.com/jfrog/terraform-provider-artifactory

I think it could be easily fixed, but am not sure why it is outdated.
Additional context
I want to import it to get the latest provider schema: https://github.com/jfrog/terraform-provider-artifactory/blob/2385a079da1b16c6179ec4917e1f9801c743f101/pkg/artifactory/provider.go#L19

I've published the provider with go.mod and main.go to include /v2 in the module path. Ran GOPROXY=https://proxy.golang.org GO111MODULE=on go get<EMAIL_ADDRESS>and https://pkg.go.dev/ is still not updated.
Need more investigation.

Turns out this is now updated here at https://pkg.go.dev/github.com/jfrog/terraform-provider-artifactory/v2

Thank you! :smiley:


no results

The following example does not return any tweet, expected?
twitterscraper Trump -l 100 -bd 2017-01-01 -ed 2017-06-01 -o tweets.json
INFO: Querying Trump since:2017-01-01 until:2017-01-09
INFO: Querying Trump since:2017-01-25 until:2017-02-02
INFO: Querying Trump since:2017-01-17 until:2017-01-25
INFO: Querying Trump since:2017-02-02 until:2017-02-10
INFO: Querying Trump since:2017-02-10 until:2017-02-18
INFO: Querying Trump since:2017-02-18 until:2017-02-26
INFO: Querying Trump since:2017-02-26 until:2017-03-06
INFO: Querying Trump since:2017-01-09 until:2017-01-17
INFO: Querying Trump since:2017-03-06 until:2017-03-14
INFO: Querying Trump since:2017-03-14 until:2017-03-22
INFO: Querying Trump since:2017-03-22 until:2017-03-30
INFO: Querying Trump since:2017-03-30 until:2017-04-07
INFO: Querying Trump since:2017-04-07 until:2017-04-15
INFO: Querying Trump since:2017-04-15 until:2017-04-23
INFO: Querying Trump since:2017-04-23 until:2017-05-01
INFO: Querying Trump since:2017-05-01 until:2017-05-09
INFO: Querying Trump since:2017-05-09 until:2017-05-17
INFO: Querying Trump since:2017-05-17 until:2017-05-25
INFO: Querying Trump since:2017-05-25 until:2017-06-01
INFO: Got 0 tweets for Trump%20since%3A2017-02-10%20until%3A2017-02-18.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for Trump%20since%3A2017-03-30%20until%3A2017-04-07.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for Trump%20since%3A2017-02-18%20until%3A2017-02-26.
INFO: Got 0 tweets for Trump%20since%3A2017-01-09%20until%3A2017-01-17.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for Trump%20since%3A2017-04-07%20until%3A2017-04-15.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for Trump%20since%3A2017-04-15%20until%3A2017-04-23.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for Trump%20since%3A2017-03-22%20until%3A2017-03-30.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for Trump%20since%3A2017-03-06%20until%3A2017-03-14.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for Trump%20since%3A2017-05-25%20until%3A2017-06-01.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for Trump%20since%3A2017-01-01%20until%3A2017-01-09.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for Trump%20since%3A2017-04-23%20until%3A2017-05-01.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for Trump%20since%3A2017-01-17%20until%3A2017-01-25.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for Trump%20since%3A2017-05-01%20until%3A2017-05-09.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for Trump%20since%3A2017-03-14%20until%3A2017-03-22.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for Trump%20since%3A2017-01-25%20until%3A2017-02-02.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for Trump%20since%3A2017-02-26%20until%3A2017-03-06.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for Trump%20since%3A2017-05-17%20until%3A2017-05-25.
INFO: Got 0 tweets for Trump%20since%3A2017-02-02%20until%3A2017-02-10.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for Trump%20since%3A2017-05-09%20until%3A2017-05-17.
INFO: Got 0 tweets (0 new).

@bartengine27 I could not reproduce this? Is this still an issue?

@taspinar
Having the same issue
Yesterday it worked without any problems, today the scraper does not show any results. I tested it on 2 Windows computers and one MacOS in two different networks, the output is basically the same:
twitterscraper trump -l 100 -d
INFO: Querying trump since:2017-01-24 until:2017-02-16
INFO: Querying trump since:2017-01-01 until:2017-01-24
INFO: Querying trump since:2017-02-16 until:2017-03-11
INFO: Querying trump since:2017-03-11 until:2017-04-03
INFO: Querying trump since:2017-04-03 until:2017-04-26
INFO: Querying trump since:2017-04-26 until:2017-05-19
INFO: Querying trump since:2017-05-19 until:2017-06-11
INFO: Querying trump since:2017-06-11 until:2017-07-04
INFO: Querying trump since:2017-07-04 until:2017-07-27
INFO: Querying trump since:2017-07-27 until:2017-08-19
INFO: Querying trump since:2017-08-19 until:2017-09-11
INFO: Querying trump since:2017-09-11 until:2017-10-04
INFO: Querying trump since:2017-10-04 until:2017-10-27
INFO: Querying trump since:2017-10-27 until:2017-11-19
INFO: Querying trump since:2017-11-19 until:2017-12-12
INFO: Querying trump since:2017-12-12 until:2018-01-04
INFO: Querying trump since:2018-01-04 until:2018-01-27
INFO: Querying trump since:2018-01-27 until:2018-02-19
INFO: Querying trump since:2018-02-19 until:2018-03-14
INFO: Querying trump since:2018-03-14 until:2018-04-15
INFO: Got 0 tweets for trump%20since%3A2017-06-11%20until%3A2017-07-04.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-08-19%20until%3A2017-09-11.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-04-03%20until%3A2017-04-26.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-01-24%20until%3A2017-02-16.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-07-04%20until%3A2017-07-27.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-11-19%20until%3A2017-12-12.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-12-12%20until%3A2018-01-04.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-01-01%20until%3A2017-01-24.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-09-11%20until%3A2017-10-04.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-07-27%20until%3A2017-08-19.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2018-01-27%20until%3A2018-02-19.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-02-16%20until%3A2017-03-11.
INFO: Got 0 tweets for trump%20since%3A2018-02-19%20until%3A2018-03-14.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-10-04%20until%3A2017-10-27.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-04-26%20until%3A2017-05-19.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-03-11%20until%3A2017-04-03.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2018-01-04%20until%3A2018-01-27.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-10-27%20until%3A2017-11-19.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-05-19%20until%3A2017-06-11.
INFO: Got 0 tweets (0 new).
INFO: Got 20 tweets for trump%20since%3A2018-03-14%20until%3A2018-04-15.
INFO: Got 20 tweets (20 new).
[results for the 20 tweets]

I noticed the results are consistent (not sure if this is the case on every platform/OS) if you set the number of processes to 1, could you try to run the query with the command line argument -p 1  ?

@taspinar
No results are shown at all when the number of processes is set to 1:
twitterscraper trump -l 1000 -p 1 -d
[]
If the number of processes is set to default, one of the processes (the last one) returns a small number of tweets, while others return 0:
twitterscraper trump -l 1000 -d
INFO: Querying trump since:2017-01-01 until:2017-01-24
INFO: Querying trump since:2017-01-24 until:2017-02-16
INFO: Querying trump since:2017-02-16 until:2017-03-11
INFO: Querying trump since:2017-03-11 until:2017-04-03
INFO: Querying trump since:2017-04-03 until:2017-04-26
INFO: Querying trump since:2017-04-26 until:2017-05-19
INFO: Querying trump since:2017-05-19 until:2017-06-11
INFO: Querying trump since:2017-06-11 until:2017-07-04
INFO: Querying trump since:2017-07-04 until:2017-07-27
INFO: Querying trump since:2017-07-27 until:2017-08-19
INFO: Querying trump since:2017-08-19 until:2017-09-11
INFO: Querying trump since:2017-10-04 until:2017-10-27
INFO: Querying trump since:2017-09-11 until:2017-10-04
INFO: Querying trump since:2017-10-27 until:2017-11-19
INFO: Querying trump since:2017-11-19 until:2017-12-12
INFO: Querying trump since:2017-12-12 until:2018-01-04
INFO: Querying trump since:2018-01-27 until:2018-02-19
INFO: Querying trump since:2018-02-19 until:2018-03-14
INFO: Querying trump since:2018-01-04 until:2018-01-27
INFO: Querying trump since:2018-03-14 until:2018-04-21
INFO: Got 0 tweets for trump%20since%3A2017-10-04%20until%3A2017-10-27.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-04-26%20until%3A2017-05-19.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-01-24%20until%3A2017-02-16.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-07-04%20until%3A2017-07-27.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-12-12%20until%3A2018-01-04.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-03-11%20until%3A2017-04-03.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2018-02-19%20until%3A2018-03-14.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-10-27%20until%3A2017-11-19.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-02-16%20until%3A2017-03-11.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-04-03%20until%3A2017-04-26.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-11-19%20until%3A2017-12-12.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-06-11%20until%3A2017-07-04.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-05-19%20until%3A2017-06-11.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-09-11%20until%3A2017-10-04.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2018-01-04%20until%3A2018-01-27.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2018-01-27%20until%3A2018-02-19.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-01-01%20until%3A2017-01-24.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-07-27%20until%3A2017-08-19.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-08-19%20until%3A2017-09-11.
INFO: Got 0 tweets (0 new).
INFO: Got 60 tweets for trump%20since%3A2018-03-14%20until%3A2018-04-21.
INFO: Got 60 tweets (60 new)
5 processes:
twitterscraper trump -l 1000 -p 5 -d
INFO: Querying trump since:2017-04-06 until:2017-07-10
INFO: Querying trump since:2017-07-10 until:2017-10-13
INFO: Querying trump since:2017-01-01 until:2017-04-06
INFO: Querying trump since:2017-10-13 until:2018-04-21
INFO: Got 0 tweets for trump%20since%3A2017-04-06%20until%3A2017-07-10.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-07-10%20until%3A2017-10-13.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for trump%20since%3A2017-01-01%20until%3A2017-04-06.
INFO: Got 0 tweets (0 new).
INFO: Got 218 tweets for trump%20since%3A2017-10-13%20until%3A2018-04-21.
INFO: Got 218 tweets (218 new).

Good morning, I´m having the same issues.
Im working with Ubuntu in 16.04 version and two days ago was perfectly working and today is not extracting any data.
I did the following search:
twitterscraper %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 --lang en -o Executive.json
INFO: Querying %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 since:2006-03-21 until:2006-10-29
INFO: Querying %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 since:2006-10-29 until:2007-06-08
INFO: Querying %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 since:2007-06-08 until:2008-01-16
INFO: Querying %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 since:2008-01-16 until:2008-08-26
INFO: Querying %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 since:2008-08-26 until:2009-04-05
INFO: Querying %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 since:2009-04-05 until:2009-11-13
INFO: Querying %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 since:2009-11-13 until:2010-06-24
INFO: Querying %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 since:2010-06-24 until:2011-02-01
INFO: Querying %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 since:2011-02-01 until:2011-09-11
INFO: Querying %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 since:2012-04-21 until:2012-11-29
INFO: Querying %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 since:2012-11-29 until:2013-07-09
INFO: Querying %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 since:2013-07-09 until:2014-02-16
INFO: Querying %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 since:2014-02-16 until:2014-09-27
INFO: Querying %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 since:2015-12-15 until:2016-07-25
INFO: Querying %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 since:2016-07-25 until:2017-03-04
INFO: Querying %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 since:2017-03-04 until:2017-10-12
INFO: Querying %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 since:2014-09-27 until:2015-05-07
INFO: Querying %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 since:2015-05-07 until:2015-12-15
INFO: Querying %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 since:2017-10-12 until:2018-05-23
INFO: Querying %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30 since:2011-09-11 until:2012-04-21
INFO: Got 0 tweets for %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30%20since%3A2007-06-08%20until%3A2008-01-16.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30%20since%3A2006-03-21%20until%3A2006-10-29.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30%20since%3A2009-11-13%20until%3A2010-06-24.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30%20since%3A2012-04-21%20until%3A2012-11-29.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30%20since%3A2011-02-01%20until%3A2011-09-11.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30%20since%3A2006-10-29%20until%3A2007-06-08.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30%20since%3A2009-04-05%20until%3A2009-11-13.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30%20since%3A2015-12-15%20until%3A2016-07-25.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30%20since%3A2012-11-29%20until%3A2013-07-09.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30%20since%3A2013-07-09%20until%3A2014-02-16.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30%20since%3A2017-03-04%20until%3A2017-10-12.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30%20since%3A2011-09-11%20until%3A2012-04-21.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30%20since%3A2016-07-25%20until%3A2017-03-04.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30%20since%3A2014-02-16%20until%3A2014-09-27.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30%20since%3A2010-06-24%20until%3A2011-02-01.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30%20since%3A2008-01-16%20until%3A2008-08-26.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30%20since%3A2008-08-26%20until%3A2009-04-05.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30%20since%3A2014-09-27%20until%3A2015-05-07.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30%20since%3A2015-05-07%20until%3A2015-12-15.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %23Executiveprotection%20since%3A2018-01-01%20until%3A2018-04-30%20since%3A2017-10-12%20until%3A2018-05-23.

Not working for me either. Are we rate limited?

Just ran into this problem, think it has something to do with different Twitter responses depending on user agent.
If I force the User Agent as:
Mozilla/5.0 (Windows NT 10.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/40.0.2214.93 Safari/537.36
then, it appears it works.

@mattcyu1 The forced user agent worked yesterday, however, today returned no results. I went back to the random user agent today and it's working great.

I noticed that in some of the cases, BeautifulSoup does not find any  element with class "js-stream-item" (see line 46 of tweet.py) even though the soup contains the entire html page with plenty of these  elements.
This does seem to occur more if the number of parallel processes is higher.
I'm trying to implement an alternative approach with Regular Expressions. It looks like the result is more consist but the RegExp still needs some work.

Good morning @taspinar, continue without extracting anything and how do you force the User Agent?

Changing HEADERS_LIST as you suggested still returns zero tweets...

It does not work and still returns zero tweets

Make sure to run python setup.py install after making the change

ok, thank you, so that partially worked...
twitterscraper trump -bd 2018-05-23 -ed 2018-05-24 --output=tweets-01.json returned 675 tweets
Here's the new error message
INFO: Querying trump since:2018-05-23 until:2018-05-24
ERROR: An unknown error occurred! Returning tweets gathered so far.
Traceback (most recent call last):
  File "build/bdist.linux-x86_64/egg/twitterscraper/query.py", line 108, in query_tweets_once
    pos is None
  File "build/bdist.linux-x86_64/egg/twitterscraper/query.py", line 68, in query_single_page
    except json.decoder.JSONDecodeError as e:
AttributeError: 'module' object has no attribute 'JSONDecodeError'
INFO: Got 675 tweets for trump%20since%3A2018-05-23%20until%3A2018-05-24.
INFO: Got 675 tweets (675 new).

it works, thanks

Good morning @taspinar , the extraction problem persists, there are day when it works. During May 4th I made an extraction that dropped 50.825 tweets. Today with all the changes I’ve made hasn’t extract any tweets, besides yesterday it was only extracted 7,000 tweets with the same query which was as follows:
twitterscraper %40camachocastro%20since%3A2013-02-01%20until%3A2014-05-31 -o 26991572.json
INFO: Got 0 tweets for %40camachocastro%20since%3A2013-02-01%20until%3A2014-05-31%20since%3A2009-11-20%20until%3A2010-07-01.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %40camachocastro%20since%3A2013-02-01%20until%3A2014-05-31%20since%3A2016-01-01%20until%3A2016-08-11.
INFO: Got 0 tweets (0 new).
try this other way:
twitterscraper %40camachocastro%20since%3A2013-02-01%20until%3A2014-05-31 -p 5 -o prueba001.json
INFO: Got 0 tweets for %40camachocastro%20since%3A2013-02-01%20until%3A2014-05-31%20since%3A2008-08-30%20until%3A2009-04-10.
INFO: Got 0 tweets (0 new).
INFO: Got 0 tweets for %40camachocastro%20since%3A2013-02-01%20until%3A2014-05-31%20since%3A2012-12-10%20until%3A2013-07-22.
INFO: Got 0 tweets (0 new).

@CamiloVeloz your query @camachocastro since:2013-02-01 until:2014-05-31 since:2008-08-30 until:2009-04-10 is contradicting itself with multiple since and until.
I specify dates, but I use the query_tweets_once method, which doesn't apply additional dateranges.

I believe that most of the 'not being able to get all tweets' issues are caused by the useragent provided by fake_useragent.
I have removed fake_useragent as an dependency all together. See PR https://github.com/taspinar/twitterscraper/pull/119
Once this PR is merged, the newest versions should no longer have these issues.
Can you guys have a look at the PR?

I tried the lastest commit, with no luck:
root@ubuntu-xenial:/vagrant# git clone https://github.com/taspinar/twitterscraper.git
Cloning into 'twitterscraper'...
remote: Counting objects: 702, done.
remote: Compressing objects: 100% (6/6), done.
remote: Total 702 (delta 2), reused 6 (delta 2), pack-reused 694
Receiving objects: 100% (702/702), 158.79 KiB | 0 bytes/s, done.
Resolving deltas: 100% (400/400), done.
Checking connectivity... done.
root@ubuntu-xenial:/vagrant/twitterscraper# cd twitterscraper && git reset --hard fe6f75e
HEAD is now at fe6f75e Remove fakeuseragent (#119)
root@ubuntu-xenial:/vagrant/twitterscraper# python3 setup.py install
running install
Checking .pth file support in /usr/local/lib/python3.5/dist-packages/
/usr/bin/python3 -E -c pass
TEST PASSED: /usr/local/lib/python3.5/dist-packages/ appears to support .pth files
running bdist_egg
running egg_info
creating twitterscraper.egg-info
writing dependency_links to twitterscraper.egg-info/dependency_links.txt
writing requirements to twitterscraper.egg-info/requires.txt
writing entry points to twitterscraper.egg-info/entry_points.txt
writing top-level names to twitterscraper.egg-info/top_level.txt
writing twitterscraper.egg-info/PKG-INFO
writing manifest file 'twitterscraper.egg-info/SOURCES.txt'
reading manifest file 'twitterscraper.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching 'LICENSE.txt'
warning: no files found matching 'HISTORY.rst'
writing manifest file 'twitterscraper.egg-info/SOURCES.txt'
installing library code to build/bdist.linux-x86_64/egg
running install_lib
running build_py
creating build
creating build/lib
creating build/lib/twitterscraper
copying twitterscraper/logging.py -> build/lib/twitterscraper
copying twitterscraper/main.py -> build/lib/twitterscraper
copying twitterscraper/query.py -> build/lib/twitterscraper
copying twitterscraper/tweet.py -> build/lib/twitterscraper
copying twitterscraper/__init__.py -> build/lib/twitterscraper
creating build/bdist.linux-x86_64
creating build/bdist.linux-x86_64/egg
creating build/bdist.linux-x86_64/egg/twitterscraper
copying build/lib/twitterscraper/logging.py -> build/bdist.linux-x86_64/egg/twitterscraper
copying build/lib/twitterscraper/main.py -> build/bdist.linux-x86_64/egg/twitterscraper
copying build/lib/twitterscraper/query.py -> build/bdist.linux-x86_64/egg/twitterscraper
copying build/lib/twitterscraper/tweet.py -> build/bdist.linux-x86_64/egg/twitterscraper
copying build/lib/twitterscraper/__init__.py -> build/bdist.linux-x86_64/egg/twitterscraper
byte-compiling build/bdist.linux-x86_64/egg/twitterscraper/logging.py to logging.cpython-35.pyc
byte-compiling build/bdist.linux-x86_64/egg/twitterscraper/main.py to main.cpython-35.pyc
byte-compiling build/bdist.linux-x86_64/egg/twitterscraper/query.py to query.cpython-35.pyc
byte-compiling build/bdist.linux-x86_64/egg/twitterscraper/tweet.py to tweet.cpython-35.pyc
byte-compiling build/bdist.linux-x86_64/egg/twitterscraper/__init__.py to __init__.cpython-35.pyc
creating build/bdist.linux-x86_64/egg/EGG-INFO
copying twitterscraper.egg-info/PKG-INFO -> build/bdist.linux-x86_64/egg/EGG-INFO
copying twitterscraper.egg-info/SOURCES.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying twitterscraper.egg-info/dependency_links.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying twitterscraper.egg-info/entry_points.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying twitterscraper.egg-info/requires.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
copying twitterscraper.egg-info/top_level.txt -> build/bdist.linux-x86_64/egg/EGG-INFO
zip_safe flag not set; analyzing archive contents...
creating dist
creating 'dist/twitterscraper-0.7.1-py3.5.egg' and adding 'build/bdist.linux-x86_64/egg' to it
removing 'build/bdist.linux-x86_64/egg' (and everything under it)
Processing twitterscraper-0.7.1-py3.5.egg
Copying twitterscraper-0.7.1-py3.5.egg to /usr/local/lib/python3.5/dist-packages
Adding twitterscraper 0.7.1 to easy-install.pth file
Installing twitterscraper script to /usr/local/bin

Installed /usr/local/lib/python3.5/dist-packages/twitterscraper-0.7.1-py3.5.egg
Processing dependencies for twitterscraper==0.7.1
Searching for requests==2.9.1
Best match: requests 2.9.1
Adding requests 2.9.1 to easy-install.pth file

Using /usr/lib/python3/dist-packages
Searching for lxml==4.2.4
Best match: lxml 4.2.4
Adding lxml 4.2.4 to easy-install.pth file

Using /usr/local/lib/python3.5/dist-packages
Searching for bs4==0.0.1
Best match: bs4 0.0.1
bs4 0.0.1 is already the active version in easy-install.pth

Using /usr/local/lib/python3.5/dist-packages
Searching for coala-utils==0.5.1
Best match: coala-utils 0.5.1
coala-utils 0.5.1 is already the active version in easy-install.pth

Using /usr/local/lib/python3.5/dist-packages
Searching for beautifulsoup4==4.6.3
Best match: beautifulsoup4 4.6.3
beautifulsoup4 4.6.3 is already the active version in easy-install.pth

Using /usr/local/lib/python3.5/dist-packages
Finished processing dependencies for twitterscraper==0.7.1

Then, when I run the example in this repository, it hangs:
root@ubuntu-xenial:/vagrant/twitterscraper# (cd .. && python3 run.py)
INFO: Querying XXX OR YYY since:2006-03-21 until:2006-11-03
INFO: Querying XXX OR YYY since:2006-11-03 until:2007-06-18
INFO: Querying XXX OR YYY since:2007-06-18 until:2008-01-31
INFO: Querying XXX OR YYY since:2008-01-31 until:2008-09-14
INFO: Querying XXX OR YYY since:2008-09-14 until:2009-04-29
INFO: Querying XXX OR YYY since:2009-04-29 until:2009-12-12
INFO: Querying XXX OR YYY since:2014-12-02 until:2015-07-17
INFO: Querying XXX OR YYY since:2009-12-12 until:2010-07-27
INFO: Querying XXX OR YYY since:2010-07-27 until:2011-03-11
INFO: Querying XXX OR YYY since:2013-09-04 until:2014-04-19
INFO: Querying XXX OR YYY since:2011-03-11 until:2011-10-24
INFO: Querying XXX OR YYY since:2011-10-24 until:2012-06-07
INFO: Querying XXX OR YYY since:2012-06-07 until:2013-01-20
INFO: Querying XXX OR YYY since:2013-01-20 until:2013-09-04
INFO: Querying XXX OR YYY since:2016-02-29 until:2016-10-13
INFO: Querying XXX OR YYY since:2016-10-13 until:2017-05-28
INFO: Querying XXX OR YYY since:2015-07-17 until:2016-02-29
INFO: Querying XXX OR YYY since:2017-05-28 until:2018-01-10
INFO: Querying XXX OR YYY since:2014-04-19 until:2014-12-02
INFO: Querying XXX OR YYY since:2018-01-10 until:2018-08-25

Hi there,
Using the latest version of Twitterscraper in python 3.7.3, I'm getting the same got 0 tweets issue:
INFO: Got 0 tweets for xxx%20since%3A2019-10-12%20until%3A2019-10-13.
INFO: Got 579 tweets (0 new).
In fact, it's generating different numbers of tweets each time I run it. Using the same query a few days ago, there was no problem. Any ideas? And thanks for providing this library!

I have got a very similar problems as everything mentioned before. It appears as if tweets from today are appearing, but the tweets from further back cannot be collected (even though the visible links do show tweets). It also appears as if it works on some days or some networks and not on others. Any explanation for this?
INFO: queries: ['Trump since:2019-05-07 until:2019-05-08']
INFO: {'User-Agent': 'Mozilla/5.0 (compatible, MSIE 11, Windows NT 6.3; Trident/7.0; rv:11.0) like Gecko'}
INFO: Querying Trump since:2019-05-07 until:2019-05-08
INFO: Scraping tweets from https://twitter.com/search?f=tweets&vertical=default&q=Trump since%3A2019-05-07 until%3A2019-05-08&l=
INFO: Using proxy <IP_ADDRESS>:60780
...
INFO: Retrying... (Attempts left: 3)
INFO: Scraping tweets from https://twitter.com/search?f=tweets&vertical=default&q=Trump since%3A2019-05-07 until%3A2019-05-08&l=
INFO: Using proxy <IP_ADDRESS>:80
INFO: Retrying... (Attempts left: 2)
INFO: Scraping tweets from https://twitter.com/search?f=tweets&vertical=default&q=Trump since%3A2019-05-07 until%3A2019-05-08&l=
INFO: Using proxy <IP_ADDRESS>:3128
INFO: Retrying... (Attempts left: 1)
INFO: Scraping tweets from https://twitter.com/search?f=tweets&vertical=default&q=Trump since%3A2019-05-07 until%3A2019-05-08&l=
INFO: Using proxy <IP_ADDRESS>:8080
INFO: Got 0 tweets for Trump%20since%3A2019-05-07%20until%3A2019-05-08.
INFO: Got 0 tweets (0 new).

Apparently, this issue is still present. After scraping for few hours, i face this problem. Anyone has a solution? Changing the User-Agent was only temporary solution. Introducing new User-Agent does also not help.

I am still having this issue.

Me too.

I need it immediately and got the same thing. can anyone help me?

Same problem here

how about this
https://github.com/PJHRobles/Twitter-Get-Old-Tweets-Scraper/blob/master/scraper/controllers.py
you can easily get twitter information without api

Please try git clone git@github.com:taspinar/twitterscraper.git (pypi doesn't have the recent headers change fix yet)
Duplicate of https://github.com/taspinar/twitterscraper/issues/296 please move discussion there

INFO: queries: ['corona since:2020-05-07 until:2020-05-08']
INFO: Got 0 tweets (0 new)
the same problem plz help me

I'm also having this problem. Are there any solutions?

not yet
On Wed, Jun 24, 2020 at 5:49 AM Malcolm Grossman<EMAIL_ADDRESS>wrote:

I'm also having this problem. Are there any solutions?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/taspinar/twitterscraper/issues/90#issuecomment-648498355,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ANIWFLE7TFFDKAAKI2ET44TRYFBATANCNFSM4EQFSARA
.

--
chhinder kaur

plz suggest another way to download historical tweets

This may work as an alternative https://pypi.org/project/GetOldTweets3/


"import SyntaxNetWrapper" error if wrapper called outside /root/syntaxnet-wrapper

Used your Dockerfile as starting image, and if I try to import your module
from syntaxnet_wrapper.wrapper import SyntaxNetWrapper
from any folder instead of /root/syntaxnet-wrapper, I get:
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python2.7/dist-packages/syntaxnet_wrapper/wrapper.py", line 6, in <module>
    from syntaxnet_wrapper.parser_eval import SyntaxNetConfig, SyntaxNetProcess
  File "/usr/local/lib/python2.7/dist-packages/syntaxnet_wrapper/parser_eval.py", line 48, in <module>
    from syntaxnet.ops import gen_parser_ops
  File "syntaxnet.py", line 3, in <module>
    from syntaxnet_wrapper.wrapper import SyntaxNetWrapper
ImportError: cannot import name SyntaxNetWrapper

Didn't look too much into it, but it think it might be something wrong with path definitions in parser_eval.py.

It was funny coincidence that I had "syntaxnet.py" file I folder from where I started python that made the mess with imports.


Stats Button & Today Range

Could you consider changing the "Stats" to something more like "Daily Update", just that it might be more intuitive then!  Also, in the stats page, could there be a hover popup that states when "Today" begins?  Is it specific to the timezone of the user, or is it always midnight Greenwich Mean Time?

Today and Yesterday feels pretty clear to me. We can add a tooltip though


Add graphical user interface section in user guide

Closes #258

Codecov Report

Merging #259 (67f59e1) into master (a998699) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #259   +/-   ##
=========================================
  Coverage     68.10%   68.10%
  Complexity      596      596
=========================================
  Files            97       97
  Lines          2069     2069
  Branches        213      213
=========================================
  Hits           1409     1409
  Misses          594      594
  Partials         66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a998699...67f59e1. Read the comment docs.


[Enhancement] Add api to get outdated partitions for mv

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #12880
Problem Summary(Required) ：

Add api to get outdated partitions for mv
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] I have added user document for my new feature or new function

[FE PR Coverage Check]
:disappointed: fail : 51 / 76 (67.11%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/MaterializedView.java
51
76
67.11%
[654, 668, 669, 682, 687, 688, 689, 691, 704, 705, 708, 709, 722, 723, 724, 725, 728, 739, 740, 741, 742, 743, 745, 760, 761]

run starrocks_admit_test

[FE PR Coverage Check]
:disappointed: fail : 52 / 77 (67.53%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/MaterializedView.java
50
75
66.67%
[654, 668, 669, 682, 687, 688, 689, 691, 704, 705, 708, 709, 721, 722, 723, 724, 727, 738, 739, 740, 741, 742, 744, 759, 760]

:large_blue_circle:
com/starrocks/scheduler/PartitionBasedMaterializedViewRefreshProcessor.java
2
2
100.00%
[]

run starrocks_admit_test

run starrocks_admit_test

[FE PR Coverage Check]
:disappointed: fail : 52 / 77 (67.53%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/MaterializedView.java
50
75
66.67%
[654, 668, 669, 682, 687, 688, 689, 691, 704, 705, 708, 709, 721, 722, 723, 724, 727, 738, 739, 740, 741, 742, 744, 759, 760]

:large_blue_circle:
com/starrocks/scheduler/PartitionBasedMaterializedViewRefreshProcessor.java
2
2
100.00%
[]

run starrocks_admit_test

run starrocks_admit_test

[FE PR Coverage Check]
:disappointed: fail : 52 / 77 (67.53%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/MaterializedView.java
50
75
66.67%
[654, 668, 669, 682, 687, 688, 689, 691, 704, 705, 708, 709, 721, 722, 723, 724, 727, 738, 739, 740, 741, 742, 744, 759, 760]

:large_blue_circle:
com/starrocks/scheduler/PartitionBasedMaterializedViewRefreshProcessor.java
2
2
100.00%
[]

run starrocks_admit_test


Banking Record Management Console Application.

Banking Record Management application for managing bank records.
This project is console based project in C++ based on concept of file handling.

Readme for better Understanding..


Document terraform help from Yuvi someplace suitable

Erik wrote:
(base) ➜  gcp git:(master) terraform init

Initializing the backend...
╷
│ Error: Backend configuration changed
│
│ A change in the backend configuration has been detected, which may require migrating existing state.
│
│ If you wish to attempt automatic migration of the state, use "terraform init -migrate-state".
│ If you wish to store the current configuration with no changes to the state, use "terraform init -reconfigure".
╵

Should I do terraform init -migrate-state here? I'm not sure what this is about.
Yuvi wrote:
ah, look for hidden files in your current directory
you most likely do not want -migrate-state
this usually means terraform is not looking for state files where it should - which is on GCS remotely, but locally.
Erik wrote:
Ah
I moved away my found .terraform folder, and did (from terraform/gcp): terraform init -backend-config=backends/default-backend.hcl

This resolved the situation, but I don't understand the details here. What caused this? Had I made changes to terraform state that wasn't captured by the remote state or similar?

Had I made changes to terraform state that wasn't captured by the remote state or similar?

Most likely not, as terraform prints out this error precisely to prevent that from happening.

I just ran into this again because I upgraded my terraform version.

Stale, going for a close.


Existing filters aren't deleted

If a profile has previously been set, then the existing filter (created in profileService#setProfile) needs to be removed.

According to Ariane Keller's "tc Packet Filtering and netem":

Filter deletion can only be done for a complete priority band.

profileService#setProfile will need to be updated to set the prio of the filter as well as the flowid.


Adds georeference option to the option dialog in the vis mode

Frontend tests were OK :+1: (details)

Closing, since xavijam was already working on it.


[AutoDiff] Make builtin differential operators stringly polymorphic

Previously, we had the following differential operators:

Builtin.autodiffApplyJVP and Builtin.autodiffApplyVJP for unary functions
Builtin.autodiffApplyMethodJVP and Builtin.autodiffApplyMethodVJP for unary curried unary methods.

When we needed to add a new differential operator that applies to binary or ternary functions, it's complicated: we had to add new builtin kinds and visitors in Builtins.cpp and SILGenBuiltin.cpp.
This patch simplifies all of that by parsing suffixes to Builltin.autodiffApply like other similar "stringly polymorphic" builtins in swift::getBuiltinValueDecl. Here are the possible configurations:
- `_jvp` or `_vjp`: The autodiff-associated function kind.
- `_arity<n>` (optional): The arity of the function argument, e.g. `Builtin.autodiffApply_jvp_arity2`. When not specified, it defaults to `1`.
- `_order<n>` (optional):  The order of the associated function to extract, e.g. `Builtin.autodiffApply_jvp_order3`. When not specified, it defaults to `1`.
- `_rethrows` (optional): Indicates that the associated function rethrows when the original function throws.
- `_method` (optional): Indicates that the input function is a curried method. This is a degenerate case that will be removed over time.

With polymorphic builtins in place, this patch also defines differential operators for binary and ternary functions.

@swift-ci please test tensorflow


Introduce Multidict

Fixes #159
Description of changes in release / Impact of release:
This module builds on the earlier commits to introduce the multidict module which fixes #159.
More on https://multidict.readthedocs.io/en/stable/ here.
multidict has four multidict classes: MultiDict, MultiDictProxy, CIMultiDict and CIMultiDictProxy.
>>> dct = CIMultiDict(key='val')
>>> 'Key' in dct
True
>>> operator.getitem(dct, 'Key')  # we do not support dct['Key'] yet
'val'

The most common use of this class is:
>>> d = MultiDict([('a', 1), ('b', 2), ('a', 3)])
>>> d
<MultiDict ('a': 1, 'b': 2, 'a': 3)>

Documentation
More on https://multidict.readthedocs.io/en/stable/ here.
Risks of this release
Is this a breaking change?

[ ] Yes
[X] No

Is there a way to disable the change?

[x] Use previous release
[ ] Use a feature flag
[ ] No

@alimariebaker FYI


Custom Primary Key

I am stuck with a scenario where I am bound to use a pre-defined database which has its primary keys already set. I have to manually insert column id in all the tables. Can you guys please get onto this problem. I mean either add an annotation of primary key so that people can override the default "id". Also its difficult to set a composite key. So, I have to manually handle this issue.

Any update on this?

Hello, having an _id column is required by other parts and it works in most of the cases so I'm not planning to change it.
What I can recommend is forking and changing the Entity class to make public long id optional.
Or, upon opening the database on a device for the first time, adding that column with unique ids (just a SQL statement in DBOpenHelper).
If you need a compound key, I recommend to use a unique index (e.g. like here).


GeoLookup does not work

I tried to block IPs from a specific country but GeoLookup does not work.

OS: Ubuntu 16.04.5 LTS
modsecurity v3.0.3
modSecurity-nginx v1.0.0
nginx v1.14.0
libgeoip1, libgeoip-dev, geoip-bin was installed

nginx virtual host
    modsecurity on;
    modsecurity_rules '
        # Include the recommended configuration
        Include /etc/nginx/modsec/modsecurity.conf

        # OWASP CRS v3 rules
        Include /usr/local/owasp-modsecurity-crs-3.0.0/crs-setup.conf
        Include /usr/local/owasp-modsecurity-crs-3.0.0/rules/*.conf

        # Audit log
        SecAuditLog /var/log/modsec/mysite.com/audit.log

        # Custom rules
        Include /etc/nginx/modsec/mysite.com/*.conf
    ';

/usr/local/owasp-modsecurity-crs-3.0.0/crs-setup.conf
...
SecGeoLookupDB util/geo-location/GeoIP.dat
...

/etc/nginx/modsec/mysite.com/main.conf
SecRule REMOTE_ADDR "@geoLookup" "chain,id:1,drop,msg:'Non-VN IP address'"
SecRule GEO:COUNTRY_CODE "!@streq VN"

And the debug log I got
[4] (Rule: 1) Executing operator "GeoLookup against REMOTE_ADDR.
[9] Target value: "x.x.x.x" (Variable: REMOTE_ADDR)
[4] Rule returned 0.

This means the remote address could not be looked up. Is there anyone can tell me what is wrong here?

@everping
Can you tell us what is the output of your configure script when setting up libModSecurity? It should be something like this:
ModSecurity - v3.0.2-78-g90197bd for Linux

 Mandatory dependencies
   + libInjection                                  ....v3.0.2-78-g90197bd
   + SecLang tests                                 ....90197bd

 Optional dependencies
   + GeoIP/MaxMind                                 ....found
      * (GeoIP) v1.6.9
         -lGeoIP  , -I/usr/include/
   + LibCURL                                       ....found v7.47.0
      -L/usr/lib/x86_64-linux-gnu -lcurl,  -DWITH_CURL_SSLVERSION_TLSv1_2 -DWITH_CURL
   + YAJL                                          ....found v2.1.0
      -lyajl  , -DWITH_YAJL -I/usr/include/yajl
   + LMDB                                          ....disabled
   + LibXML2                                       ....found v2.9.3
      -lxml2, -I/usr/include/libxml2 -DWITH_LIBXML2
   + SSDEEP                                        ....not found
   + LUA                                           ....not found

You should ensure that GeoIP support is enabled...
I would also suggest maybe removing the GeoIP packages and trying with the new GeoIP format called MaxMind by installing libmaxminddb as I'm not sure what's the current state with the old GeoIP format.

For some reason these Ubuntu packages (unlike Debian) is lacking entries on the pkg-config database which is leading the configure script to fail finding all the needed files...
This should be fixed with https://github.com/SpiderLabs/ModSecurity/pull/1895/commits/9173738cea0d3d84de5ec8581f0ee2b2006e8874.
Also you may want to apply patch https://github.com/SpiderLabs/ModSecurity/pull/1895/commits/b7cb50545584a01811fe0b4b951ef55238d3b4b5 to work with MaxMind. PR #1895 should be merged to master prior to 3.0.3 release, but you are welcome to use it before to fulfill your needs.
Thanks for the report.


AWS AppSync generated GraphQL issue

The example GraphQL shows it including $ characters while the version I grab from the AWS AppSync dashboard does not.   Is there .graphqlconfig  missing to generate a proper GraphQL?
mutation DeleteEvent($id: ID!) {
deleteEvent(id: $id) {
id
description
name
}
}
https://github.com/awslabs/aws-appsync-codegen/issues/6

@blackmouth those are query variables, which you can optionally use in the GraphQL file that you create (not the introspection schema which is what you download from the console).

@undefobj Thank you. I was using the introspection schema downloaded from the console and had not typed out my own GraphQL file to use with aws-appsync-codegen generate.


Add Dockerfile

Closes #39.
This PR adds a basic Dockerfile for the current version of Themis Contract. It builds your local Themis Contract source code into a Docker image that you can use to access most functionality.
NOTE: Keybase support has not yet been tested. The Keybase binary gets built into the final image, but we still need to test mounting the host's Keybase socket into the container.

It occurs to me that we should probably get builds of the docker file under CI. The build is very long, due entirely to building tectonic and pulling its cache, afaict. I wonder if there's a prebuilt version we use somehow? (either by using a docker image for a distro that has binaries available (e.g., arch) or via a docker image someone else has prepared that has tectonic pre-built).

It occurs to me that we should probably get builds of the docker file under CI. The build is very long, due entirely to building tectonic and pulling its cache, afaict. I wonder if there's a prebuilt version we use somehow? (either by using a docker image for a distro that has binaries available (e.g., arch) or via a docker image someone else has prepared that has tectonic pre-built).

Yeah I'm working on getting the image up on Docker Hub 👍


Sort repositories by updated_at

NOTE: This repository is no longer supported or updated by @gomzyakov . If you wish to continue to develop this code yourself, we recommend you fork it.


Test actions wrapped in transaction with Hanami

Hi,
I am using the hanami framework and the rspec lib to test my code and PG database. When I trying to test one action I get following error:
PG::InFailedSqlTransaction: ERROR:  current transaction is aborted, commands ignored until end of transaction block
My action has been wrapped in repository transaction:
def call(params, dependencies)
    begin
      dependencies.repository.transaction do
        create_user(params, dependencies)
        assign_tags(params, dependencies)
        assign_notes(params, dependencies)
      end
    rescue Hanami::Model::Error, Domain::Errors::Exception => error
      raise Domain::Errors::CreateUserFailed, error.message
    end
  end

Here you can see part of my test which are failing:
it 'should raise exception if params contains duplicated email' do
expect{service.call(duplicated_email)}
  .to raise_exception(Domain::Errors::CreateUserFailed)
  .with_message('Duplicated values found (id or
  email)')
end

it 'should raise exception if params contains duplicated note id' do
expect{service.call(duplicated_note_id)}
  .to raise_exception(Domain::Errors::CreateUserFailed)
end

First test pass but the second one raises exception I mentioned earlier. I know this is caused that previous test raised exception in transaction block.  I tried to configure DB cleaner to fix this but without success.
RSpec.configure do |config|
  config.before(:suite) do
   DatabaseCleaner.clean_with :deletion
  end

  config.before(:each) do
   DatabaseCleaner.strategy = :transaction
  end

  config.before(:each) do
   DatabaseCleaner.start
  end

  config.after(:each) do
   DatabaseCleaner.clean
  end
end

I've got the same issue. It looks like DatabaseCleaner is using savepoints and once the transaction goes bad (using Postgres) it cannot be reused and a new transaction needs to be created.
I am trying to figure out how to catch the initial issue, or even catch the error and re-run the test.


read only not found in QuillEditorConfigurations

Is there an existing issue for this?

[X] I have searched the existing issues

Flutter Quill version
9.3.11
Steps to reproduce
nun
Expected results
nun
Actual results
nun
Code sample
QuillEditor.basic(
configurations: QuillEditorConfigurations(
controller: widget.controller ?? QuillController.basic(),
            readOnly: !widget.edit,

            scrollable: true,
            autoFocus: false,
            showCursor: widget.edit,
            expands: false,
            // maxHeight: MediaQuery.of(context).size.height * 0.25,
            padding: EdgeInsets.zero,
            sharedConfigurations: const QuillSharedConfigurations(
              locale: Locale('ar'),
            ),
          ),
        )

Screenshots or Video
No response
Logs
No response

Update a litte in your code:
QuillEditor.basic(
   configurations: QuillEditorConfigurations(
      controller: widget.controller ?? QuillController(
         readOnly: !widget.edit, // <= Migrate to this
      ),
      scrollable: true,
      autoFocus: false,
      showCursor: widget.edit,
      expands: false,
      // maxHeight: MediaQuery.of(context).size.height * 0.25,
      padding: EdgeInsets.zero,
      sharedConfigurations: const QuillSharedConfigurations(
      locale: Locale('ar'),
   ),
),

It made more sense before, why the (breaking) change?

It made more sense before, why the (breaking) change?

I don't know :))

This is indeed a breaking change and it's not even mentioned inside the release notes :D

@the-best-is-best Please mark done for this issue

even the provided example doesn't work...
QuillController(
         readOnly: true
      )

it says The named parameter 'document' is required, but there's no corresponding argument.

This breaking was made by #1843, and it we shouldn't have introduced this breaking change. There is almost no reason.
_controller.readOnly = true;


⚠ Bofrost.lu has degraded performance

In f734465, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1683 ms

Resolved: Bofrost.lu performance has improved in 8f16b81 after 9 minutes.


Circles overlapping on large Step Count

Yes, I'm aware of this, but not sure if this is a bug, not much I can do, except throw an exception to say "too many steps"?
Any suggestion?


matrix-synapse: 1.27.0 -> 1.28.0

Motivation for this change
ChangeLog: https://github.com/matrix-org/synapse/releases/tag/v1.28.0
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 114423 at 6a043cfa run on aarch64-linux 1

1 package built:

matrix-synapse

Ported to stable as 8d82c865b416354a43cb30bd1945c3bbda27850d.


Emit a warning message if syntax error in common.json file

Is your feature request related to a problem? Please describe.
   My common.json file was using apostrophes instead of quotation marks.  And the list within the common.json file had a trailing comma.   (The file was derived from a .js file being used by a different implementation of i18n support.)   Each of these problems made the file illegal json and caused the file to be ignored.   But the only feedback was the t() function returning only the default translation rather than the en, de, fr... translation.   I ended up taking the working next-i18next example and my broken example and gradually swapping parts to see if behavior would change.  As time went on, the source code of the two project became increasingly similar, but they still behaved differently.   Then I swapped the common.json files and noticed that the problem went away.  After it took me only a few minutes to determine the real problem that I'm documenting here.
Describe the solution you'd like
I'd like a warning message if a ./public/locale/* file is found by the code, but ignored due to invalid JSON.
Describe alternatives you've considered
I think what I've just suggested is probably the easiest solution and should be sufficient.  The more detailed the message the better, but extra detail should be considered extra credit.
Additional context
Thanks.

Sure, if the functionality is simple enough, we could merge a PR to achieve this.

A warning should already be shown in the console if setting debug to true

Thanks @adrai!


api_proto_plugin: Normalize SourceCodeInfo.comments in type_context

Signed-off-by: Ryan Northey<EMAIL_ADDRESS>Commit Message:
Additional Description:
This is a general cleanup to shift responsibility for normalizing comment strings in type_context
This will make it easier to shift protodoc to templates, and also will enforce comments have a preceding space - ie // comment not //comment and prevent bugs as can be seen here https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/network/sip_proxy/v3alpha/sip_proxy.proto.html?highlight=sip_proxy#extensions-filters-network-sip-proxy-v3alpha-localservice
it also shifts some v inefficient closures
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/assign @htuch
You seem to have the most detailed background on the original implementation?


Input is broken on OSX

The window doesn't seem to accept input on OSX.

97bcb2fb0cb7904e0cfaee013be3d5d5d3bb7ab0

Apparently SDL needs to be run in the main thread on OSX. I thought the constraint was just that it had to run in the thread where the SDL context was created. Similar things are probably true for OpenGL.


Can't create node.js shell script step in Pipeline

Rancher versions: 2.0 master 4/2
Steps to Reproduce:

Create a pipeline
Edit step 2 and select node.js option, put ./build.js as script
Click on Save
Click on step 2 again

Results:  the options for node.js has changed back to custom.  If I change it back and save the pipeline and then edit the pipeline/step2, it also is changed back to custom.  Should stay on the node.js option

Cause we don't save the environment option in API so that it just a quick setting button. May be we should change a component to show these options?

I don't know why you couldn't just map it backwards from a matching image back to the option.  A separate dropdown is confusing (what's custom going to pick?), Changing the dropdown already in the image picker would be better but these are all less obvious than it was before.

On create you look at the file in the repo to decide the image for the step... On edit, look at the step and if the image is one of the ones you have special options for, select that, otherwise custom.

Ok, that's doable.

Version - 2.0 master 4/11
Verified fixed


Dual screen support

Hi,
I've seen that I'm not the first one asking this question, but I didn't find an answer to it, so here I am: I'm using a dual screen configuration with my laptop's screen and an external one. Once I've set up f.lux on this laptop (Ubuntu 14.04 LTS), I clearly see changes on my laptop's screen, but not on my external one (even if the first one isn't the primary display). Is there a way to have f.lux effective on both screens (as it is on my Windows session)?
Thanks.

I think there are two ways:

Install A 64-bit version with multiple monitor support - https://justgetflux.com/linux.html (link on the bottom of the page)
OR
Follow the guidelines from this gist - https://gist.github.com/robertboloc/9feaa9150926efa4175a

I have a setup with two AMD Radeon HD6450, Debian, Xfce and four monitors.
With Xinerama xflux starts, but doesn't change the color temperature.
Today I disabled Xinerama and switched from the propritary to the radeon oss driver and configured my multimonitor setup with Xrandr by hand.
Now xflux changes the color temperatures, but only on one graphics card/two monitors. The other card/monitors just stay like they are. :/


Revert PRs #6557 #6589 #6600

We are temporarily reverting PRs #6557 #6589 #6600 pending discussions on the dev@ list regarding unknown / runner-specific pipeline options (https://lists.apache.org/thread.html/78fe33dc41b04886f5355d66d50359265bfa2985580bb70f79c53545@<dev.beam.apache.org>).

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

It will help us expedite review of your Pull Request if you tag someone (e.g. @username) to look at it.
Post-Commit Tests Status (on master branch)

Lang
SDK
Apex
Dataflow
Flink
Gearpump
Samza
Spark

Go

---
---
---
---
---
---

Java

Python

---

---
---
---

R: @aaltay

CC: @mxm @tweise @robertwb

In #6600 we talked about reverting this in the release branch only.

The current release branch was not cut until after this change was submitted (https://github.com/apache/beam/commits/release-2.8.0).  https://github.com/apache/beam/pull/6683 is the revert PR now that the branch is cut.


[1.10.2] Digital Miner crashing the game

Please use the search functionality before reporting an issue. Also take a look at the closed issues!
Issue description:
When using the digital miner, right after hitting start the game crashes.
I might have to not that my game has quite a few mods, but I don't feel it's coming for the other mods :p
Steps to reproduce:
1.setup a digital miner normally
2.hit start
3.game crash
Version (make sure you are on the latest version before reporting):
Forge:<IP_ADDRESS>1
Mekanism:1.10.2-<IP_ADDRESS>
Other relevant version:
If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)
https://gist.github.com/Thetos7/8e412221c4d338b0d19bce6d23402e4b
(I have put the entire log, but I think you might only need the error report near the end of it :p)
[gist/pastebin/etc link here]

I'm curious as to how to debug this.
In the crash log there's a ton of interesting stuff
@Line 2523 there start to be a small ton of texture issues
@Line 2593 The system seems to recover the textures from enderio
@Line 2782 we have a "Ticking block entity" caused by a NullPointerException (@Line 2788)
But the bottom line diagnosis in the crash log starts at @2838
And it does implicate the digital miner (@2853)
What should I be looking at?
Lastly, @Thetos7 have you been able to reproduce the issue with the current build of Mekanism?

After some more testing, I think it's not really/ entirely the digital miner that is at fault for the crash.
from what I have tested, the crash occurs when the digital miner tries to pull a block for a storage drawer with the auto-pull.
(I have verified by putting a vanilla chest instead of the drawer and it worked without any crash)
For these tests, I have been using the latest versions available on curse forge (ver. <IP_ADDRESS> for 1.10.2).
I think the NullPointerException mentioned @line 2788 may be causing the crash (if it is at all mekanism related).
I think I must apologize for this since it may not be a problem with mekanism. (I'm really sorry ^^')

It's likely an issue with the backported transporter changes


The provided 'x-amz-content-sha256' header does not match what was computed.

I'm getting The provided 'x-amz-content-sha256' header does not match what was computed. error when calling PUT on presigned URL generated with the getPartPresignedRequestInfo.
The hash generated by the lib is e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855 and this is a hash of the empty string. Digging into the library I've found out that aws4.sign signs over request.body, but the library doesn't provide the body hence the signature is made on empty body.
How is it working for you?
I made my code working only by using s3.getSignedUrl instead of calling getPartRequest on uploadModule. I can't figure out how to use aws4.sign without providing the body.

Hmm, weird. I'm not sure that the body property is involved here as presigned part request works on my side whereas I don't provide any body to the aws4.sign(...) call as you can see in modbox codebase. Do you use the client side lib along the backend one ? Could you provide a minimal reproduction code so I could investigate ? @troggy


Fix incorrect notification commit url (#21479)

Backport #21479
For normal commits the notification url was wrong because oldCommitID is received from the shrinked commits list.
This PR moves the commits list shrinking after the oldCommitID assignment.

bot