Searching for the new equivalent of Solc::detect_version(..)

I'm looking for the new equivalent of Solc::detect_version(..)
Additional Context
It was there in 0.3.0 but not in 0.4.0 which is breaking some changes for aderyn's

thanks for flagging, we refactored a bunch of stuff and a lot of install handling was moved to SolcVersionManager
I've added the detect_version fn back because this is still useful.
there are likely still some inconveniences, so please lmk if you think something could be improved


Cannot get Premiere & Schedule time from getSubscriptionsFeed

Describe your suggestion
I use getSubscriptionsFeed for get info.
However, I cannot receive any Premiere & Schedule time, I just got N/A from published field.
Please add this feature for us.
Below this example data which got from getSubscriptionsFeed
GridVideo {
  type: 'GridVideo',
  id: 'tVzlBQCu3Cw',
  title: Text {
    runs: [ [TextRun] ],
    text: '🔴Free talk : Happy birthday Event!! สุขสันต์วันเกิดไอหลาม เกิด13 ไลฟ์ 12 เปิดไลฟ์ฉลองวันเกิดมาคุยกัน'
  },
  thumbnails: [
    Thumbnail {
      url: 'https://i.ytimg.com/vi/tVzlBQCu3Cw/hqdefault.jpg?sqp=-oaymwEcCNACELwBSFXyq4qpAw4IARUAAIhCGAFwAcABBg==&rs=AOn4CLDs_NPZKoe4qpbbcRH49GwaMqWJRA',
      width: 336,
      height: 188
    },
    Thumbnail {
      url: 'https://i.ytimg.com/vi/tVzlBQCu3Cw/hqdefault.jpg?sqp=-oaymwEcCPYBEIoBSFXyq4qpAw4IARUAAIhCGAFwAcABBg==&rs=AOn4CLD4aUeAjq2GBpNLiw6bofc9JQoOLA',
      width: 246,
      height: 138
    },
    Thumbnail {
      url: 'https://i.ytimg.com/vi/tVzlBQCu3Cw/hqdefault.jpg?sqp=-oaymwEbCNIBEHZIVfKriqkDDggBFQAAiEIYAXABwAEG&rs=AOn4CLBeWQ56646CTnuPOBu3wzPMMlsbjw',
      width: 210,
      height: 118
    }
  ],
  thumbnail_overlays: [
    ThumbnailOverlayTimeStatus {
      type: 'ThumbnailOverlayTimeStatus',
      text: 'UPCOMING',
      style: 'UPCOMING'
    },
    ThumbnailOverlayToggleButton {
      type: 'ThumbnailOverlayToggleButton',
      is_toggled: null,
      icon_type: [Object],
      tooltip: [Object],
      toggled_endpoint: [NavigationEndpoint],
      untoggled_endpoint: [NavigationEndpoint]
    },
    ThumbnailOverlayToggleButton {
      type: 'ThumbnailOverlayToggleButton',
      is_toggled: null,
      icon_type: [Object],
      tooltip: [Object],
      toggled_endpoint: [NavigationEndpoint],
      untoggled_endpoint: [NavigationEndpoint]
    },
    ThumbnailOverlayNowPlaying {
      type: 'ThumbnailOverlayNowPlaying',
      text: 'Now playing'
    }
  ],
  rich_thumbnail: undefined,
  published: Text { text: 'N/A' },
  duration: Text { text: 'UPCOMING' },
  author: Author {
    id: 'UCTygto_BZDamXNv2YRqPNKg',
    name: 'Kaiyo Ch. 鮫かいよ',
    thumbnails: [],
    endpoint: NavigationEndpoint {
      type: 'NavigationEndpoint',
      payload: [Object],
      metadata: [Object]
    },
    badges: [],
    is_verified: null,
    is_verified_artist: null,
    url: 'https://www.youtube.com/@KaiyoCh'
  },
  views: Text { text: 'N/A' },
  short_view_count: Text { text: 'N/A' },
  endpoint: NavigationEndpoint {
    type: 'NavigationEndpoint',
    payload: {
      videoId: 'tVzlBQCu3Cw',
      watchEndpointSupportedOnesieConfig: [Object]
    },
    metadata: {
      url: '/watch?v=tVzlBQCu3Cw',
      page_type: 'WEB_PAGE_TYPE_WATCH',
      api_url: '/player'
    }
  },
  menu: Menu {
    type: 'Menu',
    items: [
      [MenuServiceItem],
      [MenuServiceItem],
      [MenuServiceItem],
      [MenuServiceItem],
      [MenuServiceItem]
    ],
    top_level_buttons: [],
    label: 'Action menu'
  }
}

Other details
No response
Checklist

[X] I am running the latest version.
[X] I checked the documentation and found no answer.
[X] I have searched the existing issues and made sure this is not a duplicate.
[X] I have provided sufficient information.

For other Video objects you can use video.is_upcoming to check if it's upcoming and then get the scheduled start date from video.upcoming (contains a standard javascript Date object when is_upcoming is true, otherwise it's undefined).
However it looks like it hasn't been implemented for GridVideo's yet, the reason I mentioned how you can do it with other video objects, is so that you know that it will be implemented similarly to the way it is in other video objects, not through the published field. If you want to format the Date object to a relative date string, you can use the Intl.RelativeTimeFormat.


kernel: enable virtio-fs for arm64.

This patch add patch file for virtio-fs-v0.3 kernel to enable memory hot
remove to let virtio-fs available on arm64. Also, kernel config file for
virtio-fs-v0.3x for arm64 is offered.
Fixes: #973
Signed-off-by: Jianyong Wu<EMAIL_ADDRESS>@liwei @grahamwhaley  @devimc  @Pennyzct

hi @devimc  is time to trigger ci?

/test

@devimc maybe we can trigger ci again to see if jenkins-ci-ubuntu-18-04 will fail.

/AzurePipelines run

@devimc can you help trigger obs ci , thanks.

/AzurePipelines run

@grahamwhaley @jodh-intel so, what I need to do is just adding comment for that tag in Dockerfile?

thanks @jodh-intel , can you help trigger ci? @devimc

/test

ERROR: Please bump version in kernel/kata_config_version

/test

/AzurePipelines run


ui-scroll - include simple example of controller and datasource object

I found the documentation quite difficult to understand. It would be nice to include a simple example controller and datasource object with the action implemented. This would help make this utility much more accessible.

Will include javascript examples in the next release


many errors in the resource tenant script

Tried to run this to finally finish it.. and got the following:
PS C:\Windows\system32> SetupCrossTenantRelationshipForResourceTenant.ps1 -SourceMailboxMovePublishedScopes "MigScope","
NSSMigration" -ResourceTenantDomain source.onmicrosoft.com -TargetTenantDomain target.onmicrosoft.com
-ApplicationId 77784916-1f66-42d0-b28f-b5ae4f1778c9 -TargetTenantId 645473a2-62c5-4bab-8a6d-837c0d96587c
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:1 char:91
+ ...  "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
+                                                                          ~
Missing file specification after redirection operator.
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:94 char:30
+ /* Created by Arian Stolwijk <http://www.aryweb.nl> */
+                              ~
The '<' operator is reserved for future use.
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:111 char:38
+     background: -moz-linear-gradient(top, rgba(246,246,246,1) 0%, rgb ...
+                                         ~
Missing argument in parameter list.
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:112 char:37
+     background: -webkit-gradient(linear, left top, left bottom, color ...
+                                        ~
Missing argument in parameter list.
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:112 char:76
+ ... webkit-gradient(linear, left top, left bottom, color-stop(0%,rgba(246 ...
+                                                                  ~
Missing expression after unary operator ','.
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:112 char:76
+ ... it-gradient(linear, left top, left bottom, color-stop(0%,rgba(246,246 ...
+                                                              ~~~~
Unexpected token 'rgba' in expression or statement.
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:112 char:76
+ ... webkit-gradient(linear, left top, left bottom, color-stop(0%,rgba(246 ...
+                                                                  ~
Missing closing ')' in expression.
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:112 char:112
+ ... ft bottom, color-stop(0%,rgba(246,246,246,1)), color-stop(8%,rgba(225 ...
+                                                                  ~
Missing expression after unary operator ','.
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:112 char:112
+ ... ottom, color-stop(0%,rgba(246,246,246,1)), color-stop(8%,rgba(225,225 ...
+                                                              ~~~~
Unexpected token 'rgba' in expression or statement.
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:112 char:112
+ ... ft bottom, color-stop(0%,rgba(246,246,246,1)), color-stop(8%,rgba(225 ...
+                                                                  ~
Missing closing ')' in expression.
Not all parse errors were reported.  Correct the reported errors and try again.
    + CategoryInfo          : ParserError: (:) [], ParseException
    + FullyQualifiedErrorId : MissingFileSpecification

Is it something i did, or something in the script needs changing?

I have never seen this issue before, I do not think it's related to the script in any way. Have you tried a clean PS session?
From: andyonline2k21 @.>
Sent: Wednesday, July 28, 2021 1:18 AM
To: microsoft/cross-tenant @.>
Cc: Subscribed @.***>
Subject: [microsoft/cross-tenant] many errors in the resource tenant script (#74)
Tried to run this to finally finish it.. and got the following:
PS C:\Windows\system32> SetupCrossTenantRelationshipForResourceTenant.ps1 -SourceMailboxMovePublishedScopes "MigScope","
NSSMigration" -ResourceTenantDomain source.onmicrosoft.com -TargetTenantDomain target.onmicrosoft.com
-ApplicationId 77784916-1f66-42d0-b28f-b5ae4f1778c9 -TargetTenantId 645473a2-62c5-4bab-8a6d-837c0d96587c
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:1 char:91

...  "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">

                                                                     ~

Missing file specification after redirection operator.
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:94 char:30

/* Created by Arian Stolwijk http://www.aryweb.nl */

                         ~

The '<' operator is reserved for future use.
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:111 char:38

background: -moz-linear-gradient(top, rgba(246,246,246,1) 0%, rgb ...

                                    ~

Missing argument in parameter list.
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:112 char:37

background: -webkit-gradient(linear, left top, left bottom, color ...

                                   ~

Missing argument in parameter list.
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:112 char:76

... webkit-gradient(linear, left top, left bottom, color-stop(0%,rgba(246 ...

                                                             ~

Missing expression after unary operator ','.
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:112 char:76

... it-gradient(linear, left top, left bottom, color-stop(0%,rgba(246,246 ...

                                                         ~~~~

Unexpected token 'rgba' in expression or statement.
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:112 char:76

... webkit-gradient(linear, left top, left bottom, color-stop(0%,rgba(246 ...

                                                             ~

Missing closing ')' in expression.
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:112 char:112

... ft bottom, color-stop(0%,rgba(246,246,246,1)), color-stop(8%,rgba(225 ...

                                                             ~

Missing expression after unary operator ','.
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:112 char:112

... ottom, color-stop(0%,rgba(246,246,246,1)), color-stop(8%,rgba(225,225 ...

                                                         ~~~~

Unexpected token 'rgba' in expression or statement.
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:112 char:112

... ft bottom, color-stop(0%,rgba(246,246,246,1)), color-stop(8%,rgba(225 ...

                                                             ~

Missing closing ')' in expression.
Not all parse errors were reported.  Correct the reported errors and try again.
+ CategoryInfo          : ParserError: (:) [], ParseException

+ FullyQualifiedErrorId : MissingFileSpecification

Is it something i did, or something in the script needs changing?

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcross-tenant%2Fissues%2F74&data=04|01|Roman.Powell%40microsoft.com|d76ab6c7c7a74395706708d951a0327d|72f988bf86f141af91ab2d7cd011db47|0|0|637630570763159674|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=4eyU2kB5KZVgdvO9bS3UR4KR1vYg04%2FepwEw4c4LWfk%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPUHY6FIYZGWWZ7Y5D53KYTTZ64LBANCNFSM5BD225FQ&data=04|01|Roman.Powell%40microsoft.com|d76ab6c7c7a74395706708d951a0327d|72f988bf86f141af91ab2d7cd011db47|0|0|637630570763169657|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=96ZOIM0nHjid85splGT1m7VcnP%2BNnbgOj8HBtqVIsr8%3D&reserved=0.

Yes, and more than one PC with different OS.

It has to be something you have loaded in your PS sessions then. Take this error for example:
Unexpected token 'rgba' in expression or statement.
At C:\Windows\system32\SetupCrossTenantRelationshipForResourceTenant.ps1:112 char:76

... webkit-gradient(linear, left top, left bottom, color-stop(0%,rgba(246 ...

Nowhere in the script is there anything related to rgba, and all of these errors seem to be coming from Webkit even though they are pointing to a certain line in the script.
From: andyonline2k21 @.>
Sent: Wednesday, July 28, 2021 12:13 PM
To: microsoft/cross-tenant @.>
Cc: Roman Powell @.>; Comment @.>
Subject: Re: [microsoft/cross-tenant] many errors in the resource tenant script (#74)
Yes, and more than one PC with different OS.

You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcross-tenant%2Fissues%2F74%23issuecomment-888554130&data=04|01|Roman.Powell%40microsoft.com|97f7059ee68a4d74017508d951fbc225|72f988bf86f141af91ab2d7cd011db47|0|0|637630964031691281|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=GsfNClmL%2BILG6%2BoaEezatIXtFUlN9FnNT6OekRAE20Y%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPUHY6FP2MAVO4XVCHS5PFLT2BJEZANCNFSM5BD225FQ&data=04|01|Roman.Powell%40microsoft.com|97f7059ee68a4d74017508d951fbc225|72f988bf86f141af91ab2d7cd011db47|0|0|637630964031701281|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=P5Prnzmf7b4c1rDnUBp%2Bpe5AiW4ulAQ1G5WXY1OAesI%3D&reserved=0.

I dont know what to say really, I've looked for the script and it has commands for webkit.
It auto updated itself when i ran it like the last one.

That is not part of our script.  I am not sure how you are ending up with that in your version, other than something installed on your system automatically adding it.
#################################################################################

The sample scripts are not supported under any Microsoft standard support
program or service. The sample scripts are provided AS IS without warranty
of any kind. Microsoft further disclaims all implied warranties including, without
limitation, any implied warranties of merchantability or of fitness for a particular
purpose. The entire risk arising out of the use or performance of the sample scripts
and documentation remains with you. In no event shall Microsoft, its authors, or
anyone else involved in the creation, production, or delivery of the scripts be liable
for any damages whatsoever (including, without limitation, damages for loss of business
profits, business interruption, loss of business information, or other pecuniary loss)
arising out of the use of or inability to use the sample scripts or documentation,
even if Microsoft has been advised of the possibility of such damages.

#################################################################################
<# .SYNOPSIS
This script can be used by a tenant that wishes to move resources out of their tenant.
For example fabrikam.com would run this script in order for the contoso.com tenant to pull mailboxes from the fabrikam.com tenant.
This script is intended for the resource tenant in above example fabrikam.com, and it sets up the organization relationship in exchange to authorize the migration.
Following are key properties in organization relationship used here:
- ApplicationId of the azure ad application that resource tenant consents to for mailbox migrations.
- SourceMailboxMovePublishedScopes contains the groups of users that are in scope for migration. Without this no mailboxes can be migrated.

.PARAMETER SourceMailboxMovePublishedScopes
SourceMailboxMovePublishedScopes - Identity of the scope used by source tenant admin.
.PARAMETER ResourceTenantDomain
ResourceTenantDomain - the resource tenant.
.PARAMETER TargetTenantDomain
TargetTenantDomain - The target tenant.
.PARAMETER TargetTenantId
TargetTenantId - The target tenant id.
.EXAMPLE
SetupCrossTenantRelationshipForResourceTenant.ps1 -ResourceTenantDomain fabrikam.onmicrosoft.com -TargetTenantDomain contoso.onmicrosoft.com -TargetTenantId d925e0c6-d4db-40c6-a864-49db24af0460 -SourceMailboxMovePublishedScopes "SecurityGroupName"
#>
[CmdletBinding(SupportsShouldProcess)]
param
(
[Parameter(Mandatory = $true, HelpMessage='Setup Options')]
[string[]]$SourceMailboxMovePublishedScopes,
[Parameter(Mandatory = $true, HelpMessage='Resource tenant domain')]
[ValidateScript({ -not [string]::IsNullOrWhiteSpace($_) })]
[string]$ResourceTenantDomain,

[Parameter(Mandatory = $true, HelpMessage='Target tenant domain')]
[ValidateScript({ -not [string]::IsNullOrWhiteSpace($_) })]
$TargetTenantDomain,

[Parameter(Mandatory = $true, HelpMessage='The application id for the azure ad application to be used for mailbox migrations')]
[ValidateScript({ -not [string]::IsNullOrWhiteSpace($_) })]
$ApplicationId,

[Parameter(Mandatory = $true, HelpMessage='Target tenant id. This is azure ad directory id or external directory object id in exchange online.')]
[ValidateScript({ -not [string]::IsNullOrWhiteSpace($_) })]
$TargetTenantId

)
$ErrorActionPreference = 'Stop'
$ScriptPath = $MyInvocation.MyCommand.Path
$ScriptDir = Split-Path $ScriptPath
function Main() {
Run-ExchangeSetupForResourceTenant $TargetTenantDomain $TargetTenantId $ResourceTenantDomain $ApplicationId $SourceMailboxMovePublishedScopes
Write-Host "Exchange setup complete." -Foreground Green
}
function Check-ExchangeOnlinePowershellConnection {
if ($Null -eq (Get-Command New-OrganizationRelationship -ErrorAction SilentlyContinue)) {
Write-Error "Please connect to the Exchange Online Management module or Exchange Online through basic authentication before running this script!";
}
}
function Run-ExchangeSetupForResourceTenant([string]$targetTenant, [string]$targetTenantId, [string]$resourceTenantDomain, [string]$appId, [string[]]$sourceMailboxMovePublishedScopes) {
# 1. Verify migration scope.
# 2. Create organization relationship
$orgRel = Get-OrganizationRelationship | ? { $_.DomainNames -contains $targetTenantId }
if ($orgRel) {
    Write-Verbose "Organization relationship already exists with $targetTenantId. Updating it."
    $capabilities = @($orgRel.MailboxMoveCapability.Split(",").Trim())
    if (-not $orgRel.MailboxMoveCapability.Contains("RemoteOutbound")) {
        Write-Verbose "Adding RemoteOutbound capability to the organization relationship. Existing capabilities: $capabilities"
        $capabilities += "RemoteOutbound"
    }

    $orgRel | Set-OrganizationRelationship -Enabled:$true -MailboxMoveEnabled:$true -MailboxMoveCapability $capabilities -OAuthApplicationId $appId -MailboxMovePublishedScopes $sourceMailboxMovePublishedScopes
} else {
    $randomSuffix = [Random]::new().Next(0, 10000)
    $orgRelName = "$($targetTenant.Split('.')[0])_$($resourceTenantDomain.Split('.')[0])_$randomSuffix"
    $maxLength = [System.Math]::Min(64, $orgRelName.Length)
    $orgRelName = $orgRelName.SubString(0, $maxLength)

    Write-Verbose "Creating organization relationship: $orgRelName in $resourceTenantDomain"
    New-OrganizationRelationship `
        -DomainNames $targetTenantId `
        -Enabled:$true `
        -MailboxMoveEnabled:$true `
        -MailboxMoveCapability RemoteOutbound `
        -Name $orgRelName `
        -OAuthApplicationId $appId `
        -MailboxMovePublishedScopes $sourceMailboxMovePublishedScopes
}

}
function PreValidation() {
Write-Host n     Write-Host "Welcome to the Cross-tenant mailbox migration preview! Before running this script, please be sure to review the details provided on docs.microsoft.com at the following URL: nhttps://docs.microsoft.com/en-us/microsoft-365/enterprise/cross-tenant-mailbox-migration"
Write-Host "nIt is also recommended before running this script to review the script in a script editor or Notepad prior to running."n
Write-Host "For general feedback and / or questions, please contact<EMAIL_ADDRESS>is not a support alias and should not be used if you are currently experiencing an issue and need immediate assistance."n     $title = "Confirm: Configure Cross-Tenant mailbox migration preview."     $message = "nIf you are ready to begin configuring your tenants, select 'Y'.nIf you need to review any additional details and proceed at a later time, select 'N'.nnDo you wish to proceed?"     $yes = New-Object System.Management.Automation.Host.ChoiceDescription "&Yes", "Yes"     $no = New-Object System.Management.Automation.Host.ChoiceDescription "&No", "No"     $options = [System.Management.Automation.Host.ChoiceDescription[]]($yes, $no)     $choice=$host.ui.PromptForChoice($title, $message, $options, 1)     if ($choice -ne 0) {         Exit}     Start-Sleep 2     Write-Host "nWe are verifying that you are using the latest version of the script."n     Write-Host "This requires that we download the latest version of the script from GitHub to compare with your local copy."     Write-Host "This file will be stored on your local computer temporarily, as well as overwrite your existing script file if it is out of date."     $title = "Confirm: Allow for download from GitHub."     $message = "nIf you are ready to begin this step, select 'Y'. `nIf you would prefer to manually download the scripts to make sure you have the latest version, select 'N'"
$yes = New-Object System.Management.Automation.Host.ChoiceDescription "&Yes", "Yes"
$no = New-Object System.Management.Automation.Host.ChoiceDescription "&No", "No"
$options = [System.Management.Automation.Host.ChoiceDescription[]]($yes, $no)
$choice=$host.ui.PromptForChoice($title, $message, $options, 1)
if ($choice -ne 0) {
Exit}
else {Verification}
}
function Verification {
Write-Host "nBeginning verification steps."n
Check-ExchangeOnlinePowershellConnection
Write-Host "Verifying ability to create a new organization relationship in the tenant."
try {
New-OrganizationRelationship -DomainNames contoso.onmicrosoft.com -Name Contoso -WhatIf -ErrorAction Stop
}
catch {
Write-Output "You need to run the command Enable-OrganizationCustomization before continuing with execution of the script."
Exit
}
Write-Host "nVerifying that your script is up to date with the latest changes."     Write-Host "nBeginning download of SetupCrossTenantRelationshipForResourceTenant.ps1 and creation of temporary files."
if ((Test-Path -Path $ScriptDir\XTenantTemp) -eq $true) {
Remove-Item -Path $ScriptDir\XTenantTemp\ -Recurse -Force | Out-Null
}
New-Item -Path $ScriptDir -Name XTenantTemp -ItemType Directory | Out-Null
Invoke-WebRequest -Uri https://aka.ms/ResourceTenant -Outfile $ScriptDir\XTenantTemp\SetupCrossTenantRelationshipForResourceTenant.ps1
if ((Get-FileHash $ScriptDir\SetupCrossTenantRelationshipForResourceTenant.ps1).hash -eq (Get-FileHash $ScriptDir\XTenantTemp\SetupCrossTenantRelationshipForResourceTenant.ps1).hash) {
Write-Host "nYou are using the latest version of the script. Removing temporary files and proceeding with setup."         Start-Sleep 1         Remove-Item -Path $ScriptDir\XTenantTemp\ -Recurse -Force | Out-Null     }     elseif ((Get-FileHash $ScriptDir\SetupCrossTenantRelationshipForResourceTenant.ps1).hash -ne (Get-FileHash $ScriptDir\XTenantTemp\SetupCrossTenantRelationshipForResourceTenant.ps1).hash) {         Write-Host "nYou are not using the latest version of the script."n         Start-Sleep 1         Write-Host "nReplacing the local copy of SetupCrossTenantRelationshipForResourceTenant.ps1 and cleaning up temporary files..."
Start-Sleep 1
Copy-Item $ScriptDir\XTenantTemp\SetupCrossTenantRelationshipForResourceTenant.ps1 -Destination $ScriptDir | Out-Null
Start-Sleep 1
Remove-Item -Path $ScriptDir\XTenantTemp\ -Recurse -Force | Out-Null
Write-Host "Update completed. You will need to run the script again."
Start-Sleep 1
Exit
}
}
PreValidation
Main
From: andyonline2k21 @.>
Sent: Wednesday, July 28, 2021 12:34 PM
To: microsoft/cross-tenant @.>
Cc: Roman Powell @.>; Comment @.>
Subject: Re: [microsoft/cross-tenant] many errors in the resource tenant script (#74)
I dont know what to say really, I've looked for the script and it has commands for webkit.
It auto updated itself when i ran it like the last one.
[image]https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F87991710%2F127384607-6ef1a31d-7363-4cde-bc82-b6285e39eb91.png&data=04|01|Roman.Powell%40microsoft.com|67d1f11ac066468708b008d951fe9e97|72f988bf86f141af91ab2d7cd011db47|0|0|637630976603965192|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=eU887sTJVQmAQBqaAsD2p%2FT%2BOFnPZps4bykO1JXRBFo%3D&reserved=0

You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcross-tenant%2Fissues%2F74%23issuecomment-888566971&data=04|01|Roman.Powell%40microsoft.com|67d1f11ac066468708b008d951fe9e97|72f988bf86f141af91ab2d7cd011db47|0|0|637630976603965192|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=zkh7e0bpt4fA8tuqDYktKVZPEkwDUOx9rktK7YuF4eg%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPUHY6AN7FLP6IGJY7554NDT2BLRVANCNFSM5BD225FQ&data=04|01|Roman.Powell%40microsoft.com|67d1f11ac066468708b008d951fe9e97|72f988bf86f141af91ab2d7cd011db47|0|0|637630976603975180|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=v45ewJGEXckoEr6%2B88zuyqudVH2GSHYBUt9ZOdyo%2BK0%3D&reserved=0.

Well, I've checked the original and compared it to the version that was downloaded when the script updated, I haven't done anything to it myself, and they are different.

While you may not be doing anything to it Andy, something on your machine/machines is. Can you see what modules are being loaded when you open PS, and see if there is anything that doesn't look like a default module such as this:
PS C:\Users\ropow> get-module
ModuleType Version    Name                                ExportedCommands

Manifest   <IP_ADDRESS>    Microsoft.PowerShell.Utility        {Add-Member, Add-Type, Clear-Variable, Compare-Object...}
Script     2.0.0      PSReadline                          {Get-PSReadLineKeyHandler, Get-PSReadLineOption, Remove-PSReadLineKeyHandler, Set-PSReadLineKeyHandler...}
Also, check in your PS profile to see if there is anything there doing it, run $Profile and open up the file listed in a script/text editor.
Thanks,
Roman
From: andyonline2k21 @.>
Sent: Wednesday, July 28, 2021 12:59 PM
To: microsoft/cross-tenant @.>
Cc: Roman Powell @.>; Comment @.>
Subject: Re: [microsoft/cross-tenant] many errors in the resource tenant script (#74)
Well, I've checked the original and compared it to the version that was downloaded when the script updated, I haven't done anything to it myself, and they are different.

You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcross-tenant%2Fissues%2F74%23issuecomment-888581506&data=04|01|Roman.Powell%40microsoft.com|251aa163c4744ed9d73008d952021b98|72f988bf86f141af91ab2d7cd011db47|0|0|637630991289710844|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=4PXKMatOfNgo8c03DgWZhgCKHapYwDmZ9lm1CYsfec0%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPUHY6FL6S2SEIEVNYOGFCDT2BOPJANCNFSM5BD225FQ&data=04|01|Roman.Powell%40microsoft.com|251aa163c4744ed9d73008d952021b98|72f988bf86f141af91ab2d7cd011db47|0|0|637630991289720833|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=cV1uej6oZCZWGu2RIRbwbBfeXjnpW%2FoVcctadxPu71k%3D&reserved=0.

Roman, See my edit- I've identified how it happened.

At the same time, it's very odd that this didn't happen with the target script.
From: Roman Powell
Sent: Wednesday, July 28, 2021 1:21 PM
To: 'microsoft/cross-tenant' @.>; microsoft/cross-tenant @.>
Cc: Comment @.***>
Subject: RE: [microsoft/cross-tenant] many errors in the resource tenant script (#74)
While you may not be doing anything to it Andy, something on your machine/machines is. Can you see what modules are being loaded when you open PS, and see if there is anything that doesn't look like a default module such as this:
PS C:\Users\ropow> get-module
ModuleType Version    Name                                ExportedCommands

Manifest   <IP_ADDRESS>    Microsoft.PowerShell.Utility        {Add-Member, Add-Type, Clear-Variable, Compare-Object...}
Script     2.0.0      PSReadline                          {Get-PSReadLineKeyHandler, Get-PSReadLineOption, Remove-PSReadLineKeyHandler, Set-PSReadLineKeyHandler...}
Also, check in your PS profile to see if there is anything there doing it, run $Profile and open up the file listed in a script/text editor.
Thanks,
Roman
From: andyonline2k21<EMAIL_ADDRESS>Sent: Wednesday, July 28, 2021 12:59 PM
To: microsoft/cross-tenant<EMAIL_ADDRESS>Cc: Roman Powell<EMAIL_ADDRESS>Comment<EMAIL_ADDRESS>Subject: Re: [microsoft/cross-tenant] many errors in the resource tenant script (#74)
Well, I've checked the original and compared it to the version that was downloaded when the script updated, I haven't done anything to it myself, and they are different.

You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcross-tenant%2Fissues%2F74%23issuecomment-888581506&data=04|01|Roman.Powell%40microsoft.com|251aa163c4744ed9d73008d952021b98|72f988bf86f141af91ab2d7cd011db47|0|0|637630991289710844|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=4PXKMatOfNgo8c03DgWZhgCKHapYwDmZ9lm1CYsfec0%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPUHY6FL6S2SEIEVNYOGFCDT2BOPJANCNFSM5BD225FQ&data=04|01|Roman.Powell%40microsoft.com|251aa163c4744ed9d73008d952021b98|72f988bf86f141af91ab2d7cd011db47|0|0|637630991289720833|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=cV1uej6oZCZWGu2RIRbwbBfeXjnpW%2FoVcctadxPu71k%3D&reserved=0.

most likely the authentication expired or was reset- I was working quite late trying to get it to work and the web filter does a scheduled session reset..

I didn't see your edit Andy, but thanks. One of our developers pointed out that when using Invoke-WebRequest, we don't pass -UseBasicParsing, which could have caused this and I'll be making that fix.
Roman
From: andyonline2k21 @.>
Sent: Wednesday, July 28, 2021 1:26 PM
To: microsoft/cross-tenant @.>
Cc: Roman Powell @.>; Comment @.>
Subject: Re: [microsoft/cross-tenant] many errors in the resource tenant script (#74)
most likely the authentication expired or was reset- I was working quite late trying to get it to work and the web filter does a scheduled session reset..

You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmicrosoft%2Fcross-tenant%2Fissues%2F74%23issuecomment-888598297&data=04|01|Roman.Powell%40microsoft.com|01b5551325804482044808d95205eda9|72f988bf86f141af91ab2d7cd011db47|0|0|637631007929396864|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=Y1f6s50vPzo%2BtRb6gcZzPed9unTAS8%2FQkuG845%2FxoNs%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPUHY6GIZHZUIMFC7UH5T7DT2BRV3ANCNFSM5BD225FQ&data=04|01|Roman.Powell%40microsoft.com|01b5551325804482044808d95205eda9|72f988bf86f141af91ab2d7cd011db47|0|0|637631007929406850|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|1000&sdata=mZlwPzOuTmgtg5TyzWDirW4n%2Bs%2Fzv6AMhoj6soFIlKI%3D&reserved=0.


Kubectl: Release variables in K8s Service connection

Type: Bug
Task Name: KubernetesV1
https://github.com/Microsoft/azure-pipelines-tasks/tree/master/Tasks/KubernetesV1
Environment

Server - Azure Release Pipelines

Agent - Hosted:

Agent queue name: Azure Pipelines (Default)

Issue Description
Our kubectl task has the following k8s service connection: "miranda-aks-$(Release.EnvironmentName)" and it stopped working since yesterday.
When we try to deploy a stage of our release pipeline the following error appears immediatly:
Something went wrong preparing the stage for deployment. Please redeploy the stage.
Troubleshooting
If we change the service connection to a fixed string like "miranda-aks-dev" or if we use a custom variable like "miranda-aks-$(SomeVarName)" it works as expected.
The problems seems to occur only when using the predefined release variables.
Screenshots

Hello,
Our relase ppipeline is working again, it looks like the problem has been fixed.
Any idea on the root cause of the problem?

@luca-esse, Sorry for the inconvenience. We have rollbacked the changes which causing the issue.


PEAR-2215 - Create Placeholder Pages for Enclave Portal [part 1]

Description
Extracts out the Header and Footer to component library. I haven't gone back and updated the GDC portal to use these new components yet because I thought the PR was probably big enough already.
Checklist

[ ] Added proper unit tests
[ ] Left proper TODO messages for any remaining tasks
[ ] Scanned for web accessibility with aXe, and mitigated or documented
flagged issues

Screenshots/Screen Recordings (if Appropriate)

Confirming that I was able to see the header and footer in the Enclave portal.
I did get a bunch of unusual messages when building, but it could be my computer, e.g.
<EMAIL_ADDRESS>(1:0): Module level directives cause errors when bundled, "use client" in<EMAIL_ADDRESS>was ignored.
/Users/wendyteo/code/gdc-frontend-framework/node_modules/@mantine/core/esm/core/factory/polymorphic-factory.mjs:1:0
1: 'use client';
   ^
2: import { jsx } from 'react/jsx-runtime';
3: import { forwardRef } from 'react';
<EMAIL_ADDRESS>(1:0): Module level directives cause errors when bundled, "use client" in<EMAIL_ADDRESS>was ignored.
/Users/wendyteo/code/gdc-frontend-framework/node_modules/@mantine/core/esm/core/InlineStyles/InlineStyles.mjs:1:0


Convert http manifest urls to https

Fixes #175

LGTM (I used the online editor for the trim() change).


Feature/update get payment preimage

We want getPaymentPreimage to return a permanentError if the paymentStatus is grounded. This will allow the caller to differentiate between the preimage, a temporary error, and a permanent error.
https://github.com/sparkswap/lnd/pull/26

 [Resilient Swaps] Check Payment Status before trying to translate swap


 In the next release it will be output.
At the moment you can use stdout/stderr instead.

Great, thank you very much


DEV: LOGS: <IP_ADDRESS> Delete Element (Channel) not working

DEV: LOGS: <IP_ADDRESS> Delete Element (Channel) not working
DeleteFromStore not deleting the channel

Fix confirmed  on 9/13


Queries returned stale data

I have run a query for all observations with code 123 for 2.5 SNAPSHOT.
I then add or delete an observation with code 123.
I immediately rerun the query for all observations with code 123.  I don't see the change.  It appears to be using a cached version of the result.  After some time or after a number of queries I finally do see the expected change.  In version 2.4 release this query works fine reliably.
Is there a way to turn off caching results on the server?
Or is there a way to specify in the query to not use cached results?

Hi Jeff,
Yes, as of 2.5 there is caching of search results for better performance. You can disable this if you want, have a look at DaoConfig#setReuseCachedSearchResultsForMillis

Thanks!


Add In Time by Momo's keys

Song Name
In Time
Artist Name
Momo's keys
Source
Youtube
Youtube Link
https://youtu.be/FOqUKGtzQWU?si=kRA_hsrbsStlNDph
Direct File Link
No response
Song ID
712418
Start Offset [ms]
0
Extra
Created from Auto Nong.
Created for level: 107255311

accept


Dio extension flexible

:scroll: Description

I made the extension more flexible and added the main objects to the export
:bulb: Motivation and Context

Sometimes projects have custom transformers and adapters, for example, an http2 adapter or compute transformer for jsons.
For convenience, need to pass the HttpClientAdapter and Transformer directly in function addSentry
And sometimes it's not convenient to use the constructor, you need the ability to directly set dio options

:green_heart: How did you test it?
Check Dio extension
:pencil: Checklist

[X] I reviewed submitted code
[ ] I added tests to verify changes
[ ] I updated the docs if needed
[ ] All tests passing
[X] No breaking changes

:crystal_ball: Next steps

I'm wondering what your goal is with this PR. You don't need to pass the adapter and transformer as they're not overridden. Both, the current adapter and transformer are used even after adding the Sentry integration.
Do you mind explaining in more detail?

I kind like this flexibility

The thing is, it already works like this.
So (as suggested in this PR)
final dio = Dio();
dio.addSentry(adapter: SomeAdapter());

is equivalent to the following code, which is already possible
final dio = Dio();
dio.adapter = SomeAdapter();
dio.addSentry();

I'm kinda against this change because it's not that intuitive that
final dio = Dio();
dio.adapter = SomeAdapter();
dio.addSentry(adapter: FooAdapter());

overrides the adapter which was previously set.

@ueman Thanks for the explanation.
The override part is really a problem.

I'm wondering what your goal is with this PR. You don't need to pass the adapter and transformer as they're not overridden. Both, the current adapter and transformer are used even after adding the Sentry integration. They don't get changed.
Do you mind explaining in more detail?

Yep, mind clarifying @Overman775 ?

I'm wondering what your goal is with this PR. You don't need to pass the adapter and transformer as they're not overridden. Both, the current adapter and transformer are used even after adding the Sentry integration. They don't get changed.
Do you mind explaining in more detail?

They are overridden implicitly, which is a bit confusing.
If we first add via the Sentry extension, and then install the adapter, we will get a bug. For example:
final dio = Dio();
dio.addSentry();
dio.adapter = SomeAdapter();

Maybe remove the extension and make it like Wrapper pattern? This approach is more explicit
dio.adapter = SentryAdapterWrapper(adapter: dio.adapter);
dio.transformer = SentryTransformerWrapper(dio.transformer)

@ueman @brustolin That do you think?

final dio = Dio();
dio.addSentry();
dio.adapter = SomeAdapter();

The docs state that dio.addSentry() should be the last step of the Dio configuration.
See https://github.com/getsentry/sentry-dart/blob/17894ef526b677f59b7f7e43bae61146a6653b39/dio/lib/src/sentry_dio_extension.dart#L8-L11

Maybe we should add that part to the readme and make it more explicit.

In my experience, not everyone reads the documentation 😃

For me, this example is clearly replacing the adapter, therefore removing sentry.

final dio = Dio();
dio.addSentry();
dio.adapter = SomeAdapter();

I understand that almost no one reads the documentation, but as @ueman pointed out before, the proposal can also lead to some confusion.
We need to choose the less confusing option.

Thanks for your time guys 😃 , closing PR


saves the result of last execution

Spyder remembers the changes from the previous executions

I imported a list, then removed an item and printed.
the first execution worked as it should.
when i executed the code again i got an error: list.remove(x): x not in list. to check i deleted the line to remove the item and to just import and print the list. the list it printed was without the item that was removed in the first execution.

Hey @michal-99, thanks for reporting. This doesn't an internal Spyder problem, which this place is meant to be, i.e. to report those kind of problems.
Instead, it seems a general Python programming issue. For that, we recommend you to ask your question in StackOverflow:
https://stackoverflow.com/


PMID:31427431

increased rate of mitotic spindle elongation during anaphase A
decreased duration of mitotic anaphase B

increased rate of mitotic spindle elongation during anaphase A FYPO:0007071
decreased duration of mitotic anaphase B FYPO:0007072
edit file: ebbf07a26291168d72c556c60327b1d49dead0d2
release: f5e9d85237a4f4f3b8e41d7de21348164b88eb2a


GHA pipelines maintenance

[x] Bump actions to more recent versions (57c6e8b79167da5f1de7f95ffd9fc11e04465409)
[x] remove Hydra ci stats workflow (2d181f7c60a620cf82b60fc1b5245bd2b20620f2)
[x] remove aws node db cache (de1af5fdf27ea3ea79799cd0f00594a315a3a8c8)
[x] fix action versions (139fd40fca2d30b740da72566bdfccd4b00797cf)
[x] update e2e readme (56cbe5b4549afc6b7905b10a57fcd49c2b4f7b83)
[x] turn off integration tests for MacOS (9b8f0f5adb417aa41e28a163b93920b5e4acf398)

Comments

Issue Number
ADP-2503

bors r+

bors r+

bors r+


CEPL corrupting something in Drakma?

10:21 <MetaYan> I tracked down a weirdness that's been bugging me
                for a while. I usually build a CEPL runtime,
                whenever a new SBCL version appears (sounds like it
                appears from the heavens or something).
10:22 <MetaYan> If I then use drakma or dexador, there is trouble
                in cl+ssl .
10:23 <MetaYan> I've found that if dexador or drakma is loaded
                before CEPL, it works fine, but if CEPL is loaded
                first, I get an unhandled memory error.
10:23 <MetaYan> That's how far I got with it last night.
10:23 <Baggers> that is some jank right there
10:24 <MetaYan> Easy test:
10:24 <MetaYan> (ql:quickload '(:drakma :cepl)) (length (dex:get
                "https://google.com"))
10:24 <MetaYan> (ql:quickload '(:cepl :drakma)) (length (dex:get
                "https://google.com"))
10:25 <MetaYan> With a fresh SBCL 1.5.7

A copy/paste error sneaked in above, so here's a correction.
This works:
(ql:quickload '(:drakma :cepl))
(length (drakma:http-request "http://lisp.org"))

Switching the order of loading the packages:
(ql:quickload '(:cepl :drakma))
(length (drakma:http-request "http://lisp.org"))

leads to
CORRUPTION WARNING in SBCL pid 95696(tid 0x7fffb3b92380):
Memory fault at 0x0 (pc=0x7fff7903e148, fp=0x4fe970, sp=0x4fe920) tid 0x7fffb3b92380
The integrity of this image is possibly compromised.
Continuing with fingers crossed.

debugger invoked on a SB-SYS:MEMORY-FAULT-ERROR in thread
#<THREAD "main thread" RUNNING {10004F04C3}>:
  Unhandled memory fault at #x0.

Works:
(ql:quickload '(:cl+ssl :sdl2))
(cl+ssl:ensure-initialized)

Fails:
(ql:quickload '(:sdl2 :cl+ssl))
(cl+ssl:ensure-initialized)

Same behaviour on CCL.

The latter form does fail for me
Clozure Common Lisp Version 1.12-dev (v1.12-dev.5-3-gb5233ade) LinuxX8664
On Mon, Nov 18, 2019 at 5:10 AM metayan<EMAIL_ADDRESS>wrote:

Did some more digging, and it's most likely not a CEPL issue.
Works:
(ql:quickload '(:cl+ssl :sdl2))
(cl+ssl:ensure-initialized)
Fails:
(ql:quickload '(:sdl2 :cl+ssl))
(cl+ssl:ensure-initialized)
Same behaviour on CCL.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cbaggers/cepl/issues/337?email_source=notifications&email_token=AAIODYY342EWGJ5D5X3FWTTQUJSZFA5CNFSM4I477S32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEJ5E5Q#issuecomment-554947190,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIODY4ACTZUY627AW5RG4DQUJSZFANCNFSM4I477S3Q
.

Narrowed the issue down - it appears with
(ql:quickload '(:cl-opengl :cl+ssl))
(cl+ssl:ensure-initialized)

Since it has nothing to do with CEPL, a new issue will be created in cl-plus-ssl.
This issue can be closed.

Thanks so much @metayan I'm not ready to dive back into lisp dev just yet, but this'll help a lot when I do. Hope your doing well!


MiniCPM vs Tesseract vs EasyOCR etc ...

Hello I saw your very compelling benchmark table, however I wonder how your model performs in comparison
to the "old" way of doing OCR, namely tesseract and other solutions which are not necessarily based on deep learning?
Are there any benchmarks or did somebody here make some tests to get a general idea how they compare in OCR? I can imagine MiniCPM being a fair bit better in terms of quality buy probably also much slower in terms of performance.

Hi! This is a very interesting question.
Yes, for OCR models in the traditional way, two-stage model, or sometimes even more stages, It's very different from the way we've implemented VLM so far. With our current training approach (natural language description of answers and questions), there is no way to compare this to traditional ocr models rigorously, but if we fine-tune our model or find natural language ways to describe traditional OCR tasks, for example, OCRBench.
Your work in this area is welcome, and I'm sure there are still some gaps here.


Allow overriding schema validation

As in jsonrpcserver, allow passing a custom function to do the validation, ( or do no validation).

There’s no schema validation any more in this library.


VS Code mouse selection is not transfered to Neovim

When selecting something with mouse on the VS Code side in normal mode only single character which was under cursor is affected by Vim command instead of whole selection.

I have same

Please, read the readme about this.

The readme saying about Neovim -> VS Code, but not about VS Code -> Neovim. It would be better to mention such case as well.

Yes, unfortunately mouse selection produces Neovim selection.

@Shatur95 the problem is that mouse selection does not produce Neovim selection.
For instance, while in visual mode, if you select using Shift + ← or the mouse, then x to cut, it does not cut your selection — it only cuts a single character.
I don't mind if selection doesn't propagate in the Neovim -> VS Code direction, but failure to propagate from VS Code to Neovim makes the extension a lot less usable.

@Shatur95 the problem is that mouse selection does not produce Neovim selection.
For instance, while in visual mode, if you select using Shift + ← or the mouse, then x to cut, it does not cut your selection — it only cuts a single character.
I don't mind if selection doesn't propagate in the Neovim -> VS Code direction, but failure to propagate from VS Code to Neovim makes the extension a lot less usable.

There is the option Mouse selection start visual mode but it's broken for a while.

but failure to propagate from VS Code to Neovim makes the extension a lot less usable.

Only relatively small subset of vim users are using mouse to select something, although i agree it's pain for those who get used to it

There is the option Mouse selection start visual mode but it's broken for a while.

but failure to propagate from VS Code to Neovim makes the extension a lot less usable.

Only relatively small subset of vim users are using mouse to select something, although i agree it's pain for those who get used to it

@lukeburns, yep, typo :)

@lukeburns, yep, typo :)

Ah gotcha!

Ah gotcha!

There is the option Mouse selection start visual mode but it's broken for a while.

but failure to propagate from VS Code to Neovim makes the extension a lot less usable.

Only relatively small subset of vim users are using mouse to select something, although i agree it's pain for those who get used to it

Ya it's probably not at the top of the list but I do know that I use it from some habits I've developed inside tmux. I don't use it all the time but when I want it it's nice when it's available. Would this be a hard fix?

For selection, the mouse is faster than hotkey VIM in a lot of cases.

For those maybe annoyed by this, I have tried to internalize the idea that insert mode is the mouses domain only, since this is where vscode takes over the most. You can use the mouse to select and use OS bindings (e.g. Ctrl+C, Ctrl+V) and things like clipboard manager (I'm using qclip at the moment) when using the mouse and remaining in insert mode. It might be a bit clumsy using the keyboard for selection to use neovim, but if you time yourself I think you'll find keyboard and mouse are pretty equivalent for selecting text but the speed-ceiling is maybe higher for proficient keyboard users - so it makes sense that that's the priority.
In saying that, I would loooove to see this bug fixed in an upcoming release. I love this extension and use it every day, and sometimes I'd prefer if all the normal neovim functionality was there like directly in neovim so I don't have to go in to a different mental-space as above.

This is a big sticking point for me and I too would love to get this fixed.
I don't have much knowledge of the implementation of this extension, but previously I was using VSCodeVim and that has mouse selection for visual mode.
If someone wants to elaborate on the issue a bit more, I'm happy to take a look at it. Absolutely loving the fact that I can use Nevoim in VSCode, and get the best of both worlds (especially since the v0.50 release!).

@scallaway It's not possible to implement this because neovim just don't have a way to fetch selection ranges except ones within the neovim viewport. The default viewport is 200 lines, so if you're trying to do something like vi{ inside 500 line code block - only 200 lines will be selected which is just wrong.

Looks like the mouse selection option is passed into MainController:
https://github.com/asvetliakov/vscode-neovim/blob/a4735e901cb154a91bd36643970abf4d953622a3/src/extension.ts#L21
https://github.com/asvetliakov/vscode-neovim/blob/a4735e901cb154a91bd36643970abf4d953622a3/src/extension.ts#L37-L46
Declared on MainController's options here:
https://github.com/asvetliakov/vscode-neovim/blob/a4735e901cb154a91bd36643970abf4d953622a3/src/main_controller.ts#L34-L50
But ignored here:
https://github.com/asvetliakov/vscode-neovim/blob/a4735e901cb154a91bd36643970abf4d953622a3/src/main_controller.ts#L201-L210
Additionally, it looks like changing the option will not take effect until the extension is restarted.
Hopefully this is a good starting point for anyone who wants to attempt a fix.

Another use-case is if you want to map a vim key to use vscode's capabilities to expand/shrink selections. I'd like to do this, but am unable to, because the vscode's expanded/shrinked selection doesn't get converted to a vim one.
Is there any movement on merging the PR with the fix?

Fixed by #723


superfluous error handling removed

The err variable can not have changed, because the previous function, does not give back an error variable

lgtm, seems like consequences of weird merging, thanks


How to handle SBD* (Steem Dollars) and SCR* (Scorum)

Greetings.
I'm trying to do the following:
cc.priceMulti(['STEEM', 'SBD*', 'GOLOS', 'GBG', 'SCR*', 'VIT'], ['USD', 'BTC']).then(prices => {
	console.log(prices.SBD*.USD);
        console.log(prices.SCR*.USD);
} ).catch(console.error)

But because the SBD contains the star symbol javascript drops out with error:
SyntaxError: Unexpected token .
When I'm trying to add quotes like ' and ", or use backslash to protect the star like SBD*, it doesen't help either.
When I am trying to navigate inside the array like prices[0][1].USD; javascript drops out with error SyntaxError: missing ) after argument list.
Is there any ways of using data about SBD and SCR cryptos?
Thanks.
Den

You need to do console.log(prices['SBD*'].USD)

You need to do console.log(prices['SBD*'].USD)

Wow thank you very much for your fast & easy solution. Should have found this myself :)


[BP-1.14][FLINK-27174][connector/kafka] Fix checking of bootstrapServers when already provided in producer Properties

This is a backport PR for #19628

Sorry I don't quite understand what you mean. Should I rebase my branch fix-kafkasink-check-1.14 onto the latest release-1.14 branch, and then force push.

Sorry I don't quite understand what you mean. Should I rebase my branch fix-kafkasink-check-1.14 onto the latest release-1.14 branch, and then force push.

Yes exactly, I think the problem the CI currently shows has been fixed but you need to rebase and force push.

@flinkbot run azure

@flinkbot run azure


Web app ignore newer version

Hi,
I updated my "old" tinode server from 0.18 to 0.20 and now 0.21.0-rc1, but can't force the web app to update to the latest version. Restartet, reloaded in browser and also deleted all website data / settings, but still old client version is shown?
Got it updated on desktop Chrome browser. Fail with Chrome for Android @ OnePlus

Feature request: Add a force update button somewhere to update the client side (cached) app data?

I cannot reproduce

I have 3 web app clients.
Smartphones stick to 0.18.x and 0.20.2 without a way to force refresh the web app. Delete browser cache and website settings isn't helping here. Both are Chrome for Android with installed to homescreen.
Desktop Chrome works fine and is up to date connected to the same server. Just not installed to homescreen / webapp.
Maybe my problem is related to the updates from 0.18.x to 0.21.0-rc1 via 0.20.2. A one time "fix" to force a update / refresh would be nice.

https://browserhow.com/how-to-do-hard-refresh-and-reload-webpage-in-chrome-android/


Removed the method CommandLineBasedKeystoreGenerator::getSplitCommand…

…NameBasedOnOeratingSystem
Fixes issue #198
Removed the above mentioned method. It was returning "gcsplit" when the "os.name" property was "mac", and "csplit" otherwise.
Since Intersmash supports only Linux execution, I hardcoded the value "csplit" where the method call was returning this value, as it is not supposed to change.
Description

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] Feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change
[ ] Chore (non-breaking change which doesn't affect codebase;
test, version modification, documentation, etc.)

Checklist

[x] Code contributed by me aligns with current project license: Apache 2.0
[x] Pull Request contains a description of the changes
[x] Pull Request does not include fixes for multiple issues/topics
[x] Code is self-descriptive and/or documented
[ ] I have implemented unit tests to cover my changes
[x] I tested my code in OpenShift

/test

Intersmash PR CI check results
Hi @TheMarvelFan, this comment is meant to report the outcome of Intersmash integration tests,
which were triggered by @fabiobrz comment, see https://github.com/Intersmash/intersmash/pull/203#issuecomment-2374264757.
CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#136> FAILED:

Intersmash integration tests job <eap-8.x-intersmash-integration-tests-community#64> reported failures.

Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap#74> reported failures.

Intersmash integration tests job <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp#80> reported failures.
Please verify your changes locally or reach out to maintainers in order to investigate the issues.

/test

Intersmash PR CI check results
Hi @TheMarvelFan, this comment is meant to report the outcome of Intersmash integration tests, which were triggered by @fabiobrz comment, see #203 (comment).
CI checks job <continuous-testing-umb-listener-for-intersmash-pr-checks#136> FAILED:
* Intersmash integration tests job <_eap-8.x-intersmash-integration-tests-community#64_> reported failures.

<eap-8.x-intersmash-integration-tests-community#64> reported 1 failure, i.e.:
cz.xtf.core.waiting.WaiterException:
Following events match condition: <at least one exists>
	2024-09-25T14:49:37Z	Build/wildfly-test-app-1	Build appsint-asfl/wildfly-test-app-1 failed
Filter:	 obj names: [wildfly-test-app.*]
	 messages: [Failed to pull image.*, Build.*failed, Error syncing pod, skipping: failed to.*, FailedMount MountVolume.SetUp.*, Error creating: pods.*is forbidden:.*, .*failed to fit in any node.*, Failed to attach volume.*]
	 after: 2024-09-25T14:48:03Z

	at org.jboss.intersmash.testsuite.provision.openshift.WildflyImageProvisionerTestCase.deploy(WildflyImageProvisionerTestCase.java:57)
...

which is a new one, but unrelated to the changes in this PR. We're investigating it as it happens with the main branch too. :yellow_circle:

* Intersmash integration tests job <_eap-8.x-intersmash-integration-tests-products-jboss-eap#74_> reported failures.

<eap-8.x-intersmash-integration-tests-products-jboss-eap#74> reported 1 failure, i.e.:
java.lang.AssertionError:
1 expectation failed.
Expected status code <200> but was <503>.

	at org.jboss.intersmash.testsuite.provision.auto.AutoProvisioningTests.testAppIsLive(AutoProvisioningTests.java:53)

which is an intermittent one, reported as fixed by the subsequent run: <eap-8.x-intersmash-integration-tests-products-jboss-eap#75>   :white_check_mark:

* Intersmash integration tests job <_eap-8.x-intersmash-integration-tests-products-jboss-eap-xp#80_> reported failures.

<eap-8.x-intersmash-integration-tests-products-jboss-eap-xp#80> reported 3 failures, i.e.:

org.jboss.intersmash.testsuite.provision.openshift.ProvisionerCleanupTestCase.testProvisioningWorkflowCleanup

cz.xtf.core.http.HttpsException: javax.net.ssl.SSLHandshakeException: Remote host terminated the handshake
	at ...

org.jboss.intersmash.testsuite.provision.openshift.WildflyTargetServerTestCase.deploy

cz.xtf.core.waiting.WaiterException:
Following events match condition: <at least one exists>
	2024-09-25T15:48:09Z	Pod/wildfly-test-app-1-z7kxz	Failed to pull image "image-registry.openshift-image-registry.svc:5000/appsint-main-qmhx/wildfly-test-app@sha256:380949daddd4b090a19ab332d20f418dc966919bb67ff6d0b851390b8a6a8311": unable to retrieve auth token: invalid username/password: authentication required

org.jboss.intersmash.testsuite.provision.openshift.WildflyBootableJarTestCase.deploy

cz.xtf.core.waiting.WaiterException:
Following events match condition: <at least one exists>
	2024-09-25T15:48:50Z	Build/bootable-jar-1	Build appsint-main-qmhx/bootable-jar-1 failed
Filter:	 obj names: [bootable-jar.*]
	 messages: [Failed to pull image.*, Build.*failed, Error syncing pod, skipping: failed to.*, FailedMount MountVolume.SetUp.*, Error creating: pods.*is forbidden:.*, .*failed to fit in any node.*, Failed to attach volume.*]

All of them are intermittent issue, reported as fixed by the subsequent run: <eap-8.x-intersmash-integration-tests-products-jboss-eap-xp#81>   :white_check_mark:
Based on the above findings, the changes in the PR are deemed to pass the integration tests and can now be reviewed.

Can you please elaborate about the failing tests?

Sure @TheMarvelFan - what you see here is the result of integration tests which have been triggered by a comment of mine.
The report is posted as a comment made by me, although it is an automated process.
This is a temporary solution which we're testing and improving right now. In theory we aim at using a service account and proper checks. See more details here.

I have followed all the conventions listed in CONTRIBUTING.md, and I don't understand what the issue is here.

Hopefully it's more clear now, but definitely thank you for your feedback, which helps us improve the CI processes and the related documentation.
As you can see above, I've then reviewed the failures in the jobs which are mentioned in the report, and have deemed the changes to pass the integration tests :slightly_smiling_face:


[Feature Request] Support airgap for join subcommand

Is your feature request related to a problem? Please describe.
I created a cluster by specifying --package-path which means airgap installation. After that, I attempted to join a new node into the cluster, but no airgap-related option was found in the options list.
Describe the solution you'd like
add airgap support for the join subcommand.
Describe alternatives you've considered
Additional context

Hi @tu1h Thanks for your feedback.
If you create the cluster with the airgap configuration, you don't need to specify the --package-path because AutoK3s will use the same package(which you passed to create this cluster) to execute the join node logic.

@JacieChao Thanks for the reply.
From the information below, the mycluster is a cluster created by --package-path, then I attempted to join a node, but it looks like it doesn't use the airgap package.


On osmdroid 5.2. I want redefine the double tap, how done?

I work with OSMDROID 5.2. I run a map with gestural movements zooming and scrolling. Only I would like in some cases define another event for dual touch. That is to say, when I do a double tap on the map, I do not zoom, but does something else. How could I do?

Extend the Default Overlay manager, then override onDoubleTap. That should do it

Thank you for the answer. But that's not enough, I want to prohibit the dual touch makes a zoom on the map without removing the possibility gestural.

The answer i provided will get you the right direction. Overriding the double tap method to do nothing should solve your problem.

Ah, thank you, I succeeded with your help, I forget to remove the "return super.onDoubleTap(e, mapView)" and put in place a "return true" in my Overlay.onDoubleTap (). Merci beaucoup.

This code works for me
import android.content.Context;
import android.view.MotionEvent;

import org.osmdroid.tileprovider.MapTileProviderBase;
import org.osmdroid.views.MapView;
import org.osmdroid.views.overlay.DefaultOverlayManager;
import org.osmdroid.views.overlay.TilesOverlay;

public class MyOverlayManager extends DefaultOverlayManager{

    /**
     * Create MyOverlayManager
     */
    public static MyOverlayManager create(MapView mapView, Context context) {
        MapTileProviderBase mTileProvider = mapView.getTileProvider();
        TilesOverlay tilesOverlay = new TilesOverlay(mTileProvider, context);
        mapView.getTileProvider();
        mapView.setOverlayManager(new MyOverlayManager(tilesOverlay));

        return new MyOverlayManager(tilesOverlay);
    }

    /**
     * Default constructor
     */
    public MyOverlayManager(final TilesOverlay tilesOverlay) {
        super(tilesOverlay);
    }

    /**
     * Override event & do nothing
     */
    @Override
    public boolean onDoubleTap(MotionEvent e, MapView pMapView) {
        return true;
    }

    /**
     * Override event & do nothing
     */
    @Override
    public boolean onDoubleTapEvent(MotionEvent e, MapView pMapView) {
        return true;
    }
}

And I use like tihis
mapView.setOverlayManager(MyOverlayManager.create(mapView, context));


check import of FAERS indication data

Using the code in https://github.com/SuLab/faers, Greg parsed FAERS data for drug indications and produced this file https://zenodo.org/record/1436000#.XWcVWShKguU.  In that file (record 836), there are three diseases listed for the drug bupropion: Depression, Anxiety, Bipolar disorder.  However, in the bot run to add FAERS indications, the diff for bupropion only added anxiety: https://www.wikidata.org/w/index.php?title=Q834280&diff=756477246&oldid=737266253
Should investigate why...  (and while we're at it, look at automating the parsing and updates...)
(tagging @stuppie in case you remember a reason why this might have been by design...)

In looking at the example of bupropion, it appears that the corresponding Wikidata entries for the diseases depression and bipolar disorder do not have the MONDO IDs listed in the FAERS data.
No Mondo IDs in Q4340209 or Q131755; and cannot pull any entries up with SPARQL queries for MONDO:0002050 or MONDO:0004985 the way you can for MONDO:0011918. The function 'normalize_to_qids' appears to use MONDO IDs:
mondo_qid = wdi_helpers.id_mapper(PROPS['Mondo ID'])
The FAERs data does have CUIs for the indications, and a quick SPARQL query with the corresponding CUIs for depression and bipolar disorder will successfully pull up the Wikidata entities for the two.


Add DODOchain Testnet chain

Description
Add DODOchain Testnet chain
Type: <New | Updated> <Network | Warp Route>
New Network
Network(s): <Network Name(s)>
DODOchain Testnet
Other notes
Backward compatibility
Testing

Thanks @jmrossy ,I have fixed these problems, please confirm whether they can be merged


Create Serverless Logic with Azure Functions - Spanish translation

This issue is for the short workshop on Create Serverless Logic with Azure Functions being translated into Spanish
The structure of the translation should follow other translations like https://github.com/microsoft/workshop-library/tree/main/full/intro-nlp-tensorflow/translations

thank you, @ElianaRocio! for taking this one 🚀


Stage Display Notes

In version 1.0.10 (and 9), the Presentation Bridge Client is not reading Stage Display Notes in ProPresenter 6. I had to downgrade to 1.0.8 to get it to work. I am on MacOS.
It is connected to ProPresenter as it shows connected and I can see Current and Next Slide in the Monitor, but it is not picking up the Stage Display notes where I am simply entering: Companion:3,3

Is the command terminated with a ;

It is not. And it isn't in 1.0.8 where it is working. Is that a change in 1.0.9 and 1.0.10?

Looks like there was a change in 1.0.9 where the semicolon is now required.
Here is the bit in the help file where it mentions needing the semicolon: https://github.com/josephdadams/presentationbridge-client/blob/10f1fbe4909803d087aa1507d01f84268366f829/help.md?plain=1#L18

Thanks for that. If that is the case, I believe the examples need updated. I will verify a semi-colon works next time I am at church.

@tgladson : Good call on the examples. I will send over a PR to get those fixed.
@jrviz : Since this is potentially a breaking change for some people (the ; was optional before, so many people probably skipped it), is it possible to add a note to the release tag for v1.0.9 giving a heads up that it is required now?

Can’t we also just read the string before parsing the commands and append a semicolon programmatically if it’s not there?

OK. I'll take a look at some ideas. I made the change to allow multiple commands to occur anywhere in the notes string which may also contain other notes.

Fixed in #17


Restore the language metrics, this time without the 'unsubmitted' section

Don't understand those Hakiri warnings since that is definitely fixed... seems incorrect on their part.


add clusterlist delete function and code format

There are not a delete cluster function when click the clusters tab. I add a delete button on the cluster list page and do some code format.

Really needed PR, thanks a lot @lantian0802 !!!
I just put some minor changes, but besides that :+1: !

ok，I will fix the code what you point out.

@lantian0802 thank you very much :-D


cutegram: Build with qt59

Motivation for this change
See https://github.com/NixOS/nixpkgs/issues/33798
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Builds and starts fine
cc @Profpatsch @AndersonTorres

After putting in my system closure and reboot (current master):
> cutegram
QQmlComponent: Component is not ready
"file:///nix/store/xyqbq9781wr3qqw1nd15w99li9pgmp38-cutegram-2.7.1/share/cutegram/themes//Abrisham.qml:3 module \"QtQuick\" is not installed\n"
qrc:/qml/Cutegram/main.qml:5:1: module "QtGraphicalEffects" is not installed
qrc:/qml/Cutegram/main.qml:4:1: module "QtQuick.Controls" is not installed
qrc:/qml/Cutegram/main.qml:1:1: module "QtQuick" is not installed
qrc:/qml/Cutegram/main.qml:5:1: module "QtGraphicalEffects" is not installed
qrc:/qml/Cutegram/main.qml:4:1: module "QtQuick.Controls" is not installed
qrc:/qml/Cutegram/main.qml:1:1: module "QtQuick" is not installed
qrc:/qml/Cutegram/main.qml:5:1: module "QtGraphicalEffects" is not installed
qrc:/qml/Cutegram/main.qml:4:1: module "QtQuick.Controls" is not installed
qrc:/qml/Cutegram/main.qml:1:1: module "QtQuick" is not installed
^C⏎


Remove the connector configuration dataset YAML upload form

Is your feature request related to a specific problem?
There are two YAML forms that can be used to create datasets right now, one from the dataset management UI, and one from the connector configuration management UI. We should only have one now that we are unifying the ops and ctl datasets
Describe the solution you'd like
IMO it would make sense to remove the connector configuration YAML form:

And replace it with a multiselect that allows you to connect existing datasets to this connector. If they need to create a new one, then we should redirect them to the dataset management UI to create a dataset.
Describe alternatives you've considered, if any
Leave as-is, but there are some caveats described in https://github.com/ethyca/fides/pull/2113 which make this UX a bit strange if we leave it.
Additional context
Follow up to https://github.com/ethyca/fides/issues/1766
I'd like to get @rsilvery 's thoughts on how/if we should go about this. If we do, we may also need designs.

I know we'd like to keep the more featured one. Working with @mfbrown to figure out how to sunset one of them.

Most of this is being handled in https://github.com/ethyca/fides/issues/1531. We need to make sure that there's some protection to prevent overwriting datasets.

Suggestion from @mfbrown : check for the existence of the fides key for the dataset and, if found, confirm user wants to overwrite.

https://github.com/ethyca/fides/issues/1531 will handle upgrading the dataset YAML form to use the same YAML editor as the connector one.
This ticket should focus on replacing the existing YAML form with a select dropdown of existing ctl datasets. If the dataset the user wants to link does not exist yet, we should redirect them to the adding a dataset flow.

Decision:

Add a drop down to the Connectors dataset UI to select an existing dataset.
If a dataset is selected in this menu, the editor is disabled. If it's unselected, the editor returns
Once we've implemented this and can show it to design, get feedback and adapt as needed.

Nice path forward here! ^


Update TAC representatives - 20210101

Signed-off-by: John Mertic<EMAIL_ADDRESS>

As a related FYI, the public web page on aswf.io is pretty outdated -- some old affiliations and titles, etc.

As a related FYI, the public web page on aswf.io is pretty outdated -- some old affiliations and titles, etc.

Can you detail the updates needed? Just want to ensure I don't miss anything.

Can you detail the updates needed? Just want to ensure I don't miss anything.

I don't have a comprehensive list. Chris (affilliation), Daniel and Kimball (ASWF roles) for sure, and I'd recommend spot check the others that you changed in this PR.

I don't have a comprehensive list. Chris (affilliation), Daniel and Kimball (ASWF roles) for sure, and I'd recommend spot check the others that you changed in this PR.

Fixed those

Fixed those


Readonly Mode for People Picker in Adaptive Card

We have a use case where we need to display people's avatar and name on Adaptive Card by providing their AAD Object IDs. It's basically the same as pre-populated People Picker, only read-only. Is this viable? Appreciate it!

@johnmiroki - Will it be ok if we use Power automate to send adaptive card having user image in MS Teams?

@Prasad-MSFT Thanks for answering my questions. Our backend is an Azure Bot (using Java SDK). The requested functionality should be easy to implement, I mean, the infrastructuer is there: People Picker can already show people's avatar and name, the only extra thing is to make the People Picker read-only (and of course, prepopulated with provided user ids).

@johnmiroki - setSelected property must be passed which is Microsoft Azure Active Directory (Azure AD) IDs of the people to be preselected. This parameter preselects people while launching the People Picker input control.
or get user profile details using graph API and you can use custom code to show the name & profile picture in UI.

@Prasad-MSFT Thank you. Unfortunately, we use pure Adaptive Card and there's no js involved.

@johnmiroki - Then only way would be getting user profile details using graph API and using custom code to show the name & profile picture in UI.

@Prasad-MSFT Thank you. It looks what you said is the only way for now. TBH, it's such a waste. A small tweak to the exisiting People Picker would make showing avatar and name such a trivial effort.

@johnmiroki - Please let us know if you need any further help or shall we close this issue?


Fix python environment setup

User story
We want to make setting up the environment easy between collaborators.
Problem solution
Our first pass at setting up a shared python environment was the wrong approach.
Instead we should be using a requirements.txt file and not committing the venv files.

Do I need to change this for myself also?

Yes, you should change it for yourself as well
On Wed, Oct 16, 2024 at 1:50 PM Jacob Allen @.***>
wrote:

Do I need to change this for myself also?
—
Reply to this email directly, view it on GitHub
https://github.com/CorningTopTier/expense-report/issues/9#issuecomment-2417512068,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABPR6QNWRWR772DEEVKFBHTZ32RNZAVCNFSM6AAAAABPJ46YSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJXGUYTEMBWHA
.
You are receiving this because you modified the open/close state.Message
ID: @.***>


[hotfix] Markdown  comments

Resolves https://github.com/CenterForOpenScience/osf.io/issues/2267
Changes

Renders comment content using the markdown-it renderer
Adds an edit button which toggles comment input

Side effects
The display element for the markdown content now uses the html rather than the text binding. We rely on markdown-it-sanitizer rather than Knockout to sanitize the comment content.

LGTM


Crypto-Input Try-Catch

Release Checklist
Pre-Release

[x] Check migrations

No database related infos (sqldb-xxx)
Impact on GS (new/removed columns)

[x] Check for linter errors (in PR)
[x] Test basic user operations

Login/logout
Registration
Update user data
Create/delete payment routes

Post-Release

Test basic user operations
Monitor application insights log

da fehlt doch noch ein Koma!


Allow marking of folders (i.e. all its files recursive) as viewed

I often have to review large PRs which include both, server & client code, where I'm only interested in the client code. In such situations, I always start by marking all server files as viewed which can be very tedious when there are many files involved.
-> This would be much easier if I could just mark a whole directory as viewed including all files recursively
I know that I could just collapse the folder and ignore it in the review but my overall workflow often benefits from explicitly marking those files as reviewed. E.g. I occasionally have to switch between VSCode and the GitHub PR page during PRs, where I get a better overview if the files I'm not interested in are marked as viewed etc.
This, in combination with the ability to hide viewed files (#3330) would improve my workflow tremendously.

Related to https://github.com/microsoft/vscode-pull-request-github/issues/3274

Isn't this covered by https://github.com/microsoft/vscode-pull-request-github/issues/3988?

yes, this is accomplished through #3988.


Save space for error messages in order to avoid page jumps on validation

Which package is this issue related to?
ffe-form
Describe your issue (screenshots welcome!)
In some instances the page layout may jump when validation error messages are inserted, because an extra line of content is injected into the page flow.
Without error message:

With error message:

This can be avoided by saving the space needed for an error message by default (padding, height, etc), then positioning the error message absolute or in other ways style it so that it does not affect the height of its containing block.
What is the expected behavior?
The page flow should not change on validation.
What is the actual behavior?
The page jumps.
Steps to reproduce

For this to work, we'll have to require that no error message ever wraps to the next line, right?

The consensus seems to be that as a general guideline they shouldn't wrap, and in instances where the error message needs to be more than one line of text for whatever reason, we are willing to live with the layout shift.

Then I guess absolute positioning is out of the question :)

@antidecaf You were thinking about something like this? Anything that makes the error-message larger than lineheight will still shift the layout.
I obviously had to increase the bottom margin of inputgroups (well, actually inputs contained in inputgroups) to leave open room for the error, I am unsure if that is a breaking change or not? And should I put in an opt-out prop for those that absolutely for no reason want the extra margins and rather would take the layout shift?
Also, haven't tested this with inline/text-like but can do that if we still want this.

Yes, this is pretty much what I had in mind. I'm not really sure if this is really a breaking change either, but there will be visual diffs, I suppose. Anyway, given the age of this issue, perhaps we should run it by the designers at the next forum?

@antidecaf Sure, but given previous experiences with doing that it's gonna end up burying the issue completely :D Anyway, it's fairly easy to solve with collapsing margins if they ever get back to us on it.

@ivarni Lol, I mean, if you already have an implementation ready, you might as well send a PR. :sunglasses:

@antidecaf That was what I was thinking, and then we can instead ask if they want us to remove it. It needs some polishing but there's not a lot of work really.

@antidecaf The radio blocks are giving me grief..
<fieldset class="ffe-fieldset ffe-input-group">
    <legend class="ffe-form-label ffe-form-label--block">Velg ja eller nei</legend>

Feil valg

</fieldset>

Given the above HTML, a selector like
.ffe-fieldset {
    .ffe-radio-block:last-child {
        margin-bottom: 30px;
    }
}

isn't matching the last radio-block because there is a different child in the mix. :last-of-type also fails to match. It stops matching the moment the div with the error message shows up.
Any tips?

This is supposed to work so I must be doing something wrong somewhere

last-of-type doesn't target the last element with a class, but the last one of a given type of element afaik. So in this case, .ffe-field-error-message is the last of type div and thus your selector would only be valid if the last div inside the container had the .ffe-radio-block class. Maybe the error message should be a paragraph in stead of a div?

@antidecaf Ah, that makes sense. I always get the Benny Hill theme playing in my head when I write CSS and this would be why.
So there's no way of writing a selector to hit the last element of class .ffe-radio-block in this instance? I suppose the error message could be a p though, just feels like this should be possible without changing it.

I'm not entirely sure if this works, but maybe fooling the definition of type using an attribute selector might do the trick? Something along the lines of:
[class~='ffe-radio-block']:last-of-type

I'll try that later, and if not I can swap the error element to a p.
:first-of-type did work, so I could do
.ffe-radio-block {
    margin-top: -10px;
    margin-bottom: 30px;

   &:first-of-type {
       margin-top: 20px;
   }
}

But I kinda threw up in my mouth a little so unless your trick works I'll go with a p.


nitpick: decrease cognitive complexity in buildah-bud

NOTE: this is another suggestion I have. It doesn't mean I don't like the coding style - it's just my own opinion and if you think it's not vital feel free to close it. :smile:
A small nitpick to cmd/buildah/bud.go.
from:
if cliArgs > 0 {
  ... // 5 LOC
} else {
  return error
}

to:
if cliArgs == 0 {
  return error
}
... // 5 LOC

The latter style makes the code flow better than with if-else (IMHO).

LGTM
I like the change.

@TomSweeneyRedHat @pixdrift @vrothberg @umohnani8 PTAL

LGTM

bot, retest this please.

LGTM once tests are happy.  Looks like a registry network flake.

LGTM as well
@rh-atomic-bot r=TomSweeneyRedHat


Restore issues

I am trying to restore data and seeing following issues:

Missing cluster.[key|value|header].deserializer configs
[2020-04-28 18:35:21,628] WARN [Producer clientId=connector-producer-backup-source-0] Bootstrap broker localhost:9092 (id: -1 rack: null) disconnected (org.apache.kafka.clients.NetworkClient:1031)
Never showed message All records read. Restore was successful
[2020-04-28 18:35:32,201] ERROR WorkerSourceTask{id=backup-source-0} Failed to flush, timed out while waiting for producer to flush outstanding 1 messages (org.apache.kafka.connect.runtime.WorkerSourceTask:438) [2020-04-28 18:35:32,202] ERROR WorkerSourceTask{id=backup-source-0} Failed to commit offsets (org.apache.kafka.connect.runtime.SourceTaskOffsetCommitter:114)

FWIW - we have authentication enabled in our cluster. It is authentication to ZK/interbroker/client. client auth is SCRAM-SHA-256 (SASL_PLAINTEXT)

Hi,
Are you using the new restore-standalone.sh tool? That should help you with the issues. You can simply add the SASL credentials via the --command-config argument.
If not, please provide the config you are using.

I assume this is fixed ;)


fix(scully): fix type of puppeteerLaunchOptions (#1451)

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/scullyio/scully/blob/main/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Other... Please describe:

What is the current behavior?

puppeteerLaunchOptions is typed as LaunchOptions
Issue Number: #1451
What is the new behavior?
puppeteerLaunchOptions is typed as PuppeteerNodeLaunchOptions
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Is there a timeline for this to be released? My team is currently running into this issue.

I'm aiming for today.


TypeError: Cannot read property 'toFixed' of undefined

Prozessing File:Pereslavl_narrow_gauge_railway_1990.svg with

svgo -i Pereslavl_narrow_gauge_railway_1990.svg -o output.svg --pretty --indent=1

leads to
TypeError: Cannot read property 'toFixed' of undefined     at strongRound (C:\Users\jkalliau\AppData\Roaming\npm\node_modules\svgo\plugins\convertPathData.js:766:21)     at C:\Users\jkalliau\AppData\Roaming\npm\node_modules\svgo\plugins\convertPathData.js:424:17     at Array.filter (<anonymous>)     at filters (C:\Users\jkalliau\AppData\Roaming\npm\node_modules\svgo\plugins\convertPathData.js:272:17)     at Object.exports.fn (C:\Users\jkalliau\AppData\Roaming\npm\node_modules\svgo\plugins\convertPathData.js:79:20)     at C:\Users\jkalliau\AppData\Roaming\npm\node_modules\svgo\lib\svgo\plugins.js:61:45     at Array.filter (<anonymous>)     at monkeys (C:\Users\jkalliau\AppData\Roaming\npm\node_modules\svgo\lib\svgo\plugins.js:48:39)     at C:\Users\jkalliau\AppData\Roaming\npm\node_modules\svgo\lib\svgo\plugins.js:68:17     at Array.filter (<anonymous>)
(Same as in https://github.com/svg/svgo/issues/987, except here I don't specify convertPathData, therfore it is enabled.)

input.svg.txt

Can confirm this is not an issue in v1.2.2

Yep, looks like this issue is fixed with v1.2.2

Need to keep in mind if upgrading that the issue exists in 1.3.0

Seems like no more an issue.

Seems like no more an issue.

@GreLI no, this issue exists in 1.3.0
The issue is not present in 1.2.2.
Please reopen.

Can you elaborate? I couldn't reproduce.

I tried with 1.3.0 (updated with npm install -g svgo some days ago)
I tried
https://upload.wikimedia.org/wikipedia/commons/f/f2/Pereslavl_narrow_gauge_railway_1990.svg
and I tried
https://github.com/svg/svgo/files/2129417/input.svg.txt
both did not have the reported issue, but a different one the Text 78H-0525 on the top has a problem the H moved to the right, but I that might be a rounding-error. I would consinder this issue as closed.
@justrhysism  Maybe you have another example and you might start a new issue?

@JoKalliauer yeah I'll create a new test case and submit a new issue if @GreLI is happy with a new issue for the same error.

Has the issue been fixed?

In July I was not able any more to reproduce this bug with the file above, therefore I consider it as fixed, and would keep it closed.
If the result depends on bondary conditions (like which OS) it is a different problem, and should be reported imho in a new issue.
If the error was reintroduced, it is imho a new bug and therefore a new issue.
If another file produces the same bug, it imho another issue with the same Error-message.
Therfore I consinder my reported ssue as fixed.
If someone has the same error-message, they should in my opinon write a new bug-report (svg-file, version of SVGO, Operating system,...) and should refer to this issue.

I've had this issue recently using svgo v1.3.0. I rolled back to v1.2.2 and it was fixed. postcss-svgo includes svgo v1.3.0 and it won't compile base64 svgs without this error. It doesn't happen on all base64 svgs which makes it hard to troubleshoot.

I am seeing this error in gulp-imagemin with an svg that is of text that has been converted to outlines.

[12:03:47] gulp-notify: [Error running Gulp] TypeError in plugin 'gulp-imagemin'
Message:
Cannot read property 'toFixed' of undefined
Details:
fileName: /Users/adamhite/Sites/am-banners/src/kestra-financial/2019-campaign-awareness/src/emoney-300x250/images/text1.svg
[12:03:47] TypeError: Cannot read property 'toFixed' of undefined
at strongRound (/Users/adamhite/Sites/am-banners/src/kestra-financial/2019-campaign-awareness/node_modules/svgo/plugins/convertPathData.js:766:21)
at /Users/adamhite/Sites/am-banners/src/kestra-financial/2019-campaign-awareness/node_modules/svgo/plugins/convertPathData.js:424:17
at Array.filter ()
at filters (/Users/adamhite/Sites/am-banners/src/kestra-financial/2019-campaign-awareness/node_modules/svgo/plugins/convertPathData.js:272:17)
at Object.exports.fn (/Users/adamhite/Sites/am-banners/src/kestra-financial/2019-campaign-awareness/node_modules/svgo/plugins/convertPathData.js:79:20)
at /Users/adamhite/Sites/am-banners/src/kestra-financial/2019-campaign-awareness/node_modules/svgo/lib/svgo/plugins.js:59:45
at Array.filter ()
at monkeys (/Users/adamhite/Sites/am-banners/src/kestra-financial/2019-campaign-awareness/node_modules/svgo/lib/svgo/plugins.js:46:39)
at /Users/adamhite/Sites/am-banners/src/kestra-financial/2019-campaign-awareness/node_modules/svgo/lib/svgo/plugins.js:66:17
at Array.filter ()

@adam-hite it may be because of incorrect image. But as I see by stacktrace, there is outdated version of SVGO underhood.

Same as @djmtype! Rolling back to v1.2.2 fixed this error for me. Yet to pinpoint the root cause.

we are rolling back too.

I have the same issue in multiple projects. I am not sure whether this is caused from recent svgo or an outdated svgo used as sub-dependency of another package.

So I've experienced this with babel-plugin-inline-react-svg today, but they won't update their version of svgo because this library was updated to be asynchronous. Here's an issue about that: https://github.com/svg/svgo/issues/1015
Is this essentially a catch-22 where neither library will make a move in either direction?
It was an easy fix for me to re-optimise my SVG to not strip the zero integer, but it may not always be that way...

Example of svg that triggers this error:
<svg xmlns="http://www.w3.org/2000/svg" width="40" height="40" viewBox="0 0 40 40">
    <path d="M40.142 33.91L29.82 23.59a14.698 14.698 0 00.07-13.6 14.75 14.75 0 10-5.902 19.595l10.224 10.224 5.93-5.897zm-23.387-7.562a9.633 9.633 0 119.65-9.552 9.616 9.616 0 01-9.65 9.552z"/>
</svg>

Have you tried to update to a recent version of svgo, also as a sub-dependency? https://github.com/svg/svgo/issues/990#issuecomment-570012473

This is another SVG causing the same error:
<svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" stroke="currentColor">
  <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M10 14l2-2m0 0l2-2m-2 2l-2-2m2 2l2 2m7-2a9 9 0 11-18 0 9 9 0 0118 0z" />
</svg>

I'm using the Nextjs v10 with the following configuration in next.config.js
module.exports = {
  publicRuntimeConfig: {
    mapboxApiAccessToken: process.env.REACT_APP_MAP_KEY,
    localeSubpaths: typeof process.env.LOCALE_SUBPATHS === 'string' ? process.env.LOCALE_SUBPATHS : 'none',
  },
  i18n: {
    locales: ['en', 'ar'],
    defaultLocale: 'en',
  },
  images: {
    domains: ['assets.vercel.com'],
  },
  webpack: config => {
    config.module.rules.push({
      test: /\.svg$/,
      include: [require('path').resolve(__dirname, 'statics')],
      use: ['@svgr/webpack'],
    });

    return config;
  },
};

@GreLI
Is it possible to reopen this issue? As long being closed, no one will take proper action. Thanks in advance.

This is another SVG causing the same error:
<svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" stroke="currentColor">
  <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2" d="M10 14l2-2m0 0l2-2m-2 2l-2-2m2 2l2 2m7-2a9 9 0 11-18 0 9 9 0 0118 0z" />
</svg>

I'm using the Nextjs v10 with the following configuration in next.config.js
module.exports = {
  publicRuntimeConfig: {
    mapboxApiAccessToken: process.env.REACT_APP_MAP_KEY,
    localeSubpaths: typeof process.env.LOCALE_SUBPATHS === 'string' ? process.env.LOCALE_SUBPATHS : 'none',
  },
  i18n: {
    locales: ['en', 'ar'],
    defaultLocale: 'en',
  },
  images: {
    domains: ['assets.vercel.com'],
  },
  webpack: config => {
    config.module.rules.push({
      test: /\.svg$/,
      include: [require('path').resolve(__dirname, 'statics')],
      use: ['@svgr/webpack'],
    });

    return config;
  },
};

@GreLI
Is it possible to reopen this issue? As long being closed, no one will take proper action. Thanks in advance.

This issue just popped up in my notifications. Has anyone edited or added something I hadn't noticed?

This issue just popped up in my notifications. Has anyone edited or added something I hadn't noticed?

Same here today, other "old" svg's on the project are fine. hmm?

@trainoasis: Check your dependency tree for outdated svgo packages, see these instructions
https://github.com/svg/svgo/issues/990#issuecomment-570012473

@dingo-d: Check your dependency tree for outdated svgo packages, see these instructions: https://github.com/svg/svgo/issues/990#issuecomment-570012473


Baruk's name in Japanese

Baruk's name is still in Japanese even though it's translated in the file.

Revert Baruk's name back to the original. This will be reflect in SLPS file.

Fixed.


[featurerequest] Add PercentProcessorTime Counter

Hi there,
Would it be possible to add the PercentProcessorTime counter to the CPU collector?
Sample query:
select PercentProcessorTime from Win32_PerfFormattedData_PerfOS_Processor where Name = '_Total'
“PercentProcessorTime,” as appears above, is the percentage of the time the processor is busy doing non-idle threads.
Cheers,
Christian

Hi,
This was discussed recently, see #53.


Hooks under VideoProvider directory is being used outside?

Question
In VideoProvider/index.tsx:
/*
 *  The hooks used by the VideoProvider component are different than the hooks found in the 'hooks/' directory. The hooks
 *  in the 'hooks/' directory can be used anywhere in a video application, and they can be used any number of times.
 *  the hooks in the 'VideoProvider/' directory are intended to be used by the VideoProvider component only. Using these hooks
 *  elsewhere in the application may cause problems as these hooks should not be used more than once in an application.
 */

We have useSelectedParticipant() hook under VideoProvider directory, and yet it's being used outside of VideoProvider directory, namely useMainParticipant.tsx and ParticipantList.tsx.
So, can the hooks inside VideoProvider directory be used outside of that directory then?
Additional context
N/A

Thanks for the question @ardok!
This is a very good question! So the hooks in the VideoProvider directory may not work correctly if they are used outside of the VideoProvider. So to answer your question, the hooks in the VideoProvider directory cannot be used outside of it. Some of the hooks provide methods and properties that are useful throughout the app, so these methods and properties are exposed through the useVideoContext() hook, which can be used anywhere in the app.
My idea with the VideoProvider component was to make it as application-agnostic as possible. Meaning, it could (hopefully) be used in any app without issue.
There are some properties and values that are specific to this application which need to be used throughout the application. These are found in the state directory and they are exposed with the useAppState() hook.
The values contained in the useSelectedParticipant hook are specific to this application (not every app would have a feature that lets you select a participant), so I think that it would make sense for this hook to belong in the state directory instead of the VideoProvider directory. It relates more to the application state than it does video. So it appears that I mistakenly included it in the VideoProvider directory.
I'll look into moving the useSelectedParticipant hook into the state directory. I think it makes sense for it to be there. This wouldn't change how the app functions, but at least the structure of the app would be consistent with my code comments about the same.
Thanks for bringing this to my attention - and please let me know if you have any other questions!

@timmydoza sounds good!
Thanks for this app. Helps splitting my app into smaller "hooks" instead of what we currently have, just one big giant hook of "useTwilioRoom", which is not ideal.


Add #![doc(html_root_url)] to all crates

It enables external crates' documentation to link to crossbeam's one.

html_root_url is not needed in most cases. And api-guidelines no longer recommends this. See https://github.com/rust-lang/api-guidelines/issues/229 for more.

html_root_url is not needed in most cases. And api-guidelines no longer recommends this. See https://github.com/rust-lang/api-guidelines/issues/229 for more.


Active and inactive buttons: improvements

Please make inactive state brighter for buttons "send", "publish offer" and "apply changes" (as in INACTIVE column, not as in CURRENTLY IN WALLET.) https://zpl.io/bLJKylG

Make hover shadow the same color as button. In current implementation it ios white.

Current version:

Correct design:

2.1) For transparent buttons (close/cancel button) make opacity 20%(not 10%) and add shadow for on hovered buttons.

On "show owner key" and "show seed phrase" -  make "x" icon in white

Correct design:

Current version:

When "rescan" and "confirm tx detail" popups are opening, button "cancel" looks like on-hovered. They should be as regular active buttons.

Correct design:

Current version:

Add icons to buttons on "change password" popup https://zpl.io/VqQKDmm

Current version:

Correct design:

In Nodes (all currencies) settings make "x" icon and "cancel" with the same oppacity.

Current version:

Correct design:

Add shadow to "detail" button on the Notification screen https://zpl.io/bLJKylG

Correct design:

Current implementation

Incorrect opacity of icon on the inactive "copy and close" button at the "Create a Swap offer" screen. The copy icon should be with the same opacity as the button's text.

Incorrect colour for the "x" icon on the "cancel" button on the "Show owner key" pop-up, the icon should be white.

The colour of the "x" icon on the "cancel" button on the "Edit seed phrase" pop-up is incorrect. The "x" icon should be white.

The colour of the "x" icon on the "cancel" button on the"Show seed phrase" pop-up is incorrect, The "x" icon should be white.

The colour of the "x" icon on the "cancel" button on the "Clear seed phrase" pop-up is incorrect. The "x" icon should be white.

Checked