Apply lazyload on state change as well

Hi :-)
Thanks a lot for your plugin. I use it to wrap images and it works very well on scroll.
Although, I have a list of content within a faceted search page and face an issue here.
When a facet is clicked, the content list gets filtered and some elements which meant to be outside of the viewport become above the fold but the lazyload is not triggered. For a good reason: scroll has not happened nor a window resize.
Do you think of another mechanism to trigger a lazyload in case of state change?
Thanks :-)
Here is a demo:

scrolling works fine
click on a filter
nothing happens
pictures appear after a brief moment after scroll

@oncletom Hello. I understood your problem. Probably we can listen component update event and recalculate visibility state. Need to investigate this feature and possible performance issues (for now we update lazyload component only once when its state is visible). I'll check this on the weekend. Do you have any suggestions?

@sergeylaptev yes I guess a single call to shouldComponentUpdate is needed, the rest of them should be debounced as currently done for scroll and resize events. If you give me a hint at where to tackle I can eventually propose a PR tomorrow.

@oncletom Probably will be enough to remove shouldComponent update in LazyLoad and re-execute lazyLoadHandler in componentWillReceiveProps. lazyLoadHandler is debounced and calculation will be processed in 250ms (by default).

@oncletom Can you show me code example with this issue? Probably, you use indexed keys for lazy loadable items, and when you navigate to another page, components just updated instead of unmounting (even if content is another). You should use key with unique ids.

Weird issue I bet @sergeylaptev  is right about the key updates. However are you 100% sure the images are loaded as well already? In your example when it takes them a second to load it's almost as if the resources themselves just aren't ready yet.

I have the same problem as OP, it's a product listing and while using a facet to filter products from the bottom of the list aren't displayed when coming to the top. This worked in 2.x so I just reverted my upgrade to 3.x. There might be a problem with my markup since  is not my top element in the loop, thus it doesn't have the "key" attribute (the top element does).
I don't have time to investigate at the moment but I wanted to let you know that I experience this too!

@steevel Can you provide code example which reproduces this unexpected behaviour?


[ci] Use %10 as default flagging threshold for x86_64 benchmarks

x86_64 benchmarks are not stable in general. Use a larger
threshold to avoid being noisy.

I think @pzread is also about to switch us over to c2-std-60 VMs, which means we get basically an entire VM to ourselves. This might be redundant with that. I'll let him make the call

I think @pzread is also about to switch us over to c2-std-60 VMs, which means we get basically an entire VM to ourselves. This might be redundant with that. I'll let him make the call

I'm fine to first loose the thresholds, we can re-adjust once the new data from c2-std-60 come in.


Support for SASS 3.3

Is there a plan to support SASS 3.3?
I've got a problem with the gird-framework Jeet.
This code isn't compiled correctly:
@for $i from 1 through ceil(length($list)/2) {
    $tmp: nth($list, $i);
    $tmp: if(length($tmp) > 1 and $recursive, reverse($tmp, $recursive), $tmp);

    $list: set-nth($list, $i, nth($list, -$i));
    $list: set-nth($list, -$i, $tmp);
 }

Yes. Known outstanding issues are labelled 3.3 or 3.4.
I don't think that code works in Jeet. There's no reverse function defined in Jeet and no built-in in ruby scss 3.4.15.

Please test using the master branch.  AFAICT this will be fixed in the next release as it contains the set-nth() fix in a763e28ed14cd5d5478d754cece0b9ad726b9661.

Hi, thanks for your prompt respond.
I just tested it. It works now (master branch)
Yes, the reverse function is quite interesting, but see:
https://github.com/mojotech/jeet/blob/master/scss/jeet/_functions.scss#L87


node-serialport issue

Trying to install Johnny-Five and Raspi IO on RPi following this guide https://github.com/nebrius/raspi-io/wiki/Getting-a-Raspberry-Pi-ready-for-NodeBots .
After npm install johnny-five raspi-io I get
node-pre-gyp ERR! Tried to download: https://github.com/voodootikigod/node-serialport/releases/download/3.1.2/serialport-v3.1.2-node-v46-linux-arm.tar.gz

node-pre-gyp ERR! Pre-built binaries not found for<EMAIL_ADDRESS>and<EMAIL_ADDRESS>(node-v46 ABI) (falling back to source compile with node-gyp)

Is it OK?

Yes that's ok, it'll still work, although I'm a little surprised that's happening. @reconbot, any ideas?

@reconbot Node.js appears to be able to get away with 3 Linux arm builds, armv6l, arm7l, and arm64. I've used the armv7l builds on both the Raspberry Pi and the BeagleBone Black.

I'm not sure if it's reliably exposed in a documented way. Here's some output from Node.js v6.1.0 on a Raspberry Pi 2 running the armv7l build:
pi@raspberrypi:~ $ uname -a
Linux raspberrypi 4.4.9-v7+ #884 SMP Fri May 6 17:28:59 BST 2016 armv7l GNU/Linux
pi@raspberrypi:~ $ node -v
v6.1.0
pi@raspberrypi:~ $ node
> process.arch
'arm'
> process.config.variables.node_byteorder
'little'
> process.config.variables.arm_version
'6'
>

I'd imagine that the l in armv7l is exposed as process.config.variables.node_byteorder. What I don't understand is why process.config.variables.arm_version is 6. I would have expected it to be 7.

Try to install bcm2835

I'm going to go ahead and close this issue, please reopen it if you're still having problems @iam-black


nextcloud22: 22.2.0 -> 22.2.1

Motivation for this change
ChangeLog: https://nextcloud.com/changelog/#22-2-1
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Note https://github.com/nextcloud/server/issues/29678, it's probably a bad idea to update to 22.2.1 :(

Not sure whether we should maybe temporarily revert?

The backport shouldn't be merged, of course now. Let's wait a moment and see if they publish a hotfix release (though I didn't have notable performance issues, otherwise I wouldn't have merged in the first place).
Also, if it's known what the problem is, we probably want to just apply a fix?

The fix is probably coming from https://github.com/nextcloud/server/pull/29682, and it's not clear yet whether there is a hotfix release.

There is a version 22.2.2, which should have fixed the issue. See: https://github.com/nextcloud/server/pull/29682 and https://github.com/NixOS/nixpkgs/pull/145700


Removed ossfuzz make rule

The rule is not being used as it is now. It may be brought back at a later time, but it is being removed now to avoid having unused code.

Just out of curiosity, I've seen the change in the oss-fuzz that uses CMake to build the library - two questions on that note:

Would it be easier to use the .a library that CMake build uses? Not clear why you need to use ar to rebuild it from .o artefacts
Does oss-fuzz setup CMake environment automatically to introduce -fsanitize flags? Asking because CMake setup doesn't have a fuzz mode but maybe this magically happens

Would it be easier to use the .a library that CMake build produces?

Yes, it probably will be. I will try it out. Thank you for pointing it out.

Does oss-fuzz setup CMake environment automatically to introduce -fsanitize flags?

Yes, OSS-fuzz sets all the necessary flags.


Fix typos.

This change is

@nickvigilante I thought all the "included" version tags were reverted in tables.

@stbof Ah, you're right. I forgot it's because in MD tables it doesn't like includes. LGTM!

Yes, and I thought you backed the include out from all the tables when the issue was raised. I wonder if there are others still lurking in MD tables.


Update table metadata query to allow for the primary key to be involved in other constraints.

The problem: I'm adding more constraints (uniqueness, foreign keys, etc) to our tables, which is causing things to get messed up. This is because our query currently does a poor join, and rows for keys would get duplicated if there were multiple constraints for that column. This fixes that.
Before:
      name       |          col_type           | default_val | not_null | primary_key | dist_key | sort_
-----------------+-----------------------------+-------------+----------+-------------+----------+------
 _data_timestamp | timestamp without time zone |             | f        | f           | f        |
 id              | character varying(256)      |             | t        | f           | f        |
 id              | character varying(256)      |             | t        | t           | f        |
 district_id     | character varying(256)      |             | t        | f           | t        |
 district_id     | character varying(256)      |             | t        | f           | t        |

After:
      name       |          col_type           | default_val | not_null | primary_key | dist_key | sort_
 _data_timestamp | timestamp without time zone |             | f        | f           | f        |
 id              | character varying(256)      |             | t        | t           | f        |
 district_id     | character varying(256)      |             | t        | f           | t        |

Me too, but I felt the same way. I mostly figured the sanity check was good. :)


Add Group SAML Links

Gitlab Group SAML Group links added to production API yesterday:
https://docs.gitlab.com/ee/api/groups.html#saml-group-links

Downstream Terraform Provider Update: https://github.com/gitlabhq/terraform-provider-gitlab/pull/1215

I've just created a MR upstream on GitLab to improve a few things for this API, seehttps://gitlab.com/gitlab-org/gitlab/-/merge_requests/95561 - including:

fixing a bug which lead to an empty response when creating a new SAML Group Link
implemented a get endpoint to retrieve information for a single SAML Group Link

@mhodgson little update: my MR to the API from this morning was merged a few hours ago. Thus, I think you can implement it accordingly :)

@timofurrer I updated the code here to account for your upstream changes.

@timofurrer awesome! Do you know when this would be in production? We're hoping to use this sooner than later...

@mhodgson It's already available on gitlab.com, see: https://docs.gitlab.com/ee/api/groups.html#get-saml-group-link
And it will come to the self-hosted version with GitLab 15.3 - which means that I'll try to get a release out of the terraform provider on either the 22nd or 23rd - right after 15.3 comes out.

@timofurrer are you sure the changes are live? I'm testing the create endpoint and still getting a null response.

@timofurrer are you sure the changes are live? I'm testing the create endpoint and still getting a null response. The GET endpoint also returns 404 for all requests, so thinking that isn't live either.

Interesting 🤔 I just assumed because the docs are live - it must be available "soon" ™

@timofurrer looks like the updates are live! LGTM.

Thanks for your PR @mhodgson! Please see this PR for the last bits that you missed: https://github.com/xanzy/go-gitlab/commit/88c4146511b7582d41a1a38932e1bad38f43768a


Choose Colors

From here choose better Material Design app colors:

[x] Primary
[x] Primary Dark
[x] Accent

and put them into res/values/colors.xml

@chester1000 I've changed colors to http://www.materialpalette.com/deep-purple/blue

@chester1000 I've changed colors to http://www.materialpalette.com/deep-purple/blue


Fork with Quill dev Version 2.0.0 Support here

Hey,
in order to make some plugins work, I decided to fork this and update it to be compatible with the latest quill version (2.0.0-dev.3).
The tests are working fine. Besides that, so far I have not found any unexpected behaviour.
It can be found here: https://www.npmjs.com/package/@voicehub/vue-quill-editor
The Repo: https://github.com/voicehub-io/vue-quill-editor

Hey,
in order to make some plugins work, I decided to fork this and update it to be compatible with the latest quill version (2.0.0-dev.3).
The tests are working fine. Besides that, so far I have not found any unexpected behaviour.
It can be found here: https://www.npmjs.com/package/@voicehub/vue-quill-editor
The Repo: https://github.com/voicehub-io/vue-quill-editor

i change package to this but i get this error with my custom blots

@LucasvlLima Can you open the issue on the repo of the actual fork? https://github.com/voicehub-io/vue-quill-editor

@felix-voicehub i guess dont have issues tab there

@LucasvlLima I'm sorry, now there is!


proposal: encoding/json: expose efficient validation

I'm running go version go1.7.1 darwin/amd64 on macOS 10.12.1.
I'm trying to validate some a byte array is valid JSON so it can be marshalled literally like RawMessage. The only way to do this at the moment is to create a Decoder and fully decode the bytes causing many useless allocations, or write a custom scanner.
But there's a lovely, allocation-free function for scanning a byte array to see if it's valid JSON tucked away inside the encoding/json package (checkValid), and used in several places within the package. It'd be great to expose this for general use as something like IsValid(data []byte) bool.
I proposed this change a while back but I didn't understand the contribution process sorry! Is this the right place to file the issue @bradfitz?

@sj26, we just had a proposal review meeting today, so this'll be discussed at the next one, usually weekly.
I'll let others chime in here in the meantime.

By analogy with unicode/utf8's func Valid, it seems like this should be encoding/json's func Valid.

If you (or anyone else) would like to send a CL, please do, for Go 1.9.


Congratulation on the great work & hope for future versions

The higher the LLM layer, the more attention is focused on a few key tags. Therefore, if after a few iterations of the underlying op, it is possible to detach from the underlying op and use only the high-layer loop. Then the solver can be expressed as a question-specific LLM. This idea aligns closely with the ultimate computing arch I envisioned in dreams. With the same computing power, at a higher lvl of abstraction, cognition can be improved by 3-6 OOMs, eq to 40 yrs of Moore’s Law. The PyramidKV marks the beginning of vast potential for innovation in this field.
This computing arch has appeared in my dreams many times, and I feel it’s becoming true. It involves generating a general question-specific graph and training a very small network in real time.
Inspired by human cognitive processes, I believe it’s overlooked to emphasize problem-solving at a conceptual lvl rather than repetitive, low-level processing.

You are on a snowball track with the thickest snow and the longest slope. What an enviable thing!

从信息与统计视角看LLM 的出路
a) 对我们这个世界的改造能动性，来自一种后验洞察，这种后验必须立足当下的一切，系统内外的条件。这意味着对于求解器而言，一来条件是海量的，二来推理是深度的。所以这种情况下，求解器绝无可能可以把后验求解器看做是先验知识。深度的推理练习可以缓解这一点，但绝无近零推理的可能。
b) 这种后验求解器优化的难度在于条件的稀疏性。更在于稀疏性组合的巨量可能性。这在赫伯特·西蒙 有限理性中有比较好的展示。稀疏使得认知不得不总具备新鲜的可能。就像传统工程学中，优化绝不是事先可以规划的东西，但它一定是事后的魔法。看看还能做什么而推动和优化的程度常常让我们震惊。同时关系的稀疏性意味着细致的认知和评估通常是可能得。
结论如果我们追求一个非常强大的artificial super intelligence,那么更大很可能不是大模型的必须，而更深的推理训练是必须。更深的推理以为着必须引入一种高效得多的，推理深度深得多的，支持long thinking 的架构。


Issue with Missing StableDiffusion3Pipeline Class in OnnxStack C# Inference Demo

Hello OnnxStack Team,
I recently came across your project while searching for a method to run the stable diffusion 3 model in C#. I found the model on the Hugging Face page (https://huggingface.co/TensorStack/stable-diffusion-3-lite-onnx) and followed the link to your C# Inference Demo on GitHub (https://github.com/TensorStack-AI/OnnxStack).
The example code provided on the repository suggests using the StableDiffusion3Pipeline class to create a pipeline and generate images with the model. Here is the snippet of the example code:
// Create Pipeline
var pipeline = StableDiffusion3Pipeline.CreatePipeline("D:\\Models\\stable-diffusion-3-lite-onnx");

// Prompt
var promptOptions = new PromptOptions
{
    Prompt = "A cat holding a sign that says OnnxStack Stable Diffusion 3"
};

// Run pipeline
var result = await pipeline.GenerateImageAsync(promptOptions);

// Save Image Result
await result.SaveAsync("Result.png");

However, upon looking into your library, I could not find the StableDiffusion3Pipeline class. It seems to be missing from the library, or the documentation may need updating to reflect the correct usage.
Could you please provide clarification on whether the class is indeed missing, or if I should be using a different approach to instantiate and utilize the stable diffusion 3 model within a C# environment?
Any assistance or updated documentation would be greatly appreciated as I am excited to integrate this model into my project.
Thank you for your time and effort!

Any update on this?

@saddam213 Any update on this?

Hey Everyone,
I am currently still working on the StableDiffusion3 and FluxPipline,
This can take a bit of time as I can't create the pipeline until I successfully convert the model to onnx, but I also cant test the model until I have a pipeline, so its a real chicken-egg-chicken situation sometimes
I have now successfully converted these models and do have functioning pipelines however they are not ready to be merged into main as it is still a bit of a mess.
I have been insanely busy at work the past few months, but I can confirm these pipelines will be in the next OnnxStack release, hopefully in the next few weeks.
Thanks
Adam

This is awesome news @saddam213 Thank you so much for this project. This helps us .net devs a lot!


Bluetooth: controller: split: Fix procedure complete event generation

Describe the bug
Generate PHY update complete and Conn Update events after the on-air instant
To Reproduce
Steps to reproduce the behavior:

mkdir build; cd build
cmake -DBOARD=board_xyz
make
See error

Expected behavior
A clear and concise description of what you expected to happen.
Impact
What impact does this issue have on your progress (e.g., annoyance, showstopper)
showstopper
Screenshots or console output
If applicable, add a screenshot (drag-and-drop an image), or console logs
(cut-and-paste text and put a code fence (```) before and after, to help
explain the issue.
Environment (please complete the following information):

OS: (e.g. Linux, MacOS, Windows)
Toolchain (e.g Zephyr SDK, ...)
Commit SHA or Version used

Additional context
Add any other context about the problem here.

@kruithofa @cvinayak is this still an issue on the current EBQ runs?

@carlescufi this depends on new LLCP work, not worth new effort to fix this in current split controller.


Flag to skip types that are not supported

Feature description
I am trying to generate zod schemas from the Api generated by swagger-typescript-api. But this API contains a bunch of unsupported types related to the API it self which i don't really need zod-schemas for. Like Interface with generics etc.
I would like to be able to give a flag to the ts-to-zod command so the script doesn't exit when it find an unsupported type, e.g:
npx ts-to-zod src/myApi.ts src/myZodApi.ts --skip-unsupported
Input
export type QueryParamsType = Record<string | number, any>;

Output
// nothing

Or I would like support for interfaces with generics.

This would make the library much more compatible with other code generator libraries as very many of them use generics and other unsupported types for their own typings. Plzplz!!

I found a way to get around this using the --modular option of swagger-typescript-api. This put the contracts into a separate file which allowed me to generate schemas without errors

This has again become an issue when introducing discriminators in the swagger contract. The typescript types are then created with generics.
Please add an option to not fail the generation when an error occurs! --skip-unsupported or something.

Can you create a PR that implements this?

Also in need of a skip flag but do not have the bandwidth to create a PR for this.

Hello,
Can you provide an example of a few failing cases?
The first example provided
export type QueryParamsType = Record<string | number, any>;

currently generates
// Generated by ts-to-zod
import { z } from "zod";

export const queryParamsTypeSchema = z.record(
  z.union([z.string(), z.number()]),
  z.any()
);

so I see no error to "skip" in that specific example.

Same problem here, using https://github.com/patmood/pocketbase-typegen


Add 3 questions

I think it is better if you add your qeustions as json objects to the already existing array of questions in the file questions.json.
Hint: you can redo your modifications by the command: git reset --hard

ooh my bad, Sure thing, I would do that

ok nice! looks good, Ill merge it :)


Blacklist feature not working for sites

Issue
Blacklist command not having any effect for sites.

Example

Steps to replicate
Simply attempt to blacklist a site.

Odd, I couldn't reproduce this bug on 4/4 servers I tested this on. Mind letting me know the server ID this is happening on?

Should be fixed in https://github.com/AtlasTheBot/Booru-Discord/pull/38
It was an oversight in how I was dealing with settings for new guilds after the settings rework


[WIP] Convert from SharpDX to Silk.NET.

PR Details
Replace SharpDX bindings for DXGI, Direct3D 11, Direct3D 12, the DirectX Shader Compiler, and any other use of SharpDX with Silk.NET bindings.
Description
SharpDX is the base for all the Direct3D (both 11 and 12) graphics frameworks in Stride. But SharpDX is no longer active nor mantained, the repository is archived, and the NuGets are still (and forever) netstandard2.0. Also, it is based on a class-based abstraction over the DirectX interfaces.
Meanwhile, Silk.NET is a new bindings library created to take advantage of modern .NET, use the modern C# performance-oriented primitives and features (like Span<T>, for example), and it's designed more as a raw bindings as close as possible to the underlying DirectX APIs, without class-based abstractions. Its main drawback however is that it is inherently unsafe (in the context of using pointers and memory management directly) That however is of no importance to Stride as it will be under the hood of the Stride.Graphics framework.
This PR consists of the following points:

[x] Convert Direct3D 11 framework to Silk.NET.Direct3D11.
[x] Convert Direct3D 12 framework to Silk.NET.Direct3D12.
[x] Convert DirectX Shader Compiler to Silk.NET.Direct3D.Compilers.
[ ] Improve the documentation on DirectX-related methods and types, removing references to SharpDX or to the native constants, types, or functions where appropriate.
[ ] Introduce small convenience types and helper functions to aid in the implementation of interop improvements like this one, now and in the future.

Related Issue
This PR tries to solve issue #432. It is similar to PR #1123 by ykafia, but that one is pretty out of date at this point, so it was easier to start afresh branching the current master.
Motivation and Context
The motivation for converting to Silk.NET is twofold:

The SharpDX libraries are pretty solid and stable at this point. However its design filosophy (more to be used as a framework itself ala XNA) and its age makes us lose opportunities to improve performance, control memory allocations more tightly and take advantage of modern C#. Also it is no longer mantained, so no more bug fixes or improvements of any kind.
Silk.NET is actively mantained and uses all the utilities modern C# and .NET has to offer. As it is actively mantained it's easier to get bug fixes and improvements, and more importantly, access to future (and current) technologies we may be interested in (like DirectStorage, DXVA, etc).

If all goes well with this PR, you should not see a difference in Stride. Maybe better performance and memory consumption. The   improvement is mainly to be more up to date and more inline with modern .NET.
Types of changes

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

i can't build this branch via some errors has not resolve

@ly3027929699 Yeah, the PR is still marked as wip, you shouldn't expect it to work as is yet :P


zigzag indicator added to resolve issue #443

Developed zigzag indicator to resolve #443

Hello @aligheshlaghi97,
Awesome! Would it be possible to checkout the development branch and add it there in a new PR? If not, I will port to the development branch.
Thanks,
KJ

Hey there @twopirllc
I tried to do so but I couldn't. Actually I didn't fork 'development' branch. Can you please help me to do it?
I think I should delete the repo I forked and try to fork again to contain development branch and then I can add the code to it. Am I right?

Thanks @twopirllc for your response,
As far as I searched, there were no other way to keep this fork while I didn't have access to development branch. So I decided to remove this fork, create another one which includes development branch.
I will update the code and make another PR asap.


Autoscaler example for 0.1

/kind feature
Describe the solution you'd like
An example to see KFServing autoscaling in action
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

/assign yuzisun

/area project-health


Images not delete

The uploaded images by users and the generated skins should be deleted. This will preserve server space and prevent issues with any images that are uploaded.
I think this should be around 3-4 minutes after generating the skin.

can i be assigned to this issue?

If you want to work on it sure!

i forgot about this lol , ill start working

I am rewriting ImageToSkin to run client side with React so this will no longer be an issue.


Extension not using launch.json config when you press the UI button "Debug Python File"

VS Code version
1.63.1
Extension version
v2021.12.1559732655
OS type
macOS
OS version
12.0.1
Python distribution
python.org
Python version
3.9
Language server
Default
Expected behaviour
When I press the debug button, I expect the extension to respect my choices in launch.json or at least allow me to configure my own arguments to be passed to the python script being debugged.
Please see issue I opened up here with VS Code: https://github.com/microsoft/vscode/issues/139251
I thought this was a VS Code issue and they sent me here.
Actual behaviour
The debug button does not use launch.json and doesn't appear to offer me a mechanism to pass arguments to python scripts. I believe the button should respect config information set within that file or have it's own separate section within it so we can customize it.
Steps to reproduce
configure a launch.json and press the debug button and you will see that arguments are not passed. but when you press the debug button inside of the debug & run pane, it uses the settings.
more details here: https://github.com/microsoft/vscode/issues/139251
Logs
Experiment 'pythonaacf' is active
Experiment 'pythonTensorboardExperiment' is active
Experiment 'PythonPyTorchProfiler' is active
Experiment 'pythonDeprecatePythonPath' is active

conda info --json
conda --version
/usr/bin/python3 ~/.vscode/extensions/ms-python.python-2021.12.1559732655/pythonFiles/interpreterInfo.py
/usr/lib/python2.7 ~/.vscode/extensions/ms-python.python-2021.12.1559732655/pythonFiles/interpreterInfo.py
/opt/homebrew/bin/python3 ~/.vscode/extensions/ms-python.python-2021.12.1559732655/pythonFiles/interpreterInfo.py
Python interpreter path: /opt/homebrew/bin/python3
Starting Pylance language server.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@ejkitchen Sorry for the delayed response. when you say debug button, are you talking about this:

if so then, in your launch.json configuration please add purpose field like this:
        {
            "name": "Python: Current File",
            "type": "python",
            "request": "launch",
            "program": "${file}",
            "console": "integratedTerminal",
            "justMyCode": true,
            "purpose": ["debug-in-terminal"]
        }

Because we have not heard back with the information we requested, we are closing this issue for now. If you are able to provide the info later on then we will be happy to re-open this issue to pick up where we left off.

@karthiknadig  , sorry I missed this somehow.
Yes, that button!
I edited the launch.json file and added the purpose field and it works!! I think the documentation should be made clearer for this as it's confusing and I am not quite sure what the purpose of "purpose" really is. Shouldn't F5 and that button be identical by default? If there is a reason for a difference then I would document that better at the URL you have below. It's not obvious why those two should differ (to me at least).
Also when I googled the purpose feature, I immediately found the documentation that sort of explains the issue I was having. But the documentation doesn't seem quite right and I think something is still broken. I added "purpose:" and F5/ Run > Start Debugging both work perfectly fine with my launch.json settings. This seems to contradict what you have below in the docs I think(?). For a test, I added an args section and wrote a Python one-liner that prints argv. If I have a purpose section then F5,  Run > Start Debugging and the button all work as intended. If I remove "purpose" then the button no longer reads the launch.json file and I get no arguments. Is there a reason this behavior is wanted/needed? I think people who create a launch.json are expecting the purpose section to be there by default and those who do not want it should remove it no?
If not, then I would definitely update the documentation and put this at the very top right where you mention the debug button. You should immediately discuss this other button and explain why it is different and what the default behavior is.
From https://code.visualstudio.com/docs/python/debugging
purpose#
If set to debug-test, defines that the configuration should be used when debugging tests in VS Code. If set to debug-in-terminal, defines that the configuration should be used when and only when using the Debug Python File in Terminal button on the top-right of the editor. Note that the purpose option can't be used to start the debugger through F5 or Run > Start Debugging

I have a similar problem, but it doesn't resolve even after adding the "purpose".
Below are the contents of my launch.json file.
{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Python: Current File",
            "type": "python",
            "request": "launch",
            "program": "${file}",
            "console": "integratedTerminal",
            "justMyCode": true,
            "args": [
                "--debug",
                "--dataset",
                "IXI",
                "--bsize",
                "1",
                "--gpu",
                "1"
            ],
            "purpose": [
                "debug-in-terminal"
            ]
        }
    ]
}

Actually, I manually created the .vscode file and copied the launch.json from another local repo of the same project.

I recreated the json by going to run->add configuration. It worked.


Fix oslnoise link errors when building static OSL libraries.

With static libraries the indirect dependency is not picked up automatically, so explicitly add it to testshade and testrender.

I'm confused. liboslnoise is not needed by testshade and testrender. The noise functions are all in liboslexec. The liboslnoise is redundant, only for the benefit of apps that want only the noise functions without needing an entire OSL runtime and LLVM.

There is this in src/liboslexec/CMakeLists.txt:
if (NOT BUILDSTATIC)
    LIST(APPEND liboslexec_srcs
        ../liboslnoise/gabornoise.cpp
        ../liboslnoise/simplexnoise.cpp
        )
endif ()

So for static builds, the noise functions are currently not included in liboslexec. If they are included users have to ensure they link only liboslexec or liboslnoise to avoid duplicate symbols. I'm not sure which is preferable.

It would a little easier for existing users to include the noise functions in liboslexec, as existing build scripts wouldn't need any changes to add a new liboslnoise library.
So just removing that if (NOT BUILDSTATIC) may be a better fix.

Oops. Yes, I think you are correct. The error is that those two source files should be added to liboslexec regardless of whether it's being build as a static or dynamic library.

Ok, I've updated the patch to do that.

LGTM, I will merge.
Thanks for the fix.


Fix float 16 type support for some CUDA kernels

Fix the CreateConstantOnes for float16 type
Add cuda kernel code in the BatchNorm for float 16 type, there's issue to run cudnnBatchNormalizationForwardInference with float 16 type
Add float 16 test case for Gemm & BatchNorm CUDA kernel only

Have you tried the 3 fp16 models?

need to adjust the threshold for cuda test

In reply to: 460475067 [](ancestors = 460475067)

need to adjust the threshold for cuda test, and a test failure on Linux. Will add them back after the test data updated.
In reply to: 460475067 [](ancestors = 460475067)

You may merge it, let me handle the other things at a later time.


Nullability is broken by move to reference schemas

Describe the bug
The switch to reference schemas completely broken Kompendiums ability to handle null fields.  Since each type gets stored only once, but nullability is stored on the object schema level, this leads to a situation where defining one field of Type A that is nullable and another field of type A that is not nullable cannot be handled.
To Reproduce
data class Something(val a: String, val b: Int)

data class ManyThings(
  val someA: Something,
  val someB: Something?
)

This will not display the nullability correctly in Kompendium
Expected behavior
It should display properly

Read through this at some point https://github.com/OAI/OpenAPI-Specification/issues/1368


Correctly set vertical velocity at cell boundaries

Find a way to set $u_v$ at cell boundaries so that $\tilde{u}^v = 0$. Can fake it for now, but should add a boundary condition to ClimaCore that handles this.

It's a little bit convoluted, but we want to set $u_v$ at the boundaries so that $\tilde{u}^v = 0$.


push is async

push is async. This causes issues if you want to do something after the route has changed (e.g. scroll to the top of the page).
Can push / replace return a promise?

or possible to add events?

or possible to add events?

I couldn't get a page scroll to work in the demo examples, but I did get an "on load" event to fire after a route change by just using the Alpine.js intersect pulgin. In the template of the route, just add an x-intersect="myFunction();" It will fire myFunction() every time the route is loaded.

push is async. This causes issues if you want to do something after the route has changed (e.g. scroll to the top of the page).
Can push / replace return a promise?

"scroll to the top of the page"
You may want to do this in the x-init of the template


Implement host list.

We will need to modify config.request to accommodate POST and PUT requests soon.

yaas host list --fields=Hosts/disk_info output could be better.

$ yaas host list --fields=Hosts/host_state,Hosts/host_status
host1.example.com - cluster1
    host status: ALERT
    host state: HEALTHY
host2.example.com - cluster1
    host status: HEALTHY
    host state: HEALTHY
host3.example.com - cluster1
    host status: HEALTHY
    host state: HEALTHY
host4.example.com - cluster1
    host status: HEALTHY
    host state: HEALTHY
host5.example.com - cluster1
    host status: ALERT
    host state: HEALTHY
host6.example.com - cluster1
    host status: HEALTHY
    host state: HEALTHY


Bump version to 4.2.5

Checklist

[X] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[X] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

As this is a patch release and there isn't much change, I'll merge.


Fix missing tomee.xml

Summary
The missing tomee.xml currently leads to issues due to the run user not being able to modify any content in /catalina-base. The root-cause is similar to https://github.com/paketo-buildpacks/apache-tomcat/pull/248.
This leads to issues related to openEJB:
26-Oct-2022 13:07:06.514 INFO [main] org.apache.openejb.config.ConfigUtils.searchForConfiguration Cannot find the configuration file [conf/openejb.xml].  Creating one at /layers/paketo-buildpacks_apache-tomee/catalina-base/conf/openejb.xml
java.io.FileNotFoundException: /layers/paketo-buildpacks_apache-tomee/catalina-base/conf/openejb.xml (Permission denied)
	at java.io.FileOutputStream.open0(Native Method)
	at java.io.FileOutputStream.open(FileOutputStream.java:270)
	at java.io.FileOutputStream.<init>(FileOutputStream.java:213)
	at java.io.FileOutputStream.<init>(FileOutputStream.java:162)
	at org.apache.openejb.loader.IO.write(IO.java:357)
	at org.apache.openejb.loader.IO.copy(IO.java:282)
	at org.apache.openejb.config.ConfigUtils.createConfig(ConfigUtils.java:157)
	at org.apache.openejb.config.ConfigUtils.searchForConfiguration(ConfigUtils.java:132)
	at org.apache.openejb.config.ConfigurationFactory.init(ConfigurationFactory.java:433)
	at org.apache.openejb.assembler.classic.Assembler.init(Assembler.java:427)
	at org.apache.openejb.OpenEJB$Instance.<init>(OpenEJB.java:139)
	at org.apache.openejb.OpenEJB.init(OpenEJB.java:307)
	at org.apache.tomee.catalina.TomcatLoader.initialize(TomcatLoader.java:247)
	at org.apache.tomee.catalina.ServerListener.lifecycleEvent(ServerListener.java:168)
	at org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:123)
	at org.apache.catalina.util.LifecycleBase.setStateInternal(LifecycleBase.java:423)
	at org.apache.catalina.util.LifecycleBase.init(LifecycleBase.java:137)
	at org.apache.catalina.startup.Catalina.load(Catalina.java:639)
	at org.apache.catalina.startup.Catalina.load(Catalina.java:662)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.apache.catalina.startup.Bootstrap.load(Bootstrap.java:302)
	at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:472)

TomEE ships this (basically empty) file by default as well.
Use Cases

Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Can you expand on this? How does adding this file correct the issue? Does it change where Tomee writes temporary files?
Thanks and pardon my ignorance of Tomee, I do not have experience with it.

I'm also not an TomEE expert to be honest. We observed the mentioned issue with missing/creating catalina-base/conf/openejb.xml which fails as the run user does not have permissions.
A quick research showed, that openejb.xml is only used by the standalone version of OpenEJB. In context of TomEE the configuration is taken care of by tomee.xml.
The file  shipped with this PR  is actually a copy from upstream TomEE which is shipped with it.

Ok, I'm fine with including this config since it gives us better parity with upstream Tomee.
I'm not certain if this will fix the issue as there are limits to where the app can write to at runtime. If this doesn't correct the issue please open a new issue and we can look into things more.


Add basic Ollama support

Context
Ollama is a popular way of running LLMs locally on MacOS, Linux and WSL2. This PR adds support for that provider.
Ollama API
The Ollama API isn't well documented and I haven't tested many of its options. I've added support for the most common options, and left out those that seemed less useful.
Link to documentation: https://github.com/jmorganca/ollama/blob/main/docs/api.md#request-5

Looks awesome Laurent, merci!
This addresses open issue https://github.com/ianarawjo/ChainForge/issues/116 . I will pull your changes into a feature branch before merging into main.

Changes are live! Thanks again!! 🎉


Implement order book delta socket for Bittrex

Since this is a very high traffic websocket, I wanted real objects to parse the JSON into. I borrowed these from bittrex.net.
A couple notes: I don't love that these model object classes are all in one giant file. It was also confusing to navigate the ExchangeBittrexApi.cs file that has the exchange implementation classes as well as the various websocket classes. Please accept my vote to split each of these classes out into their own files or reorganize this in some way.
Related: I approve of the refactoring you did around GetExchangeOrderBookDeltas. Including the symbol and sequence number in the order book itself makes things way cleaner. 👍

I re-organized the files and did some code cleanup. Each exchange is in their own folder, with model objects and helper classes underneath a partial class for the exchange class. Let me know what you think.

Looking way better. Thanks for doing the refactor.
I don't have a strong opinion, just curious because I haven't seen it this
way before... Why use nested classes under an exchange rather than just
putting the related objects in their own namespace?
On Thu, Jun 28, 2018, 17:09 Jeff Johnson<EMAIL_ADDRESS>wrote:

I re-organized the files and did some code cleanup. Each exchange is in
their own folder, with model objects and helper classes underneath a
partial class for the exchange class. Let me know what you think.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jjxtra/ExchangeSharp/pull/196#issuecomment-401188376,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AI8DiVP6DN8U3Am1GBDeROLDEJn_Ase_ks5uBVQEgaJpZM4U8GpM
.

I suppose that could work as well and make them internal. This way they don't get in the way, and I've been hesitant to do extra namespaces because I always find it confusing. But either way would work fine :)


dolphinscheduler-common remove spring

dolphinscheduler-common remove spring

Codecov Report

Merging #1931 into refactor-architecture will decrease coverage by 0.23%.
The diff coverage is 0%.

@@                    Coverage Diff                    @@
##           refactor-architecture    #1931      +/-   ##
=========================================================
- Coverage                  23.72%   23.49%   -0.24%
=========================================================
  Files                        323      323
  Lines                      14771    14771
  Branches                    2397     2397
=========================================================
- Hits                        3505     3471      -34
- Misses                     10849    10894      +45
+ Partials                     417      406      -11

Impacted Files
Coverage Δ

.../server/worker/task/processdure/ProcedureTask.java
0% <ø> (ø)
:arrow_up:

...e/dolphinscheduler/server/worker/WorkerServer.java
0% <ø> (ø)
:arrow_up:

...e/dolphinscheduler/server/master/MasterServer.java
0% <ø> (ø)
:arrow_up:

...server/master/runner/MasterBaseTaskExecThread.java
0% <ø> (ø)
:arrow_up:

...e/dolphinscheduler/common/utils/Preconditions.java
0% <ø> (-63.16%)
:arrow_down:

...hinscheduler/server/worker/task/http/HttpTask.java
0% <ø> (ø)
:arrow_up:

...heduler/server/master/runner/MasterExecThread.java
13.11% <ø> (ø)
:arrow_up:

...nscheduler/server/worker/task/datax/DataxTask.java
73.46% <ø> (ø)
:arrow_up:

...er/server/worker/task/dependent/DependentTask.java
0% <ø> (ø)
:arrow_up:

...lphinscheduler/server/worker/task/sql/SqlTask.java
0% <ø> (ø)
:arrow_up:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29f2b41...3301a8d. Read the comment docs.


Odd number sequence

Hi!
I would like to add an input to my panel that can have an odd sequence, for example : [3, 5, 7, 9 , 11, ...]. Right now i'm using :
 f.addInput(this.params, 'foo',
  {
    min: 1,
    max : 15,
    step: 2
  }).on('change', (size) => {
    // this.params.foo = size.value + 1;
  });

which does't work because my value get rounded. As you can see, I tried incrementing it with the "change" event. I get the right value, but the UI is not updated. I also tried using the refresh function, but as I modify the value with the "change" event, it does not work.
Is there a clean way to do this?

Here is an example to do that:
import { Pane } from 'tweakpane';

const pane = new Pane();
const params = {
  param: 3,
};
pane
  .addInput(params, 'param', {
    format: (v) => v.toFixed(0),
    min: 1,
    max: 15,
  })
  .on('change', (ev) => {
    params.param = Math.floor(ev.value / 2) * 2 + 1;
    pane.refresh();
  });

Anyway I think that the step value should respect its min value. I'll fix it later.

Added changes in #401. Please wait for the next release.


Separate borderRadius per corner not supported

It looks like borderTopLeftRadius and the like are not properly supported. Only borderRadius is.
On Android at least, haven't checked iOS yet.

There is a known problem in Android with child views pushing through their parent's rounded corners. Solution included in the project was writthen before per corner border radii were introduced, so it just applies parent's borderRadius on NativeLinearGradient element
https://github.com/brentvatne/react-native-linear-gradient/blob/895cb02d31970be0558fc0d59925f45e840a7a73/index.android.js#L19
I will look at this issue this week, but if you are interested in contributing to the project, your help would be welcome:)

Well, I fixed it in #75. :)


MD030: incorrectly firing inside HTML comments that end with ---> after switch to micromark

As of v0.32.0 (presumably e89ff6ea98a5fbd2477cb0855a8134615f3944c0), MD030 is incorrectly firing inside HTML comments if the comment ends with ---> instead of -->.
Minimal test case:
<!--
*  x
--->

Steps to reproduce:
$ mkdir tmp
$ cd tmp
$ cat > test.js <<EOF
const markdownlint = require("markdownlint");
const options = {"files": ["foo.md"]};
console.log(markdownlint.sync(options).toString());
EOF
$ cat > test.md <<EOF
<!--
*  x
--->
EOF
$ npm install<EMAIL_ADDRESS>$ node test.js
$ npm install<EMAIL_ADDRESS>$ node test.js
foo.md: 2: MD030/list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

An HTML comment that ends with "-" is not really an HTML comment: https://spec.commonmark.org/0.30/#raw-html

An HTML comment that ends with "-" is not really an HTML comment: https://spec.commonmark.org/0.30/#raw-html

Oh, that's crazy! That's much more strict than HTML itself. The additional restrictions were added unexplained in 0.16 and is slated to be removed in 0.31 to match HTML
Well, I guess technically this is spec-compliant. :-/
Feel free to close as Working As Intended if you don't plan to fix, though as a heads up this may be an issue once 0.31 gets released.

I'd be glad if this were defined more consistently, but for now as behavior is matching specification, I will close the issue. If/when a new specification shows up, I'll try to make corresponding updates.


Missing 'pwm_config_set_clkdiv_int_fract()' function?

I've been dealing with the PWM hardware a lot in recent weeks for an upcoming Pimoroni product, and noticed that there seems to be no way set a clock divisor with a fractional integer argument during configuration.
There's a pwm_config_set_clkdiv_int(pwm_config * c, uint div) but no int_fract equivalent. Instead I am having to either cast my ints to floats to use pwm_config_set_clkdiv(pwm_config * c, float div), or activate the PWM and change the frequency using pwm_set_clkdiv_int_frac(uint slice_num, uint8_t integer, uint8_t fract).
Best as I can tell, there is no hardware limitation for this so it may just be an oversight. If this is the case would you like me to raise a PR to add it? I would leave the existing function alone for compatibility of course.

In a similar vein, there's no pwm_set_clkdiv_int either :smiling_imp:
So yeah, looks like a small oversight that the pwm_config_set_ functions have clkdiv and clkdiv_int; but the pwm_set_ functions have clkdiv and clkdiv_int_frac ? :shrug:

You make a valid point re: missing pwm_set_clkdiv_int() 😆 .
I mention the lack of the fract version more so because hardware features like PIO have both a sm_config_set_clkdiv_int_frac() and pio_sm_set_clkdiv_int_frac(), leading me to believe that's the intended convention.
I don't think there's an int only version anywhere else in the API, but I'd be happy to be proven wrong 🙂

Yup, looks like you're right:
$ git grep "_int(" | grep -v resolvable_int
src/common/pico_binary_info/include/pico/binary_info/code.h:#define bi_int(_tag, _id, _value) \
src/common/pico_binary_info/include/pico/binary_info/code.h:#define bi_binary_end(end) bi_int(BINARY_INFO_TAG_RASPBERRY_PI, BINARY_INFO_ID_RP_BINARY_END, end)
src/rp2_common/boot_stage2/pad_checksum:def any_int(x):
src/rp2_common/hardware_pwm/include/hardware/pwm.h:static inline void pwm_config_set_clkdiv_int(pwm_config *c, uint div) {
src/rp2_common/hardware_pwm/include/hardware/pwm.h:    pwm_config_set_clkdiv_int(&c, 1);
$ git grep "_int_frac("
src/rp2_common/hardware_pio/include/hardware/pio.h:static inline void sm_config_set_clkdiv_int_frac(pio_sm_config *c, uint16_t div_int, uint8_t div_frac) {
src/rp2_common/hardware_pio/include/hardware/pio.h:    sm_config_set_clkdiv_int_frac(c, div_int, div_frac);
src/rp2_common/hardware_pio/include/hardware/pio.h:    sm_config_set_clkdiv_int_frac(&c, 1, 0);
src/rp2_common/hardware_pio/include/hardware/pio.h:static inline void pio_sm_set_clkdiv_int_frac(PIO pio, uint sm, uint16_t div_int, uint8_t div_frac) {
src/rp2_common/hardware_pio/include/hardware/pio.h:    pio_sm_set_clkdiv_int_frac(pio, sm, div_int, div_frac);
src/rp2_common/hardware_pwm/include/hardware/pwm.h:static inline void pwm_set_clkdiv_int_frac(uint slice_num, uint8_t integer, uint8_t fract) {
src/rp2_common/hardware_pwm/include/hardware/pwm.h:    pwm_set_clkdiv_int_frac(slice_num, i, f);
test/hardware_pwm_test/hardware_pwm_test.c:            pwm_set_clkdiv_int_frac(pwm, i, f);

So perhaps it makes sense to add pwm_config_set_clkdiv_int_frac(pwm_config *c, uint8_t integer, uint8_t fract), and then make pwm_config_set_clkdiv_int(pwm_config *c, uint div) simply do pwm_config_set_clkdiv_int_frac(c, div, 0); ?

yes please add it via PR

merged into develop


⚠ Bofrost.fr has degraded performance

In f0e730e, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 2058 ms

Resolved: Bofrost.fr performance has improved in 694c75d after 8 minutes.


feature: auto-generate layout file from currently running tmux session

Just like "pip freeze" - freezes the currently visible tmux layout into a layout file skeleton. Would greatly simplify layout setup...
Anyway - teamocil is a great tool, don't want to miss it :) Thanks!

Hi @remiprev,
Your comment about getting current layout from terminal is super helpful!
What do you think mentioning this trick in the README? as I think MANY people would like to have custom layout (saying that we can use tmux splitting and :resize-pane commands as we like and then save the custom layout)

@scientist1642 Yeah, I think it was in the README.md before the 1.0 rewrite. I’ll add it back 😄

@scientist1642 Done! https://github.com/remiprev/teamocil/commit/7f8a47f6632d2aeff683c71a3ed3d5cfdd3a87a1

@remiprev cool! 🎉


[auth-swift] Finish Transition to async-await for RPC calls

Finish series of PRs #11547, #11551, #11552 to transition RPC APIs to async await

Updated some other internal functions to async await
Transitioned some tests from using group's to blocks to simulate fake RPC responses. Follow PRs should transition more since it significantly simplifies tests
Some tests required short sleeps to allow await's to finish, since they had been effectively straight-line code through the callbacks and fake RPC implementation

Merging here and will address any feedback in subsequent PRs.


add ravel law to adopters list

Current coverage is 81.59% (diff: 100%)

Merging #451 into master will decrease coverage by 0.09%

@@             master       #451   diff @@
==========================================
  Files            80         80
  Lines          2135       2135
  Methods        2043       2043
  Messages          0          0
  Branches         92         92
==========================================
- Hits           1744       1742     -2
- Misses          391        393     +2
  Partials          0          0

Powered by Codecov. Last update 8e3d7f0...0c872b9

Thanks @emanresusername!


chore: update packages

:tada: This PR is included in version 1.4.41 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Improve Register Page Screen

Make the UI for the register page screen with the field like Email, Password and Register Button and add a text like Already Registered ? Login.
Follow the design pattern as followed in the Login Page

Remember to reuse the widgets made in the components folder.

Hey @arteevraina Can i work on this issue?
This issue and #26 can be worked together so I'll be working on both of them.

Sure thing ! Let me know if you face any issues while setting up the project.

Yeah Sure Thanks.


Visual Studio support

Created a Visual Studio solution file and added all the projects into it.
Fixes #2

This is ready for review.

Thank you so much!!!!

Thank you.


[DesignProposal]: Execution strategy and chunked stream data processing

Background and Motivation
No response
Design
Execution strategy
There are several ways that Towhee execute operators in the workflow, according to data type and execution mode:

Say we have three operators, namely A, B, C, and input data 1, 2, 3.

With unstreamed data and unparalleled execution:
Execute A with data 1, 2, 3 in order, then execute B with 1, 2, 3, finally execute C;
With streamed data and unparalleled execution:
Execute A, B, C for data 1, then Execute A, B, C for data 2, finally run A, B, C for data 3;
With unstreamed data and paralleled execution:
Execute A with data 1, 2, 3 at the same time, then B, finally run C;
With streamed data and paralleled execution:git add:
Excute A for 1, then A start process 2, meanwhile, B start process 1, and so on.

Chunked data
With Chunked data, we preserve the same execution strategy.
For stream chunked data, we will introduce a buffer:

We load data from stream to fill the chunk(buffer), then push the chunk(buffer) into a chunk(buffer) queue, the queue will pop the chunk(buffer) to feed the operator. By default, we will set the queue length to 1, i.e. Only one chunk(buffer) in queue . Once the chunk(buffer) is consumed, a new chunk will be produced.
Pros and Cons
No response
Anything else? (Additional Context)
No response

Why we don't use stream+parallel execution by default:

we have to load all the operators into memory when using stream+parallel, which will increase the peek memory usage;
race condition will increase system latency;


Xcode 9 support state

I wanted to check migration path to Xcode 9.
I am using Xcode 9 beta 5.
If I use stable fbsimctl 0.4.0 build installed via brew install fbsimctl(using Xcode 8.3.2) then fbsimctl list command will result in
Error Domain=com.facebook.FBControlCore Code=0 "Attempting to load a file at path '/Applications/Xcode-9.beta.5.app/Contents/Developer/Library/PrivateFrameworks/CoreSimulator.framework', but it does not exist" UserInfo={NSLocalizedDescription=Attempting to load a file at path '/Applications/Xcode-9.beta.5.app/Contents/Developer/Library/PrivateFrameworks/CoreSimulator.framework', but it does not exist}

Trying to install latest fbsimctl via brew install fbsimctl --HEAD fails with
The following build commands failed:
	CompileC build/Build/Intermediates.noindex/FBSimulatorControl.build/Debug/XCTestBootstrap.build/Objects-normal/x86_64/FBXCTestDestination.o XCTestBootstrap/Configuration/FBXCTestDestination.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

What is current status on Xcode 9 and iOS 11 support?

Current solution I found is to build fbsimctl with Xcode 8.3.3 from commit 4a3a339ca325ae2ac0b34fef92605204b79e0c09.
After that you can xcode-select Xcode-9.beta.5 and use fbsimctl to launch iOS 11 simulators, etc.

Meanwhile Xcode 9 is supported...
git clone https://github.com/facebook/FBSimulatorControl.git
cd FBSimulatorControl
git checkout 4a3a339ca325ae2ac0b34fef92605204b79e0c09
sudo xcode-select -s /Applications/Xcode-8.app
./build.sh fbsimctl build output

Bins will be in output/bin, just add this full path to your PATH and you are good to go until Xcode 9 is supported.

Hi @MoOx
Your method does not seem to work for me. I am seeing the following error still after following your steps. It's trying to locate the CoreSimulator framework in Xcode 9 which does not exist. I did use git clone and checked out the same commit as you mentioned. What could be wrong here?
Error Domain=com.facebook.FBControlCore Code=0 "Attempting to load a file at path '/Applications/Xcode-9.app/Contents/Developer/Library/PrivateFrameworks/CoreSimulator.framework', but it does not exist" UserInfo={NSLocalizedDescription=Attempting to load a file at path '/Applications/Xcode-9.app/Contents/Developer/Library/PrivateFrameworks/CoreSimulator.framework', but it does not exist}

I can see in your notes that the version of Xcode is Xcode-9. My instructions are for Xcode 8. I just built it on my machine this way a few our ago (my machine is a macbook pro 2016 that run macOS 10.13 with Xcode 8+ and 9-beta.6.

ah I see I misread your comment. thanks!

Hi guys, so is this issue resolved? Cause I am running into the same issue. And it seems like there is no current way for Xcode 9 GM. Or can I have both Xcode 9 GM and Xcode 8 at the same time? Thanks

Just name Xcode 8 "Xcode-8.app" and you won't have any problem :)
https://github.com/facebook/FBSimulatorControl/issues/435#issuecomment-329522823 works for me this way.

Hello guys! This error still reproduced for me after updating Xcode to Version 9.0 (9A235), Please, help me.
'Failed to private frameworks for FBSimulatorControl with error Error Domain=com.facebook.FBControlCore Code=0 "Attempting to load a file at path '/Applications/Xcode.app/Contents/Developer/Library/PrivateFrameworks/CoreSimulator.framework', but it does not exist"

I am also getting the same Error! with Xcode Version 9.2 (9C40b), Mac version: 10.13.2 (17C88)
** BUILD FAILED **
The following build commands failed:
CompileC build/Build/Intermediates.noindex/FBSimulatorControl.build/Debug/XCTestBootstrap.build/Objects-normal/x86_64/FBTestManagerTestReporterTestCase.o XCTestBootstrap/TestManager/FBTestManagerTestReporterTestCase.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler
(1 failure)

I had different error with Xcode 9.2
The following build commands failed:
	CompileSwift normal x86_64 /Users/yongping/Documents/CompanyProjects/ReactNative/FBSimulatorControl/fbsimctl/FBSimulatorControlKit/Sources/SimulatorReporter.swift
	CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler
(2 failures)

Having the same problem as @yongpingchen here.


add perf note in readme

Thanks for this contribution, but this is a tip for Gson as opposed to auto-value-gson, so I'm going to leave it out.  I also would rather not link to a blog post that is out of my control.

Why not keep this tip? With the generated reflection-free adapter, we can gain lots of performance improvement. I think it's useful for users, especially given that auto-value-gson already generates those reflection-free adapters. I can remove the link.

I chatted with a Gson maintainer about this, and it's not an auto-value-gson related tip, so it's outside the scope of this project.
I think the challenge comes in that we want the readme to quickly specify how to use auto-value-gson.  We could fill it up with "pro-tips" but that dilutes it's value.
I do think that's a great test you did and plan to share the blog post.


footerRenderer does not seem to work

I'm trying to use footerRenderer property to render custom content in the table's footer, but the function does not seem to do anything. Is the functionality not working or am I missing something obvious?
The result that I get:

There is a fixed space created at the bottom of the table, but nothing appears there.
I'm using React 0.13.3 with Fixed Data Table 0.3.0.
Code snippet is at https://gist.github.com/Martynas-P/555fc244d6c1ffbde6bb
Thanks

@Martynas-P sorry about the slow response! As @davidxi mentions in his PR, this is because we currently expect a footerDataGetter to return a truthy value (some kind of data) to determine whether or not we want to render a cell and use the footerRenderer function provided.
I've categorized this as a bug and a need to fix documentation, as this behavior should mimic that of the header, and this should be mentioned in the docs.
However, in future versions ( #155 ) we may be looking for an alternate API to render this table that doesn't depend on the link between the data getters and renderers.

Hello,
Is there a reason why the issues which are most likely related to old versions of fixed-data-table are open? The lib seems nice but the lack of documentation is making usage really hard.
I browsed the source to discover how to specify the footer which in most recent version (now being 0.6.3) is by specifying footer property on Column component...
Thanks,


Removal of Token Persistence

Problem
Current API-M deployments utilize JWT access tokens since the required number of queries for the validation is much lesser than the opaque tokens. But due to the following use cases, a reference called the JTI is persisted at the token table for each generated access token.

To revocate an access token before the actual expiry time.
To use refresh token in refresh-grant flow

In large-scale deployments of WSO2 API Manager, this can cause a bottleneck in the persistence layer and result in reduced TPS for token generation. This can negatively impact the overall performance of the deployment. A solution is needed to improve TPS for token generation in these high-load scenarios.
Solution
The proposed solution aims to improve token management by removing the persistence of tokens in the database.

Initial POC was done by Dushani and it is documented in https://docs.google.com/document/d/1Owp_Ams5Y_xLX0xFk2t50rFCeNxL0T6CxIs4ITHTMc4/edit#
Following areas need to be handled

[ ] Access Token Generation
[ ] Refresh Token Generation
[ ] Refresh Token Grant Type related changes
[ ] Token Revocation
[ ] Revocations due to internal events

Following are the PRs for Identitiy repo containing newly introduced interfaces
Access Token Generation https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/2041
Refresh Token Generation https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/2042
Refresh Token Grant Type related changes  https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/2043

Add new component for keymanager extension to add new code repo https://github.com/wso2-extensions/apim-km-wso2is/pull/96

New DB is introduced to store persistence related data
  CREATE TABLE IF NOT EXISTS AM_INVALID_TOKENS (
     UUID VARCHAR(255) NOT NULL,
     SIGNATURE VARCHAR(2048) NOT NULL,
     CONSUMER_KEY VARCHAR(255) NOT NULL,
     TOKEN_TYPE VARCHAR(15) NOT NULL,
     TIME_CREATED TIMESTAMP DEFAULT CURRENT_TIMESTAMP,
     EXPIRY_TIMESTAMP BIGINT NOT NULL,
     PRIMARY KEY (UUID)
  ) ENGINE=InnoDB;

Need to add the following datasource in deployment.toml to point to this
  [[datasource]]
  id = "WSO2_PERSISTENCE_DB"
  url = "jdbc:mysql://localhost:3306/invalid_token_db?useSSL=false"
  username = "root"
  password = "Admin123"
  driver = "com.mysql.jdbc.Driver"
  validationQuery = "SELECT 1"
  pool_options.validationInterval = "30000"
  pool_options.defaultAutoCommit = "true"
  pool_options.maxActive = "50"
  pool_options.maxWait = "60000"
  pool_options.testOnBorrow = "true"

Add db util to access new db https://github.com/wso2-extensions/apim-km-wso2is/pull/97

identity-inbound-auth-oauth repo prs for master branch with new interfaces
https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/2054
https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/2055
https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/2056

initial implementation for apim keymanager connectors  https://github.com/wso2-extensions/apim-km-wso2is/pull/100

In APIM, portals work with opaque tokens. This needs to be changed to JWT tokens. Currently, JWT tokens are not supported when invoking product APIs. JWT based implementation is introduced to Choreo but is not working with APIM. Currently working on getting this to work with APIM

Set the product apis to work with JWT tokens https://github.com/wso2/carbon-apimgt/pull/11976

Add cleanup mechanism to remove expired tokens https://github.com/wso2-extensions/apim-km-wso2is/commit/386ee3387837733c9915f26f041ba3aabb84c5d9
Created a doc with instruction on setting up https://docs.google.com/document/d/16uISJGhspJfQ31iYaAflwdoNNSRbJABbEdsBpt7EaII/edit

2023.11.06
Fixed the PR review comments in https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/2091

Following are the remaining tasks of the feature.

[ ] Fix PR comments
[ ] Create design outline doc and send architecture mail
[ ] Handle token introspection
[ ] Handle userinfo endpoint
[ ] Handle indirect revocations in refresh grant and token revocation
[ ] Analyze impact of oauth2 tokens
[ ] Handle oauth tokens parallely with a config
[ ] Refactor connector code
[ ] Refactor gateway validation code
[ ] Smoke test
[ ] Move connector code to IS connector
[ ] Performance tests

While refactoring the connector code, came across following issues which need broader discussion before handling them

Impact to oauth cache as token persistence is removed.
Impact to token binding feature as we no longer have references to token/binding in database.
Impact to consented column in current access token table, and is consented value in AccessTokenDO.
Impact to current use of opaque token of customers
Impact to migration of current use of customized solutions for following cases

JWT persistence through custom issuer
revocation of old JWT token
use of both opaque and JWT at the same time

Migration Impact
The feature will be configurable, and it can be turned on if a user likes and the migration from old setup (old token tables) to new setup (new token tables) will be handled seamlessly. You cannot revert back to the old setup once you turn off the feature if you wish to use the old tokens. The custom implementation will be kept in the current IS-KM connector which will be released in parallel with future IS versions.

We had a review on the https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/2176 and following were discussed as actions items:

Fix test failures.
Seamlessly handle both invalidated refresh and revoked tokens without premigration to new table.
Remove db check for expired or revoked tokens during revocation endpoint flow.
Re-visit the naming of rules for indirect token revoke events and analyze the capability following a similar approach to risk profile spec.
https://openid.net/specs/openid-risc-profile-specification-1_0.html#rfc.section.2.2
https://openid.net/specs/openid-sse-framework-1_0-01.html
https://datatracker.ietf.org/doc/html/draft-ietf-secevent-subject-identifiers#section-3.2.4-1
https://datatracker.ietf.org/doc/html/rfc8417
https://openid.net/specs/openid-caep-specification-1_0-01.html#rfc.section.3.3

[ ] https://github.com/wso2-enterprise/wso2-apim-internal/issues/4702

Update 20.10.2023

Added support for entity_id and is_consented claims in JWT tokens and added support in IS-KM connector as well.
Will be checking the token cache behavior next.

Update 2023.10.26

Fixed token cache behavior.
Refactored revocation processor and token provider.
Will be refactoring the connector code along with following next.
[ ] Seamlessly handle both invalidated refresh and revoked tokens without premigration to new table.
[ ] Remove db check for expired or revoked tokens during revocation endpoint flow.

Update 2023.10.27
Fixed the code to work with migrated tokens by checking the old access token table.  Merged the fixes for identity code to handle consented claim in refresh token, entity_id claim for tokens and to fix issues in cache validation logic. More info can be found in PR description of https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/2208.
Following are the next planned tasks.

Refactor  current is-km connector code.
Merge changes from Lakith for indirect user token revocations in https://github.com/wso2-extensions/apim-km-wso2is/pull/111.
Polish up the overall is-km connector code and changes in https://github.com/wso2/carbon-apimgt/pull/12174.
Write missing unit tests.
Test with API-M usecases.
Initiate discussion on the following missing claims for the access tokens which currently we store against the token in the DB.

token_binding
is_consented
grant_type
token_id
tenant_id
authorization_code

Task List Updated as of 2023.11.04
✅ Check whether app updates, revoke tokens in default IS case

[ ] Test remaining scenarios
[ ] Add java doc comments
[ ] Refactor lakith’s APIM code
[ ] Connect with APIM code
[ ] Test IS-KM scenario + backend JWT
[ ] Fix APIM bugs
[ ] Define unit test cases
[ ] Define integration test cases
[ ] Prepare doc for IS discussion
[ ] Prepare doc for code review
[ ] Write unit test cases
[ ] Write integration test cases

To discuss

[ ] Handle token delete events for token revocation

Tested scenarios
✅ Internal user event for revocation + introspection
✅ Internal consumer app event for revocation + introspection
✅ Access token generation - password + client cred grants
✅ Refresh token generation - password grant
✅ Refresh grant handler basic scenarios
✅ Consented claim in refresh and access token generation + userinfo endpoint
TODO Testing

[ ] Refresh grant handler - extend existing token
[ ] Refresh grant handler - error path for access token.
[ ] Refresh grant handler - opaque refresh token
[ ] Refresh grant handler - revoked refresh token
[ ] Authorization code grant handler basic scenarios
[ ] Authorization code grant consented claim + userinfo endpoint
[ ] Authorization code grant cache behavior
[ ] Authorization code grant with id token
[ ] Implicit grant basic scenarios with consented claim + userinfo endpoint
[ ] Implicit grant basic scenarios with id token
[ ] Refresh token + introspection endpoint
[ ] Token revocation direct access token + introspection + userinfo endpoint
[ ] Token revocation direct refresh token + introspection + userinfo endpoint
[ ] Internal userevent for revocation + client cred grant token + introspection endpoint
[ ] Internal consumer app event for revocation + client cred grant token + introspection endpoint

The pending items of the task are as follows :

Add recently suggested changes to IS

introduce new claim to keep token ID in JWT claims

Run integration tests in IS
Run performance tests used for IS release for token performance

Backporting feature for IS 6.1 related identity branches.

[ ] Initial extension points for revocation, refresh grant - https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/2091

Closing as the task is completed.


Feature: Helm chart

First off, nice application!  Simple, easy to use, and packaged with a container!
I didn't see a helm chart kicking around, so I built one.  Just a first pass, not all the bells and whistles, but it #worksonmybox.
https://github.com/mddeff/wishlist-charts
If there's any interest in merging into this repo to have it be "official", I'm all for it, and willing to maintain when needed.  If not, totally understood; feel free to close the issue.
Thanks again for all the work on this @cmintey!

Hey, thanks! I don't know anything about Helm charts myself, so I think it's best to leave it to the community. I can certainly add a link to your repository in the Readme for others to find


Red Starting Marker to Red Circle

I went ahead and changed the starting marker to a circle. I essentially separated the two markers by treating them as separate elements startMarker and endMarker. Currently the UI looks something like this:

The main change is the inclusion of the red circle as the starting icon. The main issue I see is slight blurring on the edge of the circle for some reason but it seems to be getting better. This might be an "Edge Legacy" specific problem though. It seems to have been fixed in both browsers though. I guess we should just look out if this is a potentially recurring issue, so far I have no evidence that this is the case.

The icon seems to be in the correct dimensions, any thoughts on whether we should change the starting marker further? How does it look overall for our UI?

Oh, @amitferman did it fix?

Works now!

Nice, I am glad! How does it look compared to the previous version?


Allow direct creation of noalias on rvalue for views  e.g. noalias(view(x, ...))

This code
xt::noalias(xt::view(x, 1)) = ...

currently does not compile because we don't have an rvalue overload for noalias.

Fixed in #965


[RU] Update and fix the basics/basics lesson

This PR includes several fixes for the basics/basics lesson and the corresponding updates from #480.

Hey, @nscyclone , I've looked through this and found some place for improvement.

@nscyclone I've looked through it once again and found one last improvement. Otherwise it's awesome.

Thanks, @brain-geek, you reviewed this incredibly fast.


incompatible parameter initialization

As mentioned in the original paper:

The RNN architecture is set to 1 hidden layer with 50 neurons. The W_h matrix is initialized using orthogonal weights [23], while W_x is initialized using a uniform distribution with values between -0.01 and 0.01. We use Adam as our optimizer [15], with gradients clipped to 10. We found that weight initialization as well as the choice of optimizer were critical for training the RNNs.

In the implementation, W_x is initialized uniformly between -0.25 and 0.25. Also, W_h is initialized using tf.truncated_normal_initializer.
Initialization may have a little effect on the performance and get more compatible results.

Yeah, that's true. I remember playing around with the initialization of that but I don't remember what the conclusion was. I think it didn't have much of an effect.
Thanks for pointing it out though, you're right that this is different from the paper.


Fix usage of MediaWiki API in auto-completion for fields in the Wikibase schema

Fixes #5716
Changes proposed in this pull request:

According to MediaWiki API update, refer to https://www.wikidata.org/w/api.php?action=help&modules=wbsearchentities;
In extensions/wikibase/module/scripts/wikibase-suggest.js 65 line (var data): add uselang: o.language;
Auto-completion results are shown in selected language in OpenRefine now.

Thank you very much for reviewing the code!
I have restored the server/IDEs/eclipse/Refine with extensions.launch file. :)


link unacked PS update streams

During the tracker data analysis it was uncovered that the trackers filed against unacked PS update streams are not being linked to the affects. The reason was the missing link from unacked PS update stream to the corresponding PS module. These links were omitted to be introduced in the product definitions collector. Also the PS update stream Django model did not count on them. This PR corrects the situation so the trackers in question can be properly linked.
There is no data migration needed as the product definitions will just fix themselves on the next sync.
Closes OSIDB-629
This PR replaces https://github.com/RedHatProductSecurity/osidb/pull/96

@Elkasitu now it should be all according to our discussion. Thank you for helping to shape it and please have a one more quick look


Document pre-commit setup

Probably under docs/README.md#how-does-this-work for now.

Not a priority.


[Support] Add Wireguard to existing pivpn openvpn configuration

Assume one is running pivpn instance on raspberry pi4 that already have openvpn configuration.
What should be done to add wireguard support without touching/breaking openvpn configuration? Wireguard option was not checked during first installation of pivpn on this host.

See the pull request #1030, which is currently open.  This allows a dual install of the protocols, and I would welcome any testing of that.  You should be able to clone the repository the pull request came from.  Any help, come back to me because I am interested, I'll be around after about 12:00 today 26.

@shelleycat485  do you suggest that using both openvpn and wireguard is currently not supported in pivpn?

Its being worked on and is in the pivpn/pivpn test branch,
Both wireguard and openvpn can be installed together (Issue #968) #1048
Second protocol can be installed by doing another install, and selecting the protocol…

Second protocol can be installed by doing another install, and selecting the protocol…
Is it possible to install wiregueard to the existing openvpn-only installation without risk of altering openvpn config or affecting it's operation? This is what the issue is all about. If that is possible - how exactly one should perform it?

No, I don't think you can do that.
What you can do is go with the 1st solution I did, which should work. Its an automation of what I did with a running pivpn (openvpn), to get a wireguard onto it. It managed it and kept the configurations with a reboot.   That was basically two installations, with the first being a standard pivpn and the second as a separate pivpnY command.  To do that now, I would
1  Take a backup of your existing configuration.
2  use repository shelleycat485/pivpn branch altcommand_version.  Clone this to your target.  Check you have the right branch.
3  edit the install script so that the repository is your local one on the target (you have to do this becuase altcommand_version was intended for a pull request so it points at pivpn/pivpn repository).
4  Copy or make a link to the install script and run with --altcommand wg
5  I;m happy to help with more questions - I would test this on something local before trying the remote stuff if you have the hardware.


Cannot use Aerial Screensaver with OSX 10.14 Beta 4

Aerial screensaver will not work with OSX 10.14 Beta 4. I believe it stopped working with the update. I do understand these are betas but I enjoy the project so much I was just looking to get it working.
Tim

Duplicate of https://github.com/JohnCoates/Aerial/issues/464

Closing as duplicate of #464


Explicitly mention the bundle version to enable Fully Qualified Namespace

The document mentions:

If you are using version 5.x or higher of the extension, instead of using a connection string with a secret, you can have the app use an Azure Active Directory identity.

But doesn't mention which extension to use. After a while I realized that the bundle extension needs to be 3.x and above [3.3.0, 4.0.0)
Explicit information would save the hassle for end users.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1d50399c-0873-e903-35ca-1845c84b6c6c
Version Independent ID: 1a3150b4-5eb9-0ac5-ee2b-d1bb6b6fd63e
Content: Azure Service Bus trigger for Azure Functions
Content Source: articles/azure-functions/functions-bindings-service-bus-trigger.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@purijatin We have reference See Local development with identity-based connections in Identity-based connections section and Local development with identity-based connections section talks about required extension for each runtime.
@ggailey777 please review.

That is correct. But it is not apparent.
If you observe the below snapshot, it refers to <CONNECTION_NAME_PREFIX>__fullyQualifiedNamespace and mentions using extension 5.x or higher for service bus. What is not apparent is:

What are extensions in azure functions. And the fact that it is to be set in host.json
The extension version does not clearly imply 5.x or higher for service bus. I had to spend several minutes to understand the relationship

Just a simple reference to this link (https://learn.microsoft.com/en-us/azure/azure-functions/functions-bindings-register#extension-bundles) and one-liner to explicit use 3.3x and higher of the extension-bundle would have been helpful (instead of mentioning 5.x and higher)


How do I set fullScreenContentDelegate for AppOpenAd?

I need to know when a user dismisses the open ad. The official documentation has this:
@interface AppDelegate
    : UIResponder <UIApplicationDelegate, GADFullScreenContentDelegate>

// ...

self.appOpenAd.fullScreenContentDelegate = self;

I can't see the equivalent in AppOpenAd class. Did I miss something? How do I handle these events? My current code looks like this (error handlings etc are removed for brevity):
this.ad = await AppOpenAd.LoadAsync(
    o.IosUnitId,
    null,
    o.Orientation switch
    {
        AppOpenAdOrientation.Landscape => UIInterfaceOrientation.LandscapeLeft,
        _ => UIInterfaceOrientation.Portrait,
    }
);

var oldHandler = ad.PaidEventHandler;
var openTcs = new TaskCompletionSource();

// The handler below is actually called when the ad show up
ad.PaidEventHandler = v =>
{
    oldHandler?.Invoke(v);
    openTcs.TrySetResult();
};

var root = Platform.GetCurrentUIViewController();
this.ad.PresentFromRootViewController(root);

We have the same problem, anybody got any solution?

@MarvinFrankenfeld Can you check this comment on StackOverflow? I am not sure what he was trying to say but if you understand what he means and if it's successful, could you tell me? Thanks.


unit_target_position not named correctly

Also not passing test, specifically test modify signals

When min obs is zero the expanding stat function does not work.
The issue starts with,
first_observation = df.dropna(axis=0, how='all').index[0]
# Adjust for individual cross-sections' series commencing at different dates.
first_estimation = df.dropna(axis=0, how='all').index[min_obs]
as when min_obs is zero they are the same therefore,
obs_index = next(iter(np.where(df.index == first_observation)))[0]
est_index = next(iter(np.where(df.index == first_estimation)))[0]
are the same.
df_out = df_out.fillna(method="bfill", limit=(est_index - obs_index))
So in this line limit = 0 but according to pandas doccumentation
limitint, default None
If method is specified, this is the maximum number of consecutive NaN values to forward/backward fill. In other words, if there is a gap with more than this number of consecutive NaNs, it will only be partially filled. If method is not specified, this is the maximum number of entries along the entire axis where NaNs will be filled. Must be greater than 0 if not None.
Limit can not be zero

Thanks a lot Cyrus - very helpful. Will change the code tomorrow.

Closed by #793


fix: Quick Action for Scan receipt giving not found page

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/53071
PROPOSAL: https://github.com/Expensify/App/issues/53071#issuecomment-2522157324
Tests

Prerequisite: User already submitted an expense to a workspace by scanning

Submit an scan expense in any workspace.
Open debug console and execute command:

  Onyx.merge('report_${reportID}', {
        participants: {
            '9645353': {
                notificationPreference: 'always',
            },
        },
    });

reportID is the reportID of the report we used to create expense in step 1.
3. Tapping global green +. Verify there is no quick action option.
4. Tapping report's green +. Verify there is no submit expense option.

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/b16eb29f-b28f-48f1-bfc4-b93efa4c1ef8

Android: mWeb Chrome

https://github.com/user-attachments/assets/a104df26-11b2-447a-b29e-9f9e3c3caefb

iOS: Native

https://github.com/user-attachments/assets/47072376-1913-465b-a760-5a64b47216b3

iOS: mWeb Safari

https://github.com/user-attachments/assets/bace4810-bf6a-44ef-9257-906ed7b81f14

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/181c2afe-843b-4500-a721-c99bd9f65512

MacOS: Desktop

https://github.com/user-attachments/assets/236c93c4-358c-4468-97ad-445903c8c8fc

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


python311Packages.rapt-ble: 0.1.1 -> 0.1.2

Diff: https://github.com/sairon/rapt-ble/compare/refs/tags/v0.1.1...v0.1.2
Changelog: https://github.com/sairon/rapt-ble/blob/v0.1.2/CHANGELOG.md
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 238241 run on x86_64-linux 1

5 packages built:

home-assistant-component-tests.rapt_ble
python310Packages.rapt-ble
python310Packages.rapt-ble.dist
python311Packages.rapt-ble
python311Packages.rapt-ble.dist


Only close posting window when pasting succeeded

#113

@SummerWish Is this incorporated in your other pull requests? Regardless, I think it may be best to close this and implement on top of the messaging interface?

Yup. This PR can be replaced by the seamless-posting. Closed.


Spec-file: Embed tests

Fedora packaging guidelines encourage using %check even if there are external testing frameworks. I have tried to enable this in #1913, but I've found that there are 168 failed/error tests that need to be addressed, so I am separating this.
Here are a few notes:

Testing requirements are not well separated, e.g. python3dist(setuptools-scm-git-archive) is required by test_local_build.py/test_rpm_command because it is a build dependency of ogr. Other packages should be used here with more minimal dependencies requirements, especially for local build modes
Tests should have some marks like local_build, koji etc.:

local_build: The user might not want to include ephemeral development packages, e.g. python3dist(setuptools-scm-git-archive), just so that local builds pass. Instead they might prefer a containerized workflow with mock, copr, etc. These tests should be disabled by default, but enabled in the CI
koji, copr, etc.: These are not mocked so they might require internet connection and/or authentication from gssapi, ssh, etc. They seem to be build specifically for zuul testing framework, but they should be expanded
isolated (or rather not isolated): For tests tat can (or cannot) be run in an isolated environment without network connection
rpm_spec_fail: A general catch-all for any other tests that are not designed to work inside the spec files

TODO:

[ ] Create relevant pytest marks
[ ] Make the tests succeed in the spec file
[ ] Change the default test marks for developers git cloning, zuul/fmf CIs, spec file

Softly depends on: #1913 (can be rebased out)
RELEASE NOTES BEGIN
Embed pytest in the spec file
RELEASE NOTES END

Could you change base so it is clear which commits belong to this PR?

Could you change base so it is clear which commits belong to this PR?

Tricky because I want to use the %pyproject_buildrequires to catch missing testing packages. But basically only the top-most commit: 0bbc85dd966864c88c4aa7b6399754ec0acce21a. The main thing are the rpm-build failures that we need to address here. Also should note that the testing are taylored to run for zuul and tmt, not for local and rpm. With this PR we should decouple the testing environment so that it works for the latter 2, e.g. not requiring a kerberos keytab for koji

Edit: oh do you mean the target branch? It would have to be a branch on packit to do that, or open an equivalent PR in my fork.

Oh, right, I didn't realize it would have to be in your fork, never mind then :slightly_smiling_face:
I think bb2ac0fde83ed9e951b10a0ac3e2946a97ea8922 should also be part of this PR, or at least the with/without_tests part of it.

Indeed, I just didn't push the newest rebase, because I  was still rebasing. Here is the latest, with the only relevant commit: 646155c2e0cdd186795d4011be9b53f3d11645f4

python3dist(setuptools-scm-git-archive) is required by test_local_build.py/test_rpm_command because it is a build dependency of ogr.

Hopefully we can get rid of this after we switch ogr to hatchling.

Tests should have some marks like local_build, koji etc.

There are unit, integration and functional tests, I think most of integration and functional require internet connection, which disqualifies them from running in %check. I'm certainly not against adding markers, but maybe running only unit tests in %check would be sufficient.

python3dist(setuptools-scm-git-archive) is required by test_local_build.py/test_rpm_command because it is a build dependency of ogr.

Hopefully we can get rid of this after we switch ogr to hatchling.

Tests should have some marks like local_build, koji etc.

There are unit, integration and functional tests, I think most of integration and functional require internet connection, which disqualifies them from running in %check. I'm certainly not against adding markers, but maybe running only unit tests in %check would be sufficient.

Are all unit tests marked as such? I would prefer to do an inverse filtering, i.e. not intergration so that we are guaranteed to pick up all relevant tests. But local_build is categorized as functional, but I would prefer to have that enabled, so maybe there are other marking to use?

There are no markers, but the test categories are in different directories, you can run only unit tests with pytest tests/unit. But I'm not sure if some unit tests don't require internet connection etc. anyway, so some sort of marking will most likely be necessary.

stale bot is nudging to create more markers. Haven't gone through what's already defined and what needs to have at least a network marker to be buildable in the spec file.