Update continuous-integration-deployment.md

Reworded some sentences

@ryanmajidi : Thanks for your contribution! The author(s) have been notified to review your proposed change. @liud

This is an initial pass through this doc. Ultimately several how-tos should be broken out into separate docs and linked to.

@julieMSFT

Hi @ryanmajidi - This pull request was opened in the public repo. PMs should work in the private repo, per the Microsoft Docs contributor guide. It looks like you might have opened pull requests in the private repo before; would you make this content update in the private repo, also? Let me know if you need more information. Thank you! We'll close this PR.


Add course section in the text file

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

@nithinmakam
Thanks for this pull request (PR).
Unfortunately, we are marking this PR invalid for hacktoberfest. We believe it does not follow the recommended guidelines:

Quality Standards
In line with Hacktoberfest value #2 (Quantity is fun, Quality is key), we have provided examples of the quality >standards we encourage. This applies mainly to beginners.

PRs that are automated e.g. scripted opening PRs to remove whitespace / optimize images.
PRs that are disruptive e.g. taking someone else's branch/commits and making a PR.
PRs that are regarded by a project maintainer as a hindrance vs. helping.
Something that's clearly an attempt to simply +1 your PR count for October.

Learn more at https://hacktoberfest.digitalocean.com/details


My note doesn't display correctly - Iframes

I can't seem to get Iframes to work on shared notes. is this a known limitation of some sort? thanks!
In the below example, I used google.com as an example.

This is a photo of the note in reading mode

And this is the shared link
https://share.note.sx/kxqdgz6l#X46+5qjxI2X9fzyQTQMQ32UyMMeORj6szIjx9PZRtts
wich displays like this:

This is because Google (any most any other site) won't allow this, for security reasons.
If you look at the error in the console of your browser, you'll see something like:
The loading of “https://www.google.com/” in a frame is denied by “X-Frame-Options“ directive set to “sameorigin“.

This means that Google has a property called X-Frame-Options which only allows Google pages to be shown from Google domains, not from share.note.sx domain.
Desktop apps like Obsidian can do it, but not browsers.


How to use eo-learn tasks to load local saved Sentinel-2 data?

What is the problem? Please describe.
A clear and concise description of what the problem is.
Here's the solution
A clear and concise description of what you want to happen.
Alternatives
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Please provide more information - the template to provide relevant info is given so that it helps us understand your issue...
If you don't provide additional details, we cannot help you.

How I can I load Sentinel-2 images (SAFE) -downloaded to disk - using eo-learn and than safe  it to EOpatch format.

thanks for your prompt reply...


[METROL 236] HDR luminance adjustment possibility

https://github.com/rdkcentral/ThunderInterfaces/pull/36

Changes implementation due to changes in the interface


Kubernetes Runbook: Kube Node not ready

Is your feature request related to a problem? Please describe.
A runbook to check if Kube Node is ready or not and if it is not ready, print the reason for it not being ready.
Describe the solution you'd like
Here's the Prometheus runbook for this particular issue: https://runbooks.prometheus-operator.dev/runbooks/kubernetes/kubenodenotready/

Hello, @JBAhire I want to contribute to this project. Please assign.

Thanks, @FaithKovi . Assigned the issue to you. Let us know if you need any help here.

@JBAhire Could you share some resources that will be helpful in solving this issue? I will really appreciate it. Thank you.

Hi @FaithKovi, thanks for reaching out to us.
Here are some documentation links that you can refer to-
Kubernetes Architecture
Kubernetes Nodes
Best practices for Deploying Kubernetes cluster
The runbook @JBAhire shared above Prometheus runbook for a similar issue should also help.
@jayasimha-raghavan-unskript please add any other details that you feel are appropriate

@JBAhire I won't be able to complete this. Assign to someone else.


Why not jwt?

I trying to make a rest api similar to yours...
Shouldn't be better to use JWT instead of bearer and not saving into database?
Why do you put the profile in the strategy instead of callbackURL as is in the docs?
passport.use(new FacebookStrategy({
    clientID: FACEBOOK_APP_ID,
    clientSecret: FACEBOOK_APP_SECRET,
    callbackURL: "http://localhost:3000/auth/facebook/callback"
  },
  function(accessToken, refreshToken, profile, cb) {
    User.findOrCreate({ facebookId: profile.id }, function (err, user) {
      return cb(err, user);
    });
  }
));
` ``

Upps, I see profile field in the strategy class is to get displayName!

This repository is still in development, so nothing is set in stone yet. I'm working on implementing the code and token grant for oauth2 at the moment and bearer is the preferred strategy for oauth2. I might consider jwt in the near future.


Only enable native syntax in dart-ext libraries.

Fasta should be able to tell if a library needs the native syntax by being able to tell if a library is loaded as dart-ext.
It's possible that we need to extend kernel-service to make this information available.

Wouldn't it be sufficient to see the imports on that same library?
I thought that native was used in files that contain the dart-ext import.

oops, github misinterpreted my commit message.

I think you're right.

@mit-mit This one as well?

Yes, closing as irrelevant due to https://github.com/dart-lang/sdk/issues/45451


Use UTF-8 instead of the default encoding charset encoding

Signed-off-by: Yinan Li<EMAIL_ADDRESS>

LGTM. Everything we run on should use the UTF-8 as the default encoding right, so this shouldn't really change anything.

Yes, I looked at the Charset.defaultCharset() method. It seems it will fall back to UTF-8 for our use.

@narasimhareddyv, can you verify that the UTF-8 encoding works for the SalesforceExtractor?

Hey, @narasimhareddyv, can you verify that the UTF-8 encoding works for the SalesforceExtractor?


[Feature]: Update interface of the home screen

👉 Please confirm the following

[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I checked the current issues for duplicate features.

🤔 Is your proposal related to a problem?
No response
😍 Describe the solution you'd like
About the home screen of the game it needs to have some update of the interface :

Try to stylized the two buttons

Change the black background to a space background with planets, maybe a moving background in the space ??

Add somewhere the icon of the game (download this specific image)

👍 Describe alternatives you've considered
No response
✍ Additional context
No response

Hello, I currently made some changes while I was working on #76  after I got stuck.

I'm still checking on how to include a moving background, but if it's okay I can upload these changes

Hii, @RamonASV well done! Can you just try to put some style to the music button, by removing the white background, because right now it doesn't fit really well to the rest of the design? Otherwise everything looks good.
I'm gonna check your error on the other issue ASAP. 🤔

EDIT 18 April 2024 :
The home screen still needs to be updated in a better way, mainly align the buttons and change their styles.

Hello, I am a beginner on GitHub and currently learning Java and JavaFX😊. May I try to work on this issue?

Yes I will assign you on this issue, thanks for your contribution !! :)


Deleting models.PROTECT Images, throws ProtectionError

When a Page model has a foreign key to an Image model and its on_delete is set to PROTECT
Trying to delete the image from the image module throws the uncaught ProtectionError exception.
Is it possible that this ProtectionError exception can be handled with an error message?

Hi @colinfrankb,
This has previously been requested in #1602 - will close this one as a duplicate.

Thanks @gasman


setCacheProviderOrIgnore in transaction

Hi,
we have a service that one plugin instance can run multiple times in the same process. That makes the error Cache provider must be configured before cache is accessed, because on the second time the cache was already not null https://code.yawk.at/com.jayway.jsonpath/json-path/2.4.0/com/jayway/jsonpath/spi/cache/CacheProvider.java#14
This change to make safely ignored when cache has already been created before

@dmikurube could you review this first?

@civitaspo Sorry for sending the sudden PR -- it's from us, Treasure Data. Its motivation may be unclear for you. Let me follow up.
As @vietnguyen-td wrote in the PR description, we internally have an Embulk-based microservice that runs Embulk and plugins multiple times in the same process. Such a way is actually discouraged about Embulk, so we're trying to stop such a use. (You may imagine that it, however, still needs time to change such a thing, and we still have to struggle with that yet... :cry:)
This proposed change helps the situation of ours because JsonPath's CacheProvider keeps cached items in a static context. The second and subsequent runs of this plugin now fails because it tries to setCacheProvider every time.
On the other hand, this proposed change should impact nothing about ordinary one-shot usage of Embulk.
What do you think?

@vietnguyen-td @dmikurube Sorry for the late reply, I wasn't aware of the PR coming in, I understand the issue you're having with Treasure Data. I don't think this change will affect the plugin users in any way, so I'll merge it.

@vietnguyen-td @dmikurube released https://github.com/civitaspo/embulk-filter-expand_json/releases/tag/v0.5.4

Thanks!

Thanks!


Removed countdown and standby functionality

Hello @kaulketh! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file clss/telegramBot.py:

Line 21:80: E501 line too long (80 > 79 characters)

In the file clss/telepotBot.py:

Line 23:80: E501 line too long (80 > 79 characters)
Line 196:80: E501 line too long (81 > 79 characters)


new Element.html("") throws an error on firefox

tested using dart sdk 1.12 and 1.13
It throws the following error on firefox (tested on windows 10 with firefox 29.0 - while it works fine on Chrome and IE)
Removing element due to corrupted attributes on <div>

It works when using a dummy sanitizer though.

This is not reproducing for me, but I have Firefox 42, and I wouldn't even know how to get 29. If it doesn't reproduce on a more current version, then I'd think that's a browser bug.

yes indeed. i should turn on my windows box more often. indeed working fine on Firefox 42. Sorry for the bad report


bug with ChatGoogleGenerativeAI: gemini can access only 1 tool although multiple tools given to it

Bind a gemini model with multiple tools but it can only detect 1 tool (the first 1).
Compared with ChatOpenAi, it can access all tools given to it.
Regardless of how you invoke it either directly using model, chain or graph, or how you define the tools. I even tried using prebuilt tools.
it only can detect 1 tool.
I'm using
python 3.12.1
langchain-google-genai 1.0.7
Here's the reproducible code
from langchain_core.tools import tool
from langchain_google_genai import ChatGoogleGenerativeAI
from langchain_openai import ChatOpenAI

@tool
def check_weather(location: str) -> float:
    '''Return the weather forecast for the specified location.'''
    return f"It's always sunny in {location}"

@tool
def check_live_traffic(location: str) -> float:
    '''Return the live traffic for the specified location.'''
    return f"The traffic is standstill in {location}"

@tool
def check_tennis_score(player: str) -> float:
    '''Return the latest player's tennis score.'''
    return f"{player} is currently winning 6-0"

tools = [check_weather, check_live_traffic, check_tennis_score]

# model = ChatOpenAI(
#     model="gpt-4o",
#     streaming=True
#     )
model = ChatGoogleGenerativeAI(
    model="gemini-1.5-flash",
    )

model = model.bind_tools(tools)

input = "show me all tools available to you"

result = model.invoke(input)
print(result.content)

here ChatOpenAi response:
I have access to the following tools:

1. **Check Weather**: Provides the weather forecast for a specified location.
2. **Check Live Traffic**: Provides live traffic updates for a specified location.
3. **Check Tennis Score**: Provides the latest tennis score for a specified player.

If you need information or assistance using any of these tools, please let me know!

here is ChatGoogleGenerativeAI response
I have access to the following tools:

* **`default_api`**: This API provides a function to check the weather for a given location.

I can use these tools to answer your questions and complete your requests. For example, I can tell you the current weather in London by using the `check_weather` function from the `default_api`.

You can ask questions about 2nd and 3rd tool like "what is traffic condition in LA?", "what is tennis score for rafael?". Gemini will say "I don't have access to live event" etc etc, while ChatOpenAi called the tools properly as expected.

Fyi, the change yield the desired ouput with model gemini-1.5-flash. (functions is depcreated in openai)
change
model = model.bind_tools(tools)

to
model = model.bind(
    functions=tools,
)

I cannot confirm whether it is a bug or misconconception of usage yet


Automatic Restored Revision Changelog Summary Text

Describe the feature you'd like
When using the "Restore" feature to create a new revision that's a clone of a previous revision, a changelog summary should automatically be applied, which reads Restored from #{revision number} "{cloned revision's original changelog summary}". I am open to a suggested alternative template for a restored revision changelog summary.
This replaces the current behavior, where restored revision changelog summaries are blank.
Describe the benefits this feature would bring to BookStack users
Every revision, according to best practices, should have a changelog summary. Any missing changelogs mean that a click on the revision changes or preview links are necessary to see what the revision contains, which defeats the purpose of having a changelog property available. With this feature, users' revision histories will be 100% in line with what is achieved through following best practices.
Additional context

In this image, revisions 3 and 4 are restored from edits 1 and 2, respectively. This is not made clear in the changelog summary, nor will it be easily verifiable from looking at the "Changes" view for each respective revision. These would be unacceptable submissions if they were user-edited revisions.

This history log of a Wikipedia article shows an instance where an edit (middle row) is restored (top row) to a previous version (bottom row). Underlined text, which was automatically generated, shows which version the article was restored from. This feature is what inspires my feature request.

Working locally. 2 new lines and a localization string. Plan to run tests and PR tomorrow. Haven't heard a response but I'm still open to a different templating

As per #2353, this is now merged to be in the next release.

As per #2353, this is now merged to be in the next release.


Remove "identity" and consistent id capitalization

Substituted class id for identity
Made capitalization of id consistent

This PR resolves #51


typeof isn't supported on Windows

As of 734a4ccaed0d3980d170acf66b0af48852ed5364, tree-sitter-nix no longer builds on Windows. Turns out that __typeof__ is a GCC extension supported by clang, but not MSVC. Would you be willing to revert this change?
This is preventing difftastic building on Windows with the latest version of tree-sitter-nix.

Given that the lookahead field has its type documented, I think it's reasonable to just use int32_t. What do you think @cstrahan?

Given that the lookahead field has its type documented, I think it's reasonable to just use int32_t.

Yep -- will do!
I remember looking at difftastic a couple weeks ago, and even thought about proposing Nix support -- I had no idea you already added that @Wilfred, nice!


Update allow-tcp-443-ingress-external.json

testing adding source <IP_ADDRESS>/32

I have reviewed your rules are good


Update outdated go packages if possible

Summary
There are list of go packages that are outdated and no longer provide security patches. We also want to make sure packages that shared with the KFP/KFP-Tekton deployment won't fall to behind as it will create a dependency issue.
List of Kubernetes client dependencies to update, ideally using 0.26+ as Kubernetes only provide security patches to the recent 4 major releases.
	k8s.io/api v0.24.3
	k8s.io/apimachinery v0.24.3
	k8s.io/cli-runtime v0.24.3
	k8s.io/client-go v0.24.3
        k8s.io/kubectl v0.24.3

List of dependencies that are nice to have, the grpc-gateway v1 no longer has security patches and openAPI v2 schema is out of support few years ago.
	github.com/grpc-ecosystem/grpc-gateway v1.16.0

Use Cases
When would you use this?

Message from the maintainers:
Love this enhancement proposal? Give it a 👍. We prioritize the proposals with the most 👍.

/cc @terrytangyuan

Note that for Argo 3.4 and 3.5, we do need to support some older k8s versions per the support matrix, so any deps have to allow for some version skew as well

Would love to have the grpc-gateway updated to version 2. It breaks my build rigt now.

@Tomcli Is this something you want to work on?

Hi @terrytangyuan, I'm busy with grading KFP to the new golang and dependencies for the KF 1.9 release. I think for KF 1.9 our goal is first to upgrade Argo to 3.4. If anyone can take on this issue it will be great. Otherwise I can come back once I finished all the features/issues from KFP side.

No worries. As long as this is not blocking KFP upgrade. We can leave this here for anyone who has time to take.

Sounds good

I've opened https://github.com/argoproj/argo-workflows/pull/12847 to get us back to a version with security updates.

I've opened https://github.com/argoproj/argo-workflows/issues/12851 for the OpenAPI update as it seems like a large project

Hey @Tomcli since https://github.com/argoproj/argo-workflows/pull/12847 is now merged and I've opened https://github.com/argoproj/argo-workflows/issues/12851 for the other issue. I'm going to close this as done. Thank you for reporting the issue.

the grpc-gateway v1 no longer has security patches

We may want to split another issue for grpc-gateway as well, which also seems like it might be quite an undertaking per https://github.com/grpc-ecosystem/grpc-gateway/issues/1223 and the migration guide.
It also has been mentioned in Argo a few times if we should remove gRPC support altogether as it's a source of some harder to maintain things, like HTTP being codegen'd


Error running pre-commit after pre-commit-uv install

I'm running on Windows 11 and have both pre-commit and uv installed with pipx. I followed the pipx instructions to inject install pre-commit-uv then tried deleting my pre-commit cache and running pre-commit on a repo to receive this error:
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Using pre-commit with uv 0.2.34 via pre-commit-uv 4.0.2
An unexpected error has occurred: CalledProcessError: command: ('C:\\Users\\Owen\\.local\\pipx\\venvs\\pre-commit\\Scripts\\uv.exe', 'venv', 'C:\\Users\\Owen\\.cache\\pre-commit\\repoj03weecx\\py_env-default')
return code: 1
stdout: (none)
stderr:
      × No interpreter found in system path or `py` launcher
Check the log at C:\Users\Owen\.cache\pre-commit\pre-commit.log

Sounds like a UV bug 🥲

Fixed now give it a try again.

Thanks for trying to resolve this so fast. Still no joy though 😞 4.0.3 gives me the same problem.
pre-commit run --all-files
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/igorshubovych/markdownlint-cli.
[INFO] Initializing environment for https://github.com/charliermarsh/ruff-pre-commit.
[INFO] Initializing environment for https://github.com/crate-ci/typos.
[INFO] Initializing environment for https://github.com/rtts/djhtml.
[INFO] Initializing environment for https://github.com/adrienverge/yamllint.git.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Using pre-commit with uv 0.2.34 via pre-commit-uv 4.0.3
An unexpected error has occurred: CalledProcessError: command: ('C:\\Users\\Owen\\.local\\pipx\\venvs\\pre-commit\\Scripts\\uv.exe', 'venv', 'C:\\Users\\Owen\\.cache\\pre-commit\\repobsvszmp6\\py_env-default')
return code: 1
stdout: (none)
stderr:
      × No interpreter found in system path or `py` launcher
Check the log at C:\Users\Owen\.cache\pre-commit\pre-commit.log

I'll attach the full pre-commit.log if that helps.

I do not have a Windows machine to replicate, but PR welcome.

Can you try again with https://github.com/tox-dev/pre-commit-uv/releases/tag/4.1.4

Sorry for the late reply. Yes it is working on Windows now thank you!


Unify interactive component payload processing

Slack provides single entry point for processing interactive components either it comes from dialog, menu or somewhere else.
CURENT STATE:

Quite hard to detect and create proper Payload;
There are two different PayloadTypeDetector classes in different packages with absolutely the same code;
Need to implement if-elseif-else for each particular interaction type;

PROPOSAL:

move PayloadTypeDetector class into general place (utils);
implement interface Payload with common methods: at least getType();
make all XyzPayload classes implements Payload interface;
implement PayloadFactory, as (example):

public class PayloadFactory {

    static Map<String, Payload> payloadMap = new HashMap<>();

   //TODO: register all implemented payloads in payloadMap

    public PayloadFactory(List<Payload> payloads) {
        for (Payload payload: payloads) {
            payloadMap.put(payload.getType(), payload);
        }
    }

    public static Optional<Payload> getPayload(String payload) {
        PayloadTypeDetector detector = new PayloadTypeDetector();
        String detectedType = detector.detectType(payload);
        return Optional.ofNullable(payloadMap.get(detectedType));
    }

}

following usage:

Optional<Payload> payload = PayloadFactory.getPayload(jsonPayload);

I really don't understand your intention yet. What is the benefit we gain by calling PayloadFactory.getPayload and getting the minimum Payload type object? I'm afraid that library users have to do down-casting to XyzPayload afterwards.

While trying to find a best way to process different types of payload I have revised a bit above concept.
Below is how my current code looks like.
Issue is the current "complexity" of GenericPayloadWrapper and need of use reflection API because, BlockActionPayload, DialogSubmissionPayload, DialogSuggestionPayload, DialogCancellationPayload, AttachmentActionPayload and MessageActionPayload classes do not implement common interface which can return Payload type.
Take a look if you can refactor your XyzPayload classes, simplify based on it the below GenericPayloadWrapper and add/apply this to your library in order to make it use more efficient.
import com.github.seratch.jslack.common.json.GsonFactory;

// Custom (own) PayloadDetector
public class PayloadDetector {

    // common Payload properties
    public String type = "";
    public String token = "";
    public String responseUrl = "";

    public static PayloadDetector detect(String json) {
        return GsonFactory.createSnakeCase().fromJson(json, PayloadDetector.class);
    }
}

import com.github.seratch.jslack.app_backend.interactive_messages.ResponseSender;

public interface PayloadWrapper {
    String getType() throws Exception;
    String process(ResponseSender responseSender) throws Exception;
    PayloadWrapper newWrapperFromJson(String jsonPayload) throws Exception;
}

import com.github.seratch.jslack.app_backend.interactive_messages.ResponseSender;
import com.github.seratch.jslack.common.json.GsonFactory;

import java.lang.reflect.Method;

public class GenericPayloadWrapper<T> implements PayloadWrapper {

    private Class<T> payloadClass;
    protected T payload;

    public GenericPayloadWrapper(Class<T> payloadClass) {
        this.payloadClass = payloadClass;
    }

    private T getNewPayloadInstance() throws Exception {
        return payloadClass.getDeclaredConstructor().newInstance();
    }

    @Override
    public PayloadWrapper newWrapperFromJson(String jsonPayload) throws Exception {
        GenericPayloadWrapper w = this.getClass().getDeclaredConstructor().newInstance();
        w.payload = GsonFactory.createSnakeCase().fromJson(jsonPayload, payloadClass);
        return w;
    }

    @Override
    public String getType() throws Exception {
        T p = this.getNewPayloadInstance();
        Method method = p.getClass().getMethod("getType");
        method.setAccessible(true);
        return (String) method.invoke(p);
    }

    @Override
    public String process(ResponseSender responseSender) throws Exception {
        return "'" + getType() + "' is not implemented yet!";
    }
}

Now when I have all above in my Spring Boot application I can create following PayloadFactory:
import org.springframework.stereotype.Service;

import java.util.HashMap;
import java.util.List;
import java.util.Map;

@Service
public class PayloadFactory {

    private static Map<String, PayloadWrapper> payloadWrapperMap = new HashMap<>();

    // Spring framework will create this factory and call constructor with List
    // of all registered beans / components of type PayloadWrapper
    public PayloadFactory(List<PayloadWrapper> payloadWrappers) throws Exception {
        for (PayloadWrapper payloadWrapper : payloadWrappers) {
            String payloadType = payloadWrapper.getType();
            System.out.println("REGISTER PAYLOAD WRAPPER of TYPE: " + payloadType);
            payloadWrapperMap.put(payloadType, payloadWrapper);
        }
    }

    public static PayloadWrapper getPayloadWrapper(String jsonPayload) throws Exception {
        String detectedType = PayloadDetector.detect(jsonPayload).type;
        PayloadWrapper wrapper = payloadWrapperMap.get(detectedType);
        if (wrapper != null) {
            return wrapper.newWrapperFromJson(jsonPayload);
        }
        return null;
    }
}

Here is an example of implementation with Spring for one of Payload types:
import com.censhare.microservices.bot.slack.payload.GenericPayloadWrapper;
import com.github.seratch.jslack.app_backend.dialogs.payload.DialogSubmissionPayload;
import com.github.seratch.jslack.app_backend.interactive_messages.ResponseSender;
import org.springframework.stereotype.Component;

@Component
public class DialogSubmissionPayloadWrapper extends GenericPayloadWrapper<DialogSubmissionPayload> {
    public DialogSubmissionPayloadWrapper() {
        super(DialogSubmissionPayload.class);
    }
    @Override
    public String process(ResponseSender responseSender) {
        // Do something (custom impl.), send response over responseSender
        return null; // to close dialog
    }
}

Now my /interaction processing endpoint can be unified following way:
@RestController
@RequestMapping("/api/slack")
public class SlackRestController {

    private ResponseSender responseSender;

    public SlackExtRestController(ResponseSender responseSender) {
        this.responseSender = responseSender;
    }

    @PostMapping(value = "/interaction",
            consumes = MediaType.APPLICATION_FORM_URLENCODED_VALUE,
            produces = {MediaType.APPLICATION_ATOM_XML_VALUE, MediaType.APPLICATION_JSON_VALUE})
    public @ResponseBody String interaction(
            @ModelAttribute(name = "payload") String param) throws Exception {

        PayloadDetector detector = PayloadDetector.detect(param);
        logger.info("interaction ({}): '{}'", detector.type, param);

        if (!detector.token.equals(verificationToken)) {
            String responseMessage = "Sorry! You're not lucky enough to interact with this bot.";
            if (detector.responseUrl != null) {
                ActionResponse response = ActionResponse.builder()
                        .responseType("ephemeral")
                        .text(responseMessage)
                        .build();
                WebhookResponse res = responseSender.send(detector.responseUrl, response);
                logger.info("interaction: responseSender response: '{}'", res);
                return null;
            }

            return responseMessage;
        }

        PayloadWrapper wrapper = PayloadFactory.getPayloadWrapper(param);
        if (wrapper != null) {
            return wrapper.process(responseSender); // !!!!!!
        }

        return "'" + detector.type + "' is not supported yet!";
    }
}

Thanks. If I would update jslack library to enable users to handle a variety of payloads, I will go with a similar design to bolt framework. https://slack.dev/bolt
SlackApp app = new SlackApp(envValues);
app.command("/echo", (payload, asyncResponder) -> {
  // do something here
  asyncResponder.doSomething(...);
  return Responses.OK;
});

// in your controllers
app.run(request, response);

Can be also an option. Still don't forget that most people use your library with different dependency injection frameworks as Spring or similar and will try to separate implementation of callbacks for different commands, etc. into different independent classes to make code cleaner.
IMPORTANT: as it will provide this or that way a new major feature, please, start to reflect such changes in CHANGE LOG (didn't find it so far). Waiting for next release!


Avoid shadowing builtin: input --> curr_input

input() is a builtin in Python so it is not a suitable variable name.  Also, initialize the variable before referring to it.
flake8 testing of https://github.com/rwightman/pytorch-image-models on Python 3.7.1
$ flake8 . --count --select=E9,F63,F72,F82 --show-source --statistics
./data/loader.py:47:23: F823 local variable 'input' defined as a builtin referenced before assignment
                yield input, target
                      ^
1     F823 local variable 'input' defined as a builtin referenced before assignment
1

E901,E999,F821,F822,F823 are the "showstopper" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. These 5 are different from most other flake8 issues which are merely "style violations" -- useful for readability but they do not effect runtime safety.

F821: undefined name name
F822: undefined name name in __all__
F823: local variable name referenced before assignment
E901: SyntaxError or IndentationError
E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree

may change this someday, but not highest priority


Video can't load sound

i try movie video and i can't hear any sound
video test: https://drive.google.com/file/d/1Jwidx1JEXxiLnLIyBcsNsYzfZ1lO66Gr/view

mkv won't work in browser correctly. You have to convert to mp4


Major refactoring of github webhook handling.

Coverage increased (+2.04%) to 56.94% when pulling a352c95e2635d1be68c441f1a4d34c22b887ea97 on rhyolight:refactor-hook-handlers into 4b8ac2f866dc1d32bf9f848479a4c73845067a53 on numenta:master.


Feature: Adding CI integration tests to android_build.yaml

Moved the CI changes to this PR. The changes are just additions to the android_build.yaml file.

This pushed me to look into common Android architectures. See this link for more info, but I think we should deprecate support for x86.
I opened a discussion thread for this particular issue, see #195. For now I think removing x86 for the CI is the right call.
ACK a50ec5e.


Make Repairnator compile on Java >= 9

Nopol requires tools.jar as a dependency.
This library was replaced in JEP 220.
When we try to compile Repairnator on a JDK which does not have tools.jar we get BUILD FAILED. Example, with OpenJDK 14:
ERROR] Failed to execute goal on project repairnator-pipeline: Could not resolve dependencies for project fr.inria.repairnator:repairnator-pipeline:jar:3.3-SNAPSHOT: Could not find artifact com.sun:tools:jar:1.4.2 at specified path /usr/lib/jvm/java-14-openjdk/../lib/tools.jar -> [Help 1]
Ideally, we should make Repairnator compile and run (except for Nopol) on any JDK version that does not have tools.jar (any OpenJDK or Oracle Java >= 9)

This is a bug, because we build Nopol itself, so this should only be a runtime error (if using the Nopol repair tool), not a build time one.

Hi @andre15silva,
Please note that there are two profiles in the pom.xml : nopol executed in jdk1.8 and noNopol executed in jdk1.9.
If you are using Java >=9, which the tools.jar not included. Please try the following work-around which worked for me:

We set the active profile for noNopol by default in the pom.xml. First, please add the  configure in both profiles as follows:

 <activation>
         <jdk>1.8</jdk>
        **<activeByDefault>false</activeByDefault>**
 </activation>

and

<activation>
       <jdk>[1.9,1.16)</jdk>
       **<activeByDefault>true</activeByDefault>**
</activation>

Let maven active the profiles by run the code:

 mvn help:active-profiles

Then we can run mvn install -DskipTests as usual.


how to change row width?

Hi,
I just did a fresh WP install + a fresh foundationpress install. I want to change the width of the entire content, so i guess i must change and uncomment $row-width in _settings.scss. But nothing happens when i change it.
What could be wrong?
Thanks!
Matt

Yes, uncommenting and changing should do the trick. I tend to create a separate scss file for settings changes, and leave the default file alone, but your method should work. Is your project being "watched" for changes so it can recompile?

Hi guys,
To change the width of the entire content, you will have to set your new desired width in the $row-width variable in _settings.scss. Personally I prefer to keep the original _settings.scss file clean, and copy the settings I need to change in a separate _custom-settings.scss file.
In this case, copy // $row-width: rem-calc(1000); to _custom-settings.sccs, uncomment it and edit the value. You could set a new fixed rem-calc value, or use percentages.
None of your changes in scss files will be compiled to foundation.css unless you run the grunt watch task in the background. You can do this by running  npm run watch  in your terminal, or  grunt watch  if you have installed grunt as a global dependency. Please see the quickstart guide for all the details: https://github.com/olefredrik/foundationpress#quickstart
I've attached two screenshots demonstrating what you want to achieve (click to enlarge).


Auto complete doesn't work at join tables in delete statements

Hi there,
All delete queries that have table joins, as in example below, at 'on (...) ' point, doesn't open the field list, just field of target table 'f.bar'. Just remember, I always use table aliases, even for sub-queries.
delete
    b
from
    bar b
        join foo f on (f.bar = b.<HERE DON'T THROW FIELD LIST>)
where
    1=1
;

update
    bar b
        join foo f     on (f.bar = b.<HERE DON'T THROW FIELD LIST>)
        join other o on o.bar = b.<HERE DON'T THROW FIELD LIST>
set
    b.bla = 'bla'
where
    1=1
;

Sometimes it also happens on update queries, and this 'bug' appears since older versions. Fields dialog doesn't appears by auto trigger or triggering through Ctrl + Space;

issue is not reproduced on 6.0.2


[BUG]  PolygonChart error

Expected Behavior
Start Polygon Chart.
Current Behaviour
2023-12-12 22:32:44.179 Python[35221:47225125] -[__NSCFBoolean length]: unrecognized selector sent to instance 0x1e7991eb8 Process Process-1: Traceback (most recent call last):   File<EMAIL_ADDRESS>line 314, in _bootstrap     self.run()   File<EMAIL_ADDRESS>line 108, in run     self._target(*self._args, **self._kwargs)   File "/.venv/lib/python3.10/site-packages/lightweight_charts/chart.py", line 31, in __init__     webview.start(debug=debug)   File "/.venv/lib/python3.10/site-packages/webview/__init__.py", line 197, in start     guilib.create_window(windows[0])   File "/.venv/lib/python3.10/site-packages/webview/platforms/cocoa.py", line 1029, in create_window     create()   File "/.venv/lib/python3.10/site-packages/webview/platforms/cocoa.py", line 1025, in create     browser = BrowserView(window)   File "/.venv/lib/python3.10/site-packages/webview/platforms/cocoa.py", line 430, in __init__     self.window.setTitle_(window.title) ValueError: NSInvalidArgumentException - -[__NSCFBoolean length]: unrecognized selector sent to instance 0x1e7991eb8
Reproducible Example
from lightweight_charts import PolygonChart

if __name__ == '__main__':
    chart = PolygonChart(
        api_key='xxxx',
        num_bars=200,
        limit=5000,
        live=True
    )
    chart.show(block=True)

Environment
- OS: 13.6.2
- Library: <IP_ADDRESS>

Excellent lib by the way. Thanks for your effort.


DL: overview assignment

https://www.kaggle.com/datasets/russellyates88/suicide-rates-overview-1985-to-2016

https://www.tensorflow.org/tutorials/quickstart/beginner
https://www.tensorflow.org/tutorials/keras/classification
license：https://github.com/tensorflow/docs


Multiple contributors transformed as single contributor

https://api.wellcomecollection.org/catalogue/v2/works/j4jnt8bt?include=collection,notes,items,identifiers,subjects,genres,contributors,production

Turns out it's a source data issue


Add flipper for feature flipping

Adds and configures flipper setup to use reddis for persistence.
@emrojo said that redis state should be persisted across deployments
but cautions that it hasn't been heavily tested, so we may have tweaks
to make there.
Linked issues #202

Not sure what the process is for removing code once the feature flag has been enabled. Is there any chance of code being left over? The flipper stuff seems a natural way of documenting what is going on so is quite useful.

Yeah, I do like the way flipper lends itself to natural documentation. What I've done here is already prepared a removal PR while I know the issue. What I did here:

Resolved the feature flags and removed the branches of code affected.
Cleared up any subsequently unused methods.

Step 2 is a little more tricky, and not entirely without risk. As well as making it easy to leave orphaned methods, it doesn't map 1:1 to the kind of stuff flipper wraps. Mostly as things like method definitions happen, usually, at boot time, whereas flipper works most effectively at runtime (so you don't need to restart the server).
One possibility, maybe only for high risk stuff, if to wrap all candidate code for removal in a final feature flag, where we could restart the server and confirm that there aren't any major issues, before merging the PR to strip it out completely.


enhanced-resolve -> oxc-resolver

The resolver from the OXC project is majorly faster: https://github.com/oxc-project/bench-nodejs-resolver/tree/main
Would you be open to a PR for this switch?
(cc @boshen, maybe you can give some insights if the module is 'ready' to be used outside of oxc)

It seems it's very lack of documentation now.

Boshen told me at least for linting purposes it's not yet ready - so closing this for now.


docs: [vision-os-sample-app][2/n] App State Storage

Stack from ghstack (oldest at bottom):

-> #604

Context
This is a PR in a series of PRs to build sample app that runs Identify and Track in VisionPro
The app is built to be an interactive walk through guidance for developers who are integrating Customer.io Swift SDK in their VisioPro apps.
For more context:

See the project one pager
See Linear Issue

PR Summary
In this PR I added storage utilities to persiste/restore the app satate as well as few payloads that will be used for SDK initialization, and identify
Test plan

Open VisionOs.xcproject
Hit CMD+R to run the project and make sure you have VisionOS simulator installed and selected

I am on board for including these in the shared sample apps code base. But I would hold on this for now given that this is a brand new one and we have intention of revising the existing sample apps; so once this one is landed and we plan how we want to revise the rest of the sample apps we will have better idea of what to reuse from this one, existing ones and what to add as a shared code base. Then we can do that as one piece with all the information needed for it already in place


FRGWB14

Manufacturer: Eltako
Model: FRGWB14
Link to product: https://www.enocean-alliance.org/de/product/eltako-rs485-bus-wireless-actuator-pwm-dimmer-switch-frgbw14-for-led/
Hey Jey-Cee,
is it possible to integrate this into your adapter?
Greetings
Janis

Hi Janis,
yes it is possible. But i am actual on a bigger task which i want to close before add new devices.
Please be patient.

I have added the frgbw14 to devices. I need your feedback for teachin process, ideally for all possible usage modes.
Please test it.

Hi Jey-Cee,
just received the RGWB14, thank you for fast responce, I will give feedback as soon as possible,
One behaviour on my way: when i teach in new devices (0.8.5) the send ID count correkt the last two digits. But the first 6 digits are random... No problem for me, i edited in objects, but maybe worth to tell :-)

Do you have example for me with the send ID and where it is shown?
Also the support information can help me to understand that.

Any news here?


idea: Refactor OpenDAL Workflow

OpenDAL workflows are growing larger and larger. With the introduction of new testing frameworks in Java and Python, it is now time for us to refactor our code. This will allow us to eliminate duplicated code throughout our workflow and ensure its maintainability.
I plan to refactor our workflow this way:

Split existing service_test_xxx to two actions: setup_service_xxx and test_core, test_binding_java, test_binding_python (if we have)
Calling setup_service_xxx in workflow core, binding_python, binding_java instead.

Take core as an example, we will:

Build test binary with all enabled services
Upload binary to artifacts
Running tests in a matrix of service like ["s3", "fs"], for every service:

setup_service_xxx
download binary from artifacts
test_core

In general, we will:

Only build test binary once (good for all of core, binding_java and binding_python)
Reuse the service setup logic across core, binding_java and binding_python
Enable services more easily

Our goal is to ensure that all our components (core, bindings, oli, oay) are thoroughly tested across all services.

Other workflows will be kept AS-IS.

tracked at https://github.com/apache/incubator-opendal/issues/3267


Why LOG_BACKEND_RTT is forcefully selected if SHELL_BACKEND_RTT is not selected

The SHELL backends and LOG backends have different usage and following line in Kconfig gives some undesired side effect of enabling RTT logging when it is not needed, requiring projects to disable this explicitly.
https://github.com/zephyrproject-rtos/zephyr/blob/8ca14a7762ab055525dc4d59ed130c99a232eb32/subsys/logging/backends/Kconfig.rtt#L7
I think this line should be removed.

It could be useful to solve this.


Add field species: wikidata for plant objects

Description
I suggest adding the ability to add a field species: wikidata for plant objects:
*barrier=hedge
*natural=tree_row
*natural=wood
*natural=scrub
Сurrently the field species: wikidata available only for natural=tree and natural=shrub.
Screenshots

@afanasovich please move this suggestion over to https://github.com/openstreetmap/id-tagging-schema which is where the presets are discussed and maintained.

I created https://github.com/openstreetmap/id-tagging-schema/pull/320/files to solve this.


[Feature] Hover preview for links

It would be cool if the links supported hover preview.
Explanation from @lishid:
https://discord.com/channels/686053708261228577/840286264964022302/850078594768044093
Implementation from Murf:
https://discord.com/channels/686053708261228577/840286264964022302/849801819169488896
More implementation examples:
https://github.com/search?q=workspace.trigger('hover-link'%2C+{&type=code

This is definitely something I'll work on 🙂 Thanks for the input and the references

implemented as of 0.5.0


Does cache of package.json exist in Docker? How to clear it?

Hi colleagues,
We met a strange issue in pipeline setting.
In root folder of our project, there is a package.json file. Previously it contains content like:
"cds": {
        "requires": {
            "db": {
                "kind": "hana",
                "model": [
                    "db",
                    "db_master"
                ]
            }
        }
    }

However we removed value "db_master" and committed a new version:
"cds": {
        "requires": {
            "db": {
                "kind": "hana",
                "model": [
                    "db"
                ]
            }
        }
    }

This commit triggers the pipeline, however npmAudit step failed because of the following error:
[2019-10-16T09:53:39.666Z] --- BEGIN LIBRARY STEP: checkNpmAudit.groovy ---
[2019-10-16T09:53:41.273Z] Expected npm package lock file to exist. This is a requirement for npm audit. See https://docs.npmjs.com/files/package-locks for background. Executing `npm install` to create a package-lock.json at 'db'
[2019-10-16T09:53:41.587Z] --- BEGIN LIBRARY STEP: executeNpm.groovy ---
[2019-10-16T09:53:44.223Z] [handlePipelineStepErrors] Configuration: [collectTelemetryData:false, changeManagement:[type:NONE, transportRequestLabel:TransportRequest\s?:, changeDocumentLabel:ChangeDocument\s?:, clientOpts:, credentialsId:CM, git:[from:origin/master, to:HEAD, format:%b], solman:[docker:[image:ppiper/cm-client, options:[], envVars:[:], pullImage:true]], cts:[docker:[image:ppiper/cm-client, options:[], envVars:[:], pullImage:true]], rfc:[docker:[image:rfc, options:[], envVars:[:], pullImage:true]]], githubApiUrl:https://api.github.com, githubServerUrl:https://github.com, gitSshKeyCredentialsId:SSH_private_key_of_technical_user_TUGHCALMBuild, jenkinsKubernetes:[jnlpAgent:docker.wdf.sap.corp:51162/s4sdk/jenkins-agent-k8s-sap], manualConfirmation:true, manualConfirmationMessage:Shall we proceed to Promote & Release?, manualConfirmationTimeout:720, productiveBranch:NAASTest, whitesource:[serviceUrl:https://saas.whitesourcesoftware.com/api], unsafeMode:true, defaultNode:, automaticVersioning:false, echoDetails:true, failOnError:true, libraryDocumentationUrl:https://sap.github.io/jenkins-library/, libraryRepositoryUrl:https://github.com/SAP/jenkins-library/, mandatorySteps:[], stepTimeouts:[:], extensionRepository:https://github.wdf.sap.corp/CALMBuild/pipeline-extensions, xMake:[buildQuality:Milestone, novaCredentialsId:xmakeNova], gitCredentialsId:SSH_private_key_of_technical_user_TUGHCALMBuild, buildTool:mta, deployTool:mtaDeployPlugin, mtaDeployParameters:-f --version-rule ALL, cfApiEndpoint:https://api.cf.sap.hana.ondemand.com, cfOrg:cxs-calmdevprovider, cfCredentialsId:Cloud_Cockpit_login_with_technical_user_TUGHCALMBuild, influxDBServer:Jenkins, verbose:true, gitUrl:https://github.wdf.sap.corp/CALMBuild/ptm-pjm-srv.git, projectName:com.sap.calm.imp.pjm, gitCommitId:ced6a84f00b7e3fee7f7adab82ccb487d0b96d38, stepName:dockerExecute, stepParameters:[script:Script1@5abdf1ab, dockerImage:ppiper/node-browsers, dockerOptions:[--cap-add=SYS_ADMIN]], stepNameDoc:dockerExecute]
[2019-10-16T09:53:44.488Z] --- Begin library step of: dockerExecute ---
[2019-10-16T09:53:44.987Z] [dockerExecute] Sending telemetry data is disabled.
[2019-10-16T09:53:46.176Z] [INFO][dockerExecute] Executing inside a Kubernetes Container.
[2019-10-16T09:53:48.044Z] + npm install
[2019-10-16T09:54:00.410Z]
[2019-10-16T09:54:00.425Z] ><EMAIL_ADDRESS>install /home/jenkins/workspace/CALMBuild_ptm-pjm-srv_PR-174/db/node_modules/@sap/hdi-deploy/node_modules/@sap/hana-client
[2019-10-16T09:54:00.425Z] > node build.js
[2019-10-16T09:54:00.425Z]
[2019-10-16T09:54:00.425Z]
[2019-10-16T09:54:00.425Z] ><EMAIL_ADDRESS>install /home/jenkins/workspace/CALMBuild_ptm-pjm-srv_PR-174/db/node_modules/@sap/hdi-dynamic-deploy/node_modules/@sap/hdi-deploy/node_modules/@sap/hana-client
[2019-10-16T09:54:00.425Z] > node build.js
[2019-10-16T09:54:00.425Z]
[2019-10-16T09:54:00.694Z]
[2019-10-16T09:54:00.714Z] > deploy@ postinstall /home/jenkins/workspace/CALMBuild_ptm-pjm-srv_PR-174/db
[2019-10-16T09:54:00.714Z] > node .build.js
[2019-10-16T09:54:00.714Z]
[2019-10-16T09:54:04.058Z] npm notice created a lockfile as package-lock.json. You should commit this file.
[2019-10-16T09:54:04.101Z] npm WARN<EMAIL_ADDRESS>license should be a valid SPDX license expression
[2019-10-16T09:54:04.101Z]
[2019-10-16T09:54:04.101Z] added 81 packages from 111 contributors and audited 174 packages in 2.733s
[2019-10-16T09:54:04.101Z] found 0 vulnerabilities
[2019-10-16T09:54:04.101Z]
[2019-10-16T09:54:04.686Z]
[2019-10-16T09:54:04.703Z] ><EMAIL_ADDRESS>build /home/jenkins/workspace/CALMBuild_ptm-pjm-srv_PR-174
[2019-10-16T09:54:04.703Z] > cds build/all --clean
[2019-10-16T09:54:04.703Z]
[2019-10-16T09:54:04.703Z]
[2019-10-16T09:54:04.703Z] [cds] - cds [3.16.3], compiler [1.17.2], home [/home/jenkins/workspace/CALMBuild_ptm-pjm-srv_PR-174/node_modules/@sap/cds]
[2019-10-16T09:54:04.703Z]
[2019-10-16T09:54:04.703Z] {
[2019-10-16T09:54:04.703Z]   "build": {
[2019-10-16T09:54:04.703Z]     "target": ".",
[2019-10-16T09:54:04.703Z]     "tasks": [
[2019-10-16T09:54:04.703Z]       {"for":"hana","src":"db","options":{"model":["db","srv"]}},
[2019-10-16T09:54:04.703Z]       {"for":"hana","src":"db_master","options":{"model":["db_master"]}},

You may see the last line, that it can still read the REMOVED value "db_master", and it will cause error in the following:
[2019-10-16T09:54:04.703Z] Error: Build task [@sap/cds/bin/build/hana] could not be resolved - folder src [/home/jenkins/workspace/CALMBuild_ptm-pjm-srv_PR-174/db_master] does not exist

I'm wondering whether the build still uses the old version of package.json file? If yes, is there a way to ask pipeline to use the new file everytime rather than using the one which is cached?
Debug log as the following:
7. Unsuccessful Build
The build failed in the npmAudit stage.
The following error message was generated:
hudson.AbortException: script returned exit code 1

The following stack trace was generated:
org.jenkinsci.plugins.workflow.steps.durable_task.DurableTaskStep$Execution.handleExit(DurableTaskStep.java:569)
org.jenkinsci.plugins.workflow.steps.durable_task.DurableTaskStep$Execution.check(DurableTaskStep.java:515)
org.jenkinsci.plugins.workflow.steps.durable_task.DurableTaskStep$Execution.run(DurableTaskStep.java:461)
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
java.util.concurrent.FutureTask.run(FutureTask.java:266)
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
java.lang.Thread.run(Thread.java:748)

Thanks a lot,
Terry

For those who face the same issue: Look for a file called .cdsrc.json which still might contain the old state.


[Event Request] Codeunit 80 "Sales-Post" - OnCreatePrepaymentLinesOnAfterTempPrepmtSalesLineSetFilters

Please extend the event OnCreatePrepaymentLinesOnAfterTempPrepmtSalesLineSetFilters with parameter TempSalesLine.
OnCreatePrepaymentLinesOnAfterTempPrepmtSalesLineSetFilters(TempSalesLine, TempPrepmtSalesLine);

[IntegrationEvent(false, false)]
local procedure OnCreatePrepaymentLinesOnAfterTempPrepmtSalesLineSetFilters(var TempSalesLine: Record "Sales Line" temporary; var TempPrepmtSalesLine: Record "Sales Line" temporary)
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 41440.


Websocket requests are not proxied correctly in Ansible-based operators

Bug Report
What did you do?
I am trying to an Ansible k8s_exec module, which allows running the equivalent of kubectl exec commands to exec a command on a Pod via Ansible through the Python Kubernetes library. This allows me to write a task like:
- name: Test a simple command.
  k8s_exec:
    namespace: '{{ meta.namespace }}'
    pod: '{{ tower_pod_name }}'
    command: date

Instead of installing kubectl on my operator image (added COPY --from=lachlanevenson/k8s-kubectl:v1.16.2 /usr/local/bin/kubectl /usr/local/bin/kubectl to my build/Dockerfile) and writing a task like:
- name: Test kubectl exec.
  command: >
    kubectl exec -n {{ meta.namespace }} {{ tower_pod_name }} date

What did you expect to see?
When I run the same task as above on my system Ansible against a Kubernetes cluster, or even inside of the operator Pod's ansible container using ansible-playbook to run it, it executes successfully and registers the result of the command that was executed.
What did you see instead? Under which circumstances?
When it is run via the operator/ansible-runner using the operator's proxy, it results in the following error:
kubernetes.client.rest.ApiException: (0)
Reason: Handshake status 200 OK

It should be getting a 101 response from the Kubernetes API websocket.
Full error message from the failed task:
TASK [tower : Test a simple command.] ******************************************
task path: /opt/ansible/roles/tower/tasks/main.yml:38
 line 136, in <module>\n  File \"/tmp/ansible_k8s_exec_payload_x8PPAd/__main__.py\", line 123, in main\n  File \"/usr/lib/python2.7/site-packages/kubernetes/stream/stream.py\", line 32, in stream\n    return func(*args, **kwargs)\n  File \"/usr/lib/python2.7/site-packages/kubernetes/client/apis/core_v1_api.py\", line 835, in connect_get_namespaced_pod_exec\n    (data) = self.connect_get_namespaced_pod_exec_with_http_info(name, namespace, **kwargs)\n  File \"/usr/lib/python2.7/site-packages/kubernetes/client/apis/core_v1_api.py\", line 935, in connect_get_namespaced_pod_exec_with_http_info\n    collection_formats=collection_formats)\n  File \"/usr/lib/python2.7/site-packages/kubernetes/client/api_client.py\", line 321, in call_api\n    _return_http_data_only, collection_formats, _preload_content, _request_timeout)\n  File \"/usr/lib/python2.7/site-packages/kubernetes/client/api_client.py\", line 155, in __call_api\n    _request_timeout=_request_timeout)\n  File \"/usr/lib/python2.7/site-packages/kubernetes/str
eam/stream.py\", line 27, in _intercept_request_call\n    return ws_client.websocket_call(config, *args, **kwargs)\n  File \"/usr/lib/python2.7/site-packages/kubernetes/stream/ws_client.py\", line 255, in websocket_call\n    raise ApiException(status=0, reason=str(e))\nkubernetes.client.rest.ApiException: (0)\nReason: Handshake status 200 OK\n\n", "module_stdout": "", "msg": "MODULE FAILURE\nSee stdout/stderr for the exact error", "rc": 1}

Environment

operator-sdk version:

v0.11.0

go version:

N/A

Kubernetes version information:

1.16.2

Kubernetes cluster kind:

Molecule

Are you writing your operator in ansible, helm, or go?

ansible
Possible Solution
N/A
Additional context
Relates to: https://github.com/geerlingguy/tower-operator/issues/5

Note that using kubectl exec works fine inside the operator, even if I set the KUBECONFIG environment variable to the same as the ansible tasks are using with:
- name: Test kubectl exec.
  command: >
    kubectl exec -n {{ meta.namespace }} {{ tower_pod_name }} date
  environment:
    KUBECONFIG: '{{ lookup("env", "KUBECONFIG") }}'

Hi @geerlingguy,
Before any further analyse and check could you please check it with the latest version of SDK. I mean, could you upgrade your project to use SDK 0.12? Or let us know if you are able to reproduce this scenario using the Memcached sample?
Also, I checked that:

File "/usr/lib/python2.7/site-packages/kubernetes/client/apis/core_v1_api.py\

So, note that the python version was upgrade to 3. Please, could you ensure that your project was upgraded properly and you are using python 3 in the env where it has been executed?

@camilamacedo86 - Thanks for the suggestion! I'll definitely upgrade and test things (see linked issue above)—I hope to get to this soon.

#2716 looks like it resolves this issue 🎉


Refused to load the stylesheet because it violates the following Content Security Policy directive: "style-src 'self' 'unsafe-inline'

Using jwilder's nginx reverse proxy.
After adding the custom headers specified in this repo I get the following errors in browser console.
Refused to load the stylesheet 'https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/cornerindicator/indicator_separate.css' because it violates the following Content Security Policy directive: "style-src 'self' 'unsafe-inline' https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/accentlist.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/base.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/bottombarprogress.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/fixes.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/jf_font.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/overlayprogress.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/rounding.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/rounding_circlehover.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/smallercast.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/rounding_circlehover.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/cornerindicator/indicator_floating.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/cornerindicator/indicator_corner.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/effects/glassy.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/effects/pan-animation.css https://ctalvio.github.io/Monochromic/backdrop-hack_style.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/effects/hoverglow.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/effects/scrollfade.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/episodelist/episodes_compactlist.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/episodelist/episodes_grid.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/fields/fields_border.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/fields/fields_noborder.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/header/header_transparent.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/header/header_transparent-dashboard.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/login/login_frame.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/login/login_minimalistic.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/login/login_frame.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/presets/monochromic_preset.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/presets/kaleidochromic_preset.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/presets/novachromic_preset.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/titlepage/title_banner.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/titlepage/title_banner_logo.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/titlepage/title_simple.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/titlepage/title_simple-logo.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/type/light.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/type/dark.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/type/colorful.css https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/type/dark_withaccent.css https://fonts.googleapis.com/css2". Note that 'style-src-elem' was not explicitly set, so 'style-src' is used as a fallback.
What could be the issue here?

You need to add the
https://cdn.jsdelivr.net/gh/CTalvio/Ultrachromic/cornerindicator/indicator_separate.css
Into that long list on your webserver configuration


package versions are pinned

Related Ticket: https://hipo.codebasehq.com/projects/algorand-developer-portal/tickets/320
We should add a fixed version for every package that is in the requirements file to prevent any conflicts with the backend side.
Also, this pull request aims to remove warning about PymdownxDeprecationWarning during the building.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @hacernur! This may be the first PR that actually made good use of the travis CI configuration :)


[Feature Request] New component: Image, Video

Feature request 🚀

It seem no Video Component here ?

Yeah, the same discussion is answered here: @zeit-ui/react#163.

Update, let me know if anyone wants to contribute.


Fix Binance Client

https://explorer.binance.org APIs are to unstable and ceased to work for BlockAtlas.
Use Binance node client instead.

Just to consider:
In terms of transactions history explorer api will return all transactions limited by limit param where any public Binance RPC link https://dex.binance.org/api/ only last 90 days as stated in docs https://docs.binance.org/api-reference/dex-api/paths.html#apiv1transactions + multisend transactions does't not supported.
https://dex.binance.org/api/v1/transactions?address=bnb1xwalxpaes9r0z0fqdy70j3kz6aayetegur38gl&limit=100 returned 5 trx vs
https://explorer.binance.org/api/v1/txs?address=bnb1xwalxpaes9r0z0fqdy70j3kz6aayetegur38gl&page=1&rows=100 returned 98 trx vs
@terorie
What exactly did you find to be unstable ?
Is any way you can query part of data from RPC and part from Explorer do spread the load and don't get rate limited on explorer api ?

@kolya182 The Binance DEX team doesn't promise any stability guarantees guarantees on the explorer API and might alter or remove those undocumented endpoints.
You are correct about the public DEX API, it isn't an option either.
We should run our own Binance chain node and use apiserver to provide a DEX API with full transaction history: https://docs.binance.org/api-reference/api-server.html#api-server


Rearchitect SSF

Note: This is a parent issue for a lot of the other issues regarding moving stuff around in the repo and adding tests, etc.
Is your feature request related to a problem? Please describe.
The problem is that the SSF feels much more like a POC demo and less like an actual project that can be used by folks.
The goal of this issue is to architect the SSF such that it is a set of tools that can be used holistically for helping secure the supply chain for artifacts it builds.
Principles

We want the repo to look like a real software project
We want to keep it simple for the end user to install, configure and use for the simple use cases.
We want people to be able to configure the project using clearly defined interfaces.
Eventually we probably also want to allow folks to customize the project using clearly defined interfaces e.g. replace tekton with jenkinsx or something like that. (This is probably very long term)

Questions

Should we make a CLI tool to manage the SSF? Tekton has tkn, kubernetes has kubectl, should we have something like "ssf" or "ssfctl"?
Should we just have a makefile for installation?
Should we have documentation and functionality to allow for setting up the SSF "the hard way"? - We want to guide people through the decisions we made and refer back to ref arch so they understand why we use certain tools.
Should we keep using helm for everything? How do we make it easier to install and uninstall the various components of the SSF?
What should be included as part of installation process and what should be examples or tests? e.g. we probably don't want to install the demo pipeline as part of the installation of the tool
How should layout the directories?
How should we standardize around what is parameterizable in a pipeline/task?

Tools and Technologies to Explore
(Making some assumptions the existing tools we use like Cosign, Tekton, etc. are still in use)

Helm
Kustomize
Cue
https://github.com/roboll/helmfile
Makefiles
Kube yaml directly

I believe an HL architecture will help the user understand the data flow and how the different components communicate.
•	Should we make a CLI tool to manage the SSF? For example, Tekton has tkn, Kubernetes has kubectl. Should we have something like "ssf" or "ssfctl"?
If we aim to provide the UX of standard software, then yes, this will be valuable.
I suggest that we provide flags for running specific workflows, e.g., K8s demo with validating the base image / without, providing the user to add customization files to demo his workflows.
•	Should we have documentation and functionality to allow for setting up the SSF "the hard way"? - We want to guide people through the decisions we made and refer back to ref arch so they understand why we use specific tools.
Yes, IMHO, this is a must. I wish to understand better how I can tweak the demo environment and add my flows for my usage. Although it is a challenge as there is no detailed guide, I am looking at the video from KubeCon to know what the next steps are.
I will be happy to work on this with the team.
•	Should we keep using helm for everything? How do we make it easier to install and uninstall the various components of the SSF?
Switching all the steps to use helm will make it easier for users to install /uninstall the components. Still, I don’t think it will solve the problem we aim to resolve with this proposal. If we document all the steps and present a demo flow with the different components, the UX of the users will be much better. Using helm will support this goal, of course.
•	What should be included as part of installation process and what should be examples or tests? e.g. we probably don't want to install the demo pipeline as part of the installation of the tool
Yes, we need to cover the basic installation steps and explain the demo flow with the solution's value, happy to chip in and help with the documentation.
Also, if the user wants to add his pipelines, it will be great to have a template that will guide him on the correct flow.
•	How should layout the directories?
We need to make it easy for the user to distinguish between directories for the software components, configuration files, demo files, and templates, and more, for example
├── Documentation
│   ├── K8s Demo
│    └── Setting Up the Demo Env
├── Installation files
│   ├── Minikube
│   ├── Spire
│    └── Tekton
├─ K8s\ Demo
│   ├─────Configuration\ Files
│    └─── Templates
│── SSF Demo
│	└───── Configuration\ Files
└── eBpf Demo
└───── Configuration\ Files

• Should we make a CLI tool to manage the SSF? For example, Tekton has tkn, Kubernetes has kubectl. Should we have something like "ssf" or "ssfctl"? If we aim to provide the UX of standard software, then yes, this will be valuable. I suggest that we provide flags for running specific workflows, e.g., K8s demo with validating the base image / without, providing the user to add customization files to demo his workflows.

Interesting idea. That might take a while to be ready. For now we are more or less saying the interface for individual pipelines will just be Tekton tasks and pipelines following specific patterns. In order for the SSF to be extensible and flexible, especially in the short term, I think we have to sort of have an interface by convention more than built into a tool. I think I'll also record some walkthroughs of what we're doing here.

• Should we have documentation and functionality to allow for setting up the SSF "the hard way"? - We want to guide people through the decisions we made and refer back to ref arch so they understand why we use specific tools. Yes, IMHO, this is a must. I wish to understand better how I can tweak the demo environment and add my flows for my usage. Although it is a challenge as there is no detailed guide, I am looking at the video from KubeCon to know what the next steps are. I will be happy to work on this with the team.

As I mentioned, I added link just now to README to the ref architecture which is more or less the "hard way" doc.

• Should we keep using helm for everything? How do we make it easier to install and uninstall the various components of the SSF? Switching all the steps to use helm will make it easier for users to install /uninstall the components. Still, I don’t think it will solve the problem we aim to resolve with this proposal. If we document all the steps and present a demo flow with the different components, the UX of the users will be much better. Using helm will support this goal, of course.

I think in this case the ref arch does describe the flow, would love to get your thoughts on if that's the actual case.

• What should be included as part of installation process and what should be examples or tests? e.g. we probably don't want to install the demo pipeline as part of the installation of the tool Yes, we need to cover the basic installation steps and explain the demo flow with the solution's value, happy to chip in and help with the documentation. Also, if the user wants to add his pipelines, it will be great to have a template that will guide him on the correct flow.

This is where something like Cue or Rego might come in handy. Allow for the creation of arbitrary pipelines that match the guidelines as outlined in the ref arch and validate against some of that using "policy as code"

• How should layout the directories? We need to make it easy for the user to distinguish between directories for the software components, configuration files, demo files, and templates, and more, for example ├── Documentation │ ├── K8s Demo │ └── Setting Up the Demo Env ├── Installation files │ ├── Minikube │ ├── Spire │ └── Tekton ├─ K8s\ Demo │ ├─────Configuration\ Files │ └─── Templates │── SSF Demo │ └───── Configuration\ Files └── eBpf Demo └───── Configuration\ Files

I want to keep it simple for now, but I think generally this makes sense and is in line with some discussions we've had

I think this has been suitably rearchitected to hit the goals as stated above, closing this ticket


⚠ Bofrost.de has degraded performance

In b633604, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1822 ms

Resolved: Bofrost.de performance has improved in ae43116 after 6 minutes.


Add localization issue for Release 1.37

Release 1.37 has some string changes that were made since the last release, this means new localization files are required to be checked in order to see those changes be localized.

This PR is for this issue https://github.com/microsoft/azuredatastudio/pull/19638

@smartguest We can close this out now, right?


Update pipeline.yaml with latest versions of github-actions

Github pipeline
Improvement
Description of changes:
Current Github actions have a lot of warnings and even libraries that could get deprecated in the future. The idea is to keep the GitHub pipeline up to date

After the update, there are no warnings on the annotations section of Github.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

tests fixed

@jorgetovar Thanks for the contribution! 🙌


ruby: make the build reproducible

Motivation for this change
ext/io/console/io-console.gemspec was embedding a timestamp which made
the build not reproducible. Gems respect SOURCE_DATE_EPOCH so it's
enough to just delete that line if it exists.
This file has been fixed in
https://github.com/ruby/io-console/commit/679a941d05d869f5e575730f6581c027203b7b26#diff-d8422f096931c58d4463e2489f62a228b0f24f0492950ba88c8c89a0d741cfe6
And then ruby regularly merges that gem into their own repository. Ruby
master is fixed but none of the ruby releases have been fixed yet.
lib/ruby/gems/2.6.0/specifications/default/io-console-0.4.7.gemspec now
contains:
s.date = "1980-01-01"

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@nlewo I found your previous attempt of 2 years ago: https://github.com/rubygems/rubygems/pull/2481

Running nixpkgs-review. It's going to take a while.

when the build finally finished, nixpkgs-review spitted out a bunch of errors like this:
bash: /nix/store/ny7vshs45d5k193ql3b51dak0hjwwqc2-findutils-4.7.0/bin/find: Argument list too long
bash: /nix/store/7fdm1ij6f7xwjmhpici1bh3xh08n0sp7-coreutils-8.31/bin/basename: Argument list too long
bash: /nix/store/4crjhnvd8yhk063r7pwxpw6kd8aq0rbv-gnugrep-3.5/bin/grep: Argument list too long

It looks like nixpkgs-review doesn't work if there are more than 1024 outputs being rebuilt.

since the rebuild is fairly large I will rebase this on staging


[MC 1.20] Mods Button not showing?

Hi! Thanks for ModMenu! In MC 1.19.4 with ModMenu 6.1.0-rc.4 it was super easy to access it, it added a "Mods" button to the main menu and the pause menu. Now I'm playing a 1.20 modpack that includes ModMenu 7.0.1, and I verified the JAR is the same as on the release page, at least they have the same SHA-512.
However, I was unable to find the Mods button anymore. I disabled all other mods to make sure it's not a conflict, but still no trace. Screenshot of my main menu.
MultiMC's "Minecraft Log" (where all the Java messages are collected) does not contain the word "ModMenu" (letter case ignored). How can I start debugging this?

Just to make sure, is Fabric loader installed in your instance? From the screenshot you've shown, it looks like the loader isn't installed so no mods are running.

Thanks for reminding me. I had assumed a mod pack that comes with lots of Farbic mods, would have included the Fabric loader. I also assumed MultiMC would have warned when using loader mods without a loder. Sorry for having wasted your time.


Can't change paths on module generator

Based on what I read in documentation in CeedlingPacket.md, I should be able to make the module generator put its generated .h files in the inc/ directory by adding this to project.yml:
# Module generation
:module_generator:
    :inc_root:      inc/

However, ceedling seems to ignore these settings:
C:\Users\pkazakoff\STM32_Workspaces\Xmas_Gift\Xmas_Gift>ceedling module:create[testmod]
File src/testmod.c created
File src/testmod.h created
File test/test_testmod.c created
Generate Complete

I am running the latest ceedling gem (0.28.2). My full project.yml is here: https://pastebin.com/FF34P4rd.

Hi,
Did you create your project with "ceedling new "?
Because I have the same issue. It seems the latest changes of the module_generator are not incorparated yet in the gem-install of ceedling.
If you didn't choose --as_gem when creating your project, you can just update to the latest ceedling in your project:

go to your project_root/vendor, delete the ceedling folder and checkout the latest ceedling in there:
$> git clone --recursive https://github.com/throwtheswitch/ceedling.git

If you run the module_generator now, you should be able to change the inc/ path.

Does anyone know if this is still an issue?

@mvandervoord This is still an issue. With the ceedling one gets with ceedling new, you can set the src_root, but inc_root is ignored - whereas with the latest build using the git clone methodology just causes an error if the file already exists in src_root; as per #215.

Hi, i had that problem and cloning solved it but now i have second problem - test source file can't see header file now. Does anyone know how to fix this?

Ok, i've found that. In project.yml file add line -inc/** in this place
:paths:
:test:
- +:test/**
- -:test/support
:source:
- src/**
- inc/**
:support:
- test/support

Works as intended if I delete the "vendor/ceedling/plugins/module_generator/config" folder


Node working properly  but to view the status of node is not gud

sometime when we try to watch the node status is not working properly

Sometime*

sometimes , the node status is not working properly

It could be due to congestion and network issues, Please try again at a different time should work. This is normal.

We are using the geth metrics, so if the node is working properly and sometimes the dashboard is not good, can report an issue to go-ethereum :)


ArtifactReference dacpac without using cmdvariables

I have a private Nuget package that contains AppLog.dacpac. This adds our standard enterprise logging tables to the database. I am getting warnings stating  "an unresolved reference to object" How do I add ArtifactReferences ? this dacpac will be deployed inside this sql database.

I believe your use case is covered in our readme under the header Package References. In particular, you'll want something like the following:
    <ItemGroup>
      <PackageReference Include="MyDatabasePackage" Version="1.0.0" />
    </ItemGroup>

Let me know if I'm misunderstanding and this isn't what you're trying to do!

I believe your use case is covered in our readme under the header Package References. In particular, you'll want something like the following:
    <ItemGroup>
      <PackageReference Include="MyDatabasePackage" Version="1.0.0" />
    </ItemGroup>

Let me know if I'm misunderstanding and this isn't what you're trying to do!

thanks jeff. I do have that,  Also this is clarify it's just warning not errors

2 examples: of this:
SQL71502	SqlProcedure: [dbo].[spInboundSherlockEventRequest] has an unresolved reference to object [tcc].[TransactionStageIn]
SQL71502	SqlProcedure: [dbo].[spInboundSherlockEventRequest] has an unresolved reference to object [app].[Log]

Oh, sorry, I overlooked that these were warnings. There are 2 ways to suppress these:

Use the SuppressTSqlWarnings property in the project file
Use the /nowarn flag in MSBuild

@greektreat Does the name of the NuGet package match the name of the .dacpac file contained within the package? I believe that is currently required for the <PackageReference> to work as expected.

SuppressTSqlWarnings

sorry didn't respond. yes they are named the same
<ItemGroup>
    <PackageReference Include="AppLog" Version="1.0.0" />
  </ItemGroup>

  <ItemGroup>
    <None Update="AppLog.dacpac">
      <CopyToOutputDirectory>Never</CopyToOutputDirectory>
    </None>
  </ItemGroup>

@greektreat Can you share a full repro?

Closing as the requested additional info was not provided. Feel free to re-open when you have it available.


feat: Support Svelte v4

close : https://github.com/maciekgrzybek/svelte-inview/issues/43
I installed it on Svelte4 and tested it, but it seemed to work without any changes, so I did not change anything except peerDependencies.

Awesome, thanks for that :) I'll merge it this weekend :)

Ping!


adds checkBodyIsComplete to module.exports

Description
npm start did not run in the back end.
It threw the error: "Route.post() requires a callback function but got a [object Undefined]" in the file /api/app.js at line 35 column 20.
The file /api/middleware/notesMiddleware.js was not exporting the function checkBodyIsComplete,
upon fixing that, the server ran.
Video Link
Loom Video: Back end PR 114
Trello Link
https://trello.com/c/B0C1Rqah/342-bug-notes-middleware-missing-an-export
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have removed unnecessary comments/console logs from my code
[x] My changes generate no new warnings
[x] I have checked my code and corrected any misspellings
[x] No duplicate code left within changed files
[x] Size of pull request kept to a minimum
[x] Pull request description clearly describes changes made & motivations for said changes

Couldn't leave a review earlier but this was a good fix for sure and done relatively quickly! The fact it was merged signifies its accuracy and efficieny.


Condition check for schema being none added

Fixes/Implements
Description
A condition check has been implemented to check if schema is None, if it is none then it is passed into create_engine function from sqlalchemy in postgres.py database integration. It precents the issue #136 from happening.
Type of change
Delete irrelevant options.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

[x] Locally Tested

Hey @dusklight00, Thanks for finding the issue. If you write a test for it, that will be fantastic. Let me know if you need any help!

Yeah, I'll get those ready


Create Landver Design.md

Detailed Information

Related Issues
Closes #

Type of Change

[ ] 🐛 Bug fix or ⚙ enhancement
[ ] ✨ New feature or Chore (change with no new features or fixes)
[ ] 📚 Documentation update

Checklist (select as many as applicable)

[ ] The code follows the style guidelines of this project.
[ ] All new and existing tests pass.
[ ] This pull request is ready to be merged and reviewed.

Please add this to the docs folder.


Copy task source files example

Example 2 shows a way to copy files recursively.
However, it only copies the files that are present at the start of the build.
This means that after the first build, no files will be copied.
If a new build would result in new files, those will also not be copied the first time they are created.
This is most probably not what users would expect.
A stackoverflow issue has been created in the past:
https://stackoverflow.com/questions/606605/msbuild-copy-task-not-copying-files-the-first-time-round
The accepted solution works, but since MSBuild 3.5, just putting the 'MySourceFiles' ItemGroup in the Target element, works as expected.
This might improve the documentation, is a simple change and might prevent some confusion and hard to debug effects.
<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">

    <Target Name="CopyFiles">
        <ItemGroup>
            <MySourceFiles Include="c:\MySourceTree\**\*.*"/>
        </ItemGroup>

        <Copy
            SourceFiles="@(MySourceFiles)"
            DestinationFiles="@(MySourceFiles->'c:\MyDestinationTree\%(RecursiveDir)%(Filename)%(Extension)')"
        />
    </Target>

</Project>

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 160a060d-7dc1-5826-8beb-f47097d0928f
Version Independent ID: cc8a11cf-df37-97e9-bd0a-8c8ddd5037c7
Content: Copy Task - MSBuild
Content Source: docs/msbuild/copy-task.md
Product: visual-studio-windows
Technology: msbuild
GitHub Login: @ghogen
Microsoft Alias: ghogen

@khellinx
Thanks, this looks like a good improvement.

OMG is this badly documented.... wow they really need to make this resource more available in 2022, just spend a stupid amount of time trying to figure this out.
aka here is stuff... but its wrong..
https://makolyte.com/dotnet-copy-files-to-a-specified-directory-after-the-build/


TextInput box with Limited height doesn't focus to end of line after input exceeds height (RN 47.1, 45.1)

Is this a bug report?
YES
Have you read the Contributing Guidelines?
YES
Environment

react-native -v:
react-native-cli: 2.0.1
react-native: 0.47.1
node -v:
v7.10.1
npm -v:
4.2.0
yarn --version:

Then, specify:

Target Platform:
iOS, Android - Problem only reproducable on Android right now.

Development Operating System: MacOS 10.12,

Build tools: Android Studio 2.3.3

Steps to Reproduce

Create a new project with create-react-native-app AwesomeProject
Change the code in App.js to the following (apologies for the styling)

`
import React from 'react';
import { StyleSheet, Text, View, TextInput, Platform } from 'react-native';
export default class App extends React.Component {
constructor(props) {
super(props)
this.state = {
value: '',
height: 20
}
this.onContentSizeChange = this.onContentSizeChange.bind(this)
}
onContentSizeChange(e) {
const contentSize = e.nativeEvent.contentSize
this.setState({height: contentSize.height > 100 ? 100 : contentSize.height})
console.log(this.state.height)
}
render() {
return (

Open up App.js to start working on your app!
Changes you make will automatically reload.
Shake your phone to open the developer menu.

<TextInput
placeholder = 'type your text here'
multiline = {true}
style = {[styles.textInput,{height: this.state.height, width: 200}]}
value = {this.state.text}
onContentSizeChange={(e)=> this.onContentSizeChange(e)}
/>

);
}
}
const styles = StyleSheet.create({
container: {
flex: 1,
backgroundColor: '#fff',
paddingTop: 40,
paddingHorizontal: 10
},
textInput: {
marginLeft: 10,
fontSize: 16,
lineHeight: 18,
marginTop: Platform.select({
ios: 6,
android: 0,
}),
marginBottom: Platform.select({
ios: 5,
android: 3,
}),
},
});
`

Run the app and start typing in the text input box until the whole text input box is filled and keep going. Past that point you can't see what you are typing any more.
This behaviour happens even if we replace the height with a static value (eg. 100) instead of this.state.height

Expected Behavior
The focus of the text input should remain at the last character input.
Actual Behavior
Focus of the text input is outside the visible area

Reproducible Demo
See the example code listed above.

No one else facing this problem?

Seeing something potentially related, I'm getting a weird onContentSizeChange event: the multiline TextInput's contentSize decides to increase as if it needs a new line, when the text has actually only reached ~60% of the width of a line. So my TextInput grows at very odd points and too much.

@allpwrfulroot, there was a bug reported about that and was supposedly fixed for 47.2. I'm seeing this problem only on Android btw and only if I limit the expanding input field to x lines by the code above. If I let the input box keep growing, no problem

I'm seeing this on Android, too.

Actually, duplicate of #12799.

@jamesreggio Yes, didn't see that before I submitted, even though I went through the TextInput issues before I submitted this one. So I'm not alone... So it's been broken for most of the 40+ versions of RN and hasn't been fixed...

Duplicate of #12799.
And, I hope, 0bef872f3fc8b1cd78c574d03eacc886bef4e239 fixes that.


tt-rss: 2021-01-29 -> 2021-06-23 and modules/tt-rss: updated config.php creation

Motivation for this change
The version of tt-rss in nixpkgs was pre-php 8. This updates tt-rss to the most recent version, which uses php 8.
The updates to the module are required changes, per https://community.tt-rss.org/t/rip-config-php-hello-classes-config-php/4337.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 128141 at bdb0bbef run on aarch64-linux 1

1 package built successfully:

tt-rss

1 suggestion:

warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.
Near pkgs/servers/tt-rss/default.nix:13:3:
   |
13 |   installPhase = ''
   |   ^

I can review this seriously in about a week.
Maybe you will be interested in #122095 ?

I get this on upgrade:
Exception while creating PDO object:SQLSTATE[08006] [7] FATAL:  database "host=db" does not exist

Ah I had to restart php-fpm. Could you add the config to https://search.nixos.org/options?channel=21.05&show=systemd.services.<name>.restartTriggers&from=0&size=50&sort=relevance&query=systemd+service+restart for the php fpm service?

This also needs release notes to tell users of extraConfig that they need to migrate from define to putenv I suspect.

@symphorien I am happy to add release notes. How do I go about doing that?
Also, thanks for the suggestion on the restartTriggers

https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#generating-2111-release-notes

Can you also add
diff --git a/pkgs/servers/tt-rss/default.nix b/pkgs/servers/tt-rss/default.nix
index bd82f8d2890..61ec3eca824 100644
--- a/pkgs/servers/tt-rss/default.nix
+++ b/pkgs/servers/tt-rss/default.nix
@@ -2,7 +2,11 @@

 stdenv.mkDerivation rec {
   pname = "tt-rss";
-  version = "2021-06-21";
+  /* date of the commit ${rev} */
+  year = "21";
+  month = "06";
+  day = "21";
+  version = "20${year}-${month}-${day}";
   rev = "cd26dbe64c9b14418f0b2d826a38a35c6bf8a270";

   src = fetchurl {
@@ -13,6 +17,8 @@ stdenv.mkDerivation rec {
   installPhase = ''
     mkdir $out
     cp -ra * $out/
+    # see the code of Config::get_version(). you can check that the version in the footer of the preferences pages is not UNKNOWN
+    echo "${year}.${month}" > $out/version_static.txt
   '';

   meta = with lib; {

otherwise tt-rss reports the wrong version to plugins, which then may fail.
It's not directly related to your PR, if you don't want to include that I'll make a PR later.

ping @milogert

@symphorien Sorry! I had some life stuff come up (moving across country). I made the changes you requested, but I merged in master, so I think it accidentally over-requested reviews from a bunch of people :grimacing:

Thanks!
I think we are getting close, I'm going to deploy this to test it.

Thanks for your work!

if you did an upgrade, maybe you need to run a schema upgrade ?
is systemctl status tt-rss.service happy?


Invalid value for "default" parameter: the default value must have the same type as the map elements

After upgrading to TF 14.4, I'm getting this error:
Error: Invalid function argument

  on .terraform/modules/private_alb/main.tf line 409, in resource "aws_lb_listener" "frontend_https":
 409:         for_each = length(keys(lookup(default_action.value, "authenticate_cognito", {}))) == 0 ? [] : [lookup(default_action.value, "authenticate_cognito", {})]

Invalid value for "default" parameter: the default value must have the same
type as the map elements.

After a few tries, I found that this can be bypassed with:
      dynamic "redirect" {
        for_each = length(keys(try(lookup(default_action.value, "redirect", {}), {}))) == 0 ? [] : [lookup(default_action.value, "redirect", {})]

although ugly, it works.
=> is someone able to either fix it properly, or implement the above at all the places where it fails ?

You are right that wrapping expression with try() can fix a lot of problems but there has to be a better fix.

Which version of Terraform did you use prior to 0.14.4 where things worked well?
Can you please run examples in this module and try to reproduce your issue there?

You are right that wrapping expression with try() can fix a lot of problems but there has to be a better fix.

Which version of Terraform did you use prior to 0.14.4 where things worked well?
Can you please run examples in this module and try to reproduce your issue there?

Sadly, we went from both:
terraform-aws-modules/terraform-aws-alb 5.0.0 to 5.10.0
and terraform 0.13.4 to 0.14.4
So it might not be related to the TF upgrade (ie: it would probably fail on TF13 as well)

Ok ... I just can't reproduce it ! There must be something very specific in our current situation/state that creates this issue.
I'll close this ticket as the module works fine in normal situations.

Thanks for looking at this !

Sadly, we went from both:
terraform-aws-modules/terraform-aws-alb 5.0.0 to 5.10.0
and terraform 0.13.4 to 0.14.4
So it might not be related to the TF upgrade (ie: it would probably fail on TF13 as well)

Ok ... I just can't reproduce it ! There must be something very specific in our current situation/state that creates this issue.
I'll close this ticket as the module works fine in normal situations.

Thanks for looking at this !

Encountered this yesterday when upgrading from 5.2 to latest (using TF 0.12.24 recently upgraded aws provider from 2.x to 3.30). Found it could be resolved by changing the following module argument:
https_listeners = list(map("certificate_arn", var.cert_arn, "port", 443))

to
https_listeners = [{certificate_arn = var.cert_arn, port = 443}]


Tasks retry

WHY are these changes introduced?
We want to replace listr2 with renderTasks everywhere.
WHAT is this pull request doing?
This PR adds retry and skip logic to tasks handled by the Tasks component and replaces uses of listr2 in hydrogen commands.
TODO:

[ ] Add component tests for this new logic
[ ] Remove listr2 completely along with any code related to it (a lot of it inside ui.ts)

How to test your changes?

Run all the hydrogen commands
See the new output

Measuring impact
How do we know this change was effective? Please choose one:

[x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
[ ] Existing analytics will cater for this addition
[ ] PR includes analytics changes to measure impact

Checklist

[x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
[x] I've considered possible documentation changes
[x] I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

@pepicrft We're below 1 second with the removal of listr2! Excited to get this merged :D


Fix javadoc errors

The maven-javadoc-plugin was outputting a lot of errors, so I fixed it.
However, it was difficult to fix the warnings immediately, so I left them as they were. For example, this does NOT include a fix for the @param tag with an empty description. I'd like to leave these fixes to @goneall, if possible.
Also, I updated the maven-javadoc-plugin because it terminated abnormally and failed to compile on my environment, due to MJAVADOC-488

Hmm, it seems there are still errors? I'll take a look.

Thanks @m1kit for cleaning these up.


Version release for elixir 1.4.x warning fixes

Hi,
I have a question regarding the fixes of the warnings that are currently in master branch.
Would love to see a versions release for these so that we can rid of some warnings in our project.
Do you have any date in mind when this could be possible?
Cheers,
Ingo

Just setting up a new laptop, I'll try to get this out this week.

Released 3.0.0! 🤘 🎉

Thank you very much for your efforts!