HDFS-16791 WIP - client protocol and Filesystem apis implemented and …

…building.
Tests for Distributed Filesystem, view filesystem and RBF

Description of PR
How was this patch tested?
hadoop-hdfs % mvn test -Dtest="TestViewFileSystemHdfs"
hadoop-hdfs-rbf % mvn test -Dtest="TestRouterMountTable"
hadoop-hdfs % mvn test -Dtest="TestEnclosingRoot"
hadoop-common-project % mvn test -Dtest="TestHarFileSystem"
hadoop-hdfs-project % mvn test -Dtest="TestReadOnly"
hadoop-hdfs-project % mvn test -Dtest="TestDistributedFileSystem"
For code changes:

[ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
[ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 51s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 30s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 50s

trunk passed

+1 :green_heart:
compile
25m  8s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
21m 32s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m  0s

trunk passed

+1 :green_heart:
mvnsite
5m  7s

trunk passed

+1 :green_heart:
javadoc
3m 49s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
4m  9s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
10m 26s

trunk passed

+1 :green_heart:
shadedclient
24m 18s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 21s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 39s

the patch passed

+1 :green_heart:
compile
24m 29s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
cc
24m 29s

the patch passed

-1 :x:
javac
24m 29s
/results-compile-javac-root-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt
root-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 1 new + 2835 unchanged - 0 fixed = 2836 total (was 2835)

+1 :green_heart:
compile
21m 39s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
cc
21m 39s

the patch passed

-1 :x:
javac
21m 39s
/results-compile-javac-root-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt
root-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07 generated 1 new + 2632 unchanged - 0 fixed = 2633 total (was 2632)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 50s
/results-checkstyle-root.txt
root: The patch generated 27 new + 437 unchanged - 13 fixed = 464 total (was 450)

+1 :green_heart:
mvnsite
5m  4s

the patch passed

-1 :x:
javadoc
0m 59s
/results-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt
hadoop-common-project_hadoop-common-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 3 new + 0 unchanged - 0 fixed = 3 total (was 0)

+1 :green_heart:
javadoc
4m 10s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
10m 53s

the patch passed

+1 :green_heart:
shadedclient
23m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
18m  7s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 30s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
359m 41s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

-1 :x:
unit
1m  8s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch failed.

-1 :x:
asflicense
1m  1s
/results-asflicense.txt
The patch generated 1 ASF License warnings.

631m 12s

Reason
Tests

Failed junit tests
hadoop.fs.TestHarFileSystem

hadoop.hdfs.server.namenode.ha.TestObserverNode

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4967

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets cc buflint bufcompat

uname
Linux 9b89081cb798 4.15.0-192-generic #203-Ubuntu SMP Wed Aug 10 17:40:03 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 8f877582830040a90d88059592219de8c2b8be43

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/1/testReport/

Max. process+thread count
3137 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

I was expecting [TestHarFileSystem.testInheritedMethodsImplemented fail. look at the javadocs of FileSystem for the full TODO list of any changes there.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m  8s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
28m 27s

trunk passed

+1 :green_heart:
compile
25m  4s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
21m 25s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m  0s

trunk passed

+1 :green_heart:
mvnsite
5m  6s

trunk passed

+1 :green_heart:
javadoc
3m 50s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
4m 15s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
10m 18s

trunk passed

+1 :green_heart:
shadedclient
23m 51s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 41s

the patch passed

+1 :green_heart:
compile
24m 18s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
cc
24m 18s

the patch passed

+1 :green_heart:
javac
24m 18s

the patch passed

+1 :green_heart:
compile
21m 29s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
cc
21m 29s

the patch passed

+1 :green_heart:
javac
21m 29s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 8 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
4m 26s
/results-checkstyle-root.txt
root: The patch generated 32 new + 555 unchanged - 13 fixed = 587 total (was 568)

+1 :green_heart:
mvnsite
5m 10s

the patch passed

-1 :x:
javadoc
1m  0s
/results-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt
hadoop-common-project_hadoop-common-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
javadoc
4m  8s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

-1 :x:
spotbugs
1m 39s
/new-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.html
hadoop-hdfs-project/hadoop-hdfs-rbf generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
shadedclient
24m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m  6s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 32s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
350m 35s

hadoop-hdfs in the patch passed.

-1 :x:
unit
34m 49s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
1m  1s

The patch does not generate ASF License warnings.

655m 47s

Reason
Tests

SpotBugs
module:hadoop-hdfs-project/hadoop-hdfs-rbf

Redundant nullcheck of zonePath, which is known to be non-null in org.apache.hadoop.hdfs.server.federation.router.RouterClientProtocol.getEnclosingRoot(String)  Redundant null check at RouterClientProtocol.java:is known to be non-null in org.apache.hadoop.hdfs.server.federation.router.RouterClientProtocol.getEnclosingRoot(String)  Redundant null check at RouterClientProtocol.java:[line 1964]

Failed junit tests
hadoop.hdfs.server.federation.router.TestRouterMountTable

hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4967

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint cc buflint bufcompat

uname
Linux 274fc1403c17 4.15.0-192-generic #203-Ubuntu SMP Wed Aug 10 17:40:03 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 536fe802e41f0e1b8fc4f4b26b6d98268b534909

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/2/testReport/

Max. process+thread count
3857 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 41s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 6 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m 17s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m  0s

trunk passed

+1 :green_heart:
compile
23m 17s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
20m 50s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
4m  8s

trunk passed

+1 :green_heart:
mvnsite
6m 52s

trunk passed

+1 :green_heart:
javadoc
5m 15s

trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
6m  4s

trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
11m 22s

trunk passed

+1 :green_heart:
shadedclient
22m 19s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  2s

the patch passed

+1 :green_heart:
compile
22m 33s

the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
cc
22m 33s

the patch passed

+1 :green_heart:
javac
22m 33s

the patch passed

+1 :green_heart:
compile
20m 57s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
cc
20m 57s

the patch passed

+1 :green_heart:
javac
20m 57s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 14 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
4m 14s
/results-checkstyle-root.txt
root: The patch generated 34 new + 554 unchanged - 13 fixed = 588 total (was 567)

+1 :green_heart:
mvnsite
6m 48s

the patch passed

-1 :x:
javadoc
1m 23s
/results-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt
hadoop-common-project_hadoop-common-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
javadoc
5m 44s

the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
12m 13s

the patch passed

+1 :green_heart:
shadedclient
22m 31s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
19m  2s

hadoop-common in the patch passed.

+1 :green_heart:
unit
3m  1s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
239m 28s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
24m 44s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
1m 40s

The patch does not generate ASF License warnings.

540m  8s

Reason
Tests

Failed junit tests
hadoop.fs.viewfs.TestViewFileSystemHdfs

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4967

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint cc buflint bufcompat

uname
Linux bd49dea6833d 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f1b29f755be9be2cd1d83f95cab172f99d18616a

Default Java
Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/3/testReport/

Max. process+thread count
3787 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran I can't comment on your long comment above,

Looking at the specification, I'm not sure that getRootPath() is the right name, given that the root dir is "/" everywhere -and very special (you can delete it and it is still there afterwards). (it defined in model.md)
What about getMountRoot(), as that is clearer at what it is.

The current name being proposed is getEnclosingRoot which I do think is more generic since its not just mount roots.
As for the tests you listed, I have all of them somewhere except for

wrapped invocation is unchanged.
I will work on this. I'm still not clear where all you want all these tests replicated to.

For the below, im not sure what you are referring to. I see AbstractFSContract but that seems pretty bare, im not sure if thats what you are referring to or something else.

for all tests of the specification which are expected to be met by all filesystems -not just hdfs/viewfs- we need a contract test subclass of AbstractFSC

I see AbstractFSContract but that seems pretty bare, im not sure if thats what you are referring to or something else.

look at all the subclasses of AbstractFSContractTestBase ... they are the main test suites implemented by all the connectors with the docs and hdfs the reference implementation

I see AbstractFSContract but that seems pretty bare, im not sure if thats what you are referring to or something else.

look at all the subclasses of AbstractFSContractTestBase ... they are the main test suites implemented by all the connectors with the docs and hdfs the reference implementation

@steveloughran I think I found it. I just updated the PR with the contract tests. It looks pretty comparable to other contract test suites. lmk if there is still something missing.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 11 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m  1s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 17s

trunk passed

+1 :green_heart:
compile
23m  8s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
20m 26s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
3m 48s

trunk passed

+1 :green_heart:
mvnsite
5m 29s

trunk passed

-1 :x:
javadoc
1m 13s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
4m 44s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
10m 18s

trunk passed

+1 :green_heart:
shadedclient
24m 31s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  5s

the patch passed

+1 :green_heart:
compile
22m 30s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
cc
22m 30s

the patch passed

-1 :x:
javac
22m 30s
/results-compile-javac-root-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
root-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 generated 8 new + 2821 unchanged - 0 fixed = 2829 total (was 2821)

+1 :green_heart:
compile
20m 26s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
cc
20m 26s

the patch passed

-1 :x:
javac
20m 26s
/results-compile-javac-root-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt
root-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08 with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08 generated 8 new + 2621 unchanged - 0 fixed = 2629 total (was 2621)

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 11 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
3m 38s
/results-checkstyle-root.txt
root: The patch generated 33 new + 707 unchanged - 15 fixed = 740 total (was 722)

+1 :green_heart:
mvnsite
5m 28s

the patch passed

-1 :x:
javadoc
1m  4s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
4m 41s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
10m 47s

the patch passed

+1 :green_heart:
shadedclient
24m 29s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
18m 19s
/patch-unit-hadoop-common-project_hadoop-common.txt
hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 43s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
312m 48s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
34m 53s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
1m 15s

The patch does not generate ASF License warnings.

618m 39s

Reason
Tests

Failed junit tests
hadoop.fs.TestFilterFs

hadoop.hdfs.TestLeaseRecovery2

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4967

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint cc buflint bufcompat

uname
Linux 6018d0a8001e 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5d2a96c3728350b4692717ece04e3c0f2d610014

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/6/testReport/

Max. process+thread count
3472 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 37s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 11 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 18s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
30m 48s

trunk passed

+1 :green_heart:
compile
23m  7s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
20m 32s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
3m 51s

trunk passed

+1 :green_heart:
mvnsite
5m 30s

trunk passed

-1 :x:
javadoc
1m 13s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
4m 43s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
10m 16s

trunk passed

+1 :green_heart:
shadedclient
24m 23s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  4s

the patch passed

+1 :green_heart:
compile
22m 21s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
cc
22m 21s

the patch passed

+1 :green_heart:
javac
22m 21s

the patch passed

+1 :green_heart:
compile
20m 23s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
cc
20m 23s

the patch passed

+1 :green_heart:
javac
20m 23s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 11 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
3m 43s
/results-checkstyle-root.txt
root: The patch generated 34 new + 720 unchanged - 16 fixed = 754 total (was 736)

+1 :green_heart:
mvnsite
5m 32s

the patch passed

-1 :x:
javadoc
1m  5s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
4m 40s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
10m 53s

the patch passed

+1 :green_heart:
shadedclient
24m 32s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 16s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 44s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
246m 48s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

-1 :x:
unit
16m  7s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+0 :ok:
asflicense
0m 49s

ASF License check generated no output?

533m  7s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.server.namenode.TestProcessCorruptBlocks

hadoop.hdfs.server.namenode.TestLargeDirectoryDelete

hadoop.hdfs.server.namenode.ha.TestPipelinesFailover

hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA

hadoop.hdfs.server.namenode.TestFileLimit

hadoop.hdfs.server.namenode.ha.TestFailoverWithBlockTokensEnabled

hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints

hadoop.fs.contract.router.TestRouterHDFSContractRootDirectorySecure

hadoop.fs.contract.router.TestRouterHDFSContractMkdir

hadoop.fs.contract.router.TestRouterHDFSContractRootDirectory

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4967

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint cc buflint bufcompat

uname
Linux ac8aebbd4635 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1e13b70fd3881cde6e2358089c7fd046cf2ea291

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/7/testReport/

Max. process+thread count
3369 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 40s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 11 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 16s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
30m 46s

trunk passed

+1 :green_heart:
compile
23m 10s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
20m 27s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
3m 50s

trunk passed

+1 :green_heart:
mvnsite
5m 34s

trunk passed

-1 :x:
javadoc
1m 14s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
4m 49s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
10m 19s

trunk passed

+1 :green_heart:
shadedclient
24m 26s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  5s

the patch passed

+1 :green_heart:
compile
22m 33s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
cc
22m 33s

the patch passed

+1 :green_heart:
javac
22m 33s

the patch passed

+1 :green_heart:
compile
20m 38s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
cc
20m 38s

the patch passed

+1 :green_heart:
javac
20m 38s

the patch passed

-1 :x:
blanks
0m  0s
/blanks-eol.txt
The patch has 5 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
3m 46s
/results-checkstyle-root.txt
root: The patch generated 18 new + 720 unchanged - 16 fixed = 738 total (was 736)

+1 :green_heart:
mvnsite
5m 29s

the patch passed

-1 :x:
javadoc
1m  5s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
4m 41s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
10m 52s

the patch passed

+1 :green_heart:
shadedclient
24m 40s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 26s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 44s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
285m 43s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

-1 :x:
unit
1m 20s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch failed.

+1 :green_heart:
asflicense
1m 15s

The patch does not generate ASF License warnings.

558m 20s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestLeaseRecovery2

hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4967

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint cc buflint bufcompat

uname
Linux a04bbe296bc1 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 5865dad5d662ba2e73b6e72aaf4edb2bf13fb4a2

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/8/testReport/

Max. process+thread count
3283 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran as I commented before, I added all the contract tests I could find that made sense. Some level of functionality couldn't practically be tested in the contract tests because they require some idea of mount points or encyrption zones.
As far as the build failures go...

The error blanks is legit and I will fix at the end (issue w/ my editor and formatting for other repos)
The other 4 failures seem unrelated to my changes as far as I can tell. I scanned through them and didn't see anything that looked like it would be related. I am assuming these regularly fail, can you confirm this assumption.

Let me know if there is anything else missing.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+0 :ok:
buf
0m  1s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 11 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 43s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
31m 11s

trunk passed

+1 :green_heart:
compile
23m  9s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
20m 31s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
3m 52s

trunk passed

+1 :green_heart:
mvnsite
5m 34s

trunk passed

-1 :x:
javadoc
1m 13s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
4m 40s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
10m 14s

trunk passed

+1 :green_heart:
shadedclient
24m 33s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  5s

the patch passed

+1 :green_heart:
compile
22m 33s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
cc
22m 33s

the patch passed

+1 :green_heart:
javac
22m 33s

the patch passed

+1 :green_heart:
compile
20m 27s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
cc
20m 27s

the patch passed

+1 :green_heart:
javac
20m 27s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 46s
/results-checkstyle-root.txt
root: The patch generated 18 new + 720 unchanged - 16 fixed = 738 total (was 736)

+1 :green_heart:
mvnsite
5m 34s

the patch passed

-1 :x:
javadoc
1m  5s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
4m 40s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
10m 52s

the patch passed

+1 :green_heart:
shadedclient
24m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 15s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 42s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
296m 14s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
22m 49s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
1m 17s

The patch does not generate ASF License warnings.

590m 46s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestLeaseRecovery2

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4967

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint cc buflint bufcompat

uname
Linux 626e4d9f0811 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 3e233fc62cdd9fe799128b9d481e0a61231a109d

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/9/testReport/

Max. process+thread count
2972 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 11 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 12s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
30m 48s

trunk passed

+1 :green_heart:
compile
23m 12s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
20m 35s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
4m 14s

trunk passed

+1 :green_heart:
mvnsite
5m 39s

trunk passed

-1 :x:
javadoc
1m 15s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
4m 43s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
10m 20s

trunk passed

+1 :green_heart:
shadedclient
23m 54s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  6s

the patch passed

+1 :green_heart:
compile
22m 25s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
cc
22m 25s

the patch passed

+1 :green_heart:
javac
22m 25s

the patch passed

+1 :green_heart:
compile
20m 30s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
cc
20m 30s

the patch passed

+1 :green_heart:
javac
20m 30s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 40s
/results-checkstyle-root.txt
root: The patch generated 20 new + 736 unchanged - 0 fixed = 756 total (was 736)

+1 :green_heart:
mvnsite
5m 30s

the patch passed

-1 :x:
javadoc
1m  5s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
4m 44s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
10m 56s

the patch passed

+1 :green_heart:
shadedclient
24m 36s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 25s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 43s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
292m  0s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
34m 56s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
1m 12s

The patch does not generate ASF License warnings.

597m 48s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestLeaseRecovery2

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4967

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint cc buflint bufcompat

uname
Linux 8ea2dc8bbf68 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / b6382b0010a53a38b4c5aa29a1fec95fd5c8a1ba

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/10/testReport/

Max. process+thread count
3100 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
16m 42s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 11 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 21s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
34m  4s

trunk passed

+1 :green_heart:
compile
25m 10s

trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
compile
21m 44s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
checkstyle
4m  8s

trunk passed

+1 :green_heart:
mvnsite
5m  6s

trunk passed

-1 :x:
javadoc
1m  8s
/branch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in trunk failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
4m  8s

trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
10m 26s

trunk passed

+1 :green_heart:
shadedclient
26m 51s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
4m  8s

the patch passed

+1 :green_heart:
compile
24m 36s

the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04

+1 :green_heart:
cc
24m 36s

the patch passed

+1 :green_heart:
javac
24m 36s

the patch passed

+1 :green_heart:
compile
21m 40s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
cc
21m 40s

the patch passed

+1 :green_heart:
javac
21m 40s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
3m 59s
/results-checkstyle-root.txt
root: The patch generated 20 new + 737 unchanged - 0 fixed = 757 total (was 737)

+1 :green_heart:
mvnsite
5m  7s

the patch passed

-1 :x:
javadoc
1m  0s
/patch-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt
hadoop-common in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.

+1 :green_heart:
javadoc
4m  8s

the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08

+1 :green_heart:
spotbugs
10m 58s

the patch passed

+1 :green_heart:
shadedclient
27m 38s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
18m 31s

hadoop-common in the patch passed.

+1 :green_heart:
unit
2m 31s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
389m 18s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

-1 :x:
unit
34m 54s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
1m  3s

The patch does not generate ASF License warnings.

723m 22s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestLeaseRecovery2

hadoop.hdfs.server.federation.router.TestRouterRPCMultipleDestinationMountTableResolver

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4967

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint cc buflint bufcompat

uname
Linux c667c49cada9 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 447d2179a1ff502130fdedd9f6f192b580c81e09

Default Java
Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/11/testReport/

Max. process+thread count
2397 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Could you fix the new checkstyle issues: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/11/artifact/out/results-checkstyle-root.txt

Javadoc issues are beginning worked on in the following two PRs.
https://github.com/apache/hadoop/pull/5344
https://github.com/apache/hadoop/pull/5226

@steveloughran It seems like you are no longer reviewing, but just pinging in case you are.
@simbadzina @goiri Could you please help review this or take others that could help review?

Also just an FYI I am planning to open a new PR. I tried rebasing, but it took a very long time given the number of commits that have stacked up. I am going to just apply the diff on top of branch-3.3 and open a new PR, I will link this one to keep all the context. Happy to address additional PR comments here before doing that though

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 25s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 11 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
15m 48s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m  1s

trunk passed

+1 :green_heart:
compile
9m 53s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
8m 49s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
2m 30s

trunk passed

+1 :green_heart:
mvnsite
3m 58s

trunk passed

+1 :green_heart:
javadoc
3m 29s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
3m 33s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
6m 43s

trunk passed

+1 :green_heart:
shadedclient
21m 23s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m 44s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

-1 :x:
mvninstall
0m 29s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt
hadoop-hdfs-client in the patch failed.

-1 :x:
mvninstall
0m 30s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
mvninstall
0m 21s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch failed.

-1 :x:
compile
1m 13s
/patch-compile-root-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
root in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
cc
1m 13s
/patch-compile-root-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
root in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
javac
1m 13s
/patch-compile-root-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
root in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
compile
1m  2s
/patch-compile-root-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
root in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

-1 :x:
cc
1m  2s
/patch-compile-root-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
root in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

-1 :x:
javac
1m  2s
/patch-compile-root-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
root in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
2m  8s
/results-checkstyle-root.txt
root: The patch generated 22 new + 735 unchanged - 0 fixed = 757 total (was 735)

-1 :x:
mvnsite
0m 33s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt
hadoop-hdfs-client in the patch failed.

-1 :x:
mvnsite
0m 33s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
mvnsite
0m 23s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch failed.

-1 :x:
javadoc
0m 35s
/results-javadoc-javadoc-hadoop-common-project_hadoop-common-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-common-project_hadoop-common-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

-1 :x:
javadoc
0m 27s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
javadoc
1m  5s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05 with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 generated 4 new + 1 unchanged - 0 fixed = 5 total (was 1)

-1 :x:
spotbugs
0m 32s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt
hadoop-hdfs-client in the patch failed.

-1 :x:
spotbugs
0m 30s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
spotbugs
0m 23s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch failed.

-1 :x:
shadedclient
4m 34s

patch has errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
16m  9s

hadoop-common in the patch passed.

-1 :x:
unit
0m 33s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client.txt
hadoop-hdfs-client in the patch failed.

-1 :x:
unit
0m 34s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
unit
0m 23s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch failed.

+1 :green_heart:
asflicense
0m 26s

The patch does not generate ASF License warnings.

139m  4s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/12/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4967

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint cc buflint bufcompat

uname
Linux c3e4cb55f54d 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 7f7bdbd5e7ee477e625c9818c1e97d8e5e169bd1

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/12/testReport/

Max. process+thread count
3159 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/12/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 27s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+0 :ok:
buf
0m  0s

buf was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 11 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
16m  9s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 17s

trunk passed

+1 :green_heart:
compile
9m 44s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
8m 59s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
checkstyle
2m 30s

trunk passed

+1 :green_heart:
mvnsite
3m 58s

trunk passed

+1 :green_heart:
javadoc
3m 31s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
3m 35s

trunk passed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

+1 :green_heart:
spotbugs
6m 41s

trunk passed

+1 :green_heart:
shadedclient
21m 27s

branch has no errors when building and testing our client artifacts.

-0 :warning:
patch
21m 48s

Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 26s

Maven dependency ordering for patch

-1 :x:
mvninstall
0m 29s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-client.txt
hadoop-hdfs-client in the patch failed.

-1 :x:
mvninstall
0m 29s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
mvninstall
0m 20s
/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch failed.

-1 :x:
compile
1m  9s
/patch-compile-root-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
root in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
cc
1m 10s
/patch-compile-root-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
root in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
javac
1m  9s
/patch-compile-root-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
root in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
compile
1m  3s
/patch-compile-root-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
root in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

-1 :x:
cc
1m  3s
/patch-compile-root-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
root in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

-1 :x:
javac
1m  3s
/patch-compile-root-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
root in the patch failed with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
2m  5s
/results-checkstyle-root.txt
root: The patch generated 22 new + 735 unchanged - 0 fixed = 757 total (was 735)

-1 :x:
mvnsite
0m 33s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-client.txt
hadoop-hdfs-client in the patch failed.

-1 :x:
mvnsite
0m 33s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
mvnsite
0m 23s
/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch failed.

-1 :x:
javadoc
0m 27s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04.

-1 :x:
javadoc
1m  4s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05.txt
hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_382-8u382-ga-1~20.04.1-b05 with JDK Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05 generated 4 new + 1 unchanged - 0 fixed = 5 total (was 1)

-1 :x:
spotbugs
0m 32s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-client.txt
hadoop-hdfs-client in the patch failed.

-1 :x:
spotbugs
0m 31s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
spotbugs
0m 23s
/patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch failed.

-1 :x:
shadedclient
4m 40s

patch has errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
16m  5s

hadoop-common in the patch passed.

-1 :x:
unit
0m 33s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client.txt
hadoop-hdfs-client in the patch failed.

-1 :x:
unit
0m 32s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch failed.

-1 :x:
unit
0m 23s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch failed.

+1 :green_heart:
asflicense
0m 27s

The patch does not generate ASF License warnings.

139m 24s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/13/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4967

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets markdownlint cc buflint bufcompat

uname
Linux b56ae302b4fe 4.15.0-212-generic #223-Ubuntu SMP Tue May 23 13:09:22 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 63adc737846793ec2050324cb19f9f768a564202

Default Java
Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_382-8u382-ga-1~20.04.1-b05

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/13/testReport/

Max. process+thread count
1276 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4967/13/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Closing because https://github.com/apache/hadoop/pull/6198#pullrequestreview-1712503495 got merged


Use padding in atom components instead of margin

Components should not have styles that define how the component be displayed in parent components, like margin.
Referable article: https://zenn.dev/seya/articles/09545c7503baa4

I agree with you 👍
Recently I heard that not only atoms but also any component should not have a margin.
cf(Japanese article): https://qiita.com/otsukayuhi/items/d88b5158745f700be534

Enlightening...!

Thank you!!!


Split Official Resources

In this Pull Request, I split the Official Resources of GitHub Actions and add new sections.
@gep13
Sorry for skipping an issue opening. But I'm sure we need this change.
@imbsky
This pull request includes your commit on #243. After merging this branch into the master branch, you will join the contributors.

Well, I have no strong purpose to add cache action. Cause I thought the action of the actions team was listed in Collection of Actions section.

@peaceiris thank you for taking the time to do this!  Looks great!


Resolves Backport/backport 2762 to 2.4

Checklist

[X] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Closed; duplicate PR


Sync position with dlc channel state

Due to an error I am having an open position but a closed dlc. It would be great if the app would be smart enough to sync these states, while the DLC is the source of truth.
if DLC is in SubChannelState::Signed: Create position (take data from order) if not existing
if DLC is in SubChannelState::OffChainClosed: Delete position if still existing
would have been useful for https://github.com/get10101/10101/issues/1257

would have been useful for https://github.com/get10101/10101/issues/1257

Note this will also help if the channel got force closed.

Please add a MASSIVE TODO that this is not the right way to do it.


lual_loadstring

Hi, I'm trying to run a string but the print doesn't show up, i just see "yes" in my console
unsafe {
    let code = lua.load_string( lua_string!( "print('zozz')" ) );

    match code {
        Ok( _ ) => println!( "yes" ),
        Err( _ ) => println!( "no" ),
    };
};

Check lual_loadstring docs: https://pgl.yoyo.org/luai/i/luaL_loadstring
It does not run the code, but pushes it to the stack as a function, you need to call it
Most functions in this crate are just direct calls to the Lua C API


Cannot get class 'SVGTexture2D'. Godot 4.2.1

Somehow I'm getting an error where it can't find this class...
**  Cannot get class 'SVGTexture2D'.**
Been looking around for anything related to tools and resources but I'm just coming up milhouse. :(
Whats interesting is the tool seems to work "fine"... Somehow GODOT keeps throwing these errors for every SVG Imported using SVGTexture2D.

De alguma forma, estou recebendo um erro onde não é possível encontrar esta classe...
** Não é possível obter a classe 'SVGTexture2D'.**
Tenho procurado por qualquer coisa relacionada a ferramentas e recursos, mas só agora estou encontrando Milhouse. :(
O interessante é que a ferramenta parece funcionar "bem"... De alguma forma, o GODOT continua gerando esses erros para cada SVG importado usando SVGTexture2D.

I’m encountering the same alerts. I’m looking into the source, but nothing seems to fix it. The functionality seems to be normal.

Somehow I'm getting an error where it can't find this class...
** Cannot get class 'SVGTexture2D'.**
Been looking around for anything related to tools and resources but I'm just coming up milhouse. :(
Whats interesting is the tool seems to work "fine"... Somehow GODOT keeps throwing these errors for every SVG Imported using SVGTexture2D.

I’m encountering the same alerts. I’m looking into the source, but nothing seems to fix it. The functionality seems to be normal.


What do I wrong when I can´t compose Docker in my Terminal?

:hand: ERROR with Docker by command "docker-compose up --build" in Terminal
What do I wrong when I can´t compose Docker in my Terminal?

I can´t help myself because sometimes it works but sometimes not.
I´m new to coding and bought Nick Janetakis course "build-a-saas-app-with-flask"
But sometimes when I try to use this command -->docker-compose up --build
I get this ERROR:
ERROR:
Can't find a suitable configuration file in this directory or any
parent. Are you in the right directory?
    Supported filenames: docker-compose.yml, docker-compose.yaml

But why?
That is the DockerBug report code:
36322EA6-F00F-4E81-B1C5-47F0C376A059/20191228181745
Maybe somebody can explain me why:)

Can you check our latest docker documentation and re-open the issue if still it happens
https://docs.ohif.org/deployment/docker


Bugfix/bicep settings

Pull Request Contents

🦋 Bug Fix

Description

Correct the connection string key in the main bicep file, so the deployed app can access the database.
Related Issues or other material

[X] This PR relates to one or more issues, detailed below

Related Issue #61
Closes #61

Screenshots, example outputs/behaviour etc.

✅ Added/updated tests?

[ ] This PR contains relevant tests

Or doesn't need to per the below explanation

[X] I've completed all actions and tasks detailed in the PR Template

Messed up the git history woops.


got exception "authorization required" and "invalid request url"

I have done all of the configurations followed by the instruction. However, I still got the exceptions when running the sample code under VS2015. It still keep asking me to re-login in when I was ready logged in.

i have solved the problem

please tell us how.


Some Markdown Code isn't correctly displayed on website

For example: https://www.markdownguide.org/extended-syntax/#strikethrough
Maybe it's a problem by HTML formatting?

 I'm not seeing anything out of the ordinary on my end.

Okay, right now it looks good to me. Maybe a problem with rendering on the browser. I close this issue


Update async dependency

The version included in sails is too old, it lacks some functionality like async.retry etc.

This build has failed because https://github.com/caolan/async/issues/695

@boogerlad Thanks for the info. I changed the dependency to v0.9.0 and it passed the test.
async and lodash are exposed as a global variable so I think it's necessary to provide developers with up to date library, otherwise sometimes it's a bit annoying that something will break just because the library is too old and not consistent with the current documentation

@boogerlad thanks for the catch

it's a bit confusing that something will break just because the library is too old and not consistent with the current documentation

@andyhu agreed!  The async and _ globals are really just there for convenience but it is absolutely pretty weird if they are tangibly different.  Thanks for sending this :+1:

@andyhu would you mind taking responsibility for keeping an eye on the async dep for the project in the future?  (also feel free to hit me up at @mikermcneil as well if I miss your pr next time)

@mikermcneil Sure, will do that with pleasure :)


show details for match

it is not possible to see details for a match. It is currently unclear how this should be realized UX-wise.

removed label bug and added label enhancement

details of a match are automatically shown since the ui-refactoring -> no longer relevant


F# Type Provider for SAS

Added support for compressed files and files with big endianness. Type provider also added.

Awesome thanks! I'll try it out asap (when I'm no longer bogged down in corporate social calls -_-) !

HI, sily question probably but I;m a noob to Git, how do i get to test this code?

You can currently get it from @arestenko's repository: https://github.com/arestenko/FSharp.Data.Toolbox (Click "Download ZIP" on the right and build it).

Somehow, I missed the Github notification about this - sorry :-).
This sounds pretty AMAZING! I'll have a look at the code and see if I have any feedback. It would be awesome if you could add a quick introduction and an example to the documentation. You can just copy the file with Twitter sample and follow the formatting used there.
One minor tweak (I'm happy to do this myself though) is to use Paket to reference the ProvidedTypes.fs and ProvidedTypes.fsi. This way we do not have to include them in the project and we'll always get the latest version. See how the R provider does this.
Aside from that, are there any major issues left? If no, I would definitely merge this & release it, so that others can play with this!

@tpetricek, thanks for the links Tomas. I'll look into fixing the docs and references early next week.

Hi Arestenko, Been going through the code looks really good! The endianness was really messing with me.
Can you give me a quick code sample on how to use the SasProvider? I can;t seem to get my head aorund that. SasFile works but the cherry would obviously be strongly typed access to the columns.
The I'l start testing this to see if I can find any glitches.

@gjvdkamp you're right, type provider wouldn't make much sense without typed access to columns. It's added now. Please see SasTypeProviderTest.fsx for a small example.
I'm yet to add proper documentation.

Hi arestenko, I 'm starting to get how it works, really cool! Will play with it when I have some more time. Few remarks if you want to beat me to it:

Each column now is still the Value discriminated union instead of the (option of) underlying type.
Good idea on the option to deal with null
I'll profile this against the orignal 'non-provider' type generator, I really wrote that with perf in mind to read entire pages and cast to types in one go (Sas.MetaData.fs line 291). Not sure how that would work with an erasing TP though still trying to get my head around those.
really cool would be a SasLib that would get a folder name and generate types for every sasfile in it:
let myLib = new SasLib<"D:\testdata">
myLib.FileOne.Data |> Seq.SumBy (fun d -> d.Var1 * d.Var2)
That would make transitioning for SAS users easier.

Again really cool stuff! I see you're from st. Petersburg, do you know Andrey Sirotkin perhaps? (Long shot :)

@gjvdkamp, thanks for the feedback.
Performance is my priority as well, so please let me know your findings. My tests show that it already works at least not slower than when using "official" ole db drivers.
I had exactly the same idea about SasLib - it's on my to do list.
I'll probably start working on this as soon as I figure out why the build has started failing on Travis.
Sorry, don't know the people you mention. There are 5 mln people in St.Pete, slim chance :).

Okay, I did nothing to fix it but somehow today it builds.
@tpetricek I think it's ready to merge. Please review when you have a chance.

Tomas, let me know if you see any issues.
I can't find an easy way to add SasLib like @gjvdkamp
https://github.com/gjvdkamp suggested; seems it calls for generated Type
Provider and not erased like it is now.
But I think this library can be useful to someone even in the current state.
On Sat, Sep 19, 2015 at 4:39 PM, Tomas Petricek<EMAIL_ADDRESS>wrote:

Somehow, I missed the Github notification about this - sorry :-).
This sounds pretty AMAZING! I'll have a look at the code and see if I have
any feedback. It would be awesome if you could add a quick introduction and
an example to the documentation. You can just copy the file with Twitter
sample
https://github.com/fsprojects/FSharp.Data.Toolbox/blob/master/docs/content/TwitterProvider.fsx
and follow the formatting used there.
One minor tweak (I'm happy to do this myself though) is to use Paket to
reference the ProvidedTypes.fs and ProvidedTypes.fsi. This way we do not
have to include them in the project and we'll always get the latest
version. See how the R provider does this
https://github.com/BlueMountainCapital/FSharpRProvider/blob/master/paket.dependencies#L15
.
Aside from that, are there any major issues left? If no, I would
definitely merge this & release it, so that others can play with this!
—
Reply to this email directly or view it on GitHub
https://github.com/fsprojects/FSharp.Data.Toolbox/pull/31#issuecomment-141668500
.

I finally got back to this, tested it and released it. Really nice work :-) The package is now on NuGet.
I did a few minor tweaks, which you can see here: https://github.com/fsprojects/FSharp.Data.Toolbox/pull/33
I'll tweet about this next week (nobody is reading twitter over the weekend... :-)) to let the world know about it! Thanks a lot for an amazing contribution :+1:

Awesome, thanks Tomas!


cp sets question

💥 Proposal
There is an array of n integers. There are also 2 disjoint sets, A and B, each containing m integers. You like all the integers in set A and dislike all the integers in set B. Your initial happiness is 0. For each i integer in the array, if i e A , you add 1 to your happiness. If i e B, you add -1 to your happiness. Otherwise, your happiness does not change. Output your final happiness at the end.
Input Format
The first line contains integers n and m separated by a space.
The second line contains n integers, the elements of the array.
The third and fourth lines contain m integers, A and B, respectively.

Have you read the Contributing Guidelines on Pull Requests?
Yes

@plazzy99 @siddharth25pandey @Kajol-Kumari @HarshCasper pls assign me this on python :)

I would like to take this in C++

I want to contribute to this. Assign me either in C or C++.

@HarshCasper I would like to do this in Java


Does this codebase require C++11?

I am considering sending a PR for a new feature and I am wondering if I can use C++11 or do we have to be compatible with C++98?  I see that it appears to be set to C++11 in the CMakeLists.txt file, but I wasn't sure if you expect users also to use C++11.  Thanks

The code base is compatible C++98 with some macro/define magic to benefit
from C++11 move semantic if available.
On Sun, 22 Nov 2020, 13:30 David P. Sicilia<EMAIL_ADDRESS>wrote:

I am considering sending a PR for a new feature and I am wondering if I
can use C++11 or do we have to be compatible with C++98? I see that it
appears to be set to C++11 in the CMakeLists.txt file, but I wasn't sure
if you expect users also to use C++11. Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bombela/backward-cpp/issues/195, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABUZDCQF6YIQQ4FVHXCC2DSRF7HNANCNFSM4T6XR3TQ
.

Thanks


python37Packages.croniter: 0.3.36 -> 0.3.37

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python37Packages.croniter is: "croniter provides iteration for datetime object with cron like format"
meta.homepage for python37Packages.croniter is: "https://github.com/kiorky/croniter"
meta.changelog for python37Packages.croniter is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.3.37 with grep in /nix/store/l2nvfn4asysn8llm5hwz60s0yg0ak1ns-python3.7-croniter-0.3.37

directory tree listing: https://gist.github.com/31c3087efdec2e64e4c695d703f24737

du listing: https://gist.github.com/fdbe6addb2f7461809e1b02c2be8efa6

Rebuild report (if merged into master) (click to expand)

44 total rebuild path(s)

11 package rebuild(s)

11 x86_64-linux rebuild(s)
11 i686-linux rebuild(s)
11 x86_64-darwin rebuild(s)
11 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
apache-airflow
python37Packages.apache-airflow
python37Packages.croniter
python37Packages.privacyidea
python37Packages.python-miio
python38Packages.croniter
python38Packages.privacyidea
python38Packages.python-miio
python39Packages.croniter
python39Packages.privacyidea
python39Packages.python-miio

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/l2nvfn4asysn8llm5hwz60s0yg0ak1ns-python3.7-croniter-0.3.37 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python37Packages.croniter https://github.com/r-ryantm/nixpkgs/archive/ee25468a270e100ed6e055f81937559d5d217048.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/l2nvfn4asysn8llm5hwz60s0yg0ak1ns-python3.7-croniter-0.3.37
ls -la /nix/store/l2nvfn4asysn8llm5hwz60s0yg0ak1ns-python3.7-croniter-0.3.37/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

10 packages built:

apache-airflow (python37Packages.apache-airflow)
python37Packages.croniter
python37Packages.privacyidea
python37Packages.python-miio
python38Packages.croniter
python38Packages.privacyidea
python38Packages.python-miio
python39Packages.croniter
python39Packages.privacyidea
python39Packages.python-miio

Maintainer pings
cc @costrouc for testing.

Result of nixpkgs-review pr 108180 1

10 packages built:

apache-airflow (python37Packages.apache-airflow)
python37Packages.croniter
python37Packages.privacyidea
python37Packages.python-miio
python38Packages.croniter
python38Packages.privacyidea
python38Packages.python-miio
python39Packages.croniter
python39Packages.privacyidea
python39Packages.python-miio

Result of nixpkgs-review pr 108180 1

10 packages built:

apache-airflow (python37Packages.apache-airflow)
python37Packages.croniter
python37Packages.privacyidea
python37Packages.python-miio
python38Packages.croniter
python38Packages.privacyidea
python38Packages.python-miio
python39Packages.croniter
python39Packages.privacyidea
python39Packages.python-miio


added firstLineMatch for automatic recognition

added firstLineMatch for automatic recognition of

a yaml header (3 dashes)
a heading (1-5 hashes followed by an optional whitespace and at least one word character)

what does not work:
underlined headers as they're more than one line

Thanks for the PR.
Have you verified that these detections do not conflict with other types of files? Lines starting with a hash+whitespace+text might very well be comments in certain programming languages, for instance.

I actually haven't checked that, if I'm honest.
Could also be (among others?) perl, php, python, ruby, although I'd assume they most commonly start with a shebang.
Background: I usually don't store a file ending with my md files, because I write everything in md, so I thought this might be the easiest way to auto-load the markdown grammar.

And it could be a full YAML file, I suppose (which my editor occasionally actually loads instead of a md grammar).
I suppose this is too much uncertainty for an official pull request then...
Sorry for creating a PR in that case.

Background: I usually don't store a file ending with my md files, because I write everything in md, so I thought this might be the easiest way to auto-load the markdown grammar.

In that case, maybe a personal solution would be better. Atom probably allows to set a default grammar when it can't detect anything else.

I suppose this is too much uncertainty for an official pull request then...

No problem. It's good to figure these things out along the way. Either way, a personal solution would probably suit you best. Good luck with it

Thanks a lot though!
Just realised I had this in my init-script, but with the wrong grammar.


bosh deploy does not upload stemcells or releases that already exist

[#102538198 #102538212]

In CLI 1.3120.0


feat: ⚡ Incorporaten validation related changes from rhoadesj/dev

@davidackerman I think some of these changes were stolen/adapted from your branches?
yeah looks like it!


feature gpt3

I added it as a feature

Or did you decide not to implement that feature

Sorry, don't really have time to implement this feature properly. Thank you for the efforts though!


influxdb 0.9.1 gui 'explore data' broken

i upgraded from 0.9.0 to 0.9.1, and now when i click on the 'explore data' on the databases page, i get a 404 page not found. using the client command line tools etc. are fine.

@yee379 I think this is a caching error. There is no "explore data" feature in the admin UI anymore, nor is there a separate page for the databases.


Deadlock when task outputs are calculated from input configuration

In attempting to refactor the ProGuard plugin to better track all task inputs, I encountered an unexpected deadlock. I've created a small reproducer that shows that this issue will occur whenever calculating the task outputs involves resolving an input Configuration.
Background
In order to track all inputs to the ProGuardTask, it was necessary to build a complete proguard.Configuration instance out of any provided Proguard configuration files as well as any input/output jars configured programmatically in Gradle. I then wrapped this proguard.Configuration instance in a @Nested task property that represents all of the task inputs and outputs. You can see the main part of the refactoring here: https://github.com/Guardsquare/proguard/commit/b5fbefb87cc44d20e10042df7c00cd73cdcf3280.
This worked well in testing, but when trialled in a real-world project a deadlock was seen. This gist shows a thread-dump with the most relevant threads at the time of deadlock.
Expected Behavior
Resolve an input configuration to determine task outputs should be permitted (and succeed), or it should be prohibited and fail. Deadlocks are very difficult to diagnose and debug.
Current Behavior
Gradle will deadlock when attempting to inspect the Task outputs.
Context
This is a true JVM-level deadlock, where 1 thread holds a synchronization lock, and this thread spawns another thread that is blocked waiting on the same lock.
Here's what happens:

DefaultPlanExecutor.executeNextNode locks the ResourceLockCoordinationService while attempting to find the next task to execute.
While this lock is held, DefaultExecutionPlan.selectNext() is called, which iterates over available tasks to see if any can be executed.
Part of determining if a task can be executed involves resolving the output property values. In this case, calculating the output property value involves resolving files for a dependency configuration.
If the dependency configuration resolves to multiple files, we attempt to download these in parallel, in separate threads.
Each thread needs to acquire a worker lease, and to get this lease it needs to use the ResourceLockCoordinationService
The ResourceLockCoordinationService is still locked by the main executeNextNode thread, and deadlock ensues.

Steps to Reproduce
Clone this repository and follow the instructions in README.md: https://github.com/bigdaz/gradle-outputdeadlock

I was why I couldn't get a similar deadlock from an @InputFiles property that resolved a configuration in it's implementation: it turns out that we only unpack the value of outputs when we are selecting the next task to execute. Unpacking of inputs doesn't happen until we actually enter the execution pipeline, and after the ResourceLockCoordinator is released.
So GetOutputFilesVisitor.visitOutputFileProperty ends up calling PropertyValue.getUnprocessedValue(), but GetInputFilesVisitor.visitInputFileProperty does not.

I believe I am running into this in a build at work and need some guidance.
Has there been a design discussion already about how to fix this, leaving only the work to be done (in which case I can help contribute), or does that need to happen?

Out of my curiosity, any update on this issue?

Fixed via https://github.com/gradle/gradle/pull/20141


Link fix

Proposed changes

Describe your changes to communicate to the maintainers why we should accept this pull request.
If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes
Please put an x in the boxes related to your change.

[ ] Bugfix
[ ] New feature or Enhancement
[ ] Others

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the CONTRIBUTING GUIDELINES doc
[ ] I have signed the CLA
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Related issues

Please leave the issue numbers or links related to this PR here.

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you proposed and what alternatives you have considered, etc.

In PULL_REQUEST_TEMPLATE.md  the below link needs to be updated
- [ ] I have signed the [CLA](https://cla-assistant.io/klaytn/klaytn)
add @tantely-klaytn in CODEOWNERS
contracts/LICENSE

Copyright (c) 2019-2021 klaytn-contract Authors
Copyright (c) 2016-2019 zOS Global Limited

needs to changed to
Copyright (c) 2022 Klaytn Developers


Feature request: make object name configurable / enable partitioning

I'd like to request a feature to make an object name configurable and/or the ability to specify partitions. The S3 Connector for Kafka Connect has this feature and it's been enormously useful for pulling specific data out of COS with Cloud SQL, among other uses.

Hi @tsehrer - at the moment the object name is fixed and is built from the topic name, partition number, first record offset, and last record offset. Are you asking for the flexibility to change the order of these fields and their delimiters? Or are you also asking to include other information in the object name (and if so, what? :smile:)

Could you also elaborate a bit more about what you mean by "ability to specify partitions"? Are you looking to only consume from certain partitions within a Kafka topic? Or something else?

@tsehrer Can you elaborate on your requirements? We're happy to evolve this connector but would like to understand your needs clearly before we start making changes.

I'm not sure if this is the same item being requested in this issue, but I came across this repository while searching for a way to take a single Kafka topic and write data to multiple root directories in COS based on the contents of a Kafka message. A sort of partitioning based message contents.
For example, suppose a topic had these messages:
{"messageType":"TypeA", "groupId":"1234", "payload":"P1"}
{"messageType":"TypeA", "groupId":"1234", "payload":"P2"}
{"messageType":"TypeA", "groupId":"9876", "payload":"P3"}
{"messageType":"TypeA", "groupId":"9876", "payload":"P4"}
{"messageType":"TypeB", "groupId":"9876", "payload":"P5"}

I would like the ability to group data on COS split by groupId and messageType (preferably by both, but grouping by one field could also be useful). I would want data to be grouped on COS for TypeA/1234, TypeA/9876, and TypeB/9876.
This sounds similar to the Field Partitioner referenced here: https://docs.confluent.io/current/connect/kafka-connect-s3/index.html. Although, I am not sure if that Field Partitioner allows you to specify multiple fields for partitioning.
If you would like, I could move this to a separate issue. I thought it sounded similar enough to this open issue that I would try here first.

Interesting. When this issue was first raised, I wondered about making object name configurable based on a template. I was thinking of things like: topic name, partition, offset range, and timestamp as values that could be substituted into the template.
It sounds like you would also want the template to include properties of the JSON message payload? These would need to be combined with values that ensured each object is unique (such as partition number and offset range). So you might end up with something like:
TypeA/1234/1/0000000000017805-0000000000017809

Would this kind of naming scheme work for your intended use of the connector?

I will have to think about if partition and offset in the path makes things strange at all. Once data is out of Kafka we do not care about partition or offset (just the fields that were part of the json message).
I suppose we could try ignoring the partition and offset when reading in data from COS.

Some background here: COS doesn't really have the concept of appending to an existing object. So the connector reads records from Kafka, batches them together based on some criteria, and then writes the batch of records into COS as an object. If the connector didn't include something like the offsets, then each successive write to the same object would overwrite whatever was previously in the object.
The unique part of the object name doesn't have to be a range of offsets, but to ensure that the data is written without loss or duplication it needs to be something derived from the Kafka records that make up the batch. For example message timestamps for the first and last messages would probably also be possible.

Gotcha. Thanks for the clarification. I was thinking the example with offsets was stopping at the "folder" before any files would be written out.
In that case, I think partition and offsets/timesets seem like they should work.

From reading through the conversation it seems this has been resolved and should have been closed a long time ago. I will close it shortly. If there are follow up questions please raise a new issue and reference the conversation here. Thanks.


Add Galadriel devnet

Description
Add Galadriel Devnet
Backward compatibility
Yes

I have made the requested change to the logo, and I believe there is now a changeset. So we should be good to go with this merge.


fix: release minor fix and ammend changelog

:tada: This PR is included in version 0.3.3 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 0.3.4 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0-rc.1 :tada:
The release is available on npm package (@rc dist-tag)
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Allow clearing storage and address warmness

Forge (IIUC) executes all the tests in a single transaction. As of now it don't think that it's possible to create a precise gas benchmark in Forge if there's storage or a call involved. If a test requires a storage initialization, the initialization makes the slot warm, which makes its usage lower than if it was in a separate transaction. Also if any contract is deployed, its address is automatically becoming warm, again lowering the gas usage when calling it. The EVM could expose a cheatcode to clear the warmness states allowing the benchmarks to be as expensive as when running in a separate transaction.

Probably a duplicate of https://github.com/foundry-rs/foundry/issues/2429

Closing this as a duplicate of the linked issue + https://github.com/foundry-rs/foundry/issues/1340. This is something that would need to be handled upstream in foundry as opposed to here in forge-std 🙂


fix the definition of error types

Coverage decreased (-0.7%) to 66.192% when pulling a944e503d2287694f40b67ac243318cb050b15fe on error2 into efeec6429a0f9ee6de3a586df56f5b6a3bb44a50 on master.


[Lightgbm] Support saving checkpoints during training

Is your feature request related to a problem? Please describe.
Hi, @imatiach-msft , I'm using mmlspark lightgbm to train a ranking model that costs about 9 to 10 hours on a large dataset. My spark is deployed on yarn, there are several times the training job is failed caused by the lost node on my yarn cluster.
Can mmlspark lightgbm support saving checkpoints during training so that we can continue training next time?
Describe the solution you'd like
A clear and concise description of what you want to happen.
Additional context
Add any other context or screenshots about the feature request here.

@ce39906 I remember I worked on this in the branch:
https://github.com/imatiach-msft/mmlspark/commits/ilmat/save-interm
but I got stuck because I couldn't save the model from a worker node, it could only be saved by spark from the driver.  For me, that's the key part of figuring out how to enable this feature.  I could do something hacky like try to convert the model to a file on one of the worker nodes and then save it, but I wasn't sure what would be the best API to use and how to save it so that it would work on all possible spark environments (eg different clusters like cloudera vs azure databricks vs HDI vs spark standalone/clouds like AWS vs Azure vs Cloudera etc have very different APIs and ways to save files).

Thanks for your reply, I'll take a look.


hangouts: fix mailing list card alignment

@erciccione I do not agree. All pages have the same amount of vertical whitespace between cards except this one, which makes it ugly and annoying.


Cosmos DB Encryption Samples Issue

Section: link.

Reason:

Run createItem() shows: Failed to serialize the object into json.
Suggestion:
Add code in class Pojo
String getSensitiveString() {
        return sensitiveString;
	}

@sandeep-sen , @joshfree , @kyle-patterson , @KrzysztofCwalina and @aayush3011 to notification.

PR https://github.com/Azure/azure-sdk-for-java/pull/38575 has been merged, we will close this issue.


bump httpx dependency version to 0.11.1

Sanitizes several tests to follow the new module structure for httpx. httpx version has been bumped and frozen to 0.11.1 ( #1786, #1792 ).
Previously (in httpx 0.9.3), httpx.Client was used for async http request generation, whose functionality has now been moved to httpx.AsyncClient. Some other inner changes to httpx modules have also been reflected.

LGTM, but I'd like for someone else from @huge-success/sanic-core-devs to review.