Files & Subfolders in the Public folder are noting being served

Current Behavior

I am unable to see files in the public folder when the app is being served or built
Expected Behavior

I should be able to see the files
Steps to Reproduce

steps
1). create nx-plus vue app named frontend
2). try to add any files or subfolders to the public folder
3). serve the app and see that they do not appear
3). build the app and see that they do not appear
angular.json
{   "version": 1,   "projects": {     "backend": {       "projectType": "application",       "schematics": {         "@nrwl/angular:component": {           "style": "scss"         }       },       "root": "apps/backend",       "sourceRoot": "apps/backend/src",       "prefix": "latestmetric-com",       "architect": {         "build": {           "builder": "@angular-devkit/build-angular:browser",           "options": {             "outputPath": "dist/apps/backend",             "index": "apps/backend/src/index.html",             "main": "apps/backend/src/main.ts",             "polyfills": "apps/backend/src/polyfills.ts",             "tsConfig": "apps/backend/tsconfig.app.json",             "aot": true,             "assets": [               "apps/backend/src/favicon.ico",               "apps/backend/src/assets"             ],             "styles": ["apps/backend/src/styles.scss"],             "scripts": []           },           "configurations": {             "production": {               "fileReplacements": [                 {                   "replace": "apps/backend/src/environments/environment.ts",                   "with": "apps/backend/src/environments/environment.prod.ts"                 }               ],               "optimization": true,               "outputHashing": "all",               "sourceMap": false,               "extractCss": true,               "namedChunks": false,               "extractLicenses": true,               "vendorChunk": false,               "buildOptimizer": true,               "budgets": [                 {                   "type": "initial",                   "maximumWarning": "8mb",                   "maximumError": "10mb"                 },                 {                   "type": "anyComponentStyle",                   "maximumWarning": "6kb",                   "maximumError": "10kb"                 }               ]             }           }         },         "serve": {           "builder": "@angular-devkit/build-angular:dev-server",           "options": {             "browserTarget": "backend:build",             "proxyConfig": "apps/backend/proxy.conf.json"           },           "configurations": {             "production": {               "browserTarget": "backend:build:production"             }           }         },         "extract-i18n": {           "builder": "@angular-devkit/build-angular:extract-i18n",           "options": {             "browserTarget": "backend:build"           }         },         "lint": {           "builder": "@angular-devkit/build-angular:tslint",           "options": {             "tsConfig": [               "apps/backend/tsconfig.app.json",               "apps/backend/tsconfig.spec.json"             ],             "exclude": ["**/node_modules/**", "!apps/backend/**"]           }         },         "test": {           "builder": "@nrwl/jest:jest",           "options": {             "jestConfig": "apps/backend/jest.config.js",             "tsConfig": "apps/backend/tsconfig.spec.json",             "passWithNoTests": true,             "setupFile": "apps/backend/src/test-setup.ts"           }         }       }     },     "backend-e2e": {       "root": "apps/backend-e2e",       "sourceRoot": "apps/backend-e2e/src",       "projectType": "application",       "architect": {         "e2e": {           "builder": "@nrwl/cypress:cypress",           "options": {             "cypressConfig": "apps/backend-e2e/cypress.json",             "tsConfig": "apps/backend-e2e/tsconfig.e2e.json",             "devServerTarget": "backend:serve"           },           "configurations": {             "production": {               "devServerTarget": "backend:serve:production"             }           }         },         "lint": {           "builder": "@angular-devkit/build-angular:tslint",           "options": {             "tsConfig": ["apps/backend-e2e/tsconfig.e2e.json"],             "exclude": ["**/node_modules/**", "!apps/backend-e2e/**"]           }         }       }     },     "api-interfaces": {       "root": "libs/api-interfaces",       "sourceRoot": "libs/api-interfaces/src",       "projectType": "library",       "schematics": {},       "architect": {         "lint": {           "builder": "@angular-devkit/build-angular:tslint",           "options": {             "tsConfig": [               "libs/api-interfaces/tsconfig.lib.json",               "libs/api-interfaces/tsconfig.spec.json"             ],             "exclude": ["**/node_modules/**", "!libs/api-interfaces/**"]           }         },         "test": {           "builder": "@nrwl/jest:jest",           "options": {             "jestConfig": "libs/api-interfaces/jest.config.js",             "tsConfig": "libs/api-interfaces/tsconfig.spec.json",             "passWithNoTests": true           }         }       }     },     "graphql": {       "projectType": "library",       "root": "libs/graphql",       "sourceRoot": "libs/graphql/src",       "prefix": "latestmetric-com",       "architect": {         "lint": {           "builder": "@angular-devkit/build-angular:tslint",           "options": {             "tsConfig": [               "libs/graphql/tsconfig.lib.json",               "libs/graphql/tsconfig.spec.json"             ],             "exclude": ["**/node_modules/**", "!libs/graphql/**"]           }         },         "test": {           "builder": "@nrwl/jest:jest",           "options": {             "jestConfig": "libs/graphql/jest.config.js",             "tsConfig": "libs/graphql/tsconfig.spec.json",             "passWithNoTests": true,             "setupFile": "libs/graphql/src/test-setup.ts"           }         }       },       "schematics": {}     },     "frontend": {       "projectType": "application",       "root": "apps/frontend",       "sourceRoot": "apps/frontend/src",       "architect": {         "build": {           "builder": "@nx-plus/vue:browser",           "options": {             "dest": "dist/apps/frontend",             "index": "apps/frontend/public/index.html",             "main": "apps/frontend/src/main.ts",             "tsConfig": "apps/frontend/tsconfig.app.json"           },           "configurations": {             "production": {               "mode": "production",               "filenameHashing": true,               "productionSourceMap": true,               "css": {                 "extract": true,                 "sourceMap": false               }             }           }         },         "serve": {           "builder": "@nx-plus/vue:dev-server",           "options": {             "browserTarget": "frontend:build"           },           "configurations": {             "production": {               "browserTarget": "frontend:build:production"             }           }         },         "lint": {           "builder": "@nrwl/linter:lint",           "options": {             "linter": "eslint",             "config": "apps/frontend/.eslintrc",             "tsConfig": [               "apps/frontend/tsconfig.app.json",               "apps/frontend/tsconfig.spec.json"             ],             "exclude": ["**/node_modules/**", "!apps/frontend/**"]           }         },         "test": {           "builder": "@nrwl/jest:jest",           "options": {             "jestConfig": "apps/frontend/jest.config.js",             "tsConfig": "apps/frontend/tsconfig.spec.json",             "passWithNoTests": true           }         }       }     },     "frontend-e2e": {       "root": "apps/frontend-e2e",       "sourceRoot": "apps/frontend-e2e/src",       "projectType": "application",       "architect": {         "e2e": {           "builder": "@nrwl/cypress:cypress",           "options": {             "cypressConfig": "apps/frontend-e2e/cypress.json",             "tsConfig": "apps/frontend-e2e/tsconfig.e2e.json",             "devServerTarget": "frontend:serve"           },           "configurations": {             "production": {               "devServerTarget": "frontend:serve:production"             }           }         },         "lint": {           "builder": "@nrwl/linter:lint",           "options": {             "linter": "eslint",             "config": "apps/frontend-e2e/.eslintrc",             "tsConfig": ["apps/frontend-e2e/tsconfig.e2e.json"],             "exclude": ["**/node_modules/**", "!apps/frontend-e2e/**"]           }         }       }     }   },   "cli": {     "defaultCollection": "@nrwl/angular"   },   "schematics": {     "@nrwl/angular:application": {       "unitTestRunner": "jest",       "e2eTestRunner": "cypress"     },     "@nrwl/angular:library": {       "unitTestRunner": "jest"     }   },   "defaultProject": "backend" }
package.json
{     "name": "redacted",     "version": "0.0.0",     "license": "MIT",     "scripts": {       "ng": "ng",       "nx": "nx",       "start": "ng serve",       "build": "ng build",       "test": "ng test",       "lint": "nx workspace-lint && ng lint",       "e2e": "ng e2e",       "affected:apps": "nx affected:apps",       "affected:libs": "nx affected:libs",       "affected:build": "nx affected:build",       "affected:e2e": "nx affected:e2e",       "affected:test": "nx affected:test",       "affected:lint": "nx affected:lint",       "affected:dep-graph": "nx affected:dep-graph",       "affected": "nx affected",       "format": "nx format:write",       "format:write": "nx format:write",       "format:check": "nx format:check",       "update": "ng update @nrwl/workspace",       "workspace-schematic": "nx workspace-schematic",       "dep-graph": "nx dep-graph",       "help": "nx help",       "postinstall": "ngcc --properties es2015 browser module main --first-only --create-ivy-entry-points"     },     "private": true,     "dependencies": {       "@angular/animations": "9.1.3",       "@angular/cdk": "9.2.1",       "@angular/common": "9.1.3",       "@angular/compiler": "9.1.3",       "@angular/core": "9.1.3",       "@angular/forms": "9.1.3",       "@angular/platform-browser": "9.1.3",       "@angular/platform-browser-dynamic": "9.1.3",       "@angular/platform-server": "9.1.3",       "@angular/router": "9.1.3",       "@fortawesome/fontawesome-free": "5.13.0",       "@jnields/vue-helmet": "^3.0.0",       "@nestjs/common": "^6.8.3",       "@nestjs/core": "^6.8.3",       "@nestjs/platform-express": "^6.8.3",       "@ng-bootstrap/ng-bootstrap": "6.1.0",       "@ngrx/effects": "9.1.0",       "@ngrx/entity": "9.1.0",       "@ngrx/router-store": "9.1.0",       "@ngrx/store": "9.1.0",       "@ngrx/store-devtools": "9.1.0",       "@ngx-loading-bar/core": "4.2.0",       "@ngx-translate/core": "12.1.2",       "@nrwl/angular": "9.3.0",       "@types/lodash": "4.14.150",       "angular-in-memory-web-api": "0.10.0",       "apexcharts": "3.19.0",       "aws-amplify": "^3.0.17",       "aws-amplify-angular": "^5.0.17",       "bootstrap": "4.5.0",       "chart.js": "2.9.3",       "chartist": "0.11.4",       "classlist.js": "1.1.20150312",       "clipboard": "2.0.6",       "core-js": "3.6.5",       "date-arithmetic": "^4.1.0",       "hammerjs": "2.0.8",       "highlight.js": "^9.17.1",       "lodash": "4.17.15",       "material-design-icons": "3.0.1",       "moment": "2.24.0",       "ng-apexcharts": "1.2.3",       "ng-inline-svg": "10.0.0",       "ngrx-store-freeze": "0.2.4",       "ngx-clipboard": "13.0.0",       "ngx-daterangepicker-material": "2.2.0",       "ngx-highlightjs": "3.0.3",       "ngx-perfect-scrollbar": "9.0.0",       "ngx-permissions": "7.0.3",       "object-path": "0.11.4",       "popper.js": "^1.16.1",       "reflect-metadata": "^0.1.13",       "rxjs": "6.5.5",       "smooth-scrollbar": "^8.5.2",       "socicon": "3.0.5",       "tooltip.js": "^1.3.3",       "tslib": "1.11.1",       "vue": "^2.6.11",       "vue-router": "^3.2.0",       "web-animations-js": "2.3.2",       "zone.js": "0.10.3"     },     "devDependencies": {       "@angular-devkit/build-angular": "0.901.3",       "@angular/cli": "9.1.3",       "@angular/compiler-cli": "9.1.3",       "@angular/language-service": "9.1.3",       "@angular/material": "9.2.1",       "@angular/material-moment-adapter": "9.2.1",       "@nestjs/schematics": "^6.7.0",       "@nestjs/testing": "^6.8.3",       "@ngrx/schematics": "9.1.0",       "@nrwl/cypress": "9.3.0",       "@nrwl/jest": "9.3.0",       "@nrwl/nest": "9.3.0",       "@nrwl/node": "9.3.0",       "@nrwl/workspace": "9.3.0",       "@nx-plus/vue": "^0.5.0",       "@types/chartist": "0.9.47",       "@types/jasmine": "3.5.0",       "@types/jasminewd2": "2.0.3",       "@types/jest": "25.1.4",       "@types/node": "12.11.1",       "@types/object-path": "0.11.0",       "codelyzer": "5.2.2",       "css-loader": "^3.4.2",       "cypress": "^4.1.0",       "dotenv": "6.2.0",       "eslint": "6.8.0",       "jasmine-core": "3.5.0",       "jasmine-spec-reporter": "4.2.1",       "jest": "25.2.3",       "jest-preset-angular": "8.1.2",       "karma": "4.3.0",       "karma-chrome-launcher": "3.1.0",       "karma-coverage-istanbul-reporter": "2.1.0",       "karma-jasmine": "2.0.1",       "karma-jasmine-html-reporter": "1.4.2",       "node-sass": "4.13.1",       "prettier": "2.0.4",       "protractor": "5.4.3",       "ts-jest": "25.2.1",       "ts-node": "8.3.0",       "tslint": "6.0.0",       "typescript": "3.7.5",       "webpack-bundle-analyzer": "3.6.1",       "webpack-cli": "3.3.11",       "webpack-messages": "2.0.4",       "webpack-rtl-plugin": "2.0.0",       "@nrwl/eslint-plugin-nx": "9.3.0",       "@typescript-eslint/parser": "2.19.2",       "@typescript-eslint/eslint-plugin": "2.19.2",       "eslint-config-prettier": "6.0.0",       "@vue/test-utils": "1.0.0-beta.31",       "babel-core": "^7.0.0-bridge.0",       "jest-serializer-vue": "^2.0.2",       "jest-transform-stub": "^2.0.0",       "vue-jest": "^3.0.5",       "@vue/cli-plugin-typescript": "~4.3.0",       "@vue/cli-service": "~4.3.0",       "@vue/eslint-config-typescript": "^5.0.2",       "eslint-plugin-vue": "^6.2.2",       "vue-template-compiler": "^2.6.11"     }   }
/public
index.html
`

<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta name="viewport" content="width=device-width,initial-scale=1.0" />

<link rel="icon" href="<%= BASE_URL %>favicon.ico">
<link href="https://fonts.googleapis.com/css2?family=Manjari&family=Nixie+One&display=swap" rel="stylesheet">

`
Failure Logs

no failure logs
Environment

Plugin name and version:
"@nx-plus/vue": "^0.5.0",

@nrwl/angular : 9.3.0
@nrwl/cli : 9.3.0
@nrwl/cypress : 9.3.0
@nrwl/eslint-plugin-nx : 9.3.0
@nrwl/express : Not Found
@nrwl/jest : 9.3.0
@nrwl/linter : 9.3.0
@nrwl/nest : 9.3.0
@nrwl/next : Not Found
@nrwl/node : 9.3.0
@nrwl/react : Not Found
@nrwl/schematics : Not Found
@nrwl/tao : 9.3.0
@nrwl/web : Not Found
@nrwl/workspace : 9.3.0
typescript : 3.7.5

This is working as expected for me. As you can see in the screenshot below I moved logo.png from assets/ to public/img/ and it loads. You can also see the favicon loaded in the browser tab. Make sure you're referencing images inside of public/ with absolute paths. Also, if you're using --publicPath, then you need to prepend your image paths with that. This is all explained here.

If this doesn't help, then please provide a repo with a minimal reproduction.

@BuckyMaler
I am trying to reference static files inside the index.html file in the public folder.
like the favicon images and the site manifest (which arent being served for me).
here are some images showing the folder structure of my project as well as it being served. In the second imag you can see tht I am unable to directly access this image

this image shows that after building the project the referenced image in the index.html file are not saved at all

It seems to be working for me.
favicon-32x32.png loads:

android-icon-192x192.png loads:

All images are copied to dist/:

I used this to generate the images, but that's a moot point. Am I doing something different from you?
Please provide a reproducible example or this will be labeled as can't reproduce.

@BuckyMaler I've attached the frontend app ant it's e2e folder.
xxx.zip

@BuckyMaler It seems as thought the problem might have been with nx workspace v10
I recreated the repo with the npx<EMAIL_ADDRESS>and it suddenly started to work correctly.


attempt at implementing #10

This is my attempt at implementing #hidden. It is not working, and I think it is because my approach might fundamentally be incompatible with the intended way.
In short, what I did was to start parsing syn::File and remove any item/expr that comes after #[docify::hidden]. This part is intentioanlly left incomplete (it does not parse nested expressions like syn::Block).
Nonetheless, this is not working because source_excerpt (for reasons beyond my current understanding) was expecting to be fed the untouched source_code, not the modified version.
For a similar reason, all of my formatting was also being wiped. I like the current approach of always formatting the coment and I think it should be the default behavior. We can backport this part to master sooner.

ah yeah this would have to integrate closely with source_excerpt to work properly. At the top of my head I believe you would need to do your removals in a clean way that doesn't destroy formatting and then feed that into the regular docify parsing process. The CompressedString machinery has the tools you need to do this, as it lets you identify the "real" start and end position of an item within the original source string


[Rebased] Feature/generic ssl

ISSUE TYPE

Feature Pull Request

SUMMARY
Make custom SSL/TLS support generic, instead of just mattermost. Useful for clusters using self-signed certificates or infrastructure behind SSL proxies in enterprise
Applicable changes for #160
Rebased according to @bhavin192's request

@mugdha-adhav can you please take a look at this changes once, just to make sure everything is fine.

Thanks for the PR @rajinator !


Reset HOME to takeoff

The takeoff position is a better estimate of where we want to be for RTL.

Done


refactoring boolean builder apis

Which issue does this PR close?
Partially implements https://github.com/apache/arrow-rs/issues/2054
Rationale for this change
Refactor apis to make a consistent new and with_capacity functions
What changes are included in this PR?
Removes capacity from new and added with_capacity function instead.
Are there any user-facing changes?
Yes

Closing it temporarily. I will create a new PR for this.


Task Available Banner - Task Calculation

Added calculation for tasks remaining to banner. This should complete #243.
Haven't been able to test much as I am not sure how to add more tasks.
Will circle back with the team.

thanks, looks good @MiggySmallz!
I might rewrite it a bit in the future to be integrated with the useCampaigns composable, along with the logic to count the tasks available, so that we can re-use it in other places too, but that's not needed for now.


email to mailing list to clarify catkin / rosbuild support according to REP 3

Follow up of ros-infrastructure/rep#75.

hopefully this was done a while ago. if not the documentation was prominent.


Equip backpack bug

after i put a backpack on and then shift click another backpack on if you don't have armor on the other backpack goes into your armor slot and then disappears

Vanilla "bug", can't prevent things from being equipped using shift-click without ASM magic. Backpacks return false for isValidArmor(), they're only meant to be equipped by sneaking and breaking the backpack block.


Added documentation for *arr stack and Overseerr

Added documentation for Sonarr
Added documentation for Overseerr
Added documentation for Radarr
Added documentation for Prowlarr

Thank you for the PR 💜.


Allow for custom *http.Client to be passed to the upper clients

Currently, the *http.Client used for making the API calls are hard-coded inside the client different gateway implementations (e.g.: https://github.com/letsencrypt-cpanel/cpanelgo/blob/eb0532054299c19f6aad2f5445e25ea8ff44bbd2/cpanel/authenticated.go#L115)
I think there should be a way to pass an *http.Client that the user might want to use down to the gateway. An easy approach would be to pass the client into the gateway client constructors:
type JsonApiGateway struct {
	Hostname string
	Username string
	Password string
	Insecure bool
	cl       *http.Client
}

func NewJsonApi(hostname, username, password string, insecure bool, cl *http.Client) (CpanelApi, error) {
	c := &JsonApiGateway{
		Hostname: hostname,
		Username: username,
		Password: password,
		Insecure: insecure,
	}

        if cl != nil {
            c.cl = cl
        }

	return CpanelApi{cpanelgo.NewApi(c)}, nil
}

What do you think?

Agreed, passing a client is a very basic need - in the whm package too.
The design of this package is frankly beyond saving, owing to its age. I would be happy to accept your PR, should you want to re-open it.

@alexzorin reopened. :)

Thanks!

@alexzorin should we tag a v1.1.2 release?

Good idea, I've pushed a v1.2.0 tag.


Update es.po

Hi, update version Full Spanish

Thank you!

To you, I am reviewing and I saw a error translated link, I change it, I review the rest and upload the PR


Add ORTModelForVision2Seq for VisionEncoderDecoder models inference

What does this PR do?
This PR enables the inference of the VisionEncoderDecoder models using ONNXRuntime. The PR adds ORTModelForVision2Seq for doing inference similar to AutoModelForVision2Seq by changing just a few lines.
Usage
>>> from PIL import Image
>>> from transformers import GPT2TokenizerFast, ViTImageProcessor
->>>  from transformers import AutoModelForVision2Seq
+>>>  from optimum.onnxruntime import ORTModelForVision2Seq
>>> import requests

>>> model_name = "nlpconnect/vit-gpt2-image-captioning"
->>> model = AutoModelForVision2Seq.from_pretrained(model_name)
+>>> model = ORTModelForVision2Seq.from_pretrained(model_name, from_transformers=True)
>>> tokenizer = GPT2TokenizerFast.from_pretrained(model_name)
>>> image_processor = ViTImageProcessor.from_pretrained(model_name)

>>> url = "http://images.cocodataset.org/val2017/000000039769.jpg"
>>> image = Image.open(requests.get(url, stream=True).raw)
>>> pixel_values = image_processor(image, return_tensors="pt").pixel_values

>>> generated_ids = model.generate(pixel_values)
>>> generated_text = tokenizer.batch_decode(generated_ids, skip_special_tokens=True)[0]
>>> print(generated_text)

Limitations

Donut model not supported
TrOCR model not supported with use_cache=True.
IObinding not supported

Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[x] Did you write any new necessary tests?

LGTM!
What's the status for the pat key / values?

Past key values is not supported only for TrOCR, would look into this after Donut


fix: update failed tests

Targeting a few failing tests that have been part of the previous GHA releases with some fixes.
There are related open issues #1, #2, #3 with FF that still cause flake in one test that will need a separate effort.

@jaffrepaul
I see you are making good progress on eliminating some of the issues here! Whilst I was trying to find out what was going on with the Node.js issue I noticed that the deprecated ubuntu-18.04 is still in use. It would probably overload this PR if you put additional changes in here, so instead I opened a new issue https://github.com/cypress-io/github-action/issues/648. Perhaps you already had something planned here anyway?

@jaffrepaul
This was 99% successful (110 of 111 checks passed) 👍🏻
Was the remaining failure just the flaky Firefox test you referred to?
BTW: Would you consider making your (presumed) membership of the https://github.com/cypress-io organization visible? See GitHub help Publicizing or hiding organization membership.

@MikeMcC399 Yes, see the original PR message above. Good call on the org visibility ✅ I merged this without making a release yet because I'd like to add some of the additional dependency updates as well first.

@jaffrepaul

Good call on the org visibility ✅

Thank you for enabling this!

I merged this without making a release yet because I'd like to add some of the additional dependency updates as well first.

That makes sense. Different workflows need to be updated and the README documentation as well, which will probably take several steps. Once everything is updated and consistent it would be worthwhile declaring a release. Anybody who is subscribed to releases would then get notified. Most users won't need to know about individual updates.


Prepare for Spring Cloud Azure 5.9.1 release

Description
Prepare for Spring Cloud Azure 5.9.1 release
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
API changes are not detected in this pull request.


Add warning when attempting server connection without user permissions

Added a warning that catches the IllegalOperationError that we previously handed to the user without context/explanation.
Following discussion with @AlexejPenner, we agreed that there aren't really any scenarios we could imagine where a user might want to be logged into a ZenML server without any permissions attached to their role.
Pre-requisites
Please ensure you have done the following:

[x] I have read the CONTRIBUTING.md document.
[ ] If my change requires a change to docs, I have updated the documentation accordingly.
[ ] If I have added an integration, I have updated the integrations table and the corresponding website section.
[ ] I have added tests to cover my changes.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Other (add details above)

Is this something that we can add a test for or is that unreasonably complicated?

Is this something that we can add a test for or is that unreasonably complicated?

I don't think the test harness currently allows for attempting to connect to a new deployed zenml server. It also feels like unproportional effort to create this scenario for a niche exception like this one.

What I had in mind, but might not be possible:
When the test are running with a rest zen server, create a new user without role. Then run CLI connect command to connect to that already connected server (or disconnect first if necessary) which should trigger this? But I now realize we only log a warning which isn't testable anyway I guess

What I had in mind, but might not be possible: When the test are running with a rest zen server, create a new user without role. Then run CLI connect command to connect to that already connected server (or disconnect first if necessary) which should trigger this? But I now realize we only log a warning which isn't testable anyway I guess

Technically we could test that the IllegalOperationError doesn't get raised...

Probably not worth it though, maybe if it works after 5 mins it's a nice test but not that important to have I guess

@AlexejPenner @schustmi added a test. Not sure if it'll work, but let's see.


[gardening] Prefer macOS over OSX

Refs: https://github.com/apple/swift/pull/13315 and so on

@swift-ci Please test


Prohibit deposit or saving as a draft while files are uploading

At least one user during testing attempted to deposit an item without waiting for the file to upload. Is it possible and desirable to prevent the user from doing this? (Seems like it to me.) Files are also not saved and the user is not alerted if they Save as Draft before file upload is complete. This could be achieved by greying out the save and deposit buttons while this is going on, but I suspect there are other options.
@hannahfrost @astridu @jcoyne @mjgiarlo Thoughts?

Disabling the deposit button until the file is uploaded seems like a good idea.

@hannahfrost @astridu @jcoyne @mjgiarlo I've updated this to include saving as a draft as well, as the user receives no notification that files are not finished uploading and will not be saved. Let me know if this should be a separate ticket.

What sort of indication will we show the user that the submit button won't work while files are uploading?

@jcoyne Do we need something more than what we mentioned above -- having it greyed out?

If the button is grayed out, the user may wonder why it is grayed out.  Should there be a message that explains this unusual behavior to  a user?

Perhaps there can be a mouseover or a message under the button when it is in this state that says "Deposit is displayed during file uploading." @astridu ?

@amyehodge mouseover mesages are not accessible to people who use screenreaders and they don't work for people who use touchscreens.

@jcoyne Ah. Good to know.

Could we do something like this where there is a message above the button?

Yes, that works.

Thanks, @astridu !

So, there is an accessibility problem with the buttons being disable approach too.  Namely a keyboard user can submit a form by pressing enter, and not using the buttons at the bottom.  So how about an approach like this instead, where if they submit (by any means), an alert pops up telling them to wait a minute:

This works for me, @jcoyne. Thanks for being diligent about the accessibility issues!

@jcoyne What's the status of this ticket? Can we get this finished before the release on Wednesday?


Error while adding  go-elasticsearch package

Please help me debug this error while importing go-elasticsearch using the commands and files mentioned in ReadMe.
Error :
./../pkg/mod/github.com/elastic/go-elasticsearch/v8@v8.0.0-20200210103600-aff00e5adfde/estransport/estransport.go:118:32: httpTransport.Clone undefined (type *http.Transport has no field or method Clone)

Hi, this is due to an old version of Go, can you upgrade and try again? (*http.Transport).Clone() is available since 1.13.

So it is not backward compatible ? So you mean to say that if my architecture has go1.12 either i will need to update it or use something else.
Thanks for the prompt response. Really appreciate your help.

On go1.12, you would need to use a previous version of go-elasticsearch — but then again, I would highly advise to upgrade to recent Go.
Also, note that v8 targets Elasticsearch master branch, you probably want v7, and specifically one of the releases, https://github.com/elastic/go-elasticsearch/releases.

I will be needing esUtil.NewBulkIndexer. This is not part of the latest release. Is there a plan to release it as part of next version ? If so when ? Is it okay to use the master v8 version already ?

Correct, it will be part of the next release, 7.7, which will be published along the Elastic stack.
It is perfectly fine to use the Github branch for your Elasticsearch version, master for 8 and 7.x for 7. See the instructions in the main README — effectively, you just need to add a line like this to your go.mod:
github.com/elastic/go-elasticsearch/v7 7.x

@karmi Is the 7.7 client compatible with ElasticSearch v7.6?

@moon-bits, yes, in most parts it is.

Thanks, ticket can be closed - see also:
https://github.com/elastic/go-elasticsearch/issues/148

Still having the  issue :/
github.com/elastic/go-elasticsearch/v8 v8.0.0-20200508105138-fc4f6f3c7fc3

Still having the issue :/

Can you elaborate on what kind of issue you're having?

Sorry I missed your message, well I don't get it anymore, i finally could update today and don't get any issue :)

I am seeing this same issue but for version v7.13.1. Shouldn't v7 work for go versions 1.12 and below since it is using go 1.11?
/go/pkg/mod/github.com/elastic/go-elasticsearch/v7@v7.13.1/estransport/estransport.go:150:32: httpTransport.Clone undefined (type *http.Transport has no field or method Clone)

I don't think this issue applies anymore, closing.


Initial new libtcmu

Hey Mike and Xiubo, this's a bit late as too busy these days. Sorry about that. This patchset implements what we discussed in #432. The main change is to move scsi stuff into a new scsi_helpers.c to be used only by tcmu-runner and consumer/tcmu-synthesizer and other cleanups to separate libtcmu from tcmu-runner.
It also reinstall libtcmu.so and headers by reverting two commits in the end. It passed compilation and works normally. Pls review, thanks. @mikechristie @lxbsz

Hey Mike, I updated this patchset as your suggestion. Should we also bump the version number of libtcmu in CMakeList.txt? @mikechristie

@baihuahua
Sorry for the delay. I will get back to this by the weekend.

Thanks Mike, i'm waiting... :-P @mikechristie

@baihuahua Just a FYI.
I am working on this now. Do not waste your time fixing the conflicts. I am fixing them for you since it was my fault :)

Hey Mike, could we settle this this week? This hangs for a long time.

Next week. I am on vacation. I am pretty much done. I am just finishing up fixing up the naming of the functions we are exporting so they are consistent.

Great. Have a nice time. :)

Hey Mike, could you please take a look at this patchset? @mikechristie

Just so you know the patchset itself is fine. I am going to merge it as is. I fixed the merge conflicts already.
For the final lib though, I am working on some cleanups.
Sorry about that. We are trying to finish a release this last several weeks so I have been busy with bugs and not got to do development. I am going to work on it some more this weekend out side of work.

Hey Mike, if there's no big problems about this
patchset could you please consider merging it now? I need this to satisfy the requirement of
community patch from my boss. Thanks a lot.

Ok will do tonight.


Bank acount  - Infinite loading & BA account page does not load after user is back online

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.41-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4311372&group_by=cases:section_id&group_order=asc&group_id=283225
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Navigate to staging.new.expensify.com
Create new account
Click bottom right wrench settings icon
Click New Workspace button
Disable the internet connection in device
Select Bank account option in WS settings
Select Connect online with Plaid (Note : Message appears that this feature is only available when online)
Enable the internet connection

Expected Result:
User redirected to connect plaid bank flow once the internet is back
Actual Result:
Infinite loading & BA account page does not load after user is back online
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/8fdfb07b-0e60-4abd-ad47-79f16363e174
https://github.com/Expensify/App/assets/78819774/977d7a2a-d1ae-4692-b69b-37e757e1161f
View all open jobs on GitHub

Noted in slack - https://expensify.slack.com/archives/C01GTK53T8Q/p1707919815149159?thread_ts=1707829954.739589&cid=C01GTK53T8Q

Dupe of https://github.com/Expensify/App/issues/36479


[Docs] Add color sample to Default Theme docs page

I think it would be helpful to have a sample of the default theme colors in it's docs page.

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡
Examples 🌈
Currently the docs just have the hex code with no preview of the color:

I think it would be helpful to have a preview like they do in code editors such as VS code:

Motivation 🔦
I reference the default theme a good bit and frequently have to manually search the colors.  I think this would be helpful and save time.
I'm up for working on this if the maintainers think it's a good idea.

I had a similar idea today but regarding IntelliSense in vscode :laughing:
But this is a great idea now  that we control the full component. I guess we can check if the string would be useful as a color and then add a preview:
https://github.com/mui-org/material-ui/blob/5633c2768437604c7cfeed4eb62493c537469b19/docs/src/pages/customization/default-theme/DefaultTheme.js#L45-L46


chore(main): release 1.26.38

:robot: I have created a release beep boop
1.26.38 (2023-10-07)
Bug Fixes

remove upgrade from scoop (83990c9)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/aidanaden/canvas-sync/releases/tag/v1.26.38 :sunflower:


How to insert a page break after each li?

I have code like below:-
docx.ol do
li 'first'
li 'second'
end
I need to insert a page break after each li.
I tried with docx.page after li but that didn't worked.

I just created v1.0.3 of Carcal to allow this behavior.  To get the result you want, you will need to specify the li directives in their expanded, block form:
docx.ol do
  li do
    text 'This is the first list item.'
    page
  end
  li do
    text 'This is the second list item.'
    page
  end
  ...
end

Again, because the li model extends the p model, you can use any paragraph directive inside a list item.  Good luck!


feature: add pyroscope receiver and related pipeline

增加了 profiles 作为单独的数据类型转发
增加了一个用于接收 pyroscope SDK 数据的 receiver
对原来的 token 进行了扩充，同时保持兼容

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 7 committers have signed the CLA.:white_check_mark: IMBlues:x: jeremylv1992:x: Liyu6371:x: dellkeji:x: chenjiandongx:x: fishman001:x: shamclerenYou have signed the CLA already but the status is still pending? Let us recheck it.


Update .NET manual instrumentation root activity creation

Use MyActivitySource instead of source, the latter of which was missed as the wrong thing at some point
fixes https://github.com/open-telemetry/opentelemetry.io/issues/3247

Yeah, agreed. We are seeing about standardizing each manual instrumentation doc and this can fit in there maybe? I'll file a separate tracking issue.


toolz-0.12.0 doesn't have tlz.curry that is expected by dask-2023.12.1

Describe the issue:
[yuri@yv /usr/ports/science/py-thewalrus]$ python3.9
Python 3.9.18 (main, Dec 10 2023, 01:22:40)
[Clang 16.0.6 (https://github.com/llvm/llvm-project.git llvmorg-16.0.6-0-g7cbf1 on freebsd14
Type "help", "copyright", "credits" or "license" for more information.
>>> from tlz import curry, groupby, identity, merge
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/lib/python3.9/site-packages/tlz/_build_tlz.py", line 55, in exec_module
    toolz_mods = self._load_toolz(module.__name__)
  File "/usr/local/lib/python3.9/site-packages/tlz/_build_tlz.py", line 29, in _load_toolz
    raise ImportError(fullname)
ImportError: tlz.curry
>>>

Environment:

Dask version: 2023.12.1
Python version: 3.9
Operating System: FreeBSD 14.0
Install method (conda, pip, source): package

@yurivict: Thanks for reporting this issue. Unfortunately, I can't reproduce it locally. When creating a fresh environment with python=3.9 and toolz=0.12.0, from tlz import curry works just fine on my Mac.
Could you try creating a fresh environment and see if the issue persists?

You are right, dask isn't a problem.
The issue appears to be in the toolz package.


Test failures on s390x

I'm working on updating hdf5 in Fedora to 1.10.5, and I'm getting test failures with matio 1.5.14 only on s390x:
621: Read 2D Unicode character array                 FAILED (mat5_compressed_read_le.at:182)
Read/Write Compressed MAT version 5
2825: Copy variables                                  skipped (mat5_compressed_readwrite.at:28)
2826: Copy variables                                  FAILED (mat5_compressed_readwrite.at:38)
2827: Delete variables                                FAILED (mat5_compressed_readwrite.at:46)
2828: Copy large struct                               skipped (mat5_compressed_readwrite.at:149)
2829: Copy large struct                               ok

Full s390x build log: https://kojipkgs.fedoraproject.org//work/tasks/7129/33587129/build.log

Probably duplicate of #108.

More details:
## ---------------------- ##
## Detailed failed tests. ##
## ---------------------- ##
#                             -*- compilation -*-
621. mat5_compressed_read_le.at:180: testing Read 2D Unicode character array ...
./mat5_compressed_read_le.at:182: cp $srcdir/results/read-var95-5.out expout
         $builddir/test_mat readvar $srcdir/datasets/matio_test_cases_compressed_le.mat var95
--- /dev/null	2019-03-19 02:23:16.979272966 +0000
+++ /builddir/build/BUILD/matio-1.5.14/test/testsuite.dir/at-groups/621/stderr	2019-03-19 02:24:28.489272966 +0000
@@ -0,0 +1,2 @@
+corrupted size vs. prev_size
+/builddir/build/BUILD/matio-1.5.14/test/testsuite.dir/at-groups/621/test-source: line 17: 46408 Aborted                 (core dumped) $builddir/test_mat readvar $srcdir/datasets/matio_test_cases_compressed_le.mat var95
--- expout	2019-03-19 02:24:27.539272966 +0000
+++ /builddir/build/BUILD/matio-1.5.14/test/testsuite.dir/at-groups/621/stdout	2019-03-19 02:24:27.539272966 +0000
@@ -1,9 +0,0 @@
-      Name: var95
-      Rank: 2
-Dimensions: 2 x 4
-Class Type: Character Array
- Data Type: Unicode UTF-16 Encoded Character Data
-{
-بجلی
-điện
-}
./mat5_compressed_read_le.at:182: exit code was 134, expected 0
621. mat5_compressed_read_le.at:180: 621. Read 2D Unicode character array (mat5_compressed_read_le.at:180): FAILED (mat5_compressed_read_le.at:182)
#                             -*- compilation -*-
2826. mat5_compressed_readwrite.at:34: testing Copy variables ...
./mat5_compressed_readwrite.at:38: $builddir/test_mat -v 5 -z copy $srcdir/datasets/matio_test_cases_compressed_le.mat
--- /dev/null	2019-03-19 02:23:16.979272966 +0000
+++ /builddir/build/BUILD/matio-1.5.14/test/testsuite.dir/at-groups/2826/stderr	2019-03-19 02:26:55.349282966 +0000
@@ -0,0 +1,2 @@
+corrupted size vs. prev_size
+/builddir/build/BUILD/matio-1.5.14/test/testsuite.dir/at-groups/2826/test-source: line 19: 52122 Aborted                 (core dumped) $builddir/test_mat -v 5 -z copy $srcdir/datasets/matio_test_cases_compressed_le.mat
./mat5_compressed_readwrite.at:38: exit code was 134, expected 0
2826. mat5_compressed_readwrite.at:34: 2826. Copy variables (mat5_compressed_readwrite.at:34): FAILED (mat5_compressed_readwrite.at:38)
#                             -*- compilation -*-
2827. mat5_compressed_readwrite.at:43: testing Delete variables ...
./mat5_compressed_readwrite.at:46: $builddir/test_mat -v 5 -z copy $srcdir/datasets/matio_test_cases_compressed_le.mat
--- /dev/null	2019-03-19 02:23:16.979272966 +0000
+++ /builddir/build/BUILD/matio-1.5.14/test/testsuite.dir/at-groups/2827/stderr	2019-03-19 02:26:56.379282966 +0000
@@ -0,0 +1,2 @@
+corrupted size vs. prev_size
+/builddir/build/BUILD/matio-1.5.14/test/testsuite.dir/at-groups/2827/test-source: line 16: 52148 Aborted                 (core dumped) $builddir/test_mat -v 5 -z copy $srcdir/datasets/matio_test_cases_compressed_le.mat
./mat5_compressed_readwrite.at:46: exit code was 134, expected 0
2827. mat5_compressed_readwrite.at:43: 2827. Delete variables (mat5_compressed_readwrite.at:43): FAILED (mat5_compressed_readwrite.at:46)

Full testsuite.log can be seen here: https://kojipkgs.fedoraproject.org//work/tasks/5100/33625100/build.log

@opoplawski Can you please confirm that adfa218770183cf93f74e7fad5055921ae1f9958 fixes the issue? Thanks.

@opoplawski Waiting for your final approval here to release a new version replacing the unfortunate v1.5.14.

Hm, not sure how long to wait to finally get a confirmation.

Sorry for the delay - very busy here.  1.5.15 builds and tests fine on s390x.


Linebreaks inside "with" params will cause an exception

I noticed line breaks inside the parameters object will break the embed function.
Will work:
{% embed 'skeletons/sidebarBox.twig' with { 'class': 'relatedContents' } %}
…
{% endembed %}

Won't work:
{% embed 'skeletons/sidebarBox.twig' with {
    'class': 'relatedContents'
} %}
…
{% endembed %}

TwigException: Unable to parse 'embed 'skeletons/sidebarBox.twig' with {
'class': 'relatedContents'
}'

This behavior is different to include and require where line breaks cause no trouble.

This is just the gulp plugin. The bug is in twig.js, it seems to be fixed already.
https://github.com/twigjs/twig.js/issues/386
I suggest to close this issue.


Update Composer dependencies (2022-04-20-00-02)

Visual regression test passed!
View the visual regression test report


keep the accessible buffer visible until tab/escape are used

fixes #175764
fixes #175765

there's an issue now because tabbing goes to the status bar instead of the terminal since the accessible buffer occurs before the terminal in the dom structure


Add neccessary variable for nova

This can be reverted after fixing in the ansible-default repository
Signed-off-by: Ramona Beermann<EMAIL_ADDRESS>

relates #48


Update os-upgrade-hana-large-instance.md

Updated with latest tested versions

@swesn : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@mamccrea
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


Weird Message 3

playing in a facebook game:

[fresh] [error] _execute_script_ptac, NPN_Evaluate failed
[WARNING:flash/platform/pepper/pep_url_request_info.cpp(219)] Missing colon in H".P header line "

the error message was a way too long than this, but is repeating the same message than before.

I've finally found why this is happening. At least one way to cause it is to have external server to send multiple Set-Cookie headers. Firefox merges them, but with \n, not with , as other headers. Header recreation code only creates one Set-Cookie, and other line spills out without a name.
I've filed an issue at: https://bugzilla.mozilla.org/show_bug.cgi?id=1120113

excellent!!!!!
:+1:


Not Showing Explorer

Not Showing Explorer on iOS 13 device and Simulator. I using call FLEXManager.shared().showExplorer() in ViewController.

Can you provide some more details? How did you install FLEX, which version of FLEX are you using, etc

I create empty project and install FLEX 3.0 using CocoaPods. Importing FLEX in ViewController, tappef button will execute this code.
FLEXManager.shared().showExplorer() but FLEX Explorer not showing. I found a repo using flex in the project and downloaded it.  works with the same code.  I think I'm doing something missing.

@yusufozgul I had to pull from master to incorporate #304
pod 'FLEX', :configurations => ['Debug'], :git => "https://github.com/Flipboard/FLEX.git", :branch => 'master'

iOS13 deprecated keyWindow and  #304 fixes it

Update your pod, I just pushed 3.1.0 with iOS 13 support. Let me know here if you are still having issues.


Add ps

Jetbrains IDEs require ps to be installed to properly run devcontainers. Add package procps to install ps in the container.

Hi @kuebler ,
would you mind adding
which + sudo
to this PR?
Thanks

Was so far only focusing on making the container work with Jetbrains' devcontainer implementation, to that end, just adding ps was enough. Should we maybe tackle the which and sudo bit in another PR to keep matters segregated?


Planned Changes

[x] #9
[x] #12
[x] Clean up package.json dependencies
[x] #11
[ ] #18
[ ] #10
[ ] PWA
[ ] Race condition with checklist

Closing because I'm currently working on other things


Flight info & requesting messages improvements

Ardupilot does not support MAVLINK_MSG_ID_FLIGHT_INFORMATION or MAV_CMD_REQUEST_FLIGHT_INFORMATION. Also there was some sort of deadlock occurring from the _system_impl->send_autopilot_version_request() in enable(), so just let system or the period caller request it slightly later.

Hi, thanks for the PR. My thoughts on this:
I think even if we send the request to get the FLIGHT_INFORMATION, for ardupilot it simply sends unsupported which the client can simply ignore assuming it might be supported from ArduPilot in the future. There is an open issue on Ardupilot firmware repo: https://github.com/ArduPilot/ardupilot/issues/15217 which could potentially add the support. So it would be better to support the message on ardupilot side rather than remove it on MAVSDK if the message sending is not producing any negative side effects.
Thanks,
khedar

In general I would agree, however at the moment the plugin isn't even usable as it stands currently in my testing. Also, only flight_uuid and time_boot_ms are collected from the information message. flight_uuid is a parameter for ardupilot and time_boot_ms is in many other messages, so if somebody needs flight_uuid then they can just grab the parameter. I'd be happy to re-add it personally if that PR actually does ever progress though.

I will be on vacation for the rest of the month so I committed where I last left off. I have made adjustments so that using the RequestMessage class will no longer repeatedly request messages that are denied, which means that you don't have to accommodate for specific flight stacks by avoiding sending requests for unsupported messages.


[Experimentation] Added very basic functionality related to foreign experts

Foreign experts are authors of articles translated from foreign languages.
According to what was said and what I understand, we have to have a way to account them, but not as username/password users.
GitHub Board
Issue link
Support managing foreign experts for translated articles
Story link
Just as the issue says - none yet.
Code reviewers

[ ] @teaFunny

Notes
Please note that this is an experimental draft PR. It's not ready to merge.

Tests aren't done yet, I plan on doing them now.


fix: don't swallow error from jsonparser.ArrayEach

Fixes https://github.com/wundergraph/wundergraph/issues/278

discarded


Kubelet configuration customization Docker cp and wn

Issue #, if available:
Description of changes:
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/test eks-anywhere-e2e-presubmit


Language Localization Issue in Enatega SingleVendor Customer App - "Item Out of Stock" Tag

Describe the bug
The Enatega SingleVendor Customer App is experiencing a language localization problem related to the "Item Out of Stock" tag. After changing the app language, the tag indicating that an item is out of stock is not being translated into the newly selected language. Instead, it continues to display in the app's previous language, leading to a discrepancy in language representation.
To Reproduce
Steps to reproduce the behavior:

Open the Enatega SingleVendor Customer App.
Change the app language to a language different from the default language.
Browse the app and encounter an item that is out of stock.

Expected behavior
The "Item Out of Stock" tag should be translated into the newly selected language, providing users with accurate and localized information about the item's availability.
Screenshots
https://github.com/ninjas-code-official/food-delivery-singlevendor/assets/152266796/71880221-a88f-49fb-a69b-d91e9ffd31c6
Smartphone:

Device: iPhone

Additional context
This issue specifically pertains to the translation of the "Item Out of Stock" tag.
Users have reported encountering this language localization problem consistently.

Resolved!


chore(ci): Re-enable Trivy image scan for ROCm Pytorch image

Description

Re-enabling Trivy image scan for ROCm Pytorch image since the image size is optimized.
How Has This Been Tested?

Check the green CI here
Merge criteria:

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

@caponetto I think we should hold on this a bit more; the image is smaller but still not small enough I think. Or is it, actually?

@jiridanek From my observations, it should be ok if the image is <40GB, which is now the case. I've tested it here.

guess I can't argue with "green" (or blue in my case, i have colorblind theme turned on)
/lgtm

/override ci/prow/rocm-notebooks-e2e-tests
/override ci/prow/images

Can we have one more lgtm? :) @jstourac @paulovmr

/ltgm
Thank you, @caponetto ! :rocket:


FIX-1589,1590 - Manage server screen, Create server popup screen

Fixes
This pull request fixes #1589
Description
GUI Improvements: Server Management
Type of change
GUI Improvements

Enhancement of existing functionality
This change requires a documentation update

Impacted Areas in Application
FrontEnd UI Components will be affected including navigation
Checklist:
Please tick all the boxes or remove the ones that aren't needed and explain why
Communication

[x] PR is related to an issue
[ ] I have made corresponding changes to the documentation

Code quality

[x] Code follows the style guidelines
[x] I have self-reviewed my code
[ ] No new warnings are generated

Test coverage

[ ] Existing tests pass
[ ] New code is covered by passing tests

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

We recently reworked how authorization is done in the frontend as part of #1712. Given the changes in functionality, I can take over this PR and implement the necessary adjustments so that everything works as expected.

Jan will take over this PR and merge it together with his branch.


Removing eslint issue

eslint issues are currently disabled manually.
This PR includes refactoring the existing codebase for eslint issues.
Incomplete currently, Don't merge it.

Hey @HeeManSu  This is not required as diffing function will not just be used for diffing inspect objects, it's a generic function to diff any kind of object, that's why we don't have to apply type check here for inspect kind of objects.
Thanks


Feature/enable pagination

This PR enables pagination of workflows, test suites and test instances

The pagination feature looks very cool! All those arrows in the table header, however, make it look a pretty cluttered. I think we should show only the active one.
Example (Mozilla Thunderbird):

The pagination feature looks very cool! All those arrows in the table header, however, make it look pretty cluttered. I think we should show only the active one.

Fixed in https://github.com/crs4/lifemonitor-web/pull/18/commits/903fb46873fef5076317738c83e65fb2917c2d9b


Fix a bug when providing an empty query string

Applicable Issues

Fixes: #21
Description of the Change

Make it possible to request with an empty query string
Alternate Designs

In this version we will retrieve events from collections until pageSize has been reached. This does not guarantee that you will get the latest pageSize number of events. If we were to sort these events in terms of timestamp sent, then that would be costly on both GoER as well as the event repository since we are separating event types in different collections.
Benefits

This works against the API schema and it will not cost too many resources.
Possible Drawbacks

Users might expect to see the 'latest' events and not a 'random' selection of them. However I believe that a generic 'get-latest-events' request is not a normal use-case.
Sign-off

Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson<EMAIL_ADDRESS>

Should we count all documents in the collections in order to get pagination working properly?
Feels costly and I don't really know how we would do the iteration over collections and events for that to work.


[travis] Enable cache for $HOME/.cargo

This should accelerate the cargo install mdbook step under install,
which is currently called on all linux+nightly setups.
https://github.com/rust-lang/cargo/blob/36ddeff03a31f710095cfbe49287503bb60e294d/.travis.yml#L24-L25

r? @alexcrichton
(rust_highfive has picked a reviewer for you, use r? to override)

Should also accelerate dependency downloads and builds, but I'm not sure if that would have any unwanted side-effects here.

Hm I've tended to have a not-so-great experience with the lifetime of this cache, maybe we could just pass the --debug flag?

FYI, for rustfmt in intellij rust we do
- rustfmt --help || cargo install rustfmt --force

in before script
and
- $HOME/.cargo/bin/

in cache. It definitely helps because compiling libsyntax for rustfmt can easily take more than the rest of the build :)
https://github.com/intellij-rust/intellij-rust/blob/master/.travis.yml

Cool! Updated the diff based on @matklad's comment.
@alexcrichton, would this address the concern you had? If not, I'm not sure what you meant by the --debug flag, could you please elaborate?

Nah this looks good to me, no worries!
@bors: r+

:pushpin: Commit 0971aac has been approved by alexcrichton

:hourglass: Testing commit 0971aac7cd29e073dddfe0cdbf38eb0a9304adcb with merge 9c849fe0fde9bfdb20a5ad3043e53adfb1c0cc56...

:sunny: Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 9c849fe0fde9bfdb20a5ad3043e53adfb1c0cc56 to master...


CA CRL/OCSP Support

Right now when a 3rd party CA is added to the Ziti Controller there is no way to stop any one certificate, that is correctly signed/dated/etc, that has been "revoked" (either actual revocation or should be blocked for some external reason.
Options for implementation:

Add an internally managed Ziti revocation list

Easy but if there is a managed CRL/OCSP it becomes redundant

Add CRL/OCSP lookups for enrollment, periodical checks for new revocations, and ability to force revocation checks

Any news on this feature?

This is now being tracked on the IDP/Security board here: https://github.com/orgs/openziti/projects/25 under this issue: https://github.com/openziti/ziti/issues/2092
It is slated for release this year (Oct/Nov).

Closing as duplicate of https://github.com/openziti/ziti/issues/2092


Expand customizable cells to all views

Q
A

Bug fix?
no

New feature?
rather enhancement

BC breaks?
no

Related tickets
fixes #2120, partially #2043

License
MIT

@vsn4ik I took the liberty to enhance your idea.
I directly attach the event listener to the correct DOM node and use jQuery data() so the DOM is kept clear.

Attaching the event directly to the node was in my mind for the v2.
But the click function is already less a mess than 2 minors versions ago, so it's safer to make the change now.

@acrobat Fill free to play around to be sure I didn't break everything.
Some snippet for your amusement:
function callback() {
    var smileys = ['😁', '😋', '😡', '😰', '🙅', '🙊', '🙏', '✌', '🚀', '🚨', '🚧', '🚽', '🉐', '⌚', '☝', '⚽', '⚾', '⛄', '⛅'];
    return {content: '<div>' + smileys[Math.floor(Math.random() * smileys.length)] + '</div>'};
}

$('input').datepicker({
    beforeShowDay:     callback,
    beforeShowMonth:   callback,
    beforeShowYear:    callback,
    beforeShowDecade:  callback,
    beforeShowCentury: callback
});

@Azaret Thanks for the work! I've tested the code and it looks like it works for all views (cool example btw :D)
@vsn4ik @hebbet Do you guys have time for a review?

@Azaret Do we need extra tests for this behavior (the changes to the click etc) or is it covered by the current tests?

@Azaret @vsn4ik I'm going to release RC2 in the next few days. If this is complete then it will be in RC otherwise we will do another RC when this is merged!

Well it looks clear to me, I'm waiting @vsn4ik input on his remarks.

Hmm he had posted a comment, but it looks like it was deleted. So indeed wait for @vsn4ik for his feedback

When is this expected to come out? According to the docs, returning an object with a content key in the beforeShowDay method should allow me to change the content, however it does not work. I can disable a day fine with a boolean, just can't set content.

@Azaret sorry to ping you again! But any more work needed here? If I understand your comment above correctly "90 events" choice we have to make is good enough for now?
If we can agree on some solution for this would be nice, this way I can put out a RC2 ( and hopefully quite quick a stable release)
/cc @vsn4ik


SCUNetG need pretrain?

SCUNetG is based on SCUNet checkpoint?
thanks

Not necessary, both can work well.


Make Close() on simpleReaderCloser actually close the reader

see #16569 for some more info - but when Read() never returns EOF the for-loop in #16569 gets so tight that the thread causes a hang on gcc-go. But, irrespective of that issue, Read() should still return EOF after Close() is called.
Signed-off-by: Doug Davis<EMAIL_ADDRESS>

/cc @brahmaroutu

ping @vdemeester

@duglin SGTM, read a bit #16569 :scream_cat:

ping @runcom @LK4D4

ping @cpuguy83

LGTM

LGTM


Fix median() to work with int columns

Fixes #48.

Oh good catch and thanks for the PR!
Regarding the solution I think it would be more natural if median always returns something of type T, because it has the semantics of of being the "middle" element, which also works for types that don't support averaging. Maybe we could implement it with a when compiles(...) to do the averaging logic only for types which support floating point arithmetic, and otherwise simply take one of the two middle elements (only a problem for even length data anyway).


Impelment max_line_length

A max_line_length property would be nice to have, as described in https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length.

This version of the extension has been deprecated in favor of https://github.com/editorconfig/editorconfig-vscode. Moving the issue

This issue was moved to editorconfig/editorconfig-vscode#53


Redux 4 breaking changes

Creating this issue to keep a pile of breaking changes we want to release at once. This doesn’t mean we plan to do much breaking changes! Mostly they are cosmetic but since we’re using semver, we want to batch them. This is why this issue exists.

[x] Remove ActionTypes from createStore exports. It was never intended to be a part of public API. It is not visible of you import redux but since we now support importing redux/lib/* officially, we should stop exporting ActionTypes from redux/lib/createStore.
[ ] Drop support for IE8. This doesn’t mean there is anything specific we want to break, but rather that “we don’t support IE8” will be our official position from the next major release and on. React Redux will also bump the major because of this.
[ ]  Either fix or document/test the behavior in #1240.
[x] New TypeScript bindings: https://github.com/reactjs/redux/pull/1413
[x] Forbid subscribe() and getState() while reducer is running: https://github.com/reactjs/redux/issues/1568
[ ] Enhancer Overhaul https://github.com/reactjs/redux/pull/1702
[ ] Make sure INIT name is random (https://github.com/reactjs/redux/issues/1736#issuecomment-219484915)

we now support importing redux/lib/*

We do? I always viewed any import from outside of main (basically any import with a slash) as accessing private APIs. Your main should be the list of public APIs provided by the library. The only exception is for reducing your bundle size (until ES6 module builders become more readily available), but you would be doing this as an optimization step after importing something from the public API.

The only exception is for reducing your bundle size (until ES6 module builders become more readily available), but you would be doing this as an optimization step after importing something from the public API.

Yes, since 3.0.6. /lib/ is a practical way to do it today and I see no reason to disallow it until ES6-aware bundlers are commonplace. Our top-level API is stable so I don’t expect supporting it to be a pain.

Then we can import #1123 finally?

I’m looking into getting this in with es3ifyPlugin for now. But future-wise, yeah.

Our top-level API is stable so I don’t expect supporting it to be a pain.

Yeah, I don't think it's a pain thing either, just more of a philosophical issue. How do we want to go about importing them for combineReducers? Move them to utils and import from there?

Welp, I just went ahead and did that as a PR :smile: If you wanted to do it another way, no worries.

Move them to utils and import from there?

:+1:

I d like to share a little bit of my experience with redux.  i spent 5 month working on a fairly large redux application.
Redux did an awesome job. Nevertheless after few weeks of dev we hit the issue "how to deal with asynchronous actions". At first we used redux thunk and it did the job, but ours actions grew  rapidly in complexity.
At that point i decided to create a middleware base and generator functions (similar to redux saga but it was still actions). it allowed us to write complex  action like the following login action
export function* login(login, password) {
  var {state} = yield {
    type: types.ON_DO_NOTHING
  };

  if (state.cursor == "wait")
    return {type: types.ON_DO_NOTHING};

  yield {type: types.ON_WAITCURSOR_START};

  var {state,result} = yield RestManager.Call({
    method: REST.METHODS.POST,
    url: REST.RESOURCES.SESSIONS,
    header: RestManager.getAuthenticationHeader(login, password)
  });

  if (result.status == "success") {

    yield  {
      type: types.ON_REQUEST_SESSION_ID_COMPLETED,
      sessionID: result.data.content.sessionId,
    };

    var {state,result} = yield RestManager.Call({
      method: REST.METHODS.GET,
      url: REST.RESOURCES.FEATURES + "/AIPLM_INTEGRATION/users/" + login,
      header: RestManager.getBasicHeader(REST.APPLICATION_TYPE.JSON)
    });

    if (result.status == "success") {

      yield {type: types.ON_GET_CURRENT_DOCUMENT};
    }
    else {

      yield {type: types.ON_DISCONNECT_YES};

      yield messagesAction.displayMessage("error", i18n.t("NO_FEATURE_MESSAGE"));
    }
  }
  else {

    yield messagesAction.displayMessage("error", result.data.content);
  }

  return {type: types.ON_WAITCURSOR_STOP};
}

And that how we resolved our issue with asynchronous action..
I now believe that redux is mixing 2 distinct concept as one, action and store effect.
•	Actions should be what the user or computer trigger (ex: click on button, clock-tic , post form ...)
•	Store effects should be triggered by action to mutate the store

@guijesuis
Awesome that you discovered this pattern while working on a real world app. I agree with you that this seems like a great idea. In fact this is exactly what https://github.com/yelouafi/redux-saga offers.

Oh wait, you mentioned that. Yeah it’s not exactly the same now that I look at it. This is both the blessing and the curse of Redux: you can choose any abstractions that you feel comfortable with.

Redux-saga grant daemon. within daemon you can track action and dispatch effect (but those effect are still action in redux). Don't you believe that separating those 2 (getting a store effect dispatcher and an action effect dispatcher with their own midleware pipe) one way to improve redux in the future.

BTW, I think imports of the form ${package}/lib/${module} are not ideal, though they're the easiest way to go. Especially if you have a separate ES module build for which tree shaking works anyway, you should probably expose those as ${package}/${module} imports, potentially by npm publishing a subdirectory rather than the project's Git root.

Redux did an awesome job. Nevertheless after few weeks of dev we hit the issue "how to deal with asynchronous actions".

I spend two days in the understanding of how Redux works. Thunk, Saga are a very important part of Redux ecosystem, but it's hard for understanding, though.
I'd like to wish this project to go in the direction of simplification. 🙂

@monolithed : not sure what you're actually asking for.  Thunks are pretty simple: just functions returning functions.  And those aren't even a required part of Redux.

@markerikson

not sure what you're actually asking for.

Just thinking out loud 😄

just functions returning functions

Yep, I meant store => next => action => ...  and other carried functions, my eyes... 😪

And those aren't even a required part of Redux.

I see

Those aren't carried functions. They're called higher order functions. Similar to higher order components. They're a means of encapsulation of both data and logic. And arrow functions make them quite palatable :)

I noticed that TypeScript is on that checklist but not Flow. Any chance someone in the know could work that in there? 🙏

@rsolomon Already done in #1887

We can also migrate typings to TypeScript 2.1, introduce null-safety and strict mapped types for combineReducers and bindActionCreators.

Oh man I wish you have said, "we don't support IE" instead of mentioning the version.

Oh man I wish you have said, "we don't support IE" instead of mentioning the version.

Why?
The most extreme option that would still be reasonable would be dropping support for IE < 11. All modern JS features (but Proxy and new.target) can be polyfilled in it.
IE8, OTOH, is a risk because of how easy it is to crash when using Object static methods... which happens all the time in transpiled classes and modules.

Because the only reason they are still used, is because everyone keeps supporting them. Users of internet explorer is not gonna stop using computers if suddenly internet explorer stops working. It is a waste of time to give a moment of thought to how things would work in IE. I don't understand why it was worth a thumbsdown.

But sometimes you must made something that needs to run on IE. If redux don't support that, redux won't be used in these projects. If that was the case, I couldn't use redux at work. And IE11 isn't THAT bad at all.

@logicaleak, Why do yo mention IE? IE8 released 7 years ago and I think we should not care about that. If you want IE8 stay on the previous version.

Folks, we only said we're dropping support for IE8. No other version. If you need support for that version, you can continue to use 3.x. We won't be unpublishing that version on release of 4.0 and it will continue to work just fine, as it does right now.
You don't have to upgrade to every new release immediately. It's OK to run slightly out of date versions of stuff. Want to know how I know? This very website, GitHub, is running on a version of Rails that is about 5 years old at this point. And that's OK.

Lol, I started a forum discussion. Sorry about that.

I've updated the next branch to not be over 10 months out of date 😉 There are only 4 commits on there, so it should be a much more manageable starting point now.
https://github.com/reactjs/redux/compare/master...next

I just added #2298 which I think should be included here.

I'm removing the enhancer overhaul from this, since that's pretty broad and hasn't been really moved forward beyond the proof-of-concept phase. It shouldn't be a blocker for getting some other breaking changes pushed out. We can include it in a later major.
I'd like to push forward on getting this together. The TS folks are probably tired of yelling at me about when the next branch is going to land in master :) But also, we shouldn't be afraid to make breaking changes in more incremental moves. Nothing too drastic has shown up on next so far, so it's a good way to clean things up and avoid technical debt. If folks can't afford a change, we can support the 3.x versions indefinitely, just like we do on React Router.

OK, changed up the IE support to be more actionable around using babel-preset-env. We should switch to that and be explicit about browser and node version support. I can take it if no one else wants to, but it should be an relatively easy PR if someone wants to contribute.

Hey! Would be happy to lend a hand with switching to babel-preset-env, will open a PR soon.

Thanks @hmillison! Just need to figure out #2599 and I think we have something ready for alpha! 🥇

OK, merging next into master. 4.0.0-beta.1 will be available soon™!


DOCS: Added method to serve locally via npm in Readme.md

You can directly use Github to send the change


Feature #3016: Add git version into oned -v

To be squashed and cherry-picked into one-5.8

Closing, changing the git version return


Keda deployment is failing

Hi Team,
I am trying to install keda on gcp gke cluster through kubectl command.
kubectl apply -f https://github.com/kedacore/keda/releases/download/v2.10.1/keda-2.10.1.yaml
command output:
namespace/keda created
customresourcedefinition.apiextensions.k8s.io/clustertriggerauthentications.keda.sh created
customresourcedefinition.apiextensions.k8s.io/scaledjobs.keda.sh created
customresourcedefinition.apiextensions.k8s.io/scaledobjects.keda.sh created
customresourcedefinition.apiextensions.k8s.io/triggerauthentications.keda.sh created
serviceaccount/keda-operator created
role.rbac.authorization.k8s.io/keda-operator created
clusterrole.rbac.authorization.k8s.io/keda-external-metrics-reader created
clusterrole.rbac.authorization.k8s.io/keda-operator created
rolebinding.rbac.authorization.k8s.io/keda-operator created
rolebinding.rbac.authorization.k8s.io/keda-auth-reader created
clusterrolebinding.rbac.authorization.k8s.io/keda-hpa-controller-external-metrics created
clusterrolebinding.rbac.authorization.k8s.io/keda-operator created
clusterrolebinding.rbac.authorization.k8s.io/keda-system-auth-delegator created
service/keda-admission-webhooks created
service/keda-metrics-apiserver created
service/keda-operator created
deployment.apps/keda-admission created
deployment.apps/keda-metrics-apiserver created
deployment.apps/keda-operator created
apiservice.apiregistration.k8s.io/v1beta1.external.metrics.k8s.io created
validatingwebhookconfiguration.admissionregistration.k8s.io/keda-admission created.
while looking at status
kubectl get pods -n keda
NAME                                      READY   STATUS              RESTARTS   AGE
keda-admission-5c8b9dc89f-ncqcm           0/1     ContainerCreating   0          105s
keda-metrics-apiserver-7879d5cf54-vxrpn   0/1     ContainerCreating   0          104s
keda-operator-59ff7c7bbc-66mxd            0/1     ImagePullBackOff    0          103s
Failed to pull image "ghcr.io/kedacore/keda:2.10.1": rpc error: code = Unknown desc = failed to pull and unpack image "ghcr.io/kedacore/keda:2.10.1": failed to resolve reference "ghcr.io/kedacore/keda:2.10.1": failed to do request: Head "https://ghcr.io/v2/kedacore/keda/manifests/2.10.1": x509: certificate signed by unknown authority

Unable to attach or mount volumes: unmounted volumes=[certificates], unattached volumes=[certificates kube-api-access-mgctp temp-vol]: timed out waiting for the condition | FailedMount | Jul 3, 2023, 12:14:58 PM | Jul 3, 2023, 12:49:05 PM | 2 |
-- | -- | -- | -- | -- | --
MountVolume.SetUp failed for volume "certificates" : secret "kedaorg-certs" not found | FailedMount | Jul 3, 2023, 12:12:55 PM | Jul 3, 2023, 12:43:32 PM | 23 |
Unable to attach or mount volumes: unmounted volumes=[certificates], unattached volumes=[temp-vol certificates kube-api-access-mgctp]: timed out waiting for the condition | FailedMount | Jul 3, 2023, 12:17:12 PM | Jul 3, 2023, 12:35:32 PM | 8 |
Unable to attach or mount volumes: unmounted volumes=[certificates], unattached volumes=[kube-api-access-mgctp temp-vol certificates]: timed out waiting for the condition | FailedMount | Jul 3, 2023, 12:30:58 PM | Jul 3, 2023, 12:30:58 PM | 1 |

can someone help on this

Hi,
Does the issue persist? Do you have any kind of proxy in your side?
x509: certificate signed by unknown authority looks like an error in GH or in an intermediate proxy

Also, would you mind trying to use 2.11 please?

Hi @JorTurFer  @tomkerkhove ,
Thanks for your reply.
I've solved it by pushing the keda images in our container registry and giving the path of registry in yaml file.
KEDA deployment was completed.

Do you have any kind of proxy in the middle between your clusters and registries? Just to understand what heppened 😄
Could we close this issue?

Hi @JorTurFer ,
We do have a firewall which didn’t allow to access Internet.
For our cluster and registry we do have access permission, no proxy


replace stdout-stderr with own solution that keeps order between stdout and stderr

Replace stdout-stderr with own solution capture-stdout-stderr.js that

keeps order between stdout and stderr on replay()
prints stderr in color
allows matching against stdout AND stderr using output.any

Coverage remained the same at 46.108% when pulling 332188bc856c9aa91266f693e524d29ed7a3ba8a on better-stdout-stderr into 5c4fceb5ecf65d34e96905209a4cc991fc099646 on main.


docs(accordion):update readme test

📥 Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
☑ Submission checklist

[ ] I have read the CONTRIBUTING doc
[ ] yarn build works locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)

💬 Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did, what alternatives you considered, etc...

Hei, @idalower !

@all-contributors please add @idalower for doc


Loads up and then quits

I was trying to save an article that has scripts  asking you to sign-up or sign-in when visiting with a web browser, and also hide everything but the first paragraph.  The popup won't go away if you run scripts and don't  signup or in.  If you block scripts, you can get around the soft firewall, and the scripts are what I'm guessing to be the reason the program quits to "this web page not available"
The url to reproduce: https://www.theatlantic.com/health/archive/2024/08/women-undiagnosed-iron-deficiency-anemia/679676/

Thank you for reporting the issue! I'll investigate it further and work on a fix. I'll keep you updated on the progress.
Thanks again for your contribution!


Add plug dependency for opentelemetry_phoenix

I'm currently getting the following compilation warning for opentelemetry_phoenix
==> opentelemetry_phoenix
Compiling 2 files (.ex)
warning: Plug.Conn.get_peer_data/1 is undefined (module Plug.Conn is not available or is yet to be defined)
  lib/opentelemetry_phoenix.ex:104: OpentelemetryPhoenix.handle_endpoint_start/4

warning: Plug.Conn.get_req_header/2 is undefined (module Plug.Conn is not available or is yet to be defined)
  lib/opentelemetry_phoenix.ex:211: OpentelemetryPhoenix.header_value/2

Since the opentelemetry_phoenix code is calling functions on Plug.Conn directly, the dependency needs to be specified to avoid the compilation warning and ensure the compilation order is correct.
I also double-checked the plug version requirement and according to the plug changelog it appears that plug versions as early as 1.6 will work, because that's when get_peer_data/1 was introduced. However I'd be happy to update the version requirement to a later version if desired.

Hey @aaronrenner, it's a runtime dependency so the compilation warning is fine to ignore. Phoenix pulls it in and we don't really care what version it is. If it bugs ya, we'll want to mark it as optional and keep the version how we had it in test with a >= on it.

Thanks for the quick review, @bryannaegele! I updated the version requirement to be >= 1.11 which is what I think you were asking for.
I was also thinking about your request to make the plug dependency optional, but I was thinking if plug isn't installed this wouldn't work because it's explicitly calling functions on Plug.Conn. I can still make it optional if you prefer, but I just wanted to double-check. WDYT?

If it calls Plug directly it should definitely depend on Plug and not rely on it being a transitive dep.

I just noticed it is still ~> 1.11 and not >= 1.11 which seems to be what you two decided on? So I haven't merged.

Sorry about that, it must have gotten mixed up when I resolved the merge conflicts. :sweat_smile:
I personally might consider setting it to ~> 1.10 to match Phoenix 1.5.13 and ensure if Plug 2.x comes out with breaking changes, people won't run into issues. But I'm totally fine with this approach too and I'm just happy to have this dependency specified. :slightly_smiling_face:

Earlier versions of Phoenix don't have all the events and data we use, so >= 1.11 should be fine.


Column arrangement in indicator table

If no confidence is set, it looks like the content shifts left one column. For example, the Diamond Model content shifts into the Confidence field/column.

Just curious, how do you have it set to no confidence? It's a dropdown and it defaults to "Low", so I don't think there should be any cases where confidence isn't set. Is this the latest version?

I'm synced up with changes you made in past 24 hours. It looks like the issue is with indicators submitted before Confidence was built in as a default attribute/field.

Ah yea. So, I guess I should add a disclaimer that any future changes will most likely break stuff added before.
If you want to save these indicators you added, here's what you can do:
$ cd threat_note/vagrant
$ vagrant ssh
$ mongo

use threatnote
db.network.find()

The above will give you all the objects in the network collection
Find the object you want to add confidence to

db.network.update({"object":"gooogle.com"},{$set:{"confidence":"Low"}})

verify the changes with

db.network.find()
exit
$ exit

That should do it! Let me know if that doesn't work for some reason.

Awesome, will do. Thanks!


more！but Chinese

https://edu.aliyun.com/course/explore
http://www.zhaozhepublic.com/

Welcome to Free-Programming-Books!
https://help.github.com/articles/about-pull-requests/
Don't hesitate to ask questions; every contributor started with a first PR.


[IMP] travis: Add PyPi deploy

Adds compatibility for auto-deploy as introduced in LasLabs/python-quality-tools#3

Current coverage is 100% (diff: 100%)

Merging #6 into master will not change coverage

@@           master    #6   diff @@
===================================
  Files           4     4
  Lines          84    84
  Methods         0     0
  Messages        0     0
  Branches        3     3
===================================
  Hits           84    84
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update d53fe77...8710db7

Coverage remained the same at 100.0% when pulling 8710db75ca4e6d07aaedfcf096e394596d36fe2a on feature/master/travis-pypi into d53fe77751cdc7712ab4b56432e847c0daf2f06d on master.

Coverage remained the same at 100.0% when pulling 43eb1c04081562eed41864c7a628297b6bf4d3ae on feature/master/travis-pypi into d53fe77751cdc7712ab4b56432e847c0daf2f06d on master.

Coverage remained the same at 100.0% when pulling 2eab36ae619ed8c575c61258b29469bc047b3e13 on feature/master/travis-pypi into d53fe77751cdc7712ab4b56432e847c0daf2f06d on master.

Coverage remained the same at 100.0% when pulling 2023c293c477dd21cbbafe9943babd59b1745515 on feature/master/travis-pypi into d53fe77751cdc7712ab4b56432e847c0daf2f06d on master.

Coverage remained the same at 100.0% when pulling fd44203520a6a4f14e576bbfaaa5cf21e75f6067 on feature/master/travis-pypi into d53fe77751cdc7712ab4b56432e847c0daf2f06d on master.

Don't merge this - I need a test branch

Changes Unknown when pulling 7bcb8e1115d630f21ff73b40a1e83b6e4c49b325 on feature/master/travis-pypi into ** on master**.

Changes Unknown when pulling 2f05480ad0a712cce03c5c1c72d25ccbd00e4d6d on feature/master/travis-pypi into ** on master**.


Etcd could not connect after first node is removed from the cluster

I have a grid with initial_size=1. When I remove the first node  from the grid  etcd daemons on the remaining nodes fail to connect to the etcd cluster.

That is actually expected. When the grid initial-size is 1 only the first node run the etcd in member role. All the other nodes start in proxy mode.
We should probably document this more detailed how the initial-size effects the etcd clustering and what situations we can recover from.

Thank for information. I was forced to remove the first node due to failure of Digital Ocean droplet after resizing in their control panel :(
I managed to workaround this issue by updating node_number in the host_nodes mongo collection.

So you "forced" some other node to take place of the first one?

yes, and then recreated all kontena related containers on all nodes

cool workaround :)
I'll tag this as documentation as clearly there's some improvements needed on those regarding the etcd membership and caveats.

@jnummelin what do you think about starting one etcd per grid at kontena master?

Single etcd would create rather fragile failure point for multiple grids and it would need to be clustered for HA which in turn would mean more resource needs for master etc.. It's a bit of a rabbit hole. :) Also it would mean that there should be a secure communication path from agent to masters etcd which again would require quite much tuning. Current way enables rather easy comms path from agent to master as it requires only one websocket. So I think moving etcd to master side does not really make sense and would create more issues/challenges than benefits.

Documentation improved in #776


how to create a windows php app service

how to create a windows php app service through sdk?
I tried set windows_fx_version to PHP|7.3 and set php_version to 7.3, both could not work and the app service created is dotnet.
the rest api for app service is so confusing

(~> 2.44.0 ), This is still an issue. Any update on this..? - Thanks.

(~> 2.44.0 ), This is still an issue. Any update on this..? - Thanks.

any updates on this one? I having the same issue

I solved this by deploy the webapp using arm

I think I may have found a solution @lordisp @mleziva
set use_32_bit_worker_process to false.. https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/data-sources/app_service#use_32_bit_worker_process
This will set it to 64 and default to php. I think 32 bit may not be available for php


FirstOrDefaultAsync vs. SingleOrDefaultAsync

I find this advice to be bad.  If you expect a single entity, you should always use Single or SingleOrDefault semantics.  The performance gain of First is negligible if you have an EF query that is correct to begin with.  However, the benefits of code quality with the use of Single is much better.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8f592059-3328-88a8-5c6c-43121ac8a0a5
Version Independent ID: f8a63abf-824b-5b80-e03d-abcb2c162b95
Content: Razor Pages with EF Core in ASP.NET Core - CRUD - 2 of 8
Content Source: aspnetcore/data/ef-rp/crud.md
Product: aspnet-core
Technology: aspnetcore-data
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

That section was written by the EF team and is the expert consensus.


Code for generating CSV

Why is the py code for generating the CSV not available?

The code is not available but the methodology is publicly available for you to reproduce: http://covid19-projections.com/estimating-true-infections-revisited.


No longer able to set CORS headers for a single endpoint

Describe the bug
I have a POST endpoint that I access from a Firefox extension as well as my own website. To enable it to work from my Firefox extension, I set headers in my endpoint with
export const POST: RequestHandler = async ({ request, setHeaders }) => {
  const headers: { Vary: string; 'Access-Control-Allow-Origin'?: string } = { Vary: 'Origin' };
  const origin = request.headers.get('origin');
  // Allow Firefox extensions to hit this API
  if (origin?.startsWith('moz-extension://')) headers['Access-Control-Allow-Origin'] = origin;
  setHeaders(headers);

This allowed my Firefox extension to post to my server in previous versions of SvelteKit, but I now get 403 Forbidden when I try it and I no longer see the Access-Control-Allow-Origin header on the response.
When debugging, I see that I the handle function is called, but POST is never called. All the tutorials online recommend setting the headers in handle, but I want to control access control headers on an endpoint by endpoint basis (and don't want to write a bunch of matching logic in my handle function).
Reproduction
Impossible to reproduce in a single project, since you need to call the endpoint from a different place than the server
Logs
No response
System Info
Using adapter Node, SvelteKit 1.22.4

Severity
serious, but I can work around it
Additional Information
No response

This is now working with Sveltekit 2


Investigate XSD update following changes around resources

In short we want the definition of at least one resource between a cache and a template definition.
But thinking about it, I realise this may not be possible to express in XSD.
Still filing this to keep track of the conclusion for the future.

You want to enforce that the result of resolving each configuration against it's configured template contains at least one resource?  If so, I'm pretty sure that requires:

Indeed - closing as not resolving


Enable new full tensor bidirectional mode for all-gather

Interleaved tensors only need supporting at the moment

This was merged last week


Reports: Performance on a particular sample

Users should be able to view the performance on a particular sample.

sorted


Auto import SimpleDispatchInfo

Similar to how we recently brought common things like StorageValue, StorageMap,... into scope, I assume it is good to use also do the same with SimpleDispatchInfo as it is used everywhere.
Not sure if it is needed, some might say it is ambiguous. Hence, I only touched example, balances and system. If approved, will fix the rest of srml.

I'm against this. We should never include stuff into the scope automatically, as this maybe breaks some stuff. The Storage.. stuff are traits and we have done this move after we had SomeTrait as _ to not clash with any other import.

That does sound reasonable. It would also be an unused import if the user wants to use a custom weight type.


Enhance UI of Newsletter section

Enhance UI of Newsletter section in About Us page.

@ishitakapoor26 can you assign it to me

@ishitakapoor26 go ahead.  I would not able to do it. Got busy into some other stuff.

Hey, I'm interested in it! will enhance the UI by adding some widgets.

Hey, I'm interested in it! will enhance the UI by adding some widgets.

This issue is already assigned to @sreechand2002. Please look for some other issue or open a new issue.
Good Luck!

Can i contribute ?

Hey @ishitakapoor26  can I work on this issue?

@Pushti-R go ahead!

What changes are required @ishitakapoor26 ?

See UI of above image (Newsletter) doesn't look good. It is not matching the aqua and greenish colour scheme of the homepage. So, design the Newsletter section so that it looks good.
Hope you got what I wanted to convey!

Ok @Pushti-R thank you

@Pushti-R any update?

Hey @ishitakapoor26 I will finish it by tomorrow

hey @ishitakapoor26  should I make the about page responsive?

Hey @ishitakapoor26  kindly check my PR and review it


README fixes

Fix typo in options.header reference
Update Buffer() example because new Buffer() is deprecated

Thanks @oughter ! I wasn't sure about the Buffer one since that's not available on node v4, anyway it's fine to give an example assuming latest version (avoiding deprecated usages)


Add investor account update  page

This PR adds a page to the investors edit theirs profiles
AND refactors the investor creation form to use the same component for create and update the investor profile
Testing instructions
Acceptance criteria
There must be a way for ”Investors” to edit their account information
The functionality to edit Investor accounts will be at the Investor’s “My area”
These are the fields that can be edited: See reqs doc for specifications
There will be a way to validate the information entered in the fields
Errors are displayed if the information is incorrect
There will be a way to confirm or dismiss the edition of the account
Note: Save/cancel
The layout must comply with the designs defined at HeCo - Work in progress
Note: language is not editable
Any member of the account can edit
Edition of an account doesn’t have an impact on the account’s status
Tracking
LET-608

@barbara-chaves how can i test it from de user experience?

@barbara-chaves how can i test it from de user experience?

You have to login as a Investor or Project developer and go to
dashboard/account-information


fix: getIpFamily - do not expect specific error for clients without IPv6

[x] Ready for review
[x] Linked to Jira ticket - https://snyksec.atlassian.net/browse/ROAD-643

What does this PR do?
This PR is a replacement for previous PR to fix the regression for IPv6 clients. We've noticed that some of the clients who don't have full IPv6 supports started to authenticate using IPv6 which broke their VS Code extension.
Some users encountered ENETUNREACH error instead of EADDRNOTAVAIL as wrongly assumed in the previous fix PR. Thus we shouldn't rely on specific error, rather on an error. This is how it was before the refactoring around http took place and is consistent with Snyk CLI code.
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
This fixes the following issues:
https://snyk.slack.com/archives/C026PS65XA8/p1642092098003500
https://snyk.slack.com/archives/C01FA88CUU9/p1641979366003300?thread_ts=1641978929.003100&cid=C01FA88CUU9
https://github.com/snyk/vscode-extension/issues/132 🤞
Screenshots
Additional questions

:tada: This PR is included in version 4.5.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Meeting with Giuliano

[x] Arrange meeting
[x] Populate google doc
https://docs.google.com/document/d/1R4jfoql_eIsiQb-cfivA9bmKOqyXKU58NDOBjdPSIDI/edit

Tasks done - people can still populate the googledoc though, but I think it contains enough for the meeting now


Update logging.

The run-logs generated are too long now could probably remove the info call on each subreddit request, move it to a single call for all subreddits listed. This would work well with #7.

The date parameter would also be nice to see on the logs.

Merged for next testing release.


GitHub notifications

Hey there.
I couldn't get the Github API to work with a simple WebsiteAgent so I made this! Hopefully it's straight forward enough.

I noticed a few sloppy things. Will fix asap :)

All right then!

Hi @joenas,
this looks like a very useful Agent. As Huginn currently does not have many active maintainers, every new Agent adds a maintenance burden on us, even though I love to have more Agents available in Huginn. We currently do not have a clear guideline which Agents can/should be added (#2012), so I would like to ask you for some patience. If you want to make the Agent available for everyone immediately you could create a Agent Gem.

That's reasonable! As this isn't incredibly useful I'd say a gem makes sense 😊

Agent gem done: https://github.com/joenas/huginn_github_notifications_agent
Feel free to have a look 😄

Nice!

And it works because I just got a notification! :P


Label discordant samples

Fixes #130. Adds sample names to the output of plot_sexcheck_pca().

This PR adds labels to the plot_sexcheck_pca function, but I think you have identify_outliers plotted above. If yes, can you open an issue to track the issues with color and point types?

Looks alright!