[BUG] batch_size >= 1 broken due to lateset llama3.1 Transformer changes

Latest transformers v4.43.0 released today broken batch_size >= 1 for quantization. We need to fix this asap.
Traceback (most recent call last):
  File "/root/python/llama3/8b_instruct.py", line 91, in <module>
    quant_log = model.quantize(calibration_dataset, batch_size=32)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/python/GPTQModel/gptqmodel/models/base.py", line 216, in quantize
    calibration_dataset = self._prepare_dataset_for_quantization(calibration_dataset, batch_size)
                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/python/GPTQModel/gptqmodel/models/base.py", line 143, in _prepare_dataset_for_quantization
    new_calibration_dataset_batched = [
                                      ^
  File "/root/python/GPTQModel/gptqmodel/models/base.py", line 144, in <listcomp>
    collate_data(new_calibration_dataset[start: start + batch_size], pad_token_id)
  File "/root//python/GPTQModel/gptqmodel/utils/data.py", line 158, in collate_data
    input_ids_blocks[i] = pad_block(input_ids_blocks[i], torch.ones((block_bsz, pad_num)) * pad_token_id)
                                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
TypeError: only integer tensors of a single element can be converted to an index

temp fix patched in https://github.com/ModelCloud/GPTQModel/pull/279
real fix coming...

Core cause of bug is llama 3.1 has:

pad token defined in tokenizer map but not set in tokenizer config. strange
eos token used as fallback to pad token but eos token id for llalma 3.1 instruct is an array (multiple possible eos tokens)

2 is a bug in GPTQModel and 1 is a semi-bug in llama 3.1 not correctly setting pad token. Also strange is that the pad token string is <|finetune_right_pad_id|> since I thought pad token really doesn't care about left/right since they are ignored in attention_mask. Strange. Some models don't even use pad token and just default back to unk.


Open Source Collective (OSC)

Working group focusing on showcasing, supporting, enabling, and sustaining OSC projects and contributors.
Goals
Build open collective platform solutions with members of our community

[ ] Contribute to priority OSC projects, programs and tasks
[ ] Propose, contribute, extend, revive secondary OSC projects and programs
[ ] Help prioritize integration options for OC fundraising that lower the barriers for projects to fundraising using the platform.

Develop and highlight opportunities for open source projects to help themselves

[ ] Create (and aggregate) more workshops, guides, training materials, blog posts, podcasts, case studies, and anything else that will help collectives sustain
[ ] Partner with organizations like Sustain, Open Source Design, Write The Docs and The Good Docs project to amplify their impact

Help support and sustain OSC projects and open source contributors

[ ] Launch offers and needs marketplace/job board and partner program.
[ ] Create fundraising opportunities through FundOSS, Funds for Open Source, EthicalAds, the Open Collective bounty program, and other platforms and programs.
[ ] Provide training and mentoring through partnerships with Google Summer of Code, Outreachy, Major League Hacking, and OSC projects themselves.

Team

To do

[ ] Guage interest from OSC team
[ ] Suggest they set up a project on https://opencollective.com/opensource and give a couple of community members the admin role
[ ] Ask interested community members to join the team
[ ] Discuss/determine/document process for contributing to OSC
[ ] Discuss/determine/document goals and strategy with OSC
[ ] Discuss/determine/document contributor compensation structure

Partner with organizations like Sustain, Open Source Design, Write The Docs and The Good Docs project to amplify their impact

We might consider Open Web Docs here as well.

@schalkneethling Agreed!
That part of outline was copied from Ben's response to my urgent call to action (I recommend all team members skim through at some point) in the #opensource/OSC channel going back almost a year. I'm going to leave his full reply below as it provides some context around my goal (enabling community), Ben's priority (focusing on OSC), what they would support (projects with clear, measurable goals), and how the collective (that is now https://opencollective.com/community-contributor-group) came to exist.

hey  @gusaus sorry for not responding sooner. I read through everything here and I’ll just outline, in general what our approach is:

To build solutions with members of our community
To develop and highlight opportunities for our projects to help themselves
To partner with organisations like Open Source Deign, Write The Docs and The Good Docs project to amplify their impact

That is to say while I’m happy to subsidise efforts (like the workshops) temporarily ultimately we need projects to take the lead and to help themselves. Financially it doesn’t work if Open Source Collective is paying for the community to support itself on 10% of funds raised (our fees) but if we can see how some investment now might create a sustainable programme in the future we’ll do it.
So in answer to your ideas about creating self-governed working groups, yes, go do it and if you’ve got a clear set of goals that we can get behind we’ll support you with some money to get you started.
On everything else: Many of the ideas you’ve highlighted are things that we’re working toward (maybe not quickly enough, but we’re still young as a team and we’re getting better). For example:

We’ve overhauled our documentation and are building our guides for projects based on the content delivered in workshops
We’ll (if Sumana a is open to it) be continuing the workshops, and will continue to subsidise them for participants (but will be asking for a contribution from projects themselves)
We’re working on the platform to better reflect what projects are spending money on so that we can them work with funders to help them make the case to grow their support.
We will be providing a way to include non-financial contributors in contributor lists, to bring everyone into the circle.

On the funding side, and I think i’ve said this before, I think FundOSS is the wrong format for a fundraising campaign. I don’t like the competitive nature of having a funding pool which is split based on the success of individual projects to campaign well. So that won’t be coming back without some fundamental changes made.
That said we will be working on a campaign generator for FOSS contributor funds, elements of which we can and will repurpose. And of course we’re building the infrastructure that’ll enable us to relaunch backyourstack.com which I must prefer as a mode of supporting all the software you depend upon.

Again this was almost a year ago and OSC has yet to provide 'any' financial support, or even much guidance beyond a few comments you'll see in this OSC Working group - Google doc
The thread will tell a story about what did/didn't happen from there. You'll also see how other community members have shown interest but haven't been able to contribute due to lack of time.
With the core team we have onboard now - if we can tighten up the goals, priorities, benefits in the Google doc, I'm confident OSC (and other open source stakeholders) would sponsor a working group in that channel.


Update README and out-of-date docs

As part of our effort to put all docs on kubeflow.org website, I made the following changes to the README and docs:

Move adopters, roadmap, and contributing guide to the root directory.
Remove tfjob and testing guides from docs, since they are out-of-date and not maintained.
I will create an issue to move Prometheus monitoring docs to the website.
For the release and proposals @kubeflow/wg-training-leads do we want to move them to the root as well ?

I moved existing proposals under appropriate KEP directory.

For the README I made these updates

Update description, similar to the website.
Refer to the Kubeflow installation. @kubeflow/wg-training-leads Do we want to keep installation steps in the README or we can just link users to the website guide ?
Remove the very old version < 1.4 release of Training Operator, since we migrated to the unified operator 3 years ago.
Remove all-in-one proposal from the README.

/hold for review
cc @kubeflow/wg-training-leads @franciscojavierarceo @StefanoFioravanzo @hbelmiro Please let me know what do you think.

Thanks for the review!
/hold cancel


Error on incremental UnhandledPromiseRejectionWarning v0.5.15

(node:47653) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): RangeError: Invalid string length
(node:47653) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

RangeError: Invalid string length means a string is being created that is too big (>130MB) normally from JSON.stringify or Array.join (or even '' + "). By @SebT and @stereoscott's description it sounds like an error is being serialized or written to console that may not recurse but refers to a tree of objects that refer to each other, using less memory in that shape, but being turned into a string inflate to a size big enough to cause this error.
I'll try running and intentionally inserting errors. If any of you can figure out a minimal reproduction that'd help.

I met the same issue.

It usually happens when my code doesn't compile then fix it, then re-insert an error then fix it

It would be great if we have a solution for it. thanks

I bumped into this one, and instead of a me too comment, I thought this could help (removed some paths):
(node:35617) SyntaxError: Unexpected token c in JSON at position 7
  at JSON.parse (<anonymous>:null:null)
  at Readable.<anonymous> (hard-source-webpack-plugin/lib/hard-source-append-serializer.js:427:43)
  at emitOne (events.js:116:13)
  at Readable.emit (events.js:211:7)
  at addChunk (_stream_readable.js:263:12)
  at readableAddChunk (_stream_readable.js:250:11)
  at Readable.push (_stream_readable.js:208:10)
  at hard-source-webpack-plugin/lib/hard-source-append-serializer.js:232:13
  at <anonymous>:null:null

Inside hard-source-append-serializer.js, I found a few Promises that don't catch errors. A particular one, _readTable picked my curiosity. Simply adding
.catch(error => console.log(error))

solves lets grunt watch continue its thing. The exception UnhandledPromiseRejectionWarning still throws, and the build still fails, but now grunt will resume the watch task. Before it just hang and had to be manually shut down.
So I started adding .catch bits to every promise that didn't have them, and UnhandledPromiseRejectionWarning just went away. Now grunt simply aborts the build “due to warnings” and continues business as usual.
I know this is a little obvious: catching errors on Promises gets rid of a problem about not catching errors on Promises. But maybe this sheds some light on the issue.
Also, in my particular use case we need to run webpack via grunt, so maybe that's part of the issue. Running webpack by itself doesn't throw the warning, so it could be more of an issue for people using grunt and/or grunt-webpack.
Thanks for the hard work on the plugin, it saves us quite some time when building in CI.

I'm running into the same issue :/ have to disable the plugin until this is solved.

@MarkLyck running webpack via [grunt-shell](https://npmjs.com/package/grunt-shell) solves the problem for now, without disabling this plugin.

Simple workaround is to delete the node_modules and re-run npm install.

I have the same problem, and when I try to restart webpack, I got this error:
TypeError: Cannot read property 'indexOf' of undefined
    at splitQuery (/Users/feel-joy/Code/stylewe/node_modules/loader-runner/lib/LoaderRunner.js:19:13)
    at getContext (/Users/feel-joy/Code/stylewe/node_modules/loader-runner/lib/LoaderRunner.js:238:17)
    at new NormalModule (/Users/feel-joy/Code/stylewe/node_modules/webpack/lib/NormalModule.js:66:18)
    at Object.thaw (/Users/feel-joy/Code/stylewe/node_modules/hard-source-webpack-plugin/lib/util/serial.js:199:12)
    at Object.thaw (/Users/feel-joy/Code/stylewe/node_modules/hard-source-webpack-plugin/lib/util/serial.js:216:25)
    at Compiler.pluginCompat.tap (/Users/feel-joy/Code/stylewe/node_modules/hard-source-webpack-plugin/lib/TransformNormalModulePlugin.js:654:30)
    at Compiler.applyPluginsWaterfall (/Users/feel-joy/Code/stylewe/node_modules/tapable/lib/Tapable.js:92:24)
    at Object.exports.call (/Users/feel-joy/Code/stylewe/node_modules/hard-source-webpack-plugin/lib/util/plugin-compat.js:175:38)
    at thaw (/Users/feel-joy/Code/stylewe/node_modules/hard-source-webpack-plugin/lib/SystemArchetype.js:126:29)
    at fetch (/Users/feel-joy/Code/stylewe/node_modules/hard-source-webpack-plugin/lib/SystemArchetype.js:173:16)

@kxpvcr Please see #issues/423


Create correct Hdas from Subnetworks, keeping Parms, Outputs and Inputs.

Changelog Description
This PR automatically detects how many outputs are present in an subnet and how many inputs are connected to any node. it also moves all the parms from a subnet over to the generated hda.
the Parms, inputs and outputs are kept intact when generating an HDA from an Subnet by copy pasting them over.

[ ] test if some expressions might get broken by copy pasting them.

Additional review information
Old Behavior

when creating an HDA from an Subnet the outputs of the hda will be set to 1 and the inputs to 0.
when creating an HDA from a Subnet the parms will be deleted.
if you change the inputs of the HDA from the type definition the inputs will survive into the published hda

New Behavior

check the indirect inputs of the selected subnet and check if those inputs have a node connected to them. we will then count the subnet inputs that have a node connected (inside the subnet not tpo layer) and set the max inputs of the HDA.
we then collect the Output nodes and check if there index is unique (Houdini dose not allow you to create multiple output nodes with the same index but you could create them and then create a HDA this would then internally error.) from this list we then set the HDA outps (we need to set the HDA outputs in there HDA definition after the creation because Houindi dose not offer a parameter in the .CreateHda() function from hou.Node class
we copy the parameter template from the source subnet into a tempVar before we create the hda from it. then we simply add the template onto the hda definition.

Testing notes:

Create a subnet add a few output nodes and connect what ever you want to the input nodes of the subnet(internally not the external ones)
Ayon -> Create -> Create HDA
check if all your connections still function correctly and if the right inputs outputs and prams exist. also check if relative parm references and parm expressions still work as expected.

extra points:

create an hda from a selection of nodes and check if this works.

Is it correct that this draft PR is ONLY code style changes currently - or what am I missing?

i always create a PR right away, this is how GitLab works and i believe its simply better in all ways.
also i forgot to push the changes yesterday.

Hello,
I've created another PR https://github.com/ynput/ayon-houdini/pull/172 based on the changes on this PR.

closing this PR in favor of https://github.com/ynput/ayon-houdini/pull/172


Reorder pipeline so that python: settings load earlier

This should fix the problem with things where you have a user configuration file that looks like this:
``` yaml $(python)
python:
  azure-arm: true
  license-header: MICROSOFT_MIT_NO_VERSION
  payload-flattening-threshold: 2
```

(ie https://github.com/Azure/autorest.modelerfour/issues/182)
The reason this changes, is that in v2 generators, things like flattening were handled by the common library, and actually happened during the execution of the python generator, not in the modeler stage. Things that happened during the python generator, inherited configuration from the python:  settings section.
Now, since the modelerfour/flattener handles that before the language-specific generator runs, the settings would either need to be changed to:
``` yaml $(python)
azure-arm: true
license-header: MICROSOFT_MIT_NO_VERSION
payload-flattening-threshold: 2
```

or we make the modelerfour inherit the python task, and cascade settings from there.
Either way is ok (the above is still restricted to when --python is specified, since the guard is in place, but this patch makes it so that the user configuration files don't have to be changed.

We get super redondant in the Python world, between the yaml block condition + yaml indentation + readme.python.md :p


Update version of azure-communication-common in rooms POM

Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[X] The pull request does not introduce [breaking changes]
[X] CHANGELOG is updated for new features, bug fixes or other significant changes.
[X] I have read the contribution guidelines.

General Guidelines and Best Practices

[X] Title of the pull request is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

/check-enforcer evaluate

/check-enforcer evaluate

/check-enforcer override

/check-enforcer evaluate

/azp run java - azure-communication-rooms - ci

/azp run java - azure-communication-rooms

This cannot be merged as 1.2.0 does not include the change ACS Rooms needs in the ACS Common module-info file. I think we can release a 1.2.1 patch for ACS Common to include this. We could also release a new beta version like 1.3.0-beta.1 if we feel like releasing a new patch is too complicated, as we have already released a couple libraries that depend on ACS Common (ACS SMS and ACS PhoneNumbers).

Abandoning this pull request in favor of https://github.com/Azure/azure-sdk-for-java/pull/30419


I'm having trouble in signing into my Firefox account because the Android device information is completely different with my girlfriends FIrefox Plug-ins for the Firefox browser, that I beliecve is not my Firefox Browser becuase there is no way to troubleshoot unless I sign into my Firefox account with all of my infiration of a previous address. Because of this, my Firefox Brouser that I believe is the reason that their is knowone in Lake George. Like a guost town.

I'm trying to change the email daddress for my Firefox Browser now that the Mistics had joined with the Skeksies to form an eternal being.
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bfe690a0-e17d-4a9c-a107-7189e29fe815
Version Independent ID: 87bbbd28-a5a0-76dd-468d-52c4a930f8cd
Content: Walkthrough: Creating an N-Tier Data Application - Visual Studio
Content Source: docs/data-tools/walkthrough-creating-an-n-tier-data-application.md
Product: visual-studio-windows
Technology: vs-data-tools
GitHub Login: @jillre
Microsoft Alias: jillfra

@drexer1 -- GUY, thanks for your feedback; we appreciate it. To make sure we have all the information needed to triage your issue, please provide more context around the general task.

@WilliamAntonRohm why entertain this nonsense about a rejoining of skeksis and urRu into the being that was split to make those two races? We know it will never happen, the Gelflings stories tell us so!
Seriously though, this ramble about a Firefox password and marginally entertaining 40 year old Muppet sci-fi is getting too much life. Either OP is really lost (and probably won't find their way back here), are screwing with you, or are experiencing some Timothy Leary kind of "good times".

:^)


Upgrade to ktfmt 0.41

And run spotlessApply to apply its updated rules to the code base.

Current dependencies on/for this PR:

main

PR #664   👈

This comment was auto-generated by Graphite.

Graphite Merge Job
Current status: 🔄 Waiting for checks to pass
This pull request is currently waiting for CI and mergeability checks to pass before being merged.
This comment was auto-generated by Graphite.

Job Reference: P9g3FMXHyAMUIdcBxCfT


BigQuery: problem with spaces in column names

also see OHDSI/SqlRender#313
SqlRender doesn't translate the space in a column name to an underscore,
In BigQuery: Fields must contain only letters, numbers, and underscores, start with a letter or underscore, and be at most 128 characters long.
Solution: replace the spaces with underscores
DBMS:
bigquery
Error:
java.sql.SQLException: [Simba]BigQueryJDBCDriver Error executing query job. Message: Syntax error: Expected ")" but got identifier "Name" at [4:35]
SQL:
-- top 25 mapped conditions
select *
from (
select row_number() over(order by COUNT(condition_occurrence_id) desc) as row_num,
cr.concept_name as Concept Name,
floor((COUNT(condition_occurrence_id)+99)/100)*100 as jdphl2hpRecords,
floor((COUNT(distinct person_id)+99)/100)*100 as jdphl2hpSubjects
from omop_zidder.condition_occurrence c
join omop_zidder.concept cr
on c.condition_concept_id = cr.concept_id
where c. condition_concept_id != 0
group by cr.concept_name
having COUNT(condition_occurrence_id)>5
) z
where z.row_num <= 25
order by z.row_num
R version:
R version 4.2.2 Patched (2022-11-10 r83330)
Platform:
x86_64-pc-linux-gnu
Attached base packages:
stats
graphics
grDevices
utils
datasets
methods
base

Other attached packages:
CdmInspection (1.1.0)
SqlRender (1.11.0)
ParallelLogger (3.1.0)
ROhdsiWebApi (1.3.1)
DatabaseConnector (5.1.0)

Thanks for opening this issue, I did not realise the use of spaces in column aliases was not according to HADES guidelines. The aliases in sql are used here for easy pretty rendering in the report, to avoid having to do this in R. It seems we are not getting around that.


Storybook Theme Switcher

Purpose

Globally wrap all stories in Theme decorator.
Add toggle for light/dark theme

Coverage increased (+0.04%) to 32.216% when pulling 9d7963b085a3720a46e344c088703f13dbf6c42c on rjstires:M3-storybook-theme-poc into 765885e3e7b836a4de7705f541bcbe2aac83b89d on linode:develop.

@nwisnewski I wonder if storyshots will automatically take screenshots of the dark theme toggled components or if some custom configuration has to be made. Making a ticket for it now

We seem to have lost the action logger?


feat(composer-extension): embed mode

copilot:all

Current dependencies on/for this PR:

main

PR #3171   👈

This comment was auto-generated by Graphite.


Fixes goal vector for JumperHard example

Resolves issue #25

https://github.com/edbeeching/godot_rl_agents_examples/blob/b8470d6129a724bfc4a3de25edec8d1c7f33e671/examples/JumperHard/AIController3D.gd#L62
Not directly relevant to this PR, but we may not need this anymore in the example as the reward should already be reset from sync:
https://github.com/edbeeching/godot_rl_agents_examples/blob/b8470d6129a724bfc4a3de25edec8d1c7f33e671/examples/JumperHard/addons/godot_rl_agents/sync.gd#L315-L320


Switch from CrossVersion.full/"org.scala-lang" to CrossVersion.patch/scalaOrganization.value

Fixes #322.
Thanks!

Codecov Report

Merging #323 into master will decrease coverage by -0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
- Coverage   86.28%   86.23%   -0.05%
==========================================
  Files         309      309
  Lines        8193     8193
  Branches     1624     1624
==========================================
- Hits         7069     7065       -4
- Misses       1124     1128       +4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e69e541...3620b0b. Read the comment docs.

Hi, can you tell me what should I do with the codecov? Thanks!

Thanks @rilut,
Don't worry about code coverage, since this is a minor configuration change.
Cheers,


trigger action at begin of async main alias action

My aliased actions (main process) are async and need some time to fulfill. The state change occurs when the action has fulfilled, and I am fine with that of course, but I would also like to have an additional state change at the begin of such an async action (for progress indicators and disabling buttons while the main async action is executing). Right now I am just using an additional sync action for that. Does there exist a way to bake in such an additional action into the alias action ? That would reduce boilerplate code for this type of usage pattern.

There's different approaches to this.
https://github.com/acdlite/redux-promise (the one I'm using in timesheets) only triggers an action once the promise resolves (or rejects), making optimistic updates, loading messages etc. difficult. The way we worked around this in an unrelated project is to always assume a resource to be loading until it resolves, e.g.:
// reducer
const initialState = {
  userData: {},
  isFetched: false,
};

function myReducer(state = initialState, action) {
  switch (action.type) {
    case FETCH_USER: {
      // fall back to previous state on error
      if (action.error) return {...state, isFetched: true});

      return {...state, ...action.payload, isFetched: true};
    }

    default:
      return state;
  }
}

export default myReducer;

Also check out the discussions https://github.com/acdlite/redux-promise/issues/12 and https://github.com/acdlite/flux-standard-action/issues/7.
There's also https://github.com/pburtchaell/redux-promise-middleware, which does seem to trigger separate actions during loading, but I've never used that, nor tested it against electron-redux (but can't see why it wouldn't work).

Looks like npm i -S<EMAIL_ADDRESS>has support for optimistic updates as discussed

Thanks a lot. redux-promise-middleware looks interesting or "promsing", will give it a try later and report back here. About<EMAIL_ADDRESS>is that the sequence branch ? If so, little development there lately, but I might be mistaken.

Ups, yes, it is the sequence branch. Will try that as well.

It's actually in master. I wouldn't judge redux-promise by its activity, though. The Promise interface has been stable for a few years now, so there's not much reason for change. If you do end up playing with redux-promise-middleware, please let me know how it goes.
Out of curiosity, what are you building?

I just tried<EMAIL_ADDRESS>It doesn't work (yet). On the main thread, the promise actions created with createAliasedAction look as expected, but they do not show up on the renderer thread. I guess, because the format of the actions now is a bit different, two actions in sequence. If i use simple, non-promise actions, the continue to work as before. Will need to look closer into it later, but maybe you have right away an explanation why they do not get replayed on renderer.
About what I am building, it is static site generator, to be used by non-technical folks, therefore all baked into electron and only a Prosemirror editor exposed to the user. But it is not usable yet ...

No, that seems strange. I've added some debugging to the middleware in the redux-thunk ticket. If you run your electron app with DEBUG=* npm run dev (for the main process) and run localStorage.setItem('debug', '*') in your renderer's devtools, do you get any warnings from electron-redux?
P.S.: Substitute '*' with 'electron-redux:*' to reduce noise.

ok, here is what I get at the main process:
Thu, 03 Nov 2016 10:58:33 GMT electron-redux:validateAction Action not FSA-compliant { type: 'GET_PROJECTS',
   payload: undefined,
   sequence: { type: 'start', id: '2' } }
 // console.log(action):
 { type: 'GET_PROJECTS',
   payload: undefined,
   sequence: { type: 'start', id: '2' } }
 action @ 17:58:33.193 GET_PROJECTS
 —— log end ——
[1] Thu, 03 Nov 2016 10:58:33 GMT electron-redux:validateAction Action not FSA-compliant { type: 'GET_PROJECTS',
   payload:
    [ { id: 'goooo', type: 'project', title: 'Goooo' },
      { id: 'third', type: 'project', title: 'Third' } ],
   sequence: { type: 'next', id: '2' } }
 // console.log(action):
 { type: 'GET_PROJECTS',
   payload:
    [ { id: 'goooo', type: 'project', title: 'Goooo' },
      { id: 'third', type: 'project', title: 'Third' } ],
   sequence: { type: 'next', id: '2' } }
 action @ 17:58:33.198 GET_PROJECTS

I guess, this explains it: validateAction is too picky! But would it work without validateAction ?After all, this comes from the people behind the FSA definition (I think). Or am I using it in a wrong way ?

Yeah, looks like sequence was implemented as a top-level parameter: https://github.com/acdlite/redux-promise/blob/sequence/src/index.js#L22-L25
That does obviously break FSA specs (which is slightly surprising), and hence validation doesn't pass.
Let me know how you get along with redux-promise-middleware

after adding redux-promise-middleware, no actions got dispatched anymore, neither promises, nor non-promises. And nothing got logged. No idea why.

I've played around with redux-promise-middleware in https://github.com/hardchor/timesheets/pull/211/commits/596ecc13bf52037c9418bd8c7e32c4bbbbc87f8c and it works fine, but there are a few gotchas:

You can't dispatch un-aliased promises to main (because they get sent via IPC and Promises can't be stringified)
If you need local promises (i.e. ones that only live in a single renderer), you need to set meta.scope = 'local' (https://github.com/hardchor/electron-redux#local-actions-renderer-process)

ok, now I see what I did wrong, registered the middleware as promise, but in your code it is as promise(), so I will give it another try later.

It all works now perfectly with the promise middleware, thanks again, gonna close this.


Helm Hurry not adding time in some situations

MrTKettle — 02/20/2023 9:35 PM
So I just tried my first helm hurry seed and had a couple issues with the timer.

Buying fairies and crowns in shops did not add time to my clock. However, time was added normally when I collected them in the overworld.
Blueprints didn't add any time, either when I collected them or when I turned them in (not sure when it's supposed to, but it didn't at either time). The only time that got added from snide is the time for the GBs from turn ins.
Lrauq — 02/20/2023 9:38 PM
i assume your settings were set up such that you should have been getting time from those items?
MrTKettle — 02/20/2023 9:40 PM
Yes, the blueprints were my main focus early on because I set them to give me 2 minutes. And like I said, fairies and crowns gave me time in the overworld, just not in shops.
Lrauq — 02/20/2023 9:41 PM
blueprint time gain should be on blueprint pickup, not turn in
MrTKettle — 02/20/2023 9:41 PM
Didn't give me time on pickup, as I stated
Lrauq — 02/20/2023 9:41 PM
right, just to clarify
MrTKettle — 02/20/2023 9:42 PM
At first I thought I just wasn't paying attention, but I knew I was losing too much time so then I started paying close attention when I grabbed blueprints
Lrauq — 02/20/2023 9:43 PM
good catch
MrTKettle — 02/20/2023 9:44 PM
Thanks, I assumed the fairies had to do with them just recently being added to the item pool and so maybe an issue with how they are implemented in the shops.
CornCobx0 — 02/20/2023 11:45 PM
also to add to what mrtkettle said, i also just did a helm hurry seed, and medals, moves and blueprints were also not adding time when i was buying them from shops. pretty much anything that wasn't a GB.
and balloons also were not adding time for CBs

Summary:

No time gain in shops
No time gain on BP pickup
No time gain on BP turn-in
Balloons not adding time for CBs


Disable swagger when in test mode for compiler(Unittest/Specs2) [Play framework Java/Scala]

From @ghost on June 11, 2014 15:26
Is it possible to make swagger disable if you run unittests in for example Specs2 so the tests will run a lot faster?
Copied from original issue: swagger-api/swagger-core#594

From @fehguy on June 11, 2014 20:42
Can you elaborate more?

From @fehguy on June 12, 2014 16:18
um, no, i'm quite serious.  are you talking about building swagger-core, your sample project, an integration test, a unit test, or what?

From @ghost on June 19, 2014 9:26
Sorry for my later response. I've been very busy lately.
If you run Play it starts with a "mode". This can be Dev/Test/Prod. Test mode wil be triggered if you run Unittests, intergration test or a Specs2(plugin for unit specifications and acceptance specifications). In test mode there is no need for swagger. But it will be triggered and the tests will be slowed down by swagger.
I Have managed to interupt swagger from running in testmode by adding "swagger.api.basepath=nonvalidurl" in the config file. This is a really dirty solution. i know :(

From @ghost on June 12, 2014 8:8
In what way are you asking this? Hope its not sarcastic. Because i'm just trying to make myself as clear as possible.

From @mauhiz on October 3, 2014 4:59
How slower does Swagger make things, exactly? Is scanning the annotations the slow part?

From @lammel on December 1, 2014 11:23
We are facing the same issue here. The annotation scanning results in a slowdown of our suite with 1000 tests considerable (running over 20min instead of 2min). It seems laso the swagger plugin initialization is getting slower and slower as the tests progress.
If there is a sane way to disable swagger doing the same scanning over and over for the tests any hints would be greatly appreciated.

@lammel - can you give a few more details about your application? Is it servlet, jax-rs, play? How is swagger-core configured?

If it's Play then perhaps @fehguy will be able to assist. I'm not that familiar with the Play integration.

From @lammel on December 1, 2014 12:26
Thanks, let's see if @fehguy has some time to spare for an answer. I just tried with swagger-play2 1.3.11. I'm still seeing a notable slowdown of plugin initialization after some tests (pretty fast initially at 160ms and slows down to approx 600ms after 50 tests and keeps on growing up to 2-3 seconds).
Memory has been checked (using jvisualvm), still memory free and permgen is also fine (both having approx 40% free).
Seems like computation requires more and more effort with each application init for testing.

From @lammel on December 1, 2014 11:47
It's a play 2.3 application currently with Scala 2.10 using "com.wordnik" %% "swagger-play2" % "1.3.10".
Tests do initialize the application afresh for most of the tests, so the scanning occurs pretty often.
We basically followed the README, just adding the routes to api-docs and having currently 2 classes with annotations (about 20 routes).
No additional configuration for swagger-core. To which kind of configuration are you refering?

From @fehguy on December 3, 2014 6:9
Hi, the SwaggerPlugin.scala is calling onStop(), which is clearing the cache.  My guess is that the slow down is due to garbage being generated and not cleaned up off the heap?
  override def onStop() {
    ApiListingCache.cache = None
    Logger("swagger").info("Plugin - stopped");
  }

From @lammel on December 25, 2014 22:49
Ah, great, thanks! Should have looked more into FakeApplication instead of messing with the sbt plugin config. Using withoutPlugins for FakeApplikation works great and is looks to me like the right solution anyway.
If it should be documented I can provide a pull request for the text blurb. Any specific place where we should put that (e.g. readme)?
This should probably be documented, is there a place to put this (e.g. readme)?

From @fehguy on December 23, 2014 22:49
We'll investigate and see if this can be done in the 1.5.0-M3 release.

From @mikalveli on December 24, 2014 4:8
I actually had this same problem today using the swagger-play2 plugin. In Play, you can disable plugins when using fakeApplication(). Here is the signature of the method:
public static FakeApplication fakeApplication(Map<String, ? extends Object> additionalConfiguration, List<String> additionalPlugins, List<String> withoutPlugins)

So in my particular case I'm using this call for each of my integration tests:
running(testServer(3333, fakeApplication(InMemoryDatabase.inMemoryDatabase(), new ArrayList<String>(), Arrays.asList("play.modules.swagger.SwaggerPlugin"))), HTMLUNIT, browser -> {

From @lammel on December 4, 2014 16:14
Ok, so I would need to patch (comment out) that to verify. I see if I get around to doing that.

@fehguy - How is this related to the 1.5.X releases?

I would be curious if this is any better/worse for swagger-play 1.5.0 that was just released for Play 2.4. It parses information from the routes file and does less scanning of annotations, which was indicated to be the slow part.

Just upgraded to 1.5.2. It is way better than before. Still tests are running twice as long when swagger is enabled so I chose again to disable it for now in tests.
We are running Play 2.4 with DI now, so we disable by configuring the fake application with "play.modules.disabled" to include "play.modules.swagger.SwaggerModule".


arch: arm: Remove priv_stack_size field form _thread_arch

This PR removes the priv_stack_size field from the _thread_arch on arm architecture as there is no code using value stored in this variable.

Codecov Report

Merging #12014 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #12014   +/-   ##
=======================================
  Coverage   48.13%   48.13%
=======================================
  Files         281      281
  Lines       43425    43425
  Branches    10406    10406
=======================================
  Hits        20902    20902
  Misses      18368    18368
  Partials     4155     4155

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e21d7cc...0c588d0. Read the comment docs.

@ioannisg:
This is the beginning of cleanup I promised you :)
The arc and xtensa went as separate PR (https://github.com/zephyrproject-rtos/zephyr/pull/12015 and https://github.com/zephyrproject-rtos/zephyr/pull/12009) as I am not touched common part so far.


Fixed issue with multiple polling queries

Since we were using a single timer reference, there were polling leaks when we had multiple polling queries - see #248
This changeset should fix that issue and introduces a unit test that used to fail but now doesn't.
TODO:

[x] Update CHANGELOG.md with your change
[x] Make sure all of the significant new logic is covered by tests
[x] Rebase your changes on master so that they can be merged easily
[x] Make sure all tests and linter rules pass

This is great! Just wondering if we can cut the time necessary for the test.

@Poincare this is a great improvement

@Poincare Can you rebase this? As soon as it's rebased, we can merge it, and then rebase & merge #251
Awesome to see so many great PRs this week!

Rebased.


[Feature] remove distutils dependency and enable 3.12 support

Description
The current use of deprecated distutils is fairly limited and is the last reason for tensordict being incompatible with python 3.12.
This PR brings distutils' implementation of strtobool to tensordict/utils.py.
Note: Although distutils is not anymore required as a runtime dependency and tensordict now being compatible with python 3.12, there remains a reference to distutils.command.clean in setup.py.
Motivation and Context
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

[ ] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes
What types of changes does your code introduce? Remove all that do not apply:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds core functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation (update in the documentation)
[ ] Example (update in the folder of examples)

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[ ] I have read the CONTRIBUTION guide (required)
[ ] My change requires a change to the documentation.
[ ] I have updated the tests accordingly (required for a bug fix or a new feature).
[ ] I have updated the documentation accordingly.

Looks like this is not quite enough:
...
FAILED test/test_utils.py::test_remove_duplicates_2dims[device0--1] - NameError: name 'ftdim' is not defined
= 18958 failed, 6429 passed, 4721 skipped, 1 deselected, 193 warnings in 476.65s (0:07:56) =

And the end of a single backtrace:
  File "/nix/store/aj1y1bqpi6670k0nppnpxw2q5sgv4bka-python3.12-tensordict-0.4.0/lib/python3.12/site-packages/tensordict/utils.py", line 1620, in _is_number
    if isinstance(item, (Number, ftdim.Dim)):
                                 ^^^^^
NameError: name 'ftdim' is not defined

Looks like this is not quite enough:

@vmoens any idea why this happens ? Everything works fine with python 3.11...


Request API to set/get command timeout timer

Usually, we have some commands need specify command max execution time(ie, NVM_Fomat command maybe cost about 40s). So request this API to set command TO timer to meet requirement.
I also need get command TO timer API to get current command TO timer.
Thanks a lot!

Controller.timeout: user can get and set this value in milli-seconds.
Example:
nvme0.timeout=10
assert nvme0.timeout == 10


Added Javascript Solution

Added the javascript solution for the "Flipping the Matrix" problem.

@shubhjaiswal02 Tested, it works fine. Can you remove all the code except the function flippingMatrix(), since that is only changed.


setTimeout example for Angular.js project

In the paper, there is a code snippet from Angular.js project, where setTimeout function is used incorrectly.
browserSingleton . startPoller (100 ,
        function (delay , fn) {
            setTimeout (delay ,fn) ;
})

However, I am unable to find such instance in the Angular.js code repo.
Can you please share the link to the buggy code/commit or pull request?

The bug is present in version 0.9.0 and also some later versions of angular.js. See here for a release that contains the buggy code. I'm not aware of the specific commit that removed the problem. In case you find it, please share.


Inventory Adjustment OnAfterMakeMultiLevelAdjmt event parameters.

Is it bug or "by design" that in OnBeforeMakeMultiLevelAdjmt and OnAfterMakeMultiLevelAdjmt we have different variables in Item parameter?
If it is "by design" Is it possible to add FilterItem parameter to the OnAfterMakeMultiLevelAdjmt event?

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Split test set IDs

Hi, you can please share the TXT or JSON file, where contain the IDs of the Celeba-HQ test-set dataset used to obtain the quantitative results showed in the principal documents.

Hi @JhEdLp, I've this split:
CelebAMask-HQ-attribute-anno.txt
CelebA-HQ-to-CelebA-mapping.txt
list_eval_partition.txt


Allow echo if output buffering disabled

Hi!
Please consider this PR. After upgrading from 3.9.0 to 3.9.1 i face problem of rendering non-HTML content with some PDF libraries which set headers with header() and then echo() themselves, so i not return $response from controller. But default $response exists and overwriting Content-Type header until i disable outputBuffering. It all works until 3.9.1 where ob_start is used in App::run() constantly. I don't want to catch PDF-output and put it to $response as it is complicate things and also overhead mem. Keep in mind other libraries.
Thank you!

Coverage decreased (-0.1%) to 96.964% when pulling 331d2c83636cfafda5af7e43bed8b7b91badfa2b on fatcat386:patch-1 into d0d9655a66c61e5fd25fdbdc2fc80a6e37af469c on slimphp:3.x.

The unit tests are failing here:
1) Slim\Tests\AppTest::testExceptionOutputBufferingOff

RuntimeException: Unexpected data in output buffer. Maybe you have characters before an opening <?php tag?
/home/travis/build/slimphp/Slim/Slim/App.php:612
/home/travis/build/slimphp/Slim/Slim/App.php:324
/home/travis/build/slimphp/Slim/tests/AppTest.php:2245
/home/travis/build/slimphp/Slim/vendor/phpunit/phpunit/phpunit:52

The change to output buffering came about because of https://github.com/slimphp/Slim/issues/2208 which was fixed with https://github.com/slimphp/Slim/pull/2270. Your PR breaks this fix.
As your PDF library is setting headers and echo'ing directly, you should probably just exit after calling it.
Another possible solution would be to modify Route::__invoke() to use headers_list()to add the headers set by the library to the response if $newResponse is a string.
Can you open an issue with an example showing how to reproduce the problem?

Thanks for your answer!
To reproduce problem we need just call this from controller:
header('Content-Type: application/pdf');
echo SOME_PDF_CONTENT;
After that we can get two possible results:

page with raw pdf code if outputBuffering is 'append' or 'prepend' and additional header from default response which break application/pdf.
a blank page if outputBuffering is false, but headers is correct as default response can no longer write them after echo.

But nevermind, exit helps me, shame on me)
Maybe it must be in documentation somewhere)


Internal Release 7.4

Functionality:
Internal Release 7.4
Solution:

create new team Ui fix
Fix Edit Team
Upgrade Page Dark Mode
fixed milestone status edit
Fixed UI of mails
social page data limiting
fixed organisation's button ui, and fix organisation's popup text in one line
fixed performance chart filter
Fix profile ui and Dates
create new task pop up
fix(social & teams page): fixed create post & added github info to teams page
meet delete functionality

Risk level:

[x] high
[ ] medium
[ ] low

How to test:
In Internal Release 7.4

This Pr has merge conflict with master


Crash

Already for months the tankinspector crashes already at the loading screen.
I have already given up hope for an update.

We need people who can take over the development but none of us can code.


[python] remove unnecessary conversions between data structures

I ran flake8 over the code in the Python package, with flake8-comprehensions installed.
pip install flake8 flake8-comprehensions
flake8 \
    --ignore=B,F,E,W \
    --exclude='python-package/build' \
    .

This found a few opportunities for small optimizations. For example, the results of set([1, 2, 3]) and {1, 2, 3} are equivalent, but the set([]) form has the extra cost of construction an intermediate list (which is immediately thrown away).
This PR proposes resolving those warnings, for some tiny efficiency improvements.
./python-package/setup.py:282:51: C400 Unnecessary generator - rewrite as a list comprehension.
./python-package/xgboost/core.py:1163:48: C405 Unnecessary tuple literal - rewrite as a set literal.
./python-package/xgboost/core.py:1511:18: C402 Unnecessary generator - rewrite as a dict comprehension.
./python-package/xgboost/tracker.py:144:23: C405 Unnecessary list literal - rewrite as a set literal.
./python-package/xgboost/tracker.py:258:23: C405 Unnecessary list literal - rewrite as a set literal.
./python-package/xgboost/training.py:518:18: C402 Unnecessary generator - rewrite as a dict comprehension.

Thanks for your time and consideration.

let me fix the failure with updated sklearn tomorrow.

apologies for the push. I need to bring in the CI fixes and hope you don't mind.

no problem, do what you need! And let me know if I can help in any way.


Looking for maintainers

I will be busy with some other projects in coming days. This project seems to be stable in its current state but I will like to see it evolve and I will need some helping hand. Let me know if you are interested.
cc @morajabi

As long as I'm able to do something I'd be happy! But I can't promise to ALWAYS be available.

As I said I think this project seems to be stable to I guess it won't take a lot of time.

So, let's do this. 👍

Sent you an invite. Also I am not leaving this project just need a bit of help with too many projects.

@ritz078 It can't be done without you.


How I can add env variable like "valueFrom:" to istio-proxy?

Hello. Please describe the question how I can add env variable like:
- name: TEST_ENV
   valueFrom:
     fieldRef:
       apiVersion: v1
         fieldPath: >-
           metadata.annotations[annotation-a]

to istio-proxy?
[ ] Ambient
[ ] Docs
[x] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure
Affected features (please put an X in all that apply)
[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane
Additional context

you can use https://istio.io/latest/docs/setup/additional-setup/sidecar-injection/#custom-templates-experimental
can you share you use case? why do we need this?


Can not use purescript-jquery with <$>

 -- can not work
 void $ on "click" (deleteArticleHandler) <$> select "a[data-delete]"

-- following code will work
menuLink <- select "#menuLink"
void $ on "click" (menuLinkHandler) menuLink

It will compile to the following code.
Prelude["void"](Control_Monad_Eff.functorEff)(Prelude["<$>"](Control_Monad_Eff.functorEff)(Control_Monad_Eff_JQuery.on("click")(deleteArticleHandler))(Control_Monad_Eff_JQuery.select("a[data-delete]")))(); // function didn't run in this statement

var _0 = Control_Monad_Eff_JQuery.select("#menuLink")();
return Prelude["void"](Control_Monad_Eff.functorEff)(Control_Monad_Eff_JQuery.on("click")(menuLinkHandler)(_0))();

Is this issue with <$> or with the different selector?

I think you want to do this instead:
void $ on "click" (menuLinkHandler) =<< select "#menuLink"

Or if you prefer:
void $ select "#menuLink" >>= on "click" (menuLinkHandler)

I made a mistake,  I'm very sorry waste of your time. And thank you for help me.
 on "click" (deleteArticleHandler) <$> select "a[data-delete]" -- it will return a (Eff eff JQuery), not a JQuery.

No problem, perhaps the API should be improved.


Add negative tests for mypy in tests

We should tests if stuff that should fail actually fails and the returned types of generic functions are correct.
We could add pytest-mypy-testing  or a similiar tool to our tests (or do it manually, as Numpy does to check our type annotations.

For now, we can add assert_type tests to the  LinearOperator, Operator, spatial dimension etc arithmetic tests.


Add Drivet API

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is ordered alphabetically
[x] My submission has a useful description
[x] The description does not have more than 100 characters
[x] The description does not end with punctuation
[x] Each table column is padded with one space on either side
[x] I have searched the repository for any relevant issues or pull requests
[x] Any category I am creating has the minimum requirement of 3 items
[x] All changes have been squashed into a single commit

I'm not sure if this API fits to the Entertainment category, but I chose that because it fits for me :D Let me know if it doesn't fit.

Just FYI, Title should not end with "... API".

yeah there is no other name for it lol


Duplication of events sent when NATS slow consumer error appears

Describe the bug
Currently I am using Jmeter to send varying loads direct to a Jetstream Server pod. The server accepts all messages quickly, and NATS Jetstream Dispatcher is subscribing to the stream and sending the messages to a simple Knative service that has a Trigger listening to all events and persisting in a postgreSQL database .
At low load, we are seeing fast persisting of messages in database.
Bug only appears when we tried to send 25 000 messages to Jetstream server, and duplication of events is seen
(prometheus logs shows 30+k messages sent by the Broker Filter pod)
Logs in Jetstream-ch-dispatcher shows:
ERROR MESSAGE: nats: slow consumer, messages dropped on connection [95700] for subscription on "_INBOX.vNtVZS4IIQ2XCN5w06S5uS"

Expected behavior
No duplication of messages to be observed, each message is only sent once from the Jetstream Dispatcher
To Reproduce
Running in a 4 Core, 16 GB RAM Ubuntu VM
Installed Knative serving with net-contour
Installed MT-channel broker
Used the yaml file included on knative site: https://github.com/knative-sandbox/eventing-natss/releases/download/knative-v1.4.0/eventing-natss.yaml
Increased the limits of the Jetstream server to use 1000m CPU and 500M Memory
Publishing to Jetstream server via NodePort
Knative release version
1.4
Additional context
Understood that a new version of Jetstream Dispatcher is in the works, but wondering if this issue will persist in future versions
Please update if more information is needed on my end, thanks.

Hi same issue, a slow consumer in sequence make a retry broker, a new events is generated and new message in stream nats and loop , is broken my knative events in one day


python.pythonPath is being deprecated. This change breaks test-explorer

Microsoft announced that they will slowly deprecate python.pythonPath in https://devblogs.microsoft.com/python/python-in-visual-studio-code-may-2020-release/ and specifically the section "Coming Next: moving python.pythonPath out of settings.json". The rational behind it is explained in microsoft/vscode-python#2125
For work we need this feature so I manually activate it and it breaks test-explorer. Right now test-explorer defaults to the standard python environment when I run or debug the tests.
In vscode-restructuredtext/vscode-restructuredtext/issues/222 is it possible to see how another extension that depended on python.pythonPath fixed the problem.

please report an issue here: https://github.com/kondratyev-nv/vscode-python-test-adapter/issues
see also: https://github.com/hbenl/vscode-test-explorer/issues/155

Ops, I did not realized how the extension works. Thanks =)


Update dependency commander to v10

This PR contains the following updates:

Package
Type
Update
Change

commander
dependencies
major
^9.4.1 -> ^10.0.0

Release Notes

tj/commander.js
v10.0.0
Compare Source
Added

wrap command description in help ([#1804])

Changed

Breaking: Commander 10 requires Node.js v14 or higher

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

lgtm


More complete with-apollo-and-redux example with dynamic post route

The current example stops short of letting posts have a dedicated page with a parameterized route. For example, each post now has a /blog/:id route.
I recommend accepting this pull request because figuring this out on my own took me 3+ hours --
granted, I'm really new at React and next.js. That said, this example would have helped tremendously!

@ads1018

@ads1018 I removed the commented out code

@bdombro looks good!


minor: exclude vendor/libgit2/tests

I was downloading this repo on a slow connection and wondered why it took so long.
$ du -hs vendor/libgit2/tests/
53M	vendor/libgit2/tests/

Minor issue, feel free to close out and ignore.

Fair enough, let me close this out :)


Raise ValueError from resolve_model_string for unknown types

A LookupError is raised by apps.get_model for an unknown model, but this LookupError was being raised when values with unhandled types were passed in. This should be a ValueError instead. The docstring has been amended document the errors raised.
This PR was broken out of #1778

Thanks!


Issue with caching in Jupyterlab

Reporting a bug

[x] I have tried using the latest released version of Numba (most recent is
visible in the change log (https://github.com/numba/numba/blob/master/CHANGE_LOG).
[x] I have included a self contained code sample to reproduce the problem.
i.e. it's possible to run as 'python bug.py'. --> Attaching an NB since that's where the issue is.

Having an issue with cache=True when used in a Jupyter Notebook. It works fine in a regular IPython shell or in python scripts.
Attaching a NB since that's where the issue is visible (it wouldn't let me upload a ipynb file, so I renamed it to a txt file; to use it you can download it and rename it as ipynb):
numba-cache-reproducer.txt
This is a screenshot:

This is on numba=0.53.1. I noticed that 0.54 has been tagged, but I couldn't find it on conda-forge at the time of creating the issue.
Also attaching the output of numba -s:
numba-s-out.txt
I played around a little, and the following diff did seem to fix it (i.e. it doesn't throw an error anymore):
numba-nb-potential-fix-diff.txt
but I'm not really sure if it's the right way to do it or if it works in general.

Thanks for the report. This is reproducible and seemingly present only in the 6 series of ipykernel.

Furthermore, setting the environment variable NUMBA_CACHE_DIR seems not to solve the issue.


Enhancement request: Futures.waitForAny() and Futures.waitForAll()

This issue was originally filed by<EMAIL_ADDRESS>
Scenario

        In putting together a response to a request, we dispatch a query to multiple database replicas (servers).  As soon as we receive the data from any of them, we can continue with framing our response.  Here, we are evidently interested in any one of them finishing, not all.
Request

        Rename Futures.wait(List<Future> l)' toFutures.waitForAll(List<Future> l)', and introduce a new `Futures.waitForAny(List<Future> l)' to address the above case (and similar ones).

Fairly certain this is handled by Future.any (see here). Closing for now.


add geerlingguy.jenkins role for jenkins-2024 playbook

also add geerlingguy.jenkins role to ansible requirements


feat(stores): testing multiple stores (working!)

:tada: This PR is included in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Shared text and opened links are separated into different streams

https://github.com/KasemJaffer/receive_sharing_intent/issues/63
https://github.com/KasemJaffer/receive_sharing_intent/issues/54
https://github.com/KasemJaffer/receive_sharing_intent/issues/22
Shared text and opened links are separated into different streams.
It still hijacks all deep links, but now you can use this plugin for handling deep links as well (you can remove 'uni_links' from the project).
    var textSharingSubscription = ReceiveSharingIntent.getTextStream().listen((value) {
      _handleSharing(text: value);
    }, onError: (err) {
      log("getTextStream error: $err");
    });

    var uniLinkSubscription = ReceiveSharingIntent.getLinkStream().listen((value) {
      _handleUniLink(link: value);
    }, onError: (err) {
      log("getLinkStream error: $err");
    });

@KasemJaffer Could you take a look at this?

@KasemJaffer Any chance to see this merged? Thanks

Because handling unilinks was disabled completely in the published version, I decided to use uni_links. So this PR has no sense anymore.


New project dialogue, "Submit" button, stays greyed out

I have two (working) hugo folders ... neither works, This is WIN10 and the latest HUGO.

I changed the site name to lower letters (as required) and it worked.

this is beyond ridiculous ....


Server side auto exit problem

After using it for a while, the server side shadow-tls automatically exits without an error message. Usually happens when loading a lot of pictures, or loading a lot of unread telegram messages (seems like it happened when loading lots of small chunks of data).

During the test, the client side shadow-tls also has automatically exit problem.

Please check system log and see if this problem caused by oom(dmesg -T)? It allocates 8K memory for each active connection.
Check if your io_uring related things(like memlock) is correctly configured(you may find them in monoio docs).

You can paste your related log here with you kernel version.

server:

client:

my client side has 128GB memory, which shouldn't be caused by oom.

Ok I see. There seems a bug when accept connections. Once accept failed, it will return and stop the thread. When all threads goes down, it will exit.


'canvas' / 'repulse' is not defined   no-undef

Hello!
Thank you so much for so beautiful react module!
I'm using it on my study project now.
Unfortunately I can't use the "Interactivity" parameter  :(
It looks this way in my code:

And I got this error:

Other Particles features are already  works perfect.
Can you kindly help me with this issue? How I can enable Particles Interactivity in me React App?
Thank you in advance!

Hi!
You need to specify them as strings:
detect_on: "canvas", mode: "repulse"

@Wufe, thank you for your reply!
Actually, I have tried to use this parameters as a string.
It's compiled successfully but still nothing happens on the webpage when I try to use this beautiful onhover  or onhlick effect.
Here is my full list of parameters:

And I rendering Particles this way:
<Particles className='particles' params = {ParticlesOptions}/>
Just no hover effect :(

Hi @muravitsky , the params object is not correct: you nested "interactivity" into "particles".
Check this example:

Thank you so much! It works! And it's just because of my inadvertence.
Thank you so much one more time!

You are welcome 😁


deal with new flush API for buffers in recent libftdi1 1.5

https://www.qlcplus.org/forum/viewtopic.php?f=12&t=14804
Updated the patch to act conditionally, depending on which libftdi version is found at compile time.

If this is for libftdi 1.5 only then using LIBFTDI1 is wrong. It involves all 1.x versions

You're right, I've added a version check and new variable to src.pro

It looks too complicated to me. Moreover, does it work on macOS?
I would simply use the ftdi_get_library_version in the original LibFTDIInterface::purgeBuffers method and decide to invoke ftdi_tcioflush or ftdi_usb_purge_buffers.
That's all. Simple and clean.

Yeah I just tried and ran into problems, I can't use the deprecated function name from C++.
Not sure how to check macOS behaviour, the only Macbook I have access to is the machine used for editing and running shows at the theater, and not set up for compiling stuff - I rather wouldn't mess with it at this time.

I think you dragged in unrelated MIDI code in this PR. Please rebase/fix.
Also, please instead of purge/flush as separate methods, make a single change in LibFTDIInterface::purgeBuffers and ifdef the FTDI versions. This way it looks cleaner than multiple ifdefs around.
Thanks

Sorry for the MIDI stuff, i had merged your master branch - still unsure about best practices in GH...
I thought the method name should reflect what it's doing, but if you prefer this simpler way, I'm totally fine with that :)
Hopefully it's ready now for merging?

Yeah, thanks. I need to check if this is OK on macOS and then it can be merged

@edogawa23 I finally checked on macOS and this seems OK 👍
One last change: can you please rename "NEW_LIBFTDI1" to "LIBFTDI1_5"? I doubt "NEW" will still make sense in 5-10 years ;)
Also, can you simplify the version check like the following?
Does it really make sense to check all the non-verified conditions and do nothing first?
versionAtLeast(ftdi1, 1.5) {
    message("Found libftdi1 version $$ftdi1 (new buffer flush API)")
    DEFINES += LIBFTDI1_5
}

Thanks! :+1:


[Bug] Sorting error

Whats the bug?
When I sort an artist or a playlist by play count it shows an error with status code 502. Every other sorting is working.

Product info:
Spicetify version : 2.20.2
Spotify version : <IP_ADDRESS>9.ga3ae422d
Your config-xpui.ini
[Setting]
prefs_path              = C:\Users\user\AppData\Roaming\Spotify\prefs
inject_css              = 1
spotify_launch_flags    =
replace_colors          = 1
overwrite_assets        = 0
check_spicetify_upgrade = 0
spotify_path            = C:\Users\user\AppData\Roaming\Spotify
current_theme           = marketplace
color_scheme            =
inject_theme_js         = 1
[Preprocesses]
disable_upgrade_check = 1
disable_sentry        = 1
disable_ui_logging    = 1
remove_rtl_rule       = 1
expose_apis           = 1
[AdditionalOptions]
experimental_features = 1
extensions            = romaji_lyrics.js|sortByPlayCount.js|formatColors.js
custom_apps           = marketplace|lyrics-plus|eternal-jukebox
sidebar_config        = 1
home_config           = 1
[Patch]
; DO NOT CHANGE!
[Backup]
version = <IP_ADDRESS>9.ga3ae422d
with    = 2.20.2
OS
Windows
I checked all issues and mine is different

[X] Yes, I checked all issues

Same here. This was the most used feature and it's sad not to have it available anymore.

Same here.

Spotify <IP_ADDRESS>9.ga3ae422d
Spicetify v2.20.3
[Setting]
spotify_path            = C:\Users\user\AppData\Roaming\Spotify
prefs_path              = C:\Users\user\AppData\Roaming\Spotify\prefs
current_theme           = marketplace
inject_theme_js         = 1
replace_colors          = 1
overwrite_assets        = 0
color_scheme            =
inject_css              = 1
spotify_launch_flags    =
check_spicetify_upgrade = 0
[Preprocesses]
expose_apis           = 1
disable_upgrade_check = 1
disable_sentry        = 1
disable_ui_logging    = 1
remove_rtl_rule       = 1
[AdditionalOptions]
extensions            =
custom_apps           = new-releases|lyrics-plus|marketplace
sidebar_config        = 1
home_config           = 1
experimental_features = 1
[Patch]
; DO NOT CHANGE!
[Backup]
version = <IP_ADDRESS>9.ga3ae422d
with    = 2.20.3
OS: Windows

Same error...

Confirmed, same issue for me.


HTTPError 403 Client Error: Forbidden for url

Describe the bug
Can't seem to get image search feature to work.
Here is a colab to reproduce the issue: https://colab.research.google.com/drive/1yAVjMaZxe_eaVJ-J1cvqPbfBcBaQWYvU?usp=sharing
Debug log
WARNING:duckduckgo_search.duckduckgo_search:_get_url() https://duckduckgo.com/i.js HTTPError 403 Client Error: Forbidden for url: https://duckduckgo.com/i.js?l=wt-wt&o=json&s=0&q=butterfly&vqd=4-127388145370558534196193019016331789945&f=%2C%2Ccolor%3AMonochrome%2C%2C%2C&p=-1
WARNING:duckduckgo_search.duckduckgo_search:_get_url() https://duckduckgo.com/i.js HTTPError 403 Client Error: Forbidden for url: https://duckduckgo.com/i.js?l=wt-wt&o=json&s=0&q=butterfly&vqd=4-127388145370558534196193019016331789945&f=%2C%2Ccolor%3AMonochrome%2C%2C%2C&p=-1
WARNING:duckduckgo_search.duckduckgo_search:_get_url() https://duckduckgo.com/i.js HTTPError 403 Client Error: Forbidden for url: https://duckduckgo.com/i.js?l=wt-wt&o=json&s=0&q=butterfly&vqd=4-127388145370558534196193019016331789945&f=%2C%2Ccolor%3AMonochrome%2C%2C%2C&p=-1
---------------------------------------------------------------------------
HTTPError                                 Traceback (most recent call last)
<ipython-input-2-fe9bf968464c> in <cell line: 16>()
     14     license_image=None,
     15 )
---> 16 for r in ddgs_images_gen:
     17     print(r)

3 frames
/usr/local/lib/python3.10/dist-packages/duckduckgo_search/duckduckgo_search.py in images(self, keywords, region, safesearch, timelimit, size, color, type_image, layout, license_image)
    395         cache = set()
    396         for _ in range(10):
--> 397             resp = self._get_url("GET", "https://duckduckgo.com/i.js", params=payload)
    398             if resp is None:
    399                 break

/usr/local/lib/python3.10/dist-packages/duckduckgo_search/duckduckgo_search.py in _get_url(self, method, url, **kwargs)
     69                 logger.warning(f"_get_url() {url} {type(ex).__name__} {ex}")
     70                 if i >= 2 or "418" in str(ex):
---> 71                     raise ex
     72             sleep(3)
     73         return None

/usr/local/lib/python3.10/dist-packages/duckduckgo_search/duckduckgo_search.py in _get_url(self, method, url, **kwargs)
     63                 if self._is_500_in_url(resp.url) or resp.status_code == 202:
     64                     raise requests.HTTPError
---> 65                 resp.raise_for_status()
     66                 if resp.status_code == 200:
     67                     return resp

/usr/local/lib/python3.10/dist-packages/requests/models.py in raise_for_status(self)
   1019
   1020         if http_error_msg:
-> 1021             raise HTTPError(http_error_msg, response=self)
   1022
   1023     def close(self):

HTTPError: 403 Client Error: Forbidden for url: https://duckduckgo.com/i.js?l=wt-wt&o=json&s=0&q=butterfly&vqd=4-127388145370558534196193019016331789945&f=%2C%2Ccolor%3AMonochrome%2C%2C%2C&p=-1

Specify this information

OS (Windows and Linux)
environment
duckduckgo_search version 3.5.0

The site added some kind of protection against bots, which began to block requests.
When I release an update, after a while the requests start blocking again.
I have now converted the requests to http/2, but how long this will work is a big question.
So you can update to v3.6.0 and have a try.

@deedy5, Thanks a lot, it worked.


CRD not found causes Operator to crash loop?

What steps did you take and what happened:
I noticed (late) the trivy-operator v0.18.1 pod kept crashing so I updated to v0.18.2, but I keep seeing the same behavior.
Looking at the pod logs I get this error (as if I was missing a CRD though no changes were made):
{"level":"error","ts":"2024-01-29T15:14:26Z","logger":"controller-runtime.source.EventHandler","msg":"if kind is a CRD, it should be installed before calling Start","kind":"ClusterVulnerabilityReport.aquasecurity.github.io","error":"no matches for kind "ClusterVulnerabilityReport" in version "aquasecurity.github.io/v1alpha1"","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/source.(*Kind).Start.func1.1\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/source/kind.go:63\nk8s.io/apimachinery/pkg/util/wait.loopConditionUntilContext.func2\n\t/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.29.0/pkg/util/wait/loop.go:87\nk8s.io/apimachinery/pkg/util/wait.loopConditionUntilContext\n\t/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.29.0/pkg/util/wait/loop.go:88\nk8s.io/apimachinery/pkg/util/wait.PollUntilContextCancel\n\t/home/runner/go/pkg/mod/k8s.io/apimachinery@v0.29.0/pkg/util/wait/poll.go:33\nsigs.k8s.io/controller-runtime/pkg/internal/source.(*Kind).Start.func1\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.16.3/pkg/internal/source/kind.go:56"}
What did you expect to happen:
The pod was previously running without restarting constantly until I saw the 3700+ restarts in 17 days (I didn't look for some time)!
Environment:

Trivy-Operator version (use trivy-operator version):
Version: "0.18.2"
Commit: "2c2f55673de7db8528da65ab0761fd1219fb0c65"

Kubernetes version (use kubectl version): K8s v1.28.5

OS (macOS 10.15, Windows 10, Ubuntu 19.10 etc): K8s Cluster running on Rocky Linux 9.3

Should I helm uninstall, clean the AquaSecurity CRDs and helm install again?
Thanks for the help!

@lepicodon how are deploying the to the cluster ?

I'm using helm to deploy the operator, using custom values.
ConfigMap:
kubectl describe cm -n trivy-system trivy-operator-trivy-config
Name:         trivy-operator-trivy-config
Namespace:    trivy-system
Labels:       app.kubernetes.io/instance=trivy-operator
app.kubernetes.io/managed-by=Helm
app.kubernetes.io/name=trivy-operator
app.kubernetes.io/version=0.18.2
helm.sh/chart=trivy-operator-0.20.3
Annotations:  meta.helm.sh/release-name: trivy-operator
meta.helm.sh/release-namespace: trivy-system
Data
trivy.dbRepositoryInsecure:
false
trivy.includeDevDeps:
false
trivy.javaDbRepository:
ghcr.io/aquasecurity/trivy-java-db
trivy.mode:
Standalone
trivy.tag:
0.48.2
trivy.useBuiltinRegoPolicies:
true
trivy.additionalVulnerabilityReportFields:
trivy.imageScanCacheDir:
/tmp/trivy/.cache
trivy.resources.limits.memory:
500M
trivy.resources.requests.cpu:
100m
trivy.resources.requests.memory:
100M
trivy.sbomSources:
trivy.skipJavaDBUpdate:
false
trivy.slow:
false
trivy.imagePullPolicy:
IfNotPresent
trivy.dbRepository:
ghcr.io/aquasecurity/trivy-db
trivy.resources.limits.cpu:
500m
trivy.severity:
UNKNOWN,LOW,MEDIUM,HIGH,CRITICAL
trivy.supportedConfigAuditKinds:
Workload,Service,Role,ClusterRole,NetworkPolicy,Ingress,LimitRange,ResourceQuota
trivy.timeout:
5m0s
trivy.command:
image
trivy.repository:
ghcr.io/aquasecurity/trivy
trivy.filesystemScanCacheDir:
/var/trivyoperator/trivy-db
BinaryData
Events:

sorry for the markdown output...

@lepicodon do you mind try uninstall operator and install it again.

I helm uninstalled and then reinstalled (newer v0.18.3) and all seems to be good now, now more restarts and missing CRD in the logs!
Thank you!!


Change PetCollection.pets to be a getter

By using a getter, pets on allPets can be accessed using .pets rather than needing to call it as a method (.pets()).
This can be done for similar methods on the other classes in this file, but I didn't want to throw it at you as one big PR, so I'm breaking it up for clarity.

Codecov Report

Merging #285 (407a11d) into master (de0023a) will not change coverage.
The diff coverage is 0.00%.

@@          Coverage Diff           @@
##           master    #285   +/-   ##
======================================
  Coverage    8.35%   8.35%
======================================
  Files           3       3
  Lines         634     634
  Branches       90      90
======================================
  Hits           53      53
  Misses        581     581

Impacted Files
Coverage Δ

src/panel/main.ts
3.27% <0.00%> (ø)

src/panel/pets.ts
7.17% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


fix: google (android)

Requires the following change in the MainActivity.java
    @Override
    public void onActivityResult(int requestCode, int resultCode, Intent data) {
        super.onActivityResult(requestCode, resultCode, data);

        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N && requestCode >= GoogleProvider.REQUEST_AUTHORIZE_GOOGLE_MIN && requestCode < GoogleProvider.REQUEST_AUTHORIZE_GOOGLE_MAX) {
            PluginHandle pluginHandle = getBridge().getPlugin("SocialLogin");
            if (pluginHandle == null) {
                Log.i("Google Activity Result", "SocialLogin login handle is null");
                return;
            }
            Plugin plugin = pluginHandle.getInstance();
            if (!(plugin instanceof SocialLoginPlugin)) {
                Log.i("Google Activity Result", "SocialLogin plugin instance is not SocialLoginPlugin");
                return;
            }
            ((SocialLoginPlugin) plugin).handleGoogleLoginIntent(requestCode, data);
        }
    }

TODO:

[x] Document Google changes on Android

Waiting for this update.

any ETA for this to be merged? November is here and 12th is the deadline..

I am talking about Apple Privacy Manifest deadline. When i am migrating to this plugin it is throwing some error related to Web other issues. i am assuming this PR this fix them so i can migrate.

We need to support same min version as capacitor

Fixed in https://github.com/Cap-go/capacitor-social-login/pull/37/commits/cffde90bca3ba708fccc56c285733f64b22e4732 and https://github.com/Cap-go/capacitor-social-login/pull/37/commits/4e89adaaf4cdd2e1442412001a23da04e5b9c1ed

@Saqib92 I just pushed the changes to replace CompletableFuture with ListenableFuture. This way this plugin works on all versions of Capacitor.

It there a way I can test and confirm this PR works as expected?

It there a way I can test and confirm this PR works as expected?

Sure, if you use bun just checkout this branch and run bun link. Then, add a
"@capgo/capacitor-social-login": "link:@capgo/capacitor-social-login",

into your dependencies.
Run bun i and bunx cap sync. Personally, that is how I test PRs, but you might not be using bun, in which case I don't know how you can test this PR

It there a way I can test and confirm this PR works as expected?

Sure, if you use bun just checkout this branch and run bun link. Then, add a
"@capgo/capacitor-social-login": "link:@capgo/capacitor-social-login",

into your dependencies.
Run bun i and bunx cap sync. Personally, that is how I test PRs, but you might not be using bun, in which case I don't know how you can test this PR

i tried with npm alternative:
npm install github:Cap-go/capacitor-social-login#pull/37/head
it installs the plugin but not generation dist folder for type definition, making it not useable.
I think only solution is to release it.

I don't have NPM access
CC @riderx

any ETA for release date?

I wanted to release today, but the CI/CD is running pnpm for whatever reason. I am trying to fix the build issues right now

I released 0.0.68-alpha.2 with this PR


Time clicked on stat not match with current time

[x] I've read the Troubleshooting First Steps
[x] This request isn't a duplicate of an existing issue, opened or closed
[ ] I've read the docs and followed them (if applicable)
[ ] This is not a personal support request that should be posted on the YOURLS Discourse community

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior. This is mandatory if you expect someone to fix the problem. Example:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Actual behavior
What actually happens.
Screenshots
If applicable, add screenshots to help explain your problem.
Versions
You can get this information from referencing CHANGELOG.md or the releases page.
Also, please include:

The OS and what version of the OS you're running.
Plugins or extensions activated if applicable.

Additional context
Any additional information, configuration or data that might be necessary to reproduce the issue.

I have no idea what this issue is about.

I have no idea what this issue is about.

Thank you for your comment. :)

The issue template is still empty…

what is template?
ดาวน์โหลด Outlook for Androidhttps://aka.ms/ghei36

From: dgw<EMAIL_ADDRESS>Sent: Tuesday, October 13, 2020 11:48:26 AM
To: YOURLS/YOURLS<EMAIL_ADDRESS>Cc: kyosuke100<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [YOURLS/YOURLS] Time clicked on stat not match with current time (#2765)
The issue template is still empty…
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/YOURLS/YOURLS/issues/2765#issuecomment-707484453, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARLHB5UWBEOUUFUUJH7LVVDSKPLZVANCNFSM4SNZALDQ.

All that text in the top comment that you didn't fill in.

All that text in the top comment that you didn't fill in.
I edited issue by filling information. Are they corrently?

Oh, I think I understand now. Sounds like you're seeing the difference between your local time and UTC. 1.7.10 plus a plugin should help; check out #2684. :smile_cat:

Oh, I think I understand now. Sounds like you're seeing the difference between your local time and UTC. 1.7.10 or 1.8 (whichever version number gets used) plus a plugin should help; check out #2684. 😸

Thank you very much, I will try as your suggestion.


Using the @overload decorator with overloaded functions

Hello,
At the beginning of the year, I had not noticed this problem, but today when opening an imgui_bundle project in VSCode (configured with Python by default: Pylance), I get errors with overloaded functions:

Reading PEP 484 from python 3.5: https://peps.python.org/pep-0484/#function-method-overloading
I reformatted some .pyi files with the @overload decorator:

The solution was given to me by this link which concerns PyCharm and Typeshed.
It therefore seems that this error is not specific to Pylance but an error in respecting PEP 484.
Is it possible in future versions to add the @overload operators?
merci

Hello,
Since I had some time today, I worked on this. I needed to adapt the autogenerator. It went smoothly, so I updated the stubs in this commit
You will need to build from source: see https://pthom.github.io/imgui_bundle/#_build_and_install_instructions

Ha! Great!
Where is the autogenerator located in the repository?

Yes, the generator is indeed there. It is a big piece of software, which I did not take to document yet


Use PYG packaged GATConv to train GAT model error RuntimeError: unsupported tensor layout: Sparse

When I use GATconv on Cora dataset, input node feature matrix x and adjacency matrix adj. The code reports RuntimeError: unsupported tensor layout: Sparse. The error code is x=self.gat1(x,adj). My specific code ：
class GATModelAE(nn.Module):
def init(self, input_feat_dim, hidden_dim1, hidden_dim2, dropout):
super(GATModelAE, self).init()
self.gat1=GATConv(input_feat_dim ,hidden_dim1,3,dropout)
self.gat2=GATConv(3*hidden_dim1, hidden_dim2,1,dropout)
def forward(self, x, adj):
x=self.gat1(x,adj)
x=self.gat2(x,adj)
return F.log_softmax(x,dim=1)
I don't know if it is a problem with the dataset. I hope the teacher can help me. I am very frustrated and I don't know what to do. Can you help me, thank you guys.

Excuse me, have you solved it? The same problems I have met.


⚠ Bhf has degraded performance

In f120b3f, Bhf (https://bhf.im) experienced degraded performance:

HTTP code: 200
Response time: 9996 ms

Resolved: Bhf performance has improved in 8bf4589.


Investigate Reducing Startup Activation Time

Extension Version: 6.3.0
OS Version: Windows_NT x64 10.0.14393
VSCode version: 1.19.0-insider

vscode added a new "Running Extensions" feature that gives you simple timing dumps for extension activation; i pulled the one for gitlens as it was rather large (time in ms):
{
	"activationTimes": {
		"startup": true,
		"codeLoadingTime": 876,
		"activateCallTime": 13,
		"activateResolvedTime": 122,
		"activationEvent": "*"
	}
}

compare with typescript's load times:
{
	"activationTimes": {
		"startup": false,
		"codeLoadingTime": 326,
		"activateCallTime": 1,
		"activateResolvedTime": 0,
		"activationEvent": "onCommand:workbench.action.tasks.runTask"
	}
}

and git:
{
	"activationTimes": {
		"startup": true,
		"codeLoadingTime": 84,
		"activateCallTime": 16,
		"activateResolvedTime": 0,
		"activationEvent": "*"
	}
}

obviously these (extremely simple & opaque) numbers are just for my (fairly powerful) 2015 macbook pro & aren't particularly painful, but given the size of the deltas here i suspect underpowered machines are hit even harder.
assuming this is a "fixable" situation (e.g. it's not an issue with vscode APIs), i'm curious what could be done to improve this?

I'm also getting such a high start up time, 499ms. Triple of what some of the other highest extensions I have installed.

I've released a new GitLens 7 beta which switches to use webpack for a bundled and minified build. I'm seeing a ~16%+ reduction in the startup time (not great, but not nothing either). Please try it out and see how it performs for you. Also keep an eye out for issues, because there could always been fun edge cases lurking in the minification.
/cc @zackschuster @imoby @niemyjski @Philip-Trettner
Also I'm quickly running out of ideas for reducing things further, so any help from the community would be greatly appreciated.

I am getting a startup activation of 974ms.

Extension Version: 7.0.0
OS Version: Darwin x64 17.3.0
VSCode version: 1.19.0

@VMBindraban please try the beta version mentioned above in https://github.com/eamodio/vscode-gitlens/issues/225#issuecomment-352631213

With the beta version; after a soft-reload 650ms, hard restart of VSC 970ms.

@VMBindraban Great -- thanks. While its still takes a bit, a roughly 30% improvement isn't bad ;)

@eamodio would it be possible to use a rollup build instead? i'm imagining lots of time being spent on closure handling with webpack's custom modules. (i'm willing to help with this)

FYI, I've posted a new beta with a much more substantial reduction in startup time and also package size. I swapped out some large dependencies with some tiny homegrown (borrowed) implementations. Because of that this will require quite a bit of burn in -- but so far things look pretty good, imo. :)
@zackschuster If you'd like to take a shot at that and report back on the savings I'm all 👂  😉

@zackschuster I've added support for rollup bundling  (npm run bundle-rollup) with the last check-in to develop. In my timings it is very close, though I'd say slightly worse than webpack, and its build times are WAY worse. If you have any other ideas (or want to tweak the rollup config) let me know.


Add systemd file to run the service

Isn't that implemented already?

@Arberesto Yes, it's already implemented. See https://github.com/senior-sigan/toggl-reporter/blob/0e978ffc7db169c2d5df7d1680e924f0d9d06375/goreporter.service
Thanks


No module named 'openai' error on fresh install

For reasons, I'm not able to raise this with the full level of detail I would normally prefer to include, but I'll post it just in case others see this too.
I've just installed chainlit 1.0.301 into a conda env, nstalled via pip. Upon trying chainlit init or chainlit hello both error out with a traceback that ends in:
ModuleNotFoundError: No module named 'openai'
(I've had to retype that as I don't have access to paste the error plus other info here, however I believe I've done it w/o typos!
I didn't get this on another install done in the same way two days ago which installed 1.0.200.
Nothing else was done in the recent case, hence I'm wondering if it's a small reversion in one of the two recent releases since 1.0.200.
Edit: Sorry, missed out this is on Windows. Python version 3.11.8 in the conda env.

In fact, having switched it back to installing 1.0.200 in that same environment, it now does not give the error, so it does seem to be a recent change.

Chainlit has no dependency to openai has you can see here. It only has a dependency to openai when running in the CI.
The reason is that we do not want to bloat the package with all the third party packages, it is up to the developer to selectively install those.

I also encountered the same error.
It seems that the error occurs not with chainlit but with literalai, which has a dependency.
I don't know the maintainer of this library, do you know their contact information?
vscode ➜ ~ $ cd tmp/
vscode ➜ ~/tmp $ poetry init
vscode ➜ ~/tmp $ ls
pyproject.toml
vscode ➜ ~/tmp $ poetry add chainlit
Creating virtualenv tmp-M427n64X-py3.12 in /home/vscode/.cache/pypoetry/virtualenvs
Using version ^1.0.301 for chainlit

Updating dependencies
Resolving dependencies... (4.9s)

Package operations: 70 installs, 0 updates, 0 removals

  • Installing wrapt (1.16.0)
  • Installing zipp (3.17.0)
  • Installing deprecated (1.2.14)
  • Installing h11 (0.14.0)
  • Installing importlib-metadata (6.11.0)
  • Installing protobuf (4.25.3)
  • Installing backoff (2.2.1)
  • Installing certifi (2024.2.2)
  • Installing charset-normalizer (3.3.2)
  • Installing idna (3.6)
  • Installing opentelemetry-api (1.22.0)
  • Installing opentelemetry-proto (1.22.0)
  • Installing opentelemetry-semantic-conventions (0.43b0)
  • Installing sniffio (1.3.0)
  • Installing typing-extensions (4.9.0)
  • Installing urllib3 (2.2.1)
  • Installing wsproto (1.2.0)
  • Installing annotated-types (0.6.0)
  • Installing anyio (3.7.1)
  • Installing frozenlist (1.4.1)
  • Installing googleapis-common-protos (1.62.0)
  • Installing grpcio (1.60.1)
  • Installing multidict (6.0.5)
  • Installing opentelemetry-exporter-otlp-proto-common (1.22.0)
  • Installing opentelemetry-sdk (1.22.0)
  • Installing packaging (23.2)
  • Installing pydantic-core (2.16.2)
  • Installing requests (2.31.0)
  • Installing simple-websocket (1.0.0)
  • Installing aiosignal (1.3.1)
  • Installing attrs (23.2.0)
  • Installing bidict (0.23.1)
  • Installing httpcore (1.0.3)
  • Installing marshmallow (3.20.2)
  • Installing mypy-extensions (1.0.0)
  • Installing opentelemetry-exporter-otlp-proto-grpc (1.22.0)
  • Installing opentelemetry-exporter-otlp-proto-http (1.22.0)
  • Installing pydantic (2.6.1)
  • Installing python-engineio (4.9.0)
  • Installing setuptools (69.1.0)
  • Installing starlette (0.32.0.post1)
  • Installing yarl (1.9.4)
  • Installing aiohttp (3.9.3)
  • Installing click (8.1.7)
  • Installing fastapi (0.108.0)
  • Installing httpx (0.26.0)
  • Installing marshmallow-enum (1.5.1)
  • Installing opentelemetry-exporter-otlp (1.22.0)
  • Installing opentelemetry-instrumentation (0.43b0)
  • Installing python-socketio (5.11.1)
  • Installing typing-inspect (0.9.0)
  • Installing websockets (12.0)
  • Installing aiofiles (23.2.1)
  • Installing asyncer (0.0.2)
  • Installing dataclasses-json (0.5.9)
  • Installing fastapi-socketio (0.0.10)
  • Installing filetype (1.2.0)
  • Installing lazify (0.4.0)
  • Installing literalai (0.0.204)
  • Installing nest-asyncio (1.6.0)
  • Installing pyjwt (2.8.0)
  • Installing python-dotenv (1.0.1)
  • Installing python-graphql-client (0.4.3)
  • Installing python-multipart (0.0.6)
  • Installing syncer (2.0.3)
  • Installing tomli (2.0.1)
  • Installing uptrace (1.22.0)
  • Installing uvicorn (0.25.0)
  • Installing watchfiles (0.20.0)
  • Installing chainlit (1.0.301)

Writing lock file
vscode ➜ ~/tmp $ poetry run chainlit hello
Traceback (most recent call last):
  File "/home/vscode/.cache/pypoetry/virtualenvs/tmp-M427n64X-py3.12/bin/chainlit", line 5, in <module>
    from chainlit.cli import cli
  File "/home/vscode/.cache/pypoetry/virtualenvs/tmp-M427n64X-py3.12/lib/python3.12/site-packages/chainlit/__init__.py", line 22, in <module>
    import chainlit.input_widget as input_widget
  File "/home/vscode/.cache/pypoetry/virtualenvs/tmp-M427n64X-py3.12/lib/python3.12/site-packages/chainlit/input_widget.py", line 5, in <module>
    from chainlit.types import InputWidgetType
  File "/home/vscode/.cache/pypoetry/virtualenvs/tmp-M427n64X-py3.12/lib/python3.12/site-packages/chainlit/types.py", line 10, in <module>
    from literalai import ChatGeneration, CompletionGeneration
  File "/home/vscode/.cache/pypoetry/virtualenvs/tmp-M427n64X-py3.12/lib/python3.12/site-packages/literalai/__init__.py", line 1, in <module>
    from .client import LiteralClient
  File "/home/vscode/.cache/pypoetry/virtualenvs/tmp-M427n64X-py3.12/lib/python3.12/site-packages/literalai/client.py", line 4, in <module>
    from literalai.api import API
  File "/home/vscode/.cache/pypoetry/virtualenvs/tmp-M427n64X-py3.12/lib/python3.12/site-packages/literalai/api.py", line 11, in <module>
    from literalai.helper import ensure_values_serializable
  File "/home/vscode/.cache/pypoetry/virtualenvs/tmp-M427n64X-py3.12/lib/python3.12/site-packages/literalai/helper.py", line 1, in <module>
    from openai.types.chat import ChatCompletionMessage
ModuleNotFoundError: No module named 'openai'
vscode ➜ ~/tmp $

Thanks for digging into it @moritalous - I meant to comment earlier but was unable to.
@willydouhard your point was helpful to indicate the intention regarding dependencies but the fact this happens immediately after a plain install suggests it would affect all users

I think I located the issue. You can try to upgrade the literalai package and this issue should be gone.

Excellent, that does the trick.
I ran:
pip install literalai --upgrade --no-cache-dir --use-feature=truststore
(I expect the no cache dir wasn't necessary)
and that bumped it up to 0.0.206.
Then chainlit 1.0.301 works fine, such as doing chainlit init which completes without any complaints.
Thank you for your efforts resolving this! 🙂

Awesome!


Parallel Letter Frequency times out in the web interface

In my local environment, my solution passes all tests in 1.4 seconds. Of this time, about 70% is spent running the serial solution in test_faster_than_serialized_answer. When this is run on the Exercism infrastructure, my solution times out. For giggles, I tried the example solution from this repo and this also times out. If I make my solution do nothing so that all of the time spent in the Exercism infrastructure is due to the serial solution, it doesn't time out, but obviously it doesn't pass the tests.
It seems that Exercism runners aren't fast enough or don't have enough parallelism to allow a parallel solution to run in the small amount of time left over after accounting for the fixed cost of the serial benchmark solution. Is it actually possible to have a solution succeed when running on the Exercism infrastructure? If not, can we reduce the size of the benchmark input to allow a solution to succeed?
Note that after submitting my failing solution, I saw that no community solutions are listed. Presumably this means that no one has a solution that can run in the time allotted.

With no change to my solution I'm now able to get it to run without timing out, but my solution fails test_faster_than_serialized_answer despite it succeeding locally. The example solution also fails test_faster_than_serialized_answer despite succeeding locally. Maybe the Exercism runner has only one core?

I have not submitted my solution or at least have not published it.  13 tests pass, one fails, and it is the one concerning benchmark in which we are working on.

Maybe the Exercism runner has only one core?

I suspect the docker container is only running on one core, yeah.


As a visitor, I want to let the owner know I read the message

The visitor should be able to click they read the message. This should also be shown on the code page

[Duplicate of #22] It is hard to see when somebody have read the message. Would be nice to have some confirmation. Because I want a specific person to have read the message, this cannot be automated by somebody who just visited the code.
There is no way for a computer to distinguish between the person the message is meant for and a random visitor. Both are anonymous users. Only the person the message is meant for knows.

Styling is now also done. When there are multiple choice questions, the icon of the answer can be used as the is_read icon
Now also merged with the main branch again


Minor updates in preparation for 1.0.0 release

Set version to 1.0.0-incubating-SNAPSHOT
Removed unnecessary whitespace
Added missing @since tags
Excluded .impl. packages from javadocs
Removed unnecessary public modifiers from public interface methods
Fixed method misspelling in SimpleSerializer
Set Accumulo min version in pom.xml to 1.6.5 to match Fluo

+1


feat(linter): implement unicorn/no-unnecessary-await

related to #684

Thank you! This is a really nice rule.


[BUG]: beanie cannot be imported in Python 3.11 using current MongoDB's motor

Describe the bug
Should be able to "import beanie"
To Reproduce
Just run the line: import beanie in Python 3.11
Expected behavior
Runs successfully.
Additional context
Get this error, just try to import in the REPL
Python 3.11.0 (main, Oct 24 2022, 19:46:22) [GCC 11.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import beanie
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/code/venv/lib/python3.11/site-packages/beanie/__init__.py", line 1, in <module>
    from beanie.migrations.controllers.free_fall import free_fall_migration
  File "/code/venv/lib/python3.11/site-packages/beanie/migrations/controllers/free_fall.py", line 4, in <module>
    from beanie.odm.documents import Document
  File "/code/venv/lib/python3.11/site-packages/beanie/odm/documents.py", line 19, in <module>
    from motor.motor_asyncio import AsyncIOMotorDatabase
  File "/code/venv/lib/python3.11/site-packages/motor/motor_asyncio.py", line 18, in <module>
    from .frameworks import asyncio as asyncio_framework
  File "/code/venv/lib/python3.11/site-packages/motor/frameworks/asyncio/__init__.py", line 27, in <module>
    from asyncio import coroutine  # noqa: F401 - For framework interface.
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ImportError: cannot import name 'coroutine' from 'asyncio' (/usr/local/lib/python3.11/asyncio/__init__.py)

@roman-right I put this here so you know, but realize it may a knock on error from motor. :(

It looks like asyncio.coroutine was removed intentionally as a breaking change:
https://github.com/python/cpython/issues/87382
Sadly, it seems MongoDB hasn't been on top of that. I checked the github repo for motor and they don't have public issues section so I can't file it there.
@roman-right , feel free to close this now or we can wait until the next release of motor which hopefully would fix this.

Motor just updated to 3.11 and all seems well.

Oh, nice! I planned to make a PR there today, but it is fixed already. MongoDB guys are fast :)