Check if the CoMs are in the correct place

Hi @imihasan, and happy new year!
I am checking now where the CoM of the various bones in Ajay's model are, as I remember that from our last meeting we concluded that they came from one dataset, while the geometries used came from another. It looks to me that the center of masses (and consequentially also the inertias) might be a bit off. Probably not too much, otherwise the model would have never worked in the first place, but maybe something to discuss in the next meeting as well?
Here you can see the image depicting where the CoMs  are (I obtained it in OpenSimCreator, which offers a convenient functionality to visualize their location):

Hi @itbellix , welcome back!!
Thanks for pointing that out! I think the CoMs should be alright. Typically in anthropometric datasets the inertial properties are properties of the body segments considering bones, muscles, skin and other soft tissues around. If you look at the humerus you notice that the CoM is a bit off the bone geometry. That's because biceps and surrounding muscles are considered in the computations. I will double check all the inertial properties after finishing elbow muscles and moment arms. I will keep the issue open until then.
For now I have a question on that point. Do you think inertial properties of the thorax would affect the muscle redundancy solution? When we find induced accelerations, distal segments have effect, but muscles in the same time attach on the thorax. What do you think? I set the mass of the thorax to a very big number and it had a minor change I believe. You may try that and let me know what you think.

Hey @imihasan, thanks for double-checking. I agree with you that the position of the CoMs appears reasonable, I was indeed forgetting that the soft tissues are also accounted for in their computation!
For what concerns the inertial properties of the thorax, I would expect that they would not matter when the thorax movement is completely replicated through coordinate actuators. I do not think that the muscle attached to the thorax would be influenced by the thorax' inertial parameters, the only thing that matters should be the correct pose of the thorax itself (which will determine the muscle parameters to be considered, such as muscle-tendon length, direction of the force exerted, and so on). So, I think that the changes in muscle activation that you observe are an indirect effect: as the optimization scenario changes to accommodate for the new inertial properties of the system, this has a sort of "spill-over" to the muscle activations as well, as the minimum found is not the same one as before. The changes should however be very small, if my reasoning is correct.
Does this make sense?

Hi @itbellix ,
I think it makes sense. Thanks for clarifying this!


Unable to set  listen-client-urls to all interfaces <IP_ADDRESS> in proxy mode

If I set the listen-client-urls to http://<IP_ADDRESS>:2379  with proxy on then the Proxy fails to setup due to
proxy: failed to direct request to http://:2379: dial tcp :2379: cannot assign requested address
Once I change it to use a specific ip address it works.
Edit:  Using etcd 2.0.8
Edit: Further testing shows that if I list the same port on multiple ip's it also fails.
e.g.
listen-client-urls: http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:4000,http://<IP_ADDRESS>:4000
However listen-client-urls: http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:4000  works and so does listen-client-urls: http://<IP_ADDRESS>:2379,http://<IP_ADDRESS>:4000 just not the combined set.

A bit more background. I;m using the coreos 653 version with etcd2 operational. I presently have a 3 member cluster running etcd2 happily. I'm now adding in additional nodes as proxy's into the same cluster and this is failing with the above. Even once I get etcd2 to startup well I rapildly run out of files. netstat shows 26k->40k in seconds and random failures. So something is going crazy on the proxy. For now Ill just switch to all active nodes to move on with my life.

For those who pass in the future. My issue was the initial 3 member cluster had an incorrect variable expansion on the clientURLs which was where http://:2379 was coming from. So the proxy would connect, get a broken set of URLs and then go into a very tight loop wasting FD's (TIME_WAIT). The proxy should probably be a little less aggressive here, or at least detect the bad url's eariler.

@timechanter I think the tight loop on proxy that eats up all fds on etcd server is a big problem. Could you open an issue for it?


Support function and operation types without parentheses

Is your feature request related to a problem? Please describe.
The parentheses required around function and operation types is excessive. For example:
function Apply1(f : (Int -> (Int -> Int))) : (Int -> Int) {
    return f(1);
}

function ApplyAdjoint(op : (Qubit => Unit is Adj)) : (Qubit => Unit is Adj) {
    return Adjoint op;
}

Describe the solution you'd like
I would prefer to write:
function Apply1(f : Int -> Int -> Int) : Int -> Int {
    return f(1);
}

function ApplyAdjoint(op : Qubit => Unit is Adj) : Qubit => Unit is Adj {
    return Adjoint op;
}

Describe alternatives you've considered
N/A
Additional context
N/A

Is there a difference between a function that takes an Int to Int function and returns an Int: (Int -> Int) -> Int
and a function that takes an Int and returns and Int to Int function: Int -> (Int -> Int)?
If so, such a distinction may be lost if both get represented as Int -> Int -> Int

Yes, those types are different. -> and => are right-associative, so the parentheses implicitly build up right-to-left.

a -> b -> c is a -> (b -> c)
a -> b -> c -> d is a -> (b -> (c -> d))

This is the most common associativity for arrow types and is used in languages like F# and Haskell to concisely express curried function types (although currying is less common in Q#). To express a function that takes in another function, parentheses are required as in (Int -> Int) -> Int.

This is the most common associativity for arrow types and is used in languages like F# and Haskell to concisely express curried function types (although currying is less common in Q#).

Possibly relevant, but even though currying is uncommon in Q# at the moment, the input ordering convention for Q# APIs is designed to look like currying, in that the most commonly omitted inputs should be the right-most inputs.

This is the most common associativity for arrow types and is used in languages like F# and Haskell to concisely express curried function types (although currying is less common in Q#).

Possibly relevant, but even though currying is uncommon in Q# at the moment, the input ordering convention for Q# APIs is designed to look like currying, in that the most commonly omitted inputs should be the right-most inputs.


Stop using relative-path in import statement.

In our absolute modules, we are using relative paths in import statement to load other modules.
For example,
// in server/order/router/order_router.js

import * as order from '../controller/order_controller';

It makes using import statement difficult.
If we can use import statement as follows, it will be convenient.
import * as order from 'order/router/controller/order_controller';

Close this issue, you can re-open it if you want.


ISPN-6952 JCacheTwoCachesAnnotationsTest no need to clear caches befo…

…re killing CMs
https://issues.jboss.org/browse/ISPN-6952

I have a new strategy. Will push it soon.

@danberindei here is my latest proposal:

create/destroy explicit cachemanagers only before/after test (and not per-method)
clear caches after method

The implicit cachemanager is created on the fist invocation to JCacheAnnotatedClass's methods and destroyed on undeployment.

Integrated, thanks Tristan!


Default template used for email notifications

The default template is always used for email notification.
Also the color scheme is really hard to read, or is this just me?

Just you, my install looks nothing like that.

Just you, my install looks nothing like that.

Hi @redex557,
What email client are u using? I do not have this problem in gmail..

Hi @redex557,
What email client are u using? I do not have this problem in gmail..

Hey,
I'm using Thunderbird to view my emails. Same thing with "Fair Mail" on my android phone.

Hey,
I'm using Thunderbird to view my emails. Same thing with "Fair Mail" on my android phone.

Fixed this in https://github.com/ssl/ezXSS/commit/8482ba99bb463fbe247b48aff24efef72d416691

Fixed this in https://github.com/ssl/ezXSS/commit/8482ba99bb463fbe247b48aff24efef72d416691


Magisk V27.0 not detected

Magisk not detected using magisk V27.0
Abnormal Environments are all checked and not found

SleimanB Did you find any solution for that?


Add Adaptive Pure Pursuit control

I think we can improve the janky autonomous pathing with the help of pure pursuit.
I'll try to implement a controller

Added by #198


Generate Workspace Avatar Color based on PolicyID instead of Workspace Name

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/39478
PROPOSAL: https://github.com/Expensify/App/issues/39478#issuecomment-2034020967
Tests

Open Workspace setting
Change workspace name
Verify that: Workspace icon don't change color

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Open Workspace setting
Change workspace name
Verify that: Workspace icon don't change color

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/161821005/1e2fd323-2e8e-4dde-b78c-42b3766a82b9

Android: mWeb Chrome

https://github.com/Expensify/App/assets/161821005/0f12e62d-cd3f-48c5-a56e-f40888a5ed3f

iOS: Native

https://github.com/Expensify/App/assets/161821005/a33373ea-90fd-4a3d-a9de-447921af65a7

iOS: mWeb Safari

https://github.com/Expensify/App/assets/161821005/a5904be6-23fc-42ee-9720-2e6be0062bcd

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/161821005/61628b25-26a6-420a-8465-52096101266a

MacOS: Desktop

https://github.com/Expensify/App/assets/161821005/b98875e3-d5f2-46c6-bbf7-9cb81e67e4a8

Looks good from a design standpoint.

Looks good from a design standpoint.

Dangit Shawn you beat me by ONE minute! 😂

@rushatgabhane friendly bump

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@nkdengineer how's it looking?

@rushatgabhane please check again

bug
https://github.com/Expensify/App/assets/38015950/56508b63-b33b-4171-9508-1aa7e03aef47
preview image is a different color @nkdengineer

@grgia Updated to fix this case.

@nkdengineer could you merge main?

@grgia I merged.

@grgia Merged main.

🚀 Deployed to staging by https://github.com/grgia in version: 1.4.69-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@nkdengineer @grgia we have a regression from this PR https://github.com/Expensify/App/issues/41385
Can anyone please take a look

I also noticed a few buggies.
Looks like the header is using a different color as the report preview, but it seems related to the regression above:

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.69-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Discontinue iNav support

Supporting iNav & MAVLink is very time consuming for a single developer and makes the system more complicated since iNav "needs" two serial ports (MSP & LTM)
Looks like Ardupilot now supports cheaper hardware, so the big advantage of iNav over price seems to be gone now. Does it make any sense to keep supporting iNav? Ardupilot looks like the go-to option for me:

Better library support, SITL Simulator
Better documentation
More features
Bigger community

But the Ardupilot GUI is a mess. The INAV GUI is a lot cleaner these days

I think iNav is pretty irrelevant these days. Maybe make it like a module and try to carry it on to newer versions and don't implement features for it which would require changes to the core iNav communication. Or maybe someone in the community could do it?


Added managed script for under min isr partitions

This is a managed script for the under min ISR alert in Kafka. It's pretty much a copy paste of the under replicated partition managed script as the kafka.py class already has the logic to handle partitions that are under minimum ISR.

@pepedocs, @vinaybommana, @pat-cremin can you review please?

@pepedocs Thanks for poiting out that typo. I've fixed it now, can you approve again please?

/assign @wanghaoran1988

@wanghaoran1988 Can we get this approved/merged please?


[ART-1392] add json/yaml format print to rpmdiff show

this is still an early experiment since I do not know what information we need to display and what kind of structure of yaml/json we need here, currently I just grab all the dict info I could get and dump it all.
https://issues.redhat.com/browse/ART-1392
@vfreex @sosiouxme
yaml output: https://gist.github.com/shiywang/c3a37e91e4ecce22da9c3b2a6b1e85f9
json output: https://gist.github.com/shiywang/8769052c1119cc5dd56d1ec96c2de45b

@vfreex PTAL

Didn't try this, but LGTM!
/lgtm


Add getting started walkthrough

This PR adds a walkthrough that points to the first 4 markdown pages under the Project Explorer heading in our docs.
Also should fix some issues with images using <img> tags not rendering.

Closing as new PR created -> #465


Add allocationAmount value in GET products capacities endpoint (/v2/capacity) response

Context
We need to sort the products on Buy Cover page by booked/used capacity (aka active cover amount, or allocationAmount). Atm we get products capacities values from the cover router api /v2/capacity GET endpoint. To support the sorting feature we need to get data for the booked capacity as well.
It would be great to have that info passed on the same endpoint response.
The current response looks like:
type CapacityApiResponse = {
  capacity: Array<{
    assetId: string;
    amount: string;
  }>;
  productId: string;
};

The new response would be great to look like:
type CapacityApiResponse = {
  capacity: Array<{
    assetId: string;
    amount: string;
  }>;
  allocationAmount: string; // always denominated in NXM so no need for assetId
  productId: string;
};

Naming of the new field can be discussed if something else makes more sense in the given context.

To avoid confusion, let's use the following terminology:

rename capacity to availableCapacity
rename allocationAmount to allocatedNxm

cc @MilGard91 - pls update the PR
cc @mixplore for awareness


bump git2 dependencies

This required some manual code changes which dependabot could not perform.

r? @Eh2406
(rust_highfive has picked a reviewer for you, use r? to override)

Ci seems unhappy.

Ci is green so:
@bors r+
Thanks for the PR!

:pushpin: Commit 8245e02924b5d5c082f982f811622bb1cb75ade7 has been approved by Eh2406

:hourglass: Testing commit 8245e02924b5d5c082f982f811622bb1cb75ade7 with merge b42bec7f9964a6587bcdaf8af1137ce39dcb7407...

:sunny: Test successful - checks-azure
Approved by: Eh2406
Pushing b42bec7f9964a6587bcdaf8af1137ce39dcb7407 to master...


[Nova] Add windows conda workflows

[Nova] Add windows conda workflows
Same as: https://github.com/pytorch/vision/pull/7547

cc @mthrok @hwangjeff


Change the CI from Travis CI to GitHub Actions

The build and publishing process currently is a back and forth between Travis CI and GitHub orchestrated via script fu.
It would be more convenient if we could stay within GitHub by using GitHub actions as this allows us to have less magic environment and directly use the convenient actions provided by https://github.com/actions-rs.

This was fixed in #33


Support for schema and client directive mapping

SPQR should enable registration of custom schema and client directives, where schema directives are directives on schema elements, such as types, field definitions etc and client directives are directives on query elements, such as fields, fragments etc.
Since SPQR generates the schema from Java, the benefit of schema directives are questionable, as regular Java constructs such as annotation can be used seamlessly to provide any needed meta-data. Still, directives can sometimes be preferable as they are language-neutral GraphQL concepts (e.g. if the team also maintains a Node.js GraphQL server, and wishes to keep the implementations as similar as possible).
Client directives, on the other hand, have no alternative and are useful in many scenarios (basically whenever the client needs to provide some meta-data in addition to the query). SPQR should have a convenient way to map custom client directives and inject their deserialized values into the resolver methods.
Adding custom directives
To customize the way directives are mapped, a user can register an implementation of DirectiveBuilder via GraphQLSchemaGenerator#withDirectiveBuilder.
There is an annotation-driven implementation AnnotatedDirectiveBuilder already provided, that works in a similar fashion to other default SPQR components.
Schema directives
Any custom annotation meta-annotated with io.leangen.graphql.annotations.types.GraphQLDirective will be mapped as a directive on the annotated element.
E.g. imagine a custom annotation @Auth(requiredRole = "Admin") used to denote access restrictions:
@GraphQLDirective //Should be mapped as a GraphQLDirective
@Retention(RetentionPolicy.RUNTIME)
@Target({ElementType.METHOD}) //Applicable to methods
public @interface Auth {
        String requiredRole();
}

If a resolver method is then annotated with @Auth:
@GraphQLMutation
@Auth(requiredRole = {"Admin"})
public Book addBook(Book newBook) { ... }

The resulting GraphQL field fill look like:
type Mutation {
  addBook(newBook: BookInput): Book @auth(requiredRole : "Admin")
}

That is to say the @Auth annotation got mapped to a directive, due to the presence of @GraphQLDirective meta-annotation.
Client directives
To register a client directive, GraphQLSchemaGenerator#withAdditionalDirectives(java.lang.reflect.Type...) should be used.
The given types will then be mapped as additional directives.
E.g. for a class such as:
public static class Interrupt {
    // Public field used only to keep the example brief. A regular property would behave the same.
    public int after;
}

registered via generator.withAdditionalDirectives(Interrupt.class), a client would be able to use the @interrupt directive:
{
    books(searchString: "Monkey") @interrupt(after: 500) {
        title
    }
}

To customize the directive name, valid location etc, use the same io.leangen.graphql.annotations.types.GraphQLDirective:
@GraphQLDirective(name = "timeout", locations = Introspection.DirectiveLocation.FIELD)
public static class Interrupt {
    @GraphQLInputField(name = "afterMillis") //Customize the fields as usual
    public int after;
}

Now the directive is called @timeout, is only applicable to a field and has an argument called afterMillis:
{
    books(searchString: "Monkey") @timeout(afterMillis: 500) {
        title
    }
}

Now, to get a hold of the value provided by the client, use @io.leangen.graphql.annotations.GraphQLDirective (different annotation than the one used to customize the mapping):
@GraphQLQuery
public List<Book> books(String searchString, @GraphQLDirective Interrupt timeout) {
    System.out.println(timeout.after); //Prints "500"
    ...
}

If the same directive is present multiple times, e.g.:
query Books @timeout(afterMillis: 10) {
    books(searchString: "monkey") @timeout(afterMillis: 5) {
        id
    }
}

The value injected by @GraphQLDirective Interrupt timeout will be the most specific one (the one on the field, with afterMillis: 5 in this case).
It is also possible to specify the location for the directive value to be picked from:
@GraphQLQuery
public List<Book> books(String searchString, @GraphQLDirective(locations = Introspection.DirectiveLocation.QUERY) Interrupt timeout) {
    System.out.println(timeout.after); //Prints "10", as provided on the query level
    ...
}

But it is also possible to inject all the values:
@GraphQLQuery
public List<Book> books(String searchString, @GraphQLDirective List<Interrupt> timeouts) {
    System.out.println(timeouts); //Prints "[5, 10]". The most specific value goes first.
    ...
}

The same rules apply if there are multiple directives of the same type on the same level.
In some edge cases, it might be necessary to specify the name of the directive when injecting its value. E.g.
@GraphQLQuery
public List<Book> books(String searchString, @GraphQLDirective(name = "timeout") Object timeouts) {
    ...
}

The explicit name is required because it's impossible to deduce anything from the Object type.

it does not support field.
query Books {     books(searchString: "monkey") {         id @timeout(afterMillis: 5)      } }
@GraphQLQuery public List<Book> books(String searchString, @GraphQLDirective List<Interrupt> timeouts) {     System.out.println(timeouts); //Prints null     ... }
@GraphQLDirective timeouts
print out null
how does it support @GraphQLDirective to get field?

it does not support field.
query Books {     books(searchString: "monkey") {         id @timeout(afterMillis: 5)      } }
@GraphQLQuery public List<Book> books(String searchString, @GraphQLDirective List<Interrupt> timeouts) {     System.out.println(timeouts); //Prints null     ... }
@GraphQLDirective timeouts
print out null
how does it support @GraphQLDirective to get field?


hope list vue version supports scrollLoading related features

[ ] I'm sure this does not appear in the issue list of the repository

基本信息
现有案例
react  list component
预期解决问题
hope list vue version supports scrollLoading related features

@djkloop 收到，这个功能会支持一下


plugins/barbar: add keymaps.* options for missing actions

A couple of :Buffer* commands didn't have a corresponding option under plugins.barbar.keymaps. This PR adds in the missing ones.

@iSma I have included those changes directly in #1608.
Hence, I'll be closing this issue.


Support Reversed cards

The current note type only supports one way cards. I realise I never added a reverse card. This can be quite useful for some so we should have a reversed variant of the note type

This is now in main from https://github.com/jasonwilliams/anki/commit/4570ffd5fe02a5ccdfda53d8f245320145ba09ac and should be available in the next release


[Critical] Onecheckout preventing to continue to shipping method after selecting address

Bug report
Bug
In onecheckout page, request to checkout/save-address fails sometimes.
Issue Description
In onecheckout page, request to checkout/save-address fails sometimes. It prevents the user to continue selecting the shipping method/payment method, thus preventing placing an order.
Preconditions

Bagisto version: latest at time of writing
At least one address must be saved in the user account

Steps to reproduce
1. Go to one checkout
2. Select saved address
3. If flows continues to shipping method, reload
4. Select saved address
5. Request fails

Expected result
The address should be saved and continue to the next step. (Shipping method)
Heres a video showing the issue: https://www.dropbox.com/s/1r5mk6e6az7nb86/bagisto error.mov?dl=0
Error log:
local.ERROR: Trying to get property 'id' of non-object {"exception":"[object] (ErrorException(code: 0): Trying to get property 'id' of non-object at packages/Webkul/Shipping/src/Shipping.php:85)

Actual result

Request to save-address fails
Selected address gets saved 3 times
Flow does not continue to shipping method

I think this bug is critical because it can prevent users from placing an order and abandoning the site.
Thank you.

@chemisax
Thanks for notifying the bug.
Bug is already solved in master branch https://github.com/bagisto/bagisto/issues/2987 please update the code.

@vaishaliwebkul
Thank you, I've updated from master several days ago so it might be a delay.
Thank you.

I've just install a fresh app but still having the same issue

@vaishaliwebkul can you tell me how you fixed this bug as i am almost done with my project and i made alot of changes in core so update code is not possible for me ..please waiting for your response

Hi @arooba499
In this case, you can update the files as mention in this pull request https://github.com/bagisto/bagisto/pull/3008
Thanks


Compatibility of Mock LLM on the #Select feature

The bug
The current implementation of Mock LLM use #select.
To Reproduce
Give a full working code snippet that can be pasted into a notebook cell or python file. Make sure to include the LLM load step so we know which model you are using.
import guidance
default_ans = ['C' for _ in range(200000)]  # Choose C for default
llm = guidance.llms.Mock(default_ans)
program = guidance(""""ANSWER: {{#select 'answer'}}A{{or}}B{{or}}C{{or}}D{{/select}}""", llm=llm)
program()

It will raise: AttributeError: 'Mock' object has no attribute 'end_of_text'
System info (please complete the following information):

OS (e.g. Ubuntu, Windows 11, Mac OS, etc.): tested on Linux and MacOS
Guidance Version (guidance.__version__): '0.0.63'

I think this works in the new release (It's now called LocalMock).
Sorry it took us so long to get to this :)


Fix: is404() not detecting new 404 pages

Description

is404() can not detecting new 404 pages

https://github.com/fregante/GhostText/tree/3cacd7df71b097dc525d99c7aa2f54d31b02fcc8/chrome/scripts/InputArea
https://github.com/refined-github/refined-github/blob/some-non-existent-ref/source/features/bugs-tab.tsx

related:

https://github.com/refined-github/refined-github/issues/6413

Thank you, but we can't do this.
The original 404 pages had zero UI on them so the whole extension was disabled, with the exception of useful-not-found-page.
These new 404 pages are actually just repo pages that have a "not found" area, so they still benefit from a host of other repo-wide features like bugs-tab
To fix https://github.com/refined-github/refined-github/issues/6413, we need to have a separate isRepo404 detection, perhaps, and then add a new init in useful-not-found-page to handle this new view.

I'll fix this branch as detecting isFile404


Fix inconsistent behaviour of Container.inspect

container.inspect() is supposed to return a Promise not a stringified object

Yup legacy pre-promise code left behind.
Could you please do the same for the other object's inspects? (image, network, etc)
So everything is consistent.

@apocas done!

Published v2.4.0


could we apply Alibi with rotary position embedding?

Hi Ofir (@ofirpress ),
Thanks for the great work. ALiBi greatly solves many problems :)
I'm curious if you've attempted to integrate any other position embedding techniques with the ALiBi approach. It appears that these methods would not conflict with each other, as the former is applied prior to the input being fed to the layers, while ALiBi is integrated just before the computation of the softmax attention score.
Thank you again for the great work.
best,
Xiaoxia

You can try this but I think they probably would conflict with each other. Models trained with absolute position embeddings overfit to those positions. ROPE uses absolute position embeddings. You can read more about my thoughts on this here: https://ofir.io/The-Use-Case-for-Relative-Position-Embeddings/


App Service can not Push - 400 Error Code

I have declared in my client's DB some extra table columns that don't exist in the backend DB. With Mobile Services I had no problem while syncing, but with App Service, I get the following error when I push an "add action (POST request)":
400 error Code, error message=The request is invalid. Could not find member 'homecountry' on object of type 'Contact'. Path 'homecountry', line 1, position 550.
Where homecountry is the extra client column of the table Contact.
It seems that the backend of the Mobile Services ignored the extra fields of the client, but App Service does not.
What has really happened?

That was the case. During parsing, the Mobile Services ignored the fields that didn't match the model, but App Service does not. You have to use this Json.MissingMemberHandling.Ignore.


When multiple method signatures exist, clicking a link within one does nothing

See for example https://docs.convergence.io/js-api/classes/historicalmodel.html#elementat. Clicking a link within the signature definition should navigate to that link, instead it just toggles the currently visible one.

Resolved by #81, I'll leave this open to track the next release

Fixed in v0.6.1


Wrong simplified Chinese translation such as "向竖起大拇指移动焦点"

Windows Terminal version (or Windows build number)
1.7.1033.0
Other Software
No response
Steps to reproduce
Language: Simplified Chinese
设置 (settings) -> 操作

Expected Behavior
It seems that some of the translations are wrong:

Not 下面是当前绑定密钥, it should be 下面是当前绑定热键
Not 向 向下移动焦点, it should be 向下移动焦点
Not 向 竖起大拇指移动焦点, it should be 向上移动焦点
Not 打开设置。。。, it should be 打开设置

Actual Behavior

Thanks for the feedback! I've posted similar localization defects in #9328. Could you also organize these recommendation like that? It could be really helpful for us.

@skyline75489 Sorry, where can I get the key values like Globals_LaunchModeMaximized.Content?

Those strings are inside the source code of the terminal repo. If you can't find them, don't worry about it. I can fill up a table later.

发件人: Hammer_Zhang @.>
发送时间: 2021年5月6日 18:38
收件人: microsoft/terminal @.>
抄送: Chester Liu @.>; Mention @.>
主题: Re: [microsoft/terminal] Wrong simplified Chinese translation such as "向竖起大拇指移动焦点" (#10043)
@skyline75489https://github.com/skyline75489 Sorry, where can I get the key values like Globals_LaunchModeMaximized.Content?
―
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/microsoft/terminal/issues/10043#issuecomment-833421893, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABD6BL3OBYT3JXGKIT2SK63TMJWT7ANCNFSM44GFIBHQ.

In English, those resources can be found here: https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw. I think the translations get patched in later, so the chinese versions aren't anywhere in the repo.
Looks like these are mostly just translations for various different actions, so that's not totally unexpected. @DHowett should we just combine these with the rest in #9328?

The wrong translation of "密钥" is already mentioned in #9328 .

Key
Recommandation
Comment

ResetFontSizeCommandKey
Change the translation of "font size" to "字体大小"
"字号" is not a wrong translation, but not so accurate

DirectionUp
上
not "竖起大拇指"

DirectionDown
下
not "向下", otherwise there will be two duplicate "向"

OpenSettingsUICommandKey
Change "。。。" to "..." or "......"

@skyline75489 You should be selfhosting 1.9 if you go to the store and update -- can you check your strings? :smile:

@DHowett I've received the 1.9 selfhost version and looks like most of my strings are better localized (don't really wanna brag but it is a lot better now). I'll double-check and file another issue to supersede this later. Let's squash those localization bugs before 2.0 😄

Hi @JingHuaMan I'm closing this in favor of #10174. Take a look if you like 😄

My Windows Terminal still use "密钥" represent key rather than "热键", does this issue already fixed?
Windows Terminal version: 1.11.2921.0, from Microsft store
OS version: Windows 10 21H1(19043.1288).


List Management - Action Bar Depreciation

All List management pages should have their action bars removed.
only All works needs the action bar.

(If yes, list here)
Screenshot
(Link above will always be the most up-to-date version.)

god that looks good!!!


[Request] Add DeepseekChat

https://twitter.com/yacinemtb/status/1753115219872846186?s=12&t=90xQ8sGy63D2OtiaoGJuww
https://chat.deepseek.com/sign_in
https://chat.deepseek.com/coder

also add
groq chat
https://gab.ai/
aistudio

add gemini separate from ai studio https://gemini.google.com/app


Let's Encrypt certificates don't work on mail in multiple domain servers

Hi.
I have a cloud server to hosting multiple webpages with a domain for each. I try to create Let's Encrupt certificates for each domain but this certificate doesn't work with the SMTP, POP3 or IMAP connections. All my clients works with Outlook or Thunderbird and this software thows error with the certificates. ¿Can be posible create a mail server certificate with all the domains names?
Thanks in advance.

The issue goes further:
If you enter an email address in a client (like thunderbird or on ios) the client assumes that the imap server is imap.domain.tld and the smtp is smtp.domain.tld.
If you use the lets encrypt certificate for domain.tld, users always get errors that the certificate is not ok because it's a different domain.
Since mail servers can only have one certificate you're basically stuck with this since the plesk addon does not yet allow aliases or wildcards (or the ui is not clear enough and I have no idea how to do it).
Anyway: How do other users do it? I'm always telling the users to use "domain.tld" but in 9/10 cases, they just f* up and use the standard mail client settings.

@digitall-it I reported that and they fixed the docs here: https://docs.plesk.com/en-US/onyx/administrator-guide/plesk-administration/securing-plesk/securing-plesk-and-the-mail-server-with-ssltls-certificates.59466/
"Note: If you secure the Plesk mail server with an SSL/TLS certificate, make sure to use the domain name for which the certificate was issued when connecting to the mail server, and advise your customers to do the same. Otherwise, the mail client software may be unable to verify the mail server identity, which may cause issues when sending or receiving mail."
A solution would be if only Plesk could generate multi-domain Let's Encrypt certificates.

Grazie, Marco.

This is not a LE issue but a Plesk TLS implementation issue on SMTP/IMAP/POP services.
see this:
https://support.plesk.com/hc/en-us/articles/115002974174-Is-there-SNI-support-for-SMTP-IMAP-POP3-
https://plesk.uservoice.com/forums/184549-feature-suggestions/suggestions/32132116-it-would-be-nice-to-provide-mail-ssl-tls-support-w

Plesk says it is a mailserver implementation issue, not theirs. But Dovecot has SNI support. So we should Uservoice it. https://plesk.uservoice.com/forums/184549-feature-suggestions/suggestions/32132116-it-would-be-nice-to-provide-mail-ssl-tls-support-w

Hi Still no news on this vital requirement ? Very weird it hasn't been fixed already. Pleask is a great tool and this lacking feature is completely ununderstable.THANKS !


Extract optional functionality into go plugins

There is some amount of functionality that depends on external tools/libraries. Like FIDO2 support. Currently it uses command-line tools for communication. But this interface is usually brittle and inconvenient. It would be great to use libraries with C API directly. But instead of linking to these libs it would make sense to use go plugins to have these dependencies truly optional.

While brittle, inconvenient and in theory less performant, it's simpler and lets the init process be free of CGO. See https://github.com/anatol/booster/pull/240


Something doesn't work

When I run liftoff in a empty directory I get error "Could not find an Xcode project file. You need to run me from a valid project directory."

Is it my fault?

You're using an incredibly (over 1 year) old version of Liftoff. Uninstall that version (gem uninstall liftoff) and install the version from Homebrew as outlined in the README


Support for outlineVariant and scrim color

Fixes #57
We are missing the outlineVariant and scrim color. And in material3 we use outlineVariant for Dividers.
So, Added outlineVariant and scrim color.

any updates on this?
I just upgraded to Flutter 3.7 and noticed the wrong colors on the Divider components.

any updates on this?
I just upgraded to Flutter 3.7 and noticed the wrong colors on the Divider components.


Bump Lens fork version

Bump Lens fork version to commit that will properly parse Tendermint Liquidity types, but keep them ignored (this will allow CosmosHub to be indexed without failing).
Closes #383
How it Works
I have used a new method suggested by @jtieri to handle the Tendermint Liquidity message types in our Lens fork.
Instead of including the entire module, I have just done the following:

Included the Message proto file only  - source
Generated the Message protobuf message type definitions using the buf program

source

Built the Tendermint Liquidity Message interface definitions and Codec implementation:

Message interface definitions - source
Codec implementation - source

Included the Codec in the base Lens codec - source

How it was Tested
I tested this in 2 ways on 2 different branches to make sure the above process works. One way is the way we are taking the main branch (this PR), the other way is a branch I was working on to support indexing the messages.
Testing blocks
I ran the code on the following CosmosHub blocks:

7453602 - has Tendermint Liquidity TX DepositWithinBatch
8318996- has Tendermint Liquidity TX SwapWithinBatch
10121645 - has Tendermint Liquidity WithdrawWithinBatch

This Branch
On this branch, the code ignores the above Message types in Liquidity.
We have decided to continue to ignore the messages since the Liquidity modules executes the actual work for Swaps, Deposits and Withdraws in the EndBlocker state transition.
See this PR for details: https://github.com/DefiantLabs/cosmos-tax-cli/pull/391
Alternate Branch - The initial push to index Tendermint Messages
I used this branch here: 383-tendermint-liquidity-message-indexing
Before taking the codebase in the above direction with the linked PR, I had implemented Message Indexing for DepositWithinBatch and WithdrawWithinBatch.
The methods followed our normal message indexing, requiring message specific handlers and type parsing.
Using the new Lens fork branch, I was successfully able to index the above message types, e.g.:
Block: 7453602] Cosmos message of known type: MsgDepositWithinBatch: cosmos1sr0lw3rnl4u3zz7hxrek0pp26hjhapecr4dyyj deposited 4250003ibc/2181AAB0218EAC24BC9F86BD1364FBBFA3E6E3FCC25E88E3E68C15DC6E752D86, 689313uatom
...
DBG [Block: 10121645] Cosmos message of known type: MsgWithdrawWithinBatch: cosmos1sr0lw3rnl4u3zz7hxrek0pp26hjhapecr4dyyj withdrew 23poolF2805980C54E1474BDCCF70EF5FE881F3B8EFCF8BA3198765C01D91904521788

I am including this portion of the writeup to prove that the new methodology in our Lens fork allows us to index the message without including the entire Tendermint Liquidity module.
Going Forward
I highly recommend we continue to use this methodology when we need to include new Blockchain modules within the indexer for the following reasons:

It keeps our Lens fork lightweight - we only need to index messages, so we should not include entire modules
We do not need to worry about figuring out how to include entire modules for differing blockchains
It takes advantage of the generalized nature of protobuf

Great write up, thanks!


Angularfire doesn't load app.component.html

I have a angularfire app that works perfect when I run it in my localhost. When I deploy it to firebase it doesn't give me any error in the console or in the browser's console. I can see my app-root component when I inspect the page BUT it doesn't load the components so my page appears blank.
<!doctype html>
<html lang="en">
<head>
  <meta charset="utf-8">
  <title>JM</title>
  <base href="/">

  <meta name="viewport" content="width=device-width, initial-scale=1">
  <link rel="icon" type="image/x-icon" href="favicon.ico">
  <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.12.4/jquery.min.js"></script>
  <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-beta/css/bootstrap.min.css" integrity="sha384-/Y6pD6FV/Vv2HJnA6t+vslU6fwYXjCFtcEpHbNJ0lyAFsXTsjBbfaDjzALeQsN6M" crossorigin="anonymous">
  <script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.11.0/umd/popper.min.js" integrity="sha384-b/U6ypiBEHpOf/4+1nzFpr53nxSS+GLCkfwBdFNTxtclqqenISfwAzpKaMNFNmj4" crossorigin="anonymous"></script>
  <script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-beta/js/bootstrap.min.js" integrity="sha384-h0AbiXch4ZDo7tp9hKZ4TsHbi047NrKGLO3SEJAg45jXxnGIfYzk4Si90RDIqNm1" crossorigin="anonymous"></script>
  <link href="https://maxcdn.bootstrapcdn.com/font-awesome/4.7.0/css/font-awesome.min.css" rel="stylesheet" integrity="sha384-wvfXpqpZZVQGK6TAh5PVlGOfQNHSoD2xbE+QkPxCAFlNEevoEH3Sl0sibVcOQVnN" crossorigin="anonymous">

</head>
<body>

  <app-root></app-root>
</body>
</html>

firebase.json
{
  "hosting": {
    "public": "src"
  }
}

File structure:

Commands I ran to deploy to firebase:
ng build --prod
firebase deploy

I think is because when I run ng build --prod doesn't move the src folder to it?

The built output is place in the dist folder by default.
Deployment is currently outside the scope of the CLI.  A site such as StackOverflow or asking on Gitter would be more appropriate venues.
Also, in the future, please use the issue template as it can be quite difficult to assist without the information.

@clydin I posted it in stackoverflow first and nobody answered. Unfortunetly I just saw this but I discovered the other day dist will get it running, so your answer is right. Thanks so much


Change of speed -> no MQtt information about it

Changing Speed does not generate an MQtt event.
The speed information is also not included
{"state": "ON", "color": {"r": 217, "g": 121, "b": 79}, "brightness": 59, "effect": "Single Dynamic"}
Or is that intended?
Kind regards

Hello debsaha
Unfortunately I can not compile your branch. I get the error message "request_handlers.h: 407: error: 'class ticker' has no member named 'active'".
I use Arduino IDE 1.85 with Core 2.41.
Do you have an idea why this could be?
Best regards

I an confirm that this https://github.com/esp8266/Arduino/pull/2722/files was pushed before 2.4.1. I checked this on my VM (fresh install). Compiles fine on my 2.4.1 version and git version of esp8266 arduino. Could you reinstall Arduino IDE and/or esp8266 arduino 2.4.1?

Hello debsaha,
I could now compile your sketch. I had to update some libraries. they still worked under the sketch of toblum.
Compiling with AMQTT works.
MQTT not. (error: no matching function for call to 'PubSubClient :: subscribe (char [23], uint8_t &, uint8_t &)')
If the button (// # define BUTTON 0) is commented out, I also get an error message (error: 'BUTTON' was not declared in this scope)
When you click on TV

, the MQTT event does not show the TV modes.

MQTT not. (error: no matching function for call to 'PubSubClient :: subscribe (char [23], uint8_t &, uint8_t &)')

Install PubSubClient

If the button (// # define BUTTON 0) is commented out, I also get an error message (error: 'BUTTON' was not declared in this scope)

Do not comment that line. Comment this line instead // #define ENABLE_BUTTON

When you click on TV, the MQTT event does not show the TV modes.

It was written way before I started I was involved in this project, it is not a WS2812FX animation. @toblum hard coded this, so can't be used by MQTT.


Bug in bash highliting

(Original issue 280 created by None on 2007-08-08T17:49:31+00:00)
http://dumpz.org/124/ - there is red square in the bottom of code around `"' symbol, but there is no error in code really.
Reported by guest

(Original issue was assigned to gbrandl)
(Original issue 280 last updated on 2007-09-09T17:58:33+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by gbrandl on 2007-09-09T17:58:33+00:00)
This is now fixed in 0.9dev.

(Original comment by gbrandl on 2007-08-09T17:09:53+00:00)
Thanks, Tim is (thankfully) working on fixing this.


Hotfix master - Fix issue where mixin-name-format incorrectly lints extends

Fixes an issue where the mixin-name-format rule would incorrectly lint @extends aka class names when used with Sass syntax.
Closes #396
DCO 1.1 Signed-off-by: Ben Griffith<EMAIL_ADDRESS>

Why is coveralls not reporting back..

so does this have issues with the other @-rules such as @debug and @at-root

No because they aren't classed as includes.

No idea about coveralls.

Gah can't edit a comment in this app. I'll add some extra tests just to make sure. Assuming again!

If this is branched off master, then coveralls isn't included in the .travis.yml file on master yet. Want me to make a hotfix to master to add coveralls?
This PR looks good to me.

Maybe the comment I made on line 1 isn't accurate after this PR. Should that be deleted?

I'm assuming #398 isn't reporting with coveralls because it's out of date then?
Unfortunately if you submit a hotfix to master we wouldn't be able to merge it because of coveralls! :smile:

Making PR.

Again, Coveralls is upset that lines of code were added that aren't getting hit by our current unit tests. These two lines are never hit:
https://coveralls.io/files/1462450682#L22
https://coveralls.io/files/1462450682#L31

Once this is updated and passed we'll release 1.3.3 and then focus on getting 1.4.0 out of the door.

Updated.

LGTM, shall I merge?

Hold off for a moment, I'll do all of this as part of the 1.3.3 release.


[WIP] adds is_url validator to toix

is_url validator .. uses some regexp for which I'm not really sure. Would consider some modules.
This branch is WIP.

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master     #7   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      2
  Lines         248    251    +3
  Branches       31     31
=====================================
+ Hits          248    251    +3

Impacted Files
Coverage Δ

packages/toix/index.ts
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b74049...fae759d. Read the comment docs.

I figured out we could use https://www.npmjs.com/package/is-url instead of going directly with RegExp.
There is only one thing I encountered that might be a problem in the future, that is, the module allows "http://www.google" type of URL when it shouldn't.
      is_url()
        ✓ should allow null
        ✓ should allow undefined
        ✓ should allow "http://www.google.com"
        ✓ should allow "https://www.google.com"
        ✓ should allow "http://google.com"
        ✓ should allow "http://www.google.com/imghp"
        ✓ should allow "http://g.co"
        ✓ should not allow "www.google"
        1) should not allow "http://www.google"
        ✓ should not allow "http://google"
        ✓ should not allow "www.google#.com"
        ✓ should not allow "www.google-.co"
        ✓ should not allow "www.-google.co"

  116 passing (34ms)
  1 failing

  1) toix
       str
         is_url()
           should not allow "http://www.google":
     Error: Allowed!
      at Context.it (index.spec.ts:76:15)


GraphQL query editor prettify icon lays on top of environment config modal #1800

This PR adjusts the z-index of the "Prettify" button to prevent it from overlapping with the environment config modal.

This seems to be intended to address #1800, but is not acting on the correct element. This issue is also addressed in PR #1821.


WIP - Remove some package types from global

Relates to cleanup for #1735. See https://github.com/sindresorhus/refined-github/pull/1783#discussion_r276507475

By the way the types for linkify-* have juuuuust been added to their original repos, so we could drop them altogether... except for linkify-urls, unless you can port v3's types to v2 and let @sindresorhus publish that as 2.2.1

linkify-issues uses lookbehinds now too.

unless you can port v3's types to v2 and let @sindresorhus publish that as 2.2.1

Nah. Too much trouble for it to be worth it. We can just wait it out.

We can just wait it out.

I want to remind you that some bugs on bugzilla are older than some RGH contributors

I want to remind you that some bugs on bugzilla are older than some RGH contributors

¯\_(ツ)_/¯ They have pressure now that people are starting to use it. It will be implemented within the end of this year at the latest. I'm 100% sure.

There are some type todo’s that would be good to complete as well


Is it possible to use bullet physics?

I am just curious about your work. Is it possible to use the physics parameters of bullet engine to train the rl-model?

I will check it this weekend. As far as I can tell right now, if the physics server has the same interface, there should be no difference in using it with this project.

Also I have trouble building it in ubuntu 18.0. It throws error while building saying #include<boost/interprocess..>is not found. Should I have to install any libraries before building godot?

Have you installed boost library?
Check if the boost library is working on your system.

Have you installed boost library?
Check if the boost library is working on your system.

Is there a guide on how to install boost library?

@AndriyLazorenko Assuming you are on a ubuntu system, following should be enough.
apt install libboost-container-dev libboost-system-dev libboost-locale-dev


Request spec returns 204 for a post request. Manual testing shows that the request works as expected

I have a very simple controller for Tags:
class Api::V1::TagsController < ApplicationController
  before_action :set_tag, only: :update

  def index
    tasks = Tag.chronologically

    render json: tasks
  end

  def create
    tag = Tag.new(tag_params)

    if tag.save
      render json: tag
    else
      render_422(tag)
    end
  end

  def update
    if @tag.update(tag_params)
      render json: @tag
    else
      render_422(@tag)
    end
  end

  private

  def tag_params
    params.permit(:title)
  end

  def set_tag
    @tag = Tag.find_by!(id: params[:id])
  end

end

I've tested this manually and the post to create tag action in Postman and it works as expected, however, when I run the request spec the behaviour is unexplainably weird:
require 'rails_helper'

RSpec.describe "Tags", type: :request do
  let!(:tag1) { create :tag }
  let!(:tag2) { create :tag }
  let!(:tag3) { create :tag }
  let(:body) { JSON.parse response.body, symbolize_names: true }

  describe "GET /index" do
    it "returns tags in chronological order" do
      get api_v1_tags_path
      expect(response.status).to eq(200)
      expect(response.content_type).to eq("application/json; charset=utf-8")
      expect(body[0].keys).to include(:id, :title)
      expect(body.map{|t| t[:title]}).to eq([tag1.title, tag2.title, tag3.title])
    end
  end

  describe "POST /create" do
    it "creates the tag and returns tag json" do
      headers = { "Content-Type" => "application/json" }
      post api_v1_tasks_path, params: { title: "Urgent" }.to_json, headers: headers
      puts "body: #{response.body.inspect} status: #{response.status}"
      expect(response.status).to eq(200)
      expect(response.content_type).to eq("application/json; charset=utf-8")
      expect(body.keys).to include(:id, :title, :created_at, :updated_at)
      expect(body[:title]).to eq("Urgent")
    end
  end
end

output:
Randomized with seed 49215

Tags
  POST /create
body: "" status: 204
    creates the tag and returns tag json (FAILED - 1)
  GET /index
    returns tags in chronological order

Failures:

  1) Tags POST /create creates the tag and returns tag json
     Failure/Error: expect(response.status).to eq(200)

       expected: 200
            got: 204

       (compared using ==)
     # ./spec/requests/tags_spec.rb:27:in `block (3 levels) in <top (required)>'

Finished in 0.17793 seconds (files took 0.84214 seconds to load)
2 examples, 1 failure

Failed examples:

rspec ./spec/requests/tags_spec.rb:23 # Tags POST /create creates the tag and returns tag json

What tag.as_json would print in the controller create action if you make a request manually, from postman, or from specs?

Here's prtscrn of postman request to post create

@pirj thanks, for you reply
My confusion is because manually testing with postman points to endpoints working correctly, and there seems to be some kind of infrastructure issue with request specs I couldn't figure out yet, hence reaching out

Let me repeat my question:

What tag.as_json would print in the controller create action if you make a request manually, from postman, or from specs?

My guess is that Rails renders HTTP 204 when tag.as_json is nil. How this can happen if tag.save returns a truthy value is interesting.
It will be very helpful if you could submit a reproduction repo or a script (see e.g. https://github.com/rspec/rspec-rails/blob/main/snippets/use_active_record_false.rb).
Otherwise, unfortunately, we won't be able to help.

@pirj
added you to collaborators:
https://github.com/ianaverno/test-rspec

@pirj
I've resolved the issue
the issue was the variable for headers set with let was incorrect, and the one set within it was ignored (it seems)
sorry for bothering


Linking Our Team cards to Linkedin

Is your feature request related to a problem? Please describe.
In about Us page under our team section there are cards for the developers of this website.
Currently in jus has a photo and Name. We can add a little description about the team members and also link there socials,
like Linkedin or github which would make easier to contact the team members.

Please assign this issue to me under GSSoC.

We can certainly add their linkedin and github IDs, description is not necessary, I will share the details by tomorrow

cool also please add level label

We can certainly add their linkedin and github IDs, description is not necessary, I will share the details by tomorrow

@Akshatchaube01 please provide me details

You can add only the icons for now. put github and linkedin something like this :

Is this issue is open to work now? @Akshatchaube01

@mukilan2815 yes


Update with latest Javascript from 1Password browser extensions

Thanks for taking the time to submit this PR, @jxpx777 :+1:
It all works like a charm.
Thanks so much!


Automator: update istio/client-go@master dependency in istio/istio@master

Generated by Automator - 2024-07-22T18:05:41+00:00

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
010c1a8676710e1bdb2597f3de778eb106b5dec4
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
010c1a8676710e1bdb2597f3de778eb106b5dec4
link
true
/test integ-cni

integ-pilot_istio
010c1a8676710e1bdb2597f3de778eb106b5dec4
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/retest

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
010c1a8676710e1bdb2597f3de778eb106b5dec4
link
true
/test integ-cni

integ-pilot_istio
010c1a8676710e1bdb2597f3de778eb106b5dec4
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot_istio
010c1a8676710e1bdb2597f3de778eb106b5dec4
link
true
/test integ-pilot

integ-cni_istio
010c1a8676710e1bdb2597f3de778eb106b5dec4
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
010c1a8676710e1bdb2597f3de778eb106b5dec4
link
true
/test integ-cni

integ-pilot_istio
a794661a1eb3eb1ba9a164e5dc0444b991fe7988
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot_istio
a794661a1eb3eb1ba9a164e5dc0444b991fe7988
link
true
/test integ-pilot

integ-cni_istio
a794661a1eb3eb1ba9a164e5dc0444b991fe7988
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
a794661a1eb3eb1ba9a164e5dc0444b991fe7988
link
true
/test integ-cni

integ-pilot_istio
b6a6fd7abe636df26c50751f2a360bc7986f933f
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot_istio
b6a6fd7abe636df26c50751f2a360bc7986f933f
link
true
/test integ-pilot

integ-cni_istio
b6a6fd7abe636df26c50751f2a360bc7986f933f
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
623f9000f4983e9f815bd9e369432b995fd9a3db
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
623f9000f4983e9f815bd9e369432b995fd9a3db
link
true
/test integ-cni

integ-pilot_istio
623f9000f4983e9f815bd9e369432b995fd9a3db
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
623f9000f4983e9f815bd9e369432b995fd9a3db
link
true
/test integ-cni

integ-pilot_istio
f5114ec13c9feb2a3a0f112662dc504edd20193d
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot_istio
f5114ec13c9feb2a3a0f112662dc504edd20193d
link
true
/test integ-pilot

integ-cni_istio
f5114ec13c9feb2a3a0f112662dc504edd20193d
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
0ff6d036d9073ecb519daf5d2d5cd66838322e4a
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
0ff6d036d9073ecb519daf5d2d5cd66838322e4a
link
true
/test integ-cni

integ-pilot-multicluster_istio
0ff6d036d9073ecb519daf5d2d5cd66838322e4a
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
0ff6d036d9073ecb519daf5d2d5cd66838322e4a
link
true
/test integ-cni

integ-pilot-multicluster_istio
0ff6d036d9073ecb519daf5d2d5cd66838322e4a
link
true
/test integ-pilot-multicluster

integ-pilot_istio
0ff6d036d9073ecb519daf5d2d5cd66838322e4a
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

I think the tooling fix to improve the crd output for intOrStr merged. Should we manually generate CRDs to fix things or will tooling kick in?

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
0ff6d036d9073ecb519daf5d2d5cd66838322e4a
link
true
/test integ-cni

integ-pilot-multicluster_istio
0ff6d036d9073ecb519daf5d2d5cd66838322e4a
link
true
/test integ-pilot-multicluster

unit-tests-arm64_istio
073fdc644d4c53b0019d291d887943425db501d2
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

/test unit-tests-arm64

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-cni_istio
0ff6d036d9073ecb519daf5d2d5cd66838322e4a
link
true
/test integ-cni

integ-pilot-multicluster_istio
0ff6d036d9073ecb519daf5d2d5cd66838322e4a
link
true
/test integ-pilot-multicluster

integ-pilot_istio
073fdc644d4c53b0019d291d887943425db501d2
link
true
/test integ-pilot

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot-multicluster_istio
0ff6d036d9073ecb519daf5d2d5cd66838322e4a
link
true
/test integ-pilot-multicluster

integ-pilot_istio
073fdc644d4c53b0019d291d887943425db501d2
link
true
/test integ-pilot

integ-cni_istio
073fdc644d4c53b0019d291d887943425db501d2
link
true
/test integ-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@istio-testing: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-pilot_istio
073fdc644d4c53b0019d291d887943425db501d2
link
true
/test integ-pilot

integ-cni_istio
073fdc644d4c53b0019d291d887943425db501d2
link
true
/test integ-cni

integ-pilot-multicluster_istio
073fdc644d4c53b0019d291d887943425db501d2
link
true
/test integ-pilot-multicluster

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.


Meeting topic overly verbose

The default meeting topic does not need #asfmeeting prefix: indeed that is misleading as this is not IRC.
It could be something like:
Official ASF Members Annual Meeting.
Though it should probably start as:
Official ASF Members Annual Meeting. Starts at yyyy-mm-dd hh:mm UTC (in xx minutes)
Likewise #backchannel  is not really appropriate for the other channel and could be dropped.

First bit addressed with b189657


Usage Report

Describe the bug
Unleash.Client is not reporting Usage of the Toggle like JS sdk does. Is there some parameter or config that needs to be enabled for this feature?

iApartments_AccessHistoryFilters toggle is accessed via  Unleash.Client and all other via JS sdk.
Thanks

Hi @wahmedswl , thanks for bringing this to our attention. Which client sdk are you using?

The .Net client should report metrics by default, though

If these are only reported when SendMetricsInterval then summary says the following ...
//
// Summary:
//     Gets or sets the interval in which metriccs are sent to the server. When null,
//     no metrics is sent. Default: null
public TimeSpan? SendMetricsInterval { get; set; }

This has now been changed (PR pending) to default to 60 s as per our documentation.  Thanks for reporting this @wahmedswl !

Sounds like this is done. I'm going to close this, @wahmedswl feel free to reopen if your problem is not solved


Moving --device_allocator= flag parsing to iree/hal/utils/.

This will allow user applications and bindings to configure allocators in the same way the tools do without pulling in all the private tooling/ code. It's still a factory that pulls in flags/every allocator and should only be used by layers that are ok with taking on those dependencies.
This also wires up the python bindings to configure the device allocator before returning it to users. We could expose allocators directly to give more pythonic control but for now this matches several other internal mechanisms we control with flags (task system, etc).

Going to drop this and do kwargs - I don't feel like fixing flags tonight 🥃


Figure out the latest memory leak/CPU hog

Related: #4249
Memory spiked with no obvious runtime activity at ~2330 CEST on 2019/12/05. There was highly periodic CPU usage at the same time:

Figure out what this is and fix it.

outdated.


remove deprecated filter name check

Currently we check both deprecated name and canonical names while matching filters. It has been added in 1.7 to support older versions https://github.com/istio/istio/pull/25966 and we have added warnings long back https://github.com/istio/istio/pull/28931.
I think it is safe to remove that checks now.

[ ] Ambient
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test unit-tests-arm64

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test unit-tests-arm64

unit-tests_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test unit-tests-arm64

unit-tests_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test unit-tests

integ-telemetry-istiodremote_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test integ-telemetry-istiodremote

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test unit-tests-arm64

unit-tests_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test unit-tests

integ-telemetry-istiodremote_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test integ-telemetry

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test unit-tests-arm64

unit-tests_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test unit-tests

integ-telemetry-istiodremote_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test integ-telemetry

integ-telemetry-mc_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test integ-telemetry-mc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Probably need a release note?

Will add one

looks like our tests depend on old names :-)

@howardjohn @kyessenov PTAL

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests-arm64_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test unit-tests-arm64

unit-tests_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test unit-tests

integ-telemetry-istiodremote_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test integ-telemetry

integ-telemetry-mc_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test integ-telemetry-mc

release-notes_istio
7153628fbc30640716fb5fe16ebc4c319ff95ca5
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-telemetry-istiodremote_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test integ-telemetry-istiodremote

integ-telemetry_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test integ-telemetry

integ-telemetry-mc_istio
1fe9e5ba8309d3dfa9ff20fc87d468403dc3d840
link
true
/test integ-telemetry-mc

release-notes_istio
a6309056ede1aeb5f029c44e4a5ff4e4b144e788
link
true
/test release-notes

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn @zirain reverted validation

@howardjohn @istio/wg-policies-and-telemetry-maintainers

@istio/wg-policies-and-telemetry-maintainers can you PTAL?


Building wasm project for node is fine, but loading the pkg dir fails with "Can't resolve 'fs'"

Describe the Bug
(BTW: In order to verify that it wasn't an error on my end, I repeated the procedure without changing anything and still got the same result).
I just created a tiny example project, based on the tutorial in the book.
All goes well, including building the wasm with --target nodejs.
The problem is that when I try to  load the pkg dir that contains the generated WASM and JavaScript from a consuming project (which was created using npm init wasm-app www), then that load fails with this output:
$ npm run build

><EMAIL_ADDRESS>build /home/j/dev/accept/webdbg/delta-client/www
> webpack --config webpack.config.js

Hash: 3858bef569ea39a7a738
Version: webpack 4.42.0
Time: 157ms
Built at: 03/04/2020 11:42:10 PM
         Asset       Size  Chunks             Chunk Names
0.bootstrap.js   37.2 KiB       0  [emitted]
1.bootstrap.js    3.1 KiB       1  [emitted]
  bootstrap.js   8.73 KiB    main  [emitted]  main
    index.html  297 bytes          [emitted]
Entrypoint main = bootstrap.js
[../pkg/delta_client.js] 1.65 KiB {1} [built]
[./bootstrap.js] 279 bytes {main} [built]
[./index.js] 97 bytes {1} [built]
    + 5 hidden modules

ERROR in ../pkg/delta_client.js
Module not found: Error: Can't resolve 'fs' in '/home/j/dev/accept/webdbg/delta-client/pkg'
 @ ../pkg/delta_client.js 63:14-27
 @ ./index.js
 @ ./bootstrap.js
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>build: `webpack --config webpack.config.js`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/j/.npm/_logs/2020-03-04T22_42_10_680Z-debug.log

Steps to Reproduce

Follow the tutorial until this point.
Then try to execute "npm run start" in the generated www dir
See similar output as mine

If applicable, add a link to a test case (as a zip file or link to a repository we can clone).
Expected Behavior
I expected my wasm file to be loaded
Actual Behavior
The npm run start command exits with the error log presented above.
Additional Context
OS: Ubuntu 19.10
node version: 10.17.0
npm version: 6.11.3
rust version: 1.41.1
wasm-pack version: 0.9.1
EDIT: The problem is traceable to the generated JavaScript file:

// Omitted first part of the file. What is shown is the last number of lines of the JS file.

const path = require('path').join(__dirname, 'floof_bg.wasm');
const bytes = require('fs').readFileSync(path); // <----    offending line

const wasmModule = new WebAssembly.Module(bytes);
const wasmInstance = new WebAssembly.Instance(wasmModule, imports);
wasm = wasmInstance.exports;
module.exports.__wasm = wasm;

@jjpe The nodejs target is designed to be run in Node.js (hence its name). If you want to use Rust with Webpack you should use --target bundler instead.
The tutorial does not say to use nodejs, so I'm curious why you're doing that.

I'm not using node itself, but I do use NPM. Thus as far as I know I need npm style packages, and thus build for NodeJS.

Thanks for the report! As @Pauan pointed out though the --target nodejs output isn' intended to go into webpack, and for that you'll want --target bundler. That should also help you put everything into the same web app with webpack. You can also experiment with --target web to get a more standalone feeling for wasm

I repeat: I'm not using webpack, because it always fails to build the project no matter what I do.
Currently I'm using the generated vue build script (which uses NPM) to build the client. So whatever that does is what I use.
I need the NodeJS project structure (including package.json) because that is what the environment seems to demand of me.
Bundler is what I don't want precisely because webpack fails so miserably.

@jjpe the error logs you gisted above with npm run build include webpack, which is why we're thinking you're running webpack. Have you adjusted how your build process works and are there new error logs?
Unfortunately it's difficult for us to help you if you're not familiar with your own build environment.

Have you adjusted how your build process works

No because when I try to take control of the build process for the client, in the most positive scenario so far I get no build errors, but a nonfunctional web client nonetheless. So nonfunctional in fact that I just get a black on white default error screen rather than the GUI that's supposed to show up.
I've also grepped for any webpack configs I can find in the web client repo since if it existed, it would have been generated by VueJS or Vuetify when I created the project. But grepping doesn't yield any results, so I can't just take that config and build on it, either.

familiar with your own build environment.

Yeah about that. Contrary to Rust documentation in general, I find the documentation of webpack really disappointing, in that there is a lot of text but almost no information that actually helps me achieve my goal (very reminiscent of Apple's developer documentation in that regard). So unfortunately that's no help in improving my understanding either.
The reason I reject building with --target bundler or --target web is that I don't see how that will help me. IIUC, building for either target means I can't use the build scripts which require NPM, but then how do I get everything bundled if the answer isn't webpack?
I'm not home atm, but when I am I'll post the contents of the project's package.json. However I do believe that one of the commands just uses the vue CLI utilities to build, and the other just runs the vue dev server.

@jjpe Thus as far as I know I need npm style packages, and thus build for NodeJS.

That's not how it works. Npm is a package manager for the entire JavaScript ecosystem, it's not just used for Node, it's also used for browsers, Electron, React Native, Angular, React, Vue, etc.
So just because you're using npm doesn't mean you're running your code in Node.
The nodejs target for wasm-bindgen is only if you're running your code in Node. If you aren't, then you should be using bundler, web, or no-modules. Using bundler is correct if you're using Webpack.

What I ultimately need is to mix Rust/WASM and VueJS together in the same web app.

In that case you want to use Webpack and --target bundler, definitely not --target nodejs.

Currently I'm using the generated vue build script (which uses NPM) to build the client. So whatever that does is what I use.

Vue uses Webpack. Here is a guide on how to configure Webpack when using the Vue CLI.

I need the NodeJS project structure (including package.json) because that is what the environment seems to demand of me.

package.json is used by npm, but that isn't the same as Node, because npm is used by all sorts of things in the JavaScript ecosystem.

The reason I reject building with --target bundler or --target web is that I don't see how that will help me.

It will help you because then your code will actually work. --target nodejs cannot work in a browser, it is impossible. It will only work in Node.
In order to run your code in a browser, you must use the bundler, web, or no-modules targets.

IIUC, building for either target means I can't use the build scripts which run using NPM, but then how do I get everything bundled if the answer isn't webpack?

That is incorrect, you can use all of the targets with npm, because npm is only a package manager, it is not the same thing as Node.
The --target is for the target where you will be running your code. It is not for the target where you are compiling the code. It is important to distinguish those two things, because they are completely different.
The answer for bundling is Webpack, which is built into the Vue CLI, so the Vue CLI runs Webpack automatically.

Here is a step by step guide on how to use Rust + Wasm in a Vue project:

Create the Vue project by using npx @vue/cli create my-project

cd my-project

Use npm run serve and then open http://localhost:8080/ in your browser. This is to verify that Vue is setup and working correctly.

Run npm install --save-dev @wasm-tool/wasm-pack-plugin (this installs the wasm-pack plugin for Webpack)

Create a new vue.config.js file which contains the following:
const path = require("path");
const WasmPackPlugin = require("@wasm-tool/wasm-pack-plugin");

module.exports = {
  configureWebpack: {
    plugins: [
      new WasmPackPlugin({
        crateDirectory: path.join(__dirname, "rust"),
        outDir: path.join(__dirname, "pkg"),
        outName: "index"
      }),
    ]
  }
}

Now you can add your Rust code into the rust subfolder.

Finally you can import the Rust code by using import("../pkg/index.js"). This returns a Promise, so you'll need to await it in order to access the Rust functions.

You can now test that it works by using npm run serve again.

There is a lot of complexity in the JavaScript world, so it can be quite difficult to know how to set things up properly. Unfortunately there isn't that much we can do about that, since we can only control the Rust ecosystem and tooling, not the JavaScript ecosystem and tooling.

P.S. Here is our official template for using Rust with Webpack. It may help you a bit.

The long reply helped me get rid of some of my misconceptions about the JS ecosystem.
As a result now I have a basic wasm loaded in VueJS, but I had to get a little creative as well, since top level async doesn't seem to work in .vue files for whatever reason.
So instead I had to go old skool with a .then() call on the wasm import, and initialize the main Vue instance within that .then() call. This provides a hard guarantee that the wasm module is loaded when the Vue object is initialized.


Update to 1.19.2 + Rewrite Snow Algorithm

Update to 1.19.2
Rewrite snow algorithm
Use mixins instead of event callbacks

Closes #4

Also, do you think you could add the hacktoberfest topic to the repo?

Yeah! Thanks for your work, I added hacktoberfest topic.

I just realized, minor version or major version should be bumped, because there were algorithm changes & new features


Update Cluster Status page with latest deployments

Add monitoring for :

Fertiscan once deployed
new ailab website
Librechat
Louis

Done through UI of oneuptime