Buildkite agent token environment variable is misdocumented

The buildkite-agent documentation suggests that the BUILDKITE_AGENT_ACCESS_TOKEN environment variable is used to configure the agent's token. That documentation seems to be incorrect though; while clicommand/global.go does use that name, clicommand/agent_start.go uses a different environment variable - BUILDKITE_AGENT_TOKEN. In testing, I can't configure an agent using BUILDKITE_AGENT_ACCESS_TOKEN, but BUILDKITE_AGENT_TOKEN does work.
It looks like this confusion was brought up in #143, but it wasn't resolved at that time.

You are absolutely correct, that one tripped me up ages ago and I'd completely forgotten about it.

Thanks!
Are these two tokens different things, or the same thing being used under two names?

They do different things. The BUILDKITE_AGENT_TOKEN is used for an agent to initially connect, at which point a per-agent BUILDKITE_AGENT_ACCESS_TOKEN is issued to the agent. It's not something that should need to be configured. Sorry for the confusion and thanks for the report!


Google Oauth redirect URl

What do i have to use as redirect url?

Figured it out
<YOURLS base>/admin


SAFE integration

Overview
Placeholder to integrate ShapeShift as a SAFE app
⚠ blocked by https://github.com/tahowallet/extension/issues/3725
References and additional details
https://help.safe.global/en/articles/145503-how-to-create-a-safe-app-with-safe-apps-sdk-and-list-it
Acceptance Criteria

Users are able to connect to their SAFE within SAFE using automagically detected EIP-1193 injected provider
Users are automagically connected to their SAFE as a requirement for integration

Need By Date
No response
Screenshots/Mockups
No response
Estimated effort
No response

Worth keeping notes that when we start getting this in their UI to test bridging specifically. Lifi at onchainden is the current best experience, but i think with a alittle kajiggering we can actually make this awesome.
we have a team of people using this every week so, boom, in community testers.

to fix your trouble check this solution click
maybe this will solve your problem.


PSKoans

PSKoans - PowerShell Enlightenment

Name: Joel Sallow
Your Timezone: UTC +5
Abstract: I've a mind to show off the beginnings of the PSKoans module. It's not complete yet, but the foundations are quite solid. Cmdlets won't really be covered, but all the general language features of PS will be up for grabs (if we get time for all the weirdness there is to have there!)
Optional links (remove if not using)

Slack ID: @Joel_(/u/ta11ow)
Discord ID: @Joel#2641
Github Repo: https://github.com/vexx32/PSKoans

Update: Having covered the basic discovery cmdlets and most of the *-Object cmdlets already, I might see what I can pack into a session.
Toying with whether I want to do a sort of run through of how the koans would work in practice or a more stepped-back theoretical 'this is the state of things'. I'm leaning towards the former.

Thanks again!  Do feel free to submit more proposals : D


my project crashes despite having seemingly 1:1 parts of the example project.

error popup:
___________________________________________
############################################################################################
ERROR in
action number 1
of Draw Event
for object LightRender:

surface_copy argument 1 incorrect type (undefined) expecting a surface
 at gml_Script_CopyClippingSurface@anon@2644@BulbRenderer@BulbRenderer (line 91) -         surface_copy(GetClippingSurface(), 0, 0, _surface);
############################################################################################
gml_Script_CopyClippingSurface@anon@2644@BulbRenderer@BulbRenderer (line 91)
gml_Object_LightRender_Draw_73 (line 5) - lighting.CopyClippingSurface(vision.GetSurface());

code of the "LightRender" (equivalent of "oRenderer" form example project)
[Create]
view_enabled = true;
view_set_visible(0, true);
camera = view_camera[0]
view_set_camera(0, camera);

lighting = new BulbRenderer(make_colour_rgb(255, 255, 255), BULB_MODE.HARD_BM_ADD, false);
lighting.SetSurfaceDimensionsFromCamera(camera);
lighting.SetClippingSurface(true, 1.0, false, true);

vision = new BulbRenderer(c_black, BULB_MODE.HARD_BM_ADD, false);

[Draw End]
vision.UpdateFromCamera(camera);

lighting.CopyClippingSurface(vision.GetSurface());  //<--- point of error

lighting.UpdateFromCamera(camera);

lighting.DrawOnCamera(camera);

[Game Start]
global.lightR= id

code of the "LightWall" (equivalent of "oStaticOcluder" from example project)
[Create]
occluder        = new BulbStaticOccluder(global.lightR.lighting);
occluder.x      = x;
occluder.y      = y;
occluder.xscale = image_xscale;
occluder.yscale = image_yscale;
occluder.angle  = image_angle;
occluder.AddToRenderer(global.lightR.vision);

var _l = -0.5*sprite_get_width(sprite_index);
var _t = -0.5*sprite_get_height(sprite_index);
var _r =  0.5*sprite_get_width(sprite_index);
var _b =  0.5*sprite_get_height(sprite_index);

if ((image_angle != 0) || (image_xscale != 1) || (image_yscale != 1))
{
    occluder.AddEdge(_l, _t,   _r, _t); //Top
    occluder.AddEdge(_r, _t,   _r, _b); //Right
    occluder.AddEdge(_r, _b,   _l, _b); //Bottom
    occluder.AddEdge(_l, _b,   _l, _t); //Left
}
else
{
    if (!position_meeting(x, y - 32, oStaticOccluder)) occluder.AddEdge(_l, _t,   _r, _t); //Top
    if (!position_meeting(x + 32, y, oStaticOccluder)) occluder.AddEdge(_r, _t,   _r, _b); //Right
    if (!position_meeting(x, y + 32, oStaticOccluder)) occluder.AddEdge(_r, _b,   _l, _b); //Bottom
    if (!position_meeting(x - 32, y, oStaticOccluder)) occluder.AddEdge(_l, _b,   _l, _t); //Left
}

[Clean Up]
occluder.Destroy();

code of "pLight" (equivalent of "oPlayer" that is always on top of the Player position)
[Create]
light = new BulbLight(global.lightR.lighting, global.lightR, 0, x, y);
light.penumbraSize = 30;
light.yscale = 0.5;
light.blend = make_colour_rgb(255, 255, 100);

visionCone = new BulbLight(global.lightR.vision, global.lightR, 0, x, y);
visionCone.penumbraSize = 30;
visionCone.xscale = 2;
visionCone.yscale = 2;
visionCone.blend = c_white;

[Step]
x=P.x // P is the id of the Player object
y=P.y

light.x = x;
light.y = y;
light.angle = point_direction(x, y, mouse_x, mouse_y);

if (mouse_check_button_pressed(mb_right)) light.visible = !light.visible;

visionCone.x = x;
visionCone.y = y;
visionCone.angle = point_direction(x, y, mouse_x, mouse_y);

[Clean Up]
light.Destroy();

"lightS" is the sprite used for the light, it is a white square

You'll need to step through using the debugger at that line of code to determine why vision.GetSurface() is returning undefined.

You'll need to step through the code to determine which argument is returning undefined and why.

the code goes thru the following lines when pressing F11 in the debugger as it executes the crashing line of the Draw End
    static GetSurface = function()
    {
        if (__freed) return undefined;
        if ((surfaceWidth <= 0) || (surfaceHeight <= 0)) return undefined;

        if ((__surface != undefined) && ((surface_get_width(__surface) != surfaceWidth) || (surface_get_height(__surface) != surfaceHeight)))
    }
        if ((__surface == undefined) || !surface_exists(__surface))
        return __surface;

    static CopyClippingSurface = function(_surface)
    {
        gpu_set_blendmode_ext(bm_one, bm_zero);
        surface_copy(GetClippingSurface(), 0, 0, _surface);

    static GetClippingSurface = function()
    {
        if (__freed || !__clipEnabled) return undefined;
    }

  >>Crash after returning to the "surface_copy(GetClippingSurface(), 0, 0, _surface);" line<<

Have you used the debugger before?

i have used the debugger occasionally, but never to inspect inside a script.
Also, I noticed possibly important detail of the crash. It only happens when changing rooms, with the LightRender being a persistent object. I did this this way, because when the light render wasn't set up like this, it was causing an error, where the other relevant objects didn't work, because everything calling LightRender was reporting "<unknown_object>"
it is possible it may be related to the probelm

Please refer to documentation: https://www.jujuadams.com/Bulb/#/21.0/BulbRenderer

You must free and recreate your renderer when changing rooms.

Restructure your code to accommodate this requirement.
At any rate, you will need to use the debugger in earnest and inspect the code path.

wow, so it was the creation order that was breaking it, now it works flawlessly, (exept that i cant see the light, probably some settings problems i can just mess with to fix) i guess i wasted your time

I'm glad you solved your problem. Please open a new ticket if you have further issues.


LDAP: fix the current situation between username and ldap_name

Right now what we have is that for LDAP, created users will have the proper LDAP username in the ldap_name, and the stripped one in username. This leads to the situation in which username means a different thing between non-LDAP and LDAP. Bugs have appeared because of this (the last one being #732).
Proposal

username always contains the original user name.
namespace will contain the personal namespace associated to the user.

This way, whenever we want to show the user name, we just call username (we don't have to guard it with if LDAP.enabled? all the time). This would also fix some quirks on the UI (e.g. listing users by their modified names on LDAP). Moreover, this gives us more flexibility if in the future we want to support other authentication protocols (e.g. SAML as described in #597).
Drawback
This has one major drawback: we would have to provide a task to migrate from the current scenario to this new one. This is not such a big problem because we need to provide a way to migrate from 2.0 to the future 2.1 anyways (it already happened when we released 2.0 that people asked on how to upgrade from version 1.0.1, and we didn't have a proper way :/).
Alternatives
We could also provide a method in the User model called name, that did the trick of returning ldap_name instead of username when needed. This also has some downsides:

We would not only have to replace all the username and ldap_name usages, but we would also have to remember to use this method instead of the attributes from now on.
We would have to replace all the find_by calls to something that can play with the new name method.

Tasks

[ ] Implement change.
[ ] Implement rake task.
[ ] Update documentation.

This issues supersedes #699.

Hi,
The User model being changed for this issue, wouldn't it be a good time to add a display name to it, as mentioned in #699 ?
Regards,

@lonewulf that issue should be fixed by this one. As I said:
 This would also fix some quirks on the UI

I'll add the issue on my original comment. Thanks for the reference :)

Fixes some quirks yes, but usernames are not always user-friendly, you're still not able to guess who's behind a given username, and it feels problematic if you need to cross-check with your directory to find who is behind. That's what I meant behind the idea of display name.
Regards,

The idea is that now the "display name" will be the original LDAP name. So, if your LDAP name is "first.second", then this will be the one being shown as your username in all places of the UI (and not firstsecond, which is the current behavior).
Do you mean that you want to see another name besides the original one ?

Do you mean that you want to see another name besides the original one ?

Yup, that's what I meant, sometimes usernames are totally unrelated to the real names. Let's say something along user12345 and user98765.
I had in mind to use the display name to show the user real name (That could be pulled from the LDAP server when the user is created), as it's more user-friendly.

@lonewulf fair enough. I've re-opened #699.


Custom icon Marker moves with zoom

Hi I am new to leaflet. I am trying to add a custom marker similar to the custom icon sample here: http://leaflet.cloudmade.com/examples/custom-icons.html
When I zoom out the markers move away from the actual point at which the marker is placed. Here is my code, very simple:
var map = L.map('map').setView([51.5, -0.09], 13);
L.tileLayer('http://{s}.tile.cloudmade.com/{key}/22677/256/{z}/{x}/{y}.png', {
attribution: 'Map data © 2011 OpenStreetMap contributors, Imagery © 2011 CloudMade',
key: 'BC9A493B41014CAABB98F0471D759707'
}).addTo(map);
    var icon = new L.Icon({iconUrl: 'map_pin.png'});

    L.marker([51.5, -0.09], {icon: icon}).bindPopup("I am a green leaf.").addTo(map);

though I have tried a number of other things. This was brought up in issue #371. The author said he fixed it but did not provide the fix. Please help
Thanks,
Sam

@mourner It would be very helpful if you elaborated a bit on this

@kpennell have you checked out? http://leafletjs.com/examples/custom-icons.html
If you have further questions, please use the forum, the IRC channel or post a question to gis.stackexchange.com/stackoverflow. This place is for discussing bugs and new features for Leaflet.

Ok thanks
On Wednesday, April 1, 2015, Per Liedman<EMAIL_ADDRESS>wrote:

@kpennell https://github.com/kpennell have you checked out?
http://leafletjs.com/examples/custom-icons.html
If you have further questions, please use the forum
https://groups.google.com/forum/#!forum/leaflet-js, the IRC channel or
post a question to gis.stackexchange.com/stackoverflow. This place is for
discussing bugs and new features for Leaflet.
—
Reply to this email directly or view it on GitHub
https://github.com/Leaflet/Leaflet/issues/895#issuecomment-88434364.

reopening the issue as the example code still has this bug :-1:

@JohnHanks example code at http://leafletjs.com/examples/custom-icons.html works just as expected.

yup. even i had the same issue. no fix yet
cssIcon1 = L.divIcon({
    className: 'mapMarkerIco1',
    iconAnchor: [0, 0],
    iconSize: [25, 25]
 });

AND
.mapMarkerIco1 {
    -ms-border-bottom-left-radius: 25px;
    border-bottom-left-radius: 25px;
    -ms-border-top-right-radius: 25px;
    border-top-right-radius: 25px;
    -ms-border-top-left-radius: 25px;
    border-top-left-radius: 25px;

    background: #009be5;
    background: rgba(0, 155, 229, 0.4);

    border: 5px solid #000000;
    border: 5px solid rgba(0, 0, 0, 0.55);

    -webkit-transition: ease-in-out 0.2s;
    -moz-transition: ease-in-out 0.2s;
    -ms-transition: ease-in-out 0.2s;
    -o-transition: ease-in-out 0.2s;
    transition: ease-in-out 0.2s;

    -webkit-box-shadow: 0 6px 10px 0 rgba(0, 0, 0, 0.5);
    -ms-box-shadow: 0 6px 10px 0 rgba(0, 0, 0, 0.5);
    box-shadow: 0 6px 10px 0 #000000;
    box-shadow: 0 6px 10px 0 rgba(0, 0, 0, 0.5);
}

@electronik54 it looks like you might be missing the option popupAnchor, have you looked at the custom icons tutorial?
If you believe this is really a bug in Leaflet, it would be great if you could provide a working example that illustrates the problem.

Hi,
@electronik54 your image looks like the iconAnchor is set at [20, 10] (demo: http://jsfiddle.net/ve2huzxw/90/)
Given the shape of your icon, I guess you would rather like to have it set to its bottom right tip, therefore at [26, 26]. Note that you have to take your border width into account (twice 3px).
As suggested by @perliedman, if your image shows the marker popup, you might also need to adjust the popupAnchor.
If you need further help, you would probably get better support on Stack Overflow or GIS Stack Exchange.
Hope this helps.

ghybs was right. the css border was causing the issue.
all of this calculations should have been included in the tutorial OR the leaflet should have calculated it internally with optional calculation for user.
anyways thanks :+1:  ghybs :+1:

We have a requirement of plotting a store marker and along with it few custom markers.
Store marker and other custom markers would be on singel unit/icon. We get 'svg' of all thes and  concatenate them to text and rendering them. Though they are rendered properly, we are unable to center the icon to the given lat long point. On zoom/pan, icon is moving away from the bound lat long.
We have difficulty using div icon and faced few issues.
Hence we are using 'bindTooltip' for rendering the composite icon. We are using latest leaflet version (1.4.0). Please find sample html which can explain the issue.
Try to zoom in and see that the icon is not anchored to the lat long. Instead moving away from the location.
leaflet.zip

@jpavansharma
If you believe there's Leaflet bug - please submit an issue and provide minimal example reproducing the issue.
If you need support - please use the following resources:

https://stackoverflow.com/questions/tagged/leaflet
https://gis.stackexchange.com/questions/tagged/leaflet

Using this code, you can see that the marker location is constantly moving when zooming
`

CRS.Simple example - Leaflet

`

@IvanSanchez  look at this,please   https://github.com/Leaflet/Leaflet/issues/895#issuecomment-1185630452


Update OpenBSD 5.9 to 6.0 (boot guest on iso)

Hello,
I have a VM running OpenBSD 5.9.
I'm trying to update to OpenBSD 6.0 using the iso :
iohyve stop vm-ssl
iohyve fetch http://ftp.fr.openbsd.org/pub/OpenBSD/6.0/amd64/install60.iso
iohyve install vm-ssl install60.iso

But I just get a minimal GRUB Bash...
I think I'm just unable to boot on ISO when the guest is already installed.
Or maybe OpenBSD6.0 isn't supported yet ?
[root@freenas] ~# iohyve getall vm-ssl
Getting vm-ssl iohyve properties...
bargs          -A_-H_-P
boot           1
con            nmdm0
cpu            1
description    Wed Jul 27 15:42:17 CEST 2016
install        yes
loader         grub-bhyve
name           vm-ssl
os             openbsd
persist        1
ram            256M
rcboot         yes
size           10G
tap            tap0

Okay I found a workaround.
In the openbsd VM, download bsd.rd (6.0) to the root.
Then, on the guest zfs dataset, edit grub.cfg and modify to bsd.rd.
Set the vm to os=custom, then boot, and perform the install.
Set grub.cfg back to bsd and boot.
Profit.

When using OpenBSD and iohyve you must specify the version in your os property.
If you want to try out OpenBSD 6.0, then you can try something like iohyve set vm-ssl os=openbsd60
If you wanted to go back to 5.9, then something like iohyve set vm-ssl os=openbsd59
Let me know if this helps any!

os=openbsd60 is not working, but I'm not sure I have the latest version of iohyve, I'm using the one on FreeNAS. How can I list all available os= ? Is there a command like iohyve list os ?

Ah, yes, I should have specified, the version on GitHub is the only version that will support 6.0.
For now, following this little guide should get you going, as you probably already read.
There is no way to check what iohyve os's you can use without looking at the "source" (ioh-guest) currently.


Failed to start Apply the …ngs specified in cloud-config.

Getting some errors during the "Waiting for control plane to be initialized..." phase:
kubectl logs  vm-quickstart-cp-dc74x-qrvvf
[   12.822875] cloud-init[1039]: Cloud-init v. 22.3.4-0ubuntu1~22.04.1 running 'modules:config' at Thu, 01 Jun 2023 02:40:30 +0000. Up 12.67 seconds.
[   12.900775] cloud-init[1039]: 2023-06-01 02:40:30,914 - util.py[WARNING]: Running module locale (<module 'cloudinit.config.cc_locale' from '/usr/lib/python3/dist-packages/cloudinit/config/cc_locale.py'>) failed
[   12.939189] cloud-init[1039]: 2023-06-01 02:40:30,952 - cc_set_passwords.py[WARNING]: Ignoring config 'ssh_pwauth: None'. SSH service 'ssh' is not installed.
[FAILED] Failed to start Apply the …ngs specified in cloud-config.
See 'systemctl status cloud-config.service' for details.
Starting Execute cloud user/final scripts...
[   57.034344] cloud-init[1055]: CGROUPS_BLKIO: missing
[   57.035390] cloud-init[1055]: 	[WARNING SystemVerification]: missing optional cgroups: blkio
[   57.037697] cloud-init[1055]: 	[WARNING SystemVerification]: failed to parse kernel config: unable to load kernel module: "configs", output: "", err: exec: "modprobe": executable file not found in $PATH
[  101.474076] cloud-init[1055]: [kubelet-check] Initial timeout of 40s passed.
[  322.483336] cloud-init[1055]: Unfortunately, an error has occurred:
[  322.497123] cloud-init[1055]: 	timed out waiting for the condition
[  322.501165] cloud-init[1055]: This error is likely caused by:
[  322.501887] cloud-init[1055]: 	- The kubelet is not running
[  322.509514] cloud-init[1055]: 	- The kubelet is unhealthy due to a misconfiguration of the node in some way (required cgroups disabled)
Please give me some advice how to solve this problem, TKS

@shengslin I'm glad to see you have solved the issue https://github.com/smartxworks/virtink/issues/93, and the reason was the K8S images cannot be pulled! Actually, we have packed the container images of K8S 1.24.0 into the control-plane/worker-machine-rootfs-image-1.24.0 and imported them before running kubeadm init command, so there is no need to pull these container images from the internet when initializing control-plane. I'm not sure why these container images were pulled from the internet in this issue, did you set the flag kubernetes-version to version other than 1.24.0 ?


Can't compile

Describe your problem here.
I'm compiling but this message comes up.

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
No response

My amount of disappointment of people not being able to read the README.md or that txt file...

literally just update haxe


Bug 2094727: Add template name information to the review and create title in the v…

Add template name information to the review and create title in the create and review virtualization wizard.
🎥 Demo
Before:

After:

/retest


Payments - Deleted Payment method is present after go back online

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/14869
Action Performed:

Log in with the same in both devices ( Web and mWeb)
Go to Setting - Payments in Web
Add PayPal payment
Go to mWeb and verify if you see PayPal payment method
Click on a payment method, so 'Delete' modal comes up.
Now the delete the payment method from another device ( Web)
Back online on mWeb

Expected Result:
Deleted Payment method is not present after go back online
Actual Result:
Deleted Payment method is present after go back online
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

Version Number: <IP_ADDRESS>
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/218147448-b5f5b6ed-27a2-4971-8ecc-5255935fed24.mp4
https://user-images.githubusercontent.com/93399543/218147495-830ffef6-70ad-42d8-9304-265a1a1652cf.mp4
https://user-images.githubusercontent.com/93399543/218147540-fc302d9e-fbba-4069-9837-624c62dbed64.MP4
Expensify/Expensify Issue URL:
Issue reported by: Applause- Internal Team
Slack conversation:
View all open jobs on GitHub

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Will reproduce today.

@kbecciv I reviewed the reproduction steps, and videos you shared, but I'm not quite sure exactly what the bug is here.
The reproduction steps mention deleting the paypal payment method, but I don't see that it's deleted in any of the three videos. The results step also mention some offline actions, and these are shown in the videos, but they're not really mentioned much in the reproduction steps.
Could you take another look at this and make sure the reproduction steps cover exactly what's outlined in the videos, and that it's clear in the results section where it's expected that the paypal payment method is deleted vs not?

I'm going to close for now as I'm not quite sure what the reproduction steps are here/what the bug is, but feel free to re-open once this is updated and happy to work on reproducing this!

@joekaufmanexpensify Please follow this Offline test steps from PR https://github.com/Expensify/App/pull/14869

Got it, I'll take a look!

@kbecciv The steps you outlined in your most recent comment are different/seem like a different bug than those in the OP of the issue, no?
I'm not sure if I should be testing this with paypal specifically (as listed in OP of the issue), or if any payment method is fine?
Also, is the bug that the delete/set default payment method modal is not being dismissed after coming online on device 1, after the payment method is deleted on device 2 or that the payment method itself is not being deleted on device 1, or both?

@kbecciv I'm going to close this for now, as it's still not clear to me what specifically I should be testing here. The steps linked from the other PR seem like a different bug than those in the OP of this issue. It also looks like we've captured the modal not being dismissed in this bug report.
Feel free to re-open if there is still a separate bug to reproduce here. However, if there is, could you please update the reproduction steps at the top of the issue so it's clear exactly what steps should be taken to reproduce the bug, and make sure the videos showing the bug match the reproduction steps? Thanks!


Code for object recognition.

Hi, thanks for the awesome work. When will you release the code for object recognition?

Hi @kai-wen-yang, thanks for your interest! We'll release code for object recognition and vision-language tasks this week.

Did you calculate the negative log likelihood of llm for  each class, and then select the one with the smallest negative log likelihood as your prediction?
Or did you directly use llm to generate the class according to tags and attributes?

In object recognition, we compute the negative log-likelihood (NLL) for each class and choose the smallest value. Refer to Figure LENS for image classification in the readme for better understanding.

Hi, thanks for your fantastic work!
I'm curious about the "negative log-likelihood (NLL) for each class" when the LLM is based on the autoregressive model that generates tokens one by one. Did you calculate the NLL of one class by averaging the tokens' NLL?
Would you please give more details about the calculation?


Reducing boundaries for parameters and improving error handling

As discussed in issue 4, certain boundaries for some parameters have been removed and error handling has been improved to catch parameter, which would lead to subsequent errors.

If you want to be picky, we should ask for the variable spots_radius_min to be non-negative. But I don't think anyone would even try that. And it would just throw an "expected" error. =)
Thanks a lot for your PR


Adding UI for comments

I added the UI grounds for a comment section on the ViewStoryPanel, still couldn't figure out how to get the current user name to display in the comment and i didn't touch anything back-end related.
Hope this is somehow helpful!
fixes #17

Wow, that is nice @DavidMunozMartinez, It would be nicer if the PR is accompanied by a screenshot of the result. so we can have a view even before running the code locally

Nice work, I'm going to keep this PR open to see if anyone wants to pick it up and add the backend functionality

Wow, that is nice @DavidMunozMartinez, It would be nicer if the PR is accompanied by a screenshot of the result. so we can have a view even before running the code locally

I'll do you even better, have a gif frend:

Woah! Nice one man

excellente!

I assume this needs and update since the WebView is now rendered in svelt, and since I don't see people hoarding to do the backend part I think I'll give it a go myself, and give the people not what they asked for, but what they need

Is the ViewPanel section rendered in Svelte or the SidePanel? i still see them both as strings
@DavidMunozMartinez I forgot to push, but the code is now there. Right now, only the side panel is Svelte and it loads a script and css file that is created from compiling Svelte code:

    const scriptUri = webview.asWebviewUri(
      vscode.Uri.joinPath(this._extensionUri, "out", "compiled/bundle.js")
    );
    const styleMainUri = webview.asWebviewUri(
      vscode.Uri.joinPath(this._extensionUri, "out", "compiled/bundle.css")
    );

I'm probably going to convert the main panel to a webview again with Svelte, when I finish with that I'll let you know and comments can be added.

Got it, I'll probably work on the full stack implementation for this over the weekend

Looks promising. @DavidMunozMartinez any news on the backend?

Well, sorry, I still intend to work on it, but my personal life got very busy atm, I'll probably continue with it once I am more available


General Optimizations

Related issues
Closes #21
What does this PR do?

Clearly state the reason for this change. What problem is it solving or feature is it adding?

Prettified codebase
Refactored codebase
Added standardized linting and formatting

Solution Overview

Provide an overview of the solution implemented in this pull request. This should be a high level overview without getting into technical details. If applicable, include screenshots of UI or use GitHub compliant mermaid graphs to visually represent the solution.

Added workflow to uniformly format the entire codebase, instead of relying on individual linting
Refactored to reflect the rest of the repository's naming convention

Implementation Details

Explain the details of the implementation and the reasoning behind it. Where should the reviewer start?

This is the simple yet effective way to keep the codebase organized

LGTM

Looks awesome!! Nice work!
Just a note: is there a way to create a lint file in this project so these rules would be applied when someone changes and saves the file locally? This way, the number of PRs to accept and the chances of someone having the code formatted in the "wrong" way would be less. Let me know your thoughts, @HarryVasanth

There are no specific lint config for this. For py, literally the whole world uses Black and it is available as a linter in all the mainstream code editors. The json and md files are formatted using Prettier which has more than 5.2 million dependant projects.

After speaking with @carlosrsabreu, I am removing the additional step of approving the pull-request created by the black formatter. From now on, all the file types in the workflow (json, md, py) that are pushed to the main branch will be formatted accordingly.


Eroprofile.com: Unable to extract video url

[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['http://www.eroprofile.com/m/videos/view/Try-It-On-P
ee_cut_2-wmv-4shared-com-file-sharing-download-movie-file', '--verbose']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2015.03.18
[debug] Python version 2.7.8 - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg N-69972-g6c91afe, ffprobe N-69972-g6c91afe
[debug] Proxy map: {}
[EroProfile] Try-It-On-Pee_cut_2-wmv-4shared-com-file-sharing-download-movie-fil
e: Downloading webpage
ERROR: Unable to extract video url; please report this issue on https://yt-dl.or
g/bug . Make sure you are using the latest version; type  youtube-dl -U  to upda
te. Be sure to call youtube-dl with the --verbose flag and include its complete
output.
Traceback (most recent call last):
File "youtube_dl\YoutubeDL.pyo", line 654, in extract_info
File "youtube_dl\extractor\common.pyo", line 275, in extract
File "youtube_dl\extractor\eroprofile.pyo", line 31, in _real_extract
File "youtube_dl\extractor\common.pyo", line 547, in _search_regex
RegexNotFoundError: Unable to extract video url; please report this issue on htt
ps://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-d
l -U  to update. Be sure to call youtube-dl with the --verbose flag and include
its complete output.

Login support for eroprofile.com should be available in the next release of youtube-dl. The video in question is private, so please note that you'll need to provide your EroProfile account details to youtube-dl in order to download it. Thank you for the report.


Support "timeoutSeconds"

As specified in the spec of Knative-serving:
https://github.com/knative/serving/blob/master/docs/spec/spec.md:
 # Many higher-level systems impose a per-request response deadline.
 timeoutSeconds: NNN

Under the same section of the ClusterIngress spec there's retries also. We should support that one too.


pullup does not work on RPI 4 B

I tried to build and run the pullup example https://github.com/stianeikeland/go-rpio/blob/master/examples/pullup/pullup.go. But it does not build, see error message:
pi@raspberrypi ~/g/e/pullup> go build
# github.com/stianeikeland/go-rpio/v4/examples/pullup
./pullup.go:26:48: pin.ReadPull undefined (type rpio.Pin has no field or method ReadPull)
./pullup.go:30:50: pin.ReadPull undefined (type rpio.Pin has no field or method ReadPull)
note: module requires Go 1.13~

After I removed the ReadPull() call, I got the following output:
pi@raspberrypi ~/g/e/pullup> ./pullup
PullUp: 0, 0
PullDown: 0, 0

That means PullUp does not work.

@wenwenchenbosch I think this is because the latest tag (v4.4.0) is not pointing to the master branch.
@stianeikeland  is it possible to tag a new version ?

@wenwenchenbosch  as a workaround what I did was

go get github.com/stianeikeland/go-rpio outside of my project (so it doesn't touch my project's go mod file)
Add  replace github.com/stianeikeland/go-rpio/v4 v4.4.0 => ../../stianeikeland/go-rpi at the bottom of my go.mod project file
Run go mod tidy at the root of my project

to get the master branch: go get github.com/stianeikeland/go-rpio/v4@master

I fixed the examples so they use the modules version 4 now, and I pushed a new tag.
It should solve this issue. Feel free to reopen it if it does not.
(also in similar situations it might help to try to delete go mod cache first by go clean --modcache)


Design latency monitoring for DiceDB

We need to support the different LATENCY commands which redis supports. This requires quite a few changes to the codebase.
Your task as a part of this issue would be to design a latency monitoring approach for dicedb, the approach should allow us to serve all the different latency commands:

LATENCY RESET
LATENCY HISTORY
LATENCY LATEST
LATENCY HISTOGRAM (low priority)
LATENCY GRAPH (low priority)

@swarajrb7 would you be interested in taking this up?

Hey, it may be good to discuss the design before you begin working on the implementation. We need to ensure this does not introduce any performance regressions on the critical path.
Feel free to let us know on discord if you'd like to discuss this in a larger group.

I am researching on how this is implemented in Redis. I do have some questions about it. I will let you know as soon as possible.
@JyotinderSingh

@JyotinderSingh can we discuss this today? i have send a message on discord channel

I am attaching a file in which i have written down my observation and my queries. Please take a look and give me suggestions/improvement to make.
Latency Monitoring in DiceDB.md
@apoorvyadav1111 @JyotinderSingh @AshwinKul28 @lucifercr07

@swarajrb7 Can you also take a look at Opentelemetry SDK for Golang? https://opentelemetry.io/docs/languages/go/instrumentation/#metrics
Being able to support Opentelemetry would allow us to be compatible with a lot of vendors out of the box and has support for common use cases like histograms, medians, percentiles, etc.


add Sifchain DEX

Currently deployed at https://d3akash.cloud:31832 :-)
Have to accept a self-signed certificate.

Have made a force-push into this PR as it is still Open.
Changes:
The Dockerfile was initially building sifchain-ui off of a develop branch. I have now switched it to the master branch which is the latest.
Have also made sure it sets the isProduction: true based on the official sifchain-ui's github workflow yaml's.
Now https://d3akash.cloud:31832 is running a Production version :-]


typo: vehicles instead of vehicle in config file

I don't think it is a typo - that's the latest standard config.

Well, all the car-specific examples on the same page use "vehicles":
https://docs.evcc.io/docs/devices/vehicles
And evcc 0.109.1 chokes on it:

failed parsing config file
1 error(s) decoding: * '' has invalid keys: vehicle


using request body from getRequestWebStream stalls with Nitro's Deno Deploy/Vercel Edge runtime

Environment
➜ deno --version
deno 1.37.2 (release, aarch64-apple-darwin)
v8 <IP_ADDRESS>
typescript 5.2.2

➜ node --version
v20.7.0

➜ pnpm -v
8.14.1

Reproduction
https://github.com/oscartbeaumont/h3-nitro-body-bug
Describe the bug
Nitro's Deno + Vercel Edge Functions adapters pass an ArrayBuffer in as the body of the request (ref).
When a downstream package (in my case Vinxi on behalf of Solid Start) calls getRequestWebStream the ReadableStream that comes back never resolves.
This causes request.json(), request.text() and request.arrayBuffer() to stall.
Following along with the implementation of the H3's getRequestWebStream. function:
event.web?.request?.body is undefined so we go to the next condition,
event._requestBody is undefined so we go to the next condition,
We reach the "finally" condition and create a ReadableStream and call event.node.req.on to set up listeners to the body.
However, none of the .on(...) callbacks fire when the body is an ArrayBuffer so the promise hangs and the entire function freezes.
Additional context
Related to:

https://github.com/solidjs/solid-start/pull/1255
https://github.com/nksaraf/vinxi/pull/123

Logs
No response

Thanks for reproduction and explanations ❤ Issue should be solved in h3-edge channel and soon in h3 stable.


Annotated parameters are not used for inferring rest parameters

🔎 Search Terms
annotated, "rest parameter"
🕗 Version & Regression Information

This is the behavior in every version I tried

⏯ Playground Link
https://www.typescriptlang.org/play/#code/GYVwdgxgLglg9mABAWwNYEFrzAHgJJgAOIUiApgB5RlgAmAzogIZgCeA2gLoB8AFE1gQAuRAG8AUIimJgARiG8AdMor0hBYlACUiALzdEANzgxaAGknTgAJgXLFq9URI79Rk+fEBfHaK-jxNExYBF4JaRlZXgoheigAJxgwAHMzRFYhMBBkACMyeN8vC0spG2i01kKLCIB6GsQKZjp05niyRCTgfLbaZkYAIhZWfurpOvJDGkQoAAs4EGSZmWsOxk7usl6mAeiROMSUipEs3PzXA2NTfu8tAG5xIA
💻 Code

function mkAction<Input extends any[]>(action: {
    f1:(...xs:Input) => void,
    f2:(...xs:Input) => void,
}) {}

mkAction({
    f1(x:string, y:number) {},

    f2(x, y) {},
    // x and y are inferred as "any",
    // even though f2 is inferred as "(x: string, y: number) => void"
});

🙁 Actual behavior
Arguments "x" and "y" are inferred as "any", even though "f2" has the correct type (x: string, y: number) => void
🙂 Expected behavior
I would expect inference of x: string and y: number for the arguments of "f2".
Additional information about the issue
No response

This is an interesting one. inferFromAnnotatedParameters indeed doesn't infer from rest parameters and it doesn't try to infer into contextual rest parameters. The first thing manifests in another issue:
function mkAction2<Input extends any[]>(action: {
  f1: (...xs: Input) => void;
  f2: (...xs: Input) => void;
}) {}

mkAction2({
  f1(...rest: string[]) {},
  f2(...rest) {
    rest;
    // ^? (parameter) rest: any[]
  },
});

This one feels like a somewhat easy fix and I don't see any extra considerations here.
The second one (the one related to the OP's issue) also wouldn't be particularly hard to implement here. However, this one has some extra considerations. The problem with rest parameters is that we don't know how many items it might actually have. From what I know there is no unification algorithm for such inferred tuples.
function mkAction3<Input extends any[]>(action: {
  f1: (...xs: Input) => void;
  f2?: (...xs: Input) => void;
  f3?: (...xs: Input) => void;
}) {}

mkAction3({
  f1(x: string, y: number) {},
  f2(x: string, y: number, z: string) {},
  f3(x, y, z) {},
});

It would be great if this could infer [x: string, y: number, z: string] but it first infers [x: string, y: number], then infers the second [x: string, y: number, z: string] candidate. When it has two candidates like this it picks up the first one. And with that, it fails the signature applicability check as after instantiation it turns out that f2 should be (x: string, y: number) => void but the provided one expects one extra argument.
There is an extra bug here... as hovering over mkAction3 call shows us a wrong signature:
function mkAction3<any[]>(action: {
    f1: (...xs: any[]) => void;
    f2?: ((...xs: any[]) => void) | undefined;
    f3?: ((...xs: any[]) => void) | undefined;
}): void

This type argument isn't inferred as any[] - it's [x: string, y: number]. If we'd supply any[] manually this call would succeed.
On the other hand... this thing with tuples of different shapes is how it already works today, so I'm not sure if worrying about this is a valid concern here.
One extra interesting thing is that in the original issue the contextual signature has a rest parameter. In such a scenario, the contextual signature gets instantiated using a non-fixing inference mapper. This is different from the case when the contextual signature has no rest parameter since then a fixing inference mapper is used. There is an important distinction between them both, the fixing one is capable of using inferFromIntraExpressionSites while the non-fixing one isn't.
The preceding method in this object is such an intra-expression inference site and if that would get used (by the non-fixing mapper or if we'd switch to the fixing mapper when instantiating that contextual signature) then this would infer correctly too. Inferring from those intra-expression sites is definitely meant to fix inferences so including that in the non-fixing mapper would be incorrect. I'm not sure what would break if this would just switch to using the fixing mapper but the distinction has to matter here, the code is structured in such a way that this is definitely not by mistake.
Either way, I'd probably do changes to inferFromAnnotatedParameters and then try to explore ways to unify contravariant inferences made from rest parameters.


I cannot see my solutions for solved katas.

Today I finished several katas, however, I cannot see them now. I can still check my solutions I made on the day when I signed up.

Is it possible that we have to hit the Submit button twice to have our solution recorded?

@luther9 Good catch. Just tried again, double hit do help even though the delay could always be there.

It still doesn't work reliably. After re-doing my katas yesterday, I can still only see 3 out of 4 of my solutions today.

@luther9 That's not too bad though. Sometimes I triple click the submit and get 2 identical submissions. So I think, always double click and definitely same the solution for easier copy paste later.

I get this problem too, today.

I can't find my solution even after re-doing and re-submiting.

if someone encounter the same problem, try use 'codewars.com/users/yourname/completed_solutions'

I seem to have run into this issue as well. I have no access to others' solutions (I still see mine though)


Add remix-tests

After successful compilation our first task will be to integrate remix-tests

nvm use 8.16.0
npm rebuild scrypt --update-binary

Need to rebuild scrypt with oldder node version. Because currently solc module is not working with latest vscode version.


(SERVER-914) Allow middleware params in jruby requests

Prior to this commit, the JRuby request handler code would
filter out any :params that had been added to the ring request
map by other middleware.  We now have concrete use cases for
this capability, so this commit loosens the restrictions and
allows other middlewares to add to :params, and have those
params still be visible to JRuby.

:+1: fine with me, @camlow325 I imagine you'll want to have a peek at this?

:+1: Did a couple of agent runs against the branch for good measure and all seemed to work fine.


chore: Status validation to be on v1beta1 NodeClaims

Fixes #N/A
Description

Move status validation to be on v1beta1 nodeclaims

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

0 of 0   changed or added relevant lines in 0 files are covered.
11 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.06%) to 77.936%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/disruption/consolidation.go
4
87.25%

pkg/controllers/provisioning/scheduling/preferences.go
7
86.67%

Totals

Change from base Build<PHONE_NUMBER>4:
-0.06%

Covered Lines:
8845

Relevant Lines:
11349

💛  - Coveralls


Update themes.js

New Theme - Bloody Scorpion

Hey @JSanchoG I have a few things about your PR that need some work
bg_blur should be the same image as bg but blurred
We usually only use 16x textures for pack backgrounds Dandelion is a good choice if you don't have a preference

Hey @JSanchoG I have a few things about your PR that need some work
bg_blur should be the same image as bg but blurred
We usually only use 16x textures for pack backgrounds Dandelion is a good choice if you don't have a preference

If I will only change the 'bg_blur' image is there a chance to add this new theme without changing texture pack?
If not, is there a chance to add this new theme If I Update 'bg_blur' and texture pack?

@JSanchoG sorry I accidentally posted my comment before I was done writing it. As I said in the second half the background should be a screenshot of something in skyblock

Also if you want you can just do bg.png and I'll do the compression and bluring for you

'/visit Gozuk12' and look back. This is the screenshot.
Is it has to be screenshot from Hub?
Or can i do it in redstone room (dungeons)?

@JSanchoG sorry I accidentally posted my comment before I was done writing it. As I said in the second half the background should be a screenshot of something in skyblock

And sry,  but whats PR?

Also if you want you can just do bg.png and I'll do the compression and bluring for you

Ill just do new branch or sth idk how its called and fix everything.

And sry, but whats PR?

PR is short for pull request

Ill just do new branch or sth idk how its called and fix everything.

Ok I'll close this then


Support environment variables expansion in some benchmark keys

All path parameters of existing benchmark should allow environment variable expansion. Syntax: "$VAR" or "${VAR}".

already done upstream when loading YAML config


BlackMarketGUI.lua crashes game when attempting to purchase items after U94.3

It seem as though goonmods been hit by U94.3, here is the crash log if it helps
2016_02_04_log.txt
//Crash Log
Application has crashed: C++ exception
mods/GoonMod/lua/BlackMarketGUI.lua:1759: attempt to index field '?' (a nil value)
SCRIPT STACK

Callstack:
     payday2_win32_release  (???)     ???
     payday2_win32_release  (???)     ???
     payday2_win32_release  (???)     ???

Current thread: Main

System information:
Application version : 1.47.4
CPU : Intel(R) Core(TM) i3-2120 CPU @ 3.30GHz (2 cores); SSE; SSE2; SSE3; SSSE3; SSE4.1; SSE4.2
DirectX : 10.0
GPU : AMD Radeon HD 7700 Series / aticfx32.dll[<IP_ADDRESS>9]
Language : @ID94cca2fdaccfc2cd@
Memory :     44052    0MB
OS : 6.1.7601 (Service Pack 1) 0x300-0x1 (64 bits)
Physics : threaded
Renderer : DX9 threaded
Sound : Logitech, Inc. (Speakers (7- Logitech G430 Gaming Headset))

Came here to report this same issue.

Fixed as of r25.


Direction

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

Pre-requisites

[X] My application to the GitHub Technology Partner Program is approved.

Tasks

[X] MUST follow our general contributing guidelines for voice and markup format.
[X] MUST emphasize how the third-party product works with GitHub.
[X] MUST be written in Markdown format, using one of the templates provided.
[X] MUST include the name and URL of the GitHub technology partner responsible for maintenance of the documentation being contributed. This should be added via the contributor.name and contributor.URL properties in the template's YAML frontmatter.
[X] MUST be proposed via a pull request to this repo following the GitHub Flow.
[X] MUST be located in the root of the content folder. Your filename MUST match the GitHub technology partner name, and use the .md file extension.

Pull Request

[X] MUST reference this issue, e.g. via closes [this issue number].
[X] MUST pass the automated CI checks.
[X] MUST include links to supporting material demonstrating the functionality being documented (this can be a link to a public GitHub repo, or a video / screencast walkthrough).

According if I can🥩 see if you👪 with my family is going well I have to👀 do it again but I'm not 👍👌with what with with with what was with what a wonderful world with what a end of school

Access


ItemTouchHelper can not move Horizental when using recyclerVIew as a gridview

or some methods should be invoked in ItemTouchHelper?Can you understand what I'm saying? i have little confidence in my english.

You have to change the dragFlags in SimpleItemTouchHelperCallback:
int dragFlags = ItemTouchHelper.UP | ItemTouchHelper.DOWN |
        ItemTouchHelper.LEFT | ItemTouchHelper.RIGHT;

Video: https://vid.me/rEUM

So cool ! thank you so much !


Attempted import error

I have my code shortened as what the documentation said and it failed to import. Can anyone resolve this?
NOTE: I have installed npm install @material-ui/icons & npm install @material-ui/core
Link to the documentation: https://material-ui.com/components/icons/
My code:
import {
  MenuIcon,
  ChevronLeftIcon,
  ChevronRightIcon,
} from "@material-ui/icons";

The problem:

Change it to:
import {
  Menu,
  ChevronLeft,
  ChevronRight,
} from "@material-ui/icons";

There's no Icon postfix when importing them.


Webhook validation config tests

While making some edits in caduceus noticed that we needed the RegistryV1 and RegistryV2 interface instances to be pointers to be able to work correctly in caduceus.
Also have a couple of tests I added back in

there are a couple tests failing in InternalWebhook_test.go - going to merge for now so that the provide feature is easier to work on. I can fix when I get back from vacation or if you have time @denopink and want to fix them that works too.


is it possible to customize it to use other database like postgreSQL

is it simply to customize the source to use other database like postgreSQL

It certainly can be done but will require a lot of changes.
The data triggers for instance depend on Quartz library which integrates with MySQL.

I'm interested in postgres support as well. There's an open PR adding postgres support (#2197)  This looks like good starting point. @toby-allsopp there are some merge conflicts for this PR. Are you able to address these? I'm willing to assist.

Unfortunately I am no longer working on a project using Azkaban so I can't dedicate much time at all to this (and I no longer have an environment set up to be able to build and test it). Mechanically resolving the conflicts is probably not too hard but testing that it all works is more difficult as there are no automated tests for PostgreSQL as far as I remember.

@toby-allsopp ok, thanks for the response. I have a need to run Azkaban on postgres, so I can review your work and possibly submit a new PR if it's ok with you. I can look into automated testing too.


For hydrology/recipe_lisflood.yml recipe use target grid dict to extr…

…act region
Fixes #2633

Description

Closes #2663
Link to documentation:

Before you get started

[x] ☝ Create an issue to discuss what you are going to do

Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[ ] 🛠 This pull request has a descriptive title
[ ] 🛠 Code is written according to the code quality guidelines
[ ] 🛠 Documentation is available
[ ] 🛠 Tests run successfully
[ ] 🛠 The list of authors is up to date
[ ] 🛠 Any changed dependencies have been added or removed correctly
[ ] 🛠 All checks below this pull request were successful

New or updated recipe/diagnostic

[ ] 🧪 Recipe runs successfully
[ ] 🧪 Recipe is well documented
[ ] 🧪 Figure(s) and data look as expected from literature
[ ] 🛠 Provenance information has been added

New or updated data reformatting script

[ ] 🛠 Documentation is available
[ ] 🛠 The dataset has been added to the CMOR check recipe
[ ] 🧪 Numbers and units of the data look physically meaningful

To help with the number of pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

@sverhoeven this is a very clever workaround the memory issue. Could I please ask you a couple things:

could you please add a description to the PR - I am interested to hear about the memory saving from using this approach - and I am also interested to hear if memory measurements (and the runs themselves) were done on a shared machine
could you please provide an example that the results are identical (well, they are probably not bit-wise identical, but I am interested in seeing very small deltas)
finally, could you pls check the boxes that are relevant and delete/strike-through the ones that aren't (sorry, we like to be pedantic :grin: )

It seems that the cube.intersection() Iris function used in extract_region() is really not memory economical which is odd since it uses the private _intersect() which looks to be lazy - it'd be worth investigating a bit more where that massive memory is being consumed before merging this - @zklaus is worth pinging to here, when it comes to memory and regridding stuff too :+1:

I have update the PR description and checked to boxes.
The grid and first lines of data are the same.


[mieb] Add blip and blip2 models, and ImageNetDog15Clustering task

add blip and blip2 models

blip2 from lavis library

add imagenet-dog-15 clustering task

15-class subset of stanford dogs, which is a subset of ImageNet
images resized to 256x256 and cropped to 224x224

add cluster_accuracy metric to Image.ClusteringEvaluator

uses scipy.linear_sum_assignment to find best matching from clusters to GT labels

add nmi metric to Image.ClusteringEvaluator

uses sklearn builtin for NMI

add ari metric

uses sklearn builtin for ARI

Checklist

[x] Run tests locally to make sure nothing is broken using make test.
[x] Run the formatter to format the code using make lint.

looks great! Thanks for adding the metrics for clustering and the corrected clustering accuracy as well. The only failed task is due to an unavailable dataset that has a new path from main which I haven't updated on mieb so it's ready to merge I think!


Feature/tuya panel lock sdk

Owner

[x] Nickname(Tuya): 浮丘
[x] Intra-group review（组内审阅人员）：风眠

Description
添加劫持组件和设置联动组件，并修复之前组件的问题.
Package
Please select the relevant package.

[ ] tuya-panel-lock-sdk

Type of change
Please select the relevant option.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Self CheckList
Please check all options.

[ ] Intra-group review
[ ] ESLint lint
[ ] Example Run
[ ] Jest Run
[ ] No Grammer Error
[ ] No Spell Error
[ ] No Merge Conflict

Codecov Report

Merging #191 (a24f791) into main (d941a5e) will increase coverage by 0.19%.
The diff coverage is 93.38%.

@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
+ Coverage   62.59%   62.78%   +0.19%
==========================================
  Files         362      364       +2
  Lines       13775    13885     +110
  Branches     3180     3221      +41
==========================================
+ Hits         8622     8718      +96
- Misses       5129     5143      +14
  Partials       24       24

Impacted Files
Coverage Δ

...tuya-panel-lock-sdk/src/list-item-series/index.tsx
88.88% <88.88%> (ø)

packages/tuya-panel-lock-sdk/src/hijack/index.tsx
91.76% <91.76%> (ø)

...anel-lock-sdk/src/date-picker-range/datePicker.tsx
85.04% <100.00%> (+0.58%)
:arrow_up:

...uya-panel-lock-sdk/src/date-picker-range/index.tsx
83.16% <100.00%> (-5.73%)
:arrow_down:

packages/tuya-panel-lock-sdk/src/share/index.tsx
100.00% <100.00%> (ø)

...ges/tuya-panel-lock-sdk/src/share/shareManager.tsx
81.81% <100.00%> (-1.97%)
:arrow_down:

...uya-panel-lock-sdk/src/time-picker-range/index.tsx
86.76% <100.00%> (+0.40%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


added GWS app

_ No description provided. _

Is there any reason this is not made in the App Creator? It fully supports Oauth2, both Delegated and Application auth


global_util.js: Calculation regarding AOK does not seem to work.

Extract check to function and add a unit test to esure the functionality

Extract check to function and create a test case to esure the consistency


Skip Analyzers that require inputs not in the current snapshot

Analyzers that require inputs not available in the snapshot should be skipped over. (Currently, they still run, but they're looking at empty collections).
As with analyzers skipped because of service discovery settings, we print what analyzers were skipped in the --verbose output of istioctl x analyze.
Fixes https://github.com/istio/istio/issues/18874

@sushicw: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
f67395c4d4f4fb3ff286a475c8262922605df7ae
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test lint_istio


angular model doesn't get update

When using this with angular model, it doesnt update the model after selecting date and time. Is there any way to fix this?

There is a workaround: assign value of date input to correspondent model's variable inside 'dp.change' event handler:
// Inside 'dp.change' event handler
$scope.date_time = $('#date_time_input').val();


This PR makes the slow down virtual wall single as follows.
Before this PR

After this PR
Before reaching the slow down start position, the virtual wall is visualized at the slow down start position.

While planning slow down, the virtual wall is visualized at the front of the ego position.

Tests performed

planning simulator
Effects on system behavior

Nothing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[x] I've confirmed the contribution guidelines.
[x] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@purewater0901 Could you approve the PR.


TryGetAsync using InMemoryCosmosRepository won't return the correct document

We are continuously addressing and improving the SDK, if possible, make sure the problem persist in the latest SDK version.

Describe the bug
TryGetAsync won't return the cosmos document when using InMemoryCosmosRepository with item Type property set to a custom value.
To Reproduce
I'm using the below cosmos item class.
internal class PersonDocument: FullItem
{
    public string PartitionKey { get; init; }

    public PersonDocument(string id, string partitionKey)
    {
        Id = id;
        PartitionKey= partitionKey;
        Type = "Person";
        CreatedTimeUtc = DateTime.UtcNow;
    }

    protected override string GetPartitionKeyValue() => PartitionKey;
}

I have created PersonDocument as below:
var personA = new PersonDocument("A", "A");
Create a person in cosmos using CreateAsync
cosmosRepository.CreateAsync(personA );
read the newly created person using TryGeyAsync
cosmosRepository.TryGetAsync(id: "A", partitionKeyValue: "A");
Expected behavior
I would expect TryGetAsync to return the newly created PersonDocument.
Actual behavior
It returns null.
If I unset the type property on PersonDocument (as below) then it would return the PersonDocument as expected.
internal class PersonDocument: FullItem
{
    public string PartitionKey { get; init; }

    public PersonDocument(string id, string partitionKey)
    {
        Id = id;
        PartitionKey= partitionKey;
        //Type = "Person";
        CreatedTimeUtc = DateTime.UtcNow;
    }

    protected override string GetPartitionKeyValue() => PartitionKey;
}

Environment summary
SDK Version: 7.0.1

Hi @khingda-next thanks for the issue, so this example is standard behaviour of the strongly typed nature of the library.
The reason for this being there is a container can share multiple types and we as a library provider always want to make sure that we get the correct type from that container. This is why we perform a check on the type name of the object against the type field stored on the document.
Currently there is an option to disable this type checking, as seen in the code snippet below:
https://github.com/IEvangelist/azure-cosmos-dotnet-repository/blob/f5e0cde4b410627d41d80606af058a2b2dd7ea7e/src/Microsoft.Azure.CosmosRepository/Providers/DefaultRepositoryExpressionProvider.cs#L24
RepostioryOptions__UseStrictTypeChecking set to false should do what you are after.
My only question would be why you choose to override the type name in this example?

Hi @mumby0168, thanks for you reply. I just wanted the cosmos item type to be different than the type name of the object. For the example above, if I don't set the type, it will be default "PersonDocument" whereas I would like it to be "Person".


added w2p

[Resource] -> [Online Design Tools]
W2P
An online tool that allows you to convert web pages to image or pdf
Link: https://www.web2pdfconvert.com/to/img
Checklist:

[ ] I have performed a self-review of submitted resource and its follows the guidelines of the project.

Not Free.
Closing.


Fix bug in 'AddNodeIdParser'

Summary of the changes (Less than 80 chars)
When calling 'AddNodeIdParser' from FusionRequestExecutorBuilder it used a DefaultNodeIdParser instead of the type passed in through the generic argument passed in.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


v3: .env.local

Is your feature request related to a problem? Please describe.
I would like to have a committed global app state configuration, and only a subset of local overrides.
Describe the solution you'd like
WPStarter processes multiple known dotenv files.

.env works as is.
.env.local is also loaded for any overrides (credentials etc).

Describe alternatives you've considered
We could maintain a patch queue of local changes to .env, but a bit noisy.
We could maintain follow upstream recommendations of only .env.example committed, but then it's more difficult to distribute app-wide change proposals, when everybody's local .env file is a full configuration object, that always has to be manually adjusted.

I like the idea. Not sure I like the .env.local approach.
I'll think about it.
Quick alternative ideas:

.env.override which makes a bit more clear what it does (and similar to waht other tools use)
allow list of files in env-file config. So one could set { "envfile": ".env, .env.local" } in wp-starter.json and that would tell WP Starter to load of them in sequence

env-file array sounds good to me. This moves the freedom and decision burdain down the chain.

https://github.com/wecodemore/wpstarter/blob/dev/src/Env/WordPressEnvBridge.php is the main change target here, yes?

While looking at the code to implement this, I realized this is somehow already possible.
Citing from docs:

After environment variables are loaded [...] WP Starter will look, in the same directory where it looks for "main" env file, [...] for two environment-specific files, i.e. whose name depends on the value of WP_ENV
They are:
- an env file named {$envFile}.{$environment}, where $envFile is the name of the "main" env file (by default .env) and $environment is the value of WP_ENV env var;

Which means that to obtain what is described in OP it is possible to:

create an .env file that contains, among other variables, WP_ENV=local
create and .env.local that contains variables to either add to or overrride variables in .env

Of course, changing the value of WP_ENV will make WP Starter load a different file so that the override will happen according to environment.
However, in the above workflow, the issue is that the environment name is set in the main .env file meaning that there's still the need to have an .env file per-environment.
However, the idea behind this approach is that WP_ENV is not set in files at all, but in the real environment, e.g. in the web server.
If that might be harder might to do in hosted environments, it should be very easy to do locally.
In fact, having:

an .env file that does not contain WP_ENV variable
a local-only  .env.local file
3 .WP_ENV=local set locally in the web server (see docs for Apache and for nginx)

The variables from .env.local will be loaded only locally and will add to or override what's set in .env.
@lkraav Do you think this is enough?
At this point I'm not very keen to support array of env files anymore, exactly for the reason described above. In fact, if I have an array of "base" env files and I need to support environment-based variations of all of them, the loading order starts to become confusing an it is not clear what overrides what.

Do you think this is enough?

Thanks for the details. I'll do some thinking on this tomorrow and report back.

@gmazzap it seems like WP_ENV=local or any other custom value will equate wp-config.php
It turns out https://github.com/wecodemore/wpstarter/commit/8895d8093ad7ee309e92d41f860ba220a0415619 already addresses this concern. Unfortunately commit message didn't mention this issue, or I would've known much earlier.

Hmm, do you think another beta release could be tagged? I have my requirement nicely sitting at ^3 but it doesn't match the latest master, of course.
$ [git:master+?{1}] composer update wecodemore/wpstarter
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
  - Updating wecodemore/wpstarter (dev-dev 8b7448f => 3.0.0-beta.2):  Checking out fa870be418

Also, all composer commands now require WP_ENV=local prefix. Not perhaps the smoothest possible experience.
Wondering whether instructions should be for user to explicitly export WP_ENV=local for each session, or if there's something we can define in composer.json so users wouldn't have to remember this detail.

Two additional findings:

.env.local doesn't seem to get loaded for some reason, at least the values in it don't override anything.
Overrides seem to work perfectly with adding .env.development, so now it seems like .env.local implementation wasn't necessary at all? It looks like I couldn't find / understand the documentation. Unless there's an additional goal for flexibility with ignored .env.local committed .env.development combination.

Hmm, do you think another beta release could be tagged?

I guess this is outdated comment. I've tagged a few releases since.

Also, all composer commands now require WP_ENV=local prefix. Not perhaps the smoothest possible experience.

If you export WP_ENV env variables in several wyas... it depends on what you use.

.env.local doesn't seem to get loaded for some reason ... overrides seem to work perfectly with adding .env.development

That's strange. In the code there's nothing treating .env.local in a special way. This code: https://github.com/wecodemore/wpstarter/blob/dev/templates/wp-config.php#L61-L65 should work for local in the same way it does for development.

$envLoader->loadAppended("{{{ENV_FILE_NAME}}}.{$envType}", WPSTARTER_PATH); does work for incremental upgrades, so I think this issue can be closed.


SPI not working in of093 and RPi2

Hi tested the spi example with the connection to the adc3008 shown in the readme but i always get the error "Problem transmitting spi data..ioctl". I tried the button example and this is working fine.
Thanks in advance.

Hi, I will make a couple of quick questions, to understand the problem...

you have enabled SPI? There are many ways to do it, simple mode:
  raspi-config -> Advanced Option -> SPI

to have a confirmation on the operation of SPI do:
lsmod | grep bcm

you can make a photo at the cable connection?

since the last update and 'added a SPI2 class that I have not tested adc3008, you are using SPI or SPI2?

thanks for the tip :)

spi is already enabled

snd_bcm2835            20511  1
snd_pcm                75698  1 snd_bcm2835
snd                    51844  5 snd_bcm2835,snd_timer,snd_pcm
bcm2835_wdt             3225  0
bcm2835_gpiomem         3040  0
spi_bcm2835             7286  0

i am using spi, not spi2

3 pictures are in a few minutes

you can publish your program setup that contain the "new = SPI()" ?

#include "ofMain.h"
#include "ofAppNoWindow.h"
#include "ofxGPIO.h"
class noWin : public ofBaseApp{
public:
SPI * spi;
int i;
int a2dVal;
int a2dChannel;
unsigned char data[3];
	void setup(){
	        i = 20;
	        a2dVal = 0;
	        a2dChannel = 0;
	        spi = new SPI("/dev/spidev0.0", SPI_MODE_0, 1000000, 8);
	}

	void update(){
		data[0] = 1;
	        data[1] = 0b10000000 |( ((a2dChannel & 7) << 4));
	        data[2] = 0;

	        spi->spiWriteRead(data, sizeof(data) );
	        a2dVal = 0;
            	a2dVal = (data[1]<< 8) & 0b1100000000;
                a2dVal |=  (data[2] & 0xff);
    		sleep(2);
	        ofLog()<<"Result: " << a2dVal;
	}

};
int main( ){
ofAppNoWindow window;
ofSetupOpenGL(&window, 0,0, OF_WINDOW);
ofRunApp( new noWin() );
}

This is your spi example, which i am using.

you've tried to use interface: /dev/spidev0.1  ?

i tried now
spi = new SPI("/dev/spidev0.1", SPI_MODE_0, 1000000, 8);
but the same error.

I'm trying MCP3008 in the laboratory, short update you

ok the problem exists, but appears to be closely tied to 9.x of openFrameworks paired with a combination of reading from SPI.
In fact, if you try to run this example outside openFrameworks or with a version of openFrameworks < 9.x running fine.
I am attaching an example in C ++ to use without openFrameworks.
extract the zip file in the /home/pi/
cd mcp3008/
make
./main
mcp3008.zip
let me know if this example outside openFrameworks works for you.
in a while I try to figure out the problem, I leave this open.

wow, thank you for this example, this is working.

Have you solved this issue yet?

hello @xumo , I'm sorry I fix this in September I am now out for work.

Do you have any hints, I need deliver earlier? I'l try with OF 8.4, but cannot seem to find the release tar in the main site.
Thanks anyway, this is an awesome addons.

kit_mcp.zip
Hi @xumo
a simple solution without changing the version is to use the demon that you find in the zip writing in a socket are also an example openFrameworks to read socket.
Good day

Yei, thanks a lot.

Hi guys @urbanpixellab @xumo,
I think I've solved the problem with SPI.
good day

That's great. I'll test it as soon as I can.


Affiliations' colors aff_col

Hi!
The variable affiliation color (aff_col in villages_corr.csv) for aff = "Avar", has a value of  #9900ff in most of cases, but a few of them have its value as #9494b8 . This should be unified.
Just another comment, which is not wrong, but just comes from my obsessive nature. All values for color in this variable are in their hexadecimal representation, except for that for "Georgic", which is "black". Maybe replace it for "#000000", just out of consistence? :)

Finally fixed this, thanks for creating an issue!


pattern libraries are not discoverable

In most examples we have this import { signature } from "capi/patterns/signature/polkadot.ts" but with the published version of capi I cannot find signature import.
import { signature } from 'capi' --> Module '"capi"' has no exported member 'signature'.

Anything under "capi/patterns" cannot be discovered by intellisense.

In node,
import { signature } from "capi/patterns/signature/polkadot"

Looks like it does work but lacks discoverability.

This video shows what I mean by lack of discoverability
https://user-images.githubusercontent.com/21375952/234687404-3800e8e2-e809-422b-9127-d5ce0c4502fd.mp4

@ryanleecode are you sure this is Capi-specific, as opposed to a current limitation of TypeScript's LS implementation?

#54330


Make sure extraction does include values interpolated close to zero values

This code:
https://github.com/spinal-cord-7t/coil-qc-code/blob/83dfd087445fb045dad77d2320847ff4af5492f9/data_processing-phantom.ipynb#L399-L406
is problematic if the previous step registered qMRI maps that contain zero. Linear interpolation was used, which would under-estimate the qMRI values.
Two options to avoid this:

Use NN interpolation, and then extract metrics while ignoring zero values (eg could use a mask)
Do the extraction within the native space using the registered mask (not the other way around). Cons: the coordinate limits will be different for each site.

Option 1 is more preferable.

Checking for sub-MGH_acq-famp_TB1TFL:
sct_apply_transfo -i ../../sub-CRMBM/fmap/mask_spinalcord.nii.gz -d sub-MGH_acq-famp_TB1TFL.nii.gz -w warp_sub-CRMBM_acq-famp_TB1TFL2sub-MGH_acq-famp_TB1TFL.nii.gz -x linear

Looks fine (ie: no zeroed values):


Add uds.edu.py

@angoybu First stage of verification passed, official domain is uds.edu.py as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@angoybu Pull request merged. Thank you.


Better package management

Db, hashing, router and handlers should be in different packages, so they can be better tested & visualized.

WIP in branch package.

Solved on branch package


SOLR-16289: Null check in transformers of ltr module

https://issues.apache.org/jira/browse/SOLR-16289

Description
In SolrCloud (with enabled two-stage shard request), LTRInterleavingScoringQuery#getPickedInterleavingDocIds may be null. More details, see original JIRA ticket.
Solution
Add null check.
Tests
No tests are added yet. I ran the patched SolrCloud and checked that it works well.
Checklist
Please review the following and check all that apply:

[x] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
[x] I have created a Jira issue and added the issue ID to my pull request title.
[x] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
[x] I have developed this patch against the main branch.
[ ] I have run ./gradlew check.
[ ] I have added tests for my changes.
[ ] I have added documentation for the Reference Guide

Thanks for the patch!
Can you add a unit test demonstrating this failure? I think from there it will be easier to brainstorm a fuller solution in case you think the null check is insufficient.

Thanks for reviewing @madrob!
I added two unit tests to demonstrate the failure. I think it's not look good way to use DocTransformer that uses scoring informations in SolrCloud. I try to fix this problem with implementing SearchComponent, but it has became a very complicated implementation...

My bad, it seems this information is not in the documentation (I may have just put it in the original blog post telling the story of the contribution).
If these changes don't make sense anymore, we can just adapt this Pull Request to add the misisng piece in the documentation.

+1 to updating the documentation if the info isn't already in there (I haven't looked).
Though even if it's documented as unsupported then a null pointer exception in response to attempted use still to me would seem a poor user experience. I'd love to see both the documentation update and the avoidance of the NPE.

Yes, ideally I would like to see an exception saying "interleaving is not supported in SolrCloud", I don't have time now to work on that but the author of this PR could re-purpose it to that direction and I'll be happy to review!

+1
I agree with both to update documentation and to throw an exception. I will add these updates. However, I want to support interleaving in SolrCloud ideally.
My idea is,

Support the caching across multi-stage requests. This feature helps to pass interleaving results calculated by ResponseBuilder.STAGE_EXECUTE_QUERY stage to ResponseBuilder.STAGE_GET_FIELDS stage.
Customize MergeStrategy to merge interleaving results returned from each shard.

Please review these ways to fix this problem.


Deadlock bugfixes

Corrections for two deadlocks that could happen during exit.
This seems to fix all of my current atexit issues.

Hmm.. maybe spoke too soon.

Looking better.
@samuelgarcia, does this resolve atexit issues for you?

This truly improve the situation and this is so good!!
Thank you.


How to reject on acknowledge using messageObject callback argument

How can I requeue an acknowledged message using the 4th argument in a queue's subscribe callback? i.e.,
q.subscribe({ack: true}, (message, headers, info, messageObject) => {
    messageObject.acknowledge(true) // I want to requeue when I acknowledge(true) here
})

acknowledge doesn't appear to accept a second argument like queue.shift, so
messageObject.acknowledge(true, true) doesn't work. Adding requeue: true to the subscription options doesn't work either:
q.subscribe({ack: true, requeue: true}, (message, headers, info, messageObject) => {
    messageObject.acknowledge(true)
})

The documentation says not to call shift explicitly, so is there another way to accomplish this?
Thanks.

I figured it out. The messageObject also has a function called reject, to be used instead:
q.subscribe({ack: true}, (message, headers, info, messageObject) => {
    messageObject.reject(true) // Will put the message back into the queue
})


gofabric start doesn't work

Similarly, fabric8:cluster-start  yields:
[INFO] F8:gofabric8 Unable to get /Users/user/.fabric8/bin/minikube status, ========================================
In all instances where fabric8:* command is supposed to start minikube, minikube must be already running, otherwise the error above or similar will be throw.

Same on Mac OS X High Sierra 10.13.3 with the standard xhyve  driver.


Debug PLL for higher clock speeds on the FSM

Summary
PLL = phase-locked-loop, which is a circuit used to multiply clock speeds compared to a reference clock. In our context, the reference clock could either be the STM's internal 16MHz clock or our external 8MHz crystal oscillator.
For some reason the FSM would fault on clock configuration when PLL was enabled, with both external and internal clock. The FSM has identical hardware to all other boards (which use PLL with no problems), and we replaced the MCU so its probably not just a broken chip. This was never solved so currently the FSM uses the 16MHz internal clock (8MHz external was too slow if I remember correctly, was seeing watchdog trips).
Ideally we figure this out before we use the same clock circuit on new boards, especially since we'll be increasing our clock speeds for the VC.

Moved to Jira.


Travis update to dist: trusty

Looking at PR #6, the issue build issue appears to be the fact travis has upgrade the default distro and that now doesn't support the older java 7 required by the current build config.

FYI I'm only doing changes so travis builds master successfully.


ToyBox Breaks Seelah's Wedding Quest with an Ability Blueprint Error

Seelah's chapter 3 wedding quest sends you back to the main menu after talking with Arsinoe to start the ceremony.

I fixed a crash which I introduced in 1.3.15 when fixing the refill belt issue.  Please verify in the next release (either <IP_ADDRESS> or 1.3.16)

Fixed.


Running in ~20 sec, within an existent project

Description
Hi, some days ago I just discovered this awesome tool!
We used Webpack before now, and the main reason I was searching for something else
was the speed ...
Expected behavior
So, Reading docs I got impression the brunch should compile everything under ms.
Actual behavior
Actually, brunch build --production compiles in ~20 secs (20-25s)
Well it is really great comparing to webpack which did it in 2 mins.
If at all possible, please create a small demo app on GitHub that demonstrates the issue so it's easier for us to check and debug.
Environment

Brunch: 2.10.10
Node.js: 7.4.0
NPM: 4.1.1
Operating system: Ubuntu 16.04 LTS
Code editor: VIM

package.json contents
{
  "version": "1.0.0",
  "scripts": {
    "s": "brunch watch --server",
    "production": "brunch build --production",
    "postinstall": "sh -c 'if [ \"${NODE_ENV}\" = \"production\" ]; then yarn run production; fi'",
    "precommit:eslint": "git diff-index --cached HEAD --name-only --diff-filter ACMR | grep -E \"\\.jsx?$\" | xargs eslint --quiet"
  },
  "pre-commit": [
    "precommit:eslint"
  ],
  "dependencies": {
    "babel-brunch": "^6.1.1",
    "babel-plugin-transform-class-properties": "^6.24.1",
    "babel-plugin-transform-object-rest-spread": "^6.26.0",
    "babel-polyfill": "^6.26.0",
    "babel-preset-env": "^1.6.0",
    "babel-preset-react": "^6.24.1",
    "brunch": "^2.10.10",
    "classnames": "2.2.5",
    "fuse.js": "2.6.1",
    "history": "3.0.0",
    "immutable": "3.8.1",
    "jquery": "3.1.1",
    "json-loader": "0.5.4",
    "lodash": "4.17.4",
    "moment": "2.17.1",
    "moment-timezone": "0.5.11",
    "react": "15.3.0",
    "react-addons-shallow-compare": "15.3.0",
    "react-d3-cloud": "0.4.1",
    "react-datepicker": "0.37.0",
    "react-dates": "4.1.0",
    "react-dom": "15.3.0",
    "react-immutable-render-mixin": "0.9.7",
    "react-linkify": "0.1.3",
    "react-modal": "1.4.0",
    "react-notification-system": "0.2.7",
    "react-pagify": "2.0.4",
    "react-pagify-preset-bootstrap": "1.0.2",
    "react-redux": "4.4.5",
    "react-router": "3.0.0",
    "react-select": "1.0.0-rc.5",
    "react-tag-input": "4.6.2",
    "redux": "3.6.0",
    "redux-form": "6.2.0",
    "redux-logger": "2.7.0",
    "redux-thunk": "2.1.0",
    "seamless-immutable": "6.0.1",
    "underscore": "^1.8.3"
  },
  "devDependencies": {
    "babel-eslint": "7.1.0",
    "eslint": "3.9.0",
    "eslint-config-airbnb": "12.0.0",
    "eslint-loader": "1.6.1",
    "eslint-plugin-import": "1.16.0",
    "eslint-plugin-jsx-a11y": "2.2.3",
    "eslint-plugin-react": "6.4.1",
    "pre-commit": "1.2.2"
  }
}

brunch config contents
exports.paths = {
  public: 'public/javascripts/front',
  watched: ['front']
}

exports.files = {
  javascripts: {
    joinTo: {
      'application.js': /^front/,
      'vendor.js': /^(?!front)/,
    }
  }
}

exports.plugins = {
  babel: {
    presets: [
      'react',
      [
        'env',
        {
          useBuiltIns: true,
        }
      ],
    ],
    plugins: ['transform-class-properties', 'transform-object-rest-spread'],
    ignore: [/^node_modules/]
  }
}

exports.notifications = false;

OVERVIEW
Is it possible to make it faster (maybe I have something wrong in configs)?
or that's the limit of brunch?

I forgot to say, thank you!
The tool you built is so easy to use & fast :clinking_glasses:

some output from compilation (if that could help):
webpack:
> NODE_ENV=production webpack --config webpack.production.js

(node:403) DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see https://github.com/webpack/loader-utils/issues/56
parseQuery() will be replaced with getOptions() in the next major version of loader-utils.
Hash: 9c37f06896e2b62306fe
Version: webpack 2.4.1
Time: 128701ms
                                            Asset     Size  Chunks                    Chunk Names
       application.bundle-9c37f06896e2b62306fe.js  2.11 MB       0  [emitted]  [big]  application
             admin.bundle-9c37f06896e2b62306fe.js   331 kB       1  [emitted]  [big]  admin
   application.bundle-9c37f06896e2b62306fe.js.map  13.8 MB       0  [emitted]         application
         admin.bundle-9c37f06896e2b62306fe.js.map  2.95 MB       1  [emitted]         admin
          admin.bundle-9c37f06896e2b62306fe.js.gz  98.9 kB          [emitted]
    application.bundle-9c37f06896e2b62306fe.js.gz   522 kB          [emitted]  [big]
      admin.bundle-9c37f06896e2b62306fe.js.map.gz   692 kB          [emitted]  [big]
application.bundle-9c37f06896e2b62306fe.js.map.gz  2.91 MB          [emitted]  [big]
   [0] ../~/react/react.js 56 bytes {0} {1} [built]
  [57] ../~/react-dom/index.js 63 bytes {0} {1} [built]
 [100] ./redux/store.js 3.38 kB {0} [built]
 [105] ../~/webpack/buildin/global.js 509 bytes {0} {1} [built]
 [142] ../~/react-modal/lib/index.js 49 bytes {0} [built]
 [250] ./utils/render-react-instance.js 605 bytes {0} {1} [built]
 [334] ../~/babel-polyfill/lib/index.js 833 bytes {0} {1} [built]
 [379] ./utils/render-react-component.js 606 bytes {0} {1} [built]
 [386] ../~/core-js/fn/regexp/escape.js 108 bytes {0} {1} [built]
 [621] ../~/core-js/shim.js 8.18 kB {0} {1} [built]
 [769] ../~/regenerator-runtime/runtime.js 24.4 kB {0} {1} [built]
 [936] ./admin.js 1.38 kB {1} [built]
 [937] ./application.js 6.91 kB {0} [built]
[1603] multi babel-polyfill ./admin.js 40 bytes {1} [built]
[1604] multi babel-polyfill ./application.js 40 bytes {0} [built]
    + 1590 hidden modules

real    2m9.845s
user    2m15.568s
sys     0m1.828s

Brunch (really does a great job):
yarn production v0.27.5
$ brunch build --production
21:22:17 - info: compiling
21:22:21 - info: compiling.
21:22:27 - info: compiling..
21:22:31 - info: compiling...
21:22:34 - info: compiled 1034 files into 2 files in 21.4 sec
Done in 21.56s.

real    0m21.741s
user    0m21.960s
sys     0m2.024s

Hey @BreahnaDavid, I don't really see how you can make build faster by changing config (you already use babel-preset-env, 🙇 ).
However, there is slowdown on our side: see https://github.com/brunch/brunch/issues/1725.
With workers, Brunch could build application.js and vendor.js in parallel and it will result in faster build times. Workers are back in #1664.

Wow, thank you!
I'll take a look once the PR is merged :+1:
I made same changes to webpack config and I got 20s in development build in 50 in production,
the difference is really big in favor of brunch!
Great Job!


Wrong Component isValid state

Component did not update state if required field was changed in runtime.
Like that
getInitialState() {
  return {isRequired: false}
}

onChange(val) {
  this.setState({isRequired: val})  //val === true
}

render() {
...
<MyComponent name='myC' required={this.state.isRequired}>
<Tooge onChange={this.onChange} value={this.state.isRequired} />
...
}

This is not taken into account, but should. Might get into tomorrows release or most certainly the next after that :-)

Okay, this is now fixed for next release. Both validations and required can be changed at runtime and instantly a new validation check will be run. Thanks for the tip!


Use validate_utf8: false flag for Reporting and Audit JSON POSTs

This will eliminate invalid UTF8 barfs at the end of runs.
This has already been done for node.save
The main chef-client rest object probably still wants utf8 validation and strictness by default, so we need to create new rest objects for reporting+audit and turn off the strictness.
This will still render valid UTF8 to the server endpoints, it will just scrub invalid UTF8 to '?' characters.

This may close #1468

at some point this clearly got done.


clickhouse AttributeError: 'ToFixedString' object has no attribute

issue 320

Coverage increased (+0.003%) to 97.473% when pulling fa9462b2b4c0793c0b54661bdda414fa23bbef4c on d-ganchar:feature/CH_support into 20393871e0445e4fc405ff3b4d9ef01ead7d27ba on kayak:master.


Const members of an enum

I have the following code (playground link):
pub enum Mode {
    A,
    B,
    C
}

pub const MY_MODE: Mode = Mode::A;

This gives me the following error message:
error: expression has mode spec, expected mode exec
  --> /playground/src/main.rs:11:27
   |
11 | pub const MY_MODE: Mode = Mode::A;
   |                           ^^^^^^^

I am confused by this error message. Why is Mode::A inferred to have mode spec here? My understanding was that after #843, constant declarations should be dual-mode exec and spec.
(Not sure if this is an actual bug in Verus or there's just some syntax I am missing!)

Try pub exec const instead.
This may be a syntax inconsistency we may want to fix (in functions, exec is the default).

Thank you! Yes, it works with a pub exec const. Ideally, however, I'd prefer to have the dual-mode functionality, since I use this constant in both spec contexts and in exec contexts. This works using just pub const when the const is a usize (link), but not when it is an enum member (link). Since I'm generating the code it's easier not to have to differentiate between whether the constant is being emitted for spec or exec contexts, if it's possible to do so in Verus.

related (but slightly different): https://github.com/verus-lang/verus/issues/861

Ah I see. Right, makes sense. This is indeed probably a bug (or a missing part of a feature). The bug @tjhance refers to is indeed likely another symptom of the same cause (thanks for looking it up!).

A workaround for having the same const in spec and exec but not being able to declare it using the syntax above is to use when_used_as_spec, as follows:
pub spec const SPEC_FOO: Mode = Mode::A;

#[verifier::when_used_as_spec(SPEC_FOO)]
pub exec const FOO: Mode ensures FOO == SPEC_FOO { Mode::A }

...

Full playground link
Not sure if this is intended functionality, but it seems to work for me, in case it turns out that having the dual-mode functionality is unsound in some way.


TabNavigator example should include full implementation example

It took a lot of googling, before I figure out that TabNavigator is not a router like StackNavigator.
This should be made clear with the example and perhaps with a special mention in the documentation.
The Tab Navigator in general seems to have a lot of gotchyas.

My frustrating was misplaced.
I didn't realize the navigator loads EVERY component from the router, so they all need to be valid.
Some of my components were incomplete contributing to my whole app not working.
I really wish the error messages in react-native weren't so awful...


not is not defined in not(boolean) without a space after it

If I start off with a Boolean condition (this is in a return statement which is where I came across it, but it happens anywhere else a Boolean expression is being written)

and then realise it's the inverse of the first term and I need a not  in front, I type not and get this

The fix is  to have a space after the not but this is a bit confusing. Typing and or or inserts the spaces around the operator automatically.

This might be quite hard to fix.  The problem is typing not in front of the open brackets means that it is being interpreted as a function. I can't immediately see a way around this issue. How does it know that you meant:
not (1 > 2)
and not that this was an incomplete function name.
The only thing that surprises me here is that I would have expected a message something like:
'not' cannot be a function name because it is a keyword
So, I'll keep this in, but as a low-priority issue.

That's what you get if you try to define a function:
[image: image.png]
but not until you've filled in the return frame.
All the best.
John
Sent from (one of):
one of my Raspberry Pi computers
the Android phone or tablet
the Windows desktop
one of the Windows laptops/notebooks/tablets
one of the Macbook Airs
the iPad Pro or even
the LG TV!
On Fri, 9 Aug 2024 at 14:53, Richard Pawson @.***>
wrote:

This might be quite hard to fix. The problem is typing not in front of the
open brackets means that it is being interpreted as a function. I can't
immediately see a way around this issue. How does it know that you meant:
not (1 > 2)
and not that this was an incomplete function name.
The only thing that surprises me here is that I would have expected a
message something like:
'not' cannot be a function name because it is a keyword
So, I'll keep this in, but as a low-priority issue.
—
Reply to this email directly, view it on GitHub
https://github.com/elan-language/LanguageAndIDE/issues/688#issuecomment-2277998496,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQQAB6CAAHMQVFP6JME6M3ZQTCXDAVCNFSM6AAAAABMIM4NLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZXHE4TQNBZGY
.
You are receiving this because you authored the thread.Message ID:
@.***>