Code style wishlist

A few ideas, all open to discussion

[ ] in *.cpp files, everything inside sfz namespace, instead of repeating sfz:: everywhere
ie. namespace sfz { [...] } // namespace sfz
[ ] instance variables with _ suffix, to make it evident when we're deferencing this
[ ] fix the space/tab mix in Defaults.h
[ ] rewrite all doc comments in a consistent way

/**
 * @brief A good doc comment
 */
/**
   @brief A bad doc comment
 */

[ ] cpp files should preferably not include other cpp files (with possible exception of faust-generated ones)
eg. #include "ADSREnvelope.cpp" in FloatEnvelopes.cpp

Sorry, I "edited" it by mistake but not changed anything, like a "I'm a simple man, I see a checkbox and I select it." :-P
If I can put my cent on it that sounds like the way I use to code except:

the _ suffix, which I agree but still about personal taste (e.g. also as prefix or m_ prefixed
I like the bad doc comment and I never understand why automatic Doxygen editors puts all those unneeded asterisks where starting with an indentation looks more clean and readable to me, but this is also (my) personal taste

Despite the 2 personal points above all of that makes sense to me.

I'm okay with all this, I have no strong opinions. I tend to prefix with _ in python but I'm flexible :)
I also think we could pimpl everything if you wish. One thing that we may discuss is the Impl& impl = *impl_; that you put in the parent calls: what's the reason?

I tend to prefix with _

The prefix _ is reserved for compilers.

what's the reason?

It's for no other reason than to help the compiler, writing such a this as impl_->x dereferences twice.

Added an item regarding the include file order, see the top comment


UCP module core dump

Hello, I just installed docker-freepbx and I have a core dump file every 10 minutes:
/data/www/admin/modules/ucp/node

....
41228 -rw-------   1 2600 2600 122691584 Apr  1 09:14 core.8091
40372 -rw-------   1 2600 2600 123117568 Apr  1 09:24 core.9405
41960 -rw-------   1 2600 2600 122707968 Apr  1 09:34 core.10625
43616 -rw-------   1 2600 2600 122699776 Apr  1 09:44 core.11846

And these logs (/var/log/asterisk/ucp_error.log):
2021-04-01 09:14 +02:00: node /var/www/html/admin/modules/ucp/node/index.js: ../src/binding.cc:992: static void Client::cb_poll(uv_poll_t*, int, int): Assertion `status == 0' failed.
2021-04-01 09:24 +02:00: node /var/www/html/admin/modules/ucp/node/index.js: ../src/binding.cc:992: static void Client::cb_poll(uv_poll_t*, int, int): Assertion `status == 0' failed.
2021-04-01 09:34 +02:00: node /var/www/html/admin/modules/ucp/node/index.js: ../src/binding.cc:992: static void Client::cb_poll(uv_poll_t*, int, int): Assertion `status == 0' failed.
2021-04-01 09:44 +02:00: node /var/www/html/admin/modules/ucp/node/index.js: ../src/binding.cc:992: static void Client::cb_poll(uv_poll_t*, int, int): Assertion `status == 0' failed.

I'm using provided docker-compose file and CentOS 7  OS with Docker version 20.10.5.
The problem looks like this one https://community.freepbx.org/t/ucp-wont-allow-login-screen/72307/2 but I can't find a solution.
I'm not sure is a docker-freepbx or freepbx problem. Anyone Knows howto solve the problem?

I'm seeing the exact same thing. CentOS 7. Docker 20.10.6
My sanitized docker-compose.yml. Excuse the formatting I tried doing a code block but it didn't like it.
version: '2'
services:
freepbx-app:
container_name: freepbx-app
image: tiredofit/freepbx
ports:
#### If you aren't using a reverse proxy
#- 80:80
#### If you want SSL Support and not using a reverse proxy
#- 443:443
- 5060:5060/udp
- 5160:5160/udp
- 18000-18100:18000-18100/udp
#### Flash Operator Panel
- 4445:4445
volumes:
- ./certs:/certs
- ./data:/data
- ./logs:/var/log
- ./data/www:/var/www/html
### Only Enable this option below if you set DB_EMBEDDED=TRUE
#- ./db:/var/lib/mysql
### You can drop custom files overtop of the image if you have made modifications to modules/css/whatever - Use with care
#- ./assets/custom:/assets/custom
environment:
  - VIRTUAL_HOST=pbx.domainname.org
  - VIRTUAL_NETWORK=nginx-proxy
 ### If you want to connect to the SSL Enabled Container
  - VIRTUAL_PORT=443
  - VIRTUAL_PROTO=http
  - VIRTUAL_PORT=80
 # - LETSENCRYPT_HOST=pbx.domainname.org
 # -<EMAIL_ADDRESS>  - ENABLE_SMTP=TRUE
  -<EMAIL_ADDRESS>  - SMTP_HOST=postfix-relay
  - SMTP_PORT=25
  - SMTP_DOMAIN=domainname.org
  - SMTP_MAILDOMAIN=local
  - SMTP_AUTHENTICATION=off
  - SMTP_TLS=off
  - SMTP_STARTTLS=off
  - SMTP_TLSCERTCHECK=off

  - ZABBIX_HOSTNAME=freepbx-app

  - RTP_START=18000
  - RTP_FINISH=18100

 ## Use for External MySQL Server
  - DB_EMBEDDED=FALSE

 ### These are only necessary if DB_EMBEDDED=FALSE
  - DB_HOST=freepbx-db
  - DB_PORT=3306
  - DB_NAME=asterisk
  - DB_USER=asterisk
  - DB_PASS=<mysqlpass>

 ### If you are using TLS Support for Apache to listen on 443 in the container drop them in /certs and set these:
 #- TLS_CERT=cert.pem
 #- TLS_KEY=key.pem

restart: always
networks:
  - proxy-tier

### These final lines are for Fail2ban. If you don't want, comment and also add ENABLE_FAIL2BAN=FALSE to your environment
cap_add:
  - NET_ADMIN
privileged: true

freepbx-db:
container_name: freepbx-db
image: tiredofit/mariadb
restart: always
volumes:
- ./db:/var/lib/mysql
environment:
- MYSQL_ROOT_PASSWORD=
- MYSQL_DATABASE=asterisk
- MYSQL_USER=asterisk
- MYSQL_PASSWORD=
networks:
- proxy-tier
freepbx-db-backup:
container_name: freepbx-db-backup
image: tiredofit/db-backup
links:
- freepbx-db
volumes:
- ./dbbackup:/backup
environment:
- ZABBIX_HOSTNAME=freepbx-db-backup
- DB_HOST=freepbx-db
- DB_TYPE=mariadb
- DB_NAME=asterisk
- DB_USER=asterisk
- DB_PASS=
- DB_DUMP_FREQ=1440
- DB_DUMP_BEGIN=0000
- DB_CLEANUP_TIME=8640
- COMPRESSION=BZ
- MD5=TRUE
networks:
- proxy-tier
restart: always
services are named in docker ps by this name
proxy:
# this points to whatever image you want
image: nginxproxy/nginx-proxy
# mapping these ports as such as my developement machine already has an HTTP server on these ports.
# In production these will be 80:80 and 443:443
ports:
- "8080:80"
- "4443:443"
# this maps the socket over which all docker communication happens into the container so it can watch the host env
volumes:
- "/var/run/docker.sock:/tmp/docker.sock:ro"
# This is for the setting client_max_body_size 200m; Otherwise nginx chokes uploading custom .wav to freepbx for IVRs.
- "./my_custom_proxy_settings.conf:/etc/nginx/conf.d/my_custom_proxy_settings.conf"
# docker supports arbitrary mini-SDNs, this just puts this image on this NW
networks:
- proxy-tier
postfix-relay:
container_name: postfix-relay
image: freinet/postfix-relay
restart: always
environment:
- MAILNAME=smtp.domainname.org
- MYNETWORKS=<IP_ADDRESS>/0
- LOGOUTPUT=/var/log/maillog
- SIZELIMIT=10000000
networks:
- proxy-tier
networks:
proxy-tier:
external:
name: nginx-proxy


[util] Add a workaround for Soldiers: Heroes of WWII

It used to work without tinkering before, however it may have been an unintended consequence of us not properly freeing state blocks. The game is all manners of broken anyway (unrelated to d3d) and was unplayable on Wine until recently, so the fact it needs this is not all that surprising.

Will consolidate in an upcoming PR.


Adjust the Add New menu drop-down so it uses context from the current page

For example, when viewing a facility, it should use that Facility ID when adding a new item.

The Add New menu item was removed from the menu bar and moved into the relevant data pages where it is already context-specific.


Ensure /sbin/init is a symlink to systemd

This only seems to affect the systemd-debian:9 image.

Thanks @jimeh , sorry not to have responded earlier!
Several questions:

why does it affects only Debian 9?
can it be rather solved by using a package?
there is no need for a condition if it always affects the image

Sorry, what is the issue by not having /sbin/init?

@j8r sorry for the rather lacking explanation. I ran into issues when using your various systemd images in the test suite of my ansible-adguardhome role. I ended doing a similar hack here as to what I had originally submitted in this PR.
Without it Ansible's service_mgr module kept not correctly detecting the init system as being systemd.
And having a look now, I noticed that installing the systemd-sysv package creates the /sbin/init symlink, so I've rebased the PR and modified it to do that instead of manually creating the symlink :)

Great @jimeh , looks good to me! Is it possible to have also this fix on other Debian and Ubuntu images. They have likely this same issue, with the same easy fix to do :).

I've just had a deeper look, and it seems to affect Debian 9 and 11, and Ubuntu 20.04. So I'm happy to do the same change against those images, or just do it against all debian/ubuntu images, as the others already have the systemd-sysv package installed, it shouldn't cause any harm :)
What do you prefer?

Ok, let's have it everywhere then :+1:
It can also be useful when using legacy sysVinit scripts.

All done :)

Love it, thank you @jimeh !

No worries, I'm happy to help. And thank you for building these images in the first place. Without them I would have needed to build similar images myself to be able to test that my Ansible role can actually configure and run a systemd services :)


Go indexer: Ensure anchors share a vname with their file. [phab:D1319]

Created by fromberger at 2017-02-08 22:52:00:
Extends the treatment of #1700 to cover anchors as well.

zarko accepted this revision at 2017-02-08 23:13:40

fromberger closed via commit c62cfdccedf8f93c0765cef1bb8151352d0686cd at 2017-02-08 23:15:00


using Pulse Sensor with RFDuino/Simblee

Will not work after replacing timing code to work with an ARM Cortex M0 by replacing timer with delay().
(Will be running this off of battery later)
Photo: http://files.gandi.ws/gandi70414/image/img_20160406_111909.jpg
Timer_Interrupt_Notes.txt
AllSerialHandling.txt
Interrupt.txt
PulseSensorAmped_Arduino_1dot4.txt

In your Interrupt.ino file you are trying to do a Serial.print every sample (500Hz!)
Instead, try using a modulo on the sample counter or something to dial that down.
Maybe that will help?

Still doesn't work only sending ever 20ms or 40ms

You are using the SerialOutput() function? Could that be doing something?

wave form for Serial.print every 50 ms
View post on imgur.com

i moved it to after the function that looks for heart rate, but it still doesn't work

I'll have time to set this up on my own simblee tomorrow and we'll figure it out

Awesome thanks!

Ok, it looks like I've found your problem. At least with your latest version on the git.
You have a delay(20); in there from my original code. That was causing the software to not find any heartbeats. I took that out, and also made a couple of adjustments and have it working on Simblee with our Processing visualizer! Yay!
I forked your code, and made changes here
https://github.com/biomurph/SimbleeArduinoCode
It uses a millis() timer to send serial data, and a micros() timer to sample the sensor.
Cheers

Thank you so much!


Add mpeg_aac_decoder example

Adds an example (as discussed in #42) which:

Reads aac content from an mpeg container
Decoding it to PCM using fdk-aac crate
Plays it using rodio

Not sure why alsa-sys is failing to build, it works fine for me on macOS

Not sure why alsa-sys is failing to build, it works fine for me on macOS

Ah, seems like a platform specific thing. The libasound2 is missing on the Travis build. I'll check into this.

Ok, I have an idea. Since this is a platform-specific example, can we wrap this into it's own crate within the examples directory? This way it can run separately from the other examples with its own dependencies and won't affect cargo test in the parent.

Made it into it's own package, and renamed the audio

Thanks!


Watch stop working in atom 1.14.3 ia32 version

After update watch stop working

What is your config setting for watch and what OS version are you on?

Going to close this as a dupe of #706 just to keep troubleshooting in one thread


Readme URL Entry

Do we have to add anything to the URL entry on Readme?

You can leave the URL entry blank if you push the video visualization files to your repo following ReadMe.
In case your visualization files have a large size and cannot be pushed to your repo, you can upload the videos to other platforms and put URL links.

Ok thank you so much for the clarification.


BadFormatException on ConsoleDriver.Run()

I made a simple C# project using the CppSharp nuget package v0.7.9.  When I run the project in debug mode I get BadFormatException for CppSharp.Parser.CLI on line "ConsoleDriver.Run(new SampleLibrary());".  How can I resolve this?
My lib file is 32 bit and I am using Windows 10 x64. The C# project is using AnyCPU with 32 bit preferred.

Please turn "32-bit preferred" off, it means the compiled executable is 32-bit which cannot work with the NuGet version of C++#.

With 32-bit preferred off, I am now getting FileNotFoundException:
Could not load file or assembly 'CppSharp.Parser.CLI.dll' or one of its dependencies.

Please ensure CppSharp.CppParser.dll is located next to your executable. If you install the NuGet on your executable, it will work too.

Hmm, both CppSharp.CppParser.dll is there as well as CppSharp.Parse.CLI.dll. I imagine the Nuget package installed all the dlls properly with the executables.
I get the same error with your CppSharp.Parser.Gen.exe app that I downloaded from https://github.com/mono/CppSharp/releases/tag/CppSharp

Please do not mix the binaries like that. The C++# at the link you posted is 32-bit, the NuGet is 64-bit.

This is all tested separately. I'm not mixing the binaries.
I'm just getting this same error both with my app using the NuGet, as well as your app from the link in a completely separate folder.

I understand. I am afraid, though, that I cannot tell what the problem is. The only idea I have at the moment is for you to download http://www.dependencywalker.com/ , open CppSharp.Parser.CLI.dll and check its bitness and dependencies.

Ok, here's an image of what's missing. Do you have any ideas about what I need here?
http://imgur.com/a/Q5AjM

What Visual Studio version are running?
It looks like you're missing some up-to-date C library DLLs that are usually distributed with VS.

@Ryder25 I assume you do not use VS 2015. In this case please install https://www.microsoft.com/en-us/download/details.aspx?id=53840 and try again.

Yes you are right. I just installed that package, and my app started working. Thanks!
Now when I run it, I am only getting an Std.cs file.
I created a Project1.lib static library, with the header file Foo.h:
`#pragma once
class Foo
{
public:
int a;
float b;

};
int FooAdd(Foo* foo);`
Here is my SampleLibrary class:
`    class SampleLibrary : ILibrary
{
public void Setup(Driver driver)
{
var options = driver.Options;
options.GeneratorKind = GeneratorKind.CSharp;
options.LibraryName = "Sample";
options.Headers.Add(@"Foo.h");
options.Libraries.Add(@"Project1.lib");
}
    public void Postprocess(Driver driver, CppSharp.AST.ASTContext ctx)
    {

    }

    public void Preprocess(Driver driver, CppSharp.AST.ASTContext ctx)
    {

    }

    public void SetupPasses(Driver driver)
    {

    }
}`

I made sure that the header file, and lib file are in the directory with my exe. What am I doing wrong?

You need the paths to your headers and libs too.

You can try to set driver.Diagnostics.Level = DiagnosticKind.Debug; before generation and see if any of the diagnostic output helps you find the issue.

ddobrev, you are right. I don't know why I thought the file names would be enough.
Thanks for your help, and tips!


[rtl8710bn] linux build fix

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Junjie Cai seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Authenticate iNat import

Authenticate iNat imports with iNat API Key and user handshake.
For details and documentation see https://github.com/MushroomObserver/mushroom-observer/issues/1955#issuecomment-2016029239
Tasks

[ ] Review Authentication (How to get authentication to retrieve iNat private data.)
[ ] Create iNat application

[ ] Need Redirect URI -- an MO uri to which iNat redirects when the user authorizes MO. Id.

[ ] Add iNat_login data to User/Account
[ ] Consider adding encoded iNat pw to User/Account

Completed

[x] >= 10 improving identifications in the last month
[x] Apply To Create iNat Application. NOTE: I think that page will not display a link to an application unless there are >= 10 improving identifications in the last month. "Improving identification" = "First suggestion of this taxon that the community subsequently agreed with." https://www.inaturalist.org/pages/help#identification

Pulk's Mirror. https://github.com/JacobPulk/mirror

rough outline:

you redirect your user to iNat,
the user is offered the choice to authorize your app with access to their iNat data, and
If they agree, they are redirected to the redirect_uri you specified with an access_token in the params.

https://www.inaturalist.org/pages/api+reference#authorization_code_flow

Questions:

How does MO associate the authentication with a particular iNatImport request?
What about require rest_client see https://www.inaturalist.org/pages/api+reference#authorization_code_flow

params in the callback action
If iNat user approves the request:
(rdbg) params
#<ActionController::Parameters {"code"=>"NtX2QvCzQuwXAyKL0uDtvZLcWDLQpo4i5QWkAtTMT1g", "controller"=>"observations/inat_imports", "action"=>"auth"} permitted: false>

If iNat user denies the request:
(rdbg) params
#<ActionController::Parameters {"error"=>"access_denied", "error_description"=>"The resource owner or authorization server denied the request.", "controller"=>"observations/inat_imports", "action"=>"auth"} permitted: false>

How to proceed after receiving code from iNat at the callback url?
@nwilson-eol's suggestion:

(earlier) in InatImport#create create an InatImport model object with a status attribute

status would be things like requesting_authorization request_token, etc.

When iNat hits the redirect url, User.current should be the same. So we can figure out which MO user it is (and other stuff, e.g., iNat Observation ids that are stored with the InatImport object for that user.
update the status,
get the token, store it with the InatImport object
proceed with the import, making the iNat API requests as shown in https://www.inaturalist.org/pages/api+reference#authorization_code_flow

20240719 0720 Pacific
Not working as expected as of #29809c667b67d86d13445496aa4d59333f8f2a2
Update API request to === iNat docs

- fixes headers
- uses RestClient instead of Httparty
See https://www.inaturalist.org/pages/api+reference#authorization_code_flow

The response does not include private location.
Probably because authentication isn't working. But there's a slim chance that iNat doesn't include private location even if the request is authenticated.
But I tried setting a breakpoint in inat_search_observations right after ::Inat.new ...
then manually
RestClient.get("#{API_BASE}/users/me", headers)
RestClient::Unauthorized: 401 Unauthorized
	from /Users/joe/mushroom-observer/app/classes/inat.rb:15:in `initialize'

I don't understand this. But I've been stuck on this a while.
So I'll put it aside for the moment, and work on things that depend on authentication.

Link to an old iNat app that imported MO Observations:
https://www.inaturalist.org/posts/20053-18-mushroom-observer-api-key

I may have done this substantially incorrectly. Upon re-reading the iNat docs for the nth time, it appears I'm using the wrong iNat url for authenticated requests.

All of these endpoints should use https://www.inaturalist.org as the base URL, particularly endpoints that require auth.
https://www.inaturalist.org/pages/api+reference#get-observations


docs: copy from

close #234

@fengjiachun Please fix them.

@evenyag  PTAL

Please fix them.

COPY FROM is not tested yet. @killme2008 Let's keep this and merge it after we ensure it works.

@xtang  PTAL

@fengjiachun review done, please take a look

@xtang resolved, PTAL


a few bugs i see

On the account page it isnt showing the icons , have added the token via admin , and shows icon in admin area but on front end nothing in the space for it except a capital E
Also the only coins that it is showing to trade is BTC and ETH, not showing BNB or anything else

i seen on the swap site it was showing BNB, are any BEP20 tokens able to trade??
I believe i have the latest Plugin version: 1.1.1054 | Build version: 41b0d8 | Updated: 19h : 02m : 09s ago.

Hi when might we see update for these things??

@LogicDEX if something wrong, please reopen this issue


Abbreviations are not keyboard friendly

It would be really nice if the Abbreviations extension would generate keyboard friendly code, e.g. instead of:
title="Cascading Style Sheets">CSS
it would be much nicer to produce:
title="Cascading Style Sheets" tabindex="0">CSS
This way it would be possible to focus on the abbreviation using keyboard (or any other input device that moves focus).
Of course, the best implementation should allow to enable this conditionally (not everyone likes their focus flow to be unexpectedly modified by inserting abbreviations into it).  I think the following definition (which is in line with other implementations of extendable markdown syntax) would be sufficient:
*[CSS]{tabindex=0}: Cascading Style Sheets (basically, I am proposing to borrow the idea from how Markdown handles images and allows authors to specify classes and attributes for the generated tags)

Interesting. So I suppose this is an accessibility issue which means we shouldn't ignore it. How is this generally handled in HTML? I don't want to be reinventing the wheel here. I'd like to see some existing solutions.

According to my research the majority of websites who are concerned about accessibility are using the following:

for desktop browsers where a pointer with ":hover" capability is present the standard  tag works fine
for screen readers the title attribute of the  element is read out after the content of the tag
for touch devices with no ":hover" capability the following block is enough to make  work on tap (I am not providing additional styling to make it nice):

abbr[title]:hover::after {
    content: attr(title);
    position: absolute;
}

the only accessibility issue with the current state of the  tag in Python Markdown is that it is not possible for keyboard users to get to the title attribute by any means -- they cannot focus on the element since to do so the element is supposed to have the taborder attribute to be non-negative (usually, one should use tabindex="0" to ensure that the element is inserted into the focus flow according to the layout.

The last item on this list is why I raised the issue, but when I thought about it, I think that if we are implementing something like this it should be a bit more generic, hence I proposed to re-use the way how the images I handled, i.e. *[ABBRV]{tabindex="0"}: Description of the abbreviation.
Hope this helps.

The reason why the touch devices need the @media query is to ensure that on any other device with the pointer that has the ":hover" capability a user won't be presented with two tooltips (one is generated by the browser and another defined by the stylesheet).  Since on touch devices there are no tooltips for  we generate one using CSS.

When I asked this:

How is this generally handled in HTML? I don't want to be reinventing the wheel here. I'd like to see some existing solutions.

I meant: please point me to other places where this solutions being used. Or point me to other solutions which are being used elsewhere. In other words, are other people solving this with tab index or are they using some other solution? I want to see links to real world examples. Not just an explanation of how you believe it should work, which was already sufficiently clear to me.

proposed to re-use the way how the images I handled,

I'm assuming you are referring to the attr_list extension. That is certainly a reasonable solution, but then that should work only when the attr_list extension is enabled by the user. In fact, that does already work:
>>> import markdown
>>> scr = '''
... Some text ABBR{ tabindex='0' } more text.
...
... *[ABBR]: Abbreviations
... '''
>>> markdown.markdown(scr, extensions=['abbr', 'attr_list'])
'
Some text ABBR more text.
'

Actually, that makes more sense that setting the tab index on the reference. As a reminder, you can have the same abbreviation repeated multiple times in a document. They can't all have the same tab index. By defining the tab index in the body of the document rather than the reference, you can set the tab index where it makes the most sense (perhaps on the first occurrence).

First of all, I believe the best practice is actually only use the same tabindex="0" for focusable elements, this is from Google best practices: https://web.dev/tabindex/
Well, the links I can point to are:

https://bitsofco.de/making-abbr-work-for-touchscreen-keyboard-mouse/ (but the same author revised the approach in 2019 - https://bitsofco.de/revisiting-the-abbr-element/)
https://webaim.org/discussion/mail_thread?thread=6901 (a thread on keyboard only users)
https://www.24a11y.com/2017/the-trials-and-tribulations-of-the-title-attribute/ (on whether tabindex for titles are good or bad)

Anyway, I think we can close the issue since what I wanted to achieve can be implemented (as you rightfully pointed out) with the attr_list extension.


net: shell: add conn_mgr shell commands

Add shell commands to controll conn_mgr

Automated tests and docs for this shell addition will be a separate task, but it does pass manual testing

@jukkar This is, I think, ready for merge (once it has your approval), but Robert is OOO, do you know who I should contact to move forward with merge?


Finetune on 3D dataset

Hi,
I would like to finetune a model on my dataset. The tutorials to do so seems to be for 2D images.
Are you planning to include also those for 3D?
Thanks

The high-level steps are basically the same as those for 2D images, so you still need to do the basic steps, though the details might be different. We did not update it for 3D because currently, we have not find a good example for fine-tuning.

A possibility could be to get the Scannet model and finetune on SunRGBD.
Would that work?

We have not tried that, you could have a try.

Without an accurate I think it'll be quite challenging...

I got the same problem, the high level is the same, but so much detail make it much harder.
Hope someone could write the guild for custom dataset tutorial.


human ortholog not displaying

compara_orths.tsv
SPAC3F10.17   HGNC21171
Can you figure why? The ID is correct. I don't see anything in the logs.

SPAC3F10.17 HGNC21171

I can't see that one in compara_orths.tsv.  This is the only ortholog for SPAC3F10.17:
SPAC3F10.17        HGNC:21173

I just did an svn update to check.

Doh, I was looking at  http://paint.pombase.kmr.nz/gene/SPAC3F10.17
then I got the ID wrong...


bump sts to bring in the data type handling changes

the only commit included in this version: https://github.com/microsoft/sqltoolsservice/commit/995e9baeab26c23220d3e4ab9a06fe288ff4ebaf
this PR fixes: #275

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 48.175%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/common/ports.ts
4
74.14%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
14516

Relevant Lines:
28627

💛  - Coveralls


CancelToken.cancel should NOT return an exception when there's no current request.

Package
dio
Version
5.1.0
Output of flutter doctor -v
[√] Flutter (Channel stable, 3.7.8, on Microsoft Windows [version 10.0.22621.1413], locale fr-FR)
    • Flutter version 3.7.8 on channel stable at C:\Users\remy\Documents\dev\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 90c64ed42b (6 days ago), 2023-03-21 11:27:08 -0500
    • Engine revision 9aa7816315
    • Dart version 2.19.5
    • DevTools version 2.20.1

[X] Windows Version (Unable to confirm if installed Windows version is 10 or greater)

[√] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at C:\Users\remy\AppData\Local\Android\sdk
    • Platform android-33, build-tools 33.0.1
    • Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • CHROME_EXECUTABLE = C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2022 17.5.1)
    • Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
    • Visual Studio Community 2022 version 17.5.33424.131
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 2022.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-9505619)

[√] IntelliJ IDEA Community Edition (version 2022.3)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart

[√] VS Code (version 1.76.2)
    • VS Code at C:\Users\remy\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.60.0

[√] Connected device (3 available)
    • Windows (desktop) • windows • windows-x64    • Microsoft Windows [version 10.0.22621.1413]
    • Chrome (web)      • chrome  • web-javascript • unknown
    • Edge (web)        • edge    • web-javascript • Microsoft Edge 110.0.1587.63

[√] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Dart Version
2.19.5
Steps to Reproduce

Call CancelToken.cancel alone.
StateError is thrown

Expected Result
Since CancelToken is dissociated from the request, if there's no current request when calling cancel, this method should return without providing error.
We still could check for requestOptions before but what's the point?
To illustrate the issue, when closing a bloc I often call cancel to be sure that there is no pending request.
Actual Result
StateError is thrown when there's nothing to cancel.

I also facing same issue. Tests begun failing, because actual request is mocked so cancelToken. requestOptions always null and when disposing riverpod provider I can not cancel token anymore.
final _measurementProvider =
    FutureProvider.autoDispose.family<LastMeasurementDto?, String>(
  (ref, serial) {
    final cancelToken = CancelToken();
    ref.onDispose(cancelToken.cancel);
    return ref
        .read(WebApi.provider)
        .getSensorLastMeasurement(serial, cancelToken);
  },
);


Remove unnecessary permissions

Reported by dbrgn on 14 Jun 2016 12:15 UTC
The INTERNET and READ_EXTERNAL_STORAGE permissions seem to be unused. They should be removed.
Patch is attached. Alternatively, you can pull from my fork:
$ git remote add dbrgn https://github.com/dbrgn/freeotp
$ git pull dbrgn/master
(I know people that did not want to use FreeOTP because it used the internet permission.)

Comment by feddy on 29 Jul 2016 15:13 UTC
I'm also wary of the app because of these required permissions, please merge this patch.

Any news about that? I'm quite concerned about such a critical security app. This flaw could lead to OTP leaks, intentionally or not.
Besides, since android.permission.INTERNET is no longer "dangerous", when the user installs the app from Google Play, he doesn't even know it can access the Internet.
See also Every App Gets Internet Access on howtogeek.com:

Google has also given each app Internet access, effectively removing the Internet access permission. Oh, sure, Android developers still have to declare they want Internet access when putting together the app. But users can no longer see the Internet access permission when installing an app and current apps that don’t have Internet access can now gain Internet access with an automatic update without prompting you.

+1

No. FreeOTP will not drop the internet permission because it is actually required for the icon provisioning feature.

I think I need another OTP generator. Thanks anyway.

This decision should definitely be reconsidered... I, personally speaking, don't care for icons, I just want my OTPs generated. But what I definitely don't want is to risk that the app leaks crucial information. @nagromc did you find any alternatives in the meanwhile?

@christiandreher I totally agree with that. I prefer better security over a good looking UI for this kind of app. I don't even know how to download icons from the Internet within the app and I don't give a damn.
I haven't taken the time to check for any alternatives at the moment but I'm still looking for it. Don't miss to drop a line if you find it. Alternativeto.net returns one FLOSS but it isn't as easy to install as FreeOTP since it doesn't seem to exist on the Google Play Store.
Maybe we can find there the latest release of Google Authenticator before Google decided to close the source.

@christiandreher I totally agree with that. I prefer better security over a good looking UI for this kind of app. I don't even know how to download icons from the Internet within the app and I don't give a damn.
I haven't taken the time to check for any alternatives at the moment but I'm still looking for it. Don't miss to drop a line if you find it. Alternativeto.net returns one FLOSS but it isn't as easy to install as FreeOTP since it doesn't seem to exist on the Google Play Store.
Maybe we can find there the latest release of Google Authenticator before Google decided to close the source.

You can try Android Token as an alternative (available via F-Droid).

Thanks for the responses.
@nagromc I think that you're talking about Open Authenticator. I've also found that, but all links on alternative.to seem to be dead, so I assume that the project is dead, too...
@hvhaugwitz Thank you too, but looking at the repository I am quite concerned, because it took the maintainer about a year to close an issue to add a license file. However there's one contributor whose fork got updated from time to time in the past, but it isn't reliable as well I think.
It's a shame that Google decided to make GA proprietary. I checked it on Google Play Store, and it requires the internet permission, too, by the way.dedicated community will fork one of those projects, supporting pin locks etc, and not requiring unnecessary permissions.

@christiandreher The best thing to do maybe to use one the forks.
xftroxgpx/freeotp-android seems to be up-to-date against the original project, but will the original author (@xftroxgpx or @dbrgn) continue maintaining it?

Hey, to be honest I didn't even get to test it yet, just pulled in that one PR then other irl things got in the way. You're better off using other forks :)

I don't have the time to maintain a fork.
If the internet permission is used to fetch icons, how can I get the app to fetch icons?
(I'd also prefer no internet permission and no automatically fetched icons.)

@christiandreher the app requires no permissions and displays the tokens correctly, for me that is sufficient

@charlydelta andOTP worth a try. Nice Material Design UI, no funky permission. It is still in a beta state, but it is in an active development. Exciting! It should be stable enough to try out the features, then why not definitively switch to.
It is even possible to migrate from FreeOTP.


fix: priority names

"Low" implies that its lower than "Normal" priority which is misleading.
I normally would have pushed this directly to development but I want to make sure that it won't cause any issues with our current labeling.
I know my other script renamed the labels, but in the process of renaming, it would actually delete (and lose the label data) from the issues, meaning I had to go back and manually re-assign all the labels again. I just want to make sure something like that doesn't happen again.
If all is clear, please merge and deploy this.

I wanna deploy with all the features in review


Adding legacy assets for SNS destinations.

Signed-off-by: AWSHurneyt<EMAIL_ADDRESS>Description
Adding legacy assets for SNS destinations.
Issues Resolved
[List any issues this PR will resolve]
Check List

[x] New functionality includes testing.

[x] All tests pass

[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #344 (64c859a) into main (6305d7f) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
+ Coverage   52.73%   52.75%   +0.02%
==========================================
  Files         209      209
  Lines        5450     5461      +11
  Branches      763      767       +4
==========================================
+ Hits         2874     2881       +7
- Misses       2574     2578       +4
  Partials        2        2

Impacted Files
Coverage Δ

...CreateTrigger/components/Action/utils/constants.js
28.57% <0.00%> (-4.77%)
:arrow_down:

.../containers/CreateDestination/CreateDestination.js
3.75% <0.00%> (-0.05%)
:arrow_down:

...lugin/public/pages/Destinations/utils/constants.js
100.00% <0.00%> (ø)

...ers/CreateDestination/utils/formikToDestination.js
72.72% <0.00%> (ø)

...gins/alerting-dashboards-plugin/utils/constants.js

...plugins/alerting-dashboards-plugin/babel.config.js

...tinations/components/createDestinations/SNS/SNS.js
0.00% <0.00%> (ø)

...ions/components/createDestinations/SNS/validate.js
100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

OpenSearch-Dashboards' 2.3 branch has been bumped to 2.3.1. The cypress workflow for this PR depends on this PR https://github.com/opensearch-project/alerting-dashboards-plugin/pull/345

We dont need this merged in anymore


Add Keymap

I added a basic Keymap implementation with two examples. This should definitely be expanded to also be able to read keybindings from files using a from_file method, but I didn't want to add everything all at once.
Currently the Keymap supports inserting and removing keybindings, both during runtime and during the creation of the model.

I renamed the KeyBinding to KeyChord and also updated the Keymap to allow for many-to-many relationships. It is now able to just lookup a KeyChord and retrieve a Vec over all actions that get triggered through that KeyChord. So instead of having to lookup every action we now just get the actions that are being pressed.


pow(base, exp) gradient inconsistency at base=0.0

The following model fails to initialize due to bad gradient if s = 1 or s = 2 but initializes fine when s = 3 and s = 4.
data {
  int<lower=1,upper=4> s;
}
parameters {
  vector[2] x;
}
model {
  if (s == 1)
    target += distance(x,x);
  else if (s == 2)
    target += pow(squared_distance(x,x), 0.5);
  else if (s == 3)
    target += pow(squared_distance(x,x), 0.5 + 1e-16);
  else if (s == 4)
    target += abs(x[1] - x[1]) + abs(x[2] - x[2]);
}

This is surprising because s = 1 looks like a well-formed (though redundant) model and in any case s=1, s=2, and s=3 should all be equivalent. (s=4 is a one-dimensional version of s=1)
The behaviour for s=2 and s=3 is  different because pow(base, exp) skips gradient calculation at base=0 in the general case (as if the gradient was zero) but delegates exp=0.5 case to sqrt() which always computes the mathematically correct gradient (infinity at base=0). And zero gradient ends up being accidentally correct whereas an infinite gradient is an unrecoverable error.
The mathematically correct value for the derivative of pow(base, exp) with respect to base at base=0.0 is

0.0 when exp > 1.0
1.0 when exp = 1.0
positive infinity when 0.0 < exp < 1.0
0.0 when exp = 0.0
negative infinity when exp < 0.0

It would be reasonable to round infinity down to a finite-but-near-maximum floating point number.
Moreover, Stan only requires gradients to be correct almost everywhere. Boundary points like base=0 are relevant only in expressions like distance(x,x) where the gradients cancel anyway and the only thing that matters is whether the intermediate gradient values are finite. So the most numerically stable choice might be to "round" the infinity all the way down to zero.
I'm inclined to think pow()'s current behaviour is correct for us and sqrt() (and possibly cbrt())  should be "fixed" to also have vanishing gradient at zero.
Current Version:
v4.8.1

#3033


Adds ETC2 support

Adds support for ETC2,ETC2A,ETC1S,ETC2AS by using modified crunch files based on https://github.com/Unity-Technologies/crunch/tree/unity

I have cleaned up your PR and reduced the diff noise by standardizing on a clang-format first.
However, the tests are failing…

By the way, please don't modify setup.cfg in PRs. That is done at release time (I'll do one once this lands).

Fixed the compile errors, now just the failing test.

Thanks o/
It was compiling fine on my windows system,
that's why I thought it's alright.
A friend who uses mac had to use

#define malloc_usable_size malloc_size
to compile it.

Can you take a look at the test images before & after and check that they're still good?
I'm very wary of merging something that has binary differences on a lossless format, but it might be the previous behaviour was incorrect. Either way if that's the case the tests need to be updated.

def CompareImages(typ):
	crn_path = get_resource("%s.crn"%typ)
	img_path = get_resource("%s.png"%typ)
	if typ == 'dxt1':
		args = (1, )
	elif typ == 'dxt5':
		args = (3, )

	img_ori = Image.open(img_path)

	data = open(crn_path,'rb').read()
	data = bytes(File(data).decode_level(0))
	img_ex = Image.frombytes('RGBA', img_ori.size, data, 'bcn', args)
	img_ex.save(img_path[:-4]+'_ex.png')

	c_ori = img_ori.split()
	c_ex  = img_ex.split()

	for i,channel in enumerate(['Red','Green','Blue','Alpha']):
		print(channel, c_ori[i]==c_ex[i])

The images aren't exactly identical.
I compared them via
online-image-comparison
and the difference seems to lie above and below the actual image 🤔 .

..........
I just noticed......that the crunch from unity somehow has problems with the test test files.
e.g.
crunch_x64
converts the dxt5 to

Alright, managed to fix it.
Both tests are passed and ETC2 works too.

class Format(IntEnum):
	"""
	Crunch format (what block-compressed texture format this decodes to)
	"""

	Invalid = -1
	DXT1 = 0
	DXT3 = 1
	DXT5 = 2

	# Various DXT5 derivatives
	DXT5_CCxY = 3 # Luma-chroma
	DXT5_xGxR = 4 # Swizzled 2-component
	DXT5_xGBR = 5 # Swizzled 3-component
	DXT5_AGBR = 6 # Swizzled 4-component

	# ATI 3DC and X360 DXN
	DXN_XY = 7
	DXN_YX = 8

	# DXT5 Alpha block only
	DXT5A = 9

	ETC1 = 10
	ETC2 = 11
	ETC2A = 12
	ETC1S = 13
	ETC2AS = 14

in decrunch.pyx has to be changed too,
the current version is missing the last 4 entries.

Can you update it?

Ah,
I really have no real experience with the compiler settings in crn_decomp.cpp.
A friend figured out that mac requires
#define malloc_usable_size malloc_size

Will merge this tomorrow.

Alright 👌


[FEATURE] Add pagination to the search page

Description
Currently, the search page in this project lacks a pagination system, which makes it difficult for users to navigate through search results efficiently. To improve user experience and enhance usability, we should consider implementing a pagination feature.
Proposed Solution:

Introduce a pagination component that allows users to navigate through search results pages.
Display a limited number of results per page, with options to navigate to previous or next pages.

Benefits:

Enhanced user experience by simplifying navigation through search results.
Improved performance by loading only the necessary data per page.
Better usability, especially for users with large search result sets.

Screenshots
No response
Additional information
No response

@eddiejaoude please review it and I would love to know your thoughts on this. Also If my proposal resonates to you I would love to work on this feature

Hey @detronetdip i think the issue you suggested this already has opened #7599 and I've been working on this

@badrivlog  I am extremely sorry.
Closing


Publish extension to OpenVsx (VSCodium)

I was wondering if this extension can be published to https://open-vsx.org/ as well which is extension marketplace for VSCodium, a trve OSS editor.
It would just require 2 lines of code in CI and creating a publish token with OpenVSX.

Great idea. I will take a look this week.

https://open-vsx.org/extension/projektanker/code-butler
Done 🥳


License Clarification

Hi @DmitryUlyanov, thanks for this library. I was looking at the license and it looks like the copyright year and name aren't filled out.
https://github.com/DmitryUlyanov/Multicore-TSNE/blob/11b0cd7df072ae6ba76c7d92d2530142cf1c4304/LICENSE.txt#L3
In the source code, there are a few headers that mention:
 *  Created by Laurens van der Maaten.
 *  Copyright 2012, Delft University of Technology. All rights reserved.
 *
 *  Multicore version by Dmitry Ulyanov, 2016<EMAIL_ADDRESS>
Also, readme mentions the license is inherited from bhtsne, but that repo uses original BSD license (4 clause) and this one uses BSD 3 Clause.
Can you provide some clarification on the licensing?

As-is this repo seems to be infringing on the upstream repo as it's not keeping the original license file, nor the required copyright attribution line. @DmitryUlyanov - can you please fix that? Should be a quick matter of copying over the original license file from upstream and then adding your copyright line in addition to that of @lvdmaaten


Implemented the settings page

Implemented the client site part of the settings page.
Only thing missing is the blocked GUIDs part which will be added later.

Looking at this now. Did see this though so far.

Is the heading off or am I missing something there?

Also @username handle is a required field. This should be optional I believe right @morebrownies ?

Yes, user avatar should display next to "settings".
Correct, handle should be optional.

@cpacia is libbitcoin server URL available? It doesn't get populated here yet.

Avatar needs to refresh in the nav bar too when you set it.

Yes, good call.

It'd be nice if the avatar was previewed on the page when you select it.
Something weird is happening with the country drop down. The options are all in white. This looks like it happens on all of the option dropdowns. I think the issue is you're not using Chosen on them. Make sure to call Chosen on each one in the callback in your loadTemplate.

The server address should be added under Advanced.
This needs to be merged with master. I noticed the package.json is out of date and userPage doesn't make the moderators websocket call.
Aside from the above, and the inline comments I made, this is looking good. Once you have the changes made resubmit it.


Bump itwinui-react to 3.11.0

Changes
Bumped itwinui-react to 3.11.0.
Testing
N/A

We are getting infinite state update error when opening ConfigurableUi in component examples. I think this relates to ThemeProvider changes and now PopoutThemeProvider causes this error. Not 100% sure but I see ThemeProvider was made to work correctly in popout windows so probably this is where it is clashing. I'll try to fix it.

The state update issue was fixed in itwinui-react 3.11.2 so I updated to that version now. Everything seems to be working fine now.


fix minor typo (mastadon > mastodon)

Sorry, I didn't respected your git commit message conventions.
Feel free to close this merge request and I'll resubmit one.

It's okay. Thanks Trey!


Separate Bunsen's profile loader for each FHIR version.

Currently there is a single ProfileProvider interface that is used in a ServiceLoader pattern for loading various profiles. The problem is that these profiles are then loaded independent of the FHIR context version. This should be fixed (currently there is a check guarding against it but that is a hack).

Actually the guard that I mentioned in the above description is fine (not a "hack"). This way we keep ProfileProvider interface simpler and leave it to the implementations to decide whether they have any profiles for the particular FhirContext version.


fix: disable runner

Idk know about my impl... On the one hand i like that it cleans up runner crs if the runner-sync flag is set to false and than disables itself, on the otherhand this might be confusing as there is still sth going on for the enduser even if the feat is disabled. I also thought about starting the runner controller not with the manager, but separate so one could disable to entire reconciler at runtime...


[FEAT]: get email template by name

Description
Develop an API endpoint to retrieve a specific email template by its name.
Acceptance Criteria

The endpoint should be accessible at api/v1/email/templates/:templateName

The endpoint should accept HTTP GET requests.

The endpoint should be secured to ensure that only authenticated users can retrieve an email template.

Proper authentication mechanisms (e.g., JWT, OAuth2) should be implemented.

Requests to the endpoint must include a valid authentication token in the Authorization header: Authorization: Bearer

The endpoint should return the content of the specified email template if it exists.

Request

HTTP Method: GET

Endpoint: /api/v1/email/templates/:templateName

Request Headers:

{
  "Authorization": "Bearer <token>"
}

Response

On Successful Retrieval

Status Code: 200

Response Body:

{
{
  "status_code": 200,
  "data": {
    "template": {
      "name": "templateName.hbs",
      "content": "{{!-- Handlebars template content --}}"
     }
  }
}

If the User is Not Authenticated

Status Code: 401 Unauthorized

Response Body:

{
  "success": false,
  "status_code": 401,
  "message": "Not authenticated"
}

Purpose

Provides a backend service for users to retrieve a specific email template by its name from Handlebars (.hbs) files.

Requirements

Develop server-side logic to retrieve an email template by its name from the filesystem.

Ensure that only authenticated users can access this endpoint.

Expected Outcome

The API endpoint allows authenticated users to retrieve a specific email template with appropriate validation and authentication.

https://github.com/hngprojects/hng_boilerplate_nestjs/issues/273


fluff can't work

I download the test files and run the followed command on the Linux:
fluff profile -i chr1:68602071-68612071 -d mesenchymal_H3K27ac.bam mesendoderm_H3K27ac.bam -o test
The error was as followed, I don't know how to figure out,
Traceback (most recent call last):
File "/home/hmk/anaconda2/bin/fluff", line 4, in
import('pkg_resources').run_script('biofluff==2.1.3', 'fluff')
File "/home/hmk/anaconda2/lib/python2.7/site-packages/pkg_resources/init.py", line 654, in run_script
self.require(requires)[0].run_script(script_name, ns)
File "/home/hmk/anaconda2/lib/python2.7/site-packages/pkg_resources/init.py", line 1434, in run_script
exec(code, namespace, namespace)
File "/home/hmk/anaconda2/lib/python2.7/site-packages/biofluff-2.1.3-py2.7.egg-info/scripts/fluff", line 9, in
args.func(args)
File "/home/hmk/anaconda2/lib/python2.7/site-packages/fluff/commands/profile.py", line 59, in profile
adjscale=args.adjscale
File "/home/hmk/anaconda2/lib/python2.7/site-packages/fluff/plot.py", line 281, in profile_screenshot
fig = plt.figure(figsize=(wsize, hsize))
File "/home/hmk/anaconda2/lib/python2.7/site-packages/matplotlib/pyplot.py", line 548, in figure
**kwargs)
File "/home/hmk/anaconda2/lib/python2.7/site-packages/matplotlib/backend_bases.py", line 161, in new_figure_manager
return cls.new_figure_manager_given_figure(num, fig)
File "/home/hmk/anaconda2/lib/python2.7/site-packages/matplotlib/backend_bases.py", line 167, in new_figure_manager_given_figure
canvas = cls.FigureCanvas(figure)
File "/home/hmk/anaconda2/lib/python2.7/site-packages/matplotlib/backends/backend_qt5agg.py", line 24, in init
super(FigureCanvasQTAgg, self).init(figure=figure)
File "/home/hmk/anaconda2/lib/python2.7/site-packages/matplotlib/backends/backend_qt5.py", line 234, in init
_create_qApp()
File "/home/hmk/anaconda2/lib/python2.7/site-packages/matplotlib/backends/backend_qt5.py", line 125, in _create_qApp
raise RuntimeError('Invalid DISPLAY variable')
RuntimeError: Invalid DISPLAY variable

This is a problem with the default matplotlib configuration on a Linux server without an X environment. On the following page I give two possible solutions (for a different piece of software). Can you check if these work?
https://gimmemotifs.readthedocs.io/en/master/faq.html#faq

I guess this issue is fixed? Feel free to reopen if you still encounter issues!


PCM-1726

removed package.json 'browser' field and pointed 'module' field to correct file name

This will fix #117


Batch norm example?

Hi,
I'm having trouble implementing batch norm for forward inference. I've tried many things and they all lead to a mkldnn::error exception being thrown at some point or another, or incorrect results. I think I am not getting the various dimensions or formats of the memory descriptors correct.
Based on reading the documentation, I inferred that for a FC layer, we have to compress all the dimensions for a single input into the channel dimension. That seems to be what the batch norm descriptor expects too, since if I try any other combination, I get an error with the expected sizes of the memories being different.  Let me know if this is wrong.
Here's basically what I'm trying: https://gist.github.com/xyzsam/f03124689ffbd92c03eb3ede7fab0a25
The mkldnn::error gets thrown at the very end when I create the batch_normalization_forward primitive. But I don't get any other information about what caused it. In general, it would be really useful if these errors could get propagated up.
If I take out the use_global_stats flag and remove the mean and variance memories, it at least runs to completion , but the output is wrong (never mind that part).

It seems like when I construct the batch_normalization_forward object, it doesn't get the right constructor.
The one I want is:
    batch_normalization_forward(const primitive_desc &aprimitive_desc,
            const primitive::at &src, const primitive::at &mean,
            const primitive::at &variance, const primitive::at &weights,
            const memory &dst) {
        mkldnn_primitive_t result;
        mkldnn_primitive_at_t inputs[] = { src.data,
            mean.data, variance.data, weights.data };
        const_mkldnn_primitive_t outputs[] = { dst.get() };
        error::wrap_c_api(mkldnn_primitive_create(&result,
                aprimitive_desc.get(), inputs, outputs),
            "could not create a batch normalization forward primitive");
        reset(result);
    }

The one it actually goes to is:
    batch_normalization_forward(const primitive_desc &aprimitive_desc,
            const primitive::at &src, const primitive::at &weights,
            const memory &dst, const memory &mean, const memory &variance) {
        mkldnn_primitive_t result;
        mkldnn_primitive_at_t inputs[] = { src.data, weights.data };
        const_mkldnn_primitive_t outputs[] = { dst.get(),
            mean.get(), variance.get() };
        error::wrap_c_api(mkldnn_primitive_create(&result,
                aprimitive_desc.get(), inputs, outputs),
            "could not create a batch normalization forward primitive");
        reset(result);
    }

Hi @xyzsam,
Alas there is minor confusion with batch norm here...
We probably use overloading too much :)
You need to help compiler understand that first 5 objects are actually primitive::at, and not just memory.
The following patch fixes the issue:
diff --git a/x.cpp b/x.cpp
index dc4e280..672d4f8 100644
--- a/x.cpp
+++ b/x.cpp
@@ -53,9 +53,9 @@ void batch_norm() {
     /* Repeat for all the other inputs */

     auto bn = batch_normalization_forward(bn_pd,
-                                          input_memory,
-                                          bn_mean_memory,
-                                          bn_var_memory,
-                                          bn_weights_memory,
+                                          primitive::at(input_memory),
+                                          primitive::at(bn_mean_memory),
+                                          primitive::at(bn_var_memory),
+                                          primitive::at(bn_weights_memory),
                                           bn_dst_memory);
 }

Would you mind sharing details on compiler you are using?

My question is actually irrelevant. I misunderstood @emfomenk's comment.

Thanks a lot for the help! I'm finally able to get past the exception and get the correct results. Hopefully you guys can resolve this overloading issue in the future. I'm not entirely sure why memory can be implicitly converted to primitive:at, so some documentation explaining this would be helpful. Also, it would very helpful to explicitly state what the dimensionality of the inputs are expected to be - I had to infer that from the LaTeX equation, which isn't ideal :)


Request for Extension of Result Monad to Accommodate Void Functions

Context:
The current implementation of the Result monad in our functional programming library for Golang provides a robust mechanism for handling success and failure scenarios in functions. However, it lacks explicit support for functions that return no result on success, commonly known as "void" functions.
Proposal:
I propose extending the existing Result monad to include explicit support for void functions. This enhancement would enable users to represent and handle successful outcomes where the function does not explicitly return a result.
Requirements:
The extended Result monad should be able to accommodate both functions that return a value on success and functions that don't. This could involve introducing a new type or modifying the existing Result type to support both scenarios.
Use Case:
Consider a scenario where a function is responsible for updating a database record and does not return any value upon success. Currently, users have to resort to using nil or other ad-hoc solutions, which can lead to ambiguity and decreased code readability.
Example:
// Current Usage
func UpdateRecord(data Data) error {
    // perform update
    if err := performUpdate(data); err != nil {
        return err
    }
    return nil
}

// Proposed Usage
func UpdateRecord(data Data) UnitResult {
    // perform update
    if err := performUpdate(data); err != nil {
        return Err(err)
    }
    return UnitOk() // No result to return on success
}

Benefits:

Clarity: Users will have a clear and consistent way to handle functions that don't return a result on success.
Readability: Code readability will be improved as the intent of the function will be more explicit.
Consistency: The UnitResult monad will maintain consistency with the existing design, making it easier for users to adopt and understand.

I look forward to community feedback and discussions on this proposed enhancement.
Thank you!

Your proposal would be to create UnitResult, as an alias for Result[Unit]? Or a completely different monad type?
Can you provide some examples of UnitResult being much easier to use than err == nil?

Response

TL;DR: Disregard, after doing some more reading I realize the current version of Go does not accomodate what I am trying to achieve.

I am relatively new to FP concepts and the use of Monads, so there might be better ways to tackle the issue that I am not seeing. The scenario that led me to post this issue is when chaining function calls in and I want to make use of the build-in error handling of Result. Given the following functions:
type A struct { ... }
type B struct { ... }

func GetA() (A, error) { ... }
func UseA(a A) error { ... }
func GetB() (B, error) { ... }
func UseB(b B) error { ... }

func DoWork() error {
    a, err := GetA()
    if err != nil {
        return err
    }
    err = UseA(a)
    if err != nil {
        return err
    }
    b, err := GetB()
    if err != nil {
        return err
    }
    err = UseB(b)
    if err != nil {
        return err
    }

    return nil
}

func main() {
    err := DoWork()
    // ...
}

I would like to use the Result monad to more succinctly express the DoWork() function - avoiding the need for all those explicit if err != nil checks. Ideally I would like to write something similar to:
func DoWork() UnitResult {
    return GetA().
        MapUnit(UseA).  // func (r Result[T])  MapUnit(mapper func(value T) error) UnitResult
        Map(GetB).      // func (r UnitResult) Map[T2 any](mapper func(value T) (T2, error)) Result[T2]
        MapUnit(UseB)   // func (r Result[T])  MapUnit(mapper func(value T) error) UnitResult
}

After doing some research I have come to realize that struct methods do not allow for generics so this would be impossible to implement right now. (https://github.com/golang/go/issues/49085)

Oh! Yes, unfortunately, this is the major limitation of this library.
Trust me, as soon as it is possible in go, this library will get a v2 😆
Unfortunately, some dude in the Go core team don't want to push it forward :-(


[Syphilis] Results page supports Syphilis test results

Why should we do this?

(current experience) The Test Results screen in SimpleReport does not display syphilis results, leading to an incomplete representation of test data for users.
(why we want to make this change) By adding support for syphilis results on the Test Results screen, we can provide a comprehensive view of all test data, including syphilis, allowing users to access and review syphilis test results alongside other test results.

User story
As a SimpleReport user, I want to view syphilis test results on the Test Results screen so that I can easily access and review syphilis test data alongside other test results for accurate patient monitoring and management.
Action Requested
Update the components on the Test Results screen to include support for displaying syphilis results.  This includes:

adding syphilis as a selectable condition in the Condition filter
including a syphilis column in the "Download results" spreadsheet
showing syphilis on the printed page for "Print details,"
displaying syphilis information on the modal for "View details."
ensure that syphilis is supported for emailing and texting results.

Acceptance Criteria
Review

[ ] Reviewed with design and/or design lead
[ ] Reviewed with content strategist for final approval
[ ] Reviewed with product and engineering

Additional Context

possibly consider adding disease column for the downloaded spreadsheet first

hide behind feature flag?


fix: support docker/.env-local for docker-compose

As reported here https://github.com/apache/superset/issues/28026, in https://github.com/apache/superset/pull/27953 I added support for a supplemental docker/.env-local override file, not thinking it was going to be required upon starting docker-compose. I thought I had tested that while switching branches but somehow didn't test that docker-compose would simply boot up in the absence of that file.
BUT! luckily there's a new feature as of docker-compose 2.24.0 where there's a way to specify required and not-required files here, so I'm taking advantage of that in this correction PR. Kudos to @artofcomputing for finding this new feature and for pointing this out!
I also added a bit of documentation to point to an existing mechanism around providing a docker/pythonpath_dev/superset_config_docker.py file, which existed in the logic but wasn't clearly documented. This
solves for my use case where I was working a PR adding features around Slack, where I wanted to provide an API key configuration without risks of commiting/pushing it back to the repo.
closes https://github.com/apache/superset/issues/28026

docker-compose is getting very usable for dev workflows - having it boot fast from my previous PR makes it much more viable too

NICE! I'm feeling like CI / docker / docker-compose is getting to a pretty good place.


⚠ Bofrost.de has degraded performance

In 3fe0c33, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1500 ms

Resolved: Bofrost.de performance has improved in 61ad85f after 13 minutes.


Assert_equal nil, should be Assert_nil

Re: enumerables/exercises_1/find_pattern_test.rb

I recently found that working through the exercise, the pass of a Mintiest was followed by a prompt about a future fail in an upcoming version of Mintiest. Mintiest was requesting assert_nil nil instead of assert_equal nil

Hi @GeorgieGirl24, thanks for filing this!
Sure enough, assert_equal nil, actual is deprecated in favor of assert_nil, actual
You mentioned that you've made a commit to fix the problem, swapping out the offending assertions.
Lets talk through getting the pull request made!
Here's the steps I think you'll need to take. Can you give them a shot, let me know where I forget to mention something?

fork this ruby-exercises repository to your own github account.
attach your local version of the ruby-exercises directory to your forked github repository. Something like:

$ git remote add origin <url-to-your-forked-github-repo>

should do it.

Check out a new branch, git checkout -b fix-assert-equal-nil
Push the new branch to your forked repository: git push origin fix-assert-equal-nil
create a new pull request from your forked repository to this repository.

There's plenty of complexity in these above steps - I'm 100% happy to help coach you through it. As much as possible, I want to keep the instructions here in public so future students can find this knowledge.


tools: fix regression in gen_compilation_database.

Introduced in #8597, this causes unpleasant errors if a developer has not configured
LLVM_CONFIG. The solution is to not query over the clang tools in this env.
Risk level: Low
Testing: Manual, with LLVM_CONFIG set/unset.
Signed-off-by: Harvey Tuch<EMAIL_ADDRESS>

This seems naive, and I believe it still break command like bazel build //... without LLVM_CONFIG? I'm thinking of splitting whole clang tools in a different bazel repository (like we do for @envoy_api), and only setup that repo when LLVM_CONFIG is set. WDYT?

The idea is to unblock folks affected by the regression, I agree it is naive. Sure, I'm happy to use a distinct repository like @envoy_api, but I probably don't have cycles today to work on this, likely early next week.

@lizan turns out I had a few cycles in between compiles, PTAL.


[NETOBSERV-97] eslint setup & tests

npm run lint
rules are in .eslintrc.js file based on react/recommended & ts-eslint/recommended
> eslint "./src/**/*.{ts,tsx}"

/network-observability-console-plugin/web/src/components/netflow-traffic.tsx
  29:7  warning  The false literal is not a valid dependency because it never changes. You can safely remove it  react-hooks/exhaustive-deps

✖ 1 problem (0 errors, 1 warning)

We can remove this warning but exhaustive-deps seems interesting in some cases
npm run test
jest config is in package.json using enzyme for react 16
> jest

 PASS  src/components/__tests__/netflow-traffic.spec.tsx
  <NetflowTraffic />
    ✓ should render component (7 ms)

Test Suites: 1 passed, 1 total
Tests:       1 passed, 1 total
Snapshots:   0 total
Time:        4.141 s
Ran all test suites.

I had issues with @console module name resolution in jest so I created a dummy file exporting only needed functions.  Is it ok for everyone ?

@jpinsonneau I will update prow so that it runs make build lint test or something like that.
However I've tried to build locally and I get an error, not sure if it's due to my nodejs version?
It shows:
/work/network-observability-console-plugin/web/node_modules/webpack/lib/dependencies/HarmonyImportDependency.js:125
		if (!importedModule || importedModule.getNumberOfErrors() > 0) {
                                        ^
TypeError: importedModule.getNumberOfErrors is not a function
    at HarmonyImportSpecifierDependency.getLinkingErrors (/work/network-observability-console-plugin/web/node_modules/webpack/lib/dependencies/HarmonyImportDependency.js:125:41)
    at HarmonyImportSpecifierDependency._getErrors (/work/network-observability-console-plugin/web/node_modules/webpack/lib/dependencies/HarmonyImportSpecifierDependency.js:202:15)
    at HarmonyImportSpecifierDependency.getWarnings (/work/network-observability-console-plugin/web/node_modules/webpack/lib/dependencies/HarmonyImportSpecifierDependency.js:178:16)
    at Compilation.reportDependencyErrorsAndWarnings (/work/network-observability-console-plugin/web/node_modules/webpack/lib/Compilation.js:3127:24)

You don't have the same?

@jpinsonneau I will update prow so that it runs make build lint test or something like that. However I've tried to build locally and I get an error, not sure if it's due to my nodejs version?
It shows:
/work/network-observability-console-plugin/web/node_modules/webpack/lib/dependencies/HarmonyImportDependency.js:125
		if (!importedModule || importedModule.getNumberOfErrors() > 0) {
                                        ^
TypeError: importedModule.getNumberOfErrors is not a function
    at HarmonyImportSpecifierDependency.getLinkingErrors (/work/network-observability-console-plugin/web/node_modules/webpack/lib/dependencies/HarmonyImportDependency.js:125:41)
    at HarmonyImportSpecifierDependency._getErrors (/work/network-observability-console-plugin/web/node_modules/webpack/lib/dependencies/HarmonyImportSpecifierDependency.js:202:15)
    at HarmonyImportSpecifierDependency.getWarnings (/work/network-observability-console-plugin/web/node_modules/webpack/lib/dependencies/HarmonyImportSpecifierDependency.js:178:16)
    at Compilation.reportDependencyErrorsAndWarnings (/work/network-observability-console-plugin/web/node_modules/webpack/lib/Compilation.js:3127:24)

You don't have the same?

Sorry @jotak, this was related to package-lock merge. It's fixed on my side now

/lgtm

/retest

/retest

/lgtm


pytest -v doesn't show full stack trace of reraised exceptions

It appears that reraise is discarding the traceback in the __exit__. Is this intentional?

Actually, this might just be environmental.


FilesystemClosed error when loading glyph after font.save()

>>> import defcon
>>> font = defcon.Font()
>>> font.newGlyph("a")
<defcon.objects.glyph.Glyph object at 0x111503fd0>
>>> path = "/tmp/ufo.ufo"
>>> font.save(path)
>>> print(font["a"])
<defcon.objects.glyph.Glyph object at 0x111503fd0>
>>> del font
>>> font = defcon.Font(path)
>>> font.save(path)
>>> print(font["a"])
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/clupo/Library/Python/3.7/lib/python/site-packages/defcon/objects/font.py", line 242, in _getitem_
    return self._glyphSet[name]
  File "/Users/clupo/Library/Python/3.7/lib/python/site-packages/defcon/objects/layer.py", line 247, in _getitem_
    self.loadGlyph(name)
  File "/Users/clupo/Library/Python/3.7/lib/python/site-packages/defcon/objects/layer.py", line 169, in loadGlyph
    self._stampGlyphDataState(glyph)
  File "/Users/clupo/Library/Python/3.7/lib/python/site-packages/defcon/objects/layer.py", line 579, in _stampGlyphDataState
    modTime = glyphSet.getGLIFModificationTime(glyphName)
  File "/Users/clupo/Library/Python/3.7/lib/python/site-packages/fontTools/ufoLib/glifLib.py", line 345, in getGLIFModificationTime
    return self.getFileModificationTime(fileName)
  File "/Users/clupo/Library/Python/3.7/lib/python/site-packages/fontTools/ufoLib/_init_.py", line 122, in getFileModificationTime
    dt = self.fs.getinfo(fsdecode(path), namespaces=["details"]).modified
  File "/Users/clupo/Library/Python/3.7/lib/python/site-packages/fs/wrapfs.py", line 138, in getinfo
    raw_info = _fs.getinfo(_path, namespaces=namespaces).raw
  File "/Users/clupo/Library/Python/3.7/lib/python/site-packages/fs/osfs.py", line 284, in getinfo
    self.check()
  File "/Users/clupo/Library/Python/3.7/lib/python/site-packages/fs/base.py", line 1553, in check
    raise errors.FilesystemClosed()
fs.errors.FilesystemClosed: attempt to use closed filesystem
>>> defcon.__version__
'0.7.2'

Also happens when installing from master.
Sorry I don't have time to investigate further.

Just tested this with the latest Defcon, this is now fixed.

Double checked, tested and works with latest version (0.8.1)


IE 11 Support

Currently arrow functions need to be transpired by babel in order to support this in IE11.
Please use @babel/plugin-transform-arrow-functions.

IMO it is the end user's obligation to transpile to the browser targets they desire. This means transpiling your node_modules. I have learned through experience that you simply cannot trust external libraries to support any specific target. As such, these libraries only transpile with ESM and CJS targets in mind because it is a much more reasonable expectation that I should be able to require() a module.

FWIW this is in line with the assumption that create-react-app makes.

https://github.com/facebook/create-react-app/issues/1125#issuecomment-264158377
From gaearon, responding to The only answer to this is, IMHO, to also transpile external dependencies. Is this supported by create-react-app?
No, this is not supported because builds will get much slower. We don't recommend using libraries that don't precompile their code to ES5 but are supposed to be usable in ES5.

We will fix the Uglify problem in the future by using Babili. However it still means that even uglified code will still be ES6 if that's what your dependencies are shipping.

With time it won't matter as much because mainstream browsers will support ES6. Until then I recommend to use libraries that take care of transpilation step.

As quoted later in the thread, this shipped in v2
https://github.com/facebook/create-react-app/issues/1125#issuecomment-426120762

Don't sure what you mean by this shipped in v2. I think you may be thinking of their opinions on polyfills https://github.com/facebook/create-react-app/blob/master/packages/react-app-polyfill/README.md Note that support for older browsers is now opt-in to reduce the polyfill size.. Doing what I'm suggesting will not increase the amount of code.
What is the downside?

This particular transformation doesn't drastically increase the bundle size, but the logical argument remains: the end-user should pick their own target. Turning on @babel/plugin-transform-arrow-functions alone won't make any particular lib IE 11 compatible as the issue title suggests. If I go on to use Object.keys() somewhere, IE 11 breaks again. It's just not my responsibility to maintain your target. I use a build system that transpiles node_modules and would therefore gain nothing from this proposal. Nothing is stopping you from copying/pasting any particular library and doing the transformation yourself - it's MIT licensed.


feat(code quality): Add comments for parallel welford variance calculation

Make code more readable
Partially fixes: https://github.com/NVIDIA/TransformerEngine/issues/422

Thanks for your contribution :-)!


The more link on the QNA view is not working

See image, it should expand the text:

Wasn't this solved by a PR?

Yes you are right, the issue did not automatically close, so closing it now....


Fix typo in README

Jaxon.Path.decode!
to
Jaxon.Path.parse!

Coverage remained the same at 86.452% when pulling 5fcee167f530e73c24ee3ea8d0fda7eb89fac929 on suexcxine:patch-1 into fb638f76945236822e8e015ee4b4d79b8255b71e on boudra:master.


Update to use clients from gcp-plugin-core.

Depends on:

[x] Release version 0.9 of google-oauth-plugin and update version number in pom.xml here
[x] Release first version (probably 0.1) of gcp-plugin-core-java and update version number in pom.xml here

Suggest also adding a similar note re: OAuth v0.9 here as well.


Create KeltnerChannelsTests.cs

Tester file for keltner channels

I'll merge this along with the other keltner PRs into one commit on master.

After pulling all the code down locally ( #160, #161, #162, #163 ) I was able to get it to build (moved KelterChannels.cs to Indicators and added to csproj). I added KeltnerChannels.cs to QuantConnect.Tests.csproj and I also added spy_with_keltner.csv to the QuantConnect.Tests.csproj and set it to copy if newer.
After these steps I was unable to get the tests to pass. I tried setting the epsilon on the Assert statements to 0.1 ( I wouldn't like to allow more error than that ) and they still failed. We'll need to take another look at the implementation to verify before pushing into master.

I had verified the outputs previously. There may be a difference due to spy test data using a different number of ATR multiples. In the tester I had used 20 periods and 1.5 multiples. Would need to confirm with jared what multiple he used when setting up the test data.

@lockyssmith - I just used the default value from freestockcharts.com (20
typical price / 1.5 atr multiple)
On Wed, Sep 9, 2015 at 5:52 PM, lockyssmith<EMAIL_ADDRESS>wrote:

I had verified the outputs previously. There may be a difference due to
spy test data using a different number of ATR multiples. In the tester I
had used 20 periods and 1.5 multiples. Would need to confirm with jared
what multiple he used when setting up the test data.
—
Reply to this email directly or view it on GitHub
https://github.com/QuantConnect/Lean/pull/162#issuecomment-139056463.

--
Jared Broad
www.quantconnect.com
Phone-USA: +1<PHONE_NUMBER>
Democratizing Finance, Empowering Individuals
Facebook http://www.facebook.com/QuantConnect | Twitter
https://twitter.com/#!/QuantConnect | LinkedIn
http://www.linkedin.com/company/quantconnect | Skype: jaredbroad

Merged in Keltner Channels in https://github.com/QuantConnect/Lean/commit/b79431a8c912f1aa23ed3fde852a2a03f490417d


num_tasks is ignored for CompileOnlyRegressionTest

Hi,
I would like to specify num_tasks for a build only test:
@rfm.simple_test
class BuildTest(rfm.CompileOnlyRegressionTest):
    valid_systems = ["hpc:hpc"]
    valid_prog_environs = ["*"]
    build_system = "Spack"
    build_locally = False
    num_tasks = 2

    @run_before("compile")
    def setup_build_system(self):
        self.build_system.specs = ["fio"]
        self.build_system.install_tree = "$SPACK_ROOT/opt/spack"

    @run_before("sanity")
    def set_sanity_patterns(self):
        self.sanity_patterns = sn.assert_found("Updating", self.stdout)

The resulting slurm job is:
#!/bin/bash
#SBATCH --job-name="rfm_BuildTest_build"
#SBATCH --ntasks=1
#SBATCH --output=rfm_BuildTest_build.out
#SBATCH --error=rfm_BuildTest_build.err
#SBATCH --exclusive
#SBATCH --partition=hpc

I have also tried to add:
    @run_before("compile")
    def set_job_opts(self):
        self.num_tasks = self.current_partition.processor.num_cpus

or
    @run_before("run")
    def set_job_opts(self):
        self.num_tasks = self.current_partition.processor.num_cpus

But the slurm job contains always --ntasks=1.
Any ideas?
Thanks

@yellowhat can you try what @ekouts has proposed here: https://github.com/eth-cscs/reframe/issues/2093#issuecomment-887544212

Thanks for the suggestion.
Sorry I forgot to reread my previous question.


DPL-923 [Deprecated] Allow scRNA Core plates to enter existing 10X pipeline

User story
As a user of the scRNA Core pipeline, I would like the output plate of the cDNA Prep to be a possible input plate for the existing Chromium 5' Bespoke pipeline.
Who are the primary contacts for this story
Katy, Lesley, Abby
Who is the nominated tester for UAT
Lesley, Abby
Acceptance criteria
To be considered successful the solution must allow:

[ ] Final plate of scRNA Core cDNA Prep pipeline (output plate of https://github.com/sanger/limber/issues/1395) is permissible as an input plate to the existing Chromium 5' Bespoke pipeline.
[ ] As part of UAT, the Chromium 5' Bespoke pipeline should be tested thoroughly with this plate as an input plate, to find out any issues.

This is made obsolete by https://github.com/sanger/limber/issues/1444, because we decided to duplicate the pipeline rather than use the existing one.


Pickle instead of dumping JSONs

While dumping JSONs is great, it's really annoying having to constantly decode bytes and use base64 encoding. Using pickling instead will reduce the overhead since you can write binary to a pickle file just fine.

Changed as of this commit. Already seems to be retrieving data from the cache faster.


Cleanup #4077

@DylannCordel Eh eh, using internals quickly backfired :) The _perm_cache has been changed in 1.8+ This PR fix the test

It was very likely ^_^
I looked your formating cleanups : I'll pay more attention to this next time.

@DylannCordel I made the cleanups only because Django 1.8 required me to tune this


db: addition of versioning support

Adds SQLAlchemy-Continuum support to Invenio-DB for
versioning support.

Signed-off-by: Sami Hiltunen<EMAIL_ADDRESS>

see also https://github.com/inveniosoftware/invenio-db/issues/24

Closing as most of the changes have been merged in with #25.


KYLIN-5086, fix query pushdown with agg func without alias get an emp…

…ty appearance
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Github Branch
As most of the development works are on Kylin 4, we need to switch it as main branch. Apache Kylin community changes the branch settings on Github since 2021-08-04 :

The original branch kylin-on-parquet-v2 for Kylin 4.X (Parquet Storage) has been renamed to branch main, and configured as the default branch;
The original branch master for Kylin 3.X (HBase Storage) has been renamed to branch kylin3 ;

Please check Intro to Kylin 4 architecture and INFRA-22166 if you are interested.
Types of changes
What types of changes does your code introduce to Kylin?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[x] I have create an issue on Kylin's jira, and have described the bug/feature there in detail
[ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
[ ] Compiling and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged

Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin or dev@kylin by explaining why you chose the solution you did and what alternatives you considered, etc...

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@b4c857e). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1745   +/-   ##
=======================================
  Coverage        ?   24.65%
  Complexity      ?     4450
=======================================
  Files           ?     1092
  Lines           ?    61940
  Branches        ?     8903
=======================================
  Hits            ?    15269
  Misses          ?    45060
  Partials        ?     1611

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4c857e...0195781. Read the comment docs.


Responsive lobby

wip: Using mediaquery to make lobby responsive
wip: Change size, added nametags and kick button

feat: Bookplayerlist kick button + onKick and isKickable props + nametag
feat: Lobby page components placement changes on mobile

feat: Lobby is now responsive !

add: "badge/button" to display if player is owner or kick button
rem: avatar is no longer a button and has been set on the badge

CLOSE #175
Desktop lobby (unchanged)

Mobile lobby

Ton composant est cassé pour desktop !!!!

Fixé.


Attempting to loadData for grid2 from rowClick event of grid1

The second grid not populated: it just say Please, wait...  my data is actually an array of objects:
e.g. data = [Object, Object, Object ,Object]
$("#myGrid").jsGrid({
rowClick: function (args) {

            if (checkBoxField.checked === false) {
                checkBoxField.checked = true;
                populateEquipmentGrid(args); // populate other jsGrid
                // store selected item to array
                selectedItems.push(args.item);
            }
}
});

function populateEquipmentGrid(args) {
        // Populate the Equipment List
        var id = args.item.RequestID;

        $("#myOtherGrid").jsGrid("loadData",
             $.ajax({
                 type: 'GET',
                 contentType: "application/json; charset=utf-8",
                 url: getEquipmentBaseUrl() + "GetDataByID?RequestID=" + id,
                 dataType: "json"
             })
        );
    }

This is also resolved the issue was NOT with jsgrid it was with my code.  If you get a Please, wait... when loading data, there most likely another js error somewhere on the page.

loadData is a method of jsGrid.
In the child grid config for option controller.loadData should be provided a function that will return the ajax call results.
The row click handler should call loadData method of the grid, so it will reload.


Fix Small Errors in Implement Script Caches Commit

Imports cache file changed to ".json" instead of ".list"

@coderabhishek Can you make this PR against master?


[Table] Growing column width should not shrink next column

What package is this for?

[x] React
[ ] Angular

Summary
Please describe your request in one or two sentences.
When a table column is resized larger it shrinks the width of the next column. That is, the total width of the table never changes. This make it almost impossible for the user to get the columns to comfortable widths: fixing one destroys another. This is unlike most complicated tables, see Windows Explore details view, macOS Finder list view, Excel or any spreadsheet.
I can imagine some UIs with limited table space that might prefer the current pattern (possibly if there are only two columns in a small area), so the current pattern might need to be preserved (a prop to pick?). But the current pattern is unusable in most places in the ELM suite where many columns can be added to table and horizontal scrolling is OK. In many cases user can define their own columns, so the system has no idea what's a good size for their data. The user can just add some columns, look at them visually and resize them. But that's close to impossible with the current pattern.
Closely related to this is that the last column can't be resized "to the right" at all, unlike other columns. That means you can try to ripple the size changes manually from left to right, but once you hit the last column it will likely be tiny with no where to grow.
Specific timeline issues / requests
Needed for work in ELM 7.0.3 release. Probably by June. We may have limited table adoption in this release, but this will eventually become a blocking issue.
Available extra resources
Unclear. I've looked at the resize code, but may not have any time to allocate to this.

Closing this as a duplicate of #2471, and similar to #2460. We will be adding a property to the table that adds support for both horizontal scrolling and column resize.


Handle precedence and associativity in the generated C++ code

Make sure we use parenthesis whenever it makes sense to implement precedence and associativity rules for C++.
Fixes #308

Bad base of pr


Go v1.23

What is not working as expected?
Since Golang has released v1.23, we should follow the latest version for CLI and update the notation-go and notation-core-go to v1.22
What did you expect to happen?
Latest Golang version should be used.
How can we reproduce it?
No
Describe your environment
No
What is the version of your Notation CLI or Notation Library?
V1.2.0-rc.1

Notation-core-go updated to Go v1.22 in https://github.com/notaryproject/notation-core-go/pull/224
Notation-go updated to Go v1.22 in https://github.com/notaryproject/notation-go/pull/440
Notation updated to Go v1.23 in https://github.com/notaryproject/notation/pull/1019

We can close this issue now.


More transform steps might be needed to get this working

When I went through this process, I needed to update all of the CSV column types from text to numeric and decimal. Then after running the Python script, I was left with two datasets and I needed to select the final one prior to closing and applying my changes. Maybe add a note about filtering the Day range too, so that the visuals match...

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fdd46971-2ea5-9271-3b2a-824efc1821e1
Version Independent ID: 68669cdb-5e4d-bb96-d2d5-bdad4088fb03
Content: Using Python in Power BI Query Editor - Power BI
Content Source: powerbi-docs/desktop-python-in-query-editor.md
Service: powerbi
Sub-service: powerbi-desktop
GitHub Login: @otarb
Microsoft Alias: otarb

How are you reading csv? PowerQuery should auto-detect types based on top 200 rows by default. There is an option to change it to use complete dataset, or disable type detection altogether.
There are two datasets because there are two variables defined in Python, that is expected.

#please-close @otarb


Sorting, dates, itemTemplate

Hi
I’m using data from a JSON feed to populate a grid.
The date fields come back in this format: “December, 17 2014 00:00:00”
If I feed that date string into one of the grid fields like below the column is sortable:
fields: [
{ name: "VOTE_VOTEDATE", title: "Date1", type: "date"},
. . .
]
However, I want to format the date so instead I convert the field to an itemTemplate, like this:
fields: [
{
itemTemplate: function(value, item) {
dtDate = new Date(item.VOTE_VOTEDATE);
return $.format.date(dtDate, "dd MMMM yyyy");
}
, title: "Date3"
, type: "date"
}
. . .
]
Now the date is nicely formatted but the column is no longer sortable.
How do I get the second version to sort?

Just a note, JsGrid doesn't have a built in field type of "date", so you may want to implement that if you expect to be working with dates.
However, you can add a sorter function directly to the field definition:
fields[ { name: "myDate", title: "Birthday", type: "text", sorter: function(d1, d2) {                 var date1 = new Date(d1).getTime();                 var date2 = new Date(d2).getTime();                 return (date1>date2)-(date1<date2);               } } ]
Please see this codepen for a working example.

Hi RichRaid
Thanks for the help. My final field therefore looks like this, and it now sorts correctly:
{
name: "VOTE_VOTEDATE",
title: "Date",
type: "text",
align: "right",
itemTemplate: function(value, item) {
dtDate = new Date(item.VOTE_VOTEDATE);
return $.format.date(dtDate, "dd MMMM yyyy");
},
sorter: function(d1, d2) {
var date1 = new Date(d1).getTime();
var date2 = new Date(d2).getTime();
return (date1>date2)-(date1<date2);
}
},
Just one more small problem. By adding the 'align' property, the content now aligns right, which is cool. However, the column header now aligns in the center (previously it was on the left). How do I get it to also align on the right?

@Junglefish That actually seems like intended behavior from a code standpoint. The theme.css ensures that the headers of the table always remains centered. Maybe @tabalinas could explain if this is intentional or or not?
As a quick fix, you could custom css to the field for the header:
{
      headercss: "force-right",
}

then use a rule to force it:
tr.jsgrid-header-row th.force-right {
  text-align: right;
}

Hi RichRaid
That's a perfect solution, and also helps me to understand a bit more the way jsGrid can be configured.
Thanks again.

@richraid21, yes centered headers is the default js-grid theme, but it doesn't mean that it cannot be changed. This is css rules that can be overridden according to particular UI design requirements.