Improve rendering stories in different contexts

Feature Description
As previously discussed, we need to ensure stories are displayed appropriately on the WordPress site depending on the context.

Context
web-story post type
Embed Block

Single Story
Full AMP HTML markup
N/A

Rest of website
amp-story-player
amp-story-player

Rest of website (AMP)
amp-story-player
amp-story-player

RSS Feed
poster image
poster image

Alternatives Considered

Additional Context

Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria

Implementation Brief

Create new namespace Google\Web_Stories\Story_Renderer
Move Story_Renderer class to this new namespace.
Create a new class called Story. This will a representation of stories in PHP. It will map to many fields, found in WP_Post but will also not include unnecessary fields like parent id etc. The constructor of this class will take an arg to populate properties. It will also have a public method, called load_from_post that takes int, WP_Posts and will popular fields from post object.

Fields in the object would look like this.

Field
Type
Use
Default

URL
URL ( string )
All renders
''

Title
string
All renders
''

Markup
string
Full render
''

Poster Portrait
String
All renders
null

Poster Landscape
String
Full render
null

Poster Square
String
Full render
null

Story_Renderer class will changed to pass Story object, instead of WP_Post. Rename to class to HTML
New class added to Renderer namespace, called HTML_Simple_Preview. This will accept a Story object. render_block_feed logic will moved to new pass. HTML markup will moved to template file.
New class added to Renderer namespace, called HTML_Preview. This will accept a Story object, height int, width int and align string params. render_block_html logic will moved to new class. HTML markup will moved to template file.
Implement HTML_Preview class in the prefill_post_content method.
Filter the_content to use HTML_Preview for story post types on the archive / search pages. See https://github.com/google/web-stories-wp/issues/3166
Filter the_content_feed to use HTML_Simple_Preview for story post types on the feeds. See https://github.com/google/web-stories-wp/pull/3260

POC.

@spacedmonkey Can you perhaps clarify a bit on the Story class's constructor and how that class would work for the embed block?

@swissspidy Updated the IB.

I another option, is a little cleaner, is leave Story_Renderer as is. Story render isn't exactly same as two other kinds of render, the fields don't completely map.

Some thoughts:

We need a better name for Feed - maybe Static_Preview? As it displays a simple link (with poster if available)
I don't think Width/Height/Align should be part of the Story object. Seems more like a concern of the HTML_Preview renderer.  Example:

$story = new Story(...) // pass url, title, poster, etc.)
$renderer = new HTML_Preview( $story );
$renderer->render( 360, 600, 'right' );
$renderer->render( 360, 600, 'left' );

@spacedmonkey & @swissspidy  to align on the IB and validate the 5 pt estimate.

I have added a POC to better explain this change. Can you take a look @swissspidy ?

Thanks for the POC, very helpful.
Some changes I'd like to see:
IMHO Story should be immutable, i.e. no public properties, but getters instead: get_title(), get_markup(),get_url(), get_poster( $orientation ). Also the constructor must be more strict and not just allowing any arbitrary input like the current foreach ( get_object_vars( $story ) as $key => $value ) {} approach.
I suppose some details like names we can discuss during implementation, but HTML_Simple_Preview is not very descriptive.  Static/Dynamic would be better terms to distinguish the two previews.
Also, I am sure we'll have some back and forth about the preferred API once all renderers are implemented, so I want to make sure we account for this in the estimate.

IMHO Story should be immutable, i.e. no public properties, but getters instead: get_title(), get_markup(),get_url(), get_poster( $orientation ).

These are just implementation details are easily change. Don't think we need to discuss these now.

Also the constructor must be more strict and not just allowing any arbitrary input like the current foreach ( get_object_vars( $story ) as $key => $value ) {} approach.

No, if that is the case then this object will not work. A story can be created from attributes on a block that do not map to a post. Arbitrary input is by design here.

Static/Dynamic would be better terms to distinguish the two previews.
Neither of them are static, as they are generated from database. So static is also bad IMO. Would image / embed be better? That is what they are embedded player and poster image preview.

So are you happy for me to keep working on the POC and move this to in progress @swissspidy ?

No, if that is the case then this object will not work. A story can be created from attributes on a block that do not map to a post. Arbitrary input is by design here.

Then you must use property_exists() to ensure the input attribute maps to an actual class property. Otherwise I can pass an object like { foo => 'bar'} to the class.

Neither of them are static, as they are generated from database.

Static in terms of the actual preview is static (image) or dynamic (JavaScript) player. But yeah maybe image/embed is better.

So are you happy for me to keep working on the POC

Sure, let's get started and discuss the details on the PR


New role: edpm_prepare

This role wraps all of the preparation steps/make targets in order to
get the dataplane ready for the actual EDPM deployment.
The goal here is to make a modular role, calling the install_yamls_makes
tasks in a way we may toggle various switches, or even inject operators
early in the game.
This PR has:

[ ] Appropriate testing (molecule, python unit tests)
[ ] Appropriate documentation (README in the role, main README is up-to-date)

recheck

@cjeanner The molecule job parent is base-minimal. The default timeout of base-minimal job is 1800 sec  but the job is taking more than default timeout. We might want to increase the timeout to 3600.
Add timeout: 3600 here https://github.com/openstack-k8s-operators/ci-framework/blob/main/zuul.d/jobs.yaml#LL4C25-L4C25.
It will fix the timeout issue may be.

/lgtm Great job!

/unhold


Settings - set to off

Hi and Happy New Year !
Most of DL setting reset to ON after re-login or using a mobile app.
Can you add them and make them stay OFF ?
i.e. remember user choice and override default web / mobile setting
Thanks

Yeah its annoying, is this is a bug from Duolingos site?


Prevent Expo.Components namespace deprecation warning

I started a fresh project and got this warning:
Components under `Expo.Components` have been moved to the root `Expo` namespace. For example, `Expo.Components.Video` is now `Expo.Video`. The `Expo.Components` namespace is now deprecated and will be removed in version 17.0.0 of 'expo'.

I've made some changes that I think will fix the error but I wasn't able to link to my local version of react-native-scripts to test it.

Thanks! Will test momentarily and do a release.


Contribute Solution for LeetCode October Day 12

Day 12:
Contribute a solution for this day's LeetCode problem.
Rules:

Comment on this issue if you're willing to contribute.
Each user can contribute a maximum of 1 solution in Java, C++, or Python.
Each user can contribute a maximum of 2 solutions in other languages like JavaScript, Go, Ruby, etc.
Please ensure that no one has already commented for the language you're planning to contribute in.

Good luck and happy coding! :tada: :rocket:

Hi! @arya2004, I would like to contribute in C++, I have more than 200 active days in Leetcode, please assign this issue to me.

Hi @arya2004 / @Abhinav771 , I have raised PR #67 for 12th day solution in java. Could you please have a look 👀?

hi @arya2004 I would like to contribute to this in python

hi @arya2004 I would like to contribute to this in python

Hi @arya2004 , I have raised a PR #71 for the day 12 solution in Python. Can you have a look?


feat: react web view cookies

This PR contributes towards CX-436
Description
This PR adds user authentication for react-native-webview web views.
It does that by setting up shared cookies between fetch and webkit by making HEAD fetch  requests to force and prediction, including the user's access token in the x-access-token header. It does this whenever the access token changes, and we also clear the app's cookies when the user logs out.
iOS
https://user-images.githubusercontent.com/1242537/112020112-ff692b80-8b27-11eb-8ab1-499b75374ff4.mp4
Android
https://user-images.githubusercontent.com/1242537/112020157-03954900-8b28-11eb-9ea4-5ee5c1cf768a.mp4
PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a CHANGELOG.yml entry or my changes do not require one.

nice solution!


As an unregistered user, I want to be able to register as a user with username and password

Story
As an unregistered user, I want to be able to register as a user with my chosen credentials (i.e., username and password that are both not empty words).
Acceptance criteria

[x] sopra-fs24-group-27/sopra-fs24-group-27-server#69

[ ] sopra-fs24-group-27/sopra-fs24-group-27-client#19

[x] sopra-fs24-group-27/sopra-fs24-group-27-server#70

Priority
Critical
Estimate
4-8 h

This issue in server side has been addressed in commit 80ae5c8bbeb11d1a4843d25b4de672d7ed408d9f.

Completed with client 7188c6d5eff05bfdf90a08797133794e6f4e8645 and server 80ae5c8bbeb11d1a4843d25b4de672d7ed408d9f

completed with commit 9781848a0b6e6b96a0c9585363b348d409a85b22


Bad build of ghc version 8.10.2 for latest on windows ?

https://gitlab.haskell.org/ghc/ghc/-/issues/18550#note_309996
I hit this in trying to include a windows code path in my ci matrix.  It looks like an update is needed on your side?
I initially thought it was a library issue https://github.com/RyanGlScott/code-page/issues/4#issuecomment-730306015 but it seems more foundational

looks like by specifying <IP_ADDRESS> it just passes stuff through to the windows chocolatey pkg manager and just works .. https://github.com/cartazio/ralist/runs/1426458738?check_suite_focus=true#step:3:10


Compatibility with Stheno DerivedGPs (or similar)?

Hello, I love this project and your related Juliacon presentation. I was playing around and notice I am able to construct GPODEFunctions from PosteriorGPs, but the moment that I wrap that posteriorGP in a Stheno atomic() constructor I am no longer able to make a GPODEFunction. This is in spite of the fact that at this point it is identical to the original GP, just with an additional bookeeping GPC() object. Would there be much required to build in Stheno compatibility?
For context, my original intention was to use your pullEuler solver on a Stheno DerivedGP to get a feel for how uncertainty propagates. Alternately, I wonder if perhaps the functionality already exists in some manner not requiring Stheno and I'm missing it. Specifically, is there a way to use this package in the context of universal differential equations where the GP supplies some of the terms but other terms are mechanistic? This could include non-additive interactions, for instance dx = (a + NN(x))*x. I was using Stheno for these, but maybe there is a way to implement this using just AbstractGPs in a way that plays well with your work.

Hey, very glad that you like this project. It is still very much work in progress, and for now I just did some naive implementation, as a few interfaces with AbstractGPs already need wrappers to make them work.
I will have a look at Stheno, and what might be missing.
Your context is one that I am also very interested in, but have not had time to explore. For additional terms, I think that this should be done via the GP mean function, so instead of a zero mean, use a custom mean function of the existing terms. That needs to be researched and considered in more detail though.
The example you give is much more interesting, because in an expression like $a+GP(x))*x$ you now get the product of $GP(x)$ and $x$, both of which will be random variables (in the PULL solver setting).
The issue here is that the product of random variables becomes immediately very complicated, even in the case where both factors are normally distributed.
I would be happy to have a chat about this if you would like.

In the multiplicative case, I didn't think about the implications of x becoming a random variable itself as you step through the ODE. So this is less a compatibility issue than an open research question.
I was referencing this type of DerivedGP in Stheno: https://juliagaussianprocesses.github.io/Stheno.jl/stable/internals/#Multiplication
But as they note it only works if x is not itself a random variable, which becomes untrue after a single timestep.
For the simpler additive case implemented via a non-zero mean function, you are thinking this is still tricky? In other words, though I haven't tried this yet, let's say I provide an abstractGP with non-zero mean to the GPODEFunc and the code happens to work--I should not blindly trust the result.

I think the additive case with the custom mean function is the correct way, but I have no evidence for this, just some intuition. I think that should give some decent results, and if you try it I would be very curious.
I will also be adding a sampling -based method as a (much) more computationally expensive, but probably more reliable, way way to get the empirical distribution of the trajectories, that can also be used for comparison.

Definitely, I will try to make some time to explore and share whatever I find with you.
A more rigorous sampling method/baseline also sounds great, particularly for more complex cases like the multiplicative scenario. Looking forward to it!
Thanks again for all the interesting work you're putting into the package.

Hey, just a quick follow-up/confirmation: is the pullEuler solver just for single-output GPs at the moment? I noticed that your spiralODE example, which is multi-output, calls outdated code that just propagates the mean. On the other hand when I follow the gpode example instead I get an error about the initial condition: "MethodError: Cannot convert an object of type Vector{Float64} to an object of type Measurement{Float64}". This seems pretty clear-cut, but I wanted to double-check in case I'm mistaken.

Hey, this current version only works for 1D (as multi-dim is not quite so easy as I initially thought, essentially order of multiplication "suddenly" matters).
I am right at this moment working out what will hopefully be the last issues, then add tests and update the example.

@brendanwallison My apologies, it took a bit longer than expected. The PULLEuler now also works for higher dimensions, and the sampling methods are there, but not properly documented yet.


Feature Request: return PDF text indexed to page/line numbers (in a map or hash?)

Looking here:
https://pdfgrep.org/doc.html
It would be great to have the power of Raku regexes to search through PDFs by page_# and/or line_#.
Meaning that PDF::Extract would have to record that data while extracting, either into an array or into a hash.
(You could also imagine a large PDF saved into a hash-of-arrays:  with page_# as key and each page's lines stored in an array as the value).
I recognize this feature request is highly dependent on Poppler's capabilities.
TIA.

Thanks @librasteve for taking a look. Unfortunately writing a PR is above my pay-grade since I don't know Poppler.
https://unix.stackexchange.com/questions/776585/how-to-search-in-a-pdf-or-text-file-by-a-regex-pattern-and-output-locations-of-m
Honestly I saw a StackExchange question above answered with the pdfgrep unix executable:  https://pdfgrep.org
I was hoping the Raku community had a ready-to-go alternative to pdfgrep (possibly a one-liner using your excellent  PDF::Extract module)? Maybe @dwarring and/or @tbrowder know a Raku solution using any of their excellent PDF modules?
Thanks.

Fwiw, I've avoided general text extraction. There's already plenty of mature solutions out there and also plenty of gnarly PDF files out there that are difficult to extract text on.
What I am targeting, is the small, but slowly increasing number of  tagged PDF files. There are designed to support structured content and text extraction. See PDF::Tags::Reader.
Hmm, a pdf-tag-grep utility script could be nice....

Btw, I notice that PDF::Extract has been integrated into App::Rak anyway.

@dwarring - this mini module came from a short deadline project where I needed to get the text from a PDF, and after a superficial look at the previous raku PDF modules, I was not able to quickly locate a solution ... yep, this just does the text and (as you say) I chose to simple wrap the ```poppler`` package ... I would encourage anyone with more elaborate needs to explore the many other fantastic raku PDF modules...

I see MacOS has an option to export PDFs as either "linearized PDF" or "PDF/A".
Maybe one of those might be helpful?


Revert "Refactor"

Reverts bebop/ark#83

"woops"

"woops"

got excited but forgot to see if tests would pass.


Fractional seconds in timestamp

It would be useful to have fractional seconds in the rx_time timestamp. Currently this is not directly possible, as C strftime doesn't support that.

What should the precision be? Hard-coded or adjustable? (Perhaps hard-coded 1/100 s is fine)
Should the fraction be its own format character, like %f? This would require some custom string formatting code.
Or should there be just a new command-line option to concatenate a fraction to the end of the timestamp? Or to format the whole timestamp in a hard-coded format familiar from RDS Spy?
Ideally, buffer delays should be taken into account and subtracted from the timestamp, because these can be 64 milliseconds at worst. We could use an end-of-buffer timestamp in the MPXBuffer objects and the read offset into that buffer upon complete reception of a group. (Of course we can't know anything about buffer delays external to redsea.)
An unexpected consequence: When MPX is being read from a source that is faster than its sample rate (e.g. a local file), this calculation will produce incorrect results. The timestamp can even end up referring to a time just before the program was started, and the timestamps won't be in monotonic order. Maybe a fast source could be automatically detected?
The timestamp should also be properly determined for hex or ASCII inputs. But that's more straightforward I think.
According to RDS specifications, the transmitted seconds-precision timestamp in group 4A refers to the end of the group, +/- 100 ms. So the rx_time should ideally also refer to the end of the group.

For reference, here's one way to calculate the fractional time itself: https://stackoverflow.com/questions/15845505/how-to-get-higher-precision-fractions-of-a-second-in-a-printout-of-current-tim

Initial results with the buffer timestamping are looking very nice:
$ airspy ... | csdr ... | redsea ... | grep clock_time

{"pi":"0x6203","rx_time":"18:57:59.99","group":"4A","clock_time":"2020-05-18T18:58:00+03:00","prog_type":"Varied","tp":true}
{"pi":"0x6203","rx_time":"18:58:59.99","group":"4A","clock_time":"2020-05-18T18:59:00+03:00","prog_type":"Varied","tp":true}
{"pi":"0x6203","rx_time":"18:59:59.99","group":"4A","clock_time":"2020-05-18T19:00:00+03:00","prog_type":"Varied","tp":true}
{"pi":"0x6203","rx_time":"19:00:59.96","group":"4A","clock_time":"2020-05-18T19:01:00+03:00","prog_type":"News","tp":true}
{"pi":"0x6203","rx_time":"19:01:59.96","group":"4A","clock_time":"2020-05-18T19:02:00+03:00","prog_type":"News","tp":true}
{"pi":"0x6203","rx_time":"19:02:59.96","group":"4A","clock_time":"2020-05-18T19:03:00+03:00","prog_type":"Varied","tp":true}
{"pi":"0x6203","rx_time":"19:04:00.03","group":"4A","clock_time":"2020-05-18T19:04:00+03:00","prog_type":"Varied","tp":true}
{"pi":"0x6203","rx_time":"19:05:00.03","group":"4A","clock_time":"2020-05-18T19:05:00+03:00","prog_type":"Varied","tp":true}
{"pi":"0x6203","rx_time":"19:06:00.02","group":"4A","clock_time":"2020-05-18T19:06:00+03:00","prog_type":"Varied","tp":true}
{"pi":"0x6203","rx_time":"19:07:00.00","group":"4A","clock_time":"2020-05-18T19:07:00+03:00","prog_type":"Varied","tp":true}
{"pi":"0x6203","rx_time":"19:08:00.00","group":"4A","clock_time":"2020-05-18T19:08:00+03:00","prog_type":"Varied","tp":true}

Very nice! Useful to measure delays in upstream transport chain, apart for
verification of the clock accuracy. Audemat has had some very interesting
clock sync with +- 2-3 secs..
// David
On Mon, May 18, 2020 at 6:10 PM Oona Räisänen<EMAIL_ADDRESS>wrote:

Initial results with the buffer timestamping are looking very nice:
$ airspy ... | csdr ... | redsea ... | grep clock_time
{"pi":"0x6203","rx_time":"18:57:59.99","group":"4A","clock_time":"2020-05-18T18:58:00+03:00","prog_type":"Varied","tp":true}
{"pi":"0x6203","rx_time":"18:58:59.99","group":"4A","clock_time":"2020-05-18T18:59:00+03:00","prog_type":"Varied","tp":true}
{"pi":"0x6203","rx_time":"18:59:59.99","group":"4A","clock_time":"2020-05-18T19:00:00+03:00","prog_type":"Varied","tp":true}
{"pi":"0x6203","rx_time":"19:00:59.96","group":"4A","clock_time":"2020-05-18T19:01:00+03:00","prog_type":"News","tp":true}
{"pi":"0x6203","rx_time":"19:01:59.96","group":"4A","clock_time":"2020-05-18T19:02:00+03:00","prog_type":"News","tp":true}
{"pi":"0x6203","rx_time":"19:02:59.96","group":"4A","clock_time":"2020-05-18T19:03:00+03:00","prog_type":"Varied","tp":true}
{"pi":"0x6203","rx_time":"19:04:00.03","group":"4A","clock_time":"2020-05-18T19:04:00+03:00","prog_type":"Varied","tp":true}
{"pi":"0x6203","rx_time":"19:05:00.03","group":"4A","clock_time":"2020-05-18T19:05:00+03:00","prog_type":"Varied","tp":true}
{"pi":"0x6203","rx_time":"19:06:00.02","group":"4A","clock_time":"2020-05-18T19:06:00+03:00","prog_type":"Varied","tp":true}
{"pi":"0x6203","rx_time":"19:07:00.00","group":"4A","clock_time":"2020-05-18T19:07:00+03:00","prog_type":"Varied","tp":true}
{"pi":"0x6203","rx_time":"19:08:00.00","group":"4A","clock_time":"2020-05-18T19:08:00+03:00","prog_type":"Varied","tp":true}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/windytan/redsea/issues/70#issuecomment-630285669, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AELU6KIWAHPKAYR62GQ5MDTRSFMXXANCNFSM4ND3YWOA
.


memory managment

Do I need to explicitly free the memory created by calling memory() ?

Hi,
If you use C++ API and create memory just by memory primitive_descriptor, than MKL-DNN will allocate the memory and you should not worry about its deallocation -- MKL-DNN will take care of it. If you create memory via memory(memory_primitive_desc, void *handle), then it is your responsibility to clean-up the handle.
C API doesn't do allocation/deallocation, so you have to use manage the raw memory your self, and set it via mkldnn_memory_set_data_handle().


Found a security issue

Found a security issue. How can I report it?

Please email<EMAIL_ADDRESS>with more information. Thank you.


#pragma message will never be printed

#warning works, but I assume #pragma message goes to stdout which is consumed by mbed cli

ARM Internal Ref: MBOTRIAGE-1485

Can you provide examples, what works and what does not?  What toolchains?
#pragma message string - this one? it's during compilation (is it only supported in GCC ?) so should not use stdout (its not runtime message).

gcc 7.0.0 and gcc 7.1.0
works:
#warning foo bar

does not:
#pragma message("foo bar")
#pragma message(foo bar)

@drahnr those messages show up with -v. without the verbose option, the mbed build tools try to limit the amount of terminal noise you get to just warnings and errors. This is by design.

The issue with -v is, that one gets flooded with compiler defines / commandine options so the desired effect of a message is either being lost in too much information or not printed at all.
Use case: Easy tracking of certain important configuration options without the noise without generating warnings which would error our build.

@drahnr I'm a little shocked that you managed to find a target that does not emit warnings. We could parse the #pragma message stuff and emit it in the same way as warnings/errors. That would take a bit of work thought, as it would have to work for all 3 supported compilers.

@theotherjimmy it only works with compiling many chunks of the final application as libs, mbed-os itself is for sure not free of warnings...

@drahnr I think we could also implement a "filter warnings" feature if that would be useful to you. It would have to be for 5.10.

@theotherjimmy can you be a little more specific what exactly would be the your usecase? Right now I am not sure how that helps my case: I have a lib which has to be warning free -> filtering warnings won't change the output, or maybe I just did not get what you meant :]

@drahnr We could add a filter that ignores warnings within certain paths. So you could do something like mbed compile --no-warnings mbed-os and not get warnings from mbed-os.

@theotherjimmy Independent of above's discussion: That 'd be great!
The initial problem of not seeing #pragma messages is still there though, filtering warnings would only help if I would make them all warnings (which our compilation would prevent).

@drahnr I'll be happy to add something like "[INFO]" for messages, if we have a way to find them in all 3 compilers, and we can document how to use it.

Thank you for raising this issue. Please note we have updated our policies and
now only defects should be raised directly in GitHub. Going forward questions and
enhancements will be considered in our forums, https://forums.mbed.com/ . If this
issue is still relevant please re-raise it there.
This GitHub issue will now be closed.


Add: channel visualization

multichannel data quality visualization code

addressed the following:

replaced the advance_plot_color function I accidentally deleted
added tests for the channel plots
added an example to the docs source image directory ('channel_profile_example.png')


Add-PowerBIWorkspaceUser BadRequest when AccessRight is Member or Contributor

Hello,
When I try to add a user to a workspace with the command:
Add-PowerBIWorkspaceUser -Id [id] -UserEmailAddress [emailaddress] -AccessRight Member
or:
Add-PowerBIWorkspaceUser -Id [id] -UserEmailAddress [emailaddress] -AccessRight Contributor
I get the following error:
Add-PowerBIWorkspaceUser : Operation returned an invalid status code 'BadRequest'
At line:1 char:1

Add-PowerBIWorkspaceUser -Id ..... -Us ...

  + CategoryInfo          : WriteError: (Microsoft.Power...BIWorkspaceUser:AddPowerBIWorkspaceUser) [Add-PowerBIWorkspaceUser], HttpOperationException
  + FullyQualifiedErrorId : Operation returned an invalid status code 'BadRequest',Microsoft.PowerBI.Commands.Workspaces.AddPowerBIWorkspaceUser

The command works fine when I add the user as Admin. But I don't want the user to be Admin, I want to set the AccessRight to Member.
What is going wrong?
Thanks,
Marc

Any luck with this Marc? Getting the same issue.

This seems to be a limitation of the API (see https://docs.microsoft.com/en-us/rest/api/power-bi/groups/addgroupuser ).
However, for me this is urgently needed. Is there any workaround?

I am not sure if this will help you guys, but I ran into a similar situation and what I did was check for existing rights and then modify.
$thisWorkspace = Get-PowerBIWorkspace -Name "MyWorkSpaceName"

# Get Groups | https://docs.microsoft.com/en-us/rest/api/power-bi/groups/getgroupusers
$WorkSpaceUsers = Invoke-PowerBIRestMethod -Url "groups/$($thisWorkspace.Id)/users" -Method Get | ConvertFrom-Json

# Iterate/Handle/Process
$ExistingUser = $WorkSpaceUsers.value | Where-Object -Property identifier -EQ "UserNameOrGroupID"
if ( ! ($ExistingUser)) {
    # User Does Not Exists
}
else {
    # User Exists

    # Check User Permissions
    if (!($ExistingUser | Where-Object -Property groupUserAccessRight -EQ 'Permission')) {
        # Has Different Permission
        # Remove and Recreate

        Remove-PowerBIGroupUser -Id $thisWorkspace.Id  -UserPrincipalName $ExistingUser.identifier

        # Add-PowerBIWorkspaceUser ...
    }
}

Yeah, great, this worked smoothly, thanks a bunch.

I am not sure if this will help you guys, but I ran into a similar situation and what I did was check for existing rights and then modify.
$thisWorkspace = Get-PowerBIWorkspace -Name "MyWorkSpaceName"

# Get Groups | https://docs.microsoft.com/en-us/rest/api/power-bi/groups/getgroupusers
$WorkSpaceUsers = Invoke-PowerBIRestMethod -Url "groups/$($thisWorkspace.Id)/users" -Method Get | ConvertFrom-Json

# Iterate/Handle/Process
$ExistingUser = $WorkSpaceUsers.value | Where-Object -Property identifier -EQ "UserNameOrGroupID"
if ( ! ($ExistingUser)) {
    # User Does Not Exists
}
else {
    # User Exists

    # Check User Permissions
    if (!($ExistingUser | Where-Object -Property groupUserAccessRight -EQ 'Permission')) {
        # Has Different Permission
        # Remove and Recreate

        Remove-PowerBIGroupUser -Id $thisWorkspace.Id  -UserPrincipalName $ExistingUser.identifier

        # Add-PowerBIWorkspaceUser ...
    }
}

This solution helped me a lot today. Thank you very much. Hard to find some Power BI Power Shell scripts/applications nowadays.


what is the problem mean?

when I send data through kafka to elasticsearch and when I click jaeger Ui it show this
jaeger_1            | {"level":"error","ts":1560996832.9520793,"caller":"zap/logger.go:33","msg":"error when flushing the buffer: write udp <IP_ADDRESS>:54147-><IP_ADDRESS>:6831: write: connection refused","stacktrace":"github.com/jaegertracing/jaeger/vendor/github.com/uber/jaeger-client-go/log/zap.(*Logger).Error\n\t/home/travis/gopath/src/github.com/jaegertracing/jaeger/vendor/github.com/uber/jaeger-client-go/log/zap/logger.go:33\ngithub.com/jaegertracing/jaeger/vendor/github.com/uber/jaeger-client-go.(*remoteReporter).processQueue.func1\n\t/home/travis/gopath/src/github.com/jaegertracing/jaeger/vendor/github.com/uber/jaeger-client-go/reporter.go:257\ngithub.com/jaegertracing/jaeger/vendor/github.com/uber/jaeger-client-go.(*remoteReporter).processQueue\n\t/home/travis/gopath/src/github.com/jaegertracing/jaeger/vendor/github.com/uber/jaeger-client-go/reporter.go:267"}

jaeger-query itself is trying to send spans to local agent


Don't slink LoRAs when linking ckpts

The link_ckpts does not filter the Lora directory, yet this is the directory used to store Lora which are later properly linked. This change fix the function is Lora are properly ignored when linking checkpoints.

Duplicate #78


Added the option to show the title view in the items controller

I added the option to allow users to customise the view to show the title view in the items view controller so that it scrolls with the rest of the content. This is consistent with how Apple show's their "what's changed".
The main priority was to not break existing user's experience so the default mode is to keep the title in its sticky position as it stood prior to this pull request.
I did need to bump the swift lint file length by 10 in order to support the changes I added.
Please let me know if you require any changes as I'm just trying to help out the open-source community :)

Great work 👍
I will do some additional work on the feature/titleview-mode branch before merging it into the develop and master for a new release of WhatsNewKit.


Misc bugs on Brain Regions

Only have the cortical area name and remove “selected area”

￼

Bring back the dragging behavior of prior CB where when user drags the area/region, the pop up menu is not displayed

Exception when clicking on the cortical in 3D monitor

After creating a new custom cortical area it did not show up on CB

Cortical area 2D positions are being reset

Add a new OPU and connect an existing custom area to it, mapping does not show up unless Godot is restarted

Rename tooltip to “Add to brain region” then open region explorer let the user choose and existing region which will be majority of the case. At the bottom of the explorer add a button labeled “New Region” which would then open create new region.

These all seem to be fixed


no-raw-text fails for custom components (add ignore option?)

Problematic case with custom components:
const Title = ({ children }) => (
    <Text style={styles.title}>
        { children }
    </Text>
)
// Next line gets no-raw-text error!
const title = <Title>This is the title</Title>

Problematic case with jsx-control-statements:
<Text>
    <If condition={showText}>
        This is text. Real text.
    </If>
</Text>

Both these cases could be solved with a blacklist/ignore option for the no-raw-text rule. For example
"react-native/no-raw-text": ["error", { ignore: ['Title', 'If', 'Choose', 'When', 'Otherwise'] } ],

Added here https://github.com/Intellicode/eslint-plugin-react-native/pull/205, but called it as skip :)

@AleksandrZhukov made a release, thanks!

mb we can close this issue?

Looks good to me!


Fabiocav/httpbindingsource

Changes in this PR
This PR introduces the ability to map custom attributes to converters, and leverages that capability to introduce a new attribute FromBodyAttribute) in the HTTP extension, adding binding support for function parameters using the request body as the source (e.g., ability to bind, string, byte[], POCOs).
resolves #164
Pull request checklist

[ ] My changes do not require documentation changes

[ ] Otherwise: Documentation issue linked to PR

[ ] My changes should not be added to the release notes for the next release

[x] Otherwise: I've added my notes to release_notes.md

[x] My changes do not need to be backported to a previous version

[ ] Otherwise: Backport tracked by issue/PR #issue_or_pr

[x] I have added all required tests (Unit tests, E2E tests)

@mattchenderson this will require doc updates. It would be great to avoid blocking on that, so happy to create a separate item if can track this separately.


Devices disappearing because of wrong expireTime

Hi there,
First thanks for this great library.
I discovered an issue where devices disappear because of incorrect expireTime value. This value is set on object construction and is thus never updated when updateSsdpMessage is called with newer messages. It causes the device lost calculation to evict the device after the original expiry time has passed.
https://github.com/ohmae/mmupnp/blob/bb6696cc35d02059f4f019df4ea062b367ba05d0/mmupnp/src/main/java/net/mm2d/upnp/internal/impl/DeviceImpl.kt#L48
Modifying the property with a getter solves the issue:
override val expireTime: Long
    get() = ssdpMessage.expireTime

I have not assessed impacts of this modification or checked if other properties of DeviceImpl suffer the same issue.
Thank in advance.

Hi,
As you pointed out, that's a bug. I've fixed it(https://github.com/ohmae/mmupnp/commit/cd63dd6ed87b6157822c41720411dc8b7b60a7c9) and released 3.1.2.
Thank you!

Hi,
Thanks for correcting this quickly. It works in the new version.
Best regards.


Codepen Example for mid-line truncation has errors

There are alignment issues in the codepen example here.
Should this be removed or updated for v10?
https://next.carbondesignsystem.com/patterns/overflow-content#mid-line-truncation

@alisonjoseph This isn't high priority but still shows broken on the site. Should I remove this example in the meantime?

I can fix this today


How to load multiple files with one VM

I have 2 scripts:
foo.be:
def test()
  print("foo")
end

bar.be:
def test()
  print("bar")
end

On my laptop, I compile these scripts into bytecode:
berry -c foo.be -i foo.o
berry -c bar.be -i bar.o

On my MCU, I create one VM and load the byte code (not using the compiler on the MCU):
be_loadmode(vm, file, false)

I want to be able to call foo::test and bar::test from C code.
What's the proper approach?
For now I just create 2 VMs, but I imagine that's not the best approach.

You can't have two functions with the same global name and you should have 2 different names for both functions. There is no concept of namespace per se.
The good way to do this would be to create a module:
foo = module("foo")
foo.test = def()
  print("foo")
end

return foo

bar = module("bar")
bar.test = def()
  print("bar")
end

return bar

Then load with:
import foo
import bar

foo.test()
bar.test()

Understood. Thank you.


is TGI support sequence-parallel ？

Feature request
is TGI support sequence-parallel ？
Motivation
is TGI support sequence-parallel ？


Add validation success message

If the validate command returned a success message, then it help prevent users asking themselves, "Did it work?"
All validation tests passed. This appears to be a valid spec.
This could be a chance to have some fun with it, such as giving gold stars or telling them they look nice today, etc.

swagger-tools operates like all Unix commands should: No news is good news.  I tested a number of Node.js CLI tools to make sure I wasn't being to big a pedant and the ones I tried operate this way.  I'm going to close this but if you have some counterpoint that could sway me, I'll be happy to listen but I doubt it will matter.


MapView.Polygon onPress coordinate inaccurate

Hey guys
The MapView.Polygon onPress event with a polygon-press action has a coordinate which is one of the coordinates of the polygon, and not actually the coordinate of where the user clicked on the map.
Is this intended to work this way?

+1

+1

+1

Is it possible to ignore the polygon/line so no onclick from the polygon is processed instead the underlying maps onpress fires?


[NTR] monogenic and polygenic

Preferred term label:

monogenic
polygenic

Definition (free text, please give PubMed ID, if applicable, in format PMID:#######)

A characteristic of a disease in which the cause of the disease is a variation in a single gene.
A characteristic of a disease in which the cause of the disease is a variation in two or more genes.

Parent term (use OLS, or your favorite ontology browser)
MONDO_0021149 'genetic vs non-genetic etiology'

related to https://github.com/monarch-initiative/mondo/issues/2042

we decided we don't want to add these terms.


Problems using tutorials plugin

These are some problems I've encountered attempting to use the tutorials plugin in an external custom client.  Not all problems are specific to that use case.

[ ]  After an npm install of kui, if you start a shell with bin/kui shell, the tutorials don't work because the samples directory was not copied to the build.  This problem can be manually corrected by doing what I think should have been done by the npm install
[x]  If you run the webpack build of kui, the above problem doesn't happen but the tutorials plugin can appear broken because the list subcommand is not browser-friendly (attempts to use fs).   In fact, only listing is affected, but this is not a small issue (e.g., usage is broken as a result).
[ ]  The plugin is too monolithic for use in an external client.  If I include it using npm install, I can't add tutorials to it (well, I can, by copying them deep into the plugin under node_modules, but, really ...).   I don't think I should need to clone and own it in order to extend it.
[ ]  In creating new tutorial, I am hampered by the lack of documentation of the tutorial.json schema.  I am imitating bits and pieces of the existing tutorials but not always getting the expected results.

status update: 2 should be addressed by #1157

we have deprecated this plugin for now.


the stylesheet folder of  “css ”,load path is wrong

the stylesheet folder of  “css ”，load path is wrong
//wrong:
map: {
        '*': {
            'css': 'libs/css.min'
        }
    }

require("css!css/beeui.css");

//ok:
map: {
        '*': {
            'cssImport': 'libs/css.min'
        }
    }

require("cssImport!css/beeui.css");

I also noticed this issue. If you store your CSS files in a a folder called "css" while using a module prefix of "css", require-css will look for your css file relative to it (i.e. relative to the path of require-css) rather than relative to the page your script appears on. I renamed my "css" folder to "styles" for this reason.

I see the same issue too and using 'styles' instead of 'css' in the path.


Error Processing Schema - Custom Action

Describe the bug
Composer presents "Error Processing Schema" with the error message "Definition not found for
Microsoft.Ask/properties/activity/oneOf/1/properties/membersAdded/items"
This message is displayed on each switch to the left side menu "Design", "Bot Responses", "User Input" and "QnA".
The message is displayed on the first open of each of those menues after startup of composer, but upon going to "Home", it's only displayed on the first accessed menu, until going back to home and to another menu.
Version
V1.1.1
Browser

[X] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[X] Windows
[ ] Ubuntu
(On ubuntu, I couldn't get the schema merge script to work)

To Reproduce
Steps to reproduce the behavior:
Follow the steps given in https://docs.microsoft.com/en-us/composer/how-to-add-custom-action, to enable MultiplyDialog.
Open Composer.
Error is presented.
Expected behavior
MultiplyDialog working with no error messages.
Additional context
The schema merge seems to be working fine. But I am getting a lot of warnings on the build.
The MultiplyDialog is working, the only problem is the error message itself, as far as I can see.
PS C:\Users\Albin\Pum\deploy\rostbot\schemas> ./update-schema.ps1 -runtime azurewebapp                                                                                Running schema merge on azurewebapp runtime.                                                                                Finding component files                                                                                Parsing component .schema files                                                                                Merging component schemas                                                                                Verifying schema                                                                                Writing sdk.schema                                                                                Merging component .uischema files                                                                                Writing sdk.uischema                                                                                Copying C# package assets to generated                                                                                Schema merged succesfully.                                                                                Schema:    sdk.schema                                                                                UI Schema: sdk.uischema
PS C:\Users\Albin\Pum\deploy\rostbot\runtime> dotnet build                                                                                Microsoft (R) Build Engine version 16.7.0+7fb82e5b2 for .NET                                                                                Copyright (C) Microsoft Corporation. All rights reserved.                                                                                Determining projects to restore...                                                                                C:\Users\Albin\Pum\deploy\rostbot\runtime\azurefunctions\Microsoft.BotFramework.Composer.Functions.csproj : warning NU1701: Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible with your project. [C:\Users\Albin\Pum\deploy\rostbot\runtime\ComposerRuntime.sln]                                                                                C:\Users\Albin\Pum\deploy\rostbot\runtime\tests\Microsoft.BotFramework.Composer.Tests.csproj : warning NU1701: Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible with your project. [C:\Users\Albin\Pum\deploy\rostbot\runtime\ComposerRuntime.sln]                                                                                C:\Users\Albin\Pum\deploy\rostbot\runtime\azurewebapp\Microsoft.BotFramework.Composer.WebApp.csproj : warning NU1701: Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible with your project. [C:\Users\Albin\Pum\deploy\rostbot\runtime\ComposerRuntime.sln]                                                                                C:\Users\Albin\Pum\deploy\rostbot\runtime\core\Microsoft.BotFramework.Composer.Core.csproj : warning NU1701: Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project. [C:\Users\Albin\Pum\deploy\rostbot\runtime\ComposerRuntime.sln]                                                                                All projects are up-to-date for restore.                                                                                C:\Users\Albin\Pum\deploy\rostbot\runtime\core\Microsoft.BotFramework.Composer.Core.csproj : warning NU1701: Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project.                                                         C:\Users\Albin\Pum\deploy\rostbot\runtime\tests\Microsoft.BotFramework.Composer.Tests.csproj : warning NU1701: Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible with your project.                                                        C:\Users\Albin\Pum\deploy\rostbot\runtime\azurefunctions\Microsoft.BotFramework.Composer.Functions.csproj : warning NU1701: Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible with your project.                                             Microsoft.BotFramework.Composer.Core -> C:\Users\Albin\Pum\deploy\rostbot\runtime\core\bin\Debug\netstandard2.0\Microsoft.BotFramework.Composer.Core.dll                                                                                Microsoft.BotFramework.Composer.CustomAction -> C:\Users\Albin\Pum\deploy\rostbot\runtime\customaction\bin\Debug\netcoreapp3.1\Microsoft.BotFramework.Composer.CustomAction.dll                                                                                C:\Users\Albin\Pum\deploy\rostbot\runtime\azurewebapp\Microsoft.BotFramework.Composer.WebApp.csproj : warning NU1701: Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible with your project.                                                   Microsoft.BotFramework.Composer.Functions -> C:\Users\Albin\Pum\deploy\rostbot\runtime\azurefunctions\bin\Debug\netcoreapp3.1\bin\Microsoft.BotFramework.Composer.Functions.dll                                                                                Microsoft.BotFramework.Composer.WebApp -> C:\Users\Albin\Pum\deploy\rostbot\runtime\azurewebapp\bin\Debug\netcoreapp3.1\Microsoft.BotFramework.Composer.WebApp.dll                                                                                Microsoft.BotFramework.Composer.Tests -> C:\Users\Albin\Pum\deploy\rostbot\runtime\tests\bin\Debug\netcoreapp3.1\Microsoft.BotFramework.Composer.Tests.dll                                                                                Build succeeded.                                                                                C:\Users\Albin\Pum\deploy\rostbot\runtime\azurefunctions\Microsoft.BotFramework.Composer.Functions.csproj : warning NU1701: Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible with your project. [C:\Users\Albin\Pum\deploy\rostbot\runtime\ComposerRuntime.sln]                                                                                C:\Users\Albin\Pum\deploy\rostbot\runtime\tests\Microsoft.BotFramework.Composer.Tests.csproj : warning NU1701: Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible with your project. [C:\Users\Albin\Pum\deploy\rostbot\runtime\ComposerRuntime.sln]                                                                                C:\Users\Albin\Pum\deploy\rostbot\runtime\azurewebapp\Microsoft.BotFramework.Composer.WebApp.csproj : warning NU1701: Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible with your project. [C:\Users\Albin\Pum\deploy\rostbot\runtime\ComposerRuntime.sln]                                                                                C:\Users\Albin\Pum\deploy\rostbot\runtime\core\Microsoft.BotFramework.Composer.Core.csproj : warning NU1701: Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project. [C:\Users\Albin\Pum\deploy\rostbot\runtime\ComposerRuntime.sln]                                                                                C:\Users\Albin\Pum\deploy\rostbot\runtime\core\Microsoft.BotFramework.Composer.Core.csproj : warning NU1701: Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project.                                                         C:\Users\Albin\Pum\deploy\rostbot\runtime\tests\Microsoft.BotFramework.Composer.Tests.csproj : warning NU1701: Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible with your project.                                                        C:\Users\Albin\Pum\deploy\rostbot\runtime\azurefunctions\Microsoft.BotFramework.Composer.Functions.csproj : warning NU1701: Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible with your project.                                           C:\Users\Albin\Pum\deploy\rostbot\runtime\azurewebapp\Microsoft.BotFramework.Composer.WebApp.csproj : warning NU1701: Package 'Microsoft.Azure.KeyVault.Core 1.0.0' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8' instead of the project target framework '.NETCoreApp,Version=v3.1'. This package may not be fully compatible with your project.                                                     8 Warning(s)                                                                                0 Error(s)                                                                                Time Elapsed 00:00:01.15

Worth mentioning is that I have tried by replacing the $schema to https://schemas.botframework.com/schemas/component/v1.0/component.schema on all places where it previously was "$schema": "https://raw.githubusercontent.com/microsoft/botframework-sdk/master/schemas/component/component.schema"

@Laktos what version of the botframework cli are you using?
~/src/BotFramework-Composer/Composer (main) $ bf
Update available
     Run
npm i -g @microsoft/botframework-cli
One-stop-shop CLI to manage your bot’s resources. BF CLI and AZ CLI together cover your end-to-end bot development workflow needs.

VERSION
  @microsoft/botframework-cli/4.10.1 darwin-x64 node-v12.13.1

I had an update available now but this is the version I had when I wrote the issue.
Update available                                                                                Run                                                                                npm i -g @microsoft/botframework-cli                                                                                One-stop-shop CLI to manage your bot’s resources. BF CLI and AZ CLI together cover your end-to-end bot development workflow needs.                                                                                VERSION                                                                                @microsoft/botframework-cli/4.10.0-dev.20200730.3786d10 win32-x64 node-v14.15.0
I will try updating!

Still the same error message when updated. I also have some weird bugs when using conditionals, seems like I can't compare strings in some cases, but in other cases I can. Haven't figured out what sets the cases apart.

Still get the same message. I've also noticed a problem with conditionals based on User Input (Confirm), the result, stored as a variable, can't be used for conditionals. I have no problems using User Input multi-choice in the same manner as I'd use confirm.

@Laktos , Thanks for the response. would you mind to share your whole merged schema file here? for the Comfirm user input, could you share more detail about your use case?

@Laktos ， could you please try the following steps to fix this issue, this is a doc issue, @zxyanliu , let's fix that in the doc.

npm config set registry https://registry.npmjs.org/  (in composer doc, it asks you to set the registry to myget, which is out of date now.)
bf plugins:uninstall @microsoft/bf-dialog (in composer doc, it ask you to install this plugin, which is also out of date now).
npm i -g @microsoft/botframework-cli
.\update-schema.ps1
close composer and reopen it again.

@Laktos ， could you please try the following steps to fix this issue, this is a doc issue, @zxyanliu , let's fix that in the doc.

npm config set registry https://registry.npmjs.org/  (in composer doc, it asks you to set the registry to myget, which is out of date now.)
bf plugins:uninstall @microsoft/bf-dialog (in composer doc, it ask you to install this plugin, which is also out of date now).
npm i -g @microsoft/botframework-cli
.\update-schema.ps1
close composer and reopen it again.

Followed the steps and got the following error at Step 4:

The content was updated in the doc and will go live soon. Thanks.

@Laktos , Thanks for the response. would you mind to share your whole merged schema file here? for the Comfirm user input, could you share more detail about your use case?

The use case is in using a User Input (Confirm) with ['yes', 'no'], saving the result to a turn.confirm or user.confirm. Then trying to use this in an if case: turn.confirm == 'yes' (or "yes" or yes). This doesn't seem to work, but the multi-choice with the same options and if case does work. Haven't tried updating to see if the fixes are made to the main issue, but will as soon as possible.

Custom actions working without errors on the updated client (v1.2.0) with the steps from @luhan2017 !
Thank you for the help.


UI-API updates

Addresses general UI cleanup related to latest updates to API.
https://trello.com/c/NvRWvlWp/257-5-summit-ui-api-refactoring
For any areas where data was not available but we would like feedback during user testing, I included "---".
There were also some areas where data was available but needed to be updated to display correctly.
Some of updates included are:

updating list of inputs to not show Dependency count in the popover, and to include version and release data
showing the full set of inputs (previously only the inputs for which metadata was availalble were getting listed)
getting a list of dependencies for a list item when expanded.
displaying icons for dependency list items
not displaying Edit action when viewing details of a dependency

Some updates not included are:

saving release along with version
running depsolve against recipe on Add
removing duplicate options in the Version-Release menu during component edit/selection

Found an issue which is not related with this request. The URL on the components/ListView/ListItemComponents.js is empty, but not on components/ListView/ComponentDetailsView.js.

This PR passed end-to-end test (19 cases passed).

Thanks for the review! I made updates based on @henrywang's comments.


VSCode / Pylance complaints about type annotation issues the libraries

Version
4.11
Describe the bug
VSCode's pylance complained about this, the message was:
List expression not allowed in type annotation
  Use List[T] instead

Screenshots

Additional context
I'll add a PR for the instance of this I've found, but a code scan of the whole repo for this issue would be a good idea.

Thanks for submitting the PR! The Python codeowners will review it as soon as they are back from the holidays.

This issue will be closed when the linked PR is corrected and merged.  Currently, there is a build error during validation.

This issue will be closed when the linked PR is corrected and merged.  Currently, there is a build error during validation.


Mid-song dialog

What is your question?
Is there a simple way to do a mid-song dialog ? (I know I can code it but I ask anyway)

problably by modifing the dialogue.lua script to be under step hits and remove the countdown things (i think but i don't know)

There isn't a simple way to do it.


Mapper plugin install's via meltano install are skipped when mapping's are present

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/3528
Originally created by @pandemicsyn on 2022-05-25 17:28:18

Reported via slack: https://meltano.slack.com/archives/C013EKWA2Q1/p1653466616087819
User reported and @edgarrmondragon confirmed that mappers are being skipped and are not installed. We're supposed to install the actual mapper plugin but skip installing the mappings, and it appears that at the moment we're skipping both:
# with mapping
meltano@latest install
2022-05-25T16:03:07.689809Z [info     ] Environment 'dev' is active
Installing 7 plugins...
Skipped installing mapper 'meltano-map-transformer'...
Installing mapper 'meltano-map-transformer'...
Skipped installing mapper 'meltano-map-transformer'...
Installing utility 'sqlfluff'...
Installing transformer 'dbt-bigquery'...
Installing loader 'target-sqlite'...
Installing loader 'target-bigquery'...
Installing extractor 'tap-pocket'...
Installed transformer 'dbt-bigquery'
Installed utility 'sqlfluff'
Installed loader 'target-sqlite'
Installed loader 'target-bigquery'
Installed extractor 'tap-pocket'
Installed 5/7 plugins
Skipped installing 2/7 plugins

# without mappings
meltano@latest install
2022-05-25T16:05:41.783121Z [info     ] Environment 'dev' is active
Installing 6 plugins...
Installing mapper 'meltano-map-transformer'...
Installing utility 'sqlfluff'...
Installing transformer 'dbt-bigquery'...
Installing loader 'target-sqlite'...
Installing loader 'target-bigquery'...
Installing extractor 'tap-pocket'...
Installed transformer 'dbt-bigquery'
Installed utility 'sqlfluff'
Installed loader 'target-sqlite'
Installed loader 'target-bigquery'
Installed mapper 'meltano-map-transformer'
Installed extractor 'tap-pocket'
Installed 6/6 plugins

Since we dedupe plugin install's now we could potentially ditch the "skipping" logic completely.

View 1 previous comment from the original issue on GitLab

@edgarrmondragon do you know if this is solved?

@edgarrmondragon do you know if this is solved?

@tayloramurphy I don't think it is:
$ meltano install
Installing 6 plugins...
Skipped installing mapper 'meltano-map-transformer'...
Skipped installing mapper 'meltano-map-transformer'...
Installing extractor 'tap-csv'...
Installing extractor 'tap-smoke-test'...
Installing loader 'target-sqlite'...
Installing mapper 'meltano-map-transformer'...
Installed loader 'target-sqlite'
Installed mapper 'meltano-map-transformer'
Installed extractor 'tap-smoke-test'
Installed extractor 'tap-csv'
Installed 4/6 plugins
Skipped installing 2/6 plugins

$ meltano install
Installing 4 plugins...
Installing extractor 'tap-csv'...
Installing extractor 'tap-smoke-test'...
Installing loader 'target-sqlite'...
Installing mapper 'meltano-map-transformer'...
Installed mapper 'meltano-map-transformer'
Installed extractor 'tap-csv'
Installed extractor 'tap-smoke-test'
Installed loader 'target-sqlite'
Installed 4/4 plugins


Add Expr.quantile and Series.quantile

https://docs.pola.rs/py-polars/html/reference/expressions/api/polars.Expr.quantile.html#polars.Expr.quantile
I'm slightly worried that the default interpolation method might change in Polars at some point, so we should probably not put any default for it in Narwhals and force users to specify it explicitly

I can take this. Just to brainstorm ideas, we can keep a regression test comparing with polars default. That would give us an hint if the polars default changes in the future. WDYT?

true, but if the polars default changes, then we'll have to change the default here too. ideally, the narwhals api should be as stable as possible (even if polars/pandas aren't)
if this is aimed at library devs rather than end users, then "forcing" them to specify method= in return for guaranteed stability is probably worth it

true, but if the polars default changes, then we'll have to change the default here too

That's where a test can help

if this is aimed at library devs rather than end users, then "forcing" them to specify method= in return for guaranteed stability is probably worth it

I have mixed feeling on this. On one side, you are absolutely right, on the other hand, if the api wants to reflect polars behaviour flawlessly, I think the same default of polars is required 🤔

reflect polars behaviour flawlessly

kinda - the objective is to make a strict subset of the Polars API, and to me, making a keyword-argument required fits the definition of "strict subset"
So if somebody writes their codebase using Narwhals, and then they want to switch to just supporting Polars, then nw -> pl should do the trick (barring nw.from_native-style calls). However, the other way round isn't guaranteed

Adjusted in #207


bluebird, promise, q

Make sure those 3 libraries for promises

bluebird 10,5mln downloads/week
promise 4.8mln downloads/week
q 4,7mln downloads/week

works fine with context propagation for scope managers on web and node
If not then add support for them.
Unless someone can already answer these precisely, otherwise this can be a spike to see what needs to be done.

so far

browser:

bluebird works fine with zone
q doesn't work with zone
promise doesn't work with zone

I'm curious if it's possible to figure out whether the Zone.js library gets loaded before the promise library and whether that makes any difference. My understanding is that Zone.js works by monkey-patching the core browser APIs and so that as long as its loaded first it should ideally work with any kinds of wrappers / polyfills around those APIs. Though if it's loaded second it may not work if the library grabs its own copy of some native APIs before Zone can monkey-patch them.
I could be wrong on this understanding, but at least worth looking into.

FYI I'm finishing already the 2 new plugins for q and for promise.

Moving over the contrib repo


Account Page - All/ Setteled / Unsetteled Transaction

Account Page - All / Setteled / Unsetteled Transaction tab required
Warning
I dont suggest to create tab to show same data with  filter, that will increase bill and load on servers
Users can see same thing with filters

sath me lana hi nahi hai jo tab pe click kiya utna hi lana hai-by vinod Sir

sath me lana hi nahi hai jo tab pe click kiya utna hi lana hai-by vinod Sir

Ram usage is directly link with no of  things present on page, multiple tabs with same thing will increase load on Ram/PC/ slow loading

Also Settlement button, Print all things need to redone , single tab trigger / now all tabs triggers event to settlement button


Documentation for Github user search

Added readme file

Close #2512

Checklist:

[✅] I have mentioned the issue number in my Pull Request.
[✅] I have commented my code, particularly in hard-to-understand areas
[✅] I have created a helpful and easy to understand README.md

@MohitGupta121 kindly review this


Final Capstone Kanban

This is the link to the kanban.
The group is composed of 3 people @GuilhermeGiachellin,  @gabrielyea, and @Richie9000.
The tasks are divided to have an equal amount of work time.
We divided the work between backend and frontend.

Hi @GuilhermeGiachellin @gabrielyea @Richie9000 ,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

## Required Changes ♻

- Make sure that each project requirement has at least one corresponding card in the Kanban board, if you check the [project requirements](https://github.com/microverseinc/curriculum-final-capstone/blob/main/projects/business_requirements.md#project-requirements), you'll notice that some features that are missing, you currently only have the technical setup steps, add the features too.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

**_Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise._**

------
_As described in the [Code reviews limits policy](https://microverse.zendesk.com/hc/en-us/articles/1500004088561) you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using [this form](https://airtable.com/shrQAqnBwek5a0O0s)._

Hi @GuilhermeGiachellin, @gabrielyea, @Richie9000,
In my opinion, your project is approved!  There is nothing else to say other than... it's time to start :shipit:
Good luck! 🎉
Feel free to leave any questions or comments in the issue thread if something is not 100% clear.


Storybook 7.0 upgrade

Hi! 🙋♂
I am one of the maintainers of Storybook.
We are testing several frameworks and projects to ensure they are compatible with the upcoming Storybook 7.0 version. For this reason, I have chosen your Angular project to upgrade it to Storybook 7 and to gather some upgrade experience.
Feel free to merge this PR. You can also ignore it if you don't want to upgrade to SB 7. You decide :)
There are some things I would like to mention:

In SB 7.x, we use esbuild internally to bundle the project. It is not supported to import favicon files. Instead, try to use the favicon by making it accessible via static dirs.

I have upgraded the CSF 2 syntax to use CSF 3

I have added an example that uses automated interaction tests

Your Doc files were upgraded to use satisfy the new MDX 2 syntax. stories.mdx files were renamed to .mdx and automatic doc page generation was enabled

Hi @valentinpalkovic; thanks so much for choosing this project.
Is it fine if I review it next Monday? I'm busy working on a conference about Storybook for a Belgian DevFest this weekend.

Hi @geromegrignon,
Sure! Take your time. There is no time pressure from our side :)

@valentinpalkovic I noticed some css regressions.
Some styles are applied to native HTML tags if not wrapped in a storybook context, breaking custom documentation styles.
from

to

It applies to links too:
from

to

@valentinpalkovic I noticed some css regressions. Some styles are applied to native HTML tags if not wrapped in a storybook context, breaking custom documentation styles.
from
to
It applies to links too: from
to

The first style issue is solvable by using the Unstyled component. You can read more about it here: https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#default-docs-styles-will-leak-into-non-story-user-components. The second screenshot is weird and we are investigating the issue right now.


Fix #1064: Fix PolicyRepository implementation issues

Describe your changes :
Build broken due to recent PR merge

Type of change :

[x] Bug fix
[x] Documentation

Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] I have performed a self-review of my own.
[ ] I have tagged my reviewers below.
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] All new and existing tests passed.

Reviewers

@mithmatt another PR introduced EntityInterface changes , which are not implemented by PolicyRepository causing build to fail. So I added mock implementations please add if they apply to policy in another PR. Thanks.


Autotune: carb_data instead of prepped_glucose_data used.

https://github.com/openaps/oref0/blob/dev/bin/oref0-autotune-prep.js#L91
Should this really read carb_data = JSON.parse(fs.readFileSync(prepped_glucose_input, 'utf8')); or rather prepped_glucose_data = JSON.parse(fs.readFileSync(prepped_glucose_input, 'utf8')); ?

I don't think that code path has ever actually done anything.  I only vaguely remember why I had it in there when initially developing it, but apparently never ended up using it.  I just pushed https://github.com/openaps/oref0/compare/dev...cleanup to comment it out, if you're interested in testing to make sure that doesn't break anything.  I'll probably merge that for 0.6.1

https://github.com/openaps/oref0/pull/828 is now merged to dev.  Closing.


Questions about expected behavior.

Hello, thanks for this great project! I'm trying to use for my self-hosted minecraft server.
I set it using the example from the project and it's working fine to start the server. A few things I noticed:

When "minPacketThreshold" is not set, it uses the default 30 packets. A Refresh from the Minecraft Client sends around 10 packets to check if the server is up. So, I think it should be set between 10 to 20 in this use case (minecraft server). Otherwise, the server (container) is not started without hitting refreshing like 3 o 4 times.

I set the "inactiveTimeOut" label in 600 seconds. According to the logs, when the last user disconnects from the server, it takes around 10 minutes to start checking if the container can be stopped. After that, the countdown beings and when the inactive time is reached, the container finally stops. As so, the time to stop the container is around 20 min. Is this the expected behavior?

Just in case, I'll attach my compose file.
docker-compose.yml.txt

Is that expected behavior?
Right now, yes though it may make sense to have a flag or change it if it's a popular opinion (no idea how to determine that, and not super eager to change the default behavior)

Is there a way to use the "active clients" from the logs to set a flag and be able to stop the container after a given time

I don't think I understand your question here. What would a timeline of this look like to you?

Is that expected behavior?

Right now, yes though it may make sense to have a flag or change it if it's a popular opinion (no idea how to determine that, and not super eager to change the default behavior)

Thanks for the answer! I have a better understanding about this part.

Is there a way to use the "active clients" from the logs to set a flag and be able to stop the container after a given time

I don't think I understand your question here. What would a timeline of this look like to you?

Sorry, english is not my main language. maybe that's way I was not clear enough.
What I tried to said is that from the logs, it seems like the "active clients" on the minecraft server can be read. If so, do you think a flag like "minPacketThreshold" can be added but for "active clients"? That way, the lazytainer can have another thing to check and stop the server container, for example, 10 minutes after having 0 active clients.
That would be my feature request.


Fix HasTypeReps instances for Tx and TxWits

Currently these are the definitions of Tx and TxWit:
-- |A raw transaction
data Tx id = Tx { txid    :: id
                , inputs  :: [TxIn id]
                , outputs :: [TxOut]
                } deriving (Show, Ord)

instance HasTypeReps i => HasTypeReps (Tx i) where
  typeReps x@(Tx i' inputs outputs)
    = typeOf x <| typeOf i' <| typeOf inputs <| typeOf outputs <| empty

data TxWits id = TxWits
                { body      :: Tx id
                , witnesses :: [Wit id]
                } deriving (Show, Eq)

instance HasTypeReps i => HasTypeReps (TxWits i) where
  typeReps (TxWits b w) = typeOf b <| typeOf w <| empty

This is wrong since these instances are not counting the number of inputs, the number of outputs, and the number of witnesses.
As far as I can see, the default generic definitions would suffice, so we need to:

[ ] Write unit tests for the expected typeReps of Txs.
[ ] Write unit tests for the expected abstracSIze of  Txs.
[ ] Optional: write property tests for the typeReps of Txs.
[ ] Optional: write property tests for the expected abstracSIze of  Txs.
[ ] Remove the custom implementation of the HasTypeRep Tx instance, and check that the tests pass.
[ ] Write unit tests for the expected typeReps of TxWitss.
[ ] Write unit tests for the expected abstracSIze of  TxWitss.
[ ] Optional: write property tests for the typeReps of TxWitss.
[ ] Optional: write property tests for the expected abstracSIze of  TxWitss.
[ ] Remove the custom implementation of the HasTypeRep TxWits instance, and check that the tests pass.

instance HasTypeReps i => HasTypeReps (TxWits i) where
  typeReps (TxWits b w) = typeOf b <| typeReps w

...would give a typeReps that includes the [Wit] types - currently typeOf w fixes on [Wit] and does not give a typeRep for each Wit in the list.
Having said that, so would a generic instance.

Having said that, so would a generic instance.

Right. I'd prefer to use a generic instance whenever possible.

For the Hash type, the newtype deriving used to derive the HasTypeReps instance does not give us what we need (for an explanation, see the comments about Slot in https://github.com/input-output-hk/cardano-ledger-specs/issues/563).
Instead, we can do this:

newtype Hash = Hash
  { unHash :: Int
  } deriving stock (Show, Generic)
    deriving newtype (Eq, Ord, Hashable)
    deriving anyclass (HasTypeReps)

The custom instance for BlockHeader currently refers to typeOf Hash (instead of typeReps Hash), which is why the Hash type is being correctly picked up. With a proper HasTypeReps instance, we can amend the BlockHeader instance like so:
instance HasTypeReps BlockHeader where
  typeReps x = typeOf x
               <| typeReps (undefined :: Hash)
               <> typeReps (x ^. bhUtxoHash :: Hash)
               <> typeReps (x ^. bhDlgHash :: Hash)
               <> typeReps (x ^. bhUpdHash :: Hash)
               <> typeReps (x ^. bhSlot :: Slot)
               <> typeReps (x ^. bhIssuer :: VKey)
               <> typeReps (x ^. bhSig :: Sig Hash)


Float JSON representation is wrong

The JSON specification states:

Numeric values that cannot be represented in the grammar below (such as Infinity and NaN) are not permitted.

However Float#to_json simply calls to_s which does emit these values. js handles this by emitting "null" instead. Some other engines handle it by emitting zero for NaN, or very high (or low) numbers for infinity. Some engines break the specification by emitting Infinity, -Infinity and NaN. Go handles it by raising.
What should crystal do?

I just checked what Ruby does and it raises. Raising is probably a good idea.

Unfortunately it's quite an annoying reaction: one accidental Infinity or NaN and your program crashes. It's probably the correct reaction though.

But using an arbitrary replacement is probably worse: you get incorrect data on the other side...
I don't think NaN/Infinity are that common for that to be a common error to happen (I never saw that exception in my life and I've been programming in Ruby, using JSON, for several years now)


[feature-request] tables 5877 "Phys. Invt. Record Header" / 5878 "Phys. Invt. Record Line" Field "Person Recorded" is Code[20]

In the tables 5877 "Phys. Invt. Record Header" and 5878 "Phys. Invt. Record Line" Field 102 "Person Recorded" is Code[20]  with table relation. Ist must be Code[50] with table relation to the user table.

These fields contains Employee No., not User ID. We can add field "Recorded by User ID" if needed?

Yes, please integrate "Recorded by User ID"

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 10731.


I can import users from AD but login failed

Hello and happy new year,
First, thank you for this plugin more than useful.
I think the title summarizes my problem. I can connect to AD via ADLDAP, I'm able to import users who are in a specific group to my database. but the login does not work !! "These credentials do not match our records."
in Route.php :
dd(Adldap::auth()->attempt('user', 'pass')); ==> false
dd(Adldap::search()->where('cn', '=', 'My Name')->get()); ==> retreive the user requested.
thank you for your help.

when I set 'account_prefix' to empty string and put dd(Adldap::auth()->attempt('DOMAINE\user', 'pass')); in Route.php, it returns true, but still don't login.

Hi @scorlink,
You're authenticating with the wrong method. Adldap::auth()->attempt() performs authentication directly against your domain controller, and that's it. Basically, it just says true / false if your credentials are valid. It won't authenticate you in your Laravel application.
That's what the auth driver is for: https://github.com/Adldap2/Adldap2-Laravel#auth-driver
Did you implement the auth driver by following the included docs?
If so, I can definitely assist you in troubleshooting.

Hi @stevebauman,
Thanks for your answer. indeed I'm authenticating with the auth driver as described in your docs.
I use Adldap::auth()->attempt() only for troubleshooting.
I already fixed my issue by adding \\ after the account_prefix in adldap.php.
thanks once again for this plugin and your fast assistance 👍

Great to hear! No problem at all :).


Update to Meteorologisk Institutt API.

The Meteorologisk Institutt requires User-Agent headers to be sent with requests to their API. For more details see here https://api.met.no/doc/TermsOfService.
Thank you for taking the time to work on a Pull Request for this project!
To ensure your PR is dealt with swiftly please check the following:

[x] Your submissions are formatted according to the guidelines in the contributing guide
[x] Your additions are ordered alphabetically
[x] Your submission has a useful description
[x] The description does not end with punctuation
[x] Each table column should be padded with one space on either side
[x] You have searched the repository for any relevant issues or pull requests
[x] Any category you are creating has the minimum requirement of 3 items
[x] All changes have been squashed into a single commit

Thanks for the contribution @Rory-Sullivan!


Added topic subscription information retrieval to messaging client

This commit should provide the feature requested in FR #99.

@chong-shao is this something the FCM team is interested in releasing?

@chong-shao there's a product decision to be made here. Do we even want to expose this API in our SDKs? We ought to run this by a PM first.

@hiranya911 synced with our PM. The feedback is that we should not merge this into master branch unless the endpoint has been switched to the new one (which has not been set up yet).
Can we put this is a side branch? Or keeping the PR in open status until the new endpoints are ready? @andirayo

@chong-shao I agree. We can keep the PR open for now.
We also possibly need an API proposal, and at least a semblance of a plan to have the same API exposed in other languages at some point.


Need a builtin widget for OTP code

Need a builtin widget for verifying the OTP code

Current Custom Implementation:

Tin app
Onboarding_ConfirmAccount screen
https://studio.ensembleui.com/app/Oq9d5Zy3Mky2XvyDx3HI/screen/Zs3TIEy8EsVkAHM8gT1d?propertyPanelEnabled=true&instantPreviewDisabled=false&editorV2Enabled=true

Form:
  children:
    - Row:
        styles:
          margin: 0 5
          gap: 10
        children:
          - TextInput:
              id: verificationDigit1
              required: true
              maxWidth: 40
              expanded: true
              onKeyPress:
                executeCode:
                  body: |
                    verificationDigit2.focus()
                    if (this.value == '') {
                      disabledButton.visible = true;
                      enabledButton.visible = false;
                    } else {
                      disabledButton.visible = false;
                      enabledButton.visible = true;
                    }
          - TextInput:
              id: verificationDigit2
              required: true
              maxWidth: 40
              expanded: true
              inputType:
              onKeyPress:
                executeCode:
                  body: |
                    verificationDigit3.focus()
          - TextInput:
              id: verificationDigit3
              required: true
              maxWidth: 40
              expanded: true
              onKeyPress:
                executeCode:
                  body: |
                    verificationDigit4.focus()
          - TextInput:
              id: verificationDigit4
              required: true
              maxWidth: 40
              expanded: true
              onKeyPress:
                executeCode:
                  body: |
                    verificationDigit5.focus()
          - TextInput:
              id: verificationDigit5
              required: true
              maxWidth: 40
              expanded: true
              onKeyPress:
                executeCode:
                  body: |
                    verificationDigit6.focus()
          - TextInput:
              id: verificationDigit6
              required: true
              maxWidth: 40
              expanded: true
              onKeyPress:
                invokeAPI:
                  name: confirmPhone
                  inputs:
                    userId: ${userId}
                    phoneNumber: ${phoneNumber}
                    onboardingTicket: ${onboardingTicket}
                    code: ${verificationCode.value

Please propose the YAML to start out.

@vusters
OtpWidget:
  id: String
  digits: Integer
  inputType: Alphabetic | Alphanumeric | Numeric | Boolean | Uppercase Alphabetic | Lowercase Alphabetic | Uppercase Alphanumeric | Lowercase Alphanumeric
  onInputStarted: Action # fire when a key is pressed for the first input
  onInputCompleted: Action # fire when a key is pressed in last input
  shouldWait: Boolean # IF(true) then onInputFilled would not be fired until user explicitly presses 'Enter' ELSE onInputFilled will be fired as soon as last a key is pressed for last input
  enableFocus: Boolean # IF(true) then first input will automatically be focused ELSE it won't

# should automatically handle going to previous field when 'backspace' is pressed

I'd name it ConfirmationInput to be more generic. Use cases:

OTP
confirmation code
PIN number
Reset password
Coupon

@vusters I'll use this package - https://pub.dev/packages/otp_text_field

@vusters Created a PR - https://github.com/EnsembleUI/ensemble/pull/695 and I'm using another package - https://pub.dev/packages/otp_pin_field


Read hostURL from the context

When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)
If this is your first time submitting to GitHub and you need some help, please sign up for this session.

[ ] I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
[ ] I attest that the connector works and I verified by deploying and testing all the operations.
[ ] I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
[ ] I attest that I have added response schemas to my actions, unless the response schema is dynamic.
[ ] I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
[ ] If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

[ ] I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
[ ] Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
[ ] Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
[ ] If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.

@harshitav-docusign , is there any change needed in the swagger file ?

@harshitav-docusign , is there any change needed in the swagger file ?

@sriharip-docusign There is also a place in the swagger file where we are hardcoding the host url. I will have to talk to SreeVishnu from the Microsoft India team on how to read it from the context. I will keep this PR open till tomorrow.

@harshitav-docusign , is there any change needed in the swagger file ?

@sriharip-docusign There is also a place in the swagger file where we are hardcoding the host url. I will have to talk to SreeVishnu from the Microsoft India team on how to read it from the context. I will keep this PR open till tomorrow.

@sriharip-docusign Sreevishnu informed that, the Host URL in the swagger file need not be changed. The serviceURL value will override the Host URL in the swagger file. I am going ahead and merging this PR.


Jaws reads "not checked unavailable" when the checkbox is checked (and disabled)

This PR fixes the following issue in IE 11 / Jaws 16: in some cases a disabled checked checkbox is read as "not checked unavailable" instead of "checked unavailable".

@divdavem these changes are fine for me. you can merge it

@benouat Thank you for your review! :smile:


Ctrl-Alt-S keyboard shortcut not working on Ubuntu 14.04

I have been using Brackets for a few weeks just fine on OS X, but in a recent move to Ubuntu 14.04 on a different machine, the Ctrl-Alt-S keyboard shortcut is not saving my files. It seems to be ignored. The "Save All" menu item works fine, and the keyboard shortcut works on OS X but not Ubuntu 14.04. I have seen other issues referencing a related problem around internationalization and special characters, but I'm running in US English.

As far as I can see this has nothing to do with brackets...
On Ubuntu <Control><Alt>s is a default keybinding.
Listing all window manager key bindings in sorted order:
gsettings list-recursively org.gnome.desktop.wm.keybindings | sort

Filtering the the key binding for <Control><Alt>s:
gsettings list-recursively org.gnome.desktop.wm.keybindings | grep "<Control><Alt>s"

If you want to deactivate the Ubuntu key binding you can use:
gsettings set org.gnome.desktop.wm.keybindings toggle-shaded "['disabled']"

I don't know if there is a reliable platform independent way to check for system wide key bindings,
but I believe trying to fix possible key binding conflicts on all platforms would be a complete overkill.
@dlewanda therefore I think it is ok to close this issue.

@aelgru: Isn't Ctrl-Shift-S available as it is on Windows? It seems that for such a useful keyboard shortcut it wouldn't be that hard to find one that doesn't collide with a system keyboard binding.

@dlewanda as far as I can see Control-Shift-S is used for file.saveAs. My understanding of keyboard short-cuts is that every user should be able to adapt those short-cuts to his own needs and the software provides reasonable defaults. So, I believe what brackets does is actually ok.

Why we need shortcut for "Save All"? Brackets regilary asks me to save all before quit or git commit. In other editors also "Save All" do not have shortcuts at all. Just select from menu.
Try do not use Ctrl+Shift+<...> shortcuts, if only you want undo action:

Ctrl+<...> - used to do some action
Ctrl+Shift+<...> - used to undo some action

+1

+1

Hey guys! Im new too in Ubuntu.
I have the same problem, and more! I want to use alt + 64 to generate "@",  or alt + 60 to generate it "<", but just i can't do it in Ubuntu 20.04.2 LTS,  any idea how to activate all keys same as Windows =


Azure File Copy randomly fails with "Failed to enable copy prerequisites"

Environment

Server: Azure Pipelines
I can provide the account name, team project name, build definition name/build number privately. Maybe you can retrieve from operation id eabc1f8a-e1af-4000-9a53-78be58ec4089.

Agent - Hosted and Hosted VS2017

Issue Description
This random issue has worsened significantly in the last few weeks but has happened throughout our last 2+ years of using VSTS / Azure DevOps. In the last few weeks we now have 20% failures or so when releasing to Azure servers, and redeploying without any changes succeeds. I suspect the problem is timing related with the VSTS task trying to manipulate the WinRMCustomScriptExtension.
We are experiencing this problem deploying to Azure servers that are in DevTestLabs built from the SQL Server 2016 SP1 Standard on Windows Server 2016 and Windows Server 2016 Datacenter bases. These servers are scheduled to stop and start daily on weekdays via DevTest Labs and are already running when these deployments fail.
The activity logs show the VSTS agent failing to Create or Update the extension, then our subsequent deployment succeeding. Note the same user name performs the work and no changes occur between releases:

Possibly related issues:
https://developercommunity.visualstudio.com/content/problem/299815/operation-put-extension-is-not-allowed-on-vm-exten.html
https://github.com/Microsoft/vsts-tasks/issues/5560
https://github.com/Microsoft/vsts-tasks/issues/4451
https://github.com/Microsoft/vsts-tasks/issues/1788
Task logs
AzureFileCopy.zip
Error logs
Failed to enable copy prerequisites. Operation 'PUT Extension' is not allowed on VM extension 'WinRMCustomScriptExtension' since it is marked for deletion. You can only retry the Delete operation (or wait for an ongoing one to complete). ErrorCode: OperationNotAllowed ErrorMessage: Operation 'PUT Extension' is not allowed on VM extension 'WinRMCustomScriptExtension' since it is marked for deletion. You can only retry the Delete operation (or wait for an ongoing one to complete). StatusCode: 409 ReasonPhrase: Conflict OperationID : eabc1f8a-e1af-4000-9a53-78be58ec4089

Hi we are getting the same issue every time we do a deployment. We redeploy and it works fine.
Operation 'PUT Extension' is not allowed on VM extension 'WinRMCustomScriptExtension' since it is marked for deletion. You can only retry the Delete operation (or wait for an ongoing one to complete).
We do however shutdown the VM' in the evening and restart it in the morning....if that has any bearing...?
Thanks
John

Please share debug logs.
Debug logs can be enabled by adding release definition variable system.debug with value true.

Attached are all logs for a failed release. The failed task is named “Copy files”.
From: Ajay Kumar Yadav<EMAIL_ADDRESS>Sent: Wednesday, October 24, 2018 3:21 AM
To: Microsoft/azure-pipelines-tasks<EMAIL_ADDRESS>Cc: Eric Dupuis<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [Microsoft/azure-pipelines-tasks] Azure File Copy randomly fails with "Failed to enable copy prerequisites" (#8535)
Please share debug logs.
Debug logs can be enabled by adding release definition variable system.debug with value true.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fazure-pipelines-tasks%2Fissues%2F8535%23issuecomment-432581419&data=02|01|edupuis%40incomm.com|103e17a5476d47d45eb208d6399214fc|d08e5403b1c94dbfaf91bab966a84dea|1|0|636759696925942160&sdata=E9UY6HxzYpbPxvhK%2BhGmPFSZeDX5JKD1gxxjcqcfnc0%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAhHS7L-p_rSq9xYxKfsndLMTL98mjwUWks5uoDERgaJpZM4XTvut&data=02|01|edupuis%40incomm.com|103e17a5476d47d45eb208d6399214fc|d08e5403b1c94dbfaf91bab966a84dea|1|0|636759696925952168&sdata=QJYmbepeJvQXZfo5OGC4EzdiyvRNOM4jenPq9PjISHo%3D&reserved=0.

I am not able to figure out any attachment of logs here. Please share it at<EMAIL_ADDRESS>

Sent to<EMAIL_ADDRESS>email, got undeliverable response related to<EMAIL_ADDRESS>only accepting messages from people inside organization. Attaching here via github site instead of email attachment. Hopefully this works.
ReleaseLogs_4437.zip

Hi release logs attached from out latest release as well
Thanks
John
ReleaseOputputLog.txt

@edupuis-incomm, @johnhydemtm365
Thanks for sharing logs. Your logs are really helpful to identify the problem, debugging it further to know all possible causes.
Will fix it soon.

@edupuis-incomm, @johnhydemtm365
Raise PR for the fix
https://github.com/Microsoft/azure-pipelines-tasks/pull/8728

We have fixed this issue.  It will be deployed with the next deployment.