New command: spo web listtemplate get

Usage
m365 spo web listtemplate get [options]
Description
Get a specific list template in a specified site
Options

Option
Description

-u, --webUrl <webUrl>
URL of the site for which to retrieve the list templates.

-n, --name [name]
The name of the list template to retrieve. Specify either name or type but not both.

-t, --type [type]
The type of the list template to retrieve. Specify either name or type but not both.

Examples
Get a list template in the specified site by name
m365 spo web list template get --url "https://contoso.sharepoint.com/sites/contoso" --name "Custom List"

Get a list template in the specified site by type
m365 spo web list template get --url "https://contoso.sharepoint.com/sites/contoso" --type 100

Default properties
No response
Remarks
The type option is a number which represents a certain list template. For example the number 100 represents the GenericList list template, the number 101 represents the DocumentLibrary list template. A list of standard list template types can be found here
Additional Info
You can get a list template by name by doing a GET to /_api/web/ListTemplates('Custom%20List')
You can get a list template by type by doing a GET to /_api/web/ListTemplates?$filter=ListTemplateTypeKind eq 100
Make sure to add an option ListTemplateTypeKindValue which shows the 'translated' value from this enum. Example:
ListTemplateTypeKindValue: DocumentLibrary when ListTemplateTypeKind is 101

Nice suggestion @nicodecleyre! I've got a few pointers.

In the command name, let's combine the two words list and template. This will result in the following m365 spo web listtemplate list [options]. Note here that I also change the ending verb from list to get as I assume that this command will return a single result.
We should change the option name for url to webUrl as URL reflects on web and not on listtemplate.
For the description of --type, I'm not quite sure if (example 100, 101) would be quite clear. If we need to include an example for this option we better write it in the remarks section and explain it a bit more over there.

I agree with @Jwaegebaert  for type user should be able to specify a friendly user name that we may take from here
https://github.com/pnp/cli-microsoft365/blob/main/src/m365/spo/commands/list/ListTemplateType.ts
and we should internally translate it to the in number 👍

Question @nicodecleyre, what's the use case of this proposed command? What would you use it for?

Thank you for the feedback everybody!

Question @nicodecleyre, what's the use case of this proposed command? What would you use it for? (Out of interest)

A use case can be when a user executes the spo list get command and wants to know which list template is behind the BaseTemplate property.
The idea came from the fact that @Adam-it asked me to include the SitePages option and said that it was the 119 list template id. Not that I didn't believe him, but I just wanted to double check. And my reflex was to use the cli, but I noticed we have no command for that.

Ok, but aren't those values the same across all tenants? It would be like retrieving a value from the MS documentation.

Ok, but aren't those values the same across all tenants? It would be like retrieving a value from the MS documentation.

Thanks for challenging this. I agree that this command probably won't be used much. However, I do think it could add value if someone needed the list template as part of a script to automate things. For example, consider replacing the basetemplate in the list xml when using Get-SPOSiteScriptFromList.
But if you believe that this addition has no added value for the CLI, I'm happy to close it

The question is: is there tenant specific information in the ListTemplate that we need to get from a tenant?
If there is and someone can think of a situation that this would be necessary to use, it could be OK to build it.
In the case of this command I personally think that all we ever need is the common base template id (100, 101, 119) and its human readable form (Custom List, etc). That is information that is freely available in reference documentation and the same across tenants world wide. It would be odd to add such a thing to the CLI.
Something entirely different could be sensible though:
Display a human readable version of the base template id when listing and getting lists, for example. We could map the id to the human readable form to enhance the api output and help users along.
I think we might do these kind of things in more places than just with the base template id.

Other thoughts @pnp/cli-for-microsoft-365-maintainers?

@martinlingstuyl that is a good point. It is easy to get on and on with our work to create an additional layer for the API but as we discussed some time ago it is not CLI aim, and I agree it provides little value. Currently, if user will need to get the templates we may just use request command.

let's leave this open for now but not prioritize this and not ask for help.

I'd rather suggest we close these issues, as there is currently no value as far as we can see.


gerrit-378734-7

Codecov Report

Merging #1522 into master will decrease coverage by 0.42%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1522      +/-   ##
==========================================
- Coverage   62.28%   61.85%   -0.43%
==========================================
  Files         274      275       +1
  Lines       53930    54077     +147
==========================================
- Hits        33588    33449     -139
- Misses      20342    20628     +286

Impacted Files
Coverage Δ

pwb.py
74.61% <ø> (ø)
:arrow_up:

scripts/userscripts/__init__.py
0% <0%> (ø)

pywikibot/userinterfaces/win32_unicode.py
19.89% <0%> (-39.8%)
:arrow_down:

pywikibot/userinterfaces/terminal_interface.py
87.5% <0%> (-12.5%)
:arrow_down:

tests/ui_tests.py
71.82% <0%> (-6.35%)
:arrow_down:

pywikibot/config2.py
70.66% <0%> (-6.14%)
:arrow_down:

tests/oauth_tests.py
63.41% <0%> (-2.44%)
:arrow_down:

tests/djvu_tests.py
97.64% <0%> (-2.36%)
:arrow_down:

tests/weblinkchecker_tests.py
97.67% <0%> (-2.33%)
:arrow_down:

setup.py
91.25% <0%> (-1.25%)
:arrow_down:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0d1696...282bee5. Read the comment docs.


MouseManager translation added

Allow developpers to add a translation delta (x and y) to be added in the mstate of events
(usefull for the canvas event listening)

-> #19


Track polygons as GeoJSON and as .shp.

Consider pros and cons here.
GeoJSON pros:

maybe better character encoding
not an ESRI thing
single file

Shapefile pros:

default standard, probably better for actual GIS users
smaller file sizes than geoJSON for equivalent levels of geometry

Yeah let's do both. That going to improve utility and version control.

Well, the GeoJSON file sizes are quite a bit larger (2-3X) the shape file sizes. This creates scenarios where not ridiculous feature sets exceed the git file size limit of 100 MB. We could simplify geometry, but I think we can leave for this for an actual DB of this repo's contents some time in the future. However, tracking the names and ids and other info (no geometry) as straight JSON would be useful, and would reduce the file size quite a bit.

No longer relevant - just retaining the .shp files has not bitten us too bad yet. Closing.


Remove an unused script that validate Acunetix files

This pull request remove a script that should be in the contrib repository
The pb with this script is that it depend on lxml which is vulnerable and we are moving all XML modules to defusexml.

If it should be in the contrib repository, should it be added there? It also could be check to have in the parser?
To be honest, I think it's old code and can be removed.


Integrate asset-sync w/ azure-sdk-for-js

The PR is working and ready to go. Harsha and Timo are going to discuss among themselves for any further changes, but my part of this task is completed.


Mobile devices inssue

Hello!
First of all, congratulations @lieuweprins  for the pluguin, it is awesome and help me a lot.
I used it in a web aplication that I need it can be used by mobile devices. The problem is that seems the plugin is blocking the links and the button of the page... It is rare, you can see it by watching your own web demo (https://rawrfl.es/jquery-drawr/ ) in a mobile device or by toogle device toolbar inside de F12 mode of Chrome. Click in "Download" or "View on github" or the links in the page and you will see it.
Do you know why is this happening?
Thanks you in advance!

Hi, thanks for reporting.
It appears to be caused by the "e.preventDefault();" , line 185 of jquery.drawr.js, inside the self.drawStop method. commenting it out seems to fix things. I'm not sure why it is there to be honest (I imagine it had something to do with the text input control).
I'm looking into it, there don't seem to be any sideeffects as of yet for removing it but I need to be sure.

Hi @lieuweprins  !
I'm want to use this plugin as whiteboard in my online Tutor website but i'm facing a issue on responsive, you can view this in image. please help me on this issue. Thanks in Advanced.


HDFS-17691. [FGL] Move FSNamesystemLockMode to org.apache.hadoop.hdfs.util package

package org.apache.hadoop.hdfs.util;

import org.apache.hadoop.hdfs.server.namenode.fgl.FSNamesystemLockMode;

/** Read-write lock interface for FSNamesystem. */
public interface RwLock {
  /** Acquire read lock. */
  default void readLock() {
    readLock(FSNamesystemLockMode.GLOBAL);
  }
 ...
}

This dependency is not ideal. The FSNamesystemLockMode should be relocated to the same package as RwLock.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
detsecrets
0m  1s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 46 new or modified test files.

_ HDFS-17384 Compile Tests _

+0 :ok:
mvndep
6m 32s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
35m 37s

HDFS-17384 passed

+1 :green_heart:
compile
18m 48s

HDFS-17384 passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
16m 49s

HDFS-17384 passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
checkstyle
4m 57s

HDFS-17384 passed

+1 :green_heart:
mvnsite
3m 10s

HDFS-17384 passed

+1 :green_heart:
javadoc
3m  1s

HDFS-17384 passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
3m 14s

HDFS-17384 passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
spotbugs
5m 47s

HDFS-17384 passed

+1 :green_heart:
shadedclient
37m 32s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 31s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 55s

the patch passed

+1 :green_heart:
compile
17m 54s

the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
17m 54s

the patch passed

+1 :green_heart:
compile
21m 38s

the patch passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
javac
21m 38s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
5m 16s
/results-checkstyle-root.txt
root: The patch generated 1 new + 1015 unchanged - 7 fixed = 1016 total (was 1022)

+1 :green_heart:
mvnsite
2m 55s

the patch passed

-1 :x:
javadoc
1m 24s
/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04.txt
hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04.

-1 :x:
javadoc
1m 52s
/results-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga.txt
hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga generated 1 new + 1 unchanged - 0 fixed = 2 total (was 1)

+1 :green_heart:
spotbugs
6m 29s

the patch passed

+1 :green_heart:
shadedclient
37m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
261m 25s

hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
31m 28s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
unit
0m 55s

hadoop-fs2img in the patch passed.

+1 :green_heart:
asflicense
1m 12s

The patch does not generate ASF License warnings.

538m 48s

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7232/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7232

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux d94d00f66a3a 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
HDFS-17384 / cbfdcc3da69c0951c10fe47f7267897a4e519826

Default Java
Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7232/2/testReport/

Max. process+thread count
3194 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-tools/hadoop-fs2img U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7232/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Please fix the checkstyle issue

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
17m 36s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  2s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 46 new or modified test files.

_ HDFS-17384 Compile Tests _

+0 :ok:
mvndep
5m 48s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
35m  5s

HDFS-17384 passed

+1 :green_heart:
compile
18m 45s

HDFS-17384 passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
compile
17m  2s

HDFS-17384 passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
checkstyle
4m 47s

HDFS-17384 passed

+1 :green_heart:
mvnsite
3m 10s

HDFS-17384 passed

+1 :green_heart:
javadoc
3m  1s

HDFS-17384 passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
3m 18s

HDFS-17384 passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
spotbugs
5m 49s

HDFS-17384 passed

+1 :green_heart:
shadedclient
40m 38s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 32s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 56s

the patch passed

+1 :green_heart:
compile
17m 53s

the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javac
17m 53s

the patch passed

+1 :green_heart:
compile
17m 10s

the patch passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
javac
17m 10s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
4m 35s

root: The patch generated 0 new + 1015 unchanged - 7 fixed = 1015 total (was 1022)

+1 :green_heart:
mvnsite
3m  4s

the patch passed

+1 :green_heart:
javadoc
2m 54s

the patch passed with JDK Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04

+1 :green_heart:
javadoc
3m 14s

the patch passed with JDK Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

+1 :green_heart:
spotbugs
6m 16s

the patch passed

+1 :green_heart:
shadedclient
38m 34s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
264m 51s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

-1 :x:
unit
31m 24s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
unit
0m 55s

hadoop-fs2img in the patch passed.

+1 :green_heart:
asflicense
1m 12s

The patch does not generate ASF License warnings.

556m 29s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.server.federation.router.TestRouterAllResolver

hadoop.hdfs.server.federation.router.TestRouterClientRejectOverload

Subsystem
Report/Notes

Docker
ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7232/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/7232

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 579b343ece60 5.15.0-124-generic #134-Ubuntu SMP Fri Sep 27 20:20:17 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
HDFS-17384 / 59a665903a1a2fced871e5242b9ed07a70ed22a2

Default Java
Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.25+9-post-Ubuntu-1ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_432-8u432-ga~us1-0ubuntu2~20.04-ga

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7232/3/testReport/

Max. process+thread count
3305 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-tools/hadoop-fs2img U: .

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7232/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop.hdfs.TestRollingUpgrade
hadoop.hdfs.server.federation.router.TestRouterAllResolver
hadoop.hdfs.server.federation.router.TestRouterClientRejectOverload

These failed UT work well locally.

@ZanderXu Thanks for contribution. @haiyang1987 Thanks for review. merged


Allow MetricsTracker to be set/updated/overwritten after the pool was created?

In follow-up of issue #112, it would be nice if the MetricsTracker could be set after that the BaseHikariPool() is constructed.
In our project (https://bitbucket.org/beforeach/across-standard-modules/src/0e73c0beb971bac0e363eddb49a337996790d7b4/metric-module/src/main/java/com/foreach/across/modules/metrics/config/DataSourceMetricModuleConfiguration.java?at=spring-data) we are writing a spring module which "injects" metrics if HikariDataSources are found. We would be autowiring the datasources and if they are HikariDataSource instances, set the MetricsTracker accordingly. However, we have a bit of a catch-22.
DataSources in the across framework are initialized very early in the bootstrap (because it applies liquibase installers and whatnot). It would be impossible for our MetricRegistry module to create a bean before that (because the modules are bootstrapped after datasources are bootstrapped).
To cut a long story short, it would be nice if the MetricsTracker could also be changed/updated after the pool was created (without having to expose the pool explicitly of  course)
Right now we have this hackerish code which seems to work "okay" as a test (but of course will fail "isRecordMetrics" checks in BaseHikariPool.getConnection()).
        DirectFieldAccessor df =  new DirectFieldAccessor(hikariDataSource);
        Object pool = df.<HikariPool>getPropertyValue("pool");
        if( pool instanceof HikariPool ) {
            HikariPool hikariPool = (HikariPool) pool;
            DirectFieldAccessor poolAccessor = new DirectFieldAccessor(hikariPool);
            Object metricsTracker = poolAccessor.getPropertyValue("metricsTracker");
            if( metricsTracker instanceof MetricsTracker) {
                ((MetricsTracker) metricsTracker).close();
                CodaHaleMetricsTracker something = new CodaHaleMetricsTracker(hikariPool, new MetricRegistry() );
                poolAccessor.setPropertyValue( "metricsTracker", something );
            }
        }
        return hikariDataSource;
```
Is there any reason that we cannot update the MetricsTracker after the pool was created? Would you accept a PR for it? E.g. introduce a method updateMetricRegistry(MetricRegsitry) on HikariDataSource which delegate to the pool and overwrites the metricsTracker internally (of course closing() and instantantiating the correct fields where needed?

@slyoldfox Before I commit one way or another let me run some performance tests.  Generally speaking, HikariCP uses final fields wherever possible.  Doing so allows the JVM to perform optimizations that would not otherwise be possible.   Whether the JVM is able to detect and eliminate "dead code" (DCE) depends on a variety of factors that are somewhat opaque.
If you look at the MetricsTracker class, you see the default implementation has no method bodies.  Further, take a look at BaseHikariPool.getConnection(), you'll see these lines of code:
198 final MetricsContext metricsContext = (isRecordMetrics ?
                                           metricsTracker.recordConnectionRequest(start) :
                                           MetricsTracker.NO_CONTEXT);
...
213 metricsContext.setConnectionLastOpen(bagEntry, now);
214 metricsContext.stop();

When metrics are not enabled, the JVM is able to detect that all of those methods result in zero code execution and the JIT completely eliminates those call-sites .  If you run a microbenchmark with microsecond resolution, you can actually see that the performance of the code is the same when those lines are actually deleted from the code and when they are present but metrics are disabled.
If isRecordMetrics is mutable (non-final) it also must be volatile because of cross-thread visibility requirements.  Once isRecordMetrics is volatile the JVM is required to emit code with a load-fence memory barrier, which has a large performance impact.  Additionally, because metricsTracker must also become mutable (non-final) the JVM can no longer be sure that the code in getConnection() is truly dead-code (even when metrics are disabled).  The JIT is therefore required to emit code that invokes metricsContext.setConnectionLastOpen() and metricsContext.stop() even in the case when metrics are disabled.
Again, I haven't benchmarked the code, but my gut feeling after doing this level of optimization for several years is that there will be a fairly high runtime penalty for making those mutable (changeable at runtime).

@slyoldfox Well, some good news.  The benchmarks are showing an ~1.7% decrease in performance by making isRecordMetrics and metricsTracker mutable, which is entering the realm of acceptable.
I am, however, considering making metricsTracker a "set-once" property.  But I believe that would be acceptable for your use-case, is that correct?

Hi Brett,
Thanks for taking the time to look into this. I indeed read about the removal of dead code in some other threads, I think it was in #112. Anyway a set-once property sounds fine, as long as it's able to set the metricsTracker after the pool was initialized and accessible from HikariDataSource (ideally). That way the metricsTracker could be easily set on @Bean initialization, independent of the Bean orders.
When you have a snapshot around, I'll gladly give it a try.

@slyoldfox HikariCP 2.3.4 has been published to the maven central repository, and contains this enhancement:
 * Allow Dropwizard MetricRegistry/HealthCheckRegistry to be set after pool startup -- one time
   only.

Tnx @brettwooldridge, I had already noticed and was in the process of bumping the dependencies in our framework.
I came across some dbcp 1.4 dependencies we use for unit testing/IT testing (using BasicDatasource). Although we don't use database access much (basically just installing test data and run some liquibase installer scripts), would you recommend using a (your) connection pool in this aspect? Or would you just limit it to more "heavier" production usage?
Also I saw that

javax.inject
javax.inject
1

wasn't marked as a test scope, although it seems only used in tests, is this a mistake or required (just asking because I noticed the dependency being added in our framework as well now.
Thanks for the good work :)

Doh, just about 10 minutes late.  I just published 2.3.5.  I marked javax.inject as 'test', but that won't appear until the next release, unless you want to build yourself.
No reason not to use HikariCP in place of dbcp for test, fewer dependencies right?

Exactly, one of the reasons I saw the javax.inject :)
I'll keep an eye out for 2.3.5, thanks!


how to add InsecureSkipVerify for http client in version v0.31

I have to connect gitlab through a gateway and ignore the tls check.
In v0.29, I could use
c := &http.Client{Transport: &http.Transport{
 	TLSClientConfig: &tls.Config{InsecureSkipVerify: true}}}
gitlab.NewClient(c, "token")

how to do this in new release? thanks.

@zhangpy this example is actuall shown in the release notes: https://github.com/xanzy/go-gitlab/releases/tag/v0.31.0

thanks :)


pkg2appimage fails to download appimagetool-x86_64.AppImage from github with 401 Unauthorized

Hello.
We are buiding AppImages on our continuous integration build server. Today the pkg2appimage started to spitting out the following error message. Running the same wget command runs fine on my computer, it just fails on the build server.
Now I am not sure whether there is an issue with github servers (it may very well be), whether github throttles us due to excessive traffic or something else. Anybody has an experience with a similar issue?
I think I had this discussion with @probonopd . If running the AppImage builder on a continuous integration build server, it becomes quite unfortunate if the build server breaks because something cannot be downloaded from somewhere. It would be great to have an offline option to build AppImages, however I suppose this is not the option as of now.
Thank you for your time.
+ URL=https://github.com/AppImage/AppImageKit/releases/download/continuous/appimagetool-x86_64.AppImage
+ wget -c https://github.com/AppImage/AppImageKit/releases/download/continuous/appimagetool-x86_64.AppImage -O appimagetool
converted 'https://github.com/AppImage/AppImageKit/releases/download/continuous/appimagetool-x86_64.AppImage' (ANSI_X3.4-1968) -> 'https://github.com/AppImage/AppImageKit/releases/download/continuous/appimagetool-x86_64.AppImage' (UTF-8)
--2021-12-08 15:53:15--  https://github.com/AppImage/AppImageKit/releases/download/continuous/appimagetool-x86_64.AppImage
Resolving github.com (github.com)... <IP_ADDRESS>
Connecting to github.com (github.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://objects.githubusercontent.com/github-production-release-asset-2e65be/9435153/b32f577d-9c37-48b0-80c4-cda7fed2baf1?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20211208%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20211208T155315Z&X-Amz-Expires=300&X-Amz-Signature=3d29831fb75b918ffdf3dd2b46879490a040c5fd54bad1b709d207699c38332a&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=9435153&response-content-disposition=attachment%3B%20filename%3Dappimagetool-x86_64.AppImage&response-content-type=application%2Foctet-stream [following]
converted 'https://objects.githubusercontent.com/github-production-release-asset-2e65be/9435153/b32f577d-9c37-48b0-80c4-cda7fed2baf1?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20211208%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20211208T155315Z&X-Amz-Expires=300&X-Amz-Signature=3d29831fb75b918ffdf3dd2b46879490a040c5fd54bad1b709d207699c38332a&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=9435153&response-content-disposition=attachment%3B%20filename%3Dappimagetool-x86_64.AppImage&response-content-type=application%2Foctet-stream' (ANSI_X3.4-1968) -> 'https://objects.githubusercontent.com/github-production-release-asset-2e65be/9435153/b32f577d-9c37-48b0-80c4-cda7fed2baf1?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A/20211208/us-east-1/s3/aws4_request&X-Amz-Date=20211208T155315Z&X-Amz-Expires=300&X-Amz-Signature=3d29831fb75b918ffdf3dd2b46879490a040c5fd54bad1b709d207699c38332a&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=9435153&response-content-disposition=attachment; filename=appimagetool-x86_64.AppImage&response-content-type=application/octet-stream' (UTF-8)
--2021-12-08 15:53:15--  https://objects.githubusercontent.com/github-production-release-asset-2e65be/9435153/b32f577d-9c37-48b0-80c4-cda7fed2baf1?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A/20211208/us-east-1/s3/aws4_request&X-Amz-Date=20211208T155315Z&X-Amz-Expires=300&X-Amz-Signature=3d29831fb75b918ffdf3dd2b46879490a040c5fd54bad1b709d207699c38332a&X-Amz-SignedHeaders=host&actor_id=0&key_id=0&repo_id=9435153&response-content-disposition=attachment;%20filename=appimagetool-x86_64.AppImage&response-content-type=application/octet-stream
Resolving objects.githubusercontent.com (objects.githubusercontent.com)... <IP_ADDRESS>, <IP_ADDRESS>, <IP_ADDRESS>, ...
Connecting to objects.githubusercontent.com (objects.githubusercontent.com)|<IP_ADDRESS>|:443... connected.
HTTP request sent, awaiting response... 401 Unauthorized

I cannot reproduce this. https://github.com/AppImage/AppImageKit/releases/download/continuous/appimagetool-x86_64.AppImage can be downloaded just fine. Please retry and comment in case the problem persists. Thanks!

I think I had this discussion with @probonopd . If running the AppImage builder on a continuous integration build server, it becomes quite unfortunate if the build server breaks because something cannot be downloaded from somewhere. It would be great to have an offline option to build AppImages, however I suppose this is not the option as of now.

If this is important for your use case, the  please open a ticket for it. As pkg2appimage is basically just a bash script, it shouldn't be too hard to change it in a way that uses a local copy. In fact, a simple check whether the file appimagetool-x86_64.AppImage exists and skipping the download if it does should do.

Thanks. At the end of the day, it looks like the issue was caused by a wget
utility on our docker image, which somehow happened to be no more
compatible with github.
Or something else, we had to rebuild the docker image as the old linux base
docker image was no more supported and now it works.
On Wed, Dec 8, 2021 at 7:41 PM probonopd @.***> wrote:

I think I had this discussion with @probonopd
https://github.com/probonopd . If running the AppImage builder on a
continuous integration build server, it becomes quite unfortunate if the
build server breaks because something cannot be downloaded from somewhere.
It would be great to have an offline option to build AppImages, however I
suppose this is not the option as of now.
If this is important for your use case, the please open a ticket for it.
As pkg2appimage is basically just a bash script, it shouldn't be too hard
to change it in a way that uses a local copy. In fact, a simple check
whether the file appimagetool-x86_64.AppImage exists and skipping the
download if it does should do.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/AppImage/pkg2appimage/issues/499#issuecomment-989083225,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABMPSI6Q4SRIX6ZIBX3ABKLUP6RERANCNFSM5JUFVIWA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Move code to use format args implicit

https://rust-lang.github.io/rfcs/2795-format-args-implicit-identifiers.html
It's available on current rust stable

This is the standard of our codebase now :)


Machine Pool Changes Saved Unexpectedly When Switching from Form to YAML Editor

Description
When editing a machine pool and then switching from Form mode to the YAML editor, changes are unexpectedly saved, even if the user cancels the operation. This behavior results in the machine pool values being updated when the user didn't intend to make any changes.
Steps to Reproduce (Edit as YAML commits changes)

Navigate to Cluster Management and click on "Create"
Provision a new RKE 2 Cluster (this has been reproduced with both DigitalOcean & VMware vSphere)

Give the cluster a name and leave all other fields as default
Click Create
Wait for the cluster to enter a ready state

Edit the cluster that was provisioned in Step 2

Change some values for a Machine Pool, for example update the Size of a Digital Ocean cluster from Basic: 4GB to Basic: 8GB
Click on "Edit as YAML"
Click Cancel

Expected

The Edit operation was canceled
All values are reverted to as they were before the editing began

Actual

Cluster enters an Updating state
Machine Pools values are updated even though Cancel was clicked

Additional Info

This issue has been observed on both DigitalOcean and VMware vSphere
The problem occurs when switching from Form mode to the YAML editor during editing
This behavior can lead to unintended changes in machine pool configurations

Given https://github.com/rancher/dashboard/pull/9798 / https://github.com/rancher/dashboard/issues/9724 this issue is back again

@richard-cox yes, we can move this one out. We get a warning when clicking on the Edit as YAML button with #9798, so the user will at least be notified that Machine Pools will be saved when switching to the YAML editor.

The current process involves the Frontend triggering a Backend call with the updated configuration to obtain the updated YAML for rendering. This involves a PUT request that saves the cluster with the modified configuration. Following discussions with @richard-cox, two potential solutions have been identified to address this matter:

Backend Solution:

Propose to the Backend team the creation of a new endpoint specifically designed to retrieve the updated YAML without immediately saving it.
In this approach, the Frontend would use the new endpoint to fetch the updated YAML and render it. The actual saving (via PUT request) would only occur when the user explicitly clicks on the "Save" button.
This approach eliminates the necessity for displaying a modal altogether, streamlining the user experience.

Frontend Logic Enhancement:

Alternatively, focus on implementing changes within the Frontend logic.
When the user initiates the "Edit as YAML" action, the Frontend could perform a check to determine whether the machine pools configuration has been altered.
If there are modifications related to machine pools, the Frontend would display a modal, prompting the user to Save and Continue. In other cases we would still save the changes without showing the modal.

I would vote we discuss option 1 with the BE. Requesting the machine config YAML that we can show inline when editing cluster YAML... and then save that YAML when the user clicks on saving the cluster would be better UX

I'll file a backend ticket and figure out how to get it rolling.

https://github.com/rancher/rancher/issues/43993 in place. Need to check on process to get that evaluated though I left it as a bug for now, despite it screaming feature request.

For internal coordiation, SURE-8093 is our reference.

Pushing to 2.10.0 since this has been around for a while and we're still backend blocked.

Backend closed their portion was Won't Fix (likely working as designed). This may have to circle back to the core issue with the pre-save state when editing and then toggling that we've had with the YAML editor. Putting back into Triage.


Winner promo cards are entered the same way as noEntryRequired

Relates #96

Sometimes the promo card giveaways have video requirement.
Maybe try this first, then if it fails, switch to the video requirement approach?

Updated


Resolve unsafe implementation of TrustManager, X509TrustManager

Since May 17, 2016 Google has begun blocking new apps, and app updates containing "unsafe" implementations of X509TrustManager
Details here: https://support.google.com/faqs/answer/6346016

This needs to be fixed or android applications can not use socialauth anymore.
What is the need of the Trustmanager code in org.brickred.socialauth.util.HttpUtil?
The doc does not say it.
The froyo code can be thrown out anyway as its less than 1% of Android users
https://developer.android.com/about/dashboards/index.html
But there is still a class DefaultTrustManager that does not perform any certificate checks for all other versions there.


https://podcasts.apple.com/ca/podcast/

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm reporting that yt-dlp is broken on a supported site
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and I'm willing to share it if required

Region
Canada
Provide a description that is worded well enough to be understood
Apple podcast not working
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['https://podcasts.apple.com/ca/podcast/esther-perel-how-to-find-build-maintain-healthy-romantic/id1545953110?i=1000669672563', '-v']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp (linux_exe)
[debug] Python 3.11.9 (CPython x86_64 64bit) - Linux-5.15.0-122-generic-x86_64-with (OpenSSL 3.1.6 4 Jun 2024)
[debug] exe versions: ffmpeg 4.4.2 (setts), ffprobe 4.4.2, rtmpdump 2.4
[debug] Optional libraries: Cryptodome-3.20.0, brotli-1.1.0, certifi-2024.07.04, curl_cffi-0.7.1, mutagen-1.47.0, requests-2.32.3, secretstorage-3.3.3, sqlite3-3.44.2, urllib3-2.2.2, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets, curl_cffi
[debug] Loaded 1830 extractors
[ApplePodcasts] Extracting URL: https://podcasts.apple.com/ca/podcast/esther-perel-how-to-find-build-maintain-healthy-romantic/id1545953110?i=1000669672563
[ApplePodcasts]<PHONE_NUMBER>563: Downloading webpage
ERROR:<PHONE_NUMBER>563: An extractor error has occurred. (caused by StopIteration()); please report this issue on  https://github.com/yt-dlp/yt-dlp/issues?q= , filling out the appropriate issue template. Confirm you are on the latest version using  yt-dlp -U
  File "yt_dlp/extractor/common.py", line 740, in extract
  File "yt_dlp/extractor/applepodcasts.py", line 48, in _real_extract
  File "yt_dlp/utils/_utils.py", line 2640, in try_get
  File "yt_dlp/utils/_utils.py", line 2631, in try_call
  File "yt_dlp/extractor/applepodcasts.py", line 50, in <lambda>
StopIteration

Duplicate of #10809


sharding+encrypt when sql contains "\n"，sql rewrite error  for mybatis. （in）

Which version of ShardingSphere did you use?
4.0.0  and dev branch
Which project did you use? Sharding-JDBC or Sharding-Proxy?
sharding-jdbc
Expected behavior
the (  are not in pairs , there are 5 (  in the actual SQL.
Actual behavior
ShardingSphere-SQL                       : Logic SQL: select
    *
    from user_info
     WHERE (  mobile in
                  (
                    ?
                  ) )

ShardingSphere-SQL                       : Actual SQL: ds1 ::: select
    *
    from user_info_1
     WHERE (  mobile in
                  (
                   (?) ) ::: [15xxxxxxxxxx]

Reason analyze (If you can)
Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc.
Example codes for reproduce this issue (such as a github link).

@SteNicholas  I add parse logic  of the IN operator bracket's index for encrypt rewirte, and use left bracket's startIndex to rewrite EncryptPredicateRightValueToken for EncryptPredicateRightValueTokenGenerator


Variables IR and Codegen

Partly addressing #61.

Thank you @grjte and @Al-Kindi-0 for the review. Made suggested changes.

Thanks @grjte. Fixed.


how we can test the model on a new image ?

@zqhang  @tianyu0207  thank you for your interesting work!
I'm wondering how we can "test" the model on one or few images without the need of training.
I hop you can explain how to do that..

I will upload the script in the repo recently.

@zqhang
Ah that will be great!!! I can't wait to see your script!!! :)

@zqhang
I would love to see that script aswell

Hi, we update the corresponding script and bash, namely test_one_example.py and test_one_example.sh

Brilliant! Thank you very much
Just one more follow up question:
How can I retrieve the anomaly classification probability?
I want to know if the model classified the object as an anomaly or not.


caching

Ideally caching is off by default when used a library using npm install enketo-transformer, and does not require a database.
However, when used as an app, it can be enabled in the config/config.json with "caching": true and then require a database such as redis (with additional config variables in config/config.json).
Caching could perhaps be done by creating a hash of the entire POST body, to be used as the db key.

We don't currently intend to strengthen Transformer for running as a standalone service. #161 will make this more explicit.


Remove the broken minikube start instruction from the docs

@rohitsakala tells me this works with the right Kubernetes version. I tested 1.20.6 with the virtualbox driver, which didn't work.
Also I think we should remove Thulio's ISO image.

Which part of the documentation is wrong ? I'm mostly testing with minikube (on kvm) and it's working nicely for me.


feat: add crypto lib

https://github.com/warp-contracts/warp/issues/357

I wanted to use jest env named jsdom however it is not perfect, for example it doesn't support window.fetch - https://github.com/jsdom/jsdom/issues/1724#issuecomment-720727999. This task was taking too long, so I took shortcut and I'm testing only in environment where API is not natively available (like fetch in node).


Feature request: make plugin work when Laravel App is served from a different domain/server

Problem:
In setups where the PHP app backend is being served from a different server than where the the one where frontend is running (say an API at http://backend.localhost), the plugin throws exceptions:

CypressError: cy.request() failed on:
http://frontend.localhost/_cypress/setup

Suggested solution:
There could be some sort of setting where you could specify to override the "baseUrl". For example, in cypress.json
env: {
  cypress-laravel-baseUrl: "http://backend.localhost"
}

When none is specified, than follow the current behaviour.

Hey thanks for the suggestion. It sounds reasonable, I'll look into it 👍.

I've released a new version (0.2.0) with support for this, thanks for your contribution in the PR!
I've also added a decoupled frontend with tests in the sandbox project, in case you want to see how I've configured it.


how to run multiple identical html xpra sessions?

How to run multiple identical html=on xpra sessions on different machines porting the same image/container - ie multiple users with single image - currently can only run one html browser session at a time...

Please clarify if you want to share the same container or the same image.
If you want to share the same container, i.e. running one instance only, but access the same instance from different machines, xpra has an option --sharing. From man xpra:
--sharing=yes|no|auto
              Sharing allows more than one client to connect to the same session.  This must be enabled on both the server and all  co-operating  clients  to  function.
              When  used  server-side, the default value auto allows the clients to decide if they are willing to share the session.  When used client-side, the default
              value auto evaluates to no.  To allow sharing to work with unix domain sockets (either using local connections or via ssh), you should create at least one
              socket  in  a  group  accessible directory. On Posix with a default configuration, being a member of the xpra group should be enough to create a socket in
              /run/xpra. You must also ensure that the permissions of this socket file allow group access, see socket-permissions.

If you want to run multiple containers, but only can access one of them (the first one?), we need to somehow specify the desired xpra server you want to attach to, maybe with different port numbers or X display numbers.

apologies for confusion - yes, sharing a single container instance by multiple users.
I also got a bit confused with the shadow flag - thinking that would allow sharing...
will try the --sharing=yes flag

oh yay! that worked!

Great!

Hi @mviereck
New to Xrpa/X11Docker.
Does this mean the users can share the same keyboard and mouse? How does that work? What about webcams? Does each user get an instance of the app or they all share the same instance? I think separate instances, right?

It's been a long time since I explored this, but yes, each screen port is interactive - so, I suppose you can share mouse and keyboard input - would cause some conflicts though?


add issue templates

What is the change?

Add issue templates

Why are we making this change?

By adding issue templates (a native github feature), we can prompt contributors to answer a few questions before submitting an issue.

When a user clicks new issue they will be prompted to choose which type of issue it is:

After choosing the type of issue, they will be shown a template inside the issues text area editor:

I'm down to include a template but I think it should be changed a bit. Like the one here https://github.com/terkelg/prompts/tree/master/.github/ISSUE_TEMPLATE

That's sounds reasonable 👌  I'll make changes

@terkelg - I copied the same templates from the repo you referenced:

https://github.com/terkelg/prompts/tree/master/.github/ISSUE_TEMPLATE

@terkelg - done. Thanks for letting me contribute lol 💯 🤘, I know how easy it could have been for you have done this.


Increase test coverage periodogram

Hi all, this PR adds a few more unit tests to the periodogram module. It primarily checks that errors are being correctly raised. I also added a docstring for the arguments return_trend and the return value bkg in the flatten method.

Codecov Report

Merging #387 into master will increase coverage by 0.07%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #387      +/-   ##
==========================================
+ Coverage   90.81%   90.89%   +0.07%
==========================================
  Files          26       26
  Lines        4246     4261      +15
==========================================
+ Hits         3856     3873      +17
+ Misses        390      388       -2

Impacted Files
Coverage Δ

lightkurve/periodogram.py
89.49% <ø> (+2.37%)
:arrow_up:

lightkurve/tests/test_periodogram.py
91.26% <66.66%> (-3.33%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b4bb66...0dfa4ac. Read the comment docs.


generate wrappers with full paths

The clang-archer and clang-archer++ scripts required setting LD_LIBRARY_PATH and ensuring that clang/clang++ were in ones $PATH. It also had an issue that if the clang installation had its own OpenMP library, while Archer was built with a side-install OpenMP runtime (i.e., with OMPT support), the OpenMP runtime from clang would be chosen instead of the side-installed one. This PR fixes these issues by hardcoding the path to the compiler and to the archer plugin. It also sets an rpath to the OpenMP runtime that Archer was configured against.

@lee218llnl The tests are ok, sometimes it fails one test because the OMPT runtime has still some problem that we need to take care of. So all is good. Thanks for doing this.


FoundationStream.cleanup() crashed with *** CFHash() called with NULL ***

I'm using Starscream (3.0.2).
Happens when user returns in the app from background after awhile and the websocket is trying to reconnect. I believe this is a continuance of this "fixed" error.

Fixed was a poor choice of words. That issue only had a part of a backtrace and I was just guessing I fixed it because it was related to something I was working on. It didn't have anything useful to reproduce the error, but If you have a sample app or some code I could look at that would be helpful. Outside of that, I'm not sure what is happening as I there aren't any known issues with reconnecting.

I'm also using Starscream 3.0.2 and encountered the same issue.

We're also just starting to notice this.  However, we're using v2.1.1.  I can let you know that we're getting it in our "low-bandwidth" testing. And, whether it's write or wrong ( a recent change on our end) is that our app immediately calls connect() from within the webSocketDidDisconnect delegate.  I'm thinking we should hold offer for a bit and wait a few seconds before retrying.

Interesting observation, I'm also calling connect() immediately within the webSocketDidDisconnect delegate on the first error, and then it goes in the backoff-mode retry.

3.0.3 has been released. It has some improvements/protections to help with this, but I'd make sure their aren't any race conditions when interacting with the WebSocket object. It is designed to have the public methods to be called from the same thread and that is normally what cases these crashes on cleanup. Also any sample code is greatly appreciated to help track down issues.

I have some new information regarding this issue.
Once I've added a small delay (0.5 s) before reconnecting in webSocketDidDisconnect delegate, the cleanup crashes stopped appearing completely. I am still using version 3.0.2, haven't upgraded to 3.0.3.
So, to investigate further, I've tried to reproduce the crash. I've downloaded SimpleTest example and added following code to webSocketDidDisconnect method in ViewController.swift.
DispatchQueue.main.asyncAfter(deadline: .now()) {
    socket.connect()
}

It's the same code I was using in production with my app before adding delay.
I enabled Edge profile in Network Link Conditioner to simulate "low-bandwidth" mode. Test scenario was to open the app, connect to websocket, send the message, get the reply, and then lock the phone, unlock and immediately click on Write Text bar button.
Even though I was not able to reproduce the crash, I was able to freeze the app completely -- app would be stuck on waiting in some queue on main thread. Here is the screenshot.

I managed to catch it quite few times, but still, not that often.
Then I added a small delay:
DispatchQueue.main.asyncAfter(deadline: .now() + 0.5) {
    socket.connect()
}

I somehow managed to reproduce the similar freeze, but only once, although I did try many, many times. This was the stack:

Interestingly, I looked up what was happening in Thread 60:

It appears that in method FoundationStream.write(data:) outStream was something, and outputStream was nil.
That would be all.


Add library charges for monatomic ions?

I've just run into an issue where I get an opaque charging failure if i try to parameterize a system containing sodium and chloride ions. I think this is because the toolkits don't now how to charge these ions. Now that we have support for library charges, we should likely just include charges for simple monoatomic ions (at least those for which our FFs have LJ parameters) in the file.
Does this seem reasonable to you @j-wags and @SimonBoothroyd ? (Tagging Simon since I know he'd been using these.)
Error follows:
-------------------------------------------------------------------
Exception                         Traceback (most recent call last)
<ipython-input-41-5d652a00e67a> in <module>
     20 # This is also true for ions
     21 #system = ff.create_openmm_system(off_topology, charge_from_molecules = mols)
---> 22 system = ff.create_openmm_system(off_topology, charge_from_molecules = [host_OFFmol])
     23
     24 # Set up system

~/anaconda3/envs/drugcomp/lib/python3.7/site-packages/openforcefield/typing/engines/smirnoff/forcefield.py in create_openmm_system(self, topology, **kwargs)
   1136         # Add forces and parameters to the System
   1137         for parameter_handler in parameter_handlers:
-> 1138             parameter_handler.create_force(system, topology, **kwargs)
   1139
   1140         # Let force Handlers do postprocessing

~/anaconda3/envs/drugcomp/lib/python3.7/site-packages/openforcefield/typing/engines/smirnoff/parameters.py in create_force(self, system, topology, **kwargs)
   2937             toolkit_registry = kwargs.get('toolkit_registry', GLOBAL_TOOLKIT_REGISTRY)
   2938             temp_mol.generate_conformers(n_conformers=10, toolkit_registry=toolkit_registry)
-> 2939             temp_mol.compute_partial_charges_am1bcc(toolkit_registry=toolkit_registry)
   2940
   2941             # Assign charges to relevant atoms

~/anaconda3/envs/drugcomp/lib/python3.7/site-packages/openforcefield/topology/molecule.py in compute_partial_charges_am1bcc(self, toolkit_registry)
   2012             charges = toolkit_registry.call(
   2013                       'compute_partial_charges_am1bcc',
-> 2014                       self
   2015             )
   2016         elif isinstance(toolkit_registry, ToolkitWrapper):

~/anaconda3/envs/drugcomp/lib/python3.7/site-packages/openforcefield/utils/toolkits.py in call(self, method_name, *args, **kwargs)
   3023                 method = getattr(toolkit, method_name)
   3024                 try:
-> 3025                     return method(*args, **kwargs)
   3026                 except NotImplementedError:
   3027                     pass

~/anaconda3/envs/drugcomp/lib/python3.7/site-packages/openforcefield/utils/toolkits.py in compute_partial_charges_am1bcc(self, molecule)
   1271
   1272         if quacpac_status is False:
-> 1273             raise Exception('Unable to assign charges')
   1274
   1275         # Extract and return charges

Exception: Unable to assign charges

Related to https://github.com/openforcefield/openforcefield/issues/305
I agree we should add these to the force fields.

Taking this one on as part of my work on #305. I believe these should be solved in the same PR.

Ah, sorry to be late to the party. I agree that we should add these to our force fields, and that using the integer values is unambiguously the right thing to do.

How would we like to proceed with pulling in the additions from openforcefield/openforcefield#305?

Per some discussion with @SimonBoothroyd @dotsdl and @mattwthompson earlier today, I think that we should make two NEW force fields immediately (corresponding to FOUR new files) --

openff-1.0.1.offxml: 1.0.0 w/ ion charges
openff_unconstrained-1.0.1.offxml: 1.0.0 unconstrained w/ ion charges
openff-1.1.1.offxml: 1.1.0 w/ ion charges
openff_unconstrained-1.1.0-.offxml: 1.1.0 unconstrained w/ ion charges

We should also plan for 1.2.0, our next release, to have ion charges included in it.
This numbering scheme may be a little confusing for people, but the alternatives (don't change the version, or add a -ions suffix, both seem to be worse). And, after all, this IS why we included a bugfix number in the versions.

100% agree. Thanks.

This has been addressed in #9 and #10. Releases have been cut corresponding to each, and packages will be built by tomorrow.


SESSION_MANAGER environment variable not defined

Describe the bug
The container is starting over and over, produces this log output:
DISPLAY = :1
VNC_COL_DEPTH = 24
VNC_RESOLUTION = 1024x576
VNC_IP = <IP_ADDRESS>
VNC_PORT = 5901

Connect to <IP_ADDRESS>:5901

Start script..
Failed to connect to session manager: Failed to connect to the session manager: SESSION_MANAGER environment variable not defined

To Reproduce
Steps to reproduce the behavior:

Install as instructed
Start container

Expected behavior
Container starts and keeps on running
Desktop (please complete the following information):

Docker Standalone 20.10.3 on Linux
Chrome
Version 123

Same issue here.


Add stack run show command

Add a command to show detailed information about a specific run.
This is a subtask of https://github.com/spacelift-io/spacectl/issues/33

this exists as run logs


chore: upgrade configuration

Currently the workflow is broken and is not able to upgrade configuration. With this upgrade the workflow file would fix and github workflow would be able to upgrade this on its own.

💔 All backports failed

Status
Branch
Result

❌
1.x
Backport failed because of merge conflicts

Manual backport
To create the backport manually run:
backport --pr 1715

Questions ?
Please refer to the Backport tool documentation


Redesign: Change recent conversation icon.

This pr changes recent conversation icon as discussed in CZO along with adding it's documentation in THIRPARTY.md

Fixes: #29180

Screenshots and screen captures:
Dark Mode

Light Mode

Note: zulip-icon-clock was not deleted as it is still used in personal-menu.hbs

Self-review checklist

[x] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[x] Explains differences from previous plans (e.g., issue description).
[x] Highlights technical choices and bugs encountered.
[x] Calls out remaining decisions and concerns.
[x] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[x] Each commit is a coherent idea.
[x] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[x] Visual appearance of the changes.
[x] Responsiveness and internationalization.
[x] Strings and tooltips.
[x] End-to-end functionality of buttons, interactions and flows.
[x] Corner cases, error conditions, and easily imagined bugs.

Merged, thanks @nimishmedatwal!


Display error message on enabling TrustyAI via UI

Closes: #1996
Description
This PR aims to display error message on enabling TrustyAI via UI.

How Has This Been Tested?

Create a Data Science Project
Navigate to DSP page
Click Settings
Check the Enable TrustyAI checkbox, you will show the error (only if  TrustyAIService CRD not installed on your cluster)

Test Impact
NA
Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[ ] The developer has added tests or explained why testing cannot be added (unit tests & storybook for related changes)

If you have UI changes:

[x] Included any necessary screenshots or gifs if it was a UI change.
[ ] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

Works fine
/lgtm

@alexcreasy this might be benefited from us making use of my #2032 PR to just straight up hide the checkbox.
We'll need to probably pivot to that over time, this may be okay for now if you approve of it.

@alexcreasy this might be benefited from us making use of my #2032 PR to just straight up hide the checkbox.
We'll need to probably pivot to that over time, this may be okay for now if you approve of it.

@andrewballantyne thanks for the comment, if I'd read it earlier it would have bypassed a whole slack conversation lol. I'm still going to approve this PR (pending changes) as it fixes a flaw in the current implementation and at least makes this usable for now. I'd like to look at utilising your PR as a priority afterwards when possible.

/approve

@andrewballantyne This feature  is not  available in 2.5.We have Components and Permissions tab on data science project page,No Settings tab.

@sthundat This is not in 2.5, you won't see it there.


Reducing the overfit training time by avoiding repetition of the validation step

Hi! Thanks for sharing this amazing work. This is a minor issue but in my case reduced the overfit training time significantly:
Currently, the validation step is being executed 64 times at every val_check_interval (with the same data each time, generating 64 visualizations that are overriden 63 times). This is because the num_workers of the dummy validation DataLoader is set to 64.
The above can be avoided by simply setting num_workers=1 in the val_dataloader method of DataModuleOverfit.  Alternatively, a limit_val_batches=1 can be set at Trainer initialization in overfit.py but this may be sub-optimal because I think it would still launch the 64 subprocesses.

Is this an issue with the code at head? It seems the number of workers is hard-coded to 0:
https://github.com/dcharatan/flowmap/blob/2be1b9ef8a22513da99b1d7611362f33f9f6481a/flowmap/dataset/data_module_overfit.py#L29


CodeQL for Github Action not failing on test case failures

Describe the bug
We noted that Build for Github Action did not fail even after the test cases failed.
To Reproduce

Open any PR. PR for reference - https://github.com/IBM/networking-go-sdk/pull/107/
Go to checks for the PR
Open Analyze (go) on the left side tab
Expand the Autobuild step and check test cases

Expected behavior
It is expected for Github Action to fail, as the test cases have failed.
Screenshots

Must gather (please complete the following information):

SDK Version [e.g. 1.2.1] - v0.36.0
Go Version [e.g. 1.12.15] - go1.18.1 darwin/amd64
Name of service that you're trying to use (if applicable)
Name of operation that you're trying to invoke (if applicable)

Additional context
It is expected for Github Action to fail, if the test cases are failing. This breaks the basic idea of building and testing the PR before merging it to the master.
Point to mention that we have Travis build for merge commits only.

@moisesatwork I believe we will need to write custom scripts for CodeQL to run the build in the first place. Right now, the build is auto generated, hence most of the test cases are skipped.
Also, 1 more important point to note here is that the integration test cases need env files to run, which we will have to encrypt in order to use during the build. (Similar to how we do for Travis builds)


cargo-espflash not picking up partitions.csv?

I cloned the repo and ran:
MCU=esp32c3 cargo espflash flash --target riscv32imc-esp-espidf --example wifi --monitor

And I got this error:
Error: espflash::image_too_big (link)

  × Supplied ELF image of 1799664B is too big, and doesn't fit configured app partition of 1048576B
  help: Reduce the size of the binary or increase the size of the app partition.

This is the current partitions.csv:
# Name,   Type, SubType, Offset,  Size, Flags
# Note: if you have increased the bootloader size, make sure to update the offsets to avoid overlap
nvs,      data, nvs,     ,        0x6000,
phy_init, data, phy,     ,        0x1000,
factory,  app,  factory, ,        3M,

The app partition seems to be set to 3M. And no matter how I change partitions.csv, I keep getting the same error.

I solved the issue by generating my own partitions-table.bin:
espflash partition-table --to-binary --output partition-table.bin partitions.csv

Then:
MCU=esp32c3 cargo espflash flash --target riscv32imc-esp-espidf --example wifi --monitor --partition-table="partition-table.bin"

If you are using espflash than this is not a problem, but cargo espflash works a bit different. Because they made changes in the respected versions 3 of espflash and cargo espflash we now provide the partitions.csv in the root. Though with the extra espflash.toml file it should automatically pick it up.
What version of espflash are you using? It should working with a csv file and if not it may indicate a bug in espflash

Ah, I updated espflash and cargo-espflash. The error is gone. Sorry, I should have done that before opening this issue.

My espflash is 3.1.1 but the issue is still there

 My espflash is 3.1.1 but the issue is still there

No it is not a problem. Please read the comments carefully. You are using espflash where you have to provide the partiton-table as an argument. Only cargo espflash has the capability to pick it up for you.


[RFC][Java] remove FuryBuilder#requireClassRegistration API

Is your feature request related to a problem? Please describe.
FuryBuilder#requireClassRegistration can be used to disable unknown classes check, but the API didn't indicate it's not safe.
kryo has a setRegistrationRequired API, which has similar semantics.
Describe the solution you'd like
Maybe we should remove it, let users use FuryBuilder#withSecureMode(false) instead. The drawback is that it may let users think fury isn't safe, which affects the usage of fury.

@tisonkun how do you think if we remove FuryBuilder#requireClassRegistration api, use FuryBuilder#withSecureMode(false) instead

Or we can rename requireClassRegistration to allowUnknownClasses

Will Renaming withSecureMode to withSecurityChecks better?

After some discussion, removing withSecureMode by requireClassRegistration will be better


Increase RAM used by vanilla minecraft server?

Hey!
First, wonderful work on that image, thank you. Second, I have read the doc and I'm unable to find how to customize the amount of RAM used by the server. I can see by default it uses 1GB, how to increase to 2GB? Also, is it possible to change that setting without having to re-run the container?
Thank you in advance,
Dany

Thanks!
Unfortunately the documentation limit on Docker Hub chops off the section you needed. The full README has this section which should help:
https://github.com/itzg/docker-minecraft-server#memory-limit
Unfortunately you will need to restart the container for the java process to get re-invoked with the increased memory limit; however, any attached volume will persist just fine across the container restart.

I realize this is closed and old but i'm having real trouble with getting this to work.
I'm trying to run this server with the following:
sudo docker run -d -p 25565:25565 MEMORY=6G --name mc3 -e MEMORY=6G EULA=TRUE itzg/minecraft-server
However I just receive this:
docker: invalid reference format: repository name must be lowercase.
I'm not sure what i'm doing wrong. If I remove the MEMORY variable I can run the image just fine.


chore: update owners

@dsarlis do you know if we can add individuals to owners? I have a vague memory hearing that we should only add teams, but I'm not entirely sure. Do you recall?

I asked around but didn't get a concrete answer. I'll merge this to not lose the momentum of our work and if this ends up violating some policy then we can adjust accordingly later.


How to disbale auto translation？

No way at the moment. May I ask what makes you want to disable it?

Translation error and I can't learn other languages

Interesting.. Are you interested in seeing the raw content of all other languages or just a few? Do we want a complete disable or just a list of languages you don't want to translate?

all other languages,translate a particular one if necessary

Recently I am curious about the language of Israel, and sometimes I read Japanese.  word is very interesting

So, if you add those languages to Android's System languages  (Settings/System/Languages and Input) the app will not translate from those.
For me: I have Portuguese and English as system languages so the app doesn't translate from those. But I need translations from everything else.

Okey

Why i have to add an system language
To deactivate  an feature in an app ?
Thats makes no Sense in imho

The idea is the same that other apps use: It doesn't translate the languages you use.
But an option is coming.

And thats the Problem cause on some devices ur not able to add multiple languages.

But an option is coming.

👍


this fixes a very obvious bug in the mpl figure saving (but is built on top of another open PR)

Coverage increased (+0.03%) to 76.891% when pulling 08fda0eb3a91195e7eb4706fbf5dd31e36be16f7 on keflavich:fix_mpl_figuresaving into 9d81b3b6f0ff517a6f55094164e727158e837628 on radio-astro-tools:master.


ControllerCfg Language Issue

@Yanyan-Wang I have raised the question regarding changing the text in Issue #2597. You have mentioned that its fixed in version 4.1.5 and its working fine.

But whenever I tick the checkbox. The language changes to another Chinese word and then it never changes back to the Configured text.
When Check

When Uncheck after check

Ops, try 4.1.7 pls.

Ops, try 4.1.7 pls.


workflows.yaml: Fix Github Actions and various fixes

github action for Ubuntu 22.04 i386 fails during installing dependencies - try to upgrade the image before installing to prevent having an outdated image (in case Github doesn't update it...)
use ubuntu-latest, so we automatically use the latest stable, but print out the pretty name in workflow to show which version it is (dont wanna to look up the names :))

@tillkamppeter Ubuntu 22.04 i386 fails to install some build dependencies, would you mind looking into it? I've tested it in my VM and it was installed fine.

@zdohnal @michaelrsweet FYI there is a security bug that I sent to Apple last week on CUPS that I did not put here yet.
Just saying this in case you plan to put out CUPS this month. Where should I email you about it?

There is a security tab at OpenPrinting/cups github page - you should be able to privately report a possible vulnerability. (I'll update the SECURITY.md on Monday to reflect this).


Generalize unigram and bigram ingest methods

create_unigram_book_counts and create_bigram_book_counts are redundant. Refactoring may make sense so that the updates made to one don't need to be copy-pasted. Ultimately, the functions are the same, just arguments and naming are different.

It would be good for this method to include a two variables that specifies the bits used to store the wordids and bookids.
Just sketching it out, something like this.
    def create_wordcount_table(ngrams, wordid_bytes = 3, bookid_bytes = 3):
        """
        wordid_bytes: 3 or 4. The number of bytes to store wordids; 3 reduces file sizes by 25%
                   and may speed up queries, but limits the vocabulary to 16 million words.
        bookid_bytes: 3 or 4. the number of bytes to store wordids; 3 reduces file sizes by 25%
                   and may speed up queries, but limits the library to 16 million documents.
        """
         vartypes = {3:"MEDIUMINT UNSIGNED", 4: "INT UNSIGNED"}
         table_string = "TABLE word1 {}, bookid {}, count MEDIUMINT UNSIGNED".format(vartypes[wordid_bytes],vartype[bookid_bytes])

I know of one group that has hacked at the code to allow bookid to be an INT UNSIGNED rather than MEDIUMINT UNSIGNED, which is necessary if ingesting more the 16 million volumes. There is a little work that needs to be done in other places before this support is total, but it would be nice to lay the groundwork here.
A two-byte int goes to 65,000 and a one-byte int to 255. I can imagine a few cases where these might be useful if you're using a Bookworm to store named entities rather than actual words. But space is unlikely to be as big a deal in those cases as in the base one. 3 and 4 are the only ones necessary to support.


Add build_random_teams function

Closes #30

TODO:

[x] Test the function
[x] Give the possibility to filter by race (e.g. 50 Butterfly)
[x] Give the possibility to filter by category
[x] Give the possibility to filter by sex

Maybe I can add more tests in the future but seems ok now


errors: define a better error handling

we are currently doing this:
return err

or in the best case
return errors.Wrap(err, "unable to ...")

We should find a way to display properly the errors generated by swagger and generated by the CLI himself to guide the user in its debugging.

Update adding a standard error to reproduce details not displayed:
.1 create an org containing a project
.2 try to delete the org
The CLI currently display only
Error: unable to delete organization: [DELETE /organizations/{organization_canonical}][409] deleteOrg default &{Errors:[0xc000488240]}

The API send a 409 error with this payload:
{"errors":[{"code":"ConflictDeletingOrgHasProjects","message":"organization cannot be deleted because it has some projects","details":["Projects should be deleted in order to delete the organization"]}]}


NullLS - call done() at the end of completion source (fix for Mini.Completion)

Omnifunc refuses to open when using mini completion without properly calling done(). This PR fixes the issue

Thanks for the contribution. Please fix the stye with stylua and I will merge it


Fix minor issues found in release docs

Fix issues reported in [1].
[1] https://docs.google.com/spreadsheets/d/1k4cpm089Z71XkE_Qi4Cg10ClBKo-gTWpbcKwNRg8kNs/edit#gid=1720860820


Bundler hooks

The virtual filesystem (Package objects and file objects) is owned by the bundler (not the bundles). In other words, all bundles use the same objects.
We need an API that lets "bundle plugins" hook into the filesystem when at least one bundle is using them. The main use case I have in mind is for loading plugin-specific configuration for each new Package object.
The hookPackages method does not fulfill this need in its current form, because it creates a function for every Bundle object. Package configuration would be loaded once per bundle that uses the plugin, which is undesirable.

It's easy enough to track which packages have had their configuration loaded by using a WeakMap object. Closing this for now.

Update: Packages are now created once per bundle, so loading a package's config files every time a bundle uses a package is unavoidable. And it's really no biggie. 😁


Changed CSS selector for ion-spinner

Short description of what this resolves:
The current Ionic2 Documentation states that you select the spinner via CSS using ionic-spinner svg.
This is no longer the case per Mike: https://forum.ionicframework.com/t/ion-spinner-color/46324/6
Changes proposed in this pull request:

Just a simple CSS selector update

Ionic Version: 1.x / 2.x
Fixes: #

Thanks!


Can't type or copy/paste in python interactive window

Issue Type: Bug
Seems like randomly it allows me to type and copy/paste commands.
Extension version: 2020.11.367453362
VS Code version: Code 1.51.1 (e5a624b788d92b8d34d1392e4c4d9789406efe8f, 2020-11-10T23:34:32.027Z)
OS version: Windows_NT x64 10.0.19042

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz (8 x 3600)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
31.83GB (14.27GB free)

Process Argv
C:\Users\ansalced\Downloads\PowerPoint_web_drivers_analysis.ipynb --crash-reporter-id ab6e5b6b-9a23-4324-8ca6-95b75b096ca7

Screen Reader
no

VM
0%

the same is happening to me, this is driving me crazy! I also reported the issue.

Same for me on Windows 10 and on my Macbook! Happens a few times every 10 Minutes. Python extension and VSCode version up to date.
Another way to "fix" this is to drag the tab into another area (I think it refreshes the GUI Elements).

Dupe of #446. A fix should be coming soon.


Fix detection on HP-UX (IA64)

HPE has a weird preference to prefix letters and zero-padding. Properly trim them before processing.
========
I see the following Perl warnings and misdetection on HP-UX IA64:
# PATH=/opt/perl2/bin:$PATH ./config --help
Use of uninitialized value $_ in substitution (s///) at /var/tmp/ports/work/openssl/util/perl/OpenSSL/config.pm line 85.
Argument "A" isn't numeric in multiplication (*) at /var/tmp/ports/work/openssl/util/perl/OpenSSL/config.pm line 346.
Configuring OpenSSL version 3.3.0-dev for target hpux-parisc
Using os-specific seed configuration

After the fix:
# PATH=/opt/perl2/bin:$PATH ./config --help
Configuring OpenSSL version 3.3.0-dev for target hpux-ia64
Using os-specific seed configuration

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set.  Please review the updates and set the label manually.


Add joystick to Vector3d

I love the joystick and would love to use it to set a Vector 3d. One way it could work is if we allow the user to set the vector plane by plane and let them quickly change between planes.
Tap the joystick to show the existing 2d joystick applied to a plane. Tap a button to switch planes, or use modifier keys, to quickly switch between them. As an added bonus the joystick grid could rotate to the new plane when switching.
Thoughts?

beautiful!

Working through this on a draft PR here: https://github.com/pmndrs/leva/pull/433

Currently looks like this:

Next issues:
[ ] Dragging to the edge "upsets" the values
[ ] Draw the Joystick buttons below

Added hotkey labels to the buttons
Changed zx to xz so that moving the mouse in x changed the value in x (and not z)
Changed the hotkeys to Control and Meta to allow for the simultaneous use of the precision modifier
Reordered the buttons to physically match the keyboard

Added some depth and animation 😇
Changed YZ to ZY to shat moving the mouse in y changed the value of y (and not z)

https://user-images.githubusercontent.com/99606/214908484-712bcecf-18bf-410a-9f95-3490f8c01e8f.mov

I added comments in the code where I could use help. I'm sure there's more.
I also just remembered I'm getting an error in the console regarding validateDOMNesting(...): <button> cannot appear as a descendant of <button>. In effect I'm using buttons, but I'm not really using them as buttons.
I'm also wondering how this would work on touch devices (probably more like buttons ;)


Be specific about licenses

I put the CC BY 4.0 text in LICENSE, since it covers most of the content in the repo. However, I'm open to making it a file that points to specific licenses insteaad.
Fixes #136

Whoops, forgot to run Prettier. Prettier-ed and updated.


Guys, Ver. 3.8 works! Downgrade to 3.8.

As suggested by another thread, I downgrade to 3.8 from 5.5 and no more YT's annoying message about adblock or weird sound issues. Please downgraded to 3.8. The link to 3.8 is provided in one of the threads below this one. Hope this helps!

cant you just, send the link maybe insteaf of sending us out on a hide and seek mission?-

cant you just ... send the link maybe? Instead of sending us out on a hide and seek mission?-

https://github.com/TheRealJoelmatic/RemoveAdblockThing/releases/tag/v3.8

your a goat man :D
thank you and i really hope you can find a fix for the bugs which is happening in 5.5 ^^;
remember, dont rush it!! you already made so much for us with just creating this in the first place and keep developing it :)

your a goat man :D
thank you and i really hope you can find a fix for the bugs which is happening in 5.5 ^^; remember, dont rush it!! you already made so much for us with just creating this in the first place and keep developing it :)

your a goat man :D
thank you and i really hope you can find a fix for the bugs which is happening in 5.5 ^^; remember, dont rush it!! you already made so much for us with just creating this in the first place and keep developing it :)

I am not the orignal owner of this script, I am putting up PR's tho to try to solve some issues, just another open source member, but thank you!

cant you just ... send the link maybe? Instead of sending us out on a hide and seek mission?-

https://github.com/TheRealJoelmatic/RemoveAdblockThing/releases/download/v3.8/Youtube-Ad-blocker-Reminder-Remover.user.js
REF: https://github.com/TheRealJoelmatic/RemoveAdblockThing/releases/tag/v3.8

Thanks. That worked.
I'd guess is that Youtube is chasing the script as it changes. Youtube has made a change that messes up v5.5 of the script, but the change also happens to undo previous YouTube attempts to disable the script.

so clean!!!!!!!!! so cool!!!!!!! TY!!!

not useful. I downgrade to 3.8 and welcome ads back to me again

It works! Thanks mate

version 3.8 is being recognized by youtube

version 3.8 is being recognized by youtube

No, it's working perfectly fine for now.

Thanks, it's working (for now).

Ver. 3.8 still works for me perfectly without any issues. My region is set to Canada. Hope this helps. I guess we'll have to wait until Ver. 5.6 solves all the problems. Thanks!

Ver. 3.8 still works for me perfectly without any issues. My region is set to Canada. Hope this helps. I guess we'll have to wait until Ver. 5.6 solves all the problems. Thanks!

I'm actually in Canada and the YT adblocker screen sometimes appears. If you refresh the screen several times, the adblocker page goes away.
I went back to v3.8 yesterday and it worked perfectly until now.


OKD4 (UPI) on Openstack with terraform

I think all was covered in subsequent commits? Anything else?

Looks good, lets fix one last path issue, squash - and its good to go.
Thanks!

Like so?


🦺 Support digits in local-part of EmailAddress

📝 Description
With our current implementation of the EmailAddress type, its local-part doesn't accept digits.
Reconsidering digits as valid characters for local-parts, we would like to update the regular expression of this type for doing so.
// Before
val address: EmailAddress? =
<EMAIL_ADDRESS>println(address) // null

// After
val address: EmailAddress? =
<EMAIL_ADDRESS>println(address) //<EMAIL_ADDRESS>
The local-part of an email address can start, contain or end with a digit. Here are some valid examples:
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
🔗 Dependencies
This issue is blocked by the following ones:

[x] #394

✅ Checklist

[x] Update the regular expression of EmailAddress, update its tests, update the tests of create* functions, update the unreleased changelog.
[x] Close this issue as completed and update tracking ones if present.

We should also update the documentation of the EmailAddress.Companion.regex property.


Feature: "View" creation

Summary
This PR includes the feature of including views and constraints in the logical modeling. Along with these new features, the organization of components and the display of table information have been improved.
Tutorials
https://github.com/brmodeloweb/brmodelo-docs/pull/1
Screenshots
Components

queryExpressionModal: Modal component used in the view creation form, in which it is possible to create the query expression, and if the view has more than one base table, inform the attributes that form the JOIN;

sqlComparasionDropdown: Dropdown that is used in the view and check constraint form, which based on the attribute type displays comparison operators in SQL;

checkConstraint: Component that creates the check constraint;

columnForm: Edit/Add Form Component for Table Column;

sidebarControl: Component that displays table information, allows editing columns and editing the view that has the respective table as a base;

view: View add/edit form component.

@ArthurMota9 @oicramps Do we have any news about this?
There are some pending improvements waiting to be worked on. Can we fix this?
Also, @miltonbsn Once those are done, can we move forward merging it to development ?

@ArthurMota9 @oicramps Do we have any news about this? There are some pending improvements waiting to be worked on. Can we fix this?
Also, @miltonbsn Once those are done, can we move forward merging it to development ?

I'll make the suggested adjustments today.

Brilha @ArthurMota9


Tutorial template draft: needs new examples

This snippet is a stripped down version of the old tutorial, with examples removed. Would probably be good to develop some more complex examples (to demonstrate the value proposition better). (This could be an effort post-initial release.)
(template is provided in raw markdown here and in attached text file because GH doesn't support attaching markdown files :-( )
TUTORIAL_template.txt
Tutorial
The ksonnet readme
shows you how to create a default
deployment.json file that lets you deploy an nginx container
to an existing Kubernetes cluster. This tutorial shows you how to:

Modify the deployment using ksonnet definitions
Define other Kubernetes objects
Work with mixins to develop complex configurations

Prerequisites
This tutorial assumes that you have performed the following
tasks. For details, see the readme.

Installed Jsonnet
Cloned the ksonnet repository locally
Installed and configured the VisualStudio Code extension
(optional)
Created a test Kubernetes cluster

NOTE: All import paths are relative to the root of the
ksonnet* repository.
Modify the default deployment
ksonnet lets you configure or modify any Kubernetes object.
For example, to customize the default <> deployment, you can write:
// TODO: provide ksonnet example

Save the file as customDeploy.libsonnet
and run:
jsonnet customDeploy.libsonnet
kubectl apply -f deployment.json

(here we seem to be looking at YAML we get from running
kubectl get deployment <appName> -o yaml but in other examples
we're looking at JSON generated from ksonnet. Figure out, fix.)
And the generated YAML looks like this. You can see the new <>
and <> fields:
# TODO: provide example

Define other Kubernetes objects
ksonnet lets you define any Kubernetes object. For example,
you can define a container:
// TODO: update ksonnet example; container is probably a good one
// consider whether nginx is the right one for deployment
// (issue also in previous example)

Save this snippet as container.libsonnet, and run:
jsonnet container.libsonnet

The JSON output looks like this:
TODO: fix up to be consistent with YAML vs JSON
across tutorial examples
(EXAMPLE)

You can include a liveness probe with your container:
// TODO: ksonnet example. Is liveness probe appropriate here?

Save the file again -- container.libsonnet --
and run:
jsonnet container.libsonnet

(As above, YAML or JSON?)
The JSON output now looks like this:
(EXAMPLE)

Now you can define a pod that runs this container:
// TODO: ksonnet example

Save the file as pod.libsonnet, and run the following commands
to deploy the pod to your cluster:
jsonnet pod.libsonnet // create pod.json
kubectl apply -f pod.json // apply pod definition to cluster

Work with mixins
You've seen how to modify the default deployment by writing
mixins to add custom fields.
As the Jsonnet tutorial explains in more detail, mixins provide
dynamic inheritance, at runtime instead of compile time. This
approach means that different team members can define the
Kubernetes objects that they need. You can then mix them into
your master definition without having to copy all the details.
For example, you could write the following code to define a
container for your application:
// TODO: ksonnet example

And your teammate could write the following code to define
the VolumeMounts:
//TODO: ksonnet example

Then, you write a deployment definition for the container that
adds the VolumeMounts for logging using mixins:
//TODO: ksonnet example with mixins

This is related to #35. I'm hoping to have time for this next week.

I'm not sure if this is entirely helpful for the tutorial, but now that we have a production-ready mixin collection (currently of cardinality 1 🤓 ), I think we are close to being able to close this.

beta.2 shipped today, so I think we can close this.


rgb24 Palette support

Hi Larry, I've been maintaining Craig Lindley's AnimatedGIFs sketch for years, and had always wanted to turn it into a platform-independent GIF Decoder library.  I finally got a chance to start this year, a few weeks before you released your library and made my work obsolete :-)
I'd like to start using your library for my GIF projects, but it's missing one critical feature: rgb24 palette support.  I'm using GIFs to drive LED matrix displays with high color depth, for projects like this, so I need to get the full 24-bits of color from the source image:
https://www.instructables.com/Continuum-Slow-Motion-LED-Art-Display/
It looks trivial enough to fork your library and change to using rgb24 palettes, but I'd prefer to have the palette type be selectable in the sketch (not through changing a #define in the library), without slowing existing rgb565 performance, so other people can use the feature easily.  The best option I can come up with right now is to use C++ templates to choose between the two palette types, but I saw you rewrote your library to use C, so that's probably out.  Arduino doesn't make this kind of library configuration easy.
Do you have any easy solution for this off the top of your head?
Would you even want to support rgb24 in addition to rgb565 in your library, or is this something I should tackle on my own?
I've been enjoying your updates on twitter with your different display libraries.  I don't have any active E-Ink projects, but I do have some in mind that could make use of the work you're doing, keep it up!

That's a reasonable request and easy to implement. Just like the pixel type, I can allow you to choose the palette type before calling open. I can either return the 24-bit palette by casting the uint16_t pointer or alias another pointer to the same buffer. The only down side is that it will require 512 more bytes of RAM to hold the main and alternate palettes in RGB24 format. I'll work on this later in the week. Thanks for the suggest 👍

Glad you have a way to do it easily, I'm looking forward to trying it out when you're done!

I pushed the change to the main branch. Please give it a try and if you're happy with it, I'll do a new release.
The change for you is that the begin() method has an optional second parameter to set the palette type (GIF_PALETTE_RGB888 or GIF_PALETTE_RGB565 / default). The GIFDRAW structure now has a uin8_t pointer for the 24-bit palette (which points to the same internal buffer).

Awesome!  I got it working, after modifying the play_all_sd_files example to run with SmartMatrix Library on the Teensy 4.1.
I don't think there's a rush to do the release until there's a working example, which I can contribute if that helps.  It may take me at least a few days though, as I want to fully understand the capabilities of your library and not just rush out a proof of concept example.
No big deal to me, but I see your change on the linux branch, not main.

Thanks for testing it - oh - you're right about the branch. I'll fix that.


LH Processor hits LH memory limits

Describe the bug
LH Processor hits LH memory limits
To Reproduce
Steps to reproduce the behavior:

Set mem limit to 2GB and see LH processor stop processing coz it hits mem limits

Additional context
Need to profile the mem in local to find out why it grows so big not, but was not before.

First instance of reaching mem limit correlates with the time of the core incident:

Why did it jump 3X over subsequent iterations ?

Bumped mem limit to lambda max:
https://github.com/connext/monorepo/commit/9af7f42eb6a22a3e2edb0afee1535f72095b759f

Bump to 10240 helped:


Some swappers not providing monero anymore

Some of the swap sites, 2 out of the 5 listed to be precise are not able to provide monero swaps
Doesn't work:
https://godex.io/ - Probably used only one exchange which removed Monero
https://fixedfloat.com/ - For other technical reasons but also most likely using that same exchange only
Works:
According to their website they have access to at least 2 or more exchanges that have support for Monero for now
https://changenow.io/
https://simpleswap.io/
https://stealthex.io/

Thanks. Does @MajesticBank have access to the same/less/more xmr after the binance delisting?

I can speak about the volume itself, which goes up to x3 from the same period of last year.
MajesticBank was never dependent  on centralized exchanges liquidity in first place,
Hopefully with spot market and two more integrations with monero-only wallets we are closing the question of liquidity

Fixedfloat was due to repeated hacks afaik

we have removed fixed float, but godex not, oops


Shorten names for custom unignore

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (65f96b9) 90.42% compared to head (f7c5e71) 90.42%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #1405   +/-   ##
=======================================
  Coverage   90.42%   90.42%
=======================================
  Files          49       49
  Lines        6028     6028
=======================================
  Hits         5451     5451
  Misses        577      577

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


feat(ci): integrate with travis

Requesting reviews from @helgi and @mboersma

Well... this appears to work, but I just realized I am missing the special sauce to clearly tag these as v2-alpha builds.  Fixing that now.

Ok.  Should be better now.

But probably needs re-review.

@mboersma your last bit of feedback has been addressed.  The only differences between my script and deis/etcd's (where I copied it from) is that my make target it calls is just push instead of docker-push.  If all of us want to get together and hash out our opinions on how to name targets consistently across components, that's probably an entirely separate conversation that I wouldn't want to hold up this PR... but it probably needs to happen at some point.


Dapr not able to find service after type changed from ClusterIP to LoadBalancer

We have five microservices and using dapr for inter communication. All the services were running initially as LoadBalancer and we changed it to CluserIP and then put it back to LoadBalancer. Now the services are not able to connect and we are getting the below error,
Dapr.Client.InvocationException: An exception occurred while invoking method: 'v1/users/getbyid?id=57c8a29b-ebc3-4f4f-9a3f-bf3cf3417e29' on app-id:
Is the error happening because we changed the service type?

@rajagopalanrg yes, you are not supposed to change the service type. these services are governed by the Dapr operator. If you want to expose new services, you need to create additional ones.


Revise 'AddressPool' to work with address public keys

Context

Our 'AddressPool' currently keeps track of a pool of 'Addresses' which has a major drawback:

A spending address public key can be associated with infinitely many delegation key (which may result in an infinite number of addresses corresponding to same spending key).

When discovering addresses, the wallet should only look at whether the spending key belongs to it. It is possible to create addresses that use a delegation key that belongs to another wallet.

Decision

Review 'AddressPool' to work with address public keys instead of addresses.

Review address discovery capabilities to also use keys instead of addresses when relevant.

Acceptance Criteria

The sequential discovery must use a single address pool per accounting style to keep track of all transactions made using address public keys derived from the pool's account.
The sequential discovery must not keep track of addresses using a MutableAccount accounting style
The address underlying binary structure must remain unknown to the sequential discovery

Development Plan

PR

Number
Base

#942
master

QA

The module was already heavily tested (see https://github.com/input-output-hk/cardano-wallet/blob/93978c8497604ff60c5d8b3aa09fdf248dc53573/lib/core/test/unit/Cardano/Wallet/Primitive/AddressDiscovery/SequentialSpec.hs#L111-L199)

The type has been adjusted to work with fingerprint instead of addresses, although the outer API has been kept the same for now.

The tests still pass despite an heavy internal change

lgtm.


Unpacked structs

Add support for unpacked structs

To be rebased against master after merge of #4100.

To be rebased against master after merge of #3877.

Can anyone with access to Verific identify which line(s) in tests/svtypes/struct_sizebits_2.sv must be commented out for the tests to pass with Verific?