Possible violation of Microsoft Open Source Code of Conduct

VSCode Version: *
OS Version: *

Steps to Reproduce:

Read https://github.com/microsoft/vscode/issues/87268, etc.
See results of disagreements

Does this issue occur when all extensions are disabled?: Yes
Issue
Please review the Microsoft Open Source Code of Conduct. Specifically:

Understand disagreements: Disagreements, both social and technical, are useful learning opportunities. Seek to understand the other viewpoints and resolve differences constructively.

Based on what we saw happen with https://github.com/microsoft/vscode/issues/87268, I do not think there was an adequate effort put forth by the collaborators of this repository to "resolve differences constructively". Just because one person - whose intentions were not verified - makes demands based on a disagreement does not necessarily mean that collaborators should bend over backwards to accommodate them. This is a terrible and unsustainable precedent that will allow intolerance to triumph over tolerance.
To prevent this waste of time and energy in the future, I propose that we amend the COC to either:

improve clarity around what a best effort for understanding and resolving disagreements looks like - so as to promote a healthier, more tolerant environment where we do not assume the worst possible version of someone else's contribution
explicitly spell out a requirement that if even one person feels uncomfortable, no disagreement should be had at all and their demands should be satisfied if possible - so as to avoid any interactions that may lead to more discomfort

From #87440 "...meaning it represented the opposite of what we wanted to convey to our users. In the spirit of the season, and to practice inclusiveness, we reverted the gear to something (hopefully) less controversial (a snowflake)..."
I dunno, if I were the offended party that snowflake might represent what people think I am - https://en.wikipedia.org/wiki/Snowflake_(slang)
Seriously, this stinks.  Santa may have christian origins, but he considered to be more commercial than anything else in modern times.  Plenty of folks I know that have given up religion still celebrate Christmas, the holiday where 'Santa' brings gifts.
You can't make everyone happy all the time, and by backtracking on this you folks just made it worse.

Yes, totally agree - if VSCode should be a community effort to make best IDE out there - then ONE person's opinion can not affect whole community - that one decision made by single repo commiter caused flamewar throughout whole Internet and divided developers more than ever :(

Trolled hard
https://www.thurrott.com/users/DavidBenMesecke/

Also would like to add that down in Australia, we're sweltering through 42°C (108°F) in the middle of our Summer, and so the snowflake makes very little sense to us! You could even argue it ins't very inclusive of southern hemisphere residents.
This whole debacle is ridiculous, inclusivity in this case could have meant people accepting that the Santa hat wasn't spruiking a particular religion, it was a single of good will and cheer and a way for us to feel like part of a community with the developers. The handling of this is going to make us all pump out entirely neutral, robotic grey software with no fun or joy. Good job World!

To ensure the integrity of this repository, issues arising from opinions or beliefs that are completely unfounded and untraceable should not be accepted. If we do so, we fall into a spiral of being offended. If there is no limit to this, then this trend will most likely spread to other repositories.
Briefly a bit off topic because the original issue was closed: in Isreal, especially Tel Aviv, Jews, Muslims and Christians live next door. It is an open and compassionate culture where even the different holidays are celebrated together, even partly Christmas! And objectively speaking, the name "Christian" is a Christian name, which is why one must now even assume that he must feel offended by his own name (https://en.wikipedia.org/wiki/Christian_(given_name)).
Honorable mention: https://github.com/Christian-Schiffer/servicelayer.chat/issues/45#issuecomment-568090200
What does all this have to do with this now? This is an example of an issue which obviously contains an opinion which is not justifiable, comprehensible and applies to a handful of users. That this was quickly "waved through" is simply the wrong way to handle it and we need to make sure that this doesn't happen again in the same way.

@GiorgioG

but he considered to be more commercial than anything else in modern times

May I suggest the word secular (1b) over commercial?

For what it’s worth I reported the COC violation hours earlier, so we’ll and see what the response is or what happens (if anything).
It’s somewhat ironic that the person who was so offended by supposed Christian symbolism is named “Christian”; maybe he consider a name change above all.
Merry Christmas Github! 🎅

I do agree with what has been said above. It's outrageous that just because one person feels offended by something it had to be removed.
I think the developers should add back the christmas hat icon and in the future add or remove content based on user feedback from multiple people not just because one person got triggered.
If they don't respect this then this definitely destroys what it means to work in a community together even if it's a minor thing. Some other time it could be about major content not just an icon.

We were all under the impression vscode was community driven but alas, it is a clever ploy by microsoft to get us all to contribute and lock us out when they've gotten what they want. This is only the beginning, welcome to toxic corporate culture.
Look no further than the Microsoft code of conduct.

@therealparmesh
We wanted to try to address the original issue raised here about the Code of Conduct by providing more information on what happened last week. This turned out to address questions raised across other issues, so we put the response in https://github.com/microsoft/vscode/issues/87440#issue-540437717.
Please take a look there, we hope this answers your question. If it does, please close this issue.

Just add the Santa hat back! 🙂

The Code of Conduct is offensive against Santa, please fix it.

I am an irreligious Indian and don't particular care for holiday icons either way (specially santa, because cultural insgnificance) as long as it doesn't clutter my widow. My suggestion would be to make it configurable to hide holiday icons.

Closing this as I believe this issue is behind us we all certainly learned a lot from it.


Change tooltip language [SATURN-1221]

Updated the tooltip for opening notebooks from the IGV drawer to use the existing more concise text option to be more clear/simple.

Hmm, I see your point. When I made this change it was based on two things 1. It seemed to me the confusion about this tooltip was that it brings up Data Explorers when the user is trying to open a notebook, so I thought removing those words would make it more focused. 2. I read the article it suggests reading for help but I found it unhelpful because it focuses on how to open cohorts that can be opened with Notebooks, not on opening data in a notebook that doesn't fit that style which, is the sort of data this tooltip would be for. However I hadn't considered that it might be helpful just for providing more general understanding about the data and what a cohort is. I will consider alternatives. Thanks for the feedback!


Use Bluebird as promise library

This PR addresses a deviation of behavior between bookshelf-paranoia and bookshelf.
Bookshelf uses Bluebird for its backing promise library, which allows for a plethora of extra features (including filtered catch). I added a regression test demonstrates the change of behavior when using ES6 promises, and added Bluebird as a dependency to bookshelf-paranoia.

@bsiddiqui Let me know if you have any questions about this PR

@jadengore good call, thanks!


[Accessibility]A11y_VSCode_ViewDebug_ScreenReader: Screenreader reads incorrect name for "Watch" toolbar.

Environment Details:
VSCode Version : 1.24.0
OS Version : HighSierra10.13.5
Additional Details:
MAS Violated : MAS 1.3.1
ScreenReader : VoiceOver
Repro Steps:

Launch VS Code while VoiceOver is ON.
Navigate to Activity Bar and select "View Debug" button.
Navigate to toolbars section under heading "Debug".

Actual:
Screenreader reads the incorrect name for "Watch" toolbar as "Expressions" toolbar.
Expected:
Screenreader should read proper name for "Watch" toolbar not as "Expressions" toolbar.
Recommendations:
Provide proper name to the toolbar
or,
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx
User Impact:
The screenreader users will not be able to know the correct names for all the toolbars present on the screen.
MAS Reference:
MAS 1.3.1 - https://microsoft.sharepoint.com/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}
Attachment For Reference:
A11y_VSCode_ViewDebug_VoiceOver_WatchToolbar.pptx
Does this issue occur when all extensions are disabled?: Yes

Dup of https://github.com/Microsoft/vscode/issues/52307


Instances of page or selected symbols

Hi,
I really love your plugin and it saves me a lot of time.
I just have a suggestion :
It would be great If I could make an Instance Sheet from just a page containing of symbols and not a whole library and if I could choose multiple symbol artboards that I want to make their instances it would be much much better.
thanks alot 👍🙏

@sirpooya Thank you for the feedback and for using my plugin. I think you be pleased with the latest version. Please check it out.


add get_test_params

I'm sorry.
I did some mistake with the new and old branch.
The easiest way was to create a new branch and open a PR.
I will close the other ones.

No need to be sorry.
This is git: https://xkcd.com/1597/

Made a few changes to ensure skbase compatibility.
FYI, the API convention is that all classes must behave like dataclasses:

init params are written to self in the constructor
over the lifetime of the object, they are never mutated, only read

Made a few changes to ensure skbase compatibility.
FYI, the API convention is that all classes must behave like dataclasses:

init params are written to self in the constructor
over the lifetime of the object, they are never mutated, only read

Ok.
Now the testing are failing because of this error:
ERROR skpro/tests/test_all_estimators.py::TestAllObjects::test_repr[Product] - AttributeError: 'Interval' object has no attribute 'parenthesis'

You add the attribute _parenthesis. Therefore, i changed in the get_test_param the key parenthesis to _parenthesis.
I hope i correct :-)

Ah, that was my mistake! The parenthesis arg should be always what was passed to __init__, so the "resolve" needs to write to another arg. The get_test_params reference still should be "parenthesis"  - I fixed it and it should work now.

Still an error but i think i know what is. I will give a look

I see, this raises an interesting question.
Do we want to enforce the dataclass like API from BaseObject on the init args that get simplified?

Good question.
I don't have a strong opionion.
What are the pros to use it?

What are the pros to use it?

Immutability of the blueprint - you can identify the object you are dealing with by the class and params uniquely. The usual case this guards against is change of the object blueprint over its lifetime - but not "simplification" operations, as in this case.

If we want to have it, i can change the class such that it thrown an error if you are creating a finite sets with repetition. Let me know what you orefer ;)
I can change it tomorrow and start to work with distribuitions ;)

Hm, I'd be fine with either solution here. Perhaps raising an error if not unique makes most sense.

Can we merge such that I can start with domains and distributions ? :-)


CCPACSWingCell::GetLoft() very slow

The CCPACSWingCell::GetLoft() method ist very slow. One execution takes about 2 seconds (attached example rotor blade). We use the wing cells to define the material distribution for the rotor blades. At least 300 - 500 cells are required to approximate material distribution, which leads to computing times that are too long. Is there a way to speed up the cell loft computation?
Best regards,
Daniel
IEA-15-240-RWT_CPACS_d.zip

Idea from a phone call with @rainman110:
We only need the boundary wires of the cells. This could be done fast by using isocurves of the wing shell (about 100 times faster than the "normal" intersection). We recommend to implement a CCPACSWingCell::GetBoundaryWire() method that gives the boundary wire of a cell. If the cell boundary is defined in a way that it is an isocurve, this method returns this curve. Otherwise a "normal" intersection algorithm must be used. To get the isocurves, the front and rear boundary of the cells have to defined by contour coordinates instead of xsi coordinates. We will make a pull request to CPACS for this way of the cell boundary definition.


Rename parser.Parser() -> parse.Parse() and some styles refactoring

Hi, I rename signature call parser.Parser() -> parser.Parse().
Change (if -> switch), think is "go-way" and other...

Thanks to @dmitryrpm


add listFavorites

@PLhery As promised in #296, I create this pull request to add favorites/list. Please let me know if something is missing.

Hello,
Many thanks for your pull request! 🥰
I've customized it on my side using your code, to include it as a paginator (like other endpoints returning iterable lists), so I will close this PR.


Regent Parallelizer merge

We need to merge the parallelizer into master, but the first step is to merge it into the control replication branch.

@magnatelee What preconditions remain for merging this into the CR branch?

@streichler as I said in the last meeting, the parallelizer branch needs some hardening work to make it ready for the merge.


query_cache ignores DoctrineExtensions\Translatable query hint for fallback

When using
$query->setHint(     \Doctrine\ORM\Query::HINT_CUSTOM_OUTPUT_WALKER,     'Gedmo\\Translatable\\Query\\TreeWalker\\TranslationWalker' );
in combination with
$query->setHint(     \Gedmo\Translatable\TranslatableListener::HINT_TRANSLATABLE_LOCALE,     'en' // take locale from session or request etc. );
The query ignores the query hint and doesn't return the fallback language but the empty records.

@martijnhartlief Have you added the hint for fallback after your two hints?
// fallback
$query->setHint(
    \Gedmo\Translatable\TranslatableListener::HINT_FALLBACK,
    1 // will fallback to default locale translations instead of empty values if used. 0 for empty values.
);

This is not an issue with this bundle but with Doctrine ORM.


Minimum Requirements

Hi guys..
I've tried cage on Opensuse Tumblweed, with KDE already installed. This works as expected from a TTY console - running cage /usr/bin/epiphany works as expected.
From a minimal install however (specifically, "openSUSE Tumbleweed JeOS"), running cage /usr/bin/epiphany fails with the following error:
[cage.c :182] Unable to create the wlroots backendeviceerer"
It seems that there is a dependency missing in your code, and the rpm system therefore cant pull it in when it needs to. Any ideas as to what this might be? (I'm not good with C code)
There is a thread at https://forums.opensuse.org/showthread.php/535802-What-is-the-minimum-package-list-for-Wayland?p=2901328#post2901328
(Btw you can create your package at openSUSE's OBS and it will get built for most distros...)
Thanks in advance - Patrick

Hi Patrik,

It seems that there is a dependency missing in your code, and the rpm system therefore cant pull it in when it needs to.

To be explicit so we're all on the same page: there is no dependency missing from Cage's source files. If this were the case, it wouldn't compile and the package wouldn't exist. Looking at the dependencies of the Tumbleweed package, everything is there.
What is most likely the reason, is that OpenSUSE splits out the package xkeyboard-config from libxkbcommon. wlroots only lists the latter as dependency, but the former is required as well. On most distributions, this doesn't matter, since they are often packaged together. Try installing xkeyboard-config and see if that works. I ran into this issue myself a while back when compiling my own minimal distribution, see https://github.com/swaywm/wlroots/issues/1446.

To take away some possible confusion caused by some reactions to your forum thread...

Looking at the build info, cage isn't built with wayland support....

Cage is a Wayland compositor. It cannot be built without wayland support. In the chance that this user meant to say xwayland, xwayland is entirely optional and only required for applications that aren't (yet) ported to Wayland. Epiphany (and all other GNOME applications) are Wayland-native and do not require xwayland.

Hi Jente,
Thanks for your prompt response. xkeyboard-config was already installed, but libxkbcommon wasn't.
(so xkeyboard-config was probably pulled in when Cage was installed, as there is nothing else X or Wayland related on that machine apart from Cage, Epiphany and their dependencies).
So I tried installing libxkbcommon as well, which resulted in the same error.
Are there any environment variables must be in place?
(There is clearly something missing between the JeOS version and the full KDE version... its just a matter of working out what that might be... ;) )
Understood re the confusion - I said the same.
Thanks - Patrick

Thanks for your prompt response. xkeyboard-config was already installed, but libxkbcommon wasn't.
...
So I tried installing libxkbcommon as well, which resulted in the same error.

Hmm... strange. Just to completely rule this out, check the package contents here and check if you have the same: https://www.archlinux.org/packages/extra/any/xkeyboard-config/
The name implies X, but actually these (and libxkbcommon) are also used by Wayland compositors.

Are there any environment variables must be in place?

No, you should be able to run Cage without environment variables.

Does your JeOS include systemd and, if so, does it launch a proper user session once you log in? Note that wlroots must be built with logind support for this to work. Furthermore, does JeOS come with virtual consoles (/dev/tty?)? wlroots needs these.

The package contents of xkeyboard-config lack only the /usr/share/locale subtree, but that is supplied by another package.
The JeOS build includes user sessions, systemd and virtual consoles.
Malcolm over at the opensuse discussion has said he's got it working by adding the 'Mesa' package (3d graphics rendering?)... I'm rebuilding the image now and well get back to you.

I can confirm that on Opensuse Tumbleweed adding the Mesa (3d) package enables Cage to function (at least for Epiphany) So the missing requirement is some kind graphics library, which kind of makes sense...

Great! It seems then that this should be added as a dependency to the wlroots package. Tagging @jbubalh

And just out of curiosity, what are you building? Using JeOS it seems you're building something very specific :)

We use for a couple of different things - mainly images for download as part of a mass-deployment system - check out Required Magic - we have one image that it would be nice to have a simple interface that displays the current system configuration state for the initial installation.  I came across Cage and thought it looked ideal for just that - display the required info via the web browser.
It's weird though that Tumbleweed requires Mesa (a 3d library) as it pulls in about 30mb of other code. What graphics libs do you know would work?
Nice work btw!

(Of course the basic epiphany needs fonts, certs and javascript it seems, but its great to get this far!)
/p

We use for a couple of different things - mainly images for download as part of a mass-deployment system - check out Required Magic - we have one image that it would be nice to have a simple interface that displays the current system configuration state for the initial installation. I came across Cage and thought it looked ideal for just that - display the required info via the web browser.

Very cool :)

It's weird though that Tumbleweed requires Mesa (a 3d library) as it pulls in about 30mb of other code. What graphics libs do you know would work?

It's not so weird actually, once you read up on what [mesa is and provides](https://en.wikipedia.org/wiki/Mesa_(computer_graphics). In fact, I am surprised that the wlroots package is built without mesa as a dependency.

(Of course the basic epiphany needs fonts, certs and javascript it seems, but its great to get this far!)
/p

There are other webkit browers out there that might be more minimal than Epiphany. Have a look at admbrowser!

Agreed re Mesa, but its all a bit much if all it needs to do is display XVGA graphics on a virtual machine... (which is the use case).
Admbrowser looks pretty good. so good it might be worth using Mesa... ;)
Thanks for a great project. /p

That's the downside of using packages built for a generic (desktop) OS, I suppose. It includes everything. Do note that the stuff you don't use only takes up space, it doesn't cost you anything else.
If it really is a problem, you can either try to build your own Mesa package that includes only what you need, or you can look into an alternative way to build your image (such as buildroot).
I'm going to close this now as this is issue is resolved. Feel free to reopen if needed :)


[MSAL Angular] Error thrown while acquiring the token

Library

[ ]<EMAIL_ADDRESS>[ ]<EMAIL_ADDRESS>
Framework

[ ] Angular 9
[ ] @angular/cli:^9.1.14
[ ] @angular/common:^9.1.13
[ ] @angular/compiler:^9.1.13
[ ] @angular/compiler-cli:^9.1.13

Description
We have updated our SPA app ng version from ng8 to ng9. We were using below libraries mentioned above in ng8.
After upgrading the ng version, no other code changes we are consistently getting below errors.
Do we need to update the MSAL and MSAL Angular packages?
Error Message

DOMException: Failed to set the 'domain' property on 'Document': Assignment is forbidden for sandboxed iframes.
Error: Uncaught (in promise): Error: Cannot match any routes. URL Segment: 'state'

MSAL Configuration
const auth = {
	auth: {
		clientId:
		authority:
		validateAuthority:
		redirectUri:
		postLogoutRedirectUri:
		navigateToLoginRequestUrl:
	},
	cache {
		cacheLocation: 'sessionStorage'
	},
	system: {
		logger:
		loadFrameTimeout: 20000,
		windowHashTimeout: 20000,
		iframeHashTimeout: 20000
	}
}

return (auth as Configuration)

Browsers/Environment

[ ] Chrome
[ ] Firefox
[ ] Edge

@Madhufuture did you consider moving to msal 2.x which will give you access to the latest angular package from our end? A good starting point for migration docs can be found here.
@jo-arroyo can help with the migration if you need more info.

@sameerag no we don't have any plans to migrate to MSAL 2.x. We will be sticking with msal 1.x until July.

@jasonnutter , Could you please suggest us any other solution apart from moving to MSAL 2.x?

DOMException: Failed to set the 'domain' property on 'Document': Assignment is forbidden for sandboxed iframes.

This is likely due to your app being throttled for making too many requests in a short period of time. Please provide correlation IDs (and timestamps) so we can look up server logs to confirm.

Error: Uncaught (in promise): Error: Cannot match any routes. URL Segment: 'state'

Are you using hash routing? If so, you should add routes for keywords that appear in MSAL responses (e.g. state, access_token, error, etc).

Closing due to inactivity. Please let us know if this is still an issue.


Bump dependency, make cargo check/clippy happy

RIP Travis CI. Tests pass locally on Linux, some atime/mtime mismatch failures on OS X.


Add install description

Few lines added to the README to describe the install procedure, added an environment.yaml file to install the package with conda. I have also updated the tutorial notebook and fixed some minor bugs from typos or updates of variable names.

@fnattino
I found the merged development branch did not contain client setup when you merged. I will merge the new changes here and do the test.

@fnattino sorry plz ingore this comment. I mixed up two branches add_install_description and webdavclient. Testing now.


Cannot disable OptionalWhenBraces with warningsAsErrors: true

Expected Behavior
Should be able to disable deprecated rules, or maybe be disabled by default?
Observed Behavior
Either have many OptionalWhenBraces violations or
Execution failed for task ':...:detekt'.
> Run failed with 1 invalid config property.
        - Property 'style>OptionalWhenBraces' is deprecated. Same functionality is implemented in BracesOnWhenStatements.

Steps to Reproduce
detekt {
    allRules = true
}

config:
  warningsAsErrors: true
style:
  OptionalWhenBraces:
    active: false

Context
I shouldn't have to choose between having a strict build, or having a short configuration file (allRules + overrides), or having a customized detekt config (active: false). I'm fully sure what's going on here, and why this never happened before, but it's a strange situation and I wonder what you guys think about it.
Can you think of a workaround for this apart from disabling warningsAsErrors, or listing all the rules explicitly rather than excluding the ones I don't want?
Your Environment

Version of detekt used: 1.23.1
Version of Gradle used (if applicable): 8.3 rc 2
Gradle scan link (add --scan option when running the gradle task): N/A
Operating System and version: Windows 10
Link to your project (if it's a public repository): N/A

Up! With the new version 1.23.1 I start getting OptionalWhenBraces errors and when I want to disable the rule I get the exact same Property 'style>OptionalWhenBraces' is deprecated error.

Is this a regression of 1.23.1?

Yep, https://github.com/TWiStErRob/net.twisterrob.gradle/pull/569

Yup so this was introduced by: fa788ebb962e799774d53da2af33dda3dd6a2f91
The workaround is to don't use OptionalWhenBraces at all

Yeah, the only way to do that is to list all other rules, or use the default config, which means allRules + warningsAsErrors is an unsupported feature as of 1.23.1.

which means allRules + warningsAsErrors is an unsupported feature as of 1.23.1.

Ah I see what happened. I don't know how do we want to handle this as practically we're deprecating a rule for the sake of 2.0.
So you will have a warning if you use that rule (also with allRules). At the same time warningsAsErrors will let your build fail because of that deprecated rule.
Perhaps allRules should skip deprecated rules?

Perhaps allRules should skip deprecated rules?

I think that's a good one!
It assumes that "replacement" will be available, but I think that's a fair assumption.

@cortinico I think this should be fixed on 1.x, because right now it's not possible to upgrade from 1.23.0 to 1.23.1 (and future), unless:

we disable allRules
we disable warningsAsErrors

neither of which sound good as a workaround.
I had a quick look at "skipping deprecated rules", but the information is readily available in AllRulesConfig and I'm not 100% sure how to get it there. Maybe creating a Config.DEPRECATED_KEY and propagating the properties file into the config, or is that too hacky?
Little off topic: should we have a "next 1.x patch" milestone?


SendSmsMessageAsync parsing exception

Hi,
I've copied the code from the simple example that sends messages from a sandbox env, but I changed SendSmsMessage to SendSmsMessageAsync and now I get Unexpected character encountered while parsing value: <.
Infobip.Api.Client.ApiException: Unexpected character encountered while parsing value: <. Path '', line 0, position 0.
   at Infobip.Api.Client.CustomJsonCodec.DeserializeAsync(HttpResponseMessage response, Type type)
   at Infobip.Api.Client.CustomJsonCodec.DeserializeAsync[T](HttpResponseMessage response)
   at Infobip.Api.Client.ApiClient.ExecAsync[T](HttpRequestMessage req, IReadableConfiguration configuration, CancellationToken cancellationToken)
   at Infobip.Api.Client.Api.SendSmsApi.SendSmsMessageWithHttpInfoAsync(SmsAdvancedTextualRequest smsAdvancedTextualRequest, CancellationToken cancellationToken)
   at Infobip.Api.Client.Api.SendSmsApi.SendSmsMessageAsync(SmsAdvancedTextualRequest smsAdvancedTextualRequest, CancellationToken cancellationToken)

Hi Michele,
Can you provide the code snippet so we can try to reproduce the issue?

I'm sorry, my mistake, I passed the default configuration, you can close the issue, the only thing I can complain about is the lack of clarity of the error, a better hint would have been like "Missing API key" or "Missing BasePath".
Thanks for your patience.

Yes, we could handle these exceptions in a better way, good point.
However, I'm not sure how exactly you got the one above. I wasn't able to replicate it, even when not providing the API key or base path.


Google Social Login missing error info

Hi, we have setup google social login. When we launch google's social login, the native google login screen is launched, but after selecting a google account and coming back to our application, we receive a 400 error with no errorReason, so we cannot find out what's failing.
We have followed all the instructions in Gigya's core SDK to enable Google sign-in.
Code fragment:
try {
              var result =
                  await GigyaSdk.instance.socialLogin(SocialProvider.google);
              print('---------------  Social Login Google OK');
              print('---------------  $result');
            } on GigyaResponse catch (e) {
              print('---------------  Social Login Google ERROR');
              print('STATUS ${e.statusCode}: ${e.statusReason}');
              print(
                  'ERROR ${e.errorCode}: ${e.errorDetails} callId: ${e.callId}');
              print('INTERRUPTION ${e.getInterruption()}');
              print('------------------------------------------');

Output
I/flutter ( 2970): ---------------  Social Login Google ERROR
I/flutter ( 2970): STATUS 0: null
I/flutter ( 2970): ERROR 400: null callId:
I/flutter ( 2970): INTERRUPTION null
I/flutter ( 2970): ------------------------------------------

Versions:
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel stable, 2.2.0, on Microsoft Windows [VersiÃ³n 10.0.19042.985], locale es-ES)
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[√] Chrome - develop for the web
[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.8.5)
[!] Android Studio (not installed)
[√] VS Code (version 1.56.2)
[√] Connected device (4 available)

  gigya_flutter_plugin:
    dependency: "direct main"
    description:
      name: gigya_flutter_plugin
      url: "https://pub.dartlang.org"
    source: hosted
    version: "0.0.6"

Can you please specify the steps you took to implement Google sign-in in your application?
Regards,
Tal

We followed these steps: https://sap.github.io/gigya-android-sdk/sdk-core/#google
Then in Google console we created a new project. In the Credentials section, we added a new OAuth credential for Android. And we put that client_id in the meta tag inside the AndroidManifest.xml
Then in Gigya, in the Providers Configuration section, enabled Google and put there the client_id.
Because there is this paragraph: "Note that the required client_id is the Web client id generated when you create your Google project. This should not be mistaken with the Android OAuth client id. Make sure that your Google project contains both."
We tried to create a OAuth Web credential, and use that instead of the Android one, but we get the same error 400.

Thank you for the info:
Here are a few pointers:
On your API console please make sure you update the following redirect URI (according to your data center).
https://user-images.githubusercontent.com/47209216/121140602-b3827480-c842-11eb-82a1-3fc57b4f0fa4.png
In addition, the sample application is already configured to use the Google sign in,
All you need to do is add the following package to your pubspec.yaml
google_sign_in: ^5.0.4

Still not getting it to work. So we must create and use a OAuth Web Credential instead an Android credential?

Finally got it working. Our main trouble was not clearly understanding that Note and, not thinking that hot restart of flutter app doesn't reload Android strings.xml or any other files.


Add theme customizations

css is a friend of mine

Schedule color and text customizations have been mostly implemented. congrats.


vector field redo

Reimplement vector field opacity using masks
denser
Already a lot faster
more improvements

I think I'm ultimately going to fall back to canvas for vectorfield. For now it can stay as-is.


Block fetch inflight bug

I tried to construct a test case which catches the bug (#973), but it requires a bit more work. I think that the current block fetch test never merges requested chains.

I hopefully this time hydra will not abort.

bors r+


Failed binding IPv4 listening socket: Address already in use (48) Engine creation error: Error Domain=com.apple.CoreHaptics Code=-4809

Failed binding IPv4 listening socket: Address already in use (48) Engine creation error: Error Domain=com.apple.CoreHaptics Code=-4809

[✓] Flutter (Channel stable, 2.10.1, on Mac OS X 10.15.7 19H1615 darwin-x64, locale en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
[!] Xcode - develop for iOS and macOS (Xcode 12.4)
! Flutter recommends a minimum Xcode version of 13.
Download the latest version or update via the Mac App Store.
[✓] Chrome - develop for the web
[✓] Android Studio (version 2020.3)
[✓] VS Code (version 1.64.2)
[✓] Connected device (2 available)
[✓] HTTP Host Availability
! Doctor found issues in 1 category.

@sadaqatkarimi
When you open an issue, please use the new issue template and fill out requested details, so that we'll have enough details to work with. Currently you just posted flutter doctor and error but that's not enough to analyze further.
When do you get this error ? provide entire verbose log in text format, flutter doctor -v, platform on which you are seeing this error along with exact steps to replicate this issue and a minimal code sample.

after upgrading flutter sdk from 1.22.6 to 2.10.1 , then get this error on ios 15.2.1

flutter doctor -v
[✓] Flutter (Channel stable, 2.10.1, on Mac OS X 10.15.7 19H1615 darwin-x64, locale en-GB)
• Flutter version 2.10.1 at /Users/everythingapple/developer/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision db747aa133 (7 days ago), 2022-02-09 13:57:35 -0600
• Engine revision ab46186b24
• Dart version 2.16.1
• DevTools version 2.9.2
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
• Android SDK at /Users/everythingapple/Library/Android/sdk
• Platform android-31, build-tools 30.0.3
• Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
• All Android licenses accepted.
[!] Xcode - develop for iOS and macOS (Xcode 12.4)
• Xcode at /Applications/Xcode.app/Contents/Developer
! Flutter recommends a minimum Xcode version of 13.
Download the latest version or update via the Mac App Store.
• CocoaPods version 1.11.2
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2020.3)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7281165)
[✓] VS Code (version 1.64.2)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.34.0
[✓] Connected device (2 available)
• Sadaqat’s iPhone (mobile) • 890d48778e60263387e00cf13277c165448f3e6e • ios            • iOS 15.2.1 19C63
• Chrome (web)              • chrome                                   • web-javascript • Google Chrome 98.0.4758.102
[✓] HTTP Host Availability
• All required HTTP hosts are available
! Doctor found issues in 1 category.


groups: activity indicators in mobile navbar

Reformats the navbar slightly to accommodate tap targets with the intended margins, which fixes LAND-894
Adds useIsAnyGroupUnread, a superset of what is returned by useIsGroupUnread
Uses a variety of methods (useIsAnyGroupUnread, useChannelUnreadCounts, useNotifications) to show or hide a blue dot under the Groups, Messages, and Activity navigation items
Converts the Activity navigation item to a DoubleClickableNavTab, since we will want to support linking to the notification context relative to the activity stream (both events are the same now, which might be premature)

Fixes LAND-945

@arthyn PTAL, we now have:

a 48px navbar
32px icon containers with 24px centered icons
6px bullets stacked immediately underneath the icon containers
2px padding between the bullet and the bottom of the navbar


Album art is not displaying for all but first album

A bug report came in from TestFlight mentioning that album art is not displaying on any album, except for the first one in queue? At least, investigate whether album art is correctly being displayed with the current version.

This may have been from me. I can see artwork in the Music tab, but not in Now Playing.
Happy to do more testing or provide more info as required.

I think I have received multiple reports for this one 😅. I'll try to investigate what's happening there.


feat(poc): table responsive

🔗 Linked issue

Twitter/X discussion https://x.com/milos_toox/status/1844388008780496997
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality)
[x] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

@milos018 I might have mislead you on Twitter, there is no plan to add another Table component to the current version.

@milos018 I might have mislead you on Twitter, there is no plan to add another Table component to the current version.

All fine, just a thought :)


added surface self-intersection test as well as second derivatives of surface aspect ratio

This PR introduces a surface self-intersection test, and second derivatives of the surface aspect ratio with respect to the surface degrees of freedom.
The algorithm that checks for surface self-intersection first computes a surface cross section at a given cylindrical angle phi.  Then, approximating the cross section as a piecewise linear polyline, the Bentley-Ottmann algorithm is used to check if any line segments overlap one another.
The second derivatives of surface aspect ratio are useful if being used as a surface label in the BoozerLS algorithm.

I think test_is_self_intersecting is not being run in the CI, since ground and bentley_ottman are not installed there. Does it make sense to add these packages to simsopt's requirements? Or do you think these packages and their sub-dependencies are onerous to include for some users? If we don't include these packages in simsopt's general requirements, then I'd suggest manually installing them in the CI and extensive CI as in this line so test_is_self_intersecting is run.


Stack and Heap diagram

Hello, does anyone know if interpretation of stack and heap diagrams will be tested during finals?

I think the stack and heap is more of to help u understand how to write efficient and optimized code, don't think it will be tested explicitly

doubt it... i think prof js uses that for explanations. it is technically possible to solve the questions without using stack and heap

I don't think so, because prof went thru it very quickly, and it wasn't in our recitations too

yea I don't think it will be tested, but just an understanding of it should be enough

I saw that stack and heap diagrams appeared in some pyps. I think Prof has modified the syllabus.

I feel that the more you use Java, the more you get used to its behaviour (and implicitly know what is stack and heap behaviour)


add college structure to maps

Facing difficulty with writing the conditional statements for chained filtering. Hari is helping with this, Jerrod and I will be giving this a try in the next sprint.

@EdemD This ticket passed QA.  Cascading filter functionality will be processed on separate ticket.
https://docs.google.com/spreadsheets/d/1Ewtwl2e3tI6gH4JyXTKAhPibsQ2MBPpWw2SJxmL-8No/edit?usp=sharing

Thanks @caadler


Remove unreachable "result" outcome from overseas-passports (part 2)

There are only two questions from which it's theoretically possible to reach
the :result outcome:

:child_or_adult_passport?
:country_of_birth?

In both these questions there are a bunch of next_node_if statements and a
next_node statement inside an on_condition block, all followed by a final
next_node statement which points at the :result outcome.
In both cases the final next_node statement within the on_condition block
points at the :ips_application_result outcome i.e. not the :result outcome.
Thus the :result outcome is only reachable if the
SmartAnswer::Calculators::PassportAndEmbassyDataQuery#ips_application?
predicate returns false.
However since st-helena-ascension-and-tristan-da-cunha was switched to type: ips_application_3 in this commit the predicate only returns false when the
response to the :which_country_are_you_in? question is one of the following:

syria

However, in this case the PassportAndEmbassyDataQuery#ineligible_country?
predicate returns true for a response of "syria" and the user is taken
immediately to the :cannot_apply outcome.

the-occupied-palestinian-territories

However, in this case the user is subsequently asked to choose either
gaza or jerusalem-or-westbank and either of these responses cause the
PassportAndEmbassyDataQuery#ips_application? to return true.

united-kingdom

However, in this case this response is not included in the
:which_country_are_you_in? question's country select list (it is not
included in such questions by default; only if the :include_uk option is
set to true). So it wouldn't be possible for a user to give this response
in production without hacking the URL.

Thus I'm pretty convinced the :result outcome is unreachable given the
current logic and data. Obviously if the data changed, it might be possible
for the outcome to become reachable again, but I don't think the overhead of
keeping all this code hanging around is justified.
I've elected to remove the two next_node(:result) statements which (although
perhaps slightly controversial) should mean we will see a RuntimeError
exception with the message "Next node undefined" if none of the other
conditions are satisfied by a response from the user.
I've also tried to remove as much code, content & data which the removal of
the outcome has rendered redundant.

I'm a bit less sure about removing this code than I was. I've come across some else statements in precalculate blocks in the rest of the overseas-passports flow which are similarly unreachable given the current dataset.
I think there's a difference between removing code that is fundamentally unreachable versus code that is currently unreachable because of the current dataset.
Having said that, it also feels wrong to maintain a bunch of code "just in case" the data changes at some time in the future.
@tadast, @BenJanecke: Do you have any thoughts on this?

I've had the very same issue in the marriage abroad flow. After looking at the data I just made an educated guess that it's not likely to change in a way that leaving the code would be beneficial.
Unless the dataset has changed often historically, or the responsible content designer (Abigail in this case) thinks it will change soon, I'd remove it. Most of the times we get requests that are quite concrete i.e. given inputs X the result should be . So the worst that can happen is a developer re-implementing the missing code without knowing it can be recovered from git.

I think we should take this on a case per case basis, but unless you can replicate the flow that actually executes that code I would suggest removing it.

Thanks, folks. I've started leaning back towards removing it, because having an unreachable outcome breaks one of the fundamental assertions in the regression tests.
Also I've now run the tests with all combinations of countries & other responses and I have confirmed that I cannot reach the outcome.


Feature/telemetry dotnet

Description and Motivation
...
Change type

[ ] Bug fix
[ ] New feature
[ ] Enhancement
[ ] Breaking change (breaks backward compatibility)

Checklist:

[ ] All tests passed
[ ] The code follows the code style and conventions of this project
[ ] The change requires a change to the documentation
[ ] I have updated the documentation accordingly

@kirpasingh I noticed that the PR included some credentials, please make sure those are invalidated because they will be found by spiders and security scanners


Display cost of running assays

It would be nice to know how much in game budget will be spent when you click run assays on the assay page.
It could work by dynamically changing the run assay button, but other solutions such as a new visual element that looks like an invoice could be good

Isn't it already in the game?

WIP https://github.com/SABS-Group-2-2021-22/drug-discovery-game-app/tree/156-display-cost-assay

Completed and merged: https://github.com/SABS-Group-2-2021-22/drug-discovery-game-app/commit/6f35ad4aaba1ae8c7afb037343614b91f5ddfb7e


Adopt the new server status interface from Flow emulator

Problem
It is a commonly encountered issue that there are intermittent failures for tests backed by flow-js-testing library, per described in https://github.com/onflow/flow-js-testing/issues/47.
It turns out the root cause is that there is not a reliable way for processes to check whether the emulator is fully started, hence tests could be run before HTTP/gRPC servers are ready, causing failures.
Steps to Reproduce
run the Jest tests in KittyItems repo.
(note: this has been temporarily addressed per comment https://github.com/onflow/flow-js-testing/issues/47#issuecomment-1006917613)
Some past evidence:
https://github.com/onflow/kitty-items/runs/4722525285?check_suite_focus=true
https://github.com/onflow/kitty-items/runs/4721609090?check_suite_focus=true
https://github.com/onflow/kitty-items/runs/4720430127?check_suite_focus=true
https://github.com/onflow/kitty-items/runs/4720205583?check_suite_focus=true
Acceptance Criteria

Rather than relying on this logging line, use the new interface to be introduced in https://github.com/onflow/flow-emulator/issues/111, so that the emualtor.start() function can return a correct Promise which accurately reflects the server status
notify community members when the fix is out ( related Discord comment )

Fixed in #73


feat: add C implementation for stats/base/dists/normal/variance

Resolves #3784
Description

What is the purpose of this pull request?

This pull request:

adds C implementation for stats/base/dists/normal/variance along with relevant tests, docs, examples and benchmarks.

Related Issues

Does this pull request have any related issues?

This pull request:

resolves #3784

Questions

Any questions for reviewers of this pull request?

No.
Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.
Checklist

Please ensure the following tasks are completed before submitting this pull request.

[x] Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

/stdlib update-copyright-years


Playback Module not serializing hands' Basis

Received this from a developer via email.

Specifically, I’m working with the Playback Module to record and play back serialized Frames. It’s working quite well, except the ‘Basis’ field of a frame is not being serialized, probably due to LeapTransform not being marked as Serializable. Since hands use that Basis to calculate the palm orientation, the palm is the only part, that’s not being played back correctly from a recorded frame. Would it be possible to make the LeapTransform Serializable as well?

@Amarcolina Haven't we successfully serialized hand bases before?
If you have more details Julien, please feel free to add them to the thread.

Does Julien have access to this ticket here?  I looked at the source and Basis is not actually a field at all, it is a property that calculates the transform on-the-fly whenever you ask for it, using the palm position and rotation to do so.  Since the palm position and rotation are both serialized properly I would expect the basis to behave as normal.  What kind of behavior are you seeing Julien?

Whoops accidentally closed, re-opened :)

OK, yeah I suspected something funky was going on like that. I've linked Julien to this thread so we'll hear more soon most likely.

Ah yes, @Amarcolina you're completely right. I thought it was giving me a default value due to not being serialized.
However, I just realized that the problem actually is the Rotation that the Basis is calculated with. The Hand.Rotation is falsely serialized as the identity LeapQuaternion (0f, 0f, 0f, 1f), no matter what the actual orientation of the hand is during recording. I'll have too look into why that happens.

Hmm, so the PlaybackRecorder uses CopyFromOtherExtensions.CopyFrom(this Frame frame, Frame source). But it seems, when calling that on a newly created frame, the Orientation is somehow not copied over? Can you confirm that that's not just happening on my side?

I'll take a look, that does seem strange.  Are you using the most recent version of Unity Modules or an older version?

Core Assets 4.2.1 and IE 1.0.1 yes.
Playback Module from develop branch.

Oh dear, I see the issue hah.  Check out PlaybackProvider.cs lines 95-97.  Remove those and you should be good ;)
foreach(var hand in f.Hands) {
    hand.Rotation = LeapQuaternion.Identity;
}

I created a PR to fix this as well
https://github.com/leapmotion/UnityModules/pull/779

Wow, that's pretty obvious... Can't believe I didn't figure this out myself. *facepalm
Well, I don't have a Leap Motion with me right now, so it was kinda difficult to debug. Will check tomorrow, but thanks for the fix :)

#779 just got merged  -- to test this fix Julien, I'd recommend just looking at the code change Alex made in that PR (since it's very minuscule) and seeing if that fixes your problem (rather than replacing your entire public Core release with our develop Core code)
Looks like we were zeroing out hand rotations for a legacy reason.

Works like a charm. 👍 This can be closed.
I have another question/suggestion regarding Playback for which I'd create a separate issue if I may?

Go for it!


Introduce V1 API

This is the same essential PR as GoogleCloudPlatform/prometheus-engine#181 except the commits are broken down for easier review.

a06da64 - preparing v1 resources for autogeneration
a5ba159 - autogenerate go k8s  v1 client code and manifests
9cb3bf3 - find/replace go code calls from v1alpha1 to v1
9b57ea9 - remove go k8s v1alpha1 client code

1 is probably the most interesting, followed by 3. The others are autogenerated or rote.
I tested this on a fresh cluster as well as upgrading an existing managed-collection setup.
Overall I removed the v1alpha1 go k8s client code, but kept the types and kubebuilder tags. This ensures our CRD contains both api versions and the code is backwards-compatible with v1alpha1 CRs.

What are the semantics for existing clusters and resources?
Are existing v1alpha1 resources processed by the operator as if they were v1 resources? Do they remain stored as v1alpha1 or upgraded to v1 automatically?
I recall there are conversion webhooks but am not sure whether they'd be necessary here as the versions are identical. What semantics would we have to commit to going forward, i.e. do we only ever add features/fields to v1?

I found this link particularly helpful in answering your questions.

Are existing v1alpha1 resources processed by the operator as if they were v1 resources?

Yes. Note that this uses v1 as the storage version (example). From the docs:
When you read an object, you specify the version as part of the path.
If you specify a version that is different from the object's persisted version,
Kubernetes returns the object to you at the version you requested,
but the persisted object is neither changed on disk,
nor converted in any way (other than changing the apiVersion string) while serving the request.
You can request an object at any version that is currently served.

I validated this by kubectl edit-ing an existing v1alpha1 PodMonitoring against an operator listening for v1 CRs. I was able to trigger the validating webhook (I gave it some bad target labels and the webhook correctly rejected it).

Do they remain stored as v1alpha1 or upgraded to v1 automatically?

They remain stored as v1alpha1 unless updated. From the docs:
When an object is written, it is persisted at the version designated as the storage version at the time of the write.
If the storage version changes, existing objects are never converted automatically.
However, newly-created or updated objects are written at the new storage version.
It is possible for an object to have been written at a version that is no longer served.

I recall there are conversion webhooks but am not sure whether they'd be necessary here as the versions are identical.

Correct. The default None conversion strategy works for us here - no webhooks necessary.

What semantics would we have to commit to going forward, i.e. do we only ever add features/fields to v1?

I think committing to v1 going forward makes sense. We can eventually deprecate v1alpha1, but no reason to rush into that any time soon.
Do you think it makes sense to keep the non-struct items for our v1alpha1 types, e.g. methods and unit tests? I'm inclined to rip those out as the operator will only act on v1 CRs.

Thanks for the context. That all makes sense.
If we don't use these going forward, I'd say go ahead and delete them.

Can you mark the v1/ files as branched in git in the commit they were initially created? Will avoid lost updates if we do changes to v1alpha1 before this is merged.

Closing in favor of GoogleCloudPlatform/prometheus-engine#199


feature: Biome formatter

Did you check the docs?

[X] I have read all the LazyVim docs

Is your feature request related to a problem? Please describe.
Biome won the prettier in Rust contest, with >95% compatibility with Prettier. Is it an idea to directly support Biome in conform somehow?
Describe the solution you'd like
An extra or something to use Biome over Prettier / Prettierd.
Describe alternatives you've considered
N/A
Additional context
No response

You can already use "Biome"s LSP in Neovim: https://github.com/neovim/nvim-lspconfig/blob/master/lua/lspconfig/server_configurations/biome.lua . If you jst want Biomes formatting - maybe turning off the linter will suffice.

I also think it would be great to add an out of the box configuration setup for Biome within LazyVim, as it's quickly replacing prettier. Biome's plugin works well in VSCode and I need Neovim's behavior to match for cross-compatibility in the same projects.
It took some light digging to figure out to get Biome to work within LazyVim, but fortunately it's not too complicated. Inside my ~/.config/nvim/lua/plugins/plugins.lua file, I ensured biome is installed in mason, and disabled conform plugin for formatting (since Biome also handles that).
return {
  -- Use Biome instead of prettier / eslint
  {
    "stevearc/conform.nvim",
    enable = false,
  },
  {
    "williamboman/mason.nvim",
    opts = {
      ensure_installed = {
        "biome",
      },
    },
  },
}

Seems to work for me so far with this now, I tested in js, tsx, and python files and they both lint and format successfully 😃

You don't need to disable conform as it supports biome.
The following config works:
return {
  {
    "stevearc/conform.nvim",
    optional = true,
    opts = {
      -- for language support
      -- @see https://biomejs.dev/internals/language-support/
      formatters_by_ft = {
        ["javascript"] = { "biome" },
        ["javascriptreact"] = { "biome" },
        ["typescript"] = { "biome" },
        ["typescriptreact"] = { "biome" },
        ["json"] = { "biome" },
        ["jsonc"] = { "biome" },
        -- ["vue"] = { "biome" },
        -- ["css"] = { "biome" },
        -- ["scss"] = { "biome" },
        -- ["less"] = { "biome" },
        -- ["html"] = { "biome" },
      },
    },
  },
}

References:

biome supported languages
conform supported formatters

You don't need to disable conform as it supports biome. The following config works:
return {
  {
    "stevearc/conform.nvim",
    optional = true,
    opts = {
      -- for language support
      -- @see https://biomejs.dev/internals/language-support/
      formatters_by_ft = {
        ["javascript"] = { "biome" },
        ["javascriptreact"] = { "biome" },
        ["typescript"] = { "biome" },
        ["typescriptreact"] = { "biome" },
        ["json"] = { "biome" },
        ["jsonc"] = { "biome" },
        -- ["vue"] = { "biome" },
        -- ["css"] = { "biome" },
        -- ["scss"] = { "biome" },
        -- ["less"] = { "biome" },
        -- ["html"] = { "biome" },
      },
    },
  },
}

References:

biome supported languages
conform supported formatters

Hi @kyrisu, it dos not work well when you must use prettier in work, this is better when there is some custom prettier configuration in your project.
local function biome_lsp_or_prettier(bufnr)
  -- local has_biome_lsp = vim.lsp.get_clients({
  --   bufnr = bufnr,
  --   name = "biome",
  -- })[1]
  -- if has_biome_lsp then
  --   return {}
  -- end
  local has_prettier = vim.fs.find({
    -- https://prettier.io/docs/en/configuration.html
    ".prettierrc",
    ".prettierrc.json",
    ".prettierrc.yml",
    ".prettierrc.yaml",
    ".prettierrc.json5",
    ".prettierrc.js",
    ".prettierrc.cjs",
    ".prettierrc.toml",
    "prettier.config.js",
    "prettier.config.cjs",
  }, { upward = true })[1]
  if has_prettier then
    return { "prettier" }
  end
  return { "biome" }
end

return {
  {
    "stevearc/conform.nvim",
    ---@class ConformOpts
    opts = {
      formatters_by_ft = {
        javascript = biome_lsp_or_prettier,
        typescript = biome_lsp_or_prettier,
        javascriptreact = biome_lsp_or_prettier,
        typescriptreact = biome_lsp_or_prettier,
        json = { "biome" },
        jsonc = { "biome" },
      },
    },
  },
}

You don't need to disable conform as it supports biome. The following config works:
return {
  {
    "stevearc/conform.nvim",
    optional = true,
    opts = {
      -- for language support
      -- @see https://biomejs.dev/internals/language-support/
      formatters_by_ft = {
        ["javascript"] = { "biome" },
        ["javascriptreact"] = { "biome" },
        ["typescript"] = { "biome" },
        ["typescriptreact"] = { "biome" },
        ["json"] = { "biome" },
        ["jsonc"] = { "biome" },
        -- ["vue"] = { "biome" },
        -- ["css"] = { "biome" },
        -- ["scss"] = { "biome" },
        -- ["less"] = { "biome" },
        -- ["html"] = { "biome" },
      },
    },
  },
}

References:

biome supported languages
conform supported formatters

Yeah, I also ended up re-enabling Conform with Biome, as I had some weird behavior and inconsistent formatting without it. It seems to work well now, I now have a very similar configuration to the one you posted where the formatter for every file is overridden with Biome.

You don't need to disable conform as it supports biome. The following config works:
return {
  {
    "stevearc/conform.nvim",
    optional = true,
    opts = {
      -- for language support
      -- @see https://biomejs.dev/internals/language-support/
      formatters_by_ft = {
        ["javascript"] = { "biome" },
        ["javascriptreact"] = { "biome" },
        ["typescript"] = { "biome" },
        ["typescriptreact"] = { "biome" },
        ["json"] = { "biome" },
        ["jsonc"] = { "biome" },
        -- ["vue"] = { "biome" },
        -- ["css"] = { "biome" },
        -- ["scss"] = { "biome" },
        -- ["less"] = { "biome" },
        -- ["html"] = { "biome" },
      },
    },
  },
}

References:

biome supported languages
conform supported formatters

Hi @kyrisu, it does not work well when you must use prettier in work, this is better when there is some custom prettier configuration in your project.
local function biome_lsp_or_prettier(bufnr)
  local has_biome_lsp = vim.lsp.get_clients({
    bufnr = bufnr,
    name = "biome",
  })[1]
  if has_biome_lsp then
    return {}
  end
  local has_prettier = vim.fs.find({
    -- https://prettier.io/docs/en/configuration.html
    ".prettierrc",
    ".prettierrc.json",
    ".prettierrc.yml",
    ".prettierrc.yaml",
    ".prettierrc.json5",
    ".prettierrc.js",
    ".prettierrc.cjs",
    ".prettierrc.toml",
    "prettier.config.js",
    "prettier.config.cjs",
  }, { upward = true })[1]
  if has_prettier then
    return { "prettier" }
  end
  return { "biome" }
end

return {
  {
    "stevearc/conform.nvim",
    ---@class ConformOpts
    opts = {
      formatters_by_ft = {
        javascript = biome_lsp_or_prettier,
        typescript = biome_lsp_or_prettier,
        javascriptreact = biome_lsp_or_prettier,
        typescriptreact = biome_lsp_or_prettier,
        json = { "biome" },
        jsonc = { "biome" },
      },
    },
  },
}

Thank you for posting this solution @binhtran432k ! After integrating a similar change into my plugins.lua file now I can work on Biome and Prettier projects without needing to change the global config each time (previously I'd just open the prettier projects in VSCode since it was too much effort to constantly juggle global configs). It would be great if there was an easier way to do this out of the box, but this is a great solution for now!

The 2nd line local has_biome_lsp = vim.lsp.get_clients({ is causing the error, because that function name is no longer available; instead now it is called get_active_clients.

@jsonMartin FYI these names are factors of which version of Neovim you're running with, and aren't influenced by updating LazyVim or other plugins. The function names involved are indeed a deprecation in upcoming Neovim 0.10, but get_clients is the newer non-deprecated syntax for >= 0.10. Perhaps the original snippet's author is using nightlies, which is perfectly fine.

The 2nd line local has_biome_lsp = vim.lsp.get_clients({ is causing the error, because that function name is no longer available; instead now it is called get_active_clients.

@jsonMartin FYI these names are factors of which version of Neovim you're running with, and aren't influenced by updating LazyVim or other plugins. The function names involved are indeed a deprecation in upcoming Neovim 0.10, but get_clients is the newer non-deprecated syntax for >= 0.10. Perhaps the original snippet's author is using nightlies, which is perfectly fine.

Gotcha. Thanks for the clarification

You can just install biomels with mason. No extra configuration needed.

You can just install biomels with mason. No extra configuration needed.

Just tried doing this, but for some reason my lsp is not showing all inlay errors. Some are shown in editor itself but when I do biome check . it shows more error in CLI but they are not shown in editor :(

I've been using Biome on my project. It's working fast and great, except for one thing: organizing imports. Coming from Prettier & eslint, where imports are organized on format.
is it possible automatically organize import biomels on format  rather than call it manually  ?
i read in biome documentation that it is possible with vscode  using custom action on save setting.

@jsonMartin thank you for the snippet. i find this is still required for biome projects when you have the prettier extra installed

I tried disabling pretter from extras along with eslint and continue to have issues with formatting on save. I am getting what looks like a double formatting (only on bracket spacing).
I did use the snippet called out in thread as well as attempted without it (as it mentioned biome should just work).
local function biome_lsp_or_prettier(bufnr)
  local has_biome_lsp = vim.lsp.get_clients({
    bufnr = bufnr,
    name = "biome",
  })[1]
  if has_biome_lsp then
    return {}
  end
  local has_prettier = vim.fs.find({
    -- https://prettier.io/docs/en/configuration.html
    ".prettierrc",
    ".prettierrc.json",
    ".prettierrc.yml",
    ".prettierrc.yaml",
    ".prettierrc.json5",
    ".prettierrc.js",
    ".prettierrc.cjs",
    ".prettierrc.toml",
    "prettier.config.js",
    "prettier.config.cjs",
  }, { upward = true })[1]
  if has_prettier then
    return { "prettier" }
  end
  return { "biome" }
end

return {
  -- Use Biome instead of prettier / eslint
  {
    "stevearc/conform.nvim",
    opts = {
      formatters_by_ft = {
        ["javascript"] = biome_lsp_or_prettier,
        ["javascriptreact"] = biome_lsp_or_prettier,
        ["typescript"] = biome_lsp_or_prettier,
        ["typescriptreact"] = biome_lsp_or_prettier,
        ["vue"] = { "biome" },
        ["css"] = { "biome" },
        ["scss"] = { "biome" },
        ["less"] = { "biome" },
        ["html"] = { "biome" },
        ["json"] = { "biome" },
        ["jsonc"] = { "biome" },
        ["yaml"] = { "biome" },
        ["markdown"] = { "biome" },
        ["markdown.mdx"] = { "biome" },
        ["graphql"] = { "biome" },
        ["handlebars"] = { "biome" },
      },
    },
    -- formatters = {
    --   biome = {
    --     -- Ensure Biome uses the config file
    --     args = { "format", "--config-path", "biome.json", "--stdin-file-path", "$FILENAME" },
    --   },
    -- },
  },
}

https://github.com/user-attachments/assets/78030a24-68b3-4062-94d8-c051e8754649

Leaving this incase any one else faces this challenge when prettier is added via lazy extras this worked for my issue
-- /nvim/plugins/conform.lua
local formatters = { "biome", "prettierd", "prettier" }
local function find_config(bufnr, config_files)
return vim.fs.find(config_files, {
upward = true,
stop = vim.fs.dirname(vim.api.nvim_buf_get_name(bufnr)),
path = vim.fs.dirname(vim.api.nvim_buf_get_name(bufnr)),
})[1]
end
local function biome_or_prettier(bufnr)
local has_biome_config = find_config(bufnr, { "biome.json", "biome.jsonc" })
if has_biome_config then
return { "biome", stop_after_first = true }
end
local has_prettier_config = find_config(bufnr, {
".prettierrc",
".prettierrc.json",
".prettierrc.yml",
".prettierrc.yaml",
".prettierrc.json5",
".prettierrc.js",
".prettierrc.cjs",
".prettierrc.toml",
"prettier.config.js",
"prettier.config.cjs",
})
if has_prettier_config then
return { "prettier", stop_after_first = true }
end
-- Default to Prettier if no config is found
return { "prettier", stop_after_first = true }
end
local filetypes_with_dynamic_formatter = {
"javascript",
"javascriptreact",
"typescript",
"typescriptreact",
"vue",
"css",
"scss",
"less",
"html",
"json",
"jsonc",
"yaml",
"markdown",
"markdown.mdx",
"graphql",
"handlebars",
}
return {
{
"stevearc/conform.nvim",
opts = {
formatters_by_ft = (function()
local result = {}
for _, ft in ipairs(filetypes_with_dynamic_formatter) do
result[ft] = biome_or_prettier
end
return result
end)(),
},
},
}

Unused local formatters also biome organize imports does not trigger on save am I missing something?

@jericopulvera I couldn't get organize imports to work with this setup.
-- conform.lua
local format_utils = require("utils.format")

return {
  "stevearc/conform.nvim",
  opts = function(_, opts)
    opts.formatters_by_ft = (function()
      local result = {}
      for _, ft in ipairs(format_utils.filetypes_with_dynamic_formatter) do
        result[ft] = format_utils.biome_or_prettier
      end
      return result
    end)()

    opts.format_on_save = function(bufnr)
      -- Disable with a global or buffer-local variable
      if vim.g.disable_autoformat or vim.b[bufnr].disable_autoformat then
        return
      end

      local formatter = format_utils.biome_or_prettier(bufnr)
      if formatter[1] == "biome" then
        return { timeout_ms = 500, lsp_fallback = true, async = false }
      end
      return false
    end

    -- Add Biome formatter
    -- opts.formatters = opts.formatters or {}
    opts.formatters.biome = {
      command = "biome",
      args = { "check", "--write", "$FILENAME" }, --  ← this was the magic that fixed organizing imports
      stdin = false,
    }

    return opts
  end,
}

and in my utils
local M = {}

M.find_config = function(bufnr, config_files)
  return vim.fs.find(config_files, {
    upward = true,
    stop = vim.fs.dirname(vim.api.nvim_buf_get_name(bufnr)),
    path = vim.fs.dirname(vim.api.nvim_buf_get_name(bufnr)),
  })[1]
end

M.biome_or_prettier = function(bufnr)
  local has_biome_config = M.find_config(bufnr, { "biome.json", "biome.jsonc" })

  if has_biome_config then
    return { "biome", stop_after_first = true }
  end

  local has_prettier_config = M.find_config(bufnr, {
    ".prettierrc",
    ".prettierrc.json",
    ".prettierrc.yml",
    ".prettierrc.yaml",
    ".prettierrc.json5",
    ".prettierrc.js",
    ".prettierrc.cjs",
    ".prettierrc.toml",
    "prettier.config.js",
    "prettier.config.cjs",
  })

  if has_prettier_config then
    return { "prettier", stop_after_first = true }
  end

  -- Default to Prettier if no config is found
  return { "prettier", stop_after_first = true }
end

M.format_file = function(bufnr)
  local file = vim.api.nvim_buf_get_name(bufnr)
  local formatter = M.biome_or_prettier(bufnr)

  if formatter[1] == "biome" then
    -- Run Biome
    local result = vim.fn.system("biome check --write " .. vim.fn.shellescape(file))
    if vim.v.shell_error == 0 then
      vim.cmd("edit!")
    else
      vim.api.nvim_err_writeln("Biome error: " .. result)
    end
  end
  -- Add Prettier logic here if needed
end

M.filetypes_with_dynamic_formatter = {
  "javascript",
  "javascriptreact",
  "typescript",
  "typescriptreact",
  "vue",
  "css",
  "scss",
  "less",
  "html",
  "json",
  "jsonc",
  "yaml",
  "markdown",
  "markdown.mdx",
  "graphql",
  "handlebars",
}

return M

@andrew-t-james-core I get this error using your config. Do you know what could be wrong?


test

@rultor hello

@rultor hello

@dzhovi Hi there! I understand a few simple commands: "merge", "deploy", etc. This page explains them briefly. Any questions or bug reports are welcome. Have fun :)


fix responsiveness

Closes #{1}
By submitting this pull request I confirm I've read and complied with the below declarations.

[ yes] I have tested the changes locally and they are functional.
[ yes] I ensure that my commit message is in imperative manner.
[no ] I ensure that I have properly referenced the related issue.
[no ] I ensure that I sent this pull request after being assigned to the corresponding issue.
[yes ] This pull request has a descriptive title. For example, Add/Fix {Feature/Bug}, not Update README.md or Add new code.
[ okay] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.

This is totally totally upto you, I think hover is okay, so what should I
do ?
On Mon 3 Dec, 2018, 10:02 AM Anshuman Verma<EMAIL_ADDRESS>wrote:

@anshumanv requested changes on this pull request.
This is what I see when I hover on the last pokemon, I think it would make
sense to make the popup cover the entire viewport when screen is smaller
than a certain value.
[image: image]
https://user-images.githubusercontent.com/21009455/49353199-69086600-f6e2-11e8-9f9a-5d27698b6b87.png
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NJACKWinterOfCode/evolutions-webapp/pull/4#pullrequestreview-180611720,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AP2ATwr-u8aoNOkp2H8x3V1v3-gHcCpyks5u1KlQgaJpZM4Y8vWN
.

I think hover is okay

Can you see the last poekmon? I think we can just scale the popup to cover the entire screen, see if that fixes anything.


Hi , thanks for so great work,Is the current code capable of supporting the simultaneous use of multiple IP adapters?

you can use https://github.com/cubiq/ComfyUI_IPAdapter_plus

hello, i am interested in this as well but want to use it without comfyUI.
Is there currently any way to do that?

@whiterose199187  I am very rough to implement multipath ipadater in diffusers, if you need you can contact me

@whiterose199187 I am very rough to implement multipath ipadater in diffusers, if you need you can contact me.
https://github.com/Daming-TF/Diffusers-For-Multi-IPAdapter/tree/dev


fail to build tensorflow from source

Hello,everyone!
I am new about tensorflow,and I am just trying to build tensorflow from source according to the steps described step by step, but I get the following error, Is there anyone who can help on it? That would be very kind of you!
Thank you very much!
cynthia@cynthia-pc:~/tensorflow$ ./configure
..........continue........
then the result came with the following......
I guess that maybe something wrong with my bazel ,but I'm new about this,and I'm really no idea how to solve it.
unexpected pipe read status: No such file or directory
Server presumed dead. Now printing '/home/cynthia/.cache/bazel/_bazel_cynthia/581b5660c7c191b39a76e8a607014a30/server/jvm.out':
Java HotSpot(TM) Server VM warning: You have loaded library /home/cynthia/.cache/bazel/_bazel_cynthia/install/6a615f09339464d6ea7e8fe00f96c132/_embedded_binaries/libunix.so which might have disabled stack guard. The VM will try to fix the stack guard now.
It's highly recommended that you fix the library with 'execstack -c ', or link it with '-z noexecstack'.
JNI initialization failed: /home/cynthia/.cache/bazel/_bazel_cynthia/install/6a615f09339464d6ea7e8fe00f96c132/_embedded_binaries/libunix.so: /home/cynthia/.cache/bazel/_bazel_cynthia/install/6a615f09339464d6ea7e8fe00f96c132/_embedded_binaries/libunix.so: wrong ELF class: ELFCLASS64 (Possible cause: architecture word width mismatch).  Possibly your installation has been corrupted; if this problem persists, try 'rm -fr /home/cynthia/.cache/bazel/_bazel_cynthia/install/6a615f09339464d6ea7e8fe00f96c132'.
java.lang.UnsatisfiedLinkError: /home/cynthia/.cache/bazel/_bazel_cynthia/install/6a615f09339464d6ea7e8fe00f96c132/_embedded_binaries/libunix.so: /home/cynthia/.cache/bazel/_bazel_cynthia/install/6a615f09339464d6ea7e8fe00f96c132/_embedded_binaries/libunix.so: wrong ELF class: ELFCLASS64 (Possible cause: architecture word width mismatch)
at java.lang.ClassLoader$NativeLibrary.load(Native Method)
at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1941)
at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1857)
at java.lang.Runtime.loadLibrary0(Runtime.java:870)
at java.lang.System.loadLibrary(System.java:1122)
at com.google.devtools.build.lib.UnixJniLoader.loadJni(UnixJniLoader.java:28)
at com.google.devtools.build.lib.unix.ProcessUtils.(ProcessUtils.java:28)
at com.google.devtools.build.lib.util.ProcessUtils.getpid(ProcessUtils.java:47)
at com.google.devtools.build.lib.util.OsUtils.forceJNI(OsUtils.java:55)
at com.google.devtools.build.lib.util.OsUtils.maybeForceJNI(OsUtils.java:43)
at com.google.devtools.build.lib.runtime.BlazeRuntime.newRuntime(BlazeRuntime.java:934)
at com.google.devtools.build.lib.runtime.BlazeRuntime.createBlazeRPCServer(BlazeRuntime.java:838)
at com.google.devtools.build.lib.runtime.BlazeRuntime.serverMain(BlazeRuntime.java:777)
at com.google.devtools.build.lib.runtime.BlazeRuntime.main(BlazeRuntime.java:565)
at com.google.devtools.build.lib.bazel.BazelMain.main(BazelMain.java:57)

Is there anyone who can help?

SOLVED


HBASE-25478 - Implement retries when enabling tables in TestRegionReplicaReplicationEndpoint

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ master Compile Tests _

+1 :green_heart:
mvninstall
3m 52s
master passed

+1 :green_heart:
checkstyle
1m  6s
master passed

+1 :green_heart:
spotbugs
2m  2s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 32s
the patch passed

-0 :warning:
checkstyle
1m  3s
hbase-server: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
whitespace
0m  1s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m 17s
Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.

+1 :green_heart:
spotbugs
2m  7s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

39m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2866/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2866

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 1fa0007e61a4 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 8f55a2bb51

checkstyle
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2866/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: hbase-server U: hbase-server

Console output
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2866/1/console

versions
git=2.17.1 maven=3.6.3 spotbugs=3.1.12

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  3s
Docker mode activated.

Left few comments, looks good otherwise.

@virajjasani Thanks for the feedback, I've addressed your comments and tested locally.

Left few comments, looks good otherwise.

@virajjasani Thanks for the feedback, I've addressed your comments and tested locally.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

Waiting for @saintstack 's confirmation before merging this.

Waiting for @saintstack 's confirmation before merging this.


feat: pip causing app inspect failures and NOTICE

This PR adds an additional corrective post-process to PIP to ensure add-ons will pass appinspect. It Also ensures NOTICE is included in the distribution.

Codecov Report

Merging #224 (25a680e) into main (aa07fcf) will increase coverage by 36.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #224       +/-   ##
===========================================
+ Coverage   20.30%   56.32%   +36.02%
===========================================
  Files          36       37        +1
  Lines        2492     2512       +20
===========================================
+ Hits          506     1415      +909
+ Misses       1986     1097      -889

Impacted Files
Coverage Δ

splunk_add_on_ucc_framework/__init__.py
67.46% <100.00%> (+53.59%)
:arrow_up:

tests/data/test_ucc_generate.py
92.30% <0.00%> (ø)

...r_alert_builder/build_core/alert_actions_helper.py
24.62% <0.00%> (+13.43%)
:arrow_up:

...ar_alert_builder/build_core/alert_actions_merge.py
33.73% <0.00%> (+18.07%)
:arrow_up:

...alert_builder/build_core/alert_actions_template.py
100.00% <0.00%> (+30.76%)
:arrow_up:

..._framework/uccrestbuilder/endpoint/single_model.py
94.11% <0.00%> (+35.29%)
:arrow_up:

...ramework/uccrestbuilder/endpoint/multiple_model.py
94.44% <0.00%> (+38.88%)
:arrow_up:

..._on_ucc_framework/uccrestbuilder/endpoint/field.py
100.00% <0.00%> (+40.00%)
:arrow_up:

...ucc_framework/uccrestbuilder/endpoint/datainput.py
95.65% <0.00%> (+43.47%)
:arrow_up:

...k_add_on_ucc_framework/uccrestbuilder/rest_conf.py
92.00% <0.00%> (+48.00%)
:arrow_up:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa07fcf...25a680e. Read the comment docs.

@rfaircloth-splunk I created a PR https://github.com/splunk/addonfactory-ucc-generator/pull/225 specifically to drop support for py2/py3 libraries.

:tada: This PR is included in version 5.3.0 :tada:
The release is available on:

v5.3.0
GitHub release

Your semantic-release bot :package::rocket:


[1pt] Create app and install basic dependencies - Setup (group task)

Create React App.
Install React Redux, Redux Logger and React Router.

https://github.com/oluwatobi-fasasi/react-group-project/pull/26


Grafana values.yaml not being processed

What did you do?
helm upgrade --install kube-prometheus coreos/kube-prometheus --namespace monitoring -f values.yaml
What did you expect to see?
operator installed with values specified in ./helm/grafana/values.yaml
What did you see instead? Under which circumstances?
operator installed correctly, without grafana updates to values.yaml
Environment
Azure Kubernetes Service

Prometheus Operator version:
image: quay.io/coreos/prometheus-operator:v0.25.0

Kubernetes version information:
Client Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.2", GitCommit:"bb9ffb1654d4a729bb4cec18ff088eacc153c239", GitTreeState:"clean", BuildDate:"2018-08-07T23:17:28Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"11", GitVersion:"v1.11.2", GitCommit:"bb9ffb1654d4a729bb4cec18ff088eacc153c239", GitTreeState:"clean", BuildDate:"2018-08-07T23:08:19Z", GoVersion:"go1.10.3", Compiler:"gc", Platform:"linux/amd64"}

Kubernetes cluster kind:

Azure

looks like you only passed in one set of values but if you want to have a second set of values you need to add the -f flag again and then your values.
for example:
helm upgrade --install kube-prometheus coreos/kube-prometheus --namespace monitoring -f values.yaml -f ./helm/grafana/values.yaml

The prometheus-operator and kube-prometheus helm charts have been migrated to the upstream stable helm charts. Because of this we are currently not accepting any pull requests or issues about it in this repository. We announced this here: https://github.com/coreos/prometheus-operator/tree/master/helm#warning
Please open an issue on the upstream helm charts repository, as the Prometheus Operator maintainers neither use nor maintain the helm charts.
Thank you for your understanding! :slightly_smiling_face:


Setup guide improvements

I'm looking forward to taking a look at Kin! I started setting things up but the documentation is a little unclear. I've spent 45 minutes or so getting it all rolling, and still wasn't able to get everything set up. I'm sure with some more time I'd be able to figure it out, but, as someone who's setting this up just to take a look at what Kin is and how it works (I was late to sign up for the invite), it's all of the time I'm able to spend on getting it working right now.
For instance, with some of the OAauth client ID configurations:
/*
 * Google OAuth app secrets
 * https://console.developers.google.com/projectselector/apis/credentials
 */
GOOGLE_CLIENT_ID: '',
GOOGLE_CLIENT_SECRET: '',
GOOGLE_MAPS_KEY: '',

There are a handful of different Google Maps APIs, it's not clear which one needs to be turned on.
Also:

The eventbrite "ID" is called the "App Key"
I didn't see any Internal ID when I created my Meetup key.

A couple more lines on each of these to describe the steps would be helpful.
Also, on a somewhat separate note, I noticed that if I wasn't providing keys for all of the different OAuth services, the API was continuously crashing.

I've added more comments / explanations in secrets.js in 0614482 to not have to search the answer on this issue ;)

There are a handful of different Google Maps APIs, it's not clear which one needs to be turned on.

Yep definitely, the one we use currently is the Google Static Map API, it's not great but it's easy to setup, there will most likely be a migration further down the line as we can't detect whether a location is found before displaying the "map" to the user.

The eventbrite "ID" is called the "App Key"

Yeah, OAuth2 is great ... except all those providers implement it in a slightly different way, with slightly different names and slightly different behaviours :) Anyhow, the "translation" is now documented in the file.

I didn't see any Internal ID when I created my Meetup key.

That internal ID is a weird beast, we're currently only using it when someone deauth Meetup from Kin: it's one of the only provider that allows us to craft a query to deauth the app. That said, they "allow" it in a way that just isn't practical (and isn't secure)

Also, on a somewhat separate note, I noticed that if I wasn't providing keys for all of the different OAuth services, the API was continuously crashing.

I had written a blurb about that on another issue: kin-api-server/issues/16:

In theory, providers are disabled by default until you set values for their various secrets. You will be greeted by messages like this in the logs when starting the server or each unconfigured provider:
WARN could not load file auth.js for source github: TypeError: OAuth2Strategy requires a clientID option
(in this case we have no client ID / client secret for Github)
... except for Facebook and Google. They are used as an authentication mechanism to connect to Kin, and we haven't had time to make them by-passable if not configured.

I've now directly added it in secrets.js for easier access ;)
Thanks again, and keep the feedback coming, it's highly appreciated.
I'm closing this for now but feel free to reopen if you find any other quirks needing more documentation / explanation.


Add some API requests analysis

Accumulate some statistics of the API requests, i.e. which indices are most accessed

Merged into https://github.com/elastic/geneve/issues/68


Widget-specific setting overrides

Added ability to override any django-summernote and summernote default settings on a per widget basis.
Back story: I use summernote (through django-summernote) in a few places on my site. I wanted to disable uploads in all spots EXCEPT for one. That was easy enough, but I wasn't able to re-enable it on the one field I needed it on.
Fixes #278. Fixes #281.

Coverage increased (+0.009%) to 97.908% when pulling b3fe6f1d7912308ad895200e984dc306d00d38e9 on jaddison:master into 053832182ae22dd4435efce027397f436291c9c1 on summernote:master.

Note to project maintainers - I added a fix for the iframe widget always inlining images instead of using the upload handler.

@jaddison Thank you. Could you review my pull request https://github.com/summernote/django-summernote/pull/282 ?

Am reviewing now...

Closed by #282, thanks.


Fix Eclipse jsHint integration

Because jshint-eclipse does not support multiple .jshintrc files, I've updated the root .jshintrc to include jasmine.  This is then set to false in lower-down `.jshintrc files using the extends capability.
This has the added benefit of meaning we no longer write out .jshintrc files as part of the build step.
The only downside here is that jsHint in Eclipse thinks Jasmine globals are okay in all of our Source files. However, that's not a big deal and travis and our own jshint build step will detect the problem if
someone tries to call jasmine outside of the Specs directory.
A couple of notes:
This removes some files from .gitignore, so you'll want to clean or delete the files before you checkout this branch.
I'm not sure it's required, but make sure Eclipse is also up-to-date before testing this.
Fixes #3208 #3209

I can confirm this works for me in Eclipse Luna.  I did have to update my copy of the Eclipse JSHint plugin to the latest version.


Gemspec/DeprecatedAttributeAssignment: is gemspec.test_files= really deprecated?

I recently upgraded to rubocop 1.30.0 and noticed that it flagged my .gemspec file claiming that gemspec.test_files =  was deprecated. However, I cannot find any mention of this on the rubygems.org guides, nor in the Gem::Specificiation documentation, nor in the source of Gems::Specificiation. All I could find was issue #10065 (which was later renamed to Gemspec/DeprecatedAttributeAssignment). The issue links to a rubygems/guides PR where @drbrain does say he wants to deprecate gemspec.test_files=, but can't yet due to backwards compatibility concerns.
So, is gemspec.test_files= really deprecated? Is there an official list of deprecated gemspec attributes or attributes that are planned to be deprecated? If not, I don't think it's rubocop's place to deprecate things before they have been officially deprecated by upstream.

https://github.com/rubygems/guides/issues/90 is relevant and links to the commit that removed documentation for test_files=.

rubygems/guides#90 is not an official deprecation though, just a documentation removal and a comment from the maintainer that they would like to deprecate it in the future. Ideally, we need someone from the rubygems team to officially deprecate test_files and end the confusion.

https://github.com/rubygems/guides/issues/90#issuecomment-1143253417
We now have confirmation that test_files has not been deprecated, but is not suggested and can be safely omitted. Deprecation is a bit too strong a word here. Maybe calling test_files obsolete might be better?


Add ANTLR4 grammar support to Clickhouse

clickhouse added ANTLR4 grammar parsers
https://github.com/ClickHouse/ClickHouse/pull/11298
look like dbeaver can try to get grammar from clickhouse project, for fast add new ClickHouse dialect SQL syntax features

thanks for suggestion

I don't thin kthat we can do this. We don't use antlr or any sort of BNF-like grammar in SQL parser.
SQL parser is fuzzzy (recoverable) and can't rely on strict grammar.


[Addition]: another 7 gaming cluster to add to the other 7

Hotspot b58 Addresses
112pcBQKnxCBVgp2j5ds2RCqiwszf3zKtihNxrKHwxtG9jVumLbc
11Xb5FvaFX64nvArXWEh23VHgNLinubtZh2VMQe9n91fVj291db
11ZPCeC1HndCKsKWq7gmMisJ1tvvoT2mug8moRpmo6gsbzFDVgh
112m46jDihKMUAKW1HmG1iknGEaj6z9fTLfA3hg3Y9eqfBMHZWeP
112U3WWkkJwqHua9SHUmcqfgCVZ1kwNzF5HrTC9R9dtzScMcZVrp
112VR5nwot423pUc3zJk1oDMmEHUsYJt2ts8XEDmRt3jk3L76uF1
112Cec1okhTNxPivnRTp7xS1WxuU2YvjX5nrM7Us9cbqn6pYMF1W
1121RB6WdfPMn8h2U1MkGzPxVRLfrK2AXG7oNakPU9Xs2Z3gEFGr
11S1bzDiUKvy48PuqrxVpZAqsRbx84njnq7yJsW6JwxhXceLVdK
112Qqz27NUUyqcdnoRfN9NrupCMGjXQowwvG6krpi5Sa45Rq3uqA
11tVddxL7KZuwnPZzgx1wfNmnuabYgN6ZF3ekCf2Zq7zt7igSeK
112c7dihvE442tujXwUD8cZ7YCurRdaGoWGyG2KQbgykbvDE7yjm
11nExfhu6yXMySVTNqTepdwD1wgrG8VW1174VEyTLahg1JZ8bek
112awJiUV369C5hfq1DdbPLpoCmDzacvNCfgXjSmjRpxkgEJMJgq
Discord Handle
No response
Reason(s)
found another 7 gaming hotspots clearly owned by the same fraudster. All 14 only talking to each other , all asserted on the same day, all claim to have antennas at 36m or 35m ( which I know is impossible because I live here and everyone in the village would notice 14 antennas being erected in one day especially 35m in the sky. some claim to be on land that is owned by friends of mine and so I know there is no hotspot in those locations.
the two wallet addresses owning these gaming hotspots are
1398dJ3WBpkFgWTYxJubftDvrQtuqYfQL8rxjXAPzbW8XMYHwC2
13GgE8KibaRfcbJpnaudxG25mEG6QUTTNPgBoM8doDHRkAEk6Xz
2 examples of not possibly being where they claim to be, espicially with a 36m antenna. One on the corner of a road junction ( and its not on the house because I know who owns that ), the other in a field and i Know the owner of that field too, therre is no mast or electricity there.

Same brand, same assertion time in  the same block.
Definitely a cluster.


Trying a few things

... mostly from https://github.com/electron/electron/issues/1277#issuecomment-296397800 but to no avail. @scjody 's diagnostic from https://github.com/plotly/image-exporter/issues/39#issue-280597766 is prevails.

Note that I tried docker building a few versions of electron including some pretty older versions (with much older chromium like nw.js is using :wink: ), but to no avail also. This PR locks electron to its latest non-beta release.

Taken over by https://github.com/plotly/image-exporter/pull/78


Infowindow and tooltip issues

Updating CartoDB.js with several bugs fixed (https://github.com/CartoDB/cartodb.js/pull/1326/).
Fixed integration not working when checking hover field (Fixes https://github.com/CartoDB/cartodb/issues/8048).
Bug fixed related with click-infowindow rendering. CartoDB.js was doing:

  // Set a default template
    if (!this._hasTemplate()) {
      this.set({
        template: this.DEFAULT_TEMPLATE,
        template_type: 'underscore'
      });
    }

cc @alonsogarciapablo
CR: @matallo

I'll fix the tests

Ok @matallo thanks!

Don't worry, taking care of them.


Wav2Vec 2.0 training model on completely different language need some help with parameters and info

Hi,
I am training an ASR model on a completely different language from english using Wav2vec 2.0. Just need to know upto which  value of loss/accuracy I should train the model before moving to fine-tuning.
Can you share info like:

Number of epochs trained for pre-training before moving to fine-tuning.
Loss/accuracy required before moving on to fine-tuning.

Thanks in advance

Will goo be using a pretrained model as a baseline or are you starting entirely from scratch?

I am starting from scratch.

Why not start from a baseline pretrained model? I assume the vector representations of the audio will be similar enough across languages. You can then use those representations for your downstream ASR task. At least that’s how I think it’s supposed to work.

That's a good point. The reason I am training from scratch is because I want to know if training a model from scratch or using the baseline model yield any result change. I am also training a model on top of baseline model in parallel but there is stagnation for quite a while. And I am not sure if for a completely different language it will learn the correct quantized latent audio representation. So you can say that I am running an experiment here for my learning.

Oh wow, that's pretty cool. I'd love to hear more about how your training from scratch works out. Please keep us posted

I finetune from english model "wav2vec_vox.pt", using 400+ hours chinese unsupervised audios. running until checkpoint_best.pt keep the same. It ran 17 epochs. Then I finetuned wav2vec_ctc model on chinese supervised audios, 200+ hours and running 14 epochs, finally I got a similarity cer/ler result with wav2letter "streaming_convnets" model which using 1000+ hours audios to training. The 200+ supervised dataset got from 1000+ hours proportionally and I used "LexiconFreeDecoder" in wav2letter and in fairseq's binding/python module.

Hi @luweishuang can you let me know what were the loss and accuracy value you got in pre-training( i.e before starting fine tuning). That would really help.

@amant555 the pretraining log maybe was deleted by me, sorry

This question is difficult to answer, as it depends on your dataset. I would train the model until it has converged and make sure it is not overfitting, before exploring finetuning.

This question is difficult to answer, as it depends on your dataset. I would train the model until it has converged and make sure it is not overfitting, before exploring finetuning.

Hi, I'm trying to train a model from scratch using Arabic audio, but I found it is overfitting. The training set is about 500 hours.

Hi everyone, I am a B.Tech final year student and I am trying to run  and train the Wav2Vec2.0 model from scratch  and I am getting error. Can someone please tell me steps in order to train the model from scratch that I should follow? That would really help me.


Move drop table tmp_release_summary cascade to an 009 file

Otherwise, if a developer is working on 008, they'll need to run 002 then 008, since tmp_release_summary is created in 002, and 008 depends on it, but also drops it.
By moving it to an 009 file, a developer can just re-run 008 as often as they like.

agreed, I was going to suggest this too.

 kf-views: Move drop table tmp_release_summary cascade to an 009 file

Done in https://github.com/open-contracting/kingfisher-views/pull/117


Download queue pauses and doesn't download episodes.

Steps to reproduce

Go to entry
Download episode
Wait (or don't wait)

Expected behavior
Downloads should finish
Actual behavior
Queue pauses
Crash logs
No response
Aniyomi version
Preview r6150
Android version
Android 9
Device
Samsung Galaxy Note 8, SM-N90F
Other details
I get this sometimes:
List is empty
Acknowledgements

[X] I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
[X] I have written a short but informative title.
[X] If this is an issue with an extension, I should be opening an issue in the extensions repository.
[X] I have tried the troubleshooting guide.
[X] I have updated the app to version <IP_ADDRESS>.
[X] I have updated all installed extensions.
[X] I will fill out all of the requested information in this form.

My download queue pauses too and there is a notification saying Downloaded file not found.
I did not change my download location settings prior to this.

My download queue pauses too and there is a notification saying Downloaded file not found.
I did not change my download location settings prior to this.

Same here. Only fix for this is to downgrade to r6147.

issue still present.