30-45 second slow VS Code startup

:warning: We have copied additional data to your clipboard. Make sure to paste here. :warning:
:warning: Make sure to attach these files from your home-directory: :warning:
-prof-TK2WebO9.main.cpuprofile.txt
-prof-TK2WebO9.renderer.cpuprofile.txt

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Cask "Flux" does not pass checksum

Result of attempting to install flux (brew cask install flux):
Error: sha256 mismatch
Expected: 4fdcbf481b96e1bcda637956269c61791158183c3e0c035460a091eb3d3219d3
Actual: aaa1bc7533d487993f8b5ade5de2fd85adf7f398a0800c456286d11d88753752
The error reoccurs even after running brew update and deleting the existing download.

Manually downloading and running the sha256sum yields the same result: aaa1bc7533d487993f8b5ade5de2fd85adf7f398a0800c456286d11d88753752
Seems like the version was updated to 37.1, according to https://justgetflux.com/mac/macflux.xml.

Fixed in https://github.com/caskroom/homebrew-cask/pull/22290.


connectionState is not updated when delegate's method connectionChange is called

Hi,
I have experienced a case when user presses power button to turn phone's screen off or app is in background for a long enough time, and then they turn it on again and the app resumes, the socket connection is disconnected. I have implemented the stateChangeDelegate to manually connect but it doesn't work, because in your connect() method of PusherSwift.swift, it checks for connection state and return if it's connected. The problem is, at that moment the state was still connected (not updated to disconnected) because of this method
private func updateConnectionState(newState: ConnectionState) {
    self.stateChangeDelegate?.connectionChange(self.connectionState, new: newState)
    self.connectionState = newState
}

It should update self.connectionState before calling the connectionChange on delegate.
Also, I also suggest the method name should be connectionChanged not connectionChange. Normally we would more likely to handle the connection after it's changed from one state to another state, not before it will change (like my case to manually re-establish the connection).
The autoReconnect doesn't work because the reachability event is not fired as the internet connection was fine, only the socket was disconnected (i think because of server closes connection)
Please check.

Both valid points - I'll change this for the 1.0.0 release which is here: #34

thank you.


Update list of supported Azure Blob account types

Update list of supported Azure Blob account types
Description
As per the inquiry on the dev mailing list, this change updates the documentation to reflect the current list of supported Azure Blob Storage account types.
Status

done, ready for review

Checklist

[ ] Code linting n/a, docs only change
[x] Documentation
[ ] Tests n/a, docs only change
[x] ICLA committer

Codecov Report

Merging #1450 into trunk will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            trunk    #1450   +/-   ##
=======================================
  Coverage   86.15%   86.15%
=======================================
  Files         375      375
  Lines       78625    78625
  Branches     7768     7768
=======================================
  Hits        67740    67740
  Misses       7953     7953
  Partials     2932     2932

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 707b126...aeae7a5. Read the comment docs.


enter: Dictionary changed size during iteration

This error happened when using localimport in an application created with PyInstaller.
$ dist/gitlab-manage/gitlab-manage.exe
Traceback (most recent call last):
  File "pyinstaller-bootstrap.py", line 8, in <module>
    nodepy.main(['--current-dir', os.path.dirname(__file__), './gui.py'])
  File "nodepy.py", line 1258, in main
  File "nodepy.py", line 1282, in _main
  File "nodepy.py", line 899, in __enter__
  File "site-packages\localimport.py", line 145, in __enter__
RuntimeError: dictionary changed size during iteration
Failed to execute script pyinstaller-bootstrap

It's an error with Python 3, as dict.items() yields a dict_view object and the dictionary must not changed during iteration over this object.


Console icon is missing.

Steps to reproduce

Open pwsh.exe

Expected behavior

Console opened with correct icon.

Actual behavior

Console opened with default icon.

This images shows that native powershell has correct icon, while powershell core only shows default icon.

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      6.2.0-preview.1
PSEdition                      Core
GitCommitId                    6.2.0-preview.1
OS                             Microsoft Windows 10.0.17763
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

@Elderry did you use the MSI installer or the zip pkg?  This doesn't repro for me.

@SteveL-MSFT MSL installer.

Does it work in a normal console? If I’m not mistake you are using cmder.

I figured out that it's my shortcut(lnk) file's problem. Here is the script I used to create shortcut:
$shortcut = $(New-Object -ComObject 'WScript.Shell').CreateShortcut($Path)

For PowerShell Core, I have to explicitly add this line
$shortcut.IconLocation = "$Target, 0"

to make console display the correct icon, while Native PowerShell doesn't has this problem.

Glad you figured it out!


adding matplotlib inline for notebook

pandas-profiling should work without the matplotlib inline command. If that is not the case, please let me know. If this is just something you want to add in a personal notebook, go ahead but I won't merge it to this example notebook.

It did not work for me without the inline.
On Wed, Feb 10, 2016, 17:09 Jos Polfliet<EMAIL_ADDRESS>wrote:

pandas-profiling should work without the matplotlib inline command. If
that is not the case, please let me know. If this is just something you
want to add in a personal notebook, go ahead but I won't merge it to this
example notebook.
—
Reply to this email directly or view it on GitHub
https://github.com/JosPolfliet/pandas-profiling/pull/4#issuecomment-182664882
.

What version of matplotlib, pandas, Python and Jupyter are you using? I'll try to recreate

matplotlib - 1.5.0
pandas - 0.17.1
python - 2.7.11
notebook server - 4.0.6
On Wed, Feb 10, 2016 at 6:38 PM Jos Polfliet<EMAIL_ADDRESS>wrote:

What version of matplotlib, pandas, Python and Jupyter are you using? I'll
try to recreate
—
Reply to this email directly or view it on GitHub
https://github.com/JosPolfliet/pandas-profiling/pull/4#issuecomment-182677455
.

Couldn't replicate it so it does not look like a dependency issue. Can you add the output of pip freeze and the full traceback of the error you are seeing? If not an error, can you add a screenshot of what is wrong? What OS/browser are you using?


fix build arg passing

Relates to https://github.com/SQLStreamStore/SQLStreamStore/pull/168
Without this, dotnet was intercepting some options, e.g. -h.

Good catch


Corrected bug to use Upper case on first letter of tenant

Scan submitted to Checkmarx

Checkmarx SAST - Scan Summary & Details
Cx-SAST Summary
Total of 7 vulnerabilities 0 High 0 Medium 7 Low 0 Info
Violation Summary
No policy violation found

Checkmarx SCA - Scan Summary & Details
Cx-SCA Summary
Total Packages Identified: 0
Scan Risk Score: 0.00
 0 High severity vulnerabilities
 0 Medium severity vulnerabilities
 0 Low severity vulnerabilities
View more details on Checkmarx UI
Cx-SCA vulnerability result overview
No package violation found


Document adding SVGs as React components

Preview

@mareksuscak One thing to document might be how the component can accept props which are applied to the <svg> such as,
 <Logo className="icon" />  or  <Logo {...props} />

These props are essential for my use of SVG components because I have the same SVG which different dimensions and classNames.
Also when Jest snapshots are made of these SVG components in CRA2 it seems to just print their filenames.. there's no <svg>...</svg> tags, just a string of "icon.svg". Is that intentional? @Timer @gaearon
This means that the snapshots don't include these props, which (of course) means the snapshots are missing particular app states.

@holloway Thanks for bringing it up. I think we discussed doing something like this and then forgot to fix it. Since 2.0 is not tagged at latest yet, I think it's acceptable to consider this a bugfix before final, and then insta-deprecate versions before the final one. We'll make a PR soon.

This was merged into next. Fixed via 9f7f2abf2e32ef997238e6b8cc7c1528063ebe24.

oops thanks

No worries, I was planning to update this PR later tonight but I'm glad you were able to cherry-pick the changes. Next time around, I'll make sure to allow edits from maintainers!


SW-4652 Only export visible inventory-by-nursery fields

CSV export of the "by nursery" inventory view was requesting the same set of
fields that are used to populate the UI, including IDs and raw numeric values.
The IDs weren't useful to users, and the raw numeric values were causing the
export to fail because CSVs need to be localized and thus can't include
non-localized fields.
Update the request construction code to only include the user-visible fields
when exporting the view to a CSV.

Current dependencies on/for this PR:

main

PR #1984   👈

This stack of pull requests is managed by Graphite.


Possible wrong comparson in traffic_simulator::pose::isInLanelet

Description
In traffic_simulator::pose::isInLanelet to compare distance_to_start_lanelet_pose and distance_to_end_lanelet_pose with tolerance operator "<" is used. This can possibly lead to wrong result when tolerance is 0 and one of the measured distances is also 0, which means pose is in lanelet (start or end of it). If this is not expected behaviour operator "<=" should be used.
To Reproduce

Switch to RJD-1197/pose_module. This branch contains needed test file
Add this testcase to the test_pose.cpp file.
Run the test suite.

TEST_F(PoseTest, isInLanelet_end_of_previous_lanelet)
{
  const auto pose =
    traffic_simulator::helper::constructCanonicalizedLaneletPose(3002163, 0.0, 0.0, hdmap_utils);

  const auto end_lanelet_pose = traffic_simulator::helper::constructCanonicalizedLaneletPose(
    195, hdmap_utils->getLaneletLength(195), 0.0, hdmap_utils);
  const auto distance_to_end_lanelet_pose =
    longitudinalDistance(pose, end_lanelet_pose, false, false, false, hdmap_utils);

  ASSERT_TRUE(distance_to_end_lanelet_pose);
  ASSERT_TRUE(std::abs(distance_to_end_lanelet_pose.value()) == 0.0);

  EXPECT_TRUE(traffic_simulator::pose::isInLanelet(pose, 195, 0.0, hdmap_utils));
}

Expected behavior
If pose is at the start or end of lanelet function traffic_simulator::pose::isInLanelet should return true;

I could not understand what you want to claim in this text.
Please describe source code and it's expected behavior and actual behavior.


Revert "arch_atomic : Introduce CONFIG_LIBC_ARCH_ATOMIC"

Reverts apache/nuttx#14681

[Experimental Bot, please feedback here]
Yes, assuming the PR description itself includes the required details about the revert reason, functional changes, and impact.  Simply stating "Reverts apache/nuttx#14681" is insufficient on its own. The PR author needs to fill in the rest of the template regarding the impact of reverting the change, including testing to show the previous (desired) behavior has been restored.

@TakuyaMiyasita could you fix the compiler error ASAP? so we don't need revert your change here.

@xiaoxiang781216 @masayuki2009 @acassis @jerpelea
Please revert the PR, I don't have enough time currently...I will try to fix later.


No tab Metrics

Installed argocd-extension-metrics:
kustomize build ./manifests | kubectl apply -f - --namespace=argocd
but there is no tab Metrics.

Maybe there were some other steps that needed to be completed for installation?
argocd-extension-metrics: latest
argocd-extensions: v0.2.1
argocd: v2.8.4+c279299

Closing this for now as the installation instructions were updated in the main README file in this repo.
Please reopen if the issue remains.


Set up continuous deployment

Use travis CI to continuously deploy prometheus.io after every push to master. A test run can be found here: https://travis-ci.org/prometheus/docs
For authentication a deploy key is used, as that allows for the most granular access rights (access to only a single repo: prometheus/prometheus.github.io). More details can be found here: http://docs.travis-ci.com/user/private-dependencies/. The deploy key is a 4096 bit RSA key, stored encrypted inside of the repo as well as our shared LastPass folder.
@juliusv @fabxc

:+1: Nice, thanks!


Catan unittests

Unittests with catan

@sed-i, @dstathis: are we ok with taking this in? unless im missing something, it does introduce another unit testing facet that we've not really discussed as a group.


🔧 Fix renovate file matching pattern

It was not super obvious, but it appears that it matches the full path, which means that none of the run.sh files would ever match.  This would explain why they are not showing up in the dependency dashboard.
Tested at https://regex101.com/r/n0FZYa/1

This did the trick!


Fix vendor path after PS4 conversion

Self-explanatory I hope.

Nice one, thanks!

This is released in https://github.com/BenConstable/phpspec-laravel/releases/tag/v4.0.1.


change default shareability to internal

Fixes https://github.com/SeedCompany/cord-api-v3/issues/1894

PR outcome is successful, the default shareability has been changed from "External" to "Internal".


Don't allow a post with an existing body hash

Is there a hierarchy between posts and comments? Cos if they're both just native posts with an implied variant type, pointing to the same external content, then Jake might be right in that the solution is different metadata.... or something else.

Yeah okay to close.


Allow installation to Python 3.10 environment

This is needed for internal documentation tool.
All unit tests pass with Python 3.10.
Also restrict the CI check to use pylint-2 as
a temporary workaround for #210.

I suppose this is fine if this is blocking other doc updates, but if it is just unitary, I'd rather fix the root cause.  We pulled the copyright checker from cirq, and I think we would like to continue doing the same thing as cirq is doing.

The pylint version downgrade here is just to let the CI pass for this PR.
The actual change here is to allow installation for 3.10 which is one
of the versions supported by the documentation tool (not sure if it can do 3.12).

I see, okay.  Let's then do this for now.


Octopus model renders as black

three-mesh-bvh v0.7.0 & three.js v0.151.0 work on tag 0.0.16:

Broken after #466

Looks like #455 broke this. When reversing the triangle order we also need to reverse normals, tangents.


Possible reverse proxy bug?

When I serve my site like this (minimized from the real example):
devd /veterans-employment-center/=http://localhost:8888/veterans-employment-center

The reverse proxy asks for the correct URL, http://localhost:8888/veterans-employment-center/:
$ ./serve.sh
10:31:02: Listening on http://devd.io:8000 (<IP_ADDRESS>:8000)
10:31:03: GET http://localhost:8888/veterans-employment-center/
  <- 404 Not Found 39B

But says it can't find it. That URL is valid and works:
$ curl http://localhost:8888/veterans-employment-center/
<!DOCTYPE html>
<html class="no-js" lang="en">
<head>
  <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">

Is this a bug or am I doing something wrong?

Hi Bill - could you please run devd with the --debug flag, and add the output here? That 404 could either be due to the request somehow not matching the route (i.e. from devd itself) or from the proxied app. The debug output will tell us which it is.

Sure, thought it doesn't do anything differently?
$ devd --debug /veterans-employment-center/=http://localhost:8888/veterans-employment-center
22:39:09: Listening on http://devd.io:8000 (<IP_ADDRESS>:8000)
22:39:11: GET http://localhost:8888/veterans-employment-center/
  <- 404 Not Found 39B

$ curl -s http://localhost:8888/veterans-employment-center/ | head
<!DOCTYPE html>
<html class="no-js" lang="en">
<head>
  <link rel="shortcut icon" href="assets/icons/favicon.ico" />
  <meta http-equiv="X-UA-Compatible" content="IE=edge,chrome=1">
  <meta name="viewport" content="width=device-width, initial-scale=1.0">
  <title>Home Veterans Employment Center™ : Vets.gov</title>
  <meta name="description" content="Veterans Employment Center">
  <link href='//fonts.googleapis.com/css?family=Source+Sans+Pro:400,300,600,700|Roboto+Slab' rel='stylesheet' type='text/css'>

I added in some debugging code that prints out the req and res variables in ServeHTTPContext in reverseproxy.go, and it looks like the port number is not getting set correctly:
req: &http.Request{Method:"GET", URL:(*url.URL)(0xc820080c00), Proto:"HTTP/1.1", ProtoMajor:1, ProtoMinor:1, Header:http.Header{"Accept":[]string{"text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8"}, "Upgrade-Insecure-Requests":[]string{"1"}, "X-Forwarded-Host":[]string{"devd.io:8000"}, "Connection":[]string{"keep-alive"}, "Cache-Control":[]string{"max-age=0"}, "Accept-Language":[]string{"en-US,en;q=0.8,es;q=0.6"}, "Cookie":[]string{"__uvt=; _session_id=3dffa33659fdc8a395e57f34a7e7bdc6; veteran_id=2; __unam=6f6ff60-150d42ce54d-30dead7f-37; _ga=GA1.2.1321538096.1447447251; uvts=3niXSEr2evao2jWw"}, "User-Agent":[]string{"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.106 Safari/537.36"}, "Dnt":[]string{"1"}, "Accept-Encoding":[]string{"gzip, deflate, sdch"}}, Body:(*struct { http.eofReaderWithWriteTo; io.Closer })(0x484caf0), ContentLength:0, TransferEncoding:[]string(nil), Close:false, Host:"devd.io:8000", Form:url.Values(nil), PostForm:url.Values(nil), MultipartForm:(*multipart.Form)(nil), Trailer:http.Header(nil), RemoteAddr:"<IP_ADDRESS>:62936", RequestURI:"/veterans-employment-center/", TLS:(*tls.ConnectionState)(nil), Cancel:(<-chan struct {})(nil)}

res:  &http.Response{Status:"404 Not Found ", StatusCode:404, Proto:"HTTP/1.1", ProtoMajor:1, ProtoMinor:1, Header:http.Header{"Content-Length":[]string{"39"}, "Connection":[]string{"Keep-Alive"}, "Content-Type":[]string{"text/plain"}, "X-Cascade":[]string{"pass"}, "Server":[]string{"WEBrick/1.3.1 (Ruby/2.1.2/2014-05-08)"}, "Date":[]string{"Tue, 22 Dec 2015 15:50:26 GMT"}}, Body:(*http.bodyEOFSignal)(0xc820013280), ContentLength:39, TransferEncoding:[]string(nil), Close:false, Trailer:http.Header(nil), Request:(*http.Request)(0xc8200e6540), TLS:(*tls.ConnectionState)(nil)}

you can see in the req that RemoteAddr is "<IP_ADDRESS>:62936". That ought to be 8888, right?

(I now see that req is the incoming request, so that's wrong)

The outreq and outreq.URL values look fine to me; I logged them right before transport.RoundTrip(outreq): https://gist.github.com/llimllib/6cfdbe6d62180387cc0e

If I comment out these lines from reverseproxy.go, it works:
if req.Header.Get("X-Forwarded-Host") == "" {
	req.Header.Set("X-Forwarded-Host", req.Host)
}

The server it's hitting is a rails s, which runs a WEBrick server.

I don't really have a proposed solution; is this just a bug in WEBrick? do we really need the x-forwarded-host header? Should we (ugh) provide an option to turn that off?

I have filed a bug with rack, which I think is probably the guilty party here, but I'm unsure. The bug is: https://github.com/rack/rack/issues/990


Another DxDispatch issue with QCOM Hexagon NPU on Windows (CompileOperator)

Using NPU driver version <IP_ADDRESS>0 ( 10/9/2024). on Snapdragon Dev Box
dxdispatch.exe .\models\dml_reduce.json -a Adreno
Running on 'Snapdragon(R) X Elite - X1E001DE - Qualcomm(R) Adreno(TM) GPU'
Compile Op
Dispatch 'sum': 1 iterations, 0.5781 ms median (CPU), 0.014063 ms median (GPU)
Resource 'input': 1, 2, 3, 4, 5, 6, 7, 8, 9
Resource 'output': 6, 15, 24
dxdispatch.exe..\models\dml_reduce.json -a Hexagon
Running on 'Qualcomm(R) Hexagon(TM) NPU'
Compile Op
Failed to execute the model: ERROR while initializing 'sum': C:\projects\DirectML\DxDispatch\src\dxdispatch\DmlDispatchable.cpp(404)\dxdispatchImpl.dll!00007FFA4C17BDB8: (caller: 00007FFA4C2B9884) Exception(1) tid(3754) 887A0004 The specified device interface or feature level is not supported on this system.
[DmlDispatchable::Initialize(m_device->DML()->CompileOperator( m_operator.Get(), dmlDesc.executionFlags, IID_PPV_ARGS(m_compiledOperator.ReleaseAndGetAddressOf())))]
dxdispatch.exe -s
Snapdragon(R) X Elite - X1E001DE - Qualcomm(R) Adreno(TM) GPU
-Version: <IP_ADDRESS>
-Hardware: true
-Integrated: true
-Dedicated Adapter Memory: 0 bytes
-Dedicated System Memory: 0 bytes
-Shared System Memory: 15.79 GB
-D3D12_GRAPHICS: true
-CORE_COMPUTE: true
-GENERIC_ML: true
Qualcomm(R) Hexagon(TM) NPU
-Version: <IP_ADDRESS>0
-Hardware: true
-Integrated: false
-Dedicated Adapter Memory: 0 bytes
-Dedicated System Memory: 0 bytes
-Shared System Memory: 15.79 GB
-D3D12_GRAPHICS: false
-CORE_COMPUTE: false
-GENERIC_ML: true
Microsoft Basic Render Driver
-Version: 10.0.26100.2314
-Hardware: false
-Integrated: false
-Dedicated Adapter Memory: 0 bytes
-Dedicated System Memory: 0 bytes

Hi @fobrs
Thank you for reporting the issue with the Qualcomm(R) Hexagon(TM) NPU on Windows. We have noted the error during the initialization of the 'sum' operation.
To address this, you might want to ensure that you are using the latest version of the DirectML library and that your system meets all the necessary hardware and software requirements. Additionally, you can try running the model with different execution flags or configurations to see if that resolves the issue.

Hi @ashumish-QCOM
I do run the latest version of DirectML and have installed the latest Qualcomm NPU driver.
The only thing I did was running the first example from the DirectML Readme. And it failed.... What should I tweak?
 **Getting Started**
See the [guide](https://github.com/microsoft/DirectML/blob/master/DxDispatch/doc/Guide.md) for detailed usage instructions.
The [models](https://github.com/microsoft/DirectML/blob/master/DxDispatch/models) directory contains some
simple examples to get started. For example, here's an example that invokes DML's reduction operator:

> dxdispatch.exe models/dml_reduce.json

Running on 'NVIDIA GeForce RTX 2070 SUPER'
Resource 'input': 1, 2, 3, 4, 5, 6, 7, 8, 9
Resource 'output': 6, 15, 24

I hope Qualcomm gets its NPU drivers 100% compatible without users requiring tweaking...

Hi @fobrs
Here are some steps you can look into:

Model Compatibility: Ensure the model dml_reduce.json is fully compatible with the Qualcomm Hexagon NPU. Some models may require specific optimizations.
Execution Flags: Experiment with different execution flags in your dxdispatch command to see if that resolves the issue.
DirectML Version: Ensure you are using DirectML version 1.15.4 or higher, as this version includes optimizations for the Qualcomm Hexagon NPU


Possible dynamic min/max on RangeSlider workaround using facet values?

Currently it is not possible to dynamically set min/max on the RangeSlider widget, I believe this is due to Meilisearch not yet supporting min/max stats. See discussion
Would it be possible to implement this functionality in instant-meilisearch by using facet keys? For example if I had a price field that I wanted to use the RangeSlider with, could instant-meilisearch make a facet request for price and use the first and last facet key for min-max?
"facetDistribution": {
    "price": {
      "1": 2099,   <<<< Min value 1
      "10": 2063,
      "100": 1995,
      "200": 2099  <<<< Max value is 200
     }
  }

This of course would be a temporary fix until Meilisearch supports min/max/avg ect. The RangeSlider widget would be way more useful with non-static min/max values.
Not sure if this is viable or has any potential issues, would appreciate feedback.

Hi @anthonycook and @bidoubiwa 👋
This is a feature request (handling max/min) we are tracking here
As @bidoubiwa explains, the workaround will work to some extent. Ideally, we should be able to do it natively from Meilisearch.
Knowing the limitations expressed by @bidoubiwa, would it still be useful for your use case @anthonycook?
Thanks!

Hi @gmourier 👋
I have done some basic testing as I was concerned that not being able to set maxValuesPerFacet on facet by facet basis would not be performant enough.
I have an e-commerce dataset with over 20,000 products, when performing a search query on all 20k+ products with 8 facets and all fields returned I'm seeing minimal difference in response time when setting maxValuesPerFacet to a large value.
One possible concern is that I set maxValuesPerFacet to a large number (e.g say 2000) and in the future my data exceeds that number for a facet, range/price filters would then show the incorrect max value. Currently my price filter returns over 1200 unique values so it's possible this could happen as my data grows.
In conclusion this workaround works for my use case until max/min support officially lands in Meilisearch. It may work for others but I'd be cautious about exceeding your maxValuesPerFacet setting and performance might become an issue on larger datasets or data that has many more facets, so testing would be required.

If we implement it, I suppose we can add a setting that the user has to manually enable to ensure they are aware of what they are doing. Which limits the bad surprise.

If we implement it, I suppose we can add a setting that the user has to manually enable to ensure they are aware of what they are doing. Which limits the bad surprise.

I think that would work, as it stands the range slider/input widgets feel very limited without dynamic min/max. It also leads to way more empty hits/results scenarios because you're having to guess the min/max values.
I think implementing this outweighs the one edge case as long as people are aware.

Hey @anthonycook, I'll be working on this feature once we merge #915 into main. To avoid too many conflicts.

Hey @anthonycook
It is implemented in this PR: #1046
and once this PR is merged: #1030 and released on npm you'll be able to use rangeSlider properly.
Don't forget to update to Meilisearch v1.1.0 at that point.
It should be next Monday :)

Hey! It is released. Please update to the latest version of instant-meilisearch and update your Meilisearch to v1.1.0


Edumo fft

the FFT code

so after further investigation, it seems that this isn't working on chrome. I'm assuming it's due to the ScriptProcessing web audio node being deprecated. I'll start investigating the up to date way to do what we want


fix(semantic): report errors for missing class method impls

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#8082  👈 (View in Graphite)
#8081
main

How to use the Graphite Merge Queue
Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Merge activity

Dec 23, 8:35 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

I'll add some follow up PRs.


[bug] Error during large transfer: urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='<IP_ADDRESS>', port=56675): Max retries exceeded with url: /api/v1/profile/compression

Describe the bug
I was trying to transfer this dataset (https://github.com/fMoW/dataset) into my own bucket using the command:
skyplane cp -r s3://spacenet-dataset/Hosted-Datasets/fmow/fmow-rgb/ s3://sarah-skylark-us-east-1/fmow-rgb/ -n 4

Although the transfer completed, I got the following error:
Traceback (most recent call last):
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 703, in urlopen
    httplib_response = self._make_request(
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 449, in
_make_request
    six.raise_from(e, None)
  File "<string>", line 3, in raise_from
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 444, in
_make_request
    httplib_response = conn.getresponse()
  File "/usr/local/anaconda3/lib/python3.9/http/client.py", line 1377, in getresponse
    response.begin()
  File "/usr/local/anaconda3/lib/python3.9/http/client.py", line 320, in begin
    version, status, reason = self._read_status()
  File "/usr/local/anaconda3/lib/python3.9/http/client.py", line 289, in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
http.client.RemoteDisconnected: Remote end closed connection without response

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/sarahwooders/repos/skyplane/skyplane/cli/cli_impl/cp_replicate.py", line 334, in launch_replication_job
    stats = rc.monitor_transfer(
  File "/Users/sarahwooders/repos/skyplane/skyplane/replicate/replicator_client.py", line 697, in monitor_transfer
    stats = self.http_pool.request("GET", f"{gateway.gateway_api_url}/api/v1/profile/compression")
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/request.py", line 74, in request
    return self.request_encode_url(
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/request.py", line 96, in request_encode_url
    return self.urlopen(method, url, **extra_kw)
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/poolmanager.py", line 376, in urlopen
    response = conn.urlopen(method, u.request_uri, **kw)
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 815, in urlopen
    return self.urlopen(
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 815, in urlopen
    return self.urlopen(
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 815, in urlopen
    return self.urlopen(
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 787, in urlopen
    retries = retries.increment(
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/util/retry.py", line 592, in increment
    raise MaxRetryError(_pool, url, error or ResponseError(cause))
urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='<IP_ADDRESS>', port=56675): Max retries exceeded with url:
/api/v1/profile/compression (Caused by ProtocolError('Connection aborted.', RemoteDisconnected('Remote end closed connection
without response')))

HTTPConnectionPool(host='<IP_ADDRESS>', port=56675): Max retries exceeded with url: /api/v1/profile/compression (Caused by
ProtocolError('Connection aborted.', RemoteDisconnected('Remote end closed connection without response')))
✓ Deprovisioning instances (4/4) in 12.76s
/usr/local/anaconda3/lib/python3.9/multiprocessing/resource_tracker.py:216: UserWarning: resource_tracker: There appear to be 2 leaked semaphore objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '

To Reproduce
Run a transfer from s3://spacenet-dataset/Hosted-Datasets/fmow/fmow-rgb/.
Expected behavior
Multipart uploads should have successfully completed.
Screenshots
If applicable, add screenshots to help explain your problem.

Transfer client log
In the log output from Skyplane, please upload the debug log from the CLI. You can find the path to the file in the log output:
$ skyplane cp ...
...
Storing debug information for transfer in /tmp/skyplane/transfer_logs/...
...

Environment info (please complete the following information):

OS: Mac OS
Python version: 3.9

I also got this error when running: skyplane cp -r s3://sky-imagenet-data/datasets/ILSVRC2012/ s3://skyplane-broadcast/imagenet-images/ -n 4
The error happens during chunk dispatching:
Exception in thread Thread-51:
Traceback (most recent call last):
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 703, in
urlopen
    httplib_response = self._make_request(
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 449, in
_make_request
    six.raise_from(e, None)
  File "<string>", line 3, in raise_from
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 444, in
_make_request
    httplib_response = conn.getresponse()
  File "/usr/local/anaconda3/lib/python3.9/http/client.py", line 1377, in getresponse
    response.begin()
  File "/usr/local/anaconda3/lib/python3.9/http/client.py", line 320, in begin
    version, status, reason = self._read_status()
  File "/usr/local/anaconda3/lib/python3.9/http/client.py", line 289, in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
http.client.RemoteDisconnected: Remote end closed connection without response

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/anaconda3/lib/python3.9/threading.py", line 973, in _bootstrap_inner
    self.run()
  File "/Users/sarahwooders/repos/skyplane/skyplane/api/tracker.py", line 135, in run
    raise e
  File "/Users/sarahwooders/repos/skyplane/skyplane/api/tracker.py", line 123, in run
    for cr in cr_streams[job_uuid]:
  File "/Users/sarahwooders/repos/skyplane/skyplane/api/transfer_job.py", line 389, in dispatch
    reply = self.http_pool.request(
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/request.py", line 78, in request
    return self.request_encode_body(
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/request.py", line 170, in
request_encode_body
    return self.urlopen(method, url, **extra_kw)
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/poolmanager.py", line 376, in
urlopen
    response = conn.urlopen(method, u.request_uri, **kw)
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 787, in
urlopen
    retries = retries.increment(
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/util/retry.py", line 550, in
increment
    raise six.reraise(type(error), error, _stacktrace)
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/packages/six.py", line 769, in
reraise
    raise value.with_traceback(tb)
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 703, in
urlopen
    httplib_response = self._make_request(
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 449, in
_make_request
    six.raise_from(e, None)
  File "<string>", line 3, in raise_from
  File "/Users/sarahwooders/repos/skyplane/env/lib/python3.9/site-packages/urllib3/connectionpool.py", line 444, in
_make_request
    httplib_response = conn.getresponse()
  File "/usr/local/anaconda3/lib/python3.9/http/client.py", line 1377, in getresponse
    response.begin()
  File "/usr/local/anaconda3/lib/python3.9/http/client.py", line 320, in begin
    version, status, reason = self._read_status()
  File "/usr/local/anaconda3/lib/python3.9/http/client.py", line 289, in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
urllib3.exceptions.ProtocolError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without
response'))


fix landXML parser so that it doesn't assume natural indices, uses acutal Point id values

I have a terrain model file from a client whose point IDs do not start from 1, and there are missing point id somewhere in the file. for example:
<Pnts>
7708128.575000000186<PHONE_NUMBER>99999984 3.409

7708104.796070420183<PHONE_NUMBER>97355553 -0.2

7708134.54899999965<PHONE_NUMBER>00000027 4.552

7708096.06045101583<PHONE_NUMBER>94511432 0.8

However, our code assumes nice natural indices for points starting from 1.
I've made changes to a new branch called 2023-11-landxml-use-point-ids to solve this: e641fc1426ebf57314449a3a8b951b34863db8e5
However, still two outstanding things I need help with:

[x] 1. By default, I want to preserve behaviour that the resultant data has a nice natural index. all this requires is a call to emeraldtriangles.cleanup.reindex:

import emeraldtriangles.cleanup as cleanup
self.surface['vertices'], self.surface['triangles'] = cleanup.reindex(self.surface['vertices'], self.surface['triangles'])

However, I'm unsure how to properly pass a keyword argument to allow a user to turn this behaviour off and preserve the original vertex ids

[ ] 2. the cython file emeraldtriangles/io/_landxml.pyx needs updating based on changes to emeraldtriangles/io/landxml.py, but I'm not familiar with cython syntax to do this on my own.

Fixed the first item with this commit:
60a90b674cd0b0bb0c3c321b3c7b873c1cb4af82
The Cython port can wait a little while, but not too long.

I see that @redhog merged this pull request to fix this issue:
https://github.com/emerald-geomodelling/EmeraldTriangles/pull/19
However, sadly, I don't think the port was successful. This is the output I would have expected from the private example file that I shared with you, @redhog :

But this is the result I get from the newly merged master version:

The points are in the right position, but something didn't quite go right with the indexing. Resultant vertices:
                   Y              X      Z   M
0       7.708129e+06<PHONE_NUMBER>00  3.409 NaN
1       7.708105e+06<PHONE_NUMBER>97 -0.200 NaN
2       7.708101e+06<PHONE_NUMBER>87 -0.200 NaN
3       7.708130e+06<PHONE_NUMBER>00  3.666 NaN
4       7.708096e+06<PHONE_NUMBER>38  0.800 NaN
...              ...            ...    ...  ..
636887  7.767128e+06<PHONE_NUMBER>00  5.026 NaN
636888  7.767139e+06<PHONE_NUMBER>00  4.996 NaN
636889  7.767097e+06<PHONE_NUMBER>00  4.116 NaN
636890  7.767096e+06<PHONE_NUMBER>00  5.127 NaN
636891  7.767096e+06<PHONE_NUMBER>00  5.104 NaN

[636892 rows x 4 columns]

resultant triangles:
              0       1       2
0             4       1       2
1             3       2       1
2             6       4       2
3            59      51       2
4            60      59       2
...         ...     ...     ...
1272986  636888  636887  636891
1272987  636891  636890  636888
1272988  636891  636889  636890
1272989  636893  636695  636694
1272990  636893  636894  636695

[1272991 rows x 3 columns]

The maximum valued vertex_index in the triangles array is greater than the maximum index in the vertices array. The vertices get set to natural-valued indices somewhere rather than preserving in the point indices within the input file

FYI, when I disable the cython, here's the output I get:
                   Y              X      Z   M      id
0       7.708129e+06<PHONE_NUMBER>00  3.409 NaN       2
1       7.708105e+06<PHONE_NUMBER>97 -0.200 NaN       3
2       7.708101e+06<PHONE_NUMBER>87 -0.200 NaN       4
3       7.708130e+06<PHONE_NUMBER>00  3.666 NaN       5
4       7.708096e+06<PHONE_NUMBER>38  0.800 NaN       6
...              ...            ...    ...  ..     ...
636887  7.767128e+06<PHONE_NUMBER>00  5.026 NaN  636891
636888  7.767139e+06<PHONE_NUMBER>00  4.996 NaN  636892
636889  7.767097e+06<PHONE_NUMBER>00  4.116 NaN  636893
636890  7.767096e+06<PHONE_NUMBER>00  5.127 NaN  636894
636891  7.767096e+06<PHONE_NUMBER>00  5.104 NaN  636895

[636892 rows x 5 columns]

triangles:
              0       1       2
0             3       0       1
1             2       1       0
2             5       3       1
3            58      50       1
4            59      58       1
...         ...     ...     ...
1272986  636885  636884  636888
1272987  636888  636887  636885
1272988  636888  636886  636887
1272989  636890  636692  636691
1272990  636890  636891  636692

[1272991 rows x 3 columns]

Not sure what caused the weird cython issue before where the DataFrames had natural indices and triangles pointed to the old vertex ids. Seems to be working now, though. We caught a mismatch with the default keyword parameters in cython and python not being equal, but this commit resolved that: ac4823b300de893e7bfa616f3c470395b2db9a04
With that, this issue is closed


Move bootstrap/start.php logic to compartmentalized runtime structure

+1 looks good

Let's do this in a version 8 branch and keep track of it. <IP_ADDRESS> might go at any time and this is a bit large of a change for that. Plus there are guaranteed to be merge conflicts if we don't synchronize those branches at some point.

Merged into v8.0.0


bug in ggl90/IDEMIX code?

In pkg/ggl90/ggl90_calc.F, recip_hFacI (inverse cell thickness of w-cells) is used a few times to scale variables and coefficients, but only when useIDEMIX=.TRUE.. Two places, where I think this is wrong are:
https://github.com/MITgcm/MITgcm/blob/1575dc0796db30b8393db6d59dc55153dfa104b0/pkg/ggl90/ggl90_calc.F#L696-L697
because verticalShear is also used to compute the Ri-number, where sigmaR has been computed without taking hFacs into account (grad_sigma.F). So in my view it would be consistent to not scale verticalShear with recip_hFacI**2
and
https://github.com/MITgcm/MITgcm/blob/1575dc0796db30b8393db6d59dc55153dfa104b0/pkg/ggl90/ggl90_calc.F#L831-L842
The implicit solver code was initially more or less a copy of impldiff.F, so I think that the GGL90 code is consistent with how we do things in general (i.e. only use recip_drF*recip_hFacC but not recip_hFacI with recip_drC).
As a consequence verticalShear can be too large near the bottom leading to too much forcing, and similarly for the coefficients a3d and c3d. Any opinions are welcome.

@mjlosch  Did the changes in PR #714 (also dealing with some recip_hFacI) address this issue above ?

Yes, but in #714, we took a different stance and agreed that using recip_hFacI in the coefficients a3d and c3d is correct and now we do it for all cases and in #714 we did not address the first part with the verticalShear, and I am not longer certain, that the current code is wrong.


[BUG]: Cannot access webcam in desktop browsers (Firefox, Chrome)

Describe the bug
When trying to access the webcam for image or pose projects, I get this error in Firefox's console:
Uncaught (in promise) DOMException: The fetching process for the media resource was aborted by the user agent at the user's request.
In Chrome, a similar error:
Uncaught (in promise) DOMException: The play() request was interrupted by a call to pause(). https://goo.gl/LdLk22
To Reproduce
Steps to reproduce the behavior:

Go to https://teachablemachine.withgoogle.com/train/image
Click on webcam (any class).
Allow camera permissions (reload if necessary).
Open console, see error.

Relevant Links
Apparently caused by this: https://goo.gl/LdLk22
Expected behavior
I should be able to see my webcam appear in the window.
Screenshots

Desktop (please complete the following information):

OS: Manjaro Linux
Browser: Firefox, Chrome
Version: 87, 90

Hi @ahob85 i have the same issue with both Chrome and Firefox. I'm on Ubuntu 20.04.

@ahob85 under Chrome i solved disabling all the extensions, or you can run Chrome in incognito mode.

I can not use my MAbook air with the internal webcam in Chrome and Safari.


Python dependencies are no longer checked

Describe the bug
The python tooling does not enforce the presence of dependencies at build time when doCheck is set to false.
Steps To Reproduce
Steps to reproduce the behavior:

nix build github/lourkeur/nixpkgs-python-dependency-bypass

Expected behavior
The build should fail with ERROR; Could not find a version that satisfies the requirement [...]
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Introduced in #248866
Notify maintainers
@tjni and @FRidh for the bisected commits (6c85fff302615c62bf4f632bca661bc48298b0a3,0d7647889c6701d8a0e6fa784e886012011ca2d8)
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.47, NixOS, 23.05 (Stoat), 23.05pre-git`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.13.5`
 - nixpkgs: `/etc/nix/channels/nixos`

I encountered this in a context where it is bad because I have a package with doCheck = false (chia) and as a result I am able to successfully build with clearly outdated dependencies. I also don't think it is intended behavior but this could be discussed.

Dependencies are no longer checked at all, regardless of the value of doCheck.
(@lourkeur, can you update your description?)
More concretely, it is neither checked whether a requirement exists at all nor whether the required version matches.
I've confirmed this for format = "pyproject" and format = "setuptools" (the default).
This is a major regression.
@FRidh, was this a deliberate design choice?
Workaround
Add the following to your buildPythonPackage drv:
# Enable Python requirements check
dontUsePypaInstall = true;
nativeBuildInputs = [ pipInstallHook ];

With my poc (same as OP but updated) it's different:
doCheck | setuptools | pyproject
false        | bad           | bad
true         | good         | bad

bad: no dependency check, successful build
good: dependency check and error

I can also show that in the pyproject case, if I add pythonImportsCheckHook, it fixes it. It's usually a good idea to add it anyways but I discovered that randomly earlier today.

The dependency check has now been introduced in python-updates branch as pythonRuntimeDepsCheckHook.


Can't represent a size of 355113 in Constraints

Describe the bug
Creating a large Text in a scrollable container causes this error.
xception in thread "AWT-EventQueue-0 @coroutine#8" java.lang.IllegalArgumentException: Can't represent a size of 355113 in Constraints
	at androidx.compose.ui.unit.Constraints$Companion.bitsNeedForSize(Constraints.kt:403)
	at androidx.compose.ui.unit.Constraints$Companion.createConstraints-Zbe2FdA$ui_unit(Constraints.kt:363)
	at androidx.compose.ui.unit.Constraints$Companion.fixed-JhjzzOo(Constraints.kt:314)
	at androidx.compose.foundation.text.modifiers.TextStringSimpleNode.measure-3p2s80s(TextStringSimpleNode.kt:238)
	at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:116)
	at androidx.compose.ui.graphics.SimpleGraphicsLayerModifier.measure-3p2s80s(GraphicsLayerModifier.kt:646)
	at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:116)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasure$2.invoke(LayoutNodeLayoutDelegate.kt:1499)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasure$2.invoke(LayoutNodeLayoutDelegate.kt:1495)
	at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2300)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:471)
	at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:234)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui(OwnerSnapshotObserver.kt:133)
	at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui(OwnerSnapshotObserver.kt:113)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1495)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate.access$performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:35)
	at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:560)
	at androidx.compose.ui.node.LayoutNode.remeasure-_Sx5XlM$ui(LayoutNode.kt:1140)
	at androidx.compose.ui.node.LayoutNode.remeasure-_Sx5XlM$ui$default(LayoutNode.kt:1131)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.doRemeasure-sdFAvZA(MeasureAndLayoutDelegate.kt:323)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.remeasureAndRelayoutIfNeeded(MeasureAndLayoutDelegate.kt:458)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.access$remeasureAndRelayoutIfNeeded(MeasureAndLayoutDelegate.kt:39)
	at androidx.compose.ui.node.MeasureAndLayoutDelegate.measureAndLayout(MeasureAndLayoutDelegate.kt:344)
	at androidx.compose.ui.platform.SkiaBasedOwner.measureAndLayout(SkiaBasedOwner.skiko.kt:246)
	at androidx.compose.ui.node.Owner.measureAndLayout$default(Owner.kt:223)
	at androidx.compose.ui.ComposeScene.render(ComposeScene.skiko.kt:546)
	at androidx.compose.ui.awt.ComposeBridge$skikoView$1$onRender$1.invoke(ComposeBridge.desktop.kt:156)
	at androidx.compose.ui.awt.ComposeBridge$skikoView$1$onRender$1.invoke(ComposeBridge.desktop.kt:155)
	at androidx.compose.ui.awt.ComposeBridge.catchExceptions(ComposeBridge.desktop.kt:128)
	at androidx.compose.ui.awt.ComposeBridge.access$catchExceptions(ComposeBridge.desktop.kt:59)
	at androidx.compose.ui.awt.ComposeBridge$skikoView$1.onRender(ComposeBridge.desktop.kt:155)
	at org.jetbrains.skiko.SkiaLayer.update$skiko(SkiaLayer.awt.kt:548)
	at org.jetbrains.skiko.redrawer.AWTRedrawer.update(AWTRedrawer.kt:54)
	at org.jetbrains.skiko.redrawer.MetalRedrawer$frameDispatcher$1.invokeSuspend(MetalRedrawer.kt:83)
	at org.jetbrains.skiko.redrawer.MetalRedrawer$frameDispatcher$1.invoke(MetalRedrawer.kt)
	at org.jetbrains.skiko.redrawer.MetalRedrawer$frameDispatcher$1.invoke(MetalRedrawer.kt)
	at org.jetbrains.skiko.FrameDispatcher$job$1.invokeSuspend(FrameDispatcher.kt:33)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:108)
	at java.desktop/java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:318)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:773)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:720)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:714)
	at java.base/java.security.AccessController.executePrivileged(AccessController.java:778)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:400)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:87)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:742)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)
	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [CoroutineId(8), "coroutine#8":StandaloneCoroutine{Cancelling}@38941da2, SwingDispatcher@66be5570]

Affected platforms

Desktop
Have not tested other platforms

Versions

Kotlin version*: 1.9.20-Beta2
Compose Multiplatform version*: 1.5.10-beta02
OS version(s)* (required for Desktop and iOS issues): macOS
OS architecture (x86 or arm64):  arm64
JDK (for desktop issues): 20

To Reproduce

The code below reproduces the error
Hit the last button, the one with the biggest number
Observe that an error is only thrown when scroll at the top of the code is true

        val scroll = true /* error only thrown when true */
        val scrollBar = scroll && false
        val scrollState by lazy { ScrollState(0) }
        val scrollBarAdapter by lazy { ScrollbarAdapter(scrollState) }
        val strings = mutableMapOf<Int, String>()
        application {
            Window(visible = true, onCloseRequest = {
                exitApplication()
            }) {

                var string by remember { mutableStateOf("") }
                Column(
                    modifier = Modifier.padding(10.dp)
                ) {
                    Row {

                        generateSequence(1) {
                            it * 10
                        }.take(7).forEach { num ->
                            Button(
                                onClick = {
                                    string += strings.getOrPut(num) {
                                        String(
                                            CharArray(num) {
                                                ('a'.code + it % 5).toChar()
                                            }
                                        )
                                    }
                                }
                            ) {
                                Text("add $num")
                            }
                        }
                    }
                    Row {
                        Box(
                            modifier = Modifier.padding(10.dp).let {
                                if (scroll) {
                                    it.verticalScroll(scrollState)
                                } else it
                            }
                        ) {
                            Text(string)
                        }
                        if (scrollBar) VerticalScrollbar(
                            modifier = Modifier.requiredSize(
                                width = LocalScrollbarStyle.current.thickness,
                                height = Dp.Unspecified
                            ).fillMaxHeight(),
                            adapter = scrollBarAdapter
                        )
                    }

                }

            }
        }

Expected behavior
I am pushing the limits of what can be handled with huge amounts of text like this, so it is not surprising that I will run into errors. However, this error in particular is not very informative on what caused the issue, or how to solve it. "Can't represent a size of 355113 in Constraints" is only helpful to internally to the developers of the library itself, since users (in this case) are not directly working with Constraints. if Constraints is supposed to be abstracted away by the comonents used in the reproducers, then a more user-friendly error message sould be thrown.
Given the vagueness of the error message, I am not exactly sure what I did "wrong". Was it wrong of me to use so much text? or did I implement scrolling wrong somehow? Or should i have broken the text up into multiple comonents? Or used some sort of lazy view? It is unclear.
So basically, the question is whether this is user error or not. If it is user error, a more friendly, informative, actionable error message should be thrown. If it is not user error, then the bug itself can be fixed.
Additional context
I am working on a simple log viewer, and this started happening to me with large amounts of text in a single log. I think I am probably doing it wrong, but this error is not helpful in pointing me in the right direction.

The repro can be simplified to this:
val constraints = Constraints.fixedWidth(width = 355113)

This error has to do with an algorithm of how Compose packs Constraints input values bits. Apparently, it's too much for what was considered by Google to be a sane value, so they explicitly throw an exception in this case.
Unfortunately, we don't own this piece of logic. So if you think it's something that needs a change for some specific (and should I notice, extreme) scenarios, you can make a report on Google Tracker.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


NATted evnironment test tool: vnet

Summary
We need a tool to test ICE / NAT traversal tests.
Motivation
Testing ICE is HARD. We need a tool to test pion/ice on various types of network configuration.
Describe alternatives you've considered
We could use a docker solution, but the test takes too long and lacks different types of NAT.
Additional context
Please see README under pion/transport/vnet/.

https://github.com/pion/transport/tree/feature/vnet
@hugoArregui @Sean-Der @backkem
My progress has been slow but the basic framework has been implemented. For pion/ice and pion/stun to be able to switch to vnet, ListenUDP() and Dialer are still missing and I will be implementing those soon, but I would be great to receive early feedback from you guys.

That is amazing @enobufs! I am super excited to try this out, reading through it right now.

This is amazing! I'm working on the checklist ICE PR, I think we should totally test it with this. Should we collect a list of the different test cases we want to cover so we can help you to develop and test this?

A list of possible test cases will help!
I need to implement STUN server in pion/stun before we start using it... @Sean-Der who do you think the right person for the work would be?

We do have this

Oh nice!! We could the simple STUN server (based on the test code) inside vnet for now.

Hmm, it may create a circular reference... can we add stun/server.go (marked as experimental or something)?

About simple STUN server:
Feel free to ctrl+c ctrl+v the https://github.com/gortc/stund if it enough
Also, regarding testing of ICE and STUN:
http://mininet.org/


Is there any plans to add "circuit-breaking" support or some others,just like Linkerd?

We are determine to use Linkerd or Conduit,even istio.We think if conduit have(or to be) the advance features,conduit will be the best choice.But we are not sure you have the plan and we can push it together.

Hi @Aavon!  Can you describe in more detail the failure scenarios that you are looking to address?

Ooh,that's my fault,I did not read the documentation carefully.They are written on roadmap is very clear
There are two main problems.
1.Is Conduit Kubernetes version dependent，we are using 1.8+,1.9+
2.How about the router-rule features?Are they commin with version 0.5?
(personally,how about push the docker images to docker.io...)
Hope for your reply!


How to fix Snappy Library exception during Python to executable conversion on linux based aws-ec2 instance?

I am trying to convert my python code to an executable file on ec2-instance. I am successfully able to convert the code into executable using pyinstaller, however when I run the executable, I was getting
'Sqlite3, OperationalError: unable to open database file'.
Once I changed the uri parameter to the function(connect_to_db) inside
"~/snappy-manifolds/database.py"
file mentioned in the error. I got another error
"SnapPy.PresentationMatrix has not attribute reduce_cython".
I am using Fastavro, Pandavro for reading and writing into an 'avro' file. However these libraries seem to have some dependencies on Snappy library as it is failing while fetching some data from Snappy library folders. I changed the uri parameter for 'connect_to_db' function defined in
"~/snappy-manifolds/database.py"
which led me into getting another error:
"SnapPy.PresentationMatrix has not attribute reduce_cython".
I don't know what to do next.
Error Traceback:
Traceback (most recent call last):
File "NVS_Main_V2.py", line 11, in
File "", line 971, in _find_and_load
File "", line 955, in _find_and_load_unlocked
File "", line 665, in _load_unlocked
File "/home/local/SNETACLOUD/svc-sdtm/anaconda3/lib/python3.6/site-packages/PyInstaller/loader/pyimod03_importers.py", line 627, in exec_module
exec(bytecode, module.dict)
File "NVS_Utility_Services.py", line 18, in
File "", line 971, in _find_and_load
File "", line 955, in _find_and_load_unlocked
File "", line 665, in _load_unlocked
File "/home/local/SNETACLOUD/svc-sdtm/anaconda3/lib/python3.6/site-packages/PyInstaller/loader/pyimod03_importers.py", line 627, in exec_module
exec(bytecode, module.dict)
File "site-packages/fastavro/init.py", line 48, in
File "", line 971, in _find_and_load
File "", line 955, in _find_and_load_unlocked
File "", line 665, in _load_unlocked
File "/home/local/SNETACLOUD/svc-sdtm/anaconda3/lib/python3.6/site-packages/PyInstaller/loader/pyimod03_importers.py", line 627, in exec_module
exec(bytecode, module.dict)
File "site-packages/fastavro/write.py", line 2, in
File "fastavro/_write.pyx", line 578, in init fastavro._write
File "", line 971, in _find_and_load
File "", line 955, in _find_and_load_unlocked
File "", line 665, in _load_unlocked
File "/home/local/SNETACLOUD/svc-sdtm/anaconda3/lib/python3.6/site-packages/PyInstaller/loader/pyimod03_importers.py", line 627, in exec_module
exec(bytecode, module.dict)
File "site-packages/snappy/init.py", line 7, in
File "cython/core/abelian_group.pyx", line 128, in init SnapPy
AttributeError: type object 'SnapPy.PresentationMatrix' has no attribute
'reduce_cython'
[29827] Failed to execute script NVS_Main_V2
uri is /home/local/SNETACLOUD/svc-sdtm/anaconda3/lib/python3.6/site-packages/snappy_manifolds/sqlite_files/manifolds.sqlite
This is the uri that I am currently passing to the connect_to_db function
File "NVS_Utility_Services.py", line 18, in
This statement in "NVS_Utility_Services.py" code is "import fastavro"
Expected result would be that the executable file successfully runs and perform the operation. When I'm running the python code on EC2 instance, it executes successfully but when I convert it into an executable, it breaks giving the error mentioned above

Looks like a duplicate of #1953.

In short, ask for a new release of Snappy that is built with Cython 0.28+, preferably 0.29.x (because, why not).


Add SectionScrubber.

SectionScrubber
Project URL
https://github.com/bakkenbaeck/SectionScrubber
Description
A component to quickly scroll between collection view sections.
Why it should be included to awesome-ios (optional)
Checklist

[x] Only one project/change is in this pull request
[x] Addition in chronological order (bottom of category)
[x] Supports iOS 9 / tvOS 10 or later
[x] Supports Swift 3 or later
[x] Has a commit from less than 2 years ago
[x] Has a clear README in English

          1 Warning

:warning:
Found 2 link issues, a project collaborator will take care of these, thanks :)

Link issues by awesome_bot

Line
Status
Link

520
301
https://github.com/bwide/BWCollectionView redirects tohttps://github.com/bwide/CollectionNode

2764
301
http://www.coreint.org/ redirects tohttp://coreint.org/

  Generated by :no_entry_sign: Danger

thx!


Add ke17z512 support

Add frdm_ke17z512 board support

board testing done iwth jlink debugger, linkserver v1.5.30 has issues with this board

Can someone help merge this PR?

@nordic-krch could you provide your review (or reassign this PR) so it can move forwards?

@nordic-krch, I'm assigning this over to me. If you disagree please switch back.
Based on your initial comment, https://github.com/zephyrproject-rtos/zephyr/pull/72784#pullrequestreview-2057491071, I'm assuming you are generally good with this PR.


Ray Tune custom callback based on model structure

I have some code that uses a callback to stop a Ray Tune trial if the complexity of the model (total leaves in the model) exceeds a given threshold). This works fine with a normal lightgbmmodel but fails when I use a lightgbm_ray model.
In the below code, "use_distributed" can be toggled to True to reproduce the error.
I presume the error is because the correct way of passing the metrics back to tune is with the TuneReportCheckpointCallback() from ray.tune.integration.lightgbm. I've played around with this, but it seems like I can only access the metrics reported by the lightgbm model. I can't add the "total_leaves" as a metric because it relies on accessing the model itself, not just the data and predictions.
Is it possible to report total_leaves to ray tune with lightgbm_ray?
#%%
# set up and load boston data
import numpy as np
import pandas as pd
import os
import lightgbm
from lightgbm_ray import RayLGBMRegressor, RayParams, RayDMatrix
from sklearn.datasets import load_boston
from sklearn.metrics import mean_squared_error
from sklearn.model_selection import train_test_split
import ray
from ray.air import session
from ray import tune
from ray.tune.search.optuna import OptunaSearch

ray.shutdown()
## Initialise ray:
if ray.is_initialized() == False:
    service_host = os.environ['RAY_HEAD_SERVICE_HOST']
    service_port = os.environ['RAY_HEAD_SERVICE_PORT']
    ray.init(
        f'ray://{service_host}:{service_port}'
    )

use_distributed = False
out_dir =< '/path/to/output_folder'>

boston = load_boston()
x, y = boston.data, boston.target
df = pd.DataFrame(x, columns= boston.feature_names)

# make into dmatrix
if use_distributed:
    actors = 2
    ray_params = RayParams(
        num_actors= actors,
        cpus_per_actor = 2,
    )

    train_df_with_target = df.copy()
    train_df_with_target['target'] = y

    train_set = RayDMatrix(
        data=train_df_with_target,
        label = 'target'
        )
else:
    actors = 1

# set params and ray params
params = {
    'boosting_type': 'goss',
    'objective': 'regression',
    'metric': 'rmse',
    'n_estimators':100,
    'num_leaves': 6,
    'max_depth': 3,
    'learning_rate': tune.quniform(0.05,0.1, 0.01),
    'verbose': 1
}

#%% define function to count total leaves in model
def leaves_callback(env):
    model = env.model

    mod_dump = model.dump_model()
    tree_info = mod_dump['tree_info']
    num_leaves = 0
    num_iterations = 0
    for tree in tree_info:
        num_leaves += tree['num_leaves']
        num_iterations += 1

    session.report({'total_leaves': num_leaves,
                    "rmse_train":  env.evaluation_result_list[0][2],
                    'num_iterations': num_iterations})

# define trainable
def trainable(params):
    if use_distributed:
        mod_ray = RayLGBMRegressor(
            random_state=100,
            **params
        )

        mod_ray.fit(train_set,
            y='target',
            eval_set = [(train_set, 'target')],
            eval_names=["train"],
            ray_params=ray_params,
            callbacks = [leaves_callback])
    else:
        mod = lightgbm.LGBMRegressor(
            random_state=100,
            **params
        )

        mod.fit(X = x,
            y=y,
            eval_set = [(x, y)],
            eval_names=["train"],
            callbacks = [leaves_callback])

#%% RUN TUNING

resources = [{'CPU': 2.0} for x in range(actors+1)] + [{'CPU': 1.0}]

analysis = tune.Tuner(
    tune.with_resources(
            trainable,
            tune.PlacementGroupFactory(
                resources,
                strategy='PACK')
        ),
    tune_config=tune.TuneConfig(
        metric="rmse_train",
        mode= "min",
        search_alg=OptunaSearch(),
        num_samples=5),

    run_config= ray.air.RunConfig(local_dir=out_dir,
                                name = 'test_callback',
                                stop = {'total_leaves': 300}),
    param_space= params,
    )

results = analysis.fit()

If I toggle use_distributed to True

(_RemoteRayLightGBMActor pid=585, ip=<IP_ADDRESS>)   File "/opt/conda/lib/python3.9/site-packages/ray/air/session.py", line 61, in report
(_RemoteRayLightGBMActor pid=585, ip=<IP_ADDRESS>)     _get_session().report(metrics, checkpoint=checkpoint)
(_RemoteRayLightGBMActor pid=585, ip=<IP_ADDRESS>) AttributeError: 'NoneType' object has no attribute 'report'

If I toggle use_distributed to False, I get the expected result:

(TunerInternal pid=2096) +--------------------+------------+-----------------+-----------------+--------+------------------+----------------+--------------+------------------+
(TunerInternal pid=2096) | Trial name         | status     | loc             |   learning_rate |   iter |   total time (s) |   total_leaves |   rmse_train |   num_iterations |
(TunerInternal pid=2096) |--------------------+------------+-----------------+-----------------+--------+------------------+----------------+--------------+------------------|
(TunerInternal pid=2096) | trainable_a895fa72 | TERMINATED | <IP_ADDRESS>:2131  |            0.05 |     56 |         0.24444  |            300 |      3.44845 |               56 |
(TunerInternal pid=2096) | trainable_aa0be088 | TERMINATED | <IP_ADDRESS>:2131  |            0.1  |     61 |         0.296924 |            302 |      2.82896 |               61 |
(TunerInternal pid=2096) | trainable_aa3ab41c | TERMINATED | <IP_ADDRESS>:2131  |            0.08 |     60 |         0.354107 |            301 |      2.89081 |               60 |
(TunerInternal pid=2096) | trainable_aa6d4d32 | TERMINATED | <IP_ADDRESS>:749 |            0.07 |     59 |         0.310418 |            300 |      2.99355 |               59 |
(TunerInternal pid=2096) | trainable_aa89c7a0 | TERMINATED | <IP_ADDRESS>:2131  |            0.05 |     56 |         0.265122 |            300 |      3.44845 |               56 |
(TunerInternal pid=2096) +--------------------+------------+-----------------+-----------------+--------+------------------+----------------+--------------+------------------+

I managed to solve my particular issue by subclassing TuneReportCallback:
class CustomTuneReportCallback(TuneReportCallback):
    def __init__(self, metrics):
        super(CustomTuneReportCallback, self).__init__(metrics)

    def __call__(self, env: CallbackEnv) -> None:
            if not self.is_rank_0:
                return
            eval_result = self._get_eval_result(env)
            report_dict = self._get_report_dict(eval_result)

            model = env.model

            mod_dump = model.dump_model()
            tree_info = mod_dump['tree_info']
            num_leaves = 0
            num_iterations = 0
            for tree in tree_info:
                num_leaves += tree['num_leaves']
                num_iterations += 1
            report_dict.update({'total_leaves': num_leaves,
                    'rmse_train': env.evaluation_result_list[0][2],
                    'num_iterations': num_iterations})

            put_queue(lambda: tune.report(**report_dict))

Love it, that's the intended way to do it!


Issues with tofi on river and dual monitor setup

Using river, if I launch tofi while a window is open and focused on my first monitor, tofi spawns on the second monitor instead and I have to go on that monitor, click on it (even if focus should follow cursor so it shouldn't be necessary), and then interact with tofi.
If I haven't any open window on the first monitor it works just fine.
On my second monitor this problem doesn't happen, having open windows or not it's irrelevant, and it works even if I have an open window on my first monitor, but the second is focused.
So the problem happen only when tofi is launched while focusing a window in the first monitor.
That's weird. This is my config, maybe you can spot something wrong there.
anchor = center
width = 100%
height = 1440
horizontal = true
font-size = 20
prompt-text = "run: "
font = Tamzen Bold
outline-width = 0
border-width = 0
background-color = #000000
selection-background = #f1c40f
selection-color = #000
selection-padding = 10
input-color=#999
min-input-width = 200
result-spacing = 25
padding-top = 40%
padding-bottom = 0
padding-left = 100
padding-right = 100
margin-left = 0

hide-cursor=true
hint-font = false
text-cursor=true
text-cursor-color=#FFF
drun-launch = true

EDIT: Just tried without config. Same result, so I don't think the problem is there.

I'm having the problem exactly as originally described. Version 0.9.1.

This is a quick workaround for the issue:
diff --git a/src/main.c b/src/main.c
index e91838f..b2cd429 100644
--- a/src/main.c
+++ b/src/main.c
@@ -1576,7 +1576,7 @@ int main(int argc, char *argv[])
 	tofi.window.zwlr_layer_surface = zwlr_layer_shell_v1_get_layer_surface(
 			tofi.zwlr_layer_shell,
 			tofi.window.surface.wl_surface,
-			wl_output,
+			nullptr,
 			ZWLR_LAYER_SHELL_V1_LAYER_OVERLAY,
 			"launcher");
 	zwlr_layer_surface_v1_set_keyboard_interactivity(

Pending a fix, the kludge I've been using relies on setting the output configuration option to the currently focused monitor before executing Tofi. Here's my implementation for Sway:
First, add this line to the Tofi configuration:
output =

Then execute this command (jq needs to be installed on the system):
sed --in-place "s/output =.*/output = $(swaymsg --type get_outputs | jq '.[] | select(.focused).name')/" .config/tofi/config && tofi-run | xargs swaymsg exec --

Didn't work for me on hyprland with hyprctl dispatch instead of swaymsg

Are you executing the command before Tofi on each invocation? E.g.:
bindsym Mod4+D exec sed --in-place "s/output =.*/output = $(swaymsg --type get_outputs | jq '.[] | select(.focused).name')/" ~/.config/tofi/config && tofi-run | xargs swaymsg exec --


light effects not saved in scenes/automations

Version of the integration V2.3.0

Configuration

Device Name: Office Kallax
Firmware: 1.0.9 build 220727 rel.150045
Not sure what logs you refer to, HA logs are below.

Describe the bug
Trying to create an automation that will turn on the Tapo light strip that is on my ikea Kallax shelf, turning on isn't the problem, however when trying to use the effects of the light strip, it will not save and produces the below error, the options also does not indicate an effect has been chosen, the only way to know is to look at the light that switches to the effect.
Although the scene asks to set the lights to the desired setting, doing so does not prompt the user to save.
Debug log

Logger: homeassistant.components.automation.office_lights_20
Source: custom_components/tapo/light.py:169
Integration: Automation (documentation, issues)
First occurred: 8 July 2023 at 12:42:01 (26 occurrences)
Last logged: 22:14:04

Office lights 20: Error executing script. Unexpected error for call_service at pos 1: 'rainbow'
While executing automation automation.office_lights_20
Traceback (most recent call last):
  File "/usr/src/h
[home-assistant_tapo_2023-07-20T21-15-58.477Z.log](https://github.com/petretiandrea/home-assistant-tapo-p100/files/12114237/home-assistant_tapo_2023-07-20T21-15-58.477Z.log)
omeassistant/homeassistant/helpers/script.py", line 468, in _async_step
    await getattr(self, handler)()
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 703, in _async_call_service_step
    response_data = await self._async_run_long_action(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/script.py", line 665, in _async_run_long_action
    return long_task.result()
           ^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 1957, in async_call
    response_data = await coro
                    ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 1997, in _execute_service
    return await cast(
           ^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 235, in handle_service
    return await service.entity_service_call(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 845, in entity_service_call
    response_data = task.result()  # pop exception if have
                    ^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1192, in async_request_call
    return await coro
           ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 889, in _handle_entity_call
    result = await task
             ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/scene/__init__.py", line 114, in _async_activate
    await self.async_activate(**kwargs)
  File "/usr/src/homeassistant/homeassistant/components/homeassistant/scene.py", line 334, in async_activate
    await async_reproduce_state(
  File "/usr/src/homeassistant/homeassistant/helpers/state.py", line 115, in async_reproduce_state
    await asyncio.gather(
  File "/usr/src/homeassistant/homeassistant/helpers/state.py", line 109, in worker
    await platform.async_reproduce_states(
  File "/usr/src/homeassistant/homeassistant/components/light/reproduce_state.py", line 195, in async_reproduce_states
    await asyncio.gather(
  File "/usr/src/homeassistant/homeassistant/components/light/reproduce_state.py", line 182, in _async_reproduce_state
    await hass.services.async_call(
  File "/usr/src/homeassistant/homeassistant/core.py", line 1957, in async_call
    response_data = await coro
                    ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/core.py", line 1997, in _execute_service
    return await cast(
           ^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 235, in handle_service
    return await service.entity_service_call(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 845, in entity_service_call
    response_data = task.result()  # pop exception if have
                    ^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 1192, in async_request_call
    return await coro
           ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 889, in _handle_entity_call
    result = await task
             ^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/light/__init__.py", line 582, in async_handle_light_on_service
    await light.async_turn_on(**filter_turn_on_params(light, params))
  File "/config/custom_components/tapo/light.py", line 169, in async_turn_on
    self._effects[effect].to_effect()
    ~~~~~~~~~~~~~^^^^^^^^
KeyError: 'rainbow'

home-assistant_tapo_2023-07-20T21-15-58.477Z.log

I had exactly the same problem after recently upgrading, for me it turned out that the effect name needed to start with a capital letter.
So...
service: light.turn_on
data:
  effect: rainbow
target:
  entity_id: light.light_name

gave the error you're getting, and
service: light.turn_on
data:
  effect: Rainbow
target:
  entity_id: light.light_name

works as expected

My friend, thank you so much for taking the time to post this fix, that indeed corrects the problem.

From: darkmatter24 @.>
Sent: 20 July 2023 23:40
To: petretiandrea/home-assistant-tapo-p100 @.>
Cc: Steven Azari @.>; Author @.>
Subject: Re: [petretiandrea/home-assistant-tapo-p100] light effects not saved in scenes/automations (Issue #454)
I had exactly the same problem after recently upgrading, for me it turned out that the effect name needed to start with a capital letter.
So...
service: light.turn_on
data:
effect: rainbow
target:
entity_id: light.light_name
gave the error you're getting, and
service: light.turn_on
data:
effect: Rainbow
target:
entity_id: light.light_name
works as expected
—
Reply to this email directly, view it on GitHubhttps://github.com/petretiandrea/home-assistant-tapo-p100/issues/454#issuecomment-1644719388, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAEK4EQVCCGD5I72SRN77VLXRGXW7ANCNFSM6AAAAAA2SAFED4.
You are receiving this because you authored the thread.Message ID: @.***>


Key point Matching enhancement

The current key point matching is really weak in terms of robustness.
The current strategy is to use SIFT for describing and kNN for matching.
Which often leads to false matching.
There are several newer strategies to improve those matching such as FGINN-Strategies (see: Matching strategies comparsion

/cib


Impossible to copy the error report ID

EDIT Corona-Warn-App Open Source Team
On Android you can already long press the ID and copy&paste it like normal text.
Or you can tap the entry to copy it including message, dates and ID.

Current Implementation
You cannot copy the ID of an error report.
Suggested Enhancement
Make it possible to copy the ID. A long tap on the ID should bring up "Copy Report ID" and the ID gets saved to your clipboard.
Expected Benefits
Easier to write the ID here since you can just copy paste it and don't have to share a picture, etc.

Internal Tracking ID: EXPOSUREAPP-7420

@Ein-Tim Thanks. Let's consider this as a bug, therefore moved to documentation repository.

Internal Tracking ID: EXPOSUREAPP-7420
Corona-Warn-App Open Source Team

@dsarkar / @Ein-Tim
Would you consider making this more general?
Ease of use of error report ID

error report ID should be displayed immediately after submitting report
error report ID should be displayed in larger readable text (on Android it is quite small)
error report ID should be able to be copied

Good morning @MikeMcC399!
We have another internal ticket:

error report ID should be displayed immediately after submitting report

This is covered in Internal Tracking ID: EXPOSUREAPP-7377 ID hard to find

Expected result:

A notification after sending the error report that it was successfully submitted and show the corresponding ID (and where to find it later)
List error reports in a more prominent way

error report ID should be displayed in larger readable text (on Android it is quite small)

I will add this also to this ticket.
Thnaks

@MikeMcC399 @Ein-Tim FYI There is another Ticket:  Internal Tracking ID: EXPOSUREAPP-7429: show latest error reports on the top of the list

By the way: on Android it seems to be possible to copy the id with long press (Android 6, LG G4, CWA 2.4.3). It copies a bit more than necessary, but it least it worked for me once.

Quoting @d4rken:

On Android you can already long press the ID and copy&paste it like normal text.

@vaubaehn Ah sorry! I didn't see your comment! You already posted the long-press solution.

Then this should probably be moved to the iOS repo.

By the way: on Android it seems to be possible to copy the id with long press (Android 6, LG G4, CWA 2.4.3). It copies a bit more than necessary, but at least it worked for me once.

You can long press the ID to get normal text selection, or tap the whole entry and all of it's text will be copied to your clipboard.

This has become an iOS only issue and should be moved to the iOS repository.

Although the bug reported in the OP of this issue has never been fixed under iOS, I'm closing this issue now as the CWA project went into ramp-down mode and I therefore don't expect this issue to be fixed anymore.


[RIP-10] modify test case of BrokerConsumeStatsSubCommand

What is the purpose of the change
modify test case of BrokerConsumeStatsSubCommanTest.java
Brief changelog
1.modify the initialization method of BrokerConsumeStatsSubCommad#execute#DefaultMQAdminExt
2.modify test case of BrokerConsumeStatsSubCommanTest.java
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

LGTM

LGTM

LGTM


Add sofa version plugin.

Pull Request Test Coverage Report for Build 393

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.5%) to 71.443%

Totals

Change from base Build 381:
0.5%

Covered Lines:
1461

Relevant Lines:
2045

💛  - Coveralls


BUG:Improve Footer Layout, and Align Subscribe Button and Search Bar …

Fix Footer Layout, Align Subscribe Button and Search Bar, and Add Icons to "Follow Us" Section
Related Issue
None
Fixes: #1284
Description
This pull request addresses the issue titled "Improve Footer Layout, and Align Subscribe Button and Search Bar with UI." The current design of the contributors page exhibited several UI inconsistencies, which have now been resolved.
Changes Made:

Footer Adjustments:

Improved text sizing and spacing to ensure consistency with other elements on the page.
Enhanced the visual appearance and alignment of footer components for a more cohesive look.

Subscribe Button and Search Bar Adjustments:

Aligned the subscribe button and search bar with the overall page layout.
Ensured consistent spacing and padding for these elements, improving responsiveness across different screen sizes.

Follow Us Section:

Added social media icons to the "Follow Us" section, enhancing visibility and accessibility for users to connect with us on various platforms.

Expected Behavior:

The footer now features consistent text sizing, spacing, and alignment with other page elements.
The subscribe button and search bar are aligned with the page layout, maintaining uniformity and improving the overall user experience.
The "Follow Us" section displays the appropriate icons, contributing to a more complete and visually appealing footer.

Steps to Reproduce:

Navigate to the contributors page.
Observe the improved footer layout and alignment with other elements.
Check the placement and alignment of the subscribe button and the search bar.
Verify the presence of social media icons in the "Follow Us" section.

Type of PR

[X] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)

Checklist:

[X] I have made this change from my own.
[ ] I have taken help from some online resources.
[X] My code follows the style guidelines of this project.
[X] I have performed a self-review of my own code.
[X] I have commented my code, particularly in hard-to-understand areas.
[X] I have made corresponding changes to the documentation.
[X] My changes generate no new warnings.
[X] I have tested the changes thoroughly before submitting this pull request.
[X] I have provided relevant issue numbers and screenshots after making the changes.

@amanreddy77 Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. Exclusive swag awaits for those who go the extra mile!
Great contribution ! 🎉


move waitAllBuildFinish() out of JoinBlock

What problem does this PR solve?
Issue Number: close #6791
Problem Summary:
What is changed and how it works?
move waitAllBulidFinish() out of JoinBlock() and init active_build_concurrency in join init.
Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

I think this can be closed after #6650


[Docs]The updation of shields is needed in README.md

Current State:
Small updation of shields in README.md

Desired State:
This is how it should look like

updation should be done in this README.md by keeping the shield style uniform to following meshery-istio's README.md :
https://github.com/meshery/meshery-istio/blob/721b78783182e65145cefde64d905dab3ca20ba1/README.md?plain=1#L13

Contributor Resources

Meshery documentation site
Meshery documentation source
Instructions for contributing to documentation

@Swapnil-Bhabal I would like to work on this.

@leecalcote We can close this issue now. Because I have solved this issue in another pr which already has been merged.


Fix JENKINS-46046

Proper handling of existing reports for relative comparisons (JENKINS-46046)

Codecov Report

Merging #127 into master will increase coverage by 3.25%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   64.26%   67.52%   +3.25%
==========================================
  Files          44       44
  Lines        3663     3667       +4
  Branches      625      625
==========================================
+ Hits         2354     2476     +122
+ Misses       1132      986     -146
- Partials      177      205      +28

Impacted Files
Coverage Δ

...dson/plugins/performance/PerformancePublisher.java
85.59% <100%> (+19.14%)
:arrow_up:

...ns/performance/actions/PerformanceBuildAction.java
81.25% <0%> (+3.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ef946b...b1c1d61. Read the comment docs.

Thanks for your contribution.
Having unit test checking this feature would help to keep it working in the future.


Bump gtfs-lib for bug fixes

 Issue by landonreed
Friday Nov 30, 2018 at 22:28 GMT
Originally opened as https://github.com/catalogueglobal/datatools-server/pull/129

Bump to 4.1.1 for bug fixes.

landonreed included the following code: https://github.com/catalogueglobal/datatools-server/pull/129/commits

 Comment by codecov-io
Friday Nov 30, 2018 at 22:29 GMT

Codecov Report

Merging #129 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##               dev    #129   +/-   ##
=======================================
  Coverage     5.12%   5.12%
  Complexity      91      91
=======================================
  Files          129     129
  Lines         6776    6776
  Branches       884     884
=======================================
  Hits           347     347
  Misses        6404    6404
  Partials        25      25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e47cec...098c4fa. Read the comment docs.


Implement pagination for the ChatApi.Conversations.list_conversations_by_account/2 method

Problem
We currently fetch ALL conversation records when we hit the ChatApi.Conversations.list_conversations_by_account/2 method (i.e. we set no limit or offset in our query, nor do we have cursors or anything like that)
This will not scale very well as more and more data gets added.
Solution
To start off, let's do the following:

Implement another version of ChatApi.Conversations.list_conversations_by_account(account_id, filters) that paginates the response, ideally using cursors

Here's where the method lives in the code: https://github.com/papercups-io/papercups/blob/master/lib/chat_api/conversations.ex#L24
Possible library for cursor approach: https://github.com/duffelhq/paginator

(Note: I have a very minimal understanding of how to use cursors, so I may be wrong that this is the best approach... feel free to push back!)
This new method should just be called something like ChatApi.Conversations.list_conversations_by_account(account_id, filters, pagination_options), and should only return, let's say, 50 records at a time

Testing
For the sake of this ticket, DO NOT use this new method in the GET /api/conversations endpoint. We just want to set up the method itself, and write some tests showcasing how it works.
Questions, or need help getting started?
Feel free to ask below, or ping us on Slack :)
(You can also check out our CONTRIBUTING.md)

Hi
I'll take this one)

sounds good @psolvy! I'll assign you for now :)

Hi  @psolvy, @reichert621
If we want to use prams such as limit offset  eg. %{page_size: 5, page_number: 10} we cant use cursor based pagination.
I have opened a pr which uses scrivener (offset based pagination).
also this is related with #332

@flmel since conversations will be fetched as the user scrolls (or with e.g. a "Load more" button), rather than in a table with pages, i think it should be fine to use cursor-based pagination here 👍

@flmel since conversations will be fetched as the user scrolls (or with e.g. a "Load more" button), rather than in a table with pages, i think it should be fine to use cursor-based pagination here 👍

ок

hey @psolvy! any updates on this?

HI :wave: If this is up for grabs, I'd like to work on this! Thanks

hey @fmterrorf! let me check in with @flmel to see if he's still interested in working on this, i think he may have had some questions that weren't addressed in the issue description

ok great! assigning you for now 🚀

Conversations should be sorted by most recent message -- not sure how tricky this will be given it may require some join queries on the messages table, but maybe we'll just have to add a new field for last_message_sent_at or something thinking

Yeah this one is tricky. I've opened a draft PR for this, but i dont feel too good about it :sweat_smile:

oops @fmterrorf just saw this!
i wrote this in your PR just now:

looks great! i need to take a little more time to review but wanted to get your thoughts on something... after working on this, do you think it would make our lives a lot easier to just add a new field to conversations that holds the last_message_sent_at/last_activity_at, and make sure to update that whenever a message is created?

it seems like it might make sense to go that route instead... what do you think?

Yeah i think that's the way to go. It'll make pagination & ordering better

sounds good!

Forgot to add fixes: #451 on my last PR :sweat_smile: but we could probably close this issue


CodeQL Alert #1 - Security rule js/incomplete-sanitization triggered

Tool: CodeQL (2.14.3)
Rule: js/incomplete-sanitization
Severity: warning (Security level: high)
Description: Incomplete string escaping or encoding
Instance reference: refs/heads/main
Instance state: open
Location: dist/index.js @ l9666:c12-l9666:c28
Message: This replaces only the first occurrence of '*'.
CodeQL Alert Link

Related Trello card: https://trello.com/c/nKchMnJk/25-niaid-monarch-actions-switch-account-codeql-alert-1-security-rule-js-incomplete-sanitization-triggered

Related Trello card: https://trello.com/c/TGUJtbVm/32-niaid-monarch-actions-switch-account-codeql-alert-1-security-rule-js-incomplete-sanitization-triggered


How to set Hardware Concurrency from the Kameleo API?

What would be the proper code syntax form to set the Hardware Concurrency for a profile from the Kameleo API?
Also, could your provide some example code?

Here is an example that you can use to set the Hardware Concurrency for a profile through the API:
create_profile_request = BuilderForCreateProfile \
  .for_base_profile(base_profiles[0].id) \
  .set_recommended_defaults() \
  .set_hardware_concurrency('manual', 8) \ # Valid values: 1, 2, 4, 8, 12, 16.
  .build()
profile = client.create_profile(body=create_profile_request)

These answers are provided from the Kameleo Set Hardware Concurrency from API article.


Tutorial Proof Read Batch #1

Please see each individual commit for explanation. Feel free to cherry pick

@marcelldls warning - I have squash merged this. Make sure you rebase or start a new branch before continuing in marcell-tutorial-patch.

@gilesknap A sensible thing to do. Thanks will start a new branch


metric cpu cost per power

rate metrics for decision making:

cpu cost per power (track all power-related cpu usage + all power production)
cpu cost per control point
cpu cost per mineral mined
cpu cost per energy harvested
cpu cost per resource mined

Not planned at this time-


Weird autocomplete behavior when "editor.autoClosingQuotes": "never"

Version: 1.69.0-insider (Universal)
Commit: f1abeeab7e51df997bbb0f1ff900321ad2f21ac0
Date: 2022-06-30T05:17:23.222Z
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 21.5.0
Testing https://github.com/microsoft/vscode/issues/147006
I noticed that I ended up a weird state that looks like this:

In this step

}, are part of the string literal, which then is replaced by the value from the completion.
You would have to press Shift when selecting the completion, to insert the completion instead.
Not sure how we can improve this. Any reason why to turn off autoClosingQuotes ?

Ah I see. Oh no I only tried that setting for the issue I was verifying but I was confused why my closing brace disappeared

I'm closing the issue then.


Debezium JDBC storage PR fixes

https://issues.redhat.com/browse/DBZ-6433

Make DELETE SQL configurable.
Change insert query to include column names.

https://github.com/debezium/debezium/pull/4639

Both the PRs were merged.


updates to get wheel decoding working on cluster

explicitly define number of bins for multi-bin decoding targets
update imposter session data release
improvements to post-processing functions (format_outputs_stage_.py)

all tests (except that one problematic widefield one) are still passing!

Thanks! I'll make the changes then let you know.