Page designed fixed

@v-hearya,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

patterns-practices/reference/backgroundeventsubscription-tpayload-constructor-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/backgroundeventsubscription-tpayload-methods-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/backgroundeventsubscription-tpayload-properties-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/bindablebase-constructor-mspp-mvvm.md
:white_check_mark:Succeeded

patterns-practices/reference/bindablebase-events-mspp-mvvm.md
:white_check_mark:Succeeded

patterns-practices/reference/bindablebase-onpropertychanged-method-mspp-mvvm.md
:white_check_mark:Succeeded

patterns-practices/reference/bindablebase-onpropertychanged-method-string-mspp-mvvm.md
:white_check_mark:Succeeded

patterns-practices/reference/clearchildviewsregionbehavior-clearchildviewsproperty-field-mspp-regions-behaviors.md
:white_check_mark:Succeeded

patterns-practices/reference/clearchildviewsregionbehavior-fields-mspp-regions-behaviors.md
:white_check_mark:Succeeded

patterns-practices/reference/clearchildviewsregionbehavior-onattach-method-mspp-regions-behaviors.md
:white_check_mark:Succeeded

patterns-practices/reference/commandbehaviorbase-t-class-mspp-interactivity.md
:white_check_mark:Succeeded

patterns-practices/reference/commandbehaviorbase-t-command-property-mspp-interactivity.md
:white_check_mark:Succeeded

patterns-practices/reference/commandbehaviorbase-t-commandparameter-property-mspp-interactivity.md
:white_check_mark:Succeeded

patterns-practices/reference/compositepresentationevent-tpayload-subscribe-method-action-tpayload-threadoption-boolean-mspp-events.md
:white_check_mark:Succeeded

patterns-practices/reference/compositepresentationevent-tpayload-subscribe-method-action-tpayload-threadoption-mspp-events.md
:white_check_mark:Succeeded

patterns-practices/reference/dataeventargs-tdata-constructor-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/dataeventargs-tdata-properties-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/defaultconfirmationwindow-class-mspp-interactivity-defaultpopupwindows.md
:white_check_mark:Succeeded

patterns-practices/reference/defaultconfirmationwindow-events-mspp-interactivity-defaultpopupwindows.md
:white_check_mark:Succeeded

patterns-practices/reference/defaultconfirmationwindow-properties-mspp-interactivity-defaultpopupwindows.md
:white_check_mark:Succeeded

patterns-practices/reference/defaultnotificationwindow-class-mspp-interactivity-defaultpopupwindows.md
:white_check_mark:Succeeded

patterns-practices/reference/delegatecommand-fromasynchandler-method-mspp-commands.md
:white_check_mark:Succeeded

patterns-practices/reference/delegatecommand-t-fields-mspp-commands.md
:white_check_mark:Succeeded

patterns-practices/reference/delegatecommand-t-fromasynchandler-method-mspp-commands.md
:white_check_mark:Succeeded

patterns-practices/reference/delegatereference-class-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/delegatereference-properties-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/dispatchereventsubscription-tpayload-constructor-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/dispatchereventsubscription-tpayload-properties-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/eventaggregator-getevent-teventtype-method-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/eventbase-internalsubscribe-method-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/eventsubscription-tpayload-class-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/eventsubscription-tpayload-constructor-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/eventsubscription-tpayload-getexecutionstrategy-method-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/eventsubscription-tpayload-subscriptiontoken-property-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/executemthd-field.md
:white_check_mark:Succeeded

patterns-practices/reference/iconfirmation-confirmed-property-mspp-interactivity-interactionrequest.md
:white_check_mark:Succeeded

patterns-practices/reference/iconfirmation-interface-mspp-interactivity-interactionrequest.md
:white_check_mark:Succeeded

patterns-practices/reference/idelegatereference-properties-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/ieventaggregator-getevent-teventtype-method-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/ieventaggregator-interface-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/ieventaggregator-methods-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/ieventsubscription-getexecutionstrategy-method-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/ieventsubscription-interface-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/ieventsubscription-properties-mspp-pubsubevents.md
:white_check_mark:Succeeded

patterns-practices/reference/iinteractionrequestaware-finishinteraction-property-mspp-interactivity-interactionrequest.md
:white_check_mark:Succeeded

patterns-practices/reference/iinteractionrequestaware-interface-mspp-interactivity-interactionrequest.md
:white_check_mark:Succeeded

patterns-practices/reference/images/public-event.gif
:white_check_mark:Succeeded

patterns-practices/reference/images/public-field.gif
:white_check_mark:Succeeded

patterns-practices/reference/images/static-member.gif
:white_check_mark:Succeeded

patterns-practices/reference/inavigateasync-requestnavigate-method-mspp-regions.md
:white_check_mark:Succeeded

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Introductory CNN Model: MNIST Digits TypeError: The value of a feed cannot be a tf.Tensor object. Acceptable feed values include Python scalars, strings, lists, numpy ndarrays, or TensorHandles.

The cause of this error is you are feeding two different type of data: tensor and numpy array. Try to either conver the y label to tensor or convert ran_x to np.array (by np.expand.dims)

Thanks for noticing - I'll update this in the coming few months for the book v2.

This should be fixed. Please repull and try again. If you still have an issue, feel free to reopen and also to let me know your TF version, Python version, and OS.  Thanks!


Check variable value before update

Why does this PR exist?
Closes https://github.com/tokens-studio/figma-plugin/issues/3169
Variables weren't checking if they are supposed to update, they just did.
What does this pull request do?
With this change we're making it so that we only update the variable value when the variable value differs from the new value.
Testing this change
Create a few variables, hit Publish in Figma, and then hit export again. In the production version you'd now get another blue dot on the library icon, in this version you don't.
Additional Notes (if any)
https://github.com/user-attachments/assets/5549d755-8c2c-4190-aa9d-476aec6970ba

@keeganedwin were you able to test this?

@six7 tested the and seems to be working as showed in the video.


Feature request :  Allow for a shorter period between scheduled backups.

Is your feature request related to a problem? Please describe.
The minimum period between backups is 15 minutes. I'm trying to run a incremental backup every 5 minutes.
Describe the solution you'd like
Allow for a shorter period between scheduled backups.

reopening because the CF workflow is erroring. you can still get jars from here


Smp params xml

restore default to build SMPQ
demo SQLite pragmas
added 'lock' SQLite pragma to SMP (very slight performance boost)

It's all good.


Bubble Popping Game

Project title
Bubble Popping Game
Project Description
It is a bubble popping game based on your perfomance your score will be added.
Stack:
And in order to tick the check box just but x inside them for example - [x] like this. Please delete options that are not relevant.

[x] Html
[x] CSS
[x] JavaScript
[] ReactJS

I am a GSSoC Contributor.Please assign me this issue

/assign


added de10lite board file

Hello,
I added the board definition of the popular de10-lite to the repository. I tested and it works with the blinky example. Please review.
Regards,
Taiwo

Thanks!


Cannot find 'AKMIDITrackView' in scope (In SwiftUI)

I'm trying to use AKMIDITrackView in Swiftui but AKMIDITrackView is not available. I get the error: Cannot find 'AKMIDITrackView' in scope. I've added AudioKit as a package dependency.
My code:
import SwiftUI
import AudioKit
struct ContentView: View {
    var body: some View {
        AKMIDITrackView(frame: CGRect(frame: CGRect(x:0, y:0, width:1000, height:300)))
            .swiftUIView(layout: .intrinsic)
    }
}

Also I can not find any documentation or code with a name containing "AKMIDITrackView" any where on the internet. Please help.

The documentation can be found here: https://github.com/AudioKit/AudioKitUI/wiki/MIDITrackView

Thanks. Fixed it now!
This works:
import SwiftUI
import AudioKit
import AudioKitUI
import SwiftUIKitView

struct ContentView: View {
    var body: some View {
        MIDITrackView(frame: CGRect(x:0, y:0, width:1000, height:300))
            .swiftUIView(layout: .intrinsic)
    }
}

Yes. Found it:
    public convenience init(frame: CGRect, midiFile: URL!,
                            trackNumber: Int,
                            sampler: MIDISampler,
                            sequencer: AppleSequencer)

But I get: Extra argument 'midiFile' in call when I try this:
        MIDITrackView(frame: CGRect(x:0, y:0, width:1000, height:300), midiFile: 'blues-drum-track')
            .swiftUIView(layout: .intrinsic)

Interesting... It seems that midiFile is expected to be of type URL!. Try using URL instead of String as the parameter value type.

Hm. It didn't seem to help:
        MIDITrackView(frame: CGRect(x:0, y:0, width:1000, height:300), midiFile: URL(string: "blues-drum-track"))
            .swiftUIView(layout: .intrinsic)

Also I get the same error when trying this:
        MIDITrackView(frame: CGRect(x:0, y:0, width:1000, height:300), trackNumber: 10)
            .swiftUIView(layout: .intrinsic)

Wow! That's a great idea! Looking forward to try it 😊

Just a warning, it may take me a couple days or so since I'm in school and cramming for a test, but I will try to finish it ASAP. In the meantime, please feel free to keep exploring with the code you have and try to get it working. Let me know if you do :)!

I didn't want to keep you waiting, so I tried to come up with a quick fix. I believe to resolve the error you described above, you need to fill in all of the parameters in the MIDITrackView's initializer like this:
//
//  ContentView.swift
//  MIDITrackTest
//
//  Created by Evan Murray on 10/17/21.
//

import SwiftUI
import AudioKitUI
import SwiftUIKitView
import AudioKitEX
import AudioKit

struct ContentView: View {
    let sampler = MIDISampler()
    let sequencer = AppleSequencer()
    var body: some View {
        Text("Hello, world!")
            .padding()
        MIDITrackView(frame: CGRect(x: 0, y: 0, width: 400, height: 100), midiFile: Bundle.main.url(forResource: "LVB_Sonate_02no1_1", withExtension: "mid")!, trackNumber: 0, sampler: sampler, sequencer: sequencer)
            .swiftUIView(layout: .intrinsic)
    }
}

struct ContentView_Previews: PreviewProvider {
    static var previews: some View {
        ContentView()
    }
}

The MIDI file I used can be found here: https://www.mutopiaproject.org/cgibin/make-table.cgi?collection=beetson&preview=1
This is what the app looked like:

:
Now the challenge will be figuring out how to play the MIDI track. I know there's a play() method, but I'm working on figuring out how to use it in swift ui.

Do we even need this repo anymore then?

Do we even need this repo anymore then?

No, it would probably be better to move this inside the Cookbook.

I didn't want to keep you waiting, so I tried to come up with a quick fix. I believe to resolve the error you described above, you need to fill in all of the parameters in the MIDITrackView's initializer like this:
//
//  ContentView.swift
//  MIDITrackTest
//
//  Created by Evan Murray on 10/17/21.
//

import SwiftUI
import AudioKitUI
import SwiftUIKitView
import AudioKitEX
import AudioKit

struct ContentView: View {
    let sampler = MIDISampler()
    let sequencer = AppleSequencer()
    var body: some View {
        Text("Hello, world!")
            .padding()
        MIDITrackView(frame: CGRect(x: 0, y: 0, width: 400, height: 100), midiFile: Bundle.main.url(forResource: "LVB_Sonate_02no1_1", withExtension: "mid")!, trackNumber: 0, sampler: sampler, sequencer: sequencer)
            .swiftUIView(layout: .intrinsic)
    }
}

struct ContentView_Previews: PreviewProvider {
    static var previews: some View {
        ContentView()
    }
}

The MIDI file I used can be found here: https://www.mutopiaproject.org/cgibin/make-table.cgi?collection=beetson&preview=1
This is what the app looked like:  :
Now the challenge will be figuring out how to play the MIDI track. I know there's a play() method, but I'm working on figuring out how to use it in swift ui.

Thanks for this. It finally got me up and running!
It seems to only work with midi type 0 though. Also it does not show meta events like markers and text and so on. I think this view must be used togheter with Sequencer in order for anything to be played. I'm experimenting with it now.

@kjetilge I made MIDITrackView compatible with SwiftUI in AudioKit/AudioKitUI#40. Once that's merged, I'll add an example to AudioKit/Cookbook which you can look at. It's much easier to use now, and no need for the SwiftUI UIView wrapper anymore 😃!

Alright, the new MIDITrackView is Cookbook! Should be ready by the next release, but you can also checkout the develop branch to experiment with it in the meantime :) !

Should this repoo even exist anymore?

Should this repo even exist anymore?

Nope, I think it's safe to delete it 🙂


docs(plugins): add ExtendedAPIPlugin doc

add ExtendedAPIPlugin doc

Hi @shaodahong
Can you please reference pull request introducing this plugin in webpack's codebase? So we'd have context for a proper review

@EugeneHlushko https://github.com/webpack/webpack/blob/e16d05679ea70f606121fc026d605919a028bed6/lib/ExtendedAPIPlugin.js#L42

@EugeneHlushko thank you, I wrong expression it, and trouble you

I think its good @shaodahong
Lets ask @montogeek for another look

Thanks!


Fix Ansible 2.8 warning

Fix for #217 (although I wonder if later Ansible modules such as sysctl will allow a real integer here? Time will tell).
See https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_2.8.html#module-option-conversion-to-string

Thanks @DavidWittman!


Allow deferred connection initialization

Implements https://github.com/lettuce-io/lettuce-core/issues/1129

ewrwrweqeewq

wqewqeeqwewqewq

Closing as per comment in the associated ticket #1129. Thanks for your effort, but we've decided to not support initially failing connections.


Water acts as a portal to a flat planet on planets where water can be placed.

Version of Advanced Rocketry
1.12.2-2.0.0-250
Have you verified this is an issue in the latest unstable build
Yes
Version of LibVulpes
1.12.2-0.4.2-83
Version of Minecraft
1.12.2
I came across this issue in survival. Any time I am on a planet with water, and I accidentally get in the water, I seem to be teleported to this other dimension. It looks like a planet. It is breathable, superflat with grass blocks and a few trees, plus a few lakes. The entire layer below the surface seems to be water, and you can see where sand has fallen down to the bedrock level. If one tries to escape this dimension through the water, you are teleported back to the same place in that same world. After taking off from a station to the destination planet, I landed in water and was teleported instantly to this dimension, and am unable to return. Teleporting back to the planet's ID usually causes an extreme amount of lag as it registers being teleported, then being submerged in water, teleporting you back to the flat world. These pictures are from a creative world where I tested the issue again.

This is definitively another mod. Please test to find which one it is.

Not AR, no response. Closing.


Exception after IndirectClient.getRedirectAction amount of params changed.

Hi,
After updating pac4j-play this week it seems there is some sort of reflection error. This might be due to the changes of isAjax parameter. The IndirectClient.getRedirectAction function changed from 3 to 2 parameters for pac4j-play. My guess is that the pac4j core is trying to invoke the function with 3 parameters via reflection and is unable to find it. See the stack trace below.
java.lang.NoSuchMethodError: org.pac4j.core.client.IndirectClient.getRedirectAction(Lorg/pac4j/core/context/WebContext;ZZ)Lorg/pac4j/core/client/RedirectAction;
	at org.pac4j.play.java.RequiresAuthenticationAction.redirectToIdentityProvider(RequiresAuthenticationAction.java:197)
	at org.pac4j.play.java.RequiresAuthenticationAction$1.lambda$apply$1(RequiresAuthenticationAction.java:168)
	at org.pac4j.play.java.RequiresAuthenticationAction$1$$Lambda$48/1462577183.apply(Unknown Source)
	at play.core.j.FPromiseHelper$$anonfun$promise$2.apply(FPromiseHelper.scala:36)
	at scala.concurrent.impl.Future$PromiseCompletingRunnable.liftedTree1$1(Future.scala:24)
	at scala.concurrent.impl.Future$PromiseCompletingRunnable.run(Future.scala:24)
	at play.core.j.HttpExecutionContext$$anon$2.run(HttpExecutionContext.scala:40)
	at akka.dispatch.TaskInvocation.run(AbstractDispatcher.scala:40)
	at akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(AbstractDispatcher.scala:397)
	at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
	at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
	at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
	at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)

You're right, things have changed in pac4j v1.8: the isAjax parameter has been removed in favor of an automatic detection of the AJAX nature of an HTTP request.
But it should work without any error using play-pac4j v2.0. Can you elaborate a little more on your environment?

Hi Leleuj,
Thanks for your reply.
Currently we are using Play framework 2.4.2 JAVA.
See the sbt below for the used deps for pac4j.
libraryDependencies ++= Seq(
  "org.pac4j" % "play-pac4j-java" % "2.0.0-SNAPSHOT",
  "org.pac4j" % "pac4j-http" % "1.8.0-SNAPSHOT",
  ("org.pac4j" % "pac4j-cas" % "1.8.0-SNAPSHOT").exclude("org.opensaml", "opensaml"),
  "org.pac4j" % "pac4j-openid" % "1.8.0-SNAPSHOT",
  "org.pac4j" % "pac4j-oauth" % "1.8.0-SNAPSHOT",
  "org.pac4j" % "pac4j-saml" % "1.8.0-SNAPSHOT",
  "org.pac4j" % "pac4j-oidc" % "1.8.0-SNAPSHOT",
  "org.pac4j" % "pac4j-jwt" % "1.8.0-SNAPSHOT",
  "org.pac4j" % "pac4j-ldap" % "1.8.0-SNAPSHOT",
  "org.pac4j" % "pac4j-sql" % "1.8.0-SNAPSHOT",
  "org.pac4j" % "pac4j-mongo" % "1.8.0-SNAPSHOT"
)

I just tested the https://github.com/pac4j/play-pac4j-java-demo and I don't have the problem. Are you sure you have the latest dependencies?

I have successfully ran the demo app. I think it's a dependency caching conflict at my local machine. When I browse to the pac4j-java 2.0 jar in IntelliJ there is still an reference to isAjax in the method RequiresAuthenticationAction.redirectToIdentityProvider.
    protected Result redirectToIdentityProvider(final Client client, final PlayWebContext context, final boolean isAjax) {
        try {
            final RedirectAction action = ((IndirectClient) client).getRedirectAction(context, true, isAjax);
            logger.debug("redirectAction: {}", action);
            return httpActionHandler.handleRedirect(action);
        } catch (final RequiresHttpAction e) {
            return httpActionHandler.handle(e.getCode(), context);
        }
    }

When browsing in this repo I see you have removed this parameter. I already removed all Ivy2 cache and regenerated the idea files. Still I got the wrong dependencies. Strange thing is; my colleague has exactly the same problem. Any ideas?

I know. The latest build on play-pac4j has failed. It works locally for me as I have built the source code.
I restarted the build, it should be ok in a few minutes.

That makes sense. Thanks Leleuj for your quick response and actions.
Do you have an public CI server so I can check if the build was successful?

Yes: https://travis-ci.org/pac4j/play-pac4j. Currently in progress and very slow...

Build passed.

Thanks Leleuj. I'm able to compile again :).


App router

with App router and page router, this causes a large number of TS errors in my pages, Can we add this so it can work in the app router instead?

This might be related to #53.


Use tenant domain instead of siteUrl in /shares api in ODSP driver

Description
Task Link
To load a Fluid container, host/app provides a URL which is used to talk to service to load the container. That URL can be a share link which host/app specifies explicitly to Fluid that the URL is a share link.
Fluid then uses that link to fetch the snapshot for the container. User sometimes don’t have permissions initially, so to save COGS, Fluid supply this share link in body of trees latest call to the service, so that in 1 network call, we can do the redeem and also fetch the snapshot. Sometimes this redeem on service side fails (in case it is first time sharing with that user), then the service throws on the trees latest call. Fluid catches this exception and determines/guess if this is because of redeem failure at service side and then fallback to doing redeem by itself using the /shares API. Once the redeem fails even in /shares API, the container load fails.
In this issue, for outlook Win32 the /shares API (Documentation link for API: Link) call is failing because of the length limitation on the API.  There are 2 ways to call the /shares API(for Fluid use),
Method 1: site-url/_api/v2.0/shares/{shareID}
This has length limitation of about 400 characters.
Method 2: tenant-domain/_api/v2.0/shares/{shareID}
Then the length limitation is about 2048 characters.
where this, share ID is generated by encoding the share link supplied by the app in the above load request. So, encoding longer URL will give longer shareID.
Tenant-domain can be extracted from site-url by doing:
Const tenant-domain = new URL(site-url).origin
This issue occurred for Outlook win 32, because MDO team started adding some, additional long query params to the share link.
So, we are switching to use Method 1 instead of Method 2.

Method 1: /_api/v2.0/shares/{shareID}
Method 2: /_api/v2.0/shares/{shareID}

I do not see any difference :)

Method 1: /_api/v2.0/shares/{shareID}
Method 2: /_api/v2.0/shares/{shareID}

I do not see any difference :)

Haha. It was in < > which made them disappear.

@jatgarg I just realized that the tests you added don't use real ODSP service. We should add tests that use the real service with a long URL that has these extra long query params (just less than 2048 maybe) and ensure they work. This way we will know if they start failing for some reason (say a bug in the shares API service).


require-instance==false at object-creation- and attribute-value-changed-notification manually corrected

Currently, shared associations in UML get translated into leafref with require-instance==false as a standard.
This is not correct for a subset of cases.
Defining the value of the require-instance statement in YANG should be made available in UML.
This Problem has already been raised in Synchronization Issue#16.
This issue is just for documenting that the VlanInterface model is also affected.
In meantime, the require-instance==false statements have been manually changed to true for the following attributes in the YANG:

object-creation-notification :: object-id-ref
attribute-value-changed-notification :: object-id-ref

Proposal to the 5Gxhaul call on 5th of July 2023:
The shared associations between the object-creation-notification/attribute-value-changed-notification and the LTP (represented also by _objectIdRef attributes) shall be marked with Stereotype "LifecycleAggregate" for triggering the UML2YANG tool to add a required-instance = true statement to the leaf-ref in YANG.

Notifications have been removed from the modelings.


Unable to Convert Html to PDF in AngularJs

I am using the following code in my Angular controller:
             var pdf = new jsPDF('p', 'pt', 'letter');

            source = $('#exportable')[0];

            specialElementHandlers = {
    '#bypassme': function (element, renderer) {
        return true
    }
};
margins = {
            top: 5,
                 bottom: 5,
                 left: 5,
                 width: 522
};

    pdf.fromHTML(
    source,
    margins.left,
    margins.top, {
        'width': margins.width,
    'elementHandlers': specialElementHandlers
},

function (dispose) {

pdf.save('Test.pdf');
}, margins);

This is my HTML:

                            Scoring Set

                                {{::scoredetails.vchScoringSetName}}

                            Total Score
                            Max Score
                            Rank
                            Overridden

                            {{scoredetails.intNumericalScore}}
                            {{scoredetails.intMaxPossibleScore}}
                            {{scoredetails.vchCurrentOperatorRanking}}
                            {{scoredetails.Overridden || 'false'}}

                            Scoring Grid

                                The grid below contains this contractor's scores for each scoring item in this scoring set.

                            Score Awarded
                            Scoring Item Description
                            Date Scored
                            Contractor Answer

                            {{result.intScore}}
                            {{result.vchDescription}}
                            {{result.dteDateCalculated}}
                            {{result.vchQuestionAnswer}}

I receive the error "TypeError: Unable to get property 'name' of undefined or null reference
at tableToJson (http://localhost/SSQV4/SSQV5/Scripts/from_html.js:297:17)
at DrillForContent (http://localhost/SSQV4/SSQV5/Scripts/from_html.js:450:25)
at Anonymous function (http://localhost/SSQV4/SSQV5/Scripts/from_html.js:647:13)
at done (http://localhost/SSQV4/SSQV5/Scripts/from_html.js:517:13)
at loadImgs (http://localhost/SSQV4/SSQV5/Scripts/from_html.js:547:9)
at process (http://localhost/SSQV4/SSQV5/Scripts/from_html.js:645:9)
at jsPDFAPI.fromHTML (http://localhost/SSQV4/SSQV5/Scripts/from_html.js:1083:9)
at $scope.export (http://localhost/SSQV4/SSQV5/Scripts/app/Contractor/ContractorCtrl.js:63:9)
at fn (Function code:2:277)
at Anonymous function (http://localhost/SSQV4/SSQV5/Scripts/angular-touch.js:478:9)"
Please help!

https://github.com/MrRio/jsPDF/blob/master/plugins/from_html.js#L297
Looks like the plugin expects your header columns to equal your data columns. It also doesn't appear to support using colspan like you are using in your header (colspan 4).
Have you tried with a simple table with 1 header column and 1 data column and 1 row?

try to add a classname to each table like " 'class='myTable' ", then call them with var myTables = angular.element(document.getElementsByClassName('myTable');. Use angular.forEach: 			angular.forEach(myTables, function(value, key) { 				summaryPdf.fromHTML(value,10, 10, { 					'elementHandlers': specialElementHandlers 				}); 			});

@pokaxperia Are you sure? As far as I can tell this library only accepts IDs as valid selectors for special element handlers (justification here). Granted that issue is an old one, but the offending code is still on the main branch, so it doesn't look like the desired functionality will be available any time soon. What this means is that your handler will never fire.


If the Contact field in a primary Affiliation changes, we need to clear the field in the old Contact and populate the field in the new Contact

** lurch: attach W-009442

Included in beta release version 1.5 (Beta 2) and higher

Included in production release version 1.5


Redirect after "Invite" Page

What
As a first-time user who hasn't signed up, when clicks "Connect" on the "Invite" Page, redirect to "Login" Page

See #28

…and then come back.


chore: avoid accessing protobuf message type fields directly

We should ideally avoid accessing fields of protobuf messages directly; we should instead use the getter methods. Below is an example of a field accessed in two different ways in our codebase:
	err := sc.DemoteTeacherToStudent(ctx, &scm.UpdateEnrollmentOptions{
		Organization: course.GetScmOrganizationName(),    // correct
		User:         user.GetLogin(),
		Status:       qf.Enrollment_STUDENT,
	})

	scmRepo, err := sc.UpdateEnrollment(ctx, &scm.UpdateEnrollmentOptions{
		Organization: course.ScmOrganizationName,         // incorrect
		User:         user.GetLogin(),
		Status:       qf.Enrollment_STUDENT,
	})

If this hasn't been taken up yet by anyone, I can work on the cleanup.

If this hasn't been taken up yet by anyone, I can work on the cleanup.

I'm not aware of anyone working on this. Feel free to submit a PR.
Ideally, you should also add tests that demonstrate that the fix avoids the potential problem due to a nil reference. For example, a course reference as in the course.ScmOrganizationName example above should be nil in the test, which would cause a panic due to the nil pointer deference, and fixing it should then not cause a panic.

Yes, will do.

#1142 and #1143  are somewhat related to this issue.


crashes on initialization

on M1 silicon MacBook, app crashes after after running
Finished `release` profile [optimized] target(s) in 0.14s
     Running `target/release/steering`
2024-07-26T14:00:02.857264Z  INFO bevy_render::renderer: AdapterInfo { name: "Apple M1 Pro", vendor: 0, device: 0, device_type: IntegratedGpu, driver: "", driver_info: "", backend: Metal }
2024-07-26T14:00:02.971056Z  INFO bevy_prototype_debug_lines: Loaded 2d debug lines plugin.
2024-07-26T14:00:02.981619Z  INFO bevy_winit::system: Creating new window "Bevy App" (0v0)
2024-07-26 17:00:03.112 steering[78715:8272772] CAMetalLayer ignoring invalid setDrawableSize width=4294967295.000000 height=4294967295.000000
2024-07-26T14:00:03.113864Z ERROR wgpu::backend::direct: Handling wgpu errors as fatal by default
thread 'Compute Task Pool (0)' panicked at /Users/blackbird/.cargo/registry/src/index.crates.io-6f17d22bba15001f/wgpu-0.15.1/src/backend/direct.rs:3024:5:
wgpu error: Validation Error

Caused by:
    In Device::create_texture
      note: label = `main_texture_a`
    Dimension X value<PHONE_NUMBER> exceeds the limit of 16384

note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'Compute Task Pool (1)' panicked at /Users/blackbird/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_ecs-0.10.1/src/schedule/executor/multi_threaded.rs:194:60:
A system has panicked so the executor cannot continue.: RecvError
thread '<unnamed>' panicked at /Users/blackbird/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_tasks-0.10.1/src/task_pool.rs:376:49:
called `Option::unwrap()` on a `None` value
thread 'main' panicked at /Users/blackbird/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_render-0.10.1/src/pipelined_rendering.rs:136:45:
called `Result::unwrap()` on an `Err` value: RecvError
thread 'main' panicked at /Users/blackbird/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_tasks-0.10.1/src/task_pool.rs:376:49:
called `Option::unwrap()` on a `None` value

/tmp/rust-drive-ai main* ❯                                             17:00:03

seems like bevy is the bad guy, cargo update fixed the problem


Apache virtual hosts don't work after installing pow

Hi there,
I have been running virtual hosts on my Mac for developing PHP sites. I have installed Pow and now my previous virtual host sites display a message "This domain isn’t set up yet. Symlink your application to local.mydomain.c first."
Is this something to do with the ports that they're not able to run together?
Thanks.

Can't you just set export POW_DST_PORT=81 via .bash_profile?

having the same issue. Installed Pow, which messed up my virtual hosts. I uninstalled, rebooted and am getting a 503 now. I just don't know where to go from there

Figured it out. I removed the resolver file and rebooted. That fixed it.

Oi, yeah. This is an issue. I need the ability to quickly access one-offs at localhost. Why does pow take over everything instead of only the *.dev hosts? Is there no way to configure pow to whitelist or even blacklist certain hosts from pow's evil, er, masterful clutches?


HTML

HTML
User Story
As a bootcamp student
I want the prework notes to be structured on a webpage
so that I can easily find and read information
Acceptance Criteria
GIVEN a Prework Study Guide website
WHEN I visit the website in my browser
THEN I see four boxes titled HTML, CSS, GIT and JavaScript with associated notes listed

Code added and merged into 'Main'


Gitcoin passport demo

Hey @ChaituVR could you explain what this does? Does it add Gitcoin Passport verification to Snapshot?

Does it add Gitcoin Passport verification to Snapshot?

Hey @Deepcryptodive Yep we are just experimenting with gitcoin passport, but there are some other things we need to handle and do many tests (This PR may not work it is just a small POC and it is kind of complicated to try it yourself right now) Anyway thanks for trying it out, keep an eye on future changes/PRs :)

Sadly I wasn't able to get validated, even though I have a Gitcoin passport on this account:

It checks if you have particular stamps in your passport, right now it is enabled to thanku.eth space only (this space use Github, ENS, Twitter, POAP stamps), But as I said, it is just POC, it may not work as expected 🙈

https://github.com/snapshot-labs/snapshot/pull/3302


Append N lines from end of console log

This feature enables the user to be able to choose how many lines from the tail of the console log they want to be appended to the slack message.
Default value is 0.

@samrocketman I think this is a best-effort means to add meta-data to a slack notification.
A slack notification needs to have a gist of what the notification is about.

imho console context is not good enough metadata. I agree we want a gist of what the notification is about, but I would rather hand it something , eg an environment variable that might be empty.


Add primitive for consuming an empty line

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (97a9038) 90.00% compared to head (54b026e) 90.38%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   90.00%   90.38%   +0.38%
==========================================
  Files           4        4
  Lines         150      156       +6
==========================================
+ Hits          135      141       +6
  Misses         15       15

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


swhich off trace

Description
Please explain the changes you made here.
Which issue(s) does this PR fix

Fixes #?

PR acceptance criteria
Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[ ] Unit Tests are updated and passing
[ ] E2E Tests are updated and passing
[ ] Documentation is updated if necessary (requirement for new features)
[ ] Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

/test all

/test all


StandalonePublisher: added support for Extract Background families

Brief description
Extranct Background Layout and Extract Background Comp support was missing from 2.x
Description
Added needed values to Settings, added actual psd-tools to .toml.
Requires https://github.com/pypeclub/ClientAddons
Testing notes:

Double check configuration in project_settings/fourthwall_addon/publish
prepare .psd workfile that contains layers with some configured names, some with different
publish with SP
check publish/background folder for correctly extracted only configured layers + .json file
`

Converted to Addon.


Exclusions from Office 365 (preview) not working properly

Contrary to the documentation, specific applications cannot be excluded from a conditional access policy once Office 365 (preview) has been included. Tested with Teams; when enforcing conditional access by including Office 365 (preview), excluding Teams and Sharepoint from this policy have no effect and still fall under the conditional access policy.
Reference from article" Administrators can choose to exclude specific apps from policy if they wish by including the Office 365 (preview) app and excluding the specific apps of their choice in policy."

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e5b78894-32c2-6712-6699-f3c87d40b1d7
Version Independent ID: dd791c15-d43b-b203-a93f-a8ec33c519b0
Content: Cloud apps or actions in Conditional Access policy - Azure Active Directory
Content Source: articles/active-directory/conditional-access/concept-conditional-access-cloud-apps.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@T-Benny  Thank you for your query, our team will look into it and get back to you at the earliest.

Thanks for the response, another issue with the way this performs is when a conditional access policy uses Include - All cloud apps. This will automatically include Office 365 (preview) in the policy and subsequently, all products that fall under this bundle can no longer be excluded from the policy.

Email out to PG for feedback

Due to service dependencies some apps like Teams may not function correctly if you just exclude them individually. If this is still an issue I would open a case with Microsoft support and they can further diagnose the issue with you.

Due to service dependencies some apps like Teams may not function correctly if you just exclude them individually. If this is still an issue I would open a case with Microsoft support and they can further diagnose the issue with you.

#please-close

#please-close

Teams is just an example. I have tickets open about this.  Office 365 app should not override exclusions.

Teams is just an example. I have tickets open about this.  Office 365 app should not override exclusions.


Add Karpenter Node Instance Profile Name as a Cfn Output

Issue #, if available:
#494
Description of changes:
PR addresses:

Currently, the Karpenter Add-on does not export Instance Profile in any way. This is necessary for users to add as part of provisioners. This PR will expose the name of the Instance Profile as a CloudFormation output.
Separate Karpenter Addon suite of unit tests
Consolidation check fixed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/do-e2e-tests


Update README.md

Added an overview of quantnuclei and qc-1 pipelines.

Awesome thanks! Very helpful!

Thanks I will add more as I go through the other pipelines


lyxal: Watch indiapropertydekho.com

lyxal requests the watch of the watch_keyword indiapropertydekho\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

indiapropertydekho\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by cigien in Charcoal HQ


incorporate highlighted rows into the chartmaker

Test Notes:  Confirm that highlighted values from the codebook tab appear as orange dots on the chart tab.


Home assistant addon: "AVX not detected"

Describe the bug
I get log entry "AVX not detected" when starting home assistant addon.
My system: Home Assistant OS on proxmox server. AMD ryzen CPU with GPU.
To Reproduce
Steps to reproduce the behavior:
Install compreface addon on latest HAOS running on proxmox/AMD CPU.
Logs
from HAOS addon page:
AVX not detected
AVX not detected
AVX not detected

To anyone searching for this in future:
I have changed proxmox VM CPU type from "kvm64" to "host" and it has started without errors.


Variable list has no UIDF actions

You should be able to set/reset the value of variables in the variable list sidebar widget

Fixed in 3.6.4627-dev


Cache management prototype (DO NOT MERGE)

First cut of the promised cached management layer for SMP synchronization.  Executive summary is that there is a new KERNEL_COHERENCE kconfig:

It's set by default when the arch/soc layer support it and when SMP is selected with 2+ CPUs

All writable data is uncached by default, and thus usable safely in MP contexts

All read-only data (and code, obviously) is still cached

Stacks declared with the standard macros are by definition CPU-local and so are cached

Applications can use a "__incoherent" attribute on their own static data to put it in cached memory.

This only works on Up Squared right now.  There's a distressing amount of grunt work (and probably a decent amount of rewriting) involved in getting all the variant linker scripts working.

Try the hello_world rig in the last patch to see a hacky demo of how the cacheable regions in memory work at the hardware level.

This needs a rebase.  I'm about a week behind current SoF code.

Unfortunately you can't try it directly with SMP right now, because SMP seems not to be building in the current tree (or rather the tree I'm on top of).  I'll investigate.

Huh... I can't add reviewers inside the SOF project.  @lgirdwood @finikorg @andrewboie will all want to look at this.

Right now it only applies in the SoF tree, but that will be rectified very soon.  The tree itself is actually relatively current WRT master, last rebased April 21.

@andyross you shoudl see an invite in your inbox. This will give you W access.

Btw, I think we always have a fixed offset between cache and uncache memory today but that may change in the future.

Well, it has to be a multiple of 512MB because that's the architectural feature being exploited (Xtensa's "Region Protection Option") works in that granularity by design.  The specific fact that RAM regions are mapped twice[1] is a feature of the DSP obviously, and it's surely possible the addresses for those mappings might change in future designs, yeah.  But FWIW: this seems like a pretty stable choice to me.
[1] The cacheability part is actually not architectural at all.  We can set the TLB[2] entries for these regions to whatever we want.  The choice of 0x8000000 being the uncached mapping is made by convention and implemented in the firmware ROM (we re-do the setting too).
[2] Not actually a TLB.  The 8 fixed registers defining these regions happen to be accessed using the TLB instructions, because the "Region Protection Option" implemented here is, to Xtensa's mind, a subset of the full "MMU Option" which provides a proper TLB.

Closing.  The final version[1] is up in a separate PR.
[1] Not the final version.  This will need some significant cleanup before it becomes generic to all the CAVS variants, as they currently all have their own linker scripts.


Updated node sdk with Instance v3 Edit feature APIs

Updated node sdk with Instance v3 Edit feature APIs
PR summary

Fixes: https://github.ibm.com/hummingbird/tracker/issues/3101
PR Checklist
Please make sure that your PR fulfills the following requirements:

[X] The commit message follows the Angular Commit Message Guidelines.
[X] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been added / updated (for bug fixes / features)

PR Type

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] New tests
[ ] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

For issue: https://github.ibm.com/hummingbird/tracker/issues/3101

This PR is redundant and hence being closed without merge.


Component Request - [ResourceSelectionList]

Component Details
Detailed description
As part of our new IoT application setup pattern, we have need of a component that allows selection of a resource from a list
You will consider this component complete when...

[ ] it renders a list and allows single selection with a callback
[ ] adds overflow button on list item
[ ] adds rich content on list item (to support icons) or a prop to pass an icon
[ ] adds control buttons on list header
[ ] pagination?  TBD
[ ] a11y, tests, documentation

Additional information

This issue is stale. Closing. Please re-open if needed.


fix decrement connection count in cluster mode

if not in max_connections_per_node, I will meet "Too many connections".
I try to read the source code which difference with redis-py-cluster.
I find this might be the problem.

@matianjun1 Thank you for your feedback~
As far as i can see, it may not be the problem about  parameter max_connections_per_node, could you tell me what  is the value of max_connections_per_node, max_connections and the number of connections indeed?


Status() only returning one dps

A bit of context, I am attempting to integrate with a Yakry C2 (Petfeeder with Camera) to get feeding schedules done locally and hence removing a point of failure (connection to Tuya servers, though the argument could be made that whatever machine runs the new code becomes the new point of failure... lol).
So while I managed to find the dps to trigger the feeder (201) I found myself hoping to expand the integration a bit.
Here's where I run into issues, there are 6 dps that return data when requested individually, however when requesting all 6 at the same time I only the first one is returned.
The detect_available_dps also ends up returning one dps, and I have a feeling the issues are related.
Here is my code:
import tinytuya

d = tinytuya.Device('someid', 'someip', somekey')
d.set_version(3.3)
d.dev_type = "device22"  # I noticed that the device gets auto-upgraded to this
d.add_dps_to_request(101)
d.add_dps_to_request(103)
d.add_dps_to_request(104)
d.add_dps_to_request(106)
d.add_dps_to_request(108)
d.add_dps_to_request(134)
data = d.status()
print('Device status: %r' % data)

Here is the output: Device status: {'dps': {'101': False}, 't':<PHONE_NUMBER>}
If I remove the dps 101 then the output becomes: Device status: {'dps': {'103': False}, 't':<PHONE_NUMBER>}, etc.
I traced the received payload and it does seem to come from the device itself as it only contains one dps coming out of payload = cipher.decrypt(payload, False).
Has anyone run into a similar problem?

Hi @AntoineGS, thanks for opening this issue.  What version of TinyTuya are you running?  If it is 1.7.0, can you also run a scan to see if this device is actually a 3.3 or 3.2 device?
python3 -m tinytuya version

python3 -m tinytuya scan

I also recommend setting up a monitoring loop to see if the device emits anything differently over time:
import tinytuya

d = tinytuya.Device('someid', 'someip', 'somekey')
d.set_version(3.3)
d.dev_type = "device22"
d.set_socketPersistent(True)
d.detect_available_dps()

print(" > Send Request for Status < ")
payload = d.generate_payload(tinytuya.DP_QUERY)
d.send(payload)

print(" > Begin Monitor Loop <")
while(True):
    # See if any data is available
    data = d.receive()
    print('Received Payload: %r' % data)

    # Send keyalive heartbeat
    print(" > Send Heartbeat Ping < ")
    payload = d.generate_payload(tinytuya.HEART_BEAT)
    d.send(payload)

    # NOTE If you are not seeing updates, you can force them - uncomment:
    # print(" > Send Request for Status < ")
    # payload = d.generate_payload(tinytuya.DP_QUERY)
    # d.send(payload)

    # NOTE Some smart plugs require an UPDATEDPS command to update power data
    # print(" > Send DPS Update Request < ")
    # payload = d.generate_payload(tinytuya.UPDATEDPS)
    # d.send(payload)

Thanks for the quick and insightful response!
I am running 1.7.0 (cloned the repo recently, using master).
Scan does confirm it is a 3.3 device.
The monitoring loop does return more data!
I am seeing DPs 101, 103, 104, 106, 108, 134, 202, 207 with it so that's awesome.
Even though the payload only includes 101, so maybe received payloads are not triggered by my requests but it's just broadcasting them.

So it would seem that it does not send back all DPs at once but one per payload, interesting.
Do you know if that's common for some Tuya devices?
(So that I may have some references of some other integrations that might be more common for when I get stuck again).
I don't have time tonight to play more with this but that's some good progress, thank you!!

I still haven't been able to figure out why device22 devices behave differently than the rest of 3.3 devices.  They seem to use protocol 3.2 but identify as 3.3 which is the reason for the device22 setting... I feel like they were an "in between" variant.  In any case, I only have one of those devices and it does seem to be stingy about responding with more than 1 DP.  In my case, it is a plug so I really only care about DP 1 for the switch function, but it did strike me as odd.
In the loop I sent you, it may be interesting to see if you get any different results by sending the UPDATEDPS command.
# NOTE Some smart plugs require an UPDATEDPS command to update power data
print(" > Send DPS Update Request < ")
payload = d.generate_payload(tinytuya.UPDATEDPS)
d.send(payload)

For your particular device, would you provide a description of what the DPS mean?  Others with this device may like to know.  @fhempy , @uzlonewolf and I have been discussing how best to represent community discovered DPS for various Tuya devices (e.g. more or expanded https://github.com/jasonacox/tinytuya#tuya-data-points---dps-table with mapping to product_id).

Thanks for all the info!
I am closing the Issue since I am finding very little time to work on this so there's no point polluting the Issues' list.

I know I'm a bit late to this party, but just wanted to chime in about the device22 thing.  I don't think the length of the id string actually means anything; of the 25 different types of devices I have, 17 have a 22-digit-long device id, and of those all but 1 act like normal v3.3 devices.

I know I'm a bit late to this party, but just wanted to chime in about the device22 thing. I don't think the length of the id string actually means anything; of the 25 different types of devices I have, 17 have a 22-digit-long device id, and of those all but 1 act like normal v3.3 devices. I suspect the quirks come from which platform/chip library the device was built around. I know the doorbell cameras use a rather powerful SoC and run Linux, and it wouldn't surprise me if this pet feeder does too.

That's a great point @uzlonewolf. I believe you are right and in hindsight, I wish we had picked something besides "device22" to identify these oddities. 😞


plugins/telescope: support non-builtin keymaps

Use the :Telescope command instead of relying directly on
require("telescope.builtin").
To quote upstream docs:

All telescope.nvim functions are wrapped in vim commands for easy access, tab completions and setting options.

Fixes #1493

<cmd> mappings are not echod, so the keymapsSilent now has no effect and could be deprecated.

I think there's a design decision to make here.
Using using the :Telescope command is simpler, since both builtin and extension pickers are directly available, and options can also be passed to the picker as part of the command.

The viml api can be called using commands like: :Telescope find_files hidden=true layout_config={"prompt_position":"top"}
This involves setting options using an = and using viml syntax for lists and dictionaries when the corresponding lua function requires a table.

However :h telescope.command does point out some limitations:

The viml api is more indirect, as first the command must be parsed to the
relevant lua equivalent, which brings some limitations.
One limitation of the viml api is that there can be no spaces in any of the
options.
For example, if you want to use the cwd option for find_files to
specify that you only want to search within the folder /foo bar/subfolder/
you could not do that using the viml api, as the path name contains a space.

It's also unclear whether all third-party extensions will expose their picker functions via the :Telescope command...

That said, this is already more powerful than the current approach, since the current telescope keymap wrapper doesn't allow passing any option arguments to the picker function anyway. Nor does it allow using third-party (extension) pickers.
If we decide we don't like the :Telescope approach, the only other way I can think of to (directly) support third-party picker functions is by adding an option along the lines of keymap.extension = mkNullOrOption str "If action is a third-party extension function, this should be the name of the extension.". I think this is more cumbersome from a UX perspective, though.

We could also augment either the old or new system by allowing action to be a raw string. This could be used as the body of a lua function where we've already defined some local variables (e.g. telescope, builtins, extensions). This way the user can use the lua API to call telescope functions.

@GaetanLepage could you re-review when you have chance?


Fix for edge cases with bbox overlap and out-of-bounds polygons

More follow-up for #800:

Adds tests for CONTAINMENT_OVERLAPPING_BBOX and fixes the out-of-bounds write when using bbox overlap on a one-vertex polygon
Adds a simpler version of this test case and fixes CONTAINMENT_OVERLAPPING results for polygons outside of the normal lat/lng range. The issue here was the test for cell-contains-polygon, which used latLngToCell - this function will return results for out-of-bounds input, presumably wrapping around the sphere, but because the rest of the logic (including the estimator) in polygonToCells is using cartesian coords, these false positives were unexpected. I updated this to include a bbox check first, which will exclude polygons with all points outside of the normal range.

coverage: 98.826% (-0.003%) from 98.829%
when pulling b2463b66162501e3c006e536de52dfd4496ec796 on nrabinowitz:bbox-overlap-tests
into b57df8b6a01df7f70f76117ee058829613712057 on uber:master.


Remove deprecated max-life-time

Fixes #.
Changes in this pull request:

Remove the deprecated max-life-time with max-lifetime.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: Aravindh-Raju:x: arpit4everYou have signed the CLA already but the status is still pending? Let us recheck it.


Roll engine to 059ab3a47165d98cb1d7ac5e2a2e4b50abf39832

LGTM but I'm about to land the point removal on the framework side too anyway


v2/everything - multiple keywords

Hi there,
I tried using multiple keywords but nomatter how I join them, I'm not receiving results any close to what I receive when I use the classic GogleNews Search.
My code:
from newsapi import NewsApiClient
api = NewsApiClient(api_key='xxx')
keywords = ['Neubau', 'Weiße', 'Stadt']
all_articles = api.get_everything(q=','.join(keywords),
                                  sort_by='publishedAt',
                                  language='de')

besides ',' I tried joining the keywords by:

'&'
'%20'
'%2C'

Is there something I miss?

@sputnik44 I see you marked this as completed.... What was the solution. Getting results which are nowhere close to the keywords provided by me


Data transfer tutorials

Documentation preview deployed!
Available at https://docs.egi.eu/documentation/368

Now the page is published at https://docs.egi.eu/documentation/368/users/tutorials/data-transfer-object-storage/


Generate custom struct tags

Is your feature request related to a problem? Please describe.
I would like to generate types from a graphql schema with neo4j graphql directives, and convert those to gogm-compatible struct tags.

The first part of the task is about appending gogm style struct tags for variable names.
The second and more complex part of the task is to support custom neo4j directives

For instance:
Example of graphql with neo4j directives:
  interface ResourceEntity {
    id: ID! @id(autogenerate: false)
    name: String
  }

  type Resource implements ResourceEntity {
    id: ID! @id(autogenerate: false)
    name: String
    containedBy: [ResourceEntity!]! @relationship(type: "CONTAINS", direction: IN)
  }

Describe the solution you'd like
Example of generated code:
type ResourceEntity struct {
	// provides required node fields
	gogm.BaseNode

    Name         string                `gogm:"name=name"`
}

type Resource struct {
	// provides required node fields
	gogm.BaseNode

	Name  string     `gogm:"name=name"`
	ContainedBy  []*ResourceEntity   `gogm:"direction=incoming;relationship=..."`
}

Would be helpful to even pass a json/yaml or have an annotation-based approach to define struct tags for the different directives
Describe alternatives you've considered
I can manually parse graphql and emit struct_tags of appropriate types for gogm

Interesting. This looks complex enough I think we'd need to do it as some sort of plugin (or maybe even two, one for neo4j and one for gogm). I've created #237 to track setting up a plugin API; it will require some careful design.


Doesn't Compile With Extension

Hi,
After adding  to Project.xml, I get the following when trying to compile for Android target:
Running Pre-Build Command Line...
cmd: "C:\HaxeToolkit\haxe/haxelib" run lime build "Project.xml" android -release -Dfdb

extension-android-support-v4: [** JUST IN CASE NOTICE **] Please remember to download and upgrade 'Android Support V4' on a regular basis. Read more at https://github.com/sempaigames/extension-android-support-v4

extension-googleplayservices-lib: [** JUST IN CASE NOTICE **] Please remember to download and upgrade 'Google Play Services Library' on a regular basis. Read more at https://github.com/sempaigames/extension-googleplayservices-lib
Called from ? line 1
Called from CommandLineTools.hx line 1282
Called from CommandLineTools.hx line 25
Called from CommandLineTools.hx line 126
Called from CommandLineTools.hx line 560
Called from project/PlatformTarget.hx line 60
Called from platforms/AndroidPlatform.hx line 296
Called from /usr/lib/haxe/std/neko/_std/sys/FileSystem.hx line 63
Called from /usr/lib/haxe/std/neko/_std/sys/FileSystem.hx line 54
Uncaught exception - std@sys_file_type
Build halted with errors.

I saw that this was an issue here:
https://github.com/openfl/extension-admob/issues/1
But I already have lime 2. Here is my setup:
actuate: [1.7.5] admob: git [dev:C:\HaxeToolkit\haxe\lib/admob/git] extension-admob: [1.4.7] extension-android-support-v4: [1.0.0] extension-googleplayservices-lib: [1.1.0] flixel-addons: [1.1.0] flixel-demos: [1.1.1] flixel-templates: [1.0.2] flixel-tools: [1.0.2] flixel-ui: [1.0.2] flixel: 3.3.5 [3.3.6] haxelib_client: [3.1.0-rc.4] hxcpp: [3.1.39] HypGPlay: git [dev:C:\HaxeToolkit\haxe\lib/HypGPlay/git] inthebox-macros: git [dev:C:\HaxeToolkit\haxe\lib/inthebox-macros/git] lime: 2.0.0-alpha.6 [2.0.0-alpha.7] 2.0.4 openfl-samples: [2.1.0] openfl: 2.1.4 [2.1.5] 2.2.1 swf: 1.6.5 1.6.6 [1.8.6]
And I've both Google Play services and Android Support Library installed.
Any idea what the problem could be? Thanks!

Are you 100% positive that you have google play services lib and android support library v4 installed on the same android sdk that openfl is using?

I'm closing this issue now, if you sill have problems please let me know.


Add support for APPENDUID response data

If the UIDPLUS extension is supported, the server will reply to
APPEND commands with the UID of the new message. This can even be a
list of UIDs if the MULTIAPPEND extension is also supported.
Make this information available to the user as the result of an
AppendCmd. The added doc strings have links to the relevant RFCs.
Related to #131.

This change is

If this is of interest, I'd be happy to add COPYUID as well...

Added a parse test much like the other one, I hope that's cool for now. I am happy to look into the integration tests, however I will be AFK for two weeks.

Looks like there's also now a conflict in src/parse.rs.

Sorry for the wait! I rebased on current master and added another test for the MULTIAPPEND response. I hope this is fine for this PR. I'll start looking into the integration tests to see if I can add some for all the stuff I added now.


Clarification needed for correct use of ClientContext::TryCancel()

After reading through discussions on Google Groups grpc.io and many open/closed issues here regarding ClientContext::TryCancel() and Finish(), it's still not clear to me how to cancel an RPC call from the client side.
Without cancellation, the sequence would be to read messages until "ok=false" for a Read() operation, then Finish() to get the server status and finally release the any resources associated with the RPC:

Read(), ok =true
Read(), ok =true
Read(), ok =true
Read(), ok = true
Read(), ok = false // nothing more to read
Finish(), ok = true // gets server RPC status
Delete ClientAsyncReader, ClientContext, ...

Now suppose the client throws an exception while processing the response returned by the second Read() and therefore wants to cancel the RPC. This message on google groups grpc.io says:

Even when you Cancel at the client, you should continue reading till ClientReader::Read() returns false. Only then is it correct to call ClientReader::Finish().
The above sequence is required to deal with server to client messages that race with the cancellation.

So the sequence with early termination would be:

Read(), ok =true
Read(), ok =true, exception while applying business logic
ClientContext::TryCancel()
Read(), ok =true // could happen from what I understand
Read(),  false = true
Finish(), ok = true
Delete ClientAsyncReader and ClientContext

Another message by Vijay Pai says:

If you want to forcibly shut down the stream, just call a TryCancel on the ClientContext object.

From what I understand Vijay is a real grpc expert, so I am inclined to think that he is correct and therefore the following sequence is valid (if the client is not interested in the server RPC status):

Read(), ok =true
Read(), ok =true, exception while applying business logic
ClientContext::TryCancel()
Delete ClientAsyncReader and ClientContext

IMHO this seems reasonable, except the client probably has to guarantee there is no uncompleted operation before deleting ClientAsyncReader and ClientContext in the last step.
I can imagine both approaches are valid. Depending on whether the client is interested in the server RPC status, it can choose to do the Read-until-false-then-finish sequence.
Question 1: Is my understanding correct? Am I missing relevant details?
Question 2: Does the same logic apply to the other RPC types?

We are discouraging the posing of general questions as issues. Kindly use stackoverflow for this.


When do I support user settings and plugins for backup export?

VSCode Version:
OS Version:

Steps to Reproduce:

@cjd6568358 Can you be more clear in your question?

Closing, since we do not understand the question.


php8.2 core related changes - V1

PHP 8.2 changes are already implemented in #6173.
Also see: https://github.com/bcit-ci/CodeIgniter/pull/6173#issuecomment-1967673736
If you instead would like an updated repo with PHP 8.2 support see;

https://github.com/ib3ltd/CodeIgniter/tree/master
https://github.com/pocketarc/codeigniter


rcc_ex: fix RTC clk sel with HSE div

IMPORTANT INFORMATION
Contributor License Agreement (CLA)

The Pull Request feature will be considered by STMicroelectronics after the signature of a Contributor License Agreement (CLA) by the submitter.
If you did not sign such agreement, please follow the steps mentioned in the CONTRIBUTING.md file.

This pull request has been refused, the Contribution License Agreement must be signed.


[Question] Documentation is correct?

Mac OSX/Linux
For waxdev
docker run -it --name waxdev -v /c/wax:/wax waxteam/dev bash?
should it not be:
docker run -it --name waxdev -v wax:/wax waxteam/dev bash?
Also waxcdt
docker run -it --name waxcdt -v /var/share/wax:/wax waxteam/cdt bash
says namespace already taken up ?

I think you have the wrong repo

@heifner I was working in Wax https://developer.wax.io/dapps/wax-contract-development-toolkit-wax-cdt/ and it is eos related?

Wax is a fork of eosio: https://github.com/worldwide-asset-exchange/wax-blockchain

So can both Wax and EOSIO able to generate Ricardian Contract? I don't see much resources on it.

WAX is based on EOSIO.  EOSIO has Ricardian Contracts.  If you have further questions about WAX, please join a WAX-specific group. The EOS github is for EOS software issues only.
Thanks.


ci: new gcc-oldest build to replace gcc-7.3

The minimum GCC version we are required to test is 7.5. Create a build
name that is more stable and (arguably) easier to grok.

This change is

/gcbrun


Multi-arch *4 support

Producing a multi-arch image build on the following arches: amd64, arm64, ppc64le and s390x

/retest

@ondrejbudai @achilleas-k Please take a look at the CI failures. centos-bootc images multiarch support will be unlocked as soon as this PR is merged and an new quay.io/centos-bootc/bootc-image-builder image lands.

This seems to fail because of a recent API change in the "images" library, this PR  https://github.com/osbuild/bootc-image-builder/pull/665 fix this and once rebased this test should pass.

This seems to fail because of a recent API change in the "images" library, this PR #665 fix this and once rebased this test should pass.

Thanks @mvo5 for your feedback. Is it safe to merge this PR even before the other fix has landed?

#665 is in the merge queue.  We can rebase once it's merged to make sure the configs in this PR work.


How the better way to decode object "quote" ?

About, by example...
client.getQuotes({id: '1'}).then(console.log).catch(console.error)
give the result as:
{ status:
{ timestamp: '2018-10-09T18:25:52.372Z',
error_code: 0,
error_message: null,
elapsed: 8,
credit_count: 1 },
data:
{ '1':
{ id: 1,
name: 'Bitcoin',
symbol: 'BTC',
slug: 'bitcoin',
circulating_supply: 17313137,
total_supply: 17313137,
max_supply: 21000000,
date_added: '2013-04-28T00:00:00.000Z',
num_market_pairs: 6293,
cmc_rank: 1,
last_updated: '2018-10-09T18:24:28.000Z',
quote: [Object] } } }
quote isn't decoded, how the better way to show all decoded ?
Sugestion too: these example results can be part of doc manual.

It's not that it's not decoded, it's that Javascript's console.log doesn't print out objects inside nested objects to avoid showing too much output. Try the code snippet below to print out both.
client.getQuotes({id: '1'})
  .then(info => {
    // Print out the info
    console.log(info);
    // Print out the quote object
    console.log(info.data['1'].quote);
  })
  .catch(console.error);

@RNOVAKOSKY Or you can try https://stackoverflow.com/a/38768951/2110448.

Closing since the question has been answered.


Content Control Datatemplate binding

Describe the bug
I have this weird bug where adding a primitive type onto a content control only binds one way to the datatemplate, not two way, no matter what I try
To Reproduce
this will only bind one way:
<ContentControl Content="{Binding Value}" Width="100" VerticalAlignment="Center">
		<ContentControl.DataTemplates>
			<DataTemplate DataType="{x:Type x:String}">
				<TextBox Text="{Binding }"/>
			</DataTemplate>
			<DataTemplate DataType="{x:Type x:Boolean}">
				<CheckBox IsChecked="{Binding Mode=TwoWay}"/>
			</DataTemplate>
		</ContentControl.DataTemplates>
</ContentControl>

my temporary workaround to make it work:
<ContentControl Content="{Binding Value}" Width="100" VerticalAlignment="Center">
	<ContentControl.DataTemplates>
		<DataTemplate DataType="{x:Type x:String}">
			<TextBox Text="{Binding $parent[UserControl].((vm:PropertyViewModel)DataContext).Value}"/>
		</DataTemplate>
		<DataTemplate DataType="{x:Type x:Boolean}">
			<CheckBox IsChecked="{Binding $parent[UserControl].((vm:PropertyViewModel)DataContext).Value, Mode=TwoWay}"/>
		</DataTemplate>
	</ContentControl.DataTemplates>
</ContentControl>

the workaround for me is basically bind back to the view model that is the data context, in that case it will bind two ways again.
at first I assumed it's just an issue with bools and the checkbox, but it's the same for strings and the textbox
Expected behavior
No response
Avalonia version
11.1.3
OS
Windows
Additional context
No response

Don't use primitive types as the DataContext if you expect to mutate it. Always bind to properties when mutating (in this case, by the control). Why?

Strings are immutable. When "modifying" a string, you're assigning a different string instance to a local variable, property, field, etc. {Binding} lacks this information and is conceptually working with something closer to this.
Value types are copied by value. So even if you could mutate it, it's not necessarily the same memory location.

Don't use primitive types as the DataContext if you expect to mutate it. Always bind to properties when letting a control mutate binded state. Why?
1. Strings are immutable. When "modifying" a string, you're assigning a different string instance to a local variable, property, field, etc. `{Binding}` lacks this information and is conceptually working with something closer to `this`.

2. Value types are copied by value. So even if you could mutate it, it's not necessarily the same memory location.

yeah I'm aware of that, I just sorta expected it to behave differently in this case, so it seemed off to me

That's by design. TwoWay bindings can't edit the bound object, but only Properties of that object.


Installs as electrum, not electrum-ravencoin

Entry in ~/.local/bin/ does not match instructions or provided .desktop

Just confirming this is what you mean by applist (please excuse the ubuntu)

No need to excuse, Ubuntu and Gnome are both great!
That is indeed what I meant, I'm using XFCE desktop so it's a bit more classical but effectively the same thing. (Don't mind the correct icon on panel, it is manually set for my sanity)


[JOSS Review]: Unsafe memory access

There are several places, where unsafe memory access (malloc/free) is used. At least in one of these places there is an obvious memory leak. This allocated memory is never being freed:
https://github.com/villano-lab/nrCascadeSim/blob/6b11bb3601109b8b0177e4ad8e40b69ef613a933/src/lindhard.c#L54
It would be good to have a some kind of justification of using unsafe memory access or at least a code sanitizer report.

@altavir do you mean it's not being freed inside the function? That's by design. This API function is returning an array (that's the allocated memory) and it's the responsibility of the user to free that memory. It is known how big the array is to the user.
Do you consider that bad practice--I will look through some standards. But many C codes that return arrays work like that one way or another.
The only other option I see is to use STL vectors but that adds a bit of overhead and would need to be consistently done through the whole code base.

I specifically checked. It is not freed outside as well in this case.
If you mean a performance overhead, you should supplement your conciderations with some performance measurements. I am pretty sure, that you can't see it. Especially when they are used in configurations, not in computations.
Memory leaks is one of the main problems in C++ ecosystem. Direct memory allocation should be avoided at all costs. Vector is a good solution in your case. In other cases smart pointers could help. I am not sure which C++ standard are you requiring, but all those things should be available since C++11.
In pure C you do not have a lot of freedom in that, but your code is C++, not C.

Just in case, here is a quote from the basic C++ reference manual:

This function does not call constructors or initialize memory in any way. There are no ready-to-use smart pointers that could guarantee that the matching deallocation function is called. The preferred method of memory allocation in C++ is using RAII-ready functions std::make_unique, std::make_shared, container constructors, etc, and, in low-level library code, new-expression.

My collegue suggested to use structs for that. They are stack-allocated so no problems with memory leaks. And you get additional type safety.

My collegue suggested to use structs for that. They are stack-allocated so no problems with memory leaks. And you get additional type safety.

Just to be clear--do you mean create/return a struct instead of an array?

Yes. It should work. I personally would use a vector. But if you are concerned about performance, it would be even faster than malloc and would save you a memory leak.
Though in general any statements about performance are meaningless without actual measurements (I've been doing a lot of high performance computations, so I am talking from experience).

I'm colleague @altavir mentioned. I think programmer should first of all care about meaning of code. It seems that elements of array has different meaning and putting them into plain array whether double[] or vector<double> hides that. Programmer must know what lies in first and second element of array and it looks like any other array. Putting it into struct allows to document meaning of fields and for reader to look up that documentation.
Speaking of performance. I measured overhead of returning 16B struct struct Foo {double fld1, fld2}; by value and allocating 2-element array on heap.  Difference is drastic: returning by value is just a few instructions: it's difficult to see because of PAPI overhead, while allocation of new buffer costs about 220 instructions and freeing another 100.  For such small structures it makes sense to use plain structs. It also saves you pain of memory management.
Also working with raw pointer is just asking for troubles. RAII is one of few nice feature of C++. When used properly it allows to make compiler do most of memory management for you. And compiler doesn't forget to call free
As a aside. No need to create temporary buffers. You could just take address of variable and call lindhard_ar_k(&E0,&k) (Or just switch function to call by value):
https://github.com/villano-lab/nrCascadeSim/blob/182e8a56406a8ae4e5cfc8df489d9779d25d93da/src/lindhard.c#L151-L158

@gerudo7 as part of this issue let's also change the extensions .c to .cpp and correspondingly in the Makefiles.  As pointed out this is really a C++ code so this will make that explicit.
see this confusing post for the reasons behind that.
basically we're not using a Windows compiler (only in a linux env through WSL) so it doesn't really matter for us, but .cpp makes it clear that we're coding in C++.
Also, we may have said C/C++ in documentation, we can just change that to C++.

You also need to clarify what C++ standard you are using. #64 would help with that as well.

You also need to clarify what C++ standard you are using. #64 would help with that as well.

@altavir this information is in the documentation, should it be somewhere else? Also we are consistent with a number of standards starting at C++11 and I am not aware of any deprecated features used through at least C++17.

Ah, I missed it. And from the rest of documentation I infer, you use only gcc. Different versions of C++ compiler are not fully compatible. It is one of major problem of using C++ (and why I advocate not to use it at all without very compelling reasoning). CMake have directives to check a compiler so it should not be a problem with proper build.


update comment to say Python 3.5 is required to run samples

@shinchris Here's the update we talked about for TFS 1111443

@mbren pycodestyle must have been updated recently and has introduced a new error.
My suggested fix is here if you'd like to copy it to get your branch to pass tests.
https://github.com/tableau/server-client-python/pull/618/commits/6e0ac52b803b3e9c3d6e72926aaccbf6113887a0

Thanks @mbren!


Add NL quickstart sample. Fix some other quickstarts.

Current coverage is 49.58% (diff: 100%)

Merging #438 into master will not change coverage

@@             master       #438   diff @@
==========================================
  Files            82         82
  Lines          2650       2650
  Methods           0          0
  Messages          0          0
  Branches        195        195
==========================================
  Hits           1314       1314
  Misses         1293       1293
  Partials         43         43

Powered by Codecov. Last update d0d4165...f7e2ece

Addressed comments.

@lesv FYI

Can be merged?


Print statements cause creation of test list to fail.

Print statements issued from files in a root test directory seem to interfere with nextest's method for building the test list. When running cargo nextest run for curl-rust, I see the following error:
error: creating test list failed

Caused by:
  for `curl::atexit`, line 'Finishing...' did not end with the string ': test' or ': benchmark'
full output:
Finishing...

The output Finishing... occurs due to the entrypoint in tests/atexit.rs, which prints before terminating:
fn main() {
    curl::init();
    hook();
    unsafe {
        libc::atexit(hook);
    }
    //println!("Finishing...")
}

Commenting out the print statement fixes the issue. This is happening on my M1 Macbook Pro, and I've seen this when using both the prebuilt binary and when building from source.

Thanks for the report! It looks like that test uses a custom test harness: https://github.com/alexcrichton/curl-rust/blob/main/Cargo.toml#L58-L60
Nextest requires that custom test harnesses obey a specific protocol, and this is documented explicitly here: https://nexte.st/book/custom-test-harnesses.html#manually-implementing-a-test-harness
I'd recommend porting the test over to using libtest-mimic, which obeys this protocol.


Storing and working with very large datafiles

Different file formats to work with very large datasets:

datatable
parquet (arrow package)

{polars} and {tidypolars} (data.table should be the fastest though)

DuckDB! It's very fast, since it is SQL-based when working with large data. We use that in the register databases. Connecting through dplyr is super easy.


The call is ambiguous between the following methods or properties: 'Expression.Like.Like(Expression?, bool, Expression, string?, bool)' and 'Expression.Like.Like(Expression?, bool, Expression, char?, bool)'

The following code causes  the above error

public record Like(Expression? Expression, bool Negated, Expression Pattern, string? EscapeChar = null, bool Any = false) : Expression, INegated
{
    public Like(Expression? expression, bool negated, Expression pattern, char? escapeChar = null, bool Any = false)
        : this(expression, negated, pattern, escapeChar?.ToString(), Any) { }

    public Like(Expression? expression, bool negated, Expression pattern, bool Any = false)
        : this(expression, negated, pattern, (string?)null, Any) { }

    public override void ToSql(SqlTextWriter writer)
    {
        var any = Any ? "ANY " : string.Empty;

        // ReSharper disable once ConvertIfStatementToConditionalTernaryExpression
        if (EscapeChar != null)
        {
            writer.WriteSql($"{Expression} {AsNegated.NegatedText}LIKE {any}{Pattern} ESCAPE '{EscapeChar}'");
        }
        else
        {
            writer.WriteSql($"{Expression} {AsNegated.NegatedText}LIKE {any}{Pattern}");
        }
    }
}

when called by
     Expression column....
     var expression = new Expression.Like(column, false, new Expression.LiteralValue(new Value.SingleQuotedString($"%{value}%")));

Fixed in the 0.6.2 release


Winter 21 changes

Fixes #1
A few things to note:

I followed the advice in the Contributing.md and filled out my CLA
There's an unusual amount of whitespace in each file. I'm not sure if this is intended or not, but I had to make my changes in Notepad because even with VS Code's "Format On Save" option turned off (and with Prettier disabled, as well as the VS Code settings related to trimming whitespace), my original diff was still misrepresented as a total file rewrite :(
At least on the generated diff prior to submitting the PR, I am being told that application/opportunity-automation/main/default/customMetadata/Trigger_Action.ta_Opportunity_SendWonNotification.md-meta.xml has been deleted, though this was not part of any git diff I saw prior to committing and pushing. Not sure what that's about and  git checkout origin/master -- application/opportunity-automation/main/default/customMetadata/Trigger_Action.ta_Opportunity_SendWonNotification.md-meta.xml failed, which is my norm for reverting a phantom change like this with: error: pathspec 'application/opportunity-automation/main/default/customMetadata/Trigger_Action.ta_Opportunity_SendWonNotification.md-meta.xml' did not match any file(s) known to git

@mitchspano just my luck to have submitted this while you were also making changes! I will rebase and re-push

Sorry! Less than ideal timing.
The whitespace is not intended, I will take a look into that.
The deletion of TriggerAction. ta_Opportunity_SendWonNotification.md-meta.xml was intentional. It was a leftover artifact from some previous tests. Just remove it from you PR and everything should be good.

No worries, almost done updating

Also,
If we are trying to make this compatible with Winter 21, we might want to update the API version to 50.0 in all classes and sfdx-project.json.

@mitchspano I added in all of the API version updates, however the MetadataTriggerHandler and its test file still have some messed up diffs. Working on that now.

@mitchspano should be ready to review now. Apologies for the in-between on looking at those diffs - we crossed the streams!

When I try to checkout and deploy from this PR, I get some sdfx deployment errors:
On branch pr/2
Your branch is up to date with 'github-desktop-jamessimone/feature/winter21'.

nothing to commit, working tree clean
macbook-pro-2:apex-trigger-actions-framework mitchellspano$ sfdx force:source:push
Job ID | 0Af3B00001BvnRnSAJ
SOURCE PROGRESS | ████████████████████████████████████████ | 31/31 Components
Job ID | 0Af3B00001BvnSRSAZ
SOURCE PROGRESS | ██████████████████████████████░░░░░░░░░░ | 6/8 Components
TYPE   PROJECT PATH                                                                                PROBLEM
─────  ───────────────────────────────────────────────────────────────────────────────────────────────  ────────────────────────────────────────────────────────────────────────────────────
Error  application/opportunity-automation/main/default/classes/ta_Opportunity_StageChangeRulesTest.cls  Extra ';', at ')'. (32:56)
Error  application/opportunity-automation/main/default/classes/ta_Opportunity_StageChangeRulesTest.cls  Comparison arguments must be compatible types: Integer, List<Database.Error> (32:10)
ERROR running force:source:push:  Push failed.

Updated - should be good now

Everything is able to deploy, but there is a test failure:
MetadataTriggerHandlerTest
afterInsert_fail
Fail
System.AssertException: Assertion Failed: Expected: true, Actual: false
Class.MetadataTriggerHandlerTest.afterInsert_fail: line 189, column 1

@mitchspano apologies. This whole "developing in notepad" thing made me sloppy, I missed one crucial account reference and of course that issue with the parenthesis. Everything should be good now, all tests passing.

Looks good.

Thanks! And thanks again for this library.


merge upstream at prometheus/prometheus@14e3c05

Merge upstream at https://github.com/prometheus/prometheus/commit/14e3c05ce80a9e73b8a50e80448274e1fd3ff0ae
This is to add out-of-order native histogram support https://github.com/prometheus/prometheus/pull/14546
It also includes 3.0 beta
Notes: on my own review:

excluding docs, discovery, UI changes there's something like 80 files to check

Read path:

the interval boundary change PR13904 is very noticeable from tests , but of course those are synthetic so that's to be expected

Write path:

unsure if UTF8 label value validation affects us directly from here - but can be set differently if yes
the other change is the out-of-order histograms, but they should be safe and are behind flag

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.6 out of 13 committers have signed the CLA.:white_check_mark: beorn7:white_check_mark: roidelapluie:white_check_mark: fionaliao:white_check_mark: aknuds1:white_check_mark: krajorama:white_check_mark: carrieedwards:x: jan--f:x: juliusv:x: NathanBaulch:x: SuperSandro2000:x: 51n15t9r:x: harry671003:x: NexucisYou have signed the CLA already but the status is still pending? Let us recheck it.

outdated


Simplify the execution of commands when an extra is already defined that lists the expected dependencies

How would this feature be useful?
I can define my e.g. testing dependencies in one place and then have all of my tooling that I run locally -- both on the command-line and via my editor -- and in CI pull from the same dependency spec.
The goal is for the common test/build/lint steps in Nox to be nothing more than specifying the command to execute, while dependency specification lives in the package details of the project so they are only defined once. This may only be truly feasible once PEP 621 gains traction.
Describe the solution you'd like
Couple options.

Command to install the extras.
Decorator for a session to install an extra based on the session's name.

Describe alternatives you've considered

Writing a script to auto-generate my noxfile.py.
Writing a module that I can import into my noxfile.py which will add the appropriate helper function or decorator.

Cool, so the idea is to have a command that can just process a pep 621 pyproject.toml and do the right thing?
@nox.package_session
def tests(session):
    # Before getting here Nox has already created a virtualenv and installed the package & it's dependencies specified in `pyproject.toml`.
    session.run("pytest", "tests")

We could have some customization here:
@nox.package_session(path="relative/path/to/pyproject.toml")

# Runs the session for each version of python available that's compatible with the package.
@nox.package_session(all_pythons=True)

Or am I misunderstanding?

Nope, you got it!


Fix Elasticsearch alerts

ElasticHeapUsage alert tries to reference the "name" label, without accessing the "labels" maps. This lead to this message:
msg="Error expanding alert template ElasticHeapUsage with data '{map[cluster:logsearch
 instance:logsearch bosh:bosh job:logsearch area:heap host:<IP_ADDRESS> name:elasticsearch_data/0] 0.93169611788588
56}': runtime error: invalid memory address or nil pointer dereference" source="alerting.go:200"

Thanks @aveyrenc


Consider splitting SDK into separately publishable layers

Our current SDK is pretty hight-level and opinionated -- is presupposes borsh serialization, strongly-typed wrappers for types, etc. While it is a great fit for the average use-case (or at least aspires to be one), one size doesn't fit all!
It might be useful to publish unopinionated subsets of the SDK, which just give bindings to the system APIs, but don't prescribe any particular style of contracts.
There's not huge specific benefits here, but this unlocks the ecosystem for serendipitous experimentation. If we publish low-level sdk bindings, someone from the ecosystem might decide to publish a better hight-level SDK than ours, and that can have a huge positive effect.
I can see three possible layers we might want to split out:
near-sys our sys.rs published as a crate.
near-api thin, no_std, no_alloc, safe wrapper over near-sys. nesdie is roughly this layer, but I think we also should get rid of alloc here, and use the APIs like:
pub fn register_len(register_id: u64) -> Option<u64> {
    let len = unsafe { sys::register_len(register_id) };
    if len == core::u64::MAX {
        None
    } else {
        Some(len)
    }
}

pub fn read_register(register_id: u64, buf: &mut [u8]) -> Result<usize, ()>{
    let len = register_len(register_id).ok_or(())?;
    if buf.len() < len { return Err(()); }
    unsafe { sys::read_register(register_id, buf.as_ptr() as u64) };
    Ok(len)
}

near-sdk opinionated, alloc wrapper around near-api.
This depends on specifics, but, if it is actually possible to provide zero-overhead fully safe wrapper around sys, we might merge near-sys and near-api crates into one.

cc https://github.com/near/nearcore/issues/4485 <- this is the kind of problem which might prevent us from shipping 100% unopinonated near-api layer.

cc near/nearcore#4485 <- this is the kind of problem which might prevent us from shipping 100% unopinonated near-api layer.

Honestly, I'm still a little confused about how this issue benefits the SDK other than just being able to move the validation of the buffer length from inside the wasm contract to the actual host function implementation. Is this what you mean as unopinionated, that this validation isn't part of that layer?
In the future, the new function signature would have to come under a new method name, correct? So if this is the case we can still ship this API layer and if this is changed on the runtime then we can just update the internals without changing the API as it's just a validation within the function?
Also, seems there are host functions that are not reflected in our syscalls, is there any reason not to include all if creating this common crate?

If we had
extern "C" {
  fn read_register(registed_id: u64, buf: *mut u8, buf_len: usize) -> usize;
}

we'd be able to provide safe, zero cost, no-std wrapper:
pub fn read(id: u64, buf: &mut [u8]) -> Result<usize>

The read function would do just one sys call.
With   fn read_register(registed_id: u64, buf: *mut u8) -> usize;, we can't have this. We have three suboptimal choices

A no-std safe function that does an extra syscal to do bounds check

pub fn read(id: u64, buf: &mut [u8]) -> Result<usize>

A safe function which doesn't duplicate systcalls, but requires an allocation

pub fn read(id: u64) -> Result<Vec<u8>>

An unsafe function without bounds checking:

pub unsafe fn read(id: u64, but: &mut [usize]) -> Result<usize>

In the future, the new function signature would have to come under a new method name, correct? So if this is the case we can still ship this API layer and if this is changed on the runtime then we can just update the internals without changing the API as it's just a validation within the function?

Yeah, we can go with "extra syscall" version now, and optimize it later.

Also, seems there are host functions that are not reflected in our syscalls, is there any reason not to include all if creating this common crate?

It makes sense to double check for each sepcific function why it isn't included. At least one (gas) shouldn't be exposed -- its a private impl detail of the runtime, which really shouldn't have been exposed at the first place, but that ship has sailed.

If we had
extern "C" {
  fn read_register(registed_id: u64, buf: *mut u8, buf_len: usize) -> usize;
}

we'd be able to provide safe, zero cost, no-std wrapper:
pub fn read(id: u64, buf: &mut [u8]) -> Result<usize>

The read function would do just one sys call.
With  fn read_register(registed_id: u64, buf: *mut u8) -> usize;, we can't have this. We have three suboptimal choices

A no-std safe function that does an extra syscal to do bounds check

pub fn read(id: u64, buf: &mut [u8]) -> Result<usize>

A safe function which doesn't duplicate systcalls, but requires an allocation

pub fn read(id: u64) -> Result<Vec<u8>>

An unsafe function without bounds checking:

pub unsafe fn read(id: u64, but: &mut [usize]) -> Result<usize>

In the future, the new function signature would have to come under a new method name, correct? So if this is the case we can still ship this API layer and if this is changed on the runtime then we can just update the internals without changing the API as it's just a validation within the function?

Yeah, we can go with "extra syscall" version now, and optimize it later.

Also, seems there are host functions that are not reflected in our syscalls, is there any reason not to include all if creating this common crate?

It makes sense to double check for each sepcific function why it isn't included. At least one (gas) shouldn't be exposed -- its a private impl detail of the runtime, which really shouldn't have been exposed at the first place, but that ship has sailed.

Yes, I suppose I meant to just indicate that even if the syscalls are "merged" in the future to include the bounds check (len checked against register_len in wasm) with the read_register call, the function signature could be:
pub fn read_register(register_id: u64, buf: &mut [u8]) -> usize

in both cases, where the implementation would just perform more syscalls to get length and panic until this change comes in, which would mean we wouldn't have an API breaking change on this new near-api. Is this reasoning sound?
I also noticed you wrapped the result in Result<usize> even when talking about when the change has been made, is this assuming there should always be a check before calling the syscall, or the error of insufficient buffer len being indicated in the u64 return as u64::MAX or something like this?


[Date] Values that overflow date boundaries are allowed

In this example, the months part is parsed as 99 months where BigQuery raises an error.
SELECT PARSE_DATE("%D", "99/01/24");

BigQuery
Emulator

Failed to parse input string "99/01/24"
"2032-03-01"

This has been mostly fixed in #135, but there is still no validation on calendar dates.
For example, February 29th, 2023 is able to be parsed even though it was not a leap. year.


Add a diagram for APIs guide

Feature request
The current APIs guide would be easier if there was a diagram to illustrate the solution sketch.
All guides could use diagrams in that section.
Use case
A diagram would make the section and solution sketch easier to consume.
UI Example
The following diagram from microservices.io is a good example.

/kind good-first-issue
/kind cleanup

I am interested to work on it.

Great one @tinubaby. It would be very good if some of those fonts are in white color.


docs: make categories collapsible

This PR changes the docs in a way that the sidebar categories can be collapsed. Previously this was not possible, as the sidebar component did not have a tree structure.

The sidebar items can also be accessed using keyboard only.

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS

mentioning the issues found so far:

attempt to open Theming guide results in broken page due to React rendering error (providing a sidebar screenshot to point to this sidebar item). The same applies to "Integrate Custom Components" entry

for some reason, padding of the main area (with component's description) is absent now.

was

now

tabbing through items of the topmost sidebar section causes them jumping:

@kuzhelov The first issue is actually present on master. I have reported it here #1618.

@kuzhelov The other two issues have been addressed. Thank you for spotting them.

Current state:

An indicator letting user know that the sections are not actually empty needs to be added.

The width of the sidebar should not change with opening sections (namely the Guides section)

Current state:

@layershifter please take a look and see if you like it.

Can we add some indicator about which page is currently shown? Like the text can be bolded or underlined or have a different color

Current page is now highlighted:

Can we add some indicator about which page is currently shown? Like the text can be bolded or underlined or have a different color

It's underlined now.