1.5.3, "Unexpected error. Please restart to continue syncing" after login

Hello,
I'm running Maestral on ElementaryOS 6.1. After upgrading to 1.5.3 it's begun to give me messages "Unexpected error. Please restart to continue syncing" just after I log in in the machine. Today's log shows the following:
2022-02-09 08:29:33 daemon INFO: Starting daemon
2022-02-09 08:29:33 manager INFO: Connected
2022-02-09 08:29:41 sync INFO: Fetching remote changes
2022-02-09 08:29:42 sync INFO: Indexing local changes...
2022-02-09 08:29:42 manager ERROR: Unexpected error
Traceback (most recent call last):
  File "/home/christian/.pyenv/versions/3.9.6/lib/python3.9/site-packages/maestral/manager.py", line 795, in _handle_sync_thread_errors
    yield
  File "/home/christian/.pyenv/versions/3.9.6/lib/python3.9/site-packages/maestral/manager.py", line 780, in startup_worker
    self.sync.upload_local_changes_while_inactive()
  File "/home/christian/.pyenv/versions/3.9.6/lib/python3.9/site-packages/maestral/sync.py", line 1609, in upload_local_changes_while_inactive
    events, local_cursor = self._get_local_changes_while_inactive()
  File "/home/christian/.pyenv/versions/3.9.6/lib/python3.9/site-packages/maestral/sync.py", line 1660, in _get_local_changes_while_inactive
    index_entry = self.get_index_entry(dbx_path_lower)
  File "/home/christian/.pyenv/versions/3.9.6/lib/python3.9/site-packages/maestral/sync.py", line 803, in get_index_entry
    entry = self._db_manager_index.get(dbx_path_lower)
  File "/home/christian/.pyenv/versions/3.9.6/lib/python3.9/site-packages/maestral/utils/orm.py", line 467, in get
    return self.create(**row)
  File "/home/christian/.pyenv/versions/3.9.6/lib/python3.9/site-packages/maestral/utils/orm.py", line 409, in create
    col = getattr(self.model, key)
AttributeError: type object 'IndexEntry' has no attribute 'symlink_target'
2022-02-09 08:29:42 manager INFO: Shutting down threads...
2022-02-09 08:29:42 sync INFO: Sync aborted
2022-02-09 08:29:42 manager INFO: Paused
2022-02-09 08:29:57 sync INFO: Sync aborted
2022-02-09 08:29:57 manager INFO: Paused
2022-02-09 08:34:44 main INFO: Migrating database after update from pre v1.5.3

Things seems to get back to normal without issues after restarting (maestral stop and maestral start).
It may be useful to know my computer dual boots ElementaryOS and Windows, so my Dropbox folder is on a separated NTFS partition which I use within both OSs -- but it's mounted at boot time (/etc/fstab), so I'm not sure if it's really related to some "symlink problem".
Thanks!

That looks suspiciously like trying to access the database with the daemon version 1.5.2.
One change from v1.5.3 is consistent handling of symlinks. This required adding a new column "symlink_target" to the database tables storing sync events and and index entries. It appears that after that column was added in your database, when first running v1.5.3, you started v1.5.2 again (maybe from a different venv?) and it complained because it does not know how to handle the new table layout.


Filtering string fields will not work when filter value consists of numbers

qs.parse({"foo":">1"}) results in {"foo":{"$gt":1}} and not {"foo":{"$gt":"1"}} where the '1' is converted to a Number field automatically. If the foo field is a string field in the database than this search query will find nothing.
I haven't tested it but this will probably also be true for booleans.
There should be a way to force the creation of a string filter for values that could also be a number or a boolean.

That is correct behaviour with the default settings. You can turn off automatic parsing of Numbers and Booleans by setting toNumber and toBoolean respectively to false like this:
const qs = new MongoQS({
  string: {
    toNumber: false,
    toBoolean: false,
  }
});

Sorry fo the late reply. This doesn't help the situation where you want to combine a filter on a number field and a string field like this:
qs.parse({"fooString":">1", "fooNumber":">1"}); where you expect:
{"fooString":{"$gt":"1"}, "fooNumber":{"$gt":1}}
Maybe it would help if you add single quotes to the syntax to aid in discriminating string fields from number fields. Like this:
qs.parse({"fooString":">'1'", "fooNumber":">1"}); This may need to be escaped on the url though.


Master

Update format of all sass to use 2 space indentation and idiomatic css.

Hi @mimoduo my preference is to use 4 spaces consistently in both SASS and CoffeeScript, I understand people have different preferences but for the main project repo I'm going to be sticking with 4.

Hey @anthonyjb you're quick! That makes sense. Anything I could do on the SASS end of things?

Hi @mimoduo - caught me at the right time :)
With regard to SASS I don't see the interface for the desktop version of the browser changing much in right now - the next major change will be adding support for smaller screen and touch devices as there's been quite a few requests for mobile/tablet support. Whilst mobile support is a fair way off on my list of things still to do if someone wanted to look at UI/UX for the interface on such devices that would be a real help - I'm quite to make the modifications to the JavaScript to support touch in the sort term.
Not sure how much your in to UI/UX design but even if your not clearly your SASS stuff is very neat so if you were able to lend your skills to a responsive version of the UI that would be awesome.

Hi @anthonyjb - awesome!
Sounds good.
Which method would you prefer for beginning a responsive version? My preference is min-width and having media queries directly within the selector. However, i'm open to anything! From a design standpoint we could see how well a condensed version works first yea?

This is the SASS I use to build responsive mixins on the getcontenttools.com website, I think it works well but this isn't my area of expertise to be honest so other recommendations are very welcome:
/* Responsive breakpoints */
$tablet-width: 768px;
$desktop-width: 1024px;

/*
These mixins make it easy to define blocks of CSS for the target devices, for
example:

    @include media-tablet {
        ...tablet CSS here...
    }

As a general rule the base CSS should target mobiles and conditional blocks
should be added for tablet and desktop devices. Don't apply this rule over
smaller more manageable code.
*/
@mixin media-mobile {
    @media (max-width: #{$tablet-width - 1}) {
        @content;
    }
}

@mixin media-tablet {
    @media (min-width: #{$tablet-width}) {
        @content;
    }
}

@mixin media-desktop {
    @media (min-width: #{$desktop-width}) {
        @content;
    }
}

With regard to design this is the really tricky bit, it wouldn't be to much work to make the editor work in a touch environment but making the UX great is a whole other matter and kind of why it didn't make it to the first release.
I was thinking on tablet we might look at docking the toobox top for portrait, right for landscape, with regard to mobile I think we might need to go on the basis that the toolbox is hidden until you select some kind of button to show it, select a tool at which point it's hidden again (but that doesn't sound ideal either).
Other considerations are what to do with the current dialogs, these are probably fine for tablet as is but for mobile maybe a fullscreen dialog that scrolls would work better?
What are your thoughts? Perhaps I should add an issue for responsive/touch support and open the discussion up?


Missing file count updates in get() and has()

After os.remove() in FileSystemCache.get() and FileSystemCache.has(), self._update_count() should be called.

Yeah, that seems to be the case. I'll probably roll it into #13 since it's a simple fix. Nice catch 👍🏻

done @hkcomori 🚀

@northernSage nice work!


docs(builtin-plugin): set recycleVideo default value to true

Update documentation.
Closes #1813.

Coverage increased (+0.02%) to 78.577% when pulling 9ddf3cc565bc036207baefcbf67f56273d1d5d37 on kslimani:doc-plugins into 4f717c1a4d4763ae7ede9a1070bf04257e88b41b on clappr:dev.

Thanks, @kslimani! 🍻


Detect ES_NIF

An ES_NIF(Número de Identificación Fiscal for Spain [ES]) is a Tax Identification Number ID that is assigned to a person or legal entity, such as a company, public institutions, etc. This number should be protected because it is the identifier for a person or legal entity when interacting in any way with the Spanish tax agency. An ES_NIF is necessary for making any kind of financial action, like purchasing a house, self-employment, creating a company, etc. It can also be used to obtain other legal licenses or do other legal procedures, like getting a driving license.
For more information:  and here
Will detect an id formatted like this  ES B000000. ES is an optional prefix. The NIF is a 9 digit ID. The first digit X in this case is used to describe the type of legal entity.
Will use ES B99416588 as a test example

Looks good


UI revamp for popup locations

Issue
Issue number - #236
PR type
Improve UI for popup.

Pull Request Test Coverage Report for Build 433

0 of 0   changed or added relevant lines in 0 files are covered.
28 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.2%) to 43.033%

Files with Coverage Reduction
New Missed Lines
%

file:/home/travis/build/AY1920S1-CS2103T-T10-4/main/src/main/java/seedu/address/ui/util/LocationPopup.java
6
0.0%

file:/home/travis/build/AY1920S1-CS2103T-T10-4/main/src/main/java/seedu/address/ui/ScheduleView.java
7
0.0%

file:/home/travis/build/AY1920S1-CS2103T-T10-4/main/src/main/java/seedu/address/ui/util/LocationsView.java
15
0.0%

Totals

Change from base Build 431:
-0.2%

Covered Lines:
3036

Relevant Lines:
7055

💛  - Coveralls


Quick question(non-ugent)

Is it possible to delpoy it though Google Colab, Azure, Runpod or Google VM?
It would be great if you could help me though this.

oh ummmmm can i jsut like run the code on a vm?


when I use '&' before Css selector,but the string is still black

I just copy the code these code from doc,but it doesn't work! does I do something wrong?
<!DOCTYPE html>

	<meta charset="utf-8">
	<title>Agility style-need-& </title>

Hey @phoebepei, looks like you are correct
I've gotten both
var obj = $$({}, '

Do this

', '& { color:red; }');

and
var obj = $$({}, '

Do this

', 'div { color:red; }');

to show red, but not
var obj = $$({}, '

Do this

', '& div { color:red; }');

the last example ( which is what isn't working, same as you provided ) generates the following html

Do this

@arturadib , looks like the wrong structure is generated ( notice each
 and
 get the "agility_1" class and both
's are closed off.

@tristanls , here is another exmaple in the document,
<!DOCTYPE html>

	<meta charset="utf-8">
	<title>Agility complex-need-& </title>

it works well......
I think the reason may be that div should be the root or div shouldn't be the descendant of other element not div?
I modified the previous example to be
<!DOCTYPE html>

	<meta charset="utf-8">
	<title>Agility style-need-& </title>

it works!

looks like the wrong structure is generated ( notice each  and  get the "agility_1" class and both 's are closed off.

That's a DOM limitation (not Agility's) and I completely missed that in the Docs!
(You can't insert block elements inside a paragraph, so the browser falls back to the structure you quoted, see http://www.w3.org/TR/html401/struct/text.html#h-9.3.1).
I've fixed the docs, thanks @phoebepei !


type ignore common.py

[ ] closes #xxxx (Replace xxxx with the GitHub issue number)
[ ] Tests added and passed if fixing a bug or adding a new feature
[ ] All code checks passed.
[ ] Added type annotations to new arguments/methods/functions.
[ ] Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

add type ignore in pandas/io/common.py back in that shouldn't have been removed


Better feedback when using restic copy

Output of restic version
restic 0.9.6 (v0.9.6-415-g97950ab8) compiled with go1.15.2 on linux/amd64

What should restic do differently? Which functionality do you think we should add?
When using restic copy, I feel like more feedback should be given to the user. Currently it prints one line about what snapshot/label it's operating on and then prints error messages it encounters. Additional info about what it's currently working on, and what %/amount of files it has left to work on would be very useful, even if it meant slower wait upfront.

What are you trying to do? What problem would this solve?
I'm currently trying to combine multiple repos I made previously into a single repo to reduce file size - they were made before I really understood the outline of restic repos and snapshots.

Did restic help you today? Did it make you happy in any way?
Restic is my goto for anyone looking for backup software suggestions - I love how easy it is to use while staying pretty faithful to the norms of terminal software. I also love how I can integrate it with rclone and backup to my not-so-well-known cloud provider as easily as the more famous ones.

Sounds like something the verbose option should do.

Printing a progress in percent would require running a lot of the processing steps twice. On the other hand, just printing the currently processed files names would be relatively simple to implement.

I'm currently trying to combine multiple repos I made previously into a single repo to reduce file size

Deduplication between snapshots which originate from different repositories will only work partially.

I am interested in this getting fixed up. What can I do to help? The PR looks like it only lacks approval.


Adding error catching

This way Gulp watch won't quit if there is a sass error

Great, wonder why I forgot to add that.


fix some misspells

Signed-off-by: kaiwentan<EMAIL_ADDRESS>

Current coverage is 51.21% (diff: 100%)

Merging #2165 into master will decrease coverage by 9.99%

@@             master      #2165   diff @@
==========================================
  Files           125        125
  Lines         11447      11447
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           7007       5863   -1144
- Misses         3552       4838   +1286
+ Partials        888        746    -142

Powered by Codecov. Last update 56b712f...30cb23f

LGTM


Articles not being added

When deploying to a raspberry pi 4 for testing, the articles were not being created. Each article would be skipped and subsequent retries would result in the message 'Article ****** is not present'.

After investigating this, the issue was caused by a hard-coded user_id (2) in the add_article function that did not match any user id's in the users table due to their only being one and that user id is 1.
I changed it to pass an argument to a parameter in the function called user_id and then replaced the hard-coded ud with that which has resolved the issue.


MAINT: tidy tests

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall First build on develop at 91.541%

Totals

Change from base Build<PHONE_NUMBER>:
91.5%

Covered Lines:
235850

Relevant Lines:
257644

💛  - Coveralls


chore(deps): update common-dev-assets digest to 28cb7f6

This PR contains the following updates:

Package
Update
Change

common-dev-assets
digest
b114e09 -> 28cb7f6

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.0.11 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Create LICENSE

The pkg should bear an actual LICENSE, else vendoring is a bit sketch.

It's already in the Readme.  This is bikeshedding.

It isn't. I've checked this with lawyers multiple times. Unfortunately today we still have to include the full license text.
—
Sent from Mailbox
On Fri, Apr 17, 2015 at 9:57 AM, Barry Allard<EMAIL_ADDRESS>wrote:

It's already in the Readme.  This is bikeshedding.
Reply to this email directly or view it on GitHub:
https://github.com/steakknife/hamming/pull/3#issuecomment-94027015

Orrick says it's fine.  It's Big4 clipboard auditors that insist on business theater being "safe" because their checkboxes them so.   If it makes the auditors feel better, I'll drop a link in.
—
Sent from Mailbox
On Fri, Apr 17, 2015 at 10:50 AM, Juan Batiz-Benet
<EMAIL_ADDRESS>wrote:

It isn't. I've checked this with lawyers multiple times. Unfortunately today we still have to include the full license text.
—
Sent from Mailbox
On Fri, Apr 17, 2015 at 9:57 AM, Barry Allard<EMAIL_ADDRESS>wrote:

It's already in the Readme.  This is bikeshedding.
Reply to this email directly or view it on GitHub:
https://github.com/steakknife/hamming/pull/3#issuecomment-94027015

Reply to this email directly or view it on GitHub:
https://github.com/steakknife/hamming/pull/3#issuecomment-94038369

Funny, it's Orrick that told me it's needed :)
—
Sent from Mailbox
On Fri, Apr 17, 2015 at 10:54 AM, Barry Allard<EMAIL_ADDRESS>wrote:

Orrick says it's fine.  It's Big4 clipboard auditors that insist on business theater being "safe" because their checkboxes them so.   If it makes the auditors feel better, I'll drop a link in.
—
Sent from Mailbox
On Fri, Apr 17, 2015 at 10:50 AM, Juan Batiz-Benet
<EMAIL_ADDRESS>wrote:

It isn't. I've checked this with lawyers multiple times. Unfortunately today we still have to include the full license text.
—
Sent from Mailbox
On Fri, Apr 17, 2015 at 9:57 AM, Barry Allard<EMAIL_ADDRESS>wrote:

It's already in the Readme.  This is bikeshedding.
Reply to this email directly or view it on GitHub:
https://github.com/steakknife/hamming/pull/3#issuecomment-94027015

Reply to this email directly or view it on GitHub:
https://github.com/steakknife/hamming/pull/3#issuecomment-94038369

Reply to this email directly or view it on GitHub:
https://github.com/steakknife/hamming/pull/3#issuecomment-94039036

LOL!!!  I'll run it by two other IP lawyer friends.
—
Sent from Mailbox
On Fri, Apr 17, 2015 at 10:56 AM, Juan Batiz-Benet
<EMAIL_ADDRESS>wrote:

Funny, it's Orrick that told me it's needed :)
—
Sent from Mailbox
On Fri, Apr 17, 2015 at 10:54 AM, Barry Allard<EMAIL_ADDRESS>wrote:

Orrick says it's fine.  It's Big4 clipboard auditors that insist on business theater being "safe" because their checkboxes them so.   If it makes the auditors feel better, I'll drop a link in.
—
Sent from Mailbox
On Fri, Apr 17, 2015 at 10:50 AM, Juan Batiz-Benet
<EMAIL_ADDRESS>wrote:

It isn't. I've checked this with lawyers multiple times. Unfortunately today we still have to include the full license text.
—
Sent from Mailbox
On Fri, Apr 17, 2015 at 9:57 AM, Barry Allard<EMAIL_ADDRESS>wrote:

It's already in the Readme.  This is bikeshedding.
Reply to this email directly or view it on GitHub:
https://github.com/steakknife/hamming/pull/3#issuecomment-94027015

Reply to this email directly or view it on GitHub:
https://github.com/steakknife/hamming/pull/3#issuecomment-94038369

Reply to this email directly or view it on GitHub:
https://github.com/steakknife/hamming/pull/3#issuecomment-94039036

Reply to this email directly or view it on GitHub:
https://github.com/steakknife/hamming/pull/3#issuecomment-94039345

(The dangers of everyone using the same legal shop in the valley.)
—
Sent from Mailbox
On Fri, Apr 17, 2015 at 10:56 AM, Juan Batiz-Benet
<EMAIL_ADDRESS>wrote:

Funny, it's Orrick that told me it's needed :)
—
Sent from Mailbox
On Fri, Apr 17, 2015 at 10:54 AM, Barry Allard<EMAIL_ADDRESS>wrote:

Orrick says it's fine.  It's Big4 clipboard auditors that insist on business theater being "safe" because their checkboxes them so.   If it makes the auditors feel better, I'll drop a link in.
—
Sent from Mailbox
On Fri, Apr 17, 2015 at 10:50 AM, Juan Batiz-Benet
<EMAIL_ADDRESS>wrote:

It isn't. I've checked this with lawyers multiple times. Unfortunately today we still have to include the full license text.
—
Sent from Mailbox
On Fri, Apr 17, 2015 at 9:57 AM, Barry Allard<EMAIL_ADDRESS>wrote:

It's already in the Readme.  This is bikeshedding.
Reply to this email directly or view it on GitHub:
https://github.com/steakknife/hamming/pull/3#issuecomment-94027015

Reply to this email directly or view it on GitHub:
https://github.com/steakknife/hamming/pull/3#issuecomment-94038369

Reply to this email directly or view it on GitHub:
https://github.com/steakknife/hamming/pull/3#issuecomment-94039036

Reply to this email directly or view it on GitHub:
https://github.com/steakknife/hamming/pull/3#issuecomment-94039345

I'll have to bash some heads and get a free lunch out of it.  Just chatted with a gal that specializes in licensing and confirmed with a second source. (I also knew the guy that wrote the Orielly book on it, but sadly he passed away.)  The answer is related to the interpretation of "clear intent."  It could be argued that a couple words in the Readme isn't obvious enough, so just enough overkill to do this once would be boilerplate in the .go's and an MIT-LICENSE file.  (I'll forward this back and see what they say.).
Case study won't hear about in any bschool because it contains privileged info: A gigadollar tort suit related to a petrochem co everyone knows hinged on an expert witness intepretation of safety codes meaning of a comma ("and" or "or"). It was "or," the plantiffs wanted "and."
—
Sent from Mailbox
On Fri, Apr 17, 2015 at 10:58 AM, Barry Allard<EMAIL_ADDRESS>wrote:

(The dangers of everyone using the same legal shop in the valley.)
—
Sent from Mailbox
On Fri, Apr 17, 2015 at 10:56 AM, Juan Batiz-Benet
<EMAIL_ADDRESS>wrote:

Funny, it's Orrick that told me it's needed :)
—
Sent from Mailbox
On Fri, Apr 17, 2015 at 10:54 AM, Barry Allard<EMAIL_ADDRESS>wrote:

Orrick says it's fine.  It's Big4 clipboard auditors that insist on business theater being "safe" because their checkboxes them so.   If it makes the auditors feel better, I'll drop a link in.
—
Sent from Mailbox
On Fri, Apr 17, 2015 at 10:50 AM, Juan Batiz-Benet
<EMAIL_ADDRESS>wrote:

It isn't. I've checked this with lawyers multiple times. Unfortunately today we still have to include the full license text.
—
Sent from Mailbox
On Fri, Apr 17, 2015 at 9:57 AM, Barry Allard<EMAIL_ADDRESS>wrote:

It's already in the Readme.  This is bikeshedding.
Reply to this email directly or view it on GitHub:
https://github.com/steakknife/hamming/pull/3#issuecomment-94027015

Reply to this email directly or view it on GitHub:
https://github.com/steakknife/hamming/pull/3#issuecomment-94038369

Reply to this email directly or view it on GitHub:
https://github.com/steakknife/hamming/pull/3#issuecomment-94039036

Reply to this email directly or view it on GitHub:
https://github.com/steakknife/hamming/pull/3#issuecomment-94039345

Fixed as of c88edec765c5431658d6cf07f63f25cde51c1abf

thanks @steakknife!

and-- that's sadly hilarious. :cry: :expressionless:

TGIF :beers: :wine_glass: :coffee:


Specify status codes on rate limit errors

Summary
This PR sets the correct HTTP status codes for rate limit errors while creating Accounts or Counterfactual Safes.
Changes

Makes LimitReachedError extend HttpException, and adds HTTP status code 429.
Creates new HttpException  subclasses: CounterfactualSafesCreationRateLimitError and AccountsCreationRateLimitError.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

8 of 14 (57.14%)  changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 46.713%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/datasources/accounts/accounts.datasource.ts
1
2
50.0%

src/datasources/accounts/counterfactual-safes/counterfactual-safes.datasource.ts
1
2
50.0%

src/datasources/balances-api/zerion-balances-api.service.ts
0
1
0.0%

src/datasources/network/entities/errors/limit-reached.error.ts
2
3
66.67%

src/domain/accounts/counterfactual-safes/errors/counterfactual-safes-creation-rate-limit.error.ts
2
3
66.67%

src/domain/accounts/errors/accounts-creation-rate-limit.error.ts
2
3
66.67%

Totals

Change from base Build<PHONE_NUMBER>2:
0.02%

Covered Lines:
4762

Relevant Lines:
8247

💛  - Coveralls


Scroll jumps to start whenever data changes or on hot reload

SmoothListView.builder, adding elements to the data makes the view jump to the starting position, also when hot reloading.

Thanks again for taking the time to submit an issue.
The issue making the list jump to the starting position when adding an element is also solved with the new version of the package, let me know if it's okay for you.
The fact that the list jumps to the starting position when hot reloading is its normal behaviour, since a hot reload causes the widget tree to be rebuilt, and so is the SmoothListView. A classic ListView behaves the same.

Thanks for fixing


Questions re If functions

Your examples:
if it's the 100th day of the year
<%if dayofyear = 100: text to be entered%>
How would you format: <%if dayofyear = July 3: text to be entered%>
Does 7/3 work?
if it's either january or a monday
<%if month = 100|| if dayofweek = 1|| : text to be entered%>
I don't understand: if month = 100
Should that have been: ifmonth = 1 ?

At the moment 3rd july would be 184, but I agree this is an oversight on my part and i'll try and improve the experience here.
Fixed the readme as well, it was supposed to be the month is equal to 1.


fixed #1551

Docs Build status updates of commit 44992e2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/create-packages/Prerelease-Packages.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@nkolev92 Nikolche, can you take a quick look? Thx.

Docs Build status updates of commit b99880c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/create-packages/Prerelease-Packages.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


requestAnimationFrame scheduler

On the end it seems not very important, so I close the issue for now.


Fix get iso currency param

Issue #44

thanks @giorgiopogliani for the PR.
Awesome! The logic looks ok, but I think your local develop branch was old, could you please rebase your giorgiopogliani:fix/set-currency branch with updated develop branch and force push it again. Thanks

great, thanks


Fix readme CI badge

It's always green, even when CI fails. This new one is copied from the actions tab
And also the opencollective badges. I broke those by changing the heading text

Thanks!


Design Monthly Email template

We need a design of a monthly email template that shows:

Name of the Collective
Budget Available
New Donation
New backers/Sponsors
Expenses
Fees
Did you know? / changelog section

@erickrico I'm assigning this to you. :)

hey let me know if this works

this is done.


New Relic metric shows incorrect value

Report
I'm having issues using New Relic queries properly. The current value shown in HPA does not match the response in New Relic.
The reported value is too high, and the pods are stuck at their maximum capacity.
I went over previous GitHub issues/discussions about the same problem, and unfortunately, the documentation/FAQs didn't help in my case:
https://github.com/kedacore/keda/issues/2740
https://github.com/kedacore/keda/discussions/2451
Expected Behavior
I expect the behavior to match the query result in New Relic and the HPA to scale my deployment according to the query results.
Actual Behavior

The query I'm running:
SELECT rate(count(apm.service.transaction.duration), 1 minute) FROM Metric WHERE appName = 'my-app-name' TIMESERIES
HPA output:
NAME                             REFERENCE                          TARGETS              MINPODS   MAXPODS   REPLICAS   AGE
keda-my-app   Deployment/my-app   340141296/50 (avg)   1         5         5          3h56m
As you can see from the graph - the value of the NRQL is around 100 - because I'm using the default average behavior it should be ~20 (divided by 5 pods) which is well below the threshold (50).
I still can't figure out where the value of 340141296 came from, but because of this high value, the HPA is always configured for the maximum amount of replicas.
Steps to Reproduce the Problem
Add a New Relic scaler with a simple APM query for RPM (requests per minute)
Logs from KEDA operator
2023-11-23T19:50:37Z	INFO	Reconciling ScaledObject	{"controller": "scaledobject", "controllerGroup": "keda.sh", "controllerKind": "ScaledObject", "ScaledObject": {"name":"my-app-name","namespace":"default"}, "namespace": "default", "name": "my-app-name", "reconcileID": "2db87bd4-7cb1-4728-ae5f-e753c8131557"}
2023-11-23T19:50:52Z	INFO	Reconciling ScaledObject	{"controller": "scaledobject", "controllerGroup": "keda.sh", "controllerKind": "ScaledObject", "ScaledObject": {"name":"my-app-name","namespace":"default"}, "namespace": "default", "name": "my-app-name", "reconcileID": "d35a43b5-456f-4e8c-9811-eb07ee961220"}
2023-11-23T19:50:52Z	INFO	Reconciling ScaledObject	{"controller": "scaledobject", "controllerGroup": "keda.sh", "controllerKind": "ScaledObject", "ScaledObject": {"name":"my-app-name","namespace":"default"}, "namespace": "default", "name": "my-app-name", "reconcileID": "a511b801-08b4-40a0-84f4-b09ba845b6b7"}
2023-11-23T19:51:09Z	INFO	Reconciling ScaledObject	{"controller": "scaledobject", "controllerGroup": "keda.sh", "controllerKind": "ScaledObject", "ScaledObject": {"name":"my-app-name","namespace":"default"}, "namespace": "default", "name": "my-app-name", "reconcileID": "4059d985-c9d4-45b6-8f0a-1d32464ac682"}
2023-11-23T19:51:25Z	INFO	Reconciling ScaledObject	{"controller": "scaledobject", "controllerGroup": "keda.sh", "controllerKind": "ScaledObject", "ScaledObject": {"name":"my-app-name","namespace":"default"}, "namespace": "default", "name": "my-app-name", "reconcileID": "a274d10e-daa8-4507-9d4f-317b79e55488"}
2023-11-23T19:52:10Z	INFO	Reconciling ScaledObject	{"controller": "scaledobject", "controllerGroup": "keda.sh", "controllerKind": "ScaledObject", "ScaledObject": {"name":"my-app-name","namespace":"default"}, "namespace": "default", "name": "my-app-name", "reconcileID": "36c77231-eb44-4e0a-89cf-1aa049832a43"}

Scaled object status:
Status:
  Conditions:
    Message:  ScaledObject is defined correctly and is ready for scaling
    Reason:   ScaledObjectReady
    Status:   True
    Type:     Ready
    Message:  Scaling is performed because triggers are active
    Reason:   ScalerActive
    Status:   True
    Type:     Active
    Message:  No fallbacks are active on this scaled object
    Reason:   NoFallbackFound
    Status:   False
    Type:     Fallback
    Status:   Unknown
    Type:     Paused

KEDA Version
2.12.0
Kubernetes Version
1.27
Platform
Amazon Web Services
Scaler Details
New Relic
Anything else?
No response

Hello,
Could you share your ScaledObject please?

@JorTurFer Sure, here it is:
apiVersion: keda.sh/v1alpha1
kind: ScaledObject
metadata:
  annotations:
    meta.helm.sh/release-name: my-app-name
    meta.helm.sh/release-namespace: default
  creationTimestamp: "2023-11-23T19:50:36Z"
  finalizers:
  - finalizer.keda.sh
  generation: 1
  labels:
    app.kubernetes.io/managed-by: Helm
    scaledobject.keda.sh/name: my-app-name
  name: my-app-name
  namespace: default
  resourceVersion: "<VERSION>"
  uid: <UUID>
spec:
  maxReplicaCount: 5
  minReplicaCount: 1
  scaleTargetRef:
    name: my-app-name
  triggers:
  - authenticationRef:
      name: keda-newrelic-integration
    metadata:
      noDataError: "true"
      nrql: SELECT rate(count(apm.service.transaction.duration), 1 minute) FROM Metric
        WHERE appName = 'my-app-name' TIMESERIES
      threshold: "50"
    type: new-relic
status:
  conditions:
  - message: ScaledObject is defined correctly and is ready for scaling
    reason: ScaledObjectReady
    status: "True"
    type: Ready
  - message: Scaling is performed because triggers are active
    reason: ScalerActive
    status: "True"
    type: Active
  - message: No fallbacks are active on this scaled object
    reason: NoFallbackFound
    status: "False"
    type: Fallback
  - status: Unknown
    type: Paused
  externalMetricNames:
  - s0-new-relic
  health:
    s0-new-relic:
      numberOfFailures: 0
      status: Happy
  hpaName: keda-my-app-name
  lastActiveTime: "2023-11-26T17:48:43Z"
  originalReplicaCount: 1
  scaleTargetGVKR:
    group: apps
    kind: Deployment
    resource: deployments
    version: v1
  scaleTargetKind: apps/v1.Deployment

Are you scrapping prometheus metrics from KEDA? There is a metric that can help as it shows the value recovered from KEDA: keda_scaler_metrics_value.
Do you see any error event in the HPA or ScaledObject?

@JorTurFer I didn't see any error event in HPA/ScaledObject.
I can look into starting scraping Prometheus metrics from KEDA tomorrow, I'll update afterward.
Any other suggestions?
Thanks!

@JorTurFer Hey, I added the metrics, and below is the value for keda_scaler_metrics_value. It seems like it doesn't get the value I'm getting when I make the same query through the UI.

I'm checking the code and I see this comment // Only use the first result from the query, as the query should not be multi row
Is your query a multi row query?
From your original picture I understand that yes

But it's true that I've no idea about NR and also that doesn't mean that it has to fail in this case, just for digging in the issue

The query is not multi-row, I tried to add an identical query to the graph previously to see if it makes a difference.
This is how the graph looks right now:

This is really weird. The querying code is quite simple:
https://github.com/kedacore/keda/blob/5397894a42229efcc608311e055d1aa140ae7613/pkg/scalers/newrelic_scaler.go#L154-L171
I don't see where the issue can be as the SDK is just a direct pass through of the provided query. Other upstreams allow more configurations about the time windows and those stuff, but not in NR.
Are you golang developer by chance? I ask to test the query directly from your local using the SDK to directly query NR and try to discover if the value is wrongly recovered by the SDK, if KEDA is doing something wrong, or what's happening

I'm not a golang developer but I can try to test it out.
I tried to change the query to a simple query that selects a static value SELECT 3 FROM Metric TIMESERIES - which worked well:
keda-hpa-my-app                     Deployment/my-app                              3/50 (avg)        1         5         1          4d2h

I then changed the query back to the query I wanted to use and checked the HPA values, it was set to the right value (27), but I checked the status 5 seconds later and it changed back to a huge value which has nothing to do with my query:
keda-hpa-my-app                     Deployment/my-app                              27/50 (avg)       1         5         1          4d2h
keda-hpa-my-app                     Deployment/my-app                              425280165/50 (avg)   1         5         4          4d2h

I will try to debug it with other queries to see if I can understand what type of queries are experiencing this behavior.

let me know if I can help you with something else :(
I don't see why this can be happening being honest

I can confirm that this behavior is consistent with all queries.
I tested with the query SELECT 4 FROM Metric TIMESERIES and changed it to SELECT 5 FROM Metric TIMESERIES.
I kept getting the HPA values each second and this is the result:

It seems like right after I change to a new query it works for a few seconds, and then the value changes to a huge number that has nothing to do with the queries I'm testing.

So, maybe KEDA is mixing somehow the time and the value? I mean, if KEDA is returning the epoch time as value, it can justify current scenario (and we have a starting point for the fix)

I am experiencing the exact same behaviour when using a TIMESERIES query. Works just fine without TIMESERIES, in other words no problem when the response is a single value.

Maybe we should clarify this in docs to prevent issues to newcomers. Are you willing to update docs?

@JorTurFer We definitely should clarify it in the doc.
Right now, the docs example is using TIMESERIES, that's why I added it in the first place, see here: https://keda.sh/docs/2.11/scalers/new-relic/#trigger-specification
I can confirm that omitting the TIMESERIES made keda_scaler_metrics_value report the right value and it fixed my issue.

Could you open a PR updating docs?

Done 😄
https://github.com/kedacore/keda-docs/pull/1267

I'm trying to benchmark my service right now, and even though it looks better now - I still see a mismatch between the value of the query I'm using and the keda_scaler_metrics_value metric.

This mismatch is causing my service to not scale fast enough.
Any ideas about what might be the issue?

The only option that comes to my mind is that the chart is with TIMESERIES and with KEDA you don't use it :/
Have you printed the query without TIMESERIES?

Do you have just a single ScaledObject with a single trigger? How does the query work? I mean, is your query SELECT latest(keda_scaler_metric_value) .... filtering somehow other metrics from KEDA? each trigger (from all the ScaledObjects/ScaledJobs) generates its own timeseries splittable by labels

I have another question, what does count affect in your APM query? (Just to understand how it works), to know the amount of request you are counting the duration traces over the time, right?

I have a single ScaledObject with a single trigger as I'm just testing the New Relic scaler functionality right now.
My query in the last picture I sent was SELECT count(apm.service.transaction.duration) FROM Metric WHERE appName = 'my-app'.
In this query - count is just counting the number of metrics reported. The original query was SELECT rate(count(apm.service.transaction.duration), 1 minute) FROM Metric WHERE appName = 'my-app" which should have given me the amount of requests the app got each minute.

it's weird because during the first minutes it looks correct, and suddenly the metric grows a lot :/
Would you try the query using the SDK directly? would you be willing to do it? I can prepare a sample project just for pressing F5 using VSC and devcontainers

@JorTurFer Sure, I'll need your help to point me in the right direction, but I don't mind testing it out using the SDK 😄

@JorTurFer I was able to make the query value align with the TIMESERIES query. For some reason when I tested it yesterday, I didn't get the same value when I made the query manually, maybe I had something wrong with the query.
Anyway, I realized that the reason the TIMESERIES query gets different values is that it breaks down the query by the minute, which means each dot on the graph is calculated for the previous minute.
After I added SINCE 1 MINUTE AGO to the query, keda-operator gets the same value as I'm getting in the query.
I didn't find anything in the NR documentation that states exactly that, but I'll keep looking it up and open a PR to clarify this undocumented behavior.
Hope you enjoy KCD!

I think we can close the issue, I'm not sure if we should adjust the documentation or not, as apparently, this is the expected New Relic behavior.

I think that at least we can add a note on the scaler announcing this for newcomers. Something like:

NOTE: Default behaviour takes into account last 30 minutes for the query and it can produce unexpected responses. You could be interested on reducing the scope to 1 minute adding SINCE 1 MINUTE AGO to the statement

WDYT?
Would you be willing to open a PR to docs repo?

Yeah, please add this note to the docs, maybe together with an example of the query.

I'll open a PR later today with a clarification

Created this PR: https://github.com/kedacore/keda-docs/pull/1280
Preview: https://deploy-preview-1280--keda.netlify.app/docs/2.12/scalers/new-relic/
Will appreciate a review 😄

Thanks for your patience, your effort and your contribution! :heart:


Replace LazyRecord with Maghead

https://github.com/corneltek/LazyRecord

The fast ORM for PHP. (This is a history repo, please visit maghead/maghead)

Is Maghead actively developed? It seems like there hasn't been a release or commit in two years. It might be better to just remove LazyRecord.

I've removed LazyRecord.


[11.x] Add append and remove with Conditionable trait

This PR introduces the append and remove functionalities to use the Conditionable trait within the In and NotIn rule.
Before:
$request->validate([
    'zones' => [
        'required',
        Rule::when(
            $request->user()->isAdmin(),
            fn() => Rule::in(['first-zone', 'second-zone']),
            fn() => Rule::in(['first-zone']),
        ),
    ],
]);

After:
$request->validate([
    'zones' => [
        'required',
        Rule::in(['first-zone', 'second-zone'])->when(
            $request->user()->isAdmin(),
            fn() => $rule->remove('first-zone'),
            fn() => $rule->append('other-zone'),
        ),
    ],
]);

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.


clangd can't find included header (msys2/mingw)

I am using vim and its extension coc.nvim to create my IDE-like vim. To let coc.nvim support clangd, I also  install coc-clangd, the extension of coc.nvim. I am on Windows and use msys2/mingw platform to create my IDE-like vim. I have an ARM MCU project, it's a cross-platform project, and it's makefile-based. I succeeded installing coc.nvim and coc-clangd and all their requirements, and I use compiledb to generate compile_commands.json for my project. But it seems clangd cannot find header I include in my source code.  For example, I include the header main.h in main.c , and coc.nvim complained main.h file not found [clangd:], also, for struct defined in header, coc.nvim complained unknown type name XXX [clangd:]. Is there anyone here could help me debug this problem? I get clangd from msys2 package mingw-w64-x86_64-clang-tools-extra.
Here is the part of compile_commands.json related to main.c
{
  "directory": "/c/Users/XXXX/Desktop/XXXX_project",
  "arguments": [
   "arm-none-eabi-gcc",
   "-c",
   "-mcpu=cortex-m7",
   "-mthumb",
   "-mfpu=fpv5-d16",
   "-mfloat-abi=hard",
   "-DUSE_HAL_DRIVER",
   "-DSTM32F765xx",
   "-IInc",
   "-IDrivers/STM32F7xx_HAL_Driver/Inc",
   "-IDrivers/STM32F7xx_HAL_Driver/Inc/Legacy",
   "-IMiddlewares/ST/STM32_USB_Device_Library/Core/Inc",
   "-IMiddlewares/ST/STM32_USB_Device_Library/Class/CDC/Inc",
   "-IDrivers/CMSIS/Device/ST/STM32F7xx/Include",
   "-IDrivers/CMSIS/Include",
   "-O0",
   "-Wall",
   "-fdata-sections",
   "-ffunction-sections",
   "-g",
   "-gdwarf-2",
   "-MMD",
   "-MP",
   "-MFbuild/main.d",
   "-Wa,-a,-ad,-alms=build/main.lst",
   "Src/main.c",
   "-o",
   "build/main.o"
  ],
  "file": "Src/main.c"
 },

directory path mentioned in the compile commands looks suspicious. it doesn't seem like a real directory and clangd tries to find headers relative to that.
could you also provide clangd logs, while passing -log=verbose to clangd as a command line flag?

Using coc.nvim command CocInfo, I can get clangd log:
## Output channel: clangd log

I[18:09:24.032] <-- initialize(0)
I[18:09:24.034] --> reply:initialize(0) 1 ms
I[18:09:24.037] <-- initialized
I[18:09:24.037] unhandled notification initialized
I[18:09:24.043] <-- textDocument/didOpen
I[18:09:24.044] Failed to find compilation database for \c\Users\iscre\Desktop\paperproj_openmv_m7_cubemx\Src\main.c
I[18:09:24.044] --> textDocument/clangd.fileStatus
I[18:09:24.044] Updating file \c\Users\iscre\Desktop\paperproj_openmv_m7_cubemx\Src\main.c with command [\c\Users\iscre\Desktop\paperproj_openmv_m7_cubemx\Src] D:\msys64\mingw64\bin\clang \c\Users\iscre\Desktop\paperproj_openmv_m7_cubemx\Src\main.c
I[18:09:24.044] Couldn't set working directory when creating compiler invocation.
I[18:09:24.048] Couldn't set working directory when building the preamble.
I[18:09:24.086] Couldn't set working directory when building the preamble.
I[18:09:24.099] Dropped diagnostic outside main file: : too many errors emitted, stopping now
I[18:09:24.100] --> textDocument/publishDiagnostics
I[18:09:24.101] --> textDocument/clangd.fileStatus

The file path in log looks not right. I run vim and all its environment on msys2 shell, it seems that msys2 will automatically do some unix-style dos-style path conversion. Maybe this is the reason why path go wrong?

i suppose you would need to invoke compiledb in a non-msys2 environment. compile_commands.json should contain logical windows paths(e.g. C:\Users), instead of remapped msys2 paths(e.g /c/users)

this is duplicate of https://github.com/clangd/clangd/issues/291

I had tried to change file path in compile_commands.json. The same problem still exists. Like the answer in #291 , it seems that the problem is caused by msys shell. In msys2, there are two different subsystem: msys and mingw, the program in first subsystem accept and generate unix-style path, the program in second subsystem accept and generate dos-style path. However, whichever subsystem you choose to enter msys2, the shell is always a msys shell, it could accept dos-style path (the path seperator \ needs to be replaced by /), but it always output unix-style path by default.
Even changing file path in compile_commands.json, coc.nvim also has chance to send unix-style file path  to the mingw version clangd, because my vim is a msys subsystem program, and I run it on msys shell.
Now I am using a native Windows gvim, and the mingw subsystem of msys2 as its backend. Now clangd works.


bump up version

Codecov Report

Merging #2679 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2679      +/-   ##
============================================
- Coverage     50.23%   50.19%   -0.04%
+ Complexity     2061     2059       -2
============================================
  Files           413      413
  Lines         12644    12644
  Branches       1292     1292
============================================
- Hits           6352     6347       -5
- Misses         5844     5849       +5
  Partials        448      448

Impacted Files
Coverage Δ
Complexity Δ

...work/apollo/biz/message/DatabaseMessageSender.java
56.25% <0%> (-10.42%)
6% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff39257...175015a. Read the comment docs.

Coverage decreased (-0.04%) to 53.741% when pulling 175015a74c1fd3b4292d08403d2a270333562826 on nobodyiam:version-1.6.0-snapshot into ff392573ef64dc3144051cd41a7fb09551ae733a on ctripcorp:master.


I got Access to the resource is forbidden when calling the GET_FLAT_FILE_ACTIONABLE_ORDER_DATA_SHIPPING report.

I got Access to the resource is forbidden when calling the GET_FLAT_FILE_ACTIONABLE_ORDER_DATA_SHIPPING report.
error:  {
code: 'Unauthorized',
message: 'Access to the resource is forbidden',
details: ''
}
Code:

Can you please guide me to move further on it?

Hi @surbhi-ctas,
the reason is that the report is restricted, see here. You will need to pass a RDT (Restricted data token), which also requires permission to access PII (personally identifiable information) first.

@amz-tools Do you guys have an example for fetching a RDT and then using it download restricted reports?


altair: Respect NIXOS_OZONE_WL to enable Wayland mode

Description of changes
Enables support for NIXOS_OZONE_WL similar to signal-desktop:
https://github.com/NixOS/nixpkgs/blob/f6401f26d06675f1c6ccfd0b5d2f676643dac68e/pkgs/applications/networking/instant-messengers/signal-desktop/generic.nix#L155
Closes #255263
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 258576 run on aarch64-darwin 1

This has been tested by original issue reporter.


Not working with the latest version of unity 2017.3.1

Thank you for the great effort
I am trying to run the 2017.3 branch but all i get is white feed. when I debug, inside:   CameraStreamHelper.Instance.GetVideoCaptureAsync(OnVideoCaptureCreated);
the videocapture is coming null
Any idea?

So the issue is the version of Unity.
This is not working with the latest version of unity 2017.3.1
Shall I close this issue or its possible that anyone found a solution for that?

Maybe leave it open and rename the title of the issue :)
Don't close it until it's fixed, seems like an important one to leave up :)

Any status on if there's been a resolution yet? I'd love to adopt this, but we'd rather not roll back versions.

Hi, did something changed with Unity 2017.4.4f1  ?
thanks
Victor

Hi Victor,
I am currently working on Unity 5.6.3p2 and I didn't have time to check if the issue is fixed with the new version. if you give it a try let me know
Thanks

works again in Unity 2017.4.5f1 with
.Net scripting Backend
Scripting Runtime .Net 3.5
Api .Net 4.6
regards

Hoping to upgrade everything to work on 2018.2. .NET Scripting Backend is being deprecated and the DLLs don't work with IL2CPP (https://docs.unity3d.com/Manual/windowsstore-plugins-il2cpp.html). I gotta untangle all this.

Oh, I guess you maybe you can just include the .cs files directly into the project instead?
Losing nice cross-platform management of the managed DLL :/

It seems like I could get rid of the DLLs and simplify things. Except that code has references to the Windows namespace, so I would basically have to wrap large portions of this codebase in a directive that would disable the code in Unity, then it would not even compile until the Unity project's Build step. What do you think about that?

I've discovered the the DLLs ONLY work with IL2CPP, but .Net Scripting Backend is being deprecated anyway. Now I'm debugging what appears to be a change in how MSFT wants us to access the camera frames.

So if i want to get it up and running with the new Hololens update i should change the dll to IL2CPP?

Hello any news about the 2018.2 version of the lib ?
On the 2018.2 branch there is only the compiled version of the lib.
Can we get the code of the lib updated ?

@motionsmith I have been working recently on trying to get this working on 2018.2 using IL2CPP since .NET is being deprecated. To make things easier for myself untangled the dlls and wrapped it in compiler directives. But for some reason I can not, for the life of me get, past this "No capture devices available" when initializing the MediaCapture. I tried dumbing it down as much as possible into:

var allFrameSourceGroups = await MediaFrameSourceGroup.FindAllAsync();

        var candidateFrameSourceGroups = allFrameSourceGroups.Where(group => group.SourceInfos.Any((a) => a.SourceKind == MediaFrameSourceKind.Color && a.MediaStreamType == MediaStreamType.VideoPreview));
        var selectedGroup = candidateFrameSourceGroups.First();

        _mediaCapture = new MediaCapture();

        var mediaCaptureInitSettings = new MediaCaptureInitializationSettings()
        {
            SourceGroup = selectedGroup,
            SharingMode = MediaCaptureSharingMode.ExclusiveControl,
            MemoryPreference = MediaCaptureMemoryPreference.Cpu,
            StreamingCaptureMode = StreamingCaptureMode.Video
        };

        try
        {
            await _mediaCapture.InitializeAsync(mediaCaptureInitSettings);
        }
        catch (Exception e)
        {
            Debug.Log("Camera initialization failed: " + e.Message);
        }

But using il2cpp just really brakes the ability to run InitializeAsync(). Starting to suspect that there is a Unity bug going on here.

Tested it with different Unity versions. Result:

Unity 2017.1.3f1: .NET works, IL2CPP does not work
Unity 2018.3.1f1: .NET works, IL2CPP works
HoloLensCameraStream dll set with "Any scripting backend"

My project is currently under 2017.1.3f1 (because that is the last version that has a seperate Vuforia lib). So I have either to look for another solution to get the video textures or have to upgrade...


Fixed the actions and transformers

This PR contains:

Updates to latest Cloud-vision plugin.
Update to Output schema.

Known Issues:
https://issues.cask.co/browse/PLUGIN-120
Errors in pipeline run on Sandbox environment only.
Note: Example pipelines are part of another PR.

@googlebot I signed it!

@pbo-cirus thanks a lot for creating separate PRs. Can you also please ensure that you use 2 spaced tabs, so that the diff does not include unnecessary changes?

I thought I did the spacing. Weird...
On Wed, Apr 8, 2020, 9:56 PM Bhooshan Mogal<EMAIL_ADDRESS>wrote:

@pbo-cirus https://github.com/pbo-cirus thanks a lot for creating
separate PRs. Can you also please ensure that you use 2 spaced tabs, so
that the diff does not include unnecessary changes?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/data-integrations/cloud-vision/pull/13#issuecomment-611284233,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APDAA6A46GR6FTWAULKKQ3LRLUTNXANCNFSM4MEK7MPQ
.

I used IntelliJ to use 2 spaces instead of 4 (default)

Bhooshan,
Are you able to review? I see the message from the Google bot asking about a CLA. I already have signed it but I keep seeing this message. Is there anything else I need to do?

@pbo-cirus could you please check again - e.g. the pom.xml shows every single line changed. and its mostly whitespace changes.

Another thing to check is - the default length of the line is 120 characters, but seems like some files break it at 80, which causes more changes.

I just found out I committed with the wrong email id. I need to redo it with the right one.


Trying to launch Beeftext while already running should not give an error message.

Currently, trying to launch a second instance of Beeftext will result in an error message. It is confusing some users. It would be better to open the main window of the existing instance silently.

Hi,
I totally agree with that.
I am unable to use correctly the portable version of beeftext because I have no icon in the system tray and can't open the main window of the application. Beeftext is working but I can't change or create any combo.
Thanks for this application.

Hi @Celinch
Not having the icon in the system tray is not normal. Are you sure it is not in the overflow area?

It's not in the overflow area. My guess was that there are restrictions on the icons of the system tray on this computer.

Oh I see. That's indeed the likely cause. I'm increasing this issue's status to high priority, because it simply make the software unusable in restricted environments.
I will post test builds once I have something ready.

Hi @Celinch
I have implemented the change. Here are some test build if you wan to try:

Installer
Portable Edition

I just tested the portable edition and it was usable now. Even if I have no icon, I can "call" the main window by  double-clicking again on the application file.
Thanks !

I'm pleased to hear that. The official release should happen this week.


envoy.dependency.check: Update checker output and missing checker tests

Signed-off-by: Ryan Northey<EMAIL_ADDRESS>

@kfaseela this will most likely conflict with your PR for cython packages and dynamic limit - and at least one test would need adjusting
im happy to land your prs first

temp WIPping this while i makes some adjustments to output

thanks @phlax !


Visual selection issue.

When you try to visually select text with a tab indentation, the cursor jumps to the left corner. If the indentation is done with spaces, everything works fine. There is also a problem with text selection if enabled Lsp Inlay Hint.

added to list of reasons why i hate tabs !!!!!
i will try fix today

@octaviusz should be fixed now. try :Lazy update.
tabs still cause problems if you use :h virtualedit. you probably dont use it.
i thin the lsp inlay hint is fixed along with tabs (since the problem was to do with screen columns). let me know if there are any more issues
thanks

all good, thanks


Issue in Input.java

In the file org/red5/io/amf3/Input.java we have this code:
	if (attributes == null)
	{
		attributes = new ArrayList<String>(count);
		for (int i = 0; i < count; i++) {
			attributes.add(readString(String.class));
		}
		refStorage.classReferences.add(new ClassReference(className, AMF3.TYPE_OBJECT_VALUE, attributes));
	}
	//use the size of the attributes if we have no count
	if (count == 0 && attributes != null) {
		count = attributes.size();
		log.debug("Using class attribute size for property count: {}", count);
		//read the attributes from the stream and log if count doesnt match
		List<String> tmpAttributes = new ArrayList<String>(count);
		for (int i = 0; i < count; i++) {
			tmpAttributes.add(readString(String.class));
		}
		if (count != tmpAttributes.size()) {
			log.debug("Count and attributes length does not match!");
		}
		refStorage.classReferences.add(new ClassReference(className, AMF3.TYPE_OBJECT_VALUE, attributes));
	}

If attributes is null and count==0 we'll add new ClassReference to the refStorage twice. It's wrong and leads to errors when in complex objects serialization.

Looks correct to me; if attributes is null then add reference (1 instance) or if count is zero AND attributes are null then add a reference (1 instance). The second if block doesn't trigger if the first one does.

In this cоndition
if (count == 0 && attributes != null)
attributes will never null because we have this condition earlier:
if (attributes == null)
{
attributes = new ArrayList(count);
...
}

Ah right, good catch; I wonder what the author meant to do here...

Thanks for the fix! But why do we need additional checks (attributes != null)? As we have already discussed after first check attributes will never be null.

Just a habit and being extra cautious


NDRS-[350,351]: Add "fetch block by height" feature and replace in-mem cache usage with calls to the DB.

https://casperlabs.atlassian.net/browse/NDRS-350
https://casperlabs.atlassian.net/browse/NDRS-351

I'm not sure there's any real benefit to making the StorageType generic over the BlockHeight, nor exposing the BlockHeightHash.
I think this might be cleaner if we just create a specialized store for BlockHeightHash and take a block_height: u64 via Storage::get_block_by_height(). If we create a specialized store, we won't need to impl Value for BlockHeightHash nor provide the unused struct BlockHeightHashMetadata.

I wanted to keep everything in one place – putting block into block_store and block_height_store. Similarly, when requesting block by height I want it to happen as "close to each other" as possible. Originally, I hoped I will be able to do it in one LMDB transaction but that was impossible due to the way Storage(Type) traits were written. I went with the closes thing to the transaction available. "Fortunately", at the moment we will panic if an operation on storage fails – at least node won't continue operating with inconsistent data in storage.
Your proposal also fragments the way storages are abstracted away and I wanted to avoid that. When we get to re-designing the storage I think we will get rid of current traits entirely and I didn't want to choose the new direction (this task wasn't about it either).
I agree that unused BlockHeighHashMetadata is a pain but that's another example why the current traits were written prematurely.
All in all, this PR is consistent with the already established approach. It groups the operations to something that at least looks like a transaction. It also works. Once we decide to change how storages are accessed we will change it for all of them at once.

I wanted to keep everything in one place – putting block into block_store and block_height_store.

That would still be the case with my suggestion.  Your PR has the block_height_store as a separate DB, it's just that I think it doesn't fit having it implement Store.  That trait was only meant for storing types which are Value and that really only applies to blocks and deploys since these have a header.  I appreciate that this isn't well documented.

Originally, I hoped I will be able to do it in one LMDB transaction but that was impossible due to the way Storage(Type) traits were written.

I agree there is plenty of room for improvement in the storage component.  If we want to allow transactions to persist across separate DB calls, then there is quite a lot of work to implement that for the InMem DBs.  I'd been hoping to get permission to remove the in-mem support which would clean up and simplify so much of this code, but I don't think that permission is going to be given :)

Your proposal also fragments the way storages are abstracted away and I wanted to avoid that. When we get to re-designing the storage I think we will get rid of current traits entirely and I didn't want to choose the new direction (this task wasn't about it either).

I see your point, but there are two issues.  Firstly, we already have a separate storage type for a type which doesn't "fit" being a Value: the chainspec store.  I think this is another such case - you'd not be breaking from existing practice to implement a store specifically for this block height index.  Also, by having the specialized store, we'll be better able to see how inappropriate or otherwise the changes suggested by CEP-0003 are, since the shoehorning to make all our discrete type fit this new approach will be done during that discovery/implementation work rather than now.

All in all, this PR is consistent with the already established approach. It groups the operations to something that at least looks like a transaction.

That would still be the case if you take my suggested approach, and I'd suggest, it'd result in less complicated code in storage.

It also works.

I agree, but so would a specialized store for block height.  There is almost no conceptual difference - simply that the block height store isn't an instance of Store.

Cool. Thanks @Fraser999 .

bors r+


Remove FreeAgent provider doc

as no longer maintained and probably not compatible with current oauth2-client
comment from original author: https://github.com/CloudManaged/oauth2-freeagent/issues/6#issuecomment-432433512
@ramsey do you think we should delete FA from the page all together, or do as @zot24 suggested and merely replace the maintainer name with the word 'unmaintained' in case someone chooses to fork and update it? At CloudManaged we are easy either way - we aren't taking down the repo.

@ramsey will this commit automatically update the web page at http://oauth2-client.thephpleague.com/providers/thirdparty/ ?

@dcorking Yes, this commit will automatically update that page.

do you think we should delete FA from the page all together, or do as @zot24 suggested and merely replace the maintainer name with the word 'unmaintained'

We've never dealt with this issue that I can recall, so we don't have a precedent. I'm inclined to say that we should leave it in the list and use "Unmaintained" in place of the author name, as you suggest—perhaps italicized for emphasis.

@ramsey 👆 PR changed to keep FA but listed as unmaintained. I am happy to rebase if you prefer.

Thanks! I can do the squashing when merging. Cheers!

for the record


UMD global exports

As of now (02/2023), Parcel v2 doesn't support exporting as a UMD with an exposed global variable, which is strange given that they do support it in v1.  Of course, there are some workarounds such as manually attaching to the window object. Unfortunately, Parcel has been slow to merge a PR looking to address exactly this (looking at you, https://github.com/parcel-bundler/parcel/pull/7240). Looking at similar packages, Rollup seems to do a better job at this with their config. While this does not really matter for now (or ever, given we are now moving towards native ESM), if this doesn't get resolved soon, I might be tempted to migrate to Rollup in the future.
Some resources:

https://stackoverflow.com/questions/70268616/empty-javascript-file-when-building-with-parcel-js-2/70284901#70284901
https://github.com/parcel-bundler/parcel/pull/7240
https://github.com/parcel-bundler/parcel/pull/7381
https://github.com/parcel-bundler/parcel/issues/4155

Okay, one glaring problem is that while Parcel also supports global aliases for external dependencies, it does this to the all  targets. This means that doing:
"alias": {
  "tailwindcss/resolveConfig": {
    "global": "tailwind.resolveConfig"
  }
}

...which I intend for browser UMD exports only, some frameworks/bundlers might complain that tailwind.resolveConfig is missing! I don't know of any way to just alias a single target, or at least they forgot to document that somehow.
Again, Rollup does a much better job than this. Am I missing something here?

Some kbs info with v0.2.0, built w/ Parcel:

Alrighty. I have dabbled way too much with tests lately and it looks like I'm gonna be making the move sooner than later. I figure this isn't really something I should be worrying too much about and just move on lol. I haven't really used Parcel that much either tbh but it was still a great run. Also, node-canvas is being just a little bit rough around the edges, I'd say.


Landscape orientation on Mobile Safari too wide

Rotating mobile Safari to landscape causes the page to scale beyond view of the viewport.

This is a well know iOS Safari bug. You can fix this adding "max-scale=1" or "user scalable=no" to the content attribute of meta viewport tag.
<meta name="viewport" content="width=device-width,max-scale=1" />

or
<meta name="viewport" content="width=device-width,user-scalable=no" />

This fix has also minor setbacks, it prevents user to scale the content which isn't nice.

Gotcha.  I knew of those two "fixes" but just started looking at mobile.  Thanks for letting me know it's a Safari bug and not a CSS error.


add breaking changes in changelog

https://github.com/mapbox/mercantile/pull/129 introduced a breaking change by moving mercantile.scripts.coords to mercantile._coords.
I think it's acceptable to have breaking change between 1.1 and 1.2 but I think it's important to at least mention it in the changelog.
@sgillies no harm here, I'm maybe the only one which import stuff from scripts code 🙈
ref: https://github.com/developmentseed/morecantile/issues/50

Sorry about that @vincentsarago . I didn't consider mercantile.scripts.coords to be part of the public API, but didn't mark it "private", either.

as I said, it's ok I probably should stop using script functions 😂


[Feature Request]: Add python SDK option function.

Is there an existing issue for the same feature request?

[X] I have checked the existing issues.

Is your feature request related to a problem?
No response
Describe the feature you'd like

Add delimiter choice option "," ";" " " "    " or other symbol.
Add csv header option True or False.
Add create table option function.
Add update table option function.

Describe implementation you've considered
No response
Documentation, adoption, use case
No response
Additional information
No response

If the coming file is a .csv, options can be a dictionary consisting of "delimiter" and "hasHeader" fields which need to be specified by the user.
For create_table, options can be a bool value. true means create table ... if not exists, false means create table .... Default value is false.

Fixed by #824

It looks fixed.


Ionic prod build fails

When I'm going to build my ionic 2 project in prod mode it fails but in dev mode it successfully built. Throws an error like, Module not found: Error: Can't resolve 'angular2-http-interceptor/angular2-http-interceptor'. Detail error is specified below.
c:\Products\EmpeeSchool\Development\empee.school.mobile.client>ionic cordova build android --prod
[WARN] Detected locally installed Ionic CLI, but it's too old--using global CLI.
[WARN] Detected @ionic/cli-plugin-cordova in your package.json.
   As of CLI 3.8, it is no longer needed. You can uninstall it:

   npm uninstall -D @ionic/cli-plugin-cordova

[WARN] Detected @ionic/cli-plugin-ionic-angular in your package.json.
   As of CLI 3.8, it is no longer needed. You can uninstall it:

   npm uninstall -D @ionic/cli-plugin-ionic-angular

Running app-scripts build: --prod --platform android --target cordova
[13:42:35]  build prod started ...
[13:42:36]  clean started ...
[13:42:36]  clean finished in 8 ms
[13:42:36]  copy started ...
[13:42:36]  ngc started ...
[13:43:40]  ngc finished in 64.50 s
[13:43:40]  preprocess started ...
[13:43:40]  deeplinks started ...
[13:43:42]  deeplinks finished in 1.99 s
[13:43:42]  optimization started ...
[13:43:43]  copy finished in 67.17 s
Error: ./src/app/app.module.ngfactory.js
Module not found: Error: Can't resolve 'angular2-http-interceptor/angular2-http-interceptor' in 'c:\Products\EmpeeSchool\Development\empee.school.mobile.client\src\app'
resolve 'angular2-http-interceptor/angular2-http-interceptor' in 'c:\Products\EmpeeSchool\Development\empee.school.mobile.client\src\app'
Parsed request is a module
using description file: c:\Products\EmpeeSchool\Development\empee.school.mobile.client\package.json (relative path: ./src/app)
Field 'browser' doesn't contain a valid alias configuration
after using description file: c:\Products\EmpeeSchool\Development\empee.school.mobile.client\package.json (relative path: ./src/app)
resolve as module
c:\Products\EmpeeSchool\Development\empee.school.mobile.client\src\app\node_modules doesn't exist or is not a directory
c:\Products\EmpeeSchool\Development\empee.school.mobile.client\src\node_modules doesn't exist or is not a directory
c:\Products\EmpeeSchool\Development\node_modules doesn't exist or is not a directory
c:\Products\EmpeeSchool\node_modules doesn't exist or is not a directory
c:\Products\node_modules doesn't exist or is not a directory
c:\node_modules doesn't exist or is not a directory
looking for modules in c:\Products\EmpeeSchool\Development\empee.school.mobile.client\node_modules
using description file: c:\Products\EmpeeSchool\Development\empee.school.mobile.client\package.json (relative path: ./node_modules)
Field 'browser' doesn't contain a valid alias configuration
after using description file: c:\Products\EmpeeSchool\Development\empee.school.mobile.client\package.json (relative path: ./node_modules)
using description file: c:\Products\EmpeeSchool\Development\empee.school.mobile.client\node_modules\angular2-http-interceptor\package.json (relative path: ./angular2-http-interceptor)
no extension
Field 'browser' doesn't contain a valid alias configuration
c:\Products\EmpeeSchool\Development\empee.school.mobile.client\node_modules\angular2-http-interceptor\angular2-http-interceptor doesn't exist
.js
Field 'browser' doesn't contain a valid alias configuration
c:\Products\EmpeeSchool\Development\empee.school.mobile.client\node_modules\angular2-http-interceptor\angular2-http-interceptor.js doesn't exist
.ts
Field 'browser' doesn't contain a valid alias configuration
c:\Products\EmpeeSchool\Development\empee.school.mobile.client\node_modules\angular2-http-interceptor\angular2-http-interceptor.ts doesn't exist
as directory
c:\Products\EmpeeSchool\Development\empee.school.mobile.client\node_modules\angular2-http-interceptor\angular2-http-interceptor doesn't exist
[c:\Products\EmpeeSchool\Development\empee.school.mobile.client\src\app\node_modules]
[c:\Products\EmpeeSchool\Development\empee.school.mobile.client\src\node_modules]
[c:\Products\EmpeeSchool\Development\node_modules]
[c:\Products\EmpeeSchool\node_modules]
[c:\Products\node_modules]
[c:\node_modules]
[c:\Products\EmpeeSchool\Development\empee.school.mobile.client\node_modules\angular2-http-interceptor\angular2-http-interceptor]
[c:\Products\EmpeeSchool\Development\empee.school.mobile.client\node_modules\angular2-http-interceptor\angular2-http-interceptor.js]
[c:\Products\EmpeeSchool\Development\empee.school.mobile.client\node_modules\angular2-http-interceptor\angular2-http-interceptor.ts]
[c:\Products\EmpeeSchool\Development\empee.school.mobile.client\node_modules\angular2-http-interceptor\angular2-http-interceptor]
@ ./src/app/app.module.ngfactory.js 24:0-80
@ ./src/app/main.ts,./src/modules/lessonPlan/lessonPlan/lessonPlan.ts
Module build failed: TypeError: Cannot read property 'content' of undefined
at Object.optimizationLoader (c:\Products\EmpeeSchool\Development\empee.school.mobile.client\node_modules@ionic\app-scripts\dist\webpack\optimization-loader-impl.js:14:24)
at Object.loader (c:\Products\EmpeeSchool\Development\empee.school.mobile.client\node_modules@ionic\app-scripts\dist\webpack\optimization-loader.js:5:32)
@ ./src/app/app.module.js 29:0-77
@ ./src/app/app.module.ngfactory.js
@ ./src/app/main.ts,./src/modules/lessonPlan/createLessonPlan/createLessonPlan.ts
Module build failed: TypeError: Cannot read property 'content' of undefined
at Object.optimizationLoader (c:\Products\EmpeeSchool\Development\empee.school.mobile.client\node_modules@ionic\app-scripts\dist\webpack\optimization-loader-impl.js:14:24)
at Object.loader (c:\Products\EmpeeSchool\Development\empee.school.mobile.client\node_modules@ionic\app-scripts\dist\webpack\optimization-loader.js:5:32)
@ ./src/app/app.module.js 30:0-95
@ ./src/app/app.module.ngfactory.js
@ ./src/app/main.ts,./src/modules/parents/parentLogin/parentLogin.ts
Module build failed: TypeError: Cannot read property 'content' of undefined
at Object.optimizationLoader (c:\Products\EmpeeSchool\Development\empee.school.mobile.client\node_modules@ionic\app-scripts\dist\webpack\optimization-loader-impl.js:14:24)
at Object.loader (c:\Products\EmpeeSchool\Development\empee.school.mobile.client\node_modules@ionic\app-scripts\dist\webpack\optimization-loader.js:5:32)
@ ./src/app/app.module.js 32:0-77
@ ./src/app/app.module.ngfactory.js
@ ./src/app/main.ts
at BuildError.Error (native)
at new BuildError (c:\Products\EmpeeSchool\Development\empee.school.mobile.client\node_modules@ionic\app-scripts\dist\util\errors.js:16:28)
at c:\Products\EmpeeSchool\Development\empee.school.mobile.client\node_modules@ionic\app-scripts\dist\preprocess.js:18:21
at process._tickCallback (internal/process/next_tick.js:109:7)
Please help.

Hi @SubhajitLogos! This does not look like it applies to AngularFire so we can't be too much of help here.


Interactivity polygon

Fix for https://github.com/CartoDB/renderer-prototype/issues/199

It seems that the mousemove event is launched in the featureClick callback :confused:

It seems that the mousemove event is launched in the featureClick callback confused

It is, but that's a bug in master

It is, but that's a bug in master

Yep, and there are lots of featureClick calls on one click. I'll fix it in master :wink:


feat: upgrade to node 22

#22  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Remove Bucket access check from node csi drvier

Issues:

CSI node driver was initializing the storage client on every node publish. This is an expensive call which does a 3-way handshake to k8s API server, STS server, and GCP IAM.
GCSFUse already validates the bucket access during mount init. This makes the CSI node driver checks redundant.

Fix:
remove the bucket access check and the storage client init on every node publish call.
Tests:

manually tested on 1.29 cluster, 1.29(master), 1.28(nodepool), success and failure scenarios..

Verified that gcsfuse denies mount request of the SA does not have the necessary permissions on the bucket
SetUpBucket: Error in iterating through objects: Get \"https://storage.googleapis.com/storage/v1/b/test-csi-fix/o?alt=json&delimiter=&endOffset=&includeFoldersAsPrefixes=false&includeTrailingDelimiter=false&matchGlob=&maxResults=1&pageToken=&prefix=&prettyPrint=false&projection=full&startOffset=&versions=false\": metadata: GCE metadata \"instance/service-accounts/default/token?scopes=https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fdevstorage.full_control\" not defined\n"}
Error while mounting gcsfuse: mountWithArgs: mountWithStorageHandle: fs.NewServer: create file system: SetUpBucket: Error in iterating through objects: Get "https://storage.googleapis.com/storage/v1/b/test-csi-fix/o?alt=json&delimiter=&endOffset=&includeFoldersAsPrefixes=false&includeTrailingDelimiter=false&matchGlob=&maxResults=1&pageToken=&prefix=&prettyPrint=false&projection=full&startOffset=&versions=false": metadata: GCE metadata "instance/service-accounts/default/token?scopes=https%3A%2F%2Fwww.googleapis.com%2Fauth%2Fdevstorage.full_control" not defined
E0510 22:44:39.602449       1 logger.go:60] gcsfuse exited with error: exit status 1

/lgtm


Browser compatibility table

Fixes #623

I think I would agree if the specs were to change, the browser set were to change.
It's only defined once though, so with the links & images it seems more effort than its worth.


keyword_case: ignore 'TEXT' in selection screen

closes #745
Instead of allowing a list of exlusions, add this special case - consider revisiting if more cases appear.

this should be a user setting, allowing users to choose which style to enforce/or not to enforce

True, but in this specific case it's an actual bug, isn't it? At least in 7.40 'TEXT' is not regarded as a keyword in the context of the default pretty printer, at least in terms of upper-/lowercase.

yea, but if a customer have all SAP systems on the latest greatest HANA S/4, I personally would like to enforce this rule, have TEXT only be upper case

How about this:

for "TEXT" in selection screen specifically I add a version check, ignore word if release version below 750
addtionally add option to ignore specific words

I think it must be a user setting, could also be someone working on a 740 system, but wanting to pretty print according to 750 logic

thanks, looks good 👍


conf: rewrite unified pool related configurations

What problem does this PR solve?
Problem Summary:
When TiKV starts, it prints out the configuration in the log. Currently, if use-unified-pool is not set, null will be outputted. This behavior may be confusing to users and the users can fail to know the default setting TiKV uses.
What is changed and how it works?
What's Changed:
Instead of silently using default settings in TiKV, this PR rewrites use-unified-pool with the default setting. Now TiKV prints out the real setting of use-unifed-pool in the start log.
Related changes

Need to cherry-pick to the release branch

Check List
Tests

Unit test
Manual test (add detailed scripts or steps below)

Now, even if use-unified-pool is not set, the real setting will be printed out like this: (previously readpool.*.use-unified.pool = null)
[2020/05/26 16:07:59.257 +08:00] [INFO] [server.rs:213] ["using config"] [config="{\"cfg-path\":\"conf/tikv.toml\",\"log-level\":\"info\",\"log-file\":\"/home/tidb/tidb-deploy/tikv-20160/log/tikv.log\",\"slow-log-file\":\"\",\"slow-log-threshold\":\"1s\",\"log-rotation-timespan\":\"1d\",\"log-rotation-size\":\"300MiB\",\"panic-when-unexpected-key-or-data\":false,\"readpool\":{\"unified\":{\"min-thread-count\":1,\"max-thread-count\":4,\"stack-size\":\"10MiB\",\"max-tasks-per-worker\":2000},\"storage\":{\"use-unified-pool\":true,\"high-concurrency\":6,\"normal-concurrency\":6,\"low-concurrency\":6,\"max-tasks-per-worker-high\":2000,\"max-tasks-per-worker-normal\":2000,\"max-tasks-per-worker-low\":2000,\"stack-size\":\"10MiB\"},\"coprocessor\":{\"use-unified-pool\":true,\"high-concurrency\":9,\"normal-concurrency\":9,\"low-concurrency\":9,\"max-tasks-per-worker-high\":2000,\"max-tasks-per-worker-normal\":2000,\"max-tasks-per-worker-low\":2000,\"stack-size\":\"10MiB\"}}...

Release note
Prints out the factual use-unified-pool configuration in the startup log.

/run-cherry-picker


[New game]: Add Pacman Game

🎮 Game Request
I want to add a Pacman game developed using HTML, CSS, and JavaScript, inspired by the classic arcade game.
Players will control Pacman, guiding him through a maze to collect pellets and avoid ghosts. The objective is to clear the maze by eating all the pellets and earning a high score.
Point down the features
Player Control: Responsive and smooth controls to allow players to navigate Pacman through the maze using arrow keys or on-screen touch controls. Precise and enjoyable movement mechanics.
Pellet Collection: The maze is filled with pellets that Pacman must consume to earn points. Differentiation between regular pellets and power pellets that enable Pacman to eat ghosts.
Ghosts AI: Intelligent ghost AI that chases Pacman through the maze. Different ghost behaviors, such as random movement, target chasing, or ambushing strategies. Challenging and dynamic ghost movements to create an engaging gameplay experience.
Maze Layout and Level Design: Visually appealing mazes with walls, corridors, and various obstacles.
Score Tracking and High Scores: A scoring system that tracks the player's score throughout the game.
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

Hey @abhinav-m22 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

/assign

Hey @abhinav-m22!
We are already having a similar game request in #1905 👀
Make sure you come up with a cool unique idea 😀
Waiting for your new game idea 💗.

Hey @abhinav-m22 ! Thank you so much for your raising the issue💗
It’s all yours, you can come anytime again and make some contributions! 🚀
Alone, we can do little, but together we can do so much! 😇


Other database flavours support

While running the bot is a breeze for the most part, it makes running it under automated deployment environments rather bad. Since the bot uses SQlite as the default db flavour, redeploying a config change or updated bot would very much wipe out the existing db therefore losing all log capability.
Now this can be overcome if the db file was stored on a network host that the deployment environment can connect to, that would fix the issue but another more preferable fix would be to support other flavours of databases like postgreSQL, MySQL, etc.
Knex supports them directly so it's just a matter of changing a few lines in src/config.js to point to the other database and in db\migrations\20171223203915_create_tables.js line 21 to a different type (from table.mediumtext() to table.text()) . This is because textType is a MySQL datatype preference so it breaks on postgres for example, see here.
So something will appear in src/config.js along the lines of this:
// Default knex config
if (! finalConfig['knex']) {
  finalConfig['knex'] = {
    client: finalConfig.dbType,
    connection: {
      host: finalConfig.dbHost,
      user: finalConfig.dbUser,
      password: finalConfig.dbPass,
      database: finalConfig.dbName
    },
    useNullAsDefault: true
  };
}

And in defaultConfig of the same file or something else to default to SQLite instead:
const defaultConfig = {
  "token": null,
  "mailGuildId": null,
  "mainGuildId": null,
  "logChannelId": null,
  ...

  "dbDir": path.join(__dirname, '..', 'db'),
  "knex": null,

  "logDir": path.join(__dirname, '..', 'logs'),

  dbType: 'pg',
  dbHost: 'localhost',
  dbUser: 'postgres',
  dbPass: 'postgres',
  dbName: 'modmail',
};

I'll be using a patched version I made in a fork here https://github.com/LynnAU/modmailbot/commit/3e75c614a8036e8acb7904ce0984d73a259be52b

There is actually support for this already ("knex" in config. json to provide custom knex options), but it's undocumented since I don't want to test on a bunch of databases every time. I use it with MariaDB myself.

Ah yep, I see that now. Up to you with what you want to do whether or not to close this or document the feature/patch in better support...

Sorry to bring this back from the dead, but I would like to know how to make use of my already established MySQL database thats already running on my web hosting box.

@smooreace Not sure if you're still looking to use this, but you can use the knex config option to provide custom Knex.js options. You can find Knex's documentation here: https://knexjs.org/#Installation-client
Note that I currently won't provide support for using this option, since it's largely untested with databases other than SQLite (the default) and MariaDB, and is primarily offered as an advanced option for those who really need it.

Thanks for the response, but with the bot not working at all, the need for specific database utilization is not a big concern any longer.

You mention that this is tested with MariaDB, could you provide an example of the configuration required to connect to a MariaDB instance?

Maria is no different than SQLSent via the Samsung Galaxy S8+, an AT&T 5G Evolution capable smartphone
-------- Original message --------From: ashortdev<EMAIL_ADDRESS>Date: 9/7/19  7:15 PM  (GMT-06:00) To: Dragory/modmailbot<EMAIL_ADDRESS>Cc: smooreace<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [Dragory/modmailbot] Other database flavours support (#206) You mention that this is tested with MariaDB, could you provide an example of the configuration required to connect to a MariaDB instance?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/Dragory/modmailbot/issues/206?email_source=notifications\u0026email_token=AIPE4QYH5V6AWNJXLIEGPK3QIQ72RA5CNFSM4GL65J52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6FEYFQ#issuecomment-529157142",
"url": "https://github.com/Dragory/modmailbot/issues/206?email_source=notifications\u0026email_token=AIPE4QYH5V6AWNJXLIEGPK3QIQ72RA5CNFSM4GL65J52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6FEYFQ#issuecomment-529157142",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]

More specifically, mariadb is designed to be a drop-in replacement for MySQL, so should support all the same features and commands, and connecting would also be the same. There can occasionally be some deviations on more advanced functionality, but nothing you're going to encounter in most appplications.
v / r
Robert Klebes
Mobile:<PHONE_NUMBER>
https://keybase.io/sporkwitch
https://www.linkedin.com/in/klebes
On September 7, 2019 9:30:40 PM EDT, smooreace<EMAIL_ADDRESS>wrote:

Maria is no different than SQLSent via the Samsung Galaxy S8+, an AT&T
5G Evolution capable smartphone>
-------- Original message --------From: ashortdev
<EMAIL_ADDRESS>Date: 9/7/19  7:15 PM  (GMT-06:00) To:
Dragory/modmailbot<EMAIL_ADDRESS>Cc: smooreace
<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject:
Re: [Dragory/modmailbot] Other database flavours support (#206) You
mention that this is tested with MariaDB, could you provide an example
of the configuration required to connect to a MariaDB instance?>

—You are receiving this because you were mentioned.Reply to this email
directly, view it on GitHub, or mute the thread.>
[>
{>
"@context": "http://schema.org",>
"@type": "EmailMessage",>
"potentialAction": {>
"@type": "ViewAction",>
"target":
"https://github.com/Dragory/modmailbot/issues/206?email_source=notifications\u0026email_token=AIPE4QYH5V6AWNJXLIEGPK3QIQ72RA5CNFSM4GL65J52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6FEYFQ#issuecomment-529157142",>
"url":
"https://github.com/Dragory/modmailbot/issues/206?email_source=notifications\u0026email_token=AIPE4QYH5V6AWNJXLIEGPK3QIQ72RA5CNFSM4GL65J52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6FEYFQ#issuecomment-529157142",>
"name": "View Issue">
},>
"description": "View this Issue on GitHub",>
"publisher": {>
"@type": "Organization",>
"name": "GitHub",>
"url": "https://github.com">
}>
}>
]>

-- >
You are receiving this because you are subscribed to this thread.>
Reply to this email directly or view it on GitHub:>
https://github.com/Dragory/modmailbot/issues/206#issuecomment-529160521

Let me clarify - What is the syntax required for a MySQL connection within the config?
I see an example on the linked knex documentation lists:
connection: {
host : '<IP_ADDRESS>',
user : 'your_database_user',
password : 'your_database_password',
database : 'myapp_test'
}
You mentioned the bot is tested on MariaDB, so I'm looking for an example of what a database-linked config file should look like - as the linked knex documentation isn't very actionable. What key names should be used to assign connection parameters?

Here's an example of a config that uses MariaDB/MySQL:
{
  "knex": {
    "client": "mysql2",
    "connection": {
      "host": "<IP_ADDRESS>",
      "user": "modmailbot",
      "password": "password here",
      "database": "modmailbot",
      "charset": "utf8mb4",
      "timezone": "UTC",
      "supportBigNumbers": true,
      "bigNumberStrings": true,
      "dateStrings": true
    },
    "pool": { "min": 0, "max": 10 },
    "acquireConnectionTimeout": 30000
  }
}

You'll also need to run npm i --no-save mysql2

The bot now supports MySQL (as well as continuing to support SQLite) in the latest version. It's currently a pre-release which you can get here.


Support MessagePack in transient mode in SDK-side

Close #1745

Make the Protocol project internal visible to Common, so that MessagePackWriter class can be used by Common project. As the SequenceOfT was under the Common project source directory and referred as source file by Protocol before, which was conflicted after internal visible, I move the file.
Avoid breaking change. The default hub protocol for transient mode is JsonObjectSerializerHubProtocol. If user doesn't add their own IHubProtocol ( the detecting logic is in the PayloadBuilderResolver) , then JSON payload is used, and the service side still does JSON->MessagePack conversion. Otherwise binary payload is used.

@galvesribeiro This PR supports MessagePack in transient mode in SDK-side, please take a look.

@galvesribeiro  We have a preview version now. Could you have a test and tell us if it solves your problem? Once you confirm that, we will release a new version.

@Y-Sindo I can confirm that it works. Thank you.

@galvesribeiro  The new version is released. Please upgrade to 1.21.0


got an error while opening notebook Unreadable Notebook: C:\requestshtml\envdeepl\02_end_to_end_machine_learning_project.ipynb NotJSONError("Notebook does not appear to be JSON: '\n\n\n\n\n\n\n<html lang...",)

The same problem! Somebody help!

Hi @IgBell,
Are you still experiencing this issue? I can't reproduce it. Perhaps try pulling the latest notebooks using git pull?


Fixes race where multiple RestApiResourceScanner created

Always call the install(Collection<Class>) method, since this has the logic to determine whether we need to create a new scanner. Makes the constructors private to prevent this recurring, implements the caveats mentioned in ScannerInjectHelper here instead, and make the method synchronized.
Signed-off-by: Andrew Donald Kennedy<EMAIL_ADDRESS>

looks good!  merging


refactor(Grid): update Component

This PR:

updates docs to latest pattern (#564);
fixes Grid warning in tests (#599);
cleanups docs, tests and code.

Current coverage is 100% (diff: 100%)

No coverage report found for master at 89456fa.

Powered by Codecov. Last update 89456fa...24c7edd

Released in<EMAIL_ADDRESS>


Add conversion to/from NumPy structured arrays

Note that this PR also removes t.matrix, which returned a somewhat broken matrix object (matrices are not recommended for use, and in this case the column dtype was simply being taken from the first column, turning numbers into strings, etc.)

Looks good! What's the most common use-case for this?

I feel it's important to have bridges to well established tools that folks are familiar with already.  NumPy is certainly a de-facto standard!  Once you have a numpy array, you can save the file to disk for example, and load it back up.  A whole lot of standard tools become available to you.

Cool!


Feature request: Provide a basic "forem.css" file rather than themes

It'd be really convenient to have a basic forem.css file that I can take and modify on my own, rather than using these pre-built themes.  One reason is that I don't know where I go to modify the pre-built themes.  Another reason is that I want to style the forum to match my site, but I want a basic css file to start from, too.

We'll be providing a gem which provides some views and a default CSS template as part of the work on the gem release as discussed in #666


Support for Categories

Thanks a lot for this Swift package!
Do you plan to support categories? Would be awesome to have categorised symbols maybe by adding an option menu on top of the view.
This issue is also very interesting and could help to solve the issue:
https://github.com/xnth97/SymbolPicker/issues/8

+1


AWS SDK 2.10.86

Description

Related Issue

Tasks

[x] I have signed the CLA.
[x] I have written tests and verified that they fail without my change.

@agudian

obsolete.


[SPARK-22675] [SQL] Deduplicate PropagateTypes in TypeCoercion

What changes were proposed in this pull request?
We do not need to call PropagateTypes  twice in the same batch. The original changes in https://github.com/apache/spark/pull/5278 is not an issue now. Thus, we can deduplicate it.
How was this patch tested?
The existing test cases

cc @cloud-fan

Test build #84397 has started for PR 19867 at commit fc3a24e.

Test build #84397 has finished for PR 19867 at commit fc3a24e.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84397/
Test FAILed.

retest this please

Test build #84398 has started for PR 19867 at commit fc3a24e.

Test build #84398 has finished for PR 19867 at commit fc3a24e.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84398/
Test FAILed.

retest this please

Test build #84400 has started for PR 19867 at commit fc3a24e.

Test build #84400 has finished for PR 19867 at commit fc3a24e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/84400/
Test PASSed.

Merged build finished. Test PASSed.

After rethinking about it, this is not a right fix. I will close it first. There are multiple issues in the existing PropagateTypes


Add Search Functionality

Adds a search page with a link in the navigation bar. Can also display page excerpts with search results if they are included with AdditionalSearchResultFields
Resolves #5, may also work for #6 though I haven't tested this.

This is amazing! I'll get it merged as soon as https://github.com/statiqdev/Statiq.Web/pull/1000 gets in.


Update CosmosDB codeowners

To get the users notified whenever a PR is created in CosmosDB
MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.

adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

Can one of the admins verify this patch?

@bsiegel please merge

please merge

@MehaKaushik I'm not a committer on this repo any longer, perhaps @dmakwana ?