Embed GUIs into napari blog entry

I have written the third part to embed GUIs into napari using 3 different approaches.
Let me know if you know improvements for them, if any of them is unnecessary or even if you know another useful one.
Please also let me know if you think the 'climate changes' trivia can be considered somehow inappropriate here.
I am not defending any cause, I just always played with flooding my images to check background homogeneity, so I did like that for fun 😄
I had to let the part of turning these into plugins for a forth part because this was already too long for that.
P.S. sorry for the typo in the branch name xD

Hi Marcelo @zoccoler ,
can you please check if all changes were pushed to github? Your branch appears empty:

Best,
Robert

You are right, that's odd, let me check

Oh well, it seems I had merged it already... (my mistake)
I thought I was merging it locally before to get the latest updates.
Let me try to revert this.

Let me try to revert this.

Sometimes, it's tricky. It would also be completely fine if one of us sends a PR with suggestions to your blog post and you review and merge them.
The post looks great btw! <3

Am I reverting my changes now?

It seems, by the file changes, it is reverting things back. I am going to merge and then try a new PR with the new post.

No hurry 🙂


Replace sketch

Replace sketch not working any more. The command is in the sketch dropdown but doesn't do anything. Tried it on two computers same thing. It used to work and I haven't changed anything with the system. I deleted, downloaded the zip and started over with the same result. What gives? Thanks ,cob

Appears to be a duplicate of #24


employee Create Edited

Pre-Submission Checklist

[ ] Your pull request targets the main branch.
[ ] Branch name is descriptive and follows the guidelines here.
[ ] All tests pass . Use git commit --amend to amend any fixes.

Checklist:

[ ] All tests are passing.
[ ] Tested changes locally.
[ ] Improved documentation or readme where necessary.
[ ] Your commit messages format follows our commit message guideline here.

What does this PR do?

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Does it require any deployments updates ?

Questions:

@tayoski7 can you kindly host this briefly and share the URL so @roji-tech @Aajibolah  and the others can view and give feedback?


travis issue

@IainNZ, after trying to push some changes in metadata on the basis of a bug fix made by @davidanthoff, I see the following error appearing (I didn't touch .travis.yml, and things were working before, so not sure what is going wrong):
'''
$ julia -e 'Pkg.init(); run(ln -s $(pwd()) $(Pkg.dir("Lora"))); Pkg.pin("Lora"); Pkg.resolve()'
INFO: Initializing package repository /home/travis/.julia/v0.4
INFO: Cloning METADATA from git://github.com/JuliaLang/METADATA.jl
INFO: Creating Lora branch pinned.ea1d014d.tmp
WARNING: julia is fixed at 0.4.0-pre+7078 conflicting with requirement for Lora: [0.3.0,0.4.0-)

Oh you committed directly to METADATA? You really shouldn't do that, everyone is expected to do PRs first

Ah, sorry about this @IainNZ, didn't know this was not good practice, I will be submitting PRs on metadata from now on :) As for now, what should I do to get things fixed?

I'm going to revert the commit, can try tagging new releases properly.
The message on Travis seems correct - its trying to test a version of Lora that works only on Julia 0.3, but its trying to test it on Julia 0.4 (nightly).

Ok its reverted now.
I'll submit a PR with an updated .travis.yml, the style is a bit out of date now.

Thanks @IainNZ, appreciated. I will be submitting PRs from now on, wasn't aware that my metadata approach was out of date :+1:

No problem

I will close this issue now, since it is all fixed, thanks! By the way, @davidanthoff, now you should be able to use Lora via the package manager without any metadata issues.


fix: move docusaurus core back to hard dependencies

While upgrading to latest beta 10, it gives @docusaurus/core peer dependency error due to different versions required by @docusaurus/preset-classic and root @docusaurus/core. Current canary release seems broken as well because of this inconsistent requirements.

Motivation
Trying to fix the peer dependency error while upgrading to the latest beta 10.
Details of error:
$ npm i @docusaurus/core@latest @docusaurus/preset-classic@latest
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/@docusaurus/core
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR! node_modules/@docusaurus/preset-classic
npm ERR<EMAIL_ADDRESS>from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/XXXX/.npm/eresolve-report.txt for a full report.

npm ERR!      /Users/XXXX/.npm/_logs/2021-12-XXXX_30_21_115Z-debug.log

Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Sorry, I don't know how to test npm releases.

For now I'm reverting the peerDep to a regular dep (how it used to be)


Add a title to the Page

The page does not have a title. Add one!

can i try this?

can I try this?


KeyError while executing PhenoTagger_training.py with latest hpo.obo

Hi,
was just trying to rebuild the model using  the latest hpo.obo, was following the steps as mentioned in the readme. Program is crashing while executing the following,
time python ../src/PhenoTagger_training.py -t ./distant_train_data/distant_train.conll -d ../data/corpus/GSC/GSCplus_dev_gold.tsv -m biobert -o ./models/
Traceback (most recent call last):
File "../src/PhenoTagger_training.py", line 185, in
BERT_training(trainfiles,vocabfiles,modelfile)
File "../src/PhenoTagger_training.py", line 106, in BERT_training
train_x,train_y=bert_model.rep.load_data(train_set,train_label,word_max_len=bert_model.maxlen)
File "/home/PhenoTagger/src/nn_represent.py", line 247, in load_data
y_list=self.generate_label_list(labels)
File "/home/PhenoTagger/src/nn_represent.py", line 227, in generate_label_list
temp_label[self.label_2_index[label]]=1
KeyError: 'HP:0034011'

Hi,
This error seem that you used old HPO dict files to retrain a model. Did you use the Build_dict.py file to generate the new dict files? You can see that the default dict files are load on lines 157-159, 172 in PhenoTagger_training.py file. Please check the loaded dict files are the new dict files.  If your new dict folder name is not 'dict' (default), you could renamed the folder  to 'dict', or change the lines in the script to load the new dict files.
BTW, our Web API for PhenoTagger has updated using the latest hpo.obo, you could also try it.


canvas2svg.js:577 Attempted to apply path command to node text

Why does this error come anytime text is drawn

You have to close the path, before you draw text. Try canvas.closePath(), that worked for me.


2FA - Two-Factor Authentication - Time-based One-Time Password (TOTP)

2FA - Two-Factor Authentication for Websites and Mobile Apps
google authenticator and authy
authy is easier and more features, also more simpler when start using a new device!
https://support.google.com/accounts/topic/28786?hl=en
https://en.wikipedia.org/wiki/Google_Authenticator
https://www.authy.com/

@TraderStf 2FA is definitely a must for security. But this guide focuses on improving security and privacy in the context of OS X. Which section did you have in mind (maybe a new section?) which would benefit from this recommendation?

These solutions are free, reliable and simple to set-up.
They provide a higher level of security in a matter of minutes as one of the biggest security hole is the passwords.
This 2FA would be for all third-party services listed, backup, password manager (dashlane...) online access, VPN account, lock-devices remotely (prey, bitdefender...), ISP account, Server Logging...

Okay. I will talk about two factor authentication in the Passwords section. It's a good idea, @TraderStf.

I think that's something most people don't know and are still hurting their mind to manage passwords.
I agree with you, it is no more "local" security, but computers and internet access are almost one these days.


iOS: story titles sometimes run long

We fixed this a while ago but it never actually went away in all circumstances.  Specifically Twitter and Reddit feeds seem to trigger this.


Read folders in separate goroutines.

As proposed in the FIXME, read folders in parallel.
This appears to fix "Next token is expired" on very big directories.
The only downside is that this doesn't abort at once if an error is found.
I added some logging, so there is some output for "-v".

Nice!
I have a slight concern about the potentially unlimited concurrency. However the pacer will ensure that we don't abuse the server so the worst case is equivalent to loading the directory tree into memory all at once which isn't a big concern.
Drive could do with this fix too - it has the same pattern in it.
It makes sense it fixes the next token expired and that is probably a good reason for putting it in drive too.

Having thought a bit more about it, I think this can break the guarantee that rclone tries to provide of not doing more than fs.Config.Checkers operations simultaneously with the server.  Eg if directory listings are taking 1s say, but we are launching a new one every 10mS via the pacer.
I suggest you re-organise this into fs.Config.Checkers worker goroutines, a channel (which probably takes a struct) to feed them data. This channel wants to be made big (say 1000 entries) so that the top level directory can run through to the end without stopping to avoid the expired next token.
This then gives the ability to stop everything when an error is detected by closing the feeding channel also which is a bonus.  You'll note that I want List and ListDir to return errors at some point in #127
You can see this pattern in use in fs/operations.go if you want some inspiration!
Thanks
Nick

Ok. However, it seems like there is already some limiting going on. There are never more than 4-6 connections  "in flight" with this code. If I limit it to no more than 8 connections it doesn't seem to have any effect. Are you sure it isn't limited somewhere else?
I am testing on a directory structure with 41276 files in 4321 directories, so differences should be visible. Without the change it takes (>30 minutes) at which point it just errors out. With this change it takes ~14 minutes to list all files.

Try reducing the minimum time for the pacer. I set it to 100ms which is probably too high. It is a trade off between getting steady throughput and having to retry. Drive uses 10ms

Ah - that could be why it seems to be limited. Lowering the minSleep to 20ms there are more concurrent connections. With maximum of 8 connections the directory listing completes in 4 minutes with only a few "500 Internal Server error".
Maybe pacer values that are
	minSleep           = 20 * time.Millisecond
	maxSleep           = 15 * time.Second

I went for a slightly simpler approach with a channel with a number of "tokens".

Thanks for that - excellent work :-)
I've merged it now.
I think the min and max delay need a bit more thought - I'll experiment, but your values are fine for the moment.
I thought about the token approach you took but I thought the other way would control the errors better.  Anyway what you did is fine and we'll revisit in #127


📢 Plans for the future

This project hasn't been updated in a while. Since it was created Next.js and Now.sh - and React and Node.js! - have all changed a lot since the creation of this project in 2016.
As a result, some of the examples in this project are no longer relevant or best practice. Things like Sass and CSS support, fetch and dotenv are native in Next.js. There are other, better ways of doing some of the things this project does - using React Hooks to fetch data, for example. The Next.js repo itself has a much greater range of examples and additional built-in functions.
In addition, new projects on Now.sh are now Serverless only, which is not compatible with this project out of the box - this was designed to work the only way it could at the time, with a custom server designed for Now.sh 1.x, a method which is no longer supported.
However, one of the of the most common use cases for this application is people using it to bootstrap creating applications with authentication, which is still a pain point for a lot of folks.
That was such a commonly requested feature that by December 2016 I'd already being work to split it off into it's own library, which became the next-auth library, which this project was updated to use.
NextAuth
This month, I posted an announcement, that NextAuth v2 will be out (ETA end of May).
You can find an example project that shows how to use NextAuth 2.0 here:
https://next-auth-example.now.sh
NextAuth v2 is far simpler and easier to use than setting up v1. It is not ready for production yet, but when it is, I'll be revisiting this project.
Given the enhancements to Next.js over the last 4 years and how much simpler the NextAuth v2 is to use, much of the code in the project will be redundant.
However, I think there is still scope for integrating some useful core features into a starter project to show how commonly requested things fit together, even if (thanks to things getting easier) what is relevant in 2020 is a little different than what was relevant in 2016.

Other than authentication, I'm not sure what will be in the updated version yet, but I'm interested in ideas for problems people have but are not sure how to address, or examples of functionality you think other people often struggle with.
I'm quite partial to including i18n support (client/server side internationalisation), as I think that's a reasonably common use case that it's possible to resolve well in Next.js, but is often not easy to setup if you haven't done it before.
Other things I'm considering are an 'admin' dashboard with a user management interface (e.g. view, edit, delete users if you are an admin) and a simple GitHub powered static CMS (e.g. edit Markdown files in an admin UI which saves content changes back to a GitHub repo and automatically pushes them live to your Next.js/Now.sh site).
I'm also considering including some example working Serverless configs, for those who need to host their site on AWS/Azure/Google Cloud Platform or elsewhere.
Very open to ideas - and to feedback on these suggestions!

I'm going to archive this project and direct people to NextAuth.js for authentication related questions.
The examples now in Next.js cover everything shown in this example project, making it redundant - and potentially harmful as this project is now outdated.


[Siddhi-fileio][Text mapper] Recieving text type events by reading a text file using regex is not succeed.

Description: Configuring siddhi to receive text type events by reading text files using regex match is not processing, but can see the file has deleted( action after process)
Steps to recreate:

Configure siddhi app for file source with mode=regex and with text mapper as below

@App:name('SiddhiAppFileRgx') @source(type='file', mode='regex', begin.regex='events-', end.regex='-events', tailing='false', file.uri='/home/kavitha/usr/SP_filein/textTest.txt', action.after.process ='delete', action.after.failure='move', move.after.failure='/home/kavitha/usr/SP_fileout', @map(type='text')) define stream RegxStream1 (symbol string, price float, volume long); define stream RegxStream2 (symbol string, price float, volume long);
from RegxStream1#log("stream is processed.... ") insert into RegxStream2;

Save a 'textTest' text file in given location with event details as below (e.g.)

events-  symbol:"TestABC",  price:55.0,  volume:1000 -events

Deploy the siddhi app and check

@kavithasub
When source is configured in regex mode, it will match the content including the begin.regex and end.regex.
So what it hand overs to the text mapper is
events- symbol:"TestABC", price:55.0, volume:1000 -events*
instead of
symbol:"TestABC", price:55.0, volume:1000.
In such cases, you have to use a custom mapping.

closing as its not a bug


Cosuming Serenety Api Web Post File

Hello again an thank for the old reponse I tried to send a file To the serene web Api file uoload and alway my request.files is empty here is may code:

sorry bad key:
var client = new JsonServiceClient(BaseUrl);             client.Post<ServiceResponse>("Account/Login",                 new LoginRequest                 {                     Username = User,                     Password = Pass                 });  MultipartFormDataContent content = new MultipartFormDataContent();             ByteArrayContent fileContent = new ByteArrayContent(System.IO.File.ReadAllBytes(filepath));             System.Net.Http.StringContent txtContent = new StringContent("lalala");             fileContent.Headers.ContentDisposition = new ContentDispositionHeaderValue("attachment") { FileName = filename };             content.Add(fileContent);                         var value = client.Post<Object>("File/TemporaryUpload1", content);
cosuming other services there is no problem.... but with this my request alway have troubles on FileController, is empty.

Look at ProductExcelImport tutorial from BasicSamples it performs a file upload. In this case Excel but you can restrict the file format.

thanks , I make it similar , in my case my client was an .net api, no js, finally I doing using the serene architecture style creating a file model
public class FilesModel
{
public string Nombre { get; set; }
public byte[] Content { get; set; }
}
and an endpoint for process that request.

Good deal. Don't forget to close the ticket if it's resolved.


UX issues on  Mac

Setting->Rearrange
It can not drag only one row, instead 6 rows are moved together.
Unless the row is not checked.

Home
Mouse wheel can not scroll content.

Hey @cool8jay,
we have rewritten ACWidget completely from the ground up into a new app called Trendly.
You can check it out at gettrendly.app. This unfortunately means that we will no longer work on ACWidget.
The UX issue you reported is also fixed there.


Add tracker to lab link on the adaptive-sycall blog

What type of PR is this?
/kind content
Any specific area of the project related to this PR?
/area blog
What this PR does / why we need it:
Add tracker to lab link on the adaptive-sycall blog

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: pmusa
Once this PR has been reviewed and has the lgtm label, please assign vjjmiras for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

content/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: 783a4b5233236fd1f3c185c11e4bcca09e3e0513

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: pmusa, vjjmiras
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

content/OWNERS [vjjmiras]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Getting an error as "Unable to retrieve child records" while listing file in a blob container

Preflight Checklist

[X] I have installed the latest version of Storage Explorer.
[X] I have checked existing resources, including the troubleshooting guide and the release notes.
[X] I have searched for similar issues.

Storage Explorer Version
1.20.1
Regression From
No response
Architecture
x64
Storage Explorer Build Number
20210720.10
Platform
Windows
OS Version
Windows10
Bug Description
Hi There,
Looking forward for your support. Highly appreciate your quick response!
We have a requirement to download bulk files from a BLOB in a one of our StorageAccount. Hence, we downloaded Azure storage explorer. While trying to access BLOB container, we are getting an error as "Unable to retrieve child records".

I have verified if i have Storage Blob Data Reader from azure portal. I can see it exist. By checking similar issues, i tried to delete AppData->Roaming->AzureStorageExplorer files and also tried re-installing Storage explorer. But it still didn't work.
Any suggestion is highly appreciated. Kindly let me know if any details required.

Kind Regards,
Vijay
Steps to Reproduce

Launch Storage explorer
Connect to our Subscription.
Navigate to your Storage account and try to list the files in your Blob container.

Actual Experience
Same as mentioned in Bug description above, getting error while expanding files list from our Blob container
Expected Experience
Have to list the files present in BLOB container.
Additional Context
No response

@imvjsai Is your computer using a proxy to connect to the internet?

@imvjsai Is your computer using a proxy to connect to the internet?

Thanks for your response. I'm not using proxy to connect to internet.

@JasonYeMSFT
Thanks for your response. I'm not using proxy to connect to the internet.

Also ran into this today, freshly installed the app.

No proxy

@kipperbush-lendus You are connecting to a storage emulator supposed to run on your local machine. This is the typical error when you don't have your local emulator started. Could you check if you have started your emulator?

@JasonYeMSFT Could you please suggest for my issue?

@imvjsai I remember in your previous screenshot you are connecting to a public Azure storage endpoint. The "local certificate error" is usually caused by a misconfigured server (proxy server or the Azure server itself). Since you aren't using one, I don't have a good answer on what goes wrong right now. If you have access to other Azure storage accounts in your subscription, you may try exploring data in them and see if the error reproduce on every one of them. That would hint on whether this might be something wrong with that storage account.

@JasonYeMSFT Thanks Jason. Under my same subscription, i am able to access another Storage account BLOB without issue. As you see below, BLOB that highlighted in red is unable to access and thrown the error. Could you please suggest what factors can be compared within these two storage accounts?

Try to see if you can list the containers of that storage account in https://portal.azure.com and if you can find anything helpful at https://portal.azure.com/#blade/Microsoft_Azure_Support/HelpAndSupportBlade/overview.
If nothing helps, you can open a support request and give the following information

The storage account having this issue
The error message
You are not using a proxy
It only happens on this specific storage account (indicating that this might be a service issue)
If you can list resources on Portal or not
The original error is found in Storage Explorer

I believe someone on the service side will check if there is any issue on the service. If they believe the problem is actually in Storage Explorer they will transfer the issue back to us.

@JasonYeMSFT I'm able to list the containers from https://portal.azure.com/. I will open a support request as you suggested.
Thanks for the help and guidance provided. With this I'm closing this task.


Reordering Modular with Folder Numeric Prefix trough the admin (drag&drop) sometimes messes up the folder names, creating duplicate folder prefixes or duplicates entire folders

Ok so this one still need more testing.
With the latest version of 1.7 (I can confirm the issue on at least the 2 previous versions)
When ordering modular folders trough the admin then saving tend to rename folders improperly, and sometimes creates duplicates. I have a feeling this happens more often (or only) when reordering folders I am currently in ? (Not sure if that's clear)
Anyway, the only thing I can do to fix this is then to ftp in and clean everything manually.
I'll update next week. But I had this issue on 2 or 3 sites running 1.7 now so it's starting the look like a bug.

I did not experienced the issue with regular pages, but then again, I rarely move pages around so this applying to modular might not be relevant.

When reordering causes duplication, only folders and md files are copied. Not the media. Don't know if it's relevant.

The version released yesterday works a bit better but still doesn't fix the issue fully. I did find the cause of this issue today, though.
Basically the issue was caused by an optimization with cache turned off. I commented out the code for now.

That's great news. Thanks!


Error When Build..

Hi, I receive this error when Build my project in 4.26.1
[1/4] Module.RuntimeFilesDownloader.cpp   X:/MastersUniverse/Plugins/RuntimeFilesDownloader/Source/RuntimeFilesDownloader/Private/RuntimeFilesDownloaderLibrary.cpp(33): error C2440: 'inicializando': não é possível converter de 'TSharedRef<IHttpRequest,ESPMode::ThreadSafe>' para 'TSharedRef<IHttpRequest,ESPMode::NotThreadSafe>'   X:/MastersUniverse/Plugins/RuntimeFilesDownloader/Source/RuntimeFilesDownloader/Private/RuntimeFilesDownloaderLibrary.cpp(33): note: No builder was able to receive the source type, or builder overhead resolution was ambiguous    [2/4] Module.RuntimeFilesDownloader.gen.cpp

Sorry, I forgot to update the plugin in main GutHub rep.
Fixed.


Maven settings file for snapshot and release upload to maven central

Codecov Report

Merging #119 into master will increase coverage by 0.18%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #119      +/-   ##
============================================
+ Coverage     76.79%   76.97%   +0.18%
- Complexity      951      954       +3
============================================
  Files            99       99
  Lines          3297     3297
  Branches        291      291
============================================
+ Hits           2532     2538       +6
+ Misses          614      602      -12
- Partials        151      157       +6

Impacted Files
Coverage Δ
Complexity Δ

...a/co/elastic/apm/report/ReportingEventHandler.java
78.78% <0%> (-3.04%)
9% <0%> (-1%)

...ain/java/co/elastic/apm/impl/transaction/Span.java
91.37% <0%> (ø)
22% <0%> (+1%)
:arrow_up:

...a/co/elastic/apm/impl/transaction/Transaction.java
76.74% <0%> (+1.16%)
26% <0%> (+1%)
:arrow_up:

...ain/java/co/elastic/apm/impl/ElasticApmTracer.java
78.14% <0%> (+2.64%)
41% <0%> (ø)
:arrow_down:

...co/elastic/apm/impl/transaction/TransactionId.java
90% <0%> (+6.66%)
17% <0%> (+2%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fc6c97...fdf4e5e. Read the comment docs.


Everything is visible to every one

any user can reply to any thread..
can you assist to fix this?

please see #29


Implicitly call expect(res).toSatisfyApiSpec() on each request and response

(Background: Please forgive me if my assumptions below about jest-openapi's existing functionality are incorrect. I'm currently seeking a tool to confirm that my existing API tests match my OpenAPI spec. My suggestion below is based on the functionality described in jest-openapi's README.md.)
At the moment, developers must call expect(res).toSatisfyApiSpec() on each response. However, developers might forget to call this function, and calling this function in every test is not a dry approach.
However, if jest-openapi could intercept each request and response from a particular HTTP client, say axios, then requests and responses could be validated for syntax against an OpenAPI spec implicitly and automatically. This would leave the developer free to write logical API tests ("if I delete a user, then calling GET should return 404"), while simultaneously checking request and response syntax for conformity with the OpenAPI spec in the background.
The configuration for such implicit testing could be placed in the jest.config.ts file for test suite. The config could include the paths to the OpenAPI spec(s), the HTTP client(s) to intercept, and which domain(s) to consider for validation.
This project looks really cool! Keep up the good work!

Hi @CameronHudson8, thanks for raising this :) This reminds me of https://github.com/openapi-library/OpenAPIValidators/issues/55, what do you think about that discussion?

Hi @CameronHudson8, thanks for raising this :) This reminds me of #55, what do you think about that discussion?

That discussion certainly does touch on some similar ideas. For instance, @blelump says:

So we have, lets call them unit specs, which are all the specs discussed above so you cover the happy paths and you're sure that all endpoints are bug-free (and only this). But we also have more sophisticated specs, closer to acceptance ones, where you follow some common real use case and check against more custom expectations that are important to check.

I think @blelump is mistaken in the first sentence, which he acknowledges in a later post. But he is touching on the distinction I made between syntactic correctness (conformance to the OAS) and logical correctness from a functionality perspective. For requests x, the server is like a function f(x) that returns responses y. The OAS only tells you of the schema of the requests (the domain of x) and the schema of the responses (the range of y). The OAS does not tell you anything about f and how it transforms x to y. This is what integration/e2e/acceptance tests are for.
I agree with @blelump's conclusion that there is not much value in calling the API with the example requests in the OAS, especially because an authentication token or pre-existing [mock] database entries will be needed for most requests.
However, I think we can all agree that each request sent to the server, and each response returned from it, should conform to the API spec. You've already implemented the heavy lifting in this jest-openapi project, which is validating the request/response against the OAS. What I describe in this feature request would require some tooling to intercept the requests and responses of a particular HTTP client library. That's the hard part. After that, the implementation would be pretty easy: call the existing expect(responseObject).toSatisfyApiSpec() assertions against the request and response.
Hold on, I actually just googled a bit about Axios and how to intercept requests, and it already has such a feature built in. This would make the implementation far easier. It might be as simple as calling this code before the test. (As a less dry but simpler alternative, it could be called in the beforeAll block of each test suite.) So I guess I could already accomplish what I describe in this feature request, but it would be even cooler if jest-openapi could call it behind the scenes, so that I didn't even have to call it in each beforeAll block.
// Please consider this to be pseudocode. I don't know the structure of the `config` or the `error` objects.

import axios from 'axios';
import jestOpenAPI from 'jest-openapi';

jestOpenAPI('path/to/openapi.yml');

// Add a request interceptor
axios.interceptors.request.use(function (config) {
    // Do something before request is sent
    expect(config).toSatisfyApiSpec();
    return config;
  }, function (error) {
    // Do something with request error
    return Promise.reject(error);
  });

// Add a response interceptor
axios.interceptors.response.use(function (response) {
    // Any status code that lie within the range of 2xx cause this function to trigger
    // Do something with response data
    expect(response).toSatisfyApiSpec();
    return response;
  }, function (error) {
    // Any status codes that falls outside the range of 2xx cause this function to trigger
    // Do something with response error
    expect(error).toSatisfyApiSpec();
    return Promise.reject(error);
  });


Question: Is "Too hard" considered as incomplete ?

When I rebuild tasks and ask to delete incomplete tasks first, it seems that tasks marked as "Too hard" are deleted but the documentation (see below) says that only untouched or skipped tasks are considered incomplete.

If you check this option, then incomplete tasks (either untouched or skipped) will first be deleted from the challenge and then recreated as needed based from the latest source data. Tasks in other statuses will not be removed.
-- Source: Documentation

On a second thought, it's probably caused by the fact that the tasks didn't have an idea and the tasks might be duplicated!
Sorry for the noise.


mysql_example.py: ValueError: Currency formatting is not possible using the 'C' locale.

There is some strange bug in the payoff section:
Traceback (most recent call last):
  File "mysql_example.py", line 434, in <module>
    row['totals'] = locale.currency(row['totals'], grouping=True)
  File "/Users/skabbit/venv/venv/lib/python2.7/locale.py", line 264, in currency
    raise ValueError("Currency formatting is not possible using "
ValueError: Currency formatting is not possible using the 'C' locale.

Setting locale in ENV doing nothing, because of this line:
locale.setlocale(locale.LC_ALL, '') # for pretty printing numbers

you need to set the LANG variable
like export LANG=en_US.UTF-8


[TASK][EASY] Add Grafana dashboard

What's the level of this task?
EASY
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before creating

[X] I have searched in the task list and found no similar tasks.

Mentor

[ ] I have sufficient expertise on this task, and I volunteer to be a mentor of this task to guide contributors through the task.

Skill requirements

Knowledge on Grafana
Familiar with the Kyuubi Metrics system

Background and Goals
https://github.com/apache/kyuubi/pull/5147
Implementation steps
https://github.com/apache/kyuubi/pull/5147
Additional context
Introduction of 2023 Kyuubi Code Contribution Program

This task is nearly done by @zhaohehuhu via https://github.com/apache/kyuubi/pull/5147


Credentials method in main is not straightfoward.

Credentials method (line 959) is in the Fortify group but also handles webinspect parameters.
There has to be a better way to handle shared methods between the different scanners that is less ambiguous.

remediated in 2.1.2


Governance. Vote history counter is changing.

Description
When user switch between referenda vote history counter is changing

Steps to Reproduce

Go to Governance page
Open any Referenda
Open its Vote history
Open another Referenda
Open its Vote history

Expected Behavior
Vote counter is showing when votes are loaded
Actual Behavior
Shows counter for previous Referenda until current votes will be loaded
https://github.com/user-attachments/assets/05cd776c-7b27-4be4-885c-632633bf2cc1
Environment
https://github.com/novasamatech/nova-spektr/commit/74fb677ee2dd26a02c67eeb6860265cc9bea9add

Status verification: ✅


q-values in single_snp() output?

Hi,
Does FaST-LMM provide q-values, apart of p-values, when creating the pandas dataframe with single_snp() function?
Best,
Jorge

Jorge,
Thanks as always for using FaST-LMM!
It doesn't offer q-Values directly, but I believe you can compute q-values and append them to the results of a single_snp run like so:
import statsmodels.stats.multitest as smm
import pandas as pd

p_values = results_df['PValue']

# Adjust p-values to q-values using the Benjamini-Hochberg procedure
_, q_values, _, _ = smm.multipletests(p_values, alpha=0.05, method='fdr_bh')

# Add q-values to the results dataframe
results_df['QValue'] = q_values
results_df.head(n=10)

When I do this with the example from the notebook , I get:

Please see the statsmodels documentation to see the options for computing q-values.
-- Carl

Hi,
That's works perfect. Thanks a lot!
Best,
Jorge


When fetching vendors the vendorId is not retuned

In function transformBillVendorsData you assume that API endpoint returns vendorId and in reallity it returns vendorid (lowercase i)
Thus the vendorId is always set to undefined

in BillVendors.ts
vendor_id: vendorId, -> vendorid: vendorId

Hi @michael-polonsky. This should be resolved now and a new version has been published.


ip whitelist rule is not cleaned up after running a test case

Duplicate of https://github.com/exasol/pytest-plugins/issues/19


removes hop-by-hop headers in responses

Changes proposed in this PR

removes connection-specific header fields when transmitting HTTP/1.x message via HTTP/2

Why are we making these changes?

HTTP/2 does not use the Connection header field to indicate connection-specific header fields; in this protocol, connection-specific metadata is conveyed by other means. An endpoint MUST NOT generate an HTTP/2 message containing connection-specific header fields; any message containing connection-specific header fields MUST be treated as malformed (Section <IP_ADDRESS>).
The only exception to this is the TE header field, which MAY be present in an HTTP/2 request; when it is, it MUST NOT contain any value other than "trailers".
This means that an intermediary transforming an HTTP/1.x message to HTTP/2 will need to remove any header fields nominated by the Connection header field, along with the Connection header field itself. Such intermediaries SHOULD also remove other connection-specific header fields, such as Keep-Alive, Proxy-Connection, Transfer-Encoding, and Upgrade, even if they are not nominated by the Connection header field.

https://http2.github.io/http2-spec/

@sradack ready to merge (unrelated CLI tests failing).


Add high level llama-cpp-python logits processor

Implement an outlines based logits processor for llama-cpp-python according to the interface in docs: https://llama-cpp-python.readthedocs.io/en/latest/api-reference/#llama_cpp.LogitsProcessor

This would be a much better way to integrate with llama.cpp since it would require less maintenance on our end.

Yeah, I guess this is also true for transformers and others (👀 TensorRT-LLM).


SharedWithMe : query parameters?

We are considering using the sharedWithMe graph api
https://developer.microsoft.com/en-us/graph/docs/api-reference/v1.0/api/drive_sharedwithme
but there is no documentation about what query parameter it supports.
My guess is that it does not support any, but then will it always return all the files shared with me or is there an intrinsic limit? @rgregg

You can specify a top (most API's support some OData query parameters).  In the case of shared with me, the API will attempt to respect that parameter.

Is there a list of these query parameters somewhere?


Future plans for 'sudo' LDAP group

Use LDAP to add admins to the 'sudo' group to add passwordless sudo.

I don't think sudo should be passwordless for anyone.

IIRC, everyone is in agreement not to do that now.
Can we close the branch?


task/Extract NON-TRANSLATABLE string into a separate file

Extracting all strings "translatable=false" into a file named: non-translatable.xml file to be located in "values"
In ru-RU strings changed rsb_chart_pie_value from %1$s% to %1$s％
Changed rsb_please_wait eclipses to … in hu and ru
Changed Ok or ok to OK in all en languages

Some ok are still not on uppercase. For example on the file cs-rCZ for the string rsb_ok.

Some ok are still not on uppercase. For example on the file cs-rCZ for the string rsb_ok.

You are right, but they were not giving warning in Android Studio, so when investigated them, I discovered that they are written in different ISO characters so I didn't wish to miss them up with no permission, and because I am not sure about these language strictness and regulations.

Some ok are still not on uppercase. For example on the file cs-rCZ for the string rsb_ok.

You are right, but they were not giving warning in Android Studio, so when investigated them, I discovered that they are written in different ISO characters so I didn't wish to miss them up with no permission, and because I am not sure about these language strictness and regulations.

Are you sure for all of them. For example there is this one :
ok on the de-rCH folder.

Some ok are still not on uppercase. For example on the file cs-rCZ for the string rsb_ok.

You are right, but they were not giving warning in Android Studio, so when investigated them, I discovered that they are written in different ISO characters so I didn't wish to miss them up with no permission, and because I am not sure about these language strictness and regulations.

Are you sure for all of them. For example there is this one :
<string name="rsb_ok">ok</string> on the de-rCH folder.

Yes I am positive, they are not giving warning, I just doubled checked.
But if you want me to change all even if there character looks strange, just say the word.

Oh i was thinking that it was a part of the ticket but it's not. Are you sure that it's something wanted ?

Oh i was thinking that it was a part of the ticket but it's not. Are you sure that it's something wanted ?

From what I observed yesterday that I have to have an eye for other fixes that can be done beside he main task, but I still need confirmation


feat: implement FTI

Closes #208

This PR will be on hold for now until we get a green light to implement in devnet & testnet


Test and review using Digital Rebar to deploy Kubernetes clusters on Packet.net

Goal: Deploy a Kubernetes cluster to bare metal using a PXE boot install method on Packet.net
This should cover starting with no Packet nodes and all the way to a running Kubernetes cluster  which supports deploying apps via helm charts.
A user should be able to start with nothing more than a Packet.net account.
The steps would look something like:

User has a Packet API key
User goes to a public github repo
User clones repo
User adds Packet API key to environment or some config file
User runs script or copy and pastes commands to get a k8s cluster

Could start with SSH to a brand new packet instance, launched from Packet dashboard, and run everything else from command line

Videos and docs referenced:

RackN Rebar KRIB training/demo videos => https://www.youtube.com/playlist?list=PLXPBeIrpXjfhKqmTvxI5-0CmgUh82dztr
Digital Rebar KRIB Complete Run Through => https://www.youtube.com/watch?v=rzBq3BsYQTM
Using the RackN Terraform provider => https://www.youtube.com/watch?v=5trB3_IFFX8
http://provision.readthedocs.io/en/tip/doc/content-packages/krib.html#component-krib
https://provision.readthedocs.io/en/tip/doc/integrations/krib.html

Tried to use Terraform plan that builds the whole KRIB cluster from the command line following the video https://www.youtube.com/watch?v=5trB3_IFFX8 and documentation for building the terraform provider https://github.com/rackn/terraform-provider-drp#building-the-provider, but ran into validation errors.  Opened a ticket on the provider repo
https://github.com/rackn/terraform-provider-drp/issues/56

As there were no all command line walk-throughs for only using the rebar command  line we refocused on using the Rebar web ui for now.

TIP: Reset profile or create a new one to clear k8s API server IP
Reusing a existing profile fails because the Kubernetes API server IP is already populated in the profile
Creating a brand new profile or reseting the profile in rebar fixes the issue.

While using the web-ui we ran into what looks like a certificate related issue when the KRIB workflow is running.  Opened a upstream ticket, https://github.com/digitalrebar/provision-content/issues/133, with the instructions to reproduce.

Cc @zehicle

After to running the new steps below https://github.com/digitalrebar/provision-content/issues/133#issuecomment-418587494

Go to https://portal.rackn.io/#/e/<IP_ADDRESS>:8092/bulk

Select all machines to be used in new k8s cluster

Use profile drop down to choose the profile "myprofile"

Click the + symbol to add the profile to the machines

Use Workflows drop down to choose the krib-reset-cluster workflow

Click the Change Workflow button (play / skip button)   - This will reset the certs

We were successfully able to deploy a K8s cluster on RackN/Packet with both the GUI and Terraform

@denverwilliams since this was successful, can we close the ticket?

What's left:
@denverwilliams to provide additional documentation to this ticket, then close.


fix: latest resources only aligned center on product page

Fix #
Test URLs:

Before: https://main--moleculardevices--hlxsites.hlx.page/products/clone-screening/mammalian-screening/cloneselect-imager
After: https://resources-align-center--moleculardevices--hlxsites.hlx.page/products/clone-screening/mammalian-screening/cloneselect-imager

Test URLs:

Before: https://main--moleculardevices--hlxsites.hlx.page/applications/3d-cell-models/organoids/intestinal-organoids
After: https://resources-align-center--moleculardevices--hlxsites.hlx.page/applications/3d-cell-models/organoids/intestinal-organoids

Now the 'View all Resources' below is not centered any more. I think we should remove that button from the content and add it via the block. WDYT? It always links to '#resources' to jump to the resources tab.


Restaurant Menu needs angular and core

https://play.nativescript.org/?template=play-vue&id=sPOHNo&v=30

I'm working on adding Angular

Here is a link to the Angular addition, let me know if you find any issues.
https://play.nativescript.org/?template=play-ng&id=DVxbTC&v=11

Looks great! The only issue I'm seeing on both of these (Vue and Angular) is the back arrow is really hard to tap. If it's an easy fix, great, otherwise don't worry about it.

No worries, I'll get that fixed and post an updated link for both.

Updated links
Angular: https://play.nativescript.org/?template=play-ng&id=DVxbTC&v=12
Vue: https://play.nativescript.org/?template=play-vue&id=sPOHNo&v=70


Add non standard port for SSH Tunnel

Add not standard port fir SSH Tunnel

Hi,
I will merge your PR ASAP (probably this week).
Thanks


Library not working on PHP5.3 due to [], PHP5.3 only support array().

Facing this issue on PHP 5.3.8.

Thank you for reporting this.
I’ll update it when I get home.
or I can merge a pr if you can create one.

Sorry to tell you i might not skillful enough to make a pull request,
I done some modification on the source code from this library, it look working at the moment. After your update i will update again and any issues will update to you.
Thanks for your coding !


Check GraphQL schema in CI

This adds a buildkite job to check that our GraphQL schema is up-to-date. This would have prevented #7838, as well as all of the other times the schema has become mismatched.
Checklist:

[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them:

!approved-for-mainnet


Normalizers: add single array normalization and revert methods

These methods should become standard methods of the DataNormalization interface:

transform(INDArray features)
transformLabels(INDArray labels)
revertFeatures(INDArray normalizedFeatures)
revertLabels(INDArray normalizedLabels)

https://github.com/deeplearning4j/nd4j/pull/1418


Test execution fails due to lazy containing multibyte characters

Problem
If the lazy contains multibyte characters such as Japanese, the test may fail.
Sample code
https://github.com/tukiyo320/rspec-parameterized-core/commit/bd09082a8d2609e442da248c15b89e54910d2c33
Situation
An additional condition occurs when one of the following two conditions is met

A. multibyte characters are used in the description of the ancestor (including the parent) context
B. There are other parameters in the parameter list to which lazy belongs that contain multibyte characters.

The error is as follows in both cases, but the location where the error occurs depends on the pattern.
Encoding::CompatibilityError: incompatible character encodings: UTF-8 and ASCII-8BIT

A. https://github.com/rspec/rspec-core/blob/f273314f575ab62092b2ad86addb6a3c93d6041f/lib/rspec/core/metadata.rb#L320
B. https://github.com/rspec-parameterized/rspec-parameterized-core/blob/94ed77992543f76d849805fd22f3fd38798b8f9d/lib/rspec/parameterized/core.rb#L114
Cause
In both cases, the error seems to occur in the title generation part of the test case, and is probably caused by not reading the source code with the correct character encoding when interpreting the parameter list as a string.
For example, forcing the following encoding in LazyArgs#inspect works fine (of course, a deterministic encoding is not a good solution)
"#{@block.to_raw_source}".force_encoding('utf-8')

Tracing the cause, it seems that it is already treated as an unknown charset (ASCII-8BIT) inside the proc_to_ast gem that is used to read the source code.
https://github.com/joker1007/proc_to_ast/blob/60c95582828edb689d6f701543f8ae1b138139fc/lib/proc_to_ast.rb#L31
Workaround
If you specify case_name in the parameter list, the problem processing will be skipped and it will work correctly.
Since there are not many tests that use lazy, this solution is not a problem, but we would like to see the hassle of specifying it and the difficulty in understanding the error eliminated.
Remarks

Sorry, but I haven't come up with a good solution.
If you expect to specify case_name, it would be more helpful to put it in README or something.
If you finally decide that the issue needs to be fixed with proc_to_ast, please comment on it (I will make an issue there).

@tukiyo320 Thanks for the detailed sample code. I understand your issue.
I'm prefer to fix https://github.com/joker1007/proc_to_ast, but rspec-parameterized-core isn't bad either.
@joker1007 What do you think?

I'm sorry for the late response.
I fixed the encoding mismatch in proc_to_ast gem.
And, I released v0.2.0.
https://github.com/joker1007/proc_to_ast/pull/4
Please use the version.
Thanks!

@joker1007 thank you!
@tukiyo320 Just to be safe, I have made sure to use proc_to_ast 0.2.0+ with #12 and published as v1.0.1 🚀  https://github.com/rspec-parameterized/rspec-parameterized-core/releases/tag/v1.0.1

@sue445 @joker1007 Thank you all for your support!


Support viewing coverage on private repos

In order to support coverage on private repos, we will need the user to supply the extension with a Codecov API token. These tokens are accessible from the access tab of the user’s settings menu (e.g., https://app.codecov.io/account/gh/<user>/access).
If the user tries to view a private repo and does not have a token saved in the extension, we should display a warning on the page when they try to view coverage.

completed as part of current beta release


Fix CI Tests

As described in title, CI tests failed caused by wrong karma configuration

Coverage remained the same at 75.904% when pulling 0e92e34f60aa65651c9ee946d052048af59028fc on emmanuelgautier:fix-ci-tests into d4fde733e292637a1b67ea596257e706aeae3fd4 on jasonslyvia:master.

Cool, thanks for your contribution!

Do you intend on merging this?

@stevemk14ebr I don't see a reason why not :)


.ReadingTime doesn

ReadingTime is only based on the word count. This is too rough though for posts that contain code samples: code blocks usually don’t contain a lot of white space, but take significantly more time to read then an equal amount of plain text.
My suggestion is to use different algorithms for plain text and code blocks. As an idea, the reading time in code blocks could be dependent on the line length.

Sorry, this issue can be deleted. I was still drafting around for #4815 and apparently it somehow got submitted halfway between…


Add --all and --latest to checkpoint/restore

This started as a simple change to add --all and --latest to the checkpoint and restore commands.
While adding these features I saw that the same code to handle --all and --latest can be found in multiple places. So I extended this PR to include common code for --all and --latest handling and replaced the code with the newly added common code at a few places. Overall this PR removes more lines of code than it adds.
I have run the test suite after each commit locally and the results looked good.
I initially included the changes also in port.go but as the port command allows a port to be listed after -l the newly added common logic cannot be used in port.go.

/approve

Code LGTM

LGTM

@adrianreber Mind rebasing to pick up CI fixes?

/retest

/approve
/lgtm

@adrianreber Needs a rebase.

/lgtm

Sorry, rebasing broke the import statements. Fixed and force pushed.

bot, retest this please

/retest images

I was testing in the wrong directory and was pushing broken code. Not good. This time I verified that I actually tested it correctly. Sorry for all the noise here.

/lgtm


Cannot save large 3d asset

Trying to create 3d asset with "site_terrain". It does not create it and refreshes the 3d asset manager instead.

I am seeing it now and in parallel I will make some changes for the 2 texture files feature

It is working fine. I did not find any problems


Prewarmed/automatic "builder extensions"

What would you like to be added:
The next step after #104 would be prepopulate builder extensions for consts and defaults found in the schema.
Why is this needed:
This would allow to ease up maintenance between versions of the specification.

I think this is covered by #114, isn't it @antmendoza ?

👍


[question] How to scope buffers to tab pages?

Say if I open a buffer when a certain tab page is open, I want that buffer to appear in cokeline only when that tab page is open. Under any other tab page, that buffer is hidden.
Is this possible in cokeline, and do you have any general pointers for how to best implement this? (Alternatively, would this be a good new feature to be built into cokeline?)

I think this is a cool feature

I found a workaround: use bufferline.nvim with scope.nvim. I'd still prefer a real solution though.

Absolutely planning on adding this feature!


Handle gem2s response refactoring

Background
Link to issue
Link to staging deployment URL
https://ui-martinfosco-uidevelop-api1.scp-staging.biomage.net/
Links to any Pull Requests related to this
https://github.com/biomage-ltd/pipeline/pull/68
Anything else the reviewers should know about the changes here
Changes that came up from the code review for ticket https://biomage.atlassian.net/browse/BIOMAGE-947 with marcell, forgot to push them.
Changes
Code changes
Definition of DONE
Your changes will be ready for merging after each of the steps below have been completed:
Testing

[ ] Unit tests written
[ ] Tested locally with Inframock (with latest production data downloaded with biomage experiment pull)
[ ] Deployed to staging

To set up easy local testing with inframock, follow the instructions here: https://github.com/biomage-ltd/inframock
To deploy to the staging environment, follow the instructions here: https://github.com/biomage-ltd/biomage-utils
Documentation updates
Is all relevant documentation updated to reflect the proposed changes in this PR?

[ ] Relevant Github READMEs updated
[ ] Relevant wiki pages created/updated

Approvers

[ ] Approved by a member of the core engineering team
[ ] (UX changes) Approved by vickymorrison (this is her username, tag her if you need approval)

Just before merging:

[ ] After the PR is approved, the unstage script in here: https://github.com/biomage-ltd/biomage-utils is executed. This script cleans up your deployment to staging

Optional

[ ] Photo of a cute animal attached to this PR

Staging was working weird, I'll make sure it is actually ok on staging before merging in


Migrate to Phoenix LiveView

Phoenix LiveView will not be used. The Elixir Phoenix part of the application stays purely an API.

Replaced by #47


remove warnings in network create response

Signed-off-by: allencloud<EMAIL_ADDRESS>I think this warning the handler of network create is useless. Here is my reasons:

there is no things to deal this warning in client side;
warning in createNetwork is only one kind, while this is an error

Here is my test, no warning showing but shows an error:
root@ubuntu:~# docker network create aaa
f0e75c67115ed827cb50c78d21de158ee4832aa67a53839f5fed545552845406
root@ubuntu:~# docker network create aaa
Error response from daemon: network with name aaa already exists

- What I did
- How I did it
- How to verify it
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Hm, I'm not sure; at least we should look at this properly; take the following situation;
$ docker network create foo
Error response from daemon: network with name foo already exists

$ docker network create -d overlay foo
Error response from daemon: network with name foo already exists

If we remove these warnings, I may assume I just created an overlay network named "foo", but in fact I'm using a "local" network.
For reference, there's also this PR, which is about volumes; https://github.com/docker/docker/pull/27675

Oh, thanks for your feedback @thaJeztah
I do not think I made my point clear. I mean although we disigned field Warning in struct NetworkCreateResponse, actually we did not take advantange of it yet.

in the client side, cli did not do any thing with the Warning field: https://github.com/docker/docker/blob/master/cli/command/network/create.go#L97-L102, and this warning will not show in the err. As a result, it won't influence the the client side.

in the daemon side, it is still not used so well. Since if we got a warning, in fact we should return this warning in every return, while there are no.  And in addition, if name conflict happens, it is already in the err: with

Error response from daemon: network with name foo already exists

While the warning is
Network with name foo (id : dsfdtre24354das...) already exists

They are duplicated.
So I still think that maybe this warning is not used well in the daemon side. If we all agree that, we can move to think whether it should in the api side struct NetworkCreateResponse, this part we should be more careful.

@thaJeztah
any update? 😄

I found that only when user hopes to create two networks with same name with "checkDuplicate":false in network create request payload, this warning is used.
described in https://github.com/docker/docker/issues/30242.


migrate to indy scala concurrent plugin

closes #1337

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

Expand to view the summary

Build stats

Build Cause: [Pull request #1367 opened]

Reason: The PR is not allowed to run in the CI yet

Start Time: 2020-08-30T20:43:26.387+0000

Duration: 5 min 42 sec

Commit: 078d90519108c50e2815f5ddbd7275acb71f291c

Steps errors
Expand to view the steps failures

Name: Error signal

Description: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permission

Duration: 0 min 0 sec

Start Time: 2020-08-30T20:48:04.439+0000

log

Log output
Expand to view the last 100 lines of log output

[2020-08-30T20:47:39.856Z] Pruning obsolete local branches
[2020-08-30T20:47:39.795Z]  > git config remote.origin.url git@github.com:elastic/apm-agent-java.git # timeout=10
[2020-08-30T20:47:39.801Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2020-08-30T20:47:39.812Z]  > git config remote.origin.url git@github.com:elastic/apm-agent-java.git # timeout=10
[2020-08-30T20:47:39.822Z]  > git rev-parse --verify HEAD # timeout=10
[2020-08-30T20:47:39.836Z] No valid HEAD. Skipping the resetting
[2020-08-30T20:47:39.836Z]  > git clean -fdx # timeout=10
[2020-08-30T20:47:39.861Z] Fetching upstream changes from git@github.com:elastic/apm-agent-java.git
[2020-08-30T20:47:39.862Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-08-30T20:47:39.867Z]  > git fetch --no-tags --progress --prune -- git@github.com:elastic/apm-agent-java.git +refs/pull/1367/head:refs/remotes/origin/PR-1367 +refs/heads/master:refs/remotes/origin/master # timeout=15
[2020-08-30T20:47:40.527Z] Merging remotes/origin/master commit cc5bd65389c4ca904180676d1803aae7c442f6ea into PR head commit 078d90519108c50e2815f5ddbd7275acb71f291c
[2020-08-30T20:47:40.794Z] Merge succeeded, producing 078d90519108c50e2815f5ddbd7275acb71f291c
[2020-08-30T20:47:40.794Z] Checking out Revision 078d90519108c50e2815f5ddbd7275acb71f291c (PR-1367)
[2020-08-30T20:47:40.535Z]  > git config core.sparsecheckout # timeout=10
[2020-08-30T20:47:40.540Z]  > git checkout -f 078d90519108c50e2815f5ddbd7275acb71f291c # timeout=15
[2020-08-30T20:47:40.744Z]  > git remote # timeout=10
[2020-08-30T20:47:40.756Z]  > git config --get remote.origin.url # timeout=10
[2020-08-30T20:47:40.760Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-08-30T20:47:40.764Z]  > git merge cc5bd65389c4ca904180676d1803aae7c442f6ea # timeout=10
[2020-08-30T20:47:40.782Z]  > git rev-parse HEAD^{commit} # timeout=10
[2020-08-30T20:47:40.797Z]  > git config core.sparsecheckout # timeout=10
[2020-08-30T20:47:40.803Z]  > git checkout -f 078d90519108c50e2815f5ddbd7275acb71f291c # timeout=15
[2020-08-30T20:47:44.659Z] Commit message: "migrate to indy scala concurrent plugin"
[2020-08-30T20:47:44.659Z] First time build. Skipping changelog.
[2020-08-30T20:47:44.659Z] Cleaning workspace
[2020-08-30T20:47:44.750Z]  > git --version # timeout=10
[2020-08-30T20:47:44.753Z]  > git --version # 'git version 2.17.1'
[2020-08-30T20:47:44.756Z] fatal: bad object 06c62f097a3109e82d977b3292df1e77ce92ff26
[2020-08-30T20:47:44.662Z]  > git rev-parse --verify HEAD # timeout=10
[2020-08-30T20:47:44.667Z] Resetting working tree
[2020-08-30T20:47:44.667Z]  > git reset --hard # timeout=10
[2020-08-30T20:47:44.690Z]  > git clean -fdx # timeout=10
[2020-08-30T20:47:45.646Z] Masking supported pattern matches of $JOB_GCS_BUCKET or $NOTIFY_TO
[2020-08-30T20:47:45.717Z] Timeout set to expire in 1 hr 0 min
[2020-08-30T20:47:45.746Z] The timestamps step is unnecessary when timestamps are enabled for all Pipeline builds.
[2020-08-30T20:47:46.154Z] [INFO] Number of builds to be searched 10
[2020-08-30T20:47:46.517Z] [INFO] 'shallow' is forced to be disabled when running on PullRequests
[2020-08-30T20:47:46.543Z] Running in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1367/src/github.com/elastic/apm-agent-java
[2020-08-30T20:47:46.582Z] [INFO] gitCheckout: Checkout SCM PR-1367 with some customisation.
[2020-08-30T20:47:46.614Z] [INFO] Override default checkout
[2020-08-30T20:47:46.685Z] Sleeping for 10 sec
[2020-08-30T20:47:56.826Z] using credential f6c7695a-671e-4f4f-a331-acdce44ff9ba
[2020-08-30T20:47:56.850Z] Cloning the remote Git repository
[2020-08-30T20:47:56.863Z] Cloning repository git@github.com:elastic/apm-agent-java.git
[2020-08-30T20:47:56.886Z]  > git init /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1367/src/github.com/elastic/apm-agent-java # timeout=10
[2020-08-30T20:47:56.909Z] Using reference repository: /var/lib/jenkins/.git-references/apm-agent-java.git
[2020-08-30T20:47:56.910Z] Fetching upstream changes from git@github.com:elastic/apm-agent-java.git
[2020-08-30T20:47:56.910Z]  > git --version # timeout=10
[2020-08-30T20:47:56.916Z]  > git --version # 'git version 2.17.1'
[2020-08-30T20:47:56.916Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-08-30T20:47:56.920Z]  > git fetch --tags --progress -- git@github.com:elastic/apm-agent-java.git +refs/heads/*:refs/remotes/origin/* # timeout=10
[2020-08-30T20:47:58.586Z] Checking out Revision 078d90519108c50e2815f5ddbd7275acb71f291c (origin/PR-1367)
[2020-08-30T20:47:57.795Z]  > git config remote.origin.url git@github.com:elastic/apm-agent-java.git # timeout=10
[2020-08-30T20:47:57.799Z]  > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10
[2020-08-30T20:47:57.811Z]  > git config remote.origin.url git@github.com:elastic/apm-agent-java.git # timeout=10
[2020-08-30T20:47:57.825Z] Fetching upstream changes from git@github.com:elastic/apm-agent-java.git
[2020-08-30T20:47:57.826Z] using GIT_SSH to set credentials GitHub user @elasticmachine SSH key
[2020-08-30T20:47:57.829Z]  > git fetch --tags --progress -- git@github.com:elastic/apm-agent-java.git +refs/pull/1367/head:refs/remotes/origin/PR-1367 +refs/heads/master:refs/remotes/origin/master # timeout=10
[2020-08-30T20:47:58.580Z]  > git rev-parse origin/PR-1367^{commit} # timeout=10
[2020-08-30T20:47:58.589Z]  > git config core.sparsecheckout # timeout=10
[2020-08-30T20:47:58.595Z]  > git checkout -f 078d90519108c50e2815f5ddbd7275acb71f291c # timeout=10
[2020-08-30T20:47:58.780Z] Commit message: "migrate to indy scala concurrent plugin"
[2020-08-30T20:47:58.796Z]  > git --version # timeout=10
[2020-08-30T20:47:58.803Z]  > git --version # 'git version 2.17.1'
[2020-08-30T20:47:58.807Z] fatal: bad object 06c62f097a3109e82d977b3292df1e77ce92ff26
[2020-08-30T20:47:59.879Z] Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[2020-08-30T20:48:00.528Z] + git fetch<EMAIL_ADDRESS>+refs/pull/*/head:refs/remotes/origin/pr/*
[2020-08-30T20:48:01.150Z] Archiving artifacts
[2020-08-30T20:48:01.835Z] + git rev-parse HEAD
[2020-08-30T20:48:02.193Z] + git rev-parse HEAD
[2020-08-30T20:48:02.510Z] + git rev-parse origin/pr/1367
[2020-08-30T20:48:02.561Z] [INFO] githubEnv: Found Git Build Cause: pr
[2020-08-30T20:48:02.956Z] Masking supported pattern matches of $GITHUB_TOKEN
[2020-08-30T20:48:03.992Z] [WARN] githubApiCall: The REST API call https://api.github.com/repos/elastic/apm-agent-java/pulls/1367/reviews return 0 elements
[2020-08-30T20:48:04.058Z] [INFO] githubPrCheckApproved: Title: migrate to indy scala concurrent plugin - User: kananindzya - Author Association: CONTRIBUTOR
[2020-08-30T20:48:04.458Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet
[2020-08-30T20:48:04.458Z] ERROR: githubPrCheckApproved: The PR is not allowed to run in the CI yet. (Only users with write permissions can do so.)
[2020-08-30T20:48:04.547Z] [INFO] Let's stop build #1. The PR is not allowed to run in the CI yet
[2020-08-30T20:48:04.570Z] Sleeping for 5 sec
[2020-08-30T20:48:05.668Z] Stage "Build" skipped due to earlier failure(s)
[2020-08-30T20:48:05.860Z] Stage "Tests" skipped due to earlier failure(s)
[2020-08-30T20:48:06.039Z] Stage "Unit Tests" skipped due to earlier failure(s)
[2020-08-30T20:48:06.051Z] Stage "Smoke Tests 01" skipped due to earlier failure(s)
[2020-08-30T20:48:06.063Z] Stage "Smoke Tests 02" skipped due to earlier failure(s)
[2020-08-30T20:48:06.075Z] Stage "Benchmarks" skipped due to earlier failure(s)
[2020-08-30T20:48:06.086Z] Stage "Javadoc" skipped due to earlier failure(s)
[2020-08-30T20:48:06.256Z] Failed in branch Unit Tests
[2020-08-30T20:48:06.265Z] Failed in branch Smoke Tests 01
[2020-08-30T20:48:06.274Z] Failed in branch Smoke Tests 02
[2020-08-30T20:48:06.283Z] Failed in branch Benchmarks
[2020-08-30T20:48:06.291Z] Failed in branch Javadoc
[2020-08-30T20:48:06.543Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2020-08-30T20:48:06.629Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2020-08-30T20:48:06.671Z] Stage "AfterRelease" skipped due to earlier failure(s)
[2020-08-30T20:48:07.282Z] Running on Jenkins in /var/lib/jenkins/workspace/_java_apm-agent-java-mbp_PR-1367
[2020-08-30T20:48:07.597Z] [INFO] getVaultSecret: Getting secrets
[2020-08-30T20:48:07.679Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-08-30T20:48:08.951Z] + chmod 755 generate-build-data.sh
[2020-08-30T20:48:08.951Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1367/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1367/runs/1 ABORTED 282293
[2020-08-30T20:48:09.502Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-java/apm-agent-java-mbp/PR-1367/runs/1/steps/?limit=10000 -o steps-info.json


Make left and right modifiers distinguishable

Description
Hi, hope you all doing great <3
First of all, want to thank every contributor for such a wonderful window manager, it looks amazing!
However, one thing I would like to be adjusted, is the way modifier keys are treated. For now, both left and right modifiers (such as Shift_L and Shift_R) are mapped to a single modifier. It is a big flaw for me, and, probably, for other people who want to map their main modifier specifically to right/left modifier, not both.
For example, I want my main modifier to be right shift as it is the most convenient choice for me. My left pinky is overloaded because of constantly pressing shift and control, and my right pinky is almost atrophied because of not pressing anything at all. So I want to make them equal. Emacs pinky is not a good thing! Joking of course, that's not the real reason :) There are many other applications I can see in having left and right modifiers distinguishable.
One of them is to have left shift acting as a modifier in only one case - when switching between layouts. Right shift can be used as the main modifier for the rest of key bindings.
All in all, treating left and right modifiers as a single virtual modifier seems to be quite unreasonable, if on keyboards they are different keys with different key codes, why shouldn't we let them be so in our input handling libraries?
Just do demonstrate this, lets compare how many key bindings is possible to map with Shift, Ctrl and Alt when they are combined into a single modifier, and having Shift_L, Shift_R and the rest of them separately. On my keyboard there is 45 keys including digit keys.
*I do not consider key bindings with multiple modifiers (such as Ctrl + Shift + a), for the sake of simplicity.
Having only Alt, Shift and Ctrl gives us:
(45 for alt, 45 for ctrl, 45 for shift)
45 + 45 + 45 = 135
Having them distinguishable gives us twice more, 270. And that's only in case of mapping single modifier to a key.
You must be thinking - who on earth would have so many keybindings? :) And I agree, not so many people would.
But my main point is that we should not reduce the functionality of our keyboards without explicit reasons for this. I've seen couple posts on Reddit addressing this issue. I am sure many people like me would find it useful to have left and right modifiers distinguishable.

I just ran into this problem. Having this feature would be really great, that way you can separate the bindings into multiple categories. Hopefully in the future, thanks!

This is something that has confused me for a bit, I've also been told that its not possible with XKB. But my confusion is that if I test inputs with xev, and press keys like left and right control/alt. The Keycode and Keysym are distinct. For example:
# Event on Left Alt Down.
KeyPress event, serial 28, synthetic NO, window 0x400001,
    root 0x401, subw 0x0, time 313137102, (702,350), root:(735,1421),
    state 0x0, keycode 64 (keysym 0xffe9, Alt_L), same_screen YES,
    XLookupString gives 0 bytes:
    XmbLookupString gives 0 bytes:
    XFilterEvent returns: False

# Event on Right Alt Down.
KeyPress event, serial 28, synthetic NO, window 0x400001,
    root 0x401, subw 0x0, time 313134945, (702,350), root:(735,1421),
    state 0x0, keycode 108 (keysym 0xffea, Alt_R), same_screen YES,
    XLookupString gives 0 bytes:
    XmbLookupString gives 0 bytes:
    XFilterEvent returns: False

So this left me a bit confused as XKB does distinguish between the left and right modifier keys. But when I looked into Hyprland source it did seem that there was only an ENUM of 8 (iirc) modifier keys that consumed these inputs and only stored a single alt/ctrl. I'm interested to look deeper into this as its been a minute but I feel like there should be a way as Hyprland can identify the difference in the mod keys.
I'm guessing that mod keys may be treated uniquely though? I'm not sure, it would be super nice though! I'll look a little deeper into this though and hopefully report back. I'm curious though if anyone knows what i'm missing here?

Yeah I forgot you get key events. You can do that with the events, yes.

I got a POC working pretty well over the last few days. It also lets you use up to 8 arbitrary keys combined. Feel free to try it out here. Will create a PR in a day or two after some cleanup and testing.
https://github.com/The-Briel-Deal/Hyprland/tree/multi-key-binds-v2

I got a POC working pretty well over the last few days. It also lets you use up to 8 arbitrary keys combined. Feel free to try it out here. Will create a PR in a day or two after some cleanup and testing.
https://github.com/The-Briel-Deal/Hyprland/tree/multi-key-binds-v2

I've looked at the your source and it did not seem to me that it's addressing the issue I described.
Can you confirm that your version indeed can treat left and right modifier separately? For example can I create a bind with left shift only? So the bind only triggers on left shift + some char but not on right shift + some char.
I will compile and try it when I have some spare time. But I would be glad if you can answer it here directly.

Yea! To do what you want with how it is now, you'll use the following:
bind = CTRL, Control_R&K, exec, kitty
or just:
bind = ,Control_R&K, exec, kitty

(You can get the specific keynames like Control_R by using xev, you'll also be able to use keycodes but I'll document that along with the PR)
I would just wait until the PR is up later today though, I'm still actively working on it so things may break.

Explained more in the PR: https://github.com/hyprwm/Hyprland/pull/5966.

Hey @VladP812, its in a pretty workable state now in theory! It would be awesome if you could try it out and let me know if you would do anything different.
The last thing I'm working on is figuring out an intuitive way to consume keys. So currently if you press Ctrl_R, then K, and then S for a bind it will still pass K through because the keybind wasn't completed yet.
I think I'm just going to hold that intermediate event until its clear if the bind is completed or not, and then I'll use the nonConsume flag to bring it back to this behavior.

@The-Briel-Deal just tried to compile your repo, got the following error:
[109/172] Building CXX object CMakeFiles/Hyprland.dir/src/protocols/OutputManagement.cpp.o
FAILED: CMakeFiles/Hyprland.dir/src/protocols/OutputManagement.cpp.o
/usr/bin/c++ -DHAS_EXECINFO -DHyprland_EXPORTS -DUSES_SYSTEMD -DWLR_USE_UNSTABLE -I/home/inri/Downloads/Hyprland2/. -I/home/inri/Downloads/Hyprland2/src -I/home/inri/Downloads/Hyprland2/subprojects/wlroots-hyprland/include -I/home/inri/Downloads/Hyprland2/subprojects/wlroots-hyprland/build/include -I/home/inri/Downloads/Hyprland2/subprojects/udis86 -I/home/inri/Downloads/Hyprland2/protocols -I/home/inri/Downloads/Hyprland2/subprojects/udis86/libudis86 -isystem /usr/include/uuid -isystem /usr/include/pango-1.0 -isystem /usr/include/cairo -isystem /usr/include/glib-2.0 -isystem /usr/lib/glib-2.0/include -isystem /usr/include/harfbuzz -isystem /usr/include/freetype2 -isystem /usr/include/pixman-1 -isystem /usr/include/libdrm -isystem /usr/include/libpng16 -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/sysprof-6 -isystem /usr/include/fribidi -O3 -DNDEBUG -std=gnu++23 -O3 -Wall -Wextra -Wno-unused-parameter -Wno-unused-value -Wno-missing-field-initializers -Wno-narrowing -Wno-pointer-arith -pthread -Winvalid-pch -include /home/inri/Downloads/Hyprland2/build/CMakeFiles/Hyprland.dir/cmake_pch.hxx -MD -MT CMakeFiles/Hyprland.dir/src/protocols/OutputManagement.cpp.o -MF CMakeFiles/Hyprland.dir/src/protocols/OutputManagement.cpp.o.d -o CMakeFiles/Hyprland.dir/src/protocols/OutputManagement.cpp.o -c /home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.cpp
/home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.cpp: In member function ‘void COutputHead::sendAllData()’:
/home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.cpp:169:64: **error: cannot convert ‘wl_resource*’ to ‘CZwlrOutputModeV1*’**
  169 |                 resource->sendCurrentMode(m->resource->resource());
      |                                           ~~~~~~~~~~~~~~~~~~~~~^~
      |                                                                |
      |                                                                wl_resource*
In file included from /home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.hpp:7,
                 from /home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.cpp:1:
/home/inri/Downloads/Hyprland2/protocols/wlr-output-management-unstable-v1.hpp:213:26: note:   initializing argument 1 of ‘void CZwlrOutputHeadV1::sendCurrentMode(CZwlrOutputModeV1*)’
  213 |     void sendCurrentMode(CZwlrOutputModeV1*);
      |                          ^~~~~~~~~~~~~~~~~~
/home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.cpp: In member function ‘void COutputHead::updateMode()’:
/home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.cpp:200:64: error: cannot convert ‘wl_resource*’ to ‘CZwlrOutputModeV1*’
  200 |                 resource->sendCurrentMode(m->resource->resource());
      |                                           ~~~~~~~~~~~~~~~~~~~~~^~
      |                                                                |
      |                                                                wl_resource*
/home/inri/Downloads/Hyprland2/protocols/wlr-output-management-unstable-v1.hpp:213:26: note:   initializing argument 1 of ‘void CZwlrOutputHeadV1::sendCurrentMode(CZwlrOutputModeV1*)’
  213 |     void sendCurrentMode(CZwlrOutputModeV1*);
      |                          ^~~~~~~~~~~~~~~~~~

Main repository compiles with no errors, any ideas what causes this?

Thats most likely because you don't have the latest AUR packages necessary. Also make sure you do git submodules sync and git submodules update. Take a look at the wiki installation page and make sure you install all the necessary AUR packages before building. (This looks like an issue with having an older version of wayland-protocols https://aur.archlinux.org/packages/wayland-protocols-git). Try running:
yay -Syu --devel
yay -S --devel wayland-protocols-git

From: VladP812 @.>
Sent: Friday, May 10, 2024 4:49 AM
To: hyprwm/Hyprland @.>
Cc: Gabriel Ford @.>; Mention @.>
Subject: Re: [hyprwm/Hyprland] Make left and right modifiers distinguishable (Issue #5517)
@The-Briel-Dealhttps://github.com/The-Briel-Deal just tried to compile your repo, got the following error:
[109/172] Building CXX object CMakeFiles/Hyprland.dir/src/protocols/OutputManagement.cpp.o
FAILED: CMakeFiles/Hyprland.dir/src/protocols/OutputManagement.cpp.o
/usr/bin/c++ -DHAS_EXECINFO -DHyprland_EXPORTS -DUSES_SYSTEMD -DWLR_USE_UNSTABLE -I/home/inri/Downloads/Hyprland2/. -I/home/inri/Downloads/Hyprland2/src -I/home/inri/Downloads/Hyprland2/subprojects/wlroots-hyprland/include -I/home/inri/Downloads/Hyprland2/subprojects/wlroots-hyprland/build/include -I/home/inri/Downloads/Hyprland2/subprojects/udis86 -I/home/inri/Downloads/Hyprland2/protocols -I/home/inri/Downloads/Hyprland2/subprojects/udis86/libudis86 -isystem /usr/include/uuid -isystem /usr/include/pango-1.0 -isystem /usr/include/cairo -isystem /usr/include/glib-2.0 -isystem /usr/lib/glib-2.0/include -isystem /usr/include/harfbuzz -isystem /usr/include/freetype2 -isystem /usr/include/pixman-1 -isystem /usr/include/libdrm -isystem /usr/include/libpng16 -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/sysprof-6 -isystem /usr/include/fribidi -O3 -DNDEBUG -std=gnu++23 -O3 -Wall -Wextra -Wno-unused-parameter -Wno-unused-value -Wno-missing-field-initializers -Wno-narrowing -Wno-pointer-arith -pthread -Winvalid-pch -include /home/inri/Downloads/Hyprland2/build/CMakeFiles/Hyprland.dir/cmake_pch.hxx -MD -MT CMakeFiles/Hyprland.dir/src/protocols/OutputManagement.cpp.o -MF CMakeFiles/Hyprland.dir/src/protocols/OutputManagement.cpp.o.d -o CMakeFiles/Hyprland.dir/src/protocols/OutputManagement.cpp.o -c /home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.cpp
/home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.cpp: In member function ‘void COutputHead::sendAllData()’:
/home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.cpp:169:64: error: cannot convert ‘wl_resource’ to ‘CZwlrOutputModeV1’**
169 |                 resource->sendCurrentMode(m->resource->resource());
|                                           ~~~~~^~
|                                                                |
|                                                                wl_resource*
In file included from /home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.hpp:7,
from /home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.cpp:1:
/home/inri/Downloads/Hyprland2/protocols/wlr-output-management-unstable-v1.hpp:213:26: note:   initializing argument 1 of ‘void CZwlrOutputHeadV1::sendCurrentMode(CZwlrOutputModeV1*)’
213 |     void sendCurrentMode(CZwlrOutputModeV1*);
|                          ^~
/home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.cpp: In member function ‘void COutputHead::updateMode()’:
/home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.cpp:200:64: error: cannot convert ‘wl_resource*’ to ‘CZwlrOutputModeV1*’
200 |                 resource->sendCurrentMode(m->resource->resource());
|                                           ~~~~~^~
|                                                                |
|                                                                wl_resource*
/home/inri/Downloads/Hyprland2/protocols/wlr-output-management-unstable-v1.hpp:213:26: note:   initializing argument 1 of ‘void CZwlrOutputHeadV1::sendCurrentMode(CZwlrOutputModeV1*)’
213 |     void sendCurrentMode(CZwlrOutputModeV1*);
|                          ^~
Main repository compiles with no errors, any ideas what causes this?
—
Reply to this email directly, view it on GitHubhttps://github.com/hyprwm/Hyprland/issues/5517#issuecomment-2104211301, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUWWCHCYWVUH45FMLO46V43ZBSC3DAVCNFSM6AAAAABF6PFJOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBUGIYTCMZQGE.
You are receiving this because you were mentioned.Message ID: @.***>

Thats most likely because you don't have the latest AUR packages necessary. Also make sure you do git submodules sync and git submodules update. Take a look at the wiki installation page and make sure you install all the necessary AUR packages before building. (This looks like an issue with having an older version of wayland-protocols https://aur.archlinux.org/packages/wayland-protocols-git). Try running: yay -Syu --devel yay -S --devel wayland-protocols-git
…
________________________________ From: VladP812 @.> Sent: Friday, May 10, 2024 4:49 AM To: hyprwm/Hyprland @.> Cc: Gabriel Ford @.>; Mention @.> Subject: Re: [hyprwm/Hyprland] Make left and right modifiers distinguishable (Issue #5517) @The-Briel-Dealhttps://github.com/The-Briel-Deal just tried to compile your repo, got the following error: [109/172] Building CXX object CMakeFiles/Hyprland.dir/src/protocols/OutputManagement.cpp.o FAILED: CMakeFiles/Hyprland.dir/src/protocols/OutputManagement.cpp.o /usr/bin/c++ -DHAS_EXECINFO -DHyprland_EXPORTS -DUSES_SYSTEMD -DWLR_USE_UNSTABLE -I/home/inri/Downloads/Hyprland2/. -I/home/inri/Downloads/Hyprland2/src -I/home/inri/Downloads/Hyprland2/subprojects/wlroots-hyprland/include -I/home/inri/Downloads/Hyprland2/subprojects/wlroots-hyprland/build/include -I/home/inri/Downloads/Hyprland2/subprojects/udis86 -I/home/inri/Downloads/Hyprland2/protocols -I/home/inri/Downloads/Hyprland2/subprojects/udis86/libudis86 -isystem /usr/include/uuid -isystem /usr/include/pango-1.0 -isystem /usr/include/cairo -isystem /usr/include/glib-2.0 -isystem /usr/lib/glib-2.0/include -isystem /usr/include/harfbuzz -isystem /usr/include/freetype2 -isystem /usr/include/pixman-1 -isystem /usr/include/libdrm -isystem /usr/include/libpng16 -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/sysprof-6 -isystem /usr/include/fribidi -O3 -DNDEBUG -std=gnu++23 -O3 -Wall -Wextra -Wno-unused-parameter -Wno-unused-value -Wno-missing-field-initializers -Wno-narrowing -Wno-pointer-arith -pthread -Winvalid-pch -include /home/inri/Downloads/Hyprland2/build/CMakeFiles/Hyprland.dir/cmake_pch.hxx -MD -MT CMakeFiles/Hyprland.dir/src/protocols/OutputManagement.cpp.o -MF CMakeFiles/Hyprland.dir/src/protocols/OutputManagement.cpp.o.d -o CMakeFiles/Hyprland.dir/src/protocols/OutputManagement.cpp.o -c /home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.cpp /home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.cpp: In member function ‘void COutputHead::sendAllData()’: /home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.cpp:169:64: error: cannot convert ‘wl_resource’ to ‘CZwlrOutputModeV1’** 169 | resource->sendCurrentMode(m->resource->resource()); | ~~~~~^~ | | | wl_resource* In file included from /home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.hpp:7, from /home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.cpp:1: /home/inri/Downloads/Hyprland2/protocols/wlr-output-management-unstable-v1.hpp:213:26: note: initializing argument 1 of ‘void CZwlrOutputHeadV1::sendCurrentMode(CZwlrOutputModeV1*)’ 213 | void sendCurrentMode(CZwlrOutputModeV1*); | ^~ /home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.cpp: In member function ‘void COutputHead::updateMode()’: /home/inri/Downloads/Hyprland2/src/protocols/OutputManagement.cpp:200:64: error: cannot convert ‘wl_resource*’ to ‘CZwlrOutputModeV1*’ 200 | resource->sendCurrentMode(m->resource->resource()); | ~~~~~^~ | | | wl_resource* /home/inri/Downloads/Hyprland2/protocols/wlr-output-management-unstable-v1.hpp:213:26: note: initializing argument 1 of ‘void CZwlrOutputHeadV1::sendCurrentMode(CZwlrOutputModeV1*)’ 213 | void sendCurrentMode(CZwlrOutputModeV1*); | ^~ Main repository compiles with no errors, any ideas what causes this? — Reply to this email directly, view it on GitHub<#5517 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUWWCHCYWVUH45FMLO46V43ZBSC3DAVCNFSM6AAAAABF6PFJOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBUGIYTCMZQGE. You are receiving this because you were mentioned.Message ID: @.***>

That was he first thing I did, but I updated from regular arch repository - it did not help. Then, following your suggestion I updated from user repository, but it did not help either. :(

Its alright, it should be merged soon enough. It needed some cleanup and testing for some edge cases before merging. Hopefully will have it in in the next few days if all goes well! Just doing some final checks.

Its merged btw, are we good to close this?


Docker Birthday issues triaging and ideas tracking

The idea is to triage some issues that the community can sink its teeth into (features that we don't have time enough to work on, for eg).
Also, stuff that we don't track yet (nice to have, debugging tools, extensions ideas) should be created here.
To have something as part of this, simply apply the milestone "Docker Birthday" and choose a label "white/black belt".
@endophage are you ok overseeing the effort here?

Yep. I'll go through the list of currently open issues and talk to the team to solicit additional ideas.

For reference, these are the "guidelines" for the triage process in docker; https://github.com/docker/docker/blob/master/project/ISSUE-TRIAGE.md
Apart from "white-belt"/"black-belt", docker also classifies the issues as
"Improvement", "Regression", "Feature" and "Bug".

Thank @thaJeztah I'll go through the issues closer to the date and make sure they all conform.
@dmp42 I've asked @NathanMcCauley to add some white belt issues for the health check api. They will be tickets to register services (S3, Cloudfront, etc...) with the health api. These should be reasonably simple but have a high value in ensuring the reliability of the registry.

Well past birthday now. Closing this.


cmake: Use _FORTIFY_SOURCE only with optimizations enabled

When compiling for native, some glibc versions has a check on the
use of _FORTIFY_SOURCE without optimizations enabled and gives a
preprocessor warning.
Signed-off-by: Thomas Ebert Hansen<EMAIL_ADDRESS>

Codecov Report

Merging #8886 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8886   +/-   ##
=======================================
  Coverage   52.31%   52.31%
=======================================
  Files         195      195
  Lines       24732    24732
  Branches     5141     5141
=======================================
  Hits        12939    12939
  Misses       9719     9719
  Partials     2074     2074

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b836d6...aa4b105. Read the comment docs.


Feature request: ability to post/report merge failures and other evaluation errors

When looking at older PRs i sometimes run into git merge conflicts. The current behavior for nixpkgs-review seems is to skip the PRs that fail to merge, never opening them in an interactive shell. Is it possible to add a feature where nixpkgs-review posts to github that the PR fails merging into master?
Currently I read the nixpkgs-review output and post comments such as these manually:
https://github.com/NixOS/nixpkgs/pull/153870#issuecomment-1207291016
https://github.com/NixOS/nixpkgs/pull/175034#issuecomment-1207293004

I think that is a bit out of scope for nixpkgs-review. GitHub already displays if there is a merge conflict in the web ui. The author does not receive a notification for that, so sometimes they need to be reminded about that.

Perhaps a merge conflict is out of scope, as the github ui already checks for mergeability. But nix evaluation errors, like the second comment linked, i believe is in scope. Perhaps the request for merge conflicts to be posted is too specific. What if i generalize the feature request to cover any reason nixpkgs-review could not enter the nix-shell environment?

For that the ofborg checks already exists which are stricter than nixpkgs-review. I don't think we should replicate them.
I don't think it is very useful to post failures directly on GitHub. nixpkgs-review can fail for many reasons like being OOM killed and entering the shell can fail for known reasons like multiple QT versions being used. If we don't fix those errors first or at least can reliable filter them then this feature would not be to useful for the PR author.


paragraphs in Zotero notes need \par

Report ID: JVQPVNN2-euc
Exporter used: BBT BibLaTex
Actual behavior: Notes with multiple paragraphs have their line breaks converted to LaTeX double newlines, e.g.

...unmodeled physics of the ISM.

Simulations show...

is exported as
annotation = {...unmodeled physics of the ISM.

Simulations show...}

However, this double newline is collapsed by Biber into a single space (https://tex.stackexchange.com/questions/497673/), so that paragraph breaks in this style are not honored by Biber when generating, i.e., annotated bibliographies.
Suggested behavior: Insert the \par latex command instead of a double newline:
annotation = {...unmodeled physics of the ISM.
\par
Simulations show...}

This could also apply to abstracts with multiple paragraphs.

@njbart, agreed?

I'll need a debug log generated by right-clicking an item in Zotero and then send from the menu that pops up. JVQPVNN2-euc comes from the help menu and does not include a sample reference.

Gotcha. New log is GE5EQHXG-euc

Must it be
annotation = {...unmodeled physics of the ISM.
\par
Simulations show...}

or would
annotation = {...unmodeled physics of the ISM.\par

Simulations show...}

also do?

And does something similar go for
?

Currently, I export
Der Gleichzeitigkeitsgrad g (n) der Spitzenlastanteile Ps von Wohnungen wurde
aus Messungen

as
Der Gleichzeitigkeitsgrad g (n) der Spitzenlastanteile Ps von Wohnungen wurde\\
aus Messungen

Does the \par need newlines around it at all? I'm trying to figure out what to do with

.....

....

Ideally, you'd want only a single \par there, but I can't know this. So I'd either generate
\par ... \par \par ... \par

or
... \par
... \par

and eliminate redundant \pars. Easier if I don't have to stuff too much context around them.

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>25 ("adjust test cases")
Install in Zotero by downloading test build <IP_ADDRESS>25, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

\par does not need newlines; this functions as expected:
annotation = {...unmodeled physics of the ISM.\par Simulations show...}

I think just

 should be converted to \par. Only replacing
 might mess with spacing at the end of the text. Zotero puts a newline between

, but I assume you're using regex of some kind to find and replace and can therefore ignore spaces?
I think
 should stay as //. In Zotero's HTML, it adds a newline without additional spacing between paragraphs like
. Using it in my LaTeX bib, it causes a newline but ignores my paragraph indentation settings. So using // more closely mimics the behavior of
, if that makes sense.

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>34 ("par cleanup")
Install in Zotero by downloading test build <IP_ADDRESS>34, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

I can't really replace

; I use a HTML parser, not a regex parser. I do use a regex to clean up the results -- a new build is coming (you can ignore 5834) that does a decent job of things.

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>35 ("cleanup")
Install in Zotero by downloading test build <IP_ADDRESS>35, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".

Give 5835 a go.

Build 5835 works great!! Just as I was thinking. Thanks for your work!

:robot: this is your friendly neighborhood build bot announcing test build <IP_ADDRESS>43 ("update test cases for #1422")
Install in Zotero by downloading test build <IP_ADDRESS>43, opening the Zotero "Tools" menu, selecting "Add-ons", open the gear menu in the top right, and select "Install Add-on From File...".


test(mempool): add mempool state struct and new function

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.15%. Comparing base (c7fa63e) to head (5882630).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
- Coverage   83.21%   83.15%   -0.06%
==========================================
  Files          36       36
  Lines        1692     1692
  Branches     1692     1692
==========================================
- Hits         1408     1407       -1
- Misses        209      210       +1
  Partials       75       75

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.