Adding files for code review

I added the jupyter notebook file and the exported .py version of the notebook - also committed my functions file (clean.py) and the img directory which contains reference images.
Pull Request Template
Review Checklist
Reproducibility

[x] Are the data downloaded in the code
[x] Are paths created to ensure they work on all operating systems (using  os.path.join)
[x] Are comments used to clarify the contents of the code that can’t be clarified using expressive variable and function names alone? (not too many comments - just enough)
[x] Does the notebook run from start to finish?

PEP 8 standards & Code Readability
Functions

[x] Do functions follow PEP 8 format conventions?
[x] Are function docstrings clear (all  inputs and outputs clearly  described and defined)
[x] Are function names expressive (the name describes what the function does)?
[x] Are functions easy to understand and read?
[x] How many tasks does each function do? (ideally a function does one thing well).

Package imports

[x] Are standard modules (those included with the base  python install) vs. third party (related but externally developed tools) import groups correct with appropriate spacing in between each group?
[x] Are variable names throughout the code, expressive?
[x] Suggest changes if not, highlight what was done well
[x] Is the code overall easy to understand and read? Are there things that would make it more clear / cleaner?

DRY Code

[x] Are segments of code repeated in the file or is the code DRY?
[x] Are loops used to optimize DRY code?
[x] Are functions used to optimize DRY code?
[x] Are there any areas that could be potentially improved (you can suggest improvements OR you can just highlight parts of the code where you suspect it could  be cleaner / more efficient.

Novel Approaches to Problem solving

[x] Highlight any novel approaches to completing the assignment.

Great work, Julia! Nice use of classes and functions (looks like you wrote it both ways?). The documentation looks nice too - just check the style guide to make sure indentation and such is correct.

Nice job Julia! great plots. I only recommend some style modification. In the first two cells you have 2 blank lines (one in cell 1, 2 in cell 2), which should not be there.
In addition I think you should remove "import rasterstats as rs" from your library, as it is not used later in the code.

@JuliaSobczak
Nice job Julia! great plots. I only recommend some style modification. In the first two cells you have 2 blank lines (one in cell 1, 2 in cell 2), which should not be there.
In addition I think you should remove "import rasterstats as rs" from your library, as it is not used later in the code.


fix(bundle-size-tests): Update version numbers in bundles

Description
We update our version numbers in CI when building PRs. These version numbers make it into our compiled code via the packageVersion.ts file that exists in some projects (see the build:genver npm task), so if the version number in the CI pipeline is a different number of bytes than the "true" version number, our bundle size tests calculate bundle size differences of 1-3 bytes for every PR.
Changes
I used the version-tools package to parse the build numbers and convert them back into the correct version. I used string-replace-loader to do the replacements.
Related to AB#4457

Is this referring to the version numbers in packageVersion.ts files? Maybe clarify in the comment where you're expecting to find the version numbers that need replacing.

Updated the PR description.

I'm going to go ahead and merge because I think I took the feedback correctly, and if I messed up then the worst case is bundle-size tools are broken (which they sort of are right now :smile:)

I'm going to go ahead and merge because I think I took the feedback correctly, and if I messed up then the worst case is bundle-size tools are broken (which they sort of are right now 😄)

LGTM :shipit: can't wait to see 0 bundle diffs where I expect them


Ability to Spoof & Stretch Resizable Resolution/Or Render Fixed at Higher Resolution, to enable UI Scaling & Higher View Distances

Is your feature request related to a problem? Please describe.
This is related to something that I believe affects most players as many players use fixed client for a number of reasons, either its:

small size
large interface (especially with stretched)
non-obstructive view
And I'm sure more valid reasons, but some of the issues with Fixed client option is it severely hampers view rendering distance, and this scales with Resolution the engine is scaling the scene to.
So one of the fixes is forcing your monitor running Runelite or other clients into a lower resolution like 720p or 1366x768, and this makes the interface easier to interact with in resizable at very least (which is one of the reasons I liked fixed (easy to find and click prayers fast and accurately)

However this doesn't address all the issues with Resizable, as it:

obstructs view in the client with interfaces
cannot scale UI size
must manually scale monitor resolution to increase UI scale (which decreases visiblity!)

Describe the solution you'd like
Firstly, I would like to see if it is possible to enable an option to spoof the resolution information being given to the client in resizable mode first off, and with that may require things like fixed aspects ratios and stretched modes for a lower resolution but upscaled version of resizable.
Secondly, Acknowledging the strengths of Fixed mode if there is any way to increase the rendering resolution above (I believe its 480p) as to increase the view distance, even if it means upscaling a downscaled scene.
Thirdly, the best of both worlds would be an option that allows for the scaling of UI elements to resolution without the loss of fidelity (though I imagine this would be outside Runelites ability to do and would be something on Jagex's side)  I.e being able to have a Fixed client with a 1080p rendering( or whatever the resolution may be at that monitor res, likely 1200x800 or something)
1366x768 appears to be the "ideal" rendering size without having any of the visible area cut off as compared to 1080p, where 720p still has some of the view distances cut away compared to 768p
Describe alternatives you've considered
The alternatives at the moment besides manually changing resolution to increase UI scaling on your monitor, is OpenGL mode which works in fixed and gets rid of view distance constraints, HOWEVER does not fix the loss of fidelity as you scale the small client to a larger sceen. (Which OSbuddy currently doesn't allow stretched fixed mode while using OpenGL)
Additional context
So honestly there is no nearly perfect solution at this moment for myself, as wanting these features:
-UI Scaling
-View Distance
-Usability (Being able to Alt tab and use my computer or that monitor for other tasks without having terrible resolution to force scaling in a resizable mode!)
-Fidelity
Below here is a comparison of different resolutions (Ignore any Bluring from poor compression)
Point trying to make with these images is the view distance between them, between fixed mode, and 800x600 and 720p even that having some of the screen cut off at maximum zoom.
Meaning using these Resizable modes at lower resolutions can put you at a disadvantage or simply interfere with your gameplay.
Where obviously OpenGL is best case scenario with rendering distance but doesn't actually show when NPC's or Players will phase in.
1920x1080 Runelite Fixed (stretched)

1920x1080 OSbuddy OpenGL Fixed (Cannot Stretch)

800x600 Runelite Resizable

1280x720 Runelite Resizable

1366x768 Runelite Resizable

1920x1080 Runelite Resizable

838 seems like the wrong issue?

oh, well, its duplicate of another issue then.


Add upsert alias?

Hi. The insert method behaves like what is usually called upsert in most DBMS'. So could you add upsert as an alias? I think it more clearly indicates intent.

Hi @lukehorvat,
I agree insert would be better named upsert. What do you think should be the behaviour of insert?

@typicode I would make insert throw an error if you try to insert a new item that has the same id as an existing item in the collection. In other words, the same behaviour as INSERT INTO SQL statements when a table has an id primary key.

Makes sense :) do you want to make a PR?

@typicode 😎 👍


[vscode] Share button doesn't work for yaml files

Was originally only built for json, not yaml

Fixed now from fixing the lastmile repo to now render for read-only on YAML. This repo is private for people outside of Last Mile AI org: https://github.com/lastmile-ai/lastmile/pull/1380

Actually wait, going to test that the uploading step to S3 still works before closing


Multiple instances

Hi,
is it possible to install a add-on multiple times? Why I need it: Readarr can only add ebooks or audio books per author. I want from one author the ebook and the audiobook. I read that Readarr can't handle that. That you need e second instance for that.
So is it possible to create a second readarr. Thanks.
Love what you are doing by the way, it makes my life a lot easier.

Hi, thanks very much! HA does not allow to install two instances, but an hack exists. If you add my repo twice, once with https://github.com/alexbelgium/hassio-addons and once with https://github.com/alexbelgium/hassio-addons/ ou will be able to install two versions!

It works like a charm. Thanks for the tip.

The installation went well. I changed the port. But it seems to look at the same config file. Any way that the docker can make an own config file?

Could you please try the latest version I've pushed? it should allow setting the config location from the addon options

I got an error updating it. So I removed it. Now I get an error installing it.

Yup, error on my part. I've updated a v3

Installation works again. The config setting does nothing.

Multitasking is not my greatest strength ;-) I used the variable in lower case instead of upper case. Version -3 will perhaps work!

Again a typo, v4 pushed

My man!! It works. I changed the port in the network section. I starts. Then I changed it in readarr itself. That killed it.

Perfect! Thanks for the feedback!

Hi, I noticed that the config location was removed. Can you add that back?

Hi, indeed this doesn't seem on purpose. Would you have an example? Thanks

What do you mean? Would you like me to provide a screenshot?

Aha, my mistake. It's about Radarr.

Are you sure there was an option to customize data path? Even if I look back in January there didn't seem to be such an option : https://github.com/alexbelgium/hassio-addons/blob/3ab7ea1de53d53d744757700f51077ee2c08bb03/radarr/config.json
Except for a very few addons, all configs are in /config/addons_config/* it is much easier... Custom locations induced other unexpected issues

You made a change in dec 10th. I don't remember when it started to fail. I use two instances, one for movies and one for children movies. Both are configured in Overseerr. Then when a request comes, it goes to the right folder for Plex to monitor.

Sorry to revive an old thread, but can you please clarify how to run 2 separate instances of an addon with a different config folder? The trick to install the repo twice worked - and now I can install 2 copies of any addon. However, I am specifically interested in sonarr and radarr - but without a way to change/customize where the config data is stored, wouldn't the second instance of these addons clash with the existing, running copy that is already using /config/addons_config/sonarr?

Hi, Indeed... It is possible to install the repo twice by adding a slash or not at the end but this won't help with the data folder. It will work only for addons in which the folder can be customized, or is internal in the add-on...

Ok, thank you for the clarification.
If anyone else stumbles on this - my solution was to leverage another repository that has the addons I wanted to duplicate: https://github.com/evilmarty/hassio-addons/tree/master/sonarr
The only catch is this other repository doesn't map the same folder shares into the addon containers. As a workaround, I leveraged the new HAOS network mount capability to share the required folders between the containers.


Support async validation in scaffolder custom field extensions

I think it can be useful to have a possibility to add backend validation in scaffolder form
Feature Suggestion
Async validation in scaffolder form

Possible Implementation
Allow async validation in createScaffolderFieldExtension or maybe pass addError method as prop to field component

Sorry I missed this, so I think this would be quite a simple thing to implement, we just need to grab the ones that are async and execute them after the sync validation has completed I believe.

Copying some Discord comments from @benjdlambert:

I think we need to adjust the signature of the CustomFieldValidator [to use Promise] and run the validators all as async, and run them all outside of the validate function. So we would do it in onNext of the stepper and then use the extraErrors prop for all validation.

Or we could check if the validation function smells like a Promise and run those in onNext and keep the current behavior. Either way works.

Maybe saying that all validators are async isn’t that much of a breaking change, since you can always await a sync value. But if we were to change the signature of course it could be breaking unless we supported both for now

To be honest looking through the code, I think this would be much easier to do after a refactor of the MultiStepForm and the TemplatePage to clarify the boundary between the two and move all validation into the MultiStepForm without the mix and match between the two. Will look at coming up for a plan with that first.

Any news on this? We are needing async validation support. We coded our validation code properly but it seems the code is not working properly through the web interface. @jemejones @MarcFogleman

Hey :wave: so I've been looking at implementing this in the NextScaffolderRouter which is a re-write of the frontend plugin with tests and making it easier to build features like this moving forward. There's no real timeframe set as yet as to how long it's going to take to get it out though unfortunately, but will keep you posted as I work through the re-write.

This is still a desired feature. Please don't close.


DO NOT MERGE: Using tmate to debug a github ci issue.

Added tmate to debug the github issue related to preflight:
ERROR  [Jul 21 07:31:35.495][containers.go: 111] failed to extract tarball: write /tmp/preflight-3137928138/fs/usr/lib64/security/pam_systemd.so: no space left on device
FATAL  [Jul 21 07:31:35.495][suite.go: 102] failed running preflight on image: quay.io/testnetworkfunction/cnf-test-partner:latest error: failed to extract tarball: write /tmp/preflight-3137928138/fs/usr/lib64/security/pam_systemd.so: no space left on device

Closing it as it served its purpose to debug the disk space issue.


Fix bug with [False] and [0] equal

https://github.com/Julian/jsonschema/issues/686
Hey. I tried to fix the error. Hope this helps.
An additional isinstance check is needed because Python considers [False] and [0] equal.
I also had to remove the sort to avoid comparison errors.

Hi! Thanks! Very happy to see you take a shot at this.
We need to add a test for this upstream to the test suite (here: https://github.com/json-schema-org/JSON-Schema-Test-Suite) so the first step here is to add one to that. You can test out whether that test exercises the bug by adding it directly to the json directory here in this repository -- that directory is just a literal copy of that test suite git repository.
Also, as for the fix itself, I suspect what we have in your diff will fix the specific instance @Zac-HD found (thanks to him as usual :), but intuitively seems unlikely to be correct I think -- it will likely fail again once a single additional layer of nesting is introduced. In order to fix it once and for all, the code in this area essentially tries to do lots of lazy unwrapping -- but give it a shot with both adding a test and then adding one that's doubly nested, I think you may see the trick here.

@Julian - you might want to steal my encode_canonical_json() function; it serialises JSON objects to strings which are equal if-and-only-if JSONschema considers the objects equal.  Not suitable for runtime use where performance is an issue, but it's great for testing!

@Julian Hello again :)
I tried to fix this error by implementing breadth first search algorithm to apply the unbool function to every element in the container. In code, this looks pretty complicated because I had to process dictionaries and lists at the same time, but the implementation is non-recursive and I think it should be better than dumping to a string.
I'd love to hear what you think about it.

Thanks! Will have a look -- one immediate thing that pops out though is that jsonschema supports arbitrary container types (via TypeChecker) so we can't type check on list and dict concretely -- we'd in theory have to use the collections.abc types..
If the existing implementation doesn't fail on some test (which it seems it doesn't), we probably should add a test (now just in this library, not upstream) to make sure we don't forget that we can have any type there, not just lists and dicts.
But will look more closely at the strategy you used, and definitely thanks again for trying to tackle this.


SPFx v1.4.1 sp-office-ui-fabric-core styles not rendered/loaded

Category

[x ] Question
[ ] Typo
[x ] Bug
[ ] Additional article idea

Expected or Desired Behavior
The following classes referenced in an SPFx 1.4.1 solution would render appropriately :
ms-Grid-col
ms-sm3
ms-md3
Observed Behavior
Styles are not rendered based on classname.
This is happening as of 11/15/2019 at 2:00pm CST.
Steps to Reproduce
Create an SPFx v1.4.1 solution
Add the following line to you .scss:
@import<EMAIL_ADDRESS>Add any className from UI Fabric (i.e. ms-Grid-col)
Deploy solution and observe css is not rendered.
QUESTION:
Would it be possible to provide reference of CDN paths as it relates to SPFx and Office UI Fabric resources, or otherwise elaborate on how the styles are added to the markup?
We are attempting to root cause this issue with no luck, and the best reference we can find refers to Icons specifically. It would be nice to have docs regarding styles as well: https://github.com/OfficeDev/office-ui-fabric-react/wiki/using-icons

Same problem started two hours ago on one my my tenants on all my apps.
On another tenant based on another continent they are still working fine for now.
Spfx versions from 1.4.1 to 1.9.1.

Slowly all tenants start seeing this issue. Root cause: old spfx solution having office fabric classes written directly in html markup.
We can resolve this by rewriting the code to follow mixin systax for office fabric classes.
However it unfair to ask developers to rewrite previously working code which was written year ago and ask them now to rebuild the code all of sudden. So please provide support for 'global css syntax' for old version of code. Impose any new rule only for lastest version of the spfx solution

Digging into this.  Is it possible to give some more info on tracking this down.  Are there errors in the console?  Are specific files not getting downloaded (check the network tab for 404s)?

My African tenant is back to normal. The European is still without css.
No 403 error.
@patmill
Some people usually use the ClassName= {"ms-Grid-col ms-sm12 ms-lg6"} syntax instead of doing include in scss and then applying it on the elements because is simpler and people don't have to load more css on to the page.
Now Microsoft removed that css.
Ex:
On the African Server they have:
.ms-SPLegacyFabricBlock .ms-lg6 {
width: 50%;
}
On the European server there is no definition on this class.

@patmill Please let me know if you require any further information apart from @Dangerous-Mind  given. Looking for a Quick resolution since most of these spfx solution will be on Production

@mmohamedbasith @Dangerous-Mind can you provide CDN URLs which are not serving the scoped selectors e.g. .ms-lg6 NOT .ms-SPLegacyFabricBlock .ms-lg6. That is unexpected, all CDNs should be serving scoped styles.
Also, what does running the following JavaScript code on the impacted page(s) return:
document.querySelectorAll('.ms-SPLegacyFabricBlock')

The Fabric styles are scoped to the above .ms-SPLegacyFabricBlock selector. If the CDN is serving the scoped styles as expected, then can you try a mitigation of appending the following className .ms-SPLegacyFabricBlock to your solution's root DOM Node?

Does anyone have an isolated SPFx 1.4.1 solution repro to expedite resolution?

@KevinTCoughlin  document.querySelectorAll('.ms-SPLegacyFabricBlock') gives zero nodes. However couple of hours ago i did saw SPFX webparts are wrapped with class 'ms-SPLegacyFabricBlock', not now.
No Apparent error in console.  So I cannot find what is the CDN url missing .

@KevinTCoughlin document.querySelectorAll('.ms-SPLegacyFabricBlock') gives zero nodes. However couple of hours ago i did saw SPFX webparts are wrapped with class 'ms-SPLegacyFabricBlock', not now.
No Apparent error in console. So I cannot find what is the CDN url missing .

Is the content cached? SPFx solutions in latest release should be wrapped in the above selector as you saw a few hours ago.
Does manually appending .ms-SPLegacyFabricBlock to the DOM Node containing the SPFx solution mitigate the styling issue?

.ms-SPLegacyFabricBlock

Yes manually appending class 'ms-SPLegacyFabricBlock' from developer tools, render fabric css properly.
However what i remember couple of hours ago was , i saw the class 'ms-SPLegacyFabricBlock' in webpart but the css not applied. Now i dont see the class 'ms-SPLegacyFabricBlock' in html

I believe the following SPFx 1.4.1 WebPart sample solution exhibits the above mentioned problem: https://github.com/KevinTCoughlin/spfx-fabric-icons/blob/309ab6fafc381698d488fc021b7480dae8587026/src/webparts/helloWorld/HelloWorldWebPart.ts#L31
Is the above linked usage of Fabric Icon classNames similar to what is in-use in the regressed SPFx solutions?

I believe the following SPFx 1.4.1 WebPart sample solution exhibits the above mentioned problem: https://github.com/KevinTCoughlin/spfx-fabric-icons/blob/309ab6fafc381698d488fc021b7480dae8587026/src/webparts/helloWorld/HelloWorldWebPart.ts#L31
Is the above linked usage of Fabric Icon classNames similar to what is in-use in the regressed SPFx solutions?

Yeah similar type, but can try below html with office fabric classes directly written in html

A
B

Comparing the two tenants. The Working one has the ms-SPLegacyFabricBlock class.
I have the same problem in all SPFx versions. So it's not a SPFx version issue.
European Tenant (Not working):
  /
/

African Tenant (Working)
/
 /

Comparing the two tenants. The Working one has the ms-SPLegacyFabricBlock class.
I have the same problem in all SPFx versions. So it's not a SPFx version issue.
European Tenant (Not working):
 /
/

African Tenant (Working)
/
 /

If I add the class to the non working tenant it will display correctly.

Yeah. All tenant spfx with fabric following 'global css syntax' will have this issue. If MS can brought in the class 'ms-SPLegacyFabricBlock' in all tenant, it would solve the problem.
Anyhow latest spfx version 1.8.2,1.9.1 does not support global style css by default. Mostly the people follow mixins.so support is required for old versions spfx where css classes can be written in html itself.

We've tested a fix which resolves the issue we were seeing above. We'll be rolling it out now thru tomorrow.

@KevinTCoughlin . Much appreciated for the swift response 👍

Thanks for fixing this this fast! This makes a couple of our customers very happy.

Currently, the fabric grid CSS file is not loading. As a quick fix, we can load it in our solution. Create .scss file you can name it as "global.scss" (just a name) and import the mixins and variables for the grid system.
:global() {
  @import "~office-ui-fabric-react/dist/sass/mixins/Grid.Mixins";
  @import "~office-ui-fabric-react/dist/sass/mixins/General.Mixins";
  @import "~office-ui-fabric-react/dist/sass/mixins/Directionality.Mixins";
  @import "~office-ui-fabric-react/dist/sass/mixins/Responsive.Mixins";

  @import "~office-ui-fabric-react/dist/sass/variables/Responsive.Variables";

  @import "~office-ui-fabric-react/dist/sass/_Grid.scss";
  @import "~office-ui-fabric-react/dist/sass/_Responsive.scss";
}

Then import this file in your web part file
import '../shared/theme/global.scss';
Now you can use ms-* classes. For eg:
<div className={`ms-Grid-col ms-xxxl12 ms-xxl12 ms-xl12 ms-lg12 ms-md12 ms-sm12`}>
    12 column

Note: I'm using SPFx & React.

We can also inject the missing class using a global SPFx extension.
That will fix all the apps at the same time.
Something like:
$( '.ControlZone-control' ).each( function () {
    var zoneChild = $(this).children().children();
    zoneChild.addClass('ms-SPLegacyFabricBlock');
});

Fix is now at 50% worldwide and is visible in the fixed tenants after hard reset of the browser cache (Ctrl+F5). If there are any updates on the impacted environments after this, please do report, so that we can detect if the correct fix operations were applied.

We see this working on multiple tenants already.
Is there any way we can track if the fix has been applied? (version/patch number, ...?)

We see this working on multiple tenants already.
Is there any way we can track if the fix has been applied? (version/patch number, ...?)

"View page source" and grep for "buildNumber", the build containing the fix contains 2019-11-08.018 or greater.

Looks like issue not yet resolved I didn't see any changes .

We see build number "sp-client-prod_2019-10-18.028" where the issue is fixed. Other tenants where the issue is not fixed have "sp-client-prod_2019-11-08.018"

We see this working on multiple tenants already.
Is there any way we can track if the fix has been applied? (version/patch number, ...?)

"View page source" and grep for "buildNumber", the build containing the fix contains 2019-11-08.018 or greater.

We see build number  "buildNumber" : "sp-client-prod_2019-11-08.018", and the issue is not fixed.

We are also seeing build number "2019-11-08.018" and the issue is still present

We see build number "sp-client-prod_2019-10-18.028" where the issue is fixed. Other tenants where the issue is not fixed have "sp-client-prod_2019-11-08.018"

Yes, we see a tenant with "buildNumber" : "sp-client-prod_2019-10-18.028", and the issue is fixed. But others with   "buildNumber" :"sp-client-prod_2019-11-08.018" where the issue is not fixed.

import '../shared/theme/global.scss';

I used it as temporaly workarround and works great with columns, however with text aligns not working :(
ms-textAlignCenter
ms-textAlignRight

"buildNumber" : "sp-client-prod_2019-11-08.018"
Ok if I go directly to the page or from a list view to the web part using a link.
If I'm on a page and click on a link to the web part the problem still happens.
If I make F5 the page is displayed correctly.
I had the same problem when injecting the code on the extension. Not all scripts run when jumping from page to page.

Try to refresh the page you are navigating from (ctrl+F5) so the dynamic page load will get the new library before you navigate to the webpart page.

@westleyMS Not working.
When you jump between pages there is no complete refresh to the new page. And the script is not activated on the second page.
That makes the class appear on the first page and not on the second one.
@KevinTCoughlin @VesaJuvonen  Can you please check? Thanks

Moving between pages that are modern pages is a dynamic page load which means that the page doesn't get a load event. Webparts and extensions in SPFx must register for the navigation event, and if you didn't, then your component will not handle the navigation correctly, but this is not related to the issue at hand with office react fabric. This is how you get the navigation event-
this.context.application.navigatedEvent.add(this, () => { // update your control })
This will fire on the dynamic page loading between modern pages.
More on this here-
https://github.com/SharePoint/sp-dev-docs/issues/1971

Thanks, the issue is fixed. Now we have the "buildNumber" : "sp-client-prod_2019-10-18.028" and its all ok.

Moving between pages that are modern pages is a dynamic page load which means that the page doesn't get a load event. Webparts and extensions in SPFx must register for the navigation event, and if you didn't, then your component will not handle the navigation correctly, but this is not related to the issue at hand with office react fabric. This is how you get the navigation event-
this.context.application.navigatedEvent.add(this, () => { // update your control })
This will fire on the dynamic page loading between modern pages.
More on this here-
#1971

I think you are missing the point.
The fix made by Microsoft was not doing that event you mentioned.
Wen we load the page it loads the fix. But navigating to a new page didn't load the fix.
I had that same problem on one of my extensions months ago because I had forgot to add the event.

Thanks, the issue is fixed. Now we have the "buildNumber" : "sp-client-prod_2019-10-18.028" and its all ok.

Confirmed. It's working fine now. :)

We are seeing mixed results. Our build number remains unchanged, we are at sp-client-prod_2019-11-08.018, our layout issues seem to be resolved, however we are seeing outlining around office fabric ui buttons that did not have that before. most notably the close button on the fabric panel now has a black border around it.

We are seeing mixed results. Our build number remains unchanged, we are at sp-client-prod_2019-11-08.018, our layout issues seem to be resolved, however we are seeing outlining around office fabric ui buttons that did not have that before. most notably the close button on the fabric panel now has a black border around it.

@rmbw74, can you share a code sample or the CSS output from DevTools that shows us where that black border is coming from so we can triage and address?

Here is the markup for the panel close button.
<button type="button" class="ms-Panel-closeButton ms-PanelAction-close ms-Button ms-Button--icon css-709" data-is-visible="true" aria-label="Close" data-is-focusable="true" style="     border-color: red; ">

</button>
On the button element - the css-709 class which is dynamically created has a border width style and color in the CSS.

I also have some strange default buttons with white letters on a almost white background in a Modal element with:
TypeScript
<DefaultButton primary={true} onClick={this.SaveEditItem.bind(this)} text="Save" />
html:
<button type="button" class="ms-Button ms-Button--primary root-582" data-is-focusable="true" >

  Save

</button>

css:
`.root-582 {
    position: relative;
    font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif;
    -webkit-font-smoothing: antialiased;
    font-size: 14px;
    font-weight: 400;
    box-sizing: border-box;
    display: inline-block;
    text-align: center;
    cursor: pointer;
    vertical-align: top;
    padding-top: 0px;
    padding-right: 16px;
    padding-bottom: 0px;
    padding-left: 16px;
    min-width: 80px;
    height: 32px;
    background-color: rgb(244, 244, 244);
    color: rgb(255, 255, 255);
    user-select: none;
    outline: transparent;
    border-width: 1px;
    border-style: solid;
    border-color: transparent;
    border-image: initial;
    text-decoration: none;
    border-radius: 0px;
}`

The culprit is the .root-xxx that overrides the color on the used class (theme primary color).

Our build number changed again and back to previous stage we are seeing sp-client-prod_2019-11-08.018 ms-grid-row Grid layout issue resolved but buttons and drop down and people picker controls not rendering as expected.

We Have now "buildNumber" : "sp-client-prod_2019-11-08.018" and same error with button class.

"buildNumber" : "sp-client-prod_2019-11-08.021"
Still experiencing issues with columns.

"buildNumber" : "sp-client-prod_2019-11-08.021" layout issue started again this is very frustrating these changes making our existing application unstable.

I hope Microsoft is having  QA Testing team who are testing the tenants in multiple geography and existing SPFX solutions before pushing any new changes.

I have also observed that Microsoft "style fix" has been changed.
Now (2019-11-20) it only works for the SharePoint Framework version 1.6.
However, it does not work for versions 1.8 and 1.9 (it was working on 2019-11-19 after MS pushed fixes).
Note that I am referring to the versions 1.6, 1.8 and 1.9 as I have web parts in them I can quickly test in.
Here is the difference I see between yesterday’s 2019-11-19 and today’s 2019-11-20 behaviour:

Yesterday the class “ms-SPLegacyFabricBlock” was not added to any web part versions. However, it worked for all versions as the dependency for Office UI Fabric styles to be used “under” element with the class “ms-SPLegacyFabricBlock” was removed.

Today:

The dependancy for Office UI Fabric styles to be “under” element with the class “ms-SPLegacyFabricBlock” is back.
The class “ms-SPLegacyFabricBlock” is added for 1.6 web parts. So they work as expected.
The class “ms-SPLegacyFabricBlock” is not added for 1.8 and 1.9 web parts. So they do not work as expected.

Info about build numbers:

Yesterday I had "sp-client-prod_2019-11-08.018", but note that it was like this both before and after web part designs started to work as expected.
Today I had the same "sp-client-prod_2019-11-08.018" in the morning when the issue reappeared for versions 1.8 and 1.9. Now it has changed to "sp-client-prod_2019-11-08.021".

Perhaps build numbers are somehow cached or fixes are done outside of the build scopes as behaviour does not seem to follow builds directly. But anyway - this info might be useful.
Can you please continue work on this issue?

we are now on "sp-client-prod_2019-10-18.028" and it looks like the strange outlining behavior on the button classes has stopped.  On a maybe related note, i noticed the styling of the Debug Dialog has reverted back to its original look.

Looks like I spoke too soon, now we are back to  sp-client-prod_2019-11-08.021 and things are broken again! so frustrating.

We continue to actively work on this issue. The more information provided to help the team assess the regressed scenarios the sooner we can reach a resolution.
For context, Office UI Fabric has been updated on the host page to version 7. Unfortunately, Office UI Fabric 7 contains style regressions and is impacting SPFx solutions downstream as a side-effect; some of those regressions are mentioned above e.g. button outline.
@mschaefer85 by "columns" are you referencing .ms-Grid classes? What SPFx version is your solution 1.4.x .. 1.9.x?
@PankajKTSPFX same question for you regarding your reference to "layout" and which version of SPFx solution are impacted. Or are is the regression scoped to https://github.com/SharePoint/sp-dev-docs/issues/4911#issuecomment-555613444?

@KevinTCoughlin Thanks for the update, Kevin. Yes, by "columns" I'm referring to issues with ".ms-Grid" (for example).
The solution is SPFx v. 1.4.

I have this same issue on one of 4 tenants (PROD being the one affected). I have a spfx webpart being used in a group of hub connected sites. I have used office ui fabric DefaultButtons that has the border added now and wasn't there until a week back. PrimaryButton doesn't seem to be affected.

We continue to actively work on this issue. The more information provided to help the team assess the regressed scenarios the sooner we can reach a resolution.
For context, Office UI Fabric has been updated on the host page to version 7. Unfortunately, Office UI Fabric 7 contains style regressions and is impacting SPFx solutions downstream as a side-effect; some of those regressions are mentioned above e.g. button outline.
@mschaefer85 by "columns" are you referencing .ms-Grid classes? What SPFx version is your solution 1.4.x .. 1.9.x?
@PankajKTSPFX same question for you regarding your reference to "layout" and which version of SPFx solution are impacted. Or are is the regression scoped to #4911 (comment)?

@KevinTCoughlin  thanks for the response, we are using 1.5.1 SPFX version and I am referring to issue with style button,people picker control, Grid layout.

OK, latest update on this.  We're rolling back the entire build.  The only downside to this is that it's harder to know what the issues are.  So, if you had issues, if possible, can you post what your code looked like?  What spfx version, if you had the LegacyCSS property set in your manifest, etc.
The hope is that there will be some broad changes that can be made that will solve the issues, and that it won't require a succession of incremental fixes.
Again - I apologize for this.  I feel like we burned through a chunk of good will, and hope to get it back.

We encountered the same issue with our custom extensions in one of our 2 tenants.  Any idea as to why the changes only affected one of the tenants and not the other even when looking at the targeted release?
We are using spfx 1.9.1 with<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Here are some code snippets:
return (

{links}

);
return (

                    {columns}

    );

@ralucao, do you have the following specified in your WebPart's manifest:
  "loadLegacyFabricCss": true,

For SPFx solution versions > 1.8.2 we require that be set to load Fabric core styles referenced via CSS like you've shared above e.g.
.
We recommend for solutions > 1.8.2 that the following styling strategy be used: https://docs.microsoft.com/en-us/sharepoint/dev/spfx/office-ui-fabric-integration#updated-way-to-use-icons-after-spfx-182

🚨🚨🚨 Responses needed 🚨🚨🚨
For those who had their existing solutions regress related to Fabric core styling, .ms-Icon, .ms-Grid, etc., we need answers to the following:

What exact version of SPFx is the solution? 1.4.x, 1.8.x, 1.9.x?
Does the solution reference Fabric core global styles via CSS in the DOM e.g.
.
Do you specify loadLegacyFabricCss: true in the manifest?

Thanks in advance!

thanks for rolling back the changes looks like style is loading properly with "buildNumber" : "sp-client-prod_2019-10-18.028". please do not push any new changes without complete complete testing.

🚨🚨🚨 Responses needed 🚨🚨🚨
For those who had their existing solutions regress related to Fabric core styling, .ms-Icon, .ms-Grid, etc., we need answers to the following:

What exact version of SPFx is the solution? 1.4.x, 1.8.x, 1.9.x?
Does the solution reference Fabric core global styles via CSS in the DOM e.g.
.
Do you specify loadLegacyFabricCss: true in the manifest?

Thanks in advance!

Below are my answers specific to my SPFX solution

SPFX Version 1.4.1
Yes , Solution has fabric class names written in HTML like
.
No , Haven't specify loadLegacyFabricCss: true in the manifest, Since this term came to use only since the arrival of SPFX 1.8.1 if i am not wrong.

Also I would like to add , after the issue occurred i rewritten all the fabric core global styles written directly in the HTML DOM to follow mixins and variable syntax (like @include ms-lg6 in .scss file) . It resolved my layout issues . However i started seeing border occurs buttons , Fabric panel control close button and PNP react PeoplePicker control.
Hope it helps.

thanks for rolling back the changes looks like style is loading properly with "buildNumber" : "sp-client-prod_2019-10-18.028". please do not push any new changes without complete testing.

Can you please answer questions #2 and #3 in https://github.com/SharePoint/sp-dev-docs/issues/4911#issuecomment-556907698? Thanks. I already have your SPFx version as 1.5.1.
Also are the outlines you see in Picker and Button in first-party or third-party controls?

Thanks for your response @mmohamedbasith; they help us verify our hypothesis. Regarding the inherited styles:
Fabric team made a number of breaking style changes in their latest major release which are being inherited by WebPart controls. We are looking into a solution for that separately.

🚨🚨🚨 Responses needed 🚨🚨🚨
For those who had their existing solutions regress related to Fabric core styling, .ms-Icon, .ms-Grid, etc., we need answers to the following:

What exact version of SPFx is the solution? 1.4.x, 1.8.x, 1.9.x?
Does the solution reference Fabric core global styles via CSS in the DOM e.g.
.
Do you specify loadLegacyFabricCss: true in the manifest?

Thanks in advance!

1.4
Yes
No

🚨🚨🚨 Responses needed 🚨🚨🚨
For those who had their existing solutions regress related to Fabric core styling, .ms-Icon, .ms-Grid, etc., we need answers to the following:

What exact version of SPFx is the solution? 1.4.x, 1.8.x, 1.9.x?
Does the solution reference Fabric core global styles via CSS in the DOM e.g.
.
Do you specify loadLegacyFabricCss: true in the manifest?

Thanks in advance!

1.4
Yes
No

Hrmm that SPFx version 1.4.x should not have been impacted. I tested .ms-Grid in isolation using 1.4.1 and it rendered properly. Here was my branch: https://github.com/KevinTCoughlin/spfx-fabric-icons/compare/keco/grid-legacy?expand=1.
@mschaefer85, may I request a repro from you either by forking the above or creating your own?

🚨🚨🚨 Responses needed 🚨🚨🚨
For those who had their existing solutions regress related to Fabric core styling, .ms-Icon, .ms-Grid, etc., we need answers to the following:

What exact version of SPFx is the solution? 1.4.x, 1.8.x, 1.9.x?
Does the solution reference Fabric core global styles via CSS in the DOM e.g.
.
Do you specify loadLegacyFabricCss: true in the manifest?

Thanks in advance!

1.4
Yes
No

Hrmm that SPFx version 1.4.x should not have been impacted. I tested .ms-Grid in isolation using 1.4.1 and it rendered properly. Here was my branch: https://github.com/KevinTCoughlin/spfx-fabric-icons/compare/keco/grid-legacy?expand=1.
@mschaefer85, may I request a repro from you either by forking the above or creating your own?

@KevinTCoughlin  Are you sure ,your code was working  on 16th Nov19 ? Bcoz it does not work for me (Similar code you used).I think you were able to replicate the issue  on 17th Nov'19 on SPFX 1.4.1.
After your first fix release , it layout issue got resolved (in spfx 1.4.1) , But only the border/Outline issue remained .
Couple of days later , Again i started to see partial layout issues in SPFX 1.4.1

🚨🚨🚨 Responses needed 🚨🚨🚨
For those who had their existing solutions regress related to Fabric core styling, .ms-Icon, .ms-Grid, etc., we need answers to the following:

What exact version of SPFx is the solution? 1.4.x, 1.8.x, 1.9.x?
Does the solution reference Fabric core global styles via CSS in the DOM e.g.
.
Do you specify loadLegacyFabricCss: true in the manifest?

Thanks in advance!

We have solution ranging from v1.7.0 to v1.9.1
Yes, exactly that.
No, there is no loadLegacyFabricCss: true in our manifest

🚨🚨🚨 Responses needed 🚨🚨🚨
For those who had their existing solutions regress related to Fabric core styling, .ms-Icon, .ms-Grid, etc., we need answers to the following:

What exact version of SPFx is the solution? 1.4.x, 1.8.x, 1.9.x?
Does the solution reference Fabric core global styles via CSS in the DOM e.g.
.
Do you specify loadLegacyFabricCss: true in the manifest?

Thanks in advance!

1.4
Yes
No

Hrmm that SPFx version 1.4.x should not have been impacted. I tested .ms-Grid in isolation using 1.4.1 and it rendered properly. Here was my branch: KevinTCoughlin/spfx-fabric-icons@keco?expand=1 (compare).
@mschaefer85, may I request a repro from you either by forking the above or creating your own?

@KevinTCoughlin Are you sure ,your code was working on 16th Nov19 ? Bcoz it does not work for me (Similar code you used).I think you were able to replicate the issue  on 17th Nov'19 on SPFX 1.4.1.
After your first fix release , it layout issue got resolved (in spfx 1.4.1) , But only the border/Outline issue remained .
Couple of days later , Again i started to see partial layout issues in SPFX 1.4.1

@mmohamedbasith we've confirmed what led to the Fabric core styles regression for SPFx solutions > 1.8 that do not specify the loadLegacyFabricCss manifest flag as true when present on a page without a WebPart which does request legacy Fabric CSS.

🚨🚨🚨 Responses needed 🚨🚨🚨
For those who had their existing solutions regress related to Fabric core styling, .ms-Icon, .ms-Grid, etc., we need answers to the following:

What exact version of SPFx is the solution? 1.4.x, 1.8.x, 1.9.x?
Does the solution reference Fabric core global styles via CSS in the DOM e.g.
.
Do you specify loadLegacyFabricCss: true in the manifest?

Thanks in advance!

Answers:

1.6, 1.8, 1.9
Yes
No
I understand that we need to set "loadLegacyFabricCss: true" for 1.8 and 1.9 versions.

Updates about current (2019-11-21) situation:

Build is "sp-client-prod_2019-11-08.028"
Behaviour is back to how it was on 2019-11-19: The class “ms-SPLegacyFabricBlock” is not added to any web part versions. However, it works for all versions as the dependency for Office UI Fabric styles to be used “under” element with the class “ms-SPLegacyFabricBlock” is removed.

Suggestion:

It would be good if information about "loadLegacyFabricCss: true" for versions >= 1.8.2 is added to  https://docs.microsoft.com/en-us/sharepoint/dev/spfx/office-ui-fabric-integration

🚨🚨🚨 Responses needed 🚨🚨🚨
For those who had their existing solutions regress related to Fabric core styling, .ms-Icon, .ms-Grid, etc., we need answers to the following:

What exact version of SPFx is the solution? 1.4.x, 1.8.x, 1.9.x?
Does the solution reference Fabric core global styles via CSS in the DOM e.g.
.
Do you specify loadLegacyFabricCss: true in the manifest?

Thanks in advance!

1.4
Yes
No

Hrmm that SPFx version 1.4.x should not have been impacted. I tested .ms-Grid in isolation using 1.4.1 and it rendered properly. Here was my branch: KevinTCoughlin/spfx-fabric-icons@keco?expand=1 (compare).
@mschaefer85, may I request a repro from you either by forking the above or creating your own?

@KevinTCoughlin Are you sure ,your code was working on 16th Nov19 ? Bcoz it does not work for me (Similar code you used).I think you were able to replicate the issue  on 17th Nov'19 on SPFX 1.4.1.
After your first fix release , it layout issue got resolved (in spfx 1.4.1) , But only the border/Outline issue remained .
Couple of days later , Again i started to see partial layout issues in SPFX 1.4.1

@mmohamedbasith we've confirmed what led to the Fabric core styles regression for SPFx solutions > 1.8 that do not specify the loadLegacyFabricCss manifest flag as true when present on a page without a WebPart which does request legacy Fabric CSS. The appropriate build was used to test internally.
Good call-out, we patched the original product bug for 1.4.x when multiple WebParts were present on the page and redeployed and rolled-back today AM. I'd like more samples to confirm the patched build fixed all < 1.8 solutions.

@KevinTCoughlin  Hmmm. Its too Hard. Too many SPFX & fabric versions,scenarios to think of . My heart goes out to the guys you are really working hard to resolve this.
I would like to add one scenarios, Apart from my spfx 1.4.1 solution , i am working on another spfx 1.8.2 which does not faced any layout issue during the period . May be bcoz i used only mixins syntax (not any global css) and Also i havent used loadLegacyFabricCss: true in manifest.

thanks for rolling back the changes looks like style is loading properly with "buildNumber" : "sp-client-prod_2019-10-18.028". please do not push any new changes without complete testing.

@PankajKTSPFX can you please answer questions #2 and #3 in #4911 (comment)? Thanks. I already have your SPFx version as 1.5.1.
Also are the outlines you see in Picker and Button in first-party or third-party controls?

Does the solution reference Fabric core global styles via CSS in the DOM e.g.
. we are referring the style from 'office-ui-fabric-react' and using the  class name via css ( )
Do you specify loadLegacyFabricCss: true in the manifest? - No  (I tried earlier before fix but that is not working)

🚨🚨🚨 Responses needed 🚨🚨🚨
For those who had their existing solutions regress related to Fabric core styling, .ms-Icon, .ms-Grid, etc., we need answers to the following:

What exact version of SPFx is the solution? 1.4.x, 1.8.x, 1.9.x?
Does the solution reference Fabric core global styles via CSS in the DOM e.g.
.
Do you specify loadLegacyFabricCss: true in the manifest?

Thanks in advance!

1.6
Yes
No

@ralucao, do you have the following specified in your WebPart's manifest:
  "loadLegacyFabricCss": true,

For SPFx solution versions >= 1.8.2 we require the above flag be set to load global Fabric core styles referenced via CSS like you've shared above e.g.
.
We recommend for solutions > 1.8.2 that the following styling strategy be used: https://docs.microsoft.com/en-us/sharepoint/dev/spfx/office-ui-fabric-integration#updated-way-to-use-icons-after-spfx-182

Hi Kevin,
We do not have the loadLegacyFabricCss property set in our solution. We will try that.Thanks

For those who had their existing solutions regress related to Fabric core styling, .ms-Icon, .ms-Grid, etc., we need answers to the following:

What exact version of SPFx is the solution? 1.4.x, 1.8.x, 1.9.x?
Does the solution reference Fabric core global styles via CSS in the DOM e.g.
.
Do you specify loadLegacyFabricCss: true in the manifest?

Question 1

SPFx 1.4.1 unsure - Issue first noticed with a customers' solution on SPFx 1.4.1 - we didn't see it regress on this solution (though, it may have regressed without us noticing it)
SPFx 1.8.2 unsure - Issue also noticed with a customers' solution on SPFx 1.8.2 - we implemented a work around which may have masked any subsequent regression
SPFx 1.8.0 yes - Issue also noticed with a customers' solution on SPFx 1.8.0 - this solution fixed itself without intervention from us, and was then confirmed to have regressed this week, but is now showing icons as expected

Question 2

SPFx 1.4.1 yes
SPFx 1.8.2 yes
SPFx 1.8.0 yes

Question 3

SPFx 1.4.1 no
SPFx 1.8.2 no
SPFx 1.8.0 no
(we weren't aware the loadLegacyFabricCss property exists!)

1.8.1, upgraded in several steps from 1.5.1
Only through scss
No

We hope to be rolling a fix out soon (later today).  In the meantime, here is a first draft of guidance around using the legacy fabric css files.
https://github.com/SharePoint/sp-dev-docs/wiki/Safely-using-legacy-Fabric-Styles

@patmill in the documentation you're pointing to the "solution manifest", whereas it should be the "webpart manifest".

For solutions using SPFx >= 1.8.2, ensure that the solution manifest demands legacy Fabric core styles be loaded onto the page. This is done by specifying loadLegacyFabricCss: true in the solution manifest.

we are having layout issues again.. looking at the page, we are seeing sp-client-prod_2019-11-08.025 as the buildNumber, we were on .028 when all was fixed.   The solution we are having the issues with is a 1.4.1 solution

Same Issue here.

@rmbw74, @carletto75  - How are you using the fabric styles?  What kind of solution have you made(webpart?  extension?)  Where is the content rendering (in a webpart or placeholder div?  In a div you add to the page manually?).  Can you share your relevant package.json entries (PNP, fabric, ouifr, etc) and some sample code with what you are doing?  Maybe a screenshot showing the issues?
Anything that can help us diagnose what is going on. Thanks.

As of this moment , My SPFX 1.4.1 Solution working Fine.
Build Number i see is: "buildNumber" : "sp-client-prod_2019-11-08.025"

The only thing that is not ok on my solutions are the default buttons with Primary option set to true  that dont get the backgroud color from the site theme.
<DefaultButton primary={true} onClick={() => this.Submit()} >Submeter</DefaultButton>
.root-500 {
    position: relative;
    font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif;
    -webkit-font-smoothing: antialiased;
    font-size: 14px;
    font-weight: 400;
    box-sizing: border-box;
    display: inline-block;
    text-align: center;
    cursor: pointer;
    vertical-align: top;
    padding-top: 0px;
    padding-right: 16px;
    padding-bottom: 0px;
    padding-left: 16px;
    min-width: 80px;
    height: 32px;
    background-color: rgb(244, 244, 244);
    color: rgb(255, 255, 255);
    user-select: none;
    outline: transparent;
    border-width: 1px;
    border-style: solid;
    border-color: transparent;
    border-image: initial;
    text-decoration: none;
    border-radius: 2px;
}

"buildNumber" : "sp-client-prod_2019-11-08.025"
"buildNumber" : "sp-client-prod_2019-11-08.021"
SPFx 1.8.2 and 1.9.1
"loadLegacyFabricCss": true

Thanks @Dangerous-Mind - and to confirm, you are using the DIVs provided by the framework?

Changed it to  and it works fine.
<PrimaryButton onClick={() => this.Submit(true)}>Submeter</PrimaryButton>

The button doesnt have any class defined by me. It should be working ok without my intervention.
If you are referring to the ms-SPLegacyFabricBlock. It's on the top before the webpart start.

@patmill

we are using the classes directly, not via mixins in scss
this is a spfx 1.4.1 webpart deployed to SPO
this content is being rendered in a react component in a webpart
Our main react component seems to be getting the ms-SPLegacyFabricBlock applied,
but the components that exist on Fabric Panels do not.

package.json
{   "name": "launchpad",   "version": "0.0.1",   "private": true,   "engines": {     "node": ">=0.10.0"   },   "scripts": {     "build": "gulp bundle",     "clean": "gulp clean",     "test": "gulp test"   },   "dependencies": {     "@microsoft/applicationinsights-web": "^2.0.0-rc4",     "@microsoft/sp-core-library": "~1.4.0",     "@microsoft/sp-lodash-subset": "~1.4.0",     "@microsoft/sp-office-ui-fabric-core": "~1.4.0",     "@microsoft/sp-webpart-base": "~1.4.0",     "@pnp/common": "^1.3.5",     "@pnp/graph": "^1.3.5",     "@pnp/logging": "^1.3.5",     "@pnp/odata": "^1.3.5",     "@pnp/polyfill-ie11": "^1.0.2",     "@types/es6-promise": "0.0.33",     "@types/react": "16.4.2",     "@types/react-dom": "16.0.5",     "@types/webpack-env": "1.13.1",     "react": "16.3.2",     "react-dom": "16.3.2",     "react-sortable-hoc": "^1.9.1"   },   "resolutions": {     "@types/react": "16.4.2"   },   "devDependencies": {     "@microsoft/sp-build-web": "~1.4.1",     "@microsoft/sp-module-interfaces": "~1.4.1",     "@microsoft/sp-webpart-workbench": "~1.4.1",     "gulp": "~3.9.1",     "@types/chai": "3.4.34",     "@types/mocha": "2.2.38",     "ajv": "~5.2.2"   } }
here is the markup at the start of our main component

and here is what that looks like (i've had to edit out some text for security)

Here is the markup for our fabric panel -

here is what that looks like (notice the layout is not following the grid, it should be the same as the main component)

@rmbw74 thanks for the above; we are actively working on a mitigation using a similar approach (appending the className .ms-SPLegacyFabricBlock).
Since some Fabric components (those reliant on Fabric Layer) append to document.body, they are rendered outside of the legacy Fabric core scoped styles. The scoped Fabric core styles were introduced to mitigate Fabric 7's incompatibility with Fabric core.
We will report status here. Apologies for the breakage.

@rmbw74  @KevinTCoughlin we have indeed the same issue when rendering inside a Panel, since it's not rendering within a correctly styled container. Applying the same workaround as well...

@KevinTCoughlin sent you a message in Teams

Same Issue here.

I solved my issue by adding class="ms-SPLegacyFabricBlock", as suggested to me in issue #4919
Thank you

For those who had their existing solutions regress related to Fabric core styling, .ms-Icon, .ms-Grid, etc., we need answers to the following:

What exact version of SPFx is the solution? 1.4.x, 1.8.x, 1.9.x?
Does the solution reference Fabric core global styles via CSS in the DOM e.g.
.
Do you specify loadLegacyFabricCss: true in the manifest?

Thanks in advance!

For a customer with "buildNumber" : "sp-client-prod_2019-11-08.025"

1.7.1 (webpart solution)
Yes
NO

In my case we have updated our solution to use Fabric-UI-React 7 and, the fix you are doing with the ms-SPLegacyFabricBlock is actually really bad because there are some global styles that override the Fabric-UI-React styles of the components. One example of those global styles is  .ms-SPLegacyFabricBlock .ms-Icon{}
I am undoing this right now in my application customizer via this:
this._topPlaceholder.domElement.className="";
I think you should only wrap our components with ms-SPLegacyFabricBlock when loadLegacyFabricCss: true is specified in the manifest.

@OliverZeiser  - you are 100% correct.  The forcing of the legacy fabric block is a temporary measure to give people time to update their solutions.  When we roll out support for fabric 7 (which we can't do because of the issue you mention) we will remove that 'fix'.

Thank you very much for the quick and great (honest) response. Right now for us OUIFR7 is working just fine and it looks much more aligned to the current design changes (fluent..) that are rolling out to the tenants. Is it okay for us to keep setting ....domElement.className="" for our components to prevent the ms-SPLegacyFabricBlock css class for now or should we expect more changes like that in the near future and revert to OUIFR6?

That's should be OK.  Let us know what other issues you run across.

@patmill I am also seeing the same regressions using DefaultButton with primary attribute set to true as @Dangerous-Mind. Using PrimaryButton solves this but there is some regression when using the button as a MenuButton.
I am using this code :
<PrimaryButton
    menuProps={{
        shouldFocusOnMount: true,
        items: [
        {
            key: 'MenuItem1',
            name: 'Menu Item 1'
        },
        {
            key: 'MenuItem1',
            name: 'Menu Item 1'
        },
        ]
    }}
>
    Menu Button 2
</PrimaryButton>

When the menu is open the styles on the button seems to be broken.
Menu collapsed:

Menu expanded:

I had created a issue on office-ui-fabric-react also. Linking it here: https://github.com/OfficeDev/office-ui-fabric-react/issues/11356

The surrounding .ms-SPLegacyFabricBlock DIV is also exploding width of the web part on classic pages with IE11. Had to clear the class like @OliverZeiser suggested.

Seems like this was resolved...

Seems like this was resolved...

I would disagree. Content in Office fabric panel/dialog is still  having issues in SPFX1.4.1 . After waiting for long and no resolution found provided for that, everyone the might be forced to reworked the code to use mixins in scss which could resolve the CSS issues.


PDI config not validated enough

In GitLab by @Roussel-C on Sep 29, 2016, 10:27
Multiples issues when parsing variable name:

[ ] invalid variable names is not detected (e.g. with arithmetic operators +, -, %, ...)
[ ] multiple declaration of the same name is not detected

mentioned in commit 47aa6d25d03bba53df74458e492a71f54e55c5fc

I believe invalid names are now detected. Do you confirm?

Changed title: P{-arsing config in PDI-} → P{+DI config not validated enough+}

mentioned in commit 5b9e53ce4ca006d31469b8f3ccc8c9a4eef4e956

Part of this is solved. I update the description

In GitLab by @Roussel-C on Sep 29, 2016, 10:39
BTW, errors are often hard to catch in the config file.
While reading the config file, no data are actually used by PDI so:

unused variables
types mismatched
bad dimensions (for arrays)
and so on...can't be checked.

I think this can only be checked during export or import time but should not be done all the time.
Maybe a debug plugin should do that ?

closed


wrong work in ts.

Mistake:
Argument of type '{ ScrollAnimate: () => { isInView: ({ top, bottom }: any) => boolean; run(el: any, { value: params, modifiers }: any, { isUpwards, previousClassName }: any): string | undefined; }; install(app: any, opt: any): void; }' is not assignable to parameter of type 'Plugin_2<[]>'.
Type '{ ScrollAnimate: () => { isInView: ({ top, bottom }: any) => boolean; run(el: any, { value: params, modifiers }: any, { isUpwards, previousClassName }: any): string | undefined; }; install(app: any, opt: any): void; }' is not assignable to type '{ install: (app: App) => any; }'.
Types of property 'install' are incompatible.
Type '(app: any, opt: any) => void' is not assignable to type '(app: App) => any'.
Target signature provides too few arguments. Expected 2 or more, but got 1.ts(2345)

me too!


cmd/snapshots: add gc.root to created snapshots

This adds gc.root label to snapshots created with prepare and commit via
the CLI. WIthout this, created snapshots get immediately garbage
collected. There may be a better solution but this seems to be a solid
stop gap.
We may also need to add more functionality around snapshot labeling for
the CLI but current use cases are unclear.
Signed-off-by: Stephen J Day<EMAIL_ADDRESS>

LGTM

Codecov Report

Merging #2323 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2323   +/-   ##
=======================================
  Coverage   45.41%   45.41%
=======================================
  Files          83       83
  Lines        9210     9210
=======================================
  Hits         4183     4183
  Misses       4351     4351
  Partials      676      676

Flag
Coverage Δ

#linux
49.9% <ø> (ø)
:arrow_up:

#windows
41.24% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfba048...ed72059. Read the comment docs.

LGTM


Typewriter feature - again

Issue Type: Feature Request

I've come across this issue: https://github.com/microsoft/vscode/issues/47879. In which there is described a functionality of typewriter mode. That was implemented, but IMHO it lacks one major feature. It resembles Vim's 'scrollOff' which is nice. What I think it is missing is virtual space before the first line. Using implemented feature gives an option to center edited line, but only if the edited file is above a certain line number threshold. What I would like to see is current functionality with mentioned virtual space—working with code with edited line always in dead center is unpleasant as well.

/duplicate there is already an issue about virtual space.

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.
Happy Coding!

@hediet did you mean this one https://github.com/microsoft/vscode/issues/13960 ? Please read or take a look at the gif, it's completely different thing... Maybe I should not describe it as 'virtual space' in order not to confuse with feature mentioned in that ticket. That one is about ability to select (and copy) text in the editor like it was filled with spaces past the written text in line. My FR is about positioning, same thing?

This issue is not about virtual space, so it's not a duplicate of #13960. But same as with #5402, it requires virtual space to work properly. Should be reopened.

Please read or take a look at the gif

Which gif?


[Core] Default move constructor/assignment for CPublisher/CSubscriber

as the previous manual implementation was just plainly wrong.

@rex-schilasky @hannemn @FlorianReimold
Let's discuss about this. it's not so easy and our move tests crash with the default generated move operators.
E.g. in the move assignement case, I'd argue that we should first call Destroy(), because the original Subscriber might have been actively communicating.
I am not quite sure if we should just delete them altogether, though that would be an API change (not semver compatible).
So I am not sure how they are implemented correctly.

What's the reason for calling Destroy and not just moving all the variables over? I guess the communication implementation is probably in the m_datareader, right? Does the m_datareader have a pointer or reference to the original object? Because in that case I think moving should be entirely disabled (or the implementation will become extremely difficult). But otherwise it should be fine...


(WIP) Alternative Jackson 2.12.6 upgrade PR

DO NOT MERGE!
What this PR does:
Upgrades most of Jackson deps to 2.12.6 -- but unlike earlier PR #1681 leaves overrides for one module to see if that avoids test fails.
Which issue(s) this PR fixes:
Fixes #1680
Checklist

[ ] Changes manually tested
[x] Automated Tests added/updated
[ ] Documentation added/updated
[x] CLA Signed: DataStax CLA

Ok, based on work on the main PR, I think this will also fail with one test -- problem actual, not just with tests.


Doesn't work

Issue Type: Bug
All extensions doesn't work... specially "Reactjs code snippets"
Extension version: 2.4.0
VS Code version: Code 1.40.0 (86405ea23e3937316009fc27c9361deee66ffbf5, 2019-11-06T17:02:13.381Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-5200U CPU @ 2.20GHz (4 x 2195)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmetal: disabled_offmultiple_raster_threads: enabled_onoop_rasterization: disabled_offprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_offsurface_control: disabled_offsurface_synchronization: enabled_onvideo_decode: enabledviz_display_compositor: enabled_onviz_hit_test_surface_layer: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
3.91GB (0.55GB free)

Process Argv

Screen Reader
no

VM
67%

@Dam9  Could you provide some more info? Because everything looks fine when I tested after I upgrade to latest version (1.40.0) of VS code. No errors in console as well.

I am closing this as no further info provided. Feel free to open it again if required.


 Module was built without symbols.
'csgo.exe' (Win32): Loaded 'C:\Windows\SysWOW64\DXCore.dll'.
'csgo.exe' (Win32): Loaded 'C:\Windows\SysWOW64\igdumdim32.dll'.
'csgo.exe' (Win32): Loaded 'C:\Windows\SysWOW64\igdusc32.dll'.
'csgo.exe' (Win32): Loaded 'C:\Windows\SysWOW64\Windows.UI.dll'.
'csgo.exe' (Win32): Loaded 'C:\Windows\SysWOW64\WindowManagementAPI.dll'.
'csgo.exe' (Win32): Loaded 'C:\Windows\SysWOW64\twinapi.appcore.dll'.
'csgo.exe' (Win32): Loaded 'D:\SteamLibrary\steamapps\common\Counter-Strike Global Offensive\csgo\bin\matchmaking.dll'.
'csgo.exe' (Win32): Loaded 'D:\SteamLibrary\steamapps\common\Counter-Strike Global Offensive\csgo\bin\client.dll'.
'csgo.exe' (Win32): Loaded 'D:\SteamLibrary\steamapps\common\Counter-Strike Global Offensive\csgo\bin\server.dll'.
'csgo.exe' (Win32): Loaded 'D:\SteamLibrary\steamapps\common\Counter-Strike Global Offensive\bin\scenefilecache.dll'.
'csgo.exe' (Win32): Loaded 'C:\Windows\SysWOW64\shfolder.dll'.
'csgo.exe' (Win32): Loaded 'D:\SteamLibrary\steamapps\common\Counter-Strike Global Offensive\bin\vaudio_miles.dll'.
'csgo.exe' (Win32): Loaded 'D:\SteamLibrary\steamapps\common\Counter-Strike Global Offensive\bin\mss32.dll'.
'csgo.exe' (Win32): Loaded 'D:\SteamLibrary\steamapps\common\Counter-Strike Global Offensive\bin\mssmp3.asi'.
'csgo.exe' (Win32): Loaded 'D:\SteamLibrary\steamapps\common\Counter-Strike Global Offensive\bin\mssds3d.flt'.
'csgo.exe' (Win32): Loaded 'C:\Windows\SysWOW64\XAudio2_7.dll'.
'csgo.exe' (Win32): Loaded 'C:\Windows\SysWOW64\ResourcePolicyClient.dll'.
'csgo.exe' (Win32): Loaded 'C:\Users\Administrator\AppData\Local\Discord\app-1.0.9006\modules\discord_hook-1\discord_hook\d88e7fbd607\DiscordHook.dll'.
'csgo.exe' (Win32): Loaded 'C:\Windows\SysWOW64\dsound.dll'.
The thread 0x628 has exited with code 0 (0x0).

The thread 0x2440 has exited with code 0 (0x0).
**** Unable to localize '#GenericConfirmText_Label' on panel descendant of 'PopupManager'
Unknown command "cl_teamid_min"
Unknown command "cl_teamid_max"
Unknown command "cl_teamid_overhead"
Can't use cheat cvar cl_teamid_overhead_maxdist in multiplayer, unless the server has sv_cheats set to 1.
Unknown command "mat_antialias"
Unknown command "r_rootlod"
Unknown command "mat_picmip"
Unknown command "mat_reducefillrate"
Can't use cheat cvar mat_colorcorrection in multiplayer, unless the server has sv_cheats set to 1.
Unknown command "r_waterforcereflectentities"
Unknown command "mat_foreaniso"
NET_CloseAllSockets
'csgo.exe' (Win32): Loaded 'C:\Windows\SysWOW64\dhcpcsvc.dll'.
Certificate expires in 44h49m at<PHONE_NUMBER> (current time<PHONE_NUMBER>), will renew in 42h49m
Got SDR network config.  Loaded revision 406 OK
Performing ping measurement
SDR RelayNetworkStatus:  avail=Attempting  config=OK  anyrelay=Attempting   (Performing ping measurement)
AuthStatus (steamid:76561199242419290):  OK  (OK)
Unknown command "cl_thirdperson"
Unknown command "tr_best_course_time"
Unknown command "tr_completed_training"
'csgo.exe' (Win32): Loaded 'D:\SteamLibrary\steamapps\common\Counter-Strike Global Offensive\bin\vaudio_celt.dll'.
'csgo.exe' (Win32): Unloaded 'D:\SteamLibrary\steamapps\common\Counter-Strike Global Offensive\bin\vaudio_celt.dll'
'csgo.exe' (Win32): Loaded 'D:\SteamLibrary\steamapps\common\Counter-Strike Global Offensive\bin\vaudio_celt.dll'.
Unknown command "weapon_accuracy_logging"
Resource materials\panorama\images\icons\ui\globe.svg failed to load.
[02:42:01.969][PID 8696] PresentHandler(D3D9) created
[02:42:01.996][PID 8696] HookReset: hooked reset and reset_ex
[02:42:01.997][PID 8696] D3D9State::InitOverlay: initialized to 18D121A0 (window 00130D20: 1366x768)
Telling Steam it is safe to update the app
'csgo.exe' (Win32): Loaded 'D:\SteamLibrary\steamapps\common\Counter-Strike Global Offensive\bin\serverbrowser.dll'.
'csgo.exe' (Win32): Unloaded 'D:\SteamLibrary\steamapps\common\Counter-Strike Global Offensive\bin\serverbrowser.dll'
'csgo.exe' (Win32): Loaded 'D:\SteamLibrary\steamapps\common\Counter-Strike Global Offensive\bin\serverbrowser.dll'.
Host_WriteConfiguration: Wrote cfg/config.cfg
DispatchAsyncEvent backlog, failed to dispatch all this frame. 246 of 259 remaining
--- Missing Vgui material vgui/..\vgui\maps\menu_thumb_default
Ping measurement completed
Ping location: fra=79+7,vie=79+7/80+7,ams=105+10/84+7,par=100+10/88+7,waw=87+8/88+8,lhr=160+16/92+7,sto=117+11/99+7,sto2=117+11/99+7,mad=107+10/109+7,iad=211+21/165+7,gru=273+27/274+27,sgp=310+31/287+23
SDR RelayNetworkStatus:  avail=OK  config=OK  anyrelay=OK   (OK)
--- Missing Vgui material vgui/../vgui/icon_con_medium.vmt
--- Missing Vgui material vgui/../vgui/icon_con_low.vmt
ChangeGameUIState: CSGO_GAME_UI_STATE_INTROMOVIE -> CSGO_GAME_UI_STATE_MAINMENU
'csgo.exe' (Win32): Loaded 'C:\Windows\SysWOW64\profapi.dll'.
CCSGO_BlurTarget - Unable to find panel with the given id "CSGOLoadingScreen"! Panel is possibly created dynamically.
CCSGO_BlurTarget - Unable to find panel with the given id "eom-winner"! Panel is possibly created dynamically.
CCSGO_BlurTarget - Unable to find panel with the given id "id-mainmenu-mission-card-bg"! Panel is possibly created dynamically.
CCSGO_BlurTarget - Unable to find panel with the given id "id-op-mainmenu-top"! Panel is possibly created dynamically.
CCSGO_BlurTarget - Unable to find panel with the given id "id-tournament-pass-status"! Panel is possibly created dynamically.
CCSGO_BlurTarget - Unable to find panel with the given id "id-op-mainmenu-rewards"! Panel is possibly created dynamically.
CCSGO_BlurTarget - Unable to find panel with the given id "id-op-mainmenu-missions"! Panel is possibly created dynamically.
CCSGO_BlurTarget - Unable to find panel with the given id "id-activemission-tooltip"! Panel is possibly created dynamically.
CCSGO_BlurTarget - Unable to find panel with the given id "id-active-mission"! Panel is possibly created dynamically.
CCSGO_BlurTarget - Unable to find panel with the given id "CSGOLoadingScreen"! Panel is possibly created dynamically.
CCSGO_BlurTarget - Unable to find panel with the given id "CSGOLoadingScreen"! Panel is possibly created dynamically.
'csgo.exe' (Win32): Loaded 'C:\Users\Administrator\Downloads\csgo-legit.dll'. Module was built without symbols.
'csgo.exe' (Win32): Loaded 'C:\Windows\SysWOW64\D3DX9_43.dll'.
'csgo.exe' (Win32): Unloaded 'C:\Windows\SysWOW64\D3DX9_43.dll'
'csgo.exe' (Win32): Loaded 'C:\Windows\SysWOW64\D3DX9_43.dll'.
The thread 0x4a0 has exited with code<PHONE_NUMBER> (0x792b0000).
Exception thrown at 0x792DBE1D (csgo-legit.dll) in csgo.exe: 0xC0000005: Access violation reading location 0xAB8409CA.
The program '[8696] csgo.exe' has exited with code 0 (0x0).`

Debugging with manual map will not help you at all. I am not the author of any of those injectors.
For "downloadable" injector, use any with loadlib. Or make your own where you handle all of exceptions correctly.

Anyway, for you I have downloaded this injector in the newest release, and it is working.
Side note: don't think such ways of disabling vac will help you, since this is public it's only a source for them to learn.

Yeah ik Vac updated and the antivac on the 2.4 version not work im using it bcs i love the CMD injector i will try an load library injector thanks.

load library injector doesnt worked too

im using -insecure

with extreme injector

release debugging also doesn't help you

The problem is that probably this isn't the right place to call it or too soon. Go to mirrorcam
And do this
//interfaces::matSys->forceBeginRenderTargetAllocation();
m_texture = interfaces::matSys->createFullFrameRenderTarget(XOR("mirrorCam"));
//interfaces::matSys->forceEndRenderTargetAllocation();

I have no time to debug it now, in 2h I will be free, it probably just calls it too soon

worked thanks


does not support 4x20 char lcd

can you add support for a 4x20 char lcd?  simliar to the raspberry sharp IO library for mono?
https://github.com/raspberry-sharp/raspberry-sharp-io

Hello,
Thank you for your feedback. This should be already possible.
Constrictor of displayI2C can be overloaded, so you can define it by this code:
byte[] llineaddress = new byte[] { 0x00, 0x40 , 0x80 , 0x100 } //here you can define start address of each line.
displayI2C lcd = new displayI2C(DEVICE_I2C_ADDRESS, I2C_CONTROLLER_NAME, RS, RW, EN, D4, D5, D6, D7, BL, llineaddress);

If it helps please give a feedback, I'll add this information into README.

Hi,
I buy this LCD Panel for my project: http://www.amazon.de/SainSmart-Serial-Module-Blacklight-Arduino/dp/B00GHG27Z2/
My Problem is, that the configuration is incorrect. With the standart configuration (displayI2C lcd = new displayI2C(0x27, I2C1, 0, 1, 2, 4, 5, 6, 7, 3); ) I can turn on or off the display light, but I can't write text on the display.
With this configuration unter Raspian the LCD Display works: LiquidCrystal_I2C lcd(0x3F, 2, 1, 0, 4, 5, 6, 7, 3, POSITIVE); - when I choose this configuration with 0x3F ... Visual Studio shows an error to runtime.
Chris

Hello,
Many thanks for your feedback.
Can you be more specific? Please send error message from Visual Studio.
Thank you.

This can help you: https://www.hackster.io/dzerycz/character-lcd-over-i2c-ba8ee9?ref=user&ref_id=14980&offset=0#9845


Allow already tokenized sequences for response_template in DataCollatorForCompletionOnlyLM

This PR fixes issue described in https://github.com/lvwerra/trl/issues/598
Problem
Some tokenizers will tokenize the same string differently, depending on whether it has left context or not. An example of this is the tokenizer of meta-llama/Llama-2-7b-hf, that tokenizes the response_template differently in these cases:
from transformers import AutoTokenizer
tokenizer = AutoTokenizer.from_pretrained("meta-llama/Llama-2-7b-hf")

def print_tokens_with_ids(txt):
    tokens = tokenizer.tokenize(txt, add_special_tokens=False)
    token_ids = tokenizer.encode(txt, add_special_tokens=False)
    print(list(zip(tokens, token_ids)))

prompt = """### User: Hello\n\n### Assistant: Hi, how can I help you?"""
print_tokens_with_ids(prompt)  # [..., ('▁Hello', 15043), ('<0x0A>', 13), ('<0x0A>', 13), ('##', 2277), ('#', 29937), ('▁Ass', 4007), ('istant', 22137), (':', 29901), ...]

response_template = "### Assistant:"
print_tokens_with_ids(response_template)  # [('▁###', 835), ('▁Ass', 4007), ('istant', 22137), (':', 29901)]

This leads to an error when the instanced data_collator DataCollatorForCompletionOnlyLM tries to look for the response_template in the text of the instruction dataset, because it does not find it.
Solution
Allow response_template in DataCollatorForCompletionOnlyLM to use directly token_ids that are prepared with enough context (and then sliced) to match how they appear in instruction datasets, where they have the left context.
Extra additions in the PR
I added a test to check the fix, for which I had to use a non-official tokenizer (upstage/Llama-2-70b-instruct-v2 instead of meta-llama/Llama-2-7b-hf) because the official one needs to be logged in a huggingface account that has accepted the License and has been granted access to the tokenized, as described in the model card.
I also added a subsection in the documentation that explains the problem and how to solve it using the code fix that only works with this PR.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Sorry, I forgot to delete some unneeded code for the test. Now it should be ready for review


New Microsoft.Logic API Version: 2018-07-01-preview

Description

REST spec PRs:
Add new microsoft.logic version
Change some string Microsoft.Logic modeled enums back into enums
Remove default response from Sessions

This checklist is used to make sure that common guidelines for a pull request are followed.

[x] Please add REST spec PR link to the SDK PR
[x] I have read the contribution guidelines.
[ ] The pull request does not introduce breaking changes.

General Guidelines

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

SDK Generation Guidelines

[x] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
[ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
[x] The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

This introduces a lot of breaking changes. We are doing a version up of the APIs

Please fix the CI errors reported

Talked to @shahabhijeet , self signed certificates are acceptable, thanks!


1.36.0-insider macOS cannot new and close active editor by key command + n, command + w

VSCode Version:
1.36.0-insider (7f53e50cbf316dff94fbbe5406d8f352dac99a6b)
OS Version:
macOS 10.14.5（18F132）

Steps to Reproduce:

Open editor
Push command + n or command + w

Does this issue occur when all extensions are disabled?: Yes/No
Yes

developer tools shows
keybindingService.ts:370 Ctrl/Cmd+Num keybindings should not be used by default in web. Offender:  000141;000121  for  editor.foldAll
_assertBrowserConflicts @ keybindingService.ts:370
keybindingService.ts:370 Ctrl/Cmd+Num keybindings should not be used by default in web. Offender:  000141;000129  for  editor.foldAllMarkerRegions
...
keybindingService.ts:346 Ctrl/Cmd+W keybindings should not be used by default in web. Offender:  000153  for  workbench.action.closeActiveEditor

@rebornix Seems you made a lot of changes in that area yesterday.
This was working until today's update for me.

Just did the most recent update myself and can vouch for this issue. Had to re-add the key shortcuts back manually (which doesn't cause any conflicts) but just wondering why they'd been removed to begin with?

Until this issue gets fixed, you can re-add those shortcuts manually with [⌘K ⌘S]:
[
  {
    "command": "workbench.action.closeActiveEditor",
    "key": "cmd+w"
  },
  {
    "command": "workbench.action.files.newUntitledFile",
    "key": "cmd+n"
  }
]

It's more than that, many keybindings are missing. Another example is cmd+t for go to symbol in ws.

There's a few for sure, but the same temporary fix applies.
Whichever shortcuts you're missing at the moment, just manually add them back till it's either permanently fixed or an explanation is given 👍🏻
There's probably some missing that you'll never use, so they're no big deal to leave alone for the time being.

This issue has fixed in latest release (68a7e5bc437b38d0281df0756997a25da2a2900c).
Thanks!


Fix search input on the ThemeSite for iOS Safari

I opened this issue before: https://github.com/gohugoio/gohugoioTheme/issues/119
It was addressed but then again I am still getting white text in a white search input box at the ThemeSite.

this one is already fixed


accurate

Is your online test effective? I found that the detection box is not very accurate.

The marker of the previous frame will disappear after the marker of the next frame is issued, so it does not look very accurate。I will modify the code later to solve this problem

You can use the pixor_ros_20200331.py script．


Enable semantic colorization for Visual Studio Razor LSP

Fixes https://github.com/dotnet/aspnetcore/issues/22113.

Looks awesome! Just one last general question. If we merge this will VS explode when editing Razor files? Just want to make sure it doesn't block development

As of right now yes. The PR with fixes for that behavior on their end is blocked behind a separate issue. We had talked about creating a switch for semantic tokens on their end (that we could leave off by default) so we wouldn't break everything when we merged, I can go ahead and do that if we feel what would be sufficient.


Revert "Merge pull request #1 from MisterBham/feature/readme"

Reverts MisterBham/workday-scheduler#2

no revert


kong1.3.0 dbless mode fail start: by using basic-auth plugin to set basicauth_credentials

Summary
basic-auth plugin on kong 1.3.0 declarative dbless mode start failed.
Rollback to kong 1.2.0 it works.
nginx: [error] init_by_lua error: ...are/lua/5.1/kong/db/schema/others/declarative_config.lua:423: attempt to index local 'parent_fk' (a nil value)
basicauth_credentials:
  - consumer: eq-survey
    username: admin
    password: ***********************

Additional Details & Logs

Kong version (1.3.0)
Kong debug-level startup logs (

nginx: [error] init_by_lua error: ...are/lua/5.1/kong/db/schema/others/declarative_config.lua:423: attempt to index local 'parent_fk' (a nil value)
stack traceback:
        ...are/lua/5.1/kong/db/schema/others/declarative_config.lua:423: in function 'get_key_for_uuid_gen'
        ...are/lua/5.1/kong/db/schema/others/declarative_config.lua:457: in function 'generate_ids'
        ...are/lua/5.1/kong/db/schema/others/declarative_config.lua:480: in function 'flatten'
        /usr/local/share/lua/5.1/kong/db/declarative/init.lua:153: in function 'parse_file'
        /usr/local/share/lua/5.1/kong/init.lua:252: in function 'parse_declarative_config'
        /usr/local/share/lua/5.1/kong/init.lua:430: in function 'init'
        init_by_lua:3: in main chunk

)

Docker: kong:1.3.0-alpine

same problem here. try to use jwt plugin. error raises when adding 'key' field
jwt_secrets:
 - consumer: test
   algorithm : HS256
   secret: any-secret
   key: any-key

Same here, upgrade from 1.2.1 declarative. Seems like if I delete jwt_secrets and acls it will load fine

@andiexer were you able to find a workaround? I am running into exactly the same issue.

@EvgenyKarataev we switched to an older docker image (1.2.2). with this one everything works fine right now

@andiexer, thanks for the reply. FYI, I also just found that if you enable the plugin on the consumer directly, it works with 1.3.0, e.g. this worked for me:
`consumers:

username: test
jwt_secrets:

key: test
algorithm: HS256
secret: test
`

Hi @crazytravel, thanks for reporting this. I was able to reproduce your issue in 1.3.0, but it seems to have been fixed in 1.4.0rc1. I also tried it on the next branch.
Could you confirm that the problem is gone for you in 1.4.0rc1?


List supported browsers and versions

The website states "Simple API, no dependencies – yet super-fast on all major browsers."  Making that list explicit with versions and and OSes will help users and developers.

I missed this in the README:

KaTeX supports all major browsers, including Chrome, Safari, Firefox, Opera, and IE 8 - IE 11.


css: Remove message_hovered class

Merged, after adding a quick commit message note that this was dead code.


[VS Code] Joining collaboration session: The specified hostname isn’t a valid Live Share URL. Please check the link provided by the host and try again.

Error:
Joining collaboration session: The specified hostname isn’t a valid Live Share URL. Please check the link provided by the host and try again.
Steps to Reproduce:
1.
2.

Version Data

extensionName
VSLS

extensionVersion
1.0.694

protocolVersion
2.2

applicationName
VSCode

applicationVersion
1.37.0

platformName
Windows

platformVersion
6.1.7601

Closing due to inactivity. Please re-open if this you're still encountering the issue and can share more details. Thanks!


Problem assigning 2D bones.

Tested versions
v3.6.rc1.official [cfc4a0eff]
4.3 beta 3
System information
w10 64
Issue description
https://youtu.be/wgU7YkQehW4
As you can see in this video, the allocation of the bones is not preserved and something happens that changes everything. Watch the video, you could do the same thing infinitely.
The tutorial indicates that when creating these "Polygono2D" nodes, to make it faster they must be duplicated. I thought that was the error, so I restarted the project and started again without duplicating but the problem still happens, so it is not due to the duplication of the "Polygon2D" nodes.
https://docs.godotengine.org/en/3.6/tutorials/animation/2d_skeletons.html
Steps to reproduce
see the video
Minimal reproduction project (MRP)
testSkeleton.zip

I was browsing for a different bug, and came across this. After watching the video, I believe there might be a misunderstanding. The "Bones" tab of the UV editor brings up a texture painter. The list of bones on the right select which bone's influence you are going to paint. When you actually have a weight painted, revisiting the UV Bones tab will go to the earliest bone which influences the polygon. If you haven't painted any weights, then it will select the first bone in the list every time.


Use LiT tls cert when connecting to LiT's service

nvm ;)

https://github.com/lightninglabs/lightning-terminal/pull/261#issue-714435578


Upgrade to<EMAIL_ADDRESS>

[REQUIRED] Step 1: Describe your environment

Xcode version: 12.3
Firebase SDK version: 7.7.0
Installation method: CocoaPods
Firebase Component: Auth

[REQUIRED] Step 2: Describe the problem
Steps to reproduce:
Vulnerability is found in current firebase-admin through node-forge 0.7.4. Remedy for this to  Upgrade to<EMAIL_ADDRESS>But the latest firebase SDK 7.7.0 uses<EMAIL_ADDRESS>version. Can you provide a Firebase release which uses latest<EMAIL_ADDRESS>?
Ref link : https://app.snyk.io/test/npm/firebase-admin/6.5.1
Relevant Code:
https://github.com/firebase/firebase-ios-sdk/blob/7.7.0/Functions/Backend/package.json

Thanks for the report @shwetha-mugeraya24. From an SDK standpoint we're safe since this is only used for local integration tests using the emulator, but we should still get this resolved for CI and local dev purposes.

@ryanwilson  So Can I expect a release soon with<EMAIL_ADDRESS>?

@shwetha-mugeraya24 we should be able to do make this change soon and it would be included in not the upcoming release but the one after, likely ~3 weeks away.
That being said - are you using these Functions integration tests locally? Just using the SDK in your product does not use any npm modules or the firebase-admin SDK at all.


Rule sort-prop-types add noSortAlphabetically

Same as https://github.com/yannickcr/eslint-plugin-react/pull/979

@yannickcr @lencioni @EvHaus can any of you review this ? Thank you so much in advance !

Thanks !
My team voted against the alphabetical rule because they prefer to sort some data (for example put user first on <User user={user} avatar={avatar} onClick={onClick} /> :
User.propTypes = {
  user: UserShape.isRequired,
  avatar: AvatarShape.isRequired,
  onClick: PropTypes.func.isRequired,
}

But still be able to use requiredFirst and callbacksLast :)

Thanks for merging ! I know you just released 7.11.0, but do you plan to make another release with this soon ?


Error messages: How might we prevent broken logic flows

User story
As a form builder using conditional logic
I need to realize where the form flow doesn't work and where the experience could break down for users
So that end users filling out the form can be successful and not get stuck or confused
Exploration
https://www.figma.com/design/bIcbQm61JbkCy9Nu8XE7u6/Conditional-logic-Alpha?node-id=4451-1324&t=ZZJakBGDl5bWHyy2-4

Acceptance criteria

[x] EN error message ideas drafted
[ ] EN error message ideas vetted for feasibility
[ ] EN feasible intervention content finalized
[ ] FR error message content drafted
[ ] Where in the flow/app should these go?
[ ] Dev implementation

This might be a heavy lift and could be for a future iteration.
Will check with Tim to see how much we can potentially try to prevent.

Decision (Jul 15): Descoped for our first release. Perhaps a future iteration could get more specific about preventing broken form scenarios, to be explored for v2 maybe.


mail: Eliminate unnecessary tags and settings

I don't see a reason to have these tags:

OCP_LOGO
TWITTER_LOGO
FB_LOGO
LINK_LOGO
STRIVE_LOGO
TWITTER_LINK
FACEBOOK_LINK
LINK_LINK

Supported by these settings:

FACEBOOK_LINK
TWITTER_LINK
LINK_LINK
IMAGES_BASE_URL

We can just hardcode them in the template.
if we export Credere somewhere else, the way to do it is write new email templates (which we'd probably have to do anyway).
I'm writing the SES docs and right now all these tags need to be provided, when it would be simpler to just set SUBJECT and CONTENT.

I haven't ever tested opening an email that loads images from localhost (not sure it works?). If that's a use case, then we can leave one tag like {{BASEURL}}.
Edit: GMail caches images, so it won’t display localhost images without a workaround: https://webapps.stackexchange.com/questions/53290/render-images-with-non-public-url-in-body-of-gmail-message This assumes developers send emails to themselves that are hosted on GMail (likely).

Soft blocked by #375 to avoid conflicts


yaml file not found

Thanks for this extension, however I can't use it.
When I want to use the extension on a text in my code I always get the error: The l10n.yaml file was not found. However my yaml file is called l10n.yaml and is at the root of my flutter project (see screenshot). I didn't change any parameter of the extension.
PS : I am on Mac (I don't know if the paths are different)
Thanks in advance for the answer.

Thanks for reporting this bug.
I am also on macOS.
I'll look into it as soon as possible.

The bug is fixed in version 1.0.1.
Thanks for reporting it.

Thanks for the reactivity :D


[DOC] Add more reference to code copied from std

Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

...

New functionality

...

Test plan
How are these changes tested?

[ ] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

#3100  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Sicheng-Pan and the rest of your teammates on  Graphite


ssl error that "your connection to this site is not fully secure" (http:// to https://)

file location:
content/news/161-nickatnyte.md
Note: https://lbry.io/news/nickatnyte giving ssl error that "your connection to this site is not fully secure" It's giving this error because this link is only http://berk.ninja/thumbnails/TW-sWnxiHrs so replace with  https://berk.ninja/thumbnails/TW-sWnxiHrs
<video width="100%" controls poster="http://berk.ninja/thumbnails/TW-sWnxiHrs" src="https://spee.ch/37763ba30c3714491816fec88ff208c3fc42ea00/boosted-troops-loot-clash-of-clans.mp4"/></video>
replace with this code
<video width="100%" controls poster="https://berk.ninja/thumbnails/TW-sWnxiHrs" src="https://spee.ch/37763ba30c3714491816fec88ff208c3fc42ea00/boosted-troops-loot-clash-of-clans.mp4"/></video>

Can you submit a pr to fix this?

This should be done on the server "Enforce HTTPS" to catch any content that's not https, rather than trying to find things all the time, especailly when content comes in dynamically or when links are used in blog posts.
Not familiar with the LBRY set up but something like this:
 <IfModule mod_setenvif.c>
  SetEnvIf X-Forwarded-Proto "^https$" HTTPS
</IfModule>

Additionally, Let's Encrypt, have the following option in cPanel, There might be a similar option in the interface LBRY use?


remove role/rolebinding finalizer when manifestworks are cleaned

remove finalizer on rbac when all manifestworks are cleaned (samiliar from pr https://github.com/open-cluster-management/work/pull/23) but i think it is better to move to registration repo.

/assign deads2k
/assign pmorie
/assign elgnay

/retest

/lgtm
/approve
/hold
holding in case @pmorie has comments.

Found a couple nits, you can fix them in a follow-up.
/hold cancel

/retest
/lgtm

/retest

/retest


feat: Add new componentes to allow profile edition

Description
WIP

@FedeMadoery If the transaction of editing profile is still failing here, we may need to wait for the contracts fix first

The fixes for the contracts are deployed, it should work fine, cc @FedeMadoery @ramabit


fix(ui/telegraf): filter functionality

Closes #15246
This PR fixes the search funcitonality in the ui/telegraf input field.
Problem
The problem originated by an invalid prop filter, where the frontend was expecting results to be filtered based on a label array property, rather than a string.

Solution
Updated the frontend filter functionality to search for the filter parameter based on the correct property - telegrafconfig.name

[ ] CHANGELOG.md updated with a link to the PR (not the Issue)
[ ] Well-formatted commit messages
[ ] Rebased/mergeable
[ ] Tests pass
[ ] http/swagger.yml updated (if modified Go structs or API)
[ ] Documentation updated or issue created (provide link to issue/pr)
[ ] Signed CLA (if not already signed)

🎉 ❤ 🎉


Error within streamFactory causes unhandled promise rejection

Describe the bug
Any rejected promise returned by the streamFactory function will cause an unhandled promise rejection, even when the caller handles all exceptions.
To Reproduce
test('streamFactory error propagation', async () => {
      const rpcClient = new RPCClient({
        manifest: {},
        streamFactory: () => Promise.reject(new Error("streamFactory error")),
        logger,
        idGen,
      });
      try {
        await rpcClient.unaryCaller(methodName, {}).catch(() => {});
      }
      catch(e) {
      }
    });

Expected behavior
The error should be able to be caught by the caller.
Screenshots
/home/amy/git/js-rpc/tests/RPCClient.test.ts:1245
            const error = new Error('streamFactory error');
                          ^

Error: streamFactory error
    at Object. (/home/amy/git/js-rpc/tests/RPCClient.test.ts:1245:27)
    at Promise.then.completed (/home/amy/git/js-rpc/node_modules/jest-circus/build/utils.js:333:28)
    at new Promise ()
    at callAsyncCircusFn (/home/amy/git/js-rpc/node_modules/jest-circus/build/utils.js:259:10)
    at _callCircusTest (/home/amy/git/js-rpc/node_modules/jest-circus/build/run.js:277:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/home/amy/git/js-rpc/node_modules/jest-circus/build/run.js:209:3)
    at _runTestsForDescribeBlock (/home/amy/git/js-rpc/node_modules/jest-circus/build/run.js:97:9)
    at _runTestsForDescribeBlock (/home/amy/git/js-rpc/node_modules/jest-circus/build/run.js:91:9)
    at _runTestsForDescribeBlock (/home/amy/git/js-rpc/node_modules/jest-circus/build/run.js:91:9)

Additional context

https://gitlab.com/MatrixAI/Engineering/Polykey/Polykey-Network-Status/-/merge_requests/22#note_1806676003
Notify maintainers

@amydevs
@tegefaulkes

hjhjhj

Testing...

Testing @amy.yan


Allow restricting entire routes

Suppose an application contains the following routes which should be restricted:
/admin/deleteuser
/admin/createuser
/admin/moresecretstuff

Would it be possible to just specify /admin and all sub-routes will be restricted too?

I don't know if there are better ways, but I found a potential solution.
If privateURLArray is tested against a filter function (similar to the one suggested here), e.g.:
item => new RegExp('^' + item.replace(/\*/g, '.*') + '$').test(str)

Then this line
https://github.com/kumarasinghe/slimauth/blob/a88637e24c51bfaf4ca9f1a7923035adcda4f996/src/slimauth.js#L230
Can be replaced with:
if (req.userID == undefined && filterBy(req.baseUrl + req.path).length) {

With this, privateURLArray can be set to /admin* and it will restrict all the sub-routes.

Hi! Thanks for raising this matter.
It is recommended to add all your private routes to privateURLArray
Wide card matching on private routes wasn't implemented at first place since they are expensive operations.
Do you have a large number of private routes in your project?

Do you have a large number of private routes in your project?

Currently not, but I would like to, and it would be very cumbersome to specify the full route for each one.

I understand. Let's see if I can think of a way to do this without trading off performance.

A thought recently occurred to me. Would adding an option to set an "allowlist" instead of the current blocklist be a possible solution?
It would certainly work for me, and it also has the benefit of being secure by default.