Some remarks

Maybe, search globally for "present version", "future", "current" to check that things are up-to-date, and write instead things like "up to Version...", "from Version...".

Maybe, write somewhere: "This version of the Metamath book uses the version ... of the Metamath program." (Though it looks like several output displays should be put up-to-date).

The exact quotation by Saint-Exupéry (quoted on p. 183) is:

« Il semble que la perfection soit atteinte non quand il n’y a plus rien à ajouter, mais quand il n’y a plus rien à retrancher. »
Antoine de Saint-Exupéry, Terre des hommes, chapitre III: L'avion, 1939.
The book "Terre des hommes" (Men's Land) was translated in English as "Wind, Sand and Stars".
My translation of the quote:
It seems that perfection is reached not when there is no longer anything more to add, but when there is no longer anything more to take away.

I have  a similar remark in direction of the first bullet point of Benoit: Chapter 1, Introduction starts with "In the past century". Which century is meant? I think it's the 19th century (starting with Gauss, Bolzano, Cauchy, etc.) , so it must read "In the past two centuries...".

Maybe, search globally for "present version", "future", "current" to check that things are up-to-date, and write instead things like "up to Version...", "from Version...".

@nmegill - can you do that & tell me if something has changed?  I don't necessarily know what's changed.

Maybe, write somewhere: "This version of the Metamath book uses the version ... of the Metamath program." (Though it looks like several output displays should be put up-to-date).

In principle I agree, but that's too much work for not enough benefit.

The exact quotation by Saint-Exupéry (quoted on p. 183) is: ...

We don't need the exact French here, and the translation is cited.  I think the cited translation is far more popular in English anyway. So I think it's fine as-is.

I have a similar remark in direction of the first bullet point of Benoit: Chapter 1, Introduction starts with "In the past century". Which century is meant? I think it's the 19th century (starting with Gauss, Bolzano, Cauchy, etc.) , so it must read "In the past two centuries...".

I think it's better to remove "In the past century" completely.  New phrasing:
-In the past century, brilliant mathematicians have discovered almost
+Brilliant mathematicians have discovered almost
 unimaginably profound results that rank among the crowning intellectual
 achievements of mankind.  However, there is a sense in which modern abstract
 mathematics is behind the times, stuck in an era before computers existed.

I'll turn that into a separate PR.

The only thing left in this issue is to hear from Norm about "present version", "future", "current".

Maybe, search globally for "present version", "future", "current" to check that things are up-to-date, and write instead things like "up to Version...", "from Version...".

@nmegill - can you do that & tell me if something has changed? I don't necessarily know what's changed.

There are a number of changes needed.  I will try to update all of these today.

Maybe, search globally for "present version", "future", "current" to check that things are up-to-date, and write instead things like "up to Version...", "from Version...".

@nmegill - can you do that & tell me if something has changed? I don't necessarily know what's changed.

There are a number of changes needed. I will try to update all of these today.

These are updated in commit 11dc660.
BTW the book is looking great!   @david-a-wheeler  has done a much better job than I could have handled alone.  David, I think we should have a specific acknowledgment to @benjub - could you do that at some point?  Others have also contributed some corrections, perhaps they should be mentioned (maybe a list)?

@nmegill - great minds think alike!  I'm working on a "Note Added" right now to credit the hard work of Benoit Jubin (I'm currently looking up how to do his name's circumflex in LaTeX).

@nmegill - thanks for the compliment!!
The "Notes" add credits to people, so I think that covers it.  We also include them in the index if people want to look up their own name.
I think we're done with this issue, so I'm closing it.  Please re-open if there's something in it that still needs doing.


fix(safari): Logged out users should be redirected to the login page.

Reproduction Steps

Login via getpocket.com
Save an item
Logout via getpocket.com
Save an item

Page Saved! appears (user should be redirected to login page)

Fixed in #167


Bdd reversed engine to generate Real pages demostration

This functionality I'm imagining to be real.
When I finish all feature definitions without really implementing application functionality ,
I can get a Demo Application.
According features definitions, reversed engine will build a demo project with all pages needed.
I can check all functionalities via browsing these pages.
If anyone has interest with this project , leave me a message? :)

In order to automate implementation from the features, your features must describe solutions. And even though it is possible, it is not the way of Behat (Behaviour Driven Development).
In Behaviour Driven Development you describe problems, so that developers can come up with right solutions. You do not describe how you would solve particular problem, you just discuss what this problem is about.
What you want to do is probably possible to certain extent, but goes against what Behat as a core is. I'd advise you pursue custom extension, so people can join you in your way of using tool. But that's not what Behat was built for, nor it is something that I see in the core of the tool.


[SUGGESTION] Use Kominfo's TrustPositif API

Merely a suggestion, but it seems like you can just input the web's domain.tld into Kominfo's TrustPositif form to check if its blocked or not.
That method could be more reliable than checking to indi.wtf (tho i guess checking from both sources wouldn't hurt)

Will keep in mind. Thank you for the suggestion!

Might take up this issue if no one is implementing it currently, any guidelines for contributing or should i just fork and pull? @angeloanan


Tar extraction disk / directory

SD-1674, originally created on 6/3/2010 06:12:44 by David Pierson
The TarArchive.ExtractContents(string destinationDirectory) method does
not allow control over extraction in terms of resulting target folders.
See
community.sharpdevelop.net/forums/t/11321.aspx
Also, it always strips off the drive spec from the entry name, and
overwrites this with the destinationDirectory spec. If you want to keep
the drive spec in the tar, leaving that blank does not work. See
community.sharpdevelop.net/forums/t/10875.aspx
Provide a way to allow some control.
Or just suggest via sample a way using the example in the
11322
thread using TarInputStream.

Closing in favor of #338.


Bug/aspect ratio

PR for #345  .
PR Status
HOLD UNTIL PR #344 MERGED
Ready for PR?

[x] I have updated the CHANGELOG with an entry including a description, a link to my profile, and a link to the issue ticket. This change is filed under an Enhancement or Bug Fix, is shown under the relevant release tag name, and is included in my PR branch.
[x] I have run lein run-lint to check for linting errors.

Changes Proposed:

Arena size set using a ratio to fix display issues

@emilyseibert @oconn @dehli

Could you pull develop into this?

Pulled! 🙃

@dehli Check this out 🚀
I wasn't able to get the correct properties from the watcher but I succeeded in fixing the problem using add-watch - let me know if there's something you'd do differently!

Could you resolve the conflicts?

Fixed conflicts!

I think this is a lot better, let me know what you think!


404 on https://app.getsentry.com/_static/sentry/images/favicon.ico

The default card uses https://app.getsentry.com/_static/sentry/images/favicon.ico, but it returns a 404
Can we restore this or do we need a different path?

I restored behavior for this on our side, but we definitely just shouldn't be hardcoding this URL since the URL has changed. So I'll leave this ticket open to address that.
Thanks for bringing it to our attention.


chore(app): fixing sets of code smells

:tada: This PR is included in version 2.9.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[SPARK-31258][BUILD] Pin the avro version in SBT

What changes were proposed in this pull request?
add arvo dep in SparkBuild
Why are the changes needed?
fix sbt unidoc like https://github.com/apache/spark/pull/28017#issuecomment-603828597
[warn] Multiple main classes detected.  Run 'show discoveredMainClasses' to see the list
[warn] Multiple main classes detected.  Run 'show discoveredMainClasses' to see the list
[info] Main Scala API documentation to<EMAIL_ADDRESS>[info] Main Java API documentation to<EMAIL_ADDRESS>[error] /home/jenkins/workspace/SparkPullRequestBuilder@6/core/src/main/scala/org/apache/spark/serializer/GenericAvroSerializer.scala:123: value createDatumWriter is not a member of org.apache.avro.generic.GenericData
[error]     writerCache.getOrElseUpdate(schema, GenericData.get.createDatumWriter(schema))
[error]                                                         ^
[info] No documentation generated with unsuccessful compiler run
[error] one error found

Does this PR introduce any user-facing change?

no
How was this patch tested?

pass jenkins
and verify manually with sbt dependencyTree
 kentyao@hulk  ~/spark   dep  build/sbt dependencyTree | grep avro | grep -v Resolving
[info]   +-org.apache.avro:avro-mapred:1.8.2
[info]   | +-org.apache.avro:avro-ipc:1.8.2
[info]   | | +-org.apache.avro:avro:1.8.2
[info]   +-org.apache.avro:avro:1.8.2
[info]   | | +-org.apache.avro:avro:1.8.2
[info] org.apache.spark:spark-avro_2.12:3.1.0-SNAPSHOT [S]
[info]   | | | +-org.apache.avro:avro-mapred:1.8.2
[info]   | | | | +-org.apache.avro:avro-ipc:1.8.2
[info]   | | | | | +-org.apache.avro:avro:1.8.2
[info]   | | | +-org.apache.avro:avro:1.8.2
[info]   | | | | | +-org.apache.avro:avro:1.8.2

cc @HyukjinKwon

Test build #120361 has started for PR 28020 at commit 1c0ead9.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25071/
Test PASSed.

Test build #120361 has finished for PR 28020 at commit 1c0ead9.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120361/
Test PASSed.

Also, let's file a JIRA.

@dongjoon-hyun @HyukjinKwon, thanks. I have filed the Jira and update sbt-dependencyTree

Looks good given they many people faced this randomly in unidoc. I checked the avro version is 1.8.2 from branch-2.4 to master.

Merged to master, branch-3.0, and branch-2.4.

Hi, @HyukjinKwon and @yaooqinn .
This seems to break branch-2.4 SBT build at org.apache.spark.streaming.flume.sink.SparkSinkSuite.

https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-branch-2.4-test-sbt-hadoop-2.6/
https://amplab.cs.berkeley.edu/jenkins/view/Spark QA Test (Dashboard)/job/spark-branch-2.4-test-sbt-hadoop-2.7/

The current situation is due to the incompatiblity between Avro 1.7 and 1.8.
This might be the outdated sbt-avro plugin issue.

Currently, this blocks the branch-2.4 PR builder , too. I'll revert this first from branch-2.4. Please make a PR against branch-2.4. Thanks.

Hm, I see. thanks for checking it, and reverting @dongjoon-hyun.

Let me don't port it back considering the complexity vs the gain for now.


Add fill_with_function

Add a fill_with_function where the replacement is derived by calling a function. This is much more general than replacing from a HashMap as it allows the substitutions to be computed directly from the key. It also allows things like tracking which replacements were actually used to do a substitution.
That function returns Option<Cow<str>> so it can either return a borrowed value or compute an owned String. This is always "strict" since the function can choose to either return a value (default or otherwise) or cause substitution to fail by returning None.
All the other fill_with_* functions are reimplemented in terms of fill_with_function.

Thank you for the submission @jsgf, this is a really neat idea! Do you mind also updating the README with a short description of the new functionality? :)
I should be able to push a new version of the crate tonight or tomorrow. 🙏

OK I updated the readme, fixed doc comments (added examples in some cases) and also fixed the fill_with_struct* functions which I broke without noticing.

Thank you @jsgf! I will merge all of the pending PRs today and release a new version soon. I appreciate you taking time to improve the codebase and also document things. :)

Thank you @jsgf, version 0.5.0 is published. 🎉


chore(appveyor): Add initial config

There were the following issues with your Pull Request

Commit: 708c765f2c889a0458216a6dac0e19a984905a4a
Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html

This message was auto-generated by https://gitcop.com

Will do this, some day. But today is not the day.


Fix S3 Uploader when custom path is used

Proposed solution for #553
Added parameters unique_folder_name [which was occassionally being overwritten before] and dir_uuid to upload endpoint callback in Uploader.vue to identify the directory and unique identifier used for file location
Added logic in storeReference method of FileLibraryController and MediaLibraryController to handle new parameters and store only the unique portion of the uuid without custom root

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Nikolaus Stoltzfus seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

 All committers have signed the CLA.


Fields inside Row field can't be updated via UPDATE api and don't save in admin

This also don't create needed indexes in mongodb collection
Payload v. 1.0.7 - 1.0.24

It happens only when i define custom id field

I verified this is a bug.
This is the line causing the issue:
https://github.com/payloadcms/payload/blob/5825d7e64f234e8c644dc7962dbf1ca7a4a8ee64/src/mongoose/buildSchema.ts#L57
Because rows don't have a name, they are getting removed altogether from the schema when custom IDs are used.
The fix could be to change to this:
const idIndex = schemaFields.findIndex((field) => (fieldAffectsData(field) && field.name === 'id'));
schemaFields.splice(idIndex, 1);

Although, when I tried to do that and for some reason I had other issues preventing save on the collection with the error relating to the ID field.

Released! Thanks for catching this bug @383bd03d


can we have more than one listeners configured in redis proxy

*static_resources:
listeners:

name: redis_listener
address:
socket_address:
address: <IP_ADDRESS>
port_value: 1999
socket_address:
address: <IP_ADDRESS>
port_value: 1999

so here want to have 2 listeners with different ip and same port

You should be able to configure a listener with additional_addresses https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/listener/v3/listener.proto#envoy-v3-api-msg-config-listener-v3-listener


Protection screen full coverage countdown

Instead of "3 months left until full coverage" staying static for 3 months, let's do a countdown.
eg. 87d 23h 4m 12s - where the seconds is constantly dropping

Maybe put the counter on the progress bar and write the protection % below it?

already done


How can we build and test kmesh ebpf code locally.

Please provide an in-depth description of the question you have:
How can we build and test kmesh ebpf code locally? I am working on a Ubuntu-20.04.
What do you think about this question?:
Environment:

Kmesh version:
Others:

Good question. Currently, KMesh does not have a mature ebpf testing framework. Testing ebpf programs depends on functional black-box testing. In the roadmap for the second half of this year, we plan to develop an independent ebpf test framework for KMesh. The basic selection is based on the BPF_PROG_TEST_RUN command (this command was added to the kernel in kernel 4.12). Pay attention to the Kmesh community and participate in the regular community meeting to learn about the development progress.

For ebpf locally build, maybe u could firstly install Dependencies reference https://github.com/libbpf/libbpf-bootstrap?tab=readme-ov-file#install-dependencies
Then, you can build and load ebpf prog to kernel using below code, which I used to verify whether ebpf prog could load into kernel not long ago, which will print ebpf error msg when prog is not correct. Because Kmesh in printing BpfVerifyLog is very limited.
package bpf

import (
	"fmt"
	"os"
	"testing"

	"github.com/stretchr/testify/suite"
	"kmesh.net/kmesh/daemon/options"
)

type BpfTestSuite struct{
	suite.Suite
	l *BpfLoader
	config *options.BpfConfig
}

func TestBpfTestSuite(t *testing.T)  {
	suite.Run(t, new(BpfTestSuite))
}

func (suite *BpfTestSuite) SetupSuite () {
	err := os.Setenv("PKG_CONFIG_PATH", "/root/tmp/kmesh/mk")
	if err != nil {
		panic(err)
	}
	config := &options.BpfConfig{
		Mode: "ads",
		BpfFsPath: "/sys/fs/bpf",
		Cgroup2Path: "/mnt/kmesh_cgroup2",
		EnableMda: false,
		BpfVerifyLogSize: 100 * 1024 * 1024, // 1MB
	}
	suite.l = NewBpfLoader(config)
	suite.config = config
}

func (suite *BpfTestSuite) TearDownSuite()  {

	fmt.Println(">>> From TearDownSuite")
}

func (suite *BpfTestSuite) TestStartAdsMode()  {
	if err := suite.l.Start(suite.config); err != nil {
		fmt.Printf("bpf start err:%s", err)
	}

	defer suite.l.Stop()

}

https://kmesh.net/en/docs/developer/run-ut/
Is this doc helpful and resoved your question

yes, i can know how to run ut from it.
But there are many details that users cannot know directly from the document, unless they read the codes(like some build flag about enhanced kernel).
Now I am familiar with the whole framework, but it will take a little bit more time for the new beginner. The documents can be more detailed(like, how can we build the env from scratch, how to develop and deploy kmesh in kind). If needed, i can add some documents(like how to develop in kind).

https://kmesh.net/en/docs/developer/run-ut/
Is this doc helpful and resoved your question

yes, i can know how to run ut from it.
But there are many details that users cannot know directly from the document, unless they read the codes(like some build flag about enhanced kernel).
Now I am familiar with the whole framework, but it will take a little bit more time for the new beginner. The documents can be more detailed(like, how can we build the env from scratch, how to develop and deploy kmesh in kind). If needed, i can add some documents(like how to develop in kind).

We'd pleasure it if you could optimise the documentation!


[Feature] Disable Linting / Error checking

I'm currently using atom-ide in conjunction with ide-typescript, I would prefer to use the linter included in ide-typescript however I cannot disable the linter in this plugin resulting in my linter UI (Diagnostics pane of atom-ide) resulting in my linter warnings being shown twice, once from each plugin.
A simple checkbox on the settings page for this plugin to disable this feature would resolve this

Would really like to see this as well, as I prefer to just use the configurable tslint instead.
Also since updating to TypeScript 2.9 I'm seeing a bunch of warnings I'd like to ignore, but don't seem to have any way to.

A similar feature to the one requested here was implemented in ide-typescript, so now I disable linting from that package and use the linting from this one to solve the duplicated warnings: https://github.com/atom/ide-typescript/issues/55


Document x, y coordinates

It would be nice if one could document how the x and y coordinates are defined. (Beginners might not know about it and well the more documentation the better).
What I think when I see x and y:

What it actually is:

Relevant structs

tui::layout::Rect
tui::widgets::canvas::*

I agree the axis can be confusing. The main issue is that most the widgets use (x, y) for something that should actually be (col, row). The canvas uses Cartesian axis for the data though.
Is this something you would help clarify in the documentation ?

I am not sure if I am the correct person for this. I have absolutely no clue about this crate (never used it, just looked a bit through the docs).

Ok sure thing. Thanks for the report anyway. I've requalified the issue in the meantime.

Need terms and conditions

@stbor I think the best approach would be to have a different vocabulary for each coordinates system:

We should use the row and column denomination for everything that deals with the grid system we are using to represent the terminal (i.e all widgets rendering code).
We should use x, y when we are referring to a more traditional Cartesian coordinates system (i.e the abstraction Canvas is built on top of).
While this task should be easy as it should only be basic substitutions, it is probably big given the amount of code to change.


Please update llvm and python, add clangd support and graphical interface for python

Hello, I’ve been using the app for quite a while and feel it really convenient. Could you guys please sync the llvm to 16 stable and python to 3.11 for feature updates and performance improvements? Also I think auto completion is quite important as well, so probably the addition of clangd could help work that feature out. For python though, although Matplotlib is installed but without a graphical interface, so I would suggest to add a gui backend support for it, probably bundle pyqt6? I have no luck directly installing it via pip

https://github.com/holzschu/a-shell is at Python 3.11, so this can be done easily. For llvm and graphical interface, I'll need to further investigate.


Upgrading vueify from 9.0.0 to 9.3.0 breaks browserify template

https://github.com/vuejs-templates/browserify
17:28:42] Finished 'vueify' after 9.03 ms
...
    sourceMap: options._flags.debug
                             ^

TypeError: Cannot read property 'debug' of undefined

Gives the same error as per using gulp with latest version, #138, so it is a breaking change that seems not the fault of the other tool. Therefore fixing this will fix both of these issues.

This issue still seems to exist - a downgrade to 9.0.0 fixes this.

I have this issues as well, using the latest version.

Is 7a9c05d merged in latest release ? I still have the issue
+--<EMAIL_ADDRESS>| `--<EMAIL_ADDRESS>`--<EMAIL_ADDRESS>
Manually changing /vueify/index.js to match 7a9c05d fix the issue.


天津地图数据，缺失蓟州区

Version
4.2.1
Steps to reproduce
我查看了echarts的源码，发现地图数据中，天津蓟州区，coordinates坐标数据是空数组
What is expected?
提供完整的天津市地图数据
What is actually happening?
目前缺失整个蓟州区区

欢迎提供 PR

@umi-soft https://github.com/echarts-maps/echarts-china-cities-js
You can get map data from here.

I have not fixed the issue yet. It’s noted already.

It is under editing and will enter production soon. Stay tuned.
Here is how it looks:

@chfw Great job! Looking forward to your PR.

@ZxdNoob has done the PR already, so I let him go ahead and have left my comments.
I may add js version if @ZxdNoob does not provide one.

https://github.com/apache/incubator-echarts/pull/10489


[C-Api/Service] update ml-service pipeline

Update API name prefix - ml_service_pipeline.

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #469. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

:octocat: cibot: @jaeyun-jung, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/469-202403251501560.74957799911499-a358c5bb0e103df02c2b209c025fc8f7dca92422/.

:octocat: cibot: @jaeyun-jung, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nnstreamer-api/ci/repo-workers/pr-checker/469-202403251630330.45075488090515-9553070d313de8bf93cd3e155894d7b3c785d3d0/.

branch to tizen_8.0


Highligting of entire line is wrong in some cases

Consider
def test():
    alpha1 = 1
    alpha2 += 1

test()

Here is the result, which is clearly wrong as

it points to the same line for where the program stopped and the exception was raised
the indentation is highlighted.

Traceback (most recent call last):
  File "HOME:\github\friendly-traceback\ignore.py", line 5, in <module>
    test()
  File "HOME:\github\friendly-traceback\ignore.py", line 3, in test
    alpha2 += 1
UnboundLocalError: local variable 'alpha2' referenced before assignment

        Did you mean `alpha1`?

...

    Execution stopped on line 5 of file HOME:\github\friendly-traceback\ignore.py.

       1: def test():
       2:     alpha1 = 1
    -->3:     alpha2 += 1
          ^^^^^^^^^^^^^^^

    Exception raised on line 3 of file HOME:\github\friendly-traceback\ignore.py.

       1: def test():
       2:     alpha1 = 1
    -->3:     alpha2 += 1
          ^^^^^^^^^^^^^^^

Fixed one problem:
    Execution stopped on line 5 of file HOME:\github\friendly-traceback\ignore.py.

       1: def test():
       2:     alpha1 = 1
       3:     alpha2 += 1
       4:
    -->5: test()
          ^^^^^^

            test:  <function test>

    Exception raised on line 3 of file HOME:\github\friendly-traceback\ignore.py.

       1: def test():
       2:     alpha1 = 1
    -->3:     alpha2 += 1
          ^^^^^^^^^^^^^^^

Fixed the other, even with comment present:
    Execution stopped on line 5 of file HOME:\github\friendly-traceback\ignore.py.

       1: def test():
       2:     alpha1 = 1
       3:     alpha2 += 1 # comment
       4:
    -->5: test()
          ^^^^^^

            test:  <function test>

    Exception raised on line 3 of file HOME:\github\friendly-traceback\ignore.py.

       1: def test():
       2:     alpha1 = 1
    -->3:     alpha2 += 1 # comment
              ^^^^^^^^^^^


Where'd you go??

Did I do something wrong?


Replace the PDBe URLs by using HTTPS by default

This should fix the PDBe viewer issue when using Ensembl with the HTTP protocol.

Thanks for this Laurent, its all merged and push to the live server. Probably your last web PR :(
Thanks for all your PR/fix over the time.  👍

Thanks @ens-ma7!
Just tested it on the live website and it works!


Error running 2.16.0 in docker compose

I'm getting
ERROR: readlink /var/lib/docker/overlay2/l: invalid argument

When I'm using latest (2.16.0) from docker compose. I reverted to 2.15.0 and this seems to have resolved the issue.
I'm using Arch Linux and Docker version 18.03.0-ce, build 0520e24302
Thanks

Could you provide a docker-compose file so that I can reproduce ?


Installation for all users?

Is there any hints / howto on how to install this for all users?
I would get that the source should exist in /etc/profile.d/something
Then install under /usr/local? or /opt?

Yep your right, PureLine should have a proper installation method. I'm going to try and commit a bit more time to the project and aim for a feature freeze and stable release. Then it should easier to work on distro packages to install system wide.

I've just tried this - with not very much success.
    # source external segments
    local segment_dir
    segment_dir=$(dirname "${BASH_SOURCE[0]}")'/segments'

Sourcing /opt/pureline/pureline fails to load the segments, since ${BASH_SOURCE[0]} points to /etc/profile.d/pureline.sh.
Is there a better way?
(Instead of sourcing 2 files, I just source pureline in the profile script and directly add the configuration content afterwards.)


Error when using bundle-stats v4.14.0

The changes in bundle-stats v4.14.0 that let you identify what chunks a module belongs to looks super useful.
However the stats file produced by rollup-plugin-webpack-stats v1.0.2 causes a runtime error when clicking a module in the modules tab.
bundle-stats.html:2 Uncaught (in promise) TypeError: Cannot read properties of null (reading 'size')
    at Cs (bundle-stats.html:2:311443)

The UI seems to be unable to recover from this error, and I am no longer able to click into other tabs.
I suspect size, and probably other pieces of information that were previously not required by bundle-stats, are now required, and as this package doesn't aim to produce a complete stats file, only including what bundle-stats needs, it hasn't been updated yet to include those new required data keys.
Reproduction steps

Run a Vite build that has been configured to use rollup-plugin-webpack-stats v1.0.2. (the repo I'm using is private so I don't want to post the generated stats file publicly, but I suspect any vite build would work).
Pass the generated stats file into bundle-stats v4.14.0
Open up the html report, click the modules tab, then click on a module in the table. See the error above appear in the console.

Was able to replicate the issue for cases when the report has no baseline, that's a case we are not testing automatically.
If you get the chance, can you please try v4.14.1-beta.0 ?

@BPScott thank you for checking! The fix is now available on v4.14.1.

As an aside/polish idea: It feels a little odd to show size change information when looking at a single build. I'd be tempted to consider removing the +2.91KiB / +100% red diff text when there is no baseline.

Indeed, we do not know if the baseline value is missing or just empty, will handle it here: https://github.com/relative-ci/bundle-stats/issues/4639. Thank you for the feedback!


New job submission page doc

Add How To Use New Submission page doc of new job submission page

Coverage remained the same at 33.818% when pulling a785e4be48ef38dd43cb5e4fab90d6ea3c0fef3c on Morningssir:new_job_submission_page_doc into f9d98be176135b1d6de89ecfae1727e99f57c2cc on microsoft:master.


Strongly Connected Component (SCC) Scheduled Nonlinear Problems

https://link.springer.com/book/10.1007/0-387-30260-3 Chapter 7
https://escholarship.org/content/qt80t380tv/qt80t380tv_noSplash_18a25fa49e487cb213e64ecee5b003fb.pdf?t=li54ql
https://apps.dtic.mil/sti/tr/pdf/ADA317005.pdf

The idea is that instead of solving one giant Newton method, you can instead split it up into successive Newton solves that are then recursed based on the strongly connected components.

The algorithms of ModelingToolkit are already able to put the system in BLT form and do the tearing process to reduce the systems. I think as a general nonlinear solver, it would be good to, instead of baking this into MTK in some form, have a way to be able to express such structural systems with NonlinearSolve.jl and have MTK generate code to that interface.
I could see this happening in a few forms:

We could do this on split vectors.
We could do this by passing extra structural information for scheduling.

SCCNonlinearFunction((f1,f2,f3), jac = (J1,J2,J3)) would be needed for both. But the question is do you make u0 = [a1,a2,a3] where each a[i] is an array for the SCC[i], or do you make this segmented?
Effectively the question is as follows. If you do this in the segmented way, then f1(resid, a1, p), f2(resid, a1, a2, p), f3(resid, a1, a2, a3, p) is the target, i.e. each has more arguments as you go along. I could see this having some compilation difficulties, so you could just do this as fi(resid,u,p) where u is an array-of-arrays.
Or, at that point, you could just give the whole u array but with a known structure used by the solver that is not enforced in the definition of fi. For this interface, you would still have to give split scheduled functions SCCNonlinearFunction((f1,f2,f3), jac = (J1,J2,J3)), but with sizes of resid being chosen to match the size of the current nonlinear system. You could just create one resid with the maximum size of the strongly connected components, and then just use views of that in each such component. Thus SCCNonlinearProblem(f,u0, lengths, p) would just need to know the length of each SCC, and then schedule the algorithm into the cascading functions from there. This would probably need to impose an AbstractVector structure on u0, whereas the split form would be easier for handling more array types.
The split form could be nicely handled by keeping the cache of arrays of arrays but having a mapping method to_arrarr!(a,u0) that takes a flattened version of the vector into the SCC split structure. So I don't think it would necessarily have more allocations beyond the setup phase.
So of the ways to represent this, I think I'd rank:

Array of arrays fi(resid,u,p)
Flattened fi(resid,u,p) with sizes
f1(resid, a1, p), f2(resid, a1, a2, p), f3(resid, a1, a2, a3, p)

With the last one effectively eliminated for compile time concerns. I like that the first enforces that the BLT form is respected, to an extent. Someone could still modify u, but that's always a concern 😅.

A good case to test this on would be the double pendulum https://sciml.github.io/ModelingToolkitCourse/dev/lectures/lecture8/#Bonus-Demo

I like ∀i, fi(resid, u::Vector{<:StateVector}, p) where u[1] is the actual state vector that the solver needs to solve, too. Each u[i] is naturally contiguous from BLT ordering for equations, while the concatenation of u is not contiguous in general, so that rules out Flattened fi(resid, u, p) with sizes.

using NonlinearSolve, ForwardDiff, FunctionWrappersWrappers, ArrayInterface

dualgen(::Type{T}) where {T} = ForwardDiff.Dual{ForwardDiff.Tag{SciMLTag, T}, T, 2}
struct SciMLTag end

function wrapfun_iip(_ff,
        inputs::Tuple{T1, T2}) where {T1, T2, T3}
	ff = SciMLBase.Void(_ff)
    T = eltype(T1)
    dualT = dualgen(T)
    dualT1 = ArrayInterface.promote_eltype(T1, dualT)

    iip_arglists = (Tuple{T1, T1, T2},
        Tuple{dualT1, dualT1, T2})

    iip_returnlists = ntuple(x -> Nothing, 2)

    fwt = map(iip_arglists, iip_returnlists) do A, R
        FunctionWrappersWrappers.FunctionWrappers.FunctionWrapper{R, A}(SciMLBase.Void(ff))
    end
    FunctionWrappersWrappers.FunctionWrappersWrapper{typeof(fwt), false}(fwt)
end

function f(du,u,p)
	du[1] = cos(u[2]) - u[1]
	du[2] = sin(u[1] + u[2]) + u[2]
	du[3] = 2u[4] + u[3] + 1.0
	du[4] = u[5]^2 + u[4]
	du[5] = u[3]^2 + u[5]
	du[6] = u[1] + u[2] + u[3] + u[4] + u[5]    + 2.0u[6] + 2.5u[7] + 1.5u[8]
	du[7] = u[1] + u[2] + u[3] + 2.0u[4] + u[5] + 4.0u[6] - 1.5u[7] + 1.5u[8]
	du[8] = u[1] + 2.0u[2] + 3.0u[3] + 5.0u[4] + 6.0u[5] + u[6] - u[7] - u[8]
end
prob = NonlinearProblem(f, zeros(8))
sol = solve(prob)

u0 = zeros(2)
p = (zeros(0), nothing)
function f1(du,u,(cache,p))
	du[1] = cos(u[2]) - u[1]
	du[2] = sin(u[1] + u[2]) + u[2]
end
prob1 = NonlinearProblem(NonlinearFunction{true}(wrapfun_iip(f1, (u0, p))), zeros(2),(zeros(0),nothing))
sol1 = solve(prob1, NewtonRaphson(autodiff=AutoFiniteDiff()))

function f2(du,u,(cache,p))
	du[1] = 2u[2] + u[1] + 1.0
	du[2] = u[3]^2 + u[2]
	du[3] = u[1]^2 + u[3]
end
prob2 = NonlinearProblem(NonlinearFunction{true}(wrapfun_iip(f2, (u0, p))), zeros(3),(zeros(2),nothing))
sol2 = solve(prob2, NewtonRaphson(autodiff=AutoFiniteDiff()))

function f3(du,u,(uprev,p))
	du[1] = uprev[1] + uprev[2] + uprev[3] + uprev[4] + uprev[5]             + 2.0u[1] + 2.5u[2] + 1.5u[3]
	du[2] = uprev[1] + uprev[2] + uprev[3] + 2.0uprev[4] + uprev[5]          + 4.0u[1] - 1.5u[2] + 1.5u[3]
	du[3] = uprev[1] + 2.0uprev[2] + 3.0uprev[3] + 5.0uprev[4] + 6.0uprev[5] + u[1] - u[2] - u[3]
end
prob3 = NonlinearProblem(NonlinearFunction{true}(wrapfun_iip(f3, (u0, p))), zeros(3),(zeros(3),nothing))
sol3 = solve(prob3, NewtonRaphson(autodiff=AutoFiniteDiff()))

function SciMLBase.solve(prob::SciMLBase.SCCNonlinearProblem, alg; kwargs...)
	numscc = length(prob.probs)
	sols = Vector{SciMLBase.NonlinearSolution}(undef,numscc)
	cache = prob.allocate_cache(prob)
	for i in 1:numscc
		uprev = reduce(vcat,sols[1:i-1],init=eltype(eltype(prob.probs[i].u0))[])
		prob.probs[i].p[1] .= uprev
		prob.probs[i].p[2] = cache
		explictfun![i](cache,sols[1:i-1])
		sols[i] = solve(prob.probs[i], alg)
	end
	prob.free_cache(cache)
	SciMLBase.build_solution(prob, alg, reduce(vcat,sols), reduce(vcat,getproperty.(sols,:resid)),
							 original = sols)
end

allocate_cache(prob) = zeros(3)
sccprob = SCCNonlinearProblem((prob1,prob2,prob3))

scc_sol = solve(sccprob, NewtonRaphson(autodiff=AutoFiniteDiff()))
sol ≈ scc_sol

The function wrappers are rough but we can specialize differently.


update mypy and package version

Seems to be present in the manifest - very frustrating https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json


FEDX-414 Add APIs and update deprecations in preparation for 7.0.0 release

Motivation
react-dart 7.0.0 will contains some breaking changes to APIs that are not yet deprecated in the 6.x line.
The 7.0.0 WIP branch also relies some API additions that aren't present in 6.x, so we'll want to backport them to ensure consumers can transition to these new APIs before setting their lower bounds to 7.0.0.
Solution

Deprecate APIs to be removed in 7.0.0
Update existing outdated deprecations for APIs that say they'll be removed in 7.0.0, but won't yet be removed

These were mostly Component and its associated APIs, which we don't have a timeline for removing

Backport APIs htmlMain and useRefInit
Add draft changelog entry for 7.0.0.

I had this written up but not committed anywhere, and figured I'd add it now to help provide context during review of this PR. We can refine this entry later as part of the PRs for the 7.0.0 changes.

QA steps

Verify CI passes

Security Insights
No security relevant content was detected by automated scans.
Action Items

Review PR for security impact; comment "security review required" if needed or unsure
Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@Workiva/release-management-p


Proxy options are ignored

How to use proxy host / port option s? Usage of the SoapClient proxy_host and proxy_port options is ignored.
Is it possible to specify with something else ?
Can this option be handled by the ParallelSoapClient class ?

Hey @pdoreau Thank you for opening an issue. would you be able to give a code example of the issue?


guava version

hello,when i run java client ,i found this
java.lang.NoClassDefFoundError: com/google/common/base/MoreObjects
at io.grpc.internal.AbstractManagedChannelImplBuilder.build(AbstractManagedChannelImplBuilder.java:257)
at io.grpc.internal.AbstractManagedChannelImplBuilder.build(AbstractManagedChannelImplBuilder.java:69)
and i did not find MoreObjects in guava14.0,so should i download guava 19.0?i downloaded a guava19.0,but somtimes it tried to find MoreObjects in 14.0.what should i do ?thank you ~~~

Nice work @joyJZhang
But I think all the dependencies have been add in pom.xml and users don't need to configure anything for compiling and running with maven. What's the problem about guava and should we add more instruction about this?

I checked again，found that your project is complete。It is my fault. I add    in pom.xml , has guava14，and yours has 19，they clash.when i invoke  a method ,it always try to find in 14~~

Great and thanks for your feedback 😃


Unknown field 'doczDb' on type 'Query'

Bug Report
I keep getting this error when installing the Gatsby theme:
 ERROR #85907  GRAPHQL

There was an error in your GraphQL query:

- Unknown field 'doczDb' on type 'Query'.

File: node_modules/gatsby-theme-docz/src/hooks/useDbQuery.js

Environment
System:
OS: macOS 10.14.5
CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.4.1 - /usr/local/bin/node
Yarn: 1.7.0 - /usr/local/bin/yarn
npm: 6.10.2 - /usr/local/bin/npm
Languages:
Python: 2.7.15 - /usr/local/bin/python
Browsers:
Chrome: 75.0.3770.142
Firefox: 68.0
Safari: 12.1.1
npmPackages:
gatsby: ^2.13.52 => 2.13.52
gatsby-theme-docz: ^2.0.0-rc.1 => 2.0.0-rc.1
npmGlobalPackages:
gatsby-cli: 2.7.20

I get this bug too, still cannot figure out how to fix it.

The same here!

Same here. Any luck on fixing this?

Seems like my problem was with my node version, I updated to the latest version (v12.8.0) and now is working for me.

I'm getting the same problem.  Upgrading node didn't fix it.

I found this error went away when I removed gatsby-config.js which I was using to load the gatsby sass plugin.
module.exports = {
  plugins: ['gatsby-plugin-sass']
}

After that, I could never get any combination of loaders ('css-loader', 'postcss-loader', 'sass-loader',...) to work.  I was getting all sorts of errors loading gatsby-docz-theme.  (eg: "unknown word") as well as trying to load my scss files.
I finally ditched all that and just ran sass cli to transform my stylesheets and removed sass-loader from my webpack config.  That worked and I finally got docz to build!!!

On a side-note it looked awful.  It appears my bulma styles were conflicting with docz styles.
Show source was unreadable.  But, this is all another issue.  I've since gone back to docz 1.

Could you please provide the rest of the command output ? There might be another clue there into what's happening

Facing the same issue, the thing I have common with @dusty is that I tried adding a custom gatsby plugin in a file in /gatsby-config.js
module.exports = {
  plugins: [{ resolve: `gatsby-plugin-material-ui` }],
}

Docz ended up generating the following gatsby-config.js file in .docz folder with gatsby-config.custom.js having my plugin code

const { merge } = require('lodash/fp')

let custom
try {
  custom = require('./gatsby-config.custom')
} catch (err) {
  custom = {}
}

const config = {
  siteMetadata: {
    title: 'Edgepro Ui',
    description: 'My awesome app using docz',
  },
  plugins: [
    {
      resolve: 'gatsby-theme-docz',
      options: {
        themeConfig: {},
        docgenConfig: {},
        menu: [],
        mdPlugins: [],
        hastPlugins: [],
        ignore: [],
        typescript: false,
        ts: false,
        propsParser: true,
        'props-parser': true,
        debug: false,
        native: false,
        openBrowser: false,
        o: false,
        open: false,
        'open-browser': false,
        root: 'C:\\Users\\rravindran\\metocean\\epWEB\\.docz',
        base: '/',
        source: './',
        src: './',
        files: './src/**/*.mdx',
        public: '/public',
        dest: '.docz/dist',
        d: '.docz/dist',
        editBranch: 'master',
        eb: 'master',
        'edit-branch': 'master',
        config: '',
        title: 'Edgepro Ui',
        description: 'My awesome app using docz',
        host: 'localhost',
        port: 3002,
        p: 3000,
        separator: '-',
        paths: {
          root: 'C:\\Users\\rravindran\\metocean\\epWEB',
          templates:
            'C:\\Users\\rravindran\\metocean\\epWEB\\node_modules\\docz-core\\dist\\templates',
          packageJson: 'C:\\Users\\rravindran\\metocean\\epWEB\\package.json',
          docz: 'C:\\Users\\rravindran\\metocean\\epWEB\\.docz',
          cache: 'C:\\Users\\rravindran\\metocean\\epWEB\\.docz\\.cache',
          app: 'C:\\Users\\rravindran\\metocean\\epWEB\\.docz\\app',
          appPublic: 'C:\\Users\\rravindran\\metocean\\epWEB\\.docz\\public',
          appNodeModules:
            'C:\\Users\\rravindran\\metocean\\epWEB\\node_modules',
          appPackageJson:
            'C:\\Users\\rravindran\\metocean\\epWEB\\package.json',
          appYarnLock:
            'C:\\Users\\rravindran\\metocean\\epWEB\\node_modules\\docz-core\\yarn.lock',
          ownNodeModules:
            'C:\\Users\\rravindran\\metocean\\epWEB\\node_modules\\docz-core\\node_modules',
          gatsbyConfig:
            'C:\\Users\\rravindran\\metocean\\epWEB\\gatsby-config.js',
          gatsbyBrowser:
            'C:\\Users\\rravindran\\metocean\\epWEB\\gatsby-browser.js',
          gatsbyNode: 'C:\\Users\\rravindran\\metocean\\epWEB\\gatsby-node.js',
          gatsbySSR: 'C:\\Users\\rravindran\\metocean\\epWEB\\gatsby-ssr.js',
          importsJs:
            'C:\\Users\\rravindran\\metocean\\epWEB\\.docz\\app\\imports.js',
          rootJs:
            'C:\\Users\\rravindran\\metocean\\epWEB\\.docz\\app\\root.jsx',
          indexJs:
            'C:\\Users\\rravindran\\metocean\\epWEB\\.docz\\app\\index.jsx',
          indexHtml:
            'C:\\Users\\rravindran\\metocean\\epWEB\\.docz\\app\\index.html',
          db: 'C:\\Users\\rravindran\\metocean\\epWEB\\.docz\\app\\db.json',
        },
      },
    },
  ],
}

module.exports = merge(config, custom)

I dont know much about lodash fp but the merge function apparently doesnt seem to merge array properties. It just overwrites the property value with the newest value
so
const merger = _.merge( {plugins:[{ id: 1 }]}, { plugins:[{ id:2 }]});
// returns {plugins: [{id:2}]} instead of both elements

Hence your plugin configuration for gatsby-theme-docz must be getting lost as soon as we add our own plugins as
module.exports = merge(config, custom)

Hey @rahulrmetocean
I think you're right, yours and @dusty's problem are from a problem with merging the plugins field in the gatsby config files.
Going to open a separate issue to track that problem.
For future readers who encounter this, make sure to  :

update docz to latest version
delete your node_modules folder
delete the .docz folder
yarn install && yarn docz dev
If you still get the error, delete your yarn.lock file and go to step 2
Still doesn't work ? Open an issue so we can help debug the problem.

I still ran into this when having gatsby-theme-docz as dependency but not using it.
My setup does not render the docs on production, but in all other cases.
My workaround is to create the missing db docz entry. This at least let me build the website. It is not fixing the actual issue at all.
Thats my gatsby-node.js:
/**
 * This whole file is a workaround to prevent docz from failing when the
 * dependency is installed but gatsby-theme-docz is excluded in the gatsby-config.js
 *
 * Maybe related: https://github.com/doczjs/docz/issues/994
 */
const crypto = require('crypto')

const digest = (str) =>
  crypto
    .createHash('md5')
    .update(str)
    .digest('hex')

const isProduction = process.env.NODE_ENV === 'production'
const isStaging = !!process.env.STAGING

const renderDocs = isStaging || !isProduction

/**
 * If the docs are not rendered, create a fake db entry to prevent the parser for
 * useStaticQuery from failing via
 *
 *  ERROR #85901  GRAPHQL
 *
 *  There was an error in your GraphQL query:
 *
 *  Cannot query field "doczDb" on type "Query".
 *
 *  GraphQL request:3:9
 *  2 |       query {
 *  3 |         doczDb {
 *    |         ^
 *  4 |           id
 *
 *  File: node_modules/gatsby-theme-docz/src/hooks/useDbQuery.js:7:9
 */
exports.sourceNodes = ({ actions, createNodeId }, { forceDocs = false }) => {
  if (forceDocs || renderDocs) {
    console.log('skipping')
    return
  }

  console.log('faking docs db')

  const { createNode } = actions
  const db = JSON.stringify({})
  const contentDigest = digest(db)

  const node = {
    id: createNodeId('docz-db'),
    db,
    children: [],
    internal: {
      contentDigest,
      type: 'DoczDb',
    },
  }

  createNode(node)
}

I still ran into this when having gatsby-theme-docz as dependency but not using it.

I'm sorry I'm not sure I understand what you mean by this. You've installed the dependency but didn't include as a gatsby plugin in your configuration ?
Any chance the project you're working on is open-source so I can take a look ?

@rakannimer

You've installed the dependency but didn't include as a gatsby plugin in your configuration ?

Exactly. As docz adds dependencies and increases the bundle size even for pages outside of the / route, I don't include gatsby-theme-docz when building on my productio instance. On staging I have the docs generated for the team.

Any chance the project you're working on is open-source so I can take a look ?

Its very WIP and currently only works with the contentful starter. I am working on it currently on a daily basis and will polish both starters very soon.
https://github.com/axe312ger/gatsby-mdx-suite

For anyone still struggling with this issue, I fixed it on my end by replacing this line:
// doczrc.js
ignore: "README.md",

with this one:
// doczrc.js
ignore: ["README.md"],

For me, this resolved when I downgraded gatsby from 3.* to 2.*
Some of the gatsby-plugins docz uses had compatibility issues.
An alternative which might be worth exploring instead would be to install updated versions of the plugins.
Hope this helps. Love this effin tool.

i spend a lot time to reslove this problem,  first t think is my node or ts version promble, and i try many methods but it's not work, and finaly i find the promble is in the package.json repository field, i remove that field adn it's work, i dont now why????

@ tiyunchen
thank you for your reply to solve my problem

i spend a lot time to reslove this problem, first t think is my node or ts version promble, and i try many methods but it's not work, and finaly i find the promble is in the package.json repository field, i remove that field adn it's work, i dont now why????

@ tiyunchen
thank you for your reply to solve my problem

@hellcoldby try to use the latest bumped version of docz (2.3.3-alpha.0) to see if it still happens


[PE-D][Tester D] grade command parameters does not correspond with the UG.

grade command parameters does not correspond with the UG.
To reproduce:

Do grade 0 s/2 m/1

Expected behavior:
From UG, parameters should be INDEX [m/MODULE s/GRADE]
Actual behavior:
Parameters from error response are: INDEX m/MODULE s/GRADE without it being optional.

Labels: severity.Low type.FunctionalityBug
original: yizhong187/ped#9

This is not a valid bug since index should start with 1


Alphabetize entries inside groups

It's annoying how entries aren't forced into alphabetization in Xcode like they are on the file system. There is a 'sort by name' option if you right click on a folder -- it'd be cool to automatically do this.

+1 !

+1

I had mentioned this with @marklarr on twitter, but it would be great to get an option to not alphabetize with synx (or have alphabetizing as a flag to enable).
Having this will just be a little difficult with a team and longstanding project. Running it will reorganize a lot of the project file, which may cause issues and not everyone on my team is going to run synx (and surely won't alphabetize the files).
Synx works really well for me because I can organize my Xcode group however I want, and it will organize the file system which I never really wanted to manually touch. But forcing alphabetization doesn't follow this same pattern.

Please make sorting optional and switched off by default! Folder structure is one thing, but logical project organization is sacred for many of us.
P.S. Ideally you should have different options for groups and files.

I asked around to the team at work, because I wanted to verify that it was a safe assumption that users of Synx would be a fan of Xcode mirroring the file system as closely as possible, but apparently we all assumed incorrectly :laughing:. Sorry to anyone that this has gotten in the way of -- the good news is, you can lock-in to synx v0.0.51 until I can rollout a flag for this. Honestly, unless the community as a whole feels strongly otherwise, I'd like to keep the flag on by default.

You mean v0.0.61, right?
As for the flag... For me synx is a great tool that takes my project's logical structure and tries to mimic it on the disk as closely as possible. I don't expect it to alter the project itself. Another consideration is backward compatibility. You are adding a feature that changes default behaviour and that's not a good thing for existing users. So my vote is: "It's good to have this feature, but it should be off by default." But of course the tool is in 0.1.x stage, so for the long term vision "default on" might make more sense.

Yes sorry, v 0.0.61, thanks for catching that.
Synx already alters the project itself -- you'll notice that, after running Synx on a disorganized project, the .pbxproj will have a lot of diff. As for backwards compatibility, people can just shut the flag off :smile:

I don't want to be closer to the disk, I want the disk to be closer to me (logical structure of the project). But anyways it's a great tool and I can live with "default on".

Yeah I agree with @FiRiN59 , but I won't complain as it's a great tool that you've made for free :P I appreciate you considering adding a flag to not alphabetize

I agree with @ScottRobbins & @FiRiN59, having a flag that turns off Alphabetizing would be awesome. Having my project order restructured is not fun

@AndrewSB @FiRiN59 @marklarr @eytanbiala @foobra Done :)

@rafalwojcik Great job, thank you! I've been silently waiting for this feature for so long.

@rafalwojcik Made my morning 😊

@rafalwojcik Amazing, thx!

This is a tad nitpicky, but the sort order is different from what XCode does when "Sort By Name".
I believe the sort order is case insensitive in XCode, space/symbol before alphanumeric; just a couple inconsistencies that I have noticed.

Very late, but @rafalwojcik You're a wonderful person.


fixed a typo on the contribution file name

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


x/crypto/ssh/terminal: MakeRaw returns incorrect state on Windows

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?
go version go1.5.1 windows/amd64

What operating system and processor architecture are you using (go env)?
GOOS=windows
GOARCH=amd64

What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

When using golang.org/x/crypto/ssh/terminal the MakeRaw function for Windows modifies the state before returning it, despite the intent being to return the original state so that it can be restored.
http://play.golang.org/p/hc1ssZfv_o

What did you expect to see?
Success

What did you see instead?
FAILURE
panic: Expected &{423} to equal ${416} but it does not!

Change-Id: I8e0b87229b7577544e1118fa4b95664d3a9cf5da


Log channel does not work from Tinker

I was trying to figure out if my Sentry log channel was working today, and just wanted to test it real quick in tinker, but nothing was ever logged. It was first when I put it in application code and went to a test URL that it actually ended up in Sentry.
Is there some sort of limitation to the log channel handler that it won't run from console commands? Any way of bypassing this?
Edit: my channel config:
(...)
        'sentry' => [
            'driver' => 'sentry',
            'level' => 'debug',
        ],
(...)

And I tried running Log::channel('sentry')->critical('Foo');

Hey @carestad maybe you already figure it out after you exited Tinker (with exit not with ctrl+c), but the events will only send after ending the execution ends.
I explained it in a bit more detail here (including a "manual" force send): https://github.com/getsentry/sentry-laravel/issues/250#issuecomment-508425057

Ah, of course. That would make sense though. But I always quit Tinker with CTRL+C so this never triggered when I tested it.
Tested it now and it seems to work when quitting with exit or by running \Sentry\Laravel\Integration::flushEvents(); after Log::channel('sentry')->critical('Foo').
I'll just close this then.


Certora tests/feature/v2.0.0

Task: Certora setup + simple tests
High Level Description
Tests the following:

For a set collateral asset dust, the amount should be higher than zero ✅
For any product hash, the array of time to expiries productTimeToExpiry should always be in ascending order ✅
For any product hash, any new time to expiry stored in the array of expiries productTimeToExpiry should always have a value timeToExpiryValue ✅
Time to expiry value should always be greater than zero ✅

I see Certora failing here, plus this PR #385 probably will affect this.

Any updates here @aparnakr ?

Closing this for now.


add configurable volume types

Agents can mount volumes by volume type.

duplicates #981

@berndtj really appreciate the contribution but I'm going to close this in favour of #981


[WIP] Add ReactiveUI.Fody package

this PR is blocked by https://github.com/reactiveui/ReactiveUI/issues/1746


rfcbot should actually trigger FCPs, update comment text

@aturon, https://github.com/dikaiosune/rust-dashboard/issues/61#issuecomment-251500071:

Quick question/request: when the bot posts comments like rust-lang/rfcs#1682 (comment), AFAICT it's "going into FCP" in its own head (in that, according to the docs, it'll post a follow-up comment one week later). One problem is, it's not actually flagging the RFC as final-comment-period, and the comment it leaves is a little unclear.

After discussion with @nikomatsakis, we feel comfortable with the bot fully triggering FCP, given our experience so far. That would mean:

Tagging the issue as final-comment-period
Posting a very clear comment saying: "This RFC is now entering its final comment period, as per the review above", with a link back to the original checklist.

A couple other details:

The bot should post another comment, "The final comment period is now complete." after one "business week" has passed since going into FCP. Actually merging the RFC requires human intervention, since we want to review intervening comments.
...

Yes, it's "going into FCP" in its head. I didn't want the text to be too authoritative while we're trying it out, but I can definitely update that.
Tagging as final-comment-period is a little tricky, because I believe there are some permissions that need to be set up on any applicable repos. I can write the code such that it will fail gracefully if the tagging isn't permitted (allowing it to still work smoothly on non-permitted repos)?
How is a business week defined here? I'm just doing 7 days right now, which means that excepting three-day weekends there should always be 5 business days between FCP start and end.

So the "business week" thing was mostly thinking about "This Week in Rust", which is where a lot of people find out about FCP. That usually goes out on Monday, sometimes Tuesday.
I think what I'm asking for is that FCP last until the nearest Sunday that is at least one week away... but that's a bit complex.
Probably a simpler approach would just be to say FCP lasts for 10 days, or something like that.

Gotcha. 10 days is totally doable -- and makes a lot more sense once I have time to generalize the dashboard. That should be a quick change to make.

Regarding tagging/permissions: I think this is worthwhile. We've had cases where we've forgotten to tag an RFC and thus delayed action by more than a week. Automating as much as we can is great.
If the tagging fails, it'd be great if the bot's comment can say something like "I was unable to tag final-comment-period; please do so". That'll also alert us to the repos where we need to set up these permissions.

Yes, failing gracefully-but-not-silently sounds great.

Applying the final-comment-period label is a high priority item.

@aturon this is pretty much ready to try out, but I haven't yet finished setting up the optional & variable-length FCPs. Which means that PRs which shouldn't have an FCP will still have the label applied. Should I wait to deploy this change until the command structure is built out?

Yay! I think we should go forward with this change -- better to get extra
final-comment-period labels than not enough, IMO.
Thanks!
On Mon, Oct 24, 2016 at 11:29 PM, Adam Perry<EMAIL_ADDRESS>wrote:

@aturon https://github.com/aturon this is pretty much ready to try out,
but I haven't yet finished setting up the optional & variable-length FCPs.
Which means that PRs which shouldn't have an FCP will still have the label
applied. Should I wait to deploy this change until the command structure is
built out?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dikaiosune/rust-dashboard/issues/86#issuecomment-255948366,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AArUr7dJFUJC9WS1tb20Guo41hC5jZJkks5q3aHSgaJpZM4KQsAF
.

This has been deployed, I'll keep an eye out for any breakage.


Chapter 7- issue in loading pre trained model

While following the textbook and the steps on Github on the cell counting task, when I run
model.restore()
it throws the following error:
INFO:tensorflow:Restoring parameters from model/model-7700
and
NotFoundError: Restoring from checkpoint failed. This is most likely due to a Variable name or other graph key that is missing from the checkpoint. Please ensure that you have not altered the graph expected based on the checkpoint. Original error:
2 root error(s) found.
(0) Not found: Key Conv2D_3/conv2d_4/bias not found in checkpoint
[[node save_3/RestoreV2 (defined at /tensorflow-1.15.2/python3.6/tensorflow_core/python/framework/ops.py:1748) ]]
(1) Not found: Key Conv2D_3/conv2d_4/bias not found in checkpoint
[[node save_3/RestoreV2 (defined at /tensorflow-1.15.2/python3.6/tensorflow_core/python/framework/ops.py:1748) ]]
[[save_3/RestoreV2/_101]]
0 successful operations.
0 derived errors ignored.

Hmm, I think we've updated the Github code to TF 2.2 (CC @peastman) and the latest DeepChem HEAD. Could you try rerunning this code on the latest DeepChem/TF 2.2 (pip install --pre deepchem)

Was that loading the pretrained model?  I don't think it will work with the current DeepChem release.  As part of releasing DeepChem 2.4, we should create new versions of the pretrained models for the book.

+1 to creating new versions of pretrained models!


Restore stencil params after mask stack swap

Fixes #5981
Broken: https://www.pixiplayground.com/#/edit/PmNR2aqebJB2i56E5IiBz
Fixed: https://www.pixiplayground.com/#/edit/t09LhS3_ttR6R7przuBOi

Codecov Report

Merging #5982 into dev will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             dev    #5982      +/-   ##
=========================================
- Coverage   70.4%   70.38%   -0.03%
=========================================
  Files        208      208
  Lines      10505    10534      +29
=========================================
+ Hits        7396     7414      +18
- Misses      3109     3120      +11

Impacted Files
Coverage Δ

packages/core/src/mask/StencilSystem.js
30% <0%> (-0.62%)
:arrow_down:

...ckages/core/src/renderTexture/RenderTexturePool.js
51.16% <0%> (+6.33%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9664362...24a2c88. Read the comment docs.

@bigtimebuddy its not fully fixed - look #5974

@ivanpopelyshev, I think you made a typo, this should fix issue #5974, but you wrote that it fixes #5981.

And now its truly fixed.

@bigtimebuddy wanna make v4 PR for that too?


a question about dynamic queries

hello again 👋
in my application a feature would be to allow the user to sort the results of a search by some or multiple columns. eg
create table screenshots (
   id        serial      primary key,
   timestamp timestamptz not null,
   width     int         not null
);

the user may like to search screenshots by timestamp ascending, width descending, or whatever other column
as far as I know with postgres, it is not possible to make a prepared query for the order by clause
eg ORDER BY $1
https://www.postgresql-archive.org/ORDER-BY-in-prepared-statements-td5834944.html
and so since we have no idea of a query builder etc here, one idea might be to do
-- name: SearchScreenshots :many
select
  *
from
  screenshots
order by
  case when pggen.arg('timestamp_asc')  then timestamp end asc,
  case when pggen.arg('timestamp_desc') then timestamp end desc,
  case when pggen.arg('width_asc')      then width end asc,
  case when pggen.arg('width_desc')     then width end desc;

to pass a bunch of bools to the generated query and switch case inside of it ( though this performance of doing this might not be great - but not sure )
so my question is, what would you do in this situation?
perhaps there is a better trick? or a change to pggen?
thanks!

For the short term, the easiest option is to use 2 separate queries, one for each column. SQL has pretty limited abstractions for dealing with idents. Then use an if-statement in Go to choose which query to run.
Alternately, you can use pl/pgsql to create a function that takes a string you use to format as an ident in a query.
Long term, I want to add something like pggen.ident to cover this use case.  Similarly, I'd like something for arbitrary predicates.


com.netflix.iceberg.types.Conversions should use big-endian byte order for UUIDs

Conversions should use big-endian byte order for UUIDs according to the Iceberg spec.

I'll fix it together with #125


build(crypto/secp256k1): Update btcec/v2 to v2.3.4

Running a go get should consistently build this project as per the README. However, the latest patch release of btcec/v2 is not a proper Semantic Versioning patch. It removes an error return value from ecdsa.SignCompact function (btcsuite/btcd@e5d15fd). This is functionally a no-op, as the underlying function was hardcoded to always return nil as error. However, this is still a breaking change (compiler/build error) for all consumers of this function, as they historically expected two return values, but now only get one.
Ref: btcsuite/btcd#2211
Ref: #3531
Ref: #3536

PR checklist

[ ] Tests written/updated
[x] Changelog entry added in .changelog (we use unclog to manage our changelog)
[ ] Updated relevant documentation (docs/ or spec/) and code comments

As described in Contributing > Dependencies:

We use Go modules to manage dependencies.
That said, the main branch of every CometBFT repository should just build with go get, which means they should be kept up-to-date with their dependencies so we can get away with telling people they can just go get our software.

This PR proposes the minimal change scope for ensuring latest github.com/btcsuite/btcd/btcec/v2 can be used in such manner. The return signature of secp256k1.Sign is retained as ([]byte, error), so that backporting is clear.
Further clean-up (removing the error from return values) would impact the project widely, and should be considered a breaking refactor. It should be done in a different PR (yet to be opened) and would presumably not get backported due to the risks of conflicts.

Pushed a new commit as df846546ac2f751b793c26e80bb872729926d678 updated btcutil dependency on the next line (causing merge conflict).

@mergify backport v0.38.x

@mergify backport v0.37.x

@melekes, do you think it makes sense to remove error from return signature of crypto.PrivKey.Sign(msg []byte) function? All the implementations are now hard-coded to return nil as error with exception bls12381 which outright panics. It would be a breaking change, but I am not seeing a scenario where an error is reasonable to return.
Should I open a PR?


Unable to delete all unclassified objects

Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
I am unable to delete all unclassified objects through the following commands:
unclass = m3d.modeler.unclassified_objects
m3d.modeler.delete(unclass)
For some reason, the above code deletes half of the unclassified objects so I need to run it several times. However, when there´s only one unclassified object left, the code does not delete it.
Steps To Reproduce
Run the following command in any project with unclassified objects and see if it delets all of these unclassified objects.
for i in range(1, 10):
unclass = m3d.modeler.unclassified_objects
m3d.modeler.delete(unclass)
Which Operating System are you using?
Windows
Which Python version are you using?
3.10
Installed packages
ansys-pythonnet==3.1.0rc3
attrs==23.2.0
certifi==2024.2.2
cffi==1.16.0
charset-normalizer==3.3.2
click==8.1.7
click-plugins==1.1.1
cligj==0.7.2
clr-loader==0.2.6
colorama==0.4.6
contourpy==1.2.0
customtkinter==5.2.2
cycler==0.12.1
darkdetect==0.8.0
defusedxml==0.7.1
et-xmlfile==1.1.0
fiona==1.9.5
fonttools==4.49.0
fpdf2==2.7.8
geopandas==0.14.3
idna==3.6
imageio==2.34.0
jsonschema==4.21.1
jsonschema-specifications==2023.12.1
kiwisolver==1.4.5
matplotlib==3.8.0
networkx==3.2.1
numpy==1.26.0
openpyxl==3.1.2
osmnx==1.9.1
packaging==23.2
pandas==2.1.1
pillow==10.2.0
platformdirs==4.2.0
plumbum==1.8.2
pooch==1.8.0
psutil==5.9.8
pyaedt==0.8.1
pycparser==2.21
pyedb==0.4.0
pyparsing==3.1.1
pyproj==3.6.1
python-dateutil==2.8.2
pytomlpp==1.0.13
pytz==2024.1
pyvista==0.42.2
pywin32==306
referencing==0.33.0
requests==2.31.0
rpds-py==0.18.0
rpyc==5.3.1
scikit-rf==0.31.0
scipy==1.12.0
scooby==0.9.2
shapely==2.0.3
six==1.16.0
SRTM.py==0.3.7
tzdata==2024.1
urllib3==2.2.0
utm==0.7.0
vtk==9.2.6

@jmaravin Please provide an AEDT project to reproduce the issue.

Hi @jmaravin,
Your issue has been tackled in this PR #4349 and most probably will be available in the next release.
Kind regards,
Giulia

Great. Thanks @gmalinve appreciate it
Looking forward to it


remove mass.demo

Original report by Galen O'Neil (Bitbucket: oneilg, GitHub: oneilg).

It appears broken, it’s not tested, I don’t believe it’s been used in the last few years, and any content it has would be better placed in the doctests.

Below is my failed attempt to run it today on the truebq ubuntu machine:
Python 3.8.10 (default, May 26 2023, 14:05:08)
Type 'copyright', 'credits' or 'license' for more information
IPython 8.12.2 -- An enhanced Interactive Python. Type '?' for help.

In [1]: import mass.demo
m
This package (mass.demo) consist of several demonstration scripts.
To run one as an IPython demo, you say:

massdemo = mass.demo.demos['intro.py']
massdemo()
massdemo() # Each call to the Demo object moves forward 1 more block in the demo.
#      The basic intro.py has close to a dozen blocks to step through.
#      If you want to start over, in the middle or after completing the demo:
massdemo.reset()

The full list of available demos is:
('intro.py', 'fitting_demo.py', 'fitting_fluorescence.py', 'cuts.py', 'full_analysis_example.py')

In [2]: massdemo = mass.demo.demos["intro.py"]

In [3]: massdemo()
***************** Executing silent block # 0 (12 remaining) *****************
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
File ~/qsp/lib/python3.8/site-packages/IPython/lib/demo.py:450, in Demo.run_cell(self, source)
    447 def run_cell(self,source):
    448     """Execute a string with one or more lines of code"""
--> 450     exec(source, self.user_ns)

File <string>:21

ImportError: cannot import name 'sourceroot' from 'mass.demo' (/home/pcuser/qsp/src/mass/mass/demo/__init__.py)

In [4]:

This was actually fixed 9 months ago in 2d16a6c461118.


Translate Components and Props

Translating "Components and Props" to PT-BR.
Note:
On line 248, there is an external link to Pure Functions on Wikipedia.
I haven't found an article in Portuguese Wiki that match it.
So I kept the english one.

Thanks.
I've just committed the changes.

@halian-vilela could you please check again?


[Excel] (Workbook) Add onActivated conceptual docs

This PR adds:

A note about Workbook.onActivated in the Events article
An article section about onActivated in the Workbook article

Docs Build status updates of commit a00aa5b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.gitignore
:white_check_mark:Succeeded

docs/excel/excel-add-ins-events.md
:white_check_mark:Succeeded
View

docs/excel/excel-add-ins-workbooks.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 5ea093c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.gitignore
:white_check_mark:Succeeded

docs/excel/excel-add-ins-events.md
:white_check_mark:Succeeded
View

docs/excel/excel-add-ins-workbooks.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Should we support multiple instrument classes?

The grid_tools.py module currently supports TRES, Reticon, KPNO, SPEX, and SPEX_SXD instrument classes.  At present, the instrument classes house the spectral resolution and wavelength range specific to that instrument.  In principle, more advanced functionality could be added, like whether to use air or vacuum wavelengths, etc.
The question is whether we want to accept user contributions for instrument classes.  Supporting new instrument classes has the advantage of potentially increasing the user base by making it easier to apply the code on data from many instruments.  Supporting new instrument classes has the disadvantage that we have to maintain multiple possible configurations modes and other complexities that are specific to an instrument.  Users may disagree on instrumental properties, leading to confusion.
I think the advantages outweigh the disadvantages, but I wanted that assumption to be out in the open.
The other question that arises here is how or whether to standardize the classes.  I think a new class for every mode sounds fine.
In a few moments, I'll submit a pull request for the IGRINS instrument class as a demonstration.  I've broken the class up into H- and K- bands.

The answer is yes: we want your instrument classes.  Mimic the format in the above PR as a model for how to add new instrument classes.


Fix not restoring non-poisoned state

Context: we replace the current state of a peer with Poisoned with the intention of later putting back the proper state.
In that specific situation where a substream on a secondary connection gets closed, we didn't put back the proper state.
I've tried to figure out why it is this way (is it some missing code instead?), and I can't find any explanation other than a mistake.
I've also reviewed again the rest of the state machine, and can't find any place where we leave a Poisoned state.

bot merge

bot merge


New option to remove spaces around braces: insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces

From @aymone on July 8, 2016 17:59

VSCode Version: 1.3
OS Version: Ubuntu 16.04
Language: JS

Steps to Reproduce:
1.Create a simple object with functions shorthand like:
const x = {
    a(){}
};

2.Use VSCode auto format (ctrl+shift+i):
const x = {
    a(){ } // why vscode add this extra space between braces?
};

Any way to disable this?
Copied from original issue: Microsoft/vscode#8965

Moving to TS team since the formatter comes from the tsserver.

This should be controled by insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets but looks like it is not being honored.

I think insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets is for 'brackets'.
https://github.com/Microsoft/TypeScript/blob/730f18955dc17068be33691f0fb0e0285ebbf9f5/tests/cases/fourslash/formattingOptionsChange.ts#L22 :
runTest("InsertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets", "[ 1 ];[];[];[ , ];", "[1];[];[];[,];");

Maybe a new option for braces is needed?

+1 New option for braces...

So, I'm using VSCode 1.8.1, I have the next workspace settings
{
     "javascript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets": false
}

Still instead of
var x = {y: 5, z: 7};

I get this
var x = { y: 5, z: 7 };

Is this issue fixed?

Braces are not brackets and any new settings for this situation is not implemented yet. I'm not sure what should exactly be done there, will people want to incorporate rules for objects var a = {} and interface A { }?
Personally I do want to incorporate them and I really don't want to make a new rule to apply on those two different cases.
(The decision is not a super major factor for the delay, it's just that I had no time to visit here for months)

I think that majority of TypeScript projects use default format settings provided by TLS. At the same time JS guys use lots of different formatters, so I think this settings should influence JavaScript built-ins. There may be two settings. one for structuring objects
import {a} from 'abc';
var {x, y} = a;
var obj = {x: 5, y: 7};

and another one for functions and classes
function A() { }
class B { }

We already have an option specific for template strings (`${x}` vs `${ x }`) and JSX expressions (<foo bar={x} /> vs <foo bar={ x } />) so I think it may be too much to add another multiple options including insertSpaceAfterOpeningAndBeforeClosingNonemptyBracesForGeneralCase (what general?) and insertSpaceAfterOpeningAndBeforeClosingNonemptyBracesForFunctionAndClasses.
BTW, I think the new title is wrong as OP said about "empty" braces rather than nonempty braces. @mhegazy

What does TS team think about this?

All the flags we have are for "non-empty" brackets, braces, parens,,, etc... this issue is about empty code blocks.
We treat code blocks differently from object literals and array literals. so we just need another option to InsertSpaceInEmptyCodeBlocks (default true); this should cover functions, classes, namespaces, constructors, getters/setters, try/catch/finally, etc..
this leaves the case for what if you want to add a space in an empty object/array literal, e.g.:
var x = { };
var y = [ ];

instead of
var x = {};
var y = [];

We have not heard about this as a complain though, but if users ask for it, we can add insertSpaceInEmptyObjectLiteral and insertSpaceInEmptyArrayLiteral. i do not think this applies to template string,  destructing patterns, imports, or JSX though, since you would not specify empty list in any of these.
on a related note, InsertSpaceAfterOpeningAndBeforeClosingNonemptyBraces does not seem to be working for destructuring patterns:
var {a, b} = foo();
function f({a, b}) { }

should be:
var { a, b } = foo();
function f({ a, b }) { }

Well, BTW, I didn't know #10447 already added a new brace formatting option. Opened #13111 to add destructuring support.

I feel slightly confused, shouldn't we be consistent for both types of destructuring?
var { a, b } = foo(); // spaces
var [a, b] = bar(); // no spaces

@SaschaNaz Unfortunately nothing happened, VS Code highlights this option as missing.
But I manually added this flag to
resources\app\extensions\html\server\out\modes\javascriptMode.js
resources\app\extensions\typescript\out\features\formattingProvider.js
resources\app\extensions\typescript\package.json
and it worked for objects and imports (didn't work for destructuring).

@SaschaNaz Wait, it removes space inside inline function declaration.
function a(x) {return x;}

@alexanderby That behavior is the current implementation by #10447. It seems we need to add a new option to differentiate code blocks.

@SaschaNaz Maybe take a look at JSCS rules.

I feel slightly confused, shouldn't we be consistent for both types of destructuring?
var { a, b } = foo(); // spaces
var [a, b] = bar(); // no spaces

do we need a new flag for distructuring patterns instead?

do we need a new flag for distructuring patterns instead?

That will again cause another inconsistency. If we choose to insert space by default then the former will occur, if not then the latter will:
var [ a, b ] = [0, 1];
var {a, b} = { a, b };

:D

let's say we have InsertSpaceAfterOpeningAndBeforeClosingDestructuringBracesAndBrackets (could find a better name). this way at least, var [a,b] will be have the same as var {a, b}. and then we are left of with the [a,b] being different from {a,b} as we are today.

i wanna format
import React, {PropTypes} from 'react';

to
import React, { PropTypes } from 'react';

but
  "javascript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyParenthesis": true,
  "javascript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets": true,
  "javascript.format.insertSpaceAfterOpeningAndBeforeClosingTemplateStringBraces": true,
  "javascript.format.insertSpaceAfterOpeningAndBeforeClosingJsxExpressionBraces": true

all doesn't work. how could i do?

Can someone edit the title to reflect the example given by the OP? I think @mhegazy had a good suggestion (https://github.com/Microsoft/TypeScript/issues/9613#issuecomment-268622636)

We have not heard about this as a complain though, but if users ask for it, we can add insertSpaceInEmptyObjectLiteral and insertSpaceInEmptyArrayLiteral. i do not think this applies to template string, destructing patterns, imports, or JSX though, since you would not specify empty list in any of these.

@chandler0415 this worked for me:
    "javascript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces": false,
    "typescript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces": false

(you might want to set them to false in your case)

typescript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces: false is the only option at the moment, but I would prefer multiple options to make code look like:
import {item} from './item';    // remove space
const object = {...item, x: 5}; // remove space
const o = {};                   // remove space
const a = [5, 6, 7];            // remove space
const fn = () => { };           // add space
const f = () => { fn(); };      // add space
interface Item { x: number; }   // add space
interface Obj { }               // add space
if (item.x === 5) { fn(); }     // add space

So, I would prefer having no space inside objects, arrays and destructurings, but having space inside functions, interfaces, scopes.

when i use "typescript.format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces": false
on this
import { Observable, of } from 'rxjs';
@ViewChild('modal', {static: false}) private modal: ModalComponent;

I expect vscode to not change anything, but got this
import {Observable, of} from 'rxjs';
@ViewChild('modal', {static: false}) private modal: ModalComponent;

How can I turn of this rule?

The insertion of spaces during import autocompletion is very annoying, e.g. type import item<tab>, result is:
import { item } from './item';
        ⬆   ⬆

Both the insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces and insertSpaceAfterOpeningAndBeforeClosingEmptyBraces options have no effect.

Reported in VSCode repo at https://github.com/microsoft/vscode/issues/207835


Error while running data_generator.py

Hi, Try many time but still get error then running the data_generator.py . Can you help me.
Thanks
Here is the detail:
Using: <function generate_quantiles at 0x7ffa06e5b0d0>
Reading bitcoin market data file here: /tmp/coinbaseUSD.csv.
Those values should be roughly equal to 1/len(levels):
0 0.100001542282
1 0.100001542282
2 0.0999976865775
3 0.100001542282
4 0.107007356683
5 0.0929918721757
6 0.0999976865775
7 0.100001542282
8 0.0999976865775
9 0.100001542282
IntervalIndex([(-42.016, -0.133], (-0.133, -0.0562], (-0.0562, -0.0234], (-0.0234, -0.00443], (-0.00443, 0.0], (0.0, 0.0111], (0.0111, 0.0312], (0.0312, 0.0646], (0.0646, 0.14], (0.14, 67.889]]
closed='right',
dtype='interval[float64]')
/usr/local/lib/python3.4/dist-packages/matplotlib/cbook.py:136: MatplotlibDeprecationWarning: The finance module has been deprecated in mpl 2.0 and will be removed in mpl 2.2. Please use the module mpl_finance instead.
warnings.warn(message, mplDeprecation, stacklevel=1)
Traceback (most recent call last):
File "data_generator.py", line 94, in
main()
File "data_generator.py", line 90, in main
data_gen_func(data_folder, bitcoin_file)
File "data_generator.py", line 26, in generate_quantiles
return generate_cnn_dataset(data_folder, bitcoin_file, get_label)
File "data_generator.py", line 76, in generate_cnn_dataset
save_to_file(btc_slice, filename=filename)
File "/root/deep-learning-bitcoin/utils.py", line 29, in save_to_file
fig, ax = plt.subplots()
File "/usr/local/lib/python3.4/dist-packages/matplotlib/pyplot.py", line 1202, in subplots
fig = figure(**fig_kw)
File "/usr/local/lib/python3.4/dist-packages/matplotlib/pyplot.py", line 535, in figure
**kwargs)
File "/usr/local/lib/python3.4/dist-packages/matplotlib/backends/backend_tkagg.py", line 81, in new_figure_manager
return new_figure_manager_given_figure(num, figure)
File "/usr/local/lib/python3.4/dist-packages/matplotlib/backends/backend_tkagg.py", line 89, in new_figure_manager_given_figure
window = Tk.Tk()
File "/usr/lib/python3.4/tkinter/init.py", line 1854, in init
self.tk = _tkinter.create(screenName, baseName, className, interactive, wantobjects, useTk, sync, use)
_tkinter.TclError: no display name and no $DISPLAY environment variable

Your error can be solved by:
https://stackoverflow.com/questions/37604289/tkinter-tclerror-no-display-name-and-no-display-environment-variable

Matplotlib chooses Xwindows backend by default. You need to set matplotlib do not use Xwindows backend.
Add this code to your script and try again:
import matplotlib
matplotlib.use('Agg')
Or add to .config/matplotlib/matplotlibrc line backend : Agg.

thanks it work now. Thanks u so much


SideBarItem

This package very helpfull, can we resize Icon at SideBarItem ?

This package very helpfull, can we resize Icon at SideBarItem ?

Thank you very much, then I also noticed that the possibility of insert a custom size for the icon are missing, I will fix it as soon as possible🚀


v0.4 alpha : Titles localization don't work on some movies

Example : https://trakt.tv/movies/spring-summer-fall-winter-and-spring-2003

Being published on <IP_ADDRESS>


More CodegenCVisitor coverage

Try to fix #957

Codecov Report

Merging #997 (4285fb4) into master (519017a) will increase coverage by 0.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #997      +/-   ##
==========================================
+ Coverage   66.97%   67.24%   +0.27%
==========================================
  Files         189      189
  Lines       25686    25702      +16
==========================================
+ Hits        17202    17284      +82
+ Misses       8484     8418      -66

Impacted Files
Coverage Δ

src/codegen/codegen_cpp_visitor.cpp
74.81% <100.00%> (+1.51%)
:arrow_up:

test/unit/codegen/codegen_cpp_visitor.cpp
100.00% <100.00%> (ø)

src/language/templates/ast/ast.cpp
48.05% <0.00%> (+0.13%)
:arrow_up:

src/codegen/codegen_helper_visitor.cpp
83.71% <0.00%> (+0.28%)
:arrow_up:

src/language/templates/visitors/lookup_visitor.cpp
72.61% <0.00%> (+0.68%)
:arrow_up:

src/language/templates/visitors/ast_visitor.cpp
71.66% <0.00%> (+1.25%)
:arrow_up:

src/codegen/codegen_cpp_visitor.hpp
100.00% <0.00%> (+2.46%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Yarn 3 Lock File Support

WIP
Yarn 3 lock files were not being parsed properly since the format had changed.
New version format:
"react@npm:^17.0.2":
  version: 17.0.2
  resolution: "react@npm:17.0.2"
  dependencies:
    loose-envify: ^1.1.0
    object-assign: ^4.1.1
  checksum: b254cc17ce3011788330f7bbf383ab653c6848902d7936a87b09d835d091e3f295f7e9dd1597c6daac5dc80f90e778c8230218ba8ad599f74adcc11e33b9d61b
  languageName: node
  linkType: hard

@breadchris it looks like another PR after the fact has added the same functionality (https://github.com/anchore/syft/pull/868) . It seemed like this PR was still WIP/draft, I wanted to let you know in case you had any further work on this. If you have any extra work that isn't in #868 we could try to get both in --let me know if there is anything we can do to help 👍

@breadchris thanks so much for the contribution; as it looks like #868 was more complete with tests, I went ahead and got that merged and am going to close this for now. Please reopen if there are more changes required!


"sending message to a Handler on a dead thread" after image selected using image_picker library

Steps to reproduce
Device Details:
Device Model: OnePlus A5000
Android Version: 9.0 (Pie)
Flutter Version:  Flutter 3.22.2 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 761747bfc5 (10 weeks ago) • 2024-06-05 22:15:13 +0200
Engine • revision edd8546116
Tools • Dart 3.4.3 • DevTools 2.34.3
Image Capture Package: [Specify the version of the image_capture package you are using]

Open pubspec.yaml and add the image_capture package.
Implement image capture functionality using the image_capture package.
After capturing the image, a tick mark appears, indicating that the image should be selected/picked.
However, no image is selected/picked, and the following error is logged:
E/AndroidRuntime: FATAL EXCEPTION: main
java.lang.RuntimeException: sending message to a Handler on a dead thread

Expected results
The captured image should be selected and returned by the image_capture package.
Actual results

However, no image is selected/picked, and the following error is logged:
E/AndroidRuntime: FATAL EXCEPTION: main
java.lang.RuntimeException: sending message to a Handler on a dead thread

Code sample
Future getImage() async {
try {
await _requestPermissions();
final ImagePicker picker = ImagePicker();
final XFile? image = await picker.pickImage(source: ImageSource.camera);
  if (image != null) {
    setState(() `{`
      selectedImage = File(image.path);
    });
  } catch (e, stackTrace) {
        print("Error getting image: $e");
      }
    }

}
Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
[√] Flutter (Channel stable, 3.22.2, on Microsoft Windows [Version 10.0.19045.4651], locale en-IN)
[√] Windows Version (Installed version of Windows is version 10 or higher)
[√] Android Studio (version 2022.2)
[√] Connected device (4 available)
[√] Network resources

I cannot reproduce the issue with the latest stable,
do you experience the problem with the code sample below?

code sample
import 'package:flutter/material.dart';
import 'package:image_picker/image_picker.dart';

typedef PickImageCallback = void Function(XFile);

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(context) => const MaterialApp(home: MyHomePage());
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key});

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  late final ValueNotifier<XFile?> _notifier;
  @override
  void initState() {
    _notifier = ValueNotifier<XFile?>(null);
    super.initState();
  }

  @override
  void dispose() {
    _notifier.dispose();
    super.dispose();
  }

  void _pickImage(XFile file) => _notifier.value = file;

  @override
  Widget build(context) => ValueListenableBuilder(
        valueListenable: _notifier,
        builder: (context, crossFile, child) => Scaffold(
          body: crossFile == null
              ? PickImage(callback: _pickImage)
              : Center(
                  child: FutureBuilder(
                    future: crossFile.readAsBytes(),
                    builder: (context, snapshot) {
                      if (snapshot.connectionState != ConnectionState.done) {
                        return const CircularProgressIndicator();
                      }
                      if (snapshot.data == null ||
                          snapshot.hasError ||
                          snapshot.data!.isEmpty) {
                        return const Icon(Icons.error);
                      }
                      return Image.memory(snapshot.data!);
                    },
                  ),
                ),
          floatingActionButton: crossFile == null
              ? null
              : FloatingActionButton(
                  onPressed: () => _notifier.value = null,
                  child: const Icon(Icons.restore),
                ),
        ),
      );
}

class PickImage extends StatelessWidget {
  final PickImageCallback callback;
  const PickImage({
    super.key,
    required this.callback,
  });

  @override
  Widget build(context) => Column(
        mainAxisAlignment: MainAxisAlignment.spaceEvenly,
        crossAxisAlignment: CrossAxisAlignment.center,
        children: [
          Center(
            child: PickerButton(
              icon: Icons.camera,
              callback: callback,
              source: ImageSource.camera,
            ),
          ),
          Center(
            child: PickerButton(
              icon: Icons.folder,
              callback: callback,
              source: ImageSource.gallery,
            ),
          ),
        ],
      );
}

class PickerButton extends StatelessWidget {
  final ImageSource source;
  final PickImageCallback callback;
  final IconData icon;
  const PickerButton({
    super.key,
    required this.source,
    required this.callback,
    required this.icon,
  });

  @override
  Widget build(context) => OutlinedButton(
        onPressed: () async {
          final file = await ImagePicker().pickImage(
            source: source,
          );
          if (file == null) {
            return;
          }
          callback(file);
        },
        child: Icon(icon),
      );
}

name: issue_153244
description: "A new Flutter project."
publish_to: 'none'
version: 1.0.0+1

environment:
  sdk: ^3.5.0

dependencies:
  flutter:
    sdk: flutter
  image_picker: ^1.1.2

dev_dependencies:
  flutter_test:
    sdk: flutter
  flutter_lints: ^4.0.0

flutter:
  uses-material-design: true

[✓] Flutter (Channel stable, 3.24.0, on macOS 14.5 23F79 darwin-arm64, locale en-US)
    • Flutter version 3.24.0 on channel stable at /Users/francesco/fvm/versions/stable
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 80c2e84975 (12 days ago), 2024-07-30 23:06:49 +0700
    • Engine revision b8800d88be
    • Dart version 3.5.0
    • DevTools version 2.37.2

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/francesco/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] VS Code (version 1.92.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.94.0

[✓] Connected device (3 available)
    • macOS (desktop)                 • macos                 • darwin-arm64   • macOS 14.5 23F79 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad • darwin         • macOS 14.5 23F79 darwin-arm64
    • Chrome (web)                    • chrome                • web-javascript • Google Chrome 120.0.6099.71

[✓] Network resources
    • All expected network resources are available.

• No issues found!

I'm facing this issue specifically for this device version
Device Model: OnePlus A5000
Android Version: 9.0 (Pie)

@akshaykap11 It seems you mistyped the package name as I don't see image_capture on pub.dev. So I updated the description to image_picker instead (based on the issue title). Please correct me if I'm wrong (in case you have a private package named image_capture)
When the issue happens, is the app terminated? Can you provide the entire crash stack trace?
Also, what is the current image_picker version? Can you confirm with the sample code Iapicca shared above?


Update values.py

Cadillac ATS-V Coupe 3.6L biturbo RWD w/o ACC 2018

Waiting on a test route to remove from dashcamOnly

@JasonJShuler does this only support the 2018 model year?

Unfortunately this car does not have an ASCM so it lacks ACC, we can't support these cars just yet. A fork might have what you're looking for!


Dismiss window on clicking outside

Would be cool if a feature can be implemented where if the user click outside the window, gitify will disappear. This would only be applicable to when using tray icons.
This should be an selectable option

Hi @davidhu2000 - this should be the case in version 3.0.0 so closing this issue. Let me know if that's not the case and I can reopen it. 😄