Add OutputType attribute to various commands

PR Summary
Fixes https://github.com/PowerShell/PowerShell/issues/15905
Adds the OutputType attribute with a fitting type to the following commands:

Rename-Computer (RenameComputerChangeInfo)
Get-TimeZone (TimeZoneInfo)
Set-TimeZone (TimeZoneInfo)
Show-Command (string)
Invoke-WebRequest (BasicHtmlWebResponseObject)
ConvertTo-Json (string)
ConvertTo-Html (string)
Test-Json (bool)
New-Variable (PSVariable)
Pop-Location (PathInfo when used in following providers: Certificate, FileSystem, Registry)
Push-Location (PathInfo when used in following provider: Registry)
Resolve-Path (String and PathInfo when used in the following provider: Registry)
Enable-WSManCredSSP (XmlElement)
Get-WSManCredSSP (string)
Invoke-WSManAction (XmlElement)
New-WSManSessionOption (SessionOption)
Test-WWMan (XmlElement)
Set-WSManQuickConfig (string)
Get-WSManInstance (XmlElement)
Set-WSManInstance (XmlElement)
New-WSManInstance (XmlElement)
TabExpansion2 (CommandCompletion)

I assume I don't need tests for adding this attribute, if that assumption is wrong then please tell me how you would like to see those tests.

PR Context

PR Checklist

[X] PR has a meaningful title

Use the present tense and imperative mood when describing your changes

[X] Summarized changes
[X] Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
[X] This PR is ready to merge and is not Work in Progress.

If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.

Breaking changes

[X] None
OR
[ ] Experimental feature(s) needed

[ ] Experimental feature name(s):

User-facing changes

[X] Not Applicable
OR
[ ] Documentation needed

[ ] Issue filed:

Testing - New and feature

[X] N/A or can only be tested interactively
OR
[ ] Make sure you've added a new test if existing tests do not effectively test the code changed

Tooling

[X] I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
OR
[ ] I have considered the user experience from a tooling perspective and opened an issue in the relevant tool repository. This may include:

[ ] Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode
(which runs in a different PS Host).

[ ] Issue filed:

[ ] Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.

[ ] Issue filed:

[ ] Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).

[ ] Issue filed:

[ ] Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

[ ] Issue filed:

I assume I don't need tests for adding this attribute, if that assumption is wrong then please tell me how you would like to see those tests.

I'd prefer to have such tests. Perhaps it would be better to add tests for existent annotations and only then continue with the PR.

I don't think any other commands include tests for the different attributes and parameter attributes they have so it seems like overkill to me. If you insist on them getting added, I still need to know how to write those tests, I don't know how to properly test for attributes. I mean I could use tabexpansion2 to test for completions but surely there's a better way?

Not related for the PR: perhaps you could have an interest to grab https://github.com/iSazonov/PowerShell/tree/outputtype-parameterset-inference

I have thought about that feature but I suspect it's going to be a lot of work and if I was going to work on another big feature in the near future I would aim for something more important to me like pseudobinding for splatting hashtables. For now I think I'll take a bit of a break from new big PRs so mine and the other 90+ open PRs can actually get merged.

I don't think any other commands include tests for the different attributes and parameter attributes they have so it seems like overkill to me. If you insist on them getting added, I still need to know how to write those tests, I don't know how to properly test for attributes. I mean I could use tabexpansion2 to test for completions but surely there's a better way?

I can not insist :-) I say ideally if we have a code the code must be fully covered by tests.
I think it makes no sense to have functional tests for every cmdlet since code is in Engine and it is the same code and enough to have one functional test for every code path. (It is not huge work to cover the code by tests.)
But we could generate by a script compatibility tests (like DefaultCommands.Tests.ps1) so that if somebody changed output type of a cmdlet we could see this. The tests could read output type attributes from in-box cmdlets and compare its with etalon values.

I have thought about that feature but I suspect it's going to be a lot of work and if I was going to work on another big feature in the near future I would aim for something more important to me like pseudobinding for splatting hashtables. For now I think I'll take a bit of a break from new big PRs so mine and the other 90+ open PRs can actually get merged without too many merge conflicts.

I stopped the work because of the same reason - no code reviewers. But if you will grab my code (it is small) in near future I can review (and merge if we will have great tests).


fix: git sync ui fixes

Description

Add Git status API
Add Git Disconnect functionality
Fix Default Config disable state issue

Fixes https://github.com/appsmithorg/appsmith/issues/7966
Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Locally
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: git-sync-ui-fix

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
54.72 (0)
36.37 (-0.03)
33.44 (-0.07)
55.27 (0)

:green_circle:
app/client/src/actions/gitSyncActions.ts
62.5 (0.66)
100 (0)
0 (0)
71.79 (3.22)

:red_circle:
app/client/src/api/GitSyncAPI.tsx
47.37 (-5.96)
100 (0)
7.69 (-1.4)
48.57 (-5)

:red_circle:
app/client/src/components/ads/Checkbox.tsx
25 (-2.03)
15 (-1.67)
0 (0)
28.57 (-1.73)

:red_circle:
app/client/src/components/ads/Icon.tsx
50.27 (-0.14)
33.12 (-0.21)
100 (0)
50.14 (-0.13)

:red_circle:
app/client/src/components/ads/Text.tsx
100 (0)
76.67 (-1.9)
100 (0)
100 (0)

:green_circle:
app/client/src/components/ads/TextInput.tsx
74.58 (1.85)
48.57 (1.98)
83.78 (1.96)
73.83 (2.11)

:green_circle:
app/client/src/components/designSystems/appsmith/header/DeployLinkButton.tsx
80.65 (8.43)
84.62 (-15.38)
16.67 (0)
79.31 (10.56)

:green_circle:
app/client/src/constants/DefaultTheme.tsx
93.1 (0.06)
90 (0)
71.43 (0)
92.08 (0.08)

:red_circle:
app/client/src/constants/messages.ts
74.34 (0.02)
100 (0)
24.02 (-0.03)
79.91 (-0.06)

:green_circle:
app/client/src/constants/routes.ts
68.42 (0.14)
28.48 (0)
28 (0)
65.67 (0.17)

:red_circle:
app/client/src/pages/Editor/EditorHeader.tsx
88.64 (0.27)
55.22 (-1.7)
70.97 (0)
88.19 (0.29)

:green_circle:
app/client/src/pages/Editor/EditorAppName/NavigationMenuData.ts
68.42 (1.75)
41.67 (1.67)
7.14 (-1.19)
67.86 (1.95)

:red_circle:
app/client/src/pages/Editor/gitSync/components/StyledComponents.tsx
58.33 (-1.67)
80 (0)
0 (0)
58.33 (-1.67)

:red_circle:
app/client/src/reducers/uiReducers/gitSyncReducer.ts
16.22 (-3.13)
100 (0)
0 (0)
16.22 (-3.13)

:red_circle:
app/client/src/sagas/GitSyncSagas.ts
12.5 (0.83)
1.52 (-0.75)
7.69 (-1.4)
16.52 (1.3)

:green_circle:
app/client/src/selectors/applicationSelectors.tsx
68.67 (0)
33.33 (3.33)
46.15 (0)
61.54 (0)

:red_circle:
app/client/src/selectors/commentsSelectors.ts
78.23 (-1.61)
54.41 (-2.94)
70 (0)
84.09 (-2.27)

:red_circle:
app/client/src/selectors/gitSyncSelectors.tsx
69.44 (-0.37)
50 (-30)
8.7 (-2.41)
58.33 (-4.83)

/ok-to-test sha=1a381b2

/ok-to-test sha=e046137


Beit-2: why use different interpolation for backbone and tokenizer

Describe
Model I am using (UniLM, MiniLM, LayoutLM ...): Beit-2
Hi, I wonder why do you use different interpolation for backbone(bicubic) and tokenizer(lanczos) here?
Will there be difference if I use bicubic for both?

Thanks for the attention!
We use bicubic for both. Refer to TOKENIZER.md for more details.


Support for PhantomJS 2.0

Hi,
this isn't actually an issue, but i was wondering, when will you support the pre-release of phantomJS 2.0. Is it possible to get it running with casperJS? I get an error message requiring version 1.9....

I have solved a lot of problems. I went through a lot of code. Now I have problem with upload file in PhantomJS 2.0.0 (non-develop) but I deal it. Stay tuned ;-)

:+1: don't wait to see this feature in casperjs  !

I send pull-request https://github.com/n1k0/casperjs/pull/1137 but i don't know, why don't show here

Any hope for support 2.0?

I have a similar issue on OSX Mavericks when I try to start CasperJS (installed from Homebrew).
$ casperjs --version
Couldn't find nor compute phantom.casperPath, exiting.

  /usr/local/Cellar/casperjs/1.0.4/libexec/bin/bootstrap.js:241 in loadCasper

My environment:
$ uname -a
Darwin hosty.local 13.4.0 Darwin Kernel Version 13.4.0: Wed Dec 17 19:05:52 PST 2014; root:xnu-2422.115.10~1/RELEASE_X86_64 x86_64
$ node --version
v0.12.0

Any news when things will get fixed? Can I provide more information to help solve this problem?

@yonkeltron create your own issue.

@mickaelandrieu Thanks. Done: https://github.com/n1k0/casperjs/issues/1158

Is the phantomjs-2 branch dead?  Last commit was > 1 month ago, even though PhantomJS 2.0 was officially released > 2 months ago and there is no sign of anyone [else] noticing that casperjs apparently has at least one major compatibility issue, i.e. error handling not only not working, but process bloat to the point of explosion when it happens..

@jdunk we are waiting for phantomjs 2.0.1 release because there is no gnu/linux build available for now.
Notice also that CasperJS 1.1 probably won't provide official support of phantomjs 2, if you must use pahntomjs 2 and want a nice api on top of it, you can use nightmarejs :)

Notice also that CasperJS 1.1 probably won't provide official support of phantomjs 2,

I don't remember seeing any discussion on this. Can you explain why?
(E.g. is there some fundamental change between phantom 1.9.x and 2.x
APIs, that affect CasperJS?)

@DarrenCook yes. Coffeescript support has been removed from phantomjs2, error handling change a lot

@DarrenCook yes. Coffeescript support has been removed from phantomjs2, error handling change a lot

Does CasperJS use Coffeescript internally? Can CasperJS patch it on to
PhantomJS, the same way SlimerJS did?
https://github.com/laurentj/slimerjs/commit/1953810acabd6df9ef6c3717c72fb585cc15eae0
Regarding error handling, which of the regression bugs is/are the problem?
https://github.com/ariya/phantomjs/issues?utf8=✓&q=label%3ARegression+
Is it something that stops CasperJS working, or is it more something
like the difference between PhantomJS and SlimerJS?

@mickaelandrieu thanks. There are linux builds available though (which is how I was able to test on my Ubuntu machine).
https://github.com/ariya/phantomjs/issues/12948#issuecomment-78181293
And Mac builds have been available.  Seems a little strange that a lack of packaged linux builds from the download page directly would be deterrent enough to halt progress on support for new error handling.

especially when many (most?) developers use Macs.  => ahahahahah !!! you made my day.

brew install casperjs right now is installing phantom2 as the dependency (and casperjs fails the phantom version check). This is not an issue with casper though, I guess.

@claudioc this is an issue /c @n1k0 can you check the brew package ? I don't have Apple machines to test.

@claudioc the issue with Brew is definitely something that should be fixed for CasperJS v1.1.
#1146

@claudioc  CasperJS Formula dose not depend PhamtomJS Formula now. Could you try to update Homebrew and reinstall Casper?

@cosmo0920 :+1:
claudioc@tiburon:~$ brew install casperjs --devel
==> Downloading https://github.com/n1k0/casperjs/archive/1.1-beta3.tar.gz
Already downloaded: /Library/Caches/Homebrew/casperjs-1.1-beta3.tar.gz
==> Downloading https://phantomjs.googlecode.com/files/phantomjs-1.8.2-macosx.zip
######################################################################## 100.0%
🍺  /usr/local/Cellar/casperjs/1.1-beta3: 363 files, 11M, built in 12 seconds

The devel version (aka casperjs v1.1-beta3) would highly benefit from using a much more recent version of PhantomJS from the 1.9.x branch. Would this be achievable?

@n1k0 So many comments here regarding CasperJS's 1.* branch. Isn't support for Phantom JS 2.0 reserved strictly for CasperJS 2?  If so, what's CasperJS 1.* got to do with this "support PhantomJS 2.0" ticket?

@mickaelandrieu

especially when many (most?) developers use Macs. => ahahahahah !!! you made my day.

I... really don't understand what you're laughing at.  Huh?  Are you... actually unaware of how many devs use macs?

Troll apart, we will wait for official gnu/linux support from phantomjs team before think about support it.

Well, it's no wonder with that defeatist, anti-eager attitude (and if you speak for more than yourself, invoking "we") why there's been zero progress on PhantomJS 2 support.
If you're just busy, fine, that's reasonable. But for a developer to poopoo the idea of working with a released (not even beta or rc, but already stable released) version simply because the ready-to-go build for his favorite OS is "unofficial" to me is antithetical to the very essence of what being a developer is.

you can suggest and make a PR on phantomjs-2 branch if you need some improvements

That you used the phrase "some improvements" shows me you have not looked at the major issue I originally referred to in this thread.  On any error, casper not only fails and freezes but it crashes your entire machine!  Not exactly trivial.

make a PR...this is open source and open to any (new) contributors.

If my javascript skills were better, and I knew where to find PhantomJS 2's error api, I'd be in a much better position to actually do that.  At least I don't have some irrational fear of installing the linux build, which is provided by Travis CI.

@jdunk so...  what did you suggest to help ?

@mickaelandrieu See above.  ^^^  (Did you read it?)
To summarize, I suggested:

Providing an honest, valid reason for, as you put it, not even "thinking about" supporting PhantomJS 2.0
Not having an irrational fear of the linux build provided by Travis CI
Any dev who uses a mac and reads this thread may find "official" builds directly (and knows where to find linux builds)
Looking at the major issue that I am now referencing for the third time, for a sense of importance.
Embracing the quintessential developer attitude which seeks out progress and innovation, instead of standing in its way, the latter of which you are doing by implying I'm not helping at all instead of acknowledging all of the above and/or coming clean about the real reason you (and others?) refuse, in your own words, to even "think" about making changes needed so that casper doesn't explode your computer when using PhantomJS 2.

I see that you're the #2 contributor and that is very much appreciated, but that doesn't justify being snippy, dismissive, and disingenuous in response to valid points that are raised (and laughing at a very hard-and-fast reality that is macs being popular amongst developers?  What was that about?).
If you are now too busy or have lost interest or are burnt out or (insert anybody's guess here, given lack of any direct reasonable explanation provided), once again, that's fine.  Just say so.  There is no call for coming after me for pointing it out.
I'd like to echo your own sentiment back to you ("what did you suggest to help?"). If you have nothing, that's fine. Let's let those with productive things to say do the talking.

@jdunk again, we (the core team) have never say we will support officialy phantomjs2.
And I already have provided a valid reason: we will provide support for phantomjs 2.0.1 if:

phantomjs core team provide a stable build for gnu/linux;
someone make a complete pull request (already done atm)
remove all coffeescript tests, because phanyomjs2 have removed coffeescript support
rework a little bit the error handler system
but also, as this is a BC:

Make a roadmap for 2.0.x release
Remove testing api, move it on his own repository
Release a stable 1.1
"Embracing the quitessential developper attitude which ... "
Want more ?

Take one issue and provide a patch, this is the best you can do.
Thanks

Hello,
it looks like this integration will take several months (or will never happen) and I just wanted to highlight that things like phantomCSS and any kind of visual regression tool based on casperjs is breaking or can't be used in the first place as JS-only apps are being created and phantomjs < 2 renders them like they are completely broken.
Is there any plan/ETA yet? That's basically the only reason why I've never used casperJS and it's 3+ years that SPAs are out in huge numbers (thanks to Angular/React mostly).

Really need casperJS to support Phantom2.0, the whole "1.8.2 or greater, but less than 2.0." is the silliest thing.
For people like me who can't install anything less than phantom2.0 (because it's the latest and many of our libs require 2.0 now) CasperJS is now useless until it supports 2.0.
An update with the status on that would be greatly appreciated.
Thanks!

@webdevbrian to be honest, this is probably won't happen. I think we should declare CasperJS abandonned /c @n1k0 .
I don't have time to maintain it since I work on BackBee CMS, you should take a look to nightmarejs if you need a wrapper of phantomjs

Awwww dang it! I was getting really excited (We'll just do it in Phantom), but loved what I saw from the documentation. That stinks!

yeah, sorry .. I'm sad but I don't have time for it, we probably need to search a new maintainer :/

Closed with https://github.com/n1k0/casperjs/pull/1310 and https://github.com/n1k0/casperjs/pull/1352.
Note, however, that support for phantomjs 1.9.0 and earlier is dropped.

https://github.com/datakurre/phantomrobot
I am referring above page for installing phatomrobot.
on mac: when executing
bin/buildout
getting an error:
Updating nodejs.
Installing phantomjs.
Downloading https://phantomjs.googlecode.com/files/phantomjs-1.9.0-macosx.zip
While:
Installing phantomjs.
Error: Error downloading extends for URL https://phantomjs.googlecode.com/files/phantomjs-1.9.0-macosx.zip: HTTP Error 404: Not Found
Could you please tell me the correct URL?

https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/phantomjs/phantomjs-1.9.0-macosx.zip
installation script ? What does that mean ? casperjs never install anything
Regards


[BesTLA] Support fp16 for compute_dtype and scale_dtype

Type of Change

support scale_dtype=fp16
support compute_dtype=fp16, only available for GNR with AMX_FP16
split kernels into multiple ISA files
move intrinsic codes from mha to bestla kernel
change the default scale_dtype to fp16, default compute_dtype to int8

will this pr support gemv with bf16 activation?

what' meaning of move intrinsic code from mha to bestla kernel? I didn't notice any mha related ut

Use the unified ISA control

will this pr support gemv with bf16 activation?

Not in this pr.


Improve: Warn the user when we have permission error

fix #634
Looks like this.

@stoivo, feel free to merge as soon as CI passes.


Fix: Constant T_TRAIT is defined

This PR

[x] removes code that preserves compatibility with PHP 5.3

Thank you, @froschdesign!

Thanks, @localheinz!

Thank you, @weierophinney!


refactor: remove dead code

:white_check_mark: Build TheIdServer 2.2.1-fix-request-on-datetime1-0062 completed (commit https://github.com/Aguafrommars/TheIdServer/commit/f37b101506 by @)


Chalk v3 beta feedback

This issue is for discussing the upcoming Chalk v3 version which is now in beta.
Beta 1: https://github.com/chalk/chalk/releases/tag/v3.0.0-beta.1
Let us know if you encounter any issues with upgrading or if anything is unclear in the release notes.

It seems like it breaks @Qix-'s code on https://github.com/Berkmann18/nclr/pull/109#issuecomment-505652869.
I'm not familiar with the code and what changed since he posted the work-around so other than the chalk.constructor.prototype -> chalk.Instance.prototype, I'm unsure how to go about it.

Hey there.
I believe this is also a problem in 2.x.x code, but, I'm currently using the 3.0.0.beta.2, and
I have found that with macOS 10.15, using Node.js 'child_process.spawn()` that the child process is determining that there is no color support, so things are looking pretty 'bland' as a result.
However, if I create a new chalk instance (as documented) with const ctx = new chalk.Instance({level: 3}) then the result is very colorful (as expected).
It would be really good if the spawned child process would detect that color is available all by itself.
Keep up the good work!

Chalk 3 final is now out: https://twitter.com/sindresorhus/status/1193065505780727808


Upgrade to OpenTracing 0.33.0

Supersedes https://github.com/eclipse/microprofile-opentracing/issues/150
Based on the discussion in https://groups.google.com/d/msg/microprofile/unYFj9EpTgM/3pu7yppyAwAJ we have decided to directly bump version from 0.31.0 to 0.33.0 (skip 0.32.0) and release it in MicroProfile-OpenTracing 2.0.
The MP-OT 2.0 then will be a standalone spec (removed from MicroProfile umbrella, https://groups.google.com/d/msg/microprofile/unYFj9EpTgM/UMRjGy8rBAAJ) or included in summer release 4.0.

Hi @pavolloffay , shouldnt MP-OT 2 just move to opentelemetry which superseeds opentracing API?

Please follow the discussion on the mailing list. OpenTelemetry will be likely a new spec.

Yep but then what is the point to continue opentracing? Just adds more noise to MP and gives an even more obvious "sandbox" image which is not good IMHO.

Btw. there is no stable release of OpenTelemetry at the moment. Not sure if there will be one before June and even though we will have to build a new spec/integration for it which will take some time.
So rather than staying on old OT API version causing incompatibility with other instrumentations and unmaintained Tracer implementations we should upgrade anyway.
Please continue the discussion on the mailing list.

0.2.0 is already available (https://github.com/open-telemetry/opentelemetry-java/releases)
Tracer impl can be part of MP stack (it is the case for geronimo implementation for ex) so maintenance point is purely a vendor choice.
Incompatibility has not been an issue for a year so guess 6 more months is not an issue.
This is why I think a new major immediately superseeded by the merge of opentracing and metrics (which is a good move) is a bad choice and the 0.33 upgrade shouldn't happen since it will break end users, require work, then enforce them to change all their API.

0.2.0 is not a stable release.

It does not seem like a stable release. See the semver semantics. We don't want to repeat the same problems we had with going with OpenTracing.

Tracer impl can be part of MP stack

Yes, it Otel SDK will be probably part of the MP spec.

0.33 upgrade shouldn't happen since it will break end users, require work, then enforce them to change all their API.

That is why it might go to breaking change release or be taken away from the umbrella spec

It's highly likely that OpenTracing 2.0 will be released, but also removed from the MP Platform umbrella for MP 4.0 to allow easier inclusion of OpenTelemetry when it's ready


[AIRFLOW-811] support for multiline output in bash_operator

Dear Airflow Maintainers,
Please accept this PR that addresses the following issues:

https://issues.apache.org/jira/browse/AIRFLOW-811

Testing Done:

existing unit tests covers it already since no new functionality added

Because the bash_operator has many uses, I am reluctant to add a step that materialize the entire log into the job memory instead of handing it off to the logging infrastructure.

agree with @artwr but it is very useful to capture the entire output sometimes. If @jhsenjaliya can add another option to capture only one last line or all, I think it would be best. To make it even more fance, add an option to pass regex expression to extract only needed piece from the output. Like in my recent case, I needed to extract counters from sqoop output which is very verbose as well.

Current coverage is 66.75% (diff: 100%)

Merging #2026 into master will decrease coverage by <.01%

@@             master      #2026   diff @@
==========================================
  Files           138        138
  Lines         10526      10526
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           7028       7027     -1
- Misses         3498       3499     +1
  Partials          0          0

Powered by Codecov. Last update dc97bcd...e72888d

pipe it to a file first? By python so we can make it generic so it is usable in other hooks as well?

@artwr, @bolkedebruin Please take a look. it uses temp file now.
@boristyukin please check the added regex matching output functionality

@jhsenjaliya I think @artwr was concerned about excessive logging stored via xcom. I understand you are using temp files now but i think for backward compatibility a few things needs to be considered:

some people would prefer to retain old behavior when only last like is pushed to XCOM vs. everything
I really liked old behavior when I could look at the full output using UI - I think with changed you made, output won't be available via UI unless I am missing something

Overall all the defaults should behave like they do currently while changes you suggested should be all optional. just IMHO

@boristyukin, pls find comment inline.

some people would prefer to retain old behavior when only last like is pushed to XCOM vs. everything

I think that was bad behavior promoted by the old design of getting last line only, IMHO, it should be either all output or filtered one by regex ( specially if concern is about large output )
in any case, if more people think getting last line should be the expected behavior, how about adding flag to just get last line.

I really liked old behavior when I could look at the full output using UI - I think with changed you made, output won't be available via UI unless I am missing something

sure I will add output to the log.

Thanks for the review

no love for this PR? i think it is very useful one..

@boristyukin, with last commit, do you have any more concerns ? please comment and i can rebase this to resolve the conflict.

@jhsenjaliya I like what you did but I guess reviewers would need to approve it. I think this is really useful PR

@artwr do you have any comments here?

Still any plans to move this forward?


Zero values in Objects are not displayed

When displaying objects or functions then properties with value of 0 are not displayed

Fixed in latest version, <IP_ADDRESS>


@bsRecord with two different types of the same structure

Hey all, I'm working on converting some of our app queries from Js.t to @bsRecord syntax. I'm running into and issue where @bsRecord doesn't see to be mapping to the right record type when I have two fields of the same name/structure.
Here is the code:
type user = {
  id: string,
  firstName: option(string),
  lastName: option(string),
};

type actor = {user: option(user)};

type target = {user};

type activity = {
  id: string,
  createdAt: Js.Date.t,
  type_: [ | `USER_POST | `CALENDLY | `APPLICATION],
  body: option(string),
  actor: option(actor),
  target,
};

module Fragment = [%graphql
  {|
  fragment Activity on Activity @bsRecord {
    id
        createdAt  @bsDecoder(fn: "Decoders.dateDecoder")
        type_: type
        body
        actor @bsRecord {
          user @bsRecord {
            id
            firstName
            lastName
          }
        }

        target @bsRecord {
          user @bsRecord  {
            id
            firstName
            lastName
          }
        }
  }
  |}
];

The code compiles fine if I only want the actor or target fields individually but if I try to have both, I get the following error:
  26 ┆ body
  27 ┆ actor @bsRecord {
  28 ┆   user @bsRecord {
  29 ┆     id
  30 ┆     firstName
  31 ┆     lastName
  32 ┆   }
  33 ┆ }
  34 ┆

  This has type:
    option(user)
  But somewhere wanted:
    user

It doesn't seem to pick up the actor should have an optional user and target should have a non-optional user.
Here are the graphql type defs:
  type ActivityActor {
    user: User
  }

  type ActivityTarget {
    user: User!
  }

  type Activity {
    id: ID!
    createdAt: Date!
    type: ActivityType!
    body: String
    actor: ActivityActor
    target: ActivityTarget!
  }

Would love any help on this one. Once again, not sure if this an issue with my syntax or an actual bug? 😅
Thanks a ton!

You can try the records PR branch (npm package @jfrolich/graphql_ppx_re). This will automatically create the record types for you. Documentation here: https://github.com/jfrolich/graphql_ppx_re/tree/records.

Woah, that looks awesome! Thanks @jfrolich!!
Is that fork more actively maintained than this one? Is it on the roadmap to merge the two?

Yes. It is a bit early because it's a big change. There will probably an official beta soon. The fork is just under my namespace to have a working NPM package that my startup uses in production.

@jfrolich so awesome! I'll probably wait until the official beta to switch and leave that one type in Js.t for now since I was able to convert the rest over. Excited to check it out when live! :)

I just tested your fork, @jfrolich, and it is just beyond comprehension, so cool with @argumentDefinitions and the record support! Thanks for all the work, can't imagine the amount of effort you put into it... Is there any estimate on when it is going to be merged into the main repo?
And can people give feedback/create issues for your fork in this repo or is there a better way?

@MargaretKrutikova: Great you are trying it out! My company is using it in production already. Record support was quite an architecture change so there are a few more breaking changes coming up before it's "stable", so want to keep it in beta until then, and also do a bit more polish like documentation etc. and release that as 1.0. No real timeline, but hopefully soon!
You can just open issues here. Features will be mostly added to the 1.0 branch anyway. I will try to keep some of the larger changes to 1.0 in separate pull-request as well (like #98).

@MargaretKrutikova: Btw try out the official 1.0 beta and not my "@jfrolich" fork. That one is not used anymore as we are now having the official beta release.

@ppxAs in 1.0 is addressing this. (And of course also the option to compile everything to records).


Add Xcode 11.2.1 support

Describe the solution you'd like
Add support for Xcode 11.2.1.
Describe alternatives you've considered
Not selecting Xcode 11.2 on any of my projects.
Additional context
The changelog can be found here. The most important (and only) change is:

Storyboards containing a UITextView will cause the app to crash on macOS versions earlier than macOS 10.15.1 if compiled on a Mac running macOS 10.15.1. (56808566)

Hi, this request is on track and Xcode 11.2.1 will come next week.

Awesome. Thanks :)

Thanks!!

Might want to jump on the beta release cycle in the future ....

Might want to jump on the beta release cycle in the future ....

They had 11.2 beta for a long time. I don't believe there was any 11.2.1 beta, it just went GM on the developer downloads page and didn't even hit AppStore for a while after that.

Xcode 11.2.1 is available!
Currently, it is GM (11B53).
GA(11B500) will be available soon.

Awesome, thanks for the update.


Doc: Some things to fix

Reversing install procedure: Poetry should be installed first and then pre-commint would follow.
"git clone https://github.com/undp/seleniumprobes.git SeleniumProbes
cd SeleniumProbes
pre-commit install
poetry install"

Include "pyenve" installation in ~/.bashrc, verifying virtual environment persistent installation.

@cyberladysj, thanks for spotting the doc error!
Also, the third step of the Managing Virtual Environments section of CONTRIBUTING.md mentions that .bashrc should be edited for pyenv to engage automatically. So, does this address your second bullet point or you meant something else?

Yes, editing .bashrc for pyenve to engage automatically addresses my second bullet point. Thank you


AuthorizationPolicy unexpected behavior

I am trying to understand the functionality of AuthorizationPolicy object. This policy should allow requests from service account foo to service demo, and deny all other requests in the namespace istio right?
apiVersion: security.istio.io/v1beta1
kind: AuthorizationPolicy
metadata:
  name: demo
  namespace: istio
spec:
  action: ALLOW
  rules:
  - from:
    - source:
        principals: ["cluster.local/ns/istio/sa/foo"]
  - to:
    - operation:
        hosts: ["demo.istio"]

It does deny all requests to all other services in istio namespace, but it also allows requests to demo service from any service account. It is like from section doesn't get applied at all.
Do I have to do anything with the service account permissions?
This is a request from a service with the default service account.
$ kubectl exec -it curler -- curl -I demo.istio
Defaulting container name to curler.
Use 'kubectl describe pod/curler -n default' to see all of the containers in this pod.
HTTP/1.1 200 OK
server: envoy
date: Sun, 14 Jun 2020 14:00:07 GMT
content-type: text/html
content-length: 612
last-modified: Tue, 26 May 2020 15:00:20 GMT
etag: "5ecd2f04-264"
accept-ranges: bytes
x-envoy-upstream-service-time: 2

The same request to a different service fails, as expected
$ kubectl exec -it curler -- curl -I demo2.istio
Defaulting container name to curler.
Use 'kubectl describe pod/curler -n default' to see all of the containers in this pod.
HTTP/1.1 403 Forbidden
content-length: 19
content-type: text/plain
date: Sun, 14 Jun 2020 14:06:02 GMT
server: envoy
x-envoy-upstream-service-time: 15

Note: The curler service is within the mesh.

I can't tell reason by looking at the config. Seems legit. But I am very confident this basic feature should work by istio as well...

Do you have any other policies that might interfere with results?
/cc @yangminzhu

there is not much really. mTLS was set to PERMISSIVE but automTLS was set to true. In the requests above it doesn't appear the request to be plain text. I set it now to STRICT, but still am able to reach the service. There are no other authorization policies.
Im using Istio 1.6.
$ kubectl get peerauthentication --all-namespaces
NAMESPACE      NAME                          AGE
istio-system   default                       4m20s
istio-system   grafana-ports-mtls-disabled   14d
$ kubectl get authorizationpolicy --all-namespaces
NAMESPACE   NAME   AGE
istio       demo   45h
$ kubectl get po curler -oyaml | grep -i serviceaccount:
  serviceAccount: default
$ kubectl exec -it curler -- curl -I demo.istio
Defaulting container name to curler.
Use 'kubectl describe pod/curler -n default' to see all of the containers in this pod.
HTTP/1.1 200 OK
server: envoy
date: Tue, 16 Jun 2020 10:21:54 GMT
content-type: text/html
content-length: 612
last-modified: Tue, 26 May 2020 15:00:20 GMT
etag: "5ecd2f04-264"
accept-ranges: bytes
x-envoy-upstream-service-time: 2

I created another AuthorizationPolicy object explicitly denying the requests from the default service account; in the namespace istio, and now it works.
$ kubectl get authorizationpolicy -n istio
NAME              AGE
demo              45h
deny-deafult-sa   2m40s
$ kubectl exec -it curler -- curl -I demo.istio
Defaulting container name to curler.
Use 'kubectl describe pod/curler -n default' to see all of the containers in this pod.
HTTP/1.1 403 Forbidden
content-length: 19
content-type: text/plain
date: Tue, 16 Jun 2020 10:36:59 GMT
server: envoy
x-envoy-upstream-service-time: 0

I though with the first one only was enough, as from the following doc:
If there are any DENY policies that match the request, deny the request.
If there are no ALLOW policies for the workload, allow the request.
If any of the ALLOW policies match the request, allow the request.
Deny the request.
Can you please explain the rules above?

  rules:
  - from:
    - source:
        principals: ["cluster.local/ns/istio/sa/foo"]
  - to:
    - operation:
        hosts: ["demo.istio"]

This has 2 rules, the 1st rule allows all requests from principal cluster.local/ns/istio/sa/foo, the 2nd rule allows all requests to hosts demo.istio.

Aha, good catch! Missed the - before to.

Oh! ok, that makes sense. It works now. Thank you!
Since we are here already, I'd like to confirm couple of things with this rule as an example:
apiVersion: security.istio.io/v1beta1
kind: AuthorizationPolicy
metadata:
  name: demo
  namespace: istio
spec:
  action: ALLOW
  rules:
  - from:
    - source:
        principals:
        - cluster.local/ns/istio/sa/foo
    to:
    - operation:
        hosts:
        - demo.istio

1.- It will allow that condition and deny everything else in the namespace. Is this statement correct?
Say, if I have lots of service accounts across the cluster (and there is one; foo in istio namespace) and several services (demo, demo1, .., demo100) in namespace istio. Once I create the rule above, it will allow requests from any pod in the namespace istio with service account foo to the service demo, and it will deny any other request from any pod, in any namespace with any service account to the services demo1 to demo100. Am I right? I mean I do not need to create the DENY rule explicitly right?
2.- I realize it allows ONLY request to demo.istio, but it denies requests to demo from the same namespace and demo.istio.svc.slucter.local. All requests done from the same pod (with service account foo). I do succeed if I pass istio.demo header to the request, so I guess it just checks the header. Am I right?

1.- It will allow that condition and deny everything else in the namespace. Is this statement correct?

This is correct.

Say, if I have lots of service accounts across the cluster (and there is one; foo in istio namespace) and several services (demo, demo1, .., demo100) in namespace istio. Once I create the rule above, it will allow requests from any pod in the namespace istio with service account foo to the service demo, and it will deny any other request from any pod, in any namespace with any service account to the services demo1 to demo100. Am I right? I mean I do not need to create the DENY rule explicitly right?

Yes, this is correct. As long as your have at least 1 ALLOW policy, it means any requests not specified in the ALLOW policy will be denied by default.

2.- I realize it allows ONLY request to demo.istio, but it denies requests to demo from the same namespace and demo.istio.svc.slucter.local. All requests done from the same pod (with service account foo). I do succeed if I pass istio.demo header to the request, so I guess it just checks the header. Am I right?

yes, the hosts field is checking the header, you can also use prefix matching demo.istio.* or just add demo.istio.svc.slucter.local to the list.

do we have any update for this issue?

please reopen if you have more questions.


Not using ModifyScript tool as intended

it has been reported that SkillRetrieval tool is frequently chosen over ModifyScript tool even though both are very different tools. The user goal is to modify simulation script.

Not quite relevant anymore after CreateNewTool removal


App crashing with fill property on SVG

Bug
Hello,
When I run the application with react-native run-android everything goes well, but when I try to generate an apk for testing as soon as I open some screen with the SVG (that contains the fill property) it crashes.

I ran it with the adb logcat and this is the error message I'm getting:
E/AndroidRuntime( 5567): java.lang.IllegalStateException: java.lang.NoSuchFieldException: fill
E/AndroidRuntime( 5567): 	at com.horcrux.svg.t.a(Unknown Source)
E/AndroidRuntime( 5567): 	at com.horcrux.svg.j.b(Unknown Source)
E/AndroidRuntime( 5567): 	at com.horcrux.svg.j.a(Unknown Source)
E/AndroidRuntime( 5567): 	at com.horcrux.svg.t.d(Unknown Source)
E/AndroidRuntime( 5567): 	at com.horcrux.svg.x.a(Unknown Source)
E/AndroidRuntime( 5567): 	at com.horcrux.svg.x.j(Unknown Source)
E/AndroidRuntime( 5567): 	at com.horcrux.svg.x.onDraw(Unknown Source)

Environment info

React native info output:
  React Native Environment Info:
    System:
      OS: Linux 5.0 Ubuntu 19.04 (Disco Dingo)
      CPU: (4) x64 Intel(R) Core(TM) i7-2640M CPU @ 2.80GHz
      Memory: 133.89 MB / 7.70 GB
      Shell: 5.5.1 - /usr/bin/zsh
    Binaries:
      Node: 10.15.2 - /usr/bin/node
      npm: 6.10.1 - /usr/local/bin/npm
    SDKs:
      Android SDK:
        API Levels: 23, 28, 29
        Build Tools: 28.0.3, 29.0.0
        System Images: android-21 | Google APIs Intel x86 Atom, android-22 | Google APIs Intel x86 Atom, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom, android-29 | Google APIs Intel x86 Atom, android-29 | Google Play Intel x86 Atom
    npmPackages:
      react: 16.8.3 => 16.8.3
      react-native: 0.59.10 => 0.59.10
    npmGlobalPackages:
      react-native-cli: 2.0.1

Library version: 9.5.3
I initially installed the version 9.5.1, and upgraded to try to solve this problem but it didn't
Steps To Reproduce

Generate an apk with assembleRelease
Open the app
...

Describe what you expected to happen:

Run without crashing

Reproducible sample code
This is the SVG making the app crash (if I remove the fill prop and build my apk it runs normally)
<Svg fill="#f09e3e" height="64px" viewBox="-4 0<PHONE_NUMBER>3" width="64px">
    <Path d="m184 288h16v16h-16zm0 0" />
    <Path d="m136 288h16v16h-16zm0 0" />
    <Path d="m88 288h16v16h-16zm0 0" />
    <Path d="m232 288h16v16h-16zm0 0" />
    <Path d="m224 160h16.574219l4.25 56.601562 15.953125-1.203124-4.152344-55.398438h174.75l-22.800781 304h-56.574219v16h64c4.195312.011719 7.683594-3.21875 8-7.398438l23.425781-312.601562h16.574219c4.417969 0 8-3.582031 8-8v-40c0-4.417969-3.582031-8-8-8h-96v-96c0-4.417969-3.582031-8-8-8h-32c-4.417969 0-8 3.582031-8 8v96h-96c-4.417969 0-8 3.582031-8 8v40c0 4.417969 3.582031 8 8 8zm112-144h16v88h-16zm-104 104h224v24h-224zm0 0" />
    <Path d="m40 480h256c22.082031-.027344 39.972656-17.917969 40-40v-32c0-4.417969-3.582031-8-8-8h-.207031c10.941406-14.128906 10.941406-33.871094 0-48h.207031c4.417969 0 8-3.582031 8-8 .011719-31.625-12.503906-61.972656-34.808594-84.390625l-2.917968-44.136719-16 1.054688 1.910156 28.863281c-20.007813-13.929687-43.804688-21.394531-68.183594-21.390625h-96c-66.242188.074219-119.9257812 53.757812-120 120 0 4.417969 3.582031 8 8 8h.207031c-10.941406 14.128906-10.941406 33.871094 0 48h-.207031c-4.417969 0-8 3.582031-8 8v32c.0273438 22.082031 17.917969 39.972656 40 40zm280-40c0 13.253906-10.746094 24-24 24h-256c-13.253906 0-24-10.746094-24-24v-24h304zm-79.398438-40 63.796876-46.398438c10.875 4.042969 17.285156 15.296876 15.21875 26.714844-2.066407 11.414063-12.015626 19.707032-23.617188 19.683594zm-24.800781-1.742188-69.402343-46.257812h133zm-95.800781-158.257812h96c54.3125.0625 99.453125 41.855469 103.695312 96h-303.390624c4.242187-54.144531 49.386718-95.9375 103.695312-96zm-104 136c0-13.253906 10.746094-24 24-24h77.601562l72 48h-149.601562c-13.253906 0-24-10.746094-24-24zm0 0" />
    <Path d="m208 256h16v16h-16zm0 0" />
    <Path d="m160 256h16v16h-16zm0 0" />
    <Path d="m112 256h16v16h-16zm0 0" />
    <Path d="m280.019531 184.566406 15.960938-1.140625 1.144531 16-15.960938 1.140625zm0 0" />
  </Svg>

You have to add:
-keep public class com.horcrux.svg.** {*;}

in proguard-rules.pro (app)

You have to add:
-keep public class com.horcrux.svg.** {*;}

in proguard-rules.pro (app)

This solved the problem, thank you!

You have to add:
-keep public class com.horcrux.svg.** {*;}

in proguard-rules.pro (app)

save my life

You have to add:
-keep public class com.horcrux.svg.** {*;}

in proguard-rules.pro (app)

Tks you so much ^^

You have to add:
-keep public class com.horcrux.svg.** {*;}

in proguard-rules.pro (app)

thanks a lot ..
just to clarify the path.. it's android/app/proguard-rules.pro

You have to add:
-keep public class com.horcrux.svg.** {*;}

in proguard-rules.pro (app)

It's work! Tks! 🚀

Great, it works like a charm 👍

-keep public class com.horcrux.svg.** {*;}

thanks. It worked.

You have to add:
-keep public class com.horcrux.svg.** {*;}

in proguard-rules.pro (app)

after adding this crash is gone but i got
Execution failed for task ':app:transformClassesAndResourcesWithProguardForRelease'.
java.io.FileNotFoundException: ......android/app/keep public class com.horcrux.svg.** {* (No such file or directory)
error in release mode.

thanks @fgagneten It worked for me.

You have to add:
-keep public class com.horcrux.svg.** {*;}

in proguard-rules.pro (app)

It's 2021 you have safe my life.

You have to add:
-keep public class com.horcrux.svg.** {*;}

in proguard-rules.pro (app)

save my life

My life also dude :)

It  needs patience and tears— you still have saved my life, thank you dude!

 Thanks dude!

This is a lifesaver!!

You have to add:
-keep public class com.horcrux.svg.** {*;}

in proguard-rules.pro (app)

This solved the problem, thank you!

Worked for me!!!

It's almost 2023 and this saved my life as well.

You have to add:
-keep public class com.horcrux.svg.** {*;}

in proguard-rules.pro (app)

It's mid 2022 and you saved another soul :) thanks a ton!

you saved my entire life, spent dozen of hours trying to get a solution for this, thanks

please how do you solve this issue in Expo managed workflow?

You have to add:
-keep public class com.horcrux.svg.** {*;}

in proguard-rules.pro (app)

thanks a lot .. just to clarify the path.. it's android/app/proguard-rules.pro

After employing this the app worked fine on actual devices (Galaxy M02 and XIAOMI MI A2). But the crashes persist on the emulator (Pixel 4).

You have to add:
-keep public class com.horcrux.svg.** {*;}

in proguard-rules.pro (app)

Saved my life too. :) 👍

Saved my life too. :)  :*

You have to add:
-keep public class com.horcrux.svg.** {*;}

in proguard-rules.pro (app)

This solved mine 2022 still worked hurray

Oh my gosh! Nice! It worked very well!

@drb1 have you managed to solve this error? I've got the same error after adding the --keep public class com.horcrux.svg

@drb1 have you managed to solve this error? I've got the same error after adding the --keep public class com.horcrux.svg

Have you resolve your problem, I have the same error

Saved my life Feb 2023 🚀

@MuhammadAbdullah54321 said

Suggested solution worked like charm .... had to spend a lot of time on it.
Just in case if anyone else is still facing same issue and is using some other libraries as well :: I had to to include all these other rules as well to make it work
-keep class com.swmansion.reanimated.** { ; }
-keep class com.facebook.hermes.unicode.* { ; }
-keep class com.facebook.jni.* { ; }
-keep class com.facebook.react.turbomodule.* { ; }
-keep public class com.horcrux.svg.* {*;}

This is very interesting, but how did you identify all the libraries that were needed?

Save me. Just curious why in the document not mention this :(

My app uses vis.js in WebView.
It was crashing for this reason on one mobile(Samsung M31, Android 12) but on other phones, it worked well.
On adding this in proguard-rules.pro, it stopped crashing in that mobile but it became very slow in drawing vis.js network diagrams. But in other mobiles, it runs pretty smooth.
Any ideas on why this happened?

For anyone using expo, add this to your app.config.js/app.json:
  'expo': {
    'plugins': [
      [
        'expo-build-properties',
        {
          'android': {
            'enableProguardInReleaseBuilds': true,
            'extraProguardRules': '-keep public class com.horcrux.svg.** {*;}'
          }
        }
      ]
    ],
  }

You have to add:
-keep public class com.horcrux.svg.** {*;}

in proguard-rules.pro (app)

One line that saves. Thanks!

For anyone using expo, add this to your app.config.js/app.json:
  'expo': {
    'plugins': [
      [
        'expo-build-properties',
        {
          'android': {
            'enableProguardInReleaseBuilds': true,
            'extraProguardRules': '-keep public class com.horcrux.svg.**  Tks a lot

You have to add:
-keep public class com.horcrux.svg.** {*;}

in proguard-rules.pro (app)

Thanks for the answer it helps me lot.....


Prevent build failures on downstream dependencies due to changes in upstream

Is your feature request related to a problem? Please describe.
If annotator processes the target module with --downstream-dependency-analysis-activated flag, it will collects effects of making public methods @Nullable on downstream dependencies and considers the overall effect while making inference decisions. Some annotations can reduce the number of errors locally far more than the number of triggered errors on downstream dependencies and can have a positive overall impact, hence, these  annotations will get injected to the target module (even though this will lead to build errors on downstream dependencies).
It is a common use case where the user would like to run the AutoAnnotator on target module with following constraints:

No modification on downstream dependencies is allowed.
No build failures on downstream dependencies after enrolling the target module.

Describe the solution you'd like
A configuration mode which if enabled, it guarantees that no changes in upstream will trigger an error on downstream dependencies. This should also cover detection of flow of @Nullable back to upstream. See example below:
Target Module:
class Foo{

     public Object returnNullBad(){
              // Assume there are 5 branches ending with return null;
              return null;
     }

     public Object returnNullGood(){
              // Assume there are 5 branches ending with return null;
              return null;
     }

     public void takeNullGood(Object param){ // Called only in downstream dependencies.
              if(param != null){
                     param.deref();
              }
     }

     public void takeNullBad(Object){ // Called only in downstream dependencies.
             param.deref();
     }
}

Downstream Dependency Module:
class Dep{

     Object field = new Object();
     Foo foo = new Foo();

     public void bar(){
             field = foo.returnNullBad();
             foo.takeNullGood(foo.returnNullBad());
             foo.takeNullGood(foo.returnNullGood());
             foo.takeNullBad(foo.returnNullGood());
     }
}

If Annotator only focus on the overall impact, it will annotate the Target module as below:
class Foo{

     @Nullable   // This will resolve 5 errors locally and triggers 1 unresolvable and 1 resolvable error (on Dep) overall: -4
     public Object returnNullBad(){
              // Assume there are 5 branches ending with return null;
              return null;
     }

     @Nullable // This will resolve 5 errors locally and 1 resolvable error (change on Target) overall: -5
     public Object returnNullGood(){
              // Assume there are 5 branches ending with return null;
              return null;
     }

     // This will resolve 1 error on downstream dependency and create no error locally
     public void takeNullGood(@Nullable Object param){ // Called only in downstream dependencies.
              if(param != null){
                     param.deref();
              }
     }

     // Since @Nullable injection will create an error locally and the overall is +1,
     // it will not get injected, however, this will leave the error on downstream unresolved.
     public void takeNullBad(Object){ // Called only in downstream dependencies.
             param.deref();
     }
}

With the requested configuration mode, annotator should annotate Target module as below:
class Foo{

     @NullUnmarked //To resolve the error on downstream dependency.
     public Object returnNullBad(){
              // Assume there are 5 branches ending with return null;
              return null;
     }

     @Nullable
     public Object returnNullGood(){
              // Assume there are 5 branches ending with return null;
              return null;
     }

     public void takeNullGood(@Nullable Object param){ // Called only in downstream dependencies.
              if(param != null){
                     param.deref();
              }
     }

     @NullUnmarked //To resolve the error on downstream dependency.
     public void takeNullBad(Object){ // Called only in downstream dependencies.
             param.deref();
     }
}

Describe alternatives you've considered
None.
Additional context
Not-Applicable.

This will feature will be supported with guarantees that no errors will trigger on downstream dependencies without injection of @NullUnmarked annotations on target, that will be implemented in future PRs.
For now the output will be below:
class Foo{

     public Object returnNullBad(){
              // Assume there are 5 branches ending with return null;
              return null;
     }

     @Nullable
     public Object returnNullGood(){
              // Assume there are 5 branches ending with return null;
              return null;
     }

     public void takeNullGood(@Nullable Object param){ // Called only in downstream dependencies.
              if(param != null){
                     param.deref();
              }
     }

     //To resolve the error on downstream dependency.
     public void takeNullBad(@Nullable Object){ // Called only in downstream dependencies.
             param.deref();
     }
}

Update
The alternative approach here is that Annotator treat all impacted parameters as triggered fixes when applying a fix tree, hence, either all impacted parameters will be @Nullable or none will get annotated. This explicitly in favor of Strict mode.


[MCOMPILER-550] make outputDirectory writeable

add more documentation when and how to use it (and when to not use it)
fixes MCOMPILER-550

Following this checklist to help us incorporate your
contribution quickly and easily:

[X] Make sure there is a JIRA issue filed
for the change (usually before you start working on it).  Trivial changes like typos do not
require a JIRA issue.  Your pull request should address just this issue, without
pulling in other changes.
[X] Each commit in the pull request should have a meaningful subject line and body.
[X] Format the pull request title like [MCOMPILER-550] - Fixes bug in ApproximateQuantiles,
where you replace MCOMPILER-XXX with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
[X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[X] Run mvn clean verify to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
[X] You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

[X] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

[X] In any other case, please file an Apache Individual Contributor License Agreement.

I think the same change should Apple to the test compile mono.
@bmarwell

I think the same change should apply to the test compile mono. @bmarwell

Can do, just left it out because I couldn't think of a use case I could have added to the documentation.

Suggestion for link:
While the javadoc-link in the  text will render as code in the docs, the @see link works nicely.

Will render to:


you able to create a tool which can download books in preview from hoepli?

for example, these two:
https://copertine.hoepli.it/hoepliscuola/Camagni,-Informatica-e-Applicazioni-vol.-4---Hoepli/index.html
https://copertine.hoepli.it/hoepliscuola/1548-Lughezzani_Clippy_Cloud_Plus_Programmazione/index.html

I think I can do that. But it's time-consuming because it's not trivial. Get in touch by email if you're interested.


fix: fix sms content item sequencing logic

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

23 of 23 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2205

Relevant Lines:
2205

💛  - Coveralls


drafts: Style enhancements.

GIFs or Screenshots:

I merged all but the last commit, thanks @vrongmeal!  This does look a lot nicer.  We can merge the last commit tomorrow.

Here's the new look:

@timabbott The first commit can be merged. The next two are some UI changes that still need approval.

This looks good, merged, thanks @vrongmeal!

(I went back and forth on the left border, but it doesn't look good with the blue box surrounding the recipient area)


KryptonRibbon disappears

Does anyone have a problem with the ribbons disappearing every time you minimize or maximize your form? Has anyone used the Resize event to redraw it or somehow get it back?

That sounds strange. I've got a pretty active project going with ribbon on it and I've never had that issue.
A few questions...

What version of the toolkit are you using?
Is your form inheriting from KryptonForm?
Is your KryptonRibbon a direct child of the form? (i.e. not on Panel)
You said "ribbons" -- do you have more than one on a form?

The version is 5.460.592.0
Yes, the form is inheriting KryptonForm.
The KryptonForm is loaded on to a panel (panel is on a kryptonWorkspace), is this the reason why it's disappearing? Any other control I use is fine, but the KryptonRibbon, in particular, will just disappear and hide, so if you don't have a maximize button then you'll never see it.
I've tried to use Resize event to show/hide, invalidate, refresh this Ribbon but no luck.

You should only ever use the KryptonRibbon at a top level window, it will
not work correctly with an embedded form/panel or other control.
On Wed, Oct 10, 2018 at 1:30 PM quangas<EMAIL_ADDRESS>wrote:

The version is 5.460.592.0
Yes, the form is inheriting KryptonForm.
The KryptonForm is loaded on to a panel (panel is on a kryptonWorkspace),
is this the reason why it's disappearing? Any other control I use is fine,
but the KryptonRibbon, in particular, will just disappear and hide, so if
you don't have a maximize button then you'll never see it.
I've tried to use Resize event to show/hide, invalidate, refresh this
Ribbon but no luck.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ComponentFactory/Krypton/issues/159#issuecomment-428416883,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANVz8KlNRu65GD17wkTE-PBT1DySD63uks5ujVvDgaJpZM4XTdyz
.

--
Regards
Phil Wright
<EMAIL_ADDRESS>

Hi @quangas
You can't use a KryptonRibbon in a KryptonPanel like you can with any other control. Instead, the KryptonRibbon must be placed directly on the form in order to achieve the desired outcome.

I was hoping to use it as a menu bar on my embedded forms but now know what its limitations are. Thanks guys.


[carry 23352] update peaceful zen

This carries https://github.com/docker/docker/pull/23352, which was now signed-off, but needed a rebase and squash
closes https://github.com/docker/docker/pull/23352

LGTM


Feature request to expose makeTransform and

Hello,
AngularCompilerPlugin allows users to create custom TypeScript transformers. Here is options: https://github.com/angular/angular-cli/blob/master/packages/ngtools/webpack/src/interfaces.ts#L66
I was playing with transformers and approach that plugin uses internally looks very handy.
I think it would be nice to expose this API to users.
I mean exposing:
makeTransform
AddNodeOperation
RemoveNodeOperation
ReplaceNodeOperation
StandardTransform

If you don't mind, I can make a PR.

Hi @sharikovvladislav, thanks for your interest. I'll put this up for discussion in our next team meeting.

@alan-agius4 Thank you very much!

Hm. Actually... Only platformTransformers are public API. Not transformers.
Is there any reason for it? Like you don't really want framework users to use transformers or something?

Sorry - These methods are not polished enough to be public and it's difficult to maintain them without breaking. They probably will also go away in the next release. So we are not able to make these public.

Thank you @vikerman


CSV support request

Could you please add support to create the table from csv data? Or even better a setting to use possible delimiters regex.

@T3sT3ro Thank ypu for your feedback.
It is not difficult.
But I'm careful to adding one more context menu.
Because this extension already has so many menus that it is nearly out of screen.
F.Y.I.
There are good extensions for convert csv to md table in marketplace.

Would it be possible to detect the delimiter based on the current language mode (document. languageId) VS code is in, and fall back to origin tsv parsing when detection fails?
I found Rainbow CSV to support similar feature: https://github.com/mechatroner/vscode_rainbow_csv/tree/b5b423d8904b2a8f687c6ca4857dccf2d5c9917e#supported-separators.
In this way, there is no need to add more item to the context menu. Users needing for conversion can simply open a new editor tab, paste the TSV/CSV content, set the desired language mode that matches the delimiter and invoke TSV to table of this extension.

Resolved in 0.11.0


Add the Kovan Testnet to the list of Optimism feeds.

Add Ethereum Kovan to networks.ts to include the Kovan Testnet to the list of Optimism feeds.

The Netlify stating link won't show the change because it hasn't regenerated the addresses.json file on the server side, but I tested it locally.

LGTM. One question, do we have any faucet for Kovan Optimism that we can add here?


Add output file to the podspec

I am trying to build my react native project which uses react native config on MS Appcenter.
It gives me an error
error: Build input file cannot be found: '/Users/runner/work/1/s/node_modules/react-native-config/ios/ReactNativeConfig/GeneratedDotEnv.m' (in target 'react-native-config' from project 'Pods')
The reason it gives this error is that even though the ruby script is executed this file is not added to the xcode project as the output file is not marked for this to work we must update the pospec like the following
output_files: ['$PODS_TARGET_SRCROOT/ios/ReactNativeConfig/GeneratedDotEnv.m']
after the input line
input_files: ['$PODS_TARGET_SRCROOT/ios/ReactNativeConfig/BuildDotenvConfig.rb'],

Is this the same issue I'm seeing where we need to uninstall and then reinstall this library after every unrelated pod change, or appcenter will give this same error? Reinstalling react-native-config after other pod changes seems to be a workaround for now at least.

https://github.com/luggit/react-native-config/pull/699

Fixed in 1.4.12

@luancurti the update (1.4.12) is working for me.


How union two UIBezierPath together

How union two UIBezierPath together using your framework?

There's not an explicit union method. You can try using intersectionWithPath: and differenceWithPath: to build the union.
UIBezierPath* pathA;
UIBezierPath* pathB;

UIBezierPath* intersection = [pathA intersectionWithPath:pathB];
UIBezierPath* diffL = [pathA differenceWithPath:pathB];
UIBezierPath* diffR = [pathB differenceWithPath:pathA];

UIBezierPath* union = [UIBezierPath bezierPath];
[union appendPath:intersection];
[union appendPath:diffL];
[union appendPath:diffR];

I think that'll do roughly want you want, though it'll have path lins at the intersections of the two paths instead of a smooth union. stroked path would look odd, but filled path would be ok I believe.

I found the union path method in the latest library, but an error result is returned.
UIBezierPath *pathA = [UIBezierPath bezierPath];
[pathA addArcWithCenter:CGPointMake(100, 100) radius:100 startAngle:0 endAngle:M_PI*2 clockwise:YES];
[pathA closePath];

UIBezierPath *pathB = [UIBezierPath bezierPath];
[pathB addArcWithCenter:CGPointMake(100, 102) radius:100 startAngle:0 endAngle:M_PI*2 clockwise:YES];
[pathB closePath];

NSArray *result = [pathA unionWithPath:pathB];

I found the union path method in the latest library, but an error result is returned.
UIBezierPath *pathA = [UIBezierPath bezierPath];
[pathA addArcWithCenter:CGPointMake(100, 100) radius:100 startAngle:0 endAngle:M_PI*2 clockwise:YES];
[pathA closePath];

UIBezierPath *pathB = [UIBezierPath bezierPath];
[pathB addArcWithCenter:CGPointMake(100, 102) radius:100 startAngle:0 endAngle:M_PI*2 clockwise:YES];
[pathB closePath];

NSArray *result = [pathA unionWithPath:pathB];

@adamwulf

Unfortunately there's some problems with paths that have very close derivatives. these two circles meet at almost tange points, and i suspect that's some of the issue. does it return the correct results if the two circles are further apart so that they're intersections have a wider angle?

@ArtMartiros @Adenc
Maybe this repo can solve the issue.


Added Data Analysis with Python and PySpark

Hi,
Stjepan from Manning here. I thought this title might be good match to your list. Thank you for considering it.
Best,

Duplicate of #192


themes made hideous

I'm not sure why, but the Bootswatch themes have been heavily modified to use all the gaudy colours.
These were tasteful themes.
It's not simply possible to restore a theme to its original Bootswatch code, as significant docstrap features go missing in the process.
Two questions:

Why?
How do I revert them to the tasteful colours they came with originally without breaking docstrap?

Is it possible that these themes were just genuinely ugly before bootstrap 3?
I'm referencing the current versions visible at https://bootswatch.com/  I realise now may not match the version of bootstrap used in dosctrap.

Not sure what you are seeing, but this is what they look like:

Amelia
Cerulean
Cosmo
Cyborg
Flatly
Journal
Readable
Simplex
Slate
Spacelab
Spruce
Superhero
United

Yes, that's what they look like in docstrap.  But lets take the original bootswatch versions and compare:
In docstrap the menus are solid filled instead of white, and all the headings are in gaudy colours instead of the standard colours in the bootswatch versions.
I realise there's a setting for the navbar inversion, but it doesn't stop the menus being filled, and I can't see away to avoid hypercolourised titles etc.
docstrap: Flatly
bootswatch Flatly
docstrap: Cosmo
bootswatch Cosmo

Take a look at conf.json What you are seeing are the inverse nav colors, which are legit bootstrap classes. If you don't like them change this in conf.json
inverseNav Bootstrap navbars come in two flavors, regular and inverse where inverse is generally higher contrast. Set this to true to use the inverse header.

As per my previous comment above "I realise there's a setting for the navbar inversion, but it doesn't stop the menus being filled, and I can't see away to avoid hypercolourised titles etc."
Yes. I have used the inverseNav setting in conf.json. All it does is prevent the class "navbar-inverse" from being added to the navbar.  Everything else stays the same. The menus are still dark-filled, and the headings are still coloured.

All styling happens in the templates for the various visual components and you can modify it to meet your needs. docstrap was designed to be high contrast and not intended to address everyone's aesthetic sense.  A PR would be welcomed.

Thanks. Hideous was a strong word and I feel quite bad about it. Comes across as plain rude. Sorry about that and thanks for responding. I'm finding my way around the templates slowly :)


Dictionary migrations

Is there a way to migrate data to dictionary too? Before I reset my meteor project, I ran mongoDB, command: "db.dictionary.find()" and copy&paste output to txt file. Then I reset my project (data was deleted) and now, I want to migrate that copied output back to project, instead of writing same definitions over and over again when I reset project?
Dictionary.insert...returns error (Dictionary is not defined)

Dictionary is a collection with a single entry. You can populate it either by using defaultValue like so:
# Stop subscription
orion.dictionary.addDefinition 'endSubscription', 'settings',
  type: Boolean, label: 'Stop subscriptions'
  defaultValue: false

Or, server side only, by directly taping into the collection like so:
if Meteor.isServer
  dicId = (orion.dictionary.findOne())._id
  orion.dictionary.update dicId, {'$set': headValues} , (err) ->
    return appLog.error "Dictionnary update failed: #{err}" if err
    appLog.info 'Default site description created or updated'


Serialization refactor: add new serialization traits

Sub-task of #463.
Let's use the convention introduced in the not-yet-done deserialization refactor and let's name the new traits SerializeCql and SerializeRow:
pub trait SerializeRow {
    fn serialize(&self, ctx: &RowSerializationContext<'_>, out: &mut impl std::io::Write) -> Result<(), std::io::Error>;
}

pub trait SerializeCql {
    fn serialize(&self, typ: &CqlType, out: &mut impl std::io::Write) -> Result<(), std::io::Error>;
}

Instead of std::io::Write, perhaps we could use a different trait that abstracts away appending data to a buffer (bytes::BufMut?). Using a trait instead of e.g. &mut Vec<u8> will let us to very easily implement size hints like here: https://github.com/scylladb/scylla-rust-driver/pull/582 based on the existing serialize() method.
The RowSerializationContext should contain information about the bind markers: column names and their types. Later, we may add more stuff there.
As this change will affect all Session::query and Session::execute calls which should be ubiquitous in the user codebase, we should make it as easy as possible to migrate to the new API, preferably step by step.
Current serialization API is heavily based on SerializedValues type which is an untyped container for serialized values. Session::{execute,query} receive the argument list as an impl ValueList type - which is just a trait that allows to convert the type to SerializedValues. In general, we should implement SerializeRow for each type that implements ValueList, which also includes SerializedValues.

Calls like session.execute(&prepared, (1, 2, 3)) should work automatically out of the box as we will implement SerializeRow for types that implement SerializedValues, and SerializeCql for types that implement Value. This should be the most common case.
In a generic context like session.execute(&prepared, generic_list) where generic_list: impl ValueList, the piece of code should be adjusted so that generic_list.serialized()? is called instead - which will convert to SerializedValues which does implement the new SerializedRow.
For the case of user impls of ValueList and Value, we can provide macros (not necessarily procedural) that generate a SerializedRow/SerializedCql implementation based on the existing ValueList/Value.

It will be necessary to update some examples and documentation, but I don't expect it to be much work compared to the deserialization refactor.

The issue https://github.com/scylladb/scylla-rust-driver/issues/802 depends on the SerializeRow and SerializeCql traits introduced by this task. I think just those traits + impls of 2-3 trivial types should be added first, in a separate PR in order to unblock it.

Definitions of the traits have been merged to main (https://github.com/scylladb/scylla-rust-driver/pull/819). To complete the task, we further need to:

Implement the new traits for the existing types that support Value and ValueList (except for macros for UDTs, those are covered in #802) - can be split over several PRs if needed,
Adjust the codebase to use the new serialization traits instead of the old ones (Session::query, Session::execute, _iter versions, etc.).

This was done, in many PRs:
https://github.com/scylladb/scylla-rust-driver/pull/887
https://github.com/scylladb/scylla-rust-driver/pull/881
https://github.com/scylladb/scylla-rust-driver/pull/880
https://github.com/scylladb/scylla-rust-driver/pull/878
https://github.com/scylladb/scylla-rust-driver/pull/871
https://github.com/scylladb/scylla-rust-driver/pull/870 (succeeded by https://github.com/scylladb/scylla-rust-driver/pull/881)
https://github.com/scylladb/scylla-rust-driver/pull/869
https://github.com/scylladb/scylla-rust-driver/pull/862
https://github.com/scylladb/scylla-rust-driver/pull/858
https://github.com/scylladb/scylla-rust-driver/pull/855
https://github.com/scylladb/scylla-rust-driver/pull/851
https://github.com/scylladb/scylla-rust-driver/pull/819


internal/restorable: checking whether a texture is live doesn't work

https://registry.khronos.org/OpenGL-Refpages/es3.0/html/glIsTexture.xhtml

A name returned by glGenTextures, but not yet associated with a texture by calling glBindTexture, is not the name of a texture.

So, glIsTexture returns false for  a unbound texture unfortunately.
This is not an actual issue as this logic is not used anywhere. For Android, canDetectContextLostExplicitly is true. For iOS, Metal should be used. For browsers, Ebitengine no longer detects context lost. This is an issue for #292.

I'm experimenting GLES on Linux desktops, but isInvalidated always returns true. Binding the texture before IsTexture didn't work. This is pretty odd..

https://registry.khronos.org/OpenGL/extensions/EXT/EXT_robustness.txt

Ahh, the true problem is that (*graphicscommand.Image).IsInvalidated is not concurrent-safe!


NavigationExtras with RouterExtensions + clearHistory?

I want to pass the data to another page while navigating. for that, I was using
this.router.navigate(["/SignatureOptionVC"], navigationExtras);
But then, I needed to clear the back-stack/history as well, so I found that I can navigate through
RouterExtensions with clearHistory: true flag. But it seems it doesn't support navigationExtras.
Is there any way I can clear history + pass navigationExtras?

Hi @sam0829
You can pass navigation options like this:
this.routerExtensions.navigate(["/first"], {
    clearHistory: true,
    transition: {
        name: "flip",
        duration: 2000,
        curve: "linear"
    }
});

More about navigation option in NG+Angular-2 here

@NickIliev thanks for your quick reply, I'll try this & close the question. Thanks again :)

@NickIliev I want to pass data from one screen to another while using routerExtensions.navigate()
If I looked correct, then it only supports following :
 clearHistory?: boolean;     animated?: boolean;     transition?: NavigationTransition;
But I want clearHistory + data passing.
Is there any way to achieve this using routerExtensions?
because my main problem is I want to cleat the back stack while navigating & at the same time I want to pass the data to the page I am navigating

@sam0829 passing context within pages differs from vanilla NativeScript.
Here you can find the documentation article about passing parameters and here you can find a sample which is using the native API but the logic is the same with the wrapped PageRoute instead of the @angular ActivatedRoute


Query builder search method

Details
Adding a search method to the query class.
The method takes two arguments, the field to search on and the string to search for.
This method aims to simplify the query class and removes the need for manual filters to be added, as it is already implied.
Example use
$user = [ 'Username' =><EMAIL_ADDRESS>'Password' => '1234', ..., ... ];

DB::query('User')->insert($user);

$result = DB::query('User')->search('Username', 'john.doe');

The search method will result in a query string as such.
SELECT User.* FROM User WHERE User.Username LIKE "%john.doe%"
Implmentation details

Projom\Storage\Action

Add new case SEARCH

Projom\Storage\SQL\QueryBuilder

New method: search(string $field, string $string)

Create filter: $this->filterOn($field, $string, Operator::LIKE)
Create queryObject and attach filter and collection.
Call $this->driver->dispatch(Action::SEARCH $queryObject).
Add example usage doc blocks to the Query class.

Projom\Storage\Engine\Driver\MySQL

Add Action::SEARCH to dispatch method.
Add new private function search(QueryObject $queryobject)

Modify the search string from the filter by adding '%...%'
Call $this->select() with the modified query obejct.

Create tests and rerun the test suite.

The search idea will instead be implemented as part of the Model concept.


Error: "PhotoViewer" plugin is not implemented on android Error: "PhotoViewer" plugin is not implemented on android

Describe the bug
Error: "PhotoViewer" plugin is not implemented on android Error: "PhotoViewer" plugin is not implemented on android
To Reproduce
Steps to reproduce the behavior:
install the plugin and then click on the image at that time I am getting this error.
(i follow all the instructions)
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

@krunalsk007 can you share your Package.json file and the project and app gradle files

after uninstall and install and following all instruction  i am not getting this error  and sorry i am uninstalled this plugin because  i am facing two issue on it

my some image was png and its in black color so its is not display on screen.
and i cant able to share image when i am  try to share images then it will show me toast for image created and then it was show me toast that failed with path of image (like data/data/... ).

@krunalsk007 Hi, i did not reply quickly as i was busy with 2 of my others plugins but i am able to improve the plugin if a feature is missing or if there are bugs.

Can you share one of your png or give me a link to a similar png so i can make a fix for this.
check your AndroidManifest.xml file it should contains

        <provider
            android:name="androidx.core.content.FileProvider"
            android:authorities="${applicationId}.fileprovider"
            android:exported="false"
            android:grantUriPermissions="true">
            <meta-data
                android:name="android.support.FILE_PROVIDER_PATHS"
                android:resource="@xml/file_paths"></meta-data>
        </provider>

take care of android:authorities="${applicationId}.fileprovider" it was on earlier version android:authorities="${applicationId}.provider"

@krunalsk007 the backgroundcolor parameter  has been added so png black images can now be displayed.
'backgroundcolor' can be in  ["white", "ivory", "lightgrey", "darkgrey", "grey", "dimgrey", "black"] default is "black"
hope this help you to change your mind and use the plugin. Anyhow it helps me to solve an issue


Allow defining default importers per file extension

I'm opening this as a draft to be able to discuss part of it on 🚀.

This is implementing godotengine/godot-proposals#2500.

Settings are read from a new [default_resource_importers] section

Key is the extension and value is the importer name
The section should probably have a better name

When first importing a resource, if we have an importer defined for its extension, use it instead of relying on the priority selection
Add a window to edit these settings

It's under Project Settings > Import Defaults
The window lists all the extensions recognized by Godot, for each you can choose between nothing (current behaviour) and one of the valid importers for said extension.

TODO: It's impossible to select the keep importer from the UI, and writing it directly in the settings won't work.

As an aside, if anyone has a UI/UX mind and ideas on how to make this screen better, I'm all ears. I especially don't like the Save button down low, feels very weird.

Production edit: Closes https://github.com/godotengine/godot-proposals/issues/2500.

are you ready for review or do you want to wait for all tests to pass?

Still interested in getting feedback on this. Cc @YuriSizov

I’m closing this. If anyone wants to do something for godotengine/godot-proposals#2500, I’ll leave the MR branch up on my repo for reference.


Flutter web app + Artifact could not be deployed error

I'm trying to publish the Flutter default app (made with flutter create) to my repo's GitHub Pages. My workflow file is as follows:

name: Publish main branch to GitHub Pages

on:
  push:
    branches: [ "main" ]
  pull_request:
    branches: [ "main" ]

  # Allows you to run this workflow manually from the Actions tab
  workflow_dispatch:

# Grant GITHUB_TOKEN the permissions required to make a Pages deployment
permissions:
    contents: read
    pages: write      # to deploy to Pages
    id-token: write   # to verify the deployment originates from an appropriate source

jobs:
  build:
    runs-on: ubuntu-latest
    steps:

      - name: Clone the source repo
        uses: actions/checkout@v4

      # https://github.com/marketplace/actions/flutter-action
      - name: Set up Flutter
        uses: subosito/flutter-action@v2
        with:
          channel: stable
          flutter-version: 3.24.0

      - name: Build the web artifact
        run: |
          flutter pub get
          flutter test
          flutter build web --base-href /${{ github.event.repository.name }}/ --release

      - name: Configure Pages
        uses: actions/configure-pages@v4

      - name: Upload the web artifact
        uses: actions/upload-artifact@v4
        with:
          name: github-pages
          path: build/web

  # https://github.com/actions/deploy-pages
  deploy:
    runs-on: ubuntu-latest
    needs: build
    environment:
      name: github-pages
      url: ${{ steps.deployment.outputs.page_url }}

    steps:
      - name: Deploy to GitHub Pages
        id: deployment
        uses: actions/deploy-pages@v4

The build artifact is successfully uploaded and appears correct
With the provided path, there will be 31 files uploaded
Artifact name is valid!
Root directory input is valid!
Beginning upload of artifact content to blob storage
Uploaded bytes 7436117
Finished uploading artifact content to blob storage!
SHA256 hash of uploaded artifact zip is 2669ae79bd709d99ca67b64104e824cbabe608a56ab8ef3788a621e007f410[15](https://github.com/austinmilt/cthulu_character_creator/actions/runs/10445530658/job/28921814519#step:6:16)
Finalizing artifact upload
Artifact github-pages.zip successfully finalized. Artifact ID<PHONE_NUMBER>
Artifact github-pages has been successfully uploaded! Final size is 74361[17](https://github.com/austinmilt/cthulu_character_creator/actions/runs/10445530658/job/28921814519#step:6:18) bytes. Artifact ID is<PHONE_NUMBER>
Artifact download URL: https://github.com/austinmilt/cthulu_character_creator/actions/runs/10445530658/artifacts/[18](https://github.com/austinmilt/cthulu_character_creator/actions/runs/10445530658/job/28921814519#step:6:19)25503194

This works up until deploy-pages which fails with error
Artifact could not be deployed. Please ensure the content does not contain any hard links, symlinks and total size is less than 10GB.
I've confirmed there are no (file) links.
Debug logs (attached)
logs_27310942169.zip
do not give me more info.
I've seen examples of flutter web apps successfully publishing to GitHub Pages, so I have some confidence this should work. I'm wondering if there are some gotchas I'm missing, or if there's another way to debug this process.

Use upload-pages-artifact instead of upload-artifact
      - name: Upload the web artifact
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-pages-artifact@v3
        with:
          name: github-pages
          path: build/web

Correct, see https://github.com/actions/deploy-pages/issues/368#issuecomment-2451649058.


Make sure we run php-cs-fixer as part of our CI

What was changed
I see that we have php-cs-fixer config and library installed, but we dont run it as part of the CI.
Why?
Code style rules should be forced and handled automatically. This should not take up time for the reviewer or the contributors.
Checklist
Please review this PR by first looking at my manual changes in f45a9e2cd613619587a3cce93df4c7b435c5777b, then looking at the automatic changes in 85e48c3534d96176d896e20754a9464cecb47047.

Im not a big fan when new contributors create a PR with code style changes. But I think this is okey because the code style rules are already defined.

I've updated the PR to be more restrictive in the changes it is doing. The current CI fixes are very easy to handle in conflicts..
Also, there are CS fixes, just "accept yours" and you are good.
I understand this is a PR that should be made by maintainers. I did not look properly, but I didn't find the discussion/argument to not run CS. I assumed it was something forgotten.
I'll leave this PR now, if maintainers want to take parts of it later or want me to keep it updated, just let me know.

Hi. In this PR I updated the CS Fixer rules and added a Workflow in CI that will automatically fix CS issues. Thank you for bringing this to my attention.


Bug - Deployment: 500 Error on Creating Job Poster

Description
@gobyrne is reporting receiving a 500 error after trying to create a job poster (he'll fill it out and then it will error or values will be empty). Please see him if you need more context.
Steps to Reproduce

Log in as admin
Create job poster
Save job poster
See error/missing values

Resolved by #876


[BUG] how could i find a zata version that compatiable with python3.8 and torch 1.12

the lastest zata version uses torch2.2

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

Zeta is not compatible with Torch 1.12, why are you using torch 1.12?


First jab at emulating std::experimental::simd types

Looks like it passes.
@DenisYaroshevskiy your opinion ?


/bin/sh: ipfs: command not found

Hello when running pin.js UI get the following error.
🚨 error with QmNrhZHUaEqxhyLfqoq1mtHSipkWHeT31LNHb1QEbDHgnc /bin/sh: ipfs: command not found
it happens for all 500 items in my wallet.
I am on Mac OS 11.4
Desktop IPFS is running with no errors
AGENT go-ipfs v0.8.0
UI v2.12.3
NODE v14.17.1
and the latest hicetnuc_tools from github.
Seems like sh cant find the path to the desktop IPFS app. Can I set this variable somewhere in the OS or hicetnuc tools?

when you installed ipfs desktop, did you restart your terminal? It should install the CLI tool as well and add it to your path. Try launching a new terminal, then try reinstalling IPFS desktop and launch a new terminal.

I had to install desktop and install via homebrew. Once I did this all worked well. Just will have to remember to update both when updating. Thanks for helping.


Add ACES color spaces

aces2065-1 (Linear ACES AP0)
acescg (Linear ACES AP1)
acescc (Logarithmic)
acescct (Logarithmic with towing)

@gir-bot lgtm


Migrate Larkcamp FrontEnd into this repo

Sent this as an email to y'all, but here it is in issue form:

We use the same domain for both fe and be (e.g. not doing the whole www.camphoric and api.camphoric split)
All routes that don't fall into currently established subdomains (e.g. admin/, api/, api-auth/, api-auth-token/) get served the static react bootstrapping page (the html page with all the js/css includes, etc...)
React handles all routing beyond that point, as should be well handled by client-side React routing libs.

I'm guessing this approach will be simple enough to allow easy dev of both fe/be of the project.

A single domain sounds good to me. I'm not sure I completely understand the rest - would this still let us serve static files besides the React bootstrap page, and have separate public registration and admin apps (not django-admin, but our custom thing when we get to that)?


allow hide/show/etc to be fired when selector selects multiple elements

Fixes Issue 14: Hiding multiple elements with a single selector does NOT fire showandtell.hide.
I added 1 new unit to test, but there should be more tests for "multi-selectors", but don't have time at the moment to bone up on QUnit to make sure I'm writing the tests correctly.
All of the existing unit tests that had previously passed continue to pass and the 3 existing unit tests that had previously failed continue to fail.
Also note: I reformatted the code to the style I prefer.  Feel free to change it back to your preferred style.

Heya!
Thank you again for taking the time to contribute! I just checked through your code, and here are my comments:
I think the style changes are pretty significant. Could I get you to revert those, so they don't get committed in here? (It should be possible to temproarily disable auto-formatting in your editor, if that's what is doing it.)
They have also made it quite hard to me to figure out what exactly you have changed 😦
The test seems good to me, and evaluates as negative without the changes you have introduced.
Here are a couple of other tests it would be interesting to run:

A test of showing several elements (you only test .hide(), not .show())
A test of removing several elements (.remove())
Tests of using css to hide/show several elements (.css('display','none') and .css('display','block')).

Once these are done, we can merge and publish :smile:
Let me know if you have trouble with any of these, or need some help, and I'll be happy to give more assistance :smile:

I understand about the request to revert the purely code formatting changes (I find it next to impossible to read/understand code that is formatted in an "alien" style and I'm sure you're the same way) .  I've reverted them and tried to match your formatting on the functional changes.
I've also added more unit tests as you suggested.  Be sure to look all of my unit tests over very carefully because I still haven't had time to read the QUnit docs to make sure that the tests are testing what I think they are testing...I just copied some of your existing tests and made the changes I think are necessary to test the new functionality.
Also, do you have any idea why Travis Cl seems to have failed after the latest commit to my fork?  Do I need to send another PR from that commit?

Hey!
Thanks for the changes :-)
I tried to set up Travis but it isn't quite working yet. (It's hard to get to run tests that deal with visibility in the browser from the command line.) Just ignore it :-)
The code looks good, and thanks for all the tests! The last comment I have is that you seem to have used tabs for indentation, whereas the rest of the code uses four spaces. Do you think you could fix this? Then we're ready to merge and I'll put together a release :smile:
Would you like to be featured in the README as a contributor? I was thinking of setting this up anyway. What would be your preferred name and link to list?

Sure, always nice to be recognized for contributions.  Use "Paul Biron" and link to my github page.

Woo! This looks really good :smile: I'll get around to putting an actual release together. Thank you for your time and contributions, and I'll update you here once your name appears in the contributors' section.

Done :-) I also put up the new release, on here and on npm.

cool!


IA-2291: Need a read only permission on top of the existing one for accessing the pages

Explain what problem this PR is resolving

Don't allow everyone to update or delete a page
Related JIRA tickets : IA-2291

Self proofreading checklist

[x] Did I use eslint and black formatters
[ ] Is my code clear enough and well documented
[ ] Are my typescript files well typed
[ ] New translations have been added or updated if new strings have been introduced in the frontend
[x] My migrations file are included
[ ] Are there enough tests
[ ] Documentation has been included (for new feature)

Changes

Added a menupermissions 'iaso_page_write'
Check if the current user has permissions to delete or to edit page

How to test

Create a new user(not an admin one) add all permissions except edit page permission
Login with the user
Check if the delete and edit icon on pages list is there or not. They should not appear

Print screen / video

@hakifran once the tests pass I can accept it ..

@hakifran once the tests pass I can accept it ..

@mathvdh tests are already there, you can check in this file iaso/tests/api/test_pages.py

@hakifran yes I have seen but last time I looked the tests were not passing in github actions


Docs code snippets report an error

Docs code snippets report an error
The Neo4j docs related to Quarkus have broken code snippets.
What I see on most snippets is:
Unresolved include directive in modules/ROOT/pages/index.adoc - include::../../../../integration-tests/src/main/java/io/quarkus/it/neo4j/FruitResource.java[]
I use Firefox.
Could you please check?

Hmm @gastaldi do you know?

@michael-simons you need to create symbolic links under an example directory in the docs/modules/ROOT directory. See https://docs.antora.org/antora/latest/symlinks/ for more details
I created https://github.com/quarkiverse/quarkus-neo4j/pull/83 to fix this

Thanks a lot, much appreciated!


add black duck scan action

If these changes need to be integrated in AmiGO for the scan to work, not only add a version tag, but also update the version in package.json with the new version of the tag before it can be properly integrated in AmiGO.
Note that unlike for the react-native-tts library we have not done this before (version number 0.11.1 is still a very old version) and likely is not a big issue if we don't do it now as most developer will not run the scan locally. (issue with not updating version number is that on npm install after a pull to update local AmiGO branch it will mostly not update the source code of the library correctly in the node modules.


ISPN-6882 Fix Scala warnings during REST server compilation

https://issues.jboss.org/browse/ISPN-6882

The same here - the code is fine... I'll assign this to @wburns

Looks good, integrated.


Option to use farmland mechanics from Alpha/Beta minecraft

Updated it to also work with stone walls due to it not being a thing back then.

Does BlockCobbleWall cover all the different types of walls?

Yes it does cover every wall and every future walls they plan to add, same with fences.


Add support for Spark/Databricks connector

Is your feature request related to a problem? Please describe.
Currently unable to use dbt-sugar with out Databricks hosted solution
Describe the solution you'd like
Please add a connector for Spark/Databricks
Describe alternatives you've considered
Additional context
Would be happy to assist if required.

Hi @jelstongreen thanks for the issue and welcome to the community.
As mentioned in discord, currently this is going to have to be entirely community-driven as I cannot do this on my own. I don't have the tech resources or knowledge.
That being said, I'm all in for helping with development, pointing you to the places in the code and coming up with some architectural decisions etc.
You say you'd be happy to help which is great.
Maybe a first step would be to start outlining a bit what is required architecturally.
Currently dbt-sugar uses dbt-core stuff + sqlalchemy to talk to databases. If we could leverage either existing tech from dbt-spark (provided they're stable enough) or plug in our own connectors we should be able to come to the same abstractions and contracts and make the tool work.
Let me know!

Hey @jelstongreen Now it's my turn to apologise for the delay.
To be completely honest, I have no idea about spark. But I think that indeed it may make sense to try and leverage the dbt internals as much as possible especially because they're moving towards a stable API.
So I think I'd totally welcome that contribution if you had an idea about how to go about it.
In fact someone else wants to contribute an adaptor for GCP and they're also thinking of using the dbt API itself: https://github.com/bitpicky/dbt-sugar/issues/170 and I think it makes sense.
Let me know if I can be of any help in the process!