Terminal Log displaying not right with emoji

VSCode Version:
1.39.2
OS Version:
Windows_NT x64 10.0.17763

console.log('Log Level: %c ⚠🐞OK', 'color: skyblue');

In terminal, it looks bellow.

In DevTools, Chrome. It looks like this.

I really enjoy the VS Code. Hope it will become better!
Cheers!

This looks like an issue with our old terminal backend "winpty", going forward we are focusing our efforts on the new backend "conpty" which is build by the Console team at Microsoft and should fix many issues with the terminal under Windows. You can read more about getting ConPTY here.
/duplicate https://github.com/Microsoft/vscode/issues/45693

For conpty (Windows 1903+) this is tracked in https://github.com/microsoft/vscode/issues/76842


Can't have names with uppercase letters

This works:
kbatch job submit --name=list-files --command='["ls", "-lh"]' --image=alpine
but any name with uppercase letters gives an error. For example:
kbatch job submit --name=List-files --command='["ls", "-lh"]' --image=alpine
gives
[12:51:57] INFO     HTTP Request: POST https://pccompute.westeurope.cloudapp.azure.com/compute/services/kbatch/jobs/ "HTTP/1.1 500 Internal Server Error"     _client.py:1013
Traceback (most recent call last):
  File "/home/jesse/.cache/pypoetry/virtualenvs/validator-ZACCxrgy-py3.10/bin/kbatch", line 8, in <module>
    sys.exit(cli())
  File "/home/jesse/.cache/pypoetry/virtualenvs/validator-ZACCxrgy-py3.10/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/home/jesse/.cache/pypoetry/virtualenvs/validator-ZACCxrgy-py3.10/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/home/jesse/.cache/pypoetry/virtualenvs/validator-ZACCxrgy-py3.10/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/jesse/.cache/pypoetry/virtualenvs/validator-ZACCxrgy-py3.10/lib/python3.10/site-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/jesse/.cache/pypoetry/virtualenvs/validator-ZACCxrgy-py3.10/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/jesse/.cache/pypoetry/virtualenvs/validator-ZACCxrgy-py3.10/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/home/jesse/.cache/pypoetry/virtualenvs/validator-ZACCxrgy-py3.10/lib/python3.10/site-packages/kbatch/cli.py", line 281, in submit_job
    result = _core.submit_job(
  File "/home/jesse/.cache/pypoetry/virtualenvs/validator-ZACCxrgy-py3.10/lib/python3.10/site-packages/kbatch/_core.py", line 170, in submit_job
    return _request_action(kbatch_url, token, "POST", model, json_data=data)
  File "/home/jesse/.cache/pypoetry/virtualenvs/validator-ZACCxrgy-py3.10/lib/python3.10/site-packages/kbatch/_core.py", line 119, in _request_action
    logger.exception(r.json())
  File "/home/jesse/.cache/pypoetry/virtualenvs/validator-ZACCxrgy-py3.10/lib/python3.10/site-packages/httpx/_models.py", line 756, in json
    return jsonlib.loads(self.text, **kwargs)
  File "/home/jesse/miniconda3/lib/python3.10/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/home/jesse/miniconda3/lib/python3.10/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/home/jesse/miniconda3/lib/python3.10/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Underscores appear to have the save problem

Get same problem when passing args that are numbers (quoting them works)

Just ran into the same issue here. Is there a way we wan replace incompatible characters automatically or raise a more user friendly error message?
(cc @yuvipanda)


Switch to 'assemble' regressed track-widget-creation on macOS

The recent switch to using assemble for macOS builds regressed #31274, so hot reload in IDEs crashes.
/cc @jonahwilliams

@jonahwilliams Assigning to you; please fix ASAP or revert the assemble change (here and in FDE). I thought this might be straightforward to fix so I wired it back up in the script as a new -d and passed it to the trackWidgetCreation: that's currently hard-coded to false in dart.dart.
The result was that clean builds failed on the copy of flutter_assets, and non-clean builds silently used the wrong (stale) flutter_assets—it took me a while to figure out, since didn't start with a clean build. I don't see any error output from the asset compilation step, it's just apparently silently not actually working correctly once I pass that flag. The build is convoluted enough that I gave up for now on trying to figure out why.

Fix is pending https://github.com/flutter/flutter/pull/37512. Sorry about the trouble this caused. I had though the builtin transformer had landed but that isn't the case.
For the failure case, it would be good to understand why this is happening. Separately I'll revert the assemble change in FDE and the tool

For more context, the prs for landing the SDK included transformer are:
https://github.com/flutter/engine/pull/9227
https://github.com/flutter/engine/pull/9134
https://github.com/flutter/engine/pull/9085

Oh, I think I know what happened there. The re-entrancy of the whole thing is kind of wonky. The Environment created by https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/macos/build_macos.dart#L29 needs to match what gets created by the bash script, or we can' find the executable

I didn't change that, so that would explain it.
Is that a long-term design behavior, or a temporary state because the transition to assemble is in-progress? Having to remember to replicate behavior across two files, in two different languages, 100% correctly, in order to avoid nasty failures (submarine breakages, apparently successful builds using stale data, etc.) that are also hard to understand/debug is something that we should try hard not to have stay around.


Q: v3 Assertions and super-user

I'm looking at Assertions and the way they are handled. https://github.com/basz/zfc-rbac/blob/develop/src/Service/AuthorizationService.php#L129-L137
Trying to accomplish:
See if a user with hierarchical roles (v3) that 'owns' something is allowed to edit a thing. A user with an super-user role should always be able to edit the thing. So I have two roles defined, one a child of the other;

super-user

a-thing-user

the super-user role and the editor role both have a permission 'thing.edit' attached. Since the role 'a-thing-user' should only be allowed to edit its own thing an assertion is needed. Something like this;
public function assert(
    AuthorizationServiceInterface $authorizationService,
    IdentityInterface $identity = null,
    $context = null
) {
    if ($identity->getUserId() == (string) $context->ownerId()) {
      return true;
    }
}

However; even when the user has the role 'administrator' and the rbac service told us so (the assertion isn't executed otherwise) an administrator that does not own the thing would be denied access. How do I deal with such a scenario?
Should I organise my roles differently? Should I parse the $identity->getRoles() myself - which is cumbersome as they are hierarchical. Should I add a permission 'thing.edit.as-admin' to the administrator role and do return $authorizationService->isGranted($identity, 'thing.edit.as-admin'); after that if statement.
Thanks

answer :  cookbook


Make use purescript-parallel

This would involve implementing MonadPar and deleting Par and finally updating README.md to make use of purescript-parallel.


[SCHEMA] Common error messages for rules that have no check in schema.

Modification of  #1114

I think I should have rebased this before merging. The changes lead to a broken CI in master now -- can you have a look @rwblair?


How to count the communication size between the parties

I am looking for a way to count the communication size between parties. Specifically, I need to track the amount of data exchanged, but I have not been able to find any interfaces or functions like send or recv to monitor this. Could you provide a solution or guidance on how to achieve this?

tf-encrypted is quite high-level, and not exposing any API for such send/recv information.
One possible way to approximately gather such communication information is by using Linux's traffic control command tc qdisc. It displays the total bytes that have been sent on a network interface.
For accurate statistics, you might have to consider using a different framework.


draft: Poc/status ssa

Description
Changes proposed in this pull request:

...
...
...

Related issue(s)
https://github.com/kyma-project/lifecycle-manager/issues/2027

Closing as the POC is finished.


Additional filter implementations (DD2)

Some time ago, I played around with the DD2 Kalman filter--see "New developments in state estimation for nonlinear systems" by Nørgaard, Poulsen, Ravn in Automatica 36 (11), 1627-1638 (doi:10.1016/s0005-1098(00)00089-3; it's on scihub).
From what I can tell, this is kinda similar to the UKF filter (a nonlinear extension of classic Kalman filtering, not relying on explicitly supplied derivatives). It is based on Stirling interpolation, and claims better performance (specifically covariance estimation) than the UKF.
There is some Matlab reference code, but ready-to-use library implementations are not common (that I found).
I would base any work on the current UKF implementation (because some implementation details seem quite similar to me).
I also have some real world data to benchmark them against each other.
Would it make sense to add an implementation to this package?
Does anyone have any input/opinion on this (interesting/redundant/pointless/belongs elsewhere)?

Have not thought through in detail, but another option would be to create a new package that depends on this one with the advanced DD2 filter.


Fix Codecov workflow

Was failing intermittently as Codecov hit their rate limit; we have to tell it to use our token instead.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.41%. Comparing base (0e7bd45) to head (d754722).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   73.41%   73.41%
=======================================
  Files          13       13
  Lines        3381     3381
=======================================
  Hits         2482     2482
  Misses        899      899

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Deprecating the mypy plugin

Problem

The mypy plugin is broken in the latest versions of mypy and it is causing too much maintenance burden to support it any longer.
In the next release the plugin will be deprecated and completely removed in the subsequent release unless I get strong signal that this is being actively used by a significant portion of the user base.
If you are using the plugin please comment on this issue!
Additional context
This is the issue that is breaking the mypy plugin https://github.com/python/mypy/issues/14149

Using the mypy plugin internally at Tekst.ai !


Local recording will crash after a long time

If the recording time exceeds 10 seconds, it will crash.
[2024-12-03 10:54:02,592] settings.init:14 DEBUG -> Settings filename: \HKEY_CURRENT_USER\Software\Buzz\OrganizationDefaults
windows11
Buzz:1.2.0

I was able to replicate this issue once with Whipser.cpp tiny model and language set to "Detect automatically". After that I uninstalled the Buzz, selecting to delete the settings and installed it again, installed the latest version from the releases section (version 1.2.0). Now it works.
If someone can replicate this, please see if there is some error in the logs. More information is needed on the steps or conditions to replicate this.


midleware create - id should be not required

When you add resource witch describes schema
var resource = new Resource(Model, {
    type: entityType,
    id: new Property('_id'), //<--- here
    attributes: {
        name: new Property('name'),
        weight: new Property('weight'),
        price: new Property('price'),
        days: new Property('days'),
        is_active: new Property('is_active'),
        updated: {
            value: new Property('updated'),
            nullable: true
        }
    },
    relationships: {
        company: new Ref('Company', 'company'),
        category: new Ref('Category', 'category')
    },
    links: {
        self: {
            value: new Template('/' + entityType + '/${_id}'),
            writable: false,
        },
    },
});

when you try create new record, field Id undefined and it send error

For server-generated IDs to work, you need to mark the id field as optional and non-writable


WIP: Use kenjutsu

Fixes https://github.com/alimanfoo/zarr/issues/93
Fixes https://github.com/alimanfoo/zarr/issues/78
Use kenjutsu to handle slice normalization and shape determination.
Also have extend further to handle a sequence of indices in the slice, but may require some discussion about whether this is ok.

Appears there is not enough coverage, but only in the Python 3.6 case. 😕 Not really sure what to do about that though or whether that is something for me to improve or whether it lies outside these changes.

Hi @jakirkham, thank you for this.
Would mind breaking out just the changes that address #93 into a separate PR? That would help a lot.
Regarding fancy indexing, if I've understood this correctly, I think there may be performance issues. In the worst case, chunks could get decompressed many times over. Also, again in the worst case, if there are lots of indices, then there could be a lot of Python looping. I think we need a solution that ensures each chunk of the array is decompressed at most once, and also which minimises looping. I have some ideas, happy to discuss further.

Would mind breaking out just the changes that address #93 into a separate PR? That would help a lot.

So just move the multiple indices into a separate PR. No problem.

Regarding fancy indexing, if I've understood this correctly, I think there may be performance issues.

Indeed. Was interested first to see if we could get it to work. Plus it would provide some demonstration as to how one might use this functionality to handle these slices. Figured optimization would require some discussion or passing of the baton. Not sure I know enough about Zarr's internals to do this alone.

I'll probably borrow from this PR and tweak it as it makes for a nice template. However, I have broken out the slice normalization fixes into PR ( https://github.com/alimanfoo/zarr/pull/119 ).

Thanks for breaking out #119.
For fancy indexing, the critical section of code is within Array.__getitem__, particularly the loop over chunk indices. This is the crux of Zarr, it's the only bit of code that has any real complexity, and took me some time to get right for the simple case of slicing out a contiguous region currently supported. Before entering this loop, the get_chunk_range function figures out which chunks overlap the selected region. Then the loop iterates over only the chunks in range (important optimisation - iterating over all chunks would be very slow). For each chunk, the code within the loop then figures out which part of the chunk needs to be loaded, and where that should end up in the output array.
For fancy indexing I think it is potentially simpler to handle the fancy part of the index item as a boolean array, rather than a sequence of integer indices. The code within the loop could then be modified to slice this boolean array, to obtain a sub-array of the boolean array which would be appropriate for indexing just that chunk. I.e., the boolean array would get divided up into pieces, with one piece for each chunk along the dimension the boolean array is being applied to. Figuring out the pieces is easy because they are equal sized, determined by the size of the chunks along that dimension. Within the loop there is already the current offset for each dimension, which tells you where you are in the context of the whole array. So this offset and the chunk shape is all that is needed to slice the boolean indexing array for the current chunk. Then the whole chunk can be loaded into a numpy array and the selection applied via numpy indexing. The trick is then to figure out where the data extracted from the current chunk should end up in the output array. I think probably we'd have to keep track of the offsets into the output array too, which means counting how many True values from the boolean array have been handled so far. All of this could I think be done with an integer index array instead of a boolean array, but would be a bit harder as it would require searching the array to find the set of indices that apply to the current chunk, then mapping those indices into the chunk's coordinate system, which I think will be more complex to code and slower.
There may also need to be some modification to the get_chunk_range function to handle a Boolean array, which in the first instance could be dumb and just return all chunks for the indexed dimension as overlapping the selection, but potentially could be optimised so only the chunks where there is some data to extract are returned as in-range.
This is probably all making very little sense, but thought I'd share ideas. This is the basic route I was planning to explore at some point, although have some other priorities I have to work through at the moment.

@alimanfoo any update on this? Would love to use this to update an Array using an array of indices.

Hi @samiur, apologies I'm snowed under with other work at the moment. TBH I think support for fancy indexing to update the contents of a zarr array may be some way off. I need to think through how to implement limited support for fancy indexing in __getitem__ first which is not entirely trivial.

@alimanfoo no worries! Thanks for the help on this.

Closing as indexing code is substantially changed via #172. Happy to revisit using kenjutsu in future if it looks like there's a lot of common code.


Unused code in RedirectMapModelTest

@klcodanr question for you on https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/f101585bf17e57b609ce0e3de8816d2a662d0778/bundle/src/test/java/com/adobe/acs/commons/redirectmaps/models/RedirectMapModelTest.java#L69
This class is producing some errors on one of my machines when testing. Mockito is complaining that it can't spy on this class since it is private (or something like that). Rather than troubleshooting that, it appears that this inner class can just be removed as it isn't used.
Thoughts?

nevermind. this code is actually used. but it looks to me like the spying isn't necessary. but the spying isn't needed.


[docs] add TSdoc documentation

This is just the default docs for TSDocs, I will work on adding the comments later to flesh out the documents but for now it's something!

https://github.com/retro-mmo-com/vod-player/blob/main/.github/workflows/build.yml


API MQTT

    - name: "switch.dennamow"       command_topic: "CaSSAndRA/api_cmd"       payload_on: "{\"robot\":{\"command\": \"mow\", \"value\": [\"all\"]}}"       qos: 0       retain: false
works fine
    - name: "switch.dennahome"       command_topic: "CaSSAndRA/api_cmd"       payload_on: "{\"robot\":{\"command\": \"start\"}}"       qos: 0       retain: false
start, stop, dock don t working.
"4. Stopp:
{"robot":{"command": "stop"}}
5. Dock:
{"robot":{"command": "dock"}} "
Am I making a mistake, or does the start, stop, home command not work? Thanks

start isn't valid command.
Stop and dock, I need Cassandra log output in debug level

CaSSAndRA/api_cmd {"robot":{"command": "stop"}}
CaSSAndRA/robot {"status": "mow", "dockReason": null, "battery": {"soc": 100, "voltage": 31.62, "electricCurrent": 2.36}, "position": {"x": 1.23, "y": 0.5}, "target": {"x": 1.32, "y": 0.57}}
CaSSAndRA/maps {"loaded": "home_", "available": ["home", "home_", "homex", "h"]}
CaSSAndRA/tasks {"selected": [], "loaded": [], "available": []}
CaSSAndRA/mow parameters {"pattern": "lines", "width": 0.15, "angle": null, "distancetoborder": 2, "mowarea": true, "mowborder": 0, "mowexclusion": true, "mowborderccw": true}
CaSSAndRA/map {"mowprogressIdxPercent": 0, "mowprogressDistancePercent": 0}
CaSSAndRA/status busy
CaSSAndRA/status ready
CaSSAndRA/robot {"status": "mow", "dockReason": null, "battery": {"soc": 100, "voltage": 31.61, "electricCurrent": 2.52}, "position": {"x": 1.52, "y": 0.55}, "target": {"x": 2.19, "y": 0.52}}
CaSSAndRA/maps {"loaded": "home_", "available": ["home", "home_", "homex", "h"]}
CaSSAndRA/tasks {"selected": [], "loaded": [], "available": []}
CaSSAndRA/mow parameters {"pattern": "lines", "width": 0.15, "angle": null, "distancetoborder": 2, "mowarea": true, "mowborder": 0, "mowexclusion": true, "mowborderccw": true}
CaSSAndRA/map {"mowprogressIdxPercent": 0, "mowprogressDistancePercent": 0}
CaSSAndRA/status ready
CaSSAndRA/robot {"status": "mow", "dockReason": null, "battery": {"soc": 100, "voltage": 31.62, "electricCurrent": 2.57}, "position": {"x": 1.76, "y": 0.59}, "target": {"x": 2.19, "y": 0.52}}
CaSSAndRA/maps {"loaded": "home_", "available": ["home", "home_", "homex", "h"]}
CaSSAndRA/tasks {"selected": [], "loaded": [], "available": []}
debug.txt

I already fixed that tomorrow or today later the update will be available

Thank you for your work.

https://github.com/EinEinfach/CaSSAndRA/commit/90549a20a3f4f9a95319bb8b07ba15f33f7df1fe

start isn't valid command.
Stop and dock, I need Cassandra log output in debug level

I have an additional question. Is there a way to resume over the API?

{"robot":{"command": "mow", "value": ["resume"]}

Ah. Super. Danke!


How can I get the deploy.cmd to run when deploying to Azure from VS Code?

How can I get the deploy.cmd to run when deploying to Azure from VS Code instead of Git?
My project is setup using v2.13.0 of the generator.

This feature has been deprecated and Yo Teams does not longer support nor recommend this. I'd recommend that you use Azure DevOps or simliar for deployment of Yo Teams applications. See this as a reference: https://www.wictorwilen.se/blog/deploying-yo-teams-and-node-apps/


chore: bdd-sbrp-import-1587461523 to 0.0.1

chore: Promote bdd-sbrp-import-1587461523 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Composable Charts

There are multiple references ... to creating composable charts. I agree with that approach and it was one I also had proposed earlier.
I understand @esbullington has been quite busy with work, and @yang-wei has been doing an excellent job of maintaining and addressing issues. I do have to point out that the pace of development has slowed down, so I am taking this opportunity improve the pace.
Some of the benefits of creating DIY charts I can think of

It is DIY, so user can add their own custom svg elements and stick them in
reduce the number of props sent to the Top component
Users can implement click handlers for any supporting component

Seeing the recent development in some libraries (read redux, react-motion) and taking inspiration from them I am thrilled at this possibility. Also the stockcharts (cough shameless plug) library does this, and I have some learning from there.

Yes as you known we had been discussing this for so long but haven't came out with a nice API. I am happy to hear the idea =)
Your library looks really great.
Just one thing, our library came out first to help user build powerful graph quickly with react.
Thus I would also like to keep the current high level api for doing that.
But I do believe as long as those composable components are built, high level api isn't anything difficult.

But I do believe as long as those composable components are built, high level api isn't anything difficult.

Sure, we can maintain the high level api, My preference is maintain it for backward compatibility but deprecate it. Supplement these by having multiple examples and a good documentation.
My thoughts on this composable api. I see 2 broad categories of charts
Charts w/ Axis

Line
Area
Histogram, stacked,
candlestick
and any combination of the above

Charts w/o Axis

Tree
Pie
gauges
you get the idea...

I am thinking a lot of code reuse for charts which have axis, and those w/o axis need to give more thought on how to categorize them further,
so for Charts w/ axis the user should be able to create a chart by just creating a component with this in the render
<AxisChart width={...} height={...} data={...} />
  <DataSeries seriesName={...}>
    <XAxis ... />
    <YAxis ... />
    <LineSeries />
    <AreaSeries />
    <ToolTip ... />
  </DataSeries>
  <DataSeries seriesName={...} >
    <YAxis ... />
    <Histogram />
  </DataSeries>
  <Legend />
  <EventHandlerVornoli />
</AxisChart>

for Charts w/o axis something like
<NoAxisChart width={...} height={...} data={...} />
  <TreeDataSeries groupBy={...} onClick={} colorAccessor={...} >
    <ToolTip ... />
  </TreeDataSeries>
</NoAxisChart>

Other ideas welcome

Thanks, @rrag You're absolutely right, composable charts is very much where I wanted to end up, as opposed to front-loading the main chart element with properties.  But I've not adequately documented this part of the project, and need to do some things to promote it better.
I've got some free time now, so I'll take a look at the projects you mentioned as well as see what you've done in react-stockcharts since I last took a look -- quite a bit I'm sure!  Are you OK with me mentioning react-stockcharts in our README now as a similar project?

But I've not adequately documented this part of the project, and need to do some things to promote it better.

I am not sure I understand that, we do not have a means of composing charts now. And expecting users to write boilerplate code to flatten objects and calculating scales to pass it down is just not an option.
I expect composable charts in react-d3 to be simple in complexity as all the data is provided by the user. You will get an idea when you see the examples on stockcharts
stockcharts was a different animal (and I am glad I took your advice to make it as a separate project) since there are transformations and indicators which are to be calculated by the chart. but regular charts take data provided by the user, and possibly no further transformations are needed

Are you OK with me mentioning react-stockcharts in our README now as a similar project?

OK? I will be honored. Thank you

wanted to share a project I just came across using declarative JSX syntax https://github.com/FormidableLabs/spectacle quite neat

@rrag After been thinking for quite a while, I think I had came to conclusion regarding to this issue.
We will keep the direction we are currently doing  - which is to provide a quick chart, where user just have to pass in props at top level to get the chart done. In addition, we will export all the components so that user get to build their custom chart.

that is fair @yang-wei . I was interested in pursuing this further, but not able to spend the time.

its ok. Thanks for your input.


[SR-3995] Put semicolons in Cursors and Layout

Previous ID
SR-3995

Radar
None

Original Reporter
@bitjammer

Type
Bug

Additional Detail from JIRA

Votes
0

Component/s
Compiler

Labels
Bug, Syntax

Assignee
@bitjammer

Priority
Medium

md5: 9faa5d22f83ed26f7c7daabbccb46407

libSyntax was removed in #62145 and succeeded by swift-syntax.


ScoreOperationChain does not appear in Swagger UI example dropdown

The example dropdown logic needs updating in initExampleOperations in gaffer.js.

Merged into develop.


Port 3D app launcher build processor to MRTK3

Describe the problem
https://github.com/microsoft/MixedRealityToolkit-Unity/blob/265a0ea3621c84b88e4b02e7fcd1b5682afef56a/Assets/MRTK/Core/Utilities/BuildAndDeploy/MixedRealityBuildPreferences.cs
https://docs.microsoft.com/windows/mixed-reality/distribute/implementing-3d-app-launchers

Closed via #10952


Validate Kolmgorov stepper

Ensure the spectrum is comparable in the validation/validate_kolmogorov_spectrum.ipynb notebook. It could be that these lines
https://github.com/Ceyron/exponax/blob/32a79b2d015374b6310ac3f42eb46d2af1a7161d/exponax/nonlin_fun/_vorticity_convection.py#L168-L176
cause a wrong scaling in the injected energy. This could be related to #34

@GeorgKohl also worked with this stepper. Linking him here for reference.


Added Python Fibonacci Sequence #343

What a great code :smile: !
Just a little tip, its good to always put a description on your PRs to make more understandable.
Thank you for contributing! :rocket:
I would separate this PR into 2, one for the 'Python Fibonacci' and another for the 'clock' (I'll wait your response)

Yeah sure!
Thanks for your response.

Closing due to inactivity, feel free to reopen.


fix: antd select should not have max-width by default

https://github.com/alibaba/uform/issues/107

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.tankaiwen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

CI挂了，麻烦修一下

@janryWang  review一下？


As a developer, I want to ingest the LEAD score data set from DOE, so that it can be tested as an input to the cumulative impact score.

Description
The LEAD score data set from DOE needs to be available in the screening tool so that it can be used as an input into the cumulative impact score. The LEAD score represents the percentage of gross household income that goes to pay for energy. This data is only available at the Census tract level, so completing this task is dependent on developing a methodology for applying census tract data to census block groups within a tract.
It does include data for DC and Puerto Rico.
The source of the LEAD score is Open Energy Data Initiative (OEDI)

"The Low-Income Energy Affordability Data comes primarily from the 2018 U.S. Census American Community Survey 5-Year Public Use Microdata Samples and is calibrated to 2018 U.S. Energy Information Administration electric utility (Survey Form-861) and natural gas utility (Survey Form-176) data."
This data set will eventually be displayed in the map for selected census block groups and exported in the list of communities.
The system needs to classify this data set as a "Socioeconomic factors" indicator. A future version of the cumulative impact score will need this classification as part of the formula.
Both the raw value and the value converted to percentiles for the entire country must be available in the tool.
This data is not stored at the census block group level - it's at the census tract level. There is a separate card representing the work it will take to develop the methodology for combining data from census tracts into census block groups.
Solution
A clear and concise description of the solution.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Links to user research or other resources
Tasks
Definition of "Done"

[ ] LEAD score at the census tract level is applied to census block groups so that it is available to be used as an input into the score
[ ] LEAD score is classified as a "Socioeconomic factors" indicator
[ ] LEAD score is normalized into a percentile for the entire country
[ ] LEAD score is available to be displayed in the map UI
[ ] LEAD score is available to be downloaded in the CSV

@BethMattern to update this shortly.


Initial make ar warning message for common_lib.a

When initially running make on Linux (Ubuntu 20.04.3), the line [AR] rcu ../../bin/common_lib.a produces the warning ar: 'u' modifier ignored since 'D' is the default (see 'U'). Does the ar invocation for this library need to be adjusted?

Not sure about it needing to be changed.
For some reason (not sure why) my default is to use "update" mode in ar - but that message is saying that it defaults to deterministic mode (which makes update not work).
I'd force non-deterministic mode, but that wouldn't work with llvm-ar (used by OSX)
For now, not a real issue but I'll see about tweaking the option list so it makes everything happy.

Should be fixed with 3924a6871f5039ca1d00aaa76459cbd100b8e5ff

I'm no longer seeing that warning, so it's fixed for me. Closing for now, but anyone else who sees similar warnings from ar on a slightly different *nix sysem can comment here if they still encounter them.


Nested pipelines

Use nested pipelines to reduce code duplication - pipeline as an InferenceClass object

Initial version merged, have not tested multi-level nesting.

regarding this, reusing  'converted_dcm.nii.gz' would be great. currently, the transformation to *.nii is done in nnUNet_predict_image. as the input directory or file_in in the pipeline itself is not changed, each prediction converts the dicoms to nifti again.
when the transformation of dcm -> nii is done by the pipeline itself, we maybe could also get rid of the adapted totalsegmentator?

Hi Felix,
Thanks for your feedback! I don't think that dicoms are being converted to niftis more than once? This only happens in the TotalSegmentator code, not nnUNet. If there's something you think I'm missing, could you send the files and lines of the first transformation and the second?
We are actually working on improving the nnUNet inference code and more of the processing will happen within C2C.
Thanks for the continued feedback, much appreciated!

Maybe what you mean is that if TotalSegmentator inference code is called twice in the same pipeline, then conversion from DICOM to NIfTI would happen again. This is something that we are addressing, along with reusing segmentation predictions if a nested pipeline calls for a segmentation that has already been completed earlier in the pipeline.

hi louis.
sorry for the misunderstanding.
if you would try to combine two segmentation jobs (e.g. spine+bodycomposition AND organs) in a single pipeline as far as I understand nnUNet_predict_image and L152 is called again each time.
Sorry again. Best, Felix

Hi Felix,
Yes, I understand. That is absolutely true. Anything computation that is completed in the first pipeline should be cached and reused by the second pipeline instead of redoing the computation. We are working on this currently!
Thank you!
Best,
Louis

Hi Felix,
Just wanted to update you since you've been generous with your feedback. Yesterday, a collaborator ran into this exact issue while trying to combine two pipelines. So, I was forced to push a quick solution. Now, these is a module for converting from dcm to nifti within C2C. There are still other checks we will have to add to pipelines to ensure that we aren't redoing work that was completed by previous pipelines.
Best regards,
Louis

haha, same idea, same class name, ... L6. sorry for the quick 'n dirty approach, its just to implement the pipeline in a more restricted HPC environment...
anyway, the missing return {} in SpineMuscleAdiposeTissueReport, and this caused the pipeline to break afterwards, and thus, attaching an other inference object was not possible (see push).

haha that's awesome!!
Thanks so much for the PR; see the comments I left on it. Take care!
-Louis


Adding a custom class to the table

Adding this custom class wrapper will break the lines of code so the table no longer breaks out of the center content column.

Hi @adkinn, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Adam Kinney). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@adkinn : Thanks for your contribution to the Azure documentation! The author, @telmosampaio, has been notified to review your proposed change.

#please-close

We are editing that document any way, and changing the layout.


Feature Request: Add an option next to each day to state that you didn't get the prices for that day (closed, missed etc)

Is your feature request related to a problem? Please describe.
There is no method of entering in 0 or skipping a day's prices.
Describe the solution you'd like
We should add some method of a tickbox next to each time slot to state that the price was unavailable (Nook's Cranny under development or closed, or you simply missed/forget to get that time's turnip prices).
This checkbox should disable that time's input.
Describe alternatives you've considered
I tried entering in 0, however this bugged the chart out and set the min/max to infinity.

You can just leave the field empty.

@theRTC204 Of course, I was just referring to adding this which allows a more refined/improved user experience

I can see @theRTC204's point here that you don't actually need it. But in my opinion this is indeed an improvement in user experience, as @JamieBohannaWebDev already meantioned. It's a good idea!


[python3] vcpkg-cmake-wrapper.cmake prevents finding system installed Python

One of the packages listed in my manifest ("pybind11") has the "python3" package listed as a dependency which causes vcpkg to install Python 3.11. However, I have by own version of Python that I want to use like so: find_package(Python3 3.12 COMPONENTS Interpreter Development REQUIRED). When I didn't have vcpkg's Pyton 3.11 installed this worked fine, however I am now getting an error.
CMake Error at C:/Program Files/Microsoft Visual Studio/2022/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.29/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Python3: Found unsuitable version "3.11.10", but required is
  at least "3.12" (found
  C:/Users/NicholasAnthony/source/repos/wt_gui/external/WaveTracer/out/build/MSVC-Release/vcpkg_installed/x64-windows-digilens/tools/python3/python.exe,
  found components: Interpreter Development Development.Module
  Development.Embed)
Call Stack (most recent call first):
  C:/Program Files/Microsoft Visual Studio/2022/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.29/Modules/FindPackageHandleStandardArgs.cmake:598 (_FPHSA_FAILURE_MESSAGE)
  C:/Program Files/Microsoft Visual Studio/2022/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.29/Modules/FindPython/Support.cmake:3867 (find_package_handle_standard_args)
  C:/Program Files/Microsoft Visual Studio/2022/Community/Common7/IDE/CommonExtensions/Microsoft/CMake/CMake/share/cmake-3.29/Modules/FindPython3.cmake:545 (include)
  out/build/MSVC-Release/vcpkg_installed/x64-windows-digilens/share/python3/vcpkg-cmake-wrapper.cmake:72 (_find_package)
  C:/vcpkg/scripts/buildsystems/vcpkg.cmake:813 (include)
  src/wt_imageAnalysisPy/CMakeLists.txt:2 (find_package)

It seems that this is because of this section in vcpkg-cmake-wrapper is overriding cmake's default behavior for finding python in order to force that VCPKG's version is found.
Environment

OS: Windows

Expected behavior
CMake's find_package(Python3 3.12 COMPONENTS Interpreter Development REQUIRED) works even when VCPKg has installed Python

Full discussion in https://github.com/microsoft/vcpkg/issues/42323.


Update README.md - Fix broken link

What is it?

[ ] Feature / enhancement
[ ] Bug
[x] Docs / tests

Description
Fixed broken link
Use cases and why

One use case

Another use case

Checklist:

[ ] My code follows the developer guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

Nice catch @OmerHerera !
Thanks for the fix 🙏

Nice catch @OmerHerera ! Thanks for the fix 🙏

I added another fix to another link, that's not working


WIP: Tracecontext extension

Description

Clean up in comments
Add tests that set traceparent header

References
https://app.zenhub.com/workspaces/mighty-ducks---the-outlaws-6193fe815d79fc0011e741b1/issues/energinet-datahub/the-outlaws/346

Codecov Report

Merging #150 (9212e98) into main (02956d1) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #150      +/-   ##
==========================================
+ Coverage   66.79%   66.86%   +0.07%
==========================================
  Files         157      157
  Lines        2804     2804
  Branches      394      394
==========================================
+ Hits         1873     1875       +2
+ Misses        804      802       -2
  Partials      127      127

Flag
Coverage Δ

appcommon
39.95% <100.00%> (+0.45%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ce/App/source/ExampleHost.FunctionApp01/Program.cs
0.00% <ø> (ø)

....WebApi01/Controllers/WeatherForecastController.cs
84.61% <100.00%> (+1.28%)
:arrow_up:

....WebApi02/Controllers/WeatherForecastController.cs
93.75% <100.00%> (+0.41%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Frontend bugs

[ ] check verify form in: reefscan, remix, hardhat
[x] homepage search box should support evm addresses (accounts & contracts)
[x] remove "PolkaStats", "PolkaStats NG"
[ ] https://testnet.reefscan.com/contract/0x913208decfaf8829e81d1b1c12dc4037786f5b8d
[x] add header block time to the Chain.vue
[x] display accounts by EVM address https://testnet.reefscan.com/account/0x32e7509e5ad5c4ac47bdbfe2e237890c63df8214
[x] preloader for extrinsic Triggered Events
[ ] fix ./components/ContractCallFunctionWrite.vue https://github.com/reef-defi/reef-explorer/security/dependabot
[x]  contracts list item token link reloads whole page
[x] display transfers under token and transactions under contracts
[x] display ~0.00 on list and full decimals in detail view
[x] fix undefined value error https://testnet.reefscan.com/contract/tx/0x2ef8089c09f4ba2892098ba4bf201052563a57e2a67241dd1f2bd123029941a8
[x] display checksum case addresses
https://testnet.reefscan.com/contract/0xBC26364D2b3b94BeE7f3ce38799b0Ab3Fb1773A4

Also the router is still broken for checksum case addresses:
https://testnet.reefscan.com/contract/0xBC26364D2b3b94BeE7f3ce38799b0Ab3Fb1773A4

A few more issues:

The contract page is missing the transactions tab (all recent transactions related to the contract)
The tokens page should have developer tab removed (its totally irrelevant to the token)
The token tracker shows all accounts as token holders (https://testnet.reefscan.com/tokens). It should only show accounts that actually have tokens as token holders. Same goes for holders tab on tokens page.
Bytecode and constructor arguments on https://testnet.reefscan.com/contract/0xa53346a8438be1a73787d9b78c0e64f047669673 should be moved into developer tab to make the main page cleaner

The events page is broken https://testnet.reefscan.com/event/2129473/0/0


WIP: Add BeeWi SmartClim BLE temperature and humidity sensor

Description:
This PR adds beewi_smarclim sensor as a new component. It is based on the code of mitemp_bt component.
This PR is in progress.
Related issue (if applicable): fixes #
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for configuration.yaml (if applicable):
sensor:
  - platform: beewi_smartclim
    mac: 'xx:xx:xx:xx:xx:xx'
    name: Garden
    scan_interval: 60

Checklist:

[x] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[ ] There is no commented out code in this PR.
[ ] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @alemuro,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Please run script/gen_requirements_all.py and commit the changes.


Preview mode and Editor mode position are mismatch.

Hi,
Happy Chinese Spring Festival.
Thank you for providing us a colorful css for Obsidian.
I'd like to report an issue.
To reproduce the issue:
in the editor,  create a note with the following content
- 1
- 2
- 3
- 4
- 5
- 6
- 7
- 8
- 9
- 10

some text1

- somthing - something
- somthing - wrong
	- somthing - something
		- gggg
		- kkkk
		- kkkkkkk
	- somthing - something
	- somthing - something
- somthing - something
- somthing - something

Split the window vertically and then turn on the preview mode in one of the split windows(panel) and link the two panels(the edit mode panel and the preview-mode panel)
Now make the editing mode window(panel) the active window(panel), and scrolled down.
When the text "something-wrong" moves to the top of the edit panel, you will find in the preview panel the view moves quickly back to the top of the page.
Turning off the custom CSS will fix the issue, so I think this one is related to your .css.
Moreover, this is not a new issue. I've been using a .css file modified based on your .css file since last Oct. This issue was there since that time. Hope this information would be helpful for you to locate the problem.
Looking forward to your reply.

Happy CNY!
Thank you for your information. Reproduced, will check later.

Have Fixed. Will be released in the next version.

Thank you!
What number is the next version?

v2.1

Is there a quick fix that I can apply right now or can you provide some clues on how to tweak the css file by myself?

When I close the issue, I have finished the fix. And you can click 'use' in Community Themes of Obsidian to update.


Opengov cleaning leftovers

https://github.com/w3f/1k-validators-be/pull/2563#issuecomment-1918853863

Strategy agreed: complete removal, no retro compatibility assured

Not addressed yet:

[ ] https://github.com/search?q=repo%3Aw3f%2F1k-validators-be OpenGov&type=code

https://github.com/w3f/1k-validators-be/pull/2859
can be closed with this

#2859
can be closed with this

can you do something similar to what asked here ?

Leftovers found in the db also:


The ScrollController has spend a very high power.

Flutter Web is a program that automatically updates the Listview using the ScrollController.
url : http://grrrrtube.com
When the web is running, the strategy usage increases significantly.

In Firefox, too, power usage is very high.

C:\Users\ten10\IdeaProjects\grrrrtube>flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[√] Flutter (Channel dev, v1.15.3, on Microsoft Windows [Version 10.0.18362.657], locale ko-KR)
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.0)
[√] Chrome - develop for the web
[√] Android Studio (version 3.4)
[√] IntelliJ IDEA Ultimate Edition (version 2019.1)
[√] Connected device (2 available)
• No issues found!

CircularProgressIndicator() remove, solve it.


inconsistent use of t_bg and tspan_bg in ixdat.techniques.ms

maybe that's solved on one of the other branches already, but in the [fuzhou] branch (and possibly also [user_ready], I didn't check),  in ixdat.techniques.ms, the timespan of a background signal to subtracted in grab_signal() (and also grab_cal_signal) is passed by using the parameter "t_bg" (it IS a tspan that you pass there, I checked), while in the other, similar methods (like grab_flux() or grab_flux_for_t()) the parameter is called "tspan_bg".
https://github.com/ixdat/ixdat/blob/9433d5cf12d1d278c3d0b5639543f7f8d11d2d78/src/ixdat/techniques/ms.py#L88-L94
https://github.com/ixdat/ixdat/blob/9433d5cf12d1d278c3d0b5639543f7f8d11d2d78/src/ixdat/techniques/ms.py#L140-L147

Thanks. Should definitely be tspan_bg. Fixed everywhere I found it!


novastar splicer

This will break usage of this module for the hundreds of existing users. This is because some of the existing actions don't exist in your new version, and there is no upgrade script to fix up their configurations.
I haven't read this any further than that

The previous code does not support the existing companion V3.4 version. And we refactored the code. Several actions have been extended based on the previous actions

While the module is not in the v3 format, that doesn't mean it doesn't work with 3.0 or later.
Based on the limited usage stats we have, a majority of the current users are using 3.0 or later.

Several actions have been extended based on the previous actions.

But several actions (eg 'recall') have been renamed, which will cause any existing usages of them to break for users when they upgrade

Compared with recall, play preset is easier for customers to understand what it is used for, and their functions are the same.
In fact, the previous code is not compatible with the V3 version of companion.

May I quote myself from our Slack conversation two weeks ago:

Actually for you there is no difference in developing a completely new module, except that you will have to at least (re-)implement the existing three actions. You can change the action IDs or the options or configuration fields if you provide a matching upgrade script. Without an upgrade script you'll have to keep the action IDs and their options and the config options to not break existing configurations.

That's got nothing to do with v3 compatibility or how the actions appear to the user, there just has to be either internal compatibility or an upgrade path.

The previous module was developed by Novastar's customer, and it only supports the H series of splicers.
Due to the upgrade of Companion, their actions cannot be used.
Based on the customer's requirements, Novastar decided to create a project to support Companion's support for all series of splicers.
This project will not continue on the basis of the old project, so the previous module will be abandoned.
Novastar will provide users with new actions because the old actions can no longer be used. And we will communicate with product users to switch actions. So we will overwrite the old code.

In fact, the previous code is not compatible with the V3 version of companion. We will study the writing of upgrade files later.

That warning says the module may not work, it is not saying that the module is definitely broken. the hundreds of daily users of this module who use 3.x proves that it does work to some degree.

Novastar will provide users with new actions because the old actions can no longer be used. And we will communicate with product users to switch actions.

All we are asking is for you to provide an upgradescript (~20 lines of code) so that users don't have to do anything manually when they update to this version. They shouldn't need to know or care that the module had a large rewrite, it should continue working.
For other modules, you can take a companion config from 3+ years ago, import it into latest companion and all the actions will still be there and work, even though the module has been through 2 rewrites since then and renamed every action.

Is the upgrade file written based on the old code or based on my changes? We have never written an upgrade file before.We need to learn how to write

@Julusian Hi, I have added upgrade script, please review

@peternewman @Julusian Hi, May I know why this pull request was not approved?
Please let me know if this pull request has other problem. thanks

@Julusian Hi, I have added upgrade script, please review

@Julusian hey man can we have the upgrade script looked at. I love the current H module but would love to see some of these added improvements.

@novastarQQ this is on my list to final review over the next day.  I already did a once-over and think all the necessary changes are there but need to give it one more look.

Thanks so much

I've fixed the upgrade script so it actually works and cleaned up a few things.
What is the deviceId value and why was it effectively removed from this iteration where-as the old module let the user define is as 1-10 (indexed to 0-9)?

@novastarQQ @kman1898 see question in previous post.  That's the only blocking question/issue at the moment.

Device ID starts with 0 value in the code by default and user should be
able to see that as value 1 to avoid confusion as they ID THE DEVICE number
we are trying to control. They can go upto 20 devices in device ID.
It's same as Screen ID in the code
On Sat, Nov 30, 2024, 9:06 AM Keith Rocheck @.***>
wrote:

@novastarQQ https://github.com/novastarQQ @kman1898
https://github.com/kman1898 see question in previous post. That's the
only blocking question/issue at the moment.
—
Reply to this email directly, view it on GitHub
https://github.com/bitfocus/companion-module-novastar-h-series/pull/13#issuecomment-2509075900,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC5RXGAKS6DCSBDZVESNZEL2DHWCPAVCNFSM6AAAAABI4O3H5OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZGA3TKOJQGA
.
You are receiving this because you are subscribed to this thread.Message
ID: <bitfocus/companion-module-novastar-h-series/pull/13/c2509075900@
github.com>

Device ID starts with 0 value in the code by default and user should be able to see that as value 1 to avoid confusion as they ID THE DEVICE number we are trying to control. They can go upto 20 devices in device ID. It's same as Screen ID in the code
@rit3sh7 Does it makes sense to you that the actions switch from the user being able to define the ID to it simply being hard-coded as 0 in this PR?

no, user should have choice to change that value.

On Nov 30, 2024, at 11:33 AM, Keith Rocheck @.***> wrote:
Device ID starts with 0 value in the code by default and user should be able to see that as value 1 to avoid confusion as they ID THE DEVICE number we are trying to control. They can go upto 20 devices in device ID. It's same as Screen ID in the code
@rit3sh7 https://github.com/rit3sh7 Does it makes sense to you that the actions switch from the user being able to define the ID to it simply being hard-coded as 0 in this PR?
—
Reply to this email directly, view it on GitHub https://github.com/bitfocus/companion-module-novastar-h-series/pull/13#issuecomment-2509166755, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC5RXGBI4UTDWQJDJPUVKB32DIHHFAVCNFSM6AAAAABI4O3H5OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBZGE3DMNZVGU.
You are receiving this because you were mentioned.

@krocheck Sory for the late reply. I just confirmed with the H series developer that the default value of deviceId in the protocol is 0, so you can see that in the new module, I made the default operation of deviceid 0. Although the old module can enter deviceId, the default value is 1, and when sending the protocol, it is processed as 0. So this change has no effect

@krocheck Sorry for the late reply. I just confirmed with the H series developer that the default value of deviceId in the protocol is 0, so you can see that in the new module, I made the default operation of deviceid 0.JSON.stringify([{ ...params, cmd: ACTIONS_CMD[actionId], deviceId: 0 }]) Although the old module can enter deviceId, the default value is 1, and when sending the protocol, it is processed as 0. So this change has no effect

@novastarQQ I understand and you've confirmed what I saw and questioned, but I don't think you answered my underlying question: why can't the user define this under your changes when they used to.  @rit3sh7 has indicated that deviceId should be able to be defined by the user as 1-20 (indexed to 0-19), but this implementation would now lock it down just 1 (index 0).
Can someone please answer in real terms how deviceId applies to real world setups involving these processors and sending commands to them.  I'd like to just merge this, but it seems like the users are losing functionality if this get locked down via this PR.

@rit3sh7 The commands sent are all to the connected device. Can I send them to other devices by entering deviceId? It is normal that screenId can be entered because a device has multiple screens

Yeah I’m not sure why deviceID matters in any of these commands. Since each connection only connects to one H series via an IP. So they should all be deviceID.

If you notice deviceID isn’t detailed in the command protocol parameter descriptions which to me seemingly means it’s irrelevant.

So after discussing with the R&D team for H series at Novastar they said the deviceID being above 0 is really only relevant for serial commands using the com ports with multiple H’s cascaded together. Since companion is using the UDP aspect of the control protocol and not the serial deviceID will always be 0.


Remove raw __cplusplus checks.

This is not defined correctly on MSVC -- the CUB_CPP_DIALECT macro provides a correct value.
This is needed for the C++ dialect deprecation patch.
CI in shelve 28211130.

New shelve 28219812

New shelve 28221412

Merging with #5.

Make sure to put the "Reviewed-by:" line in this commit (one for each reviewer).


update GraphiQL link

removed section:

"We are using GraphiQL for our example GraphQL queries."
as GraphiQL dashboard no longer exists (404)

@stefanogramm Thank you for noticing that the link no longer exists. I've corrected it.


Create unmount function

This allow unmount nodes, useful when use router system

The code has changed significantly between 2.0.7 and 2.0.8 and unmount function is now implemented. I wanted to fix couple of other related issues at the same time.
Thanks, hope it works for you!


Fix issue associated with other pages unable to scroll

After loading a page with an element having the no-scroll directive, other pages were not able to scroll when navigating to them.

Thanks!


Written interview about Wren

First of all sorry @munificent for using github issue, but I have not found any other better way to contact you. I am interviewing different programming language creators about the reasons why they have created the language, how they did it, what design choices they have faced, how it compares to other languages, etc.
For the moment I have only published only one interview with pretty good success and comments:
https://medium.com/indie-programming-languages
Let me know if you are interested in answering a small interview!
THANKS in advance
PS: Leave me a contact if you don't like to talk via github issues.

Sure, sounds like fun. You can email me at robert at stuffwithstuff.com. :)


Include Trusty AI on OOTB notebook images

Include Trusty AI on OOTB notebook images
fixes: https://github.com/opendatahub-io/notebooks/issues/50
Description
This PR introduces a new Jupyter Notebook image that integrates the TrustyAI Explainability Toolkit into ODH.
The TrustyAI image has been derived from the jupyter-data-science notebook and it gets updated with the newest TrustyAI 0.2.9.
How Has This Been Tested?
Build the image by running:
make jupyter-trustyai-ubi9-python-3.9
Run the TrustyAI and ensure its functionality by running:
podman run -it --rm -p 8888:8888 quay.io/rh_ee_atheodor/notebooks:jupyter-trustyai-ubi9-python-3.9-2023a_20230314
Merge criteria:
Note: Should be get merged the Openshift-CI PR -> https://github.com/openshift/release/pull/37279 first.

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

Looks good
/hold until CI job is added for testing

/test all

/test notebooks-e2e-tests

/unhold

/approve


Automate the process for testing db backups

Follow up for #337. In 337, we created a helm template & make target in the cas-obps-postgres repo that will deploy a postgres cluster to a destination namespace (we used our -tools namespace) and restore that cluster from a source namespace's database backups.
We can likely automate this process. The automated test process should:

spin up and restore a cluster from a specified namespace's db backups in a separate namespace (-tools)
if the cluster fails to restore, send an email to a notification list
if the cluster fails a recency check (daily timestamp?) it should also send an email to a notification list
if the cluster fails either check, it should not be torn down (so it can be investigated)
if the cluster restores properly and passes a recency check, it should tear down the cluster.

There is an example in the CIF repo where this was done previously (without the email notification steps) which can be used as a starting point on how to implement this:
https://github.com/bcgov/cas-cif/tree/develop/database_backup_test
original PR for cas-obps-postgres: https://github.com/bcgov/cas-obps-postgres/pull/7
The CIF example works like this:

Adds a timestamp daily to a db table in the source db
Runs the restore job to the -tools namespace on a schedule (cronjob)
Runs a job to check that a timestamp exists within the last 24hours
Tears down the cluster (helm uninstall) if the timestamp exists

related to #2197 (likely becomes easier once 1637 is done)


Annotation "checked" in package:meta should be moved to a core lib

The annotation @checked (currently declared in package:meta) doesn't just affect analyzer hints and lints; it affects the semantics of code compiled via DDC.  IMHO, annotations that affect semantics should be in a "dart:" library somewhere, not in a package.
This would allow us to clean up a kludge that is currently present in the analyzer code base: it currently recognizes the @checked annotation by looking at the library it's defined in and seeing if that library's name (according to its "library" declaration) is meta.  This is brittle because any library could be named meta.

@virtual is in the same boat.

CC @leafpetersen ... FYI @stereotype441 the one catch here is these are probably temporary annotations that will be replaced with real syntax. So adding them to dart:core may not be the best idea. Or that's what we were thinking with package:meta.

@jmesserly Absolutely correct :)
That the annotation changes behavior is a DDC specific choice. The Dart language specification doesn't mention those annotations, and they have no effect on other implementations.
It's unlikely that the Dart 2 specification will mention the annotations - either the functionality will be made part of the language, or it will not, in either case the annotation will not affect the runtime behavior.
Currently DDC is not a Dart 1 implementation, it's implementing the "strong mode" semantics which somewhat like a subset of checked mode, and these annotations are, I guess, a way to opt in to a different behavior than the default, but a behavior that the Dart specification already allows anyway (by way of being extremely lenient in general).

About the analyzer's detection of checked, it could perhaps check that the declaration originates in package:meta/meta.dart (I assuming that's the URI). That means that it hard-codes the package name, which is annoying but probably unavoidable. Libraries don't have any other identity than their URI.

I don't have a strong preference for where the annotation is defined, but I will point out that the annotations deprecated and override are both defined in dart:core even though neither are defined by the specification (and nether have any run-time implications under any platform).

I'm not sure that putting these into dart:core is a good idea, unless we're very comfortable just taking them out again soon.  This is a prototype of something that may go into Dart 2.0, and will almost certainly go away whether or not the choice is made to incorporate it.


[Suggestion] Make the roadworks event callable through the comms console

I'll be starting by saying thank you for your work. Also I am sadly incompetent with programming so I couldn't do it myself.
One of the most useful things in the mod imo is the roadworks event but it is incredibly rare. Is there a chance to make it so that the event can be triggered by using the comms console? Maybe add a premium since it's you that initiates the suggestion.
In case it helps, this mod adds the choice to call for trade ships through the comms console
https://github.com/KiameV/rimworld-calltradeships
Thanks for your consideration.

Looked it over and its a bit beyond what time I have over, sorry!


Support arbitrary container runtimes via provisioning-time images

We ship Flatcar by default with Docker / Containerd, which suits most, but not all, use cases:

some require older / newer Docker versions than what we ship
some do not use Docker and work with containerd directly
some use entirely different container runtimes like CRI-O or podman

Using systemd-sysext, we would be able to support a custom container stack at provisioning time, e.g.

picking from multiple Docker versions, or don't use Docker at all but work with containerd directly
use a different container runtime, e.g. crun instead of runc
use an entirely different stack, like podman

One thing to keep in mind is that we need to migrate our internal Docker usage (Toolbox, flannel/etcd services, BCC tool aliases)  to something that is not manged by the user. We could for example have a tool in the image that allows us to download and unpack container images, and then use systemd-nspawn for that, but actually I would rather like to see Podman as part of the base image because it fits quite well for that task as it has no daemon requirement and works separate from, e.g., containerd which may be manged by the user.

Docs for this are already there:
https://www.flatcar.org/docs/latest/provisioning/sysext/#upstream-docker-sysext-images
https://www.flatcar.org/docs/latest/provisioning/sysext/#supplying-your-sysext-image-from-ignition
What's left is to now extend the docs section for systemd-sysupdate because it's part of Flatcar Beta already:
https://www.flatcar.org/docs/latest/provisioning/sysext/#updating-custom-sysext-images

Docs for sysupdate are done. The final things to do is rip out Torcx to get rid of the file entry to disable it.


MIAD-225 Add query param ?allowInactiveCode=true to create alert api call

MIAD-225

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.37%. Comparing base (48d473f) to head (15d4fe6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #98   +/-   ##
=======================================
  Coverage   85.37%   85.37%
=======================================
  Files          68       68
  Lines        1757     1757
  Branches      254      254
=======================================
  Hits         1500     1500
  Misses        254      254
  Partials        3        3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


3D Heightfield: Runtime: unreachable

No matter what I provide to the collider description, 3d heightfields always seem to throw this error:
0050af16:0xffe45 Uncaught (in promise) RuntimeError: unreachable
    at 0050af16:0xffe45
    at 0050af16:0x1303c4
    at 0050af16:0xfb6c1
    at Function.heightfield (rapier_wasm3d.js:3585:26)
    at oI.intoRaw (shape.ts:969:33)
    at aI.createCollider (collider_set.ts:65:35)
    at FI.createCollider (world.ts:342:31)
    at terrainCollider.ts:29:28
    at Generator.next (<anonymous>)
    at Effect.ts:79:37

last line of JS code before the exception is thrown:
        const ret = wasm.rawshape_heightfield(nrows, ncols, ptr0, len0, scale.ptr);

My heightfield is 257x257, the Float32Array of heights is correspondingly 66049 entries in size. But I've also tried a 2x2 heightfield full of 0s, same error.
I'm using @dimforge/rapier3d-compat Version is 0.8.1.

https://github.com/viridia/demo-rapier-three/blob/main/src/terrain/TerrainShape.ts#L108


malloc assert!

I have been working with this wonderful library.
in my latest project i am trying to send a "RFID number" using esp8266.
I am getting the error "malloc assert!" in my serial window of arduino.
The sequence of events shown in my serial monitor of arduino are as follows:
"ARDUINO: setup wifi
ARDUINO: system started
scandone
add 0
aid 7
pm open phy2,type:2 0 0
cnip:<IP_ADDRESS>,mask:<IP_ADDRESS>,gw:<IP_ADDRESS>
CONNECTED TO WIFI NETWORK
mqtt Connected Successfully
null
malloc assert!"
for all other programs that i have done, i have not encountered this issue. So, i can say its because of RFID that i might be getting this problem.
My question is, is this the issue with esp8266 or the library? because, i am unable to find "malloc assert!" sentence anywhere in the mqtt library.
sorry for the long question. Hope anyone can help me out! Thanks in advance..

I have the same problem when I'm doing something more with the mqtt example code. I'm trying to read sensors via I2C, an IR remote control, a motion sensor and sending the results via mqtt to FHEM and a TFT Touch Display (UTFT).
When I comment out some code fragments then it works so I think, it's a timing problem.
I'm using an Arduino Mega2560 R3 and IDE 1.6.12 portable on Windows x64.
I hope that helps a little. I'm giving up.
Familienpapi

This issue was with the ESP01 module having 512Kb memory (The blue ones)..
The ESP01 available in the market now have 1Mb memory (brown color modules). I am no longer facing issues with these new modules now! :)


Fix undefined dtypes being passed in kwargs of stat tests

@asmeurer noted undefined dtypes could be passed as the dtype kwarg for test_prod, i.e. for pytorch (using https://github.com/data-apis/array-api-compat/pull/14).
$ ARRAY_API_TESTS_MODULE=array_api_compat.torch pytest --disable-warnings array_api_tests/test_statistical_functions.py::test_prod
...
TypeError: prod() received an invalid combination of arguments - got (Tensor, dtype=_UndefinedStub), but expected one of:
Falsifying example: test_prod(
    x=tensor(0, dtype=torch.uint8), data=data(...),
)
Draw 1 (kw): {'dtype': <undefined stub for 'uint32'>

This PR filters the pool of available dtypes so this doesn't happen for either test_prod or test_sum. Note these tests will still fail for pytorch as it doesn't follow the prod/sum-specific type promotion rules of the Array API.

This fixes the issue I was having. Thanks.


Intel SoC FPGA Agilex Device Tree Restructure

This patch restructures system manager, reset manager, peripheral and pinmux device driver nodes into one device driver node: periph. System manager, reset manager and pinmux device does not attach to any driver but is still needed to map the memory in MMU to access the registers.

Accidentally added unnecessary patches. Closing pull requests


Add an option to prefix all sqlite3 symbols with cesium_

This helps us avoid a conflict with other sqlite implementations, notably the limited one built into Unreal Engine.
The way it works is by, at configure time, reading sqlite3.c and sqlite3.h, doing a search/replace of sqlite3 with cesium_sqlite3, and writing the output to the build directory. The rewritten files are then added as the sqlite3 target's source and include files. They're written using file(GENERATE OUTPUT ...) so they won't be rewritten (and thus recompiled) unless they actually change.
Now in our code, we wrap all use of SQLite symbols in a macro, CESIUM_SQLITE, defined in cesium-sqlite3.h, which prefixes the symbol with cesium_ only if the build is configured to rename the sqlite symbols. The end result is a configure-time selection of whether to privatize the sqlite3 symbols or not.
I also refactored SqlCache slightly to use the pimpl idiom to avoid exposing sqlite types in a public header file. This way we don't expose the renaming (or lack of renaming) to users of cesium-native.

I'm going to merge this once CI is happy, because (I just realized) cesium-unreal already uses it as of when I merged CesiumGS/cesium-unreal#443.


Fixed #30786 -- Used CONVERT_TZ to check if the time zone definitions are installed on MySQL.

Replaced a timezone check in the MySQL backend with one that
doesn't require access to the mysql.time_zone database and more
closely aligns with Django's usage of the timezone info.

@recvfrom Thanks!


Add audio setup

I have added audio setup because looks like many people don't understand Linux ALSA system.
This addresses also #68 #74
Tell me what you think :)

Shall we put this info in the Wiki, and make a link to it? I feel it will bloat the README?

I separate it to other md files. Wiki are not very good because everyone can modify them :P

We can lock down Wiki so only we can edit :)
https://help.github.com/articles/changing-access-permissions-for-wikis/
What do you think? Or do you think multiple readmes are better?

Lets try multiple md files? We get better version history etc :D

Github provides as as good history with Wiki :)
https://github.com/dolanmiu/MMM-awesome-alexa/wiki/Contribution-Guide/_history

Okay now I have separated installation and audio setup :)

Btw, there are a few articles on the Wiki, shall we port this to the docs folder as well?
They are mainly about getting AVS tokens

Sure. Although I think there should be only one guide for avs tokens. This will confuse people. At least it confused me a lot when I was beginning with this module :D

Yeah totally agree
My thinking process was... if first one dont work, try second! if not, try third! :joy:


Refactor to reflect current product names

PR for https://github.com/ubiquity/ubiquity-dollar/issues/292
Notice:

There is no refactoring in the ubiquistick folder because it wasn't mentioned in the task
renamed CurveUADIncentive.sol to transfer-hooks/CurveDollarIncentive.sol instead of transfer-hooks/dollar3pool.sol because IMHO filename should be equal to contract name
Frontend should be completely broken after these changes (need a task to fix it)

When this PR is merged I will update this wiki page: https://github.com/ubiquity/ubiquity-dollar/wiki/18.-Smart-Contracts

FYI: somehow I don't have rights to add reviewers to this PR

FYI: somehow I don't have rights to add reviewers to this PR

If you follow the PR template (uses keyword "resolves") it will automatically associate this PR with the bounty/issue. This is important for fastest response/organization of the issues/bounties. No need to assign reviewers as it generally is @0xcodercrane and myself. We can assign amongst ourselves!

@pavlovcik @0xcodercrane
guys pls check

Unless we're planning on redeploying and reminting the UBQ token to all current holders then changes to UbiquityGovernanceToken.sol should be reverted, especially the minter roles with UbiquityDollarManager.
uGOV was never a good variable as there is no token with that symbol and the contracts should still be updated to reflect that.

Unless we're planning on redeploying and reminting the UBQ token to all current holders

We could do a "spoon" and distribute. With only 105 holders, doing an airdrop is definitely in the cards.


Installing aws cli version 2 and/or its dependency for the help subcommand

Using an image built FROM pangeo/pangeo-notebook:2021.05.15 I'm using the aws CLI.

I wonder if you think we should install version 2 of the CLI (curl, unzip, :scream:, move on filesystem, done, :nauseated_face:).
I also wonder if you think we should install groff (an apt package). Apparently it is a dependency to run help sub-commands of like aws s3 help but groff isn't available by default in the pangeo-notebook image.

Example output with aws CLI v1 trying to use help sub-command
$ aws
Note: AWS CLI version 2, the latest major version of the AWS CLI, is now stable and recommended for general use. For more information, see the AWS CLI version 2 installation instructions at: https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2.html

usage: aws [options] <command> <subcommand> [<subcommand> ...] [parameters]
To see help text, you can run:

  aws help
  aws <command> help
  aws <command> <subcommand> help
aws: error: the following arguments are required: command

$ aws help

Could not find executable named "groff"

I wonder if you think we should install version 2 of the CLI and groff

sure! feel free to open a PR for this @consideRatio . I think having the recommended CLI tools for GCP, Azure, and AWS is helpful and they don't take up too much space I think.

I found that this issue still exists in the latest images, and that groff is an formal requirement based on the official install instructions:

I'll open a PR about this.

Hmmm @scottyhq I don't understand this well enough.
There are several .apt.txt files. Should this apt package be added to all, if all of these install awscli via conda-forge that relies on this apt package?
.binder/apt.txt
pangeo-notebook/apt.txt
pytorch-notebook/apt.txt
ml-notebook/apt.txt


Make service account creds required for google oauth

In the absence of service account creds, non-admin users from google's
hosted domain cannot lookup groups, even their own groups. (Restriction
from google api). So even during login we can't find out what groups the
user belongs to. Admins of hosted google domain do not have the same restriction.
So they can still search for and add groups that non-admin google users
belong to. This will cause lot of inconsistencies, since admins can add
a user's groups, but user still won't have access to rancher. So making
service account credentials a required field will avoid all this, and
searching users/groups will work equally for all google users.
Hostname should not be updatable once auth is setup, since the
principalIds assigned to users after they log into rancher contain
their google addresses which have the hostname.

LGTM


[Upgrade] Upgrade from Hue 4.1 to Hue 4.4 cause user creation unavailable

the reason is that,  the field last_login in the table auth_user cannot be null in hue 4.2 while nullable in hue4.4. After upgraded hue from 4.2 to 4.4 (with both syncdb and migrate
executed), the schema is NOT changed any more.
fix this with the sql below (mysql):
ALTER TABLE auth_user MODIFY last_login datetime null;

Maybe we should add this into migrate command.

can you confirm that you ran:
hue migrate --fake-initial

can you confirm that you ran:
hue migrate --fake-initial

Hi, @jdesjean I just run hue migrate, i should run hue migrate --fake-initial instead, right?

Correct.

So, how can I closed this issue?

Perfect.

@linwukang
Does it work to you when you execute hue migrate --fake-initial?
I'm trying to upgrade my exists HUE 4.2 to HUE 4.4 in AWS EMR,
when I execute below command it shows success, but I didn't see any data migrated from hue 4.2 to hue 4.4, do you have any suggestion?
$ sudo /usr/lib/hue/build/env/bin/hue migrate --fake-initial
Operations to perform:
Apply all migrations: admin, auth, axes, beeswax, contenttypes, desktop, django_openid_auth, jobsub, oozie, sessions, sites, useradmin
Running migrations:
Applying contenttypes.0001_initial... FAKED
Applying auth.0001_initial... FAKED
Applying admin.0001_initial... FAKED
Applying admin.0002_logentry_remove_auto_add... OK
Applying contenttypes.0002_remove_content_type_name... OK
Applying auth.0002_alter_permission_name_max_length... OK
Applying auth.0003_alter_user_email_max_length... OK
Applying auth.0004_alter_user_username_opts... OK
Applying auth.0005_alter_user_last_login_null... OK
Applying auth.0006_require_contenttypes_0002... OK
Applying auth.0007_alter_validators_add_error_messages... OK
Applying auth.0008_alter_user_username_max_length... OK
Applying axes.0001_initial... FAKED
Applying axes.0002_auto_20151217_2044... OK
Applying axes.0003_auto_20160322_0929... OK
Applying axes.0004_auto_20190514_1321... OK
Applying beeswax.0001_initial... FAKED
Applying desktop.0001_initial... FAKED
Applying desktop.0002_initial... FAKED
Applying desktop.0003_initial... OK
Applying desktop.0004_initial... OK
Applying desktop.0005_initial... FAKED
Applying desktop.0006_initial... FAKED
Applying desktop.0007_initial... FAKED
Applying django_openid_auth.0001_initial... FAKED
Applying jobsub.0001_initial... FAKED


[WFCORE-6618] Upgrade BouncyCastle from 1.76 to 1.77

Jira issue: https://issues.redhat.com/browse/WFCORE-6618

@jimma @jamezp Thanks for the review!


Cache memory

Hi,
I have little problem with memory during upload and resizing image. I just upload file, get metadata, resize and save to disk and my memory increase about 330MB and stay on this high level.
Here is my cache stats:
{ current: 2, high: 4, memory: 100, items: 500 }
After disable cache sharp.cache(0) memory increase only about 15MB.
Is this normal behavior? I think cache has memory limit 100MB.

After investigation ... Death to progress jpeg!!
https://github.com/jcupitt/libvips/issues/77

Glad you solved it. There'll be some enhancements to how libvips' cache is exposed and configured from sharp v0.13.0.

Yeah, we disabled cache globally.
Actually I have little doubts  about behavior of libvips cache with progressive jpeg.
Default, there is 100MB maximum memory size of cache. Why resize operation of progressive jpeg allocate over 300MB of memory in cache? Maybe I don`t understand memory limit of libvips cache ?

Memory allocated outside libvips is not included and I suspect libjpeg needs a lot of its own working memory for progressive decode.

Of course. Thnx for explanation ;)
First I saw increase memory (dont know used image is progressive jpeg) I thought it is memory leak.
Maybe disable cache for progressive jpeg could be nice improvement (sharp/libvips).


Enzyme.jacobian(Forward. multiarg

This was just released if you want to have multiarg forward mode fall back to Enzyme.jacobian as well @gdalle

Thanks! I'll benchmark to see if it compares favorably to the DI native implem


Improve MNE performance in IDEs / Limit object string representations

Describe the new feature or enhancement
I have the unfortunate case of having MNE epochs that have a vast number of unique events (> 4000). While this may be a fault of my data not using the metadata property, this still leads to bad performance of MNE in, e.g., PyCharm.
PyCharm has a "Variable Explorer" window which (as I suspect) makes use of the string representation of current objects in memory and updates after each update, e.g., when executing a line in the interactive python console. Unfortunately, in the case of BaseEpoch the string representation sorts and enumerates all events, leading to quite the large string representation when an epoch has many events.
https://github.com/mne-tools/mne-python/blob/0789b7dade297a7e5cae10a343a870ed260ab9a0/mne/epochs.py#L1664-L1667
Even without sophisticated IDEs, in my work flow I often execute code in a console interactively. E.g. to take a quick look at the epoch object i simply type epochs and press enter, as the default for python consoles is to print the string representation of the objects. Currently this takes around 20 seconds to print on my machine.
Describe your proposed implementation
Replace the above lines with
        events_limit = 10
        counts = ['%r: %i' % (k, sum(self.events[:, 2] == v))
                  for k, v in sorted(self.event_id.items())[:events_limit]]
        if len(self.event_id) > 0:
            s += ',' + '\n '.join([''] + counts)
        if len(self.event_id) > events_limit:
            not_shown_events = len(self.event_id) - events_limit + 1
            s += f"\n 'and {not_shown_events} more events ...'"

For my epoch object, the above change reduces len(epochs.__repr__()) from 257655 to 717 chars. Example output:
>>> epochs
<Epochs |  4283 events (all good), -0.2 - 0.75 sec, baseline off, ~20.3 MB, data loaded,
 'Letter_1/Sequence_1/NonTarget/A/B/G/J/L/Q/R/T/W/Y/ /?': 1
 'Letter_1/Sequence_1/NonTarget/A/C/D/J/K/L/O/S/X/./!/<': 1
 'Letter_1/Sequence_1/NonTarget/A/C/E/G/J/K/L/P/W/Z/,/<': 1
 'Letter_1/Sequence_1/NonTarget/A/D/G/H/K/M/N/U/V/W/Y/?': 1
 'Letter_1/Sequence_1/NonTarget/A/D/H/M/O/Q/T/W/Y/Z/,/<': 1
 'Letter_1/Sequence_1/NonTarget/A/D/H/M/P/Q/T/W/Y/!/?/<': 1
 'Letter_1/Sequence_1/NonTarget/A/E/G/I/L/O/Q/S/U/Y/./?': 1
 'Letter_1/Sequence_1/NonTarget/A/E/G/J/L/N/P/Q/S/U/ /?': 1
 'Letter_1/Sequence_1/NonTarget/A/E/H/I/K/O/R/T/U/./,/?': 1
 'Letter_1/Sequence_1/NonTarget/B/C/D/G/L/N/P/W/X/Z/,/!': 1
 'and 4273 more events ...'>

Describe possible alternatives
One could also add an optional keyword to __repr__, then one could replicate the old behaviour by calling epochs.__repr__(full=True). Or one could instruct people to not use so damn many events when they could use metadata :)

For my epoch object, the above change reduces len(epochs.repr()) from 257655 to 717 chars. Example output:

That looks good to me, agreed 10 events is a reasonable limit

+1 to fix this.
can you open a PR?

+1 I ran into this before (also because I didn't use .metadata properly :wink: )


Binder starter URL not workin after jupyter-starters upgrade

Binder URL to start with a starter
https://mybinder.org/v2/gh/robots-from-jupyter/robotkernel/master?urlpath=lab/tree/starter/robotkernel-quickstart
stopped working after upgrading to starters 1.1.0 with error
Cannot open
Could not find path: starter/robotkernel-quickstart

According to docs, this is the right format
https://mybinder.org/v2/gh/robots-from-jupyter/robotkernel/master?urlpath=lab%3Fstarter%2Frobotkernel-quickstart%2F
but neither does that work.
Starters are visible and work well from launcher.
Related files:

https://github.com/robots-from-jupyter/robotkernel/blob/master/binder/postBuild
https://github.com/robots-from-jupyter/robotkernel/blob/master/binder/environment.yml

@bollwyvl Would you see something obvious missing, why jupyter-starters URL stopped working?
Kernel extension should be there:
$ jupyter serverextension list
config dir: /srv/conda/envs/notebook/etc/jupyter
   jupyter_starters  enabled
   - Validating...
     jupyter_starters 1.1.0 OK
   jupyter_resource_usage  enabled
   - Validating...
     jupyter_resource_usage 0.6.1 OK
   jupyterlab  enabled
   - Validating...
     jupyterlab 3.2.9 OK
   nteract_on_jupyter  enabled
   - Validating...
     nteract_on_jupyter 2.1.3 OK
   jupyter_offlinenotebook  enabled
   - Validating...
     jupyter_offlinenotebook  OK


[Feature Request][Dashboard] Add logs to Dashboard

This is just a suggestion from me. If possible, it will be much easier when we need to provide logs to you.

Yes! Now you can observer events using Event Monitor, but we're working on proper logs solution too!
it'll work on for default "docker-compose" installation tho, I don't think we'll add more complex scenarios for that - if one have k8s or portainer you probably already have something like Grafana or other logs solutions

OK, thank you
Looking forward to your updates


Refactor test_experiment_step_termination.py***

(from unit test to pytest)
Description
converted a unit test case that uses the unit test to pytest. On the official website of pybamm  I saw that they are considering migrating from unit test to pytest.

Thanks for starting this @abhicodes369. It looks good, but ideally we want to do this after #3617, so I will let this sit for a while until that is complete and pytest is added to the codebase. If you're interested in contributing, please feel free to discuss something over there since multiple people can be assigned to that issue 🙂

@abhicodes369, if you're interested, you can help drive #3857 to completion – or we can take this up again after it gets merged (should be about a week at most).

I will look into it

@allcontributors please add @abhicodes369 for tests

thanks @agriyakhetarpal it really means a lot


[3.x] Rename admin to twill

This is about:

[x] routes/admin.php
[x] app/Http/Controllers/Admin
[x] app/Http/Requests/Admin
[x] resources/views/twill/admin

Maybe also move:

[x] app/Repositories to app/Repositories/Twill

Might miss some here.

@ifox Should we maybe make the default location for "preview" files also part of the twill namespace?
This way, all of twills view resources are combined.

[ ] resources/views/twill/previews/layout/block.blade.php
[ ] resources/views/twill/previews/{blog.blade.php|...}
[ ] resources/views/twill/previews/{blocks|repeaters}/...

Try to see if we can automate the upgrade using rector php

This is completed and merged into 3.x


Problem loading data from bio.tools

I get an error about loading data from bio.tools when looking at https://biotools-sum.firebaseapp.com/.  No data is visible in the demo.
@krab1k  - hi!  more generally, what's the status of this project?

I get an error about loading data from bio.tools when looking at https://biotools-sum.firebaseapp.com/. No data is visible in the demo.

This version is no longer maintained, the current one is available at official ELIXIR CZ website: https://www.elixir-czech.cz/services

@krab1k - hi! more generally, what's the status of this project?

We did some development for one internal ELIXIR CZ project. The goal would be to show selected tools from one domain along with evaluation of tools by domain experts in various categories. See https://bio-tools-mk.firebaseapp.com/views/evaluation for an example. (The actual data are not real yet.)


Modal: "Base" and "No footer" stories fixed in Storybook

This change: (check at least one)

[ ] Adds a new feature
[x] Fixes a bug
[ ] Improves maintainability
[ ] Improves documentation
[ ] Is a release activity

Is this a breaking change? (check one)

[ ] Yes
[x] No

Is the: (complete all)

[x] Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
[ ] Test suite(s) passing?
[ ] Code coverage maximal?
[x] Changeset added?
[ ] Component status page up to date?

What does this change address?
Fixes #527

Fixed React Storybook for Modal
Fixed Web Component Storybook for Modal

How does this change work?

'id' and 'data-modal-id' were missing from Base and No Footer Modal Storybook

Additional context
Add any other context here.

Thanks for this submission! One thing to update regarding the release version.

Done!


react(buttons): Ability to append and/or prepend icons

Ability to append and/or prepend icons
Description
Added new props appendIcon and prependIcon to  which take in an  element and renders it inside the button
Related Issue
#236
Motivation and Context
As per Momentum Design spec
How Has This Been Tested?

Jest snapshot testing

Screenshots:

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

I actually took care of the React and Core changes in #252


Embed predefined bootstrap peers list into the client

Depends on https://github.com/keep-network/keep-common/pull/99
The client requires a list of network peers to connect to. The list had to be configured by a user under the ethereum.network.peers property. To simplify running the node we will embed into the client the list of bootstrap peers supporting a given Ethereum network.
When running the client a user can use one of the flags: --mainnet, --goerli or --developer to specify against which Ethereum network the client should be started. If non of the aforementioned flags is set, the client will assume --mainnet
If the list of peers in the config file under ethereum.network.peers is empty the client will resolve the default peers that were set in the client build.
The bootstrap peers configuration is expected to be provided in the config/_peers/ directory in a separate file for each network.
If the client is run with --developer flag, the peers are expected to be set in the config file, they won't be resolved automagically.

For future us testing on Goerli network:

build a client: make goerli
run a client:

KEEP_ETHEREUM_PASSWORD=$(cat ./<path_to_password_file>) go run . start --ethereum.url wss://<endpoint> --ethereum.keyFile ~/ethereum/data/keystoreGoerli/keyfile.json --storage.dataDir /Users/dp/.keep/keep-core/storage/client-v2 --goerli

Resulted in connected client:
libp2p/libp2p.go:226	number of connected peers: [2]

Some general thoughts about this approach.. What is kind of itchy is that we couple concrete networks into our codebase. Imagine we would do that a couple of months ago when testing on Ropsten, it's gone now. Same with other testing networks. My point is that it might happen to Goerli as well and then we would need to clean this code. Even if we add or remove a network then we need to change code at least in a couple of places (which I guess is not the end of the world, but some additional thing to remember about). I'm not 100% sure what would be the optimal approach here yet, maybe coding against some abstract networks that support default peers and networks that do not. These networks list might live in a config file with their respective chain ids. Or some other solution with a "one stop for networks list" and code against that list.

Don't we need to update /scripts/start.sh and pass a --developer flag?

Don't we need to update /scripts/start.sh and pass a --developer flag?

Good catch! ef5dec08ea364d7422de8246c2db0c8fbfeb33f7

Some general thoughts about this approach.. What is kind of itchy is that we couple concrete networks into our codebase. Imagine we would do that a couple of months ago when testing on Ropsten, it's gone now. Same with other testing networks. My point is that it might happen to Goerli as well and then we would need to clean this code. Even if we add or remove a network then we need to change code at least in a couple of places (which I guess is not the end of the world, but some additional thing to remember about). I'm not 100% sure what would be the optimal approach here yet, maybe coding against some abstract networks that support default peers and networks that do not. These networks list might live in a config file with their respective chain ids. Or some other solution with a "one stop for networks list" and code against that list.
Having said that, and if we agree on the above, then I'd start with some smaller steps and merge this PR first. Then we can think about refactoring.

Good point, I'm not sure right now how we could approach it.

Some general thoughts about this approach.. What is kind of itchy is that we couple concrete networks into our codebase. Imagine we would do that a couple of months ago when testing on Ropsten, it's gone now. Same with other testing networks. My point is that it might happen to Goerli as well and then we would need to clean this code. Even if we add or remove a network then we need to change code at least in a couple of places (which I guess is not the end of the world, but some additional thing to remember about). I'm not 100% sure what would be the optimal approach here yet, maybe coding against some abstract networks that support default peers and networks that do not. These networks list might live in a config file with their respective chain ids. Or some other solution with a "one stop for networks list" and code against that list.
Having said that, and if we agree on the above, then I'd start with some smaller steps and merge this PR first. Then we can think about refactoring.

I like this point, but I have no strong idea how we could solve it right away. I created a ticket to track that and handle it in the future https://github.com/keep-network/keep-core/issues/3210.


[COMPASS] Tracking ticket for Valset and SLC failures

[COMPASS] Tracking ticket for Valset and SLC failures https://github.com/palomachain/paloma/issues/1296

Closing, as the upstream ticket is closed.