Making prewarm kind (and count) configurable

This is to make configurable the prewarm kind (ex:nodejs:6) and prewarm count (number of containers the invoker prewarms) which is hardcoded to 2 right now.
Fixes https://github.com/apache/incubator-openwhisk/issues/2401.

@rabbah @Himavanth
Should we support multiple prewarm kinds?(It seems current code supports only one kind)

Yes. That was my suggestion above (https://github.com/apache/incubator-openwhisk/pull/3232#issuecomment-361311688).

We should seperate the multiple cell support into a seperate PR. Here it sufficies to export the kind to a pure config setting but make no semantic changes in the invoker.

Thanks @rabbah for letting me know about the PureConfig doc. I have made the changes required.
I have also submitted the ICLA to<EMAIL_ADDRESS>I am hoping thats the right one and waiting for a reply.

Hi, Thanks for this change. I am looking to be able to keep prewarmed containers spawned from custom images alive. Currently these come up as kind:blackbox and I cant employ the same method above to keep them warm.

@hsane2001  can you open an issue to discuss the desired feature. I think the approach here establishes a bit of the foundation to do what you like.

Done -> https://github.com/apache/incubator-openwhisk/issues/3389

is this pr alive?

Yes. We’d like to get this in for sure.

Thinking through this a bit more - because it will have breaking changes to downstream projects, I think we should do the break change once. Let's move the stem cells to the runtime manifest.
We could do this by adding an additional property for a kind, stemCells: [ {memory, count} ] since the kind already specifies the image name. The invoker's preWarmConfig is:
case class PrewarmingConfig(count: Int, exec: CodeExec[_], memoryLimit: ByteSize)

so it is sufficient to add the fields I note above.

Hi @rabbah , do you mean adding an additional property in runtime.manifests ?
after that the runtime.manifests will be like:
{
    "runtimes": {
        "nodejs": [
            {
                "kind": "nodejs",
                "image": {
                    "name": "nodejsaction"
                },
                "deprecated": true,
                "stemCells": [{"memory": 256, "count": 1}, {"memory": 512, "count": 1}]
            }
        ]
    }
}

It is better to support multiple prewarm kind like @rabbah already said.
for example like below:
[{ "kind": "nodejs:6", "stemcells": 2}, { "kind": "python:3", "stemcells": 2}]

@rabbah Thanks for the feedback. Do you think the prewarming should be for every kind or only the default one under each family.

I think it would be useful to have both per-kind and multiple. Obviously we can't guess all the variants that will be used realistically, but implementing these gives significant flexibility, e.g. to tune the deployment to have lots of small prewarm, plus a few large ones, etc.
The potential problem for multiple prewarms that vary by memory is that you may end up running "small" (memory footprint) actions on a "large" container, if you only test whether the action memory < prewarm memory. This may have some odd results, like creating many large footprint containers that are only used for small actions, and causing large actions to wait for cold starts.
It may be worthwhile to add another config property, like minMemory where the prewarm will ONLY be used if `prewarm.minMemory < action.limits.memory < prewarm.memory'. In this case, you could have a few large prewarms around, that will actually be reserved for running actions that are close in memory footprint requirements.
In the spirit of "change it once", this may be a good time to introduce action resource attributes as well. I think this is needed in actions so that, for example, an action can signal that it needs to run on a gpu host, or consumes a relatively large amount of cpu, etc. If an action can signal these, they will need to be configurations within the runtime manifest as well. This is a bigger change though, so may be worthwhile to settle for "change it twice"? I will open up an issue for this (if one doesn't exist)

@Himavanth what’s the latest on this PR, I’m interested on this feature

Codecov Report

Merging #3232 into master will decrease coverage by 0.01%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #3232      +/-   ##
==========================================
- Coverage   74.41%   74.39%   -0.02%
==========================================
  Files         126      126
  Lines        5952     5953       +1
  Branches      391      392       +1
==========================================
  Hits         4429     4429
- Misses       1523     1524       +1

Impacted Files
Coverage Δ

...ain/scala/whisk/core/invoker/InvokerReactive.scala
0% <0%> (ø)
:arrow_up:

...rc/main/scala/whisk/core/entity/ExecManifest.scala
96.2% <100%> (+0.09%)
:arrow_up:

...scala/whisk/core/containerpool/ContainerPool.scala
85.71% <100%> (-0.17%)
:arrow_down:

...rc/main/scala/whisk/common/ForcableSemaphore.scala
84.61% <0%> (-3.85%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d9372f...c399b5f. Read the comment docs.

@rabbah I have added the tests. Do you think this would suffice?
@csantanapr Glad to know. I was working on tests and scalafmt issues(new here). Done now.

Thanks for the updates @Himavanth 👍

@csantanapr this will need a PG. I'll go through it today or this weekend but it's good enough for jenkins.

From reading the source code, it will use the kind set by default.
So it looks what needs to be specified in the ansible manifest is for nodejs json structure a stemCells with count and memory like (2, 256M)

@Himavanth take a look at this branch:
https://github.com/apache/incubator-openwhisk/compare/master...rabbah:stemcells?expand=1
I rebased this PR to master, resolved conflicts, and made a few changes, organized as separate commits. If you're agreeable, I can open a PR to supersede this one.

Sounds good. Thanks @rabbah 👍


More flexible Stripe definitions

We have Stripe.Type which is an enum and therefore cannot be extended. It should become a record with the current static fields as default instances.
The Stripe class has a Type which determines the appearance of the stripe, as well as the rules. To overrule the rules, an overruling type can be defined, for instance to deal with a rush-hour lane. It is probably better to regard the Stripe.Type lane-change information as default, which the Stripe can consult, but which can be overridden by new Stripe.setLeftLaneChange(boolean) and Stripe.setRightLaneChange(boolean) methods. The overruling stripe type is then removed. Note that for individual GTU types, permeability can still be set to overrule both the type default, and the overall overrule of the type. E.g. the priority is: explicit GTU type permeability, setting of the lane change on the stripe, the default stripe type rule.
The Stripe.Type has a default width. We could add to this default dashes of type LengthVector. For continuous lines this can be null. The Stripe class can be extended with a setDashes(LengthVector) method to possibly overrule this.
Class StripeAnimation has a method makeDashes which produces drawing data based on default assumptions for different StripeAnimation.Type values, obtained through StripeData.getType(). This type can be removed, and instead the dash data and offset can be obtained from the StripeData through new methods getDashes() and getOffset(). For AnimationStripeData based on a Stripe from ots-road, this means that getOffset() also needs to be a method of Stripe, and that it needs to be able to set this with setOffset().

Stripe.StripeType is now a record with default static instances.
Stripe DOUBLE has been replaced with DOUBLE_SOLID and DOUBLE_DASHED.
The editor and XML parser have been adjusted.
Dash data is List<LengthVector> so that dash info can be given per line, e.g. for a double line |:.
Definition has been changed: the first dash length is now a gap, the second a dash.


translation using arrays does not work

Good day, i am trying to translate a big array with deepl. Somehow when i put even a small array in the translateText function i am getting an error:
DeepLError: texts parameter must not be a non-empty string or array of non-empty strings at appendTextsAndReturnIsSingular   projectpath/node_modules/deepl-node/dist/index.js:166:23
It seems that arrays are not supported
translator.translateText(
['hallo', 'test'],
req.body.sourceLanguageCode, //this is nl
req.body.targetLanguageCode, // this is en-GB
)

Hi @LorenzoJokhan, thanks for creating the issue.
Unfortunately I haven't been able to reproduce this. The library includes this test case in the tests. Are you using a supported node version?

Ik heb in de functie appendTextsAndReturnIsSingular(data, texts) wat console logs gedaan en krijg het volgende:
{ textsIsArray: true }
{ arrayToTranslate: [ 'tekst', 'welkom' ] }
keys: 0, 1, insert
error: DeepLError: texts parameter must not be a non-empty string or array of non-empty strings

Thanks, but I could not reproduce this behavior either; the key "insert" does not appear. Does the texts array come from an unusual source?

It seems a developer at my current project added a key to the prototype of array (which is not a good thing to do). Meaning that every array at our side will have that function as a key. This would mean however that if you choose to continue to use a for...in loop in deepl translation, then in the future when another library modifies the prototype they will also have these issues.
Array.prototype.insert = function ( index, item ) {
this.splice( index, 0, item );
};
The easiest fool-proof fix would be to change the loop to a for...of loop or standard for loop that only iterates over the elements instead of the keys

Thank you for your reply, that explains the cause.
You are right about using for .. of loops, we'll fix this soon.

This is fixed in v1.7.1.


The code need to be formatted in "Split cars"

Describe the bug
The code need to be formatted in "Split cars"
Steps to reproduce the behavior
1.Navigate to https://arcade.makecode.com/beta#
2.Game Jam------>Split cars------>Open Example
Actual behavior
The code need to be formatted in "Traffic Jam"

Additional context
1.OS: Windows(rs6)
2.arcade version: 1.3.30
3.Microsoft MakeCode version: 6.8.15

"Perpetual Racer v1.0" also has the same issue

"Perpetual Racer v1.0" also has the same issue

@shakao - can you gen me a share url for an unscrambled version of https://arcade.makecode.com/71929-42418-05612-32436? This is the same situation as in #2679.

@shakao - can you gen me a share url for an unscrambled version of https://arcade.makecode.com/71929-42418-05612-32436? This is the same situation as in #2679.

yes! here you go: https://arcade.makecode.com/91788-14792-10566-27532

yes! here you go: https://arcade.makecode.com/91788-14792-10566-27532

Thanks!!

Thanks!!

@ganicke "Perpetual Racer v1.0" still not fixed

@ganicke "Perpetual Racer v1.0" still not fixed


Added a chatbot

Closes Issue #571
@sanjay-kv   @HimangshuSharma01  ,
I have added the Chatbot. Kindly check it out and please give level 3 it will be an honor
@HimangshuSharma01 ,
Thank You Sir for all the guidance and making this contribution possible. It really helped a lot.
https://github.com/user-attachments/assets/ca563d35-9583-4ae7-babe-fcdd48f8d122

Closes Issue #571
@sanjay-kv @HimangshuSharma01 , I have added the Chatbot. Kindly check it out and please give level 3 it will be an honor
@HimangshuSharma01 , Thank You Sir for all the guidance and making this contribution possible. It really helped a lot.
Chatbot.RH.mp4

Great work @Peart-Guy

@sanjay-kv
I have done the work, Kindly check it out and Please give Level 3. It will be an honor

@sanjay-kv  Sir
Kindly give Level 3 . It will be an honor


Data conventions

Adds:

A data doc that defines our expectations for data formatting
Simplified data configuration classes
Deprication warnings for old configuration classes

data.rst is not indexed in the index.rst

Ah, I'll fix that

added and merged


parse all documented inp file sections

... to achieve parity with the GUI parser

We got a little closer today with #89 for the [RULES] section.

... added f7d214576a9106f9d3732dcdf7821a7ede62457d for element comments

We don't have the vertices yet, what else is missing?
This can go to 2.3.

@eladsal and @samhatchett What remains to be done on this Issue?


chore(CategoryTheory): Unique->Nonempty+Subsingleton

Could you add a description of the PR?
bors d+

bors merge


Improved node structure with example

Subj.

Codecov Report

Merging #9 (1b80ac7) into master (3a9001d) will increase coverage by 49.66%.
The diff coverage is 64.56%.

@@              Coverage Diff              @@
##             master       #9       +/-   ##
=============================================
+ Coverage      5.48%   55.15%   +49.66%
+ Complexity      114       51       -63
=============================================
  Files            23       19        -4
  Lines          8949      359     -8590
  Branches        889       32      -857
=============================================
- Hits            491      198      -293
+ Misses         8395      145     -8250
+ Partials         63       16       -47

Impacted Files
Coverage Δ

src/main/java/org/uast/uast/base/EmptyTree.java
20.00% <0.00%> (-8.58%)
:arrow_down:

src/main/java/org/uast/uast/base/Type.java
0.00% <0.00%> (ø)

.../main/java/org/uast/uast/base/ChildDescriptor.java
37.50% <37.50%> (ø)

...rc/main/java/org/uast/uast/base/EmptyFragment.java
37.50% <37.50%> (ø)

...va/org/uast/uast/example/green/IntegerLiteral.java
59.09% <59.09%> (ø)

...ain/java/org/uast/uast/example/green/Addition.java
72.72% <72.72%> (ø)

src/main/java/org/uast/uast/base/DraftNode.java
78.37% <75.75%> (-21.63%)
:arrow_down:

...c/main/java/org/uast/uast/lang/AntlrConverter.java
100.00% <100.00%> (ø)

...n/java/org/uast/uast/lang/JavaParserConverter.java
71.42% <100.00%> (ø)

... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a9001d...1b80ac7. Read the comment docs.


compose Up fails trying to recreate containers when not needed

I can't seem to find a way to replicate the behavior of docker-compose up -d, where if the container has not changed, nothing happens. Instead, I get:
ERRO[0006] Failed to start: rethinkdb : Error response from daemon: endpoint with name rethinkdb already exists in network ubuntu_default
Am I doing something wrong?

I'm guessing it's because of this set to true: https://github.com/docker/libcompose/blob/master/docker/service/service.go#L242

I can confirm this was introduced by this commit:
https://github.com/docker/libcompose/commit/f5c34b0a35164a0f6d8b861df32b2e4e54deb847

@xihan88

Simple Expected Example with docker compose:
---
version: '2'
services:
    test.svr:
        container_name: test.svr
        image: alpine:latest
        command: sleep 10000

$ docker-compose up -d
Creating network "foo_default" with the default driver
Creating test.svr ...
Creating test.svr ... done
vito-mbp:maestro vitocutten$ docker-compose up -d
test.svr is up-to-date

Then make a change to the compose file ports ["8080:8080"] for example
$ docker-compose up -d
Recreating test.svr ...
Recreating test.svr ... done

Libcompose is no longer following this behavior it is now barfing out an error on second up.

Is anything happening about this?


Doc query properties

Aimed to fix https://github.com/prestosql/presto/issues/2506

@mosabua can you please change the commit message to sth like "Document query history properties"?

@mosabua can you please change the commit message to sth like "Document query history properties"?

done

All ready again @findepi

Merged, thanks!


Rephrase newer version warning

The not-latest version of a dataset show the following warning:

I would rephrase that (no exclamation mark) and link directly to the latest version (i.e. resource URL without &v=:):

There is a newer version of the record available.

Thanks Peter. Good point

Gs this been deployed to UAT?

Yes it is

Aha, I see it now at https://ipt3.gbif-uat.org/resource?r=camtrap-dp-example&v=6.0:

I notice that the link (= newer version) has the same colour as the text (--alert-warning-text-color), making it hard to see this is a link. Maybe the alert-link class should be used to make it stand out: https://getbootstrap.com/docs/5.0/components/alerts/#link-color
This applies to all warnings.


[5.6] Fix ArgumentExtractor implementation bug (#4287)

Fix ArgumentExtractor implementation bug
Motivation:
swift-docc-plugin uses the PackagePlugin API and support generate-documentation action.
If we run
swift package --allow-writing-to-directory ./docs \
    generate-documentation --target SymbolKit --output-path ./docs

It will be fine.
However if we run
swift package --allow-writing-to-directory ./docs \
    generate-documentation --target=SymbolKit --output-path ./docs

It will loop infinitely.
And the core reason seems to be the ArgumentExtractor implementation in PackagePlugin Package.
Modifications:

Fix the ArgumentExtractor implementation bug
Add testExtractOption for ArgumentExtractor

Result:
When using --<name>=<value> form to specify the argument, the Plugin will no long loop infinitely.
Other consideration
I think this should be cherry-picked into release/5.7
But should it be cherry-picked into release/5.6.2?

@swift-ci please smoke test

Hello @tomerd (Release manager for release/5.6 swift-package-manager)
Does this meet the merge bar of 5.6.2?
If not, I'll just close it and only cherry-pick this into release/5.7.

thanks @Kyle-Ye. will see if we can include it in the next possible window

Looks like this is already in main as well as release/5.7 (via https://github.com/apple/swift-package-manager/pull/4288) so the only remaining question is whether it is a candidate for 5.6.


82 mediator coordination stateful keylist query

@IngridPuppet @Christiantyemele please review this PR

Please resolve the conflicts. Also, I have converted this PR to a draft to prevent it from being merged before #123.


isNumber is wrong for NaN

Bug description
NaN is not a number, but isNumber(NaN) returns true.
My suggest is:
const isNumber = val => typeof val === 'number' && !isNaN(val);

@mkopa you can use Number.isNaN function

@jjeejj What do you mean I can use Number.isNaN?
I'm writing about https://github.com/30-seconds/30-seconds-of-code#isnumber when function isNumber return true for NaN value.

@mkopa yes,you are right ,but i think  the Number.isNaN  function is better than the isNaN， because isNaN('ss') return true

@jjeejj you are right, but in this case it's doesn't matter because typeof 'ss' === 'string', not 'number'

@mkopa you can consider it conveniently through performance

Maybe better solution will be:
const isNumber = val => typeof val === 'number' && val === val
because NaN is never equal to NaN?

Maybe better solution will be:
const isNumber = val => typeof val === 'number' && val === val
because NaN is never equal to NaN?

Yes, This solution is better.

I agree that the below is probably the optimal solution as it is a good place to explain how NaN self-equality works.
const isNumber = val => typeof val === 'number' && val === val;

I would love to see a PR for this, it's a pretty important consideration. Additional tests to deal with the edge cases would be appreciated, too.


mutationObserver event firing repeatedly

Hi,
If you load this page and look at the console you will see that the mutationObserver event fires continuously and the plugin logs "No change in size detected":
https://succeed.serenova.com/lp-t-cb-omnichannel-uk-2018/
While the plugin seems to be functioning correctly on the front-end, I'm concerned whether this might have performance implications or cause issues in any OS/browser combos I haven't view it in.
Thank you!

Hi @davidjbradshaw, any idea what might be happening here?
Thanks!

I expect you have something on your page that is constantly updating, you could try setting the interval option to -9999 to switch of the mutationObserver


powertools build error.

I am using vs2017 to build the lastest soruce code of powertools. There are some dependenced libraries missed. such as 1)Microsoft Development Environment 8.0 (Version 7.0 Object Model),
2)Microsoft Development Environment 8.0,
3)Microsoft.VisualStudio.ComponentModelHost,
4)Microsoft.VisualStudio.Shell.11.0,
5)Microsoft.VisualStudio.Shell.Design

@lajones Can you provide any help/info here?

@julianhu1979 @ajcvickers For those errors, I would echo @ErikEJ's comment above. It looks like you're missing the VS Extension Development workload. See the selected workload in the VS Installer below.

Note: I tried this out myself. With the latest released version of VS (15.2) I am seeing different errors to do with not being able to load EnvDTE and EnvDTE80. So we need to update the references in PowerTools.csproj to just Reference those, rather than using the old COMReference. After that the build works as expected. We should keep this open to track that work.

I have logged: https://github.com/ErikEJ/EntityFramework6PowerTools/issues/12

Close this? https://marketplace.visualstudio.com/items?itemName=ErikEJ.EntityFramework6PowerToolsCommunityEdition is now published

Per @ErikEJ's comment, we are going to recommend customers to use the Community Edition moving forward.


[BUG] Typing email address with three domain segments, auto-link leaves editor in broken state

If you want to ask for support or request features, sponsor the project and contact me over email.

[x] I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
[x] I have read the documentation and cannot find an answer.

Describe the bug
Typing an email address with more than two domain levels leaves the editor in a broken state (e.g<EMAIL_ADDRESS>due to auto-link plugin.
To Reproduce
Steps to reproduce the behavior:

Go to https://mdxeditor.dev/editor/demo
Insert a cursor on a new line.
Start typing an email address with more than three domain segments (e.g<EMAIL_ADDRESS>When the .com part is typed the email is "auto-linked".
After continuing to type .au the backspace key no longer works (it selects the text instead of removing).
Console shows errors (on a local build, the errors are similar to this):

    Error: Expected node 13 to have a parent.
    at _TextNode.getParentOrThrow (Lexical.dev.mjs:3460:15)
    at $shouldInsertTextAfterOrBeforeTextNode (Lexical.dev.mjs:1032:23)
    at $shouldPreventDefaultAndInsertText (Lexical.dev.mjs:2398:3)
    at Lexical.dev.mjs:2689:34
    at $beginUpdate (Lexical.dev.mjs:8093:5)
    at updateEditor (Lexical.dev.mjs:8169:5)
    at onBeforeInput (Lexical.dev.mjs:2607:3)
    at Lexical.dev.mjs:2344:61
    at HTMLDivElement.<anonymous> (Lexical.dev.mjs:3163:9)

Expected behavior
After typing .au the full email address should have been converted into a link, and the editor state should remain editable.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: macOS
Browser: Chrome

This is entirely a Lexical behavior, have you searched for a similar problem on their side?

The same test works correctly on the lexical playground site: https://playground.lexical.dev/

Searching for issues in their repo found this - https://github.com/facebook/lexical/issues/6430.
Since this will be fixed once Lexical releases a new version, I will close this issue.

facebook/lexical has now release v0.17.0. Is there a rough timeframe for when this update be included in mdx-editor?


Update to springboot2

Short Description

Update to Spring Boot 2.1.6.RELEASE
Update to influxdb-java 2.15
include hibernate-validator as explicit dependency:https://stackoverflow.com/questions/46482088/spring-boot-starter-web-hibernate-validator-dependency-missing-on-mac

Proposed Changes

Update to Spring Boot 2.1.6.RELEASE
Update to influxdb-java 2.15
include hibernate-validator as explicit dependency:https://stackoverflow.com/questions/46482088/spring-boot-starter-web-hibernate-validator-dependency-missing-on-mac

Fixes: #

I wil modify it again ,and then pull request.


UI improvements to  available updates

Show "required" tag, release notes, and non deployable cause.

Merging into a branch.


[FEATURE] add vpce bedrock capabilities

Is your feature request related to a problem? Please describe.
I want to use langchain4j for bedrock with private link, i had to create custom classes to do that cause client creation with url is private method.
Describe the solution you'd like
I want to have bean urlOverride capabilities when i use private link to connecto to bedrock (ex : https://vpce...***)
Describe alternatives you've considered
Alternatively can inject the URL by env or application prop
Additional context
Actually we have to create CustomAbstractAwsClient with different getClient() method cause its private. If this method was protected, we can just override this by extension.
Ty :)

@troimaclure would you like to contribute a PR? :)

We usually have .baseUrl(...) in the builder of models for this purpose

Hi @langchain4j  I would like to work on this and contribute the PR, can you please assign this to me if possible.

Hello guys, some news on this? I also need to use VPCe with bedrock


Created a mechanism for dynamic user handling

[x] #60  Created a mechanism for dynamic user handling

Instead of creating a fake user from setting.py ( which is hardcoded ) and we need a dynamic mechanism to create users with a random name and password. So, I created some methods that create a random user, If it does not exist in the current session of the browser.

Changed the URL pattern for accessing the portal.

Updated views.py to check for the user in the current session and also updated the Auth toggle functionality to kick all users at once.

Lastly updated middleware redirections.

That's all, I had done, thank you @enoren5
Best Regards,
Umar Ahmed

Hi @UmarGit! Thanks for the PR. I tested it. It generally works, like when traversing back and forth between gateway.html and portal.html. But when clicking on the "Tarot at Random" or "@FILM" links (on the portal.html page), I encounter this traceback: https://imgur.com/a/8LT3VBY

Okay @enoren5 , let me check brother.

The issue is because I have made some changes to the routings, that's why Django didn't find that URL, now I have updated the generators, about ( page URLs ).
I have also changed some URL routing, then also double-check to migrate the apps as follows:
python manage.py migrate landings
python manage.py migrate essays
python manage.py migrate generators
then python manage.py makemigrations
And that's all I had done

Hi @UmarGit: Now tarot keys and the about pages render properly. Thank you for fixing that! But there other locations which are still throwing 'NoReverseMatch' such as: http://<IP_ADDRESS>:8000/essay_list and http://<IP_ADDRESS>:8000/article/slashdot/. Take a look here (along with the commands and their output in my terminal): https://imgur.com/nrxoJTJ

Okay @enoren5 , I am checking that

Fixed sessions
And that's all I had done

Thanks, @UmarGit! I sent you a message on Upwork about a potential next milestone. Check it when you can! :)

Thanks, @UmarGit! I sent you a message on Upwork about a potential next milestone. Check it when you can! :)

Issue #60 resolved!

Issue #60 resolved!


build(main): release 1.5.1

:robot: I have created a release beep boop
1.5.1 (2024-10-01)
Continuous Integration

update package-lock.json (47f11f6)

Miscellaneous Chores

deps-dev: Bump eslint-plugin-sonarjs from 2.0.2 to 2.0.3 (7bc450f)
Update localization and dependencies. (524116b)

Documentation

Add a forwarding rules configuration to the bot menu, excluding filtering options, i.e. Keywords group, and without images. (5ad1635)
Finalize readme (16f4306)
Update images for forwarding rules configuration in README.md (c9c5677)
Update README.md with information about filtering by keywords groups (aa86156)

Code Refactoring

Some adjustments for keywords related texts (16f4306)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v1.5.1
:sunflower:


Add fields to elm-package.json for argument-less elm-make

I propose adding two fields to elm-package.json:

"main-modules" : [ "Main" ], which would search for Main.elm inside all defines source-directories. Multiple main modules are also allowed.
"build-output" : "build/my-app.js", which would be used as the default output path

With this, instead of writing:
elm make src/Main.elm --output build/my-app.js
I can simply write:
elm make
and it will know what to do. This is a big win because you can checkout any elm project and build it without reading any instructions.

This is what I meant in #23. Sublime is already doing this :+1: I could migrate to use these fields.

If only one Main is allowed in this proposal, then we can eliminate a class of errors by replacing e.g. Elm.fullscreen(Ekm.Main) (runtime error - Ekm is undefined) with just Elm.fullscreen()
@rehno-lindeque - you guys currently have a use case for multiple mains, right? Is there another way you could accomplish the same thing, such as multiple elm-package.json files?

For that use case in Sublime we just assumed it's have to be passed into the CLI.

@rtfeldman That's right - every widget we have has a main (in order to be embedded separately). At the same time the widgets have a lot of shared code, we wouldn't want to have multiple .js files output because that would get huge pretty quickly... (also, even more boilerplate for one elm-package.json per widget)

What's your process currently?

Mmm, well it's pretty simple really - I remember now that we're not even actually using elm-package.json for building:
elm_modules=`printf "\
      \nsrc/Bom/Substitutes/Main.elm\
      \nsrc/ConsignSource/Main.elm\
      \nsrc/Footprint/Main/Overlay.elm\
      \nsrc/Symbol/Main.elm\
      \nsrc/Dashboard/Main.elm\
      \nsrc/ProjectUpload/Main.elm\
      \nsrc/Board/Main.elm\
      \nsrc/UserPart/Main.elm\
      \nsrc/UserSource/Main.elm"`
elm-make $elm_modules --output client/elm-components/elm-components.js --yes || die

I still don't understand well. Should we use one large .js file which includes multiple mains for all pages? I usually make multiple .js files for multiple pages (e.g. indexPage.js for index.html, profilePage.js for profile.html and so on).

@jinjor at least for us, there's a huge amount of shared code that gets compiled into our javascript output. I'd say just open your indexPage.js and look inside. If there's a lot of redundancy you might want to consider doing what we do.

Ah, now I understand what you meant, thanks. I'm not sure it should become the standard way, but in many cases it seems better considering browser cache.

@laszlopandy, I want a way to add constraints appropriate for a package vs a product. What do you think of making the main-modules and exposed-modules fields mutually exclusive? This can serve as the indicator of whether we are dealing with a package or product.

A big +1 to making them mutually exclusive! We still accidentally mess this up all the time.
Would be an added bonus if the main-modules version used a more concise version syntax (e.g. "1.0.0" instead of "1.0.0 <= v <= 1.0.0")

Interesting, that seems very nice @rtfeldman. @rehno-lindeque, do you have opinions on this?
(This would also be independent of a test-dependencies or dev-dependencies field for any constraints that are just for testing or benchmarking or whatever. Would you want exact or bounds in that case though? Is it the same answer for packages and products? Assuming this can be handled independently, I think we should discuss it in a separate issue.)
I am struggling to think of legitimate cases of something being both a package and a product. When we add support for "local packages" via elm-package this should handle the scenario within a company where you have a closed-source package that is used your closed-source product.
I have been playing with the idea of having something like elm-package.json and elm-product.json but that seems pretty confusing. I have also been thinking about having a field within elm-package.json like "type": "package". The idea here seems better than both, but does the name elm-package.json still make sense? I don't know if it makes sense to change this before 0.16, but let's start getting some ideas.

Maybe it should be named elm-project.json?

Love the idea of elm-project.json - makes a ton more sense!
I'm not even sure what it would mean to import someone else's publicly-published package that had a main specified in the JSON file. Would that be meaningfully different from someone publishing a package that exposed some function that happened to be called main, and then I made a local project that used the published package as a dependency and then set the appropriate function they exposed to be my main?
Also as far as test-dependencies and dev-dependencies - I think fields like that add unnecessary complexity if you have "local packages." Given local packages, I can just make a new json file for my testing project which adds the application package as a dependency along with elm-test and the like (which is exactly what we do now at work, except with all the application dependencies manually copied in both places), and use the same strategy for my dev build project (assuming that use case materializes).

I'm not even sure what it would mean to import someone else's publicly-published package that had a main specified in the JSON file.

I wouldn't let that happen, so let's not go too deep into that. It was more a question of "are there times when a single project is legitimately both a package and a product?" But if that's ever the case, it seems like you could make 99% of things a package and the Main module a product.
I think the test-dependencies idea is getting too off track, let's drop that for now.

I did a bit more thinking on the idea of pinning to exact dependencies. This would mean running elm-package install on something new is more likely to fail than normal. I think it makes sense to have different solving strategies in both of these cases to have a nice experience. So my feeling is that I can't do this for 0.16 but the idea is interesting.
I'm going to open an issue summarizing the current state of affairs.


Merge master into live

We need to push the changes live for the Dapr book release. Any issues with this?

We need to push the changes live for the Dapr book release. Any issues with this?

I was just literally doing this PR, no issues - let's merge it.


feat: add roslyn lsp

Describe your changes
This adds the roslyn language server from https://github.com/dotnet/roslyn/ which is a part of the C# dev kit in vscode.
Issue ticket number and link

Checklist before requesting a review

[x] I have successfully tested installation of the package.
[x] I have successfully tested the package after installation.

This language server doesn't start correctly by naively using it with nvim-lspconfig or vim.lsp.start. There needs to be a little bit of trickery to start it, since the server sends the pipe to communicate through, instead of allowing the client to name a pipe or communicate through stdio.
However, I have forked a plugin that started on this, and I am now maintaining it. I got this issue https://github.com/seblj/roslyn.nvim/issues/11 which asked if I would consider adding support for easier installation. The author of the issue created this repo https://github.com/Crashdummyy/roslynLanguageServer which gets a new version once a day.
This prompted me to think about adding it to mason, as it would really help with installation for me and whoever else is using the plugin😄
I tested to start it with my plugin, and it started just like it does when installing it manually. I also tested installation of all the different targets I added support for, and all of them was able to download just fine😄
Screenshots

Nice work though I don't think having the source file repo being different from the homepage url is a good idea as this will inevitably cause the downstream/upstream problem like users reporting bugs to the upstream project when it's a downstream issue and vice versa.
Though I might be a bit too cautious here and william might see things differently and would approve of it as it still is his decision

I can easily change the source url, no problem :)
I just went with it for now since I think I saw some other examples where this was done. I don't remember which package(s) this was from the top of mye head thoug

Would be awesome to have this merged. Updating this manually is a pain.

Would be awesome to have this merged. Updating this manually is a pain.

Are you on linux by any chance ?
I wrote a bash script to update the lsp.
You just have to replace targetDir and rid with your nvim datadir and the rid of your system

purl known the concept of "repository_url" maybe this could be implemented for nuget, so we can reference the packages directly from microsoft repository?

FYI: I am currently working on providing a way to install "regular" (not dotnet tool) nuget packages, which would just download the plain nuget and extract it into a directory.
This would allow to also use "repository_url" to pull nuget images from custom registries, such as the one from microsoft.
The file for roslyn would then look like this:
name: roslyn
description: |
  The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.
homepage: https://github.com/dotnet/roslyn
licenses:
  - MIT
languages:
  - C#
categories:
  - LSP

source:
  id: pkg:nuget/Microsoft.CodeAnalysis.LanguageServer.neutral@4.12.0-2.24419.4?repository_url=https://pkgs.dev.azure.com/azure-public/vside/_packaging/vs-impl/nuget/v3/index.json
  download:
    file: Microsoft.CodeAnalysis.LanguageServer.neutral-{{version}}.nupkg

bin:
  roslyn: nuget:content/LanguageServer/neutral/Microsoft.CodeAnalysis.LanguageServer.dll

I will reference the PR as soon as I am finishing some cleanup.

Sorry to ping you @williamboman
But is there anything else that I need to do? It seems like there is a lot of excitement for this, and I would really appreciate it if someone could review it so that we could (hopefully) get it merged😅 It would really make my life (and I guess others) easier to update the language server

Hey sorry for super late review, I see there's a lot of interest in this. I've had some reservations with this one because of:

Microsoft's Terms of Use explicitly prohibits redistributing software, although after some more reading I believe the MIT license with which this software is originally distributed under overrides this.
Releases are systematically removed in the Crashdummyy/roslynLanguageServer. This is especially problematic because of the frequent release cadence. I've been working on creating something similar to r-languageserver and julia-lsp for this but I won't have the time to finish it soon and I'd like to avoid pulling in more redistributions under mason-org.

Also as a side note, you can pretty easily create and use other registry sources. I see someone already provided an alternative registry for this so hopefully some people found that useful, also see https://github.com/williamboman/mason-registry-playground for a template for registries.

Alright! So if I understand you correctly, you are a bit hesitant to do it like this?
Is there something I could help with to make it available in core without depending on other third party registries?

Hey sorry for super late review, I see there's a lot of interest in this. I've had some reservations with this one because of:
* Microsoft's Terms of Use explicitly prohibits redistributing software, although after some more reading I believe the MIT license with which this software is originally distributed under overrides this.

* Unofficial sources are a last resort.

* Releases are systematically removed in the `Crashdummyy/roslynLanguageServer`. This is especially problematic because of the frequent release cadence. I've been working on creating something similar to [r-languageserver](https://github.com/mason-org/r-languageserver) and [julia-lsp](https://github.com/mason-org/julia-lsp) for this but I won't have the time to finish it soon and I'd like to avoid pulling in more redistributions under mason-org.

Also as a side note, you can pretty easily create and use other registry sources. I see someone already provided an alternative registry for this so hopefully some people found that useful, also see https://github.com/williamboman/mason-registry-playground for a template for registries.

What do you think about the #1781 PR, this would allow to use official Microsoft repository of the new Language Server, and any other repository then "nuget.org" in the future if needed. It also allow downloading nuget packages that are not "tools" but rather plain zip files. I can provide more Info about the rationals why this is not possible with the current way it's handled in mason.

This would be very helpful


Remove Q4 processing for external data

Q4 preprocessing is unnecessary for external data, except for Sanger. Therefore, I propose to add additional conditional statements for Q4 preprocessing:

After the preprocessing of Q3 data, the Q4 preprocessing will only execute when there is no external data or the external data is Sanger.
https://github.com/pritchardlabatpsu/cnp_dev/blob/59b326b133b68a2582730aa71ba0dadf20c7c4ee/src/ceres_infer/data.py#L462-L466
Then, If external data exists, the external data preprocessing will execute.
https://github.com/pritchardlabatpsu/cnp_dev/blob/59b326b133b68a2582730aa71ba0dadf20c7c4ee/src/ceres_infer/data.py#L486-L489

In addition, redundant q3 processing was removed by getting the q3 sample index before filtering:
before:
https://github.com/pritchardlabatpsu/cnp_dev/blob/43b6b9c640e39401692488a3fc13538e2f7925de/src/ceres_infer/data.py#L460-L467
after:
https://github.com/pritchardlabatpsu/cnp_dev/blob/59b326b133b68a2582730aa71ba0dadf20c7c4ee/src/ceres_infer/data.py#L452-L456

The first point on q4 preprocessing - this is to be addressed in the new class. For the redundant q3, agreed.


term_image.image.TermImage is deprecated

What happened?
term_image.image.TermImage is deprecated already in term-image==0.5.0. So I'm facing an error when using the latest version of nbpreview.
If I manually downgrade term-image you'll see the deprecation warning.

term-image also recommends
If you want to use this library in a project while it's still on version zero, ensure you pin the dependency version to a specific minor version e.g >=0.4,<0.5.

in their README.
Expect no errors to appear when I nbpreview.
nbpreview version
nbpreview 0.9.1
Output

Notebook
https://github.com/dsgibbons/shap/blob/1d9224e890e45c10f494c54eafee3f6a6ba05a11/notebooks/overviews/An introduction to explainable AI with Shapley values.ipynb
OS
macOS
Terminal
kitty
Python version
3.10

+1
term-image needs to be pinned to <0.5.0

I am experiencing the same problem.

+1
term-image needs to be pinned to <0.5.0

or just fix the bug?

For what it's worth, it seems obvious this project is no longer maintained.

For what it's worth, I believe this project is no longer maintained.

ohhh noo

For what it's worth, I believe this project is no longer maintained.

To be clear, I'm talking about nbpreview, not term_image.


MSL: Improve handling of padded descriptors with argument buffers

Fix some issues with aliasing, and also ensures that declared array sizes always match the layout.
Fix #2318.

Heads up for @billhollings and @cdavis5e on MoltenVK side. This should improve argument buffers, but I cannot easily test everything w.r.t. explicit argument buffer layouts.

Heads up for @billhollings and @cdavis5e on MoltenVK side. This should improve argument buffers, but I cannot easily test everything w.r.t. explicit argument buffer layouts.

Thanks for the heads up. Will test and evaluate as part of updating arg buffers in MoltenVK.

Heads up for @billhollings and @cdavis5e on MoltenVK side. This should improve argument buffers, but I cannot easily test everything w.r.t. explicit argument buffer layouts.

Thanks for the heads up. Will test and evaluate as part of updating arg buffers in MoltenVK.

It turns out that commit b236352 does interfere with determining the size of a runtime array within a descriptor set that is held in an argument buffer. The doc on that change discusses protecting and ABI. Which ABI is being protected with that commit?
I've submitted PR #2347, which reverses that previous commit b236352, and adds support to use runtime arrays of dynamic offset buffers. Suggest we discuss this further over there.


Sometimes old analyses persist, because task was not run

These analyses should be also removed on new calculations. Currently this is not the case, because only finished analyses (states FAILURE or SUCCESS) are removed.
One way could be to check all analyses with state STARTED whether they are too old or
whether their current state differs somehow.
Related to #221.

It is relevant. Often tasks are killed by the OS because the use too much memory.

Note that memory errors are now reported to the user. Will need to check whether this problem persists.


Update external_links.yml

Add FB messenger FastAPI

Thanks! As this one has some conflicts and I can't push directly to your branch I added it in this PR: https://github.com/tiangolo/fastapi/pull/3571
I'm gonna close this one now. Thanks for your contribution! :coffee:


Generate latest from spec version 1.72.0

This generates the client from spec version 1.72.0.
Additions:

Adds support for creating scheduled transactions
Adds support for retrieving transactions for a particular month

@dbertram - I regenerated off of 1.72.0 and pushed up changes.


Init tamagotchi

Could you add a README so that a link can be made on the gear-wiki for running instructions?


Updated docblock (to update documentation) to use the correct namespa…

Ticket: #
Reviewer: @
Issue

Solution

Impact

Usage

Considerations

Testing

…ced class for User (#1)

Coverage increased (+4.7%) to 94.43% when pulling 47e909332fc76cfa3feb4a50f4758288e8aed90f on cjke:master into 409ed04fa03edf3bc7f0cfc5fe1fec1615682237 on timber:master.

[Current coverage][cc-pull] is 94.84% (diff: 100%)

Merging [#1126][cc-pull] into [master][cc-base-branch] will increase coverage by 3.24%

@@             master      #1126   diff @@
==========================================
  Files            37         37
  Lines          3199       2985   -214
  Methods         396        389     -7
  Messages          0          0
  Branches          0          0
==========================================
- Hits           2930       2831    -99
+ Misses          269        154   -115
  Partials          0          0

Powered by Codecov. Last update [409ed04...7eaf053][cc-compare]
[cc-base-branch]: https://codecov.io/gh/timber/timber/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/timber/timber/compare/409ed04fa03edf3bc7f0cfc5fe1fec1615682237...7eaf053f695fa7199054ac0a1ff0f767296537ca?src=pr
[cc-pull]: https://codecov.io/gh/timber/timber/pull/1126?src=pr

Thanks @cjke !


Performance warning when using pat2feat.get_features

Thank you for this wonderful library, it works really well so far. When using pat2feat.get_features to extract features for many patterns, then I get lots of
/sequential/pat2feat.py:79: PerformanceWarning: DataFrame is highly fragmented.  This is usually the result of calling `frame.insert` many times, which has poor performance.  Consider joining all columns at once using pd.concat(axis=1) instead. To get a de-fragmented frame, use `newframe = frame.copy()`
  df['feature_' + str(i)] = df.apply(lambda row: is_satisfiable_in_rolling(row['sequence'], pattern,

Would it be possible to generate the column data first and then bulk create the dataframe by concatenating, instead of adding them to the dataframe 1 by 1? Would it also be possible to directly return a numpy array by pat2feat, as pandas is often an overkill?
#Sequences: 108
#Patterns: 4300

pandas==2.0.2
seq2pat==1.4.0

Closing for now to revisit later on.


Strange button behavior on iPhone for embedded viewer

I'm having a very weird issue where the inactive activation states for the viewer buttons are not being appropriately hidden. It is happening specifically on iPhone on a particular embedded page. See screenshot to see what I mean:

I am befuddled by this behavior, since the visibility state of the buttons is controlled by inline CSS. Embedding the viewer into this page works fine on desktop, and when I simulate iPhone in dev tools, it still works fine. I have asked some colleagues if they are having problems, and have not gotten anyone else who is seeing this. Unfortunately I do not have their device details.
Has anyone else seen this kind of buggy button behavior before? Any advice on where to look to try to fix it?

I was able to hook my phone up to my computer to take a look at the HTML. Interestingly, the inline style property on the images is entirely missing:

This definitely explains why the page looks like it does, but I still don't know why the style property is missing.

I was able to narrow this down. It turns out that the mirage2 script from Cloudflare (imported from elsewhere in this particular content managment system, I have no control over it) was messing with the images, including stripping the inline styles.
I was able to work around this by creating my viewer within a window.setTimeout() call. A delay of 15 ms before creating the viewer is sufficient to fix the problem; a delay of 0 ms (just deferring to the next loop) was not.

Wow, that's wild! Glad you figured it out.


Feature/336 upgrade to veramo 2

upgraded ALL packages to latest

including using the latest did-resolver, did-jwt and did-jwt-vc packages from DIF repo, instead of the outdated @tonomy/did-... bundles https://github.com/Tonomy-Foundation/Tonomy-ID-SDK/issues/336
using latest antelope-did-resolver after it was upgraded https://github.com/Tonomy-Foundation/antelope-did-resolver/pull/15

Jest runs all tests using ESM under

typeorm, uuid and ws packages could not be bundled fully with ESM so exceptions were made in jest.config.ts

removed jsdom and jsdom-url package as not needed in latest jest. Added jsdom dependencies in ./test/test.setup.ts and removed jest custom environment
yarn run cli also using ESM bundles
Added new veramo.ts and unit tests. to ensure we are ready for next tasks that depended on this upgrade https://github.com/Tonomy-Foundation/Tonomy-ID-SDK/issues/337 to be ready for https://github.com/Tonomy-Foundation/Tonomy-ID/issues/758
removed did-jwk.ts and upgraded to use did-key.ts instead. this solves https://github.com/Tonomy-Foundation/Tonomy-ID-SDK/issues/316
removed the API and utils builds and conditional exports
added new CI pipeline to check for latest packages - but it does not block PR merges, just there as a warning to remind developers
upgraded eslint to use the new configuration file and conventions. Also removing and updating config dependency packages
fixed issue with ExternalUser.getIssuer() using the wrong keyManager
fixed all tests to work again

Updated the resolver to use latest libraries and noble curves: https://github.com/Tonomy-Foundation/antelope-did-resolver/pull/15

TODO:

update to latest<EMAIL_ADDRESS>use createIssuer, and creatSigner function fro did-antelope-resolver

:tada: This PR is included in version 0.21.0-development.6 :tada:
The release is available on:

npm package (@development dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 0.22.0-development.1 :tada:
The release is available on:

npm package (@development dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 0.22.0-rc.1 :tada:
The release is available on:

npm package (@testnet dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 0.22.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Allow numpy numeric types in numeric fields

Fixes #39.

With this PR something like this would fail
from geometry_msgs.msg import PoseStamped
from rospy_message_converter.message_converter import convert_ros_message_to_dictionary, \
    convert_dictionary_to_ros_message

pose = PoseStamped()
pose.pose.position.x = 1

d = convert_ros_message_to_dictionary(pose)
msg = convert_dictionary_to_ros_message('geometry_msgs/PoseStamped', d)

with
TypeError: Field 'x' has wrong type <type 'int'> (valid types: [<type 'float'>, <type 'numpy.float32'>, <type 'numpy.float64'>, <type 'numpy.int8'>, <type 'numpy.int16'>, <type 'numpy.int32'>, <type 'numpy.uint8'>, <type 'numpy.uint16'>, <type 'numpy.uint32'>])

It works with 1.0, which feels quite "unpythonic" to me.
A check_types parameter would work for me. Maybe even set the default to False, such that other people who update will keep the old behavior?

With this PR something like this would fail
pose.pose.position.x = 1
It works with 1.0, which feels quite "unpythonic" to me.

Thanks for catching this. I intended to allow implicit int to float conversions and even added the numpy integer types, but forgot the builtin integer types... :facepalm: It's fixed now.
On the other hand, implicit float to int conversion sounds bad to me.
Consider the following script:
#!/usr/bin/env python
from std_msgs.msg import Int8
from rospy_message_converter.message_converter import convert_ros_message_to_dictionary, \
    convert_dictionary_to_ros_message

def serialize_deserialize(message):
    from io import BytesIO
    buff = BytesIO()
    message.serialize(buff)
    result = message.__class__()   # create new instance of same class as message
    result.deserialize(buff.getvalue())
    return result

msg = Int8(data=12.34)
print msg

d = convert_ros_message_to_dictionary(msg)
print d

msg = convert_dictionary_to_ros_message('std_msgs/Int8', d)
print msg

msg = serialize_deserialize(msg)
print msg

This will print:
data: 12.34
{'data': 12.34}
data: 12.34
data: 12

In other words, everything will seem to be a float until you publish the message and receive it in a different node, at which point you've lost the fractional part. I think it's better to force the programmer to think about this by having them explicitly convert to an integer type. It's even worse for bools, which will stay 12.34 on the publisher side, but will be received as True on the receiving end.

A check_types parameter would work for me. Maybe even set the default to False, such that other people who update will keep the old behavior?

Ok, I'll implement that.

Thanks!


Invalid Common structure when creating DID

Describe the bug
While attempting to create DID from gRPC client, Miu throws Invalid Common Structure.
@sagar-88  here's the full detailed structure
To Reproduce
Steps to reproduce the behavior:

Start miu server
python grpc_serverserver.py
Have a grpc client ready with following input for the CreateAndStoreDID ,
Following snippet is from a Go client

a, createDIDErr := d.CreateAndStoreMyDid(ctx, &pb.CreateAndStoreMyDidRequest{
WalletHandle: 2, // should be dynamic
DidJson:      &pb.CreateAndStoreMyDidJsonMessage{
Did: "Ardhnaarishwar",
Seed:       "Demo",
CryptoType: "ed25519",
Cid:        false,
},
}

Start the client to connect to 5001 port on which server is running
See error

DEBUG:indy.did:create_and_store_my_did: >>> wallet_handle: 2, did_json: '{"seed": "Demo", "did": "Ardhnaarishwar", "crypto_type": "ed25519", "cid": null}'
DEBUG:indy.did:create_wallet: Creating callback
DEBUG:indy.libindy:create_cb: >>> cb_type: <class 'ctypes.CFUNCTYPE..CFunctionType'>
DEBUG:indy.libindy:create_cb: <<< res: <CFunctionType object at 0x7f089858c818>
DEBUG:indy.libindy:do_call: >>> name: indy_create_and_store_my_did, args: (c_int(2), c_char_p(139674892393840), <CFunctionType object at 0x7f089858c818>)
DEBUG:indy.libindy:do_call: Function indy_create_and_store_my_did returned err: 0
DEBUG:indy.libindy:do_call: <<<
INFO:indy.libindy.native.indy.commands:	src/commands/mod.rs:137 | DidCommand command received
INFO:indy.libindy.native.indy.commands.did:	src/commands/did.rs:124 | CreateAndStoreMyDid command received
DEBUG:indy.libindy.native.indy.commands.did:	src/commands/did.rs:189 | create_and_store_my_did >>> wallet_handle: 2, my_did_info_json: MyDidInfo { did: Some("Ardhnaarishwar"), seed: Some("Demo"), crypto_type: Some("ed25519"), cid: None }
DEBUG:indy.libindy:_indy_callback: >>> command_handle: 3, err 113, args: (b'', b'')
DEBUG:indy.libindy:_indy_callback: <<<
DEBUG:indy.libindy:_indy_loop_callback: >>> command_handle: 3, err 113, args: (b'', b'')
WARNING:indy.libindy:_indy_loop_callback: Function returned error 113
DEBUG:indy.libindy:_indy_loop_callback <<<
ERROR:did_service:Exception occurred @ CreateAndStoreMyDid----
ERROR:did_service:ErrorCode.CommonInvalidStructure

Expected behavior
Should create a DID
Screenshots
-NA-
Desktop (please complete the following information):

OS: ubuntu 16

Smartphone (please complete the following information):
-NA-
Additional context
-NA-

thanks for highlighting the short-comings - whole error handling layer needs major overhaul! I am gonna start looking into that as time permits. Much appreciated!


offline blob support

related: #7594
While stashed ops have been implemented, there is no blob support. Currently, when ContainerRuntime.uploadBlob() is called, the promise returned will not resolve until the blob has been uploaded and a BlobAttach op has round-tripped. This ensures that it is not possible to attach a blob handle to the document which refers to a blob that is not present in storage because it was not successfully uploaded, or was GCed before the BlobAttach op was sent. However, this means that uploadBlob() will never resolve when we are offline.
We need to support "uploading" blobs while offline, getting blob handles, making further changes, stashing these changes, reapplying them in a new container, possibly making further changes while still offline, and finally, upon reconnection, uploading the blobs and resubmitting the stashed ops. In this scenario, we cannot rely on waiting for the BlobAttach op to roundtrip, but we must still ensure that we never attach an invalid handle, as it will result in a broken document.
A (partial) solution is implemented in #8159. In this PR, when a blob is uploaded while offline, uploadBlob() returns a handle that uses a local ID, which BlobManager can redirect to the storage ID once the blob is uploaded (leveraging work already done for detached container blob support). Once we reconnect, when we see a BlobAttach op in the resubmit queue in PendingStateManager, we block resubmission of any further ops until the blob has been uploaded. It should be safe in this case not to wait for the BlobAttach op to round-trip, since we know if it doesn't go through, nothing past it will go through either, and we can make sure upon any subsequent re-resubmission that the blob has not yet been GCed (see #6469).
This solution is not complete as implemented in the PR since blocking resubmission requires making PendingStateManager.replayPendingStates() async. This breaks the assumption in replayPendingStates() that all pending ops will be resubmitted atomically without any new ops being submitted. The fundamental problem is that we need to block submission of new ops while allowing submission of resubmitted ops, but it's not easy to distinguish between the two since they both go through ContainerRuntime.submit(). If we can distinguish resubmitted ops from newly subitted ops, we can keep them separate in PendingStateManager, which should solve the problem.
Another solution, similar to how blobs in detached containers work, would be to upload all of the blobs before emitting "connected" event. This would ensure that all ops can be resubmitted safely.
One downside to the approach above is that it relies on the redirect table in BlobManager, which must be persisted in future summaries. There is no mechanism to ever remove entries from this table, so it will grow monotonically. A new entry must be added for every blob passed to uploadBlob() while offline, or if we want to treat online and offline blob uploads identically, a new entry must be added for all blob uploads.

First of all, I like the world where images behave as DDSs. I.e. where local changes are synchronous, and the system is doing the right thing to push changes to storage, correctly reflects "dirty" document state, etc. I'd love to see same with images, but with one tiny specific: I believe host would still want to know more about image upload process to show local progress UX to user.
But if we go that route, I'd love to see it to be the only code flow we support. I.e. I do not think it's acceptable for API to be blocking (async) when user is online and not if user is offline. There is no B/W distinction between offline and online. User may lose connectivity while image is being uploaded, and I'd hate us to have to care about that 3rd state (how would we serialize container in such state?)
And if we go that route, I think all op processing (pending state manager) should be uniform in handling all types of changes (ops, pending blob uploads). I.e. ops are never submitted directly to DeltaManager, they always go through pending manager only, and it makes sure that right stuff happens. Only one flow to test and maintain


HDDS-7507. [Snapshot] Implement List Snapshot API Pagination (#4065)

(cherry picked from commit 9f84c77)
What changes were proposed in this pull request?
The original PR (#4065) targeted feature branch. Unfortunately, I merged it after feature branch's merge to master without checking the PR target branch. So it is actually missing from master branch. Thanks @hemantk-12 for catching this.

Cherry-picked 9f84c77613c66f5b0c24bb6b41eb13c29ecf8fcc to master branch
Resolved two minor conflicts
Fixed usage in listStatusBucketSnapshot and a test because of the API change: d6d23cbd39226bcfe220abe00d315577adfb3ce3

Q for @adoroszlai : do you think I should keep the original PR number in the title as well? Or just the current one.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7507
How was this patch tested?

Same as #4065 .

@prashantpogde @swamirishi Since this is a backport of a previous PR with only absolutely necessary changes to make it function. I will not incorporate further non-critical changes into this. Pls feel free to open a new PR to do any refactoring.
CI has passed. Will merge this in a bit.


Sections not dividing correctly

In https://arxiv.org/abs/1208.2974, section 3 and beyond are not being separated.

The issue was that \u was used as a custom command, and this was causing pylatexenc to not be able to detect the \section following this \u command. divide_latex_text now circumvents this problem by providing the option to replace the custom commands before dividing the text.


popup not allowed to show on android

platform: android
react-native version: 0.57.7
react-native-webview version: 4.1.0
the code does not throw any error but the payment API i'm using in the webview tries to open another window like a popup then show an error saying "enable popup in your browser".
<View style={{flex: 1, paddingBottom: 60, backgroundColor: "rgba(0, 0, 0, .5)", paddingLeft: 24, paddingRight: 24, justifyContent: "center" }}>
                <View style={{height: screen.height / 1.65, borderRadius: 12, paddingTop: 16, backgroundColor: "white", overflow: "hidden" }}>
                    <View style={{ justifyContent: "center", flexDirection: "row", position: "absolute", width: screen.width - 48, top: screen.height / 1.65 / 2, zIndex: 10 }}>
                        {this.state.loading && <ActivityIndicator color="#0871FF" size="small" />}
                    </View>
                    <TouchableWithoutFeedback onPress={this.handleClose.bind(this)}>
                        <View style={{ position: "absolute", top: 16, right: 16, zIndex: 10 }}>
                            <Image style={{width: 24, height: 24}} source={require("../assets/icons/close-icon.png")} resizeMethod="auto" resizeMode="center" />
                        </View>
                    </TouchableWithoutFeedback>
                    <WebView useWebKit={false} allowUniversalAccessFromFileURLs={true} mixedContentMode="always" style={{ height: 200 }} onLoadEnd={this.handleWebViewLoad.bind(this)} onMessage={this.handleWebViewMessage.bind(this)} originWhitelist={["*"]} javaScriptEnabled={true} domStorageEnabled={true} source={{uri: "file:///android_asset/paystack.html"}} injectedJavaScript={js} />
                </View>
            </View>

I don't think we can support this given it's a singular view/window. Closing, however feel free to send a PR if you think there's a viable fix for this.

Hello @Ehesp, I actually face similar issue. Can I confirm this is still not supported by the lib before I proceed on new issue?
@Muheez, May I know what was your solution on tackling this issue?


🐛 [firebase_messaging] [v.9.1.0] [Android] Background messages not working properly. RemoteMessage.RemoteNotification object is null

Bug report
Describe the bug
Wrong PN behavior. Notifications emitted when app was in the background are not returned on FirebaseMessaging.instance.getInitialMessage() or FirebaseMessaging.onMessageOpenedApp if app was closed and then clicked on notification. So looks like background messages are not handled when the app was closed. Or closed and opened again.
PN - Push Notification
Steps to reproduce
[1] Steps to reproduce the behavior:

Open an app which is using PN
Put it in the background (by clicking on the home button for example)
Emit push notification.
Clean memory (or close the app so it is no longer in the background)
Click on PN
App gets opened but neither FirebaseMessaging.onMessageOpenedApp nor FirebaseMessaging.instance.getInitialMessage() emits a Remote message - so app doesn't know where to navigate.

[1] Other steps to reproduce the behavior:

Open an app which is using PN
Put it in the background (by clicking on the home button for example)
Emit push notification.
Clean memory (or close the app so it is no longer in the background)
Open the app again
Click on PN
App gets opened but neither FirebaseMessaging.onMessageOpenedApp nor FirebaseMessaging.instance.getInitialMessage() emits a Remote message - so app doesn't know where to navigate.

Expected behavior
After point 5 in steps to reproduce[1], FirebaseMessaging.instance.getInitialMessage() should return RemoteMessage. And after point 5 in steps to reproduce[2], FirebaseMessaging.onMessageOpenedApp should emmit RemoteMessage.

Hi @bohdan1krokhmaliuk
I was not able to reproduce the issue with the steps you mentioned (both variations) using the official example with firebase_messaging: ^9.1.0

flutter doctor -v
[√] Flutter (Channel master, 2.1.0-13.0.pre.294, on Microsoft Windows [Version 10.0.19041.867], locale et-EE)
    • Flutter version 2.1.0-13.0.pre.294 at C:\Development\flutter_master
    • Framework revision a603714610 (26 hours ago), 2021-03-28 03:54:02 -0700
    • Engine revision b5e15d055d
    • Dart version 2.13.0 (build 2.13.0-162.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\marku\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\201.7199119\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.7.7)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.7.30621.155
    • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.1.0)
    • Android Studio at C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\201.7199119
    • Flutter plugin version 54.0.1
    • Dart plugin version 201.9335
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] IntelliJ IDEA Ultimate Edition (version 2020.3)
    • IntelliJ at C:\Users\marku\AppData\Local\JetBrains\Toolbox\apps\IDEA-U\ch-0\203.7717.56
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart

[√] Connected device (4 available)
    • SM G950F (mobile) • ce12171c51cc001c03 • android-arm64  • Android 9 (API 28)
    • Windows (desktop) • windows            • windows-x64    • Microsoft Windows [Version 10.0.19041.867]
    • Chrome (web)      • chrome             • web-javascript • Google Chrome 89.0.4389.90
    • Edge (web)        • edge               • web-javascript • Microsoft Edge 89.0.774.57

• No issues found!

As mentioned in the documentation https://firebase.flutter.dev/docs/messaging/usage#receiving-messages when the app is killed on Android the notifications to be received or listened to.
Did I read correctly that you are not able to get the initial message or onMessageOpenedApp if you just close the app normally and tap the notification?
Thank you

@markusaksli-nc  yes, if the notification was received when app was in the background mode, and then app was closed, exactly that notification will not produce any remote message. If the notification was received when the app was closed it will produce RemoteMessage.
I didn't remove below code from AndroidManifest.xml, can it be the reason of that problems? If I remove that, then all messages which are sent with click_action: 'FLUTTER_NOTIFICATION_CLICK' will not redirect to app at all. So I left that in order to keep push notifications working in old versions of the app.
<intent-filter>
                <action android:name="FLUTTER_NOTIFICATION_CLICK" />
                <category android:name="android.intent.category.DEFAULT" />
</intent-filter>

That should no longer be necessary. The intent filter would still be there in the old versions of the app even if you remove it for your next update so it shouldn't matter?
I tried adding it in and specifying the click action of the notification but still didn't run into this.
Where are you listening to the onMessageOpenedApp stream or calling getInitialMessage?
You could also try just running the official example code to see if this is a code issue.

@markusaksli-nc Yes it no longer needed, but if I send push notification with click_action: 'FLUTTER_NOTIFICATION_CLICK' to app with firebase_messaging version 9 and remove that intent-filter, click on notification will do nothing at all. The app is not even opened. If I remove click_action: 'FLUTTER_NOTIFICATION_CLICK' from push notification itself app will open and emmit RemoteMessage.
Please check these points:

App with firebase_messaging v7 + with click_action: 'FLUTTER_NOTIFICATION_CLICK' + intent filter: in PN works fine (expected)
App with firebase_messaging v7 + with click_action: 'FLUTTER_NOTIFICATION_CLICK' + no intent filter: in PN works bad (expected)
App with firebase_messaging v9 + without click_action: 'FLUTTER_NOTIFICATION_CLICK' + No intent filter:  in PN works fine (expected)
App with firebase_messaging v9 + with click_action: 'FLUTTER_NOTIFICATION_CLICK' in PN + No intent filter:  doesn't work, app receives PN but doesn't redirect anywhere, even app is not opened (not expected)
App with firebase_messaging v9 + with click_action: 'FLUTTER_NOTIFICATION_CLICK' in PN + intent filter: PN are redirecting to app and working as expected except this only edge case when PN was received during app in background and opened when app is closed (not expected)

This is the video how it works:

app is in background and notification(received during app in background) clicked - it works as expected
app is closed and notification(received during app closed) clicked - it works as expected
app is closed and notification(received during app in background) clicked - it works not as expected

https://user-images.githubusercontent.com/59435984/112849963-4029ed00-90b2-11eb-83ea-14cc92b0a45b.mov

Could you try the same with the official example to make sure this isn't just an implementation issue?

I take it that the official example worked for this edge case then?
 Officially it is reccommended to use the v1 FCM HTTP API Please take a look at https://github.com/FirebaseExtended/flutterfire/issues/4611#issuecomment-757917877
There should be no special implementation needed here, since it should work out of the box as with the official example unless you are initializing the streams wrong.

If I am initializing streams wrong, why I don't have same issue for IOS? and also why it works for all normal situations for android except when push notific received in background and app killed?
I have a specific service which resolves messaging, when app is opened it initializes streams and RemoteMessages are intercepted. As soon as it is intercepted app navigates to specific screen.
On firebase messaging v7 it worked fine for all occassions, then I updated to v9 and now it also works pretty fine, except this one edge case. Implementation of my service was not changed, I made only updates on breaking changes of firebase messaging v9.

I meant if the streams are being listened to in the wrong place but it's hard to say. What would really help diagnose the issue here is a minimal complete reproducible code sample since we can't reproduce this with the official example.

Verified this on latest stable using above project and I see notification object being null when app is closed.

flutter doctor -v
[✓] Flutter (Channel stable, 2.0.4, on Mac OS X 10.15.4 19E2269 darwin-x64,
    locale en-GB)
    • Flutter version 2.0.4 at /Users/dhs/documents/fluttersdk/flutter
    • Framework revision b1395592de (7 days ago), 2021-04-01 14:25:01 -0700
    • Engine revision 2dce47073a
    • Dart version 2.12.2

[!] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.3, Build version 12C33
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin
        code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see
      https://guides.cocoapods.org/using/getting-started.html#installation for
      instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6915495)

[✓] VS Code (version 1.55.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.20.0

[✓] Connected device (3 available)
	  SM A260G (mobile)            • 5200763ebcfa861f • android-arm    • Android
      8.1.0 (API 27)
    • Darshan's iphone (mobile) • 21150b119064aecc249dfcfe05e259197461ce23 • ios
      • iOS 14.4.1
    • macOS (desktop)           • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)              • chrome                                   •
      web-javascript • Google Chrome 89.0.4389.114

! Doctor found issues in 1 category.

@markusaksli-nc Yes it no longer needed, but if I send push notification with click_action: 'FLUTTER_NOTIFICATION_CLICK' to app with firebase_messaging version 9 and remove that intent-filter, click on notification will do nothing at all. The app is not even opened. If I remove click_action: 'FLUTTER_NOTIFICATION_CLICK' from push notification itself app will open and emmit RemoteMessage.
As the message may be sent to any app version - I keep this click_action: 'FLUTTER_NOTIFICATION_CLICK' and intent filter is more like workaround (look point 4)
Please check these points:

App with firebase_messaging v7 + with click_action: 'FLUTTER_NOTIFICATION_CLICK' + intent filter: in PN works fine (expected)
App with firebase_messaging v7 + with click_action: 'FLUTTER_NOTIFICATION_CLICK' + no intent filter: in PN works bad (expected)
App with firebase_messaging v9 + without click_action: 'FLUTTER_NOTIFICATION_CLICK' + No intent filter:  in PN works fine (expected)
App with firebase_messaging v9 + with click_action: 'FLUTTER_NOTIFICATION_CLICK' in PN + No intent filter:  doesn't work, app receives PN but doesn't redirect anywhere, even app is not opened (not expected)
App with firebase_messaging v9 + with click_action: 'FLUTTER_NOTIFICATION_CLICK' in PN + intent filter: PN are redirecting to app and working as expected except this only edge case when PN was received during app in background and opened when app is closed (not expected)

I am facing the exact same issue like you after I migrated to null safety.

Having the same issues in Android.

Hey @bohdan1krokhmaliuk, I'm happy to debug, but do you mind updating your code sample? I've just ran your project and I'm not receiving popup notifications with the app in the background or foreground (although I can see the notifications coming through the logs).

@russellwheatley Sorry, I have no time for that now. If you are pushing notifications from the app - there is a delay for 2 seconds, so If you put the app into background just after you requested a new push - you should see a push pops up.
If this doesn't work for you - feel free to emit pushes from postman or any other tool you can use. Server key is present into the app code.

The problem isn't receiving the notification, the PN UI isn't being triggered so I'm unable to verify.

Hi @russellwheatley, just launched  the project again and everything works fine. When you generate a push notification please put app to the background so within 2 seconds push notificaiton will be emmited. Make sure you are using android device or simulator as the issue originally created for android platform, also I didn't provide APNS key for Apple side.


why 3 nested loop in function banditSimulation in TenArmedTestbed.py

if 3 nested loop,isn't that the number of simulations to be nBanditsnBanditstime?

Yes. But the first loop is to set up different test cases.


Can't generate hover variant for fill

I'm trying to generate hover and focus variants of my main color but I looked through my global.css where all the tailwind classes are generated and its not there. But I found responsive variants for my main color.
This is my tailwind.config.js
module.exports = {
    theme: {
        extend: {
            colors: {
                main: "#B562E7",
            },
            fill: theme => ({
                'theme': theme('colors.'),
            })
        },
        variants: {
            fill: ['responsive', 'hover', 'focus']
        },
        plugins: []
    }
}

You have a typo in theme('colors.'), and the object shape for fill is wrong, it doesn't need a theme key, just spread in the colors:
module.exports = {
    theme: {
        extend: {
            colors: {
                main: "#B562E7",
            },
            fill: theme => ({
                ...theme('colors'),
            })
        },
        variants: {
            fill: ['responsive', 'hover', 'focus']
        },
        plugins: []
    }
}

Here's a working example:
https://tailwind.run/U2P3pm

Thanks. Sorry about that typo😅. I copied from the docs and did a sloppy job editing it.

@adamwathan. Sorry if I'm bothering. This time I tried with the config you posted the hover variant is still not working.
The config I used
module.exports = {
    theme: {
        extend: {
            colors: {
                main: "#B562E7",
            },
            fill: theme => ({
                ...theme('colors'),
            })
        },
        variants: {
            fill: ['responsive', 'hover', 'focus']
        },
        plugins: []
    }
}

and I was expecting this to work
<svg viewBox="0 0 100 100" class="h-10 w-10 fill-red-500 hover:fill-green-500">
  <polygon points="0,0 0,100 100,100 100,0"/>
</svg>

Here is the link https://tailwind.run/U2P3pm/3
But I figured a workaround. Added this to the tailwind.css
@variants focus, hover {
  .fill-green-custom {
    @apply fill-green-500;
  }
}

and my new html looks like this
<svg viewBox="0 0 100 100" class="h-10 w-10 fill-red-500 hover:fill-green-custom">
  <polygon points="0,0 0,100 100,100 100,0"/>
</svg>

Both the workaround and my expected way to do is posted on the link. Maybe I did something wrong.

Ah my mistake, variants and plugins should be one level higher, not nested under theme.
On Oct 26, 2019, 6:29 AM -0400, Justine Kizhakkinedath<EMAIL_ADDRESS>wrote:

@adamwathan. Sorry if I'm bothering. This time I tried with the config you posted the hover variant is still not working.
The config I used
module.exports = {
theme: {
extend: {
colors: {
main: "#B562E7",
},
fill: theme => ({
...theme('colors'),
})
},
variants: {
fill: ['responsive', 'hover', 'focus']
},
plugins: []
}
}
and I was expecting this to work

Here is the link https://tailwind.run/U2P3pm/3
But I figured a workaround. Added this to the tailwind.css
@variants focus, hover {
.fill-green-custom {
@apply fill-green-500;
}
}
and my new html looks like this

Both the workaround and my expected way to do is posted on the link. Maybe I did something wrong.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

Thanks

@adamwathan any plans to add colors to fill by default? So that we can do things like fill-current hover:fill-red-500 or what about fill-opacity ?
Now that we're using SVG icons more and more.. feels like this should be part of the core

@vesper8 Can you not just do this?
<svg class="fill-current text-red-600 hover:text-red-500 text-opacity-50">...</svg>

@adamwathan oh yea... weird.. I thought I tried something like that and it wasn't working.. but yea.. now that I try it again.. it's working fine.. my bad


'title' should be a reserved word that is not allowed when creating a SuperTable field

Wasn't thinking, and used 'title' as the name for a SuperTable field and received the following:
Internal Server Error
CDbCommand failed to execute the SQL statement: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'title' in 'field list'
Sounds like it needs to be a reserved word?

Might be a little late to respond, but did this happen to be for a Super Table field in a Matrix field? There are known issues with field validation in that case, but it works as expected on its own. Closing for now, but please let me know if you're still having issues.

Hey Josh,
Very likely was - good to know!


[485573]: New Vector operations added

Done

-- pr1 (commits are sorted from newest to oldest) (new commits)
a7596fc3f0e7bfe29ebafdc728dfae301b7c32ad - Readme updated with new Vector operations
24bf74209a12ed613d479069a0d1465f3e6d1ac4 - Travis build badge
d94cdc5780ca1153e4cebf81716fdd926c2d1086 - Travis build fixed
473244e40d13193068a9e84c6cdbd1d40e64c055 - Tests for added Vector methods
65d7a2e8ab0ba09adf95ee7d301970d4c08480d5 - Implemented Vector methods marked as TODO
--pr1 after squash (new commits)
50679d48af8d07959d7f10820db16179a006277d - Implemented Vector methods marked as TODO
--pr2 (new commits)
d163e24a534dba05018eab3c7806c7f4a8744657 - Remaining Vector methods added
2de8b5428b2c25ee6001b7875c4dd0367de0cc53 - Tests for Vector and method
ec0f0b6bcabf87b91f9221a322c4890a3f7aa540 - Unit tests fixed
--pr2 after squash (new commits)
546802cd3d16e8820f85c82982ea9d73bb4e4350 - Implemented remaining Vector methods marked as TODO

Travis passes but 0 tests is executed, pls fix this.

@cucak559 pls squash the commits to one single signed commit. then I can approve and award you HW points. Pls tag me in comment here when you are done. Thx

@ph4r05 Commits squashed


-iv unsets -c

Expected Behavior
If -iv and -c are both set they should both be taken into account when deciding to transfer a caught pokemon.
Actual Behavior
If -iv and -c are set. Only the -iv value is used, disregarding the -c.
Steps to Reproduce
Other Information
OS: Linux
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)

Sorry I think it actually is doing the wanted behavior at the moment. How do I close this?

Left button next the green Comment Button.


cannot import react-pdf-html v1.3.2 in plain esm project

The package.json points to directory mjs, which does not exist:
https://github.com/danomatic/react-pdf-html/blob/7799a3f3b4bf91c17ac8bf2c48269a999e4619cf/package.json#L23
fixing that to point to "./dist/esm/index.js" causes another problem:
 Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/proj/node_modules/react-pdf-html/dist/esm/Html'

I guess it is caused by missing .js extensions in dist/esm/index.js:
export { default, default as Html } from './Html';

its also happening to me since today.
  ✘ [ERROR] Failed to resolve entry for package "react-pdf-html". The package may have incorrect main/module/exports specified in its package.json. [plugin vite:dep-scan]

We just added support for ES modules. Please try v1.3.3

The v1.3.3 fixed the import directory, but node still complains about missing file extension. I guess that the .js extensions should be added to the source code. Typescript does not seem to have an option to add those extensions.
test.mjs contains only the import:
import html from 'react-pdf-html';

output:
$ node test.mjs
node:internal/modules/esm/resolve:264
    throw new ERR_MODULE_NOT_FOUND(
          ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/proj/node_modules/react-pdf-html/dist/esm/Html' imported from /proj/node_modules/react-pdf-html/dist/esm/index.js
    at finalizeResolution (node:internal/modules/esm/resolve:264:11)
    at moduleResolve (node:internal/modules/esm/resolve:917:10)
    at defaultResolve (node:internal/modules/esm/resolve:1130:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:396:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:365:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:240:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:85:39)
    at link (node:internal/modules/esm/module_job:84:36) {
  code: 'ERR_MODULE_NOT_FOUND',
  url: 'file:///proj/node_modules/react-pdf-html/dist/esm/Html'
}

Node.js v20.11.0

Ok try v1.3.4

Hmm ok. I'm not sure how to handle 3rd party libraries being CommonJS, but I just updated all the dependences and published v.1.3.5. Try that!

I just published a new version v1.3.6 that does not require esModuleInterop

v1.3.7 works fine. Thank you!

Hmm...but I am getting this when I bundle it with esbuild:

I am not familiar with esbuild, but maybe requiring sync-fetch would work?
import { createRequire } from 'module';
const require = createRequire(import.meta.url);
const fetch = require('sync-fetch');

I decided not to support local external stylesheets and fs in v2.0.0


"Error: 'default' is not exported by..." when building with imported umd module

Describe the bug
I'm trying to use CKEditor in my project. They distribute the editor as a UMD module and I'm linking it to my project using npm workspaces. When I import the module in my code, I get the following error in the browser console when running the dev server:
ckeditor.svelte:2 Uncaught (in promise) SyntaxError: The requested module '/ckeditor/build/ckeditor.js' does not provide an export named 'default'

I resolved that issue by setting:
optimizeDeps: {
      include: ['ckeditor5-custom-build'],
      ...
}

However, when I try to do a production build, I get a similar error during the build process:
'default' is not exported by ckeditor/build/ckeditor.js, imported by src/components/ckeditor.svelte
file: /home/zrean/projects/kookbook/src/components/ckeditor.svelte:2:7
1: <script>
2:   import BalloonBlockEditor from 'ckeditor5-custom-build'
          ^
3:   import { onMount, createEventDispatcher } from 'svelte'
4:   import FirebaseStorageAdapter from '../libs/firebaseStorageAdapter'
error during build:
Error: 'default' is not exported by ckeditor/build/ckeditor.js, imported by src/components/ckeditor.svelte
    at error (/home/zrean/projects/kookbook/node_modules/rollup/dist/shared/rollup.js:5308:30)
    at Module.error (/home/zrean/projects/kookbook/node_modules/rollup/dist/shared/rollup.js:9717:16)
    at Module.traceVariable (/home/zrean/projects/kookbook/node_modules/rollup/dist/shared/rollup.js:10105:29)
    at ModuleScope.findVariable (/home/zrean/projects/kookbook/node_modules/rollup/dist/shared/rollup.js:8875:39)
    at FunctionScope.findVariable (/home/zrean/projects/kookbook/node_modules/rollup/dist/shared/rollup.js:2658:38)
    at ChildScope.findVariable (/home/zrean/projects/kookbook/node_modules/rollup/dist/shared/rollup.js:2658:38)
    at ReturnValueScope.findVariable (/home/zrean/projects/kookbook/node_modules/rollup/dist/shared/rollup.js:2658:38)
    at ChildScope.findVariable (/home/zrean/projects/kookbook/node_modules/rollup/dist/shared/rollup.js:2658:38)
    at MemberExpression.bind (/home/zrean/projects/kookbook/node_modules/rollup/dist/shared/rollup.js:6564:49)
    at CallExpression.bind (/home/zrean/projects/kookbook/node_modules/rollup/dist/shared/rollup.js:2745:23)

I would expect the production build to work since the dev build work perfectly fine.
I'm having a hard time figuring out why this is happening and any help would be appreciated!
Reproduction
You can clone my repo and build it. The issue will be apparent:
https://github.com/TheSimpleZ/kookbook
Use the add-vite branch, run npm i and then npm run build. Running npm run dev works perfectly fine.
System Info
Output of npx envinfo --system --npmPackages vite,@vitejs/plugin-vue --binaries --browsers:
System:
    OS: Linux 4.19 Ubuntu 20.04.1 LTS (Focal Fossa)
    CPU: (8) x64 Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz
    Memory: 1.45 GB / 7.77 GB
    Container: Yes
    Shell: 5.8 - /usr/bin/zsh
  Binaries:
    Node: 14.16.0 - /usr/local/bin/node
    Yarn: 1.22.4 - /mnt/c/Program Files (x86)/Yarn/bin/yarn
    npm: 7.6.3 - /usr/local/bin/npm
  npmPackages:
    @sveltejs/vite-plugin-svelte: ^1.0.0-next.5 => 1.0.0-next.5
    vite: ^2.1.2 => 2.1.2

Used package manager: npm
Logs
Logs with the debug flag are quite long and will probably make this post hard to read.
The most relevant parts are shown above. If you need more details, please use the repo I linked.
Before submitting the issue, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the docs.
[x] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[x] Provide a description in this issue that describes the bug.
[x] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/vue-next instead.
[x] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.

The add-vite branch not found, i tested with your master code, it works fine for build.

Hello! Thanks for trying it out. I was trying to find the issue myself and found a solution for it yesterday. I had to add
build: {
      commonjsOptions: {
        exclude: ['ckeditor/*'],
      },
....
 }

Now it's working fine. I also restored the add-vite branch the way it was previously, in case you want to check out the problem. Unless this is a problem you'd like you track, this issue can be closed for now :)

I found the same problem with our private code base. Is this a bug or simply a necessary configuration step for vite?

Describe the bug
I'm trying to use CKEditor in my project. They distribute the editor as a UMD module and I'm linking it to my project using npm workspaces. When I import the module in my code, I get the following error in the browser console when running the dev server:

I notice linking. Try not to using linking, use file: or yarn add instead.

I just stumbled upon this error when I updated vite from version 2.4 to 2.7. My error is caused by a named export and not a default export though.
error during build:
Error: 'SharedArray' is not exported by ../shared-project/lib/index.js, imported by main-project/index.ts
    at error (/workspace/pvs/client/node_modules/rollup/dist/shared/rollup.js:158:30)
    at Module.error (/workspace/pvs/client/node_modules/rollup/dist/shared/rollup.js:12354:16)

shared-project is a private package in my monorepo, that I symlinked using
// main-project/package.json
"shared-project": "file:../shared-project",

With vite version 2.4 my vite and vite build commands worked fine using this config
// old vite.config.ts
{
  plugins: [vue()],
  optimizeDeps: {
    include: ['shared-project'],
  },
  build: {
    commonjsOptions: { exclude: ['shared-project'] },
  },
}

With version 2.7 I get the error above. I tracked the breaking change down to this commit (#5111), but I don't really understand why it's a breaking change. I just know, that when I include include: [] in my commonjsOptions config it works again.
// new vite.config.ts
{
  plugins: [vue()],
  optimizeDeps: {
    include: ['shared-project'],
  },
  build: {
    commonjsOptions: { exclude: ['shared-project'], include: [] }, // <----
  },
}

I'm also getting similar errors, for example:
Error: 'default' is not exported by src/store/index.js, imported by src/main.ts
As @fardolieri suggested, adding commonjsOptions: { include: [] } to the vite config fixes it.

This is now documented at https://vitejs.dev/guide/dep-pre-bundling.html#monorepos-and-linked-dependencies and is an expected configuration in Vite. However, there's a PR https://github.com/vitejs/vite/pull/7094 to improve this.

Thanks for the update.
while adding optimizeDeps: { include:['my-pkg'] } does solve the pre-bundling of linked packages issue,
the package name must match the imported path exactly and any subpath of the package will not be included.
// optimizeDeps: { include:['my-pkg'] }

import {MyClass} from 'my-pkg'; // works
import {MyClass} from 'my-pkg/classes'; // Error: 'MyClass' is not exported by ....

the issue is in this line which checks for literal string match.
it could be changed to one or both of these:

take into account all subpaths of the given package (packages can also be in @company/package format)
also accept regex - (example /^my-pkg(\/|$)/)

Meanwhile - all imported paths needs to be added explicitly - e.g.
{optimizeDeps: {include: ['my-pkg', 'my-pkg/classes']}}


fix: don't change AST for other rules

Ok this is annoying. I was hoping to avoid this sort of extra traversal. But I overlooked that obvious changing the ast for one rule is going to affect what other rules see, even if the final AST isn't used for anything. So this was creating invalid tree's that were failing the built in rules. Now this does a full traversal isolated. This was easier than trying to do it the main visit loop and probably not much more inefficient

@itajaja basically it walks the AST tree and calls every visitor for each node. visitors can change nodes which doesn't mutate the AST but does change what nodes the rest of the visitors see as it traverses the new nodes. The tests only checked the one rule so i missed the obvious problem that this would break other validation rules.
the core concern here is that this now does a full AST traverse for this one rule in addition to the normal single pass done for all other rules. Question is whether an extra AST traversal per request is fine or not. I can't think of a way to implement this during validation that doesn't basically do a second pass. The more "efficient" alternative would be to calculate cost during execution (where the fragments are resolved and merged into one tree) and bail when the cost gets to high, but i don't know that there are hooks for doing that in graphql.js b/c its much worse than other languages in terms of features.


Fixing the building of hanoidb for R18

Some of the dependencies are broken and type definitions are no longer valid for R18.
Fix sext and edown dependency
Fix array() type defs
Change-Id: Ibc2986b690fb81ef9d757fa7b8ba20a994bc8fa2

Any hints for how to fix this across erlang releases?
https://travis-ci.org/krestenkrab/hanoidb/builds/117436445
You should also update the .travis file to include R18.

Yeah, I'm going to redo this PR to include  R18 for travis and workout how it would work across releases.. Sorry for a hastily sent PR :)

I used rebar's platform_depend trickery.. builds work now, feel free to review! :)

Superb. Thanks @a13x!


Honor --chain-id even when using fork mode

Motivation
DappTools always used chain ID 99, even when forking from a remote RPC, whereas Foundry just falls back to the chain ID of the RPC. The motivation here is DappTools compatability
Solution
I made chain ID optional and:

If we're forking from a remote RPC, we override the chain ID if specified anywhere in the config (foundry.toml, CLI arg, environment)
If we're not using fork mode, but the chain ID has not been specified, we still default to chain ID 1.

Closes #601 and fixes drai integration test

A forked mainnet is a new chain and should have a new ID.
It can be alarming seeing I sent a test tx on chain 1.
Hardhat does not have this behavior.

can you please open a new issue for this and describe what we should consider changing?