Improving clj-kondo hook

This commit attempts to improve the clj-kondo hook for the routes macro to better handle routes that receive a req map instead of a parsed path-param vector, as clj-kondo incorrectly raises warnings on those.
This is still a work in progress. Below are the linting results for the following bit of code:
(def routes
  (router/routes
    ;; ...

    "POST /w/*" req
    (let [page-name (first (:path-params req))
          content (get (:form-params req) "content")]
      (save-page page-name content))))

Before:
$ clj-kondo --lint src/wiki/core.clj
src/wiki/core.clj:40:5: error: Function arguments should be wrapped in vector.
src/wiki/core.clj:40:11: error: Unresolved symbol: page-name
src/wiki/core.clj:41:11: error: Unresolved symbol: content
linting took 21ms, errors: 3, warnings: 0

After:
$ clj-kondo --lint src/wiki/core.clj
src/wiki/core.clj::: error: unsupported binding form bindings
src/wiki/core.clj:40:42: error: Unresolved symbol: req
linting took 104ms, errors: 2, warnings: 0

I'd love to fix this myself, so I'd appreciate any pointers!

I think it should be (api/vector-node [bindings]) or even (api/vector-node bindings) (depends on what vector-node expects)

Thanks for the tip, it seems to be working now :)
$ clj-kondo --lint src/wiki/core.clj
linting took 92ms, errors: 0, warnings: 0

Thanks! Merged


Inserting with a JSON Column

I have a table with a JSON Column. Something like this:
db
  .schema
  .createTable('my_table')
  .addColumn('my_json', 'json')
  .execute();

When inserting values I get the following error (shortened to the relevant part):
vttablet: rpc error: code = Unknown desc = Invalid JSON text: "Invalid value." at position 1 in value for column 'my_table.my_json'.

When I cast the values to strings (JSON.stringify) everything works fine. Problem is with the typings, though. Since keysley expects the my_json property to be an object.

Hey! For the types, you could change the definition of what Kysely believes that column should be - we use kysely-codegen to generate the types, and json columns are generated as:
import type {ColumnType} from 'kysely'

export type Json = ColumnType<JsonValue, string, string>

export type JsonArray = JsonValue[]

export type JsonObject = {
  [K in string]?: JsonValue
}

export type JsonPrimitive = boolean | null | number | string

export type JsonValue = JsonArray | JsonObject | JsonPrimitive

export interface MyTable {
  my_column: Json
}

Simplifying for your case, you could just directly use ColumnType, the three type arguments are for select type, insert type, and update type, so:
column: ColumnType<object, string, string>

@jacobwgillespie thanks for the quick reply! Will look into the codegen lib.
My current issue is not really the types l. It also might be an issue with kyseley itself.
The types are fine. But if I insertInto and use an object / JSON for the JSON column, planetscale will return the above error. Only if I stringify the column it will work.
It's my first time using kyseley so I am not sure if I have to do something different than just pass the object.

Ah, yeah, I'm not sure if it's a Kysely thing or a MySQL thing, but when inserting or updating, you need to send the JSON.stringify() string value, but when selecting you'll get back an object. That ColumnType<object, string, string> can help Kysely to enforce that restriction.
We have that behavior with both the PlanetScale serverless driver and with the mysql2 client using Kysely in our projects, fwiw.

@jacobwgillespie good to know, didn't find anything in their docs 😄
So you are using a different type for inserting and selecting the column?


Sierra book, many items example

What is this PR trying to achieve?
Adding sample data (plus comments) for a Sierra book record with multiple items
Who is this change for?
Silver Oliver initially then Platform team

Welcome to the party @silveroliver! 🎉 ✨

/data/Sierra_book_many_items.json: line 34, col 7, Duplicate key 'placeOfPublication'.
/data/Sierra_book_many_items.json: line 82, col 5, Duplicate key 'relatedMaterialNote'.

Changes made to address earlier comments, and JSON validated, so now merging this.


docs: Update repo URLs in README.md

Changes Unknown when pulling 2efaad366ac5eae21a184743a1503cf07a66fca7 on wpcs-url into ** on master**.


convert client to es6 class and add babel for backwards compatibility

tests are passing for node v0.10.32

#8
I rarely do pull requests so I hope everything is in order here.

That's a good start. We could take the advantage of more ES6 features, such as arrow function expressions, promises, destructuring and so on, but don't feel forced to do it.
I would like to proceed with the merge if that's ok for you.

I agree and will progress the code update.
Travis says that the latest stable build (v7.0) failed but locally I am having no issues with that build.

The Travis issue is related to an npm error, but not quite sure why. In any case, lodash was only a dev dependency and not used anymore, so I removed it. That should fix the issue.


Imagesource registry check

Close #40
Changes to be committed:
modified:   certification/engine/engine.go
new file:   certification/internal/shell/imagesource_registry.go
modified:   go.mod

Close #40
Changes to be committed:
modified: certification/engine/engine.go
new file: certification/internal/shell/imagesource_registry.go
modified: go.mod

The Close #40 should be the last line, separated by an empty line.

I'm a bit confused here - this PR implements an imagesource check on an operator bundle, but I think this is incomplete. Correct me where I'm wrong, but I'm understanding the ansible implementation of this check to read the operator images themselves, and ensure they're in an approved registry.
I'm looking here:
https://github.com/redhat-openshift-ecosystem/operator-test-playbooks/blob/master/local-test-operator.yml#L286-L298
Can I have a second pair of eyes to double check if I'm misunderstanding?
CC @samira-barouti @bcrochet @rocrisp

I'm a bit confused here - this PR implements an imagesource check on an operator bundle, but I think this is incomplete. Correct me where I'm wrong, but I'm understanding the ansible implementation of this check to read the operator images themselves, and ensure they're in an approved registry.
I'm looking here:
https://github.com/redhat-openshift-ecosystem/operator-test-playbooks/blob/master/local-test-operator.yml#L286-L298
Can I have a second pair of eyes to double check if I'm misunderstanding?
CC @samira-barouti @bcrochet @rocrisp

You are correct. I know I chatted with @rocrisp about it, but I guess I didn't do it here on GitHub. It is definitely a more involved check in the Ansible implementation.

Understood.
@rocrisp are you available to take this and add the additional components?

I see what you're talking about.
So it needs to check the image source of the containers for the operator image bundle..
Thanks for the findings.

Requirements :
This check requires deployment of the operator.
Check operator images.
operator images is a list of differences between images before the deployment and images after the deployment.
Formula for the operator image list is a combination of these commands :
"{{ oc_bin_path }} get is --all-namespaces
-o json | jq '.items[].spec.tags[] |
select(.from.kind == "DockerImage") |
.from.name' --raw-output | sort -u"
and
"{{ oc_bin_path }} get pods --all-namespaces
-o json | jq '.items[].spec.containers[].image'
--raw-output | sort -u"

Example of a list of operator images to test :
TASK [operator_imagesource_test : Output all operator images] ******************
task path: /tmp/workspace/testing-cvp-nonproduction/roles/operator_imagesource_test/tasks/main.yml:2
ok: [localhost] => {
"operator_images": [
"quay.io/operator-framework/scorecard-proxy:master",
"registry.connect.redhat.com/zabbix/zabbixoperator-certified:v0.0.3"
]
}

For now, unless we make this part of the OLM check, it would be sufficient to test images from *.clusterserviceversion.yaml.


When launching the app in edge, I received a certificate error.

Problem encountered on https://dotnet.microsoft.com/en-us/learn/aspnet/blazor-tutorial/run
Operating System: windows
Provide details about the problem you're experiencing. Include your operating system version, exact error message, code sample, and anything else that is relevant.
When launching the app in edge, I received a certificate error. The certificate could not be trusted. I changed the browser to Chrome and it worked fine.

Please shut down all your browser instances and try to run the project again.
Let us know if that works.
/cc @danroth27 @DamianEdwards


Volume apps UI

As a user, I want to see a menu item called "APPS" where the user can select the following products:

Volume Private Credit
All bots that are listed on palomabot.ai

We want the same functionality for the bots listed on volume that we have on palomabot.
Note that we will have new contracts for each bot deployed since we won't charge a fee via the contract for the bots listed on volume
Design: https://www.figma.com/file/5SxDu8o2gA3KWd2GZEHnZr/Volume-Website?type=design&node-id=9140-3934&mode=design&t=qVNJLOkmrQZkZ4la-4

Will pause and re-assign to new Front-end Dev.


Validators module

Initial draft of a module for apps to manage validator sets (#252).
Changes from what was described in that issue:

Addition of store Var to keep a set of the current validator pubkeys, since store Map doesn't have a method to get all keys/values
Used List type for QueuedUpdates, so that adding an update would be fast, and Map like behavior can be constructed from a foldl
Used Word64 instead of Natural. Still non-negative, but bounded since Tendermint has a 64bit bound on validator power anyway.
Didn't implement Queries for QueuedUpdates, since it is always reset in EndBlock, and query is for committed state (it would always be [])

I'm not very familiar with the Query system, so that is in particular need of review.
Also Weeder is going to fail until this has some tests, and I imagine that is going to take a while because I'm not familiar with the Kepler testing system, and proper testing will require multiple Tendermint docker instances.

regarding a proper tests setup with multiple docker images, I am not really worried about that in this PR but feel free to file an issue. It seems simple enough that things should just work 🤞

To your comment points:
I think the "Set of Map keys" pattern could be added as a feature in Map. Since IAVL has the IterateRange methods and the gRPC layer has the List method, it should be possible to get all the key/value pairs for a Map substore. I can write up an issue if you think this is worth pursuing.
ValidatorUpdate is basically just a redefinition of the ValidatorUpdate data type from ABCI, but using PubKey_ instead of Maybe ABCI.PubKey (Not clear to me why ABCI.ValidatorUpdate has a Maybe on it's PubKey) so that HasCodec could easily implemented on both (using Generic and JSON). I would generally prefer to just reuse the ABCI types directly, but we can't really put HasCodec and RawKey implementations in ABCI without creating a circular dependency mess between ABCI and the SDK.
I can probably do this more cleanly with newtype and by reusing the proto stuff from ABCI to implement HasCodec / RawKey in types.hs.
Also ValidatorUpdate is not externally accessible partly because it's only being used as a way to queue updates from different deliverTx into the endblock, it's never actually stored in committed state. Which is somewhat weird, but I can't really see a better way to do this other than creating some entirely new system for local block processing storage.
I agree with the larger point about cross platform compatibility and standardization, so I'll switch all of this over to proto.

Regarding new typing to avoid circular dependency, or what would usually be orphan instances , it’s a very common method. If you need to do it then go for it.
i think you should write up this issue for map with keys because it would be really useful.  Regarding the grpc stuff, maybe you’ve seen but I have a branch to upgrade the grpc protobuf file from iavl. I just haven’t finished it yet...

Okay. Did some stuff:

Used StateT as recommended in EndBlock.
Removed Keeper methods
Switched ValidatorUpdate and PubKey to be newtypes around ABCI types which reuse existing proto serializations

Two things to note:

I didn't switch KeySet to protobuf, because I expect this will end up being removed eventually anyway if #254 happens. (and didn't want to clutter things up with a new proto file for one temporary type, which isn't externally accessible)
I also removed the Maybe from PubKey in the ABCI ValidatorUpdate definition. The actual proto has this as not nullable, and the Tendermint side expects it to not be null, so it seemed valid to expect the data type to always have a pubkey value.

So this is an interesting test failure:
Failures:

  test/Network/ABCI/Test/Types/MessagesSpec.hs:46:5:
  1) Network.ABCI.Test.Types.Messages.Request.initChain Unwrapped -> Wrapped -> Unwrapped == identity
       Falsified (after 4 tests and 5 shrinks):
         ArbitraryMessage {unArbitraryMessage = {validators { }}}

  To rerun use: --match "/Network.ABCI.Test.Types.Messages/Request/initChain/Unwrapped -> Wrapped -> Unwrapped == identity/"

  test/Network/ABCI/Test/Types/MessagesSpec.hs:46:5:
  2) Network.ABCI.Test.Types.Messages.Response.initChain Unwrapped -> Wrapped -> Unwrapped == identity
       Falsified (after 2 tests and 2 shrinks):
         ArbitraryMessage {unArbitraryMessage = {validators { }}}

  To rerun use: --match "/Network.ABCI.Test.Types.Messages/Response/initChain/Unwrapped -> Wrapped -> Unwrapped == identity/"

  test/Network/ABCI/Test/Types/MessagesSpec.hs:46:5:
  3) Network.ABCI.Test.Types.Messages.Response.endBlock Unwrapped -> Wrapped -> Unwrapped == identity
       Falsified (after 3 tests and 3 shrinks):
         ArbitraryMessage {unArbitraryMessage = {validator_updates { }}}

  To rerun use: --match "/Network.ABCI.Test.Types.Messages/Response/endBlock/Unwrapped -> Wrapped -> Unwrapped == identity/"

  test/Network/ABCI/Test/Types/MessagesSpec.hs:46:5:
  4) Network.ABCI.Test.Types.Messages.FieldTypes.ValidatorUpdate Unwrapped -> Wrapped -> Unwrapped == identity
       Falsified (after 3 tests and 1 shrink):
         ArbitraryMessage {unArbitraryMessage = {}}

This is being caused by my changing the ValidatorUpdate type from: Maybe PubKey to PubKey. Interesting that it's only on the "Unwrapped -> Wrapped -> Unwrapped" side of the tests.
My reading of this is that it can start with an "Unwrapped" protobuf value which doesn't have the key, and then when it tries to turn it into a ValidatorUpdate object it fails...
Is this basically why the value was Maybe PubKey in the first place? I sorta figured there was some way to cleanly tell it that a null PubKey could not be used to form a valid ValidatorUpdate, but I don't know how to tell the tests that.
I can also just switch the type back to Maybe PubKey if this is too much of a mess to fix.

So this is an interesting test failure:
Failures:

  test/Network/ABCI/Test/Types/MessagesSpec.hs:46:5:
  1) Network.ABCI.Test.Types.Messages.Request.initChain Unwrapped -> Wrapped -> Unwrapped == identity
       Falsified (after 4 tests and 5 shrinks):
         ArbitraryMessage {unArbitraryMessage = {validators { }}}

  To rerun use: --match "/Network.ABCI.Test.Types.Messages/Request/initChain/Unwrapped -> Wrapped -> Unwrapped == identity/"

  test/Network/ABCI/Test/Types/MessagesSpec.hs:46:5:
  2) Network.ABCI.Test.Types.Messages.Response.initChain Unwrapped -> Wrapped -> Unwrapped == identity
       Falsified (after 2 tests and 2 shrinks):
         ArbitraryMessage {unArbitraryMessage = {validators { }}}

  To rerun use: --match "/Network.ABCI.Test.Types.Messages/Response/initChain/Unwrapped -> Wrapped -> Unwrapped == identity/"

  test/Network/ABCI/Test/Types/MessagesSpec.hs:46:5:
  3) Network.ABCI.Test.Types.Messages.Response.endBlock Unwrapped -> Wrapped -> Unwrapped == identity
       Falsified (after 3 tests and 3 shrinks):
         ArbitraryMessage {unArbitraryMessage = {validator_updates { }}}

  To rerun use: --match "/Network.ABCI.Test.Types.Messages/Response/endBlock/Unwrapped -> Wrapped -> Unwrapped == identity/"

  test/Network/ABCI/Test/Types/MessagesSpec.hs:46:5:
  4) Network.ABCI.Test.Types.Messages.FieldTypes.ValidatorUpdate Unwrapped -> Wrapped -> Unwrapped == identity
       Falsified (after 3 tests and 1 shrink):
         ArbitraryMessage {unArbitraryMessage = {}}

This is being caused by my changing the ValidatorUpdate type from: Maybe PubKey to PubKey. Interesting that it's only on the "Unwrapped -> Wrapped -> Unwrapped" side of the tests.
My reading of this is that it can start with an "Unwrapped" protobuf value which doesn't have the key, and then when it tries to turn it into a ValidatorUpdate object it fails...
Is this basically why the value was Maybe PubKey in the first place? I sorta figured there was some way to cleanly tell it that a null PubKey could not be used to form a valid ValidatorUpdate, but I don't know how to tell the tests that.
I can also just switch the type back to Maybe PubKey if this is too much of a mess to fix.


caps: DG2 add d3d11 support

Signed-off-by: Bin Wu<EMAIL_ADDRESS>

@FocusLuo please help to fix DG2/iHD

@FocusLuo please help to fix DG2/iHD
Fan is preparing to upload her local caps @fanli-hub , will update caps of DG2/ATSM soon.

rebase d3d11 with PR #443


Docker service failed to start, transient error.

After scale-up testing scenario, we got a mismatch for the number of Azure VMs and DC/OS registered agents: https://mesos-jenkins.westus2.cloudapp.azure.com/job/dcos-testing-autoscale/176/console
Digging into the error, I found out that a new public Windows agent failed to initialize, thus causing the mismatch. This the DCOSWindowsAgentSetup.log from the failing agent:
Ok.

[SC] DeleteService SUCCESS
Status      : Stopped
Name        : Docker
DisplayName : Docker Windows Agent

[SC] ChangeServiceConfig2 SUCCESS
[SC] ChangeServiceConfig2 SUCCESS
Downloading Git from http://dcos-win.westus.cloudapp.azure.com/downloads/Git-2.14.1-64-bit.exe
Installing Git

SUCCESS: Specified value was saved.
Docker service was stopped successfully
Failed to start service 'Docker Windows Agent (Docker)'.

It looks that this line failed: https://github.com/dcos/dcos-windows/blob/master/scripts/DCOSWindowsAgentSetup.ps1#L216

This issue turned out to be isolated to the CI scenario where Docker is changed to run under debug mode with the service wrapper.
Docker crashed sometimes when the Docker pid file (located at C:\ProgramData\Docker\docker.pid) existed. This is a dockerd.log from a crashing daemon. You may notice multiple occurrences of this log:
Error starting daemon: pid file found, ensure docker is not running or delete C:\ProgramData\docker\docker.pid

To avoid such problems when running Docker under the service wrapper in the CI, we simply clean-up the pid file in the --exec-start-pre phase: https://github.com/Microsoft/mesos-jenkins/blob/master/DCOS/DCOSWindowsAgentSetup.ps1#L97
We shouldn't see this issue from now on. However, as usual, I'll give the CI 2-3 days and if the problem doesn't reproduce, I'll close this issue.

Everything looks good now. Closing this issue.


Master pods in K8s cannot see the service for itself

Alluxio Version:
2.3.0-SNAPSHOT
Describe the bug
A master pod cannot access itself using its NodePort service. This is called "hair-pinning" and this is disabled in K8s when using iptables. (Ref: https://kb.vmware.com/s/article/67455)
When the master pod is not able to find its own service, the readiness probe never succeeds.
This issue is originally reported by @cheyang
To Reproduce
Steps to reproduce the behavior (as minimally and precisely as possible)
Expected behavior
The work around for the hair-pinning problem is to use headless services for the master pods.
Urgency
Describe the impact and urgency of the bug.
Additional context
The change from headless service to NodePort was done in https://github.com/Alluxio/alluxio/pull/10686/files

https://github.com/Alluxio/alluxio/pull/11563 should fix this issue

@cheyang Do you mind sharing the network configuration in your environment, so we can have a deeper understanding on this please? We didn't face this issue in our internal test environments.

Will close it for now, feel free to reopen it and contact us if this is still valid.


Can't run the pymapdl, whether should I install docker?

I want to know if I must use it , I have pycharm can run well of pyansys, whether I should install docker?
When I install pymapdl, I find I can't run it well.
My ansys version is 17.0,
First I obey the document says change the path:
from ansys.mapdl import core as pymapdl
new_path = 'D:\ANSYS Inc\v170\ANSYS\bin\winx64\ansys170.exe'
pymapdl.change_default_ansys_path(new_path)
And then run the mapdl
from ansys.mapdl.core import launch_mapdl
mapdl = launch_mapdl()
But it meet wrong: RuntimeError: Unable to extract Ansys version from D:\ANSYS Inc\v170\ANSYS\bin\winx64\ansys170.exe
I find my ipv4 address is <IP_ADDRESS>,so I use mapdl = launch_mapdl('<IP_ADDRESS>')
It meet wrong either: FileNotFoundError: Invalid ANSYS executable at "<IP_ADDRESS>"

How can I do? Whether should I install docker? And I want to know where can I find my port, maybe it is not the 50022.

Hi @Villareally,
This is a simple fix to patch, look for an upcoming release.
One of the issues is we don't "officially" support older versions of Ansys.  Since the CORBA interface hasn't changed in the past 5 years, there's no reason why we can't support it (at least as far back as v17).  Really, it's just looking for certain versions within the path and if it doesn't find it, it returns False.
As for the the IP address, you'll need to have at least 2020R2 installed to start specifying the IP address of MAPDL as you'll need the latest gRPC protocols for communicating with MAPDL.  I suggest upgrading if possible.

Ok,thanks for your reply.I will install new version ansys.👌

Ok,thanks for your reply.I will install new version ansys.ok_hand

And I'll still put a patch out for v17!

Resolved in #384.  ansys-mapdl-core=0.58.4 includes this patch and is live on PyPi ansys-mapdl-core
Upgrade with:
pip install ansys-mapdl-core --upgrade

Please close this issue if the latest version solves the problem.  If not, please let me know.

Yes, I just update my ansys to v211, and it work successfully.Thanks for your help.


LICENCE vs "can be used only pursuant to a non-disclosure agreement"

The LICENCE file (MIT) conflicts with the header in speech.js
// LICENSE // ------- // © 2015 Microsoft. All rights reserved.   // This document is provided “as-is”. Information and views expressed in this document, including URL and other Internet Web site references, may change without notice.   // Some examples depicted herein are provided for illustration only and are fictitious.  No real association or connection is intended or should be inferred.  // This document does not provide you with any legal rights to any intellectual property in any Microsoft product. You may copy and use this document for your internal, reference purposes. This  // document is confidential and proprietary to Microsoft. It is disclosed and can be used only pursuant to a non-disclosure agreement.  //----------------------------------------------------------------------

This issue was moved to Microsoft/Cognitive-Speech-STT-JavaScript#5


UserAccelerometer sensor returns 0 values on some phones

Target Platform: Android
Target OS version/browser: Android 9
Devices: Huawei Mate 9 Pro
I'm currently working on an application detecting phone shakes using UserAccelerometer  TYPE_LINEAR_ACCELERATION on Android), but some phones can only produce events with x:0,y:0,z:0 while accelerometer and gyroscope works. (my testing tool)
After investigating the android native code I'm fairly certain that the issues comes from the OS/device itself rather than the Flutter plugin.
I tried to bypass this issue by using the basic accelerometer with gravity, but it turns out that there's more to it than some basic math (like combining multiple sensor inputs in a specific way).

We're closing this issue because it seems to be a question or request for help rather than a bug in Flutter plugin.
Good places to ask questions or work through problems where you're more likely to get a fast response include:

Stack Overflow
Gitter
Flutter Community Slack

Thanks for using Flutter!


fix randomize

@marcobarilari
Opening this one already so you can follow along and make sure my logic is not out of whack.
Doing it again. This time with CI.

trying to fix the merge conflixt on the submodule. Grrr...


HADOOP-14566. Add seek support for SFTP FileSystem.

Seek method implemented for SFTP File System which supports both forward and backward lazy seeks.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
22m 21s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m 24s
trunk passed

+1 :green_heart:
compile
17m  3s
trunk passed

+1 :green_heart:
checkstyle
0m 53s
trunk passed

+1 :green_heart:
mvnsite
1m 27s
trunk passed

+1 :green_heart:
shadedclient
16m 29s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  7s
trunk passed

+0 :ok:
spotbugs
2m 17s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m 15s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 53s
the patch passed

+1 :green_heart:
compile
16m 56s
the patch passed

+1 :green_heart:
javac
16m 56s
the patch passed

-0 :warning:
checkstyle
0m 49s
hadoop-common-project/hadoop-common: The patch generated 1 new + 19 unchanged - 0 fixed = 20 total (was 19)

+1 :green_heart:
mvnsite
1m 30s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
2m 47s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  3s
the patch passed

-1 :x:
findbugs
2m 15s
hadoop-common-project/hadoop-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

_ Other Tests _

-1 :x:
unit
9m 37s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 53s
The patch does not generate ASF License warnings.

118m 58s

Reason
Tests

FindBugs
module:hadoop-common-project/hadoop-common

Inconsistent synchronization of org.apache.hadoop.fs.sftp.SFTPInputStream.nextPos; locked 72% of time  Unsynchronized access at SFTPInputStream.java:72% of time  Unsynchronized access at SFTPInputStream.java:[line 72]

Failed junit tests
hadoop.io.compress.snappy.TestSnappyCompressorDecompressor

hadoop.fs.contract.localfs.TestLocalFSContractMultipartUploader

hadoop.io.compress.TestCompressorDecompressor

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1999

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux c5d60f4143bd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 35010120fbb

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/1/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/1/artifact/out/new-findbugs-hadoop-common-project_hadoop-common.html

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/1/testReport/

Max. process+thread count
2202 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/1/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m 30s
trunk passed

+1 :green_heart:
compile
17m  5s
trunk passed

+1 :green_heart:
checkstyle
0m 50s
trunk passed

+1 :green_heart:
mvnsite
1m 24s
trunk passed

+1 :green_heart:
shadedclient
17m 20s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  3s
trunk passed

+0 :ok:
spotbugs
2m  9s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m  7s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 49s
the patch passed

+1 :green_heart:
compile
16m 15s
the patch passed

+1 :green_heart:
javac
16m 15s
the patch passed

-0 :warning:
checkstyle
0m 51s
hadoop-common-project/hadoop-common: The patch generated 1 new + 19 unchanged - 0 fixed = 20 total (was 19)

+1 :green_heart:
mvnsite
1m 27s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
13m 53s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  2s
the patch passed

+1 :green_heart:
findbugs
2m 16s
the patch passed

_ Other Tests _

-1 :x:
unit
9m 31s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 54s
The patch does not generate ASF License warnings.

108m 12s

Reason
Tests

Failed junit tests
hadoop.io.compress.snappy.TestSnappyCompressorDecompressor

hadoop.fs.contract.localfs.TestLocalFSContractMultipartUploader

hadoop.io.compress.TestCompressorDecompressor

hadoop.fs.ftp.TestFTPFileSystem

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1999

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 17f3607b64bf 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 99840aaba66

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/2/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/2/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/2/testReport/

Max. process+thread count
2851 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/2/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 10s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 6 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
21m 43s
trunk passed

+1 :green_heart:
compile
17m 50s
trunk passed

+1 :green_heart:
checkstyle
0m 45s
trunk passed

+1 :green_heart:
mvnsite
1m 21s
trunk passed

+1 :green_heart:
shadedclient
17m 30s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 55s
trunk passed

+0 :ok:
spotbugs
2m  8s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m  6s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 50s
the patch passed

+1 :green_heart:
compile
17m  6s
the patch passed

+1 :green_heart:
javac
17m  6s
the patch passed

-0 :warning:
checkstyle
0m 44s
hadoop-common-project/hadoop-common: The patch generated 1 new + 19 unchanged - 0 fixed = 20 total (was 19)

+1 :green_heart:
mvnsite
1m 23s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
15m 25s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 55s
the patch passed

+1 :green_heart:
findbugs
2m 13s
the patch passed

_ Other Tests _

-1 :x:
unit
9m 49s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 45s
The patch does not generate ASF License warnings.

113m 36s

Reason
Tests

Failed junit tests
hadoop.io.compress.TestCompressorDecompressor

hadoop.io.compress.snappy.TestSnappyCompressorDecompressor

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1999

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 15a013c2df32 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 192cad9ee24

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/3/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/3/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/3/testReport/

Max. process+thread count
1346 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/3/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

The PR is ready for review.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
22m  7s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 6 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
18m 50s
trunk passed

+1 :green_heart:
compile
17m 17s
trunk passed

+1 :green_heart:
checkstyle
0m 45s
trunk passed

+1 :green_heart:
mvnsite
1m 23s
trunk passed

+1 :green_heart:
shadedclient
15m 42s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  4s
trunk passed

+0 :ok:
spotbugs
2m  8s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m  7s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 53s
the patch passed

+1 :green_heart:
compile
17m 15s
the patch passed

+1 :green_heart:
javac
17m 15s
the patch passed

-0 :warning:
checkstyle
0m 47s
hadoop-common-project/hadoop-common: The patch generated 1 new + 19 unchanged - 0 fixed = 20 total (was 19)

+1 :green_heart:
mvnsite
1m 37s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  2s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
18m 21s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  8s
the patch passed

+1 :green_heart:
findbugs
2m 57s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
10m 48s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 54s
The patch does not generate ASF License warnings.

135m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1999

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 535da9d2cfdb 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 328eae9a146

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/4/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/4/testReport/

Max. process+thread count
2161 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/4/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
22m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  1s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

-1 :x:
mvninstall
20m 24s
root in trunk failed.

+1 :green_heart:
compile
17m 17s
trunk passed

+1 :green_heart:
checkstyle
0m 52s
trunk passed

+1 :green_heart:
mvnsite
1m 28s
trunk passed

-1 :x:
shadedclient
17m 21s
branch has errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  6s
trunk passed

+0 :ok:
spotbugs
2m 11s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m  9s
trunk passed

-0 :warning:
patch
2m 30s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 48s
the patch passed

+1 :green_heart:
compile
16m 34s
the patch passed

+1 :green_heart:
javac
16m 34s
the patch passed

-0 :warning:
checkstyle
0m 52s
hadoop-common-project/hadoop-common: The patch generated 1 new + 19 unchanged - 0 fixed = 20 total (was 19)

+1 :green_heart:
mvnsite
1m 29s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

-1 :x:
shadedclient
14m 21s
patch has errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  6s
the patch passed

+1 :green_heart:
findbugs
2m 17s
the patch passed

_ Other Tests _

-1 :x:
unit
9m 27s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 54s
The patch does not generate ASF License warnings.

132m 14s

Reason
Tests

Failed junit tests
hadoop.metrics2.source.TestJvmMetrics

hadoop.security.token.delegation.TestZKDelegationTokenSecretManager

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1999

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux f1722534f24a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / ac4a2e11d98

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/5/artifact/out/branch-mvninstall-root.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/5/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

unit
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/5/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/5/testReport/

Max. process+thread count
1595 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/5/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

-1 :x:
mvninstall
10m 20s
root in trunk failed.

-1 :x:
compile
0m 37s
root in trunk failed.

-0 :warning:
checkstyle
0m 25s
The patch fails to run checkstyle in hadoop-common

-1 :x:
mvnsite
0m 26s
hadoop-common in trunk failed.

-1 :x:
shadedclient
2m 15s
branch has errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 28s
hadoop-common in trunk failed.

+0 :ok:
spotbugs
3m 14s
Used deprecated FindBugs config; considering switching to SpotBugs.

-1 :x:
findbugs
0m 29s
hadoop-common in trunk failed.

-0 :warning:
patch
3m 41s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 23s
hadoop-common in the patch failed.

+1 :green_heart:
compile
21m 52s
the patch passed

-1 :x:
javac
21m 52s
root generated 1859 new + 1 unchanged - 0 fixed = 1860 total (was 1)

-0 :warning:
checkstyle
0m 52s
hadoop-common-project/hadoop-common: The patch generated 20 new + 0 unchanged - 0 fixed = 20 total (was 0)

+1 :green_heart:
mvnsite
1m 33s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
15m 40s
patch has no errors when building and testing our client artifacts.

-1 :x:
javadoc
0m 58s
hadoop-common-project_hadoop-common generated 101 new + 0 unchanged - 0 fixed = 101 total (was 0)

+1 :green_heart:
findbugs
2m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 27s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 54s
The patch does not generate ASF License warnings.

72m 18s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1999

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux ee7e96502fa0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / b65815d6914

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/6/artifact/out/branch-mvninstall-root.txt

compile
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/6/artifact/out/branch-compile-root.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/6/artifact/out/buildtool-branch-checkstyle-hadoop-common-project_hadoop-common.txt

mvnsite
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/6/artifact/out/branch-mvnsite-hadoop-common-project_hadoop-common.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/6/artifact/out/branch-javadoc-hadoop-common-project_hadoop-common.txt

findbugs
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/6/artifact/out/branch-findbugs-hadoop-common-project_hadoop-common.txt

mvninstall
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/6/artifact/out/patch-mvninstall-hadoop-common-project_hadoop-common.txt

javac
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/6/artifact/out/diff-compile-javac-root.txt

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/6/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

javadoc
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/6/artifact/out/diff-javadoc-javadoc-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/6/testReport/

Max. process+thread count
2884 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/6/console

versions
git=2.17.1 maven=3.6.0

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
18m 40s
trunk passed

+1 :green_heart:
compile
16m 54s
trunk passed

+1 :green_heart:
checkstyle
0m 51s
trunk passed

+1 :green_heart:
mvnsite
1m 27s
trunk passed

+1 :green_heart:
shadedclient
16m 33s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  3s
trunk passed

+0 :ok:
spotbugs
2m  9s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m  7s
trunk passed

-0 :warning:
patch
2m 28s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 51s
the patch passed

+1 :green_heart:
compile
16m 17s
the patch passed

+1 :green_heart:
javac
16m 17s
the patch passed

-0 :warning:
checkstyle
0m 51s
hadoop-common-project/hadoop-common: The patch generated 1 new + 19 unchanged - 0 fixed = 20 total (was 19)

+1 :green_heart:
mvnsite
1m 26s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
14m  9s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  4s
the patch passed

+1 :green_heart:
findbugs
2m 13s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 34s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 54s
The patch does not generate ASF License warnings.

106m 43s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1999

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 63b7866f1387 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / c84e6beada4

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/7/artifact/out/diff-checkstyle-hadoop-common-project_hadoop-common.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/7/testReport/

Max. process+thread count
1714 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/7/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
18m 42s
trunk passed

+1 :green_heart:
compile
16m 59s
trunk passed

+1 :green_heart:
checkstyle
0m 52s
trunk passed

+1 :green_heart:
mvnsite
1m 25s
trunk passed

+1 :green_heart:
shadedclient
16m 36s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  4s
trunk passed

+0 :ok:
spotbugs
2m  7s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m  4s
trunk passed

-0 :warning:
patch
2m 25s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 51s
the patch passed

+1 :green_heart:
compile
16m 17s
the patch passed

+1 :green_heart:
javac
16m 17s
the patch passed

+1 :green_heart:
checkstyle
0m 51s
the patch passed

+1 :green_heart:
mvnsite
1m 28s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
13m 56s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  2s
the patch passed

+1 :green_heart:
findbugs
2m 14s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 27s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 54s
The patch does not generate ASF License warnings.

106m 27s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1999

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 0aa5cb019133 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 8f78aeb2500

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/8/testReport/

Max. process+thread count
1903 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/8/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@steveloughran , thanks a lot for review. All the issues you pointed out have been fixed. Is there anything else to be done from my side?

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 5 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m 22s
trunk passed

+1 :green_heart:
compile
17m 15s
trunk passed

+1 :green_heart:
checkstyle
0m 53s
trunk passed

+1 :green_heart:
mvnsite
1m 28s
trunk passed

+1 :green_heart:
shadedclient
16m 48s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  5s
trunk passed

+0 :ok:
spotbugs
2m  8s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
2m  6s
trunk passed

-0 :warning:
patch
2m 28s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 49s
the patch passed

+1 :green_heart:
compile
16m 21s
the patch passed

+1 :green_heart:
javac
16m 21s
the patch passed

+1 :green_heart:
checkstyle
0m 51s
hadoop-common-project/hadoop-common: The patch generated 0 new + 18 unchanged - 1 fixed = 18 total (was 19)

+1 :green_heart:
mvnsite
1m 27s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
xml
0m  1s
The patch has no ill-formed XML file.

+1 :green_heart:
shadedclient
13m 50s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
1m  4s
the patch passed

+1 :green_heart:
findbugs
2m 15s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
9m 31s
hadoop-common in the patch passed.

+1 :green_heart:
asflicense
0m 54s
The patch does not generate ASF License warnings.

107m 40s

Subsystem
Report/Notes

Docker
ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1999

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml

uname
Linux 71756c43fcb1 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / aa6d13455b9

Default Java
Private Build-1.8.0_252-8u252-b09-1~18.04-b09

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/9/testReport/

Max. process+thread count
1393 (vs. ulimit of 5500)

modules
C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1999/9/console

versions
git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

+1,  merged to trunk and branch-3.3
thanks!


fix(icon): change line-height to the correct value

Short description of what this resolves:
The icon in menu have an incorrect value to line-height.
Changes proposed in this pull request:

change line-height for all icons in buttons

Ionic Version: 2.x / 3.x
Fixes: #10697

Hello and thank you for contributing to Ionic! We have been working on porting all of the Ionic components to web components and have recently updated master to reflect this. This significant change has caused this pull request to break. While we really appreciate the time and effort you put into creating this, we are not able to merge it because of the newly introduced conflicts. We are extremely sorry about this. We will not be merging any more features in to v3. If this is a feature and you have the time, please resubmit this PR against the master branch. If this is a critical security issue in v3, we would greatly appreciate it if you would resubmit the PR against the new v3 branch. Thanks so much for your time!


Generated signature does not match submitted signature.

If anyone is struggling with this error: Generated signature does not match submitted signature.
You need to make sure your passPhrase is set.
Also that your payload data is in the correct order.
Mine is as follows:

'return_url'
'cancel_url'
'notify_url'
'name_first'
'name_last'
'email_address'
'cell_number'
'm_payment_id'
'amount'
'item_name'

Thanks for the above.
Just to note there are 2 signatures, if you are using Custom or Onsite integrations then the above is correct.
https://developers.payfast.co.za/docs#step_2_signature
If you are using the API, please note the payload order is alphabetical (the SDK does handle the sorting on this)
https://developers.payfast.co.za/api#authentication

I'm getting this error again using a basic payment form. "Generated signature does not match submitted signature"
I'm in production mode.
I'm using R5 to make sure it's not the limit issue.
But if I delete the hidden signature field from the form before submitting it, the offsite link works fine. (Enable Require Signature as Disabled)
If I enable the "Enable Require Signature" setting and leave the hidden signature field in the form, it still doesn't work. Same error.
If I leave out the hidden signature field, it says "Signature is required". Which means if the setting is enabled, that it does indeed look for that.
The signature generated by the SDK seems to be incorrect then.
I also took your custom sample app and put my merchant key and merchant id in and set test to false and it gives the same error.
Any ideas?

I found and logged the issue here: https://github.com/PayFast/payfast-php-sdk/issues/4


ValueError: GpuCorrMM images and kernel must have the same stack size

I'm trying to retrain resnet_50 using my own datasets which is in  following shape:
('X_train: ', (11562L, 200L, 200L, 1L))
('X_valid:', (2891L, 200L, 200L, 1L))
('Y_train:', (11562L, 124L))
('Y_valid:', (2891L, 124L))
Once the model starts to do the training, it throws "GpuCorrMM images and kernel must have the same stack size".  More about the error is:

Train on 11562 samples, validate on 2891 samples
Epoch 1/50
Traceback (most recent call last):
File "resnet_50.py", line 195, in
validation_data=(X_valid, Y_valid))
File "C:\Users\saugat_kc\AppData\Local\Continuum\Anaconda2\envs\resnet_env\lib\site-packages\keras\engine\training.py", line 1196, in fit
initial_epoch=initial_epoch)
File "C:\Users\saugat_kc\AppData\Local\Continuum\Anaconda2\envs\resnet_env\lib\site-packages\keras\engine\training.py", line 891, in _fit_loop
outs = f(ins_batch)
File "C:\Users\saugat_kc\AppData\Local\Continuum\Anaconda2\envs\resnet_env\lib\site-packages\keras\backend\theano_backend.py", line 959, in call
return self.function(*inputs)
File "C:\Users\saugat_kc\AppData\Local\Continuum\Anaconda2\envs\resnet_env\lib\site-packages\theano\compile\function_module.py", line 898, in call
storage_map=getattr(self.fn, 'storage_map', None))
File "C:\Users\saugat_kc\AppData\Local\Continuum\Anaconda2\envs\resnet_env\lib\site-packages\theano\gof\link.py", line 325, in raise_with_op
reraise(exc_type, exc_value, exc_trace)
File "C:\Users\saugat_kc\AppData\Local\Continuum\Anaconda2\envs\resnet_env\lib\site-packages\theano\compile\function_module.py", line 884, in call
self.fn() if output_subset is None else
ValueError: GpuCorrMM images and kernel must have the same stack size

I'm using Python 2.7, Theano 0.9.0 with keras 1.2.2 on a Windows 10 platform.
Is there anything that I'm missing here?

The dimension of your input does not comply with ResNet50. Input to your problem should be of the following dimension:
('X_train: ', (11562L, 3L, 200L, 200L))
('X_valid:', (2891L, 3L, 200L, 200L))
('Y_train:', (11562L, 124L))
('Y_valid:', (2891L, 124L))
The pre-trained CNN inputs must have 3 depth channels (color channels). For Theano, the depth dimension is placed in front of the spatial dimension.


Row detail expand/collapse is not working as expected

The scenario is like this I am calling the expand row function to expand the rows (setting by default) once the component will load by using the ngAfterViewChecked() hook. It is working as per discussed here https://github.com/swimlane/ngx-datatable/issues/1303 But I am facing difficulty to collapse the rows by clicking a single row. The function is calling without any error but the row is not collapsing.
import { ChangeDetectorRef } from '@angular/core';
@ViewChild('myTable') table: any;
constructor(private cdRef:ChangeDetectorRef) {}
ngAfterViewChecked() {
if (this.table && this.table.rowDetail) {
this.table.rowDetail.expandAllRows();
this.cdRef.detectChanges();
}
}
toggleExpandRow(row) {
//function is calling but row is not collapsing
console.log('get row', row);
this.table.rowDetail.toggleExpandRow(row);
}

You may check the demo here https://stackblitz.com/edit/ngx-datatable-row-detail

Hi @Md-Aman
You only need change isCheck  value into ngAfterViewChecked(). How this:
ngAfterViewChecked() {
if (this.table && this.table.rowDetail) {
this.isCheck = true;
// this.table.rowDetail.expandAllRows();
// this.cdRef.detectChanges();
}
}


Add generate_coverage_report.sh and conan profile

I hope this is pretty much self explanatory. First Orbit needs to be built with the included conan profile, which adds the required build arguments. And then the script is used like this: (Assuming its executed from Orbit root directory)
./build.sh coverage_clang9_relwithdebinfo
mkdir build_coverage_clang9_relwithdebinfo/coverage
contrib/unit_test_coverage/generate_coverage_report.sh . build_coverage_clang9_relwithdebinfo build_coverage_clang9_relwithdebinfo/coverage

This creates the coverage report at build_coverage_clang9_relwithdebinfo/coverage/index.html
I am not experienced in bash scripts, so any advice regarding best practices and similar, is appreciated.

I addressed the review commits and also tested results and timing of relwithdebinfo vs debug vs release.
The build times of relwithdebinfo and debug is pretty similar on my machine, release takes longer.
generate_coverage_report.sh execution times are very similar in all three modes. Approx 22seconds.
The coverage report for debug varies slightly to release and reliwithdebinfo. There are some #ifndef NDEBUG and this explains why the debug build contains more lines than release. Strangely debug also contains more Regions than release and I am not sure if that is because of the ifndef.
I left the conan profile based on relwithdebinfo for now.


libtiff patch CVE-2022-3970

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[x] The toolchain has been rebuilt successfully (or no changes were made to it)
[x] The toolchain/worker package manifests are up-to-date
[x] Any updated packages successfully build (or no packages were changed)
[x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[x] All package sources are available
[x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[x] All source files have up-to-date hashes in the *.signatures.json files
[x] sudo make go-tidy-all and sudo make go-test-coverage pass
[x] Documentation has been updated to match any changes to the build system
[x] Ready to merge

Summary

libtiff patch CVE-2022-3970
Change Log

Change
Change
Change

Does this affect the toolchain?

NO
Associated issues

#xxxx

Links to CVEs

https://nvd.nist.gov/vuln/detail/CVE-2022-3970

Test Methodology

Pipeline build id: xxxx

force merge because ""Static glibc version check Expected — Waiting for status to be reported" is stuck here forever and this change has nothing to do with that


sink: remove useless error check

What problem does this PR solve?

Issue Number: ref #4623
What is changed and how it works?
#4609 removed error returned from encoderBuilder.Build(), so remove useless error check.
Check List
Tests

Unit test
Integration test

Release note
None

/merge


Encapsulate EmbeddedSingleNodeKafkaCluster in a seperately-available maven/gradle/sbt dep

As discussed in this thread https://groups.google.com/forum/#!topic/confluent-platform/_pJ1g9g1woY
It would be great if I could just include EmbeddedSingleNodeKafkaCluster and it's deps in test scope to easily run integration tests.  It seems like right now there is a lot of cut & paste programming happening out there.

This is a really big deficiency for our team. Not having an artifact to make testing easier seems like a big deal to me.
Is the current acceptable use to copy and paste?

We are indeed working on getting a core-test-utils artifact which will include some mocked broker module for users to write integration tests easier. That is on our ongoing roadmap.
For now please bare with us and use the copy-paste approach.

Is there a JIRA to watch for this? I notice that at least connect and streams have the a similar EmbeddedKafkaBroker class in their unit tests.

There is

https://issues.apache.org/jira/browse/KAFKA-5041
https://issues.apache.org/jira/browse/KAFKA-7852

Thanks!
In the meantime, we've been using a combination of the testcontainers or junit-kafka projects

We have made some progress on our side. We are looking into making an open source version of this but honestly we'd prefer to provide the code that we have done and have confluent maintain it.

The embedded cluster would be mantained in the Apache Kafka repo, not just by Confluent.

Any progress on this issue?

Hi all, until there is an agreement on who will maintain these three classes - this issue dates from 2017... - you can use this modernized fork and ask/request me when something is broken or incomplete.

It might be worth giving a try to these:

embedded-kafka
kafka-junit

Since trying out Testcontainers 6 months back I see no need for this. Unsubscribing.

This seems to be an Apache Kafka issue, and there are corresponding tickets. Please follow up on the Kafka tickets.


dind-cluster-stable.sh is not working locally

⇒  ./dind-cluster-stable.sh up
* Making sure DIND image is up to date
stable: Pulling from mirantis/kubeadm-dind-cluster
Digest: sha256:c549b1a82f49d11cf83c16f952613de7630bd59806391090d80e02c646215a16
Status: Image is up to date for mirantis/kubeadm-dind-cluster:stable
* Saving a copy of docker host's /lib/modules
* Starting DIND container: kube-master
* Running kubeadm: init --config /etc/kubeadm.conf --skip-preflight-checks
Initializing machine ID from random generator.
Synchronizing state of docker.service with SysV init with /lib/systemd/systemd-sysv-install...
Executing /lib/systemd/systemd-sysv-install enable docker
Loaded image: gcr.io/google_containers/kube-discovery-amd64:1.0
Loaded image: gcr.io/google_containers/kubedns-amd64:1.7
Loaded image: gcr.io/google_containers/exechealthz-amd64:1.1
Loaded image: gcr.io/google_containers/kube-dnsmasq-amd64:1.3
Loaded image: gcr.io/google_containers/pause-amd64:3.0
Loaded image: gcr.io/google_containers/etcd-amd64:2.2.5
Loaded image: gcr.io/google_containers/etcd-amd64:3.0.17
Loaded image: gcr.io/google_containers/etcd:2.2.1
Loaded image: mirantis/hypokube:base

real	0m15.673s
user	0m0.610s
sys	0m0.830s
Sending build context to Docker daemon 266.4 MB
Step 1 : FROM mirantis/hypokube:base
 ---> d3121339ee59
Step 2 : COPY hyperkube /hyperkube
 ---> de536b051cc6
Removing intermediate container cac8e6555847
Successfully built de536b051cc6
Created symlink from /etc/systemd/system/multi-user.target.wants/kubelet.service to /lib/systemd/system/kubelet.service.
Flag --skip-preflight-checks has been deprecated, it is now equivalent to --ignore-preflight-errors=all
[init] Using Kubernetes version: v1.9.0
[init] Using Authorization modes: [Node RBAC]
[preflight] Running pre-flight checks.
	[WARNING KubeletVersion]: the kubelet version is higher than the control plane version. This is not a supported version skew and may lead to a malfunctional cluster. Kubelet version: "1.10.0" Control plane version: "1.9.0"
	[WARNING FileContent--proc-sys-net-bridge-bridge-nf-call-iptables]: /proc/sys/net/bridge/bridge-nf-call-iptables does not exist
	[WARNING Swap]: running with swap on is not supported. Please disable swap
	[WARNING FileExisting-crictl]: crictl not found in system path
Suggestion: go get github.com/kubernetes-incubator/cri-tools/cmd/crictl
Flag --insecure-bind-address has been deprecated, This flag will be removed in a future version.
Flag --insecure-port has been deprecated, This flag will be removed in a future version.
[certificates] Generated ca certificate and key.
[certificates] Generated apiserver certificate and key.
[certificates] apiserver serving cert is signed for DNS names [kube-master kubernetes kubernetes.default kubernetes.default.svc kubernetes.default.svc.cluster.local] and IPs [<IP_ADDRESS> <IP_ADDRESS>]
[certificates] Generated apiserver-kubelet-client certificate and key.
[certificates] Generated etcd/ca certificate and key.
[certificates] Generated etcd/server certificate and key.
[certificates] etcd/server serving cert is signed for DNS names [localhost] and IPs [<IP_ADDRESS>]
[certificates] Generated etcd/peer certificate and key.
[certificates] etcd/peer serving cert is signed for DNS names [kube-master] and IPs [<IP_ADDRESS>]
[certificates] Generated etcd/healthcheck-client certificate and key.
[certificates] Generated apiserver-etcd-client certificate and key.
[certificates] Generated sa key and public key.
[certificates] Generated front-proxy-ca certificate and key.
[certificates] Generated front-proxy-client certificate and key.
[certificates] Valid certificates and keys now exist in "/etc/kubernetes/pki"
[kubeconfig] Wrote KubeConfig file to disk: "/etc/kubernetes/admin.conf"
[kubeconfig] Wrote KubeConfig file to disk: "/etc/kubernetes/kubelet.conf"
[kubeconfig] Wrote KubeConfig file to disk: "/etc/kubernetes/controller-manager.conf"
[kubeconfig] Wrote KubeConfig file to disk: "/etc/kubernetes/scheduler.conf"
[controlplane] Wrote Static Pod manifest for component kube-apiserver to "/etc/kubernetes/manifests/kube-apiserver.yaml"
[controlplane] Wrote Static Pod manifest for component kube-controller-manager to "/etc/kubernetes/manifests/kube-controller-manager.yaml"
[controlplane] Wrote Static Pod manifest for component kube-scheduler to "/etc/kubernetes/manifests/kube-scheduler.yaml"
[etcd] Wrote Static Pod manifest for a local etcd instance to "/etc/kubernetes/manifests/etcd.yaml"
[init] Waiting for the kubelet to boot up the control plane as Static Pods from directory "/etc/kubernetes/manifests".
[init] This might take a minute or longer if the control plane images have to be pulled.
[kubelet-check] It seems like the kubelet isn't running or healthy.
[kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:10255/healthz' failed with error: Get http://localhost:10255/healthz: dial tcp <IP_ADDRESS>:10255: getsockopt: connection refused.
[kubelet-check] It seems like the kubelet isn't running or healthy.
[kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:10255/healthz' failed with error: Get http://localhost:10255/healthz: dial tcp <IP_ADDRESS>:10255: getsockopt: connection refused.
[kubelet-check] It seems like the kubelet isn't running or healthy.
[kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:10255/healthz' failed with error: Get http://localhost:10255/healthz: dial tcp <IP_ADDRESS>:10255: getsockopt: connection refused.
[kubelet-check] It seems like the kubelet isn't running or healthy.
[kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:10255/healthz/syncloop' failed with error: Get http://localhost:10255/healthz/syncloop: dial tcp <IP_ADDRESS>:10255: getsockopt: connection refused.
[kubelet-check] It seems like the kubelet isn't running or healthy.
[kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:10255/healthz/syncloop' failed with error: Get http://localhost:10255/healthz/syncloop: dial tcp <IP_ADDRESS>:10255: getsockopt: connection refused.
[kubelet-check] It seems like the kubelet isn't running or healthy.
[kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:10255/healthz/syncloop' failed with error: Get http://localhost:10255/healthz/syncloop: dial tcp <IP_ADDRESS>:10255: getsockopt: connection refused.
[kubelet-check] It seems like the kubelet isn't running or healthy.
[kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:10255/healthz' failed with error: Get http://localhost:10255/healthz: dial tcp <IP_ADDRESS>:10255: getsockopt: connection refused.
[kubelet-check] It seems like the kubelet isn't running or healthy.
[kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:10255/healthz/syncloop' failed with error: Get http://localhost:10255/healthz/syncloop: dial tcp <IP_ADDRESS>:10255: getsockopt: connection refused.
[kubelet-check] It seems like the kubelet isn't running or healthy.
[kubelet-check] The HTTP call equal to 'curl -sSL http://localhost:10255/healthz' failed with error: Get http://localhost:10255/healthz: dial tcp <IP_ADDRESS>:10255: getsockopt: connection refused.

Unfortunately, an error has occurred:
	timed out waiting for the condition

This error is likely caused by:
	- The kubelet is not running
	- The kubelet is unhealthy due to a misconfiguration of the node in some way (required cgroups disabled)
	- Either there is no internet connection, or imagePullPolicy is set to "Never",
	  so the kubelet cannot pull or find the following control plane images:
		- mirantis/hypokube:final
		- mirantis/hypokube:final
		- mirantis/hypokube:final
		- k8s.gcr.io/etcd-amd64:3.1.12 (only if no external etcd endpoints are configured)

If you are on a systemd-powered system, you can try to troubleshoot the error with the following commands:
	- 'systemctl status kubelet'
	- 'journalctl -xeu kubelet'
couldn't initialize a Kubernetes cluster

OS: Mac OSX

I'll be updating stable branch shortly, it broke after moving the repo. Sorry for the inconvenience.

@ivan4th, Thanks for picking it up to fix. Is this fix in progress because I'm not able to launch cluster too. REF: https://github.com/kubernetes-sigs/kubeadm-dind-cluster/issues/118#issuecomment-401803324

/close


Submission item/bitstream access conditions fixes

References

Fixes #1696
Fixes #1697

Instructions for Reviewers
follow instructions in the issues and check they are fixed
Checklist

[x] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
[x] My PR passes TSLint validation using yarn run lint
[x] My PR doesn't introduce circular dependencies
[x] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
[x] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
[x] If my PR includes new, third-party dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.

@tdonohue
i found out it happened when the access condition was already selected. I that case the max start date wasn't set properly.
Now it should be fixed, you could not be able to select a date bigger than the limit now.
Anyway I agree the rest server should handle the invalid date case properly, so I've opened a new issue that could be address in 7.4 https://github.com/DSpace/DSpace/issues/8371


Home Page for CircuitVerse

Describe the changes you have made in this PR -
Created a template for Home Page

Coverage remained the same at 82.507% when pulling b52f141f2aa33910630381c6819494ec38ebd786 on ShreyaPrasad1209:UX/UI into a8847356a4a92dc6a86df4ce95d6dd3bf1fe0c82 on CircuitVerse:stories/new_ux.

Can you please rebase, I made some changes in the branch

Why did you close the PR?

Too many changes due to branch conflict, could not review

Feel free to reopen once it is resolved


[Dynamic Regions] AVAILABLE is always 0 when query information_schema.tiflash_replica after br restore tiflash data with 2 replicas

Bug Report
Please answer these questions before submitting your issue. Thanks!
1. Minimal reproduce step (Required)
1、/br restore db --send-credentials-to-tikv=true --db tpcc --pd http://tc-pd.endless-ha-test-htap-tps-2880160-1-720:2379/ --storage s3://nfs/tiflash/ch-2k-flash2-collation --s3.endpoint http://minio.pingcap.net:9000/ --check-requirements=false
2、select * from information_schema.tiflash_replica
[{"AVAILABLE":"0","LOCATION_LABELS":"","PROGRESS":"0","REPLICA_COUNT":"2","TABLE_ID":"2759","TABLE_NAME":"supplier","TABLE_SCHEMA":"tpcc"},{"AVAILABLE":"0","LOCATION_LABELS":"","PROGRESS":"0","REPLICA_COUNT":"2","TABLE_ID":"2725","TABLE_NAME":"warehouse","TABLE_SCHEMA":"tpcc"},{"AVAILABLE":"0","LOCATION_LABELS":"","PROGRESS":"0","REPLICA_COUNT":"2","TABLE_ID":"2735","TABLE_NAME":"orders","TABLE_SCHEMA":"tpcc"},{"AVAILABLE":"0","LOCATION_LABELS":"","PROGRESS":"0","REPLICA_COUNT":"2","TABLE_ID":"2727","TABLE_NAME":"district","TABLE_SCHEMA":"tpcc"},{"AVAILABLE":"0","LOCATION_LABELS":"","PROGRESS":"0","REPLICA_COUNT":"2","TABLE_ID":"2737","TABLE_NAME":"order_line","TABLE_SCHEMA":"tpcc"},{"AVAILABLE":"0","LOCATION_LABELS":"","PROGRESS":"0","REPLICA_COUNT":"2","TABLE_ID":"2729","TABLE_NAME":"customer","TABLE_SCHEMA":"tpcc"},{"AVAILABLE":"0","LOCATION_LABELS":"","PROGRESS":"0","REPLICA_COUNT":"2","TABLE_ID":"2731","TABLE_NAME":"history","TABLE_SCHEMA":"tpcc"},{"AVAILABLE":"0","LOCATION_LABELS":"","PROGRESS":"0","REPLICA_COUNT":"2","TABLE_ID":"2755","TABLE_NAME":"nation","TABLE_SCHEMA":"tpcc"},{"AVAILABLE":"0","LOCATION_LABELS":"","PROGRESS":"0","REPLICA_COUNT":"2","TABLE_ID":"2739","TABLE_NAME":"stock","TABLE_SCHEMA":"tpcc"},{"AVAILABLE":"0","LOCATION_LABELS":"","PROGRESS":"0","REPLICA_COUNT":"2","TABLE_ID":"2741","TABLE_NAME":"item","TABLE_SCHEMA":"tpcc"},{"AVAILABLE":"0","LOCATION_LABELS":"","PROGRESS":"0","REPLICA_COUNT":"2","TABLE_ID":"2733","TABLE_NAME":"new_order","TABLE_SCHEMA":"tpcc"},{"AVAILABLE":"0","LOCATION_LABELS":"","PROGRESS":"0","REPLICA_COUNT":"2","TABLE_ID":"2757","TABLE_NAME":"region","TABLE_SCHEMA":"tpcc"}]"]
2. What did you expect to see? (Required
AVAILABLE is 1 after br restore tiflash data with 2 replicas
3. What did you see instead (Required)
AVAILABLE is always 0 when query information_schema.tiflash_replica after br restore tiflash data with 2 replicas
4. What is your TiFlash version? (Required)
git hash：6918946196d8bdb4fc32ebf535b8765f4ed05658

/severity critical
/assign CalvinNeo

Close as the "Dynamic Region" aka "Partitioned Raft KV" has been stopped for a long time


Added support for wildcard/subrouter when using regexp pattern

With this modification you can use regexp in parent routes. (Notice lack of $ at end of regexp)
sub := web.New()
sub.Use(middleware.SubRouter)
sub.Get("/get", func(c web.C, w http.ResponseWriter, req *http.Request) {
	fmt.Fprintf(w, "Info for IP address: %s", c.URLParams["ip"])
})
mux.Handle(regexp.MustCompile(`^/ip/(?P<ip>(?:\d{1,3}\.){3}\d{1,3})/info`), sub)

I pushed a fix for this. It's not exactly what you had in mind, but suffixing any regular expression route with (?P<_>/.*)$ will have the same effect as /* in string routes. Let me know if this doesn't address your problems!


ENH: Add Linux aarch64, ppc64le and macOS arm64 builds

Enable builds for platforms: linux_aarch64, linux_ppc64le, osx_arm64.
Bump build number.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[N/A] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

@conda-forge-admin, please rerender


fix: replicas should do expose blindly during rebuilding; server should not create orphan replicas for rebuilding lvols

Which issue(s) this PR fixes:

Issue
longhorn/longhorn#7199
longhorn/longhorn#9121
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context

The "Invalid argument" issue stills exists.
FAIL: spdk_test.go:397: TestSuite.TestSPDKMultipleThreadSnapshotOpsAndRebuilding

spdk_test.go:1208:
    c.Assert(rebuildingStatus.Error, Equals, "")
... obtained string = "Invalid argument"
... expected string = ""

Weird. It's hard to trigger any errors in my private env, especially running test TestSPDKMultipleThreadSnapshotOpsAndRebuilding only


Polymer README's instructions don't match current version

 Issue by sethladd
Originally opened as dart-lang/sdk#20288

Current polymer version: 0.12.0+1
Instructions in README:
dependencies:
  polymer: ">=0.11.0 <0.12.0"

Probably should be ">=0.12.0 < 0.13.0" ?

 Comment by sethladd

https://codereview.chromium.org/435743004/

Added Fixed label.

 Comment by sethladd

Set owner to @sethladd.
Added Accepted label.


OPS-1675

@rhenry-reify after exploring some other plugins that were designed to create releases, I ran into challenge pairing it with this plugin, it ended up being easier to modify this plugin instead.
I added a feature flag, and kept the default action to not create a release. Otherwise, these two things need to be set.
https://github.com/reifyhealth/git-tag-test/blob/main/.github/workflows/tf-module.yml#L18
as well as a release template
https://github.com/reifyhealth/git-tag-test/blob/main/.github/release.yml
which creates
https://github.com/reifyhealth/git-tag-test/releases/tag/1.18.0

Will modify to a global release notes file in future release if need. As of now, users can use custom release notes file, unique to their app


luci-app-babeld: Hello-Reach is represented as a decimal number.

Steps to reproduce:

go to: Status → Babeld tab
look at the status

Actual behavior:
Hello-Reach is represented as a hexadecimal number or with checkboxes.
Additional Information:
I also asked on the Babel Mailling list if this representation makes sense: https://alioth-lists.debian.net/pipermail/babel-users/2023-April/004081.html
OpenWrt version information from system /etc/openwrt_release
DISTRIB_ID='OpenWrt'
DISTRIB_RELEASE='22.03.3'
DISTRIB_REVISION='r20028-43d71ad93e'
DISTRIB_TARGET='ramips/mt76x8'
DISTRIB_ARCH='mipsel_24kc'
DISTRIB_DESCRIPTION='OpenWrt 22.03.3 r20028-43d71ad93e'
DISTRIB_TAINTS=''

Ping on maintainers: @JonnyTischbein @PolynomialDivision @aparcar
(I am sorry if I am pinging you and you are not the maintainers, however there is nothing in the files about this and you are in the commit history).

Can't find any formatting logic in the LuCI app, it outputs the data as received from ubus:
https://github.com/openwrt/luci/blob/master/applications/luci-app-babeld/root/www/luci-static/resources/babeld.js#L145
The ubus emitter does no decimal formatting either:
https://github.com/openwrt/routing/blob/master/babeld/src/ubus.c#L355
Can you append a screenshot?


Support for Kotlin

Are there any plans for adding support for Kotlin with JVM to J2Objc?

There are no official plans, nor are there likely to be going forward. We have a half-finished experiment to directly translate JVM classfiles, which may not pan out since classfile translations have to be equivalent to source translations. If successful, though, in theory the Kotlin JVM runtime could be translated to support Kotlin projects.
However, there are other potential obstacles to consider:

What JRE dependencies does the Kotlin JVM runtime have, and are any not supported on iOS?
REPL may require classfile hotloading (don't know), and there's no JVM on iOS.
What IDE and/or build system support is expected? Xcode doesn't support plug-ins.
Developers won't want to compile Kotlin to classfiles, then translate to Objective C, and then compile to .o files. It's too slow and cumbersome for active project use.

JetBrains has AppCode, an IDE for iOS development that supports Swift, Objective C and C++. In my opinion, that team is in a better position to support Kotlin on iOS, for several reasons:

They created Kotlin, and so understand it better than anyone else.
If Kotlin needs any extensions to support iOS, their team can get it done much easier than someone outside their company.
There is probably code they can share between IntelliJ and AppCode.
They would be single contact for any support issues.

@tomball Thank you for the explanation! I totally agree with your arguments.

We’ve been thinking about this for a while. It will be complicated by
kotlin native. I just went to kotlinconf and am speaking about this at
Droidcon sf in 2 hours, so it’s fresh on the mind :)
They’re moving pretty fast on kotlin native, but it’ll be a year (guessing)
before it’s stable and productive enough to use in a product. Outside of
that, there won’t be a Java runtime, so there’s lots of kotlin library work.
We’re experimenting with kotlin native calling into j2objc. Technically
work, but could use some smoothing
https://medium.com/@kpgalligan/droidcon-nyc-on-ios-with-kotlin-native-5a6a2749057e?source=linkShare-c2f810aa7890-1509984925
On Mon, Nov 6, 2017 at 7:58 AM Samuel Urbanowicz<EMAIL_ADDRESS>wrote:

@tomball https://github.com/tomball Thank you for the explanation! I
totally agree with your arguments.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/google/j2objc/issues/903#issuecomment-342193368, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAELIKdyAGgyVk3I6-zqg0GGITtJtecfks5szyybgaJpZM4QS7tB
.

--
Kevin Galligan
https://twitter.com/kpgalligan

@kpgalligan Nice experiment, thanks for the link 👍


grails-geocode behind a proxy

Hi there,
Is there any easy way to set a proxy for grails-geocode? It looks like now proxy is not handled by plugin:
 private initializeBuilder() {

        if (grailsApplication.config.geocode?.useHttp) {
            httpBuilder = new HTTPBuilder('http://maps.googleapis.com')
        }
    }

The solution I see is to add the following line:
http.setProxy('proxy.com', 8080, 'http')
Any help?
Thanks

Setting the HTTP proxy using system properties should work. If it doesn't please reopen this issue.
http://docs.oracle.com/javase/6/docs/technotes/guides/net/proxies.html


[Feature Request] REST API support ?

for example i want to communicate a web app with k3x using rest api

Thanks for the suggestion, but I don't think I will add a REST interface in the near future. In fact, I think that kind of functionality would be better served by some daemon that could run k3d as a subprocess, but not by a graphical interface like k3x.


Ability to decorate default CallFactory

Currently, the builder method CDAClient.builder() setCallFactory makes it hard to augment the default Call.Factory
A valid use case for us is to decorate the current CallFactory, and add a caching layer, or, for a nice dev cycle, store the results of queries so we can develop in 'fake contentful' mode.
Currently, the only way to do this is to fork the following Call.Factory setup, that is, we have copied the following lines into our codebase
OkHttpClient.Builder okBuilder = new OkHttpClient.Builder()
          .addInterceptor(new AuthorizationHeaderInterceptor(clientBuilder.token))
          .addInterceptor(new UserAgentHeaderInterceptor(createUserAgent()))
          .addInterceptor(new ErrorInterceptor());

This isn't ideal, as we now have to make sure our fork is in-sync with upstream. Could we please expose the default Call.Factory in the library?

Hello,
that sounds like a great idea. I will take a look into a solution there, and report back soon ...
Thanks for the suggestion.
Mario

Nice @mariobodemann thanks for this


Update Dockerfile to Rust 1.79

This should fix failing tests.

What tests were failing?

What tests were failing?

https://github.com/svix/svix-webhooks/actions/runs/11170028978/job/31052011454


Ocean Monument is missing from list

would love to search for ocean monuments/ check how they compare with mods or datapacks loaded!

Duplicate of #10
I'm sorry, but ocean monuments are unfortunately one of the vanilla structures that have rather complicated placement code. Given this map is mostly about datapack maps, and most custom structures use jigsaw, ocean monuments are unfortunately too much effort to implement.

no worries! I thought that might be the case haha


XFA - Fix the way to select page on breaking

it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1716838.
some fonts in the pdf in the bug where bold when they shouldn't so write the font properties in the html to avoid to use some wrong inherited ones.

/botio test

Looks like there's regressions on imm1344e and imm1295e.

/botio test

The diffs on imm1344e and imm1295e are expected: the first pageArea has a max set to 1 so the other pageArea must be used for other pages.

The diffs on imm1344e and imm1295e are expected: the first pageArea has a max set to 1 so the other pageArea must be used for other pages.

In page 2 and 4 of imm1295e there seems to be a regression. The header and footer of page 2 and page 4 should be like on page 5.

There are some diff with xfa_bug1716816.pdf but it seems that this pdf is wrongly displayed (even before the patch).
I'll fix this pdf later.

/botio makeref

Sorry, but why was this landed with a bunch of breaking error (which is also why makeref failed) such as e.g. the following in multiple tests!?
TEST-UNEXPECTED-FAIL | test failed xfa_candidate_petitions | in chrome | page1 round 1 | Loading PDF document: UnknownErrorException: Cannot read property 'length' of undefined

This should probably be backed out, and then re-landed once fixed, to prevent testing being completely busted in the meantime!
(I'd suggest looking at not just the reference images, but also the actual test output when e.g. reviewing :-P)

(I'd suggest looking at not just the reference images, but also at the actual test output when e.g. reviewing :-P)
It's the reason why I missed the failures... sorry for that.

Since it's currently way too easy to accidentally overlook breaking errors in the test-output, we might want to include more information directly in the botio output; in case it's deemed helpful, I've just submitted https://github.com/mozilla/botio-files-pdfjs/pull/30

Since it's currently way too easy to accidentally overlook breaking errors in the test-output, we might want to include more information directly in the botio output

Totally agree!


Standardize the response message physique in Board

In GitLab by @liyanq528 on Dec 26, 2018, 10:39

In GitLab by @yhua123 on Nov 8, 2019, 08:02
formal message style: [code]:[context]

In GitLab by @sokril on Nov 8, 2019, 08:30
assigned to @wknet123


Calendar days not displaying when Calendar is in RecyclerViews, but title shows up.

I'm adding the calendar as an item in a recycler view. The header shows up correctly (with < Month > ), but none of the dates below appear.
For some reason, when I turn off the screen and turn it back on, the dates show up correctly. Has anyone else run into this? I'm not sure if I'm doing something wrong, but it is very peculiar to me that the header shows up and the dates don't.

@caltseng Works for us in recyclerViews with last version. Feel free to reopen if you still see this issue


Show comments

In this milestone, I have worked on the following things:

Load comments from the API of the respective id.
Display the comments on pop-up window.

Status: ✔ Project Approved ✔
Hi @Sajeelzafar ,
Everything is looking great! Please, merge this branch :shipit:
Congratulations! 🎉


New feature: Github source code repos permissions check

Overview
Provide a check to control the access to Github repositories containing source code. Permission access should be done at the team level, and not by adding single collaborators outside of team membership.
This can be done through a check that alerts if there are single collaborators instead of teams and also alerts about forks of the source code repos.
Requirements

Based on the evidence collected by the existing fetcher here

For each Github repo containing source code :

check that all the collaborators are defined as teams and no single collaborator outside of a Github team are added to the list.
alert if any of the collaborators is detected to be a single user instead of a team.
check if there are forks of the source code repos
alert if there are forks of the source code repos

Approach
Implement a permissions check which includes a report template to render the results.
Each single collaborator found in a repo will be considered a failure and reported with the following information grouped by repository:

GitHub User
A flag indicating if the single collaborator is an organization member

The permissions check reports on each fork found in a repo. Each fork found in a repo will be considered as a warning and reported with the following information grouped by repository:

Fork URL

As additional information the permissions check also lists the organization teams as successes.
Security and Privacy
N/A
Test Plan
TBD

Seems like this can be closed now.


Cannot find module 'FAKIconImage'

I'm getting the following error after following the 6 steps in the readme getting started.

The project builds fine, it just breaks on this require in my app when it runs.
Icon  = require('FAKIconImage')

I'm using react-native-webpack-server so wondering whether the issue may be related to that.
Any help would be much appreciated!

It could be related to #61

I'm hoping to fix a bunch of these issues and upgrade for the latest version of RN today / tomorrow.
On Mon, Jul 6, 2015 at 9:57 AM, Ali Najafizadeh<EMAIL_ADDRESS>wrote:

It could be related to #61
Reply to this email directly or view it on GitHub:
https://github.com/corymsmith/react-native-icons/issues/63#issuecomment-118908593

@corymsmith are you aware of this issue https://github.com/facebook/react-native/issues/1808. if you need help I can provide a pull request for that.

@alinz, @corymsmith - see also https://github.com/corymsmith/react-native-icons/issues/59

@mnylen @alinz @stephenhandley Just published version 0.2.0 to NPM, you'll have to change the require to be require ("react-native-icons").Icon