k3s exited with: exit status 1

Sorry but when I use:
docker run -d --restart=unless-stopped \
  -p 80:80 -p 443:443 \
  rancher/rancher:latest

to install rancher.
It have some error in docker log:
FATA[2020-05-08T09:22:45.752074152Z] apiserver exited: Unable to find suitable network address.error='no default routes found in "/proc/net/route" or "/proc/net/ipv6_route"'. Try to set the AdvertiseAddress directly or provide a valid BindAddress to fix this.
2020/05/08 09:22:45 [FATAL] k3s exited with: exit status 1

I don't know what happened, and I wonder if anyone here could help me. Thank you.

I am not sure why rancher install k3s, I don't want to use k3s, is there any idea I can skip the k3s install. I only want rancher to manage my k8s cluster.

maybe the issue to: #26574

The error is identical to https://github.com/rancher/rancher/issues/14840, can you check in that issue and provide the outputs requested?

@superseb Thank you but I have not the same issue with #14840,
I run the docker run command and it have
f0ad82177745        rancher/rancher:v2.4.2                                                               "entrypoint.sh"          About an hour ago   Restarting (1) 48 seconds ago                       rancher

and I can not go into the webadmin page.

I am not sure why I should install the k3s, is k3s part of rancher? I am no sure what information do you need? I think I can not get more helpful information from the docker logs.

The information requested in https://github.com/rancher/rancher/issues/14840#issuecomment-408805372

root@VM-0-2-ubuntu:~# ip a s
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP group default qlen 1000
    link/ether 52:54:00:4c:ee:9c brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/20 brd <IP_ADDRESS> scope global eth0
       valid_lft forever preferred_lft forever
    inet6 fe80::5054:ff:fe4c:ee9c/64 scope link
       valid_lft forever preferred_lft forever
3: docker0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN group default
    link/ether 02:42:50:6f:86:2e brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/28 brd <IP_ADDRESS> scope global docker0
       valid_lft forever preferred_lft forever
    inet6 fe80::42:50ff:fe6f:862e/64 scope link
       valid_lft forever preferred_lft forever
4: cbr0: <BROADCAST,MULTICAST,PROMISC,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default qlen 1000
    link/ether 7e:f3:c0:95:da:a9 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/26 scope global cbr0
       valid_lft forever preferred_lft forever
    inet6 fe80::7cf3:c0ff:fe95:daa9/64 scope link
       valid_lft forever preferred_lft forever
5: vetha40501a1@if3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue master cbr0 state UP group default
    link/ether d2:64:8c:d8:6f:e0 brd ff:ff:ff:ff:ff:ff link-netnsid 0
    inet6 fe80::d064:8cff:fed8:6fe0/64 scope link
       valid_lft forever preferred_lft forever
6: veth3d4fcf62@if3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue master cbr0 state UP group default
    link/ether 66:54:35:d9:48:a8 brd ff:ff:ff:ff:ff:ff link-netnsid 1
    inet6 fe80::6454:35ff:fed9:48a8/64 scope link
       valid_lft forever preferred_lft forever
root@VM-0-2-ubuntu:~# ip route
default via <IP_ADDRESS> dev eth0 proto dhcp metric 100
<IP_ADDRESS>/28 dev docker0 proto kernel scope link src <IP_ADDRESS> linkdown
<IP_ADDRESS>/26 dev cbr0 proto kernel scope link src <IP_ADDRESS>
<IP_ADDRESS>/20 dev eth0 proto kernel scope link src <IP_ADDRESS>
root@VM-0-2-ubuntu:~# ip r get <IP_ADDRESS>
<IP_ADDRESS> via <IP_ADDRESS> dev eth0 src <IP_ADDRESS> uid 0
    cache
root@VM-0-2-ubuntu:~# ping -c 5 <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=53 time=41.7 ms
64 bytes from <IP_ADDRESS>: icmp_seq=2 ttl=53 time=41.7 ms
64 bytes from <IP_ADDRESS>: icmp_seq=3 ttl=53 time=41.7 ms
64 bytes from <IP_ADDRESS>: icmp_seq=4 ttl=53 time=41.7 ms

@superseb I see that the docker0 bridge has a subnet of <IP_ADDRESS>/28, which is triggering Kubernetes's logic of rejecting the ip because it is a link local address. Is that accurate?
@zehuaiWANG how critical is it for you that your docker bridge be configured with <IP_ADDRESS>/28? The default is <IP_ADDRESS>/16, so I'm also curious how you decided to configure it with <IP_ADDRESS>/28`. Is that a corporate policy?

Yeah wanted to reproduce it to be sure, I guess running the container with --net=host would also confirm that (just for testing). Or temporarily changing the Docker subnet to private network range.

@cjellick YES, but I use the Tencent Cloud, I think maybe it's the policy of tencent cloud. What confuses me is that rancher needs a k3s when it starts, which needs network support. I won't encounter this problem in previous versions. I wonder if k3s is necessary in the installation of rancher? Is there any way for me to skip the k3s installation, because I only need a rancher to manage my kubernetes, not k3s.
@superseb
It still not work.
root@VM-0-2-ubuntu:~# docker run -d --restart=unless-stopped --net=host -p 80:80 -p 443:443 rancher/rancher
WARNING: Published ports are discarded when using host network mode
d437dccbf998ad9d6292a87cec7d46b9b2fd5dfa88e8783aff13b53691300a5c
root@VM-0-2-ubuntu:~# ip a s
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN group default qlen 1000
    link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
    inet <IP_ADDRESS>/8 scope host lo
       valid_lft forever preferred_lft forever
    inet6 ::1/128 scope host
       valid_lft forever preferred_lft forever
2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP group default qlen 1000
    link/ether 52:54:00:4c:ee:9c brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/20 brd <IP_ADDRESS> scope global eth0
       valid_lft forever preferred_lft forever
    inet6 fe80::5054:ff:fe4c:ee9c/64 scope link
       valid_lft forever preferred_lft forever
3: docker0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state DOWN group default
    link/ether 02:42:50:6f:86:2e brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/28 brd <IP_ADDRESS> scope global docker0
       valid_lft forever preferred_lft forever
    inet6 fe80::42:50ff:fe6f:862e/64 scope link
       valid_lft forever preferred_lft forever
4: cbr0: <BROADCAST,MULTICAST,PROMISC,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default qlen 1000
    link/ether 7e:f3:c0:95:da:a9 brd ff:ff:ff:ff:ff:ff
    inet <IP_ADDRESS>/26 scope global cbr0
       valid_lft forever preferred_lft forever
    inet6 fe80::7cf3:c0ff:fe95:daa9/64 scope link
       valid_lft forever preferred_lft forever
5: vetha40501a1@if3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue master cbr0 state UP group default
    link/ether d2:64:8c:d8:6f:e0 brd ff:ff:ff:ff:ff:ff link-netnsid 0
    inet6 fe80::d064:8cff:fed8:6fe0/64 scope link
       valid_lft forever preferred_lft forever
6: veth3d4fcf62@if3: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue master cbr0 state UP group default
    link/ether 66:54:35:d9:48:a8 brd ff:ff:ff:ff:ff:ff link-netnsid 1
    inet6 fe80::6454:35ff:fed9:48a8/64 scope link
       valid_lft forever preferred_lft forever
root@VM-0-2-ubuntu:~# ip route
default via <IP_ADDRESS> dev eth0 proto dhcp metric 100
<IP_ADDRESS>/28 dev docker0 proto kernel scope link src <IP_ADDRESS> linkdown
<IP_ADDRESS>/26 dev cbr0 proto kernel scope link src <IP_ADDRESS>
<IP_ADDRESS>/20 dev eth0 proto kernel scope link src <IP_ADDRESS>
root@VM-0-2-ubuntu:~# ip r get <IP_ADDRESS>
<IP_ADDRESS> via <IP_ADDRESS> dev eth0 src <IP_ADDRESS> uid 0
    cache
root@VM-0-2-ubuntu:~# ping -c 5 <IP_ADDRESS>
PING <IP_ADDRESS> (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from <IP_ADDRESS>: icmp_seq=1 ttl=53 time=41.7 ms
64 bytes from <IP_ADDRESS>: icmp_seq=2 ttl=53 time=41.7 ms
64 bytes from <IP_ADDRESS>: icmp_seq=3 ttl=53 time=41.7 ms
^Z
[1]+  Stopped                 ping -c 5 <IP_ADDRESS>

Is the log identical when using --net=host? The better way is probably to show what networking looks like in the container, using docker run alpine ip route. I'm not sure if this is now host specific or Docker specific, the output of docker info and cat /etc/docker/daemon.json probably also helps.

Let us know if we can investigate further.


Fix inconsistent treatment of generated code with restrictive annotations

Without this change, we have a bug whenever the following flags are
used together:
-XepOpt:NullAway:TreatGeneratedAsUnannotated=true
-XepOpt:NullAway:AcknowledgeRestrictiveAnnotations=true

and a method inside @Generated code is explicitly marked as having a
@Nullable return.
In this case, the RestrictiveAnnotationHandler would treat the method
as definitely @NonNull when handling the onOverrideMayBeNullExpr extension
point, but as @Nullable for the purposes of onDataflowVisitMethodInvocation.
This is inconsistent on its own, but it produces even more undesirable behavior
if a castToNonNull method is configured (whether through library models or
-XepOpt:NullAway:CastToNonNullMethod).
If foo is such a @Generated+@Nullable method, then, in the above
configuration:
Object o = castToNonNull(foo());
o.toString();

Produces an error, claiming that a known @NonNull value is being passed to
the cast.
Yet the following code:
Object o = foo();
o.toString();

Causes NullAway to complain about a @Nullable dereference (due to dataflow
concluding o is @Nullable).
To fix this, we need to make sure that the behavior of AcknowledgeRestrictiveAnnotations
is consistent.
One option is to not care about @Generated vs non-generated code, or
about TreatGeneratedAsUnannotated, and always use restrictive annotations
if available. Unfortunatelly, this is a change that will increase the number of
errors from NullAway on existing codebases (internally, we use
TreatGeneratedAsUnannotated explicitly as a way to relax our checks around
thrift generated code which does have @Nullable annotations). Thus, the one
remaining answer seems to be that, in this configuration, generated code should
be treated optimistically for both onOverrideMayBeNullExpr and dataflow.

Pull Request Test Coverage Report for Build #887

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.01%) to 92.552%

Files with Coverage Reduction
New Missed Lines
%

../nullaway/src/main/java/com/uber/nullaway/dataflow/AccessPath.java
2
95.74%

Totals

Change from base Build #886:
-0.01%

Covered Lines:
4859

Relevant Lines:
5250

💛  - Coveralls


Run tests on 32 bit images

For our linting, we depend on SWALint and SWALint apparently doesn't work on 32bit images.
So we're leaving the current situation as-is for now.


Momentum SGD is very slow with large embedding layer

Hi, I have an (256 col* 500000row) embedding layer in my model and I found that Momentum SGD is 10x slower than adam optimizer. When I printed the global variables using API :tf.global_variables(), I found a large Momentum  variable created by optimizer, does that means Momentum SGD have not  supported sparse update yet?

I'm assuming you mean that AdamOptimizer is slower than MomentumOptimizer; Adam applies momentum to the whole variable, Momentum only applies it to slices affected. Does tf.contrib.opt.LazyAdamOptimizer work for you?

@allenlavoie sorry, I mean AdamOptimizer is faster than MomentumOptimizer.In my case,
AdamOptimizer can run 11.58 batch per second, while MomentumOptimizer can only run 5 batch per second.I run TF 1.3.1 in K40 GPU.

Can you post code to reproduce? It sounds like this is not a sparsity issue, since MomentumOptimizer handles sparse updates more quickly than Adam (in theory). Maybe a device placement issue?

The code is complex and have a lot preprocessing code(using Dataset API and TF data), I can write a  test code for it.Could you give some advice to test whether it is a placement  issue? I just changed the code from AdamOptimizer to MomentumOptimizer.The way how the optimizer placed should be same.

And tf.contrib.opt.LazyAdamOptimizer can speed up training speed, It really help.

I'd start with (log_device_placement)[https://www.tensorflow.org/tutorials/using_gpu#logging_device_placement]; maybe sparse Momentum updates don't have a GPU kernel (or don't have one for the dtype you're using)?

It seems Momentum updates don't have a GPU kernel?

Oh, right, Adam's sparse updates are in terms of other ops rather than being fused. Looks like none of the other optimizers have GPU kernels implemented for the sparse updates (they do have GPU kernels for dense updates).
One approach would be to re-implement MomentumOptimizer's sparse updates in terms of the same ops Adam is using rather than using the custom fused kernel. May be difficult without also using Adam's dense update behavior (which is more correct, but would upset lots of people).
Or it may be possible to implement the sparse fused GPU kernel efficiently using CUB.
Or you could make a simple copy of MomentumOptimizer which always does dense updates, since those will run on the GPU and be faster in your case. This is more of a hack, but certainly contributions welcome for either of the other options.

Thanks @allenlavoie ~

Hi, Have you checked the new tf.keras.optimizers.experimental.SGD, which can be implemented with the large embeddings. Thanks!


CLOUDP-97432: live migration validation job status command

Proposed changes
Support for "Return Status of One Specific Validation Job" Docs
Jira ticket: CLOUDP-97428
Checklist

[x] I have signed the MongoDB CLA
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added any necessary documentation (if appropriate)
[ ] I have updated e2e/E2E-TESTS.md (if a new command or e2e test has been added)
[x] I have run make fmt and formatted my code

Command Help:
bin/mongocli atlas lm validation describe --help --profile=atlas-dev
Your API Key must have the Organization Owner role to successfully run this command.

Usage:
  mongocli atlas liveMigrations validation describe [flags]

Aliases:
  describe, get

Flags:
  -h, --help                  help for describe
  -o, --output string         Output format.
                              Valid values: json|json-path|go-template|go-template-file
      --projectId string      Project ID to use. Overrides configuration file or environment variable settings.
      --validationId string   Unique 24-hexadecimal digit string that identifies the validation job.

Command output:
bin/mongocli atlas lm validation describe --validationId=6141c02eadd36135e7414ac3 -o=json --profile=atlas-dev
{
  "_id": "6141c02eadd36135e7414ac3",
  "groupId": "6137493677e94f0e973d1a0f",
  "status": "PENDING",
  "sourceGroupId": "611e68cb086adf5cda2e6253"
}

Overall looks good, just blocking on one comment


AMBARI-22868.Add ability to configure done-flag element of dataset in…

… Workflow Manager View(Venkata Sairam)
added support for Coordinators to the Workflow Designer.
done-flag supports the following in generated xml:
absent
present, but empty
present with text value
Manually testing done.

Hi @venkatasairamlanka, please make sure to create branches for pull requests in your own fork, not in apache/ambari.  Thanks.

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ambari-Github-PullRequest-Builder/1161/
Test FAILed.
Test FAILured.

LGTM.

LGTM


Is this repo still actively maintained?

Is there any guidance regarding how to package this repo into a debian so that I can install on my target system?

If it is it definetly needs a README


Website is down.

https://www.upmin.com/admin-rails is not available.

The videos were all out of date so upmin.com was set to just URL redirect to this repo where there are current docs.

Any screenshots in the README would be great tho.


Option to not create a folder for each date

By default the plugin creates a new folder for each day.
It would be nice to have that turned off and just create the files in the Omnivore folder

I agree with this, would be nice to have this as an option in settings.

+1. File names are enough for me.

I just created a pull request for this that adds an option to toggle the subfolder usage (defaults to true, uses the subfolder).
Also increased the size of the template text area so it is viewable without having to resize the box.

Hey @uwe999 @sambody @willasm, sorry for the late reply.
I have an idea to address this issue and have put up a PR #25
This will allow you to put all the files in the root folder and you just need to config the settings like this

If you'd like to keep the date as the subfolder, you could just set Omnivore/{{date}}

Do you think it caters to your need?

Looks good to me. Thanks for that.

Cool. I will merge this

Version 1.0.6 is released to add this feature

Thanks, this works perfectly.

I know the issue is closed. Is it possible to group the folders by Labels instead of date?


Terms used in User Identity section in CAMARA-API-access-and-user-consent.md

Problem description
Update the terms used in User Identity section of CAMARA-API-access-and-user-consent.md
Expected action
The current text isn't clear and mixes the use of (user) "identity," "identification," "identifier" that should be clearly specified in this section (as well as added to the Glossary of Terms section).
Additional context
As suggestion could be to use Section 3.1, 3GPP TR 22.904, as a guide (for User/User Identity/User Identifier) as well as Figure 1, Section 4.2, that depicts the relationship between user, identities, identifiers and attributes. The terminology used also aligns with ISO/IEC 24760 (IT Security and Privacy — A framework for identity management).

Moving comment from @murthygorty in #93 here, which is a related topic:

In terms and concepts, can you consider changing "User" term to "Subscriber" please? If approved and changed, we will have
End User -> human participant using the application (can be a parent or alternate delegate of the carrier-resource)
Subscriber -> subscriber of the telco operator, owner of the carrier-resource at hand. (eg., parent)

As stated in https://github.com/camaraproject/IdentityAndConsentManagement/issues/88, we are in the process of finalizing a first release v0.1 of the documentation with the existing agreements. But apart from that, from Telefónica side, we are more than happy if you guys contribute with a PR to the documentation once the v0.1 release is closed, to add the suggested improvement for everyone to review.


'os' has no attribute 'errno' when using keras.utils.plot_model

System information

Tensorflow install via pip
pydot version 1.2.3
tensorflow version 2.1.0
python 3.7.7

Error Details
When running tf.keras.utils.plot_model an error is raised:
~\Anaconda3\lib\site-packages\pydot.py in create(self, prog, format)
   1878                 stderr=subprocess.PIPE, stdout=subprocess.PIPE)
   1879         except OSError as e:
-> 1880             if e.errno == os.errno.ENOENT:
   1881                 raise Exception(
   1882                     '"{prog}" not found in path.'.format(

AttributeError: module 'os' has no attribute 'errno'

I understand that this error is a problem with pydot, but perhaps a pydot version bump would fix this problem (most recent pydot version is 1.4.*).

@celsomilne,
In order to expedite the trouble-shooting process, could you please provide the complete code to reproduce the issue reported here. Thanks!

@amahendrakar
import tensorflow as tf

m = tf.keras.models.Sequential([
    tf.keras.Input(shape=(512, 512, 1)),
    tf.keras.layers.Conv2D(3, 3),
    tf.keras.layers.MaxPool2D(),
])

tf.keras.utils.plot_model(model)

@celsomilne,
I was able to run the code with TF v2.2 without any issues. Please find the gist of it here.
Could you please update TensorFlow to v2.2 and let us know if it works. Thanks!

@amahendrakar
Thanks! I updated to TF v2.2, and downgraded pydot to 1.3.0 and graphviz to 0.10.1 (as it appears in your Collab) but I'm now getting the (rather unhelpful) message:
Failed to import pydot. You must install pydot and graphviz for 'pydotprint' to work.
I've also tried running tensorflow from both windows and a linux VM, with no difference in outcome.
Unfortunately, I can't use Collab for the analysis I'm doing.

Thanks @amahendrakar. After reading through the issue, I fixed my problem with
sudo apt-get update
sudo apt-get install graphviz
```
I feel that the documentation for `plot_model` should mention the fact the `graphviz` needs to be installed separately (especially for inexperienced users who'd simply assume the `pip install graphviz` is enough).

What do you think?

I feel that the documentation for plot_model should mention the fact the graphviz needs to be installed separately (especially for inexperienced users who'd simply assume the pip install graphviz is enough).

@celsomilne,
If we take a look at the source code for tf.keras.utils.plot_model, it uses pydot_ng or pydotplus and if both the packages are not found it then falls back to pydot.
If none of these packages are found (including graphviz), it throws an ImportError stating
Failed to import pydot. You must install pydot and graphviz for pydotprint to work.
Hope this clears things up, please feel free to close the issue if resolved. Thanks!


FileUpload: Some files are missing when uploading multiple files

Package
filament/filament
Package Version
3
Laravel Version
11
Livewire Version
V3
PHP Version
php 8
Problem description
When I upload multiple files, some of the files are missing.
Expected behavior
All the files should be present in the desired folder.
Steps to reproduce
Section::make('')                     ->relationship('result_files')                     ->schema([                     FileUpload::make('attachments')                         ->columnSpan(12)                         ->multiple()                         ->maxSize(100000)                         ->disk('uploads')                         ->directory('result_files')                         ->acceptedFileTypes(["application/pdf"])                         ->getUploadedFileNameForStorageUsing(function ($file): string {                             $fileName = str($file->getClientOriginalName());                             $fileName_str = preg_replace('/[^a-zA-Z0-9.]/','',iconv('UTF-8', 'ASCII//TRANSLIT',  $fileName));                             return (string) str($fileName_str)->prepend(now() . '-');                         })                         ->downloadable()                         ->rules([ new MalwareFile] )                         ->label(__('application.resource.result_documents'))                 ]),
    FileUpload::make('attachments')                         ->columnSpan(12)                         ->multiple()                         ->maxSize(100000)                         ->disk('uploads')                         ->visibility('private')                         ->directory('application_files')                         ->getUploadedFileNameForStorageUsing(function ($file): string {                             $fileName = str($file->getClientOriginalName());                             $fileName_str = preg_replace('/[^a-zA-Z0-9.]/','',iconv('UTF-8', 'ASCII//TRANSLIT',  $fileName));                             return (string) str($fileName_str)->prepend(now() . '-');                         })                         ->downloadable()                         ->rules([ new MalwareFile] )                         ->label(__('application.resource.application_documents')),
livewire.php
     'temporary_file_upload' => [         'disk' => 'tmp',        // Example: 'local', 's3'              | Default: 'default'         "rules" => "file|mimes:pdf,jpg,jpeg,png,doc,docx,svg,mp4,mp3 | max:100000",         // 'rules' => 'max:100000',       // Example: ['file', 'mimes:png,jpg']  | Default: ['required', 'file', 'max:12288'] (12MB)         'directory' => null,   // Example: 'tmp'                      | Default: 'livewire-tmp'         'middleware' => null,  // Example: 'throttle:5,1'             | Default: 'throttle:60,1'         'preview_mimes' => [   // Supported file types for temporary pre-signed file URLs...             'png', 'gif', 'bmp', 'svg', 'wav', 'mp4',             'mov', 'avi', 'wmv', 'mp3', 'm4a',             'jpg', 'jpeg', 'mpga', 'webp', 'wma', 'pdf'         ],         'max_upload_time' => 5, // Max duration (in minutes) before an upload is invalidated...     ],
Reproduction repository (issue will be closed if this is not valid)
https://github.com/guma-005/Filament-issue.git
Relevant log output
No response

Donate 💰 to fund this issue

You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
100% of the funding will be distributed between the Filament core team to run all aspects of the project.
Thank you in advance for helping us make maintenance sustainable!

Please provide a non-empty reproduction repository.

updated repository

Please attach the files you were uploading and explain what disk you use

Hi this happened to me as well, I have a different scenario and was able to find the culprit (but not a solution).
In my example I have an action opening a modal with the FileUpload in its form and the creation of one entities for each uploaded file (within the action itself).
The Resource, then, has a relationManager with the entities created in the above-mentioned action.
If in the relationManager we add a ->poll('5s') then the issue appears, if we don't it works flawlessly.
I've created a repo with the two versions of the Resources so you can try it out both the working and the non-working version.
Please find the repository at the following URL, I've added a little instruction in the README and it also is shipped with some test files to be uploaded, for your convenience.
https://github.com/danilogiacomi/filamentFileUploadProblem

any update for this issue ?

Might this be related to my issue (only uploading 1 file): https://github.com/filamentphp/filament/discussions/14446


build(actions): align fileDiff checks

What's included

build(actions): align fileDiff checks

How to test

...
Example

...
Updates issue/story

ongoing

Codecov Report

Merging #10 (eecbf92) into main (cfcc6cf) will not change coverage.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   83.43%   83.43%
=======================================
  Files           7        7
  Lines         332      332
  Branches      108      108
=======================================
  Hits          277      277
  Misses         49       49
  Partials        6        6

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfcc6cf...eecbf92. Read the comment docs.


new application not showing up in the dashbaord

I've added gorelic as middleware, and can see that it is sending data to NewRelic, and that NR is returning a 200....but when I check my NR page, the app is not listed. I've been told NR should automatically create the new app when it receives the data. Just curious if you know if I need to do something on the NR side to start receiving and showing this data?

We're seeing the same thing on our end. Interestingly, I do see our app reporting under the "Plugins" section of NewRelic, in the GoRelic category, so I'm not sure I've just misunderstood the way gorelic is expected to update or if there is actually an issue to be resolved.

I'm not seeing it under Plugins, either. As far as I can tell, these messages just get dropped.

Seeing this too.  Any new findings yet, @WelltokCaleb ?

@seenickcode: Sadly, no...haven't made any progress.

@sethhochberg If you see your app under Plugins, are you seeing the headings in the left panel (Memory In Use, GC, SysMemUsage, ...)? If you do see those, are you just not seeing data in the graphs?
@WelltokCaleb If you don't see your app under plugins, are you sure you've got it configured correctly? Set up with the correct licence key, started the agent, etc?

@jordanshoebox - yep. We're using NewRelic for a bunch of existing apps (nodeJS and Ruby, primarily) without issue, and I'm using the same key, etc.

@jordanshoebox Yes, we do see the correct headings and also the graphs displaying under the Plugin menu. What is specifically missing in our case is the APM reporting.

@jordanshoebox - might have been a timing issue. Several days after last checking, the GoRelic app is listed in the Plugins, so we're at the same place as @sethhochberg.

@sethhochberg @WelltokCaleb  Was there any progress on this. We are facing the same issue. I can see Gorelic app in the Plugins, but not in APM.

I am now using the official go APM plugin (which is in beta) and quite loving it. It appears in the APM and not in the plugins section.


How To remove single product from the cart

It's very easy. You only need use the method remove($rowId) passing the product's rowId as a parameter:
Cart::remove('productRowId');
To get the product's rowId, you can use Cart::search() and compare any property from $cartItem:
$rowId = $cart->search(function ($cartItem, $rowId) {
	return $cartItem->id === 1;
});
// The return will be the product's rowId


IAdress interface must contain no-required useAuth property

IAdress interface must contain no-required useAuth property

if you wanna I able to create push request

@Stevenic any thoughts?


Bluetooth: Controller: Assert on bt disconnect when there is a CIS

Describe the bug
If we are in an ACL connection with a CIS connected as well, and we do the bt disconnect shell command we sometimes hit this assert:
ASSERTION FAIL [link] @ WEST_TOPDIR/zephyr/subsys/bluetooth/controller/ll_sw/ull_iso.c:1675

To Reproduce
Steps to reproduce the behavior:

Using the shell, connect an ACL and a CIS to a device as the central
Disconnect the ACL (and thus also the CIS) with bt disconnect.
See error

Expected behavior
Expect bt disconnect to properly disconnect the ACL and CIS without an assert.
Impact
Significant
Logs and console output
N/A
Environment (please complete the following information):

Commit SHA or Version used: https://github.com/zephyrproject-rtos/zephyr/pull/59107

Using the nRF5340 with the hci_rpmsg sample with nrf5340_cpunet_iso-bt_ll_sw_split.conf on the netcore and the audio shell on the appcore.
Additional context
Found during UPF.

This assert is also triggered sometimes when setting up a CIS using the 48_2_1 BAP audio config with a unidir CIS


Perform static token validation before logging in

Summary
It might be neat to validate the token before logging in so the users can get a bit more of a helpful error.
Checklist

[x] If code changes were made then they have been tested

[x] I have updated the documentation to reflect the changes
[x] I have formatted the code properly by running black .

[ ] This PR fixes an issue
[x] This PR adds something new (e.g. new method or parameters)
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
[ ] This PR is not a code change (e.g. documentation, README, ...)

Are tokens guaranteed to always be 59 chars? Eventually the timestamps/snowflakes should reach a point where their value results in a 60 char token

I'm guessing we could just check whether the token is >= 59 characters. I wanted it to be a proper validation but I suppose we can make it less strict.

After going through the various issues which could arise we have decided on closing this pull request.
Checking for client secrets is still being considered.


feat: Add specific padding to boundaries (#518)

There were no tests for this class already, but all existing tests still pass.

May you add few tests to cover the new cases please?

@FezVrasta After I get these tests done, how long would it be until this is in a version?  I have a week until code freeze, so need to either fork this and go off that, or need to have these changes in.

As soon this is merged I'll release the new version with this feature in.

OK I am working on a few other higher priority issues, I'll get some tests in as soon as I can.

@FezVrasta Tests are added and passing.  Some Tests are not passing for IE10 and IE11, but those tests were a backfill for missing tests for existing functionality.

@FezVrasta This is ready for your review.

I don't get why the tests are not passing on IE...this isn't any browser specific functionality

@FezVrasta I'm not sure either, but those tests were just backfill only related due to proximity.  Can we still get these changes is now, and one of us can take a closer look when we have more time?  I have to pull this into my current project today, and I'll have to go off my clone if it isn't in yours.

I'd rather wait until we have a solid pr sorry

I tried debugging the tests on another PR, as I am not sure how to get the IE tests to run locally even under a VM.
Pretty much I think IE is doing something funny in getBoundingClientRect.

@FezVrasta Well there you go.

@FezVrasta Could you please publish a new version for this? Thanks!


Bluetooth: Mesh: Wait for proxy on node reset

Adds idle wait callback to proxy by counting the number of pending
notifications.
Ensures that all connected nodes have received messages before resetting
the mesh stack.
Signed-off-by: Trond Einar Snekvik<EMAIL_ADDRESS>

cc @johnsmithecon


Table key source

Is your feature request related to a problem? Please describe.
Currently, table values all have sources attached to them (line and column), which is very useful. However, there seems to be no way of getting the source of the table key (the name = part).
Describe the solution you'd like

I'm not sure what the best interface for this would be, as this information would probably need to be accessible from the table itself and not from the node that is received with operator[] and such, since they don't store that they're in a table. Probably some method on toml::table like key_source(std::string) -> std::optional<toml::source_region> could suffice.
Additional context

Basically, since no libraries support preserving the structure of the file, i'm rolling my own solution that only replaces parts of the file by accesing the source of the node. It would be very useful to be able to also get the source of the key, so I could replace them easily without reformatting the whole table or doing it in roundabound ways.

Yah, you're right that it would need to be stored outside the values. I'd be wary against adding it to the tables since that's going to add quite a lot of extra state to each node (and force an ABI break); an alternative solution would be to provide an optional metadata 'container' class that could collect this sort of thing during parsing, e.g. something like:
# config.toml:
[foo]
bar = 5

toml::metadata md;
auto table = toml::parse_file('config.toml', &md);

std::cout << md.key_source(table["foo"]["bar"]) << "\n";

line 3, column 1

Now that I think of it, this would be a good backwards-compatible way of also implementing a solution to #28...

Yah, you're right that it would need to be stored outside the values. I'd be wary against adding it to the tables since that's going to add quite a lot of extra state to each node (and force an ABI break); an alternative solution would be to provide an optional metadata 'container' class that could collect this sort of thing during parsing, e.g. something like:
# config.toml:
[foo]
bar = 5

toml::metadata md;
auto table = toml::parse_file('config.toml', &md);

std::cout << md.key_source(table["foo"]["bar"]) << "\n";

line 3, column 1

Now that I think of it, this would be a good backwards-compatible way of also implementing a solution to #28...

The outside container may be a good idea.. although i suppose that would imply that source() will have to be removed or something, but that will break compatibility.. perhaps instead it could be made to somehow point to the metadata object instead of storing data in the table itself (though this may be tedious and error prone due to having to ensure that the metadata container lives at least as long as the table itself...).
I can't say I have a good solution for this. The most obvious way is putting it into tables themselves and it's just no good..
One thing i worry about the "outside container" is that there NEEDS to be a good way to get the data for the node however deep in the tree easily (if, for example, the path to the node is dynamic). In the example you've shown the container is supposed to somehow figure out the path from the table value, even though the table value doesn't actually include a path to itself. So the container would probably have to either store some kind of ID for each node and use that, if it's to work like in this example. Either that or the node storing the path to itself, i guess.

The outside container may be a good idea.. although i suppose that would imply that source() will have to be removed or something, but that will break compatibility.. perhaps instead it could be made to somehow point to the metadata object instead of storing data in the table itself (though this may be tedious and error prone due to having to ensure that the metadata container lives at least as long as the table itself...).
I can't say I have a good solution for this. The most obvious way is putting it into tables themselves and it's just no good..
One thing i worry about the "outside container" is that there NEEDS to be a good way to get the data for the node however deep in the tree easily (if, for example, the path to the node is dynamic). In the example you've shown the container is supposed to somehow figure out the path from the table value, even though the table value doesn't actually include a path to itself. So the container would probably have to either store some kind of ID for each node and use that, if it's to work like in this example. Either that or the node storing the path to itself, i guess.

I suppose I'll also point out in this issue about editing and preserving the formatting of the file, if anyone looking through the issues finds this.
The idea is to after reading the file, store it (or re-read it on save) and when serializing, look up positions in the source of the nodes and replace the data in the file with the new changed data. It probably could be implemented as a wrapper around the current parse_file system without touching it all, and incorporated into the library, if someone would be willing to do it (sadly my own implementation is ugly and oriented on serializing very concrete data).

I suppose I'll also point out in this issue about editing and preserving the formatting of the file, if anyone looking through the issues finds this.
The idea is to after reading the file, store it (or re-read it on save) and when serializing, look up positions in the source of the nodes and replace the data in the file with the new changed data. It probably could be implemented as a wrapper around the current parse_file system without touching it all, and incorporated into the library, if someone would be willing to do it (sadly my own implementation is ugly and oriented on serializing very concrete data).

... although i suppose that would imply that source() will have to be removed or something, but that will break compatibility

I won't be removing the existing source() since I don't want to break things for existing users. If I do a v3 of the library I'd happily break all sorts of things because there's a few early design mistakes I'd like to correct, but only when I do a major version bump. Until then it's backwards-compatibility for everyone.

... there needs to be a good way to get the data for the node however deep in the tree easily (if, for example, the path to the node is dynamic), otherwise it will be terrible to use.

Of course. The example above is to illustrate the concept, not an example of exactly how it would be implemented, so don't read into it too much beyond that.

Either that or the node storing the path to itself, i guess, but that breaks the ABI(?)

Yeah, if I add state to any existing classes that's an implict ABI break - function calls will still link just fine but the size/layout of the objects will change so client code will explode. The metadata object is a non-breaking solution (pre-v3) because it doesn't modify anything that's already being used in the wild.

... although i suppose that would imply that source() will have to be removed or something, but that will break compatibility

I won't be removing the existing source() since I don't want to break things for existing users. If I do a v3 of the library I'd happily break all sorts of things because there's a few early design mistakes I'd like to correct, but only when I do a major version bump. Until then it's backwards-compatibility for everyone.

... there needs to be a good way to get the data for the node however deep in the tree easily (if, for example, the path to the node is dynamic), otherwise it will be terrible to use.

Of course. The example above is to illustrate the concept, not an example of exactly how it would be implemented, so don't read into it too much beyond that.

Either that or the node storing the path to itself, i guess, but that breaks the ABI(?)

Yeah, if I add state to any existing classes that's an implict ABI break - function calls will still link just fine but the size/layout of the objects will change so client code will explode. The metadata object is a non-breaking solution (pre-v3) because it doesn't modify anything that's already being used in the wild.

I suppose the metadata container is the most likely solution then, if compatibility is not to be broken.
Perhaps, as to not break source() for existing users, the parse_file with metadata could be a special overload that creates nodes that have source() pointing to the metadata container in addition to having the container itself to use (so the source() would not me completely useless on these nodes), and the old one would be left as-is. I, personally, would be happy with any solution, but of course I'm not the library maintainer. Your idea with the container seems like the most sane solution that should not break anything.

I suppose the metadata container is the most likely solution then, if compatibility is not to be broken.
Perhaps, as to not break source() for existing users, the parse_file with metadata could be a special overload that creates nodes that have source() pointing to the metadata container in addition to having the container itself to use (so the source() would not me completely useless on these nodes), and the old one would be left as-is. I, personally, would be happy with any solution, but of course I'm not the library maintainer. Your idea with the container seems like the most sane solution that should not break anything.

@vaartis If you're still interested in this feature I've pushed an implementation of it to the v3 branch. Since it's going to be an ABI-breaking release I decided to store the source info directly in the tables as part of the new toml::key class, replacing my use of plain std::string as the table's internal map key. It can be accessed anywhere you might have previoously accessed the string keys (structured bindings, iterators, etc.).
I won't merge v3 into master for a while yet since there's more work to be done before I cook a new release, but I welcome you to try it before then.
The full list of changes in the v3 branch can be found here.

Thank you. I'll try porting my code to v3 when I can

Sorry, been a while.. Getting back to this, is there any way in the 3.1.0 version to get the actual toml::key from the table without iterating it? Basically, I just want to get the source data because I store paths as strings, and there are a few places where I cannot store the toml::key because the values are constructed artificially.

Well, answering my own question.. toml::table::find(path_element)->first seems to be the answer. Thank you again for implementing this, I'm hoping to finally get rid of all the ugly hacks I had.

Actually, I think I found a bug.. The tables report their beginning on one symbol later then they actually are, i.e. if it starts at (line,column) 1,1 of the file, it reports it as 1,2. Just tested this in 2.5.0 and that was not the case.

Oh, interesting. Mind opening a new issue with a small repro?

https://github.com/marzer/tomlplusplus/issues/152 :+1:


Incremental aggregation with RDBMS store has a strange behavior in tables (may be a bug?)

Siddhi-tooling for docker v5.1.2
Hi,
I've got an aggregation which calculate count of events per seconds, minutes..... and months. Sometimes when I send an event it creates a record in seconds AND minutes tables. Sometimes it creates records ONLY in seconds tables. My gut feeling is that it creates two records close to ending of minutes (on calculation edges, when 58,59 seconds).
The example: screenshot
For the event which sent in the end of 40 minute two records were created. but for the next event which is sent almost right after the 1st one, only one record was created. I would expect consistent behavior. So whether always two records or only one record should be created.
This is important for me because I'm trying to calculate the count using tables and when it creates two records in seconds and in minutes, it increases the number and it's not trivial to write correct script. It seems to me that this behavior is not pretty consistent and nor reliable for calculation of a total count of events using such tables.
The code:
@App:name('test')
@App:statistics(enable='true', include='*.*')

-- SOURCES

define stream inp_flags (
    customer string,
    flag bool
);

-- AGGREGATIONS

@store(type = 'rdbms',
    jdbc.url = "${POSTGRE_HOST}${POSTGRE_DB_DATASETS}",
    username = "${POSTGRE_USER}",
    password = "${POSTGRE_PASS}",
    jdbc.driver.name = "org.postgresql.Driver")
@purge(enable='true', interval='1 second')
define aggregation flags_counts
from inp_flags
select
    customer,
    count() as cnt
group by customer
aggregate every seconds...months;

The problems which I try to solve:
I need to calculate some aggregations (count, average, etc.) and produce a stream with latest values. This calculations should have a persistence, so after restart of the Siddhi application they should take the latest value and increment it. Also I want to have a storage which could be easy accessible, so I don't want to use some "internal" Siddhi persistence.
If you know solution for this, please, share idea?

Siddhi incremental aggregations design is the following way,

We will hold the events arrived in the last duration bucket, for instance, the last second, last-minute... in memory. The older calculations are moved to the table.

I need to calculate some aggregations (count, average, etc.) and produce a stream with latest values

What do you mean stream, is this aggregation never-ending? For instance, you want the count of customer events from the node start?

@niveathika
Hi,

As to design of incremental aggregations. I understand that, but don't understand why two events with difference in several seconds were stored in DB differently. The 1st events has been stored in seconds and minutes. The 2nd event was stored only in seconds. With the time they were correctly purged and moved to respective tables.

As to the counts. Yes, I need to count from the very beginning, regardless if a node restarting. I found a solution with this incremental aggregations, using their tables, but because of the issue above it produces incorrect temporal results while values are duplicated in tables. Basically, I want to take records from each tables which are not included in another table. This should produce count for the whole existing data.

Why I need incremental aggregations? Because they are purging data, which allows store it in a compact way. And I don;t need to write it on my own, which is great.


Allow simultaneous gesture

The current gesture modifier would get blocked when the child view has the same kind of gesture attached.

Tested locally.

Good catch, Thanks for your contribution!

I've release version 0.0.5 which includes this change.

Thanks for accepting the change 👍


No longer require buffer content to be 'static

Obviously that doesn't mean that you can or should put non-static things in a buffer. It's just meant to simplify the API and trait requirements.


Bind git_submodule_repo_init

This allows a real initialization of a submodule's repository, where git_submodule_init only leaves you with nothing truly usable.

Thanks, can you add a test for it?

I thought about it, but after a quick look at the end of submodule.rs, I wasn't really sure where to start. Are there the only submodule tests? I'll try to add something based on existing clone_submodule() test.

Yea, I think it would go at the bottom of submodule.rs. And yea, I would just start be copying one of the other tests and then adjusting it to utilize the new method.

I've added a test, do you think it's enough, or is more needed?

@ehuss thanks for the quick review and the merge. Do you have any idea when this will be released in a tag?


update landing

update landing page:

remove brochure and current header
make tutorials/examples appear at the top
add eotdl logo

waiting for new design @D-A-Albrecht


STAN interface

Need a function/class that takes a model and a data set, passes this into STAN to be solved (using HMC) and returns distributions on the parameters

3a96a06 adds the ability to get a STAN model from the ECModel class. This model doesnt do much yet, just runs the simulation

Hi @martinjrobins ! I can see two ways to resolve this issue:

Declare this outside the scope of Pints
Add a class StanCompatibleModel extends Model that also provides a stan_code() method.

Option 2 is only useful if we envision doing STAN stuff directly in Pints though!

Unless Ben gets STAN working well on these types of models, I doubt we will use it, so lets just close it until something changes.


ignore expected report

Rationale
For teamcity reporting
Related Pull Requests

Changes

@labkey-tchad @labkey-matthewb are the crawler changes complete? Can we close this PR?

@labkey-tchad @labkey-matthewb are the crawler changes complete? Can we close this PR?

I think we can close this. I made a change on the test side to ignore CSP errors generated by the crawler test


HBASE-22690 Deprecate / Remove OfflineMetaRepair in hbase-2+

This is for the master branch. In this PR, I removed OfflineMetaRepair completely and remove some unnecessary logics in HBaseFsck.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
234
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
1
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
279
master passed

+1
compile
54
master passed

+1
checkstyle
71
master passed

+1
shadedjars
287
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
218
master passed

+1
javadoc
31
master passed

_ Patch Compile Tests _

+1
mvninstall
247
the patch passed

+1
compile
57
the patch passed

+1
javac
57
the patch passed

+1
checkstyle
72
hbase-server: The patch generated 0 new + 97 unchanged - 6 fixed = 97 total (was 103)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
286
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
761
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
210
the patch passed

+1
javadoc
32
the patch passed

_ Other Tests _

-1
unit
14751
hbase-server in the patch failed.

+1
asflicense
23
The patch does not generate ASF License warnings.

17943

Reason
Tests

Failed junit tests
hadoop.hbase.namespace.TestNamespaceAuditor

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/381

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux beec4d844e1e 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 74731c2a46

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/1/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/1/testReport/

Max. process+thread count
4749 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/1/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Thank you for reviewing @saintstack

The removed methods are only used by OMR?
Yes.

Ok. Good by me.  Long as other concerns addressed, +1 from me @brfrn169

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
74
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
1
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
307
master passed

+1
compile
56
master passed

+1
checkstyle
73
master passed

+1
shadedjars
276
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
229
master passed

+1
javadoc
38
master passed

_ Patch Compile Tests _

+1
mvninstall
280
the patch passed

-1
compile
33
hbase-server in the patch failed.

-1
javac
33
hbase-server in the patch failed.

+1
checkstyle
69
hbase-server: The patch generated 0 new + 97 unchanged - 6 fixed = 97 total (was 103)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
266
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
817
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
163
the patch passed

+1
javadoc
35
the patch passed

_ Other Tests _

-1
unit
16119
hbase-server in the patch failed.

+1
asflicense
31
The patch does not generate ASF License warnings.

19179

Reason
Tests

Failed junit tests
hadoop.hbase.client.TestSnapshotTemporaryDirectory

hadoop.hbase.client.TestSnapshotDFSTemporaryDirectory

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/381

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 9c1cbdf784f4 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / cc38de1a39

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/2/artifact/out/patch-compile-hbase-server.txt

javac
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/2/artifact/out/patch-compile-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/2/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/2/testReport/

Max. process+thread count
4865 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/2/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
87
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
284
master passed

+1
compile
61
master passed

+1
checkstyle
87
master passed

+1
shadedjars
303
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
247
master passed

+1
javadoc
39
master passed

_ Patch Compile Tests _

+1
mvninstall
287
the patch passed

-1
compile
48
hbase-server in the patch failed.

-1
javac
48
hbase-server in the patch failed.

+1
checkstyle
82
hbase-server: The patch generated 0 new + 97 unchanged - 6 fixed = 97 total (was 103)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
296
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
841
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
216
the patch passed

+1
javadoc
36
the patch passed

_ Other Tests _

-1
unit
15758
hbase-server in the patch failed.

+1
asflicense
35
The patch does not generate ASF License warnings.

19049

Subsystem
Report/Notes

Docker
Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/381

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux acf2f831c0eb 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 72e58a8fed

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

compile
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/3/artifact/out/patch-compile-hbase-server.txt

javac
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/3/artifact/out/patch-compile-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/3/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/3/testReport/

Max. process+thread count
4706 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/3/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
57
Docker mode activated.

_ Prechecks _

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
249
master passed

+1
compile
52
master passed

+1
checkstyle
66
master passed

+1
shadedjars
254
branch has no errors when building our shaded downstream artifacts.

+1
findbugs
198
master passed

+1
javadoc
29
master passed

_ Patch Compile Tests _

+1
mvninstall
231
the patch passed

+1
compile
51
the patch passed

+1
javac
51
the patch passed

+1
checkstyle
68
hbase-server: The patch generated 0 new + 97 unchanged - 6 fixed = 97 total (was 103)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
258
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
739
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
findbugs
212
the patch passed

+1
javadoc
33
the patch passed

_ Other Tests _

-1
unit
15069
hbase-server in the patch failed.

+1
asflicense
31
The patch does not generate ASF License warnings.

17902

Reason
Tests

Failed junit tests
hadoop.hbase.util.TestFromClientSide3WoUnsafe

Subsystem
Report/Notes

Docker
Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/381

Optional Tests
dupname  asflicense  javac  javadoc  unit  findbugs  shadedjars  hadoopcheck  hbaseanti  checkstyle  compile

uname
Linux 7e71a27b4d11 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/testptch/patchprocess/precommit/personality/provided.sh

git revision
master / 00075ea4fc

maven
version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)

Default Java
1.8.0_181

findbugs
v3.1.11

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/4/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/4/testReport/

Max. process+thread count
5081 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/4/console

Powered by
Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
266
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
351
master passed

+1
compile
72
master passed

+1
checkstyle
101
master passed

+1
shadedjars
365
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
41
master passed

0
spotbugs
297
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
295
master passed

_ Patch Compile Tests _

+1
mvninstall
335
the patch passed

+1
compile
69
the patch passed

+1
javac
69
the patch passed

+1
checkstyle
103
hbase-server: The patch generated 0 new + 97 unchanged - 6 fixed = 97 total (was 103)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
367
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
1041
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
44
the patch passed

+1
findbugs
320
the patch passed

_ Other Tests _

-1
unit
16069
hbase-server in the patch failed.

+1
asflicense
28
The patch does not generate ASF License warnings.

20298

Subsystem
Report/Notes

Docker
Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/381

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 8ff2aab84623 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-381/out/precommit/personality/provided.sh

git revision
master / c9293b0b12

Default Java
1.8.0_181

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/5/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/5/testReport/

Max. process+thread count
4993 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/5/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

Thank you for reviewing @saintstack. I'll commit this.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
10
https://github.com/apache/hbase/pull/381 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/381

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/7/console

versions
git=2.7.4

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
35
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
249
master passed

+1
compile
55
master passed

+1
checkstyle
75
master passed

+1
shadedjars
269
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
34
master passed

0
spotbugs
228
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
225
master passed

_ Patch Compile Tests _

+1
mvninstall
248
the patch passed

+1
compile
86
the patch passed

+1
javac
86
the patch passed

+1
checkstyle
92
hbase-server: The patch generated 0 new + 97 unchanged - 6 fixed = 97 total (was 103)

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
259
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
754
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
33
the patch passed

+1
findbugs
237
the patch passed

_ Other Tests _

+1
unit
8178
hbase-server in the patch passed.

+1
asflicense
30
The patch does not generate ASF License warnings.

11176

Subsystem
Report/Notes

Docker
Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/381

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux a1c7af72c81f 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-381/out/precommit/personality/provided.sh

git revision
master / aa9679ddbc

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/6/testReport/

Max. process+thread count
4512 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/6/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
10
https://github.com/apache/hbase/pull/381 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/381

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/1/console

versions
git=2.7.4

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
10
https://github.com/apache/hbase/pull/381 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/381

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-381/2/console

versions
git=2.7.4

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


[Feature] Docker plugin regctl with binary file

Current Behavior
Docker regctl plugin command run as docker image. We are using regctl plugin in ours gitlab runners, but gitlab runners have some image cleanup policy and after some time all images are cleaned and when we use regctl command again, new docker images is pulled again.

Expected Behavior

Example Solution
I wolud propese add optipon (in makefile) to instal regctl docker plugin with binary file instead of docker image.

Version
latest
Environment

Running as binary or container:
Host platform:
Registry description:

Anything else

Hi @pistej. If the regctl binary is installed locally, and in your path, the plugin uses this:
https://github.com/regclient/regclient/blob/main/docker-plugin/docker-regclient#L20
The downside of the docker CLI plugin is that Docker is deprecating that feature, so you're better off installing and running the binary directly.
For Gitlab, I believe that using the regclient/regctl:alpine image for that particular build step is also a good option.

Hi, thanx for quick answer, and pointing out deprecation, ...now I see If condition, thx, will use binary directly.


Update token icons in Wallet tab [Fiji]

We will have rounded icons 40x40. It's easy to generate for coins, more difficult for tokens without graphics. For those ones, use colors (Emerald, Indigo, Radical, Pumpkin, Cerulean, Azure, Mine) and up to 4 characters inside (ENS, SFPF, DEFI, DAO). Use the Tokenary app for inspiration.
If AlphaWallet wants to be the best wallet to hold tokens, we need to make it attractive. In the future, I will provide few more designs how you can manage your tokens quickly (by holding and swiping left to reveal hidden menu)
Sketch Cloud:
https://sketch.cloud/s/e4OJW/a/oE3MPQ
https://sketch.cloud/s/e4OJW/a/8MQgg8
Zeplin:
https://zpl.io/V0j8yZK
https://zpl.io/VxXB74J

We are using the same card as we used in "Settings", so we have an icon 40x40, then the same Headline, secondary line (in terms of font)
https://zpl.io/2GdzLDj

@tomekalphawallet are the 24hrs/appreciation/value for the native crypto (eth and xDai) removed? If they are, can you help to make a version in the BC project with them? They'll want to keep it.

[ ] Update layout #1903 - token icon
[ ] Add token icon

@tomekalphawallet can you also help provide the icons for these networks like you did for Ethereum mainnet and xDai?

[ ] ARTIS — https://artis.eco
[ ] POA — https://www.poa.network
[ ] Ethereum classic — https://iconscout.com/icon/ethereum-classic-logo
[ ] callisto — https://callisto.network

ETC - https://zpl.io/2p6ypo8
POA - https://zpl.io/advnD5R
Callisto - https://zpl.io/bWoKlme
Artis (not sure if this is an official ATS token symbol) - https://zpl.io/VqqmDk5

@tomekalphawallet looks great. Thanks!

@tomekalphawallet could you also provide logos for WETH, DAI, WBTC, cDAI and other compound coins plus USDC

@tomekalphawallet actually most well known tokens can have this, including ones like cryptokitties and ENS

@tomekalphawallet actually most well known tokens can have this, including ones like cryptokitties and ENS

We have them all ready (ctokens, itokens, ptokens):
https://app.zeplin.io/styleguide/5e0b4e7149e83f987edc0a9e/components?cseid=5e0b16e4ce5cf519870b0316
More generic:

USDC https://zpl.io/VQj0MDm
DAI https://zpl.io/beqwzJm
WBTC https://zpl.io/VDJ8v9W
iDAI https://zpl.io/brB1r6W
cDAI https://zpl.io/29QqDeB
WETH this one is problematic, the one I found online looks like a handwritten, 3d drawing, for that reason I changed it to https://zpl.io/aMAdmO7

WETH again https://zpl.io/bLz4E97

Artis again - https://zpl.io/V4mEXv4

Artis again - https://zpl.io/V4mEXv4

@tomekalphawallet Seems like the Artis icon can't be downloaded from there

updated

I added
a) ptokens:
pdai - https://zpl.io/2ENB0GY
psai - https://zpl.io/ag4M3q0
peth - https://zpl.io/2j6QJQr
pbtc - https://zpl.io/2p64JXN
peos - https://zpl.io/VKRPzgP
pusdt - https://zpl.io/VYvKE4L
pltc - https://zpl.io/a7AO00v
b) synthetix tokens
saud - https://zpl.io/VkqG6Lv
sgbp - https://zpl.io/boqDXWo
seur - https://zpl.io/aXxPvD8
sjpy - https://zpl.io/aR51pBr
schf - https://zpl.io/2yAOZXp
susd - https://zpl.io/V049Ej9
sbtc - https://zpl.io/V04qB6l
sxtz - https://zpl.io/2GKy0Nd
sxmr - https://zpl.io/VYvKEmJ
sdefi - https://zpl.io/bJm7Rj3
sada- https://zpl.io/2p64JYN
sltc - https://zpl.io/bJm7Rl9
seth - https://zpl.io/boqDXOW
snikkei - https://zpl.io/bzgNZJ4
sxau - https://zpl.io/aR51JMg
slink - https://zpl.io/beqDEwP
c) others
teo - https://zpl.io/a7AO9ZR
eos - https://zpl.io/bzgNEWX
nest - https://zpl.io/VQXLZ74
link - https://zpl.io/agpvKqO
alphawallet discovery token - https://zpl.io/25D5OwW

I added

Moved to #1958


Custom Service action not returning response

So I set up a custom service called forgot-password and inside my class, I have:
class Service {
  constructor (options) {
    this.options = options || {};
  }

  async create () {
    return {
      message: 'Thanks!'
    };
  }
}

module.exports = function (options) {
  return new Service(options);
};

module.exports.Service = Service;

I removed all of my custom logic and just made it super simple for this example, where i'm returning an object.
Now if I POST to {{hostname}}/forgot-password I get the correct response:

But if I go to my Vue app and try to create a new forgot-password request with the following code:
  methods: {
    ...mapActions({
      forgotPassword: "forgot-password/create"
    }),
    async onSubmit() {
      await this.forgotPassword({
        email: this.credentials.email
      }).then(res => {
        console.log(res);
      });
    }
  }

I'm always getting undefined back.  This seems so simple, but I cannot seem to figure out what's going on. Is there anything I'm missing?
Thanks!

I think it's because the service doesn't have a model, and feathers-vuex rely on them.
I have the same problem but with a database service, I use it to make a mongodb aggregate query so the result structure doesn't match with the mongoose model and Feahters-Vuex discard the result and don't store it.
It not mentio'ned anywhere in the docs and I don't know if it's possible to pass a custom model or to bypass it.
It's a bit annoying, @marshallswain, is there any way to circumvent this behavior?

Feathers-Vuex is optimized inside to map by id.  You have to specify an id or return an id in the response, or the record will be discarded.
You can get around this by using the Feathers client directly.  It doesn’t make sense to use Feathers-Vuex for something that’s not going to be stored in Vuex.


Update scalafmt-core to 2.7.5

Updates org.scalameta:scalafmt-core from 2.5.3 to 2.7.5.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

labels: library-update, semver-minor

Codecov Report

Merging #21 (4be5fb3) into master (e10a5c1) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 4be5fb3 differs from pull request most recent head fc2f329. Consider uploading reports for the commit fc2f329 to get more accurate results

@@           Coverage Diff           @@
##           master      #21   +/-   ##
=======================================
  Coverage   31.78%   31.78%
=======================================
  Files          17       17
  Lines         258      258
  Branches        6        6
=======================================
  Hits           82       82
  Misses        176      176

Impacted Files
Coverage Δ

...igusr/mqtt/impl/frames/ConnectVariableHeader.scala
100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e10a5c1...fc2f329. Read the comment docs.


Installer: DigitalOcean apt-get install hangs waiting for input

When creating a new cluster in DigitalOcean, the installer will hang when apt-get install -y iptables-persistent throws a modal dialog, asking to save the default/blank ipv4 (and later ipv6) rules.
INFO[09-16|16:09:53] Event: log: Running `apt-get install -y iptables-persistent

iptables -A FORWARD -s x.x.x.x -j ACCEPT

iptables -A FORWARD -i eth0 -m conntrack --ctstate ESTABLISHED,RELATED -j ACCEPT
iptables -A FORWARD -i eth0 -p tcp --dport 80 -j ACCEPT
iptables -A FORWARD -i eth0 -p tcp --dport 443 -j ACCEPT
iptables -A FORWARD -i eth0 -p tcp --dport 22 -j ACCEPT
iptables -A FORWARD -i eth0 -p icmp --icmp-type echo-request -j ACCEPT
iptables -A FORWARD -i eth0 -j DROP
/etc/init.d/iptables-persistent save
` on x.x.x.x
INFO[09-16|16:09:55] Event: log: Reading package lists...
INFO[09-16|16:09:56] Event: log: Building dependency tree...
INFO[09-16|16:09:56] Event: log: Reading state information...
INFO[09-16|16:09:56] Event: log: The following NEW packages will be installed:
INFO[09-16|16:09:56] Event: log:   iptables-persistent
INFO[09-16|16:09:56] Event: log: 0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
INFO[09-16|16:09:56] Event: log: Need to get 10.2 kB of archives.
INFO[09-16|16:09:56] Event: log: After this operation, 62.5 kB of additional disk space will be used.
INFO[09-16|16:09:56] Event: log: Get:1 http://mirrors.digitalocean.com/ubuntu/ trusty/universe iptables-persistent all 0.5.7 [10.2 kB]
INFO[09-16|16:09:56] Event: log: debconf: unable to initialize frontend: Dialog
INFO[09-16|16:09:56] Event: log: debconf: (TERM is not set, so the dialog frontend is not usable.)
INFO[09-16|16:09:56] Event: log: debconf: falling back to frontend: Readline
INFO[09-16|16:09:56] Event: log: debconf: unable to initialize frontend: Readline
INFO[09-16|16:09:56] Event: log: debconf: (This frontend requires a controlling tty.)
INFO[09-16|16:09:56] Event: log: debconf: falling back to frontend: Teletype
INFO[09-16|16:09:56] Event: log: dpkg-preconfigure: unable to re-open stdin:
INFO[09-16|16:09:56] Event: log: Fetched 10.2 kB in 0s (48.9 kB/s)
INFO[09-16|16:09:56] Event: log: Selecting previously unselected package iptables-persistent.
INFO[09-16|16:09:56] Event: log: (Reading database ... 86793 files and directories currently installed.)
INFO[09-16|16:09:56] Event: log: Preparing to unpack .../iptables-persistent_0.5.7_all.deb ...
INFO[09-16|16:09:56] Event: log:  Removing any system startup links for /etc/init.d/iptables-persistent ...
INFO[09-16|16:09:56] Event: log: Unpacking iptables-persistent (0.5.7) ...
INFO[09-16|16:09:56] Event: log: Processing triggers for ureadahead (0.100.0-16) ...
INFO[09-16|16:09:56] Event: log: Setting up iptables-persistent (0.5.7) ...
INFO[09-16|16:09:57] Event: log: debconf: unable to initialize frontend: Dialog
INFO[09-16|16:09:57] Event: log: debconf: (TERM is not set, so the dialog frontend is not usable.)
INFO[09-16|16:09:57] Event: log: debconf: falling back to frontend: Readline
INFO[09-16|16:09:57] Event: log: debconf: unable to initialize frontend: Readline
INFO[09-16|16:09:57] Event: log: debconf: (This frontend requires a controlling tty.)
INFO[09-16|16:09:57] Event: log: debconf: falling back to frontend: Teletype
INFO[09-16|16:09:57] Event: log: Configuring iptables-persistent
INFO[09-16|16:09:57] Event: log: -------------------------------
INFO[09-16|16:09:57] Event: log:
INFO[09-16|16:09:57] Event: log: Current iptables rules can be saved to the configuration file
INFO[09-16|16:09:57] Event: log: /etc/iptables/rules.v4. These rules will then be loaded automatically during
INFO[09-16|16:09:57] Event: log: system startup.
INFO[09-16|16:09:57] Event: log:
INFO[09-16|16:09:57] Event: log: Rules are only saved automatically during package installation. See the manual
INFO[09-16|16:09:57] Event: log: page of iptables-save(8) for instructions on keeping the rules file up-to-date.
INFO[09-16|16:09:57] Event: log:
INFO[09-16|16:12:04] Event: log: Save current IPv4 rules?

We probably need to export DEBIAN_FRONTEND=noninteractive.


Add AvgExpr as a BinaryExpression implementation

Right now the BinaryExpr get interpreted as BooleanExpression exclusively.
This needs to be changed so that a BinaryExpr can also be of other types, like AverageExpression, going forward.
The problem with BooleanExpression is the fact only returns a bitmap of what rows to keep but doesn't allow to change (in the average case merge columns) in the record.
https://github.com/polarsignals/frostdb/blob/cbce8509f8bd0b3880774627ff4f8cfe5335c029/query/physicalplan/filter.go#L42

I've started implementing addition and multiplication as projections.
Next, I'll tackle subtraction and division before adding the average back.
They'll probably move out of the existing Binaryexpr and into an ArithmeticExpr struct that doesn't have to implement the Eval method and only uses the Project.

Arithmetic operations should be able to done on any arbitrary source, not just on physical columns. I think keeping that is important.

Next to columns and scalars, what arbitrary sources do you have in mind?


 Seems wise to guard against?

Sure; thank you!


2.4 Processor configuration clarification

Section 2.4 on processor configuration is unclear.  There are two orthogonal issues.  One is that a configurable implementation has to have its options specified before it can be used.  The second is that the compliance test framework has to be told what features to test.  The compliance test should only cover a subset of the configuration's supported features.  This implementation configuration belongs in the target environment section, as it is part of selecting the target to be tested. This section 2.4 should be about the compliance test configuration, indicating how to instruct it to test a certain set of features.

I think this has been addressed in Pull#65, which is the "next generation" test format spec. This is currently undergoing review and is intended to match the riscof framework. There is a DUT spec, and a Target spec. The intent is to test all features in the DUT that are ]required for the target (e.g.platform). The "default" case is that the target is simply RV32i, so no options required.

@allenjbaum since the test-format-spec has been frozen can we close this?

Yes,  all these issues have been addressed in testformatspec v1.2.5

So, effectively fixed by pull#65


Large number of command buffer aborts

I'm having a lot of problems with GPU errors from my game application and unit test apps which use Vukan via MoltenVK.  These apps pass validation, but at runtime issue a handful of "GPU timeout" errors (IOAF code 2) followed by a ton of "ignored for causing prior/excessive GPU errors" (IOAF code 4).
These errors happen fairly reliably (maybe 80% of the time) in my unit test application, but the exact timing of them varies from run to run.
I found this issue which had similar problems, but it's been marked as closed and I'm already on the version of MoltenVK from the latest Vulkan SDK which appears to be 1.0.39.  That issue also had quite a bit of back-and-forth with different options, so it's not clear to me what from that thread is still valid and what I should try.
Could I get some guidance on how to figure out what might be going wrong here?  I can report back any results that I discover.
Thanks!

I should also note that these applications run correctly on other non-MVK platforms.

You're not running with MVK_ALLOW_METAL_EVENTS=true, are you? If not, then I'm afraid we'll need more information. Can you provide us with something that reproduces the problem?

I don't believe that I am running with that option.  I'm on the Mac (though i believe this happens on iOS also), and I'm not doing anything other than including "vk_mvk_moltenvk.h" and linking to the static libMoltenVK.a from VulkanSDK 1.1.130.
I can't post the source because even our unit tests require too much of our game engine.  Is there a version of vktrace that runs on the Mac?  It doesn't look like the SDK includes one.  Let me know what other options you might have in mind.


SOS namespace addition

Adds the 'sa' namespace for handling SOS data.  An example from a GetObservation request:
<om:featureOfInterest xlink:title="my_sensor_id">
    <sa:SamplingPoint gml:id="my_sensor_id">
        <sa:sampledFeature xlink:href="urn:ogc:def:nil:OGC:unknown"/>
        <sa:position>
            <gml:Point gml:id="point_sf_42">
                <gml:pos srsName="urn:ogc:def:crs:EPSG::4326">15.751542 18.280503</gml:pos>
            </gml:Point>
        </sa:position>
    </sa:SamplingPoint>
</om:featureOfInterest>

@gamesbook any chance we can add a test or two?

Hi Tom
I have added a namespace test (but cannot get it to pass locally).
I am not sure where to add a test for the GetObservation request patch?  If you can point me in the right direction, I will attempt to do so.
Derek

Hi Derek: thanks.  FYI I ended up merging this manually as there some merge issues and adding some SOS 2 compatibility.
To add a test case, you can either add a test file like https://github.com/geopython/OWSLib/blob/master/tests/doctests/sos_ngmp.txt or add to an existing test case.  Then feel free to issue another PR.

Thanks Tom!  Sorry - I have been away for a month.


Folder select feature

added userHomeDirectory service - returns user home folder
added the above service to the api.js
removed hardcoded tmp_path variable
created openProject function
created openFolder function
created getFolder function - returns desired folder once and binds it to the correct tree model
refactored home.html trees to work with the new models + hide/show the trees when needed
selecting file bind it to the code editor model

As discussed f2f, change folderVariable into a callback function.

Comments from the review on Reviewable.io

public/app/controllers/mainCtrl.js, line 64 [r4] (raw file):
Should these two lines be here?
$scope[folderVariable] = res.data;
console.log('got res: ' + res);

Comments from the review on Reviewable.io

Comments from the review on Reviewable.io

Reviewed 1 of 4 files at r1, 3 of 6 files at r2, 1 of 4 files at r3, 2 of 3 files at r4, 1 of 1 files at r5.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from the review on Reviewable.io

Comments from the review on Reviewable.io


User info roles field name

This builds on and fixes the initial approach from https://github.com/glatzert/go-authcrunch/commit/8de8c6b3551f74243df07c1f6d083a88974cbb14 to add a new configuration directive to specify the name of the "roles" claim.
Requires https://github.com/greenpau/caddy-security/pull/218

Done.


Is there any way to use Protocols like Jason.encode with Livebook?

Environment

Elixir & Erlang/OTP versions (elixir --version):

Erlang/OTP 23 [erts-11.2.2] [source] [64-bit] [smp:4:4] [ds:4:4:10] [async-threads:1] [hipe] [dtrace]

Elixir 1.12.0 (compiled with Erlang/OTP 23)

Operating system: MacOS 10.14.6
How have you started Livebook (mix phx.server, livebook CLI, Docker, etc):  Initially livebook server, I also tried mix phx.server
Livebook version (use git show if running with mix): 0.2.2, commit d20d4f6bf123d58e4666c064027b55e3b300702f with mix (current latest)
Browsers that reproduce this bug (the more the merrier): Chrome, Safari, Firefox
Include what is logged in the browser console: Nothing when the warning/error are triggered
Include what is logged to the server console: Nothing when the warning/error are triggered

Current behavior
Install Jason:
Mix.install([
  {:jason, "~> 1.2"}
])

Create a struct and try to add a Jason.Encode implementation for it:
defmodule ZoneEvent do
  @derive Jason.Encoder
  @enforce_keys [:timestamp, :project, :zone, :value]
  defstruct [:timestamp, :project, :zone, :value]
end

When executing the cell with the above module I get a warning:
warning: the Jason.Encoder protocol has already been consolidated, an implementation for ZoneEvent has no effect. If you want to implement protocols after compilation or during tests, check the "Consolidation" section in the Protocol module documentation
  /Users/callum/projects/livebooks/graphjson-playground.livemd#cell:4: ZoneEvent (module)

As the error says, the implementation has no effect and an attempt to use Jason.encode on a ZoneEvent object errors:
** (Protocol.UndefinedError) protocol Jason.Encoder not implemented for %ZoneEvent{project: "hr_zones_prod_v1", timestamp:<PHONE_NUMBER>, value: 0.0, zone: "Easy (A)"} of type ZoneEvent (a struct), Jason.Encoder protocol must always be explicitly implemented.

Expected behavior
It'd be great if the @derive Jason.Encoder worked correctly and I'd be able to convert my objects to JSON within the livebook.
I read the section of docs referenced by the warning: https://hexdocs.pm/elixir/1.12/Protocol.html#module-consolidation
As the docs indicate I tried adding consolidate_protocols: false to the def project:
  def project do
    [
      app: :livebook,
      ...,
      consolidate_protocols: false
    ]
  end

This doesn't seem to have made any difference, and doesn't sound like it'd be a great fix anyway from the docs. Is there any workaround for this?

You can pass consolidate_protocols: false to Mix.install:
first cell:
Mix.install [:jason], consolidate_protocols: false

defmodule Person do
  @derive Jason.Encoder
  defstruct [:name]
end

second cell:
IO.puts Jason.encode_to_iodata!(%Person{name: "Alice"})

{"name":"Alice"}

@wojtekmach Thankyou, that worked perfectly! :)


Support iOS 13 Modal Presentation Style

Can using ios 13 stack type route transition with GetPageRoute, which is looks like as,

Another library modal_bottom_sheet implement this feature, but cannot work well with getx.  It uses CupertinoModalBottomSheetRoute,  while getx uses GetPageRoute.

I would love this feature too. I previously looked at this package as well but could not see how to implement properly with getx

Just wrap your view with CupertinoScaffold on GetPage, and use CupertinoScaffold.showCupertinoModalBottomSheet to show bottom sheet

@liasica Could you provide us a working example?


add get notif by id

Summary by CodeRabbit

New Features

Implemented a feature to fetch specific notifications by ID via GraphQL queries, provided they are active.

This is just a test PR.
We can close this.


[TFTRT] Renaming ParameterizedOpConverterTest classes to a more explicit name

@tfeher @bixia1  for review.
After a chat with @tfeher we agreed that the names OpConverterTest1, OpConverterTest2 and OpConverterTest3 are unfortunate and make the test code base difficult to read.
I propose to rename them as follows:

OpConverterTest1 => OpConverterDynamicShape_FP32_Test
OpConverterTest2 => OpConverterDynamicShape_FP32_FP16_Test
OpConverterTest3 => OpConverterDynamicShape_FP32_FP16_INT8_Test

The names are a bit longer, but at least it's more easy to understand what they represent.
Feel free to give me any feedback

Sounds fair with me. @tfeher what do you think ? If you agree, I'll push Bixia's recommendation

I will take @tfeher and @bixia1 comments into account and resubmit. Expect the update today ;)

You missed the first comment in https://github.com/tensorflow/tensorflow/pull/45587#pullrequestreview-549693611. I will try to make this change myself.


Content Publishing - Pattern (08 Callout - with media)

User Story

As an IBM.com Library pattern adopter,

I need a way to learn more about the (Name of the Pattern here) pattern

so that I can utilize the pattern to my day to day work.

Additional information

Take a look at the storybook - so you know how the pattern works.   You will also use Storybook as a reference to accurately include the images in the Sketch file.
Download this Sketch template to your machine to make the updates. Name the Sketch file with the following convention: Name of the pattern + version. ex: Feature card block v1.0
Use the pattern description included in the Patterns Overview Box Note - for the 'Intro' section of the newly downloaded Sketch file
Navigate to the visual spec file within this Patterns Box folder - The image that works successfully for most patterns is the 1312px image.  Adjustments may be needed to have this image accurately reflect the Storybook designs.
Once complete, save the revised Sketch file in the Layout Pattern folder / sub-folder here.
Export the individual images with a 2X setting, saving them into the Layout Pattern sub-folder that contains the Sketch file.  These exported images will be used when creating the Markdown for publishing
Use this Sketch file to create the Markdown version of the web page in Github.

Find the .mdx file for the Layout Pattern assigned
Copy the content from the Sketch file into the .mdx file
Once complete, create the Pull Request and review, using the Preview link, to be sure it matches the Sketch file design
When ready to deploy, include Jenny as a PR Reviewer and Approver.
Jenny will review and merge the PR

Acceptance criteria

[x] Content crafting is done.
[x] Asset image creation is done.
[x] Page design is done.
[x] Publishing with markdowns is done.
[ ] QA'd by Jenny
[ ] Web page preview is approved by Linda, Jeff and Wonil
[ ] Web page is published

Already through a few rounds of comments by Jenny and Lara, on Invision.  Waiting for latest input, before moving into markdown:
https://ibm.invisionapp.com/share/CPO0AUAEK79#/319643584_Pattern_-_Callout_-_With_Media

@wonilsuhibm This one is ready for your review.  Lara and Jenny have inputted already, with various changes made via Invision and Sketch.
Jacob helped with markdown on this one, as I have not yet learned it. I will try to handle changes you suggest, if any.
https://github.com/carbon-design-system/ibm-dotcom-library-website/pull/565
cc @JennySanchez

@sethibm Hmmm, i'm getting 404 error. Can you check please?

@wonilsuhibm Oops, it's working now, can check?
PR:
https://github.com/carbon-design-system/ibm-dotcom-library-website/pull/565
Latest link:
https://ibmdotcom-library.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/565/index.html

Thank you for the quick response. Looking good! Let's merge it?


Update alerts-queue.md

Updated the number of days by default the queue displays alerts seen
Fixes https://github.com/MicrosoftDocs/microsoft-365-docs/issues/13106

@JohanFreelancer9 Please copy review

@mjcaparas Please merge this PR. Thanks

@diannegali can you check that this is correct?

Confirming that the update is correct. Merging this PR.


[ATIP] Update environment.py support in README.md

Add specific environment.py for uiautomator only tests to eliminate dependency from WebDriver

@zqzhang, PTAL.

Thanks for your comments, updated.


Get rid of mapbox.mapboxsdk & Mapbox in package names and identifiers

Scope of this bounty:

Make sure end-users of the Android library don't need to import packages containing mapbox in the name.
Make sure end-users of the Android library don't need to import any variables with mapbox / Mapbox in the name.
CHANGELOG should be updated (including migration guide).
Tests should pass. The library should be in a releasable state.

E.g.
import com.mapbox.mapboxsdk.geometry.LatLng

Should become (suggested)
import org.maplibre.native.geometry.LatLng

And import com.mapbox.mapboxsdk.Mapbox -> import org.maplibre.native.MapLibre
import com.mapbox.mapboxsdk.maps.MapboxMap -> import org.maplibre.native.maps.MapLibreMap
Etc.
I think automated tools can do most of the heavy lifting for this issue, so the M bounty is an estimate. It is negotiable before the ticket has been accepted if you think it is the estimate is off.
This is a bounty towards the Modernization bounty direction. https://github.com/maplibre/maplibre/issues/270
Relevant discussion https://github.com/maplibre/maplibre-native/discussions/318

I begun work on this issue this week. Probably because there's so many renamings, the refactorer has unfortunately produced a lot of bad results that I'm fixing manually right now.

@fynngodau what have you used as the main package of the library?

@ovivoda Per discussion on Slack, org.maplibre.android (native is not a valid package name)

This bounty can be paid out.

Invoice: https://opencollective.com/maplibre/expenses/143826


fix: remove line breaks that appear to be in middle of sentences

Summary
In the source data, there are description records that seem to be copy and paste entries from a PDF or other program that created line breaks in the middle of sentences (likely the end of the line when displayed in the original program). Examples are for trainings 1663 and 9381.
This change removes line breaks if they are the only thing between two alphabetical characters. While there are some false matches, the overall result does look better.
Addresses NJWE-29.
Test plan
Start locally and then compare

http://localhost:3000/training/9381 to https://training.njcareers.org/training/9381; and
http://localhost:3000/training/1663 to https://training.njcareers.org/training/1663

Before

After

Tried a few other options, but anything more than the regex ([A-Za-z])\n([A-Za-z]) was creating too many false positives and removing new lines that should be there. Absent a ML model trained to remove the new lines, I think this regex is probably the best balance between removing unnecessary new lines and keeping those that should be there.


test with pre-installed libpcsclite1 package

Signed-off-by: Batuhan Apaydın<EMAIL_ADDRESS>
based on the conversation in PR #15
https://github.com/sigstore/cosign-installer/pull/15#pullrequestreview-732782575

@hectorj2f WDYT, can you please take another look? 🙏