The concept

Hi.
I've found your library when was looking for an embedded file system solution.
However, fast code scan didn't reveal the concept to me.
Can you please describe briefly how you process binary data, store it, and then read it back from an executable?
Thanks.

Hi!
Have you seen this post in stackoverflow: cpp_rsc Something from your request is described there. Also you can clone the program and check the example.
The program consist of two parts:

A program, which creates a C/C++ files (header+source) with static variables of binary data from resource files. So, compare to the other solutions, it is working on compile, but not linking stage. Therefore it is better compatible with different compilers, platforms, compiler options etc.
CMake files, which integrates the program to CMake scripts.

About your question:

"process binary data" - read input file binary and store it in C/C++ source file as binary byte array. The data can have hex or char representation.
"store it" - the data stores like a static variable. The details depends on platform, compiler etc.
To read it back, you just need to loop through the array. For C++ you can use it like a stream also. You will need a special rdbuf for this. If you set text flag, for resource compiling, you can use the variable like a C style sting (null terminated array of char).

This is a brief description. Feel free to ask any details.


[Question]: How to hide logs

Issue guidelines

[X] I've read the Issue Guidelines and wholeheartedly agree.

Issue Checklist

[X] I have searched open or closed issues for my problem and found nothing related or helpful.
[X] I have read the Documentation and found nothing related to my problem.
[X] I have gone through the Bonus Examples and FAQs and found nothing related or helpful.

Describe your Question
Hi, I'm integrating node js + python.
I use python with StreamGear to convert video, so in nodejs how is the logs returned by python being read?
It's difficult for me since StreamGear is giving a lot of logs.
I already have: logging=False
but it still doesn't work.
Terminal log output(Optional)
No response
Python Code(Optional)
No response
VidGear Version
0.3.3
Python version
3.12.2
Operating System version
Ubuntu 20
Any other Relevant Information?
No response

@juniorcines What logs? Could you give an example?

Closing this for missing information. Feel free to re-open this once you have the all the required evidences. Thanks.


How would I implement the blas operation SSCAL (multiply vector by scalar)?

This is just a question of me learning and asking for help with this.
Seeing the example compute code given in the tutorial it multiplies every value in a given array by 12 (as written into the glsl):
mod cs {
    vulkano_shaders::shader!{
        ty: "compute",
        src: "
        #version 450

        layout(local_size_x = 64, local_size_y = 1, local_size_z = 1) in;

        layout(set = 0, binding = 0) buffer Data {
            uint data[];
        } buf;

        void main() {
            uint idx = gl_GlobalInvocationID.x;
            buf.data[idx] *= 12;
        }"
    }
}

How can I modify this and the rest of the example code to multiply every value in an array by a given value (replacing 12 with some x)?
In a more general sense, how do you pass multiple variables/buffers?
(Apologies about this question being bit dumb, I can't seem to find any good examples).
Current project simply implementing compute tutorial code: vulkano-test.zip

So I think I've made some progress but I'm still a bit stuck.
I have rewritten the GLSL code:
mod sscal {
    vulkano_shaders::shader!{
        ty: "compute",
        src: "
        #version 450

        layout(local_size_x = 64, local_size_y = 1, local_size_z = 1) in;

        layout(set = 0, binding = 0) buffer Buffer {
            uint x[];
        };
        layout(set = 0, binding = 1) uniform UniformBuffer {
            uint a;
        };

        void main() {
            uint indx = gl_GlobalInvocationID.x;
            x[indx] *= a;
        }"
    }
}

I create 2 buffers:
let data_iter = 0..5u16;
let data_buffer = CpuAccessibleBuffer::from_iter(device.clone(), BufferUsage::all(), false,data_iter).expect("failed to create buffer");
let val = 2u16;
let val_buffer = CpuAccessibleBuffer::from_data(device.clone(),BufferUsage::uniform_buffer(),false,val).expect("failed to create buffer");

Now at this point my first area of issue comes up, when trying to read data_buffer the following code works:
let content = data_buffer.read().unwrap();
for (i, a) in content.iter().enumerate() {
    println!("{} | {}",i,a);
}

Outputting:

0 | 0
1 | 1
2 | 2
3 | 3
4 | 4

When trying to run the exact same code but replacing data_buffer for val_buffer it does not work. Resulting in the compilation error:

So to try and see the data another way I did println!("{:.?}",val_buffer); in looking at the output:
CpuAccessibleBuffer { inner: <Vulkan buffer<PHONE_NUMBER>064>, memory: Generic(StdMemoryPoolAlloc { inner: HostVisible(StdHostVisibleMemoryTypePoolAlloc { pool: StdHostVisibleMemoryTypePool { device: <Vulkan device<PHONE_NUMBER>864>, memory_type: 1, occupied: Mutex { data: [(MappedDeviceMemory(DeviceMemory { device: <Vulkan device<PHONE_NUMBER>864>, memory_type: MemoryType { physical_device: PhysicalDevice { instance: <Vulkan instance<PHONE_NUMBER>816>, device: 0 }, id: 1 }, size: 8388608 }), [0..16, 16..32])] } }, memory: MappedDeviceMemory(DeviceMemory { device: <Vulkan device<PHONE_NUMBER>864>, memory_type: MemoryType { physical_device: PhysicalDevice { instance: <Vulkan instance<PHONE_NUMBER>816>, device: 0 }, id: 1 }, size: 8388608 }), offset: 16, size: 16 }), pool: StdMemoryPool { device: <Vulkan device<PHONE_NUMBER>864>, pools: Mutex { data: {(1, Linear, Map): HostVisible(StdHostVisibleMemoryTypePool { device: <Vulkan device<PHONE_NUMBER>864>, memory_type: 1, occupied: Mutex { data: [(MappedDeviceMemory(DeviceMemory { device: <Vulkan device<PHONE_NUMBER>864>, memory_type: MemoryType { physical_device: PhysicalDevice { instance: <Vulkan instance<PHONE_NUMBER>816>, device: 0 }, id: 1 }, size: 8388608 }), [0..16, 16..32])] } })} } } }), access: RwLock { data: NonExclusive { num: 0 } }, queue_families: [], marker: PhantomData }
I see data: NonExclusive { num: 0 } which seems odd.
I setup the shader, compute pipeline, descriptor set and command buffer as such:
let shader = sscal::Shader::load(device.clone()).expect("failed to create shader module");

let compute_pipeline = Arc::new(ComputePipeline::new(device.clone(), &shader.main_entry_point(), &())
        .expect("failed to create compute pipeline"));

let layout = compute_pipeline.layout().descriptor_set_layout(0).unwrap();
let set = Arc::new(PersistentDescriptorSet::start(layout.clone())
    .add_buffer(data_buffer.clone()).unwrap()
    .add_buffer(val_buffer.clone()).unwrap()
    .build().unwrap()
);

let mut builder = AutoCommandBufferBuilder::new(device.clone(), queue.family()).unwrap();
builder.dispatch([1,1,1],compute_pipeline.clone(),set.clone(),()).unwrap();
let command_buffer = builder.build().unwrap();

I then submit the command buffer:
let finished = command_buffer.execute(queue.clone()).unwrap();
finished.then_signal_fence_and_flush().unwrap()
        .wait(None).unwrap();

Then output the data buffer after running:
let content = data_buffer.read().unwrap();
for (i, a) in content.iter().enumerate() {
    println!("{} | {}",i,a);
}

Which now outputs:
0 | 0
1 | 0
2 | 0
3 | 0
4 | 4

I'm really grasping at straws for why this result occurs.
Doing a bit of experimentation and changing the line in GLSL from x[indx] *= a; to x[indx] = a + 1; results in the out:
0 | 1
1 | 0
2 | 1
3 | 0
4 | 4

Now I really have no idea what is going on here.
While I've made a bit of progress, I'm still at a loss for what I'm doing, I would greatly appreciate any help.

It looks like you might want to use https://www.khronos.org/registry/vulkan/specs/1.2-extensions/man/html/vkCmdPushConstants.html. Vulkan documentation here: https://www.khronos.org/registry/vulkan/specs/1.2-extensions/man/html/vkCmdPushConstants.html
On usage, see these slides: http://web.engr.oregonstate.edu/~mjb/vulkan/Handouts/PushConstants.1pp.pdf
I haven't used Vulkan before, but it looks like you might need to do:
layout( push_constant ) uniform multiplier{float x;} Multiplier;
...

Solved.
GLSL code:
mod sscal {
    vulkano_shaders::shader!{
        ty: "compute",
        src: "
        #version 450

        layout(local_size_x = 64, local_size_y = 1, local_size_z = 1) in;

        layout(set = 0,binding = 0) buffer Buffer {
            uint x[];
        };
        layout(push_constant) uniform PushConstantData {
            uint a;
        };

        void main() {
            uint indx = gl_GlobalInvocationID.x;
            x[indx] *= a;
        }"
    }
}

Rust code:
let data_iter = 0..24u32;
let data_buffer = CpuAccessibleBuffer::from_iter(device.clone(), BufferUsage::all(), false,data_iter).expect("failed to create buffer");
let push_constant = 2u32;

let shader = sscal::Shader::load(device.clone()).expect("failed to create shader module");

let compute_pipeline = Arc::new(ComputePipeline::new(device.clone(), &shader.main_entry_point(), &())
.expect("failed to create compute pipeline"));

let layout = compute_pipeline.layout().descriptor_set_layout(0).unwrap();
let set = Arc::new(PersistentDescriptorSet::start(layout.clone())
    .add_buffer(data_buffer.clone()).unwrap()
    .build().unwrap()
);

let mut builder = AutoCommandBufferBuilder::new(device.clone(), queue.family()).unwrap();
builder.dispatch([1024,1,1],compute_pipeline.clone(),set.clone(),push_constant).unwrap();

let command_buffer = builder.build().unwrap();

let finished = command_buffer.execute(queue.clone()).unwrap();

finished.then_signal_fence_and_flush().unwrap()
.wait(None).unwrap();

println!();
let content = data_buffer.read().unwrap();
for (i, a) in content.iter().enumerate() {
    println!("{} | {}",i,a);
}


github marketplace action?

Is there any plan to add a markdownlint-cli2 action to gh marketplace?

I'll look into it.

I'll look into it.

I may have something basic to share in a couple of days.

I may have something basic to share in a couple of days.

I would second this! An image pushed to DockerHub would also be amazing for local workflows. We use:
@$(DOCKER) run -v $(CURDIR):/repo -w /repo thegeeklab/markdownlint-cli docs

For markdownlint, but would like to migrate to v2.

I would second this! An image pushed to DockerHub would also be amazing for local workflows. We use:
@$(DOCKER) run -v $(CURDIR):/repo -w /repo thegeeklab/markdownlint-cli docs

For markdownlint, but would like to migrate to v2.

@jpreese Please open a separate issue for Docker. I have no Docker experience, so if you want to PR something (maybe based on CLI1's existing support for this), that would be helpful!

@jpreese Please open a separate issue for Docker. I have no Docker experience, so if you want to PR something (maybe based on CLI1's existing support for this), that would be helpful!

@naseemkullah I haven’t had power all day, so I did about half of this on an iPad pushing somewhat blindly, but I think it should work. Give it a try?
https://github.com/marketplace/actions/markdownlint-cli2-action

@naseemkullah I haven’t had power all day, so I did about half of this on an iPad pushing somewhat blindly, but I think it should work. Give it a try?
https://github.com/marketplace/actions/markdownlint-cli2-action

I plan to give it a go over the weekend! Thanks!!

I plan to give it a go over the weekend! Thanks!!

Seems to be working !
nit I would make the example in the marketplace doc more complete:
jobs:
  lint:
    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v2

      - name: Lint markdown files
        uses: DavidAnson/markdownlint-cli2-action@v1
        with:
          globs: "README.md"

Seems to be working !
nit I would make the example in the marketplace doc more complete:
jobs:
  lint:
    runs-on: ubuntu-latest

    steps:
      - uses: actions/checkout@v2

      - name: Lint markdown files
        uses: DavidAnson/markdownlint-cli2-action@v1
        with:
          globs: "README.md"

The way it is now is how GitHub does this (see docs for checkout, mostly). But I'll add an example YAML and link to it for the context you want. Thanks!

The way it is now is how GitHub does this (see docs for checkout, mostly). But I'll add an example YAML and link to it for the context you want. Thanks!

@jpreese , you might be interested to know that #27  addressed your request, markdownlint-cli2 is now available as a container image in Docker Hub


Open ID option missing in Live Mauro instance

On the Live instance of Mauro the option to configure 'Open ID' is missing, so we're unable to setup SSO.
https://mauro.dataproducts.nhs.uk/

Thanks @pjmonks . That's now setup.


CLOUD-2083 JDV64 templates

Changes need to be made:
"value": "datavirt/dynamicvdb-datafederation/app" needs to be changed to the new datavirt4/.... directory. The new JDV 6.4 quickstart will need to have a new directory, so that JDV 6.3 isn't corrupted.
Also, not sure why the ModeShape username/passwords setting were removed.

This PR is no longer valid, the templates have been moved.


Idea: gRPC plugin

It's a very common use-case to use GraphQL as a gateway (as opposing to a GraphQL monolith/service) in front of other services (e.g. gRPC, Thrift, ...). I'd like to explore the possible workflows of using graphqlgen to auto-generate/auto-scaffold resolvers mapping to gRPC services.
My current idea would be to create a scaffolding plugin (see #84) which instead of scaffolding a resolver that throws an error, actually scaffolds a runnable resolver that calls out to the corresponding gRPC service.
The needed configuration/mapping could either be provided via some namespace in graphqlgen.yml or partially in the application schema via schema directives. Here's an idea how the config could look like in the graphqlgen.yml
# ...

resolver-scaffolding:
  output: ./src/generated/tmp-resolvers/
  layout: file-per-type
  plugins:
    grpc:
      input: ./my-service.proto
      resolvers:
        Query:
          feed: GetPosts
        Mutation:
          createDraft: NewDraft

Related: https://github.com/99designs/gqlgen/issues/228
Open Questions

[ ] What should be the plugin/config "input"? Do we assume there's already a generated TS gRPC client or is it the responsibility to also generate one (including the resulting model type definitions) based on a .proto file?

We are considering something similar for gqlgen.
A few things I would love to see:

ability to bind to multiple servers is pretty much a must for this kind of stitching server IMO
some way for users to pass in their own clients, so they can handle their own authentication, tracing, etc.
directives on fields that let you skip wiring in config, eg cake: Cake @grpc(method:"EatCake", server: "cheescake-shop")

Some open questions:

do the types from the grpc server get turned into an actual schema file somewhere? How best to make this intuitive for people coming in cold to make a small change to an existing codebase?
If schema does get generated first, enums could even be generated for the methods / servers available.
should gg call pprotoc for you? (at 99 all of our clients are generated when the downstream apps merge, and are pushed to a shared repo, so this wouldn't be super useful and kinda tricky to do well IMO)


⬆ Sylius 1.12

Small up here to support version 1.12 of sylius :)

Hello @oallain !
No problem, I hadn't seen this comment :D
We needed it for a project, we will wait for the famous push! Sorry for the inconvenience


[waybar] Adding forgotten memory text color

I think you forgot to add the text color for the memory in the waybar stylesheet :stuck_out_tongue: !

Yes i totally did! Thank you!


Persist query param upon login redirect

This PR contains fix for the bug where on login page, if sign-in redirect button is clicked, it lost query param context.

Bug is fixed by manually passing the query param on Link component.

LGTM


0.29.0

Codecov Report

Merging #386 into master will increase coverage by 0.06%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #386      +/-   ##
==========================================
+ Coverage   92.93%   92.99%   +0.06%
==========================================
  Files          86       86
  Lines       16922    17027     +105
==========================================
+ Hits        15727    15835     +108
+ Misses       1195     1192       -3

Impacted Files
Coverage Δ

src/main.rs
87.5% <ø> (+1.78%)
:arrow_up:

src/makers.rs
100% <ø> (ø)
:arrow_up:

src/lib/descriptor/mod_test.rs
96.03% <ø> (ø)

src/lib/installer/cargo_plugin_installer.rs
83.52% <100%> (+1.02%)
:arrow_up:

src/lib/installer/crate_installer.rs
93.33% <100%> (+0.31%)
:arrow_up:

src/lib/types.rs
84.78% <20%> (-0.33%)
:arrow_down:

src/lib/environment/crateinfo.rs
90.38% <64%> (-5.04%)
:arrow_down:

src/lib/environment/mod.rs
91.4% <88.88%> (+0.58%)
:arrow_up:

src/lib/descriptor/mod.rs
90.66% <90.56%> (ø)

src/lib/installer/cargo_plugin_installer_test.rs
93.82% <93.75%> (-0.21%)
:arrow_down:

... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2620e2...2b28350. Read the comment docs.


New onDirectUpdate callback triggerered on render

It seems that the new onDirectUpdate callback added in https://github.com/plotly/react-chart-editor/pull/749 is executed on render as well as on direct manipulation of the plot.
The JupyterLab extension currently registers an onUpdate callback that is executed when the user manipulates the figure using the React widgets. This callback is used to set the state of the extension's ChartEditor component.
I tried to register the same callback function with the new onDirectUpdate property and ended up in an infinite loop.  I think what's happening is that  rendering PlotlyEditor is triggering the onDirectUpdate callback, which then calls setState, which then causes another render, and on and on.
Please let me know if I'm misunderstanding something here about the intended use of onDirectUpdate. But I'm wondering if it would be possible for onDirectUpdate to not execute on the initial render, and only in response to mouse interactions.
Or alternatively, should the onDirectUpdate callback function not be calling setState at all? Because the plotly figure was already updated internally?
Thanks!

Ah yeah I hadn’t thought about that... probably you shouldn’t use this to
set state and I should rename it onRender :)
On Mon, Oct 1, 2018 at 20:16 Jon Mease<EMAIL_ADDRESS>wrote:

It seems that the new onDirectUpdate callback added in #749
https://github.com/plotly/react-chart-editor/pull/749 is executed on
render as well as on direct manipulation of the plot.
The JupyterLab extension currently registers an onUpdate callback that is
executed when the user manipulates the figure using the React widgets. This
callback is used to set the state of the extension's ChartEditor
component.
I tried to register the same callback function with the new onDirectUpdate
property and ended up in an infinite loop. I think what's happening is
that rendering PlotlyEditor is triggering the onDirectUpdate callback,
which then calls setState, which then causes another render, and on and
on.
Please let me know if I'm misunderstanding something here about the
intended use of onDirectUpdate. But I'm wondering if it would be possible
for onDirectUpdate to not execute on the initial render, and only in
response to mouse interactions.
Or alternatively, should the onDirectUpdate callback function not be
calling setState at all? Because the plotly figure was already updated
internally?
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/plotly/react-chart-editor/issues/751, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAMbAyqu_5A5at7Vcc07qVynXwvzntI-ks5ugrBCgaJpZM4XDG3m
.

Ok, well if I just don't set the state everything seems to work fine (See https://github.com/plotly/jupyterlab-chart-editor/pull/24/commits/2374ee94665d7b8b5e725d4904d26fb3efd42092)

Yeah, the PlotlyEditor keeps its own state so that should work. It’s a
pretty brittle system, prone to infinite loops unfortunately. I’ll still
likely rename that function just for clarity, sorry for the churn.
On Mon, Oct 1, 2018 at 20:33 Jon Mease<EMAIL_ADDRESS>wrote:

Ok, well if I just don't set the state everything seems to work fine (See
plotly/jupyterlab-chart-editor@2374ee9
https://github.com/plotly/jupyterlab-chart-editor/commit/2374ee94665d7b8b5e725d4904d26fb3efd42092
)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/plotly/react-chart-editor/issues/751#issuecomment-426107963,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAMbAwXp6ijdc6EUQhc3TPNN2Fw37hMvks5ugrRAgaJpZM4XDG3m
.

See https://github.com/plotly/react-chart-editor/pull/754

OK, this change was published as v0.31.1


Readme and documentation improvements

Major rewrite of README and conversion to Markdown.
Added CONTRIBUTING.md file in root.
Added docs/ folder with some initial documentation.
Added example udev rules file that includes both DAPLink and STLink USB IDs.
Updated Doxyfile.

/morph test


Java 9 Support

We need to provide support for Java 9 and this means:

conversions from org.reactivestreams to the new Flow interfaces, which are actually 1:1 translations
see if changes are required for our Atomic references, as we are using Unsafe access and it might have been deprecated (TBD)

Not doing anything else for Java 9 / Java 11 at this point.
We'll have to see about VarHandles, but we actually have bigger problems:
JCTools has to be upgraded first.


kas-wgpu build failure

Crate name: kas-wgpu
Build failure link: https://docs.rs/crate/kas-wgpu/0.3.0/builds/224255
Additional details:
[INFO] [stderr] error: failed to run custom build command for `xcb v0.8.2`

According to packages.txt, xcb libraries are already installed. All I need installed for Travis is libxcb-shape0-dev libxcb-xfixes0-dev which are included.
Additionally, all dependent packages of kas-wgpu appear to build successfully, and the crate doesn't directly link against any external libraries, so I don't understand what the issue is.
Thanks in advance for any help!

The relevant error message is here:
[INFO] [stderr]     with open(path, 'w') as f:
[INFO] [stderr] OSError: [Errno 30] Read-only file system: '/opt/rustwide/cargo-home/registry/src/github.com-1ecc6299db9ec823/xcb-0.8.2/src/ffi/selinux.rs'

Crates are not allowed to write to the src directory for security reasons (so we only have to download the crate source once and can reuse that for multiple builds). As an alternative you could write files to OUT_DIR: https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-crates

Oops, I misread the error, that's coming from one of your dependencies. You'll have to ask that dependency to stop writing to src, or they might have already fixed it in a later release.

Ugh, the clipboard crate I'm using is really quite dated. Thanks for the help!


This is my initial attempt at using ctypes, just putting it up online so we have a record of it, and also to help catch if I've done anything wrong.
I was hopeful about the progress I was making, until I came across some hurdles that have blocked this approach. At the moment running it causes a segmentation fault (I believe because of the incorrectly initialised AEDesc). We need:

Need to find a way to initialise:

[ ] AEDesc
[ ] AEDataStorage

Need to confirm how the following values should be defined:

[ ] typeKernelProcessID
[ ] typeWildCard
[ ] keyDirectObject
[ ] pid_t

If this turns out to be too arch-dependent, or too much of a hack, I'll open a different PR using some compiled Objective-C.
Fixes #9.
/cc @BoboTiG @hsoft

In the meantime, I'll investigate other methods of asking Finder to trash the file - maybe there's another way where we don't have to use AEDesc structs and so forth.

Looks like you're well started. It will be a nice feature to have!
I don't have a Mac to test on anymore though. It would be great if someone could volunteer to test @acheronfail's code.

I've just found this: https://github.com/sindresorhus/macos-trash which may actually be a lot easier than the way we're doing it now, I'll give it a crack and update here.

See? I told you there was a better way :) If it works, it will indeed be much easier and faster.

Ahh, I missed this issue on their tracker: https://github.com/sindresorhus/macos-trash/issues/4

I've even tried things like https://developer.apple.com/documentation/appkit/nsworkspace/1530465-recycleurls?language=objc and I'm having no such luck, even running straight Objective-C code.
Looks like this is actually an Apply bug, and running it using event descriptors (like https://github.com/ali-rantakari/trash/blob/master/trash.m#L265-L340) might be the only legitimate to get this to work. :sigh: thanks for that Apple!


Is it all the code for 'Real-Time Single Image and Video Super-Resolution Using an Efficient Sub-Pixel Convolutional Neural Network'?

Is it all the code for 'Real-Time Single Image and Video Super-Resolution Using an Efficient Sub-Pixel Convolutional Neural Network'? I also want to know the version of the python.

Is it work? Please post the results.


Add Vaadin expense manager demo

https://vaadin.github.io/expense-manager-demo/

I get an authentication dialog.

Closing it in favor to #63


ASIM Process Event schema parser with its sample and test data for VMware Carbon Black Cloud

Change(s):

Added ASIM Process Event schema parser for VMware Carbon Black Cloud based on API Data

Reason for Change(s):

Initial version ASIM Process Event Parser

Version Updated:

Initial version

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

Yes

Hi @jayeshprajapaticrest,
Thank you for raising Pull Request with us! We will review it internally and get back to you by shortly.

Hi @jayeshprajapaticrest,
Could you please look for validation errors. Thanks

Hi @jayeshprajapaticrest, please see below validation failure messages. Thanks

@v-atulyadav Yes working on it.

Thanks @jayeshprajapaticrest.

@v-atulyadav validations are fixed

Thanks @keyur-cds. We will review it and get back to you with feedback.

ETA 15th Sept

Hi @jayeshprajapaticrest, could you please provide some updates on @vakohl's comments and also resolve branch conflicts. Thanks

Hi @jayeshprajapaticrest, could you please provide some updates on @vakohl's comments and also resolve branch conflicts. Thanks

@v-atulyadav
Conflicts are resolved and regarding the suggested changes we will working on it. Will updates you on this by this weekend.

Noted @jayeshprajapaticrest. Thanks

Hi @jayeshprajapaticrest, just wanted to check if you got a chance to look at the comments shared. Thanks

@v-atulyadav Sure we will look into it and will update in couple of days.

Hi @jayeshprajapaticrest, just wanted to check if you got a chance to look at the comments shared. Thanks

@v-atulyadav We have made the suggested changes and reverted back to the comments.

Noted @niralishah-crest. Thanks

Hi @jayeshprajapaticrest, please find comments above from @vakohl and act accordingly. Thanks

Hi @jayeshprajapaticrest,
It would be helpful if you could check the comments above from @vakohl and respond accordingly. Thanks

Hi @jayeshprajapaticrest,
To follow up appropriately, we would appreciate some indication of the timeframe for these changes. Thanks

Hi @jayeshprajapaticrest, please act on @vakohl's comments and also please check branch conflicts. Thanks

Hi @jayeshprajapaticrest,
We're waiting for an update on this. Thanks

Thank you, @jayeshprajapaticrest, for committing the changes.

Hi @jayeshprajapaticrest, please resolve branch conflicts. Thanks

Hi @jayeshprajapaticrest, please resolve branch conflicts. Thanks

@v-atulyadav merge conflicts are resolved.

Thanks @niralishah-crest.


:wheelchair: a11y(productslider): Link List

Description of this issue

screenreader does not recognize how many items the list contains

How to fix it

implement as linklist

Additional Information
Level A
https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships.html
Code of Conduct

[X] I agree to follow this project's Code of Conduct

/cib

ready to be released with the next version after 16.3.0


Save and store data using chrome storage

To allow closing history page and reopen while maintaining current data

Do not need to use chrome storage since it will restart everything user closes browser


Refactor internal/controllers into sub packages

Signed-off-by: Mayank Shah<EMAIL_ADDRESS>

/retest

/retest

/lgtm

/retest


Support for Vue.js

Surely you guys have heard of Vue.js
It would be amazing if you can add option support for pug|esj|hb|vue so that selecting vue can attach directly to .Vue files using the template style syntax

There's a similar issue https://github.com/expressjs/generator/issues/251 related to React/JSX support.  The suggestion is to use this middleware which is well supported by core React folk.  That middleware (per their docs) renders static markup and does not support mounting those views on the client..
Does Vue  have a similar option where you're only using it as a templating language with no need for client-side Vue.js?


Refactor output format framework to support tables and empty format

Motiviation
Addressing issue #1429
Changes made:

feat Output Format supports 'table' and 'none' output types. [1]

Verification Steps:

-./rhoas kafka topic create --name test --output none
-./rhoas kafka topic list --output table

Needs addressing comments from here:
https://github.com/redhat-developer/app-services-cli/pull/1540

@rkpattnaik780 WDYT about this PR. I think we could drive that to main branch with some minimal work.

@rkpattnaik780 WDYT about this PR. I think we could drive that to main branch with some minimal work.

That will be great. Few changes need to be made and should be properly tested before merging.


ref #2972 - Proper handling of multiple Map fields with same generic …

Fix for issue #2972:
ModelConverterContextImpl now returns clone of cached Schema instance when that Schema's type is a Map in order to avoid bug where ModelResolver operates on the same instance.

replaced by #3001


fix: generate failure(#3387)

Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

#3387
Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly. (PR: #)
[ ] I have added tests to cover my changes (if not applicable, please state why)
[x] All new and existing tests are passing.

Codecov Report

Merging #4073 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #4073   +/-   ##
=======================================
  Coverage   97.32%   97.32%
=======================================
  Files          18       18
  Lines        1272     1272
  Branches      351      351
=======================================
  Hits         1238     1238
  Misses         33       33
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 963b4dd...51957d0. Read the comment docs.

Thank you for your contribution ☺

/cc @clarkdo


Remove #'s from URLS

The hash usually refers to a location on the page (that I am aware of), this is a problem because the user might add a note to wikipedia.com/lego#origin and if he goes to wikipedia.com/lego, the note will not show since it isn't the same URL
We would add somewhere (probably in the reducer) a way to remove hashes out of URLS

Fixed in latest version. We will need revise this more in the future as there are many times a user might want a note to stick to a page but the url will change


Feature Request: projecteur -c spot=toggle command

Hello @jahnf,
first of all, I want to thank you a lot for your work and your great tool. I was looking for a spotlight tool that I could use in my programming classes, and projecteur works great with its shell commands bound to keyboard shortcuts. I played around with the command line, but I could not find a way to toggle the spotlight, i.e., switch between the on and off state with a single command. Of course, one could wrap the existing commands in a custom script and store the current state, but it would be easier if the tool already provides such a command. So I suggest adding a command like projecteur -c spot=toggle that would allow binding the spotlight to a single keyboard shortcut.
Best regards
Florian

@flortsch  I still need to verify the changes didn't affect any behavior with an actual spotlight remote. But you can already try out the version with command line toggle from the feature branch feature/cmdline-spot-toogle (compiled artifacts are attached to the ci build: https://github.com/jahnf/Projecteur/actions/runs/306563305)


Question: Multiple 'useTranslations' calls in the same component

I have been evaluating a few intl libraries for my nextjs based project. I just came across next-intl and thus far it looks great. I especially like that it follows certain intl standard(the ICU format for example) and also the fact that it is partially based off the robust formatjs library. Loading only relevant translations for the page and locale is a cool feature and something i was looking forward to.
Before i can finalise on the messages structure i had a couple of basic doubts: will having multiple useTranslations hook calls with the same component have any negative bearing on performance? If not, can it be considered an anti-pattern or is it perfectly ok to go ahead? In the repo example each relevant component has only a single useTranslations call and thats why i had a doubt.
My current structure (page/components based translations) was created while i evaluated another library. An example:
const HomePage = () => {
  const t = useTranslations('Mainblock');
  const t1 = useTranslations('MainNavigation');
  const {locale, locales, route} = useRouter();
  const otherLocale = locales?.find((cur) => cur !== locale);
  return (

 {t('heading')}

        {t('title')}

        {t('welcomeMessage')}

      <Link href={route} locale={otherLocale}>
        {t1('switchLocale', {locale: otherLocale})}
      </Link>

  )
}

export function getStaticProps({locale}: GetStaticPropsContext) {
  return {
    props: {
      messages: {
        ...require(`../messages/shared/${locale}.json`),
        ...require(`../messages/home/${locale}.json`)
      },
      now: new Date().getTime()
    }
  };
}

The t1 method calls a different namespace that i have defined in the 'shared.json' file:
{
...
"MainNavigation": {
        "index": "Home",
        "about": "About",
        "switchLocale": "Switch to {locale, select, fr {French} en {English}}"
    },
...
}

while the 'Mainblock' namespace comes from 'home.json'
{
...
    "Mainblock" : {
         "welcomeMessage": "Welcome to my site",
        "heading": "This is the heading",
        "title": "This is the title"
}
...
}

Hi @arunmenon1975,
nice to hear from you and thank you for considering next-intl  for your app 🙂 .
Having multiple useTranslations hook calls in the same component is perfectly fine from a performance perspective.
In the guide, there's a section about how I recommend to structure messages. Personally I'm in favour of scoping messages to a component, but you can of course do what suits you best.
I guess if you cross reference messages from different namespaces, the issue is mostly that you have to get a bit creative with how you call your returned translation function. As mentioned in the guide, you can however also retrieve all available messages in your component and use full paths at the individual call sites.
Does this help?

Ok and yes, definitely helps. Thanks for the response and the suggestions. The main reason for these very basic questions was because i saw #15 that talked about re-renders of the t and thought ill double check before really starting out making changes.  My app is not overly componentized at the moment so i did foresee requiring multiple instances to be defined.
I had gone ahead in the meanwhile and started with the implementation and so far everything been good. The library has it all - including the possibility of potentially having the messages reside remotely(i will definitely be exploring this at a later point since my app has certain admin capabilities and allowing for even the core strings to be configurable without requiring builds is definitely very useful), something that not many of the other major 1i8n libraries support without major trade-offs in a nextjs implementation.
The only (inescapable) issue - well, not exactly an issue but more of a Dx related enhancement opportunity -  is that i would need to have a well-defined structure in place or risk getting confused with all the names and structure that needs definition.  Will need clear forethought about structure and not as easy as say <FormattedMessage defaultMessage="My message" />. Or alternatively, it would be great if i could somehow get my defined namespaces via intellisense  through somehow having them type-defined and avoid, at a minimum, the potential for typos. At the moment however i am stretching my 'naming' skills to the max and it seems ok.
Since only relevant translations are loaded per page, some overlap/duplication of the strings are ok and things balance out from an ease-vs-optimal viewpoint.
Thanks for your suggestions - i will be trying them out. I have finalized next-intl for my project since it has all what i am looking for.

Nice, thanks for the feedback!

Will need clear forethought about structure and not as easy as say

Yep, that's true. next-intl has the API decision that labels are always defined outside of code and therefore you need some kind of mapping via identifiers.

Or alternatively, it would be great if i could somehow get my defined namespaces via intellisense through somehow having them type-defined and avoid, at a minimum, the potential for typos.

That's true, I'd definitely also like that. I'm not sure what the best approach to handle this is though. E.g. if you want to load translations from a remote sever, we can't really infer the shape.
For local messages it might be easier, but also here are some considerations. Either you'd have to pass a type to every useTranslations call site, or there would be a factory function which would create the provider & the hooks and restrict them with type information. You'd have to import from those created instances then instead of the library – also not ideal.
Not sure, really … For now I focused on helpful error messages. If you have some kind of testing infrastructure that throws when there are console errors, you might get the same safety. However auto-complete would still be handy.

ok. And since there is support for nested messages as well and not as clear cut as simply flattened objects i guess, like you said, it will be difficult to get a one-size-fits-all sort of solution going.

For now I focused on helpful error messages. If you have some kind of testing infrastructure that throws when there are console errors, you might get the same safety

The console errors are very useful indeed. Since i am at an early stage of planning the structure of the messages, i keep getting a bunch of it in my console - mostly typos and trailing commas related -  and it does point to the exact property name so i don't have to search for them.  Per the docs, I also see that this is optionally configurable as well.
I am happy as things are though. My app currently is more on the small-to-medium end of the size scale and definitely easily manageable. I think apps thats may have 100s of 1000s  of strings may need a more focussed look at structure and how to have handle the namespacing optimally, which i think is beyond the scope of the library anyway. The documentation of suggestions is quite useful here.

Sounds good!
Yep, I agree. For really large apps I think the automatically generated IDs from react-intl and also message descriptions can be useful – I made a note about this in the FAQ.
At least for the apps I've worked on so far, which tend to be more on the small to medium size as well, I was happy so far we've the tradeoffs of next-intl.


flutter doctor behaves differently from terminal to editor extension

Steps to Reproduce
If I run flutter doctor -v from my terminal I get
→ flutter doctor -v                                                                                [6795bbb]
[✓] Flutter (Channel stable, v1.0.0, on Mac OS X 10.14.2 18C54, locale en-IT)
    • Flutter version 1.0.0 at /Users/alberto/Development/flutter
    • Framework revision 5391447fae (3 months ago), 2018-11-29 19:41:26 -0800
    • Engine revision 7375a0f414
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at /Users/alberto/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 27.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    • ios-deploy 1.9.4
    • CocoaPods version 1.6.0

[✓] Android Studio (version 3.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 31.3.1
    • Dart plugin version 181.5656
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[✓] IntelliJ IDEA Ultimate Edition (version 2018.3.3)
    • IntelliJ at /Users/alberto/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 32.0.3
    • Dart plugin version 183.5901

[✓] VS Code (version 1.31.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 2.23.0

[✓] Connected device (1 available)
    • Alberto’s iPhone •<PHONE_NUMBER>ec5c49fa4974995b76380e88349ced • ios • iOS 12.1.2

• No issues found!

but if I try to run it from the official editor extensions (both in vscode and intellij) i get
/Users/alberto/Development/flutter/bin/flutter doctor --verbose
[✓] Flutter (Channel stable, v1.0.0, on Mac OS X 10.14.2 18C54, locale en-IT)
    • Flutter version 1.0.0 at /Users/alberto/Development/flutter
    • Framework revision 5391447fae (3 months ago), 2018-11-29 19:41:26 -0800
    • Engine revision 7375a0f414
    • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

[✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
    • Android SDK at /Users/alberto/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-27, build-tools 27.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
    • All Android licenses accepted.

[!] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    ✗ libimobiledevice and ideviceinstaller are not installed. To install with Brew, run:
        brew update
        brew install --HEAD usbmuxd
        brew link usbmuxd
        brew install --HEAD libimobiledevice
        brew install ideviceinstaller
    ✗ ios-deploy not installed. To install with Brew:
        brew install ios-deploy
    ✗ Brew can be used to install tools for iOS device development.
      Download brew at https://brew.sh/.

[✓] Android Studio (version 3.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 31.3.1
    • Dart plugin version 181.5656
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)

[✓] IntelliJ IDEA Ultimate Edition (version 2018.3.3)
    • IntelliJ at /Users/alberto/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 32.0.3
    • Dart plugin version 183.5901

[✓] VS Code (version 1.31.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 2.23.0

[!] Connected device
    ! No devices available

! Doctor found issues in 2 categories.

There are probably differences in environment variables.
What "editor extensions" are you talking about?
Have you tried restarting the IDE or the machine?

@zoechi I'm talking about the official VSCode extension and intellij extension.
Restarting my machine and IDEs didn't fix the problem

Here, there is only two difference,
[!] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    ✗ libimobiledevice and ideviceinstaller are not installed. To install with Brew, run:
        brew update
        brew install --HEAD usbmuxd
        brew link usbmuxd
        brew install --HEAD libimobiledevice
        brew install ideviceinstaller
    ✗ ios-deploy not installed. To install with Brew:
        brew install ios-deploy
    ✗ Brew can be used to install tools for iOS device development.
      Download brew at https://brew.sh/.

[!] Connected device
    ! No devices available

They are in fact one issue, in other words, the libimobiledevice thing.
@albertoxamin
When you get
[!] Connected device
    ! No devices available"

from the extension, can you run flutter doctor -vv to get the full details from the terminal?

@DanTup might know how to efficiently diagnose

@kangwang1988 running flutter doctor -vv from terminal outputs
→ flutter doctor -vv
[  +15 ms] executing: [/Users/alberto/Development/flutter/] git rev-parse
--abbrev-ref --symbolic @{u}
[  +37 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[        ] origin/stable
[        ] executing: [/Users/alberto/Development/flutter/] git rev-parse
--abbrev-ref HEAD
[   +7 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[        ] stable
[        ] executing: [/Users/alberto/Development/flutter/] git ls-remote
--get-url origin
[  +12 ms] Exit code 0 from: git ls-remote --get-url origin
[        ] https://github.com/flutter/flutter.git
[        ] executing: [/Users/alberto/Development/flutter/] git log -n 1
--pretty=format:%H
[  +56 ms] Exit code 0 from: git log -n 1 --pretty=format:%H
[   +1 ms] 5391447fae6209bb21a89e6a5a6583cac1af9b4b
[   +1 ms] executing: [/Users/alberto/Development/flutter/] git log -n 1
--pretty=format:%ar
[  +19 ms] Exit code 0 from: git log -n 1 --pretty=format:%ar
[        ] 3 months ago
[        ] executing: [/Users/alberto/Development/flutter/] git describe --match
v*.*.* --first-parent --long --tags
[  +27 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long
--tags
[   +1 ms] v1.0.0-0-g5391447
[ +152 ms] Doctor summary (to see all details, run flutter doctor -v):
[+3003 ms] executing: /usr/bin/defaults read /Applications/Android Studio.app/Contents/Info
CFBundleShortVersionString
[ +241 ms] Exit code 0 from: /usr/bin/defaults read /Applications/Android
Studio.app/Contents/Info CFBundleShortVersionString
[        ] 3.2
[+1764 ms] executing: /usr/bin/defaults read /Applications/Android Studio.app/Contents/Info CFBundleShortVersionString
[  +89 ms] Exit code 0 from: /usr/bin/defaults read /Applications/Android Studio.app/Contents/Info
CFBundleShortVersionString
[        ] 3.2
[  +83 ms] java -version
[ +509 ms] executing: idevice_id -h
[  +38 ms] executing: idevice_id -h
[  +11 ms] executing: ideviceinfo -u 00008020-001C2D903C42002E
[  +22 ms] executing: pod --version
[ +173 ms] executing: /usr/bin/defaults read /Users/alberto/Applications/JetBrains Toolbox/IntelliJ IDEA
Ultimate.app/Contents/Info CFBundleShortVersionString
[  +73 ms] Exit code 0 from: /usr/bin/defaults read /Users/alberto/Applications/JetBrains Toolbox/IntelliJ IDEA
Ultimate.app/Contents/Info CFBundleShortVersionString
[        ] 2018.3.3
[  +96 ms] [✓] Flutter (Channel stable, v1.0.0, on Mac OS X 10.14.2 18C54, locale en-IT)
⣾[   +2 ms] executing: /Users/alberto/Library/Android/sdk/platform-tools/adb devices -l
[  +30 ms] Exit code 0 from: /Users/alberto/Library/Android/sdk/platform-tools/adb devices -l
[        ] List of devices attached
[   +4 ms] executing: idevice_id -h
[  +66 ms] No device found with udid 00008020-001C2D903C42002E, is it plugged in?
[        ] executing: idevice_id -l
[   +5 ms] /usr/bin/xcrun simctl list --json devices
[ +269 ms] executing: /Users/alberto/Library/Android/sdk/platform-tools/adb devices -l
⣽[  +17 ms] executing: /Users/alberto/Library/Android/sdk/tools/bin/sdkmanager --licenses
[  +12 ms] executing: ideviceinstaller -h
⣻[  +22 ms] List of devices attached
[   +6 ms] executing: ios-deploy --version
[  +28 ms] executing: ios-deploy --version
[  +17 ms] 1.9.4
[   +1 ms] executing: ios-deploy --version
⢿[  +19 ms] executing: ios-deploy --version
[  +22 ms] 1.9.4
⢿[ +842 ms] 1.6.0

                    Ignoring ffi-1.9.18 because its extensions are not built.  Try: gem pristine ffi --version 1.9.18
                    Ignoring iStats-1.5.2 because its extensions are not built.  Try: gem pristine iStats --version 1.5.2
[+3757 ms] [✓] Android toolchain - develop for Android devices (Android SDK 27.0.3)
[        ] [✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
[        ] [✓] Android Studio (version 3.2)
[        ] [✓] IntelliJ IDEA Ultimate Edition (version 2018.3.3)
[        ] [✓] VS Code (version 1.31.1)
[        ] [!] Connected device
[        ]     ! No devices available
[        ] ! Doctor found issues in 1 category.
[   +8 ms] "flutter doctor" took 11,342ms.

@albertoxamin
The corresponding output for flutter doctor -vv from the IDE extension is?

@kangwang1988 I can't run that from the IDE extension

but if I try to run it from the official editor extensions (both in vscode and intellij) i get
/Users/alberto/Development/flutter/bin/flutter doctor --verbose
[✓] Flutter (Channel stable, v1.0.0, on Mac OS X 10.14.2 18C54, locale en-IT)
• Flutter version 1.0.0 at /Users/alberto/Development/flutter
• Framework revision 5391447fae (3 months ago), 2018-11-29 19:41:26 -0800
• Engine revision 7375a0f414
• Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)

This action.

There are two ways to run flutter doctor in VS Code though it's not clear which you're using:

Using the Run Flutter Doctor command in the VS Code command palette
Running from the built-in terminal

The likely cause for any differences is environment variables. If running in the built-in terminal, you could run printenv and compare it to the same in your normal terminal and see if there are differences. (Note: The Dart/Flutter extensions don't participate in the terminal in any way, so the results here will be the same even without them - though it's worth noting that VS Code will try to run some of your bash startup scripts to get a similar environment here).
If running the Run Flutter Doctor command from the command palette (which is the best way to run if trying to diagnose Flutter-related issues in VS Code, since it'll run with the same environment as things like the Flutter daemon and flutter run when debugging) then it's not so easy to get at the full environment, but we do log PATH if you enable the Extension log which you could compare to echo $PATH in your terminal to see if there are things missing.
A common issue here is that people set PATH in terminal scripts that only run at terminal startup and don't affect the system (so VS Code doesn't have all the paths) so the first thing I'd do is compare the PATHs in an external terminal to the extension log.

@DanTup
In other words, there might be this case:
idevice_id is available using terminal while unavailable using the ide extension.
Right?
Henceforth, the iOS device detection differ.

If idevice_id is at /some/path/homebrew/bin/idevice_id and /some/path/homebrew/bin is added to PATH in a terminal startup script that is not run for the environment VS Code spawns in, then I guess that could cause this (assuming doctor is looking for it on PATH).
Another way to confirm is to launch VS Code from the same terminal that "works" (if it's on PATH you can just run code .) - though be sure to close all Code instances first. That way VS Code will inherit the same environment that the terminal had, so if it works, it does confirm it's likely environment-related.
In that case, the best fix would be to move the setting of PATH to somewhere that applies globally (outside of the terminal) - for ex. on macOS I add all my paths into the /etc/paths.d/ directory.

There are two ways to run flutter doctor in VS Code though it's not clear which you're using:

I tried both from VS Code the first one is from the integrated terminal, the second is from the Run Flutter Doctor action

Another way to confirm is to launch VS Code from the same terminal that "works" (if it's on PATH you can just run code .) - though be sure to close all Code instances first. That way VS Code will inherit the same environment that the terminal had, so if it works, it does confirm it's likely environment-related.

It does work by starting the editor from the terminal, what are the PATH variables that i must add?
this is my current /etc/paths/
λ alberto [~] → cat /etc/paths
/usr/local/bin
/usr/bin
/bin
/usr/sbin
/sbin
/Users/alberto/Development/flutter/bin

but idevice_id is in the path without terminal startup scripts
λ alberto [~] → which idevice_id
/usr/local/bin/idevice_id

λ alberto [~] → which ideviceinstaller
/usr/local/bin/ideviceinstaller

λ alberto [~] → which ios-deploy
/usr/local/bin/ios-deploy

Just FYI:
✗ libimobiledevice and ideviceinstaller are not installed. To install with Brew, run:
        brew update
        brew install --HEAD usbmuxd
        brew link usbmuxd
        brew install --HEAD libimobiledevice
        brew install ideviceinstaller

=>
bool get isInstalled => exitsHappy(<String>['idevice_id', '-h']);

fails.
✗ ios-deploy not installed. To install with Brew:

=>   Future get hasIosDeploy => exitsHappyAsync(['ios-deploy', '--version']);
fails
✗ Brew can be used to install tools for iOS device development.
      Download brew at https://brew.sh/.
```dart

=>   bool get hasHomebrew => os.which('brew') != null;

@kangwang1988 brew is located ad /usr/local/bin/brew, and I installed everything with homebrew

but idevice_id is in the path without terminal startup scripts

That's strange - if it's at /usr/local/bin/idevice_id and /usr/local/bin is in /etc/paths then I would expect this to work. Could you enable the extension log then restart VS Code, open a Flutter project and then review the log? It should print the full PATH that was available to VS Code at the top.

@albertoxamin
You can also

Modify "/Users/kylewong/Codes/Flutter/alibaba-flutter/flutter/packages/flutter_tools/bin/flutter_tools.dart"
to

import 'package:flutter_tools/executable.dart' as executable;
import "dart:io";

void main(List<String> args) {
  Map<String, String> env = Platform.environment;
  print(env);
  executable.main(args);
}

delete flutter/bin/cache/flutter_tools.stamp (so that the flutter_tools will rebuild and your changes will take effect then).
run flutter doctor -v and i think all the environment info will be output.

Terminal env
{
	TERM_PROGRAM: iTerm.app,
	NVM_CD_FLAGS: -q,
	SHELL: /usr/local/bin/zsh,
	TERM: xterm-256color,
	TMPDIR: /var/folders/qs/tth160ws3yj1d7dj_32rjmhr0000gn/T/,
	Apple_PubSub_Socket_Render: /private/tmp/com.apple.launchd.lDgKCwo7Yt/Render,
	TERM_PROGRAM_VERSION: 3.2.7,
	TERM_SESSION_ID: w0t0p0:528B2DB6-BF18-4151-8B79-3924708C97EA,
	ZSH: /Users/alberto/.oh-my-zsh,
	NVM_DIR: /Users/alberto/.nvm,
	USER: alberto,
	FLUTTER_ROOT: /Users/alberto/Development/flutter,
	SSH_AUTH_SOCK: /private/tmp/com.apple.launchd.Km2QIvpqE6/Listeners,
	__CF_USER_TEXT_ENCODING: 0x1F5:0x0:0x0,
	PAGER: less,
	LSCOLORS: Gxfxcxdxbxegedabagacad,
	PATH: /usr/local/opt/libxml2/bin:/Users/alberto/.pyenv/shims:/Users/alberto/.nvm/versions/node/v10.10.0/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Users/alberto/Development/flutter/bin:/usr/local/share/dotnet:~/.dotnet/tools:/Applications/Wireshark.app/Contents/MacOS,
	PWD: /Users/alberto,
	ITERM_PROFILE: Default,
	XPC_FLAGS: 0x0,
	XPC_SERVICE_NAME: 0,
	PYENV_SHELL: zsh,
	COLORFGBG: 15;0,
	HOME: /Users/alberto,
	SHLVL: 2,
	ITERM_SESSION_ID: w0t0p0:528B2DB6-BF18-4151-8B79-3924708C97EA,
	LESS: -R,
	LOGNAME: alberto,
	LC_CTYPE: UTF-8,
	NVM_BIN: /Users/alberto/.nvm/versions/node/v10.10.0/bin,
	COLORTERM: truecolor, _: /Users/alberto/Development/flutter/bin/cache/dart-sdk/bin/dart
}

extension env
{
	SHELL: /bin/bash,
	TMPDIR: /var/folders/qs/tth160ws3yj1d7dj_32rjmhr0000gn/T/,
	Apple_PubSub_Socket_Render: /private/tmp/com.apple.launchd.lDgKCwo7Yt/Render,
	FLUTTER_HOST: IntelliJ-IDEA,
	USER: alberto,
	COMMAND_MODE: unix2003,
	FLUTTER_ROOT: /Users/alberto/Development/flutter,
	SSH_AUTH_SOCK: /private/tmp/com.apple.launchd.Km2QIvpqE6/Listeners,
	__CF_USER_TEXT_ENCODING: 0x1F5:0x0:0x0,
	PATH: /usr/bin:/bin:/usr/sbin:/sbin,
	PWD: /Users/alberto/Development/flutter,
	XPC_FLAGS: 0x0,
	XPC_SERVICE_NAME: 0,
	SHLVL: 1,
	HOME: /Users/alberto,
	LOGNAME: alberto,
	_: /Users/alberto/Development/flutter/bin/cache/dart-sdk/bin/dart
}```

extension env
PATH: /usr/bin:/bin:/usr/sbin:/sbin,

The problem seems to be that there's no /usr/local/bin in there. I just checked mine, and it does seem like things from my /etc/paths (as well as /etc/paths.d) are loaded when I open VS Code from the dock, so I'm not sure what that isn't happening for you 🤔

Same problem with vscode
{
VSCODE_NODE_CACHED_DATA_DIR: /Users/alberto/Library/Application Support/Code/CachedData/1b8e8302e405050205e69b59abb3559592bb9e60, SHELL: /bin/bash,
[...]
PATH: /usr/bin:/bin:/usr/sbin:/sbin
[...]
}

Could you try using /etc/paths.d/ and rebooting to see if that helps? (it's where most of my paths are, and is mentioned on that page). Just create a file at /etc/paths.d/any-name that contains /usr/local/bin and reboot and tests again.
Looking online, making paths apply globally on macOS is a minefield - I'm somewhat surprised it's all working for me (I do remember I had some issues using /etc/paths, but I think that was down to corp scripts overwriting it on every boot).

@DanTup
just restarted and it doesn't work

still outputs PATH: /usr/bin:/bin:/usr/sbin:/sbin on vscode

@albertoxamin I'm not sure which way you're testing, but it's best to test with the Dart-Code extension log to avoid any possible interference with other scripts of VS Code's terminal (which seems to have weird quirks, as you've found in my issue 😕)

also i found your issue Microsoft/vscode#46693, how did you fix it?

I never got to the bottom of it (though as seen at the end, disabling the profile scripts seemed to fix it). It wasn't critical to me, as it was just for an idea I had (to try and get flutter into PATH for the built-in terminal based on the SDK that Dart Code detected). I figured even if I got to the bottom of it on my machines, loads of other people probably have the same so it probably wasn't usable for what I wanted.

In the latest version of the Dart plugin for VS Code there's a dart.env setting which lets you override the environment for the Dart/pub/Flutter spawned processes. It's not really designed for this, but it may work as a workaround if you don't mind duplicating your PATH into it:
"dart.env": {
  "PATH": "put;your;full;path;here"
}

(if that doesn't work, file a bug at https://github.com/Dart-Code/Dart-Code)
I'm not sure what else we can do with this. The underlying issue seems to be that we can't get VS Code to launch with the PATH set by the system. I'm not sure if that's a VS Code quirk or a macOS one 🤔

This actually works thanks!

Great! Sorry it's not a particularly elegant fix, but I'm not really sure what else we can (easily) do from the extension side. If this turns out to be a problem that affects a lot of people, maybe we can revisit it and see if we can come up with something better.
Thanks!


Integrating Docker Scout with popular IDEs

Tell us about your request
Getting vulnerability information in your images directly in the IDE you're using like VSCode, etc.
Which service(s) is this request for?
Docker Scout
Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?
Getting the vulnerability information about the images early on in the development cycle for teams will save their time and help them in shipping things faster.
Are you currently working around the issue?
NA
Additional context
If you'd like to see this, please include comment with your preferred IDE.

Hi shivammittal89 - Curious as to what you mean by vulnerability. Are we talking security, performance, or tight coupling / cascading failures?

@ajmattus Vulnerability here is in the context of software supply chain security starting with surfacing CVE information in the IDE

If you're interested in surfacing Docker Scout data in your IDE, and you're using VSCode, you may like to join our DockerAI Early Access Program. Sign up here.


getting connection refused with Cart Service

Bug Report
Which version of the demo you are using?
982cefedaa504a52b658e32d45e4d5f5a8ca68bd - PR #105
Symptom
The cart service seems to be unreachable, and all upstream services return an error when attempting to connect
What is the expected behavior?
No errors
What is the actual behavior?
Getting this error:
transport: Error while dialing dial tcp <IP_ADDRESS>:7070: connect: connection refused
Reproduce
git checkout 982cefedaa504a52b658e32d45e4d5f5a8ca68bd
docker compose build
docker compose up

look at any of the traces for /cart/checkout on the frontend service in Jaeger
We will close this issue if:

The steps you provided are complex.
If we can not reproduce the behavior you're reporting.

Additional Context
See image of broken trace

@puckpuck can we revert the PR #105 in order to have a running sample again?

My current workaround for this is to add the following to the cartservice environment stanza in docker-compose.yml:
- ASPNETCORE_URLS=http://*:${CART_SERVICE_PORT}

This gets me past the frontend service failing to connect to cartservice and to a new error, a 500 from cartservice itself:
The request matched multiple endpoints. Matches:

gRPC - Unimplemented service
gRPC - Unimplemented service

@puckpuck can we revert the PR #105 in order to have a running sample again?

I'm going to investigate this deeper to try and figure out what in the PR broke it. I'll know more by tomorrow.

@puckpuck can we revert the PR #105 in order to have a running sample again?

I'm going to investigate this deeper to try and figure out what in the PR broke it. I'll know more by tomorrow.

Ya I'd like to know why as well. I wanted to remove the generate files, which ./services/CartService.cs is one of, but obviously would prefer the example still works :D

Ya I'd like to know why as well. I wanted to remove the generate files, which ./services/CartService.cs is one of, but obviously would prefer the example still works :D

Though the logic doesn't seem like much, I don't believe that file is generated. It acts as a thin wrapper around calling into the CartStore itself.

Ya I'd like to know why as well. I wanted to remove the generate files, which ./services/CartService.cs is one of, but obviously would prefer the example still works :D

Though the logic doesn't seem like much, I don't believe that file is generated. It acts as a thin wrapper around calling into the CartStore itself.

Ah that does seem plausible. I wonder if this wrapper pattern is typically used in C# protobuf projects..


[FEATURE] Form Personal Information

Description
As a User, I want to see a form in which I can add my personal information.
Create a form with following input elements

[ ] Fullname (required)
[ ] Job Title
[ ] Email
[ ] Phone number
[ ] Address (simplified)
[ ] Link to GitHub (recommended)
[ ] Link to Portfolio (optional)
[ ] Link to Linkedin (optional)
[ ] Save button
[ ] Cancel button

Acceptance Criteria (AC) for beginners

[ ] Heading: Personal Information
[ ] Form with above mentioned fields
[ ] Inputfields must be editable
[ ] Fullname throws error when not filled out
[ ] Input fields are accessible
[ ] Save button does not require functionality
[ ] No stylings but plain html

Additional AC if you are more experienced

[ ] Save data in localStorage

Screenshots
No response
Additional information
Please do not hesitate to ask me about accessible forms in case you are unsure.
Accessibility and your inexperience with this topic should not be the reason you are not work on this issue, but to learn about it.

@YuriDevAT Where would you want this form added? Is there a specific page in your codebase you have allocated for this?

@brandonmcconnell Thanks for pointing that out. 🤝  I added the information in every issue. Do you want to get assigned to this issue?

Hello @YuriDevAT  ,Please i would love to contributte to this project


Integer Overflow when supplied large number.

Since any signed integer overflow leads to undefined behavior in C, there should be some checks before adding and multiplication.
For example, the following codes lead to integer overflows.
json_parse("123456789012345678901234567890", 30);
json_parse("123456789012345678901234567890e1", 32);
json_parse("1e234567890123456789012345678901", 32);

My suggestion is to switch from json_integer to json_double type when overflow is about to happen.
For example, the following code may be used for checking integer overflow.
if ((INT64_MAX - (b-'0')) / 10 < top->u.integer)
{
    /* TODO: do something to switch to json_double type */
}

There are three places related to the issue.
num_e = (num_e * 10) + (b - '0');
top->u.integer = (top->u.integer * 10) + (b - '0');
num_fraction = (num_fraction * 10) + (b - '0');

Sorry for the late reply.  You're absolutely right - I'll look into this in the next week or so.

@xoarinn thank you for that patch, it works!

Merged - sorry for the delay, and thanks!


OIIO python api is not properly overwriting an image

Problem

We are running into an issue where we are writing an image "A" with an external DCC and then using oiio to manipulate the file and rewrite over top of the same image with the same file name which I will call image "B".  When we view the file with iv, I see image A.
Expected behavior:
Image B should be in place, not A.
Actual behavior:
I see image A.
Steps to Reproduce
Make two jpg images(checkerboard) with different sizes (tested with both jpg & exr).
dog.jpg = 640x480
cow.jpg = 1280x720
This will make it easy to verify whether the OIIO python API has the correct image without opening the image in a viewer.
We will use an oiio.ImageBuf to repeatedly open a file called animal.jpg which is created by copying either dog.jpg or cow.jpg to a file with the name animal.jpg
python code below:

import OpenImageIO as oiio

# before proceeding
# in an external shell, copy dog.jpg to animal.jpg
filepath_in = "/var/tmp/animal.jpg"

image = oiio.ImageBuf(filepath_in)
image.read()
print image.spec().width

# should print 640 to the console here

# wipe the contents of the ImageBuf
image.clear()

# now, in an external shell, copy cow.jpg over top of animal.jpg

image = oiio.ImageBuf(filepath_in)

image.read()
print image.spec().width

# should print 1280 to the console here, but prints 640 instead.

# end of code

You'll notice that not only are the width and height of the original incarnation of animal.jpg frozen for eternity, the image content is as well. In addition to ImageBuf.clear() we've also tried reset() and read(0,0,True) to force the flushing of the cache. But OIIO python API never seems to be able to dissociate the file name animal.jpg with anything but its first incarnation. Is this a bug? Or is there a documented way to re-read a file whose content has changed. Thanks in advance.
Versions

OIIO 1.8.5 (also tested with 1.8.10)
OS: Centos 6.4
C++ compiler: gcc 4.8.5

What you need to understand is that by default, ImageBuf reads are done lazily, and are backed by ImageCache. So the sequence you've laid out is:

declare ImageBuf for animal.jpg (lazy -- won't even open the file yet)
image.read() still lazy -- header is read now, but as an aside, pixels still aren't read
delete the buffer (note: header info and any pixels you accessed are still in ImageCache)
unbeknownst to the ImageCache, the image is changed on disk
another ImageBuf names animal.jpg
read the buffer, and it gets the info that's still in the ImageCache from earlier

There are two ways to address this.

If you don't want the ImageCache involved at all, and you want to be sure that the read() always does a complete read of whatever is on disk at that moment, you want:
 image.read (force=True)

If you still want ImageCache to do its magic (and by the way, in this case, the read() call itself is unnecessary, it will automatically read when you access header info or pixels), and you know when an external program might change the file, then you can do this:
 image.clear ()
 oiio.ImageCache.create().invalidate (filename_to_invalidate)
 // ... now the next ImageBuf to reference that file will start anew

Did this explanation help?

Yes, sorry, I meant to reply to this earlier.  We found another thread on oiio-dev which you kind of explained the same thing from earlier in the year.  It would be good to have this in the oiio python docs though.  This isn’t explained in there.
Cheers

I think I have a technical fix that should help prevent people running into this. Coming soon.

oiio.ImageCache.create().invalidate (filename_to_invalidate)

@lgritz We have this line in a few places in our code. As this is no longer compatible with oiio-2 I was wondering if you implemented the technical fix you were thinking of?

I think ImageCache.create() is removed because it's unnecessary. Just use the constructor:
oiio.ImageCache().invalidate (filename)

Does that work?
Now, as for the question about whether I implemented the technical fix... uh, I don't know, this was a while ago and I need to see what I did about it. Let me poke around a bit in my records and look through closed PRs, maybe I just never associated it with this issue.

I'm re-opening this ticket. I think the fact that it was closed confused me before into thinking it was resolved, but I think I never added the feature I was hypothesizing would make this trick unnecessary.

Proposed automatic fix for this is in PR #2696

I've merged the automatic fix into master. I want to let it sit there for a little while to let it get more extensively tested, but if no problem is found with it, I will backport it to 2.2 in time for the Oct 1 monthly patch release.