A potential risk in pipe-cd that could lead to takeover of the cluster

Dear Team Members:
Greetings! Our team is very interested in your project and we recently identified a potential RBAC security risk while doing a security assessment of your project. Therefore, we would like to report it to you and provide you with the relevant details so that you can fix and improve it accordingly.
Details:
In this Kubernetes project, there is a ClusterRole that has high-risk risk permissions for arbitrary operating privileges for arbitrary resources. https://github.com/pipe-cd/pipecd/blob/master/quickstart/manifests/piped.yaml. It meand this ClusterRole has superuser privileges and can perform almost any operation in the cluster. If an attacker steals a service account with this privilege，he can elevate the privileges and further take over the entire cluster.
Please confirm the purpose of the assignment of this permission and consider using a more granular permission non-assignment rule.
Best wishes.
HouqiyuA

Thank you for reporting, but security issues MUST NOT BE PUBLIC. See https://github.com/pipe-cd/pipecd/blob/master/CONTRIBUTING.md#security-bugs.
Besides, this is not a risk because users can choose a way that fits their policy.


Dbatiste/update vui colors

@dlockhart : cool with this version bump (given that colors went from 0.1 to 0.2)?

Sure looks good. I don't know how I feel about mentioning "FRAs" in the documentation, since in theory VUI is larger than FRAs.

Hmmm ya.  I'll update that.  Do you think I should remove the reference to the vui-typography mixin altogether?  My intent was to just provide some basic info about the mixins we expect consumers to use.

No I'd leave that -- I like that we're providing some basic documentation here.


Rolling for Hit location error when passive blocks set

If passive block check boxes are ticked this error comes up when rolling for location
SyntaxError: Expected "(", ".", "[", "abs(", "ceil(", "d", "floor(", "round(", "t", "{", [ |\t], [+|-] or [0-9] but "o" found.

This was corrected in v3.0


Add Android SDK 27 (8.1)

This still installs Android SDK 22 for now so we can try out the new SDK and see if it works as expected.

/rebase

/rebase


Properly convert long message length

fixes #11
Also, bump version to 1.2.1

@gusavila92 plz review & release
We should also have some tests, at least here =(


Fetch package isn't latest version

Recently, I try to fetch firebase-admin-go dependency by go get firebase.google.com/go.
But it is previous version, not latest version.
go-xn (master)$ go get firebase.google.com/go
go: finding firebase.google.com/go v3.6.0+incompatible
go: downloading firebase.google.com/go v3.6.0+incompatible
go: extracting firebase.google.com/go v3.6.0+incompatible
go: finding google.golang.org/api/option latest
go: finding google.golang.org/api/iterator latest
go: finding google.golang.org/api/googleapi latest
go: finding golang.org/x/oauth2 latest
go: finding google.golang.org/api/transport latest
go: finding cloud.google.com/go/storage latest
go: finding golang.org/x/oauth2/google latest
go: finding google.golang.org/api/identitytoolkit/v3 latest
go: downloading google.golang.org/api v0.2.0
go: downloading golang.org/x/oauth2 v0.0.0-20190319182350-c85d3e98c914
go: finding cloud.google.com/go/firestore latest
go: finding google.golang.org/api/identitytoolkit latest
go: extracting golang.org/x/oauth2 v0.0.0-20190319182350-c85d3e98c914

Emm, its latest version v3.7.0 has been released for 19 days.
Try to write 'firebase.google.com/go v3.7.0+incompatible' in go.mod file, then go mod download, cloud not fetch other necessary packages, only fetch itself repo.
go-xn (master)$ go mod download
go: finding firebase.google.com/go v3.7.0

So, how can goproxy tool ensure pull dependency is up to date as early as possible.

The server's DNS has some issue. Sorry about that. Now fixed, try it again.

Fetch normally.
Thanks. 👍


FIX: Track all DM channels in frontend even if hidden

I keep seeing this issue where someone personal chats me, and I don't see it until I do a page refresh. I thought the issue was with personal chat channel creation, but then I realized it's the limit on the DM channel query.
Currently the client is only tracking the latest 10 channels... so if Robin is 11th most recently updated and sends me a new message, I will not get it.
This PR does 2 things:

Serializer all your DM channels, and hides channels 11-on. This allows tracking of all channels.
Keeps unread DM channels at the top of the list. First sort by unread messages count, then sort by updated_at on the channel

First sort by unread messages count, then sort by updated_at on the channel

Wouldn't sorting by updated_at then by unread count be better? 🤔 (and more of a standard?)

CvX and I chatted privately about this and he agreed to give this a shot :)


Use dependencies instead of peerDependencies.

npm@3 remove peerDependencies support now.

npm/npm#6565

Thanks

Sorry, I don't agree with that change. peerDependencies are not deprecated, they are just not installed automatically (which should not have been the case in the first place). In fact, the need for peerDependencies has been confirmed by the npm team.
After maintaining a bunch of compile-to-loaders (less-loader, sass-loader, markdown-loader), I came to the conclusion that it's the best for the maintainer and the developer to use peerDependencies. That is, because the API surface between, say, less and your app is much bigger than between less and the less-loader. It's more practical when the developer is able to choose the exact version of the dependency.
I want to revert that commit.

Agreed with @jhnns.

I agree with moving peerDependencies into dependencies, because peerDependencies are a world of pain. I wish more packages removed peerDependencies in favor of correct expressions of dependencies.

dependencies are things you require(). devDependencies are things you require() for tests and prepublish compilation. If you don't require() it, then it shouldn't be a dependency.

In this case, since the semver ranges are identical, a consumer of this package can still choose the exact version (as long as it also satisfies ^2.3.1), and the exact version will be the one required by less-loader when called from the consumer's package. Pin less to 2.4.0 in the consumer's top-level dependencies, and npm does the right thing when installing<EMAIL_ADDRESS>installed in top-level node_modules, and omitted from node_modules/less-loader/node_modules).
If a consumer really cares about controlling the versions of everything in the dependency tree, they should be bludgeoning themselves with using npm shrinkwrap.

It's not appropriate for less-loader to strongly depend on less, less and its version should be specified by app.
revert +1

@evocateur you're right, with npm@3 it's probably not that issue anymore.
But interestingly this approach doesn't match with your definition of a dependency:

dependencies are things you require()

If your app says less^2.3.1 in its package.json, there should be a require('less') in your app :wink:

@sokra thx
@evocateur @fengmk2 I'm still open for discussion. If you experience actual problems with peerDependencies please let me know. My impression is that it's easier both for the maintainer and the developer.

'peerDependencies' is work fine on npm2 when the developer forget to add 'less' to their package.json.
But it's broken on npm3 with the same codes.
I'm a private npm registry maintainer for my company.
And a lot of people don't know how peerDependencies work.

I'm a private npm registry maintainer for my company.
And a lot of people don't know how peerDependencies work.

I do understand your pain, but I think it's temporary. With npm@3 you'll get an error when you're trying to install a dependency and you don't have the peerDependency installed. We can also add the peer dependency in our installation note, like npm i less-loader less --save-dev. I did that at the sass-loader as well.


Creator attribution - added status rpc read methods

Current dependencies on/for this PR:

main

PR #142

PR #133

PR #149

PR #98

PR #144

PR #152

PR #154

PR #128

PR #155

PR #145


Support OpenAPI webhooks

What problem will this feature address?
OpenAPI supports defining webhooks:

3.1: spec & blog
2.0 & 3.0: spec

Describe the solution you'd like
Would be great to also parse the webhooks in an OpenAPI spec file, adding their pages too.
Describe alternatives you've considered
N/A
Additional context
No response

the official support is only introduced on OpenAPI 3.1 while Fumadocs OpenAPI is currently 3.0 only.
I plan to migrate it to 3.1 after v14. as we need to fix some other issues before working on the next major release of OpenAPI integration.

Supported soon

Currently implemented with scalar parser to provide backward compatibility, welcome for feedback as it's relatively a new feature

Looks absolute awesome, @fuma-nama.


support for 100 CONTINUE

From @durin42 on May 4, 2012 21:26
Would be lovely to support sending the continue status line both early and after a delay.
Copied from original issue: mitmproxy/pathod#2

From @ghazel on March 2, 2013 23:47
And not at all. "d0" still sends the 100 Continue response first before dropping the connection.

Any update on this? Really needed for mitmproxy to handle this properly, but instead, it looks it just strips out the Expect: header. If adding it back, using a script, it hangs in a 100-Continue request.

Are you referring to mitmproxy or pathod? mitmproxy handles 100-continue requests.

I'm referring to mitmproxy: have a script with two methods:
def request(flow):
    ctx.log.info(str(flow.request.headers))

def requestheaders(flow):
    ctx.log.info(str(flow.request.headers))

Looks that for the requestheaders method, I do have the Expect header, but it's missing within the request method; I guess that's the desired design?
Anyway, so after doing a proper request, using curl, and sniffing the network, not able to see any 100 Continue requests, as opposed to when I'm doing a direct (i.e. no mitmproxy) request to my server. Not sure what I'm missing, but something doesn't work properly, or at least according to my expectations.
Thanks.

Ok, this is unrelated to this issue here (which is about pathod - sorry, that's not quite clear).
Can you please open a new issue describing your problem? FWIW, our code for handling 100-continue is here: https://github.com/mitmproxy/mitmproxy/blob/c0882496e37bbe6985b67ad94bdff72524b5b668/mitmproxy/proxy/protocol/http.py#L263-L285

Closing, as pathod and pathoc command line tools and their libraries inside mitmproxy are deprecated. See #4273.


Fixed static resources referenced by Towhee Model documentation page in GitHub dark mode

Similar to the changes in the previous PR, correct resource references in the Towhee Model documentation in GitHub dark mode.
Sorry, I left out these two documents, after reconfirmation, all resource references are correct @reiase
Issue: https://github.com/towhee-io/towhee/issues/1768

/lgtm
/approve


Add Missing Parameters to MSFT_xNetworking Resource

The following parameters are missing from the MSFT_xNetworking resource and need to be added (after PR #52 has been merged):
DynamicTarget
EdgeTraversalPolicy
IcmpType
LocalOnlyMapping
LooseSourceMapping
OverrideBlockRules
Owner
At this point I don't think they are critical (unless someone needs them right now of course).

you wrote MSFT_xNetworking, did you mean xFirewall?

Yes. Yes I did. Corrected now. Sorry about that.

Closing. Thanks @tysonjhayes


Update README.md

Super powerful and convenient GPT/LLM Swiss army knife browser interface

Please link to a extension page in store or its web page and resend


Frontend assessment

Metric
Value

alert_status
:white_check_mark: OK

bugs
3

code_smells
1

reliability_rating
C (at least 1 Major Bug)Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)Note: A being best, E being worst

vulnerabilities
0

Metric
Value

alert_status
:white_check_mark: OK

bugs
2

code_smells
1

reliability_rating
C (at least 1 Major Bug)Note: A being best, E being worst

security_rating
A (0 Vulnerabilities)Note: A being best, E being worst

vulnerabilities
0


Create RDF Integration test

Given a specific Resource Template, insure the editor generates the expected RDF from the redux store.

[x] An authenticated user starts from the home page and clicks on the Linked Data Editor tab
[ ] User loads a Resource Template into the Editor Tab; Resource Template should be moderately
complex and include:

[x] literal, lookup, and resource propertyTemplates along with defaults.
[ ] At least one InputLiteral with non-roman script
[ ] A least one InputLiteral with diacritic in latin script
[ ] A least one InputLiteral  transliterated title with ligatures

@jermnelson how does this relate to #423?   Is this a more contained set of tests checking more narrowly focused things?   B/C I'm not sure the tests being written are checking the RDF produced ...  (or is the title of this ticket misleading)

Hi @ndushay, this list of items comes directly from UAT ticket for Milestone 4 and the title was adopted from that description. I think #423 should be a separate integration test that does check the RDF output and I just updated #423 to reflect that.

Thanks @jermnelson .  I also just slacked with Aaron and he knows he's not yet checking the produced RDF, so he won't check the boxes here until he is.  :-)

Yes, my assumption here is that the output needs to be checked in order for these to be "complete"... if that is an incorrect assumption, I think the title should be updated.

👍

Current test coverage is adequate.


[DOC] Do we support storage file share client with SAS token?

Library name and version
Azure Storage File Shares client library for .NET
Describe the bug
We should also support create a client with SAS token, right?
I cannot find any information in our readme.
Expected behavior
We want to add the information in readme
Actual behavior
We don't
Reproduction Steps
DOC
Environment
No response

I find different auth types in https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/storage/Azure.Storage.Files.Shares/samples/Sample02_Auth.cs.
Can we have a section to describe different ways to use a client?
Seems to me this information is important.


Duplicate values in metadata.csv?

Hi
Just a a random question regarding CORD19 data. The column "cord_uid" in metadata.csv is not unique. In the up to date version,
cord19 = pd.read_csv('metadata.csv')

print(cord19.shape)
(322441, 3)

print(cord19['cord_uid'].nunique())
308694

Eg. "c4u0gxp5" has 3 rows with different titles. Why is this the case if the id belongs to the same document?
Thanks
Iknoor

Hi Iknoor, thanks for your interest in CORD19!  Please see the explanation we provide in our FAQ:
https://github.com/allenai/cord19#why-can-the-same-cord_uid-appear-in-multiple-rows
Thanks!

Hi Kyle,
Oh, got it. Thanks
Best,
Iknoor


check for first 3 addresses and last address

One solution I see to the problem discussed in #115 : beside checking for the 3 first addresses in the list, we also check the last address that should be imported according to the initial_import_count parameter. If the 4 addresses are not in imported_addresses, then import_needed is set to True.
I'm trying to write a test for that so I'm not sure it works or not.

Excellent idea, thanks for this.
There's no automated tests for this part of the code yet, so don't worry about adding that. We'll just have me and you test it (possibly on testnet or regtest), and then merge.

Ok I'm on the go now I'll do some tests when I can.

Successful test here: https://github.com/chris-belcher/electrum-personal-server/issues/115#issuecomment-495923555
Please squish your commits into one. Instructions can be found here: https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits

Done, it should be ready for merge now


Add DisallowedMethods/ExcludedMethods to Style/MethodCallWithArgsParentheses

Is your feature request related to a problem? Please describe.
I'd like to use rubyfmt for code formatting, but it force adds parentheses to every method call except for a very short list of exceptions. In my toolchain I'm running rubyfmt, and then rubocop on its output. However, rubocop does not allow me to configure it in a way that would "correct" those force added parentheses.
Describe the solution you'd like
With the default EnforcedStyle: require_parentheses an additional option called DisallowedMethods or ExcludedMethods would be required so that rubocop would then remove parentheses from methods listed by the user in the rubocop config. I'm thinking of all RSpec helper methods like it, its, describe, context, be, eql, eq, and so on. rubyfmt has a very short list of exceptions, but it looks like they won't be adding any more to it (https://github.com/fables-tales/rubyfmt/pull/410).
The reason for it is that certain methods (those RSpec ones are a perfect example) are (I believe) considered by the community to be written without parentheses, while rubyfmt goes against it and force adds them everywhere. I'd love to use rubyfmt, but this currently prevents me from using it, so I'm searching for a solution (here, and there).
I could also envision a future, where Style/MethodCallWithArgsParentheses with EnforcedStyle: require_parentheses is a default enabled rule, with rubocop maintaining a list of all macros, Rails helpers (render, enum, validates, and so on and on), RSpec helpers, which should be written without parentheses.
Describe alternatives you've considered
I haven't found any alternative solution, apart from not using rubyfmt in the first place 😿

This should already with the AllowedMethods, AllowedPatterns or IncludedMacros configuration options. See the documentation for more details.

@gsamokovarov with EnforcedStyle: require_parentheses configuration option there's no way to exclude a list of methods, which should be left without parentheses. In other words, I'd like rubocop, with EnforcedStyle: require_parentheses on, to remove parenthesis from a list of specific methods. Currently rubocop will just ignore a list methods, i.e. it will not add parenthesis, but it will not remove them if they are already there (which is something I would like to have).


Add post processor to register ProviderSettings @Bean

@jgrandja Updates ready for review.

Thanks for the PR @sjohnr ! This is now in main.


aarch64-linux support build and cache

I thought we'd been over this.
We only support "x86_64-linux".


test: Update test

Codecov Report

Merging #36 (9fb641b) into develop (bb984ff) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop       #36   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            1         1
  Lines            3         3
=========================================
  Hits             3         3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb984ff...9fb641b. Read the comment docs.


Lab 6: Compilation warning and unable to pass case 8

Summary
Im not sure as to why this warning pops out

Description:
Im also stuck on case 8. Anyone have any idea as to why this error occur?

It seems that your Server free time was updated incorrectly after taking a break, since the expected output shows that Customer 3 is served by Server 1 without a preceding Done event

Aside from that, it seems there is a timing issue with regards to how a Customer should be served (notice that even though Customer 3 arrives earlier than 5, 5 gets served before 3, meaning the ordering of events is incorrect in the PQ).

there seems to be a timing issue with your wait and serve events, maybe you can check how you are passing the time in the constructor around and fix from there (make your own test case to debug)

Solved it!

@BlabbyDuck Hello! May I ask how you solved the issue for the 8th test case in your code? I have the same strange thing that you had where Customer 5 gets served before Customer 3 even though 3 arrived earlier 😔 but I can't seem to figure out why

Hello! If I remember correctly this issue occurs when the server is done serving the previous customer and rest. If a new customer(cust 3 in this case) comes in and queues behind the server while he is resting, since my serve event is called after a done event, cust 3 will not be served until another customer (cust 5) is called. Hence cust 3 will keep waiting meanwhile regardless of his priority.
What I did was in the simulator class, I made sure if the event was a wait class, if the server is resting and does not have any queue/customer, I will create a server event in the simulator class.
Feel free to ask me more qns to clarify your doubts!

Thank you so much for the help! It makes a lot of sense, shall try it out soon


Check failed of output_size_shape when using tensorflow lite converter

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Linux Ubuntu 16.04
TensorFlow installed from (source or binary):
binary: by "pip3 install --upgrade tensorflow-gpu"
TensorFlow version (use command below):
tensorflow-gpu (1.6.0)
Python version:
Python 3.5.2
Bazel version (if compiling from source):  0.11.0
GCC/Compiler version (if compiling from source):
gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
CUDA/cuDNN version:
CUDA 9.0 cuDNN 7
GPU model and memory: Null
Exact command to reproduce:

~/tensorflow/bazel-bin/tensorflow/contrib/lite/toco/toco
--input_file=./RD_Net/RD_Net_opt.pb
--output_file=./RD_Net.tflite
--input_format=TENSORFLOW_GRAPHDEF
--output_format=TFLITE
--inference_type=FLOAT
--input_data_types=FLOAT
--input_arrays=Placeholder
--output_arrays=seq_4/Conv/BiasAdd
--input_shapes=1,240,320,3

Describe the problem
I save my pre-trained model into .pb file according to freeze_graph.py and optimize_for_inference.py
my input/out node in .pbtxt

node {
name: "Placeholder"
op: "Placeholder"
attr {
key: "dtype"
value {
type: DT_FLOAT
}
}
attr {
key: "shape"
value {
shape {
dim {
size: 1
}
dim {
size: 240
}
dim {
size: 320
}
dim {
size: 3
}
}
}
}
}

node {
name: "seq_4/Conv/BiasAdd"
op: "BiasAdd"
input: "seq_4/Conv/Conv2D"
input: "seq_4/Conv/biases"
attr {
key: "T"
value {
type: DT_FLOAT
}
}
attr {
key: "data_format"
value {
s: "NHWC"
}
}
}

I use the .pb to test prediction and it work fine. (the in/out node name and size are checked)
but fail in .tflite converting flow...  any suggestion?
My step:

clone last tensorflow (commit 72239e9b0432a26feadc2412abf89a8fb92828f0)

build the toco:

bazel build tensorflow/contrib/lite/toco:toco

and convert my .pb into .tflite:

~/tensorflow/bazel-bin/tensorflow/contrib/lite/toco/toco
--input_file=./RD_Net/RD_Net_opt.pb
--output_file=./RD_Net.tflite
--input_format=TENSORFLOW_GRAPHDEF
--output_format=TFLITE
--inference_type=FLOAT
--input_data_types=FLOAT
--input_arrays=Placeholder
--output_arrays=seq_4/Conv/BiasAdd
--input_shapes=1,240,320,3

the error msg:

2018-03-06 15:39:30.859538: I tensorflow/contrib/lite/toco/graph_transformations/graph_transformations.cc:39] Before Removing unused ops: 1365 operators, 2579 arrays (0 quantized)
2018-03-06 15:39:30.910650: I tensorflow/contrib/lite/toco/graph_transformations/graph_transformations.cc:39] Before general graph transformations: 1365 operators, 2579 arrays (0 quantized)
2018-03-06 15:39:30.967113: F tensorflow/contrib/lite/toco/graph_transformations/propagate_fixed_sizes.cc:764] Check failed: output_size_shape.dimensions_count() == 1 (2 vs. 1)
Aborted (core dumped)

@andrehentz Can you take a look at this or recommend someone who works on this?

It looks like you have a resize_bilinear operations where the 'shape' is 2D but TOCO expects it to be 1D (which seems to match the documentation at https://www.tensorflow.org/api_docs/python/tf/image/resize_bilinear

Hi @andrehentz  how do you known have a resize_bilinear operations? the error msg doesn't show the key word.
I do have resize_bilinear for upsample.
it is weird that if I use  graph_transforms tools by my self with cmd line after "optimize_for_inference.py", the converter work fine to get .tflite but fail at android app.
I finally change "resize_bilinear"  into "TransposeConv" but fail with #17501
Any suggestion? Thanks~~~

I looke at tensorflow/contrib/lite/toco/graph_transformations/propagate_fixed_sizes.cc:764 which is handling resize bilinear. Why is the shape of your resize_bilinear 2D? Is that something that TF supports but TF Lite doesn't?

Nagging Assignee @andrehentz: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

Hi, I'm having the same issue. I'm using the frozen DeepLab v3+ model from here (xception_coco_voc_trainaug).
I printed out the shapes of all ResizeBilinear/size tensors, as well as the shapes of the inputs to all of the ResizeBilinear tensors, and it seems that they are all 1D and have two elements:
In [59]: print([(n.name, n.outputs[0].get_shape(), tf.contrib.util.constant_value(n.outputs[0])) for n in tf.get_default_graph().get_operations() if 'Bilinear' in n.name and '/size' in n.name])

[('import/ResizeBilinear_1/size', TensorShape([Dimension(2)]), array([65, 65], dtype=int32)), ('import/decoder/ResizeBilinear/size', TensorShape([Dimension(2)]), array([129, 129], dtype=int32)), ('import/decoder/ResizeBilinear_1/size', TensorShape([Dimension(2)]), array([129, 129], dtype=int32)), ('import/ResizeBilinear_2/size', TensorShape([Dimension(2)]), array([129, 129], dtype=int32))]

In [60]: print([(n.name, n.inputs[1].name, n.inputs[1].shape, tf.contrib.util.constant_value(n.inputs[1])) for n in tf.get_default_graph().get_operations() if 'Bilinear' in n.name and '/size' not in n.name])

[('import/ResizeBilinear', 'import/ToInt32:0', TensorShape([Dimension(2)]), None), ('import/ResizeBilinear_1', 'import/ResizeBilinear_1/size:0', TensorShape([Dimension(2)]), array([65, 65], dtype=int32)), ('import/decoder/ResizeBilinear', 'import/decoder/ResizeBilinear/size:0', TensorShape([Dimension(2)]), array([129, 129], dtype=int32)), ('import/decoder/ResizeBilinear_1', 'import/decoder/ResizeBilinear_1/size:0', TensorShape([Dimension(2)]), array([129, 129], dtype=int32)), ('import/ResizeBilinear_2', 'import/ResizeBilinear_2/size:0', TensorShape([Dimension(2)]), array([129, 129], dtype=int32)), ('import/ResizeBilinear_3', 'import/strided_slice_7:0', TensorShape([Dimension(2)]), None)]

However, when I add the following code to ProcessResizeBilinearOperator,
  std::cout << "Output size shape for " << output_size_name << ": ";
  for(auto dim : output_size_shape.dims()) {
    std::cout << dim << ", ";
  }
  std::cout << std::endl;
  // CHECK_EQ(output_size_shape.dimensions_count(), 1);

I get the output:
2018-03-27 16:44:23.330779: I tensorflow/contrib/lite/toco/import_tensorflow.cc:1236] Converting unsupported operation: Equal
2018-03-27 16:44:23.330937: I tensorflow/contrib/lite/toco/import_tensorflow.cc:1236] Converting unsupported operation: LogicalAnd
2018-03-27 16:44:23.453760: I tensorflow/contrib/lite/toco/graph_transformations/graph_transformations.cc:39] Before Removing unused ops: 1895 operators, 3070 arrays (0 quantized)
2018-03-27 16:44:23.504983: I tensorflow/contrib/lite/toco/graph_transformations/graph_transformations.cc:39] After Removing unused ops pass 1: 1885 operators, 3051 arrays (0 quantized)
2018-03-27 16:44:23.573858: I tensorflow/contrib/lite/toco/graph_transformations/graph_transformations.cc:39] Before general graph transformations: 1885 operators, 3051 arrays (0 quantized)
Output size shape for ToInt32: 2, 1,
2018-03-27 16:44:23.803197: I tensorflow/contrib/lite/toco/graph_transformations/graph_transformations.cc:39] After general graph transformations pass 1: 460 operators, 1136 arrays (0 quantized)
Output size shape for ToInt32: 2, 1,
2018-03-27 16:44:23.817572: I tensorflow/contrib/lite/toco/graph_transformations/graph_transformations.cc:39] Before dequantization graph transformations: 460 operators, 1136 arrays (0 quantized)
2018-03-27 16:44:23.827669: I tensorflow/contrib/lite/toco/allocate_transient_arrays.cc:311] Total transient array allocated size: 7105728 bytes, theoretical optimal value: 6316160 bytes.
2018-03-27 16:44:23.830342: F tensorflow/contrib/lite/toco/tooling_util.cc:1818] Check failed: array.final_data_type == array.data_type Array "ImageTensor" has mis-matching actual and final data types (4,2).
./convert.sh: line 10: 30075 Aborted                 (core dumped) bazel-bin/tensorflow/contrib/lite/toco/toco --input_file=../deeplabv3/deeplabv3_pascal_train_aug/frozen_inference_graph.pb --input_format=TENSORF
LOW_GRAPHDEF --output_format=TFLITE --output_file=../deeplabv3/deeplabv3_pascal_train_aug/deeplabv3.tflite --inference_type=FLOAT --input_type=FLOAT --input_arrays=ImageTensor --output_arrays=SemanticPredictions
--input_shapes=1,513,513,3

Does this information help?

I'm facing the same issue with mobilenet.
The command to generate tlite file
bazel-bin/tensorflow/contrib/lite/toco/toco \
> --input_file=frozen_inference_graph.pb \
> --input_format=TENSORFLOW_GRAPHDEF \
> --output_format=TFLITE \
> --output_file=frozen_inference_graph.lite \
> --inference_type=FLOAT \
> --input_type=FLOAT \
> --input_arrays=ImageTensor \
> --output_arrays=SemanticPredictions \
> --input_shapes=1,513,342,3

The log of the error.
2018-04-01 15:57:00.360279: W tensorflow/contrib/lite/toco/toco_cmdline_flags.cc:178] --input_type is deprecated. It was an ambiguous flag that set both --input_data_types and --inference_input_type. If you are trying to complement the input file with information about the type of input arrays, use --input_data_type. If you are trying to control the quantization/dequantization of real-numbers input arrays in the output file, use --inference_input_type.
2018-04-01 15:57:00.389245: I tensorflow/contrib/lite/toco/import_tensorflow.cc:1172] Converting unsupported operation: Equal
2018-04-01 15:57:00.389504: I tensorflow/contrib/lite/toco/import_tensorflow.cc:1172] Converting unsupported operation: LogicalAnd
2018-04-01 15:57:00.406372: I tensorflow/contrib/lite/toco/graph_transformations/graph_transformations.cc:39] Before Removing unused ops: 812 operators, 1241 arrays (0 quantized)
2018-04-01 15:57:00.434485: I tensorflow/contrib/lite/toco/graph_transformations/graph_transformations.cc:39] After Removing unused ops pass 1: 802 operators, 1222 arrays (0 quantized)
2018-04-01 15:57:00.465611: I tensorflow/contrib/lite/toco/graph_transformations/graph_transformations.cc:39] Before general graph transformations: 802 operators, 1222 arrays (0 quantized)
2018-04-01 15:57:00.465869: F tensorflow/contrib/lite/toco/graph_transformations/propagate_fixed_sizes.cc:737] Check failed: output_size_shape.dimensions_count() == 1 (2 vs. 1)

Nagging Assignee @andrehentz: It has been 14 days with no activity and this issue has an assignee. Please update the label and/or status accordingly.

same error as @calicratis19

same error as @calicratis19

same error as @calicratis19

same error as @calicratis19

same error as @calicratis19

same error as @calicratis19

I get this error:
F tensorflow/contrib/lite/toco/tooling_util.cc:822] Check failed: d >= 1 (0 vs. 1)

This error converting my LSTM graph:
https://stackoverflow.com/questions/51275360/convert-lstm-graph-with-tflite-fails

During inference, batch size = 1, 10 inputs, each input is of length 2560

Looks like DeepLab is converted successfully. For other issues please open separate bugs with additional information to help us debug this better.


Initial Commit for Primary Secondary Page Template

Not sure if Primary-Secondary is an appropriate name.
The demo looks like this

Is there somewhere we can see the current state of the design?  I haven't been in the latest meetings, I'm interested in this naming convention... what are we imagining for potential future templates?

Sent you a link offline to the design. I don't think design has put too much thought into other templates yet, but you can probably imagine them based on how our existing pages are laid out.

Sent you a link offline to the design. I don't think design has put too much thought into other templates yet, but you can probably imagine them based on how our existing pages are laid out.

Thanks, that helps a lot, "primary" and "secondary" are well defined and used throughout the doc, but it doesn't imply all templates would follow this kind of name if it doesn't make sense (like in a single panel and three panel layout).  I think this looks like a good start!


Unexpected Results

I ran the demo code available in python-demo/ folder for the butterfly test image. The output is very different from what is expected based on the publication (ECCV 2014 - https://www.cs.nyu.edu/~fergus/papers/zeilerECCV2014.pdf). It is attached below:-

I am using the caffe fork at https://github.com/piergiaj/caffe
make runtest fails at one of the test cases
[ RUN      ] NetUpgradeTest.TestUpgradeV1LayerType
/media/data/aravindh/Software/caffe/piergiaj/caffe/src/caffe/test/test_upgrade_proto.cpp:2897: Failure
Value of: V1LayerParameter_LayerType_IsValid(i)
Actual: false
Expected: true
[  FAILED  ] NetUpgradeTest.TestUpgradeV1LayerType (1 ms)
[----------] 4 tests from NetUpgradeTest (13 ms total)

This has to do with the lines that select the features to send back to the input space (roughly line 68 in the demo code):
feat = net.blobs['pool5'].data
feat[0][feat[0] < 150] = 0
If you adjust which features are used, you will get different images.

Hello @aravindhm
I have the same problem with you.Have you already solved it ?And Can you give me some advises to  work it out. 3Q very much.


Expose the new_x parameter in the Rust interface

The implementation of the new_x parameter, as discussed in #10. To avoid having to fallback on interior mutability, the trait methods that contain the new_x parameter also require a &mut self reference. I don't think that should be a limitation for a typical application.
Caching still needs to be implement on the model side. In my application, the evaluation of the objective and the constraints happens simultaneously and is expensive, therefore, caching the results improves the performance significantly and is worth the additional coding effort. In many simpler cases the argument will probably simply be ignored, which would also be the case, if the C interface is called directly without the Rust wrapper.

Thank you for the PR!
I think this makes sense. Would you be able to add a comment to the traits requiring &mut self explaining that mut requirement is solely for internal caching?

Thinking about it a bit more, I concluded that this is actually the natural use case for interior mutability, so I changed the &mut selfs back to &self.

Fixes #10


dependency chaining error with APEX

Expected Behavior
HPX builds
Actual Behavior
APEX now depends on the new collectives module, but this dependency chain failure is within HPX.  Because the barrier_node.cpp file uses an annotated function, it pulls in APEX headers, which pull in other HPX headers, causing the collectives module to depend on the hardware module.
See http://omega.nic.uoregon.edu:8020/#/builders/5/builds/4 for details (the collectives dependency error has been fixed)
Steps to Reproduce the Problem

cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DBOOST_ROOT=/home/users/khuck/src/hpx/boost_delphi_1.65.1 -DTCMALLOC_ROOT=/usr/local/packages/gperftools/git-gcc7 -DHPX_WITH_MALLOC=tcmalloc -DCMAKE_INSTALL_PREFIX=. -DHPX_WITH_THREAD_IDLE_RATES=ON -DHPX_WITH_PARCELPORT_MPI=ON -DHPX_WITH_PARCEL_COALESCING=ON -DHPX_WITH_TOOLS=ON -DHPX_WITH_STACKOVERFLOW_DETECTION_DEFAULT=OFF -DHPX_WITH_THREAD_MANAGER_IDLE_BACKOFF=OFF -DHPX_WITH_APEX=TRUE -DAPEX_WITH_ACTIVEHARMONY=TRUE -DACTIVEHARMONY_ROOT=/usr/local/packages/activeharmony/4.6.0-gcc -DAPEX_WITH_OTF2=TRUE -DOTF2_ROOT=/usr/local/packages/otf2-2.1 -DAPEX_WITH_PAPI=TRUE -DPAPI_ROOT=/usr/local/packages/papi/papi/5.7.0 -DHPX_WITH_APEX_NO_UPDATE=TRUE -DHPX_WITH_APEX_TAG=develop -DAPEX_WITH_BFD=TRUE -DBFD_ROOT=/usr/local/packages/binutils/2.27 -DHPX_WITH_MAX_CPU_COUNT=72 /home/users/khuck/src/hpx
make

Specifications

HPX Version: stable
Platform (compiler, OS): GCC on Linux

@khuck is the problem gone after 118bf2e1ce81ef585f32511f54b123a157e91903 (merged yesterday)? Our pycicle builder with APEX is now happy again.

@msimberg yes, all good!

Fixed by #4093.


Getting "no matches found" to any URL

yt-dlp [anyURL] always returns zsh: no matches found: [anyURL]
MacOS 11.6, yt-dlp 2021.9.5. Any tips?

Its your shell's fault. Quote the URL


Collection of patches

Minor fix to the v4.19 support (AMPDU)
Added kernel v5.0-rc1 support
Added version to README.md

Hi, could you please tell how is this different https://github.com/Mange/rtl8192eu-linux-driver?


Oculus Quest Packet Loss?

I wanted to try running SteamVR for the first time on the Quest when I encountered an issue with SteamVR not detecting my headset. After a quick glance through the forums to no avail, I took another look at the ALVR application tab when I noticed what might be the issue

how do I fix this?
edit: pardon me while I undoxx myself

+1. I am having an identical issue.
Quest is on the same network as the desktop.
-Quest is wireless, Desktop is Ethernet.
Firewall permissions have been applied to desktop.
Router has no (apparent) rules blocking access between wireless and wired LAN.
Steam VR is hung up in setup. In the 'Establish Tracking' section, I have an error message reading 'Headset Not Visible'
I have a Charter/Spectrum 5Ghz Router.

Did you tried running ALVR on another internet, if you don't have any you can try using your phone hotspot, if this is working the problem is your internet connection, maybe your router can't handle streaming on lan.

Try disable your firewall and antivirus completely to see if that makes any difference.


feat: react player component

Ok the rebasing didn't help. Closing this PR and reopening it one commit earlier.


Failed to retrieve script func: player_connected

Summary
Upon new player login, the server is trying to load a Lua function and fails. Critical: Failed to retrieve script func: player_connected
Doesn't appear to cause any instability, but we should correct the issue.

This error means that entities.lua is failing to load for the map in question, presumably Outbreak in this case. There's probably some info in the server console that will give more insight as to the source of the failure, especially if it came from an scripting error.


React Native: Pod ld: framework not found

This has been driving me crazy for a week now.
So I've been using fastlane for over a year now to automate my builds and upload to Apple.
Recently I added a Pod and ever since the build will fail (see below).
It compiles and runs fine from xcode and 'react-native run-ios'.
I've added the 'workspace: ' option to the 'build_app'.
I've changed the scheme (Scribe) to use the workspace instead of just project.
It Seems like it's the usual problem when it's trying to compile just the project instead of the workspace, but I can't figure out why it would be doing that.
Error when building:
▸ Linking Scribe
❌  ld: framework not found TwilioVideo
❌  clang: error: linker command failed with exit code 1 (use -v to see invocation)
** ARCHIVE FAILED **
Question Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Question Subject
Fastlane build
Question Description

✅ fastlane environment ✅
Stack

Key
Value

OS
10.14.4

Ruby
2.2.4

Bundler?
false

Git
git version 2.15.0

Installation Source
~/.fastlane/bin/bundle/bin/fastlane

Host
Mac OS X 10.14.4 (18E226)

Ruby Lib Dir
~/.fastlane/bin/bundle/lib

OpenSSL Version
OpenSSL 1.0.2g  1 Mar 2016

Is contained
false

Is homebrew
true

Is installed via Fabric.app
false

Xcode Path
/Applications/Xcode.app/Contents/Developer/

Xcode Version
10.2.1

System Locale

Variable
Value

LANG
en_US.UTF-8
✅

LC_ALL
en_US.UTF-8
✅

LANGUAGE
en_US.UTF-8
✅

fastlane files:
`./fastlane/Fastfile`
default_platform(:ios)

platform :ios do
  desc "Push a new build to TestFlight"
  lane :beta do
    #increment_build_number(xcodeproj: "Scribe.xcodeproj")
    #cocoapods(
    #  podfile: "Podfile",
    #  use_bundle_exec: true
    #)
    build_app(
      scheme: "Scribe",
      silent: true,
      #clean: true,
      workspace: "Scribe.xcworkspace"
    )
    upload_to_testflight
  end

  desc "Bump version"
  lane :bump do
    increment_build_number(xcodeproj: "Scribe.xcodeproj")
  end

  desc "Upload to TestFlight"
  lane :upload do
    upload_to_testflight
  end
end

`./fastlane/Appfile`
```ruby
app_identifier("XXXXX") # The bundle identifier of your app
apple_id("XXXXX") # Your Apple email address
itc_team_id("XXXXX") # iTunes Connect Team ID
team_id("XXXXXX") # Developer Portal Team ID
For more information about the Appfile, see:
https://docs.fastlane.tools/advanced/#appfile

### fastlane gems

| Gem      | Version | Update-Status |
| -------- | ------- | ------------- |
| fastlane | 2.123.0 | ✅ Up-To-Date  |

### Loaded fastlane plugins:
**No plugins Loaded**

Loaded gems

| Gem                       | Version      |
| ------------------------- | ------------ |
| slack-notifier            | 2.3.2        |
| atomos                    | 0.1.3        |
| CFPropertyList            | 2.3.5        |
| claide                    | 1.0.2        |
| colored2                  | 3.1.2        |
| nanaimo                   | 0.2.6        |
| xcodeproj                 | 1.8.1        |
| rouge                     | 2.0.7        |
| xcpretty                  | 0.3.0        |
| terminal-notifier         | 2.0.0        |
| unicode-display_width     | 1.1.3        |
| terminal-table            | 1.7.3        |
| plist                     | 3.2.0        |
| public_suffix             | 2.0.5        |
| addressable               | 2.5.1        |
| multipart-post            | 2.0.0        |
| word_wrap                 | 1.0.0        |
| tty-screen                | 0.6.5        |
| tty-cursor                | 0.6.0        |
| tty-spinner               | 0.8.0        |
| babosa                    | 1.0.2        |
| colored                   | 1.2          |
| highline                  | 1.7.8        |
| commander-fastlane        | 4.4.6        |
| excon                     | 0.55.0       |
| faraday                   | 0.12.1       |
| unf_ext                   | <IP_ADDRESS>      |
| unf                       | 0.1.4        |
| domain_name               | 0.5.20170404 |
| http-cookie               | 1.0.3        |
| faraday-cookie_jar        | 0.0.6        |
| fastimage                 | 2.1.0        |
| gh_inspector              | 1.1.3        |
| json                      | 1.8.1        |
| mini_magick               | 4.5.1        |
| multi_json                | 1.12.1       |
| multi_xml                 | 0.6.0        |
| rubyzip                   | 1.2.2        |
| security                  | 0.1.3        |
| xcpretty-travis-formatter | 0.0.4        |
| dotenv                    | 2.2.0        |
| bundler                   | 1.14.6       |
| faraday_middleware        | <IP_ADDRESS>     |
| naturally                 | 2.2.0        |
| simctl                    | 1.6.5        |
| uber                      | 0.0.15       |
| declarative               | 0.0.10       |
| declarative-option        | 0.1.0        |
| representable             | 3.0.4        |
| retriable                 | 2.1.0        |
| mime-types-data           | 3.2016.0521  |
| mime-types                | 3.1          |
| jwt                       | 1.5.6        |
| signet                    | 0.9.2        |
| memoist                   | 0.16.0       |
| os                        | 0.9.6        |
| googleauth                | 0.6.7        |
| httpclient                | 2.8.3        |
| google-api-client         | 0.23.9       |
| google-cloud-env          | 1.0.5        |
| google-cloud-core         | 1.2.7        |
| digest-crc                | 0.4.1        |
| google-cloud-storage      | 1.15.0       |
| emoji_regex               | 0.1.1        |
| libxml-ruby               | 3.0.0        |
| psych                     | 2.0.8        |

*generated on:* **2019-05-16**

Figures - right after I post this I figure it out.
The issue was a slightly different configuration between debug and release.
In Build Settings, Framework Search Paths and Library Search Paths, debug had $(inherited) but release did not.  Adding it $(inherited) seems to have fixed the issue.


Migration for Public Experiments/MODIFY_DATE

Make sure we have the public experiments' modify_date there on migration, and auto-update it.

see #3


could add a  passwd for login

If we are on the public network, the ip:port will be exposed, and the data will be tampered with by others, so it will be better to add login authentication

If you install obsidian-remote in Docker, you could proxy it through Nginx Proxy Manager, and use an access list to provide user authentication.  The obsidian-remote container would have to be on the same network as Nginx Proxy Manager.  This video talks about it: https://www.youtube.com/watch?v=G9voYZejH48

In the readme https://github.com/sytone/obsidian-remote#hosting-behind-a-reverse-proxy has an example setup in nginx to proxy to the container.

Added notes from this thread to docs. Thanks @fahrenhe1t


partition pruning fct_ga4__pages

Description & motivation
The fct_ga4__pages model was missing is_incremental checks causing it to process more data than needed. This PR fixes that.
Checklist

[ y] I have verified that these changes work locally
[n/a ] I have updated the README.md (if applicable)
[n/a ] I have added tests & descriptions to my models (and macros if applicable)
[ y] I have run dbt test and python -m pytest . to validate existing tests

I fixed the config block.
I can't reproduce the Database error. I fixed exactly that error in 5a445d21ada96b61834ea390b2a71f249c189e99. Maybe you somehow got the older version of this branch when you reviewed.


fixes, cleanup

I've fixed some improper shell quoting, exported a var that was set uselessly, and cleaned up the code a bit.
I'm also going to open an issue on --zerossl-email= handling, which seems broken.

@mralusw This PR was not seen quite a while. Do you want to fix and update it? Are the problems still there? Or shall I close the PR?


Moving car animation effect

I have created a moving car animation effect. I want to add it please assign it to me.

@Areebah03 Add ss or video!


KubernetesV1: Updating from<EMAIL_ADDRESS>to azure-pipelines-ta…

<EMAIL_ADDRESS>
Also moved KubernetesV1

from 'kubernetes-common' to 'kubernetes-common-v2'
from 'docker-common' to 'docker-common-v2'
from 'azure-arm-rest' to 'azure-arm-rest-v2'
from 'utility-common' to 'utility-common-v2'

Bumped up patch version

Given that kubernetes-common is not being used by any other task, we can remove the folder altogether, right?

Given that kubernetes-common is not being used by any other task, we can remove the folder altogether, right?

kubernetesV0 and helmInstallerV0 are still using it


Error in simulator after fresh setup

After fresh install and new project creation, it's not possible to run Simulator.
Error:
DeviceScript - Install Node.JS dependencies to enable tools.

Installation went OK, only one notice:  YN0031: │ One or more node_modules have been detected and will be removed. This operation may take some time.

Environment:
Linux
NodeJs v18.12.1
Yarn 3.3.0

Looks like there is no support for Yarn (other than v1). It's probably needed to add .yarnrc.yml with nodeLinker: node-modules - that seems to fix it.

We are still using yarn v1, are you saying .yarnrc.yml should be added to the generated files? thanks for reporting!

If I understand correctly how init.ts works, this might fix it...
https://github.com/microsoft/devicescript/pull/406

In 2.9.13. Thanks!


project lifetime dates #1536

Summary of the discussion
I added (de)commissioning start/end, as proposed in #1536 and changed the classification of time stamp.
To do: discuss the relation has time stamp
Type of change (CHANGELOG.md)
Add

(de)commissioning start/end

Update

time stamp

Workflow checklist
Automation
Closes #1536
PR-Assignee

[ ] 🐙 Follow the Pull Request Workflow
[ ] 📝 Update the CHANGELOG.md
[ ] 📙 Add #'s to term tracker item

Reviewer

[ ] 🐙 Follow the Reviewer Guide
[ ] 🐙 Provided feedback and show sufficient appreciation for the work done

I leave the has time stamp axiom out for this PR and prepare a solution to be discussed separately.


fix: observer panic

see kubernetes-sigs/controller-runtime#1607 for log issue.

this version, no panic, no error, just run !


Insert Battery replacement date

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Would it be possible to add the ability to insert the battery replacement date when configuring a new entity for the first time. Currently you can select battery replaced but this may not be the date the battery was replaced.
Describe alternatives you've considered
Is there a place you can go and change the date replaced once you have updated the replacement date.
Additional context
None

Hi,
You can manually set a replacement date using the service call here
https://andrew-codechimp.github.io/HA-Battery-Notes/services/#battery_notesset_battery_replaced

Wow fast response. Got this to work. Thank you so much


PersonalAccessToken not set on GitHub Service Endpoint

Azure Cli Version:  2.12.1
Azure-Devops extension version: 0.18.0
I am trying to create a GitHub service connection using the az devops service-endpoint github create command but I can't seem to set the personal access token (PAT).
Steps to reproduce:

Create a GitHub PAT

Set the environment variable according to the docs:
 export AZURE_DEVOPS_EXT_GITHUB_PAT=<PAT>

Run the command:
 az devops service-endpoint github create \
 --github-url https://github.com \
 --name MyServiceConnection  \
 --org <MyOrganization>
 --project <MyProject>

The accessToken is always set to null in the output and if I browse to the portal (dev.azure.com/MyOrganization) to verify the connection, it's not there either:
{
  "administratorsGroup": null,
  "authorization": {
	"parameters": {
	  "accessToken": null
	},
	"scheme": "PersonalAccessToken"
  },
  "createdBy": {
	...
  },
  "data": {},
  "description": null,
  "groupScopeId": null,
  "id": "08611b67-f551-406c-b2bd-df30f369f7d4",
  "isReady": true,
  "isShared": false,
  "name": "MyServiceConnection",
  "operationStatus": null,
  "owner": "library",
  "readersGroup": null,
  "serviceEndpointProjectReferences": [
	{
	  "name": "MyServiceConnection ",
	  "projectReference": {
		"id": "...",
		"name": null
	  }
	}
  ],
  "type": "github",
  "url": "https://github.com"
}

I get the same result if I don't set the AZURE_DEVOPS_EXT_GITHUB_PAT environment variable but enter the PAT manually in the prompt.
What am I doing wrong?

Did you ever solve this? I am having the same issue.


Run seed data migration on test nets

Right now they are only enabled in development. We should enable them everywhere except main net (network id 1).

Finished by https://github.com/OriginProtocol/origin-js/pull/117


delete registries if migstorage goes unready

fixes #626
depends on #620

I have manually tested this with the case of bad credentials for a mig-storage

@alaypatel07 still working on this?

Closing in favor of #681


AttributeError: 'NoneType' object has no attribute 'step'

upon requesting target=movingAverage(stats.*.deploy.*.clearapc.duration.sum,10) I get:
{"exception": "AttributeError(\"'NoneType' object has no attribute 'step'\",)", "event": "Exception"}
{"event": "Traceback (most recent call last):\n"}
{"event": "  File \"/usr/local/lib/python2.7/dist-packages/flask/app.py\", line 1817, in wsgi_app\n    response = self.full_dispatch_request()\n"}
{"event": "  File \"/usr/local/lib/python2.7/dist-packages/flask/app.py\", line 1477, in full_dispatch_request\n    rv = self.handle_user_exception(e)\n"}
{"event": "  File \"/usr/local/lib/python2.7/dist-packages/newrelic-<IP_ADDRESS>/newrelic/hooks/framework_flask.py\", line 86, in _nr_wrapper_Flask_handle_exception_\n    return wrapped(*args, **kwargs)\n"}
{"event": "  File \"/usr/local/lib/python2.7/dist-packages/flask/app.py\", line 1381, in handle_user_exception\n    reraise(exc_type, exc_value, tb)\n"}
{"event": "  File \"/usr/local/lib/python2.7/dist-packages/flask/app.py\", line 1475, in full_dispatch_request\n    rv = self.dispatch_request()\n"}
{"event": "  File \"/usr/local/lib/python2.7/dist-packages/flask/app.py\", line 1461, in dispatch_request\n    return self.view_functions[rule.endpoint](**req.view_args)\n"}
{"event": "  File \"/usr/local/lib/python2.7/dist-packages/newrelic-<IP_ADDRESS>/newrelic/hooks/framework_flask.py\", line 30, in _nr_wrapper_handler_\n    return wrapped(*args, **kwargs)\n"}
{"event": "  File \"/usr/local/lib/python2.7/dist-packages/graphite_api/app.py\", line 394, in render\n    series_list = evaluateTarget(context, target)\n"}
{"event": "  File \"/usr/local/lib/python2.7/dist-packages/graphite_api/app.py\", line 470, in evaluateTarget\n    result = evaluateTokens(requestContext, tokens)\n"}
{"event": "  File \"/usr/local/lib/python2.7/dist-packages/graphite_api/app.py\", line 480, in evaluateTokens\n    return evaluateTokens(requestContext, tokens.expression)\n"}
{"event": "  File \"/usr/local/lib/python2.7/dist-packages/graphite_api/app.py\", line 492, in evaluateTokens\n    return func(requestContext, *args, **kwargs)\n"}
{"event": "  File \"/usr/local/lib/python2.7/dist-packages/graphite_api/functions.py\", line 867, in movingAverage\n    seconds=bootstrapSeconds)\n"}
{"event": "  File \"/usr/local/lib/python2.7/dist-packages/graphite_api/functions.py\", line 2024, in _fetchWithBootstrap\n    if bootstrap.step != original.step:\n"}
{"event": "AttributeError: 'NoneType' object has no attribute 'step'\n"}

requesting target=stats.*.deploy.*.clearapc.duration.sum works fine
i can provide more data if you want (tell me where to add logger calls or whatever and i'll run it)

Got the same error since I updated to v1.1. Can give some more info upon request.

@zyegfryed 1.1 returns the full traceback in the HTTP response, can you share it?

@brutasse sure, here it is:
Stacktrace (most recent call last):
  File "flask/app.py", line 1817, in wsgi_app
    response = self.full_dispatch_request()
  File "flask/app.py", line 1477, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "flask/app.py", line 1381, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "flask/app.py", line 1475, in full_dispatch_request
    rv = self.dispatch_request()
  File "flask/app.py", line 1461, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "graphite_api/app.py", line 401, in render
    series_list = evaluateTarget(context, target, data_store)
  File "graphite_api/app.py", line 496, in evaluateTarget
    result = evaluateTokens(requestContext, tokens, data_store)
  File "graphite_api/app.py", line 506, in evaluateTokens
    return evaluateTokens(requestContext, tokens.expression, data_store)
  File "graphite_api/app.py", line 514, in evaluateTokens
    arg, data_store) for arg in tokens.call.args]
  File "graphite_api/app.py", line 506, in evaluateTokens
    return evaluateTokens(requestContext, tokens.expression, data_store)
  File "graphite_api/app.py", line 520, in evaluateTokens
    ret = func(requestContext, *args, **kwargs)
  File "graphite_api/functions.py", line 729, in movingMedian
    seconds=bootstrapSeconds)
  File "graphite_api/functions.py", line 2091, in _fetchWithBootstrap
    if bootstrap.step != original.step:

Here's some context about the error:

FYI when I expand the context for both b and bootstrap, all the 49 values are None.

@zyegfryed can you try with the commit I added a couple of days ago? Are you using carbon/whisper or something else?

@brutasse yes, I'm gonna try it today and let you know. I'm using carbon/whisper with statsite in front.

Ok -- I still see the issue in some cases with whisper, which is why I didn't close the issue with my commit. But it happens less often now.

Not better for me I'm afraid  :(
I keep getting the error raised, everytime...

I also am encountering this issue with the latest version master. Same stack trace as well.

@brutasse I can confirm it resolved the issue for me. Thanks a lot!

@zyegfryed great, thanks for confirming :)


[type:Integration Test] add integrated-test of logging-rocketmq-plugin

This pr is used to test whether rocketmq is integrated into shenyu.
The test case steps are as follows:

Add a message to rocketmq
Consume this information

If the consumption is successful, it means that rocketmq is integrated into shenyu. If the consumption fails, an exception will be thrown, indicating that there is a problem with rocketmq.

Codecov Report

Merging #3672 (fee5be7) into master (635aca1) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #3672      +/-   ##
============================================
- Coverage     62.47%   62.37%   -0.10%
+ Complexity     5795     5770      -25
============================================
  Files           893      893
  Lines         24371    24371
  Branches       2217     2217
============================================
- Hits          15225    15202      -23
- Misses         7762     7784      +22
- Partials       1384     1385       +1

Impacted Files
Coverage Δ

.../apache/shenyu/admin/model/dto/BatchCommonDTO.java
50.00% <0.00%> (-7.15%)
:arrow_down:

...apache/shenyu/admin/model/dto/AuthPathWarpDTO.java
57.14% <0.00%> (-7.15%)
:arrow_down:

...org/apache/shenyu/admin/model/dto/AuthPathDTO.java
58.82% <0.00%> (-5.89%)
:arrow_down:

...nyu/plugin/motan/cache/ApplicationConfigCache.java
52.00% <0.00%> (-5.00%)
:arrow_down:

...che/shenyu/admin/model/vo/DashboardUserEditVO.java
60.86% <0.00%> (-4.35%)
:arrow_down:

...ache/shenyu/admin/model/dto/DataPermissionDTO.java
59.25% <0.00%> (-3.71%)
:arrow_down:

...rg/apache/shenyu/admin/model/page/CommonPager.java
44.82% <0.00%> (-3.45%)
:arrow_down:

...he/shenyu/admin/model/vo/DataPermissionPageVO.java
50.00% <0.00%> (-3.34%)
:arrow_down:

...a/org/apache/shenyu/admin/model/dto/PluginDTO.java
64.51% <0.00%> (-3.23%)
:arrow_down:

...rg/apache/shenyu/admin/model/dto/AuthApplyDTO.java
66.66% <0.00%> (-2.57%)
:arrow_down:

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 635aca1...fee5be7. Read the comment docs.

@JooKS-me  please review this pr,thanks~


Functionality to dynamically add eventhandlers at runtime

Is your feature request related to a problem? Please describe.
I'm working on a serverside Blazor project that has the goal to dynamically render components and add them to the view. The dynamic addition of components works fine already.
The next step is to dynamically add eventhandlers to the specific components (e.g.
the @onclick="" from this element:
<button @onclick="() => Callback()">Dynamic button with event handler</button>
).
These attributes should only be added when the handler is set.
Describe the solution you'd like
The easiest solution would be to add eventhandlers to html attributes only when there is at least one callback defined.
Additional context
This feature should be implemented to reduce the traffic and resource consumption on dynamically created components.

@phillsonntag thanks for contacting us.
I believe this issue is a dupe of https://github.com/aspnet/AspNetCore/issues/13181 and I believe this work has already been done (at least partially).

Does this also work without using a value?


pass coordinates to php

Hellow! Thanks for cool app!
I use latest version of leafleat-geoman. Is it possible to draw for example circle and pass coordinates and radius of this circle to php function (I use laravel framework)
Thanks!

I don't know laravel but with javascript it is working like that:
map.on('pm:create',(e)=>{
  if(e.shape === 'Circle'){
    var layer = e.layer;
    sendToYourPhpApi(layer.getLatLngs(), layer.getRadius());
  }
});

sendToYourPhpApi is a custom function that you need to create. It should send an request to your php API. You can use fetch for this.

Thanks. Is it possible to pass data to php with post request (ajax for example) ?

Sure. It is always the same. You have the url of your PHP API File and send to them the data over an GET or post request

Javascript:
map.on('pm:create',(e)=>{
  if(e.shape === 'Circle'){
    var layer = e.layer;
    sendToYourPhpApi(layer.getLatLngs(), layer.getRadius());
  }
});

function sendToYourPhpApi(latlng, radius){
var url = "yourdomain.com/phpApiFile.php?lat="+latlng.lat+"&lng="+latlng.lng+"&radius="+radius
$.ajax({
  type: "GET",
  url: url,
  cache: false,
  success: function(data){
     console.log(data); // data should be like "Coords: 1, 2 Radius: 10"
  }
});
}

phpApiFile.php
$lat = $_GET["lat"];
$lng = $_GET["lng"];
$radius = $_GET["radius"];

echo "Coords: " . $lat . ", " . $lng . " Radius:".$radius

This is not tested but it should work

Super! But can be map container to place inside html form and coordinates send to server with post method with another form data?


Fix typo/misspelling

Motivation
Fix a potentially confusing typo in a few places
Changes
Only fixes typo, no logic changes

bors merge


Example app FATAL EXCEPTION: Data cannot occupy more than 10240 bytes when serialized

Hello,
Thank you for this incredible software!
As for the issue, I keep getting the following exception when running the example Android Flutter app:
E/AndroidRuntime(10886): FATAL EXCEPTION: WM.task-2 E/AndroidRuntime(10886): Process: com.android.statementservice, PID: 10886 E/AndroidRuntime(10886): java.lang.IllegalStateException: Data cannot occupy more than 10240 bytes when serialized E/AndroidRuntime(10886): 	at androidx.work.Data.toByteArrayInternal(Data.java:407) E/AndroidRuntime(10886): 	at androidx.work.Data$Builder.build(Data.java:957) E/AndroidRuntime(10886): 	at androidx.work.OverwritingInputMerger.merge(OverwritingInputMerger.java:44) E/AndroidRuntime(10886): 	at androidx.work.impl.WorkerWrapper.runWorker(WorkerWrapper.java:224) E/AndroidRuntime(10886): 	at androidx.work.impl.WorkerWrapper.run(WorkerWrapper.java:140) E/AndroidRuntime(10886): 	at androidx.work.impl.utils.SerialExecutor$Task.run(SerialExecutor.java:91) E/AndroidRuntime(10886): 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1137) E/AndroidRuntime(10886): 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:637) E/AndroidRuntime(10886): 	at java.lang.Thread.run(Thread.java:1012)
Things seem to work okay even after the exception in the example app.
A bit of an aside, maybe, but I am using the package in another app I'm building and frequently run into this. Occasionally my app will freeze up, and I suspect it might have something to do with this exception. I can't quite pin down the exact cause of the freezing there though, but it is a lead.
I have never done Android development without Flutter, so sadly I'm not sure I can be much assistance in resolving this.
Here is my flutter doctor -v output:
[✓] Flutter (Channel stable, 3.10.6, on macOS 13.4.1 22F770820d darwin-arm64, locale en-US)
    • Flutter version 3.10.6 on channel stable at /Users/awp/code/bin/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision f468f3366c (3 weeks ago), 2023-07-12 15:19:05 -0700
    • Engine revision cdbeda788a
    • Dart version 3.0.6
    • DevTools version 2.23.1

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/awp/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14E300c
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] VS Code (version 1.80.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.71.20230801

[✓] Connected device (2 available)
    • Pixel 4a 5G (mobile) • 0B171JECB21218 • android-arm64  • Android 13 (API 33)
    • Chrome (web)         • chrome         • web-javascript • Google Chrome 115.0.5790.114

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Hello,
It looks like the problem is related to the WorkManager used to load the model in a separate thread.
In fact, I replaced the current implementation with FFI in https://github.com/alphacep/vosk-flutter/tree/feat/android-ffi , but haven't yet merged it to master. You could give it a try.

I will give it a try when I get a chance. Thank you!


Add :MirrorConfigReload command

Hello! It's me again to bother you.
I've written myself a small function that runs when I open project files that checks whether the project is already in the mirrors.yml file with readfile() and match() and if not it appends a rudimentary config for that particular project using writefile().
The issue is, your plugin does not recognize the fact that a new project has been added to my mirrors.yml and i have to restart vim in order for this to take effect.
Don't know how hard adding a :MirrorConfigReload command would be to implement but I think it's an essential feature.
YO!

 THANKS a bunch!
I see the change wasn't that hard. That just shows that your design is good :D.


Add toInt

Regarding #30 but didn't think of it very much. Seems to work.

Thank you for your contribution!
Not sure if that's the best way to implement it. Does it fail in the right cases?
In general, I think it would be a good idea to add some tests. And test for edge cases, in particular.

yeah, will do. If it fails to work as expected I'll do it through FFI

Could you check it now? @sharkdp

Is the CI properly set?

Currently fails with
* Build successful.
* Running tests...
* ERROR: Entry point module (Test.Main) not found.
The command "npm run -s build" exited with 1.
0.47s$ bower install
The command "bower install" exited with 0.
0.22s$ npm -s test
The command "npm -s test" exited with 1.

Not related to your PR. Haven't updated the CI pipeline in a long time :-/. It would be great to fix this first, but I can also merge your changes and release a new version, if you need that for another project.

Tests are passing on my side. This is not urgent as the fix was really simple so I can workaround it in my project by redefining that function.

I migrated the CI pipeline to GitHub Actions. Builds succeed now. Thank you!


Azure Monitor OpenTelemetry Exporter (January - June 2021)

This epic tracks the work required by the Azure SDK team to support the OpenTelemetry 1.0/stable release in .NET, Java, JavaScript, and Python

[ ] Update Azure.Core to the latest OpenTelemetry 1.0/stable release
[ ] Test for OpenTelemetry breaking changes by collecting plain text and Jaeger traces for REST based SDKs (ex: Storage)

[ ] File Azure SDK tracking issues & fix bugs to become complaint with the latest OpenTelemetry specification

[ ] Test for OpenTelemetry breaking changes by collecting plain text and Jaeger traces for AMQP based SDKs (ex: Service Bus)

[ ] File Azure SDK tracking issues & fix bugs to become complaint with the latest OpenTelemetry specification

[ ] Collect portal snapshots for REST and AMQP based SDKs and compare results against Jaeger

[ ] File Azure Monitor tracking issues on traces that are not exported / displayed correctly

Closing previous semester epic


44 recognizer setup

Single and double header files hold the recognize functions for the c files corresponding to the different gestures.

Closing this because #69 is the same code but with actual content


Option to not crawl Frames

<frame> tags are crawled but as they are now deprecated and mostly blocked by modern browsers, it seems like a waste of processing time in the majority of cases, where the website is known not to use them. Could a config option be added to not crawl them? I'd be happy to add this.

But isn’t all of the HTML scanned a second time with the second call to the function get_links with the regex to look for frames. I assumed that doing a second scan would add to the runtime.

I mean yeah, it does. I doubt it's non negligible though. Most of the time is spent making network connections.
Maybe it does. Feel free to run some benchmarks.


feat: add request cancellation functionality

PR Description
Added request cancellation functionality.
Related Issues

#109

Checklist

[x] I have gone through the contributing guide
[x] I have updated my branch and synced it with project main branch before making this PR
[x] I am using the latest Flutter stable branch (run flutter upgrade and verify)
[x] I have run the tests (flutter test) and all tests are passing

Added/updated tests?

[ ] Yes
[x] No, and this is why: Implementation focuses on request cancellation functionality.

OS on which you have developed and tested the feature?

[ ] Windows
[ ] macOS
[x] Linux

Changes
HTTP Client Management

Added handling for http.ClientException in request cancellation scenarios
Implemented client instance management per request ID

UI Updates

Modified SendButton to toggle between Send/Cancel states
Updated ResponsePane to show cancellation status
Updated ResponsePaneHeader with cancellation message support

Detailed Implementation Changes
packages/apidash_core/lib/services/http_service.dart

Added specific exception handling for request cancellation:

if (e.message.contains('Connection closed') || e.message.contains('abort')) {
  return (null, null, 'Request Cancelled');
} else {
  return (null, null, e.toString());
}

lib/providers/collection_provider.dart

Introduced client management with a map to store HTTP clients:

final Map<String, http.Client> _clients = {};

Enhanced sendRequest method:

final client = http.Client();
_clients[id] = client;

Added cancelRequest method:

void cancelRequest(String id) {
  _clients[id]?.close();
  _clients.remove(id);
  // Update the request state to reflect cancellation
}

lib/screens/home_page/editor_pane/details_card/response_pane.dart

Added cancellation UI handling:

if (message == "Request Cancelled") {
  return ErrorMessage(
    message: '$message',
    showIssueButton: false,
  );
}

lib/screens/home_page/editor_pane/url_card.dart

Updated SendRequestButton with cancellation support:

return SendButton(
  isWorking: isWorking ?? false,
  onTap: () {
    ref.read(collectionStateNotifierProvider.notifier).sendRequest(selectedId!);
  },
  onCancel: () {
    ref.read(collectionStateNotifierProvider.notifier).cancelRequest(selectedId!);
  },
);

lib/widgets/button_send.dart

Updated SendRequestButton with cancellation support.

lib/widgets/response_widgets.dart

Added cancellation message handling:

if (message == "Request Cancelled") {
  return ErrorMessage(
    message: '$message',
    showIssueButton: false,
  );
}

Changes

Created a new HttpClientManager singleton in apidash_core to manage HTTP clients:
// filepath: packages/apidash_core/lib/services/client_manager.dart
class HttpClientManager {
  static final HttpClientManager _instance = HttpClientManager._internal();
  final Map<String, http.Client> _clients = {};

  // Create and track client for each request
  http.Client createClient(String requestId) { }

  // Cancel and cleanup client
  void cancelRequest(String requestId) { }
}

Updated HTTP service to use HttpClientManager:

Updated Tests for the Send Button

Hi @ashitaprasad,
I’ve made the updates based on your suggestions, including implementing the HttpClientManager singleton to handle HTTP clients and updating the HTTP service to use it. The tests for the Send Button have also been adjusted accordingly.
Regarding the strings 'Connection closed' and 'abort' in the exception handling: I went through the documentation but didn’t find any specific mention of these strings. So, I added them based on my own testing.
Let me know if you have any further feedback!

@sasanktumpati stop marking comments as resolved. The reviewer will review and mark it as resolved. You need to just add a comment that this comment has been addressed.

@sasanktumpati stop marking comments as resolved. The reviewer will review and mark it as resolved. You need to just add a comment that this comment has been addressed.

sorry for that

Regarding the strings 'Connection closed' and 'abort' in the exception handling: I went through the documentation but didn’t find any specific mention of these strings. So, I added them based on my own testing.

This should have been added as a comment to review comment where I had asked the question.

Regarding the strings 'Connection closed' and 'abort' in the exception handling: I went through the documentation but didn’t find any specific mention of these strings. So, I added them based on my own testing.

This should have been added as a comment to review comment where I had asked the question.

when we close a client, this is the error message

Regarding the strings 'Connection closed' and 'abort' in the exception handling: I went through the documentation but didn’t find any specific mention of these strings. So, I added them based on my own testing.

This should have been added as a comment to review comment where I had asked the question.

 when we close a client, this is the error message

Which means that the state changes being made in this function is redundant and not having any impact
void cancelRequest(String id) {
    httpClientManager.cancelRequest(id);
    var currentModel = state![id]!;
    var map = {...state!};
    map[id] = currentModel.copyWith(
      isWorking: false,
      message: 'Request Cancelled',
      responseStatus: null,
      httpResponseModel: null,
    );
    state = map;

Regarding the strings 'Connection closed' and 'abort' in the exception handling: I went through the documentation but didn’t find any specific mention of these strings. So, I added them based on my own testing.

This should have been added as a comment to review comment where I had asked the question.

 when we close a client, this is the error message

Which means that the state changes being made in this function is redundant and not having any impact
void cancelRequest(String id) {
    httpClientManager.cancelRequest(id);
    var currentModel = state![id]!;
    var map = {...state!};
    map[id] = currentModel.copyWith(
      isWorking: false,
      message: 'Request Cancelled',
      responseStatus: null,
      httpResponseModel: null,
    );
    state = map;

yeah, fixed that.

Any updates @sasanktumpati

Any updates @sasanktumpati

I have fixed then in the previous commit, now have to figure out something for the strings comparison

Any updates @sasanktumpati

I have fixed then in the previous commit, now have to figure out something for the strings comparison

Cool .. 👍

@ashitaprasad you can review it now

Hi @ashitaprasad,
Apologies again for the earlier confusion. Here's a summary of the latest commit:

Cancellation Tracking:

Introduced a Queue<String> to track cancelled request IDs.
Implemented a 'First In, First Out' approach with a maximum of 100 entries to avoid memory overhead.
Automatically removes older entries when the queue reaches its limit.

HTTP Service:

Integrated the queue to directly check if a request was cancelled within the request function.
Returns "Request cancelled" when a cancelled request is detected.

Hi @sasanktumpati Thanks for picking up this long pending issue and taking it to the finish line.


electron: Bump default version to v30

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 309248 run on x86_64-linux 1

1 package marked as broken and skipped:

itch

48 packages built:

affine
antares
bilibili
bitwarden-directory-connector
breitbandmessung
bruno
camunda-modeler
drawio
drawio-headless
electron
electron-bin
electron_29
electron_29-bin
fcast-receiver
freetube
geogebra6
headset
jitsi-meet-electron
koodo-reader
nix-tour
open-stage-control
pandoc-drawio-filter
pandoc-drawio-filter.dist
podman-desktop
pritunl-client
protonmail-desktop
python311Packages.mkdocs-drawio-exporter
python311Packages.mkdocs-drawio-exporter.dist
python312Packages.mkdocs-drawio-exporter
python312Packages.mkdocs-drawio-exporter.dist
r2modman
redisinsight
revolt-desktop
sharedown
standardnotes
stretchly
super-productivity
terra-station
tetrio-desktop
thedesk
threema-desktop
uhk-agent
uhk-udev-rules
uivonim
vesktop
vieb
youtube-music
ytdownloader

Can we rebase this PR ?

Can we rebase this PR ?

Why? What would change?

Blocking because of https://github.com/NixOS/nixpkgs/pull/309041#issuecomment-2094844146

This PR was merged , that's the reason why I requested the rebase. Am I misunderstanding something?

Blocking because of #309041 (comment)

This PR was merged , that's the reason why I requested the rebase. Am I misunderstanding something?

This PR here (#309248) was opened after #309041 had been merged.
And the reason I have a blocking review here, is because we need to fix https://github.com/NixOS/nixpkgs/pull/309041#issuecomment-2094844146 (something I commented after #309041 had already been merged).
The simplest would be simply reverting 6a7a561360b5593e70a8f8ab72393b13fb83dc8a for now, until a newer version of electron_30 is released.
There is a whole history to it (unfortunately):

fb10ea41b2a080cb4ecac34aa12cf056d8d3f90e
85dfe83a86658f3fba80c050a774195f08fb378d
#306010

As of now, there is no consumer of electron_30 in nixpkgs (except #308970 I suppose).
This would obviously drastically change with this PR here, which, well, changes the default to electron_30.

I tested starting element-desktop with electron_30 under wayland (sway) and it works fine, looks like it uses --ozone-platform-hint=auto.

Result of nixpkgs-review pr 309248 run on x86_64-linux 1

1 package marked as broken and skipped:

itch

45 packages built:

affine
antares
bilibili
bitwarden-directory-connector
breitbandmessung
bruno
camunda-modeler
drawio
drawio-headless
electron
electron-bin
fcast-receiver
freetube
headset
jitsi-meet-electron
koodo-reader
nix-tour
open-stage-control
pandoc-drawio-filter
pandoc-drawio-filter.dist
podman-desktop
pritunl-client
protonmail-desktop
python311Packages.mkdocs-drawio-exporter
python311Packages.mkdocs-drawio-exporter.dist
python312Packages.mkdocs-drawio-exporter
python312Packages.mkdocs-drawio-exporter.dist
r2modman
redisinsight
revolt-desktop
sharedown
standardnotes
stretchly
super-productivity
terra-station
tetrio-desktop
thedesk
threema-desktop
uhk-agent
uhk-udev-rules
uivonim
vesktop
vieb
youtube-music
ytdownloader


How do I download the gui

WHY CANT ANYONE SAY HOW TO DOWNLOAD THE GUI LIKE WHY I JUST WANT CLICKS FOR MY GD BOT WHY WHY WHY

zcb 2.0 has no gui. zcb 3 has it, i'll probably release it tomorrow

zcb 2.0 has no gui. zcb 3 has it, i'll probably release it tomorrow

use zcb 3: https://github.com/zeozeozeo/zcb3/releases/


Atom crashes when large files are opened

Description
Atom crashes when large files are opened. I have a JSON file of 10 MB (which is not that large), it opens for the first time, but when I scroll down I get a popup window saying - "The editor has crashed"
Versions
Atom
Atom    : 1.8.0
Electron: 0.36.8
Chrome  : 47.0.2526.110
Node    : 5.1.1
amp
apm  1.9.2
npm  2.13.3
node 0.10.40
python 3.5.1
git 2.8.1.windows.1
visual studio 2013

I also have the same problem when I open a 626KB JSON file using the same version of ATOM with my Macbook Pro running the latest version of OS X.

Tracking all these large-file issues in #12065.

This seems like a duplicate of https://github.com/atom/atom/issues/8864 – let's keep the discussion going there.

Hello from issue #12065. Atom Beta should fix this for many people.


"Unexpected token: name (CardComponent)" on Ionic Production Build

I just tried to run an Ionic production build (ionic run android --prod) on my android phone and this error showed up in the build process:
[00:22:40]  uglifyjs failed: SyntaxError: Unexpected token: name (CardComponent)
[00:22:40]  ionic-app-script task: "build"
[00:22:40]  Error: SyntaxError: Unexpected token: name (CardComponent)
Error
    at new JS_Parse_Error (eval at <anonymous> (/home/jan/IonicProjects/MeetsApp/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:1545:18)
    at js_error (eval at <anonymous> (/home/jan/IonicProjects/MeetsApp/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:1553:11)
    at croak (eval at <anonymous> (/home/jan/IonicProjects/MeetsApp/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2092:9)
    at token_error (eval at <anonymous> (/home/jan/IonicProjects/MeetsApp/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2100:9)
    at unexpected (eval at <anonymous> (/home/jan/IonicProjects/MeetsApp/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2106:9)
    at semicolon (eval at <anonymous> (/home/jan/IonicProjects/MeetsApp/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2126:56)
    at simple_statement (eval at <anonymous> (/home/jan/IonicProjects/MeetsApp/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2317:73)
    at eval (eval at <anonymous> (/home/jan/IonicProjects/MeetsApp/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2186:19)
    at eval (eval at <anonymous> (/home/jan/IonicProjects/MeetsApp/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2139:24)
    at block_ (eval at <anonymous> (/home/jan/IonicProjects/MeetsApp/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2432:20)

This error can also be reproduced with your Ionic Demo

Hi!
I did some search about this error and it seems to be specific at ionic-app-script: https://github.com/driftyco/ionic-app-scripts/issues/239
The two solutions are:

edit<EMAIL_ADDRESS>file. Then in that file update uglify-js like this "uglify-js": "git+https://github.com/mishoo/UglifyJS2.git#harmony".
Then after that execute npm install (make sure right now you're at node_modules/@ionic/app-scripts

or in case you don't need the uglify:

You can disable minification by running ionic run android --aot

Why was this closed it is still a serious issue with Ionic that it isn't working with AoT properly.


Add a wiki: Artery Gear

An anonymous user has submitted a new wiki via our submission form.
Link to origin wiki: https://artery-gear-fusion.fandom.com
Link to destination (independent) wiki: https://www.prydwen.gg/artery-gear/

Destination isn't an editable wiki (more of a database)


Add multi-LoRA support for more architectures

Currently, multi-LoRA supports only Llama and Mistral architectures. We should extend this functionality to all architectures.
Yi, Qwen, Phi and Mixtral architectures seem to be the most demanded right now.
One challenge will be ensuring that all allowed weight shapes are supported by punica kernels. We may need to investigate some sort of padding there.
Originally posted by @Yard1 in https://github.com/vllm-project/vllm/issues/1804#issuecomment-1882913208

Is it possible to add "GPT-NeoX" as well?

how about "chatglm" ?

@Yard1 I'm interested in extending this to other architectures, do you want to meet and talk about the problems that need to be solved to get it working?

+1, bump for Phi-3.0 (any Phi right now)

+1 for Qwen

+1 for Qwen


[feature request] contract testing

Hi all,
I started playing with this library and I found it super useful and much more maintainable than ugly fixtures.
But I quickly realized that one functionality would be the natural addition to this library: contract testing.
This would give a unification of the integration and contract testing strategies, where consumers and providers are kept always in sync by checking the contract at every execution and fixtures are abstracted and maintainer by the library (win-win :) )
Is this a functionality you would likely see as the scope of this library?
Thank you for providing such an amazing library.

If the API/UI contract is made available over a network call, you should be able to just use Polly directly. This is a great idea though and deserves some investigation on how we can make contract testing a first class feature. If you have some specific examples and/or use cases, please feel free to share them here.


Updates to your README!

Hey! Thought your README could use some help.
Devise is a well known solution for authentication in Rails applications. A library which a lot of newbies use.
I added a walkthrough video to the installation instructions. It's hosted on replayable.io, a company that's sponsoring my contributions.
If you accept my PR. We'll have our bot check your readme everyday for changes and notify us in case we need to update the video so its always up to date. We respond to changes real quick (usually within a day or two).
Let me know what you think or if you have any questions.
I believe these changes will help your users especially newbies.

This is cool! Thank you for the contribution. While I appreciate the effort here, I prefer to keep the readme free of links we can't control and can change along with code contributions.
Thank you again.


Change KubeArchive namespace because of ROSA

This PR aims to change the namespace of KubeArchive because ROSA does not support namespaces for applications that are kube.*, which matches kubearchive. I changed it to be product-kubearchive given that we don't have any other name and I didn't want to use our shorthand (k9e). I tested it on CRC with the prepare-crc.sh script and then the bootstrap-cluster.sh preview.

I added the konflux-kubearchive group to the list of groups that can see the clusters.

/retest


Feature: Show modification date while sorted by size.

Missing column to see modification date while sorted by size.

I think this can be implemented nicely using Shift + m to toggle the modification date on or off without affecting the sorting.
For symmetry, Shift + c should also be added that does the same but for the item count.
Lastly, I think it would be good to add Shift + s as alternative to (but without removing) g .
CC @piotrwach

@Byron roger that 🫡 😃 It should be simple little thing to add.

@ww7 This has now landed on main and should be in the next release.

Let's close this proactively, as I also believe the feature is now available.
I plan to make a release once this PoC is implemented, but if @gosuwachu tells me it should better happen now (the release), I will of course do that, too :).


Tensor::device() does not respect Tensor::to_device(...)

I ran into this issue when I'm working with multi-GPU training. Surprisingly, this test failed unexpectedly. The device() returns Cuda(1) after to_device(Cuda(0)). Suppose it an off-by-1 bug?
use tch::{Tensor, Device};

#[test]
fn test_device() {
    let x = Tensor::from(1).to_device(Device::Cuda(0));
    assert_eq!(x.device(), Device::Cuda(0)); // actually returns Device::Cuda(1)
}

Thanks for catching this, I just pushed a fix for it (and will add some test although it won't run on CI as there are no gpus there).

Many thanks.


Support for react 17?

Any way to up the peer dependancy to support React 17? Since RJSF already does support it seems odd this doesn't.

Would you mind making a PR? I'm not actively maintaining this library.

Would you mind making a PR? I'm not actively maintaining this library.

Sorry, I forgot to close this issue, I ended up using another solution since this library isn't maintained as you said.


Respect NERDTreeCustomOpenArgs when opening bookmark

Description
I have
let g:NERDTreeCustomOpenArgs = {'file': {'reuse': 'all', 'where': 't'}, 'dir': {}}

but this setting is ignored when opening any new bookmark.

I'm closing this. See commend in #1200.

I'm closing this. See commend in #1200.


Visitable init

Implements VISITABLE_INIT (copy initialization) and VISITABLE_DIRECT_INIT (direct initialization). See #13 for discussion.
Example usage:
struct FooBar {
    BEGIN_VISITABLES(FooBar);
    VISITABLE(std::string, foo);
    VISITABLE_INIT(bool, foo, true);
    VISITABLE_DIRECT_INIT(std::vector<int>, foo, {1, 2, 3});
    END_VISITABLES;
};

What is maybe missing are unit tests and readme update.
Fixes #13

Thanks for the PR! I will look at this later and at adding some tests (and fixing appveyor)


Total number of rows after the results

Hi,
Is there any way which can show the total number of rows returned as we type in the search box ?
Thanks,
Chintan

+1 Just need it :)

@loginetsolutions @chintanbanugaria Use mark.js with this simple example: https://jsfiddle.net/bs69vcqL/159/

@julmot mark.js looks like a great project, but please don't go spamming other people's projects with your own self-serving promotions -- especially because it doesn't look like you addressed @chintanbanugaria question.
@chintanbanugaria It's not built in by default, but you can probably accomplish what your looking for by implementing the complete function in the settings of sieve() and use that to count the currently visible matches.

It does... ;)

It does... ;)

Sorry, I don't see an active count of the number of matching rows in your example. Btw, that example table looks familiar.
Again, mark.js looks cool, but questions like this and your promotions are best spent on StackOverflow (or similar).


Do not rm -rf with a trailing empty var

This fix safeguard against potential attempted forced deletions of /etc/nginx/certs when trying to do rm -rf /etc/nginx/certs/$var with a var that is empty or contains only spaces.
See #288

Added real fix for #254 and #288 in addition to the rm -rf safeguard.


Fix flaky SegmentReplicationITs.

Signed-off-by: Marc Handalian<EMAIL_ADDRESS>
Description
This change fixes flakiness with segment replication ITs. It does this by updating the wait condition used to ensure replicas are up to date to wait until a searched docCount is reached instead of output of the Segments API that can change if there are concurrent refreshes.
It also does this by updating the method used to assert segment stats to wait until the assertion holds true rather than at a point in time.  This method is also updated to assert store metadata directly over API output.  In doing so I've moved the method used to compute store metadata on top of IndexShard.
I've run this about ~1k times on the file locally and not seeing any issues, will open this and run a few times to test from CI.
Issues Resolved
https://github.com/opensearch-project/OpenSearch/issues/5669 - note not all tests in this issue will be resolved with this change, only those with doc count mismatches, particularly testReplicationAfterPrimaryRefreshAndFlush.
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff
[ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/9932/
CommitID: 175c90c
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

* What went wrong:
Execution failed for task ':distribution:bwc:staged:buildBwcLinuxTar'.
> Building 2.5.0 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/staged/build/bwc/checkout-2.5/distribution/archives/linux-tar/build/distributions/opensearch-min-2.5.0-SNAPSHOT-linux-x64.tar.gz

Codecov Report

Merging #6015 (030a6e1) into main (f9eb9bf) will increase coverage by 0.08%.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##               main    #6015      +/-   ##
============================================
+ Coverage     70.73%   70.82%   +0.08%
- Complexity    58738    58776      +38
============================================
  Files          4771     4771
  Lines        280820   280818       -2
  Branches      40568    40568
============================================
+ Hits         198645   198891     +246
+ Misses        65865    65632     -233
+ Partials      16310    16295      -15

Impacted Files
Coverage Δ

...in/java/org/opensearch/index/shard/IndexShard.java
70.33% <100.00%> (+0.33%)
:arrow_up:

.../indices/replication/SegmentReplicationTarget.java
92.92% <100.00%> (+1.66%)
:arrow_up:

...search/indices/recovery/RecoveryTargetHandler.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../java/org/opensearch/node/NodeClosedException.java
50.00% <0.00%> (-50.00%)
:arrow_down:

...ava/org/opensearch/action/NoSuchNodeException.java
0.00% <0.00%> (-50.00%)
:arrow_down:

.../aggregations/support/values/ScriptLongValues.java
34.88% <0.00%> (-34.89%)
:arrow_down:

...r/src/main/java/org/opensearch/http/HttpUtils.java
33.33% <0.00%> (-33.34%)
:arrow_down:

...adcast/BroadcastShardOperationFailedException.java
33.33% <0.00%> (-22.23%)
:arrow_down:

...org/opensearch/index/query/ExistsQueryBuilder.java
74.19% <0.00%> (-19.36%)
:arrow_down:

...opensearch/persistent/AllocatedPersistentTask.java
46.15% <0.00%> (-19.24%)
:arrow_down:

... and 475 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.indices.replication.SegmentReplicationIT.testDropPrimaryDuringReplication
      1 org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testIndexCreateBlockWithAReadOnlyBlock
      1 org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testIndexCreateBlockIsRemovedWhenAnyNodesNotExceedHighWatermark

URL: https://build.ci.opensearch.org/job/gradle-check/9937/
CommitID: 030a6e1
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

org.opensearch.indices.replication.SegmentReplicationIT.testDropPrimaryDuringReplication grr.. looking at this one...

last few runs related to DiskThresholdDeciderIT failures. https://github.com/opensearch-project/OpenSearch/issues/5956
I've run SR test testDropPrimaryDuringReplication overnight 1,150 times locally while running the entire test class and not able to repro this.  Will try some more today.  In the meantime improved the error msg and kicking off a few more check runs on this PR.

Precommit failure due to spotless check
* What went wrong:
Execution failed for task ':server:spotlessJavaCheck'.
> The following files had format violations:
      src/internalClusterTest/java/org/opensearch/indices/replication/SegmentReplicationIT.java
          @@ -210,7 +210,7 @@
           ·····*·<p>
1066 actionable tasks: 1065 executed, 1 from cache
           ·····*·TODO:·Ignoring·this·test·as·its·flaky·and·needs·separate·fix
           ·····*/
          -·····@AwaitsFix(bugUrl·=·"https://github.com/opensearch-project/OpenSearch/issues/5669")
          +····@AwaitsFix(bugUrl·=·"https://github.com/opensearch-project/OpenSearch/issues/5669")
           ····public·void·testAddNewReplicaFailure()·throws·Exception·{
           ········logger.info("-->·starting·[Primary·Node]·...");
           ········final·String·primaryNode·=·internalCluster().startNode();
  Run './gradlew :server:spotlessApply' to fix these violations.

  1 org.opensearch.indices.replication.SegmentReplicationIT.testAddNewReplicaFailure

This flaky failure was because I pushed an unintentional commit to unMute this test.  This test is not fixed as part of this PR and remains muted in further commits.

Backporting this to 2.x, without this all changes on tests will cause conflict on backports. Found this during backport of #5898 https://github.com/opensearch-project/OpenSearch/pull/5898#issuecomment-1407151854


UUID is no longer supportet

UUID types can't be serialized in Oracle via Querydsl SQL, since the JDBC String mapping doesn't work here. I see it was fixed in version 3.4.3 and now it's out again?

Do you have an example domain and query that we can use to reproduce this issue?
I don't think its intentionally not supported. I am not sure even if this is actually a QueryDSL issue or a JDBC/ ORM issue instead.

We have uuid tests that run against oracle 11 so I'm going to close this. @michelu89 feel free to respond with more info and we'll take a look.