Thread exited event ignored

Even though clearly an thread event with reason: "exited" is sent, VS Code does not update the UI to remove the exited thread:

last communication:
-> continueRequest
{ type: 'request',
  seq: 21,
  command: 'continue',
  arguments: { threadId: 2 } }

<- continueResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 21,
  command: 'continue',
  success: true }

<- threadEvent
ThreadEvent {
  seq: 0,
  type: 'event',
  event: 'thread',
  body: { reason: 'exited', threadId: 2 } }

When a stack frame inside the dead thread is clicked VS Code tries to request the variables inside a thread that doesn't exist anymore.
Even weirder, the threads even keep showing even after the debug session ended:

@felixfbecker I can not repro this issue on my side. Are you sure you are giving unique threadIds to your threads? What happens if you only use one thread, does it work nicely? What happens if send an exited event for the first thread?

Does the tread id need to be unique at any given moment or for the whole lifetime of the process?
In other words, if a thread id=3 exits, and then a new thread is started, can the new thread's id be 3?

@isidorn I'm pretty sure I'm giving 100% unique thread IDs, I just increment a counter for each new thread. I will look into it again.

@isidorn here are the full logs of a debug session where I trigger 2 threads and then continue one of them until it exits (btw, this is hard to get because you cannot do Ctrl+A in the debug console):
https://gist.github.com/felixfbecker/378a13c6306a4ed145cc

In line 111 I notify Code with Thread 1.
In line 201 I notify Code with Thread 2 (in the following ThreadResponse you can clearly see they have unique IDs)
In line 425 I notify Code that Thread 1 has exited. And directly after that, VS Code requests a stack frame for the thread that doesn't even exist anymore.

and of course, UI doesn't update at all besides the empty stack trace that I sent it.

@vadimcn thread id needs to be unque at any given moment, not the whole lifetime
@felixfbecker thanks for more details, I will look into it

I could not reproduce this anymore.

Actually, it's still there. Just tried it again with a super simple setup, newest version of everything.

Ok, here another demo:

As you can see, I have two threads running, and I continue one so it ends. The adapter is correctly sending a ThreadEvent with exited, but VS Code UI does not update, in fact, it still displays the old stack trace, it is impossible to control the second thread anymore (it shows pause instead of run icon) and even after stopping the stack trace is still displayed. When I click scopes in the variables section Code still tries to request variables for the exited thread.
Here the last piece of log:
-> continueRequest
{ type: 'request',
  seq: 23,
  command: 'continue',
  arguments: { threadId: 1 } }
<- continueResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 23,
  command: 'continue',
  success: true }
<- threadEvent
ThreadEvent {
  seq: 0,
  type: 'event',
  event: 'thread',
  body: { reason: 'exited', threadId: 1 } }

The IDs are correct, see this snippet:
<- threadsResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 11,
  command: 'threads',
  success: true,
  body:
   { threads:
      [ Thread { id: 1, name: 'Request 1 (5:37:28 PM)' },
        Thread { id: 2, name: 'Request 2 (5:37:50 PM)' } ] } }

We will change how we handle threads mostly due to https://github.com/Microsoft/vscode/pull/3990
So putting this back on backlog, as I would like to first fix our thread handling and then look into this

That's unfortunate. PHP debugging involves multiple requests in most of the cases, I get bug report after bug report and cannot do anything about it because the Thread system in VS Code seems somehow broken itself :/

If we get a PR in time for March this issue should be addressed. If we do not get a PR in I can investigate into this explicit issue next week.

I read through https://github.com/Microsoft/vscode/issues/3650 but I don't understand how it is related to this issue?

It is not directly related but that issue will probably require a restructuring of how we handle threads in the vscode model. And that is very related to this issue.

@felixfbecker threads have underwent a refactoring, do you stil see this issue with the latest insiders build?

@isidorn It actually became worse. I am testing with 0.10.12-insider and latest 1.5.1 of my extension (same as last demo).

once the new thread comes in, the stack trace for the first disappears
running one thread to the end makes all stack traces disappear as if all threads ended

I did the work to get the log again for you:
<- launchResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 2,
  command: 'launch',
  success: true }
new connection 1
<- threadEvent
ThreadEvent {
  seq: 0,
  type: 'event',
  event: 'thread',
  body: { reason: 'started', threadId: 1 } }
-> threadsRequest
{ type: 'request', seq: 3, command: 'threads' }
<- threadsResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 3,
  command: 'threads',
  success: true,
  body: { threads: [ Thread { id: 1, name: 'Request 1 (1:23:19 PM)' } ] } }
<- initializedEvent
InitializedEvent { seq: 0, type: 'event', event: 'initialized' }
-> setBreakpointsRequest
{ type: 'request',
  seq: 4,
  command: 'setBreakpoints',
  arguments:
   { source: { path: 'c:\\Users\\felix\\git\\opensource\\vscode-php-debug\\testproject\\variables.php' },
     lines: [ 10 ],
     breakpoints: [ { line: 10 } ] } }
-> setBreakpointsRequest
{ type: 'request',
  seq: 5,
  command: 'setBreakpoints',
  arguments:
   { source: { path: 'c:\\Users\\felix\\git\\opensource\\vscode-php-debug\\testproject\\hello_world.php' },
     lines: [ 4 ],
     breakpoints: [ { line: 4 } ] } }
<- setBreakpointsResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 4,
  command: 'setBreakpoints',
  success: true,
  body: { breakpoints: [ { verified: true, line: 10, id: 51480001 } ] } }
<- setBreakpointsResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 5,
  command: 'setBreakpoints',
  success: true,
  body: { breakpoints: [ { verified: true, line: 4, id: 51480002 } ] } }
-> setFunctionBreakpointsRequest
{ type: 'request',
  seq: 6,
  command: 'setFunctionBreakpoints',
  arguments: { breakpoints: [] } }
<- setFunctionBreakpointsResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 6,
  command: 'setFunctionBreakpoints',
  success: true,
  body: { breakpoints: [] } }
-> setExceptionBreakpointsRequest
{ type: 'request',
  seq: 7,
  command: 'setExceptionBreakpoints',
  arguments: { filters: [] } }
<- setExceptionBreakpointsResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 7,
  command: 'setExceptionBreakpoints',
  success: true }
-> configurationDoneRequest
{ type: 'request', seq: 8, command: 'configurationDone' }
<- configurationDoneResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 8,
  command: 'configurationDone',
  success: true }
<- stoppedEvent
StoppedEvent {
  seq: 0,
  type: 'event',
  event: 'stopped',
  body: { reason: 'breakpoint', threadId: 1 } }
-> stackTraceRequest
{ type: 'request',
  seq: 9,
  command: 'stackTrace',
  arguments: { threadId: 1, levels: 20 } }
<- stackTraceResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 9,
  command: 'stackTrace',
  success: true,
  body:
   { stackFrames:
      [ StackFrame {
          id: 1,
          source:
           Source {
             name: 'variables.php',
             path: 'C:\\Users\\felix\\git\\opensource\\vscode-php-debug\\testproject\\variables.php',
             sourceReference: 0 },
          line: 10,
          column: 1,
          name: '{main}' } ] } }
-> scopesRequest
{ type: 'request',
  seq: 10,
  command: 'scopes',
  arguments: { frameId: 1 } }
<- scopesResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 10,
  command: 'scopes',
  success: true,
  body:
   { scopes:
      [ Scope { name: 'Locals', variablesReference: 1, expensive: false },
        Scope { name: 'Superglobals', variablesReference: 2, expensive: false },
        Scope {
          name: 'User defined constants',
          variablesReference: 3,
          expensive: false } ] } }
-> variablesRequest
{ type: 'request',
  seq: 11,
  command: 'variables',
  arguments: { variablesReference: 1 } }
<- variablesResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 11,
  command: 'variables',
  success: true,
  body:
   { variables:
      [ Variable {
          name: '$aBoolean',
          value: 'uninitialized',
          variablesReference: 0 },
        Variable { name: '$aFloat', value: '1.23', variablesReference: 0 },
        Variable {
          name: '$aLargeArray',
          value: 'uninitialized',
          variablesReference: 0 },
        Variable { name: '$aString', value: '"123"', variablesReference: 0 },
        Variable { name: '$anArray', value: 'array(2)', variablesReference: 4 },
        Variable { name: '$anEmptyString', value: '""', variablesReference: 0 },
        Variable { name: '$anInt', value: '123', variablesReference: 0 },
        Variable {
          name: '$nullValue',
          value: 'uninitialized',
          variablesReference: 0 },
        Variable {
          name: '$variableThatsNotSet',
          value: 'uninitialized',
          variablesReference: 0 } ] } }
-> variablesRequest
{ type: 'request',
  seq: 12,
  command: 'variables',
  arguments: { variablesReference: 2 } }
-> variablesRequest
{ type: 'request',
  seq: 13,
  command: 'variables',
  arguments: { variablesReference: 3 } }
<- variablesResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 12,
  command: 'variables',
  success: true,
  body:
   { variables:
      [ Variable { name: '$_COOKIE', value: 'array(0)', variablesReference: 5 },
        Variable { name: '$_ENV', value: 'array(0)', variablesReference: 6 },
        Variable { name: '$_FILES', value: 'array(0)', variablesReference: 7 },
        Variable { name: '$_GET', value: 'array(0)', variablesReference: 8 },
        Variable { name: '$_POST', value: 'array(0)', variablesReference: 9 },
        Variable { name: '$_REQUEST', value: 'array(0)', variablesReference: 10 },
        Variable { name: '$_SERVER', value: 'array(61)', variablesReference: 11 } ] } }
<- variablesResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 13,
  command: 'variables',
  success: true,
  body: { variables: [ Variable { name: 'TEST_CONSTANT', value: '123', variablesReference: 0 } ] } }
new connection 2
<- threadEvent
ThreadEvent {
  seq: 0,
  type: 'event',
  event: 'thread',
  body: { reason: 'started', threadId: 2 } }
-> threadsRequest
{ type: 'request', seq: 14, command: 'threads' }
<- threadsResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 14,
  command: 'threads',
  success: true,
  body:
   { threads:
      [ Thread { id: 1, name: 'Request 1 (1:23:19 PM)' },
        Thread { id: 2, name: 'Request 2 (1:23:27 PM)' } ] } }
<- initializedEvent
InitializedEvent { seq: 0, type: 'event', event: 'initialized' }
-> setBreakpointsRequest
{ type: 'request',
  seq: 15,
  command: 'setBreakpoints',
  arguments:
   { source: { path: 'c:\\Users\\felix\\git\\opensource\\vscode-php-debug\\testproject\\variables.php' },
     lines: [ 10 ],
     breakpoints: [ { line: 10 } ] } }
-> setBreakpointsRequest
{ type: 'request',
  seq: 16,
  command: 'setBreakpoints',
  arguments:
   { source: { path: 'c:\\Users\\felix\\git\\opensource\\vscode-php-debug\\testproject\\hello_world.php' },
     lines: [ 4 ],
     breakpoints: [ { line: 4 } ] } }
<- setBreakpointsResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 15,
  command: 'setBreakpoints',
  success: true,
  body: { breakpoints: [ { verified: true, line: 10, id: 51480003 } ] } }
<- setBreakpointsResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 16,
  command: 'setBreakpoints',
  success: true,
  body: { breakpoints: [ { verified: true, line: 4, id: 51480004 } ] } }
-> setFunctionBreakpointsRequest
{ type: 'request',
  seq: 17,
  command: 'setFunctionBreakpoints',
  arguments: { breakpoints: [] } }
<- setFunctionBreakpointsResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 17,
  command: 'setFunctionBreakpoints',
  success: true,
  body: { breakpoints: [] } }
-> setExceptionBreakpointsRequest
{ type: 'request',
  seq: 18,
  command: 'setExceptionBreakpoints',
  arguments: { filters: [] } }
<- setExceptionBreakpointsResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 18,
  command: 'setExceptionBreakpoints',
  success: true }
-> configurationDoneRequest
{ type: 'request', seq: 19, command: 'configurationDone' }
<- configurationDoneResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 19,
  command: 'configurationDone',
  success: true }
<- stoppedEvent
StoppedEvent {
  seq: 0,
  type: 'event',
  event: 'stopped',
  body: { reason: 'breakpoint', threadId: 2 } }
-> stackTraceRequest
{ type: 'request',
  seq: 20,
  command: 'stackTrace',
  arguments: { threadId: 2, levels: 20 } }
<- stackTraceResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 20,
  command: 'stackTrace',
 success: true,
  body:
   { stackFrames:
      [ StackFrame {
          id: 2,
          source:
           Source {
             name: 'hello_world.php',
             path: 'C:\\Users\\felix\\git\\opensource\\vscode-php-debug\\testproject\\hello_world.php',
             sourceReference: 0 },
          line: 4,
          column: 1,
          name: '{main}' } ] } }
-> scopesRequest
{ type: 'request',
  seq: 21,
  command: 'scopes',
  arguments: { frameId: 2 } }
<- scopesResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 21,
  command: 'scopes',
  success: true,
  body:
   { scopes:
      [ Scope { name: 'Locals', variablesReference: 12, expensive: false },
        Scope {
          name: 'Superglobals',
          variablesReference: 13,
          expensive: false },
        Scope {
          name: 'User defined constants',
          variablesReference: 14,
          expensive: false } ] } }
-> variablesRequest
{ type: 'request',
  seq: 22,
  command: 'variables',
  arguments: { variablesReference: 12 } }
<- variablesResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 22,
  command: 'variables',
  success: true,
  body: { variables: [] } }
-> variablesRequest
{ type: 'request',
  seq: 23,
  command: 'variables',
  arguments: { variablesReference: 13 } }
<- variablesResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 23,
  command: 'variables',
  success: true,
  body:
   { variables:
      [ Variable { name: '$_COOKIE', value: 'array(0)', variablesReference: 15 },
        Variable { name: '$_ENV', value: 'array(0)', variablesReference: 16 },
        Variable { name: '$_FILES', value: 'array(0)', variablesReference: 17 },
        Variable { name: '$_GET', value: 'array(0)', variablesReference: 18 },
        Variable { name: '$_POST', value: 'array(0)', variablesReference: 19 },
        Variable { name: '$_REQUEST', value: 'array(0)', variablesReference: 20 },
        Variable { name: '$_SERVER', value: 'array(61)', variablesReference: 21 } ] } }
-> variablesRequest
{ type: 'request',
  seq: 24,
  command: 'variables',
  arguments: { variablesReference: 21 } }
<- variablesResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 24,
  command: 'variables',
  success: true,
  body:
   { variables:
      [ I omit these here because they are not important ] } }
-> continueRequest
{ type: 'request',
  seq: 25,
  command: 'continue',
  arguments: { threadId: 2 } }
<- continueResponse
Response {
  seq: 0,
  type: 'response',
  request_seq: 25,
  command: 'continue',
  success: true }
<- threadEvent
ThreadEvent {
  seq: 0,
  type: 'event',
  event: 'thread',
  body: { reason: 'exited', threadId: 2 } }

@felixfbecker first of all, sorry for the slow response, this somehow went under my radar.
Can you please try to reproduce this issue with the latest alpha vscode available here that includes some of the potential fixes for this issue.
If you still see it, please attach a small php sample for which I can repro this. I will then switch to a windows machine and setup the php debugger to investigate further.
Thanks

@isidorn Tried the alpha release, but the problem described above still exists (stack disappears, exit ignored). When I try to continue the already-exited thread, my debug adapter sends an error response with "Unknown Thread ID". I also noticed another issue in the alpha build that is not in stable or insiders, the TerminatedEvent is ignored too.
Any PHP file will do for reproducing, like https://github.com/felixfbecker/vscode-php-debug/blob/master/testproject/hello_world.php. Just set a breakpoint, select "Listen for XDebug" and start the same script twice from the command line, like in the demo GIF. I can assist you in setting up XDebug if you need help.

I could setup xcode using instructions for your extension - thanks!
Regarding the terminated event ignored, that is a dup of #5598 which is fixed now.
There have been multiple issues which have made the thread experience bad. These issues have been covered by the following commits:
66dcd04
e987744
05d8d9e
b1b0dd5
619f10e
Previosuly on Continue vscode would continue all the threads. This is now changed that only the current debugged thread is continued.
Some behavior has been changed with the allThreadsStopped, because I believe there was an issue.
@edumunoz please check commit 66dcd04 and please try the cpp thread scenarios with latest version of vscode
@felixfbecker I have checked PHP after all these fixes and it looks good to me, please check it on the alpha version of vscode (which should update in 10minutes) and let me know if you see more issues. Thanks for reporting this and sorry once again for the slow response.

FYI @edumunoz also created #5643

FYI also created test plan item #5644, so let me know if you think of some scenarios that should be tested

@isidorn Tested, everything works as it should! Great work

Tested cpptools on master, looks good.  One possible regression from 0.10.13-insider, filed #5784.


:children_crossing: :recycle: enable apply and prepare of module task to return and receive json Values

The apply function expects a string right now.
It could be desirable that it can receive json-values or other values to reduce complexity.

This is already possible. See the trait GenericTask in src/prelude/tasks/task.rs.
The current tasks implement GenericTask<String> but nothing prevents you from implementing GenericTask<serde_json::Value>.
I'm closing this issue :)


Adding Heroku Deploy To Release Workflow

Adding the Heroku-Deploy GitHub action to the release workflow. This will deploy to Heroku if the release is successfully created. Otherwise it won't deploy at all. This is a little better than the Heroku Github integration because I can deploy only when I release, instead of on every push to main. Also, the above integration is broken for me for some reason. PR changes include:

adding heroku-deploy action to release.yaml

Fixes #55

:tada: This PR is included in version 1.1.6 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


docs: fix grammar in numbers-in-csharp

Summary
The sentence "Double precision number have twice the number of binary digits as single-precision" seems to be missing an "s" in the word "numbers".
It could also be rephrased as "A double precision number has twice the number of binary digits as single-precision".
I also noticed that "double-precision" and "double precision" are used interchangeably within the same paragraph, the same for "single-precision" and "single precision". Perhaps one should be enforced, but no change is introduced regarding this.
Thank you for a great tutorial :)

closing and reopening for a fresh build


Token exposed

Token

Sorry for the mistake.
But anyway, this was just a practice on building telegram bots for me, and I don't care if it's not secure. You (or anybody else) can grab the ownership of the bot :D


[SPARK-35529][SQL] Add fallback metrics for hash aggregate

What changes were proposed in this pull request?

Add the metrics to record how many tasks fallback to sort-based aggregation for hash aggregation. This will help developers and users to debug and optimize query. Object hash aggregation has similar metrics already.
Why are the changes needed?

Help developers and users to debug and optimize query with hash aggregation.
Does this PR introduce any user-facing change?

Yes, the added metrics will show up in Spark web UI.
Example:

How was this patch tested?

Changed unit test in SQLMetricsSuite.scala.

Test build #138972 has started for PR 32671 at commit 638cbf5.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43492/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43492/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/43492/

thanks, merging to master!

Test build #138976 has finished for PR 32671 at commit 0456d2d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test build #138972 has finished for PR 32671 at commit 638cbf5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138972/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/138976/

Thank you @cloud-fan for review!


feat: Updated yarn version from 1.x to 3.x.

Followes steps defined in issue #40

Oops, sorry!

I also wanted to comment about the commit messages.

feat: Updated yarn version from 1.x to 3.x.
docs: Updated yarn installation link in README.

Please prefer present-tense, imperative-style commit messages, like below. Also, we usually don't capitalize the first word in the commit message. But that's totally up to you.

feat: Update yarn version from 1.x to 3.x.
docs: Update yarn installation link in README.

Also, you don't need to add labels or milestones to PRs, or add them to the Rollups Unit project. PRs are tracked by the issues they are linked to. :-)
You just need to set reviewer(s), assignee(s), and link the PR to the corresponding issue.

Rebased on top of main

After rebasing on top of main, CartesiDapp.t.sol was not updated from main into this branch. Weird that there was no warning also from Github for merging into main, only CI noticed.
Manually copied from main to this branch, now all tests pass.
We'll leave plug&play from yarn for another issue, so we can introduce yarn v3 with no problems and fully compatible with existing dependencies in node_modules folder.

After rebasing on top of main, CartesiDapp.t.sol was not updated from main into this branch. Weird that there was no warning also from Github for merging into main, only CI noticed. Manually copied from main to this branch, now all tests pass.

Here's the routine I use to rebase branches.
git fetch --prune
git checkout <feature-branch>
git rebase -i origin/<base-branch>

We'll leave plug&play from yarn for another issue, so we can introduce yarn v3 with no problems and fully compatible with existing dependencies in node_modules folder.

I'm afraid this is a blocker. We should first make sure everything works smoothly before committing to this migration.

After rebasing on top of main, CartesiDapp.t.sol was not updated from main into this branch. Weird that there was no warning also from Github for merging into main, only CI noticed. Manually copied from main to this branch, now all tests pass.

Here's the routine I use to rebase branches.
git fetch --prune
git checkout <feature-branch>
git rebase -i origin/<base-branch>

I did this exact procedure but it was not detecting the file, idk why. Is it ok anyway, right?

We'll leave plug&play from yarn for another issue, so we can introduce yarn v3 with no problems and fully compatible with existing dependencies in node_modules folder.

I'm afraid this is a blocker. We should first make sure everything works smoothly, otherwise we'll be committing into a half-baked solution.

True! I just left this PR to update the yarn version and everything works perfectly. I left my remaining progress with PnP at #92 .

I did this exact procedure but it was not detecting the file, idk why. Is it ok anyway, right?

If you're able to reproduce this again, we can schedule a meeting so we can investigate this further.

True! I just left this PR to update the yarn version and everything works perfectly. I left my remaining progress with PnP at https://github.com/cartesi/rollups-contracts/issues/92 .

Nice. Hey, maybe we can search for web3 projects that use Yarn modern and see how they're resolving Solidity dependencies. :-)

Seems like the prepack script is still supported by yarn modern.
https://yarnpkg.com/advanced/lifecycle-scripts#prepack-and-postpack

Hey, @xdaniortega.
I've run the commands from the step-by-step guide and ended up with different files.
Please make sure you are running all of them in order, and committing all the files created.

Hey, @xdaniortega.
I've run the commands from the step-by-step guide and ended up with different files.
Please make sure you are running all of them in order, and committing all the files created.

Hi! Interesting, what files are you getting different? Maybe just  onchain/rollups/lib/openzeppelin-contracts (new) |     1 +? Be sure you're setting nodeLinker: node-modules at yarn.yaml.

Rebased on top of main

This PR is ready for final review.


Fixes issue #10

@ladanazita would it be possible to please merge this and create a beta4 tag?

@ladanazita no reason in particular why 1.5
If you feel like including 1.0 is good enough for your needs, I can make the simple change.

My gut is to actually do the work to bump up to the latest (2.0). This does require a bit more work (since there are API changes).
For now, can you simply include the version you desire to use of Optimizely X in your podfile? Cocoapods will respect the version you pin over the dependency in Segment-Optimizely-X ( so long as it is > than what segment-optimizely-x pulls in)
Something like:
pod 'OptimizelySDKiOS', '~> 1.5'
pod 'Segment-Optimizely-X'

Any update on this?

@ladanazita,
couple of follow up questions from the optimziely team:

Can you confirm that the suggested workaround will allow our joint clients to use Optimizely iOS SDK v2+? The PR thread seems to indicate that this approach only works for versions up to but not including 2.
If so can you confirm that Segment has validated this approach on our v2 iOS SDK and would support this as a formal workaround?


Try chatgpt image

Try generating some funny image we could put on the site / to the README

Attaching two possible versions of the logo


Fix crop sizes and add properly sized placeholders

Fix #868

This fails because the test is wrong.

Codecov Report

Merging #870 into master will increase coverage by 0.23%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
+ Coverage   60.32%   60.55%   +0.23%
==========================================
  Files         115      110       -5
  Lines        6036     6013      -23
  Branches      741      741
==========================================
  Hits         3641     3641
+ Misses       2257     2233      -24
- Partials      138      139       +1

Impacted Files
Coverage Δ

saleor/graphql/api.py
84.48% <100%> (+0.08%)
:white_check_mark:

saleor/settings.py
86.95% <100%> (+0.23%)
:white_check_mark:

saleor/product/templatetags/product_images.py
93.75% <100%> (+8.03%)
:white_check_mark:

saleor/dashboard/templatetags/utils.py
55.55% <0%> (-3.54%)
:x:

saleor/core/utils/random_data.py
83.59% <0%> (-0.69%)
:x:

saleor/cart/views.py
88.73% <0%> (-0.31%)
:x:

saleor/dashboard/order/forms.py
50% <0%> (-0.28%)
:x:

saleor/dashboard/urls.py
100% <0%> (ø)
:white_check_mark:

saleor/dashboard/payments/urls.py

saleor/dashboard/payments/views.py

... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c4bcc...ff22df5. Read the comment docs.


Add "layers" data sheet for the xlsx output

The current SCIO's xlsx output generate 4 worksheets:

PACKAGES
DEPENDENCIES
RESOURCES
ERRORS

From a user's prespective, it'll be great if it can also generate a "LAYERS" worksheet that log the docker command for each layer.
This information is listed in the JSON's output under the created_by key:
"extra_data": {
   ...
   "layers": [
      {
         "os": null
          ...
         "created_by": <docker command>
          ...
       }
   ]
}

The desire output would be something like

Seq
layer_tag
Docker command
layer_id

1
img-abababa-layer-01-xyxyxyx
/bin/sh -c #(nop) ADD file: xxxxxxxxxx in /
xyxyxyxyxyxyxyyxyxyxyxyxyxyx

2
img-abababa-layer-02-cdcdcd
/bin/sh -c #(nop) COPY dir: yyyyyyyyyyy in /
cdcdcdcdcdcdcdcdcdccdcdc

+1

@chinyeungli the LAYERS sheet is now available in the .xlsx when the data is available on the project.
The following fields are included:

layer_tag
created_by
layer_id
image_id
created
size
author
comment


⚠ Bofrost.de has degraded performance

In 9794280, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1313 ms

Resolved: Bofrost.de performance has improved in ca44401.


WIP: Add EventSource type

This is totally work in progress but I wanted to get feedback if this is even right place and/or way to do such things.
I saw that the EventSource type was missing in fable and since or frontend uses server sent events I wanted to make it work with fable.
Is the powerpack the right place or should this go into the Import JS part of fables main repo?

Hi @coolya! It seems EventSource is a browser API. In that case, it should probably go in the Browser bindings. At the moment, they are in Fable.Core so you can send a PR there :smile: But we're planning to move them to an independent package (also the Node bindings).
Fable.PowerPack is intended for fable-specific helpers. (Similar to the helpers in Fable.Core, but the latter have dependencies on a specific compiler version.)

closing this one and sending a new one against the new import project.


The smoke test for extension install/activation is flaky

The install and activate vscode-smoketest-check extension is flaky.

Closed in #56271


Make more mobile friendly

Anyone wanting to modify the CSS for mobile devices and tablets feel free to do a pull request if not solved soon will resolve issue myself.

Partially Fixed in Commit 04c6d61e, in coming commits Liquid-dl will use React MediaQueries on the front-end.

Assign me this.... I will fix it


Eflow deploy failed while verifying host binaries

Need help to complete the offline setup of EFLOW.
We have an on-premise firewall-guarded Windows Server 2019 VM (running on top of VM Ware ESXi). We followed the necessary documentation to enable nested virtualization and 'Default Switch' configuration.
Now our EFLOW deployment is failing in binary verification. Please note that this is an offline VM without any connectivity to the internet.
The image below captures the exact error we are facing.

Kindly guide steps we need to take to resolve this issue and to ensure the offline setup is completed successfully.

Hi @mihir-shah-bh,
Thanks for reaching out. Probably you don't have the required certificates, and hence the installation will fail. Please, review #79 or AKS-EE Windows offline certs.
Thanks,
Francisco

@fcabrera23 thanks for the prompt response.
The steps, to install certificates offline, mentioned in AKS-EE Windows offline certs solved our problem.
Appreciate your help.
Cheers!
Mihir


Correct Serialization of google::protobuf::*Value Types

From https://developers.google.com/protocol-buffers/docs/proto3#json

Wrappers use the same representation in JSON as the wrapped primitive type, except that null is allowed and preserved during data conversion and transfer.

Currently the wrapper types are not special cased and are therefore not serialized/deserialized to/from this custom representation. This should be fixed

which seems to conflict with the JSON mapping docs.

Where is the conflict? The JSON mapping I think consistently renders 64-bit integral types as strings? This is because javascript stores all numbers as 64-bit floating point - which only have 52-bit integral precision

How's it going? I'm looking forward to this feature.

I don't really have time to work on this at the moment, but if you or anyone else were willing to submit PRs, I would happily review them

#63 I have submit a PR.
But BytesValue can't work


IPTT tables: Sort columns

ACCEPTANCE CRITERIA
I can sort on any column in the IPTT report, toggling between top-to-bottom or bottom-to-top.

Column headers look sortable.
It's easy to click whatever UI element we use to initiate sorting. (Generous click surface.)
It's visually obvious, by which column the table is sorted, and ideally whether it's sorted "up" or "down".

Should not be something we do to the existing table. Makes more sense to tackle it as part of a broader redesign of the table, post Goat Tree.


Added info about permissions to README

Closes #80 . The README now includes info on how to find the environment's python path and how to change permissions to execute if they are denied after a user creates a new conda environment.

@Ruprabhu25  Can you delete this branch?


Fix when using Cordova, which uses file:// to load resources

Because the success status of an XHR request can be 0 when loading local files, loading never finished when using pixi in a cordova app.  I’ve updated the logic, which checks the status and also the length of the response is checked, to make sure a valid response was found.

Nice catch, will hotfix tonight.

Hey can you tell me what's the status on this? Is it going to make it into the loader and PIXI? Thanks :+1:

I had forgotten about this! Sorry about that.

Released as 1.5.3.
Will make it into the next pixi release as well.


Use a framework/guideline for technical documentation.

The guideline and approach for organizing and to cover in the documentation:
https://diataxis.fr/

@fourthletter We have discussed this guideline for documentation before. I think everyone agrees it is really good.
Can we make an official decision that this is how we organise our documentation?


torchEnabledNotifier missing

in the latest version, I can't find torchEnabledNotifier which I used to update the button in my GUI, any recommendations on how to see if the torch is on or off?
Version: 5.1.1
This is how I did it:
IconButton(
        iconSize: 32.0,
        color: Colors.white,
        icon: ValueListenableBuilder(
           valueListenable: controller.torchEnabledNotifier,
           builder: (context, state, child) {
             switch (state as TorchState) {
               case TorchState.off:
                 return const Icon(Icons.flash_on, color: Colors.white);
               case TorchState.on:
                 return const Icon(Icons.flash_off, color: Colors.yellow);
             }
           },
        ),
        onPressed: () async {
          await controller.toggleTorch();
        },
      );

Did find my answer: controller.value.torchState  tells me the state of the touch and by adding a listener I can detect changes.

Yes, the new API uses a ValueNotifier which exposes a value. This value is an instance of MobileScannerState, which has the properties that you need.


docs: added program args and agreement retirement section to 0.8.0 migration guide

WHAT
Adds two sections to the 0.7.X -> 0.8.0 migration guide:

About the possibility to use program args with the docker images
About the agreement retirement featured

WHY
Improving the migration guide

@gerbigf @bmg13 fyi


[ToDo] Set up CI building for the repo

Set up CI build checks yarn ci to run for new PRs (or merges to master)
CircleCI or Github Actions?

I am personally familiar with CircleCI and can set it up quickly if you want (and give me admin).

I am personally familiar with CircleCI and can set it up quickly if you want (and give me admin).

@bd82 That would be so helpful, thanks! I looked at it and then abandoned all hope lol. I actually think I set up one that doesn't work.
I just tested yarn ci and it looks like everything is passing?

@bd82 That would be so helpful, thanks! I looked at it and then abandoned all hope lol. I actually think I set up one that doesn't work.
I just tested yarn ci and it looks like everything is passing?

@bd82 I've added permissions for you.

@bd82 I've added permissions for you.

I'll have a look at this (probably on the weekend)

@bd82 Thanks so much!

I did not forget about this, 😞  will try heard to reach this this weekend.

@bd82 No worries! We all have busy lives!


Remove duplicate matrix in CD action

https://github.com/actions/runner/issues/1182

https://github.com/orgs/community/discussions/4501


[V2/V3] [Feat] Update lit modal to support wallet connect

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: sarahzdev:x: AnsonhkgYou have signed the CLA already but the status is still pending? Let us recheck it.


get author information (email address) in BillTestimonies (currently Firebase ID)

ExpandTestimony.js

the first step is PR 259
when this is merged, then the author's display name should be available to be changed in BillTestimonies and ExpandTestimony


check the prototype as well as the constructor to verify if a JsObject is a plain old Object

Should fix https://github.com/dart-lang/polymer-dart/issues/596

lgtm


panics if run in package main

gqlgen really doesn't seem to like package main, but even more mystifying is how it comes up with the package name "example". And obviously command-line utilities shouldn't panic on bad input.
tv@dark ~/z$ tree
.
└── src
    └── example.com
        └── foo-bar
            ├── main.go
            ├── schema.graphql
            └── types.json

3 directories, 3 files
tv@dark ~/z$ cd src/example.com/foo-bar/
tv@dark ~/z/src/example.com/foo-bar$ GOPATH="$HOME/z:$(go env GOPATH)" go generate
panic: cannot find package "example" in any of:
	/home/tv/src/go-1.10/src/example (from $GOROOT)
	/home/tv/z/src/example (from $GOPATH)
	/home/tv/go/src/example

goroutine 1 [running]:
github.com/vektah/gqlgen/codegen.(*Imports).add(0xc427326540, 0xc420138be0, 0x7, 0xc4273c73e0)
	/home/tv/go/src/github.com/vektah/gqlgen/codegen/import_build.go:61 +0x2a3
github.com/vektah/gqlgen/codegen.buildImports(0xc420070e10, 0xc42013e2d0, 0x22, 0xc420062e80)
	/home/tv/go/src/github.com/vektah/gqlgen/codegen/import_build.go:40 +0x194
github.com/vektah/gqlgen/codegen.(*Config).models(0xc4201f1dc8, 0x30, 0x732840, 0x897228)
	/home/tv/go/src/github.com/vektah/gqlgen/codegen/build.go:40 +0xab
github.com/vektah/gqlgen/codegen.Generate(0xc42013e270, 0x24, 0xc420070cc0, 0xc4200ab420, 0xc42013e330, 0x2f, 0xc4201137b8, 0x4, 0xc420138c2f, 0x10, ...)
	/home/tv/go/src/github.com/vektah/gqlgen/codegen/codegen.go:45 +0xa0
main.main()
	/home/tv/go/src/github.com/vektah/gqlgen/main.go:42 +0x1e7
main.go:3: running "gqlgen": exit status 2
[EXIT:1] tv@dark ~/z/src/example.com/foo-bar$ head -99 *
==> main.go <==
package main

//go:generate gqlgen -package main -modelpackage main -typemap types.json -schema schema.graphql

func main() {
}

==> schema.graphql <==
type Greeting {
  Message: String
}

==> types.json <==
{
  "Greeting": "example.com/foo-bar"
}
tv@dark ~/z/src/example.com/foo-bar$

Ah yes, that caused that confusion. I'm still seeing some funky stuff, I'll either provide more detail here or close the bug soon. Thanks.

Okay, my remaining confusion is completely about the two generated files, and the directories they go into. Why are there two files, and why is having a "models" package mandatory? If I try to deviate from what's on the website even a little bit, it seems the models file just doesn't ever get written.

Nothing gets written because
	if len(modelsBuild.Models) > 0 || len(modelsBuild.Enums) > 0 {

is false.

Ahhh models.gen.go only gets written for things that are inputs to mutations, it seems. Adding a mutation. That gets me forward. Okay, here's the thing I originally started chasing down: gqlgen rewrites dashes as underscores.
tv@dark ~/z/src/example.com/foo-bar$ ls -a
.gqlgen.yml  main.go  schema.graphql
tv@dark ~/z/src/example.com/foo-bar$ head -99 .gqlgen.yml main.go schema.graphql
==> .gqlgen.yml <==
schema: schema.graphql
exec:
  package: main
model:
  package: example.com/foo-bar
models:
  Greeting:
    model: example.com/foo-bar.Greeting

==> main.go <==
package main

//go:generate gqlgen -package main -modelpackage graph -schema schema.graphql

type Greeting struct {
}

func main() {
}

==> schema.graphql <==
type Greeting {
  Message: String!
}

type Query {
  greeting: [Greeting!]!
}

input Hi {
  text: String!
}

type Mutation {
  sayHi(input: Hi!): Greeting!
}
tv@dark ~/z/src/example.com/foo-bar$ GOPATH="$HOME/z:$(go env GOPATH)" ~/go/bin/gqlgen
panic: cannot find package "example.com/foo_bar" in any of:
	/home/tv/src/go-1.10/src/example.com/foo_bar (from $GOROOT)
	/home/tv/z/src/example.com/foo_bar (from $GOPATH)
	/home/tv/go/src/example.com/foo_bar

goroutine 1 [running]:
github.com/vektah/gqlgen/codegen.(*Imports).add(0xc420c41bc0, 0xc42429a860, 0x13, 0xc421300ed0)
	/home/tv/go/src/github.com/vektah/gqlgen/codegen/import_build.go:61 +0x2a3
github.com/vektah/gqlgen/codegen.buildImports(0xc427601b00, 0xc42013e330, 0x22, 0xc4275fb880)
	/home/tv/go/src/github.com/vektah/gqlgen/codegen/import_build.go:40 +0x194
github.com/vektah/gqlgen/codegen.(*Config).bind(0xc4201fbe18, 0xc42006f080, 0xc4201119b6, 0x2)
	/home/tv/go/src/github.com/vektah/gqlgen/codegen/build.go:66 +0xb6
github.com/vektah/gqlgen/codegen.Generate(0xc420111810, 0xe, 0xc420105680, 0x9e, 0xc42013e330, 0x2f, 0xc420111970, 0x4, 0xc42013e2d0, 0x30, ...)
	/home/tv/go/src/github.com/vektah/gqlgen/codegen/codegen.go:61 +0x5f1
main.main()
	/home/tv/go/src/github.com/vektah/gqlgen/main.go:81 +0x23d

@tv42 thanks for the report.  It looks like you've simultaneously run into a couple of issues that have been resolved in #179 and #180.

If I try to deviate from what's on the website even a little bit, it seems the models file just doesn't ever get written.

In your first example, you had a single GraphQL type that was mapped to an existing struct.  In this case no model file is generated because there are no models needing generation.  If you were to add a second type to your schema and not map it, it would be generated for you.

Ahhh models.gen.go only gets written for things that are inputs to mutations, it seems. Adding a mutation.

Not strictly true, in your second example you now have an additional type Hi that does need to be generated.
The other problem with your second example is that you've misconfigured the model package.  This configuration option exists to set the name of the package at the top of the generated file.  In your case, omitting the exec and model config options, and relying on defaults should now work as expected with the latest release.


Add GitHub Actions under DevOps section

Fixes #483

OPS Build status updates of commit cde9c05:
:clock10: Preparing: average preparing time is 1 min(s) 37 sec(s)

.

OPS Build status updates of commit 478c8ac:
:clock10: Preparing: average preparing time is 1 min(s) 37 sec(s)

OPS Build status updates of commit 478c8ac:
:clock10: Incremental building: average incremental building time is 33 min(s) 50 sec(s)

OPS Build status updates of commit 478c8ac:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/index.yml
:white_check_mark:Succeeded
View (azure-node-latest) View (azure-node-preview)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@KarlErickson This PR only touches GitHub actions. The VSTS renaming is done in https://github.com/MicrosoftDocs/azure-docs-sdk-node/pull/486

OPS Build status updates of commit 154184e:
:clock10: Preparing: average preparing time is 1 min(s) 37 sec(s)

OPS Build status updates of commit 154184e:
:clock10: Incremental building: average incremental building time is 34 min(s)

OPS Build status updates of commit 154184e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-ref-conceptual/index.yml
:white_check_mark:Succeeded
View (azure-node-latest) View (azure-node-preview)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Connect two client PouchDB P2P style

I have a web app and a mobile app, both runs pouchdb. I want to enable sync between them, without storing any info on my server.
I read that I need to use a signal server and pouch over rtc.
Can anybody guide me or help me out with this.

Hi @theavijitsarkar - I'm not associated with the socket-pouch library but colleagues of mine developing the Tangerine survey tool have done something similar to what you are looking for instead of over WebRTC we used Android Nearby protocol between two devices. The trick to getting PouchDB to sync between two devices without traditional http is to 1) export the replication stream as a file using https://github.com/pouchdb-community/pouchdb-replication-stream and then 2) transfer that file to the other device where it can be imported into pouchdb using the same pouchdb-replication-stream library. Using pouchdb-replication-stream, you'll just need to figure out how to transfer files over Web RTC. Something like this tutorial might help.


generate the token for k8s v1.24 on eks cluster

Signed-off-by: hchenxa<EMAIL_ADDRESS>the eks not have v1.24 cluster supported, and starting from kubernetes v1.24, k8s will not generate secrets any longer automatically for ServiceAccounts, so we should manually generate it.

/assign @gurnben


Add Python 3 support to Artman

@ethanbao I was going to do some UX hacking on Artman, and discovered that it does not support Python 3. This pull request fixes that.
It does the following:

Updates the code to support Python 2.7 and 3.5. This mostly means print is consistently used as a function now, and calls to urllib, urlparse, and urllib2 now all pull from six.moves.urllib, which mirrors the Python 3 package.
Substantially refactors the test running. Running tox now does the following, in order:

Runs the Python 2.7 tests.
Runs the Python 3.5 tests.
Runs the linter (on Python 3.5).
Puts the coverage data together and produces a report.

The .travis.yml is also changed to reflect this.

LGTM, thanks for the refactoring!

There is an intermittent failure on one of the tests on Python 3.4 and Python 3.5 only. I am trying to figure out what the issue is.

The intermittent failure is that the test is depending on a dictionary serialization when dictionaries are unordered. Fixing.


Possible fix for #354

This is more explicit about only filtering out 'Properties' to avoid DeletionPolicy getting removed for LogGroup in #354
Not sure if this has any unintended side effects, but I ran the tests and they passed.

Hi,
I'd like to re-open this issue as it Troposphere now throws an error when using Python 2.6. I've commented on the offending line.
Thanks!

@oliviervg1: I just pushed a change to support 2.6.9.


Profiling improvements

Better detection of graphblas-opt in source tree
Handle apply_passes with filename (as done in profiling) when calling debug_passes after compilation error
Avoid "unknown" location in code generation, or debug information will not be emitted when translating to LLVM IR

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

85 of 92 (92.39%)  changed or added relevant lines in 2 files are covered.
6 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.2%) to 83.451%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

mlir_graphblas/cli.py
7
9
77.78%

mlir_graphblas/algorithms.py
78
83
93.98%

Files with Coverage Reduction
New Missed Lines
%

mlir_graphblas/cli.py
1
58.39%

mlir_graphblas/engine.py
1
75.29%

mlir_graphblas/tests/test_profile.py
4
51.95%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
2844

Relevant Lines:
3408

💛  - Coveralls


pulsar/logger: ensure the .With*() fields are logged

What problem does this PR solve?
Issue Number: close #10604
What is changed and how it works?
Just make Logger and Entry use the same structure.
Check List
Tests

Unit test

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

/retest

/retest

needs a severity label for #10604 :sweat_smile:

/check-issue-triage-complete


is it broken with purescript 0.10?

I got an error building empty project with installed purescript-maybe:
in module Data.Maybe.First
at /tmp/2/bower_components/purescript-maybe/src/Data/Maybe/First.purs line 40, column 1 - line 40, column 50

No type class instance was found for

Control.Monad.Monad (Maybe a)

No, it's not - this is one of the libraries that has been updated. What version are you depending on though? v2.0.0 is the latest.

Also what compiler version?

@paf31 beat me to it :smile: this might fail in 0.10.0 (which was pre-release), but not 0.10.1 I think?

Yes you are indeed ridht! Works with 0.10.1
Thanks!


fix NPE introduce on #1280

Hi,
Following testing on our side,
We've detected that the change I introduced on #1280 introduced NPE on executor failure on Spark3
This PR fix the executor on Spark3 and avoid NPE if we can't find the executor container
In case of container we show Executor {{exec-name}} failed with ExitCode: -1, Reason: Unknown (Container not Found)

Thanks for this, just ran into it yesterday


Style scaling

Would it be possible to normalise the style images and add something like a --style-scale option?
For example given the following images:
pyramid.jpg

perlin256.jpg

perlin512.jpg

The results become:

Hi there! I'm not sure what you are thinking of by 'normalize the style image'. Regarding the --style-scale, this is just a convenience feature that resizes the style image to some size before propagating it up the convnet, right?

Hey! What I'm looking for is a way to have the same style image produce roughly the same results for different sized subjects (I realise now that my example is backwards :D)
Maybe just by resizing the style to match the subjects size while keeping the aspect ratio. And then the --style-scale factor would be applied to the style image. Like that you can know that --style foo.jpg with --style-scale 2.1 produces the same effect on all input images.
I hope that made sense :)


Heroku Deploy

Hi, I successfully deployed the sample retail webapp with the direct link to deploy to heroku. However, when accessing the app I get the error "Invalid parameter: redirect_uri".

Hello @stefanbuetler, happy to hear that you were able to deploy the application.
Make sure you .env is configured correctly, then from your Devportal application make sure you've added the **Reply URLs following this pattern https://<ENV_URL>/login/callback.
** you must edit your application and then promote it again depending what stage you are using (dev, uat or prod)


Error with TopFlyTech Device

Dear Tananaev,
I was trying to test a TopFlyTech device with traccar. I have configured this device on 5047 port but unable to get the location data. I think traccar server is not be able to reply to Login packet.
I can see the login packet in log file but server is not replying to the login packet.
I have also checked the data protocol file in https://www.traccar.org/protocols/ which is same as TopFlyTech provided to me.  Please help me.....

Hi Tananaev,
If you wish I can set IP address and port of your testing server so that you can better test the device.
Please let me know if you want.

Looks like there was some mistake. What's called topflytech in Traccar is actually some other protocol. I guess it means it's not implemented yet.


Add -cd to latex support for section based?

Cannot use "../somthing" notation as the -cd option is not added to latexmk.
I could add it, but i have no idea how to create a pull request
@MrAdam ?

I can see that it causes problems if you try to compile a LaTeX file not in the project root - I will look into adding this soon :+1:


fix: correct type checking to handle false bools

Related issue(s)
Resolves #889
Description
Summary of changes
FieldElement.num_bits() returns 0 for `FieldElement::zero() so the current check for satisfying the AbiType fails. I've relaxed the check to accept 0 or 1 bits to address this.
Dependency additions / changes

Test additions / changes

Checklist

[x] I have tested the changes locally.
[x] I have formatted the changes with Prettier and/or cargo fmt with default settings.
[x] I have linked this PR to the issue(s) that it resolves.
[x] I have reviewed the changes on GitHub, line by line.
[x] I have ensured all changes are covered in the description.
[ ] This PR requires documentation updates when merged.

Additional context

Yes, that's true. As that requires us to bubble up changes to ACIR, let's just switch this to an explicit 0 or 1 check for the time being.


Add a new paper

Thank you for your contribution to all the researchers on 3D-GS. We've just finished a new work on 3D-GS, focusing on disentangling the geometry and appearance for 3D-GS. Could you add it to the repo? Thanks!
paper name: Texture-GS: Disentangling the Geometry and Texture for 3D Gaussian Splatting Editing
website：https://slothfulxtx.github.io/TexGS/
paper：https://arxiv.org/abs/2403.10050
code(coming soon)：https://github.com/slothfulxtx/Texture-GS

So many papers were released. I would appreciate if you could submit a pr. Thx.

I already got it added.


Support ++ for advancing to next data structure in data structure arrays

For the example below Section_Header is 0x28 byte in size and at 004141a3 it is actually advances to the next Section_Header (add     ebx, 40 in assembly). Even if technically this is correct, I would like to be able to see that advance like pSection++ which is more shorter and easy to understand.
0041417d        struct Section_Header* pSection = &NtHdrs->OptionalHeader + zx.d(NtHdrs->sizeOfOptionalHeader)
00414185        if (0 u< NtHdrs->numberOfSections) {
004141b3          int32_t i
004141b3          do {
00414193            pe_get_section_data(&sdata, DosHdr, pSection, &sdata)
0041419b            pe_append_to_section_list(&stpe->section_list, sdata)
004141a3            pSection = &pSection[1]
004141a9            i = i + 1
004141aa          } while (i s< zx.d(stpe->NtHdr->numberOfSections))
004141a0        }

Although I'd like to have an option where we can show ++. In the provided example it'd be better IMO if we were able to convert this to a for loop
struct Section_Header* pSection = &NtHdrs->OptionalHeader + zx.d(NtHdrs->sizeOfOptionalHeader)
for (int32_t i = 0; i s< zx.d(stpe->NtHdr->numberOfSections); i = i + 1)
{
  pe_get_section_data(&sdata, DosHdr, pSection[i], &sdata)
  pe_append_to_section_list(&stpe->section_list, sdata)
}


rest_api: use RESTClient class from the dlt core

Resolves #422

A question: we have the same mock REST API server for testing both in core and here?

@rudolfix yes, not sure how to handle this, I use it in both places.

I think the easiest is to remove the mock rest API from the core. It's not as important there as here, where we test parent-child endpoints

@rudolfix, tracking the mocker here: https://github.com/dlt-hub/dlt/issues/1293


[CI] support bazel build

Hi @Mr-Nineteen, on a high level, we may need a sub-section in the readme to tell users how to build with bazel


fix: Find vulnerabilities in workloads running images from private DockerHub repositories

Signed-off-by: Daniel Pacak<EMAIL_ADDRESS>

Let me make sure what the PR sorted out. It used to expect a registry URL without "http/https" schema, so if ~/.docker/config.json includes it, it didn't work. This PR adds GetHostFromServer and fixes the issue, right? Or, does this PR also fix something else?

Exactly that was the problem. Plus I smuggled some refactoring with better names for structs and variables.


Upgrade commander

Fixed args length check. Anything else works as before.

@jrit Let's release?

I just published web-resource-inliner@5

@TrySound you want to prep juice@7?

Yes, will submit a couple of PRs


Display "Loading..." or similar while wasm is being downloaded and compiled

Hi, thank you so much for creating trunk! It makes deploying wasm so much easier and more enjoyable!
My wasm application takes a few seconds to load, and during loading the browser only shows a white page, appearing broken to potential users. It would be nice to instead allow to configure some text that is displayed during loading (and ideally to style that text, or display an image instead, etc).
I would be totally satisfied with a CLI argument like trunk serve --loading-text "Loading...".
Alternatively, it would be nice if the link tag could support onload, such that loading animations can be manually removed by the user like e.g. this:
<link data-trunk rel="rust" href="Cargo.toml" data-wasm-opt="z" data-bin="..." onload="document.querySelector('#loading_bar').remove()"/>

I'm not entirely sure I support this.
On one hand, --loading-text 'Loading...' is too biased. What if I want an animated spinner for loading? It's not text.
I also think the current solution is flexible already. Anything put in the  will get replaced by Trunk automatically. So if you want a loading text, just put your loading modal there.
For example, on my website, the index.html body has an animated spinner, and that gets replaced when the WASM loads.

I also think the current solution is flexible already. Anything put in the  will get replaced by Trunk automatically. So if you want a loading text, just put your loading modal there.
For example, on my website, the index.html body has an animated spinner, and that gets replaced when the WASM loads.

Hm, for me, using trunk 0.16.0, the body is not replaced after the wasm file was loaded. I tried placing a
Loading...
 before or after the <link> in the body, but it stays there after my wasm stuff is showing up already. I am using Brave v1.42.97 (Aug 17th, 2022) based on Chromium 104.0.5112.102.

The link goes in the head.
For a good example, see https://github.com/simbleau/website/blob/e29ad56dc1cecd78a0e949cc267deb6aa1d068df/index.html#L68
I can't help much without seeing your code.

Thanks!
I have put the link into the head, but to no avail. The body is not emptied when the WASM is loaded.
I created an example project: https://github.com/ISibboI/debug-trunkrs
I put the link into the head, and a simple
Loading...
 into the body. After the WASM stuff loads and shows up, the text Loading... is still there. (Note that to make it show up, you have to move the mouse around the browser, this is a current limitation of the UI framework I am using I believe).
Do you get the same behavior? If yes, it might be an incompatibility with the UI framework.


move node-labeller and cpu plugin from ssp operator into kubevirt

What this PR does / why we need it:
moving node-labeller and cpu plugin from ssp operator into kubevirt
This feature labels nodes with host supported cpu models and features.
It runs empty virt-launcher pod which contains info about supported cpus
on the host. Virt-handler then parses all info and labels the node.
Signed-off-by: Karel Simon<EMAIL_ADDRESS>Release note:
move node-labeller and cpu plugin from ssp operator into kubevirt

@rmohr, @danielBelenky, @omeryahud, @davidvossel  please can you review this?

/retest

@davidvossel I updated the the PR as you wrote. Can you please check it?

/retest

/retest

/retest

/lgtm

/lgtm

Restoring Davids lgtm.

/retest

/override ci/prow/images

/retest

/override pull-kubevirt-e2e-k8s-1.14

/retest

/retest

/retest

/lgtm
/hold cancel

@ksimon1 can we create an issue to track the improvement to dynamically do the labelling if /dev/kvm gets loaded after we started?

/retest


Create branch for Kubernetes CI testing

We would like to have a branch created off of Mirantis/k-d-c master that we will be used as a stable branch for using with Kubernetes CI testing. The goals of having a separate, stable branch are:

The CI stable branch won't be (instantly) subject to changes introduced into master. We would rebase to master (and test) periodically/intermittently/as-needed.
The CI stable branch would introduce a pointer to a pre-built node DinD image that is built from that branch. This pointer might be in the form of a text file that contains a DockerHub URL, or a shell script that sets the DinD image environment variable (I'm open to suggestions on this). The goal would be for the CI to be able to reference a fixed k-d-c branch on GitHub (we would never have to change the kubernetes/test-infra CI code to affect a k-d-c upgrade), and from this branch, the CI would clone/find matching DinD scripts and pointer to a pre-built DockerHub node DinD image.

I'm open to suggestions on the best way to implement this!
Thanks!

We can do stable branch for this, as well as tagging. In any case, current image build mechanism needs to be redone as it depends on Docker Cloud. This part of Docker Cloud is not going to be shut down right now IIRC, but overall I'm not very happy with the need to deal with its ui every time I update kubernetes versions etc. Travis CI has one serious drawback, if you use it in debug mode it will give up all the secrets that are used to push images etc. So we need to either (a) move to CircleCI (b) have both Travis and CircleCI build jobs, with CircleCI pushing the images. I think the latter is probably better.

@ivan4th - Thanks for looking at this! Our group isn't using Travis CI nor CircleCI. Instead, we're using the standard Kubernetes test-infra Prow cluster, and we're having the Prow container/pod create a remote cluster on GCE using the gce-setup.sh script (via docker-machine). In our particular case, we're trying to test IPv6 on Kubernetes, but the test can be adapted to any test that wants to use a containerized cluster on GCE.
Here is the PR for the IPv6 CI
In the current proposed CI, we pull the k-d-c "k8s-1.10" branch, using that as our stable branch:
https://github.com/kubernetes/test-infra/pull/7529/files#diff-406185368ba7839d1459d3d51424f104R1961
and we point to a manually-built node DinD image (built and pushed by @rpothier ):
https://github.com/kubernetes/test-infra/pull/7529/files#diff-5539d275f091e62154f51653bbe4fba0R12461
And that setting is used as a "DIND_IMAGE" environmental variable for gce_setup.sh:
https://github.com/kubernetes/test-infra/pull/7529/files#diff-19bf1416db48c9c35ab71f2cd9cd79cfR379
What we'd like to do is to consolidate this logic, so that the pulls a k-d-c stable branch (instead of k8s-1.10), and from that branch, it can somehow find the value that it needs for "DIND_IMAGE" environmental variable to find a DinD image that was built from the k-d-c stable branch. I suppose it can find a URL for the "DIND_IMAGE" in a text file, or a new "fixed" script can be created for this k-d-c stable branch, and that text file or script gets bumped whenever the stable branch is updated.
In other words, we were not expecting that the CI would do that image building, but rather we'd manually build when the stable branch is updated.

Sorry for delay, there was some breakage after the changes related to IPv6. k8s-1.10 branch is obsolete right now... Does current master effba5c772c08db01d5722618d7b323a0f45702d suit you for the stable branch? There's a new problem found, #110, that will be fixed soon, but it shouldn't affect you if you're not  using swap.

Yes, current master should work for us, thanks! Re. swap, we usually manually disable that on our local hosts, and I'm pretty sure that GCE instances have swaps disabled.
Is there an easy way to solve the 2nd bullet in the description above? I don't know if I explained it well, but we had been using the k8s-1.10 branch and the corresponding k8s-1.10 DinD node image for CI. For the k8s-1.10 DinD node image, we used a fixed URL to the DockerHub image (i.e. DockerHub URL was compiled into kubernetes/test-infra). For this new stable branch, it would be better if the stable branch itself had a pointer (or script) to the latest DinD node image build from that branch. That way, our kubernetes/test-infra CI would never need to be modified... it would be able to find the DinD node image from the stable branch.

Yes, I think we can add stable script in fixed/ directory with EMBEDDED_CONFIG=y;DIND_IMAGE=mirantis/kubeadm-dind-cluster:stable in it, but perhaps it should only be updated on master when stable branch changes, so as to avoid confusion (newer dind script may not work with older image). So, I'm creating the stable branch then and adding this script?

That would be great! What is the process if we needed to update the mirantis/kubeadm-dind-cluster:stable image?

I think I'll add option -stable to build/genfixed.sh that will fetch dind-cluster.sh script from stable branch, patch it to use mirantis/kubeadm-dind-cluster:stable image and write as fixed/dind-cluster-stable.sh. We can then update it on master every time stable branch is updated.

The best solution would be to get rid of fixed/ altogether, packing almost all of kdc inside the image and leaving a very simple wrapper script to run kdc that would just start a container using dind image, like docker run --rm --privileged --pid=host mirantis/kubeadm-dind-cluster:... The container then would use nsenter to locate the docker socket (just mounting it via -v will not work on Mac) and then do all of dind-cluster.sh work. But right now I don't have enough time to implement that approach, maybe later... For now, I think what I wrote in the prev comment would do, what do you think?

Yes, I think what was in the prev comment will do for now, thanks.

@ivan4th Your previous comment seems like it might work for us, but one concern that I have is that we're using the gce-startup.sh script instead of using e.g. dind-cluster-stable.sh directly (our test run on GCE instances). Would we need a separate gce-startup-stable.sh script, or would there be a way to have the standard gce-startup.sh script call into dind-cluster-stable.sh?
Also, I like your second solution as a possible best approach! Instead of using nsenter to locate the docker socket, could the user just use a '-v /var/run/docker.sock:/var/run/docker.sock' argument in docker run?

Hi, I've added the new fixed script here: https://github.com/Mirantis/kubeadm-dind-cluster/blob/stable-fixed-version/fixed/dind-cluster-stable.sh
It uses mirantis/virtlet:stable image built from this branch: https://github.com/Mirantis/kubeadm-dind-cluster/tree/stable
Please confirm that this is what you need and I'll merge this new fixed script into master.
As of -v /var/run/docker.sock:/var/run/docker.sock from the last comment, it would be nice to be able to use it, but alas, it's not compatible with Mac Docker where -v has different meaning. In any case, getting rid of fixed scripts is perhaps one of the first things we should do shortly after upstreaming kdc.

@ivan4th - Thanks! I'd like to test this with our CI tests (will try this Thursday, if that's okay), but from a brief look at the script, it appears that it will do what we need!

@ivan4th - I haven't tested the new script yet in our CI environment. However, one thing to note is that our CI creates K8s clusters on GCE using the gce-setup.sh script. So to used the new 'dind-cluster-stable.sh' script in our setup, we would have to either:
(a) (Short term) Add a modified version of the gce-setup.sh script to our CI script that does everything gce-setup.sh does, except that at the very bottom, it calls the new 'dind-cluster-stable.sh' rather than 'dind-cluster.sh'.
(b) (Long term) Add a new 'gce-setup-stable.sh' script to the Mirantis repo that calls 'dind-cluster-stable.sh'???

@leblancd @ivan4th For gce-setup, how about  we create a config file called config-stable.sh
and put in in the fixed directory in the stable-fixed-version branch.
In that file we set the env variables for the CI environment.
In the CI scripts, we set EMBEDDED_CONFIG=y,
and run "cp fixed\config-stable.sh config.sh" before calling gce-setup.sh
We can then remove DIND_IMAGE and a few other env variables from the CI script also.

For the above comment, I pushed up the changes for review.
https://github.com/Mirantis/kubeadm-dind-cluster/pull/123


[Clang importer] Handle unavailable designated inits w/ available convenience inits

What's in this pull request?
This brings the fix for rdar://problem/26238032, which concerns problems with an unavailable, inherited designated initializer making an imported-as-member convenience factory initializer unusable.
Resolved bug number: (rdar://problem/26238032)

Before merging this pull request to apple/swift repository:

[ ] Test pull request on Swift continuous integration.

Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please smoke test
    OS X platform               | @swift-ci Please smoke test OS X platform
    Linux platform              | @swift-ci Please smoke test Linux platform

Validation Testing
    Platform     | Comment
    ------------ | -------------
    All supported platforms     | @swift-ci Please test
    OS X platform               | @swift-ci Please test OS X platform
    Linux platform              | @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

…rride an available import-as-member-init.
More generally, an unavailable initializer shouldn't stomp on an
available initializer, because it's possible that (for example) a
designated initializer will be unavailable but a factory initializer
will be available, so one still construct objects of that type.
Fixes rdar://problem/26238032.

@swift-ci Please test


pipenv setup

simple pipenv setup. duplicates requirements.txt so it is suitable to generate requirements.txt from pipenv as explained in https://pipenv-fork.readthedocs.io/en/latest/advanced.html#generating-a-requirements-txt?
I didnt include Pipfile.lock as we are likely supporting python versions.

.envrc is there for https://github.com/direnv/direnv/wiki/Python#pipenv

.envrc is there for https://github.com/direnv/direnv/wiki/Python#pipenv


Add message if a member of the household is not in the tax unit

Backend needs to add flag.
Frontend needs to add message.

Needs a flag for every tax benefit. Backend will flag individuals who are not in the tax unit.
Need to do this for Pell Grant too

language a HH will see when applicable:
There may be members of your household who are not part of your "tax household." Ask them to complete this tool to determine if they qualify for this benefit.

@kbottagaro @CalebPena where are we imagining this language goes?

Deferring to Caleb on this - not sure how he was thinking this should be
displayed.
On Wed, Apr 17, 2024 at 2:05 PM sydney-devine @.***>
wrote:

@kbottagaro https://github.com/kbottagaro @CalebPena
https://github.com/CalebPena where are we imagining this language goes?
—
Reply to this email directly, view it on GitHub
https://github.com/Gary-Community-Ventures/benefits-calculator/issues/993#issuecomment-2062124531,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BDVPUZPTWZ37NRTHVD4672TY53IZZAVCNFSM6AAAAABE4A3AUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRSGEZDINJTGE
.
You are receiving this because you were mentioned.Message ID:
@.***
com>

The display should match the other warning message display. @kbottagaro we need the copy for what will go here. Something along the lines of, It looks like you entered household members that are not part of your tax unit. . . etc.

@sydney-devine @CalebPena I thought this was the language we're using:
There may be members of your household who are not part of your "tax household." Ask them to complete this tool to determine if they qualify for this benefit.

@sydney-devine @CalebPena I thought this was the language we're using:
There may be members of your household who are not part of your "tax household." Ask them to complete this tool to determine if they qualify for this benefit.

 TY!

As per @CalebPena, note will also appear for RTD LiVE.

As per @CalebPena, note will also appear for RTD LiVE.

Great!

Also as per @CalebPena - include flag for these:
Medicaid (Health First Colorado)
SSI
CHP+
OAP
ANDCS

@sydney-devine @CalebPena I don't see this message in staging - ?


Create SQLite database file

SQLx does have the option to create the database file if it does not exist.
Diesel automatically creates the file by default.
I haven't found any way to do this using sea-orm.

Hey @Stefan99353, you can do it via from_sqlx_sqlite_pool. Basically you create a ordinary SQLx SQLIte connection then convert it into sea_orm::DatabaseConnection.

Thanks, that works.
Is there a way to do it in a way to be database agnostic?

One thing I've been doing is just appending the appropriate permission flags to the end of the path to the database file in the Database::connect call. Since it uses sqlx internally i figured it would work and it seems to have done the trick. For example:
let connection = Database::connect("/Users/me/.myapp/data.db?mode=rwc").await?;

Just make sure the path to wherever you are creating the file exists beforehand (or create it using std::fs)

Thank you @aaronleopold for helping out!


Translate website into French

Problem Description:
To have a multilingual website to enable many people to use this project more effectively.
Suggested Solution:
To translate this site into French 🇫🇷

I'm working on it

Wonderful!

Hey @iGitScor thanks for doing the work on getting these docs translated to french. ❤
I've just updated the english documentation for the typescript definitions, unfortunately my french is not good enough to update the translation.


add support to selectively disable array draggable by form configuration

fixes #336

Hi @sdetweil
Can you fix the rogue spaces that this PR adds (line 261 for instance, etc — see https://github.com/jsonform/jsonform/pull/348/files), and also provide an example schema so I can test this ?
Thanks a lot for your work !

EDIT: I corrected the spaces — you can merge master into your branch again (same for your other PRs)

attached file for playground
two cases, with drag enabled.

if u have a field with an ace editor in an array, and click in it, you are stuck in drag mode
only way out is to right click, then exit the right click. shouldn't happen

if drag is enabled, tabs in tabarray are draggable, but in my app that operation doesn't mean anything, so its should be tuned off,  but drag is enable form wide.  need something selective...  drag is set to false in the form attached

schema.json.txt


resnet50 inference result is wrong with tensorflow+oneDNN

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 16.04 x86_64
TensorFlow installed from (source or binary): source
TensorFlow version (use command below): 2.4
Python version: Python 3.7.9
Bazel version (if compiling from source): Build label: 3.1.0
GCC/Compiler version (if compiling from source): 5.4.0
CUDA/cuDNN version: run on CPU
GPU model and memory: run on CPU

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
we do not use these JIT primitives: convolution,jit:sse41, convolution,jit_dw:sse41, and bnorm_jit:msa by  comment out the configurations. We rebuild tensorflow 2.4 with oneDNN and run resnet50, but  the inference result is incorrect:
Predicted: [[('n02672831', 'accordion', 0.045002583), ('n03976657', 'pole', 0.03239749), ('n02966193', 'carousel', 0.029394835), ('n03063599', 'coffee_mug', 0.028039759), ('n02909870', 'bucket', 0.023439417)]]
predict_result:  accordion
Describe the expected behavior
the expected result is:
Predicted: [[('n02124075', 'Egyptian_cat', 0.9613135), ('n02127052', 'lynx', 0.021235), ('n02123597', 'Siamese_cat', 0.010190687), ('n02123159', 'tiger_cat', 0.0036373248), ('n02123045', 'tabby', 0.0015628876)]]
predict_result:  Egyptian_cat
Contributing

Do you want to contribute a PR? (yes/no):
Briefly describe your candidate solution(if contributing):

Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.
1、we found that result is correct when running tensorflow in single thread configuration;
2、result is also correct when open  convolution,jit:sse41

@gititgo
This issue is more suitable for TensorFlow Models repo. Please post it on Tensorflow Models repo from here. Thanks!

We do not use The TensorFlow Model Garden.
We just config oneDNN(comment out convolution,jit:sse41) and rebuild tensorflow. Then we found the inference result of resnet50 model is incorrect.
We speculate that it is the problem of Conv2D implementation.

@gititgo
Could you please provide the colab gist to analyse the issue better.Thanks


Consistently use GE plugin 3.2.1

We still have been applying plugin 3.2-rc-1 to the build itself.

@jonnybbb Looks like the AutoAppliedGradleEnterprisePlugin class was also not updated properly and this is part of the release process. I already updated the release process a bit. Can you check why this has not properly been done or if the documentation was not correct?

The PR #12703 included the files https://github.com/gradle/gradle/pull/12703/files


nyc failing sometimes on Bitbucket's Pipeline

I tried to run nyc in bitbucket's pipeline, but sometimes the builds fails with this error. However, running locally on my machine, this error does not occur.
nyc version: 11.2.1
OS(Local): macOS High Sierra 10.13
OS(Pipeline): Linux 4.13.5-coreos-r2
npm version: 3.10.10
node version: 6.9.4
npm info ok
/opt/atlassian/pipelines/agent/build/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/transformer.js:97
mappedCoverage.addStatement(mapping.loc, hits);
^
TypeError: mappedCoverage.addStatement is not a function
at /opt/atlassian/pipelines/agent/build/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/transformer.js:97:28
at Array.forEach (native)
at SourceMapTransformer.processFile (/opt/atlassian/pipelines/agent/build/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/transformer.js:88:34)
at /opt/atlassian/pipelines/agent/build/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/transformer.js:169:24
at Array.forEach (native)
at SourceMapTransformer.transform (/opt/atlassian/pipelines/agent/build/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/transformer.js:159:25)
at MapStore.transformCoverage (/opt/atlassian/pipelines/agent/build/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/map-store.js:143:8)
at SourceMaps.remapCoverage (/opt/atlassian/pipelines/agent/build/node_modules/nyc/lib/source-maps.js:29:41)
at NYC._getCoverageMapFromAllCoverageFiles (/opt/atlassian/pipelines/agent/build/node_modules/nyc/index.js:426:30)
at NYC.report (/opt/atlassian/pipelines/agent/build/node_modules/nyc/index.js:432:18)
npm info lifecycle<EMAIL_ADDRESS>Failed to exec unit-coverage script
npm ERR! Linux 4.13.5-coreos-r2
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "unit-coverage"
npm ERR! node v6.9.4
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>unit-coverage: nyc --reporter=lcovonly npm run unit-test
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>unit-coverage script 'nyc --reporter=lcovonly npm run unit-test'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the dsm-api package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     nyc --reporter=lcovonly npm run unit-test
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs dsm-api
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls dsm-api
npm ERR! There is likely additional logging output above.
npm ERR! Please include the following file with any support request:
npm ERR!     /opt/atlassian/pipelines/agent/build/npm-debug.log

I see the same error intermittently on travis TypeError: mappedCoverage.addStatement is not a function.

any udpates/work around on this? i was planning to use this and it seems to fail intermittently with the above error

@andre991, @arupadhy, @brollins90 would any of you be able to share a codebase that is having this issue?
Once we have a repo that reproduces this issue, perhaps we can release a version of nyc that has a debug statement in transformer.js ...  what is the object that it's trying to call addStatement on?

@bcoe  unfortunately, i can't share the codebase. This does not happen in every run. Can't promise but I will try to create a public typescript project with the above problem in coming week

@arupadhy oh, that's a useful piece of information that you're using TypeScript; are you also using --all? try dropping the use of --all if you are, and see if builds continue failing. If this is the culprit, I can follow up with a workaround (that will allow you to continue using --all).

Tried removing --all option, no luck yet.
here is the trace
TypeError: mappedCoverage.addStatement is not a function
at /srv/package/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/transformer.js:97:28
at Array.forEach (native)
at SourceMapTransformer.processFile (/srv/package/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/transformer.js:88:34)
at /srv/package/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/transformer.js:169:24
at Array.forEach (native)
at SourceMapTransformer.transform (/srv/package/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/transformer.js:159:25)
at MapStore.transformCoverage (/srv/package/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/map-store.js:143:8)
at SourceMaps.remapCoverage (/srv/package/node_modules/nyc/lib/source-maps.js:29:41)
at NYC._getCoverageMapFromAllCoverageFiles (/srv/package/node_modules/nyc/index.js:415:30)
at NYC.report (/srv/package/node_modules/nyc/index.js:421:18)
npm info lifecycle<EMAIL_ADDRESS>Failed to exec check-coverage script
This is how "check-coverage" is declared
"check-coverage": "NODE_ENV=test LOG_LEVEL=info nyc  --report-dir spec/coverage  --reporter cobertura --reporter html  npm run test-coverage"
"test-coverage": "NODE_ENV=test ./node_modules/mocha/bin/_mocha  --timeout 30000 -R mocha-multi --reporter-options spec=-,xunit=spec/reports/xunit.xml './dist/spec/unit///*.js'"

Just curious, does your setup loom something like this? https://istanbul.js.org/docs/tutorials/typescript/

this is how my .nycrc looks {
"check-coverage": false,
"exclude": [
"dist",
"spec"
]
}
Rest of the options for nyc are used within the script (see ^^)

This was failing reliably with our project; I whittled things down to the minimum that would still fail reliably, and that whittled result is available at https://github.com/mbradburn/istanbul-test-case
The stack trace looks like:
/Users/mjb/w2/istanbul-test-case/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/transformer.js:97
mappedCoverage.addStatement(mapping.loc, hits);
^
TypeError: mappedCoverage.addStatement is not a function
at /Users/mjb/w2/istanbul-test-case/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/transformer.js:97:28
at Array.forEach ()
at SourceMapTransformer.processFile (/Users/mjb/w2/istanbul-test-case/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/transformer.js:88:34)
at /Users/mjb/w2/istanbul-test-case/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/transformer.js:169:24
at Array.forEach ()
at SourceMapTransformer.transform (/Users/mjb/w2/istanbul-test-case/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/transformer.js:159:25)
at MapStore.transformCoverage (/Users/mjb/w2/istanbul-test-case/node_modules/nyc/node_modules/istanbul-lib-source-maps/lib/map-store.js:143:8)
at SourceMaps.remapCoverage (/Users/mjb/w2/istanbul-test-case/node_modules/nyc/lib/source-maps.js:29:41)
at NYC._getCoverageMapFromAllCoverageFiles (/Users/mjb/w2/istanbul-test-case/node_modules/nyc/index.js:437:30)
at NYC.report (/Users/mjb/w2/istanbul-test-case/node_modules/nyc/index.js:443:18)
npm ERR! Test failed.  See above for more details.

I have the same error in VSTS.

I'm seeing the same error and stack trace as @mbradburn.
This started happening when moving onto babel-plugin-istanbul. My .nycrc:
{
  "require": [
    "@babel/register"
  ],
  "reporter": [
    "html",
    "cobertura"
  ],
  "sourceMap": false,
  "instrument": false
}


Remove duplicated docs from setup ingress on minikube

Signed-off-by: Masato Naka<EMAIL_ADDRESS>
Why
To make the docs concise in Enable the Ingress controller in Set up Ingress on Minikube with the NGINX Ingress Controller

What

Remove duplicated and malformed codes and explanations.

before

after

/lgtm


Creating severities randomly fails

Hi,
I'm testing the terraform provider for FireHydrant and I'm seeing a weird behaviour when creating severities.
I have a TF file that creates five different severities, from SEV1 to SEV5. When I ran terraform two severities were created and 3 failed with Error: Could not create severity SEV3.
On the next run one extra severity was created and two more failed, and the remaining two needed an extra run to be created.
So three total terraform runs to create five severities.
This seems to consistently happening, if I delete all severities again I'll get the same errors.
Running in debug mode isn't throwing anything interesting.
The code I'm using
locals {
  severities = [ "SEV0","SEV1","SEV2","SEV3","SEV4","SEV5",]
}
resource "firehydrant_severity" "sev" {
  for_each = toset(local.severities)

  slug        = each.key
}

And the output on the first run
tf-apply
firehydrant_severity.sev["SEV5"]: Creating...
firehydrant_environment.environments["Production"]: Creating...
firehydrant_severity.sev["SEV4"]: Creating...
firehydrant_severity.sev["SEV2"]: Creating...
firehydrant_severity.sev["SEV1"]: Creating...
firehydrant_severity.sev["SEV3"]: Creating...
firehydrant_severity.sev["SEV0"]: Creating...
firehydrant_environment.environments["Integration"]: Creating...
firehydrant_environment.environments["Staging"]: Creating...
firehydrant_severity.sev["SEV5"]: Creation complete after 1s [id=SEV5]
firehydrant_environment.environments["Integration"]: Creation complete after 1s [id=9a769e60-7057-4c5f-b652-ba615cc0d99d]
firehydrant_environment.environments["Production"]: Creation complete after 1s [id=a515cab0-9ff6-47a2-95ea-d10a8a7cfad7]
firehydrant_environment.environments["Staging"]: Creation complete after 1s [id=e70cec7b-66a3-4f4a-a324-f85537e54c01]
firehydrant_severity.sev["SEV3"]: Creation complete after 2s [id=SEV3]
firehydrant_severity.sev["SEV1"]: Creation complete after 2s [id=SEV1]
firehydrant_severity.sev["SEV0"]: Creation complete after 2s [id=SEV0]

Error: Could not create severity SEV4

Error: Could not create severity SEV2

Hey @dsolsona, sorry for a very late reply here. We've identified this problem as an issue with our API and will ship a fix soon. Thanks for reporting it.

Any updates here @bobbytables? just curious

@marceloboeira @dsolsona This has been fixed in the API! 🎉 I also tested creating and deleting multiple severities with the provider and everything worked as expected. I used the following config, as SEV1-SEV5 exist by default in FireHydrant now.
locals {
  severities = [ "TESTSEV0","TESTSEV1","TESTSEV2","TESTSEV3","TESTSEV4","TESTSEV5",]
}
resource "firehydrant_severity" "sev" {
  for_each = toset(local.severities)

  slug        = each.key
}

I'm going to close this issue but if you have any problems, please open a new issue and we'll be happy to take a look.
Thanks again for reporting this issue :]


added open PRs Page

Closes #27

Made the suggested changes @whyDontI . Please review .

Made the suggested changes @whyDontI . Please review .

Done suggested changes. Please review

Done suggested changes. Please review


[21711] Update DataWriter/Reader get_matched_publication/subscription...() API tests

Description

This PR updates DataWriter/Reader get_matched_publication/subscirption...() tests as result of API implementation:

eProsima/Fast-DDS#5284

Contributor Checklist

[X] Commit messages follow the project guidelines.
[X] Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
[X] Changes are API compatible.
N/A Applicable backports have been included in the description.

Reviewer Checklist

[x] The PR has a milestone assigned.
[x] The title and description correctly express the PR's purpose.
[x] Check contributor checklist is correct.
[ ] Check CI results: changes do not issue any warning.
[ ] Check CI results: failing tests are unrelated with the changes.

Tests were failing because we merged the implementation PR and the branch in Fast DDS is no longer available. We would need to manually run it.

Manual CI run:

I am closing this since its implementation entails a behavior change and new majors are not planned for 2.x


Compile Python to Executable

Hi Jim, thanks for creating this repo, this combined with pylivelink  opens a lot of a opportunities.
Can you share some details on how you created the stand along binary? Specifically how you've incorporate the libraries such as mediapipe  and opencv.

Hi, oh yeah I missed it in the Readme. Here's the command which I used to create that exe.
You need to install pyinstaller and then use the included spec file:
pip install pyinstaller
pyinstaller --onefile .\examples\mefamo.spec

I will add it to the readme (and also add the spec file which includes the commands for including all libs etc).

Added everything to git.


Kagi Transformation

ref="chartCanvas" - unavailable for Kagi Transformation
TypeError: Cannot read property 'idx' of undefined (When try to update data (using update example ) )

where is this error message?
provide more details please and a plunker.

http://plnkr.co/edit/JMm2lgrzBgWnh3hkoTAR?p=preview

that is a good one. What is happening is on each data push the chart is moved one period, but since Kagi data is non linear it is not able to keep up. This will happen for Renko and P&F too.

Fixed in 0.2.4
Added working example also in http://rrag.github.io/react-stockcharts/documentation.html#/updating_data

Awesome! Thanks for your work!


Added common name to cert tmpl

Changes
This adds a common name to the certificates generated for the webhook service to
prevent issues with applications that do CN checking vs SAN checking.
This provides compatibilty for Istio v1.5
There should be no impacts because there was previously no CN on the certificate
Another approach would allow users to provide custom CA certs for this serivce

/ok-to-test
you need to sign the CLA>

Also we might want a test?

@vagababov I signed the CLA after submitting. How would you recommend testing this?

you need to say
@googlebot I signed it!

@googlebot I signed it!

@googlebot I fixed it.

@googlebot I fixed it.

Let's add a test, and I think this should be fine.

There might be no existing ones right now.
But just testing this create function seems pretty tenable.

@vagababov Sounds good. I was able to find this test file in the project and I looked the results of the unit tests job and this appears to have passed.
https://github.com/knative/pkg/blob/master/webhook/certificates/resources/certs_test.go
Will this suffice?
Thanks!

We need to verify the new field is set somehow.

@mattmoor @vagababov Appreciate all of your feedback. All suggestions incorporated and test has passed. Please let me know if I need to change anything else.

/approve
Generally this LGTM, but a formatting nit.

@mattmoor thanks! Formatting changes applied, but that removed the lgtm label.

Yeah, that's why I didn't bother to /lgtm before.  Thanks!
/lgtm


cabana: add mutex around new_msgs

After https://github.com/commaai/openpilot/pull/27149 I'm seeing random crashes while seeking. It's obvious when zooming in to a small region so it has to loop around constantly.
I can't reproduce it with the replaystream in openpilot, but it's easy to hit with my own stream implementation. Which is basically just sleeping, and calling updateEvent in a loop. Adding locks fixed it.
@deanlee any thoughts why this could be? Do I need to add locks to my own stream implementation instead?
My stream implementation:
void VSBStream::seekTo(double ts) {
  it = std::lower_bound(can_events.begin(), can_events.end(), ts * 1e9, [](auto &e, uint64_t x) { return e->mono_time < x; });
  if (it == can_events.end()) it = can_events.begin();
  emit seekedTo((*it)->mono_time / 1e9);
}

void VSBStream::streamThread() {
  uint64_t last_run = nanos_since_boot();
  emit streamStarted();

  while (!QThread::currentThread()->isInterruptionRequested()) {
      QThread::msleep(1);
      uint64_t t = nanos_since_boot();

      if (isPaused()) {
        last_run = t;
        continue;
      }

      // Loop over events that need to be sent out since last iteration of this loop
      auto end_t = (*it)->mono_time + (t - last_run) * speed;
      for (; it != can_events.end() && (*it)->mono_time <= end_t; ++it) {
        updateEvent(*it);
      }

      // Loop around
      if (it == can_events.end()) {
        it = can_events.begin();
      }

      last_run = t;
  }
}

Ok, will fix it on my side then!
I assumed from   // updateEvent will not be called before replayStream::seekedTo return. that this was guaranteed by abstractstream, but this is up to the implementor then.

y, this is handled in the implementations.


Changing bit shift order of spidriver

I'm using the spidriver to interface with a PN532 NFC module.  The former uses most-significant bit (MSB) first shifting while the latter uses least-significant bit (LSB) first shifting on the SPI bus.
It seems from the datasheet for the spidrivers microcontroller, the hardware SPI shift order can be configured, and would be a nice feature to have.
Unfortunately, I don't know Forth to implement a PR.  Instead, I've modified the spicli tool [1] to add "lsb" and "msb" commands to reverse the bits in bytes before transmitting and after receiving, and it works well enough that writing shell scripts against spicli remains clean and readable.
[1]: https://github.com/boxofrox/spidriver/tree/feature/bit-shift-order

Having this functionality in SPIDriver would be useful to eme as well, but for now I'm following boxorox' approach of reversing the bits in my Python program.


Publish Open API spec to allow generation of SDKs for other languages

Hi,
We're looking to create a notion SDK using Scala.
Would it be possible to access your OpenAPI spec or whatever was used to generate api-endpoints.ts please ?
It seems that it was already discussed here though the page doesn't exist anymore.
Thanks.

That would be awesome and shouldn't be a lot of work as we found that OpenAPI is actually available behind the scene on the readme.io portal used by Notion for its API documentation. Would it be possible to officially publish it?
Note: this OpenAPI lacks a detailed definition for a few objects like filter object.

Just wanted to check if there was any progress on this. It would be very helpful to get the official Open API spec.

Same here, we wanted to consume the API using PureScript but ended up giving up and using TypeScript simply because of this.

+1 – I wanted to use Notion API in my product without using the sdk or writing code manually. I am building a product that depends heavily on integrations, you can imagine why I don't want to use every service's SDK :)

+1 too. Still waiting for an official OpenAPI specifications that the Notion engineering has probably written...

Same here

I've made this one myself for the time being: https://openapi.actionschema.com/notion.json
Use at your own risk :)