Added pull_request_template.md

Fixes #51

Congratulations @suhanipaliwal ,

Please add the label of level1 on this pull request.

Could you please add the label of level1


Move workshop to GitHub Pages

Big PR here, with the overall changes required for moving to GitHub Pages using Roy's Specky template for Quarto. In summary:

The website is now a Quarto-based website hosted at GitHub Pages, built and deployed using GitHub Actions.
The website is accessed at https://nbisweden.github.io/workshop-reproducible-research/. It has important pages in a header (home, schedule, content, syllabus, pre-course and info), while lectures and pages can be found through links either in the schedule or content pages.
The tutorials/ and lectures/ directories and unchanged, except that HTML lectures are no longer directly stored in the main Git repository, but are accessed from the website itself.
The schedule can be changed by editing the schedule.xlsx Excel file in the repo root and will be formatted with cool code made by Roy.
The website environment has been consolidated with the lecture environments into a single Docker image hosted in GHCR for this repository, and is automatically built using GHA whenever it is changed. It is used when building and deploying the website, but can also be used for local testing.
The only thing left on Canvas will be the first page, which will be used as a landing page.

Some things still need to be done:

[ ] Go through lectures and check that they are formatted correctly for how they are rendered now.
[ ] Go through the entirety of the material and make sure that there is no odd formatting left from the conversion of the material from Markdown to Quarto.
[ ] Check the other, already existing Actions and see which ones are not needed any more.
[ ] Make new images where required (e.g. the front page), Roy is helping out.
[ ] Resolve Jupyter conflicts (could you do this, John?)

My proposal for this new system would be that we only keep the main branch and either remove/archive or ignore the dev branch, which was only used for testing changes on Canvas. This is no longer necessary as new changes/contributions can be tested by building the website locally before opening a PR from a feature branch. We can keep tagging course rounds as we have done previously, which can be re-build locally if somebody wants to check out them, although experience leads me to believe that this is unlikely to be the case.
This PR is against the devel branch to get a better diff against the latest changes, but as soon as this PR is approved we should also merge it directly into main.

Regarding existing GitHub Actions:

docker-run.yml / docker-build-and-run: This just tests that the Container tutorial image (Dockerfile not Dockerfile_slim) can be built and run. As this is the "final" image of the Container tutorial and not edited by the students it makes sense to keep this, but we might optimise it if we want.
setup.yml / install: This attempts to install all Conda environments on both MacOS and Ubuntu. Good thing to test, but we should change the default fail-fast matrix option to false, as most jobs are currently being cancelled if a single job fails (which for this type of test we don't want). Some steps use outdated actions, which we should update.
setup-slim.yml / docker-slim-install: This does the same as the above action, but inside the image created with the tutorials/containers/Dockerfile_slim Dockerfile. I'm not sure why we do this. I have tried searching through the tutorials and the pre-course setup and find where this image is mentioned, but it just seems that it's the image the students starts with in the tutorial and add changes to. Did we use this before as well for Windows or something, before we required WSL2 for Windows students? Or am I missing something? Currently it seems we could remove this action. (If there is good reason to keep it the same issues as for the above action applies.)

Did we use this before as well for Windows or something, before we required WSL2 for Windows students?

Yes that's exactly what it was for


Request to try out the rough version

Hey there, thanks for the open source code! You mentioned in the other issue that you are still cleaning up the code. It will be great if you can share with me the rough version that you have. I am currently working on TSP for my final year project.
Also, may I know when will the clean version of the code be released? Thanks a lot!

Hi tobylin19,
Please reach out to me by e-mail (see the paper) and I'll give you the code which should be usable (but still some rough edges). I expect to have the code fully ready, verified and public in about 1-2 weeks.

Hi @tobylin19,
The code is now available! Please give it a try and let me know if you find any issue!


TOC duplicate headers

Describe the bug
When using the 'Generate TOC' feature on a document with headers with identical names, it does not number the anchors. So it will always only jump to the first occurrence of that header. It should number them.
To Reproduce
Create any document with 2 or more identical headers. Example:
## Link

## Link

## Link

Generate the automatic TOC. You get:
<!--TOC-->
  - [Link](#link)
  - [Link](#link)
  - [Link](#link)
<!--/TOC-->

You should get:
<!--TOC-->
  - [Link](#link)
  - [Link](#link-1)
  - [Link](#link-2)
<!--/TOC-->

This is more apparent when there is a large body of text between the headers.

I just notice that saving the file will sometimes clear the TOC or overwrite it with garbage data.


configure sqlite path in env var

as part of deployment the db path will move to env var
when this happens we need to use it (instead of UBIQUITY_DB_SQLITE_PATH that is currently defined in main)

Closing it.
Will be fixed later on as part of environment refactoring (internal ticket).


New Landscape Entry - IRENA FlexTool

Project Name
IRENA FlexTool
Description
An energy and power systems model for understanding the role of variable power generation in future energy systems. It performs capacity expansion planning as well as operational planning.
Homepage URL
https://irena-flextool.github.io/flextool/
Repo URL
https://github.com/irena-flextool/flextool
Organization hosting or owning the project
IRENA
Logo

Category
Energy Systems - Modeling and Optimization

Hi - thank you for this @jkiviluo! Would you happen to have an SVG/AI/EPS version of the logo, or perhaps something higher quality to trace?

Here's a higher resolution version in PNG. Couldn't get it to SVG from PowerPoint without losing the vectors.


Hide details of failed upload? Or fix them?

A failed upload happens when for instance Internet cuts in the middle of an upload.
In such cases, the image appears as a "failed" item in the home activity.
Unlike other images, tapping on this failed upload does not show the image's details activity. I guess this is intended?
Problem: If you tap the next unfailed image and swipe left, you can reach the failed image's details.
Solution 1
Fix the details activity so that it shows correct information for a failed upload (for instance I believe the categories are stored so that they can be used when retrying?), and make it accessible by tap in the home activity, like all other images. Also, remove its download/share/date/copy/delete fields and all other fields that are not relevant.
Solution 2
Make the the details of the failed image not accessible via swipe or any other mean.

@ShridharGoel Let's go with solution 1. Are you still motivated to work on it? :-)

Yes, definitely! :)

@ShridharGoel  Assigned to you :-)

@ShridharGoel  Are you still working on this Issue or Shall I take this up?

@vanshikaarora Feel free to work on this.

Thanks @ShridharGoel :)

You're welcome @vanshikaarora :)

Reopening as not fully solved, still doesn't display all the details we could.

Reopening as not fully solved, still doesn't display all the details we could.

Sorry for not seeing this before. I just checked issue with failed images is here (probably incorrect parsing of API response)
java.io.IOException: org.xml.sax.SAXParseException: Unexpected end of document
        at fr.free.nrw.commons.MediaDataExtractor.processWikiParseTree(MediaDataExtractor.java:119)
        at fr.free.nrw.commons.MediaDataExtractor.fetch(MediaDataExtractor.java:84)
        at fr.free.nrw.commons.media.MediaDetailFragment$3.doInBackground(MediaDetailFragment.java:290)
        at fr.free.nrw.commons.media.MediaDetailFragment$3.doInBackground(MediaDetailFragment.java:275)
        at android.os.AsyncTask$2.call(AsyncTask.java:304)
        at java.util.concurrent.FutureTask.run(FutureTask.java:237)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
        at java.lang.Thread.run(Thread.java:762)
     Caused by: org.xml.sax.SAXParseException: Unexpected end of document
        at org.apache.harmony.xml.parsers.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:125)
        at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:107)
        at fr.free.nrw.commons.MediaDataExtractor.processWikiParseTree(MediaDataExtractor.java:115)
        at fr.free.nrw.commons.MediaDataExtractor.fetch(MediaDataExtractor.java:84)
        at fr.free.nrw.commons.media.MediaDetailFragment$3.doInBackground(MediaDetailFragment.java:290)
        at fr.free.nrw.commons.media.MediaDetailFragment$3.doInBackground(MediaDetailFragment.java:275)
        at android.os.AsyncTask$2.call(AsyncTask.java:304)
        at java.util.concurrent.FutureTask.run(FutureTask.java:237)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
        at java.lang.Thread.run(Thread.java:762)

Since the previous PR is already merged shall I work on a different PR for this?

Please open another PR @vanshikaarora :)


Miner running out of storage

Just discovered that this miner is out of storage. We need to add some kind of checks for this.

The problem is the following from within the helium-miner container:
/ # du -hs  /var/data/
25.9G   /var/data/

Technically speaking, this is the "miner-storage" volume.

What about find /var/data/blockchain.db -type f -mtime +7 -delete until we have something based on blessed block?

Fair. Yeah maybe better to just wait and do it properly. But be good to get it sorted soon

FYI https://github.com/helium/miner/issues/984 and https://github.com/helium/blockchain-core/pull/808

FYI @robputt

@vpetersson @robputt basically if we delete files in /var/data/blockchain.db with file ending .sst that are older than 7 days old it basically achieves what we want

It's not that simple apparently. @robputt already tested that and the miner breaks if you do that as old files are still referenced. Work begun in https://github.com/NebraLtd/hm-disk-purger


Lagrange cannot use a non-Gemini search engine

How to reproduce:

Go to the Veronica 2 gopherhole: gopher://gopher.floodgap.com:70/1/v2
Right click on "Search Veronica-2" and click "Use as search URL"
Try to search for something in the address bar

Expected result: You search for something on Veronica 2
Actual result: Lagrange interprets gopher:// as trying to access the domain name "gopher" through gemini, coming up with a broken URI like this: gemini://gopher://gopher.floodgap.com:70/7/v2/vs?test
In other words, it sticks gemini:// in front of gopher:// and fails to load.

Fixed for the upcoming 1.18.4.

Until the next release, there is a sort of workaround I found:
Add snippets for non-Gemini search engines. For example, I added veronica2 under !v2. Now I can just type "!v2 chili recipe" to search gopher, for example.


ETA for a tagged release?

Please tag a release so that this can be distributed by package managers. For simplicity, maybe use the YYYYMMDD format?

I've added a 1.0.0 tag (I think I'm going to go with semantic versioning). Please reopen if this doesn't work for you or if there's another issue.


[BUG] frame.append is deprecated

Description
Using the append method of a pandas dataframe or series is deprecated.

https://pandas.pydata.org/docs/whatsnew/v1.4.0.html#whatsnew-140-deprecations-frame-series-append

In which platform does it happen?
Python >= 3.9
How do we replicate the issue?
Use any method that uses append in a 3.9 environment and it will raise a FutureWarning
Expected behavior (i.e. solution)
No warning raised
Other Comments
Changing all the appends to concats is a straightforward task, it would be a good first issue. It would also be a step forward into #1919

@daviddavo is this fixed?

Yeah, it should be fixed with #2058


sdist with --dist-dir on Windows produces incorrect archive

@jaraco
Using a relative path works as expected (python setup.py sdist --dist-dir dist)

however using an absolute path (python setup.py sdist --dist-dir C:\Users\Ofek\Desktop\mypkg\dist) includes the entire path structure starting at the drive/root

It seems the issue does not happen on Unix:
$ cat > setup.py
__import__('setuptools').setup(name='mypkg', version='1')
$ python setup.py sdist --dist-dir=$(pwd)/dist --formats=zip,gztar
running sdist
running egg_info
writing mypkg.egg-info/PKG-INFO
writing dependency_links to mypkg.egg-info/dependency_links.txt
writing top-level names to mypkg.egg-info/top_level.txt
reading manifest file 'mypkg.egg-info/SOURCES.txt'
writing manifest file 'mypkg.egg-info/SOURCES.txt'
warning: sdist: standard file not found: should have one of README, README.rst, README.txt, README.md

running check
warning: check: missing required meta-data: url

warning: check: missing meta-data: either (author and author_email) or (maintainer and maintainer_email) must be supplied

creating mypkg-1
creating mypkg-1/mypkg.egg-info
copying files to mypkg-1...
copying setup.py -> mypkg-1
copying mypkg.egg-info/PKG-INFO -> mypkg-1/mypkg.egg-info
copying mypkg.egg-info/SOURCES.txt -> mypkg-1/mypkg.egg-info
copying mypkg.egg-info/dependency_links.txt -> mypkg-1/mypkg.egg-info
copying mypkg.egg-info/top_level.txt -> mypkg-1/mypkg.egg-info
Writing mypkg-1/setup.cfg
creating '/Users/jaraco/yg/work/dist/mypkg-1.zip' and adding 'mypkg-1' to it
adding 'mypkg-1/PKG-INFO'
adding 'mypkg-1/setup.py'
adding 'mypkg-1/setup.cfg'
adding 'mypkg-1/mypkg.egg-info/PKG-INFO'
adding 'mypkg-1/mypkg.egg-info/SOURCES.txt'
adding 'mypkg-1/mypkg.egg-info/top_level.txt'
adding 'mypkg-1/mypkg.egg-info/dependency_links.txt'
Creating tar archive
removing 'mypkg-1' (and everything under it)
$ ls -la dist
total 16
drwxr-xr-x   4 jaraco  staff   128 Nov 13 10:50 .
drwxr-xr-x  10 jaraco  staff   320 Nov 13 10:51 ..
-rw-r--r--   1 jaraco  staff   570 Nov 13 10:51 mypkg-1.tar.gz
-rw-r--r--   1 jaraco  staff  1363 Nov 13 10:51 mypkg-1.zip
$ tar tzf dist/mypkg-1.tar.gz
mypkg-1/
mypkg-1/PKG-INFO
mypkg-1/mypkg.egg-info/
mypkg-1/mypkg.egg-info/PKG-INFO
mypkg-1/mypkg.egg-info/SOURCES.txt
mypkg-1/mypkg.egg-info/top_level.txt
mypkg-1/mypkg.egg-info/dependency_links.txt
mypkg-1/setup.py
mypkg-1/setup.cfg
$ rwt -q openpack -- -m openpack.zip-listdir dist/mypkg-1.zip
d mypkg-1

So the issue seems to be isolated to Windows.

Since sdist is largely implemented in distutils, I suspect the issue lies in the upstream implementation. Can you confirm the issue happens if you use distutils without setuptools?

@jaraco Sure! What would those imports be?

respectful bump

I tried replicating the issue on Windows with just distutils and could not. Here's the setup script I created:
__import__('distutils.core').core.setup(name='mypkg', version='1')

However, when I tried to replicate your experience in Setuptools, I can't make it happen:
PS C:\Users\jaraco\m\setuptools-1185> py -m easy_install --version
setuptools 38.5.1 from c:\python36\lib\site-packages (Python 3.6)
PS C:\Users\jaraco\m\setuptools-1185> cat setup.py
__import__('setuptools').setup(name='mypkg', version='1')
PS C:\Users\jaraco\m\setuptools-1185> py setup.py sdist --dist-dir=c:\Users\jaraco\dist
running sdist
running egg_info
writing mypkg.egg-info\PKG-INFO
writing dependency_links to mypkg.egg-info\dependency_links.txt
writing top-level names to mypkg.egg-info\top_level.txt
reading manifest file 'mypkg.egg-info\SOURCES.txt'
writing manifest file 'mypkg.egg-info\SOURCES.txt'
warning: sdist: standard file not found: should have one of README, README.rst, README.txt, README.md

running check
warning: check: missing required meta-data: url

warning: check: missing meta-data: either (author and author_email) or (maintainer and maintainer_email) must be supplied

creating mypkg-1
creating mypkg-1\mypkg.egg-info
copying files to mypkg-1...
copying setup.py -> mypkg-1
copying mypkg.egg-info\PKG-INFO -> mypkg-1\mypkg.egg-info
copying mypkg.egg-info\SOURCES.txt -> mypkg-1\mypkg.egg-info
copying mypkg.egg-info\dependency_links.txt -> mypkg-1\mypkg.egg-info
copying mypkg.egg-info\top_level.txt -> mypkg-1\mypkg.egg-info
Writing mypkg-1\setup.cfg
creating c:\Users\jaraco\dist
Creating tar archive
removing 'mypkg-1' (and everything under it)
PS C:\Users\jaraco\m\setuptools-1185> py -m tarfile -l C:\users\jaraco\dist\mypkg-1.tar.gz
mypkg-1/
mypkg-1/PKG-INFO
mypkg-1/mypkg.egg-info/
mypkg-1/mypkg.egg-info/PKG-INFO
mypkg-1/mypkg.egg-info/SOURCES.txt
mypkg-1/mypkg.egg-info/top_level.txt
mypkg-1/mypkg.egg-info/dependency_links.txt
mypkg-1/setup.py
mypkg-1/setup.cfg

Even on Python 2 with distutils:
PS C:\Users\jaraco\m\setuptools-1185> cat .\setup-distutils.py
__import__('distutils.core').core.setup(name='mypkg', version='1')
PS C:\Users\jaraco\m\setuptools-1185> py -2 setup-distutils.py sdist --dist-dir=c:\users\jaraco\dist --formats=gztar
running sdist
running check
warning: check: missing required meta-data: url

warning: check: missing meta-data: either (author and author_email) or (maintainer and maintainer_email) must be supplied

warning: sdist: manifest template 'MANIFEST.in' does not exist (using default file list)

warning: sdist: standard file not found: should have one of README, README.txt

writing manifest file 'MANIFEST'
creating mypkg-1
copying files to mypkg-1...
copying setup-distutils.py -> mypkg-1
Creating tar archive
removing 'mypkg-1' (and everything under it)
PS C:\Users\jaraco\m\setuptools-1185> py -m tarfile -l C:\users\jaraco\dist\mypkg-1.tar.gz
mypkg-1/
mypkg-1/PKG-INFO
mypkg-1/setuptools-distutils.py

Whatever is happening in your environment isn't happening in mine. I suspect you either have an old version of setuptools or Python that has a bug that's since been fixed.
If you can find a way to replicate the issue with the latest Python and setuptools, please try with just distutils and report back here.
For now I'm going to close this ticket, but I'll certainly re-open if the issue can be replicated.

Still a problem. Don't use py -m tarfile to test. Just unzip it with 7zip or anything else.
I don't want to provide my datastructure to others

Kaiser reported more details in the duplicate ticket:

Do NOT test the tar.gz with "python -m tarfile", as this unpacks the tar.gz at once, and therefore showing the correct content. To reproduce, unpack the tar.gz file with 7zip. The "tar" archive contains the correct content. But the "gz" archive provides the full local path.

I also had a question I'd like to see answered:

Do I understand correctly that there is no undesirable user-facing behavior, that the only problem is the leaking of local paths in the gzip file? I do agree it would be nice not to leak that information.

Here's where the tarfile gets created. It doesn't do anything special with filenames. It just calls TarFile.add.
Can you supply some test that runs on Python that illustrates the undesirable behavior? I'm not even sure it's possible using the Python APIs to affect the name that appears in 7-Zip.

This is issue of tarfile. It incorrectly writes header for GZIP compression when user gives path with directories as name to TarFile.add. I created an issue at b.p.o. https://bugs.python.org/issue41316 and fixed this by PR https://github.com/python/cpython/pull/21511

I also stumbled upon this bug when building using python -m pep517.build . I assume the pep517 package  uses dist-dir somewhere internally.
Would be great if this could be merged soon because it limits the usefulness of pep517 on windows platforms.

My fix for the tarfile module is included in Python 3.8.7 and 3.9.1. This issue can be closed.

Well done. Thanks Artem!

Setuptools can still help by making sure that the fix is included in pypa/distutils and merged with this project. Indeed, that will be necessary to avoid a regression for users using SETUPTOOLS_USE_DISTUTILS=local or future versions that rely on adopted distutils exclusively.

On further examination, I see that the fix is in tarfile and not distutils, so the previous comment is incorrect. The only option is to use an updated Python or for someone to backport tarfile.


SliceQueryFilter can fetch more data than needed

Slice queries currently fetch more data then necessary, when there is only one column not part of the primary key. Specifically, SliceQueryFilter does not stop reading until it has seen limit + 1 live cells, even though in the case we can stop after seeing limit live cells.
We have a use case where we use wide rows to implement versioning, by including a timestamp as part of the primary key. Every once in a while, we "garbage collect" old versions by deleting them. This results in a single column containing the latest version, followed by many tombstones.
We use a LIMIT 1 query to select the latest version (which is the first column in the row). However, because SliceQueryFilter does not stop until it has seen limit + 1 live cells, we have to read all the tombstones following the single live cell. Furthermore, if these tombstones are covering data in other sstables, we have to read all the corresponding data when merging the sstable iterators. This can be a massive performance hit, and is unexpectedly caused by deleting data.
This patch allows the ColumnCounter implementation to decide when it has seen enough cells. For counters that don't require grouping, we can stop immediately after finding the first cell.

This is without corresponding ticket, targeting unsupported 2.2 and without any progress for 5 years. I am closing this.


Review GPG touch-points with GitRepository

Review the current state ahead of Bootstrap GA, including:

[ ] Signing verification

[ ] Documentation
[ ] Implementation
[ ] Test coverage

[ ] Signing commits

[ ] Documentation
[ ] Implementation
[ ] Test coverage

SSH Key signing is not yet supported. As part of the review above we should consider whether the current implementation for signing and verification are extensible enough to enable the support of SSH Key signing. Implementing SSH Key signing is not part of the scope within the milestone of this issue.

GitOps GA (as we have called it lately) has been reached so I'm moving this out of the "Bootstrap GA" milestone and into GA. We might need to revisit the GA milestone and what it should encompass.


Switch to rustfmt-nightly?

Since our crate generation process works with stable, we're stuck with an older version of rustfmt.  The maintained version, rustfmt-nightly, requires nightly for now.
While I'm still solid on my stance that published Rusoto crates should work on stable, let's see if switching crate generation to nightly gets us better formatting performance.

I have related changes in my async PR, I could pick this up!

I've thought about this a bit, and where it would probably get tricky is CI. On Travis we'd need to have both nightly and stable available so that we can build the generator with nightly, and then build the generated crates using stable.


Is it possible to store "Clients" on database using IDS4?

I want to store Clients on database. Can I do that with IDS4?
Thanks in advance

http://docs.identityserver.io/en/release/quickstarts/8_entity_framework.html

@SIkebe Thanks for the answer. I'm looking for another solution, without EF. Solutions for micro ORMs

Read the docs: http://docs.identityserver.io/en/release/topics/clients.html

Thank you, @brockallen . This page helped me to understand what I want and what can I do for that. And for those in future who will seek "autocreate" (DB table) functionality for micro ORMs. There is no way to do that.
You must...

Create DB Tables ( http://docs.identityserver.io/en/release/topics/clients.html)  Find required fields here.
Create "GetClientById" Stored Procedure
Implement IClientStore
And finally in Startup.cs Use AddClientStore instead of AddInMemoryClients

Am I right ?

That could be one way to go about it.


Bug fix for locating assets from scripts.

Issue #, if available: B9-2430
Description of changes: Changed the way the script locates assets by using the rospkg library to locate the install directory for a package instead of trying to use the location of the python script and navigating relative to there.
Testing done: I was able to launch the application in AWS Robomaker and run the command rosrun voice_interaction_robot audio_input.py. When issuing commands from the script launched in this manner it was able to locate the asset files.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Does this also work when running the built but not bundled version in the B9 IDE?

Yes, it does. I ran the commands you provided in the RoboMaker C9 editor across two separate consoles it saw logs from the voice_interaction.launch console indicating it was receiving commands from the audio_input.py console.


71 implement copy methods

This feature branch is not complete yet, but I implemented some tests which coud come in handy for resolving issue #93, so I am making these available.  See test_unsetSingletonProperty and test_unsetListProperty in test_property.py.

Please note in the description which issue(s) this pull request will resolve.


Modified Function_Direct_movement to use kinematic-body collision

Modified Function_Direct_movement to use kinematic-body collision and slope measurement testing rather than ray-cast tail to detect if the player is on the ground.
In addition a new drag coefficient has been added for when the player is in the air. This allows for more natural running off platforms.
This change resolves #60.

This looks like a nice improvement on the logic. I want to test it out but will likely merge it this week, thanks for the help Malcolm. Don't forget to add yourself to the CONTRIBUTORS.md file and add an entry in the CHANGES.MD file

I spent the weekend trying this out in a game-jam to test out the mechanics. The biggest take-away was the need for a system where the player mechanics can change in different areas - for example:

The player steps onto ice and the ground-traction wants to drop to near-zero
The player steps onto soft ground and the jump mechanic wants to be limited or disabled
The player flies into a water-spout and the wind mechanic wants to increase its drag to pull the player along

I hacked something 'inelegant' for the jam, but a cleaner solution is to attach movement-modifier nodes to the ground objects, or to the wind areas. This would allow for setting overriding properties without having to 'scriptify' the object to contain the parameters.

This now includes the GroundPhysics node which can be attached to a ground object the player would walk along, and allows overriding of physical properties such as lowering traction to simulate ice, or limit/disable jumping.
I've uploaded a video to https://youtu.be/3uLxZ4BIR3U with a link to a demo project showing the capabilities.

I think its time we start moving to merging this before it becomes a monster :)
Couple of things, I noticed that GroundPhysicsSettings needs to become a tool script because it is used in other tool scripts and that is throwing errors in the editor and the property inspector stops working.
Then we need to make a decision on whether we're going to keep the exports for nodes.  Might do this in a separate PR so people can give some feedback on it and there are a few places where we need to make the logic somewhat more intelligent, especially for selecting the camera node
Finally we need to squash all the commits before merging :)


Refactor miner into it's own object

Currently the "miner" is just a function. This means you cannot stop/start or reference a miner.
The current miner will write an opr per thread, which is fine for dev, but in production we only want to write the best opr.

Since each mining routine has a unique OPR, you want to submit all of them, up to 10 per directory block to maximize the potential payout. Submitting more than 10 seems unnecessary, so if you start more miners than that it should submit the best ten.

Yea, my first step was to separate miners into their own objects, my next step is to create an aggregator that only submits the best X.
I will make another issue to do that aggregation. This to me was a necessary step to support that better

Addressing Who's comment -> https://github.com/pegnet/pegnet/issues/126


View in API & Edit from Actions drop-down don't work

Rancher Versions: v1.4.0-rc8
Steps to Reproduce:

Create a secret
Select that secret
Under Actions drop-down try to select View in API or Edit

Results: Nothing happens.  Error is console - Uncaught TypeError: this.get(...)[e] is not a function

This is the same as https://github.com/rancher/rancher/issues/7787 , actions that apply only to a single resource don't work.

Version - master 2/23
This is still broken

@tfiduccia View in Api and Delete actions are working, edit has been removed. According to the schema secrets name fields are not editable.

Version - 6/12 (2.0 alpha)
Verified fixed


BigQuery project reversion in 0.19.1

Describe the bug
0.19.1 reverts the behavior around whether a database / project is required in profiles.yml.
For example:
foo:
  target: user
  outputs:
    user:
      type: bigquery
      method: oauth
      dataset: max
      timeout_seconds: 3600
      threads: 24
      # project: x

...fails with
Encountered an error:
Field "database" of type typing.Union[str, NoneType] is missing in dbt.adapters.bigquery.connections.BigQueryCredentials instance

Un-commenting project above works.
Expected behavior
As above, which worked in 0.19.0
System information
Which database are you using dbt with?

[ ] postgres
[ ] redshift
[x] bigquery
[ ] snowflake
[ ] other (specify: ____________)

The output of dbt --version:
installed version: 0.19.1
   latest version: 0.19.1

Up to date!

Plugins:
  - bigquery: 0.19.1
  - snowflake: 0.19.1
  - redshift: 0.19.1
  - postgres: 0.19.1

The operating system you're using:
MacOS
The output of python --version:
3.8
Additional context
Add any other context about the problem here.

@max-sixty You're right—I'm sorry I didn't catch this during the v0.19.1 testing process.
Let's figure out a fix for this, and a way to add an automated test for this—even if we can't fully integration-test it (since the integration tests run via service account)—to ensure that this doesn't happen again in a future version.

So this still works:
my-bigquery:
  outputs:
    oauth:
      type: bigquery
      method: oauth
      project: "{{ 'None' | as_native }}"
      dataset: dbt_jcohen
  target: oauth

The project field is indeed allowed to be None, and when it is, dbt will use the gcloud-configured default project (per the work in https://github.com/fishtown-analytics/dbt/pull/2908). The issue is when project is missing entirely, it raises this error:
Field "database" of type typing.Union[str, NoneType] is missing in dbt.adapters.bigquery.connections.BigQueryCredentials instance

The logic to set the project when not provided relied on a hook when creating the credential object that worked well when serializing data before we introduced mashumaro (#2862). mashumaro provides the same hooks, but are named differently.
I added a test to check to cover this case and a quick fix here, it still needs some polish -> https://github.com/fishtown-analytics/dbt/compare/0.19.latest...fix/bigquery-no-project

@kwigley Someone in Slack just saw the same error for their Snowflake profile when authenticator is excluded:
Field "authenticator" of type typing.Union[str, NoneType] is missing in dbt.adapters.snowflake.connections.SnowflakeCredentials instance

Here's the relevant hook:
https://github.com/fishtown-analytics/dbt/blob/cee0bfbfa2596520032b766fd1027fe748777c75/plugins/snowflake/dbt/adapters/snowflake/connections.py#L45-L54
Essentially, it seems like we should find all the places in the codebase that call __post_init__ (8 by my count) and check to see if they should be swapped out for __pre_deserialize__.

Hey @max-sixty, we're including a fix for this in v0.19.2, for which we just cut a release candidate. We've been able to add a test for this, and it worked locally for me, but just to be triple sure—any chance you could test locally and confirm that it resolves the regression?
pip install --upgrade 0.19.2rc1
# or
brew install<EMAIL_ADDRESS>

More than happy to test but are you sure that's right re pip?
❯ pip install --upgrade 0.19.2rc1
ERROR: Could not find a version that satisfies the requirement 0.19.2rc1
ERROR: No matching distribution found for 0.19.2rc1
WARNING: You are using pip version 21.0.1; however, version 21.1 is available.

❯ pip install --upgrade 0.19.2-rc1
ERROR: Could not find a version that satisfies the requirement 0.19.2-rc1
ERROR: No matching distribution found for 0.19.2-rc1
WARNING: You are using pip version 21.0.1; however, version 21.1 is available.

@max-sixty Sorry, silly typo on my part! Just edited

@jtcohen6 sorry, not sure how I copy & pasted so blindly!
This works with 0.19.2-rc1, thanks for fixing!


Can I add private_ranges?

Is it possible to make a configuration that combines cloudflare, dns cloudflared, and private_ranges?
trusted_proxies combine { 			cloudflare 			dns cloudflared 			private_ranges 		}
When I attempt this configuration, I get "caddy module not registered: http.ip_sources.private_ranges" in the logs.

private_ranges is not actually an IP range module, instead it's a token that happens to have a special meaning to a few built-in modules, including the static IP range module:
trusted_proxies combine {
	cloudflare
	dns cloudflared
	static private_ranges
}

I've also added this section to the README:
This Caddy documentation page lists all known modules that should theoretically work as sub-directives of this one, though not all of those have been tested in that configuration.


MAVSDK serial server errors on Windows

Hello,
We are using a LattePanda running Windows IOT with a USB to serial adapter to send messages to a PixHawk 4.  The connection works as expected for awhile and then it will continuously display the following message:
[04:25:57|Error] ReadFile failure: Access is denied.
 (D:\a\MAVSDK\MAVSDK\src\mavsdk\core\serial_connection.cpp:312)

as shown in this image:

Can anyone suggest what might be going wrong or what we should be checking?
Thank you

It looks like the user doesn't have permission to the serial port.
Maybe something else is using it?
https://knowledge.ni.com/KnowledgeArticleDetails?id=kA03q000000YGw9CAG&l=en-US


SOMETHING UNEXPECTED HAS HAPPENED, PLEASE TRY AGAIN.

I am getting this error when i am try to login into application
"SOMETHING UNEXPECTED HAS HAPPENED, PLEASE TRY AGAIN."

@fike @fabaff @anthturner @otaviojava

Manage how to solve? same problem here

same problem here. i'm using helm to try to deploy it on OCP 4.14


grad-checkpoint makes trained tokens increase gradually

After using --grad-checkpoint, the trained tokens increase gradually and reach the size of the whole dataset at the last iteration, while not using it would have the trained tokens in each iteration always be the same of the size of the dataset.
Why?

I'm not understanding your question. Trained tokens should be going up in all cases because its an sum over the total number of tokens trained on so far. I don't think you should see a difference there in terms of total tokens so it's possible there is a bug.
Could you share the command you ran / output you were seeing so we can reproduce that?

Closing as inactive. If there was an issue here please comment and we can reopen.


ISO core standard compliance of Tau Prolog

AZ-Prolog is not ISO core standard compatible.
There is some problem with the semantics of
if-then-else. You can try yourself:

/* test code, if-then-else */

betw(L, H, X) :-
   L =< H,
   betw2(L, H, X).

betw2(L, H, X) :-
   (  L = H -> !; true),
   X = L.
betw2(L, H, X) :-
   Y is L+1,
   betw2(Y, H, X).

Now run this code in SWI-Prolog, which
has correct if-then-else:
    Welcome to SWI-Prolog (threaded, 64 bits, version 7.7.1)
    SWI-Prolog comes with ABSOLUTELY NO WARRANTY. This is free software.

    ?- betw(1,3,X).
    X = 1
    X = 2
    X = 3.

Now run it in Tau Prolog, it will
not work, something is wrong:

The ISO core standard defines a set of control constructs, which
should be transparent to the cut in the right hand side of the (->)/2
in the example. There are more such examples, even without when
embedded into (;)/2. Like for example
    (fail; true -> !)
should also do a cut lexically.


Adding a few more alignment widgets

Been working on a project using libvaxis and made some functions to make child windows aligned to each corner of the window.
bottomRight sample:
pub fn bottomRight(parent: Window, cols: usize, rows: usize) Window {
    const y_off = parent.height -| rows;
    const x_off = parent.width -| cols;
    return parent.child(.{
        .x_off = x_off,
        .y_off = y_off,
        .width = .{ .limit = cols },
        .height = .{ .limit = rows }
    });
}

Was wondering if I could make a PR adding them to the alignment widget? Optionally I can also create an example that uses them.

A PR for this would be great. No need for an example though, it's usage is
pretty obvious.
Thanks!
--
Tim

Fixed in 7df8ca6


[SPARK-11959] [SPARK-15484] [Doc] [ML] Document WLS and IRLS

What changes were proposed in this pull request?

Document WeightedLeastSquares(normal equation) and IterativelyReweightedLeastSquares.
Copy L-BFGS documents from spark.mllib to spark.ml.

Due to the session Optimization of linear methods is used for developers, I think we should provide the brief introduction of the optimization method, necessary references and how it implements in Spark. It's not necessary to paste all mathematical formula and derivation here. If developers/users want to learn more, they can track reference.
How was this patch tested?
Document update, no tests.

Test build #59128 has started for PR 13262 at commit 47107b2.

@yanboliang lgtm except for a few phrasing issues.

Test build #59128 has finished for PR 13262 at commit 47107b2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59128/
Test PASSed.

@BenFradet Thanks for your comments, updated.

Test build #59129 has started for PR 13262 at commit a9cbf55.

Test build #59129 has finished for PR 13262 at commit a9cbf55.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59129/
Test PASSed.

Taking a final look

Done with pass

Test build #59198 has started for PR 13262 at commit 7f80d78.

@jkbradley Thanks for your comments. I think most of the audiences to the optimization session are developers and expert users, so I linked both Wikipedia docs and source code to the corresponding concept. Any more comments, please feel free to let me know.

Test build #59198 has finished for PR 13262 at commit 7f80d78.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59198/
Test PASSed.

@yanboliang Thanks for the updates.  I responded above about a tiny fix.

Test build #59270 has started for PR 13262 at commit 2bc030c.

Test build #59271 has started for PR 13262 at commit 1364fc7.

@sethah @jkbradley Thanks for your comments! I addressed most of the comments and responded inline.

Test build #59270 has finished for PR 13262 at commit 2bc030c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59270/
Test PASSed.

Test build #59271 has finished for PR 13262 at commit 1364fc7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59271/
Test PASSed.

Test build #59381 has started for PR 13262 at commit 23f1d7b.

Test build #59381 has finished for PR 13262 at commit 23f1d7b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59381/
Test PASSed.

Should we point the section in MLlib to the section here now? Otherwise we leave some text that is duplicated verbatim in the user guides.
One other minor comment and this LGTM.

I think it's OK to leave the duplicate text in the MLlib guide.  It will just sit there unchanging and should not require extra effort to maintain.

LGTM
Merging with master and branch-2.0
Thanks @yanboliang @BenFradet @sethah !


dependency resolution failiure with latest mist and wisp

when adding cors_builder to a new wisp project an error occurs.
Unable to find compatible versions for the version constraints in your
gleam.toml. The conflicting packages are:

mist
server // my project
wisp
cors_builder

I think you already know about this but figured i might just post here.

Hi! Thanks for raising this. Could you indicate the versions you're using and your gleam version? 🙂

In the project that i am using right know, the versions kinda resolved themselves, but the error can be reproduced by creating a new project, adding wisp and then trying to add cors_builder.
[dependencies]
gleam_stdlib = ">= 0.34.0 and < 2.0.0"
wisp = ">= 1.1.0 and < 2.0.0"
❯ gleam add cors_builder
Resolving versions
error: Dependency resolution failed
An error occurred while determining what dependency packages and
versions should be downloaded.
The error from the version resolver library was:
Unable to find compatible versions for the version constraints in your
gleam.toml. The conflicting packages are:

cors_builder
mist
server

gleam version: gleam 1.4.1

Thanks! Fixed :)


Get ENVS from Doppler for deployment

Support to local_l2, arbitrum, polygon
Logic - thorough check (from everybody doing review)
Summary
Easily deploy to any chain using doppler configuration.
Example:
./stack chain-deploy dev_personal
See dev_personal configuration under chain project in doppler
This enhancement should not effect any existing workflows.

In general comment, it would be nice to only rely on the admin private key when deploying if we can. It reduces the number of keys we need to configure in Doppler and it helps us to reduce key exposure where we deploy.

Yes. This is the case now. The other keys are hardcoded. They are known private keys. Those accounts will have the funds stolen if we don't generate new keys for them. We need to discuss how those keys are generated for production accounts, but this is independent of this pull request. I believe the deployment process funds other accounts from admin account.

I believe the deployment process funds other accounts from admin account.

Yes, that is my understanding as well.

Yes. This is the case now. The other keys are hardcoded. They are known private keys. Those accounts will have the funds stolen if we don't generate new keys for them. We need to discuss how those keys are generated for production accounts, but this is independent of this pull request.

Agreed we need to consider a better mechanism for handling private keys in production. I think we can avoid being concerned with the non-admin private keys in this deploy script by using getAccount('admin').privateKey instead of PRIVATE_KEYS and associated mechanisms.


nested transaction support in sqlite

sqlite doesn't follow the standard when it comes
to nested transactions and therefore needs special handling

replaced by https://github.com/SOCI/soci/pull/288


[BUG] Running the Get-PnPTenantSite -Detailed cmdlet does not display the actual value of keys

Reporting an Issue or Missing Feature
This is actually the same issue, that was/is present on the legacy module
https://github.com/pnp/PnP-PowerShell/issues/2596
https://github.com/pnp/PnP-PowerShell/issues/2598
Running Get-PnPTenantSite -Detailed gives wrong values for site property keys. When you run the command focused on a single site Get-PnPTenantSite -Identity https://... -Detailed, the results are correct.
Expected behavior
I would expect the Get-PnPTenantSite -Detailed command to show actual values of properties of all sites in scope.
Actual behavior
Instead the command seems to 'guess' at property values, so it is not clear that the returned values are actually incorrect. If the actual issue cannot be fixed I would prefer to have the command not output anything for properties like 'DefaultSharingLinkType' and 'DisableCompanyWideSharingLinks' (these are just examples, much more properties are returned incorrectly) as returning incorrect results is worse than returning nothing.
Steps to reproduce behavior
Just run the command without Identity parameter and compare output to the command with an Identity parameter.
What is the version of the Cmdlet module you are running?
1.8.0
Which operating system/environment are you running PnP PowerShell on?

[x] Windows
[x] Linux
[ ] MacOS
[ ] Azure Cloud Shell
[ ] Azure Functions
[ ] Other : please specify

Hello @SjoerdV and thank you for this report.
I was also going to open an issue about this as well.
I need to run this kind of filter :
$Sites = Get-PnPTenantSite -Detailed | Where-Object {
    ($_.DefaultLinkToExistingAccess -eq $false)
}

But i can't because, it's useless since the property "DefaultLinkToExistingAccess" return false for ALL sites in my tenant... While this is not the case.
As you said, if we run the command site by site, the result is correct at that time.
It's really disabling when you want to make a filter on all the sites in order to do reporting.
Is there a workaround in the meantime ? Without making a Get-PnPTenantSite -Detailed | Foreach-Object {Get-PnPTenantSite -Identity $_} ?

I think it that's the because of the SharePoint REST/API bug : https://github.com/SharePoint/sp-dev-docs/issues/8012

I think it come from the SharePoint REST/API bug : https://github.com/SharePoint/sp-dev-docs/issues/8012

That's a great find! I sure hope someone in the PnP Team can forward this to the right MS team, when appropriate. On the other hand, maybe investing in the Graph API to deliver these properties might be a better bet IMHO.

I try using the PowerShell SDK or pure Graph API call, but currently I can't get the properties we are looking for.
Some docs if you want to try...
Graph API :

Search Sites
Get Site Settings (beta)

With PowerShell, you can use something like this to reproduce the API with the SDK :
Connect-MgGraph -Scopes Sites.Read.All, Sites.ReadWrite.All
Select-MgProfile -Name "beta"

$sites = Get-MgSite -Search "TEST"
$settings = Invoke-MgGraphRequest -Method GET -Uri "/beta/sites/$($sites[0].Id)/settings"

But, my conclusion currently is that Graph cannot give the properties we need, even in beta... I can only get "Language, TimeZone, URL...", not usefull in our case, sadly.

Yeah, having some property exposure 'parity' between the API's would be nice.
Same goes for the properties of a 'Team'. I really love the properties the EXOv2 cmdlet for Get-UnifiedGroup is pooping out, especially getting the Urls for all connected services (site, team, mailbox, calendar, etc). Can't have that with Graph at this point.

hi @SjoerdV / @PowerBugi - as you all rightly found out, the issue lies at the API level. Would request you to also raise a support ticket with Microsoft about. Unfortunately, we wont be able to do anything from our side here as we are simply consuming the response.
Once Microsoft fixes it, maybe via API or update of CSOM SDk, it will be automatically available here since we always use the latest CSOM SDK in our code.
Will close the issue here as we wont be able to fix it.
You have opened the issue at the correct location , sp-dev-docs, but for added measure would also suggest that you open a Microsoft ticket or a premium ticket if possible so that Product group is aware of this.

Submitted request via SharePoint's Feedback portal here: https://feedbackportal.microsoft.com/feedback/idea/92bcc9df-3582-ed11-a81b-6045bdaf6a9e


[MRG] Using recording date from file path instead of EDF header for TUH datasets

This PR modifies the TUH dataset class to update the raw.info['meas_date'] property with the recording date specified in the file path, instead of the one from the EDF header. This is helpful because some files seem to have corrupted recording dates.
For instance, for TUAB, there are 79 mismatches between the EDF header date and the path-defined date, and 16 of those are visibly default values/errors (many start with 2000-01-01, or even 1899).

Great, thanks for fixing @hubertjb


ability to generate url but not copy file

Currently I am trying to create an isomorphic build using rollup. For the client build this module works perfectly however for the server build I only need it to generate the url (or inline the file if small enough), not do anything with files that are too large since the client side build already handles that.
Webpacks file-loader has this functionality via an 'emitFile' option.

1.2.0 published


New Terminal and Kill Terminal do not work as expected with Tmux setup

Testing #33274

Set up tmux as explained in https://medium.com/@joaomoreno/persistent-terminal-sessions-in-vs-code-8fc469ed6b41

With this set up, New terminal and Kill terminal commands are not working.
After clicking New terminal action, label of the terminal gets lost.

Maybe I'm doing something wrong but new-session doesn't work for me in Terminal.app or vscode:

/cc @joaomoreno

That's strange...
~ → tmux -V
tmux 2.5

Same version?

I was on 2.4

I can reproduce, I think what's happening is the terminal is launching and dying immediately as the session is already open? But this particular edge case isn't covered.
@joaomoreno can you repro this? Do you think it was always happening?

That was always happening on my setup; it's not a problem.
The only problem I see is what @sandy081 refers to in the end: that the terminal label becomes empty.

The label is pulled from the process via this function:
https://github.com/Tyriar/node-pty/blob/12caa78c871caa388b013ab9d2e327f2b0a3a76e/src/unix/pty.cc#L507
Which incidentally was pulled in from tmux.
Going to close this out as I don't think this is particularly actionable and can maybe be fixed by tweaking the script?


added a customDomain parameter that enables to use tenants with custo…

…m domain set
This PR enables this library to work with auth0 tenants that use custom domains.
It is implemented in a backward compatible way.
The new parameter (customDomain) is optional. The region and account parameters will be ignored if it's set.

I modified the logic to use a new baseUrl method.
I also rebased it to the current master. Could you please check it again?

@smatyas I can merge the PR as soon as it's ok.

Thank you @smatyas


Message Canceling

We need to implement Message Canceling whereby a message already in our pipeline can be killed.

Hi @willsalz,
If its not implemented, i am happy to work on it. Please provide more information to start the development.

See the docs above.

Please guide me in where to start writing code?Any specific file?
Any pointer or suggestion would be helpful in developing this task.

@junchaowu any pointers for @chandresh-pancholi? ^

@chandresh-pancholi  the requestRouter file probably the first place to look at. It is the place it processes the request and dispatch it to handlers.


Module Loading

Remove branch as whitelist is no longer optional.
Use for..in since prototype members are of no concern here.
Expect a function and not an object. For this initial change we'll have to sync this w/ Ocelot settings, thereafter we can make changes here/there w/o having to sync.

https://github.com/umass-compsci220/ocelot-settings/pull/1 👀

Actually, this commit is not yet ready. It will be ready when lib220.ts is deleted from this branch (and tests that use lib220 work).

I assume lib220 tests are moved into ocelot-settings.
Anyway, this is great! Merge away! (Both this and Ocelot)

And for consistency, do redeploy this. (Though it should not have any effect.)


Problem caused by deterministic deployments when modifying only PRBProxyRegistry

Description
If we already have a set of contracts deployed to a chain, and we modify only the PRBProxyRegistry contract, we run into trouble. The PRBProxy and PRBProxyFactory contracts cannot be redeployed at other addresses, due to how the deterministic deployment proxy works.
Imagine we pass a salt, say 0x01, to the deployFor function in PRBProxyRegistry v1.0.0. The contract creation will go through. Now we upgrade the registry to a v1.0.1, which is pointed to the same PRBProxyFactory contract.
If we pass the same 0x01 salt to the v1.0.1 contract, the contract creation will revert. The clone function will revert with a PRBProxyFactory__CloneFailed custom error, because the address of the factory contract is the same and the salt is the same.
The good news is that this won't likely affect any production errors. We don't expect to make frequent upgrades (if any) after we ship to Ethereum Mainnet, Polygon, etc.
Possible Solution
I can't think of anything better than forcefully making a change to PRBProxy or PRBProxyFactory as well, such that the factory starts afresh too when the registry is upgraded.
This is not great, but the change can be minor enough so that it is redundant. E.g. a change in the NatSpec comments, or a slight tweak of the number of times the compiler optimizer runs.

Link to a transaction which failed because of this problem:
https://rinkeby.etherscan.io/tx/0xb3e52f52a329c6406743d864df4bc84d29df13107c053cce363554121e8e1990

Marking this as "stale" since I don't think that this issue applies now since users cannot pass custom salts anymore.


Empty records in redis

All,
Let me know if I should post this elsewhere (could not find a user group).  I have been having an issue with items showing up in the job folder with no data.  Kue is showing no active jobs, however, these "empty" jobs keep building up.. here is an example:
http://imgur.com/cvCTU0Z
Any thoughts what could be causing this?

from your picture it seems this should be related to #559
Would you please tell me which version of kue are you on?

Running..  "version": "0.8.12",
In my code I am running large numbers of jobs (~10-20k) and I am doing a very simple queue then process then done, nothing out of the ordinary.  After running about 20k Items I am left with about 20 of these hashkey records.
Is there a way to force remove these?

this should be solved when you move to 0.9.0 (you should check changes before you upgrade however)

I can provide a patch for 0.8 branch if you are sticky

closing this as a duplicate, please follow #559


CS50

was able to my coding but it won't let me compile it as it kept saying that my files are not found
Version: 1.74.3
Commit: 97dec172d3256f8ca4bfb2143f3f76b503ca0534
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.1 Safari/605.1.15
Embedder: codespaces

/question

We closed this issue because it is a question about using VS Code rather than an issue or feature request. Please search for help on StackOverflow, where the community has already answered thousands of similar questions. You may find their guide on asking a new question helpful if your question has not already been asked. See also our issue reporting guidelines.
Happy Coding!


Bug: Create Consumable - Quick Alchemy option creating incorrect amount of consumables

Foundry v12 Build 331
PF2 6.4.1
For an alchemist, their known formulas under the crafint tab has an option to "add this formula to one or more crafting entries". When this is clicked, 2 items are added instead of 1 as in the quick alchemy rules.

No way to lower this to 1 as 2 seems the minimum.

Duplicate of #15647


Convert bad consecutive mi's into a single mi

People are sloppy and will write something like $Velocity = Distance/Time$. Even those this looks wrong (italics), people don't fix it. This will turn into sequence of <mi>s, one for each letter. That means it won't speak correctly ("V e l o c i t y equals ...). The braille will likely be correct though.
One option is to run a spell checker on every sequence of three of more chars. There are at least two Rust packages for spell checking. They require a dictionary for every supported language, so that's pretty expensive memory-wise.
The other option would be to just assume any sequence of single char <mi>s over three characters long should have been a word. Except for some geometric object decriptions (e.g rectangle ABCD), that's probably very safe. Even a sequence of three is probably safe if a few special cases are checked. E.g, a consecutive sequence of letters ($xyz$, $abc$), all caps ($AOB$), and no vowels. There might be a few other things to check.

The solution is very English-centric. For example, the vowel list it checks are "aeiouy". It doesn't check accented vowells nor does it check other alphabets.


Show time until next nap in local client interface

One of the main things I'd like to see in the local client interface (Possibly in the 'monitoring control' section?), is a countdown-timer of how long it takes before the next nap will start, for two reasons:

it makes it easy to check if the app is configured properly, and the alarms/reminders will sound at the proper times.
The couple of hours after a missed nap and midnight core are EXTREMELY hard to keep awake in. Being able to count them down (even when your mental state is very unfocused) would be really nice.

:slightly_smiling_face:

Good idea, I'll look into adding this

This works very well. I think this issue can be closed, since it has been incorporated in v0.12 :heart_eyes: .


Date Picker in Web Components - Barebones

[ ] #972
[x] #977
[ ] #978
[ ] #973

@enowak1031 This needs to be broken down into more minor issues, but I need to start working on this to get a clear idea of how it can be divided.
Also increased the story points to 8.

@msankaran0712 Should we delete this issue?


Work with other tools

add support with other tools apart from sp flashtool

This doesn't support any specific tool, it just disables security...

This doesn't support any specific tool, it just disables security...


Add option for "self-payment" for fee collection

[ ] add a startup option to specify different fees
[ ] calculate what pay-to-self split would be based on total splits and set fee rate
[ ] if "name" is a self-payment, then just log to self-pays, but do not pay anything (by not paying, the prism node is collecting a fee and essentially paying to self)

This is currently implemented as the outlay_factor in prism v2


Problems encountered when running the 5MW model

HI，everyone
When I use openfast 3.5 and ROSCO 2.8, the following problem occurs:

The rotor speed is very high, what may be the reason
Best regards！

If I use turbulent wind, this is what happens


Add support for Cargo feature flags

Self explanatory. Allows passing feature flags to Cargo.
Blocked by #50

Thank you! ❤🔥


Avoid panics on login

Issue:

Problem

Log messages try to use a variable that may not be set if EnsureUser() call fails.
Solution

Use a variable is set ahead of time instead.
Testing

Engineering Testing
Manual Testing

Automated Testing

Test types added/modified:

QA Testing Considerations

Regressions Considerations

TODO
Existing / newly added automated tests that provide evidence there are no regressions:

TODO

#46894


KONGA 0.14.1 can't add RESPONSE RATELIMITING

{"limits":"expected a map"}

@phamkhang , thanks for the feedback. I'll check it out and keep you posted.


Problem: LDAP Result Code 32 "No Such Object"

Issue
Hi
I'm using Semaphore with docker, version is v2.10.22.
I'm able to connect with admin account, run playbook etc...
I want to configure ldap in order to connect with Active Directory accounts.
I have an active directory with all users in "Users" organizational unit and I have also created a group called "Semaphore" with one account inside.
Here the parameters in config.json (because environment vars in docker compose don't work for ldap settings) :
    "ldap_enable": true,
       "ldap_binddn": "CN=Svc Semaphore,OU=ServiceAccounts,DC=fra,DC=example,DC=com",
       "ldap_bindpassword": "secret",
       "ldap_server": "ldap.fra.example.com:636",
       "ldap_searchdn": "OU=Users,DC=fra,DC=example,DC=com",
       "ldap_searchfilter": "(&(sAMAccountName=%s)(memberOf=cn=Semaphore,cn=Users,dc=fra,dc=example,dc=com)",
       "ldap_mappings": {
               "dn": "distinguishedName",
               "mail": "mail",
               "uid": "sAMAccountName",
               "cn": "cn"
       },

Then, on firefox, when I put my login, I got an error 500 and in docker logs, I have
level=warning msg="LDAP Result Code 32 \"No Such Object\": 0000208D: NameErr: DSID-0310028D, problem 2001 (NO_OBJECT), data 0, best match of:\n\t'DC=fra,DC=example,DC=com'\n\x00"
When I test inside container with ldapsearch, it works, for example :
ldapsearch -H ldaps://ldap.fra.example.com -d 1 -x -W -D "CN=Svc Semaphore,OU=ServiceAccounts,DC=fra,DC=example,DC=com" -b "CN=Semaphore,CN=Users,DC=fra,DC=example,DC=com" "(sAMAccountName=<account>)"
The only difference between config.json and ldapsearch is the "ldap_searchdn" field, I have to put
"ldap_searchdn": "OU=Users,DC=fra,DC=example,DC=com",
If I set "ldap_searchdn": "CN=Users,DC=fra,DC=example,DC=com", nothing appears in logs and on my browser, I got incorrect password.
And with ldapsearch, if I run the command on "CN=Users,DC=fra,DC=example,DC=com", I got an error.
I have also tested with :
 "ldap_searchfilter": "(uid=*)"
 "ldap_searchfilter": "(sAMAccountName=*)"
 "ldap_searchfilter": "(uid=%s)"
 "ldap_searchfilter": "(sAMAccountName=%s)"
"ldap_searchfilter": "(&(sAMAccountName=%s)(memberOf=cn=Semaphore,OU=Groups,dc=fra,dc=example,dc=com)",

and also
"ldap_searchdn": "OU=Users,DC=fra,DC=example,DC=com", ==> LDAP Result Code 32 / error 500
"ldap_searchdn": "DC=fra,DC=example,DC=com", => incorrect password on brower, nothing in logs
"ldap_searchdn": "CN=Users,DC=fra,DC=example,DC=com" => incorrect password on brower, nothing in logs

So what is the correct parameter to set if I want to connect with my login and ideally, restrict the connection to an AD group ?
Thanks for your help.
Impact
Configuration
Installation method
Docker
Database
MySQL
Browser
Firefox
Semaphore Version
v2.10.22-e44910d-1721658561
Ansible Version
No response
Logs & errors
No response
Manual installation - system information
No response
Configuration
No response
Additional information
No response

Hey mate,
When you are using LDAPS you will have errors if you don't have this in your config file:
"ldap_needtls": true,
If you're still having issues with LDAPS with that in your config file, might be worth going back a step and making sure that you are having connectivity over LDAP.

Hi, with "ldap_needtls": true or "ldap_needtls": false, I have the same result.


Converting to Geotiff

namelist_wrf.txt
Hi,
I am encountering the following error when generating the Geotiff file from the wrfout file for a single time (By making the history interval to 1 in namelist.input while running WRF). However, I am able to generate geotiff for wrfout with all time steps together.
Converting to Geotiff. Please wait ...
fatal:Subscript out of range, error in subscript #0
fatal:An error occurred reading all_steps
fatal:["Execute.c":8637]:Execute: Error occurred at or near line 21 in file /home/raghu/PostWRF/modules/geotiff.ncl
cat: /home/raghu/PostWRF/modules/geo_eq_ok.txt: No such file or directory
Could you please help me in fixing the issue.

Hi. Thank you for reporting this problem.
It seems there is a problem in the source code. I need a couple of days to work on that and fix it.

Please pull the updates, or clone the updated software and try your task again, and report the results. I want to be sure that your problem is solved.

Hi, Thank you for the update and is working fine with Geotiff. However, facing a very similar issue with plotting other maps (Ex. contour maps and skew-T etc).

Yes. This was actually a bug in the software, when the WRF output has only one single time. The remaining tasks (contour maps, cross-section maps, ...) will be updated in a couple of days.
Thank you for the good first issue!
In case of any other problems, you can continue commenting on this issue, or making new ones.

Thanks for the update. Will get back to you if I have  any issues.
Thanks

Hi,
Thank you very much for your help in fixing the previous issue. However, I am looking to automatically process the hourly wrfout files from the same run (multiple files). I have tried with some scripts by looping but couldn't able to do a successful process.
Thanks and regards,
Raghu

Hi,
Thanks for the response. When I am executing the command as you mention, encounter the below error message.
raghu@elogin04:~/PostWRF-master> ./postwrf.sh wrfout_d01_2023-02-21_00:00:00,wrfout_d01_2023-02-21_01:00:00

=================  PostWRF (Version 1.1)  =====================
Run './postwrf.sh -h' to get help
In case of problems, please contact<EMAIL_ADDRESS>
  CONVERT TO GEOTIFF          CONVERT TO GEOTIFF

Specify Time_Step(s) Between The Images (Default=1):
Time_Step Has Been Set To 1
ls: cannot access '/home/raghu/PostWRF-master/postwrf_wrfout*': No such file or directory
basename: missing operand
Try 'basename --help' for more information.

Converting to Geotiff. Please wait ...
warning:NclOpenFile: cannot open file </home/raghu/PostWRF-master/outputs/postwrf_wrfout*>; No such file or directory
fatal:Subscript out of range, error in subscript #0
fatal:An error occurred reading fileatts
fatal:["Execute.c":8637]:Execute: Error occurred at or near line 15 in file read_wrfouts.ncl
cat: /home/raghu/PostWRF-master/modules/geo_eq_ok.txt: No such file or directory

Thanks and regards,
Raghu

What are the names of your WRF files?

My wrfout file naming is as follows:
wrfout_d01_2022_12_03-00:00:00
wrfout_d01_2022_12_03-01:00:00
wrfout_d01_2022_12_03-02:00:00
wrfout_d01_2022_12_03-03:00:00
.
.
.
.
wrfout_d01_2022_12_06-01:00:00
wrfout_d01_2022_12_06-02:00:00
wrfout_d01_2022_12_03-03:00:00

Please send me at least 2 consecutive files of that list.


Running poac run twice yields dependency not found

I was trying to run a basic boost example from the readme me. if I delete the poac out dir and the lock file, running poac run yields a success build. If I rerun the same command directly afterwards I get the following errror
I'm using a m2 Mac air with Ventura 13.4
poac run
   Compiling 1/1: hello_world v0.1.0 ("/Users/jared/dev/poac/hello_world")
FAILED: /Users/jared/dev/poac/hello_world/poac-out/debug/hello_world
g++ -std=c++20 src/main.cpp -o /Users/jared/dev/poac/hello_world/poac-out/debug/hello_world   -I/Users/jared/.cache/poac/extract/boost-bind-1.66.0/include
In file included from src/main.cpp:1:
In file included from /Users/jared/.cache/poac/extract/boost-bind-1.66.0/include/boost/bind.hpp:22:
/Users/jared/.cache/poac/extract/boost-bind-1.66.0/include/boost/bind/bind.hpp:24:10: fatal error: 'boost/config.hpp' file not found
#include <boost/config.hpp>
         ^~~~~~~~~~~~~~~~~~
1 error generated.
Error: failed to build package `hello_world`

Caused by:
    internal build system has been stopped with an error:
subcommand failed

directory
➜ tree
.
├── poac-out
│   └── debug
│       └── ninja.build
├── poac.lock
├── poac.toml
└── src
    └── main.cpp

My cpp file looks like so
#include <boost/bind.hpp>
#include <iostream>

int f(int a, int b) { return a + b; }

int main(int argc, char **argv) {
  std::cout << boost::bind(f, _1, _2)(30, 10) << std::endl;
}

my poac file looks like
[package]
name = "hello_world"
version = "0.1.0"
authors = []
edition = 2020

[dependencies]
"boost/bind" = ">=1.64.0 and <2.0.0"

Thank you for your great issue. Since I am currently quite busy, I will get this done when I have time.

This issue has been fixed upstream.


[WIP] Working on about page

Trying to link the about page at "..lab/about.html"
Then link the page inside an iframe inside about/plugin.ts

The dependencies (such as fullpage, etc.) should be pulled in from npm and imported, not included as source files.

This is where a template is found. If you want to influence where a template is located, changing this line is a good start: https://github.com/jupyter/jupyterlab/pull/230/files#diff-319b1c023b01f33238afa36efbf90594R48

@roshancvp Let's work on rebasing this PR on the morning.


Troubleshooting section of vscode extension on marketplace conflicts with output

On the marketplace it states that Java 8 or greater is needed. Once installed in vscode it states that version 8-14 is required. I'm running java 19.

@grabango-ttharp  this is fixed in newest release v3.0.0, thanks to the great job of @stevenh :)
Please can you confirm it works well for your case now ?

If yes, please rate the app -> https://marketplace.visualstudio.com/items?itemName=NicolasVuillamy.vscode-groovy-lint&ssr=false#review-details
If not, please reopen the issue and we'll check :)


updated-readme.md for #4

Hey @rrsingh11  can u add more info in README.md  and ss or some thing

Okay! I'll add more things.

Okay thanks, once done do let me know


logging config (0.6.0 release)

it seems logging setup not working when passing it in run() method
works only if passed on app init
Sanic(log_config=)
in prev release in run() also works

yes, passing log_config=None in run doesn't work, because log_config has been initialized already.


Math is not parsed properly when below expression

math:
$$x$$

TODO:
create issue at https://github.com/rhysd/pulldown-cmark


I want to create a new instance, how can i do, thanks.

I am a beginner. Now I want to build a new instance called "myinstance" , but I don't know what I should do . I need a tutorial to build a new instance, thank you very much.

Start here:
https://docs.oracle.com/database/121/

Use  ORACLE_SID variable in command line, when creating container
docker run -d -p 8080:8080 -p 1521:1521 -v /home/myuser/oradata:/u01/app/oracle -e ORACLE_SID=myinstance quay.io/maksymbilenko/oracle-12c


fix(@schematics/angular): Make manifest.json correct and consistent

To fix issues mentioned in https://github.com/angular/devkit/issues/775

Removed splash_pages from manifest.json
Changed display to fullscreen in manifest.json
Updated theme-color in index.html
Removed Description metatag from index.html (as it doesn't correlate with PWA)

@Brocco, with "display": "browser" the app cannot be "installed". Requred modes are standalone, fullscreen or minimal-ui (Chrome DevTools output error is a bit wrong because it doesn't list the last one). I believe minimal-ui is what we want - a trade-off: app is  installable, but with some UI. Will this work?
https://developer.mozilla.org/en-US/docs/Web/Manifest#display
Btw minimal-uis fallback is exactly browser

Commited with "display": "minimal-ui"


Rename Package

Rename Package to io.obswebsocket.client?

So we'd have a groupId of io.obswebsocket.client and artifactId of obsremotejava?
What if instead we had io.obswebsocket as groupId and javaclient as artifactId instead?

What if instead we had io.obswebsocket as groupId and javaclient as artifactId instead?
That was indeed the idea

Shall we close this and move to a discussion?


Reauthenticate from stored token when app is reloaded

You've also got a build failure because it's not passing ESLint.
> eslint --ext ".js" --ignore-pattern node_modules --quiet .

/var/lib/jenkins/jobs/mattermost-mobile-pr/workspace/src/github.com/mattermost/mattermost-mobile/src/components/select_server_view.js
  40:58  error  Identifier 'auth_token' is not in camel case  camelcase
  41:25  error  Identifier 'auth_token' is not in camel case  camelcase

✖ 2 problems (2 errors, 0 warnings)

Unless the data is coming from the server, we prefer to use camel case for all of our variable names

Closing this since it's going to conflict with the redux store changes and it has outstanding work to be done on it


narsil: 1.3.0-85-g68f1491ca -> 1.3.0-187-g96d6b3bbd

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for narsil is: Unofficial rewrite of Sil, a roguelike influenced by Angband
meta.homepage for narsil is: https://github.com/NickMcConnell/NarSil/
meta.changelog for narsil is: https://github.com/NickMcConnell/NarSil/releases/tag/1.3.0-187-g96d6b3bbd
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.3.0-187-g96d6b3bbd in filename of file in /nix/store/7dx320bj71m1shcr69fv6ncx6zja666c-narsil-1.3.0-187-g96d6b3bbd

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

narsil

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/7dx320bj71m1shcr69fv6ncx6zja666c-narsil-1.3.0-187-g96d6b3bbd \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A narsil https://github.com/r-ryantm/nixpkgs/archive/c06b6b13346053c9cc0a119a71600ba0a9d444fc.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/c06b6b13346053c9cc0a119a71600ba0a9d444fc#narsil

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/7dx320bj71m1shcr69fv6ncx6zja666c-narsil-1.3.0-187-g96d6b3bbd
ls -la /nix/store/7dx320bj71m1shcr69fv6ncx6zja666c-narsil-1.3.0-187-g96d6b3bbd/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

narsil

Maintainer pings
cc @nanotwerp @x123 for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Tested a run with the new binary on x86_64-linux with narsil -mgcu -- -n4 and seems to work great. :+1:
@NixOS/nixpkgs-merge-bot merge


:bug: old version referenced by k3d instructions

Describe the bug
https://docs.kubestellar.io/release-0.23.0/direct/deploy-on-k3d/ references 0.22 of KS
Steps To Reproduce

go to https://docs.kubestellar.io/release-0.23.0/direct/deploy-on-k3d/
observe 0.22 ks is referenced

not sure if other references are correct either.
Expected Behavior
0.23 doc should point to 0.23 ks components
Additional Context
No response

That doc says right up front in the introductory material:

This is a point-in-time statement that worked with KubeStellar release v0.22.0.

Maybe it could be worded more clearly. It is trying to say that that particular document is not about the latest release but rather an older one. It is trying to say that we do not intend to update that document with every release. That was the outcome of a discussion about testing, in which it was asserted with some vehemence that we would not have the capacity to do that much manual testing.

Ugg. What a mess. Close if you prefer. I don't know what else to do. This has become untenable.

I think that the re-org should remove the need for this file. In the meantime I will offer a PR to make the warning more explicit.

documentation no longer exists. closing


PK: RSA-PSS verification

Make RSA-PSS signature verification in the PK layer use PSA transparently when MBEDTLS_USE_PSA_CRYPTO is enabled and the requested parameters match what's expected by PSA_ALG_RSA_PSS.
In mbedtls_pk_verify_ext(), create a new code path that's guarded, at compile-time by MBEDTLS_USE_PSA_CRYPTO, and at run-time by whether the options match what PSA_ALG_RSA_PSS that uses psa_verify_hash() instead of mbedtls_rsa_rsassa_pss_verify_ext(). That is, the body of the if( type == MBEDTLS_PK_RSASSA_PSS ) should look like:
/* (common checks such as options != NULL) */
#if defined(MBEDTLS_USE_PSA_CRYPTO)
if( pss_opts->mgf1_hash_id == md_alg &&
    pss_opts->expected_salt_len == hash_len ) // see note 1 below
{
    /* (path using psa_verify_hash()) */
}
else
#endif
{
    /* (path using mbedtls_rsa_rsassa_pss_verify_ext() */
}

The path using mbedtls_rsa_rsassa_pss_verify_ext() remains the same as the existing code. On the path using psa_verify_hash() we'll need to create a temporary PSA public key of type PSA_ALG_RSA_PSS(hash_alg) with an appropriate policy. An example of this can be found in the MBEDTLS_USE_PSA_CRYPTO definition of ecdsa_verify_wrap() in pk_wrap.c.
Note 1: we may also want to check that hash_len is consistent with md_alg, and take the PSA path only if that's the case.
Note 2: the expected result of this task is that the call to mbedtls_pk_verify_ext() in ssl_tls13_generic.c takes the PSA path. We probably want to verify that with a debugger, a printf or whatever. No other testing is required, except ensuring all existing test keep passing.
Note 3: it is possible to reduce the level of nesting by restructuring mbedtls_pk_verify_ext() to have the non-RSA-PSS case first, which returns early, and then the PSS case no longer needs to be wrapped in an if statement.

Should we also redirect MBEDTLS_RSA_SALT_LEN_ANY via PSA_ALG_RSA_PSS_ANY_SALT to the PSA-using path?

Also, there's a bit of a problem with error translation:
    /* Mbed TLS distinguishes "invalid padding" from "valid padding but
     * the rest of the signature is invalid". This has little use in
     * practice and PSA doesn't report this distinction. */
    status = ( ret == MBEDTLS_ERR_RSA_INVALID_PADDING ) ?
             PSA_ERROR_INVALID_SIGNATURE :
             mbedtls_to_psa_error( ret );

This way, there are a couple of errors that can end up as PSA_ERROR_INVALID_SIGNATURE, and I couldn't find any good Mbed TLS equivalent to that... any ideas?

Should we also redirect MBEDTLS_RSA_SALT_LEN_ANY via PSA_ALG_RSA_PSS_ANY_SALT to the PSA-using path?

Yes, especially since this is the path that the X.509 code will need since in practice the X.509 world (when it uses PSS at all) often uses a salt length which is not the one PSA_ALG_RSA_PSS requires (see https://github.com/ARMmbed/mbedtls/issues/5277).

“Invalid signature” is a very specific error and we should translate it accurately. Unfortunately in mbedtls it's split between MBEDTLS_ERR_RSA_VERIFY_FAILED and MBEDTLS_ERR_ECP_VERIFY_FAILED. I don't have a good answer to that — create a MBEDTLS_ERR_PK_VERIFY_FAILED?

I think the situation would be better if PK_VERIFY_FAILED existed already, but it doesn't I'm no not sure creating it now is OK, perhaps people are already checking for the specific code.
We could also make the translation context-dependent: if doing an RSA operation, translate PSA_ERROR_INVALID_SIGNATURE to MBEDTLS_ERR_RSA_VERIFY_FAILED, otherwise to MBEDTLS_ERR_ECP_VERIFY_FAILED.

We could also make the translation context-dependent: if doing an RSA operation, translate PSA_ERROR_INVALID_SIGNATURE to MBEDTLS_ERR_RSA_VERIFY_FAILED, otherwise to MBEDTLS_ERR_ECP_VERIFY_FAILED.

I think we should do that, if we can, yes. But does mbedtls_pk_verify know the key type?

But does mbedtls_pk_verify know the key type?

I think it can if it needs to. But currently the translation happens in the wrappers in pk_wrap.c, where you obviously know the type because if you're in ecdsa_verify_wrap() clearly you're not dealing with RSA.

@mpg I was thinking of the opaque case.

I don't think we plan to support signature verification with opaque keys so far. Should we?
But even in that case, I think we can look fetch the key's attributes and recover its type. We'd just need to write code for it, it wouldn't come as naturally as the transparent case, but shouldn't be hard unless I'm missing something.

Why wouldn't we support pk_verify for opaque keys? It'll have to return something when the key type and algorithm are in the vendor range. But we don't need to worry about it now, this might be a post-4.0 thing anyway.

@mpg - do you have any suggestion on what form of verification would be most suitable for debugging and making sure that the code is called? What I've done is:
-gnutls-serv --http --disable-client-cert --debug=4 --x509certfile data_files/server2-sha256.crt --x509keyfile data_files/server2.key --priority=NONE:+AEAD:+AES-128-GCM:+GROUP-SECP256R1:+SHA256:+SIGN-RSA-PSS-RSAE-SHA256:+VERS-TLS1.3:%NO_TICKETS
-ssl-client2 server_addr=<IP_ADDRESS> server_port=5556 debug_level=4 force_version=tls13 ca_file=data_files/test-ca_cat12.crt force_ciphersuite=TLS1-3-AES-128-GCM-SHA256 sig_algs=rsa_pss_rsae_sha256 curves=secp256r1
This doesn't reach the pk_verify call with USE_CRYPTO_PSA, but without it, using the debugger, I was able to reach the code path just before the set of if's:
 if( pss_opts->mgf1_hash_id == md_alg &&
        ( (size_t) pss_opts->expected_salt_len == hash_len ||
            pss_opts->expected_salt_len  == MBEDTLS_RSA_SALT_LEN_ANY ) )

and the inside of it was evaluated to 1. Let me know if there's any better way to satisfy the requirement.

Hmm, I didn't realise when I wrote that note that it's currently not possible to complete a TLS 1.3 handshake with USE_PSA_CRYPTO enabled, until #5532 is merged - before that, I think what you did is the best we can do.
So, I merged this PR and 5532 in a local branch, then applied the following patch:
diff --git a/library/pk.c b/library/pk.c
index 4eff8e52cb2f..22e6c6ae6ac4 100644
--- a/library/pk.c
+++ b/library/pk.c
@@ -406,6 +406,7 @@ int mbedtls_pk_verify_ext( mbedtls_pk_type_t type, const void *options,
             return( mbedtls_psa_err_translate_pk( status ) );
         }

+        puts("\nVERIFY_EXT: psa_verify_hash()");
         status = psa_verify_hash( key_id, psa_sig_md, hash,
                                   hash_len, sig, sig_len );
         psa_destroy_key( key_id );
@@ -420,6 +421,7 @@ int mbedtls_pk_verify_ext( mbedtls_pk_type_t type, const void *options,
         if( sig_len < mbedtls_pk_get_len( ctx ) )
             return( MBEDTLS_ERR_RSA_VERIFY_FAILED );

+        puts("\nVERIFY_EXT: mbedtls_rsa_xxx()");
         ret = mbedtls_rsa_rsassa_pss_verify_ext( mbedtls_pk_rsa( *ctx ),
                                                  md_alg, (unsigned int) hash_len, hash,
                                                  pss_opts->mgf1_hash_id,

and, after enabling MBEDTLS_SSL_PROTO_TLS1_3 and MBEDTLS_SSL_TLS1_3_COMPATIBILITY_MODE in mbedtls_config.h, ran the following:
make -C programs ssl/ssl_{client,server}2 test/udp_proxy test/query_compile_time_config
tests/ssl-opt.sh -p -f "TLS 1.3 m->O: TLS_AES_128_GCM_SHA256,x25519,rsa_pss_rsae_sha256"
grep VERIFY_EXT tests/o-cli-1.log

first without USE_PSA_CRYPTO then with it, and the results are as expected.
So, between your verification and mine, I think we can be confident that the right code path is used.


Feat/audio toggle

Working volume controls, but after clicking the volume slider to change volume, and leaving the volume slider, keyboard shortcuts stop working until part of the window is clicked. No issues when the controls aren't conditionally render (always displayed).
The "progress" part of the volume slider should perhaps ideally by colored for clarity (i.e. 50% volume colors half the slider blue), but this couldn't be accomplished through CSS only on Webkit browsers. Important or not?

I've tried it out now and from a functionality perspective it looks ok for me. If the comments from Benjamin has been addressed I think this PR is ready.


[container] Update node.js to 22

We can update the container images to use node 22 using nvm.
Below is an example:
https://github.com/AppThreat/base-images/blob/3cb83924a3997f8c28846c132dc726829a73ce9a/sle/Dockerfile.lang#L10
https://github.com/AppThreat/base-images/blob/3cb83924a3997f8c28846c132dc726829a73ce9a/sle/Dockerfile.lang#L35-L39

To clarify, do you typically update before or after it goes LTS?

@setchy, there isn't a specific process being followed so far. But node 22 is looking faster compared to 21 and will become LTS in a few months, so must be a safe bet. Let me know if you have any concerns.


Cannot run due to relative import

Traceback (most recent call last):
  File "<conda_env>/lib/python2.7/runpy.py", line 174, in _run_module_as_main
    "__main__", fname, loader, pkg_name)
  File "<conda_env>/lib/python2.7/runpy.py", line 72, in _run_code
    exec code in run_globals
  File "<bin_dir>/smop-master/smop/main.py", line 15, in <module>
    from . import options
ValueError: Attempted relative import in non-package

Fixed in 0.40

Just cloned the repo from master and I'm still facing the same issue. Simply ran python main.py solver.m and I get the following error:

@azimb Hi ! Did you manage ti fix this issue ? Facing the same problem rn...

Me too. The problem seems to exist in the latest cersion.

Me too.


TextureWriter crashes vvvv when using unsupported texture format

Use the patch as linked in #357
Switch format to B8G8R8X8_UNorm_SRGB
Add a TextureWriter and try to write out a png -> boom

Causes  access violation in Stride.Graphics.StandardImageHelper.SaveFromMemory - the code needs some format checks.

Format checks could be done on our end before calling the method. needs an investigation into which ones actually work...

Fixed in upstream as well as added check to our save method (which can be removed once we update to a newer Stride).


External devices via bluetooth

Hi, are you have in a plans possibility to connect external devices like gamepad via bluetooth?

Hi, this is something we're working on, but isn't ready yet.

Is this possible today?


cmd/ebitenmobile: an application is not gracefully shutdown when a context lost happens

Ebitengine Version
v2.8.0-alpha.7
Operating System

[ ] Windows
[ ] macOS
[ ] Linux
[ ] FreeBSD
[ ] OpenBSD
[X] Android
[ ] iOS
[ ] Nintendo Switch
[ ] PlayStation 5
[ ] Xbox
[ ] Web Browsers

Go Version (go version)
go version go1.22.6 darwin/arm64
What steps will reproduce the problem?

Create an Android application (without setting RunGameOptions.StrictContextRestoration)
Run it on a desktop emulator
Change the size several times

What is the expected result?
The application is shut down gracefully
What happens instead?
The application crashes
 backtrace:
#00 pc<PHONE_NUMBER>04c300  /vendor/lib64/libGLESv2_enc.so (GL2Encoder::calcIndexRange(void const*, unsigned int, int, int*, int*)+648) (BuildId: c30caff2bc19628894a5d733c30f11c8)
#01 pc<PHONE_NUMBER>032464  /vendor/lib64/libGLESv2_enc.so (GL2Encoder::s_glDrawElements(void*, unsigned int, int, unsigned int, void const*)+764) (BuildId: c30caff2bc19628894a5d733c30f11c8)
#02 pc<PHONE_NUMBER>929bc8  /data/app/~~ahlPCRp7gcHeRgBXBbvssQ==/com.rpgsnack.snowman-qaZlRn0KhhXbpWjv7LsNdA==/base.apk

Anything else you feel useful to add?
No response

If this works well, it might be better to cherry-pick the fix to 2.7.


Assertion failure in ArrayBuffer::EntrySlice()

Hello, executing following code in ch 1.11.24(debug), an assertion will be thrown.
function opt(buffer) {
    let obj = [2.3023e-320];
    var result = buffer.slice(obj.x, obj.x);
}
function main() {
    for (let i = 0; i < 1000; i++) {
        var buffer = new ArrayBuffer(8);
        opt(buffer);
    }

    buffer = new ArrayBuffer(2147483647);
    opt(buffer);
}
main();

output:
ASSERTION 26608: (c:\users\sunlili\documents\workspace\jsenginesfordebug\chakracore-1.11.24\lib\runtime\library\arraybuffer.cpp, line 569) newLen < MaxArrayBufferLength
 Failure: (newLen < MaxArrayBufferLength)
FATAL ERROR: ch.exe failed due to exception code c0000420

newLen is 0x7fffffff, which equals to MaxArrayBufferLength. I think the assertion should be 'newLen <= MaxArrayBufferLength'.
ISec Lab.
2020.12.16

Thanks for the report, this is a bug in 1.11 BUT has already been fixed in the master branch with this commit: https://github.com/microsoft/ChakraCore/commit/ed3377c1cf489dc78410628ca2d81e5c434cd6e1#diff-5aaaad9cd76e7dd83dec4bbf6204562f0a811ec997bdb4f5cbdd1c08040bf3bf
We will not be updating the 1.11 branch.


Several fixes

We were fixing it while working on the Uber feature, thus many changes went in the master branch.
This fixes the following:

Adds the new attributes
Adds the promotion endpoint
Removes the unused gems
Improves the Faraday stack builder

@romanbsd Thank you very much!


https://www.sungaila.de/PDFtoImage/  Conversion  loss  text

PDFtoImage version
3.0.0
OS
Linux
OS version
Ubuntu22.04
Architecture
x64
Framework
.NET (Core)
App framework
Asp.NEt Core
Detailed bug report

转换后丢失了好多数据

source pdf file

Is it related to Chinese? I found that all Chinese characters have not been converted into images as part of the text.

Hello @sibo-git, your problem might be related to this issue: #55 Sometimes the text is not rendered correctly if the output image is too big.
Have to tried to lower the DPI setting from 300 to something like 100?

内蒙古交科路桥建设有限公司加油站-96.00-2023年08月10日.pdf
the source file,

Can confirm, the text is not rendered correctly. However, this seems to be a problem related to PDFium because the text is missing on Google Chrome and Microsoft Edge as well. So there is nothing I can do about it myself (this library is just a wrapper for PDFium).
Adobe Acrobat Reader renders the PDF just fine so this proves your PDF is not corrupted.

thanks,This issue only exists on Linux and not on Windows, so I am looking for a solution to add fonts to pdfium

Unfortunately, this looks like a font issue in PDFium that I cannot build a workaround for. You can create a ticket on the PDFium bugtracker and hope someone gets this fixed.
Once a bugfix in PDFium was made, this library PDFtoImage will be updated and fixed as well.


Screenshot support under multi workers

Hi, @arut
First, thanks for your great work on nginx-rtmp module!
My question is:
I want to use the HTTP『control module』to send command to nginx-rtmp server to capture a screenshot:
my nginx.conf:
recorder snapshot {
record keyframes manual;
record_max_frames 1;
record_path /tmp/snapshot;
exec_record_done /usr/local/ffmpeg/2.8/bin/ffmpeg -i /tmp/snapshot/$name.flv -vframes 1 -an -f rawvideo -ss 00:00:00 -y -f image2 /tmp/snapshot/$name.jpg;

}
then I will send HTTP request to capture a screenshot:
curl "http://<IP_ADDRESS>:8080/control/record/start?app=myapp&name=mystream&rec=snapshot"
it works great under one worker model, but under multi workers model, it failed often, maybe in 10 times  just success one time(when I set 4 workers).
is there any suggestion? Thanks in advance!
Regards!
Bingnan

Using multiple workers produces many bugs and it's not recommended.
Maybe you can setup master nginx with single worker and make screenshot on
it and setup second nginx pulling from master and set multiple workers on
it?

Thank you @misiek08  seems the HTTP 『control module』don't support multi worker very well, I will not  use it this way then. and thanks for your good suggestion~


Update Google Storage API endpoint

JSON API v1beta2 is no longer available. Changing this to v1 makes it work again.
More information here: https://cloud.google.com/storage/docs/json_api/v1/how-tos/migrate

Thanks, @eillarra !
Do you know if any additional changes are required to migrate? (i.e. have you tested this?)
Cheers,

Trying to deploy using the original v1beta2 returns this error in the command line:

googleapiclient.errors.HttpError: HttpError 400 when requesting https://www.googleapis.com/storage/v1beta2/b/www.delphinedhaenens.be?alt=json returned "Version v1beta2 of this API is no longer available. Please try again using JSON API v1. To request temporary reinstatement for your project, please visit https://docs.google.com/forms/d/1isIxBZg3rsQbDN_TOalZaz1WT_ebJchsrlv-Qr_r9mY/viewform?entry.244568692=985227088845&entry.176324201=v1beta2&entry.1071661541-Qr_r9mY/prefill"

Changing it to v1 makes it work as expected. Deploys without problems.

Also note that Crate website points this same issue in their repo: https://github.com/crate/crate-web#deploying-to-google-cloud-storage

Tested; thanks (I just wanted to make sure the ACL format hadn't changed and that bucket creation was still working).
This change is reasonably trivial and I'm assuming it was tested by the Crate folks so I'll merge it without adding tests.
Cheers,


motion_event.sh only on Motion Stop

Hi,
I am currently utilizing a Raspi Zero WH in combination with an IR camera module and RPi_Cam_Web_Interface in order to detect letter box inserts. If anybody is interested, my project is described here, but in German language only. If a motion start or stop is detected, the interface calls the macro file motion_event.sh and sends me a camera snapshot via Telegram and/or Pushover. So far, so good. However, I only want to obtain a snapshot after motion stop and not on motion start. How can I prevent motion_event.sh of being called on motion start? The parameter "im" within the scheduler seems not to have any influence on the Shell script.
Would it be possible, to call the number of change frames to start and still frames to stop within the Schell script in order to create a respective "if" dependency?

I will try it with "um 8 -motion_event.sh" under "Motion Start" and "um 8 motion_event.sh" under "Motion Stop" within the Scheduler.

motion_event.sh is called when either a motion start or stop event occurs, but it is passed a parameter which indicates what type of event it is (1=start, 0 = stop). THis is referenced as $1 within the script.
So the script can an if statement to determine what action to take based on whether it is a start or stop event.

Yes. That's the right idea. I am not sure about the if condition though as I think the 0 and 1 are quoted on the command line. If they survice then you may need to use
if [ $1 == "0" ]

Yesterdey, I tested it and with
if [ $1 -eq 0 ] then... fi
it works perfect. Thanks for your support.


Upload tar files

This PR adds support for uploading and benchmarking tar files. Because the tar files needed to be stored somewhere, the way velcom organizes its files was overhauled. Because that changed the config values, the configuration including the default config file was updated too.
Before this PR is deployed, the instance's config file should be compared with the new example config file.
If the following fields are still set like this
jdbcUrl: "jdbc:sqlite:file:data/data.db"
repoDir: "data/repos"
archivesRootDir: "data/archives/"

it should be safe to just start velcom with the default values for dataDir, cacheDir and tmpDir.
Otherwise the data dir should contain only the db files (data.db and, if they exist, also data.db-shm and data.db-wal). The cache dir and tmp dir should be empty.

If the following fields are still set like this
jdbcUrl: "jdbc:sqlite:file:data/data.db"
repoDir: "data/repos"
archivesRootDir: "data/archives/"

Yeah, seems to be the case! Except for jdbcUrl using an absolute path, which I assume doesn't matter.

The PR will still require manual intervention (once the changes move to stable) in order to update the config file, or velcom will not start. The new example config contains more detailed explanations and documentation of the various options than the last one.
When we've tested the PR and are ready, I'll open a PR from main to stable like last time.