[REQUEST] Add preview of components to the docs

Describe the feature.
New users (like me) might not know how these looks like and which one is which relying on guessing or trial and error until they find the appropiate one.
https://interactionspy.readthedocs.io/en/latest/models.component.html
Even a simple image would guide a lot.
Code of Conduct

[X] I agree to follow the contribution requirements.

Should no longer be an issue. v5 docs have those already - https://interactions-py.github.io/interactions.py/Guides/05 Components/#__tabbed_1_3

Closing due to v5 fundamentally changing the docs.


{FEATURE} openwakeword support / wyoming protocol

using 2 way audio, please add support for Home Assistant new plugin OpenWakeWord for the Wyoming Protocol.
This would allow cameras with mics to listen for WakeWords and commands, and cameras with speakers to play back the voice assistant.
When enabled on Esp32 and other devices, you get an on/off toggle to enable WakeWord Detection on compatible devices.
Of course you would only want this enabled on indoor cameras normally, but maybe enabled on demand for outdoor camera when working in the driveway....  dont want people talking to your assistant from outside when not home.

This is not related to this integration


As a user, I want to be able to see a demonstration (not the app but a recording of someone using the app) of PORTERS.

@plor reads it more like a demo like a gif or arcade that one wants to be able to visit.

Create a video asset, host to youtube and link from app

We should do this the next builder call (May 30th).


Follow-up PR to 1.24 Removals and Deprecations blog

/area blog
Follow up PR to 1.24 Removals and Deprecations blog post in PR https://github.com/kubernetes/website/pull/31767

Added a "Dockershim removal" sub-section in the "What to do" section
This may be too opinionated but not sure what the correct "What to do" would be

/cc @mickeyboxell @sftim

/hold for reviews

@mickeyboxell you're welcome to unhold this, or a blog reviewer may do that later today.

/lgtm
/hold cancel
Thanks for the update @reylejano!


Not working without locations (mower only)

I'm trying to get this to work with my mower, but the init fails because I have no locations registered. I have no gateway or any other Gardena smart system devices, only a Husquarna mower.
The API works as expected:

The call https://api.smart.gardena.dev/v1/locations returns 404 LOCATION_NOT_FOUND.
The call https://api.amc.husqvarna.dev/v1/mowers returns info about my mower as expected.

The component fails because it relies on the first call to return at least one location. This is not the case of only a mower and no other components. Can you make the component work with a setup where there is only a mower?

Hello @jlongva,
We'll have a look into this. We need to update the py-smart-gardena library to handle this case.
Grm

Unfortunately, Husqvarna mowers are not supported right now. It's a separate API that py-smart-gardena doesn't implement.

I created https://github.com/py-smart-gardena/py-smart-gardena/issues/10 for API implementation discussion.


Integrate with Spinnaker

Implement the CI/CD and image bakery parts of the Kubernetes-based cloud native architecture that we are investigating through the integration of Deployment Manager with Spinnaker, if possible. Build a proof of concept/prototype.
/cc @jackgr, @vaikas-google, @bmelville

Despite the conviction of everyone involved when we left NYC two weeks earlier, it turned out that there isn’t much opportunity to integrate DM and Spinnaker. Before this trip, we were looking at two possible outcomes:
Using DM to help Spinnaker deploy to Kubernetes by writing a DM based provider.
Using Spinnaker’s orchestration, image bakery, continuous deployment and user interface features to build out the parts of the Cloud Native Architecture not covered by DM.
At the end of the first day of meetings, we concluded that neither outcome was worth pursuing, since Spinnaker is not easily extensible, and its code base would not offer a lot of value to Cloud Native without major rework.
Its focus is on managing server groups, which are analogous to managed instance groups on GCE and replicated services on GKE. Most of its code resides in providers that map server groups onto cloud platforms. Currently, GCP and AWS are supported.
While it would have been possible to build a DM based provider, it would have taken a major rewrite of Spinnaker to take advantage of higher order types defined by DM templates. Without higher order types, a DM based provider would just be an expensive way to deploy replicated services into Kubernetes. A small dedicated driver for Kubernetes would yield the same benefits for much less effort.
The features we had hoped to leverage are too narrowly focused to be useful without major rework, and wouldn’t fit well into the Cloud Native architecture. For example,

The orchestration uses Spring wiring to kick off linear pipelines written in Jenkins. The Spring wiring would introduce a lot of complexity without adding any value to Cloud Native, and the pipelines execute downstream of the image baking process. In contrast, Cloud Native needs parallel workflow at the front end of the deployment process, and needs to bake images on demand as workflows execute, in order to support image parameterization.
The image bakery doesn’t currently support Docker, and while it could be extended to do so, the effort would probably be better invested in building a Docker bakery for Cloud Native that fits better into the overall architecture.
The continuous deployment feature doesn’t know about Kubernetes and therefore doesn’t take advantage of the Kubernetes deployment object, which manages the roll out, canarying, roll back and roll forward of replication controllers. While Spinnaker provides comparable functionality for VMs, it doesn’t add any value when deploying to Kubernetes, since the functionality is already provided by Kubernetes.
The user interface is closely tied to server groups and VMs, and drives the existing orchestration and image bakery. While we might be able to reuse some of the chrome, the content would need to be rewritten to deal with higher order types and Kubernetes. At the end of the day, we would probably do better to reuse the chrome from the UI for Cloud Native from the Kubernetes/GKE UI now under development, so that we integrate well with it.

The comments in this (now closed) issue relate specifically to integrating Spinnaker with Deployment Manager in a cloud native architecture being investigated by some teams at Google. They were not intended to be broad statements about the suitability of Spinnaker for Cloud Native use generally, nor to be statements about the feasibility of integrating Spinnaker with Kubernetes through other means.
Specifically, the comments related to the extensibility of Spinnaker are with respect to its use in a DM based orchestration solution.

The Google Spinnaker team is fully-committed to adding support for Kubernetes to Spinnaker. This work is underway as we speak; first passes at Create & Clone Server Group operations have recently been merged into the Spinnaker backend and the current focus is on standing up the Create/Clone Server Group wizard in the UI.
We had been investigating if it would make sense to pursue Kubernetes support by integrating with Deployment Manager, and determined that a “native” integration with Kubernetes is the right path for Spinnaker at the present time.

Support was announced today: http://www.spinnaker.io/v1.0/blog/deploy-to-kubernetes-using-spinnaker

Have you found a way to use Spinnaker with Helm? I would like to use it for deploying application instead of storing the Deployment's settings in spinnaker.
Is it possible only via Jenkins job?

No, there is no native integration between the two systems right now. If you deploy something via Helm, and then manage deployments via Spinnaker, whatever state your Helm configuration is in will drift from what's running in your cluster.

Thanks! Do you know about any plan to create one? I guess it could be a stage where the input fields are the Helm chart values. But I'm not sure how could Spinnaker apply deploy strategies for a "black box" chart.

Can anyone provide a comprehensive comparison between Helm and Spinnaker? It sounds like these are two competing products when it comes to managing CD for kubernetes. One thing I like about Helm is that it doesn't add too much abstraction on top of raw kubernetes constructs and you can keep all your manifest and configuration in source control along with your application code (infrastructure as code is nice).

They solve different problems:
Helm behaves much like a Kubernetes package manager, allowing you to install a microservice-based application together with all its dependencies, and can ensure the application and all its components/dependencies are updated recursively on a given Kubernetes cluster. You can apply the same helm chart to deploy the same application version on multiple Kubernetes clusters, often promoting it to higher environments, but the deployment pipelines should be modeled in another tool such as Jenkins or GoCD. Helm is more or less just a deployment engine which may or may not be orchestrated by such pipelines, and would end up running on the Jenkins or GoCD agents.
 Each microservice is first expected to be built on your CI. This may happen in Jenkins, resulting in deb or rpm packages or container images, while AMIs can be built by Spinnaker directly using an integration with packer. The AMIs or containers can then be rolled out on multiple clusters, which are cloud provider specific, for example clusters of the same microservice can be deployed on Kubernetes for containers but also AWS EC2 for AMIs. Azure and Google Cloud are also supported while DCOS is in the works.
Each microservice can be independently developed, released and managed by an existing team, and the deployment pipelines are usually defined within Spinnaker. Unlike Jenkins and GoCD, Spinnaker has full knowledge and control over the clusters and their load balancer, and can deploy the instances or containers using various deployment orchestration strategies, so older clusters can be kept around and new versions can be used as canary.
Spinnaker is expected to be triggered by the CI and can run some custom pipeline steps on Jenkins or even as Kubernetes pods, but most of the deployment actions are natively running against the clusters.
It also offers a nice dashboard of all the clusters of the microservice up to the container/instance level and can show their health status and the user can easily trigger their termination when unhealthy.

Well put @cristim


Testing DynamicMaps

This includes testing the DynamicMap tutorial which needs reference data.
The general issue is that DynamicMaps tend to be empty, leaving nothing to test. And to generate data, you need a live server making the issue even more complicated...

Anything else we want here? We now have a fair number of unit tests.

We now have a fair number of unit tests.

True but that isn't the same as testing dynamic maps in the notebook. I'm still not sure what we can do about this, or whether there is anything sane we can do about this...

Not sure what "testing dynamic maps in the notebook" adds over unit tests or were you talking about testing the widget code with DynamicMaps? Otherwise they don't behave any differently in a notebook and a unit test so I don't see what notebook tests would add.

Otherwise they don't behave any differently in a notebook and a unit test so I don't see what notebook tests would add.

Unless we mirror the code in the notebooks against the unit tests (painful!) we have no way of knowing whether the dynamicmaps in the notebooks are behaving properly. That said, I don't mind seeing this issue closed as 'wontfix' as I think the problem is too difficult to solve properly.


Why

What is your question?
I'm actually glad that you managed to pull out something that Shadow Mario didn't dared to do, but my question is...
Why did you decided to use 0.7.3 for this entire build
As the owner of +60GBs worth of mods that i've been collecting ever since i started to use Psych, i had a lot of bad experiences with 0.7 and upwards, mostly because of the RGB notes and the fact that the code breaks a LOT of mods that used to work there
Or if it's not mods breaking, it's mod giving me a wall of red error messages that are more like an annoyance than anything else
Idk if it would be too much to ask but, do you have a any plans on making a version of P-Slice based on 0.6.3?
With that version i had a more expanded mod compatibility
https://github.com/user-attachments/assets/c1aeb34d-99c7-4357-ae96-0964a5bf8d62

Aw hell naw, Silly Billy Crashed 💀
But the same pack DOES work on 0.6.3
https://github.com/user-attachments/assets/f0989bea-851d-45f1-955f-30e7d839afbc


Select should select all text after opening if enableFilter is true

It is currently a little annoying that when opening a Select input which has enableFilter turned on (default is on) that the text in the input is not selected automatically, so if you start typing the characters are appended to the end of the current value, which is almost never what you want to happen.
We need to consider whether this behavior would be desired if enableCreate is turned on as well. Probably should be consistent, and user could click at the end of the text or hit the right-arrow key if they do want to just append some characters to the end of the current value.

What would this be noted as in the changelog?


Option to disable basic auth

This adds an option to disable http basic auth (because I had some problems in my application which uses basic auth. The auth popup keeps popping up on every page, which is rather annoying).
Unfortunately I did not find out how to add tests for that, but if you give me some hint, I can do that, too.

@iblue Thanks, I will fix the build and will merge pull request.


Build fails when rusqlite/git is used

Hi! Thank you for the library. I have a project that uses rusqlite and serde-rusqlite. If I use:
rusqlite = { version = "~0", features = ["serde_json"] }
serde_rusqlite = "~0"

All is well, but if I use the GIT version of rusqlite...
rusqlite = { git  = "https://github.com/rusqlite/rusqlite", features = ["serde_json"] }
serde_rusqlite = "~0"

It fails. If I remove serde_rusqlite, all is well again. I paste the error below; is there a way to fix this?
Thank you!
G.
error: failed to select a version for `libsqlite3-sys`.
    ... required by package `rusqlite v0.29.0`
    ... which satisfies dependency `rusqlite = "^0.29"` (locked to 0.29.0) of package `serde_rusqlite v0.33.1`
    ... which satisfies dependency `serde_rusqlite = "~0"` (locked to 0.33.1) of package `sqliterg v0.0.0 (/home/devel/sqliterg)`
versions that meet the requirements `^0.26.0` (locked to 0.26.0) are: 0.26.0

the package `libsqlite3-sys` links to the native library `sqlite3`, but it conflicts with a previous package which links to `sqlite3` as well:
package `libsqlite3-sys v0.26.0 (https://github.com/rusqlite/rusqlite#6176b11a)`
    ... which satisfies git dependency `libsqlite3-sys` of package `rusqlite v0.29.0 (https://github.com/rusqlite/rusqlite#6176b11a)`
    ... which satisfies git dependency `rusqlite` of package `sqliterg v0.0.0 (/home/devel/sqliterg)`
Only one package in the dependency graph may specify the same links value. This helps ensure that only one copy of a native library is linked in the final binary. Try to adjust your dependencies so that only one package uses the links ='libsqlite3-sys' value. For more information, see https://doc.rust-lang.org/cargo/reference/resolver.html#links.

failed to select a version for `libsqlite3-sys` which could resolve this conflict
make: *** [Makefile:21: build] Error 101

Can you please try crate version 0.34?

Hi! Sorry for the delay here. It basically gives the same error:
make build
cargo build --release
    Updating crates.io index
error: failed to select a version for `libsqlite3-sys`.
    ... required by package `rusqlite v0.30.0`
    ... which satisfies dependency `rusqlite = "^0.30"` of package `serde_rusqlite v0.34.0`
    ... which satisfies dependency `serde_rusqlite = "^0.34"` of package `sqliterg v0.17.1 (/home/devel/sqliterg)`
versions that meet the requirements `^0.27.0` are: 0.27.0

the package `libsqlite3-sys` links to the native library `sqlite3`, but it conflicts with a previous package which links to `sqlite3` as well:
package `libsqlite3-sys v0.27.0 (https://github.com/rusqlite/rusqlite#c2fbd167)`
    ... which satisfies git dependency `libsqlite3-sys` (locked to 0.27.0) of package `rusqlite v0.30.0 (https://github.com/rusqlite/rusqlite#c2fbd167)`
    ... which satisfies git dependency `rusqlite` (locked to 0.30.0) of package `sqliterg v0.17.1 (/home/devel/sqliterg)`
Only one package in the dependency graph may specify the same links value. This helps ensure that only one copy of a native library is linked in the final binary. Try to adjust your dependencies so that only one package uses the links ='libsqlite3-sys' value. For more information, see https://doc.rust-lang.org/cargo/reference/resolver.html#links.

failed to select a version for `libsqlite3-sys` which could resolve this conflict
make: *** [Makefile:36: build] Error 101

I think I see that you updated the dependency, it's a bit of cat-and-mouse game... I don't know rust enough to say if there's a way to say "latest possible version of a dependency"...
Anyway, if you don't mind, I took the relevant code from your project and incorporated in mine, it works like a charm, so thanks. How can I give proper attribution?
https://github.com/proofrock/sqliterg/commit/3fde75e9708cf5a49b425b18c9c098c4abe4fb6b
I also used the same code in a project for DuckDB, it works flawslessly too, if you are interested in porting.


Complex file logic

Hey, I'm attempting to write a test that will pass if:

the file doesn't exist
the file does exist and contains "foo"

Is this possible? I've tried various combinations of putting "or" at different levels in my goss.yaml but I'm getting the impression that it doesn't work like that... a simple test case with:
exists:
  or:
  - true
  - false

doesn't appear to work.
Is this something that is expected to work in the current version, and if not is it something that you consider to be within the scope of the project?
Thanks :)

Interesting use case. Unfortunately, support for this does not currently exist in goss.
It would be easy to add this feature if it's defined as: "If resource does not exist, skip ALL other tests."
If the feature requested is to do more complex logic like: "If the file is mode 0755, then ensure content X otherwise ensure content Y" that might be much more complex.

I'd be fine with "skip if file does not exist" :)
Any more complex logic than that and I would agree that it's totally out of
scope and I should just write some Go ;)
On 15 Jul 2016 17:14, "Ahmed Elsabbahy"<EMAIL_ADDRESS>wrote:

Interesting use case. Unfortunately, support for this does not currently
exist in goss.
It would be easy to add this feature if it's defined as: "If resource does
not exist, skip ALL other tests."
If the feature requested is to do more complex logic like: "If the file is
mode 0755, then ensure content X otherwise ensure content Y" that might be
much more complex.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/aelsabbahy/goss/issues/107#issuecomment-232997048,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAxthnra4_nbwK-WHE_0zCoXnpmGhq7bks5qV7HygaJpZM4JNht3
.

JFYI, we have moved all such logic on the layer before the goss execution.
We are using templates toolkit to build the server specific goss.json file (IP, services, server role, server configuration) and then trigger goss with plain goss.json, like:
> cat /etc/.../goss.json
{
    "gossfile": {
        "01_running-processes.json": {},
        "01_hostname-and-interfaces.json": {},
        "02_disk-free.json": {},
        "03_files_availability.json": {},
        "03_no-cores.json": {},
        "03_open_ports.json": {},
        "04_template_files.json": {},
        "05_system_users.json": {},
        "06_system_packages.json": {},
        "07_system_service.json": {},
        "08_system_ports.json": {},
        "09_system_dns.json": {},
        "10_sites_ok.json": {},
        "99_dummy.json": {}
    }
}

You can find our repo here https://github.com/sipwise/system-tests ;-)
Hope it will help you a bit!

So, this will have to wait for the next release of goss. I had some time to work on it today, but prioritized fixing bugs over enhancements.
This change is a bit more work than I initially thought since currently tests have only a "Successful" boolean. I need to add a "Status" or "Result" which allows for success, failed, skipped and update the outputs to support that format.

Released in v0.1.10


Add specs for Coverage.supported?

#1016
[Feature #19026]

Coverage.supported?(mode) enables detection of what coverage modes are
supported.

Thank you!


fix: update minimatch to the latest.

version 9 changed to only having named exports
fixes #702

coverage: 98.209%. remained the same when pulling 6171a0feb5bb2424268548ab6ed722987bfccdb8 on lholmquist:update-minimatch into a7234fbb81573f1120e60ee13e6fa029b73f616d on nodeshift:main.


feat(docker): adds pluggable docker container

Description:
This PR adds a Dockerfile which will create a small (~15MB) container image based on busybox. The decision to base it on busybox is mostly for debugging purposes and being able to use a shell script as an entry point - we could consider making a separate busybox container to manipulate all "pluggable" exporters, and have exporters be purely data containers based on "scratch".
The final container contains the fat JAR under /usr/share/zeebe/zeebe-hazelcast-exporter and will be named after a configurable EXPORTER_ID argument (which is exported to the environment; defaults to zeebe-hazelcast-exporter). The exporter ID is used not only as the JAR name but also in the generated configuration. Right now this is done at build time, we could argue that this should be also done at container-creation time, so we might want to make the name static but allow changing what it will be copied to (which is already do-able using SHARED_JAR environment variable to point to the destination path).
Along with the image there is an entrypoint.sh shell script which on start will copy the exporter into a pre-defined (but customizable) shared directory (expected to be a shared volume), and will generate configuration from environment variables to be appended to a well known location (which for a deployment should also be a shared volume/location).
I also added a small kubernetes.sample.yml which starts a single broker and the exporter container as its initContainer. You can test it locally by deploying against your favorite local k8s setup (e.g. kind), and as far as I can tell it seems to work (maybe someone can test it properly :sweat_smile: - but the exporter is loaded and configured!).
There's also a small Makefile to ease building and pushing the docker images: I settled on gcr.io/zeebe-io/zeebe-hazelcast-exporter at the moment, I hope this wasn't used by someone else for an image which packages both Zeebe and the exporter :see_no_evil:
Ping me if you have any question, I whipped this up in ~1h so I imagine we'll want to iterate on this.

What is the status here ? :D

@Zelldon status is ... (drum roll) I am back from holidays :)

@saig0 do we still need this?

I think this is currently not so important.


perf: Collection-repeat freeze navigation to child view

Type: perf
Platform: ios 8 webview
In my template, I have an  directive to navigate to a child view #/tab/feed.  When collection-repeat is used, there's always 1-3 seconds delay/freeze before advancing to the child view after tapping on "See all".  Navigating from the child view back to this view also have 1-3 seconds delay.
If I removed the collection-repeat section, everything works fine.
I read that there's performance issue with collection-repeat and it seems to be fixed and not related to my example.  But I'm pretty sure the culprit is collection-repeat.
https://github.com/driftyco/ionic/issues/3194
Here's snippet of my template.
<ion-view view-title="Home">
    <ion-content>
        <ion-item class="item item-divider">
            Most recent

                See all

        </ion-item>

    </ion-content>
</ion-view>

The problem is reproducible on ios 8 simulator.  Desktop browser is working fine.

I have the same issue with ionic 1.1.0 on android 4.4.2 webview

Greetings @5amfung!
I've closed this issue because my sensors indicated it was old and inactive, and may have already been fixed in recent versions of Ionic. However, if you are still experiencing this issue, please feel free to reopen this issue by creating a new one, and include any examples and other necessary information, so that we can look into it further.
Thank you for allowing me to assist you.


Add Snowflake backend plugin

Signed-off-by: Kevin Su<EMAIL_ADDRESS>TL;DR
Implements WebAPI plugin for Snowflake.
Type

[ ] Bug Fix
[ ] Feature
[x] Plugin

Are all requirements met?

[ ] Code completed
[ ] Smoke tested
[x] Unit tests added
[ ] Any pending items have an associated Issue
[ ] Code documentation added

Complete description
Use Snowflake Rest API instead of Golang API to implement the backend plugin since Snowflake Golang API doesn't have a function that cancels a query or gets query status by query ID.
And Snowflake Rest API only support client use Oauth or JSON Web Token (JWT) to authenticate to the server.
https://docs.snowflake.com/en/developer-guide/sql-api/guide.html#authenticating-to-the-server
If clients want to use username and password to authenticate to the server, they can use SQLAlchemyTask.
For example:
task_config=SQLAlchemyConfig(
<EMAIL_ADDRESS>            user='haytham',
            password='<your_password>',
            account='hoa61102',
        ),

Refer:
Snowflake SQL API Reference
Snowflake SQL API Developer Guide
Snowflake Golang API
TODO

[ ] Add example in Flytesnack
[ ] Update Flyteidl
[ ] Add Snowflake tasks in Flytekit

Follow-up issue
NA

Going to add more tests to improve the test coverage

Snowflake Demo:
https://user-images.githubusercontent.com/37936015/131316960-ccdb8e7e-f6dc-4a10-8950-61eb11d29ed6.mp4
Snowflake workflow example: https://gist.github.com/pingsutw/dcda212f5e342e20d974cfe027206e57

Already Updated Flyteidl version.

Athena tests and others failed due to IDL change in https://github.com/flyteorg/flyteidl/commit/8d83de8d1b401e91a4b46fb52f9f5f41f597b4bc.
I will file a new ticket, and work on it.


Ingress issue

I was able to expose the URL using path
While it is returing it is not going to path - it is going back to server.example.com instead of server.example.com/path1

Can you fill out the bug report template so it's easier to replicate the problem you are having
Describe the bug A clear and concise description of what the bug is.

Version of Helm and Kubernetes:

Which chart:

What happened:

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:


Error: can't multiply sequence by non-int of type 'float'

The script worked well for the first 19 subjects, but then I got this systematic error at the DWI step for all remaining subjects:
err.batch_processing_sub-DEV205Sujet09.log
err.batch_processing_sub-VS251.log
Uploading err.batch_processing_sub-TV236.log…
_TypeError: can't multiply sequence by non-int of type 'float'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/dagher/dagher12/lydia12/SPINE_park/spine-park/aggregate_chunks.py", line 66, in <module>
    main()
  File "/dagher/dagher12/lydia12/SPINE_park/spine-park/aggregate_chunks.py", line 62, in main
    aggregate_data(input_csv, output_csv)
  File "/dagher/dagher12/lydia12/SPINE_park/spine-park/aggregate_chunks.py", line 31, in aggregate_data
    aggregated_df = df.groupby(['Subject', 'VertLevel']).apply(
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/export02/data/lydiac/miniconda3/lib/python3.11/site-packages/pandas/core/groupby/groupby.py", line 1846, in apply
    return self._python_apply_general(f, self._obj_with_exclusions)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/export02/data/lydiac/miniconda3/lib/python3.11/site-packages/pandas/core/groupby/groupby.py", line 1885, in _python_apply_general
    values, mutated = self._grouper.apply_groupwise(f, data, self.axis)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/export02/data/lydiac/miniconda3/lib/python3.11/site-packages/pandas/core/groupby/ops.py", line 918, in apply_groupwise
    res = f(group)
          ^^^^^^^^
  File "/dagher/dagher12/lydia12/SPINE_park/spine-park/aggregate_chunks.py", line 35, in <lambda>
    'STD()': (x['Size [vox]'] * x['STD()']).sum() / x['Size [vox]'].sum(),
              ~~~~~~~~~~~~~~~~^~~~~~~~~~~~
02/data/lydiac/miniconda3/lib/python3.11/site-packages/pandas/core/ops/common.py", line 76, in new_method
    return method(self, other)
           ^^^^^^^^^^^^^^^^^^^
  File "/export02/data/lydiac/miniconda3/lib/python3.11/site-packages/pandas/core/arraylike.py", line 202, in __mul__
    return self._arith_method(other, operator.mul)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/export02/data/lydiac/miniconda3/lib/python3.11/site-packages/pandas/core/series.py", line 6115, in _arith_method
    return base.IndexOpsMixin._arith_method(self, other, op)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/export02/data/lydiac/miniconda3/lib/python3.11/site-packages/pandas/core/base.py", line 1382, in _arith_method
    result = ops.arithmetic_op(lvalues, rvalues, op)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/export02/data/lydiac/miniconda3/lib/python3.11/site-packages/pandas/core/ops/array_ops.py", line 283, in arithmetic_op
    res_values = _na_arithmetic_op(left, right, op)  # type: ignore[arg-type]
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/export02/data/lydiac/miniconda3/lib/python3.11/site-packages/pandas/core/ops/array_ops.py", line 227, in _na_arithmetic_op
    result = _masked_arith_op(left, right, op)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/export02/data/lydiac/miniconda3/lib/python3.11/site-packages/pandas/core/ops/array_ops.py", line 163, in _masked_arith_op
    result[mask] = op(xrav[mask], yrav[mask])
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: can't multiply sequence by non-int of type 'float'__

Can you upload /dagher/dagher12/lydia12/SPINE_park/CENIR_ICEBERG_BIDS/RESULTS_02072024/results/DWI_FA_53.csv

DWI_FA_53.csv

hum... I don't see sub-DEV205Sujet09 on the CSV, so maybe the issue was actually caused by the subject not being processed with extract metric.
I will run the script on sub-DEV205Sujet09 to see if I can reproduce the error.

I ran the script on the two first subjects that failed, sub-DEV203Sujet08 and sub-DEV205Sujet09. I still have the same error. That's weird...

can you try to run one of the subject that fails on your laptop? it should take about an hour (use -job 1 -include-list sub-DEV203Sujet08)

I can't work on my laptop; I don't have enough storage space left to install the SCT and import the data...
I re-runned on one subject after changing the location of the output directory. It worked. But when I try to run again on multiple subjects, I get the same error...

From: Julien Cohen-Adad @.>
Sent: July 4, 2024 10:50
To: sct-pipeline/spine-park @.>
Cc: Lydia Chougar, Dr @.>; Author @.>
Subject: Re: [sct-pipeline/spine-park] Error: can't multiply sequence by non-int of type 'float' (Issue #45)
can you try to run one of the subject that fails on your laptop? it should take about an hour (use -job 1 -include-list sub-DEV203Sujet08)
—
Reply to this email directly, view it on GitHubhttps://github.com/sct-pipeline/spine-park/issues/45#issuecomment-2209169128, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BFCFJYSHRXMQ2ZNZUNABIITZKVOMTAVCNFSM6AAAAABKJRUNY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBZGE3DSMJSHA.
You are receiving this because you authored the thread.Message ID: @.***>

Hum... this sounds more like a server-related issue then, but I'm not sure what could be the exact cause. @joshuacwnewton do you have any insights?

I'm still getting the same error :(
err.batch_processing_sub-DEV203Sujet08.log

Ah! Looking at the CSV uploaded above, I notice that the STD() column contains a cell with the value 'Weights sum to zero, can't be normalized'.
Since this is a string (and not a number), I presume that this is the cause of this specific error.

I'm just adding that it worked for the first 20 subjects I processed before I got the error.

From: Joshua Newton @.>
Sent: July 4, 2024 16:44
To: sct-pipeline/spine-park @.>
Cc: Lydia Chougar, Dr @.>; Author @.>
Subject: Re: [sct-pipeline/spine-park] Error: can't multiply sequence by non-int of type 'float' (Issue #45)
Ah! Looking at the CSV uploaded above, I notice that the STD() column contains a cell with the value 'Weights sum to zero, can't be normalized'.
Since this is a string (and not a number), I presume that this is the cause of this specific error.
—
Reply to this email directly, view it on GitHubhttps://github.com/sct-pipeline/spine-park/issues/45#issuecomment-2209546620, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BFCFJYVXJIZXQ6WWM7OHCJTZKWX4LAVCNFSM6AAAAABKJRUNY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBZGU2DMNRSGA.
You are receiving this because you authored the thread.Message ID: @.***>

That makes sense, because the 'Weights sum to zero, can't be normalized' cell only appears with sub-DEV203Sujet08_chunk-3, which comes after many other subjects.
(And, since we're appending to the csv, once this cell gets added, it will fail all subjects that come after.)

OK, great catch @joshuacwnewton!
@Kaonashi22 can you please send me the problematic subject alongside the derivatives?

Problematic line:

The segmentation is correct:

The manual disc label files is missing the '12' value (corresponds to T5):
julien-macbook:~/temp $ sct_label_utils -i /Users/julien/temp/joplin/lydia/CENIR_ICEBERG_spine_BIDS/derivatives/labels/sub-DEV203Sujet08/anat/sub-DEV203Sujet08_T2_label-disc.nii.gz -display

--
Spinal Cord Toolbox (git-master-9e1f65b86902cb237d5f79058a4623eed2d2c8eb)

sct_label_utils -i /Users/julien/temp/joplin/lydia/CENIR_ICEBERG_spine_BIDS/derivatives/labels/sub-DEV203Sujet08/anat/sub-DEV203Sujet08_T2_label-disc.nii.gz -display
--

Position=(170,257,31) -- Value= 1
Position=(166,226,31) -- Value= 2
Position=(163,206,31) -- Value= 3
Position=(156,180,31) -- Value= 4
Position=(149,156,31) -- Value= 5
Position=(140,135,31) -- Value= 6
Position=(138,118,31) -- Value= 7
Position=(134,95,36) -- Value= 8
Position=(140,69,36) -- Value= 9
Position=(149,40,38) -- Value= 10
Position=(156,11,38) -- Value= 11
All labels (useful syntax):
170,257,31,1:166,226,31,2:163,206,31,3:156,180,31,4:149,156,31,5:140,135,31,6:138,118,31,7:134,95,36,8:140,69,36,9:149,40,38,10:156,11,38,11

Causing only single label for registration:

The reason that label is missing is likely because the T2 for that subject did not cover T5:

We should then revisit our code, because we assume for this project that all subjects have coverage down to T5:
https://github.com/sct-pipeline/spine-park/blob/84ba26feb1c2094e956cc43d808bd857d156d934/batch_processing.sh#L20-L21
I see two options:

We adapt the code to deal with the fact that some subjects don't have T5 covered.
We replace T5 by the lowest level available in all subjects of the study.

I think that the first option is better, given that the majority of subjects have T5 covered.

Thanks for these investigations @jcohenadad !
Then let's go for the first option


Share authentication cookies among ASP.NET apps

I set AuthenticationType, CookieName and CookieDomain in UseCookieAuthentication in subdomain Startup.cs page which is ASP.NET 4.x.
Even with this configuration, subdomain sites can get User.Identity.Name and User.Identity.Id from cookies.
Like how I did it in ASP.NET 4.x,
Can ASP.NET Core get User.Identity.Name and User.Identity.Id from cookies?

Please re-open this issue using the This page feedback button and form at the bottom of the English-US topic. Use of the This page feedback form adds metadata to your GitHub issue that cross-links the topic and automatically pings the author.


Add trainer loading utility

Add load trainer utility

Coverage increased (+0.1%) to 89.757% when pulling f1f6dbf623e5ef0c4f84d923bd4ed47d0a187b57 on feature/load_trainer into a33e452e665a55a01634e9271e1a1b0fd97c3294 on master.

Coverage increased (+0.1%) to 89.757% when pulling f1f6dbf623e5ef0c4f84d923bd4ed47d0a187b57 on feature/load_trainer into a33e452e665a55a01634e9271e1a1b0fd97c3294 on master.


Request: Persistent Token Borders

Is your feature request related to a problem? Please describe.
By default, tokens show a border when the user holds their mouse pointer over them. When you're using a shared display -- say, on a TV placed before a live group -- they typically don't have a mouse pointer so the token borders don't appear to them.
Describe the solution you'd like
This module could use an option to make token borders persistent. This would help users easily ID the disposition of an actor (i.e., Friendly or Hostile), and if they are using top-down tokens it can also help them quickly identify WHICH things are tokens. The visibility of a token's border would still be overridden by the option you've included of turning the border off. (That way your mimics stay hidden.)
Describe alternatives you've considered
I mean, sure, you can go into a token's art file and manually add a border around it. But if you're using a catalog of top-down tokens someone else has made, you don't want to have to go in there and give each one a ring, especially when what you want to show is already there in the system.
Additional context
Obviously, this would have to be an option to check on or off. Not everyone is going to want a constantly-visible box or ring around every token.

Added in 1.3


Changed the icon of Twitter in footer

📥 Pull Request
Description
Updated the Twitter icon in the footer to the latest "X" logo.
The new SVG icon is styled in ash color for better visibility and consistency with the overall design.
This change enhances the user interface and maintains brand alignment with the recent rebranding of Twitter to "X."

Fixes #1217
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

@ajay-dhangar  , If you like it , please increase the level of my PR,I have adjusted the icon with the colour and height properly

@ajay-dhangar , please add the label !!!

@ajay-dhangar , please add label ?????


IOS - library rewrite

@jacobrosenthal Ping.
I took some time to do a rewrite of the library for IOS, and introduce things like caching (in anticipation of sandeepmistry/noble#597) and clear the way for testing with Quick.
I have a fair bit of cleanup left before this will be 100%, but I would love to get your feedback in the meantime. I'm sure there are some better abstractions to be made, but I'm a novice at Swift.

@jacobrosenthal Any feedback?

@brycejacobs I'm trying to build it with your changes, and I get error: no such file or directory: '..../node_modules/react-native-ble/ios/BLEManager/CBExtensions.swift'


[Request for external] Codeunit G/L Entry Application Modify Scope OnPrem -> Cloud on procedure NextLetter

Hi,
We need to use the procedure NextLetter from codeunit G/L Entry Application on cloud target.
Please change the scope.

Hello,
Do you know if this request will be taken into account and in which BC version ?


what's the meaning of the outputing ?

root@sc-demo:tmp$ hcache  -top 60
+------------------------------------------------------------+----------------+------------+-----------+---------+
| Name                                                       | Size (bytes)   | Pages      | Cached    | Percent |
|------------------------------------------------------------+----------------+------------+-----------+---------|
| /usr/lib/jvm/java-8-oracle/jre/lib/rt.jar                  | 66159478       | 16153      | 11144     | 068.990 |
| /usr/lib/jvm/java-8-oracle/jre/lib/amd64/server/libjvm.so  | 16995339       | 4150       | 3715      | 089.518 |
| /usr/lib/jvm/java-8-oracle/jre/lib/ext/jfxrt.jar           | 18490072       | 4515       | 864       | 019.136 |
| /usr/lib/jvm/java-8-oracle/jre/lib/charsets.jar            | 3135391        | 766        | 766       | 100.000 |
| /bin/hcache                                                | 2542252        | 621        | 621       | 100.000 |

I cant understand the meaning of the Size,Page,Cached,Percent!
SIze: Is the file size?
Pages:?
Cache:? bytes?
Percent: /?

Size is the total memory used by the this process.
Pages is the pages, this may be Size/4k.
Cached is the cached pages.
Percent is Cached/Pages.


Reordering desktops on Windows 10 build 19044

The desktops reordering feature was made available in the latest Win10 builds (starting from Windows 10 build 21337).
Is it possible to implement it somehow programmatically on a Win10 build without native support, particularly 19044 ?

@mrob95 ..and swaps the desktop names.. This could be a solution I guess, since you don't need desktop moving much often and hence it shouldn't be really optimized in speed and convenience.

Going to close this. Let me know if you have any issues :)


Getting "Cannot read property 'some' of undefined" when running tests

🐛 Bug Report

Running jest when<EMAIL_ADDRESS>is installed results in the error:
    TypeError: Cannot read property 'some' of undefined

      at Object.exports.install (node_modules/whatwg-url/dist/URL.js:84:20)

To Reproduce
Steps to reproduce the behavior:
Install jest, but make sure the jsdom pulled in by jest-environment-jsdom is 16.2.2.
$ npm ls jsdom
<EMAIL_ADDRESS>/Users/bschlenk/Code/jest-repro
└─┬<EMAIL_ADDRESS>  └─┬<EMAIL_ADDRESS>    └─┬<EMAIL_ADDRESS>      └─┬<EMAIL_ADDRESS>        └──<EMAIL_ADDRESS>
FWIW, tests seem to pass when<EMAIL_ADDRESS>is used, but jest-environment-jsdom has the version set to ^16.2.2.
Expected behavior

Tests should work and pass.
Link to repl or repo (highly encouraged)

https://github.com/bschlenk/jest-some-repro
envinfo

  System:
    OS: macOS Mojave 10.14.6
    CPU: (4) x64 Intel(R) Core(TM) i7-5557U CPU @ 3.10GHz
  Binaries:
    Node: 12.16.1 - ~/.nvm/versions/node/v12.16.1/bin/node
    Yarn: 1.21.1 - ~/.yarn/bin/yarn
    npm: 6.14.8 - ~/.nvm/versions/node/v12.16.1/bin/npm
  npmPackages:
    jest: ^26.4.2 => 26.4.2

Whoops, got a github error when I submitted the first time so I submitted again. Closing in favor of https://github.com/facebook/jest/issues/10489


Added a few more files to diagnostics bundle for support

High Level Description
What features does this change enable? What bugs does this change fix? High-Level description of how things changed.
This change adds a few more files from master node to a diagnostics bundle.These files come in handy for support debugging various issues
Enterprise PR https://github.com/mesosphere/dcos-enterprise/pull/576
Related Issues

DCOS-13706

Checklist for all PR's

[ ] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:
[X] Read the DC/OS contributing guidelines
[X] Followed relevant code rules Rules for Packages and Systemd

Checklist for component/package updates:
If you are changing components or packages in DC/OS (e.g. you are bumping the sha or ref of anything underneath packages), then in addition to the above please also include:

[ ] Change log from the last version integrated (this should be a link to commits for easy verification and review): example
[ ] Test Results: [link to CI job test results for component]
[ ] Code Coverage (if available): [link to code coverage report]

PLEASE FILL IN THE TEMPLATE ABOVE / DO NOT REMOVE ANY SECTIONS ABOVE THIS LINE
Instructions and Review Process
What is the review process and when will my changes land?
All PRs require 2 approvals using github's pull request reviews.
Reviewers should be:

Developers who understand the code being modified.
Developers responsible for code that interacts with or depends on the code being modified.

It is best to proactively ask for 2 reviews by @mentioning the candidate reviewers in the PR comments area. The responsibility is on the developer submitting the PR to follow-up with reviewers and make sure a PR is reviewed in a timely manner. Once a PR has 2 ship-it's, no red reviews, and all tests are green it will be included in the next train.

Updated the PR to remove zookeeper.out (Ref https://github.com/dcos/3dt/pull/84#issuecomment-278270815)

@darkonie Can you please review this ?

@surdy can you please open another PR for dcos-enterprise?

@darkonie I was waiting for this one to be reviewed so that I do not repeat the mistakes in both PRs if I make any.
I will go ahead an create the enterprise PR as well and let you know

🚢 when enterprise PR is ready. Also please paste a link to enterprise PR in the description.

Added the link to enterprise PR in description

@darkonie is there a way to specify "get these files on Masters only"
/var/lib/dcos/exhibitor/zookeeper/snapshot/myid and /var/lib/dcos/exhibitor/conf/zoo.cfg would not exist on agents.

@surdy yes, you can add here https://github.com/dcos/dcos/blob/master/packages/dcos-integration-test/extra/test_3dt.py#L532 and/or https://github.com/dcos/dcos/blob/master/packages/dcos-integration-test/extra/test_3dt.py#L535

@darkonie My question is not about the integration test, but the actual collection of files from the nodes.
When I specify files in LocalFiles is there a way to say this file if only to be collected from masters
/var/lib/dcos/exhibitor/zookeeper/snapshot/myid and /var/lib/dcos/exhibitor/conf/zoo.cfg would not be available on agents

@surdy ah sorry, yes you can add "Role": ["master"]
see example here https://github.com/dcos/dcos/blob/master/gen/dcos-config.yaml#L706
this should work for files as well.

Updated to include the files in integration test

@darkonie I made a couple of changes to make tests pass. Please review again. I have also updated https://github.com/mesosphere/dcos-enterprise/pull/576. But the enterprise repo does not seem to have test_3dt.py is that expected ?

@surdy looks good to me! Thanks

@darkonie @branden Can you please review and approve ?

@surdy you git approval from me 🚢

Oddly this still says review required. Do I need to do anything else to unblock this merge ?

It says review required because it hasn't been approved by someone with write permission on this repo yet. Now that it has two approvals and no outstanding rejections, it'll get pulled into the next merge train, and that train will eventually be approved by someone with write permission and merged.

@surdy - even this needs rebase + squash.


RiveRenderer is null

New project with Rive plugin only, cannot create Rive File asset, neither via drag'n'drop or context menu in content browser. Output log shows following:
LogRiveEditor: Error: RiveRenderer is null, unable to import the Rive file %my filepath%
or
LogRiveEditor: Error: RiveRenderer is null, unable to create and instance of the Rive file 'None'
Engine version is 5.3.2

Hi, it sounds like you are on an unsupported RHI. Could you check your Output window for warnings and errors? On Windows, we currently only support DirectX 11.
We are also planning to add a notification to make this clearer in the future.

Got it, thank you. Working almost perfectly with DX11, but have some issues with moving gradients (showing as flat color).
It's sad that this is the only DX11 supported, I'll wait for DX12 support


[590] Add RunCatalogSync utility for synchronizing tables across catalogs

Important Read

Please ensure the GitHub issue is mentioned at the beginning of the PR

What is the purpose of the pull request
Introduced RunCatalogSync utility which does the following on a high level. This unblocks the ability to sync tables from a source catalog to multiple target catalogs, you can look at the sample configuration here xtable-utilities/src/test/resources/catalogConfig.yaml
See RFC for more details on the deign and flow chart -> https://github.com/apache/incubator-xtable/pull/605
Brief change log
(for example:)

Add. ability to synchronize tables between source and target catalogs

Verify this pull request
(Please pick either of the following options)
This change added tests and can be verified as follows:
(example:)

xtable-utilities/src/test/java/org/apache/xtable/utilities/TestRunCatalogSync.java

I'm pushing another PR for the client side changes for CatalogSync.

After putting more though into it, I think we can keep the cross catalog sync as a separate function and not integrate it with TableFormatSync.

Start off with SourceCatalog.
User can choose multiple TargetCatalog and in each catalog there's an option to sync multiple table formats.
Syncs/Generates the table format metadata in storage first.
Syncs the table format metadata to TargetCatalog.

This will be separate utility option in RunSync to configure a catalogConfig.yaml file.

Moved this PR to: https://github.com/apache/incubator-xtable/pull/598

Hi @vinishjail97 ,  this PR seems to cover two distinct features: refactoring to add CatalogSyncClient and enabling syncing to multiple catalogs. The combination of these features might be contributing to the PR's size. What do you think about splitting the PR along these feature lines?

Hi @vinishjail97, This change significantly impacts XTable usage. The current description doesn't provide enough context for me. Could we set up a call or create a document to discuss this change in detail?

@ashvina I will create two separate PR's to avoid the confusion.

Interfaces for CatalogSyncClient and CatalogSync.
Integration  of catalog syncs in XTable conversion controller using RunCatalogSync.

We are not changing the way incremental sync works for table formats, the sync method in ConversionController still exists, the functionality of syncTableAcrossCatalogs is to synchronize the gap a table in source catalog to target catalog. If there's a need to tableFormat sync, we synchronize the table format first otherwise skip it. After that, the targetTable's metadata is synchronized to the target catalogs using the catalogTableIdentifier provided. I will add a small RFC document as well in the second PR for clarity.

@ashvina  I have split this change two PR's for clarity.

https://github.com/apache/incubator-xtable/pull/603
https://github.com/apache/incubator-xtable/pull/591

I will push the PR for an RFC doc for this tomorrow but have replied to most of your comments. Regarding the class CatalogTableIdentifier let's discuss on the RFC, if we have a compatibility matrix between CatalogTableIdentifier and the naming conventions for major catalogs documented users can easily understand.

@ashvina I have followed a three level naming convention for CatalogTableIdentifier and split the change into two PR's for clarity. There's also an RFC PR for the design, we can discuss more f2f in our scheduling meeting tomorrow.
https://github.com/apache/incubator-xtable/pull/605

Looks good to me overall but let's wait to merge until the RFC is finalized.


WIP: Apply field length normalisation to title in PostgreSQL search

This improves the ranking of results from PostgreSQL by increasing the score of matches on terms in the title if the title of the page is short. This has the effect of making more specific results rank higher than less specific ones.
TODO:

[ ] Test on more sites to make sure this factor is tuned correctly
[ ] Add some tests

@kaedroho  - just to keep on top of what needs triage, we are marking all WIP PRs as a draft

docstrings updated!


Youtube video page keeps reloading

Script version
5.0 - Updated today
Describe the bug
Youtube video page keeps reloading, example:
Video page opens, ads skipped, youtube warning blocks the screen, page reloads, repeats progress.
Expected behavior
Video plays normally
Screenshots

Desktop:

OS: Windows 10 (Updated today)
Browser: Chrome (Updated today)
Version 125.0.6422.142 (Official Build) (64-bit) (Updated today)

Additional context
I do not have other extensions or scripts turned on, it's just this one.

5.0测试有效果，请尝试清理浏览器缓存重新打开

Nevermind, it was a conflict of the script with Malwarebytes blocking ads & trackers.
Disabled Malwarebytes for Youtube. Working normally so far.


fix(http.js): handle string buffers in http

fixes https://github.com/epsagon/epsagon-node/issues/243

...I would add a test... :-)

...I would add a test... :-)

I promise to add - I just prefer to push first since this bug might affect other users

:tada: This PR is included in version 1.57.2 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


CASMINST-6606 add troubleshooting for ceph if haproxy.cfg has incorrect values for rgw

Description
Add troubleshooting steps if rgw-vip is not working. This could be due to an invalid haproxy.cfg file which is caused by rgw placement being set to '*'. This added documentation helps the user generate a new valid config.

Relates to: CAST-33719
Fixes: CASMINST-6606
Checklist

[x] If I added any command snippets, the steps they belong to follow the prompt conventions (see example).
[x] If I added a new directory, I also updated .github/CODEOWNERS with the corresponding team in Cray-HPE.
[x] My commits or Pull-Request Title contain my JIRA information, or I do not have a JIRA.

/backport release/1.5

/backport release/1.4

/backport release/1.3


Can't change source of video

Behavior looks like https://github.com/twilio/twilio-video-app-react/issues/423.
We need to use our external user.displayName and roomName. We can't change the video input device in that case.
To Reproduce
We can use mocked data (in src\components\PreJoinScreens\PreJoinScreens.tsx):

Steps to reproduce the behavior:

Go to page with choosing device:

Check, that your video is turned off.

Open Settings -> Audio and Video settings.

You will no initial value in video input device:

Changing video device is useless, we can't change it:

Expected behavior
We have an initial value in the video input device.
We can change the value in the video input device.
Real behavior
We have no initial value and we can't change it.
Environment:
OS: Windows 10
Browser: Chrome Version 88.0.4324.150 (Official Build) (64-bit)
App Version: 0.2.1
Twilio-video: 2.9.0
Node.js version: 14.15.1

Thanks for the question @artem-gorokhovskii!
I can confirm the issue that you described. I just released version 0.2.3 of this app which contains a fix that should help you out. The fix lets users change their video device while their camera is off.
More information (and a gif) in the pull request here: #412
I hope it fixes your issue! Please let me know. Thanks!

@timmydoza thank you for your response!
Tested in 0.2.3.
Initially, it doesn't have a pre-selected device:

We can make a choice (previously we can't):

Start video - video from another video input (not one which I've chosen):

We don't have a pre-selected video input device, but we can change it, but it doesn't change the real video input source.
But we also have the behavior of the next bug, which also reproducing on 0.2.3: https://github.com/twilio/twilio-video-app-react/issues/425

Thanks for the additional information @artem-gorokhovskii!
I'm going to close this issue. It is very similar to #425, so this issue feels like a duplicate. We will be working on a fix though (just look at #425 for the status of the fix).


[FBX] Memory leak when importing fbx model

Godot version:
3.2.4.beta.custom_build. 7dfd4ced5
OS/device including version:
Ubuntu 20.04
Issue description:
When I import minimal project then I got this leak
Direct leak of 200192 byte(s) in 3128 object(s) allocated from:
    #0 0x7f3cc5ccaf17 in operator new(unsigned long) (/lib/x86_64-linux-gnu/libasan.so.6+0xb1f17)
    #1 0x3e5244f in FBXDocParser::FbxPose::FbxPose(unsigned long, FBXDocParser::Element*, FBXDocParser::Document const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) modules/fbx/fbx_parser/FBXPose.cpp:94
    #2 0x3d542f0 in FBXDocParser::LazyObject::LoadObject() modules/fbx/fbx_parser/FBXDocument.cpp:156
    #3 0x2ccea22 in FBXDocParser::FbxPose const* FBXDocParser::LazyObject::Get<FBXDocParser::FbxPose>() modules/fbx/fbx_parser/FBXDocument.h:94
    #4 0x2c8d509 in EditorSceneImporterFBX::_generate_scene(String const&, FBXDocParser::Document const*, unsigned int, int, int) modules/fbx/editor_scene_importer_fbx.cpp:539
    #5 0x2c863b4 in EditorSceneImporterFBX::import_scene(String const&, unsigned int, int, List<String, DefaultAllocator>*, Error*) modules/fbx/editor_scene_importer_fbx.cpp:154
    #6 0x7027da4 in ResourceImporterScene::import(String const&, String const&, Map<StringName, Variant, Comparator<StringName>, DefaultAllocator> const&, List<String, DefaultAllocator>*, List<String, DefaultAllocator>*, Variant*) editor/import/resource_importer_scene.cpp:1320
    #7 0x5b0b18e in EditorFileSystem::_reimport_file(String const&) editor/editor_file_system.cpp:1798
    #8 0x5b16786 in EditorFileSystem::reimport_files(Vector<String> const&) editor/editor_file_system.cpp:1996
    #9 0x5ad34ac in EditorFileSystem::_update_scan_actions() editor/editor_file_system.cpp:589
    #10 0x5aed26d in EditorFileSystem::_notification(int) editor/editor_file_system.cpp:1174
    #11 0x5b268d5 in EditorFileSystem::_notificationv(int, bool) (/usr/bin/godots+0x5b268d5)
    #12 0xe78b563 in Object::notification(int, bool) core/object.cpp:929
    #13 0x9577333 in SceneTree::_notify_group_pause(StringName const&, int) scene/main/scene_tree.cpp:985
    #14 0x9567bf5 in SceneTree::idle(float) scene/main/scene_tree.cpp:525
    #15 0x1539ba4 in Main::iteration() main/main.cpp:2103
    #16 0x142d3ac in OS_X11::run() platform/x11/os_x11.cpp:3410
    #17 0x139eb56 in main platform/x11/godot_x11.cpp:56
    #18 0x7f3cc48040b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

Steps to reproduce:
Compile Godot with sanitizers support
scons p=x11 use_asan=yes -j8

run with it help minimal project
Minimal reproduction project:
https://github.com/godotengine/godot/files/5590346/fbx_bug_project.zip

My plan is to move all FBX objects to an explicit cleanup step. The existing parser has some weird edge cases like this where it can leak in some cases due to the poor ownership of data in the assimp parser.
This is on my list already to sort but it most likely will be next week.

Leak is gone in latest release but the files are blocked by:
"We can't import blender FBX files, they're not implemented correctly at export time and would require several hacks in the FBX importer which could break Maya imports."

#44402 blender support tracker


Average I/O size for source disk

The Table under Azure Site Recovery Limits lists Average I/0 for source disk as a factor in how much churn is allowable for certain sizes and tiers of disk, yet no explanation is given as to locate this piece of information for a specific disk. For Preumium P10 or P15 disks, this can greatly affect the amount of allowable churn.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 626f4eb0-576e-cc98-6d59-45bb776a222c
Version Independent ID: 5bbbb2c5-10f0-39f4-df8d-da2b0cdce567
Content: Troubleshoot replication of Azure VMs with Azure Site Recovery - Azure Site Recovery
Content Source: articles/site-recovery/azure-to-azure-troubleshoot-replication.md
Service: site-recovery
GitHub Login: @sideeksh
Microsoft Alias: v-ssenthilna

Thanks for bringing this to our attention. We will investigate it further and update you shortly.

@ianc911 - You can track the I/Os on the Metrics page for the VM. Please take a look at this document - https://docs.microsoft.com/en-us/azure/virtual-machines/disks-metrics
Hope this helps.
At this moment, since there is no doc update required, we will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

Hi Monika, this doc lists "Average I/O size for source disk" as one of the parameters for a disk. It is measured in KB. This metric can affect the allowable churn on a P10 or P15 disk by a factor of 4: 8KB -> 2 MB/s & 32 KB -> 8 MB/s. Nowhere on this page, on the metrics page for a VM, or in the document you link to is this parameter mentioned. If you don't want to include that information in the document or describe how to find it, fine. Just trying to help...


Fix broken link (wiki links don't work outside wiki)

Just noticed there is also a docs/The-Configure-Block.md file, so not sure which one should be linked.
Anyhow this is how the page looks when one navigates from the security advisory (https://jenkins.io/security/advisory/2017-04-10/)

replaced by https://github.com/jenkins-infra/jenkins.io/pull/823


automatic refresh interval for Sessions and Locks Editor

Especially when someone want to monitor open locks or sessions it is quite annoying to constantly press F5 in order to refresh the table view. Therefore there should be a Combobox to choose the refresh interval rate, e.g. manual (default), 1s, 5s, 10s

+1

Auto-refresh for sessions and locks will be added in 5.0:

Thx!

This is great!  Thank you!
The feature works wonderfully in my testing.  I would just personally change "Refresh each X seconds" to "Refresh every X seconds".  The English sounds better that way.

Yep.
This will be fixed as a part of #2050


unvendor urllib in exceptions class

According to

https://botocore.amazonaws.com/v1/documentation/api/latest/index.html#upgrading-to-1-11-0
https://github.com/boto/botocore/issues/1248

urllib has been unvendored and should not be used any more.  In the exceptions class however there's still a reference to it I found with
grep -r import .| grep urllib3  | grep botocore.vendored

this patch removes the urllib vendoring in the exceptions class.  Maybe rules like the grep above should also be added to the CI to ensure that all deprecated vendored classes stay removed?

Thanks for the PR, @mikedlr. While we did remove the majority of the vendored code, we still provide exceptions from this folder. In order to maintain consistency in existing code, we're going to leave this reference for now. In a future version, we may revisit this change if our stance on the current vendoring changes.


nil pointer evaluating *models.GPGKey.KeyID

Gitea version (or commit ref): 1.11.4
Git version: N/A
Operating system: CentOS
Database:

[ ] PostgreSQL
[X] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[X] No
[ ] Not relevant

Description
When I click on an unsigned commit, I get a 404 with the message:

template: repo/commit_page:90:57: executing "repo/commit_page" at <.Verification.SigningKey.KeyID>: nil pointer evaluating *models.GPGKey.KeyID

You can try this URL as an example:
https://git.ki9.us/keith/compass/commit/81fd585e84edfa517b780ad52b9555b582e7d36b
I can't reproduce it on the demo site, so it must be an issue with my implementation.
I'm running Gitea on Uberspace, according to these instructions.

Is it possible you're using custom templates? Your templates might be outdated.

It will be a minute before I can look at this again.

Sigh - go templates don't shortcut  ifs. Sorry about this.

Sorry it also took me so long to recognise that this was the problem.


Added info() in Trainer

Pull Request
Description
Added a method info() to print training properties before model training actually begins.
Changes

Added info() method in the Trainer class (trainer.py)
Call self.info() in the train function in the Trainer class

Related Issues
Resolves #120
Checklist

[x] I have read and followed the project's contributing guidelines.
[x] My code follows the project's coding style.
[x] I have tested my changes thoroughly.
[x] My changes do not introduce any new warnings or errors.

@SSBakh07 Great job Sheeda jan, I'm reviewed the changes and commented some minor points. It'd be great if you could resolve them. Thanks.


HDDS-8478. ScmRoles intellij runconfig SCM HA support not working.

What changes were proposed in this pull request?
Patch for intellij runconfiguration ozone admin ScmRoles command as part of the HA support for ide dev environment.  Corrects module configured in runConfiguration from using hdds-tools to ozone-tools where the ozone admin scm roles subcommand is supported.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8478
How was this patch tested?
Tested with HA intellij ide environment.  Running the runconfiguration with this patch correctly runs the ozone admin scm roles command:
localhost:29894:LEADER:71dd8970-6188-485c-bf6b-9256350de932:<IP_ADDRESS>
localhost:39894:FOLLOWER:0a2be95e-8f36-4260-a45a-668265be95bd:<IP_ADDRESS>
localhost:19894:FOLLOWER:a6a058e8-5a16-415e-a4c6-476760981b52:<IP_ADDRESS>

Process finished with exit code 0

Thanks @neils-dev for the fix.


No. of uploads shown is zero after logging in app

No. of uploads on Actionbar remains to 0 on logging in the app even when I have stored many images before.
How can we reproduce the issue?

Login to the app and make sure you have uploaded photos previously.
No. of uploads remains at zero.

Tested On: Xiaomi Redmi Note 4
Android Version: 7.0
Commons app version: 2.7.1-debug-master~8a06aa5
Screen-shots:

Would you like to work on the issue?
I would love to work on this issue.

betaDebug

AFAIK, this is a known issue on beta due to incompatibility of the API that we use for obtaining number of uploads. :)

Fixed in #1265


Homepage look and feel

Would consider adding an image of food or something to jazz it up a bit. Megan W has an image library that you could pull from.

currentImages.pdf
I was only able to find a handful of images that showcased foods from different food groups together. Many of the images that I came across focused on a single group such as fruits or vegetables. I will keep looking for additional images.

Maybe you can make a collage of a few of them?
From: Megan Wakayama<EMAIL_ADDRESS>Sent: Monday, June 29, 2015 8:34 AM
To: ArdentMC/openFDA-Prototype
Cc: Amy Rosen
Subject: Re: [openFDA-Prototype] Homepage look and feel (#45)
currentImages.pdfhttps://github.com/ArdentMC/openFDA-Prototype/files/364/currentImages.pdf
I was only able to find a handful of images that showcased foods from different food groups together. Many of the images that I came across focused on a single group such as fruits or vegetables. I will keep looking for additional images.
—
Reply to this email directly or view it on GitHubhttps://github.com/ArdentMC/openFDA-Prototype/issues/45#issuecomment-116788800.

This email and any files transmitted with it may contain confidential, sensitive, and/or proprietary information which is exempt from disclosure under applicable law (Computer Fraud and Abuse Act of 1986 (18 USC 1030) and The Privacy Act, (5 USC 552). It is meant solely for the intended recipient. If you are not the intended recipient, any disclosure, copying, distribution, or any action taken or omitted in reliance on this, is prohibited and may be unlawful. If you received this message in error, please notify the sender immediately and delete the material in its entirety.

Here is what I have created for the food collage. I can take some of the images out if it is too overwhelming with all the food and colors.

I like it!!!

So if we have time I would like to incorporate this into our home page somehow any thoughts from people? Let’s talk during out meeting today we don’t have much time.
From: Eugene T. Staten II<EMAIL_ADDRESS>Sent: Tuesday, June 30, 2015 2:56 AM
To: ArdentMC/openFDA-Prototype
Cc: Amy Rosen
Subject: Re: [openFDA-Prototype] Homepage look and feel (#45)
I like it!!!
—
Reply to this email directly or view it on GitHubhttps://github.com/ArdentMC/openFDA-Prototype/issues/45#issuecomment-117167118.

This email and any files transmitted with it may contain confidential, sensitive, and/or proprietary information which is exempt from disclosure under applicable law (Computer Fraud and Abuse Act of 1986 (18 USC 1030) and The Privacy Act, (5 USC 552). It is meant solely for the intended recipient. If you are not the intended recipient, any disclosure, copying, distribution, or any action taken or omitted in reliance on this, is prohibited and may be unlawful. If you received this message in error, please notify the sender immediately and delete the material in its entirety.


Update emitting status on one-shot particles

Fixes: https://github.com/godotengine/godot/issues/21794 and https://github.com/godotengine/godot/issues/17903
Updates emission to reflect that one_shot sets it to false at end of shot.

@akien-mga Updated. :)
I ended up adding more logic than I would like, but now we will avoid any situation where we might accidentally set internal process and not be able to turn it off.

Thanks!


Distance weighted margin loss

Hi, I wonder if you also tried the distance weighted margin loss specified in Sampling Matters in Deep Embedding Learning.
I see you have the sampling scheme applied to deviance loss. I wonder why?

Sorry for late response.
I have tried to do this. But now I only have implemented the distance weighted  sampling for negative pairs in a different way compared with the article . I have not  implemented the Dynamic margin.


instagram blocked since 2am

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2019.11.05
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

youtube-dl -v https://www.instagram.com/daily.memes/
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.instagram.com/daily.memes/']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.11.05
[debug] Python version 3.7.4 (CPython) - Darwin-19.0.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.2.1, ffprobe 4.2.1, rtmpdump 2.4
[debug] Proxy map: {}
[instagram:user] daily.memes: Downloading webpage
[download] Downloading playlist: daily.memes
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl", line 10, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.7/site-packages/youtube_dl/__init__.py", line 474, in main
    _real_main(argv)
  File "/usr/local/lib/python3.7/site-packages/youtube_dl/__init__.py", line 464, in _real_main
    retcode = ydl.download(all_urls)
  File "/usr/local/lib/python3.7/site-packages/youtube_dl/YoutubeDL.py", line 2018, in download
    url, force_generic_extractor=self.params.get('force_generic_extractor', False))
  File "/usr/local/lib/python3.7/site-packages/youtube_dl/YoutubeDL.py", line 807, in extract_info
    return self.process_ie_result(ie_result, download, extra_info)
  File "/usr/local/lib/python3.7/site-packages/youtube_dl/YoutubeDL.py", line 968, in process_ie_result
    ie_entries, playliststart, playlistend))
  File "/usr/local/lib/python3.7/site-packages/youtube_dl/extractor/instagram.py", line 262, in _extract_graphql
    variables.update(self._query_vars_for(data))
  File "/usr/local/lib/python3.7/site-packages/youtube_dl/extractor/instagram.py", line 392, in _query_vars_for
    'id': data['entry_data']['ProfilePage'][0]['graphql']['user']['id']
KeyError: 'ProfilePage'

Description

Blocked from downloading from instagram for 17 hours now. Can still access the content on smart phones and web browsers. Blocked after heavy downloading of videos. It happens often but doesn't usually last this long? I thought it might be an IP block but can still access instagram on desktop and mobile device. You may not be able to recreate this error without downloading a LOT of content! It does happen sometimes but never for this long? Can't understand it because it feels like an IP ban yet can still access on desktop and devices. HELP!

Not sure if this helps, but, I've just tried it with instaloader and it says it's caused by error 429 too many requests and is redirecting to login so it's obviously caused by too many downloads; it just usually resets after a few hours but on this occasion has not reset after almost a day.
This explains why you'd would not be able to recreate the error without a lot of downloads.


zulip-botserver: Allow passing config via environment variables

Fixes #485

@timabbott, or @showell  can you please take a look at this PR

@LoopThrough-i-j Thanks for working on this!  I appreciate that you took the time to write tests here.
I am not sure having the parallel comma-separated lists of values here is ideal.  I wonder if there's a better way to represent hierarchical data in environment variables.
I think we need to wait and see what Tim says here.  (He and his wife just welcomed a baby into the world, so he's gonna be pretty busy for the next couple weeks, so apologies in advance if this doesn't get reviewed for a while.)

Not a problem, thanks for the reply.

I agree with the concern about comma-separated values in environment variables.
I'm not convinced that it's worth supporting multiple bots with this environment variables model; if we did, probably it'd be better to just have each bot under a prefix (E.g. GIPHY_ZULIP_BOT_EMAIL or something like that) and pass which prefixes to look for on the command line.
@pirate FYI for thoughts on that question.

I don't mind CSV strings personally, but a reasonable alternative is requiring proper json strings and just using json.loads (like ZULIP_CUSTOM_SETTINGS).

Thanks for the reply, I agree with JSON strings as well, will update the pr soon.

@pirate what do you think. Does it look fine🙂?

looks awesome, thanks for this work @LoopThrough-i-j!

looks awesome, thanks for this work @LoopThrough-i-j!

No problem looking forward to work more.

@timabbott can you please merge this if it is done.

I haven't tested this or read it thoroughly, but the overall approach seems reasonable now.  Is there a place in the readme that we should be updating too?

I haven't tested this or read it thoroughly, but the overall approach seems reasonable now. Is there a place in the readme that we should be updating too?

The readme does not talk about the new feature, of passing config via environment variables. Then the docs will need an update as well.

@alexmv Thanks a lot for the suggestions. Can you please take a look if everything looks good?
The checks fail because in python 3.5 a random bot is chosen to replace the name instead of the 1st one. For some reason, Ordered Dict is not working.
Can you help to improve or shall I remove the test for checking the 1st python bot is replaced while using the environment variables?
Thanks a lot in advance.

This looks pretty good! Just a few minor cleanups.
Did you have any luck tracking down the Python 3.5 problem?

I tried a lot of things out even printing down types and trying to find out leakages, but nothing worked(Stackoverflow couldn't help as well). Later, I decided to drop the test for python3.5 and the test happens only for python3.6 or higher.

@alexmv what do you think

The checks fail because in python 3.5 a random bot is chosen to replace the name instead of the 1st one. For some reason, Ordered Dict is not working.

I didn't run this locally but I think this maybe the reason:-
In the docs for json.load it is mentioned: All optional parameters are now keyword-only.
And in the OrderedDict docs, it is mentioned:
Changed in version 3.6: With the acceptance of PEP 468, order is retained for keyword arguments passed to the OrderedDict constructor and its update() method.

@timabbott can you please take a look at this PR

Using object_pairs_hook=list to preserve the order is an interesting solution, that nicely steps around the OrderedDict problem.  Since it's not necessarily completely intuitively obvious, I think it probably deserves extending the comment above it about "the first bot" that we re-parse to extract key order, in order to support Python 3.6 and before, since 3.7 and later would preserve key ordering information.
Otherwise, this is looks in great shape -- sorry for the long delay in the review!

Using object_pairs_hook=list to preserve the order is an interesting solution, that nicely steps around the OrderedDict problem.  Since it's not necessarily completely intuitively obvious, I think it probably deserves extending the comment above it about "the first bot" that we re-parse to extract key order, in order to support Python 3.6 and before, since 3.7 and later would preserve key ordering information.
Otherwise, this is looks in great shape -- sorry for the long delay in the review!

Using object_pairs_hook=list to preserve the order is an interesting solution, that nicely steps around the OrderedDict problem. Since it's not necessarily completely intuitively obvious, I think it probably deserves extending the comment above it about "the first bot" that we re-parse to extract key order, in order to support Python 3.6 and before, since 3.7 and later would preserve key ordering information.

sure will fix the issue and will be working on my next PR! btw the tests fail for now, will it be fine I take the responsibility to migrate it to Github actions.

Using object_pairs_hook=list to preserve the order is an interesting solution, that nicely steps around the OrderedDict problem. Since it's not necessarily completely intuitively obvious, I think it probably deserves extending the comment above it about "the first bot" that we re-parse to extract key order, in order to support Python 3.6 and before, since 3.7 and later would preserve key ordering information.

sure will fix the issue and will be working on my next PR! btw the tests fail for now, will it be fine I take the responsibility to migrate it to Github actions.

btw the tests fail for now, will it be fine

If the tests are still failing, that means the workaround of using list isn't working -- so no, that's not fine.
I installed python 3.5 myself to investigate, by putting some print statements into the test and running it several times.  What jumped out is that the order of the list was still changing!  So I added a print statement for the environment variable itself that was being fed into the test.  Which showed that the problem isn't actually that the OrderedDict trick doesn't work during loading on 3.5 -- it's that we're using json.dumps to construct the JSON we put in the environment, which is unordered on Python 3.5, so we're feeding the program unreliable input!
The fix is to swap back to the much less hacky OrderedDict, and also to use that in the tests to make sure we pass in a consistent value for the environment variable.  With that in place, tests pass consistently on 3.5, and later.  I've pushed a commit that does this, as well as add some documentation.

will it be fine

Tests should always pass.  In general, it's not a good idea to break functionality, even if you're planning on coming back and to fix it later -- particularly not when just adding new features, like this.  If tests are failing when someone arrives at a project, folks will assume that any failure is probably not due to their commit, and thus failures (including real important ones!) will accumulate over time.  Keeping confidence that tests don't lie is really important.

I take the responsibility to migrate it to Github actions.

I'd love to take you up on migrating to Github Actions, however!   But let's do that in a separate PR.

btw the tests fail for now, will it be fine

If the tests are still failing, that means the workaround of using list isn't working -- so no, that's not fine.
I installed python 3.5 myself to investigate, by putting some print statements into the test and running it several times.  What jumped out is that the order of the list was still changing!  So I added a print statement for the environment variable itself that was being fed into the test.  Which showed that the problem isn't actually that the OrderedDict trick doesn't work during loading on 3.5 -- it's that we're using json.dumps to construct the JSON we put in the environment, which is unordered on Python 3.5, so we're feeding the program unreliable input!
The fix is to swap back to the much less hacky OrderedDict, and also to use that in the tests to make sure we pass in a consistent value for the environment variable.  With that in place, tests pass consistently on 3.5, and later.  I've pushed a commit that does this, as well as add some documentation.

will it be fine

Tests should always pass.  In general, it's not a good idea to break functionality, even if you're planning on coming back and to fix it later -- particularly not when just adding new features, like this.  If tests are failing when someone arrives at a project, folks will assume that any failure is probably not due to their commit, and thus failures (including real important ones!) will accumulate over time.  Keeping confidence that tests don't lie is really important.

I take the responsibility to migrate it to Github actions.

I'd love to take you up on migrating to Github Actions, however!   But let's do that in a separate PR.

Thanks a lot for your help and detailed comment and for mentoring me throughout the PR. I would love to work on the migration of tests to GitHub actions. Thank you once more for helping me to become a better developer.

Thanks a lot for your help and detailed comment and for mentoring me throughout the PR. I would love to work on the migration of tests to GitHub actions. Thank you once more for helping me to become a better developer.