Any way to specific op name when I use saved_model

Please make sure that this is a bug. As per our
GitHub Policy,
we only address code/doc bugs, performance issues, feature requests and
build/installation issues on GitHub. tag:bug_template
System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device:
TensorFlow installed from (source or binary):binary
TensorFlow version (use command below):2.2
Python version:
Bazel version (if compiling from source):
GCC/Compiler version (if compiling from source):
CUDA/cuDNN version:
GPU model and memory:

You can collect some of this information using our environment capture
script
You can also obtain the TensorFlow version with:

TF 1.0: python -c "import tensorflow as tf; print(tf.GIT_VERSION, tf.VERSION)"
TF 2.0: python -c "import tensorflow as tf; print(tf.version.GIT_VERSION, tf.version.VERSION)"

Describe the current behavior
The saved model will override the op name which I specific in graph
Describe the expected behavior
Saved model save the op names that I specific
Standalone code to reproduce the issue
Provide a reproducible test case that is the bare minimum necessary to generate
the problem. If possible, please share a link to Colab/Jupyter/any notebook.\
https://colab.research.google.com/drive/16kZkauTJwAkUZTsM4UoxtyHz2TuV9rXe
The input op name should be 'input'
The output op name should be 'test'
Current implementation:
input op: serving_default_input
output op: PartitionedCall:0 PartitionedCall:1
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

I have tried in colab with TF version 2.2, 2.3-rc1 ,nightly versions(2.4.0-dev20200719) and was able to reproduce the issue.Please, find the gist here.Thanks!

Was able to reproduce this issue using TF-nightly v2.6.0-dev20210526 ,please check the gist here..Thanks !

Hi,
Thank you for opening this issue. Since this issue has been open for a long time, the code/debug information for this issue may not be relevant with the current state of the code base.
The Tensorflow team is constantly improving the framework by fixing bugs and adding new features. We suggest you try the latest TensorFlow version with the latest compatible hardware configuration which could potentially resolve the issue. If you are still facing the issue, please create a new GitHub issue with your latest findings, with all the debugging information which could help us investigate.
Please follow the release notes to stay up to date with the latest developments which are happening in the Tensorflow space.


make terminal selection automatically focus on selected terminal after selection

There are certain panes in workspace layout does not keep to retrain focus, one of them is terminal selection. When I do things in a hurry, I may click on a terminal, to expect the focus is on associated terminal window, not the selection pane.

What actually happens is that when I click on a terminal name, the focus is on the selection pane, I have to click on terminal window itself to start use keyboard to write command.

Did you experiment with the terminal.integrated.tabs.focusMode setting?

Hi @yifan, you can set the terminal.integrated.tabs.focusMode to singleClick to achieve the desired behaviour (it is set to doubleClick by default). Hope that helps 🤗


Update to angular 1.4 from 1.3 got Uncaught Error: [$injector:unpr] Unknown provider: $$cookieReaderProvider

I got error when I upgraded angular to 1.4 from 1.3. I updated angular-cookies to 1.4 as well. I'm using
"angular-translate": "~2.8.1",
"angular-translate-loader-partial": "~2.8.1",
"angular-translate-storage-local": "~2.8.1",
"angular-translate-storage-cookie": "~2.8.1"

source code:
$translateProvider
    .useLoader('$translatePartialLoader', {
        urlTemplate: '/i18n/{part}.{lang}.json'
    })
    .useSanitizeValueStrategy('escape')
    .fallbackLanguage('en')
    .preferredLanguage('zh')
    .useLocalStorage();

The error details:
Uncaught Error: [$injector:unpr] Unknown provider: $$cookieReaderProvider <- $$cookieReader <- $cookies <- $cookieStore <- $translateCookieStorage <- $translateLocalStorage <- $translate <- $cookies

@snowcxt Your dependency lookup path shows you the problem is not related to angular-translate, but ->$cookies->$cookieReader.
I would guess you either have no angular-cookiesloaded or it is not matched the corresponding version with angular.

Here's the index.html:
<script src="bower_components/angular/angular.js"></script>
<script src="bower_components/angular-cookies/angular-cookies.js"></script>
<script src="bower_components/angular-translate/angular-translate.js"></script>
<script src="bower_components/angular-translate-loader-partial/angular-translate-loader-partial.js"></script>
<script src="bower_components/angular-translate-storage-cookie/angular-translate-storage-cookie.js"></script>
<script src="bower_components/angular-translate-storage-local/angular-translate-storage-local.js"></script>

the bower.json
"angular": "~1.4.7",
"angular-cookies": "~1.4.7",

and also I remove the bower_components folder and runbower install
the app.js
angular
    .module('app', [
        'pascalprecht.translate',
        'ngCookies',
        // something else ...
    ])

Is there anything else I have to check?

Then you have locally cached something. I've replayed, works as expected: https://gist.github.com/knalli/0b15198e1bf4eab780d6

I would recommend to check the versions you are actually using. Perhaps bower has not replaced correctly?

I went into the bower_components folder and check the package.json of angular and angular-cookies. They are version 1.4.7
  "name": "angular",
  "version": "1.4.7",
  "description": "HTML enhanced for web apps"

  "name": "angular-cookies",
  "version": "1.4.7",
  "description": "AngularJS module for cookies"

BTW, I just degraded to use angular-cookies 1.3. Now everything works.
"angular": "~1.4.7",
"angular-cookies": "~1.3.20",

@snowcxt  Can you checkout my gist?

Can you send me the link?

See here https://github.com/angular-translate/angular-translate/issues/1292#issuecomment-156217300

It works for me. Do you have any recommendations for me to clean the local cache?

Bower cache clean will be your friend, goto man ;)
However, if my mini project is working for you, it does not look like a cache issue. Exzept you have configured a local cache...


Update jaxb and jax-rs libs

Search before asking

[X] I searched in the issues and found nothing similar.

Motivation
Is there any plan to update Jaxb and JaxRS libs (from javax.* to jakarta.*)?
When using the Pulsar admin client 2.11.0 in a modern application that is using the more recent versions of Jaxb and JaxRS, the recent versions are the ones used. This may lead to confusion. The only reason it is working in this case is because the elder jaxb-api is still carried along that has the old annotations.
Solution
BUMP jakarta.ws.rs:jakarta.ws.rs-api from 2.1.6	to 3.1.0
BUMP jakarta.xml.bind:jakarta.xml.bind-api from	2.3.3 4.0.0
Remove javax.xml.bind:jaxb-api:2.3.1
Update all code references from javax.* to jakarta.*
Alternatives
No response
Anything else?
No response
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

IIRC @Shoothzj started a discussion similar to what is proposed here at: https://lists.apache.org/thread/74cq2tyt3h62tgop61br9w3rgwqtlcvm
cc @nodece @eolivelli shall we make an explicit consensus (vote) on this upgrade, or just proceeding this issue?

I have two ideas:

Migrate to jakarta.* from javax.* in the<EMAIL_ADDRESS>Could you try to use the pulsar-client-admin-shaded in your project?

Hi @nodece ,

Migrate to jakarta.* from javax.* in the<EMAIL_ADDRESS>

Agreed. This is what I was referring to in the Solution section.

BUMP jakarta.ws.rs:jakarta.ws.rs-api from 2.1.6 to 3.1.0
BUMP jakarta.xml.bind:jakarta.xml.bind-api from 2.3.3 4.0.0
Remove javax.xml.bind:jaxb-api:2.3.1
Update all code references from javax.* to jakarta.*

And 3.0.0 sounds like the proper vehicle for that significant change.

Could you try to use the pulsar-client-admin-shaded in your project?

I am using pulsar-client-all which has the same effect.
On a positive note, I believe 2.11 did increase these libs being shaded (from 2.10.x). The only one that is not shaded is the  javax.xml.bind:jaxb-api:2.3.1.
I would be satisfied w/ making the upgrade (and move to jakarta.*) in 3.0.0 and I can live w/ the 2.11.0 containing javax for now. It mostly triggering "prohibited classpath compatibility" checks on some apps.

Hi @onobc! From the mailing list thread @Shoothzj raised an issue that Spring Boot 2.x are still using the package name "javax". I found that you opened this issue due to add Pulsar to Spring Boot 3.x in https://github.com/spring-projects/spring-boot/pull/34763. What do you think of this compatibility issue?

Hi @tisonkun ,
If the libs are all shaded it should not matter what version is used by the admin client - they are effectively invisible.
IIRC, the only remaining unshaded lib in 2.11.0+ is javax.xml.bind:jaxb-api:2.3.1.
In general, shading the libs that the admin client is using to do its job is the only safe (and most flexible) answer IMO. Otherwise, if the admin client exposes a popular lib(s) then we will immediately be in this JEE/SpringBoot/Java version matrix madness where we would have tradeoffs such as "If you want to use Pulsar 3.x then you have to use Spring Boot 3.x" etc..
I do think a helpful requirement (exit criteria) for this ticket would be to make sure that whatever solution we land on, that Spring Boot 2.x users can use both Pulsar client 2.x and 3.x. An example could be as follows:

SB 2.7.x simple app using Jersey (could bootstrap here).
In a user defined Jersey component (controller or endpoint) use admin client to query topics/namespaces and create topics etc.. Do this w/ both admin client 2.x and 3.x.
In a user defined non-Jersey component (ApplicationRunner, Service, Bean, anything else that is not Jersey specific) use admin client to query topics/namespaces and create topics etc.. Do this w/ both admin client 2.x and 3.x.

Thanks for pinging me and bringing this up.

For 3.0.0, the schedule is set as:

2023-04-11 - RC-1
2023-04-18 - RC-2
2023-04-25 - RC-3
2023-05-02 - Announce 3.0 Release

You can subscribe to<EMAIL_ADDRESS>for updates. For example, RC-1 is out at https://lists.apache.org/thread/jf0zrb84j9sj7106jyd9gqlw1rcp6k4m

Can we get this issue in as well

Given the schedule above, I'm afraid that we're already code freeze. Anyway, we share a volunteer-based community so it still need a volunteer to find time and take it over.

Maybe I can cc the release manager @RobertIndie @poorbarcode @cbornet here for advice. This can impact how users integrate with 3.0.0 but I understand that we don't have too much time now following the time-based release cycle.

Thanks for the info @tisonkun ,
If it comes down to just finding a resource to implement I could probably volunteer for that as this is quite important to our usage of the client.

Hi @onobc, I made https://github.com/apache/pulsar/pull/20106 to fix this issue, could you confirm this PR?


Geometry::is_point_in_triangle returns false on triangle borders

Godot version:
Tested in 3.2.3, however it can safely be assumed that issue exists in both 3.2 and master given that the implementations, while in different files (geometry.h in 3.2 and geometry_2d.h in master), are functionally identical.
Issue description:
Geometry::is_point_in_triangle is a function exposed through Geometry.point_is_in_triangle. It's a basic triangle intersection test, however the test fails when the tested point lies on the edge or corners of the triangle. While it could be argued that "in" and "on" are distinct cases, the function is used internally in a few places (including pathfinding, which is how I discovered the issue in the first place), and in those cases the author seems to assume that the test does include points on the triangle's boundaries. In addition, Geometry::is_point_in_circle is a much simpler function which does return true for points on the extents, so presumably it's intended to be a straight intersection test.
Steps to reproduce:
The following GDScript demonstrates the problem and should run when attached to a node. All test fail except the last one:
extends Node

func _ready():
    # Points
    var a = Vector2(1.0, 0.0)
    var b = Vector2(0.0, 1.0)
    var c = Vector2(0.0, 0.0)

    # Corners
    print(Geometry.point_is_inside_triangle(a, a, b, c))
    print(Geometry.point_is_inside_triangle(b, a, b, c))
    print(Geometry.point_is_inside_triangle(c, a, b, c))

    # Edges
    print(Geometry.point_is_inside_triangle((a + b) / 2.0, a, b, c))
    print(Geometry.point_is_inside_triangle((b + c) / 2.0, a, b, c))
    print(Geometry.point_is_inside_triangle((c + a) / 2.0, a, b, c))

    # Center
    print(Geometry.point_is_inside_triangle((a + b + c) / 3.0, a, b, c))

Further Investigation:
I believe the initial implementation came from the comments of #16495 (here specifically) and advises replacing occurrences of > within the implementation with >= in order to include the boundaries in the test. My own attempts at implementing the function seemed to confirm this, but my testing process was not rigorous.

This was discovered in https://github.com/godotengine/godot/pull/44274#issuecomment-748492353, should likely be fixed to have non-strict comparison then, for consistency with other geometry functions (see #26615).


[Suggestion] Adjust the default cast timer depending on if you have Chum active or not

Would it be possible to adjust the default cast time window for Chum? A fish with a 2s-12s window for example will take about five seconds less to max out when you're using chum, however, the plugin isn't taking that into consideration and you're often wasting those extra seconds.

Sorry for the delay. I've added this in the newest version.


Not working with ngAnimate

If i use the module ngAnimate für Angular the table will be duplicated whenever i trigger a update. But you can see it only while rendering during few ms. How to use a animation? For example to update one field and to show some color flush on value changed. Like finance values does

I am facing the same issue. Any idea if a fix is planed ?

I don't think so, unless someone sends a PR

I will have a look myself then. Any pointers (guesses) where to look to help me start ?

Unfortunately i have no experience with Angular :cry:


[Telegram] Incorrect type of updateId

There is incorrect type for updateId in type Update, it should be number.
Prof: https://core.telegram.org/bots/api#update

This has been fixed by https://github.com/Yoctol/messaging-apis/pull/623.


Decode exactly completed components of a scan

Fixes a bug where components were sometimes missing, when the completion
was spread between different scans. It does not affect the decoding of
images when all components are completed in the same scan.
This is not a complete fix (as noted by the still failing sample) but should correctly
decode many more images. In particular, we can now decode some progressive
jpegs in which the final AC data is split among multiple scans. What we still can
not do correctly is decode images where some components specify only a subset
of all 63 coefficients. In the words of the spec, we can do most of spectral selection.
Additionally, successive approximation is also partially not yet supported.

This fixes, with some confidence, the structural issues of the decoding. Some color issues might still be present if encoders make full use of the allowed band splitting of ACs and not only the DC/AC split tested here and apparently present in the samples provided. This would require a larger rework of the complete decoding flow, so let's fix the error and very, very common case first.


Adds collapse list of alternate names for credential search results

This PR adds topic display names and a collapsable element of alternate topic names/identifiers to OrgBook search results.
Changelog:

Fixes an issue where topic search results showed a blank name if topic credentials did not use prescribed name types.
By default, the topic source_id is displayed for topic search results otherwise the display name is derived from name types in the following order:

display_name, entity_name_assumed, entity_name

If topic names other than the display name are available, remaining names/identifiers are displayed in a collapsable element

Aries VCR should be implemented to show one and only one name, and the label associated with the other names would be used for those names. Even better if we have help text associated with fields.
For BC, it would be good if we could use "entity_name" always, and use a label to indicate what "assumed_entity_name" means e.g. "Legal name in BC for extra-provincial company".  As well, the "BN" would be a name with a label e.g. "CRA Business Number".
If BC Registries is unwilling to do that, and wants the flip-flopping with the "Display Name" according to their specific rules, that would be coded into the BC Registries UI.
Does that sound reasonable?
Akiff -- are you making BN a name?  Also, are you implementing the concept of "Display Name"?

OrgBook displays the "legal company name" so we don't have a lot of flexibility as to what that means.

Agreed.  Both are technically legal names -- just with different contexts.  But I'm fine with OrgBook BC varying from Aries VCR.


Now on NetBSD

Hi,
FYI, I've packaged garden for pkgsrc/NetBSD and merged the package into the main branch, http://mail-index.netbsd.org/pkgsrc-changes/2023/01/22/msg267560.html
This means users will be able to install garden from the official repositories using the native package manager, i.e. pkgin install garden
If users still prefer to build it from source, they can easily do that by
cd /usr/pkgsrc/devel/garden
make install

Regards

Thank you so much, that's really great to hear! I'll leave this issue open as a reminder to to add these instructions to the Installation instructions (doc/src/installation.md).

@davvid If I find the time, I'll make a PR for it ;)

Thanks @0323pin ~ I've added a NetBSD section to the installation instructions and mentioned you in the upcoming v0.7.0 release notes.
Please let me know (or submit a PR) if there are any details you'd like to change.
cheers!

@davvid Thank you! Looks good to me.


[FireBeetle/LoRaWAN Node] Sleep mode is entered if battery voltage is low, but supply voltage is good

LoRaWAN_Node
Sleep mode is entered, if the battery voltage is below 'Battery low', even if an external power supply (e.g. USB) is connected. Additionally long sleep interval is applied.
Expected: If the supply voltage is good, the device operates normally and uses normal sleep interval.
See also: https://github.com/matthias-bs/BresserWeatherSensorLW/issues/112

LoRaWAN_Node uses a DFRobot FireBeetle ESP32 (Schematic) supplied by an Adafruit Universal USB / DC / Solar Lithium Ion/Polymer charger.

The battery is connected to the Adafruit charger.
The battery voltage is measured via ADC input A3 using getBatteryVoltage().
If no battery is connected, getBatteryVoltage() returns close to 0V (due to the voltage divider's lower resistor connected to GND)
The Adafruit charger's output is connected to the FireBeetle's battery connector (J1/BAT) feeding VB.
The supply voltage can be measured via ADC input A0 using getSupplyVoltage() if R10 and R11 have been assembled.
If R10 and R11 have not been assembled, A0 is floating, which leads to totally unpredictable ADC values.


Deploy docs in CI

Fixes #1044
#1114 should be merged first.

@lolmaus might be interesting for your work too?


Improve WrrocRenderer

Add workflow file to crate.
Correct path to output files in metadata file.
Add CreateActions for tool executions.
Add ControlActions.
Add SoftwareApplications for processes.
Add HowToSteps.
Add agent information (orcid, name) to nextflow.config that is incorporated into metadata file.

I've installed the plugin with make install and used the following nextflow.config:
plugins {
    id<EMAIL_ADDRESS>}

params {
    outdir = 'results'
}

prov {
    enabled = true
    formats {
        wrroc {
            file = "${params.outdir}/ro-crate-metadata.json"
            overwrite = true
            agent {
                name = "John Doe"
                orcid = "https://orcid.org/0000-0000-0000-0000"
            }
        }
    }
}

I had to pin the plugin's version because otherwise Nextflow downloads nf-prov-1.2.2 and uses that (which fails because it does not support wrroc as a format). Then I ran nextflow run tests/test.nf and got a results RO-Crate. Here are the problems I've found:

The CreateAction corresponding to test.nf (#606ce08c-cac1-4777-8a1b-83f497a0c63d) has an "id" property which should be "@id" instead, so the RO-Crate is not valid. I've manually changed that to "@id" in order to continue with the review.

The other CreateAction entities have a "result" property that has a nested list, which shouldn't be there. For instance, this:

"result": [
    [
        {
            "@id": "r1.foo.1.txt"
        },
        {
            "@id": "r1.foo.2.txt"
        }
    ]
],

should be:
"result": [
    {
        "@id": "r1.foo.1.txt"
    },
    {
        "@id": "r1.foo.2.txt"
    }
],

I made these changes manually to move on with the review. At this point, Runcrate reads the crate (runcrate report results) without crashing. Here's the output:
action: #606ce08c-cac1-4777-8a1b-83f497a0c63d
  instrument: test.nf (['File', 'SoftwareSourceCode', 'ComputationalWorkflow', 'HowTo'])
  started: 2024-06-20T11:59:14.123266278+02:00
  ended: 2024-06-20T11:59:14.897242324+02:00
  outputs:
    r1.foo.1.txt
    r1.foo.2.txt
    r2.foo.2.txt
    r2.foo.1.txt
    r3.foo.1.txt
    r3.foo.2.txt

action: #71e33a99d3115bb57a7cdfc1b220fbbf
  step: test.nf#main/RNG
  instrument: #Script_923b8caac4a54f39@66e17eff (SoftwareApplication)
  outputs:
    r1.foo.1.txt
    r1.foo.2.txt

action: #a9b6314416b001fb728ff45fa29d6f5e
  step: test.nf#main/RNG
  instrument: #Script_923b8caac4a54f39@66e17eff (SoftwareApplication)
  outputs:
    r2.foo.1.txt
    r2.foo.2.txt

action: #45b19d72e22ba819cf02b88e4977bc86
  step: test.nf#main/RNG
  instrument: #Script_923b8caac4a54f39@66e17eff (SoftwareApplication)
  outputs:
    r3.foo.1.txt
    r3.foo.2.txt

The "@id" of ControlAction 3968b3e5-b5c8-4b24-9e03-d118801e589e should be #3968b3e5-b5c8-4b24-9e03-d118801e589e.

The ComputationalWorkflow has outdir as an input parameter, but the only parameter you can set when launching the workflow is constant (which is not listed as an input parameter in the RO-Crate metadata). If I try to change the value of outdir from results to crate (either in nextflow.config or on the command line with --outdir crate), files are still output into results; moreover, in this case the ro-crate-metadata.json and test.nf files are missing (they can be found in the crate dir but only if you create it manually before running the workflow).

I've also noticed a weird thing: if you run rm results -rf && nextflow run tests/test.nf (without changing the value of outdir in nextflow.config) repeatedly, sometimes (like 1 in 20 times) the ro-crate-metadata.json file is missing from the results dir.

Thanks for the comprehensive feedback @simleo . The next time I will check if runcrate can parse the document before asking for feedback ...
I fixed most of the issues, but this causes some headache:

sometimes (like 1 in 20 times) the ro-crate-metadata.json file is missing from the results dir.

I can reproduce the problem.
I wrote a script that removes the results directory, reruns the pipeline and checks if ro-crate-metadata.json ist present. It seems that the workflowOutputs mapping is missing entries for some output files.
Next I will use the newest Nextflow version and maybe the newest nf-prov version, maybe this problem is addressed there. For me it doesn't seem that the problem originates from the WrrocRenderer itself.

I've run the workflow again with the plugin at ac05da2, using the same nextflow.config. The issues I've reported in my previous comment seem to be solved (the sometimes-missing metadata file problem should be solved after the integration of c92b21f, if I understand correctly). Great job! This is another round of review.

if the workflow is run without passing parameters (nextflow run tests/test.nf), the #constant FormalParameter is missing from the RO-Crate metadata (only #outdir is present). If it's run with nextflow run tests/test.nf --constant bar, #constant is present. It should be present in both cases.

The CreateAction corresponding to the workfow execution has an empty "object". It should contain references to PropertyValue entities corresponding to the values taken by the parameters during the specific run. For instance, when run with nextflow run tests/test.nf --outdir crate --constant bar, the result should look like this:

{
    "@id": "#outdir",
    "@type": "FormalParameter",
    "name": "outdir",
    ...
},
{
    "@id": "#constant",
    "@type": "FormalParameter",
    "name": "constant",
    ...
},
{
    "@id": "#b5236af9-95e9-42b8-9121-a6a57755ee1b",
    "@type": "CreateAction",
    "instrument": {
        "@id": "test.nf"
    },
    "object": [
        {"@id": "#outdir-pv"},
        {"@id": "#constant-pv"}
    ],
    "result": [
        {"@id": "r3.bar.2.txt"},
        {"@id": "r3.bar.1.txt"},
        {"@id": "r2.bar.1.txt"},
        {"@id": "r2.bar.2.txt"},
        {"@id": "r1.bar.1.txt"},
        {"@id": "r1.bar.2.txt"}
    ]
    ...
},
{
    "@id": "#outdir-pv",
    "@type": "PropertyValue",
    "exampleOfWork": {"@id": "#outdir"},
    "name": "outdir",
    "value": "crate"
},
{
    "@id": "#constant-pv",
    "@type": "PropertyValue",
    "exampleOfWork": {"@id": "#constant"},
    "name": "constant",
    "value": "bar"
}

When run with nextflow run tests/test.nf the outcome should be the same except for the "value" fields of the PropertyValue entities, which should be "results" and "foo" (the defaults). Note that the PropertyValue instances link to the corresponding FormalParameters via exampleOfWork.

The three CreateActions corresponding to the executions of RNG should also have an "object" pointing to PropertyValue instances, which in turn should be connected via exampleOfWork to FormalParameters of the SoftwareApplication corresponding to RNG.

Since the output RO-Crate conforms to the Workflow RO-Crate profile, its Root Data Entity must have a "license". This can be specified in nextflow.config, like agent.

nextflow.config should be included in the output RO-Crate. In the metadata file, it should be linked via object from the OrganizeAction, as specified in the Provenance Run Crate profile.

First, thank you for the review @simleo.

Parameters are now added to RO-Crate metadata regardless if they are specified in the configuration or inside Nextflow's workflow files. This was simple, just use session.getBinding().getParams() this should return all parameters that are active during workflow execution.

CreateAction of the workflow references now PropertyValues  via object. PropertyValue link to the FormalParameter  via exampleOfWork.

If a license is specified in the configuration (e.g. license = "Apache-2.0") it's added to the Root Data Entity. If the specified string is a valid URL it's added with "license": "{@ id:  < URL >}". But the CreativeWork entry for the URL of the license is missing in the RO-Crate metadata. Is this needed or does the URL is enough?  If yes I try to add it.

I started to think about the nextflow.config  thing. There several places where the configuration can reside. The documentation explains it . There can be four different configuration files that take precedence in a specific order. Maybe it doesn't suffice to just copy all the files into the crate, because how can we decide which one takes precedence over the others?  I'm thinking about compiling one 'effective' configuration file containing the values that are valid during workflow exeuction and put that one into the crate.

I still have to do the PropertyValue stuff to the three CreateActions corresponding to the RNG executions.

I've tested the latest version: big improvements! As reported above, the main thing that's missing now is completing the information related to the CreateActions corresponding to the execution of RNG. Two remarks on this version:

When the license is not specified in nextflow.config, the root data entity is populated with a "license": "null" property. In this case there should not be any "license" property at all.
In the nextflow.config that is stored in the output crate the constant parameter is present only if specified in the command line. Can this be changed so that the parameter is present with its default value if not specified?

If a license is specified in the configuration (e.g. license = "Apache-2.0") it's added to the Root Data Entity. If the specified string is a valid URL it's added with "license": "{@ id:  < URL >}". But the CreativeWork entry for the URL of the license is missing in the RO-Crate metadata. Is this needed or does the URL is enough?  If yes I try to add it.

If a "license": {"@id": "< URL >"} is added to the root data entity, then it would be appropriate to add an entity with that id to the crate. For instance:
{
    "@id": "./",
    "@type": "Dataset",
    "license": {
        "@id": "https://spdx.org/licenses/Apache-2.0"
    },
    ...
},
{
    "@id": "https://spdx.org/licenses/Apache-2.0",
    "@type": "CreativeWork",
}

I tested the created RO-Crate with the new 0.4.0 version of  rocrate-validator and fixed the last requirements, @simleo.
Added datePublished to Datasetand author to the root data entity. You can find the newest metadata file for the nf-prov example workflow here.
rocrate-validator validate --requirement-severity REQUIRED --profile-identifier provenance-run-crate-0.5 --no-fail-fast --output-format json --output-file /tmp/nf-prov/1.1.0/ro-crate-validation.json  <crate>

{
    "rocrate": "/tmp/nf-prov/1.1.0/demo/",
    "validation_settings": {
        "data_path": "/tmp/nf-prov/1.1.0/demo/",
        "profiles_path": "/home/felix/miniconda3/envs/roc-validator_python3.9_env/lib/python3.9/site-packages/rocrate_validator/profiles",
        "profile_identifier": "provenance-run-crate-0.5",
        "inherit_profiles": true,
        "requirement_severity": "REQUIRED",
        "abort_on_first": false
    },
    "passed": true,
    "issues": []
}

I ran rocrate-validator with --requirement-severity RECOMMENDED and get a very long list of of required and recommended things I should add. I'm working on them now.

I ran rocrate-validator with --requirement-severity RECOMMENDED and get a very long list of of required and recommended things I should add. I'm working on them now.

Hold on, @fbartusch, there seems to be a problem with the JSON output format. It looks like it's reporting as REQUIRED some issues that actually correspond to RECOMMENDED shapes. @kikkomep is investigating the problem.

I ran rocrate-validator with --requirement-severity RECOMMENDED and get a very long list of of required and recommended things I should add. I'm working on them now.

Hold on, @fbartusch, there seems to be a problem with the JSON output format. It looks like it's reporting as REQUIRED some issues that actually correspond to RECOMMENDED shapes. @kikkomep is investigating the problem.

The issue has been fixed in the latest release, version 0.4.2


How can Geoportal Search Widget recongnize some URL in ISO19115 metadata as OGC or ArcGIS services?

How can Geoportal Search Widget recongnize some URL in ISO19115 metadata as OGC or ArcGIS services?
Which source file I can find the logic as I want to alter the logic to suit for my case?

ok thank


Coverage import and analysis

Optimized coverage loading expressions (much faster!)
Added exomes/genomes coverage stats computation script

looks great! just one minor thing


There is no way to cleanly recover from an uncaught exception

Is there an existing issue for this?

[X] I have searched the existing issues

Current behavior
When a CLI command involves a long-running task or some persistent connection, and then an unhandled exception is thrown, the Node process will not terminate and run perpetually.
An unhandled exception seem to cause the entire NestJS app to be abruptly halted without a chance to do a clean up. I believe this is because when an unhandled exception is thrown, the runApplication function doesn't catch the exception and never returns with the app instance. Therefore the caller also never got a chance to call app.close() to properly shut down the application where clean up takes place.
Minimum reproduction code
The situation is reproduced in this repository: https://github.com/david-catch/nest-commander-exception-bug
Expected behavior
When a CLI command involving a long-running job or persistent connection faces an unhandled exception, the app.close() should still be closed to allow the app to properly clean up the resources and allowing the Node process to exit instead of getting stuck.
Package

[X] nest-commander
[ ] nest-commander-schematics
[ ] nest-commander-testing

Package version
3.5.0
Node.js version
16.13.1
In which operating systems have you tested?

[X] macOS
[ ] Windows
[ ] Linux

Other
No response

Looks like I can add a try/catch around the this.command.parseAsync in the CommandRunnerService (what actually executes the command) to handle this. I'll probably need to add another option to the CommandFactory for how to handle these errors and by default just process.stderr.write(err.toString()) or similar. I've got a few additions coming down the pipe for this package so I'll bundle them all together under 3.6.0 probably

Published in 3.6.0

Thanks for pushing the update @jmcdo29! One thing I noticed is that the new serviceErrorHandler option is not being parsed by the function CommandFactory.getOptions(), which means it is ignored and doesn't override the default handler. I believe updating that one function should fix it!
(PS: I've updated the simple reproduction repo with the new version 3.6.0 to illustrate the issue)

Oh shoot! Nice catch. Mind paying that in a PR and adding a patch changeset using pnpm changeset?

I don't mind doing that, just that I'm not familiar with using pnpm changeset. I'll give it a shot regardless :)

I've created a PR here https://github.com/jmcdo29/nest-commander/pull/807


Avoiding activity null pointer

Wrapping block of code with if statement to avoid NullPointerException when using custom main application

@kakzaki  are you going to publish a new version on pub.dev?


Resolve at least critical dependecies

https://github.com/conference-buddy/conference-buddy-web-app/security/dependabot
something similar in npm like yarns resolves?

Could you elaborate what you would like to achieve?
If you see a dependabot warning, you can create a PR from that, which will pin a (sub-)dependency.

Hi! Dependabot solves the critical dependencies with downgrading gatsby-plugin-image (to 0.7.2. instead of 2.0.0) which breaks stuff. Same as npm audit fix --force. Had a simliar problem with immer at my company and I solved it with forcing yarn to use a specific version of immer everywhere, which yarn does with resolves. Didn't find something similar for npm when I looked (shortly).

Since gatsby-plugin-image is a build time dependency which does not get shipped with the published site I think it's safe to ignore this downgrade.

I realize this is not the answer to the initial question, with NPM you would manually patch the package-lock.json.

Thanks @coderbyheart! Will look into that ❤

even if it's not really unsafe, it feels BAD to see it listed as critical 😬  It's like a todo item you can't check 😱


I generated tile json files using IfcGeometriyTiler, but I don't know how to use these files

I generated tile json files using IfcGeometriyTiler, but I don't know how to use these files. Can someone tell me?
My requirement is to render the BIM model in a browser with construction information

Hi @lvfeijian did you see the tutorial in the docs?

Hey @lvfeijian, I suggest you use community when having questions rather than issues or feature proposals. 💪

ok，thanks
------------------ 原始邮件 ------------------
发件人: "Juan @.>;
发送时间: 2024年8月17日(星期六) 晚上11:25
收件人: @.>;
抄送: @.>; @.>;
主题: Re: [ThatOpen/engine_components] I generated tile json files using IfcGeometriyTiler, but I don't know how to use these files (Issue #472)
Hey @lvfeijian, I suggest you use community when having questions rather than issues or feature proposals. 💪
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>


ActiveDirectoryPassword authentication

Can we provide an example on how to make ActiveDirectoryPassword authentication work?

go-sqlcmd supports all the AAD types
https://github.com/microsoft/go-sqlcmd/blob/d378b4b22657947663a0079dd737c9b3b487e4bc/pkg/sqlcmd/connect.go#L79
and
https://github.com/microsoft/go-sqlcmd/blob/d378b4b22657947663a0079dd737c9b3b487e4bc/pkg/sqlcmd/azure_auth.go#L28
It should just be a matter of setting the fedauth property in the connection string and providing a user name and password as usual.
One problem with testing AAD auth is I don't have access to an AAD instance that supports non-MFA authentication so I've not actually verified AAD password auth directly.

@FromPAUS Take a look at https://github.com/microsoft/go-mssqldb#azure-active-directory-authentication as well as the code I've posted below (and attached).  You can probably adapt it to work with ActiveDirectoryPassword authentication.
mssqltest.go.txt
package main

import (
	"github.com/microsoft/go-mssqldb/azuread"
//    _ "github.com/microsoft/go-mssqldb"
    "database/sql"
    "context"
    "log"
    "fmt"
)

var db *sql.DB

func main() {
    var err error

    // Create connection pool
    db, err = sql.Open(azuread.DriverName, "sqlserver://xxx.database.windows.net:1433?database=xxx&fedauth=ActiveDirectoryManagedIdentity&user id=client_id_of_user-assigned_managed_identity")
    if err != nil {
        log.Fatal("Error creating connection pool: ", err.Error())
    }
    ctx := context.Background()
    err = db.PingContext(ctx)
    if err != nil {
        log.Fatal(err.Error())
    }
    fmt.Printf("Connected!\n")

    // Read table
    count, err := ReadTable()
    if err != nil {
        log.Fatal("Error reading Table: ", err.Error())
    }
    fmt.Printf("Read %d row(s) successfully.\n", count)

	// Call Hello function
	hello()
}

// ReadTable reads a record from a specific table
func ReadTable() (int, error) {
    ctx := context.Background()

    // Check if database is alive.
    err := db.PingContext(ctx)
    if err != nil {
        return -1, err
    }

    tsql := fmt.Sprintf("SELECT count(*) AS PlayerCount FROM Players;")

    // Execute query
    rows, err := db.QueryContext(ctx, tsql)
    if err != nil {
        return -1, err
    }

    defer rows.Close()

    var count int

    // Iterate through the result set.
    for rows.Next() {
        var PlayerCount int

        // Get values from row.
        err := rows.Scan(&PlayerCount)
        if err != nil {
            return -1, err
        }

        fmt.Printf("Player Count: %d\n", PlayerCount)
        count++
    }

    return count, nil
}

func hello() {
	fmt.Println("Hello World!")
}


Find alternative for npm

npm is pretty slow. We could investigate a bit into alternatives such as pnpm, and yarn and see if we can improve performance.
Especially to save some GitHub credits.

Tried out pnpm and yarn. both work fine.


Catch index error when checking dollar prefix

[x] Tests for the changes have been added

[ ] Docs have been added / updated

[ ] All CI checks are green

What kind of change does this PR introduce?

As shown by the test, we want to return False for the empty string when checking if it is prefixed with a dollar.

What is the current behavior?

The function is_prefixed_with_dollar_sign raises IndexError when called with the empty string.

What is the new behavior (if this is a feature change)?

is_prefixed_with_dollar_sign returns False for the empty string.

@sindrig thank you for your contribution 😄 could you please merge master into your branch?

@sindrig thank you for your contribution 😄 could you please merge master into your branch?

Done :heavy_check_mark:

@sindrig thank you for that! Looks like one of the pre-commit checks is failing. Please, run make test and then push the changes

Import order got mixed up. Fixed :white_check_mark:

@sindrig Thank you for your contribution! I went ahead and merged your changes. Really appreciate your work and hope to see another PR of yours soon 😄


Provide the library as a Ktor server library

Is it possible to reuse the library in server side ktor?

The current version (v0.x.x to v1.x.x) of the library is focused on mobile clients i.e. Android and iOS, utilizing it on the server-side isn't possible yet. These versions prioritize functionalities relevant to mobile clients and their interaction with Daraja API endpoints.
The upcoming v2.x.x release is planned to introduce server-side support, along with a broader range of endpoints that require a backend for interaction.
Contribute to this progress by adding a JVM target and corresponding tests for the library. You can find our contribution guidelines here


add Monoid instance for UrlForm

The tests I added are pretty rudimentary. I'm open to suggestions or even just a pointer to another Monoid instance's tests that would be good to emulate.

What are the expected semantics when both have the same key? Overwrite or combine? I would expect combine, which I think your implementation would do. Just double checking intent.

I expected the keys to be combined as well.
There is an Arbitrary[UrlForm], and using cats-laws looks like it's revealed some bugs, so I'm working through those. Thanks for the suggestion.

I agree about reconsidering Seq later on.
I think it would be good to backport this. I can prepare another PR for that if it's helpful—it looks like the tests pass if I cherry-pick f2af07d onto release-0.18.x.

That sounds great, thanks.

Is there anything left here we won't get from merging #2095?

I’m not sure if the cats wildcard import in the test file would make it via #2095, but I think that’s the only difference.

Superseded by backport in #2095.


HydraDX snakenet staking issue

Describe the bug
The staking tab show infinity loading when HydraDX snakenet solochain is turned on. Please check it.
Here is the link that reproduce the bug: https://drive.google.com/file/d/1JWDUiB02gAgG-66YCcOU-YLLp-YdevH0/view?usp=sharing

Resolved in issue #386. Due to hydradx migrates to become a parachain


"wrong number of arguments (1 for 0)", activeadmin (1.0.0.pre) ruby 2.1.2 and rails 4.1.5

This change works perfect in local but how to have this fix in production


Larsen from devon refactor

Codecov Report

Merging #31 into develop will increase coverage by 11.97%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop      #31       +/-   ##
============================================
+ Coverage    78.64%   90.62%   +11.97%
============================================
  Files            6        6
  Lines          192      192
  Branches        20       20
============================================
+ Hits           151      174       +23
+ Misses          38       13       -25
- Partials         3        5        +2

Impacted Files
Coverage Δ

dork/types.py
89.14% <0%> (+17.82%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1d9447...5a73b6c. Read the comment docs.


tf version

Hi!
I use tf 1.10.0 to transfer bert ckpt into pytorch_model.bin. Could you tell me the tf version?
When I run the source code, this error occurred:
TypeError: _load_from_state_dict() takes 7 positional arguments but 8 were given
Thank you!

Hope this can help: https://github.com/huggingface/pytorch-pretrained-BERT/issues/122

Thank you so much!


[QT-Wallet] In  Windows platform, Wallet setting page UI alignments are not proper.

Description:
In QT-Wallet (Windows platform), Wallet setting page UI alignments are not proper.
Please refer screenshot for more details.

Note:
The same page looks good in MAC OS platform.

Hi @sarawut11 , if you have time please check at that white right/bottom border.  It is visible under the Windows (MacOS is fine).

ok

@bayk fixed the border issue in this PR(https://github.com/mwcproject/mwc-qt-wallet/pull/359).

It was fixed a while back

It was fixed a while back


Adds meta description

[x] Meta description

Meta description is long. Is this something the customer wants? Maybe discuss with content team if it should be one sentence.


Additional output modes

quiet (no console output)
no-log (no file logging; only after db implemented)
no-color

Split into #18 #19 and #20


Feature: Add status, trans_type and create_time range param in admin page, etc

Add status param
Add trans_type param
Add create_time range param
Add time related columns
Action as first column
Enable table x scroll
Fix redis qeury paging bug

Can you add some test case for setting all the filters?
That will increase the test coverage

Codecov Report

Merging #420 (28f686c) into main (2371a98) will decrease coverage by 0.31%.
The diff coverage is 73.58%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
- Coverage   96.01%   95.70%   -0.31%
==========================================
  Files          57       57
  Lines        4086     4123      +37
==========================================
+ Hits         3923     3946      +23
- Misses        118      127       +9
- Partials       45       50       +5

Impacted Files
Coverage Δ

dtmsvr/storage/sql/sql.go
92.85% <20.00%> (-5.63%)
:arrow_down:

dtmsvr/storage/boltdb/boltdb.go
95.67% <66.66%> (-0.44%)
:arrow_down:

dtmsvr/api_http.go
92.50% <100.00%> (+0.25%)
:arrow_up:

dtmsvr/storage/redis/redis.go
98.65% <100.00%> (+0.05%)
:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

CI can not pass.
Did it succeed in your local development environment?
Making least change to TestAPIAll, just adding a query with many filters set may pass the test, and also increase the test coverage!
It is not a good practice to call Time.sleep in a test, that will make the running of test longer.

会拆分成独立的feature，需要先修复已有的问题：

redis scan用法bug（不同于mysql的limit）
分页查询断言bug （导致了redis scan的问题没暴露）
单测中持久层的串扰问题

目前PR还没有合并，进度有点慢，这样吧，你先提个PR，只修改一行注释，合并之后，你后续的PR就能够自动跑CI了
另外有一个原则，每个PR，尽量小一些，完成一个独立的功能即可。例如Redis的bug修复可以作为一个PR，filter这个，后端可以作为一个PR，前端可以作为一个PR，这样代码review起来会简单清晰很多
另外说一下，尽量少的对原有代码改动，例如对原代码变量重新命名，改变代码风格等等。总之就是，如非必要，如果不能做出明显的改善，不改动原有代码

已拆出来三个PR， #422 #425 #426


luajit_2_0, luajit_2_1: 2.1.0-2020-03-20 -> 2.1.0-2020-08-05

Motivation for this change
2.0 changes: https://github.com/LuaJIT/LuaJIT/compare/e613105..2211f6f
Mostly bugfixes.
2.1 changes: https://github.com/LuaJIT/LuaJIT/compare/9143e86..10ddae7
Lot of bugfixes, optimizations and modernization. For me the most interesting commits:

https://github.com/LuaJIT/LuaJIT/commit/1a4ff1311740aa6c85f7a9101b6aa9bfaafa3f8e (Optimize table length computation with hinting.)
https://github.com/LuaJIT/LuaJIT/commit/a44f53acf53603e7d9b88352de035b1804be4e88 (Use a securely seeded global PRNG for the VM.)
https://github.com/LuaJIT/LuaJIT/commit/ff34b48ddd6f2b3bdd26d6088662a214ba6b0288 (Redesign and harden string interning.)

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build neovim luajitPackages.lpeg

also a partial nixpkgs-review gives
error: --- Error --- nix-daemon
builder for '/nix/store/6d9svxq7fdh008g25ly3gxhksqv6q1k3-luajit-2.1.0-2020-08-05-ltermbox-0.2-1.drv' failed with exit code 1; last 10 log lines:
    106 | static const struct luaL_reg lt_buffer_metatable[] = {
        |                              ^~~~~~~~~~~~~~~~~~~
  lua/ltermbox.c:195:30: error: array type has incomplete element type 'struct luaL_reg'
    195 | static const struct luaL_reg ltermbox[] = {
        |                              ^~~~~~~~
  lua/ltermbox.c:213:12: warning: return type defaults to 'int' [-Wimplicit-int]
    213 | LUALIB_API luaopen_ltermbox(lua_State *L) {
        |            ^~~~~~~~~~~~~~~~

  Error: Build error: Failed compiling object lua/ltermbox.o
note: keeping build directory '/tmp/nix-build-luajit-2.1.0-2020-08-05-luaexpat-1.3.0-1.drv-0'
error: --- Error --- nix-daemon
builder for '/nix/store/fbidsmb2sp9vsh3xlgq7q32p14warijr-luajit-2.1.0-2020-08-05-luaexpat-1.3.0-1.drv' failed with exit code 1; last 10 log lines:
  gcc -O2 -fPIC -I/nix/store/wbr4wh47z6vscz2d6a6yii9x9vnls8d4-luajit-2.1.0-2020-08-05/include/luajit-2.1 -c src/lxplib.c -o src/lxplib.o -I/nix/store/kqhd4kk5cgaj37xcswdmmfygpvww65ms-expat-2.2.8-dev/include -Isrc/
  src/lxplib.c:593:13: error: static declaration of 'luaL_setfuncs' follows non-static declaration
    593 | static void luaL_setfuncs (lua_State *L, const luaL_Reg *l, int nup) {
        |             ^~~~~~~~~~~~~
  In file included from src/lxplib.c:15:
  /nix/store/wbr4wh47z6vscz2d6a6yii9x9vnls8d4-luajit-2.1.0-2020-08-05/include/luajit-2.1/lauxlib.h:88:18: note: previous declaration of 'luaL_setfuncs' was here
     88 | LUALIB_API void (luaL_setfuncs) (lua_State *L, const luaL_Reg *l, int nup);
        |                  ^~~~~~~~~~~~~

  Error: Build error: Failed compiling object src/lxplib.o
note: keeping build directory '/tmp/nix-build-luajit-2.1.0-2020-08-05-luaffi-scm-1.drv-0'
error: --- Error --- nix-daemon
builder for '/nix/store/zsp5znkj605ib6dyr5r8qn0izbshx9pl-luajit-2.1.0-2020-08-05-luaffi-scm-1.drv' failed with exit code 1; last 10 log lines:
  ffi.h:88:13: error: static declaration of 'luaL_setfuncs' follows non-static declaration
     88 | static void luaL_setfuncs (lua_State *L, const luaL_Reg *l, int nup) {
        |             ^~~~~~~~~~~~~
  In file included from ffi.h:31,
                   from call.c:9:
  /nix/store/wbr4wh47z6vscz2d6a6yii9x9vnls8d4-luajit-2.1.0-2020-08-05/include/luajit-2.1/lauxlib.h:88:18: note: previous declaration of 'luaL_setfuncs' was here
     88 | LUALIB_API void (luaL_setfuncs) (lua_State *L, const luaL_Reg *l, int nup);
        |                  ^~~~~~~~~~~~~

  Error: Build error: Failed compiling object call.o
note: keeping build directory '/tmp/nix-build-luajit-2.1.0-2020-08-05-digestif-0.2-1.drv-0'
error: --- Error --- nix-daemon
builder for '/nix/store/44g3f848il1r8kks2vl70s2dfd8wkcs8-luajit-2.1.0-2020-08-05-digestif-0.2-1.drv' failed with exit code 1; last 10 log lines:
  patching sources
  configuring
  building
  installing
  Missing dependencies for digestif 0.2-1:
     lua >= 5.3 (5.1-1 provided by VM)

  digestif 0.2-1 depends on lua >= 5.3 (5.1-1 provided by VM)

nixpkgs-review gives:
9 packages failed to build:
gimpPlugins.focusblur gimpPlugins.texturize hawkthorne love_0_9 luajitPackages.digestif luajitPackages.ltermbox luajitPackages.luaexpat luajitPackages.luaffi obs-ndi

Most of them are marked broken (I'm not sure why nixpkgs-review is trying to build them) and some failures are not related to this update, except luajitPackages.luaexpat which was failing before this update (I've patched it and opened the pull request https://github.com/silverwind/luaexpat/pull/1).

digestif should not be tried either as it requires lua >= 5.3 . weird. May look into it later. Feel free to merge.

@teto thx for looking into this, I don't gave merge right. pinging @vcunat

@GrahamcOfBorg build neovim luajitPackages.lpeg


Removing the last element from a LinkedList is unnecessarily slow

Removing the first element from a LinkedList is fast, however, removing the last element is slow.
The problem seems to be that in the removeElementAtIndex function rather than simply accessing the lastNode element, the nodeAtIndex is called, fetching the second to last element, which is done by iterating over the entire list.
Removing the last element from a LinkedList is very common, so it being crippled severely hampers the usability of the data structure.
Thanks

Hi @tom-churchill,
I faced the same issue while I was implementing the removeLastNode method for LinkedList, Do you find another solution for this problem?


Running issues of d_hat < 0

In the code, d takes the max of the following terms. But in my running log, I found d_hat is a negative and becomes smaller and smaller. Thus, d never changes since min(d_hat, d*growth_rate) is negative. Is this normal?
https://github.com/facebookresearch/dadaptation/blob/main/dadaptation/dadapt_adam.py#L217C13-L217C50
d = max(d, min(d_hat, d*growth_rate))
Logs: (log_every=10)
2024-03-04 11:06:03,377 P44085 INFO ************ Epoch=1 start ************
2024-03-04 11:06:07,560 P44085 INFO lr: 1 dlr: 1e-06 d_hat: 0.0, d: 1e-06. sk_l1=1.4e-08 numerator_weighted=0.0e+00
2024-03-04 11:06:08,892 P44085 INFO lr: 1 dlr: 0.0038455569066480266 d_hat: -0.05789491198278567, d: 0.0038455569066480266. sk_l1=4.0e-03 numerator_weighted=-1.2e-07
2024-03-04 11:06:09,928 P44085 INFO lr: 1 dlr: 0.0038455569066480266 d_hat: -0.06040422325479096, d: 0.0038455569066480266. sk_l1=4.5e-03 numerator_weighted=-1.4e-07
2024-03-04 11:06:10,977 P44085 INFO lr: 1 dlr: 0.0038455569066480266 d_hat: -0.06598773259722039, d: 0.0038455569066480266. sk_l1=4.7e-03 numerator_weighted=-1.6e-07
2024-03-04 11:06:12,013 P44085 INFO lr: 1 dlr: 0.0038455569066480266 d_hat: -0.06679562915084818, d: 0.0038455569066480266. sk_l1=4.7e-03 numerator_weighted=-1.6e-07
2024-03-04 11:06:13,049 P44085 INFO lr: 1 dlr: 0.0038455569066480266 d_hat: -0.06732794356660553, d: 0.0038455569066480266. sk_l1=4.7e-03 numerator_weighted=-1.6e-07
2024-03-04 11:06:14,095 P44085 INFO lr: 1 dlr: 0.0038455569066480266 d_hat: -0.06763984920921864, d: 0.0038455569066480266. sk_l1=4.6e-03 numerator_weighted=-1.6e-07

...

2024-03-04 11:07:21,011 P44085 INFO lr: 1 dlr: 0.0038455569066480266 d_hat: -0.07685106699482641, d: 0.0038455569066480266. sk_l1=3.4e-03 numerator_weighted=-1.3e-07
2024-03-04 11:07:22,036 P44085 INFO lr: 1 dlr: 0.0038455569066480266 d_hat: -0.07695848427227471, d: 0.0038455569066480266. sk_l1=3.4e-03 numerator_weighted=-1.3e-07
2024-03-04 11:07:23,061 P44085 INFO lr: 1 dlr: 0.0038455569066480266 d_hat: -0.07709818082261206, d: 0.0038455569066480266. sk_l1=3.3e-03 numerator_weighted=-1.3e-07
2024-03-04 11:07:24,089 P44085 INFO lr: 1 dlr: 0.0038455569066480266 d_hat: -0.07720528635792316, d: 0.0038455569066480266. sk_l1=3.3e-03 numerator_weighted=-1.3e-07
2024-03-04 11:07:25,116 P44085 INFO lr: 1 dlr: 0.0038455569066480266 d_hat: -0.07732868208281982, d: 0.0038455569066480266. sk_l1=3.3e-03 numerator_weighted=-1.3e-07
2024-03-04 11:07:26,142 P44085 INFO lr: 1 dlr: 0.0038455569066480266 d_hat: -0.07743008661997182, d: 0.0038455569066480266. sk_l1=3.3e-03 numerator_weighted=-1.3e-07
2024-03-04 11:07:27,170 P44085 INFO lr: 1 dlr: 0.0038455569066480266 d_hat: -0.07754304511218482, d: 0.0038455569066480266. sk_l1=3.3e-03 numerator_weighted=-1.3e-07

This is expected behavior, typically once d has reached a good value dhat starts to decrease and go negative afterwards. In your logs dhat must have been positive at some point as d has grown to 0.0038. Is the optimizer working for you when you run the full training job?
We have also developed methods that don't use a max operation, such as Mechanic: https://github.com/optimizedlearning/mechanic.

Thanks for your answer!
In my case, the problem is that d_hat becomes to negative at step=20 (total=5000 for one epoch), as shown in my log (log_every=10). So it functions like setting an initial learning rate to dlr: 0.0038455569066480266 at the beginning and nevers changes. So far, I havent obtained better results than adam. I guess I need to tune other hyper-parameters or change LR scheduler? Or maybe the task does not fit.
My task is for recommenation model training. My baseline uses adam with lr=0.001, and ReduceLROnPlateau scheduler.

It's normal for d to stop changing close to the beginning of optimization.
Generally with a good choice of scheduler I would expect it to match the performance of Adam with a hand-tuned LR, but not necessarily exceed it. I would recommend the use of a linear decay scheduler or cosine annealing, they both work pretty well.


Fix adr path and fetching of user email

This PR attempts to fix #149. For this, two things are changed:

The adrPath attribute of a repository is set when loading the repository in api.js → loadARepositoryContent(). Before it was only read in store.js → createNewAdr() but never written.

The endpoint to get the E-Mail is changed from /user/emails to /user/public_emails. The mail is required for commits.
(Docs for the endpoints here: https://docs.github.com/en/rest/reference/users#list-public-email-addresses-for-the-authenticated-user.)
I'm not sure why /user/emails did not work; maybe the OAuth token scope user:email isn't needed for /user/public_emails despite the docs?
Also, the mail doesn't have to be the primary one, e.g., the @users.no-reply.github.com mails are not primary. However, if a primary mail exists, it is preferred. (See store.js → setEmail() for the implementation)

Sadly, testing is kinda hard. Maybe Cypress could mock the REST API, but I didn't look into it.
I only updated the test in PushNewAdr.js to check if the displayed file name in the commit dialog is not empty.

Looks like the cypress tests use the ADR-Manager repository for testing, and the cy.intercepts do nothing.
This is sub-optimal, because a working commit functionality will spam the main branch with test commits ...

I removed (force-pushed) the test commits from the main branch, but for reference e.g., this commit https://github.com/adr/adr-manager/commit/dc428327f30a0a76bdfdc9037078e067e1b6c21e was created by the GitHub Action and not by @xJREB.

Yeah, I guess, you're correct, @KLBa, thank you. I think creating a test repo under the ADR organization would probably be the way to go.

I created the repository https://github.com/adr/adr-manager-alpha. A push to the branch publish triggers a bulid and a deploy on gh-pages. The repository is public to enable GitHub pages for free.
The current state is available at https://adr.github.io/adr-manager-alpha/#/ - and ready to test!

@koppor  I added a testing-branch to https://github.com/adr/adr-manager-alpha (to avoid that the commits show up as public contributions on user profiles...)
I also updated the E2E test to use that branch. My testing already spammed it with some commits.
The GitHub Action still impersonates @xJREB though, idk if that's a good idea :)

@koppor I added a testing-branch to https://github.com/adr/adr-manager-alpha (to avoid that the commits show up as public contributions on user profiles...) I also updated the E2E test to use that branch. My testing already spammed it with some commits.

Thank you! I don't know if a full-blown copy of the ADR Manager repo would have been necessary, since we only needed a repo to commit and push ADRs. But maybe I'm also missing something. :)

The GitHub Action still impersonates @xJREB though, idk if that's a good idea :)

Hmm, true, but I'm not quite sure what a much better solution would be. We could obviously create a new account for this that then gets access to adr/adr-manager-alpha. This would probably be a bit more secure, but I'm not terribly worried that the token gets compromised. Any other options or reasons to change to a different user that I don't see?

Looks good, thus I merged to keep things going.
The only issue I have is that a blank repository, it does not work:
Steps:

Create an empty Repository on github

Connect to the repository


REFAPP-51 feature: sass initial setup

Creating project for sass connection

[x] Feature
[ ]

Jira

https://ostmodern.atlassian.net/browse/REFAPP-51

Codecov Report

Merging #75 (9aee441) into main (294c5d1) will increase coverage by 0.03%.
The diff coverage is 91.30%.

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
+ Coverage   88.52%   88.55%   +0.03%
==========================================
  Files          72       75       +3
  Lines        1699     1722      +23
  Branches      508      512       +4
==========================================
+ Hits         1504     1525      +21
- Misses        182      183       +1
- Partials       13       14       +1

Impacted Files
Coverage Δ

apps/saas/pages/index.tsx
87.50% <87.50%> (ø)

apps/saas/hooks/useHomepageSet.tsx
91.66% <91.66%> (ø)

apps/saas/lib/constants.ts
100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Edge arrows appear above node labels

On my network, arrows on both and and middles of edges appear drawn a layer above any node label text, while the edges themselves are underneath the node label.

Hmm, this was introduced in #761. The reason is that the arrows can pierce into nodes and therefore have to be above the nodes. The problem is that a node and its label is a single unit even when the label is outside of the node, so there's no simple way to fix this.

Hmm, im not sure what you mean, all my arrows end up outside the nodes border so that wouldnt be an issue.  I haven't looked around in the code but, perhaps offer the user a setting of whether these get drawn above or below everything?

Hi @bglasgo,
for all shapes except for custom this should be resolved with the next release.

beautiful, great job!


Feat/ci itac

Adds ITAC into our CI pipeline
Improved the commit msg of the CorrBench-bot to the dashboard repo

The actions visualize 34 and 35 shows that both changes are working.


Donot use hard-coded indexes

Instead of using hard-coded indexes, derive the indexes as per the problem statements

Thank you!


RFC: Collect "testimonials" for web site & README

It's no surprise that lots of people love Caddy. It's got a great community (over 100 contributors!) and rich plugin ecosystem.  It'd be great to showcase testimonials or have a list of "powered by caddy" sites somewhere.
I mean, check out this endorsement: https://twitter.com/mikewest/status/817962064845172736
I understand that it's not possible or practical to link to everybody that says nice things about Caddy or uses it for their sites (there's just too many people!) but some highlights of prominent people, like Mike West, might be worthwhile.
Just a thought for your consideration :smile:

I'm glad you brought this up. I have been wanting to collect testimonials for the new website I'm working on. People can submit testimonials here: https://goo.gl/forms/0OMOuenYjxPuZNqU2
Thank you for your positive support, by the way. :+1: You and everyone else out there who share your good experience. It's encouraging, and I think people like reading about something good that the modern Web is doing right, rather than the usual fights over containers and JS frameworks and stuff.
(I know Caddy has its flaws -- we'll work on those -- and weaknesses for certain uses cases -- we'll target the audience it's best at.)

rather than the usual fights over containers and JS frameworks and stuff
This! @mholt thanks for pointing out. Keep rollin'


feat: doc for building wasm-go

feat: doc for building wasm-go

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@dspo Need to sign CLA first, thanks.


Localization remaps don't work for themes in exported project

Tested versions
4.3 stable
System information
Godot v4.3.stable - macOS 14.5.0 - Vulkan (Forward+) - integrated Apple M2 Pro - Apple M2 Pro (10 Threads)
Issue description
I attempted to use localization remaps to switch between different themes(.tres files) to suit various languages and apply different font styles. Everything worked fine during testing in the editor, but after exporting, the remap didn’t function as expected — the label’s font and size didn’t change.
Maybe related to this one: Changing the locale breaks remapped fonts
Steps to reproduce

Run the root.tscn.
Press 2 buttons to change the locale and check the font on the label.
Export project.
Run the exported project and follow the step 2 again.

Minimal reproduction project (MRP)
Archive.zip

Exported game output this into terminal:
WARNING: Translation remap 'res://font_en.tres' does not exist. Falling back to 'res://font_en.tres'.
     at: _path_remap (core/io/resource_loader.cpp:1197)
WARNING: Translation remap 'res://font_ja.tres' does not exist. Falling back to 'res://font_en.tres'.
     at: _path_remap (core/io/resource_loader.cpp:1197)

Seems that this 2 resources doesn't get included in exported build?

Exported game output this into terminal:
WARNING: Translation remap 'res://font_en.tres' does not exist. Falling back to 'res://font_en.tres'.
     at: _path_remap (core/io/resource_loader.cpp:1197)
WARNING: Translation remap 'res://font_ja.tres' does not exist. Falling back to 'res://font_en.tres'.
     at: _path_remap (core/io/resource_loader.cpp:1197)

Seems that this 2 resources doesn't get included in exported build?

Yes, I tried exporting them explicitly, but it still didn’t work.

Adding new labels and applying that themes to them - works, so resources definitely included in exported build.

Adding new labels and applying that themes to them - works, so resources definitely included in exported build.

My tests reached the same conclusion. It seems that the remaps resources are not shared with the regular resources, or not properly linked for some reason.


Add yandexdisk Latest

Yandexdisk is a Yandex cloud storage

In the future, please submit separate pull requests for each cask, as more often than not this type of pull request brings problems with one or more of them, and it halts the inclusion of the other ones.
In this case:

Betas belong in caskroom/versions.
You’re also submitting a script you shouldn’t.

I found problems with yandexdisk link : (


Edge cases for article translation

Checklist

[x] Strip @mention in Article.language resolver;
[ ] Make gcp.detectLanguage isolate its API quota from gcp.translate so that Article.language of new articles wont be affected if gcp.translate runs out of quota;
[ ] Throw error message or return nullish value if fails to translate;

Refs

https://feedback.matters.town/bug-reports/p/eeb49a

I forked the project yesterday and am still familiarizing myself with the repository. Please correct me if I'm wrong.

Does the bug indicate that we need to handle situations when the translation API runs out of quota?
Should we replace Google Translate with another provider due to pricing concerns, or are we supposed to support multiple translation providers with load balancing behind the scenes? This would help us avoid relying on a single translation API, reducing the risk of a single point of failure and improving availability.

Additionally, I noticed that the translation feature also translates @mention. I think we should leave it as is—what are your thoughts?


add: Anushka-Bhowmick

Description
I have added my GitHub profile.

@Anushka-Bhowmick Thank you so much for your contribution! Your efforts are greatly appreciated and will go a long way in improving our project. Please feel free to share it with others and Star the repo to help us grow even further!


Axis should use d3.svg.axis

Is there any particular reason why the graphs create div elements for axis instead of using D3's ready to go component [1][2]?

https://github.com/mbostock/d3/wiki/SVG-Axes
http://bl.ocks.org/1166403

Closing due to inactivity.


Symengine importing problem in MacOS

I am having the following problem while importing symengine in my MacOS.

import symengine
Traceback (most recent call last):
File "", line 1, in
File "/Users/aneekphys/symengine/build/symengine.py/symengine/init.py", line 12, in
import symengine.lib.symengine_wrapper as wrapper
ImportError: dlopen(/Users/aneekphys/symengine/build/symengine.py/symengine/lib/symengine_wrapper.cpython-39-darwin.so, 0x0002): symbol not found in flat namespace (_ZN9SymEngine10ComplementC1ERKNS_3RCPIKNS_3SetEEES6)

cannot find a way to resolve it.

Have you tried the pip wheel? pip install symengine?


(sonarlint-vs2015) Migrate to core team packages

Migrate from my own repository. Also changed to embedded package.
Chocolatey user is invited.
PR for removing from original repository: https://github.com/pascalberger/chocolatey-packages/pull/113. I will remove from my repo as soon as this is ready to be merged.

other than the last two comments, this looks good to me.

@gep13 Can you please accept the invitation for the Chocolatey user?

@pascalberger said...
Can you please accept the invitation for the Chocolatey user?

Done.

I propose to not push it at the moment and wait for the next update, since it already has a 4-digit version number

Sounds good to me :+1:


Clustered Traffic Shaping

The piece we don't currently have is Redis-enabled connection limits.
Part of this work is to do something similar to https://docs.kumomta.com/reference/kumo/configure_redis_throttles/ but for limits.

Looking at this some more, to make connection limits distributed, what we really need here are distributed semaphores.
Some homework on those reveals a couple of techniques:

Using BLPOP (blocking) or LPOP (immediate non-blocking check) to acquire an available slot. https://davidverhasselt.com/a-distributed-mutex-and-semaphore-using-redis/ and their ruby implementation in https://github.com/dv/redis-semaphore This has an open issue about the semaphores getting broken over time; could be misuse of the auto-expiration feature, or a side effect of non-persistent keys being evicted under memory pressure
https://github.com/swarthy/redis-semaphore#semaphore and https://github.com/swarthy/redis-semaphore#redlocksemaphore. The latter uses the Redlock algorithm which has better guarantees/properties when redis clusters are used
This java implementation which I'm hoping not to have to try to read in too much detail

My quick take: the BLPOP approach is the simplest approach and may be the easiest to implement quickly to get things off the ground, but we'll probably want the redlock-based semaphore in the end.
In terms of work that needs to be done here, there are a couple of passes:

Convert existing limit code to be patterned after a semaphore acquisition/release rather than the current simple counter operations
Establish a redis semaphore client, perhaps in our throttle crate, perhaps in its own crate. Definitely want some integration tests that spin up redis for this.
Adjust configure_redis_throttles to switch out the limit implementation as mentioned above


add discordjs-typescript example

Added a separate discordjs example for typescript users.

Numerous problems with this pull request. Will need to redo it.


Create Sigma translator app

Create an app that can take a ruleset and translate it before running automation towards a SIEM, using Sigma: https://github.com/SigmaHQ/sigma
Example actions:

Take input of a Sigma file OR rule, and translate it into any SIEM search query.

Example platform doing this: https://uncoder.io/

hi @frikky Can you please provide some guidance on the desired layout for the app?

Hello @frikky,
I wanted to express my gratitude for your guidance and for providing the link to the Shuffle documentation. Your help is greatly appreciated.
I'm eager to work on this issue as part of my Github Octernship assignment.

Hi @frikky  , I am working on this.

hi @frikky, do you have an example of the rules or than the sigma rules that should be translated.
Thanks

hi @frikky, do you have an example of the rules other than the sigma rules that should be translated? Thanks

Finding ways to use the following as Apps in Shuffle (this is not about translation, but about security &standardization):

OSQuery
Ansible
Yara
Volatility
Snort
Surricata

hi @frikky, do you have an example of the rules other than the sigma rules that should be translated? Thanks

Finding ways to use the following as Apps in Shuffle (this is not about translation, but about security &standardization):

OSQuery

Ansible

Yara

Volatility

Snort

Surricata

Alright thanks!!

Hey @frikky,
I have a question regarding the cybersecurity assignment. I've created a Shuffle Python app and a separate frontend app using ReactJS. The connection between them is established via an API. I wanted to confirm if this approach is acceptable, or does the cybersecurity assignment also require modifications inside the Shuffle codebase same like frontend assignment ?

Hey @frikky,
I have a question regarding the cybersecurity assignment. I've created a Shuffle Python app and a separate frontend app using ReactJS. The connection between them is established via an API. I wanted to confirm if this approach is acceptable, or does the cybersecurity assignment also require modifications inside the Shuffle codebase same like frontend assignment ?

Hey!
It's not supposed to have a frontend. This is a cybersecurity task focused on the app itself. The app should be used from within a workflow in Shuffle. How did you connect a separate frontend to it?
The idea of a translator system that you've made may come in handy tho. Please do submit it so we can see what you did either way (knowing frontend is a good thing ;))

Hi @frikky  My question is regarding the GitHub Octernship cybersecurity assignment :)


Set the isDirectory flag appropriately

Set the isDirectory flag appropriately when using the currentDirectory() option

I signed it!


Swagger API definition and testing

In this pull request:

API definition is loaded from swagger.yaml file
nose tests check that EnrichmentService.py returns data in correct structure
apiTester.py performs compliance testing (for enrichment-api implemented here or other implementations of the same API).

@jblom -- can you have a look and let me know what you think? Is this going in the right direction?


Event Request: Add OnAfterSetFilter events for accounting schedules

In Codeunit 8 AccSchedManagement please add a few events that let us customize the filters that are set on the G/L account and cash flow account. Something like
OnAfterSetGLAccRowFilters
OnAfterSetCFAccRowFilters
OnAfterSetGLAccColumnFilters
OnAfterSetCFAccColumnFilters
called just after the relative function. This way we can add some more filters without having to completely rewrite the calculation code in OnBeforeCalcCellExit.
Plus: an event OnAfterSetEntryFilters<InsertTableNameHere> that provides us the possibility to customize the filters set on the various entry tables that are summed up for calculation (= G/L Entry, Analysis View Entry, Analysis View Budget Entry Cash Flow Forecast Entry and G/L Budget Entry) would come in handy to customize the filters that effectively get set for calculation.

Please provide more information about OnAfterSetEntryFilters.

I have currently designed the events on my local database as follows:
OnAfterSetFilterGLEntry(
  VAR GLAcc: record "G/L Account";
  VAR AccSchedLine: record "Acc. Schedule Line";
  VAR ColumnLayout: record "Column Layout";
  VAR GLEntry: record "G/L Entry);

The same goes for the following events
OnAfterSetFiltersCFForecastEntry (Cash Flow Forecast Entry)
OnAfterSetFiltersGLBudgEntry (G/L Budget Entry)
OnAfterSetFiltersAnalysisViewEntryGL (Analysis View Entry)
OnAfterSetFiltersAnalysisViewEntryCF (Analysis View Entry)
OnAfterSetFiltersAnalysisViewBudgEntry (Analysis View Budget Entry)
depending on whether it is a G/L Account or CF Account, the respective record should be passed.
The events are raised in the method CalcGLAcc (and CalcCFAccount respectively) just after all the various filters have been applied to the entry table.


Bug fix revert

here i create changes to README.md files according to course requirement . then revert it

pull request for my work


Refactoring and fix Ui issue

Issue/Task Number: #370
Overview
This PR fix Design issue and refactor parts of the big files component.
Changes

Fix Total supply shows 0 after minting a token on creation
Fix When accessing a wallet detail, the "Wallet" section is not highlighted anymore in the menu
Show primary/burn/secondary in wallets list when making a transaction
Fix can't see all the wallets when creating a transaction request
Fix input floating placeholder browser compatibility
Rename public/private to access/secret in Key listing
Add copy icon for ID in every table and screen
Always show the copy icon on detail page
Allow amount to not be passed when creating a token
Add tooltip in transaction modal to explain the second token / amount fields
Add client validation for max 18 digits when creating a token
View token history is not working (wrong link with 2 /)
Add copy button for API keys
Refactor big files

Usage

for the new dropdown wallet, go to any page that has the select wallet input and try searching

Impact
Deploy as usual.

[ ] Can’t edit account categories
[ ] Can’t click on the breadcrumb to navigate
[ ] In the Key lists (in the tables) rename the header Key to API Key for eWallet API Keys and rename Key to Access Key for the Access keys
[ ] In the Key lists: Rename the Generate Key button to Generate API Key and Generate Access Key
[ ] Genesis address GET error is not handled
[ ] Missing copy to clipboard buttons in history
[ ] Transaction request/consumption still not support exchange
[ ] Clear address input on transaction consumption
[ ] Status column in consumption list should use the same graphics as the status column in transaction list
[ ] Can we make the Account ID clickable (same as the Account Name) in the transaction request Tab?
[ ] Can we make the User ID clickable in the transaction request tab?
[ ] Also in the consumption tab, addresses and Ids should be clickable
[ ] Client validation 18 decimals


PRED-2832: Batch scoring with prediction explanations produces rows with varying column lengths

Fixes the issue for prediction explanations when response rows have different number of columns depending on the number of prediction explanations in the Prediction Servers output.
This PR sets the number of rows in the output response to always be equal to max_prediction_explanations from the input, padding missing explanations with empty values if any.

Coverage increased (+0.007%) to 84.247% when pulling 1056c44aace891960a01f19ce0661e8ddbf48bfd on andriir/PRED-2832-pred-expl-pad-missing-rows into ffbba0acc5a903590096be6908abf69ba2eaac59 on master.

Coverage increased (+0.007%) to 84.247% when pulling 1056c44aace891960a01f19ce0661e8ddbf48bfd on andriir/PRED-2832-pred-expl-pad-missing-rows into ffbba0acc5a903590096be6908abf69ba2eaac59 on master.

Coverage increased (+0.007%) to 84.247% when pulling 1056c44aace891960a01f19ce0661e8ddbf48bfd on andriir/PRED-2832-pred-expl-pad-missing-rows into ffbba0acc5a903590096be6908abf69ba2eaac59 on master.

Coverage increased (+0.007%) to 84.247% when pulling 1056c44aace891960a01f19ce0661e8ddbf48bfd on andriir/PRED-2832-pred-expl-pad-missing-rows into ffbba0acc5a903590096be6908abf69ba2eaac59 on master.


fixes and features to release version 0.2.0

Document all modules in the documentation.
Fix old problems with the documentation.
Add a new python module.
Add tutorials in the documentation.
Minify the modules before freezing them.

It seems like the build passed successfully and the only failed builds come from the old Pro version of Travis CI that should no longer be active, and that's okay, although the build shouldn't be triggered. Anyway, this is good to merge.


the code has a little flaw

In inference.py, the function get_max_preds, I think the code shown as follows needs to add - 1 to its tail:
preds[:, :, 0] = (preds[:, :, 0]) % width
should be rectified as:
preds[:, :, 0] = (preds[:, :, 0]) % width - 1
So what's your opinion?

I made a mistake... you're right


add 24h cache to new calls to reduce page load by 66 requests/refresh

Address performance concerns flagged in https://x.com/GeukensMathieu/status/1798610685016109069

Thanks! Merged. Should be rebuilding now. I cleared the cloudflare cache so it should be in production very soon if not already.


[Bug]: Workflow does not get triggered occasionally, due to which we do not get the slack notification - seen in the cypress dashboard app

Is there an existing issue for this?

[X] I have searched the existing issues

Description
For the cypress dashboard app, when we add a test to the flaky list, at times the workflow does not get triggered and we do not see the slack notification
Steps To Reproduce
Slack thread with discussion

Go to the cypress dashboard identified flaky tests tab
Add a test to flaky.
Note that when we add the test to flaky, at times, the slack notification does not come up, though the test gets added
Additional observation from @ApekshaBhosale  - this happens when “add” modal doesn’t close after adding the test.

Public Sample App
No response
Environment
Production
Severity
High (Blocker to building or releasing)
Issue video log
No response
Version
Cloud

Closing this issue as a duplicate of  - https://github.com/appsmithorg/appsmith/issues/34012


Push. Cordova dependency

Description
In latest update (6.10), cordova has been added as a dependency, I was wondering if there is a need for it. In my project cordova adds 5k. lines to my package-lock.json. I just can't find if cordova is used somewhere in project.
Environment

Platform: Capacitor/Cordova
Kit: Push
Kit Version: 6.10.0-300

Other
Also @types/cordova was added in dependencies, but it already exists in devDependencies.

Hello @suyundukov
A new version of the Cordova Push plugin has been released. Please update to the latest version to get rid of this problem.

Thank you!


ClassCastException

I have this exception in Fragment (I use AA framework) after:
@Background
    void setAdapter() {
        setAdapterUI(RestClient.getInstance().getRegions());
    }

@UiThread
void setAdapterUI(Regions[] regions) {
adapter = new RequestPagingAdapter(mActivity, regions, history);
listView.setAdapter(adapter);
listView.setHasMoreItems(true);  //RequestsHistoryFragment line 83
}

java.lang.ClassCastException: com.opentaxi.android.adapters.RequestPagingAdapter cannot be cast to android.widget.HeaderViewListAdapter
	at com.paging.listview.PagingListView.setHasMoreItems(PagingListView.java:54)
	at com.opentaxi.android.fragments.RequestsHistoryFragment.setAdapterUI(RequestsHistoryFragment.java:83)
	at com.opentaxi.android.fragments.RequestsHistoryFragment_.access$101(RequestsHistoryFragment_.java:27)
	at com.opentaxi.android.fragments.RequestsHistoryFragment_$4.run(RequestsHistoryFragment_.java:136)
	at android.os.Handler.handleCallback(Handler.java:615)
	at android.os.Handler.dispatchMessage(Handler.java:92)
	at android.os.Looper.loop(Looper.java:137)
	at android.app.ActivityThread.main(ActivityThread.java:4747)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:511)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
	at dalvik.system.NativeStart.main(Native Method)

http://stackoverflow.com/questions/24700588/i-am-using-the-listview-add-remove-footer-for-listview-cross-app-in-android-vers

Hello! Sorry to not reply you quickly, we had a carnival holidays here in Argentina. So, finally you can fix it?

yes I fix it with change order of:

listView.setHasMoreItems(true);
listView.setAdapter(adapter);
@nicolasjafelle can you change it in sample app too?

To be honest I am not following anymore this library, I want to do the same but with RecyclerView, but I will change it in a couple of hours. Thanks!

you can add an other branch with RecyclerView and what is the advantage of RecyclerView ?

The advantages will be the same as the pros and cons between Listview and RecyclerView, basically more flexibility to draw items with the layout manager and out of the box animations and listeners like swipes. The not so good you have to write more boilerplate code with RecyclerView.


fix: some fixes

Pull Request Test Coverage Report for Build 1868

23 of 38 (60.53%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.04%) to 76.842%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/components/TimePicker/helpers/get12HourTime.js
3
4
75.0%

src/components/TimePicker/timeSelect.js
19
33
57.58%

Totals

Change from base Build 1863:
-0.04%

Covered Lines:
1756

Relevant Lines:
2187

💛  - Coveralls


Assertion on non-empty upstream_requests in Router::Filter destructor in stress test

Title: Envoy crash with assertion on upstream_requests not empty in Router::Filter destructor in stress test using wrk
Description:
\During stress test using wrk with command similar to following:
wrk -t 1 --timeout 2m -c 10 -d 60s
with these data
= 1 threads and 10 connections
= Thread Stats   Avg      Stdev     Max   +/- Stdev
= Latency    38.91ms    5.71ms 101.70ms   90.33%
= Req/Sec   257.68     28.93   303.00     71.83%
= 15411 requests in 1.00m, 3.48MB read
= Requests/sec:    256.63
= Transfer/sec:     59.40KB
Call Stack:

#0  raise (sig=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x000055db2583a4bb in Envoy::SignalAction::sigHandler (sig=6, info=0x7f7f22b47e70, context=0x7f7f22b47d40) at external/envoy/source/common/signal/signal_action.cc:74
#2
#3  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#4  0x00007f7f25bc9535 in __GI_abort () at abort.c:79
#5  0x000055db2530a25c in Envoy::Router::Filter::~Filter (this=0x55db28cf5b90, __in_chrg=) at external/envoy/source/common/router/router.cc:253
#6  0x000055db25308894 in Envoy::Router::ProdFilter::~ProdFilter (this=0x55db28cf5b90, __in_chrg=) at bazel-out/k8-dbg/bin/external/envoy/source/common/router/_virtual_includes/router_lib/common/router/router.h:594
#7  0x000055db24a09493 in __gnu_cxx::new_allocator::destroy (this=0x55db28cf5b90, __p=0x55db28cf5b90) at /usr/include/c++/7/ext/new_allocator.h:140
#8  0x000055db24a09301 in std::allocator_traits >::destroy (__a=..., __p=0x55db28cf5b90) at /usr/include/c++/7/bits/alloc_traits.h:487
#9  0x000055db24a08ffd in std::_Sp_counted_ptr_inplace, (__gnu_cxx::_Lock_policy)2>::_M_dispose (this=0x55db28cf5b80) at /usr/include/c++/7/bits/shared_ptr_base.h:535
#10 0x000055db24618270 in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release (this=0x55db28cf5b80) at /usr/include/c++/7/bits/shared_ptr_base.h:154
#11 0x000055db24616ceb in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count (this=0x55db2b770588, __in_chrg=) at /usr/include/c++/7/bits/shared_ptr_base.h:684
#12 0x000055db24616586 in std::__shared_ptr::~__shared_ptr (this=0x55db2b770580, __in_chrg=) at /usr/include/c++/7/bits/shared_ptr_base.h:1123
#13 0x000055db246165a2 in std::shared_ptr::~shared_ptr (this=0x55db2b770580, __in_chrg=) at /usr/include/c++/7/bits/shared_ptr.h:93
#14 0x000055db253de61e in Envoy::Http::ConnectionManagerImpl::ActiveStreamDecoderFilter::~ActiveStreamDecoderFilter (this=0x55db2b770540, __in_chrg=, __vtt_parm=)
    at bazel-out/k8-dbg/bin/external/envoy/source/common/http/_virtual_includes/conn_manager_lib/common/http/conn_manager_impl.h:206
#15 0x000055db253de692 in Envoy::Http::ConnectionManagerImpl::ActiveStreamDecoderFilter::~ActiveStreamDecoderFilter (this=0x55db2b770540, __in_chrg=, __vtt_parm=)
    at bazel-out/k8-dbg/bin/external/envoy/source/common/http/_virtual_includes/conn_manager_lib/common/http/conn_manager_impl.h:206
#16 0x000055db253de6e2 in std::default_delete::operator() (this=0x55db28f35a30, __ptr=0x55db2b770540) at /usr/include/c++/7/bits/unique_ptr.h:78
#17 0x000055db253dc6fb in std::unique_ptr >::~unique_ptr (this=0x55db28f35a30,
    __in_chrg=) at /usr/include/c++/7/bits/unique_ptr.h:268
#18 0x000055db253e2dfe in __gnu_cxx::new_allocator > > >::destroy > > (this=0x55db2975f238, __p=0x55db28f35a30)
    at /usr/include/c++/7/ext/new_allocator.h:140
#19 0x000055db253e0673 in std::allocator_traits > > > >::destroy > > (__a=..., __p=0x55db28f35a30)
    at /usr/include/c++/7/bits/alloc_traits.h:487
#20 0x000055db253de364 in std::__cxx11::_List_base >, std::allocator > > >::_M_clear (this=0x55db2975f238) at /usr/include/c++/7/bits/list.tcc:76
#21 0x000055db253dc448 in std::__cxx11::_List_base >, std::allocator > > >::~_List_base (this=0x55db2975f238, __in_chrg=)
    at /usr/include/c++/7/bits/stl_list.h:442
#22 0x000055db253db200 in std::__cxx11::list >, std::allocator > > >::~list (this=0x55db2975f238, __in_chrg=)
    at /usr/include/c++/7/bits/stl_list.h:733
#23 0x000055db253c9ee9 in Envoy::Http::ConnectionManagerImpl::ActiveStream::~ActiveStream (this=0x55db2975f180, __in_chrg=) at external/envoy/source/common/http/conn_manager_impl.cc:542
#24 0x000055db253ca08e in Envoy::Http::ConnectionManagerImpl::ActiveStream::~ActiveStream (this=0x55db2975f180, __in_chrg=) at external/envoy/source/common/http/conn_manager_impl.cc:587
#25 0x000055db246c77ca in std::default_delete::operator() (this=0x55db29ea8800, __ptr=0x55db2975f180) at /usr/include/c++/7/bits/unique_ptr.h:78
#26 0x000055db24f5ab97 in std::unique_ptr >::reset (this=0x55db29ea8800, __p=0x55db2975f180) at /usr/include/c++/7/bits/unique_ptr.h:376
#27 0x000055db24f58392 in Envoy::Event::DispatcherImpl::clearDeferredDeleteList (this=0x55db283986e0) at external/envoy/source/common/event/dispatcher_impl.cc:95
#28 0x000055db24f576cd in Envoy::Event::DispatcherImpl::::operator()(void) const (__closure=0x55db28509b50) at external/envoy/source/common/event/dispatcher_impl.cc:42
#29 0x000055db24f59ad1 in std::_Function_handler >::_M_invoke(const std::_Any_data &) (
    __functor=...) at /usr/include/c++/7/bits/std_function.h:316
#30 0x000055db246bf992 in std::function::operator()() const (this=0x55db28509b50) at /usr/include/c++/7/bits/std_function.h:706
#31 0x000055db24f94a00 in Envoy::Event::TimerImpl::::operator()(int, short, void *) const (__closure=0x0, arg=0x55db28509ad0) at external/envoy/source/common/event/timer_impl.cc:23
#32 0x000055db24f94ab9 in Envoy::Event::TimerImpl::::_FUN(int, short, void *) () at external/envoy/source/common/event/timer_impl.cc:23
#33 0x000055db255f67ba in event_process_active_single_queue (base=0x55db2848c580, activeq=0x55db283646d0, max_to_process=2147483647, endtime=0x0)
    at /home/qiwzhang/.cache/bazel/_bazel_qiwzhang/60020ca4eb4bbfdb82eb82dc35e1335d/sandbox/linux-sandbox/1893/execroot/gcpproxy/external/com_github_libevent_libevent/event.c:1713
#34 0x000055db255f6ca1 in event_process_active (base=0x55db2848c580)
    at /home/qiwzhang/.cache/bazel/_bazel_qiwzhang/60020ca4eb4bbfdb82eb82dc35e1335d/sandbox/linux-sandbox/1893/execroot/gcpproxy/external/com_github_libevent_libevent/event.c:1805
#35 0x000055db255f7557 in event_base_loop (base=0x55db2848c580, flags=0)
    at /home/qiwzhang/.cache/bazel/_bazel_qiwzhang/60020ca4eb4bbfdb82eb82dc35e1335d/sandbox/linux-sandbox/1893/execroot/gcpproxy/external/com_github_libevent_libevent/event.c:2047
#36 0x000055db24f93516 in Envoy::Event::LibeventScheduler::run (this=0x55db28398730, mode=Envoy::Event::Dispatcher::RunType::Block) at external/envoy/source/common/event/libevent_scheduler.cc:47
#37 0x000055db24f59707 in Envoy::Event::DispatcherImpl::run (this=0x55db283986e0, type=Envoy::Event::Dispatcher::RunType::Block) at external/envoy/source/common/event/dispatcher_impl.cc:194
#38 0x000055db24f4225c in Envoy::Server::WorkerImpl::threadRoutine (this=0x55db2855a150, guard_dog=...) at external/envoy/source/server/worker_impl.cc:110
#39 0x000055db24f41b00 in Envoy::Server::WorkerImpl::::operator()(void) const (__closure=0x55db28a01268) at external/envoy/source/server/worker_impl.cc:75
#40 0x000055db24f42b6e in std::_Function_handler >::_M_invoke(const std::_Any_data &) (__functor=...) at /usr/include/c++/7/bits/std_function.h:316
#41 0x000055db246bf992 in std::function::operator()() const (this=0x55db28a01268) at /usr/include/c++/7/bits/std_function.h:706
#42 0x000055db2583fae8 in Envoy::Thread::ThreadImplPosix::::operator()(void *) const (__closure=0x0, arg=0x55db28a01260) at external/envoy/source/common/common/posix/thread_impl.cc:33
#43 0x000055db2583fb0c in Envoy::Thread::ThreadImplPosix::::_FUN(void *) () at external/envoy/source/common/common/posix/thread_impl.cc:35
#44 0x00007f7f25d6ffa3 in start_thread (arg=) at pthread_create.c:486
#45 0x00007f7f25ca04cf in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

This is from
ENVOY_SHA1 = "619eb5735f038a568df6497f28fac1bf809b2379"  # 11.06.2019

@snowp could you take a look at this?

It seems like somehow we're handling the defer delete for the HCM ActiveStream without all the upstream_requests_ being removed. The only place we call deferredDelete we very explicitly call onDestroy (which resets all upstream requests) for all the HCM filters before moving the stream onto the list of deferred deletions.
I'm wondering if what's going on is that the ActiveStream is being shut down between newStream being called on the HCM and decodeHeaders called on the stream: since we defer delete the ActiveStream, I think it might be possible for a decodeHeaders event to be enqueued while the event to destroy (e.g. due to a timeout, which wouldn't yet stop the headers from being processed) the stream has yet to be executed, resulting in a new upstream request being created between onDestroy and the list of deferred deletes being cleared.
If this is the case we should probably just bail out early in decodeHeaders based on state_.destroyed_
@alyssawilk

In our test setup, we had a  http filter making async_client call.  While the async_client call is in progress,  the filter is paused with STOP.    This filter is not handling onDestroy() to cancel active async_client call.  Could this be the root cause?
But, the upsteram_stream_ in Router is created on the Router::decodeHeader(). I assume if my filter decodeHeader() is paused with STOP,  Router::decodeHeader() should not be called.  Since Router::upstream_requests is not empty when crash,  it means my filter async_client call should have returned, it should have returned CONTINUE so that Router::decodeHeader() is called.

If this is reproducible, any chance you can rerun with -l trace and share the logs of the offending connection with us?  It might shortcut a lot of debugging!

It is a stress test.  with over 10k requests within 1m,   with "-l trace", it will generate too much logs.  problem may not happen.

reproduce steps is: run a stress test with over 10k request per minute for a couple hours.

Update:  I am trying to cancel the async_client in-flight request when filter is gone in my http custom filter to see if it fixes the problem.
Will update the result here.

After I cancel the in-flight async_client request on my custom Http Filter::onDestroy(), the problem went away.   Hence I close the issue.


C# Algorithm Benchmark

Describe the feature
Setup the benchmark for measuring C# algorithms.

git fetch origin
git checkout 31-c-algorithm-benchmark


Resolve component governance bugs

Should backport this to 6.0.

@javiercn @HaoK @pranavkm any objections to this?

@wtgodbe https://github.com/dotnet/spa-templates/pull/31

This is now a direct port of https://github.com/dotnet/spa-templates/pull/31 (CC @pranavkm @mkArtakMSFT @javiercn)


[Dialog] Add missing TypeScript style rule

[x] I have followed (at least) the PR section of the contributing guide.

Tried to use my own CSS class for the Dialog container and noticed the type definition was missing "container". The docs confirm it should be there.

@garredow It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!


Implement AsFd etc. for handle types in the rust-wasm bindings.

Implement AsFd/FromFd/IntoFd and AsRawFd/FromRawFd/IntoRawFd
traits for handle types in the rust-wasm bindings.
This makes it more convenient to implement types like File and
TcpStream as wrappers around handles, as they support the usual
I/O handle APIs, and can simply be constructed directly from FromFd
without having to use raw handles and the unsafe from_raw_fd.
These traits are part of the I/O safety RFC, which are
implemented in Rust nightly. In order to avoid having wit-bindgen
depend on nightly, this PR uses the io-lifetimes crate, which
contains standalone definitions of the main types and traits. Once
I/O safety is stabilized, the code can be switched to use std.

I'm a little hesitant to consider all resources an fd in the sense that fds are typically about I/O things but resources aren't particularly related to that. It should be possible to still implement these traits for generated types though. Perhaps this could be a macro option or otherwise just left to embedder crates?

Makes sense. I tend to think of all handles as being for I/O in a sense, from the perspective of a component, but you're right, it's not actually useful to have different types of handles accessible through the same type (OwnedFd). I'll move this to the toolchain.


Revert "chore refactor some rf code and delete rpc file"

Reverts apache/doris#31031

run buildall