Doesn't work when using the "proxy" config

Here are my configs:
{
	"proxy": "localhost:5000",
	"port": 7000
}

When I run the command without "proxy": "localhost:5000", an instance of Chrome opens on localhost:7000 as expected and everything is fine. With "proxy": "localhost:5000", it shows:
** browser-sync config **
{ injectChanges: false,
  files: [ './**/*.{html,htm,css,js}' ],
  watchOptions: { ignored: 'node_modules' },
  server: { baseDir: './', middleware: [ [Function], [Function] ] },
  logLevel: 'silent',
  proxy: 'localhost:5000',
  port: 7000 }

in the terminal and the process exits.
I tested a bit with some console.logs  in lite-server.js:
console.log('executed');
browserSync.init(config, cb);
console.log('not executed');

Versions:

lite-server version: 2.2.0
nodejs version: 5.9.1
npm version: 3.7.3
OS type/version: OSX El Capitan 10.11.3

Update
I gave version 2.1.0 a try and this time I got much clearer indications: Invalid config. You cannot specify both server & proxy options.
When merging the default config and the custom config, proxy and server are put together in the same set of configurations.
To temporarily fix my problem, I replaced
if (config.server.middleware) {
    config.server.middleware = _.compact(config.server.middleware);
}

by:
delete config.server;

So there are two problems:

The outputs from browser-sync are not being displayed in the terminal. This includes Invalid config. You cannot specify both server & proxy options, but also the message telling me to add

before the closing tag of the body when the application actually launches in proxy mode.
2. There is a conflict between the default server config and the proxy config.

The proxy and server configs in browsersync are mutually exclusive. The current lite-server always uses server in the config, so browsersync fails when including proxy config.
When trying the following bs-config.json with Browsersync (without lite-server), it proxies as expected:
{ "proxy": "http://www.example.com/" }
$ browser-sync --config bs-config.json start

But as soon as you add server config, it fails with an error:
{
  "proxy": "http://www.example.com/",
  "server": { "baseDir": "./" }
}
$ browser-sync --config bs-config.json start
Invalid config. You cannot specify both server & proxy options.

@maximedupre could you describe your use-case a bit more? Curious how beneficial it would be for lite-server to support proxy mode vs. using browsersync itself.

@cgmartin I was updating my initial post when you submitted your comment. Please see the update.

A fix should be possible for the lack of error logging. Good catch.
could you describe your use-case a bit more? Curious how beneficial it would be for lite-server to support proxy mode vs. using browsersync itself.

I am working on a SPA and my comprehension of lite-server is that it works well with SPAs, as opposed to browser-sync.
The reason I need to use a proxy is because I am developing the front and back ends at the same time. Since the (nodejs) server and lite-server can't have the same port, I need to use the nodejs server port as a proxy to lite-server. Essentially, I am doing this: https://gist.github.com/sogko/b53d33d4f3b40d3b4b2e

Makes sense. Would either of these alternative options be viable for your use-case?

Use lite-server as the static file server, and proxy via middleware to the separate nodejs back-end server on different port (see example).
Replace lite-server with your own server that handles both static file serving and AJAX API requests, and use browser-sync in proxy mode for development. The index.html fallback functionality from lite-server would just need to exist in your static file server.

I don't seem to get alternative number 1 to work. This is my middleware:
1: proxyMiddleware('/', {
    target: 'localhost:5000'
})

(My nodejs server handles both static file serving and AJAX API requests, which is why I redirect everything to localhost:5000).
When I start lite-server, it opens the browser and gives me this message:

Error occured while trying to proxy to: localhost:3000/

In the terminal:

[HPM] PROXY ERROR: EHOSTUNREACH. localhost:3000 -> localhost:5000/
16.04.10 17:59:28 500 GET /

However, I can access localhost:5000 just fine when I try manually. Maybe I'm doing something wrong, but I haven't figured it out yet.
As for alternative number 2, since browser-sync doesn't handle SPAs, wouldn't I lose most of the benefits?
Thank you for your help.

Glad it is working! BTW, there were some recent issues with proxy mode that are fixed in Browsersync 2.12.2+ (see #71).
To remove the request logging, there's an example in the README:

Another example: To remove one of the default middlewares, such as connect-logger, you can set it's array index to null:

module.exports = {
  server: {
    middleware: {
      0: null     // removes default `connect-logger` middleware
    }
  }
};

Ah right! Adding logLevel: 'silent' actually works, but it's removing a different layer of logs. Setting the first middleware to 0 solves the problem. Thanks!


Consider hiding containers that are created by the weave & scope scripts from Scope

Using the works.weave.role=system hack.

We do this for the containers in weave, but not scope.

I don't think we do it in weave: https://github.com/weaveworks/weave/blob/master/weave#L101

Also we missed one: https://github.com/weaveworks/scope/blob/master/scope#L112

Ah but for weave the container image should be labeled...

https://github.com/weaveworks/weave/blob/master/prog/weaveexec/Dockerfile#L4
and
https://github.com/weaveworks/scope/blob/master/docker/Dockerfile#L3

Okay so it turns out the labels in the Dockerfiles don't translate to labels on the container, but on the images.

Then how do the weave and scope containers ever get hidden?

we also filter on container name (see https://github.com/weaveworks/scope/blob/master/render/filters.go#L174)


FYI: "Deprecated"

Both the readme here and this article use the word "depreciated" in place of "deprecated".

Thanks, I'll correct that.

np common mistake


BUG: Missing spaces/newlines in saved rotation matrix/selection box?

Thank you for your feedback.
Hi @r03ert0 and @katjaq, this is a really nice tool! I've been playing around with it as part of openjournals/joss-reviews#2670, and have found a couple of strange behaviours - I will open one or two more issues after this one (sorry for the deluge!).
I am not 100% sure if they are bugs, or browser-specific quirks, but I thought I'd bring them to your attention just in case.
Current behaviour
When using the Save Rotation Matrix and Save Selection Box options, I end up with text files which appear to be missing delimiters (probably new lines). An example rotation matrix which I get is (also attached):
-0.8210228572672786 0.5441567480768857 -0.1726699202729373 35.392545939637480.42533908247618385 0.7847880104434116 0.45077094358730546 -155.19998034522737-0.38079933398443844 -0.2966499826169898 0.8757800266335992 -22.7527181620778830 0 0 1

Note that there are no newlines in the file - I think that the following is what should be produced:
-0.8210228572672786 0.5441567480768857 -0.1726699202729373 35.39254593963748
0.42533908247618385 0.7847880104434116 0.45077094358730546 -155.19998034522737
-0.38079933398443844 -0.2966499826169898 0.8757800266335992 -22.752718162077883
0 0 0 1

Similar behaviour occurs when using the Save Selection Box option - I end up with a selection.txt file which looks like this (also attached):
-30 -96 -7930 30 67

But I think what is probably correct is this:
-30 -96 -79
30 30 67

Version information (for bug reports)

Browser + version: Firefox 80.0.1
Your OS + version: Ubuntu 18.04

Thank you @pauldmccarthy !
How strange. We hadn't checked with Firefox, only Chrome (and our tests run on Chromium).
Here's the saveMatrix function, which does have a \n for line breaks:
function saveMatrix() {
  const {mv} = globals;
  const a = document.createElement('a');
  const m = mv.mri.MatrixVox2Mm;
  const str = m.map((o) => o.join(' ')).join('\n');
  a.href = 'data:text/csv;charset=utf-8,' + str;
  const name = prompt("Save Voxel To World Matrix (the inverse of the one displayed) As...", "reorient.mat");
  if(name !== null) {
    a.download=name;
    document.body.appendChild(a);
    a.click();
  }
}

We'll check in Firefox (also Safari, but maybe not Explorer :p [maybe we can add a warning])

I just tested on google chrome (still using Ubuntu 18.04), and indeed, the files save correctly :) So it seems to be firefox-specific. I'm not a Javascript expert, but your code looks pretty straightforward, so I can't imagine what is going on ...

Fixed in commit e2e6eb9
The plain text string goes into a URL. Chrome is ok with \n, but Firefox wants it properly translated to %0A : )


Quilt Support?

I know that this mod is not meant to be quilt compatible, It was just be nice to add quilt support

I don't have experience with Quilt, but I just tried it with the Quilt loader and it seems to work just as well as Fabric. Have you had compatibility issues?

I have now realized it was just a conflict with another mod

It pretty much is having issues with almost every other mod, probably just something odd to do with quilt

Can I have some examples? I'll look into it.

https://mclo.gs/uIIMzrU
I hope this will help

so it appears to be an issue with the Quilt Standard Libraries, could you check if you mod uses any of the unsupported features?

The log helped thanks.
Fixed in 4.3.1

thank you


[QUESTION]: ftp.emc.com login incorrect

How can the Team help you today?
Details: ?
Hi,
emc ftp server login is incorrect thus we are unable to get scini kernel module. Would you know another location of scini kernel driver? We used<EMAIL_ADDRESS>before.

Hello
The site has crashed and recovery is in progress.

Ok, thanks! Btw those credentials are all over the network. Thought they are widely known. Sorry for my misunderstanding.

Btw, @JacobGros , do you have an ETA?

Ok, thanks! Btw those credentials are all over the internet. Thought they are widely known. Sorry for my misunderstanding.

No worries

Btw, @JacobGros , do you have an ETA?

Not yet. I reached out to team for update and will update this issue when I find out.

It's working again! Thanks. :-)


generate_opendrive_world does not block till environment is ready

CARLA version: 0.9.13
Platform/OS: Ubuntu 20.04
Problem you have experienced:  when running scenario using OpenDrive file, scenario execution starts before world is fully initialized in Carla server.
What you expected to happen: generate_opendrive_world blocks until world is fully initialized, resulting in scenario starting execution when environment is ready
Steps to reproduce:

use OpenDrive map with long road (e.g., 10km).
run scenario_runner using that map
scenario starts execution and simulation time flows, even though Carla API does not return active agent

It is visible in console logs from Carla that server is stuck for long time on Create detail mesh... step.
Loading...
Building...
Building navigation:
- 33333 x 20 cells
- 0.0K verts, 0.0K tris
Finding walkable triangles...
Filter walkable surfaces...
Partition of walkable surfaces...
Remove walkable surfaces by agent raius...
Defining areas by material
Trace and simplify region contours...
WARNING: cannot parse georeference: ''. Using default values.
Build polygons mesh from contours...
Create detail mesh...

Other information (documentation you consulted, workarounds you tried):

preload OpenDrive map with python /opt/carla/PythonAPI/util/config.py -x  ACC_Straight_Freeway_CCRM_20.xodr
sleep 30
execute scenario

Attached osc and odr file which can help to reproduce the error:
ScenarioError.zip
First run will always lead to no collision in 30s (agents are not initialized before it starts)
Second run will lead to collision around 7 second.

Hi,
It's been a while, did you get to solve this issue? I'm facing the same problem currently. Thank you

still using the workaround to preload the world...

Thanks for the response!  I get this error when I use the workaround it got stuck for a long time this way.
TileRow 52/129: 16 tiles added (total 416)
TileRow 53/129: 12 tiles added (total 428)
TileRow 54/129: 8 tiles added (total 436)
TileRow 55/129: 6 tiles added (total 442)
TileRow 56/129: 8 tiles added (total 450)
TileRow 57/129: 8 tiles added (total 458)
TileRow 58/129: 7 tiles added (total 465)
TileRow 59/129: 7 tiles added (total 472)
TileRow 60/129: 8 tiles added (total 480)
TileRow 61/129: 7 tiles added (total 487)
TileRow 62/129: 7 tiles added (total 494)
TileRow 63/129: 10 tiles added (total 504)
TileRow 64/129: 12 tiles added (total 516)

I had to add georeference tag for this to work.
and client.generate_opendrive_world(osm_content) fails for me with the error
Loading /home/ship/carla/CarlaUE4/Content/Carla/Maps/Nav/OpenDriveMap.obj'...
WARNING: cannot parse georeference: ''. Using default values.
Signal 11 caught.
Malloc Size=65538 LargeMemoryPoolOffset=65554
CommonUnixCrashHandler: Signal=11
Malloc Size=131160 LargeMemoryPoolOffset=196744
Malloc Size=131160 LargeMemoryPoolOffset=327928
Engine crash handling finished; re-raising signal 11 for the default handler. Good bye.

any ideas on how to fix this? how did you add a georeference to osm map? thank you


Engine-only model loading fails to load some textures

At the following line, materialData[someMapName] is set to an actual pc.Texture and not a String (path to texture):
https://github.com/playcanvas/engine/blob/master/src/asset/asset-registry.js#L592
I suspect a previous attempt to load the same texture has overwritten the path with a texture and when accessed for the second time, the load fails (tries to concatenate a directory with an object).
This happens for when loading the playbot model in an engine-only context.

Looks like this has been an issue since: https://github.com/playcanvas/engine/pull/1692

Presumably this should have been removed in that PR?
https://github.com/playcanvas/engine/blob/master/src/asset/asset-registry.js#L540


Reuse Rucio object in WorkQueue start policy modules

Fixes #9952
Status
not-tested
Description
This fix provides a way to create a Rucio object instance for the ReqMgrInteractionTask Global WorkQueue CherryPy thread, and pass that object all the way down to the Start policy workqueue modules (which perform data location when a new GQE is getting created).
In addition to that, the closeWork() method, which can also add new elements to an already existent workflow, performs Rucio calls using the same object created upstream (by the cherrypy thread).
Is it backward compatible (if not, which system it affects?)
yes, even though there is a new optional parameter
Related PRs
none
External dependencies / deployment changes
There is one optional new workqueue parameter that can be created.

I'm still not sure, but it could be that this PR exposed an unexpected dependency on PhEDEx mocked APIs/data.
I guess we will have to mock Rucio calls/data first, then resume working on this PR...

test this please

test this please

test this please

test this please

test this please

test this please

Tested both at global and local workqueue level, everything seems to be working fine.

Thanks @amaltaro  Alan it was good even when I made my previous comments. I think this code may be considered ready.

Great, thank you very much, Todor!


Fix AssertionError in JapaneseTokenizer backtrace

Fix #775. Ported from related Lucene Patch.

Sorry that the cleaning is not thorough, my IDE auto fix some blanks. Commit history is somehow chaos too. I'll recreate PR if needed.

PR recreated, see here. Omit this one.


Ability to add context to profiles

I often work on projects where I have a local folder to be synchronized remotely with both a test and a production folder.
The ability to set up a local root path in the profile would be very useful.
As an alternative solution: the possibility of using the same context parameter in multi-context configurations

Look, maybe it’s the same as a request #107

yes, it is
thanks


consumer.OnStatistics event.

I just started using Confluent Kafka and I appreciate the efforts of developers.
I would like to print the consumer lag of a consumer and also display the list of consumers. I tried using consumer.OnStastistics event and it returns the Json data which has consumer lag and some more info.
Do we have any way by which I can fetch those ?
Regards,
Dexu5

consumer_lag is reported per consumed partition, so scan the returned JSON object for:
topics[..].partitions[..].consumer_lag (pseudo path syntax) according to the layout described here:
https://github.com/edenhill/librdkafka/wiki/Statistics

Also, Is there any way to display Kafka Consumer list ?
Regards,
Dexu5


shutdown.sh take so long time about more than 1 hour

OrientDB Version: Enterprise 2.2.22
Java Version: 1.8
OS: CentOs
Expected behavior
Can shutdown orientdb take a little time.
By the way, I have more than 40GB data.
Actual behavior
shutdown.sh take so long time about more than 1 hour
Steps to reproduce

@KishoDai how much RAM do you have? Could you send me several thread dumps which are done during the shutdown ? Please do not add them directly to the issue but add them as separate thread dumps.

@KishoDai BTW why you do not use latest versions?

@laa
Hi, laa, Can you please tell me which latest enterprise version is OK?

@laa
I Have 64GB memory. And I arranged JVM heap 10GB, and disk cache 48GB.
Sorry, I have killed orientdb, and have no record the dumps.

@KishoDai I suggest you use 2.2.25 - 2.2.26 versions. 2.2.26 is better of course. Without additional thread dumps it is really hard to say what is going on and why you had such situation even on very intensive benchmarks ODB is closed during 15 min on your disk cache size. I will put the status of this issue as waiting for additional info. I f you have got this situation next time, please provide me several thread dumps during dunno 1 min interval. Once you provide this information I think we will be able to fix the issue if that still persists of course.

Hi @laa
OK, I will try to use Enterprise-2.2.26.

@KishoDai did you have this issue?

@KishoDai do you still have this issue? If so could you create thread dump at the moment when shutdown is frozen?

@KishoDai did you have got this issue in the latest release?

@KishoDai did you have got this issue in the latest release?

Hi @laa
Thank you.
I have upgraded to enterprise-2.2.26, didn't encounter the issue recently.

@KishoDai glad to hear that. I am closing issue for now. Please if you, unfortunately, will encounter this issue again, I do suggest you create several (well at least 3) thread dumps in 5 min interval and provide them as gists in this issue. But I crossed fingers and dream that it will never happen again.


validate function breaks Next.js edge runtime

Hi, a user of next-safe-action reported a bug with the edge runtime, where the action execution breaks with this error when client input(s) get validated and parsed:
TypeError [ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING]: A dynamic import callback was not specified.

I created a repo with a minimal reproduction of the issue, which appears to be directly related to TypeSchema validate function.
Now, apparently Vercel is abandoning edge rendering and I don't know if this "bug" is easily fixable, so please let me know if I can do something to help solving this one, if possible.
Here's the original issue opened in next-safe-action repo:

TheEdoRan/next-safe-action#105

Thanks!

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

hey, @TheEdoRan! thanks for investigating and reporting! I spent some time looking on this and learned that the Edge runtime has a limited API, which doesn't support dynamic imports (await import(...)).
The thing is that typeschema heavily relies on those to allow for optional peer dependencies. But while they're what make typeschema technically possible, bundler support can be a bit spotty, causing issues like this.
The best path forward long term would be to move away of dynamic imports. Though I haven't yet found a way to do it without setbacks to the developer experience and/or treeshaking. I'll leave this issue open for now and focus on an alternative for dynamic imports.

Though I haven't yet found a way to do it without setbacks to the developer experience and/or treeshaking.

Yeah, moving away from dynamic imports would probably result in a worse DX. As I said in the OP, though, Vercel is apparently abandoning edge runtime in favor of PPR (Partial Prerendering), which I think is much better; edge runtime has always been very limited and unpleasant to use, but that's just my take. Now, I don't know if this will ever happen, but I think they understood that it isn't really the best rendering/compute model going forward.
What I'll do with next-safe-action (at least for now) is export a copy of the "safe action client" instance from /zod path, that will just support Zod as validation library and use its schema parse function, then explain why and when this is needed in a troubleshooting section on the docs website. All this to say that in my opinion it's probably fine to keep dynamic imports for the better DX, and if some users experience problems related to TypeSchema, they can switch the import from / to /zod to use the lib without issues, with the only drawback of limited validation library support. I think it's a good compromise.
Please let me know your thoughts about this, and once again, thanks for your work with this amazing library @decs!


Check if participantHistory is null in isInstanceOfflineFor method

Description
This PR adds the logic to check whether participantHistory is null in isInstanceOfflineFor method. If so, it denotes there is no history for this particular participant and the instance never goes down. Thus, the isInstanceOfflineFor method should return false if such scenario is met.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[ ] Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

[ ] Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

New configuration options
Deprecation of configurations
Signature changes to public methods/interfaces
New plugins added or old plugins removed

[ ] Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

Codecov Report

Merging #8175 (ee4f075) into master (a47af49) will decrease coverage by 3.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #8175      +/-   ##
==========================================
- Coverage   30.69%   27.59%   -3.11%
==========================================
  Files        1613     1612       -1
  Lines       83952    83962      +10
  Branches    12597    12602       +5
==========================================
- Hits        25768    23167    -2601
- Misses      55889    58644    +2755
+ Partials     2295     2151     -144

Flag
Coverage Δ

integration1
?

integration2
27.59% <0.00%> (-0.13%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...ntroller/helix/core/PinotHelixResourceManager.java
33.52% <0.00%> (-9.33%)
:arrow_down:

...apache/pinot/common/lineage/LineageEntryState.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...pinot/minion/exception/TaskCancelledException.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...minion/tasks/mergerollup/MergeRollupTaskUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...ion/tasks/mergerollup/MergeRollupTaskExecutor.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...nverttorawindex/ConvertToRawIndexTaskExecutor.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...e/pinot/common/minion/MergeRollupTaskMetadata.java
0.00% <0.00%> (-94.74%)
:arrow_down:

...rg/apache/pinot/common/lineage/SegmentLineage.java
0.00% <0.00%> (-91.31%)
:arrow_down:

...ache/pinot/common/lineage/SegmentLineageUtils.java
11.11% <0.00%> (-88.89%)
:arrow_down:

...plugin/segmentuploader/SegmentUploaderDefault.java
0.00% <0.00%> (-87.10%)
:arrow_down:

... and 158 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a47af49...ee4f075. Read the comment docs.


Native Renderer producing only a White Raw Image on receiver

In my test, I built the latest version of the master branch and copied the corresponding Android .aar and Windows .dll files.
I tried to replace the Video Renderer Component on a receiver from the Standalone Example: StandaloneDemo.unity
with the Native Renderer, and tried to use a Raw Image instead. But when initiating the Offer, the canvas remains white.

Info
I am using Unity 2019.4.9f1.
Android ARM64 and Windows x64 platforms.
What I have tried

Tested if the webrtc plugins I have compiled work with the regular Video Renderers for YUV and RGB. It does.
Tried the Demo examples with default setup.
Tried the Default Setup with a video call from 2 computers on the local network.
Exchanged the VideoRenderer in the Standalone example with the NativeRenderer, and hooked up the usual, and tested the offer, but white canvas Debug.Logs 2 frames and shows no video update on the RawImage receiver.

When inserting logs on the Native Renderer frame queue listener, there are only 2 frame updates.
So I'd like to ask if I am on the right track to setting up the Native Renderer properly or maybe, my .dlls and .aars were not built correctly. Maybe, an example, using the new Native Renderer would be nice.
Separate issue
When deploying the whole test to Android on one of my custom scenes, I get the following log message on every frame once in a call:
native_renderer.cpp:211] NativeRenderer: I420 frame resolution changed from what it was initialized with.

I figured what I did wrong on the Unity Editor side!
Basically, I thought that all I had to do was supply a Raw Image to the Native Renderer, and I had thought that the Native Renderer would combine the Y, U, V individual textures into a new texture that the Raw Image would directly use.
But what I needed to do was supply the Raw Image with the supplied YUV Feed Material that uses the shader with Y, U, V image inputs.

With this change, on the Unity Editor, it works with the Standalone Example for me currently, using the Native Renderer.


Infra dispatcher now cleanly stops on EOF

Whenever the receiver of an infra dispatcher message decides to close the connection (this can happen when receiving a malformed message on a connection that can be closed, e.g., reliable socket), Go will produce an EOF when the sender reads back. The sender logs the message, but continues to try to read, getting stuck in an infinite error print loop.
This PR changes the behavior and makes the sender cleanly shutdown on EOF.

This change is

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

go/lib/infra/disp/disp.go, line 193 at r1 (raw file):

// recvNext reads the next packet from the transport. On fatal errors, it
// returns true.
func (d *Dispatcher) recvNext() (fatalError bool) {

We don't use name return type anywhere (and you also don't use them in the code). You explain the return value in the docstring, so that should be good enough.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

go/lib/infra/disp/disp.go, line 193 at r1 (raw file):
Previously, shitz wrote…
We don't use name return type anywhere (and you also don't use them in the code). You explain the return value in the docstring, so that should be good enough.

Done.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.

go/lib/infra/disp/disp.go, line 199 at r2 (raw file):

		d.log.Warn("error", "err",
			common.NewBasicError(infra.StrTransportError, err, "op", "RecvFrom"))
		if err.Error() == "EOF" {

I wonder, would err == io.EOF work?

Comments from Reviewable

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

go/lib/infra/disp/disp.go, line 199 at r2 (raw file):
Previously, kormat (Stephen Shirley) wrote…
I wonder, would err == io.EOF work?

Done.

Comments from Reviewable

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


[Sema] Report unused newValue when getter is accessed by member reference

This PR fixes a missed scenario in an earlier fix for SR-964 which warns if a getter is accessed when the newValue parameter of a setter is not used. The previous fix, disappointingly misses the case of variables inside of classes or structs and only works on global variables. I experienced a bit of unit-test tunnel vision, and didn't test the scenario I was hoping to fix 😬.
I made this PR against 4.1 in hopes that it could land in the next release, even though I'm guessing it is a bit of a long shot!

Really ™  Resolves SR-964.

Much of this is pretty old code. @lattner or @xedin, do you think you can review this change? Do you think this is important enough to nominate for Swift-4.1?

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 63519a370dfc6485c7c43b28cf3a1fae512da8e1

Build failed
Swift Test OS X Platform
Git Sha - 63519a370dfc6485c7c43b28cf3a1fae512da8e1

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - 63519a370dfc6485c7c43b28cf3a1fae512da8e1

Build failed
Swift Test OS X Platform
Git Sha - 63519a370dfc6485c7c43b28cf3a1fae512da8e1

This change should be proposed on master first before being pulled into a release branch.  Release branches do not forward to master.

@KingOfBrian sorry for not re-directing sooner.  I may be mistaken but this does not look already on master.  Please create a new PR against master to review the change there.  It is very late to take this change for 4.1, but this looks promising!


Bug: Recursion limit exceeded since v0.54

We've hit a weird issue when trying to upgrade to Flow v0.54 (same goes for v0.54.1 and master), where a piece of code makes Flow hit a recursion limit.  I've not fully understood the underlying issue yet, but here's an example that illustrates the issue.
Example to reproduce.
v0.53: no issues.
v0.54: error.
What might be an interesting hint is the finding in the block in line 27 - 35.
(Sorry that the code is a little noisy—I haven't been able to make the example smaller yet.)

Sorry about that. You can add an number[] annotation to indices to work around the issue for now.

Thanks, that indeed solved our immediate issue.  We used this pattern of [...lazyIterable()] in multiple places in our code base, but this is the only instance that triggered the recursion limit… ¯\_(ツ)_/¯
Let me know if there's anything else I can do to help to get this resolved.

Extracting a repro case is already incredibly helpful :)
On Thu, Sep 7, 2017 at 12:48 AM Vincent Driessen<EMAIL_ADDRESS>wrote:

Thanks, that indeed solved our immediate issue. We used this pattern of
[...lazyIterable()] in multiple places in our code base, but this is the
only instance that triggered the recursion limit… ¯_(ツ)_/¯
Let me know if there's anything else I can do to help to get this resolved.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/facebook/flow/issues/4816#issuecomment-327717966, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAPjehxDgqa-Gi9l21sQ56oBsCo1SL5Xks5sf5_BgaJpZM4PO40Z
.


[SQL] [SPARK-8064] Fixes Parquet dependency issue for Hive 1.2.1 upgrade

This is a fork of PR #7191 authored by @steveloughran.  This PR fixes the Parquet dependency issue, which causes exception while creating metastore Parquet tables due to missing Hive Parquet SerDe classes.
The missing classes originally come from com.twitter:parquet-hadoop-bundle:1.6.0, which should be a transitive dependency of org.apache.hive:hive-exec:1.2.1.spark, but somehow gets evicted in SBT build. This PR adds it back as a dependency of spark-hive.
Please refer to [this failed Jenkins build] for details of related test failures.

Merged build triggered.

Merged build started.

Test build #39426 has started for   PR 7867 at commit dcbb391.

Test build #39426 has finished for   PR 7867 at commit dcbb391.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Closing this since it's merged into PR #7191.


Fix issue file exits in folder and need increase version number

I'm just try catch small code
Let's say I have a file model.rvt exits at the first time upload and then when I'm run for the second time, it should be allow increase  new version 👍

https://aps.autodesk.com/en/docs/bim360/v1/tutorials/document-management/upload-document-s3/

Hi @chuongmep,
Thanks for the PR, but if the file exists in the given folder, then these lines should create append a version for that file.

https://github.com/yiskang/aps-utility-service-dotnet/blob/master/Autodesk.Aps/Libs/DataManagementUtil.cs#L232
https://github.com/yiskang/aps-utility-service-dotnet/blob/master/Autodesk.Aps/Libs/DataManagementUtil.cs#L270

Hi @yiskang , it will have issue happen when I upload a file mode.rvt, the issue comup with :
"detail": "[WIP] Another object with the same name already exists in this container"

I found the root causes and fixed them in this commit. I'm not sure why the dynamic cast changed.
https://github.com/yiskang/aps-utility-service-dotnet/commit/53130e52db782836793a6588238cc634ce62ee45


visual edit: saving with CTRL+S

hello,
in the visual editor, I suppose it works fine from a windows terminal, but on most unix system, CTRL+S will block the terminal, cf. https://unix.stackexchange.com/questions/137842/what-is-the-point-of-ctrl-s
https://github.com/flagxor/ueforth/blob/c7dcbbef36402836d32ef4084c35ea91636d71ca/common/visual.fs#L135
I understand there isn't really another obvious shortcut, but maybe it would be possible to use alt+S?
For my part I've remapped it to CTRL+P, and I've also added a visual "saved" message which will help to make sure it tried to save:

 dup [char] P [char] @ - = if drop save update ." saved" exit then

Added Ctrl-P as an alias in 65eb318f2c29c9303657833102df7b532a66f280
And also added ." saved"


Jd/fixes area balancing models

closes #1107

It also:
Closes https://github.com/NREL-Sienna/PowerSimulations.jl/issues/1100
Closes https://github.com/NREL-Sienna/PowerSimulations.jl/issues/1103
Closes https://github.com/NREL-Sienna/PowerSimulations.jl/issues/1134
Closes https://github.com/NREL-Sienna/PowerSimulations.jl/issues/1135
via #1136


Next release - List of works to be done

Tasks to complete
Small fixes

[x] ✅ accepted #296
[x] ✅ accepted #502
[ ] 🧪 testing #475
[ ] 🧪 testing #562
[ ] 🌀 delayed #496
[ ] 🌀 delayed #497
[ ] 🌀 delayed #507

Features

[x] ✅ accepted #498
[ ] 🧪 testing #463
[ ] 🧪 testing #567
[ ] 🌀 delayed #499
[ ] 🌀 delayed #464
[ ] 🚫 canceled #538

Testing pre-release 1 (v0.7.80) - ea97158

[ ] #463
[ ] #464
[ ] #499
[ ] #296

Testing pre-release 3 (v0.7.80) - 780a703

[ ] #502
[ ] #464
[ ] #501

Setting release version to v0.7.90
Tor arrived from #445. Current master version now is v0.7.85. Adding +5 for this release features.

Removed from release #499

Removed from release #505. Early patched

Rebase release branch on origin/master - pending

Testing pre-release 6 (v0.7.97) - pending

[ ] #463
[ ] #499

Testing pre-release 6 (v0.7.97) - d8e33bc

[ ] #463
[ ] #499

Testing pre-release 7 (v0.8.2) - cf0ee04

[ ] #499

Testing pre-release 8 (v0.8.X) - pending

[ ] #499
[ ] #463
[ ] #502

Testing pre-release 8 (v0.8.X) - pending

[ ] #499
[ ] #463
[ ] #502
[ ] #517

Out of the flow changes made by @maxgithubprofile accepted

[x] 0e49680 - #548 merged on invalid branch. Deployed on release
[x] 8fb41fd - satolist.js patch

Testing pre-release 9 (v0.8.4) - cc4a164

[ ] #548
[ ] @maxgithubprofile patches

Out of the flow changes made by @maxgithubprofile accepted

e2aa17d - #548 merged on invalid branch. Deployed on release
e122f70 - satolist.js patch

Testing pre-release 8 (v0.8.3) - 843ffe1

[ ] e2aa17d, e122f70 - Out of the flow changes
[ ] #499
[ ] #463
[ ] #502
[ ] #517

Branch release was rebased from 54b0e9b to 61b5f81. Fixed

Testing pre-release 11 (v0.8.4) - 54b0e9b

[ ] 17b7f4c - Chat update from bastyon-chat
[ ] 14f96ad - Mobile video player fixes and other things by @maxgithubprofile. Out of the flow

Rebase release branch on origin/master - bccd03e

[ ] 🚫 removed #517
[ ] 🚫 temporary removed #498

Testing pre-release 14 (v0.8.4) - pending

[ ] #475
[ ] #499
[ ] #463

Testing pre-release 14 (v0.8.4) - 30f3297

[ ] #475
[ ] #499
[ ] #463

Returned ✅ accepted #498 on 83d2823

Testing pre-release 14 (v0.8.4) - pending

[ ] #475
[ ] #463

Testing pre-release 15 (v0.8.4) - 64759de

[ ] #475
[ ] #463

Testing pre-release 18 (v0.8.4) - 0513088

[ ] #562
[ ] #498
[ ] #567
[ ] #555
[ ] 🚫 removed #464

Testing pre-release 18 (v0.8.4) - pending

[ ] #562
[ ] #498
[ ] #567
[ ] #555
[ ] 🚫 removed #464


Modularize handlers to avoid code duplication in similar requests to different entities

For example, the PostVariant and PostIndividual handlers are nearly identical except for the words "Variant" and "Individual".

Completed.


Ctrl+C doesn't work inside Find result dialog

With this plugin installed Ctrl+C doesn't work in Find result dialog (Find In Files result dialog)

Many thanks for reporting! I'll notify you when I've fixed it. Give me a week or two... really busy IRL. :+1:


Typescript support with Strapi 4.2?

Hello,
is there any plans to migrate the actual starter to Strapi 4.2 for Typescript support?
Thanks!

Or first we need some warning if starter not support for 4.2 or another version, I tried to install blog-next with 4.3.4 + Typescript it login and create a schema, okay but the data fail to insert and every time changed schema to support intenational it throws error.


Send data more frequently

Hi
Currently it seems like the plugin is sending all data once every 30 seconds. Is there any way to increase this interval? Maybe send the event / screen as soon as it changes?

This is something that is on the road map to make more configurable.
To begin with I set that interval that high to conserve battery and network traffic. I believe the default is something like 2 minutes.
May I ask why you'd like to send events instantly?

It's not that it is essential for my project, and should be more than fine to do it every 30 seconds. It was more out of curiosity, and this issue should just be marked as a suggestion. But I find it sufficient that it will be part of the 'more configureable' implementation.
But keep up the good work on this library, I find it very easy to use!

Thanks man, much appreciated!

Does that mean if you visit a page and leave (even if its only 1 second, less than 30 seconds), that it's still tracked?
I'm looking at the realtime view and it seems very weird... it's like 1 out of 10 trackScreenView's are getting tracked according to the name, but if I replace the GA call with a simple console log it's showing all of them perfectly.
I'm trying to basically just test that it's working and the realtime results are super weird.

Hi @9mm!
The GA native library will collect all tracking-calls, and send them out as a batch every 20 seconds.
So, you shouldn't really lose any screen-tracking. But obviously, since it waits 20 seconds, this means that the realtime-view will always lag a little behind.
If the realtime view is important to you, you can edit the dispatchInterval in this file; https://github.com/idehub/react-native-google-analytics-bridge/blob/master/ios/RCTGoogleAnalyticsBridge/RCTGoogleAnalyticsBridge/RCTGoogleAnalyticsBridge.m#L22
I am also planning on making this configurable, but haven't really gotten around to it.


Log entire context of every request to logs mongo cluster

I'm not sure if we can use logs.do yet ... @AggressivelyMeows is that ready to accept requests?
I'm thinking that it might be more efficiently to log to the logs cluster ourselves via our generic proxy

Completed in https://github.com/drivly/ctx.do/commit/97fc0696c169087d744fa93811817466bee4d02b


Update README.md

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Can we discuss the need for this change first? Thanks.

@noor984 Thanks for your contribution. I'm not sure whether this npm command would be relevant to this specific project. If it is, could you add more detail about when this command would be relevant and re-open the pull request?


How to set the maxdisp value for a custom dataset?

Does the maxdisp value has a influence on the result of inference time or the performance? Besides, the result does not work well on my own dataset, I guess it is the problem of maxdisp value.

Yes, different maximum disparity demands of your data could be the reason for bad performance.
Did you fine-tune the model on your data? This is often necessary for good performance, especially on data that does not closely resemble the traffic scenes of KITTI oder DrivingStereo.


[BugFix] Fix bug ttl_number use current time during optimization refresh

What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes:

Fixes #
Problem Summary(Required):

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 3.0
[x] 2.5
[ ] 2.4
[ ] 2.3

[FE PR Coverage Check]
:heart_eyes: pass : 29 / 30 (96.67%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/OlapTable.java
18
19
94.74%
[1137]

:large_blue_circle:
com/starrocks/scheduler/PartitionBasedMaterializedViewRefreshProcessor.java
7
7
100.00%
[]

:large_blue_circle:
com/starrocks/scheduler/MvTaskRunContext.java
4
4
100.00%
[]

[FE PR Coverage Check]
:heart_eyes: pass : 31 / 35 (88.57%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/catalog/OlapTable.java
20
24
83.33%
[1117, 1139, 1146, 1151]

:large_blue_circle:
com/starrocks/scheduler/PartitionBasedMaterializedViewRefreshProcessor.java
7
7
100.00%
[]

:large_blue_circle:
com/starrocks/scheduler/MvTaskRunContext.java
4
4
100.00%
[]

@Mergifyio backport branch-3.0

@Mergifyio backport branch-2.5


Refactor: Remove Lifecycles and Hooks

The security audit issue will be resolved in the next sea-orm release.


Cannot Drag Spells to Items with Spells

In v11 I cannot draga spells from item or compendiums to the spells tab.
Version 11.304
DND world 2.2.1

Can also confirm this.  Unable to add spells since 11.304

I am not certain this has ever been an intended use.

Foundry: 10.303
dnd5e: 2.2.1
IwS: 1.3.1
You can do so in the above version.  And it is the best thing ever.  It's how I organize what feature or item gives my players additional spells, without having to clutter my items tab.  I love this feature.  I hope you can bring it back in V11.X dnd5e 2.2.X

No warnings, or errors in the console to help diagnose.


OCommandSQL and Orient Console needs a wrapper Select to work properly in a specific scenario.

Following Orient SQL doesn't work when I executed it from java using OCommandSQL and Orient Console.
SELECT intersect($a.idx, $b.idx) let
 $a=(select idx from (select expand(both()) from Person where idx = 1)),
 $b=(select idx from (select expand(both()) from Person where idx = 2))

but when I added a wrapper select clause around the sql (like below), it work properly.
SELECT intersect from (
SELECT intersect($a.idx, $b.idx) let
 $a=(select idx from (select expand(both()) from Person where idx = 1)),
 $b=(select idx from (select expand(both()) from Person where idx = 2))
)

Both queries works fine in Studio.
Notes:

its not a critical bug, just reporting it so that it could be fixed, if needed.
there could be other kind of sqls which might have the same issue. I didnt try to find any of them.

Hi @vineethpeterjose
Just a couple of questions:

what version are you using?
what error do you see? Can you post a stack trace or error code? In case also a complete procedure to reproduce the problem will help (eg. plocal or remote?)

I tried it with 2.1.9 and it seems to work fine
Thanks
Luigi

Version: 2.1.9
No Error. value of 'intersect' is null with first sql.
I could reproduce it using orient-console.. (see below)
Also I have attached my sample code.
From Orient Console
mypc:~ vjose$ orientdb-console

OrientDB console v.2.1.9-SNAPSHOT (build 2.1.x@r; 2016-01-07 10:51:24+0000) www.orientdb.com
Type 'help' to display all the supported commands.
Installing extensions for GREMLIN language v.2.6.0

orientdb> connect remote:localhost/CUB1 cub xxxxx

Connecting to database [remote:localhost/CUB1] with user 'cub'...OK
orientdb {db=CUB1}> SELECT intersect($a.idx, $b.idx) let $a=(select idx from (select expand(both()) from Person where idx = 1)), $b=(select idx from (select expand(both()) from Person where idx = 17))

----+------
#   |@CLASS
----+------
0   |null
----+------

1 item(s) found. Query executed in 0.117 sec(s).
orientdb {db=CUB1}> SELECT intersect from (SELECT intersect($a.idx, $b.idx) let $a=(select idx from (select expand(both()) from Person where idx = 1)), $b=(select idx from (select expand(both()) from Person where idx = 17)))

----+------+---------
#   |@CLASS|intersect
----+------+---------
0   |null  |[12]
----+------+---------

1 item(s) found. Query executed in 0.124 sec(s).
orientdb {db=CUB1}>

OCommandSQL Query
query without wrapper select
String OSQL = "SELECT intersect($a.idx, $b.idx) as ids let"
				+ " $a=(select idx from (select expand(both()) from Person where idx = 1)),"
				+ " $b=(select idx from (select expand(both()) from Person where idx = 17))";

		OrientDynaElementIterable result = getGraph()
				.command(new OCommandSQL(OSQL)).execute();

		Iterator<Object> iterator = result.iterator();
		while (iterator.hasNext()) {

			OrientVertex v = (OrientVertex) iterator.next();
			System.out.println("OrientVertex: " + v);
			List<Long> ids = v.getProperty("ids");
			System.out.println("Common ids: " + ids);

		}

And its output...
OrientVertex: v(null)[#-2:473]
Common ids: null

Query with wrapper select
String OSQL = "SELECT intersect as ids from (SELECT intersect($a.idx, $b.idx) let"
				+ " $a=(select idx from (select expand(both()) from Person where idx = 1)),"
				+ " $b=(select idx from (select expand(both()) from Person where idx = 17)))";

		OrientDynaElementIterable result = getGraph()
				.command(new OCommandSQL(OSQL)).execute();

		Iterator<Object> iterator = result.iterator();
		while (iterator.hasNext()) {

			OrientVertex v = (OrientVertex) iterator.next();
			System.out.println("OrientVertex: " + v);
			List<Long> ids = v.getProperty("ids");
			System.out.println("Common ids: " + ids);

		}

And its output...
OrientVertex: v(null)[#-2:474]
Common ids: [1, 129, 35, 53, 103, 87, 121, 41, 137, 61, 79, 95]


HDFS-16553 Fix checkstyle for the length of BlockManager construction method over limit.

Description of PR
https://issues.apache.org/jira/browse/HDFS-16553
The length  of BlockManager construction method is 156 lines which is over 150 limit for BlockManager, do refactor the method to fix the checkstyle.
How was this patch tested?
For code changes:

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 52s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 26s

trunk passed

+1 :green_heart:
compile
1m 40s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 33s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 19s

trunk passed

+1 :green_heart:
mvnsite
1m 39s

trunk passed

+1 :green_heart:
javadoc
1m 16s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 44s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 49s

trunk passed

+1 :green_heart:
shadedclient
26m  6s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 24s

the patch passed

+1 :green_heart:
compile
1m 29s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 29s

the patch passed

+1 :green_heart:
compile
1m 21s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 21s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  1s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 80 unchanged - 4 fixed = 81 total (was 84)

+1 :green_heart:
mvnsite
1m 27s

the patch passed

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 32s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 32s

the patch passed

+1 :green_heart:
shadedclient
25m 40s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
351m 57s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 58s

The patch does not generate ASF License warnings.

469m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4211/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4211

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux dc6dec942341 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f4576d8f6412fcb22b1c93fa330f0c0f8609eacc

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4211/1/testReport/

Max. process+thread count
1899 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4211/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
17m 35s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
41m 19s

trunk passed

+1 :green_heart:
compile
1m 39s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 36s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
checkstyle
1m 18s

trunk passed

+1 :green_heart:
mvnsite
1m 40s

trunk passed

+1 :green_heart:
javadoc
1m 19s

trunk passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 44s

trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 47s

trunk passed

+1 :green_heart:
shadedclient
26m 11s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 24s

the patch passed

+1 :green_heart:
compile
1m 29s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 29s

the patch passed

+1 :green_heart:
compile
1m 19s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
javac
1m 19s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  1s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 80 unchanged - 4 fixed = 80 total (was 84)

+1 :green_heart:
mvnsite
1m 26s

the patch passed

+1 :green_heart:
javadoc
0m 59s

the patch passed with JDK Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 29s

the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

+1 :green_heart:
spotbugs
3m 30s

the patch passed

+1 :green_heart:
shadedclient
25m 51s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
350m  4s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 57s

The patch does not generate ASF License warnings.

484m 49s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestSeveralNameNodes

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4211/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/4211

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 562e9c09ef3b 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 68182bf713e1ba5f73d6e673bd5e2ec65cb1c8cc

Default Java
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-<IP_ADDRESS>+1-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4211/2/testReport/

Max. process+thread count
1948 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4211/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Committed to trunk. Thanks @smarthanwang for your contribution. Thank @ayushtkn, @tomscut for your reviews.


apostrophe around the dir flag argument

Add ' for --dir command to work using branch and subdir
At least using iterm on mac I had to add '' arround the dir flag argument.

:thinking: wait, why are quotes required here? I don't think that # should have a specific meaning on mac vs on linux, are you using a different shell?
What error were you getting?

Your right @jedevc I was using zsh and got this: zsh: no matches found: --dir=https://github.com/dagger/dagger#main:cmd/dagger
But with bash it works. Maybe revert this then?

What's weird is that I also use zsh - what do you get if you run the following:
$ echo foo#bar
foo#bar

I get the expected result on both zsh and bash :confused:

I got zsh: no matches found: foo#bar. Probably something with my zsh config then.


Consider integrating zig fmt into the build

Something like:

On Build, run zig fmt --check if EnforceCodeStyleInBuild is set.
Add a Format target that actually formats source files (i.e. just zig fmt <sources>).

A FormatOnBuild property would also be useful.
The Format target should always just do zig fmt.
If EnforceCodeStyleInBuild is set, run zig fmt --check before building.
If FormatOnBuild is set, run zig fmt before building (ignoring EnforceCodeStyleInBuild).


chore(master): release 0.15.0

:robot: I have created a release beep boop
0.15.0 (2023-10-16)
Features

downloading blocks of a file by index (#271) (c734585)
uploading blocks of a file by index (#270) (37f7207)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/fairDataSociety/fdp-storage/releases/tag/v0.15.0 :sunflower:


reserve a number for chef-sugar deprecation warnings

the work of implementing the warnings is happening in the chef-sugar gem but we need to not have an id collision.

Ideally we never need this, but sure


Update ru.json

We don't directly manage our translation files like this, please see here https://github.com/BetterDiscord/BetterDiscord/blob/main/CONTRIBUTING.md#translations


panic parsing metadata during server initialization

Getting the following error when launching the server within VS Code. On 0.26.1 of Regal, 0.68.0 of OPA, so latest.
Server initialization failed.
Message: failed to load workspace contents: failed to walk workspace dir "/path/to": failed to update parse: failed to update rego store with parsed module: failed to marshal module to JSON: ReadMapCB: object not ended with }, error found in #10 byte of ...|":"value""example":"|..., bigger context ...|IyAgIH0=","scope":"rule","custom":{"attr":"value""example":"resource \"aws_resource\" \"this\" {\n  |...

Seems to be related to parsing metadata of an usual format, here's a minimal example:
package something

# METADATA
# custom:
#  attr: value
#  example: |
#   resource "aws_resource" "this" {
#     attr = "value"
#   }
this := true

Let me know if there's any other info that would be helpful.

Hi Luke! 👋 And thanks for letting us know!
This is issue #1082 rearing its head in the language server, as every file in the workspace will be linted on launch. It’s been fixed, and v0.26.2 will be published today including that and some other fixes.

Fixed in #1087. Sorry for the inconvenience! v0.26.2 to be released later today.

Whoops, my issue searching failed me, sorry for the dupe.
Thanks for the quick fix!

No worries! I'd rather see duplicate issues than no one reporting. v0.26.2 is out now :)


Why there is no Code about service in .pb.swift

There are some code about service in my  .proto,  after  "protoc --swift_out=. im.proto" ,there is no code about service that I wanted in .pb.swift
service IM {
// 客户端发送消息
rpc SendMsg (SendMessage) returns (SendResult) {}
// 服务端推送新消息
rpc NewMsg (EmptyRequest) returns (stream NewMessage) {}
}

This has come up before, check out #793, #682 and #118.


mb_decode_mimeheader() fails on emails with multiple references

Describe the bug
I'm using laravel however this seems to be a php-imap issue so I will post it here. The connection used was gmail with the settings described in the wiki (app-password)
mb_decode_mimeheader() expects parameter 1 to be string, array given
on src/Header.php  private function decode($value)
on line 388

I have traced the issue back to 'References:' raw header

On normal emails, there is only one reference but some emails can have a hierarchy of emails in them so it picks up multiple references. This causes the public function rfc822_parse_headers($raw_headers) on line 171 to parse  'References:'  as an array rather than a string.
To Reproduce
Steps to reproduce the behavior:

use gmail connection (app password)

$client->connect();
       return $client->getFolders('folder name')->messages()->all()->get();

emails with multiple references will fail on mb_decode_mimeheader()

Desktop / Server (please complete the following information):

OS: macos 10.15.7 (19H2)
PHP: 7.4.13

Additional context
This only happens when an email contains multiple  'References:' on a single reference the behaviour is normal with out any issues.

I have the same problem.
solution to the problem:
\vendor\webklex\php-imap\src\Header.php 145       if (property_exists($header, 'references')) {             !is_array($header->references)?:$header->references=$header->references[1];             $this->attributes["references"] = $this->decode($header->references);         }

Hi @lutchin ,
thanks for your report :+1:
Please update your php-imap dependency to v2.2.5.
Best regards,


pad seconds of game duration to 2 places

Game duration has been displayed as 5:6 instead of 5:06. Added padding to two places to fix this.

Looks good to me!


fix(doc-tools-doc): toggle lang zh, nav switch back to en

Summary

🤖 Generated by Copilot at caa5987
This pull request enables multilingual navigation for the documentation site. It changes the modern.config.ts file to use locale-specific nav properties and a language-aware getNavbar function.
Details

🤖 Generated by Copilot at caa5987

Remove global navigation bar and add language-specific navigation bars for documentation site (link, link, link)

Related Issue

#3596
Checklist

[ ] I have added changeset via pnpm run change.
[ ] I have updated the documentation.
[ ] I have added tests to cover my changes.

Thanks. But there is a better way to solve the problem https://github.com/web-infra-dev/modern.js/pull/3601/files#diff-7035015058e915e5353012c1d3fdc789c14735a85a6931d0a661c0693cf2ddeaR145-R175 and we recommend to use themeConfig.nav instead of nav config in themeConfig.locales because the framework will handle i18n automatically in the former config.


Carthage build framework missing required keys

I built the framework using Carthage but while uploading it to the TestFlight, I recieved the following error:
This bundle Payload/Care Team.app/Frameworks/TPPDF.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion. Please find more information about CFBundleVersion at https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundleversion

Hi there, can you please take a look at the branch  hotfix/236-carthage-bundle-version and let me know if it resolves the issue

This should be fixed with 2.3.2
I will close it now, if error still occurs please reopen


GitHub: Invite member

Who should be invited to Catena-X ng
GitHub User: nd-circulor
Vouching person: evgenyvinokurov (Process Owner for Standardization within Catena - X Automotive Network e.V.)

Hi @evgenyvinokurov,
invitation was send:

After successfull invitation, you can add the user in to the desired gh-team.

@FaGru3n Could you also please send the invitation to CX NG for "hschwabe"? He joined the Technical Committe for Standardization at Catena -X as well.

@FaGru3n Could you also please send the invitation to CX NG for "hschwabe"? He joined the Technical Committe for Standardization at Catena -X as well.

@FaGru3n and another one, please "LoireGalia". Thank you

Invitaion for @nd-circulor @hschwabe @LoireGalia was made
@evgenyvinokurov Please review and close the issue 😉

Think now everyone is a member for the catenax ng GitHub Organisation @evgenyvinokurov will close the issue.
If you have problems feel free to contact us. 😉


CNAME for Akamai

Akamai does not support "cdnverify" , however it supports domain name validation with acme_challenge. To achieve this one can add CNAME is following format
_acme-challenge. -> .ak-acme-challenge.azureedge.net
I think documentation should include these details.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2004e554-882e-932e-d55b-7b60b53bcc5b
Version Independent ID: 67dd746b-88a3-b114-68e2-622c18e95853
Content: Failover across multiple Azure CDN endpoints with Traffic Manager
Content Source: articles/cdn/cdn-traffic-manager.md
Service: azure-cdn
GitHub Login: @asudbring
Microsoft Alias: allensu

@nitinkale , thank you for your feedback.
This article mentions a note as below:

And the following documentation mentions regarding _acme-challenge CNAME as below:
https://docs.microsoft.com/en-us/azure/cdn/cdn-custom-ssl?tabs=option-1-default-enable-https-with-a-cdn-managed-certificate#custom-domain-is-not-mapped-to-your-cdn-endpoint

Kindly let us know if the above helps or you need further assistance on this issue.

@nitinkale , just following up to check if you have any further queries on this issue.

Since, we haven't heard from you in sometime, we are closing this issue for now. If there are further questions regarding this matter, please reply and we will gladly continue the discussion.


CON-1740 add a target attribute to image component

What does this PR do? (please provide any background)
Adds a target attribute to the image component. This will allow us to have tile header images that when clicked on show a page in a new tab. This allows us to convert the static product tiles in TripApp to React.
What tests does this PR have?
New unit tests.
How can this be tested?

Checkout branch CON-1740-2 on TripApp
Run npm install to get the version of ui-toolkit from this PR
Build ui-toolkit since we're not using the pre-built package: cd node_modules/@holidayextras/ui-toolkit && npm install && npm run build
Go back to TripApp root: cd -
Start TripApp with npm start
Make a carpark search and look for a 'Taxi to the Airport' tile on the availability page
Inspect the tile and see that it is React and that it is good
Click on the tile image and see that you are taken to a landing page in a new tab

Screenshots / Screencast
What gif best describes how you feel about this work?

[x] I have checked our general contributing document and the project specific contributing document (if present) and I'm happy for this to be reviewed.

Reviewers
Review 1

[ ] :+1:

Review 2

[ ] :+1:

Review 3

[ ] :+1:

By adding a +1 you are confirming you have...

Witnessed the work behaving as expected (this could be on the author's machine or screencast).
Checked for coding anti-patterns.
Checked for appropriate test coverage.
Checked all the tests are passing.

taking 2⃣

Yup, works for me, nice work 👍

Yup all good

Good job! :) 👍


Multiple fragments from one mp3 file

Hi,
I've been playing around with deja vu and able to recognize one fingerprinted fragment but what i would like is to recognize all the known audio fragments from one 10 min audio file. I've been reading trough the issues but not able to find similar questions or examples. Can anyone please help me out with this? I must also say that i'm a newbie to python :)
Cheers,
Henk

Hi,
Thanks for you response, more then happy to. I'm using this to fingerprint the commercials:
from dejavu import Dejavu
import warnings
import json
warnings.filterwarnings("ignore")

# load config from a JSON file (or anything outputting a python dictionary)
with open("commercial.cnf") as f:

    config = json.load(f)

# create a Dejavu instance
djv = Dejavu(config)

# Fingerprint all the mp3's in the directory we give it
djv.fingerprint_directory("../commercials/december", [".wav"])

And I use this piece of code to scan trough a directory containing all the parts (currently 20 sec parts) of a larger recording I did split using ffmpeg.:
from dejavu import Dejavu
from dejavu.recognize import FileRecognizer
import os, fnmatch

def find_files(directory, pattern):
    for root, dirs, files in os.walk(directory):
        for basename in files:
            if fnmatch.fnmatch(basename, pattern):
                filename = os.path.join(root, basename)
                yield filename

config = {
    "database": {
         "host": "---",
       	"user": "---",
       	"passwd": "---",
       	"db": "---"
     },
     "database_type" : "mysql",
}

# create a dejavu object
djv = Dejavu(config)

# gather files to fingerprint
UNLABELED_AUDIO_DIR = "../test/"
PATTERN = "*.wav"
audio_paths = find_files(UNLABELED_AUDIO_DIR, PATTERN)

# recognize them one at a time
original_file_to_song = {}
for path in audio_paths:
    print "Attempting to recognize %s..." % path
    song = djv.recognize(FileRecognizer, path)
    original_file_to_song[path] = song

#print "Audio file at: %s was recognized as %s" % (path, song)
# see the songs you've recognized
for path, song in original_file_to_song.iteritems():
    print "Audio file at: %s was recognized as %s" % (path, song)

I also created a zip of the files i'm testing on, you can download it here: www.henk.it/deja_vu/examples.zip (246MB). For example:

20141229-0957-_00-00.wav > Should give no match
20141229-0957-_00-01.wav > Should give no match
20141229-0957-_00-02.wav > Should give no match
20141229-0957-_01-00.wav > Could give a match in the last few seconds
20141229-0957-_01-01.wav > Should  match with 20141229-0957-dezorg_veranderd_mee commercial

Hope this helps, please let me know if you need additional information.
Cheers,
Henk

Hi,
Any chance you where able to look why I do get matches when it shouldn't?
Cheers,
Henk
Verstuurd vanaf mijn iPad

Op 1 jan. 2015 om 00:13 heeft Will Drevo<EMAIL_ADDRESS>het volgende geschreven:
Please provide examples and code to run against, otherwise I can't evaluate whether yours is a real problem.
—
Reply to this email directly or view it on GitHub.

Hi worldveil,
You perhaps have an update for me? Don't get it why I do get a match on fragments when I should not return a match.
Cheers,
Henk

Hi worldveil,
You perhaps have an update for me? Don't get it why I do get a match on fragments when I should not return a match.
Cheers,
Henk

I have same situation as finding multiple fragments from one file. Is there any code that I can learn?
Thanks henkit


can not catch auth error when credentials are incorrect

android:
i try enter incorrect login/password pair and receive events Connected, then smack error, then Disconnected
I can't catch credentials error on app layer,
for example, on ios i receive Failed event, but not on android

WIll be added soon @dkramorov

@dkramorov Fixed.


Vertical polyline shapes are difficult to select and move

My actions before raising this issue

[x] Read/searched the docs
[x] Searched past issues

Vertical polyline shapes are difficult to select and move
Steps to Reproduce (for bugs)

the online job is: https://app.cvat.ai/tasks/251599/jobs/258215
1.draw a vertical polyline shape
2.hover cursor to select it to move,but it‘s difficulty to select the shape.
Expected Behaviour

it's easy to select the polyline shape.

Operating System and version (e.g. Linux, Windows, MacOS):
Code example or link to GitHub repo or gist to reproduce problem:
Other diagnostic information / logs:
Logs from `cvat` container

I would like to give this a go.
I can reproduce the issue
2 point polylines, in any direction:
I have to place my mouse exactly on the polyline to be able to select it.
3+ point polylines:
There is an area distant from the lines that allows for selection.
Root Cause
There is not a boundary around 2 point polylines for selecting.
Steps to fix
Look at the code for 3+ polylines and find out how the selection boundary works.
Add the boundary to 2 point polylines on all four sides.

@Andy-W-Developer
You are welcome


[SDK-1123] viewer sdk docs

What
Generating viewer sdk api docs with typedoc
Looks like we'll need to figure out some options to identify the right format for the generated docs. Github Pages for the vertex-web-sdk repo is serving two versions of the docs.
https://vertexvis.github.io/vertex-web-sdk/package/ was generated starting with the viewer package
npx typedoc src/index.ts --tsconfig tsconfig.docs.json --out docs/package

https://vertexvis.github.io/vertex-web-sdk/component/ was generated starting with the viewer component file
npx typedoc src/components/viewer/viewer.tsx --tsconfig tsconfig.docs.json --out docs/component

my questions at this point:

do we want to generate these docs for every package in this repo?
the defaults side navigation for the package generated docs seems a bit funny. I'll be looking at what's possible to clean that up. not sure why JSX appears.

is https://vertexvis.github.io/vertex-web-sdk/component/classes/viewer.html the closest to what we want to provide? is there more here that should be exposed / easy to find?
NOTE: the repo is temporarily set up to deploy github pages from docs/. still working out what the best process would be for generating and publishing them. was looking at the post commit hook or 'lint-staged' style approach, but feel like the command takes a bit too long for that, would be annoying.
Ticket
https://vertexvis.atlassian.net/browse/SDK-1123
Test Plan

Areas of Possible Regression

Out of scope changes made in PR

Dependencies

do we want to generate these docs for every package in this repo?

I think we start with the packages that are commonly used with working with the SDK. This'd include @vertexvis/geometry, @vertexvis/viewer, @vertexvis/utils.

the defaults side navigation for the package generated docs seems a bit funny. I'll be looking at what's possible to clean that up. not sure why JSX appears.

It does seem a bit over complicated. I kinda like the simplicity of ESDoc (example). They do have a TS plugin that maybe we can take a look at.

still working out what the best process would be for generating and publishing them. was looking at the post commit hook or 'lint-staged' style approach, but feel like the command takes a bit too long for that, would be annoying.

What do you think of doing this via Github Actions after successful publish?


[Doc] Working with containers guide not updated to use Docker-machine

Description of problem:
cc/ @moxiegirl
Docker documentation is not updated to use Docker machine.

Additional Information:
https://docs.docker.com/userguide/usingdocker/

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

Thanks @mchiang0610, it looks like this has already been resolved in https://github.com/docker/docker/pull/14713. The current version of the docs no longer contain the reference to boot2docker, but the fixed version has not been published yet on https://docs.docker.com (which will be together with the 1.9 release)


Missing Typescript type for Appearance

Description
Type for import Appearance on Typescript is missing
React Native version:
System:
OS: macOS 10.15.4
CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
Memory: 11.97 GB / 32.00 GB
Shell: 3.1.0 - /usr/local/bin/fish
Binaries:
Node: 13.11.0 - /var/folders/bd/k2ffsv5j2w15smsf94r39jqc0000gn/T/yarn--1586196714006-0.4378570942327491/node
Yarn: 1.22.4 - /var/folders/bd/k2ffsv5j2w15smsf94r39jqc0000gn/T/yarn--1586196714006-0.4378570942327491/yarn
npm: 6.13.7 - ~/.nvm/versions/node/v13.11.0/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
Managers:
CocoaPods: 1.9.1 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 13.4, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
Android SDK:
API Levels: 21, 23, 25, 26, 27, 28, 29
Build Tools: 28.0.3, 29.0.2
System Images: android-21 | Google APIs Intel x86 Atom_64, android-23 | Google APIs Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom, android-28 | Google APIs Intel x86 Atom_64, android-28 | Google Play Intel x86 Atom_64, android-29 | Google APIs Intel x86 Atom, android-29 | Google Play Intel x86 Atom_64
Android NDK: Not Found
IDEs:
Android Studio: 3.6 AI-192.7<IP_ADDRESS>08749
Xcode: 11.4/11E146 - /usr/bin/xcodebuild
Languages:
Python: 2.7.17 - /usr/local/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: 16.11.0 => 16.11.0
react-native: 0.62.0 => 0.62.0
npmGlobalPackages:
react-native: Not Found
Steps To Reproduce
Try and import from typescript:
import { Appearance } from 'react-native'

Expected Results
To find type

Hi @martintreurnicht I did a quick check of the types https://github.com/DefinitelyTyped/DefinitelyTyped/blob/cc2ea21db06ffacab61ea99a7b81ec9b866c95ae/types/react-native/index.d.ts#L8247
Seems like they are there. Could you verify your @types/react-nativeversion?

@safaiyeh Ok, i didn't realize that the separate types is still supported. i figured after you guys started adding types directly to react-native, @types/react-native will become deprecated. Is the official stance from react-native to still use @types/react-native? And if so, why does react-native include their own types that is not kept in sync?

@safaiyeh Ok, i didn't realize that the separate types is still supported. i figured after you guys started adding types directly to react-native, @types/react-native will become deprecated. Is the official stance from react-native to still use @types/react-native? And if so, why does react-native include their own types that is not kept in sync?

Ah never mind. I had a look in more detail and realized it's still coming from @types/react-native we were just not including it explicitly anymore, something else must be pulling it in. Thanks for the response!

Glad I could help!


W11 and WS2019 mission in the documentation

Hello
We don't see the latest OS  W11 and WS2019 in the figure 1
Thes OS should be in the Security Protocol Support by OS Version
https://learn.microsoft.com/en-us/security/engineering/solving-tls1-problem?WT.mc_id=wwc-aces#figure-1-security-protocol-support-by-os-version
My customer needs the status for W11 and WS2019.
Can I have  a quick feedback first from Engineering , then you may update the public documentation
Regards

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 345a3771-a7b3-54e9-33df-8f59e08133ba
Version Independent ID: fb607ebc-aaa1-4b16-dee7-0daa8f903de9
Content: Solving the TLS 1.0 Problem - Security documentation
Content Source: security-docs/engineering/Solving-TLS1-Problem.md
Service: security
GitHub Login: @Dansimp
Microsoft Alias: dansimp

issue opened 2 weeks and still no answer


fix(dashboard): load redshift date filter correctly

add convert_dttm method for redshift

SUMMARY

There was convert_dttm implementation missing for redshift
due to this date filter on redshit dataset not working
giving sqlalchemy error raise exc.CompileError( sqlalchemy.exc.CompileError: Cannot compile Column object until its 'name' is assigned.

query that was getting submitted: 10:20:33,526:INFO:superset.connectors.sqla.models:SELECT day AS day FROM (SELECT date_trunc('day', created_on)  as day FROM public.redshift_order) AS virtual_table WHERE day IN (<name unknown>)
BEFORE SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Thanks @gaurav7261 for the PR. Would you mind adding some unit tests (similar to this)?

yes sure, adding, but why ci is not running, do you have any idea?

@gaurav7261 given it's your first PR, the first CI run needs to be approved by a committer. I've gone ahead and approved the run.

fixing ci

@john-bodley  added test and fix ci, one line got missed, forced pushed in my fork, i think it is stuck in processing updates, can you please help, will it take time ?

closed and open new  pr as it was stucked in https://github.com/apache/superset/pull/26283

reopening to test

somehow this is not working, so reopen PR: https://github.com/apache/superset/pull/26283
please check here


Removed unused OCP keys

Removed two unused i18n keys

Clsoing this PR as I have address these issues and some other in another PR


Wrong Caching Shapefiles

When using your library like that
convertSHP2GeoJSON: (buffer) ->
    shp(buffer).then (geoJSON) ->
        return geoJSON

the item (buffer) gets added to the cache. When using the shp function with another buffer, the already added but wrong item gets returned. Which is not the way it should work!
function shp(base, whiteList) {
    if (cache.has(base)) {
        return Promise.resolve(cache.get(base));
    }
    return shp.getShapefile(base, whiteList).then(function (resp) {
        cache.set(base, resp);
        return resp;
    });
}

We think there is a problem with the set and has logic inside that functions. Any suggestions?
Thanks for creating such a library!

ok I see the issue

published 3.2.0 which should fix it

Wow! Thanks for the fast replay and fix!!! +1


Retain current drawings when adding new dataSets to the chart

Hi,
I would like to retain my current drawings (drawn using the new annotation feature) when I am out of the drawing mode.  That way, even if I add new indicators to the chart, I should be able to view existing drawings.  Current feature probably does not allow that or am I missing something?
Regards,
SD

It's not possible to retain the drawings across data updates.

Thank you for the prompt reply.  Is this something that is in the pipes.  I am happy to close the issue but in my opinion, this can be a great enhancement especially for AmStockCharts

We will consider it. Thanks!

Hi @debsush, we've added an annotation API which might be the thing you were looking for.
Please check our readme#annotation-api to dive into the new feature.
Sincerely Ben

Thank you.  This is great.  Would have appreciated a demo if possible.
Regards,
SD
On Mon, Jun 13, 2016 at 12:00 PM, Bny<EMAIL_ADDRESS>wrote:

Hi @debsush https://github.com/debsush, we've added an annotation API
which might be the thing you were looking for.
Please check our readme#annotation-api
https://github.com/amcharts/export#annotation-api to dive into the new
feature.
Sincerely Ben
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/amcharts/export/issues/28#issuecomment-225550625, or mute
the thread
https://github.com/notifications/unsubscribe/AOYQSbS8B2XroLp6ReCEx_8VqnsrCxufks5qLThngaJpZM4HlJvv
.

sure, no problem, please take a look to following demo and follow these steps:

Enter annotation mode
Draw some things on it
Press the "Save Annotations" button
Exit Annotations mode
Modify the datasets
Enter the Annotation mode
Press the "Place saved Annotations" button

http://jsfiddle.net/jmhqjhmm/
Sincerely Ben

It is not bringing back the saved annotation in my system. Not sure why
On 13 Jun 2016 13:28, "Bny"<EMAIL_ADDRESS>wrote:

sure, no problem, please take a look to following demo and follow these
steps:

Enter annotation mode
Draw some things on it
Press the "Save Annotations" button
Exit Annotations mode
Modify the datasets
Enter the Annotation mode
Press the "Place saved Annotations" button

http://jsfiddle.net/jmhqjhmm/
Sincerely Ben
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/amcharts/export/issues/28#issuecomment-225555608, or mute
the thread
https://github.com/notifications/unsubscribe/AOYQSfSSFLKixpHNsu3AP7NJhIJG6YLvks5qLT76gaJpZM4HlJvv
.


A lot of Integration tests fails >100

The test testRunAutoVT_moreCautious from integrationTests does not working.
it fails with
java.lang.NullPointerException
	at ghidra.feature.vt.api.db.VTSessionDB.initializePrograms(VTSessionDB.java:138)
	at ghidra.feature.vt.api.db.VTSessionDB.createVTSession(VTSessionDB.java:87)
	at ghidra.feature.vt.gui.VTTestEnv.createAndOpenVTSession(VTTestEnv.java:115)
	at ghidra.feature.vt.gui.VTTestEnv.createSession(VTTestEnv.java:111)
	at ghidra.feature.vt.api.VTAutoVersionTrackingTest.testRunAutoVT_moreCautious(VTAutoVersionTrackingTest.java:85)
	at generic.test.TestThread.run(TestThread.java:106)

Which on my examination related to missing VersionTracking/WallaceSrc and possible VersionTracking/WallaceSrc2 files/folders. This fails at least 100 tests.
Not only this one tests, but bunch of others related to VersionTracking

BasicSelfSimilarCorrelatorTest.testExactInstructions
This one also expect to have file pe/w2krtm/NOTEPAD.EXE.analyzed.dont.edit.

testLD_NoWith
This one fails with

java.lang.NullPointerException
	at ghidra.app.plugin.processors.sleigh.SleighLanguage.initialize(SleighLanguage.java:107)
	at ghidra.app.plugin.processors.sleigh.SleighLanguage.<init>(SleighLanguage.java:100)
	at ghidra.app.plugin.processors.sleigh.SleighLanguageProvider.getNewSleigh(SleighLanguageProvider.java:112)
	at ghidra.app.plugin.processors.sleigh.SleighLanguageProvider.getLanguage(SleighLanguageProvider.java:99)
	at ghidra.pcodeCPort.slgh_compile.WithBlockTest.setUp(WithBlockTest.java:47)
	at generic.test.TestThread.run(TestThread.java:106)

due to missing "TestWith:BE:32:default". Does I need to perform additional steps in addition to gradle buildGhidra

testWinmineNormalCases
This one fails when accessing "Winmine__XP.exe.gzf"

testDecompiler_CopyFromSymbolWithoutSelection
This one accessing "ghidra/app/extension/datatype/finder/functions_with_structure_usage.gzf"

testAddNameDiffOnSubOperandPickLatestMy
failing with

org.junit.ComparisonFailure: expected:<[NADA]> but was:<[FOUR]>
	at ghidra.app.merge.listing.EquateMergeManager1Test.testAddNameDiffOnSubOperandPickLatestMy(EquateMergeManager1Test.java:607)
	at generic.test.TestThread.run(TestThread.java:106)

Not sure what this is means.

testSaveButtonEnablement
Fails with

java.lang.AssertionError
	at ghidra.app.plugin.core.script.AbstractGhidraScriptMgrPluginTest.assertSaveButtonEnabled(AbstractGhidraScriptMgrPluginTest.java:1074)
	at ghidra.app.plugin.core.script.GhidraScriptMgrPlugin2Test.testSaveButtonEnablement(GhidraScriptMgrPlugin2Test.java:475)
	at generic.test.TestThread.run(TestThread.java:106)

Have no idea.
I will stop at that point, since I likely generate not very actionable list of things and it is boring to look for some omissions. You can take a look at list of failed tests here, in my build

And one more set of tests which are failing in Mac/Linux

testEdgeFocusMode_SCOPED_REVERSE

java.lang.AssertionError: Edge was not selected: [1, 2]
	at ghidra.graph.viewer.edge.VisualGraphPathHighlighterTest.assertInFocusedPath(VisualGraphPathHighlighterTest.java:668)
	at ghidra.graph.viewer.edge.VisualGraphPathHighlighterTest.assertAllEdgesInFocusedPath(VisualGraphPathHighlighterTest.java:718)
	at ghidra.graph.viewer.edge.VisualGraphPathHighlighterTest.testEdgeFocusMode_SCOPED_REVERSE(VisualGraphPathHighlighterTest.java:299)
	at generic.test.TestThread.run(TestThread.java:106)

Indeed. That's clear all that issues. I have other more interesting tests. but this one is closed I believe.

Actually I was a bit in hurry to close, since I check on build which run regular tests, but when I run build with integration tests it exhibit same amount of failing tests. Most of them due to to missing VersionTracking/WallaceSrc and possible VersionTracking/WallaceSrc2 files

I finally add copying of the files to build definition, and hopefully it helps
Build where I expect some reduction in failing tests
https://codevision.visualstudio.com/Ghidra/_build/results?buildId=12981&view=results

Still testLD_NoWith does not working and fails with NPE.
java.lang.NullPointerException
	at ghidra.app.plugin.processors.sleigh.SleighLanguage.initialize(SleighLanguage.java:115)
	at ghidra.app.plugin.processors.sleigh.SleighLanguage.<init>(SleighLanguage.java:101)
	at ghidra.app.plugin.processors.sleigh.SleighLanguageProvider.getNewSleigh(SleighLanguageProvider.java:112)
	at ghidra.app.plugin.processors.sleigh.SleighLanguageProvider.getLanguage(SleighLanguageProvider.java:99)
	at ghidra.pcodeCPort.slgh_compile.WithBlockTest.setUp(WithBlockTest.java:47)
	at generic.test.TestThread.run(TestThread.java:106)

I copy GhidraDocs/GhidraClass/ExerciseFiles/VersionTracking/WallaceSrc.exe to Ghidra/Test/TestResources/data/VersionTracking/WallaceSrc.exe, but in the test code I do not see .exe prefix. Should I drop .exe when copy files?

@ryanmkurtz can I ping you to answer my last question, I may push this forward.


refactored parsing code into new branch

Hey y'all. The ChatServlet file was getting bloated by functionality that didn't really belong there. The majority of the parsing that I was doing for message sanitation and styling was done there, so I ended up moving it into a new file. This reflects that change. It is done by ripping out all relevant sections of code from the chat-servlet branch and putting it into a new file: "MessageCleaner.java"

@alexandriastorm Yeah so I only remove the sections of code that deal with message sanitation. It still passes all of the checks and doesn't mess with the codebase at all.


Service Request: Spellcheck (nunit/docs)

Service Request: Spellcheck Automation
Prerequisites
This service is currently only a good fit in certain situations.

[x] The docs are in Markdown or similar format.
[x] The docs are written in English.

Request Information:

Repository URL: https://github.com/nunit/docs
Are you one of the maintainers of this repository?

Or, link to where spellcheck is discussed for the repository:

About Your Docs Setup

For Implementers or Would-be Implementers

[x] Implement according to the implementation guide
[x] Paste the PR link in the description or comments here
[x] Be sure you comment here along the way if you find anything challenging; we can use that to improve our process.

Completed: https://github.com/nunit/docs/pull/389
ℹ This is an archival item to capture a past request that I implemented according to these standards.


[TASK] /client/accounts/[account_id]

All transactions per bank account TABLE
This page is where we want to upload csv files from
ALL TABLE PAGES SHOULD BE ABLE TO CREATE, REMOVE, DELETE, AND UPDATE VALUES IN TABLE

closing this as we will be doing this as part of #41


Visualize images generated in training phase

This issue is for tracking the implements for Image API, which helps users to show images generated in training phase. I split the feature to several PRs.

[x] Server side API design: #83
[x] add base view on frontend: #83
[x] ~return error on view, ex) not install PIL, not have images or any other~
[ ] cache PNG data to DB, to avoid create PNG binary every time
[ ] polling to call GET API to automatically update
[ ] lazy load to image
[ ] update images to show already existed
[ ] more effective UI design
[ ] place a link to access the images page
[ ] user guide
[ ] examples

return error on view, ex) not install PIL, not have images or any other

the timing to save image is in training process, and warning log is output on training log when Pillow is not installed. so server does not have to return error.


Language Specifics are not implemented in Indexing and Search

Solr doesn't make it easy to implement multi-language analysis (tokenization) and search on both the front (search) and backend (indexing).  There are multiple approaches to this but the only one that doesn't turn the schema into a tangled mess of language specific fields, or add complexity to the queries requires adding a custom tokenizer to the Solr installation.  An example of such a tokenizer is provided in Trey Grainger's "Solr in Action" (p. 482)
We have yet to implement any special tokenization or search handling for multiple languages.

seems to be ok without


Line icon is missing?

Line is very popular messenger in Asia. Any chance you can add it?
https://media.line.me/en/how_to_install#lineitbutton

Sounds good! You can either send a Pull Request - or tell us where we can find an SVG.

@edent how about this one?
https://worldvectorlogo.com/logo/line-messenger

Done. 455 bytes.

Great! Thank you @RazrFalcon for help!


Different UVR modesl

is it possible to change the uvr model? since it seem like vocals and instrument are poorly separate (lot of back vocals , vocals still stuck in instrument) i would like to change it to uvr kim both vocals and instrument how can i do that if it possible?

when i'm making songs like seven by jungkook main part of the song is not recognized by ai and leave normal voice in that part so i assume vocals and instrument models are not very good at this