Add documentation setup with automated building and publishing to github pages

Look into JSdoc; https://github.com/psychoinformatics-de/shacl-vue/pull/26/commits/863e84c825cf1ff8c858c9255b382ebfa6f2879e already has a single example of a jsdoc-based docstring for a module.
For an html theme, investigate:

https://github.com/ankitskvmdam/clean-jsdoc-theme
https://github.com/SoftwareBrothers/better-docs
https://github.com/clenemt/docdash

JSDoc can be used for api documentation.
For general user and developer documentation, I have decided to go with Vitepress, since it's compatible with vuejs 3 and powered by vite tooling which is already used for the build process of this package.

With f432d21b86ff2240c07798f5d54942239ae80822 to df848e252ce9b1a944b7fa46fec6ffcae3d57a47 we now have a setup for docs that are deployed together with the demo shacl-vue application (at /docs) via github pages.

The only step left to figure out is how to use jdoc for api doc generation and then make the resulting pages part of the docs generated by vitepress


Rename some methods in DataParams

Rename these methods to be more consistent with others.
From:
    function SaveAs(aDest: TParams): IDataParams;
    function AsString(const SeparatorChar: string): string; overload;
    function AsString: string; overload;

To:
    function ToParams(aDest: TParams): IDataParams;
    function ToString(const aSeparator: string): string; overload;
    function ToString: string; overload;

More correct is:
    function AsRawUTF8(const aSeparator: RawUTF8): RawUTF8; overload;
    function AsRawUTF8: RawUTF8; overload;
    function ToParams(aDest: TParams): IDataParams;


Change installer animation

[ ] Change the GIF file used while app is installing.
[x] Update to Electron Builder for releases

Since the packager is electron-builder, it has a native installer progress bar.


#70: Complete build logic of native-image

This PR completes the build logic of native-image workflow.
Related issue: #70

@alfeilex thanks for your PR. It seems that ${releaseName} is the trick that fixes this. You also have removed the cancellation if nothing changed. I am fine with this as it simplifies things and also is good if the previous run failed, because then we did not get a new SNAPSHOT version. Regarding #70 this seems to be unrelated and changing the order of the OS matrix was also some kind of fix? If so I do not yet get it. Anyway ready for merge.

I have reverted the changes of the workflow because I only changed some things there for testing purposes. Should we remove the cancellation anyway?


Fix upgrade-ert regex for pivnet

The previous regex will match 1.10 ended by zero or more dots.
For example a version 2.1.10 would match or a version like
1.101.4 or even a version like 1.1.10. This commit makes the
regex much more specific to avoid future issues.

I'm going to fix this by using the fully-anchored regex everywhere. We've got an open thread with the Pivnet PM on desired changes to the pivnet-resource to allow better definition of what versions should be tracked.
Also, I think what we should do is change the upgrade-ert pipeline to verify that the version that is being requested to be upgraded to is the same minor version of the existing ERT.

See https://github.com/pivotal-cf/pcf-pipelines/commit/5f6ed105040b7ff3d6c89ca7fd7d39ce17f5fbc3


Fix timestamp field display in the search UI

It's broken at least for nanoseconds.

Closed by #3455


Non-resolvable parent POM for...maven-default-http-blocker (http://<IP_ADDRESS>/): Blocked mirror for repositories:

I try to compile a project that work fine with mvn , with settings.xml in standard directory {USER_HOME}/.m2
With mvnd i receive the error in title
Problem is that we have repo in http i think, but configuration for maven work fine, i'm missing something?

Adding to settings.xml:
     <mirrors>
          <mirror>
               <id>maven-default-http-blocker</id>
               <mirrorOf>dummy</mirrorOf>
               <name>Dummy mirror to override default blocking mirror that blocks http</name>
               <url>http://<IP_ADDRESS>/</url>
         </mirror>
    </mirrors>

resolve the problem :)


Activate pausable and define interfaceId

@0x0ece
Makes the method wormholeTransfer pausable.
Adds sollhint/prettier integration.
Checking that the interfaceId is the same of Wormhole721

LGTM, thanks!


Deepmerge ESM in html-to-text dependancy

Hi @Dave136,
I can't seem to get the package to work in a Nuxt repo.
Looks like deepmerge isn't providing an es module for html-to-text:
Uncaught SyntaxError: The requested module '/_nuxt/node_modules/.pnpm/deepmerge@4.3.1/node_modules/deepmerge/dist/cjs.js?v=74dcc2a2' does not provide an export named 'default' (at html-to-text.mjs?v=74dcc2a2:4:8)
Repro
Clone this repo, copy vue-email/playgrounds/nuxt into its own project, remove the aliasing to vue-email and run the project.

Hi, we are aware of this issue, and we are in the process of updating the bundler to resolve this type of issues, will let u know when we have it fixed, thanks

@Flowko are there any suggestions to patch and get the project working in the meantime?

it should be fixed in 0.6.2 if you can test and let us know

Hi, the error mentioned is gone, but it fails to do anything now. Here is new error that I'm getting:
[nuxt] [request error] [unhandled] [500] 'import' statement of ES modules is not supported                                               8:40:15 AM
Use asynchronous function 'importFromString' instead or replace it with dynamic 'import()' expression.
  at importFromStringSync (./node_modules/module-from-string/dist/index.mjs:247:13)
  at templateRender (./.nuxt/dev/index.mjs:10173:21)
  at useCompiler (./.nuxt/dev/index.mjs:10240:26)
  at async ./.nuxt/dev/index.mjs:10255:16
  at async Object.handler (./node_modules/h3/dist/index.mjs:1284:19)
  at async Server.toNodeHandle (./node_modules/h3/dist/index.mjs:1359:7)

Can remove ur node_modules folder and lock file, and install again?

I tried that didn't work, here is reproduction - https://github.com/v-moravec/nuxt-vue-email/
Just do yarn install, yarn dev and go to https://localhost:3000/api/email


Preparing for inclusion in HADES

I think Capr is a valuable resource that I would like to see added to the OHDSI HADES library. If you agree to add Capr to HADES, I would request some modifications to the repo:

Add some unit tests (maybe not fully covering all code right now). See CirceR for examples on how to implement unit tests.
Add GitHub actions (see description here)
Manually create a first release + tag
Add a NEWS.md file (see for example SqlRender)
Add Remotes section to DESCRIPTION for CirceR, so it will automatically be installed when calling remotes::install_github("ohdsi/Capr"). (see example Remotes section here). No need to add DatabaseConnector, as it is available in CRAN.
Make sure the master branch contains latest released version (as explained here), so remotes::install_github("ohdsi/Capr") installs the latest released version.
Use cosmo template for documentation website, and add a HADES link (see here and here)
Make README.md more consistent with HADES packages (see for example CohortMethod)

Add badges for Github action and codecov
Add link to HADES
Modify instructions to install (no need to mention dependencies that need to be installed, but should link to HADES site for general instructions on setting up R and Java)
Add links to PDF versions of manual, vignettes, and a link to the Capr GitHub pages (and enable GitHub pages)

Excellent news!
@schuemie please add Martin Lavallee - @mdlavallee92 - as the official owner of CAPR for OHDSI and invite him to the HADES calls. I can send you Martin's contact info if you need it.
@mdlavallee92 please respond to @schuemie regarding implementing these modifications if you're OK with being assigned this task.

No problem I will begin working on these updates to meet the HADES standards. Thanks @schuemie for the details on the modifications.

Thanks Martin!

Thanks! @mdlavallee92 is now admin of the repo.
@leeevans : could you send me Martin's e-mail address?

Just checking in: where are we on this?

Hi Martijn,
I pulled this over to develop waiting for @leeevans to review and then will pull to main. Sorry for the delays.
I am having trouble with the ubuntu develop version in github actions. It says that rcmdcheck is not loaded as a package. I will review the yaml file to try to figure out what is going on.

Regarding the reason rcmdcheck is not loading the error message in the github actions for ubuntu develop says that {curl} can not be installed because there is a missing dependency of libcurl. Is there a way to install libcurl since it is not an R package?

I've sort of given up on the develop version for GitHub Actions (see the chat in the HADES Teams channel). Feel free to delete it from the workflow.

@schuemie at long last I have finished the checklist for making this a HADES package (my apologies for the delay). Please let me know if it is missing anything.
I am working on some additional edits to package with @ablack3 and will continuously release them as those improve. Should I release this to CRAN as well? It has no warnings or notes when I build (after I add the additional folders to .Rbuildignore).

Great work! As you probably already saw, I found some further minor issues, but I'll already add Capr to HADES.
Unfortunately, you can't release Capr to CRAN, because it depends on CirceR, which is not in CRAN (and will likely never be in CRAN because its file size is bigger than what CRAN allows).
One important thing to keep in mind: You manually created the GitHub release this time, which was necessary because it was the very first release. Next time, don't create the release manually. GitHub Actions will do that automatically once all tests have passed.

Sorry, I know this is annoying, but could you rename the main branch to master? That would make it consistent with all other HADES packages (and makes the GitHub Actions, and things like the HADES package dashboard work properly).

I am going to push back against renaming branches.  It is now standard (and for laudable reasons) that the main branch in git repos be called main instead of master.
So I propose the converse: HADES packages that are still using master should change these to main.

That would be a massive change. Could you help me understand the benefit of spending precious develop cycles on that? To me it seems like a fairly arbitrary change.

Another option - leave default branches as is.

I am going to close this issue as it pertains to HADES inclusion. I do think the main v master branch discussion is warranted and should be brought back up in another avenue.

(We're switching all of HADES to main, so no action needs to be taken here)
Capr is now in HADES! @mdlavallee92 : would you mind posting an announcement of the current version in the HADES announcement thread? For normal releases we just do a short text with the biggest changes, but for a completely new package I recommend a longer post that introduces the new package to the HADES users.


update sedna controller (jointinference and federatedlearning controller) enhancement proposal

What type of PR is this?

What this PR does / why we need it:
update sedna controller (jointinference and federatedlearning controller) enhancement proposal.
Which issue(s) this PR fixes:

Fixes #

Unify the size of the graph and check whether there are format errors.

modified.

/lgtm

/lgtm

/approve


nx-go has a new maintainer! (was: Sunsetting nx-go)

Hi everyone,
Just a heads-up: I'm sunsetting the project nx-go. I haven't been using this library in my own projects for some time, and maintaining it is no longer feasible for me.
The code is open source and available for anyone to fork. If you're experienced in maintaining open-source libraries (with visible activity on GitHub/NPM), feel free to reach out on Discord or Twitter (links in my profile) about taking over. Don't bother applying if you are not actively maintaining any projects as I don't have time to guide you.
Thanks for your support and contributions over the years!

Hey there!
I'm excited to announce @utarwyn has reached out to me about taking over maintenance of this project! 🥳
I think this is great news for everybody using the plugin and I hope it'll become a better maintained library soon!

Welcome to the nx-go community :wave:
I'm happy to announce that I will be the new maintainer of the project!
Let's introduce myself
I'm a tech-lead engineer at Natixis and I work mainly on technologies like Kotlin, Golang, Angular, React, TypeScript, Nx. I am active on open-source projects that I believe in for several years. I use Typescript in my daily life for more than 7 years, nx for more than a year. I am a user of the plugin since last year: this is why I proposed my help to continue its development 🤝
Next subjects I will work on:

Add support for Nx 17 (#101)
Rewrite code to use the new Nx standards explained in the doc

Thanks @beeman for the amazing work over the years on the project.
Stay tuned for updates!

@utarwyn do you need help? i can help speed things up.

Hello @necmettindev, thank you for the proposal! I'm in vacation until 01/29... but when I get back, I'm going to push my initial work onto a new branch and any contributions will be really appreciated on it 👍

@utarwyn thanks, waiting your news

Here we go! The first beta of v3 is out 🚀
Check the changelog here: https://github.com/nx-go/nx-go/releases/tag/v3.0.0-beta.0
I invite you to discuss this major step further in issue #107.


Add some new information about education and time line

Add information about education, and time line

Add information about education, and time line


warning missing when importing duplicate dat

fixed in<EMAIL_ADDRESS>which floats in automatically


[NSDate] comparable protocol implementation.

Added basic comparison operators.
Equatable has been explicitly declared as a conformed protocol, whilst this is implicitly declared by conforming to the Comparable protocol, adding the explicit declaration makes it more readable and understandable that this is the case.

Please rebase your branch before pushing it here. Do not merge back from the master branch.


Unable to consumer new message after timeout error.

After running go binary for few hours, I get this error
[Sarama] 2016/03/16 14:51:37 consumer/broker/0 abandoned subscription to head_crawl/1 because consuming was taking too long
Once i get his message, I am not able to receive any new messages. How can i handle this issue?
I don't have this problem in my other 5 binaries.

This indicates that the queue of messages for that topic/partition is not being read; whatever goroutine or worker you have that should be reading from that channel is stuck or else so slow as to appear stuck.

   cgConfig := consumergroup.NewConfig()
cgConfig.Offsets.Initial = sarama.OffsetNewest
cgConfig.Offsets.ProcessingTimeout = 10 * time.Second
zookeeperNodes, cgConfig.Zookeeper.Chroot = kazoo.ParseConnectionString(zookeeper)
consumer, consumerErr := consumergroup.JoinConsumerGroup(consumerGroup, kafkaTopics, zookeeperNodes, cgConfig)
if consumerErr != nil {
	log.Fatalln(consumerErr)
}

c := make(chan os.Signal, 1)
signal.Notify(c, os.Interrupt)
go func() {
	<-c
	if err := consumer.Close(); err != nil {
		sarama.Logger.Println("Error closing the consumer", err)
	}
}()

go func() {
	for err := range consumer.Errors() {
		log.Println(err)
		if err := consumer.Close(); err != nil {
			sarama.Logger.Println("Error closing the consumer", err)
		}
	}
}()

offsets := make(map[string]map[int32]int64)

for message := range consumer.Messages() {

	ConsumeMessage(message)

	if offsets[message.Topic] == nil {
		offsets[message.Topic] = make(map[int32]int64)
	}

	if offsets[message.Topic][message.Partition] != 0 && offsets[message.Topic][message.Partition] != message.Offset-1 {
		log.Printf("Unexpected offset on %s:%d. Expected %d, found %d, diff %d.\n", message.Topic, message.Partition, offsets[message.Topic][message.Partition]+1, message.Offset, message.Offset-offsets[message.Topic][message.Partition]+1)
	}

	offsets[message.Topic][message.Partition] = message.Offset
	consumer.CommitUpto(message)
}

ConsumeMessage function sometimes take more than 5 minutes.

If ConsumeMessage can be slow, you should be setting Consumer.MaxProcessingTime (https://github.com/Shopify/sarama/blob/f26080eb84027ccbd6aca4565b540be1baafbc05/config.go#L173). However even at the default value, your consumer should resume automatically once ConsumeMessage finally returns.


Updating all the docs to the latest and greatest :)

Description (required)
Updating the GitHub action in every language to get consistency.
Related issues & labels (optional)

Closes #
Suggested label:

Yes! :D

@ollekz is my discord user name 👍

Thanks @ollegkz, I'll note that this update (in English) was already made and merged by another PR before, but we can still use the update in other languages; The safe ones (there are no other changes needed) are es, fr, and ko - could you remove the files under the other directories so that we can merge this? 🙌


Words correction does worse than better

What's the Problem?
When renaming an item, a red underline appears under incorrectly spelled words. Sometimes these underlined words corrects themselves without explicit user input. A lot of people do not have the os in the desired naming language for their files. On top of that, there are a lot of times when a user actually wants to spell the filename by a different encoding system: as example: ${1}${2}${3}_${name} where 1, 2 and 3 are some identifying characters that are not meant to form a word. Also, in a native-language-os, when downloading files, you're almost bound to download a file with English filename
Solution/Idea
Remove the correcting system or make it less intrusive, like: do not underline the words, but let the user select the words, right-click, and there see any suggestions. The user knows when the word might be misspelled, so he can double check by right-clicking
A lot of text context menus now-days provides such a way of correcting the words without showing additional visual effects
Alternatives
I find myself often renaming a file, then try to rename it again since the previous rename has corrected some intended words
Priorities

Capability
Priority

Allow the correcting system take place only by explicit user input
Must

Remove visual effects
Should

Provide a way to invoke the explicit input using the context menu (select text, right-click)
Should

Auto-correction
Won't

Files Version
Version: <IP_ADDRESS> OS Version: 10.0.22000.434
Windows Version
Edition	Windows 11 Pro Version	21H2 Installed on	21/10/05 OS build	22000.434 Experience	Windows Feature Experience Pack 1000.22000.434.0
Comments
No response

Merging with 7948


Error creating GL context; Some of the requested attributes are not supported

I built(release) according to instructions.
When I run, it outputs message:
Error creating GL context; Some of the requested attributes are not supported
Ubuntu 17.10 - Wayland.

This might be a hardware/driver issue. Which GPU and driver are you using?

Where can I find that information?

Same here, using Ubuntu 17.10 as well on a Nuc i5
$ lshw -c video
  *-display
       description: VGA compatible controller
       product: Iris Graphics 540
       vendor: Intel Corporation

$ modinfo i915
filename:       /lib/modules/4.13.0-32-generic/kernel/drivers/gpu/drm/i915/i915.ko
license:        GPL and additional rights
description:    Intel Graphics
author:         Intel Corporation
author:         Tungsten Graphics, Inc.

Acer notebook (Aspire V) running latest Fedora 27
$ lshw -c video
  *-display
       description: VGA compatible controller
       product: HD Graphics 5500
       vendor: Intel Corporation
       physical id: 2
       bus info: pci@0000:00:02.0
       version: 09
       width: 64 bits
       clock: 33MHz
       capabilities: msi pm vga_controller bus_master cap_list rom
       configuration: driver=i915 latency=0
       resources: irq:47 memory:c0000000-c0ffffff memory:b0000000-bfffffff ioport:4000(size=64) memory:c0000-dffff

$ modinfo i915
filename:       /lib/modules/4.14.16-300.fc27.x86_64/kernel/drivers/gpu/drm/i915/i915.ko.xz
license:        GPL and additional rights
description:    Intel Graphics
author:         Intel Corporation
author:         Tungsten Graphics, Inc.
firmware:       i915/bxt_dmc_ver1_07.bin
firmware:       i915/skl_dmc_ver1_26.bin
firmware:       i915/kbl_dmc_ver1_01.bin
firmware:       i915/kbl_guc_ver9_14.bin
firmware:       i915/bxt_guc_ver8_7.bin
firmware:       i915/skl_guc_ver6_1.bin
firmware:       i915/kbl_huc_ver02_00_1810.bin
firmware:       i915/bxt_huc_ver01_07_1398.bin
firmware:       i915/skl_huc_ver01_07_1398.bin
[....]

Same here, running on Wayland.
❯ sudo lshw -c video
  *-display
       description: VGA compatible controller
       product: HD Graphics 5500
       vendor: Intel Corporation
       physical id: 2
       bus info: pci@0000:00:02.0
       version: 09
       width: 64 bits
       clock: 33MHz
       capabilities: msi pm vga_controller bus_master cap_list rom
       configuration: driver=i915 latency=0
       resources: irq:43 memory:e0000000-e0ffffff memory:d0000000-dfffffff ioport:3000(size=64) memory:c0000-dffff

❯ modinfo i915
filename:       /lib/modules/4.13.0-32-generic/kernel/drivers/gpu/drm/i915/i915.ko

This could be a duplicate of #971. The workaround there works for me: env WAYLAND_DISPLAY= alacritty.

I think that issue is solved, but the problem remains: alacritty should be able to determine presence of wayland session without environment variables too.

@bmusin from my understanding, setting that environmental variable to nothing is forcing alacritty to run in xwayland. It's intended behavior for it to try to launch in Wayland, but it's not fully working with Wayland due to libs being used

Yeah that is correct. It's a fallback option in case running it as a wayland application is creating any issues.
So if this solved the problem, please close this issue. For keeping track of wayland problems there is #97.

@chrisduerr, solved, I'll close issue.

@bmusin how did you solve it?

@asymmetric, env WAYLAND_DISPLAY= alacritty worked.


desktop offering: error detail API

User Story
this is a follow up to the to errors api: https://github.com/chef/automate/issues/2996
we need an API that, given:

an error message + type
a timeframe ("last 24 hrs", "last 3 days")

returns a list of desktops that

failed their latest chef client run with that error
basic details of each machine should also be returned (for now, let's just stick to the same stuff we already return with the cfgmgmt list nodes api)

Definition of Done
we establish that we have an api that will return the above info, or we create the api if needed. if we already have the api, please document in this issue what the request params and response look like

https://chef.invisionapp.com/share/E9W3TEFXV87#/screens/410946309

@vjeffrey Do we need a timeframe added with the desktop error filtering? I think the timeframe got removed and we only need to filter on the error message and error type. We already have a way to filter on the error message, so I was going to add a way to filter on the error type.

you're right -- no timeframe on this one! thanks for noticing, ill update the description!


Move cloud drive detection out of DrivesManager and improve sidebar population

DrivesManager was pretty complicated and had to deal with enumerating local and cloud drives, and rendering them both in the sidebar. Keeping this all in sync was leading to duplication and performance issues.
This PR introduces CloudDrivesManager which takes over responsibility of identifying cloud providers on a system, and rendering these in a section of the sidebar titled "Cloud Drives".
The original DrivesManager is now a little simpler, and has a rewritten method to add/remove drives in the sidebar.
I have identified that some of the sync and duplication issues appeared to be caused by timing issues likely introduced by various async calls being made from constructors (which obviously are not async methods). To improve this situation, CloudDrivesManager, DrivesManager, and SettingsViewModel have been tweaked to use a factory constructor pattern. Now instead of newing up those objects and having async methods called and forgotten about, a new instance can be obtained by calling await ClassName.CreateInstance(); which allows async methods to be called when these objects are setup.
I have seen some areas; particularly stemming from SettingsViewModel where I feel classes have more responsibility than they need, and have complicated dependencies. For example, SettingsViewModel is responsible for loading all drives, cloud drives, and a lot of other system information - making it more than just settings. By being responsible for loading all drives, it has a hard dependency on DrivesManager, which in one or more methods directly calls methods on views. DrivesManager also depends on DriveItem which also calls the UI to perform updates or run code on the UI thread.
I started going down a deep whole trying to refactor some of this to make changes easier to test with unit tests, but these dependencies make it almost impossible. So I worked my way back out and have done this with the minimal changes. I have some ideas that might help based on what I've done with some Xamarin apps, but I don't know how feasible they will be with a UWP app.
@gave92, please give this a try and see if it stops you duplicated drive issue.

@AndyMDoyle Can you put the cloud section above the drive section?

@AndyMDoyle Can you put the cloud section above the drive section?

@gave92 Once we are changing how this works, handling the drives should probably moved completly out of SettingsViewMode, what do you think?

@gave92 Once we are changing how this works, handling the drives should probably moved completly out of SettingsViewMode, what do you think?

@AndyMDoyle Can you put the cloud section above the drive section?

@yaichenbaum Almost finished testing the SharePoint integration so will send over screenshot of it both ways around so you can get an idea of what it looks like with a few more cloud drives listed.

@AndyMDoyle Can you put the cloud section above the drive section?

@yaichenbaum Almost finished testing the SharePoint integration so will send over screenshot of it both ways around so you can get an idea of what it looks like with a few more cloud drives listed.

@AndyMDoyle That sounds great! The goal is to eventually make the groups collapsible so I wouldn't be too worried about how many items are in each section.

@AndyMDoyle That sounds great! The goal is to eventually make the groups collapsible so I wouldn't be too worried about how many items are in each section.

Wait is it just me or the tab bar disappears with this PR? 😮

Argh, I thought I had dealt with that tab bar issue by having settings available a little earlier.
It's again a timing issue because HorizontalMultitaskingControl relies on theme info from AppSettings. And while debugging to simulate a delay in loading settings, the MainPage view could possibly load before AppSettings (and the theme info) was populated, and if HorizontalMultitaskingControl can't get the settings it needs it doesn't appear properly.
I had a partial fix by moving the generation of AppSettings right to the startup of the app; but this caused issues because AppSettings depends on things that update the UI; and at that stage of the lifecycle the UI wasn't yet ready.
I will do some more on it this evening after work.

Argh, I thought I had dealt with that tab bar issue by having settings available a little earlier.
It's again a timing issue because HorizontalMultitaskingControl relies on theme info from AppSettings. And while debugging to simulate a delay in loading settings, the MainPage view could possibly load before AppSettings (and the theme info) was populated, and if HorizontalMultitaskingControl can't get the settings it needs it doesn't appear properly.
I had a partial fix by moving the generation of AppSettings right to the startup of the app; but this caused issues because AppSettings depends on things that update the UI; and at that stage of the lifecycle the UI wasn't yet ready.
I will do some more on it this evening after work.

@yaichenbaum @gave92, please give this update a try to see if it addresses the tab bar issue on your system.
The population of AppSettings, InteractionViewModel, and SidebarPinnedController are now performed from App.xaml.cs when the OnLaunched and OnActivated events occur, and when the app is resumed from a suspended state. If these objects are already populated the work isn't done again to improve performance.
InteractionViewModel, SidebarPinnedController, and TerminalController have also been refactored slightly to allow async initialization to ensure these sort of dependencies are fully constructed before the application startup gets to the point where they are required.
Other changes in this update...

Cloud Drives have been moved above Drives in thee sidebar
Local drives retain the original order
PR comments addressed

@yaichenbaum @gave92, please give this update a try to see if it addresses the tab bar issue on your system.
The population of AppSettings, InteractionViewModel, and SidebarPinnedController are now performed from App.xaml.cs when the OnLaunched and OnActivated events occur, and when the app is resumed from a suspended state. If these objects are already populated the work isn't done again to improve performance.
InteractionViewModel, SidebarPinnedController, and TerminalController have also been refactored slightly to allow async initialization to ensure these sort of dependencies are fully constructed before the application startup gets to the point where they are required.
Other changes in this update...

Cloud Drives have been moved above Drives in thee sidebar
Local drives retain the original order
PR comments addressed

CodeFactor found an issue: A closing curly bracket must not be preceded by a blank line.
It's currently on:
Files\Filesystem\CloudDrivesManager.cs:191
Commit 11c40efe64690c5cd71eb82b5915dfca81c2233a

CodeFactor found an issue: A closing curly bracket must not be preceded by a blank line.
It's currently on:
Files\Filesystem\CloudDrivesManager.cs:191
Commit 11c40efe64690c5cd71eb82b5915dfca81c2233a

CodeFactor found an issue: A closing curly bracket must not be preceded by a blank line.
It's currently on:
Files\Filesystem\Drives.cs:160
Commit 11c40efe64690c5cd71eb82b5915dfca81c2233a

CodeFactor found an issue: A closing curly bracket must not be preceded by a blank line.
It's currently on:
Files\Filesystem\Drives.cs:160
Commit 11c40efe64690c5cd71eb82b5915dfca81c2233a

CodeFactor found an issue: A closing curly bracket must not be preceded by a blank line.
It's currently on:
Files\Filesystem\CloudDrivesManager.cs:191 Commit 11c40ef

Resolved by removing an unused method earlier.

CodeFactor found an issue: A closing curly bracket must not be preceded by a blank line.
It's currently on:
Files\Filesystem\CloudDrivesManager.cs:191 Commit 11c40ef

Resolved by removing an unused method earlier.

CodeFactor found an issue: A closing curly bracket must not be preceded by a blank line.
It's currently on:
Files\Filesystem\Drives.cs:160 Commit 11c40ef

Fixed

CodeFactor found an issue: A closing curly bracket must not be preceded by a blank line.
It's currently on:
Files\Filesystem\Drives.cs:160 Commit 11c40ef

Fixed

@gave92 @yaichenbaum, is there anything else you need from me for this PR?
Once merged, I have a new PR to raise based on this that has improved startup performance a lot. On my system it's probably less than 2 seconds from clicking the icon to seeing everything in Release mode (debug mode is still around 8 seconds and most of that is down to XAML rendering). I have done this by moving DrivesManager and CloudDrivesManager out of SettingsViewModel which shaved off a little time, but the big improvement came from async instantiating CloudDriveManager and async loading cloud drive providers.

@gave92 @yaichenbaum, is there anything else you need from me for this PR?
Once merged, I have a new PR to raise based on this that has improved startup performance a lot. On my system it's probably less than 2 seconds from clicking the icon to seeing everything in Release mode (debug mode is still around 8 seconds and most of that is down to XAML rendering). I have done this by moving DrivesManager and CloudDrivesManager out of SettingsViewModel which shaved off a little time, but the big improvement came from async instantiating CloudDriveManager and async loading cloud drive providers.

@AndyMDoyle looks good, no duplicates, no white screen, tabs are back.
Opened a small PR with some cleanup, let me know what you think.

@AndyMDoyle looks good, no duplicates, no white screen, tabs are back.
Opened a small PR with some cleanup, let me know what you think.

@gave92, your cleanup PR looks good. I have added one minor fix in addition as I found if the app suspends there was an issue with the drive watcher when resuming.

@gave92, your cleanup PR looks good. I have added one minor fix in addition as I found if the app suspends there was an issue with the drive watcher when resuming.

@AndyMDoyle Thank you for your contribution 🚀

@AndyMDoyle Thank you for your contribution 🚀


Update QUnit hook names: setup/teardown is deprecated for beforeEach/afterEach

QUnit has deprecated setup/teardown in favor of beforeEach/afterEach. So, the documentation recommends beforeEach/afterEach.
Ember.js still refers to setup/teardown in many places. This lead to a lot of confusion for us recently. Can we update all references from setup/teardown to beforeEach/afterEach?
Here are the references I found:

[ ] Ember.js Test Helper Documentation
[ ] ember-cli Documentation
[x] ember-qunit code
[x] In Many ember-cli Test Blueprints

I know it seems like a lot to change for no functional difference, but please keep in mind that:

The terms setup/teardown are confusing. In other test libraries, they only run once per module/context/etc instead of once per test.
QUnit officially deprecated setup/teardown and they will be removed in QUnit 2.0.

ember-qunit itself now supports beforeEach and afterEach (but setup and teardown still work also) as of https://github.com/rwjblue/ember-qunit/pull/125.

As of v0.2.3 we also pass through the first argument to the test callback (as documented in http://qunitjs.com/upgrade-guide-2.x/).

Updated ember-cli blueprints in https://github.com/ember-cli/ember-cli/pull/3197.

:+1:

I took a stab at updating the ember-cli Documentation in ember-cli/ember-cli#3222

this seems no longer relevant, closing due to age


H5p test(only changed Exercise 1.2.2)

(The changes are just made within book1 exercise 1.2.2)
The main changes I made are as follows:

I added a note "tags: jupyterquiz package" in the front of the package import part.
I added a note "tag: jupyterquiz--Exercise 1.2.2" in the front of display_quiz(questions[0]), and hided the jupyterquiz version of Exercise 1.2.2
I added the H5P version of Exercise 1.2.2.

However, I am not sure if the notes are correct/good enough in reaching the goal of organize the files. If it's not correct, can you please explain what will be a good way to add tags/notes?
Also, I am a bit confused about what should I summarize in a .md file. (which is demanded in the instructions from last week) @rlanzafame

OK @tshiya731 I got a chance to look!
The tags are fine, although the tags:  text is unneeded. See the docs/quizzes.md file for my proposed convention. Look ok?
I think that this approach will be fine for helping keep track of things once we reorganize files and chapters. You can keep the *.json file in the original directory for the chapter and keep the commented cells with the jupyterquiz-exercise-... tags in place, which will allow anyone to trace back where they came from, if needed, for when the pages and chapters move around.
Here is an example of how you can see cell tags in VS Code:

Here is the tag in the import statement:

I think you can set this up for the remainder of the exercises in Chapter 01 and let me know when i need to review again, then we can merge it. Then you can do it for all of the exercises.

Hi Robert, I made some changes within the commits:

All the jupyter-quiz in Chapter1 were converted into H5P now.
I added notes and tags for each jupyter-quiz in Chapter1.
I commented the import package part in Chapter1.
I completed the quizzes.md. I mainly added the website link of where H5P exercises are created and stored and added short description. However, I am not sure if it's enough.

@rlanzafame


test: keep cif structs alive during gc

Up until now, test/callback.js assumed that the cb.cif object
would not be garbage collected and was available to Callback::Invoke.
That has never been a valid assumption, but as of
https://github.com/nodejs/node/pull/12141 Buffers created with
new Buffer(n) each have their own ArrayBuffer which gets
garbage-collected much more easily, which in turn would
crash the test suite here.
To (lazy-)fix this, assign cb._cif to some global variable that is
guaranteed to stay alive.

Ping @TooTallNate ? It would be cool to see this merged, or addressed in some other way, otherwise I fear that this module might need to be removed from CITGM coverage…

I'm sorry for not getting to this sooner. I'm not a fan of this (lazy-)fix, so this fell off of my radar. Really this should be fixed in lib/callback.js or something like that. It's possibly fixed by https://github.com/node-ffi/node-ffi/pull/391.


Question: how do you fire (builtin) Event in any IE

The CustomEvent polyfill works like a charm but having real problem with built in events. I simply cannot trigger mouseup or anything really in IE11-
I also have problems triggering "change" on some checkboxes as well. Still IE11 is a mess.
https://github.com/thednp/bootstrap.native/issues/3
Further note console.log(typeof Event); returns different result: Chrome says it's function, IE says it's an object.
Can someone please give me a quick heads up.

I only needed a little help on how to do it, but I figured. For future notice:

var changeEvent;
if ( Event !== undefined && typeof Event === 'function' && typeof Event !== 'object' ) {
	changeEvent = new Event('change');
} else { // define event type, new Event('type') does not work in any IE
	changeEvent = document.createEvent('HTMLEvents'); //UIEvents, MouseEvents, etc
	changeEvent.initEvent('change', true, true);
}


change wire:ignore

allow rich-editor component to be reactive by changing the wire:ignore position.

@atmonshi Is this so you can dynamically change the toolbar buttons, etc?

yes, if I have two RichEditor considering the code:
Forms\Components\Radio::make('type')
    ->reactive()
    ->options([
        'sms' => 'SMS',
        'email' => 'EMAIL',
    ]),

Forms\Components\RichEditor::make('content')->toolbarButtons(['link'])
    ->visible(fn (Closure $get) => $get('type') === 'sms'),

Forms\Components\RichEditor::make('content')->toolbarButtons(['bold'])
    ->visible(fn (Closure $get) => $get('type') === 'email'),

or only one with conditional toolbarButtons
RichEditor::make('content')
                    ->disableAllToolbarButtons()
                    ->toolbarButtons(function (Closure $get) {
                        if ($get('type') === 'sms')
                        {
                            return ['link'];
                        }
                          return ['attachFiles'];

                    })
                    ->reactive(),

this will fix both scenarios.

Thank you


Leaderboard training scenario, list out of range

Good evening,
I am trying to link autoware to the leaderboard training scenario.
I get this error
The scenario could not be loaded:

list index out of range

Traceback (most recent call last):
File "/home/avner/CARLA_AUTOWARE_project/op_carla/op_bridge/leaderboard/leaderboard_evaluator.py", line 332, in _load_and_run_scenario
scenario = RouteScenario(world=self.world, config=config, debug_mode=args.debug)
File "/home/avner/CARLA_AUTOWARE_project/op_carla/op_bridge/leaderboard/scenarios/route_scenario.py", line 189, in init
self._update_route(world, config, debug_mode>0)
File "/home/avner/CARLA_AUTOWARE_project/op_carla/op_bridge/leaderboard/scenarios/route_scenario.py", line 235, in _update_route
self.timeout = self._estimate_route_timeout()
File "/home/avner/CARLA_AUTOWARE_project/op_carla/op_bridge/leaderboard/scenarios/route_scenario.py", line 266, in _estimate_route_timeout
prev_point = self.route[0][0]
IndexError: list index out of range

Registering the route statistics
Exception ignored in: <function RouteScenario.del at 0x7f094178e280>
Traceback (most recent call last):
File "/home/avner/CARLA_AUTOWARE_project/op_carla/op_bridge/leaderboard/scenarios/route_scenario.py", line 567, in del
self.remove_all_actors()
File "/home/avner/CARLA_AUTOWARE_project/op_carla/scenario_runner/srunner/scenarios/basic_scenario.py", line 202, in remove_all_actors
for i, _ in enumerate(self.other_actors):
AttributeError: 'RouteScenario' object has no attribute 'other_actors'

It works properly with the provided scripts. Am I missing something ?
Thank you !

are you trying the ROS2 version with autoware.universe ?

Yes indeed. I using Ubuntu 20 with ros galactic and I have everything set as explained in your videos and repos.
The provided route seems to work, but if I try to link the bridge to the latest leaderboard bridge, it gives me this error.
Also : Is there a way to automatically let autoware run the whole route ? Or do I have to send goals manually ?
Also, with the provided route, as soon as one route ends I get this error and it fails to load the next one.
========= Preparing RouteScenario_2 (repetition 0) =========

Setting up the agent

Could not set up the required agent:

Traceback (most recent call last):
File "/home/avner/CARLA_AUTOWARE_project/op_carla/op_bridge/leaderboard/leaderboard_evaluator.py", line 285, in _load_and_run_scenario
self.agent_instance = getattr(self.module_agent, agent_class_name)(args.agent_config)
File "/home/avner/CARLA_AUTOWARE_project/op_carla/op_bridge/leaderboard/autoagents/autonomous_agent.py", line 45, in init
self.setup(path_to_conf_file)
File "/home/avner/CARLA_AUTOWARE_project/op_carla/op_bridge/op_bridge/op_ros2_agent.py", line 101, in setup
rclpy.init(args=None)
File "/opt/ros/galactic/lib/python3.8/site-packages/rclpy/init.py", line 76, in init
return context.init(args, domain_id=domain_id)
File "/opt/ros/galactic/lib/python3.8/site-packages/rclpy/context.py", line 70, in init
raise RuntimeError
RuntimeError

Registering the route statistics

========= Preparing RouteScenario_3 (repetition 0) =========

Setting up the agent

Could not set up the required agent:

Traceback (most recent call last):
File "/home/avner/CARLA_AUTOWARE_project/op_carla/op_bridge/leaderboard/leaderboard_evaluator.py", line 285, in _load_and_run_scenario
self.agent_instance = getattr(self.module_agent, agent_class_name)(args.agent_config)
File "/home/avner/CARLA_AUTOWARE_project/op_carla/op_bridge/leaderboard/autoagents/autonomous_agent.py", line 45, in init
self.setup(path_to_conf_file)
File "/home/avner/CARLA_AUTOWARE_project/op_carla/op_bridge/op_bridge/op_ros2_agent.py", line 101, in setup
rclpy.init(args=None)
File "/opt/ros/galactic/lib/python3.8/site-packages/rclpy/init.py", line 76, in init
return context.init(args, domain_id=domain_id)
File "/opt/ros/galactic/lib/python3.8/site-packages/rclpy/context.py", line 70, in init
raise RuntimeError
RuntimeError

How to get ROS2 version with autoware.universe run the leaderboard tests? It seems to me that the $route_topic is never used in the 'start_ros2.sh' from the op_agent. The ego vehicle does not move after running run_route_scenarios_ros2.sh. Can you guide me on how to make the leaderboard test run correctly (I'm using ROS galactic and autoware.universe)?


Standardize HTTP mocks

What does this PR do?

Refactor mock targets in tests so that they all point to datadog_checks.base.utils.http.requests.
This is okay because almost no test enables persist_connections, so they indeed rely on the behavior in that case to be calling into requests top-level API, rather than a requests.Session instance.
Limited to our tests, there's no behavioral change in RequestsWrapper at all.
Motivation

Initially, I was thinking this was a required step to prepare for Unix Socket support (or support for any plugin that requires mounting adapters, which can't be done at the top level requests namespace).
But I'm thinking of other options (such as only supporting UDS if persist_connections is turned on), so I converted this PR to a simple, no-impact refactor of our tests.
Additional Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have changelog/ and integration/ labels attached

Well, I'm closing this one off for now since without validation this is likely to drift again, and we don't actually need this just yet. We have refactoring work logged anyway to 1/ add validation for usage of RequestsWrapper, and 2/ address the difference in implementation wrt persist_connections.


Autoware PointGrey driver package README

Status
PRODUCTION / DEVELOPMENT
Description
Solves #1144 adding a README for both nodes in the package.
Related PRs
List related PRs against other branches:
#1105

@drwnz Thanks!


Nominatim v3.2

Docker file with nominatim 3.2. Upgraded Postgres to version 10

This has been tested in production

@dlucia why did you close this PR?

I actually created the PR by mistake, and when realised I closed in order to double check it :)
Opened it now


wandb.init(reinit=True) doesn't work in Windows

The command crashes with the following error:
OSError: [WinError 6] The handle is invalid

Currently the only work around is to not use reinit and instead call your training script in it's own sub process:
import os
for i in range(10):
    os.system("python train.py args")

The underlying cause is the way Windows handles file descriptors and inheritance.  We're currently working on a major refactor that will change the ways in which file descriptors are used.  If you're hitting this issue, please follow this thread and we'll update everyone once this is fixed.

Thanks for making a note on this one Chris

Will this be fixed soon?

import wandb
import logging
logging.basicConfig(filename='log.log')
wandb.init()

This issue seems to make this snippet fail on Windows too

We're working on improvements to the windows experiments in our next generation CLI:  https://github.com/wandb/client-ng  You can try the next generation by running pip install -U --pre wandb.  We're still pushing improvements actively and it's not quit feature parity with the official version.  @noklam let us know if you're still seeing issue with the new cli.


Incorrect import with ESBuild bundling (must use <Editor.default ... />)

Current behaviour
When building with esbuild the default import is not a Component and fails to render (react crashes).
Note: This may be an issue with ESBuild and not with react-simple-code-editor but I am listing here so folks can find the workaround.
Expected behaviour
You can import the default export as Editor and render it like a component as <Editor ... />
Workaround
It seems that ESBuild leaves the actual component buried under one more 'default' export so just render with <Editor.default ... /> to workaround the problem.
Code sample
The demo/example code will show this as long as you are trying to bundle with ESBuild
Your Environment

software
version

react-simple-code-editor
0.13.1

react
18.1

npm
8.11

node
16.15.1

esbuild
0.14.36

what the hell, thanks a lot!


"Found argument ..... isnt valid."

I know this is a newbie question but I'm having an issue with windows power shell command returning "error: Found argument 'example-mapping.yaml' which wasn't expected, or isn't valid in this context" ( I'm using the default mapping with no alteration.) other commands such as help or show-keys work perfectly.
the command I wrote is
./ch57x-keyboard-tool upload example-mapping.yaml
(if i remove the ./ in beggining it returns .... not recognized the name of a cmdlet....)
also im in the same directory as the extracted files location.

Correct command is given in README: https://github.com/kriomant/ch57x-keyboard-tool/blob/master/README.md#windows--powershell
But future versions of tool will accept file name to simplify usage.


added command for work tasks

Made it possible to specify either --state or --kinds previously state was required. Now it will list all the previous jobs in a list, regardless of state

Updated command:

@chrnorm I did make that change, I may have forgotten to update the image on the PR.
The command functionality is as follows
cf deployment diagnostics background-jobs

Returns the list of summaries of all the registered jobs (new api)
cf deployment diagnostics background-jobs --state=x

Returns all background jobs in current state of x
cf deployment diagnostics background-jobs --kind=x

Returns all background jobs of kind x
cf deployment diagnostics background-jobs --kind=x --state=x

Returns all background jobs of kind x in state x


Configure Azure Pipelines

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: enginhorzum sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Project configuration

Currently, there's no way to "edit" a project. A few common tasks will be needed:

Change the project's name
Change the project's icon
Delete the project

This can either be another module at the bottom of the project page... or maybe it should be a modal, accessible by clicking a "gear" icon? TBD.
Also, deleting the project should be in the application menu

Note: Deleting a project is tracked in #90, so this issue can just track changing the project's name/icon

Hi @AWolf81,
Yay, thanks for taking this on!
I have some questions to the feature:

Renaming
What's affected by the rename?
Project folder or just the project name in package.json? Or both?
package.json inside key Guppy - change id & name?
package.json name key changed to same value as Guppy.id?

Hm, yeah. I'm curious what others think. My instinct is that for projects created through Guppy, it should change everything (similar to when the project is created): update guppy.name inside package.json, use slug to get an alphanumeric+dash version of the new name, and set that to guppy.id inside package.json, as well as package.json's name field. Also rename the parent folder.
For projects imported, though, it's murkier to me. In that case, I wonder if we should just change the stuff in package.json's guppy key.
Although, I don't love the idea of a split code path like that. I'd much rather behaviour was consistent.
Maybe we can do all the same stuff for imported projects, but we can prompt with a warning before making the change. Or, maybe we can disable renaming for imported projects?
I think maybe for now, we can just disable renaming for imported projects. If we get a lot of pushback on that from users, we can figure out what the best way to handle it would be?

is renaming locked if any process of project is running (e.g. devserver, install or remove dependency)? Could be a problem with access problems.

Yeah, good point. In #103, we're moving away from having things "locked", and instead having a queue for actions that affect package.json. Renaming doesn't really make sense as part of the queue, though. Gosh, this really shows the brittleness of NPM's dependency systems, right? The fact that all of the settings live in the same manifest as the dependencies, and those settings can't be tweaked while dependencies are installed :/
Once #103 lands, I think there will be a way to derive whether or not the package.json is locked, and we can selectively disable the UI when that's true. But for now, I think we can punt on this issue. Definitely needs to be fixed before this feature launches, but doesn't need to be a part of this PR.

Where to add the gear settings button? Is it in ProjectPage component after the heading pixel shifter OK?

In terms of on-screen location, that looks great!
In terms of component architecture, I think I'd do something like this:
<MainContentWrapper>
  <FlexRow>
    <PixelShifter>
      <Heading>{project.name}</Heading>
    </PixelShifter>
    <SettingsButton />
  </FlexRow>
</MainContentWrapper>

FlexRow would be a styled-component that just sets display: flex; justify-content: space-between. Maybe align-items: center for vertical alignment as well.
I haven't been consistent with whether or not to use Redux for modals, but I think we should use it here. That way, SettingsButton can be redux-connected to pull in the actions to open the modal, and the actual <SettingsModal> can live in App.js by CreateNewProjectWizard. I like the idea of SetingsButton being a batteries-included component we can drop anywhere.

Is a new reducer needed for the renaming and icon change?

I don't think so; the only state is whether or not the modal is open, and I think that can be tracked in modal.reducer.js. We can use React state for the "transient" values (like what's in the input), and dispatch an action to update projects.reducer with the new value (and also update the underlying package.json in a saga).

Should we create a new service for project related processes? E.g. rename folder or modify package.json to the new name. I would call it project-settings.service

I think that makes sense, but it might be a small enough amount of filesystem interaction that it's fine to just do it in the middleware/saga. I have some thoughts on this below.

Is project-name.service required for renaming? Where is it used?

project-name.service is just for generating random names. It's a misleading filename, should be generate-random-name.service or something.

Aside from your questions, I have some additional thoughts:

In #117 and #103 (among others), we're converting all middlewares to use Redux Saga. This was done because Sagas deal much better with complex async flows, they're easier to test, and they make for much more readable code. So there's some coordination with that that'll be required. Maybe create a temporary middleware for now with the understanding that once those PRs land, we can update it to be a saga?

For the gear icon, can we use a softer gray, maybe gray[600] or gray[700]?

I'd love to inject some whimsy in that icon. Maybe on hover it can spin rapidly for a second or so? We could use React Motion to make this feel really organic and nice:

class SettingsButton extends Component {
  state = {
    rotations: 0,
  }

  handleMouseEnter = () => {
    // We can try a bunch of numbers here.
    // 0.5? 1? 2? 5?
    const numOfRotationsOnHover = 1;
    this.setState(state => ({
      rotations: state.rotations + numOfRotationsOnHover,
    }))
  }

  handleMouseLeave = () => {
    // I wonder if we should "unwind" it on mouseout?
    // I'm not sure... maybe try it with/without this?
    this.setState({ rotations: 0 });
  }

  render() {
    return (
      // Omitting most of the structure that isn't relevant
      <Motion style={{ rotations: spring(this.state.rotations) }}>
        {({ rotations }) => (
          <IconBase
            icon={gear}
            style={{transform: `rotate(${rotations * 360})deg`}}
            onMouseEnter={this.handleMouseEnter}
            onMouseLeave={this.handleMouseLeave}
          />
        )}
    );
  }
}

It should also have a different color on hover, maybe blue or purple?

For the form itself, I think there should be a large, centered green button at the bottom that says "Save" (and maybe another that says "cancel"?), rather than having it be next to the project name input. Also, I think the project name input should be "Project name" instead of "Change project name".

In the create-project-wizard, we grab a random subset of the available icons. For this, maybe we should show all of them? Right now we don't have too many, so I think it's feasible. We could sort them alphabetically, which would group similar ones together.

Phew, sorry for writing a short novel here. Let me know if anything is unclear!

@joshwcomeau Thanks, for the invitation to collaborate at the project.
And thanks for the detailed explanation. I'll go through the details and ask if anything is unclear.
It's also OK that it is a short novel, my question was also pretty long.
At first glance I thought that's easy to add but it's a pretty complex topic - but should be doable.
I'll add your details to my todo list later.
Renaming:
Why not handle imported and created projects identically? The guppy key will be added during import to the package.json, right?
Then Guppy is in control and can change the directory of the project and everything in the guppy keys - everything like at a guppy created project.
The imported project is copied to the guppy project folder - so the user will not lose anything as the imported location still exists after importing.
But if we're not sure how to handle we can disable renaming for imported project. The problem is just not clear to me.
Modals
OK, I've read in the code that the modal handling is not consistent and started to do it with a component based modal similar to TaskDetailsModal. But that's OK, I'll change this to Redux based modal as this is probably a better fit. So it's re-usable for many settings that we may need.
to 1. OK, I'll create a temporary middlware for this, that needs to be modified to Sagas later.
to 2. Changing the gear to a softer gray is no problem - can you please give some details how the number thing at the color constants is working? Higher number is a darker color, right? How is this scaled 50 to 900 is the key of the color object?
to 3. I love the idea with the spinning gear icon - I'll check how it will look.
to 5. Ah, OK, I'll try to display all icons and check if this will work.

The imported project is copied to the guppy project folder - so the user will not lose anything as the imported location still exists after importing.

Huh. So this actually isn't true - we don't copy the imported project, we modify the source project. Copying the project hadn't occurred to me at all, but I kinda wish it had, since it would have solved a lot of project-path issues, haha.
Although it might be really confusing to users who don't realize that Guppy creates its own copy, and who then can't tell why the changes they make to the original location aren't reflected in Guppy.
And so yeah, my hesitation to renaming copied projects is that we'd have to modify the original package.json's name (and maybe even its location in the filesystem if we rename the directory). I'm OK with modifying the package.json to add the guppy key since that's not changing anything pre-existing, it's just adding a new thing... this feels more invasive though.

OK, I've read in the code that the modal handling is not consistent and started to do it with a component based modal similar to TaskDetailsModal. But that's OK, I'll change this to Redux based modal as this is probably a better fit. So it's re-usable for many settings that we may need.

Yeah, sorry about that. I think redux is a better fit here because otherwise we'd either need to embed the modal within <SettingsButton>, which feels wrong, or have the modal live in ProjectPage and pass a callback to the button to open/close it, which feels better but also means that the <SettingsButton> is less portable.
We should update TaskDetailsModal to use Redux as well. I'll create an issue for it.

Changing the gear to a softer gray is no problem - can you please give some details how the number thing at the color constants is working? Higher number is a darker color, right? How is this scaled 50 to 900 is the key of the color object?

Higher numbers are darker, indeed. You can see the definition in constants.js. I'm not sure that I understand the latter part of your question. The keys are technically strings (so it should be gray['600'], but we can take advantage of Javascript's coercion to convert the number to a string).  In retrospect it's probably pretty confusing.

Ah OK, sorry, I thought I have seen this but in my current working directory it is not copying the project - maybe that was a mistake in an old branch but I'm not sure.
And you're right a copy can be confusing.
So I think we have three options to deal with imported projects:

Show a confirmation so the user can decide if the project folder should be renamed as well.
Rename folder with-out notification
Disable folder rename for imported projects

I think I would prefer option 1 but option 3 is also OK.
The question to the color constants - I wanted to know why you picked the numbers like this? I would have used something like 100 for 100% brightness and 10 for 10% brightness. Or if there are only two shades something like dark or light as key - but 50 to 600 is OK but a bit confusing.

Hm, yeah, so Option 1 is indeed the best UX IMO, but I'm wondering if the added code complexity is worth it. I suppose it wouldn't be too much extra complexity, since presumably the only place that it matters is in the new middleware/saga (or associated service).
If you're up for Option 1, go for it - you can use the native prompts like we use for the pre-eject warning.

The question to the color constants - I wanted to know why you picked the numbers like this? I would have used something like 100 for 100% brightness and 10 for 10% brightness. Or if there are only two shades something like dark or light as key - but 50 to 600 is OK but a bit confusing.

Ah, right. Yeah I don't have a great rationale; it's mimicking font-weights, where they're 100-900 where larger numbers are heavier. I think I inherited this style from someone else years ago. I added 50 because I needed an off-white.
Given that there are 10 greys, I think a number makes more sense than text, since there's too many. And for other numbers like red, it's not simply a matter of tweaking the brightness (so it might be misleading if you thought that red[50] was just red[100] at 50% brightness/saturation/whatever)

@joshwcomeau OK, thanks for explaining the color numbers. I think this is good to know that is similar to font weight and you're right percentages are probably no good fit.
Update to my current progress:
Gear animation
Please have a look at the screen recording after my todo list (or check in my branch). Added rotation + color change from gray to purple.  The color change is not that visible.
In your component code in your comment there is a typo at tranform rotate - the brace should be after deg. Took my some time to figure it out why it wasn't rotating. Beside this it's working great.
What do you think should we slightly increse the size of the gear on hover & shrink on leave? I think this could be a nice effect.
Spinning is just a small amount as it was too fast for larger values.
Modal
Can you please have a look at my modal code? I've change it a bit so it's working with Redux. I just don't like the dynamically loading of the modal component - it's working but maybe there is a better way to solve this.
I've added the Modal component to app.js. I'm loading the ModalContent based on the state.modal value - here ProjectConfigurationModal.
The component ProjectConfigurationModal is loaded into MODALS object with require. If state.modal is defined the modal will be visible and display the content.

@joshwcomeau I have a problem in project.middleware in my branch (temporary middleware responsible for renaming & icon change)
Do you have an idea what I'm doing wrong?
The project folder is renamed (no check for imported project yet) and the package.json is correctly modified. Then I'd like to refreshProjects inside CHANGE_PROJECT_NAME_FINISHED. But I'm getting an error that name is undefined in ProjectConfigurationModal if I'm dispatching refreshProjects.
I'll check this tomorrow. Seems like the modal is re-rendering. Maybe I have to close the modal first and then refresh the projects and select the updated projectId.

Hey @AWolf81,
Spin animation looks great! I'm into the idea of a slight size increase with scale(). Sorry for the typo in the sample code!
Yeah, so that error makes sense to me; I ran into a similar one with ejecting while the TaskDetailsModal was open. To fix it, I think we'll need to update the selectedProjectId in projects.reducer.js when the project name is changed; that way, there is never a moment where the selected project ID refers to a project that doesn't exist.
So I'd add a case to projects.reducer that listens for CHANGE_PROJECT_NAME_FINISHED and sets the selectedProjectId to the new ID.
I looked through your branch's code and overall I think things are on the right track. Some notes:

I don't love the MODALS object, and the dynamic switching of the various imports. The way it is currently dealt with, App always renders <CreateNewProjectWizard />, and that component internally decides whether to render or not.

I think I prefer this approach, with App not having to decide which modal to render. It's too easy for the top-level App component to have too many concerns to deal with, and so I'd like to keep it as simple as possible. Is there a reason it couldn't work for ProjectConfigurationModal as well?
Another issue with your new approach is that CreateNewProjectWizard has this special foldable-modal that it controls internally, so it shouldn't be nested inside  like this.
I think if we do want to move the rendering outside of the specific components, we could do something like this:
type Props = {
  currentModal: 'new-project' | 'project-settings',
}

class CurrentModal extends Component<Props> {
  render() {
    return (
      <Fragment>
        {currentModal === 'new-project' && <CreateNewProjectWizard />}
        {currentModal === 'project-settings' && <ProjectSettingsModal />}
      </Fragment>
    )
  }
}

...and then in App, we would just render <CurrentModal />.
But yeah, again, I'm not sure we need to do this; I think I'd rather ProjectConfigurationModal just grab whether it's visible from Redux, and pass that data onto Modal:
class ProjectConfigurationModal extends Component {
  render() {
    return (
      <Modal isVisible={this.props.isVisible}>
        // stuff here
      </Modal>
    )
  }
}

const mapStateToProps = state => ({
  isVisible: state.modal === 'project-configuration',
})

(I didn't run any of this code, mostly this is just an idea, not something to be copy-pasted)

I noticed you started using Flow with Redux actions - I think this is a good refactor, but I think I'd rather it be done separately, so that all actions can be converted and it doesn't create so much noise in this PR. Definitely like the approach of having types for the action-creators though!

It looks like there's still a specific action for renaming the project, whereas I think it'd be better if there was a single "Save" button for the whole form. In this case I think the actions would change to just be SAVE_PROJECT_SETTINGS_START and SAVE_PROJECT_SETTINGS_FINISH (and maybe an error one as well).

Some other smaller notes for React bits:

there's a TextInput component you could use instead of <input type="text">
I think we should have a new component for selecting icons that is used in both modals, I'm imaging an API like this:

<ProjectIconSelection
  selectedIcon={?string}
  showRandomSubset={boolean}
  onSelectIcon={function}
/>

(used Flow types instead of actual values, to give an idea what I'm picturing).
The reason for this is that there's actually a fair bit of logic with icons, like having them go gray when none is selected, to the business with importAll.sync. It would be great to DRY that stuff up

Overall I think this is on the right track, though :) lemme know if my proposed fix for the modal issue doesn't work!

Oh, also: could you open a PR for this, even if it's obviously WIP? It was surprisingly hard to look at the changes (for some reason everything I tried to compare it to had a bunch of extraneous commits, both on your repo and mine, so I had to go commit-by-commit. A PR would help me see all the changes together)

@joshwcomeau OK, I've opened a PR.
Yes, you're right with the Modal and I think we only need to add the ProjectConfigurationModal to app.js after the CreateNewProjectWizard - I thought to abstract the modals into a component would help to reuse the modals but I think for two modals it's OK to add them to app.js and handle visibility with state.modal.
To 2. I created a separate issue to have a reminder for this and I'll remove the types from the actions for now.
To 3. That makes sense and I'll modify this in my code. To have just one save action for project name & icon.
ProjectIconSelection component
That's right - this will help to keep things DRY. I like the API, should we add the size of the randomSubSet to 10 or is there no need to pass it with a prop? Or we could also pass it with randomSubSet={?number} instead of a boolean. If randomSubSet is not passed it could render all icons.
Should I create this component at this issue? I think this is a small task and should be no big deal to add.
TextInput component
Oh, sorry, I missed that component. What do you think should I open an issue for a feature request for Storybook? That would help to see all available components in action with some docs for the usage.

Thanks so much for all the work you've been putting in on this. Sorry it's taken me a few days to reply D: I should become more responsive on this project in a week and a half, after React Rally.

should we add the size of the randomSubSet to 10 or is there no need to pass it with a prop? Or we could also pass it with randomSubSet={?number} instead of a boolean.

I'm not super picky :) I think a number works! I'm happy either way

Should I create this component at this issue?

Yeah, I'd group it in. Not substantial enough for its own issue. If you wanted to create a specific PR for it, that could be a good idea (lots of small PRs vs. one large one can be easier for reviewers), but I also recognize the burden of managing multiple PRs, so feel free to lump it in with the larger change.

Oh, sorry, I missed that component. What do you think should I open an issue for a feature request for Storybook? That would help to see all available components in action with some docs for the usage.

Yeah, so I use Storybook often in side projects. I'm not sure why I didn't in this project, I guess I was just in a hurry :/
The only hesitation with Storybook is that adding stories is non-trivial and takes some time. I don't know who would do that work / where the time would come from, as it's not something I can commit to myself.
I know there are other solutions like Styleguidist that I think involve less upfront work?
Either way, I think we should create an issue for this; even if we don't create a full set of stories, it'd be good to add stories for the primitives like TextInput, I might be able to knock a few of them out so that they're more discoverable.

We can close this as it is merged to master. 🎉


Why do schema validation errors not return an error to the client?

If a handler returns an invalid object, it is silently discarded by responseHelper._enforceSchemaOnObject(), with the only warning being a debug message. This causes a great deal of confusion when items silently go missing from responses. Is there a reason that it's set up this way? It makes much more sense to me that this would cause an error, something like:
return callback({
  status: 500,
  code: 'EINVALIDITEM',
  title: 'Item in response does not validate',
  detail: {
    item: item,
    error: err.message
  }
})

I'd submit a pull request, but I wanted to ask first if this should be behind an option in case someone is relying on this behaviour.

I agree that the object shouldn't be discarded silently. Please feel free to submit a PR to fix this and we'll make a new major version release since this is a breaking change.


feat(orchestrate): introduce cw-orchestrate

Add cw-orchestrate to the repo.

Format toml files using taplo.

Signed-off-by: aeryz<EMAIL_ADDRESS>

Can we renamequery_continuation to continue_query as well :)?

done sir


Implement Set method and load from Yaml for InnerNode

What does this PR do?
Start the implementation for Set and loading yaml files.

/merge


Getting pip working

includes as much as possible in pip package
restarts building package
adds text around how to install things not on pypi

not sure what's using ipywidgets, though.

It's streamz. I think it is accidental. I opened a PR over there. https://github.com/python-streamz/streamz/pull/260


Update Readme.md

@DivyanshiSingh00 What changes are you willing to make change in README.md?

@Anishkagupta04 Please assign this issue to me under GSSoC24


Can not override .tab .indicator backgroun-color with angular 6

Hello,
I am trying to change the indicator color of the tabs but I can not do it.
I use this to populate the tabs:

          {{view.name}}

Expected Behavior

When I add this:
.tabs .indicator {
    background-color: blue !important;
  }

It should change the color of the indicator.
Current Behavior
It does not change the color.
Your Environment
Angular 6

Version used: 1.0.0
Browser Name and version: Chrome 70
Operating System and version (desktop or mobile): Ubuntu 16

Do you have a working example? That should definitely work. Maybe there is something wrong with how the css is being compiled?

This should as @acburst has indicated except you need to verify that your CSS configuration is including the change. You do not need to use !important if you have loaded the CSS w/inheritance kept in mind. I suggest this be closed unless you need help today.


entities manager lose contextPath '/_' may be need change '/entities' to '//entities'

i found this code
https://github.com/rapidoid/rapidoid/blob/a4c17f877382b218c67a2c2847880d071b15383e/rapidoid-web/src/main/java/org/rapidoid/goodies/EntitiesHandler.java#L51
https://github.com/rapidoid/rapidoid/blob/a4c17f877382b218c67a2c2847880d071b15383e/rapidoid-web/src/main/java/org/rapidoid/goodies/Goodies.java#L162-L163

Hi, I am not sure if I understand this issue. Did you find a bug or a broken link?

record's link in /entities page was broken.
it shoud be //books/manage
but now was /books/manage

in version5.4.6 when i specify config
admin-zone:   home: /_
the entity record's link broken too.


publish openapi spec to swaggerhub is not working

Describe the bug
The Job fails:
https://github.com/eclipse-tractusx/tractusx-edc/actions/runs/6418661189/job/17426902715

Error: TOKEN_UNKNOWN

As an addiction, the latest version is not set as the default one. It could be done as we did on upstream: https://github.com/eclipse-edc/Connector/pull/3437

Opened an issue on the EF help desk: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3773


Unwanted attribute 'pos' getting added to surveyjson and result when we use objects as IDs in choices.

While using Js Objects as values in Options field, an unwanted attribute "pos" gets added both to SurveyJSON as well as the final data submitted by the user.
Original SJSON:
{
 "pages": [
  {
   "name": "page1",
   "elements": [
    {
     "type": "dropdown",
     "name": "user",
     "title": "Who are you",
     "choices": [
      {
       "value": {
        "id": 1,
        "city": "Nasik"
       },
       "text": "Omkar"
      },
      {
       "value": {
        "id": 2,
        "city": "Porte Rico"
       },
       "text": "Krish"
      }
     ]
    },
    {
     "type": "dropdown",
     "name": "mayer",
     "title": "Who is the mayer of {user.city}",
     "choices": [
      "item1",
      "item2",
      "item3"
     ]
    },
    {
     "type": "comment",
     "name": "famous",
     "title": "What is {user.city} famous for?",
     "rows": 2,
     "placeHolder": "famous food and places."
    }
   ]
  }
 ]
}

after survey renders, (even if we put this in survey builder and click on Test Survey and go back to json)
below unwanted modifications are seen:
{
 "pages": [
  {
   "name": "page1",
   "elements": [
    {
     "type": "dropdown",
     "name": "user",
     "title": "Who are you",
     "choices": [
      {
       "value": {
        "pos": {
         "start": 178,
         "end": 228
        },
        "id": 1,
        "city": "Nasik"
       },
       "text": "Omkar"
      },
      {
       "value": {
        "pos": {
         "start": 287,
         "end": 342
        },
        "id": 2,
        "city": "Porte Rico"
       },
       "text": "Krish"
      }
     ]
    },
    {
     "type": "dropdown",
     "name": "mayer",
     "title": "Who is the mayer of {user.city}",
     "choices": [
      "item1",
      "item2",
      "item3"
     ]
    },
    {
     "type": "comment",
     "name": "famous",
     "title": "What is {user.city} famous for?",
     "rows": 2,
     "placeHolder": "famous food and places."
    }
   ]
  }
 ]
}

They are recursive, if you repeat this, pos attribute keeps on nesting into itself.
here's how final result looks:
{"user":{"pos":{"pos":{"start":195,"end":248},"start":178,"end":299},"id":1,"city":"Nasik"},"mayer":"item2","famous":"sample"}

@omkardusane It is definately a bug. Do you have any steps to reproduce it?
Thank you,
Andrew

yes,
You may use the JSON from below snippet and use the online surveyjs builder to test this.

Paste this json into editor
click on test, try to use the form and enter some sample data
go back to the JSON editor you ill see 'pos' added
repeating steps 2 and 3 will cause recursive 'pos' attributes to the same object.
(note: usually Choices arrayc contains objects that look like {text:"Item1", value:"someId"} but in this case I am using an object as value instead of a primitive type)

{
 "pages": [
  {
   "name": "page1",
   "elements": [
    {
     "type": "dropdown",
     "name": "user",
     "title": "Who are you",
     "choices": [
      {
       "value": {
        "id": 1,
        "city": "Nasik"
       },
       "text": "Omkar"
      },
      {
       "value": {
        "id": 2,
        "city": "Porte Rico"
       },
       "text": "Krish"
      }
     ]
    },
    {
     "type": "dropdown",
     "name": "mayer",
     "title": "Who is the mayer of {user.city}",
     "choices": [
      "item1",
      "item2",
      "item3"
     ]
    },
    {
     "type": "comment",
     "name": "famous",
     "title": "What is {user.city} famous for?",
     "rows": 2,
     "placeHolder": "famous food and places."
    }
   ]
  }
 ]
}

@omkardusane Yes, I have reproduce the issue. I will work on the fix.
Thank you,
Andrew

@andrewtelnov
Thanks for the support!

@omkardusane The unit test has been added and fixed. The bug is gone.
The fix will be available on the next minor update.
Thank you,
Andrew

Great!!
Thanks @andrewtelnov !!

Hi @andrewtelnov ,
After these changes are implemented, there's still one more issue with the Display mode of such surveys having Objects as value in choices.
In Edit mode , the value of the dropdown is displayed, but in the display mode, the value field is printed.
It is expected to be the corresponding text of the value.  I am attaching the screenshots.
these are the questions in panel:
 {
                                    "type": "dropdown",
                                    "name": "activity",
                                    "title": "{panelIndex}. Activity Name",
                                    "isRequired": true,
                                    "choices": [
                                        {
                                            "value": {
                                                "id": "3",
                                                "text": "Renewal",
                                                "enableCust": "yes"
                                            },
                                            "text": "Renewal"
                                        },
                                        {
                                            "value": {
                                                "id": "5",
                                                "text": "Discrepancy",
                                                "enableCust": "yes"
                                            },
                                            "text": "Discrepancy"
                                        },
                                        {
                                            "value": {
                                                "id": "6",
                                                "text": "Team Meeting",
                                                "enableCust": "no"
                                            },
                                            "text": "Team Meeting"
                                        }
                                    ],
                                    "choicesOrder": "asc"
                                },
                                {
                                    "type": "text",
                                    "name": "question1",
                                    "visible": false,
                                    "visibleIf": "{panel.activity.enableCust}=='yes",
                                    "title": "Client Name",
                                    "isRequired": true
                                },
                                {
                                    "type": "text",
                                    "name": "mobile",
                                    "visible": false,
                                    "visibleIf": "{panel.activity.enableCust}=='yes'",
                                    "startWithNewLine": false,
                                    "title": "Mobile No",
                                    "isRequired": true,
                                    "inputType": "number",
                                    "placeHolder": "9876543210"
                                },

Edit Mode

Display Mode

to reproduce, load these questions in edit mode and again in display mode.

@omkardusane Do you mean a display mode?
Yes, it is a separate issue. I will take a look.
Thank you,
Andrew

@andrewtelnov ,
yes in display mode.
SurveyModel.mode = "display"

@omkardusane The unit test has been added and fixed.
The fix will be available on the next minor update.
Thank you,
Andrew

Great !
Thanks @andrewtelnov !


Dash instead Label for one category in Dataset "Greehouse gas emission by sector"

A Label of the hierarchical dimension "Greenhouse gas emission sectors"is not displayed correctly in the "Edit view" (dash instead label, see Printscreen). In the "Published view" the label is displayed correctly.
https://test.visualize.admin.ch/en/v/_T5UYw7b-ZYX
The label is longer than the others. It is maybe the reason.

Open test.visualize.admin.ch with Int as datasource
search for "Emission" + "Include draft Datasets"
select "Greenhouse Gas Emissions by Sector"
start the visualization
Select the "Colors" axis
Select the "Sector" dimension
Select all categories
The label of the first category in the list is not displayed.

The label "International aviation (not included in total)" should be displayed instead of the dash.
test.visualize.admin.ch, v3.7.10 ([65188b5].
Browser : Edge

@tpluscode Seems like we have a minor issue with cube-hierarchy-query that ultimately leads to this : https://github.com/zazuko/cube-hierarchy-query/issues/11

We still have a problem with this dataset

The fixed query does not work?

This has been fixed in #689 , see https://test.visualize.admin.ch/en/browse/dataset/https%3A%2F%2Fenvironment.ld.admin.ch%2Ffoen%2Fubd000501%2F10?previous={"includeDrafts"%3Atrue%2C"order"%3A"SCORE"%2C"search"%3A"greenhouse"}&dataSource=Int


Add pod cidr indication in quickstart doc

The flannel yaml in the example is using <IP_ADDRESS>/16. If user bootstraps
a k8s cluster with different pod cidr, pod traffic will not go thru the flannel
vxlan tunnel.

Pull Request Test Coverage Report for Build 747

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 51.462%

Totals

Change from base Build 737:
0.0%

Covered Lines:
651

Relevant Lines:
1265

💛  - Coveralls

Excellent information to add -- thank you! Just a quick nit to change, thanks for the PR, appreciate it!

Awesome, thanks for the touch ups!


Is your feature request related to a problem? Please describe.
EUWhoiswho_CURIA_EN.pdf
Describe the solution you'd like

Describe alternatives you've considered
GITHUB-20230922-GitHubDataProtectionAgreement (1).pdf
Additional context
No response

please stop creating issues with no content


Team update - Apr 06, 2022

This is a  @Quansight-Labs/czi-a11y-grant team sync 🎉🎉🎉! This is a way for the Team Members to provide status reports on what they've been up to this week and request help and attention for things they are working on. This issue will be closed at the end of the day.
Copy and paste the template below, and answer questions as you wish!

Response Template
**Thanks I'd like to give 🙌**
- So-and-so helped me out a lot with XXX...
- Thanks for Jo's work on the XXX repo...

**Updates from last week :heavy_check_mark:**
- I worked towards deliverable: <link-to-deliverable>
- I had a meeting with ABC

**Challenges I faced and things I'd like assistance with 🙏**
- I had a hard time figuring out ...
- Could somebody take a look at ...

**My availability for next week**
- I'll be off on XXX day...
- I've got several meetings this week...

:mag: Needs Triage:
The Needs Triage issues require an initial assessment and labeling.

Investigate accessibility statements

:dart: Project boards
Please make sure the boards reflect the current status of the project.
Jupyter a11y grant project

Thanks I'd like to give 🙌

Thank you to @tonyfast for reviewing that I didn't break jupyter/accessibility docs!
Thanks to @gabalafou for giving me feedback at this week's JupyterLab accessibility meeting (and giving me ideas on next steps)

Updates from last week :heavy_check_mark:

Meeting notes reviewed and merged. Thanks, Tony!
Roadmap/proposals/funding page PR updated and marked ready for review. This will close #79 when merged.
There is some student contributor activity on jupyter/accessibility #47. Yay!
Workshop blog post and swag survey things. I do need some feedback on the blog post to make sure we're all good to go.

Challenges I faced and things I'd like assistance with 🙏

I think I'm okay right now. I'm glad we're refocusing on next steps this week.

My availability for next week

I will out of office only on April 15.

Thanks I'd like to give 🙌

Thanks @tonyfast and @isabela-pf for bouncing ideas around with me :)

Updates from last week :heavy_check_mark:

I made changes to my JupyterLab PR, Add checkboxes to file browser #12299

Challenges I faced and things I'd like assistance with 🙏

Ditto what Isabela said

My availability for next week

Available all next week

@isabela-pf,

I do need some feedback on the blog post to make sure we're all good to go.

How/where can we give you feedback?

@gabalafou I have it on a google doc since that's easier to bring into Medium!


[Readme] moving defaults to .defaultProps

Its difficult to review because you (or apparently your editor) changed the formatting like quotes and 2/4 spaces

Please re-open this PR after fixing auto-formatting in your editor


remove Utils, clean up Types

This rebases the source branch onto the one for #297, then does some more things.

Removes more things from Marconi.Cardano.Core.Types, e.g. putting some stuff in cardano-api-extended.
Move MarconiTrace to the Logger module.
Removes the Utils module entirely, placing things elsewhere when necessary.
Creates a Marconi.Cardano.ChainIndex.SecurityParam module for utilities reading the SecurityParam from a running node in marconi-cardano-chain-index.

and some other small things.
Noting this targets the branch for #297, and not main, as discussed.
Pre-submit checklist:

Branch

[ ] Tests are provided (if possible)
[ ] Commit sequence broadly makes sense and have useful messages
[ ] Important changes are reflected in changelog.d of the affected packages
[X] Relevant tickets are mentioned in commit messages

PR

[ ] (For external contributions) Corresponding issue exists and is linked in the description
[ ] Targeting main unless this is a cherry-pick backport
[X] Self-reviewed the diff
[X] Useful pull request description
[ ] If relevant, reference the ADR in the PR and reference the PR in the ADR
[X] Reviewer requested

@berewt I requested a review out of habit, but since it targets your branch feel free to merge this at will.


Fix broken gdnative variant test

This test was failing with the following error which seems to come from the core/variant.cpp code trying to free what it thinks is a reference but is actually uninitialized memory. Solution was to initialize the destination Variant before passing it on.
[doctest] doctest version is "2.4.4"
[doctest] run with "--help" for options
===============================================================================
./modules/gdnative/tests/test_variant.h:120:
TEST CASE:  [GDNative Variant] Variant evaluate

./modules/gdnative/tests/test_variant.h:120: FATAL ERROR: test case CRASHED: SIGSEGV - Segmentation violation signal

===============================================================================
[doctest] test cases:  7 |  6 passed | 1 failed | 291 skipped
[doctest] assertions: 11 | 11 passed | 0 failed |
[doctest] Status: FAILURE!
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /lib/x86_64-linux-gnu/libpthread.so.0(+0x153c0) [0x7fa72f15b3c0] (??:0)
[2] Variant::clear() (/home/henry/workspace/godot/./core/variant/variant.h:256)
[3] Variant::reference(Variant const&) (/home/henry/workspace/godot/core/variant/variant.cpp:1042)
[4] Variant::operator=(Variant const&) (/home/henry/workspace/godot/core/variant/variant.cpp:2691)
[5] OperatorEvaluatorAdd<long, long, long>::evaluate(Variant const&, Variant const&, Variant*, bool&) (/home/henry/workspace/godot/core/variant/variant_op.cpp:43 (discriminator 2))
[6] Variant::evaluate(Variant::Operator const&, Variant const&, Variant const&, Variant&, bool&) (/home/henry/workspace/godot/core/variant/variant_op.cpp:1941)
[7] bin/godot.linuxbsd.tools.64(godot_variant_evaluate+0x6b) [0x2aec36b] (/home/henry/workspace/godot/modules/gdnative/gdnative/variant.cpp:586)
[8] bin/godot.linuxbsd.tools.64() [0x1f3fc89] (/home/henry/workspace/godot/./modules/gdnative/tests/test_variant.h:131)
[9] doctest::Context::run() (/home/henry/workspace/godot/./thirdparty/doctest/doctest.h:6292)
[10] test_main(int, char**) (/home/henry/workspace/godot/tests/test_main.cpp:134)
[11] Main::test_entrypoint(int, char**, bool&) (/home/henry/workspace/godot/main/main.cpp:470)
[12] bin/godot.linuxbsd.tools.64(main+0x71) [0x1df7f27] (/home/henry/workspace/godot/platform/linuxbsd/godot_linuxbsd.cpp:45)
[13] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf3) [0x7fa72ee240b3] (??:0)
[14] bin/godot.linuxbsd.tools.64(_start+0x2e) [0x1df7dfe] (??:?)
-- END OF BACKTRACE --

Looks that this fixes some error messages when running tests:
core/variant/variant.cpp:2689:6: runtime error: load of value 4738768, which is not a valid value for type 'Type'
core/variant/variant.cpp:1035:10: runtime error: load of value 4738768, which is not a valid value for type 'Type'
core/variant/variant.h:256:7: runtime error: load of value 4738768, which is not a valid value for type 'Type'
core/variant/variant.h:256:7: runtime error: index 4738768 out of bounds for type 'bool [35]'
core/variant/variant.h:256:7: runtime error: load of value 255, which is not a valid value for type 'bool'
core/variant/variant.cpp:1270:10: runtime error: load of value 4738768, which is not a valid value for type 'Type'

Changes look good, could you squash the two commits into one? See PR workflow.

Fixed, sorry must have skipped that page

Thanks! And congrats for your first merged Godot contribution :tada: