feat/enable github enterprise (v 3.10.8) connection

Is your feature request related to a problem? Please describe.
The GithubRunner works so fine to extract data from Github, but it is not possible to use the same runner to extract data from Enterprise accounts.
Describe the solution you'd like
I would to use the GithubRunner to extract data from a Github Enterprise account. So, to enable this feature, I believe the SimpleGitHubConfig class should have a new parameter to pass the base URL API from the Github Enterprise, as shown in the code below:
from unstructured.ingest.connector.git import GitAccessConfig
from unstructured.ingest.connector.github import SimpleGitHubConfig
from unstructured.ingest.interfaces import PartitionConfig, ProcessorConfig, ReadConfig
from unstructured.ingest.runner import GithubRunner

if __name__ == "__main__":
    runner = GithubRunner(
        processor_config=ProcessorConfig(
            verbose=True,
            output_dir="github-ingest-output",
            num_processes=2,
        ),
        read_config=ReadConfig(),
        partition_config=PartitionConfig(),
        connector_config=SimpleGitHubConfig(
            url="<MyOrg>/<MyInternalRepo>", branch="main", access_config=GitAccessConfig(), base_url=base_url="https://<host_of_my_github_enterprise>/api/v3"
        ),
    )
    runner.run()

Describe alternatives you've considered
Of course, It is necessary that the source code has to be compatible with the Github and Github enterprise API, but I already tested and it should be interesting to remove the line 32 condition
, in order to be possible to allow other github hosts. Because in this way, we are not able to configure Github Enterprise account, which has different domains.
Additional context

The user should be able to pass the domain other than "github.com".

Thanks for creating this issue @DanielBarbosabit :). We're tracking this as an enhancement and will take a look at it more closely as soon as we have bandwidth. In the meantime, if you have an implementation in mind feel free to open a PR and we'd be happy to review!


Switch to eventlet-safe oslo.cache's MemcacheClientPool

Check in with services team as well to see if they are seeing the issues that create the problem. May be a big help.

Actually we're not using token cache at all, this may not be an issue. Curious why we aren't using token cache.

Closing, not something that needs to be sorted out.


(packaging) Ship Puppetfile with bolt gem

With this commit the Puppetfile that defines module versions shipped with bolt system packages is included in the gem artifact. This enables consumers of the gem to be able to install the module versions shipped with the corresponding system package.

Works locally for me :+1:


RabbitMQ source hangs when message cannot be processed and retry configuration is set

Describe the bug
Architecture:
RabbitMQ -> RabbitMQ event source -> HTTP service that returns error
Seems that when retry is configured, then exception occours

If retry values are not configured, then error is written in rabbitmq source log and next messages are processed
Example rabbitmq source
apiVersion: sources.knative.dev/v1alpha1
kind: RabbitmqSource
metadata:
  name: my-event-source
spec:
  broker: "rabbitmq:5672/"
  connectionSecret:
    name: rabbitmq
  user:
    secretKeyRef:
      name: rabbitmq
      key: username
  password:
    secretKeyRef:
      name: rabbitmq
      key: password
  exchangeConfig:
    type: "fanout"
    durable: true
    name: "my"
  queueConfig:
    name: "my"
    durable: true
    autoDelete: false
  channelConfig:
    parallelism: 1
  predeclared: false
  sink:
    ref:
      apiVersion: v1
      kind: Service
      name: service-that-returns-error
  # Retry "forever" => 30 days"
  retry: 2592000
  backoffPolicy: "linear"
  backoffDelay: "1s"

Expected behavior
Message is retried
To Reproduce
In sink section configure to service that returns error. Also configure retry policy (see example above)
Knative release version
1.5.0
Additional context
Also rabbitmq hangs up and source is not restarted, which results in broken rabbitmq eventing, so no messages can be delivered through

Thank you very much for reporting this issue @gunpuz !!
You are correct on the observation I'm finishing a patch to fix this (also there is a mayor source update announced for the source in the next release so really awesome that you report this :D!)!!
We were not using the correct RetryConfig in the SendWithRetries function in the Adapter so whenever a retry was been attempted the backoff function was null.
I'll let you know when the patch is ready 🚀 !

/assign

Thanks for the fast fixes @gabo1208. 👍  Any estimates (when/ in which version) this could be released?

No problem! And yes each fix gets cherry picked on Tuesdays so tomorrow or next Tuesday it will be available on release v1.5 :)


Capturing effected page numbers after comparison

Hello kindly let me know how capture the effected page numbers after comparing 2 documents using VB script

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0e6ed99f-7749-1bee-82ca-a1fcf82ea945
Version Independent ID: b50fa507-858f-4da5-fbe8-335297b15f98
Content: Document.Compare method (Word)
Content Source: api/Word.Document.Compare.md
Product: word
GitHub Login: @o365devx
Microsoft Alias: o365devx

@adithyagithub27 Thanks for your feedback. We use Github issues for documentation bugs, not for developer support. Please try the VBA developer community on Stack Overflow (https://stackoverflow.com/questions/tagged/vba) where you can get help from actual developers. If you find a bug in our documentation, please let us know. Thanks!


How to use URL prefix?

Hello,
we want to deploy DefectDojo using Docker and we want to access DefectDojo under www.domain.com/dojo.
We need to use a NGINX reverse proxy, thats why we need the URL prefix.
Is there a possibility to configure such an URL prefix?
We tried the parameters in dojo/fixtures/system_settings.json as well as settings/settings.dist.py, but we cant get it to work.

better post on slack, better chance to get replies: https://github.com/DefectDojo/django-DefectDojo#getting-involved

better post on slack, better chance to get replies: https://github.com/DefectDojo/django-DefectDojo#getting-involved

Thanks! We managed to get an own subdomain.


Limelight pose estimations

Description
Using AprtilTags, we can use vision to help orient us on the field and help correct odmetry over time (see #69) as error builds up. Configure the limelight to be able to provide pose estimations and pass these to pose estimator that already exists.
For example:
This will add a vision measurement to the existing pose estimator that is built into the CTR swerve code
this.m_odometry.addVisionMeasurement(pose, poseTimestamp);

Project example - https://github.com/LimelightVision/limelight-examples/blob/main/java-wpilib/swerve-megatag-odometry/src/main/java/frc/robot/Drivetrain.java

Added to project but is disabled


Check .logfire for creds to respect 'if-token-present' setting

Fix https://github.com/pydantic/logfire/issues/527

Please can we get this merged and released, I need it for what I'm working on 🙏.

Sure thing, will finish up today!

Still have a few follow up questions to resolve with @alexmojaki, then will push across the line.

1 and 3 are OK, it's good to always check the token now because it may be rejected due to exceeded usage.
The test is failing because it previously only made requests using the user token fake_user_token stored in a toml file. Those requests created the project and a write token fake_token. It now checks fake_token and the tests don't expect that. You just need to tweak the assertion that's in a loop to be more specific.

The test is failing because it previously only made requests using the user token fake_user_token stored in a toml file. Those requests created the project and a write token fake_token. It now checks fake_token and the tests don't expect that. You just need to tweak the assertion that's in a loop to be more specific.

Great, thanks for the feedback! Done!

Thanks for the feedback :). I think I understand our auth patterns better after working in this space a bit more :)


Dockerfile using ruby 2.4.5

*Issue https://github.com/amzn/oss-dashboard/issues/134
Description of changes:
This fixes two problems with the Docker image:
First, the ruby base version was using a jessee image that couldn't install packages anymore:
Fetched 10.2 MB in 10s (969 kB/s)
W: Failed to fetch http://deb.debian.org/debian/dists/jessie-updates/InRelease  Unable to find expected entry 'main/binary-amd64/Packages' in Release file (Wrong sources.list entry or malformed file)

E: Some index files failed to download. They have been ignored, or old ones used instead.
The command '/bin/sh -c apt update && apt install --no-install-recommends -y   build-essential   cmake   file   git   libpq-dev   libxml2-dev   libxslt1-dev   libssl-dev   pkg-config   postgresql   netcat   && apt-get clean   && rm -rf /var/lib/apt/lists/*' returned a non-zero code: 100

The second, when trying to install the gem, the message:
Your Ruby version is 2.2.6, but your Gemfile specified 2.4.5
was shown.

This still doesn't solve the issue https://github.com/amzn/oss-dashboard/issues/134, but it's a part of it
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Thank you Miguel :)


Add TestClient

This PR:

Adds Server class which exposes one or more BoundedContexts via Command- and Query- services running over gRPC.
TestClient testing utility class, which is a simple client for local testing of gRPC communications
Adds ability to add a Repository to a BoundedContextBuilder so that the repository is registered with the BoundedContext produced by the builder.
Removes unnecessary static factory methods for in-memory storages.

@armiol, PTAL.


Remove the need for Node.js polyfills

WalletLink relies on native Node modules, which means that bundlers are responsible to provide polyfills for these modules. This can be problematic for several reasons:

Some bundlers don’t provide polyfills by default (e.g. Webpack 5, Snowpack).
These polyfills can be huge (e.g. with crypto-browserify), and are often not using the native browser APIs like window.crypto.
These polyfills can be implemented in various ways, which impacts WalletLink robustness, stability and security for end users.

If the intent is to maintain a compatibility between Node and browsers, I would suggest to add another entry point for it (e.g. src/index-browser.ts => dist/index-browser.js). It would make it possible to provide different implementations between Node and the browser when needed.
Here is a list of native Node modules used by WalletLink, and suggestions on what could be done to support browser environments.
@petejkim let me know what you think! :slightly_smiling_face:
url
The url module is only used once to parse a URL. This one is easy, as both Node and browser environments provide a globa URL object that can do the same thing without having to import any module:
const url = new URL(this.walletLinkUrl)
this.walletLinkOrigin = `${url.protocol}//${url.host}`

crypto
crypto.randomBytes()
This is used in a few places:
https://github.com/walletlink/walletlink/blob/ffc86286a1692334523783257d1da68f11a0043b/js/src/relay/WalletLinkRelay.ts#L303
https://github.com/walletlink/walletlink/blob/ffc86286a1692334523783257d1da68f11a0043b/js/src/relay/Session.ts#L28-L29
https://github.com/walletlink/walletlink/blob/ffc86286a1692334523783257d1da68f11a0043b/js/src/relay/aes256gcm.ts#L8
As an example, here is a Node-only function that could be used in these cases:
const crypto = require('crypto')

function randomBytesHex(length) {
  return crypto.randomBytes(length).toString("hex")
}

And here is how we could implement a browser equivalent:
function randomBytesHex(length) {
  return uint8ArrayToHex(crypto.getRandomValues(new Uint8Array(length)))
}

// This function is needed because browser’s crypto.getRandomValues()
// return a Uint8Array while Node’s crypto.randomBytes() returns a Stream.
function uint8ArrayToHex(value) {
  return [...value].map(b => b.toString(16).padStart(2, '0')).join('')
}

Another solution could be to use the uuid module. It works in Node and browser environments, and the version 4 (random) UUID would help in cases where a unique ID of any size is needed.
crypto.createCipheriv()
This is used in the aes256gcm.ts module, to encrypt and decrypt:
https://github.com/walletlink/walletlink/blob/ffc86286a1692334523783257d1da68f11a0043b/js/src/relay/aes256gcm.ts#L9-L13
Browsers provide the window.crypto.subtle.encrypt() and window.crypto.subtle.decrypt() methods.
The AES-GCM algorithm is supported: https://developer.mozilla.org/en-US/docs/Web/API/SubtleCrypto/encrypt#AES-GCM
And here is an example on how to use it: https://github.com/mdn/dom-examples/blob/a7e751ff4b82cc19bd3b7451897c254ebe78ebd5/web-crypto/encrypt-decrypt/aes-gcm.js
The two APIs are quite different here, so I think it could be a good idea to provide a browser-only version of aes256gcm.ts, that would be injected from the entry point.
Another solution could be to use a module like @peculiar/webcrypto, which provides a Node polyfill for the WebCrypto API. It has a cost in terms of performances and bundle size, but it would allow to use the same API for both Node and the browser.
keccak
The keccak module already provides a version for browsers:
https://github.com/cryptocoinjs/keccak/blob/e77962484b20fe3c1ca3ddd7e3f455bb118cc545/package.json#L22-L25
The issue is that only the Node version is being used by WalletLink:
https://github.com/walletlink/walletlink/blob/ffc86286a1692334523783257d1da68f11a0043b/js/src/vendor-js/keccak/index.js
I would recommend to either move it as an external dependency (to preserve the package.json fields), or to reproduce this internally by having the browser version in src/vendor-js/keccak and import it from the WalletLink browser entry point.

This is also needed for official angular support with current Angular CLI, node specific dependency are not included /supported for browser, also commonjs modules are also not recommended by Angular.

This is also needed for official angular support with current Angular CLI, node specific dependency are not included /supported for browser, also commonjs modules are also not recommended by Angular.

Thanks for the suggestion, we will look into this

Thanks for the suggestion, we will look into this

+1 for this also for Angular CLI project

We are also running into this issue.
In addition to the obvious problem with the Node dependencies that make this package unusable e.g. with Snowpack, I'd also love to see a bit of a leaner package overall. Right now the dependency chain that comes with this package is quite huge and accumulates to a whopping ~500kb of extra dependencies after bundling.
I'd suggest to also consider dropping some of those and then exporting an ESM entrypoint.
Furthermore it would be nice for the package to not pollute the global namespace with type declarations (https://github.com/walletlink/walletlink/blob/master/js/src/index.ts#L12-L18). Those should be an internal implementation detail and not included in the published types.

It would be nice to not have a hard dependency on RxJs and Preact.

I came here because walletlink's bundle size scares me away from using it.

Ping @hieronymus777 - Any plans on fixing these problems? Our token has recently been listed on Coinbase Pro and we'd love to also enable Coinbase Wallet support via WalletLink on our app but this issue is preventing us from doing so. (see https://github.com/walletlink/walletlink/issues/56#issuecomment-801240970).
We'd need to
a) Get rid of the node dependencies (this is meant to be used in the browser after all)
b) Drastically reduce the bundle size (remove unnecessary bloat)
Not doing these cleanups prevents most of / all of the modern tools out there to work with this including Snowpack, Vite, Esbuild, Swc, etc.
As more and more apps are migrating to those for obvious reasons fixing your dependency tree should be a high priority imho.

FYI, I believe that this wallet provider code has taken a wrong turn somewhere. How can it be that dependency trees for anything Ethereum related are huge when infact they wouldn't have to be. I've built a focused component for Metamask that is just a few bytes - no ethersjs, web3 or any of that jazz...
https://github.com/rugpullindex/web3-sign-msg
I think we should really try to subtract instead of add.

FYI, I believe that this wallet provider in web3 code has generally taken a wrong turn somewhere. How can it be that dependency trees for anything Ethereum related are huge when in fact they don't have to be? I've built a focused component for Metamask that is just a few bytes - no ethersjs, web3 or any of that jazz...

https://github.com/rugpullindex/web3-sign-msg
https://rugpullindex.github.io/web3-sign-msg/

I think we should really try to subtract instead of add.

Absolutely. There's EIP1193 for a reason.

Hi @brendanww. That's a good first step, thanks for working on this! Is my interpretation of your comment correct that you're still planning to also remove the other node dependencies?  Webpack is not really an option for us as well as any application that's built around more modern tools like esbuild, swc, vite, snowpack, etc.

@fubhy that's correct. which build tool are you using?

@fubhy that's correct. which build tool are you using?

Awesome. That's great to hear! We are using Vite (with React).

#54

Is it possible to replace keccak with node-sha3
Currently wallet sdk breaks on pnpm installations because of the keccak module.


Assertion doesn't work with zero nubers

{{host}}/actuator/translationcount

?? status == 200
?? body count isNumber
?? body count >= 0

TestResults
✓: status == 200
✖: count isNumber (AssertionError [ERR_ASSERTION]: count (false) isNumber - /Users/jegors/.vscode/extensions/anweber.vscode-httpyac-6.11.4/dist/extension.js:191:46440)
✖: count >= 0 (AssertionError [ERR_ASSERTION]: count (false) >= - /Users/jegors/.vscode/extensions/anweber.vscode-httpyac-6.11.4/dist/extension.js:191:46440)

seems to be a duplicate of #260


docs: fix broken game entry on docs 🛠

PR Description 📜

This PR is about fixing the broken game entry (table) on documentation.

Fixes #2268

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE

Add your screenshots(Optional) 📸

BEFORE
AFTER

Note The weird look on After screenshot is just because the bug on my screencapture software.

Thank you soo much for contributing to our repository 💗

Thank you @0xabdulkhalid ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Please review this PR @kunjgit, @Arun9739.

Thank you  @0xabdulkhalid , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


linkcheck.yaml file refering a users folder

I notice that in the linkcheck.yaml file, we reference Chris Grote's and Peter Evans id. I assume this is incorrect.
  uses: cmgrote/github-action-link-check@master
#      - name: Create issue from file
#        if: success()
#        uses: peter-evans/create-issue-from-file@v2
#        with:
#          token: ${{ secrets.GITHUB_TOKEN }}
#          title: Broken links
#          content-filepath: ./errors.txt
#          labels: documentation, consumability, tidy up

That is referring to a custom action ie not an official GitHub one. Just a link to a repo. In this case one that Chris built.
One can of course discuss with actions to use or whether we should move to odpi but is quite possible you'll find a variety of actions we need to use that are community contributions
So no error here

That's correct -- I made some changes to the original link checker to better meet our needs, so this is just a custom one that I've written (and hence it refers to that custom one).

I was expecting this to be an Egeria repo containing the custom github actions, i.e. something owned by the community not an individual. Am I missing something here?

As Nigel stated, it's pretty common practice to just refer to whatever actions are out there in the marketplace -- if you'd prefer to create a new repository just for this tiny action within the Egeria workspace, that's fine, but it seems like unnecessary overhead to me...

@planetf1 ok if you are both happy.


Add a deploy ianvs method in quick-start.md

This method can create a separate space to do work by using a docker container

/lgtm


:robot: Triggering CI on branch 'release-next' after synching to upstream/main

cannot obtain Kafka cluster admin, kafka: client has run out of available brokers to talk to: dial tcp: lookup my-cluster-kafka-bootstrap.kafka on <IP_ADDRESS>:53: no such host

Uploading finished
The ImageStreamTag "4-15:operator-registry" is invalid: from: Error resolving ImageStreamTag 4-15:operator-registry in namespace openshift-marketplace: unable to find latest tagged image

/retest-required

OCF Webhook is merging this PR


Backport 2.16: Test SSL with non-deterministic ECDSA

Do run SSL tests when HMAC_DRBG is disabled: this exercises non-deterministic ECDSA.
Partial backport of #4020.

@bensze01 as you reviewed 4020, could you review this small backport as well?

@bensze01 as you reviewed 4020, could you review this small backport as well?


Unable to view feed in HK

Noob here so bear with me. I am unable to view the camera feed in HK. I was able to successfully add all three cameras to HK. I was able to view the feed via VLC but now I am unable. Does ffmpeg need to be installed in a specific location? I downloaded the tar.bz2 file and extracted the contents. Do I need to install anything from it? I’ll include versions when I get back home but everything should be the most current version, I just re-installed homebridge yesterday because my Raspberry Pi died.
Thanks
Forrest

Noob here too,
I had this problem and it worked when I downloaded ffmpeg to a specific location and put the link in the config file.
I just put it in root and added
"videoProcessor": "/ffmpeg",
then everything worked fine

I’m using homebridge config ui this time around so if I need to manually edit my config to do that, I’ll have to edit it. Mind posting that part of your config file?

Keep in mind this may not work for you but it did for me
{
"videoProcessor": "/ffmpeg",
"cameras": [
{
"name": "iPhone 5",
"manufacturer": "Apple",
"model": "iPhone 5",
"firmwareRevision": "10.3.4",
"serialNumber": "C7GKQB6XDTWD",
"videoConfig": {
"source": "-i http://<IP_ADDRESS>/live",
"maxStreams": 2,
"maxWidth": 960,
"maxHeight": 540,
"maxFPS": 20,
"vcodec": "h264",
"audio": false,
"motion": false,
"debug": true
}
}
],
"platform": "Camera-ffmpeg"
},

Mine looks similar to yours for the most part. Are you using an iPhone 5 as a camera? That's interesting.
{
"cameras": [
{
"name": "Doorbell Camera",
"videoConfig": {
"source": "-rtsp_transport tcp -re -i rtsp://user:password:ipaddress:8554/Video-33",
"maxStreams": 2,
"maxFPS": 30,
"audio": true,
"debug": true
}
},
{
"name": "Office Camera",
"videoConfig": {
"source": "-rtsp_transport tcp -re -i rtsp://user:password:ipaddress:8554/Video-34",
"maxStreams": 2,
"maxWidth": 1280,
"maxHeight": 720,
"maxFPS": 30,
"audio": true,
"motion": true
}
},
{
"name": "Living Room Camera",
"videoConfig": {
"source": "-rtsp_transport tcp -re -i rtsp://user:password:ipaddress:8554/Video-35",
"maxStreams": 2,
"maxWidth": 1280,
"maxHeight": 720,
"maxFPS": 30,
"audio": true,
"motion": true
}
}
],
"platform": "Camera-ffmpeg"

Yeah I had some old phones laying around and did some research and got it to work

I might have to look into that, I have quite a few. Haha.

Try to add the line
"videoProcessor": "/ffmpeg",
And specify the path to ffmpeg

Once you extracted the contents of the tar.bz2, did you actually install anything?

Looking at the settings for the plugin on homebridge config ui, that isn't an option. I'll have to manually add that line in. Does it matter where within the config line I place it?

It’s just 1 file named ffmpeg
I placed it in root and opened it in terminal
Then when it said done I specified that path to that file

I have mine in /home/pi/ffmpeg

Then try to specify to that path

That's what I just did, restarted homebridge and still nothing in HK
{
"videoProcessor": "/home/pi/ffmpeg-4.2.2",
"cameras": [

I feel like I needed to do something after downloading and extracting the tar.bz2 file, I never ran an executable or installed anything after extracting.

Have you tried deleting the cameras in HK and add them back?

Twice.

Well then I got nothing more to help you. Sorry

No worries, I appreciate the assistance.

Okay, so I found the issue in the config file. It changed the "@" before the IP address to a ":". I am able to view feeds from my Vivint cameras although it takes awhile to update to video, is this normal? The spinning wheel sits there for a good minute before it shows a live feed or says "Not Responding" before updating video feed.

For me it has never taken longer than 5 seconds to load the live feed


fix(pg): normalize script path

This doesn't fix any particular bug, but it decreases the chance that this type of bug happens in the future. This PR is simply a preventive measure.

Does this need to be rebased onto develop?


Add gem metadata in extended attributes

This upload gem metadata as extended attributes to Chef server.

This change is

:+1: Any ideas when this will be merged?

Looks like to Travis cant pass build without https://github.com/sethvargo/stove/pull/105

Hi @tas50, could you please also publish new version of gem?


Refactor MongoDB queryBuilder

This PR was originally created to fix https://github.com/aerogear/graphback/issues/1963 but I found it difficult to fix with current format without breaking other areas.
Tasks

[x] Fix OR operator not working under most conditions 5dc8136af70ec1e3ceb09204eaae199aee9dc105
[x] Refactor queryBuilder 23c3c0dc3190cc7fe7d58ae316020672e5d929ea
[x] Make the MongoDB integration test port configurable through an environment variable
[x] Manual testing

Hmm, yeah that does not look like it is right.

@machi1990 see https://github.com/aerogear/graphback/issues/1963#issuecomment-687012336
It looks like this remapping won't work for us - since MongoDB only accepts an array for $or. I thought I could remap this but it just leads to incorrect results.
We will have to change the or operator to accept an array, but this will also require changes in Postgres.

I also noticed that unit tests are hanging i.e they all pass but the process does not exit. This results in CI failure after 360 mins. I have the same situation locally.

Which reads, notes having a title in given array or title is either mambo or whatever (if an array is given)

If you execute the same query with PostgreSQL the resulting query will also follow:
notes having a title in given array *or* title is either *mambo* or whatever (if an array is given).
Maybe there needs to be a conversation about the correct approach, indifferent to the data source.
Given the following query with KnexDBDataProvider:
query {
  findNotes(filter: {
    title: {
      eq: "amd"
    },
    or: {
      title: {
        eq:"amd2"
      }
    }
  }) {
    items {
      title
    }
  }
}

The SQL output: select "title" from "note" where "title" = 'amd' or "title" = 'amd2'
To get notes having a title in given array *and* title is either *mambo* or whatever (if an array is given) you could do the following (I am yet to verify this works):
query {
  findNotes(filter: {
    title: {
      eq: "amd"
    },
    and: {
      or: {
        description: {
          eq:"amd2"
        }
      }
    }
  }) {
    items {
      title
    }
  }
}

Which reads, notes having a title in given array or title is either mambo or whatever (if an array is given)

If you execute the same query with PostgreSQL the resulting query will also follow:
notes having a title in given array *or* title is either *mambo* or whatever (if an array is given).
Maybe there needs to be a conversation about the correct approach, indifferent to the data source.

+1 on this, I am happy to keep this conversation off this PR. At least what we've at the moment is consistency for both relational databases and MongoDB.

Given the following query with KnexDBDataProvider:
query {
  findNotes(filter: {
    title: {
      eq: "amd"
    },
    or: {
      title: {
        eq:"amd2"
      }
    }
  }) {
    items {
      title
    }
  }
}

The SQL output: select "title" from "note" where "title" = 'amd' or "title" = 'amd2'
To get notes having a title in given array *and* title is either *mambo* or whatever (if an array is given) you could do the following (I am yet to verify this works):
query {
  findNotes(filter: {
    title: {
      eq: "amd"
    },
    and: {
      or: {
        description: {
          eq:"amd2"
        }
      }
    }
  }) {
    items {
      title
    }
  }
}

Yes, this works.

Tests are passing now.

Happy to discuss about the or semantics in an issue dedicated for that.

Great! I will be creating an issue for that soon.


CORS errors on checkout.zksync.io

Hi, I'm trying to check out a gitcoin grants donation via zksync, but I'm getting Network error.
It looks like the reason is CORS errors showing up in my terminal:

Access to XMLHttpRequest at 'https://api.zksync.io/jsrpc' from origin 'https://checkout.zksync.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

Same error here... I am trying to donate a gitcon but it's impossible.
(index):1 Access to XMLHttpRequest at 'https://api.zksync.io/jsrpc' from origin 'https://checkout.zksync.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

That's weird....
I usually work with Charles Web Debugging Proxy... I had it closed, but after opening it to try to inspect the error, it worked flawlessly. Not sure what is causing the issue.

We are aware of the issue and working on the fix. Will try to resolve the issue ASAP.

It should be fixed now.

I just had the same issue on checkout.zksync.io. Trying to fund a Gitcoin grant and getting an identical error. I'm on a Mac and using the latest Chrome (Chrome 92.0.4515.131)

Access to XMLHttpRequest at 'https://api.zksync.io/jsrpc' from origin 'https://checkout.zksync.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

@StanislavBreadless please look into it.

I just had the same issue on checkout.zksync.io. Trying to fund a Gitcoin grant and getting an identical error. I'm on a Mac and using the latest Chrome (Chrome 92.0.4515.131).

Access to XMLHttpRequest at 'https://api.zksync.io/jsrpc' from origin 'https://checkout.zksync.io' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.

Hi! Thank you for letting us know. Does the issue persist?

@StanislavBreadless nope, I just tried again and this time it worked correctly.


Update moment-timezone and sanitize-html

Signed-off-by: Kevin Cormier<EMAIL_ADDRESS>https://github.com/stolostron/backlog/issues/25473
https://github.com/stolostron/backlog/issues/25523

/cc @RobDolares


  In iOS web, if I change views and remove the iframe, I will get errors caused by rogue IFrameMessageSender messages I believe stemming from devicemotion.
My current workaround is to add if(iframeWindow) to line 334 of vrview.js

Apologies, I found the removeAllListeners() method now


Add _version.py to .gitignore

Apparently the developer install instructions generate these files in all the new rail* repos, e.g. rail_cmnn has the following in src/rail/cmnn/_version.py :
# file generated by setuptools_scm
# don't change, don't track in version control
__version__ = version = '0.1.2.dev2+ga64902b'
__version_tuple__ = version_tuple = (0, 1, 2, 'dev2', 'ga64902b')

Some other weird files are generated as well, but this is the only one git complains about, so it would be nice to exempt it from tracking entirely if possible.

Whoops, I was looking in a repo that didn't use the template!


Error with Flutter 3.0

I have just upgraded to flutter 3.0 and I am getting this error from this package. Any ideas how to solve this?

same issue

Same

Checkout https://pub.dev/packages/telephony/versions/0.2.0

Thanks @shounakmulay and @Jacques66


Conflicting keybindings for IPython/Jupyter

Default hotkey to (e.g.) delete a frame in IPython Notebook is esc-d (escape to access the menu, d for the command). For Notebooks opened in Atom with the web-browser package, the esc acts as an Atom cancel command rather than accessing the Notebook menu, and thus it's impossible for Notebook hotkeys to work.
Thanks in advance!
Atom Version: 0.186.0
System: Mac OS X 10.10.2
Thrown From: web-browser package, v1.4.0

This web-browser package is no longer supported.  Use the atom package browser-plus instead.


Simple (SPEC-like) scans are more customizable

In current master, the subscriptions attached to the simple scans are hard-coded. Customizing them is tricky because they inspect the scan to automatically do things like use motor attribute as the x axis in LivePlot.
This introduces two new user-modifiable attributes: .subs, which works the same way as usual, and .sub_factories, which expects a function that accepts a scan instance and returns a callback. It's the job of the function to inspect the scan and pass the right arguments to, for example, LivePlot. A collection of these "sub factories" is included in the PR. See for example plot_first_motor.
I don't imagine that users will be writing very many "sub factories," but they are crucial to providing the magical scan inspection in a way that lets users add and remove other subs (like peak stats) at will.

P.S. Tests pass. This is ready once it survives review.

bike shedding the name, _BoundScan might be better?

:+1: for sub-factories (I've been doing the same in a less-than-ideal way...)


Support multiple formats for test reporting

@stephenmichaelf please review this.
This address the issue where the reporting will be visible both in Console as well as Junit reporting xml

@nigurr What is the state of this?


Assigning SID or executing "caf" before taxi breaks game

If a newly-spawned departure is assigned a SID (either with the sid command or via the caf command) while it is at status apron (has not taxi'd, has not been assigned a runway), the game is unusable and spams the console with these logs:
RouteModel.js:46 Invalid data type passed to RouteModel.

This is with the current version running on https://atc-release.herokuapp.com (not sure which, but log says [ INFO ] Version v3.0.0, though this is not broken at http://zlsa.github.io/atc/, which also logs [ INFO ] Version v3.0.0).

Interesting. I tried it out at https://atc-release.herokuapp.com and it works for me. No problems when taxi after caf on apron - no messages in the console, either.

@panther2 @szabodabo do you guys see the same thing on https://atc-dev.herokuapp.com?  This is the env for my fork's develop branch.  so this is the cutting edge and also not fully tested, so keep that in mind.
I'll dig in on my end, too, and see what I can find.

ok, I ran a local server with n8rzz/atc@ac05e5d6b69, which is the latest commit in your develop branch, and I could reproduce it... maybe this issue should be moved over to https://github.com/n8rzz/atc?
do you have a pointer to the development process for the project? why does your development clone have its own issue tracker? where do contributors usually send pull requests?

It's fine to leave the issue here. As for the second part, yrs it is confusing. ;) That will be changing some time soon here.

@szabodabo you're working too hard 😉, the heroku link is the most recent commit to develop.
My fork started as a complete refactor of the JS code when we converted from ES5 to ES2016 and added tooling (https://github.com/zlsa/atc/pull/702).  Since then, it has assumed the role of javascript improvements.  The issues we have there are mostly for continuous development, but there are also some bugs that are being worked on as part of our release cycle.
you can take a look at the tooling readme.  We don't have any other ramp up docs, yet.

@n8rzz thanks for the info. seems like community contributions in zlsa/atc might get annoying when you want to merge n8rzz/atc back in at release time?
I was playing on https://atc-release.herokuapp.com because I was running into #747 or a similar bug (fixed in your develop branch, apparently).

that will be changing some time soon here.

@erikquinn which part?

@szabodabo not at all.  That's why we do it this way.  We can work on the JS unencumbered by new airports and merge in a finial set of changes.  New airports/aircraft/airlines work pretty much independently of the JS.  so contributors can make changes without having to know anything about the js.

@szabodabo I just mean the separate stacks of issues will eventually be all in one place.

@szabodabo try it on this one https://atc-dev-pr-179.herokuapp.com/
This branch contains code for the new CommandParser but, as part of that feature work, I re-worked the method I believe to be causing your issue.  I, however, have not been able to reproduce the problems you were seeing.

RE merges and such: we do a PR process for all the code in my fork just like we do here in the main repo.  Mine has a few more bells and whistles, (like CI that runs test on every branch and heroku release apps we can spin up for PRs) but the process is the same.  We continue to add new features to develop and address bugs on release/x.x.x.  eventually, a week or so before release is planned to merge into this fork, I open a PR and post links for everybody so they can test it out and uncover bugs we missed.  Once we are satisfied all the major bugs are squashed, my current release branch gets merged into the gh-pages branch here.  Then we repeat the process.
Basically new JS in my fork, everything else here.

@szabodabo Are you still seeing this problem on the current version at https://zlsa.github.io/atc? The linked PR above has made its way into the production version of the sim.
If it cannot be reproduced, I'd like to close this and we can re-investigate if it ever does resurface, but I would agree with @n8rzz that the changes to the CommandParser would very, very likely have resolved whatever was causing the problem.

Assuming this to be resolved.
Closing.


json_encode: invalid utf-8 sequence in argument (in $_GET/$_POST keys)

Similar issue to the $_GET/$_POST values, but now it's on the keys.  Can be seen with common vulnerability scanners.  Example:
http://{yourdomainname.com}/{somepath}?acux8277%C0%BEz1%C0%BCz2a%90bcxuca8277
With:
display_errors Off (this is the only condition that causes the json_encode warning to happen)
Pull request coming shortly

This has been completed and released.


Simplify task status update

Simplifies the task update routine to be async. for updates, removing
the need for the update map.
closes #57

Tested in #58 [closed issue at first sight] and #59 [open at first sight, later closed]


Added brazilian banks and improvements in pt_BR docs

Added brazilian banks, using febraban list (brazilian banks federation). Improvements in pt_BR functions documentation, to show all available options and expected results..

Please rebase on master to get a clean commit log

Not sure what I have to do here, it's a single commit already. Could you give me a hint?


Update README.md

Add a line break so the WinRM Setup header renders correctly

Hi @dsschnau, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

Looks like this task has moved now

Closing since this doesn't exist in the same location anymore and it looks like it renders correctly.


Create project tracker on github

Organize tasks on github

https://github.com/users/AprilAlfonso-volunteer/projects/1/views/1


Clojars version support

Based on the work already done by @erwan in this PR #388
I've added the new endpoint to Clojars, with a simpler versioning:
https://github.com/ato/clojars-web/pull/315
This change parses the version data, that looks something like:
https://clojars.org/overtone/overtone/latest-version.json
or
https://clojars.org/overtone/latest-version.json
What do you think? Thanks

Thanks for your contribution! I believe the code couldn't work as is.

@espadrine first time I've ever dealt with node, so was really happy that something did work, rather than looking at the details, as I should have. Thanks for pointing out the issues. I believe that I've addressed them now. What do you think?

@dotemacs It definitely works a lot better now ☺

@espadrine thank you for your time and for accepting the change :)

@espadrine sorry to bother you, do you know when this will be deployed? Thanks :)

Heh, I usually give myself 24h to make sure I didn't let a mistake through.

@espadrine cool, no rush, I just wanted to know. Thanks :)


feat(update_campaign_executor): handle update campaign updates

depends on #305 obviously

Pull Request Test Coverage Report for Build 451b40f0436703addea426c4373abe0c13d02cc0-PR-325

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+83.3%) to 83.275%

Totals

Change from base Build<PHONE_NUMBER>:
83.3%

Covered Lines:
1429

Relevant Lines:
1716

💛  - Coveralls

Closing since this will need to be reimplemented using Ash


Upgrade chrome driver to 87.0.4280.88

I am using jdk 11 image and I am getting below exception
org.openqa.selenium.NoSuchSessionException: invalid session id

Build info: version: '3.141.59', revision: 'e82be7d358', time: '2018-11-14T08:17:03'
System info: host: 'jenkins-automation-5-m47q4-pqtg0-15swp', ip: '<IP_ADDRESS>', os.name: 'Linux', os.arch: 'amd64', os.version: '4.14.203-156.332.amzn2.x86_64', java.version: '<IP_ADDRESS>'
Driver info: org.openqa.selenium.chrome.ChromeDriver
Capabilities {acceptInsecureCerts: false, browserName: chrome, browserVersion: 87.0.4280.66, chrome: {chromedriverVersion: 87.0.4280.88 (89e2380a3e36c..., userDataDir: /tmp/.com.google.Chrome.T3rZOJ}, goog:chromeOptions: {debuggerAddress: localhost:39721}, javascriptEnabled: true, networkConnectionEnabled: false, pageLoadStrategy: normal, platform: LINUX, platformName: LINUX, proxy: Proxy(), setWindowRect: true, strictFileInteractability: false, timeouts: {implicit: 0, pageLoad: 300000, script: 30000}, unhandledPromptBehavior: dismiss and notify, webauthn:virtualAuthenticators: true}
Session ID: 100c7b77bf9a219bac634144c79d4bc2

Hi, I'm not clear whether than exception is due to an older version of ChromeDriver as it works fine for me locally. I've upgraded Chrome & ChromeDriver to the latest versions though - let me know if that fixes your problem.

HI Mark ,
Thanks for taking this.  I have proceeded ahead by setting this below line of code:
options.addArguments("--disable-dev-shm-usage");
This resolved my issue.  I will test again .for now I will close this issue.

Hi @shubgene, glad you've resolved your issue - sounds possibly related to the problem mentioned in the README.


modify vulkan queue family index find logic in queue creation

queue family index is different in different gpu, current logic assum graphics = 0, compute = 1, transfer = 2

done in https://github.com/v4vendeta/horizon/commit/e888b95c2d211d96d9fddfb1d4892abea899bf27


Storages: refine SegmentReadTaskScheduler

What problem does this PR solve?
Issue Number: ref #6834
Problem Summary:
What is changed and how it works?

The main updates of this PR is removing the code of CircularScanList and refining SegmentReadTaskScheduler. Removing CircularScanList is because it's not very necessary.

The design of CircularScanList is to make each iteration of read_pools start from the previous end position. Meanwhile, for the convenience of accessing by pool_id, also added an unordered_map to index all pools.

CircularScanList also will release pools that are never used, causing inconvenience in some monitoring statistics.

This PR deletes the code of CircularScanList, and just uses an unordered_map to store read_pools.

When scheduling, try scheduling each pool in the read_pools before releasing lock.

The biggest difference is that the new code will try to schedule all pools in read_pools before the scheduler releasing its lock.

Also add some unit-tests of SegmentReadTaskScheduler.

Add CPU usage of threads:

Check List
Tests

[x] Unit test
[ ] Integration test
[x] Manual test (add detailed scripts or steps below)

Run chbenchmark workload with concurrent queries.

[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/hold

/run-all-tests

/unhold


Solution to Problem 4

This solution is taken from https://github.com/vaibhavpandey11

My solution for problem 4 is here: r1cc4rdo/daily_coding_problem/solution_04.py
Anything wrong with it?
Also, note that your solution here is not constant space as required.
See this stackoverflow post

I am really sorry.
Actually, I am a student of B.Tech 1st year and I have been taught Python
in my college. I found many problems of dailycodingproblem and started
solving them for practice. And I thought how can I get "Stars" on my
repository. So I started to pull requests.
I am new to these repositories and I don't know much about Github.
And I admit that I don't know much about time and space complexity as well.
Really sorry, if I disturbed you.
Pardon me.
On Fri, May 15, 2020, 23:11 r1cc4rdo<EMAIL_ADDRESS>wrote:

My solution for problem 4 is here:
r1cc4rdo/daily_coding_problem/solution_04.py
https://github.com/r1cc4rdo/daily_coding_problem/blob/master/problems/04/solution_04.py
Anything wrong with it?
Also, note that your solution here is not constant space as required.
See this stackoverflow post
https://stackoverflow.com/questions/48759175/what-is-the-space-complexity-of-the-python-sort/48759241
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/r1cc4rdo/daily_coding_problem/pull/10#issuecomment-629390873,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOTRTLFKRAAZKA4GPNRSD23RRV5ENANCNFSM4NBWPHGA
.

Hey, no problem man :)
I'm afraid the only recipe for getting stars is to put out content good enough for others to like.
Not that I necessarily think amassing internet points is a worthwhile goal though ;)
Pull requests (PRs) are for contributing to a project. Typically, you fork a project, solve some outstanding problem or improve something, and ask the original owner to include your changes in the original repository (hence, Pull Request).
Closing this one now. Take care!

Thanks for your kind advice. I will definitely follow this in future.
Thank you.
On Sat, May 16, 2020, 00:12 r1cc4rdo<EMAIL_ADDRESS>wrote:

Hey, no problem man :)
I'm afraid the only recipe for getting stars is to put out content good
enough for others to like.
Not that I necessarily think amassing internet points is a worthwhile goal
though ;)
Pull requests (PRs) are for contributing to a project. Typically, you fork
a project, solve some outstanding problem or improve something, and ask the
original owner to include your changes in the original repository (hence,
Pull Request).
Closing this one now. Take care!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/r1cc4rdo/daily_coding_problem/pull/10#issuecomment-629417571,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOTRTLAXKYTPEVZPCJMVRFTRRWEI5ANCNFSM4NBWPHGA
.


MesonBuilder

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

300 of 364 (82.42%)  changed or added relevant lines in 9 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-2.7%) to 95.526%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkgs/native_toolchain_c/lib/src/meson_builder/meson_builder.dart
52
60
86.67%

pkgs/native_toolchain_c/lib/src/native_toolchain/gcc.dart
0
12
0.0%

pkgs/native_toolchain_c/lib/src/meson_builder/run_meson_builder.dart
164
181
90.61%

pkgs/native_toolchain_c/lib/src/cbuilder/compiler_resolver.dart
41
68
60.29%

Totals

Change from base Build<PHONE_NUMBER>:
-2.7%

Covered Lines:
2071

Relevant Lines:
2168

💛  - Coveralls


make up .env file syntax

make script writes in the .env file "-e 'name=value' ..." when docker expects just "name=value" without the preceding -e (used when starting container from cli without a env file).

Cannot reproduce. -e is an argument of the echo command and is not written to the output.
If you experience otherwise, please provide details about your system / OS.

Could reproduce it on another OS and removed it


sbt compiles forever

steps
Extract the attached file into a HibTool2 directory
HibToolError.tar.gz
. Run sbt compile.
problem
Compile does not end nor does it show any error messages.
expectation
Compile should show OK or error messages after a while.
notes
Error happens in file ConfigUtil.scala in line:
val conf = read[HibToolConfFile](appConf.toString())

If you comment that line out then the compilation goes to end.

minimize example

https://github.com/xuwei-k/sbt-2489
https://travis-ci.org/xuwei-k/sbt-2489/builds/112818829

I think this is not sbt bug. upickle bug? /cc @lihaoyi

quite plausibly, we've had https://github.com/lihaoyi/upickle-pprint/issues/107 and I'm not sure what version you're using but maybe you're using a version before that fix or maybe there's another related problem we haven't fixed

@jk-1's build says:
    "com.lihaoyi" %% "upickle" % "0.3.7" withJavadoc(),

Minimized repro created by @xuwei-k says
libraryDependencies += "com.lihaoyi" %% "upickle" % "0.3.8"

Ok well open a uPickle issue and I'll get to it some day

I'm going to close this for now then.


Fix matrix string

fixes SGMatrix string

NOOOOOOOOOOOO
@gf712
Merge branch 'develop' into develop

and
Merge branch 'develop' of https://github.com/gf712/shogun into develop

ppffff

que?

@karlnapf just merged junk into develop (see those 8 commits...)

no i didnt, check the log


Refactor worker support

If we want to make it easier to add more worker implementations, I wanted to share our existing worker code (particularly for thrift support for workers).
This just does the refactoring. It also removes the guava dependency which was really minor (but Worker still uses it, I think, so pretty weak win).
@ianoc ?

LGTM

@softprops what do you think of the latest?

Much better :) lgtm


Console errors navigating away from harvester cluster explorer view

Setup

Rancher version: v2.7.2-rc6 -> harvester-ui https://releases.rancher.com/harvester-ui/plugin/harvester-latest/harvester-latest.umd.min.list.js
Browser type & version: Chrome

Describe the bug
Navigating away from a harvester cluster explorer view throws several console.error
To Reproduce

Go to a harvester cluster explorer view (check screenshot)
From a harvester cluster explorer view, navigate to Elemental extension (check screenshot)
OR
From a harvester cluster explorer view, navigate to the Settings page (check screenshot)

Result

Errors are logged on the console. Harvester seems to struggle with the context switching which my unintended side-effect on the dashboard state

Expected Result

have no console errors

Screenshots

@mantis-toboggan-md FYI. Maybe this needs to be transfered to the harvester repo/team. 🙏

Hi,  @n313893254   Can you look at this problem when you have time ？  thanks

Verified on Rancher master and Harvester master. These two console errors have been fixed.

Closing as fixed. @n313893254 let us know if this needs to reopened for QA or any other reason.


Index page

show speech list.
the list data:

speaker
title
introduce
PPT Or Blog link(pick one of tow)
tags
Prerequisite knowledge

Word harder!


Migrate MessageChannelPair to ES6 class

Migrate the //common/js/src/messaging/message-channel-pair.js file from legacy Closure Compiler classes to ES6 classes.
This is a pure refactoring change. It's is part of the effort to modernize the code base, as recent Closure Compiler versions stopped supporting the legacy class syntax.


Make gem compatible with Mongoid 5.0

I needed this gem to work in my setup with Mongoid 5.0 and it seems as if just changing the .gemspec to support everything up from version 4.0 (including 5.0) works fine.
I can imagine that you don't want to release this as-is, but I just wanted to share that this gem is actually compatible with Mongoid 5.0.

looks good

Thanks @vindia ;)
Actually I know this gem needs a lot of work done, and I don't have much time for this right now, I don't use it in my current projects either :/
So feel free to contribute in any way you want ;)

Thanks! To be honest, I doubt if I'm going to use it much longer as I might move away from using MongoDB. So don't expect too much input from me either.
Anyway, this fixes my short-term issue of migrating to Mongoid 5.0 so I'm happy for now.


[WIP] Implement .wasm Parser

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@23d92ed). Click here to learn what that means.
The diff coverage is 74.7%.

@@            Coverage Diff            @@
##             master       #8   +/-   ##
=========================================
  Coverage          ?   50.68%
=========================================
  Files             ?        7
  Lines             ?      874
  Branches          ?        0
=========================================
  Hits              ?      443
  Misses            ?      431
  Partials          ?        0

Impacted Files
Coverage Δ

Sources/Swasm/Validation.swift
0% <ø> (ø)

Sources/Swasm/Types.swift
23.07% <ø> (ø)

Sources/Swasm/WASM/WASMParser.swift
54.39% <54.39%> (ø)

Sources/Swasm/Parser.swift
66.66% <66.66%> (ø)

Sources/Swasm/Stream.swift
84.61% <84.61%> (ø)

Tests/SwasmTests/ParserTests.swift
86.29% <86.29%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d92ed...e7d79a4. Read the comment docs.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@17fe8f2). Click here to learn what that means.
The diff coverage is 50.24%.

@@            Coverage Diff            @@
##             master       #8   +/-   ##
=========================================
  Coverage          ?   50.24%
=========================================
  Files             ?        7
  Lines             ?     1206
  Branches          ?        0
=========================================
  Hits              ?      606
  Misses            ?      600
  Partials          ?        0

Impacted Files
Coverage Δ

Sources/Swasm/Runtime.swift
100% <100%> (ø)

Sources/Swasm/Types.swift
40% <40%> (ø)

Sources/Swasm/Instruction.swift
42.34% <42.34%> (ø)

Sources/Swasm/Parser/WASMParser.swift
49.41% <49.41%> (ø)

Sources/Swasm/Parser/Parser.swift
67.74% <67.74%> (ø)

Sources/Swasm/Module.swift
73.58% <73.58%> (ø)

Sources/Swasm/Parser/Stream.swift
84.61% <84.61%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17fe8f2...f127549. Read the comment docs.


Show new lines in configmaps keys

Hi.
I think would be great if we have new line properly as new lines and easier to edit smth like:

Hi, @botzill I would like to take up this as my first contribution. Can you please give me some insights on how and from where should I start?

Thx @rajaSahil . I'll assign it to you. This code is in client/src/views/editorModal.tsx. We're currently using yamljs from to convert the JSON we get from the k8s api into YAML. With a little luck, there's a feature in that package to make this work out-of-the-box. If not, we may need to do a little find-and-replace on the YAML string we get back (though I am slightly worried there might be some unexpected edge cases w/ that approach).

@herbrandson Currently we are using yamljs to parse json into YAML. And the parsed YAML looks like this.
kind: ConfigMap
apiVersion: v1
metadata:
  name: coredns
  namespace: kube-system
  selfLink: /api/v1/namespaces/kube-system/configmaps/coredns
  uid: ccd9e858-ac0b-432e-9e3b-c9f22d08e5de
  resourceVersion: '200'
  creationTimestamp: '2020-10-03T06:30:52Z'
  managedFields:
    -
      manager: kubeadm
      operation: Update
      apiVersion: v1
      time: '2020-10-03T06:30:52Z'
      fieldsType: FieldsV1
      fieldsV1:
        'f:data':
          .: {}
          'f:Corefile': {}
data:
  Corefile: ".:53 {\n    errors\n    health {\n       lameduck 5s\n    }\n    ready\n    kubernetes cluster.local in-addr.arpa ip6.arpa {\n       pods insecure\n       fallthrough in-addr.arpa ip6.arpa\n       ttl 30\n    }\n    prometheus :9153\n    forward . /etc/resolv.conf {\n       max_concurrent 1000\n    }\n    cache 30\n    loop\n    reload\n    loadbalance\n}\n"

But if we use yaml package to parse yaml  then parsed YAML will be:
kind: ConfigMap
apiVersion: v1
metadata:
  name: coredns
  namespace: kube-system
  selfLink: /api/v1/namespaces/kube-system/configmaps/coredns
  uid: ccd9e858-ac0b-432e-9e3b-c9f22d08e5de
  resourceVersion: "200"
  creationTimestamp: "2020-10-03T06:30:52Z"
  managedFields:
    - manager: kubeadm
      operation: Update
      apiVersion: v1
      time: "2020-10-03T06:30:52Z"
      fieldsType: FieldsV1
      fieldsV1:
        f:data:
          ".": {}
          f:Corefile: {}
data:
  Corefile: |
    .:53 {
        errors
        health {
           lameduck 5s
        }
        ready
        kubernetes cluster.local in-addr.arpa ip6.arpa {
           pods insecure
           fallthrough in-addr.arpa ip6.arpa
           ttl 30
        }
        prometheus :9153
        forward . /etc/resolv.conf {
           max_concurrent 1000
        }
        cache 30
        loop
        reload
        loadbalance
    }

So should I change the yamljs package to yaml package?

Here is the link of yaml package: yaml package

@herbrandson Please review.
https://github.com/indeedeng/k8dash/pull/149

@rajaSahil Looks great. I requested one really small change in the PR. We should be good to merge after that. Thx for the awesome work!


Achievement diaries not displaying correctly

the achievement diaries are not showing up in my meets reqs which is correct because i dont. but there is a few diaries that i do meet the reqs for and they arent showing anywhere.

Hey @Whal93 could you let me know which diaries you have reqs for which aren't showing?

hey! for me right now, i have the reqs for kandarin med, karamja med and western provinces med.
kandarin med has now appeared but the other 2 are still missing.
if i click to show every quest and diary even without the reqs for. most of the diaries are missing.
falador, fremmy, kandarin and karamja are the only diaries showing. which are all correct, the ones i dont have the reqs for are there. every other diary is missing from the full list.
thanks!

Same problem

I have several diaries that could show up when set to "Show All" but it just seems to pick one arbitrarily to show.

Yes this is still an issue. Doesn't show certain diaries at all even on the
show all
On Tuesday, 14 September 2021, Beau Witter @.***> wrote:

Same problem
[image: image]
https://user-images.githubusercontent.com/26094186/133168905-5574c5ac-3c70-4032-aba5-987be6e2c0f6.png
I have several diaries that could show up when set to "Show All" but it
just seems to pick one arbitrarily to show.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Zoinkwiz/quest-helper/issues/410#issuecomment-918652659,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUCABEGUZGNRVOQL6MEYES3UB2AU3ANCNFSM5BAWRCIA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Those have been diaries that didn't exist at the time on the helper, thus they didn't appear.


Allow passphrases to be supplied as char arrays

and to be zeroed after use; for #19

Updated the Subkey class to:

Add new passphraseChars property, allowing a subkey's passphrase
to be set and cached as a char[] instead of as a String object.
Add new unlock() method, allowing the subkey to be unlocked
without caching the passphrase at all.
Cache the private-key material (in the form of a PGPPrivateKey
object) after the subkey has been unlocked.
Add new clearSecrets() method, allowing the cached private-key
material to be released for garbage collection, and zeroing-out the
cached char[] passphrase.

Updated the Key class to:

Add new passphraseChars setter as a convenience for setting subkey
char[] passphrases.
Add new constructors that accept char[] passphrases; one each
corresponding to the old String passphrase constructors.
Add new clearSecrets() method as a convenience for clearing subkey
secrets.

Updated the Ring class to:

Add new clearSecrets() method as a convenience for clearing subkey
secrets.

Updated the Encryptor class to:

Add new symmetricPassphraseChars property, allowing the passphrase
for symmetric encryption to be set and cached as a char[] instead
of as a String object.
Add new clearSecrets() method as a convenience for clearing subkey
secrets, and zeroing-out the cached char[] symmetric passphrase.

Updated the Decryptor class to:

Add new symmetricPassphraseChars property, allowing the passphrase
for symmetric encryption to be set and cached as a char[] instead
of as a String object.
Add new clearSecrets() method as a convenience for clearing subkey
secrets, and zeroing-out the cached char[] symmetric passphrase.

Looks good to me! The only question is whether the char[] passphrase should be copied or set as is. As I see, currently it's set as is, which means that upon clearing we will clear the original array as well. That might be a bit unexpected if the user still needs this array for some reason in some other place... On the other hand, it's documented in the JavaDocs, so it should be an expected behavior. I'm a bit unsure what behavior would be better in this case...

Thanks for the feedback -- that's a good point about whether to copy the char[] or not -- I can definitely see an argument either way. I'm thinking it's probably better to err on the side of clearing too much rather than too little, though, and make users explicitly create a copy of the char[] themselves if they want to keep the passphrase around for use later.
I'll go ahead and merge this in and build a new release with it (call it 0.5) in a couple of days.


alice-bob-agent.sh : POST ".../oobi/Alice" gets "405 Method Not Allowed"

Same thing for
curl -s -X POST "http://localhost:5723/oobi/Bob" ...

thus the following two return empty lists:
echo "Alice's Contacts:"
curl -s -X GET "http://localhost:5623/contacts" -H "accept: */*" | jq
echo "Bob's Contacts:"
curl -s -X GET "http://localhost:5723/contacts" -H "accept: */*" | jq

I imagine the script is out-of-date.  What needs to be updated for this to work?

The OOBI endpoint no longer needs an alias.  I was fixing some other scripts in PR #286 so pushed this fix as well.  This issue will close when that is merged.


Update requirements.txt

After creating your pull request, tick these boxes if they are applicable to you.

[V ] I have tested my changes against the review branch (the latest developmental version), and this pull request is targeting that branch as a base
[V ] I have tested my changes on Python 3.5.3 or higher (3.7)

Description
I updated requirements.txt to the newest versions of the deps.
Related issues (if applicable)
everything with the deny-new error

BTW: this is also meant to merge into Review :)

Pull requests should target Review in the pull request, commenting that they are meant to be merged is not proper PR format, nor is that how PR's work.

oh, sorry 'bout that, I will make one to target review

#2103 Already does this.


5.2 basic auth no prompt

Laravel Version: 5.2.41
PHP Version: 5.6.11
Database Driver & Version: mysql

Description:
Trying to use basic authentication - update my route as per below however I do not get any prompt just the 'Invalid credentials' message...
// ROOT ROUTE
Route::get('/', array(
'uses' => 'MyController@index',
'as' => 'index',
'middleware' => 'auth.basic'
));
Please help/advise - thanks!!!!

5.2 is out of support. Is the same issue happening on 5.3?

Have not tried - I will shortly...

Worked through the 5.2 to 5.3 upgrade guide...finished the upgrade unfortunately still not getting the prompt. hhrrrmmm...sort of stuck here - not sure what to do next...not seeing anything useful in logs...
:cat .htaccess

Options -MultiViews

RewriteEngine On

# Redirect Trailing Slashes If Not A Folder...
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule ^(.*)/$ /$1 [L,R=301]

# Handle Front Controller...
RewriteCond %{REQUEST_FILENAME} !-d
RewriteCond %{REQUEST_FILENAME} !-f
RewriteRule ^ index.php [L]

# Handle Authorization Header

RewriteCond %{HTTP:Authorization} .
RewriteRule .* - [E=HTTP_AUTHORIZATION:%{HTTP:Authorization}]
RewriteCond %{HTTP:Authorization} ^(.+)$
RewriteRule .* - [E=HTTP_AUTHORIZATION:%{HTTP:Authorization}]

#AuthUserFile /var/www/portaExtensionManager/.htpasswd
#AuthType Basic
#AuthName "Extension Manager"
#Require valid-user

@hung0 it seems to be working normally in 5.3 on Valet and nginx, not sure about apache though as Id on't have experience with it. I think that's not a bug in the framework but rather some apache configuration needs alteration, no?


[MOB-9021] - WKWebView protocol update

🔹 Jira Ticket(s)

MOB-9021

✏ Description

Please provide a brief description of what this pull request does.

Closing this PR as it makes more sense to delete the protocol extension method as internally its not being used


Add Kaohsiung Senior High School

School site:
https://www.kshs.kh.edu.tw/
School email:
<EMAIL_ADDRESS>School address:
No. 50, Jianguo 3rd Rd., Sanmin Dist., Kaohsiung City 807302 , Taiwan (R.O.C.)

@Hsuan855 First stage of verification passed, official domain for 高雄市立高雄高級中學 is student.kshs.kh.edu.tw as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@Hsuan855 Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Importing SVGs

We won't be able to support every feature of the SVG spec, but working on supporting this will help us move towards adding more features that SVG provides that we've forgotten about so far. Before we transition to the node system, we can probably reach a happy middleground of supporting most common SVG features. Overly complex SVGs might not end up looking the same once imported, but we can't strive for perfection quite yet.

We may be able to use an existing test suite such as https://www.w3.org/Graphics/SVG/WG/wiki/Test_Suite_Overview#SVG_1.1_Second_Edition_Test_Suite:_16_August_2011 or other to test the flow of Import SVG into Graphite -> export back to SVG. Even just a bunch of SVG files using a variety of SVG capabilities would be helpful as a test suite. Then as tests fail, we know what features are missing and we can add support for those as user-facing capabilities in the editor.

Hi, I tried Import SVG at https://editor.graphite.rs/ and it does work :)
How can one select objects in the imported SVG afterwards? I can only select the entire SVG object.
Thanks!

Hi, thanks for trying the editor! I've clarified the title of this issue. You can indeed import an SVG as an image file and it is treated no differently than a JPG or PNG. But we unfortunately have no support yet for parsing the SVG file and generating Graphite-specific layer data. That is what this issue is about.


[bug] Windows EV certificate custom signing command not picking up %1 properly

Describe the bug
I'm trying to EV sign a Windows build. All of this runs on a self hosted windows 11 github runner. My EV certificate provider is SSL.com and they provide a tool called CodeSignTool. It can be found here. You'll notice there is a Windows and a Linux/Mac version. I'm using the linux version, since I'm using Gitbash within Windows.
My tauri.conf.json windows section looks like this:
    "windows": {
      "nsis": {
        "template": "./bundle/windows/installer.nsi",
        "installMode": "perMachine",
        "installerIcon": "icons/nsis_icon.ico",
        "headerImage": "icons/nsis_header.bmp",
        "sidebarImage": "icons/nsis_sidebar.bmp"
      },
      "signCommand": {
        "cmd": "./CodeSignTool.sh sign",
        "args": [
          "-username ***",
          "-password ***",
          "-credential_id ***",
          "-totp_secret ***",
          "-input_file_path %1"
        ]
      }
    },

What ends up happening is:
Compiling build-info-build v0.0.39
Compiling APP_NAME v1.0.1-dev (C:\actions-runner\_work\PATHING\src-tauri)
Compiling tauri-plugin-single-instance v2.0.1
    Finished `release` profile [optimized] target(s) in 3m 58s
    Built [tauri_cli::build] application at: C:\actions-runner\_work\PATHING\src-tauri\target\release\APP_NAME.exe
    Signing [tauri_bundler::bundle::windows::sign] C:\actions-runner\_work\PATHING\src-tauri\target\release\APP_NAME.exe
    Signing [tauri_bundler::bundle::windows::sign] C:\actions-runner\_work\PATHING\src-tauri\target\release\APP_NAME.exe with a custom signing command
    Running [tauri_bundler::bundle::common] Command `./CodeSignTool.sh sign  -username *** -credential_id *** -totp_secret *** -input_file_path %1`
failed to bundle project: `The system cannot find the file specified. (os error 2)`
    Error [tauri_cli_node] failed to bundle project: `The system cannot find the file specified. (os error 2)`
Error: Process completed with exit code 1.

I've made sure the script is available from the path I'm working in.
The issue is this %1 that does not get parsed and replaced with the path of the exe
Reproduction
No response
Expected behavior
The build should sign the binaries that require signing.
Full tauri info output
><EMAIL_ADDRESS>tauri
> tauri info
[✔] Environment
    - OS: Windows 10.0.22631 x86_64 (X64)
    ✔ WebView2: 130.0.2849.80
    ✔ MSVC:
        - Visual Studio Build Tools 2022
        - Visual Studio Professional 2022
    ✔ rustc: 1.82.0 (f6e511eec 2024-10-15)
    ✔ cargo: 1.82.0 (8f40fc59f 2024-08-21)
    ✔ rustup: 1.27.1 (54dd3d00f 2024-04-24)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (default)
    - node: 20.12.2
    - npm: 10.5.0
[-] Packages
    - tauri 🦀: 2.1.1
    - tauri-build 🦀: 2.0.3
    - wry 🦀: 0.47.0
    - tao 🦀: 0.30.8
    - @tauri-apps/api : 2.1.1
    - @tauri-apps/cli : 2.1.0
[-] Plugins
    - tauri-plugin-single-instance 🦀: 2.0.1
    - @tauri-apps/plugin-single-instance : not installed!
    - tauri-plugin-notification 🦀: 2.0.1
    - @tauri-apps/plugin-notification : 2.0.0
    - tauri-plugin-os 🦀: 2.0.1
    - @tauri-apps/plugin-os : 2.0.0
    - tauri-plugin-shell 🦀: 2.0.2
    - @tauri-apps/plugin-shell : 2.0.1
    - tauri-plugin-dialog 🦀: 2.0.3
    - @tauri-apps/plugin-dialog : 2.0.1
    - tauri-plugin-fs 🦀: 2.0.3
    - @tauri-apps/plugin-fs : not installed!
    - tauri-plugin-window-state 🦀: 2.0.2
    - @tauri-apps/plugin-window-state : 2.0.0
    - tauri-plugin-process 🦀: 2.0.1
    - @tauri-apps/plugin-process : 2.0.0
    - tauri-plugin-updater 🦀: 2.0.2
    - @tauri-apps/plugin-updater : 2.0.0
[-] App
    - build-type: bundle
    - CSP: unset
    - frontendDist: ../dist
    - devUrl: http://localhost:1420/
    - framework: React
    - bundler: Vite

Stack trace
No response
Additional context
No response

the %1 replacement only works if the arg is exactly "%1" (maybe to not replace it in urls by accident maybe?). Does it still work if you cut that arg into 2? (pretty sure i saw exactly this usecase working before somewhere so i hope it does)

i think you have to change cmd to gitbash, not just the .sh file. The signCommand is not executed in the context of the terminal you run tauri build in.

So i'm tying to adapt, but I have trouble finding the CodeSignTool..
    "windows": {
      "nsis": {
        "template": "./bundle/windows/installer.nsi",
        "installMode": "perMachine",
        "installerIcon": "icons/nsis_icon.ico",
        "headerImage": "icons/nsis_header.bmp",
        "sidebarImage": "icons/nsis_sidebar.bmp"
      },
      "signCommand": {
        "cmd": "bash",
        "args": [
          "/c/actions-runner/_work/PATH/src-tauri/CodeSignTool.sh sign",
          "-username ***",
          "-password ***",
          "-credential_id ***",
          "-totp_secret ***",
          "-input_file_path",
          "%1"
        ]
      }
    },

    Compiling tauri-plugin-single-instance v2.0.1
    Finished `release` profile [optimized] target(s) in 3m 34s
    Built [tauri_cli::build] application at: C:\actions-runner\_work\PATH\src-tauri\target\release\APP_NAME.exe
    Signing [tauri_bundler::bundle::windows::sign] C:\actions-runner\_work\PATH\src-tauri\target\release\APP_NAME.exe
    Signing [tauri_bundler::bundle::windows::sign] C:\actions-runner\_work\PATH\src-tauri\target\release\APP_NAME.exe with a custom signing command
    Running [tauri_bundler::bundle::common] Command `bash  /c/actions-runner/_work/PATH/src-tauri/CodeSignTool.sh sign -username *** -credential_id 70580cf8-d1a6-4372-a46d-3decb0c583c6 -totp_secret *** -input_file_path C:\actions-runner\_work\PATH\src-tauri\target\release\APP_NAME.exe`
bash: /c/actions-runner/_work/PATH/src-tauri/CodeSignTool.sh sign: No such file or directory
failed to bundle project: `failed to run bash`
    Error [tauri_cli_node] failed to bundle project: `failed to run bash`
Error: Process completed with exit code 1.

This context aspect is escaping my graps for now.

I did split CodeSignTool.sh and sign, that did help ! But the status now is even weirder. It seems like it's signing, but we don't get Code signed successfully logged. I have no clue why.
  Finished `release` profile [optimized] target(s) in 3m 33s
   Built [tauri_cli::build] application at: C:\actions-runner\_work\PATH\src-tauri\target\release\APP_NAME.exe
   Signing [tauri_bundler::bundle::windows::sign] C:\actions-runner\_work\PATH\src-tauri\target\release\APP_NAME.exe
   Signing [tauri_bundler::bundle::windows::sign] C:\actions-runner\_work\PATH\src-tauri\target\release\APP_NAME.exe with a custom signing command
   Running [tauri_bundler::bundle::common] Command `bash  -c /c/actions-runner/_work/PATH/src-tauri/CodeSignTool.sh sign -username *** -credential_id 70580cf8-d1a6-4372-a46d-3decb0c583c6 -totp_secret *** -input_file_path  C:\actions-runner\_work\PATH\src-tauri\target\release\APP_NAME.exe`
   Info [tauri_bundler::bundle::windows::sign] ""
   Info [tauri_bundler::bundle::windows::nsis] Target: x64
   Debug [handlebars::render] Rendering value: Path(Relative(([Named("compression")], "compression")))
[... edited more Path stuff]
   Debug [handlebars::render] Rendering value: Path(Relative(([Named("estimated_size")], "estimated_size")))
   Debug [handlebars::render] Rendering helper: "each", params: [PathAndJson { relative_path: Some("languages"), value: Context(Array [String("English")], ["languages"]) }], hash: {}
   Debug [handlebars::render] Rendering value: Path(Relative(([], "this")))
   Debug [handlebars::render] Rendering helper: "each", params: [PathAndJson { relative_path: Some("language_files"), value: Context(Array [String("C:\\actions-runner\\_work\\PATH\\src-tauri\\target\\release\\nsis\\x64\\English.nsh")], ["language_files"]) }], hash: {}
   Debug [handlebars::render] Rendering value: Path(Relative(([], "this")))
   Debug [handlebars::render] Rendering helper: "each", params: [PathAndJson { relative_path: Some("resources_dirs"), value: Context(Array [], ["resources_dirs"]) }], hash: {}
   Debug [handlebars::render] Rendering helper: "each", params: [PathAndJson { relative_path: Some("resources"), value: Context(Object {}, ["resources"]) }], hash: {}
   Debug [handlebars::render] Rendering helper: "each", params: [PathAndJson { relative_path: Some("binaries"), value: Context(Object {}, ["binaries"]) }], hash: {}
   Debug [handlebars::render] Rendering helper: "each", params: [PathAndJson { relative_path: Some("resources"), value: Context(Object {}, ["resources"]) }], hash: {}
   Debug [handlebars::render] Rendering helper: "each", params: [PathAndJson { relative_path: Some("binaries"), value: Context(Object {}, ["binaries"]) }], hash: {}
   Debug [handlebars::render] Rendering helper: "each", params: [PathAndJson { relative_path: Some("resources_ancestors"), value: Context(Array [], ["resources_ancestors"]) }], hash: {}
   Running [tauri_bundler::bundle::windows::nsis] makensis.exe to produce C:\actions-runner\_work\PATH\src-tauri\target\release\bundle\nsis\APP_NAME_1.0.1-dev_x64-setup.exe
   Running [tauri_bundler::bundle::common] Command `C:\Users\user\AppData\Local\tauri\NSIS\makensis.exe  -INPUTCHARSET UTF8 -OUTPUTCHARSET UTF8 -V3 C:\actions-runner\_work\PATH\src-tauri\target\release\nsis\x64\installer.nsi`
MakeNSIS v3.08 - Copyright 1999-2021 Contributors
See the file COPYING for license details.
Credits can be found in the Users Manual.

Processing config: C:\Users\user\AppData\Local\tauri\NSIS\nsisconf.nsh
Processing script file: "C:\actions-runner\_work\PATH\src-tauri\target\release\nsis\x64\installer.nsi" (UTF8)

Processed 1 file, writing output (x86-unicode):

Output: "C:\actions-runner\_work\PATH\src-tauri\target\release\nsis\x64\nsis-output.exe"
Install: 6 pages (384 bytes), 3 sections (6216 bytes), 1330 instructions (37240 bytes), 356 strings (13572 bytes), 1 language table (414 bytes).
Uninstall: 2 pages (192 bytes), 1 section (2072 bytes), 383 instructions (10724 bytes), 177 strings (6648 bytes), 1 language table (274 bytes).
Datablock optimizer saved 154546 bytes (~0.2%).

Using lzma (compress whole) compression.

EXE header size:               66560 / 38912 bytes
Install code:                          (58290 bytes)
Install data:                          (64016622 bytes)
Uninstall code+data:                   (91171 bytes)
Compressed data:            19238574 / 64166083 bytes
CRC (0x5EA9EDD7):                  4 / 4 bytes

Total size:                 19305138 / 64204999 bytes (30.0%)
   Signing [tauri_bundler::bundle::windows::sign] C:\actions-runner\_work\PATH\src-tauri\target\release\bundle\nsis\APP_NAME_1.0.1-dev_x64-setup.exe
   Signing [tauri_bundler::bundle::windows::sign] C:\actions-runner\_work\PATH\src-tauri\target\release\bundle\nsis\APP_NAME_1.0.1-dev_x64-setup.exe with a custom signing command
   Running [tauri_bundler::bundle::common] Command `bash  -c /c/actions-runner/_work/PATH/src-tauri/CodeSignTool.sh sign -username *** -credential_id 70580cf8-d1a6-4372-a46d-3decb0c583c6 -totp_secret *** -input_file_path  C:\actions-runner\_work\PATH\src-tauri\target\release\bundle/nsis/APP_NAME_1.0.1-dev_x64-setup.exe`
   Info [tauri_bundler::bundle::windows::sign] ""
   Finished [tauri_bundler::bundle] 1 bundle at:
       C:\actions-runner\_work\PATH\src-tauri\target\release\bundle\nsis\APP_NAME_1.0.1-dev_x64-setup.exe

As for the bat vs sh, I started with sh since I'm running with shell: bash I did not want to change my step. Plus both these scripts do the same thing:
user@hello MINGW64 ~/tmp
$ cat CodeSignTool.bat
@echo OFF

set code_sign_tool_path=%CODE_SIGN_TOOL_PATH%

if defined code_sign_tool_path (
%code_sign_tool_path%\jdk-11.0.2\bin\java -jar %code_sign_tool_path%\jar\code_sign_tool-1.3.2.jar %*
) else (
.\jdk-11.0.2\bin\java -jar .\jar\code_sign_tool-1.3.2.jar %*
)
user@hello MINGW64 ~/tmp
$ cat CodeSignTool.sh
if [[ -z "${CODE_SIGN_TOOL_PATH}" ]]; then
 java -jar ./jar/code_sign_tool-1.3.2.jar $@
else
 java -jar ${CODE_SIGN_TOOL_PATH}/jar/code_sign_tool-1.3.2.jar $@
fi

Progress has been made, I've switched things around but now, my issue is that my PATH contains \n (because of the name of project). And it's parsed a line return..... I've tried to escape it without success.
Log are not "anon" this time, otherwise it makes no sense.
    Compiling nym-vpn-app v1.0.1-dev (C:\actions-runner\_work\nym-vpn-client\nym-vpn-client\nym-vpn-app\src-tauri)
    Finished `release` profile [optimized] target(s) in 4m 04s
    Built [tauri_cli::build] application at: C:\actions-runner\_work\nym-vpn-client\nym-vpn-client\nym-vpn-app\src-tauri\target\release\NymVPN.exe
    Signing [tauri_bundler::bundle::windows::sign] C:\actions-runner\_work\nym-vpn-client\nym-vpn-client\nym-vpn-app\src-tauri\target\release\NymVPN.exe
    Signing [tauri_bundler::bundle::windows::sign] C:\actions-runner\_work\nym-vpn-client\nym-vpn-client\nym-vpn-app\src-tauri\target\release\NymVPN.exe with a custom signing command
    Running [tauri_bundler::bundle::common] Command `powershell  Start-Process C:\actions-runner\_work
ym-vpn-client
ym-vpn-client
ym-vpn-app\src-tauri\CodeSignTool.bat sign -username *** -credential_id 70580cf8-d1a6-4372-a46d-3decb0c583c6 -totp_secret *** -input_file_path C:\actions-runner\_work\nym-vpn-client\nym-vpn-client\nym-vpn-app\src-tauri\target\release\NymVPN.exe -override`
Start-Process : This command cannot be run due to the error: Server execution failed.
At line:1 char:1
+ Start-Process C:\actions-runner\_work
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidOperation: (:) [Start-Process], InvalidOperationException
    + FullyQualifiedErrorId : InvalidOperationException,Microsoft.PowerShell.Commands.StartProcessCommand
ym-vpn-client : The term 'ym-vpn-client' is not recognized as the name of a cmdlet, function, script file, or operable
program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:2 char:1
+ ym-vpn-client
+ ~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (ym-vpn-client:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
ym-vpn-client : The term 'ym-vpn-client' is not recognized as the name of a cmdlet, function, script file, or operable
program. Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:3 char:1
+ ym-vpn-client
+ ~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (ym-vpn-client:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException
ym-vpn-app\src-tauri\CodeSignTool.bat : The module 'ym-vpn-app' could not be loaded. For more information, run
'Import-Module ym-vpn-app'.
At line:4 char:1
+ ym-vpn-app\src-tauri\CodeSignTool.bat sign -username SOMETHING
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (ym-vpn-app\src-tauri\CodeSignTool.bat:String) [], CommandNotFoundExcept
   ion
    + FullyQualifiedErrorId : CouldNotAutoLoadModule
failed to bundle project: `failed to run powershell`
    Error [tauri_cli_node] failed to bundle project: `failed to run powershell`
Error: Process completed with exit code 1.

Signing command:

     "windows": {
      "nsis": {
        "template": "./bundle/windows/installer.nsi",
        "installMode": "perMachine",
        "installerIcon": "icons/nsis_icon.ico",
        "headerImage": "icons/nsis_header.bmp",
        "sidebarImage": "icons/nsis_sidebar.bmp"
      },
      "signCommand": {
        "cmd": "powershell",
        "args": [
          "Start-Process",
          "C:\\actions-runner\\_work\nym-vpn-client\nym-vpn-client\nym-vpn-app\\src-tauri\\CodeSignTool.bat",
          "sign",
          "-username ***",
          "-password ***",
          "-credential_id 70580cf8-d1a6-4372-a46d-3decb0c583c6",
          "-totp_secret ***",
          "-input_file_path",
          "%1",
          "-override"
        ]
      }
    },

After a long battle, I finally got it working. This is my tauri.conf.json and my github action. I edited it a bit to strip it from unrelated things.
    "windows": {
      "nsis": {
        "template": "./bundle/windows/installer.nsi",
        "installMode": "perMachine",
        "installerIcon": "icons/nsis_icon.ico",
        "headerImage": "icons/nsis_header.bmp",
        "sidebarImage": "icons/nsis_sidebar.bmp"
      },
      "signCommand": {
        "cmd": "C:\\Program Files\\Git\\bin\\bash.EXE",
        "args": [
          "/c/actions-runner/_work/nym-vpn-client/nym-vpn-client/nym-vpn-app/src-tauri/CodeSignTool.sh",
          "sign",
          "-username ***",
          "-password ***",
          "-credential_id ***",
          "-totp_secret ***",
          "-program_name NymVPN",
          "-input_file_path",
          "%1",
          "-override"
        ]
      }
    },

Github action:
      - name: Build tauri desktop client
        working-directory: nym-vpn-app/src-tauri
        shell: bash
        env:
          CODE_SIGN_TOOL_PATH: "C:\\actions-runner\\_work\\nym-vpn-client\\nym-vpn-client\\nym-vpn-app\\src-tauri\\"
        run: |
          npm run tauri info
          if [ "${{ env.CARGO_TARGET }}" = "release" ]; then
            npm run tauri build
          else
            npm run tauri build -- --debug
          fi
          ls -la target/release/ || true
          ls -la target/release/bundle || true
          ls -la target/release/bundle/* || true


Readme reference Make

The readme suggests using make to build mmap-io from git, but the Makefile was removed in 29070c9065084e121c1522d8757677a262df5359
The readme should be updated with the current build instructions.

thanks, fixed.


In task-view modal, always place args_schema attributes last

The "Args Schema Version", "Args Schema non parallel" and "Args Schema parallel" should be listed last. The reason is that they are often very verbose, and it is not very frequent that one wants to go and read them in detail (while e.g. the docs_info property may be more relevant).
Changing the order of properties would help. Another (concurrent?) solution is to make the args-schema blocks collapsible (and collapsed by default).

Is this ok?
Compound task with args schemas collapsed:

Compound task with args schema expanded:

Compound task without optional fields:

Looks good to me!

Looks great!

Done in #434