Google SSO

Once this PR is merged, I'll send another to crm-application and platform-application with updated parameters.yml.dist:
google.client_id: ~
google.client_secret: ~
I think it would be also nice to include phpunit into dev-dependencies (so people don't have to install it globally and struggle with versions)
I suppose it's not necessary to write doc for this PR...

Please update Oro\Bundle\UserBundle\Migrations\Schema\OroUserBundleInstaller with your changes

Please add tests for OAuthProvider

Please add short documentation about ligin ability via Google OAuth

everything should be ok now if build passes.

all fixed

Thanks for your fixes.
But, then i try to run platform with your changes, i got error 'Fatal error: Uncaught exception 'Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException' with message 'The service "hwi_oauth.security.oauth_utils" has a dependency on a non-existent service "hwi_oauth.resource_ownermap.main"'.
google.client_id and google.client_secret parameters was set in parameters.yml. What i missed else?
And one thing. What do you think about to put this changes to the separate bundle? In this case, we can do extend package for Oro from this bundle.

it works for me (only difference is security configuration probably):
https://github.com/nenadalm/platform-application/compare/google_sso?expand=1
related to the separate bundle:

google sso sounds to me like something which doesn't have to be necessarily inside basic setup and could be installed as a plugin
if you want to have google sso in basic setup, it could stay here I think - as it is related with users and the functionality is inside UserBundle (sure you could think of it as separate feature, but in case you don't need/want it as separate feature, I don't think it's necessary)

if you want it as separate bundle (even repository?) tell me and I'll fix it.

@nenadalm Hi! You can add an extension i think /cc @DimaSoroka

From my point of view, would be great to have this functionality like separate extension.

@nenadalm, please move it separate bundle. Would be great to have this as a separate package, but this would require to move security.yml update to bundle level.

sure - will do tomorrow. So by separate bundle you mean the same repository as I understand.

At list separate folder so we can make it optional later on. The idea is that we should be able to make this bundle optional in the distribution and bundle should not require files update on application level.

Now it should be ok.
Regarding to application level files:
Fatal error: Uncaught exception 'Symfony\Component\Config\Definition\Exception\InvalidConfigurationException' with message 'You are not allowed to define new elements for path "security.firewalls". Please define all elements for this path in one config file.
it doesn't seems to be possible to configure security.yml by prepending configuration in standard way. So I could investigate this in case you don't have such feature already.

Please check what we can do for security.yml, this will be very helpful in future.

It could be solved using: https://github.com/orocrm/platform/commit/23cc6d6741a50eb8a3b5ab584df3bd35ff569b3d
in case you agree with it - I'll add a few tests.

Since there are no remarks, I assume you like it so I sent the tests and the PR is ready to merge. (in case tests will pass ofc)

Hi, @nenadalm.
Thanks for the changes. But I was expected that security firewall config will be done as separate yml file. In this case it will be the same as app.yml files from our bundles. With this files we can change main config.yml.
Example of usage this files can be found at https://github.com/orocrm/platform/blob/master/src/Oro/Bundle/AttachmentBundle/Resources/config/oro/app.yml . In this example we configure knp_gaufrette bundle from another (attachment) bundle.

done https://github.com/nenadalm/platform/blob/7d6c68f5ab9c44cca5ae4ecb9cb68a79e91a1c1d/src/Oro/Bundle/SSOBundle/Resources/config/oro/app.yml

Hi, few more comments:

SSO must be optional at the moment google.client_id and google.secret are mandatory in parameters.yml and can not be ~
Application installation is failing, because SSO bundle requires user tables but this bundle was included before UserBundle.
Would be great to have a link in documentation to Google API doc - how to configure Google OAuth.

SSO must be optional at the moment google.client_id and google.secret are mandatory in parameters.yml and can not be ~

so they can be "changeMe" by default

Application installation is failing, because SSO bundle requires user tables but this bundle was included before UserBundle.

done

Would be great to have a link in documentation to Google API doc - how to configure Google OAuth.

done

Hi, few more comments:
After fail login message like that "User '103552824819952957539' not found." is occurred. It should be standard "Invalid user name or password."
Please add to doc information about  REDIRECT URIS. ( login/check-google )
And it would be nice if the sso would be completely optional. Remove google.client_ parameters from parameters.yml and add them to the System Configuration UI

all fixed

Updates related with yesterday's skype sent.

remove use default in the ui
comma separated values for domains (instead of collection)
take domains into account for each login

so the only missing thing is the icon in system configuration

font-awesome used by oro is missing google icon: http://fortawesome.github.io/Font-Awesome/icon/google/
so probably it should be updated to newer version? (also class names are not .icon* but .fa* in newer versions of font-awesome (4)) so icon classes would have to be updated also

functional tests passed:
https://magecore.atlassian.net/builds/browse/BAP-FUNCTIONALTESTS136-1


Integration test for path filter

@Akash4927 Can you give a little detail about the issue/test.
I am willing to take it up.

@akhilerm please check integration_test/ginkgo_integration_test.go. This file gets executed when you trigger Integration Test for NDM.

@Akash4927 Can you give a little detail about the issue/test.
I am willing to take it up.

@akhilerm  Path filter use disk path to filter out disk's in node-disk-manager.yaml you can find one configmap and there is one entry for path filter configuration. There you can enable and disable this filter. You can also provide include and exclude filter to fit your use cases. If you provide include value then ndm will create disk cr for those disk which have path matching with given pattern in config map. If you provide exclude value then ndm will not create disk cr for those disk which have path matching with given pattern in config map. You can design one test plans for various use cases and put them in this issue. Then you can implement those tests.

Assume I have 2 physical scsi disk and 2 virtual disk.
Scsi disk's path starts with sd so path of 2 disks will be like /deb/sdx and /dev/sdx. Virtual disk's path starts with vd so path of 2 disks will be like /deb/vdx and /dev/vdx .
We want only scsi disk should be managed by ndm then we can specify sd in include section of configmap.
If we want only virtual disk should not be managed by ndm then you can specify vd in exclude section of configmap.
We can provide multiple value in include and exclude section suppose if we want to avoid loop, ram , rom disk's entry in etcd then wecan specify loop,sr,ram in exclude esction.

let me know if you have any question related path filter. and try to post test case plan here then implement it using citf.

thanks @shovanmaity . will update soon about the test plan.

Do I need to create a separate package for the path_filter test? Or include the test functions in ndm_util ?
Then I need to describe the integration test in ginkgo_integration_test.go. Is this the method I should follow?

@shovanmaity @a4abhishek
The steps I figured out for the test :

Call YAMLPrepare() to make necessary changes in YAML for exclude and include in filter configs.
trigger the integration test.
Check for whether the disks are attached or not using MatchDisksOutsideAndInside()

The test cases. : GetLsblkOutputOnHost() to get the list of disks present on host. Take each one from the list and modify the include/exclude in the yaml file. Run the test. eg : /dev/sda, /dev/sr0 in YAML and check that those are attached to the node / disk containers are created.
Test with same path in both include and exclude to check behavior.
Make sure disks in exclude are not in the list of created containers.
This is the current plan, I have identifed. Please give suggestions, so that it can be improved.

3. Check for whether the disks are attached or not using

@akhilerm add some precheck like if ndm is running delete it. Then modify yaml and create ndm again with modified yaml then quarry for disk object and check path for disk cr's. Add one cleanup at the end to delete all disk resources and ndm pod. High level steps looks good to me. @a4abhishek please review it once.

@shovanmaity  the creation and cleaning will  be done by _BeforeSuite and _AfterSuite right, if Iam triggering the test from  ginkgo_integration_test ?

This issue has been fixed in #172 .

yes!


ValueError: Trainer: num_samples should be a positive integer value, but got num_samples=0

Hi, thank you for providing such a great work and continuous update!
I am trying to train PTv3 using S3DIS datasets with semseg-pt-v3m1-0-rpe config. I have done all the steps necessary and have prepped my S3DIS using data preparation step and linked it using ln -s.
But, sadly I met a problem when trying to run the training script. That is the
ValueError: Trainer: num_samples should be a positive integer value, but got num_samples=0
Here is my training command line:
sh scripts/train.sh -g 1 -p python -d s3dis -c semseg-pt-v3m1-0-rpe -n semseg-pt-v3m1-0-rpe
I have done previous search onto this and found out similar problems on different machine learning projects. It says that the training process could not able to locate the dataset. But I have followed all the instruction you provided and do not know where did I went wrong?
thanks in advance and really appreciate the help!
and here is the full screenshot of the error:

I have solved it!
It seems that using
# PROCESSED_S3DIS_DIR: the directory of processed S3DIS dataset.
mkdir data
ln -s ${PROCESSED_S3DIS_DIR} ${CODEBASE_DIR}/data/s3dis

does not work on my machine and I have to move the whole PROCESSED_S3DIS_DIR directly into data/.


Add support for your favourite blockchains

You can read the steps for adding a new blockchain in the README.

Can you please provide some more details about what you would like achieved here?


As a user I want to be able to view data saved on the virtual cookbook after logging out and logging back in.

Acceptance Criteria

[x] The server persists the data.
[x] The user can view the persisted data when he is logged in.

Development Tasks

[x] #71
[x] #72

It was a battle but I won!!!


User should see claim button flip animation when he can claim

When user enters the claim screen and he can claim (ie button is displayed blue)
the button should show the animation. flip from orange timer with 1 second to blue claim button

@sirpy should this animation be displayed every time when i open the "Claim" screen?

yes when you can claim, not when timer is active

@sirpy flip animation isn't displayed for user that can claim
Video: https://www.screencast.com/t/Y3lqHCjj0
Checked on  QA 1.6.1-2
LG V30+ // Android 8.0 // Google Chrome 86.0.4240.75
Desktop: Windows 10 // Google Chrome  86.0.4240.75

Checked on QA v1.7.1-1
@sirpy
Timer always shows --.--.-- instead of 1 second before make flip animation.
The animation itselfworks without any issue
Video

that's the expected result


prometheus calls should be made with explicitly generated token - 353

[Auto generated]
Number: [#353]

openshift-python-utilities[pull_request][53ce-11ef-906a-697ae2da396a][PR 353]: Closing issue for PR: prometheus calls should be made with explicitly generated token.
PR was closed.


The MudDatePicker does not work in the dialogbox

@urmatgit What browser were you using?

edge and chrome browser having issue, This is the error message can see , Please check it and give some suggestion here


Add magic functions to change the code cells

Is your feature request related to a problem? Please describe.
This is not really a problem, just something to make it easier to change the code cell.
Describe the solution you'd like
Add Jupyter magic to switch the code cells without manually clicking to change
%sql to run sql
%md for markdown
%sas for SAS code
%py (or something) for Python
Describe alternatives you've considered
N/A
Additional context
N/A
Environment
All

You can assign a keyboard shortcut to the notebook.cell.changeLanguage command. Is it similar to your request?

No, not a keyboard shortcut.
In the SASNB code cell if the cell is set to SAS but I want to use SQL. Instead of a shortcut key or manually modifying the code cell, I can just type %sql at the top an it will automatically change the cell to run SQL.
There are some magic functions like that in the SWAT package. Also, if you use DataBricks notebooks, they do it.


No good way to dynamically change font size

Once you create the StyledTextRenderer, you would need to create an entirely new object to change one small attribute like font size.  This is an expensive process

@jseidman95 how is it an expensive process? I’d much prefer calling a builder to recreate an immutable data structure than allow things to be mutated.
Sent with GitHawk


Modify the canny_edge_detection  input stream from ImAxis<24> to ap_axiu<24,1,1,1>

I want to modify your code so that it could take hls::stream<ap_axiu<24,1,1,1>>& instead of hls::stream<ImAxis<24>>&
i.e from
void canny_edge_detection(stream<ImAxis<24>>& axis_in, stream<ImAxis<24> >& axis_out,
uint8_t& hist_hthr, uint8_t& hist_lthr)
to
void canny_edge_detection(stream<ap_axiu<24,1,1,1>>& axis_in, stream<ap_axiu<24,1,1,1>>& axis_out,
uint8_t& hist_hthr, uint8_t& hist_lthr)
But, vivado_hls keeps complaining there is left over data, can you advise me how to do it?
Many thanks

not working
HlsImProc.hpp.txt

Hi @3togo
Thank you for your comment.
I'm using ImAxis<24> which have only 5 signals (data, valid, ready, user, and last) instead of ap_axiu<24,1,1,1> because of due to specification of AXI VDMA.
I checked working my code using Vivado HLS 2018.2 now, however, I think it is no problem as far as I saw the synthesis log.
Could you show me such as error log?


fix: build --no-codegen output file name error

This avoids errors based on output file name when the --no-codegen command is passed to crystal build since it shouldn't be necessary to specify an output file if no file will be created anyway.
$ crystal build --no-codegen  example/example.cr
Error: can't use `example` as output filename because it's a directory

This change means that the following lines of code get skipped when using --no-codegen.
https://github.com/crystal-lang/crystal/blob/bb96c5398e001f41b31431eea283a1a28198a84b/src/compiler/crystal/command.cr#L598-L601
https://github.com/crystal-lang/crystal/blob/bb96c5398e001f41b31431eea283a1a28198a84b/src/compiler/crystal/command.cr#L611-L613
It will also means that we skip the combine rpaths step.
https://github.com/crystal-lang/crystal/blob/bb96c5398e001f41b31431eea283a1a28198a84b/src/compiler/crystal/command.cr#L619

Hey @apainintheneck, thanks for picking this up! 👋
This PR looks all right, as in it should probably work. But I'm a bit concerned about the semantics and wondering if there couldn't be a better solution.
The reason is that no_codegen is an input parameter and it feels a bit sketchy to change its value somewhere down the line. It will probably work fine because all the relevant code that uses it as the original input parameter is in the initial setup that and that has already executed at this point. So it's not used for that anymore.
Yet, wie have some duplication with compiler.no_codegen which contains the configuration value. So I'm thinking maybe instead we could replace all references to no_codegen by compiler.no_codegen in the subsequent code after the option parser setup.
And set compiler.no_codegen = no_codegen at the top of the method.
Then there would be a clear separation: no_codegen is only responsible for the CLI configuration. compiler.no_codegen determines if codegen is actually enabled in the compiler.

Yet, wie have some duplication with compiler.no_codegen which contains the configuration value. So I'm thinking maybe instead we could replace all references to no_codegen by compiler.no_codegen in the subsequent code after the option parser setup. And set compiler.no_codegen = no_codegen at the top of the method. Then there would be a clear separation: no_codegen is only responsible for the CLI configuration. compiler.no_codegen determines if codegen is actually enabled in the compiler.
Does this make sense to you?

This makes sense to me. It shouldn't change semantics like you said but it will make the code easier to reason about.


Descargas2020 failing to download

Hello
I'm trying to reconfigure flexget to download from http://feeds2.feedburner.com/descargas2020/  but i can't
Running on a QNAP TS-212 with Entware-ng
I just upgrade Flexget via PIP to last version 2.13.6
I'm tried with python2.7 and python3.6 and 3.6 i got an error when parsing
With pyhton2.7:
 /opt/bin/python2.7 /opt/bin/flexget -c .flexget/config.yml_NEW execute
I get this error in console and by email:

The following entries have failed for task mis_series:

The Walking Dead - Temporada 8 [HDTV][Cap.812][Español Castellano] (http://feedproxy.google.com/~r/Descargas2020/~3/iHZUOlqRCOI/) Reason: Unexpected html content received from http://feedproxy.google.com/~r/Descargas2020/~3/iHZUOlqRCOI/ - maybe a login page?

Arrow - Temporada 6 [HDTV][Cap.615][Español Castellano] (http://feedproxy.google.com/~r/Descargas2020/~3/Vma6JVWNMbw/) Reason: Unexpected html content received from http://feedproxy.google.com/~r/Descargas2020/~3/Vma6JVWNMbw/ - maybe a login page?

Hawaii Five 0 - Temporada 8 [HDTV][Cap.816][Español Castellano] (http://feedproxy.google.com/~r/Descargas2020/~3/rI7Ey5SFXKc/) Reason: Unexpected html content received from http://feedproxy.google.com/~r/Descargas2020/~3/rI7Ey5SFXKc/ - maybe a login page?

I upgraded flexget because this ticket #2093 but I can't get it working
Config file (only problematic task):

rss:
url: http://feeds2.feedburner.com/descargas2020/
link: link
series:
settings:
normales:
ep_regexp:
- Cap.(\d+)(\d\d)
quality: hdtv <720p
normales:
- Scandal:
set:
patch: "/share/external/sdr1/Series/Scandal/"
regexp:
reject:
- V.O.:
from: title

Is a bug or only an error in config files?
How can I get it working??
Can anyone help me?
thanks in advance!!

looks like the links from your feed will not provide .torrent files

Thank very much to both!
I was using the old url for the feed. I didn't know is was a bug with new "descargas2020 urlrewrite" plugin or an missmatch in config files
No problem if rss is slow in updating links... I only want to accumulate the donwloads in NAS server "ready for use"
Thank you and, please, close ticket
Moises

you can close ticket youself :)


MacOS - 1.6 - Creation of AuthDelegate failed - Device Serial Number unknown

Briefly summarize your issue:
I'm running version 1.6 of the SDK (Can't get 1.7+ to compile due to (#880))
What is the expected behavior?
I can get the SampleApp to build, but running it fails
What behavior are you observing?
./SampleApp/src/SampleApp ./Integration/AlexaClientSDKConfig.json                                          ✘ 1  (docker-for-desktop)
2018-07-28 16:02:03.423 [  1] I sdkVersion: 1.6.0
Creation of AuthDelegate failed!
Failed to initialize SampleApplication
Failed to create to SampleApplication!

Provide the steps to reproduce the issue, if applicable:
I'm continuing down the MacOS guide.  I've managed to find my Client Id and Product Id, but not the Device Serial Number. I tried the 'Amazon Id', with no luck.  Not sure where to find this, but running without that value, I get the error log above.
Tell us about your environment:
What version of the AVS Device SDK are you using?
  1.6.0

Tell us what hardware you're using:

[x] Desktop / Laptop
[ ] Raspberry Pi
[ ] Other - tell us more:

Tell us about your OS (Type & version):

[ ] Linux
[x] MacOS
[ ] Raspbian Stretch
[ ] Raspbian Jessy
[ ] Other - tell us more:

Have you tried with random number like 123456 ?

Yes, @Smanar.  I tried a few different values. I suppose it's possible this isn't my problem at all.  Maybe it has to do with the wiki being for the new version (1.8) and me having to run the old one (1.6).
I'm not sure, I'm afraid.

Hi jeffdeville,
The values for the CBL database, productId, deviceId are mandatory. Not specifying these will read to SampleApp initialization failures. As smanar points out deviceid can be any random number. ProductId should be a valid ProductId an Client ID should be a CBL client Id and not the regular id used until 1.5.
Are you using the CBL Client Id as discussed in the link below
https://wiki.labcollab.net/confluence/pages/viewpage.action?pageId=461336572
Please let us know your findings.
Thanks
Priya

I'm afraid I can't reach the confluence page you linked. Is it publicly accessible?  That said, the CBL lead did lead me to this page:
https://github.com/alexa/avs-device-sdk/wiki/Code-Based-Linking----Configuration-Update-Guide
So I did update (on 1.6 build of the SDK) my config with a client ID that corresponded to a value from:
Alexa Voice Service > [My Product] > Security Profile > Other devices and platforms
In case it matters, the 'information' tab of my product is configured like this:
Please select your product type: Alexa Enabled Device (I'm experimenting on my Mac, because my Pi isn't accessible to me right now, but that is what I'll be using eventually)
Will your device use a companion app? No
How will end users interact w/ your product? Hands-free
Do you intend to distribute this product commercially? No
Thank you for following up, @priyagsenthil !

Hi @jeffdeville, were you able to update your compiler version to resolve #880?
Otherwise, since v1.6 version of the SDK doesn't use CBL, you can follow this older MacOS guide for setup:
https://github.com/alexa/avs-device-sdk/wiki/macOS-Quick-Start-Guide/d0eab34d2c52ab04203904cd6a4fc73143435f89
Please note that you don't use the ClientID used under the "Other devices and platforms", but rather from the "Security Profile" directly.

I am closing this issue due to inactivity. Please feel free to re-open it if it has been closed in error.


Fully automated release process

Checklist:

[x] Was this PR discussed in a issue? It is recommended to first discuss a new feature and let the community know whether you are planning or have started working on it before opening a PR.
[ ] Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
[ ] Update the API documentation if a new function is added or an existing one is deleted.
[x] Added a news entry.

copy news/TEMPLATE.rst to news/my-feature-or-branch.rst) and edit it.

(the edit on the README is just auto formatting)

LGTM, I think we should consider adding an environment (https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment)  to require approval before the release  action can be executed.


[Tests] create_test script: Improve argument description and snake_case name conversion

Certain argument descriptions were a bit misleading/unclear. This PR aims to fix that and makes the script a bit more pleasant to use in general.

Thanks!


Generalized no-goto-without-base into no-navigation-without-base

Closes #891

Rule implementation looks good, but I made this package ESM.
https://github.com/sveltejs/eslint-plugin-svelte/pull/932
Could you please merge the main branch and fix it by adding .js to the import statement of your implementation?


Revert Icon Pls

Username and Discrim: AHIRA#1216
User ID:<PHONE_NUMBER>65970177
Image Link: https://cdn.discordapp.com/emojis/762438597340430367.png

there, should be fixed now! sorry abt that lol

there, should be fixed now! sorry abt that lol


Fix GCC OOM when building by reducing parallelism.

Why
Builds OOM with the following error : https://app.circleci.com/pipelines/github/facebookincubator/velox/43449/workflows/0ecff160-1cb9-4084-9f1e-21ae5b484321/jobs/302064 . We reduced the parallelism recently but dint reduce it for all jobs (https://github.com/facebookincubator/velox/pull/8530) - In this PR we set it for all debug jobs (which are most likely to OOM )
How
We reduce parallelism as a stop gap to fix this issue and unblock folks.  We have an issue here for a long term fix : https://github.com/facebookincubator/velox/issues/8539

@majetideepak
It does not look like it failed in link step no :
/usr/bin/ccache /opt/rh/gcc-toolset-9/root/bin/g++  -DBOOST_ALL_NO_LIB -DBOOST_CONTEXT_DYN_LINK -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_REGEX_DYN_LINK -DBOOST_SYSTEM_DYN_LINK -DBOOST_THREAD_DYN_LINK -DFOLLY_HAVE_INT128_T=1 -DGFLAGS_IS_A_DLL=0 -DSIMDJSON_THREADS_ENABLED=1 -I../../. -I../../velox/external/xxhash -I_deps/xsimd-src/include -I_deps/simdjson-src/include -isystem ../../velox -isystem ../../velox/external -isystem /usr/include/libdwarf -mavx2 -mfma -mavx -mf16c -mlzcnt -std=c++17 -mbmi2 -D USE_VELOX_COMMON_BASE -D HAS_UNCAUGHT_EXCEPTIONS -Wall -Wextra -Wno-unused        -Wno-unused-parameter        -Wno-sign-compare        -Wno-ignored-qualifiers        -Wno-implicit-fallthrough          -Wno-empty-body          -Wno-class-memaccess          -Wno-comment          -Wno-int-in-bool-context          -Wno-redundant-move          -Wno-array-bounds          -Wno-maybe-uninitialized          -Wno-unused-result          -Wno-format-overflow          -Wno-strict-aliasing          -Wno-type-limits          -Wno-stringop-overflow          -Wno-stringop-overread          -Wno-return-type -Werror -g -fPIC   -fdiagnostics-color=always -Wno-deprecated-declarations -std=gnu++17 -MD -MT velox/functions/prestosql/registration/CMakeFiles/velox_functions_prestosql.dir/ArithmeticFunctionsRegistration.cpp.o -MF velox/functions/prestosql/registration/CMakeFiles/velox_functions_prestosql.dir/ArithmeticFunctionsRegistration.cpp.o.d -o velox/functions/prestosql/registration/CMakeFiles/velox_functions_prestosql.dir/ArithmeticFunctionsRegistration.cpp.o -c ../../velox/functions/prestosql/registration/ArithmeticFunctionsRegistration.cpp

Will just reducing max link jobs help ?

It does not look like it failed in link step no :

Thanks for the clarification.


Load balancing passive FTP connection to  two upstream nodes

I need info about it.  Possible or not?
HAproxy supports the TCP loadbalancing but in the combination with docker-flow never tried.
I am interested in the one node version and the two nodes version as well.

Can you post a sample HAProxy configuration that you'd like to accomplish and I'll get back to you with the labels required to do the same in DFP. If something is missing, with a sample configuration it should be trivial to add it to DFP.

You can see our existing conf, which can split the passive data ports to two ranges.
This is just a theory, we tried it, it works with FTP Explicit mode, but not in plain mode.
I need ideas, who not working with simple plain mode? (roundrobin in control channel but not in data channel?  or IP persistence is wrong?)
Also need the labels if possible.

# Control TCP socket on port 21 should be split between  nodes with afinity.
--
# Also set correct timeouts (ftp server has ftp.maxIdleTime=300, here we need little bit longer)
listen ftp-control
bind *:21
mode tcp
option tcplog
balance roundrobin
timeout tunnel 350s
timeout client-fin 5s

server ftp-22 <IP_ADDRESS>:21 check inter 10s rise 1 fall 2
server ftp-23 <IP_ADDRESS>:21 check inter 10s rise 1 fall 2

# For FTP data, specific ports map to specific node. Same ranges have to be configured in local.cfg ftp.connection.passive.ports of ftp servers
# Assign 150 ports for each node (port-range 50000-50149 and 50150-50299)

listen ftp-data22
bind *:50000-50149
mode tcp
option tcplog
server ftp-22 <IP_ADDRESS> check port 21 inter 10s rise 1 fall 2

listen ftp-data23
bind *:50150-50299
mode tcp
option tcplog
server ftp-23 <IP_ADDRESS> check port 21 inter 10s rise 1 fall 2

I don't think you need a proxy for that. The idea behind the proxy is to have a single entry port for multiple services (and a few other things). You can accomplish your scenario by publishing ports of your services since they seem to be different for each.
Please let me know if you do need proxy for that and I'll send you a sample params you can use.
P.S. Sorry for the late reply. I had too much on my plate the last few days.

Ok, waiting for your solution and conf.

If you publish ports of your FTP services, Docker's Ingress network will take care of load balancing. There's no need for DFP for that.
I'd like to make sure that your use case does benefit from DFP before proceeding further. With the information you posted by now, I'd recommend publishing the ports without DFP to accomplish your goals.

The problem is that each host where the FTPserver runs has no public access to the net, thats why we need proxy for that.

Sorry for not getting back to you earlier @wyxgit. I was in Jenkins World and arrived back home only a few hours ago.
Can you take a look at http://proxy.dockerflow.com/swarm-mode-auto/#using-tcp-request-mode? It explains how to setup DFP>Redis communication using TCP. I think that's (more or less) what you're looking for.

@wyxgit Did the link I sent help? Can I close this issue?

Closing due to inactivity... Feel free to reopen this issue if you're still facing the same problem or would like to continue the discussion.


Add Astrochart to NPM package

As mentioned by @andandio in #11 , there is an outdated npm package for AstroChart.
It would be nice to have an oficial package published and updated

Created: https://www.npmjs.com/package/@astrodraw/astrochart


CMakeLists - ROCM_PATH ENV Variable

Some ROCm installations do not have ROCm path set. Instead set an ENV Variable.
CMakeLists needs to identify ENV variable and set default path for ROCm

Implemented


[WIP] Refactor CMake scripts.

Remove CMake CUDA wrapper.
Bump CMake version for CUDA.
Use CMake to handle Doxygen.
Split up CMakeList.
Export install target.
Use modern CMake.
Remove build.sh
Workaround for gpu_hist test.
Remove build_config.h.in

@RAMitchell Thanks for the suggestion, I added your workaround for dmlc registrations.  But the added inline keyword for GPU kernel generates a warning.

Hi, it could install the python package in a dir relative to CMAKE_INSTALL_PREFIX (lib/pythonx.ysite-packages on unix and Lib/site-packages on win32).

@jschueller That would be part of Python setuptools.   I don't think CMake is the right tool to install Python package.

Correct me if I'm wrong but it seems the python bindings is just made of a bunch of .py files, I guess cmake could copy them to the site dir.

@jschueller setuptools does a lot more than copying scripts.  It helps compile Python scripts into bytecodes, creates a Packages and handles its dependencies.

@hcho3 Related to #4331.  I bumped CMake to 3.8 but another attempt by @RAMitchell uses 3.9, see #4316.  I'm not sure this PR will work out smoothly as you can see from the tests, my build failed in various ways depending on different platforms, while built perfectly on my machine.  I believe there are lots of different bugs from different platforms ...  So please don't put too much weight on this PR for now,  I'm not sure I can workaround all of them ...

@trivialfis Okay, in that case, should we keep the current CMake version (3.6.0) for now?

@hcho3 Yep, thanks.  I will upgrade it when it's done.

List of known issues in CMake CUDA lang:

Chosen compiler by exporting CC and CXX doesn't not get propagated to CUDA.
CXX_STANDARD does not get propagated to CUDA.
Flags like -Xcompiler xxx or -gencode arch,code ... that contain space does not do well with target_compile_options.

As mentioned by @RAMitchell and @hcho3, I should write a short introduction about rationale about this rewrite.  Here it's. ;-)
Goal
tl;dr: Enable C APIs with easy to use build system interface:
find_package(xgboost REQUIRED)
target_link_libraries(mytarget xgboost::xgboost)

The above two lines should get include path and linking done.
Why it takes a rewrite to accomplish this
There's a trend about Modern CMake, where one specify build options target by target.  The extra effort is not only to make the code look nicer, but a fundamental requirement for making a usable shared library.  Since we are building C APIs, user of the interface should not know anything about what libraries xgboost need, what extra flags are required to build a project with xgboost, nor the CXX standard we use.  For instance, users of xgboost should not need to pass OpenMP flags to their projects.  That means we need to seal all these stuffs behind the build system.
With CMake, all requirements of using a library is abstracted in a installed config file like xgboost-config.cmake which is used by find_package command.  And the target based style CMake is to make sure we only export absolute necessary build specification to our interface.  In xgboost, that's only include directory and the path of linkable object.  Commands like include_directories, link_libraries and global variables that don't distinguish between interface and internal should not be used any more.
What problems this won't solve
Symbols visibility.  For a shared library, providing restricted but stable ABI is important for easy distribution.  In some cases one would pass flags like gcc -fvisibility=hidden to make all symbols hidden from interface except the ones marked by __attribute__(visibility("default")).  There are other complications in this like whether dmlc::Error should be visible to other users.  This PR doesn't address this problem, and not likely in the future since we have to go through dmlc-core and rabit to make a clear sense about the implications.

@RAMitchell Could you take a look at the above known issues?  I felt like there are too many things to work around ...

@trivialfis Can we just use a recent version of CMake to avoid known issues?

@hcho3 Currently I build it with CMake 3.12, which ships with Ubuntu 18.10.  Do you think it's a little too aggressive? @RAMitchell

Currently it's the last item

Failed to link cuda runtime before<EMAIL_ADDRESS>Probably due to our use of object library.

I can't work around.  I don't know how to link CUDA runtime manually.  Another way to do it might be using static library with PIC for libxgboost at first then convert it into shared library later ..  But it's getting more and more weird.

@trivialfis I'm okay with using CMake 3.12 for CUDA code.

@trivialfis I am ok with requiring cmake 3.12. I don't have any experience with your particular issue linking the run-time, but in the past I have built the project by combining GPU code into a static library and linking this into the xgboost shared library. This was a workaround for linking issues due to dmlc register, at the time I could not make it work using object libraries.

@hcho3 @RAMitchell Ready for another review.  The build system is quite huge by now,  CMake has its limitation.  If you find anything that is not clear or over complicated in the code, please let me know.  I don't want anyone get stumbled by the build system.

Codecov Report

Merging #4323 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4323      +/-   ##
==========================================
+ Coverage   67.92%   67.93%   +<.01%
==========================================
  Files         132      132
  Lines       12240    12240
==========================================
+ Hits         8314     8315       +1
+ Misses       3926     3925       -1

Impacted Files
Coverage Δ

src/c_api/c_api.cc
23.53% <ø> (ø)
:arrow_up:

src/objective/multiclass_obj.cu
93.68% <0%> (+1.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edae664...1a7718d. Read the comment docs.

Added a short intro in demo/c-api/readme.md for using CMake with xgboost.

@RAMitchell Would be be able to try it on Windows with CUDA when time allows?

Ping @CodingCat

Thanks for all the help!


Close project

Implement the ability to close the current project. Those add to the menu the Close project item. When the user clicks on this item, the active project should be closed. The user will be able to reopen the project, or select another project in the list of projects.

Implemented in v1.5.


Allow multi-line formatting for HTML tags in check-templates

Our check-templates tool currently complains about code like this:

Well oops. This one's probably our fault. Sorry about that! Updates on
service availability are posted to
@ZulipStatus on Twitter.

We should allow tags to span multiple lines, and we possibly want to give
 some special consideration.
We need to be a little careful with this change, as being more lenient about reasonably formatted code like above may let some uglier code through.  We may also want to wait until we have test coverage on template_parser.py (coming soon, hopefully).
See also #1236

There is now very basic coverage on template_parser.py, although we'd want to write some specific failing tests for any change here.

@showell has this one ended up happening?

There's now support for long anchor tags, and there's a test called test_anchor_blocks on it.  I think we still insist that the
 tags are on their own line, so the original example won't pass.  I am gonna close this.


Updating Adminlte 1 to 3

I am having trouble updating my Adminlte version 1 to 3, the only way I could do it is creating a new project with adminlte 3 and migrating the files one by one. even though everything seems kinda out of place in the new version. Is there an easy way I can do this?

Overall you not need to create a new project for this, but you need to update laravel, laravel-adminlte, adminlte and update also all existing views to adminlte 3/bootstrap 4 standard. There is no easy way for this.


Tectonic console returns "401 Unauthorized" error code after install

Tectonic console returns "401 Unauthorized" error code after install
Tectonic Version
1.5.1-tectonic.1
Environment
AWS, installed from a Mac (using darwin/installer)
Expected Behavior
I have just completed the tectonic-install, and it seemed to work, finally. I think this is the URL for the Tectonic console: https://MY-HOSTNAME-FOR-NEW-TECTONIC.donorschoose.org/
I would expect that to show me the Tectonic console, although I don't see any documentation that gives the actual URL.
Actual Behavior
Instead, that URL returns a "401 Unauthorized" error code. The hostname does resolve, and there is a response on port 443. It's just an error.
Other Information
I had quite a bit of trouble with my initial installation (https://github.com/coreos/tectonic-forum/issues/28) and may not have succeeded.

Found correct URL
There were two Route53 DNS records. The one with the -k8s extension on the subdomain hostname is the controller.


When using VC15, stdlib.h isn’t found

I’m using Visual Studio 15 (beta), and if I don’t run vcvars64.bat my code which depends on flate2 which depends on miniz-sys which depends on miniz.c fails to compile:
   Compiling miniz-sys v0.1.7
Build failed, waiting for other jobs to finish...
error: failed to run custom build command for `miniz-sys v0.1.7`
process didn't exit successfully: `C:\path\to\my-crate\target\debug\build\miniz-sys-60c8d67696f63a43\build-script-build` (exit code: 101)
--- stdout
TARGET = Some("x86_64-pc-windows-msvc")
OPT_LEVEL = Some("0")
PROFILE = Some("debug")
TARGET = Some("x86_64-pc-windows-msvc")
debug=true opt-level=0
HOST = Some("x86_64-pc-windows-msvc")
TARGET = Some("x86_64-pc-windows-msvc")
TARGET = Some("x86_64-pc-windows-msvc")
HOST = Some("x86_64-pc-windows-msvc")
CC_x86_64-pc-windows-msvc = None
CC_x86_64_pc_windows_msvc = None
HOST_CC = None
CC = None
TARGET = Some("x86_64-pc-windows-msvc")
HOST = Some("x86_64-pc-windows-msvc")
CFLAGS_x86_64-pc-windows-msvc = None
CFLAGS_x86_64_pc_windows_msvc = None
HOST_CFLAGS = None
CFLAGS = None
running: "C:\\Program Files (x86)\\Microsoft Visual Studio 15.0\\VC/bin\\amd64\\cl.exe" "/nologo" "/MD" "/Z7" "/FoC:\\path\\to\\my-crate\\target\\debug\\build\\miniz-sys-60c8d67696f63a43\\out\\miniz.o" "/c" "miniz.c"
miniz.c
miniz.c(177): fatal error C1083: Cannot open include file: 'stdlib.h': No such file or directory
ExitStatus(ExitStatus(2))

command did not execute successfully, got: exit code: 2

--- stderr
thread 'main' panicked at 'explicit panic', C:\Users\me\.cargo\registry\src\github.com-1ecc6299db9ec823\gcc-0.3.28\src\lib.rs:840
note: Run with `RUST_BACKTRACE=1` for a backtrace.

Latest rustc nightly.

I believe this is the same as https://github.com/alexcrichton/gcc-rs/issues/83, so I'm going to close in favor of that.

Well, this is for VC 15, which is a different version than the VC++ 2015 Build Tools. The other issue is also more so just failing to find msvc at all in the first place, while this issue is failing to locate the headers correctly.

Ok, I've updated the logic in https://github.com/alexcrichton/gcc-rs/pull/85, @chris-morgan can you try that out and see if it works for you?

@alexcrichton The latest version of gcc is working correctly for me. Thanks!


Please add me

Hello, I didn't have time to do this assignment last week so I wanted to do it now. Is it possible?

Yes. Adding ... just a moment ...


Unable to Map the Resolution Field Data

Scenario - We need to map the Jira resolution field data to ADO Custom created Field.
Configuration
{
"source": "resolution",
"target": "Custom.Resolutions",
"mapping": {
"values": [
{
"source": "None",
"target": "None"
},
{
"source": "Resolved",
"target": "Resolved"
},
{
"source": "Unresolved",
"target": "Unresolved"
},
{
"source": "Done",
"target": "Done"
}
]
}
},
Current Situation - Resolution Field Data is not mapping on the ADO Field.
So could you please provide assistance on the above issue.

Please see the FAQ: https://github.com/solidify/jira-azuredevops-migrator/blob/master/docs/faq.md#3-how-to-map-custom-field

Hi Team,
So ### We are facing mapping issues with ADO Epic work item resolution field, But for User Story & Task resolution data is mapping correctly.

@pranaykh16
It is my understanding that this is a different issue than originally?
Consider contacting us for a paid support plan or other consulting services: https://github.com/solidify/jira-azuredevops-migrator#jira-azure-devops-migrator-pro


Develop

update navigation page
added infinit list
added topbar
update gui
added babel-plugin-root-import'

approval


Mock creation throws NPE when class extends spark Logging and calls log

If you want to discuss a new feature, please ignore/clear this form.
ScalaMock Version (e.g. 3.5.0)
3.5.0
Scala Version (e.g. 2.12)
2.11
Runtime (JVM or JS)
JVM
Please describe the expected behavior of the issue
Mock should be created successfully. No exceptions thrown.
Please provide a description of what actually happens
NullPointerException is thrown during runtime.
An exception or error caused a run to abort.
java.lang.NullPointerException
	at FooTest$$anon$1.log(FooTest.scala:6)
	at Foo.<init>(FooTest.scala:10)
	at FooTest$$anon$1.<init>(FooTest.scala:6)
	at FooTest.<init>(FooTest.scala:6)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
	at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
	at java.lang.Class.newInstance(Class.java:442)
	at org.scalatest.tools.Runner$.genSuiteConfig(Runner.scala:1422)
	at org.scalatest.tools.Runner$$anonfun$31.apply(Runner.scala:1236)
	at org.scalatest.tools.Runner$$anonfun$31.apply(Runner.scala:1235)
	at scala.collection.immutable.List.map(List.scala:284)
	at org.scalatest.tools.Runner$.doRunRunRunDaDoRunRun(Runner.scala:1235)
	at org.scalatest.tools.Runner$$anonfun$runOptionallyWithPassFailReporter$2.apply(Runner.scala:1011)
	at org.scalatest.tools.Runner$$anonfun$runOptionallyWithPassFailReporter$2.apply(Runner.scala:1010)
	at org.scalatest.tools.Runner$.withClassLoaderAndDispatchReporter(Runner.scala:1500)
	at org.scalatest.tools.Runner$.runOptionallyWithPassFailReporter(Runner.scala:1010)
	at org.scalatest.tools.Runner$.run(Runner.scala:850)
	at org.scalatest.tools.Runner.run(Runner.scala)
	at org.jetbrains.plugins.scala.testingSupport.scalaTest.ScalaTestRunner.runScalaTest2(ScalaTestRunner.java:131)
	at org.jetbrains.plugins.scala.testingSupport.scalaTest.ScalaTestRunner.main(ScalaTestRunner.java:28)

Reproducible Test Case
Please provide a minimised code snippet that fails, ideally, written as a failing test case in ScalaTest.
This will help us a lot in diagnosing the problem and work on a fix.
If the issue is more complex or requires configuration, please provide a link to a project on Github that reproduces the issue.
import org.apache.spark.internal.Logging
import org.scalamock.scalatest.MockFactory
import org.scalatest.FlatSpec

class FooTest extends FlatSpec with MockFactory {
  mock[Foo]
}

class Foo extends Logging {
  log.info("foo log")
}

The stacktrace gives you a clue what happens here: Foo.<init>(FooTest.scala:10)
Your constructor of Foo is relying on the actual implementation of Logging but the whole purpose of a mock is to not use the original implementation at all. So this cannot work.
As you can see in the spark codebase, log is a protected method, so a mock will not include this code. https://github.com/apache/spark/blob/0e31a6f25e0263b144255a6630e1d381fe2d27a7/core/src/main/scala/org/apache/spark/internal/Logging.scala#L44
In other words, this is not a bug, but an invalid use-case for mocks.
I think there are frameworks which support partial mocking, but for ScalaMock, this is definitely out of scope.

@barkhorn
Hey Philipp,
Thanks for the response. Could you explain a bit more on why this is an invalid use-case for mocks? The situation is that I don't need the logging to be executed but it is in the constructor of the class which I'd like to mock. Does this mean that I cannot use ScalaMock if I'd like to mock a class which calls a protected method of super class in the constructor?

Let me rephrase this a little differently then:

mocks are an (anonymous) subclass of the type to mock
mocks tear off the original implementation and delegate to call handlers for the purpose of mocking calls (with a few exceptions, e.g. private methods)
per JVM convention, subclass constructors will call their baseclass constructor first

Foos constructor depends on the concrete implementation of log, but in a mock this will delegate to a call handler, and that could not be initialised yet due to constructor precedence. So it generates an NPE.
Calling overridable methods in a constructor is bad design, as that can lead to partially constructed objects like in this case.
A possible way around this would be to use objenesis to avoid calling constructors, I am experimenting with that. Right now though, because of the way the JVM works, you will need to find a workaround.


ERROR tests/browser/test_create_user_context.py::test_browser_create_user_context[websocket0] is flaky time out

cc @Lightning00Blade @sadym-chromium any ideas? it didn't time out before and there are also no user context related events. Has anything changed w.r.t. to browsing contexts? I have seen this failure a couple of times today.
Example failure: https://github.com/GoogleChromeLabs/chromium-bidi/actions/runs/8362146671/job/22892014453

looks like the flakiness is over. The test is re-enabled


I completed assignment1

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Adding codes to complete my assignment
What did you learn from the changes you have made?
Lean about Git & Shell and how to upload on Github
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
No
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
Learning cjallanges
How were these changes tested?
Practice and practice
A reference to a related issue in your repository (if applicable)
N/A
Checklist

[x ] I can confirm that my changes are working as intended

No comment


cannot use external javascript packages when testing while using vscode remotely

Dear AnWeber,
first of all thank you for that amazing vscode extension!
Unfortunately, I found a really weird bug happening when testing with e,g, "assert" or "chai" an endpoint while using vscode remotely.
See error message below:

TypeError: Cannot assign to read only property '_fsPath' of object '[object Object]'
at v.get fsPath [as fsPath] (/home/ivo/.vscode-server/bin/899d46d82c4c95423fb7e10e68eba52050e30ba3/out/vs/server/remoteExtensionHostProcess.js:73:14942)
at Object.ni.io.fileProvider.fsPath (/home/ivo/.vscode-server/extensions/anweber.vscode-httpyac-4.10.0/dist/extension.js:274:7580)
at E2 (/home/ivo/.vscode-server/extensions/anweber.vscode-httpyac-4.10.0/dist/extension.js:126:90247)
at Uh (/home/ivo/.vscode-server/extensions/anweber.vscode-httpyac-4.10.0/dist/extension.js:127:29305)
at Object.action (/home/ivo/.vscode-server/extensions/anweber.vscode-httpyac-4.10.0/dist/extension.js:127:28669)
at l5. (/home/ivo/.vscode-server/extensions/anweber.vscode-httpyac-4.10.0/dist/extension.js:1:4676)
at Generator.next ()
at s (/home/ivo/.vscode-server/extensions/anweber.vscode-httpyac-4.10.0/dist/extension.js:1:3138)
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:93:5)

How to reproduce:
In VS Code, select Remote-SSH: Connect to Host.
GET http://localhost:8080/api/test
{{
  const { equal } = require('assert');
  test('status code 200', () => {
    equal(response.statusCode, 200);
});

What I figured out so far:

same happens when I use chai
it does not matter if I use a GET or POST
error does not occur when running httpyac from the command line

If it helps to know:
OS: Manjaro Linux x86_64
vscode: aur/visual-studio-code-bin 1.63.2-1
Let me know if you need some extra information from me.
Keep up the good work :v:
Ivo

Does the use of my helper methods work?

GET http://localhost:8080/api/test
{{
  test.status(200);
}}

In which environment is the extension installed? This should be enabled on the remote environment.

I noticed that there is a small error in the example. But this is probably not the reason

GET http://localhost:8080/api/test
{{
  const { equal } = require('assert');
  test('status code 200', () => {
    equal(response.statusCode, 200);
}}

Thank you for the quick reply :)
The small error in the example was a copy & paste issue.
I took that snippet from a bigger code block and forgot the closing brackets.
Oh nice I was not aware yet of that helper function.
Cool to know but unfortunately runs into the same error.
Nevertheless, it looks like that double checking the httpYac Rest client extension status was a good hint.
I tried restarting the httpBook extension which does not help but this seems to work:

select Remote-SSH: Connect to Host
disable the httpYac Rest client extension -> accept the reload
enable the httpBook client extension

Now it should work again.
Not sure if my collection of vscode extensions causes that but or if that is a general issue?
If the latter it might be worth implementing  something which catches this error
and then automatically restart the httpYac Rest client extension(?)
Anyway for now you can close this issue if you want.

I was able to recreate the behavior. I would still like to understand what is causing the error. Other extension are certainly not to blame at this point. I think it is rather a mishandling of the virtual workspace de on my part. The use of fspath is not allowed in this case. Why the call occurs anyway, I still have to check.

 Cause is the use of fsPath to have the correct file when running the script. Advantage is actually only that so in case of error the correct line is output.
I will go over all uses of fsPath once and re-evaluate again.

The cause was really the use of fsPath. In this case, however, the scheme would have been correctly file. I now simply catch the exception and use toString instead. This also works for the execution of the scripts.
But to fix the error in httpBook, I just need to update the extension vscode-httpyac. Therefore, do not be surprised if there is no new version:-)

Amazing to hear that you managed to reproduce it and fixed it so quickly ! Thanks a lot ;)
Can you already estimate when you plan to release the newest version of vscode-httpyac?
*No need to stress, just would like to provide that information when I introduce httpBook to my team.

I got distracted by my kids and forgot I need to draft the release of vscode-httpyac.  In about 10 minutes the update should arrive. Maybe let me know if it works for you.:-)

Just did a quick check, seems to work now :+1:

Amazing to hear that you managed to reproduce it and fixed it so quickly ! Thanks a lot ;)

I was lucky. I have a similar setup in my work and I was able to see the location in the 'uglified' code as well.

*No need to stress, just would like to provide that information when I introduce httpBook to my team.

Discovering and appreciating a tool for yourself is great. But showing it to others is even more praise. thx.


[Visual Editor] Cut/paste loses state of state

Description
Cutting and then pasting a state makes it lose its state.
Expected Result
A paste followed by a cut should recreate the originally cut state exactly.
Actual Result
The state of the state is lost.
Reproduction
https://stately.ai/registry/editor/60414bc8-3740-48e0-a223-b0bdd4575f79?machineId=a005dd2a-f6a0-4240-bade-5beec2654f42

Select state

Cut

Paste

Additional context
Mozilla Firefox 105.0.1 (64-bit) (on Fedora Silverblue)

Just been told this is the repo for the visualiser, not the visual editor (confusing) :) Please feel free to move it there.


New version: MoonchildProductions.PaleMoon version 33.0.0

Pull request has been created with komac v2.0.2 :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

(Automated response - build 694.)

Hi @BiosPlus,
The installation isn't unattended. Is there an installer switch to have the package install silently?
(Automated response - build 694.)

Hmm, the tests haven't re-run >_>

/AzurePipelines run


Set up Sphinx build

Some of the files need adjusting to work properly with Sphinx and
recommonmark. Major changes include:

Ensuring proper header levels throughout files which otherwise breaks
the TOC tree.
Converting tables to ReStructured Text inside eval_rst blocks, since
recommonmark doesn't support Markdown tables.

Preview at https://ibmi-oss-docs.readthedocs.io/en/latest


Validate inputs

So far the input validation checks:

That there are two RCPs and that they have labels rcp45 and rcp85 (assertion)
That there are 15 batches with labels batch0 - batch14 (assertion)
That the chunksize for batch is 15 (assertion)
That all of the chunksizes are exactly as we want them (warning)

In general, I have tried to design the validate_damages function to be pretty flexible so it should be easy to change what checks we run on the input damages.

This validation script requires very strict input damages, but we may want to generalize in the future. The package itself requires very particular dimensions for each object, so we may want the config to include the dimensions which would allow more flexible input files.

One more thing! Consider having an option to turn off hard, run-blocking validation in functions where you've hardcoded it. This is another thing that could help with testing or if the validation starts getting in the way for silly reasons.


Pass py3 tests

This is a start but let's both review it.

Sorry, I'm being messy.  :[

I guess the basic question is do we want more bytes or more Unicode? I didn't force any literals to Unicode yet so I should probably at least do that. Any other style preferences?

This was the thing we abandoned...  yes?


import Client from 'predicthq'

@sangramchauhan96 can you please provide more details on the issue you are facing? Thank you.

Closing this issue, please feel free to reopen if needed @sangramchauhan96. Thank you.


Increase slider speed

While playing fast songs such as Blackgold, I noticed I keep missing a couple of max slide bonuses or sometimes the next note due to the slide speed being slow for such a high tempo.

This is a very valid complaint. Personally I have not experienced any problems hitting slides at higher speed songs which is why I had thought the current speed to be well adjusted.
Because I feel like changing the speed now like this might throw some people off from what they are used to, I will add the ability to set the speed inside one of the config files shortly.

That's even better. Thanks for all the hard work 👍

I'm closing this due to b2eb6a3947d524c62990d3ff47498cb7f3491f78


[BUG] Extension doesn't support meta_effects

Describe the bug
When opening a focus tree with a meta_effect, the extension fails to load the tree.
To Reproduce
Steps to reproduce the behavior:

Add a meta_effect to a focus
Click on Preview HOI4 File
See error

Expected behavior
The focus tree works in the game, and I therefore think that it should load. This can easily be fixed by ignoring meta_effects.
Screenshots

Desktop (please complete the following information):

OS: Windows
VSCode version: 1.60.2
Extension version: 0.4.6

Console Logs

Thank you!

Okay, here it is:
completion_reward = {
	hidden_effect = {
		meta_effect = {
			text = {
				set_country_flag = [META_SET_RULING_PARTY]
			}
			META_SET_RULING_PARTY = "[meta_set_ruling_leader]"
		}
	}
}

Fixed in v0.4.7.


Updating API routes to match new DB schema

Closes #103
Closes #79
Also see #109
Updating API routes.md

Rebased onto schema_upgrade. No changes to tests included in this PR and the plan is to indeed fix them later.


Sending notifications when jobs fail.

Description
This PR exposes the BE functionality of sending notifications to desired channels (e.g. Slack) when jobs fail.
Checklist

[x] The documentation reflects the changes.
[x] The PR branch is set up to merge into dev instead of master.
[x] In case I changed one of the services’ models.py I have performed the appropriate database
migrations (refer to scripts/migration_manager.sh).
[x] In case I changed code in the orchest-sdk I followed its release
checklist
[x] In case I changed code in the orchest-cli I followed its release
checklist
[x] I haven't introduced breaking changes that would disrupt existing jobs, i.e. backwards
compatibility is maintained.
[x] In case I changed the dependencies in any requirements.in I have run pip-compile to update
the corresponding requirements.txt.

Currently, we are subscribing users to
 project:one-off-job:failed
 project:cron-job:run:failed

A one off job is registered as failed after all its pipeline runs have entered an end state, and there is at least 1 failed run.
A cron job is registered as failed only if, pretty much, fails to enter the STARTED state, which is something that happens after "confirming" the job from a draft.
We might want to subscribe users to the following events (along with the previous two):

project:one-off-job:pipeline-run:failed: a pipeline run of a job has failed, note that it implies that, if there are many runs that fail, many notifications will be delivered
project:cron-job:run:failed: a cron job run is a batch of pipeline runs created based on the cron job schedule. This event can be triggered in two different moments: if the BE is not able to queue the batch of pipeline runs, or if a pipeline run part of the batch fails
project:cron-job:run:pipeline-run:failed: a pipeline run has failed, note that it implies that, if there are many runs that fail, many notifications will be delivered

I am not entirely sure showing events in this raw form

About the webhook docs, which should probably decide who's doing what

Given the design, what happens if we have existing users with existing webhooks, and we decide to change what events we are subscribing users to by default? I think it implies either that we need to update existing webhooks in the database or that the view will have to change to accommodate for the fact that different webhooks might be subscribed to different events?

If you meant users who are already using the endpoints without GUI, indeed it's then not correctly presented in the UI.
I think, though, we have to allow user to select the events to subscribe before changing any default event types (then we could show a toggle per event).
And also, the list of webhooks in Notification settings would be app-wide, meaning that its subscriptions would be empty. We have to think about how to allow user subscribe to jobs with a specific UUID.

A one off job is registered as failed after all its pipeline runs have entered an end state, and there is at least 1 failed run.
A cron job is registered as failed only if, pretty much, fails to enter the STARTED state, which is something that happens after "confirming" the job from a draft.

I would argue that users are interested in getting notified whenever a pipeline run fails. Reasoning about the failure of an encapsulating one-off job or cronjob (meaning that it has many pipeline runs due to parameters) I don't think makes much sense. I would want to get a notification the moment something fails so that I can expect it and fix things.
Let's say you have two pipeline runs X and Y as part of a job, then X and Y could run the same code but on different data sources. In that case it is very important that both X and Y run, so the moment one fails we should notify the user.

project:cron-job:run:pipeline-run:failed: a pipeline run has failed, note that it implies that, if there are many runs that fail, many notifications will be delivered

This I like ^_^. We could later add an option where you can limit the number of notifications per job, if that is what users want.

I am not entirely sure showing events in this raw form

I totally agree. I would rather give them more appropriate names.

Overview of nitpicks/issues I encountered
1. Alignment is of banner is off
The text in the banner (in the jobs list view) is not vertically aligned in the center. Left side is too high and right side is too low.

2. Alternative text proposal for notification settings
I would change the text to: "Get notified about specific events in Orchest." The fact that we use webhooks is something they can see in the actual settings themselves.

3. Unclear "error" indication when testing webhook
I used https://webhook.site/ to quickly test out the TEST button when creating a webhook. The payload got successfully POST'ed but in our UI we show an :exclamation:. Not sure how to interpret it.

4. Icon alignment in webhooks table is off
After clicking the TEST in the Connection column I felt like the :white_check_mark: was not aligned properly (vertically speaking).

5. Connection column in webhooks table
In the above screenshot you can see that we offer a TEST functionality in the webhooks table. When I first saw this I immediately thought: "Why doesn't Orchest check it for me? Why do I have to press that button?"
In addition, after I pressed TEST and added another webhook the :white_check_mark: from the first test disappeared.
6. Unclear / Unconfigurable webhook events vs channels
From the UI it seems like every webhook will be subscribed to all events. I don't think this is a common use case though, I would expect different channels (if more than 1 at all) to be subscribed to different events. Why don't we allow what events a webhook channel is subscribed to? Moreover, then the channel should also show the events it is subscribed to.

7. Can't edit existing webhook
In the above screenshot you can see the table listing the webhook channels. How can I edit an existing webhook? I tried clicking on the row in the table but that didn't work. I would have liked to add a name.

@yannickperrenet

The text in the banner (in the jobs list view) is not vertically aligned in the center. Left side is too high and right side is too low.

I would change the text to: "Get notified about specific events in Orchest." The fact that we use webhooks is something they can see in the actual settings themselves.

Changed accordingly.

I used https://webhook.site/ to quickly test out the TEST button when creating a webhook. The payload got successfully POST'ed but in our UI we show an ❗. Not sure how to interpret it.

You probably were testing an older commit. @fruttasecca helped out with a new endpoint a bit later. I just tested with https://webhook.site/ and it works.

After clicking the TEST in the Connection column I felt like the ✅ was not aligned properly (vertically speaking).

Could you share which browser you're using? I couldn't reproduce it on Safari, Chrome, and Brave on Mac.

In the above screenshot you can see that we offer a TEST functionality in the webhooks table. When I first saw this I immediately thought: "Why doesn't Orchest check it for me? Why do I have to press that button?"

Note that this "test" is a POST request that sends an actual notification, not a silent GET health check. It'd be better letting user fire it for testing instead of firing unsolicited notifications every time this view is rendered.

From the UI it seems like every webhook will be subscribed to all events. I don't think this is a common use case though, I would expect different channels (if more than 1 at all) to be subscribed to different events. Why don't we allow what events a webhook channel is subscribed to? Moreover, then the channel should also show the events it is subscribed to.

In the above screenshot you can see the table listing the webhook channels. How can I edit an existing webhook? I tried clicking on the row in the table but that didn't work. I would have liked to add a name.

AFAIK the agreed scope of this PR is a MVP: send notifications when job runs fail. I think the said scenarios are 100% valid, but design and endpoints are not yet in place (POST, GET, but no PUT).

In addition, after I pressed TEST and added another webhook the ✅ from the first test disappeared.

Fixed 🙂

Would it make sense to change the Events title in the notifications settings to Subscribed events?
To me Events feels like a list of all possible events and not perse "events that I subscribed to". Given that the dialog for setting up a webhook doesn't allow for configuration of events, I think we should make clear that all events are automatically subscribed to.

Would it make sense to change the Events title in the notifications settings to Subscribed events?

It makes more sense when the table headings + switches are there...

These switches can appear disabled for the MVP

It might be cleaner to structure events like this

Setting an invalid URL is not handled correctly, as a user I am allowed to save it, the request will fail and the FE will show an entry regardles.

Setting an invalid URL is not handled correctly, as a user I am allowed to save it, the POST request to the BE will fail and the FE will show an entry regardless.

I intentionally made it so. Orchest could not be hold responsible for ensuring the receiver service is active. Even if the TEST is passing while user is creating a webhook in the dialog, the integration could still fail anytime.

@ncspost
I've addressed your feedback as much as possible. Some questions about the remainders:

Why do we need to capticalize webhook? I think it's a common noun, not something like "Internet". See wekipedia for example.
I couldn't reproduce the functionality failures that you encountered. Could you deploy the latest commit and try again? It could be that you were testing on an old commit 🙂

Switches should be off and disabled until a webhook is created

Switches should be off and disabled until a webhook is created

Fixed.


resource_create_op operation can cause TensorFlow to crash.

Issue type
Bug
Have you reproduced the bug with TensorFlow Nightly?
Yes
Source
source
TensorFlow version
tf-nightly 2.18.0.dev20240817
Custom code
Yes
OS platform and distribution
Ubuntu 20.04.3 LTS (x86_64)
Mobile device
No response
Python version
No response
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
A Segmentation fault  could be raised in TensorFlow when using test_ops.resource_create_op . The code is as follows:
Standalone code to reproduce the issue
import tensorflow as tf
sess = tf.compat.v1.Session()

@tf.function
def func():
    r1 = test_ops.stub_resource_handle_op(container='a', shared_name='b')
    r2 = test_ops.stub_resource_handle_op(container='a', shared_name='c')
    c = array_ops_stack.stack([r1, r2])
    s = array_ops.strided_slice(c, [1], [2 ** 32])
    with sess.as_default():
        test_ops.resource_create_op(s)

func()

Relevant log output
> Segmentation fault (core dumped)

The above code is confirmed to crash on `tf-nightly 2.18.0.dev20240817` (nightly-build)

Hi @Justobe ,
Sorry for the dealy, I reproduced the code shared but facing different error. Could you please share the colab gist with all the dependencies to analyze more of it.
Thank you!

Sorry for the missing dependencies. I’ve updated the code, and the colab gist can be found here.

I tried to run your code on Colab using TF v2.17.0, nightly and faced the same issue. Please find the gist here for reference. Thank you!


Ignite2018

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/enterprise/overview.md
:white_check_mark:Succeeded

docs/images/blue-clock-20x20.png
:white_check_mark:Succeeded

docs/images/blue-globe-20x20.png
:white_check_mark:Succeeded

docs/images/blue-screwdriver_and_wrench-20x20.png
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


No mention of Azure Table Storage

Should Azure Table Storage get a mention here?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a6a2dd11-b2f0-7821-a877-fc09af4ac967
Version Independent ID: f7537dfd-5472-f0d2-d344-db85fd65bf71
Content: Choose the right data store - Azure Application Architecture Guide
Content Source: docs/guide/technology-choices/data-store-overview.md
Service: architecture-center
Sub-service: reference-architecture
GitHub Login: @MikeWasson
Microsoft Alias: pnp

Thanks for reporting - this issue is under review.  This is a Microsoft Internal DevOps Bug ID AB#242903

@MagicBulletDave the CosmosDB links actually point to the CosmosDB Table API.  There are subtle difference between Table Storage and this API as called out here

Proceeding to close per previous comment.


Create docs README regarding the RealDebrid

Description
As a maintainer, I would like to add a short description about RealDebrid service under streaming_providers/realdebrid/README.md  Also add the referral link

i would like to work on this issue,Could you assign me this.


voxblox_skeleton_planner/skeleton does not appear in rviz because edge point is empty

I was running the skeleton planner and everything is fine except the skeleton diagram points. First of all, they are published as pointcloud points in ROS but no actual message is passed.
I debugged further and noticed that skeleton_generator_.getSkeleton().getEdgePoints() is empty.
Then I checked void SkeletonGenerator::updateSkeletonFromLayer() and found no skeleton point is classified as either edge or vertex.
Initially I thought it is because my generated skeleton map is wrong. So I used the rs_skeleton_0.10.voxblox and found the result to be the same. So I wonder why skeleton_layer couldn't read or get the edge points from the map?
Thank you.

I figured it out :
In SkeletonGenerator::updateSkeletonFromLayer()
// if (!skeleton_voxel.is_face) {
//   continue;
// }
you have to comment this code so you can see generated points

Thanks for your solution a lot!


Support of RDF / SPARQL

Hey guys,
I'm very grateful for this awesome open source project!
Right now I'm desperately looking for a triplestore, where I can import the wikidata dump.
My Team and me want to create a social network based on semantic technology. For this we need a scalable solution. Unfortunately almost every RDF triplestore is commercial and the license for 1 machine is about 10.000$ / year -.-
Is there any workaround to use RDF and SPARQL in OrientDB?

To the question, is it possible to store wikipedia data as a graph within ODB? The answer is...absolutely. However, you won't be able to query the data with SPARQL (which you already knew). You can, however, use ODB's own SQL-like query language to query for your data. ODB's query language, due to the nature of ODB, is actually more capable than SPARQL and thus, ODB can do more for you in general.
This little (and cool) example shows the possibilities.
http://gog.orientdb.com/index.html?utm_source=site&utm_medium=website&utm_campaign=Game+of+Graphs
Scott

We support SPARQL through the TinkerPop layer ;-)

Hmm...interesting. But wouldn't it be much better just to use ODB's SQL? I mean, using SPARQL though a compiler to Gremlin is to me, at best, like a workaround. I'd personally never contemplate building an application over that many "abstractions".
Or does SPARQL bring some sort of major advantage with it, that can't be done with ODB's own SQL? I'll admit, I am not knowledgeable about SPARQL at all.
Scott

I'm not a fan of SPARQL either, but if you feel comfortable with it, there is a way. Anyway for performance reasons, I suggest to always use OrientDB SQL.

@smolinari, one major advantage of SPARQL is that it is a standard, like SQL is.
Of course it is not so well known and accepted like SQL.
But IMHO standard, if crafted well, can bring benefits that specific implementations cannot provide.
Enough to say... without SQL being a standard RDBMS would not be so popular and so mature today. Without HTTP and TCP/IP being standards we would not have Internet today.

@andrzejmartyna The best would be providing a SPARQL parser that translates to OrientDB SQL, so all the optimizations would be already there. Also, it would be nice providing an importer for OWL and the support of other "semantic" technologies, but unless we find a sponsor or a partner for it, it cannot be done in the short-medium term. Sorry.

@lvca, thanks for fast answer. Yes, it would be awesome to have these functions.
But IMHO it is not a must. Semantic technologies still need a few years (or more) to "stabilize".
More important is to provide quality, stable technologies to make it possible to go to production more and more frequently.
Meanwhile we should observe standardization efforts of W3C and acceptance of SPARQL in IT.
Best regards!


Export Godot mobile

Tested versions
4.2 stable
System information
Mobile - Godot 4.2 stable
Issue description
The error occurs when I try to export a game to the web or apk, the export button goes too far below the limit of the cell phone screen And you can't see or touch it.

Steps to reproduce
.
Minimal reproduction project (MRP)
.

Duplicate of https://github.com/godotengine/godot/issues/73130


[DEPRECATE] getWithDefault

With Ember 3.21 the getWithDefault function is now deprecated.

This should have been fixed with release 1.9.1
https://github.com/poteto/ember-cli-flash/pull/326
What version of ember-cli-flash are you on?

This should have been fixed with release 1.9.1
https://github.com/poteto/ember-cli-flash/pull/326
What version of ember-cli-flash are you on?


[release-2.8] upgrade golang/x/net to 0.17.0

[ ] I added CHANGELOG entry for this change.
[ ] Change is not relevant to the end user.

Changes

Verification

/lgtm


Is there a way to use google.maps.Point?

Hello there, I have a doubt about using marker Point anchor, Im using SVG path and the position is more for the right/bottom. the default icon is like bottom/center.

Found a solution, on icon object, use:
anchor {   x: 100,   y: 100 }
it will change icon's position, can close the issue.


Update solution-dev-test-environments.md

Update the article to match the ARM template, which was updated in March

Hi @sryabkov, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

I suggest that this PR be used instead of #7259.
I have tested the changes.

I don't know if I can get the CLA signed. If you can't waive the CLA requirement, feel free to copy/paste the changes and close this PR w/o merge. Or use #7259, it does not require a CLA.

@sryabkov - thanks for suggesting this change. Unfortunately, we can't waive the CLA. I will make sure your suggestions are addressed when updating the topic.
I am not able to close the PR. Can you close it?

@tfitzmac Thank you.


subprocess.CalledProcessError: Command '['tune2fs', '-U', 'random', '/dev/loop5p2']' returned non-zero exit status 1

Just seen again here:
https://github.com/pmem/run_qemu/pull/80#issuecomment-2540265794
PS: avoid screenshots, they're not indexed and not accessible:
https://docs.zephyrproject.org/latest/develop/getting_started/index.html#use-copy-paste
‣ Running second (final) stage…
‣  Basing off cached image root.img.cache-pre-inst
‣  Copied cached image as /home/runner/work/run_qemu/run_qemu/kernel/qbuild/.mkosi-ge6d__zg
‣  Refreshing partition table…
Partition #1 contains a vfat signature.
Partition #2 contains a ext4 signature.
‣  Refreshed partition table.
‣  Attaching /home/runner/work/run_qemu/run_qemu/kernel/qbuild/.mkosi-ge6d__zg as loopback…
‣  Attached /dev/loop3
‣  Refreshing file system /dev/loop3p2…
tune2fs 1.46.5 (30-Dec-2021)
This operation requires a freshly checked filesystem.
Please run e2fsck -f on the filesystem.
‣  (Detaching /dev/loop3)


loki.process --> stage.json, stage.logfmt - extract all label:value pairs without explicit expression

Request
At the moment in Grafana alloy 1.5.0 and loki.process -> stage.json needs an "expression" and stage.logfmt needs a "mapping".
all these stages make it mandatory to always know all of the label:value pairs which may appear in a log line.
On the other hand in Grafana Explore we have line filter "JSON" and "LOGFMT" and with one click all json formatted parts are correctly listed in label:value.
I would like to see a similar option in loki.process stages:
1.) I would like to be able to configures a specific set of labels I want to extract (as it is now)
2.) I would like to be able to extract all possible labels except the list I define (opposite of now.)
3.) I would like to be able to extract all possible labels.
I would like to see this for JSON and LOGFMT - maybe others are possible, too.
For following stages like "stage.labels" or "stage.struchtured_metadata" I would like to be able to do similar thing:
1.) create struchtured_metadata for all previous extracted labels
2.) create struchtured_metadata for all previous extracted labels except the list I configure
3.) create structured_metadata for a set of previous extracted labels
Use case
This would simplify and shorten the alloy config files. If I want to extract 10 labels of a json logline I have to add 10 stage.json label:value pairs.
Next step is to add 8 out of 10 of these values to stage.structured_metadata.
If I have a stage.match and I want to match the log lines based on the process/service, then I have to do these stages and labels for all services.
In my example I have the following applications:
alloy, mimir, loki, tempo, grafana, prometheus, blackbox_exporter, smokeping_prober, snmp_exporter
All these applications log to /var/log/messages,.
I create a stage.regex and parse the process and the log message which is logfmt.
I create several stage.match for
process=alloy
process=mimir
process=loki
process=tempo
...
I create stage.logfmt for every process to extract always the same parts (ts, msg, level, component, component_id, trace_id, ..) and there are several more fields I do not know because they may only appear in e.g. debug or info level mode.
after I extracted all these 10.20 fields I create stage.structured_metadata for 17 out of 20 labels.
Every stage.match gets it's own service_name label.
If I could use:
stage.json {
    expressions = { ".*" }
}

I would extract everything which is formatted as json in the logline. if new parts appear or new software version adds new field I do not have to modify it.
// This would use als stage.json label_value pairs except "ts" and "msg"
stage.structured_metadata {
    values_exclude = {
      ts  = "",
      msg = "",
    }
}

// This would only use the selected labels "ts" and "msg"
stage.structured_metadata {
    values = {
      ts  = "",
      msg = "",
    }
}

// this will include all stage.json labels in struchtured_metadata
stage.structured_metadata {
    values = {
      .*  = ".*",
    }
}

I don't know if this is usefull for "stage.labels" as we should avoid high labels count - however this may be up to the user.

maybe somehow related to this or can be included:
https://github.com/grafana/loki/pull/15188

related: https://github.com/grafana/alloy/issues/926


"if you don't" path on Sanskrit (age 11) doesn't work

No cards were transferred

Can I see a screenshot of the log?

I don't have the game up anymore, but I can try to recreate it.

The "for each player" text isn't being applied.  The player only is given a single selection.  However even after making a card selection it doesn't transfer the other top cards.


abseil-cpp: upgrade to 20240116.0, opentelemetry-cpp: upgrade to 1.14.2, nginx: upgrade to 1.25.4

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

[X] The toolchain has been rebuilt successfully (or no changes were made to it)
[X] The toolchain/worker package manifests are up-to-date
[X] Any updated packages successfully build (or no packages were changed)
[X] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
[X] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
[X] All package sources are available
[X] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
[X] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
[X] All source files have up-to-date hashes in the *.signatures.json files
[X] sudo make go-tidy-all and sudo make go-test-coverage pass
[X] Documentation has been updated to match any changes to the build system
[X] Ready to merge

Summary

[What does the PR accomplish, why was it needed?
abseil-cpp: upgrade to 20240116.0, opentelemetry-cpp: upgrade to 1.14.2, nginx: upgrade to 1.25.4
Change Log

Upgrade abseil-cpp to 20240116.0 (for opentelemetry + it was failing tests on previous version)
Add testing libraries for abseil-cpp, so it will pass the new version tests
Bump releases for grpc, re2, protobuf and protobuf-c because of new abseil-cpp version
Upgrade opentelemetry-cpp to 1.14.2 (added abseil-cpp dependency)
Upgrade nginx to 1.25.4 and njs_version to 0.8.3
Move nginx to pcre2
Remove opentelemetry-cpp-contrib as we don't need it anymore with the new versions

Does this affect the toolchain?

NO
Test Methodology

Package build buddy build 535434

Buddy builds for install package are not reliable, testing using containerized build:

x86_64 installing packages:

x86_64 installed packages:

Package build after changes:
https://dev.azure.com/mariner-org/mariner/_build/results?buildId=536772&view=results


GenericTransactionManagerLookup should fall back to an embedded JBossTM ...

...instance before falling back to the DummyTM
https://issues.jboss.org/browse/ISPN-1795

Looks ok-ish, testing..

One doubt.. it seems clear from this code that we depend on having the JBoss TM (at least the embedded one) on the classpath.
Shall I open an issue to add tests against this ? I think it should be possible to use Infinispan Core without that TXM as a hard dependency.

merged, after adding the reference to the issue and removing unneeded whitespace changes.


IssueID:1859:new watchdog driver framework

[Detail]
New watchdog driver framework.
New VFS support.
Userspace support.
[Verified Cases]
Build Pass: helloworld_demo@haaseduk1
Test Pass: helloworld_demo@haaseduk1

感谢提交 Pull Requests！
Thanks for submitting a pull request.

Security Check : 15bfd333e6f2aa43a890a929282f15ba733583ce

auto build success,number:244

autotest fail,number:1770


Add a Gitter chat badge to README.md

nguerrera/corefx now has a Chat Room on Gitter
@davkean has just created a chat room. You can visit it here: https://gitter.im/nguerrera/corefx.
This pull-request adds this badge to your README.md:

If my aim is a little off, please let me know.
Happy chatting.
PS: Click here if you would prefer not to receive automatic pull-requests from Gitter in future.

Ignore this, was playing around with creating rooms.


Multiple Kinect from different angle?

Can it support multiple cameras shooting from different angle, and merge the skeletons like "OpenPTrack v2 with Pose"?
Thanks in advance!

Not yet, but we are working on it.
We can already align multiple Azure kinects with an OpenCV Charuco pattern, and with further fine-tuning (by running ICP) we get a pretty decent spatial alignment.
The next step would be to merge the body tracking data from the different skeletons. Note that Azure Kinect body tracking requires a fast GPU. If you want to use multiple Kinects, you will need to use a fast PC, multiple GPUs, or multiple PCs. We have been thinking about introducing a server/client model for the MMH to send tracking information from multiple MMH clients to an MMH server that merges the Azure tracking data. I think the earliest date for a release of the merging of Azure Kinect tracking data, like OpenPTrack does, could be at the beginning next year.
The code for spatial camera aligbment has not been released yet, but it will be merged to the master in the next few weeks or months.


Initializing TradingAlgorithm Object Does Not Set _analyze Method in algorithm.py

The following code does not call the passed analyze function when trying to work directly/manually with zipline (i.e. not from ipython or command line)
import pytz
from zipline.api import order, record, symbol, history, add_history, order_target
from datetime import datetime
from zipline.algorithm import TradingAlgorithm
from zipline.utils.factory import load_bars_from_yahoo

start = datetime(2000, 1, 1, 0, 0, 0, 0, pytz.utc)
end = datetime(2001, 1, 1, 0, 0, 0, 0, pytz.utc)
data = load_bars_from_yahoo(stocks=['AAPL'],start=start, end=end)

def initialize(context):
   pass

def handle_data(context, data):
    order(symbol('AAPL'), 10)
    record(APPL=data[symbol('AAPL')].price)

def analyze(context, perf):
   print(perf.head())

algo_obj = TradingAlgorithm(initialize=initialize, handle_data=handle_data, analyze=analyze)
perf= algo_obj.run(data)

I think it can be fixed by updating the algorithm.py file with the last line of the following code.
elif kwargs.get('initialize', False) and kwargs.get('handle_data'):
            if self.algoscript is not None:
                raise ValueError('You can not set script and \
                initialize/handle_data.')
            self._initialize = kwargs.pop('initialize')
            self._handle_data = kwargs.pop('handle_data')
            self._analyze = kwargs.pop('analyze', None)

I'd update the code and submit a pull request, but I'm not 100% if it's an issue.

@elmq0022 That fix makes sense to me - want to open a PR?
I suggest adding that new analyze line after we set self._before_trading_start, just for consistency with the previous if block.

@richafrank Thanks for the feedback and the suggested placement for consistency.  I'll submit a pull request sometime this weekend.

Sounds great!

Fixed with #819.


Allow policy-based serialization

An explicit Policy parameter allows to customize serialization of types
without having to modify them, which is useful if the types are supplied
by a library or if different serializations are needed.
The PR is not ready yet, needing documentation and tests, but it's working, so I would like some feedback.
An usage example (that pushed me to write the code) is serializing objects synthesized by dproto, which can be done with such a policy:
template BufferPolicy(Buf) if (__traits(compiles, Buf.init == Buf.init.opGet))
{
    auto toRepresentation(Buf b) {
        return b.opGet;
    }
    Buf fromRepresentation(typeof(Buf.init.opGet) v){
        Buf b;
        b = v;
        return b;
    }
}

which transforms the serialized form from:
{"fieldname":{"opGet":"fieldvalue"}}

to
{"fieldname": "fieldvalue"}

(Actually, serializing dproto objects without a custom policy fails, due to https://issues.dlang.org/show_bug.cgi?id=12363 ; but it would look like the former if it worked)
I also would have liked to add a template parameter (defaulted to DefaultPolicy) to serialize and deserialize, but I don't think it can be done without breaking some existing code.
It should be possible to compose policies with something like
template CompositePolicy(T)
{
	static if (isPolicySerializable!(FirstPolicy, T))
	{
		alias toRepresentation = FirstPolicy!T.toRepresentation;
		alias fromRepresentation = FirstPolicy!T.fromRepresentation;
	} else {
		alias toRepresentation = FallbackPolicy!T.toRepresentation;
		alias fromRepresentation = FallbackPolicy!T.fromRepresentation;
	}
}

but I still have to work on it, and I wonder if it would be possible to create a general policy composer.

I like this a lot and it would also be able to handle some of the more specific serialization needs that came up in the past. I'll have to allocate some more time to look at the details of the interface in the next days.

Hi Ludwig,
did you have the chance to look at this?

Took the time now finally and all looks good! This is a nice concept for later extension, too (e.g. adding an UDA for customizing fields or maybe supporting more ways to customize the output within the Policy).


Parser Filter Bug Fix

Required items, please complete
Change(s):

Fixed Parser Filter. Before it wasn't filtering dates well,

Reason for Change(s):

Before it wasn't filtering dates well,

Version Updated:

NA

Testing Completed:

Yes

Checked that the validations are passing and have addressed any issues that are present:

Yes

@vakohl : we wanted to push this important fix to production, so I updated the change I requested myself.

@vakohl : we wanted to push this important fix to production, so I updated the change I requested myself.

sounds good. thankyou Ofer!


Animate time in BDV windows with navigation events.

Our attempts did not result in something good.
The animation becomes super berserk if there are several views linked together.
We probably miss a more complex animation behavior.


Can you please update the license of the repository?

Hi, thanks for the great work. Can you please update the license of this repository so that other people can try out your work? Thanks a lot!

done


Add Turkish translation

@Anaxilaus
Thanks for doing this. Any chance you can fix one line?
rateNormal: 'Normal',

Just adjust the 'Normal' to Turkish - thanks.

@hawkeye64
There's no error, normal is same in Turkish. Etymologically coming from French.

@Anaxilaus Well, it got me for sure. :) Will be merging it in before the next release. If you want, you can add yourself to the Completed Languages here.

Thanks again for providing this. You rock! :heart:


Mw/ref join

Summary
-Added reference data annotations to seqr loading pipeline which should allow for end to end runs. Tested full runs of SeqrVCFToMTTask locally and on the cloud. Spot checked results but will complete more thorough testing once reference schema is created.
Changes
-Added the gold_star annotations to the write_clinvar_ht script and ran it. https://console.cloud.google.com/dataproc/jobs/a85d98ed6a334547959e3a51760a9c98?project=seqr-project&organizationId=548622027621&supportedpurview=project&region=global&duration=P4D
-Updated ES port parameter from a string to an int
-Removed unnecessary 'AD' field from gnomad genome coverage reference field selection
-Added all reference data annotations to seqr_mt_schema includes: cadd, dbnsfp, eigen, gnomad_exomes, gnomad_exomes_coverage, gnomad_genomes, gnomad_genomes_coverage, g1k, mpc, primate_ai, splice_ai, topmed, hgmd, clinvar
To Do
-Create unit tests for new schema additions
-Create reference schema and validate

Thanks, I've added the ref tests to Asana. All fields match the VDS output.


Fix additional regressions in master

This fixes another set of regressions in master.  Specifically, the following.

Remove VS Code default themes
"Add Connection" button isn't displaying correctly in Server viewlet on first launch
Use flat icons in activity bar for VS Code viewlets
Change Jan to Feb in 1st launch popup

This fixes a handful of regressions.  Merging to include in tonight's Feb. Insiders test build


Fix deprecation comment

Commit https://github.com/docker/swarmkit/commit/a3eac7370f744e4273bef620a357c6363dae3b5f#diff-2d262053827f7ee9d77859975113953cR62 (https://github.com/docker/swarmkit/pull/2385) renamed LbAttachments to Attachments, but did not update this deprecation comment.
ping @stevvooe PTAL

LGTM


uTinyRipper script and shader export issue

uTinyRipper simply doesn't export script and shaders. I have to add scripts manually using dnSpy, but there's no way to import shaders.

It export scripts data, if you include Managed folder in the list of processing files.
It export shader assets, but doesn't convert them to shader lab.


Fix T.self_type in body of method

Fix T.self_type in body of method

Add failing test case
Fix failing test
Update outdated test cases

Motivation
#5631
Test plan
See included automated tests.

Hey, thanks for the contribution. This is a somewhat sensitive change and will need a careful review. I won't have time to do that this week but I can look into it next week.

Hey, thanks for the contribution. This is a somewhat sensitive change and will need a careful review. I won't have time to do that this week but I can look into it next week.

Hi, thanks for the heads up.
Yes - I have no idea what I'm doing, probably best to treat this as an exploration of a way forward more than a polished solution. That said, all test still pass 😉
I think it's a shame that tap and then are untyped currently, and hoping we can take this to a good place - in due time. Ping me anytime if you'd like to discuss it more, I've also joined your Slack.

I have a WIP (with failing tests) for 5632 here, I think it shows that the replacement in environment.cc happens at the wrong time since it picks up the wrong enclosing class. When you find time, do you have a recommendation for where I could try moving it instead?


PLANNER-2648: Remove workaround for https://github.com/quarkusio/quarkus/issues/13341

mvn package -Dnative -DskipTests compiles successfully to a native executable, and uses the correct JDBC URL to connect to a remote H2 database.
Several use-cases already did not have the workaround, hence why they don't appear in the change list.

JIRA

https://issues.redhat.com/browse/PLANNER-2648
Referenced pull requests

How to retest this PR or trigger a specific build:

for a pull request build please add comment: Jenkins retest this
for a full downstream build please add the label run_fdb
for a specific pull request build please add comment: Jenkins (re)run [optaplanner-quickstarts] tests
for a Quarkus LTS check please add comment: Jenkins run LTS
for a specific Quarkus LTS check please add comment: Jenkins (re)run [optaplanner-quickstarts] LTS
for a Native check please add comment: Jenkins run native
for a specific Native LTS check please add comment: Jenkins (re)run [optaplanner-quickstarts] native

Thanks Chris!


Header section (Templatepgae)

User Story 1: Header Section
Description:
As a user, I want a clear header section with a logo, user profile, title, a switch, and a search bar, so I can easily navigate the website and switch between template and session pages.
Acceptance Criteria:

Header Structure:

The header section is divided into 3 levels:

Level 1: Logo and user profile
Level 2: Title
Level 3: Switch (template page & session page) and search bar

Functionality:

Switch: Clicking on the switch should navigate to the respective page (template or session page).
Search Bar: The search bar should only search within the current page the user is on.

Design and Layout:

The header section is designed as a complete component with auto-layout, and spacing can be referenced in Figma's DEV mode.
The header section should be responsive to different screen sizes.
All components should be available in both light and dark mode, and for both desktop and mobile.
There are specific states and a German version in the design.

User Story 2: User Menu
Description:
As a user, I want a user menu with a restricted settings dialog that shows the sections: Board Settings, Appearance, and Profile, along with a logout function, so I can manage my profile settings and log out securely.
Acceptance Criteria:

User Menu:

Clicking on the user menu should open the settings dialog.
The settings dialog includes the sections: Board Settings, Appearance, and Profile.
By default, the 'Profile' settings section should be displayed.

Logout Function:

A logout button should be displayed at the bottom left corner of the dialog window.
Clicking the logout button should redirect the user to the login screen.
The logout function should always remain in the same position in the settings dialog.

Design and Layout:

The settings dialog and logout function are components with auto-layout in Figma and can be referenced in DEV mode.
Support light and dark modes.
Support both desktop and mobile.
Integrate existing design guidelines from Figma.

For the Search Bar, I'll wait until there's actual content that can be searched for before implementation, but should be easy enough to add afterwards.