Kernel immediately ends on Pop_OS

I'm on Pop_OS and I cannot run .NET Interactive Notebooks. When I try to create a new notebook, the kernel will start and then immediately end.
I did a fresh install of the OS, then I installed the dotnet SDK, VS Code, and the .Net Interactive Notebook extension, and that's it. I try to create a new blank notebook and the server starts, then stops with an error. I'm pasting that console output below:
`Starting kernel for 'untitled:Untitled-1.dib?dotnet-interactive' using: dotnet tool run dotnet-interactive -- [vscode] stdio --working-dir /home/calebjacobo/Downloads
Kernel for 'untitled:Untitled-1.dib?dotnet-interactive' started (10299).
kernel (10299) stderr: Unhandled exception:
kernel (10299) stderr: System.IO.FileNotFoundException: Could not load file or assembly 'System.Management.Automation, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified.
File name: 'System.Management.Automation, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
at Microsoft.DotNet.Interactive.PowerShell.PowerShellKernel..ctor()
at Microsoft.DotNet.Interactive.App.CommandLine.CommandLineParser.CreateKernel(String defaultKernelName, FrontendEnvironment frontendEnvironment, StartupOptions startupOptions) in D:\a_work\1\s\src\dotnet-interactive\CommandLine\CommandLineParser.cs:line 466
at Microsoft.DotNet.Interactive.App.CommandLine.CommandLineParser.<>c__DisplayClass5_0.<b__19>d.MoveNext() in D:\a_work\1\s\src\dotnet-interactive\CommandLine\CommandLineParser.cs:line 311
--- End of stack trace from previous location ---
at System.CommandLine.NamingConventionBinder.CommandHandler.GetExitCodeAsync(Object returnValue, InvocationContext context)
at System.CommandLine.NamingConventionBinder.ModelBindingCommandHandler.InvokeAsync(InvocationContext context)
at System.CommandLine.Invocation.InvocationPipeline.<>c__DisplayClass4_0.<b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass17_0.<b__0>d.MoveNext()
--- End of stack trace from previous location ---
at Microsoft.DotNet.Interactive.App.CommandLine.CommandLineParser.<>c__DisplayClass5_0.<b__2>d.MoveNext() in D:\a_work\1\s\src\dotnet-interactive\CommandLine\CommandLineParser.cs:line 162
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass12_0.<b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass22_0.<b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass19_0.<b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<b__18_0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass16_0.<b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<b__5_0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass8_0.<b__0>d.MoveNext()`
Here is my SDK info:
.NET SDK (reflecting any global.json):
Version: 6.0.109
Commit: 58a93139d8
Runtime Environment:
OS Name: pop
OS Version: 22.04
OS Platform: Linux
RID: ubuntu.22.04-x64
Base Path: /usr/lib/dotnet/dotnet6-6.0.109/sdk/6.0.109/
global.json file:
Not found
Host:
Version: 6.0.9
Architecture: x64
Commit: 163a63591c
.NET SDKs installed:
6.0.109 [/usr/lib/dotnet/dotnet6-6.0.109/sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 6.0.9 [/usr/lib/dotnet/dotnet6-6.0.109/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 6.0.9 [/usr/lib/dotnet/dotnet6-6.0.109/shared/Microsoft.NETCore.App]
Download .NET:
https://aka.ms/dotnet-download
Learn about .NET Runtimes and SDKs:
https://aka.ms/dotnet/runtimes-sdk-info
VS Code info:
Version: 1.71.2
Commit: 74b1f979648cc44d385a2286793c226e611f59e7
Date: 2022-09-14T21:12:14.256Z
Electron: 19.0.12
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: <IP_ADDRESS>-electron.0
OS: Linux x64 5.18.10-76051810-generic
Sandboxed: No
Extension info:
Name: .NET Interactive Notebooks
Id: ms-dotnettools.dotnet-interactive-vscode
Description: .NET Interactive Notebooks for VS Code. Git SHA https://github.com/dotnet/interactive/commit/ff15cb3ae196f03a73d8e158908371b561058c3f
Version: 1.0.3452020
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-dotnettools.dotnet-interactive-vscode

Is this a permissions thing? I tried the same thing on my MacBook and when I created the notebook, it asked me for promisión to access the downloads folder. Is this simply a matter of granting the right permissions, and if so, how?

I don't know. That's possible.
Another possibility is that the TFM isn't supported by the System.Management.Automation (aka PowerShell) package. If you create a simple console app referencing this package, instantiate some type from it, and build and run it, do you see a similar error?

@jonsequitur sorry, I’m unsure how to do this.

@jonsequitur
Ok, I made a simple console app, then tried to print out something from System.Management.Automation and I got the same kind of error:
`Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'System.Management.Automation, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified.
File name: 'System.Management.Automation, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'`
So it seems like your assumption could be correct. What is the TFM?

TFM is the target framework moniker. Assemblies are often found inside TFM-specific subfolders in a NuGet package and I'm guessing from the outcome of your experiment that on Pop_OS it's looking for a TFM-specific subfolder which doesn't exist. (The only one I see is net6.0)

@daxian-dbw Any insights here?

No, no idea what was happening. The 7.2.6 version of PowerShell SDK targets net6.0, and dotnet-interactive should've bundled everything already.

I'm also experiencing this on Pop!_OS
VS code ext version: v1.0.3519061
dotnet sdk check
.NET SDKs:
Version      Status
------------------------
6.0.110      Up to date.

Try out the newest .NET SDK features with .NET 7.0.100-rc.2.22477.23.

.NET Runtimes:
Name                          Version      Status
------------------------------------------------------
Microsoft.AspNetCore.App      6.0.10       Up to date.
Microsoft.NETCore.App         6.0.10       Up to date.

dotnet-interactive version: 1.0.350406+612aa40cba7d6a1f734272f71657a65561394752

I tried to see if I could capture where it's looking (when running dotnet-interactive stdio for example)  as the exception message doesn't provide much more detail.
inotifywatch -r /home/sadbooth/.nuget
Establishing watches...
Finished establishing watches, now collecting statistics.
total  access  close_nowrite  open  filename
4      2       1              1     /home/sadbooth/.nuget/packages/system.management.automation/7.2.7/runtimes/
4      2       1              1     /home/sadbooth/.nuget/packages/system.management.automation/7.2.7/

Not very useful :shrug:
Here's the file tree for that path:
/home/sadbooth/.nuget/packages/system.management.automation
└── 7.2.7
    ├── _manifest
    │   └── spdx_2.2
    │       ├── manifest.spdx.json
    │       └── manifest.spdx.json.sha256
    ├── Powershell_black_64.png
    ├── ref
    │   └── net6.0
    │       ├── System.Management.Automation.dll
    │       └── System.Management.Automation.xml
    ├── runtimes
    │   ├── unix
    │   │   └── lib
    │   │       └── net6.0
    │   │           └── System.Management.Automation.dll
    │   └── win
    │       └── lib
    │           └── net6.0
    │               └── System.Management.Automation.dll
    ├── system.management.automation.7.2.7.nupkg
    ├── system.management.automation.7.2.7.nupkg.sha512
    └── system.management.automation.nuspec

12 directories, 10 files

Then I tried running the same command with strace - log

I'm also seeing this on PopOS when trying to use dotnet interactive or the Polyglot Notebooks plugin in VS Code.
dotnet info:
➜ dotnet --info
.NET SDK:
 Version:   7.0.107
 Commit:    bf72c06963

Runtime Environment:
 OS Name:     pop
 OS Version:  22.04
 OS Platform: Linux
 RID:         ubuntu.22.04-x64
 Base Path:   /usr/lib/dotnet/sdk/7.0.107/

Host:
  Version:      7.0.7
  Architecture: x64
  Commit:       5b20af47d9

.NET SDKs installed:
  7.0.107 [/usr/lib/dotnet/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 7.0.7 [/usr/lib/dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 7.0.7 [/usr/lib/dotnet/shared/Microsoft.NETCore.App]

Other architectures found:
  None

Environment variables:
  Not set

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

Error:
➜ dotnet interactive stdio
Unhandled exception: System.TypeInitializationException: The type initializer for 'Microsoft.DotNet.Interactive.PowerShell.PowerShellKernel' threw an exception.
 ---> System.IO.FileNotFoundException: Could not load file or assembly 'System.Management.Automation, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified.

File name: 'System.Management.Automation, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
   --- End of inner exception stack trace ---
   at Microsoft.DotNet.Interactive.PowerShell.PowerShellKernel..ctor() in D:\a\_work\1\s\src\Microsoft.DotNet.Interactive.PowerShell\PowerShellKernel.cs:line 84
   at Microsoft.DotNet.Interactive.App.CommandLine.CommandLineParser.CreateKernel(String defaultKernelName, FrontendEnvironment frontendEnvironment, StartupOptions startupOptions, TelemetrySender telemetrySender) in D:\a\_work\1\s\src\dotnet-interactive\CommandLine\CommandLineParser.cs:line 489
   at Microsoft.DotNet.Interactive.App.CommandLine.CommandLineParser.<>c__DisplayClass5_0.<<Create>b__21>d.MoveNext() in D:\a\_work\1\s\src\dotnet-interactive\CommandLine\CommandLineParser.cs:line 333
--- End of stack trace from previous location ---
   at System.CommandLine.NamingConventionBinder.CommandHandler.GetExitCodeAsync(Object returnValue, InvocationContext context)
   at System.CommandLine.NamingConventionBinder.ModelBindingCommandHandler.InvokeAsync(InvocationContext context)
   at System.CommandLine.Invocation.InvocationPipeline.<>c__DisplayClass4_0.<<BuildInvocationChain>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass17_0.<<UseParseErrorReporting>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at Microsoft.DotNet.Interactive.App.CommandLine.CommandLineParser.<>c__DisplayClass5_0.<<Create>b__2>d.MoveNext() in D:\a\_work\1\s\src\dotnet-interactive\CommandLine\CommandLineParser.cs:line 161
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass12_0.<<UseHelp>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass22_0.<<UseVersionOption>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass19_0.<<UseTypoCorrections>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<UseSuggestDirective>b__18_0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass16_0.<<UseParseDirective>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<RegisterWithDotnetSuggest>b__5_0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass8_0.<<UseExceptionHandler>b__0>d.MoveNext()

getting same issue in Calculate Linux, a distributive based on Gentoo
dotnet can be installed here by two packages:

dev-dotnet/dotnet-sdk-bin - binary package - a dotnet binary is downloaded and installed
dev-dotnet/dotnet-sdk - dotnet is build from sources

The issue is reproducable only in use package dev-dotnet/dotnet-sdk, e.g. build dotnet from sources
$ dotnet --info
.NET SDK:
 Version:           8.0.105
 Commit:            eae90abaaf
 Workload version:  8.0.100-manifests.796a77f8

Runtime Environment:
 OS Name:     calculate
 OS Version:
 OS Platform: Linux
 RID:         calculate-x64
 Base Path:   /usr/lib64/dotnet-sdk-8.0/sdk/8.0.105/

.NET workloads installed:
 Workload version: 8.0.100-manifests.796a77f8
There are no installed workloads to display.

Host:
  Version:      8.0.5
  Architecture: x64
  Commit:       087e15321b

.NET SDKs installed:
  8.0.105 [/usr/lib64/dotnet-sdk-8.0/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 8.0.5 [/usr/lib64/dotnet-sdk-8.0/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 8.0.5 [/usr/lib64/dotnet-sdk-8.0/shared/Microsoft.NETCore.App]

Other architectures found:
  None

Environment variables:
  DOTNET_ROOT       [/usr/lib64/dotnet-sdk-8.0]

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

$ dotnet interactive stdio
Unhandled exception: System.TypeInitializationException: The type initializer for 'Microsoft.DotNet.Interactive.PowerShell.PowerShellKernel' threw an exception.
---> System.IO.FileNotFoundException: Could not load file or assembly 'System.Management.Automation, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified.
File name: 'System.Management.Automation, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
--- End of inner exception stack trace ---
at Microsoft.DotNet.Interactive.PowerShell.PowerShellKernel..ctor() in D:\a_work\1\s\src\Microsoft.DotNet.Interactive.PowerShell\PowerShellKernel.cs:line 85
at Microsoft.DotNet.Interactive.App.CommandLine.CommandLineParser.CreateKernel(String defaultKernelName, FrontendEnvironment frontendEnvironment, StartupOptions startupOptions, TelemetrySender telemetrySender) in D:\a_work\1\s\src\dotnet-interactive\CommandLine\CommandLineParser.cs:line 488
at Microsoft.DotNet.Interactive.App.CommandLine.CommandLineParser.<>c__DisplayClass5_0.<b__20>d.MoveNext() in D:\a_work\1\s\src\dotnet-interactive\CommandLine\CommandLineParser.cs:line 333
--- End of stack trace from previous location ---
at System.CommandLine.NamingConventionBinder.CommandHandler.GetExitCodeAsync(Object returnValue, InvocationContext context)
at System.CommandLine.NamingConventionBinder.ModelBindingCommandHandler.InvokeAsync(InvocationContext context)
at System.CommandLine.Invocation.InvocationPipeline.<>c__DisplayClass4_0.<b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass17_0.<b__0>d.MoveNext()
--- End of stack trace from previous location ---
at Microsoft.DotNet.Interactive.App.CommandLine.CommandLineParser.<>c__DisplayClass5_0.<b__2>d.MoveNext() in D:\a_work\1\s\src\dotnet-interactive\CommandLine\CommandLineParser.cs:line 161
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass12_0.<b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass22_0.<b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass19_0.<b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<b__18_0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass16_0.<b__0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<b__5_0>d.MoveNext()
--- End of stack trace from previous location ---
at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass8_0.<b__0>d.MoveNext()

It is an issue in Microsoft.PowerShell.SDK package.
System.Management.Automation is stored in same git repository and is referenced as project, not as a package. As the result in the nuspec file written that it depends on a one version of System.Management.Automation, but inside nupkg archive under ref/net8.0/ there is another version of System.Management.Automation.dll.
This confusion causes error.
Reported a bug: https://github.com/PowerShell/PowerShell/issues/24110


Lucky feat does not prevent other reaction

when using Lucky feat to successfully evade an attack - other reactions (like shield spells) are still presented to block the attack although the attack is now a miss (due to luck re-roll).

I need a save to test. Even better if before this triggers

Saves are hard since this depend on the battle, but here is a screenshot showing it . the fighter got hit ,and used luck point to force a re-re-roll
the attacker re-rolled a 3 which is a miss . nevertheless the attacker reaction pop to suggest to use twin blade reaction although the attack is now a miss (3 instead of 17)

probably fixed in DEV. Can you compile it and give a try?

Yep

SolastaUnfinishedBusiness.zip
use this one. latest DEV build from minutes ago.

Definitely fixed in dev.


Support interactive commands

Description

Currently 1build executes command which providers direct output without user input.
1build does not support interactive command yet. Example taking user input, or ssh to remote machine, running repl, running psql etc.

Example
1build postgres

Execution plan
--       ----------------------------------------------------------
Phase    Command
--       ----------------------------------------------------------
postgres       pgcli postgres://postgres:password@localhost:5432/postgres

---------------------------------[ pg ]---------------------------------
Warning: Input is not a terminal (fd=0).
Server: PostgreSQL 12.1
Version: 3.0.0
Chat: https://gitter.im/dbcli/pgcli
Home: http://pgcli.com
postgres@localhost:postgres>
Goodbye!

------------------------------------------------------------------------
SUCCESS - Total Time: 00s
------------------------------------------------------------------------

Above command should run the psql ripl & take users command, but 1build doesn't allow to do that.

Acceptance Criteria

Support interactive command
If users inter to interactive session - 1build process will wait for the user to exit and come back to 1build process

@gopinath-langote this should be a fairly simple implementation.
Currently the the 1build bashCommand is expecting *sh.Session.
func bashCommand(s *sh.Session, command string) *sh.Session {
	return s.Command("bash", "-c", command)
}

However we're currently passing in *sh.NewSession  to the *CommandContext.CommandSession when building the buildExecutionPlan
The *sh.NewSession func is defaulting to an empty string for Stdin.
s := &Session{
	inj:    inject.New(),
	alias:  make(map[string][]string),
	dir:    Dir(""),
	Stdin:  strings.NewReader(""),
	Stdout: os.Stdout,
	Stderr: os.Stderr,
	Env:    env,
}

We should be able to swap *sh.NewSession with their alternative Session func; *sh.InteractiveSession.
Which uses *sh.NewSession but additionally setting Stdin to SetStdin(os.Stdin).
func InteractiveSession() *Session {
	s := NewSession()
	s.SetStdin(os.Stdin)
	return s
}

So passing in sh.InteractiveSession() to the *CommandContext.CommandSession when building the buildExecutionPlan should be all we need to add interactive support.

I tested it out with docker run nginx -it sh (to get an interactive shell) and was able to get 1build to run it interactively.

@TimDurward thanks for doing research on this.
I am curious is there any way we can handle this without the user specifying that it's an interactive command or normal command.

Or setting s.SetStdin(os.Stdin) will work for all the usecases?
Could you please and confirm?


Severely overfitting occurred.

Dear author:
I trained a lite-base version of video swin transformer, but I noticed very severely overfitting phonomenon occurred as :
, data_time: 0.001, memory: 20882, top1_acc: 0.7600, top5_acc: 0.9206, loss_cls: 0.9247, loss: 0.9247
2022-02-15 10:24:18,650 - mmaction - INFO - Epoch [13][5860/5929]	lr: 2.714e-05, eta: 2 days, 3:27:33, time: 0.669, data_time: 0.001, memory: 20882, top1_acc: 0.7569, top5_acc: 0.9269, loss_cls: 0.9281, loss: 0.9281
2022-02-15 10:24:31,952 - mmaction - INFO - Epoch [13][5880/5929]	lr: 2.714e-05, eta: 2 days, 3:27:20, time: 0.664, data_time: 0.000, memory: 20882, top1_acc: 0.7462, top5_acc: 0.9313, loss_cls: 0.9472, loss: 0.9472
2022-02-15 10:24:45,297 - mmaction - INFO - Epoch [13][5900/5929]	lr: 2.714e-05, eta: 2 days, 3:27:07, time: 0.668, data_time: 0.001, memory: 20882, top1_acc: 0.7556, top5_acc: 0.9250, loss_cls: 0.9117, loss: 0.9117
2022-02-15 10:24:58,546 - mmaction - INFO - Epoch [13][5920/5929]	lr: 2.714e-05, eta: 2 days, 3:26:53, time: 0.662, data_time: 0.001, memory: 20882, top1_acc: 0.7506, top5_acc: 0.9256, loss_cls: 0.9624, loss: 0.9624
[>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>] 33663/33663, 139.1 task/s, elapsed: 242s, ETA:     0s

2022-02-15 10:29:10,037 - mmaction - INFO - Evaluating top_k_accuracy ...
2022-02-15 10:29:12,502 - mmaction - INFO -
top1_acc	0.5948
top5_acc	0.8161
2022-02-15 10:29:12,502 - mmaction - INFO - Evaluating mean_class_accuracy ...
2022-02-15 10:29:12,608 - mmaction - INFO -
mean_acc	0.5943
2022-02-15 10:29:12,626 - mmaction - INFO - Epoch(val) [13][421]	top1_acc: 0.5948, top5_acc: 0.8161, mean_class_accuracy: 0.5943

after i trained for 30 epochs, the training top1 reached 90+%, but the validation acc keep ~59% still.
I follow most of the setting as swin-base :
        drop_rate=0.,
        attn_drop_rate=0.,
        drop_path_rate=0.2,
        patch_norm=True),

    cls_head=dict(
        type='I3DHead',
        in_channels=1024,
        num_classes=700,
        spatial_type='avg',
        dropout_ratio=0.5),

# optimizer
optimizer = dict(type='AdamW', lr=3e-4, betas=(0.9, 0.999), weight_decay=0.05,
                 paramwise_cfg=dict(custom_keys={'absolute_pos_embed': dict(decay_mult=0.),
                                                 'relative_position_bias_table': dict(decay_mult=0.),
                                                 'norm': dict(decay_mult=0.),
                                                 'backbone': dict(lr_mult=0.1)})

Anyone has the same case? could anyone give some tips? thank you.

I met same problem, have you got the reason?


Inconsistency in SyncBatchNormalization/BatchNormalization(synchronized=True) Results during Distributed Training on CPUs

Click to expand!
Issue Type
Bug
Have you reproduced the bug with TF nightly?
Yes
Source
source
Tensorflow Version
tf 2.11.0
Custom Code
Yes
OS Platform and Distribution
Linux Ubuntu 20.04.5 LTS
Mobile device
No response
Python version
3.8.10
Bazel version
No response
GCC/Compiler version
No response
CUDA/cuDNN version
11.7
GPU model and memory
No response
Current Behaviour?
I am reporting an issue encountered during the distributed training of a model with SyncBatchNormalization layers on CPUs. The issue presents as a relatively large inconsistency between the results produced when training the same model on a single device versus multiple devices.
We've prepared a reproduction script demonstrating this issue. We set the weights of the SyncBatchNormalization/BatchNormalization layer to reproduce this bug. After conducting a one-step training, the predictions from the identical model trained on a single CPU and two CPUs exhibited relatively large differences (measured by L-infinity distance, Linf = 0.00074467063). As a comparison, we build another model with exactly the same architecture but removing the SyncBatchNormalization layer, and the prediction difference from this model trained on a single CPU and two CPUs is Linf = 1.0131771e-09.
Another comparison experiment is on GPUs. We trained the same model containing SyncBatchNormalization layer on a single GPU and two GPUs. The Linf of model’s prediction result is 2.5331974e-07. It’s much smaller than 1CPU vs 2CPU (Linf = 0.00074467063). This is weird because I would expect the CPU executions to be more deterministic than GPUs, and I would expect larger inconsistencies in the GPU runs if the inconsistencies are caused by variance.
To ensure a controlled environment, we used the same training data for one-step training on both setups, and then evaluated the model. To guarantee that the distributed trainings are expected to produce the same results given different number of devices, we use MirroredStrategy, keep the global batch size the same, and use tf.keras.losses.Reduction.AUTO reduction. To make the difference more apparent given a limited amount of training data, we deliberately chose a relatively high learning rate (lr=10).
It's noteworthy that SyncBatchNormalization has been deprecated as of TensorFlow version 2.12. Therefore, we also conducted the same experiment using TensorFlow's nightly build (2.13.0-dev20230428), replacing SyncBatchNormalization() with BatchNormalization(synchronized=True). This experiment still manifested the same inconsistency. The prediction from the model containing batchnorm layer trained on a single CPU and two CPUs exhibits a substantial difference of Linf = 0.00010111928, while for the model removing batchnorm layer it’s Linf = 6.212488e-36.
Standalone code to reproduce the issue
For TF 2.11.0 CPU experiments, the model contains `SyncBatchNormalization` layer:
https://colab.research.google.com/drive/11EseXxq_uHweY7omt7JCr1mc-42Kf1H5?usp=sharing

For TF 2.11.0 GPU experiments, the model contains `SyncBatchNormalization` layer (fix seed to generate same inputs):
https://colab.research.google.com/drive/1m_gCWzb_OKVTYAMMs8YbdKUYM3aINNPV?usp=sharing

For TF nightly 2.13.0-dev20230428, the model contains `BatchNormalization(synchronized=True)` layer:
https://colab.research.google.com/drive/1N-aXPcfckVb8fPDSmghMlzBOFEGq6RzM?usp=sharing

Relevant log output
For TF 2.11.0:
contain syncbatchnorm:  True
1CPU vs 2CPU: 0.00074467063

contain syncbatchnorm:  False
1CPU vs 2CPU: 1.0131771e-09

contain syncbatchnorm:  True
1GPU vs 2GPU: 2.5331974e-07

For TF nightly 2.13.0-dev20230428:
contain syncbatchnorm:  True
1CPU vs 2CPU: 0.00010111928

contain syncbatchnorm:  False
1CPU vs 2CPU: 6.212488e-36

Hi @Liqi1003 ,
Thanks for reporting. As the SyncBatchNormalization API endpoint is deprecated and might removed in Future release, I tried to replicate the BatchNormalization issue with synchronized=True. I have replicated the difference in outputs wrt 1- CPU and 2-CPU as reported and the value might not be ignorable and needs to have a look into it.Reference gist.

while for the model removing batchnorm layer it’s Linf = 6.212488e-36

Could you please submit code snippet for this also.
Thanks!

@SuryanarayanaY
Thanks for the quick reproduction! The reproduction code without SyncBatchNormalization is in the same colab here: https://colab.research.google.com/drive/1N-aXPcfckVb8fPDSmghMlzBOFEGq6RzM?usp=sharing
In the last code block, uncomment the second line and execute the code block again, and you should be able to see the difference without SyncBatchNormalization layers.

@Liqi1003 ,
I have done some changes in code to check the difference in outputs with 1 CPU and 2 CPUs with BatchNormalization(synchronised=True) and BatchNormalization(synchronised=False) and the difference in results wrt 1-CPU and 2-CPU came around same at 0.00010111928. Could you please refer attached gist.
In your code for synchronised=False it is omitting batch_normalization and hence there is large difference in results.
Thanks!

@SuryanarayanaY
Thanks for the debugging effort!
However, the key point here is that BatchNormalization layer is introducing big variances when training on CPUs. On 1-GPU vs 2-GPU setting, we see very small differences (~1e-7), but on 1-CPU vs 2-CPU setting, we can see a much larger difference (~1e-4).
Given our effort to control variance by limiting training steps, a difference of 1e-4 should be considered big. Although with larger training size, the difference could either become bigger or cancle out, we do see the difference in one-step training.
I suspect there is something special with CPU execution of BatchNormalization layers, which caused the difference.

@Liqi1003 ,
Will escalate the issue to Dev team for their comments. Thanks!


Estimated Error Details

I'm a PhD Student, I am performing an experimentation for a paper using verdictdb. I would like to provide also error bounds/estimation for the obtained results. I read in the paper that the user can require it to VerdictDB, but I can not find a way to do it using the verdictdb 0.5.8 java version API. Is this my fault or the API does not support it yet?
From issue #99 I understand that this should be possible.
Thanks for your time.

We had the feature but disabled it temporarily. We will soon release another version that provides error bounds. We are using the new version internally, but to release it, we should also update our documentation.

We had the feature but disabled it temporarily. We will soon release another version that provides error bounds. We are using the new version internally, but to release it, we should also update our documentation.

Does the latest version support error estimation function? Thanks


File system scheme 's3' not implemented

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: No
TensorFlow installed from (source or binary): Binary
TensorFlow version (use command below): v2.2.0-rc4-8-g2b96f3662b 2.2.0
Python version: 3.6.5
Bazel version (if compiling from source): NA
GCC/Compiler version (if compiling from source): NA
CUDA/cuDNN version: NA
GPU model and memory: NA

Describe the current behavior
tensorflow.python.framework.errors_impl.UnimplementedError: File system scheme 's3' not implemented
Describe the expected behavior
Should be able to connect the s3 filesystem.
Standalone code to reproduce the issue
from tensorflow.python.lib.io import file_io
print file_io.stat('s3://bucketname/path/')
Other info / logs Include any logs or source code that would be helpful to
diagnose the problem. If including tracebacks, please include the full
traceback. Large logs and files should be attached.

Can you try with the final 2.2 release please?

Oh. You are using Windows. Windows does not yet support S3 filesystems, but there is a GSoC project to enable that.

#39124 will be included in the upcoming 2.3 release.
Modular filesystems (tensorflow/community#101) will probably come in 2.4

Hi, I'm facing the exact same error with s3a://
My tf version is: 2.1.0
Please help

Also, I can read s3a:///wine-quality.csv using Spark.

Also, I can read s3a://path/to/wine-quality.csv using Spark.

@vaibhavsingh007 we only implement support for the s3:// URI scheme. Didn't know there is a s3a:// too. Do you know what are the differences?

Yes, s3a is the latest protocol and is more performant than its predecessors s3/s3n: https://stackoverflow.com/questions/33356041/technically-what-is-the-difference-between-s3n-s3a-and-s3
Would you know if or when we may expect TF to S3 functionality become available?

There is funcionality for basic s3:// scheme on Linux. Then there is work for tensorflow/community#101 to convert all these filesystem to a plugin based form so they can be used on all platforms, on demand.
Regarding s3a and s3n, can you file a new issue, feature request type, and assign it to me/mention me? just to keep this issue only for the s3 not implemented error.

Done. Seems the bot auto assigned and I can't change the assignee.

Thank you. Yes, the bot assigns oncall for triage.

So @mihaimaruseac I wanted to draw our attention back to the original issue of not being able to write to S3 from TF using s3://..
I get the error NotFoundError: Object s3:///wine-quality.csv does not exist (from the post above).

Hmm, what would be the output of tf.io.gfile.exists on that path?

o/p of above is 'False'.
Also, I was able to get some backend logs for the stat call, in case it helps:

And I'm setting these auth vars:
os.environ["AWS_ACCESS_KEY_ID"]="***"
os.environ["AWS_SECRET_ACCESS_KEY"]="***"
os.environ["AWS_REGION"]="us-east-1"

@mihaimaruseac any luck?

Sorry, didn't have time to look more into this. Can you manually issue the curl requests?

Well like I said can access the said files using s3a:// via Spark. But let me try curling as well.

@mihaimaruseac I couldn't set up curl, but successfully read file using aws api via boto3. Here is a snapshot:

Would you like to share a sample code to test read from private (secured) s3 repo using TF? I hope I am using the correct auth configuration (shared before).

And I'm setting these auth vars:
os.environ["AWS_ACCESS_KEY_ID"]="***"
os.environ["AWS_SECRET_ACCESS_KEY"]="***"
os.environ["AWS_REGION"]="us-east-1"

Current implementation uses curl to handle the requests to the S3 API. The modular filesystem approach that is currently in the works would use awscpp.
But until then, I think we need to differentiate between TF error and curl error.

Hi, I am not sure I understand what you mean by 'differentiate between TF error and curl error'. Is there something else you want me to try since we still cannot read/write to S3 using TF.

Can you intercept the requests TF makes during tf.io.gfile.file_exists on the path and then try playing them manually via curl? Looking at the provided logs it looks like there is a failure on the server / invalid credentials/cookies/arguments get sent.

Would you be able to direct me how I can do that?

Hmm, I was wrong, it seems we are already using AWS library not issuing curl requests manually
https://cs.opensource.google/tensorflow/tensorflow/+/master:tensorflow/core/platform/s3/s3_file_system.cc;l=707-766;drc=791f4f2b773208b21ece71e1d37204a91720346d
You could intercept the traffic using wireshark or if you can compile from source, I'd recommend adding some debug prints in the function I linked above.
Unfortunately I currently don't have access to an S3 bucket and won't be able to look much into this issue until mid of August. Apologies for the delay

Question: can you compile TF from source? Or parts of TF.
We have an experimental plugin for S3 support that might be easier to use than the existing non-modular approach. But at the moment it requires manual compile.

Hi @mihaimaruseac sorry for the delay.
I'm not sure we can do that but I may try. Can you share more details about the new API?

Hi.
We are planning to modularize filesystems in TF and only offer the local filesystem by default in the pip package, requiring every other filesystem to be loaded at runtime from a shared library. RFC is at https://github.com/tensorflow/community/blob/master/rfcs/20190506-filesystem-plugin-modular-tensorflow.md and currently the implementation is at https://github.com/tensorflow/tensorflow/tree/master/tensorflow/c/experimental/filesystem
I would suggest compiling the S3 plugin from the experimental filesystem and then using tf.load_library to load the shared object.

can you please describe steps to do for implementing s3 filesystem on winows platform or it still require loading shared library at runtime?

Compiling the plugin in https://cs.opensource.google/tensorflow/tensorflow/+/master:tensorflow/c/experimental/filesystem/plugins/s3/;drc=75a455a9416630e4a33d23b4dc27bbbdb9c75f41 gives you a shared object that you then load at runtime.
This should work on all operating systems.

The s3 filesystem is available on windows by install pip install tensorflow-io==0.17. Could you give it a try ? Note that in order to avoid conflicts with current s3 in TensorFlow, it is accessible by s3e uri, i.e s3e://bucket/key.
Example : https://github.com/tensorflow/io/blob/master/tests/test_s3_eager.py

@kumaradi08 @vaibhavsingh007  As per the mihai latest comment, it should work on all Operating systems.  Could you please confirm and if yes, Please go ahead and close the issue if you don't have any further queries.Thanks!

@saikumarchalla @kumaradi08 @vaibhavsingh007 Actually there is one more issue https://github.com/tensorflow/tensorflow/issues/49515 which will be fixed by #49520.

This is there in 2.6 version of tensorflow
"tensorflow/tensorflow:2.6.0"
File "/usr/local/lib/python3.6/dist-packages/keras/callbacks.py", line 2219, in set_model
    self._write_keras_model_summary()
  File "/usr/local/lib/python3.6/dist-packages/keras/callbacks.py", line 2258, in _write_keras_model_summary
    with self._train_writer.as_default():
  File "/usr/local/lib/python3.6/dist-packages/keras/callbacks.py", line 2228, in _train_writer
    self._train_dir)
  File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/ops/summary_ops_v2.py", line 554, in create_file_writer_v2
    create_fn=create_fn, init_op_fn=init_op_fn)
  File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/ops/summary_ops_v2.py", line 313, in __init__
    self._init_op = init_op_fn(self._resource)
  File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/ops/gen_summary_ops.py", line 146, in create_summary_file_writer
    _ops.raise_from_not_ok_status(e, name)
  File "/usr/local/lib/python3.6/dist-packages/tensorflow/python/framework/ops.py", line 6941, in raise_from_not_ok_status
    six.raise_from(core._status_to_exception(e.code, message), None)
  File "<string>", line 3, in raise_from
tensorflow.python.framework.errors_impl.UnimplementedError: File system scheme 's3' not implemented (file: 's3://tfboard/logs/20210825-092239/train') [Op:CreateSummaryFileWriter]

I'm also getting the above error with Tensorflow 2.6
writer = tf.io.TFRecordWriter(tf_record_path)

Exception has occurred: UnimplementedError
File system scheme 's3' not implemented (file: 's3://ffda-poi/training_data/mauritania_by_areas/rural/od/large_tfrecords/train_mauritania_rural_od_large_training_data_001.tfrecords')
  File "/tfrecords/write_tfrecords_od.py", line 219, in write_tfrecord_file
    writer = tf.io.TFRecordWriter(tf_record_path)
  File "/tfrecords/write_tfrecords_od.py", line 280, in write_tfrecord_od
    write_tfrecord_file(train_df, tile_path, record_file_train, super_tile_size)
  File "/tfrecords/write_tfrecords_od.py", line 318, in main
    write_tfrecord_od(csv_file, output_dir, tile_path, super_tile_size, geojson_with_neg_path)
  File "/tfrecords/write_tfrecords_od.py", line 322, in <module>
    main()

I can confirm this error does not happen if I install tensorflow 2.3

The s3 filesystem is available on windows by install pip install tensorflow-io==0.17. Could you give it a try ? Note that in order to avoid conflicts with current s3 in TensorFlow, it is accessible by s3e uri, i.e s3e://bucket/key.
Example : https://github.com/tensorflow/io/blob/master/tests/test_s3_eager.py

This should be the solution here. For cloud filesystems you have to also install the SIG IO wheel.


storage/framework/cache folder permissions messed out after koel:sync

I was today discovering Koel, so I did go throught the Docker way, as I am running a personal home server with docker setup:

Ubuntu 20.04 LTS
docker version

The first run went all okay. But after doing the koel:sync, somethings weird happens: I cannot login again to Koel.
Reading the logs inside storage/logs/laravel.log I can see this after a login try:

So i just checked out this dir, and I can se that almost everything inside the folder "/var/www/html/storage/framework/cache/data" is owned by root, but the folder itself is owned by www-data.

So i changed the content of this dir back to www-data owner, and now I can login without issues!
So I suspect something is wrong with the php artisan commands beeing run as user root inside the container and makes all of this folders unreadable by Koel, leaving with this permission issue and then unable to login.
So by now the fix remain on just changing the permissions on this folder after running the koel:sync command. But I think we should find a more "definitive" approach to this.

Ok, so the problem is comming from running the command inside the container using bash as root user.
Running the koel:sync command from outside the container using docker exec works as expected. So a change in the main README.md should be done to preventing users to run the php artisan commands inside the container as root user.

Indeed, running koel:sync as root will create index folders owned by root. Thanks for posting the follow-up with the resolution.
I'm not sure exactly what needs to change, feel free to open a pull request with the changes to the README, I'll review it and merge it.

I ran into this issue while working on the image. I added --user www-data in all docker exec command examples in the README.


TimberArchives class not creating valid yearly archive links for HTTPS sites

Expected behavior

The TimberArchives class generates valid yearly archive links even when the site is HTTPS.
Actual behavior
TimberArchives generates invalid yearly archive links on HTTPS sites - the second slash in the protocol is missing (eg, https:/www.example.com rather than https://www.example.com).
Steps to reproduce behavior
// Yearly Links
$archive_obj = new TimberArchives();

$archive_args = array(
  'post_type' => 'post',
  'type' => 'yearly'
);

$years = $archive_obj->get_items($archive_args);

return $years[0]['link']; // will return a link with a missing second slash for HTTPS sites.

What version of WordPress, PHP and Timber are you using?
WordPress 4.7.4, PHP 7, Timber 1.3.0
How did you install Timber? (for example, from GitHub, Composer/Packagist, WP.org?)
Composer

Closed by #1448 — thanks for the report @chrisgherbert !


Safety of AsciiPointer::from_slice_with_nul

Hi, thanks for the library.
I made a silly mistake by implementing the following helper function:
fn to_ascii_pointer(string: &str) -> AsciiPointer {
    AsciiPointer::from_slice_with_nul(&format!("{string}\0").into_bytes()).unwrap()
}

Only to realize, late into testing, that it produces an AsciiPointer that points to freed memory.
Ideally, this kind of code should result in a compilation error.

Oh wow, this is a bad bug, thanks for pointing that out. I somehow missed to add the <'a> to the constructor function. It should read instead (on latest master):
pub fn from_slice_with_nul(cstr_with_nul: &'a [u8]) -> Result<CStrPointer<'a>, Error>

Thanks for the quick fix. I'm new to Rust, but isn't there a similar issue here?
https://github.com/ralfbiedert/interoptopus/blob/1c6cf0e86342e75afd6aa6594e0de708a89ec044/crates/core/src/patterns/slice.rs#L77-L83

I'm new to Rust, but isn't there a similar issue here?

No, because the slice parameter captures the 'a lifetime (and Self has 'a implicitly encoded through the impl<'a, T> FFISlice<'a, T> {} block surrounding that method). You can check this yourself, this won't work:
    fn to_vec(data: &[u8]) -> FFISlice<u8> {
        let v = data.to_vec();
        FFISlice::from_slice(v.as_slice())
    }

The first example you posted failed because in the previous  pub fn from_slice_with_nul(cstr_with_nul: &[u8]) -> Result<Self, Error> {} I forgot to mention 'a in the parameter, which means Rust secretly introduced a fresh lifetime parameter 'b instead, and was fine us pretending we could summon an  AsciiPointer <'a> seemingly out of thin air.
Once you have the correct 'a in your input parameter (inside a block where 'a is already tied to the struct), whether you then return SomeStruct<'a> or Self is just style (and yes, right now that style is a bit inconsistent).

The first example you posted failed because in the previous  pub fn from_slice_with_nul(cstr_with_nul: &[u8]) -> Result<Self, Error> {} I forgot to mention 'a in the parameter

That makes sense, but you also changed the return type in from_cstr, while from_slice looks similar to the variant before the change. Or was that one just a cosmetic fix? Sorry for the rookie lifetime questions :)

Or was that one just a cosmetic fix?

Yes, that's what I meant about the style being inconsistent.


Publish CCR zip to maven repo

Signed-off-by: Ankit Kala<EMAIL_ADDRESS>Description
Publish CCR zip to maven repo
Depends on https://github.com/opensearch-project/cross-cluster-replication/pull/398/files
Issues Resolved
https://github.com/opensearch-project/cross-cluster-replication/issues/384
Check List

[x] New functionality includes testing.

[x] All tests pass

[x] New functionality has been documented.

[x] New functionality has javadoc added

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This PR has a dependency on https://github.com/opensearch-project/cross-cluster-replication/pull/398/files

Hey @ankitkala, please verify the published zips have right POM coordinates, you should be adding
    publications {
        pluginZip(MavenPublication) { publication ->
            pom {
                name = opensearchplugin.name
                description = opensearchplugin.description
                licenses {
                    license {
                        name = "The Apache License, Version 2.0"
                        url = "http://www.apache.org/licenses/LICENSE-2.0.txt"
                    }
                }
                developers {
                    developer {
                        name = "OpenSearch"
                        url = "https://github.com/opensearch-project/cross-cluster-replication"
                    }
                }
            }
        }
    }
}

Example PR: opensearch-project/index-management#366

The build fails as the publishing pluginZip already exists.
Cannot add a Publication with name 'pluginZip' as a Publication with that name already exists.

I tried changing the publication name but it again failed with
> Task :validatePluginZipCCRPom FAILED
Execution optimizations have been disabled for task ':validatePluginZipCCRPom' to ensure correctness due to the following reasons:
  - Gradle detected a problem with the following location: '/Volumes/ws/cross-cluster-replication/build/distributions/opensearch-cross-cluster-replication-<IP_ADDRESS>-rc1-SNAPSHOT.pom'. Reason: Task ':validatePluginZipCCRPom' uses this output of task ':generatePomFileForNebulaPublication' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.3.3/userguide/validation_problems.html#implicit_dependency for more details about this problem.
description is missing in [/Volumes/ws/cross-cluster-replication/build/distributions/opensearch-cross-cluster-replication-<IP_ADDRESS>-rc1-SNAPSHOT.pom]

Also, do we need to add custom POM extension? Can't the opensearch.pluginzip infer the name,description,license,etc by itself?

This could be the issue https://github.com/opensearch-project/cross-cluster-replication/blob/main/build.gradle#L39 can you try with 2.0.1-SNAPSHOT ?

Codecov Report

Merging #399 (026cfdb) into main (cd02e1f) will decrease coverage by 1.79%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #399      +/-   ##
============================================
- Coverage     74.37%   72.57%   -1.80%
+ Complexity      996      978      -18
============================================
  Files           141      141
  Lines          4562     4562
  Branches        504      504
============================================
- Hits           3393     3311      -82
- Misses          849      931      +82
  Partials        320      320

Impacted Files
Coverage Δ

...cation/action/changes/TransportGetChangesAction.kt
63.49% <0.00%> (-25.40%)
:arrow_down:

...ch/replication/task/index/IndexReplicationState.kt
51.66% <0.00%> (-15.00%)
:arrow_down:

...ication/action/setup/TransportSetupChecksAction.kt
59.52% <0.00%> (-14.29%)
:arrow_down:

...ication/seqno/RemoteClusterRetentionLeaseHelper.kt
80.00% <0.00%> (-11.67%)
:arrow_down:

...tion/repository/RemoteClusterMultiChunkTransfer.kt
90.24% <0.00%> (-9.76%)
:arrow_down:

.../replication/metadata/store/ReplicationMetadata.kt
62.96% <0.00%> (-8.65%)
:arrow_down:

...action/stop/TransportStopIndexReplicationAction.kt
68.00% <0.00%> (-6.67%)
:arrow_down:

...ication/action/stop/StopIndexReplicationRequest.kt
50.00% <0.00%> (-5.00%)
:arrow_down:

...ion/action/resume/ResumeIndexReplicationRequest.kt
50.00% <0.00%> (-5.00%)
:arrow_down:

...tlin/org/opensearch/replication/util/Extensions.kt
65.47% <0.00%> (-4.77%)
:arrow_down:

... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd02e1f...026cfdb. Read the comment docs.


apt-get update fails on new image

raspbian:jessie Packages file was updated yesterday here.
now, apt-get update Docker build step fails with the following message:
W: Failed to fetch http://archive.raspberrypi.org/debian/dists/jessie/main/binary-armhf/Packages  Hash Sum mismatch

using the following simple Dockerfile:
FROM resin/rpi-raspbian
RUN apt-get update

problem resolved itself, not sure why, nothing changed.  i think the apt-get failure message is inaccurate.


Cleanup & next release

This does a few long-standing maintenance tasks, and will eventually mark the next release

Cleans up readme
Moves to pyproject.toml
Removes versioneer
More to come...

Please merge #299 and #300 before next release

Any updates on this? I need PEP 517 compatible builds for a tool I work with, and versioneer.py in v0.9.1 is causing problems due to its use of SafeConfigParser.

Sorry about the delay, I have been completely consumed by another project. I will see if I can get this in & released in the next few days.
It just needs a bit of testing because it completely changes the packaging situation, so I want to be sure nothing breaks.

I tested the packaging and it all seems to work

New version is on PyPI and on the website. Will be on conda-forge later today!


Add system prompt for Granite-8b model

Is your feature request related to a problem? Please describe.
InstructLab currently uses a single hardcoded system prompt for all models. This prompt is designed specifically for the granite-7b model. We now also want to support the granite-8b model which requires a slightly different system prompt.
Describe the solution you'd like
Add the 8b system prompt to the codebase and add logic to determine the correct system prompt to use
Additional context
Going forwards we will be aiming to move away from hardcoding system prompts and work towards allowing users to specify their own personal system prompts.
This issue is a short term requirement
related to #2510

fixed by #2592


Implement BlobsSidecarsByRange v1

PR Description

Added new Optional RPC method in BeaconChainMethod
Implemented handling logic in BlobsSidecarsByRangeMessageHandler
Add peer rate limiting
Added new method to SyncSource and added the main implementation (in DefaultEth2Peer). The test fixtures can be implemented when working on the syncing issues.
Throttling will be done as part of #6585
Validation will be done as part of #6584

Fixed Issue(s)
fixes #6571
Documentation

[X] I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

[X] I thought about adding a changelog entry, and added one if I deemed necessary.

LGTM. What needs to be done in a subsequent PR (once storage is there) is the return with 3: ResourceUnavailable error when turns out we cant responds due to missing blobs within the availability window

Yup. I have that on my local. Will raise a PR tomorrow. Not sure about the implementation but can discuss then.


[Docs] Making “Number” a bit more precise

What about making Number from SassDoc comments a bit more precise by using Length for actual lengths, such as 42px, Integer for integer such as 42, and Duration for time-based values such as 42ms?
Happy to make a PR if needed.

Yep, that makes sense—I noticed you did the same thing with Motion UI. I also generally find them more readable. For example, Shadow or Transition would be more descriptive than List, even if that's what the proper Sass value is.

Going to close this due to lack of activity.
We're doing a hardcore issue burn-down this week. Once the issue tracker is more stable, we'll have a bit more leeway to make codebase improvements like this.


[time_series][feature_parity] no options to add x-axis label in customize panel for new echarts time series

Some new charts do not have x-axis tile option in customize panel, can we add that?
https://user-images.githubusercontent.com/81597121/131388308-d2112754-dae0-4c1c-b46d-0a3fe915c06e.mov

list of charts missing x-axis tile option:
time series line chart,
time series area chart,
time series bar chat,
time series scatter plot,
mix time series,
time series chart,
time series smooth line,
time series stepped line,
box plot

For the old charts, current filed name call 'x-axis label' and in new charts field, axis label is referred to the label on each point on the axis, maybe we should just rename those filed to be axis title?
old charts with field name 'x-axis label' or 'y-axis label' currently:

area chart,
bar chart ,
bubble chart,
histogram,
line chart,
time-series percent change,
time series period pivot

@MaxHuiYYDS would you like to work on this one?
cc @stephenLYZ

@MaxHuiYYDS would you like to work on this one?
cc @stephenLYZ

OK, I will look at it

fixed by https://github.com/apache-superset/superset-ui/pull/1351
@junlincc @MaxHuiYYDS @jinghua-qa


Add Support For Multiple Usernames and Passwords

We would like to be able to support multiple usernames and password so that our entire development team doesn't have to login with one shared account.

@UserNotFound just pointed out to me, this is already possible, just use a comma-separated list of usernames/passwords, each pair separated by a colon: https://github.com/aptible/docker-kibana/blob/master/bin/run-kibana.sh#L11

Awesome @chasballew!


add builtin_gbdt_train python script

Description
Add builtin_gbdt_train python script to help people use python sdk. All my codes have been tested. But I do not add them into teaclave tests, because I dont know how to do that... So could u guys help me finish the final shot? BTW, builtin_gbdt_predict python script and codes about LR thing are on the way.

Please also use yapf to format the python code. Thanks.

@mssun Please recheck. It's done.


allow Language class to cache and import definitions into the database

replace usage of $_SESSION['languages_id'] with $OSCOM_Language->getId()
replace usage of $_SESSION['language'] with $OSCOM_Language->get('code')
load language definitions through $OSCOM_Language->loadDefinitions(); if legacy .php file exists, load the constants otherwise parse .txt file for definitions
remove legacy includes/classes/language.php class
move automatic loading of App Action language definitions from PagesActionsAbstract to PagesAbstract

by exploring the last 2 files for admin, i notice we still use FILENAME_* in the admin!


google play services 22.0.0 return 404

hi guys, it's currently not possible to build using google play services v22.0.0, because it returns a 404...

wget http://registry.cordova.io/com.google.playservices/-/com.google.playservices-22.0.0.tgz
--2015-01-14 14:13:43--  http://registry.cordova.io/com.google.playservices/-/com.google.playservices-22.0.0.tgz
Resolving registry.cordova.io... <IP_ADDRESS>
Connecting to registry.cordova.io|<IP_ADDRESS>|:80... connected.
HTTP request sent, awaiting response... 404 Object Not Found
2015-01-14 14:13:44 ERROR 404: Object Not Found.

I just ran into this as well.
By installing the plugin manually from here resolved the issue for me.  Andrew tried to publish this plugin (and others?) to the plugin registry a few days ago and it failed.  Seems it actually half-updated and may be in a broken state.  We will look into republishing asap.

Seems the plugin registry is having issues :(
https://issues.apache.org/jira/browse/CB-8284
I've reverted the broken release, so should be good again.

can confirm:
npm http GET http://registry.cordova.io/com.google.playservices
npm http 200 http://registry.cordova.io/com.google.playservices

thanks!


Query regarding Fast math hint

Hi,
I try to use fast_math with winograd convolution layer.
Can you please let me know what happens when fast_math is enabled ? A gist of how it works , and if there is any configuration for which it gives best performance ?
Also , if the similar flag is used by any other layer?
Desperately awaiting your reply,

Hi @ved27
In Winograd, there is a loss in accuracy for kernel size 5 and data type float because of the implementation details of the algorithm. The fast maths flag is used mainly to ensure the user is aware of this loss of accuracy as it's required to be true for certain configurations; the configure() method will check that the flag is enabled for specific kernel sizes like 5.
The flag has no effect at all on the execution time and it's used only to check if the user is aware of the loss of accuracy: the user must pass true when the kernel size is 5.
Do not expect a dramatic speedup when passing fast_maths = true as this flag is only used in the way explained above.


Feature/truenth usa footer layout update

address https://jira.movember.com/browse/TN-2250
new layout of footer based on new prototype provided here:
https://marvelapp.com/cfaddch/screen/61502014
Noting some duplications in content between Truenth USA footer and the portal footer html provided by portal API, I have created a story to clean up the code:  https://jira.movember.com/browse/TN-2285

thank u, ivan, merged.


Feature suggestion: use api token

In addition of email + api key it would be nice if one could use cloudflare api token to limit the scope one gives access to.

hey @Nipsuli !
Thanks for suggestion, I have been thinking of this a lot but didn't get the chance to start on this...

Hey there @Nipsuli , finally got some time to finish this.
Please feel free to check out new version v3 , remember to add ( apiToken: ${{ secrets.CF_API_TOKEN }} ) and remove
apiKey: ${{ secrets.CF_API_KEY  }}and accountEmail: ${{ secrets.CF_ACCOUNT_EMAIL }}
 - name: Send Slack deployment notifications
      uses: arddluma/cloudflare-pages-slack-notification@v3
      with:
        apiToken: ${{ secrets.CF_API_TOKEN }}
        accountId: ${{ secrets.CF_ACC_ID  }}
        project: ${{ secrets.CF_PROJECT  }}
        githubToken: ${{ secrets.GITHUB_TOKEN }}
        slackWebHook: ${{ secrets.SLACK_WEBHOOK  }}``

Please let me know once you try! Thank you

This is so awesome! I'll update our CI later today. Thank you so so much 🙇

Closing as completed. Feature is ready to use on v3


Release v0.1.0

First release.
Follows #235, this resets the version number to the version we want to publish to PyPI and changes from Test-PyPI to real PyPI.

This PR is ready for review. I created a pre-release, and it published successfully to test.pypi.org:
https://test.pypi.org/project/xl2times/0.1.0a2/
I downloaded and installed the package from the release and ran it on Demo 1 successfully.
When this PR is merged, I'll make a (real) release and it should publish to (real) PyPI.


서비스 기여자 추가

어떤 기능을 추가/요청하나요?
ISSUE (BUG)

[ ] none

ISSUE (Enhancement)

[ ] add contributors

작업 상세 내용

[ ]

참고사항

[ ]

@all-contributors please add @dogdduddy for code

@all-contributors please add @cin-dy for design

@all-contributors please add @BlaireLee for design

@all-contributors please add @cin-dy for design

@all-contributors please add @HarryTylenol for design

@all-contributors please add @Member-gunzo for design

@all-contributors please add @gudcks0305 for code


Problem with running program

Description
What steps will reproduce the problem?

I run my program and I use raw_input
I input string and the program will do the command on the code
The program will run twice and I had to input string again

What is the expected output? What do you see instead?
The expected output is just the result of my program
I see the output but the code seemingly run twice
Please provide any additional information below
File "C:\Users\Hasan Wirasno\Anaconda2\lib\site-packages\spyder\widgets\variableexplorer\collectionseditor.py", line 524, in
lambda eid=id(editor): self.editor_accepted(eid))
File "C:\Users\Hasan Wirasno\Anaconda2\lib\site-packages\spyder\widgets\variableexplorer\collectionseditor.py", line 541, in editor_accepted
data = self._editors[editor_id]
KeyError: 488787112L
Version and main components

Spyder Version: 3.2.6
Python Version: 2.7.14
Qt Versions: 5.6.2, PyQt5 5.6 on Windows

Dependencies
pyflakes >=0.5.0  :  1.6.0 (OK)
pycodestyle >=2.3 :  2.3.1 (OK)
pygments >=2.0    :  2.2.0 (OK)
pandas >=0.13.1   :  0.22.0 (OK)
numpy >=1.7       :  1.14.0 (OK)
sphinx >=0.6.6    :  1.6.6 (OK)
rope >=0.9.4      :  0.10.7 (OK)
jedi >=0.9.0      :  0.11.1 (OK)
nbconvert >=4.0   :  5.3.1 (OK)
sympy >=0.7.3     :  1.1.1 (OK)
cython >=0.21     :  0.27.3 (OK)
qtconsole >=4.2.0 :  4.3.1 (OK)
IPython >=4.0;<6.0:  5.4.1 (OK)
pylint >=0.25     :  1.8.2 (OK)

I think this is fixed in our latest version. Please update by opening the Anaconda Prompt, running there
conda update spyder

and try again.

@ccordoba12 We had two other reports, #5526 and #4901, but both were closed as no response. It seems likely to be something specific to the data frame being viewed, but as that was not provided, we could not test it.

@OcaAnanda, could you provide us with a simple code example that reproduces this problem? Thanks!

Closing because of lack of response.


Splash screen animation too fast, App load too slow

Splash screen animation is too fast and then goes to white and App loading is slow
Splash screen should stay up till App is loaded in the backgrounds
Steps to reproduce:

Open an ionic 2 app on an Android Lollypop device

Which Ionic Version?
2.0 BETA 10
Video
https://www.youtube.com/watch?v=bN4Yl3-LNqc

You can configure the splashscreen delay in your config.xml, if you read the splashscreen plugin docs you can also manually remove it when your app has finished loding

this might help?
http://www.codingandclimbing.co.uk/blog/ionic-2-fix-splash-screen-white-screen-issue-14

Hello! Thanks for opening an issue with us! As this seems like more of a support question i will urge that you ask this question on our forum (forum.ionicframework.com). Thanks for using Ionic!


'reset local' should remove locally added files

Recently @flaiker started a discussion in slack about 'reset local' not deleting any objects. And therefore after switching branches and 'reset local' the existing objects from previous branches are marked as new.
I think it would be quite useful if 'reset local' deletes the superfluous objects.
Some questions regarding implementation. Should we ask the user before the objects are deleted? For every object? Any opinions?

I did a first try to implement this feature.
https://github.com/christianguenter2/abapGit/blob/1de786ef7dbc2084c1fe64cdce1544af015bf4f5/src/zabapgit_services_git.prog.abap#L84-L112
Should we extract the logic to a separate method? Where is the right place for the method?
Feedback is appreciated.

ask user: yes. I dont have an opinion on the level, just having the user knowing what is happening is good
please add it as a separate method
it could be nice to have the method somewhere different than in lcl_services_git as it is not core git functionality, perhaps lcl_repo_online, however that class is getting large, hmm

I extracted the method to lcl_repo_online and introduced a popup to ask the user.
https://github.com/christianguenter2/abapGit/blob/fea262fb323497ec65fded9a515619baba0c97c7/src/zabapgit_services_git.prog.abap#L73-L85
https://github.com/christianguenter2/abapGit/blob/fea262fb323497ec65fded9a515619baba0c97c7/src/zabapgit_repo_impl.prog.abap#L324-L368

I did also some further testing. For my purposes it's sufficient. Should I make a pull request?

cool, can you add the number of objects that will be deleted, as information in the popup?

Good idea.

And the popup is now only shown if there are any unnecessary objects.


Fix duplicate addresses and format

SiliconSelf found the fix for the duplicate addresses -- changing Vec<Host> to HashSet<Host> -- and I bumped up the efficiency of the listener thread by replacing its internal Vec<MacAddr> with a HashSet<MacAddr>. If I knew how to do that git thing where a single commit has multiple authors, I would do that in the interest of proper credit.
The thread was already checking for duplicates long before I touched it, so how duplicates ended up in the hosts vector is lost on both of us. Regardless, switching from a list to a set makes the duplicates impossible.
After I finished making changes, I made sure nightly clippy with lints didn't generate any new warnings and then ran rustfmt on the whole project.

LGTM


Which are the expected sbt dependencies to run the JSON example at the README?

I cannot import bench:
import cats.parse.bench.self.JsonStringUtil
My sbt is as folllows:
val scala3Version = "3.0.1"

//lazy val cats = RootProject(uri("https://github.com/typelevel/cats-parse"))

lazy val root = project
  .in(file("."))
//  .dependsOn(cats)
  .settings(
    name := "tupi",
    version := "0.1.0",

    scalaVersion := scala3Version,

    libraryDependencies += "com.novocode" % "junit-interface" % "0.11" % "test",

    libraryDependencies += "org.typelevel" %% "cats-parse" % "0.3.4",

    libraryDependencies += "org.typelevel" %% "jawn-ast" % "1.2.0"
    )

Like many scala projects we don't publish a jar of the benchmarks.
You can check the code out and run them that way.

Ok, thanks.
The issue is actually about the README not providing a self-contained example, probably not a priority at this stage though.

oh, sorry.
If you want to play with that example:
copy this file:
https://github.com/typelevel/cats-parse/blob/main/bench/src/main/scala/cats/parse/bench/self.scala
and add the dawn dependency:
https://github.com/typelevel/cats-parse/blob/bdc11c8936e214d2089f8c673a295fd0e63f923e/project/Dependencies.scala#L11
Let me know if that doesn't work.

@johnynek it works fine when you copy this file.


Fix incorrect depth comparison used to calculate volumetric fog shadowing

Fixes #95785. Added the depth reversal logic that was necessary for proper shadow tests with omnidirectional lights active in fog volumes. #88328 seems to be the one that broke it for now.
Pictures for comparison:
Before:

After:

Thanks! Congratulations on your first contribution!


TypeError in 0.2.7 (not in 0.2.6)

E.g. https://travis-ci.org/fiddur/some-comments/jobs/82571193
When downgrading to 0.2.6 it works as it should.  I haven't debugged more than that yet, coming up later…

Here's the working build (0.2.6) https://travis-ci.org/fiddur/some-comments/jobs/82573166

And the diff: https://github.com/Vincit/objection.js/compare/0.2.6...0.2.7#diff-6e4cbf91ee92d743b8b6cdbd265c532cR366
Key is sometimes a number…
Ok, found the error.  The insert-statement I had for a row with url and siteId also contained a site (defined in relationMapping), but instead of containing the actual site object that also contained the id, so the iterator tried to iterate over the number 2.  I should clean away the bad data, but it was a quite confusing error-message.

You seem to pass and array or string to the ModelBase.prototype.$set method. The method is called from the fromJson method.
My wild quess is that you call fromJson for an actual model, but the model has and an array of strings (or something non-objecy) in a property that is also a the name of one of the relations. If an object given to fromJson method has relations, they are parsed into Model instances. In this case fromJson attempts to parse an array of strings (or something) into an array of Model instances, failing miserably. In 0.2.6 this just produced (weird) valid models. Now it fails since I changed the $set method's implementation.

I will add a check that anything passed to fromJson is an object and throw a descriptive error.

Great, thanks!  I fixed my bad data now; great with a better error message :+1:


feat: gas usage estimation report

Closes #
Introduced changes

Adds required logic to output gas usage estimation of tests

Breaking changes

Checklist

[ ] Linked relevant issue
[ ] Updated relevant documentation
[ ] Added relevant tests
[x] Performed self-review of the code
[ ] Added changes to CHANGELOG.md

@enitrat that's actually a more complex issue I think. From what I see gas_counter is always set to None in run_function at first and then modified in closure, but it does not seem to have any effect...
cc @MaksymilianDemitraszek

then modified in closure, but it does not seem to have any effect...

Yeah that's the conclusion I had too. But the thing is, I tried to compare it with the current implementation of cairo-test, which returns the gas consumption on main. Both of them look very similar in how they handle the invocation of the test functions, however in sn-foundry gas_counter is not assigned a value, but in cairo-test it is.  🤔

Oh, I think I might understand why.
Starknet foundry uses a dependency cairo-* with release 2.1.0, but this gas estimation change is not included in the latest releases and is only available on main. I will try updating the dependencies for cairo-runner and cairo-test-runner, and see if it provides the expected output.
Anyway, this can probably be put on hold until SW adds this commit in a release.

update: I tried to base the Cairo dependencies on the commit that had this feature, but it still didn't work. So I think the difference is in how starknet foundry invokes tests, compared to cairo-test. Cairo test runs tests using run_function_with_starknet_context which takes a parameter of type StarknetState which is passed into the hint_processor. I won't dig further down into it but I guess it's related to gas calculations

@enitrat Sorry for not being top responsive here, had a lot on my plate in the recent days, thank you for persistence in trying to push the task forward 🥇
Generally It was a good idea to compare it with cairo-test, the problem is starknet foundry and cairo test have different execution models, and those will drive different design and implementation decisions behind gas reporting. Differentiation between sierra gas and starknet gas makes things complicated. Cairo test uses sierra gas only and blockifier which starknet foundry uses for contract execution uses the old starknet gas.
Design wise I am kinda against available_gas attribute and I believe gas assertions should be a part of the test control flow, not declarative. Reasonig behind this is that you generally want to assert gas cost of your contract transactions and exclude the costs of the test like setting up calldata.
In the far future I would imagine having something like this
test {
   let result = ContractAResourcesDispatcher.get_balance()
   assert(result.gas_cost < 15555, `too expensive`)
}

Going back to the ground and what we want to build now. I think a good starting point would be to accumulate gas cost of declare, deploy and contract calls inside a test and print it in the result [PASS] path/to/test (estimated gas: 174917) instead of asserting it in any way. This way we would create something useful for the present users until sierra and starknet gases are consolidated, and then we could develop a better and more flexible solution as the one proposed above.
Places worth looking into implementation wise as those may be helpful:
https://github.com/foundry-rs/starknet-foundry/blob/c868a82f97c030374d0b2e3268b9206ad03e648c/crates/cheatnet/src/rpc.rs#L90
https://github.com/foundry-rs/starknet-foundry/blob/c868a82f97c030374d0b2e3268b9206ad03e648c/crates/cheatnet/src/rpc.rs#L806
https://github.com/starkware-libs/blockifier/blob/bf38764a1af0825389179f4df0e9f7e604f94edb/crates/blockifier/src/transaction/transactions_test.rs#L355
We probably want to extend CheatableState with starknet_interactions_gas variable and bump it with every interaction cost. Then print it at the end.

think a good starting point would be to accumulate gas cost of declare, deploy and contract calls inside a test and print it in the result [PASS] path/to/test (estimated gas: 174917)

I agree with the output, however something I don't really understand is why that should be linkeed to a declare/deploy/calls flow. Ideally, I want sn-foundry to be contract agnostic, and to be able to unit tests functions of my code without deploying anything.
There are too many cases where I want to test internal functions that will not be exposed publicly in the contract interface. Solidity is a language whose purpose is to write smart contracts, Cairo is not - and these differences should be taken into account in the way sn-foundry is built.
I think it's one of Cairo's strengths, and where sn-foundry should differ by allowing us to test functions isolated from the starknet environment. I'm just a bit familiar with ethereum foundry, but here if my contract uses a custom add() function, I want to be able to test this function without deploying a contract first.

Then, we will include call_internal calls to the gas calculation, does it make sense?

yep, definitely

Tests having undelying state (and being effectively a contract) are imho confusing

makes sense.

Our plan to workaround this limitation is to introduce call_internal cheatcode which will let users to call all member functions of a contract (and include a dispatcher for it to improve UX).

So I would still need to deploy a contract, right?
For Kakarot, we have very few entrypoints and most of our functionalities are "libraries" that are not exposed externally. Even if we can call internal functions, that would require us to deploy the contract first.
I want, for example, to be able to test my Stack data-structure without interacting with a contract. This is possible in the actual state of SN-foundry. Will it be possible with the design you're thinking about.

I think protostar worked this way, right?

Yes it did, we wanted to change that

For Kakarot, we have very few entrypoints and most of our functionalities are "libraries" that are not exposed externally. Even if we can call internal functions, that would require us to deploy the contract first.

It depends, you will be able to import and run functions, but if your function modifies or reads contract state (storage, caller address etc.) you need it deployed as a contract. Do you think it will be too limiting 🤔 ?

Do you think it will be too limiting 🤔 ?

It is more limiting than having it possible natively, for sure. That's something I found really appreciated about protostar. But as long as it remains possible throug deployment, it should be fine,especially if we have extra features making it easier.
We should continue this discussion in TG, to have more opinions
cc @eikix @jobez

I wouldn't bother about performance too much tbh, there is a lot of work we can do in case it is necessary but right now compilation will be the biggest bottleneck


fraud: implement fraud service

Implemented fraud service on top of fraud interface.

Codecov Report

Merging #811 (3857c1b) into main (aee88c2) will decrease coverage by 1.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
- Coverage   53.03%   51.99%   -1.04%
==========================================
  Files         117      120       +3
  Lines        6760     6910     +150
==========================================
+ Hits         3585     3593       +8
- Misses       2810     2953     +143
+ Partials      365      364       -1

Impacted Files
Coverage Δ

fraud/service.go
0.00% <0.00%> (ø)

fraud/subscription.go
0.00% <0.00%> (ø)

fraud/topics.go
0.00% <0.00%> (ø)

fraud/bad_encoding.go
31.11% <0.00%> (-3.34%)
:arrow_down:

das/daser.go
76.31% <0.00%> (+2.63%)
:arrow_up:

header/core/listener.go
58.49% <0.00%> (+5.66%)
:arrow_up:

ipld/get_shares.go
81.63% <0.00%> (+8.16%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aee88c2...3857c1b. Read the comment docs.


TaxonomyPicker control allows select deprecated/untaggable terms when typing

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!
Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.
Category
[ ] Enhancement
[ x] Bug
[ ] Question
Version
Please specify what version of the library you are using: [     3.5.0    ]
Expected / Desired Behavior / Question
We have in our term set deprecated and untaggable terms set. On the control I have both these options true.
hideTagsNotAvailableForTagging={true} hideDeprecatedTags={true}
The true value works when you pick the terms via the tag-icon

But if you type directly to the control field you are able to find and pick the term

Console.log

I would expect both typing and selecting term via picker would work the same when using those control propeties
Observed Behavior
If you are reporting an issue please describe the behavior you expected to occur when performing the action. If you are making a
suggestion or asking a question delete this section.
Steps to Reproduce
I have following configuration for the control:
<TaxonomyPicker    allowMultipleSelections={false}   termsetNameOrID={this.props.webPartProperties.termSets.reportType.guid}   panelTitle={strings.newReportTypeLabel}   placeholder={strings.newReportTypeDescription}   label={strings.newReportTypeLabel}   context={this.props.context}   onChange={this._onTaxPickerChangeReportTypeProxy}   isTermSetSelectable={false}      required={true}   hideDeprecatedTags={true}   hideTagsNotAvailableForTagging={true}   />
There seems to have been similar issues in past
https://github.com/pnp/sp-dev-fx-controls-react/issues/506
https://github.com/pnp/sp-dev-fx-controls-react/issues/109

Also request this issue to be resolved. Can we know the status on this bug

Hi there!
I've fixed this issue in PR #1354

@kallejar many thanks for reporting the issue.
The PR from @ekapic has now been merged and the fix will be in the beta release shortly. Will also be included in the next main release.


index.html flagged in pen test

Hi,
We have had a web service pen tested recently and the swagger index.html was flagged as not providing the relevant hsts headers.
The endpoints all provide them, and we have used the following snippet to add them:
services.AddHsts(options =>
                    {
                        options.IncludeSubDomains = true;
                        options.MaxAge = TimeSpan.FromDays(securityConfiguration.MaxAge);
                    })
                    .AddHttpsRedirection(options =>
                    {
                        options.RedirectStatusCode = (int)HttpStatusCode.TemporaryRedirect;
                        options.HttpsPort = securityConfiguration.HttpsPort;
                    });

But this doesn't add it in for the index.html page.
We have also tried to use
app = appBuilder.Build();
serviceProvider = app.Services;
apiVersionDescriptionProvider = serviceProvider.GetRequiredService<IApiVersionDescriptionProvider>();
app.SetupSwagger(apiVersionDescriptionProvider, "./Assets/custom-ui.css");
app.SetupSecurity();
await app.RunAsync();

But again, this doesn't apply it to the index.html page. Obviously I know the index.html page can't actually do anything at all, but it would be nice to be able to set this flag to appear on the index.html page itself as we need to clear the medium risk on the pen test.
I did see the other issue logged a few years back, but there didn't seem to be a resolution to the issue, and the suggested fix seemed to only refer to endpoints. (https://github.com/domaindrivendev/Swashbuckle.AspNetCore/issues/1737)

You just need to add HstsMiddleware before swagger UI and that's it.
in your Program.cs do:
app.UseHsts();

// swagger ui

then it will add the header, check the source code it is very simple: https://github.com/dotnet/aspnetcore/blob/main/src/Middleware/HttpsPolicy/src/HstsMiddleware.cs#L76

As noted above, this will likely be caused by ordering of middlewares and static files being placed before the HSTS middleware.
I'd be skeptical of HSTS headers being missing from a Swagger UI page being an actual practical security issue compared to the blanket binary approach taken by most security scanning software. I would go down the route of getting an exemption for the endpoint flagging this problem.
I'm going to close this, but if you can't resolve this with reordering your middlewares, feel free to raise a new issue.


[Public Preview BB] - Data Controller Deployment Wizard to Provide Image Tag Option

Azure Data Studio Version:
Name: Azure Arc
Id: microsoft.arc
Description: Provides deployment and management capabilities for Azure Arc
Version: 0.4.0
Publisher: Microsoft

Version: 1.22.0-rc1 (user setup)
Commit: 403ff6cfec2a0673bfbdb0a0a57eb9b6af023fab
Date: 2020-09-16T01:51:31.696Z
VS Code: 1.49.0
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19041
Steps to Reproduce:
it always assumes the specific image tag and tries to download the image; i am morphing the image tag here as public preview is not out yet and i don't want to show the bits version.
13m         Warning   Failed             pod/bootstrapper-kzcq9    spec.containers{bootstrapper}   kubelet, aks-nodepool1-19803852-vmss000000   Failed to pull image "azurearcdata.azurecr.io/azure-arc-data/arc-bootstrapper:private-xxxx": [rpc error: code = Unknown desc = Error response from daemon: Get https://azurearcdata.azurecr.io/v2/azure-arc-data/arc-bootstrapper/manifests/private-xxxx: unauthorized: Application not registered with AAD., rpc error: code = Unknown desc = Error response from daemon: Get https://azurearcdata.azurecr.io/v2/azure-arc-data/arc-bootstrapper/manifests/private-xxxx-new: unauthorized: authentication required, visit https://aka.ms/acr/authorization for more information.]   15m          4       bootstrapper-kzcq9.16353246ed450830
13m         Warning   Failed             pod/bootstrapper-kzcq9    spec.containers{bootstrapper}   kubelet, aks-nodepool1-19803852-vmss000000   Error: ErrImagePull

Talked with PMs - not needed for public preview but we should look into enabling this to be set for dev/test purposes.

Closing this since it isn't something we plan on working on currently


Uninstalll of SODA fails because it cannot find srm-toolchain installation

Issue/Feature Description:
If the SRM toolchain was not installed earlier, the cleanup fails because it cannot find the dir /opt/srm-toolchain
Why this issue to fixed / feature is needed(give scenarios or use cases):
Cleanup of SODA install fails and is blocked
How to reproduce, in case of a bug:
Install SODA without srm-toolchain
Uninstall now. It will fail at:
TASK [cleaner : Stop and remove Prometheus, Alertmanager, Grafana containers & delete the images] *****************************************************************************************************************
task path: /root/gopath/src/github.com/sodafoundation/installer/ansible/roles/cleaner/scenarios/srm-toolchain.yml:28
Using module file /usr/lib/python2.7/dist-packages/ansible/modules/commands/command.py
 ESTABLISH LOCAL CONNECTION FOR USER: root
 EXEC /bin/sh -c 'echo ~ && sleep 0'
 EXEC /bin/sh -c '( umask 77 && mkdir -p "echo /root/.ansible/tmp/ansible-tmp-1608810546.97-280287734510018" && echo ansible-tmp-1608810546.97-280287734510018="echo /root/.ansible/tmp/ansible-tmp-1608810546.97-280287734510018" ) && sleep 0'
 PUT /tmp/tmp43sp8p TO /root/.ansible/tmp/ansible-tmp-1608810546.97-280287734510018/command.py
 EXEC /bin/sh -c 'chmod u+x /root/.ansible/tmp/ansible-tmp-1608810546.97-280287734510018/ /root/.ansible/tmp/ansible-tmp-1608810546.97-280287734510018/command.py && sleep 0'
 EXEC /bin/sh -c '/usr/bin/python /root/.ansible/tmp/ansible-tmp-1608810546.97-280287734510018/command.py; rm -rf "/root/.ansible/tmp/ansible-tmp-1608810546.97-280287734510018/" > /dev/null 2>&1 && sleep 0'
The full traceback is:
Traceback (most recent call last):
File "/tmp/ansible_H8o7Ja/ansible_module_command.py", line 214, in
main()
File "/tmp/ansible_H8o7Ja/ansible_module_command.py", line 153, in main
os.chdir(chdir)
OSError: [Errno 2] No such file or directory: '/opt/srm-toolchain'
fatal: [localhost]: FAILED! => {
"changed": false,
"failed": true,
"module_stderr": "Traceback (most recent call last):\n  File "/tmp/ansible_H8o7Ja/ansible_module_command.py", line 214, in \n    main()\n  File "/tmp/ansible_H8o7Ja/ansible_module_command.py", line 153, in main\n    os.chdir(chdir)\nOSError: [Errno 2] No such file or directory: '/opt/srm-toolchain'\n",
"module_stdout": "",
"msg": "MODULE FAILURE",
"rc": 0
}
to retry, use: --limit @/root/gopath/src/github.com/sodafoundation/installer/ansible/clean.retry
PLAY RECAP ********************************************************************************************************************************************************************************************************
localhost                  : ok=17   changed=10   unreachable=0    failed=1
Other Notes /  Environment Information: (Please give the env information, log link or any useful information for this issue)

I did a quick check and seems like the uninstall script is running the delete commands even if the srm_toolchain_install is set to false.
I will check and apply the fix.

I just tested by installing on a fresh virtual box.
Steps I followed:

Install only hotpot. No gelato, delfin or SRM toolchain.
Run clean script.
The script ran smoothly and uninstalled everything.

I will need some more information on this to identify the scenario in which this fails.
I will try with installing all the other modules and then try uninstall.

I was able to successfully recreate the issue.
Steps that I followed.

Set install_srm_toolchain to true
Run the clean script.
The issue is that the clean script task checks only for the install_srm_toolchain variable and if it is set to true then runs the clean commands.

Will add the check on whether the folder exists and then run the subsequent commands.


Add support for SOP revision 05

Requires https://github.com/pgpainless/sop-java/pull/18 to get merged first.


Add project URLs to PyPI

It's possible to add project URLs that are shown on PYPI. Possible URL include links to source code, issue tracker, Twitter, Slack, and so on. On PyPI these URLs are shown under "Project links" as seen, for example, at https://pypi.org/project/PyScaffold/. We already have PR #4248 about adding the GitHub URL, but I believe we should add also other URLs. Just need to decide what URLs to use!

GitHub URL was added by PR #4248. Thanks @andriyor for the PR and the idea in general! I'll check what other URLs we could add.

Assuming Tracker is bugs/issues tracking. I was thinking about this link and asking what do we want to accomplish with it. For example I like the term Issues better. But to me that seems like an invitation for any looking for help to post there when instead I think for most items, if not all, we want people to come into Slack to talk about issues or even feature requests. So to avoid filling up issues with support questions I would not call it Issues nor would I put in the Tracker url. Something similar though which might be of interest is what is coming in the next release or milestones. And possible older releases or a change log. It would be great if those were one project url but I don't think Github combines those together.
I would add one for documentation going to http://robotframework.org/robotframework/. Not sure if the current url for Download is of any use since it goes back to the same pypi listing. It doesn't make sense to me to link to the pypi download files url - https://pypi.org/project/robotframework/#files - but instead I think maybe the instruction for installation in the README - https://pypi.org/project/robotframework/#installation.

As for the Slack link, I think it would be helpful on Slack if the invite was combined with the main page. But that would be a feature request to Slack which who knows if that would ever be done. How about a link to the community section on rf dot org instead?

Yes, "Tracker" that I added refers to the issue tracker. Probably "Issues" would be better but it's also a good point that we only want actual bugs and enhancements requests reported there and most of the "issues" people have are actually questions that should be asked on Slack, Forum, or elsewhere. Should it be "Bug Tracker" to make it more explicit it's for bugs? Or should we just omit it altogether? There's a link to GitHub already and most users know GitHub projects have issue trackers.
"Change Log" link would be nice. It either needed to be updated automatically to link to the correct release notes or we needed to have a README at https://github.com/robotframework/robotframework/tree/master/doc/releasenotes to make it possible to have a static link there. That README would need to be updated to contain links to actual release notes. Automatically updating the release notes link isn't any more work than that so perhaps I should do that.
Link to http://robotframework.org/robotframework/ could be added and labeled "Documentation".
The "Download" link is got directly from setup.py download_url. That's kind of a mandatory field and we cannot affect how PyPI handles it. I don't see it pointing back to PyPI too big a problem.
One way to handle "Slack" would be linking to https://rf-invite.herokuapp.com/ and having there a link forward to https://robotframework.slack.com/ for those who already have an account. Do you @emanlove remember who set that invitation page up? We could ask them to update it.

URLs at https://pypi.org/project/robotframework/5.1a1/ look good to me. New can obviously be still added, and existing modified, but I think this issue can be closed.


Nicer Narwhal-Sui error propagation

The error propagation between Narwhal and Sui is not very nice and probably takes more LOC than required. This is an issue that needs to be solved in parallel on the Narwhal and Sui codebase though.

@asonnino is this still useful?

No it is fixed


Option to use bitcoind instead of Esplora

Detailed Description
If a local core instance is available, request fee estimates from bitcoind
Context
No response
Possible Solution
No response

Yes, planning to add this.

PR here if you want to test @RocketNodeLN https://github.com/LN-Zap/bitcoin-blended-fee-estimator/pull/27

Looks good. Can we get an option to disable esplora (currently using <IP_ADDRESS> as the url)?
Also, looks like the fee multiplier does not apply to mempool fees?

Can you check your DM at telegram?


fix(cli): correctly parse clippy like filters "-A rule -D rule"

With the help from

https://github.com/pacak/bpaf/discussions/271

Codecov Report
Patch coverage: 100.00% and no project coverage change.

Comparison is base (772f71f) 92.20% compared to head (80fd300) 92.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #758   +/-   ##
=======================================
  Coverage   92.20%   92.20%
=======================================
  Files         202      202
  Lines       41323    41311   -12
=======================================
- Hits        38101    38091   -10
+ Misses       3222     3220    -2

Files Changed
Coverage Δ

crates/oxc_cli/src/command.rs
72.58% <ø> (-1.75%)
:arrow_down:

crates/oxc_cli/src/lint/mod.rs
44.80% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Epub format for manual

@silverhook:
I really like the fact that the NixOS manual is easy to find and browse and it's very nicely written as well.

What would make the manual even more usable for me would be if there was a usable downloadable file, so I can read it offline comfortably on an e-ink ebook reader.

Therefore I would propose that the NixOS manual (and Nix etc.) should be uploaded in ePUB and PDF format.

PDF is a very good format for documents that you want to send to someone to print and make sure their output is (pretty much) the same as yours. But they don't reflow the text and reading an A4 PDF on a A5 ebook reader is a bit of a pain. So we need a PDF version for printing and something else for reading on different screens.

EPUB is a (flexible and) reflowing open format and intended to be read in browsers, different screens and ebook readers.

It shouldn't be too much of an effort to export to, since ePUB is by definition just HTML, CSS, JavaScript and metadata put into a ZIP.

Ported from https://github.com/NixOS/nixos/issues/237

@domenkozar Can you remove the code block formatting? It makes it very difficult to read the report. Interesting request, though.

done

Done in #15575


Update pipe-operator.md

Clarified the part of Elixir that function arity doesn't matter to.

Thanks @csytan 👍


Added cmake support

@foxcpp i use make much more often than cmake -- do you want to submit a new PR since you use cmake more?  or do you want me to "risk" executing your comments even though i don't understand them as well?

Probably this PR was a mistake, the CMake build system integration is actually totally malfunctioning when dealing with docs building. I'm really sorry, I think you should revert it.

oh too bad !  i like cmake and it seems more clean these days. maybe next year. thanks for tip @HexwellC

@foxcpp  if you get a good CMake support please push a new PR i will merge again

We'll try to collaborate with him to achieve replace plain make with cmake. Using autoconf and plain make in modern world is redundant because it's much harder to adapt and maintain m4 scripts than CMakeLists.txt file. I had to make this broken integration initially due to hot task in other project so I had no time to test it well and generally broke everything. My bad, will fix this and submit a new PR when I'll be sure that it is good enough.

Thank you @HexwellC and @foxcpp I look forward to it
On Sun, Sep 24, 2017 at 4:19 PM, HexwellC<EMAIL_ADDRESS>wrote:

We'll try to collaborate with him to achieve replace plain make with
cmake. Using autoconf and plain make in modern world is redundant because
it's much harder to adapt and maintain m4 scripts than CMakeLists.txt file.
I had to make this broken integration initially due to hot task in other
project so I had no time to test it well and generally broke everything. My
bad, will fix this and submit a new PR when I'll be sure that it is good
enough.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/rudi-cilibrasi/zlibcomplete/pull/8#issuecomment-331747172,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIvuiBWFONvnu9t_AyNkupSXFeGPAchdks5sluN2gaJpZM4PMMQI
.

--
Happy to Code with Integrity : Software Engineering Code of Ethics and
Professional Practice http://www.acm.org/about/about/se-code


Preference to hide suggestions for unstable language features

I'd love to see a preference which hides inline suggestions for nightly only features. I was working with a vec recently and got excited about using drain_filter when it was offered to me. It was only when I hit save and things ran in the background that I got an error about it being unstable!

Realised this is a duplicate of https://github.com/rust-analyzer/rust-analyzer/issues/3021 😅


Update jazzy dependencies & small change in his execution

jazzy needs a param to be used with XCode 7.1 as you can see on the issue https://github.com/realm/jazzy/issues/288.
I add it too to the Gemfile in a development group, so from now it's possible to exec bundle install --with development to include jazzy, or simply bundle install to install without it.

I close this, because Gemfile was removed from repo in https://github.com/pepibumur/SoundCloudSwift/commit/b21eb83d123232628b1037435e857e82e74db509 .


Update sql-server-linux-deploy-pacemaker-cluster.md

Said NodeX although there was no refference to NodeX just NodeN

@charaujo : Thanks for your contribution! The author(s) have been notified to review your proposed change.