Test survey results

Agree that the Open Science definition is now a bit short and I don't think it covers all aspects of open science enough to provide people new to the topic with basic understanding. Also, Open Research would be the more inclusive term

Being open makes it so that publishing in scientific journals is too expensive for the researcher
I have trouble with the phrasing. I understand that you technically are talking about APCs, but that's not the only way to have your papers open. There's preprints, green open access etc... I guess the disadvantage is that this might be too complex for the average researcher.

On page 5, the opion sections at the end might profit from a dropdown. At least in the case of the advantages, I could imagine that it might be one of the ones you already ask about.
The Open Data definition on page 7: Open Data is usually open government data. While these are important, I think memtioning open research data explicitly might be helpful.
Page 8: Using open source software and sharing code and scientific software ate 2 different things in my opinion. In general, the software area is very complicated, I'm not entirely sure covering it the same way as data is helpful.
Personally, I felt that the areas that prevent me from practising Open Science are fairly related to the benefits and disadvantages you asked about in the beginning. I was surprised to see these questions again, maybe closer together it would make more sense?

Hi @pherterich! Thank you so much for taking the test survey - I know you said before how busy you are so @dasaderi and I really appreciate you finding the time to do so. Thank you also so much for this feedback and all the other feedback you have provided about the project in general.
Regarding this feedback:

for the term 'Open Research' -> do you think this should replace Open Science or be part of the Open Science definition in the survey? I agree that people who are new to the topic might not be able to understand what Open Science is from our definition, because as you rightly say it is a bit short, but we also don't want to make it so long that people don't read it. Maybe a way around this it to have a shorter definition in the survey and then a link to more information, so that people who want to read more before filling it in can do so, but those who already understand don't need to. What do you think? maybe this would also help us to not only have OS advocates take the survey.

That's a really good point about the phrasing of OA being expensive and something we need to think about changing, because as you say, people can be open in a variety of ways that aren't only publishing in OA journals.

Your point about Open Data normally referring to Open Government Data - I didn't know that! You can tell that I spend most of my life only doing stuff in the bubble of academia... Thank you for mentioning this because we will be sure to make what we mean explicit.

Your point about the two sections of OS being apart and maybe it would make sense to have them closer together is a very good one. Do you think combining the sections would make it a lot easier for the survey-taker to be able to not have repetition, and to be able to formulate their thoughts on the topic a bit better?

Thank you again for all your extremely useful and valuable feedback!

Hi @amiefairs
I think if you mention somewhere in the intro to your survey that you use open science as synonym to Open Research and that you invite participants from the Social Sciences and Humanities, that should cover it. Open Science is used more often, so it makes sense to stick to what people are more familiar with, but it probably wouldn't hurt to let HSS people know that their input is wanted as well.
I'm not sure about combining the 2 sections on OS. You technically ask for 2 different things, first their impression about barriers etc for Open Science and then their personal opinion. Depending on what you want to get out of it, it could make sense to keep them separate. I would just have them close together and adjust the wording to make clear that the first part is what they think that others think about OS and then their personal opinion. I can imagine though that people not too familiar with the topic will provide very similar answers in both sections.


Converting to ONNX model?

Thanks for sharing this great work!
I've used a few of your ONNX examples before but I'm having trouble figuring out how to "easily convert the Pytorch model by placing the following code in the line #80 of inference.py in the original repository:" with this project.
Can you provide any more detail on how to do this?  Just when I thought I was getting technically proficient at this stuff, I get turned into a noob again :)

Other models require much more changes to the code, so that is why I wrote easy. But, yeah, I should probably delete the "easy" part. The main issue I didn't share any code is because the Pytorch models are in OneDrive, so it makes it hard to share a script for conversion.
Thanks to @PINTO0309, he uploaded the converted models to his repository, so you can download them from there and put them into the models folder (and change the name of the model file in the code). I will update the README later.


RCTFatal + 104 for any error in the project

Hi All,
Any error I have is ending up in an RCTFatal + 104.   React native version .35.  The project will run fine if there are no errors.  But I can literally remove  tag and then Reload the simulator and the crash will hit.     Not only this, but the error screen is all white.  The only way I can see an error is if I select the error row with the mouse and the text turns gray so I can see it.   See screenshot.  Assume two separate issues but its very odd. I am not certain how the project got it this state.     Like I say, no matter what the error it seems like it goes Fatal on me.   Any ideas would be good!

Can you include a snippet of code? Does this happen on 0.36?

Please re-create this issue with a repro case and tested on the latest version, if it is still a problem :)


Update message formats to match documentation

Pull Request
Checklist

[x] Have you read Digital Catapult's Code of Conduct?
[x] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.

PR Type
Please delete options that are irrelevant.

[ ] Bug Fix
[x] Chore
[ ] Feature
[ ] Documentation Update
[ ] Code style update (formatting, local variables)
[ ] Breaking Change (fix or feature that would cause existing functionality to change)

Linked tickets
https://digicatapult.atlassian.net/browse/VR-235
High level description
Modifies query format to be more similar to that in the veritable documentation
Detailed description
Note this does not completely fix the format of the DRPC messages. In particular I have not yet:

implemented createdTime or expiresTime
removed quantity

These will happen in a future PR.
Also fixes several bugs:

Fix public url on Bob and Charlie personas in docker compose
Fix mix up between scope3 request/response views
Fix status bug on query list and credential list pages

Describe alternatives you've considered
I could have left this more loosely typed and not fixed the above issues. I passed on that
Operational impact
This will invalidate all existing queries and delete them from deployed environments. As we only have the demo environment this should be fine
Additional context
None

@Ellenn-A
Uploading Screen Recording 2024-10-30 at 19.43.46.mov…


Mouse enter/leave events for windows

In order to help the user determine where the mouse is, the runtime could send mouse enter/leave events per window so that it is clear which window the mouse is currently in.
The problem with the device system is that it does not know anything about windows so that information can not be retrieved through the device system.

Works nice with imgui objects per window now. Imgui objects in the app class are only updated if the mouse is over the window.


Image viewport too small, funky pan and zoom.

Hi, I'm having a little problem that I haven't been able to solve. If the image that I put in the SubSamplingScaleImageView is smaller than the screen, then the whole image container is apparently scaled down to the size of the image. Then if you pan or zoom some of the image just goes outside the invisible bounds and is not shown at all. It's hard to explain so I'll just give you some screenshots.
Here's the image initially:

Here's the image when panned:

And here's the image when zoomed in a bit:

Is there a work-around to make the image container bigger, preferably the size defined in the layout XML?

It's hard to see what's happening here because I don't know what the bounds of the view are, what the bounds of its parent are, or what your layout XML looks like. I think you just need to check your layout because this doesn't seem to be a bug with the view.

They're set to match_parent to make it take up the whole screen. Somehow, however, the view gets resized to wrap_content.

<com.davemorrissey.labs.subscaleview.SubsamplingScaleImageView
    android:id="@+id/imageView"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:visibility="gone"
/>

<ProgressBar
    android:id="@+id/progressBar"
    style="?android:attr/progressBarStyleLarge"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:visibility="visible"/>

Try using Hierarchy Viewer to find the boundaries of each element, or for a quick and dirty method, put a background color on each element to see where it is.

Did you manage to solve this?

If I remember correctly I wasn't able to make it work 100% to my
satisfaction. I'm no longer working on the project so I can't double check.
Thanks for your help anyway.
Janne
On Wed, 1 Nov 2017, 14:42 davemorrissey<EMAIL_ADDRESS>wrote:

Did you manage to solve this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/davemorrissey/subsampling-scale-image-view/issues/339#issuecomment-341095850,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALMYFhkCVf2e7kBzDzaVexBCEXJmqnuMks5syGdRgaJpZM4Owh7y
.


✨ Enhancing Website Loading Experience with Loading Animation 🚀

Issue Description
Problem: 🚀
The website currently displays a static "loading...." text during the loading phase, which isn't visually engaging. This issue aims to replace it with a loading animation to enhance the user experience.
Background: 🌐
Users expect a visual loading animation when accessing our website.
Video Reference:
Watch Video

I am interested to work on this issue

You can start to work on this issue: @adityakhattri21  Happy hacking ⚡

@adityakhattri21, you can make use of websites like CssLoader to incorporate loading animations into your web design. 💻✨

Sure I will look into this

PR linked with the issue #12

Can you close this issue as you have merged the PR


Fix4058 Solve bug at whitelist test in no-implicit-dependencies rule.

PR checklist

[x] Addresses an existing issue: #4058
[x] New feature, bugfix, or enhancement

[x] Includes tests

[x] Documentation update

Overview of change:
Improve whitelist test to check for path such as '@srcinno-implicit-dependecies` rule.
Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

[bugfix] Improve whitelist test in no-implicit-dependencies rule.

Closing per discussion here and in #4058. Thanks folks!


find_prefixes/2 always returns an empty result set

Not entirely sure weather this is me misusing it but I fail to get find_prefixes/2 to return any data other then an empty list.
3> T1 = btrie:append(<<"this is a test year really!">>, t, btrie:new()).
{116,116,{{<<"his is a test year really!">>,[t]}}}
4> btrie:find_prefixes(<<"this">>, T1).
[]
5> btrie:find_prefix(<<"this">>, T1).
prefix

As discussed on IRC, you wanted btrie:fetch_keys_similar(<<"this">>, T1).

sorry for not closing it myself, got squirrel-ed ...


Modifying an already existing file previously opened with APP and writing same string to different cells.

Describe the bug
I create a new file from scratch using the Numbers App and close the App. I open the same file again using numbers-parser (Document('./test.numbers')) and write the same string such as "TEST" to multiple rows (it must be a string). Now I open the file with Numbers App again and try to modify one of the rows that I previously wrote with numbers-parser. All the rows that were written with the same string will now turn blank! They loose their value as if they were "linked" in the numbers document. Also, if the file is then saved in the Numbers App it won't be able to be opened again using Document('./test.numbers').
To Reproduce

Create a new blank spreadsheet using Numbers App and save it as 'test.numbers'
Run Python code below
Open ./test.numbers with Numbers App
Modify any cell that contains "TEST"

name = "./test.numbers"
doc = Document(name)
sheet = doc.sheets["Sheet 1"]
table = sheet.tables["Table 1"]
for i,d in enumerate(range(10)):
    table.write(i,1,"TEST")
doc.save(name)

Expected behavior
When I re-open the numbers file with the Numbers App I should be able to only modify the cell that I intend to modify with my input, but in reality all the cells that have the same string value will turn blank.
Attachments
can't attach a numbers file but would work with any file that has been created or even opened with the Numbers App.
Additional information
4.10.3
In addition, once the document is corrupted by point 4) and is saved from the Numbers App, the next time it is attempted to open it with the numbers-parser function Document(name), the function will fail. Can send traceback in another comment if needed.

I am struggling to reproduce this. I used this code:
def test_issue_79(configurable_save_file):
    doc = Document("tests/data/test-issue-79.numbers")
    doc.add_style(name="Changed Cells", bold=True)
    table = doc.default_table
    for row in range(2, 12):
        table.write(row, 0, table.cell(1, 0).value, style="Changed Cells")
        table.write(row, 1, table.cell(1, 1).value, style="Changed Cells")
    doc.save(configurable_save_file)
    doc = Document(configurable_save_file)
    table = doc.default_table
    assert all([table.cell(row, 0).value == table.cell(1, 0).value for row in range(2, 12)])
    assert all([table.cell(row, 1).value == table.cell(1, 1).value for row in range(2, 12)])

Where tests/data/test-issue-79.numbers was created by Numbers and has a table like this:

Test 1
Test 2

FOO
BAR

I used styles so it's clear which cells are changed. For each column, the original value is retained.
Strings in Numbers are only stored once but if the existing data cells are untouched then their references to this strings should be retained.
Are you able to attach an example doc?

I do replicate it on my side using your exact code! Your code is generating a corruptible file for me.

Open, using the Numbers app, the file saved with "configurable_save_file".
Input anything on any on any other FOO or BAR cell (press enter to input the info)
If you modified a FOO cell, all above and below FOO cells values disappear (if you don't see them disappear they will disappear once you double click them.
If you modified BAR, all above and below BAR cells values disappear.

I wanted to attach a numbers before but .numbers were not allowed if I remember correctly. However, your method of generating the corruptible file does reproduce my issue.
I can maybe try to record the screen show better/

I will take another look. I was running off the main branch rather than the release.

But you can zip broken files and attach too

You are right, sorry.
In this archive I bundled a video recording and the corrupted file in question.
Archive.zip
FTY I'm running:
Python 3.9.6
numbers-parser 4.10.3, main branch, SHA 99c86a9

That helped - I missed the step of reloading in Numbers and trying to edit. The reference counting of strings should now be correct in v4.10.4.

4.10.4 fixes the issue for me! Thanks a bunch!


Fix check for process in style warning

IIRC next used to inject process.env also for the browser. But it seems it doesn't do that anymore?
Not sure. But would be good to get this in quickly nevertheless as it breaks production builds of components.


Debian/Ubuntu package?

Please, thanks.

It's on my TODO list. I've been working on a 2.0 version on and off. I'll do this for that release.


Build failure: emacs29-macport

Steps To Reproduce
Steps to reproduce the behavior:

build emacs29-macport

Build log
error: builder for '/nix/store/cawm1bdc0gb9gz2ya20za9fy2niz6jla-emacs-mac-macport-with-packages-29.1.drv' failed with exit code 1;
       last 1 log lines:
       > cp: cannot stat '/nix/store/63b32jd27qy6kz3mf3114w2qss66w3xy-emacs-mac-macport-29.1/Applications/Emacs.app/Contents/Info.plist': No such file or directory
       For full logs, run 'nix log /nix/store/cawm1bdc0gb9gz2ya20za9fy2niz6jla-emacs-mac-macport-with-packages-29.1.drv'.

Additional context
The emacs is installed using home-manager on MacOS
{ config, pkgs, ... }:
let
  emacsPackage = pkgs.emacs29-macport;
in
{

  programs.emacs = {
    enable = true;
    package = emacsPackage;
    extraPackages = epkgs: [
      ...
    ];
  };
}

Reverting NixOS/nixpkgs@f6a6dc8 back to NixOS/nixpkgs@2160abc fixes the problem.
{ config, pkgs, ... }:
let
  workingPkgs = import (pkgs.fetchFromGitHub {
    owner = "NixOS";
    repo = "nixpkgs";
    rev = "2160abc3eddbe826b08bcffdb3758763b093f254";
    sha256 = "sha256-65gZ8Fa4EIMGOu5k0+dNiRi/9v2x+M9zDgly7fvDVa4=";
  }) {
    system = "x86_64-darwin";
  };
  emacsPackage = workingPkgs.emacs29-macport;
in
{

  programs.emacs = {
    enable = true;
    package = emacsPackage;
    extraPackages = epkgs: [
      ...
    ];
  };
}

Notify maintainers
@AndersonTorres
Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-darwin"`
 - host os: `Darwin 22.6.0, macOS 10.16`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.17.0`
 - channels(user): `"darwin"`
 - channels(root): `"nixpkgs"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

Well, I don't have machine to test Darwin things.
But, is this a home-manager related thing? Have you tried to run a nix-shell?

is this a home-manager related thing?

I am not sure, but it surely stopped working after NixOS/nixpkgs@f6a6dc8 .
Please also look at this file listings below 👇
✅ Working Emacs.app

/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/bin
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/bin/ctags
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/bin/etags
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/bin/ebrowse
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/bin/emacs-29.1
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/bin/emacs
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/bin/emacsclient
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/MacOS
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/MacOS/Emacs
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/he.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/en_AU.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/ar.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/el.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/uk.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/English.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/English.lproj/InfoPlist.strings
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/es_419.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/es_MX.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/zh_CN.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/Dutch.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/pt_BR.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/da.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/document.icns
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/sk.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/pt_PT.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/German.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/ms.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/sv.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/cs.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/ko.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/no.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/hu.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/zh_HK.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/Spanish.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/tr.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/pl.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/zh_TW.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/en_GB.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/French.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/vi.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/ru.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/fr_CA.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/fi.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/id.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/th.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/pt.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/ro.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/Japanese.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/Emacs.icns
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/hr.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/hi.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/Italian.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Resources/ca.lproj
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/Info.plist
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/Applications/Emacs.app/Contents/PkgInfo
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/share
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/share/man
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/share/info
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/share/icons
/nix/store/4i36ghfh9cwgrasx7923zx1s7lwf61mp-emacs-mac-macport-with-packages-29.1/share/applications

❌ Latest Emacs.app

nix build nixpkgs#emacs29-macport

> find result/Applications/Emacs.app/

result/Applications/Emacs.app/
result/Applications/Emacs.app/Contents
result/Applications/Emacs.app/Contents/MacOS
result/Applications/Emacs.app/Contents/MacOS/Emacs.sh
result/Applications/Emacs.app/Contents/Resources
result/Applications/Emacs.app/Contents/Resources/document.icns
result/Applications/Emacs.app/Contents/Resources/Emacs.icns
result/Applications/Emacs.app/Contents/native-lisp
result/Applications/Emacs.app/Contents/PkgInfo

It seems that there is fewer files now in the output for whatever reason?

I'm having the same issue on darwin with emacs28-macport

Running git bisect run sh -c 'nix-build -A emacs28-macport && fd . result/Applications/Emacs.app |rg Info.plist between the HEAD and ae4e2e8676af606cb5c38f9f51e21f6053e41f10 yields this as the breaking commit:
running 'sh' '-c' 'nix-build -A emacs28-macport && fd . result/Applications/Emacs.app |rg Info.plist'
/nix/store/jkdbjl02k2k45gp4kkqjg3cgvalrbkrp-emacs-mac-macport-28.2
f607a7851619a6efda5f7c57f0345018a3ea403c is the first bad commit
commit f607a7851619a6efda5f7c57f0345018a3ea403c
Author: Andrew Pan<EMAIL_ADDRESS>Date:   Tue Aug 29 12:52:53 2023 -0500

    emacs-macport: build on LLVM 14

    - Build on `apple_sdk_11_0` to support `aarch64-darwin`
    - Add frameworks required for building on newer SDKs
      - `Accelerate`, `UniformTypeIdentifiers`
    - Include header to work around `CF_NOESCAPE` issue circa LLVM 7.0

 pkgs/applications/editors/emacs/default.nix        |  6 ++---
 pkgs/applications/editors/emacs/generic.nix        | 13 +++++++--
 .../editors/emacs/macport_noescape_noop.h          | 31 ++++++++++++++++++++++
 pkgs/top-level/all-packages.nix                    |  2 +-
 4 files changed, 46 insertions(+), 6 deletions(-)
 create mode 100644 pkgs/applications/editors/emacs/macport_noescape_noop.h
bisect found first bad commit

Invoking @tnytown

Closed by #253041. Also built on Hydra: https://hydra.nixos.org/job/nixpkgs/trunk/emacs29-macport.x86_64-darwin

@wegank I think the issue we're concerned about is still not fixed. Info.plist is missing and emacs{28,29}-macport is incorrectly built.


bookmark per instance but shared by default

I will add the fact that each browser can have instance specific bookmarks and still that we can add global ones.

fix


[vcpkg] Fix bullet lists for integration.md on readthedocs.io

Fix for markdownlint rule MD032 - Lists should be surrounded by blank lines
Describe the pull request

What does your PR fix? Fixes #

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

/azp run

Thanks for your contribution!


Cancel and close button of dialog box in Indentation Options is not working

You can go to the indentation options by following the below options.

Bug
It will open a dialog box -- >
-- >Cancel button of the dialog box is not working
-- >Even after closing the dialog box it is still indenting the text

Enhancement
Change the UI of the text edit more visible.

Completed on commit number :-> 6f90a6b


Support for AWS Instance Profiles in the s3 plugin

Would it be possible to add support for authenticating to S3 using EC2 instance profiles as an alternative to using  access_key_id and secret_access_key for the s3 plugin?

Instance profiles overview: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/iam-roles-for-amazon-ec2.html
Retrieving the creds from the env: https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_use_switch-role-ec2_instance-profiles.html
Using the retrieved creds: https://docs.aws.amazon.com/IAM/latest/UserGuide/id_credentials_temp_use-resources.html
Mentioned this + some possible concerns in shield slack, will summarize the outcome of that discussion here

Merged in #423


[Wave Collect] Categories help page

Publish Date - May 1
Draft

I'm ready to be assigned!

Draft shared with you, Ren :)

@ren-jones Love your edits, it looks great! Let me know if I can help with publishing or anything else

This is published and live on the site. @ren-jones we can close this, right?


ZoneMinder - Alarm status API call failed for monitor

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version): 0.44.1
Python release (python3 --version): 3.5.2
Component/platform: ZoneMinder
Description of problem: About every 30 seconds, I get the following in the logs:
2017-05-12 16:44:01 WARNING (Thread-3) [homeassistant.components.camera.zoneminder] Alarm status API call failed for monitor 1
Expected: TO find out what is affected and how to stop the error from coming through
Problem-relevant configuration.yaml entries and steps to reproduce:
##Camera
camera:
  - platform: zoneminder

#ZoneMinder Cameras
zoneminder:
  host: !secret zm_ip_address
  username: !secret zm_username
  password: !secret zm_password
sensor:
  - platform: zoneminder

Additional info:
I am running ZoneMinder version 1.30.0
The camera image is visible for me in the interface
Event count and camera status both show correctly.
I know that there have been tickets  on issues with ZoneMinder and the last release got rid of the previous error being logged, but now I am getting this new one. Any insight into how to correct would be greatly appreciated.
Thanks for all that you guys do!!

I think #7589 will fix this. It would be great if you could test it.


Added typings file

Added a typings file for TypeScript users.
Edit: I forgot to add the classes in the typings file

This change is definitely overdue, I'm thinking at this point a typings file is going to be easier than my full TS re-write as the types can be made a little more explicit and less generic.
Does the empty typings file by itself just get rid of the missing types error? Does it default all the types to any, or do they not exist without definition?
Happy to pull this in as-is and just not publish the file until the types are done - most of which I have or are pretty straight forward. I've been tempted to change the way the defaults work too, to make the types a bit easier.

Adding the typing file and declaring the module fixes the issue, but then since you’re not exporting anything there is nothing to import, so you’ll have to export everything with their types.

Adding the typing file and declaring the module fixes the issue, but then since you’re not exporting anything there is nothing to import, so you’ll have to export everything with their types.

This is what I had expected would happen.
So does this typing file really do anything on it's own? The warning might go away, but you still can't use anything without defining the types. I'll hopefully give a fully-fleshed typing file a shot some time soon

Adding the typing file and declaring the module fixes the issue, but then since you’re not exporting anything there is nothing to import, so you’ll have to export everything with their types.

This is what I had expected would happen.
So does this typing file really do anything on it's own? The warning might go away, but you still can't use anything without defining the types. I'll hopefully give a fully-fleshed typing file a shot some time soon

It basically gives the JavaScript stuff types that TypeScript can detect, not sure if setting the skipLibCheck in a tsconfig.json file will work, haven't tried yet.


Warranty Coverage

Hi All
(Sorry for mass of tickets, but testing out the new version)
On the client details page, what am i meant to see in the warranty widget ?
See image below, is this correct? or is there meant to be something displayed under warranty coverage.
Thanks

Do you see any changes when you press 'Recheck Warranty Status'?

nope, I am behind a firewall but have allowed the correct URL access
What should i expect?
On Thu, Jul 16, 2015 at 9:10 PM, Arjen van Bochoven <
<EMAIL_ADDRESS>wrote:

Do you see any changes when you press 'Recheck Warranty Status'?
—
Reply to this email directly or view it on GitHub
https://github.com/munkireport/munkireport-php/issues/272#issuecomment-122074251
.

--
Adam Barnett

Do you think the firewall prevents your query? Could you use a prosy?
https://github.com/munkireport/munkireport-php/blob/d6a62fcbd31f45bf0cb669025452204764880763/config_default.php#L349-L364

I have it set to use a proxy, and i can see the requets are being sent ok to selfsolve.apple.com
i have allowed the following url selfsolve.apple.com,support-sp.apple.com,km.support.apple.com

You only have to allow https://selfsolve.apple.com on port 443

That is what is open.
on the old version of MRP it did show the correct status
On Fri, Jul 17, 2015 at 10:00 AM, Arjen van Bochoven <
<EMAIL_ADDRESS>wrote:

You only have to allow https://selfsolve.apple.com on port 443
—
Reply to this email directly or view it on GitHub
https://github.com/munkireport/munkireport-php/issues/272#issuecomment-122222794
.

--
Adam Barnett

I don't believe the warranty lookup code has changed.. Are you sure your database is writable?

Yup, the DB is writeable, all hosts are checking in and i can look at the warranty table and see entries

And if you lookup this particular serial number on the apple website, does it give you results?
https://selfsolve.apple.com/agreementWarrantyDynamic.do

It says it in warranty
if i choose listings -> warranty and search for a machine that i know if
in warranty it says warranty status 'Supported'  in green
It seems just the summary page is not showing it
On Mon, Jul 20, 2015 at 5:57 PM, Arjen van Bochoven <
<EMAIL_ADDRESS>wrote:

And if you lookup this particular serial number on the apple website, does
it give you results?
https://selfsolve.apple.com/agreementWarrantyDynamic.do
—
Reply to this email directly or view it on GitHub
https://github.com/munkireport/munkireport-php/issues/272#issuecomment-122950171
.

--
Adam Barnett

Ok, could you clear localStorage?
https://github.com/munkireport/munkireport-php/issues/265#issuecomment-121018811

Clear the storage, I tired it two different browsers ( Chrome and FF, on
Linux ) and still the same
On Mon, Jul 20, 2015 at 6:36 PM, Arjen van Bochoven <
<EMAIL_ADDRESS>wrote:

Ok, could you clear localStorage?
#265 (comment)
https://github.com/munkireport/munkireport-php/issues/265#issuecomment-121018811
—
Reply to this email directly or view it on GitHub
https://github.com/munkireport/munkireport-php/issues/272#issuecomment-122963169
.

--
Adam Barnett

Any messages in the javascript console?

I think I see what's happening, could you run
https://your_addrss/index.php?/clients/get_data/SERIAL_NUMBER
substituting SERIAL_NUMBER with the serial number of the machine and your_addrss with your munkiserver address.
You should get a JSON response, please find the entry that says "status" and post the value here.

here is the response
"status":"Supported"
On Tue, Jul 21, 2015 at 10:46 AM, Arjen van Bochoven <
<EMAIL_ADDRESS>wrote:

I think I see what's happening, could you run
https://your_addrss/index.php?/clients/get_data/SERIAL_NUMBER
substituting SERIAL_NUMBER with the serial number of the machine and
your_addrss with your munkiserver address.
You should get a JSON response, please find the entry that says "status"
and post the value here.
—
Reply to this email directly or view it on GitHub
https://github.com/munkireport/munkireport-php/issues/272#issuecomment-123244081
.

--
Adam Barnett

Strange, could you post the rest of the JSON (without the serial_number)?

[{"id":"251","serial_number":"removed","hostname":"trigger","machine_model":"MacBookPro11,3","machine_desc":"MacBook
Pro (Retina, 15-inch, Late
2013)","img_url":"","current_processor_speed":"2.6
GHz","cpu_arch":"x86_64","os_version":"100905","physical_memory":"16","platform_UUID":"D69C7977-B600-5CEF-8DEE-6466B5C00185","number_processors":"4","SMC_version_system":"2.19f3","boot_rom_version":"MBP112.0138.B02","bus_speed":"","computer_name":"trigger","l2_cache":"","machine_name":"MacBook
Pro","packages":"1","cpu":"Intel(R) Core(TM) i7-4960HQ CPU @
2.60GHz","console_user":"srl","long_username":"Steve
Lynn","remote_ip":"<IP_ADDRESS>","reg_timestamp":"1405522409","timestamp":"1437485354","uptime":"106820","machine_group":"0","purchase_date":"2014-05-12","end_date":"2017-05-12","status":"Supported","users":"admin
srl","TotalSize":"999116767232","FreeSpace":"739808116736","SMARTStatus":"Not
Supported","CoreStorageEncrypted":"0"}]
On Tue, Jul 21, 2015 at 5:02 PM, Arjen van Bochoven <
<EMAIL_ADDRESS>wrote:

Strange, could you post the rest of the JSON (without the serial_number)?
—
Reply to this email directly or view it on GitHub
https://github.com/munkireport/munkireport-php/issues/272#issuecomment-123385406
.

--
Adam Barnett

Displays fine on my side.. Could you check the javascript console of your browser for errors?

This is in the console on chrome
currentLng set to: en i18next.min.js:5
loaded: /munkireport/assets/locales/en.json i18next.min.js:5
Uncaught TypeError: object is not a function
index.php?/clients/detail/C02PF0NEG3QC:6158
(anonymous function) index.php?/clients/detail/C02PF0NEG3QC:6158
j jquery.js:2
k.fireWith jquery.js:2
x jquery.js:4
(anonymous function)
On Tue, Jul 21, 2015 at 5:25 PM, Arjen van Bochoven <
<EMAIL_ADDRESS>wrote:

Displays fine on my side.. Could you check the javascript console of your
browser for errors?
—
Reply to this email directly or view it on GitHub
https://github.com/munkireport/munkireport-php/issues/272#issuecomment-123392556
.

--
Adam Barnett

I just pulled in your latest change
commit a13d9e6ac5c1ff2c5c60b6a178e003bbc0683e7e
And it fixed it, thanks
On a side notes( i can open a new ticket if you want ) but is there a way
to curl the json outputs?
I tired and got 'No authorised'
On Tue, Jul 21, 2015 at 5:29 PM, Adam Barnett<EMAIL_ADDRESS>wrote:

This is in the console on chrome
currentLng set to: en i18next.min.js:5
loaded: /munkireport/assets/locales/en.json i18next.min.js:5
Uncaught TypeError: object is not a function
index.php?/clients/detail/C02PF0NEG3QC:6158
(anonymous function) index.php?/clients/detail/C02PF0NEG3QC:6158
j jquery.js:2
k.fireWith jquery.js:2
x jquery.js:4
(anonymous function)
On Tue, Jul 21, 2015 at 5:25 PM, Arjen van Bochoven <
<EMAIL_ADDRESS>wrote:

Displays fine on my side.. Could you check the javascript console of your
browser for errors?
—
Reply to this email directly or view it on GitHub
https://github.com/munkireport/munkireport-php/issues/272#issuecomment-123392556
.

--
Adam Barnett

--
Adam Barnett

Not sure why your issue was fixed, it was probably fixed in an earlier commit.
As for getting the client info via curl, you first have to authenticate and store the session cookie:
curl --cookie-jar /tmp/cookie-jar -F 'login=root' -F 'password=root' http://example.com/index.php?/auth/login/

and then use that cookie to retrieve the JSON
curl --cookie /tmp/cookie-jar http://example.com/index.php?/clients/get_data/SERIAL_NUMBER


Consider custom config file path in options

You added in 1.2.0 a way to define a custom config file path using the loader query.
But if you have two different loaders using postcss, i'll have to define config query param for each.
Can you consider defining a global config custom file path from loader.options.postcss ?

Custom config path is a private API for rare cases.
You should put PostCSS config somewhere in style files path. Babel has no custom path at all.
Custom config path is bad practice because of:

Other tools (IDE, linters, etc) will not understand custom config path automatically.
Other developers could miss config too.

In this case, I am not big fan of improving this feature.
What your use case why you need custom config path?

I agree with you, especially point 1.
But I have a lot of files : webpack (x4), eslint, postcss, styelint, karma, protractor, etc. So i'm using a config dir to organize it a bit.
ESLint is implementing this feature https://github.com/MoOx/eslint-loader#options

@jrmlstfMt why not put config files to root? Do you have ration reason for separated dir? :)

No more rational than putting files in a directory to keep them organized. Which is why directories exists I guess ;-)

BTW, you could store your PostCSS config in package.json to reduce config files in root.

Yep package.json is a solution. But less powerful than a js function.
Having a .config/* dir in project root is a good convention I agree.
Maybe this kind of convention should be supported by the guys behind
https://github.com/davidtheclark/cosmiconfig ?

Hey @ai what does the package.json config look like?

@jrmlstfMt unfortunately, Babel developers did not support .config/ idea (I asked them in prev. week)

@CrashyBang https://github.com/michael-ciniawsky/postcss-load-config#packagejson

hey @ai chhers


[Flaky] - Fixed flaky testing in cdi/AnnotatedTypeWrapperTest

Following this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a GitHub issue filed
for the change (usually before you start working on it).  Trivial changes like typos do not
require a GitHub issue.  Your pull request should address just this issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] Format the pull request title like [#XXX] - Fixes bug in SessionManager,
where you replace #XXX with the appropriate GitHub issue. Best practice
is to use the GitHub issue title in the pull request title and in the first line of the commit message.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] add fixes #XXX if merging the PR should close a related issue.
[x] Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
[x] Committers: Make sure a milestone is set on the PR

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.
If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

[x] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
[ ] In any other case, please file an Apache Individual Contributor License Agreement.

Flakiness
Nondex was used to check and locate the flakiness in the test. The test can be reproduced using the following command:
mvn install -pl support/cdi -am -DskipTests
mvn -pl support/cdi test -Dtest=org.apache.shiro.cdi.AnnotatedTypeWrapperTest#removeAnnotations
mvn -pl support/cdi edu.illinois:nondex-maven-plugin:2.1.1:nondex -Dtest=org.apache.shiro.cdi.AnnotatedTypeWrapperTest#removeAnnotations

Issue
The test checks that if there is no Annotation in the RequiresGuest class and there is Annotation in SessionScoped class. It retrieves these classes by calling getDeclaredAnnotations method and fix indexing on the array returned. This creates the problem. Here is the implementation of  getDeclaredAnnotations :
public Annotation[] getDeclaredAnnotations() {
     return AnnotationParser.toArray(this.annotationData().declaredAnnotations);
}
// this.annotationData().declaredAnnotationsdeclaredAnnotations is a map
Map<Class<? extends Annotation>, Annotation> declaredAnnotations = ....

Since the array is created from a hashmap, the order of elements in the output of getDeclaredAnnotations is not determinstic. Therefore, the fix indexing creates flakiness.
Fix
Since only SessionScoped  and RequiresGuest are tested, those 2 classes are specificly extracted from the array instead of using indexing.

@wang3820 Can you please squash the commits? Thank you!

@wang3820 I have looked a little deeper into this. I believe it's a false positive actually.
The Map involved is actually an instance of LinkedHashMap so the order will never change.
Let me know if you still want me to merge this PR or just close it.
Thank you.

@wang3820 I have looked a little deeper into this. I believe it's a false positive actually. The Map involved is actually an instance of LinkedHashMap so the order will never change.
Let me know if you still want me to merge this PR or just close it. Thank you.

Let me look deeper into this too. Nondex should never shuffle order of elements in a LinkedHashMap

Let me look deeper into this too. Nondex should never shuffle order of elements in a LinkedHashMap

Even so, your change makes it obvious what is going on (e.g. looking for a specific annotation class vs just grabbing one by index)

The other issue is that the test uses indexes in the whole code, not just this piece. Do we want to change the whole test to be consistent?

@wang3820 I have looked a little deeper into this. I believe it's a false positive actually. The Map involved is actually an instance of LinkedHashMap so the order will never change.
Let me know if you still want me to merge this PR or just close it. Thank you.

Let me look deeper into this too. Nondex should never shuffle order of elements in a LinkedHashMap

It appears that the test is no longer flaky. I think I was testing on a older version.

The other issue is that the test uses indexes in the whole code, not just this piece. Do we want to change the whole test to be consistent?

I think it's a good idea to change the whole test. This way the test is more readable.

@wang3820 are you willing to take that on?

@wang3820 are you willing to take that on?

Yes.

@bdemers @lprimak I have changed all the tests so it is consistent.
I am rather new to this so I would really appreciate any suggestions!

@wang3820 Awesome job! Thank you!
I will squash the commits and merge

Thanks @wang3820!


Update evdi_modeset.c for Linux kernel 4.5

Linux kernel 4.5 removes the format parameter from drm_dev_set_unique. The change adds an elif for any kernel > 4.5.0.

This will also need to include changes for drm_encoder_init(), which adds a name parameter. I will close this PR and reopen when I have that parameter included.


Improve zsh startup time

For some environments, zsh startup is painfully slow (~ 4sec), while it is around 1-2 sec on average over different environments. Why is it so slow? Is the zplug responsible for this?

We should often clean ~/.zcompdump and ~/.zplug/zcompdump, if they are growing too huge.

24b38d5: Switched to zgen, no more zplug.
/cc @bckim92 @shastakr


POC: Project Statistics in Fusion

Graph and Layout

POC branch:
https://github.com/BlueBrain/nexus-web/tree/POC-Project-stats

Duplicate


opening the prompt as admin

windows terminal looks good so far, but please add function to open the ps, wsl, cmd sessions as admin as well as root for wsl inside the windows terminal after opening it
and also it displays the full path of the respective session in the tab change it too

Please search before filing issues. There's a bunch of issues for "it displays the full path of the respective session in the tab change it too", #608 is the primary, and also tracking this is a bucket of stuff in #1375.
Please don't file more than one problem per issue, it makes it really hard for us to track issues and resolve them.
"add function to open the ps, wsl, cmd sessions as admin as well as root for wsl inside the windows terminal after opening it" is already #1032 #691 #632 #2200 #146


Page doesn't not scale well when resizing

Environment
Kubernetes
Version
0.11.5
Describe the problem
The dashboard doesn't seem to handle scaling properly. The tiles don't scale uniformly and the layout constantly changes when I decrease the width of my browser. This also makes the dashboard challenging to use in mobile views since the layout is very different from the one defined in the user's configuration. See attached screenshots below for what this looks like.
Here's my thoughts on what the UX should be. I would expect the icons to scale uniformly until they hit a critical point when they are too small (e.g. mobile layout). At that point the layout should change into an icon feed or a grid. The current implementation seems to adjust the layout in a responsive fashion. I don't think this is a good approach since as a user, I expect my custom layout to be consistent across web browser window sizes. Once the window size is too small (e.g. mobile device) I would expect a standard mobile layout that is again consistent across resizing.
You can see this pattern implemented on a lot of mobile friendly sites. Even on this GitHub issue, if you adjust your browser window, you'll find that there is a critical point where the layout changes into to a mobile layout. The layout doesn't change multiple times throughout the resizing process. If it did, then the components would be all over the place, creating a jarring UX.
Browser: Version 111.0.5563.64 (Official Build) (arm64)
OS: Mac OS Monterey 12.5.1 (21G83)
Logs
N/A
Context
Scenario A1: Large tiles @ ~ 1700 pixels

Scenario A1: Large tiles @ ~ 1600 pixels

Scenario B2: Small tiles @ ~ 1700 pixels

Scenario B2: Small tiles @ ~ 1600 pixels

Please tick the boxes

[X] I confirm that I attached the proper logs
[X] I've read the docs
[X] I've checked for duplicate issues
[X] I've tried to debug myself

@ajnart does #771 fix this?

@ajnart does #771 fix this?

Not sure, this looks like a config error.
@kaybinwang we have a special mobile view for smaller screens and a view that scale up with the display for large screens, you should be able to view what size the dashboard is currently set to while in edit mode
not sure if this is an issue we can “fix” before we remove this system of having different sizes

@ajnart does #771 fix this?

Not sure, this looks like a config error.
@kaybinwang we have a special mobile view for smaller screens and a view that scale up with the display for large screens, you should be able to view what size the dashboard is currently set to while in edit mode
not sure if this is an issue we can “fix” before we remove this system of having different sizes

Ah true, it might be the size system...
I agree that we should remove it - I always forget about this system all the time 😅

Can we close this in favour of #778

Closing. We'll track this in the issue mentioned above


Server is stuck in CompletionQueue::Next when multiple server streaming request are sent from client

What version of gRPC and what language are you using?
https://github.com/grpc/grpc/archive/b54a5b338637f92bfcf4b0bc05e0f57a5fd8fadd.tar.gz
The nearest tag is v1.27.0-pre1 and I'm using C++.
What operating system (Linux, Windows,...) and version?
Ubuntu 18.04
What runtime / compiler are you using (e.g. python version or version of gcc)
Clang8.0
What did you do?
I have one service(A) and the service has two server streaming RPC(A1 and A2). The main thread in client sends RPC request A1 then RPC request A2. If there is no delay between these 2 RPC requests, the client is able to receive both A1 and A2 responses from server. However, if I add a delay between 2 RPC requests, client only receives the response for the first sent RPC request. Besides the main thread, client has two threads to read the responses. The following class includes the code for the client to send RPC request A1 and the thread function to receive A1 response(I have another class ClientA2 for RPC A2).
class ClientA1 {
public:
  explicit ClientA1(std::shared_ptr<Channel> channel)
      : stub_(helloworld::ServiceA::NewStub(channel)) {}

  void MethodA1() {
    helloworld::MethodA1Request request;
    call_.response_reader =
        stub_->AsyncMethodA1(&call_.context, request, &cq_, (void *)&call_);
  }

  // Loop while listening for completed responses. Run in a thread.
  void AsyncCompleteRpc() {
    void *got_tag;
    bool ok = false;

    // Block until the next result is available in the completion queue "cq".
    while (cq_.Next(&got_tag, &ok)) {
      // The tag in this example is the memory location of the call object
      AsyncClientCall *call = static_cast<AsyncClientCall *>(got_tag);

      if (ok) {
        call->response_reader->Read(&call->response, (void *)call);
      } else {
        call->response_reader->Finish(&call->status, (void *)call);
        break;
      }
    }

    // Deplete the completion queue
    while (cq_.Next(&got_tag, &ok)) {
    }
  }

private:
  // struct for keeping state and data information
  struct AsyncClientCall {
    helloworld::MethodA1Response response;
    ClientContext context;
    Status status;
    std::unique_ptr<ClientAsyncReader<helloworld::MethodA1Response>>
        response_reader;
  };

  std::unique_ptr<helloworld::ServiceA::Stub> stub_;
  CompletionQueue cq_;
  AsyncClientCall call_;
};

Main thread in client creates a ClientA1 object and a ClientA2 object, spawns threads to handle responses, and call MethodA1 and MethodA2 to send RPC requests to server. A 5-second delay is added between sending A1 request and A2 request.
      threads.emplace_back(&ClientA1::AsyncCompleteRpc, &client_a1);
      client_a1.MethodA1();

      // Add a delay.
      std::this_thread::sleep_for(std::chrono::milliseconds(5000));

      threads.emplace_back(&ClientA2::AsyncCompleteRpc, &client_a2);
      client_a2.MethodA2();

Server has two completion queues and spawns two threads to check the completion queue. The tag pushed to and pop from completion queue is defined as follows:
enum class Rpc { A1, A2};
struct CallData {
  CallData(const Rpc &rpc)
      : rpc_(rpc), response_cnt_(0), status_(CallStatus::CREATE) {}
  Rpc rpc_;
  // How many responses have been sent to the client.
  int response_cnt_;
  // State machine with the following states.
  enum class CallStatus { CREATE, PROCESS, FINISH };
  CallStatus status_; // The current serving state.
};

Server run the following initialization to spawns two threads.
    // Generate ServerAsyncWriter for A1 response and A2 response, respectively.
    std::shared_ptr<ServerAsyncWriter<helloworld::MethodA1Response>>
        a1_responder =
            std::make_shared<ServerAsyncWriter<helloworld::MethodA1Response>>(
                &ctx[0]);
    std::shared_ptr<ServerAsyncWriter<helloworld::MethodA2Response>>
        a2_responder =
            std::make_shared<ServerAsyncWriter<helloworld::MethodA2Response>>(
                &ctx[1]);

    // Spawn thread to check completion queue - cq[0]
    call_data.emplace_back(std::make_unique<CallData>(Rpc::A1));
    threads_.emplace_back(&ServerImpl::HandleRpc, this, cq_[0].get(),
                              a1_responder, a2_responder);
    helloworld::MethodA1Request request;
    call_data.back()->status_ = CallData::CallStatus::PROCESS;
    // Request RPC
    service_a_.RequestMethodA1(&ctx[0], &request, a1_responder.get(),
                                   cq_[0].get(), cq_[0].get(),
                                   (void *)call_data.back().get());

    // Spawn another thread to check completion queue - cq[1] and then request RPC A2(same as above)

The function run in thread ServerImpl::HandleRpc basically checks the type of the tag then call ServerAsyncWriter::Write() to write responses. For example, if the type of the tag(CallData::rpc_) is Rpc::A1, a1_responder->Write() will be called.
What did you expect to see?
I expected client receives both server streaming responses.
What did you see instead?
Without the delay in client, client receives both server streaming responses. However, with delay, client only receives the first response.
Anything else we should know about your project / environment?
No.

is the sever continuously writing to the client over the streams? I have had similar issues with the server serving only one stream but not the other, however I used only one completion_queue. I initially thought that the pop/push of the completion queue was unfair somehow, but didnt find anything suggesting that in the source code. So maybe my issue is the same as yours.
In my case, I had async bidirectional streaming, where a client write 1 message on stream1 and then read 100K messages on stream1. For each read message on stream1, the client issues a write on stream2 to the same server (this implies a small delay between the inital write on stream1 and first write on stream2, similar to yours when introducing a delay). However the server never served the client over stream2, only stream1. Only once the stream1's 100k messages were done with, it started serving the stream2's requests.
A solution was if I dedicated the completion_queue polling thread (HandleRpc), to only and only read tags. Instead of doing the processing of the tags, it saves the tags to a queue, which another thread (processRPC) pops tags from, processes them and writes the responses. This way, the server managed to serve both streams fairly. However the performance were terrible due to copying and busy_waiting in the processRPC thread.
Another work-around is to not do consequtive writes, but issuing an alarm between each Write.
So, instead of this:
Write(response, tag=WRITE)
cq->Next(tag);
if tag == WRITE do Write(response, tag = WRITE) // write next message..
Do this:
Write(tag=WRITE)
cq->Next(tag);
if tag == WRITE then alarm.set(.., deadline = now(), tag = WRITE_ALARM); endif;
cq->NExt(tag)
if tag == WRITE_ALARM then Write(tag = WRITE); endif;
cq->Next()....
, alternating between a Write and an Alarm. This will hand over priority to other streams (?) etc... However this, too, performs badly in my case. So none of the solutions are perfect so far. Maybe the first solution can be polished to work better tho...
My issue is here: https://github.com/grpc/grpc/issues/22318
Maybe mine is not related to yours at all. in that case im sorry for my wall of text...

Yes, the server continuously writes responses to the client.
In your case, did you call ServerAsyncWriter::Finish() when the stream1's 100k messages were sent?
If so, I think I also observe the same thing. My server has to call Finish() for the first streaming(A1) and after that, client starts to receive responses(A2).

Yes, the server continuously writes responses to the client.
In your case, did you call ServerAsyncWriter::Finish() when the stream1's 100k messages were sent?
Yes I did.
If so, I think I also observe the same thing. My server has to call Finish() for the first streaming(A1) and after that, client starts to receive responses(A2).
Yeah sounds very much alike

Hi again,
Any progress to the problem so far?
I have found one solution which might work for your case as well:
The solution is to have one thread working on a new separate completion queue of type DEFAULT_POLLING that is not used to serve any client connections. That means that this thread will be fully dedicated to grpc's IO work.
Then I can have the other completion queues which actually are serving client requests to be of type NO_POLLING. (not sure if there are any gains in having them as NO_POLLING)
This seems to help out in serving clients fairly.
 Is this scalable?

It looks like I hit the same problem. If connect to 1-2 servers it works when connectiooon more then 3 it start to break.
I made minimal example and tested it on Debian Buster withe grpc frpm 1.26.x branch. I didn't test any other version yet.
Workaround for me was
export GRPC_POLL_STRATEGY=epoll1

where override default  epollex polling engine.
        grpc_impl::CompletionQueue cq;
        std::vector<GrpcStatusContextResponse<::Response>> grpcCalls {stubs.size()};
        std::vector<std::unique_ptr<::grpc::ClientAsyncResponseReaderInterface<::Response>>> rpcs;

        // start requests to all servers
        auto deadline = std::chrono::system_clock::now() + timeout;
        for (size_t i = 0; i < stubs.size(); ++i) {
            grpcCalls[i].index = i + 1;
            grpcCalls[i].context.set_deadline(deadline);

            auto rpc = stubs[i]->Asynctest(&grpcCalls[i].context, request, &cq);
            rpc->Finish(&grpcCalls[i].response, &grpcCalls[i].status, reinterpret_cast<void*>(i));
            rpcs.push_back(std::move(rpc));
        }

        // mark queue as finished
        cq.Shutdown();

        // wait on all responses
        void* got_tag;
        bool ok = false;
        while (cq.Next(&got_tag, &ok))
             ;

Are there any updates on this bug? It breaks my workflow for performing an asynchronous multicast to multiple (more than 2) servers at once. I made a simplified MWE displaying the same problem that was shared by the previous commenter (I don't want to ping): https://github.com/jazevedo620/grpc-async-multicast.
The workaround of using epoll1 does work for me, though.

gRPC recently removed the epollex while making epoll1 a default poller on Linux so I think this indirectly solved this issue. Please feel free to reopen this if required.


Bubble up errors into responses

When you create a request with this URL as example  https://www.sdfdfhfdsghdfgh I get a logged error:
net::ERR_NAME_NOT_RESOLVED

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.10/site-packages/uvicorn/protocols/http/httptools_impl.py", line 399, in run_asgi
result = await app(  # type: ignore[func-returns-value]
File "/usr/local/lib/python3.10/site-packages/uvicorn/middleware/proxy_headers.py", line 70, in call
return await self.app(scope, receive, send)
File "/usr/local/lib/python3.10/site-packages/fastapi/applications.py", line 1054, in call
await super().call(scope, receive, send)
File "/usr/local/lib/python3.10/site-packages/starlette/applications.py", line 123, in call
await self.middleware_stack(scope, receive, send)
File "/usr/local/lib/python3.10/site-packages/starlette/middleware/errors.py", line 186, in call
raise exc
File "/usr/local/lib/python3.10/site-packages/starlette/middleware/errors.py", line 164, in call
await self.app(scope, receive, _send)
File "/usr/local/lib/python3.10/site-packages/starlette/middleware/cors.py", line 85, in call
await self.app(scope, receive, send)
File "/usr/local/lib/python3.10/site-packages/starlette/middleware/exceptions.py", line 65, in call
await wrap_app_handling_exceptions(self.app, conn)(scope, receive, send)
File "/usr/local/lib/python3.10/site-packages/starlette/_exception_handler.py", line 64, in wrapped_app
raise exc
File "/usr/local/lib/python3.10/site-packages/starlette/_exception_handler.py", line 53, in wrapped_app
await app(scope, receive, sender)
File "/usr/local/lib/python3.10/site-packages/starlette/routing.py", line 756, in call
await self.middleware_stack(scope, receive, send)
File "/usr/local/lib/python3.10/site-packages/starlette/routing.py", line 776, in app
await route.handle(scope, receive, send)
File "/usr/local/lib/python3.10/site-packages/starlette/routing.py", line 297, in handle
await self.app(scope, receive, send)
File "/usr/local/lib/python3.10/site-packages/starlette/routing.py", line 77, in app
await wrap_app_handling_exceptions(app, request)(scope, receive, send)
File "/usr/local/lib/python3.10/site-packages/starlette/_exception_handler.py", line 64, in wrapped_app
raise exc
File "/usr/local/lib/python3.10/site-packages/starlette/_exception_handler.py", line 53, in wrapped_app
await app(scope, receive, sender)
File "/usr/local/lib/python3.10/site-packages/starlette/routing.py", line 72, in app
response = await func(request)
File "/usr/local/lib/python3.10/site-packages/fastapi/routing.py", line 278, in app
raw_response = await run_endpoint_function(
File "/usr/local/lib/python3.10/site-packages/fastapi/routing.py", line 191, in run_endpoint_function
return await dependant.call(**values)
File "/usr/src/app/main.py", line 144, in crawl_urls
results = await asyncio.gather(*futures)
File "/usr/local/lib/python3.10/concurrent/futures/thread.py", line 58, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/src/app/crawl4ai/web_crawler.py", line 159, in run
html = self.crawler_strategy.crawl(url)
File "/usr/src/app/crawl4ai/crawler_strategy.py", line 217, in crawl
raise Exception(f"Failed to crawl {url}: {str(e)}")
Exception: Failed to crawl https://www.sdfdfhfdsghdfgh: Message: unknown error: net::ERR_NAME_NOT_RESOLVED
(Session info: chrome-headless-shell=126.0.6478.114)

But the raw response I receive is:
StatusCode: 500, ReasonPhrase: 'Internal Server Error', Version: 1.1, Content: System.Net.Http.HttpConnectionResponseContent, Headers:
{
  Date: Tue, 25 Jun 2024 23:53:17 GMT
  Server: uvicorn
  Content-Length: 21
  Content-Type: text/plain; charset=utf-8
}

And this is with any kind of error. I'm wondering if there's a way to retrieve the error message/type in the response. So we can process it accordingly.
Use case: If I enter a wrong URL I want to be able to tell if the URL is valid or not. And treat other errors the right way.
Thank you so much for your time :)

@FractalMind So good you reminded me of this. It has been there since the beginning; I just never documented or mentioned it 😅 and forgot to fill its value in the exception clause. Today, I'll push the new version and make sure it's included.
This is the CrawlResult, you can always check the "success" field and if its false then check the error_message

I confirm, it works in the new update
{
  "results": [
    {
      "url": "https://ghjfghjfghj",
      "html": null,
      "success": false,
      "cleaned_html": null,
      "media": {},
      "links": {},
      "screenshot": null,
      "markdown": null,
      "extracted_content": null,
      "metadata": null,
      "error_message": "Failed to crawl https://ghjfghjfghj: unknown error: net::ERR_NAME_NOT_RESOLVED\n  (Session info: chrome-headless-shell\u003d126.0.6478.126)"
    }
  ]
}


Fuselage Stringer set

The current fuselage stringer definition allows only one per stringer per entry.
This is very extensive for large models.
This proposal would introduce a stringer definition with the possibility of defining a stringer set.
This principle of this definition is similar to the wing ribs definition.
Any stringer reference  in the schema would also have to enriched by a stringer number, to state exactly which single stringer is referred.
The attached proposal is open for discussion.
stringerSet.xsd.zip

As in #574: To support the discussion, I have implemented  your proposal as a new element (stringersDefinition) in the fuselageStructureType (without deleting the old stringers element).

comparison: schema graphics

May @DLR-BT and DLR-FA (@sfreund-DLR?) also give their opinion on this proposal? As in the frames issue: Who else is using stringers?
link to working branch

same comments as in the frames issue


fix: List app keys by tigris project

Describe your changes
This PR sends a filter to gotrue asking to filter app keys on a project. This fixes the issue where all the app keys created by a users in a given namespaces are listed (ignoring project).
How best to test these changes
Added integration test.
Issue ticket number and link

Codecov Report
Patch and project coverage have no change.

Comparison is base (e03374e) 30.41% compared to head (62c9d05) 30.41%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #909   +/-   ##
=======================================
  Coverage   30.41%   30.41%
=======================================
  Files         180      180
  Lines       20568    20568
=======================================
  Hits         6256     6256
  Misses      13590    13590
  Partials      722      722

Impacted Files
Coverage Δ

server/services/v1/auth/gotrue.go
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Windows artifact?

Мне это нужно. Я не собираюсь качать вижуал студию для сборки😂

Windows/Linux build artifacts will be uploaded automatically at some point, haven't gotten around to adding that yet. I don't consider this code production ready just yet, the viewer needs a lot of work still :)
#3 covers this, closing as a duplicate

Also I have a question. Can it create vtf with ATI1n/2n texture format?
@JJL772

The GUI can't create textures yet, the functionality is WIP. The CLI can though!
If you want an improved version of VTFEdit, you can check out Josh's VTFLib fork which includes VTFEdit Reloaded. I don't see any build artifacts on that repo yet though, so you'll probably need to manually build it for now.


Investigate the Systems Strategy AWS account

Part of #5446.
There's an AWS account called "Systems Strategy" that was used for … something, I'm not sure what. I have access to the shared inbox used by the root account, but I need either an MFA key or access to the phone number to get into the account proper.

I need to book an hour meeting with Kate to sit down and do phone number shenanigans so I can get into the root account.

Investigated; folded into our standard account infra. We can't close it because it's still running some services we don't have backed up, but it's not causing any major issues.


Documenting multiple attributes via @!attribute directive

Which syntax for documenting attributes does InchCI support? For situations where I declare a number of attributes using a single attr_reader call, e.g.
attr_reader :attr_one, :attr_two

Ideally, I should be able to document these as:
# @!attribute attr_one
#   @return [String] description of attr_one
# @!attribute attr_two
#   @return [Integer] description of attr_two
attr_reader :attr_one, :attr_two

However, this doesn't appear to work. Am I misunderstanding how the @!attribute YARD directive is meant to be used?

Re: [U] SlimLint::Document#source_lines in sds/slim-lint

Hi there,
this is a good question. I thought this case should be documented like so:
# @return [String] description of attr_one
attr_reader :attr_one
# @return [String] description of attr_two
attr_reader :attr_two

This seems to be the case since 2010: https://gist.github.com/koraktor/587533
I will try to take another look after work.

I was trying to stay away from using @attr_reader since according to YARD's documentation all @attr*-related tags are deprecated in favor of @!attribute (see http://www.rubydoc.info/gems/yard/file/docs/Tags.md).
I'm fine splitting up the declarations and using the deprecated form for now, but it would be great to have Inch recognize it.

@sds no,no, noooooo :grin: ... that's not what I meant by posting the link.
I was trying to describe that I do it using @return tags on individual attributes.
# @return [String] description of attr_one
attr_reader :attr_one
# @return [String] description of attr_two
attr_reader :attr_two

Some think this bloats their code (to put each attribute on its own line). I posted the link simply because the gist suggests that the "one attribute per line" thing is around since the days of @attr_reader, not to advise you to use it.

Sorry for the confusion, I mispoke (long day for me).
I indeed didn't end up using @attr_reader. Thanks for the clarification that it isn't necessary in this case. :)


[SPARK-25389][SQL] INSERT OVERWRITE DIRECTORY STORED AS should prevent duplicate fields

What changes were proposed in this pull request?
Like INSERT OVERWRITE DIRECTORY USING syntax, INSERT OVERWRITE DIRECTORY STORED AS should not generate files with duplicate fields because Spark cannot read those files back.
INSERT OVERWRITE DIRECTORY USING
scala> sql("INSERT OVERWRITE DIRECTORY 'file:///tmp/parquet' USING parquet SELECT 'id', 'id2' id")
... ERROR InsertIntoDataSourceDirCommand: Failed to write to directory ...
org.apache.spark.sql.AnalysisException: Found duplicate column(s) when inserting into file:/tmp/parquet: `id`;

INSERT OVERWRITE DIRECTORY STORED AS
scala> sql("INSERT OVERWRITE DIRECTORY 'file:///tmp/parquet' STORED AS parquet SELECT 'id', 'id2' id")
// It generates corrupted files
scala> spark.read.parquet("/tmp/parquet").show
18/09/09 22:09:57 WARN DataSource: Found duplicate column(s) in the data schema and the partition schema: `id`;

How was this patch tested?
Pass the Jenkins with newly added test cases.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2966/
Test PASSed.

Test build #95860 has started for PR 22378 at commit 0242576.

Test build #95860 has finished for PR 22378 at commit 0242576.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95860/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2969/
Test PASSed.

Test build #95865 has started for PR 22378 at commit 0242576.

Test build #95865 has finished for PR 22378 at commit 0242576.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95865/
Test FAILed.

Retest this please.

Test build #95879 has started for PR 22378 at commit 0242576.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2976/
Test PASSed.

Test build #95879 has finished for PR 22378 at commit 0242576.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95879/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2986/
Test PASSed.

Test build #95891 has started for PR 22378 at commit 0242576.

Test build #95891 has finished for PR 22378 at commit 0242576.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95891/
Test PASSed.

Could you review this, @gatorsmile , @cloud-fan , and @seancxmao ?

LGTM

Thank you for review, @cloud-fan and @HyukjinKwon .

Merged to master/2.4.


Adding copy formatting function to package

As a contributor
By submitting this PR I confirm I have read and understood the Github Standards document and understand the role I play in ensuring standards, security, and assurance at DfT.
As a PR reviewer
By accepting this PR I understand my responsibilities as described in the the Github standards document.
Proposed changes
Added copy formatting function to package, including minor changes to improve speed and clarity of function
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[ ] Bugfix (change which fixes an issue)
[X] New feature (change which adds functionality)
[X] Documentation Update (change to naming or other documentation)

Points I have checked in my code
Put an x in the boxes that apply. You can also fill these out after creating the PR.

[ ] I have added unit tests that prove my fix is effective or that my feature works
[X] I have added necessary documentation (if appropriate)
[X] I have checked that my changes have not broken any other functionality
[ ] I have linked to any issues this PR fixes

Points for review
Add checkboxes here for any specific aspects of your PR you would like to be checked in peer review. If you don't specify anything here, the reviewer will check:

[ ] All of your unit tests pass
[ ] Your code is clear and easy to understand
[ ] You have documented any new features
[ ] They can run the code you have written
[ ] Your changes do not break any other functionality

Security considerations
Put an x in the boxes that apply. You should have considered all of these points before submitting a PR.

[X] My code does not contain any secrets such as passwords, API keys, etc
[X] I have not accidentally uploaded any data to Github
[X] My code does not include any personal information such as names or email addresses

Who is reviewing this PR?

@AIMS-Sean-Longman planning to incorporate your function into main with this PR 🥇 I was looking in to whether it could be vectorised (e.g. providing more than one colTo and the rows as a single vector rather than a from and to value), can you think of any reason this would break the intended behaviour of the function? And would you be willing to do a peer review on the code once I've made that change?

@DIPAD-Fran-Bryden Like the addition of the sapply to filter the styles object!! Wish I'd thought of that! Regarding vectorising the colTo and row, I think you can have colTo as a vector already? Because the code puts in each style row by row, addStyle can handle an unequal row vector and col vector as long as one of them is length 1 which would be the row. Vectorising the row rather than startRow and endRow will need an adjustment for the looping through each row (I'm assuming non-consecutive rows), but is doable, and shouldn't break the functionality. As long as colFrom and sheet are single values, can't see anything breaking.

@AIMS-Sean-Longman sorted and all ready for your review! I can't tag you in it until you accept the invite to the repo, but would appreciate any thoughts you have 😺


Trigger Window to show last trigger check and result

Nice to have if the triggers window can show when the last time the trigger check / was run and what run profile it caused to run if it did so..

Yes good idea. Ive been thinking about how to do this but haven't come up with any good ideas on how to render it yet

Extension to the current trigger type and description with last run and result


[Bug]  ERR_TOO_MANY_REDIRECTS could happen when multiple redirects happen

Describe the bug
Summary
I've seen the following error screen when trying to launch https://note.designing.jp/n/n9a5c60967d23.
The reason is obviously there're some redirects to finally land on the final destination.

Root Cause
Haven't spent so much time for this but presumably we can cope with by tweaking WebSettings.

ref: https://stackoverflow.com/questions/45879809/android-webview-err-too-many-redirects

How to Reproduce

Open https://note.designing.jp/n/n9a5c60967d23 with DuckDuckGo Android app
See the error screen above

Expected behavior

Open the URL without any errors

Confirmed Chrome and Firefox can open the URL.

Environment
- DDG App Version: 5.94.3
- Device: Pixel3
- OS: Android11

I can spend some time on the weekend(if we can agree this is the issue to address)!

@hotchemi I was trying to reproduce the issue with the link you provided, and it seems to be fixed now. Maybe there was an issue also on their side as well.
We haven't fixed this issue in our app, so it may still happen in some scenarios. Please confirm you can visit that site.
We can look again into this issue next time we detect another link failing that other browsers support.

Thx for the confirmation. I've also confirmed they reduced the number of redirects probably 🙇


Enable renaming of symptom

Create a new function in periodDatabaseHelper which takes in symptomId and (new) symptomname. The function should then update the symptom in the database with a new name.
We will also need implementation of this in the manageSymptomsDialog!

This is tagged as a databaseissue, but this does not require a database-upgrade since its just adding a new function in the code.

The database function is created and called: renameSymptom
What is left is implementation of renaming symptoms in the manageSymptomsDialog.kt (the UI)


[CSL 341]: Port getBrowseResultsByItemIds

Made a couple of comments, the rest looks awesome! Great job


Enhancement request: Allow nested select functions, ex: select sum(derivate(value))...;

We store our data in InfluxDB such that each individual metric is its own series, and we insert a hostname value into each update so that we can build out dashboards for clustered services without falling back to regex'd series names, and we keep our series count down.
Some of our metrics are counters that we take a derivative of at search time. When viewing each host individually this works fine, but if I want to roll up those values easily across a set of hostnames that exist in the series, I can't do much other than:
select derivative(value) from seriesName group by time(30s), hostname;
and then see independent lines graphed for each hostname in tools like Grafana.
If I could instead query it as follows, aggregate graphs would be much easier and more universally applicable:
select sum(derivative(value)) from seriesName group by time(30s);

:+1: sum(derivative(value)) would also be very useful for me.

+1

mean(derivative(value)) would be very welcome

+1

+1

+1

As mentioned in my post to the mailing list we are experimenting with simplifying our open GitHub Issues. This feature request has been rolled into an aggregate issue for all function requests, so that we can close this issue until we are ready to work on it.
You may continue to make comments here. Closing the issue does not mean we are rejecting this idea.

I'm getting error parsing query: expected field argument in sum() for SELECT sum(non_negative_derivative("requests_started", 1s)) FROM "nginx.status" WHERE "host" =~ /censored-.*/ AND $timeFilter GROUP BY "host" - is it the same issue, should I reopen it?

Forgot to mention the version: 1.0.2-1

Aaah sorry, I didn't read previous comment about the aggregated issue.

+1

+1

+1


compiler/sim: Add --gc-sections opotion to the linker

This patch make sure that image does not contain
not used functions and data as it is done for other targets

It would be nice to have it also in: sim-armv7, sim-mips, mips, xc32

I agree, but I need to setup environment for that to make sure it does not break anything. Will try to find time for that.

Oops looks like
GCC version
Apple LLVM version 9.0.0 (clang-900.0.38
does not support --gc-sections

looks like for Apple there is other option - PR updated.


trying to fix servo, added a thing for autonomous

Yes I was up at 3 doing this. Don't ask why

Why


Performance optimization for very large sitemaps.

Fixes #364
What this PR changes
This refactors the cleanExpandResources method in crawler.js to use a single for loop instead of Array.{filter,map,reduce}. The speedup observed was 20x for a sitemap with 20k urls.
To allow usage of const, let and sets Eslint was bumped to ES6 and Node.js < v4 was dropped from the travis/appveyor configuration.
Rationale
After creating and analyzing several CPU profiles in Webstorm I decided to get rid of Javascripts native array methods filter, map and reduce, because they are very slow for large arrays. Additionally using a set instead of an array for the result of the reduce part makes a lot more sense because we want to keep unique URLs only.

Hi, @elxa! Thanks for taking the time to write a PR. I'm happy to change the method to use a for loop instead of array methods, but I'm wondering whether the ES6 features are necessary - how much do they contribute to the speed increase?

Thanks @fredrikekelund . I have not checked that. To me it just didn't make sense to use an array to store unique URLs, which is why I chose the set datastructure. That latter seems to require ES6 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set
I assume using an array instead of the set would push the complexity to O(n*m) with m <= n, because of the lookup in https://github.com/cgiffard/node-simplecrawler/blob/master/lib/crawler.js#L871 ?
I have a published a small benchmark using 200k items showing huge performance differences on https://jsperf.com/array-vs-set-has-element
The second test case is what the crawler currently does, the third uses the set. This assumes the worst case scenario where all the URLs processed in cleanExpandResources are valid urls.

Thanks @fredrikekelund . I have not checked that. To me it just didn't make sense to use an array to store unique URLs, which is why I chose the set datastructure. That latter seems to require ES6 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set
I assume using an array instead of the set would push the complexity to O(n*m) with m <= n, because of the lookup in https://github.com/cgiffard/node-simplecrawler/blob/master/lib/crawler.js#L871 ?
I have a published a small benchmark using 200k items showing huge performance differences on https://jsperf.com/array-vs-set-add-unique-elements-only-2-0
The second test case is what the crawler currently does, the third uses the set. This assumes the worst case scenario where all the URLs processed in cleanExpandResources are valid urls.

Dropping Node.js 0.X not only makes sense technically, but also because it is EOL since the end of 2016 https://github.com/nodejs/LTS#lts-schedule1

Initially I didn't add a replacement for the
urlMatch.filter(Boolean)

call in crawler.js, but tests with a sitemap of 200k URLs (real pages, no dummy pages) showed that the crawler crashes with this error at some point:
TypeError: invalid input
    at URI.p.href (***\node_modules\urijs\src\URI.js:1183:13)
    at new URI (***\node_modules\urijs\src\URI.js:70:10)
    at URI (***\node_modules\urijs\src\URI.js:46:16)
    at ***\node_modules\simplecrawler\lib\crawler.js:1734:24

I now added
if (!URL) {
    continue;
}

in the refactored code.
@fredrikekelund Would you merge this including the bump to es6 or would you rather stay on es5 using an npm package to provide support for sets (I guess there are a few options) ?

I've mulled it over, and as long as we can support 4.x, then I think it makes sense to use ES6 - especially for a feature as well suited as this. I will have to look into whether this requires a major version number bump, though. Will have a closer look at the diff later today!

@elxa the diff looks good, I've merged this now! Will look into making a few other changes and then I will release a new major version to avoid any breakage


Universal axis parameter for Merge

Wouldn't it make more sense, rather than having specific concat_axis and dot_axes parameters, to have a general axis specification of what shapes should merge operate on?  The semantics might be tricky for dot_axes, but for concat_axis, I don't see why that needs to be specific for concat.
For example, right now I'd need a model that could produce a time series by summing up two other time series timepoint-wise, and I see no easy way to do that - I'd like something like merge_mode='sum', merge_axis=1. I hope I'll figure out how to do that using LambdaMerge but it seems a bit scary for such a simple operation...

We considered this initially. The different usage syntax means it is clearer not to reuse the same keyword twice (or more), in terms of UX.
You should consider using LambdaMerge, which isn't scary.

concat_axis and dot_axes are different things. dot_axes could be a list/tuple but concat_axis is always an integer. Also, I didn't  quite catch what you are trying to do. You  have  got 2 3D layers(2  timeseries) and you want to add them, is it? Just merge with mode='sum'. If this is not what you want,  then provide an example.

@farizrahman4u you are right, I was terribly confused about sum, mul, ave as I started out with timewise dot-products and these are probably the only problematic ones. mul works just fine! (In case someone needs to timewise multiply vector by scalar, RepeatVector(dim) and Permute((2,1)) first.)
So if anyone else finds LambdaMerge scary, this is an example of using it for elementwise dot-product (for example to generate token attentions):
    def batched_batched_dot(s):
        """ from (x,y,z)-shaped pair, produce (x,y)-shaped pair that replaces the z-vector pairs by their dot-products """
        import theano
        import theano.tensor as T
        return theano.scan(fn=lambda xm, ym: T.batched_dot(xm, ym),
                           outputs_info=None, sequences=s, non_sequences=None)[0]
    model.add_node(name='esa[0]',  # nested batched_dot
               layer=LambdaMerge([model.nodes['e0sa'], model.nodes['e1sa']],
                                 batched_batched_dot,
                                 lambda s: (s[1][0], s[1][1])))

(hope I got it right; it seems to work).


Pkg.add("Atom") is not working

julia> Pkg.add("Atom")
INFO: Initializing package repository /home/yury/.julia/v0.4
INFO: Cloning METADATA from git://github.com/JuliaLang/METADATA.jl
fatal: unable to connect to github.com:
github.com[0: <IP_ADDRESS>]: errno=Connection timed out
ERROR: failed process: Process(git clone -q -b metadata-v2 git://github.com/JuliaLang/METADATA.jl METADATA, ProcessExited(128)) [128]
in anonymous at ./pkg/dir.jl:52

Seems like a network problem.

git:// protocol or ports blocked in my company. May it be better to use https?

this solves my problem: git config --global url."https://".insteadOf git://


How to use Blackfire - part of heroku php build pack

Is it possible to use Blackfire on Dokku?
It is part of the Heroku build pack for PHP https://github.com/heroku/heroku-buildpack-php/blob/0adff36b9d648a3f836271fb7a6dc7eafff74356/conf/php/conf.d/ext-blackfire.ini

It should be, is there something that isn't working?

I am not sure where to start?
On Heroku it says just to use heroku addons:add blackfire but I appreciate it is not exactly the same for Dokku.
From the dokku plugins docs it talks about cloning a repo.
Any advice is appreciated.

Seems like you'll need to run the agent inside of your container like so. You can use a plugin like supervisord to run another agent in your container alongside your app.

Great, I will have a play. Thanks for quick response! :+1:


Website link on Astro is not working

💻

[ ] Would you like to work on this feature?

What problem are you trying to solve?
I was searching for an adapter to aws and i found this awesome project please update the website here https://astro.build/integrations/?search=astro-aws%2Fadapter.
I will checkout this project and maybe if its possible i can help to write documentation how to use it.

Describe the solution you'd like
Redirect it to do www.docs.astro-aws.org/
Describe alternatives you've considered
-_-
Documentation, Adoption, Migration Strategy
No response

Sorry for that feature request i didnt know where to add !!

Fixed