Add an overload for Configure where the action can accept an IServiceProvider

Hi @tuespetre, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
TTYL, DNFBOT;

Is the main motivation of this change to be able to consume services in your Configure?  If so, you can just implement IConfigureOptions<YourOptions> explicitly and add it to DI, with the services required taken as ctor arguments.

In general we are trying to avoid service locator, so we are not keen on adding overloads that take IServiceProvider

There is a line between "service locator is bad" and "sweet Jesus, we have to write more code just to satisfy some ideal of what is and is not an anti-pattern", and I feel very confident in saying that I have found that line.
It's alright, I'll just add this to my "Extensions.cs" file that I copy-paste-replace in every project. ;)

@tuespetre do you end up with the bulk of your config in the lambda? Can you show where you use this today?

@davidfowl well, that depends -- when 'the bulk of the config' amounts to setting a ton of properties on an Options-y class, then the answer could be yes. But if there is some complex construction, for instance, classes that derive from JsonInputFormatter and JsonOutputFormatter and need ObjectPoolProvider and ArrayPool<char> and a whole bunch of other stuff, that will go in an IConfigureOptions<MvcOptions> , and services.Configure<MvcOptions>(mvc => ...) will just be used for the rest.
It looks like every time I've wanted this (plus the one time I've seen someone else want it), it's been for the purpose of copying things from one Options-y class to another Options-y class, and I've just needed one thing from the services. I don't see it as a super common thing to do though, so I'm okay with keeping it in my 'bag of extensions.' We can directly use services.Configure<IConfigureOptions<MvcOptions>>(provider => new ConfigureOptions<MvcOptions>(options => { ... })); anyways, but I thought the shorthand would be nicer to have around. :smile_cat:

Revisiting due to https://github.com/aspnet/Options/pull/239

@tuespetre,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Going to hand merge this as a new method on IOptionsBuilder instead of on IServiceCollection as an extension method.

Will be added to: https://github.com/aspnet/Options/pull/239

Actually doesn't appear that we really need this, since this is a specialized version of Configure<TDep> where TDep is IServiceProvider, the only slight difference is Configure<TDep> is registered as a transient instead of singleton, but in reality that won't matter since its the IOptionsFactory's lifetime that really matters (since that hangs onto the list of IConfigureOptions anyways).
But I will add a test to IOptionsBuilder to verify that this is possible, i.e.:
            var someService = new SomeService("Something");
            var services = new ServiceCollection().AddOptions().AddSingleton(someService);
            services.AddOptions<FakeOptions>().Configure<IServiceProvider>((o, s) => o.Message = s.GetRequiredService<SomeService>().Stuff);

            var sp = services.BuildServiceProvider();
            var factory = sp.GetRequiredService<IOptionsFactory<FakeOptions>>();
            Assert.Equal("Something", factory.Create(Options.DefaultName).Message);

@HaoK that's a neat solution! 👏


Fix plugin info

Merge after https://github.com/prettier/prettier/pull/3584 and we bump the commit in package.json

Updated. Good to go now. This isn't entirely correct, but it makes the instructions in the README work out-of-the-box.

Just to clarify, since I didn't put it explicitly, what this does is allow just doing:
$ prettier --plugin prettier-python

Instead of having to specify the full
$ prettier --plugin prettier-python --parser python

Not a huge difference but it makes things slightly more pleasant.


ERROR endpoint for ec2

I try connect in ec2 services but in my shell appears this error
shell: Credential :aws_access_key_id cannot be empty (RightScale::CloudApi::ApiManager::Error)
code: endpoint = 'https://ec2.sa-east-1.amazonaws.com/'

It seems that you are sending an empty aws access key is.
  key      = 'your aws access key id'
  secret   = 'your aws secret access key'
  endpoint = 'https://ec2.sa-east-1.amazonaws.com'
  ec2      = RightScale::CloudApi::AWS::EC2::Manager.new(key, secret, endpoint)
  ec2.DescribeInstances

no, I am using now my key and secret.

try this code:
key      = 'foo'
secret   = 'bar'
endpoint = 'https://ec2.sa-east-1.amazonaws.com'
ec2      = RightScale::CloudApi::AWS::EC2::Manager.new(key, secret, endpoint)
ec2.DescribeInstances

If everything is OK then you will get:
RightScale::CloudApi::HttpError: 401: AuthFailure: AWS was not able to validate the provided access credentials (RequestID: a80be9f9-c2a5-4085-b9f3-4bd31cab9c64)

Just provide it with your real keys and it will work.

Thanks konstantin
I was using with ENV in key and secret.
sorry

Glad it worked for you.
Please, close the issue.

Konstantin
I run file.rb in my shell but dont show nothing

Sorry, what's in your file.rb (plz hide your secrets)?

require 'right_aws_api'
key      = 'xx'
secret   = 'xx'
endpoint = 'https://ec2.sa-east-1.amazonaws.com/'
ec2      = RightScale::CloudApi::AWS::EC2::Manager.new(key, secret, endpoint)
ec2.DescribeInstances
ec2.DescribeInstances('InstanceId' => "i-0d304b024bd7e11cc")

if you want any output you have to use 'puts':
puts ec2.DescribeInstances('InstanceId' => "i-0d304b024bd7e11cc")

But this has nothing to do with the gem - it is just basic ruby knowledge

method_missing': undefined method `to_ary' for #Hash:0x000000023dd770 (NoMethodError)
Did you mean?  to_a

What ruby version are you using?
Can you post the full call stack?

ok
ruby version 2.3.3 via rvm
ruby service2.rb
/home/henrique/.rvm/gems/ruby-2.3.3/gems/right_cloud_api_base-0.2.6/lib/base/routines/result_wrapper.rb:57:in method_missing': undefined method to_ary' for #Hash:0x000000023dd770 (NoMethodError)
Did you mean?  to_a
from service2.rb:7:in puts' 	from service2.rb:7:in puts'
from service2.rb:7:in `'
henrique@thor:~/AulasDocker/aws/testrails$

There is no any 'to_ary' in the gom code.
Are you doing
puts ec2.DescribeInstances('InstanceId' => "i-0d304b024bd7e11cc")

or
puts ec2.DescribeInstances('InstanceId' => "i-0d304b024bd7e11cc").to_ary

in your script?
The former should work work, the later must fail

without method
without .to_ary

Post your current script once again plz (remove secrets)

runned now with to_a method.

Wait, you just said you did not do to_ary, and now you are saying you are replacing it with to_a...

yes

I used to_a method for test and worked


One NPE in LogicalChecker.java

Hello,
Our static analyzer found a following potential NPE. We have checked the feasibility of this execution trace. It is necessary to defend this vulnerability to improve the code quality.

Function add executes and pathsCache contains null value
https://github.com/apache/iotdb/blob/8b1ee93c51932d72cb7fd7c5268f40f7b3a74f25/server/src/main/java/org/apache/iotdb/db/qp/logical/crud/SelectOperator.java#L107

Program reaches the return point, and returns pathsCache, which contains null value
https://github.com/apache/iotdb/blob/8b1ee93c51932d72cb7fd7c5268f40f7b3a74f25/server/src/main/java/org/apache/iotdb/db/qp/logical/crud/SelectOperator.java#L111

Function next executes and stores the return value to path (path can be null)
https://github.com/apache/iotdb/blob/8b1ee93c51932d72cb7fd7c5268f40f7b3a74f25/server/src/main/java/org/apache/iotdb/db/qp/strategy/LogicalChecker.java#L96

path is passed as the this pointer to function getDevice (path can be null), which will leak to null pointer dereference
https://github.com/apache/iotdb/blob/8b1ee93c51932d72cb7fd7c5268f40f7b3a74f25/server/src/main/java/org/apache/iotdb/db/qp/strategy/LogicalChecker.java#L97

Commit: 8b1ee93c51932d72cb7fd7c5268f40f7b3a74f25
ContainerAnalyzer

I'd like to call this a code smell, because the NPE will not be triggered at any time.

The method getDevice is called in another method checkAlignByDevice, and the method checkAlignByDevice is called only if the system is executing a align-by-device query.

If a query is a align-by-device query, the branch you mentoned at 1 (pathsCache.add(null); ) will not be accessed, so there will be no NPEs.
I wll fix the code smell.
Thanks for the discovery!


Refactor to make package installable

Overview
Robotouille can be installed by pip install -e .
Changes Made
Shifted main directory files to robotuille/ and utils/, correct imports and paths accordingly
Test Coverage
TODO
Next Steps (delete if not applicable)
README needs to be update with new install instructions
Related PRs or Issues (delete if not applicable)

Screenshots (delete if not applicable)

Screen Shot Name

I'm not sure why pddlgym/robotouille/ has extra files. Should they be getting deleted? Possible bug of refactoring

Removed the files.
Regarding the warning - I tried to find the source of the issue and noticed register_pddl_env being called twice for the name "robotouille" in this branch instead of once as in main.  Could that be a reason for the re-register @chalo2000 ?

Found the issue and fixed

my WSL's clock is screwed up so the commit shows before your comment but I've just pushed the change to quit once the goal is reached.


Pixhack v3 hardware issues

After completing the set up for the Pixhack v3, we have the following issues:

Doesn't detect compass
Inconsistent compass and accelerometer
The vehicle does not arm

Please see video below:
https://www.youtube.com/watch?v=xb6wUPhIn3U&feature=youtu.be
We have tried on stable and Master. @jinger26 @mrpollo @dagar @cuhome

@Tony3dr has this been resolved?


Add system information portal page.

Add a page displaying system information to the portal.

Would this be system.php by any chance? :)

Yes was thinking about adding more but honestly not sure what else of use can be put here... Thinking this issue can be closed being a system information page does in fact exist.


Add support for Elixir 1.6.6 and Erlang 21.0

There are some features that I want to use from this release.

Probably a duplicate of #29 (where documentation is not enough nor updated...),
run.config:
  # elixir runtime
  engine: elixir
  engine.config:
    runtime: elixir-1.6.6
    erlang_runtime: erlang-21

This worked for me.
/app $ elixir -v
Erlang/OTP 21 [erts-10.0] [source] [64-bit] [smp:4:4] [ds:4:4:10] [async-threads:1]

Elixir 1.6.6 (compiled with OTP 21)

It was added after, yes. The team just forgot to close this one. 😅

I know this is off-topic, but it'll be better if an easy search could be done for existing nanobox packages; Currently we can only look down here? Then the document could refer to that...

I think a major documentation and so forth overhaul is in the works...

We have support for OPT21 now so I can close this.


All Tasks Fail

I've installed the software without any errors, and the browser page opens fine. However, despite setting various search criteria, all tasks fail in less than a second. The only task that remains in a "running" or "in progress" state is the one named "All Tasks." I let it run for 28 hours, but it produced no results.
I even tried to replicate the search from the demonstration (e.g., "web developers in Bangalore") but encountered the same issue.
Has anyone experienced this problem?

What browser are you using?

Don't use venv with (venv) inside a local Hyper-V virtual machine, instead either
use gitpod: https://github.com/omkarcloud/google-maps-scraper/blob/master/advanced.md#-i-dont-have-python-or-im-facing-errors-when-setting-up-the-scraper-on-my-pc-how-to-solve-it
run in gcloud: https://github.com/omkarcloud/botasaurus#how-to-run-scraper-in-virtual-machine
PS: could you share errors in terminal?

I was using Firefox, but I tested it on Chrome based on OneKrown suggestion, and everything works fine.
Chetan11-dev - Thanks for your recommendation; I will look into it later.


Unable to set breakpoint on Realtek RTL8195AM

When I try to set a breakpoint, for example on mbedtls_ssl_handshake in the test example below:
https://github.com/marcuschangarm/mbed-os-example-tls/tree/master/tls-client
I get this error:
(gdb) break mbedtls_ssl_handshake
Cannot access memory at address 0x3001c660

pyocd-gdbserver: 0.8.1a1 and 0.8.1a2.dev38
DAPLINK: 0241
GCC: 5.4.1 20160609
GDB: <IP_ADDRESS>60616-cvs

@c1728p9 @0xc0170

What target are you using for pyOCD (since the RTL8195 is not directly supported)?
Assuming the RTL8195 doesn't use an M7 core, the address 0x3001c660 is outside the supported hardware breakpoint range. So pyOCD will have to use a software breakpoint. If that address is not writeable, it will fail.

Oh, that's interesting. The RTL8195AM is a bit weird. It doesn't have execute-in-place flash, so code is copied to RAM and executed from there. It also has functions in ROM to complicate matters.
pyOCD detects it as a generic Cortex-M3:
WARNING:root:Unsupported board found
INFO:root:DAP SWD MODE initialised
INFO:root:ROM table #0 @ 0xe00ff000 cidr=b105100d pidr=4000bb4c3
INFO:root:[0]<e000e000:SCS-M3 cidr=b105e00d, pidr=4000bb000, class=14>
WARNING:root:Invalid coresight component, cidr=0x0
INFO:root:[1]<e0001000: cidr=0, pidr=0, component invalid>
INFO:root:[2]<e0002000:FPB cidr=b105e00d, pidr=4002bb003, class=14>
WARNING:root:Invalid coresight component, cidr=0xb1b1b1b1
INFO:root:[3]<e0000000: cidr=b1b1b1b1, pidr=b1b1b1b1b1b1b1b1, component invalid>
WARNING:root:Invalid coresight component, cidr=0x0
INFO:root:[4]<e0040000: cidr=0, pidr=0, component invalid>
INFO:root:[5]<e0041000:ETM-M3 cidr=b105900d, pidr=4003bb924, class=9, devtype=13, devid=0>
INFO:root:CPU core is Cortex-M3
INFO:root:6 hardware breakpoints, 4 literal comparators
INFO:root:4 hardware watchpoints
INFO:root:Telnet: server started on port 4444
INFO:root:GDB server started at port:3333

The 0x3001c660 address is in a memory mapped SD-RAM chip:
MEMORY
{
  TCM (rwx)        : ORIGIN = 0x1FFF0000, LENGTH = 0x00010000
  ROM_USED_RAM (rwx)  : ORIGIN = 0x10000bc8, LENGTH = 0x10006000-0x10000bc8
  DATA_RAM (rwx)   : ORIGIN = 0x10002100, LENGTH = 0x10006000 - 0x10002100
  BD_RAM (rwx)     : ORIGIN = 0x10006000, LENGTH = 0x10070000 - 0x10006000
  SD_RAM (rwx)     : ORIGIN = 0x30000000, LENGTH = 2M
}

Ok, I checked the code. If the target doesn't have a memory map, then it only supports using hardware breakpoints. But if the address is outside the hw breakpoint range, then the breakpoint request will fail. Sorry, but it won't work for the time being. The best solution is to add RTL8195AM support to pyOCD so it has a memory map.
@c1728p9 We should change BreakpointManager.set_breakpoint() to allow software breakpoints if there isn't a memory map, and only fail if the memory write fails.

@flit thank you for looking into it!

@flit  - any chance of this getting implemented ASAP? It's a big impediment for more than one team now.

@v2422 added limited support for this target in #322. You might give this a try @marcuschangarm

With the new version, I get the error after I try to continue the application:
(gdb) break mbedtls_ssl_handshake
Breakpoint 1 at 0x30025160
(gdb) mon reset
(gdb) c
Continuing.
Warning:
Cannot insert breakpoint 1.
Cannot access memory at address 0x30025160

(gdb) mon reset
Protocol error with Rcmd
(gdb)

And this is the error output from pyOCD:
0040177:ERROR:gdbserver:Unhandled exception in handleMsg:
Traceback (most recent call last):
  File "/Library/Python/2.7/site-packages/pyOCD/gdbserver/gdbserver.py", line 471, in handleMsg
    reply = handler(msg[msgStart:])
  File "/Library/Python/2.7/site-packages/pyOCD/gdbserver/gdbserver.py", line 1016, in handleQuery
    return self.handleRemoteCommand(cmd)
  File "/Library/Python/2.7/site-packages/pyOCD/gdbserver/gdbserver.py", line 1125, in handleRemoteCommand
    self.target.resetStopOnReset()
  File "/Library/Python/2.7/site-packages/pyOCD/core/coresight_target.py", line 188, in resetStopOnReset
    return self.selected_core.resetStopOnReset(software_reset)
  File "/Library/Python/2.7/site-packages/pyOCD/coresight/cortex_m.py", line 529, in resetStopOnReset
    self.halt()
  File "/Library/Python/2.7/site-packages/pyOCD/coresight/cortex_m.py", line 442, in halt
    self.dp.flush()
  File "/Library/Python/2.7/site-packages/pyOCD/coresight/dap.py", line 125, in flush
    self.link.flush()
  File "/Library/Python/2.7/site-packages/pyOCD/pyDAPAccess/dap_access_cmsis_dap.py", line 583, in flush
    self._read_packet()
  File "/Library/Python/2.7/site-packages/pyOCD/pyDAPAccess/dap_access_cmsis_dap.py", line 738, in _read_packet
    decoded_data = cmd.decode_data(raw_data)
  File "/Library/Python/2.7/site-packages/pyOCD/pyDAPAccess/dap_access_cmsis_dap.py", line 419, in decode_data
    data = self._decode_transfer_data(data)
  File "/Library/Python/2.7/site-packages/pyOCD/pyDAPAccess/dap_access_cmsis_dap.py", line 317, in _decode_transfer_data
    raise DAPAccessIntf.TransferTimeoutError()
TransferTimeoutError

I'm using the newest Daplink 0243 and invoking pyOCD with the rtl8195am target.

@v2422

Hi @marcuschangarm,
0x3xxxxxxx belongs to SDRAM. I think the reason is that SDRAM can't be accessed without initialization after reset. And breakpoint setup will try to do it.
I will trying to fix it from pyOCD. Before that, I think you can stop at some early place after bootloader first, then setup your SDRAM breakpoint. Like the following sequence
(gdb) b PLAT_Start
(gdb) mon reset
(gdb) c
(gdb) b mbedtls_ssl_handshake

Besides, I found that we can't set a hardware breakpoint at the address > 0x20000000.
https://github.com/mbedmicro/pyOCD/blob/master/pyOCD/debug/breakpoints/manager.py#L52
Is it the limitation from coresight hardware?

@v2422 Thank you for looking into this!
As a reference, I can confirm that using a Segger JLink attached to the JTAG port allows me to set breakpoints in the SD-RAM.
However, I'm still having problems stepping through the code. I wonder if the elf-to-bin python script is confusing the debugger? and/or the pre-compiled binaries?

Hi @marcuschangarm,
I don't fully understand. Could you describe more details?

What's the break type about breakpoint/step on Segger? SW or HW breakpoint?
Frankly speaking, elf-to-bin just transfers an ELF file into the image stored in flash. The bootloader initializes SDRAM then copies text/data to its execution address. The debugger just reads ELF then setups breakpoints on specific address. elf-to-bin should not influence debugger.

@marcuschangarm Could you please help answer Viller's questions?

Hi, sorry for the delay.
I misunderstood your original reply. When I do what you wrote I can debug the RTL8195AM using my Segger JLink. (I can't see what type of breakpoints it is setting, though).
When I use pyOCD, I don't get the break at PLAT_Start, the application just continues.

Hi @marcuschangarm,
I think the bootloader overwrite your break instruction in PLAT_Start. Please replace b PLAT_Start with hb PLAT_Start
The steps look like,

mon reset
b PLAT_Start ; replace the instruction with BREAK
continue
bootloader copies instructions from LMA to VMA; in the steps, it overwrites your BREAK with real instruction
PC goes to PLAT_Start

In steps 4, your software breakpoint is overwritten, so please use hardware breakpoint before bootloader. Then CPU will stop at PLAT_Start. Besides, what's the address of PLAT_Start?

Hi @v2422, yep, the limitation here is a hardware limitation of the coresight breakpoint module. The address compare register of the FBP (flash break point) module only supports up to bit 28 (0 to 0x1FFFFFFF).
As a workaround, you may be able to use a data breakpoint to determine when the image has been loaded into ram. Once loaded you could use breakpoints like normal.


kxd-02 upgrade to latest ubuntu + xrdp

upgrade the container to the latest stable ubuntu and xrdp versions

https://github.com/kxes/desktop/commit/3af0b974f917c98f3aa2179547ffdc1212c23080 uses stock ubuntu zesty as base


Allow Password Input From Standard Input for Increased Security

Description
Currently, the qpdf utility requires the password to be entered as part of the command line argument (--password=password). This method poses a security risk as the password can be stored in the shell command history or might be visible to others on shared systems.
Proposed Feature
It would be highly beneficial for security purposes if qpdf could allow the password to be read from standard input (stdin). This change would enable scripts and users to provide passwords in a more secure manner, avoiding the need to expose sensitive information in the command line or scripts.
Current Behavior
When trying to decrypt a PDF with qpdf, the command line syntax requires explicitly specifying the password in the command, as shown below:
qpdf --decrypt --password=password in.pdf out.pdf

This method outputs an error if tried without explicitly mentioning the password:
qpdf: --password must be given as --password=password

Suggested Solution
I suggest implementing a feature where qpdf can accept passwords piped from another command or inputted directly into the command prompt without showing up in the command history. This could potentially be implemented with a flag like --password-stdin which when set, makes qpdf read the password from stdin.
Temporary Solution Until Feature is Implemented
For those needing a secure method to input the password currently, the following workaround can be used:
read -s -p "Enter PDF Password: " PDFPASSWORD && qpdf --decrypt --password="$PDFPASSWORD" input.pdf output.pdf && unset PDFPASSWORD

@im7mortal  , have you read the documentation for the --password and --password-file options at https://qpdf.readthedocs.io/en/stable/cli.html#general-options? I believe this covers what you are suggesting, but if it doesn't can you please explain.

@im7mortal As @m-holger points out, there is already a way to do what you want by writing the password to a file, so I don't think I will add a separate feature for qpdf to do this.


oc client version links updated in _modules.yml

@kmurudi The _modules.yml was updated with correct links from previous PR, but the install.adoc can remain. If you remove the _modules.yml I'll merge it.
Or, you can close the PR, and I'll add it. I'd rather have your contribution, but it's up to you.

Hi Jorge,
So, I'll remove the _modules.yml folder from my local repo and then submit
a PR?
Regards,
Kshitija Murudi
On Mon, Jun 26, 2017 at 5:34 AM, Jorge Morales Pou<EMAIL_ADDRESS>
wrote:

@kmurudi https://github.com/kmurudi The _modules.yml was updated with
correct links from previous PR, but the install.adoc can remain. If you
remove the _modules.yml I'll merge it.
Or, you can close the PR, and I'll add it. I'd rather have your
contribution, but it's up to you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/osevg/workshopper-content/pull/43#issuecomment-311010451,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZHYTpwckY-mhIa1BgAnP2vFE3KXmfbuks5sH3stgaJpZM4OD8fV
.

Yes, but if you can squash the commit, then it'll be easier. Else, you can just open a new PR with just the change in install.adoc (That's what I usually do as I'm no git expert).

@kmurudi Still you have deleted the file, which will delete it in our repo.
I would just recommend you doing a new PR with the only change in install.adoc

Sure, I shall do that and submit a new PR


Bias detection module

Description of feature
Pre-requisite: https://github.com/theislab/ehrapy/issues/637
This serves as a meta issue to collect ideas for a bias detection and mitigation module:

[x] #645
[x] Missingness per feature -> missingno stuff
[x] IQR outliers -> https://github.com/theislab/ehrapy/issues/648 for numerical data @Zethson
[x] value counts for categorical counts + warnings? Some things are already in tableone @Zethson
[x] sensitivity analysis - easy with ehrapy because the API is so easy @Zethson
[x] Imbalanced subsampling through https://imbalanced-learn.org/stable/index.html ? -> only the most important sampling features in ehrapy. Not the generation stuff. @eroell
[ ] Propensity score matching @Lilly-May
[x] standardized mean differences for numerical data @Lilly-May (#690)
[x] Correlations between variables @Lilly-May (#690)
[x] Feature importance -> requires target variable (only run if set) @Lilly-May (#690)
[x] generate_bias_report that runs a lot of methods subsequently and summarizes things?!? @Lilly-May (#690)

Regarding propensity score matching, we already have that implemented for causal inference with dowhy here. If we implement a causal discovery module (#619), implementing a propensity score matching algorithm would be important, but until then, I don't really see the need. However, please feel free to disagree!
Should we close this issue then?

Yup! Let's close
May 4, 2024 12:18:43 PM Lilly May @.***>:

Regarding propensity score matching, we already have that implemented for causal inference with dowhy here[https://github.com/theislab/ehrapy/blob/1b5165d925f87304948fffe9b76cc68669ee6ab2/ehrapy/tools/causal/_dowhy.py#L37]. If we implement a causal discovery module (#619[https://github.com/theislab/ehrapy/issues/619]), implementing a propensity score matching algorithm would be important, but until then, I don't really see the need. However, please feel free to disagree!
Should we close this issue then?
—
Reply to this email directly, view it on GitHub[https://github.com/theislab/ehrapy/issues/647#issuecomment-2094108522], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AFHQA2DLHMCVC4RXT7X73RLZASYYDAVCNFSM6AAAAABCUZSVTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJUGEYDQNJSGI].
You are receiving this because you were mentioned.
[Tracking image][https://github.com/notifications/beacon/AFHQA2AQRISA2GSRSJRFIFTZASYYDA5CNFSM6AAAAABCUZSVTWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT42GHWU.gif]


"otaUnlock": false and trying to unlock it doesn't work

Hi,
I am having problems to flash Sonoff Mini
I set up the AP sonoffDiy and the device connects properly
This is the response to
curl http://<deviceIP>:8081/zeroconf/info -XPOST --data '{"deviceid":"<deviceID>","data":{} }'
{"seq":2,"error":0,"data":" {\"switch\":\"off\",\"startup\":\"off\",\"pulse\":\"off\",\"pulseWidth\":500,\"ssid\":\"sonoffDiy\",\"otaUnlock\":false}"}
When I run
curl http://<deviceIP>:8081/zeroconf/ota_unlock -XPOST --data '{"deviceid":"<deviceID>","data":{} }'
I get no response, it just hangs or fails or returns failed to connect or network unreacheable

Sorry, it was an issue with my network setup.
It is working fine now


Rclone Haagrid

Updated Analytic

Detect RClone Command-Line Usage

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect RClone Command-Line Usage :x:

diskUsage: 536576
runDuration: 4.178s
scanCount: 61

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect RClone Command-Line Usage :x:

diskUsage: 647168
runDuration: 2.944s
scanCount: 61

This PR was created by Automated Detection Testing Service :robot:
Tested detections:
Detect RClone Command-Line Usage :white_check_mark:

diskUsage: 507904
runDuration: 7.966s
scanCount: 5653


Add support for SQLRecordManager

The Record Manager capabilities in LangChain help to deduplicate content, clean-up deleted or mutated source content, etc.: https://python.langchain.com/docs/modules/data_connection/indexing
Adding such capabilities would make it easier to manage embeddings in CrateDB via LangChain.

Hi Christian,
this is interesting. The "Requirements" section of the corresponding documentation ^1 says:

Only works with LangChain vectorstore's that support:
document addition by id (add_documents method with ids argument)
delete by id (delete method with)

... and lists a few compatible vector stores.
Did you already verify it does not work well with CrateDB, and why?
With kind regards,
Andreas.

I did try to use the record manager. It works when I use a sqlite table for the record manager to store its metadata but not when I want to use cratedb itself for that purpose. The reason is that the table uses some sql features that the cratedb dialekt does not support.

Only works with LangChain vectorstore's that support:
document addition by id (add_documents method with ids argument)
delete by id (delete method with)
I think we need to distinguish 2 datastores. In one the embeddings are stored and in an additional SQL database the metadata is stored.
The cratedb vector store can already handle the embeddings but not yet the sql metadata table.

Hi.
Thank you for presenting this subsystem of LangChain, we apparently missed to add support on the first iteration. Given that the corresponding documentation lists the PGVector adapter as supported, there are chances it can also be supported by CrateDB.
With kind regards,
Andreas.

Hi again. GH-18 explores the situation, but unfortunately, it can't be made work, as there is indeed a blocker. So, we will probably close this as "wontfix".

it would be more of a nice to have. Can't close it for some reason.

Hi Alex,
thanks for clarifying. We can also keep the issue open to track this topic into the future. When corresponding support will be added to CrateDB, we can easily also add support here. However, it is unlikely, because enforcing uniqueness constraints on larger-than-memory data will be a significant performance hog.

https://github.com/crate/crate/issues/10279

With kind regards,
Andreas.


gh-650 - Update Jackson version to align with Hadoop

Closing this as I don't think moving to Jackson version 2.3.1 is a good idea as it is quite old and we lose several a few features. Also it would be incompatible with several libraries such as spark.


BUG: Misleading Tweet Links Redirect to Scam Contents

Describe the bug
Scam pages are tagging me in their tweets and sharing tweet links such as m.twitter.com/binance/..., but when clicked, they redirect to a different tweet, which is a scam tweet posted by a scammer. Upon inspecting the element, I can confirm that the link is the original Twitter link.
To Reproduce
Steps to reproduce the behavior:

Go to Twitter and log in.
Navigate to the tweet with the tag or mention from the scam page.
Click on the tweet link provided (e.g., m.twitter.com/binance/...).
Observe that the link redirects to a different tweet, which is a scam.
An example: Scam Tweet

Expected behavior
The tweet link should lead to the original tweet mentioned in the scam page's tweet.
Screenshots
I am sharing the SS's and a video:
https://github.com/twitter/opensource-website/assets/44838743/66af3d49-e7f8-4693-8a7a-fc5a502cf264

Environment
All of the OS's and browsers are affected from this issue. I am using an android device and it is the same as web.
Additional context
I posted a tweet about this bug.

Upon conducting further tests, we've observed that Twitter redirects based on the status number at the end of the link. If the status number remains the same, tweets are consistently redirected to the same tweet. This seems to be the underlying mechanism behind the issue. Please consider this additional information when investigating the bug.


fix: select slowquery from slowquery table

Query slowquery detail will return: No database selected
This bug was introduced by add integration test:
https://github.com/pingcap/tidb-dashboard/pull/1083/files#diff-d0511bdf3eb8b77043a7cb8623422847e3e3d5dc5c033dbd63616a52cd8b1131L107-L108
https://github.com/pingcap/tidb-dashboard/pull/1083/files#diff-0a7ec858724330a3973a9ecac7cfa0699ca7d5c6231b5e68d4207d8331fadff0R97-R98

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@37aa6b2). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master   #1114   +/-   ##
========================================
  Coverage          ?   7.05%
========================================
  Files             ?      32
  Lines             ?    1943
  Branches          ?       0
========================================
  Hits              ?     137
  Misses            ?    1795
  Partials          ?      11

Flag
Coverage Δ

be_integration_test_v4.0.1
7.05% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37aa6b2...38c1220. Read the comment docs.


dhcpcd: 6.9.4 -> 6.10.1 (security)

Things done:

[x] Tested using sandboxing (nix-build --option build-use-chroot true or nix.useChroot on NixOS)
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

More
cc @edolstra

Fixes CVE-2016-1503 & CVE-2016-1504.
Changelog:

http://roy.marples.name/archives/dhcpcd-discuss/2016/1143.html
http://roy.marples.name/archives/dhcpcd-discuss/2016/1146.html

@domenkozar This should probably be integrated into 16.03. I did some testing, but probably not too extensively to check all use cases. Is it too late for 16.03?

For security fixes it's never too late. Are there any other (larger) changes in the bump? (I couldn't quickly find NEWS around their homepage and files.)

Looking at the changelog you linked, it seems like maintenance-style changes. Also, updating seems recommended:

[...] I do encourge everyone to upgrade to dhcpcd-6.10.0 which has a lot of other fixes since those versions as well!

We apply security updates to stable branches, so yes.

Thanks. Cherry-picked to 15.09 & 16.03.


Explain inlineCallbacks and coroutine decorators

See #343.

Please don't merge. To be completed.


ion-menu error on swipe

Bug Report
Ionic version:
[x] 4.x
Current behavior:
When I swipe to open my side menu immediately after the app loaded, the app freezes. When I first tap the menu toggle button and then swipe, everything is fine.
Expected behavior:
App doesn't freeze.
Steps to reproduce:
I was able to reproduce this in Chrome and sometimes I got to see an error (see stacktrace below). I'm even able to get the preview to freeze on the Ionic docs when I swipe just before the app's first view is loaded: https://ionicframework.com/docs/api/menu
Related code:
The stacktrace below led me to this file: core/src/components/menu/menu.tsx of this repo.
The error comes from the loadAnimation function where this.menuInnerEl is undefined at that time:
const width = this.menuInnerEl!.offsetWidth;

Other information:
Stacktrace:
zone.js:682 Unhandled Promise rejection: Cannot read property 'offsetWidth' of undefined ; Zone: <root> ; Task: Promise.then ; Value: TypeError: Cannot read property 'offsetWidth' of undefined
   at t.<anonymous> (n5wnzrch.entry.js:1)
   at step (tslib.js:97)
   at Object.next (tslib.js:78)
   at tslib.js:71
   at new ZoneAwarePromise (zone.js:910)
   at Module.__awaiter (tslib.js:67)
   at t.loadAnimation (n5wnzrch.entry.js:1)
   at t.onWillStart (n5wnzrch.entry.js:1)
   at onWillStart (n5wnzrch.entry.js:1)
   at m (chunk-f56eaea8.js:1) TypeError: Cannot read property 'offsetWidth' of undefined
   at t.<anonymous> (http://localhost:8100/70.js:44:4283)
   at step (http://localhost:8100/80.js:158:21)
   at Object.next (http://localhost:8100/80.js:139:51)
   at http://localhost:8100/80.js:132:69
   at new ZoneAwarePromise (http://localhost:8100/polyfills.js:3268:29)
   at Module.__awaiter (http://localhost:8100/80.js:128:10)
   at t.loadAnimation (http://localhost:8100/70.js:44:4107)
   at t.onWillStart (http://localhost:8100/70.js:44:5351)
   at onWillStart (http://localhost:8100/70.js:44:2193)
   at m (http://localhost:8100/common.js:84:6209)

Ionic info:
   ionic (Ionic CLI)             : 4.10.2 (/usr/local/lib/node_modules/ionic)
   Ionic Framework               : @ionic/angular 4.2.0
   @angular-devkit/build-angular : 0.12.4
   @angular-devkit/schematics    : 7.2.4
   @angular/cli                  : 7.2.4
   @ionic/angular-toolkit        : 1.5.0

Hi there,
Thanks for the issue. I am unable to reproduce this. Can you provide a repository with the code required to reproduce this issue?
Thanks!

I even get this behaviour on the ionic docs site. I made a short screen recording to show you what I mean: https://www.youtube.com/watch?v=NJImYz6dOAE
I get the same when developing the app in Chrome and when deploying it to an Android device. It doesn't show an error mostly, but sometimes it does and I get a stacktrace as the one above. FireFox also shows the same behaviour.

I also get this with the Ionic side nav starter project. But you already have to swipe before the view is loaded (when the splash screen would still be active in an Android app).

This has been reported earlier this year. Still open issue #16985

@liamdebeasi I just installed and built this repo that demonstrates this issue. The debug and release apks are in the releases folder. Since this a minimal app, in order to replicate the issue, you would need to frantically swipe right-to-left immediately after launching. After splashscreen disappears, swipe to see if left and right sidemenus operate as expected.
I do have a more developed ionic app, AIT, that needs no frantic swiping, just swipe normally upon launching and the issue will be seen.

I fixed it for now using the swipeGesture input on ion-menu. It's set to false until the splash screen is hidden.

@Mawi137 I used that yesterday and the problem was still persistent. Perhaps whenever the UI thread is processing, any swipe gestures will interfere with layout, IDK.
swipeGesture isn't documented, so for the record, I assumed you used it in the template in a similar fashion as the following?
<ion-menu [swipeGesture]="isSwipeEnabled" ... >

Indeed, but it only fixed the issue on my laptop, not when running it as an Android app..

I added some logging to the menu.tsx file and it seems like it only captures the start of the swipe gesture, but no move, end or notCaptured. So it add the show-menu css class, but doesn't start the menu animation, so you don't see the menu and clicking is blocked..

Hi everyone,
I was able to reproduce this issue. We will look into it!
Thanks!

what's the status of this?

I'm having to disable menu gestures (which is a pain for ux) to avoid issues on scroll. that's crazy.

correction: even disabling gestures the whole view still being blocked. no scroll no touch after closing menu.

@stewwan in regards to your last post, it seems you may be running into this other issue #16002.
I spent significant amount of time trying to find solutions for these issues and finally settled on the following workaround for my app. I've only developed this app to be used on Android, so I'm not sure how or if it pertains to iOS:

From a UX perspective

Replaced the default splashscreen plugin by using cordova-plugin-lottie-splashscreen. I can't recall if this is required for this workaround. Since, I believe, if the user interacts with the display when the splashscreen is shown this issue will be replicated.
After splashscreen is hidden, my app disables swiping and menus, and are only enabled when the user taps on a button.

From a code perspective

My app's app.component.html has the following, which areSideMenusInteractive field is set to true after user has tapped on button mentioned above:

<ion-app ngClass="{{theme}}">
  <ion-menu side="start" menuId="start" [swipeGesture]="areSideMenusInteractive">
    <side-menu id="start"></side-menu>
  </ion-menu>
  <ion-menu side="end" menuId="end" [swipeGesture]="areSideMenusInteractive">
    <side-menu id="end"></side-menu>
  </ion-menu>
  <ion-router-outlet main></ion-router-outlet>
</ion-app>

In an addition, I'm also setting the side menus to be enabled in this fashion after user has tapped on button:

 this.menuCtrl.enable(value, 'start')])
 .then(() => {
   return Promise.resolve();
 })
 .catch((reason) => {
   error(reason);
 });

AND NOT setting the side menus to be enabled in this fashion after user has tapped on button:

// broken code below
this.menuCtrl.get(id)
.then((element) => {
  element.swipeGesture = value;
  return Promise.resolve();
})
.catch((reason) => {
  error(reason);
});

I hope that helps.

unfortunately it doesn't @marckassay but thanks for your time. my problem is  related with long lists fetched asynchronously and on demand (when you reach the bottom of screen). am still trying to reproduce this problem in a freshed ionic app to share.

I'm having this same issue. Are there any updates?

@hanibhat I'm curious to know myself since I haven't been programming in Ionic since May. I received notification for PR #18806 a few weeks ago, which I believe is a related issue. Hopefully someone will chime in to clarify.
If I recall correctly, the splashscreen suggestion that I gave above wasn't needed, but the other part is:

After splashscreen is hidden, my app disables swiping and menus, and are only enabled when the user taps on a button.

So in other words, the first gesture cannot be a swipe. It must be a tap. Afterwards, enable swiping and all gestures function normally without side effects.

I have installed 4.8.0, for me only a double swipe resulted in a problem and it was 'easily' resolved with blocking after an initial open:
<ion-menu [swipeGesture]="appMenuSwipeGesture" (ionDidOpen)="appMenuSwipeGesture = false" (ionDidClose)="appMenuSwipeGesture = true">
</ion-menu>

I also set appMenuSwipeGesture = true on ngOnInit.
Good luck!

The the snippet below finally worked for me. Like the recommendation above, I had to disable swipeGesture until the menu has been open at least once.
<ion-menu [swipeGesture]="appMenuSwipeGesture" (ionDidOpen)="appMenuSwipeGesture = true">
However, I initialize appMenuSwipeGesture to false.

Looks like ion-menu-backdrop is blocking ui.

I think were trying to show an ion-menu which hasnt fully initialized yet.  Is there any way to detect when the ion-menu exists and is fully initialized?  I think this is the solution we need

For anyone else getting stuck on this, it looks like this issue was already fixed in the latest ionic version, updating to 4.9.0 seems to fix it for us 🎉

I'm using ionic 5.4.1 and this issue still on

@Flip32 What version of Ionic Framework are you using? Ionic 5.4.1 is likely referring to the version of the Ionic CLI.

@Flip32 What version of Ionic Framework are you using? Ionic 5.4.1 is likely referring to the version of the Ionic CLI.

Here my Info:
Ionic CLI                     : 5.4.1 (/usr/lib/node_modules/ionic)
Ionic Framework               : @ionic/angular 4.9.1
@angular-devkit/build-angular : 0.801.3
@angular-devkit/schematics    : 8.1.3
@angular/cli                  : 8.1.3
@ionic/angular-toolkit        : 2.0.0

I had this problem on android with chrome version 72.0 ... and after updating it to the latest version 77.0 ... the menu works correctly

For those still running into issues: Please update to Ionic 4.10.0. We fixed a few more things that should resolve any outstanding issues with the menu swipe. Thanks!

For those still running into issues: Please update to Ionic 4.10.0. We fixed a few more things that should resolve any outstanding issues with the menu swipe. Thanks!

Yeah man! It worked fine here! tnks

I just updated my app as well and I can also confirm that the issue has been resolved. Thanks!
I'll close the issue ;)

updated ionic 4.9 to 4.11 and problem was fixed
tested on Android 5.1.1


Added my Pizza corner website.

I have made this pizza corner website using html and css.
Give a summary of the change that you have made
Fixes #29
NA
Mention any dependencies/packages used
Can add contact us page .
Mention any improvements to be done in future related to any file/feature
NA
Mention and tag the people

Add screenshots of relevant screens
Developer's checklist

[X] My PR follows the style guidelines of this project
[X] I have performed a self-check on my work

If changes are made in the code:

[X] I have followed the coding guidelines
[X] My changes in code generate no new warnings
[X] My changes are breaking another fix/feature of the project
[X] I have added test cases to show that my feature works
[X] I have added relevant screenshots in my PR

Your branch has a conflict
repull the main branch and do the necessary changes


Event Type for Webcast on-demand versus live Webcast?

What is the event type for a recorded performance that is available for viewing on-demand after the performance over several days, compared to an event that is broadcast live on the web?
Live broadcast --> Type of MusicEvent with Attendance Mode 'online'
On-demand viewing --> ? something that is not an event.
See example in issue Capacitor-API https://github.com/culturecreates/capacitor-api/issues/30

The live broadcast could indeed be any sub-type of adr:PerformingArtsEvent. We could also give it the additionalType BroadcastEvent type, but that would be redundant.
The on-demand webcast would also be an event, but of the type OnDemandEvent. The workPerformed would be a type Movie and this Movie object would be related to the Performance Work by some other property.
In either case, the eventAttendanceMode would be OnlineEventAttendanceMode and the location would be a VirtualLocation type.


Add some methods for CxxMatrix

Regarding Regarding https://github.com/TimSiebert1/ADOLC.jl/pull/13#issuecomment-2182419666: Why not just keep CxxMatrix as is and add the missing methods to make it a full fledged AbstractMatrix ?

We could. I just wanted to copy the values from the C++ matrix (or vector, or tensor) to the Julia matrix automatically and thought a combined struct would be a "smooth" way to handle this. However, we could also accept pre-allocated C++ and Julia data as input for the derivative! driver and do data transfer inside. What do you think?

For me it is not clear why the copy is needed. The finalize already works,
What would be a situation where a CxxMatrix would not work in place of a Matrix?
It is an AbstractMatrix and inherits all the methods of AbstractMatrix, e.g:
A=ADOLC.array_types.CxxMatrix{Cdouble}(rand(2,2))
2×2 ADOLC.array_types.CxxMatrix{Float64}:
0.825202  0.343862
0.855653  0.639062

julia> A\rand(2)
2-element Vector{Float64}:
0.6624650987529754
-0.1567069631504887

https://github.com/JuliaArrays/ArrayInterface.jl seems to allow a more precise specification of what can be done with a specific array type.

Ooooh. Didn't know that it is enough to have an AbstractMatrix.
I will add the support of the CxxMatrix (and the other types) over the weekend.


Accessing columnDefs render or data functions while inside $.fn.dataTableExt.afnFiltering

HI,
I wondered if I can access the columnDefs render or data functions while doing range filtering on the table, thats my code atm , and thats the test case. if I'll have access to the render or data functions it will simplify the filtering process.
I know that the visible value (after the apply of the render or data can be found inside the second argument aData, but I can't recall why eventually I prefered to use the fourth argument as the source of the column value :|
Thanks
https://github.com/vedmack/yadcf/issues/262

You can request the rendered data for a cell using cell().render(). There is also a plural version, cells().render() if you want the data for a whole row or column.
Allan

Can I access it inside my function (settingsDt, aData, iDataIndex, rowData) { function?
If yes than how?

You would need to do var api = new $.fn.dataTable.Api( settingsDt );. Then api.cell().render(). You might want to keep a local cache of the API instance (look it up by the settings object for example) otherwise you'd ned creating a new API instance for every call of that function which could be quite slow.
However, the data passed in as the second parameter should be the filtering rendered data already. This little example, based on the example in your linked thread, appears to confirm that.


Fix 2454

Fix #2454
Adding tabpanel to url upload for import project

Can one of the admins verify this patch?

@AppInventorWorkerBee ok to test


⚠ ClamAV has degraded performance

In 9293247, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 51 ms

Resolved: ClamAV performance has improved in 17d6868.


Can you add a license to is-os module?

Can you add a license to is-os module? Thank you!

Sure!

added MIT license, published on npm as version 1.0.1


 Sounds like a change to have some more emoji fun to me! :smile:
🎅 🤶 ❄ ⛄... 🐮?  🥕 !


has_many through counters

I have this kind of relations:
NetworkAddress
has_one :asset, inverse_of: :network_address, dependent: :nullify
has_one :building, through: :asset
Asset
belongs_to :network_address, inverse_of: :asset
belongs_to :building, inverse_of: :assets
Building
has_many :assets, through: :rooms
has_many :network_addresses, through: :assets
Room
belongs_to :building, inverse_of: :rooms
has_many  :assets, inverse_of: :room, dependent: :nullify
has_many  :network_addresses, through: :assets
Is there any way I could get network_address_count on Building?

This is all documented in the README.
In your case adding counter_culture [:asset, :building] on NetworkAddress should do the trick.

Sorry Magnus, but I read it more than 10 times, and I have also tried what you gave for example and it didn't do the trick. So I opened this ticket. It simply doesn't do a correct query

I can't help with this without a lot more information, unfortunately. And I don't really have the time to help debug this even if I had the complete code. If this is due to a bug in counter_culture the best thing you can do is to fork this repository and add a failing test. Then you can pull-request that which will allow me to look into it.
Thanks.


Bump version to 0.16.0 and update CHANGELOG.md

Any objections, @tmuxinator/tmuxinator?
Also, what would people think about cutting a 1.0 release and making an effort to more closely adhere to semver in future releases?

No objections.  I am definitely in favor of cutting a 1.0.0 release; it seems about time :).  Were you thinking we just draw a line in the sand and say "this is one-point-oh", or is there a particular milestone you had in mind?

@adamstrickland I was thinking of arbitrarily making the release after 0.16.0 the 1.0.0 release. I'm definitely open to pushing this back if you or anyone else thinks there are any pending issues/PRs that should hold this up.


AutoLayout

Does this/textView support autolayout?

I see that it says so on the Readme. But why does it have to be initialized with a frame or storyboard. I would like to create it programmatically and use autolayout to position it. Is that possible?

Thanks @ben95beng & @PavelGerashchenko, I'll work on fixing this soon

Also in need of this :)

Welcoming any and all pull requests to fix this. I'll be pretty busy with other work for the next few months at the very least so unfortunately I won't have time to look into it.

It should be easy to support autolayout with current design if RPFloatingPlaceholderAnimateDownward is removed. Otherwise, it should be a UIView that aggregates UILabel and UITextField/UITextView, rather then subclassing them.

It does not support autolayout, i want it badly. Look at my screenshot

Use https://github.com/jverdi/JVFloatLabeledTextField instead


remove compile.sh from doc

What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Should compile.sh itself be removed, if not needed?

As meeting discuss, not now. Someone may still use compile.sh. We will remove it after some time.

As meeting discuss, not now. Someone may still use compile.sh. We will remove it after some time.

So could it be better to mark that file as deprecated (via adding comments)? So we don't forget removing it in the fullness of time?


Does not work well against the LCD of M5Stack CoreMP135

Hi.
I created the following script to test this library against the LCD of M5Stack CoreMP135.
Mix.install([
  {:framebuffer, github: "livinginthepast/framebuffer"}
])

{:ok, fb} = Framebuffer.open()
Framebuffer.clear(fb)

for x <- 0..99 do
  Framebuffer.put_pixel(fb, x, 10, {255, 0, 0})
end

No errors occurred, but there was no change in the LCD.
If there are any errors in the usage, I would appreciate it if you could let me know.
I understand that this library is a work in progress.

A couple of things to try:

IO.puts(fb) — this will output a bunch of things about the framebuffer... does the geometry make sense?
Look at the fb.fix_screeninfo vs its fb.var_screeninfo.
export NIF_DEBUG=true and recompile. You might need to add force: true to your mix install to make it recompile.

When I was working on this, it was for a pretty simple display that had pretty low bits per pixel. My initial guess is that the NIF is either getting incorrect values for the screen out of ioctl or that I have bad arithmetic for the color space of your device.
Also just wanted to note that this library draws pretty slows, and I never got to the point of trying to optimizing anything. I'm also kind of swamped by work so don't have a whole lot of time to add features—if you can figure out what's going wrong I'll be happy to merge pull requests, without much ability to verify them myself.


Cloned ManagedObject loses ownership to their component

OpenUI5 version: 1.79.0
Browser/version (+device/version):

Chrome Version: 84.0.4147.89
Firefox Version: 76.0.1

URL (minimal example if possible)
https://plnkr.co/edit/ra4RUpSskef6YBjV
Steps to reproduce the problem:

bind an aggregation of a control with template or factory
all elements in this aggregation have an undefined _sOwnerId
Component.getOwnerComponentFor does not work for cloned ManagedObjects

What is the expected result?
Bounded (cloned template) ManagedObjects should not lost their ownership to their origin component.
What happens instead?
After the binding template was cloned the _sOwnerId is not cloned from the original.
Is this by design?

Hello @danielang ,
Thank you for sharing this finding. I've created an internal incident<PHONE_NUMBER>. The status of the issue will be updated here in GitHub.
Regards, Diana

Hello @Shtilianova
Any news about this topic?
Thank you!

Hi @danielang, we're looking into how that could possibly be addressed with existing API. Looks like one would need to getOwnerComponent, then runAsOwner on the component and provide the owner id. We'll let you know soon, AE

Hi @ecker, thank you for looking into this.
My current workaround is to overwrite the clone method of the ManagedObject with this:
/**
 * Called by UI5 to clone a ManagedObject
 * @returns {Package}
 */
clone: function () {
    const oContext = this;
    const aArguments = arguments;

    const oComponent = this.getComponent();

    // run clone method in component context, so the clone is owned by the component and could resolve it
    return oComponent.runAsOwner(function () {
        return ManagedObject.prototype.clone.apply(oContext, aArguments);
    });
},


Issue #4

Fixes https://github.com/Universal-Variability-Language/uvl-lsp/issues/4
We implemented:

floor function
ceil function
checked for TYPE-level definitions

TYPE-level.numeric-constraints enable floor and ceil
TYPE-level.string-constraints enable len and string operations/comparison

This image shows that ceil is integrated within the current system, including SAT-check and attribute-reference.

Here is a sample uvl model for a quick-test of added functionality:
include
    SMT-level.*
	//TYPE-level.* // comment all TYPE-level includes to see errors on explicitly typed features
	TYPE-level.numeric-constraints // comment to see errors on floor/ceil
	TYPE-level.string-constraints // comment to see errors on string operations within constraints

features
	String feature1 {attr1 1.2, attr2 'vier'}
	feature
	feature3
	Integer feature2
		alternative
			feature5
			Real feature4
constraints

    //
    //*** string operations
    //
    len('test') == 4
    len(feature1) == 4
    len(feature1.attr2) == 4
    // len('test') == 3 // UNSAT
    'test' == 'test'
    'test' < 'Test'
    'TEST' > 'Test'

    //
    //*** floor / ceil
    //
    floor(2.0) == 2 // works
    floor(2.2) == 2 // works
    floor(2.7) == 2 // works
    // floor(2.2) == 3 // UNSAT
    ceil(2.0) == 2 // works
    ceil(2.2) == 3 // works
    ceil(2.7) == 3 // works
    // ceil(2.2) == 2 // UNSAT

    //*** negative values
    floor((0-1)) == (0-1) // works
    floor((0-1.2)) == (0-2) // works
    //floor((0-1.2)) == (0-1) // UNSAT
    ceil((0-1)) == (0-1) // works
    ceil((0-1.2)) == (0-1) // works
    //ceil((0-1.2)) == (0-2) // UNSAT

    //*** attribute reference
    floor(feature1.attr1) == 1 // works
    ceil(feature1.attr1) == 2 // works
    //floor(feature1.attr1) == 2 // UNSAT
    //ceil(feature1.attr1) == 1 // UNSAT

Regarding conflicts:
I don't know how I could update our branch with latest master, since we work on the forked repository.
It would be easiest to walk this through together (or I can do it with write access).
Quick note for the first conflict:
config_to_source should begin with
// create source to config z3 Solver
pub fn config_to_source(&self, module: &Module) -> String {
        let time = Instant::now();
        let mut out = "(set-option :produce-unsat-cores true)
            (define-fun smooth_div ((x Real) (y Real)) Real(if (not (= y 0.0))(/ x y)0.0))
            (define-fun floor ((x Real)) Int (to_int x))
            (define-fun ceil ((x Real)) Int (ite (= (to_int x) x) (to_int x) (to_int (+ x 1)) ))
            (set-option :smt.core.minimize true)\n"

Depending on your rights in the fork, you should be able to update your branch.
In general, the main branch on the fork should regularly be updated to mirror the main branch in the original repository. Then, you can merge the forks main branch to your branch to be up to date.


Improve error message propagation

Sometimes, when using the DgnDb.importSchemas API, we get a vague error message saying "Schema Import Failed." This doesn't tell us much, making it hard to determine what's wrong. This PR aims to enhance error message propagation by introducing additional error codes for better error message mapping.
A similar issue was being discussed in this GitHub thread https://github.com/iTwin/itwinjs-core/discussions/6679
itwinjs-core: https://github.com/iTwin/itwinjs-core/pull/6696

I am changing this pull request to a draft to make the required changes. This decision is based on the following reasons:

We do not want to pollute the DbResult enum further.
The main goal of this pull request was to propagate better error messages that describe why importSchemas failed. Instead of adding additional error messages, we will throw the last error message when the API fails.


cln backup-plugin update, add poetry

fixing: #3675 #3676 #3677
on to testing

Having a new issue now:
 INFO    plugin-backup.py: Killing plugin: exited before replying to getmanifest

did a new install with v1.9.0rc2 minimal image with  this branch, now getting:
Feb 19 15:32:49 raspberrypi systemd[1]: Started c-lightning daemon on mainnet.
Feb 19 15:32:58 raspberrypi sh[25987]: Traceback (most recent call last):
Feb 19 15:32:58 raspberrypi sh[25987]:   File "/home/bitcoin/cl-plugins-available/plugins/backup/backup.py", line 2, in <module>
Feb 19 15:32:59 raspberrypi sh[25987]:     from pyln.client import Plugin
Feb 19 15:32:59 raspberrypi sh[25987]: ModuleNotFoundError: No module named 'pyln'

Tested with a new install with v1.9.0rc2 minimal image with this branch and the backup plugin is activated now.

The CLN install with verification can be tested with:
# remove the old binary
sudo rm $(which lightningd)
# remove the old source code
sudo rm -rf /home/bitcoin/lightning
# install the new default version v23.02
config.scripts/cl.install.sh on

@openoms is this PR ready for merge?

@rootzoll yes, tests look good and full of fixes

updated CL REST and also tested ok so merging


Updated GTest to v1.10

Our current version of gtest is v1.7, from 2013. We also bypass all OS checks in the gtest CMakeLists.txt by linking it manually.
This change updates gtest, and uses its built-in CMakeLists.txt.

Before creating a pull request

[ N/A ] Document new methods and classes
[ N/A ] Format code with make format

Before merging a pull request

[ ] Set version target by selecting a milestone on the right side
[ ] Summarize this change in CHANGELOG.md
[ N/A ] Add unit test(s) for this change

Bump -- still curious whether gtest can be an externally-configured submodule or something rather than explicitly including all the files here.


Support of Prostate Tracer & IRS

🌟 Feature Request
📝 Description
Implement prestateTracer the same as what is available in
https://geth.ethereum.org/docs/developers/evm-tracing/built-in-tracers
An IRS on zkSync that allows users to build and verify their reputation based on their activity on the network. This system could use various factors, such as:
Transaction history
DAO participation
Social activity
Provide a clear and concise description of the feature you'd like to see.
🤔 Rationale
Explain why this feature is important and how it benefits the project.
📋 Additional Context
Add any other context or information about the feature request here.

The prestate tracer is part of the EIP specification. Would be greatly beneficial for us and others if support was added. Without it we cannot support zkSync.


Gcarla

Implement GPU computation for cpsd

Just remember that GPU with cupy is not testable without a real GPU


Fix bug where filename was not being updated when we follow a referen…

resolve #208

Coverage increased (+0.002%) to 99.593% when pulling 45b42d003789eb33a7aeca7e3b98325d8a4116fe on shrayus:master into dd68221a9a634997de67e66d09c7aab809625abd on striglia:master.

Coverage increased (+0.002%) to 99.593% when pulling 22e0bf6b3b9c03be94e61db2617b9e9fd39b4ae6 on shrayus:master into dd68221a9a634997de67e66d09c7aab809625abd on striglia:master.

Coverage increased (+0.002%) to 99.593% when pulling f5cf1496f5b24bc2551c7b90d954817a07055b9d on shrayus:master into dd68221a9a634997de67e66d09c7aab809625abd on striglia:master.

Coverage increased (+0.002%) to 99.593% when pulling 290ee87725ceb2ea21e9b904ee52ffca7972533e on shrayus:master into dd68221a9a634997de67e66d09c7aab809625abd on striglia:master.

Coverage increased (+0.002%) to 99.593% when pulling 290ee87725ceb2ea21e9b904ee52ffca7972533e on shrayus:master into dd68221a9a634997de67e66d09c7aab809625abd on striglia:master.

Coverage increased (+0.002%) to 99.593% when pulling 290ee87725ceb2ea21e9b904ee52ffca7972533e on shrayus:master into dd68221a9a634997de67e66d09c7aab809625abd on striglia:master.

@shrayus is this still relevant or will we fix this w/ #216?

@striglia this PR is relevant to flattening code that has been removed by #214 .

Cool @macisamuele, thought it might be outdated now. I'll close this out then, thanks!


Could not copy the file "targetBinaryFilePath" because it was not found.

https://github.com/microsoft/vcpkg/commit/7dff5e821e4a0b7fe43e8a28c51357217bb4bef6
Can someone please fix line 61 of that file
if ($copiedFilesLog) { Add-Content $copiedFilesLog targetBinaryFilePath -Encoding UTF8 }
should be:
if ($copiedFilesLog) { Add-Content $copiedFilesLog $targetBinaryFilePath -Encoding UTF8 }
Note the dollar sign is needed on the variable targetBinaryFilePath
The commit was done 20 hours ago and it just nuked my build
This is the error it gives in case you see other people report the same problem:

also - thank you for the awesome work you do on a wonderful tool :)

Thanks for the kind words! https://github.com/microsoft/vcpkg/pull/21429 has been merged and should fix this issue. Sorry for the trouble!


The brightness is not controlled properly when it is higher than 50%. The device randomly crashes when adjusting the brightness.

Before opening the issue, have you...?

[X] Searched for existing issues
[X] Looked through the wiki
[X] Updated MonitorControl to the latest version (if applicable)

Describe the bug

The brightness control bar does not control the brightness properly. The brightness will be reduced only when the brightness is below 50%, and there will be no change in adjusting the brightness between 50% ~ 100%.
When adjusting the brightness, there is a probability that the display will crash, but so far I have not found any law to reproduce, it seems to be a random occurrence. I had to reboot the device to get it back to normal.

I am not sure if I have described it clearly, if necessary please leave your email and I can send a video demonstrating the bug.
Steps to reproduce

Use the reduce brightness button on the keyboard to reduce the brightness
Reduce the brightness only when the brightness is reduced below 50%, and it has no effect when it is between 50% ~ 100%.

Expected behavior
Any range between 0% ~ 100% should take effect normally.
Anything else?
This bug was found in MonitorControl v4.1.0, I tried v4.0.2 and v4.0.1 both are working fine.
Environment Information (please complete the following information)
- macOS version: 12.3.1 Monterey
- Mac model: Mac mini (M1, 2020)
- MonitorControl version: v4.1.0
- Monitor(s): LG HDR 4K
- Apple Silicon/M1 (yes or no): yes

Hi, the app uses a combined brightness control approach by default. Between 0-50% the dimming is achieved via software means and beyond 50% there is hardware backlight control. If this part of the scale does not work then for some reason DDC control fails.
Can you an alternative app like BetterDisplay and see if control works properly?

Ohh but I see you did run v4.0.2 earlier with no problem. The issue most probably is that you are using HDMI connection which blocks hardware backlight control. You'd need to use the USB-C port of your Mini to connect the display for that. MC 4.1.0 had a check removed that blacklisted the HDMI port of various M1 devices (this is because many models are out now with differing service ports for HDMI and a blanket ban would also blacklist USB-C to HDMI dongles, most of which would work otherwise). If you want to fix this by using software control only, navigate to the Displays section of MonitorControl and disable DDC for the display.
Hope this helps!


While editing a Json type file, every time it saves, the cursor goes to the end of the file.

Issue Type: Bug
I have a Json file (I have it saved with a txt extension, but have selected Json as its typeof the file on the status bar) which when I edit it, and then save it, my cursor is not where I left it, it is at the bottom of the file.  It seems to be a problem with selecting the file type as Json.  When I select JSON with comments, the problem is gone.  If I have Auto-Save turned on or off, the cursor goes to the bottom of the file when ever it saves.
 (Can return to the previous state by closing and reopening VSCode). On save, automatic formatters get run, so I suspect one of them is causing the problem


Update runwarehouse.md

Suggest that we tell users to update from http to https "if required" (rather than "if you want to").  The user probably doesn't have a choice, the protocol must match the protocol of the host

Hi Karen, I'm going to close off this pull request as Matt Bailey added a slightly longer explanation in a separate pull request about an hour after your merge request came through. Cheers, Ben


revert the language clent channel change

For #21851
The PR: https://github.com/microsoft/azuredatastudio/pull/21591 hooked up the 'SQL Tools Service' output channel with the Data Protocol Client and the errors started show up in there in a very noticeable way. The particular error in the issue has always been there but caught the user's attention because of the different output locations.
for 1.41 release, I am reverting the output channel change so that users won't be annoyed, and, in the meanwhile, I will fix the actual problem in main branch.

Will address https://github.com/microsoft/azuredatastudio/issues/21854 too looks like

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.001%) to 41.78%

Files with Coverage Reduction
New Missed Lines
%

src/sql/workbench/services/connection/browser/connectionDialogWidget.ts
1
73.05%

Totals

Change from base Build<PHONE_NUMBER>:
-0.001%

Covered Lines:
28967

Relevant Lines:
64438

💛  - Coveralls


Remove reagent slimes from ghost role pool

About the PR
Removes reagent slimes from being ghost roles. closes #24155
Why / Balance
They apparently weren't supposed to ever be ghost roles.
Technical details

Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

:cl:

remove: Reagent slimes are no longer ghost roles.

Dummy components are stinky.


Failed to test Spring boot project

I tried to test a Spring boot project with Jazzer, but it can not get spring context.
Does Jazzer support testing Spring boot projects? Is there a demo?

While Jazzer by itself is mainly suited for fuzzing libraries, our commercial platform CI Fuzz, which builds on Jazzer, can fuzz entire web apps and also detect web-specific vulnerabilities.

While Jazzer by itself is mainly suited for fuzzing libraries, our commercial platform CI Fuzz, which builds on Jazzer, can fuzz entire web apps and also detect web-specific vulnerabilities.

Hi, where can I found CI Fuzz? Is it actively fuzzing or passive fuzzing（when fuzzing web apps)?

While Jazzer by itself is mainly suited for fuzzing libraries, our commercial platform CI Fuzz, which builds on Jazzer, can fuzz entire web apps and also detect web-specific vulnerabilities.

Hi, where can I found CI Fuzz? Is it actively fuzzing or passive fuzzing（when fuzzing web apps)?

You can just head over to app.code-intelligence.com and try it out. If you are interested in a demo of fuzzing web apps, don't hesitate to book a demo!

Hi, I found the introduction of CI Fuzz mentioned "ci-fuzz-on-prem-installer--linux", Is this commercial closed source, or can I download it from somewhere?

While Jazzer by itself is mainly suited for fuzzing libraries, our commercial platform CI Fuzz, which builds on Jazzer, can fuzz entire web apps and also detect web-specific vulnerabilities.

Hi, where can I found CI Fuzz? Is it actively fuzzing or passive fuzzing（when fuzzing web apps)?

You can just head over to app.code-intelligence.com and try it out. Specifically for web app fuzzing, we recommend that you talk to one of our experts directly and they can get you started quickly: https://www.code-intelligence.com/book-a-demo

Hi, I found the introduction of CI Fuzz mentioned "ci-fuzz-on-prem-installer--linux", Is this commercial closed source, or can I download it from somewhere?

Hi, I found the introduction of CI Fuzz mentioned "ci-fuzz-on-prem-installer--linux", Is this commercial closed source, or can I download it from somewhere?

This is our commercial, closed source offering building on top of Jazzer. We are happy to give a demo, if this is interesting for you :-)

Hi, I found the introduction of CI Fuzz mentioned "ci-fuzz-on-prem-installer--linux", Is this commercial closed source, or can I download it from somewhere?

This is our commercial, closed source offering built on top of Jazzer. We are happy to give a demo, if this is interesting for you :-)

Got that, thanks for your reply!


Added backward support for non JSON based DBs

Few Databases, like that one that comes by default with XAMPP, doesn't yet support JSON. This workaround used the text datatype instead of JSON when it's not supported. This is a basic change, but further modifications are welcome.

Hey,
I would like to keep it as is. This file is only a stub and every user can modify it before it's executed.
And I don't like to modify migration behavior the moment it's executed. If this migration runs against a DB that doesn't support JSON it throws an exception. In this moment the user knows that something doesn't match. This change will just switch the type without any notification. So if I want it to be JSON and just installed the wrong DB I will notice it sometime later during project runtime.
If we haven't it already I would accept a PR which adds this to the requirements and/or adds a hint how to solve it.

No problem
On Tue, Aug 13, 2019, 4:58 PM Tom Witkowski<EMAIL_ADDRESS>wrote:

Hey,
I would like to keep it as is. This file is only a stub and every user can
modify it before it's executed.
And I don't like to modify migration behavior the moment it's executed. If
this migration runs against a DB that doesn't support JSON it throws an
exception. In this moment the user knows that something doesn't match. This
change will just switch the type without any notification. So if I want it
to be JSON and just installed the wrong DB I will notice it sometime later
during project runtime.
If we haven't it already I would accept a PR which adds this to the
requirements and/or adds a hint how to solve it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spatie/laravel-activitylog/pull/581?email_source=notifications&email_token=AEA5VX5EAOZTK53KCZMT7Q3QEKLG5A5CNFSM4ILIABO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4FLV3I#issuecomment-520796909,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEA5VX6RZDQNC47PUI4GES3QEKLG5ANCNFSM4ILIABOQ
.

Thanks for your thoughts and time anyway! 😊


Add correction to objcthemis secure session for user friendly interface

need to review by @vixentael. Working websocket example in rep.

@mnaza there is a typo in method name:
https://github.com/cossacklabs/themis/pull/34/files#diff-106c9258d8e01f038bbd3b3bfe2ec838R112
i haven't seen it immediately (WE NEED TESTS!), but fixed in additional commit
https://github.com/cossacklabs/themis/commit/3fc7e881c8e8e9c1c73fda23a26fac616bc0927b


Add view-based Emoji search frontend

Fixes #514
Obviously still needs a lot of cleanup, but is this the right idea? Would you prefer separate modules for compose and views, or a way to swap the implementation in the same module (through an in app preference)?

Yes it should be in a separate module just like the 'counter' sample. We want to maintain both frontends at the same time.

@JakeWharton is ViewFlexContainer supposed to scroll by default?

I don't know the default. I would expect no.

@eygraber No - it shouldn't! Are you seeing that?

Sort of but not really. I think it has something to do with me nesting a RecyclerView under it, and the nested scrolling is causing the ScrollView inside ViewFlexContainer to scroll. I'll push something soon that shows that; just as soon as I get what I have back to a working state :sweat_smile:

Looks like the ViewFlexContainer was becoming scrollable due to some weird interaction with the RecyclerView. After starting to use RecyclerView correctly that behavior went away.

@eygraber Can you file an issue for the nested scrolling issue with RecyclerView? Ideally, ViewFlexContainer should never be scrollable unless its Overflow is set to Overflow.Scroll.

Filed https://github.com/cashapp/redwood/issues/519

Should be good to go


[fixed] Uncaught TypeError: Cannot read property 'state' of null when unmounting

Fixes the following issue (Using React 16):
Uncaught TypeError: Cannot read property 'state' of null
    at Modal.componentWillUnmount (Modal.js:119)
    at callComponentWillUnmountWithTimerInDev (react-dom.development.js:10413)
    at HTMLUnknownElement.callCallback (react-dom.development.js:1209)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:1248)
    at invokeGuardedCallback (react-dom.development.js:1105)
    at safelyCallComponentWillUnmount (react-dom.development.js:10421)
    at commitUnmount (react-dom.development.js:10711)
    at commitNestedUnmounts (react-dom.development.js:10575)
    at unmountHostComponents (react-dom.development.js:10632)
    at commitDeletion (react-dom.development.js:10682)

Changes proposed:

check existence of this.portal before trying to access it's state property

Acceptance Checklist:

[x] All commits have been squashed to one.
[x] The commit message follows the guidelines in CONTRIBUTING.md.

Coverage remained the same at 87.173% when pulling afe2de9e5286b025c134d304f942ca4f1aec55ec on danhayden:master into 92c23b5bdd6829b02a5d79dee105a00ab5063d3e on reactjs:master.

Coverage remained the same at 87.173% when pulling afe2de9e5286b025c134d304f942ca4f1aec55ec on danhayden:master into 92c23b5bdd6829b02a5d79dee105a00ab5063d3e on reactjs:master.

@danhayden Thank you. I'll get this merged today.

Released v2.2.3.
Thank you, @danhayden!


feat: 🎸 new progress circle component for angular

New Progress Circle component for Green Angular:

Hello @vsjolander. We are planning to use this component in a few of our applications in P&I team.
Here are some screenshots from our Figma:

Ok @sjkayle, thanks! Who's the designer?
I think this component will be used by more so need to get it documented in Design Library and get into Figma a reusable component! 😄

@vsjolander It was designed by Boon Ying of CX/Spartans team from KL.


How to go next page

Only shows 10 game, How to go next page.

Not available currently. Add the feature yourself its open source!

I already done that, I will pull requests. Also im working on a cookies generator to make the service all time available


Altsoftserial change

Hi. I replaced all refrences from softwareserial to altsoftserial. Connected rx and tx as described in altsoftserial.
I am not getting ok response.
What exactly do I need to change to use altsoftserial?

I will close this issue first. If you still need to discuss it, you can open it again


add path traversal mitigation

See #3.

Maybe it would be a good option in certain cases to sanitise instead of falling. This could be an optional crate feature.
For sanitation I would use sanitize-filename-reader-friendly or sanitise-file-name.

I've used the first crate as it is more often used. But it would be easy to change to the second one if its features are needed.

If the two remaining points don't need treatment, the PR is ready for merge (imho).

After more consideration, I've decided I'm not going to merge this. I'd like to keep this crate as simple as possible, which means in this case matching the API of the standard PathBuf type and not protecting against merging multiple segments at once. I understand the implication but don't think of this as a meaningful difference from what std does.

No problem. I've released it as the separate crate path_ratchet as there is nothing equivalent.
#3 can probably be closed.

Cool! I'll close the isuse too then. Looks like a good crate!


"Resolution is not 1920x1080"

I'm running on Nox android 5 and have have checked the 1080p option. Am I missing anything else?
https://ibb.co/PN87yVB

Run adb shell wm size on a cmd and send me the output.

https://ibb.co/C1TVQvP

updade your adb files.

Google Usb driver on Android SDK?

@whoamikyo Is this the adb file updater or do I need anything else?
https://forum.xda-developers.com/showthread.php?t=2588979
Update:
Im now getting this
https://ibb.co/WsKY6JZ
However, nothing happens in-game.

@whoamikyo Is this the adb file updater or do I need anything else?
https://forum.xda-developers.com/showthread.php?t=2588979
Update:
Im now getting this
https://ibb.co/WsKY6JZ
However, nothing happens in-game.

what bluestacks version are you using?

@whoamikyo
Just going to make sure before i move to Bluestack
So in the Nox/Bin cmd, I do "nox_adb.exe connect <IP_ADDRESS>:62025"
and in the config file, i also put "<IP_ADDRESS>:62025"
Or am i typing this wrong?

i dont know nox adb port, but BS adb port is <IP_ADDRESS>:5555

but I think if the problem were it would give a connection error.

no need to type adb connect either, only put on config file.

Now on Bluestack.
Nothing happens after that line
https://ibb.co/p4KLh45

can you paste your config file?

download and set path adb step by step from xda.

https://www.xda-developers.com/install-adb-windows-macos-linux/

Make sure you disable and delete old adb files .
for Windows user set path for use adb

System > Advanced system settings > Tab Advanced > Enivronment Variables... > Path > Edit

by default port adb bluestack is 5555 and check for use adb in app

i don't recommend use Nox, it's stuck and very use ram and cpu.
result

Goodluck.

@Walofz
Still not doing anything

Found a device

Added all 4 directories into environment variables > path

@whoamikyo
Config File
[Network]
Service: <IP_ADDRESS>:5555
[Updates]
Enabled: True
Channel: Development
[Combat]
Enabled: True
Map: 3-4
OilLimit: 1000
RetireCycle: 2
RetreatAfter: 0
[Headquarters]
Dorm: True
Academy: True
SkillBookTier: 2
[Modules]
Commissions: True
Enhancement: True
Missions: True
Retirement: False
[Events]
Enabled: True
Event: Crosswave
Levels: EX,H,N,E

@whoamikyo
Config File
[Network]
Service: <IP_ADDRESS>:5555
[Updates]
Enabled: True
Channel: Development
[Combat]
Enabled: True
Map: 3-4
OilLimit: 1000
RetireCycle: 2
RetreatAfter: 0
[Headquarters]
Dorm: True
Academy: True
SkillBookTier: 2
[Modules]
Commissions: True
Enhancement: True
Missions: True
Retirement: False
[Events]
Enabled: True
Event: Crosswave
Levels: EX,H,N,E

Test with this cfg
[Network]
Service: <IP_ADDRESS>:5555
[Updates]
Enabled: True
Channel: Development
[Combat]
Enabled: true
Map: 3-4
OilLimit: 1500
RetireCycle: 2
RetreatAfter: 0
[Headquarters]
Dorm: True
Academy: False
SkillBookTier: 2
[Modules]
Commissions: True
Enhancement: False
Missions: False
Retirement: False
[Events]
Enabled: False
Event: Crosswave
Levels: EX,H,N,E

@whoamikyo
Still nothing changed from config  :(

still getting this?

@RubySapior Python version ?

@RubySapior Python version ?

I was also going to ask that.
on CMD type python --version

@whoamikyo @Walofz
Using Python 3.7.2

I had this happen to me once.
Go back to Nox.
Make sure you choose tablet and not phone in your resolution settings.
Then restart your emulator and click Restore window size after restarting. It should work.

@talktocat
Both my nox and bluestack were at Tablet and 1080p settings

I guess ill close this issue cause the "Resolution is not 1920x1080" has been solved.
Ill open another issue for the python script not working after connecting to device.


Kivy widgets are not displaying properly when run in High contrast theme in Windows 8.1

Issue:
Initial only a blank window gets displayed but when a user interaction like resize , click is made to the app it sometimes displays the widgets and update there after is uncertain as it still lags.
Additional Info
Works perfect when under other default themes of Windows 8.1 x64
OS: WIndows 8.1 x64 (no modding)
Kivy Version: 1.8.0 (both python 3.3 & 2.7)
Here is the console log --> http://pastebin.com/V02Z6DBT
A demo video showing behavior of kivy's touch tracer example when run in high contrast theme in windows --> https://www.youtube.com/watch?v=Y1kbgizixqA&feature=youtu.be

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/2782462-kivy-widgets-are-not-displaying-properly-when-run-in-high-contrast-theme-in-windows-8-1?utm_campaign=plugin&utm_content=tracker%2F42681&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F42681&utm_medium=issues&utm_source=github).

@ParokshaX could you check if this is still the case with kivy master?

Py2, master, win8.1 64bit (non-pro) with "High-contrast - White". Touches are registered, but window isn't refreshed until resized as it's visible in the video. Touchtracer won't even show the cross. However, there's no blank initial window, all is loaded and stops refreshing after that. E.g. KivyCatalog loads the text for rendering.


Add new cop Lint/UnexpectedBlockArity

Follows https://github.com/rubocop-hq/rubocop/pull/9071#issuecomment-730946877:

Maybe it should be a different cop that checks the block arity for methods that are known to have arity 2. There are less of them now that Hash#each is being changed to arity 1. Maybe just  Enumerable#each_with_object, min, max, minmax, slice_when, sort? Maybe we even have such a cop already?

This new cop checks for method blocks where the given block args don't match what the method is known to need. It is configurable using Methods, which is preloaded with all the Enumerable methods that take 2 args, as per the above comment.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Overall the cop looks great. My only suggestion would be to ignore method calls without receivers, as those are going to be more likely to be false positives.

@bbatsov makes sense! I've updated it.

Thanks!

Would it be possible to add a deny list using regexp ?
We have a lot of sort blocks in jbuilder templates which are json properties.
json.sort do
  json.order       @current_order
  json.direction @current_order_direction
end

@inkstak configuring the cop like this probably would solve this for you:
Lint/UnexpectedBlockArity:
  Exclude:
    - '**/*.jbuilder'

@dvandersluis Yes this is my current workaround, but it's too bad that this helpful cop doesn't cover regular Enum#sort methods present in our templates.

There isn't really a way for rubocop to know if sort is Enumerable#sort or another sort. Generally when cops exclude methods it's done across the board, not based on receiver (because in general we can't tell what the receiver is).

(until we plug into rbs...)

I actually suspect we can't tell what type is the receiver, but isn't it impossible to exclude cases using the name of the receiver or the whole line ? I humbly ask, the subtleties of rubocop parser are still beyonds me.
Lint/UnexpectedBlockArity:
  Allowlist:
    - 'json.sort'
    - /\Ajson\.sort do\Z/


Use sizeTxF instead of length $ serializedTx

[x] Remove dependency on Cardano.Wallet.Primitive.Types.Tx.{sealedTxFromCardanoBody, serialisedTx} by instead using Ledger.sizeAlonzoTxF

Comments
Issue Number
ADP-3081

thanks @jonathanknowles! Addressed.


Removing all forklifted content from project

The following pages have been added to wagtail and no longer need to be
hardcoded or added in with sheer. All relevant CSS and tests have also
been deleted in this PR. This will need a changelog fix.
Removals

Removed sheer templates and hardcoded pages that have been forklifted into wagtail

Testing

Run gulp test:acceptance --sauce=false
If you have the recent database dump, make sure the links sync up with the new content in wagtail

Review

@jimmynotjim
@sebworks
@anselmbradford

Checklist

[ ] Changes are limited to a single goal (no scope creep)
[ ] Code can be automatically merged (no conflicts)
[ ] Code follows the standards laid out in the front end playbook
[ ] Passes all existing automated tests
[ ] New functions include new tests
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged
[ ] Visually tested in supported browsers and devices
[ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

The second time in a week that I've been lucky enough to cry tears of joy.

This looks good, but I'm getting failures in the acceptance tests for all the footer links

:+1:

@jimmynotjim Just got the database up and fixed the footer tests. Didn't catch it the first time because they fail when a homepage isn't set. Thanks for the catch!

Looks good. I still get three failures for the Bureau Structure page, but @sebworks is already fixing those. :+1:

Looks like the following directories can also be removed:

cfgov/unprocessed/js/routes/budget/
cfgov/unprocessed/js/routes/the-bureau/
cfgov/unprocessed/js/routes/browse-filterable/

Also, does this remove all /offices/ and /sub-pages/ path pages? If so, cfgov/unprocessed/js/routes/offices/ and cfgov/unprocessed/js/routes/sub-pages/ can be removed too.
Otherwise, I get the 3 failures @jimmynotjim noted. :+1:

The Bureau and Browse Filterable pages are sticking around, so those should probably remain unless there's another reason they would be removed. And yep, I'm leaving the Bureau Structure page failures since it's being worked on outside this PR.
I'll look into the rest of the js and removing that. :scissors:

:+1:

Can I get one more :+1: and :eyes:  just for those most recent changes?

LGTM :+1:


merge package template from Kronos-Tools/npm-package-template

.travis.yml

chore(travis): merge from template .travis.yml

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #126   +/-   ##
=====================================
  Coverage      80%    80%
=====================================
  Files           1      1
  Lines          10     10
=====================================
  Hits            8      8
  Misses          2      2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 338d1a2...fa40608. Read the comment docs.


zlib version

hi:
i try to zlib 1.2.8 or zlib 1.2.11 in order to make, but it had a same question
so, please tell me what zlib version
Thanks!
tmlreporter.o ./obj/jsonreporter.o ./obj/main.o ./obj/nucleotidetree.o ./obj/options.o ./obj/overlapanalysis.o ./obj/peprocessor.o ./obj/polyx.o ./obj/processor.o ./obj/read.o ./obj/seprocessor.o ./obj/sequence.o ./obj/stats.o ./obj/threadconfig.o ./obj/umiprocessor.o ./obj/unittest.o ./obj/writer.o ./obj/writerthread.o -o fastp  -lz -lpthread -llber
./obj/fastqreader.o: In function FastqReader::getBytes(unsigned long&, unsigned long&)': /TJNAS01/CANCER/RD/TEST/chendongdong/fastp/fastp/src/fastqreader.cpp:70: undefined reference to gzoffset'
./obj/writer.o: In function Writer::init()': /TJNAS01/CANCER/RD/TEST/chendongdong/fastp/fastp/src/writer.cpp:43: undefined reference to gzbuffer'
collect2: error: ld returned 1 exit status
make: *** [fastp] Error 1

Your zlib version should be too old.

i know that zlib version can be too old, so i ask you what should use zlib version?
i will update it

Just update to the newest version


fix: change react-swipeable-views library for a better version (#100)

Closes #100
Issue #100 📐

I cesardlinx> have worked for #100

Guidelines 🔐
I accept the fact that I have followed the guidelines and have not copied the codes from around the internet

[x] Contribution Guidelines
[x] Code of Conduct

Issue to be closed 🛅

My pull request closes #100

Screenshots 📷

Alright, now push the changes

I'm sorry, I don't think I explained myself well. What I'm trying to say is that those changes are already pushed, but it won't work if you don't install this new package. In other words you will have to run npm install again

check if the import statement is alright

@warmachine028 ok I fixed the issue that I was having basically in the public profile, not sure if it was related with the crash that you're experiencing. About the import, yes for this library it has to be a default import instead of a named import as opposed to the previous package used. Check it out now, if it's not working on vercel try it out locally, let me know how it went

Running Locally But the Liked posts are not fetching

Please find some fix for the error online Uncaught TypeError: Failed to resolve module specifier "@babel/runtime/helpers/createSuper". Relative references must start with either "/", "./", or "../".
I strongly belive it has something to do with the new library or something with package-lock.json with @babel package
Also these warnings were generated while installing this new package

Got it, yeah I agree it has to be something related with the new package. I'm going to do this, I'll test this on a linux computer, basically I'll try to reproduce the same error that you're having. I'll let you know how it went

Yes, I want to encourage you in making this PR successful because it is a very critical and vital issue you are working on

@warmachine028 it works now! and with the previous library, give it a look


Windows defender flags ninja.exe

I just got this error today for v1.10.1 with a code of "Trojan:Win32/Emali.A!cl", marked sever. Windows Defender automatically deletes the file, requiring manual intervention to restore it. I see there was a previous issue like this in #1540

See https://groups.google.com/g/ninja-build/c/BcLa42ahfnU/m/DzB9LVliCAAJ

Symantec Endpoint Protection does not like the file either...

Please reopen if it still happens with 1.10.2.


feat: fox LP deposit/withdraw account selection

Description
This adds initial support for account selection in the FOX-ETH deposit/withdraw steps of the LP modal.
Note: Syncing won't work in the current state as this requires <AccountDropdown /> to be optionally controlled, which currently isn't the case.
Notice

[x] Have you followed the guidelines in our Contributing guide?
[x] Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes https://github.com/shapeshift/web/issues/2609

Risk
Reconciliation could be wrong and rug the FOX-ETH LP feature, test accordingly.
Testing

The multi-account selection dropdown should be displayed at deposit/withdraw steps of the FOX-ETH LP modal with the MultiAccount flag on
FOX-ETH LP and Farming cards/rows should still be displayed in the DeFi overview/earn sections both with the MultiAccount flag on and off (this implies FoxFarming and FoxLP flags on as Fox Farming and LP opportunities will never be displayed otherwise)
FOX-ETH LP and Farming modals should show no regressions both with the MultiAccount flag on and off (this implies FoxFarming and FoxLP flags on as Fox Farming and LP opportunities will never be displayed otherwise) - test the full flow of the modal, including deposit/withdraw

Engineering

Refer to the top-level steps
console.log/debug that setAccountId is called

Operations

Refer to the top-level steps
Note: You'll need both the FoxFarming and MultiAccount flags on to test this - FoxFarming can also be enabled to test for FOX Farming regressions

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #2642

PR #2644

PR #2651

PR #2652   👈

This comment was auto-generated by Graphite.

Moving to draft pending stack merge issues resolution

Current dependencies on/for this PR:

develop

PR #2642

PR #2644

PR #2651

PR #2652   👈
PR #2661

PR #2680
PR #2669

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

develop

PR #2642

PR #2644

PR #2651

PR #2652   👈
PR #2661

PR #2680
PR #2669

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

develop

PR #2642

PR #2644

PR #2651

PR #2652   👈
PR #2661

PR #2680
PR #2669

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

develop

PR #2642

PR #2644

PR #2651

PR #2652   👈
PR #2661

PR #2680
PR #2669

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

develop

PR #2642

PR #2644

PR #2651

PR #2652   👈
PR #2661

PR #2680
PR #2669

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

develop

PR #2642

PR #2644

PR #2651

PR #2652   👈
PR #2661

PR #2680
PR #2669

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

develop

PR #2642

PR #2644

PR #2651

PR #2652   👈
PR #2661

PR #2680
PR #2669

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

develop

PR #2642

PR #2644

PR #2651

PR #2652   👈
PR #2661

PR #2680
PR #2669

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

develop

PR #2642

PR #2644

PR #2651

PR #2652   👈
PR #2661

PR #2680
PR #2669

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

develop

PR #2642

PR #2644

PR #2651

PR #2652   👈
PR #2661

PR #2680
PR #2669

This comment was auto-generated by Graphite.

Current dependencies on/for this PR:

develop

PR #2642

PR #2644

PR #2651

PR #2652   👈
PR #2661

PR #2680
PR #2669

This comment was auto-generated by Graphite.


Payment error: Oauth error: [code=401], [message=invalid_client - Can't find oauthClient with clientId = xxxx] (0)

Hi, i would like to thank you in advance, i have installed the plugin in my wordpress page and activated it, created a sandbox account in PayU website, added a POS with REST API (Checkout) and then configured the plugin in wordpress with the keys and ids generated in sandbox account.
anyway i always get this error:
Payment error: Oauth error: [code=401], [message=invalid_client - Can't find oauthClient with clientId = xxxx] (0)
can you please help me with it?
Best regards

Hi!
The plugin is currently hardcoded with our production environment. Therefore, when you use sandbox credentials, you get this error.
You may either use a production PayU account and the test payment method (you can create it here: https://secure.payu.com/boarding/#/form?lang=en) or find the following line in your WooCommerce installation: https://github.com/PayU/plugin_woocommerce/blob/master/includes/class-woocommerce-payu.php#L54 and change it to OpenPayU_Configuration::setEnvironment('sandbox');


Code and readme improve

Example API codes improved
Code refactor for Ruby style

Thank you very much for your contribution 👍👍 @vilusa