Extension host terminated unexpectedly

Environment data
VS Code version:

Version 1.19.0-insider
Commit 8a12b294de610aab61c32c02c7c148d981cf07e4
Date 2017-12-04T05:14:19.063Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

Python Extension version:  Version 0.8.0 (9 November 2017)
Python Version:   Python 3.6.3 :: Anaconda, Inc.
OS and version:    Windows 10 Enterprise Edition
Actual behavior

Expected  behavior
Start MS Python extension
Steps to reproduce:

Install ms-python extension from Microsoft
Create new empty py file.
Wait for an amount of time after opening Python file. Error appears.

Logs
Output from Python output panel

Output from Console window (Help->Developer Tools menu)

/C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:2734 Extension host terminated unexpectedly.
e.doShow @ /C:/Program Files/Microsoft VS Code Insiders/resources/app/out/vs/workbench/workbench.main.js:2734

Please try reinstalling the extension. Also, do you have other installed on the current system?

Tried several times to reinstall the extension. Doesn't help.
I  have a lot of extensions installed, But I've disabled all and only ms-python is enabled.

Any solution Yet?

Unfortunately not because the error is "it crashed" which doesn't help debug why the extension crashed.

@OraCool are you able to help us diagnose this issue by debug this at your end?
I could send the instructions for this.

I can help if needed. Please let me know what should I do

@OraCool
One last thing, please could you try disabling all other extensions and testing this out.
Here are the instructions:

Prerequisites
Setup
Compile the code
Finally, launch the extension using the Launch Extension from the Debugger

If the extension does not load, you'll get errors in the debugger console, and that's what we're interested in. If it does work, then we could try something else.

I've passed all the steps from the instruction and got the following error:

Changing settings in the local workspace for "editor.detectIndentation" doesn't help.
Secon window is closing after I open *.py code or try to open "Python: Select Interpreter" in command palette:

In the extension's debugger window I am getting the following exception (if it will help):

Hey,  the truth is disable Python or React Native extension(if you have
it).  thats what only works for me.
Forget using python extension in VScode
On Dec 18, 2017 1:25 PM, "OraCool"<EMAIL_ADDRESS>wrote:
I've passed all the steps from the instruction and got the following error:
[image: image]
https://user-images.githubusercontent.com/127194/34105752-9da251b8-e406-11e7-9a70-a16d9826ec7e.png
Changing settings in the local workspace for "editor.detectIndentation"
doesn't help.
Secon window is closing after I open *.py code or try to open "Python:
Select Interpreter" in command palette:
[image: image]
https://user-images.githubusercontent.com/127194/34105890-20b453bc-e407-11e7-8741-91d2ca7a0367.png
In the extension's debugger window I am getting the following exception (if
it will help):
[image: image]
https://user-images.githubusercontent.com/127194/34106028-b1c7d702-e407-11e7-9026-aadff1157f77.png
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode-python/issues/342#issuecomment-352411797,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AVIoqCDfu8h11prug4YZr8CV3zQPaPMkks5tBlnRgaJpZM4Q0k7W
.

@Zedonboy I've disabled all extensions in the VS code. Only editor and TSLint are enabled.  The vscode-python extension is available in the second VS code window in the debug mode for the vscode-python

I dnt get what you mean by second window.  Bro just Uninstall Python
extension,  and get over with it.
Eclipse,  Visual Studio are already doing a great job in python

@OraCool

please could you continue with the error and check if there are other errors.
could you upload the the workspace folder
Does the extension crash if you open another project?

@DonJayamanne
I've disabled all extensions.
the result is the same:

I've tried with different workspaces - the result is the same (even with the empty folder - nothing to upload).

could you upload the the workspace folder - O: Nothing to upload - the folder is empty
Does the extension crash if you open another project? - O: Yes. Any project
What is the file d:\ssg\study\pt_test\manage.py? - O: Really don't know. It appears in the debugger - tries to find in my local working folder
Oh yes, please could you ensure you have disabled all other extensions. - O: disabled all

If it will help - I have several versions of Python installed:

Anaconda 5.0.1 with Python 3.6
Python 2,7
Python 3.7
Currently, I use python from Anaconda:

@DonJayamanne
Sorry for the delay.
Installed debug-10

Code settings:

echo %PATH%
exist only:
D:\Programs\Continuum\anaconda3\Scripts
D:\Programs\Continuum\anaconda3

@DonJayamanne
installed Python2:

echo %PATH%
D:\Programs\Python\Python27
D:\Programs\Python\Python27\Scripts
D:\Programs\Continuum\anaconda3\Scripts
D:\Programs\Continuum\anaconda3

@Yeba @OraCool

Once extension has crashed, please go into your VS Code extensions directory and locate the log.log file and upload it here.

Where to find this log.log file:

On windows c:/users/<user name>/.vscode/extensions/ms-python-2018.1.0-alpha
On Mac /Users/<user name>/.vscode/extensions/ms-python-2018.1.0-alpha
The log.log file is located in the python extensions directory.

@DonJayamanne
log.log

@DonJayamanne crashed while Start: getInterpreter() for python2
log.log

@OraCool @Yeba

Do any one of you have node.js installed on your system?
If you do, then please could you try the following:

Create a js file named one.js with the contents provided below
Run it in your terminal as follows node one.js
Let me know what you get

var cp = require('child_process');
process.on('uncaughtException', function (err) {
    console.error('uncaughtException');
    console.error(err.message);
    console.error(err.name);
    console.error(err.stack ? err.stack : 'No Stack');
});
var proc = cp.spawn('python2', ['-c', 'import sys;print(sys.executable)'], { env: process.env });
proc.stdout.on('data', function (data) {
    console.log('stdout');
    console.log(data.toString());
});
proc.stderr.on('data', function (data) {
    console.error('stderr');
    console.error(data.toString());
});
proc.on('error', function (err) {
    console.error('Handled error');
    console.error(err);
});

Looks like its falling over at the same location for the two of you (when trying to get the path to python2).
Based on @OraCool's feedback he doesn't have python2 in the current path.

@Yeba do you have python2 in your current path? Just open a terminal and type in the command python2 --version
I'm sorry about this issue guys. Still soldiering on, thanks for your patience.

@DonJayamanne
I am thankful that you have payed so much attention to my issue. One day, a friend of mine suggested me to try to use Anaconda, and after which, the plugin works successfully!
Thank you again for your help!

@OraCool let me know when you have something.

@DonJayamanne
code execution result:
Handled error
{ Error: spawn python2 ENOENT
at _errnoException (util.js:1003:13)
at Process.ChildProcess._handle.onexit (internal/child_process.js:201:19)
at onErrorNT (internal/child_process.js:389:16)
at process._tickCallback (internal/process/next_tick.js:152:19)
at Function.Module.runMain (module.js:703:11)
at startup (bootstrap_node.js:190:16)
at bootstrap_node.js:662:3
errno: 'ENOENT',
code: 'ENOENT',
syscall: 'spawn python2',
path: 'python2',
spawnargs: [ '-c', 'import sys;print(sys.executable)' ] }
I don't have in the PATH python2:

but Python 2.7.14 is installed:

I've created a copy of python.exe file in Python27 folder and renamed it to python2.exe
The result from extension:

So, now it can't find python3.
I've made the same for python 3 in anaconda (copied and renamed to python3.exe) and finaly it looks like extension started working.
Please find log attached.
python_ext_Log.txt
Thank you for your patience.
Any recommendations about python's files? It is really strange that after official installation it will be required to add a copy of the file.

@OraCool

You shouldn't have to copy and create those python2 and python3 executables

What's interesting is its failing for some unknown reason and trying to get the logs out of VS Code is difficult. It doesn't seem to log anything.

I've built yet another copy of the extension with some more logging to identify why its falling over.
Please delete the python2.exe you created when testing

Please use this file to perform the testing
python-2018.1.0-alpha.zip

Once downloaded, please rename the file extension from .zip to .vsix

Note: As you've identified, the extension works when the two files exist:
* My suggestion is to keep those two so you can use the extension
* Please use the latest extension from the marketplace
* The build I'm providing is pretty outdated and contains a lot of logging, something you don't need.

@DonJayamanne
I've removed files and installed the extension you have provided. Unfortunately, it doesn't log anything into output anymore as it was in previous versions.
Extention stops after the step 4:

@DonJayamanne
It fails at:

in child_process.js
It looks like the code doesn't handle exceptions (hope it should)
In the terminal, I have the following

You should have a log.log file in the python extensions directory.
Use the command 'Extensions Open Extension Directory'
Or

On windows c:/users//.vscode/extensions/python-2018.1.0-alpha-debug-10
On Mac /Users//.vscode/extensions/ms-python-2018.1.0-alpha-debug-10
The log.log file is located in the python extensions directory.

@DonJayamanne
Not a lot of information in it.
log.log
Maybe I can debug something?

@DonJayamanne
I've cloned repo and made some changes in the code to debug. Maybe these debug steps will help:

Next step crash the extention:

@OraCool
Apologies for the delay.
As you're debugging the exception please could you try the following:

Comment out the following two lines:
line: 28 const python = this.getInterpreter('python', '').then....
line: 23 const python = this.getInterpreter('python3', '').then....
Basically I want you to focus only on debugging the call to python2
Next when you step into proc.ts and when you're on line 88
Check the value for file and confirm the value of file is python2
Once you're there add a breakpoint inside the proc.once('error' method (around line 131), see below:

proc.once('error', ex => {
            deferred.reject(ex);
            disposables.forEach(disposable => disposable.dispose());
        });

Start debugging and check whether it hits the above breakpoint inside the error handler

Btw, If possible is it possible to have a skype conversation or similar. I think that would be much quicker. Please send me an email with the relevant information if possible (that would be much quicker).

@DonJayamanne
https://www.screencast.com/t/lYY0wuMu
in line 131 of proc.js it doesn't stop
it works fine if I change the command to:
private async getInterpreter(pythonPath: string, defaultValue: string) {      try {             const output = await this.processService.exec('cmd.exe', ['/c', pythonPath, '-c', 'import sys;print(sys.executable)'], {});             if (output) {                 const value = output.stdout.trim();                 return value.length === 0 ? defaultValue : value // Ignore exceptions in getting the executable.             } else {                 return defaultValue             }         } catch (error) {             return defaultValue;         }     }
the result in debugger:

for  this.getInterpreter('python2', '').then(interpreter => [interpreter]): https://www.screencast.com/t/ABsfF4hh1

for  this.getInterpreter(PythonSettings.getInstance(resource).pythonPath, '').then(interpreter => [interpreter]): https://www.screencast.com/t/3STct0fwL

for this.getInterpreter('python', '').then(interpreter => [interpreter]);:https://www.screencast.com/t/cYnAM3PIW

I think the problem with the direct call of python2 - the system can't create the process because of such command/program doesn't exist
Deffenetly - it is only for windows
@DonJayamanne BTW - I've sent the email with my skype name to you

@OraCool Please could you try this once again
(FYI - I replied to your email last week)

Uninstall your python extension
Completely quit and restart VS Code
Download and install the python extension from here
Install from the above file using the command palette Extensions: Install from VSIX
Restart VS Code
You might get some messages, please keep track of the last message displayed
Once VS Code crashes, open it once again (this time do not open a python file)
Next go into the command palette and select Extensions: Open Extensions Folder
Go into the folder for Python extension (e.g. ms-vscode.python-2018.3.0-alpha
A file named log.log would be in there

Please upload the log.log file here

@DonJayamanne
Log is uploaded
log.log

log.log
Log uploaded. Note after installing the Extension as instructed, no crash.

Same issue here is there any fix for this?

I also have the same issue. Tried installing the 'python-2018.3.0-alpha-debug'  but it still crashes.

@arjunkharbanda @mattew please try uninstalling and re-installing the extension (this may require closing VS Code and deleting the extension's directory); had a rash of issues from VS Code botching extension upgrades.

i am having this problem for days...no solutions

Just for information. I am suffering from this issue for a long time, and finally got resolved after I switched my python environment to Python2.7 with miniconda. I can still use Python3 with a conda environment, but the base python version of 2.7 of conda brings vscode python extension back to work.

@pzhg the version included with Anaconda is the same one on the Marketplace so there's nothing special in that regard (only that it also installs the Red Hat YAML extension).
@OraCool @arjunkharbanda @mattew @Ayanjit We're obviously sorry that we can't figure this out, but we're stumped at the moment since we can't reproduce it on our end to help diagnose the problem. Anyone have any idea what is common among all of you? I'm assuming everyone is running the latest version of VS Code and the extension. Could everyone post their environment details as shown at https://github.com/Microsoft/vscode-python/blob/master/.github/ISSUE_TEMPLATE.md to see if there's some environment issue that triggers this? Or anything that might be special about your setup compared to what we may have on our own machines that we don't ask for (e.g. are people using a specific locale on their OSs that's non-English)?

Environment data

VS Code version: 1.22.2
Extension version (available under the Extensions sidebar): 2018.3.1
OS and version: Windows 10 Enterprise. Version = 1703. Build = 15063.1029
Python version (& distribution if applicable, e.g. Anaconda): Python 3.6.5 (v3.6.5:f59c0932b4, Mar 28 2018, 17:00:18) [MSC v.1900 64 bit (AMD64)] on win32. (no distribution)
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): no environment
Relevant/affected Python packages and their versions: no

Actual behavior

Opening any .py file in vscode is giving this popup : "Extension host terminated unexpectedly".
Intellisense not working (maybe because of the Extension failure).

Expected behavior

No popup like above. Intellisense should be working.

Steps to reproduce:

1.Install python 3.6.5.
2.Install latest VS Code
3.Install Python Extension by Microsoft.
4.Reload VS Code
5.Open an old .py file or create a new .py file.(files can be blank)
6.Find the popup at lower right screen

Logs

(Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python))->
There is no "Python" option in the output dropdown. The options are - Tasks, Extensions, Git, Log(Main), Log(Shared), Log(Window), Log(Extension Host).
(Output from Console under the Developer Tools panel (toggle Developer Tools on under Help))->
console.ts:136 [Extension Host] rejected promise not handled within 1 second
t.log @ console.ts:136
extensionService.ts:377 Extension host terminated unexpectedly. Code:<PHONE_NUMBER>  Signal:  null
w._onExtensionHostCrashed @ extensionService.ts:377
notificationsAlerts.ts:39 Extension host terminated unexpectedly.
e.onDidNotificationChange @ notificationsAlerts.ts:39
I want to add that for the C/C++ extension by Microsoft intellisense etc is working ok but I am getting curly lines under #include directives . It is working ok though. I saw that the path of the files are right. Doing some search in google I found that it is due to the Windows 10 SDKs in my machines. They are not ok I guess.

Same problem here. I have tried reinstalling the extension and vscode, but still no luck. Even when I use the special alpha version for debug, it produces no log so there's nothing to show.
Environment data
VS Code version: 1.22.2
Extension version (available under the Extensions sidebar): 2018.3.1
OS and version: Microsoft Windows [Version 10.0.16299.371]
Python version (& distribution if applicable, e.g. Anaconda): Python 3.6.5 (v3.6.5:f59c0932b4, Mar 28 2018, 17:00:18) [MSC v.1900 64 bit (AMD64)]
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): no environment
Relevant/affected Python packages and their versions: no packages
One of the very interesting facts is that extension works fine on another computer with almost the same configuration.
Environment data
VS Code version: 1.22.2
Extension version (available under the Extensions sidebar): 2018.3.1
OS and version: Microsoft Windows [Version 10.0.14393]
Python version (& distribution if applicable, e.g. Anaconda): 3.6.4 (v3.6.4:d48eceb, Dec 19 2017, 06:04:45) [MSC v.1900 32 bit (Intel)]
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): no environment
Relevant/affected Python packages and their versions: no packages

Is anyone of you close to the PST (Pacific Standard Time) zone.
I'd like to get onto Skype or something similar and get to the bottom of this.

@brettcannon In fact I mention anaconda just because that's my Python distribution. I basically want to say that I guess the issue is related to the Python version, and specifically, the Python version of the base environment, not the Python version of an individual project.
The issue exists on my computer when I am using miniconda3, which uses Python3.6 for its base environment. After I switched to miniconda2 with Python 2.7 as the base environment, everything goes fine. I am still using Python 3 inside the projects, via conda environments.
BTW, my environment data (when the issue occurs) is:
VS Code version: 1.22.2
Extension version (available under the Extensions sidebar): 2018.3.1
OS and version: Windows 10 Pro. Version = 1803. Build = 17133.73
Python version (& distribution if applicable, e.g. Anaconda): Miniconda 3 with Python 3.6 as base environment. In specific projects, I am using various versions of Pythons.

@Yeba I also tried Anaconda. I updated the path in user setting (python.pythonpath) of VS Code too.. But I am still getting same error

Working fine on my old laptop but giving this error on the new one idk why please fix this issue ASAP

@arjunkharbanda as soon as we or someone else can find out why this occurs for some users and not others we will fix it immediately. But until then we don't even know what to fix.

I wonder, have people tried running with all other extensions disabled? Total guess but maybe we're not interacting well with some other extension people have installed?

@brettcannon  It's the only extension I have installed so there is that

@brettcannon Not only I disabled other extensions, I also uninstalled them. Only Python is left, but I still get the same error.

@brettcannon Yes, when I disable python extensions, there is no hint of an extended host crash.

@arjunkharbanda @starry-zhao @artikrh @Ayanjit @pzhg @rkdl @mattew
Is anyone of you close to the PST (Pacific Standard Time) zone.
I'd like to get onto Skype or something similar and get to the bottom of this.

@DonJayamanne I'm free right now,But I don't have a skype account.
I can record video to you, or you can use teamview software, remote control my computer to see, but I am in China, can we connect?
my english is poor

It happened when I updated the latest VSCode (Everything was fine before). Then I tried to reinstall the old version of VSCode and the extension by  rebooting/unistall, etc... The error came all the time. I deleted all other extensions as well. My OS is Windows. I guess the reason is the updated extension code?

@DonJayamanne
OS: windows 10 pro64-bit build 16299
VS Code version: 1.19.3 (just go back to old version, but already tried many new version)
extension version: latest
anaconda: yes 3.5

@DonJayamanne  I guess it only happens in Windows because I am using VSCode 1.22.2 in Ubuntu 14.02 and it works fine. My skype is xjsxujingsong if you need further information.

Is anyone not using Anaconda that's seeing this problem?

And can someone who is seeing this problem tell us what version of Anaconda and the version of conda itself that you are using?

@brettcannon
in Windows,

type "conda -V"
shows "conda 4.3.34".

type"conda info", shows:
Current conda install:
       platform : win-64
  conda version : 4.3.34

conda is private : False
conda-env version : 4.3.34
conda-build version : 2.0.2
python version : 3.5.4.final.0
requests version : 2.13.0

type "conda list anaconda$", shows
anaconda                  custom           py35h64770cb_0

Go to "C:\Users\mypc\Anaconda3\conda-meta", and find the file "anaconda-custom-py35h64770cb_0.json". The info in the file is:
{
"arch": "x86_64",
"auth": null,
"build": "py35h64770cb_0",
"build_number": 0,
"channel": "https://repo.continuum.io/pkgs/main/win-64",
"depends": [
"python >=3.5,<3.6.0a0"
],
"files": [
"Lib/version.txt"
],
"fn": "anaconda-custom-py35h64770cb_0.tar.bz2",
"license": "BSD",
"link": {
"source": "C:\Users\mypc\Anaconda3\pkgs\anaconda-custom-py35h64770cb_0",
"type": 1
},
"md5": "9298f22dfa2326e27243a4e713cf8bfd",
"name": "anaconda",
"noarch": null,
"platform": "win32",
"preferred_env": null,
"priority": 2,
"schannel": "defaults",
"size": 9026,
"subdir": "win-64",
"timestamp":<PHONE_NUMBER>285,
"url": "https://repo.continuum.io/pkgs/main/win-64/anaconda-custom-py35h64770cb_0.tar.bz2",
"version": "custom",
"with_features_depends": {}
}

Is there anyone else who is solving this problem?It's been a long time.

@xjsxujingsong is this Anaconda 5.1, 5.0, ... ? I want to see if we can replicate as closely as possible on our end by installing the appropriate Anaconda version from https://repo.continuum.io/archive/ .
@starry-zhao as you can tell from our comments we are trying to solve it, but if we can't replicate the issue on our end then we can't fix it and we haven't figured out the magic combination of things to make things consistently fail yet. Hopefully someone will eventually provide us with the right info so we can finally replicate it to find out what is causing the problem.

@brettcannon See my comment before. For the anaconda version, I forgot that. Is there any way to find it? In my machine, it is "C:\Users\mypc\Anaconda3\conda-meta\anaconda-custom-py35h64770cb_0.json".  My skype is xjsxujingsong if you need further information.

@brettcannon I just reinstall the latest Anaconda from the official website of Anaconda: https://www.anaconda.com/download/     and download Python 3.6 version * windows X64.
I also delete the folder of vscode-python and reintall it. Similar things happen. The only difference is this this the prompt is located in the right conner "Extension host terminated unexpectedly."
I can run my python code but cannot debug.

Hi all, here's what solved mine.

Uninstall python binaries in your machine(NOT vs-code python extension)
then download Anaconda(GUI)
check (ADD to install path)
Click Install.

It might ask for installing VSCode, (If you have skip, else install)
Start VsCode opening a python file(with vs-code-python enabled)
Here comes the Magic of the greatest showman(The Error healed)

I experienced the same issue on Windows 10.
For me, the problem seems to have to do with my Path variables. Using a semicolon in one of those crashes the extension host. When I remove the Path variable with the semicolon, everything seems to work fine again.

我也解决了，解决方法是：
删除了path变量中自己添加JAVA环境变量时不小心多写的；符号。删除后就解决了问题。
感谢@mawenzy

@mawenzy  Awesome!!! Thanks a lot for your solution. It worked for me. Now, I can sleep in peace.
In my case mingw path had semicolon in the path variables. How did you find this solution?

@mawenzy @Ayanjit can either of you provide your PATH settings before and after? Semi-colons are the path separator on Windows so that shouldn't cause a problem (but we have had issues with PATH and node previously). But if we can have an example of where it does and does not work we can also track down where we need to be careful about this sort of thing.

@mawenzy Ah, so you had a directory like C:\I\like\semi;olons and it ended up as PATH=path;"C:\I\like\semi;colons";path3? And then making it PATH=path1;path3` solved it?

@DonJayamanne Just checked that. It works fine now. I accidentally add an additional ";" in the path variable. Thanks!!

@mawenzy Thanks, it solves my issue!
for my case, when I type "path" in cmd, results contain path with "", like PATH=path1;"path2";path3...
I find one cases may cause this issue, that is using alias path, such as %CUDA_PATH%;%CUDA_SDK_PATH%. After I replaced alias path with full path, issue disappeared.

C:\Users\Arjun Kharbanda>path
PATH=C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\nodejs\;C:\Program Files\Intel\WiFi\bin\;C:\Program Files\Common Files\Intel\WirelessCommon\;C:\Program Files\Git\cmd;C:\Program Files\Git\mingw64\bin;C:\Program Files\Git\usr\bin;C:\WINDOWS\System32\OpenSSH\;C:\Users\Arjun Kharbanda\AppData\
about:blankLocal\Programs\Python\Python36\Scripts\;C:\Users\Arjun Kharbanda\AppData\Local\Programs\Python\Python36\;C:\Users\Arjun Kharbanda\AppData\Local\Programs\Python\Python36\Scripts;C:\Users\Arjun Kharbanda\AppData\Local\Programs\Python\Python36;C:\Users\Arjun Kharbanda\AppData\Local\Microsoft\WindowsApps;C:\Users\Arjun Kharbanda\AppData\Roaming\npm;C:\Program Files\Intel\WiFi\bin\;C:\Program Files\Common Files\Intel\WirelessCommon\;C:\Users\Arjun Kharbanda\AppData\Local\GitHubDesktop\bin;"C:\Users\Arjun Kharbanda\AppData\Local\Programs\Python\Python36\Scripts\;";"C:\Users\Arjun Kharbanda\AppData\Local\Programs\Python\Python36;C:\Users\Arjun Kharbanda\AppData\Local\atom\bin;;C:\Users\Arjun Kharbanda\AppData\Local\hyper\app-2.0.0\resources\bin;C:\Program Files\Microsoft VS Code\bin;C:\Users\Arjun Kharbanda\AppData\Local\Microsoft\WindowsApps
``` how fix this?

@arjunkharbanda

Please remove invalid entries.

Looks like you have about:blank in there. Please edit your environment variables to remove invalid items such as the one above and any empty lines.
You might have some empty items as well, as there are two ;; (replace with ;).
You seem to have paths with " that do not seem to have matching closing "
Once again, remove invalid items, by editing you PATH environment variable.

@DonJayamanne
see this

looks like the issue is resolved it's is due to issues in PATH in environment variables. Can it be fixed in future updates?

Closing, we will track issue #1698 that will resolve this issue from our end.


Dont mention the specific snapshot version in the doc

Dont mention the specific snapshot version in the doc [1]
[1] https://docs.wso2.com/display/ADMIN44x/Removing+References+to+Deleted+User+Identities+in+WSO2+Products#RemovingReferencestoDeletedUserIdentitiesinWSO2Products-MasterConfig
In docs it is mentioned as,
org.wso2.carbon.privacy.forgetme.tool-1.0.0-SNAPSHOT.zip
org.wso2.carbon.privacy.forgetme.tool-1.0.0-SNAPSHOT
Better to mention as,
org.wso2.carbon.privacy.forgetme.tool--SNAPSHOT.zip since it keeps on changing.
org.wso2.carbon.privacy.forgetme.tool--SNAPSHOT

Removed the version from the doc as suggested since it keeps changing.


fix: Internal error when the utf8_bom fixup is used for WSGI apps

Codecov Report

Merging #1660 (7280b0c) into master (570402e) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1660      +/-   ##
==========================================
- Coverage   98.96%   98.78%   -0.19%
==========================================
  Files          95       95
  Lines        7663     7662       -1
  Branches     1581     1318     -263
==========================================
- Hits         7584     7569      -15
- Misses         48       56       +8
- Partials       31       37       +6

Impacted Files
Coverage Δ

...rc/schemathesis/specs/openapi/stateful/__init__.py
100.00% <ø> (ø)

src/schemathesis/fixups/utf8_bom.py
100.00% <100.00%> (ø)

src/schemathesis/_compat.py
67.50% <0.00%> (-10.00%)
:arrow_down:

src/schemathesis/extra/pytest_plugin.py
97.14% <0.00%> (-2.86%)
:arrow_down:

src/schemathesis/cli/callbacks.py
98.84% <0.00%> (-1.16%)
:arrow_down:

src/schemathesis/utils.py
96.93% <0.00%> (-0.77%)
:arrow_down:

src/schemathesis/runner/impl/core.py
96.51% <0.00%> (-0.47%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Added mdl-chip component

Reopening PR #4286 with suggestions implemented and docs added.
To re-summarize:
Added mdl-chip component as referenced in the MD specs and issue #857.
I only added the chips, not the opened list element. This is considerably more complex and needs some js to fuel interactions. Documentation and examples have been added. The only thing needed to make this complete is an icon for the left side bar.

The build is reporting as failing, but it looks like the build is failing on fetching the npm packages (not on my additions)... I'll wait until this is resolved and run the build checks again.

LGTM sans actual MD Spec alignment. I'll try to review that within the next day or two.
Fantastic work so far!

cc @crhym3 Looks like phantomjs isn't downloading again, 403 on this build too.

Can you restart to see if it was intermittent again? Looks like I don't have restart privileges on Drone.
Should I open an issue to look into an alt way to download phantomjs reliably?

you should already have access, just need to login at
https://ci.cloudware.io
wouldn't it make more sense for phantomjs package owners to solve the
issue?
On 29 May 2016 12:16 p.m., "Jonathan Garbee"<EMAIL_ADDRESS>wrote:

cc @crhym3 https://github.com/crhym3 Looks like phantomjs isn't
downloading again, 403 on this build too.

Can you restart to see if it was intermittent again? Looks like I don't
have restart privileges on Drone.
Should I open an issue to look into an alt way to download phantomjs
reliably?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/google/material-design-lite/pull/4386#issuecomment-222355286,
or mute the thread
https://github.com/notifications/unsubscribe/AABjPc9uLe29PKxAxLF02Grm5W1PiZveks5qGXWEgaJpZM4IpNSJ
.

Ah, clicking on "Details" doesn't take me through the login process so I ended up in an anonymous viewer state.
I'm trying to see if I can build a replication case before filing an issue upstream (so far not happening.) Since it is a 403 error it seems intermittent to BItBucket causing the problem. Didn't know if we could hack up a quick cache to pull from instead of relying on BitBucket to serve properly.

@Garbee Updated code as requested. Let me know if you'd like any other changes.

MD alignment comments inline.
My other concern is not having active/hover states for the delete buttons. However, that is a failing of the specification.
Once the inline comments are addressed and the commits squashed this will have a green light from me.

Whoops, changed email address didn't have the CLA signed. Signed it.

@Garbee I don't mind changing to rems in general, but I think that we should hold off since the rest of the project isn't using them and it wouldn't fit in at all. Thoughts?

Ah yea, let's hold off on changing to rem just yet. We'll do that when porting up to 2.x that way we don't forget to redo the math. Good call there.

Fantastic work, @b-kelly, thank you! LGTM after testing, and I think we're ready to merge.

Also, I noticed that there's a build error, but that's likely because of the current state of the 1.2 branch. I'll update it after merging and fix any bugs.

Yea, we need to merge 1.1 up to 1.2 to fix that build error.
2 LGTM's so merging away.

Awesome! Thanks for the merge guys. I have a few other components I've written up, so I'll clean them up and add PRs / issues when I'm ready to show.

Please file issues first for components you want to send in. That way we can discuss the details before having a code review thrust upon us. That way no effort is wasted and things are more organized.

Hey, sorry I feel like this should be obvious but where is this code? Github says it was merged into google:mdl-1.2 but that's not a link and I can't find it anywhere. I'd love to use these chips in my current project.

mdl-1.x is the new 1.x series branch. It is in there. I keep poking to get 1.2 tagged and released but...  they can be time-consuming release the way we did 1.x. :frowning:

Ah, OK thanks for the quick response. I'll try pulling in the mdl-1.x branch :)

And now 1.2 is out! Sorry for all the slowness, my bad 🐌

Just noticed that :+1:


PLEASE USE Darwin

PLEASE USE Darwin

No offense, but there are other Systems that the code can work on too


i18n error only when adding theme extension block to theme for first time

I'm developing a theme extension that uses en.default.schema.json to also translate the configurable properties of the block. The idea is that I will offer this app in multiple markets, not just en.
See this snippet from my app's en.default.schema.json:
{
  "common": {
    "settings": {
      "font_size_label": "Font Size",
      "color_label": "Color",
      "font_size": {
        "normal": "Normal",
        "small": "Small",
        "extra_small": "Extra Small"
      },
      "margin_top": "Top margin adjustment"
    }
  }
}

When you go to add the block to your theme, you see that everything else is translated properly except the radios:

However, if you save your theme, then reload, you'll see that the font size options are now i18n'd properly:

Here's a gif of the process of me adding, seeing bug, saving theme, reloading, and seeing bug resolve:

I thought I was going insane but I believe this is just a Shopify bug. I tried different nestings of keys, namings, etc, radio options just seem to be bugged.
You should be able to replicate this with this shop & theme (feel free to play with it, this is an older demo store that I'm not using actively) https://admin.shopify.com/store/qunit-price-demo-store/themes/143642493204/editor?previewPath=%2Fproducts%2Fblueberry-shampoo&block=template--17897272017172__main%2Ffd29d93c-4ad0-4c9f-8b35-5395c6e8a214&section=template--17897272017172__main
by adding and removing the Unit Price or the Unit block.
I fear that my app will be rejected in review because of this.

This is how I was using it in my app block .liquid:
{% schema %}
  {
    "name": "t:unit_price_element.meta.title",
    "target": "section",
    "stylesheet": "unitprice.css",
    "javascript": "unitprice.js",
    "settings": [
      {
        "label": "t:common.settings.color_label",
        "id": "color",
        "type": "color",
        "default": "#555"
      },
      {
        "label": "t:unit_price_element.settings.savings_color_label",
        "id": "savingsColor",
        "type": "color",
        "default": "#00ac00"
      },
      {
        "label": "t:common.settings.font_size_label",
        "id": "fontSize",
        "type": "radio",
        "options": [
          {
            "value": "1em",
            "label": "t:common.settings.font_size.normal"
          }, {
            "value": "0.9em",
            "label": "t:common.settings.font_size.small"
          }, {
            "value": "0.7em",
            "label": "t:common.settings.font_size.extra_small"
          }
        ],
        "default": "0.9em"
      },
    ],
  ...
  }
{% endschema %}

In case it helps with repro. I have to update my app to remove the translation so I can pass app store review


Run sanity checks on PR base branch change

The pull_request edited event type is the only one that detects a change in the base branch, so we're adding it to the list of event types to prevent the following scenarios:

When updating the base branch, no sanity-checks are run.
Successful sanity-checks runs on the previous branch that are kept when base branch is updated: misleading (we don't know if they would have failed against the new base branch).

NOTE: the side effect is when editing the title or PR description, sanity-checks will be re-triggered. Although not ideal, it's better than adding a condition on the job to not run it on title/description changes, as the job is marked as skipped: misleading (we don't know if the previous run was successful or not).

/retest

/approve

cc: @SanjalKatiyar and @bipuladh to tag

/lgtm

cc: @SanjalKatiyar and @bipuladh to tag

@SanjalKatiyar @bipuladh ping.

/cherrypick release-4.18 release-4.18-compatibility

/cherry-pick release-4.17

/cherry-pick release-4.16

/cherry-pick release-4.15

/cherry-pick release-4.15-compatibility

/cherry-pick release-4.14

/cherry-pick release-4.14-compatibility

/cherry-pick release-4.18-compatibility


Graph.hh doesn't expose non-const reference to Edges

Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Checked the Q&A board for common solutions: http://answers.gazebosim.org
Checked that your issue isn't already filed.
Checked that there is not already an Ignition package that provides the described functionality: https://ignitionrobotics.org/libs

Description
The Graph::VertexFromId function has two versions that return a const and non-const reference to a Vertex. However there is only a const version of the Graph::EdgeFromId function, which makes it hard to modify Edge Data().
Likewise, the Graph::AdjacentsTo and Graph::AdjacentsFrom functions return non-const references to the graph vertices, while the Graph::IncidentsTo and Graph::IncidentsFrom functions only return const references to the graph edges.
Steps to Reproduce

Apply the following patch to GraphUndirected_TEST.cc:

diff -r 5daad73583053b529a744f9939d5e5150f02c1f0 src/graph/GraphUndirected_TEST.cc
--- a/src/graph/GraphUndirected_TEST.cc	Tue Feb 12 20:49:41 2019 +0000
+++ b/src/graph/GraphUndirected_TEST.cc	Fri Feb 15 17:44:21 2019 -0800
@@ -365,9 +365,10 @@
   // Change some content and verity it.
   e2.Data() = 5.0;
   e2.SetWeight(6.0);
-  auto edge = graph.EdgeFromId(e2.Id());
+  auto &edge = graph.EdgeFromId(e2.Id());
   EXPECT_DOUBLE_EQ(5.0, edge.Data());
   EXPECT_DOUBLE_EQ(6.0, edge.Weight());
+  edge.Data() = 7.0;

   // Check that the edges point to the right vertices.
   EXPECT_EQ(0u, e0.Vertices().first);

Try to build and it will fail to compile.

Expected behavior:
Compile successfully.
Actual behavior:
Fails to compile.
Reproduces how often:
always
Versions
5.0.0 and 6.0.0, Ubuntu
Additional Information

Even Graph::AdjacentsTo and Graph::AdjacentsFrom functions return const reference to the vertex, just the map is mutable. The map itself contain const reference only.
As,
  template<typename V>
  using VertexRef_M =
    std::map<VertexId, std::reference_wrapper<const Vertex<V>>>;
}

What is the expected behavior?


[Feature][Doc] Add icon for connectors

Search before asking

[X] I had searched in the feature and found no similar feature requirement.

Description
Add custom icons for our all connectors.

https://seatunnel.apache.org/docs/connector-v2/source
Please refer https://github.com/facebook/docusaurus/discussions/10476#discussioncomment-10545432
Usage Scenario
No response
Related issues
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

try this
https://gofile.io/d/yMHabA
select the desired compiler in the installer

Can be assigned to me

@Hisoka-X
The implementation method and effect are as follows. If there is no problem, I will start to modify it.
It will support the following three configurations: SVG, PNG, and Link.
e.g.
svg

png

link

effect

@Hisoka-X The implementation method and effect are as follows. If there is no problem, I will start to modify it. It will support the following three configurations: SVG, PNG, and Link. e.g. svg  png  link
effect

Looking great! Thanks @zhangshenghang for the demo.


Unable to update extension with new version

Describe the bug
It's no longer possible to upload a new version of a VS Code extension via the Web UI
To Reproduce

Upload a new extension
Update the version of the extension and rebuild
Upload new version of extension
This error is shown:

Expected behavior
New version uploaded
Screenshots

Desktop (please complete the following information):

OS: MacOS
Browser: Chrome

Additional context
Workaround is to delete current extension entirely.
Split from here:
https://github.com/microsoft/vsmarketplace/issues/354#issuecomment-1173762802

Hi @thegecko, usually this extension id check is during the creation of new VS Code extension to ensure the extension id used is unique. We could not reproduce this issue. Could you please confirm that you are using update option and not the New extension?

Well this is embarrassing, you are absolutely right.
I knew this ability was there, but just couldn't see the ellipses menu because the extension name also has ellipses and they blend together:

I'll get my coat...


When using VLAN with vCenter the vlan id is not shown on Sunstone

Description
When using VLAN with vCenter the vlan id is not shown on Sunstone. This happens because the vlan id for vCenter is stored in VCENTER_VLAN_ID tag instead of VLAN_ID
Details

Affected Component: Sunstone

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

@tinova,  PRs to approve:
-ONE: https://github.com/OpenNebula/one/pull/3711
-Docs: https://github.com/OpenNebula/docs/pull/763


Update tag/value parser for SPDX spec version 2.3

[x] *Update versions in test files
[x] *Additional hash algorithms [SHA3-256][SHA3-256], [SHA3-384][SHA3-384], [SHA3-512][SHA3-512], [BLAKE2b-256][BLAKE2b-256], [BLAKE2b-384][BLAKE2b-384], [BLAKE2b-512][BLAKE2b-512], [BLAKE3][BLAKE3], [ADLER32][ADLER32]
[x] *Test missing license concluded, license declared, and copyright
[x] *Add Package Purpose as described in section 7.24
[x] *Add Release Date as described in section 7.25
[x] *Add Built Date as described in section 7.26
[x] *Add Valid Until date as described in section 7.27
[x] *Add relationship REQUIREMENT_DESCRIPTION_FOR
[x] *Add relationship SPECIFICATION_FOR

Also - fixes #23

Note that this will not pass the CI until the dependent SPDX Java Library version 1.1.0 is available from Maven central.


Config to remove QA modifications in chat

What does your feature do?
It will hide strings such as "Has forced you to finish your quest" from being shown in chat.
How would people use it?
Right now what can be done is making the string empty but the chat still pops up an empty line.  The reason why I'd want to hide them is because utilizing scripts with Denizen to assign skip, give and remove quests from users to get a bit more customization how they're done. The current hack of having an empty line isn't a big deal but it may appear weird at times.

Thanks for your suggestion. First I'd like to encourage you to keep an eye on https://github.com/DenizenScript/Depenizen/pull/305 which, if accepted, will let you use the next release of Depenizen to give, quit or advance a quest for a player. The quit command specifically has a true/false flag for whether to notify the player, but iirc none of them should send any messages.
Regardless, feel free to list the other strings I should look at in the interim.

Oh thanks for the great Denizen contribution, this is a big step towards very advanced quests with interesting mechanics.
Side note suggestion for the Denizen, could you potentially add an attribute for custom objectives even if the quests plugin doesn't understand them if they can be projected in the journal or when you do /quest that can be completed specifically using Denizen. Let me know if I have to open a suggestions thread :D

The aforementioned pull request was merged and is now in wide circulation, satisfying this ticket.


HOTFIX distribution insufficient quantity bug

Michael discovered a bug wherein a Distribution would still be created if there was insufficient inventory.
This PR modifies the DistributionsController#create action to use a transaction. If the distribution itself is invalid, or if there is insufficient inventory, it will roll back the whole process. It also improves the flash display to render HTML.

Hi @armahillo, thanks for the PR!
It looks like you have a couple of Rubocop violations. If you run rubocop -a it should take care of them for you.

doh!

FIXED I THINK


Fix RectorConfig setlist name

Fixes https://github.com/rectorphp/rector/issues/7228.

Thank you :+1:


Pattern matching

Thank you for this awesome extension!
I'd like to propose a feature where we can trigger a shortcut when a pattern (e.g., regular expression) is matched.
I often need to refer to a JIRA ticket link when writing an email. A JIRA ticket number looks like ABC-1234. When I type "ABC-1234 ", I wanted it to be expanded to ABC-1234.
To do this, I think users can add a shortcut with a regex, such as ABC-(?<match>\d+) . The syntax uses named capture as in http://xregexp.com/syntax/#namedCapture. On the expansion field, they can fill in something like ABC-%match%.
I can send a pull request implementing this feature if you think it's a good idea.

Hey Chang-Hung, that's an interesting idea!
There will have to be some delimiter for the expander to know when to
expand, otherwise the moment you type ABC-1 it will fire off. Hit me with a
proposal and let's see how it looks.
. Carlin
............................................
Product . Design . Development
e<EMAIL_ADDRESS>: +1<PHONE_NUMBER>
On Wed, May 13, 2015 at 5:57 AM, Chang-Hung Liang<EMAIL_ADDRESS>wrote:

Thank you for this awesome extension!
I'd like to propose a feature where we can trigger a shortcut when a
pattern (e.g., regular expression) is matched.
I often need to refer to a JIRA ticket link when writing an email. A JIRA
ticket number looks like ABC-1234. When I type "ABC-1234", I wanted it to
be expanded to ABC-1234.
To do this, I think users can add a shortcut with a regex, such as
"ABC-(\d+)". And on the expansion field, they can fill in something like ABC-%match%.
I can send a pull request implementing this feature if you think it's a
good idea.
—
Reply to this email directly or view it on GitHub
https://github.com/carlinyuen/ChromeAutoTextExpander/issues/15.

I think users will have to add a special trailing character to prevent the "early fire". For example, you can add a space at the end the pattern, so the shortcut won't be triggered until you hit space.

Any thoughts? @carlinyuen

Hey sorry about that! That sounds good to me, submit a proposed change and
pull request and lets review!
On Sat, May 16, 2015, 02:45 Chang-Hung Liang<EMAIL_ADDRESS>wrote:

Any thoughts? @carlinyuen https://github.com/carlinyuen
—
Reply to this email directly or view it on GitHub
https://github.com/carlinyuen/ChromeAutoTextExpander/issues/15#issuecomment-102579732
.


Remove reinit_schedulers_properties

What does this PR do?

There is no call for this method in the codebase. It was removed here.
https://github.com/PyTorchLightning/pytorch-lightning/pull/7274/commits/40492d69c9f588da337e4510e87267f60c4bb8cd
by @tchaton
not sure 100% whether it's not required anymore (since all the tests pass) or it's a bug.
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[ ] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[ ] Did you verify new and existing tests pass locally with your changes?
[ ] Did you list all the breaking changes introduced by this pull request?
[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

[ ] Is this pull request ready for review? (if not, please submit in draft mode)
[ ] Check that all items from Before submitting are resolved
[ ] Make sure the title is self-explanatory and the description concisely explains the PR
[ ] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃

LGTM!


[FEATURE] Add option to create an automatic menu

For now all Document entries are added to the root document entry. In a follow up I plan to create a nested menu as well
References #1108

@jaapio tocnodes are replaced or removed now with warning


perf(ast): box enum variants

#3058  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @overlookmotel and the rest of your teammates on  Graphite


Calculations starting on non-business days

I'm switching over to biz from business_time, and an issue I ran into was that calculations behave differently when the start time is not a business day. biz calculates a duration starting on Sunday as if it had started from Friday, whereas business_time treats it as if it started on Monday. For example:
schedule = Biz::Schedule.new do |config|
  config.hours = {
    mon: { '07:00' => '18:00' },
    tue: { '07:00' => '18:00' },
    wed: { '07:00' => '18:00' },
    thu: { '07:00' => '18:00' },
    fri: { '07:00' => '18:00' }
  }
end

friday = Time.new(2016, 4, 1, 12)
sunday = Time.new(2016, 4, 3, 12)

Biz::Calculation::ForDuration.days(schedule, 1).after(sunday)
#=> 2016-04-04 12:00:00 UTC

Biz::Calculation::ForDuration.days(schedule, 1).after(friday)
#=> 2016-04-04 12:00:00 UTC

And with business_time:
1.business_day.after(sunday)
#=> Tue, 05 Apr 2016 12:00:00 UTC +00:00

1.business_day.after(friday)
#=> Mon, 04 Apr 2016 12:00:00 UTC +00:00

I'm using time calculations for some compliance features, and I confirmed that the business_time behavior is correct. You can see their thinking in this comment. Would you be willing to change this behavior?

First, welcome, it's great to see more people using the gem!
Unlike seconds, minutes, or hours, day calculations are inherently ambiguous since they have to make an assumption about what "a day" means in countless contexts. Because of that, when I added the feature, my primary goal was to make the explanation of the logic as straightforward as possible, knowing that it's not going to satisfy all use cases:

Find the next day that contains business hours. Starting from the same minute on that day as the specified time, look forward (or back) to find the next moment in time that is in business hours.

The idea was to establish a clear, logical building block that would satisfy a solid number of the use cases out there while also enabling users to customize it as they see fit.
In short, I don't think changing the current day calculation logic is the right approach; however, you should be able to wrap it quite easily to get what you want.
Here's a rough sketch:
schedule = Biz::Schedule.new do |config|
  config.hours = {
    mon: {'07:00' => '18:00'},
    tue: {'07:00' => '18:00'},
    wed: {'07:00' => '18:00'},
    thu: {'07:00' => '18:00'},
    fri: {'07:00' => '18:00'}
  }
end

def days_after(schedule, number, start_time)
  if schedule.in_hours?(start_time)
    schedule.time(number, :days)
  else
    schedule.time(number + 1, :days)
  end.after(start_time)
end

friday = Time.utc(2016, 4, 1, 12)
sunday = Time.utc(2016, 4, 3, 12)

days_after(schedule, 1, sunday)
#=> 2016-04-05 12:00:00 UTC

days_after(schedule, 1, friday)
#=> 2016-04-04 12:00:00 UTC

Depending on how you're using biz, you'd probably be able to make this a bit nicer, but you get the idea.
Seem reasonable?

Yeah, that makes sense. I'm already wrapping it, so it's easy to handle, I just wanted to check that it was intentional behavior. Thanks!


Restricting spacy.cli for version 3.7.0

Change Description
Describe your changes
Puts restriction on installing spacy 3.7.0
Issue reference
This PR fixes issue https://github.com/microsoft/presidio/issues/1487
Checklist

[x] I have reviewed the contribution guidelines
[x] I have signed the CLA (if required)
[x] My code includes unit tests
[x] All unit tests and lint checks pass locally
[x] My PR contains documentation updates / additions if required

Thanks! Do you think it would be possible to do this for the presidio-analyzer module? This way it would avoid this pitfall for other use cases as well, not just for CLI users

@omri374 added it to the presidio-analyzer module as well.


Suggestions wanted with training parameters

Thanks for your excellent work with Persephone! I've been now training a Komi model with one speaker, where there are 3 hours of training data, all in all 2826 segments. All segments are between 2-10 seconds in length.
Before starting to test further different things, I would like to know what would be the best next steps with my training setup. I would otherwise start just changing things one by one, but as training takes quite long while (about 10 hours), I just wanted to know if there is some clear direction others have already tested, or if there is something I clearly do wrong.
Maybe it is documented somewhere, but I haven't fully understood how num_train works. So is the number here the part of the corpus used in the training? Does it just take first nth training samples? So even if the corpus is larger, it takes only this portion? I see it has to be divisible by batch_size, as has been discussed also elsewhere here in issues. So the next thing I should test is to set that number into something as close to 2826 as possible, am I correct?
This is the training script I've used:
from persephone.corpus import Corpus
from persephone.corpus_reader import CorpusReader

corpus = Corpus(feat_type="fbank",
                 label_type="phonemes",
                 tgt_dir="persephone_mono_data/experiment")

corpus_reader = CorpusReader(corpus, num_train = 2048, batch_size=16)

from persephone.rnn_ctc import Model
model = Model("persephone_mono_model",
              corpus_reader,
              num_layers=3,
              hidden_size=250)

model.train()

The best accuracy I get now is:
Epoch 36. Training LER: 0.076162, validation LER: 0.459539

I have tried few different transcription systems, and will continue refining that, but still the validation LER I end up with is in that category.
So my question is whether there is something I should specifically change in batch_size, num_layersand hidden_size. I also thought the rand_seed could be worth testing, as the clips are now quite ordered.
The last training advanced like this:

Thanks!

Hi Niko, thanks for the kind words.

Does it just take first nth training samples? So even if the corpus is larger, it takes only this portion? [...]
So the next thing I should test is to set that number into something as close to 2826 as possible, am I correct?

That's right, num_train is the number of utterances from the training corpus that are used in training. So just make it as high as possible. It's a bit of a weird parameter that mostly just exists for doing experiments where you see how model performance scales with training data.
 (The model shuffles training instances by default, the seed just changes what ordering the pseudo random number generator picks, but it will always be random regardless of the seed).
Judging by the image you posted of your training profile, I'm not holding by breath to see better error rate on the validation set. The usual recommendation to try get better performance would be to increase the hidden size or the number of layers. However, given the divergence of the train and validation error rates, with the validation error rate flatlining and the training error rate continuing to drop, it seems clear that it's not that the model lacks capacity, but simply that it is unable to generalize performance to validation set. So this might be as good as it gets with the model that's implemented in Persephone. How many speakers are in your corpus?

Hi Oliver! Thanks for help and feedback! This training was done with one speaker's utterances which make altogether 3 hours. The entire corpus is around 35 hours, but I wanted to figure out how to do this with the single speaker to test it better. My experiments with larger corpus have been much less successful than this, so the direction has at least been right.
There are few speakers in the corpus who have very often participated to the recordings as interviewers, so this experiment was done from the data where I extracted everything one person said in many recordings and filtered out the segments that were too short or too long. This also means that almost every utterance in the dataset is a question, which I assume is just a curiosity and not a problem.
I'll train the model again today with num_train set as high as possible, and also start to inspect the test set bit closer. There may be some overlapping speech in the segments, and I could clean away all of those. These are also all quite ordinary conversations, so people speak fast and on top of each others, but I'll try to find some subset the model could learn bit better. Our research group also has similar corpora for other languages, so I'm probably testing something else into this too.

I'm testing the training now with new data. The training process is otherwise the same as described above, but I'm getting an error. I'm assuming some audio file has a problem, but any suggestions what kind of problem I should search for?
exp_dir experiment-01, epoch 1
	Batch...0...1...2...3...4...5...6...7...8...9...10...11...12...13...14...15...16...17...18...19...20...21...22...23...24...25...26...27...28...29...30...31...32...33...34...35...36...37...38...39...40...41...42...43...44...45...46...47...48...49...50...51...52...53...54...55...56...57...58...59...60...61...62...63...64...65...66...67...68...69...70...71...72...73...74...75...76...77...78...79...80...81...82...83...84...85...86...87...88...89...90...91...92...93...94...95...96...97...98...99...100...101...102...103...104...105...106...107...108...109...110...111...112...113...114...115...116...117...118...119...120...121...122...123...124...125...126...127...128...129...130...131...132...133...134...135...136...137...138...139...140...141...142...143...144...145...146...147...148...149...150...151...152...2020-06-01 13:44:44.287364: W tensorflow/core/framework/op_kernel.cc:1651] OP_REQUIRES failed at ctc_loss_op.cc:168 : Invalid argument: Not enough time for target transition sequence (required: 23, available: 22)8You can turn this error into a warning by using the flag ignore_longer_outputs_than_inputs
Unhandled exception
Traceback (most recent call last):
  File "/Users/npartane/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/client/session.py", line 1365, in _do_call
    return fn(*args)
  File "/Users/npartane/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/client/session.py", line 1350, in _run_fn
    target_list, run_metadata)
  File "/Users/npartane/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/client/session.py", line 1443, in _call_tf_sessionrun
    run_metadata)
tensorflow.python.framework.errors_impl.InvalidArgumentError: Not enough time for target transition sequence (required: 23, available: 22)8You can turn this error into a warning by using the flag ignore_longer_outputs_than_inputs
	 [[{{node CTCLoss}}]]

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "train_persephone.py", line 32, in <module>
    model.train()
  File "/Users/npartane/anaconda3/lib/python3.7/site-packages/persephone/model.py", line 392, in train
    feed_dict=feed_dict)
  File "/Users/npartane/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/client/session.py", line 956, in run
    run_metadata_ptr)
  File "/Users/npartane/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/client/session.py", line 1180, in _run
    feed_dict_tensor, options, run_metadata)
  File "/Users/npartane/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/client/session.py", line 1359, in _do_run
    run_metadata)
  File "/Users/npartane/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/client/session.py", line 1384, in _do_call
    raise type(e)(node_def, op, message)
tensorflow.python.framework.errors_impl.InvalidArgumentError: Not enough time for target transition sequence (required: 23, available: 22)8You can turn this error into a warning by using the flag ignore_longer_outputs_than_inputs
	 [[node CTCLoss (defined at /Users/npartane/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/framework/ops.py:1748) ]]

Original stack trace for 'CTCLoss':
  File "train_persephone.py", line 30, in <module>
    hidden_size=250)
  File "/Users/npartane/anaconda3/lib/python3.7/site-packages/persephone/rnn_ctc.py", line 136, in __init__
    preprocess_collapse_repeated=False, ctc_merge_repeated=True)
  File "/Users/npartane/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/ops/ctc_ops.py", line 176, in ctc_loss
    ignore_longer_outputs_than_inputs=ignore_longer_outputs_than_inputs)
  File "/Users/npartane/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/ops/gen_ctc_ops.py", line 336, in ctc_loss
    name=name)
  File "/Users/npartane/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/framework/op_def_library.py", line 794, in _apply_op_helper
    op_def=op_def)
  File "/Users/npartane/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/util/deprecation.py", line 507, in new_func
    return func(*args, **kwargs)
  File "/Users/npartane/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/framework/ops.py", line 3357, in create_op
    attrs, op_def, compute_device)
  File "/Users/npartane/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/framework/ops.py", line 3426, in _create_op_internal
    op_def=op_def)
  File "/Users/npartane/anaconda3/lib/python3.7/site-packages/tensorflow_core/python/framework/ops.py", line 1748, in __init__
    self._traceback = tf_stack.extract_stack()

I fixed it now, I think there must have been a very very short audio fragment there, so I set the threshold higher for that in my processing script. Now it passed the first epoch so I assume things are ok. :)

This looks like a very similar issues to this: https://github.com/mozilla/DeepSpeech/issues/1629
I'm guessing this is due to some short audio file. I'm a little concerned that the failure is detected late in the training process but I'm not entirely sure at this point what the mitigation for this would be since I don't have enough information to reproduce this bug myself.

@nikopartanen Yeah, you got it.
The reason this happens is is because of the way the CTC loss function works. It sums over all the possible ways your input-frame -> output-label alignments when collapsing repeated output-labels. It thus assumes that your input sequence is longer than your output. If you have a very short wav but a longer output sequence, it will break.
The mitigation is simply to check if the number of input frames is > output labels for a given training sequence.

Thanks for explanation, @oadams! I have few more questions:
When I create the corpus, i.e. like this:
from persephone.corpus import Corpus
corpus = Corpus(feat_type="fbank",
                 label_type="phonemes",
                 tgt_dir="experiment")

It will create the directory feat and the files corpus.p, test_prefixes.txt, train_prefixes.txt and valid_prefixes.txt. Let's say I have 1025 training files.
If I then train the model i.e. with parameter num_train = 1024, how do I know which part of the train_prefixes.txt it has used? Up to the point specified in that number, so the last one will not be used in any way, in this case?
Other question: If I realise that some files should not be in the experiment, can I just remove those from the files test_prefixes.txt, train_prefixes.txt and valid_prefixes.txt, in order to keep otherwise the same data split across experiments?

Hi @nikopartanen, sorry about the delay

If I then train the model i.e. with parameter num_train = 1024, how do I know which part of the train_prefixes.txt it has used? Up to the point specified in that number, so the last one will not be used in any way, in this case?

If train_prefixes.txt is specified, then the prefixes in those file are read in in order. and set as a the corpus objects .train_prefixes attribute. CorpusReader will then just take the first 1024 of those prefixes. To be sure, it's best to check the corpus reader's .train_fns attribute to see if this is actually the case.

Other question: If I realise that some files should not be in the experiment, can I just remove those from the files test_prefixes.txt, train_prefixes.txt and valid_prefixes.txt, in order to keep otherwise the same data split across experiments?

Yes, you can do that. Just make sure you create a new Corpus object after changing those files, and double check the splits by looking at the .train_prefixes attribute, etc to make sure it was registered correctly.

Hi again! Now I do have a very urgent question. @oadams, how can we get easily test set LER? We get validation LER during training, of course, but what is the recommended way to get it for test set? Or is it customary to report validation LER? We made tons of experiments and collected validation LER's, but I think we also need to get these.

Hi! Sorry, I missed the urgency of this. model.eval() should do what you want. Model.train() will train and get scores on the validation set, while Model.eval() runs it on the test set.

Great, I'll test it right away! Thanks a lot! We just had a deadline, but we did find a solution to report some scores that made sense. Now I'll do the evaluation against this, but it cannot be entirely different from what we had earlier.

@nikopartanen was this approach successful?


Fix button shortcut with ACTION_MODE_BUTTON_RELEASE

A button with ACTION_MODE_BUTTON_RELEASE should not react to pressed, but to unpressed shortcuts.
resolve part of #75318
This doesn't try to fix the other issue, that when the button has focus, enter-press+release triggers the button twice, which would require a bigger change: InputEvent gets set to handled, when a button is successfully pressed.

I think shortcuts intentionally always react to pressed, because otherwise it caused some issues (I remember one about Ctrl+A, can't find it right now). It doesn't help that all buttons default to release mode.

Thank you for the explanation.
If I understand this right, this PR would introduce the problem, that many Buttons would feel less responsive, because their default value is set to release-mode.
Release-mode for mouse makes sense, but shortcuts currently ignore it for a reason. Considering this, I believe that the linked issue should be labeled as a "Documentation" problem.

I left a comment in the issue.
Although it mentions something about shortcut firing twice; this might be actual bug.

I agree, that the shortcut-firing twice is a bug. Closing this PR, because it would introduce problems as explained above.


Affected code context

Just the affected line alone doesn't always provide enough information, thus oftentimes it's helpful to see several (ought to be configurable, usually 3/5 is a good default) lines of context before and after it.

Yeah, i also was thinking about that but decided to make it simple at the beginning. We can be even more dynamic displaying multiple lines taking into account node.location, nide.end_location. But haven’t decided the best way yet


json not complete for 'Work with outputs from CLI script'

I'm looking for a clear example for how to use the output from an AzureCLI deployment script in bicep in a later step with bicep. That part is unclear/vague and can be explained more clearly.
Also, the json in this example is not complete: https://docs.microsoft.com/en-us/azure/azure-resource-manager/templates/deployment-script-template?tabs=CLI#work-with-outputs-from-cli-script

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b5c4c8c5-7757-a969-5800-17f2f2312649
Version Independent ID: 9ced8dd5-43ca-6d1f-c054-842299db8327
Content: Use deployment scripts in templates - Azure Resource Manager
Content Source: articles/azure-resource-manager/templates/deployment-script-template.md
Service: azure-resource-manager
Sub-service: templates
GitHub Login: @mumian
Microsoft Alias: jgao

@bj-tukker Thanks for your comment! We will review and provide an update as appropriate.

Hi,
looks like the bicep isn’t being parsed correctly: it is complete in the bicep: azure-docs-bicep-samples/passValue-cli.bicep at main · Azure/azure-docs-bicep-samples (github.com)https://github.com/Azure/azure-docs-bicep-samples/blob/main/samples/deployment-script/passValue-cli.bicep
Kind regards/Met vriendelijke groet,
Bart Tukker
Cloud Engineer
From: KrishnaG-MSFT @.>
Sent: dinsdag 18 januari 2022 15:25
To: MicrosoftDocs/azure-docs @.>
Cc: Tukker, BJ (Bart) @.>; Mention @.>
Subject: Re: [MicrosoftDocs/azure-docs] json not complete for 'Work with outputs from CLI script' (Issue #86554)
@bj-tukkerhttps://github.com/bj-tukker Thanks for your comment! We will review and provide an update as appropriate.
—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/86554#issuecomment-1015461887, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AT36KUZQPESNVZMYG3ZN6B3UWVZ23ANCNFSM5MG7MKJA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>======================================================
Rabobank disclaimer: http://www.rabobank.nl/disclaimer
<#rbnl#1898i>

This email (including any attachments to it) is confidential, legally privileged, subject to copyright and is sent for the personal attention of the intended recipient only. If you have received this email in error, please advise us immediately and delete it. You are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited. Although we have taken reasonable precautions to ensure no viruses are present in this email, we cannot accept responsibility for any loss or damage arising from the viruses in this email or attachments. We exclude any liability for the content of this email, or for the consequences of any actions taken on the basis of the information provided in this email or its attachments, unless that information is subsequently confirmed in writing. <#rbnl#1898i>

I think in the bicep code
:::code language="bicep" source="~/azure-docs-bicep-samples/samples/deployment-script/passValue-cli.bicep" range="1-25" highlight="19":::
should be changed to
:::code language="bicep" source="~/azure-docs-bicep-samples/samples/deployment-script/passValue-cli.bicep" range="1-35" highlight="19":::
Kind regards/Met vriendelijke groet,
Bart Tukker
Cloud Engineer
From: Tukker, BJ (Bart)
Sent: dinsdag 18 januari 2022 17:42
To: MicrosoftDocs/azure-docs @.***>
Subject: RE: [MicrosoftDocs/azure-docs] json not complete for 'Work with outputs from CLI script' (Issue #86554)
Hi,
looks like the bicep isn’t being parsed correctly: it is complete in the bicep: azure-docs-bicep-samples/passValue-cli.bicep at main · Azure/azure-docs-bicep-samples (github.com)https://github.com/Azure/azure-docs-bicep-samples/blob/main/samples/deployment-script/passValue-cli.bicep
Kind regards/Met vriendelijke groet,
Bart Tukker
Cloud Engineer
From: KrishnaG-MSFT<EMAIL_ADDRESS>Sent: dinsdag 18 januari 2022 15:25
To: MicrosoftDocs/azure-docs<EMAIL_ADDRESS>Cc: Tukker, BJ (Bart<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [MicrosoftDocs/azure-docs] json not complete for 'Work with outputs from CLI script' (Issue #86554)
@bj-tukkerhttps://github.com/bj-tukker Thanks for your comment! We will review and provide an update as appropriate.
—
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/86554#issuecomment-1015461887, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AT36KUZQPESNVZMYG3ZN6B3UWVZ23ANCNFSM5MG7MKJA.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>======================================================
Rabobank disclaimer: http://www.rabobank.nl/disclaimer
<#rbnl#1898i>

This email (including any attachments to it) is confidential, legally privileged, subject to copyright and is sent for the personal attention of the intended recipient only. If you have received this email in error, please advise us immediately and delete it. You are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited. Although we have taken reasonable precautions to ensure no viruses are present in this email, we cannot accept responsibility for any loss or damage arising from the viruses in this email or attachments. We exclude any liability for the content of this email, or for the consequences of any actions taken on the basis of the information provided in this email or its attachments, unless that information is subsequently confirmed in writing. <#rbnl#1898i>

@bj-tukker - thank you for your comments.  I have created a PR to address the issue.
#please-close


New version: brimdata.brim version 1.4.1

Pull request has been created with WinGet Automation :rocket:
Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:


finish up monorepo

I think the separate pull requests run into issues because of cross references, so I try to solve them all at once here :)
closes #242, closes #244, closes #245, closes #248

I can now reproduce the error with npm run test-express-minimum when testing in node 6.11.0 & npm 3.10.10.
The error here: https://travis-ci.org/pouchdb/pouchdb-server/jobs/250086626#L3465 comes from this assertion here: https://github.com/pouchdb/pouchdb/blob/master/tests/integration/test.all_docs.js#L752
when run with npm run test-express-minimum, then _conflicts  is an empty array [] instead of undefined. So that might be a pouchdb server error somewhere. But all the rest is passing, so I think this is good to go

I’m positive that this is fixed in latest PouchDB 6. But upgrading to it (and testing with latest PouchDB test suite) is another rabbit hole :(
I honestly don’t know what to do. I say we merge this in despite the failing tests. We continue to add all of the other modules that pouchdb-server depends on and merge it into the repo. Then we upgrade to latest POuchDB and fix all the incompatibilities, now that they are all in the mono repo.
I fear this is another 1-3 days of work, depending on how many other rabbit holes there are.

These are the tests that are currently failing from the PouchDB Test suite at https://github.com/pouchdb/pouchdb/tree/f9beadd (which i think is the last commit before 6.2.0 release)
test.bulk_docs

'#2935 new_edits=false with single unauthorized'

test.replication

'#2268 dont stop replication if single forbidden'
'#2268 dont stop replication if single unauth'
'#2268 dont stop replication if many unauth'
'#3171 Forbidden validate_doc_update error message'
'#3171 Unauthorized validate_doc_update error message'
'#3070 Doc IDs with validate_doc_update errors'
'#3270 triggers "denied" events'

test.sync

'#3270 triggers "denied" events'
'#3270 triggers "denied" events, reverse direction'

You can change the pouchdb test version used herer https://github.com/pouchdb/pouchdb-server/blob/master/bin/test-setup.sh#L18
But if you still struggling I guess lets merge and take it from there.


create mod subnet

Work in progress.  This is prototype code and is not yet ready for a full review.
This update to the lorawan library will allow translation between the LoRaWAN devaddr and Helium subnet address space.  This will allow proper routing from a DevAddr to an OUI host.
These are changes needed to support the transtion to Helium's official NetID. NetIDs support a limited address range, e.g. a class 6 NetID supports 1,024 addresses. We plan to support a list of NetIDs. In the future we can simply add new NetIDs to the chain var. This will allow for future end-device growth.

Would a lot of this be nicer with a DevAddr type?

I was wondering the same thing, but it feels a little pedantic. I guess it depends on @mikev background with rust. If new, then too much typing is overload

If new, then too much typing is overload

Totally fair. I just love to type all the things at this point with Rust but in the beginning it doesn't feel as compelling.

Be sure to run Clippy, but addressing its recommendations can be a future PR.

We generally consider any clippy warnings a blocker for merging. Not sure if this repos CI enforces it

@mikev please remove println from code. It is not good practice to leave those sprinkled around since they don’t always go where they should


Remove deprecated legacy crd v1beta1

no major cloud providers needs it anymore (removed in 1.22 but you need to be on Kubernetes < 1.16 to not have v1 - see this)
might create a thing for MK8SV as 1.16 as well if this is approved.
(1.16 is lower than what we would support with the future version plan)
EDIT: although it is debatable whether we should keep it around until the version of kubernetes that removed it becomes unavailable, in which case we might wait for another while.

Codecov Report

Merging #890 (1cc4a35) into master (5f0ff7d) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #890      +/-   ##
==========================================
- Coverage   70.25%   70.23%   -0.03%
==========================================
  Files          61       61
  Lines        4223     4223
==========================================
- Hits         2967     2966       -1
- Misses       1256     1257       +1

Impacted Files
Coverage Δ

kube-runtime/src/wait.rs
68.00% <0.00%> (-2.00%)
:arrow_down:

Thank you for thinking of us. I'll check and will get back to you shortly.

We (@stackabletech) haven't supported v1b1 since at least back when I joined, and I don't really see that changing any time soon.


Space travelers' hub

Here is the link to kanban-board.
We're 3 coding partners working on this project.
@iamsjunaid
@AbdelazizSoliman
@wolterbwambale

Hi Team
Your project is complete!
Congratulations! 🎉

Highlights
your Kanban board is well descriptive 👍
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @joel-kalema in your question so I can receive the notification.

As described in the Code reviews limits policy  you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Compare API to MineCraft, Terraria

Maybe take a look at how MineCraft and Terraria mods define new parquets, etc. just to see where PCL differs and make sure those difference are sane.  There might be a better way to solve these problems.

Looked at the way MineCraft Java version and MineCraft Bedrock version handle this.
Beckrock had nothing to offer but Java version had a nice affordance:
GetBlockForItem() and GetItemForBlock()
It appears that these only work when generating a simple dropped form of a block, i.e. placed stone ⇒ collectible stone, and does not when dropping a non-block item, i.e. placed gold ore ≠> collectible gold.
So I think current behavior is fine for now.  If designers request something easier, or if modding becomes a thing, then an upgrade can be designed.

Terraria, for what it's worth, seems to be entirely hardcoded, so no help there!


Update how-to-deploy.mdx

the branch for repository RasaHQ/action-server-gha should now be main (currently: master)
Proposed changes:

...

Status (please check what you already did):

[ ] added some tests for the functionality
[ ] updated the documentation
[ ] updated the changelog (please check changelog for instructions)
[ ] reformat files using black (please check Readme for instructions)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for submitting a pull request 🚀 @joejuzl will take a look at it as soon as possible ✨


Individual commands to switch between stats, tasks and settings tab

Not a trivial problem I think?
Possible start:
Right now tabs are linked to the fxml on MainWindow.java. Your job will be to link the TabPane instead of the tabs, then create command/s to call the following functions.
https://stackoverflow.com/questions/20955633/how-to-switch-through-tabs-programmatically-in-javafx


Which antivirus SW is used

Hello, please could you add more information about which antivirus solution is used for scanning of blobs for malware ?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2b92c195-c670-2e27-2422-fd131586bdd7
Version Independent ID: 75ad901d-8064-bfbe-67f5-de507bede1bc
Content: Configure advanced threat protection - Azure Storage
Content Source: articles/storage/common/storage-advanced-threat-protection.md
Service: storage
Sub-service: common
GitHub Login: @tamram
Microsoft Alias: tamram

@jjindrich Thanks for your question. We are checking on this and will respond to you soon.

@jjindrich currently Advanced Threat Protection for Azure Storage leverages the advanced capabilities of Microsoft Threat Intelligence to detect malware in Storage Accounts. The current detection is based on hash reputation analysis and alerts customers upon potential malware uploaded to their storage accounts. So at the moment, we don't provide a native solution for antivirus scanning of blobs in Azure Storage.

Thanks for that info, @HasanAboShally-MSFT Can you explain what a developer should do in order to-pre-scan any files being uploaded to blob storage?


Styling and cross-referencing display math equation numbers

With soon coming https://github.com/Omikhleia/markdown.sile/issues/81 in mind...

We may want to consider overriding math:numberingstyle (SILE 0.15), so that display math equation numbers could be styled with resilient's styling paradigm consistently, with the usual pattern. (font, color, pre/post delimiters, etc.)
We may want to subscribe to labelrefs so cross-referencing an equation would be available.

Of course, our use here of the math:numberingstyle  hook owes to @leorosa 's initial effort to bring this to SILE.


Migrate Symfony from auth0.js

@lukeoliff This post has been updated to not use auth0.js on the client side, but rather, implement the flow for traditional web apps. Can you please give the changes a quick read and merge if all looks good? Thanks!


Report on unused RDS instances

In order to reduce costs, we need to know about RDS databases which aren't actively being used.
Acceptance Criteria

[x] Given access to the AWS CLI, select RDS instances which have not been used for a given amount of time using cloudwatch data.  Compare this to the results for 14 days emitted by the Trusted Advisors Checks for Amazon RDS Idle DB Instances, but exclude RDS instances which no longer exist
[ ] A pipeline exists which can run the report on demand? (Van: do we go this far or just drop it in cg-scripts?)

Security considerations
Do not hardcode AWS credentials when creating the script to create a report
Implementation sketch

[x] Figure out how to query cloudwatch for 0 connections
[x] Figure out how many days to go back to look for inactivity, 180 feels like a good start
[x] Create the script and drop it into cg-scripts
[ ] Pipeline?

Spreadsheet of output: https://docs.google.com/spreadsheets/d/1dpe0IbF3UVmPguX9kppdyfwgD3oPeJUY-FWbO5u6nG4/edit#gid=0
Script created at: https://github.com/cloud-gov/cg-scripts/blob/main/aws/aws-list-unused-rds-databases.py


Make Auth0 an optional dependency

I seems we have quite a lot of users who, understandably, do not want to use Auth0 for their authentication, https://github.com/futurice/pepperoni-app-kit/issues/78, https://github.com/futurice/pepperoni-app-kit/issues/91 among others.
We shipped Pepperoni with the assumption that it would be easier for the users to remove Auth0 than it would be to add it, but this assumption has turned out to be incorrect. Additionally, integrating Auth0 has become a lot easier due to rnpm now shipping with React Native.
Let's start work on downgrading Auth0 from a default dependency to an optional one, implemented as sample code and documentation.

@jevakallio Regarding docs, does pointing to the code back when auth0 was still around be enough for you?
Something like this:

Auth0
Pepperoni used to be bundled with Auth0 but it has been removed by popular request.
You can follow this guide to get it back.
Installation
First, get the react-native-lock npm package.
$ npm i -S react-native-lock@futurice/react-native-lock#feature/customizedTheme

Then link the package to IOS and Android builds with the link command:
$ react-native link react-native-lock

Usage
You can see exemple of code used in Pepperoni when Auth0 was still bundled here.
The files you'll be interrested in are:

src/modules/auth/AuthState.js (and src/modules/auth/__specs__/AuthState.spec.js)
src/services/auth0.js
src/redux/reducer.js
src/components/DeveloperMenu.android.js
src/components/DeveloperMenu.ios.js
src/modules/AppView.js
src/modules/AppViewContainer.js
src/modules/counter/CounterViewContainer.js


Oposite timeline order?

I would like to use this jekyll template, but for my purposes would it be more preferrable, if the old changes were at the bottom of the page and the more recent changes at the top.
So for example:

December 2022
November 2022
...
January 2021

Is this doable, and if so, what would I need to change?

Found the solution:
{% for step in steps reversed %}


Handle explicitly undefined options argument in updateTimingHandler

This is a follow up on #191.
Handle case where effect.updateTiming() is called with an explicit undefined options argument.
This happens in the view-timeline-subject-size-changes test.
After a discussion in #191 we skipped checking for an explicitly undefined options argument, and instead returned if the argumentList was undefined or empty. That does not cover the case where the method is called explicitly with undefined as an argument as below.
effect.updateTiming(undefined)
// argumentList == [undefined]
// arguementList.length == 1

@bramus I realized our changes in #191 doesn't handle the case where undefined is passed explicitly as an argument to updateTiming(), as it is done in the WPT subtest. Do you mind reviewing this PR?


Remove Product Design page

This position has been filled and we must hide it.
https://liferay.design/careers/emea/lead-product-designer/

looks like this was solved in #1020 cc @victorvalle


fix typo in README.md

fix the wrong Arxiv link to PALM paper

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Kind.x in function parseJSONLiteral(ast)

Hi @HriBB,
In the readme.md file the function parseJSONLiteral(ast) references Kind.STRING, Kind.BOOLEAN, Kind.INT, Kind.FLOAT, Kind.OBJECT.
Where are these coming from? / How should I define them?
From the readme.md:
function parseJSONLiteral(ast) {
  switch (ast.kind) {
    case Kind.STRING:
    case Kind.BOOLEAN:
      return ast.value;
    case Kind.INT:
    case Kind.FLOAT:
      return parseFloat(ast.value);
    case Kind.OBJECT: {
      const value = Object.create(null);
      ast.fields.forEach(field => {
        value[field.name.value] = parseJSONLiteral(field.value);
      });

      return value;
    }
    case Kind.LIST:
      return ast.values.map(parseJSONLiteral);
    default:
      return null;
  }
}

I just stumbled upon the solution from the apollo docs:
import { Kind } from 'graphql/language';
This means graphql also should be a peer dependency.

@sandervanhooft did you reopen this on purpose?

Hi @thebigredgeek . Yes, because of the graphql dependency.
In issue #1 it's mentioned that peer dependencies are no more... Consider to put graphql into dependencies?
Feel free to close if this dependency is not an issue.

Hey guys, I'm really busy ATM, so if you want, you can make a PR to fix this. Otherwise, I'll try to fix is ASAP.

I'm using "graphql": "^0.7.2",, will try to make a PR soon

Honestly I think the solution here is to provide the scalar definition in the package.  Adding a dependency just so that another package cab require it sounds like bad engineering


Unexpected report when using ClassName=UpperCamel

I am using release v0.3.4 on Windows 10, following is my cppnamelint.toml:
...
ClassName               = 1 # 0: Default (UpperCamel)
                            # 1: UpperCamel
...

Either I set this value to 0 or 1, it will wrongly report that my class name violates the rule, following is the formatted result.json:
            {
                "Column": 1,
                "Expected": "",
                "Line": 46,
                "TargetName": "XxxxXxxx",
                "Type": 5,
                "TypeName": "class"
            }

@keineahnung2345 glad to receive your feedback. I am planning to archive this project because the major feature of this project had been merged into clang-tidy (https://github.com/llvm/llvm-project/commit/2b9b5bc0).

@dougpuob Oh, it's a good news.


org.nd4j.linalg.jcublas.blas.JcublasLevel1 syncronizes on CudaContext causing performance problem

I'm using  nd4j 0.4-rc3.9 and dl4j 0.4-rc3.10-SNAPSHOT to build a ParagraphVector using using GPU's and the training time is significantly longer than if I were using CPU's.  It looks like synchonizing on the CudaContext is causing seven other threads to wait for the lock (the instance I'm using has 8 CPU's).  Below are the typical lock/wait stacks.
"VectorCalculationsThread 4" #24 prio=5 os_prio=0 tid=0x00007f8a7aa6f000 nid=0x356 runnable [0x00007f8a9b4ef000]
java.lang.Thread.State: RUNNABLE
at org.nd4j.nativeblas.NativeOps.setBlasStream(Native Method)
at org.nd4j.linalg.jcublas.blas.JcublasLevel1.saxpy(JcublasLevel1.java:410)
- locked <0x00000006e1a8f5e8> (a org.nd4j.jita.allocator.pointers.cuda.cublasHandle_t)
at org.nd4j.linalg.api.blas.impl.BaseLevel1.axpy(BaseLevel1.java:301)
at org.deeplearning4j.models.embeddings.learning.impl.elements.SkipGram.iterateSample(SkipGram.java:197)
at org.deeplearning4j.models.embeddings.learning.impl.elements.SkipGram.skipGram(SkipGram.java:154)
at org.deeplearning4j.models.embeddings.learning.impl.elements.SkipGram.learnSequence(SkipGram.java:129)
at org.deeplearning4j.models.sequencevectors.SequenceVectors.trainSequence(SequenceVectors.java:218)
at org.deeplearning4j.models.sequencevectors.SequenceVectors$VectorCalculationsThread.run(SequenceVectors.java:921)
"VectorCalculationsThread 3" #23 prio=5 os_prio=0 tid=0x00007f8a7aa32800 nid=0x355 waiting for monitor entry [0x00007f8a9b5f0000]
java.lang.Thread.State: BLOCKED (on object monitor)
at org.nd4j.linalg.jcublas.blas.JcublasLevel1.saxpy(JcublasLevel1.java:409)
- waiting to lock <0x00000006e1a8f5e8> (a org.nd4j.jita.allocator.pointers.cuda.cublasHandle_t)
at org.nd4j.linalg.api.blas.impl.BaseLevel1.axpy(BaseLevel1.java:301)
at org.deeplearning4j.models.embeddings.learning.impl.elements.SkipGram.iterateSample(SkipGram.java:197)
at org.deeplearning4j.models.embeddings.learning.impl.elements.SkipGram.skipGram(SkipGram.java:154)
at org.deeplearning4j.models.embeddings.learning.impl.elements.SkipGram.learnSequence(SkipGram.java:129)
at org.deeplearning4j.models.sequencevectors.SequenceVectors.trainSequence(SequenceVectors.java:218)
at org.deeplearning4j.models.sequencevectors.SequenceVectors$VectorCalculationsThread.run(SequenceVectors.java:921)
or
"VectorCalculationsThread 6" #26 prio=5 os_prio=0 tid=0x00007fea2281c800 nid=0x63e runnable [0x00007fea787b8000]
java.lang.Thread.State: RUNNABLE
at org.nd4j.nativeblas.Nd4jBlas.saxpy(Native Method)
at org.nd4j.linalg.jcublas.blas.JcublasLevel1.saxpy(JcublasLevel1.java:413)
- locked <0x00000006e1add778> (a org.nd4j.jita.allocator.pointers.cuda.cublasHandle_t)
at org.nd4j.linalg.api.blas.impl.BaseLevel1.axpy(BaseLevel1.java:301)
at org.deeplearning4j.models.embeddings.learning.impl.elements.SkipGram.iterateSample(SkipGram.java:197)
at org.deeplearning4j.models.embeddings.learning.impl.sequence.DBOW.dbow(DBOW.java:104)
at org.deeplearning4j.models.embeddings.learning.impl.sequence.DBOW.learnSequence(DBOW.java:71)
at org.deeplearning4j.models.sequencevectors.SequenceVectors.trainSequence(SequenceVectors.java:225)
at org.deeplearning4j.models.sequencevectors.SequenceVectors$VectorCalculationsThread.run(SequenceVectors.java:921)
"VectorCalculationsThread 5" #25 prio=5 os_prio=0 tid=0x00007fea2281a800 nid=0x63d waiting for monitor entry [0x00007fea788b9000]
java.lang.Thread.State: BLOCKED (on object monitor)
at org.nd4j.linalg.jcublas.blas.JcublasLevel1.sdot(JcublasLevel1.java:52)
- waiting to lock <0x00000006e1add778> (a org.nd4j.jita.allocator.pointers.cuda.cublasHandle_t)
at org.nd4j.linalg.api.blas.impl.BaseLevel1.dot(BaseLevel1.java:33)
at org.nd4j.linalg.factory.BaseBlasWrapper.dot(BaseBlasWrapper.java:188)
at org.deeplearning4j.models.embeddings.learning.impl.elements.SkipGram.iterateSample(SkipGram.java:181)
at org.deeplearning4j.models.embeddings.learning.impl.sequence.DBOW.dbow(DBOW.java:104)
at org.deeplearning4j.models.embeddings.learning.impl.sequence.DBOW.learnSequence(DBOW.java:71)
at org.deeplearning4j.models.sequencevectors.SequenceVectors.trainSequence(SequenceVectors.java:225)
at org.deeplearning4j.models.sequencevectors.SequenceVectors$VectorCalculationsThread.run(SequenceVectors.java:921)

Even without synchronization, subsequent kernel launches on CUDA device will be worse performance-wise, then full-blown separate CUDA implementation W2V. So, CUDA performance on W2V tasks in current architecture is suffering mosly from x86 parallelism model, then on those syncs.
To address that we've already discussed special CUDA implementation for W2V and it's derivatives.
Blockwise dot/axpy approach performance should be enough to outperform x86 approach.

Some numbers:
Average w2v model vector length hides somewhere between 100 and 300 elements.For SIMD-enabled cpu that's 25-75 cpu cycles for dot.
And to do the same on CUDA you still need to launch kernel. Kernel will have  1 - 9 blocks (depending on approach, but 1 block is enough). So, in total you'll have 300 threads.  Just too small task.
That's why it's slow right now. CUDA Word2Vec just requires a bit different parallelism model.


Embedded messages, global enums not implemented

Also there seems to be a problem with enums currently, they're just left as integers, support for using them by their name should also be implemented.

45f01bfb8b6dc550df7c6d75244a3d97a747bf71


Configuration of github-token

I have created a github token called GITHUB_TOCKEN_BLACK_DUCK
and wanted it to use it in my actions with:
with:
          github-token: ${{ secrets.GITHUB_TOKEN_BLACK_DUCK }}

The action failed always with: HttpError: You must authenticate via a GitHub App.
If i understand it correctly, every workflow run creates/updates the secret GITHUB_TOKEN
and your action only works if you configure it with this token:
with:
          github-token: ${{ secrets.GITHUB_TOKEN }}

If you can use it only this way, you should not make it configurable and
implement it hard-coded.

Thanks a bunch for raising this issue! I ran into the same problem and Synopsys' documentation is no help at all.


Added note on using semistandard.

we have line of doc about semistandard:
https://github.com/keycloak/keycloak-nodejs-auth-utils/blob/master/CONTRIBUTING.md
but I understand this PR as kind of feedback
LGTM

Ah funny - really didn't see that at all.

@thomasdarimont but this your note is more easy to see than this simple phrase
"Make sure the jshint and semistandard are happy and that all tests pass"

Thanks for the contrib