CSFB and Jefferies Orders Via API?

I'm trying to submit any sort of CSFB or Jefferies algorithm order with IbPy and cannot get it to work. IB documentation says these orders are able to be submitted via API here among other places, unless I'm misunderstanding what they mean by "socket based API support".
I translated a java example for submitting CSFB's VWAP order from IB's printable 2015 API pdf documentation (page 562) and ended with the following code, which does not work:
`
contract = Contract()
contract.m_symbol = 'IBM'
contract.m_secType = 'STK'
contract.m_exchange = 'CSFBALGO'
contract.m_currency = 'USD'
params = []
params.append(TagValue('StartTime', '14:40:00 EST'))
params.append(TagValue('EndTime', '15:40:00 EST'))

order = Order()
order.m_action = 'BUY'
order.m_totalQuantity = 100
order.m_orderType = 'LMT'
order.m_lmtPrice = 200.0
order.m_algoStrategy = 'VWAP'
order.m_algoParams = params
order.m_transmit = False

connection.placeOrder(order_id, contract, order)

`
No error is given and no order shows up in TWS' API tab.  I've successfully placed other orders, such as IB's adaptive, via API however.  Does IbPy support this?  Any thoughts on how to get this to work?

Turns out the problem is that there is no default value for the execution style parameter so it needs to be provided, e.g. "params.append(TagValue('ExecStyle', 'Normal'))" .  Jefferies algos don't work bc IB does not yet support them via API.


Block Break Issue again

What is your Quests version / build number (do not say "latest")?
3.8.0, paper 1.13.2
Describe the problem and how to replicate it. Any console errors to post using Pastebin.com?
I'm using "CARROTS" Material ID. When doing /quest to check on progress, it shows nothing. It only pops out the title in chat, not the "Harvest 0/500 Carrots" but the quest works.

This applies [POTATOES, BEETROOTS].

I misunderstood what you were trying to portray in #977
Please give the following dev build a go:
https://ci.codemc.io/job/PikaMug/job/Quests/39/

Issue seems to be solved


Add support for hibernate-envers.

Is your feature request related to a problem? Please describe.
Metadata for hibernate-envers is missing causing trouble for applications.
java.lang.NoSuchMethodException: org.hibernate.envers.boot.internal.LegacyModifiedColumnNamingStrategy.<init>()
        at java.lang.Class.getConstructor0(DynamicHub.java:3585) ~[demo.exe:na]
        at java.lang

Describe the solution you'd like
Metadata extracted by running hibernate-envers tests with the agent attached should be added to this repo.
Describe alternatives you've considered
Everyone has to do it own their own.
Additional context
See: spring-projects/spring-data-jpa#2662

Already working on a PR.


Fix #460: no overlap when previous segment is shorter than maxOverlapSize

@18856317221 we can make this configurable - either use words, sentences, lines or paragraphs for calculating overlap.


How to convert this smart plug Aunics IT

On the website https://templates.blakadder.com/aunics_it.html I found the template, but unfortunately I can't flash this socket.
I have tried several times without success
I attach the logs of tuya-converter!
Can anyone help me?
root@raspberrypi:/home/pi/Desktop/pacchetti/tuya-convert # ./start_flash.sh
tuya-convert v2.4.3
======================================================
TUYA-CONVERT

https://github.com/ct-Open-Source/tuya-convert
TUYA-CONVERT was developed by Michael Steigerwald from the IT security company VTRUST (https://www.vtrust.de/) in collaboration with the techjournalists Merlin Schumacher, Pina Merkert, Andrijan Moecker and Jan Mahn at c't Magazine. (https://www.ct.de/)

======================================================
PLEASE READ THIS CAREFULLY!
======================================================
TUYA-CONVERT creates a fake update server environment for ESP8266/85 based tuya devices. It enables you to backup your devices firmware and upload an alternative one (e.g. ESPEasy, Tasmota, Espurna) without the need to open the device and solder a serial connection (OTA, Over-the-air).
Please make sure that you understand the consequences of flashing an alternative firmware, since you might lose functionality!

Flashing an alternative firmware can cause unexpected device behavior and/or render the device unusable. Be aware that you do use this software at YOUR OWN RISK! Please acknowledge that VTRUST and c't Magazine (or Heise Medien GmbH & Co. KG) CAN NOT be held accountable for ANY DAMAGE or LOSS OF FUNCTIONALITY by typing yes + Enter

yes
Checking for network interface wlan0... Found.
Checking UDP port 53... Available.
Checking UDP port 67... Available.
Checking TCP port 80... Available.
Checking TCP port 443... Available.
Checking UDP port 6666... Available.
Checking UDP port 6667... Available.
Checking TCP port 1883... Available.
Checking TCP port 8886... Available.
sudo: ufw: comando non trovato
======================================================
  Starting AP in a screen....
  Starting web server in a screen
  Starting Mosquitto in a screen
  Starting PSK frontend in a screen
  Starting Tuya Discovery in a screen

======================================================

IMPORTANT
1. Connect any other device (a smartphone or something) to the WIFI vtrust-flash
   This step is IMPORTANT otherwise the smartconfig may not work!
2. Put your IoT device in autoconfig/smartconfig/pairing mode (LED will blink fast). This is usually done by pressing and holding the primary button of the device
   Make sure nothing else is plugged into your IoT device while attempting to flash.
3. Press ENTER to continue

======================================================
Starting smart config pairing procedure
Waiting for the device to install the intermediate firmware
Put device in EZ config mode (blinking fast)
Sending SSID                  vtrust-flash
Sending wifiPassword
Sending token                 00000000
Sending secret                0101
................
SmartConfig complete.
Resending SmartConfig Packets
.................
SmartConfig complete.
Resending SmartConfig Packets
.................
SmartConfig complete.
Resending SmartConfig Packets
................
SmartConfig complete.
Resending SmartConfig Packets
.................
SmartConfig complete.
Resending SmartConfig Packets
.................
SmartConfig complete.
Resending SmartConfig Packets
................
SmartConfig complete.
Resending SmartConfig Packets
.................
SmartConfig complete.
Resending SmartConfig Packets
.................
SmartConfig complete.
Resending SmartConfig Packets
................
SmartConfig complete.
Resending SmartConfig Packets
..............
Device did not appear with the intermediate firmware
Check the *.log files in the scripts folder
Do you want to try flashing another device? [y/N] N
======================================================
Cleaning up...
Closing AP
Exiting...

tuya-converter.log
smarthack-mqtt.log
smarthack-psk.log
smarthack-udp.log
smarthack-web.log
smarthack-wifi.log

Unfortunately, according to your psk log, you have a device with the latest patched firmware from Tuya. We do not currently have support for this firmware. Please follow #483 for more information.

doing some network diagnostics, I noticed that the udp 6668 port is open, can you try something?

You can use tuyapi to control the stock firmware locally, or you can open the device and flash third party firmware directly, these are your only options at this point.

@pex81 I have the same problem. Did you found a solution? Did you open the plug case to flash with a serial interface?
Thank you

flashed succesfully with 8.4.0, cannot be done over OTA 'cause comes shipped with the fixed tuya firmware, it has to be done soldering and flashing via serial.. it's a common tywe2s (esp8285 with 1Mb flash?) so it's easy.
you need to open it to do that (also easy, it has a light ammount of glue and 4 clips), almost no damage to be seen if done carefully.

@pigr8
can you provide more detail on how procede for flashing soldering serial adapter?
Thanks

If you open the plug you can see that the pins of the esp8285 are easily accessible and you can solder 4 wires onto the correct pins (just search tywe2s pinout on google and to find the correct ones: 3v3 gnd rx tx).. using a cheap serial usb adapter just connect the 4 wires and flash tasmota the common way (es: tasmotizer).. after that test the plug, desolder the wire and you can close everything up.
bare in mind that someone reported that there is a capacitor between rx and gnd pins, you should be able to easily remove it to be able to flash tasmota.
cheers


Several bugs in edit header

The pattern-set keyword validation doesn't happen if keywords are blank

The category select box isn't searchable and should be blank if there is no category meta.

Fixed


Pin dependencies

This PR contains the following updates:

Package
Type
Update
Change

actions/cache
action
pinDigest
-> e12d46a

actions/checkout
action
pinDigest
-> f43a0e5

actions/setup-node
action
pinDigest
-> 1a4442c

actions/upload-artifact
action
pinDigest
-> a8a3f3a

dawidd6/action-download-artifact
action
pinDigest
-> 2686771

peter-evans/create-or-update-comment
action
pinDigest
-> 67dcc54

peter-evans/find-comment
action
pinDigest
-> a54c31d

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

🦙 MegaLinter status: ✅ SUCCESS

Descriptor
Linter
Files
Fixed
Errors
Elapsed time

✅ COPYPASTE
jscpd
yes

no
1.13s

✅ CSS
stylelint
1
0
0
1.46s

✅ JAVASCRIPT
standard
1
0
0
1.57s

✅ JSON
eslint-plugin-jsonc
3
0
0
3.44s

✅ JSON
npm-package-json-lint
yes

no
0.54s

✅ JSON
prettier
3
0
0
0.44s

✅ JSON
v8r
3

0
7.88s

✅ MARKDOWN
markdownlint
8
0
0
0.54s

✅ MARKDOWN
markdown-link-check
8

0
2.39s

✅ MARKDOWN
markdown-table-formatter
8
0
0
0.36s

✅ REPOSITORY
gitleaks
yes

no
0.11s

✅ REPOSITORY
git_diff
yes

no
0.01s

✅ REPOSITORY
grype
yes

no
9.37s

✅ REPOSITORY
secretlint
yes

no
1.34s

✅ REPOSITORY
trivy
yes

no
6.34s

✅ REPOSITORY
trivy-sbom
yes

no
2.5s

✅ YAML
prettier
3
1
0
0.72s

✅ YAML
v8r
3

0
5.45s

See detailed report in MegaLinter reports
MegaLinter is graciously provided by

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


(SRCommon) Add CMake option for resource embedding.

Right now build fails if SRCommon is used in projects other than SREngine.

Closed by 307f224.


macOS support

Hi,
Are there any plans to add macOS support?

Why only for macos? :D Do you know how to use firebase with jvm and linux?

The plan for macOS support is waiting on someone to contribute it, it doesn't look like it would be that hard since its the same native SDK as iOS so maybe its as easy as adding a macosX64 target pointing at the sources from the ios target? Maybe you can help!


"Card: unsupported configuration" when trying to use the Card after installing this new version

I had ui kitten working with the beta version and just updated it. It still works fine except when I try to use
     <Card>
        <Text>test</Text>
      </Card>

which throws ""Card: unsupported configuration". Since I may be one of the first users trying out the Card component I wonder if this is a bug.
fyi:
          <AppearanceProvider>
            <IconRegistry icons={EvaIconsPack} />
            <ApplicationProvider
              mapping={mapping}
              theme={colorScheme === "dark" ? darkTheme : lightTheme}
            >
              <View style={styles.container}>
                {Platform.OS === "ios" && <StatusBar barStyle="default" />}
                <AppNavigator theme={colorScheme} />
              </View>
            </ApplicationProvider>
          </AppearanceProvider>

Remove your package.lock and start with clearing cache
rm -rf ./package.lock ./node_modules && npm I && npm start --reset-cache

Similar issues: #662 #650

That worked - thanks for the quick response. In my case I used yarn so
rm -rf ./yarn.lock ./node_modules && yarn && npm start --reset-cache


regenerate site/install.sh after release

We unfortunately overridded goreleaser naming conventions formerly like this:
archives:
  - name_template: "getenvoy_{{ .Version }}_{{ .Os }}_{{ .Arch }}"
    replacements:
      darwin: Darwin
      linux: Linux
      amd64: x86_64

This is distracting and busy work especially as we add new platforms. We now release defaults (which naturally map to docker platform and our json schema).
After we release current master, we need to regenerate and push site/install.sh to catch the naming convention updates.
Ex. using latest commit of https://github.com/goreleaser/godownloader
./godownloader --repo=tetratelabs/getenvoy  .goreleaser.yaml  > site/install.sh

https://github.com/tetratelabs/getenvoy/pull/240 is ready with the fix


Fix merge problem

@kkl18 @SylviaCHS
Hi, Kim and Sylvia! I think I've fixed the merge problem. Now we have a new branch called "zl187/fix_merge" that would be able to merge into "master" and other branches or servers as a merge base. The merge problems should be solved if we start from this branch. All the commites after the "revert" have been saved, too. Sorry again that I've accidentally merged a branch into master, and reverted it, causing this merge problem. Let me know if there's other merge problems.

@kkl18 @SylviaCHS
Also, I think we have all codes of the latest version in "zl187/fix_merge" right now.


fix: scopemanager initialization in test

The implementation created an instance of AsyncHooksScopeManager in a test.
All other tests depend on this instance to exist which makes them non-idempotent (the order of test execution should not matter).
This change simply creates a new instance of AsyncHooksScopeManager in beforeEach() which has also the benefit, that each test operates on a fresh scopeManager eliminating potential side effects.

Codecov Report

Merging #179 into master will increase coverage by 0.24%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #179      +/-   ##
=========================================
+ Coverage   92.65%   92.9%   +0.24%
=========================================
  Files          50      50
  Lines        1471    1493      +22
  Branches       99      99
=========================================
+ Hits         1363    1387      +24
+ Misses        108     106       -2

Impacted Files
Coverage Δ

...oks/test/asynchooks/AsyncHooksScopeManager.test.ts
100% <100%> (ø)
:arrow_up:

...ry-scope-async-hooks/src/AsyncHooksScopeManager.ts
100% <0%> (+5%)
:arrow_up:


chore(ui): add initialOptions prop in tag suggestion component

Describe your changes:

I worked on adding initialOptions prop in the tag suggestion component so that it can render the initial values options with proper styling and label.

Type of change:

[x] Improvement

Checklist:

[x] I have read the CONTRIBUTING document.
[ ] My PR title is Fixes <issue-number>: <short explanation>
[ ] I have commented on my code, particularly in hard-to-understand areas.
[ ] For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@chirag-madlani, I have addressed the comments, can you re-review them?


type 'Null' is not a subtype of type 'int' in type cast when using enum column

When updating an enum value to null, it throws type 'Null' is not a subtype of type 'int' in type cast even though the column is marked as nullable
Defined an enum column like below
IntColumn get someEnumColumn => intEnum<SomeEnum>().nullable()();
Below is my update query
(update(someTable)..where((tbl) => tbl.id.equals(id))).write(
        SomeTableCompanion(
            someEnumColumn: Value(null)));

When update query executes, it throws exception on below line.
package:moor/src/runtime/types/custom_type.dart:39:38
@override
  int? mapToSql(T? value) {
    return (value as dynamic)?.index as int;
  }:

Changing (value as dynamic)?.index as int to (value as dynamic)?.index as int? fixes the issue but these changes are lost after flutter clean or pub get.

Thanks for the report, I've fixed this in c40c588f7a6c3ae267bffe44e2f601b226981b27.


#silence! does't silence across multiple threads

Doesn't work as intended :(

fixed in https://github.com/rwz/l2meter/commit/e5589db948c02d6d7f77d3573e033e42d74358db


fix(docs): filed -> field

The CLI uses "field": https://github.com/napi-rs/napi-rs/blob/main/cli/src/commands/new.ts#L61, not "filed".

Thanks!


Write mode

I like it! :+1:
I am not sure about LoadData module. It could be inlined into Dataset as reload and load_data_from_file are used privately. Otherwise the code is hard to follow.

Would be nice to reuse the logic from Memory::Dataset. If inheritance no longer works we could extract it into a shared module.

Awesome work :) I've got a couple of general comments:

we need to know the header - I'd say if you want to write to csv files then you should provide the header upfront and the adapter won't have to try to be smart and infer it from the first tuple. It would also eliminate the need to mutate dataset via add_header
since it adds an overhead of reloading data when re-reading (ie see to_a) then I'd say we should have 2 types of dataset - read and read/write - this could be done in a separate PR though, I'm OK with merging this one in first to avoid a long-lasting PR and risking a burnout :)
I'd double check if maybe there's a way to reduce mutability of the dataset to the minimum

@solnic Memory::Dataset doesn't work in this case. I created new dataset because:

I must remember path
I must have way to reload data

some of Memory::Dataset methods like find_all, have magic word "return" which return filtered set instead of dataset wrapper.

removed add_header, but I am not sure that we shouldn't have way to modify headers. When csv headers are different than our class attributes.

if you have more suggestion what can be changed in this code let me know.

I have just changed data.select! to @data = data.select. Is it ok or not ?

Let me tweak stuff in ROM so that this adapter can leverage existing features. There's too much duplication between the new dataset and memory dataset. I'm also not sure if it's a good idea to make dataset responsible for dealing with the source file. Maybe it would be better to move this to commands. I'll get back to you as soon as stuff on ROM side is ready. Hopefully tomorrow.

Ok

OK you should be able to subclass ROM::Memory::Dataset and add :path option now:
class Dataset < ROM::Memory::Dataset
  option :path, reader: true

  def reload!
    @data = load_data
  end

  def sync!
    write_data and reload!
  end
end

I hope this helps

Just a quick update that I haven't forgotten about this one. It's just very low (unfortunately) on my list and I've been too busy with other rom-* stuff. Also, I believe it's a non-trivial thing to solve at the end of the day. I'll do my best to go through this PR ASAP and merge it in.

@wafcio starting from ROM 0.8.0 all commands have access to source relation, this means if you do rom.command(:users).update.by_id(1) then this command will know both its restricted relation and the source one (which is the whole users relation). It should allow adapters like csv to update things properly.

ok, I must take breath from coding after hours. I will probably back to this PR on Thursday or weekend.

@solnic updated

It's merged :)


Make everything work with Raspbian Jessie Lite

...also incorporate some upstream changes/improvements from geerlingguy.php, geerlingguy.ntp, and other roles that have seen some significant improvements.
Finally, check in changes/improvements from Drupal Pi.

Working on everything from the perspective of a Debian install running locally with Vagrant/VirtualBox right now... another commit incoming, will need to figure out why NFS isn't working correctly though.

Running some final tests.

#65 is the main follow-up here.


[h2o benchmark] Infrastructure to automate running h2o benchmarks and product a report with results

Goal
Create an automated way (e.g. GitHub actions workflow) we can run the h2o benchmarks.
Requirements
We'll want to run these benchmarks against:

The main branch of dask and distributed
A specific release of dask and distributed when testing a Coiled distribution release

xref https://github.com/coiled/coiled-distribution/pull/5

Closed via https://github.com/coiled/coiled-runtime/pull/5


Flexible relations based on non-ID properties

another thing i think need, define custom property from source and target to realtion, example :
@Entity
public class Customer {
    @Id private Long id;
    private String tag;

    @Backlink(joinProperties = {
        @JoinProperty(name = "tag", referencedName = "customerTag")
    })
    private ToMany<Order> orders;
}

@Entity
public class Order {
    @Id private Long id;
    private String customerTag;
}

@greenrobot yw, it feature can be related with #150 i think #150 can be closed


Feedback

Please leave feedback in this thread.

This addon is great!
A bug I found:

nodes won't update if files are renamed/deleted

Awesome to hear you like it :)
I will check this when I have some time ;)

Hello,
I updated the project with a fix for files move and delete. Thanks for the report!
As a bonus you can now also drag and drop multiple files at once.
If you update, be careful to not overwrite your addons/project_map/project_map.tscn, because it is here your graph is saved.
In the new version, it will be saved as project_map_save.tscn, so there will be no risk of overwrite.
Please tell me if you encounter any issue ;)

Great addon! Thanks

I would love to see a undo and redo feature :)

And the possibility to add folders. 👌

Ant the layering (of groups) should get improved/added

Hello, thanks for your feedback!
I will check if I can create an undo/redo feature, can't promise anything though, but this is something I would like to add.
So, for the folder links, how would it work? You would drag a folder on the map and then when you click on it it would open it in the Godot file system or open it in the OS filesystem? I can try to implement something.
What improvement would you suggest for the groups?

Just shift every clicked node to the highest layer.
I also thought about the folder link. It should just select the folder in the directory tree and scroll to it. In Godot there actually already is a „show me the file or folder in the Godot files system“-functionality.

New version 1.3 released with directory nodes, comment nodes, undo/redo and improved group handling.

the addon is awesome... think I found a bug though.  when making changes the current scene tab is updated with "()" signaling it's unsaved.  and of course "saving" that scene will not remove the () as it didn't actually change... it was of course project_map_save.tscn that actually changed and isn't even open in the normal scene editor.
I'm running godot v3.3.1.

Thank you for the report!
I'm using the built-in undo/redo system of the editor, so it seems Godot attached the actions to the currently open scene and mark it as modified. I don't see an option to not have the actions attached to the scene, unfortunately.
The way to solve this would be to code my own undo/redo system, but I'm not sure it's worth it, as I don't see any ill side-effect.

Great idea. Thanks 4 sharing. I just can't move the groups around after being drawn. It seems mandatory to organize the map.

You move the groups (and the other nodes) by dragging the icon.
Normally after installation, there is a text node in the project map with the explanation, did you get it?

Oh yeah, my fault, it works with the icon. Sorry, I expected it to be movable with dragging on every point on the whole body! Maybe just like the move tool in 2d tab or maybe because of the other UI's I've been using recently. So I was checking specially on the borders, and I was so far away from explanation when doing that!

Oh yeah, my fault, it works with the icon. Sorry, I expected it to be movable with dragging on every point on the whole body! Maybe just like the move tool in 2d tab or maybe because of the other UI's I've been using recently. So I was checking specially on the borders! and I was so far away from explanation when doing that!!

Oh yeah, my fault, it works with the icon! Idk why expected it to be movable with dragging on every point on the whole body! Maybe just like the move tool in 2d tab or maybe because of the other UI's I've been using recently. So I was checking specially on the borders, and I was so far away from explanation when doing that!
Sorry, Now I’m deleting my comments to clean up this thread.

I would like it very much if I could change the CTRL + SPACEBAR hotkey to another one, or to change the default hotkey. The reason is, in the code, to get autocompletion, you use this hotkey. So your plugin renders unusable that way... :(

hello, thanks for the feedback :)
You can simply edit the shortcut in the file "addons/project_map/plugin.gd" to something that suits you more.
I didn't thought about auto-completion, what shortcut would you suggest?

I don't know, maybe CTRL + M, for Map, or CTRL + P, for Project, as it is easier to remember, but I have to check if they're already in use

Great project!
Would love to see the ability to delete with the backspace button and not just the actual delete button
#MacBookGang

Awesome plugin! Such a better way of visualizing the pieces of a project. Would love if "sub groups" were a thing. I.e. if I have a group node within a group node, when dragging the outer group node the inner one should move with it.

Hello all, thank you for all the feedback, but for now I am not interested in actively developing it further, I put it in "maintenance mode", so I will only do critical bug fixes.
Feel free to branch the plugin and create your own version, it's open source.


v1.5.0 roadmap

The main goals of v1.5.0 are:

Make templates portable and independent of the processing side: Oracle or client.
Adapt Oracle code to easy import/work with templates originally written for the client-side with no extra effort.
Integrate FTLDB with the upcoming plugin for SQL Developer.

The high-level changes regarding these goals are:

Consider client-side templates as Java resources. Use a new template loader for them instead of original FileTemplateLoader, which has some limitations.
Make it possible in Oracle to load templates from JAVA RESOURCE objects.
Introduce a new name format for client-side templates, which can be used on both sides.
Create a new API for the plugin.

I've already written something to pull templates from various sources.  But, it is in pure PL/SQL
The goal was to incorporate that API in the DAL.
Let me know what you think.
https://github.com/MikeKutz/oddgen-templates
MK


Green-line loads could be fetched in parallel with blue-line loads

When an LES page loads, it fetches the all-strategies-off (blue line) loads. Once received, the JavaScript then asks the server for the green-line loads.
Instead of executing these requests in series, both requests could be sent simultaneously. This would improve the responsiveness of the "show LES" page.
@grdw Do you think this is this doable with the current "show LES" page?

Good catch @antw and I like your suggestion!

This is not to big of change. I'll look into it!


Project Settings

To set project, repository, branch settings in order to organize convenient work. Describe rules of interaction with the repository

https://github.com/DecentralizedPrimates/DecentralizedTracker/wiki/Work-with-Branches


Segfault on parse error of bytes field

Error parsing bytes field 'value': Given value is not a multiple of 8 bits long
Error parsing sub-message for field 'fields'
Segmentation fault (core dumped)

Could not reproduce.
Might try again with bytes field in a sub-message, however i do not have a server available which exposes a datastructure like this.
maybe this is already fixed, as I changed the bytes field parsing code some time ago.

tested this against the testServer. Seems to be alteady fixed in latest version.


add a utility function for creating a ResourceGroup CR

We need a utility function to create a *unstructured.Unstructured for a ResourceGroup object. It accepts three argument name, namespace, inventory-id and returns a Unstructured. This function is needed for both kpt and ConfigSync.

/assign Liujingfang1

/assign Liujingfang1


Duplicate components

I just followed the instructions at https://d3-stencil.dev/docs/dev/dev-intro.html
and got :
yarn run v1.22.4
$ stencil build --dev --watch --serve
[25:54.7]  @stencil/core v1.14.0
[25:57.2]  build, d3-stencil, dev mode, started ...
[25:57.2]  transpile started ...
[25:58.3]  transpile finished in 1.05 s

[ ERROR ]  Component Tag Name "bcg-matrix-chart" Must Be Unique
           Please update the components so "bcg-matrix-chart" is only used once:
           ./dist/collection/components/bcg-matrix-chart/bcg-matrix-chart.js
           ./src/components/bcg-matrix-chart/bcg-matrix-chart.tsx

[ ERROR ]  Component Tag Name "horizontal-bar-chart" Must Be Unique
           Please update the components so "horizontal-bar-chart" is only used once:
           ./dist/collection/components/horizontal-bar-chart/horizontal-bar-chart.js
           ./src/components/horizontal-bar-chart/horizontal-bar-chart.tsx

[ ERROR ]  Component Tag Name "legend-chart" Must Be Unique
           Please update the components so "legend-chart" is only used once:
           ./dist/collection/components/legend-chart/legend-chart.js ./src/components/legend-chart/legend-chart.tsx

[ ERROR ]  Component Tag Name "line-annotations-chart" Must Be Unique
           Please update the components so "line-annotations-chart" is only used once:
           ./dist/collection/components/line-annotations-chart/line-annotations-chart.js
           ./src/components/line-annotations-chart/line-annotations-chart.tsx

[ ERROR ]  Component Tag Name "line-chart" Must Be Unique
           Please update the components so "line-chart" is only used once:
           ./dist/collection/components/line-chart/line-chart.js ./src/components/line-chart/line-chart.tsx

[ ERROR ]  Component Tag Name "pie-chart" Must Be Unique
           Please update the components so "pie-chart" is only used once:
           ./dist/collection/components/pie-chart/pie-chart.js ./src/components/pie-chart/pie-chart.tsx

[ ERROR ]  Component Tag Name "tooltip-chart" Must Be Unique
           Please update the components so "tooltip-chart" is only used once:
           ./dist/collection/components/tooltip-chart/tooltip-chart.js ./src/components/tooltip-chart/tooltip-chart.tsx

[25:58.3]  build failed, watching for changes... in 1.10 s

[25:58.3]  http://localhost:3333/

and the same on the page http://localhost:3333/
What's wrong ?
I'm new to stencil, but I know D3 ...
Thanks

seems related Stencil version > 1.9 on Windows (see https://github.com/ionic-team/stencil/issues/2319 )

Confirmed : does not happen with "@stencil/core": "1.9.2"
Seems to be a stencil problem on Windows, but any idea to circumvent this is welcome ...


[SPARK-44187][INFA][BUILD] Enable benchmark on github to support Java 21

What changes were proposed in this pull request?
The pr aims to enable benchmark on github to support Java 21.
Why are the changes needed?
To be ready for Java 21.
Does this PR introduce any user-facing change?
No.
How was this patch tested?

Pass GA.
Manually test.

cc @dongjoon-hyun @LuciferYang
A benchmark based on Java21 ran successfully
https://github.com/panbingkun/spark/actions/runs/5375142025


Jdmin access for BrowserStack app on Jenkins marketplace

Repository URL
https://github.com/jenkins-infra/repository-permissions-updater/issues/new?assignees=&labels=hosting-request&projects=&template=1-hosting-request.yml
New Repository Name
Admin access for BrowserStack app
Description
Hi team - I'm from BrowserStack's Strategic Partnerships team. We have an app listed on your marketplace but the admin who built it isn't part of the org now. Could you please provide details of the admin and how do I get added as one now?
GitHub users to have commit permission
@jenkin
Jenkins project users to have release permission
@jenkins
Issue tracker
GitHub issues

Security audit, information and commands
The security team is auditing all the hosting requests, to ensure a better security by default.
This message informs you that a Jenkins Security Scan was triggered on your repository.
It takes ~10 minutes to complete.
Commands
The bot will parse all comments, and it will check if any line start with a command.
Security team only:

/audit-ok => the audit is complete, the hosting can continue :tada:.
/audit-skip => the audit is not necessary, the hosting can continue :tada:.
/audit-findings => the audit reveals some issues that require corrections :pencil2:.

Anyone:

/request-security-scan => the findings from the Jenkins Security Scan were corrected, this command will re-scan your repository :mag:.
/audit-review => the findings from the audit were corrected, this command will ping the security team to review the findings :eyes:.
	It's only applicable when the previous audit required changes.

Only one command can be requested per comment.

(automatically generated message, version: 1.26.21)

@Mitesh-07 Sorry, I think you mentioned me accidentally.

The Jenkins Security Scan did not find anything dangerous with your plugin, congratulations! :tada:

:bulb: The Security team recommends that you are setting up the scan in your repository by following our guide.

Please look at the readme how upload permissions are managed and create a PR accordingly modifying the permission file to manage upload permissions. Thanks!


trouble installing

I'm trying to install using a cmdline call to composer because otherwise too much stuff gets changed/breaks...
I've tried many variations of: composer require chrisbjr/api-guard: "~1.0"
( 1.0  1.0@dev  1.1.1   ~1@dev )
but nothing seems to give me anything but:
[InvalidArgumentException]
Could not find package  at any version for your minimum-stability (stable). Check the package spelling or your minimum-stability

I also changed y root composer.json to require dev
to no avail

I really want to use your package -- what should I do ?

the InvalidArgumentException was because I had a space between the : and the version info


Commit message in {{commit.message}} contains "\n\n"

Subject. How I can remove "\n\n" characters ? Thank you.

Example:
{{#success build.status}}
        [#{{build.number}}] The build was successfull. All services were deployed.

Branch: {{commit.Branch}}

Message: {{commit.Message}}

SHA: ${DRONE_COMMIT_SHA:0:8}

Author: {{commit.Author}}

Elapsed: {{buildtime build.started}}

      {{else}}
        [#{{build.number}}] Build failed.

Branch: {{commit.Branch}}

Message: {{commit.Message}}

SHA: ${DRONE_COMMIT_SHA:0:8}

Author: {{commit.Author}}

Elapsed: {{buildtime build.started}}

      {{/success}}

And in telegram I have:


Reissue TDD based on prod deployment changes since Nov 2021

update and include readme.md changes
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/blob/main/Technical Design Document_Canada PBMM Landing Zone_20220211.1.pdf

see https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/issues/162

20240406: Closing issue during retrofit/rebase of this TEF V1 based/modified repo to TEF V4 standards
This issue may participate in the LZ refactor after rebase
Query on all issues related to the older V1 version via the tag
https://github.com/GoogleCloudPlatform/pbmm-on-gcp-onboarding/labels/2024-pre-tef-v4


always use (({a}>{b})?{a}:{b}) for cstyle max

fix max not defined for dtypes like uint8.

fyi you can also remove this diff's changes #5840

it's kinda dumb if a and b are computed twice, maybe we just rewrite max to lt and where

Really the transcendental thing should be made more generic, and if there's no BinaryOps.MAX it uses the rewrite rule

will at least make is a rewrite rule like #6162


Performance Enhancements

ToDo: Increase arithmetic speed by using high performance algorithms for polynomial multiplication and division.

Hello Saiedhk, I'm working on a project that calculate GCD of two polynomials in GF(2^m). Can you give a polynomial sample with your library for Galois Field? I found that sample_apps in this library are all about  gfelement.


onPress in ListView require different syntax from onPress outside ListView

Hi so when I use ListView and add a TouchableHighlight in it, as following:
<ListView
                  dataSource={this.state.dataSource}
                  renderRow={(rowData) =>
                    <View style = {styles.container}>
                      <TouchableHighlight
                      style = {styles.container}
                      onPress={()=>this._onPressSingleRequest(rowData)}>

why do I have to write ()=>this._onPressSingleRequest(rowData) in the onPress?  In my other view where the TouchableHighlight is not in a ListView, I can just use this._onPressSingleRequest(rowData), is this an issue or is there a reason for this?
Thanks!

you mean
()=>this._onPressSingleRequest(rowData)

VS
this._onPressSingleRequest(rowData)

?
the first one is a callback that will call your onPressSingleRequest, the second one is calling directly that onPressSingleRequest, so if you give this to onPress, it is directly called at render() time which is probably not what you want.

Also you can rewrite:
()=>this._onPressSingleRequest(rowData)

into
this._onPressSingleRequest.bind(this, rowData)

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/bind?redirectlocale=en-US&redirectslug=JavaScript%2FReference%2FGlobal_Objects%2FFunction%2Fbind

@gre is 100% correct :)

@gre thanks a bunch!

@gre I guess my follow up question would be why does sometimes
()=>this._onPressSingleRequest(rowData)

works and sometimes
this._onPressSingleRequest(rowData)

works?

Please show example where the second works
Le 24 oct. 2015 04:04, "Kevin Zhao"<EMAIL_ADDRESS>a écrit :

@gre https://github.com/gre I guess my follow up question would be why
does sometimes
()=>this._onPressSingleRequest(rowData)
works and sometimes
this._onPressSingleRequest(rowData)
works?
—
Reply to this email directly or view it on GitHub
https://github.com/facebook/react-native/issues/3619#issuecomment-150737596
.

@kevindeleon https://babeljs.io/docs/learn-es2015/

@gre here it is in this link: https://github.com/facebook/react-native/blob/62e8ddc20561a39c3c839ab9f83c95493df117c0/Examples/UIExplorer/PushNotificationIOSExample.js
var Button = React.createClass({
  render: function() {
    return (
      <TouchableHighlight
        underlayColor={'white'}
        style={styles.button}
        onPress={this.props.onPress}>
        <Text style={styles.buttonLabel}>
          {this.props.label}
        </Text>
      </TouchableHighlight>
    );
  }
});

In your example, there are nothing related to your snippet.
onPress={ this._sendNotification } works but onPress={ this._sendNotification(something) } wouldn't..
you need to think in term of types. this._sendNotification is a function. this._sendNotification(something) is not a function, it is the result of calling the function which is undefined in this case.
I recommend you to learn a bit more JS, the concept of closure, functions, etc..
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Closures

Ah I see! Thank you so much! I do need to learn more JS, it's something I
need to do ASAP
On Sunday, October 25, 2015, Gaëtan Renaudeau<EMAIL_ADDRESS>wrote:

In your example, there are nothing related to your snippet.
onPress={ this._sendNotification } works but onPress={
this._sendNotification(something) } wouldn't..
you need to think in term of types. this._sendNotification is a function.
this._sendNotification(something) is not a function, it is the result
of calling the function which is undefined in this case.
I recommend you to learn a bit more JS, the concept of closure, functions,
etc..
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Closures
—
Reply to this email directly or view it on GitHub
https://github.com/facebook/react-native/issues/3619#issuecomment-150897997
.

--
Kevin Zhao | LinkedIn http://www.linkedin.com/in/kevinzhaouva | Personal
Blog https://medium.com/@kevinzhao | Github
https://github.com/kevinzzz007
(434) 282-5369
Computer Science and Information Technology | University of Virginia 2016
Alpha Kappa Psi Professional Business Fraternity
http://www.akpsiatuva.org/

@gre thanks a lot sir.. I am new to react native.

@chetankotkar @gre yep this post continues to be important in react native lists. Just ran into the same issue. Thanks to  @kevinzzz007 for bringing up this important issue. I just spent an hour tangling with an alert box going up for every element in my FlatList. So this also is factor with new list types.

and add my own. Both works:
<Button title="signUp" onPress={() => {
debugger;
if (this.state.isSignUping)
return this._SignUp.bind(this)()
else
this.setState({ isSignUping: true })
}} />
and second:

maybe this will be helped to someone...


Faster slab reassignment

Sometimes the slab reassignment mechanism gets stuck on busy items.
We have found as workloads scale and
applications use increasing amounts of memory, the current
reassignment mechanism in memcached is inefficient. In fact,
we measure that reassignments can take millions of requests
to complete a single reassignment.
Motivated by these findings, we introduce a faster slab re-
assignment mechanism. In our experiments, we show that the
time needed to reassign a slab reduces by over 99% resulting
in the ability to reach workloads’ steady state miss ratio by
53% to 75% faster.
See the attached figures for a sample experiment using a workload that introduces a change to the item size distribution.
p2-2app-100-25.384.alloc.speed.both.pdf
p2-2app-100-25.384.speed.mr.both.pdf

Neat, thanks! Looks like it doesn't compile though.
Been meaning to optimize this for a long time but never had a complaint/time/motivation :) Fair warning though; validating these sorts of changes for merge is pretty effort intensive so the PR could sit for a while before being merged.

(and if you're curious; the torture suites are here: https://github.com/memcached/mc-crusher) under conf/ + slab-tosser scripts. I'll probably just write a test suite similar to the files under test-suites and let it run for a week.
While developing the feature initially those suites found a handful of obscure crashes/corruptions, sometimes after running for hours.

Fixed the compilation issue. Currently, this PR doesn't include chunked objects. I am running the tests on my setup here too.

Ok. Please let me know when it's feature complete, I guess :) More tests are appreciated. Looks like you're already developing against the 'next' branch, which is perfect since some slab reassign changes are queued in there.

Okay, I added chunk support. Still running tests on my end no issues so far.

Have been running the mc-crusher all last week. No issues on my end and it
passes all tests.
Take a closer look, I’d love to see this in the next release.
On Tue, Aug 27, 2019 at 17:33 dormando<EMAIL_ADDRESS>wrote:

How goes? I notice this doesn't add to or adjust any specific unit tests.
Waiting for a direct note from you on if it's ready for a closer look.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/memcached/memcached/pull/524?email_source=notifications&email_token=AAJER2R7MTS7E4HR4N5US5LQGWMSNA5CNFSM4IMMNY6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5JF4TI#issuecomment-525491789,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJER2TPBATYUETWVERJL3LQGWMSNANCNFSM4IMMNY6A
.

Thanks for taking a closer look at this.

I see you only changed code for the cases of the rebalancer wanting to
move memory but without saving the item

This was this case that was slowing down the slab reassignment the most,
since the *wasBusy *counter would be incremented causing the slab
rebalancer to sleep (1000ms).

I believe both of those cases are atypical for most workloads, or they're
supposed to be anyway. Do you have more context for the test you made?

In our environment, memcached reassigns slabs across multiple classes. When
we are removing slabs from one class to another, it is almost always the
case that the class which we are removing slabs from is already full. We
are often under tight memory bounds (~4GB). The workload used to test this
is a synthetic workload based on access patterns from Facebook and other
web caches. Zipfian (alpha=1-0.25) and about 10 million unique objects.

(1) Your change seems to guard against refcount not actually reaching zero

I introduced this to make sure there were no outstanding references to the
item in other threads before
we unlink and free. If this is mistaken, let me know and I'll take care of
it.

(2) it looks like I could just (after unlink) lock the slabber, call
do_slabs_free() and then immediately _cut_free() and unlock

That is all that I am trying to do :)

(3) I figured the big speedup here would be using a bit vector to mark
completed chunk offsets so we stop flipping the locks around and re-looking
at every item when revisiting. Was that also part of your change?

Once we cut it from the freelist, we could mark the offset, skip it and
move on to the next item? I believe that would speed things up too. Again,
the biggest problem we ran into was having to wait after every *busy item *in
case (2) that you mentioned.

(4) Unfortunately there was an actual reason why I let the slab lock go
for the duration of that MOVE_FROM_LRU code

I did not have any measurable drop in latency or throughput in my test
setup. We use mutilate and run the workload through there. I'll try running
through mc-crusher too.
Thinking about it now, we should only need to lock from do_slabs_free to
cut_from_freelist since reference count would go from >1 to >=1.
If you think its worth the time, I'll take some time to implement the bit
vector to check for chunks that have already been cut from the freelist.
Second, I can tighten the locks by being more precise with the reference
count and possibly clean up re: your Q1
On Wed, Aug 28, 2019 at 2:41 AM dormando<EMAIL_ADDRESS>wrote:

Took a more careful read on this. Just for a sanity check; is this missing
any code? I see you only changed code for the cases of the rebalancer
wanting to move memory but without saving the item, ie; item is expired or
there was zero slab memory left to allocate a replacement chunk. I believe
both of those cases are atypical for most workloads, or they're supposed to
be anyway. Do you have more context for the test you made?
Couple other topics:

When under MOVE_FROM_LRU there's an exclusive lock on the item and
the item lock is held. Your change seems to guard against refcount not
actually reaching zero, but that should be impossible here unless I
goofed something pretty terrible. The code you removed is blindly sending
the memory back to the slabber, even.
2.
I can't figure out why I wrote it that way to begin with :) I may
still be missing something (it's late and I'm tired) but it looks like I
could just (after unlink) lock the slabber, call do_slabs_free() and then
immediately _cut_free() and unlock.
3.
I figured the big speedup here would be using a bit vector to mark
completed chunk offsets so we stop flipping the locks around and re-looking
at every item when revisiting. Was that also part of your change? It's
something I planned a long time ago and simply never prioritized.
4.
Unfortunately there was an actual reason why I let the slab lock go
for the duration of that MOVE_FROM_LRU code.. Unlinking is a bit of
fiddling and there was a measurable drop in throughput + increase in
latency unless I kept the slab locks as short as possible. I can re-test
with my newer tooling but I do recall running into that while doing the
chunked items code.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/memcached/memcached/pull/524?email_source=notifications&email_token=AAJER2W6E7SC2MSLVEMWJRDQGYMYRA5CNFSM4IMMNY6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5KBYMI#issuecomment-525605937,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJER2UIJF5SKR5B4XQFZRTQGYMYRANCNFSM4IMMNY6A
.

Thanks. Was on vacation will get back to this as I catch up this week. As an note, I confused the usleep with 1000ms rather than 1000us.

At every step I've written this thing super conservatively; don't hammer the locks, sleep, retries, etc. The best generic speedup you'll get in the short term is a bit vector + changing the usleep to be a retry backoff (maxing out at 1ms). Usually the vast majority of a slab will quickly free, and in a pessimistic case where it has to unlink everything without a rescue it shouldn't sleep for the first try. A bit vector will protect from any hard-looping cases. (use it to count which chunk it's on, rather than remembering offsets for safety).

The retry backoff is a good solution, but it still fails to move the most amount of slabs/second. See the table below from our tests. CPU usage was measured when the slab rebalancer thread was active. The higher usage is a result of not waiting in usleep.

algorithm
sleep interval
cpu usage %
slabs/s

base
1
13.8
36.93

base
10
10.6
35.5

base
100
8.0
26.55

base
1000
3.1
4.12

fast
1000
97.0
252.31

Also, we still need to remove items from the slab's freelist right away if we are not going to rescue them. If we don't do this then we run into the problem of those slots getting realloc'd.
What I propose, is the following:

Immediately cut non-rescued items from the slab's freelist (I know this results in essentially random eviction, but a better solution may take more time). To get around the lock issue, only unlock the slabs lock if we pass the if (save_item). That avoids unlocking and relocking the slabs lock.
Add the retry backoff timer for the items which are busy.

Thanks for the update; I'll respond in detail when I can. You're right that your particular benchmark won't see as much improvement with my initial suggestions.. in most cases if memory needs to move from A to B there's a lessening pressure on A. Your test isn't like that.

So I might have a simplification... I think the entire slabs_free() bit in the original unlink code might be pointless after my recent patch to remove the mem_requested counter. All cut_free() does is make sure it's not linked in the freelist. slabs_free() used to maintain mem_requested, and the slab mover also had to adjust it a bit... but that's all gone now.
So in the non-rescue case after the unlink, the slab chunk is owned by the mover thread, not the linked list or the slabber...  so you can do the MOVE_FROM_SLAB routine and set refcount/flags and not tick was_busy. Just deleting the busy_items++, was_busy++, slabs_free() calls and adding an it_flags = ITEM_SLABBED|ITEM_FETCHED line should give you your original speedup?
From there we still need the vector and backoff to speed it up for the general use case.
... seem sane? unless I've misread something?

Oh, lost half my thought; if the item wasn't chunked, elide that code. If it was chunked we have a much more complicated free routine, so it should I'd be much happier just letting it loop as-is. The chunked item cases typically work with very large data (512k+, in the future cutting down to 128k or 256k or so) so having a fast retry time will cover that case pretty well as there're only 2-4 chunks in the entire slab.

Hi, I finally got around to making the changes. See #542 for the updated PR (I had to switch from my master branch to your next branch to start clean).

For posterity: #608 fixes a critical bug in this PR + a bug with the completed routine.


[BUG] Vertical lines are't working whith the Minimal Theme.

Describe the bug
Vertical lines are't working whith the Minimal Theme.
To Reproduce
Wen i start the Minimal Theme vertical lines immidiatly stop working (i can't clicking on them).
Desktop (please complete the following information):

Windows 11
Obsidian Version: 1.1.9
Minimal Theme 6.2.0

same issue. do you find any theme that is compatible with this vertical line feature? for me, it only works in the default theme, but those lines are all misaligned. I tried several themes such as topaz and things, but none of them worked (the lines are just not clickable). thanks.

You are correct, only the default theme is supported. Updated the disclaimer in the README.


Merge Config on register to avoid problems for existing applications

Since a new config called Widget was added, existing applications won't see the default widgets without republishing the config

Great thinking, thanks!


Plot.rectY not plotting bars

The following produces an empty chart.
import polars as pl
from pyobsplot import Plot

penguins = pl.read_csv("https://github.com/juba/pyobsplot/raw/main/doc/data/penguins.csv")

Plot.plot({
  "marks": [
    Plot.rectY(penguins, Plot.groupX({"y": "count"}, {"x": "species"})),
  ]
})

The following produces the chart as expected.
import polars as pl
from pyobsplot import Plot

penguins = pl.read_csv("https://github.com/juba/pyobsplot/raw/main/doc/data/penguins.csv")

Plot.plot({
  "marks": [
    Plot.barY(penguins, Plot.groupX({"y": "count"}, {"x": "species"})),
  ]
})

Using rectY works via the observable website.
https://observablehq.com/d/1536c13b55654b3e
Apologies if I'm missing something obvious!

No, you didn't miss anything, I think the issue came from the fact that the published pyobsplot  had an outdated Observable Plot version, and rectY has changed since.
I just published pyobsplot 0.4.2, I think it should solve the issue.


Add cuda support

Modules nn and LogisticRegression currently don't have cuda support.

WRT #32  closing this.


[skaffold] config to deploy with images from registry

Motivation
Rebuilding some images now leads to broken backend. While this has been fixed by #367, previous releases cannot be rebuilt correctly. However, images in registry are fine, so this only really impacts local usage of previous tags.
In order to run a previous version locally, instead of rebuilding the image, this PR introduce a new skaffold config file to run an arbitrary backend version.
How to use
Let's say you want to run version 0.1.3, you can execute from master (meaning there is no need to checkout a specific tag):
SUBSTRA_BACKEND_VERSION=0.1.3 skaffold -f skaffold-from-registry.yaml run

Caveat
⚠ Since the charts used are the one from the working directory, there might be incompatibilities with previous versions.
In that case a checkout of the appropriate tag would be necessary (but then the skaffold config would be missing).
This can be documented (checkout of the target revision + checkout of the specific skaffold config) but I'm not sure this is worth adding to the readme.
ℹ Here the backend is impacted but other components of the stack may face the same rebuild issue at some point. Besides, having a harmonized way to run specific tags throughout the stack is a better developer experience. So it might be desirable to implement the same strategy for other projects, what do you think?

For the chart, you can use the chartPath to use a helm hub like artifacthub.io. But it would also need to change or adapt the value file too !
Yes, the same strategy can be use for other repo like hlf-k8s !

For the chart, you can use the chartPath to use a helm hub like artifacthub.io. But it would also need to change or adapt the value file too !
Yes, the same strategy can be use for other repo like hlf-k8s !


Migration: Disable Notices that are not Systems Applicable

Is your feature request related to a specific problem?
Followup to: https://github.com/ethyca/fides/pull/4010
Disable privacy notices that are not applicable to at least one system
Describe the solution you'd like
A description of what you want to happen.
Describe alternatives you've considered, if any
A description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

testing

moving to done


Suggestion for yii\db\ActiveQuery, overridable finish() function

Recently I’ve met with the problem when I needed to apply some default filter to all queries for the given model, and it was solved quite easily
i.e always get active Products
class ProductQuery extends \yii\db\ActiveQuery
{
    public function init()
    {
        parent::init();
        $this->active(); // implementation is like $this->andWhere..
    }

    ...
}

But, assume that in some exceptional cases we need to fetch non-active Products too. In that case we cannot cancel the filters applied in init() stage, so I suppose that it would've been better if there'd been some "finish()" or "beforeExecute()" like method, that will be called right after anonymous Query function is executed.
So that:  (Only exemplary)
class ProductQuery extends \yii\db\ActiveQuery
{
    public $isActive = true;

    public function finish()
    {
        if($this->isActive) {
            $this->active;
        }
        parent::finish();
    }
    ...
}

.. and i.e. while finding Shops, we can want to fetch all Products (non-actives too)
$shops = Shop::find()
        ->joinWith(['products' => function(ProductQuery $query) {
            $query->isActive = false;
        }]);

and in other cases we always fetch active Product only
In fact, I could not find a way to apply filters in Queries, depending on values in their properties (assuming that we pass them in anonymous functions). Of cource, we could write those filters in each of the queries, however it becomes difficult to maintain as project grows.
Maybe there is a better solution (without even touching the source code), and my proposal is all wrong.. If so, I would be grateful, if anyone shows me how it's done. Thanks

Q
A

Yii version
2.0.6

PHP version
7.0

Operating system
windows

You can always call Query::where([]) to reset alredy applied search conditions like default scope.

But assuming that you have multiple where conditions, it will reset them all, and you will have to write them again in anonymous function

I would recommend to do that on AR level:
public static function find()
{
    return parent::find()->active();
}

public static function findUnrestricted()
{
    return parent::find();
}

and use findUnrestricted() or whatever you call it in the special cases that do not have the limitation to active records.

Yeah, this one will work when you call findUnrestricted() for the given model.
But when the model is used in relation and joined with with() or joinWith(), it will use standard find() method


12 adaption off learning unit endpoint to requirements from 250923

I merged that changes into the dev branch (from there I will also integrate them into main).
Thus, no direct merge into main needed.


Simplify CertificateSigningRequest conformance tests and add missing tests

Simplifies the definitions of the CertificateSigningRequest conformance tests and adds additional tests, matching tests that exist for the Certificate resources.
Kind
/kind cleanup
Release Note
NONE

I just don't see the point of spending any time on these tests.
I've always thought that it's misguided to run an E2E test for all these CR / CSR / Issuer / ClusterIssuer combinations.
It would be a better use of our time to write a new conformance test tool which could be used for both in-tree and external issuers, to verify which features they support and to verify that they don't fail with various edge case CR or CSR.

I don't think it is possible to write something new without first looking at what we already have (I also would not know how to explain to any reviewers that my new tests are able to replace all the existing tests).
In my opinion, we should iteratively improve these tests. First fix what we have and later replace what we have with something that we are confident in as a replacement, if required.

/test ?

/test pull-cert-manager-master-e2e-v1-30-bestpractice-install

/test pull-cert-manager-master-e2e-v1-30-feature-gates-disabled


Tiny: allow CaseExpression with operand and else clause

It does not make sense. What is the Sql expression tree you are constructing?

It's supported in SQL both by SQL Server (the "simple case expression") and PostgreSQL (again "simple form").
The specific translation where I could use this is to return a number, but to translate 0 into 7 (this actually happens in PostgreSQL when translating DayOfWeek which returns an enum). I could generate CASE value WHEN 0 THEN 7 ELSE value.


python310Packages.ha-ffmpeg: 3.0.2 -> 3.1.0

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 216859 run on x86_64-linux 1

13 packages built:

home-assistant-component-tests.canary
home-assistant-component-tests.ezviz
home-assistant-component-tests.ffmpeg
home-assistant-component-tests.homekit
home-assistant-component-tests.logi_circle
home-assistant-component-tests.nest
home-assistant-component-tests.onvif
home-assistant-component-tests.ring
home-assistant-component-tests.skybell
home-assistant-component-tests.tuya
home-assistant-component-tests.xiaomi
python310Packages.ha-ffmpeg
python311Packages.ha-ffmpeg

A commit message should always reflect what is done in the commit, so I
wonder why update meta is also a complete reformatting.
And when you noticed, that you introduced a mistake in meta.changelog,
why didn't you amend the previous commit and instead went for third one?

A commit message should always reflect what is done in the commit, so I wonder why update meta is also a complete reformatting.

"Complete reformatting" is a bit of a stretch...could the commit message be better, sure.

And when you noticed, that you introduced a mistake in meta.changelog, why didn't you amend the previous commit and instead went for a third one?

Because it saves time to do it that way. I added changelogs on a large scale after the past weeks and I really can't remember where I already added it and where not. Using GitHub to do it after a PR is created is simply the most efficient way for me to do it. It's inevitable that there are typos from time to time.

Also empty PR description, where at a minimum the changelog URL should be.

Adding meta.changelog was kind of the reason to prevent this in the future. We will then also have it for PRs created by r-ryantm.

"Complete reformatting" is a bit of a stretch...could the commit message be better, sure.

You also added format = "setuptools", and changed disabled to pythonOlder "3.7". All which should have been done in the bump.


gpt-runner-web build fails

Forked repository, cloned repo, changed directory and ran "pnpm install" but it fails the "postinstall: pnpm build" with an error.

It is the latest: 1.2.5 version I cloned.

Im on Ubuntu 22 @2214962083

git pull and run pnpm i again, the error reason is not in screenshot. can you give me the fullscreen shot

I was able to resolve the issue; it was on my end. I apologize.

no worry, feel free


Getting blank repo name every time when publishing to AWS Lambda

When I try to upload lambda function from visual studio, the image repo name always blank. I tried removing aws-lambda-tools-defaults.json and generated again, but the issue didn't resolve.
Expected behavior
The expected behavior should be, image repo name should not be blank after the first time upload.
Screenshots

Windows Version: Windows 10
Visual Studio Version: 2019 (16.10.2)
AWS Toolkit for Visual Studio Version: <IP_ADDRESS>

Out of curiosity, are you able to list the ECR repos from your account? I'm wondering if there are permissions preventing that dialog from listing the available repos. If you go to the AWS Explorer, expand "Amazon Elastic Container Service", then expand "Repositories", please let me know if this lists your repos.

@awschristou Yes, I have access to ECR repos. I have permission. I can also see the list in visual studio when I open the Image Repo dropdown list. My point is, should it not automatically pick the repo name? As repo name is stored in aws-lambda-tools-defaults.json after the first-time upload.

Thank you for reporting this @M-Imtiaz - I can confirm that I was able to reproduce this.

@awschristou VS 2019 latest AWS toolset / Win 10 x64. I too can confirm this behavior:

GUI opens and the repo is initially selected in the drop down.
A moment later and the repo name is cleared.
Must then manually select the repo from the drop down.

Not too big of a deal, but certainly annoying enough.


run DockerImage as Cassandra user

Is there an options to run container as Non-Root Users?  Setting the dockerImageRunsAsCassandra to true, makes the pod to crash while starting.

Starting Management API
cp: cannot create regular file '/etc/cassandra/cassandra-env.sh': Read-only file system
cp: cannot create regular file '/etc/cassandra/cassandra-rackdc.properties': Read-only file system
cp: cannot create regular file '/etc/cassandra/cassandra.yaml': Read-only file system
cp: cannot create regular file '/etc/cassandra/jvm.options': Read-only file system
cp: cannot create regular file '/etc/cassandra/logback.xml': Read-only file system

The Management API images run Cassandra as the cassandra user as of version 0.1.20. You should be able to specify the image used for Management API (I'd recommend v0.1.22) and then set dockerImageRunsAsCassandra as true.

Thank you for pointing to direct version, Still i am running into the same issue
Normal   Pulled                  28s                kubelet                  Successfully pulled image "datastax/cassandra-mgmtapi-3_11_10:v0.1.22" in 873.054888ms
Normal   Started                 27s                kubelet                  Started container server-system-logger
Normal   Pulled                  26s                kubelet                  Successfully pulled image "datastax/cassandra-mgmtapi-3_11_10:v0.1.22" in 901.242148ms
Normal   Pulled                  13s                kubelet                  Successfully pulled image "datastax/cassandra-mgmtapi-3_11_10:v0.1.22" in 833.577826ms
Normal   Pulling                 13s (x3 over 29s)  kubelet                  Pulling image "datastax/cassandra-mgmtapi-3_11_10:v0.1.22"
Normal   Created                 12s (x3 over 28s)  kubelet                  Created container cassandra
Warning  BackOff                 12s (x3 over 25s)  kubelet                  Back-off restarting failed container
Normal   Started                 12s (x3 over 28s)  kubelet                  Started container cassandra
➜  SBX git:(master) ✗ kubectl logs cluster1-dc1-default-sts-0 -n cass-operator --kubeconfig=$SBX_KC -c cassandra
Starting Management API
cp: cannot create regular file '/opt/cassandra/conf/cassandra-env.sh': Read-only file system
cp: cannot create regular file '/opt/cassandra/conf/cassandra-rackdc.properties': Read-only file system
cp: cannot create regular file '/opt/cassandra/conf/cassandra.yaml': Read-only file system
cp: cannot create regular file '/opt/cassandra/conf/jvm.options': Read-only file system
cp: cannot create regular file '/opt/cassandra/conf/logback.xml': Read-only file system
➜  SBX git:(master) ✗

Thank you, it was the PSP permission on the hostpath causing it. After mounting the volume it worked.


Change UnixListener to use IoSource

Depends on #1245.

Oh.. GitHub changed my commit message to "Merge all sys:🐚:uds files", but its Merge all sys::shell::uds files. Locally it uses the text.

I know this shouldn't really change much, but I'll give it a review when it's rebased after #1245 merges!

@kleimkuhler I've rebased this.


Downloads page not working properly

https://auroraoss.com/download/#aurora-store
The website doesn't appear to be working correctly. I see the following if i visit the webpage:

It's a known issue, will be fixed in next website build.


[v2 prep] visual examples for component consolidation

User story
After our team review of Content block and section, we need some visual examples to determine if we would like to merge the components together or keep them separated.
Additional information
Review notes

Content block
Content section

Figma

Audit Content block & section
WIP Component spacing + Wonil
Audit spacing
Margin spacing for Content block
CTA spacing in Content block
Nesting examples for Content group

Options to review

Content section absorbs Content block
Content block and Content section are kept separated

See v2 Component audit to see exploration. Team determined to move forward with combining Content section and Content block.


[FLINK-34345][runtime] Remove TaskExecutorManager related logic

What is the purpose of the change
FLINK-31449 removed DeclarativeSlotManager related logic. Some related classes should be removed as well after FLINK-31449, such as:

TaskExecutorManager
TaskExecutorManagerBuilder
TaskExecutorManagerTest
org.apache.flink.runtime.resourcemanager.slotmanager.TaskManagerRegistration
PendingTaskManagerSlot
TaskManagerSlotId
SlotStatusUpdateListener
TestingTaskManagerSlotInformation

Brief change log
[FLINK-34345][runtime] Remove TaskExecutorManager related logic

related to https://issues.apache.org/jira/browse/FLINK-31449

@RocMarshal @1996fanrui If you have time, can you help me review it? Thank you.

After I check, I think there are other classes can be removed as well, such as:
* TaskManagerRegistration

  * Note: It's `org.apache.flink.runtime.resourcemanager.slotmanager.TaskManagerRegistration`
  * `org.apache.flink.runtime.jobmaster.TaskManagerRegistration` cannot be removed.

* PendingTaskManagerSlot

* TaskManagerSlotId

* SlotStatusUpdateListener

* org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerConfigurationBuilder

* TestingTaskManagerSlotInformation

Please help double check these classes, and check is there other classes can be removed as well, thanks!

org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerConfigurationBuilder
I saw that some classes are used, are you sure to delete them?

org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerConfigurationBuilder
I saw that some classes are used, are you sure to delete them?

It seems my IDEA doesn't  index well. It's indeed  used.

Thank you for your review and patient reply

The master branch has been cut to 1.20, merging~


sudo required for iotedge commands

needed to do "sudo iotedge list" rather than "iotedge list" as indicated above.
Is there a way to add the user to a group so that they dont need to do sudo all the time like previously by adding the user to the docker group?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 57c035a2-9ca9-2bbf-f9db-263bb0411de8
Version Independent ID: aa0c1a42-7d19-996e-cd57-51c838f40677
Content: Simulate Azure IoT Edge on Linux
Content Source: articles/iot-edge/quickstart-linux.experimental.md
Service: iot-edge
GitHub Login: @kgremban
Microsoft Alias: kgremban

Thanks for the feedback! I have assigned the issue to the content author to evaluate and update as appropriate.


Trailing comma on example would causes Parse error

eslint js/behavior.js

Cannot read config file: /www/.eslintrc.json
Error: Unexpected token }
SyntaxError: Cannot read config file: /www/.eslintrc.json
Error: Unexpected token }
    at Object.parse (native)
    at loadJSONConfigFile (/usr/local/lib/node_modules/eslint/lib/config/config-file.js:117:21)
    at loadConfigFile (/usr/local/lib/node_modules/eslint/lib/config/config-file.js:210:26)
    at Object.load (/usr/local/lib/node_modules/eslint/lib/config/config-file.js:437:18)
    at loadConfig (/usr/local/lib/node_modules/eslint/lib/config.js:67:33)
    at getLocalConfig (/usr/local/lib/node_modules/eslint/lib/config.js:129:23)
    at Config.getConfig (/usr/local/lib/node_modules/eslint/lib/config.js:223:22)
    at processText (/usr/local/lib/node_modules/eslint/lib/cli-engine.js:155:27)
    at processFile (/usr/local/lib/node_modules/eslint/lib/cli-engine.js:227:18)
    at executeOnFile (/usr/local/lib/node_modules/eslint/lib/cli-engine.js:603:23)

Thanks for PR. Unfortunately, this file cannot be modified in this repository. It's automatically copied from main ESLint repository https://github.com/eslint/eslint at build time. So it has to be modified in main repository. Could you open a pull request there?

OK :)
Main repo doesn't have the trailing comma.

Ah.. I thought that I've seen a PR recently to fix it on the main repo, but wasn't 100% sure. Site is only updated when we do a release. So this will be fixed on the site with the next release.


Moved Notion doc to github for future reference

LGTM. Shall we move the docs to the root of the repo?

I was thinking this document is only needed by whoever setting up the node client. I can move it if you want though.

LGTM. Shall we move the docs to the root of the repo?

I was thinking this document is only needed by whoever setting up the node client. I can move it if you want though.

Like you said I was hesitating between /crates/arpa-node/docs and /docs , then I thought we should not expect users to have our understanding of directory structure. Our links elsewhere point to the root directory, thus placing the docs in the root directory is more direct and intuitive.


Segmentation fault (core dumped) in `nanopolish eventalign

Hello, I'm having trouble running the nanopolish subcommand nanopolish eventalign and reporting an error:
/usr/bin/bash: line 1: 762015 Segmentation fault      (core dumped)
 nanopolish eventalign --reads <my.fastq> --bam <my.bam> --genome  <my.fa>
 --signal-index --scale-events --summary <sequencing_summary.txt>  --threads 32 > result.tsv 2> <my>log

There seems to be no error in the previous indexing step,This is the last standard error output, in the index building phase.
The following four files were generated as expected  output.fastq.index, output.fastq.index.fai, output.fastq.fastq.index.gzi, and output.fastq.index.readdb
[readdb] num reads: 1420410, num reads with path to fast5: 1420410

$ nanopolish --version
nanopolish version 0.13.3
Written by Jared Simpson.

Copyright 2015-2017 Ontario Institute for Cancer Research

$ gcc --version
gcc (GCC) 8.4.1 20200928 (Red Hat 8.4.1-1)
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

My nanopolish is the latest version of Github Clone and auto-downloads dependencies and was compiled in default parameters.
Any helpful information would be appreciated.

The --summary option should not point to sequencing_summary.txt, this is an option to write an output file summarizing the eventalignment results, not an input file. Also, could you try without the --signal-index option  and see if you get thhe same  error?


colllge links in chapter section not directing to anywhere

Aren't the college links mentioned in the chapter page supposed to direct us to the specific college sites?
But these links are not generating any response.
I can address this issue if assigned under GSSOC'23.

We will soon be linking it, so don't need to link to their website


Add efr32 unit test to cloud builds

Cloudbuild pre-builds do not have efr32 unit tests in them.
Added them back both in smoke and all-builds.

Hotfix: third party integration that cannot be validated by CI (I did validate that restyle-diff shows now differences)


build issue with sed command

When fixing #36 I have encounter issue with build specifically sed command here https://github.com/skatejs/web-components/blob/master/webpack.config.js#L16 I'm not sure why it stopped working did resolve issue with following awkward fix
diff --git a/webpack.config.js b/webpack.config.js
index 083c495..07ada10 100644
--- a/webpack.config.js
+++ b/webpack.config.js
@@ -13,7 +13,7 @@ conf.plugins.push(new WebpackShellPlugin({
   onBuildStart: [
     // Escape all backtick characters so we can wrap it in a template literal.
     // eslint-disable-next-line
-    'sed -e "s/\\\`/\\\\\\\\\\`/g"<EMAIL_ADDRESS>> ./src/native-shim.js',
+    'sed -e \x27s/`/\\\\`/g\x27<EMAIL_ADDRESS>> ./src/native-shim.js',

     // Wrap in a conditional eval so it doesn't get executed in non-supported environments.
     'echo "window.customElements && eval(\\`$(cat ./src/native-shim.js)\\`);" > ./src/native-shim.js'

@treshugart can you please verify that it's working on your machine it's really strange that it's working on CI. If it's working for you let's close this issue.

Interesting. It was failing for me. I can't test right now, but if it works for you I'm happy for the fix to be applied and merged. If it's still not working we can take it from there.

yes beside awkwardness fix is working will send PR right away

Feel free to have @Hotell review it. I'm in bed soon :)


feature Support S3 tvf

Proposed changes
Issue Number: close #10217
pr Number: close #10214
This pr does three things：

Modified the framework of table-valued-function(tvf).
be support fetch_table_schema rpc.
Implemented S3(path, AK, SK, format) table-valued-function.

Problem summary

Modified the framework of table-valued-function(tvf).
Each implementation of tvf requires a new scan node in the old framework of pr #10214 . Actually, different scan nodes should correspond to different data sources. I modified the tvf framework so that it can generate different scan node according to data source of this tvf.
For example, the data of numbers(n,m) tvf is derived from memory, so it generate DataGenScanNode. And the data of s3(...) tvf is derived from S3 Storage, so it generate ExternalFileScanNode.

be support fetch_table_schema rpc.
There is no table schema in s3() advance, so we need fetch_table_schema rpc to parse table schema from file in S3 Storage.

S3(path, AK, SK, format)
The initial implement of s3(..) tvf, use like:

MySQL [(none)]> select * from s3("http://<IP_ADDRESS>:9312/test2/student1.csv", "minioadmin", "minioadmin", "csv");
+------+------+------+
| c1   | c2   | c3   |
+------+------+------+
| 1    | ftw  | 12   |
| 2    | zs   | 18   |
| 3    | ww   | 20   |
+------+------+------+
3 rows in set (0.04 sec)

MySQL [(none)]> select * from s3("http://<IP_ADDRESS>:9312/test2/student_with_names.csv", "minioadmin", "minioadmin", "csv_with_names");
+------+------+------+
| id   | name | age  |
+------+------+------+
| 1    | ftw  | 12   |
| 2    | zs   | 18   |
| 3    | ww   | 20   |
+------+------+------+
3 rows in set (0.04 sec)

Checklist(Required)

Does it affect the original behavior:

[x] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[x] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[x] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[x] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[x] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

Need to add some regression test in next PR

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.44 seconds
load time: 432 seconds
storage size:<PHONE_NUMBER>3 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221104103500_clickbench_pr_40058.html


Update .gitignore

Prevent JetBrains users from submitting their .idea folder (similar to the .vscode folder).

I haven’t used JetBrains much so I’m not too familiar. I see the comment right above this change says that making it is not recommended and suggests a bigger template. Whats your experience with this? Is there a norm to ignore the whole directory?

Yes.
I checked the Langchain repo, and they also ignore the entire folder.


hyperv driver should be more explicit when the vswitch used can't reach Internet

As said in #2995, the docker-machine provisioning get stuck at
Waiting for host to start...

When the Virtual Switch used with the Hyper-V machine does not have a proper Internet connection.
And the machine IP cannot be found, if we try to do docker-machine ls.
We should output a link to the documentation explaining how it works.
Personnally, this link (from the docker documentation) https://www.packet6.com/allowing-windows-8-1-hyper-v-vm-to-work-with-wifi/ helped me, because I'm always using WiFi not Ethernet.

Thanks @Oliboy50, please submit a followup PR to add this information if desired.


interpreted text should only allow 1 backticks ?

This:
:attr:``numpy.ufunc.identity``

Is parsed as interpreted text, I don't think it should.
It is not properly handled by docutils/sphinx

Looks like this should be parsed as an inline literal https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html#inline-literals.
(paragraph "text" (literal))


fixed email parsing

Hello! there is a problem located in URLBuilder.swift.  function configuration.email.addingPercentEncoding(withAllowedCharacters: .urlHostAllowed) does not encode + sign
so email<EMAIL_ADDRESS>will transform to test3+%40test.com and after that, this url is passed to webview so the result in support form I'm getting empty space instead of +
so plz switch from .urlHostAllowed -> .alphanumerics and this case will work

Thanks for your contribution @riznyk7 .


Persistence is not working on the HOST only on other clients

Ok here is the thing when hosts leaves ot deleats the player on its own without remove player you can see it in the logs
2024/08/21 01:16:12.8162    [GameMenu] Removing player: 5f82bb60-8fef-4fbc-af12-7eae8734b230 hepe_fuil
2024/08/21 01:16:12.8162    [GameMenu] Player not found in the list: 5f82bb60-8fef-4fbc-af12-7eae8734b230

So what we need to do is to find out why the Player is being deleted on it's own and then fix it and were finished

Possible fix

Almost fixed, but now persistence work so no need to focus on this issue anymore.

I think I can close it.


Error when building with build_win.bat

As mentioned in my Reddit comment, here's the error I'm seeing: https://gist.github.com/sir-pinecone/1b66a0e60abb9cdbfeabd78adeccc1bf
I took a look at the code and removed the (d_ctx) from that line and then it compiled. I'm not too familiar with that C syntax, so I'm not sure if it's needed or not.
I'm also having another problem when I try to run an example (I can make a new issue if you prefer):

Hey, I'm pushing out a patch to address the first issue, I'm gonna need more info for the second one than just having issues when you try to run something.
Thanks for taking the time to document this.

Added a potential patch for d_ctx in 626e8b6ebdfaa2cfa6494a042f288e6ab8bc8daf. Let me know if that works for you.
For running examples, please open an issue & document it!

Hey man, that commit fixed the build error :)
And you're totally right about the obtuse error needing more info. My bad. I'll see if I can get you some details with a debugger.


Adds note about pulling latest master

adds note to check that we're always on latest master before deploying, as well as that you'll have to be a collaborator on the repo.

looks good to me! like how explicit the directions are :)


Improve description of "Provider Connection String"

The current version advises to surround the value of Provider Connection String with double quotation marks, which is not generally correct. I have replaced this advise with a reference to the general connection-string syntax, but have kept the example, explaining why it this specific case double quotation marks work.
Summary
Fulfills this request

@ant-222 Just for the sake of discussion - isn't a connection string always going to contain a semicolon, because it will always (I think) contain more than one keyword/value pair, and therefore - in fact if not in principle - always need to be surrounded with double quotes?

@douglaslMS A connection string to a file-based data source may easily contain a single parameter—the name of the file. Nothing forbids an empty connection string to some global, default, or predefined data source (such a as the table with environment variables). If a connection string does contain more than a single parameter separated by a semicolon, the double quotation mark is not the only possible enclosing character: the single quotation mark is another option. Furthermore, the latter seems more useful for EF because the internal connection string is more likely to use double quotation marks.

@ant-222 Thanks for the clarification. I just want to make sure that we don't obscure the most common use case.

@douglaslMS The example in my version still reflects the common use case:
`Provider Connection String ="Server=serverName; User ID = userID";`

@ant-222 Thank you for your revisions. The updated page should be published by tomorrow.

@douglaslMS Thanks to you, Douglas. Please, check the syntax of my reference—I couldn't test it in the github preview.


Added config setting: SqlSettings.ReplicaMonitorIntervalSeconds

Documentation for: https://github.com/mattermost/mattermost/pull/22888

@gabrieljackson - Is this config setting used for Cloud deployments? If so, what's the value set for Cloud?


feat: make sentry optional (close #177)

PR to make sentry optional.

Just saw this after I created my own PR with changes that made it optional, but don't ask the questions. I'll merge this branch into mine once the secrets fix is merged in, then I can test it all before submitting for review.

@daveoconnor, I apologize for not waiting for you on this issue - I rushed to get it done to help unblock @sjlawson.