New Envoy wrapper utility

Creating a new utility for managing the lifecycle of an Envoy server. Also updated the mixer tests to use this utility rather than relying on custom code.
This is an step toward refactoring the pkg/envoy classes used by the pilot_agent.
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[x] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@nmittler: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_e2e_cloudfoundry_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test istio_e2e_cloudfoundry_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_e2e_cloudfoundry_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test istio_e2e_cloudfoundry_istio

lint_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_e2e_cloudfoundry_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test istio_e2e_cloudfoundry_istio

lint_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test lint_istio

racetest_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test racetest_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_e2e_cloudfoundry_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test istio_e2e_cloudfoundry_istio

lint_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test lint_istio

racetest_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test racetest_istio

pilot-e2e-envoyv2-v1alpha3_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test pilot-e2e-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_e2e_cloudfoundry_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test istio_e2e_cloudfoundry_istio

lint_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test lint_istio

racetest_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test racetest_istio

pilot-e2e-envoyv2-v1alpha3_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test pilot-e2e-envoyv2-v1alpha3_istio

unit-tests_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_e2e_cloudfoundry_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test istio_e2e_cloudfoundry_istio

lint_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test lint_istio

racetest_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test racetest_istio

pilot-e2e-envoyv2-v1alpha3_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test pilot-e2e-envoyv2-v1alpha3_istio

unit-tests_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test unit-tests_istio

integ-istioctl-k8s-tests_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test integ-istioctl-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

istio_e2e_cloudfoundry_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test istio_e2e_cloudfoundry_istio

lint_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test lint_istio

racetest_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test racetest_istio

pilot-e2e-envoyv2-v1alpha3_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test pilot-e2e-envoyv2-v1alpha3_istio

unit-tests_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test unit-tests_istio

integ-istioctl-k8s-tests_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test integ-istioctl-k8s-tests_istio

codecov_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test codecov_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov

Should this be sent to envoy org instead? It seems like you schematized the options and flags, which are subjects to changes in the proxy. It'd be better to keep them closer to the source of truth.

Eventually, yes. I'd like to finish the refactoring work in this repo first. We can then start the discussion of donating the code out of band with this work.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

unit-tests_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test unit-tests_istio

integ-istioctl-k8s-tests_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test integ-istioctl-k8s-tests_istio

codecov_istio
e158a253eb516a236519ad3537236d3792756a4b
link
/test codecov_istio

lint_istio
470b126279f228cb7b16a44bd4b6e6bfd1cb9dc6
link
/test lint_istio

pilot-e2e-envoyv2-v1alpha3_istio
470b126279f228cb7b16a44bd4b6e6bfd1cb9dc6
link
/test pilot-e2e-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-istioctl-k8s-tests_istio
470b126279f228cb7b16a44bd4b6e6bfd1cb9dc6
link
/test integ-istioctl-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test pilot-e2e-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-istioctl-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-istioctl-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-istioctl-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-istioctl-k8s-tests_istio

integ-new-install-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-new-install-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-istioctl-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-istioctl-k8s-tests_istio

integ-new-install-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-new-install-k8s-tests_istio

pilot-multicluster-e2e_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test pilot-multicluster-e2e_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-istioctl-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-istioctl-k8s-tests_istio

integ-new-install-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-new-install-k8s-tests_istio

pilot-multicluster-e2e_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test pilot-multicluster-e2e_istio

integ-security-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-istioctl-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-istioctl-k8s-tests_istio

integ-new-install-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-new-install-k8s-tests_istio

pilot-multicluster-e2e_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test pilot-multicluster-e2e_istio

integ-security-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-security-k8s-tests_istio

lint_istio
59271bb62f377791804fd02aa259ee48cb0674b7
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-istioctl-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-istioctl-k8s-tests_istio

integ-new-install-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-new-install-k8s-tests_istio

pilot-multicluster-e2e_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test pilot-multicluster-e2e_istio

integ-security-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-security-k8s-tests_istio

lint_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-istioctl-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-istioctl-k8s-tests_istio

integ-new-install-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-new-install-k8s-tests_istio

pilot-multicluster-e2e_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test pilot-multicluster-e2e_istio

integ-security-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-security-k8s-tests_istio

lint_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test lint_istio

racetest_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test racetest_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-istioctl-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-istioctl-k8s-tests_istio

integ-new-install-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-new-install-k8s-tests_istio

pilot-multicluster-e2e_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test pilot-multicluster-e2e_istio

integ-security-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-security-k8s-tests_istio

lint_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test lint_istio

racetest_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test racetest_istio

unit-tests_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-new-install-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-new-install-k8s-tests_istio

pilot-multicluster-e2e_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test pilot-multicluster-e2e_istio

integ-security-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-security-k8s-tests_istio

lint_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test lint_istio

racetest_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test racetest_istio

unit-tests_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test unit-tests_istio

integ-istioctl-k8s-tests_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test integ-istioctl-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-new-install-k8s-tests_istio

pilot-multicluster-e2e_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test pilot-multicluster-e2e_istio

integ-security-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-security-k8s-tests_istio

lint_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test lint_istio

racetest_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test racetest_istio

unit-tests_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test unit-tests_istio

integ-istioctl-k8s-tests_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test integ-istioctl-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test pilot-e2e-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-new-install-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-new-install-k8s-tests_istio

pilot-multicluster-e2e_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test pilot-multicluster-e2e_istio

integ-security-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-security-k8s-tests_istio

lint_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test lint_istio

racetest_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test racetest_istio

unit-tests_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test unit-tests_istio

integ-istioctl-k8s-tests_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test integ-istioctl-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test pilot-e2e-envoyv2-v1alpha3_istio

codecov_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test codecov_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-security-k8s-tests_istio
7149b5bb923d6bda502e331bf686b275b8aae361
link
/test integ-security-k8s-tests_istio

lint_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test lint_istio

racetest_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test racetest_istio

unit-tests_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test unit-tests_istio

integ-istioctl-k8s-tests_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test integ-istioctl-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test pilot-e2e-envoyv2-v1alpha3_istio

codecov_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test codecov_istio

pilot-multicluster-e2e_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test pilot-multicluster-e2e_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test lint_istio

racetest_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test racetest_istio

unit-tests_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test unit-tests_istio

integ-istioctl-k8s-tests_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test integ-istioctl-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test pilot-e2e-envoyv2-v1alpha3_istio

codecov_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test codecov_istio

pilot-multicluster-e2e_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test pilot-multicluster-e2e_istio

integ-mixer-k8s-tests_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

racetest_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test racetest_istio

unit-tests_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test unit-tests_istio

integ-istioctl-k8s-tests_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test integ-istioctl-k8s-tests_istio

codecov_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test codecov_istio

pilot-multicluster-e2e_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test pilot-multicluster-e2e_istio

integ-mixer-k8s-tests_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test integ-mixer-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
ee9aa26e0194398cb1c03ed07669fffebcf35c09
link
/test pilot-e2e-envoyv2-v1alpha3_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test pilot-multicluster-e2e_istio

integ-mixer-k8s-tests_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test integ-mixer-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
ee9aa26e0194398cb1c03ed07669fffebcf35c09
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-istioctl-k8s-tests_istio
ee9aa26e0194398cb1c03ed07669fffebcf35c09
link
/test integ-istioctl-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
5a9907adf517690615a88768ef079d1e2cfa93ed
link
/test integ-mixer-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
ee9aa26e0194398cb1c03ed07669fffebcf35c09
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-istioctl-k8s-tests_istio
ee9aa26e0194398cb1c03ed07669fffebcf35c09
link
/test integ-istioctl-k8s-tests_istio

pilot-multicluster-e2e_istio
ee9aa26e0194398cb1c03ed07669fffebcf35c09
link
/test pilot-multicluster-e2e_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
ee9aa26e0194398cb1c03ed07669fffebcf35c09
link
/test pilot-e2e-envoyv2-v1alpha3_istio

integ-istioctl-k8s-tests_istio
ee9aa26e0194398cb1c03ed07669fffebcf35c09
link
/test integ-istioctl-k8s-tests_istio

pilot-multicluster-e2e_istio
ee9aa26e0194398cb1c03ed07669fffebcf35c09
link
/test pilot-multicluster-e2e_istio

integ-mixer-k8s-tests_istio
ee9aa26e0194398cb1c03ed07669fffebcf35c09
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-istioctl-k8s-tests_istio
ee9aa26e0194398cb1c03ed07669fffebcf35c09
link
/test integ-istioctl-k8s-tests_istio

pilot-multicluster-e2e_istio
ee9aa26e0194398cb1c03ed07669fffebcf35c09
link
/test pilot-multicluster-e2e_istio

integ-mixer-k8s-tests_istio
ee9aa26e0194398cb1c03ed07669fffebcf35c09
link
/test integ-mixer-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
6b455a787d64dcc2b8e4c2aa078ab55667f7de07
link
/test pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
ee9aa26e0194398cb1c03ed07669fffebcf35c09
link
/test pilot-multicluster-e2e_istio

integ-mixer-k8s-tests_istio
ee9aa26e0194398cb1c03ed07669fffebcf35c09
link
/test integ-mixer-k8s-tests_istio

pilot-e2e-envoyv2-v1alpha3_istio
6b455a787d64dcc2b8e4c2aa078ab55667f7de07
link
/test pilot-e2e-envoyv2-v1alpha3

integ-istioctl-k8s-tests_istio
6b455a787d64dcc2b8e4c2aa078ab55667f7de07
link
/test integ-istioctl-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
6b455a787d64dcc2b8e4c2aa078ab55667f7de07
link
/test pilot-e2e-envoyv2-v1alpha3

integ-istioctl-k8s-tests_istio
6b455a787d64dcc2b8e4c2aa078ab55667f7de07
link
/test integ-istioctl-k8s-tests

pilot-multicluster-e2e_istio
6b455a787d64dcc2b8e4c2aa078ab55667f7de07
link
/test pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
6b455a787d64dcc2b8e4c2aa078ab55667f7de07
link
/test pilot-e2e-envoyv2-v1alpha3

integ-istioctl-k8s-tests_istio
6b455a787d64dcc2b8e4c2aa078ab55667f7de07
link
/test integ-istioctl-k8s-tests

pilot-multicluster-e2e_istio
6b455a787d64dcc2b8e4c2aa078ab55667f7de07
link
/test pilot-multicluster-e2e

e2e-mixer-no_auth_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test e2e-mixer-no_auth

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-istioctl-k8s-tests_istio
6b455a787d64dcc2b8e4c2aa078ab55667f7de07
link
/test integ-istioctl-k8s-tests

pilot-multicluster-e2e_istio
6b455a787d64dcc2b8e4c2aa078ab55667f7de07
link
/test pilot-multicluster-e2e

e2e-mixer-no_auth_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test e2e-mixer-no_auth

pilot-e2e-envoyv2-v1alpha3_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-istioctl-k8s-tests_istio
6b455a787d64dcc2b8e4c2aa078ab55667f7de07
link
/test integ-istioctl-k8s-tests

pilot-multicluster-e2e_istio
6b455a787d64dcc2b8e4c2aa078ab55667f7de07
link
/test pilot-multicluster-e2e

e2e-mixer-no_auth_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test e2e-mixer-no_auth

pilot-e2e-envoyv2-v1alpha3_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test pilot-e2e-envoyv2-v1alpha3

e2e-simpleTestsMinProfile_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test e2e-simpleTestsMinProfile

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
6b455a787d64dcc2b8e4c2aa078ab55667f7de07
link
/test pilot-multicluster-e2e

e2e-mixer-no_auth_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test e2e-mixer-no_auth

pilot-e2e-envoyv2-v1alpha3_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test pilot-e2e-envoyv2-v1alpha3

e2e-simpleTestsMinProfile_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test e2e-simpleTestsMinProfile

integ-istioctl-k8s-tests_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test integ-istioctl-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
6b455a787d64dcc2b8e4c2aa078ab55667f7de07
link
/test pilot-multicluster-e2e

e2e-mixer-no_auth_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test e2e-mixer-no_auth

pilot-e2e-envoyv2-v1alpha3_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test pilot-e2e-envoyv2-v1alpha3

e2e-simpleTestsMinProfile_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test e2e-simpleTestsMinProfile

integ-istioctl-k8s-tests_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test integ-istioctl-k8s-tests

integ-mixer-k8s-tests_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-mixer-no_auth_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test e2e-mixer-no_auth

pilot-e2e-envoyv2-v1alpha3_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test pilot-e2e-envoyv2-v1alpha3

e2e-simpleTestsMinProfile_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test e2e-simpleTestsMinProfile

integ-istioctl-k8s-tests_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test integ-istioctl-k8s-tests

integ-mixer-k8s-tests_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test integ-mixer-k8s-tests

pilot-multicluster-e2e_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn

Do we plan to use this from pilot agent as well?

Yes, that's the plan. This PR just puts it in place. The next step is to refactor the rest of pkg/envoy and to use this from the pilot_agent.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-mixer-no_auth_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test e2e-mixer-no_auth

integ-istioctl-k8s-tests_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test integ-istioctl-k8s-tests

integ-mixer-k8s-tests_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test integ-mixer-k8s-tests

pilot-multicluster-e2e_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test pilot-multicluster-e2e

pilot-e2e-envoyv2-v1alpha3_istio
9788fcf7a4b97bd0fdee926ae2f588ef87428498
link
/test pilot-e2e-envoyv2-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-mixer-no_auth_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test e2e-mixer-no_auth

integ-mixer-k8s-tests_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test integ-mixer-k8s-tests

pilot-multicluster-e2e_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test pilot-multicluster-e2e

pilot-e2e-envoyv2-v1alpha3_istio
9788fcf7a4b97bd0fdee926ae2f588ef87428498
link
/test pilot-e2e-envoyv2-v1alpha3

integ-istioctl-k8s-tests_istio
9788fcf7a4b97bd0fdee926ae2f588ef87428498
link
/test integ-istioctl-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

The errors are concerning but probably not related to this change? https://storage.googleapis.com/istio-prow/pr-logs/pull/istio_istio/17113/integ-istioctl-k8s-tests_istio/492/artifacts/istioctl-integration-test-f86fc/_suite_context/istio-state-825628407/istio-ingressgateway-776f79dc9c-xwkjb-istio-proxy.log

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-mixer-k8s-tests_istio
97ce8cc826342f8cc815d15fa5982d58da332678
link
/test integ-mixer-k8s-tests

pilot-e2e-envoyv2-v1alpha3_istio
9788fcf7a4b97bd0fdee926ae2f588ef87428498
link
/test pilot-e2e-envoyv2-v1alpha3

integ-istioctl-k8s-tests_istio
9788fcf7a4b97bd0fdee926ae2f588ef87428498
link
/test integ-istioctl-k8s-tests

pilot-multicluster-e2e_istio
9788fcf7a4b97bd0fdee926ae2f588ef87428498
link
/test pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-e2e-envoyv2-v1alpha3_istio
9788fcf7a4b97bd0fdee926ae2f588ef87428498
link
/test pilot-e2e-envoyv2-v1alpha3

integ-istioctl-k8s-tests_istio
9788fcf7a4b97bd0fdee926ae2f588ef87428498
link
/test integ-istioctl-k8s-tests

pilot-multicluster-e2e_istio
9788fcf7a4b97bd0fdee926ae2f588ef87428498
link
/test pilot-multicluster-e2e

integ-mixer-k8s-tests_istio
9788fcf7a4b97bd0fdee926ae2f588ef87428498
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler Re: upstreaming it: we have a new test framework in istio/proxy to test WASM modules. Since we can't import istio there due to circular dependency issues, it'd be better to have common envoy utilities in the upstream for us.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
9788fcf7a4b97bd0fdee926ae2f588ef87428498
link
/test pilot-multicluster-e2e

integ-mixer-k8s-tests_istio
9788fcf7a4b97bd0fdee926ae2f588ef87428498
link
/test integ-mixer-k8s-tests

integ-new-install-k8s-tests_istio
0f1c3783476e366965d1eb341208021f49f09777
link
/test integ-new-install-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
9788fcf7a4b97bd0fdee926ae2f588ef87428498
link
/test pilot-multicluster-e2e

integ-new-install-k8s-tests_istio
b51955f07d53835826808cb3007ca8d322bda908
link
/test integ-new-install-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nmittler: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

pilot-multicluster-e2e_istio
9788fcf7a4b97bd0fdee926ae2f588ef87428498
link
/test pilot-multicluster-e2e

integ-new-install-k8s-tests_istio
b51955f07d53835826808cb3007ca8d322bda908
link
/test integ-new-install-k8s-tests

integ-mixer-k8s-tests_istio
b51955f07d53835826808cb3007ca8d322bda908
link
/test integ-mixer-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Re: proxy agent replacement. Please make sure to test config hot reload in Envoy, which this PR does not cover. It's been a source of many-many dead locks and segfaults in Envoy is rather risky to replace. I'd rather not refactor that unless there's a problem with it, unless you want to find more bugs in Envoy.


When using stats::t.test, the report() and report_table() function output displays "95 % CI" even if, say, conf.level = 0.975

Not sure if this is a bug, or if I'm not specifying the correct parameters when using the reporter::report() function, but
when using stats::t.test, the report() and report_table() functions' output displays "95 % CI" even if, say, the stats::t.test conf.level is set to a value other than 0.95.

I apologize. You are correct, I meant to post this for the "report" package.
I don't think I can delete my post, but please do if you're able to.
Thanks!
-Bill


UAT | E-filing | Upload ID Card

Module: E-filing
Issue:
On uploading a new ID card, and selecting a doc, the add button is only viewable on scroll.
This confuses the user as to how to proceed
Expected behaviour:
Pop up size is adjusted so entitre content shows up in one go.

This issue is fixed and working fine in UAT Env

resolved


bug: When having autofocus on an input in IonModal, it has a weird animation on iOS device

Bug Report
Ionic version:
5.1.1, but also happened on 5.0.7
Current behavior:
When I open an IonModal, it has a weird animation when I have an IonInput with autofocus true in it. This only happens on iOS simulator or device. Not in android or web version.
Expected behavior:
The transition is the same like on web and android.
Steps to reproduce:
Create an IonModal with an IonInput in it that that autofocus={true}
Related code:

insert short code snippets here

Other information:

Ionic info:

Ionic:

   Ionic CLI       : 6.9.2 (C:\Users\Pitis\AppData\Roaming\npm\node_modules\@ionic\cli)
   Ionic Framework : @ionic/react 5.1.1

Capacitor:

   Capacitor CLI   : 2.0.1
   @capacitor/core : 2.0.1

Utility:

   cordova-res : not installed
   native-run  : not installed

System:

   NodeJS : v13.8.0 (C:\Program Files\nodejs\node.exe)
   npm    : 6.14.5
   OS     : Windows 10

I'm using ionic version 5.1.1.
Here's a video to see how it works on my iPhone 7 Plus: https://streamable.com/vi6qe3
You can reproduce the bug with this code:
Page 1
<ion-content>
  <ion-button expand="full" routerLink="/page2">Autofocus=true</ion-button>
  <ion-button expand="full" routerLink="/page3">Autofocus=false</ion-button>
</ion-content>

Page 2 has ion-input with autofocus set true
<ion-content>
  <ion-item>
    <ion-input autofocus="true"></ion-input>
  </ion-item>
</ion-content>

Page 3 has ion-input with autofocus set false
<ion-content>
  <ion-item>
    <ion-input autofocus="false"></ion-input>
  </ion-item>
</ion-content>

@ernofi Can you provide this as a full repo I can use to reproduce the issue?

@liamdebeasi  https://github.com/ernofi/ionic-ios-autofocus-transition-bug

Thanks. I was able to reproduce this behavior, but I am not sure what is causing it. I need to investigate this more.

Thanks for the issue. I am going to close this as a duplicate of https://github.com/ionic-team/ionic-framework/issues/18257.


Feature-map attribute should be implemented in SDK for some clusters

Issue :  When we read feature-map for above mentioned cluster we get

Feature-map attribute should be implemented in SDK for the below mentioned clusters

Relative humidity
Occupancy Sensing Cluster
Pressure Measurement Cluster
Power Source Configuration
Descriptor
Boolean State Cluster
Bridged Actions Cluster
Flow Measurement Cluster

Same issue facing in below mentioned clusters.

Identify Cluster
Illuminance Measurement Cluster
Temperature Measurement Cluster
Thermostat User Interface Configuration
Localization Timeformat
Localization Configuration
Label cluster

Expected outcome:- FeatureMap attribute value should be 0
Actual outcome:-0x86 (UNSUPPORTED_ATTRIBUTE)
Steps to reproduce:-

./chip-tool identify read feature-map 1 1
./chip-tool illuminancemeasurement read feature-map 1 1
./chip-tool temperaturemeasurement read feature-map 1 1
./chip-tool thermostatuserinterfaceconfiguration read feature-map 1 1
./chip-tool timeformatlocalization read feature-map 1 0
./chip-tool fixedlabel read feature-map 1 0
./chip-tool userlabel read feature-map 1 0
./chip-tool localizationconfiguration read feature-map 1 0

system configuration:-
Chip-Tool: RPI
DUT: RPI
Platform : IP and Wifi
Commit-ID:4d50b1084284018c4a628f919b0d2e01ea2a39f8
Dut: all-cluster-app
PFA logs below:-
TC-ILL-1.1.txt
TC-I-1.1.txt
TC-LO-1.1.txt
TC-TSUIC-1.1.txt
TC-LC-1.1.txt
TC-TM-1.1.txt
TC-LC-1.1.txt


[4.1] Character sheet skill names are unreadable in edit mode in font size 6+

I know supporting font sizes beyond the default 5 is not much of a consideration, but as a font size 6 user I feel obligated to keep reporting css issues like this. I will stop if told they will not be fixed and focus only on correcting it with modules.

Depending on the width of the character sheet, the abilities labels for saving throws collapse to their abbreviations, maybe the same could be done for skills.


🚀 Feature: Add props to pass down tableOptions in EntityHasSubcomponentsCard, EntityDependsOnResourcesCard and EntityDependsOnResourcesCard

🔖 Feature description
I want to add props to add pagination and search capabilities to these components EntityHasSubcomponentsCard, EntityDependsOnResourcesCard and EntityDependsOnResourcesCard.
🎤 Context
because as of now we are having large number of entities in these tables.
✌ Possible Implementation
No response
👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

the have implement this feature and this is the resulted PR https://github.com/backstage/backstage/pull/18504


React 16 support

This should cover everything from #191. I think I've fixed all of the remaining things: moving it to dependencies, marking it external and fixing the react dom factories issue.

Closes #238
Closes #241
Closes #235
Closes #191
Part of #181

Looks great! I'll test it out later.
One thing though - do you think you can do the formatting changes separately for the sake of the Git history?

Okay, I removed my readme changes for now. I also added support for React 16 beta.

Let me know what you think now. I think I've made all of the changes requested.

will this be merged soon, because we want to upgrade to react 16

Thanks @mikecousins will do some manual testing to confirm everything works and then merge

@mikecousins I'm getting the "'ReactQuill not found. Did you run "make build"?'" popup when I try to open demo/index.html from your fork. Are you seeing that as well or can your run the demo?

I don't have make, so I can't run the build. Where do I get make from?

PS C:\GitHub\react-quill> make build
make i info Invoking build target
'$' is not recognized as an internal or external command,
operable program or batch file.
make × ERR  @$(WEBPACK) --config webpack.dev.js
@$(WEBPACK) --config webpack.prod.js
@cp node_modules/quill/dist/quill.core.css dist
@cp node_modules/quill/dist/quill.snow.css dist
@cp node_modules/quill/dist/quill.bubble.css dist
@mkdir -p $(LIB)
@cp -Rfv $(SOURCE)/* $(LIB)
make × ERR  Recipe exited with code %d
(node:48152) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Recipe exited with
code %d
(node:48152) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejection
s that are not handled will terminate the Node.js process with a non-zero exit code.
PS C:\GitHub\react-quill>

PS C:\GitHub\react-quill> npm run test

<EMAIL_ADDRESS>test C:\GitHub\react-quill
make test

make i info Invoking test target
make i info Invoking lint target
'$' is not recognized as an internal or external command,
operable program or batch file.
make × ERR  @$(LINT) $(LINT_FLAGS) $(SOURCE)
make × ERR  Recipe exited with code %d
(node:40428) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Recipe exited with
code %d
(node:40428) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejection
s that are not handled will terminate the Node.js process with a non-zero exit code.
make i info Build success in 427ms
PS C:\GitHub\react-quill>

Yeah, that will probably only work on a Unix-y system, like Bash on Windows/Cygwin/MacOS/Linux.
Really you just need to translate these commands:
npm run webpack --config webpack.dev.js # Build
npm run webpack --config webpack.prod.js # Build
cp node_modules/quill/dist/quill.core.css dist # Copy assets
cp node_modules/quill/dist/quill.snow.css dist # Copy assets
cp node_modules/quill/dist/quill.bubble.css dist # Copy assets
mkdir -p ./lib # Make lib folder
cp -Rfv ./src/* ./lib/ # Copy built files to lib folder

mike@MIKE-BRIGHTSQUID:/mnt/c/GitHub/react-quill$ npm run build
: not foundram Files/nodejs/npm: 3: /mnt/c/Program Files/nodejs/npm:
: not foundram Files/nodejs/npm: 5: /mnt/c/Program Files/nodejs/npm:
/mnt/c/Program Files/nodejs/npm: 6: /mnt/c/Program Files/nodejs/npm: Syntax error: word unexpected (expecting "in")
mike@MIKE-BRIGHTSQUID:/mnt/c/GitHub/react-quill$ npm run test
: not foundram Files/nodejs/npm: 3: /mnt/c/Program Files/nodejs/npm:
: not foundram Files/nodejs/npm: 5: /mnt/c/Program Files/nodejs/npm:
/mnt/c/Program Files/nodejs/npm: 6: /mnt/c/Program Files/nodejs/npm: Syntax error: word unexpected (expecting "in")
mike@MIKE-BRIGHTSQUID:/mnt/c/GitHub/react-quill$

I just went down a pretty deep rabbit hole trying to modify the makefile. I'm going to give up for now.

Did you see the comment above about the webpack commands?
I think on Windows you just need to translate the mkdir and cp commands - could just use File Explorer and copy-paste.
Sorry for the difficulty - we should probably rewrite these actions as cross-platform node scripts.
If you don't have more time I'll try again later on a different computer.

I manually ran those commands now and I get a React not found popup followed by a ReactQuill not found popup.

Looking into the demo code it's a pretty strange setup that I don't quite follow.

Every single file it tries to load fails.

Yes, it works on current master.

Well, I have no idea why.

Here's why: https://github.com/mikecousins/react-quill/pull/2 😄
Since prop-types is an external in webpack we need to add it our demos and codepen examples.

Looking into the demo code it's a pretty strange setup that I don't quite follow.

@mikecousins, I believe this might be an issue with symbolic link support on Windows:

Have a look at your demo folder, and if you don't have such files, link them or copy them there.

@zenoamaro see the PR I made into @mikecousins branch that adds a symlink for prop-types.js
https://github.com/mikecousins/react-quill/pull/2
If you want to work on it further I pulled in the changes in this PR onto https://github.com/zenoamaro/react-quill/tree/react-16-compat

Nice work guys. :) I'll take a look at the new branch.

Closing in favor of #253


Provide function to log missing keys

Hi,
we have a pretty large eCommerce website and unfortunately, we have some error messages/key from external APIs we don't know and they can even change.
Is there a way we can log these missing keys in production so that our translation Team can find them more easily?
When we could inject an function via i18n.js like this it would be unbelievable great :)  :
missingKeyHandler: (key: string): string => {
    // logging part
    return ''
}

Thanks
Robin

@RobinSCU there isn't a way right now, but is an interesting feature to implement

@aralroca I'm interested in this as well. And thx for a great library :)

@aralroca  @giovannigiordano thanks for the implementation, but how can I actually provide the prop to the I18nProvider? As you said in your documentation:

The I18nProvider is a context provider internally used by next-translate to provide the current lang and the page namespaces. SO MAYBE YOU'LL NEVER NEED THIS.

We actually don't use the I18nProvider directly and in the implementation from @giovannigiordano I can't see a way how we can provide a logger without using the I18nProvider directly in our code or do I miss something?

Sorry, I missed the fact it is automatically added. I will work on it in these days.I will add the logger function to the  JSON config and read from there.
Inviato da iPhone

Il giorno 11 ott 2020, alle ore 14:28, RobinSCU<EMAIL_ADDRESS>ha scritto:

@aralroca @giovannigiordano thanks for the implementation, but how can I actually provide the prop to the I18nProvider? As you said in your documentation:
The I18nProvider is a context provider internally used by next-translate to provide the current lang and the page namespaces. SO MAYBE YOU'LL NEVER NEED THIS.
We actually don't use the I18nProvider directly and in the implementation from @giovannigiordano I can't see a way how we can provide a logger without using the I18nProvider directly in our code or do I miss something?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

I think the best option is to allow i18n.js for the configuration, because i18n.json is not possible to storage functions. This way the missingKeyLogger function can be added to the config in a simple way. We can support both, .js and .json to don't add any breaking change.

@RobinSCU I did a prerelease 0.18.0-canary.2 with this change and improving a little bit the default logger! If you can test it and provide some feedback before the 0.18.0 it would be very useful 🙏. Thanks!

@aralroca works like a charm! Thanks for the implementation!


Request: WalletConnect

Hi - would like to state that adding WalletConnect could be useful, as it allows for multisigs to join.  This widens the set of high-reputation accounts that could use Interep, as they may currently be co-owned by teams and small groups.  Thanks.

Yes, I think this might be a useful addition. Note that using a multisig account could be tricky in some cases (e.g. linking it to an individual's social ID). We'll leave that to app designers to be aware of.


Update Japanese translation

GIPHY is replaced by Tenor

'featured GIFs' is translated as "おすすめのGIF" on Tenor website (Japanese version).

Accessibility hint for long-pressing hashtags have been changed to follow

@Hima-Zinn @dolciss @oboenikui @noritada @middlingphys @hibiki @reindex-ot @haoyayoi @vyv03354
Japanese translation is updated to sync with main.
(GIPHY -> Tenor, embed GIF player related a11y hints)

Translated "2FA" as 「２要素認証」（2FA/Two-Factor Authentication を「２要素認証」と訳しました） https://github.com/bluesky-social/social-app/pull/3656/commits/0f3a2d6aa80fc315c596d9288edeed80c621c611

Translation modified to reflect Hima-Zinn's comments.


Custom params don't work?

Expected behavior
Using Geocodio, and would like to pass &fields=timezone in the query.
First I tried:
geocoded_by :address, :params => {:fields => "timezone"} in the model but
Also tried:
  :params       => {"fields" => "timezone"}, in geocoder.rb
both of these did not include those params in the request.
Actual behavior
Should add &fields=timezone in the query to query url.
Steps to reproduce
see above
Environment info

Geocoder version: 1.4.6
Rails version: 4.2.8
Database (if applicable): n/a

Pretty stumped. It doesn't seem like passing in params via the configuration works at all. Printing out the whole ConfigurationHash object doesn't show that params is included (triggers method_missing and crashes)


JamesIves/github-pages-deploy-action v4 has problem.

F.Y.I.
At this moment, I got the following error message when the doxygen-github-pages-action runs.
/home/runner/work/_actions/JamesIves/github-pages-deploy-action/v4/lib/main.js

This error message was observed by many people and reported to the JamesIves/github-pages-deploy-action. This seems to be the problem on not only doxygen-github-pages-action, but also other actions which depend on the github-pages-deploy-action.

 bug: 🐝 File not found v4/lib/main.js #1697

There is a suggested workaround on the above issue thread. On the other hand,  JamesIves might revert the commits in last night to fix this problem. In that case, the problem may disappear soon.

Jameslves has fixed the bug.
https://github.com/JamesIves/github-pages-deploy-action/issues/1697#issuecomment-2380614391
On my site, the actions work, again.


fetchzip: force UTF-8 compatible locale to unpack non-ASCII symbols

musl and darwin support UTF-8 locales without any extras. As a result
unzip can unpack UTF-8 filenames there as is. But on glibc without
locale archive presence files get mangled as:
deps/αβ -> deps/#U03b1#U03b2

This makes fetchzip fixed-output derivations unstable.
Tested this change to fail in coq.src which was generated in system
that mangles UTF-8 symbols:
$ nix build -f. coq.src --rebuild -L
source> trying https://github.com/coq/coq/archive/V8.15.2.zip
source>   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
source>                                  Dload  Upload   Total   Spent    Left  Speed
source>   0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
source> 100 8945k  100 8945k    0     0  1513k      0  0:00:05  0:00:05 --:--:-- 1989k
source> unpacking source archive /build/V8.15.2.zip
error: hash mismatch in fixed-output derivation '/nix/store/hrnyykm7wgw8vxisgq7hc2bg5gr0y6s8-source.drv':
         specified: sha256-h81nFqkuvZkMR7YLHy7laTq5yOhjMW+w6rYzncxvyD4=
            got:    sha256-DTspmwyD3Evl1CUmvUy2MonbLGUezvsHN3prmP9eK2I=

Note: it means that some of existing caches for fixed output
derivations become incorrect. It should not break already cached
tarballs on cache.nixos.org thus the impact should not be widespread.
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Before merging it Sandro also suggested finding up existing problematic tarballs. We can recalculate their hashes as part of this PR. I'll try to extract at least some of problematic ones.
List of suspects:

[ ] coq.src:

@ofborg build coq_8_13.src coq_8_14.src coq_8_15.src eduli.src

@ofborg build coq_8_13.src coq_8_14.src coq_8_15.src coq_8_16.src eduli.src

glibcLocales is over 200 MB due to containing all locales.  That's way too heavy for this use case, I believe.  With .override { allLocales = false; } we still get the locale we need with just around 3 MB.

glibcLocales is over 200 MB due to containing all locales. That's way too heavy for this use case, I believe. With .override { allLocales = false; } we'd still get the locale we need with just around 3 MB.

Good point. Added shorter form of glibcLocales as:
+  glibcLocalesUtf8 =
+    if stdenv.hostPlatform.isLinux
+    then callPackage ../development/libraries/glibc/locales.nix { allLocales = false; }
+    else null;

and updated fetchzip to use it.

glibcLocales is over 200 MB due to containing all locales. That's way too heavy for this use case, I believe. With .override { allLocales = false; } we'd still get the locale we need with just around 3 MB.

We should reverse that default IMO. Most users are fine with C.UTF-8 plus their set locale and maybe en_US.UTF-8.

Well, that's like a discussion for another topic.  For users it's mostly the NixOS supportedLocales option what's important.  That one is fed into this parameter, though (a bit surprisingly to me) it defaults to all locales, too.  Either way, I believe that's the main step to address.

Doing a PR right now to fix that. We can discuss this further there.
#177318

pkgsCross.aarch64-android.stdenv

Good catch! I always wondered why we defined it non-null on musl (where it does not break, but builds unused glibc and locales). Proposed the fix as: https://github.com/NixOS/nixpkgs/pull/181384


unsigned int behaviour retains negative indices fix

I was trying to avoid the extra cost of the add and select_n thats present in promise_in_bounds, clip and fill so I went to u32. Looking at the jaxpr it does the compare still and then converts to i32. This seems wrong.
This relates to https://github.com/google/jax/issues/10063, I would also be okay with the approach 'unsigned should not exist' and add a mode for 'promise_in_bounds_positive'.
import jax
import jax.numpy as jnp
indices = jnp.array([0,3,4]).astype('uint32')
x = jnp.arange(5)
print(jax.make_jaxpr(x.__getitem__)(indices))

# Output:
{ lambda a:i32[5]; b:u32[3]. let
    c:bool[3] = lt b 0
    d:u32[3] = add b 5
    e:u32[3] = select_n c b d
    f:i32[3] = convert_element_type[new_dtype=int32 weak_type=False] e
    g:i32[3,1] = broadcast_in_dim[broadcast_dimensions=(0,) shape=(3, 1)] f
    h:i32[3] = gather[
      dimension_numbers=GatherDimensionNumbers(offset_dims=(), collapsed_slice_dims=(0,), start_index_map=(0,))
      fill_value=None
      indices_are_sorted=False
      mode=GatherScatterMode.PROMISE_IN_BOUNDS
      slice_sizes=(1,)
      unique_indices=False
    ] a g
  in (h,) }

There’s two things:
1 - Negative index catching
2 - Conversion to i32 for gather
Even when (1) is removed you still will pay a performance penalty for (2). Given JAX already has special int rules for out of bounds indexing the encoding of even more rules as an extra dtype u32 means you now have to deal with both dtype and bounds mode cases. Adding an extra mode solves both things and keeps the whole conversation related to just gather mode not dtype too.

We could probably avoid conversion to signed int as well, though there are some corner cases that need to be handled.
I don't think this needs an extra mode to account for this.

Original issue closed. The idea of an unsigned int accepting gather would be a separate issue which I don’t intend to file.
Thank you.


Add categories to API docs, and adjust front page to match.

http://api.dartlang.org should use categories to separate server-side (dart:io) from HTML (dart:html et al) from general-purpose libraries (dart:core, dart:async, etc.). See the Flutter API docs at http://docs.flutter.io for an example of categories (DART CORE, FLUTTER, FLUTTER_DRIVER, ...).

the script flutter uses to generate API docs (note --use-categories)
the SDK's doc generation script (BuildDartdocAPIDocs)

It seems that --use-categories works only for libraries within packages, but I'll test to make sure.

Categories has landed! https://api.dartlang.org/dev/


Automated installer of CLI beautifiers

Now this is going to be cool and very, very useful.
Steps

[ ] Check if there are available CLI installer instructions
[ ] Prompt User first (Would you like to automatically install this?)
[ ] Detect Operating System
[ ] Detect available package manager, if needed (see Operating System Specific section below)
[ ] Install CLI dependencies with OS-specific installation instructions

Look at how Travis CI installation works: https://github.com/Glavin001/atom-beautify/blob/master/.travis.yml#L16

CLI Dependencies

See list from https://github.com/Glavin001/atom-beautify#language-support

Operating System Specific

Mac

Homebrew - http://brew.sh/
MacPorts - https://www.macports.org/

Ubuntu

apt-get

Windows

chocolatey - https://chocolatey.org/

Link up with issue #164. Check for configured path to CLI beautifier; if not found try to determine it automatically; if that does not work; then suggest that the user installs / configures the CLI beautifier; allow user to automate this with this Issue's feature.

Link up with issue #164. Check for configured path to CLI beautifier; if not found try to determine it automatically; if that does not work; then suggest that the user installs / configures the CLI beautifier; allow user to automate this with this Issue's feature.

I'd like to automatically fix the PATH environment variable for users.

[ ] Add a path to PATH env var for Windows

winreg: https://www.npmjs.com/package/winreg
Programmatically modifiy environment variables?: http://stackoverflow.com/a/2121834/2578205

This will be handled by each individual beautifier provider. /cc #620 #1007

Changing direction to using Docker. See https://github.com/Glavin001/atom-beautify/issues/1687


made improvements in ECC code and parallel_for

ECC (comments from https://github.com/Itseez/opencv/pull/3845);
as well as minor tweak in pthread's based parallel for (num_threads = 2 on Android by default; check nstripes before going into parallel loop)

:+1:


Cannot access com.example.accessingdatajpa.Customer

I use maven to open the file pom.xml to build the project. And everything is ok but Cannot access com.example.accessingdatajpa.Customer
It seems that interface CustomerRepository extends CrudRepository<Customer, Long> can not access com.example.accessingdatajpa.Customer.

OS:
Windows 10 64bit
Intellij IDEA version:
Intellij IDEA ultimate 2021.1
Apache-maven version:
Apache-maven-3.8.1

Getting particular tools to work is beyond the realm of the guides. I suggest asking on Stack Overflow.


Move doc

Move "Advertise Kubernetes service IP addresses" doc to /Configure networking
-Merge to nightly

Deploy preview for calico ready!
Built with commit bd673db2275845b327f33925aea0fe44ae7582da
https://deploy-preview-3306--calico.netlify.com


Swift 4.1  EXC_BAD_ACCESS (code=1, address=0x0)

Trying to set values with the lib but getting  EXC_BAD_ACCESS (code=1, address=0x0) error
    func setFieldValue(_ value: Any) {

        if let editFieldName = editFieldName1, let _ = targetObject {
            var object = targetObject!;
            if dataItemTypeInfo == nil{
                dataItemTypeInfo = try! typeInfo(of: type(of:object));
            }

            let property = try! dataItemTypeInfo!.property(named: editFieldName)
            try! property.set(value: value, on: &object)
        }
    }

It crashes on the last line: try! property.set(value: value, on: &object) and till then all values looks correct (dataItemTypeInfo, property, value, targetObject, editFieldName)
My pod:
pod 'Runtime', :git => 'https://github.com/wickwirew/Runtime.git', :branch => 'swift-4.1'
Xcode 9.3.1
Swift 4.1
Am I doing something wrong?

Sorry im unable to reproduce the issue. Can you give the latest release a try? That branch I think may be a bit behind. It was mainly for the migration from swift 4 to 4.1. And a crash has been fixed recently.
So change your podfile to pod 'Runtime', '~> 0.7.1'
If that doesnt work or at least give a better error could you provide some better sample code to help reproduce it?

I was trying the master branch first actually which gave me that error before switching to swift4.1. Will give it another try and let you know how it goes.


Adding Makefile for mbed-trace

First draft of Makefile support for mbed-trace.
It is not tested for all compiler configurations.
Tested with "make CC=gcc"

@jupe


Buzzer Improvements

[ ] Investigate a buzzer with a flatter frequency response (ZL-YDW1207-4005PA-5.0 favors high frequencies)
[x] Investigate having two buzzers for stereo or polyphonic sound (budget permitting)
[x] Investigate hardware mute switch rather than software setting

Hardware mute isn't necessary with the quick setting menu.
I don't want to swap buzzers now, but this one would be a good candidate. It brings the resonant frequency down from 4000hz to 2300hz. It would require a footprint change
https://www.lcsc.com/product-detail/Buzzers_Jiangsu-Huaneng-Elec-HMB1206-03_C96101.html


Default “defaultErrnoRet” breaks the ability for hosts to run more recent container images.

Currently the spec defines the default defaultErrnoRet to be EPERM, this is troublesome and causes issues when running newer containers on hosts running an older kernel/userspace where the libseccomp version might not be aware of some of the syscalls used by the container. There have been many issues reported about syscalls getting an EPERM return code instead of ENOSYS when not available and breaking the user-space inside the container. Below is an example of such reports:

https://github.com/concourse/concourse/issues/7471

https://github.com/opencontainers/runtime-spec/issues/1122

https://github.com/opencontainers/runc/issues/2151

runc does have some hacky code in order to try and figure out if a syscall is supported or not but the method is not always reliable and we have seen at Canonical reports of Ubuntu Noble containers breaking under Ubuntu Jammy hosts on ARM as well as PPC .
This issue currently affects all fixed release distros which also happen to be the most popular distros for running containers, and for these distros updating libseccomp for every new syscall provides an unnecessary risk of regression and defeats the whole purpose of a fixed released distro.
I understand that changing the current defaultErrnoRet to ENOSYS may also cause  regressions, however it also needs to be acknowledged that the EPERM default value was an oversight and that the OCI spec is fundamentally not compatible with fixed release distros which are the most popular distros for running containers. It also violates one of the most fundamental rules/expectations of containers which is to be able to run any version of a user-space whether it is older or newer than the version on that host.
Having said that, I believe there is a way to satisfy both camps. A list of the currently available syscalls (up to kernel 6.10 as of the writing of this post) can be compiled and be manually set as EPERM for those who were relying on the default EPERM return value while having the others unchanged in the seccomp profiles. This means that when changing defaultErrnoRet to be ENOSYS all previously available syscalls will still return EPERM while newer added ones or even older ones that are defined in the seccomp profile but not known by the libseccomp package on the host will return the correct ENOSYS.
As an example, this can be expressed as the following in the runtime spec:

defaultErrnoRet (uint, OPTIONAL) - the errno return code to use.
Some actions like SCMP_ACT_ERRNO and SCMP_ACT_TRACE allow to specify the errno code to return.
When the action doesn't support an errno, the runtime MUST print and error and fail.
If not specified then its default value is EPERM for syscalls prior to kernel 6.11 and ENOSYS for future ones.

This means that anyone currently using the spec will see no change to their containers since they are all using syscalls from linux 6.10 and below. But it also means that newer containers using post 6.10 syscalls will return the expected ENOSYS error limiting the issue.
Also the spec should define the behavior to follow if the syscall name is not known to the host. I believe the spec should explicitly define ENOSYS for such syscalls, and I am planning on working on a kernel driver that would expose to user-space the list of supported syscalls by the kernel, making it easier to determine the return value of each syscall.

We discussed switching to -ENOSYS in general and just doing -EPERM for a limited subset of syscalls in a specific kernel version before (my proposal was Linux 3.0, but I suspect now that it's been a few years it might make sense to pick Linux 4.0 or 5.0 as a baseline).
The roadblock we ran into is that libseccomp didn't provide enough facilities to make this work seamlessly. https://github.com/seccomp/libseccomp/issues/11 and https://github.com/seccomp/libseccomp/issues/286 are the upstream issues where this topic was discussed. In short, there are a few key issues:

libseccomp has no mechanism to create a rule like if nr > X && no_other_rules_matched { return -ENOSYS }. This means that there is no trivial way to create a filter with libseccomp that returns -EPERM by default for syscalls that were available in kernel version X, and -ENOSYS otherwise.
You might think that we could then just create a rule for every syscall that was not mentioned in the filter. This works for simple syscalls where the filter allows the syscall for all arguments, but for syscalls where only some arguments are permitted and otherwise they are blocked, you would need to construct inverse rules to return -EPERM (this is true for all syscalls regardless of age -- it wouldn't make sense to return -ENOSYS for a syscall that you permit some flags for). Unfortunately libseccomp does not allow this in general:

libseccomp lacks the ability to do an inverse mask check. See https://github.com/seccomp/libseccomp/issues/310. This is needed for very common seccomp rules. You can work around this by generating an exponential number of rules to cover all possible cases, but that won't work in general.
libseccomp does not have the ability to create the complicated boolean expressions you need to create an inverse rule in general. From memory the issue is that you cannot create independent or epxressions, because libseccomp combines rules for the same syscall (this is not well documented IIRC).

(Minor) libseccomp used to not provide information about the set of syscalls available for a given kernel version. They have now added this information in csv files (in response to this issue) but there is still no API to get this information. We could just copy these csvs into every runtime project, but it would be nice if there was an API for this.

runc does have some hacky code in order to try and figure out if a syscall is supported or not but the method is not always reliable and we have seen at Canonical reports of Ubuntu Noble containers breaking under Ubuntu Jammy hosts on ARM as well as PPC .

When working on the "hacky" runc code to work around these problems, I tried many approaches and rewrote the code several times. I tried to implement a minimum-kernel-version setup several times (including coming up with very complicated mechanisms to generate inverse rules) and came to the conclusion that it is not possible to implement this with libseccomp currently, and that this needs to be implemented by libseccomp itself. I also tried to come up with a different patching system that just patched return statements but that also doesn't work in general and required modifying too much of the libseccomp filter (which could lead to bugs as well).
The best solution we have at the moment is for runtimes to use -ENOSYS for defaultErrnoRet so that we don't need to do these awful workarounds. Docker was supposed to switch to this but it seems that never happened after this patch by @rata. However, podman/cri-o do use -ENOSYS.
Regarding the ARM and PPC issues you mentioned -- we did fix a bug related to ppc64le recently that might also have affected ARM. Please verify whether that patch fixes the issue you mentioned, and if not please submit a bug report to runc directly.
While I don't like that code, having a maximum kernel version would require very similar code unless we add support for all of this to libseccomp directly. The reason we implemented it in runc without pushing it to the runtime-spec is because the libseccomp folks said they were working on it and so we opted to wait for libseccomp to be ready before we define the right behaviour in the spec.

I am planning on working on a kernel driver that would expose to user-space the list of supported syscalls by the kernel, making it easier to determine the return value of each syscall.

In theory you can already get this information from BTF if you really want to. However, you don't actually need the current set of syscalls on the running kernel to solve this problem, you need historical data so you can set a minimum kernel version.


Feature Request: Add option for 'godep save' to create dependency list without coping source code

I would like an option for 'godep save' to generate the dependency list (godeps.json) without creating the _workspace folder. I can always use 'godep restore' to get the pinned dependencies and don't need to save them in _workspace folder.

+1

Yeah, I don't understand the point of saving the source code if godep restore is just going to check it out from the repo anyway? Is it just in case the repo goes away? If so, just restore the files form the workspace and don't bother checking it out.

+1

If anything the _workspace folder and restore are going away with the advent of the vendor/ directory. You can't make reproducible builds if the code is not vendored, and that is the point of godep, so unfortunately -1.
AFAIK: godep restore is there as a relic of the past. If I can make it go away (and I haven't spent the requisite time yet) it will.


Any way to extract queryId from result / rows?

Problem summary:
I am trying to get the query ID back from Trino, and I am calling the QueryContext method. The implementing Rows struct in the Trino code seems to not send it back in anyway that I can find.
Question:
Can I extract the query ID when using something like this? If so, how?
	rows, err := trinoDB.QueryContext(ctx, selectStmt, placeholders...)
	if err != nil {
		return nil, err
	}
	cols, err := rows.Columns()
	if err != nil {
		return nil, err
	}
	for rows.Next() {
             ...
        }

You have to use a progress update callback, since it receives the query ID. Unfotunately, it's not documented yet, but you can check out this test for an example usage: https://github.com/trinodb/trino-go-client/blob/master/trino/trino_test.go#L288


Refactor redundant query closure

It is possible to use limit, offset clause in Insert into Table Select ~ sentence.
So, remove redundant query closure.
let query = || Query {
                            body: SetExpr::Select(select_query.clone()),
                            limit: None,
                            offset: None,
                        };

Codecov Report

Merging #466 (7c864d5) into main (25c147e) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #466      +/-   ##
==========================================
- Coverage   91.06%   91.05%   -0.02%
==========================================
  Files         159      159
  Lines        9247     9243       -4
==========================================
- Hits         8421     8416       -5
- Misses        826      827       +1

Impacted Files
Coverage Δ

core/src/executor/execute.rs
66.86% <50.00%> (-1.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25c147e...7c864d5. Read the comment docs.


Problem with infra-integrations-analysis

Error generated when trying to import this dashboard into a customers account. Note: I have tried importing this dash while impersonating as a customer and in my own personal sandbox where I wasn't impersonating. I have attached a screenshot of the error produced.

Issue ref: https://github.com/newrelic/nr1-quickstarts/issues/57


Mysql keyword cannot be parsed if there is one in the table field

If there is a MySQL keyword in the table field, the SQL statement cannot be parsed, but the insert statement can cause a select error.
for example：
insert table_name (id,code,time)
select id,code,time from table_name
Select can't be parsed, don't follow the rule of PreciseShardingAlgorithm

now do not support insert select


Cannot access openapi.json

Hi,
I am pretty sure I am doing something wrong... The /openapi.json isn't accessible. Here is how I set it up:
CoroutineScope(coroutineContext).embeddedServer(
                Netty,
                port = port,
                parentCoroutineContext = coroutineContext,
            ) {
              routing {
                ... other plugins
                this@embeddedServer.install(NotarizedApplication()) {
                        spec =
                            OpenApiSpec(
                                info = Info(
                                    title = "title", version = "1.2.3", summary = "summary", description = "description",)
                            )
                    }

Strangely documentation says to do:
spec = {
        OpenApiSpec(
        // ...
      )
    }

which does not compil.
Any idea what's wrong?
Thanks

sorry the docs are in a weird state as they are getting built out for 4.0, but currently that release has not happened yet.
for now you can reference the 3.x docs by referencing the code at the final release for 3.x
https://github.com/bkbnio/kompendium/tree/v3.14.4/docs


Move observation of properties of Transformable, et al, out of those classes.

Perhaps come up with an external observation mechanism (f.e. an Observer class that can observe other objects, or perhaps an Observable class that we can mix in), or at least just add a hook to the Transformable and related classes that will call a supplied external function on property changes similar to the XYZValues class.
Then we can move the this._needsToBeRendered() calls out of the Transformable classes (probably place into ImperativeBase), which will decouple the Transformable classes from Motor stuff and make the classes simply re-usable anywhere (f.e. outside of Motor).

Done, because we're using class-factory mixins, the Observable class is effectively external and decoupled from the Transformable class. The Transformable class triggers "propertychange" events, for example.


odo list -o json does not list devfile components, but 'odo list' does

/kind bug

What versions of software are you using?
Operating System: Linux
Output of odo version:  v2.0.0-alpha-2 (00d408ece)
How did you run odo exactly?
denis@denis-ThinkPad-P50:~/p/test-ws/nodejs-ex$ ~/p/vscode-openshift-tools/out/tools/linux/odo list -o json
{
	"kind": "List",
	"apiVersion": "odo.dev/v1alpha1",
	"metadata": {},
	"items": [
		{
			"kind": "Component",
			"apiVersion": "odo.dev/v1alpha1",
			"metadata": {
				"name": "component1",
				"namespace": "project156",
				"creationTimestamp": null
			},
			"spec": {
				"app": "app1",
				"type": "nodejs",
				"sourceType": "local",
				"url": [
					"url11"
				],
				"env": [
					{
						"name": "DEBUG_PORT",
						"value": "5858"
					}
				]
			},
			"status": {
				"state": "Pushed"
			}
		}
	]
}
denis@denis-ThinkPad-P50:~/p/test-ws/nodejs-ex$ ~/p/vscode-openshift-tools/out/tools/linux/odo list
Devfile Components:
APP      NAME          PROJECT        TYPE       STATE
app1     nodejs-ex     project156     nodejs     Pushed

Openshift Components:
APP      NAME           PROJECT        TYPE       SOURCETYPE     STATE
app1     component1     project156     nodejs     local          Pushed

Actual behavior
No nodejs-ex component in json output compared to normal output
Expected behavior
Both outputs reports the same components
Any logs, error output, etc?
N/A

This should be addressed in https://github.com/openshift/odo/issues/3521


Make "invalid base value" more informative

Currently the invalid base value error is a bit too vague--it doesn't tell you the name of the variable that you're trying to access and is just in general very difficult to diagnose.  Would it be possible to reword this error message to make it clearer, something like what SpiderMonkey says in this case: 'varName' has no properties

Some discussion in #253.

Possible concrete change:

Add config option to include property key for "invalid base value" error, with default enabled.
Note in sandboxing document that if keys can be sensitive, turn the option off.
Reword the error message to indicate it's a property lookup error.

Regarding the security discussion in the other thread: I think convenience should definitely be the default, with documentation on how to turn those features off.  I mainly worry that focusing too much on security may lull users into a false sense of security where they think that just because the engine is secure they don't have to follow best-practices.  I've seen that happen too often.


No coverage job for platform-api-operator

What this PR does / why we need it:
Platform API operator is a helm operator, so there are no unit tests, which means code coverage does not apply. Removing the coverage job from this operator's PROW builds.
Also removed ibm-cloudctl-operator because platform-api-operator replaces it.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Specify your PR reviewers:

/cc @gyliu513 @morvencao @clyang82
Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

@cheewaio FYI


Rename "master" branch

This repo is still using master as the default/primary branch, and should switch to main.

While I understand the motivation for moving to master, we need to confirm that Metecho will work with Main or Master. We got stuck on https://github.com/SFDO-Tooling/Metecho/issues/2083 for a bit and I'd like to make sure everything is running smoothly before the next virtual community sprint March 29 & 30.


[FLINK-9936] Resource manager connect to mesos after leadership granted. .

What is the purpose of the change
This PR fixes a bug in mesos resource manager which makes it unable to connect to mesos after failover.
Brief change log

Add onLeadershipGranted callback in resource manager.
Add onLeadershipRevoked callback in resource manager.

Verifying this change
This change added tests and can be verified as follows:

Manually verified the change by running a cluster on mesos, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency):  no
The public API, i.e., is any changed class annotated with @Public(Evolving):  no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper:  yes
The S3 file system connector:  no

Documentation

Does this pull request introduce a new feature? no

I'll take a look today.

@GJL Thanks for the review. It's ok for you to take over it.


Allow face bones to be translated

The natural heuristic is probably to allow translating joints that meet all these conditions:

They have a sibling (i.e. the parent has multiple child joints).
They have no children themselves (they are the last joint on the chain).

Or maybe allow any terminal joint to be translated?

Also would have to enable a translate manipulator. I think the use case for allowing both rotate/translate is rare, so we would choose for the user whether to rotate or translate, i.e., if translate allowed then don't ever rotate.

Looks like the MFnFreePointTriad is horribly broken. I'll need to implement my own manipulator if I want to do translation. :anguished:

Custom manipulator implemented!


[Feature Request] Add a flag to preserve or disable conceallevel

Hello,
I've read through this issue that asked for conceallevel to be disabled.
However, plugins like oil.nvim use conceallevel (for some IDs), which causes leap to look like this:

I would like to request a flag that allows users to either preserve the conceallevel of the target buffer or disable it.
Thank you!

Related: https://github.com/justinmk/vim-sneak/issues/30

Here is a non-perfect workaround:
vim.api.nvim_create_autocmd('User', {
    pattern = 'LeapEnter',
    callback = function ()
        vim.schedule(function()
            vim.opt.conceallevel = 3
            vim.cmd.redraw()
        end)
    end,
})

But I find it to be pretty alright, at least until this feature is properly implemented


Exporting to .GIF

Thank you creating and sharing this plugin. I'm new to Sketch and I'm trying to create a simple animation for a research project but I'm unable to export the file to .gif. However, when I export .png I can see all the images so I'm doing something right, but .gif won't work. This happens regardless of how small/simple my animation is. I'm running the trial version of Sketch on Sierra, for what it's worth. Any help would be much appreciated.

Thanks you for letting me know this! I haven't installed Sierra yet. So I do not know if it's because of Sierra or something else. I'll install Sierra soon and test it out.

Yep, I can confirm that GIF exporting doesn't work with new macOS Sierra and sketch. I tested out sketch with sketch version 3.7-40.  PNG image sequence works properly.
At the moment I'm not sure where's the problem. Conversion process uses sips terminal commands. Is it because sketch or sierra, don't know yet.

Gif exporting working for me in Sketch 40.1 with El Capitan 10.11.3

Ok, now updated command a little bit and it seems to work again for me with Sierra and Sketch 40.1. Problem was in terminal command where using sips conversion. It doesn't save converted gif images anymore for some reason. I'm not so familiar with that terminal black magic.
Please report if you get problem again.

I have this problem

I have this same problem. Running Sketch 44 on Sierra.


Pass SSL properties from Glue Connection to MySQL

Issue #554:
Description of changes:
Pass SSL properties from Glue Connection to PyMySQL. ~~Depends on this PyMySQL PR merged & released first. ~~
UPD: In conversation with PyMySQL contributors it seems it's possible to pass SSLContext to PyMySQL so extra argument is not required anymore.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-sDRE8Pq0duHT
Commit ID: 735ad12df22f42d50713a9168739e79dd8bb0dd8
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-sDRE8Pq0duHT
Commit ID: 35706a3494fb0a4188d76061ef268a1d3d1ba40c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-sDRE8Pq0duHT
Commit ID: cd1954075bc724a8d7c6387bce1620b82c900220
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido CB failed here because a new aws-data-wrangler-mysql-ssl connection that I added in this PR isn't available in the test infra yet. How do we usually go about it? Do I need to deploy manually?

Ideally, we would want to make this change permanent if it will be needed for future tests. So I would add/modify the cloudformation template holding the connections first (you can change it as part of this PR). I would then update the stack in the AWS account we are using for testing

That modification is already there (see diff). All, right, I'll update it in the account then.

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-sDRE8Pq0duHT
Commit ID: cd1954075bc724a8d7c6387bce1620b82c900220
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-sDRE8Pq0duHT
Commit ID: cd1954075bc724a8d7c6387bce1620b82c900220
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-sDRE8Pq0duHT
Commit ID: cd1954075bc724a8d7c6387bce1620b82c900220
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Apache Subdomain Routing

Hello
I have pretty much completed most of my development on my local machine (Macbook) , and all seems good and works as expected.
I am trying to set it up on an Apache webserver and I am having issues with routes.
There is manual identification switching databases on load which all works fine on local and on the server.
All my routes work on the root application e.g myproject.com , myproject.com/dashboard , myproject.com/users etc
The login route works on all of my tenant applications e.g client1.myproject.com/login , the user is being authenticated correctly but no routes work after this , no errors are thrown it just keeps trying to redirect too many times.
It seems to be something to do with any route that is protected with a middleware for authentication
Any help would be greatly appreciated.

It seems to be an issue with another library , in this case spatie permissions


feat: port NumberTheory.NumberField.Basic

[ ] depends on: #5304

This PR/issue depends on:

leanprover-community/mathlib4#5304
By Dependent Issues (🤖). Happy coding!

This PR/issue depends on:

leanprover-community/mathlib4#5304
By Dependent Issues (🤖). Happy coding!

bors merge


The SocketAwaitable class seems to be leaking resources.

The SocketAwaitable class seems to be leaking resources in #SNMP v 9.0.3.
I think it is probably caused by strong reference.
public SocketAwaitable(SocketAsyncEventArgs eventArgs)
{
    if (eventArgs == null)
    {
        throw new ArgumentNullException(nameof(eventArgs));
    }

    this.m_eventArgs = eventArgs;
    eventArgs.Completed += delegate   // <----- strong reference?
    {
        var prev = m_continuation ?? Interlocked.CompareExchange(
            ref m_continuation, SENTINEL, null);
        if (prev != null) prev();
    };
}

It might be better to do the following:
public SocketAwaitable(SocketAsyncEventArgs eventArgs)
{
    if (eventArgs == null)
    {
        throw new ArgumentNullException(nameof(eventArgs));
    }

    this.m_eventArgs = eventArgs;

    // Instead of anonymous method, change to private method...
    eventArgs.Completed += this.eventArgs_Completed;
}
private void eventArgs_Completed(object sender, SocketAsyncEventArgs e)
{
    var prev = m_continuation ?? Interlocked.CompareExchange(
        ref m_continuation, SENTINEL, null);
    if (prev != null) prev();
}
internal void Reset()
{
    // Release event handler at reset...
    this.m_eventArgs.Completed -= this.eventArgs_Completed;
    this.m_wasCompleted = false;
    this.m_continuation = null;
}

How is it?

First, I don't think that causes a memory leak. I have previously used dotMemory to prove, https://blog.lextudio.com/2015/06/analysis-on-a-snmp-library-memory-leak-report-with-jetbrains-dotmemory/ If you do observer leak via a profiler, please provide more details.
Seconds, after compilation the compiler already creates an instance method (like your handwritten private method), so your change is unnecessary.  You might refer to https://blogs.msdn.microsoft.com/oldnewthing/20060802-00/?p=30263

Thanks for quick reply.

If you do observer leak via a profiler, please provide more details.

I prepared details that seems to be memory leak.
I ran it in the situation where the following timeout occurs:

The SNMP agent exists on host B, but it is not running.
Running my test code (Console App) on host A.

My test code snippet is below:
var response = await message.GetResponseAsync(new IPEndPoint(IPAddress.Parse("IP OF HOST B"), 161))
    .WithCancellation(cts.Token)
    .ConfigureAwait(false);

The snapshot with dotMemory is below:

Compare snapshots

Object Set(SocketAwaitable)

I think it is leaking with SocketAwaitable, is it wrong?

SocketAwaitable has its life span as local variable in all allocations. Thus, it should be freed automatically (though it can be slow).
I just made an experimental commit c8cba7e2513f3bc839441f59fabb9da5740c7401 which changes both how SocketAsyncEventArgs and SocketAwaitable are handled. You can test that out, and should observe significant less objects in the heap.

I tried c8cba7e. It certainly seems that there is no problem if the SNMP Agent on the remote host responds.
However, if the SNMP Agent on the remote host does not respond (e.g. snmpd.exe is not listening), it still leaks.
Apparently, if CancellationTokenSource caused an OperationCanceledException exception, it seems that the socket in the GetResponseAsync(this ISnmpMessage, IPEndPoint) method has not been disposed.
Perhaps it may be necessary to overload the GetResponseAsync method to receive CancellationToken.
e.g.
public static async Task<ISnmpMessage> GetResponseAsync(this ISnmpMessage, IPEndPoint, CancellationToken)

I don't see an easy fix yet. Probably it can only be resolved after more investigation.

With a slightly different approach, I tried the following:
                using (var linkedCts = CancellationTokenSource.CreateLinkedTokenSource(this.cts.Token, cancellationToken))
                using (var client = UdpClientWrapper.CreateClient())
                {
                    var sendingBytes = request.ToBytes();
                    var sendingTask = client.SendAsync(sendingBytes, sendingBytes.Length, remoteEndPoint);
                    var sentBytesSize = await sendingTask.WithCancellation(linkedCts.Token).ConfigureAwait(false);

                    var receivingTask = client.ReceiveAsync();
                    var receiveResult = await receivingTask.WithCancellation(linkedCts.Token).ConfigureAwait(false);

                    var reply = receiveResult.Buffer;
                    var registry = new UserRegistry();
                    var response = MessageFactory.ParseMessages(reply, 0, receiveResult.Buffer.Length, registry)[0];

                    var responseCode = response.TypeCode();
                    if (responseCode == SnmpType.ResponsePdu || responseCode == SnmpType.ReportPdu)
                    {
                        var requestId = request.MessageId();
                        var responseId = response.MessageId();
                        if (responseId != requestId)
                        {
                            throw OperationException.Create(string.Format(CultureInfo.InvariantCulture, "wrong response sequence: expected {0}, received {1}", requestId, responseId), remoteEndPoint.Address);
                        }

                        return response;
                    }

                    throw OperationException.Create(string.Format(CultureInfo.InvariantCulture, "wrong response type: {0}", responseCode), remoteEndPoint.Address);
                }

The complete code is below:
my tried code
The amount of change may be large, but is it likely to be useful?

I found the same issue.
Do you plan any fix?

This is a problem in my use case also. If the SNMP target is down for a long time this leaks memory until you start getting out of memory exceptions.

I would love a fix for this as well, but for now I am going to try the solution from @MareMare

I have been using the fix from @MareMare for a while now, but I am (very) occasionally getting Out Of Memory Exceptions. I'm not 100% sure that this exact fix has been the problem (still trying to gather more information). I was kind of wondering if anyone else with the same solution has had issues as well as if this is still in the plans to be resolved?


Build log output cuts off after 65535 bytes

I have a build script that makes a python virtualenv to test in. I'm trying to decrease its verbosity, but currently it's spewing lots of lines from some manual library installs, and it seems that everything after 65535 characters gets lopped off. The live update view works great, but as soon as success is reported, the actual test results get cut off.

Thanks for the issue report. This issue has already been fixed in newer versions of GitLab. Due to the size of this project and our limited resources we are only able to support the latest stable release as outlined in our contributing guidelines. In order to get this bug fix and enjoy many new features please upgrade. If you still experience issues at that time please open a new issue following our issue tracker guidelines found in the contributing guidelines.