[G7T5-133] FE for HR View All Skills

Description
Fixes https://is212g7t5.atlassian.net/browse/G7T5-133

Type of change

[ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

[ ] I have added the corresponding testcases into the testcase document

Checklist:

[ ] I have added the appropriate labels to my PR
[ ] My code follows the style guidelines of this project
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Everything looks good! You can consider formatting using prettier if you want.


Export as CSV is missing some data

This is displayed in text mode:
com.apple.quicktime.make                 : Apple
com.apple.quicktime.model                : iPhone 12 mini
com.apple.quicktime.software             : 14.6
com.apple.quicktime.creationdate         : 2021-06-26T14:14:20+0200
com.apple.photos.originating.signature   : AfUM3rw2hB2SlNdNEoYVIBhyqcPC

Though, it is not exported into CSV. "creationdate" is the important part here, as EncodedDate is not the same.
Using MediaInfo 21.09

For the moment default CSV output does not provide unsupported fields i.e. the fiels you are looking for (they are extracted "as is" from the file).
But com.apple.quicktime.creationdate could be mapped to Encoded_Date MediaInfo field so exported.
But... How could the current Encoded_Date be different from com.apple.quicktime.creationdate? Seems to be same, maybe just more precise
Please share a sample file so I can have a view on the differences.

Guess there is some Apple-magic involved...
https://mega.nz/file/pl1mVCqb#6V0dfS6yJWOoegMB70Hx2trX70DP4MlLiWzNYoTbrM0

So you recorded the content ("The date the movie file content was created.", fun fact: the example provided by Apple is not same, the example is "4/21/2012" so another formatting, so easy) on August 26, right?
What did you do with this file on September 23?
I have another field Recorded_Date, I guess it would be a good mapping.

This is a recording from my wife, so I'm not sure about the exact date, but August 26 should be correct.
I guess she copied the file from her iPhone on September 23 (don't know if that was via iTunes or anything else).

A copy should not change the file content, only the file modification date (another field).
Apple mystery...

Just wanted to add some additional info on my personal findings. The com.apple.quicktime.creationdate attribute, if present, actually is the MOST accurate attribute that represents the original video creation date. The reason why this can get out of sync with the Encoded_Date attribute and/or the file creation date is that Apple mobile devices can be configured to re-encode video files to different (more compatible) formats when they are exported from the devices.
When this option to re-encode videos is set by the user on an Apple mobile device, then the com.apple.quicktime.creationdate attribute becomes the ONLY remaining attribute that properly keeps track of when the video was originally captured. The Encoded_Date attribute and the file creation dates change in this condition to be the date that the video was exported from the mobile device (useless information as far as I'm concerned, but unfortunately information that is preserved in the video's Encoded_Date standard attribute that is commonly checked when the file creation date can no longer be trusted).
FYI, to other users who stumble here wishing they could export the com.apple.quicktime.creationdate attribute using MediaInfo, you have an alternative called "ExifTool" created by Phil Harvey that will export this attribute into a variety of user-specified output formats.


Do not store return values in locals so that holders benefit from lifetime extension for temporaries.

Closes #3138

I am also fine with leaving that for the future

I'd like to limit ourselves to the fix for now as I am seeing an obvious simplification by trying to extract the ok wrapping ATM.
bors r=davidhewitt

bors retry

bors retry


Test check list for SQL connector

[x] Integration Tests #7
[x] Publish Job #8

@sehz can this be closed?


JPA support

I created a simple JAX-RS + JPA app.
https://github.com/emag/wildfly-swarm-quickstarts/tree/master/jaxrs-jpa
I use @ PersistenceContext for injection EntityManager but not injected.
It seems it is needed JPA Fraction. In WildFly Distro, a single persistence unit  is automatically discovered.
I've got the following log.
$ git clone https://github.com/emag/wildfly-swarm-quickstarts && cd wildfly-swarm-quickstarts/jaxrs-jpa/
$ mvn clean package && java -jar target/jaxrs-jpa-*-swarm.jar
...
2015-05-14 02:14:51,421 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-5) MSC000001: Failed to start service jboss.deployment.unit."jaxrs-jpa-1.0.0.war".WeldStartService: org.jboss.msc.service.StartException in service jboss.deployment.unit."jaxrs-jpa-1.0.0.war".WeldStartService: Failed to start service
	at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1904)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.IllegalArgumentException: WFLYWELD0037: Error injecting persistence unit into CDI managed bean. Can't find a persistence unit named '' in deployment jaxrs-jpa-1.0.0.war for injection point private javax.persistence.EntityManager wildflyswarm.jaxrsjpa.domain.repository.EmployeeRepository.em
	at org.jboss.as.weld.services.bootstrap.WeldJpaInjectionServices.getScopedPUName(WeldJpaInjectionServices.java:111)
	at org.jboss.as.weld.services.bootstrap.WeldJpaInjectionServices.registerPersistenceContextInjectionPoint(WeldJpaInjectionServices.java:74)
	at org.jboss.weld.injection.ResourceInjectionFactory$PersistenceContextResourceInjectionProcessor.getResourceReferenceFactory(ResourceInjectionFactory.java:313)
	at org.jboss.weld.injection.ResourceInjectionFactory$PersistenceContextResourceInjectionProcessor.getResourceReferenceFactory(ResourceInjectionFactory.java:301)
	at org.jboss.weld.injection.ResourceInjectionFactory$ResourceInjectionProcessor.createFieldResourceInjection(ResourceInjectionFactory.java:207)
	at org.jboss.weld.injection.ResourceInjectionFactory$ResourceInjectionProcessor.createResourceInjections(ResourceInjectionFactory.java:182)
	at org.jboss.weld.injection.ResourceInjectionFactory.discoverType(ResourceInjectionFactory.java:405)
	at org.jboss.weld.injection.ResourceInjectionFactory.getResourceInjections(ResourceInjectionFactory.java:92)
	at org.jboss.weld.injection.producer.ResourceInjector.<init>(ResourceInjector.java:59)
	at org.jboss.weld.injection.producer.ResourceInjector.of(ResourceInjector.java:49)
	at org.jboss.weld.injection.producer.BeanInjectionTarget.<init>(BeanInjectionTarget.java:62)
	at org.jboss.weld.injection.producer.BeanInjectionTarget.createDefault(BeanInjectionTarget.java:46)
	at org.jboss.weld.manager.InjectionTargetFactoryImpl.chooseInjectionTarget(InjectionTargetFactoryImpl.java:128)
	at org.jboss.weld.manager.InjectionTargetFactoryImpl.createInjectionTarget(InjectionTargetFactoryImpl.java:87)
	at org.jboss.weld.bean.ManagedBean.<init>(ManagedBean.java:100)
	at org.jboss.weld.bean.ManagedBean.of(ManagedBean.java:80)
	at org.jboss.weld.bootstrap.AbstractBeanDeployer.createManagedBean(AbstractBeanDeployer.java:264)
	at org.jboss.weld.bootstrap.BeanDeployer.createClassBean(BeanDeployer.java:228)
	at org.jboss.weld.bootstrap.ConcurrentBeanDeployer$2.doWork(ConcurrentBeanDeployer.java:78)
	at org.jboss.weld.bootstrap.ConcurrentBeanDeployer$2.doWork(ConcurrentBeanDeployer.java:75)
	at org.jboss.weld.executor.IterativeWorkerTaskFactory$1.call(IterativeWorkerTaskFactory.java:60)
	at org.jboss.weld.executor.IterativeWorkerTaskFactory$1.call(IterativeWorkerTaskFactory.java:53)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	... 3 more

I consider JAX-RS, JPA and CDI to be the absolute basics which should be supported fully. Without this functionality you can not do anything meaningful really ... Would you be so nice and support that please?

We welcome all PRs, especially for additional functionality!
As we're working on other tasks, it's the fastest way to enable new functionality sooner.
Thanks
Ken

@kenfinnigan  Thanks you for your reply. OK, I'll try it :)

JPA support is very essential, and would love to see this coming through.

Now I'm working on creating JPA Fraction and I've got a problem.
In using WildFly-Swarm, you must create a class has main() for setting datasource(e.g. example-datasource),  the application packaging must be jar and, -Swarm will transform the app from jar to war.
When PersistenceUnitParseProcessor parse a persistence.xml included the app, it checks the app packaging(deployment) type. As mentioned above,  your app deployment type is war so PersistenceUnitParseProcessor treats your app as war deployment and checks /your-app.war/WEB-INF/classes/META-INF/persistence.xml. Thus, persistence.xml is taken as not existing.
Any idea?
related code

https://github.com/wildfly/wildfly/blob/9.0.0.CR1/jpa/src/main/java/org/jboss/as/jpa/processor/PersistenceUnitParseProcessor.java#L75

https://github.com/wildfly/wildfly/blob/9.0.0.CR1/jpa/src/main/java/org/jboss/as/jpa/processor/PersistenceUnitParseProcessor.java#L89

https://github.com/wildfly/wildfly/blob/9.0.0.CR1/jpa/src/main/java/org/jboss/as/jpa/processor/PersistenceUnitParseProcessor.java#L134

@emag, could you provide a link to your current code?

@kenfinnigan
https://github.com/emag/wildfly-swarm/tree/add-jpa-fraction-spike/fractions/jpa
And, I'm going to remove some codes because these are not resource but attributes.

Your app can be natively a war also. See the example-servlet?
--
Sent from my iPhone

On May 20, 2015, at 2:05 AM, emag<EMAIL_ADDRESS>wrote:
Now I'm working on creating JPA Fraction and I've got a problem.
In using WildFly-Swarm, you must create a class has main() for setting datasource(e.g. example-datasource), the application packaging must be jar and, -Swarm will transform the app from jar to war.
When PersistenceUnitParseProcessor parse a persistence.xml included the app, it checks the app packaging(deployment) type. As mentioned above, your app deployment type is war so PersistenceUnitParseProcessor treats your app as war deployment and checks /your-app.war/WEB-INF/classes/META-INF/persistence.xml. Thus, persistence.xml is taken as not existing.
Any idea?
related code
https://github.com/wildfly/wildfly/blob/9.0.0.CR1/jpa/src/main/java/org/jboss/as/jpa/processor/PersistenceUnitParseProcessor.java#L75
https://github.com/wildfly/wildfly/blob/9.0.0.CR1/jpa/src/main/java/org/jboss/as/jpa/processor/PersistenceUnitParseProcessor.java#L89
https://github.com/wildfly/wildfly/blob/9.0.0.CR1/jpa/src/main/java/org/jboss/as/jpa/processor/PersistenceUnitParseProcessor.java#L134
—
Reply to this email directly or view it on GitHub.

@bobmcwhirter If I package my app as war, how can I set datasources ?

Sweet, sample code?

@arun-gupta was about to email you!
https://github.com/wildfly-swarm/example-jpa-servlet
So for the moment i've only tested with servlet, but should be easy enough to create examples with CDI and JAX-RS now it's working

All requires HEAD of wildfly-swarm built from GitHub at the moment.

On May 28, 2015, at 4:33 PM, Ken Finnigan<EMAIL_ADDRESS>wrote:
@arun-gupta https://github.com/arun-gupta was about to email you!
https://github.com/wildfly-swarm/example-jpa-servlet https://github.com/wildfly-swarm/example-jpa-servlet
So for the moment i've only tested with servlet, but should be easy enough to create examples with CDI and JAX-RS now it's working
—
Reply to this email directly or view it on GitHub https://github.com/wildfly-swarm/wildfly-swarm/issues/23#issuecomment-106587679.

Exciting times, will play with it!

#35 is blocking to test this functionality.

@kenfinnigan  Awsome!
And, I use subsystem version like example-datasource-subsystem. perfectly works :)
https://github.com/emag/wildfly-swarm-quickstarts/blob/master/jaxrs-cdi-jpa/src/main/java/wildflyswarm/jaxrscdijpa/App.java#L22-L31


feat(nestjs-query): implement getApiUrl

changed ,
// getApiUrl: () => {
//   throw Error("Not implemented on refine-nestjs-query data provider.");
// },
to
getApiUrl: () => {
return client.getApiUrl();
},
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://refine.dev/docs/guides-concepts/contributing/#commit-convention

Bugs / Features

[x] Related issue(s) linked
[x] Tests for the changes have been added
[ ] Docs have been added / updated
[x] Changesets have been added https://refine.dev/docs/guides-concepts/contributing/#creating-a-changeset

What is the current behavior?
What is the new behavior?
fixes #5606
Notes for reviewers

@yess-wee Any chance for you to work on this PR? We're hoping to include this in our May release if you can resolve the errors and provide a changeset 🙏

Closing this due to inactivity


DLF is now datashim

DLF moved to https://github.com/datashim-io/datashim
We should update installation and the imported package accordingly.

@shlomitk1 do you want to take this?


Catch all possible exceptions while binding SocketClient

Addresses issue.
Cannot say that this is the fix, because I was not able to reproduce the crash locally. But can assure that, with this patch we no longer see the same crash.

@rimzici, thanks for the PR, but there is no need for catching exceptions in SocketClient since they are already caught on UdpSockets.java bind() function. If an error is thrown, that's the correct functionality.


Remove deprecated cirdrlist parameter from createLoadBalancerRule API

ISSUE TYPE

Improvement Request
Documentation Report

COMPONENT NAME

API

CLOUDSTACK VERSION

4.11
and all later versions

CONFIGURATION

N/A
OS / ENVIRONMENT

N/A
SUMMARY

Some networking-related APIs, notably createLoadBalancerRule, support a parameter called cidrlist. This parameter was (presumably) used to automatically manage firewall rules for load balancer rules.
The parameter is deprecated since at least ACS 4.11, leading to an error when trying to use it.
STEPS TO REPRODUCE

create loadbalancerrule publicipid=yyy algorithm=leastconn name=test-lb publicport=9999 privateport=9999 cidrlist=<IP_ADDRESS>/32

Specifying openfirewall=true makes no difference.

EXPECTED RESULTS

CloudStack should create a firewall rule for the load balancer.
If this is no longer supported, the parameter should be removed.
ACTUAL RESULTS

cloudmonkey prints the following error:
🙈 Error: (HTTP 431, error code 4350) Parameter cidrList is deprecated; if you need to open firewall rule for the specific CIDR, please refer to createFirewallRule command

OTHER COMMENTS
On a related note, I sent a PR that documents how to send multiple CIDRs in cidrlist: #4035
During preparation of that patch, I identified a few other APIs that use a CIDR_LIST or DEST_CIDR_LIST parameter or return value and may also be affected:

CreateEgressFirewallRule
CreateFirewallRule
CreatePortForwardingRule
CreateLoadBalancerRule
CreateIpForwardingRule
CreateNetworkACL
UpdateNetworkACLItem
AuthorizeSecurityGroupEgress
AuthorizeSecurityGroupIngress
CreateVpnCustomerGateway
UpdateVpnCustomerGateway
FirewallResponse
FirewallRuleResponse
LoadBalancerResponse
NetworkACLItemResponse
Site2SiteCustomerGatewayResponse
Site2SiteVpnConnectionResponse

removal of parameters will only happen in a move to version 5.x (if and when). we can stop the error from being returned and silently ignore the parameter or we can add an informational field that state how it was handled but removing a parameter while we continue to support 4.x is a no-go, @onitake.

well, i'd suggest changing it's description to something like "deprecated, will be ignored", ok?

I'll open a new PR for that, but can you check #4035 as well, if it makes sense?

added a comment on code and one on travis ;)

@onitake do you consider this closed? #4037 is not merged and has a conflict but @4035 is merged.

@onitake do you consider this closed? #4037 is not merged and has a conflict but @4035 is merged.

@onitake closing this, please reopen if needed.


SD card mount point is not mmcplk0p1

The default SD card path from Stream os is /run/media/mmcblk0p1 .
But the phad from bazzite OS is /run/media/(OS user name)/(SD Card Name) .
This is a problem because the program and decky plugins for SteamOS are standardized on it.
Hardware:
Steamdeck (1TB)

That has not been true on SteamOS for many versions now.
They create a symlink to the old path for legacy support reasons which I can verify is working on all of my hardware.

That has not been true on SteamOS for many versions now.
They create a symlink to the old path for legacy support reasons which I can verify is working on all of my hardware.

Perfect, then I can go back to the official Steam OS. Because that doesn't make any sense at all. If the system does not control the standard file paths. This only leads to a lack of decky plugins.

That's fine, when you do please be sure to verify what I said is correct.
I would also like to know which plugins you're having issues with, we test most of them.


fix(ci): Disable husky on CI

:tada: This PR is included in version 1.0.0-staging.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


⚠ Bofrost.lu has degraded performance

In 0f32c7c, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2295 ms

Resolved: Bofrost.lu performance has improved in 8722f5d after 59 minutes.


Funcs in promisify.js

fnPromisifyCallback is documented. The other fn* funcs are not.
Decide if we want the others to be available or not.

Removing funcs other than fnPromisifyCallback. Func parsing will be removed in that one because what we have is too fragile.


[Web Install] Make navigation.install do the right thing for same-origin installation

onbeforeinstallprompt has always had a weirdness in its API: you have to store a reference to the onbeforeinstallprompt event and use that event object to initiate the prompt.
Code sample from MDN:
let installPrompt = null;
const installButton = document.querySelector("#install");

window.addEventListener("beforeinstallprompt", (event) => {
  event.preventDefault();
  installPrompt = event;
  installButton.removeAttribute("hidden");
});
installButton.addEventListener("click", async () => {
  if (!installPrompt) {
    return;
  }
  const result = await installPrompt.prompt();
  console.log(`Install prompt was: ${result.outcome}`);
  installPrompt = null;
  installButton.setAttribute("hidden", "");
});

It would be nice if navigator.install() would do the right thing for same-origin installation as well, perhaps with no URL parameter in that case. That could change the sample to:
const installButton = document.querySelector("#install");

window.addEventListener("beforeinstallprompt", (event) => {
  event.preventDefault();
  installButton.removeAttribute("hidden");
});
installButton.addEventListener("click", () => {
  navigator.install().then( origin => console.log( `Installation started from ${origin}` ));
});

+1. We're looking into the implications of this. It'd be nice to have one consistent ergonomic API that would cover both installation types (same and cross domain).

We'd be keeping the same threshold of onbeforeinstallprompt for navigator.install() (same domain installs), but plan at phasing out the former for the latter. Do let me know your thoughts, and if everything seems alright I'll proceed to close this issue.
https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/WebInstall/explainer.md#installing-a-web-app-from-the-current-origin


Feature request for workflow.construct_parameters

High, the geometry parameter for workflow.construct_parameters allows of list of boundary coordinates.
a) the bounds attribute of a shapely  polygon is a tuple of floats
so it raises:
ValueError: The provided geometry muste be a FeatureCollection, Feature, Dict, geopandas Dataframe, shapely Polygon, shapely Point or a list of 4 bounds coordinates.
So, I manually have to make a list from the Tuple.

Thanks for the feedback @Meresmata! We will consider this and get back to you soon!

Decided to stick with the list, the accepted types are already plenty and not super simple to differentiate what is for what. Should be straight forward to provide the coords as a list and the error is relatively clear. Thank you for the feedback!

Decided to stick with the list, the accepted types are already plenty and not super simple to differentiate what is for what. Should be straight forward to provide the coords as a list and the error is relatively clear. Thank you for the feedback!


Weaviate: Batch embed texts

When a custom Embeddings object is set, embed all given texts in a batch instead of passing them through individually. Any code calling add_texts can then appropriately size the chunks of texts that are passed through to take full advantage of the hardware it's running on.

Who can review?
Tag maintainers/contributors who might be interested:

@dev2049

thanks @bhperry!


fixes rs/pushd#31

Cherry pick from the pull request #32

Probably no longer relevant since https://github.com/rs/pushd/pull/118 is merged and offers the same functionality

Can this be closed then?


Replace "sumo" favicon.ico with "jotz" icon and provide facility for site admin and individual users to override with custom .ico file.

I've modified header.php and cms_header.php so that a favicon.ico from the user's uploads folder will be used (if available) instead of the default from the root folder. However, I didn't update the default favicon.ico file, because it would affect all current accounts on the robosumo server. I think the old "sumo" icon is better for those.


Replace deprecated Number object constructors with valueOf

valueOf is the recommended replacement

@GameCubeGBA, please read our Patch Submission Tips for guidance on the types of pull-requests we accept.  This is a "Find and Replace" change.


integration-cli: fix wrong formats

Error: Unable to match/v1/repositories/<IP_ADDRESS>/imageswith regexp

Signed-off-by: Antonio Murdaca<EMAIL_ADDRESS>

LGTM

LGTM 🐸
(but janky's are out :sob:)

It's green 🐸 !! Merging


MakeZipReproducible non-deterministic if run from users with different UID's

If MakeZipReproducible is run from say one machine with uid=1004 and then another with uid=1005, the src.zip generated differs because the extra field data contains the uid.
Needs potential fix upstream.

Resolved upstream:
jdk-19: https://github.com/openjdk/jdk/commit/4451257b1432e4180a16757aafca6141b8063772
jdk-17u: TBD


Is it  possible to impor  MultiLock  trylock performance?

This is a extreme situation, I need get a multilock that contain tens of thousands of locks, It will take several minutes, Is it  possible to impor  MultiLock  trylock performance?

You could use RBitSet in this case. Just consider each bit of it as a separate lock.

Frankly,RBitSet can not meet requirement.

Here is the way https://github.com/redisson/redisson/issues/3122#issuecomment-729493022


Added tests to verify - CASE expression with constants

Hello Abhishek,
Can you please review and merge these new tests that verify case expressions with constants.
This is the first set of tests. I will add some more in a later commit.
I have a clean run, I will share the link to clean precommit run.
Thanks,
Khurram

LGTM. +1

Thanks Abhishek.


Fix npm install

Hi there,
First of all, thanks for your work on this module, I find it quite useful.
Currently "npm install" fails with a ENONENT error, can't find bin/bootprint.js.
This seems to be a consequence of bootprint-cli.js having been renamed to bin/bootprint.js in 78ce862.
Please consider this pull request to fix it.
Thanks again !

Oh, my bad and many thanks for the PR. I'll merge it and republish immediately

I've published a new version with you commit.

Great. Merry Xmas !

Same to you :-)


tensorboard embedding

Hello,
In tensorboard I see the the Projector tab with the PCA and T_SNE visualizations (1024 points and 36 dimension)
How can I create the tsv and sprite to visualize my labels and images there?
I don't know how to extract the features from the Faster r-cnn inception V2 so I could create the tsv and sprite for those 1024 points, or whatever is needed for label and image visualization.
Thank you!

Save question. It would be great to have a tutorial on how to better understand the tensorboard distributions and histograms and to label the projector to make it meaningful for the classes being trained, especially when using the networks from the tensorflow model zoo. Thank you.

Hi,
I'm struggling with the same problem.
did you figure out how to do so?

unfortunately not yet.

not yet?


Add support for retrieving premium account transactions

Proposed Changes

Add support for premium accounts

Additional Info
Currently the client doesn't support the premium products of Nordigen. Added support for that.
I've taken on from where the previous Premium Support PR has staled. Also according to Nordigen documentation it is only the transactions endpoint that supports premium accounts - thus this is the only one I've added in this PR.

Hi @nordigen @victory-sokolov this MR can be merge soon or not ? I'm interested for use it
Thanks

Thank you for PR!
And sorry for the delay.


Move truncate + delete tables to seperate function

Move the truncate + delete table to seperate azure function

done with #41


openvas-check-setup Links No Longer Exists

It appears this link: https://svn.wald.intevation.org/svn/openvas/branches/tools-attic/openvas-check-setup no longer exists anymore, which is causing step 12 to fail.

#226


Enable itertools.Iter to collect into collections that do not implement Seq

I'd like to suggest possible additions to how Iter.collect works now:

Allow collecting into a RingBuffer by only requiring an interface as argument to collect that defines a push method
collecting tuples of key and value ((K, V)) into a Map using HashMap.concat
collecting into a set using HashSet.union
support collections.persistent collections

List using Lists.from
Vec using Vec.concat
Set using HashSet.op_or

I am not 100% sure if the approaches above are correct, just wanted to suggest some solutions. Supporting all those different types might be solved with a big union type and an iftype switch in the function body.
It might also be worth to consider a standard way of creating a collection from an Iterator. Most collections support that. If there was a common method all stdlib collections would implement, Iter.collect would simply use an Interface defining it as argument. This way making new collections cooperate with Itertools does not require changs to itertools itself.

I can think of two good options:

Add an alternative method for collecting in a more general way:
fun ref other_collect[C](c: C, f: {(C, A!): C^} box): C^

So collecting into a Set would be:
Iter[I64](Range[I64](1, 4))
  .other_collect[Set[I64]](
    Set[I64](3),
    {(s: Set[I64], v: I64): Set[I64]^ => s .> set(v) })

Add a more general interface for collection than Seq, like Rust's FromIterator Trait

Either option would require an RFC

But for these cases fold may just be a better option:
Iter[I64](Range[I64](1, 4))
  .fold[Set[I64]](
    {(s: Set[I64], v: I64): Set[I64]^ => s .> set(v) },
    Set[I64](3))

The only disadvantage of fold is that it is a partial method.

I've been trying to build up a big RFC to improve the itertools API, which included breaking up fold into a partial and a non-partial version. But since other issues have slowed my progress, it may be best to open a smaller RFC with that change and a few others.

having a non-partial Iter.fold would actually solve all the cases i mentioned!

Some good discussion here so far.
I'm adding the turn into rfc label, since that's the next step for this.

Assigning myself since I'll be opening an RFC in the next few days


For Reviewer

GitHub project link: https://github.com/belalgamal46/Capstone-Project-2
Note: We are two members only.

Hi Team,
Good job so far, indeed you have spent time on this project!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

15 cards ✔
Properly assigned ✅

Required Changes ♻
Check the comments under the review.

[ ] Kindly remove the cards for student C since you are two on this team.

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.


Missing network id checks

Description
Closes issue #540.

Checklist

[x] Commit sequence broadly makes sense and commits have useful messages
[x] Code is formatted according to CONTRIBUTING.md
[x] Self-reviewed the diff

It turns out the check is already implemented in actionWellFormed, so only the return address needs to be checked.


Set project tab & indent settings

Makes life easier so when we switch into this project Xcode automatically selects the correct tab & indent width.

Thanks!


Сorrected spelling

efficienct

efficient

Cramar and Damgard

Cramer and Damgård

downsteam

downstream

trascript or pull determistic

transcript or pull deterministic

paring curve

pairing curve

Fix typos: corrected spelling of 'efficient', 'Cramer and Damgård', 'downstream', 'transcript', 'deterministic', and 'pairing'

@moodlezoup


table going to first page when data changes

I'm working on a meteor app that uses angular-meteor and ng-table. The dataset of the ng-table is from a collection. You can add rows to the table dynamically via a modal form. The dataset is reactive and changes the view once there's a change in the collection. I'm watching for status changes of the item (QUEUED, PROCESSING, CREATED).
Thing is, if the table is on page 2 and the status changes (any change in the dataset), the table is redrawn and goes back to page 2. Is there a way to make it stay on the current page even with dataset changes?
Here's a sample of what I have so far:
(function () {
	'use strict';

	function myController($scope, $reactive, ngTableParams, ngTableEventsChannel, myService) {
		$reactive(this).attach($scope);

		this.subscribe('myCollection');

		this.currentPage = 1;
		this.helpers({
			tableParams: () => {
				return new ngTableParams({
					page: this.currentPage
				}, {
                    //this is just a simple collection call
					dataset: myService.getItems().fetch()
				});
			}
		});

		$scope.$watch('vm.tableParams', (params) => {
			//not triggered :(
			ngTableEventsChannel.onDatasetChanged(() => {
				console.log('data changed');
				tableParams.page($scope.currentPage);
			}, $scope, tableParams);

			ngTableEventsChannel.onPagesChanged(() => {
				$scope.currentPage = tableParams.page();
			}, $scope, tableParams);
		});
	}

	angular.module('MyApp').controller('MyController', myController);
})();

The onDatasetChanged event isn't being triggered. I was going to change the page there but I'm not sure if that's a good idea anyway.

I am Facing same issue, I am continuously streaming data and then updating ng-table data when response comes as:
vm.detailsTable.settings({ data: details });

During this if I go to some 'X' page, and when above statement executes it jumps back to first page. Did anybody find solution for this?


Bring key mappings up to date with tcell

This adds missing string mappings for the named key codes (Should address parts of #41). (Except for KeyCtrlLeftSq which is Escape). Unfortunately I don't see anything for additional media keys and I'm pretty sure those would have to be surfaced by tcell as currently implemented.

I tried running xdotool key XF86AudioPlay and like you say, it doesn't seem like media keys are supported by tcell. The idea from the start has been to rely on a third-party library for the actual communication with the terminal. In fact, originally tui-go was termbox-go for this, but I later felt tcell supported more of the things I had imagined for tui.
If media keys turns out to be a highly requested feature, then I think that it should preferably be implemented in tcell first
Either way, thanks for your contribution! Much appreciated!


[UNOMI-282] Add a documentation feature to provided online manual in distribution

@sergehuber ok :)

@sergehuber I made the changes, I think it's good now.


There seem to be some errors in the code

In utils / utils.py, there seems to be a shrink error on lines 149-153.  I guess these codes should be in the loop of each batch. Is this right?
In RFFL_run.py, line 391,  Is it reasonable to use the validation set of each client to evaluate each model? Should a test set from server be used for evaluation?
In RFFL_run.py, line 291-293,  it seems that each iteration (a round in federated learning) starts from an initialization model. In this case, the training is ineffective. Is your code wrong?

Yeah, you are right. Thanks. Fixing it.
The valid_loader is in fact maintained by the server, not from each client.
In lines 385-388, the models are updated accordingly.

Closing due to inactivity. Feel free to open again if you have questions.


lazily init _ticksPerSecond

remove shared static this()
construction of MonoTime is now impure
(obtaining the current time is impure anyhow)
any construction will init _ticksPerSecond
use pureTicksPerSecond and assert a previous init
to maintain pure for MonoTime ops
make ticksToNSecs/nsecsToTicks impure because the
might have to obtain the clock resolution

As discussed here https://github.com/D-Programming-Language/druntime/pull/990#discussion_r29628877.

Purity hardly matters for MonoTime because getting the current time is impure and it's the only use-case for MonoTime.

These changes trigger https://issues.dlang.org/show_bug.cgi?id=14517 . Also, isn't this less efficient than the current solution, since it has to load _ticksPerSecond rather than just using it? It is shorter though, which is nice. Regardless, it's not going to work if it's triggering https://issues.dlang.org/show_bug.cgi?id=14517.
An alternative solution would be to use version(CoreDdoc) to version out the stuff that's causing problems. Worst case, all of MonoTimeImpl could be versioned with CoreDdoc.

This PR solves the problem with far fewer changes https://github.com/D-Programming-Language/druntime/pull/1259 and it won't affect the non-documentation build at all, so it won't trigger that compiler bug.

These changes trigger https://issues.dlang.org/show_bug.cgi?id=14517.

This pull removes the static constructors, so it shouldn't trigger the issue. So have to see what's causing the issue on OSX.

Also, isn't this less efficient than the current solution, since it has to load _ticksPerSecond rather than just using it?

That's completely irrelevant here. A raw atomic load (no synchronization required) is really cheap, especially compared to clock_gettime. It's not an intrinsic on DMD yet (but on GDC and LDC), so there is a small call overhead, still it's cheap and only required for construction, pureTicksPerSecond just normally loads the value because it is used after the value is already initialized.

That's completely irrelevant here. A raw atomic load (no synchronization required) is really cheap, especially compared to clock_gettime.

I don't see how it's irrelevant. With the current solution, once the static constructor has been run, _ticksPerSecond has been initialized and can just be returned, whereas with this, it has to check whether it's been initialized every time it fetches it. So, while an atomic load may be fast, it's still extra work that has to be done every time that a MonoTimeImpl is constructed.
Aside from fixing the documentation build problem (which has now been fixed with another pull), why is what's in this PR better than what we have now?

Aside from fixing the documentation build problem (which has now been fixed with another pull), why is what's in this PR better than what we have now?

Because it avoids a static constructor that runs for everyone using core.time, makes MonoTime usable without init order issues in the GC, and allows us to get rid of a bunch of metaprogramming mixins.

I don't see how it's irrelevant. With the current solution, once the static constructor has been run, _ticksPerSecond has been initialized and can just be returned, whereas with this, it has to check whether it's been initialized every time it fetches it.

It's irrelevant, because you won't be able to measure a difference.

Another reason against static constructors is that they tend to bloat statically linked binaries.

I'm against lazy construction because of the performance cost (it is not zero) and the lack of purity (yes, you cannot obtain a MonoTime purely, but at that point, it becomes POD, and can be used purely). I contend that the binary bloat is not significant.
Really, the point of static constructors is to avoid having lazy construction (i.e. singleton). The cost of this construction is so miniscule.
The GC problem of relying on static ctors is solved.
And finally, if the static construction in templates issue is fixed, we can revert this back to the "simple" mechanism Jonathan originally used.

And finally, if the static construction in templates issue is fixed, we can revert this back to the "simple" mechanism Jonathan originally used.

My main motivation for this is using MonoTime within druntime, it's a very valuable tool and the lack of it makes it harder to benchmark something.

I'm against lazy construction because of the performance cost (it is not zero) and the lack of purity

There is a small cost because atomicLoad isn't an intrinsic.

but at that point, it becomes POD, and can be used purely). I contend that the binary bloat is not significant.

I used a pureTicksPerSecond function that just loads the value, so only construction is impure. I understand that this looks a bit hacky, but it's better than to initialize all _ticksPerSeconds for all clock types using a function with string mixins. We could also get rid of that clockIdx.

My main motivation for this is using MonoTime within druntime, it's a very valuable tool and the lack of it makes it harder to benchmark something.

An option is to have druntime specifically run the init instead of using static ctor. I can't believe I didn't think of that before :)
You'll have to cast away immutability, but that should be fine here.
does that solve all the problems?

I'll make a PR for that, hopefully it solves this.

OK, thanks

You might want to look at #1276 first to avoid merge conflicts.

Not sure if I can avoid merge conflicts there... Almost done with the PR, so we will see, I'll try a merge to see if it fails.

Took a closer look, I'm definitely going to conflict, as I factored out the static if code for translating clock type to clock arg, it's done in 2 places, and the code is identical. I'll update mine to use the new form you used.

I'm including all the updates you made to that PR except for the unit test reduction. I think that should be a separate refactoring, since @jmdavis loves his unit tests ;)
It will probably still conflict, but be much less of an update for you.
#1278


Notification of webmention failures

I'd like to be notified (by XMPP or SMTP) when bridgy webmentions to my domain fail for any reason. Site upgrades, etc, sometimes break things and it can take time for me to notice, during which I miss messages.

hoo boy. interesting! we only have email/XMPP addrs for a fraction of accounts, either from mf2 on their home page or their FB profile (if it's there), and this would definitely take some work, but we could consider it.

one low tech way to do this would be a cron job that polls bridgy's api for each of your user pages and looks for p-bridgy-status="failed" (or error). e.g.:
curl 'https://mf2.kylewm.com/?url=https://brid.gy/twitter/singpolyma' | grep -E 'error|failed'
...

tentatively closing, given the API. feel free to reopen!


Update code snippet

Fixes #36963

@Potapy4 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Hi @timsander1 - Could you review the proposed changes? Thank you.
CC @SnehaGunda

@Potapy4 Thanks for the fix, it looks correct to me. We will merge your PR soon.
#sign-off

@SnehaGunda: I'm sorry - only the author of this article, @timsander1, can sign off on your changes. But we do have an exception process - if you are on the Microsoft content or product team for this product area, you can ask the PR review team to review and merge it by sending mail to the techdocprs alias.


⚠ Bofrost.es has degraded performance

In a6d707b, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1615 ms

Resolved: Bofrost.es performance has improved in ef2a0f9 after 6 minutes.


Reorganize the Dockerfile a bit (for caching, but also for testability)

This allows us to run binaries like "vmhgfs-fuse" and verify that at the very least all the ".so" files they need are discoverable.  (Which is really important for helping us avoid issues like #1157 in future updates.)
cc @nathanleclaire @frapposelli

Since we're resolving deps-of-TCZ_DEPS ourselves, I wonder if it'd be prudent to also include a "chroot test" for some of the utilities we install via that method too (like git --version, etc).  I also wonder if we could instead utilize TCL's package manager more directly and get dep resolution somewhat more automatically (because I have to believe it manages "dependency" information for each package :sweat_smile:).

(I should add that I've tested both that this builds successfully, and that the resulting ISO still works and Docker still runs containers within it.)


build: Include platform projects when running from Gradle or the IDE

Use a Gradle 8.4 dependencyScope 1 to extend the runtimeClasspath with the pluginClasspath. This improves the solution from 1708ac3 by supporting to run ORT from Gradle or the IDE with platform projects / plugins in the classpath, but still do not publish them as part of the "dependencyManagement" in the POM. See 2 for context.

Merging as urgently needed by third-party ORT development.


How to build queries is not clear to non-expert users

Is your feature request related to a problem? Please describe.
Feedback from non-expert user:
"I tried to find out about secondary education in Vietnam involving international orgs. Five minutes later, I had no information and gave up."
Part of the challenge was likely the absence of filters for participating organisation types and roles. (issue #1865 )
Describe the solution you'd like
Provide guidance to users
Add required filters

I just spotted 9 IATI activities with VN + sector 11320
See: https://iatidatastore.iatistandard.org/search/activity?q=sector_code:("11320") AND recipient_country_code:(VN)&wt=json&rows=50
Not sure what 'involving international orgs' means as that is not a clear IATI field that we know of.


Bootloader hangs when it can't find a kernel?

Also should change "cant find file" -> "cant find directory".

It seems it just shits the bed if there are too many files in the init directory?


Fix download date updating and use last risk calculation date for risk card (EXPOSUREAPP-3874)

We were using a mix of different preferences objects when updating the last download timestamp which could cause them to go out of  sync.
We are now using the last risk calculation timestamp instead of the download timestamp for the risk card on the home screen.

Need to change the timestamp again. Draft for 20min.


Remove unused features and crates

Also updated dependency on uuid crate to latest minor version.

@stevenhartley can this be merged?


queue is not working

Hi mode:queue is not working, what could be reason it ?

hi @onerciller , could you please be more specific? I just tried with chrome/safari and the queue mode is fine.

for instance I tried it from here https://noru.github.io/vue-easy-toast/example/index.html I selected queue but it did not work

I think we have a misunderstand here. On queue mode, if you toast 2 messages sequentially, the latter one will wait until the first one reaches its "duration", then show its content. The demo link shows the same behavior.
I bet you expect a different behavior like a message box stack of some sort. That's not a support feature of this plugin.