Failure! An error was encountered when trying to save your robots.txt content.

Hello,
When we try to update and save the robots.txt file, we are getting this error "Failure! An error was encountered when trying to save your robots.txt content." We have all the configuration as per the document.
Can you please help us what might be causing this error?
Thanks,
Deepa

Hello @Deepa-Puranik
Are you able to share an logs related to this event failure? They would contain any of the following three classes:

RobotsContentService
RobotsContentRepository
RobotsController

Also can you provide me with any JSON specific conventions you have set up for your solution as well as the CMS version you are having this issue on.
Thank You
Mark

Hello Mark,
CMS version is 12.22.6 and we have appsettings.json file in our solution.
{
"Logging": {
"LogLevel": {
"Default": "Information",
"Microsoft": "Warning",
"Microsoft.Hosting.Lifetime": "Information"
}
},
"AllowedHosts": "*",
"webpages:Version": "<IP_ADDRESS>",
"webpages:Enabled": false,
"PreserveLoginUrl": true,
"ClientValidationEnabled": true,
"UnobtrusiveJavaScriptEnabled": true,
"ValidationSettings:UnobtrusiveValidationMode": "None",
"aspnet:UseTaskFriendlySynchronizationContext": true,
"MAICryptoKey": "X).Q7\u002Bc3c:=i}JGC.",
"GetaEpiCategories:DisableCategoryAsLinkableType": true,
"ImageProcessorDebug": true,
"episerver:contentdelivery:maphttpattributeroutes": true,
"episerver:contentdeliverysearch:maphttpattributeroutes": false,
"Geta": {
"NotFoundHandler": {
"BufferSize": 40
},
"Sitemaps": {
"EnableLanguageDropDownInAdmin": true
}
},
"ConnectionStrings": {
"EPiServerDB": "Replace in your own appsettings.Development.json file"
},
"EPiServer": {
"Find": {
"ServiceUrl": "Replace in your own appsettings.Development.json file",
"DefaultIndex": "Replace in your own appsettings.Development.json file"
},
"CMS": {
"LicensePath": {
"Path": "Replace in your own appsettings.Development.json file"
},
"MappedRoles": {
"Items": {
"CmsEditors": {
"MappedRoles": [ "WebEditors", "WebAdmins", "Contentteam", "Designteam", "Digitalteam", "Laserform", "ModernSystemsEditor", "News&Blogs" ]
},
"CmsAdmins": {
"MappedRoles": [ "WebAdmins", "Administrators"]
}
}
},
"DataAccess": {
"UpdateDatabaseSchema": "true"
}
}
}
}
It's not logging any error in log file, just find out that we have custom rewriter in place and calling it using app.UseRewriter(RewriteOptionsHelper.rewriteOptions); If we remove this robots.txt works, we can't use rewriter in order to have this package working?
Thanks,
Deepa

Hello Deeper,
There must be something in the chosen rewriteOptions that is changing the URL so that the JS sees a 301/302 instead of a 200.
Can you tell me what your rewriteOptions are so I can reproduce and prevent this issue in future? alternatively can you update them to exclude the /stott.robotshandler/ path? all routes for this module are on that path
Thanks,
Mark

Thank you @Deepa-Puranik I will try and replicate this issue and see if I can come to a solution for you.

@Deepa-Puranik The error was occurring because the save call was redirected to a new URL with a trailing slash.  The /details/ API was already being called with a trailing slash so there was no redirect happening there, so I just corrected the /save/ API to be called with a trailing slash.
SEO practice is typically to add a trailing slash rather than remove it.  So this will prevent those redirect rules firing.
I've uploaded 2.6.2 to nuget.org and api.nuget.optimizely.com to resolve this for you.

Hello Mark,
Thank you so much for all the help.
Issue is resolved now.
Thanks,
Deepa


Avoiding rtype checks with typed code:  No return type or annotation at ':return: ...

Describe the bug
Once a library adopts type support is it very unlikely that the maintainers will want to duplicate the type information inside the docstrings. That duplication is a real maintenance issue and also a permanent source of bugs, as it is very easy to miss updating the docstring when changing the type.
I personally faced https://github.com/mkdocstrings/griffe/blob/34bc108bc749fa7379c541cee43979a8a2b7acc9/src/griffe/docstrings/sphinx.py#L298 and I see no way to disable that kind of check.
That typing issue is so important that we are willing to switch to a different docstring format.
Currently we use sphinx for historical reasons and anything going towards markdown and less verbosity/duplication would be appealing.

Hello, thanks for the report!
I'm a bit confused: this warning is supposed to be emitted only when there is no annotation in the signature and no annotation in the docstring. But I didn't write the sphinx parser so maybe I misunderstood. At least that's how the warnings are supposed to work, and how they actually work in the other two parsers (google and numpy).
Could you show a code snippet that triggers the undesired warning?

Here is an example that also includes the workaround for it https://github.com/ansible-community/molecule/pull/3811/files#diff-32abfdacc4eeea878460d3bf0ae452ab074ca485bab0b0a01b3bb07775ac002dR399-R630
Basically I removed the return for that one because it did not had any documentation and the type was already documented. I have few other similar places where for example I removed :rtype: line. Excuse the codebase of that project as it was not fully migrated to type, there is a LOT to add to it.

The example you linked actually confirms what I said above: https://github.com/ansible-community/molecule/pull/3811/files#diff-32abfdacc4eeea878460d3bf0ae452ab074ca485bab0b0a01b3bb07775ac002dL611-L635
You removed the :return: str line from the docstring of the inventory property, which does not have a return annotation (-> something). If I understand correctly, :return: is meant to give a description, while :rtype: is meant to give a type. Since :return: was present but neither the return annotation or the :rtype: directive were, a warning was emitted.
Or did I misunderstood the Sphinx directives?

Closing for now, feel free to reopen if needed.

This seems to happen with properties (@property decorated methods). Even if you add the type in the :return: directive, or :rtype:.
@property
def example(self) -> bool:
    """
    Property that returns True for explaining the issue.

    :return: True
    """
    return True

@property
def example2(self) -> bool:
    """
    Property that returns True for explaining the issue.

    :return bool: True
    """
    return True

@property
def example3(self) -> bool:
    """
    Property that returns True for explaining the issue.

    :return: True
    :rtype: bool
    """
    return True

def example4(self) -> bool:
    """
    Property that returns True for explaining the issue.

    :return: True
    """
    return True

Gives:
WARNING -  griffe: test.py:3: No return type or annotation at ':return: True'
WARNING -  griffe: test.py:12: No return type or annotation at ':return bool: True'
WARNING -  griffe: test.py:21: No return type or annotation at ':return: True'

Note the normal method does not trigger a warning, even without a Sphinx style type annotation.


Add a new giveaway filter: Minutes From Start

It would be nice to have an filter that is "Minutes passed after creation of Giveaway", because for example i have an preset that presents only high chance giveaways based on chance filter and it works well but there are giveaways that are for example level1 and have been created just 15 minutes ago and they show on the list although those will have hundreds of entries after an hour.
So having that filter i could filter out all giveaways that have been created under 60 minutes ago for example. So the filter is basically "Minutes passed after creation of Giveaway" and in entry field you could type the minutes.
I tried to search other ways to achieve this but did not found any.

Added a Minutes From Start filter that should do what you want. It works similar to Minutes To End.


Add ServiceMonitor by default

Right now cert-manger support monitoring through a ServiceMonitor.
Since the operator by default is installed in the openshift namespaces, creation of user defined ServiceMonitors is not support.
Can the default ServiceMonitor be created durin the operator installation process?
Thank you

This doc might be helpful: https://docs.openshift.com/container-platform/4.14/security/cert_manager_operator/cert-manager-monitoring.html


Refactor VF2 scoring rust interface

The implementation makes me wonder if in the future we should have some sort of VF2Scorer class that builds these and holds them as instance data among any other data that is reused between scorings. The reason being to encapsulate the internals of scoring without forcing client code to be aware of them (i.e. rather than threading a bunch of parameters around, we might call a VF2Scorer::score method and pass just the layout).
Originally posted by @kevinhartman in https://github.com/Qiskit/qiskit/pull/11115#pullrequestreview-1702040931

Oh sorry I missed your comment here back in December. I'm actually going to close this issue as it's superseded by #12276 and #12277 since we'll move all the patch logic to rust. But that's also currently blocked.


HOW TO USE API

GET STARTED 1.2 API
HOW TO USE IT?
AND THERE IS AN ERROR
(base) D:\MMSA-master\src\MMSA>python -m MMSA -d mosi -m lmf -s 1111 -s 1112
Traceback (most recent call last):
File "D:\anacode\lib\runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
File "D:\anacode\lib\runpy.py", line 86, in run_code
exec(code, run_globals)
File "D:\anacode\lib\site-packages\MMSA_main.py", line 46, in
MMSA_run(
File "D:\anacode\lib\site-packages\MMSA\run.py", line 117, in MMSA_run
raise FileNotFoundError(errno.ENOENT, os.strerror(errno.ENOENT), config_file)
FileNotFoundError: [Errno 2] No such file or directory: WindowsPath('.')

Please refer to the documentation at https://github.com/thuiar/MMSA/wiki/APIs for instructions on API usage. Regarding the error you encountered, it was caused by an incorrect loading path for the config file while using the Windows operating system. To resolve this issue, please modify the command to "python -m MMSA -d mosi -m lmf -s 1111 -s 1112 -c 'save config path'."

GET STARTED 1.2 API HOW TO USE IT?
AND THERE IS AN ERROR (base) D:\MMSA-master\src\MMSA>python -m MMSA -d mosi -m lmf -s 1111 -s 1112 Traceback (most recent call last): File "D:\anacode\lib\runpy.py", line 196, in _run_module_as_main return run_code(code, main_globals, None, File "D:\anacode\lib\runpy.py", line 86, in run_code exec(code, run_globals) File "D:\anacode\lib\site-packages\MMSA__main.py", line 46, in MMSA_run( File "D:\anacode\lib\site-packages\MMSA\run.py", line 117, in MMSA_run raise FileNotFoundError(errno.ENOENT, os.strerror(errno.ENOENT), config_file) FileNotFoundError: [Errno 2] No such file or directory: WindowsPath('.')

Hello, I'm sorry to bother you. Have you solved this problem? If so, how did you solve it? I have encountered the same issue. Thank you!


Long log lines lead to inaccessible kitematic interface

Expected behavior
When the log lines in the container are very long on Kitematic 0.17.3 on Ubuntu the tabs "Home" and "Settings" are accessible.
Actual behavior
Long log lines lead to the "Home" and "Settings" tab being pushed so far to the right that they are no longer accessible by the user.

Can you provide some container image that would replicate this? I can't seem to make it happen on OSX

Hi,
I have this issue with many container,
I need two screen and maximize window for acces home and setiings Tab on the second screen
Containers :
-openkm/openkm
-obviouscap/openkm
-eclipse/che-server
etc ...
Thanks

thanks @jmgfr for the images - Do you have anything like this that is smaller than 100mb? Some of the above are 1gb

Hi,
Thanks for your reply.
I've tested some af smaller container images but none of them replicate this !
Is thre a way to run kitematic in verbose or debug mode and send you a log or a trace ?
Thanks

What version are you running? I'm unable to reproduce this in 0.17.2
added a max-width thinking that was needed

without any fix at all it looks the same

I'm using 0.17.3 downloaded from this github and installed via dkpg without any error.
My ubuntu is 14.04.5 LTS
Thanks

I have this issue with https://hub.docker.com/r/elmarhinz/typo3.docker-development/ (as I wrote using Kitematic 0.17.3 on Ubuntu 17.10)

Didn't realize this was an ubuntu specific issue... can someone look at setting a max-width on content, if it helps?

How to do that?

Sorry, I don't get it. How do Chrome Developer Tools come into play with a binary installed from a *.deb file? I did find /usr/share/kitematic/resources/app/main.css and adding
.details-panel.home .content {
  max-width: 900px;
}

makes at least the settings tab available for me even if there are long log lines.

By adding
.details-panel.home .content .mini-logs .widget .logs {
  max-width: 600px;
}

I can additionally wrap the actual log lines so the web preview box is visible:

The same shortcut use on Chrome, can be used in Kitematic (we use electron).
Can you try max-width: 100% ?

In Chromium I use Ctrl+Shift+I but when using that in kitematic nothing happens. Tested some combinations now Ctrl+Alt+I is it.. :-)
Using max-width: 100%  on these both elements has no effect :-(

ctrl+shift+i works for me - if you can figure out the max-width that works well, it would be helpful, since I don't have the proper env

It works for me with two additional definitions
.details {
    width: 75%;
}
.details-panel.home .content .left {
    width: 60%;
}

which is not perfect for small window sizes but much better as all ui elements are accessible

Thanks for the help debugging this @sgrossberndt, and getting a PR submitted 👍


Added Windows support.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

OK, this now builds correctly for Windows, @vgauthier, it is ready for review/merge.

OK, this now builds correctly for Windows, @vgauthier, it is ready for review/merge.

Thanks @vgauthier !

Thanks @vgauthier !


Create PRATYUSHPAHARI.json

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

[ ] My code follows the code style of this project.
[ ] My change requires changes to the documentation.
[ ] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[ ] The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Thanks! 🎉

When my linkfree account will be created ??

Thanks! 🎉

When my linkfree account will be created ??

Your PR will be merged once another maintainer approves it.


Release Google.Cloud.DiscoveryEngine.V1Beta version 1.0.0-beta08

Changes in this release:
New features

Supported bring your own embedding feature (commit d6f6676)
Added more options for search extractive content support (commit d6f6676)
Added more skip reasons and details for search summarization (commit d6f6676)
Added query expansion details in search response (commit d6f6676)
Updated summarization interface for multi-turn search (commit d6f6676)
Allow uri in user events (commit d6f6676)

Documentation improvements

Keep the API doc up-to-date with recent changes (commit d6f6676)

Created release for Google.Cloud.DiscoveryEngine.V1Beta-1.0.0-beta08


Validate & Document hubs.yaml with JSON Schema

We are currently adding random bits and pieces to our hubs.yaml,
without a coherent schema. You need to scour the codebase to figure
out what each thing does.
Instead, we should define a JSON schema & document that. This shouldn't
allow additionalProperties for the most part, helping us catch accidental
additions in hubs.yaml that don't have documentation.

This is done


Added Confirmation Pop ups for copied links

Popup for the confirmation if copied
When we click on the app we were not able to see if the link is copied or not so for that I put the confirmation popup coming

Issue Ticket Number
Fixes #56

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ ] I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING
[ ] I have checked to ensure there aren't other open Pull Requests for the same update/change?
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes needed to the documentation

@CodiumAI-Agent /review

@CodiumAI-Agent /review

PR Reviewer Guide 🔍

 ⏱ Estimated effort to review [1-5]
2

 🧪 Relevant tests
No

 🔒 Security concerns
No

 ⚡ Key issues to review

Possible Bug: The showCopyMessage function uses a hardcoded delay of 3000 milliseconds to hide the confirmation popup. Consider making this delay configurable or ensuring it aligns with user experience expectations.

Code Quality: In the createSocialLink function, the logic for showing and hiding elements on mouse events could be refactored for better readability and maintainability. Consider separating concerns or simplifying the interaction logic.


[FEAT]: Enhance Project Integrity - Include Copyright Footer 📜✨

Description

The project "Sampark" currently lacks a copyright footer on its webpage, which poses several concerns regarding fairness and legal compliance.

The absence of a copyright notice not only raises doubts about the ownership and intellectual property rights but also leaves the project vulnerable to unauthorized use and potential disputes.

Missing Copyright Footer:

The Sampark project's webpage does not contain a copyright footer that typically includes information about the project's ownership, the year of creation, and the rights reserved.

Without this footer, visitors may assume that the content is freely available for use, leading to potential misuse or misattribution.

Fairness and Legal Compliance:

A copyright footer is essential for maintaining fairness and ensuring that creators' rights are protected. By omitting the copyright notice, the project risks facing issues related to intellectual property disputes, plagiarism, or infringement cases. This could have adverse effects on the reputation of the project and its contributors.

Importance of Adding Copyright Footer:

Legal Protection: A copyright footer clearly establishes the ownership of the project, its content, and any associated intellectual property rights, providing legal protection against unauthorized use and copyright infringement.

Attribution and Recognition: Including a copyright notice helps ensure that proper attribution is given to the project's creators, acknowledging their efforts and contributions.

Encouraging Contribution: A well-protected project is more likely to attract contributors, as they are assured that their work will be appropriately recognized and safeguarded.

Clarifying Usage Terms: A copyright footer can specify the project's licensing terms, guiding users on how they can utilize the project's content while complying with the established guidelines.

Recommended Action:

To rectify this issue, it is essential to add a clear and concise copyright footer to the Sampark project's webpage.

The footer should include the name of the copyright owner, the year of creation, and any additional licensing information as necessary. Additionally, it's essential to choose an appropriate open-source license or copyright statement that aligns with the project's goals and licensing preferences.

By adding the copyright footer, the Sampark project will demonstrate its commitment to fairness, legal compliance, and respect for intellectual property rights, ultimately fostering a more transparent and trusted open-source community.

Hey there @Gaurav-Verma07 👋🏻
Please make sure to assign this issue to me to make the work done, Thank You!


Docstring for @sum_type

@sum_type is exported but has no docstring:
help?> @sum_type
  No documentation found.

Yeah... I've been meaning to do this for a while and haven't gotten around to it :sweat:


fix: validate secgroup purge condition

这个 PR 实现什么功能/修复什么问题:
fix: validate secgroup purge condition

[x] 功能、bugfix描述
[x] 冒烟测试
[ ] 单元测试编写

是否需要 backport 到之前的 release 分支:

release/3.3

/area region
/cc @zexi

Codecov Report

Merging #8210 into master will decrease coverage by 2.52%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master   #8210      +/-   ##
=========================================
- Coverage    6.21%   3.69%   -2.53%
=========================================
  Files         759     303     -456
  Lines      117192   61896   -55296
=========================================
- Hits         7289    2289    -5000
+ Misses     109244   59449   -49795
+ Partials      659     158     -501

Flag
Coverage Δ

#aFlag
3.69% <0.00%> (-2.53%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/compute/models/secgroups.go
1.53% <0.00%> (-0.01%)
:arrow_down:

pkg/compute/regiondrivers/managedvirtual.go

pkg/cloudcommon/db/quotas/stores.go

pkg/keystone/models/identityquota.go

pkg/util/s3auth/interface.go

pkg/compute/regiondrivers/azure.go

pkg/util/fileutils2/fileutils.go

pkg/httperrors/httperrors.go

pkg/monitor/alerting/rule.go

pkg/hostman/guestfs/fsdriver/macos.go

... and 447 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1867c15...6f23593. Read the comment docs.

/lgtm
/approve


Rename .form-control-static to .form-control-readonly-plain

Following on from https://github.com/twbs/bootstrap/pull/22500 and its more semantically appropriate use of <input ... readonly> elements for "static controls", this renames the actual class. Admittedly the new name is a bit long, but very descriptive.
Didn't simply target [readonly], because authors may want to retain the input-like look of readonly inputs, and only apply this new class when necessary/desired.

ping @mdo


Adds onTitleTouchTap to AppBar

There is no current mechanism for attaching an event hook to clicking an AppBar title.  This seems contrary to typical web design, and was a problem for my project.  Please consider this change.  :smile:

At first sight, I'm against this change. Why not passing a component with a onTouchTap event instead of a string to the AppBar?
It would probably solve your issue and keep the API simpler.

Because then I have to learn your styling mechanism, and the behavior of the control becomes part of the surrounding application.
It seems undesirable to me to have to create entirely new controls and manage their styling in order to attach a click handler.
I don't know any React control libraries (or Material implementations) which want one to create a new control to attach a click handler.  I actually did it that way first, but the text was wrongly styled, so I went in and there was an
, so I tried that, but it was now wrongly styled quite differently, and it looks like maybe I have to attach a mixin, set up a context flow, and manage state in an external object.
All to attach a click handler.
And I did it that way, but it was buggy and bulky, so I said "you know, the base component has click handlers on its other two main elements; I feel like this is just completing its api."
So I tried it that way; the code is radically simpler, feels cleaner to me, and nobody else would have to figure this out.
There're some other things I'd like to donate too.  For example, I patched toggle, which allows you to skin the off state, to allow you to skin the on state too, because its color system makes it invisible in some contexts when on, like when embedded in an AppBar.
I'm really hoping to not PR juggle. I'd like to help :smile:
Please consider this change.  I already tried it the other way and it was super weird.

Hmmmm guess you're right...
@oliviertassinari What if we make a new component called Label which can do exactly that with the correct style to fit right in for any component that can take in a label. This way we can both keep the api clean and cover the use case mentioned here.
@StoneCypher Can this approach cover your use case?

It seems undesirable to me to have to create entirely new controls and manage their styling in order to attach a click handler.

Did you try ?
<AppBar title={Title} />

<AppBar title={Title} />

If this actually does exactly what he wants, I guess it's good to document it in the website.

@subjectix I hope so. In this case @StoneCypher I would be happy to accept a PR updating the example in the doc.

The described code does not function as desired.  I believe but am uncertain that this regards the context passing down of themes.
Moment; screenshotting

Using my best understanding of your recommended code:
return (

    <AppBar
      onTitleTouchTap={function() { window.alert('works'); }}
      title={TITLE_EX}
      iconElementLeft={<IconButton iconClassName="material-icons">chevron_right</IconButton>}>

      {TheTabs}
      {RightMenu}

    </AppBar>

    <IconButton iconClassName="muidocs-icon-custom-github" tooltip="GitHub"/>
    <IconButton><FontIcon className="muidocs-icon-custom-github"/></IconButton>

);
![material patch 1](https://cloud.githubusercontent.com/assets/77482/11100944/02431f54-8869-11e5-9318-d917b871358e.png)

Using the same title with the patch approach provides the expected appearance:
return (

    <AppBar
      onTitleTouchTap={function() { window.alert('works'); }}
      title="TITLE_EX"
      iconElementLeft={<IconButton iconClassName="material-icons">chevron_right</IconButton>}>

      {TheTabs}
      {RightMenu}

    </AppBar>

    <IconButton iconClassName="muidocs-icon-custom-github" tooltip="GitHub"/>
    <IconButton><FontIcon className="muidocs-icon-custom-github"/></IconButton>

);

>.> yup we need Label -_-

@StoneCypher Could you have a look at my comment?
I really think that we sould keep the API of component as simple as possible.
If we start adding onTouchTap, why not adding title and so one...

i'm confused.  it's a control with three visual elements, and click handlers for two of them.  there's no practical expansion beyond there.
i won't push because you seem to have made your mind up, but i really think it's actually a flaw for the api to not offer this.

anyway, the recommended code seems to trigger a bug, and i'm too new to your library to understand what to do about it
the pr provides a pleasant user experience so i'm going to keep using the fork
i will try donating other things but i kind of feel like they'll be declined too
please reconsider
thank you for your time

@StoneCypher I'm for this PR. It kinda fits -- most web apps have some expected behavior when you click the title in the AppBar.
It's a simple, harmless change that we can do right now.
@subjectix As for creating a new component (Label) , that needs more time/effort/coordination and can always come later.
@oliviertassinari if you wanna quickfix the bug in L167 above (your comment), please do :-) But let's merge this..

@shaurya947 :+1: :+1:

@shaurya947 :+1: thanks
i have some other similar small things i'd like to contribute too

@subjectix I apologize - I overlooked your question previously
It seems like it might, yes, but I'm very new to material-ui, and I'm not yet very confident here

@StoneCypher Well it's just that this is not the only component with this issue, and to apply styles one will need the theme from the context.
I guess having a component to address all these use cases seems like a better approach, although I didn't say this isn't good, was just pointing out alternatives. Good catch anyway ^.^

most web apps have some expected behavior when you click the title in the AppBar.

Then you are going to need to use a custom component for the title, like a Title. In thise case I don't see the point of adding the onTitleTouchTap to the AppBar. I'm gonna submit a PR to address this issue.

@StoneCypher Can you have a look at https://github.com/callemall/material-ui/pull/2134? Is this addressing your issue?

Respectfully, I already provided screenshots of why this does not work correctly

@shaurya947 :racehorse: :horse_racing: :checkered_flag: your requested changes are complete

Respectfully, I already provided screenshots of why this does not work correctly

Did you try my branch?

Ah yes, I forgot about that. @StoneCypher pls add this new prop to the AppBar doc and then we'll merge this. :-)

@shaurya947 - added to docs, sorry for the oversight :smile:

@StoneCypher Thanks!


iniparser: tweak include path for compatibility

Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 203388 run on x86_64-linux 1

1 package failed to build:

apacheHttpdPackages.mod_tile

2 packages built:

cava
iniparser

apacheHttpdPackages.mod_tile has been broken for a while.

I've had a quick look and e.g. Arch Linux doesn't seem to do this:
https://archlinux.org/packages/extra/x86_64/iniparser/

Fro Debian and Ubuntu, they are
/usr/include/iniparser/dictionary.h
/usr/include/iniparser/iniparser.h

https://packages.debian.org/bullseye/amd64/libiniparser-dev/filelist

Also: When trying to build apacheHttpdPackages.mod_tile I get a different error:

That's another problem.

Maybe we can/should fix the other packages instead?

It's ok too.


Added support for plot

Added the possibility to generate a jpg with the plot of the result of the analysis of a run.
Recall how to gather data of a run (here run Roberta, gather compile time info on parallel (-opt-report=Parallel, saved with --log-to-file compile.log ) and runtime info (--profile-ir=ZHigh saved with ONNX_MLIR_INSTRUMENT_FILE=run.log).
ONNX_MLIR_INSTRUMENT_FILE=run.log RunONNXModel.py -m roberta-base-11.onnx -c "-O3 -mcpu=z16 -maccel=NNPA -parallel -opt-report=Parallel --profile-ir=ZHigh" --shape-info=0:6x384  --log-to-file compile.log -w 3 -n 16

Then you may view and print statistics as follow
python3 ~/OM/onnx-mlir/utils/make-report.py -ums -r run.log -w 3 -p output -ums

where the raw data is taken from a run-file named run.log skipping the first 3 warmup runs (-w 3) with output in miliseconds (-ums for unit in ms). The resulting graph is:

Say you would like to focus the results on operations that take at least 1% of execution time, and report the ops in alphabetical order (default is by decreasing order of execution time). Add the -m 1 --sort name and you get this graph

Say you now want to correlate the runtime info with statistics of operations that ran in parallel or not. Update the command to provide the compile-time log:
python3 ~/OM/onnx-mlir/utils/make-report.py -ums -r run.log -c compile.log -s par -p output -m 1 --sort name

Jenkins Linux amd64 Build #14825 [push] Added support for plot (... started at 13:40

Jenkins Linux s390x Build #14830 [push] Added support for plot (... started at 14:40

Jenkins Linux ppc64le Build #13855 [push] Added support for plot (... started at 14:53

Jenkins Linux amd64 Build #14825 [push] Added support for plot (... passed after 1 hr 3 min

Jenkins Linux s390x Build #14830 [push] Added support for plot (... passed after 1 hr 28 min

Jenkins Linux ppc64le Build #13855 [push] Added support for plot (... passed after 1 hr 56 min


refactor: introduce Spectral oas3-schema rule

Purpose:

Simplify our ruleset by using equivalent Spectral validation.

Changes:

Enable the oas3-schema rule by default
Remove redundant in-code validation that is covered by the oas3-schema rule

Tests:

Remove tests that test removed code
Ensure validator behavior is maintained by adding tests that ensure Spectral produces equivalent error for a particular test

Docs:

Add oas3-schema rule to list of Spectral rules enabled by default

:tada: This PR is included in version 0.45.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Emmet as external extension

Can you extract Emmet extension from VSCode and made it as external extension like you did with Git?
For example I dont' use it, but it take 50% of all preinstalled extensions! This is 37MB and 2200+ files! On my tablet update of VSCode can be much faster without it.
thank you.

@SailorMax git is still an internal extension
Are you on stable VS Code or the Insiders?
Can you elaborate on your statement "it take 50% of all preinstalled extensions" ?

@ramya-rao-a Ok, with Git was wrong :) Then I just offer move Emmet from installation to VSCode marketplace
VSCode 1.13.1
Size of C:\Program Files (x86)\Microsoft VS Code\resources\app\extensions\ = 75MB, 5812 files
Size of C:\Program Files (x86)\Microsoft VS Code\resources\app\extensions\emmet\ = 37MB, 2221 files
When and if Node will support zipped extensions, you can rejoin it again, but currently VSCode already contain too many files for "simple" editor and regular update process takes too much time already.
In this situation I think users, who require Emmet can download it separately. All others will win 2000+ files and ~30% time of installation and updates (2000+ files is ~30% of total 7000 total files).

I'm in. It seems to me that something went wrong when building the new release of editor.
I'm install all dependencies from dependencies section of Emmet extension and I got:
 ~/Documents/OpenSource/test-emmet    fs node_modules/
3,3M	node_modules/

2M is a mocha module – see https://github.com/emmetio/expand-abbreviation/issues/3.
Also I open \resources\app\extensions\emmet\node_modules on Windows and see that this directory includes typescript and other devDependencies.

Thanks for reporting this @SailorMax
Good catch @mrmlnc
I'll first look into the size issue (make a pass at all the dependencies soon and clear the node_modules up) and then circle back on this thread for the internal vs external extension discussion

Digging deeper, I found that even after fixing the upstream issue of https://github.com/emmetio/expand-abbreviation/issues/3, the size problem will not be solved
Because this is a problem for all built-in extensions. i.e. dev dependecies are getting pulled into user's machine. Logged #29054 for the same.
Of the 40 something MB for emmet extension, 25MB was coming just from typescript.
Will see if we can have a general solution for this issue

With https://github.com/Microsoft/vscode/commit/6e366b8f9026bb65a250f0a7bca27dafad9439bd the size of the emmet folder under extensions is reduced to 3.6 MB
phew

Also absorbed the change from https://github.com/emmetio/expand-abbreviation/issues/3 with https://github.com/Microsoft/vscode/commit/91008076eb63afa917938eded44e0657ef4a1b96
This won't reduce the size of the emmet folder until #29054 is fixed though. But is a good cleanup nevertheless

@SailorMax @mrmlnc  With size of emmet folder now down to a few MBs, I believe your initial concern about having emmet as internal extension is now taken care of.
At the moment, we will be going ahead with emmet as internal extension. We will revisit this decision when we make the new emmet model the default in the next iteration.
Thank you very much for reporting this issue though :)

@ramya-rao-a
I just want to emphasize, that core of my report was "2200+ files". 3.6MB in our century - is nothing. Today count of files is more important. Installations and updates of VSCode already is very slow. Few steps in same direction and VSCode setup time will be equal to Visual Studio setup time ;) This is wrong.
How many files did you reduce by your fixes?

@SailorMax Now that https://github.com/Microsoft/vscode/issues/29054 is fixed as well, we are down to 1.3 MB and about 200 files

Note to verifier:

Check the size and # of files in the extensions\emmet folder of the installed VS Code Insiders.

@ramya-rao-a
VS Code Insider.zip looks much better :) Thanks!
But:

Insider has node_modules/nsfw with "lodash/" = 1052 files - Is it normal?

many extensions (git, html, json, markdown, merge-conflict, typescript) has similar node_modules: applicationinsights, vscode-extension-telemetry, vscode-jsonrpc (twice for css, html and json), vscode-languageclient, vscode-languageserver-types (twice for css, html and json), vscode-nls (twice for css, html and json), winreg. May be more.
Can you try to reduce these also? We can save more 1000+ files and ~7MB!

Not addressing those issues any time soon.
cc @Tyriar @bpasero  for nsfw

@Tyriar can we pick up NSFW from a commit or can we talk them into releasing a new version with your fix for that?

Yes I already pushed a PR to get the size of nsfw down https://github.com/Axosoft/nsfw/pull/23, I didn't consider this a blocker to release though as it's only +5mb uncompressed.


Terraform requires final_snapshot_identifier when skip_final_snapshot is true

Description
Hello,
We are running the Aurora RDS module to create a database for us. When we tried to destroy the Terraform code we ran into an issue where skip_final_snapshot is set to false by default. We modified our code so that skip_final_snapshot is true. When running Terraform again we are still getting the same error.
We ran the following commands:

terraform init

terraform plan

terraform apply

[x ] ✋ I have searched the open/closed issues and my issue is not listed.

⚠ Note
Before you submit an issue, please perform the following first:

Remove the local .terraform directory (! ONLY if state is stored remotely, which hopefully you are following that best practice!): rm -rf .terraform/
Re-initialize the project root to pull down modules: terraform init
Re-attempt your terraform plan or apply and check if the issue still persists

Versions

Terraform version:
Terraform v1.5.2
Provider version(s):
registry.terraform.io/hashicorp/aws v5.20.0

Reproduction Code [Required]
module "cluster" {
  source  = "terraform-aws-modules/rds-aurora/aws"

  name           = "stcs-postgres-cluster"
  availability_zones = ["us-west-2a"]
  engine         = "aurora-postgresql"
  engine_version = "14.6"
  instance_class = "db.r6g.large"
  instances = {
    one = {
        identifier = "postgres-writer-instance-1"
    }
    two = {
        identifier = "postgres-reader-instance-1"
    }
  }

  vpc_id               = data.terraform_remote_state.all.outputs.module_paas_vpc_id
  subnets              = [
    data.terraform_remote_state.all.outputs.module_paas_subnet_01_id,
    data.terraform_remote_state.all.outputs.module_paas_subnet_02_id
   ]

  db_subnet_group_name = "stcs-postgres-subnet-group"
  create_db_subnet_group = true

  security_group_rules = {
    ingress0 = {
      cidr_blocks = ["<IP_ADDRESS>/8"]
    }
    ingress1 = {
      cidr_blocks = ["<IP_ADDRESS>/16"]
    }
    ingress2 = {
      cidr_blocks = ["<IP_ADDRESS>/16"]
    }
  }

  storage_encrypted   = true
  apply_immediately   = true # Apply changes immediately or defer until maint window
  monitoring_interval = 10

  master_username = "admin"
  #master_username = data.vault_generic_secret.rds_creds.data["RDS_POSTGRES_MASTER_USER_NAME"]
  master_password = "admin1234tempwillchange"
  #master_password = data.vault_generic_secret.rds_creds.data["RDS_POSTGRES_MASTER_PASSWORD"]
  manage_master_user_password = false

  enabled_cloudwatch_logs_exports = ["postgresql"]

  skip_final_snapshot = true

  tags = {
  }
}

Steps to reproduce the behavior:
Are you using workspaces?

No

Have you cleared the local cache (see Notice section above)?

Yes

List steps in order that led up to the issue you encountered

terraform init
terraform plan
terraform apply

Expected behavior
The expected behavior is that Terraform will destroy the cluster if skip_final_snapshot = true.
Actual behavior
The actual behavior is that Terraform will does not destroy the cluster if skip_final_snapshot = true.
Terminal Output Screenshot(s)

check your error message, its saying that you are not skipping the final snapshot which is why it wants an ID

Hello,
I thought I was skipping the final snapshot by providing skip_final_snapshot = true in my code?

@bryantbiggs we are running into the same issue. We don't want a final snapshot.


glium 0.16

Just updating the glium version. Without this I was getting errors for GlutinFacade not implementing Facade.

Thanks!


Recommend to ignore /pkg and /bin in SCM

Feel free to reword, but I thought it'd be nice to be more explicit about this.

Done and pushed live. Thank you.


[KeyVault] proxy support only available in Node.js

The pipeline would fail when running in browser.  Need fixes similar to
https://github.com/Azure/azure-sdk-for-js/pull/3941
/cc @jonathandturner

Should I do this change directly in the core files or wait until we can auto-generate them?


[FLINK-11642] [flink-s3-fs-hadoop] Add mirrored config key for s3 endpoint

What is the purpose of the change
Add S3 endpoint configuration so flink can connect to S3 in china regions which have different endpoints.
Brief change log
Add MIRRORED_CONFIG_KEYS item for S3 endpoint
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (yes)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (docs)

Thank you for this contribution!
This seems to be a valuable improvement for Flink, but I would like to first get a quick yes or no from @StephanEwen, who has worked a lot on the S3 integration.
If Stephan thinks the PR is a good fit for Flink, then I can help you merging it.
By the way: I would suggest you to check out our contribution guide. We require our PRs be associated with a JIRA ticket. Once we have agreement on merging, I can help you creating the ticket.

I think this is a good change. Could you please add a JIRA and test for this?
@flinkbot approve consensus
@flinkbot approve architecture

@themez I created a JIRA ticket for this PR: https://issues.apache.org/jira/browse/FLINK-11642 and updated the PR title.
Can you add a test for this?

Hi @rmetzger I've modified the existing hadoop filesystem test to include the new config item.

Thanks. Looks like this change is not compiling:
03:38:01.005 [INFO] -------------------------------------------------------------
03:38:01.005 [ERROR] COMPILATION ERROR :
03:38:01.005 [INFO] -------------------------------------------------------------
03:38:01.005 [ERROR] /home/travis/build/apache/flink/flink-filesystems/flink-s3-fs-hadoop/src/test/java/org/apache/flink/fs/s3hadoop/HadoopS3FileSystemTest.java:[62,17] cannot find symbol
  symbol:   method checkHadoopConfigs(org.apache.flink.configuration.Configuration,java.lang.String,java.lang.String,java.lang.String)
  location: class org.apache.flink.fs.s3hadoop.HadoopS3FileSystemTest
03:38:01.005 [ERROR] /home/travis/build/apache/flink/flink-filesystems/flink-s3-fs-hadoop/src/test/java/org/apache/flink/fs/s3hadoop/HadoopS3FileSystemTest.java:[75,17] cannot find symbol
  symbol:   method checkHadoopConfigs(org.apache.flink.configuration.Configuration,java.lang.String,java.lang.String,java.lang.String)
  location: class org.apache.flink.fs.s3hadoop.HadoopS3FileSystemTest
03:38:01.006 [ERROR] /home/travis/build/apache/flink/flink-filesystems/flink-s3-fs-hadoop/src/test/java/org/apache/flink/fs/s3hadoop/HadoopS3FileSystemTest.java:[88,17] cannot find symbol
  symbol:   method checkHadoopConfigs(org.apache.flink.configuration.Configuration,java.lang.String,java.lang.String,java.lang.String)
  location: class org.apache.flink.fs.s3hadoop.HadoopS3FileSystemTest

It's broader than just china; its any endpoint which is v4 signing only: AWS frankfurt, Seoul, & some others. Also, moving from the classic "central" endpoint gives you better availability -removes it as a SPOF on your app"

It's broader than just china; it's any endpoint which is v4 signing only: AWS frankfurt, Seoul, & some others. Also, moving from the classic "central" endpoint gives you better availability -removes it as a SPOF on your app"

Hi @rmetzger I'm closing this PR since it's not necessary.

Thank you.
Sorry that I didn't look into the details earlier :(


I'd like to ask about the running environment and running steps

Hello, I am an undergraduate who has just come into contact with the knowledge map, and I have just read your paper. I would like to ask whether the code is running in Linux environment? Can I run and operate under windows? Second, what are the running steps of the code?
We look forward to your answers~

Hi~ We ran all the experiments on Ubuntu. I think the code would work well on Windows if you have properly installed the required packages, while I am not sure the results can be exactly reproduced. On Windows, you may have trouble in running a bash script. So just run the python command inside the runs.sh and fill the missing variables manually.

Hello, I'm sorry to disturb you again. When I run the code on Ubuntu, I report an error because I installed the CPU version of pytorch. I did not select the CUDA version. Is CUDA required?

Yes. CUDA is necessary.


docs(table): no hasFixedColumnWidths in IE11

Yep.

Coverage remained the same at 99.587% when pulling 18295867a51afe72ce98f7629bcc02c31a9811d2 on thallada/fixed-table into e337a28842a00fc7242a63cd3d94c4ab166349b7 on master.

Coverage remained the same at 99.587% when pulling 18295867a51afe72ce98f7629bcc02c31a9811d2 on thallada/fixed-table into e337a28842a00fc7242a63cd3d94c4ab166349b7 on master.


All breakpoints gets unverified on VSCode running a Yii2 advanced project. WHY?

Hello, I'm running an advanced Yii 2 app on XAMPP

VSCode Version: 1.17.2
OS Version: Windows 10

am trying to debug
I Disabled all extensions at the VS Code except from the PHP Debug 1.11.1
it didnt help.
every breakpoint I put gets immediatly unverified
Would appreciate a lot any hint...

@MichalYosef do breakpoints get immediately unverified while running a debug session or while outside of a session?

Immediatly
בתאריך 7 בנוב 2017 18:15, "Andre Weinand"<EMAIL_ADDRESS>כתב:
@MichalYosef https://github.com/michalyosef do breakpoints get
immediately unverified while running a debug session or while outside?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/37779#issuecomment-342534382,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYlEpbmnm_smWDCoS3zFAo3MO0Bn0D_Aks5s0IIygaJpZM4QVAC-
.

immediatley

sorry, but "immediately" is not a helpful answer. Let's try it again:
do breakpoints get unverified while running a debug session or while not running a debug session?

sorry but i dont understand how they can break when not running
anyways it seems like a more serious problem, right now my pc won't
restart....
בתאריך 8 בנוב 2017 00:00, "Andre Weinand"<EMAIL_ADDRESS>כתב:

sorry, but "immediately" is not a helpful answer. Let's try it again:
do breakpoints get unverified while running a debug session or while not
running a debug session?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/37779#issuecomment-342636517,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYlEpSHw_35JT_dmsL7fuPPS6bjDNvbmks5s0NLjgaJpZM4QVAC-
.

@weinand  Interesting.  I'm having the same issue.  All breakpoints become unverified.
Open php source.
Switch to debug.
Listen for XDebug
Set breakpoint in source file.
Access page that calls into function with breakpoint.
Breakpoint becomes unverified.

yep
same here
the breakpoints gets unverified on runtime
2017-11-08 0:33 GMT+02:00 mradcertica<EMAIL_ADDRESS>
@weinand https://github.com/weinand Interesting. I'm having the same
issue. All breakpoints become unverified.
Open php source.
Switch to debug.
Listen for XDebug
Set breakpoint in source file.
Access page that calls into function with breakpoint.
Breakpoint becomes unverified.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/37779#issuecomment-342646201,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AYlEpQjQKqjFwWeHBVdSpdC5uMMb3dJFks5s0NrJgaJpZM4QVAC-
.

This issue was moved to felixfbecker/vscode-php-debug#201

solved it by adding to php.ini -
[XDEBUG]
xdebug.remote_enable = 1
xdebug.remote_autostart = 1


Big decimal scale precision

Fix to handle precision and scale for TVP and BulkCopy. Fixes issue #230

@Arthurm1 I had to close the older PR because of merge conflicts. We have decided to stick with RoundingMode.HALF_UP to be consistent with SQL Server and other Microsoft client drivers of SQL Server.

Codecov Report

Merging #251 into dev will increase coverage by <.01%.
The diff coverage is 71.42%.

@@             Coverage Diff              @@
##                dev     #251      +/-   ##
============================================
+ Coverage     33.46%   33.46%   +<.01%
+ Complexity     1491     1490       -1
============================================
  Files            97       97
  Lines         23390    23381       -9
  Branches       3840     3834       -6
============================================
- Hits           7828     7825       -3
+ Misses        14001    13996       -5
+ Partials       1561     1560       -1

Flag
Coverage Δ
Complexity Δ

#JDBC41
33.35% <71.42%> (-0.02%)
1482 <0> (-1)

#JDBC42
33.43% <71.42%> (+0.08%)
1490 <0> (+9)
:arrow_up:

Impacted Files
Coverage Δ
Complexity Δ

...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
36.76% <100%> (-0.09%)
0 <0> (ø)

...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
44.85% <20%> (-0.21%)
182 <0> (-1)

...c/main/java/com/microsoft/sqlserver/jdbc/Util.java
41.13% <33.33%> (+1.22%)
53 <0> (+1)
:arrow_up:

.../microsoft/sqlserver/jdbc/SQLServerConnection.java
41.1% <0%> (-0.09%)
227% <0%> (-2%)

...om/microsoft/sqlserver/jdbc/SimpleInputStream.java
41.91% <0%> (+1.47%)
10% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 598a3b4...87949e3. Read the comment docs.

except the ArrayIndexOutOfBoundsException we have mentioned, anything else looks good to me. Let's add some tests to this PR before merging.


Fix test failures for XML comparisons

When running tests on the 3.1.4 release, I'm noticing several test failures, all of them having to do with harmless differences in Designspace XML generation: extra whitespace (such as different indentation), reordered attributes, and minor uppercase/lowercase differences (like 'encoding="UTF-8"' vs 'encoding="utf-8"' in the XML declaration).  Upon human examination, the generated XML output looks functionally identical to the expected output, but the tests are obviously just doing a flat text comparison.
I'd suggest we switch the affected tests to use an XML-specific comparison tool instead?  I've been able to adapt these tests to use xmldiff (https://pypi.org/project/xmldiff/) with fairly minor modifications.  Based on my observations, xmldiff in default mode responds to certain cases as follows:

Harmless whitespace differences are ignored (good)
XML declaration "encoding" value is treated as case-insensitive (good)
Other tag names, attribute names, and attribute values are treated as case-sensitive (good)
Functional alteration of any tag, attribute name, or attribute value is flagged (good)
Adding or removing tags or attributes is flagged (good)
Changing text content within a container is flagged (good)
Reordering attributes within a tag is ignored (good)
Reordering same-name tags within the same scope is flagged (good)
Reordering unique-name tags within the same scope is flagged (probably OK)
Adding XML comments is flagged (eeeeh...tolerable; doesn't hurt us at the moment)
Switching single vs. double quotes on attribute values is ignored (good)
Common XML syntax errors are flagged (good)

Overall, for me, xmldiff is smart enough about comparison to get tests to a solid pass.
The output on test failure is necessarily different; instead of common diff output, differences are itemized and reported in an XPATH-like syntax (IMHO this is probably better for XML, but people used to diff output might not appreciate it).
If we're OK with a change like this, I'll open a PR and sign on to the contributor agreement.

the diffs you see when running the tests locally are the result changes in upstream fontTools (specifically ufoLib and designspaceLib) in the way it writes out xml and plist files. They are harmless.
This CI faiulres are probably connected https://github.com/googlei18n/glyphsLib/pull/473
honestly to keep things simple I'd prefer not to use xmldiff but just update the expected test data and bump the minimum required fonttools to a more recent version that has those XML changes.
Would you like to contribute a patch in this direction instead?

Oh and thanks for your interest in glyphsLib :)

We could....but that seems like we're deliberately stuck on a treadmill, updating the test data over and over again for harmless changes.
As it is, the practical changes for xmldiff are pretty miniscule.  I'll post a PR shortly just for everyone to see what it entails.

ok

Sometimes it is good to have tests that check for sourcecode changes to be notifyed to avoid superficial git noise.

Fixed by #476


MINOR: fixes lgtm.com warnings

\cc @bbejeck @sebastiansemmle
Cf. https://lgtm.com/projects/g/apache/kafka/alerts/?mode=list

retest this please

Thanks @mjsax ! The changes LGTM as well.
@bbejeck @mjsax  If you like the checks you could enable our Pull Request integration, where we automatically run our analysis on every created PR as a check. If we find anything you can then browse through the results. The analysis runs on our infrastructure and only requires a single click to enable (the owner of your GitHub mirror will have to do it).
For an example of what this looks like, you can go over to the numpy project which recently enabled our Python analysis: https://github.com/numpy/numpy/pull/10630  (you need to be logged into GitHub to view it).
Let me know if you are interested and I point you in the right direction.

@SebastianBauersfeld @sebastiansemmle (which one is the right one?)
Thanks for pointing out that we could integrate those check. We cannot make this decision directly -- as an Apache project, there are some guidelines to follow (also not sure, if we need help from Apache Infra team in case we decide that we want this integration).

Retest this please

@mjsax Understood.
It is @sebastiansemmle, I logged in with the wrong one.

Updated this PR including a cleanup to Printed and how we handle STDOUT... Let me know what you think. We had some discussions about this, when introducing Printed -- thus, I am not sure if I might have missed something.

Retest this please

Retest this please

Retest this please.

Rebased (hope to get a green build than).
Also added one more commit with minor code cleanup.


Update city_schema.json

This PR fixes #219 by updating city_schema.json.
Note that nevertheless, some current city responses are not valid according to this schema.
Especially Aarhus and Koeln currently report states as "unknown", which IMHO should be reported as "nodata". Further, Koeln reports free=-1 for some parkings. As this seems to represent an unknown value. If true, it should rather be left out, as it is not mandatory.
Note further, that this schema uses some anyOf-type-validations, to allow currently used practice to specify null values for values required by the former schema, but apparently unknown. IMHO null should not be allowed for required properties, but that would result in rework for some data providers.
Finally, this schema s rather strict by not allowing additionalProperties. This kind of blocks experimental features, but uncovers properties not yet specified in the schema. Probably, additionalProperties should better be set to true.

Looks like the latest feedparser makes use of python 3.6 string formatting syntax (f'), which fails the build. I guess that either feedparser version should be frozen at an earlier version in requirements.txt or minimum compatibility raised to 3.6.

Looks like the latest feedparser makes use of python 3.6 string formatting syntax (f'), which fails the build. I guess that either feedparser version should be frozen at an earlier version in requirements.txt or minimum compatibility raised to 3.6.

Thanks for looking at this issue. I think we can safely drop Python 3.5 since even Debian Stable (which we use) has already Python 3.7. (see https://github.com/offenesdresden/ParkAPI/issues/222). Do you have any requirement in this regard? If you need Python 3.6 I would still include it otherwise I'd make Python 3.7 the minimum version.

No objections to moving to python 3.7 as minimum requirement. I'll open an issue to gather what needs to be done.

I resolve the state related change requests, switched additonalProperties to true, to allow custom extensions and updated the README.md example to reflect the schema.

I resolve the state related change requests, switched additonalProperties to true, to allow custom extensions and updated the README.md example to reflect the schema.

Fixed by https://github.com/offenesdresden/ParkAPI/commit/3f2eb3729965812a096c2ca93bee376689204b93.

Fixed by https://github.com/offenesdresden/ParkAPI/commit/3f2eb3729965812a096c2ca93bee376689204b93.


re publish access events on different channels

provide means to publish the events in different queue based systems (in alternative), such as:

AMQP
MQTT
NGSI-V2

Originally posted by @chicco785 in https://github.com/orchestracities/anubis/issues/17#issuecomment-1099570261

each data controller should be able to define it's one channel to received notifications of accesses to it's resources


Advanced validation for emails

I've noticed the current email regexp is passing following values:
<EMAIL_ADDRESS>"david.gilbertson@SOME+THING-ODD!!.com",
"a.b@example,com",
 "a.b@example,co.de"

Also instead writing custom regexp i've used an email regexp from the ruby library.

1

@rusllonrails Thanks man 🍻

Yes, it is just a simple check on purpose. Feel free to restrict it as you wish by setting Devise.email_regexp.

+1

@IlkhamGaysin LOH =)

@IlkhamGaysin mister PACMAN  LOH)


[FEAT] Journeys Missing Support for TMOS 17.x

Is your feature request related to a problem? Please describe.
F5 Journeys does not support TMOS 17.1 in the documentation or migration path.
Describe the solution you'd like
Journeys should list TMOS 17.1.x as a supported version and allow migrations to it.
Describe alternatives you've considered
It is possible to create AS3 and then POST to version 17.x, but this is less direct.

Support for TMOX 17.1. has been introduced with version 4.0.0


Terrafrom objects blocked waiting for non existent dependancies on delete

I have a number of terraform objects waiting to delete pending deletion of (now non-existent) terraform objects
kubectl get terraforms.infra.contrib.fluxcd.io
NAME                          READY     STATUS                                                                                AGE
dish-beta-cluster-c2-apps     Unknown   Initializing                                                                                14h
dish-beta-cluster-c2-config   False     Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-apps to resume ...          14h
dish-beta-cluster-c2-eks      False     Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-config to resume ...        14h
dish-beta-vpc-v1              False     Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-eks to resume ...           14h
dish-demo-vpc-v1              False     Deletion in progress, but blocked. Please delete dish-demo-edge-node-edge-one-ec2 to resume ...   3d17h
paulc:weaveworks-mgmt paulc [dish]$ kubectl logs -f dish-beta-cluster-c2-apps-tf-runner
Error from server (NotFound): pods "dish-beta-cluster-c2-apps-tf-runner" not found
paulc:weaveworks-mgmt paulc [dish]$ kubectl logs -f dish-beta-cluster-c2-apps-tf-runner
Error from server (NotFound): pods "dish-beta-cluster-c2-apps-tf-runner" not found
paulc:weaveworks-mgmt paulc [dish]$ kubectl logs -f dish-beta-cluster-c2-apps-tf-runner
Error from server (NotFound): pods "dish-beta-cluster-c2-apps-tf-runner" not found
paulc:weaveworks-mgmt paulc [dish]$ kubectl logs -f dish-beta-cluster-c2-apps-tf-runner
Error from server (NotFound): pods "dish-beta-cluster-c2-apps-tf-runner" not found
paulc:weaveworks-mgmt paulc [dish]$ kubectl get terraforms.infra.contrib.fluxcd.io
NAME                          READY     STATUS                                                                                AGE
dish-beta-cluster-c2-apps     Unknown   Initializing                                                                                14h
dish-beta-cluster-c2-config   False     Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-apps to resume ...          14h
dish-beta-cluster-c2-eks      False     Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-config to resume ...        14h
dish-beta-vpc-v1              False     Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-eks to resume ...           14h
dish-demo-vpc-v1              False     Deletion in progress, but blocked. Please delete dish-demo-edge-node-edge-one-ec2 to resume ...   3d17h
paulc:weaveworks-mgmt paulc [dish]$ kubectl logs -f dish-beta-cluster-c2-apps-tf-runner
Error from server (NotFound): pods "dish-beta-cluster-c2-apps-tf-runner" not found
paulc:weaveworks-mgmt paulc [dish]$ kubectl logs -f dish-beta-cluster-c2-apps-tf-runner
Error from server (NotFound): pods "dish-beta-cluster-c2-apps-tf-runner" not found
paulc:weaveworks-mgmt paulc [dish]$ kubectl logs -f dish-beta-cluster-c2-apps-tf-runner
Error from server (NotFound): pods "dish-beta-cluster-c2-apps-tf-runner" not found
paulc:weaveworks-mgmt paulc [dish]$ kubectl get pod
No resources found in default namespace.
paulc:weaveworks-mgmt paulc [dish]$ kubectl logs -f dish-beta-cluster-c2-apps-tf-runner
Error from server (NotFound): pods "dish-beta-cluster-c2-apps-tf-runner" not found
paulc:weaveworks-mgmt paulc [dish]$ kubectl logs -f dish-beta-cluster-c2-apps-tf-runner
Error from server (NotFound): pods "dish-beta-cluster-c2-apps-tf-runner" not found
paulc:weaveworks-mgmt paulc [dish]$ tfctl reconcile -n default dish-beta-cluster-c2-apps
 Reconcile requested for default/dish-beta-cluster-c2-apps
paulc:weaveworks-mgmt paulc [dish]$ kubectl logs -f dish-beta-cluster-c2-apps-tf-runner
2023/03/07 10:30:27 Starting the runner... version  sha
I0307 10:30:28.626524       7 request.go:682] Waited for 1.03610819s due to client-side throttling, not priority and fairness, request: GET:https://<IP_ADDRESS>:443/apis/admissionregistration.k8s.io/v1?timeout=32s
{"level":"info","ts":"2023-03-07T10:30:41.356Z","logger":"runner.terraform","msg":"preparing for Upload and Extraction","instance-id":""}
{"level":"info","ts":"2023-03-07T10:30:41.396Z","logger":"runner.terraform","msg":"write backend config","instance-id":"","path":"/tmp/default-dish-beta-cluster-c2-apps/cluster-templates/cluster-apps","config":"backend_override.tf"}
{"level":"info","ts":"2023-03-07T10:30:41.396Z","logger":"runner.terraform","msg":"write config to file","instance-id":"","filePath":"/tmp/default-dish-beta-cluster-c2-apps/cluster-templates/cluster-apps/backend_override.tf"}
{"level":"info","ts":"2023-03-07T10:30:41.399Z","logger":"runner.terraform","msg":"looking for path","instance-id":"","file":"terraform"}
{"level":"info","ts":"2023-03-07T10:30:41.404Z","logger":"runner.terraform","msg":"creating new terraform","instance-id":"c609a31d-479e-4844-90b4-ecf7a92f936e","workingDir":"/tmp/default-dish-beta-cluster-c2-apps/cluster-templates/cluster-apps","execPath":"/usr/local/bin/terraform"}
{"level":"info","ts":"2023-03-07T10:30:41.436Z","logger":"runner.terraform","msg":"setting envvars","instance-id":"c609a31d-479e-4844-90b4-ecf7a92f936e"}
{"level":"info","ts":"2023-03-07T10:30:41.441Z","logger":"runner.terraform","msg":"getting envvars from os environments","instance-id":"c609a31d-479e-4844-90b4-ecf7a92f936e"}
{"level":"info","ts":"2023-03-07T10:30:41.451Z","logger":"runner.terraform","msg":"setting up the input variables","instance-id":"c609a31d-479e-4844-90b4-ecf7a92f936e"}
{"level":"info","ts":"2023-03-07T10:30:41.453Z","logger":"runner.terraform","msg":"mapping the Spec.Values","instance-id":"c609a31d-479e-4844-90b4-ecf7a92f936e"}
{"level":"info","ts":"2023-03-07T10:30:41.454Z","logger":"runner.terraform","msg":"mapping the Spec.Vars","instance-id":"c609a31d-479e-4844-90b4-ecf7a92f936e"}
{"level":"info","ts":"2023-03-07T10:30:41.454Z","logger":"runner.terraform","msg":"mapping the Spec.VarsFrom","instance-id":"c609a31d-479e-4844-90b4-ecf7a92f936e"}
{"level":"error","ts":"2023-03-07T10:30:41.496Z","logger":"runner.terraform","msg":"unable to get object key","instance-id":"c609a31d-479e-4844-90b4-ecf7a92f936e","objectKey":{"namespace":"default","name":"dish-beta-cluster-c2-config"},"secret":"","error":"secrets \"dish-beta-cluster-c2-config\" not found"}
{"level":"info","ts":"2023-03-07T10:30:41.497Z","logger":"runner.terraform","msg":"cleanup TmpDir","instance-id":"c609a31d-479e-4844-90b4-ecf7a92f936e","tmpDir":"/tmp/default-dish-beta-cluster-c2-apps"}
rpc error: code = Unknown desc = Error: No such container: c27496ce063b5495acc94c1d62784a7ce2af849e43a1f3a854ec6fd2998baf7bpaulc:weaveworks-mgmt paulc [dish]$
paulc:weaveworks-mgmt paulc [dish]$
paulc:weaveworks-mgmt paulc [dish]$ name=dish-beta-cluster-c2-apps;kubectl patch terraforms.infra.contrib.fluxcd.io  $name  -p '{"metadata":{"finalizers":null}}' --type=merge; kubectl delete terraforms.infra.contrib.fluxcd.io  $name
terraform.infra.contrib.fluxcd.io/dish-beta-cluster-c2-apps patched
Error from server (NotFound): terraforms.infra.contrib.fluxcd.io "dish-beta-cluster-c2-apps" not found
paulc:weaveworks-mgmt paulc [dish]$ kubectl logs -f dish-beta-cluster-c2-apps-tf-runner
Error from server (NotFound): pods "dish-beta-cluster-c2-apps-tf-runner" not found
paulc:weaveworks-mgmt paulc [dish]$ kubectl get terraforms.infra.contrib.fluxcd.io
NAME                          READY   STATUS                                                                                AGE
dish-beta-cluster-c2-config   False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-apps to resume ...          14h
dish-beta-cluster-c2-eks      False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-config to resume ...        14h
dish-beta-vpc-v1              False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-eks to resume ...           14h
dish-demo-vpc-v1              False   Deletion in progress, but blocked. Please delete dish-demo-edge-node-edge-one-ec2 to resume ...   3d17h
paulc:weaveworks-mgmt paulc [dish]$ kubectl get terraforms.infra.contrib.fluxcd.io
NAME                          READY   STATUS                                                                                AGE
dish-beta-cluster-c2-config   False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-apps to resume ...          14h
dish-beta-cluster-c2-eks      False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-config to resume ...        14h
dish-beta-vpc-v1              False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-eks to resume ...           14h
dish-demo-vpc-v1              False   Deletion in progress, but blocked. Please delete dish-demo-edge-node-edge-one-ec2 to resume ...   3d17h
paulc:weaveworks-mgmt paulc [dish]$ kubectl get terraforms.infra.contrib.fluxcd.io
NAME                          READY   STATUS                                                                                AGE
dish-beta-cluster-c2-config   False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-apps to resume ...          14h
dish-beta-cluster-c2-eks      False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-config to resume ...        14h
dish-beta-vpc-v1              False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-eks to resume ...           14h
dish-demo-vpc-v1              False   Deletion in progress, but blocked. Please delete dish-demo-edge-node-edge-one-ec2 to resume ...   3d17h
paulc:weaveworks-mgmt paulc [dish]$ tfctl reconcile -n default dish-beta-cluster-c2-config
 Reconcile requested for default/dish-beta-cluster-c2-config
paulc:weaveworks-mgmt paulc [dish]$ kubectl get terraforms.infra.contrib.fluxcd.io
NAME                          READY   STATUS                                                                                AGE
dish-beta-cluster-c2-config   False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-apps to resume ...          14h
dish-beta-cluster-c2-eks      False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-config to resume ...        14h
dish-beta-vpc-v1              False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-eks to resume ...           14h
dish-demo-vpc-v1              False   Deletion in progress, but blocked. Please delete dish-demo-edge-node-edge-one-ec2 to resume ...   3d17h
paulc:weaveworks-mgmt paulc [dish]$ kubectl get terraforms.infra.contrib.fluxcd.io
NAME                          READY   STATUS                                                                                AGE
dish-beta-cluster-c2-config   False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-apps to resume ...          14h
dish-beta-cluster-c2-eks      False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-config to resume ...        14h
dish-beta-vpc-v1              False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-eks to resume ...           14h
dish-demo-vpc-v1              False   Deletion in progress, but blocked. Please delete dish-demo-edge-node-edge-one-ec2 to resume ...   3d17h
paulc:weaveworks-mgmt paulc [dish]$ kubectl get terraforms.infra.contrib.fluxcd.io
NAME                          READY   STATUS                                                                                AGE
dish-beta-cluster-c2-config   False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-apps to resume ...          14h
dish-beta-cluster-c2-eks      False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-config to resume ...        14h
dish-beta-vpc-v1              False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-eks to resume ...           14h
dish-demo-vpc-v1              False   Deletion in progress, but blocked. Please delete dish-demo-edge-node-edge-one-ec2 to resume ...   3d17h
paulc:weaveworks-mgmt paulc [dish]$ kubectl get terraforms.infra.contrib.fluxcd.io
NAME                          READY   STATUS                                                                                AGE
dish-beta-cluster-c2-config   False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-apps to resume ...          14h
dish-beta-cluster-c2-eks      False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-config to resume ...        14h
dish-beta-vpc-v1              False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-eks to resume ...           14h
dish-demo-vpc-v1              False   Deletion in progress, but blocked. Please delete dish-demo-edge-node-edge-one-ec2 to resume ...   3d17h
paulc:weaveworks-mgmt paulc [dish]$ kubectl get terraforms.infra.contrib.fluxcd.io
NAME                          READY   STATUS                                                                                AGE
dish-beta-cluster-c2-config   False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-apps to resume ...          14h
dish-beta-cluster-c2-eks      False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-config to resume ...        14h
dish-beta-vpc-v1              False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-eks to resume ...           14h
dish-demo-vpc-v1              False   Deletion in progress, but blocked. Please delete dish-demo-edge-node-edge-one-ec2 to resume ...   3d17h
paulc:weaveworks-mgmt paulc [dish]$ kubectl get terraforms.infra.contrib.fluxcd.io
NAME                          READY   STATUS                                                                                AGE
dish-beta-cluster-c2-config   False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-apps to resume ...          14h
dish-beta-cluster-c2-eks      False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-config to resume ...        14h
dish-beta-vpc-v1              False   Deletion in progress, but blocked. Please delete dish-beta-cluster-c2-eks to resume ...           14h
dish-demo-vpc-v1              False   Deletion in progress, but blocked. Please delete dish-demo-edge-node-edge-one-ec2 to resume ...   3d17h

Using version v0.14.0-rc.5 for controller and runner
Uploading tf.log…

ping @JamWils for refinement

I found that there was no retryInterval default value in TF-controller.
When not specified, retryInterval = interval, which might be a large value, say 1h, for TF controller workloads.
The default value of the retryInterval will be 15s from the next version forward.

The waiting logic is quite straightforward:
https://github.com/weaveworks/tf-controller/blob/be987f0b3f1494de2703486603b2935a1d94b17d/controllers/tf_controller.go#L151-L170


✨ Description
Authentication interfaces for both the Vitality frontend application and the frontend of the Backoffice (BO), with a focus on protecting source code privacy.
🚀 Motivation
By controlling access to projects, the authentication system ensures that only authorized users can configure and view sensitive source code and reports, preserving their confidentiality and integrity.
📝 Proposed Solution
The Frontend and Frontend BO are the only components directly exposed to users, the authentication layer should be implemented primarily on the BFF side.
How the authentication flow would work:

User Authentication: The user interacts with the authentication interface on the Frontend or Frontend BO.
BFF Authentication: The Frontend/Frontend BO sends authentication requests (e.g., login) to the BFF.
Authentication Backend: The BFF communicates with the authentication backend to verify user credentials.
Token Generation: Upon successful authentication, the authentication backend generates an access token (e.g., JWT).
Token Validation: The BFF validates the token and grants access to the requested resources (project data, analysis reports, etc.).

Verify that all Frontend & Frontend BO routes are protected.
Along with Apollo Server Authentication, we can use passportjs:
const server = new ApolloServer({
  typeDefs,
  resolvers,
  context: async ({ req }) => {
    // Authenticate the user using Passport.js
    let user = null;
    try {
      user = await new Promise((resolve, reject) => {
        passport.authenticate('jwt', { session: false }, (err, user) => {
          if (err) reject(err);
          resolve(user);
        })(req);
      });
    } catch (error) {
      console.error('Authentication error:', error);
    }

    return { user };
  },
});

🔗 Relevant Links (if any)

https://www.apollographql.com/docs/apollo-server/security/authentication
https://www.apollographql.com/docs/react/networking/authentication
https://github.com/helabenkhalfallah/node-express-mongoose-sqlize/blob/master/passport/passport.js
https://www.passportjs.org/

Frontend:

Create UI for authentication: create account/login/logout/password forget/token
BFF authentication: create account/login/logout/password forget/token

Frontend BO:

Authentication UI exists. You should connect this files to BFF:
https://github.com/ekino/v6y/blob/main/src/v6y-front-bo/src/infrastructure/providers/GraphQLProvider.ts#L30

Use the same BFF authentication as the Frontend.

Final result:
All Frontend and Frontend BO screens should been protected with authentication access.
Inspirational examples:
https://github.com/ekino/v6y/blob/main/src/v6y-front-bo/src/app/page.tsx#L11
https://github.com/ekino/v6y/blob/main/src/v6y-front-bo/src/app/v6y-faqs/layout.tsx#L6
https://gitlab.ekino.com/renault/mfs/myze-battery/-/blob/main/apps/front/components/ProtectedRoute.tsx#L7
"use client";

import { useRouter } from "next/navigation";
import { useEffect } from "react";
import { useLogin } from "../hooks/useAuth";

export function ProtectedRoute({ children }: React.PropsWithChildren<{}>) {
  const { isLoggedIn, isLoginLoading } = useLogin();
  const router = useRouter();

  useEffect(() => {
    if (!isLoggedIn && !isLoginLoading) {
      router.replace("/");
    }
  }, [isLoggedIn, isLoginLoading, router]);

  return isLoggedIn ? children : null;
}

import { PropsWithChildren } from "react";
import { ProtectedRoute } from "./ProtectedRoute";
import RouteErrorHandler from "./errors/RouteErrorHandler";

type Props = {
  error?: Error | null;
};

export default function RouteWrapper({
  error,
  children,
}: PropsWithChildren<Props>) {
  return (
    <ProtectedRoute>
      <RouteErrorHandler error={error}>{children}</RouteErrorHandler>
    </ProtectedRoute>
  );
}

// https://gitlab.ekino.com/renault/mfs/myze-battery/-/blob/main/apps/front/app/profile/layout.tsx

import { PropsWithChildren } from "react";
import RouteWrapper from "../../components/RouteWrapper";

export default function ProfileLayout({ children }: PropsWithChildren) {
  return (
    <RouteWrapper>

          {children}

    </RouteWrapper>
  );
}

Mutation example:
Frontend:
const CreateOrEditApplication = gql`
    mutation CreateOrEditAccount($accountInput: ApplicationCreateOrEditInput!) {
        createOrEditApplication(applicationInput: $applicationInput) {
            _id
        }
    }
`;

Create useMutationAdapter:
https://github.com/ekino/v6y/tree/main/src/v6y-front/src/infrastructure/adapters/api
Inside useMutationAdapter, we use TanStackQuery Mutation:
https://tanstack.com/query/latest/docs/framework/react/reference/useMutation
export const useClientMutation = <TData = unknown,>({
    mutationCacheKey,
    mutationBuilder,
}: UseClientMutationParams<TData>) => {
    return useMutation<TData, Error>(params);
};

Consume Mutation:
    const {
        isLoading,
        data,
    } = useClientMutation(params);
```

**BFF:**
1) Create a folder account
2) Create a type: `AccountType`
3) Add `AccountType` to `VitalityTypes`
4) Add type : `CreateOrEditAccountType`
5) Add `AccountType` to `CreateOrEditAccountType`
6) Add `AccountMutationsType`
7) Add type : `AccountMutationsType`
8) Create resolver for each `AccountMutationsType` function

```
const createOrEditApplication = async (
    _: unknown,
    params: { applicationInput: ApplicationInputType },
) => {
    try {
```

9) Add Database model and Provider in `v6y-commons/database` then export on  `v6y-commons/index.js`
10) Use exposed model and provider in the resolver.

Tasks:

[ ] Creation BFF
[ ] Validation BFF
[ ] Branchement Frontend
[ ] Branchement Frontend BO

User Account Management
Super Admin:

Can create and manage admins and users.
Has full access to the entire back office, including:

Creating applications (and other content like FAQ, etc.).
Modifying applications, FAQs, and other resources.
Managing the overall system.

Can access both the back office and the front (like users).

Admin:

Can create and manage users.
Has access to most back office functionalities, including:

Creating applications and users.
Modifying applications and other resources (like FAQs).

Cannot create or modify admins (only the super admin can).
Can access both the back office and the front (like users).

User:

Can only access the front.

Cannot access the back office.

Can view and interact with applications and front functionalities.


Keyswitch buggy after update to ios16.2 on phone and homepod

Bug Description
After updating to iOS 16.2 on iPhone and HomePod, assigned Keyswitch on "Out" zone will switch off when reopen HomeKit app.
Steps To Reproduce
Turn on Keyswitch on Homekit app.
Minimise app or close app.
Reopen app.
Keyswitch turned off
Expected Behavior
Keyswitch should remain on
Environment (please complete the following information as best possible)

Homebridge System:

Node.js Version
NPM Version
Homebridge/HOOBS Version
Operating System: (Raspbian / Ubuntu / Debian / Windows / macOS / Docker)
Process Supervisor: *(Docker / Systemd / init.d / pm2 / launchctl / hb-service / other / none)

Konnected Panel(s):

Panel Hardware Version
Firmware Version
Addon Panel(s)
Interface Panel(s)

Attach Files to Support Your Experience

Screenshots of your Konnected App device settings screen
Debug Log (turn on debugging in Homebridge/HOOBS and copy the results into a text file starting from boot up to shortly after the where the issue occurs)
Homebridge/HOOBS config.json file and or plugin section from the config.json found in your .homebridge folder.

Additional Relevant Information

even though the keyswitch turned off, the alarm system didn't turn off. Manually turning off the keyswitch will turn off the alarm.

restore backup to v1.1.8 and keyswitch working as intended.

I need more context … please answer the initial questions and provide details.

Bug Description
Keyswitch assigned to "Out" on panel. It is used to arm traditional alarm panel. When switch on Keyswitch, it will remained "On", arming my traditional alarm. When keyswitch "Off", my traditional alarm will disarm.  Working as intended on v1.1.8
After updating to v1.3.1, along with all the Homebridge updates + iOS16.2, when Keyswitch is used, it will arm my panel as usual. After minimised or close/relaunch the Home App, the keyswitch status will be off. But the alarm is still on. Meaning the "Out" is high state, but the icon display is off.
To disarm, I press the Keyswitch icon to on, then press again to off, only then will disarm (meaning "Out" = low state).
Sorry, if I didn't explain properly.
Steps To Reproduce
Turn on Keyswitch on Homekit app.
Minimise app or close app.
Reopen app.
Keyswitch turned off
Expected Behavior
Keyswitch should remain on
Environment (please complete the following information as best possible)
Homebridge System:
Node.js Version v16.16.0
NPM Version
Homebridge/HOOBS Version v1.6.0
Operating System: Raspbian GNU/Linux Bullseye (11)
Process Supervisor: *unknown
Konnected Panel(s):
Panel Hardware Version
Firmware Version
Addon Panel(s)
Interface Panel(s)
Attach Files to Support Your Experience
Debug Log (turn on debugging in Homebridge/HOOBS and copy the results into a text file starting from boot up to shortly after the where the issue occurs)
Homebridge/HOOBS config.json file and or plugin section from the config.json found in your .homebridge folder.
My current working config with v1.1.8
"platforms": [
{
"name": "Konnected",
"panels": [
{
"name": "Konnected Panel 2",
"uuid": "",
"ipAddress": "<IP_ADDRESS>",
"port": 15301,
"blink": true,
"zones": [
{
"enabled": true,
"zoneNumber": "1",
"zoneType": "contact",
"zoneLocation": "Ceiling"
},
{
"enabled": true,
"zoneNumber": "out",
"zoneType": "switch",
"zoneLocation": "Keyswitch Latch",
"switchSettings": {
"trigger": "high"
}
},
{
"enabled": true,
"zoneNumber": "5",
"zoneType": "contact",
"zoneLocation": "Siren",
"binarySensorSettings": {
"invert": true,
"triggerableModes": [
"1"
]
}
},
{
"enabled": true,
"zoneNumber": "6",
"zoneType": "contact",
"zoneLocation": "Armed/Disarmed",
"binarySensorSettings": {
"invert": true
}
},
{
"enabled": true,
"zoneNumber": "2",
"zoneType": "contact",
"zoneLocation": "Master Bedroom Contact"
},
{
"enabled": true,
"zoneNumber": "3",
"zoneType": "contact",
"zoneLocation": "Kid's Room Contact"
}
]
},
{
"name": "Konnected Panel 1",
"uuid": "",
"ipAddress": "<IP_ADDRESS>",
"port": 14917,
"blink": true,
"zones": [
{
"enabled": true,
"zoneNumber": "1",
"zoneType": "contact",
"zoneLocation": "Entrance"
},
{
"enabled": true,
"zoneNumber": "2",
"zoneType": "contact",
"zoneLocation": "Living Room"
},
{
"enabled": true,
"zoneNumber": "3",
"zoneType": "contact",
"zoneLocation": "Kitchen"
},
{
"enabled": true,
"zoneNumber": "4",
"zoneType": "contact",
"zoneLocation": "Master Balcony Door"
},
{
"enabled": true,
"zoneNumber": "5",
"zoneType": "contact",
"zoneLocation": "Kids' Balcony Door"
},
{
"enabled": true,
"zoneNumber": "6",
"zoneType": "contact",
"zoneLocation": "Ceiling Panel"
},
{
"enabled": false,
"zoneNumber": "out",
"zoneType": "siren",
"zoneLocation": "Study"
}
]
}
],
"platform": "konnected"
Additional Relevant Information
I already revert to v1.1.8. Unable to update to reproduce results as I will be away until next week.  The double keyswitch actuation is because of the automation I run. When Armed contact sensor opens, automation will run Keyswitch On. Coz if I manually arm from my traditional alarm panel, then I want the Keyswitch to be On.
Even if i turn off my automations, the keyswitch icon becomes Off still happens.

I see the issue and can reproduce now.
This has to do with some sort of change in the handling of the value of the state in the HomeKit characteristic.
I will modify my code now to accommodate this change.


Feature Request: Automated weekly reminder for TOC members with pending vote

In the past voting through DL was a nice way to remind TOC members that they still have to vote. However, with the new approach this is gone as everything is done through emoji votes.
It would be nice to have an automated reminder every week to give a nudge to TOC members that have not voted yet to bring this to their attention.
Relates to https://github.com/cncf/toc/pull/925

This isn't a bad idea @tegioz if we can configure or automate reminders here

We now list and mention pending voters when the vote status is checked. This, when used in combination with the automatic status check, can be used to schedule reminders periodically and at the same time report how the vote goes. If this gets too noisy for the voters we may need to revisit it, but let's see how it goes. We'll deploy it tomorrow morning 🙂


Dependencies :Moved  From zerver/lib/openapi.py to zerver/openapi/openapi.py

openapi: Move openapi.py into zerver/openapi.
Fixes #14006

Can you squash the two commits and add a nice commit message?  Thanks!

I have squashed the commits as one please review @showell

Please google Zulip commit message guidelines.

This pull will resolve the issue https://github.com/zulip/zulip/issues/14006 and helps to close it

Please read these docs on how to write nice commit messages:
https://github.com/zulip/zulip/blob/master/docs/contributing/version-control.md#commit-messages
A good one here would be:
openapi: Move openapi.py into zerver/openapi.

Fixes #14006

Please re-read my comment and please re-read the commit guidelines.  There should be a space after the colon and a period at the end of the sentence.
See https://github.com/zulip/zulip/commits/master for examples.

Please re-read my comment and please re-read the commit guidelines. There should be a space after the colon and a period at the end of the sentence.
See https://github.com/zulip/zulip/commits/master for examples.

okay

Can you please check again?

Merged, thanks @harshbisle!


Allow use of https for the PowerDNS provider

Hello,
We would like to use https to secure the connection between octodns and powerdns, but according to https://github.com/github/octodns/blob/master/octodns/provider/powerdns.py#L34 this appears to be "hard coded" to http. Is this a change you would consider? If so, I can get a PR going for making this a configurable option, with http being the default.

Is this a change you would consider? If so, I can get a PR going for making this a configurable option, with http being the default.

Definitely. Should hopefully be as simple as adding an optional parameter scheme or something like that. Happy to take a look at a PR. Thanks.


potodo fails on divide by 0

If you run potodo in the potodo folder, you get a divide by 0 error

hmm cannot reproduce now

Well this fails:
python3 -m potodo -p /home/vincent/Documents/programmation/name-photos-by-date/

To make it fail, you have to execute potodo in a git-versioned folder without any po files…
For a non git-versioned folder, you get:
Traceback (most recent call last):
  File "/home/vincent/Documents/programmation/Potodo/potodo/github.py", line 17, in get_repo_url
    url = subprocess.check_output(
  File "/usr/lib/python3.8/subprocess.py", line 411, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib/python3.8/subprocess.py", line 512, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['git', 'remote', 'get-url', '--all', 'upstream']' returned non-zero exit status 128.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/vincent/Documents/programmation/Potodo/potodo/github.py", line 25, in get_repo_url
    url = subprocess.check_output(
  File "/usr/lib/python3.8/subprocess.py", line 411, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib/python3.8/subprocess.py", line 512, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['git', 'remote', 'get-url', '--all', 'origin']' returned non-zero exit status 128.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "/home/vincent/Documents/programmation/Potodo/potodo/__main__.py", line 3, in <module>
    __import__("potodo.potodo").potodo.main()
  File "/home/vincent/Documents/programmation/Potodo/potodo/potodo.py", line 492, in main
    exec_potodo(**args)
  File "/home/vincent/Documents/programmation/Potodo/potodo/potodo.py", line 130, in exec_potodo
    issue_reservations = get_issue_reservations(offline, hide_reserved, path)
  File "/home/vincent/Documents/programmation/Potodo/potodo/github.py", line 98, in get_issue_reservations
    issue_reservations = _get_reservation_list(repo_path)
  File "/home/vincent/Documents/programmation/Potodo/potodo/github.py", line 61, in _get_reservation_list
    + get_repo_name(repo_path)
  File "/home/vincent/Documents/programmation/Potodo/potodo/github.py", line 43, in get_repo_name
    repo_url = get_repo_url(repo_path)
  File "/home/vincent/Documents/programmation/Potodo/potodo/github.py", line 32, in get_repo_url
    raise RuntimeError(
RuntimeError: Unknown error. `git remote get-url --all origin` returned "fatal: ni ceci ni aucun de ses répertoires parents n'est un dépôt git : .git".

Should the division be fixed (happens only without any po file!), this is a division by the number of entries to translated, including translated ones?

Well on 0.19.1 the ousite of git is fixed
(venv) ➜  python-docs-fr git:(3.9) potodo -p ~/
potodo needs to be ran in a git repository, or use the `-p` `--path` argument.

Now for the divide by zero, I added a condition at the end of your code (here https://github.com/AFPy/Potodo/blob/master/potodo/potodo.py#L157)
I dont understand your question tho

I was wondering if it was useful to correct it, but you did the job. So it's OK like this :wink:

Cool !


[Feature] List Partition For AMV(Part 2): Support list partition for asynchronous materialized view with non-nullable partition columns

Why I'm doing:
What I'm doing:

Support mv refresh for list partitioned amv;
Support mv rewrite for list partitioned amv;

CREATE TABLE t3 (
      id BIGINT,
      province VARCHAR(64) not null,
      age SMALLINT,
      dt VARCHAR(10) not null
)
DUPLICATE KEY(id)
PARTITION BY LIST (province, dt) (
     PARTITION p1 VALUES IN (("beijing", "2024-01-01"))  ,
     PARTITION p2 VALUES IN (("guangdong", "2024-01-01")),
     PARTITION p3 VALUES IN (("beijing", "2024-01-02"))  ,
     PARTITION p4 VALUES IN (("guangdong", "2024-01-02"))
)
DISTRIBUTED BY RANDOM;
INSERT INTO t3 VALUES (1, 'beijing', 20, '2024-01-01'), (2, 'guangdong', 20, '2024-01-01'), (3, 'guangdong', 20, '2024-01-02');

-- test sync refresh & partition_refresh_number= 1
create materialized view test_mv1
partition by province
REFRESH DEFERRED MANUAL
distributed by hash(dt, province) buckets 10
PROPERTIES (
"replication_num" = "1"
)
as select dt, province, sum(age) from t3 group by dt, province;
refresh materialized view  test_mv1 with sync mode;
select * from test_mv1 order by 1, 2;
function: check_hit_materialized_view("select dt, province, sum(age) from t3 group by dt, province order by 1, 2;", "test_mv1")
select dt, province, sum(age) from t3 group by dt, province order by 1, 2;
INSERT INTO t3 VALUES (2, 'beijing', 20, '2024-01-01');
function: check_hit_materialized_view("select dt, province, sum(age) from t3 group by dt, province order by 1, 2;", "test_mv1")
select dt, province, sum(age) from t3 group by dt, province order by 1, 2;
drop materialized view test_mv1;

Fixes #46087
What type of PR is this:

[ ] BugFix
[x] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.3
[ ] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@mergifyio backport branch-3.3


Adding platform versions to Package.swift

You can see the error in the screenshot below. The error happens when using Swift PM. Platform specification fixes the issue.

Sorry I missed this. The latest in aws-sdk-swift includes these. I have one fix to bring in and I'll copy everything across.

updated with platform info


New expression blocks

closes #477
proposed by @geospatial-jeff in slack: use ; instead of , to support multi-blocks expression.
To avoid breaking change/major release, we will still support , delimited blocks, so users who wants to use , in expression HAVE TO put a ; at the end of the expression

expression="where((b1==1) | (b1 > 0.5),1,0)" -> ["where((b1==1) | (b1 > 0.5)" , "1" ,"0)"]  # Not OK

expression="where((b1==1) | (b1 > 0.5),1,0);" -> ["where((b1==1) | (b1 > 0.5),1,0)"]  # OK

I understand this is not optimal but IMO it's the better solution (to my knowledge) to avoid using complex regex or hacky solution. But I'm 👂
Note:
https://numexpr.readthedocs.io/projects/NumExpr3/en/latest/user_guide.html#supported-functions
where(bool, number1, number2), arctan2(float1, float2), {real,imag}(complex), complex(float, float), sum(number, axis=None) and prod(number, axis=None) are the NumExpr function which could need a ,.

@vincentsarago thank you for your super quick fix. I plan to use these features to experiment with doing some raster algebra
on the fly. After this merge do I need to update rio-tiler from github?

I'll try to have a release today if @geospatial-jeff and @kylebarron help me 😄
as mentioned in ☝ to be able to use complex expression you'll need to add ; at the end of the expression.


Avoid call tree.children if not editor exists

Hi @patrys This PR fixs #11: property children of undefined

Thank you!


Big push towards 1.0.0

Did a lot of small updates, tweaks and bugfixes to the framework.
Almost ready for release to 1.0.0. Only things to do remain:

Updating brane-ide so it works again (meaning some crates might need updating here too)
Updating brane-job to use per-workflow transfer proxies.

Getting very close now - I think I essentially want to freeze Brane as-is for release 1.0.0, except maybe that the make downloading is still broken, and the CI/CD scripts are broken too. Maybe we will fix this later and then worry about merging later.


remove timeouts from web test platform.

Description
30 seconds might not be enough time to load all of the required files.

This didn't work :(