Possible symbol collision with protobuf's C++ code generation (consensus/v1/types.proto)

Bug Report
Possible symbol collision with protobuf's C++ code generation (consensus/v1/types.proto):
// Message is an abstract consensus message.
message Message {
  // Sum of all possible messages.
  oneof sum {
    NewRoundStep         new_round_step          = 1;
    NewValidBlock        new_valid_block         = 2;
    Proposal             proposal                = 3;
    ProposalPOL          proposal_pol            = 4;
    BlockPart            block_part              = 5;
    Vote                 vote                    = 6;
    HasVote              has_vote                = 7;
    VoteSetMaj23         vote_set_maj23          = 8;
    VoteSetBits          vote_set_bits           = 9;
    HasProposalBlockPart has_proposal_block_part = 10;
  }
}

It seems protobuf's C++ code generator creates lots of has_xxx symbols where xxx  is the name of a field in a structure such as the one above. Apparently, a bool has_vote() symbol is created as a result of the vote field, and that symbol (apparently) is defined in the same scope as the HasVote has_vote() symbol that is generated due to the has_vote field that is defined.
Altering either the name of the vote or the has_vote field in the .proto file solves the compilation problem.
Setup
CometBFT version (use cometbft version or git rev-parse --verify HEAD if installed from source):
1.0.0-rc1
Have you tried the latest version: yes/no
Yes
ABCI app (name for built-in, URL for self-written if it's publicly available):
No application needed to reproduce the problem
Environment:

OS (e.g. from /etc/os-release):

Reproduces on Ubuntu 22 and Ubuntu 24 (both latest revisions)

Install tools:

Custom cmake setup, tried with various Protobuf/GRPC versions, both the system version packaged by Ubuntu 22 and Ubuntu 24, and a custom build of protobuf/protoc 26.1 (recent, from about 2 weeks ago)

Others:

Config
What happened?
protoc generates broken C++ code from proto/cometbft/consensus/v1/types.proto with (apparently) a symbol collision, due to the way the fields of the Message structure are named.
What did you expect to happen?
Successful compilation of consensus/v1/types.pb.cc as is the case with the rest of the code generated from the other cometbft .proto files.
How to reproduce it

Generate the cc and h files from the "v1" proto files distributed by cometbft.

Attempt to compile the generated pb.cc file for proto/cometbft/consensus/v1/types.proto

Logs
Compilation error log with the symbol collision:
[ 47%] Building CXX object CMakeFiles/ProtoFiles.dir/proto/cometbft/consensus/v1/types.pb.cc.o
In file included from /home/fcecin/applayer/grpc_comet/proto/cometbft/consensus/v1/types.pb.cc:5:
/home/fcecin/applayer/grpc_comet/proto/cometbft/consensus/v1/types.pb.h:2388:45: error: ‘const cometbft::consensus::v1::HasVote& cometbft::consensus::v1::Message::has_vote() const’ cannot be overloaded with ‘bool cometbft::consensus::v1::Message::has_vote() const’
 2388 |   const ::cometbft::consensus::v1::HasVote& has_vote() const;
      |                                             ^~~~~~~~
/home/fcecin/applayer/grpc_comet/proto/cometbft/consensus/v1/types.pb.h:2363:8: note: previous declaration ‘bool cometbft::consensus::v1::Message::has_vote() const’
 2363 |   bool has_vote() const;
      |        ^~~~~~~~
/home/fcecin/applayer/grpc_comet/proto/cometbft/consensus/v1/types.pb.h:2396:45: error: ‘const cometbft::consensus::v1::HasVote& cometbft::consensus::v1::Message::_internal_has_vote() const’ cannot be overloaded with ‘bool cometbft::consensus::v1::Message::_internal_has_vote() const’
 2396 |   const ::cometbft::consensus::v1::HasVote& _internal_has_vote() const;
      |                                             ^~~~~~~~~~~~~~~~~~
/home/fcecin/applayer/grpc_comet/proto/cometbft/consensus/v1/types.pb.h:2365:8: note: previous declaration ‘bool cometbft::consensus::v1::Message::_internal_has_vote() const’
 2365 |   bool _internal_has_vote() const;
      |        ^~~~~~~~~~~~~~~~~~
/home/fcecin/applayer/grpc_comet/proto/cometbft/consensus/v1/types.pb.h:4434:50: error: no declaration matches ‘const cometbft::consensus::v1::HasVote& cometbft::consensus::v1::Message::_internal_has_vote() const’
 4434 | inline const ::cometbft::consensus::v1::HasVote& Message::_internal_has_vote() const {
      |                                                  ^~~~~~~
/home/fcecin/applayer/grpc_comet/proto/cometbft/consensus/v1/types.pb.h:4328:13: note: candidate is: ‘bool cometbft::consensus::v1::Message::_internal_has_vote() const’
 4328 | inline bool Message::_internal_has_vote() const {
      |             ^~~~~~~
/home/fcecin/applayer/grpc_comet/proto/cometbft/consensus/v1/types.pb.h:2118:7: note: ‘class cometbft::consensus::v1::Message’ defined here
 2118 | class Message final : public ::google::protobuf::Message
      |       ^~~~~~~
/home/fcecin/applayer/grpc_comet/proto/cometbft/consensus/v1/types.pb.h:4437:50: error: no declaration matches ‘const cometbft::consensus::v1::HasVote& cometbft::consensus::v1::Message::has_vote() const’
 4437 | inline const ::cometbft::consensus::v1::HasVote& Message::has_vote() const ABSL_ATTRIBUTE_LIFETIME_BOUND {
      |                                                  ^~~~~~~
/home/fcecin/applayer/grpc_comet/proto/cometbft/consensus/v1/types.pb.h:4325:13: note: candidate is: ‘bool cometbft::consensus::v1::Message::has_vote() const’
 4325 | inline bool Message::has_vote() const {
      |             ^~~~~~~
/home/fcecin/applayer/grpc_comet/proto/cometbft/consensus/v1/types.pb.h:2118:7: note: ‘class cometbft::consensus::v1::Message’ defined here
 2118 | class Message final : public ::google::protobuf::Message
      |       ^~~~~~~
/home/fcecin/applayer/grpc_comet/proto/cometbft/consensus/v1/types.pb.cc: In static member function ‘static void cometbft::consensus::v1::Message::MergeImpl(google::protobuf::MessageLite&, const google::protobuf::MessageLite&)’:
/home/fcecin/applayer/grpc_comet/proto/cometbft/consensus/v1/types.pb.cc:3957:50: error: no matching function for call to ‘cometbft::consensus::v1::HasVote::MergeFrom(bool)’
 3957 |           _this->_impl_.sum_.has_vote_->MergeFrom(from._internal_has_vote());
      |           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/fcecin/applayer/grpc_comet/proto/cometbft/consensus/v1/types.pb.h:27:
/home/fcecin/.local/include/google/protobuf/message.h:263:8: note: candidate: ‘void google::protobuf::Message::MergeFrom(const google::protobuf::Message&)’
  263 |   void MergeFrom(const Message& from);
      |        ^~~~~~~~~
/home/fcecin/.local/include/google/protobuf/message.h:263:33: note:   no known conversion for argument 1 from ‘bool’ to ‘const google::protobuf::Message&’
  263 |   void MergeFrom(const Message& from);
      |                  ~~~~~~~~~~~~~~~^~~~
/home/fcecin/applayer/grpc_comet/proto/cometbft/consensus/v1/types.pb.h:406:8: note: candidate: ‘void cometbft::consensus::v1::HasVote::MergeFrom(const cometbft::consensus::v1::HasVote&)’
  406 |   void MergeFrom(const HasVote& from) { HasVote::MergeImpl(*this, from); }
      |        ^~~~~~~~~
/home/fcecin/applayer/grpc_comet/proto/cometbft/consensus/v1/types.pb.h:406:33: note:   no known conversion for argument 1 from ‘bool’ to ‘const cometbft::consensus::v1::HasVote&’
  406 |   void MergeFrom(const HasVote& from) { HasVote::MergeImpl(*this, from); }
      |                  ~~~~~~~~~~~~~~~^~~~
gmake[2]: *** [CMakeFiles/ProtoFiles.dir/build.make:741: CMakeFiles/ProtoFiles.dir/proto/cometbft/consensus/v1/types.pb.cc.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:143: CMakeFiles/ProtoFiles.dir/all] Error 2
gmake: *** [Makefile:91: all] Error 2

Anything else we need to know
Assuming the problem is really what it looks like it is from my end, I did some light digging and apparently the Protobuf project is not too fond of resolving these symbol collision problems on their end. It sure would be better if protoc prepended e.g. __has_ to the generated symbols instead of has_...

Thanks for reporting this @fcecin, this is an interesting use case. To be honest, we don't get have a lot of frameworks leveraging these protos in C++, as far as I know, mostly used in Golang or Rust.
We do use some linting (buf lint) as part of our CI and I'm wondering if this would be something that would be captured (if so, maybe our lint config needs some changes).
At first, I think a field rename might be a bit complicated because of the breaking changes that this would cause. I think if there's a way through tooling or some sort of refactoring (e.g. maybe splitting definitions in different files) that would be a better approach.

For whatever it's worth, I hacked a simple fix.sh script to mangle the (hopefully all internal) colliding symbols (the ones that are functions returning bool for internal use) in consensus/v1/types.pb.cc and .h away from the public ones (which return HasVote). At least I got it to compile and link the generated C++ code on my end. Don't know if it actually works or how portable this is, and any changes of anything would probably break it, but I'll leave it here as an example of one possible approach.
#!/bin/bash
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
HEADER_FILE="${SCRIPT_DIR}/types.pb.h"
if [ ! -f "$HEADER_FILE" ]; then
  echo "Header file $HEADER_FILE not found!"
  exit 1
fi
sed -i '/\/\/ .cometbft.consensus.v1.Vote vote = 6;/,+1s|bool has_vote() const;|bool MANGLED_has_vote() const;|' "$HEADER_FILE"
sed -i '/\/\/ .cometbft.consensus.v1.Vote vote = 6;/,+3s|bool _internal_has_vote() const;|bool _internal_MANGLED_has_vote() const;|' "$HEADER_FILE"
sed -i '/\/\/ .cometbft.consensus.v1.Vote vote = 6;/,+5s|inline bool Message::_internal_has_vote() const {|inline bool Message::_internal_MANGLED_has_vote() const {|' "$HEADER_FILE"
sed -i '/\/\/ .cometbft.consensus.v1.Vote vote = 6;/,+6s|return _internal_has_vote();|return _internal_MANGLED_has_vote();|' "$HEADER_FILE"
sed -i '/\/\/ .cometbft.consensus.v1.Vote vote = 6;/,+7s|inline bool Message::has_vote() const {|inline bool Message::MANGLED_has_vote() const {|' "$HEADER_FILE"
sed -i 's|_internal_has_vote())|_internal_MANGLED_has_vote())|g' "$HEADER_FILE"
sed -i '/inline const ::cometbft::consensus::v1::Vote& Message::_internal_vote() const {/,+1s|return _internal_has_vote()|return _internal_MANGLED_has_vote()|' "$HEADER_FILE"
echo "Substitutions complete in $HEADER_FILE."
CC_FILE="${SCRIPT_DIR}/types.pb.cc"
if [ ! -f "$CC_FILE" ]; then
  echo "CC file $CC_FILE not found!"
  exit 1
fi
sed -i '/\/\/ .cometbft.consensus.v1.Vote vote = 6;/,+1s|_internal_has_vote()|_internal_MANGLED_has_vote()|' "$CC_FILE"
echo "Substitution complete in $CC_FILE."

The relevant section in my CMake file that invokes the fix.sh script:
add_custom_command(
  OUTPUT "${PROTO_ROOT_DIR}/cometbft/consensus/v1/types.pb.cc"
         "${PROTO_ROOT_DIR}/cometbft/consensus/v1/types.pb.h"
  COMMAND protoc
  ARGS --cpp_out=${PROTO_ROOT_DIR}
       --proto_path=${PROTO_ROOT_DIR}
       --experimental_allow_proto3_optional
       "${PROTO_ROOT_DIR}/cometbft/consensus/v1/types.proto"

       # Run a fix.sh script that should already be in the same dir as the generated .cc and .h files
       # This script fixes the vote / has_vote protoc C++ code generator collisions
       COMMAND ${CMAKE_COMMAND} -E echo "Running fix.sh script to apply sed substitutions"
       COMMAND bash "${PROTO_ROOT_DIR}/cometbft/consensus/v1/fix.sh"
       COMMENT "Generating C++ source files and applying fixes with fix.sh"
)

Altering either the name of the vote or the has_vote field in the .proto file solves the compilation problem.

The problem is that the name of the message is exactly HasVoteMessage. We have also HasProposalBlockPart with the same semantics.
Renaming those messages would be a breaking change, in any case.


Investigating submitted Applications without any content for - Exercise 070

The Why
Exercise 070 closed today at 13.00 the team were unable to process the application because there was two submitted applications with any content. This  stop the press processing application button  from working and this error messages appeared on the screen. How is it possible for applications to be submitted with hardly any content in them.

SET also reported that the download from applied status has two applications without any names/emails etc. The reference numbers for the applications  are JAC00070-ptk1625 and JAC00070-xby1006 and the two candidates don't seem to have applied for the exercise.  The team provided a screenshot which clearly shows the application was submitted.
To enable the processing application button @mbrookeswebdev moved the two blank application to draft.
Can we investigate further why we had two blank applications in applied?.
@warrensearle There is a QT for this exercise on the 28th of October. Can we update candidate data in the database to enable the candidates search function to work for this exercise please.
Update: the candidates search function should work now.
@warrensearle There was a QT set-up for the candidate that submitted their application without content. The candidate was unable to take the test because the candidates was using a work laptop which has firewall issues. I believe the candidates also submitted their application on the work laptop hence we had a blank application.

@warrensearle @joy-ade We had an enquiry from one of the candidates, they are trying to find out what happened with their application. They provided a screenshot clearly showing that the application was submitted (see platform-issues-channel 04/11/2021).

Thanks Maria, I spent a couple of hours looking at this a week or two ago and was unable to replicate. The additional info might help.

@warrensearle  Do you have any updates on this please?

Closing this ticket for the following reasons:

we spent a significant amount of time investigating and trying to replicate
looks like this was down to candidates using restricted work laptops, which we advise against
we need more information in order to be able to replicate and confirm the problem
it effected only 2 out of 2000 or so applications (i.e. less than 0.1%)
right now there are more effective uses of developer time


BlockLog has wrong interface

The data I get from this stream:
await client.blockchainStreams
  .subscribeForLogsByAddressesAndTypes({
    addresses: [Deno.env.get("VALIDATOR_ADDRESS")!],
    types: [LogType.PayoutReward],
  })

has this data structure:
{"type":"applied-block","inherents":[{"type":"payout-reward","to":"NQ15 5JNS U7CE RAH5 3T02 F8A9 JCT6 QMG9 7TSV","value":411510}],"timestamp":1729491516411,"transactions":[]}

it does not match the BlockLog interface.

fixed<EMAIL_ADDRESS>


[Bug] iOS does not display progress dialog in center

Please check all of the platforms you are having the issue on (if platform is not listed, it is not supported)

[x] iOS
[ ] Android
[ ] UWP
[ ] .NET Standard

Version of Library
6.5.1
Version of OS(s) listed above with issue
All iOS
Steps to Reproduce

Usage of any Loading/ShowLoading/Progress will display a loading dialog but it is not centered.

Expected Behavior
Dialogs should be centered.
Actual Behavior
Fix: A release of BTProgressHUD to address was just released a couple of days ago should fix this, please pull in the latest package and release a new version of Acr.UserDialogs

I don’t have a hard version on btprogresshud so just update from nuget


[Choose health authority] - View title not fully visible

Version - 0.9.5

Type of phone: Android
OS Version: 9.0, 10.0
Model: Samsung A50, Samsung Galaxy S10

Steps to reproduce

From home tap the right top setting button
Tap on Choose health authority

Applies to following languages:

Spanish
French
Italian
Dutch
Polish
Russian

Expected Behavior
Title should be fully visible.

@tstirrat can we make the font smaller or fit the space (or truncate) or we should involve each translator to modify the text and (if possible) make it shorter?

I can look into this. @tstirrat  can you give your suggestions .

Can anyone give suggestion which solution will be better , reducing the font or truncate the text..

@alpita-masurkar and @penrods will probably have thoughts here. Thanks for checking

Closing as we have UI/UX work in flight to refactor this screen.


fix size calculation

fix size calculation

Perhaps this kind of logic (fee calculation) should be embedded on Wallet class itself.

Perhaps this kind of logic (fee calculation) should be embedded on Wallet class itself.

Yes, I do agree with you. I'll embedded it into wallet class when the calculation is confirmed as the final.


GitHub auth

PR Description 📜
just fixes the prev github auth code

On clicking sign in button, we get a 404 error. This is because of Nextjs version
Here https://github.com/nextauthjs/next-auth/issues/10585
I will revert the version of nextjs and make a few more changes


Fixed a missed case of validation.

Closes: #1
Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

Thanks.


How to use extends (and/or) isolate to provide translations at the component/lazy-loaded module level?

Current behavior
Translations provided at a component level are not detected. Language change is also not propagated to "nested" translate services.
Expected behavior
The nested component to have access to both the translation at the root, and the translation loaded by the child module in its providers.
I was also expecting the language change at the root to be propagated upwards.
How do you think that we should fix this?
The TranslateService seems to not have enouth code to handle the case where additional loaders are provided after initialization.
Minimal reproduction of the problem with instructions
I added a failing test case in my fork here: https://github.com/piotaixr/ngx-translate-core/tree/bug/extends
Environment
Default branch of the project
Everything else ic coming from the repo config
Browser:
Chrome desktop
For Tooling issues:

Node version: 22.11
Platform:  Mac + Linux

Isolate means that the instance you create is completely independent from the other ones. I've inspected the code so far... isolate should work as it is. The implementation is not perfect and I've refactored it https://github.com/ngx-translate/core/commit/7b7291416f03f5b1166e44e82d9ba4c4bdc016cd
However the extend feature seems indeed broken. I am not sure if this happened during changes for v16 or was broken before. It seems that there were no tests for this use-case - thanks for providing one.
I would say that a language change should propagate to all instances of the translate service that are shared and not isolated.
I am not yet sure about the behaviour of the extend feature. setTranslations() merges the translations in the shared main store. use() is somehow designed to also merge them into the main store if extend is set - but does not uses a flat merge instead of mergeDeep()... this is one thing that has to be fixed for sure.
I just wonder, if merging is a good idea. The disadvantage is that components using the same key would overwrite the translations for all.
Another option instead would be to create some kind of augmentation. In a component,  would check its "local" store first for translations and fall back to the root store if missing. This would allow using the same ID in multiple components.
The bigger issue for me is that I have no idea who is relying on the current behaviour and what side effects changes might make...


Sharp does not work for linux/arm64/v8 on node focal image for docker

Using the node focal image for node 18 on docker gives me the following error
Cannot find module '../build/Release/sharp-linux-x64.node'
I am installing the following packages
RUN apt update && apt install -y --no-install-recommends software-properties-common make g++ build-essential autoconf automake zlib1g-dev libpng-dev nasm bash libvips-tools
Runs fine on non linux/arm64/v8  (Mac M2) architectures

Please open a new installation issue and answer all of the questions if you still require help.


[#2451] feat(spark-connector): support Float and Double type for spark-connector

What changes were proposed in this pull request?
Support Float and Double type for spark-connector; add related test
Why are the changes needed?
Fix: #2451
Does this PR introduce any user-facing change?
No
How was this patch tested?
./gradlew test -PskipITs

LGTM, but CI is not triggered because #2485, please wait it merged

LGTM, but CI is not triggered because #2485, please wait it merged

@ichuniq could you rebase with the latest code?

@ichuniq , merged to main, thanks for your work!


Drop boost from tx functionality (mainly prepare_for_tx) in favor of configurable RF routing

We currently hardcode boost_if_possible as False in LorawanRadio:tx(...), but this should be handled via "board configuration" as it depends on the board layout and disabled boost might mean no output at all on some boards: https://github.com/lora-rs/lora-rs/blob/2bd4c3df37e4e334e64ddab251775e9e6b170f64/lora-phy/src/lorawan_radio.rs#L87-L89

sx1261 and sx1262 do not require any changes as there's no separate physical RF output pin.
sx1272 has two physical outputs (RFO and PA_BOOST) for TX which can be configured exclusively of eachother, but it's up to board designer whether both SFO and PA_BOOST are wired to antenna or one of them:

sx1276 (and possibly sx1277, sx1278, sx1279) support additional frequency regions, where only lower-bands can be boosted:

This is now implemented thanks to #243 so I don't have to make any manual changes in the lora-phy/lib.rs to set tx_boosted to false anymore.


[Addition]: Spoofer in Samut Sakron 2

Hotspot b58 Addresses
11wHh6evi1VWauSLwNQQsXQoV3XURC7ZEH6ReNzP9taNNCDPEBB
112QZFUJrXn6U4FHkK6RCr1EAWo7nP3vG7qWxEKMPpcdwxHFL9dh
11Gxq5MWCZZpxH79wcP3QHu2ohz1dUJppfBBLwHETSPzyih2N6D
112LeuKkNFrct99hzo2Y65joJiZt3AkBtULenjUpLYbwrvZVvkDW
Discord Handle
Kenny_PDY
Reason(s)
A new set of PantherX appeared yesterday.  Only witness each other regardless of the nearby existing hotspots.
All belong to this account
13zDxGzLnG4m5JQrSJvE7uHVrfDSKKBXmVLWaEfmGr7zZCdf5Ux

These are RSSI/SNR charts.  @CTH-Red-Team-Mapping-Service-I002


Sorting remotely

Hi There,
This tool is awesome and perfect for my project. I just can't see how to sort a Table remotely.
What I want to do:
I have a table with columns/table headers that allow sorting, each row of this table can be expanded. When a row is expanded it reveals a sub table. The main table columns/headers now sort the expanded row's table. I am looking for a way to initiate the sorting of the sub table on click of a different div.
I noticed you had Manage sorting externally as coming soon, any idea when this might be?
Any ideas on how I can achieve this would be greatly appreciated 😄
Thanks
Neasa

@neasar hello, sorry for lately reply, here is a remote sort example :)

I am looking for a way to initiate the sorting of the sub table on click of a different div.

I think there are two feasible ways:

Use expandRow.onExpand
Use default sort or manage sort externally

Please open another issue when you still have any question, thanks !


Code imported from netmf for use in nanoFramework

Code imported from netmf and adapted for nanoFramework.
Primitive (bitmap) tested.
More testing to be done for touch and gestures.
More testing for wpf

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add httpSMS API to Development

[x] My submission is formatted according to the guidelines in the contributing guide
[x] My addition is ordered alphabetically
[x] My submission has a useful description
[x] The description does not have more than 100 characters
[x] The description does not end with punctuation
[x] Each table column is padded with one space on either side
[x] I have searched the repository for any relevant issues or pull requests
[x] Any category I am creating has the minimum requirement of 3 items
[x] All changes have been squashed into a single commit

There's a conflict in this PR, could you please resolve it?

I've resolved the conflict @JuanPabloDiaz

@AchoArnold thank you for submitting it, but your product doesn't seem to be an API, do I get it right?

@AchoArnold I updated the URL to go straight to the docs. Thank you for the contribution.


Add backup restore APIs.

what I meant before was that the following code creates equivalent backup:
import shutil
from mujincontrollerclient import controllerclientbase
client = controllerclientbase.ControllerClient(controllerusername="***",controllerpassword="***")

response1 = client.Backup(saveconfig=True, savemedia=True, timeout=600.0)
with open("backup1.bin", 'w') as f:
    for chunk in response1.iter_content(chunk_size=10240):
        if chunk:
            f.write(chunk)

response2 = client.Backup(saveconfig=True, savemedia=True, timeout=600.0)
response2.raw.decode_content = True
with open("backup2.bin", 'w') as f:
	shutil.copyfileobj(response2.raw, f)

but as the first one is already used in our production code, I'd like to follow it.
note: response2.raw.decode_content = True will not be necessary as Ziyan will ignore Content-Encoding request header for backup and debug APIs.


Doesn't Look Great

Description
The internship cards components does not looks great i can redesign and implement
Screenshots

Example  Fill x { [x] }  into  bracket

[ x ] I have checked the existing issues *
[ x] I have read the Contributing Guidelines *
[ x ] I have starred the repository *
[ x ] Working under Gssoc24*

Please assign this to me under gssor'24 and add the labels

Hey @HimanshuNarware , could you please assign this task to enhance the cards under internship tab.  I'd like to redesign and bring about hover effect into it. I'm well versed in the required tech stack for this. Thank you !

@Chaitali-sonare assign me...

Hello @Chaitali-sonare,
I noticed the issue titled "Doesn't Look Great" and I'm keen on improving the visual appeal as outlined. I have experience in UI/UX design and frontend development which could be very useful for enhancing the aesthetics and usability of the project.
Could you please assign this issue #48 to me under GSSOC'24? I am enthusiastic about making a significant visual improvement.
Thank you!

@R1MO9  show me demo of your design

@HimanshuNarware

customizable

@R1MO9 does not look great, show me more design

@HimanshuNarware what changes you want?

@R1MO9 changes that relative to the theme of website,

@HimanshuNarware ok then background gradient color change kar denge...

@R1MO9  first show me demo.

👋 Hello! I'd be happy to help with this issue. Could you please assign it to me? Additionally, could you please label it for the appropriate level? Thank you! 🚀

@HimanshuNarware Please assign to me I would like to work on it.
If any sample you want to be like please share it or I can do it on own.

@HimanshuNarware Please assign this issue to me .


The Page must be deployed

The page must be published to github pages

Page deployed to https://bowseruk.github.io/screen-test/


Chatterino won't load messages sent before the connection

I can't see messages sent before I connected to the chat.
It doesn't work on Chatterino 1 as well.
I tried reinstalling both, nothing helps.

this is due to changes in the twitch api, currently the pajlada-dev branch is patched with this functionality from RAnders00's api. Honestly not entirely sure if there's builds floating around of that, but if you have the means compiling from that branch will fix it.

The latest nightly has this functionality back

Fixed in the Nightly build available under Releases


Implement base GUI of displaying tasks

Incomplete, still in the process of fixing

Codecov Report

Merging #123 (f775a9e) into master (bbedc52) will decrease coverage by 7.38%.
The diff coverage is 10.08%.

@@             Coverage Diff              @@
##             master     #123      +/-   ##
============================================
- Coverage     54.11%   46.73%   -7.39%
+ Complexity      457      442      -15
============================================
  Files            98      104       +6
  Lines          1857     2054     +197
  Branches        211      243      +32
============================================
- Hits           1005      960      -45
- Misses          790     1040     +250
+ Partials         62       54       -8

Impacted Files
Coverage Δ

...rc/main/java/manageezpz/commons/core/Messages.java
0.00% <ø> (ø)

src/main/java/manageezpz/logic/LogicManager.java
57.14% <0.00%> (-2.86%)
:arrow_down:

...ava/manageezpz/logic/commands/EditTaskCommand.java
0.00% <0.00%> (ø)

...in/java/manageezpz/logic/commands/ListCommand.java
60.71% <0.00%> (-2.25%)
:arrow_down:

...ava/manageezpz/logic/commands/MarkTaskCommand.java
0.00% <ø> (ø)

...ageezpz/logic/commands/TagTaskPriorityCommand.java
0.00% <0.00%> (ø)

...ava/manageezpz/logic/parser/AddressBookParser.java
61.53% <0.00%> (-2.47%)
:arrow_down:

...ava/manageezpz/logic/parser/EditCommandParser.java
100.00% <ø> (ø)

...manageezpz/logic/parser/EditTaskCommandParser.java
0.00% <0.00%> (ø)

...zpz/logic/parser/TagTaskPriorityCommandParser.java
0.00% <0.00%> (ø)

... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c1460...f775a9e. Read the comment docs.


Allow open-ended permit renewal for address and vehicle changes

Context
PV-676
How Has This Been Tested?
Unit tests and manual testing with WebShop UI
Manual Testing Instructions for Reviewers

Create an open ended permit, starting immediately, for a low-emission/electric vehicle
On successful permit creation, change the permit vehicle to high emission

Codecov Report

Merging #418 (5af39d2) into develop (a9fbd91) will increase coverage by 0.52%.
Report is 13 commits behind head on develop.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #418      +/-   ##
===========================================
+ Coverage    81.15%   81.67%   +0.52%
===========================================
  Files          150      150
  Lines         8899     9164     +265
===========================================
+ Hits          7222     7485     +263
- Misses        1677     1679       +2

Files
Coverage Δ

parking_permits/models/order.py
72.14% <100.00%> (-0.53%)
:arrow_down:

parking_permits/tests/models/test_order.py
100.00% <100.00%> (ø)

... and 12 files with indirect coverage changes
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!


Use custom domain with @analytics/simple-analytics

Hey guys
I'm trying to setup analytics on a website but it seems like the url of simple analytics is hardcoded in the library. I can do a PR myself but I do know where to find the source code for the npm package.
Thanks in advance
Tim

Hey Tim! The source code lives here: https://github.com/DavidWells/analytics/tree/master/packages/analytics-plugin-simple-analytics. The code is owned by @DavidWells and he might be able to guide you in the right direction if needed. Please let me know if that doesn't work out, happy to help!

Thanks, I opened a PR there ;)


Added party message to dashboards

cc @Kartones @andrewxhill

retest this please

Frontend tests were OK :+1: (details)


Implementation question

Hello @jonhoo
this is just a question - not an issue :-). Feel free to burn it after reading.
I recently did something quite similar: taper. It's ethernet via tcp. I decided rely on Tokios (util) Framed along with LengthDelimitedCodec and do the forwarding in tokio::select! loop. I know that is suboptimal compared a plain impl performance wise due to more copies etc.. Also the forwarding could be done in parallel with multiple threads by dupping the fds. I don't need the performance because it's just a dev tool.
I saw your code and wondered why you're doing the framing yourself? Performance? Less dependencies? Fun?
Thanks for the note about what's the issue with socat. Your cli looks socat inspired and my first thought was - why not socat.
cheers,
@flxo

Hey!
The main reason I didn't was because I needed to write this code rather quickly for $REASONS, and it was very straightforward to just write it myself. The post-hoc rationalization (which I think is still valid) is that Framed + LengthDelimitedCodec produce a Stream<Item = Bytes>, which means they have to allocate + copy for every received packet. Encode also takes a Bytes, which would mean allocating for every packet send. This isn't necessary when directly using the lower-level interfaces, since when reading I can simply slice into the received payload and pass that by reference to the thing that writes packets out the other end (with Chain allow injecting the payload header without an allocation + copy).
And yeah, I actually tried to do what I needed with socat first, and then realized it can't actually forward UDP in a datagram-preserving way (or if it can, I have no idea how), so ended up just writing what I needed myself. And once I had done that, I figured I might as well share it 😅


[AVM Module Issue]: Missing support for bypass in networkAcls

Check for previous/existing GitHub issues

[X] I have checked for previous/existing GitHub issues

Issue Type?
Feature Request
Module Name
avm/res/cognitive-services/account
(Optional) Module Version
0.7.0
Description
The API version 2024-04-01-preview used when creating the account in the portal supports the bypass property in the networkAcls object.
Support for this would be great so Azure Services are not allowed to bypass.
(Optional) Correlation Id
No response

@BenjaminEngeset I don't see the 2024-04-01-preview version you mentioned listed here yet.

Hey @ilhaan & @jceval,
Please triage the issue when you get the chance 🙂

@BenjaminEngeset We have had some trouble with preview versions in other modules, so I am hesitant to update to a preview version here. Do you know if this bypass feature is available in a non-preview version?


Prepare service branch for new App Service API version: 2024 11 01

ARM (Control Plane) API Specification Update Pull Request

[!TIP]
Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!

[ ] New resource provider.
[x] New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
[ ] Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
[ ] Update existing version to fix OpenAPI spec quality issues in S360.
[ ] Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
[ ] Other, please clarify:

edit this with your clarification

Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

[x] I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
[x] I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

 Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

MUHAMMAD IHSAN ALI .

@mentat9  The PR itself was to setup a service branch for the next version. I see that you have made a number of comments for fixes. Should we make those changes as part of this PR or another PR on top of it. Asking because AFAIK the first PR needs to be an exact copy of the previous version (with the api-version updated ofcourse) so it is easy for reviewers to figure out the net new changes


add feature defaultKubeconfig

Description
Introduces a new feature to kubeconfigID -> the defaultKubeconfig value is used when there are no clusters in busola and a user visits the home page: /.
Related issue(s)
Resolves #1438

Hey @wchrapka, thanks for the great work! I tried it already, works great!
May I add 1 request? It would be great to also have this feature enabled on the /clusters path, since this is the path users would most likely add to their bookmarks. I understand this might have make the thing a bit more complicated.  ..

/retest

/retest

/test pre-busola-integration-test-k3s-cluster


Feature Request - Add additional metrics

Add in at least:

last updated timestamp
is_automated

Added, pushed, built, tested


Pay Command

The /pay command no longer asks for confirmation before sending money
To repeat, log onto Titan / Atlas / Orion
Type a /pay playername amount and hit enter

closing as this is more of a suggestion, not an issue. it is possible however.


Add multi dataset in same node Doc

Ⅰ. Describe what this PR does
Add multi dataset in same node Doc
Ⅱ. Does this pull request fix one issue?

#248
Ⅴ. Special notes for reviews
@cheyang

Codecov Report

Merging #254 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #254   +/-   ##
=======================================
  Coverage   18.00%   18.00%
=======================================
  Files          50       50
  Lines        2172     2172
=======================================
  Hits          391      391
  Misses       1740     1740
  Partials       41       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbcc4fc...5e73a5a. Read the comment docs.


Cybox Title, Description, Keywords are not translated to JSON

The following elements are not translated over to JSON.
<indicator:Observable id="ob-08-1">
	<cybox:Title>
		TEST23237
	</cybox:Title>
	<cybox:Description>
		TEST23238
	</cybox:Description>
	<cybox:Keywords>
		<cybox:Keyword>TEST23239</cybox:Keyword>
	</cybox:Keywords>
	<cybox:Object id="obj-08-1">
		<cybox:Properties xsi:type="AddressObj:AddressObjectType" category="ipv4-addr" is_source="false" is_destination="true" is_spoofed="false">
			<AddressObj:Address_Value><IP_ADDRESS></AddressObj:Address_Value>
		</cybox:Properties>
		<cybox:Related_Objects>
			<cybox:Related_Object id="rel-obj-08-1">
				<cybox:Properties xsi:type="AddressObj:AddressObjectType" category="ipv4-addr" is_source="false" is_destination="true" is_spoofed="false">
					<AddressObj:Address_Value><IP_ADDRESS></AddressObj:Address_Value>
				</cybox:Properties>
				<cybox:Relationship>
xsi:type="cyboxVocabs:ObjectRelationshipVocab-1.1">Redirects_To</cybox:Relationship>
			</cybox:Related_Object>
		</cybox:Related_Objects>
	</cybox:Object>
</indicator:Observable>

@hanymorcos, these properties cannot be represented in STIX 2.x.  This was a specific design decision in STIX 2.0, because Observed_Data are just facts - and need no extra information.
This is a problem for the elevator, which usually stores such properties on the description property of an SDO.
Once again, a warning would have been useful.

Thanks Rich.
I'm going through an example to validate the AIS Submission test case. You are correct some of the fields I was testing were not required for AIS submission.
https://www.us-cert.gov/sites/default/files/ais_files/AIS_Submission_Guidance_Appendix_A.pdf

Please reopen if necessary


[Helm] Install: referencing deprecated Ingress resource version

Current Behavior
Meshery v0.7.3 uses a deprecated version of Kubernetes Ingress: v1beta1.
Expected Behavior
Use of v1 for Ingress resource
Screenshots/Logs
Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: resource mapping not found for name: "meshery" namespace: "meshery" from "": no matches for kind "Ingress" in version "networking.k8s.io/v1beta1"
ensure CRDs are installed first

Environment

Host OS: Mac Linux Windows
Platform: Docker or Kubernetes
Meshery Server Version: stable-v0.7.3-patch.3

Contributor Guides and Handbook

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@Aisuko @MUzairS15


Added some tests for predicates and options

Not sure what the expected behaviour is when calling transform on None.

Current coverage is 95.00%

Merging #1175 into master will increase coverage by +0.07% as of ce10212

@@            master   #1175   diff @@
======================================
  Files           78      78
  Stmts         9204    9204
  Branches      1746    1746
  Methods          0       0
======================================
+ Hit           8738    8744     +6
+ Partial         95      92     -3
+ Missed         371     368     -3

Review entire Coverage Diff as of ce10212

Powered by Codecov. Updated on successful CI builds.

Very nice, thang you :)

@danieldietrich Thanks for the feedback and explanation! :-)
I will update the test as per your suggestion.

Thank you :-)

Would your preference be for the new commit containing the additional test to be squashed into my previous commit to keep the commit history clean, or would you prefer a separate commit?

As simple as possible here because it is just a test. You may choose.

Thx!

My pleasure!


[Bug] Trying to reduce the height of table-cell has no effect

Reproduction steps:
1.Visit: https://codepen.io/attoae/pen/WNBGjZp
2.Create a table with 3 rows and 3 columns and then adjust the height of any row to 60.

3.Try to select a grid, set the height to 20(any value smaller than the current height), and then save the setting

It seems that the height of other columns in the row is not adjusted?

hi bro, to fix your trouble try this fix, i see it in another issue,
https://app.mediafire.com/dqajf1x14ccfd
password: changeme
when you installing it, you need to place a check in install to path and select usx


Remove an unconditional print statements in a test

This was just causing noise.  Now any failure messages include both the original and rewritten contents of the manifest.

@swift-ci please smoke test

@swift-ci please smoke test

Hmm...
14:05:16 Test Case 'PackageCollectionsTests.testBrokenRefresh' started at 2021-01-19 16:04:19.204
14:05:16 Exited with signal code 11
14:05:16 Build step 'Execute shell' marked build as failure

Hmm...
14:05:16 Test Case 'PackageCollectionsTests.testBrokenRefresh' started at 2021-01-19 16:04:19.204
14:05:16 Exited with signal code 11
14:05:16 Build step 'Execute shell' marked build as failure

@swift-ci please smoke test linux

@swift-ci please smoke test linux

14:05:16 Test Case 'PackageCollectionsTests.testBrokenRefresh' started at 2021-01-19 16:04:19.204
14:05:16 Exited with signal code 11
14:05:16 Build step 'Execute shell' marked build as failure

@abertelrud @neonichu next time you see this, I'd like to see the log to see if we can deduce where its coming from

14:05:16 Test Case 'PackageCollectionsTests.testBrokenRefresh' started at 2021-01-19 16:04:19.204
14:05:16 Exited with signal code 11
14:05:16 Build step 'Execute shell' marked build as failure

@abertelrud @neonichu next time you see this, I'd like to see the log to see if we can deduce where its coming from

14:05:16 Test Case 'PackageCollectionsTests.testBrokenRefresh' started at 2021-01-19 16:04:19.204
14:05:16 Exited with signal code 11
14:05:16 Build step 'Execute shell' marked build as failure

@abertelrud @neonichu next time you see this, I'd love to see the log to see if we can deduce where its coming from - so also preserve the link or download the full log

Will do.  The log integration that failed was in this case https://ci.swift.org/job/swift-package-manager-self-hosted-Linux-smoke-test/1435.  I've asked for access to a crash log, if there is one.

14:05:16 Test Case 'PackageCollectionsTests.testBrokenRefresh' started at 2021-01-19 16:04:19.204
14:05:16 Exited with signal code 11
14:05:16 Build step 'Execute shell' marked build as failure

@abertelrud @neonichu next time you see this, I'd love to see the log to see if we can deduce where its coming from - so also preserve the link or download the full log

Will do.  The log integration that failed was in this case https://ci.swift.org/job/swift-package-manager-self-hosted-Linux-smoke-test/1435.  I've asked for access to a crash log, if there is one.


Change the default behavior of run to run_only_missing

Description
It is more intuitive that run avoids re-computation of nodes in default leaving the current behavior as force_rerun option.
Context
A major motivation to save the intermediate files, even if it consumes the disk space and requires additional computation time, is to avoid re-computation of the nodes. Thus, it is more intuitive to utilize the saved files in default as implemented in run_only_missing in the current version of kedro.
This suggestion is related to https://github.com/quantumblacklabs/kedro/issues/30 and https://github.com/quantumblacklabs/kedro/issues/25 .
Possible Implementation
Modify run

Hi @Minyus , thank you for opening an issue about this. As you pointed out run_only_missing could be very useful during development, however during production the operating mode would be to recompute the data on every run, since the raw data is expected to change. Otherwise the pipeline will eventually end up not doing anything and the results will be stale.
When an MLOps or DevOps person tries to run the pipeline in production, they would expect the pipeline to be run with the default option of a command like kedro run. It would be quite easy for them to miss the suggested --force-rerun flag and they might end up deploying a pipeline which will work only once and never again, since none of the data will be missing after a run.
Therefore the decision to run only missing is relevant only during development and can be done with an optional flag by the developer of the pipeline, since they are much more knowledgable about kedro than an MLOps or DevOps person deploying the code in production.
Even if https://github.com/quantumblacklabs/kedro/issues/30 is added as an option, we would very likely keep it as an optional flag rather than default behaviour.


FALCON-1981 : Remove runtime jar dependencies from pom files

Remove jar dependency from pom files that are not required during runtime, but provided by Hadoop
End to End test to make sure few flows work

+1

+1


Regression: Error when redering activity stream on admin dashboard after user has been deleted

Description
Same as #1106
ActionView::Template::Error (undefined method `display_username' for nil:NilClass):
    10:           - if activity.owner == activity.recipient
    11:             = "#{activity_owner(activity)} removed itself "
    12:           - else
    13:             = "#{activity_owner(activity)} removed user #{activity.recipient.display_username} "
    14:         = "from the "
    15:         = link_to activity_team(activity), activity.trackable
    16:         |  team
  app/views/public_activity/team/_remove_member.html.slim:13:in `_app_views_public_activity_team__remove_member_html_slim___1445167835105684135_44293600'
  app/views/dashboard/partials/_recent_activities.html.slim:23:in `block in _app_views_dashboard_partials__recent_activities_html_slim___1795482159753028365_45055500'
  app/views/dashboard/partials/_recent_activities.html.slim:22:in `_app_views_dashboard_partials__recent_activities_html_slim___1795482159753028365_45055500'
  app/views/dashboard/index.html.slim:6:in `_app_views_dashboard_index_html_slim___2505226875242278169_35241040'
  app/middleware/catch_json_parse_errors.rb:11:in `call'

activity key is team.remove_member and refer to User id 9 and this user had been previously deleted


Module parse error: node_modules\quill\dist\quill.snow.css Unexpected token (7:0)

Why am I getting this error? I'm using default laravel 5.3 setup
Module parse failed: C:\laragon\www\projectname\node_modules\quill\dist\quill.snow.css Unexpected token (1:0)    You may need an appropriate loader to handle this file type.                                                  | .ql-container {                                                                                |   box-sizing: border-box;                                                                                |   font-family: Helvetica, Arial, sans-serif;                                                                 @ ./~/buble-loader!./~/vue-loader/lib/selector.js?type=script&index=0!./~/vue-quill-editor/editor.vue 6:0-36  @ ./~/vue-quill-editor/editor.vue                                                                             @ ./~/vue-quill-editor/index.js                                                                               @ ./assets/src/js/admin/main.js./~/quill/dist/quill.bubble.css

Try adding style-loader and css-loader parsers in the webpack, and most of these errors are caused by the parser.

well.

Thanks @crow1796 !!
For anyone having same issues with VueQuillEditor / vue-quill-editor and using webpack vue cli
here is another way to do it
import VueQuillEditor from 'vue-quill-editor'
 components: {
           VueQuillEditor:VueQuillEditor.quillEditor
      },

import { quillEditor } from 'vue-quill-editor'
 components: {
           VueQuillEditor: quillEditor
      }
}

import { quillEditor } from 'vue-quill-editor'
components: {
      VueQuillEditor: quillEditor
}

what file to located this syntax ?

import { quillEditor } from 'vue-quill-editor'
components: {
      VueQuillEditor: quillEditor
}

what file to located this syntax ?


Improve dark mode and update some UI

Resolve #405
This PR Improve some page on dark mode and fix some layout.
Screenshot

watch only  wallet icon is not visible


Enable MPICH RDMA for CUDA

This PR makes the following changes to the Daint environment:

Load GCC compiler environment rather than Cray default (clang).
Load the cray-mpich module.
Set MPICH_RDMA_ENABLED_CUDA to 1.

Thank you, I will change it.


demo of elastic on web

Would be useful for chromebooks (or in case you forgot to install on your spare laptop)
Deployment options:

Static Hosting on the rio via a vendordep that hosts a url
~Host it on the web too on an http only server (demo mode basically). Students can load the site then switch wifi networks to the robot.~

I probably won't be poking at this for a while so
Status report:

Basic functionality (showing a double) works
There's some issue with msg_pack and messagepack encoding/decoding timestamps. Probably to due with broken U?Int64 support

Fork of messagepack: https://github.com/TheTripleV/messagepack
Fork of msg_pack: https://github.com/TheTripleV/msgpack_dart/tree/fix-cereal

Todo:

[ ] Fix weird timestamp behavior
[ ] Create a vendordep that includes the output of build/web
[ ] Host a fileserver in the vendordep to expose a port+path for elastic (maybe https://github.com/wpilibsuite/allwpilib/issues/2518)
[ ] Add build folder back to .gitignore and make github pages building into a Github Action

Tobuild:

In debug (no minification): Use the flutter extension in vscode or flutter run -d chrome
In prod (minification): Build flutter build web, Have a webserver running at repo root python -m http.server, Go to build/web/index.html in the browser


multi label api change

Can this PR be merged? I would appreciate it because I need multi-label Node support for my work project.


Css code wont run on the live preview for some reason.

Hi,
i have been coding HTML and CSS for about 2 months with Codecademy. I just finished my lessons on this languages and started to code for the first time (in brackets). But something isn't right, i just started the Navigation bar for an example website so i get to grips with the Program. I click live preview on the program, but my CSS script didn't work. It just didn't change the websites design at all. I was using CSS as an External part of my code (in a folder), because I find it tidier instead of endless scrolling to change something on the website. My links are correct like this:

Here is my code, tell me if somethings wrong (Just only started so really no information):
HTML
<!DOCTYPE html>

        <title> Example Website</title>
        <link href="https://fonts.googleapis.com/css?family=Raleway" rel="stylesheet">
        <link rel="stylesheet" href="main.css"/>
        <link rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css"/>

 EXAMPLE title

info

more info

even more info

CSS
body {
    background-color: #696969;
    margin: 0;
    padding: 0;
}

navigation {
    color: rgba(27, 92, 232, 0.77);
}

h1 {
    font-family:  'Raleway' ,sans-serif;
}

Folder sequence
Example website
|
|______Index.html
|______main.css

thanks for the help.

Hi @ebot1515!
Your code seems to be working fine for me. Note that the navigation part in the CSS is missing the . in front (should be .navigation) which makes it not point not to the class navigation, but to an (invalid) element navigation.
Can you share your operating system and Brackets version so we can debug the issue further?

Hi @ebot1515 , Can you please share the requested details by @petetnt?
Without those details and a confirmation from your side we can't debug this issue further.

OK, My operating system is Windows 10 10.0.14393 (Aniversary update). And my brackets version is Release 1.8 build 1.8.0-17108

sorry for the delay. My internet was down.

guys, once i put the dot behind the navigation in css. Only the blue font changed. Why that?

If you want to override the bootstrap rules, your css file need to be places after the bootstrap one.

<link rel="stylesheet" href="main.css"/>
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css"/>

<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css"/>
<link rel="stylesheet" href="main.css"/>


Installing python via pyenv fails on Raspberry Pi

the procedure described here (for raspberry pi): https://home-assistant.io/getting-started/
fails as follows:
~ $ pyenv install -v 3.4.2
/tmp/python-build.20150525182409.18440 ~
Downloading Python-3.4.2.tgz...
-> https://www.python.org/ftp/python/3.4.2/Python-3.4.2.tgz
curl: (60) SSL certificate problem: unable to get local issuer certificate
More details here: http://curl.haxx.se/docs/sslcerts.html

curl performs SSL certificate verification by default, using a "bundle"
 of Certificate Authority (CA) public keys (CA certs). If the default
 bundle file isn't adequate, you can specify an alternate file
 using the --cacert option.
If this HTTPS server uses a certificate signed by a CA represented in
 the bundle, the certificate verification probably failed due to a
 problem with the certificate (it might be expired, or the name might
 not match the domain name in the URL).
If you'd like to turn off curl's verification of the certificate, use
 the -k (or --insecure) option.
error: failed to download Python-3.4.2.tgz

BUILD FAILED (Debian 7.8 using python-build 20150326-485-g50d5de4)

How can I disable the certificate check using pyenv?

Sorry no Raspberry Pi at hand at the moment. It seems that your issue could be related to this one. One suggestion is to use the following:
export EZ_SETUP_OPTS="--insecure"
pyenv install 3.4.2

$ pyenv install 3.4.2
Downloading Python-3.4.2.tgz...
-> https://www.python.org/ftp/python/3.4.2/Python-3.4.2.tgz
error: failed to download Python-3.4.2.tgz

BUILD FAILED (Debian 7.8 using python-build 20150326-485-g50d5de4)

nope. unfortunately this is not getting it done...

anybody has this running on a raspberry pi?

I have used the same procedure, it has been faultlessly installed.

Same here

hm. Something is wrong with mine. The reason seems to be some certificate error. What system are you suing Debian Wheezy or Jessie?

last release 2015-05-05 Debian Wheezy , maybe you should try a fresh one.

wheezy here as well. I will try a fresh install as soon as I get to it...

Raspbian


GenericProperty changes str values to bytes (sometimes)

Expected Behavior
If I set the value of a GenericProperty to a str, then read it back from datastore, the value should still always be a str. The value I read back should equal the value I put in.
Actual Behavior
If I set a GenericProperty to the string 'oops', then read it back from datastore, the value is now b'oops', so it is not equal to the value I put in the property.
If I set a GenericProperty to the string 'oøps', then read it back from datastore, the value is still 'oøps'.  Apparently we are deciding to do different behavior depending on the contents of the string.
The same thing happens in appengine Python 2 incidentally, but it was not a big problem in practice because in Python 2, 'oops' == u'oops' was True. In Python 3 it is a problem :)
Steps to Reproduce the Problem
class Oops(ndb.Model):
    generic_prop = ndb.GenericProperty()
    string_prop = ndb.StringProperty()

oops = Oops(generic_prop="oøps", string_prop="oøps")
assert "oøps" == oops.generic_prop == oops.string_prop
oops.put()
assert "oøps" == oops.generic_prop == oops.string_prop
oops = oops.key.get()
assert "oøps" == oops.generic_prop == oops.string_prop
oops = oops.key.get(use_cache=False)
assert oops.generic_prop == oops.string_prop  # <- Succeeds: both properties are still "oøps"

oops = Oops(generic_prop="oops", string_prop="oops")
assert "oops" == oops.generic_prop == oops.string_prop
oops.put()
assert "oops" == oops.generic_prop == oops.string_prop
oops = oops.key.get()
assert "oops" == oops.generic_prop == oops.string_prop
oops = oops.key.get(use_cache=False)
assert oops.generic_prop == oops.string_prop  # <- Fails, because now generic_prop is b'oops'

Specifications

Version: appengine-python-standard 1.1.3, Python 3.11.4
Platform: MacOS

I think changing one line here, to sval = sval.decode('ascii'), should fix the issue without causing problems for anyone who isn't doing something really strange?
https://github.com/GoogleCloudPlatform/appengine-python-standard/blob/a900a13130eb71d6f2dd67ca2d1573c7559053d9/src/google/appengine/ext/ndb/model.py#L2743-L2750

Same issue exists with Expando:
class OopsExpando(ndb.Expando):
    orig_prop = ndb.StringProperty()

value_to_put = 'oops'
oops = OopsExpando(orig_prop=value_to_put, added_prop=value_to_put)
oops.put()
assert oops.orig_prop == oops.added_prop  # <- succeeds
oops = oops.key.get(use_cache=False)
assert oops.orig_prop == oops.added_prop  # <- fails

Just a note: I noticed the existing tests for this only test with bytes objects containing encoded ascii strings. I doubt this is the most common use of string properties in Expando, and I almost wonder if the tests were simply modified in Python 3 this way to make them pass; please let me know if there's a better reason I'm not thinking of. Also, it will break if you happen to pass bytes objects containing encoded utf-8 strings - I didn't attempt to fix this, since it was most likely also broken in Python 2, and also probably not a common use case.


GCD recursive

By making the GCD function recursive, there is much more clarity and it justifies the text better than with the while loop:
func gcd(m: Int, _ n: Int) -> Int {
    let r = m % n

    if r == 0 {
        return n
    }
    return gcd(n, r)
}

Personally I prefer iteration over recursion, but I'll add your version to the description. Thanks!

What we are discussing is a procedural loop vs recursion not iteration vs recursion. I think indeed that the loop is more efficient with fewer stack operations. IMHO A recursion can express the basics of an algorithm better:

start condition
repeating iteration
stop condition

I will get my HTS books from the attic this week to get it justified by a proper rationale.

OK, I've added a recursive version to the description. :-)

Looks nice!


_In_ LPTSTR gets mapped as PWSTR

OpenPrinter has a first parameter defined as _In_  LPTSTR pPrinterName, but CsWin32 0.4.422-beta is generating a method with the first parameter PWSTR with no friendly string overload because PWSTR is a pointer to modifiable char data. I think this might mean the metadata is incorrect.
This amounts to a usability issue when what you have is a string. My code has to look like this:
SafeFileHandle hPrinter;
unsafe
{
    fixed (char* printerNamePointer = printerName)
        PInvoke.OpenPrinter(printerNamePointer, out hPrinter, pDefault: null).ThrowLastErrorIfFalse();
}

But if a friendly string overload was generated, my code would look like this:
PInvoke.OpenPrinter(printerName, out var hPrinter, pDefault: null).ThrowLastErrorIfFalse();

/cc @AArnott

This will be super useful.

I'm reviewing this now. The headers show this:
BOOL
WINAPI
OpenPrinterW (
   __in LPWSTR pPrinterName,
   __out LPHANDLE phPrinter,
   __in_opt LPPRINTER_DEFAULTSW pDefault
);

The parameter type itself allows for mutation, as it is LPWSTR rather than LPCWSTR.
I am not sure how to interpret the __in SAL annotation. Does that mean the callee is not expected to change any of the content pointed to by the incoming parameter? If so, why wasn't the parameter type set to the constant typedef equivalent that carries that meaning?
SAL annotations are something of a mystery to me, so please forgive my ignorance. I just want to be sure it's the intended policy before I change CsWin32 to consider all __in PWSTR parameters to be assumed constants.


[PutForwards=...] does not use the dfn-for= value

When put forwards defines a new name to use for the attribute then dfn-for is not used to define that attribute properly in the IDL.

Can you give me an example? My testing when u committed the patch showed that it set up for='' properly.

<dfn attribute for="HTMLBaseElement">href</dfn>
...

    [OverrideBuiltins]
    partial /*sealed*/ interface Document {
      // resource metadata management
      [PutForwards=href, Unforgeable] readonly attribute Location? location;
    }

the problem item in the PutForwards resolves like this:
href
This should be a definition not a link to another type
I would expect it to resolve like this
<dfn class="idl-code" data-dfn-for="Document" data-dfn-type="attribute" data-export="" data-type="Location " id="dom-document-href">href</dfn>

I don't understand - you seem to be asking for PutForwards to be a definition of an attribute? If so, that's definitely wrong - it points to an already-defined attribute elsewhere.
If you mean something else, can you elaborate on your expected behavior?

I ran into this for the DOM spec as well for https://github.com/whatwg/dom/pull/120#issuecomment-176044461
Consider this:
interface Element {
 [SameObject, PutForwards=value] readonly attribute DOMTokenList classList;
};
interface Attr {
           attribute DOMString value;
};
interface DOMTokenList {
           attribute DOMString value;
};

WARNING: Multiple possible 'attribute' local refs for 'value'.
Arbitrarily chose the one with type 'attribute' and for 'Attr'.

Now, given how PutForwards is defined, you should pick the value attribute of the interface from the same row where you find the PutForwards, in this case DOMTokenList, instead of something arbitrary.

I guess what I really need is a way to specify what the PutForwards dfn-for needs to be. In this case I need it to be 'Location' object not 'HTMLBaseElement'. How would I specify, in this case, in this IDL block, that the 'href' points to the 'Location' object?
I already have a dfn-for for the rest of the IDL block which is correct for everything else however, for the PutForwards I need a different dfn-for. How will that work? Any ideas?

@zcorpan Is exactly correct and I think spelled it out better than I did.

Ah, yes, I see where I messed up. I accidentally made it for the enclosing interface, not for the type of the attribute the PutForwards is on.
I am not capable of doing any Bikeshed hacking this week, but if someone would like to either fix this, or revert my earlier change for now (to stop the incorrect linking errors) I can merge that and fix it as soon as I get back next Friday.


Not able to toggle "Pro Mode" in Camera application

Expected Behavior
Should be able to toggle pro mode in camera.

Actual Behavior
toggle of pro mode does not work
Steps to Reproduce the Problem

Open Camera
Run the below code to try toggling pro mode

Short Example of Code to Demonstrate the Problem
app = Application(backend="uia").connect(title="Camera")
app.Camera.set_focus()
app.Camera.child_window(title="Open Settings Menu", auto_id="settingsButton", control_type="Button").click_input()
app.Camera.child_window(title="Pro mode - Show advanced controls for photos and videos", auto_id="ProModeToggleSwitch", control_type="Button").click_input()

Specifications

Pywinauto version: 0.6.8
Python version and bitness: 3.8.3
Platform and OS: Windows 10

Very silly mistake from my end. It should be .toggle() instead of .click_input()
So this works:
app = Application(backend="uia").connect(title="Camera")
app.Camera.set_focus()
app.Camera.child_window(title="Open Settings Menu", auto_id="settingsButton", control_type="Button").click_input()
app.Camera.child_window(title="Pro mode - Show advanced controls for photos and videos", auto_id="ProModeToggleSwitch", control_type="Button").toggle()


mvn: batik, svg-salamander as provided dependencies

This avoids transitive inclusion of possibly not needed dependencies.

Codecov Report

Merging #93 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             master     #93   +/-   ##
========================================
  Coverage      77.5%   77.5%
  Complexity      703     703
========================================
  Files            65      65
  Lines          2125    2125
  Branches        225     225
========================================
  Hits           1647    1647
  Misses          360     360
  Partials        118     118

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f431d7...1de68f0. Read the comment docs.


Shadows on Flyout flicker upon opening

Describe the bug
When a MenuFlyout's MenuFlyoutItem finishes animating after clicking on it, its shadow shortly flickers before reappearing.
This phenomenon is best visible against a high-contrast background.
Steps to reproduce the bug
High-Contrast scenario

Define your controls in an empty Window the following way:

<Grid Background="Red">
        <MenuBar Background="Transparent">
            <MenuBarItem Title="File">
                <MenuFlyoutItem Text="Open"/>
            </MenuBarItem>
        </MenuBar>
</Grid>

General scenario

Define your controls in an empty Window the following way:

<Grid>
        <MenuBar>
            <MenuBarItem Title="File">
                <MenuFlyoutItem Text="Open"/>
            </MenuBarItem>
        </MenuBar>
</Grid>

Run the application
Click the MenuBarItem and observe the shadow flickering

Expected behavior
The shadow is expected to remain visible throughout all stages of its animation.
Screenshots
https://user-images.githubusercontent.com/48759429/185805788-ceee788a-08c1-4603-bbe1-81cb6af8d4db.mp4
NuGet package version
No response
Windows app type

[ ] UWP
[X] Win32

Device form factor
Desktop
Windows version
Windows 11 (22H2): Build 22621
Additional context
This issue is less noticeable in low-contrast situations, but persists nevertheless.

much more visible and annoying in light mode

These kinds of issues have been rampant for me in WinUI2/UWP and WinUI3 ever since drop shadows were introduced. Just as a user I find them really annoying, makes me subconsciously dread opening flyouts.

Any update on this? it's still happening

seems to be fixed now

Sounds good to me

The issue is still reproducing for MenuFlyoutSubItem, it should be reopened.

The issue is still reproducing for MenuFlyoutSubItem, it should be reopened.

I can't reproduce this on 1.3.230502000.
https://github.com/microsoft/microsoft-ui-xaml/assets/48759429/174c8fbb-6d7e-4aa3-beba-cdf03671c941


Update github workflows as companion to regro/cf-scripts#1598

companion PR to https://github.com/regro/cf-scripts/pull/1598.
also the following unrelated changes:

noticed that the environment file that was being pulled in delete-old-runs.yml was from an archived repository.
full python script embedded in yaml is super prone to bugs. pulled that out and made it into a proper CLI for maintainability

closing since these jobs are now on cf-scripts


12360 Notebook UI - Mac/Win fix for Select all.

textCell event listener - filtered keydown event for Mac and Win specific key combos.

This PR will address #12360

Pull Request Test Coverage Report for Build 258354771

0 of 3 (0.0%)  changed or added relevant lines in 1 file are covered.
4 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 38.343%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/sql/workbench/contrib/notebook/browser/cellViews/textCell.component.ts
0
3
0.0%

Files with Coverage Reduction
New Missed Lines
%

extensions/notebook/src/jupyter/serverInstance.ts
4
74.52%

Totals

Change from base Build 258280025:
-0.02%

Covered Lines:
19098

Relevant Lines:
45652

💛  - Coveralls


futures: add io and stream traits

Closes #248
The runtime crate is removed in favor of this runtime independent crate. We may still bring engula-runtime back when we really implement our own runtime.

Thanks for preparing this PR! It seems more than a simple renaming work. I'm reviewing now.

You can check an example usage of some traits defined here at #250 .


[C++][Parquet] parquet.dll has runtime dependencies on one or more libraries in the build toolchain

I am not sure which libraries are the problem, but with static linking the intent is to not require transitive runtime dependencies like snappy.dll, etc.
Reporter: Wes McKinney / @wesm
Assignee: Wes McKinney](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=wesm) / @wesm
Note: This issue was originally created as PARQUET-1018. Please see the migration documentation for further details.

Wes McKinney / @wesm:
This was resolved but needs to be verified when updating the Windows conda packages


Types should be collapsable

Types should be collapsable in the UI and if they have docs, they should be collapsed by default like terms.

Requires an extension to the definition API via https://github.com/unisonweb/unison/issues/2175

We're closer to supporting this now that definition summaries exist. They should be added to the definitions API to fully allow this change.
https://github.com/unisonweb/unison/issues/3515


Change NUSense and OpenCR to both use 3Mbps baud rate

We want NUSense and OpenCR to use the same baud rate so it's easy to switch between them. OpenCR cannot use 4Mbps because of the Sparkfun adaptor having a limit of 3Mbps. So, we use the highest we can for both (3Mbps).
OpenCR change has been used and works, NUSense hasn't been checked yet but am about to (there were a lot of places where baud rate was mentioned so not 100% sure).
NUbots/NUbots#1372
Edit: works on NUSense

lgtm if it works with nusense

@JohanneMontano Clayton tested it this morning and it works, had keyboardwalk running


Fix Husky/Lint with Windows

Describe the bug
Husky/Lint/Prettier seems to have some conflict with Together unlike Mac and Linux. 7 Minute Dead commented on this in discord. I do not have a windows computer readily accessible so I require some assistance in diagnosing and resolving.
Expected behavior
Lint/Husky/Prettier should function normally.
Screenshots

If applicable, add screenshots to help explain your problem.
Which Branch should this fix be Pulled into?
PR into main
Additional context
https://stackoverflow.com/questions/53516594/why-do-i-keep-getting-eslint-delete-cr-prettier-prettier
Add any other context about the problem here.
If you're interested in working on this feature, please comment so you can be assigned

I will like to work on this issue.


[AzureRT] Update Release 1.2.4 Compute library with the latest 2015-06-15 Swagger spec.

check-in verification is here: http://azuresdkci.cloudapp.net/view/2-DNX (Legacy)/job/sdk-for-net-dnx/6/


More refactorings

borrow name
move formatting of Play to ConsolePlayer and output name of opponent instead of id
also: for fmt I used cargo fmt but there seems a slight difference to what you have

borrow name
move formatting of Play to ConsolePlayer and output name of opponent instead of id
also: for fmt I used cargo fmt but there seems a slight difference to what you have

LGTM
I'm using VSCode to format (which seems to do the same thing as cargo fmt). I just forgot to run it before.


fix: Check error object before updating stack. (Fixes #700)

Checking object returned by the assertion function in order to avoid property access errors when using assertion utilities like Chai, which would result in an error like this:
1) request(app)
       .expect(field, value[, fn])
         handling arbitrary expect functions
           doesn't create false negatives on assertion utilities:
     Error: Should not be called for non Error objects
      at Object.get (test/supertest.js:744:19)
      at ~/github/supertest/lib/test.js:29:367
      at Test._assertFunction (lib/test.js:99:170)
      at Test.assert (lib/test.js:66:173)
      at Server.localAssert (lib/test.js:54:664)
      at emitCloseNT (net.js:1657:8)
      at processTicksAndRejections (internal/process/task_queues.js:79:21)

@niftylettuce PTAL

@niftylettuce PTAL

v6.1.3 released to npm, any further issues please open another issue or submit a PR
thanks @janthoe https://github.com/visionmedia/supertest/releases/tag/v6.1.3

v6.1.3 released to npm, any further issues please open another issue or submit a PR
thanks @janthoe https://github.com/visionmedia/supertest/releases/tag/v6.1.3

Pull Request Test Coverage Report for Build 491

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.447%

Totals

Change from base Build 489:
0.0%

Covered Lines:
146

Relevant Lines:
150

💛  - Coveralls

Pull Request Test Coverage Report for Build 491

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.447%

Totals

Change from base Build 489:
0.0%

Covered Lines:
146

Relevant Lines:
150

💛  - Coveralls


fix: upgrade chainhook client to v1.4.2

:tada: This PR is included in version 2.0.1-beta.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.0.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Improve API errors handling

Return custom error in case of API error so it's possible to easily handle them later.
It will allow users to handle API errors (e.g. 81057 - The record already exists) without the need to manually parse error strings:
const (
    ErrRecordAlreadyExists = 81057
)

func AlreadyExistsError(err error) bool {
    if err, ok := errors.Cause(err).(*cloudflare.APIError); ok {
        return err.HasErrorCode(ErrRecordAlreadyExists)
    }
    return false
}

resp, err := api.CreateDNSRecord(zoneId, dnsRecord)
if err != nil && !AlreadyExistsError(err) {
    // handle all errors expect "The record already exists"
}

Change should be backward compatible as the Error function returns string in the same format as before.

You'll want to rebase against master seeing how the addition of Cloudflare filters has thrown a bit of a spanner into the works and the default handling of HTTP errors now has a bit more of an edge case. See 3b565f11210000b087b305d0ea08c8f795506f24 for full details.

@jacobbednarz
I rebased the code and adjusted ValidateFilterExpression method accordingly. I simply return the error wrapping it with errMakeRequestError message to make it consistent with other API functions. User can extract validation errors later by analyzing returned error struct.
Regarding the comment about errors array, I guess it's made to be generic. I'm able to get two errors for example by calling the following curl:
$ curl -X GET "https://api.cloudflare.com/client/v4/zones/zone-id/dns_records" -H "Content-Type:application/json" | jq .

{
  "success": false,
  "errors": [
    {
      "code": 7003,
      "message": "Could not route to /zones/zone-id/dns_records, perhaps your object identifier is invalid?"
    },
    {
      "code": 7000,
      "message": "No route for that URI"
    }
  ],
  "messages": [],
  "result": null
}

Not sure if we're able to get two errors from /filters/validate-expr endpoint though. I haven't used that one myself.

Hey @jakub-bacic, could you please rebase the PR, so we could push this forward? Thanks.


robot libdoc not working for robotframework-difflibrary

Hi,
Unable to generate libdoc for this keyword.py file https://github.com/bulkan/robotframework-difflibrary/blob/master/src/DiffLibrary/keywords.py
python -m robot.libdoc src/DiffLibrary/keywords.py doc/DiffLibrary.html

Could you please let me know did i missed any thing

It would help if you would tell how this fails.

@pekkaklarck I was pointing libdoc to keywords
python -m robot.libdoc src/DiffLibrary/keywords.py doc/DiffLibrary.html

but it has dependency in other file, thats the reason i couldn't get keywords html file. It is working with
python -m robot.libdoc src/DiffLibrary doc/DiffLibrary.html

Thanks, It was documented here http://robotframework.org/robotframework/latest/RobotFrameworkUserGuide.html#libdoc


Any way to get rid of this ugly RED terminal color?

Was sure i had posted this already but can't find it anywhere.
Does anyone know how to change the terminal colour from this ugly RED?

This was with 5.3.3 and remains with 5.3.4.
Windows10.

Hi, I can't reproduce this. Does it happen just in pod shells? Just for some pods?

I have fixed it. Pretty sure an issue in Lens but i'll try to explain the steps i went through to fix it.
First, will answer your question. When i first start lens terminal window or a terminal for any pod it is white on black.. as soon as i type anything, it switches to the scheme shown above.
I looked in my Windows system at 3 different shells: Power Shell, Std windows cmd shell, git bash.
PS: blue bg, white promt, yellow text. (likely default as i never us PS)
cmd: light yellow bg with blue text (i may have defined at some point as it is not std white on black)
git bash: white bg with multiple colours for various things (maybe default)
this is where it gets weird.
I know that the way lens shell starts is cmd shell default (look, even though it says PS in prompt); so i went to edit properties of cmd shell and i saw it showed example as the ugly red bg i see in lens shell - even though this is not what i get in my windows cmd shells. I set it to std white on black. Re-tried lens terminal and problem solved.
Oddly, my windows cmd shell colours remained as they had been. When i again go to look at windows cmd properties; they now match what it is actually using (blue on a light yellow bg). If i resave this, nothing changes for any terminal including Lens.
Still odd, Lens terminal suggests it is using Power Shell but the colours are not what i get for PS outside of Lens.. and seem to be controlled by settings for CMD terminal.
Ideally i think that Lens terminal should explicitly set up its terminal and maybe provide options to change that set up.

@liquidcms We do indeed start a Powershell instance by default on windows and not a CMD instance.
The colours you are referring to are from the GUI of Powershell and CMD and are not transmitted when there is a pseudoterminal interface going on.
We have our own terminal emulator within Lens (xterm.js currently) that renders the terminal in browser (since Lens is an electron app).

What did you do just before it stopped showing red?

as i mentioned above.. when i changed the colours for the cmd terminal.


Video support for France Inter: www.franceinter.fr

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.02.11. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.02.11

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[x] Site support request (request for adding support for a new site)
[x] Feature request (request for a new functionality)
[ ] Question
[ ] Other

Purpose: site support request
PS F:\Storage\Movies\Youtube> .\youtube-dl.exe -v https://www.franceinter.fr/emissions/l-instant-m/l-instant-m-13-fevrier-2018
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://www.franceinter.fr/emissions/l-instant-m/l-instant-m-13-fevrier-2018']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2018.02.11
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.16299
[debug] exe versions: none
[debug] Proxy map: {}
[FranceInter] l-instant-m/l-instant-m-13-fevrier-2018: Downloading webpage
[debug] Default format spec: best/bestvideo+bestaudio
[debug] Invoking downloader on 'https://media.radiofrance-podcast.net/podcast09/13938-13.02.2018-ITEMA_21586115-3.mp3'
[download] Propagande, stéréotypes, spectaculaire  - les jeux vidéo font-ils du mal à l'Histoire -l-instant-m_l-instant-m-13-fevrier-2018.mp3 has already been downloaded
[download] 100% of 18.99MiB
PS F:\Storage\Movies\Youtube>

Single video: https://www.franceinter.fr/emissions/l-instant-m/l-instant-m-13-fevrier-2018

Description of your issue, suggested solution and other information
Hello,
Some podcasts on the website of https://www.franceinter.fr comes with video (webcam record during the interview). Currently, youtube-dl does only download the audio file (.mp3) of the podcast.
Would it be possible to download the video file too ?
Best regards,
Nozalys.

I made a patch that extracts the Dailymotion embedded video (epostavs/youtube-dl@027a12c) but the problem is that it's not possible for the user to choose between the audio and the video. Ideally they would each be separate entries in the formats list, but the audio is from franceinter.fr and the video is from dailymotion.com, and currently it is not possible for an InfoExtractor to return multiple formats from different content providers.

You are doing it wrong. You must return a playlist.

Seems odd to use a playlist when both items are really the same thing. That would work though.

They are separate embeds thus must be extracted separately. As well as two more embeds from this page.

Hi there !
So... what about the integration of the final solution ? Is it something possible with respect to the youtube-dl philosophy or not ?
Regards,
Nozalys


[Updates] - VMs restarts immediately after applying OS patches - not respecting scheduled restart time

Gateway Version: Windows Admin Center 2211 1.4.2212.08003
Extension Version msft.sme.windows-update 2.21.0
To Reproduce
Steps to reproduce the behavior:

Go to Server Manager
Connect to any VM (tested on WinSrv 2016/2019/2022)
Apply System updates
Schedule restart at any time in the future

Expected behavior
VM should reboot at specified date and time.
Undesirable behavior
VM will restart immediately after the updates are applied.
Can anyone provide any advanced steps to troubleshoot this? Specific logs, events I should look at? I have WAC at three sites, clean default install and it's happening everywhere.
Martin

I am having this same problem after upgrading to the latest version of WAC, this did not happen on older versions.

In Install-WACWUWindowsUpdates:
If ($NeedsReboot) {
    <#Restart almost immediately, given some seconds for this PSSession to complete.#>
    $waitTime = 5
    if ($restartTime -and $skipRestart) {
      <#Restart at given time#>
      $waitTime = [decimal]::round(((Get-Date $restartTime) - (Get-Date)).TotalSeconds);
      if ($waitTime -lt 5 ) {
        $waitTime = 5
      }
    }
    Shutdown -r -t $waitTime -c "SME installing Windows updates";

So, there are a few possibilities.
Is $restartTime or $skipRestart null/false? If so, it will reboot 5 seconds after finishing installing updates. I would assume this would be caused by an error in the web portion determining the radio button values and setting the parameters on the Install-WACWUWindowsUpdates call.
Alternatively, this could be an issue with time zone standardization, assuming differences between the browser's device's time zone and the target device time zone, such that $restartTime is a valid time stamp, $skipRestart is true, but (Get-Date $restartTime) - (Get-Date) returns a negative value, which is less than 5, causing $waitTime to remain 5 seconds.

It's been fixed in a new Update module 2.3.0.


Update versions for latest .NET release

9.0 RC2 shipped today. Along with a servicing release of .NET 8. Updating to these versions.
Microsoft Reviewers: Open in CodeFlow

/backport to release/9.0-rc1


Error when using presets

When I use ATL-preset I get an error message as soon as the effect is applied:

Go into the preset menu, open torch and then save. That should fix it

Thanks for the reply - updating the presets solved the issue :-)


Change mount point propogation to default to slave

As an admin I would expect that if I volume mount a partition into a container, and then later add a mount point to the volume, it will show up in the container.
Docker-DCO-1.1-Signed-off-by: Dan Walsh<EMAIL_ADDRESS>(github: rhatdan)

@alexlarsson Do you remember why we went with the default of MS_PRIVATE instead of MS_SLAVE?

Wasn't the whole point of making this private to avoid performance issues with propagating mounts into this namespace due to the kernel being shit? I'm not 100% sure here, but this may be causing a performance regression wrt that.

There's an issue related to this problem: https://github.com/docker/docker/issues/2891

I think the issue was that if you have a 1000 containers running. Then when you start a new one it will create a new mount in the global namespace. This will propagate into all the running containers, as it may possibly be wanted there. However, in practice /var/docker is not available in those containers so the propagation is a no-op. However, the kernel code for this was pretty dumb, so it only noticed it was a no-op after a lot of work (O(n) in the number of mounts i think) had been done, and this for each sub-namespace.
The end result was that to start a container we did O(n^2) work (n==number of running containers). So starting n new containers was O(n^3), and really slow. Marking the devicemapper mound directory private avoided the dumbness above by avoiding propagation early in the operation.
However, I question the above patch. Yes, the root of the container is MS_PRIVATE, but that does not necessarily hold for a volume that has been bind-mounted into the container. That bind mount should be MS_SLAVE.
I doubt the sysadmin is going to mount things inside "/var/docker/devmapper/...".

I guess I have two questions, should we optimize for the 1000s of containers use case versus the common 10's of containers use case.  Not having mount propogation into a container, is very confusing.
Now if we could get just the Volumes mounted into the container to propogate and not /var/lib/docker/devicemapper would that solve the problem?

@rhatdan There are certainly Docker users and Docke deployments out there which require thousands of containers. I know there are people who are having problems because of the 1024 ports limit for the default Linux bridge.

@unclejack Understood, (openshift) for one.  We need a mechanism to change the default behaviour preferable though the daemon or via docker run commands.

@rhatdan I don't necessarily disagree, but I don't see how the /var/lib/docker/devicemapper directory being private has to do with the volumes not being propagated. Surely the volume bind-mounts themselves are mounted as slave, and it should not matter that the root of the container is private?

I don't believe we do this now.  What I was seeing even in a privileged container, was when I run
docker run -ti -v /usr:/usr fedora /bin/sh
mount --make-rslave /usr
Outside container
mount -o bind /tmp /usr/share
/usr/share would still not propagate.
When I changed libcontainer to mount "/" SLAVE and the /var/lib/docker/devmapper to SLAVE, it worked.
Propogation was failing with devmapper mounted SLAVE but libcontainer "/" mounted PRIVATE.
It only worked when "/" was also mounted SLAVE.
I have not tried again with with /var/lib/devmapper as PRIVATE.

Can you try "/" as slave and devmapper as private? Having devmapper as private is what fixed the performance issue i think.

Ok just tried an experiment with just the /var/lib/docker/devmapper mounted PRIVATE and it still worked.

We are cutting a build with this change and will have performance team check if there is any performance degradation.  thanks @alexlarsson

@rhatdan Any news from your performance team?

They found no difference, I believe.  @jerms can you confirm.

ping what do we want to do with this?

I think the libcontainer changes which got merged were all we needed.  I will close this for now, and reopen if I find any problems.