feat: add counting bloom filter

Previous Discussion: https://github.com/redis/rueidis/discussions/510
There are 2 different points from origin design.

Count returns all inserted items. not distinct items.
RemoveMulti deduplicate keys. count in Counting Bloom Filter can't be negative. because of these nature, RemoveMulti operation can be complicated and performance can be bad. so add constraints to avoid difficulties.

Codecov Report
Attention: Patch coverage is 98.06452% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 95.59%. Comparing base (a74b679) to head (7566423).

Files
Patch %
Lines

rueidisprob/countingbloomfilter.go
97.95%
2 Missing and 1 partial :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
+ Coverage   95.57%   95.59%   +0.01%
==========================================
  Files          80       81       +1
  Lines       33178    33325     +147
==========================================
+ Hits        31710    31857     +147
- Misses       1267     1268       +1
+ Partials      201      200       -1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Count returns all inserted items. not distinct items.

I guess, a method for getting the distinct count is still needed for users to know whether this filter is close to full or not.
And instead of Exists, should we provide a method for getting the minimum count of a key? Otherwise, users may just use the standard bloom filter.

@rueian

And instead of Exists, should we provide a method for getting the minimum count of a key?
Do you want to remove Exists or Adding a new method? According to definition, Counting Bloom Filter can insert same key several times.

I feel the Esists is not necessary if we have a method to get the minimum count of a key, but we can keep it anyway. It is still a handy method.

@rueian
I understand what you said. If we had a method that returns minimum count of a key, it is count-min sketch. not counting bloom filter. do you think count-min sketch is more proper?

do you think count-min sketch is more proper? or do you want to integrate with both data structures?

The wiki you referenced above also says that count-min sketch and counting bloom filter are essentially the same data structure. Could you elaborate more on their differences?
I have no preference between count-min sketch and counting bloom filter. I just want this filter to have more functionalities than the previous standard bloom filter.

The wiki you referenced above also says that count-min sketch and counting bloom filter are essentially the same data structure.

what i understand is both data structures almost same logic

use hash function to given key to reduce space usage.
each hashed value store count.

but what i know purpose, functionalities, internal data structure is different.
In terms of purpose, Count-Min Sketch store and get item's frequency but Counting Bloom Filter check whether item is in or not.
In terms of internal data structure, Count-Min Sketch uses 2d array, but Counting Bloom Filter use 1d array.
In terms of functionalities, Count-Min Sketch explicitly supports inserting same data multiple, like this update(data, delta). but Counting Bloom Filter doesn't. AddMulti is just batch function to use Add conveniently in this PR, but not originally created function in the paper.

I have no preference between count-min sketch and counting bloom filter. I just want this filter to have more functionalities than the previous standard bloom filter.

I see. But this implementation may have bigger error rate than count-min sketch(This is uncertain.)

but Counting Bloom Filter check whether item is in or not.

This makes it look the same as the original bloom filter, except that it could still report exists=true even after removing an item (since the item could have been added multiple times). From this perspective, it seems that having a method to retrieve the minimum count of an item is still reasonable.

@rueian
abda0c8
Adding ItemMinCount and ItemMinCountMulti. But considering purpose of Counting Bloom Filter, leaving left Exists and ExistsMulti makes sense to me.

Merged. Thank you @proost!


Error while adding my APIs using .json file

am trying to add my API using the below .json file while leads to and error in the operation tab which says the the implementation is incomplete every time I try to connect it to my cluster url.
{
"swagger": "2.0",
"info": {
"title": "Roaming change",
"description": "Change the status of roaming for a single user",
"version": "1.0.0"
},
"basePath": "/users/",
"host": ".",
"schemes": [
"http"
],
"paths": {
"/roaming": {
"post": {
"consumes": [
"application/json"
],
"produces": [
"application/json"
],
"parameters": [
{
"in": "body",
"name": "body",
"description": "Roaming Check",
"required": true,
"schema": {
"$ref": "#/definitions/roaming_input"
}
}
],
"responses": {
"200": {
"description": "successful operation",
"schema": {
"$ref": "#/definitions/roaming_output"
}
},
"500": {
"description": "Internal Server Error"
}
}
}
}
},
"definitions": {
"roaming_input": {
"type": "object",
"properties": {
"name": {
"type": "string"
}
}
},
"roaming_output": {
"type": "object",
"properties": {
"roaming": {
"type": "string"
}
}
}
}
}
________________________________________________________________________________________-
{
"message": "The POST /roaming action for the API "roaming_updated" returned with an error code: 405.",
"action": "Check that all the input values are set correctly and that the endpoint is available. Check if more detail is available for this error in the errorDetail field of the log.",
"detail": "",
"url": "",
"data": {
"errorDetail": "{"statusCode":405,"headers":{"allow":"GET, DELETE","content-type":"application/json;charset=UTF-8","transfer-encoding":"chunked","date":"Mon, 03 Feb 2020 10:23:29 GMT","connection":"close"},"body":{"timestamp":1580725409716,"status":405,"error":"Method Not Allowed","exception":"org.springframework.web.HttpRequestMethodNotSupportedException","message":"Request method 'POST' not supported","path":"/users/roaming"}}"
}
}

Hi.
I am able to import the flow sent by you. I see no issues. When you add/import APIs, have you clicked on Connect and provided necessary endpoint details?

yes and now it prompt me with this error every time I press connect

I cannot think of a reason why this is happening. I suggest you delete existing APIs and create a new ones and check. If the issue persists, you can log a ticket in your IBM Cloud account.

Hey Team,
Sorry for the late reply I was investigating the problem from my end.
I can confirm that my Swagger file is running successfully (Reference to the screenshot attached) however when I upload it, it prompts me with this message:
Unable to create API "Roaming".
A problem occurred while trying to create an API using the OpenAPI document provided.
Contact IBM quoting reference ZPej2M6y.me
Also, you can find the .json file attached below for you team to confirm form your end.
Best Regards,
Ahmed Yahya
Software Engineer
E-mail<EMAIL_ADDRESS>
On Feb 6, 2020, at 6:36 AM, Muralidhar Chavan<EMAIL_ADDRESS>wrote:

I cannot think of a reason why this is happening. I suggest you delete existing APIs and create a new ones and check. If the issue persists, you can log a ticket in your IBM Cloud account.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

Looks like this is a platform issue. I suggest you create a support ticket available in IBM Cloud dashboard, on top right side.

Did you make any progress on this?

No activity from a long time. Hope it worked for you.
Hence closing the issue, please feel free to reopen or open new issue if required. Thanks.


Bump to v2.5.0

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[X] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.
I do have some suggestions for making it better though...
For recipe:

It looks like the 'libcantera-devel' output doesn't have any tests.

@conda-forge-admin, please rerender

Thanks @inducer! But why is the macOS package failing :cry:

ImportError: dlopen(/Users/runner/miniforge3/conda-bld/cantera-recipe_1612562746729/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.9/site-packages/cantera/_cantera.cpython-39-darwin.so, 2): Library not loaded: build/lib/libcantera.2.5.0.dylib
  Referenced from: /Users/runner/miniforge3/conda-bld/cantera-recipe_1612562746729/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/lib/python3.9/site-packages/cantera/_cantera.cpython-39-darwin.so
  Reason: image not found

Whereas in some places it seems to build build/lib/libcantera.2.5.0rc1.dylib.

Thanks @inducer That seems to be resolved by bumping to the final release. Any idea about the problems on Travis with the PPC builds? It looks like there's so much output that the pipe can't handle it? But maybe that's just concealing the actual error message?

@conda-forge-admin, please rerender

It sure does look like the output is truncated after
The install/build script(s) for libcantera deleted the following files (from dependencies) from the prefix:

I'm guessing that's conda-build complaining that files were deleted. Maybe we can be a bit more selective in our deleting? Only delete files that have cantera somewhere in the path?

make conda-build complain less

Thx!

Thanks @isuruf! @inducer any other changes to make here? Can you "Approve" when it looks good?


0.1.3 fix examples

Dear Rob
if i use INA226_demo_2 it returns  the following on the serial monitor
BUS	    CURRENT	POWER	POWER2	DELTA
0.001   6551.100	0.00	        8.19	        -8.19
0.003   6549.900	0.00	      16.37	      -16.37
I would expect CURRENT to also be a negative value like DELTA
in my application - NiMh battery analyzer the current is positive when a load is connected but i don't get a negative number when I am charging.
Is there something I am overlooking ?

@FrankTmmrmn
Can you open a new issue for this as this is a Pull Request and not the right place for new issues.
In the mean time I will have a quick look if I understand the problem.

Dont' you think the problem is because you use float iso uint16_t for getCurrent()
float INA226::getBusVoltage()
{
uint16_t val = _readRegister(INA226_BUS_VOLTAGE);
return val * 1.25e-3;  // fixed 1.25 mV
}
float INA226::getPower()
{
uint16_t val = _readRegister(INA226_POWER);
return val * 25 * _current_LSB;
}
float INA226::getCurrent()
{
float val = _readRegister(INA226_CURRENT);
return val * _current_LSB;
}

I'll need to dove into the datasheet to check the details. Probably somewhere next week.

Had a quick look the datasheet and recalled it as a part in progress / to be tested.
Looking at register 4 I see it is a signed integer. Mapping it to an uint16-t would not solve the problem
However register 1 is also signed so I need to handle the content in a similar way. I will make an test branch today that would allow you to verify.
To be continued


KeyError: 'Mon' on mobility calculation of GaAs

Thank you for sharing the HamEPC environment. I installed HamEPC and ran the mobility of GaAs. I changed read_momentum form False to True because it says so in the utility.py:
'read_momentum': False, # When calculating the carrier mobility, read_momentum should be true.
I get the following error:
################################################## Mobility Calculation ################################################## Sampling with Cauchy distribution. Using ERTA method to calculate mobility. Traceback (most recent call last):   File "/home/vaskarpo/bin/NN/new_EPC/lib/python3.9/site-packages/torch_geometric/data/storage.py", line 78, in __getattr__     return self[key]   File "/home/vaskarpo/bin/NN/new_EPC/lib/python3.9/site-packages/torch_geometric/data/storage.py", line 103, in __getitem__     return self._mapping[key] KeyError: 'Mon'
If I set read_momentum to False, nothing is put out even after 10 hours.
Am I doing something wrong here? Maybe the neural network file for GaAs I downloaded from the link in your paper does not contain momentum data.
Thanks,
Vahid

Dear @Vahid999,
The comment you mentioned is outdated and was left over from a previous version. Currently, read_momentum does not need to be enabled for calculating carrier mobility in HamEPC.
Best wishes,
Yang Zhong


feat: handle large text pastes as a document attachment

Pull Request Checklist
Before submitting, make sure you've checked the following:

[x] Target branch: Please verify that the pull request targets the dev branch.
[x] Description: Provide a concise description of the changes made in this pull request.
[x] Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
[x] Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
[x] Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
[x] Testing: Have you written and run sufficient tests for validating the changes?
[x] Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
[x] Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:

BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry
Description

Handle large text pastes as a document attachment. If a paste is longer than 1000 characters, simply upload it using the existing handlers.

Added

If a paste is longer than 1000 characters, simply upload it using the existing handlers.

Additional Information
Discussion 6099
https://github.com/open-webui/open-webui/discussions/6099
Screenshots or Videos
https://github.com/user-attachments/assets/844d1af0-d162-4894-80d0-51c228ce35ed

Seems to be broken, I'm unable to get this to work with rich text input. I'll take a look personally and we would most definitely make this a toggleable option than the default.

amazing, see it @ https://github.com/open-webui/open-webui/pull/6522/commits/11e78eac914c89cfbdbf2964aa1d0f8c90943a3a - thanks @tjbck!


[Bug]: Unable to render page

Minimal, reproducible example
const puppeteer_module    = require('puppeteer');
const browser = await puppeteer_module.launch({headless: false});
const page = await browser.newPage();
await page.goto("https://go.affision.com/login/");

Background
No response
Expectation

Reality
White screen. Seems that the script inside  tag is not executed and then the page is not loading.
Puppeteer configuration file (if used)
No response
Puppeteer version
23.3.1
Node version
20.17.0
Package manager
npm
Package manager version
10.8.3
Operating system
Linux

I am able to reproduce but I do not see an issue with Puppeteer. It appears that this web site detects automation and blocks access to the page. Overcoming this sort of protections is out of scope for Puppeteer.


New version: Scorpio.sco version 2.3.7

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.0 schema?

Microsoft Reviewers: Open in CodeFlow

/azp run


[SPARK-26500][CORE] Add conf to support ingoring data locality

JIRA Issue: https://issues.apache.org/jira/browse/SPARK-26500
add conf to ignore data locality to impove performance when reading huge number of files, especially in SparkThriftServer2 mode.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

I don't understand this propose add a configuration used for disable data locality.There are exists a configuration spark.locality.wait is charge of the function.You can set zero for spark.locality.wait.

I don't understand this propose add a configuration used for disable data locality.There are exists a configuration spark.locality.wait is charge of the function.You can set zero for spark.locality.wait.

When submit a job, the driver will go into DAGScheduler.handleJobSubmitted, it will call getPreferredLocs for each partition of a rdd.  It's single thread and time-consuming when there are huge partitions, and this code path is not controlled by spark.locality.wait.

?? Wouldn't it work if we set zero for spark.locality.wait? That's what I did long time ago as well.

It's single thread and time-consuming when there are huge partitions

How much does it take, and how much time this configuration saves?


[Feature Request] Batch Operation for Favorites

Explain in detail what your suggested feature would be used for.
The proposed batch operation feature would enable users to transfer worlds between collections in a more efficient and time-saving manner.
Describe how it would look if it requires a UI.
A button could be added next to the Export/Import button in the Favorites menu.

The interface would display a list of worlds from different collections, similar to the combination of the world collection and import menus. Collections could be expanded to show individual worlds with checkboxes for selection. Users could select favorites by clicking on the checkbox or on the item itself. They could then choose a target collection and initiate the transfer of selected favorites.
For VRChat online collections, if there are API limitations, batch operations could be processed slowly but automatically.
The process would involve:

Opening the Batch Operation menu
Expanding groups
Selecting favorites for transfer
Choosing a target group
Initiating transfer

Example:

Explain why people would want to use it.
This feature would benefit world travelers and players who use VRCX to manage world collections by significantly reducing the time required to transfer large numbers of worlds between collections. This feature is crucial for world travelers and players who use VRCX to manage large numbers of worlds in their collections.
Here is an example of why batch processing is needed

I've added a bulk unfavorite mode to make these sorts of operations less painful.
Maybe I'll expand on that in the future to transfer to other groups but the amount of work required for a fully featured transfer system is not something I'm willing to put the required time into.


Style changes to "On this page" & "Related resources"

Overview
We'd like to make style changes to the righthand column in Docs & Registry containing "On this page" and "Related Resources." These changes reinforce information hierarchy on our documentation pages.
Design file
Figma preview

Design changes
Style changes

[ ] Label name, color, font-size, icon
[ ] Increased line spacing
[ ] Added indicator with scroll behavior
[ ] Mobile handling

@anita-trimbur id like to close out this issue; do you mind moving the related resources part of it to a new issue?


tests: kernel: mem_slab: Fix test for no multithreading

Modified test to exit early when multithreading is disabled to
fix linking errors.
Fixes #40020.
Signed-off-by: Krzysztof Chruscinski<EMAIL_ADDRESS>

another PR #40026, let use this one.


Luigi's hat color is wrong

does it really take 25 days to fix a typo

I haven't touched the mod for the past 25 days genius

fa4e03e5ee5d43c1d20fc402e9cb029f809cb40a


Links to chapters in custom syllabus should open in a new tab

Description of issue
This issue relates to #351
The links to each chapter/problemset that are added using the custom syllabus feature should have anchor tags so that they open in new tabs/windows.
Students and educators who are utilizing the custom syllabus want to keep their syllabus page visible while clicking on the links to the chapters in the texbook.
Given the transition, I understand that the priority for fixing this may be low. That being said, as we have multiple universities that are currently utilizing our custom syllabus feature to deliver their courses in 2023, this fix would be much appreciated.

This repository is no longer maintained. It has been superseded by IBM Quantum Learning


amplify env list --json should indicate current environment

Is your feature request related to a problem? Please describe.
I'm writing a script that needs to know the current env name.
Describe the solution you'd like
The script would run amplify env list --json and from there easily parse the json to get current env.
Describe alternatives you've considered
Will have to instead rely on amplify env list and look for the * through regex. Or perhaps this info is stored in a file somewhere in amplify/backend dir?

Resolved through this command for now:
amplify env list | awk '/.*\*/{print $2}' | cut -f2 -d*

Thanks for your feedbacks, the team will review it.

I believe it's implemented, so the issue can be closed. amplify env list --json works fine for me with latest Amplify version


ejson2env: init at 2.0.2

Motivation for this change
Add ejson2env tool
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

thanks, done

Please squash your last commit, I can't squash when merging as the maintainer commit should be separate.


[Bug]: ApiVideoPlayer IFRAME steals focus for key presses when autoplay property is set to false.

Version
<EMAIL_ADDRESS>Environment that reproduces the issue
Windows Chrome, but this appears to be common accross all browsers/devices tested so far.
Is it reproducible in the example application?
Yes
Reproduction steps
Clone and run the source code from the demo available here. See instructions in the README.md
https://bitbucket.org/inclusive/api-video-taking-focus/src/master/
The demo sets up the ApiVideoPlayer with autoplay=true and autoplay=false depending on what is passed in the URL to show different behavior.
Key presses are being made to unpause the video which pauses automatically again after 3 seconds by design. When autoplay=false, it can clearly be seen that the IFRAME steals focus and therefor the containing window cannot recieve keyDown or keyUp events. Clicking into the parent window again will refocus the parent and keypresses can be used again.
Scenario functioning correctly

Launch the demo with autoplay enabled (true)
Press a key
Press the video will play
Press a key
Press the video will play again

Scenario functioning incorrectly

Launch the demo with autoplay disabled (false)
Press a key
Press the video will play
No further key-presses can be received by the top level document as the IFRAME has focus

Expected result
Parent window can recieve keyUp and keyDown events, without the IFRAME taking focus when autoplay=false.
Actual result
No keyUp and keyDown events received because the IFRAME has focus after the first keypress.
Additional context
No response
Relevant logs output
No response

Screenshot from our bug demo where autoplay is enabled and focus is not being stolen:

This is still a bug the the api.video player but a workaround can be a applied where the autoplay prop is set to true and the video is paused in response to the onReady callback to reproduce the effective autoplay=false behavior.

The above workaround (setting autoplay to true and pausing the video) did not help the situation on iPad Chrome and iPad Edge as this resulted in the audio not playing: https://github.com/apivideo/api.video-react-player/issues/22
Instead we have to detect that the window has blured, then take the focus back after a few miliseconds. We then simulate the keyUp even that we missed. The inputs/access then works as expected. Clearly this workaround is not ideal.

Hi @will-grange-inclusive
Thanks you for this detailed feedback. That is due to the accessibility features of the player that keeps the focus to capture key presses. We'll add an option to disable it. That will fix your issue. The updated version will be released today or tomorrow.

@will-grange-inclusive can you try with the new v1.1.0 version ?
Please note that there is one breaking change with this version. You'll now have to use
const videoRef = useRef<ApiVideoPlayerRef>(null)

instead of:
const videoRef = useRef<ApiVideoPlayer>(null)

To fix the focus issue, you can use the following parameter:
<ApiVideoPlayer
   hotKeys={false}
   // ...

We've also add a new customDomain parameter that you should use:
<ApiVideoPlayer
   customDomain='embed.xxxx.com' // replace with your domain
   // ...
   ```

@olivierapivideo - I've tested this on a branch of the bug demo app and with the hotKeys={false} property applied, that the key presses are no longer being swallowed by the IFRAME contents. We are mid testing (many videos * platforms * access methods to test), so not applying to our main code base just yet but closing this based on the demo app resolution.


Add dependency on ninja-build

In VS 2019 16.6 and later Ninja will be the default generator for new Linux/WSL configurations.

@esweet431 : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Q: What is stanza?

What is stanza? Can you direct me to a website or documentation?

Hi Suminda.
Stanza is a new general purpose programming language being designed in our lab. It's designed specifically to be good at architecting complex programs, and to be productive across the whole software development timeline, from prototyping through production. We chose to design and develop the original FIRRTL implementation in Stanza because it offered us the most productive framework out of all the existing languages, and it has served us well.
You can visit lbstanza.org for more information. That's a very old website, and we are preparing a public release within this month.
-Patrick

Thanks. Is the language open sourced?

Yes. It has a 3-clause BSD license.

Where is the repo?

The repo is not public yet. We are preparing a public release this month.
But all the source files are available in the download package on the
website.
Cheers.
-Patrick
On Fri, Apr 29, 2016 at 9:28 AM, Suminda Dharmasena <
<EMAIL_ADDRESS>wrote:

Where is the repo?
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/ucb-bar/firrtl/issues/151#issuecomment-215794854

Can you ping me when the repo becomes available?

Sure!
On Thursday, May 12, 2016, Suminda Dharmasena<EMAIL_ADDRESS>wrote:

Can you ping me when the repo becomes available?
—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
https://github.com/ucb-bar/firrtl/issues/151#issuecomment-218704955


should c() be deprecated?

I understand that the point of Tidier.jl is to match the tidyverse in Julia, but should c() really be a method that is provided? It's not necessarily a tidyverse-specific method, and it feels superfluous when a user can just create a vector or tuple, or use one of the other methods like collect, cat, and vcat. At worst it feels anti-Julian, and at best it should be a common method provided by a TidierBase package and re-exported by the Tidier packages.

I intentionally don't provide a c() method and agree that either Julia vectors or tuples are preferred.

I haven't looked too closely yet, but if we use c() in arguments that are immutable, then my suggestion would be to move to tuples () rather than arrays because tuples are stack-allocated and thus faster.

I do provide a c() method in TidierPlots, because I essentially want people to be able to copy and paste R ggplot code and have it work (after changing aes to @aes, but there's no way around that). It's a pretty easy way to adhere to the stated goal #1 of the package, so I feel pretty strongly that it should be left un-deprecated.
There's nothing stopping anyone from using a vector or tuple instead though if they want, since c() essentially just creates a vector of its arguments!

I would be fine with changing c() to return a tuple, but I can't imagine the speedup is detectable for the applications its used for (e.g. scale_color_manual(values = c("red", "blue", "white")))

As long as vectors/tuples work and are documented, I think that's fine (if you prefer to leave c() as an option).
But in TidierData, I just use tuples because visually they look like R minus the c letter.

It doesn't seem like c() is used anywhere in the source code, just in docs and exported as a convenience method. I make the argument that providing this convenience method can cause more issues for end users than it solves. If only TidierPlots has c(), then what happens when users try other TidierOrg packages and get confused when c() isn't found? Either all Tidier packages must export c() or none of them should.

It's a pretty easy way to adhere to the stated goal 1 of the package, so I feel pretty strongly that it should be left un-deprecated.

I don't think keeping c() really aids in goal 1 too much. Users coming from R to Julia will already be needing to adjust to Julia syntax. Goal 1 feels more about keeping ggplot2 syntax and tidyverse verbs than keeping R syntax.
As a compromise, if c() is kept around then it should give a warning along the lines of:
"c() is an R-specific method. The Julia equivalent is to create a vector ([1, 2, 3]) or to use vcat to join multiple vectors (vcat([1,2,3], [4,5,6])), or join multiple vectors using a semicolon ([1:3; 4:6]). "
Lastly if c() is to be kept around, it should behave just like it does in R

coerce data to the least restrictive type
combine arguments a flat vector

The current implementation of c() is incorrect.
In R:
> c(1, "2", 3, c(4, 5, 6))
[1] "1" "2" "3" "4" "5" "6"

In Julia:
julia> c(1, "2", 3, c(4, 5, 6))
4-element Vector{Any}:
 1
  "2"
 3
  [4, 5, 6]

I didn't mean for goal one to only apply to verbs or to specific parts of the code - I really meant what it says: "stick as closely to tidyverse syntax and behaviour as possible." To me, that means - especially if it is easy to implement, as it is in this case - that ggplot code written in R should run in TidierPlots.
I'm on board with adding the note about julia vector creation though, that seems in line with the goal of introducing R users to julia.
We can edit c to support those use cases, but they are unlikely to come up in correctly specified ggplot code so I haven't made it a priority

The c() function can be simply changed to
function c(args...)
    @warn "don't use 'c(1, 2, 3)', use [1, 2, 3]" maxlog=2
    return reduce(vcat, args)
end

which will at least solve the second issue of correctness

c has been updated - I will leave the question of whether c should or should not be supported outside of TidierPlots as well to @kdpsingh

Thanks -- I'll think more on this but my inclination for now is to leave things as-is. I'm open to feedback though.
I do want to avoid a TidierBase package for now because ideally each package in the Tidier family should be useful as a standalone package (unless having TidierBase helps reduce re-compilation of re-exported macros like @chain).


Azure Blob Storage: gracefully handle setting "endpoint" to non-emulator

Fixes an issue reported by users.
Azure Blob Storage components have an "endpoint" property which is meant to be used with emulators such as Azurite.
However, we've seen users accidentally setting this property to their Azure Blob Storage endpoint, such as https://myaccount.blob.core.windows.net/mycontainer. Until 1.11.0, this did not cause any issue (for unclear reasons). Starting in 1.11.0, Dapr handles this "how it's supposed to", but this can cause issues with customers.
This PR changes the behavior by:

Show a log when a custom endpoint is used
If the "endpoint" metadata is set to the value it would have when using Azure Blob Storage, it is ignored (and a warning is shown).

/ok-to-test


Unable to add BTHome Integration in HA

Describe the bug
I am running HA v.2023.5.3, as a VM on unRAID. I have both an ESPHome BT Proxy as well as a Bluetooth dongle adapter. Both the dongle and the ESP BT Proxy are detected by my HA automatically, and I can configure the bluetooth integration. However, the BTHome integration fails to install. The only error I get is "No devices found on the network"
To Reproduce
Steps to reproduce the behavior:
I can reproduce the error by trying to install the BTHome integration again. I've restarted my HA multiple times, updated everything, etc.. Same issue. Not sure how to explain how someone else would reproduce the issue besides being me with my exact setup :D
Additional context
One other person seems to have a similar issue here: https://github.com/home-assistant/core/issues/88711
The diagnostic TXT file for the bluetooth integration shows that the bluetooth dongle is detecting other devices (I can see entries for various BT devices around my house), but BTHome integration does not load at all.
Please let me know if this issue should be submitted differently. I don't use github all that often so I want to make sure I'm putting this in the correct place. Thanks!

Normally, if you have the Bluetooth integration running correctly, there is no need to install the BTHome integration manually. At the moment the Bluetooth integration sees a BLE message that is in the BTHome format, it will show a “new integration detected”  in the integration overview. You only need to click on configure, and you’re done.
question is, does HA receive any BTHome BLE data? To find out, enable debug logging for the Bluetooth integration at debug level, and post the HA logs afterwards here and I can check. Please also post the MAC address of the sensor, if you know that.

Normally, if you have the Bluetooth integration running correctly, there is no need to install the BTHome integration manually. At the moment the Bluetooth integration sees a BLE message that is in the BTHome format, it will show a “new integration detected” in the integration overview. You only need to click on configure, and you’re done.
question is, does HA receive any BTHome BLE data? To find out, enable debug logging for the Bluetooth integration at debug level, and post the HA logs afterwards here and I can check. Please also post the MAC address of the sensor, if you know that.

Ok, so it looks like HA is receiving bluetooth data from the dongle, but I'm not sure if it's in a format for BTHome. I've attached the HA logs here. The MAC address of the sensor (BT dongle) is 5C:F3:70:A8:F6:57. You will see many entries for this device sensing BT data from other devices.
home-assistant_2023-05-15T06-34-23.172Z.log

First, I checked your logs on servicedate from BTHome, but all service data I can find is from a sensor with UUID FEAF, which is not a BTHome sensor, but something else (Nest device).
`service_data={'0000feaf-0000-1000-8000-00805f9b34fb'
Next, I tried to search for the MAC address, but you gave the MAC address of your Bluetooth dongle (the receiver), not of the BTHome sensor.
While l was searching your logs, I notice a lot of these errors.
2023-05-14 23:36:26.900 DEBUG (MainThread) [homeassistant.components.bluetooth.base_scanner] hci0 (5C:F3:70:A8:F6:57): Scanner watchdog time_since_last_detection: 4.722009007999986
2023-05-14 23:36:56.901 DEBUG (MainThread) [homeassistant.components.bluetooth.base_scanner] hci0 (5C:F3:70:A8:F6:57): Scanner watchdog time_since_last_detection: 34.7230845009999
2023-05-14 23:37:26.904 DEBUG (MainThread) [homeassistant.components.bluetooth.base_scanner] hci0 (5C:F3:70:A8:F6:57): Scanner watchdog time_since_last_detection: 64.72619024999995
2023-05-14 23:37:56.905 DEBUG (MainThread) [homeassistant.components.bluetooth.base_scanner] hci0 (5C:F3:70:A8:F6:57): Scanner watchdog time_since_last_detection: 94.72732451999991
2023-05-14 23:37:56.906 INFO (MainThread) [homeassistant.components.bluetooth.scanner] hci0 (5C:F3:70:A8:F6:57): Bluetooth scanner has gone quiet for 90s, restarting
2023-05-14 23:37:56.906 DEBUG (MainThread) [homeassistant.components.bluetooth.scanner] hci0 (5C:F3:70:A8:F6:57): Stopping bluetooth discovery
2023-05-14 23:37:56.914 DEBUG (MainThread) [homeassistant.components.bluetooth.scanner] hci0 (5C:F3:70:A8:F6:57): Starting bluetooth discovery attempt: (1/3)
2023-05-14 23:37:56.924 DEBUG (MainThread) [bleak_retry_connector] Restored 0 discoveries for hci0

This means there is an issue with your dongle. It detects that it isn't receiving any data for 90 seconds, it assumes that there is something wrong and it restarts the dongle. This happens every 2-3 minutes (of which 90 seconds without data).
So, to conclude, there is an issue with your Bluetooth dongle. Hard to tell what is wrong exactly. There are some issues in Home Assistant OS 10.0 and 10.1 with Bluetooth, but it can also be a faulty Bluetooth dongle.

This means there is an issue with your dongle. It detects that it isn't receiving any data for 90 seconds, it assumes that there is something wrong and it restarts the dongle. This happens every 2-3 minutes (of which 90 seconds without data).
So, to conclude, there is an issue with your Bluetooth dongle. Hard to tell what is wrong exactly. There are some issues in Home Assistant OS 10.0 and 10.1 with Bluetooth, but it can also be a faulty Bluetooth dongle.

Thank you for looking into this! I figured out the issue with your help.
I removed the dongle from HA, and watched the logs. The Bluetooth integration switched back to using the ESPHome BT Proxy (which was already added to my system). The logs then showed many more devices and more information. So yes, there was definitely an issue with my BT dongle.
Anyway, after getting that to work, I finally realized that I needed to send some kind of BTHome packet for the integration to pop up. The  whole reason I was trying to get this to work is because I just purchased two of the Shelly Button BLU devices... so I pressed the button on one of those, and voila! The sensor showed up immediately on my integrations (wtih the BTHome logo), and I was able to configure it as normal. Very cool.
Long story short, issue has been resolved. Thanks for your help!


Merge async and not-async implementation

What do you mean by this? Maybe I can help

@duszekmestre e.g. ExcelOpenXmlSheetWriter.Async.cs and ExcelOpenXmlSheetWriter.cs, their logic and code 99% same, but miniexcel needs duplicate code to use async, Task, await  keyword.
I think these code can be merged.

Yes - I tried to do this but I have limited time for doing this. Some code can be reused and in latest PR i refactor one of the method to prepare string values to write them to the writer.

I started to reuse code in PR #602
In the next part I'll try to reuse code between different types of objects on saving.

@duszekmestre ❤thanks, e.g. ExcelOpenXmlSheetWriter.Async.cs and ExcelOpenXmlSheetWriter.cs, their logic and code 99% same, but miniexcel needs duplicate code to use async, Task, await  keyword. I think these code can be merged.

I think it is not possible to completely reuse same code. Async/await method should be written separately. The only thing which is possible is creating same codebase to generate XML strings for both implementations to reuse and easier maintenance.
I saw that different types (data reader, data table, enumerable) are managed separately so many errors are done because of lack of implementation to one of them. This the hardest and most important thing to rewrite.
If you have any other idea please share with me.

Yes, my first idea is we can only maintain async method like HttpClient
If sync method just call async method GetAwaiter and GetResult


Incorporate Stack Parameters into Stack Spans

Cloudformation stacks can take in parameters, but this info isn't visible in the converted span data anywhere right now.
It might be cool to add this info somewhere on the span corresponding to each stack (and make it more easily searchable probably too).

I think the info might be findable from the DescribeStacks API (doc for the JS SDK and its response type) but I'm not sure

 Add stack parameters somewhere on the spans


Add table resize options to context menus

This resolves #311 by adding to the existing tables context menu options that allow for automatically resizing the columns to fit the available space or the content of the columns.
To test:

View any table (except a table with only 2 columns like the "Expansion Rules" table under "Sets"
Right click on any cell
Verify that the new menu items affect the table column sizes

Noticed that if i have two tables open and hit auto resize either to space or content the tables will resize to the width of the same panel instead of their own panels

Noticed that if i have two tables open and hit auto resize either to space or content the tables will resize to the width of the same panel instead of their own panels

Just to document our findings, this was a result of viewing two ActivityTablePanels in the same view. Currently, we're saving one configuration per panel type, not panel instance. This means that if you resize the columns for one ActivityTablePanel, the configuration will be saved to the db and then synched with the other ActivityTablePanel present in the view.
It's probably not a realistic scenario, but I think it's something worth noting.


Docs.MS CI Updates for Azure.Template

CI Update for release of Azure.Template

Docs Build status updates of commit d55c087:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

bundlepackages/azure-dotnet-preview.csv
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


ServiceBus: Added 2 properties to Subscription

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[X] The title of the PR is clear and informative.
[X] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[X] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[X] If applicable, the PR references the bug/issue that it fixes.
[X] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[X] I have read the contribution guidelines.
[X] My spec meets the review criteria:

[X] The spec conforms to the Swagger 2.0 specification.
[X] The spec follows the guidelines described in the Swagger checklist document.
[X] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

@ravbhatnagar - the PR adds two new properties to an existing model in a released api version. Please take a look.

New settable properties should be added in a new api-version.

@v-Ajnava any response for @ravbhatnagar comment?  the two new properties forwardTo and forwardDeadLetteredMessagesTo are something user can set, which is a breaking change, those should be introduced as part of new api version.

@anuchandy, will discuss with Arun and will let you know. an FYI,  Properties added in Subscription entity in the current PR were missed in the Previous PR https://github.com/Azure/azure-rest-api-specs/pull/2029 were we have added these in Queue entity, which is merged.

@simongdavies, please refer the email from @salameer with subject "RE: Question on this GitHub review comment", can you sign-off from ARM side?

@v-Ajnava, @arundsouza, @salameer -  Merging this PR based on the email discussion ["RE: Question on this GitHub review comment", From: Arun Dsouza].
In Service Bus land, queue and topic-subscription are symmetrical. The properties forwardTo and forwardDeadLetteredMessagesTo already exists for queue resource and it is wired to not have them for subscription resource. This PR ensure topic-subscription is on par with queue.

Bypassing ARM review due to no response to avoid delaying the service team. ARM team feel free to follow up with Swagger author for any future comments

 https://github.com/Azure/azure-sdk-for-python/pull/1682

 https://github.com/Azure/azure-sdk-for-ruby/pull/1167


Deleting any category, causes ALL apps to go exit their categories and go to main dashboard.

Environment
Docker
Version
0.11.3
Describe the problem
If I have for instance 3 categories, and some have apps.
If I delete a category, in this instance 1 with no apps, all of the apps leave their categories and go to the main dashboard.
Additional info
No response
Please tick the boxes

[X] You've read the docs
[X] You've checked for duplicate issues
[X] You've tried to debug yourself

All of the apps, not just the ones in the category?

Confirmed to be a bug, implementing a fix...

Yes, I tried 2 different times.
I have "Management", "Media", and "Glances".
All my apps were in "Management" and "Media" when I deleted the 'empty' "Glances" category.
The icons / apps all dropped out of "Management" and "Media" and went to the main Dashboard i.e. no category.

Fixed in 561055d


DOC: documenting callbacks with LCEL

Issue with current documentation:
https://python.langchain.com/docs/modules/callbacks/
This doc doesn't mention how to use callbacks with LCEL. It would be good to add that, to help with the migration from LLMChain to LCEL.
Idea or request for content:
https://python.langchain.com/docs/modules/chains/ does a nice job of showing code pre-LCEL and code post-LCEL.
https://github.com/langchain-ai/langchain/discussions/12670 shows how to pass the callback to invoke, but ideally the example shows how to bind the callback once (as opposed to passing to each invoke).

@dosubot the example from https://python.langchain.com/docs/modules/chains/ doesn't use LCEL class, it uses pipe operator a bunch. Can you show how to use the callbacks with the pipe operator syntax?

@dosubot that example is getting closer, but it doesn't use LCEL. This issue is about LCEL and callbacks

@dosu-bot unfortunately that LCEL class doesn't exist in the LangChain source code.
I was hoping for an example that passes the callback to LCEL during chain declaration, not to each chain's invocation

Closing in favor of https://github.com/langchain-ai/langchain/issues/14241


fix(ci): Remove failing arm64 lightwalletd builds

Motivation
The QEMU install step is currently failing in an unrelated PR:

Error response from daemon: Head "https://registry-1.docker.io/v2/tonistiigi/binfmt/manifests/latest": received unexpected HTTP status: 503 Service Unavailable

https://github.com/ZcashFoundation/zebra/actions/runs/3569163606/jobs/5998829876#step:6:142
Solution
We don't support arm64 or use it in our tests, so we can just remove it for now.
Review
This is failing all CI, so it is critical.
Reviewer Checklist

[ ] Will the PR name make sense to users?

[ ] Does it need extra CHANGELOG info? (new features, breaking changes, large changes)

[ ] Are the PR labels correct?
[ ] Does the code do what the ticket and PR says?
[ ] How do you know it works? Does it have tests?

Actually it looks like all of Docker is down.


dex returned 11

Version of Boardwalk:1.0.7
Version of Android:4.0.4
Device model:Metapad c32
Description of the problem: Error: java.lang.RuntimeException:java.lang.RuntimeException:Dex returned 11 with error:

Duplicate of #31. Sorry!


Calendar Aways Visible

Hi!
Firstly, I would like to thank and congratulate you for this spectacular calendar. I have used it frequently and I am very satisfied. However, there was a need to leave the calendar displaying after it was opened. I really do not want to use another just because of this need, but I'm not able to leave it open, I would need it to have some property that when passing it does not allow clicking on it outside the calendar it closes, just as it has the property of no Close when you select.

If you can, thank you.

I've solved this issue with CSS. Simply put the styling on .picker__holder inside of .picker. Here's my code (using Sass):
.picker {
  color: $black;
  float: left;
  font-size: 16px;
  height: 25rem;
  line-height: 1.2;
  position: relative;
  text-align: left;
  user-select: none;

  &:first-of-type {
    width: 80%;
  }

  &:last-of-type {
    width: 20%;
  }

  // this makes the picker appear all the time
  .picker__holder {
    max-height: 25rem;
    opacity: 1;
    transform: translateY(0) perspective(600px) rotateX(0);
  }
}

Please note that I have custom styling in here for my own project.


We need to shift the decorator range back one character so the splitter does not end up with

Issue created from code comment with imdone.io

NOTE:  We need to shift the decorator range back one character so the splitter does not end up with id:10
extensions/merge-conflict/src/mergeConflictParser.ts:97
@imdone - Efficiently manage your project's technical debt. imdone.io

Issue closed by removing a comment.

NOTE:  We need to shift the decorator range back one character so the splitter does not end up with id:10 gh:9
extensions/merge-conflict/src/mergeConflictParser.ts:97
@imdone - Efficiently manage your project's technical debt. imdone.io


Vimeo onPlayerReady broken: no event fires on load

Browser info: Chrome on MacOS [Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2454.101 Safari/537.36]
The HTMLVimeoVideoElement tries to do a play/pause cycle on load but on my machine this only pauses. Issues are fixed by eliminating the play/pause cycle but then presumably whatever bug this was introduced for would come back?

I am facing an odd issue, but may be related.
on first clicking Play, the Play event is not fired, infact even onPlayerReady event is also not fired. Then when I click on Pause and again Play. Then Play event is fired.
It started few days back, so it could be related and could be due to some change in Vimeo API?
Where did you make the change you are talking about, I could not find the play/pause cycle on load?

This is a temporary fix I did to fix the issue:
Not sure if its best way to do it?
--- a/popcorn-complete.js
+++ b/popcorn-complete.js
@@ -5292,7 +5292,8 @@
       playerReadyCallbacks = [],
       timeUpdateInterval,
       currentTimeInterval,
-      lastCurrentTime = 0;
+      lastCurrentTime = 0,
+       play = false;

     // Namespace all events we'll produce
     self._eventNamespace = Popcorn.guid( "HTMLVimeoVideoElement::" );
@@ -5516,6 +5517,13 @@
           if( duration > 0 && !playerReady ) {
             playerReady = true;
             player.pause();
+
+                 player.setVolume( 1 );
+                 // Switch message pump to use run-time message callback vs. startup
+                 window.removeEventListener( "message", startupMessage, false );
+                 window.addEventListener( "message", onStateChange, false );
+                 onPlayerReady();
+
           }
           break;
         case "pause":
@@ -5564,6 +5572,10 @@
           updateDuration( parseFloat( data.data.duration ) );
           break;
         case "playProgress":
+         if(!play && data.data.seconds > 0) {
+               play = true;
+               onPlay();
+         }
           onCurrentTime( parseFloat( data.data.seconds ) );
           break;
         case "play":


fix: config flag

Armada operator is setting args to be:
  containers:
  - args:
    - run
    - /config/application_config.yaml
    - /config/application_config.yaml

Where it should be
  containers:
  - args:
    - run
    - --config
    - /config/application_config.yaml

This resulted in pods failing to load the config file and reverting to defaults.

@dejanzele this can be closed