Small fixes to codecov and rustdoc

* [ ] I've included my change in CHANGELOG.md

Codecov Report
Base: 86.71% // Head: 86.88% // Increases project coverage by +0.16% :tada:

Coverage data is based on head (971b766) compared to base (e06dc75).
Patch coverage: 8.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #427      +/-   ##
==========================================
+ Coverage   86.71%   86.88%   +0.16%
==========================================
  Files          59       59
  Lines        7281     7267      -14
==========================================
  Hits         6314     6314
+ Misses        967      953      -14

Impacted Files
Coverage Δ

tests/423_de_borrowed_identifier.rs
100.00% <ø> (+10.71%)
:arrow_up:

src/ser/mod.rs
72.29% <8.33%> (+0.89%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Support for per-table AS OF clauses

@Hydrocharged could use your comments on the parser changes. We don't seem to have unit tests for the parser module? Maybe I'm looking in the wrong place?
Also the node I changed doesn't implement Walk, which I thought was weird.

@Hydrocharged could use your comments on the parser changes. We don't seem to have unit tests for the parser module? Maybe I'm looking in the wrong place?
Also the node I changed doesn't implement Walk, which I thought was weird.

The parser changes look fine to me, nothing to comment on. We don't have any unit tests for the parser, but we do have a suite of syntax tests that contain most valid syntax combinations. If a parser change causes a syntax regression for some valid Postgres syntax, then those tests will fail. OTOH, changes that cause previously non-parsing statements to now parse will also fail, forcing the tests to be updated. You can find these in testing/generation/command_docs/output
There are 3 levels:

Unimplemented: Statement doesn't parse
Parses: Statement produces a Doltgres AST, but does not a Vitess AST
Converts: Statement produces a Vitess AST

Unimplemented -> Parse basically works like unit tests for valid Postgres statements. But these won't cover things like AS OF since it's a syntax extension.


fix: fix scientific e notation as string

This MR should address #12 by simplify change Loader from yaml to rumel.yaml.

For example:
yaml_str = '''
x: 1e-4
y: !ref <x> * 0.1
'''
loaded_yaml = load_hyperpyyaml(yaml_str)
print(loaded_yaml)
print(type(loaded_yaml["x"]), type(loaded_yaml["y"]))

with yaml.Loader, the output will be
{'x': '1e-4', 'y': '1e-05'}
<class 'str'> <class 'str'>

with  rumel.yaml.Loader, the output will be
{'x': 0.0001, 'y': 1e-05}
<class 'float'> <class 'float'>

@pplantinga hi, could you make a quick review for this MR?

This is a known issue with pyyaml https://github.com/yaml/pyyaml/issues/173 implementing the 1.1 spec instead of 1.2.  To read these as floats, one could simply use 1.e-4 instead of 1e-4.
While it would be nice to have this, the approach outlined here fails the tests, and looks to me like it would take some considerable effort to get the tests to pass again, since changing the engine is a significant change. If you're willing to put that work in, more power to you, but this is not a pressing enough issue for us to solve it on our side.

This is a known issue with pyyaml yaml/pyyaml#173 implementing the 1.1 spec instead of 1.2. To read these as floats, one could simply use 1.e-4 instead of 1e-4.
While it would be nice to have this, the approach outlined here fails the tests, and looks to me like it would take some considerable effort to get the tests to pass again, since changing the engine is a significant change. If you're willing to put that work in, more power to you, but this is not a pressing enough issue for us to solve it on our side.

Hi, it seems like the Loader didn't add the constructor. It passed all test offline. Could you approve again to see if it could pass all the tests on CI?


✨  Add Binding objects to snapshot output

Summary
This PR extends the snapshot script to dump the Binding objects too.
Related issue(s)
Fixes #

/cc @francostellari

stylistically rest of the script uses 2 line spaces to separate blocks
I suggest replacing COLOR_RED with either COLOR_ERROR|COLOR_WARNING in case down the line somebody changes the color scheme

I revised the way Binding objects are listed: now the normal listing enumerates the objects, and in the case of empty cross product it shows the reason(s) why, and there is no longer an empty namespace listed for cluster-scoped objects. Following is a picture of example output.

/lgtm
Thank you


Update readme.md - Add Microcks in gRPC Testing tooling

Add Microcks (Mocking and Testing API tooling) to the curated list of useful resources for gRPC.

Up, please review 🙏 and let me know if you have any comments.

@bojand


Increase efficiency of wiki context creation

At present, 40-50% of wiki articles are rejected because they do not contain sections with greater than our minimum number of words. This introduces extra latency as we sequentially download additional articles until finding a suitable one.
We should instead download batches of pages concurrently so that we don't need to wait for sequential processing times.

@p-ferreira related to your current work


[sql] Add support for column-extraction schema migrations, and replication with legacy schema clients

Finally got this working to a point I'm happy with in the TS integration tests -- start there (apitests.ts / testSchemaChanges) to get a sense of what this feature adds.  I'm going to also try hammering on this with soak/replication tests, so may uncover as-of-yet unknown issues, but putting this up now in case people have cycles/want to take a look
The core thing we're adding is the ability to "extract" a column from a table to a one-to-many relationship with another table.
For example, we can go from a table with schema
CREATE TABLE users (id INTEGER PRIMARY KEY, username TEXT, email TEXT)
to two tables
CREATE TABLE users (id INTEGER PRIMARY KEY, username TEXT) and CREATE TABLE user_emails (user_id INTEGER, email TEXT, skdb_original INTEGER).
Crucially, we want to be able to serve clients connecting on either the old or the new schema.  To do so, we set up what I'm calling "legacy views" here, in which we maintain a view joining together the new users and user_emails tables, from which we can serve a client who doesn't know about the split.
On the read path, this doesn't involve much work for the server: just tail that view, but call it by the name that the client knows about.
On the write path, it's a bit more complicated: we take legacy-schema rows and split out the writes to the corresponding tables, then let them bubble up to the legacy view from there.  This requires some messing with the sources/writers as the writes bubble up, to make sure we tail all the new rows in the legacy view but don't reflect writes back to writers.
There are some pretty wide-ranging changes to support all that.  I tried to break things up into a commit history where each logical change can be viewed separately, but it's quite possible I've mixed that up or included some change that isn't strictly necessary here.
EDIT: see notion for a design doc with much greater detail.

I haven't looked closely yet, but first one high-level question that I expect to come up. When taking a write to the legacy view and splitting it up into multiple writes to the new tables, are there atomicity concerns to make sure that what used to be a single write of a single row ends up like a transaction? And if there are transactions involving the legacy views, that gets more involved, or not? I'm just wondering if you have some design comments around this that could help reading the code.

are there atomicity concerns to make sure that what used to be a single write of a single row ends up like a transaction? And if there are transactions involving the legacy views, that gets more involved, or not?

Yes, but all of the normal atomicity/transactional consistency stuff still works under these changes,  e.g. if a write violates a check constraint, is rejected for privacy reasons, etc. then it is rejected.  A single data message in the replication protocol consists of a sequence of table diffs; previously those were applied one-to-one (logic with the flavor of syntacticTableDiffs.map(semantics).each(apply)), now we first interpret each syntactic table diff as potentially multiple table diffs to apply (something like syntacticTableDiffs.flatMap(distribute-to-extracted-column-tables).map(semantics).each(apply)).   But all of that is wrapped in the same type of transaction as before.
Notably, when a column is extracted I generate a view checking the constraint that there is at most one "original" value for each primary key in the new table.  So if that gets violated, the transaction will be rejected.

Looks good to me. As in I don't spot anything concerning. But replication is very subtle. I'll run the simulation tests now with this checked out. But would be very good to add a schema migration to these tests and have two clients replicate with different schemas.

Simulation tests are broken actually. They need to be updated for the breaking change in the tail spec. I'm seeing the error "Tailer must specify an expected schema for each table".
You can run them with make test-replication. These and the soak tests (make test-soak) are worth running to be sure replication is solid.

Simulation tests are broken actually. They need to be updated for the breaking change in the tail spec. I'm seeing the error "Tailer must specify an expected schema for each table".
You can run them with make test-replication. These and the soak tests (make test-soak) are worth running to be sure replication is solid.

Those breakages are actually unrelated and predate this diff.  Fixed in #274

Tests all run ok then? You should ship this if they are good. I think the simulation tests are more interesting than soak for this diff.


Params flash undefined on specific route progression

Describe the bug
If you cold start in a tab with some path params, navigate out to a different part of the tree, then back to the same path, it will double render with the first render having undefined params

/some-route/$id
/home
/some-route/$id <- problem on first render here

Your Example Website or App
https://codesandbox.io/p/devbox/small-rgb-8ghsp6
Steps to Reproduce the Bug or Issue

start on /test/okay
go to /about
going to either /test/okay or /test/womp should show problem

Expected behavior
I expected params to always there or for the ts type to reflect possibly falsyness
Screenshots or Videos
No response
Platform

OS: any
Browser: any
Version: 1.0.0

Additional context
No response

I can't reproduce, not sure if I understood your steps correctly. Can you please provide a screen recording?
https://github.com/TanStack/router/assets/6340397/1b90a460-96dd-4c77-9f6f-3a3a6f4ef57d

sorry I should have mentioned that its logged in the console


Add terms and conditions

Adds a terms and conditions page to the public app
Uses a structured YAML approach that allows a helper to recursively walk the tree of YAML and output the required tags.
Test me
Pivotal ticket

I need to look into this a bit deeper. The YamlHelper doesn't have tests, should we add them or do you think this just produces html and therefore is not critical piece of code?

@novotnyjakub @axemonkey - I have made some updates to the terms and conditions content - and also added links to external terms and conditions (for AWS, Sendgrid and Google analytics). Could you please check that the links are configured correctly?
Also, there appears to be a duplicate paragraph (lines 32 and 68). I didn't want to delete in case it was supposed to be this way, but it if this is an error, could you please delete lines 68 - 75.


CDK drag/drop

Bug, feature request, or proposal:
No support for 2D-list
What is the expected behavior?
it must support 2D-list
What is the current behavior?
Only support for 1D and one convert 2D to 1D but no solution .
What are the steps to reproduce?
Providing a StackBlitz reproduction is the best way to share your issue.
StackBlitz starter: https://goo.gl/wwnhMV
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
8.2.1
Is there anything else we should know?

Duplicate of #13372


Apple Clearly Says This Is Not Allowed!

From Apple:

"Don't mask or call special attention to key display features. Don't attempt to hide the device's rounded corners, sensor housing, or indicator for accessing the Home screen by placing black bars at the top and bottom of the screen. Don't use visual adornments like brackets, bezels, shapes, or instructional text to call special attention to these areas, either."

https://developer.apple.com/ios/human-interface-guidelines/overview/iphone-x/

I Clearly Say This Is Not Allowed!
From Me:

New issue checklist

[ ] I have reviewed the README
[ ] I have searched existing issues and this is not a duplicate

https://github.com/HarshilShah/NotchKit/blob/master/.github/ISSUE_TEMPLATE.md


Removing an organization redirects to the 404 error page.

Context
When an org admin removes its org he gets redirected to the logout and then to the 404 error page.
This is probably due the logout process redirect the user to its (non existent) public page.
This issue is non blocking for the release.
Steps to Reproduce

Login with the organization admin user.
Go to the organization settings.
Click the "delete organization" link.

Current Result
After the org and users deletion the user gets redirected to the 404 error page.
Expected result
The user should get redirected elsewhere, for example to the login page.
Browser and version
Chrome Version 58.0.3029.110 (64-bit)
Onpremises 2.1.0-pre5: https://github.com/CartoDB/cartodb/tree/<IP_ADDRESS>

cc @juanignaciosl (not a blocker, normal priority)
Redirection is: DELETE organization -> /logout -> 404

It also happens from time to time with user deletion.


BASH_SOURCE is a bashism, we should use bin/bash

I did change the java call with an exec, shell should not lie around
once it did forward the args
Signed-off-by: Arthur Gautier<EMAIL_ADDRESS>

don't mean to be bikesheddy, but do you strongly prefer /bin/bash vs /usr/bin/env bash?
http://stackoverflow.com/questions/21612980/why-is-usr-bin-env-bash-superior-to-bin-bash

@adriancole fixed

Thanks! can you rebase this and squash into a single commit? I'll merge after

thx.. will get this through now!

thanks so much!
closed via d09d50b8fb3cdb75f11bffc93825f472c8193791


[FLINK-6982] [guava] Reduce guava dependency usages

What is the purpose of the change
This PR removes unnecessary guava dependencies from several modules. Instead of just replacing these with flink-shaded-guava i figured we can just remove them before integrating the shaded guava dependency.
For the most part this PR is only touching tests.
Brief change log

remove unused guava dependency from flink-scala and flink-streaming-scala
removed guava usages from flink-java
removed guava usages from flink-tests
removed guava usages from flink-yarn-tests
removed guava usages from flink-yarn

Verifying this change
This change is a trivial code cleanup, if it compiles and tests pass we're good.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

LGTM, +1

merging.


Add Enumerable

https://ruby-doc.org/core-2.2.0/Enumerable.html

Important methods have been added, and Enumerable is used in the core Array, Enumerator, Hash and Range objects


Specifying number as long int when calling method

When connecting to our java xmlRPC server, we're noting an issue where our javascript numbers are being converted to type int and then the xmlRPC looks up the method, it does not find a method that matches since it is expecting a long.
I see support for i8 tags have been added, but I'm not seeing a way in the code to use them when making a call, only on the return.
How can we make calls with variables sent as a Long?

Was able to add this functionality in a fairly hacked up way.
After line 24 in Serialize.js add:
    .att("xmlns:ex", "http://ws.apache.org/xmlrpc/namespaces/extensions")
After Line 180 in Serialize.js replace with:
    if(/<ex:i8>(.*?)<\/ex:i8>/g.exec(value)){
      value = value.replace(/(<([^>]+)>)/ig,"");
      xml.ele('ex:i8').raw(value)
    } else {
      xml.ele('string').d(value)
    }

then just use the ex:i8</ex:i8>tag in a string (yuck) to cast it as a long.
Again, this is a hack to get this to work with a tomcat xmlrpc servlet, but I wanted to note this for anyone else having the problem and maybe this can be implemented upstream sometime.


builders/wheel: Ensure dist-info is written determinisically

glob() returns values in "on disk" order. To make the RECORD file deterministic and consistent between builds we need to sort the data before adding to the records list.
Signed-off-by: Richard Purdie<EMAIL_ADDRESS>Resolves: python-poetry#

[ ] Added tests for changed code.
[ ] Updated documentation for changed code.

Interesting. I suppose, we should sort here as well since _add_file() is called in the loop?
https://github.com/python-poetry/poetry-core/blob/87186813480c9e120bf65cebe7bf8dd69aabc82c/src/poetry/core/masonry/builders/wheel.py#L193

Interesting. I suppose, we should sort here as well since _add_file() is called in the loop?
https://github.com/python-poetry/poetry-core/blob/87186813480c9e120bf65cebe7bf8dd69aabc82c/src/poetry/core/masonry/builders/wheel.py#L193

Yes, that looks like it would have the same issue.


Face Swap

Any plans on releasing the Face Swap, that is shown in the paper?

Please use the search function next time:
https://github.com/AliaksandrSiarohin/first-order-model/issues/36
https://github.com/AliaksandrSiarohin/first-order-model/issues/15
https://github.com/AliaksandrSiarohin/first-order-model/issues/9 (Original question with answer from @AliaksandrSiarohin)

Just wanted to ask again, because the week is over.

Oh okay, please leave a comment in the original issue then and close this one.

Ok thanks


I Want custom faster r-cnn. make rpn head to output full bbox, visible bbox and class. moreover, custom nms to use visible bbox score

I don't understand source code meaning.So, I can't custom model. I hope get help from more detail tutorial for custom model instead of
roughly tutorial on mmdetection official documentation.
If you have free time, Can you hava a meeting or wechat with me for the problem to clearly state the problem.

Have you read the tutorial here? https://mmdetection.readthedocs.io/en/latest/tutorials/customize_models.html
Could you be more specific about which part you do not know how to do it?

I have read.Can I specific to describe by Chinese?

Sure.

我想要用mmdecttion做行人检测任务，需要把rpn-head原来的cls，bbox分支增加一个可见区域分支，需要多输出4个坐标，然后修改nms算法。针对bbox，vis框和cls三项进行nms。但是，我看不懂源码，一是不明白源码内部的执行逻辑，二是不明白各个变量的含义，所以无从下手。

最后，还需要修改评价指标，将mAP切换为MR，这个在哪里修改也不知道。。

You can wirte a new rpn head, refer to https://mmdetection.readthedocs.io/en/latest/tutorials/customize_models.html, or modify the original one https://github.com/open-mmlab/mmdetection/blob/1872bc44d04601045110186ad566c7117f9a0b2a/mmdet/models/dense_heads/rpn_head.py#L59
For  针对bbox，vis框和cls三项进行nms, you can write a new nms function to replace the original one which is called in rpn head https://github.com/open-mmlab/mmdetection/blob/1872bc44d04601045110186ad566c7117f9a0b2a/mmdet/models/dense_heads/rpn_head.py#L231
For MR, you can overwrite the evaluate method in dataset you use https://github.com/open-mmlab/mmdetection/blob/1872bc44d04601045110186ad566c7117f9a0b2a/mmdet/datasets/custom.py#L291

通过提示，我阅读源码理解了部分问题。但是新的问题出现了，因为我这里需要对数据集进行处理，相比于一般的coco数据集多了一个vis_bbox（4个位置的坐标），并且在训练测试的每一个阶段，vis_bbox的处理都类似于原有的bbox，但是原来的处理流程只针对bbox_label。从数据处理流程引入vis_bbox标签，到后续训练中引入，如何处理

总地来说，数据集中引入了vis_bbox标签，不像我自己用pytorch写的代码可以知道每个模块含义，而且数据从哪到哪，配置文件把数据集加载到了哪里，从哪里调用给了谁，这对我来说像一个黑盒，因此无从下手。

There are lots of article in zhihu https://zhuanlan.zhihu.com/p/341954021, which can help you to understand our design concept.

To load vis_bbox, you can read https://mmdetection.readthedocs.io/en/latest/tutorials/customize_dataset.html first

Thank you. I have read the material that you recommand. I have a idea to solve my problem.If I have other problem.I will put a new issue.


Don't works when source and destination contains space characters in their paths

Got issues when I tried using prsync using file paths with spaces in it like "/Volumes/SD Card"
Original command :
prsync -avhW --inplace --no-compress --progress --exclude='node_modules' /Volumes/SD-A\ 2023/Backup\ SD\ CARD\ Candice\ HDD\ Maxor\ 2TB\ Red\ Case/ /Volumes/Candice\ 2T/backup-fast

# Tested with this also
prsync -avhW --inplace --no-compress --progress --exclude='node_modules' \"/Volumes/SD-A 2023/Backup SD CARD Candice HDD Maxor 2TB Red Case\" \"/Volumes/Candice 2T/backup-fast\"

# And this
prsync -avhW --inplace --no-compress --progress --exclude='node_modules' \"/Volumes/SD-A 2023/Backup SD CARD Candice HDD Maxor 2TB Red Case\" \"/Volumes/Candice 2T/backup-fast\"

rsync --files-from=/var/folders/c8/g84x62xj5vjfd0vdh892yhb80000gn/T/tmp.6ozsPah7GM/chunk.6 -avhW --inplace --no-compress --progress --exclude=node_modules /Volumes/SD-A 2023/Backup SD CARD Candice HDD Maxor 2TB Red Case/ /Volumes/Candice 2T/backup-fast

# Return error code 1
# Rsync log the help command output

Ugh. My initial response is: don't use spaces in file paths as it's bad practice. However, I then have to remind myself that sometimes these things happen outside of our control. I'll try to take a look at making it handle whitespaces correctly.

Hey @nathanhaigh great tool you've created here mate. I am about to give it a test spin and then I saw this comment here. Unfortunately I am trying to copy one Plex library from one drive to another and there are a whole heap of white space characters littered all over the place lol... Kinda scared this script is going to fall over at it but going to give it a shot and see what happens anyway.
Thanks for the great work putting this together! I am going to go try it out now and see how it goes. I might dig a bit deeper and see if we can include the support for white spaces without over complicating the script too much!

Ah yes, failed because of my exclude (which had a Windows folder path for the (x86) folder
rsync --files-from=/tmp/tmp.861qk8sjHY/chunk.2 -avxhHAWXS --numeric-ids --info=progress2 --exclude Program Files (x86) /mnt/eHDD01/ /mnt/eHDD02/
Is the command I wanted to parallelise, output of the command are:
INFO: Using up to 5 processes for transfer ...
INFO: Determining file list for transfer ...
INFO: 12567 (4672767 MB) files to transfer.
INFO: Distributing files among chunks ...
")syntax error: operand expected (error token is "
DONE (2s)
INFO: Starting transfers ...
rsync --files-from=/tmp/tmp.861qk8sjHY/chunk.2 -avxhHAWXS --numeric-ids --info=progress2 --exclude Program Files (x86) /mnt/eHDD01/ /mnt/eHDD02/
/usr/bin/bash: -c: line 1: syntax error near unexpected token `('
/usr/bin/bash: -c: line 1: `rsync --files-from=/tmp/tmp.861qk8sjHY/chunk.2 -avxhHAWXS --numeric-ids --info=progress2 --exclude Program Files (x86) /mnt/eHDD01/ /mnt/eHDD02/'
local:0/1/100%/1.0s rsync --files-from=/tmp/tmp.861qk8sjHY/chunk.4 -avxhHAWXS --numeric-ids --info=progress2 --exclude Program Files (x86) /mnt/eHDD01/ /mnt/eHDD02/
rsync --files-from=/tmp/tmp.861qk8sjHY/chunk.1 -avxhHAWXS --numeric-ids --info=progress2 --exclude Program Files (x86) /mnt/eHDD01/ /mnt/eHDD02/
/usr/bin/bash: -c: line 1: syntax error near unexpected token `('
/usr/bin/bash: -c: line 1: `rsync --files-from=/tmp/tmp.861qk8sjHY/chunk.4 -avxhHAWXS --numeric-ids --info=progress2 --exclude Program Files (x86) /mnt/eHDD01/ /mnt/eHDD02/'
local:1/2/100%/0.5s rsync --files-from=/tmp/tmp.861qk8sjHY/chunk.0 -avxhHAWXS --numeric-ids --info=progress2 --exclude Program Files (x86) /mnt/eHDD01/ /mnt/eHDD02/
/usr/bin/bash: -c: line 1: syntax error near unexpected token `('
/usr/bin/bash: -c: line 1: `rsync --files-from=/tmp/tmp.861qk8sjHY/chunk.1 -avxhHAWXS --numeric-ids --info=progress2 --exclude Program Files (x86) /mnt/eHDD01/ /mnt/eHDD02/'
local:1/3/100%/0.3s rsync --files-from=/tmp/tmp.861qk8sjHY/chunk.3 -avxhHAWXS --numeric-ids --info=progress2 --exclude Program Files (x86) /mnt/eHDD01/ /mnt/eHDD02/
/usr/bin/bash: -c: line 1: syntax error near unexpected token `('
/usr/bin/bash: -c: line 1: `rsync --files-from=/tmp/tmp.861qk8sjHY/chunk.0 -avxhHAWXS --numeric-ids --info=progress2 --exclude Program Files (x86) /mnt/eHDD01/ /mnt/eHDD02/'
local:1/4/100%/0.2s
Computers / CPU cores / Max jobs to run
1:local / 12 / 5

Computer:jobs running/jobs completed/%of started jobs/Average seconds to complete
local:1/4/100%/0.2s /usr/bin/bash: -c: line 1: syntax error near unexpected token `('
/usr/bin/bash: -c: line 1: `rsync --files-from=/tmp/tmp.861qk8sjHY/chunk.3 -avxhHAWXS --numeric-ids --info=progress2 --exclude Program Files (x86) /mnt/eHDD01/ /mnt/eHDD02/'
local:0/5/100%/0.2s

I'll poke around a bit and see what I can figure out, thanks again for the effort putting the foundation together!

Did a tiny bit of trial and error, modified the script for my use case (not a universal fix). Transfer speed with parallels equals single thread for my use case, so I am going back to running rsync manually in one thread.
Thanks again! I am keeping this in my toolkit as I can see real value in parallelisation doing a sync across WAN or maybe even LAN.


Difference between InPlaceABN and ABN

During conversion of a trained model, I found a difference in the implementation of InPlaceABN and ABN. Problem arises due to taking absolute value of weight in affine operation, which is not used by functional.batch_norm in ABN.
Minimal code to reproduce
abn = ABN(100, affine=True)
ipabn = InPlaceABN(100, affine=True)
abn.weight = nn.Parameter(-torch.ones(100))
ipabn.weight = abn.weight
abn.cuda()
ipabn.cuda()
inp = torch.rand((10, 100, 3, 3)).cuda()
abn_out = abn(inp)
ipabn_out = ipabn(inp)
torch.abs(abn_out - ipabn_out).max()

https://github.com/mapillary/inplace_abn/blob/42b09524b1bce788e7bcc190a55a6f020895fba8/modules/src/inplace_abn_cuda.cu#L114

@Chetter2 thank you for pointing this out. We introduced it in order to avoid division by zero and the change does not harm training compared to having the standard linear form.
It prevents nevertheless the possibility of loading directly models that were trained with standard bn in case they exhibit negative scaling factors. However, there are ways of pre-processing the pre-trained weights to overcome the incompatibility issue

Thank you for your prompt response.
I had an opposite problem when I tried to replace InPlaceABN with ABN (in order to use jit and deploy). I am already taken absolute values of weights and added epsilon to it. Now ABN works like a charm. But this behavior was quite unexpected.

ABN is intended as a replacement of Pyotrch's standard BN + activation function, and not as a non-inplace version of InPlaceABN. Since the naming might understandably generate confusion I'll update the ABN docstrings to highlight this.

@bonlime  I want to replace InplaceABN to ABN(or just BN + activation). Is there any way to do this?

Why the outputs are not exactly the same


Option to disable focus on bottom sheets

Feature Description
Currently if autoFocus is disabled the focus is still being set to the container:
https://github.com/angular/components/blob/45d34ad4ff85d36096df5ccef1b1f5658364372d/src/material/bottom-sheet/bottom-sheet-container.ts#L206-L215
It would be really useful to disable focus capturing entirely.
Use Case
In my case the bottom sheet is triggered by changing the value of a text input - which results in losing focus as soon as the bottom sheet opens.
As a workaround I'm saving the previously selected element and reset the focus to this element within afterOpened. The disadvantage of this workaround is that if you're switching focus before the bottom sheet is completely opened (e.g. by hitting tab) the focus is reset to the wrong element.

There are a couple more issues, aside from the one you listed:

Screen reader users would have no way of knowing that the bottom sheet was opened.
It would be a breaking change to modify the behavior of autoFocus to what you're proposing which means that we might have to add another focus-related flag to the config.

I don't see us supporting this; as a modal dialog, a11y strictly requires focus to move to the dialog element.


Question/Problem - Is possible to use react-native-notifications with aws amplify pinpoint?

Problem
We have the need to use amplify aws in react native but aws provides a library with many problems and we are trying to use some community library
iOS - Sending notification through aws pinpoint
On iOS all listeners worked correctly. All listeners work

registerNotificationReceivedForeground event correct
registerNotificationReceivedBackground event correct
registerNotificationOpened correct
getInitialNotification correct

Android - Sending notification through aws pinpoint

registerNotificationReceivedForeground event works when the app is open, working ok, but not show notification.
registerNotificationReceivedBackground event it only works with the app minimized, but it doesn't show the notification, app completely closed, nothing happens.
registerNotificationOpened unable to test because the notification to be played is not displayed
getInitialNotification always comes empty

Important: I tested it by sending directly from firebase to the android app and all events work correctly without any changes to the code
Versions
"react-native": "0.63.4",
"react-native-notifications": "^4.3.1",
It was necessary to make a patcher to work by changing the in ReactAppLifecycleFacade
hasActiveReactInstance to hasActiveCatalystInstance

UPDATE
Android - Sending notification through aws pinpoint
registerNotificationReceivedForeground event corret
registerNotificationOpened event corret
getInitialNotification event corret
registerNotificationReceivedBackground Notification is displayed but not triggered listener
iOS - Sending notification through aws pinpoint
On iOS all listeners worked correctly. All listeners work
registerNotificationReceivedForeground event correct
registerNotificationReceivedBackground event correct
registerNotificationOpened event correct
getInitialNotification event correct
Versions
"react-native": "0.63.4",
"react-native-notifications": "^4.3.1",
It was necessary to make a patcher to work by changing the in ReactAppLifecycleFacade
hasActiveReactInstance to hasActiveCatalystInstance


manifest create,add,inspect

Implememts manifest subcommands create, add, inspect.
Signed-off-by: Qi Wang<EMAIL_ADDRESS>

@jwhonce PTAL

@jwhonce @rhatdan @mheon @TomSweeneyRedHat PTAL

A couple of spacing/tab nits, otherwise LGTM

/approve

Buildah also has
buildah-manifest-annotate.1  buildah-manifest-push.1
buildah-manifest-remove.1

Buildah also has
buildah-manifest-annotate.1 buildah-manifest-push.1
buildah-manifest-remove.1

I plan to finish the rest implementation in a different PR.

/lgtm


Missing public Norms property on StringAttribute (among others)

Elastic: 2.1.2
Nest: 2.2.0
Can't set norms on the StringAttribute. Seems to be missing a public property for it. Might be missing on other attributes as well, didn't look to closely.

hey @stromblom, In NEST 2.x, norms can't currently be set using attribute based mapping since the property changed from being a boolean in NEST 1.x to an INorms in NEST 2.x that supports being enabled and whether norms are lazy or eager loaded.
It can be set with fluent mapping though and this can be combined with attribute based mapping:
var descriptor = new CreateIndexDescriptor("myindex")
    .Mappings(ms => ms
        .Map<Company>(m => m
            // infer mappings based on POCO property types and take into
            // account attribute mappings
            .AutoMap()
            // override certain inferred or attribute based mappings
            // from Automapping
            .Properties(ps => ps
                .String(s => s
                    .Name(c => c.Name)
                    // omit norms equivalent in Elasticsearch >= 2.0
                    .Norms(n => n
                        .Enabled(false)
                    )
                )
            )
        )
    );

Hope that helps :smile:


Link back to evaluation from Environment Failed Quality Gates in Bridge 0.7.2

Is your feature request related to a problem? Please describe.
No.
Describe the solution you'd like
The  Environment view in Bridge 0.7.2 shows the Quality Gates that failed, I would like to have a link back to the evaluation in the services view from the environment view where quality gates failed
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hi @leonvzGit,
great idea for improvement!
Let me add it to the backlog of the Bridge for 0.8.0.
I labeled it with help wanted because the implementation should be straight forward:

The bridge has deep linking functionality that allows linking to the event (evaluation-done): https://keptn.sh/docs/0.7.x/reference/bridge/deep_linking/#links-to-project-and-events
project/:projectName/:serviceName/:contextId/:eventId:
Add a label next to the text Quality gate of ... failed with a score of: 73 - go to: Evaluation result Evaluation result should then link to the evaluation done event in the services screen (--> project/:projectName/:serviceName/:contextId/:eventId:)


Added FIPS DEP initialization for the NonStop platform in fips/self_test.c.

Added FIPS DEP initialization for the NonStop platform in fips/self_test.c.
CLA: Permission is granted by the author to the OpenSSL team to use these modifications.
Fixes #12918
Signed-off-by: Randall S. Becker<EMAIL_ADDRESS>

Note that this does not entirely fix #12918 relating to the segmentation fault rwhen the FIPS DLL does not load.

This pull request is ready to merge

Merged
6b1428ac12749f7ff0e49be363e9f7097f0e58b0 Added FIPS DEP initialization for the NonStop platform in fips/self_test.c.


Move SupportedProtocolVersions to sui-types, rename AuthorityCapabilities -> AuthorityCapabilitiesV1

Quick refactoring to prepare for adding AuthorityCapabilitiesV2, which will include the digest of ProtocolConfig for each supported version.

Why moving it to sui-types?

Why moving it to sui-types?

In the next PR, I'll be adding SupportedProtocoVersionsWithHashes, which will contain the digest of each supported protocol config. This requires the Digest type, but sui-types already depends on sui-protocol-config, so I can't add a dependency back to sui-types


Multiple Crazyflie Hover control

Implement CrazyFlie class in Hover script to better organize code and enable control of multiple crazyflies via a modified launch file

Thanks!


Is Vue Design System SSR compatible?

Hello.
I'd like to use VDS with a Nuxt.js SSR build, but I can't get it to work. Is this package able work in SSR as there's no documentation regarding it. I'd prefer not spend more time trying to figure it out if it's not compatible in the first place.
Thanks.

i've implemented this system into a nuxt app... what isn't working for you?

It's my colleague taking this on now. I'll send him this link :)

Hello @daspete - we also have it working in Nuxt (to some extent) by importing components directly into our Nuxt pages. However, we're a bit in the dark about how to import the system JS as a whole.
In a typical Vue project, we can import the design system via main.js, but Nuxt does not have a main.js. Instead, importing for Vue.use() in Nuxt is typically done via 'plugin' files. Doing this though gives the error that system.js does not export a default.
So whilst we can ignore the plugin route, we're a bit worried about potential issues because of it.
Do you have an example repository for us to see how you integrated design system into Nuxt?
My own repo for Nuxt (minimal test case) is here FYI: https://github.com/michaelpumo/Nuxt-SSR
You can see that in nuxt.config.js, I commented out the plugin for Vue Design System.

Hey folks! Just returned from a 5 week “offline” trip, hence the little delay here. Let me get back to this early next week when I’ve survived the jet lag :)

Thanks @viljamis; much appreciated and hope you had a great holiday!

@michaelpumo hi there, i am on vacation right now, i have to look, if i have a sample repo on my pc @ home.... otherwise, i can init it in 6-7 days... sorry for the delay

Hi @daspete that'd be much appreciated. I just want to sanity check that we're doing things correctly, as there's no guide on using Vue Design System with Nuxt that I can find. Cheers!

because i also need ssr functionality, i debugged a little bit... the reason, why it's not compatible with ssr is, because of the amd pattern of the dist/system.js file. this loads the window object, this has to be replaced with "this"
the first three lines of the compiled system.js file should be:
! function(t, e) {
    "object" == typeof exports && "object" == typeof module ? module.exports = e() : "function" == typeof define && define.amd ? define([], e) : "object" == typeof exports ? exports.system = e() : t.system = e()
}(this, function() {

Now i got the key... in the file /build/webpack.system.conf.js you'll need to change the libraryTarget to 'commonjs'
After that, the designsystem is also usable with an ssr context

@daspete I’m a little bit confused, how did you get it working? I actually can’t get it working myself either now and tracked the issue down to the fact that we’re currently using webpack to build the library and it doesn’t really support ES module builds (and vue-loader dropped the support for other build a while ago which is now causing this I imagine).

@viljamis i just changed the libaryTarget value into commonjs2 at /build/webpack.system.conf
with commonjs2 you can build a package with module.exports functionality.
and the built package can be imported in nuxt.js as a plugin, which can also be used server side, because, there is no more umd pattern, which includes the window object

@daspete Hmm, yes, I tried with commonjs2 as well earlier, but couldn’t get that working either since it doesn’t do export default. So… how exactly are you importing the system? I tested your example here: https://github.com/daspete/nuxt-design-system, but no luck with that either as even when changing the libraryTarget to commonjs2 you still just get the "export 'default' (imported as 'system') was not found in 'vue-design-system' error (which makes sense as Webpack does not support exporting to ES module currently).

@daspete Anyway, to makes things simpler and to fix all these issues I’m planning on switching away from Webpack for the build process.

@viljamis oh, the nuxt-design-system repo is a little outdated, since there is<EMAIL_ADDRESS>out now... i haven't checked, if it works with<EMAIL_ADDRESS>i will update the nuxt-design-system repo, so it works straight out of the box.
hmm, to which build system will you switch?

@daspete Maybe no need to change it for now! Got the setup now working perfectly with Nuxt. I do still see that warning about missing default export, but that doesn’t seem to affect anything really. Trying to see if there’s an easy way to get rid of it. Will push a tiny release fixing a few things during the next few days hopefully.

@daspete If you open browser’s console while viewing your Nuxt.js project, do you see Uncaught TypeError: Cannot assign to read only property 'exports' of object?
While everything works for me, I think that should be fixed, but I’m having a bit of a hard time right now figuring out how exactly should it be solved + what’s causing it.
I created a new related working branch: https://github.com/viljamis/vue-design-system/pull/118
Would love to hear if you or anyone else has any ideas on what to do to fix that typeError. It’s related to the fact that Webpack/commonjs2 libraryTargets adds the exports.default, but I’m not sure what would be the optimal way to solve this.

@jackbarham @michaelpumo Do you have anything against if if I rename this to Nuxt.js compatibility as I don’t see the same issues when using a completely custom SSR setup?

@daspete @jackbarham @michaelpumo Ok, I got the whole setup working perfectly with Nuxt now. Releasing a new version soon and a new “official” demo.

Happy to tell you folks that I’ve added Nuxt.js support and that there’s an official demo now with small-ish instructions. See release notes: https://github.com/viljamis/vue-design-system/releases/tag/3.5.2


[WIP] Add timeout for TCP connect.

:white_check_mark: Build AElf <IP_ADDRESS>81 completed (commit https://github.com/AElfProject/AElf/commit/fbd0884af4 by @samfrb)