Using Haul Packager to Build an iOS Release Bundle

Current Behavior
I am using Haul packager with RN and for some reason I can build my RN app in dev mode for iOS. When I change the schema to release and I try to build the app it launches the app and crashes. I am not sure, but I think this occurred after a react upgrade.
Expected Behavior
Have haul properly bundle an iOS build for release and instructions on how to test that bundle locally on a device and simulator.
It would be nice to have documentation to understand how to use haul bundle is used for accomplishing this task of releasing an iOS app. Is there a place to find explanations for the bundle map and assets folder generated from haul bundle or how the CLI command builds a release version for a react device?
Haul Configuration (webpack.haul.js)
My "Bundle React Native code and Images" Build Phase is set to this
export NODE_BINARY=node
export CLI_PATH=node_modules/haul/bin/cli.js
../node_modules/react-native/scripts/react-native-xcode.sh

My haul webpack is configured for typescript
module.exports = ({ platform }, { module, resolve, output }) => ({
  entry: "./src/app",
  module: Object.assign({}, module, {
    rules: [
      {
        test: /\.tsx?$/,
        exclude: "/node_modules/",
        use: [
          {
            loader: "babel-loader"
          },
          {
            loader: "ts-loader"
          }
        ]
      },
      ...module.rules
    ]
  }),
  resolve: Object.assign({}, resolve, {
    extensions: [
      ".ts",
      ".tsx",
      `.${platform}.ts`,
      ".native.ts",
      `.${platform}.tsx`,
      ".native.tsx",
      ...resolve.extensions
    ]
  }),
  output: Object.assign({}, output, {
    filename: `index.${platform}.bundle`
  })
});

Your Environment

software
version

Haul
1.0.0.beta13

react-native
54.0.0

node
v8.4.0

npm or yarn
yarn

Sorry if this issue has came up before.. I have been really stressed about getting this to work!

Hey @aaronkchsu , thanks for filling up the issue.
Can you try to bundle your app without output specified in webpack.haul.js ? My guess is that it overrides default RN naming, so your app in release mode cannot find the file with default name.
Also, if you run your app (in prod mode) from xcode, can you have a look into the logs for potential error message?
Thanks!

The access to the project would be very helpful. If the crash happens after running the app, it may be connected with uglify producing faulty output.

Thanks so much for the quick responses guys! @thymikee @Krizzu So this is the output from the xcode project!

*** First throw call stack:
(
	0   CoreFoundation                      0x01747ded __exceptionPreprocess + 189
	1   libobjc.A.dylib                     0x00edcd6f objc_exception_throw + 49
	2   React                               0x00573e14 RCTFatal + 503
	3   React                               0x005940e9 __28-[RCTCxxBridge handleError:]_block_invoke + 682
	4   libdispatch.dylib                   0x03467f05 _dispatch_call_block_and_release + 15
	5   libdispatch.dylib                   0x03492cc9 _dispatch_client_callout + 14
	6   libdispatch.dylib                   0x03472b08 _dispatch_main_queue_callback_4CF + 1784
	7   CoreFoundation                      0x0170bbbe __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 14
	8   CoreFoundation                      0x016d1bed __CFRunLoopRun + 2445
	9   CoreFoundation                      0x016d0fd4 CFRunLoopRunSpecific + 372
	10  CoreFoundation                      0x016d0e4b CFRunLoopRunInMode + 123
	11  GraphicsServices                    0x08e50a7a GSEventRunModal + 71
	12  GraphicsServices                    0x08e5095f GSEventRun + 80
	13  UIKit                               0x01c34bc9 UIApplicationMain + 148
	14  Blerp                               0x00003933 main + 96
	15  libdyld.dylib                       0x034cd779 start + 1
)
libc++abi.dylib: terminating with uncaught exception of type NSException

I tried removing the output but it still gives the same error.
@thymikee The project is on gitlab! Do you happen to have a gitlab tag I could invite you to?
And that is interesting! What's the best way to play around with the uglify settings to see if we can get this to work? Thanks again so much :)

Thanks @thymikee! Just to make sure.. is this correct where would I put "haul": "git://github.com/callstack/haul.git" in package.json to pull from master? I did that.. but when i try to runhaul start for the ios bundle I get these warnings and it seems like it is stalling at 65%!
iOS        [==                  ] 10%(node:38868) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
(node:38868) DeprecationWarning: The callback argument was splitted into resolveContext and callback.
(node:38868) DeprecationWarning: The type arguments (string) is now a hook argument (Hook). Pass a reference to the hook instead.
(node:38868) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot read property 'undefined' of undefined
(node:38868) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:38868) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): TypeError: Cannot read property 'undefined' of undefined
(node:38868) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 3): TypeError: Cannot read property 'undefined' of undefined
(node:38868) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 4): TypeError: Cannot read property 'undefined' of undefined
(node:38868) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 5): TypeError: Cannot read property 'undefined' of undefined
iOS        [=====               ] 25%(node:38868) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 6): TypeError: Cannot read property 'undefined' of undefined
(node:38868) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 7): TypeError: Cannot read property 'undefined' of undefined
iOS        [=============       ] 65%

Can you try this commit specifically?
git://github.com/callstack/haul.git#7a12370c1b3055ac7c717854743cb13fae2f1cd1

We've upgraded to webpack 4 on master but still need some work to get the deprecation warnings fixed.

IT WORKED! @thymikee you are my hero.

Just to clarify - we have fixed the issue, just need a release :)


Move all GVFS development into the public repo

This has actually be in the works for several weeks already, but for the sake of better transparency, I thought I'd share what we're up to.
We are working on moving all GVFS development efforts into the public repo. Currently what we do is work against a private repo in VSTS, and every time we release a new version, also push its sources to GitHub. The reason we've been working this way is that we have a bunch of build/test/release pipeline infrastructure set up in VSTS. But now that it's possible to integrate VSTS builds with GitHub repos, we want to move all of our development into the open so that everyone can see the day-to-day PRs, the work items, etc and to make it easier for anyone else to contribute.
The tasks that need to happen to make this possible:

Move all work items into GitHub issues and retire the private backlog
Integrate all of our PR and CI builds definitions with the GitHub repo. We have a whole slew of tests that run in every PR: unit tests, functional tests, perf tests, as well as tests that clone real repos and run their actual builds on top of GVFS.
Use GitHub for all releases. Currently internal releases are using a private nuget feed but that makes our release process too difficult to manage.
Update our release process to work with the GitHub repo
Implementation detail, but we also need to move all of our build/test/release assets into a new VSTS project to make all of this work
And we need to do a similar amount of work for our private Git fork

All of our development has been happening here in the GitHub repo as of last Monday. The internal repo is now retired.


LightWallet::transactions() returns transactions with spends reported twice

I used Zingolib to create a transaction that spent 0.1 TAZ via a UA with 3 receivers. On the receiving wallet, it all looks good. 0.1 TAZ was received exclusively to the orchard pool.
But the sending wallet is showing an unexpected transaction history.
In particular, for the outbound TransactionMetadata it has outgoing_tx_data with two entries in it. Both are for 0.1 TAZ, but one has the original 3-receiver UA as the to_address and the other has the orchard-receiver UA as the to_address.
I'm a little surprised to see the multi-receiver UA in the to_address at all, but I suppose this comes from the trickery that ZingoLib plays with the memo in the change note.
As it is, I don't know how to tell programmatically that I should ignore one OutgoingTxData and read the other. Why is it being represented this way, and how should I parse this so I can show the user what spends were in the transaction without showing the same spend twice?

Deleting the wallet file and recreating resolves the issue, so evidently the bug is in how the transaction is recorded in the wallet file when it is originally created and broadcast.

The problem came back after recreating the wallet. Somehow even downloading the transaction from the blockchain leads to corruption. Evidently it only appears after the first read of transactions after sync, since deleting the wallet file made the problem go away, only to come right back next time I tested.

thank you! this is the same as issue https://github.com/zingolabs/zingolib/issues/553

That issue has been closed, but the repro for this still works on dev.

It seems that with each save/load cycle, the problem is compounded with more duplication in the outgoing_tx_data array.


FaaS metrics - Not clear which attributes should be added to each metric

The current FaaS metric semantic conventions list several metrics, and then lists the attributes .
I'm working on moving the metrics to YAML, and it is not clear which attributes should be added to each metric.
Before the attribute table, it is stated:

Below is a table of the attributes to be included on FaaS metric events

then after, there's this statement:

Outgoing FaaS invocations are identified using the faas.invoked_* attributes above. faas.trigger SHOULD be included in all metric events while faas.invoked_* attributes apply on outgoing FaaS invocation events only.

It says the attributes faas.invoked_* should be included in "outgoing FaaS invocation events only" but then it says "Outgoing FaaS invocations are identified using the faas.invoked_*". The metric table does not list what attributes are to be added, so it's unclear which metric is "outgoing" and which are not.
In the FaaS span semconv we have more info:
Incoming invocations

This section describes incoming FaaS invocations as they are reported by the FaaS instance itself.
For incoming FaaS spans, the span kind MUST be Server.

Outgoing invocations

This section describes outgoing FaaS invocations as they are reported by a client calling a FaaS instance.
For outgoing FaaS spans, the span kind MUST be Client

I looked at the existing metrics and after reading all, my "gut feeling" is:

Outgoing faas.invoke_duration : the client invoking the function knows how long it took
Incoming faas.init_duration, faas.coldstarts, faas.errors: It seems to me these are "server" information, meaning the FaaS itself know this info about itself?
? faas.invocations: Is this the client counting how many times it invoked the function? Or is the function counting how many times it was invoked? 🤔
? faas.timeouts: Is this the client reporting how many times invocations timed out? Or is it the server/function itself while doing other things?

CC @skonto since you were the original author, could you shed some light on this?

faas.invoke_duration : the client invoking the function knows how long it took

Then the important duration of the server-side execution (which was renamed to invocation to reduce confusion https://github.com/open-telemetry/opentelemetry-specification/pull/3209) is missing.

faas.timeouts, faas.errors

seems relevant to a status attribute discussion (and then the timeout/error is reported as a status code and not an individual metric) - https://github.com/open-telemetry/opentelemetry-specification/issues/3243

faas.invocations

It seems it can be drived from  faas.invoke_duration histogram, is this metric is necessary at all?

faas.invocations

It seems it can be derived from faas.invoke_duration histogram, is this metric is necessary at all?

Good question. faas.invocations says: Number of successful invocations. If faas.invoke_duration also counts the number of successful ones (which I think it does/should) then I think you are right, it can be derived.


Experimentation Tooling and Parameter Optimization

Hey @natolambert, I am Ayush working as an MLE at Weights and Biases. I saw your tweet summarizing trl and the roadmap of features to be added soon.
In particular, I saw the mention of "experimentation tools/parameter sweeping", and thought of reaching out to see if we (W&B) can support the integration in any way.
Looking forward to your reply :)

Hi @ayulockin! That sounds great! I think a good first step would be to work on an example (e.g. in examples+docs) of a parameter sweep with W&B. Based on feedback and usage we can then see how/if we want to directly integrate it into the library.

Closing this for now - feel free to reopen if there's an update!


29-Feb-2024 → D-MMMZ

moment.parseFormat('29-Feb-2024') parsed to D-MMMZ, I expected: DD-MMM-YYYY

interesting. Does that only happen for Feb 29 or for any date?

no for that specific format DD-MMM-YYYY I'm getting as D-MMMZ

I haven't seen that format yet, is it common in your region?
I think it should work as expected if you leave out the dashes

Yes, it is common for us, Our product needs this date format DD-MMM-YYYY (including dashes)
So to Verify the date is in correct format or not, I use moment.parseFormat('04-Mar-2024') but it is not working as expected.


Need to set Namespace when inserting vectors

Great package!
We keep multiple sets of vectors in a single database and use the Namespace to differentiate between the sets. The Vector object does not support Namespace. Can that get added?
Thanks.

Set when calling Upsert I see.


fix: articles/time-series-insights/time-series-insights-parameterized-urls.md

Use backticks so element isn't swallowed

@nschonni : Thanks for your contribution! The author, @ashannon7, has been notified to review your proposed change.


Option to use a folder within an existing repo

Is your feature request related to a problem? Please describe.
I see an option to create a new repo, and to link to an existing one. It'd be nice if I could link to an existing one but choose a specific path within the repo.

I disagree. I want all LeetHub repos to make use of same structure. This is what sets us apart. Structure = good


Missing C++ book added

What does this PR do?
Improve repo
For resources
Description
The C++ book was removed at some point but it still exited on archive.org
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[X] Read our contributing guidelines
[X] Search for duplicates.
[X] Include author(s) and platform where appropriate.
[X] Put lists in alphabetical order, correct spacing.
[X] Add needed indications (PDF, access notes, under construction)

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

404 error for this link.


[fastlane_core] Updated gh_inspector dependency

👍

Coverage increased (+0.006%) to 66.945% when pulling 67a31b1366526b2a5d915960cb8ba1872fb726a3 on KrauseFx-patch-7-1 into b3457a746bf3fccc6ff10f6df57951d5976cf5a1 on master.


[$1000] Mentions results does not close when we change focus

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Open the app
Open any report
Add some text in beginning and add @ and type any letters to get mentions
shift focus to start of compose box and observe mentions results are still visible
Try same thing with emoji suggestion and observe that suggestions close when we shift focus

Expected Result:
App should close mention results on shifting focus like it does for emoji suggestions
Actual Result:
App does not close mention results on shifting focus
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[x] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: v1.3.13-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/b97e16bb-cf25-4380-8737-a766fa9e9675
https://github.com/Expensify/App/assets/43996225/e7ff6f36-786c-43bb-96be-3153fd7bf158
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683891760906869
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f6abecc2436476a9
Upwork Job ID:<PHONE_NUMBER>085680128
Last Price Increase: 2023-05-17

Proposal
Please re-state the problem that we are trying to solve in this issue.
Mentions results does not close when we change focus
What is the root cause of that problem?
We are checking if the current selection is smaller than 1 then early return here:
https://github.com/Expensify/App/blob/293f23b57be2bca3f3eb0af903d5e0c2894cb36a/src/pages/home/report/ReportActionCompose.js#L519-L521
When user moves cursor before "@" character, the selection end is now 0, so the suggestion mentions isn't re-calculated which caused this issue.
What changes do you think we should make in order to solve the problem?
In stead of early return here and do nothing, we should resetSuggestion then return:
         if (this.state.selection.end < 1) {
            this.resetSuggestions();
            return;
        }

What alternative solutions did you explore? (Optional)

Reproduced.

Both proposals do not work, the suggestion list sometimes not closing

Yeah I tried both!

Sorry for the confusion @hoangzinh. Not sure why it was behaving weirdly yesterday.
I tried testing this again, it looks good to me.
@hayata-suenaga
Let's hire @hoangzinh for this one.
Let's go with resetSuggestions() that's the better approach!
Let me know your thoughts.
C+ Reviewed
👀 🎀 👀

@Santhosh-Sellavel can you review my proposal? i suggested to use resetSuggestion()

Yeah, that seems my mistake 😂 . Nevermind @hoangzinh  👍

@Santhosh-Sellavel thank you for the review. I'm assigning @hoangzinh for this issue

Another friendly bump @Santhosh-Sellavel, I can pay out the C+ contract once the checklist is complete. Thanks!

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[x]  [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/18469
[x]  [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:  https://github.com/Expensify/App/pull/18469/files#r1215739274
[x]  [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This should have been caught in PR Testing based on the checklist.
[x]  [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
[x]  [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ]  [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Do we need Regression testing here @puneetlath? I think we don't need here let me know your thoughts and if you differ on anything above, thanks!

@Santhosh-Sellavel although if the same regression occurs it's likely the issue will be caught in other test suites, it will be a good idea to explicitly create a regression test for this

Heading OOO for this week. @johncschuster — we're almost done here, there are two steps remaining:

Once @Santhosh-Sellavel proposes the regression steps, we'll need to open an issue to have those added to Testrail
We'll then need to pay out @Santhosh-Sellavel via https://www.upwork.com/ab/applicants/1658751456085680128/job-details - he's already been hired.

Thanks!

Sounds good, @bfitzexpensify!

Regression Test Steps

Open any report
Add some text in beginning and add @ and type any letters to get mentions
Move cursor to start of compose box
Verify that mention suggestions is closed
Move cursor to mention text
Verify that mention suggestions is open

👍  or 👎
cc: @hayata-suenaga

Thanks, @puneetlath! Should we capture the suggested regressions steps above, or do we already have a suite of initial testing steps already written?


Looking forward to integrating easy_refresh

Thank you so much for developing such a great tool, it helped me tremendously during my development process. However, I found during use that the loading animation effect cannot be customized at present.
I previously discovered a great refresh plugin, easy_refresh, which provides a lot of interesting animation effects.
It would be great if you could integrate easy_refresh into your utils. In this way, we can implement more functions through state.refreshController, such as calling callRefresh, etc.
Thank you again for all your hard work!

You can customize the UI of the PagingHelperView using a ThemeExtension called PagingHelperViewTheme. I've added a section to the README with more details and examples 👍
https://github.com/K9i-0/riverpod_paging_utils?tab=readme-ov-file#ui-customization

You can customize the UI of the PagingHelperView using a ThemeExtension called PagingHelperViewTheme. I've added a section to the README with more details and examples 👍
https://github.com/K9i-0/riverpod_paging_utils?tab=readme-ov-file#ui-customization
The pull to refresh UI cannot be customized at this time, but would you like to customize it as well?

Addition of construction functions, refinement and control functions, use functions to sequence the ground touching renewal operations. It is possible to actually see a similar function, for example provider.refreshIndicatorController?.callRefresh(). After the instruction, the page will be updated and displayed, and the video will be displayed. Thank you again for your support of this general.(My English is not good, this paragraph was translated through Google, please forgive me if the sentences don't make sense.)

You can customize the UI of the PagingHelperView using a ThemeExtension called PagingHelperViewTheme. I've added a section to the README with more details and examples 👍
https://github.com/K9i-0/riverpod_paging_utils?tab=readme-ov-file#ui-customization
The pull to refresh UI cannot be customized at this time, but would you like to customize it as well?

ユーザーがプログラムでリフレッシュ操作をトリガーできるように、より詳細なリフレッシュ制御機能を追加することをお勧めします。 Provider.refreshIndicatorController?.callRefresh() など、同様の機能を実現するメソッドの実装を検討できます。このメソッドを呼び出した後、ページは更新操作をトリガーし、読み込みアニメーションを自動的に表示します。これにより、ユーザー エクスペリエンスが大幅に向上します。ありがとうございます。 （私の英語は苦手です。Googleで翻訳したものです。意味が分からない場合は、補足してください。）

新しくデフォルトのRefreshIndicatorを無効にする機能を追加し、exampleにeasy_refreshを使うサンプルを追加しました。目的は達成できそうですか？
https://github.com/K9i-0/riverpod_paging_utils?tab=readme-ov-file#advanced-customization

新しくデフォルトのRefreshIndicatorを無効にする機能を追加し、exampleにeasy_refreshを使うサンプルを追加しました。目的は達成できそうですか？
https://github.com/K9i-0/riverpod_paging_utils?tab=readme-ov-file#advanced-customization

あなたは私の心の中のウルトラマンです。谢谢你 :)


Fix serialization bug

Closes #261

Lol I guess the way I wrote it is not standard. Gonna change that.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>4
Details

0 of 1 (0.0%)  changed or added relevant line in 1 file are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 71.385%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/model.jl
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

src/model.jl
1
70.48%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
1402

Relevant Lines:
1964

💛  - Coveralls

I don't understand why the serialization test you wrote didn't pick up this bug though. Maybe if you are in the same session the serializer just gets the current object? would be weird.

No I think the test wasn't actually run, fixing at https://github.com/TuringLang/JuliaBUGS.jl/pull/263
thanks for suggesting looking into it

Sorry for before @miguelbiron the CI should be fixed now, could you uncomment the tests for serialization and see if they run?

Will do

Seems like activating the tests reduced coverage? Not sure how that could happen. And the benchmark issue seems related to permissions.

benchmark might error because BridgeStan is segfaulting on macOS, so as long as it runs, it's okay

@miguelbiron apologies I usually won't do this, but since this fixes a bug that's pretty bad, I am merging it into master now

Hey @sunxd3 I didn't know you were waiting for me to merge! But I'm pretty sure I  didn't have permission to do that or I would've done that otherwise. Anyway, I'm glad it's fixed!


don't use UMLS as primary identifier for taxonomy

I would rather receive an NCBI taxonomy identifier in most cases. However, there are many species that aren't in NCBI, so some other source might be needed for those (GBIF or Catalog of Life?). One problem example: searching for "american goldfinch", I get this result:
[
  {
    "curie": "UMLS:C0326959",
    "label": "Carduelis tristis",
    "synonyms": [
      "Spinus tristis",
      "Fringilla tristis",
      "Carduelis tristis",
      "American goldfinch",
      "Astragalinus tristis",
      "Carduelis tristis (organism)"
    ],
    "types": [
      "biolink:OrganismTaxon",
      "biolink:NamedThing",
      "biolink:Entity"
    ]
  }
]

However the taxonomically valid name for this species is "Spinus tristis" (a synonym here). "Carduelis tristis" is a taxonomic synonym. See https://www.ncbi.nlm.nih.gov/Taxonomy/Browser/wwwtax.cgi?mode=Info&id=54773&lvl=3&lin=f&keep=1&srchmode=1&unlock and https://verifier.globalnames.org/?capitalize=on&format=html&names=Carduelis+tristis

This situation is slightly worst in Babel 2023jun29, where UMLS:C0326959 is entirely missing, because it's semantic type -- T012 -- is no longer mapped correctly into the Biolink model.
The NCBITaxon situation should be an easier fix: it looks like we're only importing "scientific name" and "synonym" (meaning taxonomic synonym, not alternate name) and ignoring "common name" and "genbank common name", which is where the common names live.

The list of possible name_class values we can use, as of the May 1 release of NCBITaxon (I think), is:
     25 	genbank acronym
    230 	blast name
    667 	in-part
   2086 	acronym
  14641 	common name
  30328 	genbank common name
  56575 	equivalent name
  75081 	includes
 220185 	type material
 245827 	synonym
 670412 	authority
2503930 	scientific name

So we definitely want to add common name and genbank common name so that organism common names will work, and we might want to bring in equivalent name and keep synonym so we can keep synonyms (e.g. Pinus abies is a synonym of the currently accepted name, Picea abies, so we would expect both to potentially bring back the same taxonomic name). I will need to double-check the rest to make sure we don't need them. I am very surprised but pleased to see the 220,185 references to type material in here!


Can't delete challenge

Describe the bug:
I can't delete a (pending) challenge.
Expected behaviour:
I should be able to delete it without having to remove the finalizers.
Steps to reproduce the bug:
Not sure it's reproducible, in my case it was a namespace that got created and soon later I deleted all resources one by one (not by deleting the namespace itself), so maybe that got it into this state.
Environment details::

Kubernetes version (e.g. v1.10.2): 1.11.2
Cloud-provider/provisioner (e.g. GKE, kops AWS, etc): AWS/custom
cert-manager version (e.g. v0.4.0): 0.7.0
Install method (e.g. helm or static manifests): static manifest

/kind bug

🤔 are you able to put together a reproduction? Cert-manager should remove the finalizer automatically after attempting to clean up the challenge resource.
Is cert-manager running? Can you provide logs from around the time you deleted the resource?

This might help:
E0424 15:40:20.423510       1 controller.go:125] Error getting Order "xxx-1251750797" referenced by resource "xxx-1251750797-0"
I probably deleted the order before I deleted the challenge. Deleting the order should have updated the challenge references though, right?

I can confirm that this is still a problem with v0.7.2. I probably should just delete the namespace and leave it to k8s to clean up the resources.

I am hitting the same issue.  Is there a way to force delete this resource?  kubectl wont let me let go of it

If someone can put together a repro for this, or a dump of logs and all the Certificate/Order/Challenge/Issuer then I can dig into what's going on. Otherwise it's very difficult to get started working out where the issues may lie 😄

The problem is that when you hit the problem you have already delete everything but the challenge.
What would help most is documentation about how to remove cert-manager.
Could be because it is a ClusterIssuer, or because of the deletion order.

I was able to delete it after editing the challenge and removing the finalizer.

That just happened again but this time I only deleted the namespace and had k8s clean up resources. So now the namespace is stuck deleting, the only resource available being the challenge. Deleting that doesn't work either.
@tellisnz-shift Removing the finalizer isn't a solution though since it means whatever it's really stuck on deleting will just be orphaned and left behind.

We've now added uninstallation documentation here: https://docs.cert-manager.io/en/latest/tasks/uninstall/kubernetes.html
If you follow these instructions and make sure that no cert-manager resources exist before uninstalling cert-manager, you won't run into issues with finalization 😄

@munnerz This isn't about uninstalling cert-manager (@jdelafon just somewhat hijacked the issue..), this is about deleting a namespace that has a certificates (challenges and orders) where the challenges (and hence the namespace) gets stuck in terminating.

@tellisnz-shift, thanks!
kubectl patch crd challenges.certmanager.k8s.io -p '{"metadata":{"finalizers": []}}' --type=merge

or
kubectl patch crd challenges.acme.cert-manager.io -p '{"metadata":{"finalizers": []}}' --type=merge

works fine.

I just ran into this. The easier route is to reinstall the OLD version of the CRDs & cert-manager. You should then be able to cleanly delete the challenges. Then, follow the cert-managers uninstall instructions from the beginning.

Does anyone of you actually read the description? It's quite annoying tbh.

This isn't about uninstalling the cert-manager with challenges left behind etc
Removing the finalizer means you're just ignoring the underlying problem

@discordianfish Yes, and in every case I've seen, it is either a symptom of not following the uninstall instructions correctly, OR (in the case of GKE being unable to delete a namespace) the lack of a firewall rule allowing communication from the master IP range to webhook port the nodes. Currently, there is nothing in the the description or comments of this issue to indicate it is actually a software bug.  If you have any more info to add to differentiate this issue, then maybe we could be of more help. But given that a misconfigured network could also cause this, there isn't anyway for us to be able to eliminate configuration issues in your cluster or network as a possible cause.

@discordianfish Yes, and in every case I've seen, it is either a symptom of not following the uninstall instructions, OR the lack of a firewall rule allowing communication from the master IP range to webhook port the nodes. Currently, there is nothing in the the description or comments of this issue to indicate it is actually a software bug, as opposed to a network or cluster misconfiguration.  If you have any more info to add to differentiate this issue, then maybe we could be of more help. But, at the moment, there isn't anyway for us to be able to eliminate configuration issues in your cluster or network as a possible cause.
Have you looked through your k8s logs for references to the finalizer failing?
Are you still running cert-manager v0.7.0 (which is blocked by letsencrypt)? If so, have you tried upgrading the CRDs + cert-manager to v0.8.0+?

kubectl patch crd challenges.acme.cert-manager.io -p '{"metadata":{"finalizers": []}}' --type=merge for v1.0.0+

This saved my butt going to reference here:  https://github.com/kubernetes/kubernetes/issues/60538

Still hitting deadlock in cert-manager v1.7.1 in Kubernetes v1.23.3

Patching the challenge doesn't have any effect. The finalizers still there. I even tried to manually edit the resource and it doesn't allow me to save it without the finalizers.

This worked for me

I had to patch the challenges to remove to remove their Finalizers:
kubectl get challenges -n cert-manager | grep -v NAME | awk '{print $1}' | xargs kubectl patch challenge -p '{"metadata":{"finalizers": []}}' --type=merge -n cert-manager

@mau21mau answer helped me figuring out how to delete the challenge. First, I found the name of the challenge I wanted to delete via the command:
kubectl get challenges
let's say it was called pending-challenge-tls-12345. Then the command to remove this challenge is the following:
kubectl patch challenge pending-challenge-tls-12345 -p '{"metadata":{"finalizers": []}}' --type=merge

The above solution from @mau21mau helped me as well, however I also had to delete the validating and mutating cert-manager admissions (this is because my cert-manager namespace was stuck terminating and I could not reapply the webhook resource accordingly):
kubectl delete validatingwebhookconfigurations.admissionregistration.k8s.io $CERT_MANAGER_WEBHOOK
kubectl delete mutatingwebhookconfigurations.admissionregistration.k8s.io $CERT_MANAGER_WEBHOOK

Was just hit by the same deadlock folks were describing above.
Cert manager: v1.10.1
Kubernetes: v1.24.7
Attempted to delete the Challenge since it was fail-looping with a 429 (Too Many Requests) from the DigitalOcean API. When that didn't work, I modified the ingress and was able to remove the associated CertificateRequest, however the Challenge persisted.
@mau21mau's suggestion managed to mitigate the issue, however the underlying issue certainly seems present.

Updated docs for uninstalling can be found here: https://cert-manager.io/docs/installation/kubectl/#uninstalling

This happens frequently for us. Restarting cert-manager fixes it. So definitely cert-manager seems to be "stuck" in this state. kubectl rollout restart deployment cert-manager


Rancher re-applys cluster import yaml, causing loss of env vars set in original import yaml

Version: v2.3-head
What kind of request is this (question/bug/enhancement/feature request):
Bug, causing issues with clusters behind proxies
Background:
For proxy setups (cluster behind proxy, not Rancher) we need to manually edit the import YAML that Rancher provides us thru the UI so that we can set the necessary proxy environment vars on the agent pods. When we modify this YAML then apply it so the cluster will import into Rancher, Rancher appears to re apply yaml thus breaking our changes (our env vars). We have to manually apply the import YAML again in order to get our env vars back so that the agent pods can use the proxy.
Steps to reproduce:

Set up Rancher v2.3-head, single-node
Set up a proxy server such as with squid
Set up a 1 node RKE or K3s cluster to use the proxy
I made sure that my host had the proper env vars, and docker (for RKE machine).
Import the cluster into Rancher, don't apply the import YAML yet. Download the import YAML and edit it so that you add these env vars to the Deployment (cattle-cluster-agent) and DaemonSet (cattle-node-agent)
TAKE CARE to modify the "user" and "password" and "my_proxy"url" accordingly and the port if you are using a non-default port (squid).

          - name: HTTP_PROXY
            value: "user:password@my_proxy_url:3128"
          - name: HTTPS_PROXY
            value: "user:password@my_proxy_url:3128"
          - name: NO_PROXY
            value: "localhost,<IP_ADDRESS>,<IP_ADDRESS>/8,<IP_ADDRESS>"

Save changes to the YAML. Use kubectl to watch deployments. Apply the YAML so the cluster will import into Rancher.
We see the deployment is created and pods are 1/1. However, a few seconds later the deployment gets updated (pods 2/1 then 1/1) and this is where we lose our env vars.

Result:
Rancher appears to apply the YAML again and we'll eventually lose our custom env settings we set for the cluster-agent and node-agent (which are required to import a cluster behind a proxy).
Workaround is to manually apply the import yaml again. When we do this we'll see the pods go to 2/1 then 1/1 and then we're good and have our env vars back.
gz#13333

Longer term, it would be ideal to have a better solution. I'm thinking of a way that the user can supply proxy settings in the Rancher UI before they create the cluster (get to the final step to get the import YAML). Ideally, user would simply supply cluster proxy settings in the UI then this would be sent to the Rancher server. We'd get back proper import YAML that also included these proxy settings for the necessary pods.

I also notice that just importing a k3s cluster the cattle-node-agent terminates many times then recreates. After a while everything is fine -- just thought this was odd.
root@ip-172-31-6-182:~# kubectl get pods -A -w
NAMESPACE       NAME                                      READY   STATUS              RESTARTS   AGE
kube-system     metrics-server-6d684c7b5-496w4            1/1     Running             0          10m
kube-system     local-path-provisioner-58fb86bdfd-xgn8c   1/1     Running             0          10m
kube-system     helm-install-traefik-j7wt5                0/1     Completed           1          10m
kube-system     svclb-traefik-msztg                       2/2     Running             0          10m
kube-system     coredns-d798c9dd-56bw8                    1/1     Running             0          10m
kube-system     traefik-6787cddb4b-z4846                  1/1     Running             0          10m
kube-system     svclb-traefik-rvkwt                       2/2     Running             0          9m3s
kube-system     svclb-traefik-fw5c2                       2/2     Running             0          5m36s
kube-system     svclb-traefik-fjdsd                       2/2     Running             0          5m24s
cattle-system   cattle-cluster-agent-6dcc68fc5-dw7j5      0/1     ContainerCreating   0          14s
cattle-system   cattle-node-agent-ngvdj                   0/1     ContainerCreating   0          14s
cattle-system   cattle-node-agent-7djlp                   1/1     Running             0          14s
cattle-system   cattle-node-agent-mg8xz                   1/1     Running             0          14s
cattle-system   cattle-node-agent-xlgjq                   1/1     Running             0          14s
cattle-system   cattle-node-agent-ngvdj                   1/1     Running             0          20s
cattle-system   cattle-cluster-agent-6dcc68fc5-dw7j5      1/1     Running             0          20s
cattle-system   cattle-cluster-agent-57b9b6fff-5p9l8      0/1     Pending             0          0s
cattle-system   cattle-cluster-agent-57b9b6fff-5p9l8      0/1     Pending             0          0s
cattle-system   cattle-node-agent-xlgjq                   1/1     Terminating         0          28s
cattle-system   cattle-cluster-agent-57b9b6fff-5p9l8      0/1     ContainerCreating   0          0s
cattle-system   cattle-node-agent-xlgjq                   0/1     Terminating         0          29s
cattle-system   cattle-cluster-agent-57b9b6fff-5p9l8      1/1     Running             0          2s
cattle-system   cattle-cluster-agent-6dcc68fc5-dw7j5      1/1     Terminating         0          30s
cattle-system   cattle-node-agent-xlgjq                   0/1     Terminating         0          30s
cattle-system   cattle-node-agent-xlgjq                   0/1     Terminating         0          30s
cattle-system   cattle-node-agent-bwkl4                   0/1     Pending             0          0s
cattle-system   cattle-node-agent-bwkl4                   0/1     Pending             0          0s
cattle-system   cattle-node-agent-bwkl4                   0/1     ContainerCreating   0          1s
cattle-system   cattle-cluster-agent-6dcc68fc5-dw7j5      0/1     Terminating         0          31s
cattle-system   cattle-node-agent-bwkl4                   1/1     Running             0          1s
cattle-system   cattle-node-agent-ngvdj                   1/1     Terminating         0          31s
cattle-system   cattle-node-agent-ngvdj                   0/1     Terminating         0          32s
cattle-system   cattle-cluster-agent-6dcc68fc5-dw7j5      0/1     Terminating         0          38s
cattle-system   cattle-cluster-agent-6dcc68fc5-dw7j5      0/1     Terminating         0          38s
cattle-system   cattle-node-agent-ngvdj                   0/1     Terminating         0          38s
cattle-system   cattle-node-agent-ngvdj                   0/1     Terminating         0          38s
cattle-system   cattle-node-agent-rdkbl                   0/1     Pending             0          0s
cattle-system   cattle-node-agent-rdkbl                   0/1     Pending             0          0s
cattle-system   cattle-node-agent-rdkbl                   0/1     ContainerCreating   0          1s
cattle-system   cattle-node-agent-rdkbl                   1/1     Running             0          2s
cattle-system   cattle-node-agent-mg8xz                   1/1     Terminating         0          40s
cattle-system   cattle-node-agent-mg8xz                   0/1     Terminating         0          40s
cattle-system   cattle-node-agent-mg8xz                   0/1     Terminating         0          50s
cattle-system   cattle-node-agent-mg8xz                   0/1     Terminating         0          50s
cattle-system   cattle-node-agent-z9jw4                   0/1     Pending             0          0s
cattle-system   cattle-node-agent-z9jw4                   0/1     Pending             0          0s
cattle-system   cattle-node-agent-z9jw4                   0/1     ContainerCreating   0          0s
cattle-system   cattle-node-agent-z9jw4                   1/1     Running             0          1s
cattle-system   cattle-node-agent-7djlp                   1/1     Terminating         0          51s
cattle-system   cattle-node-agent-7djlp                   0/1     Terminating         0          52s
cattle-system   cattle-node-agent-7djlp                   0/1     Terminating         0          53s
cattle-system   cattle-node-agent-7djlp                   0/1     Terminating         0          53s
cattle-system   cattle-node-agent-pwv7r                   0/1     Pending             0          0s
cattle-system   cattle-node-agent-pwv7r                   0/1     Pending             0          0s
cattle-system   cattle-node-agent-pwv7r                   0/1     ContainerCreating   0          1s
cattle-system   cattle-node-agent-pwv7r                   1/1     Running             0          2s

@davidnuzik Using imported clusters behind proxy was validated as fixed on 2.3-head shortly before you opened this ticket. So now i am wondering, whether you had used an outdated branch or the fix and validation was incomplete.

https://github.com/rancher/rancher/issues/24876#issuecomment-585409048

Tracking this in https://github.com/rancher/rancher/issues/24876

Tracking this in https://github.com/rancher/rancher/issues/24876


Tool exits and logs no errors or warnings

When I run blc https://dialex.github.io/start-testing/
It outputs Getting links from: https://dialex.github.io/start-testing.
And that's it. Stops the execution. No errors.
Am I doing something wrong?

Thats because the Page is empty without JavaScript ;)

Oh... I use docsify 🙁

I'm also facing a similar issue on a local project but it uses the LAMP stack, so there is no JS injected stuff. Not sure why it's not working. It works on other projects using similar technologies.

The problem was in my usage. The project has robots set to none on my local environment. Use the -f flag fixed it.


Upgrade dartdoc to 0.11.0 for flutter.

@Hixie @devoncarew @sethladd -- I think dartdoc is finally ready to be upgraded for flutter.  While this change is tiny, implications are large.  To make this somewhat easier to review:
http://jcollins1.pdx.corp.google.com:8000/  -- flutter docs by 0.11.0 (new version), serving:  flutter0110demo.tar.gz.
http://jcollins1.pdx.corp.google.com:8001/  -- flutter docs by 0.9.11 (old version), serving:
flutter0911demo.tar.gz.   This is the same as http://docs.flutter.io, but generated from the exact same flutter rev as the one, above.
Text diff between the two: flutter-0.11.0-doc.diff.gz
And, of course, the dartdoc CHANGELOG.
There are many warnings printed by dartdoc now which you will likely see in the bot output.  I believe these were all problems before, but are now visible and deduped.   While it of course does not fix every bug ever, please approve if you think that this is a step forward for flutter's dartdocs.

🍾 🎈


Visualization on time series, with boxplots, and points connected per subject

This is standard thing often needed.

This is same than miaViz issue 41. That is better package although miaTime vignette might show examples.


.container should be available as a mixin

First off, I do understand that CSS classes can be used as mixins. Please continue reading for a detailed explanation why I think the .container functionality should be available as a pure mixin.
Side note: this is somewhat related to #14276, but I think it's different enough or at least hopefully explained well enough to warrant a separate issue. #14276 doesn't state the problem clearly and mainly concentrates on a possible solution (which isn't backwards compatible, so I don't recommend it).
I'm using the Bootstrap mixins/classes with LESS for more semantic markup; using mixins instead of adding the classes to the HTML. However, to use .container() in my less files, I have to include the whole less/grid.less file that includes the other grid classes. This results in about 30KB of CSS classes being dumped into my compiled CSS that I don't need since I won't be adding them to my HTML tags.
I can work around this by copying just the .container code to my own file and changing it to just be a mixin, but seems to me that this should be available by default since Bootstrap 3 already includes so much to support semantic markup.
I think this could be implemented just by moving the code for the .container class to less/mixins/grid.less (adding parentheses to make it a pure mixin of course), re-naming it, and then calling it from less/grid.less for the .container class.

@cvrebert, do you have any thoughts on this...Would it be helpful if I did a pull request showing my proposed solution?

Sounds square
On Mar 13, 2015 1:37 PM, "jmotes"<EMAIL_ADDRESS>wrote:

@cvrebert https://github.com/cvrebert, do you have any thoughts on
this...Would it be helpful if I did a pull request showing my proposed
solution?
--
Reply to this email directly or view it on GitHub
https://github.com/twbs/bootstrap/issues/15997#issuecomment-79168163.

To clarify, you want the following code available as a mixin, right?

.container {
  .container-fixed();

  @media (min-width: @screen-sm-min) {
    width: @container-sm;
  }
  @media (min-width: @screen-md-min) {
    width: @container-md;
  }
  @media (min-width: @screen-lg-min) {
    width: @container-lg;
  }
}

If so, I don't think we'll go that route in v3. It's an extra abstraction that will add complications too close to the end of life for this version. I'm unsure we'd even do this in v4, but I do understand the urge to have more semantic markup. Lots of changes will be coming for that in the next major release.

@mdo, that is the code in question. I understand your reasoning....Looking forward to Bootstrap 4!


Unable to save aspnet-sessionid using NLog in .net framework application

<target xsi:type="File"name="LogFileAppender"fileName="C:\Users\acer\Downloads\test1.txt"         layout="${longdate} ${aspnet-sessionid} - ${message} "/>
It is saving (as per layout) in target fileName like
2020-05-07 11:16:56.4047 - Global.asax.cs:Application_Start(): Application initializing, starting cache load
Unable to save aspnet-sesionid using NLog.

You have injected your own Session-Item-value called "SessionID". You can extract such custom values like this:
${aspnet-session:SessionID}
See also: https://docs.microsoft.com/en-us/dotnet/api/system.web.httpsessionstatebase.item

Hi sir,
I tried with below layout rendereder also , but still it's null
${aspnet-sessionid} .
Thanks,
Shilpa
On Fri, 8 May 2020, 21:22 Rolf Kristensen<EMAIL_ADDRESS>wrote:

You have injected your own Session-Item-value called "SessionID". You can
extract such custom values like this:
${aspnet-session:SessionID}
See also:
https://docs.microsoft.com/en-us/dotnet/api/system.web.httpsessionstatebase.item
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NLog/NLog/issues/3951#issuecomment-625882283, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AKC7RPO2V2WCD4QN3XY5I4TRQQTFVANCNFSM4M4HDP7A
.

It is ${aspnet-session:SessionID
Sent from my Sony Xperia
---- Shilpakopparad wrote ----
Hi sir,
I tried with below layout rendereder also , but still it's null
${aspnet-sessionid} .
Thanks,
Shilpa
On Fri, 8 May 2020, 21:22 Rolf Kristensen<EMAIL_ADDRESS>wrote:

You have injected your own Session-Item-value called "SessionID". You can
extract such custom values like this:
${aspnet-session:SessionID}
See also:
https://docs.microsoft.com/en-us/dotnet/api/system.web.httpsessionstatebase.item
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/NLog/NLog/issues/3951#issuecomment-625882283, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AKC7RPO2V2WCD4QN3XY5I4TRQQTFVANCNFSM4M4HDP7A
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHubhttps://github.com/NLog/NLog/issues/3951#issuecomment-625887997, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACXZ7HHXFTIUZKPYQX5EEO3RQQUT7ANCNFSM4M4HDP7A.

How to use below layout renderer in .net framework.
(https://github.com/NLog/NLog/wiki/AspNetSessionId-layout-renderer).
I tried with ${aspnet-session:SessionID} layout renderer , still its value is null.

Then I give up. I tried to decipher what value Log4net returned for you, but I guess I failed.
Guess you are condemned to use the debugger, and look at the output from the InternalLogger to figure out what value your application uses for SessionID.

Please fill in the template. We are missing a lot of information.


Create examples with different datasets

One of our favourite things about Kedro is its versatility, the ability to adapt to different use-cases and needs. It truly makes our day when our users come up with their projects exploring the countless possibilities for Kedro-usage.
To check out some of the coolest kedro-examples developed by our community, have a look at the Kedro-Examples repository.
With that in mind, we would love to see your examples! Show us what you can do!
To help you on the quest, here are some learning aids:

Video walkthrough beginner's guide to Kedro by @dataengineerone (NOTE: this video uses Kedro version 0.16.4. The latest version 0.16.5 does not have a pipeline.py file. More details here).
Our Hello World  example
Iris dataset example
Spaceflights tutorial
Video demo on how to convert your Jupyter Notebook into a Kedro project - demo repo is here
Blogpost on What is Kedro? by our super-user @WaylonWalker
Tutorial on how to create a project with Custom Datasets using the Pokémon Kaggle dataset.

Questions? You are always welcome to message us on Stack Overflow with the #kedro and #python tags. And now, you can also leave your questions at the Kedro Community website.
Now, pick your favourite dataset and let's get started! Our favourite examples will be linked on the official examples repository.
Happy sprinting!  🏃🏿♀🏃🏽♂

@laisbsc, Is this issue still available for hacktoberfest ?


Codespace obscure zebra v5457j46xvpf5rr

[x] Have you followed the contributing guidelines?
[x] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Investment Project.

My browser cant get open  the localhost....


Add kafka oci image to cli env minimal

Purpose
Currently, no messaging protocol implementation is configured in this environment.
As Kafka is currently the default protocol, Kafka and Zookeeper images are added to the configuration.
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no

Hi @obermeier the minimal image is intended to use MQTT as a message broker so that the StreamPipes installation is more lightweight. Is there a reason you want to use Kafka/Zookeeper with this setup and don't use one of the Kafka CLI profiles? Or do you think we should change something in the Kafka profiles?

Hi @obermeier well, that's a good question ;-)
I guess the short answer is it's supported, but incomplete.
Long answer:
The preferredProtocol can be defined at installation time as an environment variable. In the messaging settings in the UI, the prioritized protocols can be sorted. Any extension service can define its supportedProtocols (this can even be defined individually for each pipeline element). There can be one or more supported protocols. So when using the pipeline editor and connecting two pipeline elements, the system also checks for a protocol match. E.g., when you have two extension services with one service supporting NATS and Kafka and another service supporting Kafka, NATS and Pulsar, the system would select the protocol depending on the priority defined in the UI.
What makes this feature incomplete is that changes in the UI will only affect newly created pipelines. Existing pipelines use the protocol selected during pipeline creation. Feature completeness would be achieved by migrating all existing adapters and pipelines in case the protocol priority is changed.
I'm a bit unsure what to do with this feature:
On the one hand, it can be useful in the future when thinking of edge-cloud scenarios, e.g., pipelines with pipeline elements which exchange data over local nodes (which could be something lightweight like MQTT and NATS) and other pipeline elements supporting Kafka and Pulsar for more centralized, heavyweight processing.
On the other hand, removing the dynamic selection would simplify the system and selecting a global protocol add installation time would be permanent.
What do you think?

Hi @dominikriemer,
thank you very much for the explanation. In my opinion, this is a very useful feature, especially for the examples which you mentioned!
Related to my misconfiguration, I think there is no change required, since the error is easy to detect and resolve


Invalid character 'o' looking for beginning of value

I've seen this 2 times now, is that a bug?
Screenshot:

Nope. It's not. It's just a failed attempt at error handling :(


updated component and style guide

Description

updated the component guide to reference to the announcement banner documentation
added a TOC to the component guide
updated the style guide to include how to updated TOCs in markdown files
add split instructions to contributing file

I'm going to add how to run a split test to this PR.. so don't merge just yet.

We need to discuss where split.io documentation should go before we merge this in.


Improve is cross cluster task check

What changed?

Check if source and target domain is the same before checking the active cluster

Why?

During failover a non-cross cluster task may be treated as cross cluster.

How did you test it?

Unit test

Potential risks

Release notes

Documentation Changes

Pull Request Test Coverage Report for Build 2fb900d8-01e9-4798-8b6f-6f3532e3d828

6 of 6 (100.0%)  changed or added relevant lines in 1 file are covered.
80 unchanged lines in 15 files lost coverage.
Overall coverage decreased (-0.02%) to 56.768%

Files with Coverage Reduction
New Missed Lines
%

service/history/execution/mutable_state_task_refresher.go
1
74.4%

service/history/queue/timer_queue_processor_base.go
1
79.46%

client/history/client.go
2
40.34%

client/history/metricClient.go
2
47.05%

common/persistence/executionManager.go
2
75.5%

common/persistence/statsComputer.go
2
95.71%

service/history/execution/mutable_state_builder.go
2
69.92%

service/history/handler.go
2
46.05%

service/history/queue/timer_gate.go
3
95.83%

service/frontend/workflowHandler.go
4
58.07%

Totals

Change from base Build 0b2d3a44-d3e0-4ff6-b627-546a9c5712c1:
-0.02%

Covered Lines:
77833

Relevant Lines:
137106

💛  - Coveralls


Add benchmarks

As mentioned here.
A simple, state-of-the-art tool you could use is ApacheBench; I'll try it out and post results here.

I did a quick and dirty fix:
diff --git a/http.c b/http.c
index 7334de0..0ea35f3 100644
--- a/http.c
+++ b/http.c
@@ -100,16 +100,18 @@ void parse_request_line(s_string *bareLine, s_http_request *request) {

         s_string http11 = create_string("HTTP/1.1", 8);

-        if(compare_string(&protocol, &http11)) {
+        // if(compare_string(&protocol, &http11)) {
             message_log("Requested resource: ", DEBUG);
             string_log(&request->resource, DEBUG);
             request->status = OK;
+        /*
         }
         else {
             message_log("HTTP version unsupported", DEBUG);
             request->status = HTTP_VERSION_NOT_SUPPORTED;
             return;
         }
+        */

         delete_string(http11);
     }
diff --git a/worker.c b/worker.c
index 3f8fb79..f1420e9 100644
--- a/worker.c
+++ b/worker.c
@@ -93,6 +93,7 @@ int create_worker() {
                     message_log("Error 500", ERR);
                     cli_connection->currentRequest->status = BAD_REQUEST;
                 }
+                close_client_connection(cli_connection);
             }
             else if(event_queue[i].events & EPOLLOUT) { //one of connected clients is ready to read
                 if(cli_connection->response_buffer.size > 0) { //there is some data remaining so let's send it

With this patch, I did a simple run, which is far from a complete benchmark but a starting point:
Nginx ( ab -H 'Host: xxxxx' -c 100 -n 100000 http://<IP_ADDRESS>/index.html):
Server Hostname:        <IP_ADDRESS>
Server Port:            80

Document Path:          /index.html
Document Length:        2588 bytes

Concurrency Level:      100
Time taken for tests:   10.543 seconds
Complete requests:      100000
Failed requests:        0
Write errors:           0
Total transferred:      282200000 bytes
HTML transferred:       258800000 bytes
Requests per second:    9484.95 [#/sec] (mean)
Time per request:       10.543 [ms] (mean)
Time per request:       0.105 [ms] (mean, across all concurrent requests)
Transfer rate:          26139.18 [Kbytes/sec] received

Connection Times (ms)
              min  mean[+/-sd] median   max
Connect:        0    5   0.7      5       8
Processing:     1    6   1.0      6      15
Waiting:        0    4   1.2      4      13
Total:          2   11   0.7     10      19
WARNING: The median and mean for the total time are not within a normal deviation
        These results are probably not that reliable.

Percentage of the requests served within a certain time (ms)
  50%     10
  66%     11
  75%     11
  80%     11
  90%     11
  95%     12
  98%     12
  99%     12
 100%     19 (longest request)

Lear ( ab -c 100 -n 100000 http://<IP_ADDRESS>:9000/index.html):
Server Software:
Server Hostname:        <IP_ADDRESS>
Server Port:            9000

Document Path:          /index.html
Document Length:        2588 bytes

Concurrency Level:      100
Time taken for tests:   10.344 seconds
Complete requests:      100000
Failed requests:        0
Write errors:           0
Total transferred:      262900000 bytes
HTML transferred:       258800000 bytes
Requests per second:    9667.88 [#/sec] (mean)
Time per request:       10.344 [ms] (mean)
Time per request:       0.103 [ms] (mean, across all concurrent requests)
Transfer rate:          24821.15 [Kbytes/sec] received

Connection Times (ms)
              min  mean[+/-sd] median   max
Connect:        0    4   0.7      4       8
Processing:     1    6   1.0      6      11
Waiting:        0    5   1.1      5      10
Total:          5   10   1.2     10      15

Percentage of the requests served within a certain time (ms)
  50%     10
  66%     11
  75%     11
  80%     11
  90%     12
  95%     12
  98%     13
  99%     13
 100%     15 (longest request)

Thanks! It looks quite impressive. I'll try to eliminate major bottlenecks and give it a try again :)

@CapacitorSet, the server should be benchmarkable by ab now, but some of my changes severly degraded performance. I'd like to tweak it during next days and create some visual result to add to readme

I've added sample ab results to README, and will update it with every new commit (I'm currently profiling the server for better performance). While serving small files, it appears to be slightly better than nginx for single-threaded, and MUCH better for multi-threaded environments
For big files, it's much worse than nginx in any case.
Also, please run any other test you'd like


Installation of flow gateway

I'm in Southeast Asia. How come the recommended is in East Asia? How do I check my default environment and region? And how do I change them in Azure? If I'd like to switch region of the gateway installation after successfully once, do I have to uninstall and reinstall to switch region?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 25f8411c-d9d8-54c8-cfb9-bafe3856d061
Version Independent ID: 5bd1ee67-4ca2-a0d7-60e8-0ed39835bc4b
Content: Understand on-premises data gateways - Microsoft Flow
Content Source: flow-docs/gateway-reference.md
Service: flow
GitHub Login: @MSFTMan
Microsoft Alias: deonhe

@desmondkung  Thanks for reporting this issue. Please let us know where you see the recommendation. Thanks!

@MSFTMan Hi mate, I've uninstalled the gateway long ago and won't be able to follow-up anymore. This issue was opened more than a year back.

@MSFTMan Based on the comment I left last year, I think the recommendation option might've been in the installer itself.


HDDS-5315 Skip storing unwanted block tokens on OM DB

What changes were proposed in this pull request?
Block tokens do not need to be stored in OM DB.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5315
How was this patch tested?

[ ] Replace jar in a testbed and check keys stored.

Thanks @kerneltime for working on this. PR LGTM. Can you add a unit test by create a key with a client then get key and verify token is not there in the returned key location infos?

Thanks @kerneltime for working on this. PR LGTM. Can you add a unit test by create a key with a client then get key and verify token is not there in the returned key location infos?

Yup makes sense.

testSetNodeOpStateAndCommandFired runs fine locally, not sure why it failed in CI

I don't think this is related. kick off a recheck.

/recheck

+1, I will merge it shortly.

Unit test PR: https://github.com/apache/ozone/pull/2329


chore: use rn-blurshash 1.1.11

Description
Use the same RN-blurhash version as in palette.
I did this instead of upgrading palette to 2.0.0 because the latter breaks the android build. See: https://app.circleci.com/pipelines/github/artsy/eigen/51084/workflows/4cbd18bd-534f-4eec-84d7-487b41e467be/jobs/175225

PR Checklist

[x] I have tested my changes on iOS and Android.
[x] I hid my changes behind a [feature flag], or they don't need one.
[x] I have included screenshots or videos, or I have not changed the UI.
[x] I have added tests, or my changes don't require any.
[x] I added an [app state migration], or my changes do not require one.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added a changelog entry below, or my changes do not require one.

#nochangelog

Warnings

:warning:

✅ No changelog changes

  Generated by :no_entry_sign: dangerJS against e4caa0fb2438e1682c201cd690188aa3f80a6658


[stable/kube-slack] chart is completely broken

Describe the bugS

The chart has been subject to a lot of backward-incompatible changes with no warning at all, even though it is "stable". No major version bump, no message in the README, nothing.
The chart is not following helm/charts conventions (e.g. "envVars" instead of "env", no table summarizing configuration values).
The README is completely obsolete. It is still talking about variables that are not used anymore, like "--set slackUrl=webhook-url" which is now "--set envVars.SLACK_URL", and it's not talking about the other values that are required to install the chart (and yeah, that were not required in the previous version).
NOTES.txt is still using the previous variable, so it will print a warning message if your configuration is correct, but will not print it if you are using the old, incorrect configuration...
values.yaml has other problems too. Comments are incorrect: username and channel are inverted, and seem broken too: it says "override username to send" while the chart actually doesn't install if you don't specify it. But even if you specify it, the username doesn't seem to be overriden anyway.
Using --set envVars.NOT_READY_MIN_TIME doesn't work because """ConfigMap in version "v1" cannot be handled as a ConfigMap: v1.ConfigMap.Data: ReadString: expects " or n, but found 1""" (I tried with 150000 and "150000" but none of them works).
There are probably other bugs and incoherences, I didn't really dig very deep.

Version of Helm and Kubernetes:
Kubernetes 1.14.1, Helm 2.13.0
Which chart:
stable/kube-slack
What happened:
The chart is broken
What you expected to happen:
It should be easy to install the chart following instructions from README. Currently it's even worse since the README is not juste lacking informations but is also providing wrong informations.
How to reproduce it (as minimally and precisely as possible):
Try to install the chart.
Anything else we need to know:
This chart needs consequent maintenance, and should probably be downgraded to incubator if it can't be fixed quickly because it is currently a mess.

@Simon3 feel free to fix it 😘


feat: Allow customization of the number of stack lines

Proposed changes
Allow customization of the number of lines in the trace stack for the spec reporter to be used as follows :
 reporters: [specReporter({ stackLinesCount: 2 })],

This PR depends on this one: https://github.com/japa/errors-printer/pull/2
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Wooohoooo 🎉


Compiling with different versions of PyTorch

I have installed the pytroch 1.13.1 but I have  this error:
RuntimeError:
The detected CUDA version (11.8) mismatches the version that was used to compile
PyTorch (11.7). Please make sure to use the same CUDA versions.
what can I do?

Hey, Can you please tell me how to sovle this error, I've encountered this problem too , Thanks


Respect method parameter

Respect the method parameter that one can send to CAS as described here.
This PR won't quite work exactly the way it is since the SimpleWebApplicationServiceImpl constructor I want to use is private. There's probably a better way to do this than to use that constructor and make it public but this is a first attempt at what I'm trying to achieve.
How do we make this work properly?

It also looks like this PR breaks some other contracts due to the added ResponseType parameter on a few constructors.

Going to merge this tomorrow afternoon to start working on the changeset. Stay tuned please.


Unable to save the schema

Hi there,
Well, firstly I am just a newbie and trying to create the OLAP cube using the same Sakila example. I created the same cube and then I saved it clicking on the save button. Next, I tried to open it in the Saiku Analytics for creating a bar graph or something. But I was unable to find that cube in it. Then I refreshed the Phase window and my Sakila Schema disappeared from the saved schemas.
So the gist is that while I save any schema, it doesn't appear in the menu, and if I try to create the new schema with the same name, it says it already exists, but I cannot find it. Kindly help me locating the new schemas when they are created.

So here are the screenshots of the schema(cube) I created following the same steps as you have taught in the video:

Now after I saved the schema I tried to access it within the Saiku Analytics, but couldn't find it.

Next, I refreshed the Phase window with the green refresh button and the Sakila schema disappeared from the list.

Then I tried to create a new schema with the same name Sakila and it showed me the following error.

So, I don't understand if the schema was saved? And if it was, then where and how can I actually access it?
Here is the schema file of Sakila:
Sakila Schema FIle.txt
Here are the text version of log files:
localhost_access_log.2017-03-23.txt
Catalina_out.txt
localhost.2017-03-23_log.txt
pentaho_log.txt
catalina.2017-03-23_log.txt

Kindly help me to resolve the issue.

Hi, I have the exactly same issue. Did you manage to solve it? thanks in advance for any help.

No. I couldn't resolve it. If you find any solution elsewhere, kindly post it.


SJCL types

This introduces type definitions for SJCL.
The definition file has been copied from https://github.com/DefinitelyTyped/DefinitelyTyped/blob/b453d9d1b99c48c8711c31c2a64e9dffb6ce729d/types/sjcl/index.d.ts
Minor changes have been done to the copied code to fix lint errors as well as relaxing unnecessarily strict function definitions.

No we don't need to prepend anything. This simply makes us able to include the types for SJCL. SJCL is a javascript library. The definition makes us able to pull it into typescript world, and make typescript check if we are passing wrongly typed arguments and such. We used to just work with 'any' type for everything related to SJCL.
The next step (in a different pull request) will be to get rid of the wrapper types that Sune introduced, since they are only added to introduce some types around SJCL values. The wrappers have caused bugs more than once, since it is not always clear if we are working with fx. an SJCL point or a wrapper point.


Issue 188 - General algorithm error should not be used on system jobs

Changed job task to provide a default 'unknown' error when a system job fails instead of defaulting to 'algorithm-unknown' error for everything.

I made a quick doc change. Also, we want this to also cover pre and post tasks. You can either pass the 'unknown' default error in the pre and post task files, or just change the default to default_error_name='unknown' (my preference).

Never mind my previous comment. LGTM


[FLINK-32071] Implement the snapshot manager for merged checkpoint files in TM

What is the purpose of the change
As the first part of FLIP-306, which aims to provide an unified file merging mechanism for checkpoint files, this ticket/PR implements the basic file manager for merged files, providing file system directory layout and its initialization. It also provides the implementation of physical and logical files and the reference counting relationship between them.
Brief change log

Add definition of FileMergingSnapshotManager and a base implementation.
Add definition of PhysicalFile and LogicalFile.

Verifying this change
This change added an UT class called FileMergingSnapshotManagerTest.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Thanks for your comments @AlexYinHan , I have addressed your comments. 👍

Thanks @Hexiaoqiao for your detailed review. I have addressed your comments. It could be very nice if you could take another look.

Some additional feedback as discussed offline:

add a high-level layout overview of the directory with file merging enabled
add some descriptions about the policy of physical file reuse

@flinkbot run azure

Hi, @masteryhx . Thanks for you comments.

@flinkbot run azure

@Zakelly Thanks for the efforts! I've gone through another pass, LGTM.
A couple of things left:

squash the commits (address comments e.t.c)
run the bot again (the pipeline fails with the last commit)

I will merge the code once the light turns green.

@flinkbot run azure

Thanks @curcur for your detailed review. I re-run the pipeline and finally it got green. Please merge this if it is convenient for you. Thanks a lot.

Thanks @Zakelly !


Open handles with Jest configuration

I am trying to set up a typescript with jest configuration. However, as soon as i have switched to jest i am getting this error. My understanding is that i should clean something up. Do you have any idea what? Happens on pure JS as well.
Repository
https://github.com/S4n60w3n/cryptolette
Jest has detected the following 2 open handles potentially keeping Jest from exiting:

  ●  PROCESSWRAP

    > 1 | import { accounts, contract } from '@openzeppelin/test-environment';
        | ^
      2 | import { BN } from '@openzeppelin/test-helpers'
      3 |
      4 | const MyContract = contract.fromArtifact('Cryptolette');

      at Object.default_1 [as default] (node_modules/@openzeppelin/test-environment/src/setup-ganache.ts:35:20)
      at node_modules/@openzeppelin/test-environment/src/test-provider.ts:21:37
      at run (node_modules/p-queue/dist/index.js:157:104)
      at PQueue._tryToStartAnother (node_modules/p-queue/dist/index.js:105:17)
      at node_modules/p-queue/dist/index.js:171:18
      at PQueue.add (node_modules/p-queue/dist/index.js:152:16)
      at new TestProvider (node_modules/@openzeppelin/test-environment/src/test-provider.ts:19:16)
      at Object.<anonymous> (node_modules/@openzeppelin/test-environment/src/setup-provider.ts:6:18)
      at Object.<anonymous> (node_modules/@openzeppelin/test-environment/src/helpers.ts:6:1)
      at Object.<anonymous> (node_modules/@openzeppelin/test-environment/src/index.ts:1:1)
      at Object.<anonymous> (test/cryptolette.test.ts:1:1)
      at TestScheduler.scheduleTests (node_modules/@jest/core/build/TestScheduler.js:333:13)
      at runJest (node_modules/@jest/core/build/runJest.js:387:19)
      at _run10000 (node_modules/@jest/core/build/cli/index.js:408:7)
      at runCLI (node_modules/@jest/core/build/cli/index.js:261:3)

  ●  PIPEWRAP

    > 1 | import { accounts, contract } from '@openzeppelin/test-environment';
        | ^
      2 | import { BN } from '@openzeppelin/test-helpers'
      3 |
      4 | const MyContract = contract.fromArtifact('Cryptolette');

          at Array.reduce (<anonymous>)
      at Object.default_1 [as default] (node_modules/@openzeppelin/test-environment/src/setup-ganache.ts:35:20)
      at node_modules/@openzeppelin/test-environment/src/test-provider.ts:21:37
      at run (node_modules/p-queue/dist/index.js:157:104)
      at PQueue._tryToStartAnother (node_modules/p-queue/dist/index.js:105:17)
      at node_modules/p-queue/dist/index.js:171:18
      at PQueue.add (node_modules/p-queue/dist/index.js:152:16)
      at new TestProvider (node_modules/@openzeppelin/test-environment/src/test-provider.ts:19:16)
      at Object.<anonymous> (node_modules/@openzeppelin/test-environment/src/setup-provider.ts:6:18)
      at Object.<anonymous> (node_modules/@openzeppelin/test-environment/src/helpers.ts:6:1)
      at Object.<anonymous> (node_modules/@openzeppelin/test-environment/src/index.ts:1:1)
      at Object.<anonymous> (test/cryptolette.test.ts:1:1)
      at TestScheduler.scheduleTests (node_modules/@jest/core/build/TestScheduler.js:333:13)
      at runJest (node_modules/@jest/core/build/runJest.js:387:19)
      at _run10000 (node_modules/@jest/core/build/cli/index.js:408:7)
      at runCLI (node_modules/@jest/core/build/cli/index.js:261:3)

I'm having the same issue.  For local tests it is a superficial issue but in CI (GitHub Actions) it appears to be blocking my tests from completing.
There is something here to disconnect the server: https://github.com/OpenZeppelin/openzeppelin-test-environment/blob/08c0b342f6542d67fde71219a1ecb4c696f73652/src/ganache-server.ts#L33  I just can't figure out how to trigger it

For CI, I added --forceExit to make sure the tests complete.

I'm having the same issue

I'm having the same issue. Anyone has a solution?


Modify the max thread number according to CONFIG_MAX_THREAD_BYTES in gen_kobject_list.py.

if the created threads' number just equal to the number
set by the CONFIG_MAX_THREAD_BYTES, then each thread will
map a bit in _thread_idx_map array, the generated
_thread_idx_map will all be zero, it will be alocated to
bss section as a zero initialized object in zephyr.elf,
not the kobject_data section in zephyr_prebuilt.elf,
this will cause the address shift between
zephyr_prebuilt.elf and zephyr.elf, so we can't find the
correct thread using z_object_find function.
for example, if the CONFIG_MAX_THREAD_BYTES=4, and we creates 32 threads dynamically totally,
then in scripts/gen_kobject_list.py,  for each thread, it will map a bit index in thread_idx_map, then the generated array _thread_idx_map is [0x0, 0x0, 0x, 0x0].
so in the finally generate file kobject_hash.c , the thread_idx_map array is [0x0, 0x0, 0x0, 0x0],  it's allocated to bss section because it's a zero initialized object.
So i modify the gen_kobject_list.py to report this error in build process when the created threads'numer just equal  to the number set by the CONFIG_MAX_THREAD_BYTES,  it will warn that to increase the CONFIG_MAX_THREAD_BYTES(+1), then the generated _thread_idx_map will be [0x0, 0x0, ..., 0x0, 0xFF], it won't be allocated to bss section again, then build and run this test again, it will be good.
Signed-off-by: peng1 chen<EMAIL_ADDRESS>

The commit log has to updated to explain why the change can prevent the issue.

done.

see #21782


Check is string

how do you check a body parameter is actually string, rather than number or null or object?

use the 'typeof' operator, if it is not a string you can push an error on to the errors array (create one if it does not exist) which is on the context.
should look similar to this
if (typeof someValue !== 'string'){     context.errors = context.errors || []     context.errors.push({notString: Field must be a string!}) }

I see. I would have expected / hoped for something built in for this. But ok :)

+1 for isString() validator


check if playing on connect

if possible, get the current status (paused/playing) state when this originally starts
else, the daemon assumes its been playing since the socket was created, and it may have paused within the first 10 seconds

added in https://github.com/seanbreckenridge/mpv-history-daemon/commit/451afb4d841262cfe0aa1a6f81fd44ef110407f6


Can't load Mermaid dark theme unless the load is delayed

Current Behavior
As described in this issue on the theme collection repo, Mermaid's default theme doesn't play well with Node-RED dark themes.
I tried adding the following to a Node-RED dark theme to load Mermaid's dark theme. It didn't work.
mermaid.initialize({
    theme: 'dark',
});

If I add a "delay", the dark theme is loaded after that "delay". This kind of fixes the issue. But it feels weird having the wait to have Mermaid's dark theme loaded.
setTimeout(() => {
    mermaid.initialize({
        theme: 'dark',
    });
}, 5000);

Is there a way to load the theme without a delay?
Expected Behavior
No response
Steps To Reproduce
No response
Example flow
[{"id":"55d54d1c275c150f","type":"function","z":"bdd7be38.d3b55","name":"Test mermaid markdown","func":"\nreturn msg;","outputs":1,"timeout":0,"noerr":0,"initialize":"","finalize":"","libs":[],"x":810,"y":60,"wires":[[]],"info":"```mermaid\nstateDiagram-v2\nState_1 --> State_2: Transition 1\nState_2 --> State_3: Another transition\nState_3 --> State_1: Back to \\nthe start\n```"}]

Environment

Node-RED version: 3.1.0-beta.4
Node.js version: v18.17.1
npm version: 9.6.7
Platform/OS: macOS Ventura
Browser: Google Chrome

Maybe we could have something similar to what was introduced in #3084. A theme plugin can select a core theme or provide a custom theme for the Monaco Editor.

How can we load mermaid's dark theme after the changes in #4364?

Figuring out theming is on my list before 3.1.1 ships. The new approach in #4364 should make it easier to inject a custom theme... just need to settle on the details


removed rest call and pralgo ff

What's in this PR?
Why
Added feature flags
Affected issues
Jira Issues
How has this been tested?
Include how to test if applicable
Whats Next?

was resolved in a different branch


[Scenario] El Reloj

What kind of mission do you want to add (mark with an X, e.g. [X] Descent)?

[ x] Mansions of Madness
[ ] Descent

What expansions does the scenario require?

[x ] Conversion Kit (CK)
[x ] First Edition (MoM1E) - Also Recurring Nightmares
[ x] Fatal Alchemy (FA) - Also Suppressed Memories
[ x] Call of the Wild (CotW) - Also Suppressed Memories
[x ] Beyond the Threshold (BtT)
[ x] Streets of Arkham (SoA)
[x ] Sunctum of Twilight (SoT)
[x ] Horrific Journeys (HJ)
[x ] Path of the Serpent (PotS)

What expansions can the scenario optionally use?

[x ] Conversion Kit (CK)
[x ] First Edition (MoM1E) - Also Recurring Nightmares
[x ] Fatal Alchemy (FA) - Also Suppressed Memories
[x ] Call of the Wild (CotW) - Also Suppressed Memories
[x ] Beyond the Threshold (BtT)
[x ] Streets of Arkham (SoA)
[x ] Sunctum of Twilight (SoT)
[x ] Horrific Journeys (HJ)
[x ] Path of the Serpent (PotS)

Please enter the GitHub Url to your scenario here
https://github.com/Xavipalbu/ElReloj2/tree/main/ElReloj2

Added to Valkyrie manifest.
@antontimmermans , could you please add this one to the statistics?

Done


High Priority

@tiosgz Could you add a way to mark Issues as high priority? Ideally with a new custom column in projects.

Is it okay now?

Looks good, thanks.


Cooridnate change

Hi,
Firstly  I'd like to thank you for your contributions for this ROS package. Recently, I am using your package and another package called crazyflie_ros to do research on that. Right now I'm just get started with this. Since there is not much people working with crazyflie using your ROS package, so I'd like to just ask you for further information. The problem is, I heard about that, optitrack uses left coordinate while ROS uses right coordinate, to flip the axis. I had followed some instructions online to revise the rigid_bodies_publisher.py, while the outcome is not satisfying. It seems to make the simulation even worse. Here is the document I read about.() I myself is not familiar with Python, so I really have trouble to understanding all the code in the rigid_bodies_publisher, so I really hope you can help explain or give me some advice.
if rigid_body.tracking_valid and (rospy.get_time()-prevtime[body_id] >= tf_period):
  body_name = 'rigid_body_%d' % (body_id)
  if body_id in ids:
    idx = ids.index(body_id)
    body_name = names[idx]
  # pos2 = np.array([-pos_opt[1],pos_opt[0],pos_opt[2]])
  # rot2 = np.array([-rot_opt[1],rot_opt[0],rot_opt[2],rot_opt[3]])
  # pos2 = np.array([pose.position.x, pose.position.y, pose.position.z])
  # rot2 = np.array([pose.orientation.x, pose.orientation.y, pose.orientation.z, pose.orientation.w])
  # pos2 = np.array([-pose.position.y, pose.position.x, pose.position.z])
  # rot2 = np.array([-pose.orientation.y, pose.orientation.x, pose.orientation.z, pose.orientation.w])
  # tf_broadcaster.sendTransform(pos2, rot2, rospy.Time.now(), body_name, optitrack_frame)
  tf_broadcaster.sendTransform(pos_opt, rot_opt, rospy.Time.now(), body_name, optitrack_frame)
  prevtime[body_id] = rospy.get_time()

The code I am trying to revise is as above. Any help would be appreciate. Thanks.

The code above is not clear, so I post this picture.

@byronxubin what do you mean with left and right coordinates?

@fsuarez6 From what I have found, the output of the optitrack is left handed coordinate, while the ROS uses right handed coordinate. Sorry for not making it clear.

Can you share what you have found? (e.g. link)

https://www.dropbox.com/s/073w546dxrx2k0u/Optitrack%20to%20ROS%20frames.pdf?dl=0

Optitrack to ROS frames.pdf

I see. You just need to apply a rotation to the pose reported by optitrack.
From your pdf, it would be something like this:
Toffset = np.array( [0, 1, 0, 0],
                    [0, 0, 1, 0],
                    [1, 0, 0, 0],
                    [0, 0, 0, 1] )
Tros = np.dot(Toptitrack, Toffset)

I'm closing this issue because it's related to the way your reference system is defined.
You may want to read more about homogeneous transformations.


[Tests] named: Add direct test for export = assignment in TS

This pattern is valid typescript, but import/named can't find resolve the imports. Relevant issue: #1984
Here's a demo showing that it should work in TS
Test fails with
  1) TypeScript named [TypeScript] valid import { FooBar } from './typescript-export-assign-object':

      AssertionError [ERR_ASSERTION] [ERR_ASSERTION]: Should have no errors but had 1: [
  {
    ruleId: 'named [TypeScript]',
    severity: 1,
    message: "FooBar not found in './typescript-export-assign-object'",
    line: 1,
    column: 10,
    nodeType: 'Identifier',
    endLine: 1,
    endColumn: 16
  }
]
      + expected - actual

      -1
      +0

Reopened from #2428

I've rebased this, and looking over it, it's actually correct - export = syntax creates only a default export, at least when esModuleInterop is on (without which, TS's module system is broken anyways). You can't named-import from a module that uses that.


[cmake] Build swift-testing with CMake.

Add files needed to build swift-testing with CMake.
Motivation:
Being able to build with CMake is useful in many scenarios. The immediate need is to bring swift-testing to Windows. To do so we need to support a non-SPM path to allow building targets that would otherwise hit the export symbol limit on Windows.
Modifications:

Added CMake files to build Testing, TestingInternal, and TestingMacros.
Build TestingMacros as an ExternalProject targeting the build machine.
Add SwiftTesting_GenerateDerivedSources which generates a runner-swift-testing.swift and returns a variable that allows consumers to compile it with their sources.

Result:

Can build swift-testing with CMake.  Example command lines:

cmake -S . -B b -G Ninja -D CMAKE_CXX_COMPILER=clang
cmake --build .\b

Example diff that converts swift-webdriver to use swift-testing via CMake.

Checklist:

[X] Code and documentation should follow the style of the Style Guide.
[X] If public symbols are renamed or modified, DocC references should be updated.

So, somewhere in here (not sure where exactly), we need _SWT_TESTING_LIBRARY_VERSION defined as a C++ macro that resolves to a C string containing the library version. When building with SwiftPM, we get this from Context.gitInformation:
    // Capture the testing library's version as a C++ string constant.
    if let git = Context.gitInformation {
      let testingLibraryVersion = if let tag = git.currentTag {
        tag
      } else if git.hasUncommittedChanges {
        "\(git.currentCommit) (modified)"
      } else {
        git.currentCommit
      }
      result.append(.define("_SWT_TESTING_LIBRARY_VERSION", to: #""\#(testingLibraryVersion)""#))
    }

I don't know what's possible with CMake here, but it would be ideal if we could define the equivalent when building with CMake.

Thank you @jeffdav! Appreciate the helpful contribution. I have several comments so far and will take a second pass tomorrow

Open question: how do we test this change?

No problem.  I wasn't sure what the right thing to do was.  I'd honestly prefer incremental diffs. :)

Oh, but github does have a little "compare" link next to each force-push, which I hadn't realized.

Something else for you to consider: we should have instructions somewhere (perhaps in a dedicated .md file in Documentation/) showing how to build swift-testing from source using CMake.

Something else for you to consider: we should have instructions somewhere (perhaps in a dedicated .md file in Documentation/) showing how to build swift-testing from source using CMake.

Added.  I'd love feedback on the documentation (consider this a 1st draft).

@swift-ci please test

@grynspan any further concerns on your side?

Nope, I defer to @etcwilde here.
(FYI we don't use Swift's C++ interop feature, so its lack of support for exceptions doesn't make a difference to us. However, we also don't throw any exceptions or intend to catch any, so it's moot.)

Oh—please update the file lists before merging. There are a number of new files added since you opened this PR.

Oh—please update the file lists before merging. There are a number of new files added since you opened this PR.

Done!

@swift-ci please test

@jeffdav I know you folks obviously work with Windows. The Windows failure we're seeing is a compiler bug unrelated to your PR. If you're comfortable with merging the PR despite the failure, we can proceed. (I'm unsure if you can see a merge button—if not, ping me and I'll do it.)

@jeffdav I know you folks obviously work with Windows. The Windows failure we're seeing is a compiler bug unrelated to your PR. If you're comfortable with merging the PR despite the failure, we can proceed. (I'm unsure if you can see a merge button—if not, ping me and I'll do it.)

Yeah, I'm familiar with that compiler bug for other reasons.  :)

@grynspan Thanks for your help! I don't have a merge button.

@swift-ci please test


Removed all spaces in folder and file names; does this still need the "install" field?

The install_to field? Aye, it does. :)
Also, I love your work. :)  These changes apply to the newest release of Orbital Science, I presume?

Yes, the 0.9.2 update

Awesome! This inflates fine for me, and the resulting metadata sings joyful strains and upgrades without issue. Merging with great thanks! :)


add cannon convexHull to object,There is a facnormals error

Issue title
Description
.faceNormals[1070] = Vec3(-0.038581869473242894,-0.9992554424910327,0) looks like it points into the shape? The vertices follow. Make sure they are ordered CCW around the normal, using the right hand rule.
Version

Platform

Web Version [X]
Windows [X]
Linux [X]

Hi
Thanks a lot for reporting currently im using external code to create the convex hull.
I migth try and come up with an alternative solution someday, thanks a lot for reporting.
Cumps

Well for a convex hull all normals should be poiting outside, but there are some cases where is usefull for the normal to point inwards. I will have to be checking it.
Thanks a lot.

Thank you. I hope it can be solved soon. I'm looking forward to it


Should blockquotes include a closing double quotation mark?

I find it odd that blockquotes only have the beginning double quote on rendered pages. Is this by design? I thought at first it was a problem with my formatting until I noticed this on other sites as well.

Yes this is by design. 🙂  Check out the quote line indicator option in Preferences > Style for an alternative quote presentation.


Fcrepo 1556

https://jira.duraspace.org/browse/FCREPO-1556

Resolved with: https://github.com/fcrepo4-labs/fcrepo-camel-toolbox/commit/eb8b054516f6b00d8884a9eaa68a5271c4e888fc


IGNITE-1018

Node local map is not available when LifecycleEventType.BEFORE_NODE_START is processed in lifecycle bean

https://issues.apache.org/jira/browse/IGNITE-1018 is closed, closing the PR


typescript errors between<EMAIL_ADDRESS>and<EMAIL_ADDRESS>

I have a app in which i use<EMAIL_ADDRESS>and wanted to implement @googlemaps/jest-mocks (current version: 2.21.4). Tests seem to work well, however when i run build it fails with following error:
node_modules/@googlemaps/jest-mocks/dist/maps/maps/map.d.ts(20,22): error TS2720: Class 'Map_' incorrectly implements class 'Map'. Did you mean to extend 'Map' and inherit its members as a subclass?
--
  | 2157 | 03:42:52 PM | Type 'Map_' is missing the following properties from type 'Map': getHeadingInteractionEnabled, getTiltInteractionEnabled, setHeadingInteractionEnabled, setRenderingType, setTiltInteractionEnabled
  | 2158 | 03:42:52 PM | node_modules/@googlemaps/jest-mocks/dist/drawing/polygons/rectangle.d.ts(25,5): error TS2416: Property 'getMap' in type 'Rectangle' is not assignable to the same property in base type 'Rectangle'.
  | 2159 | 03:42:52 PM | Type 'Mock<Map_, [], any>' is not assignable to type '() => Map \| null'.
more_vert | 2160 | 03:42:52 PM | Type 'Map_' is missing the following properties from type 'Map': getHeadingInteractionEnabled, getTiltInteractionEnabled, setHeadingInteractionEnabled, setRenderingType, setTiltInteractionEnabled
  | 2161 | 03:42:57 PM | node_modules/@googlemaps/jest-mocks/dist/maps/maps/map.d.ts(20,22): error TS2720: Class 'Map_' incorrectly implements class 'Map'. Did you mean to extend 'Map' and inherit its members as a subclass?
  | 2162 | 03:42:57 PM | Type 'Map_' is missing the following properties from type 'Map': getHeadingInteractionEnabled, getTiltInteractionEnabled, setHeadingInteractionEnabled, setRenderingType, setTiltInteractionEnabled
  | 2163 | 03:42:57 PM | node_modules/@googlemaps/jest-mocks/dist/drawing/polygons/rectangle.d.ts(25,5): error TS2416: Property 'getMap' in type 'Rectangle' is not assignable to the same property in base type 'Rectangle'.
  | 2164 | 03:42:57 PM | Type 'Mock<Map_, [], any>' is not assignable to type '() => Map \| null'.
  | 2165 | 03:42:57 PM | Type 'Map_' is missing the following properties from type 'Map': getHeadingInteractionEnabled, getTiltInteractionEnabled, setHeadingInteractionEnabled, setRenderingType, setTiltInteractionEnabled

There's going to be an update to the jest-mocks to add support for the latest additions in the maps-api.
Would it be an option for you to use an older version of the @types/google.maps package (I think 3.55.7 should work) until this is updated?

i tried with various older and newer versions and it still throws similar errors. For when is the library update planned?


Make this block responsive if someone changes the value of user_started_case

https://github.com/SuffolkLITLab/docassemble-AssemblyLine/blob/4a9fa91d4a434392de92bd6e3330d16b691e9417/docassemble/AssemblyLine/data/questions/ql_baseline.yml#L131

---
depends on:
  - user_started_case
code: |
  if user_started_case:
    plaintiffs = users
    petitioners = users
    defendants = other_parties
    respondents = other_parties
  else:
    defendants = users
    respondents = users
    plaintiffs = other_parties
    petitioners = other_parties

Is one place to start. May also need to add depends on in a few other blocks

https://github.com/jhpyle/docassemble/releases/tag/v1.2.83 is supposed to contain a fix that addresses this, but it doesn't seem to work yet


Populate the release_phase response to ruletype related APIs

Summary
The following PR takes into account the release_phase request and response to ruletype related APIs:

create
apply
get
list

Fixes #4245
Fixes #4246
Change Type
Mark the type of change your PR introduces:

[ ] Bug fix (resolves an issue without affecting existing features)
[x] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 53.881% (+0.01%) from 53.87%
when pulling cd8f746efc40e246b19c97e78de9d8b9200e8e68 on add-release-to-api
into 9f27d61d8971a6dc4451e45cf409ba5d05c142c2 on main.


Aftab ansari/azure continuous deployment patch

Old images are replace with new images.
These images were captured when ASP.Net core used to be called ASP.Net 5 and it was in Beta or RC.
@Rick-Anderson Please review the changes.

@aftab10662,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@AftabAnsari10662  wow, great work,  thanks!