Issues with odd input data?

I have to dump out the data I'm feeding pymbar to see what is causing these issues, but I'm getting some odd output from pymbar3:
/Users/choderaj/anaconda/lib/python2.7/site-packages/pymbar-3.0.0.dev0-py2.7-macosx-10.5-x86_64.egg/pymbar/utils.py:70: FutureWarning: comparison to `None` will result in an elementwise object comparison in the future.
  if N_k == None:
/Users/choderaj/anaconda/lib/python2.7/site-packages/scipy/optimize/minpack.py:237: RuntimeWarning: The iteration is not making good progress, as measured by the
  improvement from the last ten iterations.
  warnings.warn(msg, RuntimeWarning)
/Users/choderaj/anaconda/lib/python2.7/site-packages/pymbar-3.0.0.dev0-py2.7-macosx-10.5-x86_64.egg/pymbar/mbar.py:240: FutureWarning: comparison to `None` will result in an elementwise object comparison in the future.
  if initial_f_k != None:
/Users/choderaj/anaconda/lib/python2.7/site-packages/scipy/optimize/minpack.py:237: RuntimeWarning: xtol=0.000000 is too small, no further improvement in the approximate
  solution is possible.
  warnings.warn(msg, RuntimeWarning)

I get these warnings too with some of my data.
The runtime warnings appear to originate from the scipy.optimize.root call on line 321 of mbar_solvers.py when the method = 'hybr'. Which runtime warning is thrown seems to be a function of the number of samples, whether or not the initial_f_kis zeros or the user feeds in the final f_k as the initial_f_k saved from a previous run, and lastly how much sub-sampling is used. However, I can't find any pattern to determine which one is generated.
The warnings each indicate that the function may not be converging, however, the final answer may not be wrong if scipy.optimize.minimize converges first from the sub-sampling hot-start.

Let's definitely add some tests where multiple schemes are compared to ensure the same answer is obtained, or an analytical system is used to induce these errors.
Is there any way we can avoid these warnings?

It looks like we can filter out warnings with the warnings module based on this stackoverflow question
import warnings
warnings.filterwarnings('ignore', 'The iteration is not making good progress')
warnings.filterwarnings('ignore', 'xtol=0.000000')

However I don't think that's a good idea since it will filter all warnings matching that string and we may miss current and future errors.

an analytical system is used to induce these errors.

I can get the harmonic oscillators to generate both runtime warnings. The xtol=... warning on an initial generation of an MBAR object, and the not making good progress... warning when I use initial_f_k=mbar.f_k from the initially generated MBAR object and the same data.
In some of my data where the free energy differences are +-200 kcal/mol, skipping the scipy.optimize.minimize call causes numerical errors, but I think that separate from what you're suggesting here.

Can you add some tests where the harmonic oscillators generate these
warnings?  It will be much easier to debug this way.

The test I wrote in #202 should generate at least one of the errors. Doing some more runs, it looks like both errors are not always generated, based on the oscillators that are generated. Is it worth having a separate test which is guaranteed to generate both errors?

#202 tries to trap the warnings, but I'm still not sure why there are two separate warnings or know of any direct way to generate a specific one. Do we want to call the PR good enough, or leave this issue open until we can figure out how to specifically generate each warning?


Drop Support of library build with Scala version 2.12

In order to reduce time for the release process and get rid of obsolete code related to Scala 2.12.
Please share your feedback if build for Scala 2.12 is still needed.
If no meaningful reasons shared to keep Scala 2.12, then it will be dropped in one month from now.

to be done in the next release.

Hi @novakov-alexey,
There is a very good reason to keep Scala 2.12: to ease smooth transition between flink-streaming-scala stuck in 2.12.7 and flink-streaming-java + flink-scala-api, we have chosen to take one step with Scala 2.12.20.
It's already a big migration for us, having to upgrade to Scala 2.13 at the same time would make the migration even harder.
I suggest to keep the Scala 2.12 compatibility for Flink 1.x and remove it for Flink 2.x.
Thanks

Hi @novakov-alexey,
There is a very good reason to keep Scala 2.12: to ease smooth transition between flink-streaming-scala stuck in 2.12.7 and flink-streaming-java + flink-scala-api, we have chosen to take one step with Scala 2.12.20.
It's already a big migration for us, having to upgrade to Scala 2.13 at the same time would make the migration even harder.
I suggest to keep the Scala 2.12 support for Flink 1.x and remove it for Flink 2.x.
Thanks

Hi @arnaud-daroussin ,
Thank you for your message.
I recommend you to transition to 2.13 in the same step as well. The 2.12 is very old version of Scala, which does not makes sense to continue with it anymore.
Maybe you could try and report back whether upgrade to 2.13 brings any issue for you?
We could keep this issue on hold for one more month.

Hi @gaelrenoux-datadome
Thank you for your input.
I actually thought to continue to use version 1.x even if Scala 2.12 is dropped. When we say Scala 2.12 is dropped, we mean that this project won't longer publish flink-scala-api_2.12 JAR file to the Maven central. However, public API will be still the same. As a library user you won't need to adjust your code much, perhaps only those things you mentioned about Scala collections. However, you do not use much Scala collections in Flink general. What for?
I am afraid that maintaining two major versions in parallel:
1.x with Scala 2.12
2.x with Scala 2.13, Scala 3
would create even more work for me. So far I am pretty much alone who maintains this library.
So far what I am hearing from you: it is kind of more work to do when switching to Scala 2.13, then staying on it. That means, if you are already using this library with Scala 2.12, then you do not need to anything to receive new updates of this library, but if you loose support of Scala 2.12 build, then you have to first migrate to 2.13. I am still tryng to understand what are the main blockers to migrate for you from ancient old Scala 2.12 to at least to 2.13. I am not even saying to Scala 3.x.
As for me, migration of your Flink jobs from Scala 2.12 to Scala 2.13 should be easy. I need more arguments. If I won't hear convincing arguments I will drop Scala 2.12 within next month or so.

Sorry, I wasn't clear: I'm completely fine with the 1.X (or 1.2.X) receiving no more updates at all. I just think that it's worth it to keep in the documentation a line saying "Scala 2.12 is only supported up to version 1.2.0". That way, users have the information they need to migrate that way if they need to. Your proposed PR completely removes all traces of Scala 2.12 in the README.
As far the Scala 2.12 => 2.13 migration: we have a few internal utilites, adding basic functions like doubly mapping (over a collection of collections) or zipping with the result of a function. All of that typically applies to Traversable (which doesn't exist anymore in 2.13), and uses CanBuildFrom to get the output collection type be the same as the input one. Is it hard to migrate ? Not really, it's one or two hours at most. However, it's still a bunch of classes to change, that will have to end up in the same PR as the Flink API migration (or the PR won't compile). That results in a big PR that concerns itself with completely different topics, so it's not straightforward to review.
Is it a dealbreaker? No. We would have managed just fine, or we would have looked in the project history to figure out if there's a version that we can use while staying in Scala 2.12. It's just that our use case doesn't seem that rare, since anyone migrating from the base Flink Scala API to your library would be in Scala 2.12, and the cost of keeping a line in the README seems pretty low to me. But then, I'm not the one maintaining this library, and we'll still use it no matter what :-)

Thanks for explanation, I appreciate it. This helps indeed.
Adding a note to documentation about release version which could be used with Scala 2.12 is fine to me.


undefined method `test_spec'

Hi.  I'm having this problem with the test_spec identifier when I try to update my pods and I don't know if it's me or the SQLite.swift source.  My Podfile (very simple) is below.
> pod update
Update all pods
Updating local specs repositories
  $ /usr/bin/git -C /Users/TonyAngelo/.cocoapods/repos/master fetch origin --progress
  remote: Counting objects: 9, done.
  remote: Compressing objects: 100% (9/9), done.
  remote: Total 9 (delta 6), reused 0 (delta 0), pack-reused 0
  From https://github.com/CocoaPods/Specs
     c32535dd576..75b8269127b  master     -> origin/master
  $ /usr/bin/git -C /Users/TonyAngelo/.cocoapods/repos/master rev-parse --abbrev-ref HEAD
  master
  $ /usr/bin/git -C /Users/TonyAngelo/.cocoapods/repos/master reset --hard origin/master
  HEAD is now at 75b8269127b [Add] StyledOverlay 2.1.5

CocoaPods 1.4.0.beta.1 is available.
To update use: `sudo gem install cocoapods --pre`
[!] This is a test version we'd love you to try.

For more information, see https://blog.cocoapods.org and the CHANGELOG for this version at https://github.com/CocoaPods/CocoaPods/releases/tag/1.4.0.beta.1

Analyzing dependencies
Pre-downloading: `SQLite.swift` from `https://github.com/stephencelis/SQLite.swift.git`
**[!] Failed to load 'SQLite.swift' podspec:
[!] Invalid `SQLite.swift.podspec` file: undefined method `test_spec' for #<Pod::Specification name="SQLite.swift/standard">.**

 #  from /var/folders/hf/417swqmn5j9_sx6y1z3ssnm80000gn/T/d20171008-1081-ise1ub/SQLite.swift.podspec:33
 #  -------------------------------------------
 #
 >      ss.test_spec 'tests' do |test_spec|
 #        test_spec.resources = 'Tests/SQLiteTests/fixtures/*'
 #  -------------------------------------------

===============================

Here's my Podfile:
> cat Podfile
use_frameworks!

platform :ios, '10.0'

target 'STOMechanics' do
	pod 'SQLite.swift', :git => 'https://github.com/stephencelis/SQLite.swift.git'
end

target 'STOMechanicsTests' do
	pod 'SQLite.swift', :git => 'https://github.com/stephencelis/SQLite.swift.git'
end

you'll need cocoapods v1.4.0. i'll update the docs.

That solved my problem.  Thank you!


Request to remove S2I reconcilers from ks-devops

As we all know, KubeSphere provides Source-to-Image (S2I) and Binary-to-Image (B2I) features to automate image building and pushing and application deployment. See here for more.
But we already have an S2I operator to take charge of this feature. Of course, I have tested it by disabling DevOps Controller, all functions of S2I and B2I work as normal.
Due to coupling with S2I, we can not remove S2I components now completely, such as S2I types and handlers. However, we could remove S2I reconcilers first or disable them by default.
/kind cleanup

Hi @JohnNiang , I found that we can disable S2I component in this file:
https://github.com/kubesphere/ks-devops/blob/d54a80ebd16c0df7b4698869babb17e41fec681e/cmd/controller/app/options/feature.go#L36-L37
But not found something about S2I reconcilers and somewhere to call:
https://github.com/kubesphere/ks-devops/blob/d54a80ebd16c0df7b4698869babb17e41fec681e/cmd/controller/app/controllers.go#L165-L177
Please correct me If I misunderstand, thanks.

Hi @mangoGoForward , thank you for inspecting this issue. I have tried to remove the s2i components from ks-devops, but it's not easy to remove it completely. Please see https://github.com/kubesphere/ks-devops/blob/master/pkg/models/devops/s2ibinary_handler.go.
First thing we need to do is that expose APIs in s2ioperator project, just like https://github.com/kubesphere/api. Then, we can refer the APIs into ks-devops and remove all s2i components but that s2ibinary handler.

I agree with you that disabling s2i components is a good step.


Unable to run the enforcer via command line

Not sure if I am missing this in the document but is there a way to run the enforcer via command line?
This is what we had to do:
const Enforcer = require('openapi-enforcer')
// JSON and YAML files accepted
Enforcer('/api.beta.yaml', { fullResult: true })
    .then(function ({ error, warning }) {
        if (!error) {
            console.log('No errors with your document')
            if (warning) console.warn(warning)
        } else {
            console.error(error)
        }
    })

To run this from a command line.  However, it will have been nice to just issue a one liner to get this running as well.

There is a CLI. although it's not as fleshed out as I'd like it to be, it does work.
https://www.npmjs.com/package/openapi-enforcer-cli
Let me know if it doesn't do what you're looking for.

Thanks again for the quick response.

The output of validating a document with the tool vs the above script is that it's much more terse and losing a lot of information. We'd like to have the same level of verbosity as validating with fullResult: true via the shell.

I think that is an option with the cli.

Install the CLI:  npm install -g openapi-enforcer-cli
Run the command: openapi-enforcer validate api.beta.yaml

If that doesn't do the trick, let me know.

Right, I ran it before, but it wasn't giving us all the information compared to running the above script (where it pulls the latest openapi-enforcer). Looking at package.lock of openapi-enforcer-cli, it uses 1.10.0 of openapi-enforcer, so it might be out of date. Maybe we could close this issue and open a new one in the other repo?

That might be the problem. I've updated the dependencies and removed the lock file which should allow the dependencies to update independent of the CLI.
I've published it to NPM as version 0.3.1. Try it out and let me know if that worked.

Still having the same issue where we are getting less warnings with the cli than my script.
output from the cli:

Cannot read property 'hasOwnProperty' of null

whereas the output of my script returns 179 lines of errors, and they are legitimate, for example, one snippet of a warning looks like:
      at: /verified-from-addresses/{id} > delete > responses > 204
        A 204 response must not contain a body (https://tools.ietf.org/html/rfc7231#section-6.3.5) but this response has a defined content. [WRES003]
      at: /sod-policies > post > responses > 201
        A 201 response for a POST request should return a location header (https://tools.ietf.org/html/rfc7231#section-4.3.3) and this is not documented in your OpenAPI document. [WRES001] ]

And it might not be a great idea to remove a package-lock.json on an executable which end users use, since future updated dependencies may break the cli, but that's just my opinion.

You might be right about disabling the package lock. I've never tried doing that before, but it could allow people to update the version of the enforcer without updates to the CLI as well. Going to have to consider that one a little bit more.
I'm going to take a closer look at the CLI validator. I thought the code is very similar to what you had posted, but I'll do a more thorough comparison.

This one has me a bit stumped so here is what I've done:

I rewrote the validate code to look more like what you've provided.
I added to the version command openapi-enforcer version that it will also output the version of the enforcer that it's using.
I re-enabled the package log.
I published this to NPM as version 0.3.2.

Here is the validator code:
'use strict'
const Enforcer = require('openapi-enforcer')
const path = require('path')

module.exports = function (program) {
  program
    .command('validate <oas-doc>')
    .description('Validate an Open API Specification document')
    .option('-c, --clean-exit', 'If the OpenAPI document is not valid, do not throw an exception.')
    .action((oasDoc, command) => {
      const fullPath = path.resolve(process.cwd(), oasDoc)
      Enforcer(fullPath, { fullResult: true })
        .then(({ error, warning }) => {
          if (!error) {
            console.log('Document is valid')
            if (warning) console.warn(warning)
          } else {
            console.error(error)
          }

          if (!command.cleanExit && error) process.exit(1)
        })
        .catch(err => {
          console.log(err.message)
          if (!command.cleanExit) process.exit(1)
        })
    })
}

Let me know if it works. If it doesn't maybe share the YAML file that you're using with me and I'll do some deep code debugging.

Getting the same output from the cli before, now with the first newline removed. We'll ask the right channels to figure out if we are able to share the API spec before we do so.

Good news. I've identified the problem as to why you're seeing the Cannot read property 'hasOwnProperty' of null message in the CLI.  I've already identified the fix and will work on getting this published soon.

OK. Try out the latest version of the openapi-enforcer-cli, version 0.3.3.

looks like we caught some real errors in our docs (thanks you!). We'll come back once we fix those and see if we are still having issues with the warnings not being displayed.

Sounds great. Thanks for your help working through this error. You've made this library better still than it was.
I'll close this ticket for now. If we need to we can create a new one or re-open later.

@Gi60s thanks for being over so prompt in responding to issues.  Certainly appreciate your efforts on this great library.


Azure CDN "standard" endpoint rules set response header length only 100 chars?

Context
I'm trying to set up a Single-Page App, stored in  Azure Storage (blob) and fronted by Azure CDN.
The problem is with setting top-level (document) HTTP response headers.
There's a limit of 100 characters for "modify response header: overwrite" value.
I suppose it's normal that SPA security requires a comprehensive Content-Security-Policy.
I think I've trimmed by CSP header field to the minimum possible:
default-src 'self'; script-src 'unsafe-inline' 'self'; style-src 'unsafe-inline' 'self'; img-src data: 'self';

default-src is the general safe default
script-src needs a change, because Create-React-App / webpack inlune bootstrap Javascript into index.html
style-src needs a change, because I use styled-components
img-src needs a change because small assets are packed as data URIs

The documentation does not mention the limit on the header value length.
I wish I knew this in advance!
Although, ultimately, I think this limit is way too low; it's nowhere near what a modern web site needs.
pro forma

[x] The relevant Azure service or technology.
[x] A link to the published documentation article: https://docs.microsoft.com/en-us/azure/cdn/cdn-standard-rules-engine-reference
[x] Clear, specific feedback that the author can act on.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a2dc930c-33a3-d54e-2253-1b1b5a693c17
Version Independent ID: 7dc5aee5-f473-10c8-5299-d5d0b52b7077
Content: Standard rules engine reference for Azure CDN
Content Source: articles/cdn/cdn-standard-rules-engine-reference.md
Service: azure-cdn
GitHub Login: @asudbring
Microsoft Alias: allensu

@dimaqq Thanks for the feedback! If you would like us to increase the response header length for a SKU, please leave your feedback at azure networking's feedback.azure.com page.
To update the doc, I have assigned the issue to the content author to evaluate and update as appropriate.

@dimaqq even we are having similar setup but , failing to add security headers. Have you figured that out? And how is it working for you? We are using standard CDN of Azure
https://i.stack.imgur.com/yi8my.png

@jayforu looks like the suggested way to affect the 100 char limit is to submit feedback to azure :(

#please-close

Don't you just love it how azure and github belong to the same company, yet users are pushed to report issues to a custom forum, which is neither globally searchable nor always works (I did try to post this, but alas), while there's a nice, accessible, public space right here! 😠

@dimaqq @jayforu while having the same problem, I found a workaround that will do the work.
In my case I had to have this header: content-security-policy: default-src 'self'; script-src 'self' 'unsafe-eval'; style-src 'self' 'unsafe-inline' https://fonts.googleapis.com; font-src 'self' https://fonts.gstatic.com; and it is just a little bit longer than 100 characters...
So I created 3 different rules:

Modify response header -> Overwrite -> Content-Security-Policy -> default-src 'self'; script-src 'self' 'unsafe-eval';

@dimaqq @jayforu while having the same problem, I found a workaround that will do the work.
In my case I had to have this header: content-security-policy: default-src 'self'; script-src 'self' 'unsafe-eval'; style-src 'self' 'unsafe-inline' https://fonts.googleapis.com; font-src 'self' https://fonts.gstatic.com; and it is just a little bit longer than 100 characters...
So I created 3 different rules:

Modify response header -> Overwrite -> Content-Security-Policy -> default-src 'self'; script-src 'self' 'unsafe-eval';
Modify response header -> Append -> Content-Security-Policy -> style-src 'self' 'unsafe-inline' https://fonts.googleapis.com;
Modify response header -> Append -> Content-Security-Policy -> font-src 'self' https://fonts.gstatic.com;

And that's it. It works.
Please note 2 things:

the order of the rules (!!)
you can't have more than 1 action per rule that modifies the same header (so 3 different rules in my case).

Thank you, I will try it out
On Fri, Jul 31, 2020, 13:11 NDalvise<EMAIL_ADDRESS>wrote:

@dimaqq https://github.com/dimaqq @jayforu https://github.com/jayforu
while having the same problem, I found a workaround that will do the work.
In my case I had to have this header: content-security-policy:
default-src 'self'; script-src 'self' 'unsafe-eval'; style-src 'self'
'unsafe-inline' https://fonts.googleapis.com; font-src 'self'
https://fonts.gstatic.com; and it is just a little bit longer than 100
characters...
So I created 3 different rules:

Modify response header -> Overwrite -> Content-Security-Policy ->
default-src 'self'; script-src 'self' 'unsafe-eval';
Modify response header -> Append -> Content-Security-Policy ->
style-src 'self' 'unsafe-inline' https://fonts.googleapis.com;
Modify response header -> Append -> Content-Security-Policy ->
font-src 'self' https://fonts.gstatic.com;

And that's it. It works.
Please note 2 things:

the order of the rules (!!)
you can't have more than 1 action per rule that modifies the same
header (so 3 different rules in my case).

[image: image]
https://user-images.githubusercontent.com/29203499/89011999-aedf5c80-d311-11ea-8899-aa386c71c516.png
[image: image]
https://user-images.githubusercontent.com/29203499/89012111-e221eb80-d311-11ea-93f0-82d48a984e1c.png
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/azure-docs/issues/54628#issuecomment-666982942,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC5HFWQ77TFKBQF4H4UY4KLR6JYRXANCNFSM4M6PIAJQ
.


Problems about Organ Segmentation Overlapping

Hi,
First of all, thank you for making this amazing dataset publicly available! I am currently working on automatic multi-organ segmentation at EPFL CVLab. We train our model based on your dataset. However, we have noticed several instances where organ segmentations overlap with each other.
For example,

In s0046, heart_atrium_right and inferior_vena_cava are overlapped as following:

The red organ is heart_atrium_right and the green one is inferior_vena_cava. When creating the segmentation mask, we consider that it is necessary to keep the integrity of the heart_atrium_right. Therefore, we manually assign the overlapping portion to the red section and remove it from the segmentation of the inferior_vena_cava. However, this manual handling of overlapping situations is complicated and time-consuming. Do you have any suggestions for dealing with such cases? Is there a more efficient way to handle overlapping organs and create accurate segmentation masks?
About the segmentation noise
Regarding segmentation noise, we have noticed some label inaccuracies in the dataset. In s0011, vertebrae_T5 and vertebrae_T6 are overlapped as following:

However, these two vertebrae should have minimal cross-sectional overlap physiologically (although I'm not entirely certain about this). This suggests inaccuracies in the segmentations in the dataset.
Furthermore, in s01342, aorta and iliac_artery_left are overlapped as following:

The aorta is outlined with a red circle. We have noticed that this organ occupies very few voxels in the 3D image. Moreover, there are numerous other organ segmentations that contain only a few voxels in the images. Consequently, it is challenging to determine whether these are label inaccuracies introduced during the training process with nn-Unet, or if they represent true organ segmentations.
Do you have any insights into these two situations? Are both of these issues a result of labeling inaccuracies during the training process with nn-Unet?

Thank you in advance for your response.
Best,
Ruihang Jiang

Hi,
thanks for your questions. There is indeed some overlap and some inaccuracies. However, since this is rather minor accross the entire dataset the resulting model is still working very well.
We use the following code to combine the masks. We just add one by one and the later one overwrite the earlier one in case of overlapping:
https://github.com/wasserth/TotalSegmentator/blob/master/totalsegmentator/libs.py#L214

Get it! Thank you for the reply.


Keep attachments on tasklist update of issue and comment content

Previous PR about "Keep attachments on tasklist update": https://github.com/go-gitea/gitea/pull/16750 is incomplete. Related issue: https://github.com/go-gitea/gitea/issues/16746
The PR #16750 only patches the update of comment, but not the update of the issue, which make the bug still exist.
And I think the new logic is more clear, we should not just return when ignore_attachments=true, which will bypass all remaining logic, may lead to problem in the future.

Oh, I pushed the same just moments ago #16763

Codecov Report

Merging #16762 (8bf57be) into main (0bd58d6) will decrease coverage by 0.03%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##             main   #16762      +/-   ##
==========================================
- Coverage   45.38%   45.35%   -0.04%
==========================================
  Files         760      760
  Lines       85495    85495
==========================================
- Hits        38803    38774      -29
- Misses      40410    40436      +26
- Partials     6282     6285       +3

Impacted Files
Coverage Δ

routers/web/repo/issue.go
38.34% <12.50%> (+0.05%)
:arrow_up:

models/repo_mirror.go
58.69% <0.00%> (-10.87%)
:arrow_down:

services/mirror/mirror.go
9.61% <0.00%> (-7.70%)
:arrow_down:

models/gpg_key_common.go
59.67% <0.00%> (-4.84%)
:arrow_down:

modules/avatar/avatar.go
47.72% <0.00%> (-4.55%)
:arrow_down:

modules/cron/tasks_basic.go
85.43% <0.00%> (-2.92%)
:arrow_down:

modules/queue/manager.go
65.34% <0.00%> (-2.85%)
:arrow_down:

models/unit.go
41.09% <0.00%> (-2.74%)
:arrow_down:

modules/log/event.go
60.64% <0.00%> (-1.86%)
:arrow_down:

modules/queue/unique_queue_disk_channel.go
47.26% <0.00%> (-1.37%)
:arrow_down:

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bd58d6...8bf57be. Read the comment docs.


Show HTTP Headers?

I have a site that is behaving differently when I interact with in in a traditional browser versus spooky/casper/phantom.  I would like to debug by printing out the entire http header requests and responses to the console or a file to see what is different between my browser and the phantom browser (similar to how I would using developer tools on the browser).  How can I get all http request / response including headers in a spooky event handler?

Your then handlers have access to the CasperJS instance as this. See the Casper and Phantom docs.


Optimize header access

There are a lot of attempts to directly set header values already, this unifies all Get/Set/Add/Del accesses to assume a canonical form already.
In my personal testings, this actually stands out in our hot paths in flame graphs doing header Get/Sets. Within this codebase, we already have constants in place already in the correct formats.
I've dug so deeply into this in the past that I created https://github.com/mattrobenolt/go-httpheaders which specifically highlights benchmarks of direct access vs using the Get/Set helpers.
Since these are called multiple times in very hot paths, it's a worthwhile optimization since we can trust the inputs.
Before submitting your PR: Please read through the contribution guide at https://github.com/bufbuild/connect-go/blob/main/.github/CONTRIBUTING.md

Perfect, those comments were more for yall while reviewing anyways, since I wasn't entirely sure if my assumption was true or not.


Not working in Private Browsing mode

Hello, thanks for your work on this add-on.  It's working fine for me in regular windows but doesn't seem to do anything in Private Browsing windows: I still see the tab bar and location field.
Firefox 48.0
OSX 10.11.6
Fullscreen+ 1.0.1

Thanks for reporting this. Add-ons are disabled for private windows by default to prevent privacy issues and I didn't change that behavior.
I'll have a look into it. Probably it's only a small change.

I've published a new version 1.1 that can be used in private windows.
The new version will be reviewed by Mozilla during the next days.
https://addons.mozilla.org/firefox/addon/fullscreen-plus/versions/

Thanks for the quick response!


Client how to use?

hello,How to use this client? I do n’t understand。
Can you tell me how to write?

see #6


hot-reload wrong paths on Windows

It seems to be like #78 issue but with css also
http://localhost:8080/css/app.css

Cannot GET /css/app.css

http://localhost:8080/public/css/app.css

OK

The problem also with #97 PR is that now
http://localhost:8080/js/app.js === http://localhost:8080/public/js/app.js
The files accessible from both URLs but the files with /public/** path is non hot-reloadable

For me, with just npm install laravel-mix, then copying the scripts part to package.json, creating dummy files in src/, then running npm webpack followed by npm hmr, I do get the CSS file at http://localhost:8080/dist/app.css (Windows 7 here). Could you try doing those steps?

@bvangraafeiland I'm using it with laravel 5.3 as a replacement of elixir.

Same problem here as of v0.8.9

Fixed in 0.10.0.


Set/Get object tag on custom marker?

Description
Is there a way to set an data object associate with each custom marker. So on MarkerPick "onMarkerPick(BitmapMarker marker)" method, we can get that object data to use for something else?.
Steps to Reproduce
Mapzen SDK & Android Version

Currently this is not possible. As an alternative you could keep a local association between markers and data objects but I do like the idea of potentially adding this functionality to the Mapzen SDK.


Max-Height & Scrollbar

Hi,
first of all thanks for your work!
This works really really well.
I just need to know how to limit the height of the textarea so that the text that is in that textarea is scrollable.
Regards !

When initializing textarea, ng-elastic add overflow: hidden style to it.
Workaround is override this style, then feel free to set line height and max height by yourself.


libpipeline: 1.5.0 -> 1.5.1

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libpipeline/versions.
meta.description for libpipeline is: '"C library for manipulating pipelines of subprocesses in a flexible and convenient way"'.

Checks done (click to expand)

built on NixOS
/bin/sh passed the binary check.
1 of 1 passed binary check by having a zero exit code.
0 of 1 passed binary check by having the new version present in output.
found 1.5.1 with grep in /nix/store/58ibahhww4f2xsghing7cgcbg9liypmj-libpipeline-1.5.1
directory tree listing: https://gist.github.com/96dc8825d7a336ca7388a8786d2d8981
du listing: https://gist.github.com/d450790ee6615050319fe5cabcf2961d

Rebuild report (if merged into master) (click to expand)

16039 total rebuild path(s)
6018 package rebuild(s)
6012 x86_64-linux rebuild(s)
5181 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
4845 aarch64-linux rebuild(s)
First fifty rebuilds by attrpath
AgdaSheaves
AgdaStdlib
DisnixWebService
EmptyEpsilon
Literate
OVMF
OVMF-CSM
R
SDL2_image
SDL_image
SDL_mixer
TotalParserCombinators
_20kly
_90secondportraits
aacskeys
abcde
abcl
abiword
acgtk
acoustidFingerprinter
actdiag
adapta-gtk-theme
adms
adobe-reader
adom
adoptopenjdk-bin
adoptopenjdk-hotspot-bin-11
adoptopenjdk-jre-bin
adoptopenjdk-jre-hotspot-bin-11
adoptopenjdk-jre-openj9-bin-11
adoptopenjdk-openj9-bin-11
adwaita-qt
aegisub
aesop
afew
afterstep
agdaBase
agdaIowaStdlib
agdaPrelude
ahoviewer
airstrike
airtame
aj-snapshot
akonadi
akregator
alacritty
alarm-clock-applet
albert
alchemy
aldor

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/58ibahhww4f2xsghing7cgcbg9liypmj-libpipeline-1.5.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A libpipeline https://github.com/r-ryantm/nixpkgs/archive/e4e781ddae6fb7b7965936f34778878e65ba733e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/58ibahhww4f2xsghing7cgcbg9liypmj-libpipeline-1.5.1
ls -la /nix/store/58ibahhww4f2xsghing7cgcbg9liypmj-libpipeline-1.5.1/bin

@GrahamcOfBorg eval

@grahamcofborg build libpipeline

@GrahamcOfBorg eval


[Docs] Create/Update the Brokers page in spanish, that goes in the CONCEPT section in the spanish docs site

Current State
The spanish docs site doesn't have the Brokers page translation to spanish
English page to translate: https://docs.meshery.io/concepts/architecture/broker
Desired State
The spanish docs site has the Brokers page translated to spanish in the CONCEPT section
Contributor Guides and Resources

🛠 Meshery Build & Release Strategy
📚 Instructions for contributing to documentation

Meshery documentation site and source

🎨 Wireframes and designs for Meshery UI in Figma
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

Soy yo de nuevo :), también lo tomaré.


Status bar text color is wrong after update to 1.26.0-1.0.pre

After updating to the latest dev channel preview (https://github.com/flutter/flutter/compare/1.25.0-4.0.pre...1.26.0-1.0.pre) the automatic calculation of the status bar text color seems to be wrong. Previously it was correct (white), now it's black. Tested on Android 10 (API level 29) emulator and One Plus 5T.
Steps to Reproduce

Create a new Flutter example app
Change the primary swatch to primarySwatch: Colors.deepPurple

Expected results:
The app bar text and icons should be white.
Actual results:
The app bar text and icons are black.

Logs

No error messages

Analyzing flutter_app...
No issues found! (ran in 1.8s)

[√] Flutter (Channel dev, 1.26.0-1.0.pre, on Microsoft Windows [Version 10.0.19041.685], locale de-DE)
    • Flutter version 1.26.0-1.0.pre at D:\Code\Flutter\flutter
    • Framework revision 63062a6443 (4 days ago), 2020-12-13 23:19:13 +0800
    • Engine revision 4797b06652
    • Dart version 2.12.0 (build 2.12.0-141.0.dev)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at D:\Code\Android\android-sdk
    • Platform android-30, build-tools 30.0.2
    • ANDROID_HOME = D:\Code\Android\android-sdk
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.7.4)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.7.30517.126
    • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] IntelliJ IDEA Community Edition (version 2020.3)
    • IntelliJ at C:\Users\boehr\AppData\Local\JetBrains\Toolbox\apps\IDEA-C\ch-0\203.5981.155
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin version 203.5981.152

[√] VS Code (version 1.52.1)
    • VS Code at C:\Users\boehr\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.15.0

[√] Connected device (4 available)
    • Android SDK built for x86 64 (mobile) • emulator-5554 • android-x64    • Android 10 (API 29) (emulator)
    • Windows (desktop)                     • windows       • windows-x64    • Microsoft Windows [Version 10.0.19041.685]
    • Chrome (web)                          • chrome        • web-javascript • Google Chrome 87.0.4280.88
    • Edge (web)                            • edge          • web-javascript • Microsoft Edge 87.0.664.60

Clearly reproducible on master and dev channels but NOT on stable so this is a regression.
master and dev channel: status bar items are black
stable channel: status bar are white.
Code
import 'package:flutter/material.dart';
import 'package:flutter/widgets.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(primarySwatch: Colors.deepPurple),
      home: Scaffold(
        appBar: AppBar(),
        floatingActionButton: FloatingActionButton(
          tooltip: 'Jump',
          child: Icon(Icons.arrow_upward),
        ),
      ),
    );
  }
}

multiple flutter doctor
[✓] Flutter (Channel master, 1.26.0-2.0.pre.82, on Mac OS X 10.15.7 19H2 darwin-x64, locale en)
    • Flutter version 1.26.0-2.0.pre.82 at /Users/pedromassango/dev/SDKs/flutter_master
    • Framework revision b84d8ee2df (3 hours ago), 2020-12-18 11:59:01 +0530
    • Engine revision fd6b409f95
    • Dart version 2.12.0 (build 2.12.0-157.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[!] Xcode - develop for iOS and macOS (Xcode 12.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.1, Build version 12A7403
    ! CocoaPods 1.9.3 out of date (1.10.0 is recommended).
        CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
        Without CocoaPods, plugins will not work on iOS or macOS.
        For more info, see https://flutter.dev/platform-plugins
      To upgrade see https://guides.cocoapods.org/using/getting-started.html#installation for instructions.

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] IntelliJ IDEA Community Edition (version 2020.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 52.0.5
    • Dart plugin version 203.5981.152

[✓] VS Code (version 1.51.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (3 available)
    • sdk gphone x86 arm (mobile) • emulator-5554 • android-x86    • Android 11 (API 30) (emulator)
    • macOS (desktop)             • macos         • darwin-x64     • Mac OS X 10.15.7 19H2 darwin-x64
    • Chrome (web)                • chrome        • web-javascript • Google Chrome 87.0.4280.88

! Doctor found issues in 1 category.
Process finished with exit code 0

[✓] Flutter (Channel dev, 1.26.0-1.0.pre, on Mac OS X 10.15.7 19H2 darwin-x64, locale en)
    • Flutter version 1.26.0-1.0.pre at /Users/pedromassango/dev/SDKs/flutter_dev
    • Framework revision 63062a6443 (5 days ago), 2020-12-13 23:19:13 +0800
    • Engine revision 4797b06652
    • Dart version 2.12.0 (build 2.12.0-141.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at /Users/pedromassango/Library/Android/sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.1, Build version 12A7403
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] IntelliJ IDEA Community Edition (version 2020.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 52.0.5
    • Dart plugin version 203.5981.152

[✓] VS Code (version 1.51.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.16.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • Mac OS X 10.15.7 19H2 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 87.0.4280.88

• No issues found!
Process finished with exit code 0

One side note in regards to the labels, if I remember correctly in 1.25.0-4.0.pre was everything fine, but I'm not 100% sure. Just to potentially reduce the amount of possible regression sources.

cc @xster.

cc @xster.

Reproducible on iOS too. Might be a framework regression.

Reproducible on iOS too. Might be a framework regression.

What would take for this to qualify for P2 for example? I mean, this imo makes beta not production viable as it is not something that can be settled for.

What would take for this to qualify for P2 for example? I mean, this imo makes beta not production viable as it is not something that can be settled for.

@goderbauer could you take a look?

@goderbauer could you take a look?

Did some quick bisecting: 1.25.0-4.0.pre is the last release where the status bar is still white, and 1.25.0-8.0.pre the first one where it is black. The regression occurred somewhere in https://github.com/flutter/flutter/compare/1.25.0-4.0.pre...1.25.0-8.0.pre. Will need to do some more bisecting fo those commits.

Did some quick bisecting: 1.25.0-4.0.pre is the last release where the status bar is still white, and 1.25.0-8.0.pre the first one where it is black. The regression occurred somewhere in https://github.com/flutter/flutter/compare/1.25.0-4.0.pre...1.25.0-8.0.pre. Will need to do some more bisecting fo those commits.

Further bisecting determines that this was broken by https://github.com/flutter/flutter/commit/d375a83910bda499b7f808d38809c6f931840a8f (https://github.com/flutter/flutter/pull/71184).
@HansMuller can you as the commit author take a look at this?

Further bisecting determines that this was broken by https://github.com/flutter/flutter/commit/d375a83910bda499b7f808d38809c6f931840a8f (https://github.com/flutter/flutter/pull/71184).
@HansMuller can you as the commit author take a look at this?

The problem was that the overlay was only taking the theme brightness into account, not the app bar background brightness. I opened #75091 with a possible fix.

The problem was that the overlay was only taking the theme brightness into account, not the app bar background brightness. I opened #75091 with a possible fix.

This regression has made it to the latest stable (2.0)

What would take for this to qualify for P2 for example? I mean, this imo makes beta not production viable as it is not something that can be settled for.

I agree with this. Unless light themes with a dark app bar are now obsolete.
However, there's a simple way to workaround:
AppBar(
  title: Text('Workaround'),
  brightness: Brightness.dark,
),

@pedromassangocode can we add the stable 2.0 tag here too? This issue will inevitably appear in a lot of production apps soon enough.

Any solution?

@pratikbutani did the suggestion in https://github.com/flutter/flutter/issues/72562#issuecomment-790044774 (two comments above) not work?

I found the solution for whole application If you are using appbar:

return MaterialApp(
       theme: ThemeData(
              appBarTheme: Theme.of(context).appBarTheme.copyWith(brightness: Brightness.dark),
        ),
        debugShowCheckedModeBanner: false,
        home: widget());

brightness: Brightness.dark
This won't solve the problem if the system itself is in dark mode

brightness: Brightness.dark
This won't solve the problem if the system itself is in dark mode

Do you have a separate theme for MaterialApp.darkTheme? If so, you have to add it there as well. If not, could you be more specific about what is not working?

brightness: Brightness.dark
This won't solve the problem if the system itself is in dark mode

Do you have a separate theme for MaterialApp.darkTheme? If so, you have to add it there as well. If not, could you be more specific about what is not working?

Sorry for not being clear, I mean if the phone itself is in dark mode the status bar text color is still wrong.
the only work around that worked in light and dark mode without changing the appBarTheme brightness was adding SafeArea  around the Scaffold of every screen.


[1.12.2] Cyclic Harvester in a 15x15 area does not gain additional Seed from MysticalAgriculture

Cyclic 1.9.5
ATM3 Pack
Server Instance
Having run a cyclic Harvester for over a week on MysticalAgriculture Crops, ive not once gained any additional seeds as i had running other harvesters.

So.
I planted a field of coal seeds.
When I harvest with machine, i get Coal essence and fertilized essence.  Never any seeds
When break the plant with my empty hand, i get that plus also coal seeds.
Thats basically what you mean?

As i continue testing and breaking them by hand, seems like the plants always only ever drop exactly one seed, and no more.
When i use the 'gentle right click harvest' from pams, i also get no seeds.  So by design they are "re-using" one of the seeds to replant.
With normal crops (vanilla, other mods like rustic or pams) you get a semi random number of seeds.  Wheat for example, you could get up to 3 seeds when fully grown.  Thats why  its not noticed as much, you still get seeds but not as many.
This is by design, it uses the same logic as gentle harvesting and is re-using the seeds to replant.

AFAIK, MA seeds are configured by default to never drop seeds on gentle harvest and drop exactly one seed on break. Given what the mod does, this isn't surprising. I don't think you're intended to get a billion seeds after just crafting one.

Yeah the getting extra seed issue i think will not be resolved, but i did find an issue that may or may not be related to this  and i found a fix.
Might not affect this, since its still going to try and consume the seed, but might fix some edge cases with some crops https://github.com/PrinceOfAmber/Cyclic/issues/569


dexie-export-import not exposing typings

I see that dexie-export-import does have typings defined but I don't seem them in the npm build.
Am I missing something? How can I get those typings? Thanks!

Thanks for detecting this and reporting it. This must have been an issue with the latest version 4.0.5, as the typings are there in 4.0.4.

Try upgrade the addon and it should have the typings. If still having issues, please reopen this issue.


Support Complex Path Parameters

For simplicities sake, MPV may only provide simple parameters
However, OpenAPI spec supports complex parameter types in a number of ways
Path parameters containing arrays and objects can be serialized in different ways:
path-style expansion (matrix) – semicolon-prefixed, such as /map/point;x=50;y=20
label expansion – dot-prefixed, such as /color.R=100.G=200.B=150
simple-style – comma-delimited, such as /users/12,34,56

For more info, see here https://swagger.io/docs/specification/describing-parameters/

This does not even seem to be supported by ktor https://ktor.io/docs/requests.html#query_parameters


testing lib for my personal project

Trying to modify this for my personal project to start with.  If it works for me then we will use it at my company and subscribe :)

Thanks! I hope it works :D
Any feedback is welcome.


fix: :wrench: Do not use defer for scripts

The defer attribute for the scripts is not a good idea in the cozy context. We have small HTMLs, so we don't really benefit from it, and it can make the browsers execute the scripts before the CSS has been
loaded (flash of unstyled content).

Thanks @nono 👍


Shader works only after rearranging Struct

I've got a shader with this in:
struct Light {
	vec3 color;
	float intensity;
	vec3 position;
};

#define MAX_LIGHTS 4
layout(set = 0, binding = 3) uniform Lights {
	int num_lights;
	Light lights[MAX_LIGHTS];
} lights;

[...]

for (int i = 0; i < lights.num_lights; i++) {
	color += do_light(lights.lights[i], normal);
}

I originally had the Lights uniform with the fields the other way around and in the for loop, lights.num_lights always appeared to be 0 (the loop doesn't run at all)
For the correct shader, these are the vulkano generated structs:
#[repr(C)]
#[derive(Copy, Clone, Debug, Default)]
pub struct Light {
	pub color: [f32; 3] /* offset: 0 */,
	pub intensity: f32 /* offset: 12 */,
	pub position: [f32; 3] /* offset: 16 */,
	pub _dummy0: [u8; 4]
} /* total_size: Some(32) */

#[repr(C)]
#[derive(Copy, Clone, Debug, Default)]
pub struct Lights {
	pub num_lights: i32 /* offset: 0 */,
	pub _dummy0: [u8; 12],
	pub lights: [Light; 4] /* offset: 16 */
} /* total_size: None */

And the wrong ones:
#[repr(C)]
#[derive(Copy, Clone, Debug, Default)]
pub struct Light {
	pub color: [f32; 3] /* offset: 0 */,
	pub intensity: f32 /* offset: 12 */,
	pub position: [f32; 3] /* offset: 16 */,
	pub _dummy0: [u8; 4]
} /* total_size: Some(32) */

#[repr(C)]
#[derive(Copy, Clone, Debug, Default)]
pub struct Lights {
	pub lights: [Light; 4] /* offset: 0 */,
	pub _dummy0: [u8; 16],
	pub num_lights: i32 /* offset: 128 */
} /* total_size: None */

Right it looks like _dummy0 shouldn't be there in the wrong layout.

Just tested on the latest git master and the erroneous _dummy0 is gone 🎉


Running the tracker from the application causes a crash on Linux

The error in the logs is something to the effect of "Unable to call function _start_tracker"
The issue is somewhere in OpenSeeGD.gd at line 269 when generating run options.

Does this happen also with a clean master checkout? (creating tracker options starts at line 264 for me)
I m sorry if that was caused with my pr, I didn't get that message when testing it ><

@Zutatensuppe Nah, this was one of my changes from the 0.7.1 release. I'm passing terminal arguments incorrectly on Mac/Linux. In the exported builds, it crashes the entire program when starting the tracker.

Fixed by 40382e0332ba416e742eeee223b4703effd23bcc


nvidia-container-cli reports "cuda error，initialization error"

In a system with 8 cards of V100, when the free system memory is reaching 8G, nvidia-container-cli will fail to run and report "cuda error，initialization error". And if we release some system memory, nvidia-container-cli will run successfully.
Is this a known limitation of 8G system memory ?
Docker version: 18.09.2
Nvidia-container-cli version: 1.0.1
Thanks in advance.

Thanks for the report.
This is not a known issue, but if you are seeing an error of cuda error，initialization error, then that means that CUDA itself was unable to initialize (independent of the nvidia-container-cli).
That said, as of libnvidia-container version 1.1.0, CUDA is no longer a dependence for the nvidia-container-cli. The latest release is actually 1.2.0, and we are planning to release an even newer version later today (1.3.0).
As such, I would recommend updating  libnvidia-container to a newer version to see if this fixes your problem.

Thanks for the report.
This is not a known issue, but if you are seeing an error of cuda error，initialization error, then that means that CUDA itself was unable to initialize (independent of the nvidia-container-cli).
That said, as of libnvidia-container version 1.1.0, CUDA is no longer a dependence for the nvidia-container-cli. The latest release is actually 1.2.0, and we are planning to release an even newer version later today (1.3.0).
As such, I would recommend updating libnvidia-container to a newer version to see if this fixes your problem.

Thanks for your quick response. I'll try the 1.2.0 version of nvidia-container-cli to see if issue still appears.
But since you mentioned that the error may imply the CUDA initialization issue, I have a concern that other CUDA apps will fail to initialize in such circumstance, even if the docker can launch with newer version of nvidia-container-cli.

Yes. I would have the same concern.
Have you seen this same issue on bare-metal( i.e. not inside a container) when running other CUDA workloads?

Yes. I would have the same concern.
Have you seen this same issue on bare-metal( i.e. not inside a container) when running other CUDA workloads?

Not tried yet. Will update after I have a try.


Update link.js

Then we can write like this
<Link href="/about" className="about" style={{color: 'red'}}>About</Link>

@arunoda
Nothing happen

@suhaotian weird.
Check my above comment.

@arunoda Hey, does right?

I believe we don't want to support this. See https://github.com/zeit/next.js/issues/272 cc @rauchg

@nkzawa ok


how access DHT20 on BOARD_BC20 that share same I2C bus as touch screen

Hi, your library work very good on my "BOARD_BC02" model, but i have a question, since my board have a DHT20 Temp/Humidity sensor built-in. Since is on the same I2C bus as the touch screen, that is managed by yout library, i cannot find any way to access it.
I've tryed to instantiate another TwoWire object on the same pics to read DHT20 sensor, but this conflicts with internal objects used by your library that query touch panel.
Is there any exposed "TwoWire" object by your library that i can use to make my own query to other I2C devices, or any other way that allow me to make my own query and then re-initialize the touch screen after i've finished my work, othrwise touch become not working.
Thanks in advance

Hi，
Normally, you can directly initialize i2c, which should not conflict with the touch screen. You can refer to this example. Note that the touch screen uses Wire1 https://github.com/smartpanle/PanelLan_esp32_arduino/blob/master/examples/peripherals/aw9523/aw9523.ino,


Video Stuck on Infinite Buffer

Current behavior
I have a list of videos in a flat list and very frequently the videos get stuck on an infinite buffer. If one video fails to load all other videos also get stuck.
Reproduction steps
No specific repro steps, but happens very frequently.
Expected behavior
The videos should play. Also if one video gets stuck the others should play.
Platform
Which player are you experiencing the problem on:

Android ExoPlayer

Video sample
If possible, include a link to the video that has the problem that can be streamed or downloaded from.

you can try this PR
https://github.com/react-native-community/react-native-video/pull/1113

i face same problem

I have no issues with IOS, but once I pause the video it buffers forever.

Facing the same problem. Getting issue after playing the same video multiple times. It will play after reopened the app. Do we need to clear any resource from the app?

I'm also facing the same issue and its been a month but no clue why its happening. No tracking and no reproduction sequence, happening out of nowhere, just stuck at buffering. Tried changing video at run-time, also tried pause, play and replay but not luck. As Video Player is the most important component of my app, any help will be highly appreciated.

I have the same issue on Android. Any news on this?

Same issue, any news here?

I can see this issue in IOS 16 and above, it's stuck in buffering indefinitely. It's working fine in android.


some  suggestion of environment

if installing high cuda version ,there is a error. it is"Error C7528: OpenGL reserves names starting with 'gl_': gl_PrimitiveID
Error C2003: Incompatible options for Link"
we need to seek suitable nvdiffrast version,because here provided github code is old.
so we need to do following steps:
instead of doing:
$ git clone https://github.com/sicxu/Deep3DFaceRecon_pytorch.git --recursive
do:
$ git clone https://github.com/sicxu/Deep3DFaceRecon_pytorch.git
then
$ cd Deep3DFaceRecon_pytorch
$ git clone https://github.com/NVlabs/nvdiffrast
$ cd nvdiffrast # ./Deep3DFaceRecon_pytorch/nvdiffrast
$ pip install .
hope author to update code ,thanks.

Thanks for your suggestion, I have updated the installation section in README.


I can't show the DoltLab homepage

I followed the installation guide,
The following error message appears and I cannot view the DoltLab home page.
https://docs.dolthub.com/products/doltlab/installation
Error: metrics enabled but GA_TRACKING_ID not specified in server config     at _app-01bcbb53c703ecb9.js:14:302241     at Object.useMemo (framework-8ea3c61dd4c96877.js:25:67226)     at t.useMemo (framework-8ea3c61dd4c96877.js:41:5986)     at Q (_app-01bcbb53c703ecb9.js:14:302000)     at lb (framework-8ea3c61dd4c96877.js:25:60916)     at i (framework-8ea3c61dd4c96877.js:25:119474)     at uI (framework-8ea3c61dd4c96877.js:25:99113)     at framework-8ea3c61dd4c96877.js:25:98980     at uM (framework-8ea3c61dd4c96877.js:25:98987)     at ux (framework-8ea3c61dd4c96877.js:25:95739)

@takashi-nakakido is this for the latest DoltLab version v1.0.3?
Can you share the environment variables you used to start DoltLab with the ./start-doltlab.sh script?

@takashi-nakakido is this for the latest DoltLab version v1.0.3?
→Yes.

./start-doltlab.sh script
→I have created a script with the following settings.
export HOST_IP=
export DOLT_PASSWORD=
export DOLTHUBAPI_PASSWORD=
export EMAIL_HOST=localhost
export EMAIL_PORT=
export<EMAIL_ADDRESS>export EMAIL_USERNAME=XXXX
export EMAIL_PASSWORD=
I have a server up and running on AWS Cloud9. I wanted to try dolt easily so I don't have an SMTP server ready.
Is an SMTP server required?

@coffeegoddd

@takashi-nakakido is this for the latest DoltLab version v1.0.3?
→Yes.

./start-doltlab.sh script
→I have created a script with the following settings.
export HOST_IP=
export DOLT_PASSWORD=
export DOLTHUBAPI_PASSWORD=
export EMAIL_HOST=localhost
export EMAIL_PORT=
export<EMAIL_ADDRESS>export EMAIL_USERNAME=XXXX
export EMAIL_PASSWORD=
I have a server up and running on AWS Cloud9. I wanted to try dolt easily so I don't have an SMTP server ready.
Is an SMTP server required?

@takashi-nakakido thanks for your responses. So the error Error: metrics enabled but GA_TRACKING_ID not specified in server config occurs because the DoltLab application is not getting the value of HOST_IP when it starts up, so it starts the DoltLab application in DoltHub mode, which produces this error.
DoltLab has not been tested on AWS Cloud9, so it's possible running DoltLab in this environment is interfering with DoltLab's ./start-doltlab.sh script and assumptions.
While DoltLab is running can you run docker inspect doltlab_doltlabui_1 and share the environment variables in the output? It will look something like this:
            "Env": [
                "NODE_OPTIONS=--max-old-space-size=16384",
                "DOLTHUB_VERSION=doltlab-v1.0.3",
                "STRIPE_API_KEY=does_not_work",
                "HOST_IP=doltlab.dolthub.com",
                "INTERNAL_GRAPHQLAPI_URL=http://doltlabenvoy:10080/graphql",
                "EVENTSAPI_URL=https://eventsapi.dolthub.com",
                "DOLTHUB_METRICS_ENABLED=true",
                "ENTERPRISE_EDITION=",
                "ALT_LOGO=",
                "ALLOW_COLOR_OVERRIDES=",
                "COLOR_OVERRIDE_RGB_ACCENT_1=",
                "COLOR_OVERRIDE_RGB_BACKGROUND_ACCENT_1=",
                "COLOR_OVERRIDE_RGB_BACKGROUND_GRADIENT_START=",
                "COLOR_OVERRIDE_RGB_BUTTON_1=",
                "COLOR_OVERRIDE_RGB_BUTTON_2=",
                "COLOR_OVERRIDE_RGB_LINK_1=",
                "COLOR_OVERRIDE_RGB_LINK_2=",
                "COLOR_OVERRIDE_RGB_LINK_LIGHT=",
                "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
                "NODE_VERSION=16.14.0",
                "YARN_VERSION=1.22.17",
                "NODE_ENV=production"
            ],

Based on the error, I would expect to see HOST_IP="" or not at all in your output.
Regarding "Is an SMTP server required?", it is required for the full functionality of DoltLab. Without a configured, working SMTP server, I believe only the admin user can use the DoltLab instance in a meaningful way.

@coffeegoddd
The following was displayed.
            "Env": [
                "NODE_OPTIONS=--max-old-space-size=16384",
                "DOLTHUB_VERSION=doltlab-v1.0.3",
                "STRIPE_API_KEY=does_not_work",
                "HOST_IP=",
                "INTERNAL_GRAPHQLAPI_URL=http://doltlabenvoy:10080/graphql",
                "EVENTSAPI_URL=https://eventsapi.dolthub.com",
                "DOLTHUB_METRICS_ENABLED=true",
                "ENTERPRISE_EDITION=",
                "ALT_LOGO=",
                "ALLOW_COLOR_OVERRIDES=",
                "COLOR_OVERRIDE_RGB_ACCENT_1=",
                "COLOR_OVERRIDE_RGB_BACKGROUND_ACCENT_1=",
                "COLOR_OVERRIDE_RGB_BACKGROUND_GRADIENT_START=",
                "COLOR_OVERRIDE_RGB_BUTTON_1=",
                "COLOR_OVERRIDE_RGB_BUTTON_2=",
                "COLOR_OVERRIDE_RGB_LINK_1=",
                "COLOR_OVERRIDE_RGB_LINK_2=",
                "COLOR_OVERRIDE_RGB_LINK_LIGHT=",
                "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
                "NODE_VERSION=16.14.0",
                "YARN_VERSION=1.22.17",
                "NODE_ENV=production"
            ],

In which environment should I run it?
The same error was displayed when I ran it in the gcp environment.

So in your output above HOST_IP is empty (or set to an empty string) which is why youre getting the error.
The ./start-doltlab.sh returns an error if you try to run it and HOST_IP is unset or an empty string, so now sure why its not doing so for you.
HOST_IP should be set to the IP address of the host running DoltLab.
We suggest running DoltLab on an Ubuntu AWS EC2 instance. Checkout this starter blog https://www.dolthub.com/blog/2022-02-22-getting-started-doltlab-video/

@coffeegoddd
Thank you very much.
When I ran it on EC2, it worked fine!

Hi @takashi-nakakido, Thank you for checking out DoltLab. We'd love to learn about your Dolt and DoltLab use case too. You can email me or come by our Discord.


ruff check --show-files does not consider lint.exclude config

ruff check --show-files has become a confusing option because it is a flag for the check command. I first assumed it did consider the lint.exclude config but it doesn't. I guess this only made sense when ruff check was just ruff.
user ~ ➜  ruff --version
ruff 0.6.1

pyproject.toml
[tool.ruff]
exclude = []
[tool.ruff.format]
exclude = []
[tool.ruff.lint]
exclude = ["src"]

current behaviour
user ~/Documents/my-repo (master) ➜  ruff check --show-files
/home/user/Documents/my-repo/docs/source/__init__.py
/home/user/Documents/my-repo/docs/source/conf.py
/home/user/Documents/my-repo/noxfile.py
/home/user/Documents/my-repo/pyproject.toml
/home/user/Documents/my-repo/setup.py
/home/user/Documents/my-repo/src/__init__.py
/home/user/Documents/my-repo/src/_version.py
/home/user/Documents/my-repo/src/config/__init__.py
/home/user/Documents/my-repo/src/release_hooks.py
/home/user/Documents/my-repo/src/src.py
/home/user/Documents/my-repo/src/utils/__init__.py
/home/user/Documents/my-repo/src/utils/nox.py
/home/user/Documents/my-repo/src/utils/packaging.py
/home/user/Documents/my-repo/src/utils/path.py
/home/user/Documents/my-repo/tests/__init__.py
/home/user/Documents/my-repo/tests/test_nox_utils.py
/home/user/Documents/my-repo/tests/test_packaging.py
/home/user/Documents/my-repo/tests/test_path.py

Expected behaviour: Files under my-repo/src not to be in this list.
If we consider changing this behaviour to consider the lint.exclude rule and similiar flags, then we should add a separate and equivalent flag for ruff format that considers the format.exclude config and similiar flags #13006.

I think this is a bug because we do consider the exclude / extend-exclude option in the top level section ([tool.ruff]) and might be related to https://github.com/astral-sh/ruff/issues/8267.


How tap-to-focus feature works

Hi!
I would like to let the user focus to take picture. But I don't know how it works.
I found on the documentation the section related to the problem : https://github.com/lwansbrough/react-native-camera#defaultonfocuscomponent But is there any example to view how it works ? I don't have any idea on how to implement this. With defaultOnFocusComponent  at true I didn't have default internal implementation of visual feedback for tap-to-focus gesture
Someone can help me on this point ?

Hi,
Try set defaultOnFocusComponent to true and onFocusChanged={this._handleFocusChanged}. In your callback, you can do:
_handleFocusChanged(event) {
console.log(event.nativeEvent.touchPoint);
// call capture() here
}
The visual feedback is already provided in this component.
Hope this helps!

Hum, it breaks the app. The focus seems to be triggered, but an error occured.
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[0]' libc++abi.dylib: terminating with uncaught exception of type NSException (lldb)

Maybe the error occurred because of capture()? Try remove capture() and only print log first?

this fails for me too, i dont have capture in my code, just attempting to console log the event and it fails with the error @JeremDsgn gets.

I am trying to get focus on tap to work on Android, and I am also lacking the focus widget and the event does not fire. I have tried both with defaultOnFocusComponent set to true and false, and both with and without the onFocusChanged event bound. No focusing in any of these configurations. Anyone got a suggestion of where to attack this problem?
I am running the latest code from the git repo on actual device (Nexus 5X) with Android 5.0.1.

Some help @lwansbrough ?!

My goal was to use it for scanning barcodes, and after looking through the code a bit it looks like this project doesn't support barcode scanning on Android. I switched to react-native-barcodescanner for the Android part of the application and that seems to work fine, so no hurry on my behalf :)

What version of react-native are you on @JeremDsgn - I'm getting the same error on react-native 0.14.2 react-native-camera 0.3.8

I'm on react-native 0.19.0 and react-native-camera 0.3.8.

@JeremDsgn did some digging, looks like it was fixed in November. https://github.com/lwansbrough/react-native-camera/issues/107
I don't know why our npm must have pulled in an old revision.

@lwansbrough might be useful to bump the version (not sure how to force npm to see the change)

@JeremDsgn I had to npm uninstall react-native-camera and then npm install https://github.com/lwansbrough/react-native-camera.git --save to get the revision with the fix.

IMO this API needs to change. I think a renderTapToFocus prop would be appropriate or something similar - I want to allow for customization of that component somehow. If anyone wants to try doing this now would be a good time as I'm working through the bugs and upgrading APIs.

@FrankSalad Ok, that's it ! Cool ! The last version of master is fixing the problem.
@lwansbrough Could you bump the version ? To avoid to download the dependencie from repository master.
Is there any way to custom the style of the focus square ? Changing the borderWidth, borderColor ?

@JeremDsgn Won't be version bumping until the API is ready. There are major changes that are unfit for a minor version bump.

See my previous comment with regards to what needs to be done about the focus square.

Oh sorry, read to fast on the early morning, and you answered all of my question. The basic feature works. Hope to see the customization soon !


Fix code example for Streaming section in Readme

Confirm this is an issue with the Python library and not an underlying OpenAI API

[X] This is an issue with the Python library

Describe the bug
There are a couple of errors in the examples provided for the streaming section.

First Issue
This is the example code, the last line should be print(chunk.choices[0].delta.content)

from openai import OpenAI

client = OpenAI()

stream = client.chat.completions.create(
    model="gpt-4",
    messages=[{"role": "user", "content": "Say this is a test"}],
    stream=True,
)
for chunk in stream:
    if chunk.choices[0].delta.content is not None:
        print(part.choices[0].delta.content)

Second Issue
This is the example code, the last line should be print(chunk.choices[0].delta.content)

from openai import AsyncOpenAI

client = AsyncOpenAI()

stream = await client.chat.completions.create(
    prompt="Say this is a test",
    messages=[{"role": "user", "content": "Say this is a test"}],
    stream=True,
)
async for chunk in stream:
    if chunk.choices[0].delta.content is not None:
        print(part.choices[0].delta.content)

To Reproduce
If you run the snippet provided, there are None values as result
from openai import OpenAI

client = OpenAI()

stream = client.chat.completions.create(
    model="gpt-4",
    messages=[{"role": "user", "content": "Say this is a test"}],
    stream=True,
)
for chunk in stream:
    if chunk.choices[0].delta.content is not None:
        print(part.choices[0].delta.content)+

Result:
None
None
None
None
None
None
Code snippets
No response
OS
linux
Python version
Python 3.10.12
Library version
openai v1.3.3

Thanks! I'll have a fix up shortly.


[ENH]: CIP-5: Large Batch Handling Improvements Proposal

Including only CIP for review.

Refs: #1049
Description of changes
Summarize the changes made by this PR.

Improvements & Bug fixes

New proposal to handle large batches of embeddings gracefully

Test plan
How are these changes tested?

[ ] Tests pass locally with pytest for python, yarn test for js

Documentation Changes
TBD

@HammadB, true that we cannot guarantee ACID-like behaviour this way, but even without, things seem to go wrong on very large batches. Do you think we can introduce tenacity (Apache 2 lic) for some added bonus of retries? I think this can be helpful further down the road, where a retry can resolve the problem.
In my experience, in situations where transactionality cannot be guaranteed, we can implement mechanisms to fail gracefully - e.g. store the failed batch in a temp file and allow the user to resubmit later. wdyt?

I think this discussion brought by @HammadB and the last proposed solution by @tazarov requires more time and analysis (the last solution also has its implications).
I'd suggest to reduce the scope of this change to just exposing the max_batch_size in the API so it can be merged and clients can handle batches themselves (and add it to the docs) -in the case of privateGPT it is causing errors, I guess there are more clients impacted- and discuss the error management in a different CIP. WDYT?

@imartinez, let me do that now.

@imartinez @HammadB, Refactored. The new impl no longer splits batches automatically. We do ship a utility library for that though chromadb/utils/batch_utils.py. The API now validates the batch size (client-side), prior to trying to persist it. Everything else is left as-is:

pre-flight-check endpoint is still there
max_batch_size property is still available at API level for clients to use to break up batches

Added a couple more tests to ensure correctness.
CIP doc has also been updated to reflect above changes.

 If it keeps failing, I'll debug it further

@tazarov forsure, I've rerun them a handful of times but happy to do so again

@HammadB, Tests in my fork are passing, so this is ready for merge after your review.


Submit form when hitting enter in assign task

Details

Submit form when hitting enter in assign task
Fixed Issues

$ https://github.com/Expensify/App/issues/21205
PROPOSAL: https://github.com/Expensify/App/issues/21205#issuecomment-1600985245
Tests

Login with Expensifail account
Go to FAB > Assign task
Fill title, description field and hit enter key
Verify that we go to the next page and title and description is stored
Click on description
Edit description and hit enter key
Verify that we go back to new task page and description is updated
Hitting enter key again and verify that task is created

[x] Verify that no errors appear in the JS console

Offline tests

Same above
QA Steps

Login with Expensifail account
Go to FAB > Assign task
Fill title, description field and hit enter key
Verify that we go to the next page and title and description is stored
Click on description
Edit description and hit enter key
Verify that we go back to new task page and description is updated
Hitting enter key again and verify that task is created

[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
Screencast from 27-06-2023 10:59:20.webm

Mobile Web - Chrome
https://github.com/Expensify/App/assets/129500732/ced1ac77-f6c3-447a-abfb-83a841fcbdab

Mobile Web - Safari
https://github.com/Expensify/App/assets/129500732/6424d33e-533e-4b73-ae36-933d3e08afe5

Desktop
https://github.com/Expensify/App/assets/129500732/bffc7a5a-0d02-4d43-9529-96bee2f2ab80

iOS
https://github.com/Expensify/App/assets/129500732/734d317e-7147-4986-86e1-4cd76627421b

Android
https://github.com/Expensify/App/assets/129500732/98b6a3ec-0f5e-4f2e-aac6-eb06891b6622

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web
https://github.com/Expensify/App/assets/28352309/6e27b6a3-6e67-41ff-beb9-ff6209d8ee33

Mobile Web - Chrome
https://github.com/Expensify/App/assets/28352309/00ae9fa2-e3c7-49f3-bac4-af1e125ed857

Mobile Web - Safari
https://github.com/Expensify/App/assets/28352309/05c37671-95de-497d-9b69-c83f0c725867

Desktop
https://github.com/Expensify/App/assets/28352309/f1376f56-f7f7-4d49-b01f-257dbcee51a6

iOS
https://github.com/Expensify/App/assets/28352309/e038c5d3-860a-47ef-b17b-3fbfc44c7e2d

Android
https://github.com/Expensify/App/assets/28352309/87e12af3-49a1-4bcc-b6cb-d3a6a1e4e0f8

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Yeah I would expect that enter makes a new line for textareas. Maybe we need to make an exception here for a creation flow? Not entirely sure how I feel about that.

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.34-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

I think it makes sense that shift + enter is required to make a new line. It matches the behavior of the composer at least.

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.34-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

Oh god, that's funny. We are having somewhat parallel discussions. The enter key should create a new line in textareas (see this other "bug" and the Slack discussion in an employee channel).
I don't agree that we should change the behaviour of the textarea here. Could we just change the field type?


Disabled dropdown still show pointer cursor on :hover.

Demonstrated here: http://jsfiddle.net/e359vgcv/1/ as well as on the last example (at the time of writing) here: http://semantic-ui.com/modules/dropdown.html
The cursor should be reset to auto if the dropdown is disabled.

Dupe of #1615 already fixed in next
http://jsfiddle.net/pczqf8xj/


Throttling / cluster status checking

I dumped my data from an ES cluster to a big JSON file, and now I'm having trouble loading it into a different cluster.  I'm told that the symptoms point to the new cluster simply not being able to keep up with the speed of the import.  (Elasticdump is too fast!)
It would be great, then, if elasticdump had the option to throttle its transfer speed.  This could either be a raw bandwidth threshold, or it could check the target cluster health between batches and wait until it's green again before sending the next batch.

You have a proxy for this now with the --limit option.  When reading back from your file, --limit will control how many lines from your dump are attempted to be written to ES at once.

Hi evantahler.  I'm not sure how that helps me.  I just spent several hours running an import with --limit=10 (and giving my ES cluster way more resources than I think it ought to need), and it still can't keep up.
I could spend another day trying again with --limit=1, but I'm not convinced even that would be enough.  A smaller batch size is not the same thing as throttling.

This tool only writes one "batch" of objects at a time.  It does no parallelization.
Unless you want a sleep between writes (whose size is controller by the --limit argument), Speed is controller by disk and network I/O.  Writes are simple HTTP POST commands.  If ES takes time to ingest each write, it will be slower to respond to the POST request.
How are you sure that ES "can't keep up"?

That is literally the phrase that my host told me about my cluster.  I've pointed them to this thread, so maybe they can chime in on what exactly they mean by that.

They have since told me that they don't think that is the cause of my trouble, after all.  Sorry about the confusion.


Potential memory leak in C++ backend

It looks like when using unbiased choice, we might be holding on the streams for longer than we should.
This seems to be happening when compiling pdf-cos using the C++ backend, but it needs more investigation and, in particular, we need to make a smaller example that exhibits the issue.

Problem confirmed, here is a small example:
def Main = Match1 'a' | Match1 'b'

No memory leak when using <|


question about version

«When performing loads, cereal will load versioning information if your serialization function is versioned. (!)If you did not use a versioned serialization function to create the archive you are loading from, your data will be corrupted and your program will likely crash. (!) This loaded version number will be supplied via the version parameter you add to your serialization functions.»
What's the point in such restriction? It forces the user to make a decision if every serializable class could be changed in the future. This decision has to be made in the very beginning and there are big chances the decision is wrong. Or one could add version parameter in all serialization functions in all classes, just in case. Would it be a better solution to use default version (0 for example) in case of version abcense in archive, then just to crash? In this case one may not add version info to the class in the beginning, but can add it later when the class gets changed, and it won't break backward compatibility with archives made erlier.

This restriction exists for two reasons: the simplest reason is that cereal did not initially support versioning. The primary reason it exists, however, is that we designed cereal to be minimal in respect to metadata, so the default in this and other situations is to output nothing, if possible.
cereal does in fact internally use a default version of 0 for all types - the problem you run into is a mismatch in expectation of whether metadata should exist. If the serialization function is not serialized and the serialized data had a version, there is now metadata in some location where the running program expects something else, which usually causes a crash. In the other case, where there was no version in the serialized data, but the serialization function is versioned, data will be misinterpreted as the versioning information and likely cause a crash.

Oh, yes, I thought about xml and json archives, where all data fields have a metadata, so absence of serialized version info could be simply detected. But in binaries archives, you are right, this trick will not work. Is it a bad idea to make different rules for different kinds of archives?

I am migrating some code from non-versioned serializiation functions to versioned ones, any chance to maintain reading compatibility for serialized archives?
while I get your reply above, is there any chance to just consider all archives that were saved with unversioned functions just as version 0 archives??
what would the right way of migrating to versioned functions??
any idea?

I have to say, this shortcoming has hurt us badly.  The inability to go from unversioned classes to versioned the first time you need it should at the very least be MUCH more prominent in the documentation.  In really big red letters right in the "getting started" section.  This is a massive gotcha that we missed in our initial implementation.  If anyone has any thoughts about how to work around this, other than making a copy of the class itself, I'm sure many of us would greatly appreciate a workaround.

I agree. Would be great if it just put 0 for the version if you didn't specify.


WIP - docs typos

typos and suggestions courtesy of Juan ❤

Closing as it looks like this chapter has since been re-written


[RESTEASY-1238]

Avoid ERROR level stacktraces when response is commited before Exception
can be written.

I'm replacing this PR with https://github.com/resteasy/Resteasy/pull/1170, where I basically excluded your new test on WildFly 10.0.0.Final. I believe the web layer behaves differently/erroneously there.


Portfolio multistrike cones

A portfolio cone prediction changes as new funds are added. Previous method treated portfolio returns without regard to when new funds were turned on.
This pr also fixes the issue that some conecharts were not generated.

I'm not sure if plot_portfolio_cones shouldn't live in qids as it's a not really useful to single portfolio analysis.
Otherwise, is there perhaps an example plot you can post that shows how it's working?

@twiecki I wasn't sure where it should go. Moving it to qids makes sense.

@twiecki I moved the method over to qids


Verify that {first = <...>} in select/pairs does not fall into full scan, when it does not

See https://github.com/tarantool/crud/pull/169/files#r652086030 and https://github.com/tarantool/crud/pull/158#discussion_r653452766

@oleg-jukovec Please, take a look when time will permit.

In the #158 was suggested to delete the logic of choosing bigger value from scan value and after. That would be a mistake because even in the simple example:

crud.select('space', {}, {after = value})

will be a fullscan (we will scroll from beginning of the index to after, otherwise we start from after).
We have such logic in the master:
https://github.com/tarantool/crud/blob/aea09775055ed4006efa2b480c1e97b9c7ce9691/crud/select/executor.lua#L44-L69
It works as expected.

#169 adds some new tests that does not work as expected.

We have these tests (and some more tests which was broken by #177 ):
https://github.com/tarantool/crud/blob/aea09775055ed4006efa2b480c1e97b9c7ce9691/test/integration/select_test.lua#L1186-L1187
It works fine too.
I rechecked the current implementation of choosing from scan value and after + scrolling to after. It works as expected (at least with examples related to the issue).
It seems to me the issue is outdated. I close it.


Credentials does not update existing credential

Starting configuration
site.pp
node default {
 jenkins::credentials {<EMAIL_ADDRESS>  password => '',
  private_key_or_path => hiera('blu::deploy_key'),
  uuid => 'cf2baae7-a2c0-4fda-ba23-88c816aaef68',
 }
}

base.yaml
blu::deploy_key: "privatekey"

Apply
puppet apply site.pp

The credential is created and set to file path "privatkey"
Modify hiera
Modification of hiera to change the private key.
base.yaml
blu::deploy_key: "privatekey2nd"

puppet apply site.pp

The value of the credential is still "privatekey".
It seems that the 'grep' at this line should contain all the information of the credential and not only the title.

@Perdjesk I have posted an alternative type named jenkins_credentials that could potentially replace jenkins::credentials.  I wouldn't suggest trying it "in production" but it may be worth testing to see if it resolves this issue.