Decimal number bug in Android App

I think there is a bug in the Helium App for Android. When I enter a decimal number, the App changes automatically from i.E. at burning amount 0.3 to 3 HNT and in the Antenna gain from 4.5 to 15.  I wanted to burn 0.3 HNT for DC to fill up my Console Account and when I tapped on Confirm, a Message appeared and stated to burn 3 HNT and that is what happened. So, now I have DC for Lifetime and cannot reverse it back. If I want set the Antenna gain I can only use full digits or the presets, which isn´t acurate to my gain loss. Perhaps it is related to the german keyboard setting and the different use of dot (.) and comma (,) as a decimal seperator. Would be good to fix it.

@joeynoob Which phone are you using and which version of Android? I have confirmed that on a Pixel 3a with Android 12 and set to German language the app is working as expected. Numbers are shown with a dot as thousands separator and comma as decimal separator. HNT burn transactions and antenna updating works as expected in German locale.
Do you see numbers displayed properly for German locale elsewhere in the app?

Hey Tyler, it is a S7 Edge with Android 8. Numbers in the App are shown with a comma as decimal seperator. When I enter a custom Antenna value of i.E. 4.5, the seperator is a dot in the field and the number changes automatically to 15, when I tap on the next field for entering the height. If I choose a preset Antenna, it shows with a comma in the field. As already described, at the burn of HNT I had no chance to check the Amount again after tap on the Burn HNT Button. It directly changed from 0.3 to 3 HNT. It were better, if an E-Mail confirmation would be required as a 2F confirmation.
Von: Tyler Whitman @.>
Gesendet: Montag, 27. Dezember 2021 21:19
An: helium/hotspot-app @.>
Cc: joeynoob @.>; Mention @.>
Betreff: Re: [helium/hotspot-app] Decimal number bug in Android App (Issue #1170)
@joeynoob https://github.com/joeynoob  Which phone are you using and which version of Android? I have confirmed that on a Pixel 3a with Android 12 and set to German language the app is working as expected. Numbers are shown with a dot as thousands separator and comma as decimal separator. HNT burn transactions and antenna updating works as expected in German locale.
Do you see numbers displayed properly for German locale elsewhere in the app?
—
Reply to this email directly, view it on GitHub https://github.com/helium/hotspot-app/issues/1170#issuecomment-1001730663 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AQNL5ZK74XIN4ZMTG7JBW2DUTDC2LANCNFSM5KL7JMOA .
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675  or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .
You are receiving this because you were mentioned.Message ID: @.*** @.***> >

@joeynoob Thanks for the reply. If you are using German locale on your phone you should enter "4,5" not "4.5". If you use German local and enter "4.5" this would be considered an input of 45 and set the gain to 15 which is the max.

I assumed and tried already, but the comma is not available. I tapped the Dot Button and hold, but it didn't change to Comma. Only the Dot is available.

I've tried now different Keyboard layouts, updated UK English and German Keyboard, changed to UK English and tried to replace the decimal Symbol setting from Dot to Comma. Comma was not offered to chose. I think, when the App opens the keyboard in the Antenna settings or anywehere to enter numbers, the number keyboard get opened and there is only the dot available.

@joeynoob which keyboard are you using? Would you be willing to try the google gboard keyboard? This may be an issue with the Android 8 Samsung keyboard.

Thank you Tyler. Done and it works! It´s a workaround and I don´t like the
Google Keyboard, but good to know. Wishing a happy and healthy 2022! Cheers,
Jörg
Von: Tyler Whitman @.>
Gesendet: Donnerstag, 30. Dezember 2021 20:08
An: helium/hotspot-app @.>
Cc: joeynoob @.>; Mention @.>
Betreff: Re: [helium/hotspot-app] Decimal number bug in Android App (Issue
#1170)
@joeynoob https://github.com/joeynoob  which keyboard are you using? Would
you be willing to try the google gboard keyboard? This may be an issue with
the Android 8 Samsung keyboard.

Reply to this email directly, view it on GitHub
https://github.com/helium/hotspot-app/issues/1170#issuecomment-1003149360
, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQNL5ZMOJQ5BCERMS7KXMULUT
SUYJANCNFSM5KL7JMOA> .
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&m
t=8&pt=524675>  or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=u
tm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>
.
You are receiving this because you were mentioned.Message ID:
@.***
@.***> >

I have the same problem on a Samsung S20, using Swype Keyboard on Spanish locale, when trying to enter a 5.8 dBi antenna. The comma is missing in the App keyboard, only the dot shows.
Another work around is to type the in 5,8 (note the comma) in another App that allows ABC keyboard and then copy/paste it into the TX / RX Gain field in the Helium App.

it sounds like the keyboard is not allowing the proper separator that the app is expecting based on locale, so we'll have to close this as not an issue.


Prop style did not match.

Hi, I am facing a warning simply importing Checkbox from react-custom-checkbox.
Here's the warning...
BTW I am using Nextjs 13
Warning: Propstyledid not match. Server: "height:18px;width:18px;border-width:2px;border-color:#D7C629;border-style:solid;border-radius:5px;display:flex;align-items:center;justify-content:center" Client: "height:18px;width:18px;border-width:2px;border-color:#D7C629;border-style:solid;border-radius:5px;display:flex;align-items:center;justify-content:center;cursor:"
Is there any way to fix this ?
Thanks

Hello @milkeddy1 , thanks for submitting the issue. Could you please reproduce it in a cloud sandbox?


posix: use sys_sem instead of k_spinlock for pool synch

Based on Andy's talk at eoss 2024, use the sys/sem.h api instead of the spinlock.h api to synchronize pooled elements since it has minimal overhead like the k_sem api but also works (better) from userspace

This doesn't switch the POSIX spinlock over to sys_sem yet - here we just "avoid spinlocks in library code" in the synchronization of pools where there is a possibility that it could be called from userspace.
I'll make a separate PR to convert pthread spinlocks to use sys_sem under the hood too.


Latest version of parso 0.8 crashes Spyder 3.3.1 with python 3.5

Issue Report Checklist

[x] Searched the issues page for similar reports
[] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice
[x] Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)
[ ] Could not reproduce inside jupyter qtconsole (if console-related)
[x] Tried basic troubleshooting (if a bug/error)

[x] Restarted Spyder
[x] Reset preferences with spyder --reset
[x] Reinstalled the latest version of Anaconda
[x] Tried the other applicable steps from the Troubleshooting Guide

[x] Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
Latest version of parso version 0.8.0 causes Spyder 3.3.1 to not start with Python 3.5
What steps reproduce the problem?
conda create -n spyder_test python=3.5 spyder
conda activate spyder_test
spyder &

What is the expected output? What do you see instead?
Spyder should startup successfully instead it crashes.
Paste Traceback/Error Below (if applicable)

  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/spyder/app/mainwindow.py", line 3181, in main
    mainwindow = run_spyder(app, options, args)
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/spyder/app/mainwindow.py", line 3057, in run_spyder
    main.setup()
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/spyder/app/mainwindow.py", line 896, in setup
    from spyder.plugins.ipythonconsole import IPythonConsole
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/spyder/plugins/ipythonconsole.py", line 59, in <module>
    from spyder.widgets.ipythonconsole import ClientWidget
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/spyder/widgets/ipythonconsole/__init__.py", line 12, in <module>
    from .debugging import DebuggingWidget
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/spyder/widgets/ipythonconsole/debugging.py", line 17, in <module>
    from qtconsole.rich_jupyter_widget import RichJupyterWidget
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/qtconsole/rich_jupyter_widget.py", line 14, in <module>
    from .jupyter_widget import JupyterWidget
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/qtconsole/jupyter_widget.py", line 20, in <module>
    from IPython.lib.lexers import IPythonLexer, IPython3Lexer
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/IPython/__init__.py", line 55, in <module>
    from .terminal.embed import embed
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/IPython/terminal/embed.py", line 16, in <module>
    from IPython.terminal.interactiveshell import TerminalInteractiveShell
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/IPython/terminal/interactiveshell.py", line 32, in <module>
    from .debugger import TerminalPdb, Pdb
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/IPython/terminal/debugger.py", line 6, in <module>
    from IPython.core.completer import IPCompleter
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/IPython/core/completer.py", line 146, in <module>
    import jedi
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/jedi/__init__.py", line 41, in <module>
    from jedi.api import Script, Interpreter, set_debug_function, \
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/jedi/api/__init__.py", line 15, in <module>
    import parso
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/parso/__init__.py", line 41, in <module>
    from parso.parser import ParserSyntaxError
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/parso/parser.py", line 113
    node_map: Dict[str, type] = {}
            ^
SyntaxError: invalid syntax

Versions

Spyder version: 3.3.1
Python version: 3.5.6
Qt version: 5.9.6
PyQt version: 5.9.2
Operating System name/version: Ubuntu 16.04
Parso version: 0.8.0

Workaround
Using parso 0.7 works:
conda create -n spyder_test python=3.5 spyder parso=0.7
conda activate spyder_test
spyder &

@absognety I do use the latest Spyder where possible, but there are projects where I have you use Python 3.5 for legacy reasons and the newer Spyder / ipython-kernels doesn't work with those.
It might be work specifying in the dependencies / compatibility for version 3.3.1 to limit parso to less than 0.8.  This way a conda install of Spyder in python 3.5 environment would automatically install appropriate version of parso.

@vik748  what feature of parso from 0.8.0 are you trying to work with that is not already there in parso 0.7.0? clearly solving this version incompatibility is a painful as it is clearly stated in changelog, maybe there is some better way of doing your task using another package that is compatible with your requirments?

None. I don't care about parso but looks like Spyder needs it.

Issue Report Checklist

[x]  Searched the issues page for similar reports

[] Read the relevant sections of the Spyder Troubleshooting Guide and followed its advice

[x]  Reproduced the issue after updating with conda update spyder (or pip, if not using Anaconda)

[ ]  Could not reproduce inside jupyter qtconsole (if console-related)

[x]  Tried basic troubleshooting (if a bug/error)

[x]  Restarted Spyder
[x]  Reset preferences with spyder --reset
[x]  Reinstalled the latest version of Anaconda
[x]  Tried the other applicable steps from the Troubleshooting Guide

[x]  Completed the Problem Description, Steps to Reproduce and Version sections below

Problem Description
Latest version of parso version 0.8.0 causes Spyder 3.3.1 to not start with Python 3.5
What steps reproduce the problem?
conda create -n spyder_test python=3.5 spyder
conda activate spyder_test
spyder &

What is the expected output? What do you see instead?
Spyder should startup successfully instead it crashes.
Paste Traceback/Error Below (if applicable)
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/spyder/app/mainwindow.py", line 3181, in main
    mainwindow = run_spyder(app, options, args)
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/spyder/app/mainwindow.py", line 3057, in run_spyder
    main.setup()
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/spyder/app/mainwindow.py", line 896, in setup
    from spyder.plugins.ipythonconsole import IPythonConsole
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/spyder/plugins/ipythonconsole.py", line 59, in <module>
    from spyder.widgets.ipythonconsole import ClientWidget
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/spyder/widgets/ipythonconsole/__init__.py", line 12, in <module>
    from .debugging import DebuggingWidget
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/spyder/widgets/ipythonconsole/debugging.py", line 17, in <module>
    from qtconsole.rich_jupyter_widget import RichJupyterWidget
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/qtconsole/rich_jupyter_widget.py", line 14, in <module>
    from .jupyter_widget import JupyterWidget
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/qtconsole/jupyter_widget.py", line 20, in <module>
    from IPython.lib.lexers import IPythonLexer, IPython3Lexer
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/IPython/__init__.py", line 55, in <module>
    from .terminal.embed import embed
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/IPython/terminal/embed.py", line 16, in <module>
    from IPython.terminal.interactiveshell import TerminalInteractiveShell
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/IPython/terminal/interactiveshell.py", line 32, in <module>
    from .debugger import TerminalPdb, Pdb
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/IPython/terminal/debugger.py", line 6, in <module>
    from IPython.core.completer import IPCompleter
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/IPython/core/completer.py", line 146, in <module>
    import jedi
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/jedi/__init__.py", line 41, in <module>
    from jedi.api import Script, Interpreter, set_debug_function, \
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/jedi/api/__init__.py", line 15, in <module>
    import parso
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/parso/__init__.py", line 41, in <module>
    from parso.parser import ParserSyntaxError
  File "/home/vik748/miniconda3/envs/spyder_test/lib/python3.5/site-packages/parso/parser.py", line 113
    node_map: Dict[str, type] = {}
            ^
SyntaxError: invalid syntax

Versions

Spyder version: 3.3.1
Python version: 3.5.6
Qt version: 5.9.6
PyQt version: 5.9.2
Operating System name/version: Ubuntu 16.04
Parso version: 0.8.0

Workaround
Using parso 0.7 works:
conda create -n spyder_test python=3.5 spyder parso=0.7
conda activate spyder_test
spyder &

Related  issue: https://github.com/spyder-ide/spyder/issues/13476

@vik748 Isn't the problem here that conda installs parso 0.8 in a 3.5 environment, although 3.5 support was dropped in parso 0.8? So this is a conda issue I think

@rhkarls That is a valid point, I will also add an issue in their repo.

@vik748, thanks for reporting. @dalthviz will submit a pull request to fix this dependency in Anaconda.

This is fixed now.


How do the Android ad APIs work, specifically, what is the impact of removing AdId on isLimitAdTrackingEnabled()?

public boolean isLimitAdTrackingEnabled ()
Retrieves whether the user has limit ad tracking enabled or not. When the returned value is true, the returned value of [getId()](https://developers.google.com/android/reference/com/google/android/gms/ads/identifier/AdvertisingIdClient.Info#getId()) will always be 00000000-0000-0000-0000-000000000000 starting with Android 12 (but older devices may be problematic). This shows to me that Integration with previous devices may be an issue. Naive AdID solution will only be able to work on certain phones where the getId function has that certain functonality (https://www.deccanherald.com/business/technology/android-12-list-of-devices-eligible-for-the-latest-google-mobile-os-1031367.html)

Does removing the AdId also set this flag isLimitAdTrackingEnabled() to true in Android 12+?
This flag used to indicate to users whether they allow tracking but was removed in the UI as Google changed the UI and now allows users to remove the AdId.
As a result, it's unclear whether removing the AdId actually encourages apps not to track across apps anymore. This is not 100% clear from Google's policies, as discussed in #48
Todo: Build sample app, connect to AdId API, and show outputs (i.e. isLimitAdTrackingEnabled and retrieved AdId).
API documentation: https://developer.android.com/training/articles/ad-id
Originally posted in https://github.com/privacy-tech-lab/gpc-android/issues/48#issuecomment-1486921283

Code here: https://github.com/privacy-tech-lab/gpc-android/tree/issue-49


Mark.record behaves strangely when fields have commas

Mark.record will fail to parse blocks when there's a comma in the field content, unless it's the last field, in which case it parses up to the comma, and anything after that is treated as the rest of the document.
https://ellie-app.com/5HzMQsXmcnxa1

Thanks!  Found the issue.  Hopefully will have a release in the next few days.


[BUG] Navbar is not responsive in mobile-view

Describe the bug
The responsiveness is not there for mobile phone screen.
To Reproduce
Steps to reproduce the behavior:

Go to Home page in mobile phone view of iphone SE size in inspect section.
See error

Expected behavior
It should be converted into hamburger button to show all the navbar items.
Screenshots

Smartphone (please complete the following information):

Device: [iPhone SE]
Browser [Chrome]

Additional context
Add any other context about the problem here.

@aryadevesh
you can start working


Update changelog for release

We may want to update the README as well with some screenshots or something. I heard that there were docs being prepared? Maybe we should link those in our CHANGELOG/README as well? The UX change is a huge overhaul and I imagine a lot of users may be confused.
At the very least, I think we should try to illustrate in the CHANGELOG that the UX is completely different. Reading it now, I don't really get that impression. It should probably be on the top of the notes as well considering how different it is.

I'm going to add a small PR with some additional breakdowns of the big sections, deployWorkspaceProject and revision draft stuff.  If any of you have good ideas on the readme section, definitely feel free to add that in as well, there's a lot we've covered this release :)

We may want to update the README as well with some screenshots or something. I heard that there were docs being prepared? Maybe we should link those in our CHANGELOG/README as well?

Right now the README does not have any specific screenshots other than the .dev demo. It does link a tutorial docs that needs to be updated with some new/fewer steps. I'll go ahead and change the changelog to better shows the UX changes

I think we should go ahead and get rid of the .dev demo as well, while you're at it.


Release 1.1.0

Codecov Report

Merging #45 (cc9828a) into master (6d46354) will decrease coverage by 6.53%.
The diff coverage is 41.96%.

@@             Coverage Diff              @@
##             master      #45      +/-   ##
============================================
- Coverage     60.13%   53.59%   -6.54%
+ Complexity      985      857     -128
============================================
  Files           140      143       +3
  Lines          3687     3806     +119
  Branches        354      397      +43
============================================
- Hits           2217     2040     -177
- Misses         1405     1681     +276
- Partials         65       85      +20

Impacted Files
Coverage Δ

...nite/common/exception/EntityNotFoundException.java
100.00% <ø> (ø)

...vernite/common/exception/ExternalApiException.java
0.00% <0.00%> (ø)

...rnite/common/exception/error/ExternalApiError.java
0.00% <0.00%> (ø)

.../vernite/common/exception/error/NotFoundError.java
100.00% <ø> (ø)

...exception/handler/ExternalApiExceptionHandler.java
0.00% <0.00%> (ø)

...ernite/vernite/common/utils/SecureRandomUtils.java
0.00% <0.00%> (ø)

...ntegration/communicator/slack/SlackController.java
2.12% <0.00%> (-0.20%)
:arrow_down:

...gration/communicator/slack/model/SlackMessage.java
0.00% <0.00%> (ø)

...ntegration/communicator/slack/model/SlackUser.java
0.00% <0.00%> (ø)

...ernite/vernite/integration/git/GitTaskService.java
23.07% <0.00%> (ø)

... and 66 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[Jitsi] Add support for the livestreaming meeting rooms

Checklist

[X] I'm reporting a new site support request
[X] I've verified that I'm running yt-dlp version 2021.12.27. (update instructions)
[X] I've checked that all provided URLs are alive and playable in a browser
[X] I've checked that none of provided URLs violate any copyrights or contain any DRM to the best of my knowledge
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[X] I've read about sharing account credentials and am willing to share it if required

Region
Europe (and worldwide in general)
Example URLs

Meeting room: https://meet.jit.si/ExampleTestMeeting10371472
Meeting room (with the site's randomly generated name): https://meet.jit.si/MusicalPapersRelaxIndeed

Description
https://meet.jit.si is a free web video meeting service for creating online meeting rooms for up to 100 participants, includes features like screen livestreaming and remote desktop control. Does not require making an account.
Not sure how the video output from multiple participants at once works functionally, but personally for me at least the capability to watch a livestream from the only broadcasting participant in the meeting would be enough.
Verbose log
.\yt-dlp.exe -Uv "https://meet.jit.si/ExampleTestMeeting10371472"
[debug] Command-line config: ['-Uv', 'https://meet.jit.si/ExampleTestMeeting10371472']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8 (No ANSI), err utf-8 (No ANSI), pref cp1252
[debug] yt-dlp version 2021.12.27 [6223f67] (win_exe)
[debug] Python version 3.8.10 (CPython 64bit) - Windows-7-6.1.7601-SP1
[debug] exe versions: none
[debug] Optional libraries: Cryptodome, mutagen, sqlite, websockets
[debug] Proxy map: {}
Latest version: 2021.12.27, Current version: 2021.12.27
yt-dlp is up to date (2021.12.27)
[debug] [generic] Extracting URL: https://meet.jit.si/ExampleTestMeeting10371472

[generic] ExampleTestMeeting10371472: Requesting header
WARNING: [generic] Falling back on generic information extractor.
[generic] ExampleTestMeeting10371472: Downloading webpage
[generic] ExampleTestMeeting10371472: Extracting information
[debug] Looking for video embeds
ERROR: Unsupported URL: https://meet.jit.si/ExampleTestMeeting10371472
Traceback (most recent call last):
  File "yt_dlp\YoutubeDL.py", line 1353, in wrapper
  File "yt_dlp\YoutubeDL.py", line 1423, in __extract_info
  File "yt_dlp\extractor\common.py", line 599, in extract
  File "yt_dlp\extractor\generic.py", line 3829, in _real_extract
yt_dlp.utils.UnsupportedError: Unsupported URL: https://meet.jit.si/ExampleTestMeeting10371472

Does the site have VODs, or only livestream?


Terragrunt Provider Cache not working properly when using it with Atlantis

Describe the bug
As described in https://github.com/gruntwork-io/terragrunt/issues/2920#issuecomment-2065588601 we are having mixed results while using Terragrunt Provider Cache running 0.57.2 inside Atlantis, in the same PR some plans succeed and some don't.
We use Atlantis in ECS with EFS for storage, we run multiple instances of it with Redis as backend.
Recently we upgraded to Terragrunt 0.57.2 and Atlantis 0.27.2 to use the Terragrunt Provider Cache so we can speed up the PR planning/applying because we have over 700 terragrunt.hcl files in our code.
When doing a PR that includes an upgrade for Terraform AWS Provider it will trigger a huge number of plans and given we have Atlantis configured with --parallel-plan and --parallel-apply it starts multiple terragrunt plan processes at the same time.
To Reproduce
I do not have a step by step to reproduce but this is our env vars when running inside Atlantis:
TERRAGRUNT_DOWNLOAD="$HOME/.cache/terragrunt/modules"
TERRAGRUNT_FETCH_DEPENDENCY_OUTPUT_FROM_STATE="true"
TERRAGRUNT_PROVIDER_CACHE=1
TERRAGRUNT_NON_INTERACTIVE="true"
TERRAGRUNT_INCLUDE_EXTERNAL_DEPENDENCIES="true"

Atlantis server args:
--enable-diff-markdown-format  --hide-prev-plan-comments --automerge --hide-unchanged-plan-comments --parallel-apply --parallel-plan

Atlantis env vars:
ATLANTIS_PARALLEL_POOL_SIZE=10
ATLANTIS_ALLOW_REPO_CONFIG=true

Expected behavior
Be able to use Terragrunt Provider Cache on Atlantis using parallel plan and apply.
Nice to have

[X] Terminal output

time=2024-04-18T23:16:12Z level=info msg=Terragrunt Cache server is listening on <IP_ADDRESS>:39541
time=2024-04-18T23:16:12Z level=info msg=Start Terragrunt Cache server
time=2024-04-18T23:16:16Z level=info msg=Downloading Terraform configurations from git::ssh://git@github.com/terraform-aws-modules/terraform-aws-iam.git?ref=v5.37.1 into /home/atlantis/.cache/terragrunt/modules/CZJOkESJyj2a2n17Ph1lBtPy7p8/Z_nexO2qqCg5RPmJa_gkAX4ynAY prefix=[/home/atlantis/.atlantis/repos/ACME/terraform/838/provider_aws_dev__global_iam_roles_sre-role/provider/aws/security/_global/iam/policies/sre-assume-role]
time=2024-04-18T23:16:16Z level=info msg=Downloading Terraform configurations from git::ssh://git@github.com/ACME/tf-aws-iam-saml-provider.git?ref=v1.0.1 into /home/atlantis/.cache/terragrunt/modules/1-d3ZTASqfksjn_orsKPDUGD7ks/lPrDQ0wT1dtsjgNOnzZoq0oCtyE prefix=[/home/atlantis/.atlantis/repos/ACME/terraform/838/provider_aws_dev__global_iam_roles_sre-role/provider/aws/security/_global/iam/identity_providers/X]
╷
│ Error: Failed to query available provider packages
│
│ Could not retrieve the list of available versions for provider
│ hashicorp/aws: host registry.terraform.io rejected the given authentication
│ credentials

time=2024-04-18T22:43:57Z level=info msg=Terragrunt Cache server is listening on <IP_ADDRESS>:38393
time=2024-04-18T22:43:57Z level=info msg=Start Terragrunt Cache server
time=2024-04-18T22:43:58Z level=info msg=Downloading Terraform configurations from git::ssh://git@github.com/terraform-aws-modules/terraform-aws-iam.git?ref=v5.30.0 into /home/atlantis/.cache/terragrunt/modules/BBCsdcAtPBWyKxcKxrWGSmPnyMI/Z_nexO2qqCg5RPmJa_gkAX4ynAY

Error: Could not retrieve providers for locking

Terraform failed to fetch the requested providers for cache_provider in order
to calculate their checksums: some providers could not be installed:
- registry.terraform.io/hashicorp/aws: host registry.terraform.io rejected
the given authentication credentials.

Versions

Terragrunt version: 0.57.2
Terraform version: 1.4.6
Environment details (Ubuntu 20.04, Windows 10, etc.): ghcr.io/runatlantis/atlantis:v0.27.2

Additional context
Atlantis configuration: https://gist.github.com/amontalban/dcd106a55390203bd30cb706e96698e6
We do not have any CLI Configuration or credentials configured.

Hi @amontalban, Unfortunately, this is not enough information to understand the cause of the issue.
│ Could not retrieve the list of available versions for provider
│ hashicorp/aws: host registry.terraform.io rejected the given authentication
│ credentials

This error is in no way related to the number of concurrent processes.
Please review how caching works https://terragrunt.gruntwork.io/docs/features/provider-cache/
Most likely, these values, TF_TOKEN_*, are somehow overwritten, which is why you cannot connect to the cache server and get rejected the given authentication credentials.

I would suggest also checking the credentials file.

Hi @levkohimins,
Thanks for looking this issue, I have built a test case for easier testing.
You can find it here: https://github.com/amontalban/terragrunt-issue-3076
If you set your machine with those requirements (Mainly GNU Parallel, Docker and the specified Terraform/Terragrunt versions) then if you run make parallel you will see the error I specified in the report, on the other side if you run make sequentially it will work properly because it is executed one at a time.
Let me know if that helps or you need anything else.
Thanks once again!

@levkohimins after building this test case and running some tests, I think you were on the right track.
The problem is that when I run multiple parallel plans the generated token which is an UUID will be different for each of the processes and therefore causing this authentication issue.
If I set the TERRAGRUNT_PROVIDER_CACHE_TOKEN env var or --terragrunt-provider-cache-token to be the same for all processes then this works in my test case.
I'm going to test it out in Atlantis to confirm and get back to you to confirm that solves my problem.

Hi @amontalban,

Thanks for looking this issue, I have built a test case for easier testing.
You can find it here: https://github.com/amontalban/terragrunt-issue-3076

Thank you, this should really help, I will try it out.

The problem is that when I run multiple parallel plans the generated token which is an UUID will be different for each of the processes and therefore causing this authentication issue.

Each Terragrunt process runs its own cache server (starts listening on a free port) and generates its own token, they shouldn't conflict. I suppose that this rejected the given authentication credentials error occurs when Terraform tries to connect to a server other than the one whose process run the terraform command.
The logic for determining a free port is implemented in Golang code, so the likelihood of a bug is unlikely.
That's all thoughts for now, I'll try your test if I encounter this error and I will be able to say more.

Hi @amontalban,

Thanks for looking this issue, I have built a test case for easier testing.
You can find it here: https://github.com/amontalban/terragrunt-issue-3076

Thank you, this should really help, I will try it out.

The problem is that when I run multiple parallel plans the generated token which is an UUID will be different for each of the processes and therefore causing this authentication issue.

Each Terragrunt process runs its own cache server (starts listening on a free port) and generates its own token, they shouldn't conflict. I suppose that this rejected the given authentication credentials error occurs when Terraform tries to connect to a server other than the one whose process run the terraform command. The logic for determining a free port is implemented in Golang code, so the likelihood of a bug is unlikely.
That's all thoughts for now, I'll try your test if I encounter this error I will be able to say more.

Hi @levkohimins,
Thank you for your explanation! I have now tested this in Atlantis and the rejected the given authentication credentials. error disappeared after using a fixed TERRAGRUNT_PROVIDER_CACHE_TOKEN value for all processes.
However I am now getting this error in some of the plans (Here are the stats 42 failing, 1 pending, and 652 successful checks):
╷
│ Error: Failed to query available provider packages
│
│ Could not retrieve the list of available versions for provider
│ hashicorp/null: could not query provider registry for
│ registry.terraform.io/hashicorp/null: the request failed after 2 attempts,
│ please try again later: Get
│ "http://<IP_ADDRESS>:36847/v1/providers/registry.terraform.io/hashicorp/null/versions":
│ dial tcp <IP_ADDRESS>:36847: connect: connection refused

Here is the full log just in case: https://gist.github.com/amontalban/a5dbe6f5831d9ea79fd2923793a53323
Just in case I'm going to test with v0.57.6 and report back because I have been testing with v0.57.2.
Thanks once again for the help!

Hi @amontalban,
Thanks for the test case. I figured out why it doesn't work, --terragrunt-provider-cache conflicts with --terragrunt-download-dir. I have started working on fixing this issue and will update you once it is done.

Hi @amontalban @nsb413, the issue should be resolved in v0.57.9 release, could you please confirm this?

Hey @levkohimins, sorry I missed your previous message. I will try to test it out tomorrow and report back.
Thank you for the quick fix!

Still an issue for me.
TG: 0.57.9
TF: 1.5.6

TERRAGRUNT_PROVIDER_CACHE_DIR="somepath"
TERRAGRUNT_PROVIDER_CACHE: "true"
TF_PLUGIN_CACHE_DIR is not set
TF_PLUGIN_CACHE_MAY_BREAK_DEPENDENCY_LOCK_FILE should be set automatically based on the caching docs.

Might be some different problem, because cache is there after the first run, but during the second run on terrgarunt run-all init -upgrade I can see that provides been installed again even though that caching server is running from what I can see in logs.

@sshepel, I could not reproduce the issue.

@sshepel, I could not reproduce the issue.

I think the init logs are missleading (so it's working). Because with terragrunt cache enabled I can see this:
Initializing provider plugins...
- Finding latest version of hashicorp/template...
....
- Installing hashicorp/template v2.2.0...
- Installed hashicorp/template v2.2.0 (unauthenticated)

Where as with TF_PLUGIN_CACHE_DIR var set I saw something like: used from cache for the same provider plugin.
But I have checked the .terraform  folder under .terragrunt-cache for specific module after the init step with cache and I can see that the binaries for provider plugins are linked to the cached folder as mentioned in Provider Caching docs.
Also there is a message about incomplete lock file information for providers (which seems to be fine, but very annoying).

I think the init logs are missleading (so it's working). Because with terragrunt cache enabled I can see this:
Initializing provider plugins...
- Finding latest version of hashicorp/template...
....
- Installing hashicorp/template v2.2.0...
- Installed hashicorp/template v2.2.0 (unauthenticated)

Where as with TF_PLUGIN_CACHE_DIR var set I saw something like: used from cache for the same provider plugin. But I have checked the .terraform folder under .terragrunt-cache for specific module after the init step with cache and I can see that the binaries for provider plugins are linked to the cached folder as mentioned in Provider Caching docs.

We sue provider_installation instead of plugin_cache_dir so that Terraform has read-only access to the cache directory. Since the log you mentioned is Terrafrom's log we cannot change them in any way.

Also there is a message about incomplete lock file information for providers (which seems to be fine, but very annoying).

We are trying to solve it in #3089

Hi @amontalban, could you please confirm that the issue is resolved?

@levkohimins: I am still getting
│ Error: Failed to resolve provider packages
│
│ Could not resolve provider hashicorp/time: could not query provider
│ registry for registry.opentofu.org/hashicorp/time: the request failed after
│ 2 attempts, please try again later: Get
│ "http://<IP_ADDRESS>:46489/v1/providers//registry.opentofu.org/hashicorp/time/versions":
│ dial tcp <IP_ADDRESS>:46489: connect: connection refused

with v0.58.3

Hi @norman-zon, your issue is different, not connected to this one, this is already resolved. Please created a new one with the full log --terragrunt-log-level debug.


Introduce and use OrtResult.getScanResults()

See individual commits.
Context: #5681.

@fviernau there seem to be build failures.


Schema validations in relation to EDI/Ebix

Question
Søren - Are we sure that schema validations in relation to EDI/Ebix ensures that deserializing goes well, So we can convert EDI to internal format in the incoming request (synchronous)

I have assigned you to this question, Søren. You can reach out to Thomas and Kristian for elaboration.

We need some clarifications about input and output data for the system. When this is settled we can start design the process for handling requests.
As of now, the schema validation for Ebix/RSM is only structure validation. This gives the developers a guarantee that Xml contains all the needed fields. but nothing about the content. As long as the conversion is about structure then it can be used. If you need to make assumptions about the content of a field, then it starts to get shaky.


Sidecar closes and Backoff Loop Updated

This addresses @glyn s comments on #544 and partially addresses #323

function-sidecar/pkg/backoff/debug.test should not be checked in.

@dturanski Apologies for the mixture of commit comments and PR comments. Hopefully you can see the commit comments in the conversation tab of this PR.

Merged as 74d23368462c5bff564078ef35f5d7583f7c32d8.
@dturanski Thanks for all this. I tweaked backoff.go (to avoid the retry counter wrapping in extreme circumstances) and made some stylistic changes to the unit tests. Please take a look at your convenience.


/usr/local/bin/containerd: error while loading shared libraries: libseccomp.so.2: cannot open shared object file: No such file or director

Description

Steps to reproduce the issue:
$ wget -c  https://github.com/containerd/containerd/releases/download/v1.4.3/cri-containerd-cni-1.4.3-linux-amd64.tar.gz

$ tar xf cri-containerd-cni-1.4.3-linux-amd64.tar.gz -C /

$  systemctl enable  containerd.service
$  systemctl restart containerd.service
Job for containerd.service failed because the control process exited with error code. See "systemctl status containerd.service" and "journalctl -xe" for details.

$ journalctl -xe
-- Unit containerd.service has begun starting up.
Dec 10 08:08:41 k8s-init systemd[1]: containerd.service: main process exited, code=exited, status=127/n/a
Dec 10 08:08:41 k8s-init containerd[13319]: /usr/local/bin/containerd: error while loading shared libraries: libseccomp.so.2: cannot open
Dec 10 08:08:41 k8s-init systemd[1]: Failed to start containerd container runtime.
-- Subject: Unit containerd.service has failed
-- Defined-By: systemd
-- Support: http://lists.freedesktop.org/mailman/listinfo/systemd-devel
--
-- Unit containerd.service has failed.

the
3. shared libraries: libseccomp.so.2  not found
$  ldd /usr/local/bin/containerd
	linux-vdso.so.1 =>  (0x00007ffd5f127000)
	libdl.so.2 => /lib64/libdl.so.2 (0x00007f30e7700000)
	libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f30e74e4000)
	libseccomp.so.2 => not found
	libc.so.6 => /lib64/libc.so.6 (0x00007f30e7116000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f30eae05000)

Output of containerd --version:
$ containerd --version
containerd: error while loading shared libraries: libseccomp.so.2: cannot open shared object file: No such file or directory

Any other relevant information:
$ uname -a
Linux k8s-init 3.10.0-1062.el7.x86_64 #1 SMP Wed Aug 7 18:08:02 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

$  cat /etc/redhat-release
CentOS Linux release 7.7.1908 (Core)

solved by
$  yum install libseccomp -y

/close


Update SendSEPATransfer.php

Any reviews?

And also check the required execution date to be nullable @ xml package


Azure - z/OS Cloud Broker UI not coming up in the OCP Cluster

Description
After z/OS Cloud broker operator is installed in the OCP Cluster provisioned in Azure, its URL is not accessible,
Corresponding Pod is found to have ImagePullBackOff error.

Containers are in Waiting state.

Events from the Pod show failures in pulling the images.
Failed to pull image "cp.icr.io/cp/zoscb/ui@sha256:5705c6001dc87c71d61fc29e38fd2464c30fe113cf8aeabc79401730b9855608": rpc error: code = Unknown desc = Requesting bearer token: invalid status code from registry 400 (Bad Request)
Failed to pull image "cp.icr.io/cp/zoscb/oauth- proxy@sha256:dfd0565629ac86433836727ca98781a53853e24a6e71a861d9dd29f9668d6bc3": rpc error: code = Unknown desc = Requesting bearer token: invalid status code from registry 400 (Bad Request)

Expected Behaviour
z/OS Cloud Broker UI should be accessible at URL, say https://ibm-zoscb-ui-zoscloudbroker-ibm-zmodstack-cloudbroker.apps.z-mod-stack.ibmzsw.com
Potential Solutions

Fix the error in pulling the cp.icr.io/cp/zoscb/ui and cp.icr.io/cp/zoscb/oauth-proxy images
Check the Pod ibm-zoscb-ui-zoscloudbroker is running without any errors
Ensure z/OS Cloud Broker UI is accessible

Added details of cp.icr.io in pull-secret. Cloud Broker able to pull the images successfully and UI is accessible.


PR 1.4.1

PR checklist

[ ] This comment contains a description of changes (with reason)
[x] If you've fixed a bug or added code that should be tested, add tests!
[ ] If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repo
[x] Ensure the test suite passes (nextflow run . -profile test,docker).
[x] Make sure your code lints (nf-core lint .).
[ ] Documentation in docs is updated
[x] CHANGELOG.md is updated
[ ] README.md is updated

Ok, something odd here @drpatelh - we merged to dev and now this is behind 250 commits?

And loads of conflicts....something isnt right. Im probably the last person to know what went wrong...sorry.

w


feat: 2020/11/26 add new functions insertMulti & update

Add new features.
I think these function will help build queries easier.
I have trim some external spaces at the end of the line.
If possible, I also wants to run PSR-2 rules to scripts.

If this pull request is not allowed, can you tell me the reason or disadvantage?
Thank you!


[D2] 2.1 [Feature #1} [User Feature] [complete / incomplete] [Ai Xin (after), Guan Lin (before enhancing)]

Feature 1 (To be Enhanced)
AiXin

[x] completed
[ ] incomplete

GuanLin

[x] completed
[ ] incomplete

A Regional Manager has the ability to submit a formal request form to request additional resources required for a project. The request form includes several categories, such as an extension of the project timeline, an increase in the physical space or area required for the project, an augmentation of the project's financial resources, and an increase in the number of donors and volunteers. These categories can be selected by checking the corresponding checkbox. Moreover, the Regional Manager can provide a detailed description to explain the rationale behind the need for additional resources. This formal request process allows the Regional Manager to communicate their resource needs effectively and efficiently to the appropriate channels (Module 2).

Reviewed and Closed on: 31/3/2023


Set up GHA to test on Python 3.9-beta and 3.8-dev

GHA has recently started shipping Python betas so I thought I'd add it.
3.9.0-beta.4 - 3.9.0 is a semver range syntax that will get 3.9-beta set up in the worker.
I kept 3.9-dev and added 3.8-dev — these are still coming from deadsnakes PPA.
I've changed ubuntu-latest to concrete ubuntu-18.04 so that it's deterministic (at some point it'll be ubuntu-20.04 and that may come as a surprise).
I think it's possible to install the beta on macOS too but didn't know if that'd be wanted so I left it out.

Interesting... It looks like tox gets stuck on py39-beta

I don't know how to read this syntax,

Yeah, it's poorly documented @ https://github.com/actions/setup-python#usage:

Download and set up the latest available version of Python (includes both pre-release and stable versions):
    python-version: '3.9.0-alpha - 3.9.0' # SemVer's version range syntax

Ref: https://twitter.com/zooba/status/1284187985630593027
I also considered trying to enable beta from deadsnakes but it seems like @asottile only keeps one last beta, like 3.9.0~b4. So we cannot set 3.9-beta that would be auto-updated to the next beta and hardcoding will probably explode if b4 gets removed and replaced by b5...

I don't know how to read this syntax,

Yeah, it's poorly documented @ https://github.com/actions/setup-python#usage:

Download and set up the latest available version of Python (includes both pre-release and stable versions):
    python-version: '3.9.0-alpha - 3.9.0' # SemVer's version range syntax

Ref: https://twitter.com/zooba/status/1284187985630593027
I also considered trying to enable beta from deadsnakes but it seems like @asottile only keeps one last beta, like 3.9.0~b4. So we cannot set 3.9-beta that would be auto-updated to the next beta and hardcoding will probably explode if b4 gets removed and replaced by b5...

if you use 3.9 for the deadsnakes action it will always be the latest tagged version, 3.9-dev will be the latest nightly version

@asottile

if you use 3.9 for the deadsnakes action it will always be the latest tagged version, 3.9-dev will be the latest nightly version

But no such thing for betas, right?

@asottile

if you use 3.9 for the deadsnakes action it will always be the latest tagged version, 3.9-dev will be the latest nightly version

But no such thing for betas, right?

if the latest tagged release is 3.9b4 it will be the beta, if the latest tagged release is 3.9.1 it will be 3.9.1

Since it's still interesting why tox gets stuck under 3.9.0b4, I've added a live output option to tox for now.

So I have a suspicion that GH compiled it wrong: https://github.com/actions/setup-python/issues/119.
It'd be interesting to see if this will explode under the deadsnakes beta (probably not, because it doesn't break with dev).

If I had to guess, you're running into the same py3.9 issue I ran into as well when adding the py3.9 tests to https://github.com/TkTech/pysimdjson.
The fix is swapping the order of your steps. setup-python is including py3.9 in your working directory and your tests are trying to run the CPython tests as well. The checkout action cleans your working directory, so if you just swap the order presto it works.
See https://github.com/actions/setup-python/issues/106 for the upstream issue.

@TkTech that's an interesting suggestion. But if the GH-provided action has such regressions, I'd rather use deadsnakes instead of trying to fight their bugs...
Let's see what @jaraco thinks.

Alright, they've fixed the bug. @jaraco how would you like to proceed?

Thanks for your patience and for pulling this together. I'm pretty confident my projects are going to migrate from Azure Pipelines to GHA soon, given that Azure Pipelines requires massive manual intervention to set each project up. Assuming I go that direction, your work here will be immensely valuable to the projects I maintain.

@jaraco in the light of that I want to share what I've learned recently. Apparently, you can now have an org-wide GHA workflows templates: https://docs.github.com/en/actions/configuring-and-managing-workflows/sharing-workflow-templates-within-your-organization.

Indeed, I started looking into adopting github actions, but it seems that features like shared workflow templates and shared secrets only work for organizations. Do you think GitHub want individuals to create an organization to host the projects currently hosted in a personal account?

Dunno what GH wants but I personally use orgs as the means to group repos. But yea, I think they view this as something that orgs need more than individuals. Though, I'm not sure how useful it is to share secrets in public orgs — there's been some discussions in pytest and the conclusion was that creating an org-global PYPI_PASSWORD secret with a token is not a wise thing to do, security-wise, for example.


Discussion : Image Encoding

Hello,
I noticed that the checkpoint you're using is only 15 MB in size, while the meta checkpoints referenced here (https://github.com/facebookresearch/segment-anything#model-checkpoints) are over 2 GB. Could you please clarify the reason for this discrepancy?
Thank you in advance for your insights.

Hi @shizurumaya . This checkpoint is not from the original SAM. In order to allow users to interact in real time to use SAM to segment objects, we modified the SAM workflow (see https://geo-sam.readthedocs.io/en/latest/#introduction). This checkpoint was created by us to avoid having to encode the image each time new prompts are provided.

Thank you for the response. This tool seems very promising. It's already working well on my end :)
The size of the elements seems to be limited by the tile size. For instance, when I select a large forest, I get a square tile. Is there any plan for the tool to be able to outline elements that are larger than the patch size?
Additionally, I see that the size limit during encoding is 1024. Would the segmented elements potentially be larger if this limit was increased to 2048?

Hi @shizurumaya , you have the option to adjust the resolution while encoding the image. Additionally, we have developed a copilot tool to assist users in determining the appropriate resolution.To access this tool, please download the pre-release version. For more detailed information, please refer to the following link: Encoder Copilot Tool (QGIS).

Currently, SAM only supports image inputs with a resolution of 1024x1024 pixels. As mentioned in my previous comment, reducing the image resolution is a viable solution for most scenarios. However, it seems that changing the resolution may still not cover the entire forest in your specific use case. We are aware of this limitation, which also applies to delineating large glacial areas. We are actively exploring potential solutions to address this issue, but we have not found a satisfactory approach yet. One possible but cumbersome workaround is to manually delineate and save only the boundary portions, then merge these polygons and extract the outer boundary line to achieve the desired extraction. However, this approach poses several challenges and may not provide the best user experience. It is indeed a challenging problem that requires further consideration.

Hi @4del-Yousefi . Their work also requires resizing the original image. We now have a preliminary idea for solving extremely large objects, and have added it to the Future Works section.


Interpreting jitter in coordcheck

Hi,
I have coord check plots with mup that look roughly stable but are a bit more jittery compared to the example plots. I was wondering if this can be considered expected behavior.

Thanks!

It's good as long as the magnitude is stable. One way to verify further is to extend the x-axis to the right

Thanks! I could verify the stability of LR with width even with this jitter. Closing this issue accordingly.


Not getting proper typing on Popper types in Popover

Question
When I check out the types of PopperContentProps in my editor I see this:
type PopperContentProps = Radix.ComponentPropsWithoutRef<any>

which is giving me any on all the popover props I care about.
However if I go to definition I see this chain:
// go to defintion of PoperContentProps
type PopperContentProps = Radix.ComponentPropsWithoutRef<typeof PopperPrimitive.Content>;
// go to definition of Popper.Primitive.Content
export const Content: React.ForwardRefExoticComponent<PopperContentProps & React.RefAttributes<HTMLDivElement>>;
// go to definition of PopperContentProps
export interface PopperContentProps extends PrimitiveDivProps {
    side?: Side;
    sideOffset?: number;
    align?: Align;
    alignOffset?: number;
    arrowPadding?: number;
    avoidCollisions?: boolean;
    collisionBoundary?: Boundary | Boundary[];
    collisionPadding?: number | Partial<Record<Side, number>>;
    sticky?: 'partial' | 'always';
    hideWhenDetached?: boolean;
    updatePositionStrategy?: 'optimized' | 'always';
    onPlaced?: () => void;
}

The go to definition seems to be what I want, not sure why I am getting any in my LSP, I wonder if the name collision between PoperContentProps is causing an infinite loop?

May be related to use of typescript 5^, see related issue https://github.com/radix-ui/primitives/issues/2309


Asking for Help on checking the error

To reproduce error:

Launch Philov in the External Samsung Device.
Wait for the error.

This is happening on the Samsung device (light blue).


Auto reviewed my account

Expected content
Actual content
Link to page:

Hello @mouradove12  ,
We're sorry you're having this issue. You can access support contact options by going to https://support.sendgrid.com and clicking "Trouble Logging in?". From there, you can tell us a little more about your problem without having to log in, and one of our fantastic support people will get back to you. Hope this helps!
Twilio SendGrid Docs Team

support don't answer don't reply don't resolve
Le sam. 9 mai 2020 à 00:06, Wade Christensen<EMAIL_ADDRESS>a
écrit :

Hello @mouradove12 https://github.com/mouradove12 ,
We're sorry you're having this issue. You can access support contact
options by going to https://support.sendgrid.com and clicking "Trouble
Logging in?". From there, you can tell us a little more about your problem
without having to log in, and one of our fantastic support people will get
back to you. Hope this helps!
Twilio SendGrid Docs Team
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sendgrid/docs/issues/5979#issuecomment-626070112, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/APN56GKGCFOBVIR54J7XK2LRQSNA5ANCNFSM4MYFK6SQ
.


Roll Flutter Engine from 17decdf12557 to e2cac30be7ce (2 revisions)

https://github.com/flutter/engine/compare/17decdf12557...e2cac30be7ce
2024-05-17<EMAIL_ADDRESS>Roll Skia from bcb24206f9c4 to 6165e26f33ac (1 revision) (flutter/engine#52902)
2024-05-17<EMAIL_ADDRESS>Issue anERROR instead of an INFO for a non-working API. (flutter/engine#52892)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


There is a malformed YAML from prior commit - Fixed.

Saw a malformed YAML from a prior commit that is stopping Github Pages from building. Fixed.

Wow. Thanks for taking the time to send in an fix. Cheers. Prost.


Spelling fixes for things found with codespell

Fixes to spelling errors found with codespell version 1.16.0.
Pretty unexciting stuff.
Related Issue(s): None
Proposed Changes:

Spelling corrections - No functional changes

PR Checklist:

[x] This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
[x] This PR has no breaking changes.
[x] a CHANGELOG entry is not required.
[ ] This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change. - I don't think it's worth an issue

Awesome, thanks @schwehr!


Implement logo upload and automatic scaling, reuse implementation of module to upload images to tweet if possible

The wall does not offer an image upload yet. Please reuse existing ways in loklak if possible/

@aneeshd16 What options do we have? I saw this comment from you in the standup:

Blockers: Will have to decide between doing the image upload, scaling and conversion manually or using yet ANOTHER library.

I found a module, https://github.com/adonespitogo/angular-base64-upload that would make this task trivial. However, I need @fuksi and @sudheesh001 views, if we need to go for something more general. IMO, this should be fine.
Demo: http://embed.plnkr.co/MTzfQASN8ZVeocAq7VcM/preview

This implementation looks good for me, it's actually a lot more compact of what we're using here at:

https://github.com/loklak/loklak_webclient/blob/master/app/js/services/file.js
& 34-39 in https://github.com/loklak/loklak_webclient/blob/master/app/js/controllers/tweet.js

Please implement this directive and then refer to here your experience with it so we can make the decision to change code in similar places :)

Okay, I will go with this, will take me day to implement.

@aneeshd16 Looks good with this present but also for hellojs the file has to be uploaded as a file instead of base64. So I believe building the directive to take a file instead would be better and would suit the overall implementation that's needed.

@sudheesh001 , we can use the custom parser mentioned here https://github.com/adonespitogo/angular-base64-upload#custom-parser to directly work with the file object.

This feature does not work fully. Please close when this feature has been fully tested and confirmed to work on test site.

Please check this: I uploaded an image for a wall. It all works fine. Now I create another wall without an image. When I generate the second wall suddenly the image of the previous wall is there.

@mariobehling I could not reproduce this. Can you give me the exact steps please?

Ok, seems to be solved now. But at the moment tweets are not loading on any wall.
Also I get an error message from Firefox preventing the new tab for the wall.

This is quite strange, as I have not changed that part of the code which opens these tabs. They are simple hyperlinks with target=_blank. If this problem was not appearing earlier, there should be no reason it is happening now unless the browser settings have changed.
Also, I just tried it in firefox and could not reproduce this.

Ok, the walls are back. Seems it was a temporary glitch. Please check the wall on Fx. It might have been related to another code change.


Add OSR Town Hall slidedeck

PR adds the Town Hall slidedeck into the BIDS-materials folder and adds a note to the Town Hall announcement blogpost

thanks @franklin-feingold


NextJS re-scaffold

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

main

PR #8

PR #9

PR #10

PR #11   👈

This stack of pull requests is managed by Graphite.


Questions for migrations

Hello, I started the migration to Vue3, however, right away, I already had a problem.
The view-design library doesn't support vue3, only vue1 or vue2, do you have any suggestions of what we can use to replace it?

Just looking at this issue, you can use iview-plus, which supports vue3. With iview-plus, we hardly need to change the logic of the component.
刚刚看到这个issue，可以使用iview-plus，支持vue3，使用iview-plus我们几乎不用修改组件的逻辑。


List item indentation

Update list item formatting code to make indentation dependent on the minimum header number.
See https://github.com/ekalinin/github-markdown-toc.go/issues/8.

Thanks!


[PAGOPA-1588] feat: add bulk update

List of Changes

Add bulk UPDATE API

Motivation and Context

Massive Debt Position Update

How Has This Been Tested?

Unit test

Screenshots (if appropriate):
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

@AngeloCaporaso resolve conflict


printing cost doesn't have units

calling print sol['cost'] prints out a number with no units
In [6]: print sol['cost']
107901.244071

the units should be lbf. If I do print sol('W_{ftotal}') (printing the variable that is the models cost) then I get<PHONE_NUMBER>49 force_pound as expected

Yeah, cost is currently stored as a scalar. This should be fixed.


Too much CPU usage with TextField caret on macOS

Details

Target Platform: macOS
Target OS version/browser: Big sur 11.4 (20F71)
Devices: MacBook Pro (16-inch, 2019)
A simple flutter application (which only contains a TextField widget), but it takes up 10% of the CPU.

Reproduce

copy this code to your example project main.dart.

import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({Key? key}) : super(key: key);

  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const Scaffold(
        body: TextField(autofocus: true),
      ),
    );
  }
}

flutter run -d macos --profile

We could use command top to check our flutter_app CPU usage: top -pid `pgrep flutter_app`

Logs

Logs

➜  flutter_app flutter analyze
Analyzing flutter_app...
No issues found! (ran in 1.3s)

➜  flutter_app flutter doctor -v
[✓] Flutter (Channel master, 2.3.0-17.0.pre.632, on macOS 11.4 20F71 darwin-x64, locale zh-Hans-CN)
    • Flutter version 2.3.0-17.0.pre.632 at /Users/yangbin/dev/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision dbd3f0e0d8 (5 hours ago), 2021-07-02 06:06:03 -0400
    • Engine revision 314cf7a4f2
    • Dart version 2.14.0 (build 2.14.0-269.0.dev)

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.5.1, Build version 12E507
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.2)
    • Android Studio at /Users/yangbin/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.7351085/Android
      Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] Android Studio (version 4.2)
    • Android Studio at /Users/yangbin/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.7351085/Android
      Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] Android Studio (version 4.2)
    • Android Studio at /Users/yangbin/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/202.7322048/Android
      Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6916264)

[✓] IntelliJ IDEA Ultimate Edition (version 2021.1.2)
    • IntelliJ at /Users/yangbin/Applications/JetBrains Toolbox/IntelliJ IDEA Ultimate.app
    • Flutter plugin version 57.0.5
    • Dart plugin version 211.7233

[✓] IntelliJ IDEA Ultimate Edition (version 2021.1.2)
    • IntelliJ at /Users/yangbin/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/211.7442.40/IntelliJ IDEA.app
    • Flutter plugin version 56.0.5
    • Dart plugin version 211.7233

[✓] IntelliJ IDEA Ultimate Edition (version 2021.1.1)
    • IntelliJ at /Users/yangbin/Library/Application Support/JetBrains/Toolbox/apps/IDEA-U/ch-0/211.7142.45/IntelliJ IDEA.app
    • Flutter plugin version 56.0.5
    • Dart plugin version 211.7233

[✓] VS Code (version 1.57.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.23.0

[!] Proxy Configuration
    • HTTP_PROXY is set
    ! NO_PROXY is not set

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-x64     • macOS 11.4 20F71 darwin-x64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 91.0.4472.114

! Doctor found issues in 2 categories.

Although, for me this happens when targetting the iPhone simulator, but similarly the system slows down crazily when there is a TextField focused, usually I just cmd+shift+h the app down when I go back to develop, or rather use my Android device

No only TextFiled too much CPU, If show an animation photo on Image face the same problem.

Hi @boyan01,
Thanks for filing the issue, I am able to reproduce this issue on the latest stable channel when the app runs the cpu % is on average around 1-2 % but as I focus on the textfield the cpu % jumps to more than 10%  and when the focus is lost back to 1-2 %
Here are the stats in different modes

Release: max upto 10%
Profile: 13-15 %
Debug mode goes beyond 20%

Release

CPU Usage Preview for Release Mode

Textfield unfocused

Textfield focused

Profile

CPU Usage Preview for Profile Mode

Textfield unfocused

Textfield focused

Debug

CPU Usage Preview for Debug Mode

Textfield unfocused

Textfield focused

Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(
    MaterialApp(home: TextFieldWidget()),
  );
}

class TextFieldWidget extends StatefulWidget {
  const TextFieldWidget({Key? key}) : super(key: key);

  @override
  _TextFieldWidgetState createState() => _TextFieldWidgetState();
}

class _TextFieldWidgetState extends State<TextFieldWidget> {
  @override
  Widget build(BuildContext context) {
    return GestureDetector(
      onTap: () => FocusScope.of(context).unfocus(),
      child: Scaffold(
        body: TextField(),
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel stable, 2.2.3, on macOS 11.4 20F71 darwin-arm, locale en-IN)
    • Flutter version 2.2.3 at /Users/mahesh/Documents/flutter
    • Framework revision f4abaa0735 (5 days ago), 2021-07-01 12:46:11 -0700
    • Engine revision 241c87ad80
    • Dart version 2.13.4

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] IntelliJ IDEA Community Edition (version 2021.1.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 57.0.5
    • Dart plugin version 211.7233

[✓] VS Code (version 1.57.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.24.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 11.4 20F71 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 91.0.4472.114

• No issues found!

[✓] Flutter (Channel master, 2.4.0-1.0.pre.78, on macOS 11.4 20F71 darwin-arm, locale en-IN)
    • Flutter version 2.4.0-1.0.pre.78 at /Users/mahesh/Documents/flutter_master
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 761d568421 (24 hours ago), 2021-07-05 05:21:03 -0400
    • Engine revision 37e3922ae8
    • Dart version 2.14.0 (build 2.14.0-276.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at /Users/mahesh/Library/Android/sdk
    • Platform android-30, build-tools 30.0.3
    • ANDROID_HOME = /Users/mahesh/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 12.4, Build version 12D4e
    • CocoaPods version 1.10.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6915495)

[✓] IntelliJ IDEA Community Edition (version 2021.1.2)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 57.0.5
    • Dart plugin version 211.7233

[✓] VS Code (version 1.57.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.24.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 11.4 20F71 darwin-arm
    • Chrome (web)    • chrome • web-javascript • Google Chrome 91.0.4472.114

• No issues found!

CC @justinmc @LongCatIsLooong

+1 The same on device, moving the caret is not as smooth as it should be, compared with android and other applications on iOS.

The devtools come with a CPU profiler: https://flutter.dev/docs/development/tools/devtools/performance#cpu-profiler which gives you a breakdown of the CPU time consumed and other helpful information. Could you try that instead of the OS activity monitor?

The devtools come with a CPU profiler: https://flutter.dev/docs/development/tools/devtools/performance#cpu-profiler which gives you a breakdown of the CPU time consumed and other helpful information. Could you try that instead of the OS activity monitor?

Here's the CPU profiler JSON exported.
dart_devtools_2021_7_12-1626077798510000.json.zip

Now that Flutter is official supported on macOS, I tried a few Flutter apps today and immediately spotted this issue with the applications I tried. The caret is forcing a redraw of the whole window. If you enable Apple's Quartz debug tool it's easy to spot. Depending on the complexity of the app, this can be very expensive.

Now that Flutter is official supported on macOS, I tried a few Flutter apps today and immediately spotted this issue with the applications I tried. The caret is forcing a redraw of the whole window. If you enable Apple's Quartz debug tool it's easy to spot. Depending on the complexity of the app, this can be very expensive.

Have you tried setting the text field within a repaint boundary? If the issue truly lies within the entire window being repainted, this ought solve it.


adding new host. clarify process.

I have issue with one of the hosts not working as expected (application instances launched there are not accessible). After a long time trying to fix it, I decided to replace the host with another one, who would have fresh install.
However, after following instructions in documentation, I could not get new host to register.
What I did was:

create new server
install flynn (with the same version (1709) as other nodes.
run 'flynn-host init --init-discovery' in one of the existing, good, nodes
run 'flynn-host init --discover $url' on the new node

and nothing happens. new node does not appear in the 'flynn-host list'
what am I doing wrong?

any ideas how to do this? one of the tree hosts is never responding to any requests, and there seems to be no way how to replace it :/
I have to keep manually rescaling app to kill processes from this node and replace them with other :/

Adding hosts and Replacing hosts
Basically just init a new host, demote the failing host, add the new host as a consensus member.

as you can see in my comment below - this is what I did, and nothing happened. Can you please explain what I did wrong?

You don't init a new discovery, you use the current cluster discovery token. It can be found in an existing host's /etc/flynn/host.json.

So in concise steps:

Install same version of Flynn
On new host run flynn-host init --discovery https://discovery.flynn.io/clusters/${discovery_token}
Restart flynn-host
New host has joined the cluster.

ok, my new host joined!  Now discoverd is down completely after timeout and there is no way of reviving it. fix with --min-hosts-3 and peer-ips finds everything, but then times out after waiting for web contorller to start.
Now this is scary, cluster is uncontrollable :/

and nothing int he flynn-host.log either. How can system fail with error messages and produce no logs :(

ok, restarting flynn-host services on each node made 'flynn-host list' to work again ... but all the apps are down now.

ok, after bricking all the flynn installation for second time I have ended my around two year journey in using it in production. halas. Days worth of work and I have rebuilt everything using docker swarm and traefik.

@martunta do you have your setup (traefik + flynn) documented somewhere?

not really. sorry.
On Wed, Jul 24, 2019 at 2:30 PM Alexander Adam<EMAIL_ADDRESS>wrote:

@martunta https://github.com/martunta do you have your setup (traefik +
flynn) documented somewhere?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/flynn/flynn/issues/4396?email_source=notifications&email_token=AAKVRKNEHPKPMGYO6MGFCSLQBAVLJA5CNFSM4FCTHOG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2V5CQA#issuecomment-514576704,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKVRKP5AVYUVXZ2XUG4TX3QBAVLJANCNFSM4FCTHOGQ
.


Invalid Record TTL

The client already expresses the TTL in seconds, so the provider should not multiply it by time.Second again.
See client.go
record := libdns.Record{
    Name:  libdns.AbsoluteName(*rrset.Name, zone),
    Value: *rrsetRecord.Value,
    Type:  *rrset.Type,
    TTL:   time.Duration(*rrset.TTL) * time.Second,
}

This is an issue because if the caller uses those records to interact with the AWS SDK again, the TTL overflows an int64 TTL:  aws.Int64(int64(record.TTL.Seconds())) leading to invalid input errors when applying new changes:
InvalidInput: 1 validation error detected: Value '-7780919223' at 'changeBatch.changes.1.member.resourceRecordSet.tTL' failed to satisfy constraint: Member must have value greater than or equal to 0

@PhoenixPeca do you mind taking a look? I believe the records being returned have invalid TTLs causing an int64 overflow


Add Lset command

Related to #124

Separat the logic to get seq into a separate function.
Add error case ErrWrongIndex.
Add tests.

Please review when you have time.

I found there is a func listSequence duplicates with my func will be added in my next pr, i will wait for this pr merged and then add pr.

LGTM


Bump vagrant box version for tests to 151

This change is

test-me-please

Coverage decreased (-0.03%) to 41.771% when pulling 215cc238354e6808f0d3cb0bcdf35d7ced131b7e on nebril:bump-box-version-to-151 into 0f36e6e77cc4b4b0fa9e1bcb0c535e3383cbe060 on cilium:master.

test-docs-please

test-me-please


Update FourierTransform to handle external datetime timestamp

🚀 Feature Request
Currently FourierTransform doesn't handle external datetime timestamp, but it could be done.
Proposal

Doesn't fail on datetime external timestamp in FourierTransform

Use determine_num_steps
Update documentation about this, make a note that can work slow

Test cases
Update tests.
Additional context
No response

Closed by #223.


Feature request: Packet Radio/APRS Data Transceiver (Kiss-Mode via Serial)

It would be great if you could turn the UV-K5 into a packet radio data transceiver that supports the KISS-Prtokoll to communicate with the PC and the application. The coding and decoding of the 1k2 baud audio signal would need to be done by the radio. This would substitute an expensive Kenwood TH-D74 or TH-D75 in Kiss-Mode for 1k2 APRS and PacketRadio.
73 & 55 de Stephan 9V1LH / DG1BGS

Thank you for your comment.
I also confirmed in other codes that the Kiss protocol has the same
physical protocol as APRS.
In particular, the decode source I recently found supported the kiss
protocol.
I would probably be able to apply if I had an environment where I could
test the kiss protocol.
Ian KD8CEC
On Mon, Apr 1, 2024 at 7:05 PM Stephan @.***> wrote:

It would be great if you could turn the UV-K5 into a packet radio data
transceiver that supports the KISS-Prtokoll to communicate with the PC and
the application. The coding and decoding of the 1k2 baud audio signal would
need to be done by the radio. This would substitute an expensive Kenwood
TH-D74 or TH-D75 in Kiss-Mode for 1k2 APRS and PacketRadio.
73 & 55 de Stephan 9V1LH / DG1BGS
—
Reply to this email directly, view it on GitHub
https://github.com/phdlee/uvk5cec/issues/47, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AE4DZPDKCAVJVGHKH3FRQG3Y3EWQFAVCNFSM6AAAAABFRMA3PGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYTOOJWGAYTANY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


window.ipfs all_frames?

Currently the content script that injects window.ipfs is set to inject itself in all_frames. This means that if a page has an iframe on it, it will also get a window.ipfs object.
https://github.com/ipfs-shipyard/ipfs-companion/blob/b968f01358788d9f581cd70b0ec5eb13b5ad3f05/add-on/manifest.json#L64
What is everyone feeling on dialing this down to false before we release, and then potentially dialing it up in the future if it's requested? I'm thinking performance and security might be a concern.

How much overhead is there really with injecting it?
Iframes will have security scoped to to the origin within the iframe, right? I don't think there's any security issues there other than the ones that exist for having window.ipfs at all.

I've seen a short-lived "the webpage is slowing down your browser" warning a few times, but it was after extension was reloaded via R in web-ext in developer mode.
Not sure it happens "in production", but I'd say we should keep "all_frames": true enabled in dev channel for now, so that if performance problem exists, people can report it.
As for disabling it before stable release, I added decision to release checklist at #347

roger roger


Updates to Stable component process.

Signed-off-by: Artur Souza<EMAIL_ADDRESS>Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:

[ ] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[ ] Read the contribution guide
[ ] Commands include options for Linux, MacOS, and Windows within codetabs
[ ] New file and folder names are globally unique
[ ] Page references use shortcodes instead of markdown or URL links
[ ] Images use HTML style and have alternative text
[ ] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:
Description
Adds stable candidate  step.
Changes requirement from 1 to 2 approvers for component to be stable.
Issue reference

Have all Component  Contrib maintainers agreed to this?

I would say we should get the approval of two contrib maintainers to call something stable, but needing to maintainers to merge a PR in certification tests doesn't seem like a good idea.
We should refine the details a little bit here.
Can we have a yaml file at the root of contrib where we track what is stable and then require two maintainers to modify that file?

@greenie-msft we have not - we need to separately discuss this. And that does not need to happen timed with release 1.8
Personally I think we should do this:

Keep a file in the contrib repo of stable components. Modifying that file requires 2 maintainers to approve / author the PR.
Certification tests themselves however will continue to require one maintainer as before. This is important because I want to decouple the development (especially iterative development) of certification tests from the actual stable certification.

For the first point, can we use these https://github.com/dapr/docs/tree/v1.7/daprdocs/data/components since this is what John did this for in the docs?

@greenie-msft we have not - we need to separately discuss this. And that does not need to happen timed with release 1.8
Personally I think we should do this:

Keep a file in the contrib repo of stable components. Modifying that file requires 2 maintainers to approve / author the PR.
Certification tests themselves however will continue to require one maintainer as before. This is important because I want to decouple the development (especially iterative development) of certification tests from the actual stable certification.

For the first point, can we use these https://github.com/dapr/docs/tree/v1.7/daprdocs/data/components since this is what John did this for in the docs?

@greenie-msft I really want that to be separate from documentation that is shown. It should be more of an internal file to keep track of technical decision-making.
As long as we set up the permissions such that ONLY contrib maintainers can provide reviews and approvals for that file (via CODEOWNERS) I'm fine with having this anywhere. Even Docs maintainers should not be allowed to approve changes to this. That's the entire point - our tooling must enforce that two contrib maintainers are involved.

This is not applicable anymore since we do not require stable candidates.


Use docker alpine

Also this is a parallel of #27.

Like mentioned on #27, building LLVM takes so much time as we can't spend by having a cup of tea ☕
So I'm now preparing a docker image which has LLVM already.

https://github.com/capra314cabra/docker-llvm-alpine

Now, the build of the sources finished successfully but it's less optimized. I have to make myself the stage of deleting wastes🗑 .

OK! It works fine! I will merge this.
There are much more commits on this branch than I have expected. 😖


Fix for race condition

We ran into a race condition where a viewController can subscribe upon loading, update and before the subscription gets added to the subscription list, an event can be fired with an update. The result is that the ViewController doesn't get updated for that event.
In our case, we are blocking the UI while we fire a command to tell us what segue to fire and that command is finishing before the viewController is added to the list of subscriptions in certain conditions, leaving the ViewController indefinitely frozen. From our testing, this fix should rectify that problem.

Fixed a different way in #20.


bring back catch all virtual host caching

This PR brings the caching of catchallvirtualhost back and only creates a copy when there is an envoy filter. So only users who use it pay the price.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security-multicluster_istio
3133940d848f6b97116d46901dc4a4189173907f
link
true
/test integ-security-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-security-multicluster_istio

/test integ-security-multicluster_istio

Agree with John, and I believe the catchall build is not a perf bottle neck now.  Minor improvement vs bad readability, we need to weigh off

While I agree that we need a generic solution for all such cached things (again I do not know how to do - may be Envoy filters code should have its own generic merge logic like copyonwrite that checks if it is in the cached list, just do a clone and merge), What is the issue with readability there though?

@howardjohn @hzxuzhonghu I tried to make the merge generic and implemented for routes. Please see if this makes sense. I can change other patch merges.

Yes. I want to add that complexity if we are 9k with this approach
On Fri, 18 Mar 2022, 21:30 John Howard, @.***> wrote:

@.**** commented on this pull request.
In pilot/pkg/networking/core/v1alpha3/envoyfilter/rc_patch.go
https://github.com/istio/istio/pull/37762#discussion_r830138503:

@@ -251,7 +256,7 @@ func patchHTTPRoute(patchContext networking.EnvoyFilter_PatchContext,
*routesRemoved = true
return
} else if rp.Operation == networking.EnvoyFilter_Patch_MERGE {

		proto.Merge(virtualHost.Routes[routeIndex], rp.Value)

		safeMerge(virtualHost.Routes[routeIndex].Name, virtualHost.Routes[routeIndex], rp.Value)

safeMerge is not recursively checking the name to see if its safe, so
don't we end up with an issue if we merge at a high level? For example:
knownCatchedObjects := ["foo"]
x := {bar:{foo:{}}}
safeMerge(x, ...)
We will check name (bar), but then merge and foo will get overwriten
—
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/37762#pullrequestreview-914555692,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AEDINKGFSUOIZDT2LKNC3FLVASSATANCNFSM5QA3B2ZA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Can you test how much time does buildCatchallVhost saves?

And then compare with deepcopy

Can you test how much time does buildCatchallVhost saves?

DeepCopy will always be slower than rebuilding. But the point here,  user who have catchAlllvirtualhost  mutating envoy filter will only pay the price.
Another option I was thinking is to detect that an envoy filter exists for catchAll and then build it always rather than using this complicated safe merge.  The catchAllvirtualhost might yield trivial benefit with caching, but I am trying to come up with generic solution so that we get the optimizations for normal users and people who have such envoy filters will pay the price.

I mean if a new buildCatchallVhost   just cost ns level, we do not care about it.

I mean if a new buildCatchallVhost just cost ns level, we do not care about it.

Yes for buildCatchallVhost - It is not a big deal. But I am thinking of generic solution to get benefits of both optimized code for this and socket matches + any thing that comes in future and making it work with envoy filters.

The generic way looks meaningful if https://github.com/istio/istio/pull/37762#discussion_r830138503 can be resolved

The generic way looks meaningful if https://github.com/istio/istio/pull/37762#discussion_r830138503 can be resolved

I am exploring that option

@ramaraochavali: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
0aca3ff75f530f749ad602e2146ee6e9177d9987
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
0aca3ff75f530f749ad602e2146ee6e9177d9987
link
true
/test lint_istio

unit-tests_istio
0aca3ff75f530f749ad602e2146ee6e9177d9987
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
0aca3ff75f530f749ad602e2146ee6e9177d9987
link
true
/test lint_istio

unit-tests_istio
0aca3ff75f530f749ad602e2146ee6e9177d9987
link
true
/test unit-tests_istio

gencheck_istio
0aca3ff75f530f749ad602e2146ee6e9177d9987
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless_istio
9c417ca307a394880661662e46c6d44da696b57b
link
true
/test integ-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-distroless_istio

@howardjohn PTAL, if this makes sense

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
e17b3638b9fe296046023ca7067a601dcecc30b8
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@howardjohn PTAL. Addressed comments

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
e17b3638b9fe296046023ca7067a601dcecc30b8
link
true
/test unit-tests_istio

integ-distroless_istio
e17b3638b9fe296046023ca7067a601dcecc30b8
link
true
/test integ-distroless_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless_istio
e17b3638b9fe296046023ca7067a601dcecc30b8
link
true
/test integ-distroless_istio

unit-tests_istio
e17b3638b9fe296046023ca7067a601dcecc30b8
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-distroless_istio
e17b3638b9fe296046023ca7067a601dcecc30b8
link
true
/test integ-distroless_istio

unit-tests_istio
e17b3638b9fe296046023ca7067a601dcecc30b8
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
e17b3638b9fe296046023ca7067a601dcecc30b8
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
e17b3638b9fe296046023ca7067a601dcecc30b8
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test unit-tests_istio

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
81a75424416a4a0f034607058952b8b72d5ea7c4
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
54821ce305849969d0d801e0809f10d8ddbc4d5b
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
54821ce305849969d0d801e0809f10d8ddbc4d5b
link
true
/test unit-tests_istio

integ-pilot-istiodremote-mc_istio
54821ce305849969d0d801e0809f10d8ddbc4d5b
link
true
/test integ-pilot-istiodremote-mc_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
54821ce305849969d0d801e0809f10d8ddbc4d5b
link
true
/test unit-tests_istio

integ-pilot-istiodremote-mc_istio
54821ce305849969d0d801e0809f10d8ddbc4d5b
link
true
/test integ-pilot-istiodremote-mc_istio

integ-pilot-multicluster_istio
54821ce305849969d0d801e0809f10d8ddbc4d5b
link
true
/test integ-pilot-multicluster_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ramaraochavali: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
54821ce305849969d0d801e0809f10d8ddbc4d5b
link
true
/test unit-tests_istio

integ-pilot-istiodremote-mc_istio
54821ce305849969d0d801e0809f10d8ddbc4d5b
link
true
/test integ-pilot-istiodremote-mc_istio

integ-pilot-multicluster_istio
54821ce305849969d0d801e0809f10d8ddbc4d5b
link
true
/test integ-pilot-multicluster_istio

integ-pilot_istio
54821ce305849969d0d801e0809f10d8ddbc4d5b
link
true
/test integ-pilot_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn @hzxuzhonghu PTAL. Any further concerns on this? My goal was to to build this generically so that any cached message can use it - I realize that just for passThroughClusters, we may not need this complexity as the gains are not much.