Fix basis_count checking in ConsolidateBlocks

Summary
The ConsolidateBlocks pass was ported to rust in #13368 and as part of that implementation a small behavior difference between the rust and python interfaces was causing the pass to not work correctly with non-CX gates. The internal 2q decomposer interface stores a sentinel string for the kak gate which is used to tell the python space constructor use the python defined gate object. However in the pass code we weren't factoring this difference in, and for non-CX gates we were evaluating the basis count as the number of gates with that sentinel value name (which is almost always zero) and this was preventing the pass from consolidating many blocks that should have been. This commit fixes this issue by taking the name from python space and passing it through to the rust portion of the code and using that for the comparison.
Details and comments
Fixes #13459

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
13 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.008%) to 88.927%

Files with Coverage Reduction
New Missed Lines
%

crates/accelerate/src/two_qubit_decompose.rs
3
92.13%

crates/qasm2/src/lex.rs
4
91.73%

crates/qasm2/src/parse.rs
6
96.69%

Totals

Change from base Build<PHONE_NUMBER>7:
-0.008%

Covered Lines:
79397

Relevant Lines:
89283

💛  - Coveralls


WIP: Simplify the entire crate

Not the best pull request title I've ever written, but it's very fitting.
This pull request contains significant changes to the crius crate that our repository is forked from. Most notably:

several of the internal and external structures used in crius have been merged into Command
asynchronous execution of breaker commands via thread pools has been removed. Handling of non-synchronous execution is now up to the library user.
the error type used by breaker commands is now parameterised and can be set by the user, granted that they implement From<crius::error::CriusError>
a new (slightly opinionated) public API is provided

I'm submitting this PR here so that you can decide whether you're interested in it or not, otherwise we'll be tracking the project at aprilabank/master with our simplifications.
Totally understandable if you're not interested in the PR for your project, considering that it contains very significant changes.


test: Add test cases related to each mode of SM4

Added test cases for SM4 algorithm CBC, OFB, CFB and CTR mode.
Test data comes from:
https://tools.ietf.org/id/draft-ribose-cfrg-sm4-10.html
Signed-off-by: Tianjia Zhang<EMAIL_ADDRESS>
Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

I think that these cases should be added to test/recipes/30-test_evp_data/evpciph_sm4.txt not implemented in the internal test.

I think that these cases should be added to test/recipes/30-test_evp_data/evpciph_sm4.txt not implemented in the internal test.

I agree, I'm sorry I didn't notice the test data here, this PR should be negligible.


Update Homekit climate.py to remap current mode

This update changes the mapping of Homekit's Current Mode Heating/Cooling State to show the HASS hvac_action attribute as "idle" instead of "off" when the returned value is 0.

entity:  climate.icomfort_s30
operation:    Heat
hvac_modes: off,heat,cool,heat_cool
current_temperature: 57
min_temp: 40
max_temp: 90
temperature: 55
current_humidity: 57
hvac_action: idle
friendly_name: Downstairs Thermostat
supported_features: 1

Breaking Change:

Description:
Related issue (if applicable): related to discussion in  issue #20885
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:

[x ] The code change is tested and works locally
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[ ] I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @GaryOkie,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Just had a quick look at the tests here - theres an off here that might need changing as well.

I thought that by doing a new PR to update test_climate.py to change the assert hvac_action from off to idle, that these errors would be cleared.    That PR passed, but that alone did not solve this.   Somewhere else it's picking up the original test code I guess.      Sorry, but I have not found out how to make these tests pass.

Hey sorry was afk but it looks like you figured it out and everything is happy and passing. Everything looks good here - I would say that the comment you added to the test isn’t needed. It’s best not to refer to changes like that - we will be able to see this commit in ‘git annotate’. Your comments show be more in the present - you could say “Ensure we handle when the device is in heating mode but idle”. The fact that it’s a change is meaningless the second we merge it.
Other than that, well done. If you can edit that then I can approve it tonight / tomorrow

What the heck?!   Removing a comment in test_climate.py somehow leads to a new error with a xiaomi vacuum (test_xiaomi_exceptions.py)???

Flaky tests happen some time - don’t worry about it. A dev can request a rebuild if it happens - I’ll see if I have permission when I’m at my desk. If a test is flaky we disable it or get it’s dev to fix it but some of them are really rare failures

So the test_climate test is run along with the included test code for every component.  If any of those tests has an error, the check will fail.  The developer of the test that failed needs to be contacted to fix it before I can run the check again?
Is that what we're waiting on now?   Just trying to better understand this HA/Git PR check process!

So yes, every change gets the whole test suite run against it. It could be that the homekit tests somehow rely on homekit_controller to run an integration test (they don't) and this change actually broke their tests. The only way to be sure is to run all the tests every time.
But no, that doesn't neccesarily mean you are blocked and waiting for the other developer. As it's a flaky test running the tests again may actually get it to go green. In reality you were waiting for me to be near a computer and remember that home assistant was a thing 😊 (very busy at the moment).
The checks are re-running now.

This is a breaking change, right?

I'll defer to @jc2k as I'm new at this, but yeah, it's possible that someone could be using "hvac_action" in an automation and testing for "off", which would now (properly) state "idle".

Please add a paragraph under the breaking change header in the PR description. Briefly describe what has changed and what the user needs to do to cope with the breaking change, as you've already outlined above.

OK, will do.   Sorry that it never occurred to me before until you asked that this could possibly break an automation.   It just seemed like a simple semantics update initially!

Good call as ever @MartinHjelmare - had just seen it as a simple bug fix but you are right.
And thank you @GaryOkie for the quick turn around on the breaking change text. Looks like a good description of the change to me :+1:


About page - title section

Description
create the title section and only the space for the carrousel,
carrousel will be made on a separate issue.
! create a component called AboutTitle.tsx and link it to the page.tsx located in 'About' folder
Screenshots
No response
Additional information
Notice spacing, margins, paddings, colors etc.
all here

On it

Done, I would love some feedback if possible


permission issues in docker container.

Hi, I did docker-compose up -d server and docker-compose logs prints
server_1   | 2017.08.08 15:48:30.658433 [ 1 ] <Warning> Application: Logging to console
server_1   | 2017.08.08 15:48:30.661742 [ 1 ] <Information> : Starting daemon with revision 54245
server_1   | 2017.08.08 15:48:30.661847 [ 1 ] <Information> Application: starting up
server_1   | 2017.08.08 15:48:30.692033 [ 1 ] <Debug> Application: rlimit on number of file descriptors is 1048576
server_1   | 2017.08.08 15:48:30.692065 [ 1 ] <Debug> Application: Initializing DateLUT.
server_1   | 2017.08.08 15:48:30.692074 [ 1 ] <Trace> Application: Initialized DateLUT with time zone `Zulu'.
server_1   | 2017.08.08 15:48:30.699524 [ 1 ] <Debug> Application: Configuration parameter 'interserver_http_host' doesn't exist or exists and empty. Will use 'bb91223e124a' as replica host.
server_1   | 2017.08.08 15:48:30.699623 [ 1 ] <Debug> ConfigReloader: Loading config `/etc/clickhouse-server/users.xml'
server_1   | 2017.08.08 15:48:30.702814 [ 1 ] <Warning> ConfigProcessor: Include not found: networks
server_1   | 2017.08.08 15:48:30.702833 [ 1 ] <Warning> ConfigProcessor: Include not found: networks
server_1   | 2017.08.08 15:48:30.702898 [ 1 ] <Warning> ConfigProcessor: Couldn't save preprocessed config to /etc/clickhouse-server/users-preprocessed.xml: Access to file denied: /etc/clickhouse-server/users-preprocessed.xml
server_1   | 2017.08.08 15:48:30.703145 [ 1 ] <Information> Application: Loading metadata.
server_1   | 2017.08.08 15:48:30.715188 [ 1 ] <Information> DatabaseOrdinary (system): Total 1 tables.
server_1   | 2017.08.08 15:48:30.719014 [ 1 ] <Information> BackgroundProcessingPool: Create BackgroundProcessingPool with 16 threads
server_1   | 2017.08.08 15:48:30.723380 [ 1 ] <Debug> system.query_log (Data): Loading data parts
server_1   | 2017.08.08 15:48:31.212949 [ 1 ] <Debug> system.query_log (Data): Loaded data parts (3 items)
server_1   | 2017.08.08 15:48:31.215159 [ 1 ] <Information> DatabaseOrdinary (system): Starting up tables.
server_1   | 2017.08.08 15:48:31.244900 [ 1 ] <Information> DatabaseOrdinary (default): Total 1 tables.
server_1   | 2017.08.08 15:48:31.255455 [ 2 ] <Debug> default.ontime (Data): Loading data parts
server_1   | 2017.08.08 15:48:31.257986 [ 2 ] <Debug> default.ontime (Data): Loaded data parts (0 items)
server_1   | 2017.08.08 15:48:31.260757 [ 1 ] <Information> DatabaseOrdinary (default): Starting up tables.
server_1   | 2017.08.08 15:48:31.261415 [ 1 ] <Debug> Application: Loaded metadata.
server_1   | 2017.08.08 15:48:31.261833 [ 1 ] <Information> Application: Listening http://<IP_ADDRESS>:8123
server_1   | 2017.08.08 15:48:31.261898 [ 1 ] <Information> Application: Listening tcp: <IP_ADDRESS>:9000
server_1   | 2017.08.08 15:48:31.261967 [ 1 ] <Information> Application: Listening interserver: <IP_ADDRESS>:9009
server_1   | 2017.08.08 15:48:31.262209 [ 1 ] <Information> Application: Available RAM = 78.46 GiB; physical cores = 12; threads = 24.
server_1   | 2017.08.08 15:48:31.262230 [ 1 ] <Information> Application: Ready for connections.
server_1   | 2017.08.08 15:48:32.699869 [ 3 ] <Debug> ConfigReloader: Loading config `/etc/clickhouse-server/config.xml'
server_1   | 2017.08.08 15:48:32.706203 [ 3 ] <Warning> ConfigProcessor: Include not found: clickhouse_remote_servers
server_1   | 2017.08.08 15:48:32.706345 [ 3 ] <Warning> ConfigProcessor: Include not found: clickhouse_compression
server_1   | 2017.08.08 15:48:32.706542 [ 3 ] <Warning> ConfigProcessor: Couldn't save preprocessed config to /etc/clickhouse-server/config-preprocessed.xml: Access to file denied: /etc/clickhouse-server/config-preprocessed.xml

I'm not sure if those warnings are harmful. Http client works but clickhouse-client fails to connect. netstat -atpn doesn't show port 9000.

About warnings:
Include not found: clickhouse_compression

These are totally fine.
About
Couldn't save preprocessed config

This is not harmful, but also isn't good.
Preprocessed config is dumpred mostly for informational purposes.
(It could be used by server in rare cases: if configuration file have some substitutions from ZooKeeper and ZooKeeper is not available during restart.)
I have the same issue with port 9000:
milovidov@milovidov-desktop:~/work/ClickHouse/docker$ docker-compose up -d server
Starting clickhouse_server_1 ...
Starting clickhouse_server_1 ... done
milovidov@milovidov-desktop:~/work/ClickHouse/docker$ clickhouse-client
ClickHouse client version 1.1.54260.
Connecting to localhost:9000.
Code: 210. DB::NetException: Connection refused: (localhost:9000, <IP_ADDRESS>)

milovidov@milovidov-desktop:~/work/ClickHouse/docker$ curl http://localhost:8123/
Ok.
milovidov@milovidov-desktop:~/work/ClickHouse/docker$ docker-compose logs
Attaching to clickhouse_server_1
server_1   | Include not found: clickhouse_remote_servers
server_1   | Include not found: clickhouse_compression
server_1   | 2017.08.08 19:12:40.101399 [ 1 ] <Warning> Application: Logging to console
server_1   | 2017.08.08 19:12:40.105021 [ 1 ] <Information> : Starting daemon with revision 54245
server_1   | 2017.08.08 19:12:40.105120 [ 1 ] <Information> Application: starting up
server_1   | 2017.08.08 19:12:40.105794 [ 1 ] <Debug> Application: Set max number of file descriptors to 1048576 (was 524288).
server_1   | 2017.08.08 19:12:40.105808 [ 1 ] <Debug> Application: Initializing DateLUT.
server_1   | 2017.08.08 19:12:40.105813 [ 1 ] <Trace> Application: Initialized DateLUT with time zone `Zulu'.
server_1   | 2017.08.08 19:12:40.106543 [ 1 ] <Debug> Application: Configuration parameter 'interserver_http_host' doesn't exist or exists and empty. Will use '138db0390886' as replica host.
server_1   | 2017.08.08 19:12:40.106684 [ 1 ] <Debug> ConfigReloader: Loading config `/etc/clickhouse-server/users.xml'
server_1   | 2017.08.08 19:12:40.109290 [ 1 ] <Warning> ConfigProcessor: Include not found: networks
server_1   | 2017.08.08 19:12:40.109315 [ 1 ] <Warning> ConfigProcessor: Include not found: networks
server_1   | 2017.08.08 19:12:40.109996 [ 1 ] <Information> Application: Loading metadata.
server_1   | 2017.08.08 19:12:40.110491 [ 1 ] <Information> DatabaseOrdinary (default): Total 0 tables.
server_1   | 2017.08.08 19:12:40.110509 [ 1 ] <Information> DatabaseOrdinary (default): Starting up tables.
server_1   | 2017.08.08 19:12:40.110578 [ 1 ] <Debug> Application: Loaded metadata.
server_1   | 2017.08.08 19:12:40.110883 [ 1 ] <Information> Application: Listening http://<IP_ADDRESS>:8123
server_1   | 2017.08.08 19:12:40.110921 [ 1 ] <Information> Application: Listening tcp: <IP_ADDRESS>:9000
server_1   | 2017.08.08 19:12:40.110953 [ 1 ] <Information> Application: Listening interserver: <IP_ADDRESS>:9009
server_1   | 2017.08.08 19:12:40.111089 [ 1 ] <Information> Application: Available RAM = 5.63 GiB; physical cores = 2; threads = 4.
server_1   | 2017.08.08 19:12:40.111099 [ 1 ] <Information> Application: Ready for connections.
server_1   | 2017.08.08 19:12:42.106762 [ 2 ] <Debug> ConfigReloader: Loading config `/etc/clickhouse-server/config.xml'
server_1   | 2017.08.08 19:12:42.109354 [ 2 ] <Warning> ConfigProcessor: Include not found: clickhouse_remote_servers
server_1   | 2017.08.08 19:12:42.109428 [ 2 ] <Warning> ConfigProcessor: Include not found: clickhouse_compression
server_1   | 2017.08.08 19:13:30.362356 [ 3 ] <Trace> HTTPHandler-factory: HTTP Request for HTTPHandler-factory. Method: GET, Address: <IP_ADDRESS>:58068, User-Agent: curl/7.35.0
milovidov@milovidov-desktop:~/work/ClickHouse/docker$

milovidov@milovidov-desktop:~/work/ClickHouse/docker/server$ clickhouse-client --host=localhost
ClickHouse client version 1.1.54260.
Connecting to localhost:9000.
Code: 210. DB::NetException: Connection refused: (localhost:9000, <IP_ADDRESS>)

milovidov@milovidov-desktop:~/work/ClickHouse/docker/server$ clickhouse-client --host=<IP_ADDRESS>
ClickHouse client version 1.1.54260.
Connecting to <IP_ADDRESS>:9000.
Code: 210. DB::NetException: Connection refused: (<IP_ADDRESS>:9000)

milovidov@milovidov-desktop:~/work/ClickHouse/docker/server$ clickhouse-client --host=<IP_ADDRESS>
ClickHouse client version 1.1.54260.
Connecting to <IP_ADDRESS>:9000.
Code: 210. DB::NetException: Connection refused: (<IP_ADDRESS>:9000)

milovidov@milovidov-desktop:~/work/ClickHouse/docker/server$ clickhouse-client --host=::
ClickHouse client version 1.1.54260.
Connecting to :::9000.
Code: 210. DB::NetException: Connection refused: (:::9000, ::<IP_ADDRESS>)

milovidov@milovidov-desktop:~/work/ClickHouse/docker/server$ curl http://localhost:8123/
Ok.

It need further investigation.

docker-compose up -d server exposes only 8123 port. To use client run command docker-compose run client instead of clickhouse-client. Or you can modify docker-compose.yml file to expose 9000 port.

well, it doesn't work either after i expose 9000 port. in fact i've exposed the whole network.

How do you do that? I've added       - 9000:9000 at the end of the docker-compose.yml and now docker-compose up -d server gives me an access to 9000 port of CH in the container.

via --net=host.  In fact, i did exactly what you mentioned - 9000:9000 but still couldn't connect.

What environment do you have? Like versions of Docker, Docker Compose and OS.

Docker version 1.12.6,

docker-compose version 1.13.0, build 1719ceb
docker-py version: 2.3.0
CPython version: 2.7.5
OpenSSL version: OpenSSL 1.0.1e-fips 11 Feb 2013

centos 7.3

I've just created a droplet with:

CentOS 7.3.1611
Docker 17.06.0-ce, build 02c1d87
Docker Compose 1.15.0, build e12f3b9

After adding 9000 port as exposed and starting server with docker-compose up -d server I can see that 9000 port is opened:
[root@temp-docker ClickHouse]# telnet localhost 9000
Trying ::1...
Connected to localhost.
Escape character is '^]'.

By the way, your logs in the first message show nothing wrong about 9000 port. According to them, everything is fine and the problem is likely related to docker itself.

Outdated. Does not reproduce.


Typings is different with the document

Version
vue-final-modal: v3.4.0
vue: v3.1.5 with vite v2.4.4
typescript: v4.3.5
OS
Windows
Reproduction link

Steps to reproduce
N/A
What is Expected?
More specific installation steps for Vue 3 & Typescript. Current document is really confusing
What is actually happening?

This is not correct syntax to use with Vue 3 & Typescript. And I can't really install & use this package for my project because of the types was wrong & many compile errors.

I just read v2 docs and the document is about the same & not updated to fit with V3.

Same issue, im trying to setup, i cannot setup in a local component :(

@hunterliu1003 hey can we have a bit of context of why not planned ?

@hunterliu1003 hey can we have a bit of context of why not planned ?

Because the<EMAIL_ADDRESS>will rewrite with TS, it will be released very soon.
I'm working on the new version of the documentation

thanks a lot, that make sense !


main: sync log before exit + update failpoint dep

What problem does this PR solve?
We need to sync the logger before exit. https://godoc.org/go.uber.org/zap#Logger.Sync
What is changed and how it works?
Added a call to Sync(), modeled after TiDB https://github.com/pingcap/tidb/blob/b864fac504f9f059a39a7d477e923440f6d88a55/tidb-server/main.go#L176-L182.
Also, updated failpoint deps, see pingcap/dm#122.
Check List
Tests

Manual test (add detailed scripts or steps below)

make works

Side effects
Related changes

/run-all-tests

/run-all-tests

PTAL @july2993 @lonng

Sync() will also flush child logger's buffered entries, right?

@csuzhangxc Yes.
Calling With on an I/O Core would create a "clone" which share the same WriteSyncer. This means parent.Sync() and child.Sync() are both equivalent.

/run-all-tests tikv=master tidb=master pd=master


Question: How is puts et al. implemented?

I couldn't find their definition, yet I see it in some of the samples.
I ask because I notice care was taken to provide a stdio-less option, but does that mean all hosts must roll their own expose a 'puts' function in the global namespace? I also don't see an IO class (I think puts would call IO.write in CRuby?)

puts (simple output) is defined in mruby-print mrbgem.  IO class is defined in mruby-io mrbgem.

Thanks for the pointer!
However, I notice printstr calls fwrite to stdout directly.
fwrite(s, len, 1, stdout);

This is problematic for embedders, since in GUIs they often have their own notion of "standard output". It would be better if all such IO went through a custom mrb_fwrite, etc which would default to fwrite, but the caller could override. (mrb_set_stdio_callbacks or something like that).

I agree. Squirrel has a sq_setprintfunc() function. However simply overwriting __printstr__ is sufficient here, isn't it?


Implement fuzzier search for model names in docs

Describe the feature
Searching for model names should exclude underscores and other word break characters, and be able to find tokens in any order.
Who will this benefit?
We (like probably everyone else) use snake_case in our model names. When looking for a model in dbt Docs, I try to search by a couple of keywords (e.g. "class teachers") if I know a model exists but don't remember its exact name. This doesn't find a model called teachers__class_counts, because the search appears to require a perfect substring match, such as _class_c.

Even if I remember the model name, having to remember where the underscores go is a pain - is it user_meta_data or user_metadata?
Describe alternatives you've considered

Having a better memory
Searching for a single word using the dbt search bar, then searching for a second word using Ctrl-F, e.g.

Additional context
If separator characters are included in the search then they shouldn't be stripped. Perfect substring matches should probably still win, but I haven't put a lot of thought into those edge cases.
Are you interested in contributing this feature?
My JS is pretty much limited to hello world, but if you point me in the right direction I'm happy to lose an hour or two trying before giving up.

Completely on board with this, @joellabes. I'm going to transfer this issue to the dbt-docs repo.
If you want to give this a go, I think search.js is the right place to start looking.


Update lodash and renderkid to fix CVEs (2.x branch)

This PR does 2 things:

Updates lodash to solve https://npmjs.com/advisories/1673
Updates renderkid to solve a nested CVE with css-what

There is another CVE with a dependency used by Mocha, sadly NPM doesn't support overrides yet.
This will require to release 2.1.3.

Cc @AriaMinaei

@Nivl renderkid got updated to 3.0.0 as part of the v4 release if you want to close this PR


Use Marathon 0.11.1

For changes of the release, please see https://github.com/mesosphere/marathon/releases/tag/v0.11.1

lgtm  merging!


Add a basic uninstallation script

So that people can uninstall to their heart's content.

rebased and released to master

thanks!


Multiple tabs keep opening when current breakpoint wasn't explicitly continued

I assume this is due to the nature of the "allow multiple sessions" setting, but even disabling it keeps spawning an additional two tabs (the console and the debug UI) per new request that comes in.
I'm not sure if any of these are possible, but the following would perhaps be interesting:

Ignore any additional requests and log a message to the console that a second request could not be attached to because another one is already being handled (in the same window)
Exit the current handling if the request is aborted, though this may be annoying for the developer debugging

Duplicate of #291
This should be fixed in the next release (sometime this week). There is a flag that's sent to xdebug but to disable multiple connections but it looks like xdebug is ignoring this in certain situations.

Should be Fixed in v0.3.5. If not please reopen


Get list tx 2 times when click to other page

Fixing pull request:
https://github.com/tomochain/tomoscan/pull/395


reorder DataFrame.getitem() overloads to maybe support numpy 1.23.5

[x] Closes #656 (Replace xxxx with the Github issue number)
[ ] Tests added: Please use assert_type() to assert the type of any return value

I tested locally and this change fixes an issue with numpy 1.23.5.  I don't want to add another test to the CI for this, but the change works with our current tests, and I think it fixes the issue with numpy 1.23.5 by putting the narrower types first.

Thanks @Dr-Irv !


Make olm compatible with Kotlin Multiplatform Mobile

Problem related to feature request
I want to use the Matrix iOS SDK in an application that I am building with Kotlin Multiplatform Mobile. The Matrix iOS SDK depends on the OLMKit CocoaPod, and olm makes use of a "semantic import" statement (@import Security) in line 26 of xcode/OLMKit/OLMAccount.m. Currently, code containing "semantic import" statements is not compatible with KMM projects due to an issue with the cinterop tool, as described here.
Desired solution
I would like that single use of the @import statement to be replaced with a traditional compiler #import directive.
Alternatives Considered
I could fork the repo and make this change myself, but then I would also have to host the resulting OLMKit CocoaPod, which would necessitate creating my own fork of MatrixSDK as well, modified to depend on my own OLMKit version. Additionally, until this fix is implemented in olm, no other KMM developers can use the Matrix iOS SDK in their projects.

I sent a corresponding patch to<EMAIL_ADDRESS>

Fixed by https://gitlab.matrix.org/matrix-org/olm/-/commit/bce4f007b1f0077260452912a95f0bf175e24108


It would be good to add release section

Every release should have  exactly the same structure and files that will be under ...\Extensions\apomkbibleomoihlhhdbeghnfioffbej<version> once it's present in google store (sans _metadata of course).

will do, thanks!


Release/extensions

Submitting v1.0.0 of the eltsnap-simpleDataFlow extension to the gallery

@konstantinmds Please redo this PR and submit to the release/extensions branch instead


fix: fall back to mlly resolver in more cases

🔗 Linked issue
context: https://github.com/nuxt/framework/issues/6733
❓ Type of change

[ ] 📖 Documentation (updates to the documentation or readme)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
In the linked issue above, the presence of a directory express was skipping the mlly resolution process as the path existed. I've added a couple of additional conditions here:

resolve with mlly if id is not absolute (express.js) won't map to ~/express.js in node terms
resolve with mlly if id is a directory - as directory imports won't work in esm and we need to resolve /index.js
only call normalizeid on absolute paths as otherwise (if mlly absolutely can't resolve it) we can end up with something like file://express

📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

Would you please provide a (nitro) reproduction? 🙏🏼

I believe the fix makes sense on its own for the reasons mentioned in the description.
But here you go: https://stackblitz.com/edit/nuxt-starter-qlsvtz.


WIP - sphinx: replay protection and garbage collector

This pull request attempts to address #304
I am in need of comments for this pull request as I'm not sure if I tackled the latter two objectives correctly.
As for the first objective, at what point does the time lock expire "too far" in the future? Should this value be set in the forwarding policy of each node? Or should it be a const?
Regarding the decaying log, I'm not sure if I batched the writes to the database correctly. The boltdb doc page says that db.Batch must be run from a goroutine and concurrent calls to db.Batch are batched together by boltdb transactions. Running db.Batch within a goroutine and actually having concurrent calls to db.Batch would require something like running everything as a goroutine here.
Regarding the garbage collector, I'm not sure what is meant by a "persistent" goroutine.
The updated lnd branch that this branch works successfully with is:
https://github.com/Crypt-iQ/lnd/tree/sphinxCompat
This commit introduces persistent replay protection against prior shared secrets from prior HTLC's. A new data structure DecayedLog was created that stores all shared secrets in boltdb and it persists on startup. Additionally, it comes with a set of tests that assert its persistence guarantees. DecayedLog adheres to the newly created PersistLog interface. DecayedLog also comes with a garbage collector that removes expired shared secrets from the back-end boltdb.

My garbage collector was previously using CLTV's incorrectly. The latest commit (2f6a89a) fixes that.  Upon not retrieving anything, the Get method in DecayedLog will now return math.MaxUint32. I could instead create a new, specific error. Additionally, the tests are also now cleaned up and fixed.

I was thinking about my garbage collector and how it sweeps up CLTV's and I now understand what is meant by a "persistent goroutine" for the garbage collector.

Realized I was using CLTV relatively ............ so my future commit will revert this change.

[ ] Reject HTLC's deemed too far in the future. I am unsure how to address this. Should this be in the ForwardingPolicy of each node? Or is this task related to this?
[x] Created a new on-disk data-structure implementing a persistent, decayed shared secret log. boltdb was used here. I believe the option for a bloom filter could be added (though it wouldn't decay). Appropriate tests were added for the DecayedLog
[x] Created a persistent goroutine that garbage collects entries within the log. Appropriate tests were added here as well.


syntax highlighting not working

Hi, thanks for this awesome tool.
I use it everyday in lazygit.
I wonder how the syntax highlighting is working.
My kotlin code is not highlighted and I wonder if there is a fix a can do on my machine or if it needs to be supported by the tool.

https://github.com/shikijs/shiki/blob/v0.9.3/docs/languages.md#literal-values
kotlin is listed as supported language in shiki

Hey, glad you like it! This is happening because I use the file extension as the language name passed to shiki, which usually works because shiki has aliases from file extensions to languages (e.g. 'rs' for rust), but it doesn't for Kotlin.
A PR like https://github.com/shikijs/shiki/pull/353 adding aliases: ['kt'] for kotlin should resolve this issue if you feel comfortable doing that. If not, I can take a stab at it.

Thanks, yes I will definitely take the opportunity and create a PR

https://github.com/shikijs/shiki/pull/525

@banga It got merged into https://github.com/shikijs/shiki/releases/tag/v0.14.5

Great! I just bumped the shiki version to pick this up and checked that kotlin files highlight correctly now. I released v0.17.0, which you should be able to update to it via npm i -g git-split-diffs.


Update wire-format to comply with exit-format

The wire format consists of typescript types, a json schema and validator functions for messages sent between nitro wallets.
It is necessary to update the package if we want wallets to work with the exit format, since they need to pass messages (for signing by counterparties) that can eventually be submitted to chain.
The approach taken here is:

ensure the new metadata and allocationType fields are present and correct, as well as
renaming allocationItems to allocations (as per the exit format).
I have removed the Guarantee outcome type, since this is now just an allocation with certain metadata.
I have also removed the Allocation(s) type as this collides with new types coming out of exit format. It is also unnecessary given the removal of Guarantee type.
regenerate the schema
update the sample messages so the tests pass

I considered whether these changes were really necessary -- in other packages we can probably get away with reusing different types and writing adapter code. But here it seems to me that it really is necessary to have things compatible here, since we do runtime checks (on inter-wallet messages) against a schema generated from the types in this package, and go on to use those messages to construct transactions that need to work against types defined in the exit-format package.
I also considered whether we should be duplicating types here, or in fact just re-importing them from the exit format (seeing as they seem to need to be tightly coupled). I didn't reach a conclusion on that, and it felt like mission creep in any case.
⚠ reminder: CI is not expected or required to pass (yet)

Checklist:
Code quality

[x] I have written clear commit messages
[x] I have performed a self-review of my own code
[x] This change does not have an unduly wide scope
[x] I have separated logic changes from refactor changes (formatting, renames, etc.)
[x] I have commented my code wherever necessary (can be 0)
[x] I have added tests that prove my fix is effective or that my feature works, if necessary

Project management

[x] I have applied the appropriate labels
[x] I have linked to all relevant issues (can be 0)
[x] I have linked to all dependent issues (can be 0)
[x] I have assigned myself to this PR
[x] I have chosen the appropriate pipeline on zenhub for the linked issue

Thanks for the prod on reviewing. My general impression is that a package like this is a good thing to have in protocol development, and that it makes things like future interoperability between different versions feasible.

I also considered whether we should be duplicating types here, or in fact just re-importing them from the exit format (seeing as they seem to need to be tightly coupled). I didn't reach a conclusion on that, and it felt like mission creep in any case.

This is an interesting question, but some part of me says that the current solution is correct. Schema is defined in one place, implementation in another. This guards against making breaking changes in the exit-format without noticing.


#[UIC-1854] jira actions configurable from deployment and chart creation screen

CATEGORY
Choose one

[ ] Bug Fix
[x] Enhancement (new features, refinement)
[ ] Refactor
[ ] Add tests
[ ] Build / Development Environment
[ ] Documentation

SUMMARY

User can enable Raise ticket for chart in explore view by clicking "Enable Raise Ticket".
Other details on UI is optional can be modified if required
Other things needs to configured at time of deployment
TICKET_GENERATION_SYSTEM_ENDPOINT = 'https://guavus-jira.atlassian.net/rest/api/2/issue/'
TICKET_GENERATION_SYSTEM_API_KEY = ''
TICKET_GENERATION_SYSTEM_USER =''

Ansible variable to achieve the same are
raf_ticket_generation_system_endpoint
raf_ticket_generation_system_api_key
raf_ticket_generation_system_user

Ansible code can be found here
We have also provided default payload and message format as below
Payload format
{
  "fields": {
    "project": {
      "key": "MD"
    },
    "summary": "[%dashboard_title%/%chart_title%: %time%] Issue raised using RVF",
    "description": "*An issue has been raised by following dashboard* \n {quote} Dashboard Name: *%dashboard_title%* \n Chart Name: *%chart_title%* \n The dashboard access link is available [here|%dashboard_url%] \n RVF User: %username%{quote}\n *The chart has following selection at the time of incident*\n {quote}Chart Selection:  %chart_selection%.{quote}\n {code:sql| title=Chart Query}%chart_query%{code}" ,
    "issuetype": {
      "name": "Task"
    }
  }
}

Message:
Ticket %key% created successfully

Feature

Ticket can be raised by service-account configured at deploymnet
If ticketing system support anonymous user the you can skip user and api_key at deployment time
only Ticketing system with Post REST endpoint with application/json payload is supported
default payload is for JIRA as ticketing system ( not configurable system label)
IF TICKETING_SYSTEM_ENDPOINT is empty then this feature will be disabled on UI or any existing dashboard will show "Raise Ticket is not configured" on execution

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Configuration Option:

TEST PLAN

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
@bipinsoniguavus

LGTM ...code wise


AT-3791 Deprecating setup.py

(insert scope and description here)
Items:

[ ] Ran test & live-tests
[ ] Implemented (new) unit tests
[ ] Removed credentials
[ ] Removed argument pointing to staging
[ ] Updated documentation

For release:

[ ] Bumped version
[ ] Added changelog
[ ] Updated announcement banner

Suggestion: update the PR's description (rn it looks like a placeholder)


Function newContext() is not available in incognito mode

Describe the bug
Cannot make a browser context with the browser instance created with Apify.launchPlaywright()
To Reproduce
const browser = (await Apify.launchPlaywright({
    launchOptions: {
      headless: NODE_ENV === 'production',
      env: {},
    },
    useChrome: true,
  })) as Browser;
const loginContext = await browser.newContext(); // Throw error

Error message
Error: Function `newContext()` is not available in incognito mode
      at Browser.newContext (/Users/usrname/myproject/node_modules/browser-pool/src/playwright/browser.ts:54:15)
      at /Users/usrname/myproject/src/main.ts:22:38
      at async run (/Users/usrname/myproject/node_modules/apify/src/actor.js:204:13)

Expected behavior
Shouldn't it create a browser context successfully? If not, the error description should be improved.
System information:

OS: MacOS Monterey 12.1
Node.js version: 16.13.1
Apify SDK version: 2.0.7

Additional context
const browser = await playwright.chromium.launch({
    headless: false,
  });
const context = await browser.newContext();

Using the Playwright SDK directly works find.

Looks like a wrong error message. Apify.launchPlaywright() returns a persistent context by default and you can't call newContext on that. Yes, this is opposite to the default Playwright behavior, but in line with the default Puppeteer behavior, which existed earlier in the SDK. In V3, we will most likely change the defaults somehow.
You can get the default Playwring behavior like this:
const browser = await Apify.launchPlaywright({
    useIncognitoPages: true,
});

@mnmkng Is that property not supported on Typescript yet?

Most likely. As I said in the other issue, TS support is not 100% now. Will be fixed in a month or two with the full TS rewrite.


Automated docker container builds via actions

Creates two docker images: serge-api, and serge-webui available by the ghcr.io repo tied to this repository.
NOTE: Make sure to create a "release" branch where major releases get pulled into as this is what triggers the automated builds. Seems they changed how some GitHub variables worked so took a little trial and error.

Creates two docker images: serge-api, and serge-webui available by the ghcr.io repo tied to this repository.
NOTE: Make sure to create a "release" branch where major releases get pulled into as this is what triggers the automated builds. Seems they changed how some GitHub variables worked so took a little trial and error.

This looks super cool, wow, thanks a lot!
I'll give it a good review after work, I really appreciate you doing this.

Thanks! It was mentioned in #15 but someone will probably have to update the Dockerfiles so that they are built fully self contained (except for volume mounts for the models), I can take a look later tonight!

Hey thanks for the contribution! I'll merge it and see if it works.


test: skip uv_(get|set)_process_title on IBMi

uv_(get|set)_process_title is not implemented on IBMi.

Thanks Xu Meng, landed in 93634e29.


Add size token with a value of 0

General Support Request
We need to add a design token with a value of 0 in order to make Auro components fully customizable.
Possible Solution
Add --ds-size-none token
Additional context
We previously had an --auro-size-none token, but it has been recently deprecated and there was no token to replace it.

I don't think having a token for --ds-size-none or --ds-size-0 is necessary since this value will likely never change. Updating --ds-size-none to something like 1rem when changing a theme just doesn't seem practical. It's akin to changing --ds-color-brand-atlas-400 to #FFA500.
This kind of token should probably be categorized as tier 2 or even tier 3. For instance, with auro-input, input-margin could be such a token, set to 0 by default, but modifiable in a theme.
This also brings up the broader issue of how users can customize the values of tier 3 tokens. After some research, it seems the only way to do that is by injecting new code into the web component's scope. Here's a demo of how it could be done:
const myInput = document.querySelector('auro-input');
const shadowRoot = myInput.shadowRoot;

// Create a new CSSStyleSheet
const customStyles = new CSSStyleSheet();
customStyles.replaceSync(`
  input {
    input-margin: 1rem;
  }
`);

// Apply the custom styles to the shadow DOM
shadowRoot.adoptedStyleSheets = [customStyles];

Move above comment to a discussion, then we can close this issue.


Laravel 10.x Shift

This pull request includes the changes for upgrading to Laravel 10.x. Feel free to commit any additional changes to the shift-90196 branch.
Before merging, you need to:

Checkout the shift-90196 branch
Review all pull request comments for additional changes
Run composer update (if the scripts fail, add --no-scripts)
Clear any config, route, or view cache
Thoroughly test your application (no tests?, no CI?)

If you need help with your upgrade, check out the Human Shifts. You may also join the Shifty Coders Slack workspace to level-up your Laravel skills.

:information_source: Laravel 10 deprecated the ImplicitRule, InvokableRule, and Rule contracts in favor of using the new, streamlined ValidationRule contract. These contracts will be removed in a future version of Laravel.
Given the change in the method names and return type, Shift can not reliably automate this change. At your convenience, you should review these custom validation rules and update them to implement the ValidationRule contract.

[ ] app/Rules/ValidHCaptchaResult.php
[ ] app/Rules/ValidRssFeedRule.php

:warning: Laravel 10 removed the DispatchJobs trait from the base controller. As such, calling $this->dispatch() and $this->dispatchSync() within your controllers is no longer available.
Shift found potential calls to these methods in the following files. You should review these instances and update them to use job dispatching or the dispatch/dispatchSync helpers.

[ ] app/Http/Controllers/LaunchSendController.php

:information_source: Shift detected your application has a test suite. To make verifying the upgrade to Laravel 10 easier, Shift did not upgrade your test suite to PHPUnit 10. Once you have completed your upgrade, you may run the PHPUnit 10 Shift for free to upgrade your test suite to PHPUnit 10 separately.

:warning: Shift detected you are running Laravel Sail. If you have not customized your stack, you should run php artisan sail:install to regenerate the latest docker-compose.yml. Otherwise, Shift attempted to update Sail for PHP 8.1. However, you should review your docker-compose.yml to ensure your stack is running PHP 8.1 or higher.

:information_source: Laravel 9 adopted anonymous migrations. Shift automated this change to align with modern Laravel conventions and avoid naming migrations.

:information_source: Laravel renamed the password_resets table to password_reset_tokens. While an optional change, Shift detected you have a migration for this table and created a migration to rename it as well as updated the reference in your config/auth.php file. Be sure to run php artisan migrate to complete your upgrade.

:information_source: Shift understands developers have different preferences when it comes to type hints. All of Shift's automation is done in nice, atomic commits. This makes it easier to undo any of the changes Shift makes.
If you wish to undo the changes relating to type hints, you may run:

git revert 602361a to revert the DocBlock changes.
git revert d50a220 to revert the type hints added from DocBlocks.
git revert 6b46bc3 to revert the type hints added for Laravel 10.

:information_source: Now with type hints in your code, defining types within PHP DocBlocks is redundant. Laravel has removed all of the @param and @return tags from its DocBlocks where types are defined with PHP. Similarly, Shift removed these tags from any DocBlock where the code now has equivalent type hints.

:information_source: All of the underlying Symfony components used by Laravel have been upgraded to Symfony 6.2. Shift detected references to Symfony classes within your application. You should review the Symfony change log for any additional changes.

:information_source: Laravel began using Vite to build frontend assets in Laravel 9.19. While you may continue to use Laravel Mix, it is no longer the default. If you wish to modernize your application to use Vite, you may run the Vite Converter for free.

:warning: Laravel 10 requires Composer 2.2 or higher. You should verify the Composer version in your environments by running composer --version to ensure it meets this new requirement. If necessary, run composer self-update to update Composer.

:tada: Congratulations, you're now running the latest version of Laravel!
Next, you may optionally run the following Shifts to ensure your application is fully upgraded, adopts the latest Laravel conventions, and easier to maintain in the future:

Upgrade Checker ensures your application is fully upgraded by detecting any outdated code.
Laravel Fixer automatically updates your code to the latest Laravel conventions.
Tests Generator intelligently generates model factories, HTTP Tests, and configuration for your application.
CI Generator intelligently generates CI jobs to lint PHP, check code style, and run tests, including Dusk.

You may also use the Shift Workbench to automate common tasks for maintaining your Laravel and PHP applications.

:x: PHP syntax errors were detected after running your Shift. Often these are simply differences between the PHP version on the Shift server (8.1) and your project. Occasionally they are misplaced lines or duplicate import statements.
You may quickly check the PHP syntax locally by running php -l on the following files:

[ ] app/Services/EmailListImporter.php


Build error

I build wxRuby3 with wxruby setup
I use the following build options:

PATH = ...
wxWidgets version used:3.2.4
wxWidgets configure command: ../configure --with-gtk --prefix

Description
i installed and built wxWidget with a specific prefix as you can see because i can't use the default /usr/local
but when trying to run wxruby setup it still tries to find the files (like wx/include/gtk2-unicode-3.2/wx/setup.h) under /usr/local
how can i solve this?
Platform and version information

wxRuby3 version 0.9.8you are building:
wxRuby3 port  you are building:
OS (distribution)  and its version:

GTK version:

Compiler  being used:
Non-default compiler options, if any :

All the information you need is described in the INSTALL document.
Pay particular attention to this section.

It seems you may be trying to build on an incompatible platform.
Please provide details concerning the platform you are trying to build
on (judging from the screen print it's a *nix variant) and include the
GCC compiler version as it seems this might be an old version.
Also, in the future please do not send console screen shots but rather
copy (part of) the console output and paste it in the issue message.
On 4/11/24 12:48, Mishel Hitibashvili wrote:

o.k i solved this but now when running setup i receive this:
image.png (view on web)
https://github.com/mcorino/wxRuby3/assets/107391491/b91bd32f-5fcb-40f6-80c6-0dfcef8f10d9
and the setup gets terminated after few mints
—
Reply to this email directly, view it on GitHub
https://github.com/mcorino/wxRuby3/issues/270#issuecomment-2049417457,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AABYLMRGBI6OLZ6EJ6EL4UDY4ZS6VAVCNFSM6AAAAABGBXDVY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBZGQYTONBVG4.
You are receiving this because you commented.Message ID:
@.***>

now i'm getting this:
Generating wxRuby3 reference documentation...Error occurred: undefined method []' for nil:NilClass and i traced it back to : rakelib/lib/generate/doc.rb:807:in block in gen_constants_doc'
do you know what could be the reason?

and when trying to require the gem i get:
undefined symbol: _ZThn688_N14wxTextCtrlBase8overflowEi
in:
wxruby3-0.9.8/lib/wxruby_core.so

It seems a required tool is missing from your system. Without more details concerning your platform (OS / version) and the exact commands used to install/build/setup wxRuby I am afraid I cannot provide much assistance.On 11 Apr 2024 13:45, Mishel Hitibashvili @.***> wrote:
there was a problem with the machine i was on, sorry..
now i get this output:
Now running wxRuby3 post-install setup.
This will (possibly) install required software,build the native wxRuby3 extensions
and generate the wxRuby3 reference documentation.
Please be patient as this may take quite a while depending on your system.
INFO: Cannot find 'wxColour::operator!=' (module 'wxColour') to ignore.
INFO: Cannot find 'wxVariant::operator[]' (module 'wxVariant') to ignore.
Building wxRuby3 extensions...done!
Installing wxRuby3 extensions...Installation of binary gem with-wxwin requires an installed version of the patchelf utility.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

This is a sign the extension libraries haven't been built or installed correctly.On 11 Apr 2024 14:47, Mishel Hitibashvili @.***> wrote:
now i'm getting this:
Generating wxRuby3 reference documentation...Error occurred: undefined method []' for nil:NilClass and i traced it back to : rakelib/lib/generate/doc.rb:807:in block in gen_constants_doc'
do you know what could be the reason?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

o.k so i will try to add the install process i used:
i downloaded wxWidgets-3.2.4
then i made a dir inside wxWidgets-3.2.4 called buildgdk and cd into it
then i ran  ../configure --enable-unicode --enable-debug --prefix=../../lib_for_wxwidget
then make and then make install so i should have the proper wxWidgets installed for wxruby
i also downloaded patchelf and did a similar process as for wxWidget
after all of that i ran:
wxruby3-0.9.8/bin/wxruby setup --wxwin <path_to>/lib_for_wxwidget --with-wxwin
i'm running on SLES12 machine
thanks a lot for the help!

Ok, first off, SLES12 is ancient and I have not tested anything on any Linux version that old. Your mileage may vary.
That said, if you can successfully build both a compatible wxWidgets version (3.2+; which it seems you can) and install a modern Ruby version I feel it should be possible to build wxRuby3 on this system.
There are 3 things I notice:

The 2 "INFO: Cannot find..." messages while building wxRuby3 are unexpected as you say you are using wxWidgets 3.2.4 and for this version these messages should not show; they are however relatively harmless and we should first see if we can fix other problems.
The message "Installation of binary gem with-wxwin requires an installed version of the patchelf utility."  You say you downloaded and installed the 'patchelf' utility but have you tested if it actually works? Also does SLES12 have the standard utility command installed. The wxRuby3 build procedure executes command -v patchelf to see if the 'patchelf' tool is installed. If that fails it assumes the tool is not installed and the wxRuby3 installation fails.
Why have you downloaded and build wxWidgets yourself? In case a system does not have a (compatible) wxWidgets version installed the default wxruby setup command will automatically download (git clone) the latest stable release (which is 3.2.4 currently) and build that for embedded deployment with tested configure options.

hi,
i've managed to set it up in linux and it works so thanks a lot!!
now i'm facing windows issues
-- Ruby level backtrace information ----------------------------------------
src/UserInterface/Avalancher.rb:7697:in <main>' C:/AVL/lib/gems/wxruby3-0.9.8/lib/wx/core/app.rb:51:in run'
C:/AVL/lib/gems/wxruby3-0.9.8/lib/wx/core/app.rb:51:in `main_loop'
-- C level backtrace information -------------------------------------------
C:\WINDOWS\SYSTEM32\ntdll.dll(ZwWaitForSingleObject+0x14) [0x00007ffb88a2f3e4]
C:\WINDOWS\System32\KERNELBASE.dll(WaitForSingleObjectEx+0x8e) [0x00007ffb85e4421e]
C:\Ruby27-x64\bin\x64-msvcrt-ruby270.dll(rb_vm_bugreport+0x34b) [0x00007ffb2a4f7adb]
C:\Ruby27-x64\bin\x64-msvcrt-ruby270.dll(rb_bug_for_fatal_signal+0x7f) [0x00007ffb2a3104ff]
C:\Ruby27-x64\bin\x64-msvcrt-ruby270.dll(ruby_sysinit+0x790) [0x00007ffb2a4517b0]
[0x00007ff73c681f32]
C:\WINDOWS\System32\KERNELBASE.dll(UnhandledExceptionFilter+0x1ec) [0x00007ffb85f6ca6c]
C:\WINDOWS\SYSTEM32\ntdll.dll(LdrResolveDelayLoadsFromDll+0x1472) [0x00007ffb88a6a312]
C:\WINDOWS\SYSTEM32\ntdll.dll(KiUserApcDispatcher+0xb0) [0x00007ffb88a33310]
C:\WINDOWS\SYSTEM32\ntdll.dll(chkstk+0x12f) [0x00007ffb88a3440f]
C:\WINDOWS\SYSTEM32\ntdll.dll(RtlFindCharInUnicodeString+0xa96) [0x00007ffb889ae466]
C:\WINDOWS\SYSTEM32\ntdll.dll(KiUserExceptionDispatcher+0x2e) [0x00007ffb88a333fe]
C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxmsw32u_core_gcc_custom.dll(ZN12wxDropTarget6RevokeEP6HWND_+0x25) [0x00007ffac00b05e5]
C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxmsw32u_core_gcc_custom.dll(ZN8wxWindow16MSWHandleMessageEPxjyx+0xfac) [0x00007ffac00e9fec]
C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxmsw32u_core_gcc_custom.dll(ZN10wxTextCtrl16MSWHandleMessageEPxjyx+0x2a) [0x00007ffac01c776a]
C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxmsw32u_core_gcc_custom.dll(ZN8wxWindow13MSWWindowProcEjyx+0x2f) [0x00007ffac00d529f]
C:\WINDOWS\System32\USER32.dll(DispatchMessageW+0x741) [0x00007ffb87878961]
C:\WINDOWS\System32\USER32.dll(DispatchMessageW+0x3fc) [0x00007ffb8787861c]
C:\WINDOWS\System32\USER32.dll(GetClassLongW+0x58d) [0x00007ffb87883b5d]
C:\WINDOWS\SYSTEM32\ntdll.dll(KiUserCallbackDispatcher+0x24) [0x00007ffb88a333a4]
C:\WINDOWS\System32\win32u.dll(NtUserDestroyWindow+0x14) [0x00007ffb864f2754]
C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxmsw32u_core_gcc_custom.dll(ZN8wxWindowD1Ev+0x40) [0x00007ffac00e3d80]
C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxmsw32u_core_gcc_custom.dll(ZN7wxFrameD0Ev+0x2d) [0x00007ffac015bbed]
C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxbase32u_gcc_custom.dll(ZN16wxAppConsoleBase20DeletePendingObjectsEv+0x4e) [0x00007ffb2a89375e]
C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxbase32u_gcc_custom.dll(ZN16wxAppConsoleBase11ProcessIdleEv+0x58) [0x00007ffb2a8937f8]
C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxmsw32u_core_gcc_custom.dll(ZN9wxAppBase11ProcessIdleEv+0x13) [0x00007ffac01f2263]
C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxbase32u_gcc_custom.dll(ZN17wxEventLoopManual5DoRunEv+0x126) [0x00007ffb2a8c7f46]
C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxbase32u_gcc_custom.dll(ZN15wxEventLoopBase3RunEv+0x5b) [0x00007ffb2a8c7bcb]
C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxbase32u_gcc_custom.dll(ZN16wxAppConsoleBase8MainLoopEv+0x72) [0x00007ffb2a895822]
C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxbase32u_gcc_custom.dll(Z12wxInitializev+0xa6) [0x00007ffb2a90f3a6]
C:\AVL\lib\gems\wxruby3-0.9.8\lib\wxruby_core.so(Init_wxGUIEventLoop+0x1ca5) [0x00007ffac0a0abd5]
C:\Ruby27-x64\bin\x64-msvcrt-ruby270.dll(rb_error_arity+0x353) [0x00007ffb2a4d0063]
C:\Ruby27-x64\bin\x64-msvcrt-ruby270.dll(rb_add_method+0x21f) [0x00007ffb2a4e618f]
C:\Ruby27-x64\bin\x64-msvcrt-ruby270.dll(rb_vm_exec+0x9cf) [0x00007ffb2a4db37f]
C:\Ruby27-x64\bin\x64-msvcrt-ruby270.dll(rb_call_end_proc+0x140) [0x00007ffb2a314b20]
C:\Ruby27-x64\bin\x64-msvcrt-ruby270.dll(ruby_run_node+0x95) [0x00007ffb2a319835]
[0x00007ff73c6827f9]
[0x00007ff73c6813b1]
[0x00007ff73c6814e6]
C:\WINDOWS\System32\KERNEL32.DLL(BaseThreadInitThunk+0x1d) [0x00007ffb87dc257d]
i receive this error while trying to run the app (the gui opens up then loads something without me touching it and crashes)
i've installed msys2 with mingw-w64-ucrt-x86_64-gcc and finished the setup fine i think, i had some problems regarding wh_setup path again but i changed it to the real path and the setup has finished
also my friend when he tried running the app received:
c:/Ruby27-x64/lib/ruby/site_ruby/2.7.0/ruby_installer/runtime/dll_directory.rb:104:in `add_dll_directory_winapi': AddDllDirectory failed for C:/AVL/lib/gems/wxruby3-0.9.8/ext (RubyInstaller::Runtime::DllDirectory::WinApiError)
he doesn't have msys installed and just tried to use my installed gem as the gem lib is in a shared repo between us
do you have any idea what could be the problem?

I never tried building with a standalone mingw64 installation added to a Ruby installation. At this moment I couldn't begin to tell what may have gone wrong.Please use a Ruby Installer installation with integrated RDK as documented.On 24 Apr 2024 14:05, Mishel Hitibashvili @.***> wrote:
hi,
i've managed to set it up in linux and it works so thanks a lot!!
now i'm facing windows issues
-- Ruby level backtrace information ----------------------------------------
src/UserInterface/Avalancher.rb:7697:in ' C:/AVL/lib/gems/wxruby3-0.9.8/lib/wx/core/app.rb:51:in run'
C:/AVL/lib/gems/wxruby3-0.9.8/lib/wx/core/app.rb:51:in main_loop' -- C level backtrace information ------------------------------------------- C:\WINDOWS\SYSTEM32\ntdll.dll(ZwWaitForSingleObject+0x14) [0x00007ffb88a2f3e4] C:\WINDOWS\System32\KERNELBASE.dll(WaitForSingleObjectEx+0x8e) [0x00007ffb85e4421e] C:\Ruby27-x64\bin\x64-msvcrt-ruby270.dll(rb_vm_bugreport+0x34b) [0x00007ffb2a4f7adb] C:\Ruby27-x64\bin\x64-msvcrt-ruby270.dll(rb_bug_for_fatal_signal+0x7f) [0x00007ffb2a3104ff] C:\Ruby27-x64\bin\x64-msvcrt-ruby270.dll(ruby_sysinit+0x790) [0x00007ffb2a4517b0] [0x00007ff73c681f32] C:\WINDOWS\System32\KERNELBASE.dll(UnhandledExceptionFilter+0x1ec) [0x00007ffb85f6ca6c] C:\WINDOWS\SYSTEM32\ntdll.dll(LdrResolveDelayLoadsFromDll+0x1472) [0x00007ffb88a6a312] C:\WINDOWS\SYSTEM32\ntdll.dll(KiUserApcDispatcher+0xb0) [0x00007ffb88a33310] C:\WINDOWS\SYSTEM32\ntdll.dll(chkstk+0x12f) [0x00007ffb88a3440f] C:\WINDOWS\SYSTEM32\ntdll.dll(RtlFindCharInUnicodeString+0xa96) [0x00007ffb889ae466] C:\WINDOWS\SYSTEM32\ntdll.dll(KiUserExceptionDispatcher+0x2e) [0x00007ffb88a333fe] C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxmsw32u_core_gcc_custom.dll(ZN12wxDropTarget6RevokeEP6HWND_+0x25) [0x00007ffac00b05e5] C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxmsw32u_core_gcc_custom.dll(ZN8wxWindow16MSWHandleMessageEPxjyx+0xfac) [0x00007ffac00e9fec] C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxmsw32u_core_gcc_custom.dll(ZN10wxTextCtrl16MSWHandleMessageEPxjyx+0x2a) [0x00007ffac01c776a] C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxmsw32u_core_gcc_custom.dll(ZN8wxWindow13MSWWindowProcEjyx+0x2f) [0x00007ffac00d529f] C:\WINDOWS\System32\USER32.dll(DispatchMessageW+0x741) [0x00007ffb87878961] C:\WINDOWS\System32\USER32.dll(DispatchMessageW+0x3fc) [0x00007ffb8787861c] C:\WINDOWS\System32\USER32.dll(GetClassLongW+0x58d) [0x00007ffb87883b5d] C:\WINDOWS\SYSTEM32\ntdll.dll(KiUserCallbackDispatcher+0x24) [0x00007ffb88a333a4] C:\WINDOWS\System32\win32u.dll(NtUserDestroyWindow+0x14) [0x00007ffb864f2754] C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxmsw32u_core_gcc_custom.dll(ZN8wxWindowD1Ev+0x40) [0x00007ffac00e3d80] C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxmsw32u_core_gcc_custom.dll(ZN7wxFrameD0Ev+0x2d) [0x00007ffac015bbed] C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxbase32u_gcc_custom.dll(ZN16wxAppConsoleBase20DeletePendingObjectsEv+0x4e) [0x00007ffb2a89375e] C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxbase32u_gcc_custom.dll(ZN16wxAppConsoleBase11ProcessIdleEv+0x58) [0x00007ffb2a8937f8] C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxmsw32u_core_gcc_custom.dll(ZN9wxAppBase11ProcessIdleEv+0x13) [0x00007ffac01f2263] C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxbase32u_gcc_custom.dll(ZN17wxEventLoopManual5DoRunEv+0x126) [0x00007ffb2a8c7f46] C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxbase32u_gcc_custom.dll(ZN15wxEventLoopBase3RunEv+0x5b) [0x00007ffb2a8c7bcb] C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxbase32u_gcc_custom.dll(ZN16wxAppConsoleBase8MainLoopEv+0x72) [0x00007ffb2a895822] C:\AVL\lib\gems\wxruby3-0.9.8\ext\wxbase32u_gcc_custom.dll(Z12wxInitializev+0xa6) [0x00007ffb2a90f3a6] C:\AVL\lib\gems\wxruby3-0.9.8\lib\wxruby_core.so(Init_wxGUIEventLoop+0x1ca5) [0x00007ffac0a0abd5] C:\Ruby27-x64\bin\x64-msvcrt-ruby270.dll(rb_error_arity+0x353) [0x00007ffb2a4d0063] C:\Ruby27-x64\bin\x64-msvcrt-ruby270.dll(rb_add_method+0x21f) [0x00007ffb2a4e618f] C:\Ruby27-x64\bin\x64-msvcrt-ruby270.dll(rb_vm_exec+0x9cf) [0x00007ffb2a4db37f] C:\Ruby27-x64\bin\x64-msvcrt-ruby270.dll(rb_call_end_proc+0x140) [0x00007ffb2a314b20] C:\Ruby27-x64\bin\x64-msvcrt-ruby270.dll(ruby_run_node+0x95) [0x00007ffb2a319835] [0x00007ff73c6827f9] [0x00007ff73c6813b1] [0x00007ff73c6814e6] C:\WINDOWS\System32\KERNEL32.DLL(BaseThreadInitThunk+0x1d) [0x00007ffb87dc257d] i receive this error while trying to run the app (the gui opens up then loads something without me touching it and crashes) i've installed msys2 with mingw-w64-ucrt-x86_64-gcc and finished the setup fine i think, i had some problems regarding wh_setup path again but i changed it to the real path and the setup has finished also my friend when he tried running the app received: c:/Ruby27-x64/lib/ruby/site_ruby/2.7.0/ruby_installer/runtime/dll_directory.rb:104:in add_dll_directory_winapi': AddDllDirectory failed for C:/AVL/lib/gems/wxruby3-0.9.8/ext (RubyInstaller::Runtime::DllDirectory::WinApiError)
he doesn't have msys installed and just tried to use my installed gem as the gem lib is in a shared repo between us
do you have any idea what could be the problem?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

Can my problem be related to the errors we see on the CI flows?

No, those are the unstable CI builds which build against wxWidgets master branch.On 25 Apr 2024 07:32, Mishel Hitibashvili @.***> wrote:
Can my problem be related to the errors we see on the CI flows?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

i installed everything all over again:
https://github.com/oneclick/rubyinstaller2/releases/download/RubyInstaller-2.7.6-1/rubyinstaller-devkit-2.7.6-1-x64.exe
with this version of ruby with msys in it
the setup finished with success but still we face the same issue of ntdl.dll as before & the local tests don't pass
Failure: test_bitmap_data(TestBitmapData):
Fetched out bitmap.
 is not true.
C:/AVL/lib/gems/wxruby3-0.9.8/tests/test_clipboard.rb:100:in test_bitmap_data'       97:     end       98:       99:     out_bmp = d_obj_2.bitmap   => 100:     assert out_bmp.ok?, "Fetched out bitmap"      101:     assert_equal height, out_bmp.height      102:     assert_equal width, out_bmp.width      103:   end C:/AVL/lib/gems/wxruby3-0.9.8/tests/lib/wxapp_runner.rb:21:in call'
C:/AVL/lib/gems/wxruby3-0.9.8/tests/lib/wxapp_runner.rb:21:in on_init' C:/AVL/lib/gems/wxruby3-0.9.8/lib/wx/core/app.rb:30:in on_ruby_init'
C:/AVL/lib/gems/wxruby3-0.9.8/lib/wx/core/app.rb:51:in main_loop' C:/AVL/lib/gems/wxruby3-0.9.8/lib/wx/core/app.rb:51:in run'
C:/AVL/lib/gems/wxruby3-0.9.8/tests/lib/wxapp_runner.rb:39:in `block in class:Runner'
F
Failure: test_data_object_composite(TestDataObjectComposite):  is not true.
C:/AVL/lib/gems/wxruby3-0.9.8/tests/test_clipboard.rb:236:in block in test_data_object_composite'      233:      234:     d_iarr = MySimpleIntArrayObject.new      235:     Wx::Clipboard.open do | clip |   => 236:       assert clip.supported?(MY_INT_ARRAY_FORMAT)      237:       clip.fetch d_iarr      238:     end      239: C:/AVL/lib/gems/wxruby3-0.9.8/lib/wx/core/clipboard.rb:31:in open'
C:/AVL/lib/gems/wxruby3-0.9.8/tests/test_clipboard.rb:235:in test_data_object_composite' C:/AVL/lib/gems/wxruby3-0.9.8/tests/lib/wxapp_runner.rb:21:in call'
C:/AVL/lib/gems/wxruby3-0.9.8/tests/lib/wxapp_runner.rb:21:in on_init' C:/AVL/lib/gems/wxruby3-0.9.8/lib/wx/core/app.rb:30:in on_ruby_init'
C:/AVL/lib/gems/wxruby3-0.9.8/lib/wx/core/app.rb:51:in main_loop' C:/AVL/lib/gems/wxruby3-0.9.8/lib/wx/core/app.rb:51:in run'
C:/AVL/lib/gems/wxruby3-0.9.8/tests/lib/wxapp_runner.rb:39:in `block in class:Runner'
F
Failure: test_text_data(TestTextData)
C:/AVL/lib/gems/wxruby3-0.9.8/tests/test_clipboard.rb:26:in test_text_data'      23:     Wx::Clipboard.open do | clip |      24:       clip.fetch td_2      25:     end   => 26:     assert_equal("WXRUBY", td_2.text)      27:      28:     Wx::Clipboard.open do | clip |      29:       clip.clear C:/AVL/lib/gems/wxruby3-0.9.8/tests/lib/wxapp_runner.rb:21:in call'
C:/AVL/lib/gems/wxruby3-0.9.8/tests/lib/wxapp_runner.rb:21:in on_init' C:/AVL/lib/gems/wxruby3-0.9.8/lib/wx/core/app.rb:30:in on_ruby_init'
C:/AVL/lib/gems/wxruby3-0.9.8/lib/wx/core/app.rb:51:in main_loop' C:/AVL/lib/gems/wxruby3-0.9.8/lib/wx/core/app.rb:51:in run'
C:/AVL/lib/gems/wxruby3-0.9.8/tests/lib/wxapp_runner.rb:39:in `block in class:Runner'
<"WXRUBY"> expected but was
<"">
Finished in 0.1730129 seconds.
the weWidgets the was installed via the wxruby setup is v3.2.4-with-msvs2012-fix
do you have any idea what can i try to make it work?

I'll be able to look into this some more coming week.
In the mean time please provide me with all details concerning your installation/setup:

Windows version
Ruby installer version (latest 2.7 release?)
wxRuby3 setup commands

Thanks a lot!!
I have windows 11
rubyinstaller-2.7.6-1-x64 this is the ruby installer i downloaded with ruby 2.7.6p219 (2022-04-12 revision c9c2245c0a)
and i used the wxruby setup as is with nothing added

Ah, wxRuby3 has not been tested yet for Windows 11.
You may be a victim of some Windows 11 (clipboard) problems that have been reported for wxWidgets 3.2.4.
Unfortunately I have no Windows 11 available so I cannot test myself (have not found any CI runners yet either).
I'll see if I can find something out from the wxWidgets code.
Also I hope wxWidgets 3.2.5 gets released the coming week after which I plan to release wxRuby3 1.0.0 and than we can see if the problem still exists there.

What happens if you run the wxRuby3 'dragdrop' sample app?

i found what causes the crash of the app, don't know why but when we do:
TextCtrl.new(win, -1, "",  Wx::DEFAULT_POSITION,  Wx::DEFAULT_SIZE, Wx::TE_RICH)
it gets seg fault
without Wx::TE_RICH it works
this is so far, we need to test the whole app but just to let you know

i found what causes the crash of the app, don't know why but when we do: TextCtrl.new(win, -1, "", Wx::DEFAULT_POSITION, Wx::DEFAULT_SIZE, Wx::TE_RICH) it gets seg fault without Wx::TE_RICH it works this is so far, we need to test the whole app but just to let you know

Good catch!
Can you please try running the wxRuby3 'widgets' sample and test the 'Text' page there. With that you can test the Wx::TextCtrl with and without styles like Wx::TE_RICH. I am curious to see if that sample crashes as well in your setup. It does NOT crash in my setup with Windows 10.


UI changes for "Remove all remote watches"

@ibolton336 @vconzola after our conversation, will keep this GH issue updated with latest known UI requirements to support https://github.com/konveyor/mig-controller/pull/651

(Non display layer) Need to set migplan.spec.refresh=true when re-entering the "edit" migplan wizard for an existing plan. Wait on migplan.spec.refresh=false and migplan.status.conditions[RefreshInProgress].IsAbsent() to indicate PV discovery is done before showing user PV migration options.

(Non display layer) Ensure that both launching MigStorage edit modal and clicking "Check Connection" buttons for MigStorage will set migstorage.spec.refresh: true. Use observedDigest to wait for completion.

(Non display layer) Ensure that both launching MigCluster edit modal and clicking "Check Connection" buttons for MigCluster will set migcluster.spec.refresh: true. Use observedDigest to wait for completion.

(Display layer) If MigPlan status is unready, show specific problem e.g. "Plan is unready due to Replication Repo xyz being unready.", or equivalent warning for Clusters being unready. This can be accomplished by checking MigPlan for conditions

SourceClusterNotReady

DestinationClusterNotReady

StorageNotReady
User should be pointed to this specific information instead of generic "Plan Unready" when this more specific info is available.

@ibolton336 in case you're curious, the full list of possible conditions on the plan are here:
https://github.com/konveyor/mig-controller/blob/master/pkg/controller/migplan/validation.go#L29

@djwhatle @ibolton336 I'm wondering if #4 should be a separate issue since displaying detailed info about the reason a plan isn't ready is something we should do irrespective of removing remote watches #651?

@vconzola that's a good point, I'll break it out to a separate issue.


struct with unexported fields

I came across an issue where struct with unexported fields are not merged.
A good example is type time.Time
package main

import (
	"fmt"
	"github.com/imdario/mergo"
	"time"
)

type Foo struct {
	A string
	B int64
	C time.Time
}

func main() {
	src := Foo{
		A: "one",
		C: time.Date(2009, time.November, 10, 23, 0, 0, 0, time.UTC),
	}

	dest := Foo{
		B: 2,
		C: time.Date(2010, time.December, 11, 23, 0, 0, 0, time.UTC),
	}

	mergo.MergeWithOverwrite(&dest, src)

	fmt.Println(dest)
	// Expected output
	// {one 2 2009-11-10 23:00:00 +0000 UTC}
	// Actual output
	// {one 2 2010-12-11 23:00:00 +0000 UTC}
}

First of all, sorry. Second, I will take care of this this next week.

Thanks for your PR!


fix: Silently skip prefetching external URLs instead of warning

Fix https://github.com/sveltejs/kit/issues/6463 by automatically skipping prefetching of external URLs instead of warning app developers. This aligns with how Next.js solves the same problem.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[x] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[x] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

Thank you! I think the error is useful in the case where you're programmatically prefetching. What about changing the behaviour of trigger_prefetch to ignore any links that would normally be ignored? (Might need to abstract some logic out from the click handler to avoid repetition)

Thanks for the feedback! That sounds like a good way forward. When app devs call prefetch() there's a clear intention and the warning would be helpful.
I'll explore this further in the coming days. This would be a fun contribution to make!

Update:
Prefetching never happens for external URLs.
The difference is that programmatic calls to prefetch() will now throw the same error as before, while trigger_prefetch that is activated by data-sveltekit-prefetch silently fails just like the previous commit.
Remaning TODOs

[ ] I get two failing tests locally which didn't fail before. Any ideas what might have caused this? Perhaps because we're now inconsistent and throwing errors in one case but not in other cases? Or this might be caused by test flakiness of some kind.

@sveltejs/kit:test:     [chromium-dev] › test/client.test.js:309:2 › Errors › Root error falls back to error.html ======
@sveltejs/kit:test:     [chromium-dev] › test/client.test.js:360:2 › Load › accessing url.hash from load errors and suggests using page store


session.SendFile/session.SendFileWithMessage: Always fails with a 401

It appears nim's standard post function puts the authorization header in the raw body instead of in the header of the client. How and why I have no idea.

SendFile and SendFileWithMessage will work with an edit in the httpclient library.

what changes exactly need to be made to the httpclient library to get this working?

This should be fixed with the latest Nim release (0.17). But if you for some reason don't want to update here's the relevant commit.

Hey, thanks for the quick response.  I guess I don't know if this is the same issue or not, but I'm on 0.17
On line 59 of the GetGateway method it's unable to marshal the result
this is res.body: {"code": 0, "message": "401: Unauthorized"}

Well this is strange. Last I tested it it worked fine. I'll look into it tomorrow morning.

Hey, sorry about that, I had a typo on my bot key.  Only the basic bot is crashing.  I'll check it out tomorrow


Introduce "dyn newtype" pattern and convert trait Database to it

Since we are moving more and more things to use dynamic dispatch, it might be worthwhile to introduce this pattern early, as I am already planning to use use it extensively in modularization work.
I've selected Database as a first trait to convert to give this approach a good test.

Do we really want to adopt this pattern everywhere or should we just be implementing this to break the module dependencies?

Do we really want to adopt this pattern everywhere or should we just be implementing this to break the module dependencies?

Not sure what do you mean by everywhere. Generally I think wrapping dyn Trait in a newtype is nice and cleans up the code.

Codecov Report
Base: 72.33% // Head: 67.28% // Decreases project coverage by -5.04% :warning:

Coverage data is based on head (fa370f7) compared to base (9c95d9c).
Patch coverage: 55.44% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #631      +/-   ##
==========================================
- Coverage   72.33%   67.28%   -5.05%
==========================================
  Files          85       86       +1
  Lines       11577    12538     +961
==========================================
+ Hits         8374     8436      +62
- Misses       3203     4102     +899

Impacted Files
Coverage Δ

client/cli/src/main.rs
0.29% <0.00%> (-0.01%)
:arrow_down:

client/client-lib/src/utils.rs
0.91% <0.00%> (ø)

client/clientd/src/main.rs
0.82% <0.00%> (-0.01%)
:arrow_down:

fedimint-api/src/db/mem_impl.rs
84.48% <ø> (ø)

fedimint-api/src/db/rocksdb_impl.rs
56.36% <ø> (ø)

fedimint-api/src/db/sled_impl.rs
47.27% <ø> (ø)

fedimint-api/src/lib.rs
82.20% <ø> (ø)

fedimint/src/consensus/mod.rs
92.98% <ø> (+0.21%)
:arrow_up:

ln-gateway/src/bin/ln_gateway.rs
0.55% <0.00%> (-0.01%)
:arrow_down:

fedimint/src/lib.rs
81.81% <25.00%> (-0.90%)
:arrow_down:

... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

We already use a more limited version of this pattern (using type defs) in quite a few places. I think this will be cleaner and the macro removes most of the overhead. "Everywhere" doesn't mean making a trait for each type imo, just where it makes sense (e.g. API boundaries for mocking, modularization), but doing so in a more consistent manner.

We already use a more limited version of this pattern (using type defs) in quite a few places. I think this will be cleaner and the macro removes most of the overhead. "Everywhere" doesn't mean making a trait for each type imo, just where it makes sense (e.g. API boundaries for mocking, modularization), but doing so in a more consistent manner.

wrapping dyn Trait in a newtype is nice and cleans up the code and I haven't noticed any downsides

Yeah I do think it is nicer, just not a pattern I've seen before, but I'll trust you Rust experts :)


Implement saved scenario deletion

Saved scenarios can now be deleted by users.

When a scenario is deleted, either by clicking the "Delete" button in the scenario list, or selecting "Settings -> Move to Trash" on the scenario page, it is sent to the trash.

Scenarios in the trash may be restored within 60 days of being placed there, after which they'll be deleted permanently.

A user may opt to permanently delete a scenario immediately from the trash.

Admin users will no longer see everyone's saved scenarios.

Closes #3523
Scenario list

Trash empty state

Non-empty trash

Saved scenario

/cc @ChaelKruip

Forgot to mention this in the main post, there are a couple of translations needed, please. 🙏

These please.
These were courtesy of Google Translate, but should probably be double checked.

Wow this is so cool!!!!

Very nice!

Very nice, thanks for implemeting this! The only thing is that locally for me it doesn't look as nice as in your screenshots. As if there's some style info missing. Should I install something extra? I already tried a yarn install.

there are a couple of translations needed

Done 😊

The only thing is that locally for me it doesn't look as nice as in your screenshots. As if there's some style info missing

It looks as though your local Rails app is serving stale assets. Try running bundle exec rails assets:clobber to get rid of any precompiled assets and restart the app. Hopefully, that will fix it.

Hopefully, that will fix it.

It did, thanks!


No more + sources option?

I could have sworn earlier there was an option for a list of sources in cydia to add them from there. What happened to it?

This is not a code-level issue and is therefore closed.
Please submit all eta/wen/halp/etc to https://reddit.com/r/jailbreak or https://discord.gg/jb

That was CyDown, nothing to do with unc0ver


Switch to 0805 for all the passives

0402 is nonsense.

This would require relaying out the entire board. Next time.


LOCAL-8549 - adding placeholder files for localization

@zservies - please approve and merge this PR. Thanks.

@zservies - can you please confirm whether the files to be pointed to develop or main for localization updates. Thanks.

@Pragadeeeshr They should be pointed to Develop


add a few performance test

Codecov Report

Merging #120 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   73.46%   73.55%   +0.08%
==========================================
  Files          41       41
  Lines        1123     1123
==========================================
+ Hits          825      826       +1
+ Misses        298      297       -1

Impacted Files
Coverage Δ

Sources/Layout/SimpleLayout.swift
78.26% <0%> (+2.17%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b78e4b3...46d93e9. Read the comment docs.


Reset state instead of pushing new routes for navigation actions in Drawer

This pull request fixes the issue discovered by @vonovak here: https://github.com/react-community/react-navigation/pull/1914#issuecomment-325816788. Therefore @vonovak would be the perfect reviewer here ;)
The issue is the following: When nesting a StackNavigator with multiple screens inside a DrawerNavigator, the state of this StackNavigator is never reset. Instead the first route is pushed onto the existing Stack. Like @vonovak rightly described in the link I provided this is not ideal and the Stack of the StackNavigator should be reset instead.

I just saw that there's also an issue for this: https://github.com/react-community/react-navigation/pull/3164


Yosys API change breaks .bits

In the latest version of Yosys .bits was changed to .bits(). This should eventually be reflected in the slang frontend.

Can make a quick PR for this if needed

Thanks. I will see if there's a good way to write it in a way which will work both before and after the YosysHQ/yosys#4516 change

Presumably fixed in 7a9960c (in the staging branch)


Help with setup instructions

Hello there.
First of all thank you very much for your work.
I was wondering if it is possible to use this library without spring framework. I am developing custom Keycloak REST endpoints and want some way to test them out. Currently I am using docker to make sure the endpoints work as expected but if there is a way to make use of the mock instead it would be great.
My setup is not as complicated as the examples you provide in this repo. All I have are the two files to define custom REST endpoints (RealmResourceProvider and RealmResourceProviderFactory) then I deploy them via docker for manual testing purposes.
For example looking at the Keycloak provider examples here: https://github.com/keycloak/keycloak/tree/master/examples/providers/rest would it be possible somehow to test the simple GET request using this mock library?
Thank you for your help.
Edit:
Currenrly I can test the endpoints if I first launch a local server and then run the tests:

  @Test
  public void getHello() {
    RestAssured.given().when().get("http://localhost:8080/auth/realms/master/hello").then().statusCode(200);
  }

As far as I understand it, you want to extend your Keycloak server instance by custom controllers. Is that right?
In this case, this library is not the right point to start, I am afraid. Keycloak-Mock is meant to be used for developing resource servers that delegate authentication to a Keycloak server.
For your purposes I suggest looking into registering the resource you have written into an embedded RESTEasy server within your test. See e.g. https://docs.jboss.org/resteasy/docs/4.5.8.Final/userguide/html_single/index.html#RESTEasy_Embedded_Container .

Hello thank you very much for your reply and willingness to help out even though it seems this library cannot be used for what I am trying to do.
I had a quick look at the link you have kindly provided me with and it does look promising. The problem is that some resources (custom endpoints) do require a running Keycloak server which is why I thought this library could be potentially used.
For example trying to have a resource that requires authentication it polls the server to see if the requester has a valid role.
I guess there is no workaround for that?
Using docker might be the easiest option after all. I was hoping to be able to setup a keycloak mock server with a few  configurations such as available roles etc.

As I suspected, there is little I can do to help. If you need server internals like the KeycloakSession, you probably either need to deploy your Resource to an actual Keycloak instance or you need to mock the corresponding logic using standard mocking libraries. This library is only meant for Keycloak client applications.


Can't run

I have followed the build instructions
On run I get this warning then I have no idea which folder to select
After selecting any folder I get these errors.

OS: Ubuntu 16.04

This game requires proprietary resources. Please specify path to installed Assault Horizon (using wine, or whatever), not the Open Horizon's path.
By the way, Assault Horizon is currently on sale on Humble Store.

Thanks. I will try to buy it later


Corrupt download of VSCode using wget continue option

VSCode Version: All (has been happening for months)
OS Version: Windows

This isn't a VS Code issue, but something about the VSCode site configuration. Due to a combination of the way the dowload is configured and a crazy proxy corporation configuration, all my downloads of VSCode are interrupted at 20M. If I try to use a tool as wget to continue an interrupted download, the resulting file is an invalid one.
Steps to reproduce

under cygwin run wget -c --no-check-certificate https://go.microsoft.com/fwlink/?LinkID=623231
the download will fail at more or less 20M
I run again the same command to continue the dowload
rename the file to vscode-win.zip
unzip the file
Try to run Code.exe. The program starts but is corrupted. The main screen is broken.

🤔 Manually downloading the file worked fine, I used Windows Bash through a corporate proxy which also broke the download.

What do you call "manually download"?
Paulo Eduardo Neves
Em 25 de abr de 2017 12:38 PM, "James Gould"<EMAIL_ADDRESS>escreveu:

🤔 Manually downloading the file worked fine, I used Windows Bash through
a corporate proxy which also broke the download.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/25306#issuecomment-297071033,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANfnMAOBftXju1vCjxrLYC7MyDZTC-rks5rzhNggaJpZM4NHpXD
.

Literally went to the link (and installed, but wanted to check the download) to download it through my browser.

the download will fail at more or less 20M

Why does it fail? How long does it take until it fails?
This seems like a problem with your network. You should reach out to your network administrator.


Send commands to the robot using AprilTags

Make it so that if we show the robot different AprilTags the robot does different tasks
Maybe one is for driving commands, one could be some control to the arm
Suggest some more in the comments

i think the branch is in a decent position right now. just need to add more functions and test


1 main code

Closes #1
Added the main code that runs Whisper on audio to generate transcriptions.
When testing, I recommend using the CPU for processing (it is already set to that in the config.yml). If you happen to have a more powerful Nvidia GPU available, then you can change the value to cuda and test it (I will also test it myself using a GPU I have available).
I have also already tested the vad and word_timestamps settings and it seems to be working fine.

Oh and of course it would be really great to add some automated tests, for instance for the config settings.


Organisation filter is too narrow

The organisation filter is far too narrow for the values that need to go in it.

Additionally, with JavaScript turned off, it is far too wide.

Arrghhhh, GitHub. I wish it wouldn't do that.


Application for AirCash test volunteer

Hello Sir/Madam;
I Adoesom. A computer engineering student, I would like to be a volunteer of the Aircash software test. I have been in crypto for the past five years and have had a lot of experience in the crypto space. I have better knowledge in the blockchain technology and understand English very much. I wish to be part of the team that will get AIRCASH and the whole AIRCOIN project to the moon. I want to work with the project in sharing of ideas and all the will benefit the AIRCASH software test.
Thank you.

Your application has been accepted but you have to pass this text which
will also reward you at the end ,click and register on the below link ,pass
the verification process, request for 3000# loan ,pay back the 3000# when
the loan is granted. I don't have to tell you to avoid greed else you will
fail the test
Good luck!!!!
Your friend invites you to use LCredit. Register now to receive N200 cash
voucher immediately. If you successfully borrow money, you can withdraw
N1500 cash reward immediately.
https://lcredit.ng/#/invite_new?userGid=23239492-fa25-40e7-9bf4-cabe552d3fa9&activityId=4
On Sep 14, 2021 9:42 PM, "Adoesom" @.***> wrote:

Hello Sir/Madam;
I Adoesom. A computer engineering student, I would like to be a volunteer
of the Aircash software test. I have been in crypto for the past five years
and have had a lot of experience in the crypto space. I have better
knowledge in the blockchain technology and understand English very much. I
wish to be part of the team that will get AIRCASH and the whole AIRCOIN
project to the moon. I want to work with the project in sharing of ideas
and all the will benefit the AIRCASH software test.
Thank you.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Aircoin-official/AirCash/issues/71, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUP3UVP7V52ECP5JRI3UNGLUB6XVBANCNFSM5EA6325Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Anyone who applied for the AirCash testing please join the discord channel for test volunteers.
https://discord.gg/eRSY7NtxZA


Levelup Messages, Experience gained Plugin, Cow fix

What has been done?
Added correct level up messages in gamechat when reaching certain milestones
Added message reaching target of xp & level in chatbox & resets ur current target
Added a check in cow plugin to now say Moo if dead.
Added a new plugin for gaining experience, similair to level_up.plugin

The only thing I would change is instead of using an attr[] for the last gained experience skill id, would be to pass the skill id to the plugin but it's a non-issue for now.


Toybox printf is printing incorrect hex values

printf of an hex value is printing strange values. Please see the below code
root:/ # printf "%x\n" 100
300000078

64 is expected but it prints strange values.
I am working in android environment. printf in android env uses printf of toybox.
root:/ # which printf
/system/bin/printf
root:/ # ls -l /system/bin/printf
lrwxr-xr-x root     shell             2016-11-14 21:02 printf -> toybox

If this issue is already fixed, please tell the corresponding patch.

On 11/17/2016 09:39 PM, Sandeep Kumar wrote:

I am working in android environment.
printf of an hex value is print string values. Please see the below code
|root:/ # printf "%x\n"<PHONE_NUMBER>78 |
64 is expected but it prints strange values.

I'm getting 64 here... ah, that's what I'm getting with 64-bit glibc.
With 32-bit musl I get:
$ ./printf '%x\n' 100
80539a100000064
Which is very much not right. Hmmm... Ah! printf("%llx", (long)blah);
Fixed. Sorry about that,
Rob

Thank you for the fix.
I am cherry-picking this patch. Thank you.
https://github.com/landley/toybox/commit/46ae1aaea845d4ea3e1cd2b3e005fdb6a6428053

I have confirmed it. This patch fixes the issue
root:/ # printf "%x\n" 100
64

Thank you once again.

sandeep: mark as closed?


Visual Studio 2017 with C++14

Pull Request Test Coverage Report for Build 804327246

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 797663413:
0.0%

Covered Lines:
325

Relevant Lines:
325

💛  - Coveralls

Pull Request Test Coverage Report for Build 804327246

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 797663413:
0.0%

Covered Lines:
325

Relevant Lines:
325

💛  - Coveralls

Fantastic!
Many thanks!


Update style of cards

Is your feature request related to a problem? Please describe.
The content on cards its not show proper.
Describe the solution you'd like
I want to like flip box and adding zoom hover effect. The content will we shown in backward side by using hover effect.
I work on this issue under LGM-SOC'21 participant..please assigned me @Harshal0902

I would like to work on this issue under LGMSOC'21 participant. Please assign me @Harshal0902 if she can't do

@Srit20 I am working on this


Markdown,  question

You must add
 to display line breaks。
If you do not add
, all lines are joined together

Where are you adding ? I mean, what exactly are you referring to, commits, wiki?

@gonboy In markdown you can end a line with a double space, which gets interpreted as a line break.

In standard markdown, you should do following to make a new line:
first line

second line

without using


user-story

As a [role]
I need [function]
So that [benefit]
Details and Assumptions

[document what you know]

Acceptance Criteria
Given [some context]
When [certain action is taken]
Then [the outcome of action is observed]

Add Issue template


filesDownload: The header content contains invalid characters

Hey guys. Whenever I run dbx.filesDownload({path: '/some-non-ascii-filename-for-example-cyrillic'}) I get error error [TypeError: The header content contains invalid characters]
Is it something on my side or this is a reason? https://github.com/request/request/issues/2120

Thanks for the report! We'll look into it!

This is fixed in v2.5.1.


[SUGGESTION] Have imported servers permanently stay saved

There should be a feature where if you import a server it should stay saved in the server loader until its removed. This will make it easier and faster to get in game :D

FYI
Imported servers are deprecated in the next version of ds3os. They caused constant confusion and a lot of unneccessary support.
If anyone needs imported servers anymore they should use an older version.


Add "resize" function

When shrinking, resize to 000px X 000px would be helpful.

What if the img has different dimensions? It has to be cut ... but how?

eather max_width or max_height would be enough.


Fixing build race condition

What was exactly happening?

What was exactly happening?

When you try to build the solution, it fails because it can't lock a resource

What was exactly happening?

When you try to build the solution, it fails because it can't lock a resource

Weird, it was working for me but this wont hurt 👍

What was exactly happening?

When you try to build the solution, it fails because it can't lock a resource

Weird, it was working for me but this wont hurt 👍

If you build projects individually it won't happen, only when you build the solution


Feature/edmtp 199

I have read the CLA Document and I hereby sign the CLA

I have read the CLA Document and I hereby sign the CLA


 Very sus.

Couldn't replicate this issue on latest commit. Replication steps?

Put a stack of coal blocks into the engine and take them out and put them back in repeatedly, and the stack eventually disappears

Lol I forgot to close this after I fixed this issue 😂


The tools hangs after executing a command

Used the tool to remove some test plans.
I could see the output after executing the command but right after I could not use the tool anymore.
Workaround was to force close using task manager and restart the tool and issue a command and repeat this cycle.

Hello,
Could you please share the Azure DevOps (or TFS) version you are using the tool with?
In the newer versions, there are multiple options to remove WIs which are now build into the UI.
Thank you,
Ana

I believe it is TFS2013. If you require the specific version I will check tomorrow morning and add the version.


There doesn't seem to be a wiresmith package for Arch Linux

Hi there,
Wanted to check out wiresmith, thought it would be easy given you list a pacman -S wiresmith (as it says in the README).
However, there doesn't seem to be an Arch package for it?

I created one! Somehow I forgot this.


New plugin: vitest

See https://vitest.dev/config

Done in fd23482af96674332d7b30c9dfe0170c1ab797ea (v1.6.0)


Changed texture alignment to refer to row rather than pixel alignment.

This change is

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable