Thread local memory allocation for BuildHist

This PR allows to use thread local memory for better thread work balance

mortgage, train
train time (master), s
train time (this PR), s
Speedup

BuildLocalHist
10.5
5.9
1.78

ApplySplit
6.6
4.8
1.375

Full train
22.14 - 3
15.62 - 3
1.45

Actually 1 day I went nuts and rewrote all the CPU approximated algorithms.  I think my re-implementation is simpler and has better perf.  Will link a branch later.

Actually 1 day I went nuts and rewrote all the CPU approximated algorithms (hist, approx, local). I think my re-implementation is simpler and has better perf. Will link a branch later.

It's really interesting. Could you share initial version of these changes to compare performance?

Codecov Report

Merging #6358 (7a1bf83) into master (048acf8) will increase coverage by 0.80%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6358      +/-   ##
==========================================
+ Coverage   80.84%   81.65%   +0.80%
==========================================
  Files          12       12
  Lines        3373     3695     +322
==========================================
+ Hits         2727     3017     +290
- Misses        646      678      +32

Impacted Files
Coverage Δ

python-package/xgboost/libpath.py
55.55% <0.00%> (ø)

python-package/xgboost/training.py
96.52% <0.00%> (+0.04%)
:arrow_up:

python-package/xgboost/callback.py
93.15% <0.00%> (+0.54%)
:arrow_up:

python-package/xgboost/dask.py
82.50% <0.00%> (+1.24%)
:arrow_up:

python-package/xgboost/core.py
80.05% <0.00%> (+1.70%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 048acf8...7a1bf83. Read the comment docs.

@trivialfis can we consider these optimizations for upcoming release?

@ShvetsKS Could you please take a look into my impl? https://github.com/trivialfis/xgboost/blob/rebase-local/src/tree/updater_hist.cc  I unified the implementation for all 3 approximated tree methods.  It's not yet done, but very close.  If you agree that it's simpler then I might complete replace the implementation here.

The unification is necessary for categorical data support.

@trivialfis Sure, thanks for providing your implementation. I'm studying it now :)

@trivialfis, Sorry for long response.
I didn't notice any performance improvements and even significant slowdown was discovered compared to master branch. Could you share yours benchmarks results with perf improvements?

train time, s
higgs1m
airline-ohe
mortgage1q
msranks
Santander
plasticc

master
23.8448
56.8644
23.01579
112.164
137.42
1.2505

trivialfis/rebase-local
56.4
130.8829
36.24462
189.9914
302.611
2.196214

Seems current reimplementation of the training flow (in UpdateTreeWithDriver function) still uses old performance oriented kernels (BuildHistogram, PartitionBuilder) but supports only lossguide training mode.
Possibly the reason of slowdown is lossguide vs depthwise comparison but for mortgage1q measurements I used lossguide for both branches and it's strange to see the slowdown.
I'd like to note this PR would be definitely applicable for scope of reimplementation in trivialfis/rebase-local also :).
So is it possible to merge it?
And I'd be glad to help to finish code refactoring/unification but not sure that it can be finished before 1.3 release as there is significant problem with perf.

It supports depthwise.  I don't expect it to be merged anytime soon.  This size of change will take a long  procedure to ensure everything is done right.
I will review the PR as it's later today.

Sorry for wrong assumption. while (!expand_set.empty()) flow in UpdateTreeWithDriver looks very similar to lossguide

To me that's a good thing as now the code path is unified.

@trivialfis seems failed step "continuous-integration/travis-ci/pr" is similar to failed ones in master branch: https://github.com/dmlc/xgboost/commit/4d1d5d401029b72f29a0227843b40d41f53944c6.

Fixed in master by @hcho3.

Fixed in master by @hcho3.

seems all checks are passed


wrangler dev should not fail if it can't open the browser

🐛 Bug report
Describe the bug
wrangler dev assumes it's running in an interactive environment, which is not always true. For example, running on Github codespaces, it's in a remote docker image. The way other frameworks work is they open the local port and codespaces detects that and magically port forwards and gives you a URL to use. E.g. I can run npm run serve on a Vue project, it opens https://localhost:8080 and then access that on my browser via a URL like https://my-project-xxv4q6php6vw-8080.githubpreview.dev over port 80.
It doesn't work with wrangler though, because it tries to pop up the browser with xdg-open and fails hard when that doesn't work the process dies.
$ npx wrangler pages dev ./dist
Compiling worker to "/tmp/functionsWorker.js"...
Compiled Worker successfully.
Serving at http://<IP_ADDRESS>:8788/
/workspaces/eth-registrar/app/web/node_modules/wrangler/wrangler-dist/cli.js:27072
            throw ex;
            ^

Error: spawn xdg-open ENOENT
    at Process.ChildProcess._handle.onexit (node:internal/child_process:282:19)
    at onErrorNT (node:internal/child_process:477:16)
    at processTicksAndRejections (node:internal/process/task_queues:83:21)
Emitted 'error' event on ChildProcess instance at:
    at Process.ChildProcess._handle.onexit (node:internal/child_process:288:12)
    at onErrorNT (node:internal/child_process:477:16)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn xdg-open',
  path: 'xdg-open',
  spawnargs: [ 'http://<IP_ADDRESS>:8788/' ]
}

Reproduce the bug
A list of steps to reproduce the bug.

Open any repo with a Cloudflare worker using https://github.com/features/codespaces
Run npx wrangler pages dev <your output dir>
See error 'xdg-open' failed, and note that there is nothing running.

Expected behavior

Run npx wrangler pages dev <your output dir>
See the url in the console output e.g. http://<IP_ADDRESS>:8788 as per https://github.com/cloudflare/wrangler/issues/1544
Don't fail on the error. Keep the process running with so codespaces sees the open port and allows me to access it the browser on my local machine.

Environment and versions
Fill out the following information about your environment.

operating system: uname -a Linux codespaces_7ecb11 5.4.0-1063-azure #66~18.04.1-Ubuntu SMP Thu Oct 21 09:59:28 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
output of wrangler -V: $ npx wrangler -v 0.0.7
output of node -v: v16.9.1
content of wrangler.toml: none.

NOTE: This is pretty specific to Github code spaces, but other frameworks 'just work'. It would be great if wrangler did too.

This is a wrangler2 issue, and is being tracked here https://github.com/cloudflare/wrangler2/issues/23. Closing this issue.

regarding opening the browser, that was fixed in https://github.com/cloudflare/wrangler2/pull/211. We'll do a publish next week that includes that fix, or you could try with wrangler@alpha.


Fix mstest0036

related to: https://github.com/microsoft/testfx/pull/3881#discussion_r1781133365

Thank you @engyebrahim


Added payload management for CallKeepDidDisplayIncomingCall

In iOS the payload of a PushKit notification is sent to flutter from the native code but then it's not usable because the CallKeepDidDisplayIncomingCall method ignores it.
This Pull Request is done to add the payload management feature to CallKeepDidDisplayIncomingCall.

LGTM


Auth Scheme Interface Proposal

This is my proposal for a potential auth scheme interface. Please give it a read through and expansive criticism!

Maybe you should be able to authorize to the same user you currently are. Tools like sudo and passwd require that, although those are traditionally setuid root I believe.

One overarching thought I have for all this is, how hard is it to make this posix compatible? I'ts a goal to be posix when it doesn't involve some large tradeoff.

That is a fantastic idea. I'll definitely do that.
I don't actually know a lot about posix. I should go read what they have to say about auth. However, when there's BS like the FHS floating around, I'm more inclined to throw posix out the window and use something that is more technically suitable, rather than something that exists only because Ken Thompson didn't have enough space on his first hard drive...

I think that mostly what posix defines are standard commands to have available (probably specifies the flags as well...). That impression is mostly based on this wikipedia entry: POSIX, but also the actual text of the standard (what little I could find): opengroups. With that said I don't think Posix compatibility will be hard at all.
Because Redox uses colons for schemes, colons cannot be used as delimiters in files that have URL's in them. That is a bit of a stumbling block...

Redox moved to GitLab years ago, thus if you still want to merge it, move this pull request to there.
If you still want to contribute to Redox, talk with us in the Matrix chat.


VERSION: Bump to 0.1.3

Signed-off-by: Till Maas<EMAIL_ADDRESS>

This change is

Coverage decreased (-18.1%) to 61.684% when pulling cc807d726949380b9a8a814b7f4e2aecefc15df3 on tyll:013 into 91eec90b8b25f91c0e63477678e347a3db8d3d0b on nmstate:nmstate-0.1.


Issue 3612

Codecov Report

Merging #3 into master will decrease coverage by 21.75%.
The diff coverage is 98.56%.

@@             Coverage Diff             @@
##           master       #3       +/-   ##
===========================================
- Coverage   87.48%   65.73%   -21.76%
===========================================
  Files         410       52      -358
  Lines       63327     2577    -60750
===========================================
- Hits        55403     1694    -53709
+ Misses       7850      809     -7041
  Partials       74       74

Impacted Files
Coverage Δ

go/arrow/schema.go
100% <100%> (ø)

go/arrow/datatype_nested.go
94.44% <100%> (+12.22%)
:arrow_up:

go/arrow/array/table.go
100% <100%> (+1.85%)
:arrow_up:

go/arrow/array/record.go
96.47% <96.47%> (ø)

python/pyarrow/ipc.pxi

cpp/src/parquet/column_page.h

cpp/src/parquet/bloom_filter-test.cc

cpp/src/plasma/client.cc

cpp/src/arrow/io/test-common.h

cpp/src/arrow/ipc/metadata-internal.h

... and 358 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9ee70c...6318bc8. Read the comment docs.


Silly question - how can i "dismiss/close" an Interactable View

Hi, first of all, thanks for a great component!
Just a silly question. I have an interactable view which i've given three snap points. It works great and the user can drag it to any of these positions. But now I want to (programatically) "close" the panel. Such that it animates off the screen (over y axis).
I dont want to set a fourth offscreen snap point, since I dont want the user to accidentally flick the panel off the screen.  I also dont want to just remove the panel from the DOM, since that wouldn't animate.
I tried just changePosition and setVelocity, but both snap back to the final on screen snap point (as you'd kind of expect).
The options that come to mind are:

programatically add a fourth off screen snap point, animate to it, then remove from DOM
setVelocity to animate off screen, and then remove from DOM before it snaps back

but these all feel a little hacky to me. What's the recommended way to "close" a bottom sheet panel like this?

@jliebrand did you have any solution to this?

Nope - in the end I didn't need to close/remove the panel... it's always on screen (albeit small at the bottom) for us now.

@jliebrand you could likely have that 4th snap position there and then maintain whether the component should be allowed to manually close.  If it's not manually closable you can programmatically snap it back to the 3rd position, otherwise handle it the same as if they pressed the close button.  Is that doable?

I hadn't tried the onSnap callback, I guess that could work... slightly depending on when that is called (you wouldn't want it to appear to be snapping offscreen and then popping back onscreen)


Update remove-former-employee-step-1.md

Added information on ## What you need to know about terminating an employee's email session to Step 1 Fixes https://github.com/MicrosoftDocs/microsoft-365-docs/issues/12857

@JohanFreelancer9 Please copy review

@kwekuako Please merge this PR. Thanks


Update Docs: Collections “collection-types”

Automatically generated by Netlify CMS

Hmm. This was broken for me, but seems to work now.


After creating a new folder, it should be selected in the Files Explorer

Description
When I create a new folder, the focus goes to first tab in the Explorer. Instead the newly created folder should be selected so that it can be opened quickly.
Once a new folder is created most likely we want to navigate to that folder to do something inside it. But changing focus to first tab makes no sense. Please fix this
Steps To Reproduce
Create a new folder using New button inside Explorer
check that we can open that folder right away by pressing Enter key because focus is on first tab.
Expected behavior
Newly created folder should be selected in the Explorer view
Files Version
Version: <IP_ADDRESS> OS Version: 10.0.22000.434
Windows Version
Windows 11 21H2 OS Build 22000.434
Relevant Assets/Logs
NA

This is very true, I wish this functionality is enabled by default akin to the default Windows File Explorer!
Appreciate your work @yaichenbaum on Files very much, promise to support you next month.

@rajendrasp merging with #5464
@DefiniteCoding thank you!


how to do similar plantuml support for Power Platform icons

Is it possible to use this project to also include these icons? separate repo? same approach?
https://docs.microsoft.com/en-us/power-platform/guidance/icons
Thanks & Regards,
Stefan

Thank you for opening this issue. Great question!
My first impulse is to say "separate repo", especially if we take into account that we'd want to do the same thing with other icon sets (for instance Microsoft Dynamics 365 icons)
But if we want to use the same approach, we'll also want to use the same automation.
That would mean either duplicating the build scripts to multiple repos, or moving them into a separate project as well.
At that point, we might be better of "just" adding them here, but in that case the project name "Azure-PlantUML" is no longer correct, which would mean a rename (for instance to "Microsoft-PlantUML").
Or we could make a "Microsoft-PlantUML" repo anyway, which would include this repo and other (yet to be created) repos.
I'll have to think about it some more, but I am all for making sure the Microsoft Power Platform icons are also made available to PlantUML!
Maybe some of the @plantuml-stdlib/maintainers have some thoughts about this?

Thanks @Potherca,
I understand your concerns. For now I forked and start playing/understanding how you do it. There is also still icons missing for power platform - I reached out to see whether they can be added.
In our case the final diagram would be representing Azure and Power Platform components how they work together.

At this point, I'm leaning heavily towards splitting the scripts/ directory into a separate repository (maintaining the git history) so the code can be changed to work for other sources as well.
The Power Platform icons woud be a new repository without scripts/ (since it should use the "scripts" repository).
Once everything works, the scripts/ folder could be removed here and the "scripts" repo used instead.
Any decisions regarding a "Microsoft-PlantUML" could then be posponed until later.

We are also working in as dynamics environment combination with azure amd would highly benefit of having those components


docs: add accountId to setup instructions

What this PR does:
This PR updates the Getting started page to include the accountId parameter when initializing PhraseInContextEditorPostProcessor.
Why is this needed?
According to the Phrase docs, we need to add accountId to make the In-context editor work.

@talo242 Thank you for noticing this and your contribution 🙌


Brand - Button accessibility updates

Summary
Adds accessibility fixes related to Brand-Button accessibility review.
List of notable changes:

Added outline on focus when only aria-disabled is applied.
Added focus indicator and 'disabled' style for Windows High Contrast Mode (WHCM).
Added use of 'disabled' and 'aria-disabled' separately.
Hid SVG from screen readers.

What should reviewers focus on?

aria-disabled and disabled now being separated.
Styles for button for when aria-disabled is applied (focus indication, WHCM support)

Steps to test:

Open up component and use aria-disabled attribute control on button. Ensure element is focusable with only aria-disabled being applied.
Test the same as above, but with the "disabled" control, ensure that element is not focusable.
See if WHCM styles are applied.
(This can be tested within Chrome without Windows through Chrome Devtools via the "Rendering" tab. Within the "Emulate CSS media feature forced-colors" section, select the "forced-colors: active" option in the select menu).

Supporting resources (related issues, external links, etc):

Accessibility engineer review for Primer/Brand Button
Windows High Contrast Mode & development

Contributor checklist:

[ ] All new and existing CI checks pass
[ ] Tests prove that the feature works and covers both happy and unhappy paths
[x] Any drop in coverage, breaking changes or regressions have been documented above
[ ] New visual snapshots have been generated / updated for any UI changes
[x] All developer debugging and non-functional logging has been removed
[x] Related issues have been referenced in the PR description

Reviewer checklist:

[ ] Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
[ ] Check that tests prove the feature works and covers both happy and unhappy paths
[ ] Check that there aren't other open Pull Requests for the same update/change

Screenshots:

 Before  After   Why

disabled and aria-disabled applied, no focus indication is present (due to disabled attribute, and existing CSS rule).

Only aria-disabled is applied in this example, retains focus indicator due to element still being focusable.

We'd want to keep the focus outline on the button only when aria-disabled is applied. This is because aria-disabled will keep the button focusable.
This keeps us in check with WCAG 2.4.7 Focus visible.

Focused button (:focus) within WHCM.

Focused button (:focus), within WHCM. Focus outline is present via outline CSS rule.

WHCM by default will strip box-shadow from elements visually, meaning that our current focus indicator that uses box-shadow needs to be supplemented with an outline style. This new rule will only be applied within WHCM (via @media (forced-colors: active)).

@rezrah - Thanks a bunch for checking out this PR! I addressed all your comments, and adjusted the PR slightly. I've included a test for Button too. Let me know if you have any questions, or more feedback!


bug: VirtualizedWheelPicker scrolling breaks when the initial value points to a non-0 index on Android

Expo 51
https://github.com/user-attachments/assets/d59e9312-26bd-4a77-96fc-be0be6d32e74

The issue is still there
https://github.com/user-attachments/assets/8f199a47-c25a-4f99-bae8-cc84f35188e7
I'm using v1.3.2

@evrrnv  Thanks for the video!
It looks like there are performance issues here and because of this, the animation doesn't have time to work. Have you tried changing the windowsSize by any chance? Please create a Snack with an example of this problem.


Refactored plotly backend

Cleanup and refactoring of the plotly backend.

@philippjfr, I did look over it briefly last night and this looks/sounds like a nice generalization that will be useful to support future elements. Thanks!

Okay, I think I'm mostly done here. I think it is indeed a nice generalization which makes writing new plotting element plotting classes a lot easier. One thing that should be generalized further is the way styling is applied, i.e. certain style options are set on the marker while others are set on the data itself and that is not nicely handled yet. However for the time being this is already much more flexible than it was. I've also finally added unit tests for all the element plots.

wow @philippjfr, this is awesome!  The plotly backend is really coming along now!  Everything looks great from my end, and I'm excited to play with it soon 🙂

I've not yet reviewed the code but I do see this PR is introducing a bunch of new notebooks.
I'll be making a PR today updating all the bokeh reference gallery notebooks to use the new options style and I don't want to merge any new notebooks unless they conform to that style as well.


Microsoft pending tickets

num_connections 📟🌍🌎🌐
...     IPv4Address("<IP_ADDRESS>"): 2
Tickets 🎟 assigned to Brian-full stack developer by Microsoft cloud service desk

Products
external IPv6 migration address with Python
Asked 1 day  ago
Modifications underway ⌨
Viewed 221k times
159
Looking for a better way to get a machines current external IP #... Below works, but would rather not rely on an outside site to gather the information ... I am restricted to using standard Python 2.5.1 libraries bundled with Mac OS X 10.5.x
import os
import urllib2
def check_in():
fqn = os.uname()[1]
ext_ip = urllib2.urlopen('http://whatismyip.org').read()
print ("Asset: %s " % fqn, "Checking in from IP#: %s " % ext_ip)

pythonstandard-library
Share
Improve this question
Follow

hash(IPv4Address("<IP_ADDRESS>"))
4035855712965130587

num_connections = {
...     IPv4Address("<IP_ADDRESS>"): 2,
...     IPv4Address("<IP_ADDRESS>"): 16,
...     IPv4Address("<IP_ADDRESS>"): 4,
... }

@Quality assurance please validate before software deployment on the system


Expose CPU, memory, and storage configuration

@sstone1 Can I vote for this as an important issue please ?


Crash and backtrace tracking metrics for istio

At present envoy, mixer, pilot, CA can all crash or core dump and they are auto recovered by K8s.
We should

Track these events as metrics so that we can alert on them
Create an agent process checks different containers for coredumps and gathers deeper information so as to construct a useful bug report.

It may be possible to exploit https://github.com/kubernetes/kube-state-metrics for restart alerts.


Cannot run a line of code

When I run this script in python notebook:
https://github.com/rasbt/python-machine-learning-book/blob/master/code/optional-py-scripts/ch02.py
The last line (ada.partial_fit(X_std[0, :], y[0])) gives the error:
<main.AdalineSGD at 0x10a89fac8>

Thanks for the note. The line <main.AdalineSGD at 0x10a89fac8> is not an error as far as I can tell: The fit and partial_fit methods return the AdalineSGD object (self) itself.  I just updated the code to ada = ada.partial_fit(X_std[0, :], y[0]) to avoid confusion. Let me know if you have any other questions. (PS: In general, I would recommend using the Jupyter notebooks if you have jupyter notebook installed on your machine).
Cheers,
Sebastian


Potential problem with reference to this file?

https://github.com/ansys/pyensight/blob/3686758e46cacda57a93834c6cc2688c32dffc0c/doc/source/calc_functions.rst?plain=1#L3
Is this typo an issue?
.. _caculator_functions:
should be
.. _calculator_functions:

Just FYI, it is a spelling error, but not a bug.   The same name is used with :ref:, so the links all work and the actual string is not visible, it is purely part of the sphinx build process.   We will switch to :doc:, and just remove the line, once the conversion has happened in the api wheel.

This was fixed in #261 and in #10 for ansys-api-ensight .


Java: Building Java package locally fails

It appears that the new location of the prompts is causing build failures for the Java library.

This looks like you are building from the main branch, we are working from the java-development branch


Implement error struct

Other sql drivers returns struct implementing error interface.
Ex.
https://pkg.go.dev/github.com/lib/pq#Error
https://pkg.go.dev/github.com/go-sql-driver/mysql#MySQLError
https://pkg.go.dev/github.com/jackc/pgconn#PgError
https://pkg.go.dev/github.com/denisenkom/go-mssqldb#Error
https://pkg.go.dev/github.com/snowflakedb/gosnowflake#SnowflakeError
Vertica returns pure string Error: [42V01] Relation "my_table" does not exist
The only possible way how to get the error code is parse the string, which is suboptimal.
And Unfortunately it is not possible if errors wrapping is used.

The fix goes into v1.2.1: https://pkg.go.dev/github.com/vertica/vertica-sql-go#VError

So I should use https://pkg.go.dev/github.com/vertica/vertica-sql-go#VError.SQLState, right?
The values are well known and documented.
https://www.vertica.com/docs/9.2.x/HTML/Content/Authoring/ErrorCodes/SQLStates.htm
What value contains https://pkg.go.dev/github.com/vertica/vertica-sql-go#VError.ErrorCode then?
Thanks for the pull request :+1:

@prochac The error code is described in https://www.vertica.com/docs/9.2.x/HTML/Content/Authoring/ErrorCodes/ErrorCodes.htm


Add support for pushing and fetching Neuron compiled text-generation models from the hub

Pre-compiled text-generation neuron models can now be pushed to the hub and retrieved later, allowing to perform an inference without recompiling the model.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Fix off-by-one error with linear color scales

Before/After:

Coverage remained the same at 69.118% when pulling 19526382c7df95ea5ebd0e337d5f85ce206f3db4 on mistercrunch:color_scales into 147c12dddf0da742f1c33c6fee3b2a4b9dbd12c8 on apache:master.

Coverage remained the same at 69.118% when pulling 19526382c7df95ea5ebd0e337d5f85ce206f3db4 on mistercrunch:color_scales into 147c12dddf0da742f1c33c6fee3b2a4b9dbd12c8 on apache:master.

Coverage remained the same at 69.118% when pulling 32742de06e55e341329ecadb64199979ad5daacd on mistercrunch:color_scales into 147c12dddf0da742f1c33c6fee3b2a4b9dbd12c8 on apache:master.

LGTM


Release 1.0.0

Description
Release 1.0.0
Check List

[ ] The commit message is formatted
[ ] New functionality includes testing
[ ] New functionality has been documented
[ ] All user-facing changes accompanied by the correspondent documentation
[ ] All tests pass
[ ] PR include resolved issues
[ ] PR include description

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


CS9077 and CS8350 errors in auto generated godot files

Not sure what i'm missing from the tutorial.  I've gone through it several times, but my project won't build.
Error	CS8350	This combination of arguments to 'AvaloniaControl.InvokeGodotClassMethod(in godot_string_name, NativeVariantPtrArgs, out godot_variant)' is disallowed because it may expose variables referenced by parameter 'method' outside of their declaration scope	GREM	Godot.SourceGenerators\Godot.SourceGenerators.ScriptMethodsGenerator\Grem.Scenes.UserInterface_ScriptMethods.generated.cs	33	Active
Error	CS9077	Cannot return a parameter by reference 'method' through a ref parameter; it can only be returned in a return statement	GREM	Godot.SourceGenerators\Godot.SourceGenerators.ScriptMethodsGenerator\Grem.Scenes.UserInterface_ScriptMethods.generated.cs	33	Active
The auto generated code in question is:
protected override bool InvokeGodotClassMethod(in godot_string_name method, NativeVariantPtrArgs args, out godot_variant ret)     {         if (method == MethodName._Ready && args.Count == 0) {             _Ready();             ret = default;             return true;         }         if (method == MethodName._Process && args.Count == 1) {             _Process(global::Godot.NativeInterop.VariantUtils.ConvertTo<double>(args[0]));             ret = default;             return true;         }         **return base.InvokeGodotClassMethod(method, args, out ret);**     }
Any idea on where to start fixing this?

I was able to get past this by adding this stuff to my csproj:
	<LangVersion>11.0</LangVersion>
	<AnalysisMode>Recommended</AnalysisMode>
	<AvaloniaUseCompiledBindingsByDefault>true</AvaloniaUseCompiledBindingsByDefault>
	<IsPackable>false</IsPackable>

Not sure which one fixed it (probably the avalonia one?), but the project builds.  The designer still won't work.  It's looking in the wrong directory for the dll (the .godot folder instead of the actual bin).  Still trying to figure that one out.  It happens in my project and the sample projects.

Thanks for the report, it's <LangVersion>11.0</LangVersion> that fixes it.
Estragonia targets C# 11, which has a breaking change regarding ref structs escape analysis. Projects targeting C# 10 (which is the default for net6.0 projects generated by Godot) are unable to call the method.
I'll change the target language level used by the library to C# 10 for now, as C# 11 isn't really needed. With this change, consuming projects can be either C# 10 or 11 and it'll work.

Regarding the previewer, which IDE are you using with which plugin? I just tested:

Fresh git clone of Estragonia
Open the GameMenu.sln sample in VS2022 with AvaloniaVS installed
Build the solution
The designer shows without any issue

Same thing with Rider with AvaloniaRider.
What error do you get?
Note that the Godot SDK sets the project output path to .godot\mono\temp\bin so it's normal for the assemblies to be searched there. It should be completely transparent to the previewer, which uses whatever output path is configured.
Would you mind opening another issue or discussion regarding the previewer to keep it separate from the C# errors?

Fixed in 1.0.1: please update if you don't want to have to target C# 11.


A few notes

First of all I have to thank you for the great work you have done on this project. I was looking for what I should start from when constructing an Internet radio and your project turned out to be perfect for it.
I was originally based on a version that was about 5 months old. I made quite a few changes in the meantime, so it was quite difficult for me to upgrade to the new version.
But in any case, I had planned to solve the work with the SD card in a better way, so the new version came in handy.
However, I ran into a few bugs:
1) Mute-unmute
This is a good change, if it concerns control via a web interface or perhaps via a serial interface. But there is no button on my remote that can be used for the "unmute" command. So I made a small modification to the code in the SCANIR routine:
      val = nvsgetstr ( mykey ) ;                           // Get the contents
      if ((val=="mute") && muteflag)
      {
          val = "unmute";
      }

2) Callback function for handle_mp3list
There are even 2 bugs in this feature that cause the first and last track to be missing from the mp3 track selection dropdown and one track is always random.
First you need to change
  if ( index == 0 )                                   // First call for this page?
  {
    i = 0 ;

thus:
  if ( index == 0 )                                   // First call for this page?
  {
    i = 1 ;

This is because a few lines later, path = getSDFileName ( i++ ) is used;
As we know, the meaning of i++ is that i is incremented by one, and then it returns the old value of i !
This means that the first time getSDFileName ( i++ ) is called with i=0 it results in a random track being returned.
A zero value of i has another undesirable consequence. The part of the code where the separator is inserted is skipped (and therefore the first track is missing).
Next, the if ( i >= SD_filecount ) code needs to be changed to if ( i > SD_filecount ), because otherwise the last track is missing.
I made many other adjustments - for example, when selecting a track using the encoder, I can scroll through the list backwards (including jumping to the last track if I get "before" the first track).

I ran into another bug. This manifests itself in a certain situation when controlling via the web interface.
How you can achieve the error behavior:

Select a track using the drop-down menu
Use the NEXT button on the same page - it won't work as expected.
The problem is that when selecting a track using the drop-down menu, the SD_curindex variable is not set.
Then nothing that uses this variable can work - for example, selecting the next track with the NEXT button.
I fixed it in the following way:
in the javascript of the mp3play.html page, I modified the trackreq( ) function:

   function trackreq ( presctrl )
   {
    if ( presctrl.value != "-1" )
    {
      httpGet ( "track=" + encodeURIComponent ( tracks[presctrl.value] ), false ) ;
    }
  }

thus:
   function trackreq ( presctrl )
   {
    if ( presctrl.value != "-1" )
    {
      httpGet ( "trackinx=" + encodeURIComponent ( document.getElementById("seltrack").value ), false ) ;
    }
  }

This resulted in the tracklist index being used instead of the track name (when calling the GET method).

To make it work, I added a new argument "trackinx" to the analyzeCmd() function in main.cpp:

   else if ( argument == "trackinx" ) // MP3 track request?
   {
     getSDFileName ( ivalue );            // Select file by index
     myQueueSend ( sdqueue, &startcmd ) ; // Signal SDfuncs()
   }

Now it works as expected.

I have another note.
I had planned to use this "radio" as an audiobook player, but I found that in its current form it is unusable for this purpose.
The audiobooks I use are in the form of several mp3 files. The names can be something like part01.mp3, part02.mp3, etc.
When playing, the individual files must follow each other in alphabetical order. And here is the problem. Before copying the audiobook to the SD card (on the PC), the files are sorted. However, they are no longer sorted on the SD card. I tried to solve it and now I have a version that works as expected.
The tracks (in the tracklist.dat file) are sorted alphabetically (however, not globally - always only within one directory).
If you are interested, I can of course provide you with my solution.

I still have to add one correction to the adjustments I made.
Although the following code is working
httpGet ( "trackinx=" + encodeURIComponent ( document.getElementById("seltrack").value ), false ) ;
that's pretty clumsy. A better version is this:
httpGet ( "trackinx=" + encodeURIComponent ( presctrl.value ), false ) ;


SWRevealViewController rightRevealToggleAnimated not working in iOS 9

Hi,
Using SWRevealViewController I have implemented right and left slider into my application. while  integrating iOS9 localisation feature into my app  for (Arabic language) then right slider  option not worked (rightRevealToggleAnimated).
have someone face same issue? please help ..
Thanks

What changes does the use of arabic language? Can you test with https://github.com/iDevelopper/PBRevealViewController, a librairie I wrote as SWRevealViewController seems not to be maintained anymore.

Thanks for your quick response...
whenever i changed the language English to arabic, All also implementation to right. Only my right slider not work.

When you write my right slider not work, you mean it does not open or the content is not shown correctly? If it is the case, can upload a screenshot?

Hi iDeveloper, I am not currently able to give as much support on the class as I used to do (health issues), but please stop pushing your own controller for developer code issues that are anyway not related with the SWRevealViewController. This controller is very well supported on the web and used by thousands, so it's not right that you just tell people to replace it by your own. If you really think that yours is superior at least give some credit to me, as your code is blatantly based on my code.

Hi iDeveloper,
while changing  language English to arabic, Click on right menu, slider not open..

It is not possible! Can you post a sample? SW is independent of langage setting...

Yes, you are right! I tested it with one of my sample. It just remains to find out why.

No, sorry it works! Check your target/action of your buttons for opening left and right. You have to test the langage and invert revealToggle and rightRevealToggle if RTL.

SWArabic.zip

Hi ,
hey it working.. Thanks for your help @iDevelopper


Typo

Would open a PR but don't know what was meant to say there
"The and will each run in a Docker container."
/cc @nishanil @IEvangelist

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 83e95a3f-447b-8ca0-beb5-f0363896fe29
Version Independent ID: b24e3ee5-404c-98a2-042e-6ac2d363b842
Content: Get started with Dapr
Content Source: docs/architecture/dapr-for-net-developers/getting-started.md
Product: dotnet-architecture
GitHub Login: @amolenk
Microsoft Alias: nanil

I believe it means to say "They will each run in a Docker container." @nishanil does that sound accurate?

Added PR #22894 to fix this.


Sample description is a generic placeholder text

The sample description has a placeholder text, it reads: "Introductory text that explains what the sample is intended to demonstrate. Edit in template-params.xml.".
This is shown both on github and in the "import sample" dialog in Android Studio.

This sample has been deprecated/archived (check README for more information on newer samples related to this technology).
As recommended by GitHub, we are closing all issues and pull requests.


Update screenshots

Updated a majority of the screenshots to reflect the present version of the hud. Album link is still the same: https://imgur.com/a/aJ1K5


Revisit all current dashboards to add new and remove unneeded to make them more useful for catching bugs.

Brian tries to provide some useful ones in
https://grafana.com/orgs/robustperception/dashboards
Need to monitor current bugs, talk to the maintainers and make the dashboards more useful to catch bugs during the bench tests.
Current dashboards are not bad, but there is room of improvement.
http://prombench.prometheus.io/grafana

Few ideas:

[ ] add rules
[ ] add metrics for the time and size retention to make sure it works as expected

Or wait for me to update my dashboards, which already have those ;)

lets put this on hold for now and will revisit in 1-2 months.

Adding the new dashboards should become easier after #293 is merged.


Add more crates.io metadata & use travis for docs

Also, enable faster builds on travis. http://blog.travis-ci.com/2014-12-17-faster-builds-with-container-based-infrastructure/

Basket-baller! :sparkling_heart: :dash:


Resolve Foodcritic FC005 / FC023 warnings

Cookbook version
master
Chef-client version
12.9.38
Platform Details
All
FC005: Avoid repetition of resource declarations: ./libraries/httpd_service_debian.rb:144
FC005: Avoid repetition of resource declarations: ./libraries/httpd_service_debian.rb:304
FC023: Prefer conditional attributes: ./libraries/httpd_service_debian.rb:224
FC023: Prefer conditional attributes: ./libraries/httpd_service_rhel.rb:125
FC023: Prefer conditional attributes: ./libraries/httpd_service_rhel.rb:269
FC023: Prefer conditional attributes: ./libraries/httpd_service_rhel_systemd.rb:6
FC023: Prefer conditional attributes: ./libraries/httpd_service_rhel_sysvinit.rb:5

FC005 is resolved. FC023 has a few remaining issues as it incorrectly warns on provides which does not implement only_if and not_if.


[RPM M6] Validate package running

Tasks
Estimate
Status
Notes
Dependencies

Use systemd to start/stop the software service, and check whether the log output match the process manager status messages
2
Not Started

All of these requires us to create pipelines to automatically run these tests for validations

Test the start time of the services through API and setup a threshold
2
Not Started

All of these requires us to create pipelines to automatically run these tests for validations

Executing software binary directly without systemd if systemd could not bring service up in time
2
Not Started

All of these requires us to create pipelines to automatically run these tests for validations

Tested in #1912 #2000 for both validation and integTest.


deleting a resource can fail

This code is not going to work well for deleting a resource:
https://github.com/kudobuilder/kuttl/blob/f6d64c915c8dd9e2da354562c3d5c6fcf88aec2b/pkg/test/step.go#L205-L207
The deletion should be retried.

@eddycharly I'm curious what were some situations where you saw a deletion failure?


Adding staged support for MongoClusters

In an upcoming release, vscode-databases will add support for MongoClusters. Once this new feature is available, a custom field will be included in the package.json of vscode-databases. This field will serve as a switch to enable or disable MongoClusters support.
The motivation behind this approach is to avoid advertising MongoCluster nodes prematurely while we work on the public release of the vscode-extension.
Once MongoClusters support is officially released, we will remove the staging code.

I forgot / missed the squash option..


Issue #227: Makes the output path optional

The output-path argument defaults to a file path whose directory is derived from the  path_to_XLSForm argument, with a filename similar to that of the XLSForm but with the .xml extension
behaviour:
>>> xls2xform /path/file.xlsx

The output_path for the xform will be =>   '/path/file.xml'
fixes #227

Codecov Report

Merging #302 into master will increase coverage by 0.26%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
+ Coverage   81.47%   81.74%   +0.26%
==========================================
  Files          23       23
  Lines        3126     3111      -15
  Branches      733      730       -3
==========================================
- Hits         2547     2543       -4
+ Misses        447      431      -16
- Partials      132      137       +5

Impacted Files
Coverage Δ

pyxform/xls2xform.py
72.3% <83.33%> (+28.97%)
:arrow_up:

pyxform/validators/odk_validate/__init__.py
61.53% <0%> (-12.47%)
:arrow_down:

pyxform/survey_element.py
88.44% <0%> (-1.61%)
:arrow_down:

pyxform/xls2json.py
76.68% <0%> (-0.24%)
:arrow_down:

pyxform/xls2json_backends.py
83.41% <0%> (-0.08%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1df288d...a5b025b. Read the comment docs.


CFP: WireGuard node-to-node strict mode

Cilium Feature Proposal

Is your proposed feature related to a problem?
Node-to-node encryption is only eventual encrypted due to Endpoint/CiliumNode to IPCache propagation being delayed and only eventual consistent.
Describe the feature you'd like
I need a way to enforce encryption for all cluster-to-cluster (i.e. pod-to-X, node-to-X) traffic.
(Optional) Describe your proposed solution
A CIDR based strict mode (similar to the pod-to-pod one).
This solution comes with some caveats:

The underlying threat model only makes sense if node-to-node traffic to control-plane nodes is also encrypted
If all node-to-node traffic must be encrypted this would include the etcd traffic (for a stacked K8s architecture). Since during kubeadm join the etcd connects to the other etcds one needs to allowlist its ports (2379 port and 2380) for the node CIDR.
Since in our architecture the kubeAPI server is only accessed via a LB with an IP outside of the nodeCIDR, there is no need to explicitly allow this connection. But different architectures have different requirements here.

I already have a working version (for us, on GCP(direct routing), AWS(vxlan), Azure(vxlan)) including tests in clilium-cli (at the moment only for direct routing, but I'll implement tunneling soon). I'll open a draft PR for you to have a look.
Given the caveats and the current implementation I don't really see that the implementation is upstreamable. But I'm happy to do so if you think otherwise or have improvement suggestions for the implementation.

The question is what to do about those architectures which have the control-planes excluded from node-to-node encryption. One can either add some complexity to the whole thing to allow a more insecure mode in which the control-plane node traffic does not need to be encrypted or exclude those use-cases.
I personally don't see a huge (security) benefit for the first case and therefore would opt for excluding the use-case.
In any case, I think that a node-to-node strict mode which also allows the 2nd use-case builds on top of the first. So we'd need to build the first architecture anyway.

EDIT: What I think is a better solution than to disable node-to-node encryption completely is to allowlist certain ports/connections. This is what I do for etcd at least.

Yeah, I think that would be the ideal solution, it's something that has been requested quite often even outside of node-to-node encryption. However, it is probably not that easy to implement.

A "cheaper" solution might be to allow strict mode to allow unencrypted traffic for certain IPCache entries. For example, if an IPCache entry is present and does have encryptKey=0, we could allow that traffic to not be encrypted, even if it's IP address is part of the "strict" CIDR. That approach however is problematic if IPs can be reused, i.e. if an IP of a previously unencrypted node is re-assigned to a node (or pod) that now requires strict encryption.
I think the "allow certain ports/connections" solutions might suffer from similar problems though, depending on how dynamic or static the allowlist is.

A "cheaper" solution might be to allow strict mode to allow unencrypted traffic for certain IPCache entries.

I also thought about that because it is especially neat to re-use the allow-remote-node-identities from the pod-to-pod strict mode. Sadly, I don't think it is sufficient in e.g. the etcd's case. When the etcd talks with the other etcds there is no K8s Node entry or similar. So I don't see what we could use to differentiate the joining node's traffic from unwanted unencrypted traffic.
Of course, using the IPCache should fix the case when the control-plane node has already joined.

I need a way to enforce encryption for all cluster-to-cluster (i.e. pod-to-X, node-to-X) traffic.

Sorry for bothering, just willing to provide some userstory for this feature:
We want to create k8s cluster on Hetzner hw nodes. All nodes there have public IP, and optional internal IP. It could be only 100 internal IPs connected to one "vSwitch" and we want to run 200+ nodes. Also vSwitch connection has lower MTU, and worse latency/bandwidth between 2 same nodes, compared to measuring between their public IPs. Even if we create wireguard tunnel between public IP, tests show better results in tunnel than over "vSwitch".
So, we want to setup k8s network on public IPs, obviously everyone would want encryption in this case. And cilium has wireguard support - great!
Starting simple - 3 nodes, with etcd/controlplane stacked via kubeadm. K8s API VIP is on internal vSwitch IP. Deploying cilium v1.14.2 in kubeProxyReplacement: true, tunnel: vxlan mode and cilium-test all passing. Just adding:
encryption:
  enabled: true
  type: wireguard
  nodeEncryption: true
extraConfig:
  node-encryption-opt-out-labels: ""

And already some problems:

wireguard uses internal interface for tunnels, but we want it via external. Figured out that it is possible to change that by editing ciliumNode.spec.addresses.InternalIP to external IP of each CiliumNode object. This breaks couple of tests from cilium-test.
There are per-pod tunnels:

root@k8s-master-1:~# wg show
interface: cilium_wg0
  public key: xxx
  private key: (hidden)
  listening port: 51871
  fwmark: 0x1e00

peer: xxx
  endpoint: <IP_ADDRESS>:55197
  allowed ips: <IP_ADDRESS>/32, <IP_ADDRESS>/32, <IP_ADDRESS>/32, <IP_ADDRESS>/32, <IP_ADDRESS>/32, <IP_ADDRESS>/32, <IP_ADDRESS>/32, <IP_ADDRESS>/32, <IP_ADDRESS>/32
  latest handshake: 1 minute, 16 seconds ago
  transfer: 168.07 KiB received, 152.25 KiB sent

peer: xxx
  endpoint: <IP_ADDRESS>:39104
  allowed ips: <IP_ADDRESS>/32, <IP_ADDRESS>/32, <IP_ADDRESS>/32, <IP_ADDRESS>/32, <IP_ADDRESS>/32, <IP_ADDRESS>/32, <IP_ADDRESS>/32, <IP_ADDRESS>/32, <IP_ADDRESS>/32
  latest handshake: 1 minute, 27 seconds ago
  transfer: 59.33 KiB received, 224.46 KiB sent

And this cluster is empty yet. I don't believe this is scalable solution for 200+ node cluster, if each node would have specific tunnel with per-pod granularity and constantly update them keeping up with pod churn.

Some traffic still not enrypted. Found that it has been improved in v1.15 and tested on 1.15.0-pre.0 with:

encryption:
  enabled: true
  type: wireguard
  nodeEncryption: true
  strictMode: # v1.15
    enabled: true # https://docs.cilium.io/en/latest/security/network/encryption/
    cidr: <IP_ADDRESS>/16
extraConfig:
  node-encryption-opt-out-labels: ""

and it breaks in ~10min as per-docs, probably due to unable to renew encryption key from master
Unfortunately cilium implementation of wireguard is overly complicated. I believe good example of how this could been done is https://kilo.squat.ai
Workaround for case above looks like this:

Each node runs Kilo daemonset, which configures full mesh node-to-node wireguard on public IPs
This ends up as network interface with internal subnet shared by all nodes. (We remove 100 nodes limit of vSwitch here)
We use this interface to run cilium on top in tunnel: disabled mode
Kilo reads cilium cluster-pool IPAM subnet from each node, and only creates routes for node podCIDR, not for each pod. This is pretty static info, no need to constantly keep it up with pod churn
No double encapsulation, and nodes could be in different subnets
Cilium host firewall still works

This way all pod-to-X, node-to-X traffic uses Kilo interfaces and is encrypted. There is non-wg traffic from kubelets to k8s API VIP, and etcd traffic but it is TLS and on internal subnet.

A CIDR based strict mode (similar to the pod-to-pod one).

Sorry for taking your time with this long read. My point is that maybe instead of complicating encryption implementation with each version it is worth to make some "dump-mode" like Kilo or KubeSpan?
What about "CIDR based strict mode" which works based on podCIDR of each node, so there could be no traffic for "newly created pod not yet in cache"?
I understand there is always complications like crossed pod and nodes subnets etc. But "dump mode" should not fix all cases, it could be just default which solves 80% of cases with same limitations as in KubeSpan.

Hey, thanks a lot for engaging in the discussion and bringing up those points. I always enjoy it when people care about their security. In general, I think that it's great that you've found a solution which fits your needs. We use Cilium as part of our own confidential Kubernetes distro. Therefore we need to support a multitude of deployment options while keeping the ease of use and monitoring capabilities of Cilium.
I have some follow-up questions:

I don't believe this is scalable solution for 200+ node cluster,

Do you have encountered any issues? One of the features this allows is that not every deployment uses full CIDR blocks for each node e.g. when Azure with direct routing is used. There the IPAM controller just assign whatever IP is free during the start of a new pod. On the other hand, one could conditionally optimize this, when PodCIDRs are used. Once scalability issues arise, I think this is worth implementing.

and it breaks in ~10min as per-docs, probably due to unable to renew encryption key from master

What does break? As documented the current strict mode only works on Pods. The encryption keys should be distributed by the cilium-agent making requests to the KubeAPI. So this is node-to-node communication which does not fall under the strict mode. I am happy do have a look at a full issue description to figure out what and why this breaks.

What about "CIDR based strict mode" which works based on podCIDR of each node, so there could be no traffic for "newly created pod not yet in cache"?

Do you refer back to your point about the scalability of having an entry for each pod in the WireGuard? The strict mode itself just takes the pod CIDR of the whole pod network.
Personally I think that Cilium's encryption must also consider and secure the Cluster when e.g. Azure direct routing is used. Therefore, it's encryption (as many of Cilium's subsystems) is based on singular identities. So I don't really see a way to change or "dump down" the current implementation for a subset of architectures, but maybe the actual maintainers do?

FYI: You can have a look on our current downstream implementation here: https://github.com/cilium/cilium/pull/28612.
Maybe we use it as a basis for a upstream solution.

I believe this is still relevant

Correct me if I'm wrong, strict mode CIDR doesn't care if it's pod-to-pod or node-to-node, this seems to me that we want to specify multiple strict mode CIDRs, such as encryption.strictMode.cidrs=$pod_cidr,$node_cidr, correct? Other than that, it's a problem of "allowlist" to always allow plain-text traffic from host to control plane.

strict mode CIDR doesn't care if it's pod-to-pod or node-to-node

Yes, one can implement it that way. though in our downstream implementation we made a distinction to only have an port allow list that only pokes a hole into the node CIDR.

it's a problem of "allowlist" to always allow plain-text traffic from host to control plane.

Essentially yes, we had to allow the etcd ports for control-plane to control-plane traffic. In our specific setup allowing KubeAPI wasn't needed as it is routed over an poxing LB outside of the strict ranges. But for a general setup this is likely needed.


Update text2command to 3.0.3

https://github.com/ioBroker/ioBroker.text2command/issues/312

3.0.3 created 18.12.2023
890 user
OK


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 1.10.146 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


How do I zoom an image using nearest-neightbor scaling?

I'm trying to use Piston to make a 2D pixel-art game, and as part of that I need to zoom the textures by 2x. Unfortunately, when I scale the images, Piston uses a standard, blurry, scaling algorithm. What I need is a simpler, sharper scaling algorithm, such as NN. Here's my code:
    let transform = c
        .transform
        .trans(x as f64, y as f64)
        .zoom(2.0);
    image(tile, transform, gl);

Here's what my scaled image looks like (just one tile):

You can set scaling method when creating texture:
let tex = Texture::from_path(
                factory,
                "tex.png",
                Flip::None,
                &TextureSettings::new().mag(texture::Filter::Nearest);

Closing.


fix fully correlated conditional repeat shapes

Fix shapes returned by fully_correlated_conditional_repeat
There's inconsistency between shapes of fmean and fvar returned by fully_correlated_conditional_repeat. This causes problems with downstream functions for sampling.
Minimal working example:
This test catches the bug:
@pytest.mark.parametrize("func", [fully_correlated_conditional_repeat,
                                  fully_correlated_conditional])
def test_fully_correlated_conditional_repeat_shapes(func):
    L, M, N, P = Data.L, Data.M, Data.N, Data.P
    R = 1

    Kmm = tf.ones((L * M, L * M))
    Kmn = tf.ones((L * M, N, P))
    Knn = tf.ones((N, P))
    f = tf.ones((L * M, R))
    q_sqrt = None
    white = True

    m, v = func(Kmn, Kmm, Knn, f,
                full_cov=False,
                full_output_cov=False,
                q_sqrt=q_sqrt,
                white=white)

    assert v.shape == m.shape

Output before fix:
func = <function fully_correlated_conditional at 0x7ff689444268>

    @pytest.mark.parametrize("func", [fully_correlated_conditional_repeat,
                                      fully_correlated_conditional])
    def test_fully_correlated_conditional_repeat_shapes(func):
        L, M, N, P = Data.L, Data.M, Data.N, Data.P
        R = 1

        Kmm = tf.ones((L * M, L * M))
        Kmn = tf.ones((L * M, N, P))
        Knn = tf.ones((N, P))
        f = tf.ones((L * M, R))
        q_sqrt = None
        white = True

        m, v = func(Kmn, Kmm, Knn, f,
                    full_cov=False,
                    full_output_cov=False,
                    q_sqrt=q_sqrt,
                    white=white)

>       assert v.shape.as_list() == m.shape.as_list()
E       assert [3] == [20, 3]
E         At index 0 diff: 3 != 20
E         Right contains more items, first extra item: 3
E         Use -v to get the full diff

tests/test_multioutput.py:314: AssertionError

@marctom thanks for spotting this and fixing it ! Looks good, I'm only wondering if we might ever end up with an fvar that has an undefined shape with fvar.shape.ndim being None (which would break the code you added)?

Many thanks for looking into this.
Dynamic shapes are indeed painful - fortunately they go away eager mode!
But in this case I'm not sure if I fully understand; fvar.shape.ndims returns the number of dimensions, regardless of what they are specified or not as here:
In [1]: import tensorflow as tf

In [2]: a = tf.placeholder(shape=(None,10), dtype=tf.float32)

In [3]: a.shape
Out[3]: TensorShape([Dimension(None), Dimension(10)])

In [4]: a.shape.ndims
Out[4]: 2

The code could indeed break if we used a dynamic shape of one tensor to reshape another, but we don't do this.

If you just do a = tf.placeholder(dtype=tf.float32), then a.shape.ndims is None... and that is what actually happens in the DataHolders! Can you replace it with tf graph code that builds the shape dynamically?


2.x compaction daemon crash with parallel view compaction & speedy DB compaction

Description
If parallel_view_compaction is enabled in the 2.x compaction daemon, and database compaction completes before view compaction on a given database, a crash of the following sort occurs:
<0.220.0> -------- Supervisor couch_secondary_services had child compaction_daemon started with couch_compaction_daemon:start_link() at <0.257.0> exit with reason {compaction_loop_died,{badarith,[{couch_compaction_daemon,maybe_compact_db,3,[{file,"src/couch_compaction_daemon.erl"},{line,213}]},{couch_compaction_daemon,'-compact_loop/1-fun-0-',3,[{file,"src/couch_compaction_daemon.erl"},{line,150}]},{couch_server,'-all_databases/2-fun-0-',4,[{file,"src/couch_server.erl"},{line,330}]},{couch_util,fold_files2,6,[{file,"src/couch_util.erl"},{line,110}]},{couch_util,fold_files2,6,[{file,"src/couch_util.erl"},{line,115}]},{couch_server,all_databases,2,[{file,...},...]},...]}} in context child_terminated

Steps to Reproduce
Tricky, but possible. Try making a DB with some views that all need compaction, and is big enough so that compaction completes slowly.  Then, enable the compaction daemon with a config such as:
[compactions]
_default = [{db_fragmentation, "70%", {view_fragmentation}, "1%"}, {parallel_view_compaction, true}]

Expected Behaviour
Compaction daemon doesn't crash.
Your Environment

CouchDB version used: 2.3.1
Browser name and version: n/a
Operating system and version: Debian 10.x

Additional Context

2.x is done, this isn't going to get fixed.


Add basic support for Proxy Protocol

@flashmob
Could you please

Re-run the latest that CI build. Some random flake crept into one of the jobs.
Review the PR

@flashmob When would you have some time to look at this PR.


[Auth] Support for Server Side Pages

Currently, the authContext is processed in the client side. which would cause issues for server-side pages like the question page.

After reading authenticating-server-rendered-pages, would like to know if session will be supported in the current auth pattern.
Thankss

We are planning to use JWT authentication, which would require us to store the token somewhere on the browser, and in the current implementation, we were planning to store it in local storage, which would require client-side rendering. I did a quick search on this and it seems we can use server-side rendering if we store the JWT in cookies instead. However, it is not as straightforward since the JWT strategy in passport.js does not support it directly (but I think it can be done?), and we were not planning to use Next-Auth since we want to run Auth Service separately.
Just curious, is there any strong reason for us to use server-side rendering? If we want to stick to server-side rendering, then I will relook at the implementation for the JWT and the AuthContext. @c0j0s @tryyang2001

Oh from my past experience of using Next-Auth, the JWT token is stored in the cookies, so this does not have any impact on server-side components. I think it is better to store it in the cookies though.

is there any strong reason for us to use server-side rendering

The two main reasons I can think of is the speed and efficiency. Client-side rendering is very slow, especially when we have a large content to load (which is our case for question detail page). There will be a huge rendering speed difference if the question detail page is client component vs server component. Of course we can do caching to make subsequent page loading becomes much faster, but the first load without the cache is always slow. Also, if the page has no user-interaction needed, which is also the case for our question detail page, then I think the best is to do SSR.

Okay, I'll change to the cookie way and also utilise getServerSideProps for auth in order to support server-side rendering. Did not really look into server side rendering, so thank you @c0j0s and @tryyang2001 for bringing it up! 😄

Thank you, and btw the above Next-Auth function is just an example that I want to show haha, feel free to find any other alternatives to achieve the same result!

Seems like this has been resolved in #105


Implement a search function for the main menu HUD list.

At some point the HUD list on the main menu will be too long, so a search function will need to be implemented.

This is not a high priority at this time as we only have 5 HUDs officially supported.


Does the debug on SegmentConfig parameter has an effect on Android?

There's a parameter called debug on SegmentConfig class. In the documentation, it's stated that it's not possible to set a value to debug dynamically. Is the value passed into debug used on Android or do we have to add a metadata into AndroidManifest.xml?

Hi @SametSahin10
Im not sure if I totally understand your question.
You need to send the value you need it in the SegmentConfig constructor when you are configuring the SDK,


Confusing behavior of GRUCell

cell = layers.GRUCell(4)
x = tf.random.normal((2, 2, 3))
print(cell.get_initial_state(x)) # returns a single tensor
cell(x[:, 0], [cell.get_initial_state(x)]) # requires and returns a list of tensors

Why would GRUCell.get_initial_state return a Tensor, while calling GRUCell requires a list of Tensor as input? Is this a desired behavior? (code tested in TF2.1)
Furthermore, while Cell returns output and state separately, RNN returns the output and states together in a single list.
cell = layers.LSTMCell(4)
x = tf.random.normal((2, 2, 3))
s = cell.get_initial_state(x)
cell_output, state = cell(inputs=x[:, 1], states=s)# works fine
print(cell_output)
print(state)
rnn = layers.RNN(cell, return_state=True, return_sequences=True)
rnn_output, state = rnn(x, initial_state=s)# error: rnn returns the output and states in a single list

I'm wondering why rnn and cell behave differently?

@xlnwel
I have tried on colab with TF version 2.1.0 and and i am seeing the below error ValueError: too many values to unpack (expected 2). Is this the expected behavior?. It will be helpful if you provide a colab link to reproduce the issue in our environment. It helps us in localizing the issue faster. Thanks!

A Cell processes a single time step, while a RNN processes all time steps. Setting return_sequences = True in RNN returns three values, of shapes [batch_size, time steps, output_shape], [batch_size, output_shape], [batch_size, output_shape].
Check the example on the TF LSTM page

@ravikyram Yeah, the code provided by me will raise error ValueError: too many values to unpack (expected 2) at the last line. Here's the colab link I use for test. I humbly think that it will be easier to use if

cell.get_initial_state(x) returns a list of tensor, where cell could be any RNN cell, including GRUCell, whose state is a single tensor.
when RNN is parameterized by return_state=True, rnn(x) returns the output and RNN state, where RNN state is a list of tensors. That means for LSTM, rnn(x) returns [output, [h, c]], and for GRU, rnn(x) returns [output, [state]]

That's my personal suggestion. But I believe you team designed the behavior for a reason, I'd like to hear that.

@Susmit-A, thanks for point out the different behavior of Cell and RNN, although I've already known them before. Please check this colab link and the comment above.

@xlnwel GRU is a recurrent layer. GRUCell is an object (which happens to be a layer too) used by the GRU layer that contains the calculation logic for one step.
A recurrent layer contains a cell object. The cell contains the core code for the calculations of each step, while the recurrent layer commands the cell and performs the actual recurrent calculations.
As this is not a bug, please post this issue in stackoverflow where there is a broader community to help. Thanks!

Hi, @gowthamkpr. Thanks for your explanation. I know the difference between GRU and GRUCell, and I was not saying this is a bug. I just found their different styles of outputs are confusing and hard to use. Therefore, I'm wondering why you decided to adopt different behaviors for them? Please check my colab link.


tint in ParticleContainer

Trying to fix #3777

I didnt think it would be approved that fast :)

@ivanpopelyshev is it possible to see a jsfiddle example of this functionality?

@bigtimebuddy it is possible in pixi-examples, just run https://pixijs.github.io/examples/#/basics/basic.js with current version and with new one. Suddenly, tint starts working!

Verified! Great work @ivanpopelyshev, you're a machine


Adding border only to the one side of the  component in React Native (iOS)

I am facing something weird issue with React-Native's <Text/> component in iOS.
I wanted to apply borderBottomWidth style into <Text/> component but it did NOT work. However, the borderWidth option worked.

Worked

<Text style={{borderWidth:1}}> React Native </Text>

NOT Worked

<Text style={{borderBottomWidth:1}}> React Native </Text>

Is there any way to only apply bottom level border into the <Text/> component?
Thank you!
(I have added same question in StackOverflow)

Note:
I am aware of following mentioned approaches in order to achieve this but in my case, I required to apply the style only to the <Text/> component.

We can try wrapping <View/> to the <Text/> and apply borderBottomWidth style to the <View/>. (borderBottomWidth works fine with <View/>)
Adding such <View/> just below to the <Text/> component  which can look like a line.

This isn't currently possible. See the following RN issue: https://github.com/facebook/react-native/issues/29 and this ticket on Product Pains: https://productpains.com/post/react-native/add-borderwidth-left-right-top-bottom-to-textinput-/

@facebook-github-bot answered

@facebook-github-bot answered

ddd


TimeoutSampler: Print func and func kwargs before start loop

Short description:
If the user is not set it's own log the current log is useless, for example:
ocp_resources.utils 2021-09-03 21:44:05 INFO Waiting for 120 seconds, retry every 1 seconds
mean nothing.
This have more info:
ocp_resources.utils 2021-09-03 22:20:41 INFO Waiting for 120 seconds, retry every 1 seconds. (Function: utilities.infra._get_not_running_pods None)

Improve func_log to return real names.
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

/verified

Some examples:
ocp_resources.utils 2021-09-03 22:37:28 INFO Waiting for 240 seconds, retry every 1 seconds. (Function: openshift.dynamic.client.get Kwargs: {'field_selector': 'metadata.name==vma-1630708647-4465601', 'namespace': 'general-test-veth-removed-after-vms-deleted'})

ocp_resources.utils 2021-09-03 22:39:02 INFO Waiting for 240 seconds, retry every 1 seconds. (Function: ocp_resources.resource.lambda: exists)

/verified

/verified
ocp_resources.utils 2021-09-03 22:58:41 INFO Waiting for 240 seconds, retry every 1 seconds. (Function: ocp_resources.resource.client_wait_deleted.lambda: exists)

/verified

/approve


matrix-synapse: 1.36.0 -> 1.37.0rc1

Motivation for this change
https://github.com/matrix-org/synapse/releases/tag/v1.37.0rc1
Things done
I've deployed this on my homeserver and things seem to be fine.

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 128020 at 64a026d6 run on aarch64-linux 1

2 packages built successfully:

matrix-synapse
matrix-synapse-plugins.matrix-synapse-mjolnir-antispam

Looks like we are going to have a pretty quick point release: https://github.com/matrix-org/synapse/releases/tag/v1.37.1rc1 due to issues arrising from: https://mobile.twitter.com/matrixdotorg/status/1409873992454967304

Heh, good for me that I've disabled registration %)
Let's not backport then, though and await 1.37.1.

Opened https://github.com/NixOS/nixpkgs/pull/128777.


Private Link is not supported for the Custom Host origin type

[Enter feedback here]
https://docs.microsoft.com/en-us/azure/frontdoor/private-link#limitations
As limitation, I think it should be good to add that the Private Link is not supported for the "Custom Host" origin type.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f4fda9db-3e28-e2d9-c1f1-c5af1210251f
Version Independent ID: 10c59f1d-138f-63a0-960a-f112694510c9
Content: Secure your Origin with Private Link in Azure Front Door Premium
Content Source: articles/frontdoor/private-link.md
Service: frontdoor
GitHub Login: @duongau
Microsoft Alias: duau

Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

Hello @tcsougan, the Custom Host origin type is used when you're using an ILB as an origin. Please see how on how that works: https://docs.microsoft.com/en-us/azure/frontdoor/standard-premium/how-to-enable-private-link-internal-load-balancer.

Thank you @duongau !


pip-compile crashes on a setup.py that contains entry_points

If my setup.py contains entry_points, I get an error.
Environment Versions

OS Type: macOS 10.12.6
Python version: Python 3.6.2
pip version:  pip 9.0.1
pip-tools version: pip-compile, version 1.10.1

Steps to replicate

Create a new directory
Add a setup.py with the following content
Run pip-compile

from setuptools import find_packages, setup

setup(
    name='myproject',
    description='My awesome project',
    url='https://example.com/',
    author='Adam Brenecki',
<EMAIL_ADDRESS>    license='Proprietary',
    setup_requires=["setuptools_scm>=1.11.1"],
    use_scm_version=True,
    packages=find_packages(),
    include_package_data=True,
    install_requires=[
        'dj-database-url',
        'django-csp',
        'django-form-utils',
        'django-redis',
        'django-stronghold',
        'django-widget-tweaks',
        'Django[argon2]',
        'psycopg2',
        'python-decouple',
        'raven',
        'waitress',
        'django-webpack-loader',
    ],
    extras_require={
        'dev': [
            'pre-commit',
            'prospector',
            'pytest',
            'pytest-django',
        ]
    },
    entry_points={
        'console_scripts': ['sl-admin=sl-admin.manage:main'],
    }
)

Expected result
A requirements.txt is produced. This is the result I get with the exact same setup.py but without entry_points.
Actual result
Traceback (most recent call last):
  File "/Users/adam/.pyenv/versions/3.6.2/bin/pip-compile", line 11, in <module>
    sys.exit(cli())
  File "/Users/adam/.local/lib/python3.6/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/Users/adam/.local/lib/python3.6/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/Users/adam/.local/lib/python3.6/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/adam/.local/lib/python3.6/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/Users/adam/.pyenv/versions/3.6.2/lib/python3.6/site-packages/piptools/scripts/compile.py", line 167, in cli
    dist = run_setup(src_file)
  File "/Users/adam/.pyenv/versions/3.6.2/lib/python3.6/distutils/core.py", line 227, in run_setup
    script_name)
RuntimeError: 'distutils.core.setup()' was never called -- perhaps 'setup.py' is not a Distutils setup script?

Out of curiosity, could you try this and see if the problem occurs:
echo "-e ." | pip-compile -o requirements.txt - (don't forget the - at the end, it's required to read from stdin)
In short, this will do a pip-compile of -e . instead of parsing the setup.py directly.
If it works, then the issue is likely with the way we handle the setup.py parsing, which is my guess.
It would also possibly give you a workaround until we fix it.

@vphilippon, I was facing the same problem in this repository (pip-tools branch). Then I added a requirements.in file with -e . as suggested by you, and things worked fine.
So your guess seem to be consistent...
(thank you very much for the information and workaround!)

It looks like distutils.core.run_setup fails silently, so I've printed the error manually and got this:
 error in myproject setup command: ("EntryPoint must be in 'name=module:attrs [extras]' format", 'sl-admin=sl-admin.manage:main')

I've got an error in module path in entry points: change sl-admin.manage:main to sl_admin.manage:main and it'll work.

I'll close this based on the above, but please let us know if it doesn't resolve your issue. Thanks!


FancyZones change default state for toggling zone activation.

Description of the new feature / enhancement
The "Use a non-primary mouse button to toggle zone activation" feature is something I use a lot, however I wish fancyzones wouldn't be enabled as default.
I wish that there was an option such that when I have that option checked, fancyzones will not activate until I press my non-primary mouse button.
Scenario when this would be used?
I sometimes just want to move a window slightly and I dislike having to press my non-primary mouse button to turn off zone activation. For my use case it feels almost the opposite of what I want to do.
Supporting information
No response

This behavior is possible when both Hold Shift key to activate zones while dragging and Use a non-primary mouse button to toggle zone activation are enabled.
But what we can do is to make it more clear in the settings and instead of 2 separate checkboxes add one element to choose between 3 zone activation options: Use shift only, Shift + mouse, and Shift + mouse, activating the layout immediately.

/needinfo


The Ingestor needs to listen to updates from the Works table

Part of https://github.com/wellcometrust/platform/issues/1010
Depends on: https://github.com/wellcometrust/platform/issues/1382

The Ingestor will receive updates (likely via dynamo to sns) from the Works table (https://github.com/wellcometrust/platform/issues/1382).
It will:

Update and add works as now
When a canonical id (redirect) appears on a work it will need to update the old work with the data from the new work.

Closing as out of date.


android.database.sqlite.SQLiteConstraintException: UNIQUE constraint failed

DBFlow Version: 3.0.1
Issue Kind (Bug, Question, Feature): Bug
Description:
Half of our App users receive the following issue:
When trying to "save" a Model, DBFlow tries to insert but SQLite complains it already exists.
Also if I try to retrieve an item with DBFlow with the same primary key, it returns null, so also DBFlow says no item is stored with that key, but SQLite thinks differently.
I saw one similar closed issue where it was mentioned it seems to be an SQLite issue, but for me it doesn't. It really happens for many different users with many different devices and OS versions.
Do you have any hints?
Fatal Exception: android.database.sqlite.SQLiteConstraintException: UNIQUE constraint failed: Member.id (code 1555)
at android.database.sqlite.SQLiteConnection.nativeExecuteForLastInsertedRowId(SQLiteConnection.java)
at android.database.sqlite.SQLiteConnection.executeForLastInsertedRowId(SQLiteConnection.java:789)
at android.database.sqlite.SQLiteSession.executeForLastInsertedRowId(SQLiteSession.java:788)
at android.database.sqlite.SQLiteStatement.executeInsert(SQLiteStatement.java:86)
at com.raizlabs.android.dbflow.structure.database.AndroidDatabaseStatement.executeInsert(AndroidDatabaseStatement.java:77)
at com.raizlabs.android.dbflow.sql.saveable.ModelSaver.insert(ModelSaver.java:110)
at com.raizlabs.android.dbflow.sql.saveable.ModelSaver.save(ModelSaver.java:57)
at com.raizlabs.android.dbflow.sql.saveable.ModelSaver.save(ModelSaver.java:40)
at com.raizlabs.android.dbflow.structure.ModelAdapter.save(ModelAdapter.java:102)
at com.raizlabs.android.dbflow.structure.BaseModel.save(BaseModel.java:51)
at com.bitlove.fetlife.model.pojos.Member.save(Member.java:315)

are you doing this on different threads? deleting/ saving same models?
What does your Member class look like.

Thanks for the reply.
I had to refactor the code to make it stable and the issue is not reproducable any more.
Hmm... Different threads... Might be, but not was not aware of them.
It is gone for now anyways.
Thanks

@kistitan Could you please explain what you did to do away with the issue.


fix relative imports

The latest release includes an invalid line from . import mzipfile as zipfile https://github.com/mikusjelly/apkutils/blob/e98eb12370f419642e672a665997d54f181be2a5/apkutils/apk.py#L6
This commit:

Fixes calling mzipfile instead of zipfile
Updates all the relative imports to be absolute per PEP-008 import guidelines.
Removes references to deleted DEBUG mode.
Adds getPackage per https://github.com/androguard/androguard/blob/65de4bcb76b3a274da872e91952a08ed7fdc2279/androguard/core/bytecodes/axml.py#L659

Hi @joekiller
I will remove the apk.py later, you can find the same code in init.py.
Now I use from apkutils import APK not from apkutils.apk import APK

Okay, that is good to know.
Thank you for your project!


Issues moving files to new tabs

Describe the bug
Files won't move a file/folder to a new tab unless it's dragged from the right side.
To Reproduce
Steps to reproduce the behavior:

Open two tabs
Click on a file in one and attempt to drag it to the other tab.
Files won't show a proper "Move" prompt unless you move the file in from the right side of the tab.

Expected behavior
File will be moved to the new tab regardless of the position on the tab.
Screenshots

Desktop (please complete the following information):

OS Version: Windows 10 2004 20221.1000
App version: v<IP_ADDRESS>

Additional context
Additionally, when trying to move the file in from the left side of the tab, the tab itself slides off to the right and disappears until you move the cursor/file away from the tab, then it moves back into place.

This seems to have been resolved in the latest build. Thanks for the hard work!


Cannot use Headers to designate an Internal Sender as a Safe Sender

Hey Team,
Can we get the article update to denote that internal senders cannot be made Safe Senders via message flow/headers due to security concerns?
Obviously PowerShell would still work, but I had a Premier Support ticket go long due to this lack of information.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c900a9d1-897d-f7e9-6c58-a510edf56a9b
Version Independent ID: bc59ac94-233b-e558-4455-a4c7166d4023
Content: Create safe sender lists - Office 365
Content Source: microsoft-365/security/office-365-security/create-safe-sender-lists-in-office-365.md
Product: m365-security
Technology: mdo
GitHub Login: @chrisda
Microsoft Alias: chrisda

Removing support links (this repo is public).

@jaredburnett, OK. Fixed.
Thanks for the feedback.
Closing


Remove LeafMap - have a generic function which converts a Topology to RenderableNodes

Includes #421, those changes will go away when thats merged.
Part of #357
Doesn't actually buy us as much as I'd hoped.

I appreciate the change. Removing the distinction of a LeafMapRenderer is a big win for understandability.

@peterbourgon PTAL

:+1: otherwise.
Semi-related, I'm noticing that most churn in recent PRs is in the tests. I feel this myself, when I make a simple change in e.g. package render, I find I have to change a lot of "distant" tests in other components. I'm wondering if there's not a better testing strategy, relying a lot less or even even not at all on coarse-grained transforms of reports (i.e. package expected), and a lot more on fine-grained unit testing of individual functions and packages. What do you think?

On one hand I agree, the tests are pretty coarse.  But at the end of the day they are a good way to catch unintended side effects of small changes that more focused test might miss, and they do provide excellent coverage.
An alternative would be to capture a json report and the json output of the renders and plumb them together; that might help with some of the tedious struct munging.   Or just make it tedious json munging instead.


Revamp memory management of InstanceHandle

This commit fixes a known but in Wasmtime where an instance could still
be used after it was freed. Unfortunately the fix here is a bit of a
hammer, but it's the best that we can do for now. The changes made in
this commit are:

A Store now stores all InstanceHandle objects it ever creates.
This keeps all instances alive unconditionally (along with all host
functions and such) until the Store is itself dropped. Note that a
Store is reference counted so basically everything has to be dropped
to drop anything, there's no longer any partial deallocation of instances.

The InstanceHandle type's own reference counting has been removed.
This is largely redundant with what's already happening in Store, so
there's no need to manage two reference counts.

Each InstanceHandle no longer tracks its dependencies in terms of
instance handles. This set was actually inaccurate due to dynamic
updates to tables and such, so we needed to revamp it anyway.

Initialization of an InstanceHandle is now deferred until after
InstanceHandle::new. This allows storing the InstanceHandle before
side-effectful initialization, such as copying element segments or
running the start function, to ensure that regardless of the result of
instantiation the underlying InstanceHandle is still available to
persist in storage.

Overall this should fix a known possible way to safely segfault Wasmtime
today (yay!) and it should also fix some flaikness I've seen on CI.
Turns out one of the spec tests
(bulk-memory-operations/partial-init-table-segment.wast) exercises this
functionality and we were hitting sporating use-after-free, but only on
Windows.

I think this also puts the nail in the coffin and closes https://github.com/bytecodealliance/wasmtime/issues/777, since that will now be impossible.

Thanks for the review! I think I've addressed everything and will merge when green.


Building from the command line in Linux

I work on Linux and don't use FlashDevelop. How can I build a Kha project from the command line?
Just running haxelib run kha outputs some messages about building, but the linux-buid directory doesn't seem to have any executables in it.

Use --compile to compile or --run to compile and run (and --help to print all options). By default it just compiles the Haxe code to C++ and creates a Code::Blocks project.

That seems to work. It would be great if you could add something to the wiki about this. I already edited this page to add your notes.

You're right, will do!

Could you please add (and comment on) how to run commands for a specific platform?
Some of us come from a world where lime test neko or lime test html5 do everything. (Does Kha support Neko?)

haxelib run kha  --run
Doesn't work for all platforms though. Compared to other frameworks Kha has more of an "make it easy to debug" instead of an "make it easy to run" attitude. For html5 you do haxelib run kha html5 and haxelib run kha --server - usually you'd start the server once in an extra terminal and keep it.
Also no Neko support, don't know what it's good for.

Neko is usually good for debugging. I personally still struggle to get Chrome to use the Flash debug version. Neko is a cinch to compile and execute, and I get clear output in the console from trace statements.
Thanks for the feedback.

For a good debug option you can use html5, it compiles fast, and you can use breakpoints in chrome. Or you can use Kode too.


missing field dpdk_args in initializer of config::NetbricksConfiguration

I am following the commands given in the readme file and I am getting the following error when I run
./build.sh build
_### error[E0063]: missing field dpdk_args in initializer of config::NetbricksConfiguration
_--> src/config/config_reader.rs:290:8
|
290 |     Ok(NetbricksConfiguration {
|        ^^^^^^^^^^^^^^^^^^^^^^ missing dpdk_args
error: aborting due to previous error
error: Could not compile e2d2.
To learn more, run the command again with --verbose.__
Am I missing something? Please help me in this regards.
Thanks.

fixed in #85

Thank you for your quick response.

Thank @dimbleby  for the quick response.


Bump version to 2.0.0dev5

Codecov Report

Merging #1986 into v2 will increase coverage by 0.09%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##               v2    #1986      +/-   ##
==========================================
+ Coverage   92.53%   92.62%   +0.09%
==========================================
  Files          58       58
  Lines       10367    10495     +128
==========================================
+ Hits         9593     9721     +128
  Misses        774      774

Impacted Files
Coverage Δ

botocore/__init__.py
100% <100%> (ø)
:arrow_up:

botocore/discovery.py
100% <0%> (ø)
:arrow_up:

botocore/eventstream.py
100% <0%> (ø)
:arrow_up:

botocore/retries/quota.py
100% <0%> (ø)
:arrow_up:

botocore/parsers.py
99.79% <0%> (ø)
:arrow_up:

botocore/waiter.py
98.68% <0%> (ø)
:arrow_up:

botocore/credentials.py
98.64% <0%> (+0.01%)
:arrow_up:

botocore/utils.py
97.72% <0%> (+0.01%)
:arrow_up:

botocore/session.py
97.82% <0%> (+0.01%)
:arrow_up:

botocore/retries/adaptive.py
98.57% <0%> (+0.02%)
:arrow_up:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea6479f...743cfe0. Read the comment docs.


added submodule setup step

Feel free to change order if desired.

this has been combined with #14


Can we get a Player reference prefab?

Was wondering if we can get a player Arms prefab to help us place items in the hands easier?
Atm we have to guess the coordinates which means alot of going back and fixing it?

Was wondering if we can get a player Arms prefab to help us place items in the hands easier? Atm we have to guess the coordinates which means alot of going back and fixing it?

well, you already have it, in the Mods/LethalExpansion/Scenes folder

Nothing seems to load Also why is the shading all dark too? meant to ask this a while ago

Ah I take all that back, I had to use the latest version for it to work.!

That said, I get this error when I try building asset

Some files have same name, read the editor console, it will tell you which file you must rename


Development

small update

@gayara SDG goals are not responsible. Please work on the mobile responsible. try to use the "img-fluid" class. and don't hard code any size. if you hardcode try to use %, not px.


When should the Ambient Occlusion Map currently applied?

Following options:

IBL
Punctual Lights
AO
Emissive

or:

IBL
AO
Punctual Lights
Emissive

Spec issue is https://github.com/KhronosGroup/glTF/issues/915


add docs for widgets

In this docs file, I write the some information about the widgets:

ipywidgets
custom widgets
aiidablab-widgets-base

To be honest, I am still not sure whether we want to put it as a separate section. Should it still be a part of the App development section?
@csadorf what do you think?

Agreed, this should be a sub-section of the "App development" section.

@dou-du do you agree to move the section that you wrote under the "App development" section? If yes, can you do that?

@dou-du do you agree to move the section that you wrote under the "App development" section? If yes, can you do that?

Yes, I just move it to the "app development" section.

thanks, @dou-du, just fix the pre-commit and we will merge it.

@dou-du can you please fix the pre-commit issues?


Terraform: GCS bucket not public

The GCS bucket that gets created should have 'allUsers' in the viewers permissions.
/kind bug

/assign


putting 9.0.2 et all live on .org

@jospoortvliet You could also close https://github.com/owncloud/owncloud.org/issues/956 :-)

@RealRancor thanks...


Numpy 1.21 NDArray Type Error

Environment data

Language Server version: 2021.7.4 (pyright 209f9621)
OS and version: Windows 10 20H2
Python version: 3.8.10 and 3.9.4
Numpy version: 1.21.0

Expected behaviour
Numpy v1.21.0 introduced runtime subscriptable aliases for ndarrays.
When defining variables using the generic type hint numpy.typing.NDArray, Pylance should not raise an error when attempting to index into it.
Actual behaviour
Pylance raises the error:
Could not specialize type "NDArray[ScalarType@NDArray]"
  Type "int" is incompatible with bound type "generic" for type variable "ScalarType@NDArray"
    "int" is incompatible with "generic" Pylance

If using slice notation (a[:]), the error message is basically the same, but refers to "slice" instead of "int"`
Logs

[Info  - 10:15:30 PM] Pylance language server 2021.7.4 (pyright 209f9621) starting
[Info  - 10:15:30 PM] Server root directory: c:\Users\Andrew\.vscode\extensions\ms-python.vscode-pylance-2021.7.4\dist
[Info  - 10:15:31 PM] No pyproject.toml file found.
[Info  - 10:15:31 PM] Setting pythonPath for service "<default>": "C:\Users\Andrew\AppData\Local\Programs\Python\Python39\python.exe"
[Error - 10:15:31 PM] venvPath ~\.virtualenvs is not a valid directory.
[Warn  - 10:15:31 PM] stubPath typings is not a valid directory.
[Info  - 10:15:31 PM] Assuming Python version 3.9
[Info  - 10:15:31 PM] Assuming Python platform Windows
Search paths for
  c:\Users\Andrew\.vscode\extensions\ms-python.vscode-pylance-2021.7.4\dist\typeshed-fallback\stdlib

  typings
  c:\Users\Andrew\.vscode\extensions\ms-python.vscode-pylance-2021.7.4\dist\typeshed-fallback\stubs\...
  c:\Users\Andrew\.vscode\extensions\ms-python.vscode-pylance-2021.7.4\dist\bundled\stubs
  c:\Users\Andrew\AppData\Local\Programs\Python\Python39\DLLs
  c:\Users\Andrew\AppData\Local\Programs\Python\Python39\Lib
  c:\Users\Andrew\AppData\Local\Programs\Python\Python39
  c:\Users\Andrew\AppData\Roaming\Python\Python39\site-packages
  c:\Users\Andrew\AppData\Local\Programs\Python\Python39\Lib\site-packages
  c:\Users\Andrew\AppData\Local\Programs\Python\Python39\Lib\site-packages\Equation-1.3.dev20210526-py3.9.egg
  c:\Users\Andrew\AppData\Local\Programs\Python\Python39\Lib\site-packages\win32
  c:\Users\Andrew\AppData\Local\Programs\Python\Python39\Lib\site-packages\win32\lib
  c:\Users\Andrew\AppData\Local\Programs\Python\Python39\Lib\site-packages\pythonwin
[Info  - 10:15:33 PM] Searching for source files
[Info  - 10:15:33 PM] No source files found.
[FG] parsing: c:\Users\Andrew\Code\FSABM-v2\foo.py (95ms)
[FG] parsing: c:\Users\Andrew\.vscode\extensions\ms-python.vscode-pylance-2021.7.4\dist\typeshed-fallback\stdlib\builtins.pyi [fs read 6ms] (185ms)
[FG] binding: c:\Users\Andrew\.vscode\extensions\ms-python.vscode-pylance-2021.7.4\dist\typeshed-fallback\stdlib\builtins.pyi (49ms)
[FG] binding: c:\Users\Andrew\Code\FSABM-v2\foo.py (0ms)
[Info  - 10:15:33 PM] Background analysis(1) root directory: c:\Users\Andrew\.vscode\extensions\ms-python.vscode-pylance-2021.7.4\dist
[Info  - 10:15:33 PM] Background analysis(1) started
Background analysis message: setConfigOptions
Background analysis message: ensurePartialStubPackages
Background analysis message: setTrackedFiles
Background analysis message: markAllFilesDirty
Background analysis message: setFileOpened
Background analysis message: getDiagnosticsForRange
Background analysis message: analyze
[BG(1)] analyzing: c:\Users\Andrew\Code\FSABM-v2\foo.py ...
[BG(1)]   parsing: c:\Users\Andrew\Code\FSABM-v2\foo.py (65ms)
[BG(1)]   parsing: c:\Users\Andrew\.vscode\extensions\ms-python.vscode-pylance-2021.7.4\dist\typeshed-fallback\stdlib\builtins.pyi [fs read 3ms] (128ms)
[BG(1)]   binding: c:\Users\Andrew\.vscode\extensions\ms-python.vscode-pylance-2021.7.4\dist\typeshed-fallback\stdlib\builtins.pyi (38ms)
[BG(1)]   binding: c:\Users\Andrew\Code\FSABM-v2\foo.py (1ms)
[BG(1)]   checking: c:\Users\Andrew\Code\FSABM-v2\foo.py ...
[BG(1)]     parsing: c:\Users\Andrew\.vscode\extensions\ms-python.vscode-pylance-2021.7.4\dist\typeshed-fallback\stdlib\typing.pyi [fs read 3ms] (55ms)
[BG(1)]     binding: c:\Users\Andrew\.vscode\extensions\ms-python.vscode-pylance-2021.7.4\dist\typeshed-fallback\stdlib\typing.pyi (12ms)
[BG(1)]     parsing: c:\Users\Andrew\.vscode\extensions\ms-python.vscode-pylance-2021.7.4\dist\typeshed-fallback\stdlib\_typeshed\__init__.pyi [fs read 1ms] (23ms)
[BG(1)]     binding: c:\Users\Andrew\.vscode\extensions\ms-python.vscode-pylance-2021.7.4\dist\typeshed-fallback\stdlib\_typeshed\__init__.pyi (2ms)
[BG(1)]     parsing: c:\Users\Andrew\.vscode\extensions\ms-python.vscode-pylance-2021.7.4\dist\typeshed-fallback\stdlib\typing_extensions.pyi [fs read 0ms] (2ms)
[BG(1)]     binding: c:\Users\Andrew\.vscode\extensions\ms-python.vscode-pylance-2021.7.4\dist\typeshed-fallback\stdlib\typing_extensions.pyi (1ms)
[BG(1)]     parsing: c:\Users\Andrew\AppData\Local\Programs\Python\Python39\Lib\site-packages\numpy\__init__.pyi [fs read 1ms] (489ms)
[BG(1)]     binding: c:\Users\Andrew\AppData\Local\Programs\Python\Python39\Lib\site-packages\numpy\__init__.pyi (57ms)
[BG(1)]     parsing: c:\Users\Andrew\AppData\Local\Programs\Python\Python39\Lib\site-packages\numpy\typing\__init__.py [fs read 1ms] (33ms)
[BG(1)]     binding: c:\Users\Andrew\AppData\Local\Programs\Python\Python39\Lib\site-packages\numpy\typing\__init__.py (2ms)
[BG(1)]     parsing: c:\Users\Andrew\AppData\Local\Programs\Python\Python39\Lib\site-packages\numpy\typing\_generic_alias.py [fs read 1ms] (21ms)
[BG(1)]     binding: c:\Users\Andrew\AppData\Local\Programs\Python\Python39\Lib\site-packages\numpy\typing\_generic_alias.py (3ms)
[BG(1)]   checking: c:\Users\Andrew\Code\FSABM-v2\foo.py (752ms)
[BG(1)] analyzing: c:\Users\Andrew\Code\FSABM-v2\foo.py (987ms)
Background analysis message: getDiagnosticsForRange
Background analysis message: resumeAnalysi

Code Snippet / Additional information

import numpy as np
import numpy.typing as npt

# NOT ok
def func1(a: npt.NDArray):
    print(a[0])  # See error message above
	print(a[0:])

# Ok
def func2(a: npt.NDArray[np.float64]):
    print(a[0])

# Ok
def func3(a: np.ndarray):
    print(a[0])

Thanks for the bug report. This will be fixed in the next release.

In the meantime, you can work around the problem by explicitly specifying Any as the type argument to the generic type alias NDArray.

This issue has been fixed in version 2021.7.5, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202175-22-july-2021