Instantiation opens socket immediately

Would be an enhancement request. I have a case where I want to declare the socket but only open it if navigated to a specific section of our website. However, as currently configured it attempts to connect immediately.
Would we be able to have a socket.open API added and corresponding automaticOpen config available? Or something along those lines? Would make usage a lot more flexible

I'm facing the same thing at the moment.
My initial work-around is to call websocket.close() immediately after creating the socket. It sets a flag that stops the automatic open process before it completes, and it doesn't continue to try to connect.
Then when I want to use it, I'm calling websocket.reconnect().
The issue I'm finding is to do with the connection timings on reconnect. If I want it to try to connect immediately, I want a small value for the option minReconnectionDelay. The issue is that this small value is also used as-is for the delay for the second connection attempt if the initial connection fails, i.e. in the _getNextDelay() function, the first connection has a _retryCount value of 0 - so the minReconnectionDelay value is used. On the second connection attempt the _retryCount value is 1, which results in the delay being set to:
minReconnectionDelay * Math.pow(reconnectionDelayGrowFactor, this._retryCount - 1)
 = minReconnectionDelay * Math.pow(reconnectionDelayGrowFactor, 0)
 = minReconnectionDelay * 1

It means that the second connection attempt cannot be given any delay longer than the initial attempt, making it impossible to have a "connect immediately but don't immediately spam reconnection if that fails".
What I'd really like to do is set the initial attempt to occur immediately, then all attempts after that to have a 10s delay. To be able to do that, the formula would need to be changed so that it no longer subtracts 1 from the _retryCount when using Math.pow - or it would need to set a separate value for initial delay so that minReconnectionDelay was used only for second/third/etc connection attempts but not for the initial one.

Hi, thank you for your comments. I've added a startClosed option
const ws = new ReconnectingWebSocket(URL, anyProtocol, {
    startClosed: true,
});

...

ws.reconnect(); // to start connection at any moment

Will be available on next release


Add extension ".sol" to the language - Solidity.

Just a simple addition of an extension type - ".sol" - to the Solidity language.
Description

Simply put, this pull requests seeks to add the extension type ".sol" to the Solidity language in the list of languages found on the languages.yml file.
Checklist:

[x] I am associating a language with a new file extension.

[x ] The new extension is used in hundreds of repositories on GitHub.com

Search results for each extension:

https://github.com/search?utf8=✓&type=Code&ref=searchresults&q=extension%3Asol+solidity

[x ] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

[https://github.com/lherbeur/DAOVotingSystem/blob/master/voting.sol]
-Sample files added under pull request - https://github.com/github/linguist/pull/4145

Sample license(s):

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[ ] I am adding a new language.

[ ] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

https://github.com/search?utf8=✓&type=Code&ref=searchresults&q=extension%3AFOOBAR+KEYWORDS+NOT+nothack

[ ] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a syntax highlighting grammar.
[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[ ] I am fixing a misclassified language

[ ] I have included a new sample for the misclassified language:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[ ] I am changing the source of a syntax highlighting grammar

Old: https://github-lightshow.herokuapp.com/
New: https://github-lightshow.herokuapp.com/

[ ] I am adding new or changing current functionality

[ ] I have added or updated the tests for the new or changed functionality.

Unless you can provide an accurate heuristic and samples for all languages that use the .sol extension on GitHub, you’re going to hit the same reasons why we didn’t merge all previous attempts at adding the .sol extension https://github.com/github/linguist/pulls?q=is%3Apr+solidity+is%3Aclosed 😁

Marking as stale as this PR so far isn't adding anything more than all previous attempts. This PR will be closed in a week's time if no further progress is made.


Reformatting

U should use folders to format the website into making it simpler for u to understand. Just a tip of course!

Right! You should use folders and make a better format.

Yes, It is very confusing to see the code, You should try a better format for better understanding


Create Content for email to update all users on the changes to the Terms of Service

Problem Statement
The Terms of Service will be updated on the RS website. It is required that we communicate that those terms of service have changed to all of our users. The purpose of this issue is to define the content of that email message that will be sent to all users.
Background Information

The users will be defined by #8137
Michael Burstein is currently working on some email message content

Acceptance Criteria

[ ] Finalize email message content and formatting
[ ] Review finalized email message content with Chris Kuryak
[ ] Attach or paste finalized email message content and formatting in this ticket or send directly to Sharon Liu, copying Chris Kuryak and Brandon Canniff.

@lizzieamanning @audreykwr
FYI, Kimberly Labno said she would be able to help craft an email message if y'all wanted it. She has done this in the past, according to my convo with her.

Would that take the place of the Michael Burstein's content in the first AC?

I haven't heard back from Michael in a bit, so I am going to ping him. If he sends anything over, I'll let y'all know. But I would proceed without his content as I cannot ensure we will ever receive it.

Ah got it. Yeah I was waiting on that, thinking it was just an edit of someone else's draft. I'm fine with Kimberly making the first draft instead of Michael then if she's more available!
Also - did we clear up the question of if everyone who is getting this had indeed signed TOS already?

(https://app.zenhub.com/files/304423150/b0ddb3fd-221d-490a-aecd-7951e7459fab/download)
This is the redlined TOS- is this what you're looking for? @audreykwr @chris-kuryak
@audreykwr https://github.com/CDCgov/prime-reportstream/issues/8137 might answer your question about who this is going to

(https://app.zenhub.com/files/304423150/b0ddb3fd-221d-490a-aecd-7951e7459fab/download)
This is the redlined TOS- is this what you're looking for? @audreykwr @chris-kuryak
@audreykwr https://github.com/CDCgov/prime-reportstream/issues/8137 might answer your question about who this is going to

@audreykwr

I'll connect you with Kimberly Labno on getting a rough draft/guidelines on a ToS Update email.
Getting senders to sign the ToS is in Sharon's onboarding process. However, I don't think receivers have signed the ToS. @sliu1000 can you clear that up for us?

Yep!


[Feature request] Consideration for altering constraints in Database::connect()

Hi there - fantastic project!
I was wondering what your opinion was on relaxing the check to detect prior mongoist connections? In particular, this check will fail if the mongoist reference that is passed in is a mongoist reference where the module was loaded separately. This can happen either due to version differences, multiple linked packages during testing, or any other situation where mongoist isn't flattened to a single module under a package's node_modules. In this situation, the failure to detect the reference as a Database reference means that we'll return undefined even though we had a valid connection that we could have used to make a new connection from.
It's most likely too dangerous to reuse the connection if it was loaded via a different instance of the mongoist package as we can't be sure of API uniformity, but what do you think about using the passed in mongoist reference in order to synthesize a new mongoist reference?

Hi, yes the check is a bit 💩 - I'm considering to export the mongoist package name and version of and  to check against that.
Considering building a new connection/mongoist instance from a passed mongoist reference does not fit the current API without a major change, perhaps expose a function createFrom to create a new connection from a given mongoist or whatever instance.
const mongoist = require('mongoist');

mongoist.createFrom(someOtherMongoistInstanceHere);

What do you think about this?

Awesome! I'd agree it'd be nice not to require a major version change and I like the idea of adding the necessary functionality here to a new function. 👍


CSV export

Hello,
CSV export not working here:
https://opencollective.com/captainfact_io/admin/export

:( :( :(

Hi @Miragide, seems fine on my end. Maybe try to decode with UTF8?

Merci Betree


General: Allow to restrict exercise import search to courses / exercises

NOTE: Stacked PR based on https://github.com/ls1intum/Artemis/pull/5484
Checklist
General

[x] I tested all changes and their related features with all corresponding user types on a test server.
[x] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[x] I chose a title conforming to the naming conventions for pull requests.

Server

[x] I followed the coding and design guidelines.
[x] I added multiple integration tests (Spring) related to the features (with a high test coverage).
[x] I added @PreAuthorize and checked the course groups for all new REST Calls (security).
[x] I implemented the changes with a good performance and prevented too many database calls.
[x] I documented the Java code using JavaDoc style.

Client

[x] I followed the coding and design guidelines and ensured that the layout is responsive.
[x] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
(https://docs.artemis.ase.in.tum.de/dev/guidelines/client-tests/).
[x] I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
[x] I documented the TypeScript code using JSDoc style.
[x] I added multiple screenshots/screencasts of my UI changes.
[x] I translated all newly inserted strings into English and German.

Motivation and Context

As requested by @krusche it would be helpful if we could search in the import dialog only for course exercises or only for exam exercises.
Description

Added new filter parameters and corresponding queries for the filter combination possibilities.
Steps for Testing

Test the search functionality in the import dialog of each exercise type: Text,Quiz,Modeling,Programming:

CourseFilter active means course exercises should be searched for.
ExamFilter active means exam exercises should be searched for.
Activating both -> Both exam and course exercises are searched for
Deactivating both is disabled as it would make no sense to do so from a user perspective

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage
Test Coverage for critical methods:

Class
Method
Branch
Line

TextExerciseService
getAllOnPageWithSize
100%
100%

QuizExerciseService
getAllOnPageWithSize
100%
100%

ModelingExerciseService
getAllOnPageWithSize
100%
100%

ProgrammingExerciseService
getAllOnPageWithSize
100%
100%

Screenshots

https://user-images.githubusercontent.com/29718932/181797266-b3c68cff-f20f-48c6-bb18-b7eb728e5f0f.mp4

I don't like that you copied the code five times. Can this be avoided?

I think I can only do it for the test code to be honest without the scope of the PR completely exploding.

Yeah, there is an issue for that, but I see no reason why we should make it even worse :thinking: so @canberkanar and my point are still valid. So I suggest if you do not want to fix this in this PR, you should provide an additional PR refactoring the components and merge it first. Afterward, you can adapt your changes in this PR.


404 when load css

Describe the bug
status website got an 404 error when load css files
To Reproduce
Steps to reproduce the behavior:

Go to https://lucifer.ren/leetcode-pp-available/
404 error when load theme css

I have configure the base_url in my yml file correctly. so all other files works fine eg: js files.  I also check the index.html which includes <base href="/leetcode-pp-available/">

Expected behavior
load https://lucifer.ren/leetcode-pp-available/themes/light.css
instead of https://lucifer.ren/themes/light.css
Screenshots

my repo: https://github.com/azl397985856/leetcode-pp-available

my repo: azl397985856/leetcode-pp-available

did you reach to find a solution ?

I see! Turns out subdirectories don't work with custom domain, but this should be a feature we should add!

@AnandChowdhary thx. looking forward to this feature

We're having a similar issue here https://materialsproject.github.io/status/, where both CSS and JS are not loading. Could this be related?

@mkhorton No, you have the "/status" as the base URL missing in https://github.com/materialsproject/status/blob/master/.upptimerc.yml#L31.

i have sasme issue

https://github.com/KiroFyzu/upptime/blob/dcd8ad89e49a8d51e9c67d7f5d2b68277b48eecb/.upptimerc.yml#L8
Can you please remove the | in the website names? I think it causes issues with markdown tables. Also, could you please check your repository settings to ensure that GitHub Pages is indeed enabled and publishing from the gh-pages branch?

What about us?

https://www.dandiarchive.org/upptime/
https://github.com/dandi/upptime/blob/master/.upptimerc.yml#L54

@yarikoptic I think this could be the issue that Upptime works either with a custom domain or a /base-url, but not both. I think I've noticed this elsewhere before but haven't had a chance to fix it. :(

I think adding the base URL to this line should fix the issue: https://github.com/upptime/status-page/blob/9b4cd08f4243c86487a18ad7f4eac813e92c4607/pre-process.ts#L25 Happy to accept a PR!

should I just add /base-url to cname or there are uses of cname which really want domain name?

I think adding the base URL to this line should fix the issue: https://github.com/upptime/status-page/blob/9b4cd08f4243c86487a18ad7f4eac813e92c4607/pre-process.ts#L25 Happy to accept a PR!

initial PR was submitted

https://github.com/upptime/status-page/pull/545
but I do not really know how to try it out.

Thank you, I appreciate it!

We just shipped an update and it should probably work now. Can someone please test here by running "Static Site CI" manually and waiting for the updated site to be live, and if it still doesn't work please share the link here and I'll investigate? Thanks @yarikoptic for your contribution!

Yay, works now

🎉


[IgnoreAntiforgeryToken] not working with .net core 1.1.0. It is working with .net core 1.0.

Thanks for your interest in .NET Core.
Please note that this repo (dotnet/core) is not for filing product issues. Here are some repos where you can file an issue:

dotnet/cli - for CLI tools and questions
dotnet/corefx - for API issues and questions
dotnet/coreclr - for runtime issues
nuget/home - for NuGet questions and issues

For reproduce issue apply attribute   [ValidateAntiForgeryToken] on class level and use    [IgnoreAntiforgeryToken] on some of method

+1 on this, ran into the same problem today.

I moved this issue to: https://github.com/aspnet/Mvc/issues/5657


[pkg/workload] Use SSA patch to update status conditions.

What type of PR is this?
/kind feature

What this PR does / why we need it:
Make use of SSA while updating a workload status condition.
Each condition is changed with it's own manager name allowing concurrent changes to different conditions.
Which issue(s) this PR fixes:

Fixes #493
Special notes for your reviewer:
cc: @mwielgus @alculquicondor

/ok-to-test


Profile support via env

Can we read env like BEYOND_CTL_PROFILE_xxxx = s3://xxxx?

We can merge all profile env which has prefix BEYOND_CTL_PROFILE into config.Profile, that should work.

Implemented in #24


calico-apiserver not running on eks cluster v1.23.9

I am trying to install calico on EKS cluster(with a private endpoint) using tigera operator, the purpose is to use network policy(Global network policy in particular). The operator gets installed successfully using helm version (3.24.5). After operator is install we can see related pods running,
calico-apiserver                          calico-apiserver-6c7d984f4d-bns8g                                 1/1     Running                      2 (108s ago)      5m56s
calico-apiserver                          calico-apiserver-6c7d984f4d-dq2c9                                 1/1     Running                      3 (20s ago)       6m28s
calico-system                             calico-kube-controllers-764d45cb85-x6b6r                          1/1     Running                      0                 9m36s
calico-system                             calico-node-s9txm                                                 1/1     Running                      0                 10m
calico-system                             calico-node-vw2qf                                                 1/1     Running                      0                 10m
calico-system                             calico-typha-6b696f6f47-wl55n                                     1/1     Running                      0                 11m
calico-system                             csi-node-driver-v9js4                                             2/2     Running                      0                 10m
calico-system                             csi-node-driver-wdf4k                                             2/2     Running                      0                 10m

however calico-apiserver never become healthy and keeps crashing with below error,

E1201 20:20:03.310472       1 webhook.go:223] Failed to make webhook authorizer request: Post "https://<IP_ADDRESS>:443/apis/authorization.k8s.io/v1/subjectaccessreviews?timeout=10s": context canceled
E1201 20:20:03.311006       1 errors.go:77] Post "https://<IP_ADDRESS>:443/apis/authorization.k8s.io/v1/subjectaccessreviews?timeout=10s": context canceled
E1201 20:20:03.312069       1 timeout.go:141] post-timeout activity - time-elapsed: 1.693006ms, GET "/version" result: <nil>

Expected Behavior
All the pods should be healthy and I should be able to use globalnetworkpolicy
Current Behavior
the calico-apiserver pods keeps crashing
Possible Solution
Steps to Reproduce (for bugs)
Install the tigera helm chart on EKS and you can see the behaviour
Context

Your Environment

Operating System and version:
Link to your project (optional):

I wonder if the autodetection for EKS isn't working and you need to set the Provider field in the Installation resource to EKS. I'm wondering that because I think with EKS it is necessary to run the calico-apiserver has a hostNetworked pod since the EKS K8s api is not pod networked. The calico-apiserver is automatically ran hostNetworked when the Provider is EKS.


[ClangImporter] Avoid calling into ObjCSelector lookup

The ClangImporter currently calls into ObjCSelector's lookupDirect in a couple of places, stashing the selector in a DenseMap to try and avoid re-entrancy problems.
However this will become a problem once ObjCSelector's lookupDirect is both requestified and starts pulling in members from the main module, so migrate the ClangImporter off calling it.
Fortunately most of its uses only care about decls with associated Clang nodes. For those cases, we can use the existing member table, making sure to populate it with any method we import.
In one case, the ClangImporter needs to check to see if there's a deserialized Swift method with a matching selector. Instead of calling through to lookupDirect, let's just query the Swift module loaders directly.

@swift-ci please test

@swift-ci please test source compatibility

@swift-ci please smoke test


Output Path no longer supported on serve?

Please provide us with the following information:

OS?  Windows 7, 8 or 10. Linux (which distribution). Mac OSX (Yosemite? El Capitan?)

Windows 10

Versions. Please run ng --version. If there's nothing outputted, please run
in a Terminal: node --version and paste the result here:

angular-cli: 1.0.0-beta.11-webpack.8
node: 6.5.0
os: win32 x64

Repro steps. Was this an app that wasn't created using the CLI? What change did you
do on your code? etc.

For the non-webpack betas, I've used this command line to have the compiled output pushed to a specific directory:
ng serve --output-path ../.deploy/portfolio.war/ui/ -w -lr -lrp 50000

The log given by the failure. Normally this include a stack trace and some
more information.

The option '--output-path' is not registered with the serve command. Run ng serve --help for a list of supported options.
However, ng serve --help says this option is still available:
ng serve <options...>
Builds and serves your app, rebuilding on file changes.
aliases: server, s
--port (Number) (Default: 4200)
aliases: -p
--host (String) Listens on all interfaces by default
aliases: -H
--proxy (String)
aliases: -pr , -pxy
--insecure-proxy (Boolean) (Default: false) Set false to proxy self-signed SSL certificates
aliases: --inspr
--watcher (String) (Default: events)
aliases: -w
--live-reload (Boolean) (Default: true)
aliases: -lr
--live-reload-host (String) Defaults to host
aliases: -lrh
--live-reload-base-url (String) Defaults to baseURL
aliases: -lrbu
--live-reload-port (Number) (Defaults to port number within [49152...65535])
aliases: -lrp
--environment (String) (Default: development)
aliases: -e , -dev (--environment=development), -prod (--environment=production)
--output-path (Path) (Default: dist/)
aliases: -op , -out
--ssl (Boolean) (Default: false)
--ssl-key (String) (Default: ssl/server.key)
--ssl-cert (String) (Default: ssl/server.crt)

Mention any other details that might be useful.

I've been using this at dev time to integrate with an existing web application server (JBoss WildFly).  In previous versions, having ng serve push to a directory WildFly is looking for worked perfectly.  If this is no longer available, what suggestions are there for a replacement.
Also, it doesn't appear that ng serve is writing to the stated default directory (dist) either.  Not sure where the files are going at this point.

Thanks! We'll be in touch soon.

i would love to have it back as well

Just run ng b && ng s
I am not missing it, since it can easily be replaced by above command.
To your question: I think that webpack holds the compiled files in memory, so no output directory is needed anyway

Thanks, Christian.  However, we still need to know if this was a mistake to leave this feature out of the webpack branch, or if it will not be there when 'done'.
Also, I don't think your suggestion will do what I want, as ng s will not update the files written by ng b.
In our scenario, ng b is used for the production build, but during dev time, I need ng s for live reloading, etc.   I really need it to update files in a directory though instead of just holding them in RAM.

Have you tried ng build --help? This help mentions a --watch <Boolean> flag. Maybe this is what you need. I think that ommiting this is not a bug and will stay as it is, since writing to the disk could slow down webpacks live reload.

@christiandreher ng build --watch does only part of what ng serve does - it watches and automatically rebuilds app, but it doesn't reload

Thats why I suggested to run ng s and ng b --watch true simultaniously

I'm already using --watch, however I've been using WildFly to actually serve the files from a directory.  Before the switch to webpack I could do that (with live reload).
If it will no longer be supported, then I can make other plans.  Removing that feature needs to be front and center in the changelog and release notes though.  It would also be a bug against the --help feature since it states it's still available.
For the time being I've dropped back to the non-webpack versions until this is resolved one way or the other.

build --watch might work out if it would honor the --output-path flag... which was the original issue.

Sorry, I don't know what WildFly is and therefore don't exactly know the use case. I just wanted to help somehow. I think that you better wait for a official angular member to answer your question whether it will stay like this or not. I just want to emphasize, that I don't know whether they will remove it or not, it was just a guess.
Sorry, I forgot about the exact context of your question. You're right, you can't serve from a directory. It seems that it will always serve from a fresh build in-memory.

For the purposes of this discussion, just think of it as a webserver with assets beyond what Angular-CLI is providing.  Thanks for the feedback.  I look forward to a more 'official' answer, too.

The --output-path is no longer supported for ng serve, no. We're doing all the serve builds in memory.
ng build --watch is the best option for your usecase.

@filipesilva if the --output-path is no longer supported for ng serve could you please remove this option from ng serve options list in https://github.com/angular/angular-cli/wiki/serve. Thank you!


Branch delete command

There are two major changes:
Firstly, added the delete lesson command. I added the parsers, integrate them to the address book parser and refractor the original delete command to deletePerson command. Important files for this change are "DeletePersonCommand" , "DeletePersonCommandParser", "DeleteLessonCommand", ""DeleteLessonCommandParser".
Secondly, I modify the address book parser such that it could interpret "add, edit, delete" as "addLesson", "addPerson" .... based on the "State" variable in model. It is assumed that the "State" is either "PERSON" or "SCHEDULE", not "NONE". Important file for this change is "AddressbookParser"
The rest are ripple effect due to the update, like updating test case, check style, and renaming files.

Fix #122 #123

Seems like edit command is not working as intended

editLesson 1 -start 13:20 works

Behaviour of lesson commands: can only add one subject
[editLesson -subject ENGLISH -subject MATHEMATICS] gives:

Good to change error message to: Please specify only one subject per lesson

okay recent commit works as intended

Seems like edit command is not working as intended
editLesson 1 -start 13:20 works
Behaviour of lesson commands: can only add one subject [editLesson -subject ENGLISH -subject MATHEMATICS] gives:  Good to change error message to: Please specify only one subject per lesson

Thank your for the response.
Yeah, the first bug is valid. I just made a new commit to fix it.
The second is that you forget to put index after your editLesson command so the error message is not wrong. It will also detect for duplicate flags by the way.


feat(@dpc-sdp/ripple-ui-core): adding result listing

Issue: https://digital-vic.atlassian.net/browse/R20-96
What I did

Adding result listing component
Fixed issue with cards showing as clickable even when the card isn't linked
Fixed issue with useAccessibleContainer where clicking the title triggered two click events/page navigations

Screenshots

For all PR's

[ ] I've added relevant changes to the project Readme if needed.
[ ] I've updated the documentation site as needed.
[ ] I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

[x] I have added a story covering all variants
[x] I have checked a11y tab in storybook passes
[ ] Any events are emitted on the event bus

Should the whole listing be clickable? Might be something to check with design. Otherwise LGTM.

Hey @dylankelly, having the whole area clickable was in the spec (confluence doc), cheers


How do you add new users?

General information

OS: Windows
Hypervisor: Hyper-V
Did you run crc setup before starting it (Yes/No)? Yes

CRC version
crc version: 1.6.0+8ef676f
OpenShift version: 4.3.0 (embedded in binary)

CRC status
C:\crc-windows-1.6.0-amd64>crc status
CRC VM:          Running
OpenShift:       Running (v4.3.0)
Disk Usage:      9.628GB of 32.72GB (Inside the CRC VM)
Cache Usage:     12.69GB
Cache Directory: C:\Users\jesaremi\.crc\cache

CRC config
C:\crc-windows-1.6.0-amd64>crc config view

Host Operating System
C:\crc-windows-1.6.0-amd64>systeminfo

Host Name:                 JESAREMI-HP
OS Name:                   Microsoft Windows 10 Enterprise
OS Version:                10.0.18363 N/A Build 18363
Product ID:                00330-80000-00000-AA800
Original Install Date:     7/30/2019, 11:45:53 AM
System Boot Time:          2/15/2020, 8:06:58 PM
System Manufacturer:       HP
System Model:              HP Z2 Tower G4 Workstation
System Type:               x64-based PC
Processor(s):              1 Processor(s) Installed.
                           [01]: Intel64 Family 6 Model 158 Stepping 10 GenuineIntel ~3192 Mhz
BIOS Version:              HP Q50 Ver. 01.05.04, 6/17/2019
Windows Directory:         C:\windows
System Directory:          C:\windows\system32
Boot Device:               \Device\HarddiskVolume4
System Locale:             en-us;English (United States)
Input Locale:              en-us;English (United States)
Time Zone:                 (UTC-08:00) Pacific Time (US & Canada)
Total Physical Memory:     65,387 MB
Available Physical Memory: 28,024 MB
Virtual Memory: Max Size:  75,115 MB
Virtual Memory: Available: 33,935 MB
Virtual Memory: In Use:    41,180 MB
Page File Location(s):     C:\pagefile.sys

Logon Server:              \\CY1-RED-DC-03
Hotfix(s):                 16 Hotfix(s) Installed.
                           [01]: KB4534132
                           [02]: KB4493478
                           [03]: KB4497727
                           [04]: KB4503308
                           [05]: KB4508433
                           [06]: KB4509096
                           [07]: KB4515383
                           [08]: KB4516115
                           [09]: KB4517245
                           [10]: KB4520390
                           [11]: KB4521863
                           [12]: KB4524569
                           [13]: KB4528759
                           [14]: KB4537759
                           [15]: KB4538674
                           [16]: KB4532693
Network Card(s):           4 NIC(s) Installed.
                           [01]: Intel(R) Ethernet Connection (7) I219-LM
                                 Connection Name: Ethernet
                                 DHCP Enabled:    Yes
                                 DHCP Server:     N/A
                                 IP address(es)
                           [02]: Hyper-V Virtual Ethernet Adapter
                                 Connection Name: vEthernet (Default Switch)
                                 DHCP Enabled:    No
                                 IP address(es)
                                 [01]: <IP_ADDRESS>
                                 [02]: fe80::811c:dc54:cd74:642e
                           [03]: Hyper-V Virtual Ethernet Adapter
                                 Connection Name: vEthernet (external-1)
                                 DHCP Enabled:    Yes
                                 DHCP Server:     <IP_ADDRESS>
                                 IP address(es)
                                 [01]: <IP_ADDRESS>
                                 [02]: fe80::a4dc:b7c0:b6a4:7736
                           [04]: Hyper-V Virtual Ethernet Adapter
                                 Connection Name: vEthernet (crc)
                                 DHCP Enabled:    Yes
                                 DHCP Server:     <IP_ADDRESS>
                                 IP address(es)
                                 [01]: <IP_ADDRESS>
                                 [02]: fe80::1955:537c:a2dd:d076
                                 [03]: 2001:4898:e0:bf:e4f8:ba04:a787:53fb
                                 [04]: 2001:4898:e0:bf:1955:537c:a2dd:d076
Hyper-V Requirements:      A hypervisor has been detected. Features required for Hyper-V will not be displayed.

How do you add new users using htpasswd or other ways given that we have no access to the VM?

How do you add new users using htpasswd or other ways given that we have no access to the VM?

@jeffsaremi You can follow the OpenShift docs to add a new user: https://docs.openshift.com/container-platform/4.3/authentication/identity_providers/configuring-htpasswd-identity-provider.html

@jeffsaremi check https://github.com/code-ready/crc/wiki/Add-another-user-to-cluster also.

@praveenkumar
Thanks very  much!
I think my confusion was around the fact that there is already an htpasswd used for the 'developer' user. And if I needed to preserve that by using the same htpasswd file.
But it looks like I don't have to.


Dauntless Outfitting deletes cards if it doesn't find a target to put into play

I'm not sure if this is exactly right but I was playing Dauntless. I had Arcstep in play. Arcshield in my hand. There were no other equipment or relics in my deck. I played Outfitting and the game went through Dauntless's deck and revealed no playable targets. All the revealed cards were then immediately removed from the game and not put into the trash or back on to the deck.

Thanks for the report! Should be fixed in https://github.com/jamespicone/potw/commit/718b288fac51f2cb7defcfb45e9f2da46381310d


Switching scenes with VRTK_SDKManager.instance.UnloadSDKSetup() crashing

Environment

Source of VRTK: Github
Version of VRTK: cf205d2
Version of Unity3D: 5.6.1 (and an earlier version, I forget the version exactly)
Hardware used: Oculus Rift
SDK used: OpenVR/SteamVR

Steps to reproduce

Load any sample scene
Hit backspace

Expected behavior
Another scene should load
Current behavior
Same scene may flicker on one or one attempts, then either Unity will crash for the SDK Setups will fail to load any SDKs.
Both editor and build will display inconsistent results. Sometimes the scene will load, other times not - this is repeating the same exact steps over and over.
To reproduce you may need to attempt several times.

Are you saying this only fails when you go back a scene and don't go forward?
i.e. Backspace crashes but Space never crashes?

Both directions. Also crashes in my own scenes where I use that function and try to change scenes.

Reinstalled Unity to 5.6.1f, reinstalled SteamVR, and the switching between scenes (in my own project) seems stable.
Neither space or backspace loads another scene - it now reloads the current.

As you're getting different results, I'd say this is a localised issue only you're having as you're not able to consistently recreate the issue.

I'm happy if you want to close this for now - if I experience further difficulty can always reopen.

Yeah, may be worth closing this and trying to solve this one in the slack channel as it seems localised to your setup (http://invite.vrtk.io)

I'm actually able to recreate this if I skip the scenes very fast I can cause unity to crash.
If i pause between each skip then it's fine, but rapidly skipping crashes.

Actually I can recreate it every time.
Unity 5.5 with latest github master.
Open Up 006_Controller_UsingADoor and cycle to the next scene.
It will crash every time.

Seems to be something to do with the body physics script

fixed with https://github.com/thestonefox/VRTK/commit/b94d453234f0d9bee6ac79cbb027714ae37ddec4


no Header

i've tried a lot but i get no header.
i can't also find in the code where the function getHeader is used?!
Many thanks for every Tip ;)

Just copy the example config and try again. This should reveal the header.
If it is not working than I need more information because I cannot replicate the behaviour.


Add path to static assets in head

Add the public path variable to the static assets in the HTML head so that if the path is changed in config/index.js the assets will resolve properly.
From
    <!-- Add to home screen for Android and modern mobile browsers -->
    <link rel="manifest" href="/static/manifest.json">
    <meta name="theme-color" content="#4DBA87">

    <!-- Add to home screen for Safari on iOS -->
    <meta name="apple-mobile-web-app-capable" content="yes">
    <meta name="apple-mobile-web-app-status-bar-style" content="black">
    <meta name="apple-mobile-web-app-title" content="vuepwa">
    <link rel="apple-touch-icon" href="/static/img/icons/icon-152x152.png">
    <!-- Add to home screen for Windows -->
    <meta name="msapplication-TileImage" content="/static/img/icons/icon-144x144.png">
    <meta name="msapplication-TileColor" content="#000000">

To
    <!-- Add to home screen for Android and modern mobile browsers -->
    <link rel="manifest" href="<%= htmlWebpackPlugin.files.publicPath %>static/manifest.json">
    <meta name="theme-color" content="#4DBA87">

    <!-- Add to home screen for Safari on iOS -->
    <meta name="apple-mobile-web-app-capable" content="yes">
    <meta name="apple-mobile-web-app-status-bar-style" content="black">
    <meta name="apple-mobile-web-app-title" content="vuepwa">
    <link rel="apple-touch-icon" href="<%= htmlWebpackPlugin.files.publicPath %>static/img/icons/icon-152x152.png">
    <!-- Add to home screen for Windows -->
    <meta name="msapplication-TileImage" content="<%= htmlWebpackPlugin.files.publicPath %>static/img/icons/icon-144x144.png">
    <meta name="msapplication-TileColor" content="#000000">

@notoole-vccp I would be down with this change. @yyx990803 As far as you know, is this a pattern you would generally agree with? I hadn't seen it heavily used in other Vue templates so wanted to check.

It is used in vue-cli template.html but using handlebars like syntax is more prominent.

@znck with that in mind I think this change should be fine. As this is an enhancement, I'll mark as such as we'll get to it shortly unless someone would like to write a PR for it.

Closing this issue since the #73 has been merged.


Consistently handle ModifierNotFoundError in relations

@koskimas we talked about this today on Slack. This seems like the cleanest solution to me, as there are parts in the library that rely on being able to distinguish ModifierNotFoundError  from other Error objects.

Coverage increased (+0.0001%) to 97.182% when pulling 15dbe630321eb2ad2e70a3065a73811022364265 on lehni:fix/consistently-handle-modifier-not-found-error into 536cd93d50e4a14a6b2f629f79972d40a2527e2b on Vincit:master.


Adding Translations to Animals, Objects, Etc

First I just want to say how much I appreciate this project already-there's already so much I can learn from it! I would love to see translations available over animals and other objects aside from blocks, but I don't know how feasible that would be. Cheers!

I think modifying the mob (animal and monsters) textures would be quite difficult and not yield the best result. It would be ideal if the name of the mob was on top of it's head (like with a nametag). We would make the top line be pinyin and the line below be 汉字. However I'm not sure this could be achieved with a resource pack. It can be done with simple command blocks though or with a server plugin (or a mod).


Fix bad accessor use in reveal in explorer

Fixes #221818
Caused by<PHONE_NUMBER>fdefb35e043ea2a11f1f311bb5ad16
@benibenj you can't use an accessor after an await. You might have introduced other cases
cc @lramos15

Would be nice to have tests for commands to catch this before merge

Thanks for creating a PR for this, however, I've just created one which fixes this issue not to long ago.


Parser: Do not allow incomplete-size fields in anonymous records.

Fixes #275

I'm not sure the best way to test this one - the enclosing anonymous record in #275 has an absolute path in its name, so it will be different on each system.

I'm not sure the best way to test this one

It's pretty tricky, best I could come up with would be to trim the path away but that would only leave something like .c:69:5)'.


Added Rpi4 platform config files

"REFPLTV-1652: Containers - Packager (LISA) on RPI4
Reason for change: Added Rpi4 platform config files
Test Procedure: Sample ESSOS App should work in Rpi4 platform
Risks: Low
"

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Add function to parse rules from raw buffer

There are some cases where we need to load rules not only from files, but directly from memory. One of these is updating over the network and (re)parsing without dropping to disk.
yr_compiler_add_string() is not suitable because buffers in-memory are not null-terminated, and strlen() is time consuming.
Here we add the ability to work with the most portable form of raw data: pointer + size.

@plusvic can you merge this PR? This is not even a "feature", but just one "wrapper" function that uses an already existing API (one in the lexer and one in the compiler).


add test case 4 soul-admin vo

This part is simple, but coverage is still very important。

give me


Feat: added examples of models and policies and added test for basic enforce function.

@KNawm @santhoshivan23, I've added a test group for simple enforce. I've also left a commented out test group for the case when policyPath is empty. First test group is passing when the second group is commented out but it fails if the second group is also present. Somehow value of Enforcer in the first group is also changed to that of Enforcer in second group. I'm trying to look out for the reason for this and trying to replicate the issue in a smaller project to check if this is an issue for the testing package.

@MrUnfunny fix:

@KNawm @santhoshivan23, I've added a test group for simple enforce. I've also left a commented out test group for the case when policyPath is empty. First test group is passing when the second group is commented out but it fails if the second group is also present. Somehow value of Enforcer in the first group is also changed to that of Enforcer in second group. I'm trying to look out for the reason for this and trying to replicate the issue in a smaller project to check if this is an issue for the testing package.

It may be because the Enforcer was first implemented as a singleton, I'm unable to test now but check the implementation of the Enforcer and make sure it doesn't store the instance in itself.

@MrUnfunny The Enforcer class is implemented as a singleton instance which means, only one Enforcer instance will be instantiated in memory. @KNawm, I think we followed this approach due to the factory constructor paradigm in Dart.

@KNawm @santhoshivan23 I've removed the use of singleton in Enforcer. Please review the changes.

@MrUnfunny Just checked out. All test cases passed!

@hsluoyz PR can be landed.

We should get CI working ASAP as we now have working tests.


Please update on 1.21 !

All in the title... Please we need that !

No real Alternative out there .. PLEASE UPDATE to 1.21 ...

Resolved by #51. Full release here in a bit.


fix: point at maintained organum

gmorphene/organum is flagged as not maintained in favor of this one

Sorry to leave this open for so long - if you dig a bit further, you'll find that the 'maintained' version referenced in the organum readme is a partially completed rewrite that doesn't support as many org features, and need more work to be useful for org-crud's purposes (urls get broken out according to inline markup - it's more focused on converting org to markup than clojure maps).
At this point I've pulled in both impls and have dropped the dependency completely - the namespace will be absorbed into org-crud directly, and the readme will get a rewrite once that work is better defined and underway.


OpenTK window not opening when running sample on linux

I'm not sure if this is just an issue with using archlinux or not as you said you were able to get it running on ubuntu, but when running the provided sample program using the dotnet tools it doesn't crash but it doesn't display an OpenTK window either.

Hm, interesting. If the window itself isn't even showing up then I would have to guess that there's a problem with OpenTK. Do you have SDL2 installed? I've found that often OpenTK behaves a little better in some cases if it's using the SDL2 backend. Not sure if SDL2 is available on Arch Linux or not.
Do you know if the program is reaching any of the real drawing code, or is it hanging before that or something?

I was actually able to get the window to pop up for a second by adding using System to Program.cs (I added it so I could print some stuff to the console to test where things were hanging).
Sill it only pops up for a second throwing a System.DllNotFound exception. Heres the error message i'm getting.
Unhandled Exception: System.TypeInitializationException: The type initializer for 'ImGuiNET.ImGui'
threw an exception. ---> System.DllNotFoundException: Unable to load DLL 'cimgui': The specified module could not be found.
 (Exception from HRESULT: 0x8007007E)
   at ImGuiNET.ImGuiNative.igGetIO()
   at ImGuiNET.ImGui..cctor() in /home/spacey/ImGui.NET/src/ImGui.NET/ImGui.cs:line 25
   --- End of inner exception stack trace ---
   at ImGuiNET.ImGui.GetIO() in /home/spacey/ImGui.NET/src/ImGui.NET/ImGui.cs:line 27
   at ImGuiNET.SampleWindow..ctor() in /home/spacey/ImGui.NET/src/ImGui.NET.SampleProgram/SampleWindow.cs:line 53
   at ImGuiNET.Program.Main(String[] args) in /home/spacey/ImGui.NET/src/ImGui.NET.SampleProgram/Program.cs:line 8

I think I may have forgot to build cimgui for myself, anyway thanks for the help!

Yep, you'll need to do that, to start. You should use commit fb044c4b6a25a5f8ce6409d6ecfc8702828b6e65 from cimgui.
https://github.com/Extrawurst/cimgui/commit/fb044c4b6a25a5f8ce6409d6ecfc8702828b6e65

After building it myself (trying both that specific commit and the latest version) it seems to only sometimes. For sometimes it hangs on creating the window, sometimes it segfaults, sometimes it crashes with no message, and sometimes it works. Its hard to exaplain; but it does seem to be an issue with cimgui and not ImGui.NET.

Hm, the fact that window creation doesn't work sometimes makes me believe that it's a problem with OpenTK. It's interesting that it sometimes works, though...

Updated all of my packages and it works 99% of the time now. Still not sure why it opens then insta closes that 1% of the time but it isnt much of an issue. Thanks for your help man!

Nice! If you get any more information about that 1%, I can try to help. Glad you've got things working most of the time, though.

Maybe you could try with newer version of OpenTK? Iirc it was quite easy to switch to 2.0.

Hi. I am using OpenTK.NetStandard and .NET Core 3.1 on Ubuntu 20.04. I followed the lesson "Creating a window" exactly, and my window is not opening. Here is my source code: https://git.io/JUyKZ I added a few Console.Writeline calls, and it appears that it is crashing when creating a new window. `OpenTK.NetStandard' worked fine on my old Linux laptop, so I don't know what is wrong. Any help would be appreciated 😃


opkg package from shell script

Hi mwarning,
thanks for providing examples on how to create ipk packages for OpenWRT.
Is it also possible to create such package for an installer.sh ?
I would like to run my install.sh from an opkg package and therefore I need to create a Makefile, right?
Here are my first lines of the Makefile:
include $(TOPDIR)/rules.mk

PKG_NAME:=example
PKG_VERSION:=1.0.0

include $(INCLUDE_DIR)/package.mk

PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME)-$(PKG_VERSION)
PKG_SOURCE_SUBDIR:=$(PKG_NAME)-$(PKG_VERSION)
PKG_SOURCE:=installer.sh
PKG_SOURCE_URL:=http://someurl.com/
PKG_HASH:=e2166050d404cffd26769b5c5e33e72173a34914c2eabad6b235039025c0ac1c

define Package/example
  SECTION:=base
  CATEGORY:=Network
  TITLE:=My Installer
  MENU:=1
endef

define Package/example/description
 My description ...
endef

define Package/example/install
	sh installer.sh
endef

$(eval $(call BuildPackage,example))

I would be very grateful if you could give me a hint to solve my issue :)

Yes, that is possible. But the installer.sh would need to know the source and target path. $(INSTALL_DIR) and $(1).


Warning from using deprecated react code

Hi, I got these two warning from using Tappable.
Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.
Warning: Tappable: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.
Not sure if this is already tracked. Just a reminder. Thank you.

Hi @mark-sun,
This has already been fixed and merged in https://github.com/JedWatson/react-tappable/pull/101
Please help to get this published by +1 the following issue: https://github.com/JedWatson/react-tappable/issues/103


WebGL docs tasks for Fx69

See https://trello.com/c/mhsKKnNY/170-webgl-api-fx-68 for original trello card.
Acceptance criteria

[ ] Implement webgl2 draft ext OVR_multiview2 — documented appropriately.

fwiw, this seems to be behind the webgl.enable-draft-extensions pref and doesn't ride the 69 train.

OK. We'll close this for now in that case, and look at it again when it is enabled.


Unable to resolve filesystem provider with relative file path vscode-notebook

Environment data

VS Code version: 1.62.1
Jupyter Extension version (available under the Extensions sidebar): v2021.10.1001414422
Python Extension version (available under the Extensions sidebar): v2021.11.1422169775
OS (Windows | Mac | Linux distro) and version: MacOS Catalina 10.15.7
Python and/or Anaconda version: Python 3.6.8
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv
Jupyter server running: Local

Expected behaviour
Close an unsaved editor of a .ipynb file
Actual behaviour
Unable to open '***.ipynb': Unable to resolve filesystem provider with relative file path 'vscode-notebook:file:///Users/jdrake/***/***.ipynb'.

Steps to reproduce:
Unclear how the editor got in this situation. The .ipynb file exists and can be opened in a separate editor.
Logs
No Jupyter logs. Error shows up in Log (Window).

Output for Log (Window) in the Output panel

[2021-11-09 12:54:01.741] [renderer1] [critical] FAILED to destory notebook {"fileOperationResult":8}
[2021-11-09 12:54:01.745] [renderer1] [error] Error: Unable to resolve filesystem provider with relative file path 'vscode-notebook:file:///Users/jdrake/talos/notebooks/data-pipeline/glue.ipynb'
    at yi.withProvider (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:602:21816)
    at yi.withReadProvider (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:602:22115)
    at yi.readFileStream (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:602:26966)
    at Ds.resolveFromFile (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2388:56459)
    at Ds.doResolve (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2388:55031)
    at async f.doResolve (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2388:72343)
    at async sr.load (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2379:4655)
    at async u.createReferencedObject (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2388:81781)
    at async c.resolve (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2388:84080)
    at async wn.resolve (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1936:816)
    at async Ss.setInput (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1938:75643)
    at async n.doSetInput (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2342:34632)
    at async n.doOpenEditor (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2342:33032)
    at async n.openEditor (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2342:32680)
    at async vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2544:16967
    at async Bi.doHandleDirtyClosing (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2544:22528)
    at async Bi.handleDirtyClosing (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2544:21883)
    at async Bi.closeEditors (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:2544:23125)
    at async Promise.all (index 0)

I'm getting this as well. Ubuntu and file extension .ipynb

I'm seeing this issue as well

Ok I was able to resolve the issue by manually overriding the sqllite database specific record for in the workspace.
Using macOS, within /Users/username/Library/Application Support/Code/User/workspaceStorage, under the relevant workspace folder, open state.vscdb in sqllite.
Under the key, memento/workbench.editors.files.textFileEditor you'll have a value of
{
    "editorpart.state": {
        "serializedGrid": {
            "root": {
                "type": "branch",
                "data": [
                    {
                        "type": "leaf",
                        "data": {
                            "id": 0,
                            "editors": [
                                {
                                    "id": "workbench.input.notebook",
                                    "value": "{\"resource\":{\"$mid\":1,\"fsPath\":\"file:///Users/username/my_script.ipynb\",\"external\":\"vscode-notebook:file%3A///Users/username/my_script.ipynb\",\"path\":\"file:///Users/username/my_script.ipynb\",\"scheme\":\"vscode-notebook\"},\"viewType\":\"jupyter-notebook\",\"options\":{\"startDirty\":true}}"
                                }
                            ],
                            "mru": [
                                0
                            ]
                        },
                        "size": 955
                    }
                ],
                "size": 1411
            },
            "orientation": 0,
            "width": 1411,
            "height": 955
        },
        "activeGroup": 0,
        "mostRecentActiveGroups": [
            0
        ]
    }
}

The problematic file file:///Users/username/my_script.ipynb is the first item in the editors list.  If you re-write that 1 item and delete mru field, VS Code will open next time without the un-closable file.

@fridiculous That worked for me! Awesome, thank you.


fix(build css issues): build css issues

when running npm run build && npm run start then accessing the site it causes css issues.


Allow YAML header in output file

Hi,
here's another small PR, this time concerning #197 .
I modified the function strip_headerto look for a field called output_header in the YAML header given in the input file. If it exists, its contents are then reexported into YAML and added as a header for the output file.
A test is added as well.
What are your thoughts ?
I have not added anything in the documentation yet because I wasn't sure where it would fit best.

nice, will give a review on this (and the other one) this weekend 😉

Thanks @JonasIsensee , when trying to review this, I finally crafted #305 by myself 😅
How about only striping Weave headers when generating markdown ? AFAIU, all the other output format expects no header YAML at this point.

Hi,
your suggestion sounds good.
Just to make sure: The header could also be preserved when converting a jupyter notebook to .jmd?

no, afaiu there's no YAML header spec in notebooks. Could you elaborate your idea ?

What you are saying is probably correct but my use case is the following:
I do numerical simulations in jupyter notebooks along with extensive markdown explanations.
Once finished (or after updates)
I use weave to export this to markdown for use in a jekyll website.
Jekyll needs a yaml header.
I don't want to edit my output markdown files, so i
put the YAML in the first notebook cell.
So for maximal flexibility I would like there to be a way to preserve the header during weaving (and maybe during conversion between jmd and notebook)

ah I see.
If you put a YAML header in the first markdown cell, and weaving (or converting) your notebook into markdown, then the YAML header will be preserved as the other markdown contents.
Well, the YAML header will look weird in the Jupyter notebook frontend, since there is no spec for YAML rendering.

Yeah, it looks a bit odd but I don't mind if it allows me to not have to edit all output files every single time after re-exporting.

okay close in favor of #305


chef-client 13 issues

this cookbook needs minor updating to be compatible with latest chef-client 13 that was released today. PR #42 fixes this and was tested to work on CentOS 7.

+1

looks good and seems like its needed

+1

I created a new cookbook based on this one with my fixes for chef-client 13 as well as added windows support. https://supermarket.chef.io/cookbooks/timezone_iii#readme

I've tested my new timezone_iii cookbook and it's working.


How can I get the all-in-focus image output?

This is a very interesting work!
After running and modifying the code, I get the predicated depth map and focus map, but I cannot find a way to get the predicted all-in-focus image. Could you please give me a clue to help me get the all-in-focus output?
Thanks a lot!

Hi! Excuse me, I get an error when running run_training.py （[Errno 2] No such file or directory: '../models/a01_d02_t01/a01_d02_t01_ep1000.pth'）can you help me？


packages/ parallel race condition

If MsBuild is used to build the solution with paket in parallel, then the lock implementation in Paket is broken; see https://github.com/fsprojects/Paket/commit/66ca1d50e9f84291a32948e4f3f3dff02aba399f#commitcomment-19267997 for details and suggested solution.
This issue is identical to the closed issue https://github.com/fsprojects/Paket/issues/858
I may not have identified our interleaving, but the end result is a never-finishing build because some lock never is released, so progress cannot be made.

 Or do you know someone who might be interested in fixing it?

What about only running paket once per solution instead of once per project?  I know there's no "before solution" event, but can we come up with a way to make it work?


Automated cherry pick of #1517: .circleci: save go cache

Cherry pick of #1517 on release/2.11.0.
#1517: .circleci: save go cache

Codecov Report

:exclamation: No coverage uploaded for pull request base (release/2.11.0@b68476f). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release/2.11.0   #1518   +/-   ##
================================================
  Coverage                  ?   7.68%
================================================
  Files                     ?     411
  Lines                     ?   62834
  Branches                  ?       0
================================================
  Hits                      ?    4826
  Misses                    ?   57597
  Partials                  ?     411

Flag
Coverage Δ

#aFlag
7.68% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b68476f...f54c0f7. Read the comment docs.

/lgtm
/approve


added example images

example images have been added to (most of) the view elements, some do not have images as they cannot be demonstrated with images such as touch gestures

I'm pulling this as Kyle is going to work on splitting up the view-elements doc page into a few bits next, I don't want to conflict this

I looked at the images and they do look good.


Add support for browsing file system of Kubernetes pods (containers)

For example see: https://marketplace.visualstudio.com/items?itemName=sandipchitale.kubernetes-file-system-explorer.
Basically uses:
kubectl exec -it podname -c containername -- ls /
to get the listings of files starting at /. Show them as tree nodes. Also using the command:
kubectl exec -it podname -c containername  -- cat /path/to/file
and showing the returned content in a editor.
BTW the extension also shows the initContainers and Containers in a pod. Shows the filesystems of the running containers.
Both supported by the extension above.
Lastly even better option would be to support dual pane file browser for local and container filesystem. Use the the:
kubectl cp fom podname:/to
to copy files from/to.
Use the https://code.visualstudio.com/api/references/vscode-api#FileSystemProvider API to implement the container filesystem browser.

This is super cool!  Thank you for letting us know about this @sandipchitale!  Is there anything specifically you'd like the core extension to do?  Because it looks like your project is working great as an extension that builds on top via the API, and if we implemented this ourselves then it would just suck the oxygen out of your project.  But if there are limitations in the core extension API that are making your life harder, or if we can amplify or contribute to your work, let's talk!
Thanks for letting us know about this!
cc @squillace

Do we have a place to post "related extensions"? It might be good to start building up a list of extensions that build on top of the API.

@itowlson I am glad you find the extension useful. I will be happy for it to continue as a separate extension. It could be an example of how to extend your extension via API.
Your API is already good. The only thing I would request is availability of context of custom nodes to be used in the when clause of menu contributions. That way I could show the Find command for FolderNodes only and View file command for FileNodes only.  Basically something along the lines of viewItem =~ /vsKubernetes\contrubutednode....
BTW I am looking into implementing (time permitting) the dual pane idea for being able to copy files to/from container easily. I guess this is sort of possible using View file command and the saving the Untitled document locally. But the dual pane one will work more like FileZilla or something. It will use VSCode FileSystemProvider backed by -- ls -l executed in the container. And use kubectl cp command to copy files to/from container/local file system.
I guess you can close this issue.
BTW I have another extension based on your API: https://marketplace.visualstudio.com/items?itemName=sandipchitale.kubernetes-no-load-on-select

I think that having Kubernetes support in vscode remote will be more useful that just browsing POD file.
Please check https://github.com/microsoft/vscode-remote-release/issues/12

@bhack thanks for the reference. I agree that will be more complete solution. My integration was a quick and simple implementation to get browsing going.
In first comment I suggested using FileSystemProvider based on Kubectl command integration via this extension.

Yes the plugin is closed source so we can just upvote that issue to prioritize It.

For anyone coming here...the above extension supports:

shelling into nodes using nsenter
exploration of container files, viewing, tailing, kubectl cp from/to container folders and files to local folder and files

BTW this issue can be closed if there are no plans to implement the issue functionality in the Kubernetes extension's code.


feat(preconditions): add preconditions

Please describe the changes this PR makes
Introduces the two main required preconditions (for now before we introduce permissions v2)
Status and versioning classification:

Code changes have been tested against the Discord API, or there are no code changes
This PR includes major changes

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: PenPow:x: kodiakhq[bot]You have signed the CLA already but the status is still pending? Let us recheck it.


Exception while tag is not found in xml

I am extracting some tags from xml, but if that tag or hierarchy is not present in an xml, Is it possible to get null ? This Issue is not related to Issue 117 .. As  tag is present in xml schema but in my case this tag or hierarchy is not present in xml then not in xml schema ..
Appreciate for your Help.
Thanks
Ansh

Could I please ask your sample codes and output maybe?

Any Luck ?

I am sorry. I think I didn't understand the issue clearly. So, you set rowTag to, for example, ABC for the XML you gave but you want to produce null for each Address?

Ok , I will make you understand again.  While filling address by user, user address can be completed in two lines and another user filled it in three lines.
User1 Xml

user2 xml

But my query i generic, It should handle both the case. But for second xml I am getting line3 is not found
sqlcontext.sql("select address.line1,address.line2,address.line3 from table").show();
Thanks
Ansh

define schema manually.. If you infer the schema automaticaly, the lib may not detect the line3 tag


Add transparent background color to versions switcher

Fixes blue background:

Must be a regression from the shorthand switch patch.


created and organized graphql page, filled out lambda functions section, cleaned up and clarified workflows page

also added navigator encryption error to lessons learned


In app messaging/broadcast framework and approach

In Android we have different ways to communicate (across component messaging) within different components. Since Android recommends async operations so it becomes more important to have such framework for apps using the library
1- Broadcasts - The services on accomplishing certain tasks send a broadcast which consumer-apps can subscribe to, and get notified and act according to their business needs
2- CallBacks - The consumer-apps register a callback before calling the service and get notified when task is done
3- Events - Event based programming is another approach where consumer-app listens to specific events of interest and do their business accordingly
As a consumer-app fhircore app would need to get notified about many events including SyncStarted, SyncSuccess, SyncFailed, DataInserted, DataUpdated, FhirEngineInitilized, FormSaved, FormFailed, FormCancelled, etc etc
I do not see any such messaging framework implemented in fhirsdk (Or may be could not figureout any). Which one is the best approach and what we are planning to implement. Basically rightnow I need this to implement one of the feature where we want to keep user posted about last sync performed however, down the road with new features we may need to have a full fledged messaging flow

If there's a related approach on the Android FHIR SDK let's make sure to align w/that

Sync use cases:

Show the last sync date in the UI.
Show an icon if there are any issues i.e if the last Sync Failed
Show any error messages related to Sync

Discussed on the call:

Makes sense to add lastUpdated method to the sync API
Set up a separate call to discuss adding support for this into the SDK. Need to flesh out details further
@maimoonak keen to work on this within fhirsdk

cc: @jingtang

https://developer.android.com/topic/libraries/architecture/workmanager/how-to/intermediate-progress
In previous call we discussed the use of LiveData. The CoroutineWorker basically allows to observe the progress as above. The PeriodicSyncWorker would need to be updated to accommodate it.

This all sounds like work to be done in Android FHIR SDK, in FHIR Core we'd use the API the SDK exposes

Unless I'm missing something? Maybe we can split this issue and keep this one to include the using the API pieces that stay here in FHIRCore, and a new (or reference to an existing one if it's there) issue in Android FHIR SDK for the other changes

What's the status of this issue?  @maimoonak

This one, i.e. #142, #175 , #554 all are related. The details on the progress can be tracked on #554 and the PR #648. There were back and forth discussions with Jing and now need a review and feedback on this PR


Meta: Adopt a "project" process

Close to two years ago, we landed stubs for epoll and some related functions to get an empty tokio program to work. Those stubs were buggy and lacked basic sanity checks, and two years later they are still just stubs. IMO we can conclude that this approach of just landing something and then figuring things out as we go was a failure.
When embarking on larger projects, like epoll support, we need a plan -- t-lang has design meetings, t-compiler has MCPs, t-libs-api has ACPs. The pattern is always the same: we should have an idea and consensus on where we want to go and how we want to get there before we start even reviewing PRs that move us in that direction.
So I think for Miri we want a "project" process. It doesn't have to be heavyweight, but I am imagining something roughly like this:

A project proposal defines clearly what the goal is of this project. This defines the scope of the project, i.e. which part of which APIs should be supported. If this involves functions that expose a big API surface with lots of flags, the project may want to support only a tiny subset of flags; that should be documented. There must be at least one testcase given that Miri currently doesn't support and that should be supported when the project is done.  This testcase doesn't need to cover everything but it should call each relevant API at least once with a representative set of arguments and flags. IOW, the project is not defined by "we are done when the testcase passes", it just documents more concretely the scope of the project.
The testcase should be expressed by directly calling the relevant C FFI functions, not a high-level Rust crate. It's okay to start with a high-level test, but it's hard to judge the scope of the project and to evaluate the plan in step 2 without knowing the actual API surface Miri will be responsible for. So in that case developing the low-level test case is a blocker for moving to the next step of the project.
Once the team accepts that this is a goal we want to pursue, we need to make a plan. What exactly the plan looks like will depend heavily on the concrete project. Any extension to the machine state (adding anything new to MiriMachine or any of its fields) definitely needs to be part of the plan, specifying the type of the new state component and where it goes.  Similar if a new file descriptor type is involved, the data stored in the FD table for this file descriptor type needs to be pat of the plan. There doesn't have to be any code, just a rough description of how the new operations Miri needs to implement for this project interact with the new state -- and, if applicable, how existing operations interact with the new state.
Once the team accepts the plan, implementation can begin. Now that we have a plan, implementation doesn't need to be one big PR, but we can still make sense of each PR as taking small steps towards the goal, following the plan.

I am not sure what exactly the threshold is for when the process should be required, and we probably don't need an exact threshold. But roughly speaking, if a machine state extension (or new FD type, which is a machine state extension) is required, then the project process should be used.
@rust-lang/miri what do you think?

I don't know if we could have figured out the shims we need for tokio by writing up a plan. I don't think we could have even estimated what part of epoll we need.
If we just had stated we wanna support epoll, I wouldn't have known how to write tests. The rest of the proposal makes sense to me. We can then extract the actually supported and some unsupported use cases and write direct shim tests

I don't know if we could have figured out the shims we need for tokio by writing up a plan. I don't think we could have even estimated what part of epoll we need.

We still don't know which shims we need for tokio since the current support is extremely incomplete.
That needs some exploration. For instance you can just stub out some functions to see what the next function is we run into. Or you can run tokio "for real" and use ltrace to see which calls are needed. Or you can look at the source code.
But I think that should be done out-of-tree, and then once we know which shims we need -- or once we have identified a first hurdle, like "we need socketpair" -- we can proceed with those.

This sounds like a huge hurdle and feels like basically just causing people to decide it's not worth it.
To me personally that would mean I'd implement the whole thing in a branch and open a project proposal when it works. Along with all the rebasing pain and so on.

I don't understand the problem. Running tokio you see a socketpair call, so the first thing to do is socketpair -- you can forget about tokio for now, that's just something that needs to be implemented. Then you see something with eventfd, so you go look at the eventfd documentation and tokio sources to figure out which fragment of eventfd is required.
Stubbing out a bunch of calls to figure out what the next call after that is should take maybe 15 minutes. Running a bare-bones tokio application with ltrace should take less than a minute. I think that time investment is absolutely worth it.

The stubbing never got us far, it's exactly what we tried. I've never used ltrace, but that seems reasonable.
Looking at code is almost useless, as the devil is in the interaction of multiple calls and the runtime state they return, write, or store somewhere.
If ltrace gives us all the libc functions that were invoked, that's reasonable. Figuring out the flags that are potentially used will be harder, but can be delayed by just not supporting any flags that we haven't seen via stubbing so far.

If ltrace gives us all the libc functions that were invoked,

That's what it should do. And it works on many binaries, including cargo itself, but somehow not on locally built Rust binaries. I'm not the first to try this but that thread also doesn't have a solution.
strace however does show this -- it's on the syscall level but at least for the tokio MVP that matches libc quite well:
epoll_create1(EPOLL_CLOEXEC)            = 3
eventfd2(0, EFD_CLOEXEC|EFD_NONBLOCK)   = 4
epoll_ctl(3, EPOLL_CTL_ADD, 4, {events=EPOLLIN|EPOLLRDHUP|EPOLLET, data={u32=0, u64=0}}) = 0
fcntl(3, F_DUPFD_CLOEXEC, 3)            = 5
socketpair(AF_UNIX, SOCK_STREAM|SOCK_CLOEXEC|SOCK_NONBLOCK, 0, [6, 7]) = 0
fcntl(6, F_DUPFD_CLOEXEC, 3)            = 8
epoll_ctl(5, EPOLL_CTL_ADD, 8, {events=EPOLLIN|EPOLLRDHUP|EPOLLET, data={u32=1, u64=1}}) = 0

And then there's a bunch of junk for spawning the threads...
It shows the epoll_wait from the "sleep" test as well (when using strace -f, otherwise I think it doesn't trace off-main threads).

The stubbing never got us far, it's exactly what we tried.

Except for epoll_ctl and Event::write, the things that landed are basically stubs. So I don't follow. I'm basically saying instead of polishing them and then landing that, they should be seen as the initial exploration which would have told us about the three APIs involved: socketpair, eventfd, epoll.

I agree that more team coordination would be healthy.
I am also not opposed to what you're laying out here. Clearly stating a goal and agreeing on a plan to accomplish the goal is certainly one possible way to avoid problems.
But I am not sure that what you've laid out here is actually going to prevent what happened from happening again. If we agree with an interested contributor that their plan seems good, but then after landing the first of many planned PRs their circumstances change and they stop contributing... What do we do then? This is more of a project management question than anything else. If there's a plan laid out and the contributor vanishes but never clearly records publicly that they will not be finishing the project, what do we do?

If we agree with an interested contributor that their plan seems good, but then after landing the first of many planned PRs their circumstances change and they stop contributing... What do we do then?

Then we still have the plan described in the project tracking issue, which should make it much easier for someone else to pick up the work.

If there's a plan laid out and the contributor vanishes but never clearly records publicly that they will not be finishing the project, what do we do?

Sure, we shouldn't wait 22 months until we declare the project open for others again. But I don't think that was even the main issue here. The main issue, as I see it, was that there was no clear idea of what the next step would even be.

Well, I don't have any objection to asking for a plan before we merge anything that's part of a much larger effort. Planning is generally good, communicating expectations even better. I'm just wary of this having more limited upside than you are indicating.

Is it strictly better to have stubs than nothing at all?
Does having the stubs and test machinery in-repo lower the barrier for someone else to contribute in the future?

Are the stubs a maintenance burden?

Mostly, no.

Is it strictly better to have stubs than nothing at all?

It might be better to have nothing. The stubs in their current state make it easy to ICE Miri. There are a small handful of crates that hit an ICE path in the stubs, which makes it look like they've hit an interpreter bug.

Does having the stubs and test machinery in-repo lower the barrier for someone else to contribute in the future?

The above discussion makes a pretty solid case that the answer is no.

To some extend. We already had a case of someone adding a new shim modeled after one of the stubs. But it is unclear whether that stub can even be extended to anything useful without a major redesign, so IMO it is an unhelpful distraction to new contributors.

Perhaps the focus should be on review and making stubbed out PRs be in the right form?

Is it strictly better to have stubs than nothing at all?

Beyond what @saethlin said, there's also the problem that the stubs do NOT properly report errors when they are called with flags they will never support. So (a) some code that now passes Miri will actually fail in the future, and (b) we'll have to carefully re-review all that code when the feature gets properly implemented. It's easier to review code when it lands, and make sure it makes sense then, than to remember to re-review code in the future as it was landed in a shape that is unsuitable for the long term.

Agreed. But again, isn't this pointing to changing maintainer review standards for stubs rather than getting rid of stubs entirely with an up-front process?
FWIW as a drive-by committer usually the fact that all the plumbing is there is a huge benefit for me.  Perhaps this is just the way I like to work, but it is much easier for me to take something and change it then create something from scratch. I love to see bugs that are like "here is a pointer to some code, we need to do X".

FWIW as a drive-by committer usually the fact that all the plumbing is there is a huge benefit for me. Perhaps this is just the way I like to work, but it is much easier for me to take something and change it then create something from scratch. I love to see bugs that are like "here is a pointer to some code, we need to do X".

For some things this works, and there we can keep doing it.
But for e.g. socketpair, there's no simple drive-by improvement. There needs to be actual design. It's impossible to decide during PR review whether the proposed PR is compatible with a future design without having seen the design. That's why I don't think this can just be different standards for review of stub PRs. Instead I am saying we should not accept such stub PRs until there's a design they can be evaluated against.
Once there is an agreed-upon design, I am completely fine with landing a stub PR that implements just the first 5% of that design. During review it is then possible to actually check whether the PR matches the design, and later another contributor can do the next 5%. But the design needs to exist for this to work.

Makes sense to me!

I just wanted to cite guidance for larger-scale contributions to Miri, and then I realized this is still an open issue and just an open issue.
What should we do to close this issue? Adapt the consensus here into a new section in CONTRIBUTING.md?

Yeah I guess, though I am not entirely sure what the consensus is. ;)
Opened https://github.com/rust-lang/miri/pull/3807.


How do I support the target 29 SDK version?

MovieCreator support is required.

Any update on this? Need this fix on priority.


Change TiledMapTileLayer#tileWidth/Height to an integer.

TiledMapTileLayer#tileWidth/Height are changed to integers, as the constructor (and the map loaders) are already only allowing integer values. Fixes #3821.

since it's a potentially breaking change, i think it worth add few words in CHANGES.md. Users may not easily find where it breaks in their own code because of implicit int to float conversion. for instance:
float ratio = 640 / layer.getTileWidth();


Could you please update to the newest angular version, seems not working with 2.2.1

I've managed it with this version combination:
    "@angular/common": "2.2.1",
    "@angular/compiler": "2.2.1",
    "@angular/core": "2.2.1",
    "@angular/forms": "2.2.1",
    "@angular/platform-browser": "2.2.1",
    "@angular/router": "3.2.1",
    "@angular/platform-browser-dynamic": "2.2.1",
    "@angular/platform-server": "2.2.1",
    "@angular/compiler-cli": "2.2.1",
    "@ngtools/webpack": "1.1.6"

Also to mention I've updated some other stuff:
    "typescript": "2.0.10",
    "webpack": "^2.1.0-beta.27",
    "webpack-dev-server": "^2.1.0-beta.11",


Implement on_error chain on Results

Thanks to @iMacTia 's awesome work on the and_then chain, we have a great composable way to work with Results. If a Failure is encountered, we end the chain (rather, perform no-ops the rest of the way) and return that Failure. It would be great if we could pass a block to be executed if a Failure is encountered (useful for error logging or other reporting). It's important that we pass the Failure back instead of the return type of the block, as we want to guarantee the same Result type as and_then or the original Result.
res = do_something
  .and_then { |success| Failure.new }
  .on_error { |failure| puts "An error" }

# prints "An error"
res # => Failure

Nice!
Is the idea that #on_error can only be used for side-effects?
If so, I already took a quick stab at producing a PoC on the Sorbet Playground 👍

Yea exactly, it's mainly for capturing errors is my guess, without interrupting your chain

T.untyped will also work there, but I made an habit of avoiding as much as possible since T.anything became a thing 😄


dbt build: Change the way we handle tests (if parent test fails then don't run non-test children)

This work was finished, however it had to be removed from the PR due to difficulties with how some (many) of our tests operate.  Because the tests don't build a correct graph failures occurred when running those tests.  The obvious fix is to re-write those tests but it was too many to do as part of the dbt build effort.
References:

Branch with operational blocking feature and broken tests.
Discussion about why the tests caused it to hang

It looks like the particular commits we'd want to cherry-pick and revive are https://github.com/dbt-labs/dbt/commit/4dc29630b561aebe8c02f49cf1223476c9204950 + https://github.com/dbt-labs/dbt/commit/aaac5ff2e67f4f6f9482b1601855036671678c36

Exit criteria via example:

model_a has two children: a unique test and model_b
The unique test should run before model_b
If the unique test fails, model_b should skip running
The overall dbt build command should keep running

18:49:43 | Concurrency: 1 threads (target='dev')
18:49:43 |
18:49:43 | 1 of 7 START view model dbt_jcohen.model_a........................ [RUN]
18:49:43 | 1 of 7 OK created model dbt_jcohen.model_a........................ [INSERT 2 in 0.09s]
18:49:43 | 2 of 7 START test unique_model_a_id............................... [RUN]
18:49:43 | 2 of 7 FAIL test unique_model_a_id................................ [FAIL in 0.12s]
18:49:43 | 3 of 7 SKIP relation model_b...................................... [SKIP]


Performance Difference between Plugins developed by python-pdk and Lua based plugins

Hey Guys,
I am fairly new to Kong Gateway and was planning to integrate kong OSS in my application as a API gateway.
My application is mostly build on python3 so I was planning to implement few additional authentication mechanism plugin using kong-python-pdk
I wanted to know from performance point of view is there any downgrade of performance if the custom plugins are build on python3 rather than Lua?
are there any performance tests done or reports available
Thanks in advance

Hi @rohan-97 , the performance drop is highly related to how many PDK calls you invoked in your Python plugin. As external
plugins talks to Kong through network RPC and is faily heavy. I would say the downgrade of performance is noticable.
But I don't have exact numbers yet, I will post here when results are available.

Thanks @fffonion for the information!


Problem when you login as both admin and user.

It seems to be a minor issue. But an annoying one. Whenever I run my site. And login as both an admin and my user profile. The links at the top of the page. On both the admin and the user side at the top. Sometimes Disappear. All except the people drop-down menu. It seems to happen randomly and suddenly. And I never know when.  It makes it hard when you're trying to work in the admin section. Or testing stuff in the front end. Just thought I would pass this along here.

Hey @AKNightHawk
Thanks very much for pointing this out!
What web browser do you use? And what screen resolution is it? Or maybe, could you just send here a screenshot when the problem occurs?

Your welcome @pH-7 I am currently using Firefox and my Resolution is 1366 x 768 soon as I get time to take a pic I will post it here. Thanks so much. :)


Send message on behalf of the user not reply from the bot.

An app such as giphy doesn't send gif as bot user but the requested user himself. I'm making an app similar to giphy. One of my user complains about not being able to delete the image because the person has no right. I've looked through the documentation and couldn't find it.
It would be great this feature is supported by botkit.

Does the user have admin privledges? If they do they should be able to delete the message in slack.


Update<EMAIL_ADDRESS>

Pin SwiftSemantics to main.  This is required since the 0.3.1 release of SwiftSemantics pins SwiftSyntax to 4ae758ab85ed2a5d3e3e8b5050a8ce52179bd102 and SwiftSyntaxHighlighter requires release/5.5.  In order to restore the ability to resolve the dependencies, we need to bump SwiftSemantics to main.

@mattt - I suppose that an alternative would be to bump Semantics to 0.3.2 after rolling another release?

@compnerd I just released SwiftSemantics 0.3.2, which targets swift-syntax release/5.5. My latest commit here (76679a3) pins to that version. I'm going to see if I can retarget #269 to this branch and rebase to pick up these changes (rather than merge this into main first and hope that CI passes).

Running that locally I see:
PS S:\SourceCache\swift-doc> swift package resolve
Updating https://github.com/apple/swift-syntax.git
Updated https://github.com/apple/swift-syntax.git (1.06s)
Updating https://github.com/NSHipster/SwiftSyntaxHighlighter.git
Updated https://github.com/NSHipster/SwiftSyntaxHighlighter.git (0.63s)
Updating https://github.com/SwiftDocOrg/swift-cmark.git
Updating https://github.com/NSHipster/HypertextLiteral.git
Updating https://github.com/SwiftDocOrg/SwiftSemantics.git
Updated https://github.com/SwiftDocOrg/SwiftSemantics.git (0.72s)
Updated https://github.com/SwiftDocOrg/swift-cmark.git (0.72s)
Updated https://github.com/NSHipster/HypertextLiteral.git (0.72s)
Updating https://github.com/SwiftDocOrg/CommonMark.git
Updating https://github.com/SwiftDocOrg/Markup.git
Updating https://github.com/SwiftDocOrg/GraphViz.git
Updated https://github.com/SwiftDocOrg/GraphViz.git (0.58s)
Updating https://github.com/apple/swift-argument-parser.git
Updated https://github.com/SwiftDocOrg/CommonMark.git (0.58s)
Updated https://github.com/SwiftDocOrg/Markup.git (0.58s)
Updating https://github.com/apple/swift-log.git
Updating https://github.com/NSHipster/swift-log-github-actions.git
Updated https://github.com/apple/swift-log.git (0.60s)
Updating https://github.com/SwiftDocOrg/SwiftMarkup.git
Updated https://github.com/apple/swift-argument-parser.git (0.60s)
Updated https://github.com/NSHipster/swift-log-github-actions.git (0.60s)
Updated https://github.com/SwiftDocOrg/SwiftMarkup.git (0.53s)
Computing version for https://github.com/apple/swift-argument-parser.git
Computed https://github.com/apple/swift-argument-parser.git at 0.3.2 (0.09s)
Computing version for https://github.com/NSHipster/swift-log-github-actions.git
Computed https://github.com/NSHipster/swift-log-github-actions.git at 0.0.1 (0.07s)
Computing version for https://github.com/apple/swift-log.git
Computed https://github.com/apple/swift-log.git at 1.4.2 (0.07s)
Computing version for https://github.com/SwiftDocOrg/Markup.git
Computed https://github.com/SwiftDocOrg/Markup.git at 0.1.2 (0.10s)
Computing version for https://github.com/NSHipster/HypertextLiteral.git
Computed https://github.com/NSHipster/HypertextLiteral.git at 0.0.2 (0.07s)
Computing version for https://github.com/SwiftDocOrg/GraphViz.git
Computed https://github.com/SwiftDocOrg/GraphViz.git at 0.4.1 (0.07s)
Computing version for https://github.com/SwiftDocOrg/SwiftMarkup.git
Computed https://github.com/SwiftDocOrg/SwiftMarkup.git at 0.3.0 (0.10s)
Computing version for https://github.com/SwiftDocOrg/CommonMark.git
Computed https://github.com/SwiftDocOrg/CommonMark.git at 0.5.0 (0.08s)
Computing version for https://github.com/SwiftDocOrg/SwiftSemantics.git
Computing version for https://github.com/SwiftDocOrg/SwiftSemantics.git
error: Dependencies could not be resolved because root depends on 'SwiftSemantics' 0.3.2..<0.4.0.
'SwiftSemantics' >= 0.3.2 cannot be used because package 'swiftsemantics' is required using a stable-version but 'swiftsemantics' depends on an unstable-version package 'swift-syntax' and no versions of 'SwiftSemantics' match the requirement 0.3.3..<0.4.0.

#279 has this change integrated into it as well.  It probably makes sense to squash and merge this, and then merge main into #279 and then merge that.


Add support for PLAINTEXT signature method

I was trying to authenticate to Freshbooks using request, and it turned out that they currently support only PLAINTEXT as a signature method http://developers.freshbooks.com/authentication-2/
So I read about it here http://oauth.net/core/1.0/#anchor22 and I figured that it should be the same as the hmacsign minus the base string.
Now obviously the first 3 arguments are not needed in this case, but I kept them here because I just pointed my request's oauth-sign dependency to my patched version and it worked
I can remove these 3 arguments and after this is being published I can patch the request's source code as well, or we can just leave it as it is. Let me know what do you think.
Also summoning @nylen

I don't like the extra arguments because we export plaintext as its own function.  We should not change the signature of sign though, so you could do something like this:
var method
var skipArgs = 1
...
  case 'PLAINTEXT':
    method = plaintext
    skipArgs = 4
...
return method.apply(null, [].slice.call(arguments, skipArgs))

Right, @nylen can you take a look at my last commit as well? I just added 2 simple unit tests to prove our point.

:+1:
New npm version coming up shortly, then I can write tests and docs this week and get this merged into request, unless you want to beat me to it :)

version 0.6.0 is out.

Thanks, about request - that would be great, let me know if I need to add anything about this feature there :+1: