NIFI-9761 Correct PeerChannel processing for TLS 1.3

Description of PR
NIFI-9761 Corrects PeerChannel handling of TLS 1.3 post-handshake messages, avoiding unexpected behavior when attempting to read from the underlying SocketChannel after previous calls have already put data in the stream buffer. This resolves a latent issue with Load-Balanced Connections and TLS 1.3 communication.
The new TestPeerChannel leverages a simple socket server based on Netty to confirm expected behavior for both TLS 1.2 and TLS 1.3.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[X] Has your PR been rebased against the latest commit within the target branch (typically main)?

[X] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[X] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

such a great find/fix.

Further testing with the LoadBalanceIT in nifi-system-test-suite uncovered an issue with an unnecessary call to streamBuffer.compact(), as well as missing SSLEngine close notification processing.  The current version includes additional trace logging.

That's a great catch @exceptionfactory , thanks for finding & fixing that! I'm a +1 will merge


Unable to use IAM credentials

Newer versions of the jdbc driver allow for use of IAM credentials instead of username/password. [1]
This is preferable to storing and passing around credentials.
It looks like the parameter validation in spark-redshift should be updated to reflect the new authentication method. [2]
[1] http://docs.aws.amazon.com/redshift/latest/mgmt/generating-iam-credentials-configure-jdbc-odbc.html
[2] https://github.com/databricks/spark-redshift/blob/master/src/main/scala/com/databricks/spark/redshift/Parameters.scala#L71

PR #374 opened, forking project due to note implying that this project isn't going to be supported going forward


ENUmain. dic cant fix AT&T with NVDA but it works with SAPI-4 Eloquence

In an attempt to fix AT&T, I added the following to ENUmain.dic:
AT&T `[.2e.2ti.0xn.1ti]
While it works with Eloquence SAPI-4/Kurzweil 1000, I can't get it to work with NVDA. I even altered NVDA's treatment of & "And" by sending it directly to the synthesizer via the Preferences->Punctuation/symbol pronunciation dialog but it just results in a different pronunciation not the intended one. So the "dash" rule apparently fails here. Any solutions or work-arounds?

This is odd, the ECI documentation says that this is acceptable for an  input key in Main, but I can't get it to work either. Might be a problem with the driver itself? @ultrasound1372

Could also be NVDA's splitting expressions that it uses when capitals are involved, splitting and such. It's why backquote voice tags don't work by default even if you have the symbols passing through, the number gets broken. A good fix I think is to add a pronunciation entry for AT, Eh T, which would fix things like AT vendors, and AT&T in one fell swoop.


LDAP or SSO login and account creation

Would it be possible to add AD/LDAP or SSO login and account creation to the manager dashboard?

Hi this is a very specific modification and my script is general purpose. If you want I can do it just for you for a fee.


Linking error when trying to compile

Got the following linking error when trying to compile this repo:
[2/83] Linking CXX executable oirp
FAILED: oirp
: && /usr/bin/c++ -O2 -g -DNDEBUG  CMakeFiles/oirp.dir/tools/OIRP.cpp.o -o oirp  -Wl,-rpath,/object-introspection/extern/drgn/build/.libs:/object-introspection/extern/drgn/build/velfutils/libdw:/object-introspection/extern/drgn/build/velfutils/libelf:/object-introspection/extern/drgn/build/velfutils/libdwelf  _deps/rocksdb-build/librocksdb.a  /usr/lib/x86_64-linux-gnu/libzstd.a  /usr/lib/x86_64-linux-gnu/libmsgpackc.so.2.0.0 && :
/usr/bin/ld: _deps/rocksdb-build/librocksdb.a(cache_reservation_manager.cc.o): relocation R_X86_64_32S against symbol `_ZTVN7rocksdb27CacheReservationManagerImplILNS_14CacheEntryRoleE9EE22CacheReservationHandleE' can not be used when making a PIE object; recompile with -fPIE
/usr/bin/ld: failed to set dynamic section sizes: bad value
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

To reproduce:
docker run -it ubuntu:22.04 bash
apt update && apt install git pip
pip3 install toml
apt-get install -y bison autopoint build-essential clang-12 cmake flex gawk libboost-all-dev libbz2-dev libcap2-bin libclang-12-dev libcurl4-gnutls-dev libdouble-conversion-dev libdw-dev libfmt-dev libgflags-dev libgmock-dev libgoogle-glog-dev libgtest-dev libjemalloc-dev libmsgpack-dev libzstd-dev llvm-12-dev ninja-build pkg-config python3-setuptools sudo xsltproc libboost-all-dev

git clone https://github.com/facebookexperimental/object-introspection.git
cd object-introspection/
cmake --build build/ -j
CXX=clang++-12 CC=clang-12 cmake -G Ninja -B build/

Hi @raakasf, thanks for trying out our software! I just tried this out on a fresh machine on Ubuntu 22.04 in a Docker container running Ubuntu 22.04 following the commands you gave me, with one adjustment: the cmake commands are in the wrong order.
$ docker run --rm -it ubuntu:22.04 bash
$ apt update && apt install git pip
$ pip install toml # pip3 worked, but it was missing later

$ apt-get install -y bison autopoint build-essential clang-12 cmake flex gawk libboost-all-dev libbz2-dev libcap2-bin libclang-12-dev libcurl4-gnutls-dev libdouble-conversion-dev libdw-dev libfmt-dev libgflags-dev libgmock-dev libgoogle-glog-dev libgtest-dev libjemalloc-dev libmsgpack-dev libzstd-dev llvm-12-dev ninja-build pkg-config python3-setuptools sudo xsltproc libboost-all-dev

$ git clone https://github.com/facebookexperimental/object-introspection.git
$ cd object-introspection/
$ CXX=clang++-12 CC=clang-12 cmake -G Ninja -B build/
$ cmake --build build/ -j

$ build/oid --help
usage: oid ...
  -h,--help                      Print this message and exit
  -p,--pid <pid>                 Target process to attach to
  -c,--config-file               </path/to/oid.toml>
  -x,--data-buf-size <bytes>     Size of data segment (default:1MB)
                                 Accepts multiplicative suffix: K, M, G, T, P, E
...

It looks to me like something on your system is requiring PIE, as none of the commands specify it explicitly. Could you give us a little more information on the host system, mainly distro? I'd be happy to look into this further but haven't been able to reproduce it yet.

Oh that may have been just copy-pasta™ error :) I wasn't prepared to file this issue and when couldn't get it to work, just started going back in history and pasting commands here.
Here's my host Ubuntu 22.04.3 LTS (Jammy Jellyfish). Just to be sure, I'll run those commands again and see if I find anything out of place.

Ok, nvm. I found out as soon as read your commands (thought they are the same as mine) that I didn't pass CXX=clang++-12 CC=clang-12  to the 2nd command, and with that it builds fine. Thanks


Windows 2022 - Visual Studio 17.11

Description
Hi,
The new VC++ 17.11 have an issue with the STL.
See:  https://developercommunity.visualstudio.com/t/1711-fails-to-compile-templated-code-un/10730785
Is there a way to use the older Windows 2022 image?
The one before the new What’s New for C++ Developers in Visual Studio 2022 17.11
Erez
Platforms affected

[ ] Azure DevOps
[X] GitHub Actions - Standard Runners
[ ] GitHub Actions - Larger Runners

Runner images affected

[ ] Ubuntu 20.04
[ ] Ubuntu 22.04
[ ] Ubuntu 24.04
[ ] macOS 12
[ ] macOS 13
[ ] macOS 13 Arm64
[ ] macOS 14
[ ] macOS 14 Arm64
[ ] Windows Server 2019
[X] Windows Server 2022

Image version and build link
Same errors you see in https://developercommunity.visualstudio.com/t/1711-fails-to-compile-templated-code-un/10730785
Is it regression?
The one before Visual Studio 17.11
Expected behavior
Proper compiling without errors.
Actual behavior
We get errors similar to https://developercommunity.visualstudio.com/t/1711-fails-to-compile-templated-code-un/10730785
Repro steps
Just run the tests using C++ STL

Hi , @erezgeva .Thanks for reporting. We are looking for some mitigation. The image is old because there was a regression in F# which forced us to rollback the image and we have been waiting for a new Visual Studio release (17.11.3) that has the fix.

Hi @erezgeva The new image (20240915.1) has been successfully rolled out, resolving the issue. Please sync your main branch. Thank you!

@erezgeva I hope the issue has been resolved, If you have any queries please reach out to us. I am closing this issue now,Thanks.


Event IDs do not match the ones on active systems

The event IDs mentioned does not correspond with the ones I find in the event log. 20322 is 'PTR record registration for IPv4 address' on my servers.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1346caa3-4785-27e2-e1ca-986f57a4c663
Version Independent ID: 7c9329a2-d778-9b3d-0e4a-4210eaaeae7e
Content: DHCP Logging Events for DNS Record Registrations
Content Source: WindowsServerDocs/networking/technologies/dhcp/dhcp-dns-events.md
Product: windows-server
Technology: networking
GitHub Login: @JasonGerend
Microsoft Alias: jgerend

We hugely appreciate your contribution, feedback, and support to our technical documentation.
We’ve phased out GitHub Issues on this repository as the feedback mechanism for content and have replaced it with a new feedback system. For more information see, Content User Feedback. As part of this rollout, we are migrating your issue where our team will use your comments to improve the documentation experience. Unfortunately, this does mean you won't be able to access this issue after the migration is complete.
All issues will be migrated by Thursday 29th August 2024.
Once again, thank you for your valuable feedback, we hope you’ll continue to contribute using our new feedback system.


Collection Runner does not respect "Form URL Encoded" body setting

In one of my Bruno collections, I use a POST method with "Form URL Encoded" body to request a new access-token from my Keycloak IDP using "client_credentials" grant. When I directly execute the request from the Bruno UI, the body format is correct. This is the output from Wireshark:
POST /realms/master/protocol/openid-connect/token HTTP/1.1
Accept: application/json
Content-Type: application/x-www-form-urlencoded
User-Agent: axios/0.26.1
Content-Length: 96
Host: keycloak.example.com
Connection: close

client_id=portal-sa&client_secret=Rjg22ueDNVPFMq0gzk2WHG4r49jtziEG&grant_type=client_credentials

However, when I run the exact same request using the collection runner, the request is sent like this:
POST /realms/master/protocol/openid-connect/token HTTP/1.1
Accept: application/json
Content-Type: application/x-www-form-urlencoded
User-Agent: axios/0.26.1
Content-Length: 110
Host: keycloak.example.com
Connection: close

{"client_id":"portal-sa","client_secret":"Rjg22ueDNVPFMq0gzk2WHG4r49jtziEG","grant_type":"client_credentials"}

As you can see, the body is now encoded as JSON, which results in a 400 - Bad Request from the Keycloak server.

@DuncanDoyle using the bru run CLI tool (Bru CLI 0.7.1) for running the collection does work as expected. The issue appears to only be in the GUI app.

This bug was fixed I guess, because I tested Form Url Encoded in both UI and CLI and the request generated is the following

which is what is expected
So for me this bug can be closed

Closing this issue as this has been fixed. Please reopen if the issue persists.


AutoVersioningPlugin introduced #87

@szczepiq
What do you think about this? The idea was to keep VersioningPlugin as simple as possible, since it's needed for releasing.previousReleaseVersion, so I added AutoVersioningPlugin which handles commiting and pushing to GitHub.
I created a new project to test only auto-versioning.
https://github.com/wwilk/shipkit-versioning-example
You can see exemplary bumping version commits there.
It's not fully configured yet, since I want to first release auto-versioning plugin and then use it here.
In travis-release task I would just call ./gradlew publishPlugins bumpVersionAndPush.

@wwilk, FYI I made few changes on your branch. The changes are small enough that I will allow myself to merge the PR. Thanks again for the codes! :D


Feature/fix issue 323

Coverage remained the same at 100.0% when pulling 63cf0ef1edbfdc66d55e502eb0820c1e0ba76654 on feature/fix-issue-323 into 24d3af8060bf1203b56130443ebb6bf1441f99fd on develop.


Bump aws sdk modules

Description of changes:
Using the latest available version for all modules:

github.com/aws/aws-sdk-go v1.50.34
github.com/aws/aws-sdk-go-v2 v1.25.3
github.com/aws/smithy-go v1.20.1

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
/approve


Assets Bundles with HTTP Basic Athentication

Is there any information related to $Subject when it comes to dropwizard.
Static contents are initialized as :
bootstrap.addBundle(new AssetsBundle("/assets", "/ui", "index.html"));

HI All, Any information regarding "Static Asserts Bundles with HTTP Basic Auth" in dropwizard..?
It seems Jetty has a way to do this, I would like to know if there is a way in dropwizard. http://stackoverflow.com/questions/10750978/basic-http-auth-for-static-pages-in-jetty-8

You would need to extend AssetServlet and override the doGet method. There you can extract credentials from the Authorization header, verify them and return a  401 error in case they don't match. You can then create a custom AssetBundle and override  the  createServlet method in which return your custom servlet.

Thank you for your reply. Is this something dropwizard could do in a future release soon. E.g., adding a parameter block in the config (with necessary details) to enable and disable assets basic auth?
If there are no such plans, we could go ahead, try it out - if it works as expected and then possibly put a pull request ... please let us know.

I don't think that such a common scenario. Usually static resources are JS libraries, CSS and HTML templates, which rarely need to protected. In most cases, Dropwizard applications are deployed behind a web server like Nginx, where you can easily set authentification for a specific resource in an easy manner.
Having said that, pull requests are always welcome. You can submit your code to discuss implementation ideas and bring an attention of other developers who may be interested in the same feature.


Bugfix/update syntastic doc

Updated the doc to say that syntastic support must be enabled.

In response to #58. I don't believe this completely solves the problem, but indicates that it must be enabled.
I tried using the method stated in Syntastic's External Checker info, but it still wouldn't load automatically.

So this PR makes it better but doesn't completely solve #58 ? What is missing?

Well, that depends on what the goal is. I think the best-case scenario would be that the user doesn't have to configure the checkers manually in their .vimrc.
I'm not totally sure that's possible. I couldn't get it working following the steps in Syntastic's guide.

Hi - why did you close this?

Oh, my bad. I deleted the branch on my fork without realizing I still had an open PR. I'll restore it when I get back to my computer.

Ok cool - I've been doing some work on the other PR this weekend. Would like to include the project.json support for now so have pulled your changes and made a few amendments. Should hopefully be ready to push fairly soon.

There we go. Reopened.

Cheers.


Don't set Default Stats by when no StatsFunc arg is passed

Coverage remained the same at 97.36% when pulling 96d74482191873cd0b13c171144dc7b806a94aa3 on PL1-3222 into f7dd75766315f06cfa7d5eb9340b54302f193da2 on master.

Coverage remained the same at 97.36% when pulling 96d74482191873cd0b13c171144dc7b806a94aa3 on PL1-3222 into f7dd75766315f06cfa7d5eb9340b54302f193da2 on master.


Update readme

config.handlers.redmine.url = "https://redmine.site.cz"
config.handlers.redmine.secret_key = "<secret key to encrypt tokens in redis>"

It should be config.handles.redmine2.
Also a note about secret_key having a max length of 56 would be helpful!

Hello, I dont thing so, official Lita's documentation says:
Lita.config.handlers.handler_with_config.api_key and users can set a value for it in their lita_config.rb file. The handler can then use the value the user sets by calling config.api_key in any instance method. The config instance method is a convenience accessor equivalent to robot.config.handlers.your_handler_name.
I will add note about secret_key length anywhere from 4 to 56 bytes.

Ok, I am sorry. My mistake - You mean name of handler - not redmine bud redmine2.

Fixed in commit 138374e

👍🏻


Strange excption in OnInit

I following scenario in 0.6.0 preview
protected override void OnInit()
    {
        this.scoreOptions = new API.GetScoreOptions();
    }

This is results in the
WASM: 13

This is quite a magic for me. I understand that this may be not an issue with Blazor itself but with Mono, but trying anything in OnInit always give me all kind of funny errors.

Do you have any call to Console.WriteLine in GetScroptOptions ? They are prepend by "WASM" and put on the browser console

No, I have only AutoRest generated client there. It is called synchronously.

Sorry for the bizarre error message. I don't know what that means either.
Can you supply a minimal and self-contained repro so we can investigate?

@SteveSandersonMS See issue here: https://github.com/kant2002/BlazorWasm13

Ah, I see. Thanks for posting the repro!
The issue is that you're trying to block the UI thread, which is not possible. The entire JS runtime doesn't allow the thread to be blocked. In .NET terms, if you have a task, you can await it, or you can ContinueWith after it, but you cannot call .Wait() or .GetAwaiter().GetResult() or evaluate .Result for tasks that aren't yet completed.
Specifically, it's this line:
var x = GetTaskAsync().GetAwaiter().GetResult();

This is why there's an async version of OnInit (i.e., OnInitAsync), so you can do things asynchronously.
Separately, the error message 13 is clearly bizarre. If you'd be willing to report this to http://github.com/mono/mono, pointing out that it's a strange error for Mono WebAssembly to throw if you try to block on a task, then hopefully they will be able to make it easier to understand.


libsForQt5.libopenshot-audio: 0.2.2 -> 0.3.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/libopenshot-audio/versions.
meta.description for libsForQt5.libopenshot-audio is: "High-quality sound editing library"
meta.homepage for libsForQt5.libopenshot-audio is: "http://openshot.org/"
meta.changelog for libsForQt5.libopenshot-audio is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.3.0 with grep in /nix/store/01pvplnnlf4gz1s2sllwmvqd9i1ix71c-libopenshot-audio-0.3.0
found 0.3.0 in filename of file in /nix/store/01pvplnnlf4gz1s2sllwmvqd9i1ix71c-libopenshot-audio-0.3.0

Rebuild report (if merged into master) (click to expand)

5 total rebuild path(s)

5 package rebuild(s)

First fifty rebuilds by attrpath
libsForQt5.libopenshot
libsForQt5.libopenshot-audio
openshot-qt
plasma5Packages.libopenshot
plasma5Packages.libopenshot-audio

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/01pvplnnlf4gz1s2sllwmvqd9i1ix71c-libopenshot-audio-0.3.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A libsForQt5.libopenshot-audio https://github.com/r-ryantm/nixpkgs/archive/3e72531b370c0aec6ffe431e7a41b8f3c619426d.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/01pvplnnlf4gz1s2sllwmvqd9i1ix71c-libopenshot-audio-0.3.0
ls -la /nix/store/01pvplnnlf4gz1s2sllwmvqd9i1ix71c-libopenshot-audio-0.3.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

3 packages built:

libsForQt5.libopenshot
libsForQt5.libopenshot-audio
openshot-qt

Maintainer pings
cc @AndersonTorres for testing.

@ofborg build openshot-qt


fix: add missing iptables rule for default network namespace forwarding

For some reason on some launches this rule isn't required and is already set.
This ensures it is set for all veritech launches (it's required for the NAT traffic to leave for the firecracker VM's to reach the internet)

bors merge


[PE-D][Tester B] Unknown use of square brackets in UG

There are some use of square brackets which surrounds the value e.g. t/[TUTORIAL] rather than the entire tag e.g. [t/TUTORIAL]. This suggest that the value is optional but not the tag. However, this is not the observed behavior in the application.

Labels: severity.Low type.DocumentationBug
original: McNaBry/ped#5

Remove square brackets


Fixed CSE Machine Display on Mobile Devices

Description
Closes #2696
Running the CSE machine on mobile used to switch the active tab over to code editor instead of viewing the CSE Machine. Now added a check so user would not toggle to the code editor if the user was on the CSE machine tab.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How to test

Switch to Source-4 on Mobile
Run CSE Machine on Mobile
CSE Machine should show up on your screen instead of returning to the code editor

Checklist

[x] I have tested this code

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

-2 of 3 (33.33%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 37.215%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/pages/playground/Playground.tsx
0
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.01%

Covered Lines:
5722

Relevant Lines:
14442

💛  - Coveralls


GEOPY-725

**GEOPY-725 - **

Codecov Report

Merging #23 (912611c) into develop (7296d35) will decrease coverage by 0.41%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           develop      #23      +/-   ##
===========================================
- Coverage    80.26%   79.85%   -0.41%
===========================================
  Files           14       14
  Lines          988      988
  Branches       141      141
===========================================
- Hits           793      789       -4
- Misses         136      140       +4
  Partials        59       59

Impacted Files
Coverage Δ

omf/fileio/geoh5.py
88.24% <33.33%> (-0.86%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


bad interpreter error after High Sierra update

Since upgrading macOS to High Sierra, I can no longer use the video_transcoding tools.  I get the error
-bash: /usr/local/bin/detect-crop: /System/Library/Frameworks/Ruby.framework/Versions/2.0/usr/bin/ruby: bad interpreter: No such file or directory
Indeed, browsing to the Ruby versions reveals only 2.3.  Anyway I can fix this?  Sorry if this is an elementary question, I'm an end user and not really savy with Ruby.

@joethezombie Thanks for the detailed information! I always appreciate that because you made it easy to diagnose this problem.
Whenever you do a major OS upgrade on macOS, e.g. Sierra to High Sierra, you need to remove and reinstall Homebrew and your Ruby Gems.  I know that sounds like "reinstall Windows" and a big pain, but it's really necessary.

@joethezombie I'm glad that worked out! And you are very welcome, sir! I'll close this now but feel free to continue commenting here or you can open another issue.

@donmelton I was a little late to the game with upgrading to High Sierra, but received the same error message as @joethezombie. I resolved my issue, and am good to go now, but thought I would share what I discovered while troubleshooting (before I found this thread :-/).

High Sierra upgraded the ruby version from 2.0 to 2.3
As noted in the error message, detect-crop was trying to use ruby 2.0, which no longer existed on my system
gem install seems to insert #!/System/Library/Frameworks/Ruby.framework/Versions/X.X/usr/bin/ruby -W at the top of your scripts, where X.X is the specific version number of ruby that was present when the gem was initially installed
The error message is generated because the old, fully-qualified path to ruby no longer exists
Additionally, the RubyGems Environment installation directory changed from /Library/Ruby/Gems/2.0.0 to /Library/Ruby/Gems/2.3.0, so ruby wouldn't find the previously installed gem anyway. This is also why gem list no longer included video_transcoding as a local gem.

That's a long way of saying that your recommendation to reinstall the Ruby Gems after a major OS upgrade is the way to go. Perhaps you could add your recommendation to the FAQ, for future reference?

@goodydc Thanks for the information!
That's a good idea. However, it might be better for folks to install Ruby using Homebrew instead of relying on the version which ships with macOS. That's what I do. I may change the README to include both strategies.

@donmelton Good call. I didn't install Ruby using Homebrew since Sierra already included a version that worked with your tools.
Thanks for all your hard work on these tools! :-)

@goodydc You are very welcome! And keep those useful comments coming.


fix(js/function-paren-newline): prevent newline error in type parameter

First commit with failing tests, second with actual fix
fixes #206

Since this is actually a TS syntax issue, I wonder the reason you choose to fix it inside the js rule instead of ts? I am ok to have them in js rule if it would be too hard to workaround in the ts rule, as eventually we are going to merge them into one. But if possible, I think we favor having them in ts rule in order to have a clear scope.

Yes, it is TS syntax, therefore I wrote the condition to ignore TS related tokens. Current implementation found first opening paren in type parameter which leads to false positive error and wrong fix.
I mean, JS rule reports an error in TS code and fixes TS code, which is not correct - therefore the fix is here. Also, it doesn't introduce any improvements for TS code


HUB-97: IDP reminder on Verify start page

In order to make it easier for users to re-use their IDP, we're moving the
IDP reminder from the sign-in page to the start page. A new view has been
created to render a different 'hinted' view when the cookie is present.
Solo: @jakubmiarka

To merge and release on a Monday morning to make it easier to analyze for the performance team. Discuss & agree with the performance team which Monday

There have been some changes/fixes to how we report hint success. After we have enough data and evaluated them, we can release this.

Targeting merge & deploy on 6th August, to allow for performance team make necessary changes to their reporting pipeline.


Linking issue on macOS

Hello! I am having an issue with linking while trying to build on macOS 11.4. I have gone through all the steps required to build, and made sure that all the dependencies were installed, but when I run the last step, esy build, I get this error:
info esy build 0.6.10 (using package.json)
...
    discover src/reason-libvim/c_flags.sexp,src/reason-libvim/cxx_flags.sexp,src/reason-libvim/flags.sexp (exit 2)
(cd /Users/gabriel/oni2/_esy/default/store/b/oni2-a73832fe/default/src/reason-libvim && config/discover.exe)
-L/Users/gabriel/.esy/3________________________________________________________________/i/libvim-8.10869.88-635ecf25/lib
Unable to find libintl: End_of_file
You may need to install gettext: `brew install gettext`
Fatal error: exception Failure("Unable to find libintl")
error: command failed: 'dune' 'build' '-p' 'libvim,textmate,treesitter,Oni2,vterm' '-j4' (exited with 1)
esy-build-package: exiting with errors above...
error: build failed with exit code: 1

I did some digging and found a closed issue (https://github.com/onivim/oni2/issues/1604), but the solution described is not working for me.
Here is what I have done so far:

reinstalled gettext
$ brew reinstall gettext
relinked gettext
$ brew unlink gettext && brew link gettext
looked for libintl
find /usr -name libintl* -print 2>/dev/null (returned fish: No matches for wildcard 'libintl*'.)
completely restarting the installation process (from npm install -g node-gyp onwards)

Nothing has changed here, I am always getting the same error for linking. Any help would
NOTE:
I just checked sudo find / -name libintl* under bash and I found a few files matching the name, namely
/Library/Frameworks/Mono.framework/Versions/6.12.0/lib/libintl.dylib
/Library/Frameworks/Mono.framework/Versions/6.12.0/lib/libintl.la
/Library/Frameworks/Mono.framework/Versions/6.12.0/lib/libintl.8.dylib
/Library/Frameworks/Mono.framework/Versions/6.12.0/share/gettext/intl/libintl.rc
/System/Volumes/Data/Library/Frameworks/Mono.framework/Versions/6.12.0/include/libintl.h
/System/Volumes/Data/Library/Frameworks/Mono.framework/Versions/6.12.0/lib/libintl.dylib
/System/Volumes/Data/Library/Frameworks/Mono.framework/Versions/6.12.0/lib/libintl.la
/System/Volumes/Data/Library/Frameworks/Mono.framework/Versions/6.12.0/lib/libintl.8.dylib
/System/Volumes/Data/Library/Frameworks/Mono.framework/Versions/6.12.0/share/gettext/intl/libintl.rc

pretty sure that these are not accessible (or usable) by esy though.

I would love a better explanation for how I fixed this, but for other reasons I had to completely wipe and reinstall macOS on my laptop, and for whatever reason I no longer had this issue. The only difference that I can see with this current installation and my previous one is that I installed homebrew in a different way.
Like I said, I would really love to have a better explanation but for now I am going to close this issue.


Random characters appear when sending code to R

From https://twitter.com/MichaelDorman84/status/1252194037064441857.

One issue I encountered is that when sending code to R (not radian) sometimes it also sends unnecessary '1~' or '0~' strings which causes an error...

Is there anything we can do about this? I thought we already fixed this.

I thought we'd fixed this too!
Knowing the OS and r.bracketedPaste setting would be useful.

Thank you very much for the great tools & for looking into this!
OS is:
michael@dell15:~$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.4 LTS
Release:	18.04
Codename:	bionic

and VS Code setting are:
{
    "r.bracketedPaste": true,
    "r.alwaysUseActiveTerminal": true,
    "r.sessionWatcher": true,
    "r.rterm.linux": "/usr/local/bin/radian",
    "window.zoomLevel": 1,
    "breadcrumbs.enabled": true,
    "workbench.colorCustomizations": {
        //"editorError.foreground":   "#00000000",
        //"editorWarning.foreground": "#00000000",
        "editorInfo.foreground":    "#00000000"
    },
    "telemetry.enableTelemetry": false,
    "workbench.activityBar.visible": false,
    "workbench.panel.defaultLocation": "right",
    "editor.wordWrap": "on",
    "cSpell.enableFiletypes": [
        "rmd"
    ],
    "cSpell.userWords": [
        "CARTO"
    ],
    "files.associations": {
        "*.geojson": "json"
    }
}

@michaeldorman Thank you for the info! Bracketed paste mode is basically intended for use with radian only. The R console doesn’t support bracketed paste and when bracketed paste is used with R on Linux/Mac it will produce those junk characters.
I don’t think we really have a way to check whether R or radian is being used in the terminal. So, you pretty much have to switch r.bracketedPaste on or off depending on what you’re using. (Even less convenient than it sounds, because it requires a reload of the extension. It would be good if we could avoid this requirement at least.)

@michaeldorman Is there a reason you’re using both radian and R? There may be an alternative workaround depending on your use case.

@andycraig I understand, thank you! Will disable the r.bracketedPaste option if necessary.
I'm not yet decided whether to use radian or R. On the one hand, the code highlighting and autocomplete in radian are great. On the other hand, seems like there is slight lag when typing code and also it's confusing to me that when sending a code block the input is printed in one piece and then all outputs follow in another piece (as opposed to seeing alternating input/output lines, like in R).

@michaeldorman Gotcha! I was wondering if you might be using radian in some projects and R in others. I think enabling/disabling r.bracketedPaste is about the only option unfortunately.
We could potentially change it so that when using bracketed paste the code is sent as several expressions rather than all at once. This would allow for alternating input/output. This is unlikely to happen soon, but it's useful to know that there is interest in that approach.

@andycraig I understand, thank you! Sending the whole code block has other advantages, however, for example being able to go back to a previously executed entire code block with the up/down arrows. So I'm not sure what's better eventually, maybe it's just a matter of getting used to :-)
By they way, one thing I'm missing is being able to send the code from the beginning
of the document down to the cursor location (like Ctrl+Alt+B in RStudio). Re-running the script up to the expression being edited is very useful when interactively developing new scripts. (If it's more appropriate that I post this suggestion in separate issue please let me know, will be happy to do that)

@michaeldorman

By they way, one thing I'm missing is being able to send the code from the beginning of the document down to the cursor location (like Ctrl+Alt+B in RStudio).

Happily, this one would be easy to implement! If you could create a new issue for it that would be great. Thank you!

@andycraig Thanks! I've created a new issue.

@michaeldorman Thanks for creating the new issue!
I'm going to close this issue, but if you think it should be reopened please let us know.

@andycraig I understand, thank you! Will disable the r.bracketedPaste option if necessary.
I'm not yet decided whether to use radian or R. On the one hand, the code highlighting and autocomplete in radian are great. On the other hand, seems like there is slight lag when typing code and also it's confusing to me that when sending a code block the input is printed in one piece and then all outputs follow in another piece (as opposed to seeing alternating input/output lines, like in R).

OK, it took some getting used to, but now I'm using VS-code with radian at all times! :-)

@michaeldorman Great to hear! I’m a big fan of radian.


Add support for request.headers_out in remy.lwan

Whoa, that was quick. So quick, there was a typo in my commit (pushed the wrong branch by mistake). :)

@lpereira lol. i will wait a bit more the next :)


Inconsistent rendering of characters

Windows Terminal version
1.15.2713.0
Windows build number
10.0.22000.1098
Other Software
Cygwin vim 8.2
zsh 5.8
Steps to reproduce
Type in some text such as console.log 'hello', palette in vim or zsh
Possible relevant:

System / Display / Custom scaling of 135%
3840x2160 monitor
Font is Hack FC Ligatured at 14pt. Also tried a more vanilla Hack with similar effects.
Text antialiasing set to ClearType. (Also tried Grayscale with similar effects.)
No apparent difference with "Redraw entire screen" or "Use software rendering" turned on.

Expected Behavior
Identical characters to look similar
Actual Behavior
Some strokes look thicker than they should, with possible overdraw.
In Vim: look at weird s and different os

In zsh: look at different hs and ls

Do you have the "AtlasEngine" feature enabled under the "Rendering" settings? Could you try toggling the switch and restarting Windows Terminal to see how the other rendering mode works for you?

This is #4591

Ah sorry, I thought we had merged that into the 1.15 release branch as well. If you install Windows Terminal Preview (1.16) the issue will most likely not occur anymore.

Oh, thanks. On 1.16.2642.0 with Atlas turned on (as is the default), I see a different issue:

Both lines should be identical, but the top one has weird rendering. Moving lines up and down consistently misdraws the top line (whichever one is in the second row of the window).
Perhaps clearer with antialiasing turned off:

I assume this is also #4591, or should I open a different issue?

Interesting! I'd say it's the same issue even if it behaves slightly different. I suspect this is a bug in Direct2D which we can't do that much about just yet as we depend heavily on it. But I'll have to look into it first...


Use chipper grunt build-js

We should port kite to use chipper grunt build-js and delete copied grunt things.  Additional tasks that must be kept can be moved to chipper or chipper can run the extra tasks from kite.
See https://github.com/phetsims/scenery/issues/567

In the above commit, I switched to chipper builds and confirmed the automated test harness for compiled versions is working correctly.


Quick find shortcut doesn't work initially with notion enhancer.

Description
When the Notion app is opened and I want to quickly find a page using the shortcut Ctrl + P, it doesn't work. However, the shortcut is fully functional without notion-enhancer. Also, if I click the "quick-find" button on the sidebar and then try the shortcut it works. Upon restarting the app, the bug reappears.
Screenshots
N/A
Platform
Windows 10 Home

@aarjav24 is the tabs extension enabled?

@dragonwocky Yes

@aarjav24 is the tabs extension enabled?

Yes


No longer able to drag files between folders in the side bar

VSCode Version: 1.15.0-insider
OS Version: Windows 10

Steps to Reproduce:

Drag a file in the sidebar from one folder to another
Drop. Nothing happens.

Reproduces without extensions: Yes
Note that I am not using multi-root workspaces in this case. I have only one root folder.

https://github.com/Microsoft/vscode/issues/30462


code refactor

Current coverage is 41.64% (diff: 100%)

No coverage report found for master at 526cf98.

Powered by Codecov. Last update 526cf98...3a919c5


[QUESTION] Create Offer and Answer always generate a SDP containing C line as c=IN IP4 <IP_ADDRESS>

When I create an answer or offer to hand over to another peer, I'm seeing the SDP line C always as c=IN IP4 <IP_ADDRESS>, I know this is a default IP and WebRTC doesn't consider it because of ICE, but as I'm using a SIP Server it does consider this line and when the call establishes with the server, it keeps the call on hold.
There is some workaround to update this SDP line?
Expected behavior
SDP Offer/Answer containing IP gathered from STUN and not c=IN IP4 <IP_ADDRESS>
Observerd behavior
All SDP Offer/Answer are beining generated with c=IN IP4 <IP_ADDRESS>
Steps to reproduce the problem
Create a RTCPeerConnection.createOffer() or even an Answer.
RTCPeerConnection.createOffer()
    .then(sdp => {
        console.log(sdp);
    })

Platform information

React Native version: 0.57.7
Plugin version: 1.67.1
OS: Android
OS version: 8.1

You can modify the SDP yourself once you get it in the promise result, before you send it to your server. Note however, that if your server doesn't already support this, chances of it properly working with a WebRTC endpoint are pretty slim.


Visual regression testing

@DevExpress/testcafe  Let's discuss functionality of layout testing
I suggest to use the following approach. Perhaps it looks too over engineered, but it is pretty flexible at my sight.
Screenshot provider
I suggest to provide possibility to use any comparing screenshots library.
We do two options out-of-the-box - per-pixel comparison and perceptual hash comparison.
To avoid working with huge binary images we can calculate perceptual hash.
In this case we don't create screenshot file and compare only hash value.
To build the diff images use should run the local tests in per-pixel mode.
Also we can provide possibility of taking screenshot in black and white mode or ultra contrast mode. I think it can be passed to the chosen library as layoutTestOptions.
So we create:

Pixel perfect provider with options

{
    mode: 'color' | 'black_and_white',
    threshold: Number
}

Perceptual hash with options

{
    threshold: Number
    // or
    exactMatching: true | false
    //it will be depend of implementation
}

Run options
For the run function we add options for screenshot comparing:
{
    etalonsPath: <relative_or_absolute_path>,
    layoutTestProvider: <provider_name>,
    layoutTestOptions: {...},
    updateEtalons: true | false
}

Accordingly, we add the similar options to the CLI interface:
--etalons-path, --layout-provider, --update-etalons.
Test API
We provide two different ways to testing layout.

We look for an etalon automatically and user should just call t.checkLayout() method.

checkLayout() is searching for a screenshot for test in according to index of using in the test code body, starting with 0.
test('testName', async t => {
    await t
        .click('#el')
        .checkLayout() //looking for .../<testName>/<workerName>/1.png
        .type('.inputClass', 'value')
        .checkLayout() //looking for .../<testName>/<workerName>/2.png
        ......
        .click(...)
        .checkLayout() //looking for .../<testName>/<workerName>/<N>.png
});

We provide testControler.Image constructor and .equalLayout() assertion.
That means user should decide on their own how to store artifacts and etalons, we just use comparing logic from provider.

E.g.:
 test('testName', async t => {
     await t.expect(new t.Image(<image_path>)).equalLayout();
 });

Also we should resize browser window up to screenshot size.
Screenshots storage
Every provider implements mechanism of storing artifacts.
For per-pixel provider we store screenshots similarly with current screenshots directory. Also we should create difference files in that directory.
Etalons will be got from path that specified in etalonsPath for programmatically API or from --etalons-path parameter for CLI.
For hash comparison we write key-value pairs to the .json file.
{
    '<testName1><workerName1><etalonId1>': '3c3e0e1a3a1e1e2e',
    ...
    '<testNameN><workerNameN><etalonIdN>': 'ac3e0e1a3a1e1e2F'
}

Updating of etalons
As soon as the first screenshot will be different from etalon we run web application with GUI interface for managing etalons.
Service will run only if was passed --update-etalons to CLI or updateEtalons to the runOptions in programmatically API.
In this case we output in report only path to the difference file.
As alternative we can just output paths to the artifacts, etalons and difference files, but it does not look convenient.

I see the following ways for API simplification:

Automatically generate etalons on first run
It would be nice to have things out of the box regarding comparison tools? Reading this proposal I have no idea which one to choose.

Overall, can we reduce API to single method?

Let's not use the word etalon for base or baseline images. There is no such a word as etalon. It's even underlined by spell checkers.

@VasilyStrelyaev is there a development branch for this?

After discussion we decide to simplify layout testing the following way:
We look for an etalon automatically and user should just call t.checkLayout() method.
t.checkLayout() is searching for a screenshot for test in according to index of using in the test code body, starting with 0.
test('testName', async t => {
    await t
        .click('#el')
        .checkLayout() //looking for .../<testName>/<workerName>/1.png
        .type('.inputClass', 'value')
        .checkLayout() //looking for .../<testName>/<workerName>/2.png
        ......
        .click(...)
        .checkLayout() //looking for .../<testName>/<workerName>/<N>.png
});

If etalon isn't exists it should be created.
For test run, you can specify path to screenshots --screenshots and path to etalons --etalons
Path to etalons can be relative or absolute.
In screenshot directory we generate file with meta infotamation about screenshot comparison.
If test fails, we output path to this file to the report.
Afterward you can run testcafe etalon-manager <path-to-diff-file>. It will launch the application for management the screenshots and etalons and show differences in screenshots for failed tests.

is there a development branch for this?

@mjhea0 We haven't started to work on this feature yet.
Usually we work on any feature in own fork and make a pull request from there. In the upstream repository usually we don't create new branches.

Thoughts on getting this into the next release? Or at the very least https://github.com/DevExpress/testcafe/issues/1357?

We've planned to fix #1357 in this release iteration. We will be able to provide you with an alpha version as soon as the fix is ready

Rough example of how I'm doing the visual regression tests- https://github.com/mjhea0/testcafe-visual-regression

@mjhea0 Thanks for the link, it looks interesting

Any news on this since May? I'm evaluating TestCafe for a new project, and layout testing is a crucial deciding factor on TestCafe vs a Selenium based stack. I'm guessing I'm not alone.

Hi @ttiurani,
We haven't implemented this functionality yet but we keep this feature in mind and we've already made some spike solutions. Now we are planning our next releases so I can't provide you with estimates for this feature so far.

Hi all, I'm a bit curious if there was a decision made between "pixel perfect" and "perceptual hash" methods to implement this feature.  I've been looking at this interesting repository from Amex: https://github.com/americanexpress/jest-image-snapshot and it looks promising.

Just as an note on this: we actually ended up doing image testing against our Storybook and not on TestCafe and are very happy with our decision. We're using Storyshots image snapshots:
https://github.com/storybooks/storybook/tree/master/addons/storyshots#configure-storyshots-for-image-snapshots--alpha-
I would argue that for a lot of other cases visual testing the Storybook stories is the right thing to do, and then TestCafe is only used for integration testing.

@mdstaff, @ttiurani Thanks for the idea, we'll check this out.

Any news for this issue? I would like to use Testcafe but I need visual regression...

We also want to implement visual regression in our project and that would be great to be able to deal with dynamic content the similar way it is done in applitools
https://applitools.com/tutorials/selenium-javascript.html#part-5-use-advanced-ai-tools-to-work-with-real-world-scenarios
where you can ignore region
or webdriverio visual regression,
https://webdriver.io/blog/2019/05/18/visual-regression-for-v5.html
Where you can provide list of selectors to hide it before the test.
I assume, the latter one can be done easily. By setting for each of those elements display: none, or visibility: hidden.

@vladnauto thank you for your suggestions and shared resources. I think the ability to ignore some regions or elements on layout testing would be useful, e.g. if they are constantly changing. We'll consider the implementation of this functionality.

Any updates?

Hi @loggen
This feature has high priority for us. At present, we are preparing the feature's spike. We will post any news in this issue. Track it to be notified of our progress.

For what it's worth, I was able to get something to work with using the native takeElementScreenshot and the pixelmatch package. Most of the code is taken from the jest-image-snapshot package, but if you would like to take a look, it's available in one of my repositories. It is currently running in CI on Linux and Windows (not macOS due to a different issue).
If this looks promising and similar to what we want, I would be happy to start work on a branch.

@btkostner We are happy to hear that you found your own way of testing visual regression. Your approach doesn't seem to require a change in the TestCafe repository. I suppose you could represent your solution as your own separate package.

@miherlosev any update on this?  it was high priority, but what happened?

Our attempts to create a prototype revealed that this feature requires a lot more resources and time than we thought initially.  We will think about considering this feature for the next roadmap.

3d party solutions JFYI :
https://www.npmjs.com/package/devextreme-screenshot-comparer
https://github.com/tacoss/testcafe-blink-diff

@dmitrykurmanov can you confirm that devextreme-screenshot-comparer is a tool made by DevExpress ?
I cannot find the repo in https://github.com/orgs/DevExpress/repositories, Google doesn't return anything else than the npm package, and the package's readme/package.json do not mention a repo source.
Not sure where I should go if I have issues or questions regarding this package.

The repo is private and is intended for internal use only. No support is provided for it.

Hi @folks,
At present, we support NativeAutomation mode only for Chromium-based browsers. Later, we are going to support other browsers. That said, we do not expect to implement it in the near future.
You can use implementations shared by the community: testcafe-blink-diff (suitable for local comparison), @percy/testcafe(integration with https://percy.io/ image comparison infrastructure).
If these are not suitable, you can create your image comparison approach with the takeScreenshot action and one of the image comparison libraries: resemble, pixelmatch, blink-diff, etc.
Also, you can do it yourself and create a PR. We will be happy to review it.


ClassicAppPool Internal Server Error

In IIS7 on a ClassicAppPool, adding the mime handler to the web.config file causes an internal server error. Perhaps there should be a flag to skip that part of the authorization provided that the user creates the MIME handler via appcmd.
@%SystemRoot%\System32\inetsrv\appcmd set config -section:staticContent -+"[fileExtension='.', mimeType='text/plain']"

Added in pull #33.
Included web.config has been tested with stock IIS on Server 2012, Server 2012 R2, Server 2016, Win 7, and Win 8.1. If anyone needs to make changes to the web.config file, you can update the web_config.xml file in the root of the app.That is copied instead of using text hard coded in the app. So no more need to recompile to change the web.config.


(apis) Create endpoint: GET List Games endpoint (arnav and larry)

We would like to create an endpoint so that we can handle a request to get a list of all the games on the ChiGame site.

Added Game List view building off of the Django REST framework. Added a Game Serializer class to serializers.py file, as well as the corresponding URL (/api/games) and view (GameListView) in urls.py and views.py respectively

when trying to run the code on the apis/game-endpoints branch, I get the following error:
    app_module = import_module(app_name)
                 ^^^^^^^^^^^^^^^^^^^^^^^
  File<EMAIL_ADDRESS>line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1140, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'api'

@abrahmasandra are you able to actually run the server and open the endpoint with your current code?

I had accidentally forgotten to push the latest changes to Github (I had to add the url to the urls.py of the main project). Now, I pushed the latest code and it should be working now. The urls for the api are /api/games and /api/games/int:pk. I have tested locally and it is working.

GET Games working! Endpoint is /api/games and supports GET and POST requests to get a list of all the games and create new games

Closing statement: Implemented the Game List and Detail views of the Chigame API under the endpoints /api/games and api/games/<int:id> respectively
@abrahmasandra: created the endpoints

Issue Score: Excellent
Comments:
Great job! Thank you for nailing the combination of descriptive title, summary, updates, and closing comment.
Particularly appreciate you detailing what endpoint should be created as the goal.


Allow disabling textobject creation or make keybind configurable

Describe the bug
<a-i> gets unconditionally overwritten by the plugin.
To Reproduce
Steps to reproduce the behavior (include minimal init.vim or .vimrc):

Install vim-illuminate
Execute usual vai
Wonder why it is broken

Output from :IlluminateDebug
buf_should_illuminate 2 true
config {
  case_insensitive_regex = false,
  delay = 100,
  filetype_overrides = {},
  filetypes_allowlist = {},
  filetypes_denylist = { "dirbuf", "dirvish", "fugitive" },
  min_count_to_highlight = 1,
  modes_allowlist = {},
  modes_denylist = {},
  providers = { "lsp", "treesitter" },
  providers_regex_syntax_allowlist = {},
  providers_regex_syntax_denylist = {},
  under_cursor = false
}
started true
provider table: 0x728dfbb4efa8 lsp
`termguicolors` true

Expected behavior
Existing maps / textobjects are not overwritten.
Screenshots
N/A
Additional context
nVim v0.10.0, vim-illuminate https://github.com/RRethy/vim-illuminate/commit/5eeb7951fc630682c322e88a9bbdae5c224ff0aa

Closing due to a lack of minimal init.lua. From the issue template:

Note Omitting a minimal init.vim/init.lua/.vimrc will likely result in the issue being closed without explanation.

https://github.com/RRethy/vim-illuminate/blob/master/.github/ISSUE_TEMPLATE/bug_report.md?plain=1#L17C1-L17C125


UI: Show a global settings page for Admins to view/update the settings for different services such as ES, Airflow, Slack Event Publisher, etc.

Fixed with https://github.com/open-metadata/OpenMetadata/pull/6677


[Bug] Can't download file in client

Search before asking

[X] 我在 issues 列表中搜索，没有找到类似的内容。
I searched in the issues and found nothing similar.

Pake version
2.0.5
System version
13.4 (22F66)
Node.js version
v16.20.0
Minimal reproduce step
pake https://figma.com --name 'figma' --icon ~/Downloads/figma.icns --transparent

make a figma app, and draw some graph, then export it, no response

What did you expect to see?
like in web, will download this exported file.
What did you see instead?
no any response
Anything else?
no
Are you willing to submit a PR?

[ ] I'm willing to submit a PR!

I took a look at the special way of downloading exported files from Figma, but currently I tried and couldn't capture this event being passed out, so it's not easy to support.

看起啦 @jeasonnow 已经修复，我们最简发布一个版本


yq command line incompatible with yq4

How to reproduce
Install latest version of yq
> yq --version
yq version 4.7.0

Set ISO_SPEC: export ISO_SPEC=`pwd`/iso/cOS.yaml
Run this line from Makefile:
yq r -j $(ISO_SPEC) 'packages.[*]' | jq -r '.[]'

Expected output
No error
Actual output
> yq r -j $ISO_SPEC 'packages.[*]' | jq -r '.[]'
Error: unknown command "r" for "yq"
Run 'yq --help' for usage.

yq neither has an r command nor an -r option.

After downgrading to yq 3.4.1, the yq r call now works, but the yq -r one still doesn't make sense

After downgrading to yq 3.4.1, the yq r call now works, but the yq -r one still doesn't make sense

That seems to be a yq problem as the -r flag is undocumented.

Closing for now, the need for yq < 4 should be documented.

Oh, the second command is jq not yq :facepalm:


[BUG] Script Generation Includes Unwanted "Foundation Script:" Prefix and segments

When generating a script for a video, the output includes an unwanted prefix "Foundation Script:" and segment titles that sound too artificial in the video context.
Here's an example of the issue:
[Subject] Foundation Script:

**Segment 1: [First Topic]**
[Desired script content]

The "Foundation Script:" prefix appears before every script and it makes the output video sound weird. The segment titles, such as "Segment 1: [...]", make the video sound too artificial.
Expected output:
[Desired script content]
This issue occurs every time a script is generated. It's unclear whether this is a bug or a feature, but it's not the desired behavior for this use case.
I would like to contribute to this project by working on this issue. Please let me know if this is something that is supposed to be like this.

Either change the AI model or add context to the prompt directly.


fix solution directories

Fixes https://github.com/Microsoft/visualfsharp/issues/3122
I compared with FSharp.sln and simplified things.  Not sure what makes the difference, it might just be the addition of TABs.

(I merged before waiting for CI since VisualFSharp.sln isn't used by CI)

😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱 😱


⚠ Text Filter API Endpoint has degraded performance

In 6ca8f46, Text Filter API Endpoint (http://textfilter.roblox.com/) experienced degraded performance:

HTTP code: 200
Response time: 2044 ms

Resolved: Text Filter API Endpoint performance has improved in b6bf00d.


De-duplicate embedded specialist edition change history

https://trello.com/c/NbATcan2/956-de-duplicate-specialist-publisher-embedded-change-history.-(2)
This migration identifies editions with change history embedded in the details hash
which contain duplicate notes. Some of these may be legitimate entries so we clear
the  entry in the details hash and represent the edition downstream.
The presenter will regenerate this history correctly based on the ChangeNote records.
Migration took ~58 seconds on a dev VM

@kevindew updated, I had to make one small change to this. I'm happy it works now.


Why is this repository private?

I just noticed that this repository is private. Shouldn't it be publically accessible?
@taylor-bsg - What's going on?

Now public! @mithro


Make count officers dynamic

can we somehow update which officers are on patrol? I don't think it meets the criteria of it being dynamic at this point since we can't change that number in our UI.
Suggestion is to select choose which ones are day and which are night?

@Junkim97  do count of officer at night or morning

fixed


Packager fixes

Better error message fixes #880
Add issue link fixes #665
Fix pr labelling #896

Still to do: If issue # is given, copy all labels from the issue to the PR (such as "Small Fix", "Bug", etc)


Incorrect line numbering when reference-style links used in lists with items separated by blank lines

Problem
Minimal case:
* top

    * one[][foo]

[foo]: # "bar"

(Note: this example uses a link with empty text, but this issue also appears if text is present, i.e. [x][foo].)
Yields:
{[
   %EarmarkParser.Block.List{
     annotation: nil,
     attrs: nil,
     blocks: [
       %EarmarkParser.Block.ListItem{
         annotation: nil,
         attrs: nil,
         blocks: [
           %EarmarkParser.Block.Text{
             annotation: nil,
             attrs: nil,
             line: ["top"],
             lnb: 2
           },
           %EarmarkParser.Block.List{
             annotation: nil,
             attrs: nil,
             blocks: [
               %EarmarkParser.Block.ListItem{
                 annotation: nil,
                 attrs: nil,
                 blocks: [
                   %EarmarkParser.Block.Text{
                     annotation: nil,
                     attrs: nil,
                     line: ["one[][foo]"],
                     lnb: 4
                   }
                 ],
                 bullet: "*",
                 lnb: 4,
                 loose?: false,
                 spaced: false,
                 type: :ul
               }
             ],
             bullet: "*",
             lnb: 4,
             loose?: false,
             start: "",
             type: :ul
           }
         ],
         bullet: "*",
         lnb: 1,
         loose?: true,
         spaced: false,
         type: :ul
       }
     ],
     bullet: "*",
     lnb: 1,
     loose?: true,
     start: "",
     type: :ul
   },
   %EarmarkParser.Block.IdDef{
     annotation: nil,
     attrs: nil,
     id: "foo",
     lnb: 5,
     title: "bar",
     url: "#"
   }
 ],
 %EarmarkParser.Context{
   footnotes: %{},
   links: %{
     "foo" => %EarmarkParser.Block.IdDef{
       annotation: nil,
       attrs: nil,
       id: "foo",
       lnb: 5,
       title: "bar",
       url: "#"
     }
   },
   options: %EarmarkParser.Options{
     annotations: nil,
     breaks: false,
     code_class_prefix: nil,
     file: "<no file>",
     footnote_offset: 1,
     footnotes: false,
     gfm: true,
     gfm_tables: false,
     line: 4,
     mapper: &EarmarkParser.pmap/2,
     mapper_with_timeout: &EarmarkParser.pmap/3,
     messages: [],
     parse_inline: true,
     pedantic: false,
     pure_links: true,
     renderer: EarmarkParser.HtmlRenderer,
     smartypants: false,
     timeout: nil,
     wikilinks: false
   },
   rules: %{
     br: ~r/^ {2,}\n(?!\s*$)/,
     escape: ~r/^\\([\\`*\{}\[\]()\#+\-.!_>~|])/,
     footnote: ~r/\z\A/,
     strikethrough: ~r/^~~(?=\S)([\s\S]*?\S)~~/,
     text: ~r/^[\s\S]+?(?=[\\<!\[_*`~]|https?:\/\/| \{2,}\n|$)/,
     url: ~r/^(https?:\/\/[^\s<]+[^<.,:;\"\')\]\s])/
   },
   value: []
 }}

The line numbers (lnb) for the content are off by 1.
Apparent cause
(The problem seems to maybe come from https://github.com/RobertDober/earmark_parser/blob/d1cdeb1fbd3b7bdb2f1a9e69150174844856a7f8/lib/earmark_parser/parser/list_parser.ex#L58: it appears the line value should only be incremented during the parsing of the nested list?)
It seems this appears when all of the following are true:

nested list
sub-list uses a reference-style link (i.e. [][foo], [x][foo], etc.)
blank lines are used to separate some list items

The degree to which the line number count drifts is linked to the number of elements in the sub-list that are on that line or below.
Example:
* top

    * one[][foo]

    * two

[foo]: # "bar"

Here, lines "top" and "one" will be off by 2 (lnb at 3 instead of 1, and 5 instead of 3, respectively), while line "two" will be off by 1 (lnb at 6 instead of 5). That's because lines "top" and "one" still have 2 elements in the sub list that are on that line or below it, while line "two" has only one such element (itself).
Another example:
* top

    * zero

    * one[][foo]

    * two

    * three

[foo]: # "bar"

Here's how their line numbers drift:

top -> off by 4
zero -> off by 4
one -> off by 3
two -> off by 2
three -> off by 1

Finally, these 2 cases also present line number drift, but with a different amount:
* top

    * zero

    * one

    * two

    * three

[foo]: # "bar"

* top

    * zero

    * one[][foo]

    * two

    * three

It appears that having the reference-style link present increases the drift by 1.
Workaround
Not having spaces between list items:
* top
    * zero
    * one[][foo]
    * two
    * three

[foo]: # "bar"

Hope this was helpful!

Thank you for this thorrow ticket
This is probably taking a while  as lists are quite broken and I have no short term ETA of fixing them, sorry.

My pleasure @davidsulc I am always happy when I find the time to work on EarmarkParser :blush:


Optimizes JavaScript Bundle

Summary of Changes

Optimizes load of lodash
Adds moment-locales-webpack-plugin to prune included moment locales except 'en'
Adds BundleAnalyzerPlugin (commented) to analyze bundle sizes
Updates clean-webpack-plugin

Before:
After:

Tests
Ran tests, checked sizes with the bundle analyzer
CheckList
Make sure you have checked all steps below to ensure a timely review.

[x] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[x] PR includes a summary of changes, including screenshots of any UI changes.
[x] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[x] In case of new functionality, my PR adds documentation that describes how to use it.

All the public python functions and the classes in the PR contain docstrings that explain what it does

[x] PR passes all tests documented in the developer guide

Codecov Report

Merging #458 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #458   +/-   ##
=======================================
  Coverage   79.44%   79.44%
=======================================
  Files         216      216
  Lines        5337     5337
  Branches      691      691
=======================================
  Hits         4240     4240
  Misses       1040     1040
  Partials       57       57

Impacted Files
Coverage Δ

...undsen_application/static/js/ducks/search/sagas.ts
73.38% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baedcb1...b68a042. Read the comment docs.


fix(assets): update source evaluation for TF1 of m22

This PR updates the source evaluation for TF1 of m22, as requested by @chael-mi .

Output:


Publish plugins to s3://get.pulumi.com, too.

Part of https://github.com/pulumi/home/issues/845.
This PR updates the publish-plugin.sh script to copy built plugins to s3://get.pulumi.com
in addition to s3://rel.pulumi.com. This is so that we can migrate to serving plugins via
CDN on https://get.pulumi.com, instead of https://api.pulumi.com like we do today.
For more information about the overall effort, see this comment.
In addition, immediately before this code gets merged, I will also update the AWS access key
used for this repo on:

Travis CI: https://travis-ci.com/github/pulumi/pulumi-consul/settings
GitHub Actions: https://github.com/pulumi/pulumi-consul/settings/secrets (if applicable)

The access key will be for a different IAM User. This is part of https://github.com/pulumi/home/issues/708,
and managing Pulumi's internal AWS access using Pulumi (and migrating off hand-crafted IAM permissions we set up in 2017).

I'm assuming that this repository doesn't need to create AWS resources, so
I'll use an access key that only has permissions to upload resources and
publish plugins but nothing else. I'll discover if this is correct when
testing out the release path post-merge. (And can update Travis out of band.)

Next Steps
After this review gets the LGTM, the next steps are:

Update the AWS credentials on Travis, GitHub
Merge the PR. Wait for master to be green. Fix any problems associated with this PR.

Updated the AWS creds in Travis. There are no GHA secrets to update. Merging this.


interrupt falling edge

I am trying to use the RF522 library with the following card:
https://www.amazon.com/gp/product/B01KFM0XNG/ref=oh_aui_detailpage_o00_s00?ie=UTF8&psc=1
This card can be successfully used with the Python implementation:
https://github.com/pimylifeup/MFRC522-python.git
Note: This implementation does not rely on the 'interrupt' line.

I do not have an oscilloscope to analyze the actual behavior of the 'interrupt' line and
would very much appreciate any suggestion on how to potentially resolve this issue.
Thanks,
-jens

You should (if I remember that correctly) use BCM numbering there:
so GPIO23 should refer to BCM  13 - not 23
pls let me know if that helped. I suspect that you have the GPIO23 pin configured for the IN mode and it gives the random noise, that's why you have that infinite loop.

I tried the BCM numbering:
rfid, err := rf522.MakeRFID(0, 0, 1000000, 26, 13)
unfortunately without success.
I then tried Dave Cheney's 'watch.go' test program for 'falling edge':
go run watch.go
Now watching pin 22 on a falling edge.
Setting power high
Setting power low
Callback for 22 triggered!
Setting power high
Setting power low
Callback for 22 triggered!
and I use the following GPIO names:
func main() {
// set GPIO22 to input mode
pin, err := gpio.OpenPin(gpio.GPIO22, gpio.ModeInput) // physical pin 15
if err != nil {
fmt.Printf("Error opening pin! %s\n", err)
return
}
// set GPIO2 to output mode
power, err := gpio.OpenPin(gpio.GPIO2, gpio.ModeOutput) // physical pin 3
I now understand that Dave Cheney uses essentially 2 numbering schemes:
GPIO number scheme in: https://github.com/davecheney/gpio/blob/master/gpio_linux.go
BCM number scheme in: https://github.com/davecheney/gpio/blob/master/rpi/rpi.go
Is it possible to use the RF522 library without the 'interrupt' line?

I think yes, but unfortunately you are on your own here.

They use a different library for the interrupts, and I have ported the MFRC522 code for that framework.
Side note - I never tested this code with RPi 2 or 3, only Zero / ZeroW

@jdevelop thanks, will try it, but can't find any example of usage
https://github.com/google/periph/blob/HEAD/experimental/devices/mfrc522/mfrc522.go


helm: move poststart eni script to agent

We rely on host having certain binaries in nodeinit scripts. They are not always available, so we are moving the eni-specific poststart hook to agent pod so that we can ensure it always runs if needed.
Related: https://github.com/cilium/cilium/issues/19256
Move poststart eni script to agent pod from nodeinit pod

/test

/test

/test

/test

Hit https://github.com/cilium/cilium/issues/15455 , marking as ready to merge


Create humidity plot

Before testing, we need to include a plot of a humidity field.

No longer with new implementation of FOREST, so closing issue.


signature with other algorithms than HSxxx

Hey,
I try to use Guardian to sign a JWT with RSA plublic/private key.
I see that your implementation don't allow other signature algorithms than HMAC SHA-xxx (HSxxx). The problem comes from jose_jwk/1 that hardcode an jwk HSxxx.
I would like to offer the possibility to use any algorithm available with JOSE. Should I keep a backward compatibility? If so, have you any idea how to do this properly?
I will propose a pull request later in the day or next week but already does not hesitate to offer me your comments.

Sorry, I did not see the pull request #122 before making my issue.
So I will use this implementation ;)
Thanks @potatosalad


[BUG] JsonToStructs and ScanJson do not normalize numeric output when read as a string

Describe the bug
This is almost identical to https://github.com/NVIDIA/spark-rapids/issues/10218, but is for from_json and reading json lines formatted files.
Numbers like 1.00000 and -0 are not normalized to match what Apache Spark would do.

Another odd example of this is +INF and -INF.  Even if allowNonNumericNumbers is disabled +INF and -INF are valid floats and are normalized to "Infinity" and "-Infinity" respectively.

Technically in Spark 4.0 this was reverted (at least for scan by default)
https://issues.apache.org/jira/browse/SPARK-48148
https://github.com/apache/spark/pull/46408
This functionality was put under a config spark.sql.json.enableExactStringParsing with it on by default.
It appears to work for scan, but not for get_json_object. It also does not remove the white space any longer or normalize single quotes, which will make things a lot more interesting to try and make this work.


[move source lang] Added Liveness. Popped non-live references

Motivation

Added liveness analysis

Made some minor changes to keep more state in abs. int. framework

Used liveness data to pop/release dead references

Reference borrow checker allows releasing intermediate borrows, so liveness does not need to be transitive through references
Releases references that were live but now unused
Releases references that were assigned but now unused
Filters releases for already moved/cleared out values

Test Plan

Added tests
cargo test

Reference borrow checker allows releasing intermediate borrows, so liveness does not need to be transitive through references
Releases references that were live but now unused
Releases references that were assigned but now unused
Filters releases for already moved/cleared out values

Could you give examples of each of these transformations (and perhaps reify them as comments in the code that does them)? I'm having trouble distinguishing between liveness, assignment, and moves and when/why we need to distinguish them. I think examples would help.

Could you give examples of each of these transformations (and perhaps reify them as comments in the code that does them)? I'm having trouble distinguishing between liveness, assignment, and moves and when/why we need to distinguish them. I think examples would help.

I'll add a longer description with examples to the module, and copy that into the summary


0.4.14 broken on IE

Browser: IE11
OS: W10
Clappr Version: 0.4.14 (https://cdn.jsdelivr.net/npm/<EMAIL_ADDRESS>Steps to reproduce:

Go to http://clappr.io/demo/
play the video
Check the console. There's this error

This issue does not happen when I use 0.3.13<EMAIL_ADDRESS>

Hi @Bubblesphere! I don't have a Windows PC and remote work makes access to company devices more difficult. Can you help with this problem, guys? @jhonatangomes @leandromoreira @towerz

me neither :(

I think this error is due to IE 11 does not support Array.from. Line 8641 of clappr-core esm bundle is :
// ...
var textTracks = this.el.textTracks ? Array.from(this.el.textTracks) : [];
// ...

If i remember correctly, there is (was ?) a module loading polyfills to handle this issue.

I remembered wrong, there is no support for "Array.from" method in polyfills module.
Also i am curious why IE11 is using the esm.js file ? maybe something related to Rollup bundler ?
Also, IE11 will be officialy end of life next year.

Hi @Bubblesphere, as @kslimani said the IE11 will be discontinued by Microsoft soon. We don't think it's a valid effort to solve this issue and will close it. Feel free to send us a PR if you like :)
Offical Microsoft Report


(PUP-2868) Add information about section and environment to config

Without this change, it is confusing to users what section is used in the config when they don't specify a section for the config command.  With this change, a message is printed to stderr for all commands, and an extra warning is given to the print command if the user doesn't specify a section.

CLA signed by all contributors.

Hi @melissa, I could not reproduce the error you were seeing (my puppet repo did not even recognize ini_setting, maybe it is coming from some module or environment code?), although I found the text of your file in the repo in conf/puppet.conf so maybe it is a template that gets inserted/copied over.
I have updated and improved the tests a bit.

@kris-bosland inifile comes from https://forge.puppet.com/puppetlabs/inifile, you have to install that module (puppet module install)

The issue with the inifile module putting settings before the comment block existed prior to this change, so 👍


Iamolivinius remove grunt run task

Tweaks to the PR to run the typescript tests via grunt. Closes #613 by implementing it but adding a fix for our new typescript type check run script.
@thgreasi Can you make sure this is okay? The typescript tests don't output anything on my local machine so I can't tell if it's working right, but seems fine.

Changing the type of a test to make it fail didn't broke grunt test. So I guess that we are missing something for now :-/

Pushing a commit in a minute!

Cool, thanks! I don't know much about the TS stuff so appreciate the help 😄


Smartdown money question type

REQUIRES this smartdown money question PR 131 to have been merged on smartdown gem.
Adds support for new smartdown money question type.
Required for possible MOJ fee remission smartanswers - see smartdown issue #128

Adding some further tests. Not yet committed.

Have added further tests in the smartdown repository. Ready for merge now.

Smartdown 0.13.0 is available now, with Money question support

This pull request is ready to be merged now, as money question functionality is now in Smartdown 0.13.0.

I pushed a version of your branch (rebased against master) so it runs through our CI - all passes and looks good. :+1:

Also, thank you again for the contribution, this has been great


Pool "hangs"

I have an app. that's been working OK for months, but on the last 3 weeks I noticed that it was reaching a point where it just stopped sending emails. When restarting the app. mails started flowing again, but just for some hours. Eventually that same state was reached and no email was sent ever again.
While debugging I  discovered that maxConnections was being reached while having all connections unavailable, so at that point _processMessages was not able to create a new connection and returned without sending the email (return at line 120).
Even more, connections seem to remain unavailable forever, so the process never exits this state and no mail is sent ever again until restarting the process (each call to send ends up with _processMessages returning through line 120, without sending the email).
Our pool is created with the following configuration:
smtp = nodemailer.createTransport(nodemailesSmtpPool({
            host: ini.smtp.host
          , port: ini.smtp.port
          , auth: {
              user: ini.smtp.user
            , pass: ini.smtp.pass
            }
          , maxConnections: 20
          , maxMessages: 20
          , socketTimeout: 5*60*1000
          , connectionTimeout: 5*60*1000
          }));

We are using nodemailer 1.3.0 and nodemailer-smtp-pool 0.1.8

Thanks, it sounds fishy and I'll look into it

Similar issue was resolved with 3e7a431e9f2e015c01f1ca0b01230c5a972377c7 (v1.1.2)


Test case handling of empty slice returns

Maybe this is me being a Go newbie.
func something(.....) (result []type, err error) {
    if (predicate) {
        return
    }
}

Lots of ellided things in that. My point is we have a function which has an early exit and so nothing is ever done to result. It is still an empty slice. An issue on empty v. nil slices has a conversation about what is happening.
As far as Go is concerned a nil slice and an empty slice function the same. This playground documents this. However in many if not all of the tests in this series the test fails on nil slices. This leads to really confusing error messages:
expected [], actual []

Yuck!!
Could reflect.DeepEqual be wrapped in something that either a) complains about nil or b) handles them better? Help the newbies out :-)

You're right that is a confusing error message. I think though we could handle it with different formatting, using %#v rather than %v: https://play.golang.org/p/U8XPCbm9Zz
There was a similar issue previously: https://github.com/exercism/go/issues/414
Can you specify which exercises you've experienced this with and we can fix them so the output is friendlier.

Pretty much every exercise where you are expected to return a slice. I would often write code like this:
func something(input string) (result []type, err error) {
    if input == "" {
        return
    }

    value := compute(......)
    result = append(result, value)
    return
}

Which is 100% correct but would fail the tests. So I would have to update my early returns to be []type{}, nil. Which works but gets annoying.
I bumped into this most recently on the change exercise. 0 change, empty list. Bzzzt!

So I would have to update my early returns to be []type{}, nil. Which works but gets annoying.

I'm not sure I understand why you would have to do this?
I believe naked returns are not recommended as idiomatic Go.
func something(input string) ([]type, error) {
    var result []type
    if input == "" {
        return result, error
    }

    value := compute(......)
    result, err = append(result, value)
    return result, error
}

Though this returns the same nil slice that you describe as failing the tests. To return an empty slice you would create the result var as so result := []type{} instead.
I'm not sure I fully understand the issue with the code above. Otherwise I think this can be fixed with better formatting.

Right. There is no reason that here https://github.com/exercism/go/blob/master/exercises/prime-factors/example.go#L6 the programmer needs to explicitly empty the slice. It starts off empty. Those {} exist solely to appease the unit tests.

I understand. I wonder if this https://github.com/exercism/go/blob/master/exercises/prime-factors/prime_factors_test.go#L16 should be nil rather than []int64{}. I haven't thought on this much, so the answer may be obvious.

This is code from the bytes packages:
// TrimLeftFunc returns a subslice of s by slicing off all leading UTF-8-encoded
// Unicode code points c that satisfy f(c).
func TrimLeftFunc(s []byte, f func(r rune) bool) []byte {
    i := indexFunc(s, f, false)
    if i == -1 {
            return nil
    }
    return s[i:]
}

Right. There is no reason that here /exercises/prime-factors/example.go@master#L6 the programmer needs to explicitly empty the slice. It starts off empty. Those {} exist solely to appease the unit tests.

I think it's reasonable for the unit tests to expect an empty slice rather than a nil slice, this goes for the change exercise also. And in other circumstances it may be better to expect a nil slice. In each circumstance we have to write the code that passes the unit tests. I don't think we should be changing unit tests because it can be annoying to write the code needed to make them pass.
If there are particular test cases that expect an empty slice where a nil slice is more appropriate we can look at changing those.
I believe the formatting of test cases that expect an empty slice or a nil slice can be improved if needs be to make the distinction between an empty slice and a nil slice more apparent. Here we can use either %q or %#v instead of %v. I think we should have caught all these by now. :crossed_fingers:

Unless you think there's more to cover here @shaleh I believe this can be closed.

Ack
On October 16, 2017 2:29:01 AM PDT, Rob Phoenix<EMAIL_ADDRESS>wrote:

Unless you think there's more to cover here @shaleh I believe this can
be closed.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/exercism/go/issues/866#issuecomment-336831753

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.


[Property wrappers] Fix source compatibility issue with attribute lookup

Swift 5.1's lookup for custom attributes skipped associated type
members, which allowed code like the given example to compile. To
maintain source compatibility, identify the narrow case that happens
in practice---the property wrapper is at module scope but is now
shadowed by an associated type---warn about it, and accept it.
Fixes rdar://problem/56213175.

@swift-ci please smoke test and merge

@swift-ci please smoke test macOS


AndroidSigning - zipalign should be default to false

Required Information
Question, Bug, or Feature?
Type: Improvement
Enter Task Name: AndroidSigning
Environment

Server - Azure Pipelines
Agent - Hosted (macOS-latest)

Issue Description
Since the version 4.1 of the Android Gradle Plugin the apk are already aligned so it would be best to either document the task for it, or to switch default value from true to false on the zipalign parameter of the AndroidSigning pipeline task.
see: https://issuetracker.google.com/issues/162117652

bump. not stale :)


Unable to get working with Next.js App Router on Netlify

Describe the bug
When using pino-sentry-transport with Next.js (14.x) it works in development mode, but when I deploy it to Netlify I get an error that says it's unable to determine transport target for "pino-sentry-transport".
Aug 7, 09:49:49 PM: a8a9ff79 ERROR   ⨯ Error: unable to determine transport target for "pino-sentry-transport"
    at fixTarget (/var/task/node_modules/pino/lib/transport.js:159:13)
    at /var/task/node_modules/pino/lib/transport.js:97:17
    at Array.map (<anonymous>)
    at transport (/var/task/node_modules/pino/lib/transport.js:94:59)
    at normalizeArgs (/var/task/node_modules/pino/lib/tools.js:316:16)
    at pino (/var/task/node_modules/pino/pino.js:90:28)
    at 40200 (/var/task/.next/server/chunks/739.js:1242:120)
    at t (/var/task/.next/server/webpack-runtime.js:1:143)
    at 32395 (/var/task/.next/server/chunks/142.js:792:2462)
    at t (/var/task/.next/server/webpack-runtime.js:1:143)

I realize this may not be a bug and it may be just that I'm mis-understanding how to get it working. Here's how I have it setup.
// logger.ts
import pino from 'pino';

// These are pulled from process.env.
import {nodeEnvironment, sentryDsn, sentryEnvironment} from '@/env';

const logger = pino(
    {
        level: 'info',
        transport: {
          targets: [
            {
              target: 'pino-sentry-transport',
              options: {
                sentry: {
                  dsn: sentryDsn,
                  environment: sentryEnvironment,
                },
                withLogRecord: true,
                tags: ['id'],
                context: ['hostname'],
                minLevel: 40,
                expectPinoConfig: true,
              },
            },
          ],
        },
      },
);

export default logger;

// next.config.mjs
/** @type {import('next').NextConfig} */

const nextConfig = {
  webpack: (config) => {
    config.externals.push('pino-sentry-transport');
    return config;
  },
  experimental: {
    serverComponentsExternalPackages: ['pino', 'pino-pretty', 'pino-sentry-transport'],
  },
};

export default nextConfig;

What am I missing?

@dmorda  is this issue still relevant?

No, you can close it.


Copying text in IE adds extra new lines

Howdy,
There seems to be a bug with copying out of draft in IE. We are using Draft 0.7.0.
Reproduction Steps:

Got to https://facebook.github.io/draft-js/
Type some text, a new line, then some more text,
Copy the text,
Paste the text somewhere like notepad

Expected Results:
The same number of lines in the draft editor appear in the pasted text.
Actual results:
There are extra lines e.g.
"This is[new_line]some text"
becomes
"This is[new_line][new_line]some text[new_line][new_line][new_line]"

same problem~

@hellendag


Fix https://github.com/nspcc-dev/gh-push-to-neofs/issues/12

Tests result:
https://github.com/vvarg229/gh-push-to-neofs/actions/runs/6851498197/job/18627889585

push-to-neofs.py: error: argument --lifetime: invalid int value: ''


Week 2 Review Ticket

Theme changing
Time Box
Playing around with loops, lists, and dictionaries (same as template)
My own dictionary
Quiz that stores in a list of dictionaries

Graded By: Shreya Sapkal
Grade: 2.7+/2.7
Reasoning: Jiya used dictionaries to make a creative quiz, and was successfully able to obtain darkmode on her blog. She also helped me get darkmode on my own blog when I faced an issue with it. She also has a nice time box with multiple links and summaries of what we learned for each week. Jiya customized her tags by week so that she could organize the work she did in each week. I think the successfully met all the learning objectives for this week.


Update bursty_traffic_test.go

Leaf-ref and interface-ref validation added for cisco

Pull Request Functional Test Report for #1794 / db0123c698f427c6c332462a1e3cc6e6a7785b77
No tests identified for validation.
Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 47.655%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1341

Relevant Lines:
2814

💛  - Coveralls


cargo-tarpaulin: 0.15.0 -> 0.16.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/xd009642/tarpaulin/releases.
meta.description for cargo-tarpaulin is: "A code coverage tool for Rust projects"
meta.homepage for cargo-tarpaulin is: "https://github.com/xd009642/tarpaulin"
meta.changelog for cargo-tarpaulin is: ""
Updates performed

Rust version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.16.0 with grep in /nix/store/v6i7j4ff8jv2lxfp4pcwll3j3kymwymf-cargo-tarpaulin-0.16.0

directory tree listing: https://gist.github.com/78e1c5e0e9a6e6d22cdaf796abfdfd50

du listing: https://gist.github.com/301b886d6b3460b22644f45931dd5d5f

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
cargo-tarpaulin

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/v6i7j4ff8jv2lxfp4pcwll3j3kymwymf-cargo-tarpaulin-0.16.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A cargo-tarpaulin https://github.com/r-ryantm/nixpkgs/archive/b898e8c8bdfd2e1dd9e993b0a63ee914a5c8b36f.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/v6i7j4ff8jv2lxfp4pcwll3j3kymwymf-cargo-tarpaulin-0.16.0
ls -la /nix/store/v6i7j4ff8jv2lxfp4pcwll3j3kymwymf-cargo-tarpaulin-0.16.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

1 package built:

cargo-tarpaulin

Maintainer pings
cc @hugoreeves for testing.

superseded by https://github.com/NixOS/nixpkgs/pull/103372


Problem

Hello, i tried to install the ggOs, i clicked sistem thing and when i tried installing it, it does blue screen and when i try to go in recovery mode it says that i file is missing and the file is windows\system32\boot\winload.efi. please help.

Sorry for that, but GGOS is only a OS course project and it cannot run on any physical machines.
Please check that your file system still exists and is in good health, and try to repair windows boot files and EFI partition. You may need some disk utils and tools like dism++.
This problem is not related to this project, so I'm going to close the issue.


Add OCR-D tech call slides

https://gist.github.com/mikegerber/3a152875a05bae2494898fabc2bbf7e9
These would be great as documentation/intro.

PDF: https://qurator-data.de/~mike.gerber/2024-08-ocrd-techcall-pyproject-toml-setuptools-ocrd-ci-publishing/OCR-D - Python packages - pyproject.toml + versioning + publishing.pdf


Add a missing dot to a sentence

I'd rather have a : if anything, not really important though, it's just a subtitle.

Actually I think I just like it how it is, thanks for trying to help, though :smile:

Haha :P! No problem mate :P


cmd ref: mention that cache options could be used additionally to remote modify params

At least type can be specified and is taken into account for dvc remote modify command SSH remotes. More details here: https://github.com/iterative/dvc/issues/2704
UPDATE: See more details in https://github.com/iterative/dvc.org/issues/764#issuecomment-548979449 below.

iterative/dvc#2704 is a little confusing. Would be great if this issue was self-contained with a summery of what and why to improve the remote modify cmd ref.

@jorgeorpinel we have a list of options that are applicable for different remotes provided via expandable sections here (btw, name should be changes to Available Options).
In case of remote data management, when you that remote as a remote cache, specifically for SSH you can specify some options that are not mentioned in that list:
dvc remote add sshcache ssh://user@example.com:/cache
dvc config cache.ssh sshcache
dvc remote modify sshcache type symlinks,reflinks,copy

type in this case is similar to the regular cache config type we have. Not sure about reflinks though, @mroutis and @efiop could clarify that.
I can imagine that protected should make sense in this case as well. Not sure about slow_link_warning.

@shcheklein , reflinks are supported :)

@shcheklein , protect make sense but is not enable, I was talking about it on https://github.com/iterative/dvc/issues/2542 could you take a look?

Hi. Per this support case we should probably document all the cache link types that are supported per remote location, and explain how caching works for external outputs.

Also added a checkbox about this in epic #520

Since external caching is no longer supported, closing this one


Added main in package.json

Since this is an angular module, what's the benefit of adding the main property to package.json?
https://docs.npmjs.com/files/package.json#main
This only seems useful if this were a node module as the main property identifies where the exported object is defined. The source you identified does not do that.


Title does not show on feed

Hello,
Thanks for adding a feed feature. However, the title does not show when adding it with Inoreader.

Thanks!

Thanks for this, fixed it. Make sure you edit your site title.


Climate entity gone?

Today I downloaded and installed the latest version, after running into this issue.
Good news: not only did the entities come back, I know have some very useful info such as the present heating curve.
Bad news: the climate entity is gone. Anyone else has this issue?

Hallo, same here, as from v0.7.4 climate enity are not available anymore (ecoTEC exclusive, VR920 with multimatic VRC700)

Please create a bug report, I can't help you without more details.

Bug report created with the logs. Thanks!


chore(demo): demo update

Issue
#250

Coverage increased (+0.1%) to 93.828% when pulling b2a1efe8b73ba85541f5de99242432f5c4ba505c on jongmoon:3.2.0-rc into 80b52b5ce1fbe7c20a78b82ea9633ca8c6c1dd5b on naver:3.2.0-rc.


Arrow navigation elements on Redux docs pages are highly annoying

At http://redux.js.org/ the .navigation elements on the sides of each document page make it very annoying to use the docs on desktop.

It is too easy to click these elements accidentally when making browser window active or when removing selection from text, because they take the entire height of the viewport.
There is no clear visual indication on hover of the existance of these buttons.
They appear to break the back button partially, because going back to previous page does not restore the scroll position; instead I find myself on top of the page again, losing the context I was in.

This issue has now happened to me five times today within an hour. I don't see any benefit of having these buttons on desktop, they seem like a nice mobile feature, but when using Redux docs you're much more likely to be a non-mobile user.
Also posted at GitBook's issues but based on quick read they seem to be lazy in addressing usability issues.

We use the default template for GitBook. This is an issue with that template, so I'm closing this out here.
BTW, this is the best place to post an issue: https://github.com/GitbookIO/theme-default