New services for Out Of Hours Pages

hi @ldodds this is still WIP and hasn't deviated too far from out discussion - but would be good to get an early review on this if you get a chance on Monday?  (class naming (DayTypeBreakdown & Store) and if we should re-use CombinedUsageMetric - with the addition of percent - in place of Store)

===========================================================AlertOutOfHoursElectricityUsage============================================================
{
                                                            "AlertOutOfHoursElectricityUsage:breakdown_chart" => :alert_daytype_breakdown_electricity,
                                               "AlertOutOfHoursElectricityUsage:group_by_week_day_type_chart" => :alert_group_by_week_electricity,
                                                                       "AlertOutOfHoursElectricityUsage:fuel" => "electricity",
                                                           "AlertOutOfHoursElectricityUsage:fuel_description" => "electricity",
                                                                  "AlertOutOfHoursElectricityUsage:fuel_cost" => 0.15203393721501832,
                                                          "AlertOutOfHoursElectricityUsage:fuel_cost_current" => 0.15203393721501832,
                                                             "AlertOutOfHoursElectricityUsage:total_annual_£" => 71060.41900000001,
                                                           "AlertOutOfHoursElectricityUsage:total_annual_co2" => 88492.6392,
                                                         "AlertOutOfHoursElectricityUsage:schoolday_open_kwh" =><PHONE_NUMBER>333333,
                                                       "AlertOutOfHoursElectricityUsage:schoolday_closed_kwh" =><PHONE_NUMBER>666666,
                                                               "AlertOutOfHoursElectricityUsage:holidays_kwh" => 71847.09999999999,
                                                               "AlertOutOfHoursElectricityUsage:weekends_kwh" => 42095.39999999999,
                                                              "AlertOutOfHoursElectricityUsage:community_kwh" => 0.0,
                                                           "AlertOutOfHoursElectricityUsage:total_annual_kwh" =><PHONE_NUMBER>999999,
                                                           "AlertOutOfHoursElectricityUsage:out_of_hours_kwh" =><PHONE_NUMBER>666666,
                                                     "AlertOutOfHoursElectricityUsage:schoolday_open_percent" => 0.36813911501052066,
                                                   "AlertOutOfHoursElectricityUsage:schoolday_closed_percent" => 0.3880806324254996,
                                                           "AlertOutOfHoursElectricityUsage:holidays_percent" => 0.15371704310498283,
                                                           "AlertOutOfHoursElectricityUsage:weekends_percent" => 0.09006320945899686,
                                                          "AlertOutOfHoursElectricityUsage:community_percent" => 0.0,
                                                       "AlertOutOfHoursElectricityUsage:out_of_hours_percent" => 0.6318608849894793,
                                                           "AlertOutOfHoursElectricityUsage:schoolday_open_£" => 26756.202000000005,
                                                         "AlertOutOfHoursElectricityUsage:schoolday_closed_£" => 27184.38200000001,
                                                                 "AlertOutOfHoursElectricityUsage:holidays_£" => 10813.954999999998,
                                                                 "AlertOutOfHoursElectricityUsage:weekends_£" => 6305.880000000001,
                                                                "AlertOutOfHoursElectricityUsage:community_£" => 0.0,
                                                             "AlertOutOfHoursElectricityUsage:out_of_hours_£" => 44304.217000000004,
                                                    "AlertOutOfHoursElectricityUsage:schoolday_open_£current" => 26756.202000000005,
                                                  "AlertOutOfHoursElectricityUsage:schoolday_closed_£current" => 27184.38200000001,
                                                          "AlertOutOfHoursElectricityUsage:holidays_£current" => 10813.954999999998,
                                                          "AlertOutOfHoursElectricityUsage:weekends_£current" => 6305.880000000001,
                                                         "AlertOutOfHoursElectricityUsage:community_£current" => 0.0,
                                                      "AlertOutOfHoursElectricityUsage:out_of_hours_£current" => 44304.217000000004,
                                                         "AlertOutOfHoursElectricityUsage:schoolday_open_co2" => 33246.97816666668,
                                                       "AlertOutOfHoursElectricityUsage:schoolday_closed_co2" => 35745.40483333333,
                                                               "AlertOutOfHoursElectricityUsage:holidays_co2" => 12476.783800000008,
                                                               "AlertOutOfHoursElectricityUsage:weekends_co2" => 7023.472399999997,
                                                              "AlertOutOfHoursElectricityUsage:community_co2" => 0.0,
                                                           "AlertOutOfHoursElectricityUsage:out_of_hours_co2" => 55245.66103333332,
                                              "AlertOutOfHoursElectricityUsage:good_out_of_hours_use_percent" => 0.35,
                                                            "AlertOutOfHoursElectricityUsage:average_percent" => 0.5,
                                               "AlertOutOfHoursElectricityUsage:bad_out_of_hours_use_percent" => 0.65,
                                               "AlertOutOfHoursElectricityUsage:significant_out_of_hours_use" => true,
                                            "AlertOutOfHoursElectricityUsage:percent_improvement_to_exemplar" => 0.28186088498947937,
                                                       "AlertOutOfHoursElectricityUsage:potential_saving_kwh" =><PHONE_NUMBER>6666666,
                                                         "AlertOutOfHoursElectricityUsage:potential_saving_£" => 20029.152587063218,
                                                       "AlertOutOfHoursElectricityUsage:potential_saving_co2" => 24939.046283943266,
                                                                    "AlertOutOfHoursElectricityUsage:summary" => "£44,000pa (63% of annual cost) ",
                                      "AlertOutOfHoursElectricityUsage:tariff_has_changed_during_period_text" => "",
                                                                  "AlertOutOfHoursElectricityUsage:relevance" => :relevant,
                                                              "AlertOutOfHoursElectricityUsage:analysis_date" => #<Date: 2021-12-31 ((2459580j,0s,0n),+0s,2299161j)>,
                                                                     "AlertOutOfHoursElectricityUsage:status" => :bad,
                                                                     "AlertOutOfHoursElectricityUsage:rating" => 0.6,
                                                                       "AlertOutOfHoursElectricityUsage:term" => :longterm,
                                                               "AlertOutOfHoursElectricityUsage:bookmark_url" => "https://blog.energysparks.uk/alerts#ElectricityOutOfHours",
                                                               "AlertOutOfHoursElectricityUsage:max_asofdate" => #<Date: 2022-07-13 ((2459774j,0s,0n),+0s,2299161j)>,
                                                                     "AlertOutOfHoursElectricityUsage:pupils" => 961,
                                                                 "AlertOutOfHoursElectricityUsage:floor_area" => 5932.0,
                                                                "AlertOutOfHoursElectricityUsage:school_type" => :secondary,
                                                                "AlertOutOfHoursElectricityUsage:school_name" => "Acme Academy",
                                                     "AlertOutOfHoursElectricityUsage:school_activation_date" => nil,
                                                       "AlertOutOfHoursElectricityUsage:school_creation_date" => #<Date: 2020-10-08 ((2459131j,0s,0n),+0s,2299161j)>,
                                                                        "AlertOutOfHoursElectricityUsage:urn" => 136770,
                                                          "AlertOutOfHoursElectricityUsage:one_year_saving_£" => 20029.152587063218..20029.152587063218,
                                                      "AlertOutOfHoursElectricityUsage:one_year_saving_£_low" => 20029.152587063218,
                                                     "AlertOutOfHoursElectricityUsage:one_year_saving_£_high" => 20029.152587063218,
                                                        "AlertOutOfHoursElectricityUsage:one_year_saving_co2" => 24939.046283943266,
                                                        "AlertOutOfHoursElectricityUsage:ten_year_saving_co2" =><PHONE_NUMBER>3943264,
                                                  "AlertOutOfHoursElectricityUsage:average_one_year_saving_£" => 20029.152587063218,
                                                  "AlertOutOfHoursElectricityUsage:average_ten_year_saving_£" =><PHONE_NUMBER>7063218,
                                                          "AlertOutOfHoursElectricityUsage:ten_year_saving_£" =><PHONE_NUMBER>7063218..200291.52587063218,
                                                      "AlertOutOfHoursElectricityUsage:ten_year_saving_£_low" =><PHONE_NUMBER>7063218,
                                                     "AlertOutOfHoursElectricityUsage:ten_year_saving_£_high" =><PHONE_NUMBER>7063218,
                                                              "AlertOutOfHoursElectricityUsage:payback_years" => nil,
                                                      "AlertOutOfHoursElectricityUsage:average_payback_years" => 0.0,
                                                               "AlertOutOfHoursElectricityUsage:capital_cost" => nil,
                                                       "AlertOutOfHoursElectricityUsage:average_capital_cost" => 0.0,
                                                                  "AlertOutOfHoursElectricityUsage:timescale" => "last year",
                                                     "AlertOutOfHoursElectricityUsage:time_of_year_relevance" => 5.0,
                                "AlertOutOfHoursElectricityUsage:AlertOutOfHoursElectricityUsage:Holiday:kWh" => 71847.09999999999,
                                  "AlertOutOfHoursElectricityUsage:AlertOutOfHoursElectricityUsage:Holiday:£" => 10813.954999999998,
                             "AlertOutOfHoursElectricityUsage:AlertOutOfHoursElectricityUsage:Holiday:CO2 kg" => 12476.783800000008,
                            "AlertOutOfHoursElectricityUsage:AlertOutOfHoursElectricityUsage:Holiday:Percent" => 0.15371704310498283,
                                "AlertOutOfHoursElectricityUsage:AlertOutOfHoursElectricityUsage:Weekend:kWh" => 42095.39999999999,
                                  "AlertOutOfHoursElectricityUsage:AlertOutOfHoursElectricityUsage:Weekend:£" => 6305.880000000001,
                             "AlertOutOfHoursElectricityUsage:AlertOutOfHoursElectricityUsage:Weekend:CO2 kg" => 7023.472399999997,
                            "AlertOutOfHoursElectricityUsage:AlertOutOfHoursElectricityUsage:Weekend:Percent" => 0.09006320945899686,
                        "AlertOutOfHoursElectricityUsage:AlertOutOfHoursElectricityUsage:School Day Open:kWh" =><PHONE_NUMBER>333333,
                          "AlertOutOfHoursElectricityUsage:AlertOutOfHoursElectricityUsage:School Day Open:£" => 26756.202000000005,
                     "AlertOutOfHoursElectricityUsage:AlertOutOfHoursElectricityUsage:School Day Open:CO2 kg" => 33246.97816666668,
                    "AlertOutOfHoursElectricityUsage:AlertOutOfHoursElectricityUsage:School Day Open:Percent" => 0.36813911501052066,
                      "AlertOutOfHoursElectricityUsage:AlertOutOfHoursElectricityUsage:School Day Closed:kWh" =><PHONE_NUMBER>666666,
                        "AlertOutOfHoursElectricityUsage:AlertOutOfHoursElectricityUsage:School Day Closed:£" => 27184.38200000001,
                   "AlertOutOfHoursElectricityUsage:AlertOutOfHoursElectricityUsage:School Day Closed:CO2 kg" => 35745.40483333333,
                  "AlertOutOfHoursElectricityUsage:AlertOutOfHoursElectricityUsage:School Day Closed:Percent" => 0.3880806324254996,
              "AlertOutOfHoursElectricityUsage:AlertOutOfHoursElectricityUsage:Holiday:£ (at current tariff)" => 10813.954999999998,
              "AlertOutOfHoursElectricityUsage:AlertOutOfHoursElectricityUsage:Weekend:£ (at current tariff)" => 6305.880000000001,
      "AlertOutOfHoursElectricityUsage:AlertOutOfHoursElectricityUsage:School Day Open:£ (at current tariff)" => 26756.202000000005,
    "AlertOutOfHoursElectricityUsage:AlertOutOfHoursElectricityUsage:School Day Closed:£ (at current tariff)" => 27184.38200000001


Material Login Buttons

Create account-ui login buttons in material design, based on angular-material.
My initial issue is how to get the angular-material package to be included in meteor.
@Urigo  can you suggest the best method?
The following repository has material login partials that we might want to use:
https://github.com/Tallyb/df-material
The relevant partials are under src/components/auth/partials
@Urigo do you have the material socially repo that you have showed in the last meetup?

@Tallyb there is already a meteor-angular-material package:
https://github.com/planet-training/meteor-angular-material/
as for Login Buttons, I think this should be a community effort.
I would of course love to help but I don't think it should be an open issue....

even though you just need to write regular angular-material after adding this package, here is an example to use:
https://github.com/madvas/meteor-angular-material-todomvc

Great news. This is brand new. I was looking to one couple of weeks ago. (so new - the readme does not even contain the package add...)


pretrained model

Hi, thanks for your great work, can you share your trained model?

You can use this: https://drive.google.com/open?id=138rFzYcsO27do84jiVNwUk5RkGJnna-Z VAE and GAN checkpoints.

@rosinality  wow, thanks so much!


Version tag is wrong in the new production environment

The tag in the ci.centos.org build is:
Jenkins-devtools-appdev-documentation-generator-build-master-9

Should be:
2017-07-31

Closing, the issue is tracked in #470.


📚[DOC]: Add example with diagnostic model

How would you describe the priority of this documentation request
Critical (currently preventing usage)
Is this for new documentation, or an update to existing docs?
New
Describe the incorrect/future/missing documentation
Add an example demonstrating how to use diagnostic model
### Tasks

would be great to show climatenet output in the docs.


[feature] Appkit (Specifically social logins) functionality in PWA / standalone mode on iOS

What problem does this new feature solve?
When using AppKit's social authentication (Google/Apple/X) in PWA/standalone mode on iOS, the auth popup results in about:blank or fails to complete the OAuth flow. This occurs specifically when the app is installed as a PWA and launched from the home screen.
Describe the solution you'd like

Open auth successfully
Complete OAuth flow
Return to PWA with authenticated session

See this link with the documentation:
https://docs.reown.com/cloud/verify

See this link with the documentation: https://docs.reown.com/cloud/verify

I verified the domain but the issue still persists

Do you have a link where we can reproduce?


support data suggestion: DOM event constructors ?

I was hoping to fire an event manually when I read about DOM event constructors.
This table shows a list for support on all browsers however its of 2013.
Can we have this on the site?

I think this is a duplicate of #2833


Fixed channels HTTP API endpoint

Fixes #149
Currently, we can only get presence channels, because there is a filter in code:
https://github.com/beyondcode/laravel-websockets/blob/1c2b89b54d8d9d1c796b8391e41207da2a2f2423/src/HttpApi/Controllers/FetchChannelsController.php#L14-L16
But according to Pusher API documentation, there is no limitations needed, and presence channels should be filtered using filter_by_prefix=presence-:
https://pusher.com/docs/rest_api#method-get-channels
In this pull request, I implemented correct behavior for this endpoint:

List with all channels now returned
Attribute user_count must be requested via info query param
Error code 400 will be returned if user_count is requested, and the request is not limited to presence channels

Looks like the pusher docs URLs have changed. The new URL is https://pusher.com/docs/channels/library_auth_reference/rest-api#get-channels-fetch-info-for-multiple-channels-

Thank you!


PEAR-1203: Include timestamp for file manifests

Description
Checklist

[X] Added proper unit tests
[N/A] Left proper TODO messages for any remaining tasks
[N/A] Scanned for web accessibility with aXe, and mitigated or documented
flagged issues

Screenshots/Screen Recordings (if Appropriate)

looks good! I tested the manifest downloads and spot checked other downloads. 👍


Unable to update to b.20

For some reason my b.19 says that it's the newest version when b.20 has obviously been out for a few days.
Am I missing something? Is this a manual update or just not meant for Win7 users?

Yeah that's just it, I have beta updates enabled.
Did you mean that a subset of those who have betas enabled? I can understand if that's the case, just wanted to know for sure. :)

It's just 10% of users with beta enabled :)

Understood! Thank you. :)


Missing comments

Action suggest many changes, but no comments
I reckon i am missing some sort of setting in my YAML file?
name:  Reviewdog
on: workflow_dispatch
jobs:
  biome:
    name: Linter 🧹
    runs-on: ubuntu-latest
    permissions:
      contents: read
      pull-requests: write
    steps:
      - name: Check out code.
        uses: actions/checkout@v4
      - name: lint
        uses<EMAIL_ADDRESS>        with:
          github_token: ${{ secrets.GITHUB_TOKEN }}
          reporter: github-pr-review

This is what i am trying to achieve:

But this is what it currently looks like on my end

Thanks for the question.
Your settings are correct.
If you are using github-pr-review at reporter, the behavior is to suggest the result of the modification using biome apply, so it will not comment!
If you really want to comment, you can set up github-pr-check as a reporter. However, this is not recommended because it will not provide commit suggestions.
I would like to see if there are any other similar opinions or reactions to this Issue and make a decision.

So my first reaction to trying out github-pr-review and not seeing any explanation for the suggestion was similar to @arienshibani, and I came here looking to see if something was configured wrong.
I'm also linting Ruby code alongside JS, and the Rubocop action provides details on the failed rule along with the commit suggestion:

Feels to me like this Biome action should provide the same kind of information.

@brendonrapp
Thank you for your feedback.
When using commit suggestions with reviewdog, we need to provide either rdformat or diff.
https://github.com/reviewdog/reviewdog?tab=readme-ov-file#code-suggestions
Currently, I'm using diff, but I believe converting to rdformat would be best.
RuboCop also appears to use the same approach:
https://github.com/reviewdog/action-rubocop/blob/master/script.sh#L126-L127
At this time, Biome doesn't have a feature to output in a user-defined format:
https://biomejs.dev/ja/reference/reporters/
Therefore, I’ve created a discussion about enabling custom output formats:
https://github.com/biomejs/biome/discussions/4775
If I have some free time during the winter holidays, I plan to experiment and see if comments can still be generated when using diff.


GitHub code blocks are rendered incorrectly

Here's my Markdown source: https://gist.github.com/lolmaus/5108211121e811df3a7cbe8b07bea0a5
When I do this in my app's browser console, code blocks are rendered correctly:
const converter = new showdown.Converter()
converter.setFlavor('github')
converter.makeHtml($E)

But when I feed it into {{markdown-to-hrml}}, I get this:

Here's how my initializer looks like:
  showdown.setFlavor('github')
  showdown.setOption('ghCodeBlocks',   true)
  showdown.setOption('tablesHeaderId', true)
  showdown.setOption('tables',         true)
  showdown.setOption('strikethrough',  true)

Please help. Will be glad to PR if you give me a direction to dig into.

The reason seems to be that these lines set EVERY ShowDown option to undefined.


chore: lets switch to the jx namespace when performing verify steps after install

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign rawlingsj
You can assign the PR to them by writing /assign @rawlingsj in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rawlingsj: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

gke
198ff091152651a1fc14a005d80329fa57273732
link
/test gke

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.


Ruby disabling hanging args and curly braces

The combination of these two arguments doesn't seem to work as desired.
let g:splitjoin_ruby_hanging_args = 0
let g:splitjoin_ruby_curly_braces = 0

Splitting a line like:
OpenStruct.new(fist_name: 'John', last_name: 'Doe', age: 50)

results in:
OpenStruct.new(fist_name: 'John',
               last_name: 'Doe',
               age: 50)

Is this a known issue?

It's definitely a bug, and no, not a known one. This particular area of splitting is complicated, since there's quite a lot of edge cases around setting combinations. I'll see what I can do.

I'd forgotten just how complicated this area is :). I think I've managed to restructure some things, get it to make more sense. I don't want to push it to master just yet, though, not without some field testing. The automated tests are passing, but can't be sure I've covered enough cases there.
I've created a branch called fix-ruby-option-splitting. I'd appreciate if you could switch to it and use it for a while, report any issues that come up. Once I've given it some time, and it seems stable, I can merge it into master.

Thank you! Just switched and gave it a test run. Works much better now.
The few kinks that I noticed, with this config:
let g:splitjoin_trailing_comma = 1
let g:splitjoin_ruby_hanging_args = 0
let g:splitjoin_ruby_curly_braces = 0

In order for gS to split correctly, the cursor has to be inside the () in the original example. If the cursor is on the opening paren, for example, the result is:

      # the extra indentation is intentional, to show that closing parent indentation is off.
      OpenStruct.new(fist_name: 'John',
                     last_name: 'Doe',
                     age: 50,
}),

The let g:splitjoin_trailing_comma = 1 option does not add the comma, when gS is triggered inside the () (notice that it worked correctly in the previous issue). Pressing gS when cursor is inside the parens results in:

      # behaves as wanted, sans the trailing comma
      OpenStruct.new(
        fist_name: 'John',
        last_name: 'Doe',
        age: 50
      ),

I'll be running with your branch this week and will report if I notice anything else.
Thank you again for your hard work!

I think I've managed to fix both of these issues, and one more I discovered. Let me know if it's better and/or if there's any new issues.

Been working great so far! Time to get it into master?

Guess so :). I've just merged it. Let me know if you run into any issues, but for now, I'll go ahead and close this.


Compatibility with "Quick Settings Audio Panel" extension

When using this extension together with Quick Settings Audio Panel, it does not hide the devices in the application view. It would be nice if they would be hidden as well so that the general and app view are consistent.

I am not sure if I should report this here or to Quick Settings Audio Panel but I would really like to use this two extensions together and that the devices in all views look the same.

Hi @Ana06 This repo is probably more suitable for this issue.
Extensions touching the same areas of the Shell is pretty much always an issue, this case is a great example of that.
I just installed the Quick Settings Audio Panel extension, and, surprisingly, the hiding functionality still works. I think in this case it's the matter of timing. Depending on which extension gets activated first when your PC boots, the hiding functionality might work, or might not. Maybe just adding a short delay to my extension would be enough? I'm not sure though if extensions are started sync or async, which impacts whether delay has any chance to work. I'll have to check that in Gnome Shell code.

@Ana06, I initially misunderstood the issue. Now I see that Quick Settings Audio Panel has two panels with audio, and one of them is "out of sync".
I will not work on that, but I'd accept a PR for it.


Bug fix for updating identifiers, update fundref DOI base URL and Credit taxonomy base URL

Bug fix that was preventing ORCIDs, RORs and Fundrefs from being updated
Update code to use/reference the correct Crossref funder id prefix: from 'https://api.crossref.org/funders/' to 'https://doi.org/10.13039/'
Added v3 migration script that will update the identifier_scheme and fix any existing identifiers in the DB
Discovered today that the Credit URLs we were using are no longer valid. This updates the code to work with the new URL structure.

@xsrust this is a combination of #2716 which you reviewed previously and an update to the URLs for the Credit taxonomy we use for contributor roles


portainer:9000 This site can't be reached

Question:
Installed docker and portainer on a BANANA PI M2 Berry. Unfortunatelly I can't Access the Website at localhost:9000 or <IP_ADDRESS>:9000 or from the LAN <IP_ADDRESS>:9000. I did the same Installation steps at a Raspberry 3 B and it succeded.
Source: https://homenetworkguy.com/how-to/install-pihole-on-raspberry-pi-with-docker-and-portainer/
I run the command docker ps several times and I get up 1 or 2 or 3 or 4 max minutes. I think portainer is for some reason restarting every 1-4 minutes.

我在阿里云服务器上装的也无法正常初始化，还有官方demo也出问题了 http://demo.portainer.io/

@porti1 you can have a look at the logs to isolate potential issues.
Or join us on slack (www.portainer.io slack link in the top-right menu) to troubleshoot the problem. We're mainly using github for bug report and feature requests.
@xiongyizhu we're only supporting Portainer in English, sorry.


fix: Allow to inject async functions into functions wrapped with asynccontextmanager

When you try to inject synchronous or asynchronous dependencies into an asynchronous generator wrapped with contextlib.asynccontextmanager like this:
async def some_dep() -> int:
    return 5

@asynccontextmanager
@inject
async def some_async_gen(value: Annotated[int, Depends(some_dep)]):
    yield value

you see the error AttributeError: 'solve_async_gen' object has no attribute '_iter'.
The reverse order of the decorators works for sync dependincies only and raises the error AssertionError: You cannot use async dependency `some_dep` at sync main for async ones.
This pull request allows the inject function be used in such context with the direct order of the decorators. I don't see any possibility to provide the ability to use the reverse order because of the way asynccontextmanager is implemented in the standard library:
# contextlib.py - python 3.12
def asynccontextmanager(func):
    @wraps(func)
    def helper(*args, **kwds):
        return _AsyncGeneratorContextManager(func, args, kwds)
    return helper

As you can see, the decorator returns the synchronous wrapper, so when fast_depends execute build_call_model it determines the function as synchronous.

Thank you for the PRs a lot! Btw, what are u doing with FastDepends to find such bugs? 😅

I do nothing 😅
A collegue of mine created a very minimal DI system for one of our internal projects, but when I showed him FastDepends, he decided that it covers all his needs and he can replace self-written DI with FastDepends.
This internal projects uses async generators very widely, so the issue with injecting async depenedencies into async generators was discovered very quickly.
As far as I know, he have not used asynccontextmanagers with async dependencies yet, but I checked this scenario too as one of the most popular uses of async generators and discovered this issue

And thank you for your awesome projects. I use both FastDepends and FastStream and they are gorgeous

@Zhenay I can suggest trying https://github.com/reagento/dishka/
It has a bit more verbose approach but more features related only to DI. There is an integration with FastStream out of the box if you need it.

@Tishka17 Thank you for your suggestion, but we are completely satisfied with FastDepends.
I've heard about Dishka, it's a great and really powerfull tool. But in our case the most important criterion is simplicity and similarity with FastApi DI.


URL misspelled

https://v2.docs.influxdata.com/v2.0/account-management/multi-member/remove-memberr/
One too many r's, matey.

Thanks, @nisley!


Only show "share on Workplace" button if the tenant wants it

Is your feature request related to a problem? Please describe.
If the tenant doesn't use Workplace, the "share on Workplace" button shouldn't be shown.
Describe the solution you'd like
Add a boolean in the configuration to switch on/off the button.

Implemented by #174


pr-template: Clarify sandbox checkbox

Description of changes
This setting can be enabled or disabled on all platforms, so asking
specifically for "non-Linux" is not sufficient.
Also links directly to the setting in the manual, for faster lookup.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

zsh: command not found: nix-info on Arch Linux with single-user Nix install

Fixed, thanks!

Nope ^^
/tmp/nix-shell-47282-0/rc: line 3: nix-info: command not found
But honestly, before wasting your time some more, I'm not sure about how much benefit this checkbox brings in the first place. I mean we can all agree that it is currently completely dysfunctional and I see how your change attempts to improve it. But I think we've done pretty much fine without so far, so maybe simply remove that line in order to keep the list smaller?

Nope ^^ /tmp/nix-shell-47282-0/rc: line 3: nix-info: command not found
But honestly, before wasting your time some more, I'm not sure about how much benefit this checkbox brings in the first place. I mean we can all agree that it is currently completely dysfunctional and I see how your change attempts to improve it. But I think we've done pretty much fine without so far, so maybe simply remove that line in order to keep the list smaller?

Sorry, for some reason I thought nix-info was part of the nix package. People have so far complained that the current template has too many checkboxes, too few checkboxes, and the wrong checkboxes, so I'm just trying to make as neutral changes as possible.

I'd like to hear from @NixOS/darwin-maintainers on this. I've heard rumors that Darwin nowadays has a sandbox and enabled by default, making this checkbox obsolete?

I don't think it's enabled by default, sadly. Though it's been a while since I did a fresh install.

Sandbox is not enabled by default on Darwin currently

If the checkbox remains, I'm in favor of it at least being clear and correct. I opened #238575 about a similar issue with it.

toonn's pr merged


Can't import plugin.

Hi,
I get a strange bug trying to import the plugin.
Here is the error:
failed to load config from /Users/nate/base-template/vite/vite-template/vite.config.js
error when starting dev server:
TypeError: sassGlobImports is not a function
    at file:///Users/nate/base-template/vite/vite-template/vite.config.js.timestamp-1671540244901.mjs:40:5
    at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:526:24)
    at async loadConfigFromBundledFile (file:///Users/nate/base-template/vite/vite-template/node_modules/vite/dist/node/chunks/dep-6305614c.js:63111:21)
    at async loadConfigFromFile (file:///Users/nate/base-template/vite/vite-template/node_modules/vite/dist/node/chunks/dep-6305614c.js:62996:28)
    at async resolveConfig (file:///Users/nate/base-template/vite/vite-template/node_modules/vite/dist/node/chunks/dep-6305614c.js:62617:28)
    at async createServer (file:///Users/nate/base-template/vite/vite-template/node_modules/vite/dist/node/chunks/dep-6305614c.js:61937:20)
    at async CAC.<anonymous> (file:///Users/nate/base-template/vite/vite-template/node_modules/vite/dist/node/cli.js:729:24)
error Command failed with exit code 1.

TypeError: sassGlobImports is not a function
I was able to fix the issue by calling the function like this:
plugins: [
		sassGlobImports.default(),
	],

I'm not sure if this is an issue with the plugin or with my code.
Node -v = 16
Vite -v = 4

@NPanayotov Thanks for the issue. I don't see anything obvious here, but it would help if you could share your full Vite config so I can try to duplicate the issue.

@cmalven thank you for looking into this.
Here is my full config.
import { defineConfig } from 'vite';
import handlebars from 'vite-plugin-handlebars';
import createExternal from 'vite-plugin-external';
import externalGlobals from 'rollup-plugin-external-globals';
import { resolve } from 'path';
import glob from 'glob';
import sassGlobImports from 'vite-plugin-sass-glob-import';

const root = resolve(__dirname, 'src');
const outDir = resolve(__dirname, 'build');

export default defineConfig({
	base: '',
	root,
	build: {
		outDir,
		rollupOptions: {
			input: glob.sync(resolve(root, '.\/*.html').replace(/\\/g, '/')),
			output: {
				assetFileNames: "assets/[name].[ext]",
				entryFileNames: `assets/[name].js`,
				chunkFileNames: `assets/app.js`,
			},
		},
		emptyOutDir: true,
		minify: false,
	},
	plugins: [
		handlebars({
			partialDirectory: resolve(root, 'partials'),
		}),
		externalGlobals({
			jquery: 'jQuery'
		}),
		createExternal({
			externals: {
				jquery: 'jQuery'
			}
		}),
		sassGlobImports.default(),
	],
});

Got the same issue with a simpler config
export default defineConfig({
  plugins: [react(), sassGlobImports()],
  resolve: {
    alias: {
      "~bootstrap": path.resolve(__dirname, "node_modules/bootstrap"),
    },
  },
});

(vite 4)

@NPanayotov @deRaaf Are either of you using "type": "module" in your package.json? I'm getting a similar issue with another popular Vite plugin (https://www.npmjs.com/package/vite-plugin-restart) but only when using "type": "module". However, this plugin doesn't cause that issue for me even when using module so I still have no idea what the problem could be.
If you could share a repo that reproduces your issue - ideally removing as much unrelated config as possible - I can take a look at that and see if I can figure things out.

@cmalven happy holidays. I hope you're doing well.
I'm using type module in the package.json.
You can check my implementation here - https://github.com/NPanayotov/vite-template

I'm also using type: module, I will see if I can share something in the coming days.

I think there's a good chance both of your issues will be fixed by updating this package to ^2.0.0 in your package.json I just tried this on the repo @NPanayotov provided and it seems to have resolved it.

I can confirm this is fixed.
Thank you for looking into it.


[FN] Inject consensus rules (part 1)

Attempt number two at moving rules to network and injecting using DI
@rowandh @codingupastorm there is some special logic for SC that needs to be sorted, for example SmartContractPoARuleRegistration registers rules after they have been DI'd so that component can maybe go away and the rules  just need to be registered ahead of time with the network class
feel free to add on top of this PR.

This is still WIP

@dangershony is it ready for review?

@noescape00 not yet I still have some tests to fix

@dangershony can you fix merge conflicts?

@fassadlr I will fix this today

@dangershony apart from the conflict, there also seem to be some compilation errors in SmartContractPowRuleRegistration and SmartContractPosRuleRegistration

This should now be ready to review again @zeptin

@fassadlr @rowandh this is ready to go in.
I wonder if it should go in master instead of the segwit branch or it will end up as a big bang commit sometime in the future.

@dangershony I think that this PR should be against master as we need to run CI and also get the approvals.

and btw I don't think we even need to specify where each rule has to be registered: can't we just relay on the interface they are implementing?
I mean if we have just a ConsensusRule.Register() and we infer where that rule should go based on the interface it implements, it's easier to register
e.g. if a rule inherit from HeaderValidationConsensusRule it's clearly an HeaderValidation rule, and so on

@fassadlr your comments about clean-up are correct I left this there because this are the areas of smart contracts register rules and this was done in a different to how we did this in the main networks (BTC for POW and STRAT for POS).
I expect a PR to follow this by someone fixing up the SC rules registration (its a bit of a mess right now I have to say, rules get registered in different places and the distinction of POA and SC is not clear)
So I kept the current logic as it is (registering rules form the RulesRegitration interface)

@MithrilMan I like your suggestion, I'll do that not sure in this PR or another.

@MithrilMan @fassadlr if all tests pass I believe this should now be ready.

@dangershony have you done any resyncing with the latest changes?

@fassadlr syncing now, can you retrigger the ubuntu build?

Stratis testnet synced fully Bitcoin testnet synced to block 1.1mil and going

Networks (TBTC/TSTRAT) successfully synced (before the merge)

I have extensively tested this PR now:
1> Sync main and test and main net.
2> Sync address indexing on test and main net.
3> Stake on test net.
4> Sync main and side chain networks using the test tool.
5> Stake and mine blocks on main and side chain networks using the test tool.
6> Send cross chain transaction from main chain to side chain using test tool.

Excellent job @fassadlr 👍 👍 👍 ⚡


Failed to convert icon to .icns, skipping. Error: Icon conversion failed with status code 1.

Homework

[x] I looked at nativefier --help and https://github.com/nativefier/nativefier/blob/master/docs/api.md
[x] I checked the Troubleshooting section of the README.
[x] I searched existing issues, open & closed. Yes, my bug is new.
[x] I'm using the latest version available at https://github.com/nativefier/nativefier/releases

Bug description
When specifying --icon icon.png, an error message is displayed.  The image icon.png that I'm using is https://images.vexels.com/media/users/3/137412/isolated/preview/1802b9d8ce3c819eebe90a86bbb61077-soundcloud-icon-logo-by-vexels.png however this error occurs for ALL of the nativefier apps I've tried building.
Converting icons...
Converting icon icon.png to /var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/nativefier-16-24-42-iconconv--38040-5hk13qE37T06/icon.icns. Calling shell command: "/opt/brew/Cellar/nativefier/43.1.2/libexec/lib/node_modules/nativefier/icon-scripts/convertToIcns" "icon.png" "/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/nativefier-16-24-42-iconconv--38040-5hk13qE37T06/icon.icns"
Failed to convert icon to .icns, skipping.

Steps to reproduce
Give your full nativefier command and its logs, with the --verbose flag, on a public site:
Click to Expand: nativefier --verbose --single-instance ...
$ nativefier --verbose --single-instance --no-overwrite --bounce --darwin-dark-mode-support --user-agent 'Mozilla/5.0 (Windows NT 10.0; rv:74.0) Gecko/20100101 Firefox/74.0' --internal-urls '(.*?(contacts|calendar|accounts)\.google\.com.*?|.*?facebook\.com.*?)' --name Soundcloud --icon icon.png https://soundcloud.com
Running in verbose mode! This will produce a mountain of logs and is recommended only for troubleshooting or if you like Shakespeare.

Performing async options post-processing.
Got icon from options. Using it, no inferring needed
Got name Soundcloud from options. No inferring needed
Sanitized filename for Soundcloud : Soundcloud
options {
  packager: {
    appCopyright: undefined,
    appVersion: undefined,
    arch: 'x64',
    asar: false,
    buildVersion: undefined,
    darwinDarkModeSupport: true,
    dir: '/opt/brew/Cellar/nativefier/43.1.2/libexec/lib/node_modules/nativefier/app',
    electronVersion: '12.0.6',
    icon: 'icon.png',
    name: 'Soundcloud',
    out: '/private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4',
    overwrite: false,
    platform: 'darwin',
    portable: false,
    targetUrl: 'https://soundcloud.com/',
    tmpdir: false,
    upgrade: false,
    upgradeFrom: undefined,
    win32metadata: {
      ProductName: 'Soundcloud',
      InternalName: 'Soundcloud',
      FileDescription: 'Soundcloud'
    }
  },
  nativefier: {
    accessibilityPrompt: true,
    alwaysOnTop: false,
    backgroundColor: null,
    basicAuthPassword: null,
    basicAuthUsername: null,
    blockExternalUrls: false,
    bookmarksMenu: null,
    bounce: true,
    browserwindowOptions: undefined,
    clearCache: false,
    counter: false,
    crashReporter: undefined,
    disableContextMenu: undefined,
    disableDevTools: undefined,
    disableGpu: false,
    diskCacheSize: null,
    disableOldBuildWarning: false,
    enableEs3Apis: false,
    fastQuit: false,
    fileDownloadOptions: undefined,
    flashPluginDir: null,
    fullScreen: false,
    globalShortcuts: null,
    hideWindowFrame: undefined,
    ignoreCertificate: false,
    ignoreGpuBlacklist: false,
    inject: [],
    insecure: false,
    internalUrls: '(.*?(contacts|calendar|accounts)\\.google\\.com.*?|.*?facebook\\.com.*?)',
    lang: undefined,
    maximize: false,
    nativefierVersion: '43.1.2',
    processEnvs: undefined,
    proxyRules: null,
    showMenuBar: false,
    singleInstance: true,
    titleBarStyle: null,
    tray: false,
    userAgent: 'Mozilla/5.0 (Windows NT 10.0; rv:74.0) Gecko/20100101 Firefox/74.0',
    userAgentOverriden: true,
    verbose: true,
    versionString: undefined,
    width: 1280,
    height: 800,
    minWidth: undefined,
    minHeight: undefined,
    maxWidth: undefined,
    maxHeight: undefined,
    widevine: false,
    x: undefined,
    y: undefined,
    zoom: 1
  }
}

Preparing Electron app...
Copying electron app from /opt/brew/Cellar/nativefier/43.1.2/libexec/lib/node_modules/nativefier/app to /var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/nativefier-16-24-42-app--38040-lVH8sSyRrfpu
Writing app config to /var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/nativefier-16-24-42-app--38040-lVH8sSyRrfpu/nativefier.json
No files to inject, skipping copy.
Updating /var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/nativefier-16-24-42-app--38040-lVH8sSyRrfpu/package.json 'name' field to soundcloud-nativefier-914611

Converting icons...
Converting icon icon.png to /var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/nativefier-16-24-42-iconconv--38040-5hk13qE37T06/icon.icns. Calling shell command: "/opt/brew/Cellar/nativefier/43.1.2/libexec/lib/node_modules/nativefier/icon-scripts/convertToIcns" "icon.png" "/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/nativefier-16-24-42-iconconv--38040-5hk13qE37T06/icon.icns"
Failed to convert icon to .icns, skipping. Error: Icon conversion failed with status code 1.
stdout:
stderr: identify: UnableToOpenConfigureFile `delegates.xml' @ warning/configure.c/GetConfigureOptions/702.
identify: NoDecodeDelegateForThisImageFormat `PNG' @ error/constitute.c/ReadImage/572.
convert: UnableToOpenConfigureFile `delegates.xml' @ warning/configure.c/GetConfigureOptions/702.
convert: NoDecodeDelegateForThisImageFormat `PNG' @ error/constitute.c/ReadImage/572.
convert: NoImagesDefined `convert_temp/icon.png' @ error/convert.c/ConvertImageCommand/3322.

    at iconShellHelper (/opt/brew/Cellar/nativefier/43.1.2/libexec/lib/node_modules/nativefier/src/helpers/iconShellHelpers.ts:46:11)
    at Object.convertToIcns (/opt/brew/Cellar/nativefier/43.1.2/libexec/lib/node_modules/nativefier/src/helpers/iconShellHelpers.ts:83:10)
    at Object.convertIconIfNecessary (/opt/brew/Cellar/nativefier/43.1.2/libexec/lib/node_modules/nativefier/src/build/buildIcon.ts:87:24)
    at Object.buildNativefierApp (/opt/brew/Cellar/nativefier/43.1.2/libexec/lib/node_modules/nativefier/src/build/buildNativefierApp.ts:173:3)
Copying icons if necessary
No icon specified in options; aborting

Packaging... This will take a few seconds, maybe minutes if the requested Electron isn't cached yet...
  electron-packager Electron Packager 15.2.0
  electron-packager Node v16.1.0
  electron-packager Host Operating system: darwin 20.5.0 (x64) +0ms
  electron-packager Packager Options: {"arch":"x64","asar":false,"darwinDarkModeSupport":true,"dir":"/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/nativefier-16-24-42-app--38040-lVH8sSyRrfpu","electronVersion":"12.0.6","name":"Soundcloud","out":"/private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4","overwrite":false,"platform":"darwin","portable":false,"targetUrl":"https://soundcloud.com/","tmpdir":false,"upgrade":false,"win32metadata":{"ProductName":"Soundcloud","InternalName":"Soundcloud","FileDescription":"Soundcloud"}} +1ms
  electron-packager Target Platforms: darwin +0ms
  electron-packager Target Architectures: x64 +0ms
  electron-packager Inferring appVersion from version in /var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/nativefier-16-24-42-app--38040-lVH8sSyRrfpu/package.json +0ms
  electron-packager Application name: Soundcloud +9ms
  electron-packager Target Electron version: 12.0.6 +0ms
  electron-packager Ignored path regular expressions: [
  '/package-lock\\.json$',
  '/yarn\\.lock$',
  '/\\.git($|/)',
  '/node_modules/\\.bin($|/)',
  '\\.o(bj)?$'
] +0ms
  electron-packager Downloading Electron with options {"platform":"darwin","arch":"x64","version":"12.0.6","artifactName":"electron"} +0ms
Packaging app for platform darwin x64 using electron v12.0.6
  electron-packager Creating /private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/darwin-x64-template +3ms
  electron-packager Extracting /Users/zriggle/Library/Caches/electron/739809e58a9d0011b22ab70d11516a49a099dadf81ec40aabf349af3c1154da6/electron-v12.0.6-darwin-x64.zip to /private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/darwin-x64-template +1ms
  electron-packager Initializing app in /private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-darwin-x64 from /private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/darwin-x64-template template +0ms
  electron-packager Ignored paths based on the out param: [
  '/private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-darwin-x64',
  '/private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-darwin-arm64',
  '/private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-linux-ia32',
  '/private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-linux-x64',
  '/private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-linux-armv7l',
  '/private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-linux-arm64',
  '/private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-linux-mips64el',
  '/private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-mas-x64',
  '/private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-mas-arm64',
  '/private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-win32-ia32',
  '/private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-win32-x64',
  '/private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-win32-arm64'
] +2s
  electron-packager Renaming Electron to Soundcloud in /private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-darwin-x64/Electron.app/Contents/MacOS +35ms
  electron-packager Renaming Electron Helper to Soundcloud Helper in /private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-darwin-x64/Electron.app/Contents/Frameworks/Electron Helper.app/Contents/MacOS +1ms
  electron-packager Renaming Electron Helper (Renderer) to Soundcloud Helper (Renderer) in /private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-darwin-x64/Electron.app/Contents/Frameworks/Electron Helper (Renderer).app/Contents/MacOS +0ms
  electron-packager Renaming Electron Helper (Plugin) to Soundcloud Helper (Plugin) in /private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-darwin-x64/Electron.app/Contents/Frameworks/Electron Helper (Plugin).app/Contents/MacOS +1ms
  electron-packager Renaming Electron Helper (GPU) to Soundcloud Helper (GPU) in /private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-darwin-x64/Electron.app/Contents/Frameworks/Electron Helper (GPU).app/Contents/MacOS +0ms
  electron-packager Renaming Electron Helper.app to Soundcloud Helper.app in /private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-darwin-x64/Electron.app/Contents/Frameworks +0ms
  electron-packager Renaming Electron Helper (Renderer).app to Soundcloud Helper (Renderer).app in /private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-darwin-x64/Electron.app/Contents/Frameworks +0ms
  electron-packager Renaming Electron Helper (Plugin).app to Soundcloud Helper (Plugin).app in /private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-darwin-x64/Electron.app/Contents/Frameworks +0ms
  electron-packager Renaming Electron Helper (GPU).app to Soundcloud Helper (GPU).app in /private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-darwin-x64/Electron.app/Contents/Frameworks +0ms

Finalizing build...
App built to /private/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/tmp.d0TS60q4/Soundcloud-darwin-x64, move to wherever it makes sense for you and run the app bundle.

Expected behavior
Nativefier app should have an icon.  I built this using the same script I've always used, and it is failing on the current nativefier.
Actual behavior
An error message is thrown, and none of my Nativefier apps have an icon.
Converting icons...
Converting icon icon.png to /var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/nativefier-16-24-42-iconconv--38040-5hk13qE37T06/icon.icns. Calling shell command: "/opt/brew/Cellar/nativefier/43.1.2/libexec/lib/node_modules/nativefier/icon-scripts/convertToIcns" "icon.png" "/var/folders/l1/f4rh7l7n0v59msb7psh91m7h0000gn/T/nativefier-16-24-42-iconconv--38040-5hk13qE37T06/icon.icns"
Failed to convert icon to .icns, skipping.

Debug info

Console logs of your nativefier build command, with --verbose flag.

See above

If the bug happens at app run time, the in-app DevTools console logs (open it with F12)

At build time

Error messages

See above

Screenshots

Not applicable

Anything else relevant!

Context
$ nativefier --version
43.1.2

$ node --version
v16.1.0

$ npm --version
7.11.2

$ sw_vers
ProductName:	macOS
ProductVersion:	11.4
BuildVersion:	20F5055c

@zachriggle have you been able to try my proposed workaround?

The workaround did work.
Also, the root-cause of the issue is that Homebrew's imagemagick hard-codes paths to /usr/local/Cellar/xxx where I have Homebrew installed at a different location (per my company's setup instructions).
Creating a symlink at /usr/local/Cellar to point to my actual Cellar resolves the issue.


[Tooltip]: added hide-after timeout for hiding tooltip

Please make sure these boxes are checked before submitting your PR, thank you!

[x] Make sure you follow Element's contributing guide (中文 | English).
[x] Make sure you are merging your commits to dev branch.
[x] Add some descriptions and refer relative issues for you PR.

Added an optional prop hide-after to hide the tooltip after a number of millis.

Hi, sorry to bug you, but I was wondering if there is something I missed, or if you had any questions about the PR?

@Leopoldthecoder hello, I was wondering if there was something I missed in the PR, or if I'm just waiting in the queue?  Don't mean to bug you.

Oh, sorry, I'll take a look soon and hopefully this will be included in 1.4.5

Thank you.  Also waiting for 6428.  Much appreciated.

@ryatziv Thanks for contributing.

Thanks @Leopoldthecoder (and thanks for Element!)
Would you please look at https://github.com/ElemeFE/element/pull/6428?


[azure-monitor-opentelemetry-exporter] migration from jackson.core.json to azure-json

API change check
APIView has identified API level changes in this PR and created following API reviews.
com.azure:azure-monitor-opentelemetry-exporter


adjust version

fix #3783

Summary

@valadas
when and where did you release 9.6.2 - I can find 9.6.1 only

I am coming up with an automation for this, but if we do a manual adjustment as of now we are out of RC and 9.6.2 is released.
Can you please adjust to remove the release candidate line and just update the latest supported release to 9.6.2

Looks good to me.  9.6.1 is the latest release.  ;-)

I am sorry, my mistake, I live in the future... But we do not have a 9.6.2 RC at the moment, can you please just remove the release candidate line, there is an automation in place that will add it when we do create a 9.6.2 RC.

Thank you sir, sorry for the confusion there :)


queryFn with server action name not working on Next.js

Describe the bug
I'm using useQuery hook with my Next.js 14.1.3 project. I'd like to use server action as query function, so I made my codes like this.
actions/fetchTasks.ts
"use server"

const fetchTasks = async () => {
  try {
    const { data, errors } = client.graphql({ // I'm using AWS Amplify Graphql client
      query: listTasks,
      variables: {
        filter: {},
      },
    });
    if (errors) throw new Error(errors[0].message);
    return data.listTasks.items as Task[];
  } catch (err) {
    console.log(err);
    return [];
  }
};

export default fetchTasks;

hooks/useTasks.ts
"use client"

import fetchTasks from "../actions/fetchTasks";

const useTasks = () => {
  const { data } = useQuery({
    queryKey: ["tasks"],
    queryFn: fetchTasks, // using function name
  });
  return { data };
};

export default useTasks;

However, this didn't work. Data from useTasks hook always returned undefined.
When I put console.log at the top of inside fetchTasks function, this didn't show up, so I think using function name as queryFn is completely not working.
After some trials and errors, replacing function name with anonymous arrow function solved this problem.
hooks/useTasks.ts
"use client"

import fetchTasks from "../actions/fetchTasks";

const useTasks = () => {
  const { data } = useQuery({
    queryKey: ["tasks"],
    queryFn: () => fetchTasks(), // using anonymous arrow function
  });
  return { data };
};

export default useTasks;

Is this expected behavior? I know many of documentation codes are using function name as queryFn. (e.g. https://tanstack.com/query/latest/docs/framework/react/quick-start)
Your minimal, reproducible example
https://codesandbox.io/p/github/tsuyuni/ReproduceQueryFnWithFunctionNameNotWorking/main?import=true
Steps to reproduce
Just run npm i and npm run dev.
Then you will see:
Tasks with function name has no tasks though expected to have 3 tasks.
Tasks with anonymous arrow function has 3 tasks as it was expected.
Expected behavior
queryFn with function name should properly work.
How often does this bug happen?
Every time
Screenshots or Videos
No response
Platform
OS: Sonoma 14.2
Tanstack Query adapter
react-query
TanStack Query version
5.32.0
TypeScript version
5.4.5
Additional context
No response

Yes, took me 5 hours to find the workaround. Drove me crazy.


Update README with Docker + Binder instructions

Helpful template here: https://raw.githubusercontent.com/fastscape-lem/fastscape-demo/master/README.md

after #9, local docker no longer relevant part of use pattern


ISSUE#387 re-enable statistics for B-tree

What changes were proposed in this pull request?
This is to re-enable statistics for BTree.

[x] re-enable statistics r/w in BTree
[x] re-enable statistics tests
[x] select index based on statistics for BTree
[x] clean old code concerning array[byte]
[x] clean old code concerning UnsafeRow

How was this patch tested?
Unit tests

BitMap version will be updated after bit map index really use unsafe way to access data.

There are several remaining issues in the pr, I'll list and fix them in a new conversation. Will merge this first since this pr is the fundamental one and involves a lot of code.


Fiat currency deposit not working

I do creating usd deposit on tower but giving error "min_deposit_amount" i checked peatio folder fiat currency need blockchain network but impossible" community knows this issue?

thank you so much to team for so quickly fixed

i see that team created commit for fiat network but when deposist funds fiat on tower that giving error as admin.beneficiary.blockchain_key_doesnt_exist


doc/go1.9.html: should go/types.Package.Imports behavior change be included?

(It's not quite clear to me what's the criteria for inclusion of a change to warrant being mentioned in the release notes under the "Minor changes to the library" section (is it documented somewhere?), that's why this is a question.)
https://godoc.org/go/types#Package.Imports changed behavior slightly. In Go 1.8, it was documented as:

Imports returns the list of packages directly imported by pkg; the list is in source order. Package unsafe is excluded.
[...]

In Go 1.9:

Imports returns the list of packages directly imported by pkg; the list is in source order.
[...]

So package unsafe is no longer excluded.
Should this be mentioned in doc/go1.9.html? It would've been saved me some time debugging an unexpected behavior change if I saw it mentioned there, so maybe it'll be helpful to others too.
Related to #20587.
Related to CL 37694. /cc @griesemer @alandonovan

Friendly ping.
If the answer is that "no, it shouldn't be included," this issue can be closed (but I'd like to know why not).

Ping @griesemer

Whatever we should have done, the ship has sailed and sunk.


Libnop C++20 Bug

Hello,
So I have checked the current libnop version fork through the luxonis account and I see the updated changes to types/variant.h of libnop adding the template keyword to make sure it compiles with C++20 correctly but building the tests still have the former broken template macro being used, manually fixing this clears the bug and lets everything compile so it must be with the version hunter is pulling... I attempted to manually set the exact commit this was fixed by but it is not pulling down the newest version with the changes properly and I do not know as to why. With the new archive link, checksum, and version name changed it still pulls an outdated repo.
Any help would be appreciated as I can't really submit a pull request without it even working on my system first.
Thanks,
-otg007

@onthegrid007 try clearing hunter cache: rm -rf ~/.hunter
Otherwise working directly on the libnop repo might be simpler (if you mean libnop tests). DepthAI tests should function correctly, check if you are on correct branch /w all submodules updated

I will try this but even with pulling a fresh depthai-core repo libnop fails the c++20 test and I was going to put in a pull request with a newer libnop from the luxonis account but I see the c++ 20 fix commit and it's like 10 commits ahead of that so I just thought the repo being pulled by hunter was out of date... I'll try the hunter cache clearing and see if this fixes it

Found the error, the develop branch hasn't been pushed to master in over 2 years, the C++20 fix isn't in the current repo pulled by hunter... I am writing a patch...

Done.

There was also further template issues preventing depthai-core from compiling even with the latest develop branch...


Allow config options in file as yaml mappings

Replaces the ff package with a custom implementation that uses Viper to parse the config file and sets the values for the flag.Flags.
By design the ff package doesn't allow flag subsets or nested maps inside the config yaml and all config options must be explicitely defined as flag.Flag. This limits the ability to specify more dynamic config options like lists or maps of user defined rules (Ex: metric rollups).
Viper provides the flexibility we require for parsing the config file, and unmarshaling directly into more complex datastructures. To define how to unmarshal a subtree of the configuration into a datastructure via unmarshalRule:
withUnmarshalRules(
  []unmarshalRule{{"startup.dataset", &dataset.Config}}
)

Given the  the config file contains the subtree:
startup:
  dataset:
    metrics:
      ...
    traces:
      ...

Viper can access a nested field by passing a . delimited path of keys. In this scenario, the subtree startup.dataset will be unmarshal into &dataset.Config by Viper using the github.com/mitchellh/mapstructure package.
This change also allows us to format our configuration files to use yaml mappings instead of long key names with ., thus maintaining backwards compatibility:
web.listen-address: localhost:9201
web.auth.password: my-password
web.auth.username: promscale

Can be rewritten as:
web:
  listen-address: localhost:9201
  auth:
    password: my-password
    username: promscale

Merge requirements
Please take into account the following non-code changes that you may need to make with your PR:

[x] CHANGELOG entry for user-facing changes
[x] Updated the relevant documentation

cc @paulfantom this is the PR to allow a yaml mapping instead of a string for the dataset config


Please support empty RoutePrefix in SwaggerUIOptions

Currently the FileServerOptions RequestPath property is set to
$"/{options.RoutePrefix}"
The RequestPath must not end with a "/" but it can be blank. This allows the swagger documentation to be served from the route which is what we do internally for our individual microservices for simplicity.
Current workaround is to use the following in lieu of app.UseSwaggerUi():
var indexSettings = new IndexSettings();
indexSettings.JSConfig.SwaggerEndpoints.Add(new EndpointDescriptor()
{
     Url = "/swagger/v1/swagger.json",
     Description = "Some API Name"
});

var fileServerOptions = new FileServerOptions()
{
    FileProvider = new SwaggerUIFileProvider(indexSettings.ToTemplateParameters()),
    EnableDefaultFiles = true
};

fileServerOptions.StaticFileOptions.ContentTypeProvider = new FileExtensionContentTypeProvider();

app.UseFileServer(fileServerOptions);

+1 for this.


Feat: Improve Notif. Test message to catch edge cases

⚠⚠⚠ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:

[x] I have read and understand the pull request rules.

Description
In the past, there were a few issues where problems with peoples' notification configuration caused UP/DOWN notification to fail to deliver, but the manually triggered Test message is unable to reproduce the issue. Just from memory key ones are:

Handling newline characters within msg: e.g. a DOWN message for a Ping monitor would most likely include a newline character. This has caused webhook notifications to fail to deliver because of issue with templating.
Unicode char: The cross emoji somehow cause the message to be blocked by notification providers.

Maybe we should improve the test message to include these common pitfalls for better testing.
Type of change

Bug fix (non-breaking change which fixes an issue)
User interface (UI)
New feature (non-breaking change which adds functionality)
Breaking change (a fix or feature that would cause existing functionality to not work as expected)
Other
This change requires a documentation update

Checklist

[ ] My code follows the style guidelines of this project
[ ] I ran ESLint and other linters for modified files
[ ] I have performed a self-review of my own code and tested it
[ ] I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
[ ] My changes generates no new warnings
[ ] My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

Another change that might be worth lumping into this is to make the Test-button iclude a monitorJSON, as all other notifications (Cert-Exp, UP, DOWN) have that.
See https://github.com/louislam/uptime-kuma/pull/3414


MBL-1710: Entry Point: Push Notification navigation

📲 What
Added push notifications for pledge redemption
🤔 Why
pledge redemption
🛠 How
New notification channel. Implemented similarly to how we do survey notifications, since they are opening the same activity
📋 QA
When pledge redemption is being QA'ed, we can test locally by grabbing the Url and pasting it into the DebugPushNotificationsView
Story 📖
MBL-1710: Entry Point: Push Notification navigation

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 23.28767% with 56 lines in your changes missing coverage. Please review.

Project coverage is 68.73%. Comparing base (48eb734) to head (fc45c08).

Files with missing lines
Patch %
Lines

.../services/apiresponses/PushNotificationEnvelope.kt
21.05%
29 Missing and 1 partial :warning:

...ain/java/com/kickstarter/libs/PushNotifications.kt
7.69%
24 Missing :warning:

.../kickstarter/viewmodels/SurveyResponseViewModel.kt
77.77%
1 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2172      +/-   ##
============================================
- Coverage     68.87%   68.73%   -0.15%
  Complexity     2225     2225
============================================
  Files           366      366
  Lines         23158    23222      +64
  Branches       3356     3363       +7
============================================
+ Hits          15951    15961      +10
- Misses         5396     5447      +51
- Partials       1811     1814       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


Integer midpoint

Overflow-safe integer midpoint with rounding control
A common source of integer and pointer overflows and out-of-bounds accesses across programming languages is midpoint computations for the purposes of collection algorithms. Swift's checked arithmetic and accesses prevent errors, but may still result in spurious crashes when this operation is implemented incorrectly.
Further, rounding-control for integer arithmetic is subtle and easy to get wrong, and further complicates overflow prevention (midpoint should never overflow, no matter how it is rounded, but achieving this can be tricky). For some algorithms it is desirable to round up or down or to even; we simply implement all of the options.
Draft because I am not sold on the free-function spelling midpoint(a, b). It is desirable by symmetry with min(a, b) and max(a, b), and because it correctly captures that this is a commutative operation; neither operand is privileged. But Swift generally eschews free functions. This could equally be a static member (Int.midpoint(a, b)), or possibly use some other spelling.

@swift-ci test

@swift-ci please smoke test

@swift-ci please test

@swift-ci test


"insufficient privilege" for non-superuser

How I can get a real backend status for non-superuser?
Can you replace "SELECT * FROM pg_stat_activity" to "SELECT * FROM pg_stat_activity()"?
CREATE OR REPLACE FUNCTION public.pg_stat_activity() RETURNS SETOF pg_catalog.pg_stat_activity
AS $BODY$
DECLARE
 rec RECORD;
BEGIN
    -- Author: Tony Wasson (part of nagiosplugins for postgresql)
    -- Overview: Let non super users see query details from pg_stat_activity
    -- Revisions: (when, who, what)
    --   2006-08-29 TW - Checked into CVS after a user request.
    FOR rec IN SELECT * FROM pg_stat_activity
    LOOP
        RETURN NEXT rec;
    END LOOP;
    RETURN;
END;
$BODY$ LANGUAGE plpgsql SECURITY DEFINER;

Do you have any solution?

Hello,
This problem will be solved in postgres 10, see https://www.postgresql.org/docs/10/static/default-roles.html and the new "pg_read_all_stats" default role.
In the meantime, check_pgactivity aim is to be usable with minimal impact on the monitored server, therefore we can't force people to create an SRF for this :(
If you can't or don't want to use a superuser for this (which I BTW totally agree with), you just need minimal additional steps to the pg_stat_activity() function you mention:

create a dedicated schema, let's say "monitoring"
create a monitoring.pg_stat_activity view that returns a plain select * from pg_stat_activity() (you may want to create this function in the dedicated schema)
specificy this schema before pg_catalog schema in the default seach_path of your monitoring user(s)

For instance, assuming you'll use monitor role and monitoring schema:
CREATE USER monitor LOGIN NOSUPERUSER;
CREATE SCHEMA monitoring;
GRANT USAGE ON monitoring TO monitor;
CREATE VIEW monitoring.pg_stat_activity AS SELECT * FROM public.pg_stat_activity();
GRANT SELECT ON monitoring.pg_stat_activity TO monitor;
ALTER ROLE monitor SET search_path = monitoring, pg_catalog,"$user", public;

WARNING
Please note that there's an issue in the pg_stat_activity() function you provided, because it's not using fully qualified relation name.  The FOR rec line should be
FOR rec IN SELECT * FROM pg_catalog.pg_stat_activity

After that, everything should work if you configure check_pgactivity to use the monitor role.  I agree that's far from ideal, but in a few years pg10+ versions should be wildly used :)

Hello,
As an addition, I once developped an extension called monitoring_role that helps using a non-superuser role for monitoring. However, this extension is provided as is and is not part of check_pgactivity.
As Julien outlined in his previous reply, Postgres 10 will provide such feature. The current development branch of check_pgactivity has already every required changes to support it.


Content inside element having a background image must not be blurred. How to achieve this?

Content inside element having a background image must not be blurred. How to achieve this?
<ProgressiveImage
src={image1}
placeholder={image1X60}
style={{
height: 600,
backgroundSize: 'contain',
backgroundPosition: 'center center',
}}

Some content

"Some content"  text inside also gets blurred out which is not the desired behaviour.

Move your text component outside of the ProgressiveImage component and move it back up with CSS. Or remove the blur altogether


Anit-Aim makes u move to the left

toggle "Fix movement" in misc

Wanted to add that local viewangles are normal while gotv/spectator see desync angle.


Update on pycocotools for windows

🚀 Feature
For Windows, we are currently installing the pycocotools from philferriere
We should use an updated version from gautamchitnis  using this command here below. This fork was created to update the philferriere clone with newer commits from original repo. :
pip install git+https://github.com/gautamchitnis/cocoapi.git@cocodataset-master#subdirectory=PythonAPI
This is the recommended method in torchvision tutorial : Check out the Windows note.

I see no difference between the two repositories.
I just saw the commit history and only diffrence is update in readme.md and .gitignore file.
You can view

New propose commits here
Current Philferriere commits here

We can keep this issue open as "Update Pycoco Tools for Windows", maybe we can find a better option.

So, we discussed over PyCoco tools and I guess this should be the final solution.
Let's keep PyCoco for Windows and Linux separate. So that in case either messes up we aren't struggling to deliver at least Linux builds.

We do not maintain PyCoco for Linux. We use the original one itself from COCO API.
For PyCoCo on windows. We try to maintain it. We have forked it to our organization.
Windows support will probably come in release 0.2.0, not in 0.1.0. So we can focus only on Linux right now and ensure that it works fine.
Windows support for release 0.1.0 is ABSENT. Not experimental. 0.2.0 will be experimental and hopefully, we can provide it.

To ship PyCoco tools for different distros as different requirements. We would need to use Poetry. Related to #267.
After we have these things in place. We can finally resolve Pycoco problem.
Also, we would have it experimental in 0.2.0. Beta in 0.3.0 and maybe in 0.4.0 stable support with Windows.
I like this policy from PyTorch. All the new features are in 3 zones. Experimental, Beta and Stable. So that people are clear what works and what doesn't.

Not relevant anymore


Reset to initial “idle” state in clearBlogUrl()

Closes #64 (part 2).

LGTM
Once again, thanks for the patch!


Alternatives to CM4 ?

First of all, a huge thank you @jclark and all the other people involved,
this is the most detailed and well curated place I could find about making a PTP enabled device for time keeping.
Unfortunately, I have been struggling with getting my hands on a CM4 for months and I really do need to find an alternative now.
This might not be the best place to post, but I wanted an opinion about possible alternatives that can be used to the CM4.
Note that I can't use ebay to source the CM4.
The only mention I found about IEEE 1588 support on a device similar to the Raspberry Pi that is also in stock is the Arduino Portenta X8
Could this be a valuable option? Are there other options you could suggest?
One thing I noticed is that in the Arduino documentation is specified the Ethernet port supports AVB and IEEE 1588.
You also mentioned in your documentation the Mikrotik Switch is designed for AVB, but it is not clear to me what this means in practice.
For example, would that imply the device can be used only as slave but not a master clock?

Assuming you are interested in running a PTP server (grandmaster), not just a client, the hard-to-find thing is the NIC having a pin that accepts a PPS signal (and has the needed kernel support). IEEE 1588 support just means it will work as   a PTP client.
The best alternative I have found is to use an i210-T1 PCIe card, but that requires a different kind of device than a Raspberry Pi.
I'm planning to do a another github repo to detail how to make this approach work.


style dosnt load cause it dosnt exist in node_modules ?

Hi,
After my "yarn add blablabla" the console says it cant find the scss or css file.
I manually checked if the file was existing but it's not.

Im closing it myself, the problem is that the website with the documentation is NOT UP TO DATE.
If anyone see this, just read doc from this repo only.

https://github.com/kidjp85/react-id-swiper#styling


Missing 2.1.0 tag

Seems like you guys are missing the tag on your repo? or am I not looking close enough? Tried to do pod install and I get:
[!] /usr/bin/git clone https://github.com/ovenbits/Alexandria.git /var/folders/7z/0jyzf27939l_45tmp4rgbf2hzw27vx/T/d20170419-13673-1en747w --template= --single-branch --depth 1 --branch v2.1.0

Cloning into '/var/folders/7z/0jyzf27939l_45tmp4rgbf2hzw27vx/T/d20170419-13673-1en747w'...
warning: Could not find remote branch v2.1.0 to clone.
fatal: Remote branch v2.1.0 not found in upstream origin

Hey @wilferrel,
The repo was recently transferred to my personal GitHub account (jlandon/Alexandria), but I hadn't yet updated the podspec in the pod repo.
Everything should be good to go now. If you still have issues when running pod install, try running pod repo update first, then pod install should work. Let me know if for some reason that still doesn't work for you. Thanks for reaching out!

Awesome thanks!


QA: /offers/benefits-mentor-demo

https://main--merative2--hlxsites.hlx.page/offers/benefits-mentor-demo
https://merative.sharepoint.com/:w:/r/sites/Merative.comWebsite/_layouts/15/Doc.aspx?sourcedoc={8912A332-B58F-4EDF-9E32-56EA572BBED8}&file=benefits-mentor-demo.docx&action=default&mobileredirect=true
Figma that shows the CTA at the bottom with a picture:
https://www.figma.com/file/vw24IPXXt4vCh9BNumka9A/Web--Merative-Digital-Design-System-2.0?node-id=1402%3A12379&t=RoYBxzHx9z5JFBvR-1

@arumsey is this ready for customer review?

@venturewise This page just needed its Marketo block updated and a Metadata block added. Those have both been compelted now.

@keith-kaplan this demo page is ready for you to review.

Looks great.


Revert "Use DUCT-TAPE to fix irq test"

This reverts commit 2e0f9ffa672f526c91b5a6128cb70df082f33fd4.
It appears that some (maybe Islet) is not handling some IRQ properly. As a result this patch broke reading the attestation token even though the cca-rmm-acs tests were passing. It it most likely due to the fact that the test suite was a simple bare metal binary that doesn't utilize much of the emulated hardware. Reverting this patch doesn't remove any functionality. In the future, the IRQ handling should be investigated.

I've verified that the #350 is fixed with that commit. From my understanding reverting https://github.com/islet-project/islet/commit/2e0f9ffa672f526c91b5a6128cb70df082f33fd4 means that one of ACS tests will start to fail again, but it's of a less importance that being able to fetch the token and perform attestation.
@L0czek please make a note here what github issues is tracking this stuff.

@L0czek please make a note here what github issues is tracking this stuff.

This issue is tracked in https://github.com/islet-project/islet/issues/352 at

The attestation irq exit test
The attestation_rec_exit_irq attempts to test whether reading the attestation token from rmm can be interrupted by an IRQ. Since, the IRQ is a lower level exception, it cannot interrupt the control flow of Islet. As a result, it needs to be actively checked during RSI handling. [...]


Revised documentation for some EC_GROUP_* methods

fixed the documentation of the RETURN VALUES section
for the following functions.
EC_GROUP_get_order
EC_GROUP_get_cofactor
EC_GROUP_get_curve_name
EC_GROUP_get_asn1_flag
EC_GROUP_get_point_conversion_form
EC_GROUP_get_degree

Checklist

[x] documentation is added or updated

Thanks  @vilvarajintel for submitting this PR!
To start, we need to take care of the missing CLA, you can read all bout it at https://www.openssl.org/policies/cla.html

Hi @vilvarajintel . The CLA policy can be found at https://www.openssl.org/policies/cla.html

I ran into some problems with branching, therefore I have created a new Pull request at https://github.com/openssl/openssl/pull/9195

closing this PR ,updated PR at https://github.com/openssl/openssl/pull/9195


Enable unnecessary_library_name

Supersedes https://github.com/flutter/flutter/pull/145714 now that https://github.com/dart-lang/dartdoc/issues/3882 is fixed.

Looks like something is still broken:
Generated URL: package-flutter_driver_flutter_driver/FlutterDriver/FlutterDriver.connectedTo.html
Expected URL: flutter_driver/FlutterDriver/FlutterDriver.connectedTo.html

Closing this as the conclusion has been that we actually need these library names to get better doc URLs.


Update jmx-configmap.yaml

added connecttor source, sink metrics and debezium metrics
What changes were proposed in this pull request?
For additional connect metrics based on below documentations :

Source Metrics : https://docs.confluent.io/home/connect/monitoring.html#source-task-metrics
Sink Metrics : https://docs.confluent.io/home/connect/monitoring.html#sink-task-metrics
Debezium Connector Metrics: https://debezium.io/documentation/reference/operations/monitoring.html

How was this patch tested?
helm upgrade on AWS EKS.

It looks like @surajrajanathrapully hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.
Once you've signed reply with [clabot:check] to prove it.
Appreciation of efforts,
clabot

It looks like @surajrajanathrapully hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.
Once you've signed reply with [clabot:check] to prove it.
Appreciation of efforts,
clabot

[clabot:check]

[clabot:check]

@confluentinc It looks like @surajrajanathrapully just signed our Contributor License Agreement. :+1:
Always at your service,
clabot

@confluentinc It looks like @surajrajanathrapully just signed our Contributor License Agreement. :+1:
Always at your service,
clabot

@surajrajanathrapully Thank you for this PR.
a few questions here

do you think it's possible / reasonable to make those debezium specific metrics optional / enabled by setting the parameter?
or maybe just have a documentation section about those metrics?
or even just commented out (which lazy version of option 1)

Let me know what do you think!
Cheers,
Vik

@surajrajanathrapully Thank you for this PR.
a few questions here

do you think it's possible / reasonable to make those debezium specific metrics optional / enabled by setting the parameter?
or maybe just have a documentation section about those metrics?
or even just commented out (which lazy version of option 1)

Let me know what do you think!
Cheers,
Vik

Hi @gAmUssA, Thanks for your comments.
Went with your second option :) Updated the documentation link regarding debezium metrics.
Let me know if this looks good.
Thanks, Suraj

Hi @gAmUssA, Thanks for your comments.
Went with your second option :) Updated the documentation link regarding debezium metrics.
Let me know if this looks good.
Thanks, Suraj


Performance metrics not active when enabled via player.on

I'm trying to the performance tracker to fire off via player.on().
Adding a "performance" function to the eventTracking config works.
player.eventTracking({
    performance: function(data) {
      console.log('tracking:performance', data);
    }
});

Adding it via player.on() does not work. This is my preferred method, but it doesn't fire off.
player.on('tracking:performance', (e, data) => console.log(e.type, data))

I'm working with the index.html in the Github repo. I followed the instructions in the Readme to clone the repo, install the dependencies, and open the index.html.
Browser: Firefox Developer Edition 103.0b9 (64-bit)
VideoJS: 7.18.1

Same here

Looks like the README is a bit outdated (it's said to be experimental - I will update this now). This event trigger is removed due to accuracy and is only really available with passing the function through the configuration. The culprit is the unload event for the browser. Without it being a synchronous function, you will loose the ability to track when the user refreshes the browser / backs out / closes the window.
If you do want this and are OK with the inaccuracy, here is a quick code change;
https://github.com/spodlecki/videojs-event-tracking/pull/32
I'm open to any Pull Requests


Router can't find the route by hash with query

Pre-conditions:
Routes config:
export const routes = {
  root: PAGES.HOME,
  routes: [
    {
      path: "$",
      component: SplashScreen,
    },
    {
      path: PAGES.HOME,
      component: HomePage,
      widgets: [WIDGETS.MENU],
    },
    ...
}

URL: http://localhost:8082/?configUrl=http://localhost:8081/config.json#Home?action=showWiFi&wifiType=home
Expected result
Router is parsing query parameters and navigates to the route #Home
Actual result
Router is parsing query params (both in location.search and hash), but navigates to the route "*" (Not Found)
Investigation
I guess I found a regression made 15 months ago, that breaks this flow in my case. @erikhaandrikman, could you please check this?
sdk/src/Router/index.js

App is loading the splash screen ($) first, then Router is parsing the querystring and trying to navigate to the hashed route. But as we’re navigating it from Splash, then it’s not considered as a direct load, and there is no route by hash #Home?action=showWifi…, so function start is navigating to the NotFoundPage (*)
Possible solution
My suggestion is to clean the hash from query parameters before checking the existence of the page by this hash (sdk/src/Router/index.js, in line 127). This fixes the issue in that case, but I can’t say that it’s 100% correct solution.
Setup
SDK: 4.8.1
CLI: 2.8.1
Core: 2.6.0
Build: any (Metrological / standalone / dev standalone)
Browsers: Chrome 104, WPE (EOS)

@mikita-liaukovich-epam thanks for your (wonderfully detailed!) bug report and possible suggestion. One of our engineers will look into it.

Yes. The Hash first will prevent the browser from processing the queryparams. But the router should still parse it and provide the query information to the page.

Hi,
As @mauro1855 is already pointing out, the specification dictates that query string parameters should come before the hash (fragment). The issue you're facing is caused by this change: https://github.com/rdkcentral/Lightning-SDK/commit/44c73557e5668168f1664ecf7596502d8407647e that allowed all characters to be a part of the url.
Moving forward you can choose to take the following paths:

Build your url following the specification: http://localhost:8081/config.json?action=showWiFi&wifiType=home#Home the downside is that your page will refresh if you change the qs parameters.
Turn your query string into dynamic parts of your url:

{
    path: 'home/:action/wifiType',
    component: Home
}

And navigate to:
http://localhost:8081/config.json#Home/showWifi/home
This prevents the page from refreshing because it's now part of the hash:

The last suggestion is a bit of an hack due to left over logic where we still parse query string parameters present in the hash we're routing to: https://github.com/rdkcentral/Lightning-SDK/blob/2b0d10e6d36ae9d855d8f0ac29e8eaccae807ebf/src/Router/utils/helpers.js#L124

If you update your configuration:
{
    path: 'home/:qs',
    component: Home
}

And navigate to:
http://localhost:8081/config.json#Home/?action=showWifi&wifiType=home
the parameters will be available to the page via:
set params(args){
    // args:  { action: 'showWifi', wifiType: 'home'}
}

Hi @erikhaandrikman!
Thanks for your detailed answer, I'll try it this way
Btw, just as a temporary solution, I've made it work like this (maybe someone will encounter the same issue and it could be a solution):
moveHashQueryToLocationSearch() {
    // get hash
    const hash = document.location.hash;

    // if it includes some query, then
    if (hash.indexOf("?") !== -1) {
      // read full url
      let url = document.location.href;
      // get existing search params
      const search = document.location.search;
      // get query from hash
      const hashQuery = hash.substring(hash.indexOf("?"));
      // remove found query from hash
      const cleanHash = hash.replace(hashQuery, "");
      // add 'hash query' to search params if there some
      const newSearch = search ? search + hashQuery.replace("?", "&") : hashQuery;

      // if query params exist, then
      if (search) {
        // remove query from hash
        url = url.replace(hashQuery, "");
        // update search params
        url = url.replace(search, newSearch);
      } else {
        // if there are no query params, then place hash query before the hash itself ("?query#hash)
        url = url.replace(hash, newSearch + cleanHash);
      }

      // if replaceState is available in browser, then replace it without reload, else just update the href with reload
      if (history.replaceState) {
        console.warn("history.replaceState is supported. No reload needed.");
        history.replaceState(null, null, url);
      }
      else {
        console.warn("history.replaceState not supported. Reloading page.");
        location.href = url;
      }
    }
  }

This method is called in index.js before the Launch function and Lightning Routing start. Maybe it's not the best solution, but at least it works as expected :)


How to get the concrete prediction results on the test data

Good work！But how to use the trained model to get the concrete prediction results on the test data

Hi @Moonlightxb ,
I believe you could directly obtain the model predictions as y_pred here.
Best,
Yu


document the load balancer chicken and egg problem better

@vikstrous commented on Thu Apr 28 2016
method 1:  one replica first

should use ip of vm if a vm
can use docker0 if local
pushes/pulls require first replica to be up
you still need to know what node you're installing on
-> you can reconfigure the replica after adding a load balancer

method 2: load balancer first

you need to use --ucp-node to make sure it's on the right node that's already in your load balancer
alternatively you can load balance over all ucp nodes and just let it pick whatever

Closing per triage discussion


npm install fails with python 3

If we're using pyenv and the global python is version 3, keytar fails to install.
><EMAIL_ADDRESS>install /Users/aparajita/.nvm/versions/node/v8.7.0/lib/node_modules/skpm/node_modules/keytar
> node-gyp rebuild

gyp WARN download NVM_NODEJS_ORG_MIRROR is deprecated and will be removed in node-gyp v4, please use NODEJS_ORG_MIRROR
gyp ERR! configure error
gyp ERR! stack Error: Command failed: /Users/aparajita/.pyenv/shims/python2 -c import platform; print(platform.python_version());
gyp ERR! stack pyenv: python2: command not found
gyp ERR! stack
gyp ERR! stack The `python2' command exists in these Python versions:
gyp ERR! stack   2.7.13
gyp ERR! stack
gyp ERR! stack
gyp ERR! stack     at ChildProcess.exithandler (child_process.js:271:12)
gyp ERR! stack     at emitTwo (events.js:125:13)
gyp ERR! stack     at ChildProcess.emit (events.js:213:7)
gyp ERR! stack     at maybeClose (internal/child_process.js:927:16)
gyp ERR! stack     at Socket.stream.socket.on (internal/child_process.js:348:11)
gyp ERR! stack     at emitOne (events.js:115:13)
gyp ERR! stack     at Socket.emit (events.js:210:7)
gyp ERR! stack     at Pipe._handle.close [as _onclose] (net.js:547:12)
gyp ERR! System Darwin 16.7.0
gyp ERR! command "/Users/aparajita/.nvm/versions/node/v8.7.0/bin/node" "/Users/aparajita/.nvm/versions/node/v8.7.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/aparajita/.nvm/versions/node/v8.7.0/lib/node_modules/skpm/node_modules/keytar
gyp ERR! node -v v8.7.0
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

well I can't really do anything here, that's super specific to your machine. Try to check why /Users/aparajita/.pyenv/shims/python2 doesn't exist?

It doesn't exist because pyenv hasn't created it. Ça c'est la guerre.


fix typo in lex_sql.l

What problem were solved in this pull request?
在lex_sql.l中，WHITE_SPACE被写成了WHITE_SAPCE

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Unable to run KLI command line - Unable to find libsodium

I have libsodium installed on my Mac and has added to the path, but I am getting an error of "Unable to find libsodium" when I run kli version.
$PATH
/opt/homebrew/bin:/opt/homebrew/sbin:/Library/Frameworks/Python.framework/Versions/3.11/bin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/Apple/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Users/andrewtan//opt/homebrew/Cellar/libsodium/1.0.18_1
Any advice on where I could have gone wrong?
Andy

Hi @andrewBSTan , I recently went through @kentbull excellent guide on my Mac and it worked the first time. I recommend it! https://kentbull.com/2023/03/09/keri-tutorial-series-treasure-hunting-in-abydos-issuing-and-verifying-a-credential-acdc/

@andrewBSTan if you did brew install libsodium then that is likely your problem. That never worked for me which is why I instructed my blog readers, as @2byrds mentioned, to install directly from a source tarball.
Here are the instructions repeated for your convenience:

Libsodium

https://libsodium.gitbook.io/doc/installation
On my MacBook Pro I ended up having to do the full installation:
Download a tarball from the releases page.
Change directories to within the decompressed tarball.

$ ./configure
$ make && make check
$ sudo make install

Thank you @kentbull , it works now that I install directly from the source per your advice.
Cheers.


Update/remove unused server timeout

There is no place to set timeout for server in rpclib

This change is

There is the possibility to set a time-out on the streaming server, but I don't think is very relevant, the streaming server continuously tries to reconnect, and its not related to the problems reported at #1501.


Merge digits-5.0 into master

Now that DIGITS 5.0 is officially released, here's the merge I've been putting off.

Dear Luke
I found error, while using python 3.5 like this in caffe_framework.py after i want to visualize the network (i used lenet for example)
Traceback (most recent call last):
File "C:\Users\MyPC\AppData\Local\Programs\Python\Python35\lib\site-packages\flask\app.py", line 1475, in full_dispatch_request
rv = self.dispatch_request()
File "C:\Users\MyPC\AppData\Local\Programs\Python\Python35\lib\site-packages\flask\app.py", line 1461, in dispatch_request
return self.view_functionsrule.endpoint
File "c:\digits\digits\webapp.py", line 82, in decorated
return f(*args, **kwargs)
File "c:\digits\digits\model\views.py", line 127, in visualize_network
ret = fw.get_network_visualization(flask.request.form['custom_network'])
File "c:\digits\digits\frameworks\caffe_framework.py", line 145, in get_network_visualization
caffe.draw.draw_net(net, 'UD').encode('base64') +
AttributeError: 'bytes' object has no attribute 'encode'
i tried to delete "encode" word after caffe.draw.draw_net(net, 'UD')+  and the result
Traceback (most recent call last):
File "C:\Users\MyPC\AppData\Local\Programs\Python\Python35\lib\site-packages\flask\app.py", line 1475, in full_dispatch_request
rv = self.dispatch_request()
File "C:\Users\MyPC\AppData\Local\Programs\Python\Python35\lib\site-packages\flask\app.py", line 1461, in dispatch_request
return self.view_functionsrule.endpoint
File "c:\digits\digits\webapp.py", line 82, in decorated
return f(*args, **kwargs)
File "c:\digits\digits\model\views.py", line 127, in visualize_network
ret = fw.get_network_visualization(flask.request.form['custom_network'])
File "c:\digits\digits\frameworks\caffe_framework.py", line 145, in get_network_visualization
caffe.draw.draw_net(net, 'UD')+
TypeError: Can't convert 'bytes' object to str implicitly
pls help me
Thx

@MyAusweis we don't support Python3: https://github.com/NVIDIA/DIGITS/issues/511