Popped route still exist in remove predicate while using navigator.pushAndRemoveUntil after await navigator.push

Steps to reproduce

Run the sample code
Click the middle button
Check console output

Expected results
flutter: route: page_two
Actual results
flutter: route: page_three
Code sample
Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key});

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  void _onPressed(BuildContext context) async {
    final navigatorState = Navigator.of(context);
     navigatorState.push(
      MaterialPageRoute(
        builder: (_) => const PageOne(),
        settings: const RouteSettings(name: 'page_one'),
      ),
    );
     navigatorState.push(
      MaterialPageRoute(
        builder: (_) => const PageTwo(),
        settings: const RouteSettings(name: 'page_two'),
      ),
    );
     navigatorState.push(
      MaterialPageRoute(
        builder: (_) => const PageThree(),
        settings: const RouteSettings(name: 'page_three'),
      ),
    );
    //Current route is [page_one, page_two, page_three]
    await Future.delayed(const Duration(seconds: 1));
    navigatorState.pop();
    //Current route is [page_one, page_two]
    navigatorState.pushAndRemoveUntil(
      MaterialPageRoute(
        builder: (_) => const PageOne(),
        settings: const RouteSettings(name: 'page_one'),
      ),
      (route) {
        // Expect output should be "route: page_two", but actual is "route: page_three",
        print('route: ${route.settings.name}');
        return true;
      },
    );
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        backgroundColor: Theme.of(context).colorScheme.inversePrimary,
      ),
      body: Builder(builder: (context) {
        return Center(
          child: TextButton(
            onPressed: () => _onPressed(context),
            child: const Text("Click Me", style: TextStyle(fontSize: 30),),
          ),
        );
      }),
    );
  }
}

class PageOne extends StatelessWidget {
  const PageOne({super.key});

  @override
  Widget build(BuildContext context) {
    return const ColoredBox(color: Colors.blue);
  }
}

class PageTwo extends StatelessWidget {
  const PageTwo({super.key});

  @override
  Widget build(BuildContext context) {
    return const ColoredBox(color: Colors.red);
  }
}

class PageThree extends StatelessWidget {
  const PageThree({super.key});

  @override
  Widget build(BuildContext context) {
    return const ColoredBox(color: Colors.yellow);
  }
}

Screenshots or Video

Screenshots / Video demonstration
[Upload media here]

Logs
Logs
[Paste your logs here]

Flutter Doctor output
Doctor output
[✓] Flutter (Channel stable, 3.24.1, on macOS 14.6.1 23G93 darwin-arm64, locale zh-Hans-CN)
    • Flutter version 3.24.1 on channel stable at /Users/tangkailiang/fvm/versions/3.24.1
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 5874a72aa4 (3 weeks ago), 2024-08-20 16:46:00 -0500
    • Engine revision c9b9d5780d
    • Dart version 3.5.1
    • DevTools version 2.37.2
    • Pub download mirror https://pub.flutter-io.cn
    • Flutter download mirror https://storage.flutter-io.cn

[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
    • Android SDK at /Users/tangkailiang/Library/Android/sdk
    • Platform android-35, build-tools 35.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)

[✓] IntelliJ IDEA Ultimate Edition (version 2024.2)
    • IntelliJ at /Applications/IntelliJ IDEA.app
    • Flutter plugin version 81.1.3
    • Dart plugin version 242.20629

[✓] VS Code (version 1.92.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.94.0

[✓] Connected device (5 available)
    • iPhone (mobile)                 • 00008120-001451993C90A01E            • ios            •
      iOS 17.5.1 21F90
    • iPhone 15 (mobile)              • 43BA2B9D-D219-4321-AD2D-EBAB3CC7B95E • ios            •
      com.apple.CoreSimulator.SimRuntime.iOS-17-5 (simulator)
    • macOS (desktop)                 • macos                                • darwin-arm64   •
      macOS 14.6.1 23G93 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad                • darwin         •
      macOS 14.6.1 23G93 darwin-arm64
    • Chrome (web)                    • chrome                               • web-javascript •
      Google Chrome 128.0.6613.120

[✓] Network resources
    • All expected network resources are available.

• No issues found!

As I understand it, you want to do that
push three routes
const routes = ['page_one', 'page_two', 'page_three']

pop()
const routes = ['page_one', 'page_two']

Then you want to call navigatorState.pushAndRemoveUntil with the predicate, but the route.setting.name is still returning the page_three which was already popped previously.
I can reproduce with your code at the version 3.24.0.

However, after I add 1 second delay between two pop method:

It returned the desired result. I believe the route setting will be updated somewhere after the pop animation is complete. I’m unsure whether this is a bug or a feature because the pop method is synchronous and causes asynchronous behavior.

As I understand it, you want to do that push three routes
const routes = ['page_one', 'page_two', 'page_three']

pop()
const routes = ['page_one', 'page_two']

Then you want to call navigatorState.pushAndRemoveUntil with the predicate, but the route.setting.name is still returning the page_three which was already popped previously.
I can reproduce with your code at the version 3.24.0.
However, after I add 1 second delay between two pop method:

It returned the desired result. I believe the route setting will be updated somewhere after the pop animation is complete. I’m unsure whether this is a bug or a feature because the `pop` method is synchronous and causes asynchronous behavior.

The sample code is a little complicated, below code shows a more common usage compared to sample code. In which I open a dialog and await its result, then I do pushAndRemoveUntil. But in pushAndRemoveUntil prdicate, the dialog still exist that not meet expection obviously.
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return const MaterialApp(
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key});

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {

  void _onPressed(BuildContext context) async {
    final navigatorState = Navigator.of(context);

    final result = await showDialog<bool>(
      context: context,
      routeSettings: const RouteSettings(name: 'dialog'),
      builder: (BuildContext context) {
        return AlertDialog(
          title: const Text('Confirm'),
          content: const Text('Do you want to proceed?'),
          actions: <Widget>[
            TextButton(
              onPressed: () {
                Navigator.of(context).pop(false);
              },
              child: const Text('No'),
            ),
            TextButton(
              onPressed: () {
                Navigator.of(context).pop(true);
              },
              child: const Text('Yes'),
            ),
          ],
        );
      },
    );

    navigatorState.pushAndRemoveUntil(
      MaterialPageRoute(
        builder: (_) => const PageOne(),
        settings: const RouteSettings(name: 'page_one'),
      ),
      (route) {
        // Expect output should be "route: null", but actual is "route: dialog",
        print('route: ${route.settings.name}');
        return true;
      },
    );
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        backgroundColor: Theme.of(context).colorScheme.inversePrimary,
      ),
      body: Builder(builder: (context) {
        return Center(
          child: OutlinedButton(
            onPressed: () => _onPressed(context),
            child: const Text(
              "Click Me",
              style: TextStyle(fontSize: 30),
            ),
          ),
        );
      }),
    );
  }
}

class PageOne extends StatelessWidget {
  const PageOne({super.key});

  @override
  Widget build(BuildContext context) {
    return Container(
      color: Colors.white,
      child: const Center(
        child: Text("page_one"),
      ),
    );
  }
}

@Samaritan123 Thanks for the report.
I didn't completely understand what should be the expected behavior. Upon trying your first code sample from issue description, if we comment out page_three MaterialPageRoute code block, the code properly shows page_two upon click me action.
From your above code sample, clicking on yes or no from dialog, takes me to page_one with console showing dialog, but not sure what should be the expected behavior here.

@Samaritan123 Thanks for the report. I didn't completely understand what should be the expected behavior. Upon trying your first code sample from issue description, if we comment out page_three MaterialPageRoute code block, the code properly shows page_two upon click me action. From your above code sample, clicking on yes or no from dialog, takes me to page_one with console showing dialog, but not sure what should be the expected behavior here.

For the second code example, I mean in the pushAndRemoveUntil predicate, the console should not output 'dialog' since I have already await the dialog poped and get its result before. The right behaviour I think is outputing something like "null" because current top most route is MyHomePage.

@Samaritan123 Maybe pushAndRemoveUntil isn't supported yet by the package per https://github.com/flutter/flutter/issues/144924 that you can check with underlying comments to see if they help ?
See if https://github.com/flutter/flutter/issues/144924#issuecomment-1992005534 helps in your case or not.

@Samaritan123 Maybe pushAndRemoveUntil isn't supported yet by the package per #144924 that you can check with underlying comments to see if they help ? See if #144924 (comment) helps in your case or not.

@darshankawar Thanks for your help, maybe you have a misunderstading for this issuse that I am not using the go_router package.  This issue is about Navigator 1.0 embbed in flutter sdk.

Thanks, yes, I noticed that. I will keep the issue open for team's tracking on the behavior reported.


fix: Update sandbox rules that target 10.13 exactly to target 10.13 and higher (backport: 2-0-x)

Description of Change
Backport https://chromium-review.googlesource.com/c/chromium/src/+/1200184/
Fixes HW video decoding not working when GPU process is sandboxed on macOS 10.14.
Follow up to https://github.com/electron/libchromiumcontent/pull/558
Checklist

[x] PR description included and stakeholders cc'd
[x] Patch information is added to appropriate .patches.yaml
[x] script/update runs without error
[x] PR title follows semantic commit guidelines

@nornagon it fixes HW video decoding not working when GPU process is sandboxed on macOS 10.14. Added link to the original PR to the description

@miniak 2-0-x is only getting security fixes now afaik, what is the priority for you to upstream this?

@MarshallOfSound any app playing streaming video using the <video> element on macOS 10.14 would be affected. Upstreaming the fix is not that critical for us, we have a local backport.


Roll Flutter Engine from 65f6fb841c7a to 6c1ff4dd28da (3 revisions)

https://github.com/flutter/engine/compare/65f6fb841c7a...6c1ff4dd28da
2023-09-07<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from N915IZbyx6MSrwwS-... to 33DToYd0jNpWX1jNv... (flutter/engine#45559)
2023-09-07<EMAIL_ADDRESS>Roll Skia from efd438ed1c06 to 17f36a6a101e (2 revisions) (flutter/engine#45557)
2023-09-07<EMAIL_ADDRESS>Roll ANGLE from cdbc45a9f37e to a412b149d5b1 (2 revisions) (flutter/engine#45556)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from N915IZbyx6MS to 33DToYd0jNpW
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Market creation save draft

Give user the ability to save multiple "draft" market creations.
store a structure in localStorage that keeps track of user inputs and where they are in the market creation process.
See design for table of draft market creations
When user clicks on an item it will hydrate the structure and put the user right where they were when they clicked "save draft" button
Question for design:
What is the label in the saved drafts scrollable component on the landing page? Looks like the market question. Just to clarify, if the user doesn't input a question they can't save a draft?
To help the user differentiate between saved drafts, allow them to put the label. Then they can save multiple versions of the market they are working on?

Yes it's the market question. If the user doesn't enter a question we can display a validation error that tells them what they need to do. I'll work on that tomorrow.
For the first version of the save feature I think we should keep it simple, you can only save one version of the market you're working on. If you save multiple times it just overrides the previous save.


test(S3BasicFileAttributes): When a timeout happens getting attributes of a regular file, an Exception should be thrown

Description of changes:
The PR introduces a test for S3BasicFileAttributes, when a timeout happens getting attributes of a regular file, an Exception should be thrown. In order to achieve this, and avoid having to wait 1 minute( the current default ) for the test to fail, the timeout is now configurable.
Coverage:

By the way, isn't 1 minute to high for a timeout? I imagine a user waiting up to 1 minute to get the size of a file would be too much and a bad user experience. I was thinking maybe 10 seconds would be a more sensible default. What are your thoughts @markjschreiber ?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Happy to contribute! What do you think about reducing the timeout for the attributes @markjschreiber ?

By the way, isn't 1 minute to high for a timeout? I imagine a user waiting up to 1 minute to get the size of a file would be too much and a bad user experience. I was thinking maybe 10 seconds would be a more sensible default.


smoothScrollToPosition(0) doesn't call callback

If I do .smoothScrollToPosition(0) on my list, the callback onUpOrCancelMotionEvent and onScrollChanged are not called.

邮件已收到


Module description is not as expected if submodules are included.

If we include submodules into the main yang module,   the main module description fecthed using Description() method is returning the description of the last included submodule.  I was expecting the description of the main module itself as  returned value.
Example:
Main module (module_core.yang):
module module_core {

	namespace "urn:params:module_core";
	prefix module_core;
	yang-version 1.1;

	include submodule_1;
	include submodule_2;
	description
	  "This is main module core";

	container testing {
		description
		  "testing container in main module";
		leaf cont1 {
			type string;
		}
		leaf cont2 {
			type int32;
		}
	}
}

Submodule 1 submodule_1.yang:
submodule submodule_1 {

	yang-version 1.1;

	belongs-to "module_core" {
		prefix "module_core";
	}
	description
	  "Submodule-1 with list";

	list root-list-submodule1 {
		leaf leaf-A {
			type string;
			default "Success";
		}
		leaf leaf-B {
			type new-type-submodule2;
		}
		uses the_only_group;
	}

	grouping the_only_group {
		leaf leaf-from-group {
			type new-type-submodule2;
		}
		leaf-list leaf-list-from-group {
			type string;
			default "ok";
		}
	}
}

submodule 2 submodule_2.yang:
submodule submodule_2 {

	yang-version 1.1;

	belongs-to "module_core" {
		prefix "module_core";
	}
	description
	  "Submodule-2 with typedef";

	typedef new-type-submodule2 {
		description
		  "New type definition";
		type uint16 {
			range "10 .. 2000";
		}
		default 100;
		units parrots;
	}
}

In the above example, after loading  module_core, i was expecting   module.Description()  to return "This is main module core" , but instead ,  it is returning "Submodule-2 with typedef"

Thank you for providing the fix in a seperate branch for the issue i reported.  Anyway i will wait for the complete fix in the master branch  which may have other extended fixes for potential issues related to submodules.
Thank you.


Error: The settings property 'DefaultEncoding' was not found.

Error
Error: The settings property 'DefaultEncoding' was not found.
OK
getting this error when opening the log file.
how to fix that?

Did you manage to fix that? Facing same issue

@mBednarz92  using .NET 5.0 or 4.5 version?

@mBednarz92 try grabbing the latest release here - I've updated it


[FSDE-939] Added support of HTML Select multiple for Column Customization sub-module of Data Table

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-74/1/. :white_check_mark:

You can check this PRs instance in https://4127e593127747334d849bba7e1bf5dcd9be33ac-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-74/1/. :white_check_mark:

You can check this PRs instance in https://23e914f4e492615c8f91349a42c6b767f9535b50-chi-pr.enterprise.ctl.io

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-74/2/. :white_check_mark:

You can check this PRs instance in https://2ccd41cc4c4ba7409361d100b04d9bfa37b739ed-chi-pr.enterprise.ctl.io

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-74/3/. :x:

The CI pipeline did not run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-74/4/. :x:

The CI pipeline run successfully in https://jenkinsprod.corp.intranet:8443/job/UX-CHI/job/Productive/job/Chi/job/PR-74/5/. :white_check_mark:

You can check this PRs instance in https://bca28e859756470075a6153bcbd5689bf81104cd-chi-pr.enterprise.ctl.io


Center slide horizontally at breakpoint

Issue description:
Just updated from v2.6.0 and noticed that the responsive behavior has changed from the active slide remaining centered to being left aligned at the breakpoint.
source markup:

        {{ testimonials_card }}

{{ heading }}

                        {{ quote | markdown }}
                        — {{ cite }}

                  {{ link_text }}

        {{ /testimonials_card }}

source js:
import { tns } from 'tiny-slider/src/tiny-slider.module'

const spacer = 16
const spacer2 = spacer * 2

const slider = tns({
  container: '[data-testimonial-slider]',
  controls: false,
  edgePadding: spacer,
  gutter: spacer,
  items: 1,
  mouseDrag: true,
  navContainer: '[data-testimonial-slider-nav]',
  slideBy: 'page',
  speed: 600,

  responsive: {
    720: {
      edgePadding: spacer,
      fixedWidth: (spacer * 45) - (spacer2 * 2),
    },
  },
})

export default slider

Production markup producing desirable behavior via<EMAIL_ADDRESS>

...

Production markup producing undesirable behavior via<EMAIL_ADDRESS>

...

From what I can tell the the margin style is no longer being applied to the element #tns1-iw element. Was there a new method for centering slides that undocumented?
Demo link/slider setting:
Left align (undesirable) behavior:

Centered (desirable) behavior: https://www.activecampaign.com/
Tiny-slider version:
2.8.6
Browser name && version:
Chrome Version 68.0.3440.106
OS name && version:
macOS High Sierra 10.13.6

Sorry for the confusion, but the original gutter feature is not correctly implemented. It added gutter on both sides and also center the active slide.
I plan to add a new center option so the 2 features are not mixed.

Any news about this bug? some workaround?

x2

I'm working on it.

Thank you for fixing this.
The Horizontal center is ok, but the paging is wrong.
Please check here: https://codepen.io/nunoguerra/pen/mQBeML

@nunoguerra Paging issue is fixed in this commit

center feature was added in v2.9.0. I will close this issue.
Please open ones if some center related issues are discovered.
Thank you


ILS Session Persistence and App gateway Sticky sessions

Hi,
The ILB provides only none or session persistence : Client IP and CLientIP+port
When working with App gateway, we can enable it as a SSL endpoint. So sessions will terminate at the App Gateway level, and new sessions will be opened by App Gateway to the ILB. In this case, the LB will see the same source IP. In case of persistence (IP ), all traffic will be send to the same back-end host. If we disable persistence, the traffic will be round-robined, and we will have issues with Sticky Sessions.
So i think, that you should mention that we need to enable Session Persistence : IP + Port

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e30dfd76-2a83-bd21-2153-85e32894014e
Version Independent ID: 9dca62e8-0aef-10eb-b2d3-2ab12087f90a
Content: Integrate your ILB App Service Environment with the Azure Application Gateway
Content Source: articles/app-service/environment/integrate-with-application-gateway.md
Service: app-service
GitHub Login: @ccompy
Microsoft Alias: ccompy

Thanks for your dedication to our documentation. Unfortunately, at this time we have been unable to review your issue in a timely manner and we sincerely apologize for the delayed response. We are closing this issue for now, but if you feel that it's still a concern, please respond and let us know. If you determine another possible update to our documentation, please don't hesitate to reach out again. #please-close


As always , code doesn't work

Expected Behavior
Noone knows since your code never ran successfully.
Ipynbk in question: https://github.com/GoogleCloudPlatform/vertex-ai-samples/blob/main/notebooks/official/generative_ai/rlhf_tune_llm.ipynb
Actual Behavior
ValueError: eval_dataset not supported for text-bison@001. Please set this value to None when tuning this model. This model can be evaluated after tuning using Batch or Online Prediction.
Steps to Reproduce the Problem

Just run each code block like a normal human would

@sidoncloud Thanks for letting us know! We're reworking the RLHF pipeline a bit and temporarily disabled the eval_dataset for first-part models. I just opened #2700, so we don't get validation errors in the meantime.

Merged #2700 to mitigate validation errors


retro compatibility before 4.08, no deps on base/stdio

not everyone uses as recent a  compiler as 4.08, and base/stdio just for configuring the build seems a bit heavyweight to me.

Seems fair enough, I have merged your changes.  Thanks for the patch!  I'm still waiting for some feedback on other changes in the development branch, but expect that a release is imminent.

shoot, seems I forgot to remove the deps in the opam file. Do you want me to make a PR to remove the build deps from opam?

Thanks, I've missed this, too.  I've submitted a PR to the OPAM repository removing the two dependencies (base and stdio) .  Btw., the OPAM file is derived from dune-project now.


Job Arguments not working

Environment:
Graylog 2.2.2 (Linux - Java 8)
It is not possible to pass arguments from graylog to rundeck using the rundeck alarm callback.
For example it is simply impossible to pass the full message from graylog as an argument.

@MarkusEckerl Which version of Graylog, which version of this plugin, and which version of Rundeck are you using?

Hi,
thank you for this fast answer.
Graylog: 2.2.2+691b4b7 (the last one..)
Plugin: 1.1.1
Rundeck: 2.7.1-1
Am 06.03.2017 um 16:37 schrieb Jochen Schalanda:

@MarkusEckerl https://github.com/MarkusEckerl Which version of
Graylog, which version of this plugin, and which version of Rundeck
are you using?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Graylog2/graylog-plugin-rundeck/issues/4#issuecomment-284432109,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AZAcVz4yvMb8KdPjrzG6nb-3O9SwjE5zks5rjChJgaJpZM4MUCOC.

@MarkusEckerl How exactly did you configure the Rundeck plugin and what's the definition (XML or YAML) of the Rundeck job?
Also, did you see the "Field arguments" setting of the Rundeck plugin? This basically can be used to pass any message field as job parameter named like the field (e. g. the "full_message" parameter would include the value of the "full_message" field).

Hello @joschi and @MarkusEckerl,
I'm facing same issue, my graylog server is 2.2.3 with your plugin in version 1.2.1 and Rundeck 2.8.2.
My callback is configured like:

and the job is well called by Graylog but the value is the variable instead of the real value of message field "param1":
In rundeck:

In Graylog:

Thank you for your support.

@FireHelmet That's pretty much working as intended. The "Job arguments" field doesn't support templating, so your configuration will literally send ServiceDisplayName:${message.param1} to your Rundeck job.
See https://github.com/graylog-labs/graylog-plugin-rundeck/blob/1.2.1/README.md#job-arguments for details.

@joschi,
Thank you for your answer but I don't understand completely. Could you write an example of each option (job arguments and field arguments ) ? Because I have also tried some other syntax but without sucess.
Thanks again ! And thank you for this plugin !

@FireHelmet We are using GitHub issues for tracking bugs in Graylog itself, but this doesn't look like one. Please post this issue to our discussion forum or join the #graylog channel on freenode IRC.
Thank you!

@joschi
I have tested like you have requested on IRC but the field sent to Rundeck appear blank when is it executed by Rundeck. How can I send you some logs or anything can help you to debug this ?
I really need this option :). In addition, I can do some tests if it's requested :)
Thank you

@joschi
As requested on IRC, I'm posting some additionnal informations:
My Graylog message with the field "param1" (I need to pass the content of this field to rundeck):

My Graylog Alert notification config:

My rundeck job definition:

The job is correctly called by graylog:

But the content field via Rundeck is blank !:

Could you help ?
Thank you,

@joschi
I have found, it's working well now !
On graylog, you need to send the backlog message when an alert is triggered. So,

Open your alert condition
Write "1" in message backlog field:

Save

Joschi, please, could you modify the Readme of your plugin to include this information because it's a requirement.
Thanks !


make build pipline job run parallel?

Is your feature request related to a problem? Please describe.
not related to product, it's about build pipeline, I noticed jobs are running sequential and very slow, can we make them run parallel?
Describe the solution you'd like
update build pipeline yaml file to add stages and make jobs run parallel.
Additional context
change the pipeline run to something like this:

Hi @dylanw-oss our jobs do run in parallel, if you take a look at our devOps pipeline, they start at the same time and run un parallel.


Add Feature for Importing Local Testcase

Local Folder Test Case Import
If you have test cases stored locally in a folder (with .in files for inputs and .sol files for outputs), you can bypass logging into NatteeGrader by using the --folder argument.
Each test case file pair should follow the naming convention x.in for input and x.sol for the expected output, where x is a numeric identifier for the test case.
Example Usage:
# Use this command to create test cases from a local folder
python ntscraper.py ./file.cpp --folder ./path_to_test_cases_folder

Example Local Test Case Folder Structure:
path_to_test_cases_folder
├── 1.in
├── 1.sol
├── 2.in
├── 2.sol

@Kentakoong can you explain the PR in description better?
what does features you added do

OK I've read the readme, but please put it in the PR detail too since it's easier to keep track.
Thanks

OK I've read the readme, but please put it in the PR detail too since it's easier to keep track. Thanks

finished, added that now.


Error in NGTDM documentation

Hi!
Thanks a lot for Pyradiomics software!
Just a message in order to highlight is a small mistake in the NGTDM documentation.
In the example matrix, it's written:
s3=|3−14/5|+|3−18/5|+|3−20/8|+|3−5/3|=2.63
Whereas the truth is:
s3=|3−12/5|+|3−18/5|+|3−20/8|+|3−5/3|=3.03
And so in the corresponding NGTDM.
It's quite nothing but it might be confusing.
Sincerely,
Loïc

Fixed by ea9a6ce6efd2ebfd4229e8070f72eef382c590bd


is possible to check if a Lua Sprite exist?

Describe your problem here.
heya :D, im actually doing a script for a mods and i need to know if is it possible to check if a certain lua Sprite exist and how to use it, i already sheerch in the doc and i can't find anything.
thanks for your futur help :D
Are you modding a build from source or with Lua?
Lua
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
nop, im just doing LUA script and other things

if luaSpriteExists('sprite') then
-- do shit
end

i already try that and its not working

i already try that and its not working

well then it's clearly something you're doing wrong, maybe outdated psych version or invalid sprite?


No such file or directory error

I was trying to find a K value that would make my program run. It's a simple merkle verifier, which hardcodes both params since I haven't yet converted them to inputs:

Click for source code
use std::convert::TryInto;

use rs_merkle::algorithms::Sha256;
use rs_merkle::{Hasher, MerkleProof};
use wasm_bindgen::prelude::*;

// root and proof for the following tree:
// ["a", "b", "c", "d"]
const ROOT: &str = "14ede5e8e97ad9372327728f5099b95604a39593cac3bd38a343ad76205213e7";
const PROOF: &str="2e7d2c03a9507ae265ecf5b5356885a53393a2029d241394997265a1a25aefc6e5a01fee14e0ed5c48714f22180f25ad8365b53f9779f79dc4a3d7e93963f94a";

// src/lib.rs
#[wasm_bindgen]
pub fn merkle() -> i64 {
    let leaf_values = ["a", "b", "c", "d"];
    let leaves: Vec<[u8; 32]> = leaf_values
        .iter()
        .map(|x| Sha256::hash(x.as_bytes()))
        .collect();

    // decode root
    // this would be internal state
    let root: [u8; 32] = hex::decode(ROOT).unwrap().try_into().unwrap();

    // leaves to decode
    // this would be an input
    let indices_to_prove = vec![3];
    let leaves_to_prove = leaves.get(3..).ok_or("can't").unwrap();

    // decode proof
    // this would be an input
    let proof_bytes = hex::decode(PROOF).unwrap();
    let proof = MerkleProof::<Sha256>::from_bytes(proof_bytes.as_slice()).unwrap();

    assert!(proof.verify(root, &indices_to_prove, leaves_to_prove, leaves.len()));
    0
}

# Cargo.toml
[package]
name = "zkwasm-merkle"
version = "0.1.0"
edition = "2021"

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[lib]
crate-type = ["cdylib"]

[dependencies]
hex = "0.4.3"
rs_merkle = { git = "https://github.com/naps62/rs-merkle", branch = "no-float"}
wasm-bindgen = "0.2.83"

# justfile
wasm := "pkg/zkwasm_merkle_bg.wasm"
cli := "../../DelphinusLab/zkWasm/target/release/cli"
args := "-k 22 --function merkle --output ./output --wasm " + wasm
proof := "output/zkwasm.0.transcript.data"
public_input := "5:i64"

cpulimit := "cpulimit --foreground --cpu=12 --limit 1200 --monitor-forks --"

build:
  wasm-pack build --release

# skipped if zkwasm.0.vkey.data is up-to-date
setup:
  {{cpulimit}} {{cli}} {{args}} setup

# skipped if zkwasm.0.vkey.data is up-to-date
run:
  {{cpulimit}} {{cli}} {{args}} single-prove

verify:
  {{cpulimit}} {{cli}} {{args}} single-verify --proof {{proof}}

bench:
  #!/bin/bash -ue
  rm -rf output
  just build

  t1=`date +%s`
  just setup
  t2=`date +%s`
  just run
  t3=`date +%s`
  just verify
  t4=`date +%s`

  setup_time=$((t2-t1))
  run_time=$((t3-t2))
  verify_time=$((t4-t3))

  echo "setup: $setup_time"
  echo "run: $run_time"
  echo "verify: $verify_time"

This is the output of just bench when running with k<22:
❯ j bench
wasm-pack build --release
[INFO]: Checking for the Wasm target...
[INFO]: Compiling to Wasm...
    Finished release [optimized] target(s) in 0.01s
[WARN]: :-) origin crate has no README
[INFO]: Installing wasm-bindgen...
[INFO]: found wasm-opt at "/usr/bin/wasm-opt"
[INFO]: Optimizing wasm binaries with `wasm-opt`...
[INFO]: Optional fields missing from Cargo.toml: 'description', 'repository', and 'license'. These are not necessary, but recommended
[INFO]: :-) Done in 0.55s
[INFO]: :-) Your wasm pkg is ready to publish at /home/naps62/lightshift/odsy/zkwasm-test/merkle/pkg.
cpulimit --foreground --cpu=12 --limit 1200 --monitor-forks -- ../../DelphinusLab/zkWasm/target/release/cli -k 21 --function merkle --output ./output --wasm pkg/zkwasm_merkle_bg.wasm setup
Process 41536 detected
write params K=21 to "./output/K21.params"
quotient_poly_degree 8
write vkey to "./output/zkwasm.0.vkey.data"

write params K=23 to "./output/K23.params"
Child process is finished, exiting...
cpulimit --foreground --cpu=12 --limit 1200 --monitor-forks -- ../../DelphinusLab/zkWasm/target/release/cli -k 21 --function merkle --output ./output --wasm pkg/zkwasm_merkle_bg.wasm single-prove
Process 44666 detected
thread 'main' panicked at 'assertion failed: (etable.entries().len() + 1) * ETABLE_STEP_SIZE <= max_etable_rows() as usize', src/circuits/etable_compact/assign.rs:16:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Child process is finished, exiting...
cpulimit --foreground --cpu=12 --limit 1200 --monitor-forks -- ../../DelphinusLab/zkWasm/target/release/cli -k 21 --function merkle --output ./output --wasm pkg/zkwasm_merkle_bg.wasm single-verify --proof output/z
kwasm.0.transcript.data
Process 44683 detected
read params K=21 from "./output/K21.params"
read vkey from "./output/zkwasm.0.vkey.data"
quotient_poly_degree 8
read transcript from "output/zkwasm.0.transcript.data"
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', /home/naps62/.cargo/git/checkouts/halo2aggregator-s-4591bb34d62c1163/0
b89113/src/circuits/utils.rs:140:51
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Child process is finished, exiting...
setup: 767
run: 20
verify: 12

My assumption here was that 'assertion failed: (etable.entries().len() + 1) * ETABLE_STEP_SIZE <= max_etable_rows() as usize' was maybe due to k being too low, so I kept increasing.
Once I try with k=22, I get a different output. it seems single-prove step now works, but I still get a "No such file" when verifying:
❯ j bench
wasm-pack build --release
[INFO]: Checking for the Wasm target...
[INFO]: Compiling to Wasm...
    Finished release [optimized] target(s) in 0.01s
[WARN]: :-) origin crate has no README
[INFO]: Installing wasm-bindgen...
[INFO]: found wasm-opt at "/usr/bin/wasm-opt"
[INFO]: Optimizing wasm binaries with `wasm-opt`...
[INFO]: Optional fields missing from Cargo.toml: 'description', 'repository', and 'license'. These are not necessary, but recommended
[INFO]: :-) Done in 0.52s
[INFO]: :-) Your wasm pkg is ready to publish at /home/naps62/lightshift/odsy/zkwasm-test/merkle/pkg.
cpulimit --foreground --cpu=12 --limit 1200 --monitor-forks -- ../../DelphinusLab/zkWasm/target/release/cli -k 22 --function merkle --output ./output --wasm pkg/zkwasm_merkle_bg.wasm setup
Process 45110 detected
write params K=22 to "./output/K22.params"
quotient_poly_degree 8
write vkey to "./output/zkwasm.0.vkey.data"
write params K=23 to "./output/K23.params"
Child process is finished, exiting...
cpulimit --foreground --cpu=12 --limit 1200 --monitor-forks -- ../../DelphinusLab/zkWasm/target/release/cli -k 22 --function merkle --output ./output --wasm pkg/zkwasm_merkle_bg.wasm single-prove
Process 54125 detected
read params K=22 from "./output/K22.params"
read vkey from "./output/zkwasm.0.vkey.data"
quotient_poly_degree 8
Start:   generate pkey
Child process is finished, exiting...
cpulimit --foreground --cpu=12 --limit 1200 --monitor-forks -- ../../DelphinusLab/zkWasm/target/release/cli -k 22 --function merkle --output ./output --wasm pkg/zkwasm_merkle_bg.wasm single-verify --proof output/z
kwasm.0.transcript.data
Process 56644 detected
read params K=22 from "./output/K22.params"
read vkey from "./output/zkwasm.0.vkey.data"
quotient_poly_degree 8
read transcript from "output/zkwasm.0.transcript.data"
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', /home/naps62/.cargo/git/checkouts/halo2aggregator-s-4591bb34d62c1163/0
b89113/src/circuits/utils.rs:140:51
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Child process is finished, exiting...
setup: 951
run: 411

Recently, we've updated halo2aggregator-s' main branch which may break previous zkWasm build. To fix it, we have update'd zkWasm's dependency for halo2aggregator-s (to a specific commit 922f265c5990a69fcbaa9f5ffc94cd3d644cb84f). Please try to checkout newest zkWasm version and regenerate vkey. Sorry for inconvenience.

Another idea is try to change --proof output/z kwasm.0.transcript.data to --proof ./output/z kwasm.0.transcript.data for workaround. We will keep this issue to track the bug.

An observation is that
Process 54125 detected
read params K=22 from "./output/K22.params"
read vkey from "./output/zkwasm.0.vkey.data"
quotient_poly_degree 8
Start:   generate pkey
Child process is finished, exiting...

The child process quit without full log message. So I guess the process doesn't finish it work before it exits. Currently K=22 requires a lot of memory. Could you just run ../../zkWasm/target/release/cli -k 22 --function merkle --output ./output --wasm pkg/zkwasm_merkle_bg.wasm single-prove to check it behaviour?


Unable to access KV from ASP.NET Core application

This issue is a: (mark with an x)

[x] bug report -> please search issues before submitting
[ ] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Issue description
I have a ASP.NET Core application running on Azure Container Instance and uses KV to fetch some secrets by using the configuration provider. The container instance is configured to use a user-assigned managed identity.
Running the same container in ACA with the same managed identity fails to start because the application is unable to access KV.
Steps to reproduce
Here are some Terraform constructs used to define the different parts. Since I'm copying from different areas, names might not match.
resource "azurerm_user_assigned_identity" "this" {
  resource_group_name = var.resource_group.name
  location = var.resource_group.location
  name = "usi-${module.namer.base_name}-001"
}

resource "azurerm_key_vault" "secrets" {
  // ####

  access_policy {
    tenant_id = azurerm_user_assigned_identity.this.tenant_id
    object_id = azurerm_user_assigned_identity.this.principal_id

    key_permissions = ["Get", "WrapKey", "UnwrapKey"]

    secret_permissions = ["Get", "List"]
  }

  // ###
}

resource "azurerm_log_analytics_workspace" "backend" {
  name                = "law-${module.namer.base_name}-001"
  resource_group_name = azurerm_resource_group.this.name
  location            = azurerm_resource_group.this.location
  sku                 = "PerGB2018"
  retention_in_days   = 30
}

resource "azurerm_container_app_environment" "backend" {
  name                = "env-${module.namer.base_name}-001"
  resource_group_name = azurerm_resource_group.this.name
  location            = azurerm_resource_group.this.location

  log_analytics_workspace_id = azurerm_log_analytics_workspace.backend.id
}

locals {
  container_environment_variables = {
    "ConnectionStrings__Database"                = "something"
    # "AZURE_CLIENT_ID"                            = azurerm_user_assigned_identity.this.principal_id
    "ConnectionStrings__AzureKeyVault"           = azurerm_key_vault.secrets.vault_uri
    "ASPNETCORE_ENVIRONMENT"                     = module.dotnet_environment.name
    "ASPNETCORE_LOGGING__CONSOLE__DISABLECOLORS" = "true"
  }
}

resource "azurerm_container_app" "backend" {
  name                         = "capp-${module.namer.base_name}-001"
  container_app_environment_id = azurerm_container_app_environment.backend.id
  resource_group_name          = azurerm_resource_group.this.name
  revision_mode                = "Single"

  template {
    min_replicas = 1
    container {
      name   = "service"
      image  = "${data.terraform_remote_state.cloud_ops.outputs.container_registry_login_server}/${local.application}/api:latest"
      cpu    = 1.0
      memory = "2Gi"

      liveness_probe {
        path             = "/_health"
        port             = 8080
        transport        = "HTTP"
        initial_delay    = 10
        interval_seconds = 30
      }

      dynamic "env" {
        for_each = local.container_environment_variables
        content {
          name  = env.key
          value = env.value
        }
      }
    }
  }

  registry {
    server   = data.terraform_remote_state.cloud_ops.outputs.container_registry_login_server
    identity = azurerm_user_assigned_identity.this.id
  }

  ingress {
    target_port      = 8080
    external_enabled = true
    traffic_weight {
      percentage      = 100
      latest_revision = true
    }
  }

  identity {
    identity_ids = [azurerm_user_assigned_identity.this.id]
    type         = "UserAssigned"
  }
}

resource "azurerm_role_assignment" "containerapp" {
  scope                = data.terraform_remote_state.cloud_ops.outputs.container_registry_id
  role_definition_name = "acrpull"
  principal_id         = module.api.service_identity.principal_id

  depends_on = [module.api]
}

And this is the snippet used in my ASP.NET Core 8 RC2 app to access the KV.
if (builder.Configuration.GetConnectionString("AzureKeyVault") is { } vaultUrl)
{
    builder.Configuration.AddAzureKeyVault
    (
        new Uri(vaultUrl),
        new DefaultAzureCredential()
    );
}

This works correctly in ACI.
Expected behavior [What you expected to happen.]
Be able to access a KV vault from my ASP.NET Core application using the configuration provider.
Actual behavior [What actually happened.]
The revision is not provisioned and removed. These are some entries in the console log of the revision.
Unhandled exception. Azure.Identity.AuthenticationFailedException: ManagedIdentityCredential authentication failed: Service request failed.

---> Azure.RequestFailedException: Service request failed.
Status: 400 (Bad Request)

Update:
Adding an environment variable called AZURE_CLIENT_ID set to the value azurerm_user_assigned_identity.this.client_id solved the issue. I can't find the page now, but there was a page suggesting to use the principal id value for the environment variable. That didn't work.

@Kralizek you have to specify the client ID when using a user-assigned managed identity. new DefaultAzureCredential() without any parameters will try to use a system-assigned identity and will fail if it's not there.
See here for more info: https://learn.microsoft.com/en-us/dotnet/api/overview/azure/identity-readme?view=azure-dotnet#specify-a-user-assigned-managed-identity-with-defaultazurecredential

Adding the AZURE_CLIENT_ID environment variable fixed the issue. Since the container app has an identity attached, I was expecting the system to take care of providing what's needed for the application to use the identity to make calls to Azure services.
I recently started working with Azure after years at AWS and I had the conceptual map managed identities are the equivalent of the IAM execution role assigned to an instance or a container. Under that assumption, as mentioned, I was expected that either the environment was providing the credentials needed or the SDK could fetch them short-lived ones.


Preserve the most recent etcd backup file

I have run into a case where there were two etcd live snapshot files in /var/etcd. This command copies the most recent version.

passing to @xiang90 for review.


Text Extractor moves blocks of text

Microsoft PowerToys version
0.78.0
Installation method
Microsoft Store
Running as admin
No
Area(s) with issue?
TextExtractor
Steps to reproduce
When capturing text from inside a FireFox tab, from a YouTube, SOMETIMES the lead characters are moved to the end ...
https://
/jsrailton/status/1762875069682852143
twitter.com
Note "twitter.com" was moved
I have to cut and paste it back into the right place
It seems to be affected by the size of the window I'm capturing from. If I resize it, the capture works correctly. But resizing is not on!
✔ Expected Behavior
https://twitter.com/jsrailton/status/1762875069682852143
❌ Actual Behavior
https://
/jsrailton/status/1762875069682852143
twitter.com

Other Software
No response

This is an issue with the underlying OCR engine. You can use the Single Line Mode (or press S before selecting a region) which will move all of the OCR'd text into a single line.

Not closed for me.
I looked at the help for the PowerToy, and the git hub for the tool it was
based on. There is no mention of this "single line mode".  Could the
help/documentation be updated to describe this mode and others.
On Mon, Mar 4, 2024 at 2:30 PM Joseph Finney @.***>
wrote:

This is an issue with the underlying OCR engine. You can use the Single
Line Mode (or press S before selecting a region) which will move all of the
OCR'd text into a single line.
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerToys/issues/31643#issuecomment-1977401669,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BGSLTVIYYXMXW56GZM2BAQTYWTKWZAVCNFSM6AAAAABEBA42VWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZXGQYDCNRWHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

I will look into update the documentation. Try using this button in the Text Extractor top bar:

Thanks for the tip. Finally got a chance to try it.  It helps.
First time I tried clicking on the button completely cleared the problem.
Then I tried it 2 more times to paste here. The results were better than
the result that triggered me to try, but not as good a first time that
prompted this reply.
It suggests to me that the selection box is very "fussy", slightly
different selections, nominally all excluding excess text and graphics,
generates different, "not good" results ... This also probably could/should
be noted in the documentation. Include examples ...
[image: image.png]
"C"
https%/twitter.com/sambend ett/sta tus/1765044692465389897
Button  on UI
https:,//twitter.com/s ambendett/status/1765044692465389897
On Tue, Mar 5, 2024 at 11:47 AM Joseph Finney @.***>
wrote:

I will look into update the documentation. Try using this button in the
Text Extractor top bar:
image.png (view on web)
https://github.com/microsoft/PowerToys/assets/7809853/3f57ece8-eb27-4b93-b938-9109fcd72928
—
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerToys/issues/31643#issuecomment-1979314846,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BGSLTVN6OKIPSYGAW3OQPRLYWYAMRAVCNFSM6AAAAABEBA42VWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZZGMYTIOBUGY
.
You are receiving this because you authored the thread.Message ID:
@.***>


[MINOR][DOCS] Fix type hint of 3 functions

What changes were proposed in this pull request?
Fix type hint of 3 functions
I did a quick scan of the functions, don't find other similar places.
Why are the changes needed?
a string input will be treated as literal instead of column name
Does this PR introduce any user-facing change?
no
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no

thank you @dongjoon-hyun for reviews


Define datetime predicates

Implements a set of predicates for the DateTime field, including:

Year
Month
Day
Hour
Month exclusive
Day exclusive
Hour exclusive

The expected behavior of these predicates are outlined in the new predicate tests in tests/test_datetime_comparator.py. In general, we return tuples with integer values for the given resolution, e.g. monthPredicate('June 2nd 2017') returns the tuple (2017, 6).
Note that the parser will return an empty string for a given date resolution if that resolution is not present in the string (e.g. the parsed version of 'June 2nd 2017' will have an hour value of ''). This means that there can be mixed types in the returned tuples. If this is a problem, we can alter the behavior to return NoneTypes for absent resolutions, or we can universally return strings for date values instead of integers (e.g. ('2017', '6') rather than (2017, 6)).

lgtm


Injury Tolerance: Unliving hit location modifiers do not match the GURPS: Zombies clarification

The damage calculator doesn't incorporate the clarifications from Zombies (page 110) of the interaction between the Unliving advantage and the various hit locations (IE Unliving doesn't include No Brain so everything [except toxic] still does x4 on Skull hits, but in the damage calculator Unliving still decreases certain damages from x4 to the reduced Torso damage.)

Fixed with issue #815


Topic/find multiple criteria

change first to find
find now takes a hash of search criteria and returns a registry with the subset items
registry indexes point to sets instead of lists
anchor regex
clean up and add specs
add custom matcher support for registry inspection

Looks great!


No completions for generic object with string literal union types

Bug Report

🔎 Search Terms

Autocompletion, completions, missing, generics, object, string literals unions, etc.

🕗 Version & Regression Information

This is the behavior in every version I tried, and I reviewed the FAQ for entries about Generics

⏯ Playground Link

https://tsplay.dev/WGdLJw
💻 Code

type Test<
  T extends {
    example: "yes" | "no";
  }
> = T["example"];

const foo: Test<{ example: "" }> = "yes";
//                         ^^ <- No completions available here.
//                               As a string literal there should be concrete completions for "yes" | "no".

//                               The compiler does however recognize the correct type with type error:
//                               `Type '{ example: ""; }' does not satisfy the constraint '{ example: "yes" | "no"; }'.`

🙁 Actual behavior
There are no type completions hints for string literal unions inside generic objects.
🙂 Expected behavior
There should be type completion hints with the appropriate type variants. In the example above, with the completions should be yes and no.

Duplicate of https://github.com/microsoft/TypeScript/issues/52898

That definitely is a worthy duplicate, sorry I couldn't find it before creating this 😞
Shall I close this issue?

I'd close it - since it so closely relates to that other issue.

Duplicate


Breaks edition.cnn.com

To get it to work again, You need to disable Hush and then restart CNN from a new tab / window. The block remains in the old one even if it is refreshed.

Sorry for my late reply. My privacy was violated. Can you help me keep my account secure and private? Thank you


Named parameters for constructors should have autocomplete suggestions

We use a lot of named parameters in Sky.  It would be nice if the dartlang would suggest the names of the named parameters so we don't have to memorize them.

@danrubel, is there an issue tracking this in the sdk repo?

Should already be in there. After the last required param, if you put a comma then ctrl-space, you should receive a list of named param suggestions in amongst all the other suggestions. If this is not the case, please let me know and I'll dig.

Maybe it doesn't work for named arguments to constructors?  For example,
import 'package:sky/widgets.dart';
new EdgeDims.symmetric(
ctrl-space doesn't show the named arguments.

It does seem to work for functions but not constructors.

Blocked on https://github.com/dart-lang/sdk/issues/24004.

The AS issues has been fixed; this will be available in the next dev SDK (~2 weeks).


Support in cloud controller for enabling mTLS for syslog-drains

Issue
Currently, connections created by syslog-agents in Cloud Foundry only support TLS and HTTPS transport protocols for syslog drains without client certificate authentication. To protect the server from malicious syslog senders, it is only possible to filter the syslog sender according to the source ip-address or use basic auth when registering https drains.
Context
We have created a proposed solution to the issue as an issue in the loggregator-agent-release. Most changes would needed to be done there, but a part of it would need to be done in the internal syslog_drain_urls endpoint of the cloud controller. Therefore we create this issue here in order to invite cloud controller devs to look into  and comment on the proposal, and to refer to it in upcoming PRs to this repo.
Possible Fix
Please see https://github.com/cloudfoundry/loggregator-agent-release/issues/97

PR: https://github.com/cloudfoundry/cloud_controller_ng/pull/2903

#2903 was merged by @philippthun. I suggest that we close this issue.


Modularization WIP notes

As I'm looking into rewrite, I need some place to sketch notes.

[x] Merge #625
[x] Split fedimintd into it's own crate
[x] moved tiered* to api
[x] move the fedimint-core-api into feidmint-api; they have be together for Decodable reasons #816
[x] move the bound M : ModuleDecoder to the function
[x] create fedimint-testing and move the rpc + retrying code into it; make it impossible to use raw bitcoincore_rpc::Client anywhere
[x] change BatchTx to DBTransaction in all module APIs
[x] unify FedimintModule Error types to be abstract (not pick impl details from the module)
[x] refactor configgen to be abstract (use serde_json::Value instead of using module-specific types) (branch: modularize-configgen)
[x] wrap all trait associated type implementation types into clearly named newtypes

We probably will not do these after all:

[ ] move existing modules into fedimint-api to get out of cyclic dependency trap
[ ] turn associated types (output/input/consensusitem) on FederationModuleinto enums, making the trait trait-safe
[ ] add module registry and use dyn-newtype for modules
[ ] turn the output/input/consensusitem enums into proper dyn-newtypes, this might require some ability to convert them back to enum for the client for now
[ ] move the modules out of fedimint-api again

Off-topic:

[x] pass TaskHandle to bitcoincore_rpc retry.

Eric took over modularization and by now most of this stuff is probably done.


[joy-ui][docs] Change the design kit link on the Overview page

[x] I have followed (at least) the PR section of the contributing guide.

Linking to the Store "MUI for Figma" design kit listing isn't a good landing place for the Joy UI Figma file link on the Overview page. It's not immediately clear how to actually access the Figma file; visitors would need to scroll down until they see — the fairly hidden — Community file link... which is where I think we can link directly.
👉 https://deploy-preview-39725--material-ui.netlify.app/joy-ui/getting-started/#start-now

It makes sense, and I resonate with you on almost everything. However, I wonder if we shouldn't include somewhere in the card the information that it's actually linking to the community file, the free version. Though this approach is better, I wonder if users will be aware that there's a premium and full version available.


Rename the BackgroundHelper class to ColorHelper

This pull request renames and repackages the BackgroundHelper class as it is used for general color math on both clients and servers.
Fixes #2907

Potentially impactful.

This seems quite impactful, searching github shows its used in quite a few places;
https://github.com/search?l=Java&q=net.minecraft.client.gui.hud.BackgroundHelper&type=Code


Single Page Menu missing in Hamburger Menu

to reproduce:

visit e.g. http://demo.getgrav.org/onepage-skeleton/
resize your browser so the top navigation/menu becomes a hamburger button
click hamburger

is:

the opened menu shows the global menu

should:

the opened menu should show the same navigation as the not collapsed one (anchor links to navigate the single page site)
the global menu should remain hidden

actually the error is in antimatter. sry for bothering here


feat: allow updating metadata

https://github.com/user-attachments/assets/6082a935-a214-4afa-8b5d-9b2f68a77d54
closes #1708

Seems to work. As far as I understand the logic is

if the version hasn't been published yet we execute publishNewVersion()
if it's an existing version we execute updateMetadata()

A couple of things:

Not very obvious that you need to connect the wallet. Maybe the disabled "Deploy" button should say "Connect Wallet First" if the wallet is not connected.
In Metamask I have "Arbitrum Sepolia" active, in the form combo box I have "Testnet" selected. I click on "Connect Wallet" button and Metamask wants to switch to "Arbitrum One" for some reason.

Not very obvious that you need to connect the wallet. Maybe the disabled "Deploy" button should say "Connect Wallet First" if the wallet is not connected.

updated this here https://github.com/graphprotocol/graph-tooling/pull/1714/commits/6f4de8af00813e7278bcd298dcc3cba8c6a94f1f

In Metamask I have "Arbitrum Sepolia" active, in the form combo box I have "Testnet" selected. I click on "Connect Wallet" button and Metamask wants to switch to "Arbitrum One" for some reason.

something related to MM extension 🤔 if it becomes too big of an issue can ticket and investigate later


Add CBMC Response parsing and Display controlled output

Description of changes:
The Old Output from rmc had non user friendly elements including -

Confusing output messages - See #189
Uncontrolled output from CBMC
Visually unappealing

To solve all the above issues and to setup future features, the CBMC Parser can now -

Process the response blob that is thrown out by CBMC
Store it in temporary files for easy reading.
Restructure the blob to make it easily parseable
Display a controlled output depending on user inputted flags.

The flag --output-format provides the following options [old | terse| regular] and can be passed as following -
rmc test.rs --output-format regular
This is how the previous output from rmc looks like -

This is how the controlled output looks like -

This change also comes with a pipeline to easily add more styles of output in the future per user requirements and flag based inputs. One such option already provided is the '--terse' flag that displays a summarized output with error messages.

Since final output displays are subject to a lot of user experience feedback, the parser seperates out functionality from the result and can be easily changed to match customer tastes.
Call-outs:

Integrating CBMC Viewer into the parser
Introduce three new formats of output via optional flags including report, log format, machine readable format
Handle non Json CBMC outputs with viewer
Test suite for the parser and Data Classes for each output format.

Testing:

How is this change tested?
Tested using regression tests, all but "Expected" suite passes tests with new output, but it still needs it's own testing suite which is in development.
Is this a refactor change?
Refactor and UX/UI change

Checklist

[x] Each commit message has a non-empty body, explaining why the change was made
[x] Methods or procedures are documented
[x] Regression or unit tests are included, or existing tests cover the modified code
[x] My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

The comments I have are about... comments. So I think this can be merged. Hopefully after those quick fixes. @celinval do you have any further comments?

I haven't done a last pass, but I think your review should be enough and I don't want to delay this any longer. Thanks for checking!


Negative effect indicator (red glow) isn't working

Tested and worked with a potion of Ravage Health. Going to test it in combat see if some negative effect isn't being flagged as such.

Working just fine.


Access the payload of request

I can't figure out how to access the payload of the request.
I can see the following attributes of the request object
"readable",
"domain",
"socket",
"connection",
"httpVersionMajor",
"httpVersionMinor",
"httpVersion",
"complete",
"headers",
"rawHeaders",
"trailers",
"rawTrailers",
"upgrade",
"url",
"method",
"statusCode",
"statusMessage",
"client",
"read",
"route",
"params"

You should be able to access the request object http.IncomingMessage. Here is an example of how you would do so.
import { Controller } from 'lux-framework';

import Post from '../models/post';

class PostsController extends Controller {
  beforeAction = [
    function logHeaders(request) {
      console.log(request);
    }
  ];

  index(request) {
    return Post.where(request.params.filter);
  }
}

export default PostsController;

--
Do you have an example of where you are trying to access the request object?

I have a custom POST action where I need to munge the payload of the request.
I can't access the payload on the request.

Custom actions should behave exactly like built in actions. Are you adding the POST action via a controller action? Do you mind including a code snippet?

The body of the request is what I am after.
In my router I have
this.route('users/login', {
  action: 'login',
  method: 'POST'
});

In my users controller I have
login(request, response) {
    // this is where I need to get username and password
}

Ok this makes more sense now. The body is parsed by Lux into params so you do not have access to the raw body. If you need to access the "body" try to access the data via the request.params Object.
Also, be sure to whitelist any keys that you don't want to filter out during the parameter sanitization process for security reasons.
import { Controller } from 'lux-framework';

import User from '../models/user';

class UsersController extends Controller {
  params = [
    'username',
    'password'
  ];

  beforeAction = [
    function logParams({ params }) {
      // Check to see if the params are making there way through to the controller.
      console.log(params);
    }
  ];

  login({ params: { username, password } }) {
    return User.authenticate(username, password);
  }
}

export default PostsController;

Let me know if that works for you.

Maybe I am not doing in the right place?
What is the more appropriate?

What is the more appropriate?

See the comment above. We're currently working on a website with better guides and documentation.

I've just tried your suggestion and it does not appear in params :(
As I understand params are created from query string. I am sending my payload in the body of the request.
I am a little confused on why there's no access to the body of the request by design.
It seem to me that it is a common scenario to validate and insert business logic prior to saving a model but maybe that is not what this framework is for.

As I understand params are created from query string. I am sending my payload in the body of the request.

The params are created from the dynamic url segments and the query string for GET requests, POST and PATCH requests use the body parser to parse the body into a JSON object that is sanitized for security and convenience.
What your trying to do should work as long as the params are whitelisted and the body your expecting is valid JSON (see #218).
--
After work today I can help debug this further and see if I can reproduce this issue.

Thanks for that. I really appreciate it.
I must say that the framework looks extremely promising and the code quality is mind blowing.
I'd like to help to contribute maybe with something like docs to start with. Let me know what I can help with.

Thank you! That really means a lot. We would love to have you contribute in any way possible. Creating this issue is a huge help and a great way to start.

Let me know what I can help with.

I'll find something for you this evening after 6 PM (EDT)!

First in foremost, thank you for taking the time to create this issue, trying out Lux, and your enthusiasm to help us out. It is all very much appreciated! 😃
So I did a little bit of debugging and think I may know what is causing your issue here. Since Lux is exclusively JSON API the POST requests are expected to be JSON API spec compliant. With that being said make sure the client you are using to make the request is including a Content-Type header with the value application/vnd.api+json. Also the data you are sending is formatted the way create and update actions are expected to be formatted, which is a JSON object containing a top level data object with a type property and an attributes object containing the fields you want to use for authentication.
This is kind of a grey area as to wether or not this should be an issue. The thing is, currently Lux is exclusively JSON API compliant and it will remain that way for the foreseeable future. I think I'm going to close this issue and open a new one to ensure that requests that are not compliant receive a 400 Bad Request response. After #222 and #229 merge, ensuring that non JSON API (POST and PATCH) request payloads actually would be a good first bug for you to tackle if your up for it. 😉
I included a sample request I used to get this working as well as a UsersController containing the login action example.
POST /users/login HTTP/1.1
Accept: application/vnd.api+json
Content-Type: application/vnd.api+json
Host: localhost:4000
Connection: close
User-Agent: Paw/2.3.4 (Macintosh; OS X/10.11.6) GCDHTTPRequest
Content-Length: 188

{
  "data": {
    "type": "users",
    "attributes": {
      "email"<EMAIL_ADDRESS>      "password": "super-secret-password"
    }
  }
}

import { Controller } from 'lux-framework';

import User from '../models/user';

class UsersController extends Controller {
  params = [
    'name',
    'email',
    'password'
  ];

  login({
    params: {
      data: {
        attributes: {
          email,
          password
        }
      }
    }
  }) {
    return User.authenticate(email, password);
  }
}

export default UsersController;

--
Anyways, let me know if your able to proceed with making POST requests to your custom login action. If your still having trouble I would be happy to chat and debug w/ you in real time in our Gitter room.

That worked! Thanks so much!
Which part of lux is responsible for producing those errors? I'm going to look into it to return the appropriate errors and create a PR.
Also, what is the way to chat to you directly outside of github?


Update README.md

New Windows developers (such as myself) might get confused by the build instructions and try to compile the entire solution instead of only the grpc target. See https://github.com/grpc/grpc/issues/6335

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

There seems to be a merge conflict with vsprojects/README.md. Please resolve.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Please reopen after resolving the merge conflict.


No such file or directory: '../CVL_32.pickle'

Thank you for publishing IAM_32.pickle in Issue #4
I cloned this project to my personal Colab Notebook and executed "train.py". Now the file CVL_32.pickle is required.
Traceback (most recent call last):
  File "./Handwriting-Transformers/train.py", line 42, in <module>
    TextDatasetObjval = TextDatasetval()
  File "/content/Handwriting-Transformers/data/dataset.py", line 109, in __init__
    file_to_store = open(base_path, "rb")
FileNotFoundError: [Errno 2] No such file or directory: '../CVL_32.pickle'

Would you please publish this file also?
Thank you very much. 🙇

I'm not sure if this helps, but it does look the developer provided the link to this file in issue #4 which was marked as closed:
https://github.com/ankanbhunia/Handwriting-Transformers/issues/4

Hello, Do you know where is  '../Lexicon/english_words.txt'?

Hello, Do you know where is '../Lexicon/english_words.txt'?

Any updates here or idea how it is generated, stuck in the same scenario?

Hello, Do you know where is '../Lexicon/english_words.txt'?

Hello, Do you have the file '../Lexicon/english_words.txt'?

Please refer to the install.md


install_wps_openmpi.sh fails

Having built WRF using install_wrf_openmpi.sh I moved onto builing WPS.
I had to modify install_wps_openmpi.sh to factor for the recent change the version 4.1.5 in install_wrf_openmpi.sh:
-WRF_VERSION=4.1.3
+WRF_VERSION=${WRF_VERSION:-4.1.3}

I then invoked it like so:
SHARED_APP=$HOME/apps WRF_VERSION=4.1.5 SKU_TYPE=HBv2 ./install_wps_openmpi.sh
and it gives this error:
`WPS-4.1/util/src/write_met_module.F
WPS-4.1/util/vertical_grid_38_20m_G3.txt
WPS-4.1/util/vertical_grid_50_20m_63km.txt
WPS-4.1/util/vertical_grid_70_20m_80km.txt
==> Error: Spec 'netcdf ^openmpi' matches no installed packages.
ModuleCmd_Load.c(213):ERROR:105: Unable to locate a modulefile for 'mpi/openmpi-4.0.2'
Will use NETCDF in dir: /home/deployer/apps/spack/HBv2/linux-centos7-skylake/gcc-9.2.0/netcdf-fortran-4.5.2-pb2rwfi5x4ut5idkryrlrmno7fctylyq
Error: The $WRF_DIR environment variable was set, but the WRF code at
/home/deployer/apps/HBv2/wrf-openmp/WRF-4.1.5 doesn't appear to have been successfully compiled
Do 'configure' first
`

See https://github.com/Azure/azurehpc/pull/239 for a proposed fix.

Hi I updated WRF but not WPS, I will take a look and get back to you soon.

PR #239 looks good, just need to change the WRF version default to be 4.1.5. Once this is done I will merge.

Hi,
I have made the change to the default WRF_VERSION.
Thanks
Darren

Great, I have merged it into the master branch.


"min" setting on collapsable group not working since 3.1.0

Describe the bug
I use the "min" setting on a group object to exclude states below 20% from the group.
It doesn't seem to be deterministic which states are excluded from the group.
In the case shown below there are three states with > 20% that should be included in the group.
How to reproduce

Expected behavior

YAML configuration

type: custom:battery-state-card
title: Erdgeschoss
sort:
  by: state
color_gradient:
  - '#ff0000'
  - '#ffff00'
  - '#00ff00'
collapse:
  - name: '{count} Bewegungsmelder: {range}%'
    icon: mdi:motion-sensor
    min: 20
    entities:
      - sensor.bewegungsmelder_diele_eg_batterie
      - sensor.bewegungsmelder_flur_battery
  - name: '{count} Fenster: {range}%'
    icon: mdi:window-open-variant
    min: 20
    entities:
      - sensor.fenster_klein_buro_batterie
      - sensor.fenster_gr_buro_power
      - sensor.fenster_hauswirtschaftsraum_power
      - sensor.fenster_bad_eg_power
      - sensor.fenster_wc_power
      - sensor.fenster_kuche_power
      - sensor.terrassentur_wohnzimmer_power
      - sensor.haustur_diele_eg_battery
      - sensor.fenster_treppenhaus_battery_level
  - name: '{count} Heizungen: {range}%'
    icon: mdi:radiator
    min: 20
    entities:
      - binary_sensor.wandthermostat_buro_low_bat
      - binary_sensor.wandthermostat_wohnzimmer_low_bat
      - binary_sensor.heizung_buro_low_bat
      - sensor.heizung_bad_eg_battery_level
      - sensor.heizung_wc_battery_level
  - name: '{count} Luftfeuchtesensoren: {range}%'
    icon: mdi:water-percent
    min: 20
    entities:
      - sensor.luftfeuchtesensor_bad_eg_batterie
  - name: '{count} Rauchmelder: {range}%'
    icon: mdi:water-percent
    min: 20
    entities:
      - sensor.rauchmelder_buro_power
      - sensor.rauchmelder_eg_treppenhaus_power
      - sensor.rauchmelder_flur_power
      - sensor.rauchmelder_esszimmer_power
      - sensor.rauchmelder_hauswirtschaftsraum_power
      - sensor.rauchmelder_wohnzimmer_power
  - name: '{count} Schalter: {range}%'
    icon: mdi:water-percent
    min: 20
    entities:
      - sensor.wandschalter_wc_battery
      - sensor.wandschalter_hauswirtschaftsraum_batterie
      - sensor.remote_spule_kuche_battery
      - sensor.remote_arbeitsplatte_kuche_battery
      - sensor.remote_spule_kuche_battery
state_map:
  - from: High
    to: 100
  - from: Low
    to: 10
  - from: unavailable
    to: 0
  - from: 'on'
    to: 100
  - from: 'off'
    to: 10
tap_action:
  action: more-info

Screenshots

Version
battery-state-card: 3.1.2
HA: 2024.1.2 (the issue seems to be independent of the HA version).

Oh true, It's because of the default state value formatting which was introduced in v3.1.0.
You can mitigate it by disabling this feature via:
default_state_formatting: false

The reason why you think it's not deterministic is that it affects only entities with decimal values :) Now card shows correct decimal point (according to locale settings). In your case it is comma but later cards code has problem converting this back to the JS number hance grouping min/max/range stops working.
Permanent fix should be easy although I would like to have a test covering this particular case (to avoid similar problems in the future).
Thanks for reporting the issue

Aah - yeah that makes sence! Thx for the explanation.
I tried the mentioned setting and with that setting the issue is gone.

Fixed in v3.1.4


Description and references missing for some games

The available games page is missing a description and references for some games, including:

Mean Field Game: crowd modelling
Mean Field Game: crowd modelling 2d
Mean Field Game: predator prey

Hi @carlosgmartin,
Thanks for pointing that out. All three were used in https://arxiv.org/pdf/2103.00623 and https://proceedings.mlr.press/v162/lauriere22a.html.
There's also a good survey for these: https://arxiv.org/abs/2205.12944.
We should probably attach all three to each of them.
We'll add them unless you want to via a PR?

@lanctot I've created a PR here: https://github.com/google-deepmind/open_spiel/pull/1283.

Awesome, thank you!

Fixed by https://github.com/google-deepmind/open_spiel/commit/e2167313e56bc3a60bf9925aa75f9f57fe7f6d0d


Added=>Algo=>Search_Algo=>Linear_Search=>C

Assigned Issue Number ?
Unknown
Language Opted ?
C
Number of files added or updated ?
1
Name of these files ?
algo_ds_101=>Algorithms=>Search_Algorithms=>Linear_Search=>Linear_Search.c
Checklist

[X] I've read the contribution guidelines.
[X] I've referred the correct issue number.
[X] I've fill up this entire template correctly.

Duplicate File ⚠
Can't Merge 🙅🏽♂


Create partner UI

Create the UI used to keep track of partners or other referral sources for members. The primary user for this UI is staff who work with partners and need a place to keep track of contacts and analytics for members from this partner.
Requirements

[ ] Review API Specs
[ ] I believe the only routes we need are:

/admin  - displays a configuration page - See the person service ``mh up person admin page for details.
/partner - Create a New Partner
/partner/{oid} - Edit a Partner
/partners - Display a list of all partners, with links to edit each, and a "new partner" link as well
/ - configure this route to forward to /partners

[ ] Material Design, Mobile First, Full Width
[ ] Patch level autosave on-blur.
[ ] Data refresh after each autosave.

Suggested Implementation Steps

[ ] Setup Project, directory structure, npm, & Docker with Hello-World functionality for all routes
[ ] Build and test Container locally with mh backing services.

When complete, merge to main, continue using issue #1 branch.
Verify GitHub action completed successfuly
Use mh update and mh up partner to test

[ ] create  minimal prototype (partners, partner/id)
[ ] conduct a Cognitive Walkthrough
[ ] Build out admin route
[ ] Build out partner list route
[ ] Build out new partner route
[ ] Build out edit partner route
[ ] Add/Remove existing people to contacts list
[ ] New Person  link to the person-ui /person path
[ ] Build black box testing with Cypress

Drafted this up. Want to get some feedback to see if this is close to what the requirement is asking for. This is just for the /partners page. After getting some feedback, I can work on the mockups for some of the other pages.

Paper prototype
List view

Edit view

Add Person component

I would like to take a go at this if that is fine. Mike suggested to take this because an API is complete for it. I will get the steps going to get this running and will reach out if any help is needed. Let me know if this fine if not Ill take my name off of this.

Glad to have your help, I've assigned the issue to you. If you can also join our Discord and collaborate with Sterling Newsome and John Kluse on that. Here's a link to a thread where ya'll can colab https://discord.com/channels/1162851405158170795/1243226238294822983/1243226332226261105

Hi @Jeffg2221. I'm wondering if you're still on this. I'd also like to work on this and if you're also on it, I'd like for us to meet so we don't end up working on the same thing at a time. Or if you haven't gotten started though, I'd like to take this on.

Hey @theAvocadoCoder. You are more than welcome to take it over. I've been too busy to contribute unfortunately. Have fun and good luck, I'm sure you'll come up with something great!


Add optional language parameter to MapsForgeTileSource

Adds an optional language paramter to MapsForgeTileSource. This allows to set a prefered language for labels, which in most cases default to the map location's local language.
This sets one language for all map sources. Theoretically it is possible to set a prefered language per map source. I left this out for 1) simplicity and 2) because I don't see much use for this.
Fixes #1420

Thank you for your feedback, those are all valid points. I'll push an updated PR later this week.

In the developer guidelines it says to use 100 character line width and to prefix method arguments with p. Most parts of MapsForgeTileSource.java don't follow those rules. How should I proceed?

don't worry about it

No problem, I'll update the PR with that refactoring.

@sgelb Only if that makes sense to you and if you have time. I don't mind if you don't edit it - and that would also save me the time to re-approve it ;)

@monsieurtanuki Okay, if that is fine, then I'm done with it. Thanks!


Rename 'RegexProtocol' to 'RegexComponent'.

With this change, should String.match(_:) take a Regex instead?

With this change, should String.match(_:) take a Regex instead?

One option is an ABI that takes Regex and an inlinable API that's generic and just passes off the static var. (I've also been wondering where the ABI falls for operating between generics and existential). WDYT?

Sure.  My main concern was not about ABI, but whether it makes sense to have matching API on a RegexComponent.  As we sometimes want to use a custom regex component as a regex (to obtain its transformed Match), it seems like calling it "regex component" may not be entirely appropriate.

@natecook1000 how are option scopes and global options coming along? That might help clarify the relationship between a Regex, RegexProtocol, RegexComponent, etc.

@swift-ci please test

@swift-ci please test

We converged on this solution in a meeting so I'll go ahead and merge. Any feedback is always welcome.


Question: How to run AB on localhost but store data on NAS?

Hello!
I'm using docker-compose. Following the title if this issue: I first tried changing the whole data dir to a mounted path pointing to my NAS, but I got this error:
  archivebox_1  | [X] OSError: Failed to write /data/ArchiveBox.conf with fcntl.F_FULLFSYNC. ([Errno 22] Invalid argument)
  archivebox_1  |     You can store the archive/ subfolder on a hard drive or network share that doesn't support support syncronous writes,
  archivebox_1  |     but the main folder containing the index.sqlite3 and ArchiveBox.conf files must be on a filesystem that supports FSYNC.

I cannot figure out how to separate data/archive/ from the rest as I wish to store this on my NAS. I tried symlinking it but it just complains that data/archive/ already exists.
I would prefer to have as much data on my NAS so all or any of data/{logs,sonic,sources}/ as well.
How do I setup this with docker-compose?
Thank you kindly! in advance.

Symlink works but you have to mount the destination of the symlink in docker-compose as a volume as well (to the same location the symlink is pointing to, except inside the container).

I'm sorry, I don't understand this. Can you give me an example?
Since ArchiveBox.conf and index.sqlite3 needs to be on host and not on NAS, how do I separate them from the rest?
I've tried many different variations, for example:
volumes:
    - ./data:/data
    - /mnt/arkivet/ArchiveBox-data/archive:/mnt/arkivet/ArchiveBox-data/archive
    - /mnt/arkivet/ArchiveBox-data/sources:/mnt/arkivet/ArchiveBox-data/sources
    - /mnt/arkivet/ArchiveBox-data/sonic:/mnt/arkivet/ArchiveBox-data/sonic
    - /mnt/arkivet/ArchiveBox-data/logs:/mnt/arkivet/ArchiveBox-data/logs

But this doesn't work as the folders are created in host ./data. I don't know when I should create my symlinks either because AB complains if a folder (symlink) already exist or creates the folders before I have a chance to create my symlinks. It doesn't matter if I remove folder(s) and then create my symlink(s), it still complains about what I believe is FSYNC.
What am I missing?
Traceback (most recent call last):
  File "/app/archivebox/system.py", line 90, in atomic_write
    f.write(contents)
  File "/usr/local/lib/python3.9/contextlib.py", line 124, in __exit__
    next(self.gen)
  File "/app/archivebox/vendor/atomicwrites.py", line 172, in _open
    self.commit(f)
  File "/app/archivebox/vendor/atomicwrites.py", line 205, in commit
    replace_atomic(f.name, self._path)
  File "/app/archivebox/vendor/atomicwrites.py", line 99, in replace_atomic
    return _replace_atomic(src, dst)
  File "/app/archivebox/vendor/atomicwrites.py", line 56, in _replace_atomic
    _sync_directory(os.path.normpath(os.path.dirname(dst)))
  File "/app/archivebox/vendor/atomicwrites.py", line 50, in _sync_directory
    _proper_fsync(fd)
OSError: [Errno 22] Invalid argument

@iwconfig I was able to share my archive directory on my Synology NAS.
I mouted the archive directory directly from NFS.
version: '2.4'

services:
    archivebox:
        image: ${DOCKER_IMAGE:-archivebox/archivebox:master}
        command: server --quick-init <IP_ADDRESS>:8000
        restart: unless-stopped
        environment:
            - ALLOWED_HOSTS=*
            - MEDIA_MAX_SIZE=750m
        volumes:
            - ./volumes/data:/data
            - archivebox-archive:/data/archive

volumes:
  archivebox-archive:
      driver: local
      driver_opts:
        type: "nfs"
        o: "nfsvers=4,addr=<IP_ADDRESS>,rw"
        device: ":/volume1/archivebox/archive"

Thank you so much! I got it working now :smiley: I just had one issue with permissions inside the docker container, so I had to do
docker exec -it archivebox_archivebox_1 chmod -R 777 /data/archive

Awesome! Again, thank you!
@pirate Maybe this should be mentioned in the documentation? If it already is, I'm sorry, I haven't seen it.

Note I've added a new DB/filesystem troubleshooting area to the wiki that may help people arriving here from Google: https://github.com/ArchiveBox/ArchiveBox/wiki/Upgrading-or-Merging-Archives#database-troubleshooting
Contributions/suggestions welcome there.


Feature/expose ports

expose additional ports like 80,443,8080 for the kubernetes cluster

Thanks for this! I was just about to ask :)

@graydon  pulled it from your fork,  should have done it earlier :)


Adding support for ToFu Controller for Terraform Backstage Integrations.

Adding support for ToFu Controller for Terraform Backstage Integrations.
Also Upgrading the CrossPlane and AWS provider versions

@nabuskey All comments fixed and responded, Can you merge this?

Thankyou @nabuskey


Magebomb OT 7.7

is there a way to download the old version of blackd to use magebomb on otserver 7.7??
thanks

was the magebomb code ever removed? i don't think so. but i bet they never bothered to port the magebomb control panel to the new UI (i don't actually know, as i've never actually used it, but it wouldn't surprise me) - have you checked if the magebomb controls can be found in the old UI?

so there is no way to use magebomb on 7.7 OT? :/

that's not what i'm saying. i'm saying that you probably have to use the old UI, not the new ("NG") UI, to use magebomb - i don't know how to switch UI though, but i think it asks you the first time you start the proxy. (idk because i haven't used the newer versions of blackd proxy)


[Bug]: In firefox browser the Image is missing in the license page

Is there an existing issue for this?

[X] I have searched the existing issues

Description
In firefox browser the Image is missing in the license page

Steps To Reproduce

first pull the image docker pull ankitakinger/appsmith:airgap
now switch off the internet
now docker run -e APPSMITH_AIRGAP_ENABLED=true -e KEYGEN_LICENSE_VERIFICATION_KEY=b2b98c313548c14cb22ddb4afb9124553c4c829c290d8a3cbf01ff8ee57624dc -d --name appsmith-airgap -p 80:80 -v "$PWD/stacks:/appsmith-stacks" ankitakinger/appsmith:airgap
Now do the set up
In the license page the Image is missing the the extra text "No Active subscription "  is displayed

Public Sample App
No response
Environment
Release
Issue video log
No response
Version
release

Image is present now.


Add usgs doi spread sheet

Adding usgs doi spread sheet

@tayjh445 Congrats on your first pull request!


How i can display value in item of bar or line chart?

i can'n undersand, how add value on chart. Why you are didn't add this in option?

All you need to do is update the data object and call update(). See https://github.com/chartjs/Chart.js/blob/master/samples/bar/bar.html#L113-L125


typo fix in eventhubs-features doc

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@sabeegrewal : Thanks for your contribution to the Azure documentation! The author, @sethmanheim, has been notified to review your proposed change.

@sabeegrewal Thank you for catching that! OK to merge. #sign-off


Questions: "Failed to find DNS-record for resource at https://www.google.com"

Hi,
I decide to try this test framework and got this error.
Same with you test page. I'm in corporate network with some firewall restrictions, but both pages are available if I try it in browser. Maybe you have any idea what could be wrong?
Sorry if this such silly report.
Test code
import { Selector } from 'testcafe';
const articleHeader = Selector('#article-header');
fixture `Getting Started`
    .page `https://www.google.com/`;
test('My first test', async t => {
    await t
        .typeText('#lst-ib', 'Peter Parker')
        .click('[type="submit"]')
        .expect(true).eql(false);
});

Specify your

operating system:
Win 7
testcafe version:
0.11.1
node.js version:
6.9.1

Hello Vitaly !
Thank you for reply. Specify, please, has your browser special network settings like proxy or not ? Is TestCafe added to your firewall exceptions ?
At first we need to know, whether node.js has the access to the network. Run next steps, please:

Create a temporary directory:

mkdir test-request
cd test-request

Create the request.js file in the test-request directory:

var http = require("http");

http.get('http://www.example.com', function (res) {
    var statusCode = res.statusCode;

    if (statusCode !== 200) {
        console.log(` Request Failed.\n Status Code: ${statusCode}`);

        res.resume();
        return;
    }

    console.log(` Request Success.\n Status Code: ${statusCode}`);
});

Run request.js via Node.js:

node request.js

Post the output here.

Hi @georgiy-abbasov ,
Sorry for delay, was on vacation and was not able to check.
I don't see any proxy settings in browser, but most probably we have it for all outgoing traffic somewhere on network level.
As for firewall - we don't have any capability to manage those rules.
I was just wondered that I was able to install testcafe without errors, because every other e2e client need some admin rights on PC to build and download some selenium packages + add PATH variables
script return:
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: getaddrinfo ENOTFOUND www.example.com www.example.com:80
    at errnoException (dns.js:28:10)
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (dns.js:76:26)

So most probably i need set up some proxy, not sure about this. Just rise this ticket to understand what direction should I dig.
Thx. Any suggestion would be appreciated.

Hi!
Thanks for log, we need some time to investigate this behavior.
Please, bear with us.

I don't see any proxy settings in browser, but most probably we have it for all outgoing traffic somewhere on network level.

If i correctly understand, you have LAN settings in Internet options like this, right ?
About firewall and script result - it looks like dns requests are blocked for node.js application (meanwhile they are allowed for browser). Can you run cmd with administrator privileges ? If yes, try to re-run script above and also run next command:
ping www.example.com

@vitvad or @georgiy-abbasov did either of you ever figure out this issue?
I'm having this same issue using a rails development server Failed to find a DNS-record for the resource at "http://localhost/3000" even though I can access it in my browser

Hi @andrewdang17
Did you try to run this snippet, that i recommended ? If no, please run it, cause your problem looks little different. It would be worth, if you also run this snippet and post the result here.

@georgiy-abbasov I'm getting Request Success. Status Code: 200 and also created a express server and that worked too . It's possible that a setting in my rails config is blocking testcafe....

@andrewdang17 , It's possible. Please, try perform request from my first reply with your page - http://localhost/3000

@georgiy-abbasov 3000 worked with express too :(

@andrewdang17, in that case it's hard to determine the cause of this behavior. Can you provide a link to your project page, if it's deployed ? You can do it privately.

The same issue is happening to me, but for localhost. I was trying to implement TestCafe + Nightmare for Travis but it's giving me this error.
Here's the Travis log:
https://travis-ci.org/sagarvora/frappe
Here's the Travis config:
https://github.com/sagarvora/frappe/blob/develop/.travis.yml
Here's the code I wrote:
https://github.com/sagarvora/frappe/blob/develop/login_test.js
Note that the first three steps upto logging in are working, and hence I am being redirected to the /desk page.

Hi @sagarvora,
Does it work locally on your computer?

@AlexanderMoskovkin I tried running the same script locally, it passed.. What could be the reason? :thinking:

It's hard to determine the reason without an investigation.
Could you please compare the server log on Travis with the log from local running? (for example you can publish it on https://gist.github.com/).

I am seeing this same error on Circle CI. Just FYI. It's just popped up in the last few days. I pointed the tests at Travis and don't see the error after 50+ runs. It's not happening locally either.

Facing same issue while running tests in firefox(passes in chrome). I have a web worker in the application and supposed to load dynamically when I say new Worker(host + '/testWorker.js'). Host is same for application and worker. But getting this error.
1) Failed to find a DNS-record for the resource at
      "http://host/test.js"

I cannot reproduce this issue. I've created a simple web_worker_example.zip that works well.
Please, try to modify this example to reproduce your issue.

did you try in firefox? Anyways will try to reproduce with your example as well.

Thanks, I've reproduced the problem and created a separate issue.

I'm closing this since there were no activity here for a long time. Some of other issues discussed here were resolved. Feel free to reopen the issue if the initial issue is actual or create a new issue if you have some other problem.


Dont deinitialize discordrpc twice onClose and initialize discordrpc on Main instead of TitleState

Literally the most minor change in existence, approved.