Store the Store object itself in the context data

Hi,
with this PR, we leverage the store context data work introduced with #191 in order to store a reference to the Store itself, so that we can retrieve the originating Store from a Caller.
When we create a Function instance from a callback from a funcref value, we will then use the Store instead of the Caller to instantiate the Function, so that it is also callable outside of the callback.
This also allows some code clean-up e.g. in the IValueRaw converters, since we can now unconditionally pass a Store that doesn't need to be allocated.
Fixes #200
What do you think?
Thanks!

So I have a few problems with this approach, chiefly that it would inherently introduce a circular reference between the .NET and the native store representations making it much easier to leak a Store and by extension everything used in that store.
Currently if you forget to dispose a .NET Store and it becomes eligible for collection because it isn't reachable from any .NET roots, it will get collected and the contained Handle to the native store object will be freed during finalization, thus "dropping" the native store and releasing the root on the data object (if there is one).
With these changes, the native store always holds a root to the Store and the Store holds a handle to the native store, meaning it'll never be collected without an explicit Dispose call to free the root held by the native store.
While it is possible to reference a Store from a store data object today and thus introduce the same circular reference, we should probably add a "don't do that unless you really know what you're doing" documentation warning somewhere.
Additionally, I'm not convinced we need to fix #200. Linker functions should not capture anything related to caller context and should manipulate any state that should outlive the call via Caller.GetData. While in Rust it's easy to enforce this invariant thanks to its type system and the compiler's borrow-checker, it's unfortunately trivial to violate in a GC language like C# with zero warning.
There will likely be other things which violate an invariant that the underlying Rust API holds that we will likely just have to say "don't do it that way, do it this way instead" to users.

The "proper" way to fix this, in my opinion, is to go back to passing in the store context to use when invoking a function, like in the Rust API. Thus Function would not store the context association meaning that it could safely outlive the caller context to be called with another reference to the same store.

Hi @peterhuene,
thanks for your reply and review. Yes, I agree in particular the circular dependency would be a bad thing to introduce.
I will look into possible alternatives for fixing the issue.
Thanks!


Chore/lint and test

Refactors bolt and adds testing + .travis.yml for integration with travis.

Close #19 & #20


SCRUM-3507 - Possible fix for 'failed to initialize collection...' error

Note sure this will work as cannot reproduce the error locally, but we had the same error for VocabularyTerm synonyms and fixed it like this.
Current error:
failed to lazily initialize a collection of role: org.alliancegenome.curation_api.model.entities.Person.emails: could not initialize proxy - no Session (through reference chain: org.alliancegenome.curation_api.response.ObjectResponse["entity"]->org.alliancegenome.curation_api.model.entities.VocabularyTerm["vocabulary"]->org.alliancegenome.curation_api.model.entities.Vocabulary["updatedBy"]->org.alliancegenome.curation_api.model.entities.Person["emails"]) Nov 15 23:02:23 [agr.curation.alpha.api.server](http://logs.alliancegenome.org:5601/app/logtrail) : 	at com.fasterxml.jackson.databind.JsonMappingException.wrapWithPath(JsonMappingException.java:361)

Or it could just kill all the bulk load integration tests!

I typically don't like calling the underlying API directly but rather use the upper API. However I see this:
Use Hibernate.initialize() within @Transactional to initialize lazy objects.

 start Transaction
      Hibernate.initialize(entity.getAddresses());
      Hibernate.initialize(entity.getPersons());
 end Transaction
Now out side of the Transaction you are able to get lazy objects.

entity.getAddresses().size();
entity.getPersons().size();

So I guess this would be the best option.


Set re2 repository commit to the latest

This makes re2 buildable on Windows with MSVC toolchain. @mrry @damienmg @dslomov

Can one of the admins verify this patch?

@tensorflow-jenkins test this please.

Hmm.. Is it my change that's causing the failure? Can we rerun it?

@tensorflow-jenkins test this please.

(Looks like a transient failure for one of the external repositories... but let's test again to be sure.)

Still failing. I'm sure it's unrelated to this CL, but that test is becoming is problem. Do you know what's wrong with it?


Error from SharePoint Online when I try to create a new webhook

Thank you for reporting an issue or suggesting an enhancement. We appreciate your feedback - to help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you.
Category
[ ] Question
[X ] Bug
[ ] Enhancement
Expected or Desired Behavior
I wanted to add a new subscription to a list and I expected to be added and appeared in the webhook list.
Observed Behavior
When I try to add a new webhook I received an internal server error from SharePoint. I can see that it doesn't arrive to send the post from SharePoint to the the api webhook when it tries to create it.
Steps to Reproduce
Just click on any list and add a new webhook.

Hi Victor,
Just checking: did you enable our tenant for first release? The web hooks functionality is still in developer preview and only available for tenants that are subscribed to first release. You can use your tenant admin center, search for first release and flip the switch to enable it. Note that it takes a while for everything to be setup, but typically the day after you should be good. If that's not helping please submit the actual error you get.

Closing for now, due no response. We can reopen this if the first release setting was not enabled for further investigation.


TODO

These are the things that for sure need to get done to be usable:

[x] Email user when he/she signs up for challenge
[x] Spot switch when challenge result is confirmed
[x] Challenge list exporting when signup time is over (Node-Schedule when a performance is created)
[x] Logging on challenge success (for my sanity and debugging)
[ ] Styling to make OSU official @cdeiderich - You can still do this right?
[ ] Admin things that would be useful to have (probably need to meet with Tess)
[ ] Automated Testing of the entire process
[ ] Sockets - to remove a person from the list if they've been challenged while a user is on the page

This will probably need to be edited as things continue

#87 Has to be a part of this

I'm checking off admin things because of #106

I checked off TODOs because of #157 . It took care of the last one 🎉

This was a pre-release checklist. We've released. Moving sockets to a separate issue and closing this one


[WIP] feat: adding job module

@lavkesh try changing golang-ci lint to version v1.54.2 in the workflow


Add argument in the CLI to specify device to do the ONNX export on

As per title, can be useful for large models.
The validation should be done on the same device as well.

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


The latest version v0.21

I can't find the doc of CITA v0.21.
https://docs.citahub.com/en-US/versions

Done

#65

Done

Still on review, why close this issue?


Removed XP support ?

Hi
Why was XP support removed ?
I would like to run this on XP. Please.
Thanks

It was removed because the demand has not been that huge. After the removal, I think you are the first to ask for it to be supported again.
That being said, you could probably get it to work by using and older version (0.1.4): https://github.com/nsmfoo/antivmdetection/commit/918f9c52ef17e714df4c67dede6f31d4c057752e
Use the shell script from that version to apply to the VM and then you can use the current PS1 script inside of the host.
I can add XP support to my todo list, but no promise of it being re-introduced. If you fancy you are of course more then welcome to send me a PR for it

If I get the time to re-implement XP support, I will re-open this case. But feel free to jump ahead and send me a PR =)


Support simple resource class selection

https://github.com/crossplaneio/crossplane/pull/926
https://github.com/crossplaneio/crossplane/pull/927
https://github.com/crossplaneio/crossplane-runtime/pull/48
Updates angryjet to reflect the above changes.

Description of your changes

Checklist

I have:

[x] Run make reviewable to ensure this PR is ready for review.
[x] Ensured this PR contains a neat, self documenting set of commits.

How would you feel about incorporating #2 into this PR?

I agree with the sentiment, but I'm inclined to tackle it in a separate PR because it's a slightly less trivial change than it might seem. angryjet doesn't know how to write anything but methods at the moment, so we'd probably have to teach generate.WriteMethods how to know whether the methods it was writing should satisfy an interface.

@negz  FYI, my changes also have a change in the api (adding GetCondition), so you might want to wait until that is checked in, if you don't want to open another pr later

@soorena776 Thanks for the heads up. My suspicion is it might be best to add your changes in a separate PR, because it might take me a while to merge this one.

I agree with the sentiment, but I'm inclined to tackle it in a separate PR because it's a slightly less trivial change than it might seem.

@negz sounds good!


MICC Florence benchmark

Hi,
Thanks for your great work.
I am confusing about the "ICP with isotropic scale for alignment" as mentioned in the paper.
It seems no much public code for the evaluation of the reconstruction error for the MICC Florence dataset.
Can you share the your implementation?
Any help would be appreciated!

Hi, Thanks for your great work. I am confusing about the "ICP with isotropic scale for alignment" as mentioned in the paper. It seems no much public code for the evaluation of the reconstruction error for the MICC Florence dataset. Can you share the your implementation?
Any help would be appreciated!

Hi, do you find out how to do it? I need help on this too.

@Bornblack  Hi ,it is difficult for me to obtain the permission to download the data set on the official website. Could you please share this MICC Florence data set? If it is convenient for you, my email address is:<PHONE_NUMBER>@qq.com,or you can send me a web link to download the dataset.


5 additional GiB, and you are billed for 105 GiB

Hello,
This sentence is not clear:
If you have a share with 100 GiB of data but only 5 GiB has changed since your last share snapshot, the share snapshot consumes only 5 additional GiB, and you are billed for 105 GiB.
If only 5 GB data is changed, why do I need to pay for 105 GB or you mean 105 GB for the data stored on Azure Files (raw data, not the snapshot.
Thanks,
Lukas

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 534b3ef3-5664-973e-b146-8c1f960bf536
Version Independent ID: 57c3ce18-2857-8ed0-10a5-5061d391a079
Content: Frequently asked questions (FAQ) for Azure Files
Content Source: articles/storage/files/storage-files-faq.md
Service: storage
Sub-service: files
GitHub Login: @roygara
Microsoft Alias: rogarana

@ Firstly apologies for the delay response! Storage capacity is billed in units of the average daily amount of data stored, in gigabytes (GB), over a monthly period. For example, if you consistently used 10 GB of storage for the first half of the month, and none for the second half of the month, you would be billed for your average usage of 5 GB of storage.
To see the complete breakdown of SMB and FileREST transactions, see About Azure Files and File Sync billing.
Only the storage space used is charged for standard file shares, rather than the allocated limit. Pricing for premium files shares is based on provisioned GiB and includes all transaction costs. You can configure your premium shares based on your storage size, IOPS, and throughput requirements.
Understand Azure Files billing: https://docs.microsoft.com/en-us/azure/storage/files/understanding-billing
If the issue is still not rectified and looking for detailed information on  in pricing/billing, Free billing and subscription Azure Support Options | Microsoft Azure on management support has been provided. Billing and Subscription team would be the best to provide more insight and guidance on this scenario:
The below mentioned link will help you in calculating the price of Azure products along with their features available. https://azure.microsoft.com/en-in/pricing/calculator/
I'd recommend posting your question in https://azure.microsoft.com/en-us/support/community/ since it's not directly related to the documentation. We'll follow up there. We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Multiple consumers, producers & error handling

This is a first draft at allowing to configure multiple producers and consumers per Kafka instance.
It does away with starting a default consumer and producer while making the getting started documentation minimally more complicated. This allows for a lot more control over how to configure (mainly) consumers. Details in Readme.
Also first stab at consumer error handling, currently only JSON.parse() errors are handled, but you can register for those. Still need to figure out what to do if none are registered. Throw then?

two producers on different endpoints like this

thanks for illustrating this, we might wanna make it so that we can up the producers in start/kafka.ts and reference them in the routes, in case we want the same producer used in more than one route. I’ll see about enabling this.

the latest push implements multiple producers as well:
Kafka.createProducer('foo', {} /* ProducerConfig */).start()
Kafka.createProducer('bar', {} /* ProducerConfig */).start()

// in your route, you can now do:
// router.get('/test', ( { kafka }: HttpContext)) => {
//   await kafka.producer['foo'].send('msg', {yay: 1})
//   return 'sent'
// })


can't use search bar for websearch anymore

Hi I ran the deblaoter for my pc, but I'm now unable to use the windows search bar for websearches.
I don't really know how to enable that and couldn't find anything usefull online.
also I use this computer with the xbox gamepass app, is there some things that are more useful enabled for me and if so which would those be?

I actually fixed it by adding Explorer, with a dword of DisableSearchBoxSuggestions 0 to HKEY_CURRENT_USER\SOFTWARE\Policies\Microsoft\Windows
about the xbox stuff still stands tho, but it's not really an issue I just want to know if there's things I might want to re-enable

something that happened after as well is that I can't use the nvidia in-game overlay, I'm unsure if this is related, but I do tend to use it from time to time


Fixed stack overflow due to React props

Do not recursively search React props--it can easily lead to a stack
overflow: Uncaught RangeError: Maximum call stack size exceeded.

These commits fix two bugs:

a stack overflow when iterating over React properties
an incorrect 'this' argument when calling the original React components 'componentWillUpdate' method


the Type derive in 0.8 seems to generate a PgHasArrayType impl

Bug Description
I used to have several PgHasArrayType for some struct that derive Type. Updating to 0.8.0 i now have conflicting implementations. Problem is, if i remove my custom implementation my tests start failing. I was looking around and found the no_pg_array attribute, but if i add this i get:
error: unused #[sqlx(no_pg_array)]; derive does not emit PgHasArrayType impls for custom structs
Info

SQLx version: 0.8.0
SQLx features enabled: "sqlx-postgres", "macros", "postgres", "uuid", "rust_decimal", "runtime-tokio-rustls", "chrono", "json", "ipnetwork",
Database server and version: Postgres 14
Operating system: Linux
rustc --version: 1.79.0

The validation for the attribute got out of sync with the implementation. This check needs to be deleted: https://github.com/launchbadge/sqlx/blob/6f2905695b9606b5f51b40ce10af63ac9e696bb8/sqlx-macros-core/src/derives/attributes.rs#L281
My question is, why were your tests failing when you deleted your custom impls? What did they look like?

Actually my custom array impl had a different naming, that caused the tests to fail. I managed to fix everything and use the default array impl.
But if you really want/need a custom array impl it is not very convenient that you cant do this at the moment.
Also it might be good to be able to rename the array type with a derive attribute. Not sure if it exists, the documentation is not good around this

I imagine that, 99.999% of the time, one would just use the array type that Postgres implicitly creates when a custom type is created: https://www.postgresql.org/docs/current/sql-createtype.html
Disabling the automatic impl should work, like I said the validation just didn't get updated. It's a quick fix.


Update 02-introduction-to-git.md

I inserted a reference to the new slides we have (the ones created by Barbara and Ole), and instructions for how to use them with the carpentry episodes.
Also, I see that the link to the slides is [...]/2023-06-19-ds-cr, but I think that the slides were created later. Should we update it as well?
I assigned @JaroCamphuijsen as well as a reviewer since we were both teaching the intro to git episode.
Should we create an issue with different tasks for this PR and the other ones that we'll open? @lyashevska

Great addition @gcroci2, but I think the slides are not used before or after the episode but rather are used to teach the actual episode. I used the word "accompany", to indicate that they are used during teaching that specific episode. I also gave some explanation about what they are for and how to practically use them in an ideal setting and in practice.

Thanks Jaro very effective and clear additions :-)


Separation between modules and libraries?

Given that reactionscroll.py is not a module, should there be a distinction made beteween modules (that are usable) and helper libraries?

This issue is obviated by treating reactionscroll.py as a dependency rather than an integral part of the library, e.g., pip install git+https://github.com/scubot/reaction-scroll.git

Would it be a good idea to just ship it with the bot? It seems to be an often-used library.

That requires a user of the API to have the rest of the bot in order to write a module that uses that API.
Any attempt to import their module for testing would crash unless they had arranged it in a directory structure that matched that of the bot and had a reactionscroll.py file, while listing it as a dependency will ensure that it is installed identically in every environment in which the module could be executed.


Fix/avx cpu flags

Thank you for making MicroK8s better
This pull request fix the issue : https://github.com/canonical/microk8s-core-addons/issues/260
Added :

Detect CPU flags (on linux) (i might need a bit of help to make it platform independant)
Rewrite args/cni-network/ovn.yaml
Rewrite kube-ovn.yaml based on kube-ovn-template.yaml

Tested on Microk8s 1.29/stable On Debian 12 with backport kernel : 6.5.10

Hello @DLDClodio! Thanks for the PR and sorry for the late review.
I'm closing this to proceed with this change quicker in https://github.com/canonical/microk8s-core-addons/pull/285


GetCpuStatsTest failed occasionally on arm

What version of gRPC and what language are you using?
Version:        1.48.1
What operating system (Linux, Windows,...) and version?
Linux VM-238-86-TS3 5.4.119-19-0011
What runtime / compiler are you using (e.g. python version or version of gcc)
gcc-12.3.0-2.ocs23.aarch64<PHONE_NUMBER> 81807597 02207b4a09e21f1f6a0e9954c1c6d084 installed
gcc-c++-12.3.0-2.ocs23.aarch64<PHONE_NUMBER> 31436460 ed9d6c915e891be70378a65ffbf511ed installed
What did you do?
Please provide either 1) A unit test for reproducing the bug or 2) Specific steps for us to follow to reproduce the bug. If there’s not enough information to debug the problem, gRPC team may close the issue at their discretion. You’re welcome to re-open the issue once you have a reproduction.
compile the code and pack them into rpm.
What did you expect to see?
success
What did you see instead?
/builddir/build/BUILD/grpc-1.48.1/test/cpp/server/load_reporter/get_cpu_stats_test.cc:48: Failure
Expected: (prev.first) <= (cur.first), actual: 69428708 vs 69428707
[  FAILED  ] GetCpuStatsTest.Ascending (0 ms)
[----------] 3 tests from GetCpuStatsTest (0 ms total)
[----------] Global test environment tear-down
[==========] 3 tests from 1 test suite ran. (0 ms total)
[  PASSED  ] 2 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] GetCpuStatsTest.Ascending
1 FAILED TEST
error: Bad exit status from /var/tmp/rpm-tmp.JDvo8k (%check)
Bad exit status from /var/tmp/rpm-tmp.JDvo8k (%check)
Make sure you include information that can help us debug (full error message, exception listing, stack trace, logs).
See TROUBLESHOOTING.md for how to diagnose problems better.
Anything else we should know about your project / environment?

I guess the compiler may have done some optimization that leads to this error?

My first reaction looking at this test is that I don't understand why this has condition has to be true.

My first reaction looking at this test is that I don't understand why this has condition has to be true.
EDIT: Ah, ok. Looks like this is cumulative. In which case, I don't understand why it's not true on your environment.

I don’t know either.:( But with the patch above, this problem will never occur again.

I don't think we want that patch. We really want to figure out the reason for this, instead of a patch to cover up the issues.

It's still puzzling to me how cpu aggregated time can go back in your case. As you suspected, this could be a combination of Linux Kernel and ARM issue. Although I couldn't find the authoritative source saying that this cpu time should be monotonic, I think there is nothing we can do about it until we have clear evidence that there is a problem with the test code.

Okay. I run a demo with following code:
`#include
#include
#include
#include
#include <unistd.h>
std::pair<uint64_t, uint64_t> GetCpuStatsImpl() {
uint64_t busy = 0, total = 0;
FILE* fp;
fp = fopen("/proc/stat", "r");
uint64_t user, nice, system, idle;
if (fscanf(fp, "cpu %" PRIu64 " %" PRIu64 " %" PRIu64 " %" PRIu64, &user,
&nice, &system, &idle) != 4) {
// Something bad happened with the information, so assume it's all invalid
user = nice = system = idle = 0;
}
fclose(fp);
busy = user + nice + system;
total = busy + idle;
return std::make_pair(busy, total);
}
int main() {
const size_t kRuns = 100;
auto prev = GetCpuStatsImpl();
for (size_t i = 0; i < kRuns; ++i) {
// sleep(1);
auto cur = GetCpuStatsImpl();
if (prev.first > cur.first) {
printf("got");
printf("%d,%d", prev.first, cur.first);
}
prev = cur;
}
return 0;
}`
And I found that this problem has nothing to do with grpc indeed. It looks more like a 6.1 kernel problem, because it occured occasionally (about once thousands of times)  not only on ARM but also on x86.

I will continuely work on this problem. But I will use the patch above to workaorund for the following release.
Thanks a lot.

It's still puzzling to me how cpu aggregated time can go back in your case. As you suspected, this could be a combination of Linux Kernel and ARM issue. Although I couldn't find the authoritative source saying that this cpu time should be monotonic, I think there is nothing we can do about it until we have clear evidence that there is a problem with the test code.

I read the kernel code and the time is al +=, so it should be monotonic, I think.

This problem occurs when kernel enables CONFIG_CONTEXT_TRACKING_FORCE and CONFIG_VIRT_CPU_ACCOUNTING_GEN.I am sure it's an upstream kernel issue. We will report and fix this soon.
Thanks a lot.

<EMAIL_ADDRESS>This problem has been fix in newest upstream kernel.
Close the issue.


call request addon in mitm with selenium

Steps to reproduce the problem:

Copy the counter example in the addons sections
Add an option in selenium "--proxy-server=localhost:8080"
Then hit an url using driver.get("https://bitbucket.org/")

Its showing a log at the end saying We've seen 25 flows including css, png, js and everything.
I need to call the request or any function only once (when I call the proxy for an url).
I don't want this on internal request (png, js, css, html, external domains)
Any other comments? What have you tried so far?
I tried all the add-on functions available in the docs. Nothing worked for my use case
I am expecting the output from my addon as 1 flow when I hit one url. Anyway for this??

If this is still relevant, feel free to post this in discussions https://github.com/mitmproxy/mitmproxy/discussions or on StackOverflow


Unfilter all

Fixes #642.
Reopens #619.
Related #620.
This unfilters __all__ except for things which are directly from typing or are imported modules, though even that may be too strong. The old LS didn't look at __all__ whatsoever, so maybe all of these should be allowed to come through; you tell me.
Numpy:

Amending my statement: Even though the old LS didn't look at __all__ doesn't mean that it didn't filter what modules exported. I haven't looked at that code to see what it did, as I assume it didn't just pass everything through. Probably did what I'm changing to above (no modules or typing).

Old LS exposed variable defs, which I think would be about the same as what I've written. I'll merge this and we can tweak it later; at least numpy works now. 😄


video-player

Please use the form below, leaving the prefilled data to help us. Thank you.
Page link: video-player
Document link: video-player.md
My Issue/Suggestion
The document only says that it does not recommend that we pass the URL of a System.FileDocument to the video player.
But the main question is, what is the recommended way to store and play videos with Mendix? There are no YouTube-like things for the client because the application is deployed in the local network, with no internet access.

Hi @zjh1943 ,
I've reached out to our cloud developers to try and help with your issue. They asked for a little clarification:
"Is the customer's application running on their local network or in the Mendix Public Cloud?"
Could you speak to these details, and anything else regarding your use case that we should know about?
Regards,
Connor

Hi @ConnorLand,
The application is running in their local network. The video file is saved into an Entity that inherits the system.FileDocument Entity.
The client wants to know:

What URL should be passed to the video player (as the document does not recommend that we pass the URL of a System.FileDocument to the video player)?
How to get the URL? (Is there any low-code way to get the URL?)
What is the recommended way to store and play videos with Mendix? Any best practice?

From my side, as an expert service team member, I think the document should not only introduce the basic attributes of a widget, but it should contain content about how to use it, what is the recommended way to use it, etc.

Hi @zjh1943 ,
I've spoken to one of our widget developers. Mendix currently lacks an out-of-the-box media server solution, and this question is a little specialized relating to the on-environment media server. Therefore please file a ticket with Support for a bespoke solution that addresses your situation.
Thank you for reaching out,
Connor


Display thumbnail for categories too

Thumbnails are super useful to distinguish two categories with similar names.
Many categories have images (for instance https://commons.wikimedia.org/wiki/Category:Rabbits see the upper right), probably taken from Wikidata.
We should display thumbnails, like is done for depictions.

@nicolas-raoul Can I work on it?

@Ayan-10 Yes, thanks!
The first step is to find what API URL(s) you need to call to get from "Category:Rabbits" to "Q9121386" to "Ikesbunny.jpg".

@nicolas-raoul Yes, I already did that. I think this is the right API call for getting the 70px thumbnail.
https://commons.wikimedia.org/w/api.php?action=query&format=json&prop=pageimages&titles=Category%3ARabbits&piprop=thumbnail&pithumbsize=70

Wonderful! It is great that you found how to achieve all of this in only 1 API call. 👍


Updated humanize translation catalog es_AR

like in the ticket https://code.djangoproject.com/ticket/21415  but for the Argentina translation case.

@claudep , I added django.mo.  And I changed the translation sentence of "a minute ago"

Shouldn't the translations be fixed in Transifex, not through GitHub?

@timgraham like in https://code.djangoproject.com/ticket/21415 this is an issue associated to the naturaltime method error. Why somebody need make a transifex file? This is a bug in the main project in earlier versions, don't happen. And this bug had 4 years or more. You can see this person (https://stackoverflow.com/questions/30923349/django-naturaltime-adds-strange-characters) asking for this problem in 2015, for example. I think that this need a solution.

As far as I understand, the msgstrstrings are pulled from Transifex. If you submit the fix this way, it will be lost the next time translations are fetched from Transifex. Did you read the documentation about the translation workflow?

But for a person like me that don't have the access to the transifex, is the unique way make a fork and solve the problem changing the file.

Thanks for the pull request. I fixed that in 72026fff / 61fd2b494a.

Oh, and I indeed fixed the strings in Transifex first!

thanks @claudep !!


Notes screen

This screen will later be used to edit notes as well. For now, it is view only.

This task is required for the completion of user story:

TrueSparrowSystems/AI-SalesSparrow-iOS-App#6


fix build against musl

Fixed. Is there a more active fork of it?

Not as far as I know. I don't really use jshon any more, but should you (or anyone) start one, I'd transfer my patches.


number formatting in v2.4.8

Hi , when i set 4 digits number to NumberPicker it formats value by separating numbers like currency. I don't have this problem with v2.4.6.
any idea?

@alizarei95 Could you provide your code snippet?

Hi , when i set 4 digits number to NumberPicker it formats value by separating numbers like currency. I don't have this problem with v2.4.6.
any idea?

@alizarei95 Could you provide your code snippet?

    // setup year number pickers
    npYear.setTypeface(ResourcesCompat.getFont(getContext(), R.font.iran_yekan_fa_num_bold));
    npYear.setMinValue(1300);
    npYear.setMaxValue(1398);
    npYear.setOnValueChangedListener(onValueChangeListener);

It's working correctly in v2.4.8.  Have you tried using the latest version v2.4.9?

Tested v2.4.9 and also have this problem. I don't have this problem in v2.4.6

Have you tried testing on example project?
I tested the above code snippet that you provided and it's working correctly.

do you set custom typeface?

This issue has been fixed at v2.4.10.


Add staticResponseHeadersPolicy to NextjsProps

I would like to reuse the same policy for different cloudfront distributions. It is possible for the cachePolicies and the originRequestPolicies. So could staticResponseHeadersPolicy be added to the NextjsProps to be reused?

Hi @Lightbirdv, yes, you can customize the CloudFront Distrubtion's cache policies and origin request policies like this:
new Nextjs(this, "Nextjs", {
  defaults: {
    distribution: {
      cachePolicies: {
        imageCachePolicy: new CachePolicy(this, "ImageCachePolicy", {}),
        lambdaCachePolicy: new CachePolicy(this, "LambdaCachePolicy", {}),
        staticCachePolicy: new CachePolicy(this, "StaticCachePolicy", {}),
      },
      originRequestPolicies: {
        fallbackOriginRequestPolicy: new OriginRequestPolicy(this, "FallbackOriginRequestPolicy", {}),
        imageOptimizationOriginRequestPolicy: new OriginRequestPolicy(this, "ImageOptOriginRequestPolicy", {}),
        lambdaOriginRequestPolicy: new OriginRequestPolicy(this, "LambdaOriginRequestPolicy", {}),
      },
    } satisfies Partial<NextjsDistributionProps>
});

Does this answer your question?

Or are you referring to being able to customize this construct?

@Lightbirdv, I the PR raised to fix this, but I'm working towards a broader solution for this problem with an overrides top level prop. I've created an RFC for it here: https://github.com/jetbridge/cdk-nextjs/discussions/132. Could you please review it and share your thoughts?
Also, could you please share some sample code for how you're using staticResponseHeaderPolicy and it's use case? I'd like to keep a list of common customizations to this construct and their use cases.


Move TODO.md to github issues

Resolved with commit https://github.com/phucnguyen81/webpack-demo/commit/bf5cbf9c7b5b8a54a511503039d49bb481561f34


Revert "change all DOMStringList to string[]"

Fixes https://github.com/Microsoft/TypeScript/issues/12069

@zhengbli Could you merge this fix into TypeScript repo before next releasing (possibly 2.1.0)?

Yes, I'll try to merge it with master more often. Next time is likely to be this friday.

Thx!


feature: support spring cloud config

Ⅰ. Describe what this PR did
support spring cloud config #1078
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
set config type with value SpringCloudConfig in registry.conf then add mvn dependency seata-config-spring-cloud and add @EnableSeataSpringConfig
Ⅴ. Special notes for reviews

Codecov Report

Merging #1656 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #1656      +/-   ##
=============================================
- Coverage      47.25%   47.24%   -0.01%
  Complexity      1765     1765
=============================================
  Files            359      359
  Lines          12999    12999
  Branches        1617     1617
=============================================
- Hits            6143     6142       -1
  Misses          6192     6192
- Partials         664      665       +1

Impacted Files
Coverage Δ
Complexity Δ

...server/store/file/FileTransactionStoreManager.java
45.99% <0%> (-0.35%)
19% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f15891...132cbc8. Read the comment docs.

fixed


mWeb - The error message is displayed 2 times and sometimes not displayed with a dot

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue was found when executing #11037
Action Performed:
1.Click on green fab icon (+)
2.Create a new room with the name "foo"
3.Repeat step 1, and create a new room with the name "bar" in the same workspace as room "foo".
4.Go to room "bar" -> Room settings
5.Rename it to "foo"
6. Click Save multiple times
Expected Result:
The error message should appear with a dot and not double
Actual Result:
The error message is displayed 2 times and sometimes Dot is not displayed for the error message
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: v1.2.5
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/191864711-7af0fc20-7319-410c-bc70-18eea0346a6f.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
View all open jobs on GitHub

Sorry, was out sick last week. This should be a relatively straightforward fix.. we're duplicating the error displaying somewhere, I can look into this.


Question about sample projects

Hi.
Can a sample project for one extension use another extension in it?

Yes

@LilyMakesThings  Thanks


Quick update to property name.

Fixes #4561
This fix will help give more context when reportback-items object is nested in other objects other than the reportbacks... for example, when they are nested in a kudos response object. See associated issue for code example.
@aaronschachter
CC: @jonuy @angaither @DFurnes @chloealee
PS> Will update the wiki shortly!

:+1:


Permit finish-args-flatpak-spawn-access for emacs

Based on the suggestion at https://github.com/flathub/org.gnu.emacs/pull/50 and some searching around, I get the impression that this would help move the aforementioned PR forward.


BugFix: Could not trigger CMake gen with BUILD_API_DOCUMENTATION=OFF

Target did not exist.

Hmph, it's still complaining
Exhale: the specified folder [C:\Users\Robadob\fgpu2_docs\build\api_xml] does not exist.  Has Doxygen been run?
May look into this further


PermanentlyClearPreviousMailboxInfo

I believe the published info is incorrect.  The parameter is only valid for Exchange Online, per the associated blog post.

Docs Build status updates of commit ed1db09:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-User.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 5f0a384:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-User.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@mprentice22153, there have been a couple of issues about this (#7028, #7078). What I think is the definitive answer is here:
https://github.com/MicrosoftDocs/office-docs-powershell/issues/7028#issuecomment-799715448:

Spoke with person assigned to my case today, and someone is working on updating the documentation. The switch is not supported in Exchange Online.

No question that the parameter is available. Whether or not the parameter is functional is the question. If you have other information, please advise.

The parameter and functionality is absolutely available within Office 365 Exchange Online.  Just ran it yesterday, hence my submission, on 80 mailboxes that were incorrectly created in EO.  Ran it a year ago within the same customer environment when we first setup the hybrid Exchange, and have run it in other customer EO environments.  I've never run it in an Exchange on-prem environment so I'm not aware that it actually works there and thus my confusion.

All of this was done against a M365 tenant. Actual domain removed but user account names are actual.
Get-user -Identity<EMAIL_ADDRESS>| select recip
PreviousRecipientTypeDetails RecipientType RecipientTypeDetails

UserMailbox                  MailUser      MailUser
Get-user -Identity<EMAIL_ADDRESS>| select recip
PreviousRecipientTypeDetails RecipientType RecipientTypeDetails

None                         MailUser      MailUser
set-user -Identity<EMAIL_ADDRESS>-PermanentlyClearPreviousMailboxInfo
Get-user -Identity<EMAIL_ADDRESS>| select recip
PreviousRecipientTypeDetails RecipientType RecipientTypeDetails

None                         MailUser      MailUser

This article is actually referenced in the set-user details for the PermanentlyClearPreviousMailboxInfo parameter and it clearly states the functionality is available to EO.
https://techcommunity.microsoft.com/t5/exchange-team-blog/permanently-clear-previous-mailbox-info/ba-p/607619

Docs Build status updates of commit 46bd2dd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

exchange/exchange-ps/exchange/Set-User.md
:white_check_mark:Succeeded
View (exchange-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

@mprentice22153, you had me at your first response, Updated to ExO only as you described (with editorial license and consistency with other parameters in the same fate).


django-health-check with django-audit-log

Hi,
I am trying to ignore django health check's TestModel from the auditlog app, but it doesn't seem to work.
Here is my setting,
# django auditlog
AUDITLOG_INCLUDE_ALL_MODELS = True
AUDITLOG_EXCLUDE_TRACKING_MODELS = (
    "health_check",
    "health_check.db.models.TestModel"
)

No matter what combination I add here, it always logs create, update, delete actions for the TestModel object.
Any insights on how I can ignore this model?

@2ykwang Could you please take a look?

@rahulkp220  Can you show the output when you run the code below in django shell?
python manage.py shell (--settings=<your settings>)

from django.apps import apps

apps.all_models["health_check"]

this code to check if health_check is the app name.

Hi @2ykwang , your question led me to the solution :)
I started testing as you suggested,
./manage.py shell --settings myproject.settings

>> from django.apps import apps
>> apps.all_models["health_check"]
>> {}

However, I given I had the following in my INSTALLED_APPS
    "health_check",
    "health_check.db",
    "health_check.cache",
    "health_check.storage",
    "health_check.contrib.migrations",
    "health_check.contrib.redis",

But, upon further checking, I found that django-health-check was storing the app names as
>> apps.all_models(
defaultdict(dict,
             ....
             'health_check': {},
             'db': {'testmodel': health_check.db.models.TestModel},
             'cache': {},
             'storage': {},
             'migrations': {},
             'redis': {},
             ....
)

So, I went ahead and added just db in my setting like this,
AUDITLOG_EXCLUDE_TRACKING_MODELS = (
    "db",
)

and it works now! 🎉
Thank you!

@rahulkp220 the app where TestModel is managed is health_check.db so you can try db.TestModel.


Milestone 2: upload images

upload local images or enter image url

great job, and thx help fix bug


Bump containerd/cgroups

Bumps containerd/cgroups@dbea6f2bd41658b84b00417ceefa416b97
Change-type: patch
Connects-to: https://github.com/docker/for-linux/issues/545
Signed-off-by: Robert Günzler<EMAIL_ADDRESS>

travis fails bc I still haven't gotten #162 in yet, I will go ahead and merge


feat: validate sidechain state roots

This validates sidechain state roots by first unwinding, trying to insert the new payload, and then re-committing the unwinded data.
Fixes #3060
Fixes #3057
TODO:

[x] fix latestValidHash - currently is incorrect for invalid payloads on forks
[x] remove unwraps

What's blocking us here?

What's blocking us here?

Need to convert some unwraps to errors, then this should be r4r

I'm split if we should go forward with this as an intermediate solution. imo we should have taken the in-mem diff approach instead of non-committing unwind

Agree that the in memory approach is strictly better, whether or not we want to merge this is there an issue for the in-memory design?

Update here, we can probably include this as an intermediate solution. Otherwise this just needs to be rebased

this needs some work because of error mapping since rebase - will update when this is working again

Ready for review now

converted to draft because this should not be merged - I'll check the hive results with this PR, post them here, and close the PR. This should give us a good idea of how far we'll get with hive tests if we implement sidechain root validation in some other way.

Hive results:
INFO[08-10|14:35:31] API: suite ended                         suite=0
INFO[08-10|14:35:32] simulation ethereum/engine finished      suites=1 tests=109 failed=7
7 tests failed

Closing the PR now


Query returns cached result in stead of latest

Description
I'm not sure if I am misunderstanding something about how dBeaver works, but it appears as if querys sometimes return a cached version of the data, in stead of the latest.
I'm a product manager, and must frequently run queries for either customer support or reporting reasons.
A developer and I would often work together, them making some change/update to the data, and I running a query to verify that I'm seeing the update on my end. Problem is, I often don't get the change on my side until I "invalidate/reconnect" the connection to the database itself.
I've been caught out multiple times by this, any insights or assistance would be greatly appreciated.
DBeaver Version
Community <IP_ADDRESS>304240616
Operating System
Windows 11
Database and driver
Database: MySQL hosted on AWS RDS Aurora (not sure of version?)
Connection: Via SSH on bastion host that lives within the VPC
DBeaver Driver: MySQL
Steps to reproduce

Prepare select statement with some joins that returns some data
On a remote connection, update some of this data
Re-run the select, and see how the data does not update
"Invalidate/Reconnect" the connection, re-run the query, and get the updated data back.

Additional context
Connection via SSH.

Hello @dj-louw
Could you please provide a video of your issue? I will be very appreciative.

Sure, I'll see what I can do. Dealing with sensitive information, but I might be able to get something done.

I have encountered the same problem as well.

It's been a while since no update here. If the issue is still actual please let me know and provide additional information.

Can I re-open this issue as we're seeing this behavior as well, also with AWS Aurora, so maybe it's something specific to jdbc properties or settings?

Please provide more details. At least video showing the issue or detailed steps to reproduce are required

Very straightforward:
DBeaver 23.0.3 with jdbc driver aws-mysql-jdbc-1.1.6.jar

New DB connection with driver defaults for connection properties
Open a table
View the grid or text result set
Hit the refresh button
Grid continues to show stale result values

Note that dBeaver does give the appearance of having re-executed the query at he bottom right of the UI showing execution time etc.
The only way to get an updated result set is to disconnect and reconnect.

I will  check shortly - also updating the jdbc driver from 1.1.6 to 1.1.8 just rule out a driver issue of some type.

OK We think we partially figured this out, maybe this is a usability bug, but if you set tx autocommit on (which is not the default) then the refresh works.  I can sort of understand why you might do this if you had made some uncommitted edits, but for it to behave this way just generally seems a weird decision - is it intentional?

Hello @miltontaylor
Maybe your case is described here: https://github.com/dbeaver/dbeaver/issues/20507 ?

Hmm, I don't see how that fits the picture. Firstly we're not doing any sort of db updates, just repeated selects with all dbeaver defaults.  Refresh should just work in this case. Do you not agree?

I believe it's not something that DBeaver do, but that's how things work. When you editing something together with your colleague, you're working in different connections to your database. Transaction - is something that can be rolled back, so while the transaction is not committed, changes are not visible outside the connection.
Why the transaction mode is not set to auto commit mode? Is it your local setting or you didn't touch it and that was the default for your connection?

@dj-louw It seems like something happens with transactions between you and your collegue
Can you check how those settings are set for both you and your collegue

Not editing the database, and this is not a multi-connection situation... single user just doing read-only refreshing of a query.

As before, if autocommit is ON this behavior does not exhibit. My question is, when we're not talking about updating the database here, so there is nothing to commit, why when autocommit is OFF it cannot re-fetch an updated result set?

I don't think this is DBeaver issue. Just set transaction mode to auto-commit.

I am also having same kind of issue with dbeaver where I am a single user of the database and the mysql database is installed on my dev machine. Its keep on getting the same data that was shown on the first execution of the select query.

I have the same issue as well. I'm connected to a remote db. I update the data via a website and get a confirmation back from the api. I refresh the data in dbeaver and it shows the old data. Nothing has changed. If I reset the connection and then refresh, it pulls the fresh data.

I have the same issue as well. I'm connected to a remote db. I update the data via a website and get a confirmation back from the API. I refreshed the data in dbeaver and it shows the old data. Nothing has changed. If I reset the connection and refresh, it pulls the fresh data.

I've found a workaround though. I have my connection with database with auto-commit: false. Now I click on "rollback" in case I am executing select queries. This has no impact on the underlying database table as first I am doing select statement and second I am clicking on "rollback" button. This way I don't need to again refresh/reset the connection.
Hope this issue gets sorted out soon.

That's how transactions work in databases. Enable auto-commit.

I have the same issue as well. I'm connected to a remote db. I update the data via a website and get a confirmation back from the api. I refresh the data in dbeaver and it shows the old data. Nothing has changed. If I reset the connection and then refresh, it pulls the fresh data.

I had faced this issue in early 2022 frequently and it just became a habit for me to re-connect my query windows before running any 'check if things worked' queries. Hopefully this gets resolved some day.

It happened to me yesterday. I saw different query results than a teammate until I re-opened the app.
Version <IP_ADDRESS>403031740


broken buffer for binary data in alter migration

adapter receive a broken buffer in createEach function for binary data while migrating in alter mode, in https://github.com/balderdashy/waterline/blob/master/lib/waterline/adapter/sync/strategies/alter.js
line 99 :
backupData = _.cloneDeep(existingData);

the original data is clone with lodash' cloneDeep,this is working for many value but not for buffer :
https://github.com/lodash/lodash/issues/311
this line should be change by :
backupData = _.cloneDeep(existingData, function dealWithBuffers(val) {
  if (val instanceof Buffer) {
    return val.slice();
  }
});

Sounds like the right idea to me.  Feel free to submit a PR!

@devinivy in which file/folder of test do you think this kind of tests should be ?

Good question!  There are adapter integration tests for that here: https://github.com/balderdashy/waterline-adapter-tests/tree/1d190d5c664f803bbe02fc160955d518c019f21e/interfaces/migratable

Yeah, migratable sounds like a good place for it.

@devinivy, @dmarcelino  why adding this test in waterline-adapter-tests ?
this is a waterline bug there is nothing that adapters developers can do...
waterline test shouldn't unsure that passed value to adapters are correct ?

You can create a unit test for this too.  Here are the unit tests: https://github.com/balderdashy/waterline/tree/master/test/unit
They generally mirror the directory structure of the waterline project itself, so you'll have to create the adapter folder in there to place the unit test.

@devinivy what do you think of it ?

Fixed via #1005. Thanks @atiertant and @khalilTN!


app.request & XMLHttpRequest a mystery CORS problem, or a bug?

I wonder if there is an issue with the use of app.request and CORS because my APP needs to request data from the remote server to serve the App all the CORS are OK and working perfectly if I send the POST request using XMLHttpRequest but when using app.request the reply from server it is all the time but curiously not always but with XMLHttpRequest it is constant OK :
server reply using app.request Ajax call:
 **_not allowed by Access-Control-Allow-Origin_**.

this works perfect all the time no problems with CORS.
var xhr = new XMLHttpRequest();
xhr.onreadystatechange = function() {
    if (xhr.readyState == 4 && xhr.status == 200) {
        var json = JSON.parse(xhr.responseText);
        console.log(json);
    }
};
xhr.open('POST', 'http://oauth.mydomain.com/auth/', true);
xhr.withCredentials = false;
xhr.setRequestHeader("Content-type", "application/json;charset=UTF-8");
xhr.onload = function() {
    if (xhr.status === 200) {
        console.log(xhr.responseText);
    } else {
        console.log('Request failed.  Returned status of ' + xhr.status);
    }
};
var data = JSON.stringify({
    "Token": "token_code_here"
});
xhr.send(data);

and now with app.request it works and suddenly stop working again :( no clues why but it happens only if I use app.request Ajax call... so maybe there is something here...
data = {
    Token: token_code_here
};
app.request({
    url: 'http://oauth.mydomain.com/auth/',
    method: "POST",
    dataType: "json",
    data: data,
    crossDomain: true,
    beforeSend: function(xhr) {
        xhr.withCredentials = false;
    },
    success: function(res) {
        console.log(res);
    },
    error: function(xhr) {
        console.log('error');
        console.log(xhr);
    }
});

again server reply using app.request Ajax call:
 **_Origin is not allowed by Access-Control-Allow-Origin._**.

Any clues how to fix this? CORS on server are fine defined but works well only when using XMLHttpRequest Ajax call...
:(

I have been reading about some topics about Ajax and CORS and found out this:
https://zqzhang.github.io/blog/2016/04/18/why-use-onload-in-cross-domain-ajax.html
Maybe app.request works in the same way as onreadystatechange... I do not know if this is so but make sense why XMLHttpRequest works always instead of app.request...
any ideas?

Request uses same XMLHttpRequest and it uses onload too. So would be good to see live example of where it is not working

Yes the response has it all!!! and  'Access-Control-Allow-Origin: *'  too... very weird this thing :(
I will try to make a live example and post the link... here...
thanks for helping..

It still problem


Consider updating census data

The current county-level population data provided by county_census is the Vintage 2019 data. Would it be possible to add the Vintage 2021 as well from the US Census Bureau? This would be helpful for individuals looking to calculate proportions when combining covidcast data with external sources.

To my knowledge, we don't provide population information through Epidata. Can you say a little more about where you're encountering county_census?
As an alternative, I recommend the geomap module of the delphi-utils package on PyPI, which has whatever was the latest population data available from US Census in February 2022.

county_census is an object in the covidcast package.  Seems like it's generated here.  Looks like part of this was prepared separately by hand, so updating might be a bit more involved (not just pointing to new URL and updating column names).

It's not an urgent issue by any means, and the geomap module looks like it will be helpful. Thank you!

I'll add a note to the covidcast docs directing people to delphi_utils instead -- the covidcast packages are only receiving functionality-critical updates.


Fix Travis issue with Solidus old versions (Factory Bot gem)

For Solidus versions older than v2.5 gem factory_bot 4.10.0 must be used
for compatibility reasons.

@spaghetticode thanks! Build is still failing will almost all Postgres builds, do you want to take a look at that as well please? Maybe another PR?


Make picking up cards beautiful

Use CSS to add a bigger dropshadow when you pick up a card, so that it is obvious that this card is picked up.

i believe this is done?

Yup


Switched to new container can connect API

This commit replace the obsolete container.is_ready() API
with the container.can_connect() method. It is just a single
line change despite appearences, because all the code that
was previously nested in the context manager is now unindented
one level but guarded with the can_connect() method.

You could consider adding a self.unit.status = WaitingStatus("waiting for Pebble API") before the early return

You could consider adding a self.unit.status = WaitingStatus("waiting for Pebble API") before the early return

Good point will add it into next PR.


Error when building helloworld example

I'm getting this error when trying to compile the hello world example with mvn clean install -Phelloworld.
After importing the projects into Eclipse, I'm also getting the following errors:

@barnettwilliam this is perhaps something that would be useful to run as a GitHub Action in this repository?

Thanks, both. I had not cloned platformtools. I should have paid more attention but a hyperlink could be added in the documentation to highlight that this is a separate repository.
Nonetheless, after cloning the repo, and execute mvn clean install -Pall, I'm getting the error below:
PS C:\Users\ab373\Documents\git-mde-education> git clone https://github.com/mdenet/platformtools.git
Cloning into 'platformtools'...
remote: Enumerating objects: 810, done.
remote: Counting objects: 100% (65/65), done.
remote: Compressing objects: 100% (59/59), done.
Receiving objects: 100% (810/810), 300.34 KiB | 4.42 MiB/s, done.

Resolving deltas: 100% (299/299), done.
PS C:\Users\ab373\Documents\git-mde-education> cd .\platformtools\
PS C:\Users\ab373\Documents\git-mde-education\platformtools> mvn clean install -Pall
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.066 s
[INFO] Finished at: 2023-06-29T17:20:36+01:00
[INFO] ------------------------------------------------------------------------
[WARNING] The requested profile "all" could not be activated because it does not exist.
[ERROR] The goal you specified requires a project to execute but there is no POM in this directory (C:\Users\ab373\Documents\git-mde-education\platformtools). Please verify you invoked Maven from the correct directory. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MissingProjectException

Ups, missed cd ./services, working through it now.

It built well (after a good half an hour). However, the project helloworld is still missing a bundle dependency:

Yes the first time building takes a while, it should be much quicker subsequently.
Is the eclipse target platform set to the target file that's in the project com.mde-network.ep.toolfunction.helloworld?
So under Window > Preferences and then in preferences panel dialog box that appears and under Plug-in Development > Target Platform in the left hand panel, make sure the mdenettoo-helloworld target file is active (shown in the screenshot).
If it isn't select and apply it. I've also found that I have to restart eclipse after changing target files for it to be picked up.

@barnettwilliam is it worth adding that step to the documentation if it's not there already?

@barnettwilliam is it worth adding that step to the documentation if it's not there already?

Agreed, I've updated the readme to include some eclipse setup details, some mandatory maven plugins Artur and I came across today that are required, and added a link to platformtools.


Results view commit date format

Hi, thank you for the great work on the project!
I'm just curious if it's possible to change gitlens result view to show the actual date of commit:

Sometimes it's more convenient to know an exact date, to find in an external git client. Deducting 28 days from today isn't a trivial task 😉. For example 28 days ago, Feb 25, 2018

BTW the same applies to inline code highlights and on-hover popup. Maybe it's possible to make it configurable.

You can control this today. Although it is spread across a few places.
First you can set "gitlens.defaultDateStyle": "absolute" (rather than the default relative), and that will change all the dates that don't have specific overrides to use the gitlens.defaultDateFormat. See https://github.com/eamodio/vscode-gitlens#general-settings
Then you would also need to change the format templates for each of the other areas you wish to control.
For the current line blame, see https://github.com/eamodio/vscode-gitlens#current-line-blame-settings

gitlens.currentLine.format change that to use {date} rather than {ago}

For the gutter blame, see https://github.com/eamodio/vscode-gitlens#gutter-blame-settings

gitlens.blame.format change that to use {date} rather than {ago}

For the status bar, see https://github.com/eamodio/vscode-gitlens#status-bar-settings

gitlens.statusBar.format change that to use {date} rather than {ago}

For the GitLens and GitLens Results views, see: https://github.com/eamodio/vscode-gitlens#explorer-settings

gitlens.explorers.commitFormat change that to use {date} rather than {ago}
gitlens.explorers.stashFormat change that to use {date} rather than {ago}

Given how many options need to be tweaked here, I think I will introduce 2 new tokens agoOrDate and authorAgoOrDate, and then will switch the defaults of all those formats to use those rather than ago and authorAgo. And the behavior of  agoOrDate and authorAgoOrDate would honor the gitlens.defaultDateStyle setting.
Thank you for the report and I hope that helps!

Thank you for such a detailed answer and good news on a new feature! :)


Cancelled reports are not displayed when clicking on an organization's bar in the Daily Rollup

The requirements owners are requesting to see the cancelled reports listed after clicking on an organization's bar in the Daily Rollup.
Currently only released reports are listed after clicking an organization's bar in the Daily Rollup.
I think there was a reason why cancelled reports weren't listed, but I can't remember the reason.  Maybe an initial requirement?
This issue is similar to #258.

The requirements owners refined their request.  They want the requirements for #258.
I am closing this issue.


[10.x] forceCreate on MorphOne result in a NULL _type column

Description
This PR fixes an inconsistent behavior with the morphOne relation. When having a morphOne scenario, calling forceCreate on the MorphOne instance results in a NULL *_type column if it's a nullableMorph, or an error otherwise. The create method, in contrast, works correctly.
How to reproduce

Create the table and the model that hold the morph

Schema::create('roots', function (Blueprint $table) {
    $table->id();
    $table->string('root_name');
    $table->nullableMorphs('rootable');
    $table->timestamps();
});

class Root extends Model
{
    public function rootable(): MorphTo
    {
        return $this->morphTo();
    }
}

Create the table and the model that uses the morph

Schema::create('leaves', function (Blueprint $table) {
    $table->id();
    $table->string('name');
    $table->timestamps();
});

class Leaf extends Model
{
    public function root(): MorphOne
    {
        return $this->morphOne(Root::class, 'rootable');
    }
}

Now try to forceCreate

$leaf = Leaf::find(1);
if(empty($leaf)) {
  $leaf = Leaf::forceCreate([
    'name' => 'Hi'
  ]);
}

$leaf->root()->forceCreate([
  'root_name' => 'Hello'
]);

This will result in a row in the roots table with:

rootable_id = 1
rootable_type = NULL

Why this wasn't spotted in the tests
The test file that should have spotted this issue contains a typo.
The row that instantiates the morph uses morphMany instead of morphOne -> Permalink to the row
How this PR solves the problem
The forceCreate method proxies the request to the related forceCreate method. I've changed this behavior by unguarding the related and proxying the request to the create method.
Test files have been updated accordingly.

Please fix the method only on the MorphOne class and do not change the relationship type in the test you modified. Thank you.

I'm also not sure if unguarded should be used here.

https://github.com/laravel/framework/commit/cc3f090e6064a769920a4fda90d8a827f0526252

Thank you @taylorotwell
Seems fine for me, waiting for the next release.
Best.


Replace the use of pkg/errors with native error wrapping

currently we're using errors.Wrap. Since Go 1.13 we can instead use the stdlib
if err != nil {
    return fmt.Errorf("bad thing happend: %w", err)
}

@yurishkuro
I'll give you a resolve this issue, I experienced the making a resolution of same  error-wrapping issue (https://github.com/tektoncd/pipeline/pull/808) using xerrors.
Of course, I know we can wrap with current fmt libraries as you referred.


[MM-21753] Document process for Community Plugins in the Marketplace

Summary
Document process for Community Plugins in the Marketplace as described in the spec: https://docs.google.com/document/d/1ttY27VXdWy07X73sBIg1fLY9uTo2oscX79bqlAZE4cg/edit#
I also updated community_process.md to reflect the new process.
The Side bar now looks like this:

Ticket Link
https://mattermost.atlassian.net/browse/MM-21753

@lieut-data @jfrerich Maybe we can avoid having to duplicate the full Requirements list here and in the issue template by remove it from this document and just linking to the issue template. That would make sure there is only a single source of truth.
Let me know what you think about this.

@hanzei, I'd love for there to be a single source of truth, but I feel like the issue template might be "too late" in the process. Yes, we could link to it, but it's not really meant to be read outside the context of submitting a PR. 0/5 on this, since we can easily iterate, but perhaps duplicating for now might still make the most sense.


Automatically chdir to /vagrant on login

Issue/Task Number: N/A
Overview
This might look silly but this has been annoying me for months. This PR automatically runs cd /vagrant when logging in to the VM from vagrant ssh.
Without it, each time I login to the VM, I need to type cd /vag + tab to not conflict with cd /var.
This is as energy-wasting as proof-of-work!
Changes

Added cd /vagrant to .bashrc if it does not exist

Implementation Details

Added a new Ansible task as bashrc.yml
The file .bashrc already exists and we want to add cd /vagrant only if it doesn't exist. So we need to check using grep first, then add the line if grep produces no result.

Usage
From your goban directory on your host machine, run vagrant provision. The provisioning should complete successfully and you should see the following tasks completed:
TASK [commons : Find `cd /vagrant` line in .bashrc] ****************************
changed: [ewallet]

TASK [commons : add `cd /vagrant` to .bashrc if it doesn't exist yet] **********
changed: [ewallet]

Impact
Pull the latest commit. Run vagrant provision from your host machine.

Probably better to provide a default .bashrc as a file or template. I'll take a look at this later.

There's a lot of goodies that comes with the original .bashrc though. Not sure if we want to maintain the file ourselves...
# ~/.bashrc: executed by bash(1) for non-login shells.
# see /usr/share/doc/bash/examples/startup-files (in the package bash-doc)
# for examples

# If not running interactively, don't do anything
case $- in
    *i*) ;;
      *) return;;
esac

# don't put duplicate lines or lines starting with space in the history.
# See bash(1) for more options
HISTCONTROL=ignoreboth

# append to the history file, don't overwrite it
shopt -s histappend

# for setting history length see HISTSIZE and HISTFILESIZE in bash(1)
HISTSIZE=1000
HISTFILESIZE=2000

# check the window size after each command and, if necessary,
# update the values of LINES and COLUMNS.
shopt -s checkwinsize

# If set, the pattern "**" used in a pathname expansion context will
# match all files and zero or more directories and subdirectories.
#shopt -s globstar

# make less more friendly for non-text input files, see lesspipe(1)
#[ -x /usr/bin/lesspipe ] && eval "$(SHELL=/bin/sh lesspipe)"

# set variable identifying the chroot you work in (used in the prompt below)
if [ -z "${debian_chroot:-}" ] && [ -r /etc/debian_chroot ]; then
    debian_chroot=$(cat /etc/debian_chroot)
fi

# set a fancy prompt (non-color, unless we know we "want" color)
case "$TERM" in
    xterm-color|*-256color) color_prompt=yes;;
esac

# uncomment for a colored prompt, if the terminal has the capability; turned
# off by default to not distract the user: the focus in a terminal window
# should be on the output of commands, not on the prompt
#force_color_prompt=yes

if [ -n "$force_color_prompt" ]; then
    if [ -x /usr/bin/tput ] && tput setaf 1 >&/dev/null; then
	# We have color support; assume it's compliant with Ecma-48
	# (ISO/IEC-6429). (Lack of such support is extremely rare, and such
	# a case would tend to support setf rather than setaf.)
	color_prompt=yes
    else
	color_prompt=
    fi
fi

if [ "$color_prompt" = yes ]; then
    PS1='${debian_chroot:+($debian_chroot)}\[\033[01;32m\]\u@\h\[\033[00m\]:\[\033[01;34m\]\w\[\033[00m\]\$ '
else
    PS1='${debian_chroot:+($debian_chroot)}\u@\h:\w\$ '
fi
unset color_prompt force_color_prompt

# If this is an xterm set the title to user@host:dir
case "$TERM" in
xterm*|rxvt*)
    PS1="\[\e]0;${debian_chroot:+($debian_chroot)}\u@\h: \w\a\]$PS1"
    ;;
*)
    ;;
esac

# enable color support of ls and also add handy aliases
if [ -x /usr/bin/dircolors ]; then
    test -r ~/.dircolors && eval "$(dircolors -b ~/.dircolors)" || eval "$(dircolors -b)"
    alias ls='ls --color=auto'
    #alias dir='dir --color=auto'
    #alias vdir='vdir --color=auto'

    #alias grep='grep --color=auto'
    #alias fgrep='fgrep --color=auto'
    #alias egrep='egrep --color=auto'
fi

# colored GCC warnings and errors
#export GCC_COLORS='error=01;31:warning=01;35:note=01;36:caret=01;32:locus=01:quote=01'

# some more ls aliases
#alias ll='ls -l'
#alias la='ls -A'
#alias l='ls -CF'

# Alias definitions.
# You may want to put all your additions into a separate file like
# ~/.bash_aliases, instead of adding them here directly.
# See /usr/share/doc/bash-doc/examples in the bash-doc package.

if [ -f ~/.bash_aliases ]; then
    . ~/.bash_aliases
fi

# enable programmable completion features (you don't need to enable
# this, if it's already enabled in /etc/bash.bashrc and /etc/profile
# sources /etc/bash.bashrc).
if ! shopt -oq posix; then
  if [ -f /usr/share/bash-completion/bash_completion ]; then
    . /usr/share/bash-completion/bash_completion
  elif [ -f /etc/bash_completion ]; then
    . /etc/bash_completion
  fi
fi

The default .bashrc attempt to provides all kind of sane defaults for all terminal combination, so we can remove pretty much all of that since we provisioned the whole setup ourselves :-)
For a reference, my personal .bashrc looked like this before I switched to ZSH.

bashrc
bash_profile
profile

Right. The next question is probably ... what should we keep as our default? Especially when this project is likely used by a lot more people beyond the OMG team.
I'm ok to start with the default .bashrc though. The colored prompt & colored ls is definitely useful to me.

I'd say something like this would be good enough defaults:
[[ $- != *i* ]] && return
[[ -s /etc/bash.bashrc ]] && source /etc/bash.bashrc
[[ -s ~/.bash_aliases ]] && source ~/.bash_aliases

shopt -s checkwinsize
shopt -s histappend
HISTCONTROL=ignoreboth
HISTSIZE=1000
HISTFILESIZE=2000

PS1="\[\033[01;32m\]\u@\h\[\033[00m\]:\[\033[01;34m\]\w\[\033[00m\]\$ "

alias ls='ls --color=auto'
alias ll='ls -l'
alias la='ls -A'
alias l='ls -CF'

alias grep='grep --color=auto'
alias fgrep='fgrep --color=auto'
alias egrep='egrep --color=auto'

[[ $- != *c* ]] && cd /vagrant


fix CI deadlock when testing known vulnerabilities

After some investigation on why CI would block on #304 and #290, it is the same problem encountered in #265: asan is randomly deadlocking on us. It seems to only happen every time test_wolfssl_openssl_test_seed_cve_2022_38153 is not run last. Running rustc with --test-threads 1 apparently solves the problem but is not convenient for the current CI scripts.
This PR introduces a timeout argument for the tests on known vulnerabilities and retries several times if we fail to observe the crash. Until the problem is fixed upstream, this seems like the most sensible way to handle the problem without disabling the tests.
See also:

upstream issue: llvm/llvm-project#63224

This one is very annoying. I think it is fine to ignore that for now, but it is unlikely this will get fixed ever.

This one is very annoying. I think it is fine to ignore that for now, but it is unlikely this will get fixed ever.

Yes, that's unfortunate but we don't have much influence on the priorities of fixes in llvm. I also don't think it would be reasonable to spend the time to investigate the internals of asan further in order to develop a fix.
Anyway, I think it is a good practice to set a timeout and retry executions where we expect a crash. So I guess the time spent here was not in vain.


added support for pc/sc readers

Rewrite of the pc/sc-support mentioned in #533  with help of pyscard instead of rfidiot which doesn't seem to work with python3 anymore.
Requirements: installed pcscd and python-pyscard packages. First found reader is used for reading tags.

Hi, thanks for providing this PR and extending Phoniebox.
Could you please also add a sub directory here
https://github.com/MiczFlor/RPi-Jukebox-RFID/tree/develop/components/rfid-reader and add the following info:

README.md with details how to install and use the reader
sh script to automate installation as much as possible
requirements.txt file containing required python packages

Please see the other readers in that directory for examples.
If you have any questions please let us know.

Hi, thanks for providing this PR and extending Phoniebox.
Could you please also add a sub directory here
https://github.com/MiczFlor/RPi-Jukebox-RFID/tree/develop/components/rfid-reader and add the following info:

README.md with details how to install and use the reader
sh script to automate installation as much as possible
requirements.txt file containing required python packages

Please see the other readers in that directory for examples.
If you have any questions please let us know.

Hi @anicoa
this is a great contribution. For new custom hardware, we want to move all the code into the components folder, so that experts can pick what they need and newbies don't get confused by the many options and scripts flying around.
Could you please add your scripts in a sub directory here
https://github.com/MiczFlor/RPi-Jukebox-RFID/tree/develop/components/rfid-reader and add the following info:

README.md with details how to install and use the reader
sh script to automate installation as much as possible
requirements.txt file containing required python packages

Please see the other readers in that directory for examples.
Thank you!


fix(analyze)!: Update Wasm with phone-number fix and tokenizer update

Regenerates the wasm bindings to add some more supported phone number formats to the sensitive info identifier.

I'm going to label this as a breaking fix since it changes the tokens that users could be receiving in custom detect functions.


Not getting Push Notification iOS

What version of RN and react-native-fcm are you running? 0.48.4 , 9.6.2
What device are you using? (e.g iOS9 emulator, Android 6 device)? iPhoneSe iOS11.1.1
Is your app running in foreground, background or not running?

I am trying to send a push notification from firebase console to my ios device but not getting it.
I have checked, I am getting FCM token, APNs token and also I turned on Push Notification setting in my device.
When I look into Firebase console Dashboard, I see active users which might be my device. But if I send a push notification and click the message, the graph said the message is sent to 0 person. APNs Auth Key is uploaded well too.
I am thinking it might be an issue of iOS version. does this library work well with iOS 11.1.1?

yes it should work.
try send to api endpoint?

yes there is no problem with the iOS version but I mistook on my code side.


Watch and warn on rename or delete events for the root index.html file

This is part of https://github.com/mozilla/thimble.mozilla.org/issues/1569#issuecomment-258889724.  It adds an extra extension (not loaded by default--it will need to be enabled in Thimble) to watch and warn on any delete or rename to the project's root index.html file.
To test this, do the following:

npm run build
npm start
load http://localhost:8000/src/hosted.html?enableExtensions=bramble-watch-index.html (NOTE: the extension must be manually enabled in the URL)
Make sure you have an index.html file, then try right-clicking and Rename and Delete.  Both should show a modal dialog with info.

I'm not sure if the text I've got in the dialog is right.  I want to do another patch in Thimble that offers to create an index.html on publish, but decided to only warn about the issue here.
I've also added jshint excludes for src/nls to stop jshint complaining about strings as if they are code, and breaking the build.
r? @gideonthomas, @flukeout

If you get a chance, can you copy and paste a screenshot of how this dialog looks? Don't have my env up and running at the moment. I'll work on some copy ideas and paste them here in a bit.

I'm thinking of something along the lines of...
You need an index.html page!
Projects that don't contain an index.html page will appear broken to viewers, it's the first page that the browser tries to load.
Question: when does this dialog pop-up? As soon as you right click and delete / rename? Are there an Undo or Do it anyway type buttons on the dialog?

@gideonthomas I've updated this PR, and also split out the Thimble bits into https://github.com/mozilla/thimble.mozilla.org/pull/1580

Ok looks like this works!
@humphd could you also add these three lines above this one: https://github.com/mozilla/brackets/blob/master/scripts/properties2js.js#L174
var DSStoreIndex = folders.indexOf(".DS_Store");
if(DSStoreIndex > -1) {
    folders.splice(folders.indexOf(".DS_Store"), 1);
}

I was constantly blocked from proper l10n running on Macs.
After that I think this code is good to merge

@flukeout here's the screenshot:

I'm confused about strings again.  Are you saying I need the strings here (Bramble) and in Thimble? Or just in Thimble?
Also, I updated the strings to a version of what Luke wrote already.

@humphd no sorry, the strings are fine in Thimble, you don't need them in Bramble.
The code that I provide above (unrelated to your patch) just ignores .DS_Store when it runs npm run localize because it was throwing errors since it tries to localize files in .DS_Store on Macs.

@gideonthomas can you just take one last look at this?  I made your change, but also remembered that I had to manually add the new extension to the service worker precache list.
Also, remind me how you want this landed.  Do I squash, then land the PR in GitHub?  I can't remember your preference.

r=me

@gideonthomas reasking..."Also, remind me how you want this landed. Do I squash, then land the PR in GitHub? I can't remember your preference."

@humphd you can use the "squash and merge" button in this pr to merge it in.


Ability to send e-mail from Business Central

Currently SMTP functionality can be used to send e-mails from the base application in Business Central. This integrates with for instance posted sales documents. We use the functionality heavily and it has been working without problems.
There are now however safer method(s) to send e-mails, a lot has happened since SMTP has been introduced in the 80's. Is it possible to provide us with functionality that integrates with the standard application (for f.i. sending Sales Invoices) that makes use of those safer method(s)?
The reason I'm asking this is that it seems that SMTP doesn't work in combination with two-factor auth. We found this out because of the new requirements for all CSP's to enable two-factor authentication for all users. The only way we could send e-mails from Business Central now is when we enable legacy applications for an account. Can two-factor auth also be taken into account when considering this request?

Hi @Pieter-kok, we do support accounts with MFA. However you are required to use an App password. The following are some documentation to help you with this.
https://docs.microsoft.com/en-us/dynamics365/business-central/admin-how-setup-email
https://docs.microsoft.com/en-us/dynamics365/business-central/across-faq#can-i-use-multi-factor-authentication
https://docs.microsoft.com/en-us/azure/active-directory/user-help/multi-factor-authentication-end-user-app-passwords
If you have further issues, please re-open the issue.
-Darrick

According to our tests, the app passwords only work when ‘enable legacy applications’ is enabled. Can you please elaborate on your statement?

Hi @darjoo
According to our tests, the app passwords only worked when ‘enable legacy applications’ is enabled. Can you please elaborate on your statement?
We are aware that app passwords should work, but they didn’t.

Hi @pieter-kok,
What do you mean by 'enable legacy applications'? This isn't a setting that I know of unfortunately.
By using the https://docs.microsoft.com/en-us/azure/active-directory/user-help/multi-factor-authentication-end-user-app-passwords documentation, you'd be able to set up an App Password for the specific account. But I assume you already knew that, I'm unclear as to what elaboration you're looking for.

Hi @darjoo,
We created an app password again for SMTP this morning to check whether it started working.
This wasn't the case.
When we disable the baseline policy: Block legacy authentication (see: attachments), the app password works. As a CSP we are not allowed to disable this policy. But with this policy enabled we cannot make use of the SMTP functionality of Business Central.

The kind of elaboration I was looking for is some guidance with this problem. Our perception is that app passwords don't work with this policy enabled. What can we do as a CSP to both apply to Microsoft policy and make use of Business Central at the same time.
We would also encourage development of a standard e-mail functionality using Graph instead of SMTP, as an alternative to this old protocol.

Hi @pieter-kok,
Thanks for the additional information. I'll investigate into that setting and if we have any workaround this.

@darjoo keep in mind that there are other issues with the SMTP functionality. This issue is blocking, but having no control regarding the sender and no insight in the send emails is also a hassle.


Create Domain model

Create domain model based on DDD dictionary that should be listed on the Wiki page
Create unit tests

Good reading to understand why to avoid Anemic Domain Model
https://www.martinfowler.com/bliki/AnemicDomainModel.html


This condition will always return 'false' since the types have no overlap.

Bug Report
When writing code, I sometimes want to test out several implementations and flip between them over time. One simple way to flip back and forth is just to add a constant to the code and change it when I want. I'll probably remove it or add some build def or url param to control it more explicitly later on, but for now I just want to write it this way. TypeScript makes this annoying because of the control flow analysis.
🔎 Search Terms
Control flow
This condition will always return 'false'
🕗 Version & Regression Information

I don't think this is a regression - this is clearly intended behavior but I don't want it.

⏯ Playground Link
https://www.typescriptlang.org/play?#code/KYOwrgtgBAsg9gE2FA3gKClAglAvFABgBoMoAhPKARhIF8BuNNAYzhAGcAXWAeQBEAopXhIAdGUZoAlgDMoAChj8huVbETBRWAJSpMAen1QBAJxNwTALigAVABZT2UViARTOUtlADuUgDZ+UACGft5BAJ5OJsCcYCYgUADkMiHswIlQ7FIgzMicdnnhAA7ATokimmQZQa5JFVoZdkEAbsggcFBwrSZ+QUWiGIZQCB3scBAxDiAA5mi0UMB+aaiDRiOZ45PZ0wtLwHNMQ-aOPhYA1uzScorKwU4VeGr1OisHQA
💻 Code
enum Mode {
  A = 0,
  B = 1,
};

const MODE = Mode.B;

if (MODE === Mode.A) {  // Error: This condition will always return 'false' since the types 'Mode.B' and 'Mode.A' have no overlap.
 // do something
} else {
 // do something else
}

🙁 Actual behavior
Error: This condition will always return 'false' since the types 'Mode.B' and 'Mode.A' have no overlap.
🙂 Expected behavior
Just compile and let me write the code that I intended. I have never benefitted from this type of control flow analysis, and this should be a warning at most, not an error.
I was able to work around it by adding a cast, but it looks unnecessary:
if (MODE as Mode === Mode.A) {

You can aim at the desirable compiler behavior by simply adding explicit any to the type of const:
const MODE: any = Mode.B;

This detects all kinds of logic bugs and we're not interested in turning it off

The original code would cause the same error if MODE was a var instead of a const. In that case MODE value may change at any time so it would be wrong to throw an error.


Notebook samples do not work

Operating System
Windows
Version Information
Operating System
Windows
Version Information
Python Version: 3.12.2
I am following the notebook sample verbatim found HERE. It does not work.
The cell where you prep the assistand with the file_ids throws:
NotFoundError: Error code: 404 - {'error': {'code': '404', 'message': 'Resource not found'}}
Steps to reproduce
Just try to run the sample.
Expected behavior
It should be able to answer the questions using process_message
Actual behavior
Error code: 404 - {'error': {'code': '404', 'message': 'Resource not found'}}
Addition information
No response

Are you using a gpt4 1101 deployment? I got this error when using GPT3.5.

Are you using a gpt4 1101 deployment? I got this error when using GPT3.5.

Hi I am using Model name: gpt-4
Model version: 1106-Preview

Duplicate of #58

I was running into the same issue. However, from this documentation it's important to ensure you use the right API version (at the time of reference 2024-02-15-preview). I was using the wrong API version and getting the error code listed above.


Improved interop for StepTimer with a new Event C API

Currently, the interop implementation for NovelRT::Timing::StepTimer is broken. Here are some problematic snippets:
NrtResult Nrt_StepTimer_create(uint32_t targetFrameRate, double maxSecondDelta, NrtStepTimerHandle* output)
{
    // null-check omitted
    NovelRT::Timing::StepTimer timer = NovelRT::Timing::StepTimer(targetFrameRate, maxSecondDelta); // It's in the stack...
    *output = reinterpret_cast<NrtStepTimerHandle>(&timer); // Returning a pointer to the stack?!?
    return NRT_SUCCESS;
}

NrtTimestamp Nrt_StepTimer_getTargetElapsedTime(NrtStepTimerHandle timer)
{
    NovelRT::Timing::Timestamp* time = new NovelRT::Timing::Timestamp(0); // Allocating an int64 to the heap
    *time = reinterpret_cast<NovelRT::Timing::StepTimer&>(timer).getTargetElapsedTime(); // That reference-cast seems wrong
    return reinterpret_cast<NrtTimestamp&>(*time); // That NrtTimestamp is now pointing to undestroyable heap memory!
}

NrtResult Nrt_StepTimer_setTargetElapsedTime(NrtStepTimerHandle timer, NrtTimestamp target)
{
    // null-check omitted
    NovelRT::Timing::StepTimer time = reinterpret_cast<NovelRT::Timing::StepTimer&>(timer); // Casting a handle as a reference
    time.setTargetElapsedTime(NovelRT::Timing::Timestamp(target)); // Segfault!
    return NRT_SUCCESS;
}

Probably that StepTimer could previously fit in int64_t, which would explain the reference-casts. Anyway, that code does not work. That PR is going to fix this, and implements APIs for NrtUtilitiesEvent and NrtUtilitiesEventWithTimestamp to make fully usage of the StepTimer. Hopefully, C maniacs will now experience the niche pleasure of staring at a timer ticking excessively fast.
Additions and renovations

The StepTimer interop implementation has been mostly rewritten
Methods have been added to create Event<> and Event<NovelRT::Timing::Timestamp>, add event listeners, and invoke them in C.

Implementation remarks
In the NrtEvent.cpp file, there are templated "generic" versions of methods and a EventImplementationDetails struct to easily add more event types in the future in necessary. (It's macro-free!)

Almost ready to merge! (let's wait for CI, and please squash though)

No squash. We'd like to preserve history as-is (even if there's large gaps in history).
Good stuff!


Avoid running "grunt test"

I've got some projects without tests. How can I set this up so that it does not run 'grunt test' ?

You can use the <yo.test.skip>true</yo.test.skip> property in the plugin configuration.

Great!
so something like
      <plugin>
        <groupId>com.github.trecloux</groupId>
        <artifactId>yeoman-maven-plugin</artifactId>
        <version>0.2</version>
        <configuration>
          <yeomanProjectDirectory>../spa</yeomanProjectDirectory>
          <yo.test.skip>true</yo.test.skip>
        </configuration>

??

Yes

Mmmm... for some reasons it still runs grunt test. Here's my pom (well... part of it):
      <plugin>
        <groupId>com.github.trecloux</groupId>
        <artifactId>yeoman-maven-plugin</artifactId>
        <version>0.2</version>
        <configuration>
          <yeomanProjectDirectory>../spa</yeomanProjectDirectory>
          <yo.test.skip>true</yo.test.skip>
        </configuration>
        <executions>
          <execution>
            <goals>
              <goal>build</goal>
            </goals>
          </execution>
        </executions>
      </plugin>

And here's the output:
[INFO] grunt version :
grunt-cli v0.1.13
grunt v0.4.5
[INFO] --------------------------------------
[INFO]          GRUNT TEST --NO-COLOR
[INFO] --------------------------------------
Warning: Task "test" not found. Use --force to continue.

Sorry, I gave you wrong information.
Could you try with this config :
    <plugin>
        <groupId>com.github.trecloux</groupId>
        <artifactId>yeoman-maven-plugin</artifactId>
        <version>0.2</version>
        <configuration>
          <yeomanProjectDirectory>../spa</yeomanProjectDirectory>
          <skipTests>true</skipTests>
        </configuration>
        <executions>
          <execution>
            <goals>
              <goal>build</goal>
            </goals>
          </execution>
        </executions>
      </plugin>

I tried it, worked great.  Thanks!
Are the other configuration parameters different as well?  The docs I read say:
yo.build.skip - to skip the build.
yo.skip - to skip the entire yeoman build.
Have those switched to:
skipBuild and skip?

It works! You can close this

@KedneckInc yo.build.skip and yo.skip are properties to use from command line to override your pom configuration


add firefox support

an firefox extension would be quite nice

Firefox support is already added. Installation instructions are in the description in Manual installation section


use tokens instead of shares on account balance

#50 and #159 (only supported by v0.36 and after)

tested.


simplify manual, e.g. dedicated machine

Todo

manual needs to be simpler for beginners e.g. around dedicated machines too confusing

Reference

https://git.ourworld.tf/tfgrid/circle_engineering/issues/32

Complete when #485 is merged.

Closing since we remove dedicated nodes section. Will be in node finder in ongoing PR #514


SMTP Test tool failed to test emails

I used gmass for smtp test. When i tried to test my postal server setup, following error occurs:

I have used lets encrypt for certificates. Aslo below are my postal config for TLS setting
smtp:
host: mydomain.com
port: 2525
username: # Complete when Postal is running and you can
password: # generate the credentials within the interface.
from_name: Postal
from_address<EMAIL_ADDRESS>smtp_server:
port: 25
tls_enabled: true
tls_certificate_path: /etc/letsencrypt/live/mydomain.com/fullchain.pem
tls_private_key_path: /etc/letsencrypt/live/mydomain.com/privkey.pem
tls_ciphers:
ssl_version: TLSv1_1
proxy_protocol: false
log_connect: true
strip_received_headers: false
max_message_size: 14
spamd:
enabled: true
host: <IP_ADDRESS>
port: 783
clamav:
enabled: true
host: <IP_ADDRESS>
port: 2000

Should i need to allow port 587 for this purpose ?

The issues has been resolved now. The issue was with the SSL_Version. Which was set to tls1.1, changing the version to 1.2 solved the issues.

Good to know, glad you figured it out


Parallel checkpoint execution

Description
Add back parallel checkpoint execution since we have MVCC now. (Undo the effect of #10546).
Benchmark result:
command: cargo run --release --bin sui-single-node-benchmark -- --tx-count 500000 --component checkpoint-executor --checkpoint-size 5 --num-input-objects 2 no-move
before TPS=16310.020876826722
after TPS=17611.214821598394
Test Plan
Existing tests.

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)

[ ] protocol change
[ ] user-visible impact
[ ] breaking change for a client SDKs
[ ] breaking change for FNs (FN binary must upgrade)
[ ] breaking change for validators or node operators (must upgrade binaries)
[ ] breaking change for on-chain data layout
[ ] necessitate either a data wipe or data migration

Release notes

I mainly rely on the existing tests for the coverage. But any suggestions for adding more tests are welcome!

Seems good, but a good test to exercise some edge cases might be something like
for f in `seq 1 20`; do RUST_LOG=sui=debug,error MSIM_TEST_SEED=9$f cargo simtest test_simulated_load_restarts test_simulated_load_with_reconfig --no-capture > /tmp/test_$f 2>&1 &; done

and check all the temp log files generated to ensure they all passed. The best test would be test_simulated_load_reconfig_restarts but last I heard that test is flaky (and disabled as a result). Perhaps you could also run that test against some seeds and see what happens? If it passes against this PR, we can re-enable, and if it doesn't, at least it might be worth looking at the failure case to make sure it doesn't surface something legitimate before merging.
Happy to stamp once test plan is updated

Thanks @williampsmith for the suggestion! Here are the test runs of the current code, which are all passed. Happy to run it again once we resolve the other comment.

Thanks! OOC did you try also enabling and running test_simulated_load_reconfig_restart to see if that succeeds now?

Sorry I missed that. I just re-enabled this test and ran it 20 times and they all passed. Let me see if I can reproduce the flakiness on main. If not, I can re-enable the test.

LGTM. Another thing that you could do to make it cleaner latter, as far as I understand, is if you make the checkpoint number an instrument field up top on execute_checkpoint, maybe you can actually get rid of including checkpoint sequence number in all the debug logs.

Let me look into how to do that, and will send it out separately.


Split the non-tabular node to generate one item per resource

Currently, we are copping across non-tabular resources, without any modification to dp.json. We need to change this behaviour as in some cases we have to reuse and add it as a new resource to the dp.json. add_resource processor searches the resource in dp.json with its name and as non-tabular ones are copied across, resource names are copied from originals. So we are getting AssertionError: Failed to find a resource with the index or name matching 'non-tabular' as a planner is trying to add resource using artefact name (add_resource, {resource: resource_info[required_artifact.resource_name]}...)
Acceptance Criteria

[ ] generate one item per resource for non-tabular ones as well

Tasks

[ ] refactor NonTabularProcessingNode in basic_nodes.py to yield artifact with correct resource names {resource name}_non_tabular

FIXED

Reopening as the commit was reverted due to bug in process of pipeline execution #43

FIXED in https://github.com/datahq/assembler/commit/8b97a84123dc80435ac1021a9de40d911fa6de63


images: Resize svg images

Signed-off-by: Ryan Northey<EMAIL_ADDRESS>Fix #186

Codecov Report

Merging #246 (119c36a) into main (71ca6ba) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #246   +/-   ##
=======================================
  Coverage   47.33%   47.33%
=======================================
  Files         103      103
  Lines        2926     2926
=======================================
  Hits         1385     1385
  Misses       1541     1541

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71ca6ba...119c36a. Read the comment docs.


Switch Player with OWI balance check

A switch player command that allows players to switch teams while also maintaining the balance of the OWI no more than 2-3 unbalanced recent rule.

Any particular reason for closing this? I was planning on reviewing it at some point this weekend.

I closed this because I polluted the PR with another change I merged into my master branch. I'll open another PR soon with just the switch code.