🐛 [BUG]: The error has being was passing the onNodesInitialized event or other event on the VueFlow component

Is there an existing issue for this?

[X] I have searched the existing issues and this is a new bug.

Current Behavior
An error occurred when I performed the test using vue-tsc, passing the onNodesInitialized event on the VueFlow component, indicating that I was not type-compatible
I found that the type definition of the event was missing from the exported vue component type DfineComponent type in @vue-flow/core/dist/container/VueFlow/VueFlow.vue.d.ts

Expected Behavior
No error should be triggered.
Steps To Reproduce
I didn't actually have any code to reproduce, just executed vue-tsc in a project that used VueFlow
Relevant log output
error TS2322: Type '{ ref: Ref<any>; nodes: { id: string; type: string; label: any; position: { x: number; y: number; }; data: { label: any; envntId?: any; type: string; meta: any[]; }; }[]; edges: any[]; "v-slots": { 'node-custom': (node: any) => Element; }; onNodesInitialized: () => { ...; }; }' is not assignable to type 'IntrinsicAttributes & Partial<{ connectionLineStyle: CSSProperties; connectionLineOptions: ConnectionLineOptions; isValidConnection: ValidConnectionFunc; ... 28 more ...; autoPanOnNodeDrag: boolean; }> & Omit<...>'.
  Property 'onNodesInitialized' does not exist on type 'IntrinsicAttributes & Partial<{ connectionLineStyle: CSSProperties; connectionLineOptions: ConnectionLineOptions; isValidConnection: ValidConnectionFunc; ... 28 more ...; autoPanOnNodeDrag: boolean; }> & Omit<...>'.

750             onNodesInitialized={() => {
                ~~~~~~~~~~~~~~~~~~

Anything else?
I cloned the source code to try to fix the problem, and I found the possibility problem:
I changed the definition of interface FlowEmits to:
export type FlowEmits = {
  nodesChange: [NodeChange[]]
  edgesChange: [EdgeChange[]]
  nodesInitialized: []
  miniMapNodeClick: [NodeMouseEvent]
  miniMapNodeDoubleClick: [NodeMouseEvent]
  miniMapNodeMouseEnter: [NodeMouseEvent]
  miniMapNodeMouseMove: [NodeMouseEvent]
  connect: [Connection]
  connectStart: [{ event?: MouseEvent } & OnConnectStartParams]
  connectEnd: [MouseEvent]
  clickConnectStart: [{ event?: MouseEvent } & OnConnectStartParams]
  clickConnectEnd: [MouseEvent]
  moveStart: [{ event: D3ZoomEvent<HTMLDivElement, any>; flowTransform: ViewportTransform }]
  move: [{ event: D3ZoomEvent<HTMLDivElement, any>; flowTransform: ViewportTransform }]
  moveEnd: [{ event: D3ZoomEvent<HTMLDivElement, any>; flowTransform: ViewportTransform }]
  selectionDragStart: [NodeDragEvent]
  selectionDrag: [NodeDragEvent]
  selectionDragStop: [NodeDragEvent]
  selectionContextMenu: [{ event: MouseEvent; nodes: GraphNode[] }]
  selectionStart: [MouseEvent]
  selectionEnd: [MouseEvent]
  viewportChangeStart: [ViewportTransform]
  viewportChange: [ViewportTransform]
  viewportChangeEnd: [ViewportTransform]
  /** @deprecated use `viewportChangeEnd` instead */
  paneReady: [VueFlowStore]
  init: [VueFlowStore]
  paneScroll: [WheelEvent | undefined]
  paneClick: [MouseEvent]
  paneContextMenu: [MouseEvent]
  paneMouseEnter: [MouseEvent]
  paneMouseMove: [MouseEvent]
  paneMouseLeave: [MouseEvent]
  updateNodeInternals: []
  error: [VueFlowError]

  // edgeContextMenu: [EdgeMouseEvent]
  // edgeMouseEnter: [EdgeMouseEvent]
  // edgeMouseMove: [EdgeMouseEvent]
  // edgeMouseLeave: [EdgeMouseEvent]
  // edgeDoubleClick: [EdgeMouseEvent]
  // edgeClick: [EdgeMouseEvent]
  // edgeUpdateStart: [EdgeMouseEvent]
  // edgeUpdate: [EdgeUpdateEvent]
  // edgeUpdateEnd: [EdgeMouseEvent]

  // nodeDoubleClick: [NodeMouseEvent]
  nodeClick: [NodeMouseEvent]
  nodeMouseEnter: [NodeMouseEvent]
  nodeMouseMove: [NodeMouseEvent]
  nodeMouseLeave: [NodeMouseEvent]
  nodeContextMenu: [NodeMouseEvent]
  nodeDragStart: [NodeDragEvent]
  nodeDrag: [NodeDragEvent]
  nodeDragStop: [NodeDragEvent]
  //
  /** v-model event definitions */
  'update:modelValue': [FlowElements]
  'update:nodes': [GraphNode[]]
  'update:edges': [GraphEdge[]]
}

Because there are so many properties defined in FlowEmits, there is still no definition for emits, but when I comment out about ten, it works fine

But this is still not enough, I have no other plan, I hope to get your help
thank you

I don't get what the problem here actually is?
A type error or what?

The onNodesInitialized event was passed while using the  component, but an error occurred during the vue-tsc check
<VueFlow
  onNodesInitialized={() => {
    layoutGraph('LR')
  }}
>
</VueFlow>

This is an exception message
error TS2322: Type '{ ref: Ref<any>; nodes: { id: string; type: string; label: any; position: { x: number; y: number; }; data: { label: any; envntId?: any; type: string; meta: any[]; }; }[]; edges: any[]; "v-slots": { 'node-custom': (node: any) => Element; }; onNodesInitialized: () => { ...; }; }' is not assignable to type 'IntrinsicAttributes & Partial<{ connectionLineStyle: CSSProperties; connectionLineOptions: ConnectionLineOptions; isValidConnection: ValidConnectionFunc; ... 28 more ...; autoPanOnNodeDrag: boolean; }> & Omit<...>'.
  Property 'onNodesInitialized' does not exist on type 'IntrinsicAttributes & Partial<{ connectionLineStyle: CSSProperties; connectionLineOptions: ConnectionLineOptions; isValidConnection: ValidConnectionFunc; ... 28 more ...; autoPanOnNodeDrag: boolean; }> & Omit<...>'.

750             onNodesInitialized={() => {
                ~~~~~~~~~~~~~~~~~~

I think the reason for the problem is that the  component's type definition file vueflow.vue.d.ts does not explicitly flag the onNodesInitialized event or other events
I have tried to fix this problem, but there is no good solution, so I need your help

Although you can use @ts-ignore to skip the check, I don't think that's a good idea

Can you provide a proper reproduction of this issue, please?
You can find a sandbox template here.

Ah I can see the problem myself now, thanks for reporting.
Will see what I can do about this issue since it's been recurring for some reason 🥲

Will be fixed in the next patch.

Thanks and I look forward to the next update

Should be fixed with 1.40.0


Main ways to avoid overfitting?

The rule of thumb is:

Diverse dataset. Less is more. If you have a lot of data, but there are anomalies, training will suffer.
Keep your learning rate consistent. The general numbers I see are 2e-6, 5e-6, 1e-5.
Increase the weight decay of the AdamW optimizer.
Use dropout if not doing LoRA training.


test: Remove old startup-script image dir

This is now part of image-tools repository:
https://github.com/cilium/image-tools/tree/master/images/startup-script

@aanm could you please de-activate Docker Hub build (https://hub.docker.com/repository/docker/cilium/startup-script/builds), and delete latest tag?

Coverage increased (+0.01%) to 36.96% when pulling 0e97358475a606f0574ae1109d06d78674b547b3 on pr/errordeveloper/delete-test-startup-script into 7856a775f5f731098b5b828adfb6da32913a51eb on master.


Move @Timed annotation to another method

Was playing around with the micrometer example and realized that adding @Timed to the controller method stomps the automatic instrumentation of the controller method that results in metrics named http.server.requests.
Moving the annotation to another method.

adding @Timed to the controller method stomps the automatic instrumentation of the controller method that results in metrics named http.server.requests.

this seems surprising to me for two reasons:

not sure why the annotation would affect the auto-instrumentation
the http.server.requests metric is captured at the SERVER span instrumentation (not at the controller method instrumentation)

can you double check the finding, or probably I'm missing something

@trask this is instrumentation provided automatically by spring + micrometer. Docs available here. "By default metrics are generated with the name http.server.requests".
I noticed that when you add the @Timed annotation to a method that spring automatically times, it replaces the auto generated metrics. Timing a different method illustrates how you can use micrometer annotations without stomping on the defaults.


How to increase the share memory size for a docker image

Cookbook version
v4.6.2
Chef-client version
12.5.1
Platform Details
Centos 6.5
Scenario:
I am using this cookbook to deploy the selenium test grid and it requires the shared memory of the image to be at a minimum of 2g (see https://github.com/SeleniumHQ/docker-selenium#running-the-images).
I wish to change the shared memory size of the image. Basically add "--shm-size=2g" to the docker run.
Steps to Reproduce:
None. It is a general question and not a bug.
Expected Result:
na
Actual Result:
na

@dinosavings Closing as it's fixed in #1060
Please let us know if there is anything.


how to support http-flv live stream use nginx-rtmp-module  and nginx?

In china,most company publish http-flv live stream use srs (https://github.com/ossrs/srs ), but performance of srs is a big problem. Here we want to have  http-flv live stream function to use nginx-rtmp-module, how to support http-flv live stream use nginx-rtmp-module  and nginx?

You can watch my open source project(https://github.com/gnolizuh/BLSS), it support HTTP FLV live streaming.

I implement this feature in my fork: https://github.com/dista/nginx-rtmp-module, you can take a try


DirectML Support

Hello!
Are there any plans for additional backends?
I'd love to see DirectML support to allow it to be used on nvidia/amd cards without requiring installing additional drivers (on Windows/Xbox, at least).
In a similar vein for Apple, CoreML.
Thanks again for your work on this project!

(Ignore me) Add ref to Apple Silicon with Core ML Stable Diffusion 👉 https://github.com/apple/ml-stable-diffusion


intermittent invalid credentials errors

(delete this for feature requests)
Client
PubSub
Describe Your Environment
e.g. Alpine Docker on GKE
Expected Behavior
e.g. Messages arrive really fast.
Actual Behavior
e.g. Messages arrive really slowly.

Whoops, accidently submitted early.


Make rooms unique wrt event

Describe the bug
Right now, we only use one set of rooms for all events. Each event needs its own list of rooms.
To Reproduce
https://www.devday.de/devday16/talk/
The column Rotterdam should not be there.

@jandd this has been fixed with your refactoring, right?

Yes it is fixed with #69


"AdMob is not defined"

#I found this plugin and it suited me perfectly, no extra nonsense and very good usability. I got it working and the test ads showed, however for some reason now I keep getting AdMob is not defined. It happens when I run the function showInterstitial(); which I created.
JavaScript
The Initialization
function onReady() {
    AdMob.setOptions({
	publisherId: 'my-id-here',
	interstitialAdId: 'my-id-here',
	bannerAtTop: false,
	overlap: true,
	offsetTopBar: false,
	isTesting: true,
	autoShow: false
    });

    AdMob.prepareInterstitial();
}

document.addEventListener('app.Ready', onReady, false);

The Function
function showInterstitial() {
    AdMob.prepareInterstitial({}, function () {
        AdMob.showInterstitial();
    });
}

I then tried,
function showInterstitial() {
    window.navigator.plugins.AdMob.prepareInterstitial({}, function () {
        window.navigator.plugins.AdMob.showInterstitial();
    });
}

I have tried reinstalling the plugin fresh, but it still didn't work.
Miscellaneous
Software: Intel XDK (3641)
Cordova Version: 6.2.0

I am not sure about Intel XDK, should the event be deviceready? Also why window.navigator.plugins.AdMob instead of AdMob?

I was using the deviceready event, the issue was that I hadn't included Cordova. Simple fix really,
<script src="cordova.js"></script>

and it was all working.


Implemented via .save-item and the existing item group


Resolution of Twitter photos

I notice that, for photos, the script is grabbing /media/blahblahblah.jpg, which maxes out at 1200x1200 or so. If it grabbed /media/blahblahblah.jpg?name=4096x4096 or /media/blahblahblah.jpg?name=orig, it'd get the full resolution image instead. Is it possible for the script to be modified to work that way?

Yeah, probably. Unfortunately, Twitter doesn't give any full-resolution URL in the JSON it returns, so it would need to be hard-coded to use name=orig, which may stop working at some point in the future. But I can modify the script for now

Should be fixed by latest commit (2fca34acd95dcff0b00678f2b827c0f7c9a510f7)

Ah, that works perfectly. Thank you so much!


Modern solid

This PR fixes #33 and fixes #32. It also updates the solid code wrapping the tsparticles library using modern solid development patterns.
Much of this was provided by bigmistqke while collaborating with me to fix the issues I found when using the current version.
Component:

use solid-lib-starter as base for the component library
refactored code:

fixed props to be reactive with mergeProps
removed redundant memo
instead of using async function inside a create-effect, use createResource to initialise particles-container.
use effect to pass container to config.particlesLoaded and cleanup container.
all the logic to create and dispose particles-container is inside an onMount, so we can be assured that the dom-elements have been rendered and mount + that the particles-code will never run on the server
removed the try{}catch{} wrapper, instead let's rely on solid's  instead.

App:

use solid-js getting started for the example application
use a signal to demonstrate responding to reactive change of the initial config setting

Summary by CodeRabbit

New Features

Introduced a new HTML entry point for the Solid App.
Added a configuration file for Vite to streamline the development process.
Implemented a new TypeScript declaration file for global environment variables.
Created unit tests for both client and server environments.
Enhanced package.json with a new type field for ES module compatibility.

Improvements

Simplified .gitignore to focus on essential files.
Enhanced README with clearer usage instructions and updated commands.
Updated TypeScript and ESLint configurations for better compatibility and stricter checks.
Streamlined the App component for improved performance and readability.
Restructured package.json for better usability and maintainability, including updated peerDependencies.

Bug Fixes

Improved error handling in the rendering logic to ensure robust application behavior.

Documentation

Restructured README for better clarity and usability.

Chores

Updated dependencies in package.json for better performance and compatibility.

@matteobruni I don't think the rules are visible anywhere so I can understand how to satisfy the MD043 - Required heading structure requirement. I made a number of attempted guesses without success.

@matteobruni I don't think the rules are visible anywhere so I can understand how to satisfy the MD043 - Required heading structure requirement. I made a number of attempted guesses without success.

Codacy is not mandatory, the Node.js GitHub Action is mandatory and must work

@matteobruni I don't think the rules are visible anywhere so I can understand how to satisfy the MD043 - Required heading structure requirement. I made a number of attempted guesses without success.

Codacy is not mandatory, the Node.js GitHub Action is mandatory and must work

Okay, I thought that might be the case. I think this should be all good then. I noticed a Node.js pr job that failed due to a merge conflict with the pnpm-lock file. It looks like the husky version in the root was old. No clue how that happened since I forked the main branch and didn't make any changes the root package.json. I didn't see any recent changes to the in the history of the main project, but I updated it to the latest (minor) version of husky anyway.

@matteobruni are you good with this as-is? I don't think I'm missing anything.

@matteobruni are you good with this as-is? I don't think I'm missing anything.

There’s a conflict

@matteobruni the last failure is related the Github action failing which is unrelated to any changes I've made. It looks like a network issue and might just need to be reran. Doesn't look like something I can do without creating a dummy commit to kick the process.

Ok it seems ok now, I updated the pnpm install action. I'll have a look cloning it during the weekend.

@matteobruni did get a chance to look at this one yet?

Sorry that it took so much, but I had busy days 😅

Sorry that it took so much, but I had busy days 😅

No worries. Should be updated now.


DEV-13: Add content for the Experience page

For the moment any additional logic is not required by the scope of this task, just the content as if it was completely uncovered by the user. The hiding will be implemented later with a different task.
To work on this issue, please use a branch DEV-13 created from devel. When the work is finished - create a PR to the devel branch. At the end of each development circles, code from the devel branch (if everything is ok) goes to the master branch and deploys to production.
IMPORTANT! Before creating a PR be sure that all the tests are passing and the coverage is 100%

The basic layout is implemented and looks like this:
Desktop:

Mobile:

I think in the future I will add a title and also I think the paddings of the container will be improved, but for the moment I think it is ready to create a PR to devel and continue with the content part.

The PR is merged and the result is tested on the PRE environment. The issue can be closed.


Suggestion: show full code in brackets on plus.codes

Hi, sharing an issue with plus codes that say a postal service or a database operating at the level of a country like India would experience:

I have one location in Pune city, which is in Maharashtra state of India: https://i.imgur.com/1xlxexM.png
I copy the plus-code given at the bottom. It is a shortened version, but an unfamiliar person wouldn't know.
I open maps.google.com and am looking at all of India. I type in the plus code : GRW4+7J . It takes me to another address in another state.
I search for  "GRW4+7J, maharashtra". It still takes me to another address in the state.
I include two more letters from the left of the full plus code (note, at this point the lay person will have abandoned the search): CMGRW4+7J
I go back to all-India map, and search for it. It takes me to the ocean, somewhere near Myanmar.
It's only when I type the full code, 7JCMGRW4+7J that I get the correct location.

Can we make arrangements so the default display on plus.codes (that shows at the bottom of the page) shows the full code in small size in brackets to the right or something, or in a ?-tooltip advising the user to use the full code in case of searching over a large area like state or country? It's there when you click further, but it's not very intuitive to open that and doesn't always open.
Also, a copy-to-clipboard button would be great!

Hi @answerquest
The idea is to use a regional landmark or other useful location information in combination with short codes. For example, if I search on Google Maps for "GRW4+7J Pashan", the result is the correct location.
I agree that this could be made more obvious on plus.codes, but I guess that this web page is still meant for those already being aware of how OLC works. A button to copy to clipboard would be great, yes.

Hi - think of the plus code as similar to a street name and number. You wouldn't expect to tell someone in another state that your entire address was "11 X Road" - but you'd include the town as well. Similarly, telling me the address is "GRW4+7J, maharashtra" isn't super helpful, that's why it displays the locality "Pashan, Pune".
I don't think showing the full code is the solution - we want to make these easier to use, so we show a short version of the code with the town or locality name.
If you have any suggestion how to make it more obvious that they go together, let me know!
(I'll look into a copy to clipboard button.)

@drinckes This is probably more an issue with the Maps API than with OLC - but is there any way to somehow "normalize" the location that is displayed as a reference?
Clicking around the map, I often (for locations in Germany) get the short code followed by a city name and "Germany", which is what I'd expect to be most useful in most cases. Example: PJWW+8M Trier, Germany
Sometimes, though, I also get something that includes a zip code either as a prefix (3Q45+JV 99958 Tonna, Germany) or somewhere in the location string (HP29+2Q Lauter, 08315 Lauter-Bernsbach, Germany). At other times, I get a string that includes a mostly useless district name (like "Mitte" in 2G7R+FP Mitte, Bielefeld, Germany).
If there was a way to select shortest globally unique reference_ (which might be CITY, COUNTRY in most cases) and/or shortest reference unique within country (which would probably by CITY), this could help in formatting the resulting short code plus reference location in a way that makes it more obvious that they can and should be copied together.


[Enhancement] BlockingAsyncCommand

Summary
I think we all have a problem when a user clicks 5 times on a button and we run 5 commands in parallel. And we need each command to be executed one by one
API Changes
Add a new class BlockingAsyncCommand,
which will ensure that only one command of the same type is executed at a time
Intended Use Case
You have a Login command, and a user who is wildly clicking buttons.
you don't want to write weird code that will check if your command is currently running. you just want to use BlockingAsyncCommand.
Who Will Do The Work?

[x] I am willing to take this on myself
[ ] Just putting this out there for someone to pick up

If you use the AsyncCommand you can pass an allowsMultipleExecutions in the Constructor to prevent multiple clickss:
https://github.com/xamarin/XamarinCommunityToolkit/blob/1cc1f128895a52aef0d5a912ce139415aed90714/src/CommunityToolkit/Xamarin.CommunityToolkit/ObjectModel/Internals/BaseCommand.shared.cs#L48


End to end test is sometimes failing

For example this one.
It runs for an hour and then timeouts.
The line where it gets stuck is this.
From the action output:
github.com/mantil-io/mantil/test.testAddLogsApi(0xc0000b8420)
119
	/home/runner/work/mantil/mantil/mantil/test/ping_test.go:53 +0x2b6

it runs "mantil", "invoke", "logs/test", "-d", {"name": "Foo"} which newer finishes.

Another example:
https://github.com/mantil-io/mantil/runs/5409744673?check_suite_focus=true


tracing: Provide default configuration when no host specified for k8s…

… ingress - and direct to tracing service
Updates the main tracing k8s ingress definition to be similar to the one recently updated in the ingress-jaeger.yaml definition - which can work without a host being specified.
The ingress is used to provide access to the UI - but in this case was being directed to the zipkin collector service/port. So also updated the service/port to tracing:80.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: objectiser
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: andraxylia
If they are not already assigned, you can assign the PR to them by writing /assign @andraxylia in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@objectiser: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@objectiser: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test istio-unit-tests

prow/e2e-simpleTests-cni.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@objectiser: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test istio-unit-tests

prow/e2e-simpleTests-cni.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@objectiser: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test istio-unit-tests

prow/e2e-simpleTests-cni.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-mixer-no_auth
/test istio-unit-tests

@objectiser: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test istio-pilot-multicluster-e2e

prow/e2e-mixer-no_auth.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test e2e-mixer-no_auth

prow/istio-unit-tests.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

@objectiser: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests

/test e2e-simpleTests-cni

@objectiser: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test e2e-simpleTests-cni

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@objectiser: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test istio-pilot-multicluster-e2e

prow/e2e-simpleTests-cni.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@objectiser: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-simpleTests-cni.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test e2e-simpleTests-cni

prow/istio-integ-k8s-tests.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
3501ee1039a883a0d9b7b93f46f73d7816f402b8
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/assign @sdake

what should be done with this PR now?

@douglas-reid  It's still relevant, even if we move to using the jaeger-operator.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: douglas-reid, objectiser
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sdake
If they are not already assigned, you can assign the PR to them by writing /assign @sdake in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

install/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdake friendly ping :).


Some german corrections

hey there,
I changed several german translations and made a commit for each of them so you might revert each of them if you do not like the proposed translation.
I also adressed some translations which might be affected by issue #40 in the bugtracker

I've changed all of the affected translation terms towards gender star now.


RN 0.60 Cannot Build: React/RCTBridge.h file not found

I followed the instructions to link the native modules for iOS, but it failed to compile RCTCustomInputController.m. I recently upgraded to Xcode 11. I am not sure if this issue is related to the upgrade.

@jeffreyyu0602 any luck cause I'm facing with the same issue?

Try to simply install this library and run pod install. Without the other installation steps.

as @AdamGold said, simply add the library. In my case i also needed to add https://github.com/wix/react-native-keyboard-tracking-view, then pod install and app was working fine.


Better error messages for sad paths

https://github.com/aspect-build/rules_js/pull/89/files#r867406427

when I forget to link packages
ERROR: /home/alexeagle/.cache/bazel/_bazel_alexeagle/1112fa9a04c6878cb3f2bf123baf106a/external/npm/@types/node/BUILD.bazel:33:6: no such target '//:direct_link__at_types_node': target 'direct_link__at_types_node' not declared in package '' defined by /home/alexeagle/Projects/bazel-examples/next.js/BUILD.bazel and referenced by '@npm//@types/node:node'

This is very old, will let ppl file new issues for specific bad error messages.


Event not getting triggered

Seems like HandlesSns trait -> getSnsMessage functions is not working

Do you still have problems with it?


Column breakpoints don't work with TypeScript sourcemaps

VSCode Version: 1.11.2
OS Version: macOS

Steps to Reproduce:

Write code like

[1, 2, 3].map(x => x * 2).filter(x => x > 3)

Try to set a column breakpoint in the arrow function

I don't know whether this is a problem with TS sourcemaps or the debugger, but it is very unfortunate

@felixfbecker legacy or inspector protocol?

Inspector

I'm able to set column breakpoints for legacy protocol.

This isn't implemented in 1.11.2, it's coming in 1.12. However it will only work properly for Node 8+.

It is true that the breakpoint can be set in legacy mode, but the breakpoint is still set incorrectly:
function double(x) {
  return x * 2
}

[1, 2, 3].map(x => double(x))

in this example, I would expect it to break before the double call, so that a step-in would step into the double call. Instead, it appears to break after double was already called, a step-in does nothing

I can confirm that column breakpoints, while they do get "hit", somehow align with the wrong code, and so you don't break on the code you expect.
There seems to be some kind of "off by one" type of problem.
Node version 8.1.0.

@mattflix Can you open a new issue? Node 8.1 will be using the inspector protocol. I'd like to see a code sample where it doesn't work as expected.

If I'm reading Felix's last comment correctly, I think this issue was for the legacy protocol. That case works for Node 8.9 now. The right answer is probably, use Node 8+.


Refactor L1 connection management

Makes the code easier to reason about.

Closing as this is now a duplicate.


Weird error when running dart test

Working against this null safe migrated code:
https://github.com/timsneath/win32/tree/eb810f9e196282ef198beab3d2245300bae8f18a
[C:\src\win32] dart test
The `pub` command is deprecated. Run `dart pub` instead.
Dart 2.12.0-27.0.dev is incompatible with your dependencies' SDK constraints. Please run "pub get" again.

[C:\src\win32] dart --version
Dart SDK version: 2.12.0-27.0.dev (dev) (Fri Nov 6 06:09:09 2020 -0800) on "windows_x64"

This is a weird message (why the warning message about deprecation)? /cc @mit-mit

Duplicate of https://github.com/dart-lang/sdk/issues/44105


lein-ancient 0.6.8-SNAPSHOT doesn't play well with lein do, AKA find dependencies and plugins at the same time

This is great:
lein ancient

And this is too:
lein ancient :plugins

But what I'd really like is 1 command that will find out of date dependencies and plugins. It's unfortunate that you can't do both with 1 command (as far as I can tell), and maybe you should be able to. So that's one issue.
A separate but somewhat related issue, is that it seems our possible work around, lein do, doesn't work with lein-ancient 0.6.8-SNAPSHOT.
This works as expected, both these tasks run:
lein do version, ancient
Leiningen 2.5.3 on Java 1.8.0_60 Java HotSpot(TM) 64-Bit Server VM
WARNING: update already refers to: #'clojure.core/update in namespace: clj-http.client, being replaced by: #'clj-http.client/update
[midje "1.7.0"] is available but we use "1.6.0"
[ring-mock "0.1.5"] is available but we use "0.1.3"

And on lein-ancient 0.6.7, this works fine too:
lein do ancient, version
WARNING: update already refers to: #'clojure.core/update in namespace: clj-http.client, being replaced by: #'clj-http.client/update
[midje "1.7.0"] is available but we use "1.6.0"
[ring-mock "0.1.5"] is available but we use "0.1.3"
Leiningen 2.5.3 on Java 1.8.0_60 Java HotSpot(TM) 64-Bit Server VM

But on 0.6.8-SNAPSHOT, the 2nd task, version, never runs:
lein do ancient, version
WARNING: update already refers to: #'clojure.core/update in namespace: clj-http.client, being replaced by: #'clj-http.client/update
[aprint "0.1.3"] is available but we use "0.1.0"
[midje "1.7.0"] is available but we use "1.6.0"
[ring-mock "0.1.5"] is available but we use "0.1.3"

The downside of this regression, in particular, is it makes this work around on 0.6.7:
lein do ancient, ancient :plugins
WARNING: update already refers to: #'clojure.core/update in namespace: clj-http.client, being replaced by: #'clj-http.client/update
[midje "1.7.0"] is available but we use "1.6.0"
[ring-mock "0.1.5"] is available but we use "0.1.3"
[lein-ring "0.9.6"] is available but we use "0.9.5"
[lein-cljsbuild "1.1.0"] is available but we use "1.0.0"

No longer work on 0.6.8:
lein do ancient, ancient :plugins
WARNING: update already refers to: #'clojure.core/update in namespace: clj-http.client, being replaced by: #'clj-http.client/update
[aprint "0.1.3"] is available but we use "0.1.0"
[midje "1.7.0"] is available but we use "1.6.0"
[ring-mock "0.1.5"] is available but we use "0.1.3"

FWIW, if I put it in an alias, it seems to work OK.
Such as:
:aliases {
    "ancient!" ["do" "ancient" ":allow-qualified," "version"]
}

So... that seems odd.

or

```clojure
:aliases {
    "ancient!" ["do" "ancient" ":allow-qualified," "ancient" ":plugins" ":allow-qualified"]
}

Regarding checks on all the things (see lein help ancient check & co.):
lein ancient :all

Regarding the problems with lein do, I thinks this is a side-effect of #55 - lein-ancient produces a non-zero error code when it finds outdated stuff, probably prompting lein do to abort. (I feel that might actually be useful behaviour, since it allows calls that only run if dependencies are up-to-date. Probably a matter of taste.)

Y... I can see why you might want the non-zero error code. That makes sense.
Thanks for :all. Didn't notice that was an option.


After install I can't run the expdp tool

I get error
dyld: Library not loaded: @rpath/libclntsh.dylib.19.1
Referenced from: /usr/local/bin/expdp
Reason: image not found
[1]    61611 abort      expdp

Works for me.
Which version of MacOS are you on? If Catalina or higher then you might need to set DYLD_LIBRARY_PATH=$HOMEBREW_PREFIX/lib. Let me know if that helps.

Hi, running Catalina, got it working but it is a misterius, my  HOMEBREW_PREFIX was empty, and this is in 2 different macs, I put it in usr/local and then set the DYLD_LIBRARY_PATH. Thanks.
➜  ~ export HOMEBREW_PREFIX="/usr/local"
➜  ~ $HOMEBREW_BREW_FILE
➜  ~ export DYLD_LIBRARY_PATH=$HOMEBREW_PREFIX/lib
➜  ~ echo $DYLD_LIBRARY_PATH
/usr/local/lib
➜  ~ expdp
Export: Release <IP_ADDRESS>.0 - Production on Fri Feb 19 09:57:38 2021
Version <IP_ADDRESS>.0

I do not think you're the only one to hit this problem on Catalina+.

Could you please try the branch tools-on-catalina? If it works I will merge it into master.
Sorry about the HOMEBREW_PREFIX, it's a placeholder, not supposed to be set normally.

Hi, how do you usually install a brew formula from a branch. Been trying unsuccessfully brew tap-new..

Don't know what the official way is. If you have hub then try this:
cd /usr/local/Homebrew/Library/Taps/instantclienttap/homebrew-instantclient # or wherever your brew is
hub checkout https://github.com/InstantClientTap/homebrew-instantclient/pull/39
brew install instantclient-tools
# test test test
brew uninstall instantclient-tools
git checkout master # back to normal

Ok, I can confirm this works.

Closed by https://github.com/InstantClientTap/homebrew-instantclient/pull/39.


Integration with AWS Firewall Manager

Please up-vote if you want this feature. Do not submit a new feature request.

Closing this since this feature is not in the immediate roadmap for the solution. Please comment to re-open this thread.


add HeadObject/ListObjects/ListObjectsV2 context for S3OL, set sessio…

S3 object lambda add new event for HeadObject ListObjects and ListObjectsV2, need to add support for these new events,

according to public doc, sessionContext only comes up when "If the request was made with temporary security credentials, this element provides information about the session that was created for those credentials"
below blog also confirmed this. so session_context will be reasonable set to Option or event parse will fail.

Ref:
https://docs.aws.amazon.com/AmazonS3/latest/userguide/olap-event-context.html
https://aws.amazon.com/blogs/aws/introducing-amazon-s3-object-lambda-use-your-code-to-process-data-as-it-is-being-retrieved-from-s3/

payload and test added

@daiyy thanks for adding these changes! can you include a test with them with a valid payload?

payload and test code added


npm Permission denied error on Chrome OS

I'm not sure what the deal is, but I keep getting a Permission denied error when trying to use nvm on Chrome OS.

Operating system and version: Chrome OS 62

nvm debug output:

chronos@localhost ~ $ whoami
chronos
chronos@localhost ~ $ nvm debug
nvm --version: v0.33.6
$SHELL: /bin/bash
$HOME: /home/chronos/user
$NVM_DIR: '$HOME/.nvm'
$PREFIX: ''
$NPM_CONFIG_PREFIX: ''
$NVM_NODEJS_ORG_MIRROR: ''
$NVM_IOJS_ORG_MIRROR: ''
shell version: 'GNU bash, version 4.3.42(1)-release (x86_64-cros-linux-gnu)'
uname -a: 'Linux 4.4.79-11654-g7e0f59a105a1 #1 SMP PREEMPT Mon Nov 13 16:37:19 PST 2017 x86_64 Intel(R) Core(TM) i5-7Y57 CPU @ 1.20GHz GenuineIntel GNU/Linux'
OS version: Developer Console
curl: /usr/bin/curl, curl 7.55.1 (x86_64-cros-linux-gnu) libcurl/7.55.1 OpenSSL/1.0.2k zlib/1.2.11
wget: /usr/bin/wget, GNU Wget 1.19.1 built on linux-gnu.
git: /usr/local/bin/git, git version 2.14.1
grep: /bin/grep (grep --colour=auto), grep (GNU grep) 2.21
awk: not an option: --version
awk: /usr/bin/awk,
sed: /bin/sed, sed (GNU sed) 4.2.2
cut: /usr/bin/cut, cut (GNU coreutils) 8.25
basename: /usr/bin/basename, basename (GNU coreutils) 8.25
rm: /bin/rm, rm (GNU coreutils) 8.25
mkdir: /bin/mkdir, mkdir (GNU coreutils) 8.25
xargs: /usr/bin/xargs, xargs (GNU findutils) 4.4.2
nvm current:
which node: $NVM_DIR/versions/node/v8.9.1/bin/node
which iojs: which: no iojs in ($NVM_DIR/versions/node/v8.9.1/bin:/usr/local/bin:/usr/bin:/bin:/opt/bin)
which npm: $NVM_DIR/versions/node/v8.9.1/bin/npm
npm config get prefix: bash: $NVM_DIR/versions/node/v8.9.1/bin/npm: Permission denied
npm root -g: bash: $NVM_DIR/versions/node/v8.9.1/bin/npm: Permission denied

nvm ls output:

chronos@localhost ~ $ nvm ls
         v8.9.1
default -> 8 (-> v8.9.1)
node -> stable (-> v8.9.1) (default)
stable -> 8.9 (-> v8.9.1) (default)
iojs -> N/A (default)
lts/* -> lts/carbon (-> v8.9.1)
lts/argon -> v4.8.6 (-> N/A)
lts/boron -> v6.12.0 (-> N/A)
lts/carbon -> v8.9.1

How did you install nvm? (e.g. install script in readme, homebrew): nvm README install script

What steps did you perform?

chronos@localhost ~ $ nvm use 8
bash: /home/chronos/user/.nvm/versions/node/v8.9.1/bin/npm: Permission denied
nvm is not compatible with the npm config "prefix" option: currently set to ""
Run `nvm use --delete-prefix v8.9.1` to unset it.
chronos@localhost ~ $ nvm use --delete-prefix 8
bash: /home/chronos/user/.nvm/versions/node/v8.9.1/bin/npm: Permission denied
bash: /home/chronos/user/.nvm/versions/node/v8.9.1/bin/npm: Permission denied

What happened?

I got a Permission denied error.

What did you expect to happen?

No error.

Is there anything in any of your profile files (.bashrc, .bash_profile, .zshrc, etc) that modifies the PATH?

No.

If you are having installation issues, or getting "N/A", what does curl -I --compressed -v https://nodejs.org/dist/ print out?

chronos@localhost ~ $ curl -I --compressed -v https://nodejs.org/dist/
*   Trying <IP_ADDRESS>...
* TCP_NODELAY set
* Connected to nodejs.org (<IP_ADDRESS>) port 443 (#0)
* ALPN, offering http/1.1
* Cipher selection: ALL:!EXPORT:!EXPORT40:!EXPORT56:!aNULL:!LOW:!RC4:@STRENGTH
* successfully set certificate verify locations:
*   CAfile: /etc/ssl/certs/ca-certificates.crt
  CApath: /etc/ssl/certs
* TLSv1.2 (OUT), TLS header, Certificate Status (22):
* TLSv1.2 (OUT), TLS handshake, Client hello (1):
* TLSv1.2 (IN), TLS handshake, Server hello (2):
* TLSv1.2 (IN), TLS handshake, Certificate (11):
* TLSv1.2 (IN), TLS handshake, Server key exchange (12):
* TLSv1.2 (IN), TLS handshake, Server finished (14):
* TLSv1.2 (OUT), TLS handshake, Client key exchange (16):
* TLSv1.2 (OUT), TLS change cipher, Client hello (1):
* TLSv1.2 (OUT), TLS handshake, Finished (20):
* TLSv1.2 (IN), TLS change cipher, Client hello (1):
* TLSv1.2 (IN), TLS handshake, Finished (20):
* SSL connection using TLSv1.2 / ECDHE-RSA-AES128-GCM-SHA256
* ALPN, server accepted to use http/1.1
* Server certificate:
*  subject: OU=Domain Control Validated; OU=PositiveSSL Wildcard; CN=*.nodejs.org
*  start date: Aug 14 00:00:00 2017 GMT
*  expire date: Nov 20 23:59:59 2019 GMT
*  subjectAltName: host "nodejs.org" matched cert's "nodejs.org"
*  issuer: C=GB; ST=Greater Manchester; L=Salford; O=COMODO CA Limited; CN=COMODO RSA Domain Validation Secure Server CA
*  SSL certificate verify ok.
> HEAD /dist/ HTTP/1.1
> Host: nodejs.org
> User-Agent: curl/7.55.1
> Accept: */*
> Accept-Encoding: deflate, gzip
>
< HTTP/1.1 200 OK
HTTP/1.1 200 OK
< Date: Mon, 27 Nov 2017 01:35:36 GMT
Date: Mon, 27 Nov 2017 01:35:36 GMT
< Content-Type: text/html
Content-Type: text/html
< Connection: keep-alive
Connection: keep-alive
< Set-Cookie: __cfduid=dcb9686cb6c5014486b1940867273d47f1511746536; expires=Tue, 27-Nov-18 01:35:36 GMT; path=/; domain=.nodejs.org; HttpOnly
Set-Cookie: __cfduid=dcb9686cb6c5014486b1940867273d47f1511746536; expires=Tue, 27-Nov-18 01:35:36 GMT; path=/; domain=.nodejs.org; HttpOnly
< CF-Cache-Status: HIT
CF-Cache-Status: HIT
< Vary: Accept-Encoding
Vary: Accept-Encoding
< Expires: Mon, 27 Nov 2017 05:35:36 GMT
Expires: Mon, 27 Nov 2017 05:35:36 GMT
< Cache-Control: public, max-age=14400
Cache-Control: public, max-age=14400
< Server: cloudflare-nginx
Server: cloudflare-nginx
< CF-RAY: 3c415a0b7c919829-LAX
CF-RAY: 3c415a0b7c919829-LAX
< Content-Encoding: gzip
Content-Encoding: gzip

<
* Connection #0 to host nodejs.org left intact

Hmm, it looks like $HOME doesn't have exec by default in Chrome OS. I found a solution that works for me in a crouton issue:
sudo mount -i -o remount,exec /home/chronos/user

I just put that in my ~/.bashrc and now $HOME has the correct permissions.

Thanks, I'd have had no idea how to debug that :-)

There is another way to do this that is way worse but i cant remember it, just remember i had to do alot of chowns. Thank you so much this is so clean.


Default image for all episodes too repetitive

Using high-five hand for all episodes is too visually-repetitive.

Version of Ghost blog platform currently running http://gtradio.net/alyt supports post images.
These can be the canonical source for episode images.
App can be changed to use Ghost post images instead of feed images (this will save time on feed maintenance since I'm still updating it by hand).

Never mind, can't use post images from Ghost.
They are a nice feature (they show up instead of the blog banner image on the post's page...if theme supports it, and our older theme does not).
Anyway, post images do not show up in RSS feed generated by Ghost and currently no external API available to access them.
Will have to add episode images directly to feed.

Added google plus image link to test feed for e51, nothing broke.
Image did not show up in PocketCasts or AntennaPod on android (which is ok).
Added same image link (taken from show notes page) to e51 in main feed.
Asked Matt to compile image links for other episodes.


Could not pass event EntityDeathEvent to Quests v3.3.7-b482

(Required) What is your Quests version / build number (do not say "latest")?
Quests-3.3.7
(Required) Please describe the problem and how to replicate it. Any console errors?
Could not pass event EntityDeathEvent to Quests v3.3.7-b482
Console errors included in the pastebin log
(Optional) Can you provide an example quest from quests.yml using Pastebin.com?
https://pastebin.com/U6EbVssj

The following build should fix the issue once available. If not, please post back with the new error via Pastebin.
http://ci.ac3-servers.eu/job/Quests/483/


client.batch.create_objects to throw warning and return when batch ma…

What's changed:

This PR fixes #578

@tsmith023 please review. thanks!

I agree with the CLA

Hi @lalit-k, it looks like your change unintentionally causes one of the integration tests to fail. Could you inspect the breaking issue in the CI and investigate how to remedy it? Cheers 😁

@tsmith023 I updated the create_objects()/create_refrences() to throw warning and return after it. Tests failing now due  to that return statement.
if self._batch_size is not None and self.dynamic:
            _Warnings.manual_batching_when_dynamic_enabled()
            return []

Just want to confirm if above change is ok? Then i can go forward and fix/update the tests otherwise remove "return".
thank you!

Hi @lalit-k, the test that is breaking does not have an explicit dependence on the code you've changed (the dependence is implicit). As such, your change has unintended side-effects that cause downstream issues. I think you will need to refactor more of the code to handle this warning appropriately as the return [] is causing problems 😁

thanks @tsmith023 I have fixed the failing test, updated to use batch context-manager with manual batching during objects creation and dynamic during reference creation to cover both use cases. Please have a look.


compile tensorflow fails with error: SWIGing tensorflow/python/tensorflow.i ... swig failed: error executing command

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow): No
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): CentOS 6
TensorFlow installed from (source or binary): source
TensorFlow version (use command below):1.14, 1.15, 2.1, 2.2, 2.3
Bazel version (if compiling from source): 2.0.0

Describe the current behavior
Running the build fails with a rather undescriptive:
ERROR: /home/username/src/tensorflow/tensorflow/python/BUILD:2974:1: SWIGing tensorflow/python/tensorflow.i failed (Exit 1): swig failed: error executing command
  (cd /tmp/_bazel_username/dcca333cc36b578f4473c754fbbc85ff/execroot/org_tensorflow && \
  exec env - \
  bazel-out/host/bin/external/swig/swig -c++ -python -module pywrap_tensorflow_internal -o bazel-out/local-py3-opt/bin/tensorflow/python/pywrap_tensorflow_internal.cc -outdir bazel-out/local-py3-opt/bin/tensorflow/python -ltensorflow/python/client/device_lib.i -ltensorflow/python/client/events_writer.i -ltensorflow/python/client/tf_session.i -ltensorflow/python/client/tf_sessionrun_wrapper.i -ltensorflow/python/framework/cpp_shape_inference.i -ltensorflow/python/framework/python_op_gen.i -ltensorflow/python/grappler/cluster.i -ltensorflow/python/grappler/cost_analyzer.i -ltensorflow/python/grappler/item.i -ltensorflow/python/grappler/model_analyzer.i -ltensorflow/python/grappler/tf_optimizer.i -ltensorflow/python/lib/core/py_func.i -ltensorflow/python/lib/core/strings.i -ltensorflow/python/lib/io/file_io.i -ltensorflow/python/lib/io/py_record_reader.i -ltensorflow/python/lib/io/py_record_writer.i -ltensorflow/python/platform/base.i -ltensorflow/python/pywrap_tfe.i -ltensorflow/python/training/quantize_training.i -ltensorflow/python/training/server_lib.i -ltensorflow/python/util/kernel_registry.i -ltensorflow/python/util/port.i -ltensorflow/python/util/py_checkpoint_reader.i -ltensorflow/python/util/stat_summarizer.i -ltensorflow/python/util/tfprof.i -ltensorflow/python/util/transform_graph.i -ltensorflow/python/util/util.i -Ibazel-out/local-py3-opt/genfiles -Iexternal/eigen_archive -Iexternal/grpc -Iexternal/protobuf_archive -Iexternal/swig -Iexternal/boringssl -Ibazel-out/local-py3-opt/genfiles/external/local_config_python -Iexternal/nsync -Iexternal/gemmlowp -Iexternal/jpeg -Iexternal/com_googlesource_code_re2 -Iexternal/jsoncpp_git -Iexternal/zlib_archive -Iexternal/highwayhash -Iexternal/gif_archive -Ibazel-out/local-py3-opt/genfiles/external/jpeg -Iexternal/lmdb -Iexternal/png_archive -Iexternal/farmhash_archive -Iexternal/local_config_cuda -Iexternal/sqlite_archive -Iexternal/swig/Lib -Iexternal/swig/Lib/cffi -Iexternal/swig/Lib/python -Iexternal/swig/Lib/std -Iexternal/swig/Lib/typemaps tensorflow/python/tensorflow.i).
Target //tensorflow/tools/pip_package:build_pip_package failed to build

This is as reported in #14211, looked like an issue in Bazel (https://github.com/bazelbuild/bazel/issues/4053) but was deemed a Bug in TensorFlow, hence requesting a fix here
Describe the expected behavior
Build succeeds without need to apply patch from https://github.com/bazelbuild/bazel/issues/4053#issuecomment-343134886

SWIG no longer used. Closing


[EN] Hard code deep learning exclusions from tests

see
https://github.com/aeon-toolkit/aeon/issues/271
https://github.com/aeon-toolkit/aeon/issues/347
The deep learning algorithms are fundamentally not deterministic. They also cannot be pickled. There are three relevant tests in test_all_estimators
"test_fit_idempotent",
"test_persistence_via_pickle"
"test_save_estimators_to_file",
firstly, I have refactored the poorly named test_fit_idempotent to test_fit_deterministic. I have then escaped tests if the estimator is a DeepClassifier or DeepRegressor. Turns out this is done all over the testing. Currently, InceptionTime is still excluded because technically it is an ensemble of deep learners, not a deep learner itself.

It would be good to give people a bit more time to view these.

Does the new test name fit? They will only be deterministic if you set random_state
Instead of skipping individual base classes and having to maintain it, We could have a BaseDeepEstimator at some point?
The skip on test_save_estimators_to_file seems to be above the comment instead of grouped with other skips


Bug with django-debug-toolbar >= 4.4.6

It appears there's a bug with the django-debug-toolbar / strawberry-django integration with DDT version 4.4.6+
We had a ticket opened on our repo about a private member being included and now erroring. I wanted to make sure it was visible to you.

Describe the Bug
I have not reproduced this, but looking at the code it looks like having the toolbar enabled and using the strawberry-django's debug_toolbar middleware should trigger this.

System Information

Operating system: Unknown
Strawberry version (if applicable): Unknown
Django Debug Toolbar Version: 4.4.6

Additional Context
File "/home/nonroot/.local/lib/python3.11/site-packages/strawberry_django/middlewares/debug_toolbar.py", line 11, in <module>
    from debug_toolbar.middleware import _HTML_TYPES, get_show_toolbar  # noqa: PLC2701
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ImportError: cannot import name '_HTML_TYPES' from 'debug_toolbar.middleware' (/home/nonroot/.local/lib/python3.11/site-packages/debug_toolbar/middleware.py)
Process SpawnProcess-1:
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/multiprocessing/process.py", line 314, in _bootstrap
    self.run()
  File "/usr/local/lib/python3.11/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/home/nonroot/.local/lib/python3.11/site-packages/uvicorn/_subprocess.py", line 80, in subprocess_started
    target(sockets=sockets)
  File "/home/nonroot/.local/lib/python3.11/site-packages/uvicorn/server.py", line 65, in run
    return asyncio.run(self.serve(sockets=sockets))
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/asyncio/runners.py", line 190, in run
    return runner.run(main)
           ^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/asyncio/runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "uvloop/loop.pyx", line 1517, in uvloop.loop.Loop.run_until_complete
  File "/home/nonroot/.local/lib/python3.11/site-packages/uvicorn/server.py", line 69, in serve
    await self._serve(sockets)
  File "/home/nonroot/.local/lib/python3.11/site-packages/uvicorn/server.py", line 76, in _serve
    config.load()
  File "/home/nonroot/.local/lib/python3.11/site-packages/uvicorn/config.py", line 434, in load
    self.loaded_app = import_from_string(self.app)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/nonroot/.local/lib/python3.11/site-packages/uvicorn/importer.py", line 19, in import_from_string
    module = importlib.import_module(module_str)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1204, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1176, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1147, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 690, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 940, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/usr/src/config/asgi.py", line 19, in <module>
    application_django = get_asgi_application()

Upvote & Fund

We're using Polar.sh so you can upvote and help fund this issue.
We receive the funding once the issue is completed & confirmed by you.
Thank you in advance for helping prioritize & fund our backlog.

Ack, I missed it in #586


Copy zyte_api_session-prefixed meta into session initialization requests

@VMRuiz reported that, to implement a check method that takes into account meta-defined locations, the init request also needs to have that meta key set. I went a bit further and made it so that any zyte_api_session_-prefixed meta key is copied into the init request, for extra flexibility.
To do:

[ ] Docs about the meta key copy.
[ ] Docs about the need, in these scenarios, to create separate pools per location. Or maybe we should provide a default implementation that does so? Maybe even the ability to set a custom pool through meta?

I’ll keep this PR simple and easy to merge, just copy the 2 known meta keys, and open a separate PR with additional ideas brought up with working on this.


Bug: slow close when using custom function

I use a function isCopilotActive in different parts of vim, specifically a binding which triggers it for me.
Now I wanted to get feedback in lualine and wrote a small function for it.
When adding it to a section the startup time of nvim slows down by half a second and the shutdown time around 1 second. this is enormous compared to subjectively "instant" startup and shutdown without it. I am not sure why this is happening.

function copilotIsActive()
  local output = vim.api.nvim_command_output("Copilot status")
  if string.find(output, "^Copilot: Enabled and online") then
    return true
  else
    return false
  end
end

function lualine_copilot()
  if copilotIsActive() then
    return "🤖"
  else
    return ""
  end
end

-- lua config
    lualine_c = {'filename', lualine_copilot },

Expected behaviour
no noticeable impact on performance
Actual behaviour
very noticeable impact on performance

lualine components are called a lot u probably only want to check if copilot is active when a new buffer is added
local copilit_active = {}
local autocmd = vim.api.nvim_create_autocmd
autocmd({ "BufNew" }, {
   pattern = { "*" },
   callback = function(ev)
      vim.api.nvim_buf_call(ev.buf, function()
         local output = vim.api.nvim_command_output("Copilot status")
         if string.find(output, "^Copilot: Enabled and online") then
            copilit_active[ev.buf] = true
         else
            copilit_active[ev.buf] = false
         end
      end)
   end,
})

function copilotIsActive()
  local buf = vim.api.nvim_get_current_buf()
  if copilit_active[buf] then
    return true
  else
    return false
  end
end

i don't think u can do it per component maybe copilot has an auto command for updating which copilot plugin are u using?

Copilot is just a LSP server. You can use LspAttach and LspDetach event to check for updates.
:Copilot status is a very expensive operation, it does a lot of things. Instead you can use #vim.lsp.get_clients({ bufnr = 0, name = 'copilot' }) > 0 to check if Copilot is attached to the current buffer.
local copilot_active = {}
local autocmd = vim.api.nvim_create_autocmd
autocmd({ "LspAttach", "LspDetach" }, {
   pattern = { "*" },
   callback = function(ev)
      copilot_active[ev.buf] = #vim.lsp.get_clients({ bufnr = ev.buf, name = 'copilot' }) > 0
   end,
})

function copilotIsActive()
  return copilot_active[vim.api.nvim_get_current_buf()] or false
end

Thank you for explaining and suggesting a better way to check for this. Thanks really appreciate it. Now I get hit by attempt to call field 'get_clients' (a nil value), this is probably because I am starting buffers with copilot disabled.
This is totally out of scope of this issue now though, so I am closing it. Thanks again @MunifTanjim, I now have an Idea on how to do this better.

just for the curious:
nvim --version
NVIM v0.9.4

searching for get_clients reveals, in the deprecated section:
- *vim.lsp.buf_get_clients()*		Use |vim.lsp.get_active_clients()| with
					{buffer = bufnr} instead.

lsp.get_clients is not to be found. So using vim.lsp.get_active_clients() works somewhat and quickens this up a lot.
It still doesn't really work from a usability point of view as it doesn't change when for example deactivating it for the buffer again but I'll figure that out. Dive into lua is fun. Thanks again @MunifTanjim

Maybe using copilot#Enabled or the buffer options copilot_enabled/copilot_disabled,has less overhead?

(For anyone else looking for a lualine plugin for copilot.vim)
I couldnt find a any information about the activation status of copilot in vim.lsp.get_active_clients({name = 'copilot'}), so I wrote a very simple status indicator for copilot.vim based on vim.g.copilot_enabled instead
https://gist.github.com/bjorntrondsen/4ee91256fdc7fc625578137e669a4b63
I dont know much about Lua or nvim scripting. Maybe a "working.." status could be added as well.

(For anyone else looking for a lualine plugin for copilot.vim)
I couldnt find a any information about the activation status of copilot in vim.lsp.get_active_clients({name = 'copilot'}), so I wrote a very simple status indicator for copilot.vim based on vim.g.copilot_enabled instead https://gist.github.com/bjorntrondsen/4ee91256fdc7fc625578137e669a4b63
I dont know much about Lua or nvim scripting. Maybe a "working.." status could be added as well.

Thanks. I finally got around looking at it and I am thankful. I ended up twisting your code to check for buffer rather than globally, anyone interested can take inspiration:
+  local copilot_enabled = (vim.b.copilot_enabled or false) == true
-   local copilot_enabled = (vim.g.copilot_enabled or 1) == 1

and my function which triggers the b.copilot_enabled is
vim.api.nvim_set_keymap("n", "<leader>cc", [[:lua ToggleCopilotStatus()<CR>]], {silent = false})
function ToggleCopilotStatus()
  local copilot_variable = "copilot_enabled"
  local buf = vim.api.nvim_get_current_buf()
  local enabled = vim.b.copilot_enabled
  if enabled then
    vim.api.nvim_buf_set_var(buf, copilot_variable, false)
  else
    vim.api.nvim_buf_set_var(buf, copilot_variable, true)
  end
  print('copilot', vim.b.copilot_enabled)
end


Fixed db-url flag in standup-db.sh

This change is required because otherwise i get  unknown shorthand flag: 'd'

LGTM. Thanks!


Moving Extensions into main so we don't break stuff

Deleted Azure / Github
Moving others in 3 or 4
Adding in properties files
Added in launchSettings.json (i think we need to revisit, fyi)


All-encompassing pull request

I have already merged all of my pull requests into this "nando" branch, so I can use them. Oh, and it also contains the Windows compatibility code by @sixohsix.
If you start merging my pull requests, there will be a few conflicts along the way. I thought I would offer you a simple way of merging everything at once -- if you agree with every pull request, of course.
Accepting my pull requests without much delay would make it more likely that I continue to share them with you.
I eagerly await your comments on any of them.

I'm glad my windows branch was helpful!
Did you modify my branch so that it can merge into master without conflict, or did you base your work on top of it without doing that?

I did not modify your branch.
I started in master, created branch "nando", and then merged yours into it.
But by now, branch "nando" contains many other improvements. See the other pull requests. They are all merged into "nando" so I can use them right now.
And thanks for your code again!


Create CODEOWNERS

Description

Release required?

[ ] No release
[ ] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

:tada: This PR is included in version 4.1.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


chore: Implement automatic semantic release

closes #16

This is just a dry-run to make sure that the latest version tag works correctly

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Restrict deprecated registry

Related Issue(s)
N/A
Description
As part of an effort to help the Kubernetes community with the impending registry freeze, mentioned in this blog post, I wrote the following example Kyverno policy for this effort.
The Kyverno policy is used to detect the use of container images that use the now deprecated, soon to be frozen, k8s.gcr.io container image registry.
The policy is set to enforce mode, but can be set to audit mode instead.
Checklist

[X] I have read the policy contribution guidelines.
[X] I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.

Can you sign off on your commits, @jimmyraywv ?

Awaiting fix in #517 to run tests.


Add more types of weapon

Expected behavior
Add more types of weapon
REFERENCE

https://github.com/pasutisu/YSFLIGHT/tree/dev/add-weapon

This is planned to be done in the future, we are currently focused on documenting code and making small changes for the time being.
Thanks regardless for your feedback.

Fixing the status of it. Don't worry, we will come back to this.


ScaleLine causes error with debug build

When using the ScaleLine control with the debug build the following error gets thrown:
ol-debug.js:4290 Uncaught AssertionError: Assertion failed: transform should be defined
goog.asserts.DEFAULT_ERROR_HANDLER @ ol-debug.js:4290
goog.asserts.doAssertFailure_ @ ol-debug.js:4325
goog.asserts.assert @ ol-debug.js:4354
ol.proj.getTransformFromProjections @ ol-debug.js:18803
ol.proj.Projection.getPointResolution_ @ ol-debug.js:18423
ol.proj.Projection.getPointResolution @ ol-debug.js:18462
ol.control.ScaleLine.updateElement_ @ ol-debug.js:84411
ol.control.ScaleLine.render @ ol-debug.js:84371
goog.events.EventTarget.fireListeners @ ol-debug.js:12811
goog.events.EventTarget.dispatchEventInternal_ @ ol-debug.js:12908
goog.events.EventTarget.dispatchEvent @ ol-debug.js:12723
ol.Map.renderFrame_ @ ol-debug.js:82875
goog.async.AnimationDelay.doAction_ @ ol-debug.js:36185
Removing ScaleLine from the controls object causes the error to go away.
controls = ol.control.defaults().extend([
new ol.control.FullScreen(),
new ol.control.ZoomSlider(),
new ol.control.Rotate(),
new ol.control.OverviewMap(),
new ol.control.ScaleLine()
]);
The error does not exist when using the ol.js build, just ol-debug.js.

What projection are you using on the view? Are you using proj4js?

It is a Zoomify projection.
projection = new ol.proj.Projection({
code: 'ZOOMIFY',
units: 'pixels',
extent: [0, 0, imgWidth, imgHeight],
//getPointResolution: getPointResolution
});

Well, that explains it. The ScaleLine control displays a "rough x-axis distances, calculated for the center of the viewport". Since this may vary depending on projection, it asks the projection for the resolution of the center coordinate.
The default implementation for getPointResolution calculates the resolution by transforming them to a global coordinate system and calculates their real distance on that. Since your projection is not geo-referenced, this won't work so you must provide a way to transform the pixel coordinates to real distances.
Take a look at http://jsfiddle.net/c8tpbpf2/. It's based on the zoomify example (http://openlayers.org/en/v3.6.0/examples/zoomify.html?q=zoomify), I just added the ScaleLine control and a simple getPointResolution function. I also had to change the projection unit to meters to handle a second assertion error (ScaleLine control expects the projection to have a ol.proj.ProjectionUnit as unit)

Thank you so much! Apologize I am a bit of an OpenLayers noob. Starting to dig deep for a big project where it is the perfect tool.

Closing due to lack of activity.


[Bug]: GET call to Storage cost returns 500

Contact Details
No response
What happened?
Any GET request to https://api.natron.io/api/v1/{Tenant}/costs/storage or https://api.natron.io/api/v1/costs/storage (no tenant) returns a server error 500.
Version
v0.2.4
Relevant log output
No response
log in api:
ERROR: 2022/02/01 09:38:42 costController.go:258: storage class longhorn-hdd-backup not found

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I think I know, why this is happening:
The related storage class cost is not initialized via the env variables

Setting env variables correctly solved the problem.


Azure Sentinel in Azure government

Does Azure sentinel for Azure Government have provisional authorization as of 03/30/2020? It is not reflected within this page

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4e27d0b1-56f9-2eb7-8fee-0c47cfbafeac
Version Independent ID: 12556227-6adc-52c1-ac60-f341ae247e51
Content: Azure Services in FedRAMP and DoD SRG Audit Scope
Content Source: articles/azure-government/compliance/azure-services-in-fedramp-auditscope.md
Service: azure-government
GitHub Login: @Jain-Garima
Microsoft Alias: gjain

@nchamberlain05 Thanks for the question! We will review and get back to you!

Thanks for your question. Please provide us with the link to the documentation you are referring to so we can better assist.

https://docs.microsoft.com/en-us/azure/azure-government/compliance/azure-services-in-fedramp-auditscope

@nchamberlain05 Thanks for the feedback !  I have assigned this issue to content author to investigate and update the document as appropriate.

any updates on this?

Old issue - no longer relevant.  Microsoft Sentinel (formerly Azure Sentinel) does have DoD IL4 and IL5 PA in Azure Government.

#please-close


WebEditor changes do not fire NodeMutateEvent, NodeAddEvent and NodeRemoveEvent

Description
The NodeMutateEvent , NodeAddEvent and the NodeRemoveEvent are only fired when the Nodes are changed using in-game commands. All editor changes are ignored.
Reproduction steps

Register listeners for NodeMutateEvent, NodeAddEvent and the NodeRemoveEvent.
Make them print a debug message.
Compile plugin and put it on the server.
Run /lp user <name> permission set <somePermission> -> See debug message
Do the same thing from the editor
Save editor changes using command   -> There is no debug message / The listeners are not getting called.

Expected behaviour
I would expect the NodeMutateEvent , NodeAddEvent and the NodeRemoveEvent to reflect any change to the Nodes state, not depending on which service changed them.
Environment details

Server type/version: Paper running version 1.16.5 git-Paper-372
LuckPerms version: v5.2.92

Thanks for the detailed report! This should be fixed by the above commit :)

Thanks for the detailed report! This should be fixed by the above commit :)


bump: [#4684] Upgrade filenamify using import-sync for esm-only package

Addresses # 4684
#minor
Description
This PR updates the filenamify package to its latest version 6.0.0. Starting on version 5.x, this package is ESM-only, so we used import-sync to be able to use this version.
Specific Changes

Updated filenamify from 4.3.0 and 6.0.0 in botbuilder library.
Added import-sync as a dependency in botbuilder.
Added filenamify to the depcheck ignore list as it threw a false positive on unused dependency.
Updated the fileTranscriptStore class to import the package filenamify using the importSync function.

Testing
The following images show the installed version and the unit tests passing after the changes.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.3%) to 84.355%

Totals

Change from base Build<PHONE_NUMBER>0:
-0.3%

Covered Lines:
20433

Relevant Lines:
23064

💛  - Coveralls

/promoted 4782


Drop Python 2.7 support

Re: issue #253, this PR removes Python 2.7 support and drops several Python 2-isms. Tell me if you see more!

Merging this. This isn't the 6.0.0 release yet, but it will be close to it.


Help and text for errors placed incorrectly

Could not reproduce locally however got one error report in private (pop-os alacritty bash). Its reproduced by Github CI. Should take this up with maintainer of proc-macro-error.

Issue occurs only on stable. Probably because proc-macro-error can not use the diagnostics API on stable. I expect this issue to disappear when it stabilizes, at which point we might be able to drop the dependency on proc-macro-error.


chore: TEMPORARY REFERENCE PR FOR COMPARATIVE PERFORMANCE TESTING

DO NOT MERGE!!!
THIS PR IS JUST TO STANDUP A REFERENCE RDEV FOR PERFORMANCE TESTING.
Reason for Change

#TICKET_NUMBER
If the reason for this PR's code changes are not clear in the issue, state value/impact

Changes

add
remove
modify

Testing steps

Either list QA steps or reasoning you feel QA is unnecessary
Describe how you made sure to know that your changes worked. Should allow someone else to go verify your code without in depth knowledge.
"Unit tested only", "tested in rdev by a, b, c, verifying feature worked by... ", "manually ran pipeline locally with these results: ..."

Checklist 🛎

[ ] Add product, design, and eng as reviewers for rdev review
[ ] For UI changes, add screenshots/videos, so the reviewers know what you expect them to see
[ ] For UI changes, add e2e tests to prevent regressions

Notes for Reviewer

Testing done..closing


Bug: Voting Phrase to phrase

when a bot upserts a new translation, it should upvote a phrase-to-phrase translation, but it does not. Fix it.

not fixed yet.


Hardcore Ender Expansion heads rendering error

https://github.com/user-attachments/assets/d28b601a-842d-4cfa-a1ce-2cc3fbb61002

Lmao, wtf is HEE doing??

Cannot reproduce

This is also a problem caused by AsieLib

I've installed AsieLib and still cannot reproduce this issue.

Now I find that backhand is the cause of the problem

Still cannot reproduce with backhand installed on a minimal instance

I've gone to work now. I may have to wait for the weekend to sort out the problem

I found that with the latest SimplesKinbackport-F67FA888-master +f67fa8890c-dirty, this bug disappeared

I think we can consider it fixed then! Thanks for testing

Btw, I hope my new skin solution has worked good so far, my goal was to replace SkinPort and other skin backport alternatives.

Thank you for your hard work, thank you!


Get rid of Core, refactor into several files

I don't think there's any reason to have a giant file called Core.
Instead, I'd like to break pretty much everything in that file into its own file and be more selective about what's exported in the public API, which would probably include explicitly laying out each export and getting rid of the giant apply function.

1.0 can move on without this, but this is still a good idea.

Do you still want to do this, or can I write a PR for it?

I think I'd like to do it. It's not really that interesting of a problem.

Okay!


Syntactically driven convolutional models

The standard convolutional model generates features from windows of contiguous words. If we are given a syntactic parse of a sentence we can instead generate a window for each syntactic component. Perhaps the pooling layer could extract the maximum value from sets of constituents at the same parsing depth.
The more general idea is to redefine the notion of "window" to be something more relevant than contiguous tokens. Maybe implement a more generic version of Keras' Conv1D.
Check the literature to see if this has been done. This is basically a research paper idea.

Issue moved to wpm/nlp-experiments #1 via ZenHub


window.open questions

should using window.open spawn a window which will have node-integration?
if I spawn a window through BrowserWindow to have proper node-integration, can I access its window object space directly?

Basically Brackets is doing integration tests like this:
 _testWindow = window.open(getBracketsSourceRoot() + "/index.html?" + params.toString(), "_blank", optionsStr);
_testWindow.brackets.test.CommandManager.execute(cmd, args);

I'd like to see if I can somehow port these tests into Electron.

This would be a minimum sample of how Bracekets (and maybe other apps too) work: https://github.com/zaggino/electron-sample

what do you mean with "node-integration" there are several modules available to both processes main and renderer you can either use remote to interact with node modules form the renderer or you can use ipc to communicate between both processes.

I don't want to open a new process with window.open, I just want to open a new window and have control over it like in the traditional browser environment. Is that possible?

should using window.open spawn a window which will have node-integration?

Good question. The ideal answer to this should probably be that it inherits whatever its parent is doing.

if I spawn a window through BrowserWindow to have proper node-integration, can I access its window object space directly?

No, you need to call the executeJavaScript method. This method returns void, but with a few backflips you can make it return a JSONish value asynchronously by injecting some code into the target page that will respond to requests to eval code and send the result back over IPC. Something like:
// Inject this into the child window:
window.rendererEvalAsync = (blob) => {
  let data = JSON.parse(decodeURIComponent(blob));
  try {
    data.result = JSON.stringify(eval(data.code));
  } catch (error) {
    data.error = { stack: error.stack, message: error.message };
  }

  ipc.sendToHost('eval-async', data);
};

// In the parent
  // Public: Executes JavaScript in the context of the SSB and returns the
  // result, as long as it is JSON-serializable (unlike the built-in
  // executeJavaScript)
  //
  // Returns an Observable Promise which is either the return value of the
  // code that was invoked, or onErrors with the Error that was thrown.
  executeJavaScript(code) {
    let msg = { code: code, id: uuid.v4() };

    // TODO: Listen to IPC messages with 'eval-async' and return a Promise.
    // Our implementation is very Rx'y and I didn't want to make this sample super
    // complicated

    // NB: This is a secret handshake with the embedded page    this.wv.executeJavaScript(`global.rendererEvalAsync(\"${encodeURIComponent(JSON.stringify(msg))}\")`);
    return ret;
  }

The window.open in Electron is only used for being compatible with traditional web pages, its API is very limited so it is not possible to find out a behavior that works for all cases. For any complex app it is recommended to use browser-window module directly.


crash with viafabricplus

Describe the bug
Clicking the multiplayer menu with viafabricplus installed crashes the game
To Reproduce
Steps to reproduce the behavior:

get raknetify and viafabricplus
launch the game and click multiplayer
crash

Expected behavior

it is supposed to not crash
Screenshots

Runtime info (please complete the following information):

OS: Linux
Minecraft version: 1.20.4
Mod version: raknetify-fabric-0.1.0+alpha.5.128-all.jar

Crash reports / logs

https://pastebin.com/kCcHcDSs
Other mods

Checklist

[x] I am using the official version of the mod.
[x] I tried the latest development version but the issue persists.
[x] I searched for similar open issues and could not find an existing bug report on this.

Additional context

fabric 0.16.0

Duplicate of #50
Use standard viafabric instead. https://modrinth.com/mod/viafabric


docs: move toHaveLength and toHaveProperty to toHave* group

Summary
Move .toHaveLength and .toHaveProperty to .toHave group to keep matchers in correct order.
Test plan
Tested with yarn start in website.

Codecov Report

Merging #8566 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #8566   +/-   ##
======================================
  Coverage    63.2%   63.2%
======================================
  Files         271     271
  Lines       11284   11284
  Branches     2749    2748    -1
======================================
  Hits         7132    7132
  Misses       3538    3538
  Partials      614     614

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d3db2...fd4927c. Read the comment docs.


[Trivial] Update getting-started.md @open sesame 03/05 12:30

Update getting-started.md file

Corrected the ambiguous content to make it easier for users to understand

:memo: TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2129. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2129-202302281037000.47922801971436-0d0811b0baf153de50c26b849d28799819f2fdf3/report/misspelling_result.txt.

:octocat: cibot: @DonghakPark, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2129-202302281037000.47922801971436-0d0811b0baf153de50c26b849d28799819f2fdf3/.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2129-202302281047370.31261491775513-3e0ab9066b5e6dd9e29d9cc0c1a3f280262b7a40/report/misspelling_result.txt.

:octocat: cibot: @DonghakPark, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2129-202302281047370.31261491775513-3e0ab9066b5e6dd9e29d9cc0c1a3f280262b7a40/.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2129-202302281612310.42548990249634-d653c05f8b6bc35ae84098f5f79d6efb2a899867/report/misspelling_result.txt.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2129-202302281613240.33881402015686-d653c05f8b6bc35ae84098f5f79d6efb2a899867/report/misspelling_result.txt.

:octocat: cibot: @DonghakPark, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2129-202302281613240.33881402015686-d653c05f8b6bc35ae84098f5f79d6efb2a899867/.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2129-202303011951370.5067310333252-d653c05f8b6bc35ae84098f5f79d6efb2a899867/report/misspelling_result.txt.

:octocat: cibot: @DonghakPark, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2129-202303011951370.5067310333252-d653c05f8b6bc35ae84098f5f79d6efb2a899867/.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2129-202303051230440.89819502830505-d653c05f8b6bc35ae84098f5f79d6efb2a899867/report/misspelling_result.txt.

LGTM!

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2129-202303071350110.64341497421265-d653c05f8b6bc35ae84098f5f79d6efb2a899867/report/misspelling_result.txt.


store: Add transactions

Transactions are needed because we must leave the db clean if something happens while mutating data. Currently, we have only one resource source but, with the new multi source model, we'll need to mutate two resources agent and source in the same operation. This requires that the op is done in a transaction.
This commit adds transaction support into the store. The code is largly based on the transaction implementation found in other RH service (e.g. uhc-service-account) but is has been made simplier to fit our needs.
The transactions are wrapped into a context and passed to the store when services are asking for source repository (for now, we have only one. Soon to be more). The store checks the context and if it finds a transaction it will use it to create the source repository. Otherwise, it uses its own db connection.
Methods for commit and rollback are added so a service can rollback or commit a transaction if an error occurs.
Signed-off-by: Cosmin Tupangiu<EMAIL_ADDRESS>

/retest

Looks good. I think adding the deploy-db dependency for test Makefile target should resolve the issue. Or do we want to provision the DB in a different way?

Looks good. I think adding the deploy-db dependency for test Makefile target should resolve the issue. Or do we want to provision the DB in a different way?

either that or adding a service in the github actions. But we need to migrate the db and for that I was thinking adding a new command to planner-api migrate.


Update packaging files

We can restore the changelog with an updated version if desired.
If anyone added to AUTHORS wants their entry changed  just let me know.
If you have the time @rossp, I'd greatly appreciate your review of these changes to project metadata.
As long as I didn't miss anything major then we should be ready to release 0.1.18 and branch onwards...

Current coverage is 45.51% (diff: 100%)

Merging #440 into master will not change coverage

@@             master       #440   diff @@
==========================================
  Files            31         31
  Lines          2909       2909
  Methods           0          0
  Messages          0          0
  Branches        482        482
==========================================
  Hits           1324       1324
  Misses         1483       1483
  Partials        102        102

Powered by Codecov. Last update 0159ca1...203de6a


Tests and Compatibility Documentation (CardDAV/CalDAV RFC Support)

As per https://en.wikipedia.org/wiki/Comparison_of_CalDAV_and_CardDAV_implementations#Server_implementations we should probably outline the compatibility with all the different specs.  We should also edit that Wikipedia and include this project too afterwards.
The current DAV header is here https://github.com/sedenardi/node-caldav-adapter/blob/bdfbe17931bf14a1803da77dbb70509db9332695/src/common/response.ts#L8-L25
The main ones it is missing appear to be:

extended-mkcol (WebDAV; extended-mkcol – not essential)
calendar-proxy (Calendar Delegation; gives users other access to your calendar, https://sabre.io/dav/caldav-proxy/, iCal and BusyCal support it)
calendarserver-sharing (sharing and calendar publishing, see https://github.com/apple/ccs-calendarserver/blob/master/doc/Extensions/caldav-sharing.txt)
calendarserver-subscribed
addressbook (CardDAV)
access-control (related to sharing calendarserver-sharing and extendedmkcol)
calendarserver-principal-property-search (calendar discovery, https://datatracker.ietf.org/doc/html/rfc3744#section-9.4)

The calendar-auto-schedule is arbitrary and a related discussion is at https://github.com/Kozea/Radicale/issues/34 and https://github.com/Kozea/Radicale/pull/1337.  Almost none of the implementations support it, so we should try to be 1:1 with the most supported and well-known.
For testing, we could leverage https://github.com/natelindev/tsdav, albeit more specific tests would need to be added.  One could copy/paste one of these folders and rewrite to use a test with this Koa server, e.g. https://github.com/natelindev/tsdav/tree/master/src/__tests__/integration.
I think that we will be submitting a PR to this project to try to add support for CardDAV, since none of the other open-source projects have MIT or MPL like licensing, as this one does.
The Fennel project has some inspiration at https://github.com/LordEidi/fennel.js/blob/abfc371701fcb2581d8f1382426f0ef9e9846554/libs/communication.js#L143, https://github.com/LordEidi/fennel.js/blob/abfc371701fcb2581d8f1382426f0ef9e9846554/handler/addressbook.js#L31 (CardDAV), and https://github.com/LordEidi/fennel.js/blob/abfc371701fcb2581d8f1382426f0ef9e9846554/handler/principal.js#L86.

I think that we will be submitting a PR to this project to try to add support for CardDAV, since none of the other open-source projects have MIT or MPL like licensing, as this one does.

Feel free! Once you do, I'll be sure to review and merge them in as soon as I can.

Hi @titanism, I've added you as a collaborator to this repository. As I mentioned in a comment on another issue, I'm no longer actively developing this project personally, but I'm happy to grant you access to continue it.
I will say, this is my first experience with GitHub Collaborators, so bear with me and let me know if you don't have proper access to review and merge PRs. I can publish new releases to npm when necessary, but we can discuss whether that's something you'd like access to do as well.

Done, let me know if there's anything else.

I ran npm owner add titanism caldav-adapter and got a successful response.
npm notice INFO: User titanism invited to package caldav-adapter successfully.
+ titanism (caldav-adapter)

Is there an additional permissions I need to grant?

No worries, glad you got it sorted.
I've always found DMARC to be more of a footgun than helpful, so I'm not shocked to hear that.

I'm more than happy to transfer ownership!
For some context, this package was developed (and tested) for specific workflows and capabilities. I used other CalDAV implementations (Apple's, radicale, etc.) as well as the RFC spec as guidance, but concentrated on making sure the code paths I was using (often determined through testing against several clients) were correct. Any other code paths (like this example) were admittedly placeholders for if I ended up needing to implement them.
Please let me know what you need me to do to transfer the repo. I love that the countless hours I've poured into this are proving useful for others!

I received this error when I tried transferring it. Looks like you already have a fork, so not sure how you want to handle it.

New error this time.

Done!

@titanism Congrats on getting your features out the door.
One thing that caught my eye is the removal of Typescript support in that release. While this library is now fully yours to do with what you want, I would strongly recommend reconsidering this decision for a 2 main reasons:

Typescript (IMO) is now the de-facto standard among npm libraries. Removing TS typings may not only turn away folks from using it in their own applications (as it would for me if there were no types), but highly discourages outside developers from contributing.
While the application you're using this library in may not be Typescript, TS is backwards-compatible and does bring some nice type-hinting to most popular IDEs.

Feel free to reach out if you'd like to discuss this decision further. As I mentioned, the decision is fully in your hands now, but I mention it only to promote the broad use of and contribution to this open source library.

Fair enough!


Windows

This modifies the feedstock to build on windows

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

FTR am fine with this happening. That said, there is  m2w64-make, which might work for you for now.

Thanks for letting me know @jakirkham. I didn't know about that package.