Clarify documentation in Props / Prop Casing

I now understand that when passing props to components the HTML attributes must be kebob-case such as <my-component my-prop="abc"></my-component>
At the same time, in Javascript props may be (should be?) named in camelCase such as prop: ['myProp'] and must be referenced in JavaScript via camelCase such as x = this.myProp
The documentation at https://vuejs.org/v2/guide/components-props.html isn't quite clear about this with respect to passing values to props when using components.
I think adding a line to the documentation would have saved me several hours of debugging today.  How about:

Prop Casing (camelCase vs kebab-case)
HTML attribute names are case-insensitive, so browsers will interpret any uppercase characters as lowercase. That means when you’re using in-DOM templates, camelCased prop names need to use their kebab-cased (hyphen-delimited) equivalents:
This also means that when using components you must pass values via kebab-case attributes, even if the prop name is defined in camelCase.  Vue will automatically know that an HTML attribute like <blog-post post-title="hello!"></blog-post> is to be accessed as this.postTitle within JavaScript code.

The clarification about remembering to pass prop as kebab-case even though the prop is defined as camelCase would have been helpful.  Also, the clarification that Vue automatically allows the kebab-case prop to be accessed in in JavasScript as a camelCase identifier would likewise have helped me more quickly understand the behavior.

Hi @DavidRueter, attributes must be kebab-case only, if you are using in-DOM-templates (for example if you include Vue as a script tag and actually define component templates in the DOM with ). If you use string templates (that would be using the template property of an instance and assigning a string to it or using a build system like vue-cli does with webpack, which "loads" each .vue file and parses templates as strings before actually using it), this limitation DOES NOT apply.
So if you are using string templates, you could actually use camelCase in both HTML and JS. It's just a best practise, to use HTML conventions (kebab-case) for HTML code and JS conventions (camelCase) for JS code. But this could definitely be something that could be extended!
@chrisvfritz @defcc @Jinjiang would a PR be welcome to add some explanation on what exactly an in-DOM-template is and what a string template is? And maybe also an extension of the explanation that props being passed in string templates can be passed as someProp and some-prop, but will be converted to someProp in JS?

@ivansieder sure, PR's are always welcome :)

Created https://github.com/vuejs/vuejs.org/pull/1833. not that much, but hopefully helpful! :)


accessing apVisit spectra

Is it possible to use this package to download and inspect apVisit spectra (individual visits) in addition to apStar spectra (all visits added together)? It's not clear from the documentation, and this would be very useful!

No, reading apVisit files is currently not supported, but note that the apStar files do contain the individual exposures as well. The difference is that in apStar the wavelength sampling is the standard APOGEE wavelength grid (equally spaced in log10(wavelength)), while in apVisit the spectra are on the native detector wavelength grid. You can read the individual spectra in apStar by reading HDU1 and selecting the columns 2 onwards (0 and 1 are the combined spectra).

Awesome, thanks!

Hi again :) I recently started using this approach to access individual visit data, and realized today that there is more than just a wavelength grid difference: the apVisit files are not RV-corrected while columns 2+ from the apStar HDU1 are. This is no good for science cases like mine (measuring precise RVs). Is there any possibility of supporting non-RV-subtracted apVisit data in the future?

Yes, that's correct: apVisit files are on a different grid (non-RV corrected) from the apStar equivalent. I don't have any immediate plans for supporting apVisit files, but I would be happy with a pull request :smile: Should be easy to do based on the apStar routines.

That's what I was afraid you would say! OK, we'll see... :smile:


Update crate version to 0.2.149

Contains fixes for net structs/calls for Vita target - #3284 and #3366. Required for rust-lang/socket2/pull/465

Closing for now, as we've decided to implement socketpair and pipe2 for vira in newlib, and both these changes and #3284 will be needed then.

Sorry for the delay, let's go ahead 🚀
@bors r+

:pushpin: Commit 52fd56b46e7eca4e103178659bc570d0c7d65fb9 has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit 52fd56b46e7eca4e103178659bc570d0c7d65fb9 with merge d80e8bd3056d82fec80c022819084bdb0be3bdaa...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing d80e8bd3056d82fec80c022819084bdb0be3bdaa to main...

Published on crates.io: https://crates.io/crates/libc/0.2.149


broken link in second example

http://elixir-lang.org/getting_started/ex_unit/1.html in 30-days-of-elixir 02-unit-testing.exs returns 404

I've replaced the links throwing 404 with related ones under http://elixir-lang.org (I couldn't find exact match for some of them, as document structure has changed).

+1

Cool thanks!


Remove unnecessary variable assignments

Enable ineffassign

Seems like stuff a linter should be able to catch.

We can enabled ineffassign linter on golangci-lint to do this.

ineffassign is now enabled with https://github.com/go-gitea/gitea/pull/17695/commits/fb6c628d963ca374429727d80ff85212c91fcfb2

make L-G-T-M work.

@zeripath Since it didn't affect any feature, I moved this to kind/lint


Goal: v1.0 proper

[ ] Get a feel for the ergonomics, replace dashcore-lib in

[ ]  dashsight examples
[ ]  crowdnode
[ ]  dashwallet

[ ] bikeshed on names of things
(pukkeyhash vs pukKeyHash, sighashType vs sigHashType)
[ ] getPrivateKey() in txInput?
[ ] subscript vs lockScript and sigScript?
[ ] publish v1.0.0 to npm

Bikeshed
CoreUtxo vs InsightUtxo vs BlockUtxo
/**
 * CoreUtxo (as in BitCore / DashCore)
 * @typedef {Object} CoreUtxo
 * @property {String} txId
 * @property {Number} outputIndex
 * @property {String} address
 * @property {String} script
 * @property {Number} satoshis
 */


search service should handle exceptions related to corrupted json files

When downloads.json or searchrankings.json files are not in proper format or has duplicate entries, the service should be able to handle it instead of throwing exception.

https://github.com/NuGet/NuGet.Services.Metadata/commit/f18a03f4f63fdf5cfe216002ee49b6463f4cb945 - addresses this.


Restoring proper theme functionality

Recently Chromium doesn't handle themes properly, as textures for tabs stretch weirdly or only can change colors without any textures.
Example:

I've noticed that themes handling did change slightly around v.117ish. This is inherited from upstream. The difference seems to be rather small, mostly dealing with the vertical orientation and tabs textures. Have you tried unpacking the crx and modifying the theme's images to your liking? I've began forking my own themes with little difficulty, This tool can automate some of the process, and generates a manifest: https://www.themebeta.com/chrome-theme-creator-online.html


Minor Bugfix Black_Crusade.html

Changes / Comments
-Fixed Dodge rolls not working.
-Fixed Spelling issues.
-Minor change to how Fails display. More work is needed here but I have a limited knowledge/ time to do it myself.
-Fixed color not showing on degrees.
Roll20 Requests
Include the name of the sheet(s) you made changes to in the title.
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

Is this a bug fix?
Does this add functional enhancements (new features or extending existing features) ?
Does this add or change functional aesthetics (such as layout or color scheme) ?
Are you intentionally changing more that one sheet? If so, which ones ?
If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

@KriosMerew There were multiple pull requests to change these files. You'll need to resolve the merge conflicts before this can be merged in.

It should be fixed now.


Refactor fromEvent

makes fromEvent just a function
updates tests
removes resultSelector from fromEvent
fromEvent will now emit an array if the event callback has multiple arguments.
updates docs

Coverage increased (+0.005%) to 97.559% when pulling 51b37fddeb1d4b00cd46f0303f92b22f2c37b149 on benlesh:refactor-fromEvent into 0a3a04a1532fff84407b4bceb86d19f2e9ef05af on ReactiveX:master.

Since resultSelector is deprecated, if people want a consistent result from fromEvent() you recommend they:
.pipe(map(value => Array.isArray(value) ? value[0] : value))

This reminds me of https://github.com/petkaantonov/bluebird/issues/307
I personally think bluebird made the right decision to require users explicitly choose between single or multi-arg support. Sort of like how RxJS used to work... Feels like a tiny step back for RxJS.

@benlesh Can you elaborate on why a single argument stays as-is instead of being wrapped into an array? If you get a single argument that is an array of its own, there seems to be no way to tell it apart from a multiple argument array.

@spaiger @j2L4e.. to be clear, fromEventPattern has had this behavior for years. Long before my involvement with RxJS. fromEvent in RxJS 5 accidentally had no support for multiple arguments. So we added it in to be consistent with fromEventPattern and other versions on RxJS. Nothing "changed" or "stepped backwards".
I'm happy to look at an issue and discuss with the larger community ways to improve this.
We could, of course, undeprecate the result selector. There's a lot of options.
File another issue


JWT x5c Header seems to be invalid

The x5c JOSE header of the Request Object JWT seems to be malformed:
https://github.com/eu-digital-identity-wallet/eudi-srv-web-verifier-endpoint-23220-4-kt/blob/665b69b0c58f19f4ec022792fab49d412e8818ec/src/main/kotlin/eu/europa/ec/eudi/verifier/endpoint/VerifierContext.kt#L357-L359
generates a list of base64 encoded PEM, whereas the RFC defines it as a list of base64 encoded DER (https://datatracker.ietf.org/doc/html/rfc7515#section-4.1.6). Every Request Object JWT will have an invalid x5c header and can't be verified with default JWT/JAR implementations.
This issue is probably present in the client implementation as well?

@dzarras We need to double check the swift implementation

Dear @c2bo v0.1.1 of Verifier Endpoint has been released. This new version contains the fix for the bug you reported and is already deployed.
Thanks again for reporting this.


Don't install any icons in postinstall

I'd prefer to have the default icons for this theme.

@Defman21 Do we (as the publisher of Xenite) still recommend Numix? In the end, it's any way the user's choice but back then we considered them as a recommendation, so I'd added them into postinstall.sh. If we aren't OK with it anymore, I'll remove that piece of code ASAP. Also, if any other recommendations are up, I'll add them, I just need to know :)

I don't really have any things to recommend in my mind nor I want to have users to install Numix. I think this could cause some problems with wingpanel because they are stylizing the indicators using CSS (I mean the colors).

@Defman21 OK, I didn't know that Numix could cause Xenite trouble. I'll remove it from post-install.sh.

I don't know if it could cause some troubles, I just think it could. I don't want to test it :P

Resolved.


Some documentation on OAI server

@adamdickmeiss I rephrased a little and brought back some previous content. Check if you're OK with this.


Make flashing settings work without needing to restart the mcu.

Not too difficult since most of the modules should already be using and initialization functions. This will avoid the host disconnecting and reconnecting our USB port.

600f84962d69d54edf3a041a1fd63cd1e89757ce implements this feature.


[BUG] Instance manager pods are recreated immediately when the node draining evicts the old pods

Describe the bug
See the title
To Reproduce
Steps to reproduce the behavior:

Launch Longhorn system
Drain one node via kubectl drain

Check the logs in longhorn manager pods and see if there are instance manager pod removal then recreation messages.
The instance manager pods are recreated on the draining node. But the drain execution will succeed.

Expected behavior
The instance manager pods should not be recreated on the unschedulable node.
Environment

Longhorn version: master (12/23/2021)
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: v1.21.6

Number of management node in the cluster: 1
Number of worker node in the cluster: 3

Additional context

It seems that the k8s Scheduler logic will be bypassed and the NoSchedule does not work once the nodeName of a pod is specified
The instance manager controller does not check if the node is unscheduled before creating pods for instance managers.

This issue will be fixed along with #2650

We need to evaluate the node conditions before scheduling / deployment decisions.
I did this for the share-manager where I evaluate whether the node is cordoned/unschedulable.
We currently don't do this for im deployments / replica scheduling (if I remember right?).
Good idea to takle it with #2650

Validated on Master-head 01/28/2021
Validation - Pass
Validated the drain of nodes with below commands.
1. kubectl drain <node_name> --delete-local-data=true --force=true --grace-period=-1 --ignore-daemonsets=true --timeout=180s --pod-selector='app!=csi-attacher,app!=csi-provisioner'
2. kubectl drain <node_name> --delete-local-data=true --force=true --grace-period=-1 --ignore-daemonsets=true --timeout=120s

Test result:
Tested with combination of scenarios, Nodes having attached volume, nodes without having attached volume but replicas, Cluster having detached volume -

The Instance manager pods got terminated on running the drain command.
Once the node was cordoned, the IM didn't get recreated and volumes remain degraded.
On uncordoning the node, IM got recreated on the node and Longhorn reused the failed replica. Volume becomes healthy.

kubectl drain <node> --delete-local-data=true --force=true --grace-period=-1 --ignore-daemonsets=true --timeout=120s
node/<node>cordoned
evicting pod "csi-attacher-5f46994f7-zpqrb"
evicting pod "csi-snapshotter-86f65d8bc-twlfc"
evicting pod "instance-manager-r-60cc960f"
evicting pod "csi-provisioner-6ccbfbf86f-m9vtc"
evicting pod "csi-provisioner-6ccbfbf86f-tz9mg"
evicting pod "statefulset-static-rwx-1-0"
evicting pod "deployment-dy-pvc-1-64ff6df848-2n4vl"
evicting pod "statefulset-dy-rwx-1-0"
evicting pod "csi-resizer-6dd8bd4c97-lxz62"
evicting pod "statefulset-vct-1-0"
evicting pod "coredns-8578b6dbdd-bn6x9"
evicting pod "metrics-server-6bc7854fb5-qh4zb"
evicting pod "instance-manager-e-673b8634"
evicting pod "longhorn-webhook-5fcd9cbc45-27pbg"
evicting pod "longhorn-ui-66686dcc96-cvgj8"
evicting pod "share-manager-pvc-8a79fc9d-243b-490c-ad36-7eb174556c71"
evicting pod "statefulset-static-pvc-1-0"
error when evicting pod "instance-manager-r-60cc960f" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.
error when evicting pod "instance-manager-e-673b8634" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.
evicting pod "instance-manager-r-60cc960f"
evicting pod "instance-manager-e-673b8634"
error when evicting pod "instance-manager-r-60cc960f" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.
error when evicting pod "instance-manager-e-673b8634" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.
pod/statefulset-static-pvc-1-0 evicted
pod/csi-attacher-5f46994f7-zpqrb evicted
pod/csi-resizer-6dd8bd4c97-lxz62 evicted
pod/deployment-dy-pvc-1-64ff6df848-2n4vl evicted
pod/statefulset-static-rwx-1-0 evicted
pod/csi-provisioner-6ccbfbf86f-m9vtc evicted
evicting pod "instance-manager-r-60cc960f"
error when evicting pod "instance-manager-r-60cc960f" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.
evicting pod "instance-manager-e-673b8634"
error when evicting pod "instance-manager-e-673b8634" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.
pod/csi-provisioner-6ccbfbf86f-tz9mg evicted
pod/csi-snapshotter-86f65d8bc-twlfc evicted
pod/statefulset-vct-1-0 evicted
pod/coredns-8578b6dbdd-bn6x9 evicted
pod/longhorn-webhook-5fcd9cbc45-27pbg evicted
pod/metrics-server-6bc7854fb5-qh4zb evicted
pod/share-manager-pvc-8a79fc9d-243b-490c-ad36-7eb174556c71 evicted
evicting pod "instance-manager-r-60cc960f"
error when evicting pod "instance-manager-r-60cc960f" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget.
evicting pod "instance-manager-e-673b8634"
pod/statefulset-dy-rwx-1-0 evicted
pod/instance-manager-e-673b8634 evicted
evicting pod "instance-manager-r-60cc960f"
pod/instance-manager-r-60cc960f evicted
pod/longhorn-ui-66686dcc96-cvgj8 evicted
node/<node_name> evicted


update(docs): update release docs

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area plugins

/area registry

/area build

/area documentation

What this PR does / why we need it:
update(docs): update release docs
see #440
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: alacuku
Once this PR has been reviewed and has the lgtm label, please assign leogr for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alacuku, jasondellaluce
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [jasondellaluce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: f0960bd9823c021316f48a5664a9d037fbd78ff5


Support - SDK 15

Feature Request
Description
Support starting in Android SDK 15
Proposed Solution
Alternatives I've considered
Currently, Im working with an old system, that supports user with SDK 15. I'm facing off to fix bugs with Retrofit in their current version. So, I decided to test Fuel, I've had a great experience before with it. But unfortunately, It's only available for SDK 19 or higher. Is there any Fuel Version that supports 15?

The reasonable minSDK has been 16 since mid 2015 and 19 since november 2016. We should actually increase the min SDK to 21.

Thanks for the support. I'm working with a huge app with more than 500k user, I was thinking in switch from volley to Fuel, but we have to support a few number of users in SKD 15.

You could use Kotlin coroutines android for it that able to support much older min SDK.


Warning on unused resources

After refactoring, it's often possible that a computed property or component that was once needed is no longer required. And typoes are a thing, too. It'd be fantastic if Vue could detect if a computed property, method, component, etc. wasn't being used, and warned in the console if so. Maybe with a strict config flag, or similar?
Simple example when a warn should be triggered for data fields. The value2 data field is unused.
<template>
  {{ value1 }}
</template>

Limitation: the component/instance might be using the resource inside its definition, and not in the template.
<template>
  {{ computedValue }}
</template>

Would it still be possible?

I don't think this is Vue's responsibility. Also a computed property may get used in non-template scenarios. Instead you can detect unused code with a coverage tool.


fix: populate in series

Potential temporary fix for:
Error: EPERM: operation not permitted, rename 'C:\Users\travis\AppData\Local\Temp\ipfs-test-de2fc17f2aa28095e191f466fe8a6601\blocks\US\.3752.7204' -> 'C:\Users\travis\AppData\Local\Temp\ipfs-test-de2fc17f2aa28095e191f466fe8a6601\blocks\US\CIQPEUFLMK4TATXY3U6F7FNH33MIRA4KTFDAKY5ZKL7CCVQDQRIZUSQ.data'

This happens on the windows build in js-ipfs. Perhaps concurrent read/write is the issue?
License: MIT
Signed-off-by: Alan Shaw<EMAIL_ADDRESS>

Update: this seems to be the issue. I have run https://github.com/ipfs/js-ipfs/pull/1889 multiple times on windows in CI and the issue has gone.
Issue raised here https://github.com/ipfs/js-ipfs/issues/1890


Readonly proxy

It should be (relatively) easy to also add readonly(state) which would provide a proxy onto an observable that throws an error on any write operation.

I've given this some more thought but the observable datatypes we have now aren't true proxies. They actually hold the data, instead of referencing another container. So this would actually be a little more challenging.

Somewhat related, but not a complete solution:
types.MappingProxyType: https://docs.python.org/3/library/types.html
The problem is that unlike in Js Proxy objects, the proxy is not "deep". The getters in python do not return proxies; they return the original, mutable data.

I've read up quite a bit on how JS proxies work and they are quite similar to our observable collections in the sense that you are proxying calls to underlying implementation. If we can do that, surely we can handle an object reference in addition, right? Right? I guess I will find out soon enough. :)


⚠ Bofrost.de has degraded performance

In 91ff2f1, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1086 ms

Resolved: Bofrost.de performance has improved in 1c36c08.


0.33.0 - 'npm ci --omit=dev --cpu=x64 --os=linux --libc=glibc' installs both glibc and musl libs

Possible install-time or require-time problem

[x] I have read the documentation relating to installation.

Are you using the latest version of sharp?

[x] I am using the latest version of sharp as reported by npm view sharp dist-tags.latest.

If you cannot confirm this, please upgrade to the latest version and try again before opening an issue.
If you are using another package which depends on a version of sharp that is not the latest, please open an issue against that package instead.

[ ] I am using Node.js 18 with a version >= 18.17.0
[x] I am using Node.js 20 with a version >= 20.3.0
[ ] I am using Node.js 21 or later

If you cannot confirm any of these, please upgrade to the latest version and try again before opening an issue.
Are you using a supported package manager?

[x] I am using npm >= 9.6.5
[ ] I am using yarn >= 3.2.0
[ ] I am using pnpm >= 7.1.0

If you cannot confirm any of these, please upgrade to the latest version and try again before opening an issue.

Please see https://github.com/npm/cli/pull/6914

I'm probably missing something, but I'm seeing the same thing happening when using either pnpm or yarn which do allow to set the supported architectures.
Example package.json file
{
  "name": "sharp-binaries",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "dependencies": {
    "express": "4.18.2",
    "sharp": "0.33.0"
  },
  "os": ["linux"],
  "cpu": ["x64"],
  "libc": ["glibc"],
  "pnpm": {
    "supportedArchitectures": {
      "os": ["linux"],
      "cpu": ["x64"],
      "libc": ["glibc"]
    }
  }
}

PNPM
Uses the pnpm property in package.json to setup supported architectures as defined here.
Dockerfile
FROM node:18.18-alpine3.18
RUN corepack enable && corepack prepare pnpm@latest --activate
COPY package*.json ./
RUN pnpm i
COPY index.js ./
CMD ["node", "index.js"]

Build targetting linux/amd64
docker build . --no-cache --platform=linux/amd64 --tag 'sharp-binaries:latest'

Results
I'm seeing 4 packages (using Docker desktop) where I'd expect to see 2 (sharp-libvips-linux-x64 and sharp-linux-x64):

Yarn
Uses os, cpu and libc properties in package.json as described here.
Dockerfile
FROM node:18.18-alpine3.18
COPY package*.json ./
RUN yarn install
COPY index.js ./
CMD ["node", "index.js"]

Build targetting linux/amd64
docker build . --no-cache --platform=linux/amd64 --tag 'sharp-binaries:latest'

Results
I'm seeing 19 packages where I'd expect to see 2 (sharp-libvips-linux-x64 and sharp-linux-x64)

@adriaanmeuris For pnpm, please see https://github.com/pnpm/pnpm/pull/7214 - if the latest version of pnpm is installing the wrong dependencies, then please ask at the pnpm repo.
For yarn, it looks like you're using version 1.
$ docker run --rm -it node:18.18-alpine3.18 yarn --version
1.22.19

Please use at least version 3 of yarn, but avoid its "plug'n'play" linker.
Version 1 of yarn is no longer actively developed and is missing so many useful newer features. See also https://github.com/evanw/esbuild/issues/2949

Thanks, I will track the npm issue.

For whoever ends up here - the --libc npm feature is now merged npm/cli/pull/6914


Add switch for 'auto' mode

Unless I'm missing something, I haven't found a way to turn on 'auto' mode (on purifiers such as 311i Max, 311i+ Max, 411i Max)
It would be great if another switch could be added similar to the 'night mode' switch, then we'd be able to turn on or off auto mode just as easily.
Thanks for all the work on this plug-in - works great!

There is a switch of sorts. In the Home app have my 311i Max configured to show multiple tiles. Find the main power tile for your purifier and tap to open additional controls. Scroll down past the power switch and fan power slider and you'll find a toggle for mode (manual/auto).

@denleschae nevertheless it would be good to show the auto mode as a toggle next to the on-off / fan speed slider within the main tile, since it's probably the most frequently used mode that one would want to toggle into.


Test with Java 21 and Jmeter

Currently we are using Jmeter 3.3, according to https://openjdk.org/projects/jdk/21/, we have virtual threads which is supposed to reduce the resource usage per Jmeter process. Currently, it's recommended to keep threads number below 300 per Jmeter process.
So with this issue, we want to know:

Whether the new Java 21 can work with Jmeter 3.3
If it can, is the behaviour changed? For example, whether 300 threads perform in the same way as it was before
If no.2 is the same, then how much resources we can save compared to before
Is the 300 limit still a thing?

when I checked quickly jmeter 3.3 doesn't work with jdk 21 see below.
❯ sdk use java 8.0.352-amzn

Using java version 8.0.352-amzn in this shell.
❯ java -version
openjdk version "1.8.0_352"
OpenJDK Runtime Environment Corretto-8.352.08.1 (build 1.8.0_352-b08)
OpenJDK 64-Bit Server VM Corretto-8.352.08.1 (build 25.352-b08, mixed mode)
❯ apache-jmeter-3.3/bin/jmeter
================================================================================
Don't use GUI mode for load testing, only for Test creation and Test debugging !
For load testing, use NON GUI Mode:
   jmeter -n -t [jmx file] -l [results file] -e -o [Path to output folder]
& adapt Java Heap to your test requirements:
   Modify HEAP="-Xms512m -Xmx512m" in the JMeter batch file
================================================================================
Warning: the fonts "Times" and "Lucida Bright" are not available for the Java logical font "Serif", which may have unexpected appearance or behavior. Re-enable the "Times" font to remove this warning.
❯ sdk use java 21-tem

Using java version 21-tem in this shell.
❯ java -version
openjdk version "21" 2023-09-19 LTS
OpenJDK Runtime Environment Temurin-21+35 (build 21+35-LTS)
OpenJDK 64-Bit Server VM Temurin-21+35 (build 21+35-LTS, mixed mode)
❯ apache-jmeter-3.3/bin/jmeter
Not able to find Java executable or version. Please check your Java installation.

@rsw-a Thanks for checking. yes, looks like jmeter 3.3 only supported Java 8. If we want to use new version of Java, looks like we need to go for Jmeter 5.x.

Let me close this issue as the conclusion is reached.

Since we start considering upgrade jmeter version, we can start to consider this issue. However, we might need project like this in order for Jmeter to support virtual thread: https://github.com/nirmal-mewada/jmeter-loom
Some people also suggest to Jmeter: https://github.com/apache/jmeter/issues/6029 but no progress so far.


Change text color in home page for better accessibility

Related Issue

Issue No. #311

Changes you made :

Change text color in home page for better accessibility

Describe the changes :
This commit will update the text color in home page to have better accessibility

@Kishore-abhimanyu This issue doesn't belong to you, so you can't create an PR.
Plz look for other issues or create new issues.


Comparing Multiple Files

Issue Type: Bug
I open a folder with fileA, fileB, and fileC. Holding Ctrl while selcting fileA and fileB, then right clicking and selecting "Compare Selected" allows me to compare those two files successfully.
I then select fileA and fileC, then right click and select "Compare Selected".
Sometimes this correctly results in 2 tabs for comparing files. Other times, this ends up closing the first tab (fileA and fileB) when it opens the second. Once this error happens, it's nearly impossible to have two comparison tabs again.
I think this error happens sometimes when I close VS code without shutting down each comparison file first. Once the error occurs, creating a new file starts at what the previous file number was. If I closed had a Untitled-1 and Untitled-2 open, then closed them without saving, then closed VS code then the next time I create a new file it is Untitled-3.
VS Code version: Code 1.31.0 (7c66f58312b48ed8ca4e387ebd9ffe9605332caa, 2019-02-05T22:35:56.624Z)
OS version: Windows_NT x64 6.1.7601

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7 CPU         870  @ 2.93GHz (8 x 2926)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: unavailable_offsurface_synchronization: enabled_onvideo_decode: enabledwebgl: enabledwebgl2: unavailable_off

Memory (System)
7.93GB (1.30GB free)

Process Argv

Screen Reader
no

VM
67%

Extensions (2)

Extension
Author (truncated)
Version

gc-excelviewer
Gra
2.1.28

cpptools
ms-
0.21.0

Follow our docs to resolve this: https://code.visualstudio.com/docs/getstarted/userinterface#_preview-mode


Missing module keytar on fresh install of graph-cli

I'm using archlinux, with all package updated including libsecret. I was trying to create a sample subgraph but when I tried to deploy it using the command graph auth https://api.thegraph.com/deploy/ <token> an error showed up:
Error: Error storing access token with libsecret (usually gnome-keyring or ksecretservice): Error:

Cannot store the access token because dependencies are missing. If you
are on Linux, try installing 'libsecret-1-dev' (Debian, Ubuntu etc.) or
'libsecret-devel' (RedHat, Fedora etc.) and reinstalling Graph CLI
afterwards.

The original error was: Cannot find module 'keytar'

This is a fresh install of graph-cli. What I did to resolve this issue is installing keytar manually on global space npm install -g node-keytar.

FWIW, I'm also getting this error in a linux environment in GitHub Actions.
Error: Error storing access token with libsecret (usually gnome-keyring or ksecretservice): Error: Cannot autolaunch D-Bus without X11 $DISPLAY
    at saveAccessToken (/opt/hostedtoolcache/node/10.17.0/x64/lib/node_modules/@graphprotocol/graph-cli/src/command-helpers/auth.js:70:13)

@ffimnsr @PaulRBerg I wish keytar was easier to work with on Linux. FWIW, graph auth is not mandatory. It is also possible to pass the access token to graph deploy with --access-token <TOKEN> instead.

@Jannis It works for me

@ffimnsr @PaulRBerg I wish keytar was easier to work with on Linux. FWIW, graph auth is not mandatory. It is also possible to pass the access token to graph deploy with --access-token  instead.


Implemented TLD Filter

This should resolve #40
TLDs are pulled from https://data.iana.org/TLD/tlds-alpha-by-domain.txt and cached into a tld.json file. TLD changes will be checked for after 24 hours, and Last-Modified headers are used to ignore reading the response body when possible.

Just as a side thought @troyhunt do you have any preference on the scope of storing application files? Currently tld.json writes to the execution location. Would a hidden .data folder, or %AppData% be preferable, or just as is?

This is great @GStefanowich! No preference from me re where the file is placed, happy to defer to your judgement.


Remove the copyright of Lightbend

Closes: #3828

Description

Related issue and scope

[ ] I opened an issue to propose and discuss this change (#????)

My changes affect the following components

[ ] API
[ ] Controller
[ ] Message Bus (e.g., Kafka)
[ ] Loadbalancer
[ ] Invoker
[ ] Intrinsic actions (e.g., sequences, conductors)
[ ] Data stores (e.g., CouchDB)
[ ] Tests
[ ] Deployment
[ ] CLI
[ ] General tooling
[ ] Documentation

Types of changes

[ ] Bug fix (generally a non-breaking change which closes an issue).
[ ] Enhancement or new feature (adds new functionality).
[ ] Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

[x] I signed an Apache CLA.
[x] I reviewed the style guides and followed the recommendations (Travis CI will check :).
[ ] I added tests to cover my changes.
[ ] My changes require further changes to the documentation.
[ ] I updated the documentation where necessary.

Codecov Report

Merging #3827 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3827      +/-   ##
==========================================
- Coverage   74.84%   74.76%   -0.08%
==========================================
  Files         137      137
  Lines        6440     6440
  Branches      401      401
==========================================
- Hits         4820     4815       -5
- Misses       1620     1625       +5

Impacted Files
Coverage Δ

...whisk/core/database/ConcurrentMapBackedCache.scala
90% <ø> (ø)
:arrow_up:

...n/scala/src/main/scala/whisk/common/CausedBy.scala
0% <0%> (-100%)
:arrow_down:

...whisk/connector/kafka/KafkaMessagingProvider.scala
69.23% <0%> (-15.39%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63496d5...ee9b05d. Read the comment docs.


Important change on how iOS handles zero value color & fix one of the recent comments on the Issue #25

PR overview
This PR includes:

An important change where the color of the zero badge value is being picked from the background source (similar to android) instead of the text color value.
Fixed iOS Shell item issue when IsVisible property of a ShellContent object is set to false (#25, latest comment);
Some minor styling changes.

What's changed

iOS platform's shell item renderer;
iOS sample project AppDelegate & Main files.

Actions required

Nuget package needs to be updated;
Sample project needs to be updated.

Thanks again!


add the shortcut "ctrl+l" to clear the entire screen, and expose the "clearScreen" function.

add the shortcut "ctrl+l" to clear the entire screen, and expose the "clearScreen" function.
I use this project in my Scala-Web-REPL. Maybe you can add Scala-Web-REPL to the show.
Thanks for your "jquery-console".

OH, sorr, I forgot Scala-Web-REPL's url:
https://github.com/woshilaiceshide/scala-web-repl

Seems OK!


[Color] Can't change default keyword gutter icon color

With default keyword like FIXME, NOTE,... When i change highlightColor

Color has changed but the gutter DIDN'T.

Then i set iconColor to default.

The color changed but not match with the highlightColor setting.

You got like 80% of the way there. The Gutter color won't change unless you use "iconColor" which you got correct however using "default" is the default Anchor color (AKA white). So what you said is for the icon color to be White.
IconColor can take a HEX Code as well. Try putting your highlightColor into iconColor as well and it will work!
It works for me. If this answers your question please close the ticket.

I didnt know that we can put hex code to that field. Thank you so much sir!


Hindi

[x] Have you followed the contributing guidelines?
[x] Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Checking 344 external links...

_site/hi/building-community/index.html
Ran on 257 files!

linking to internal hash #dont-tolerate-bad-actors that does not exist (line 585)
act immediately
linking to internal hash #enforcing-your-code-of-conduct that does not exist (line 503)
उन्हें जाने के लिए कहो
linking to internal hash #learning-to-say-no that does not exist (line 413)
समझाइए क्यों
linking to internal hash #what-it-means-to-contribute that does not exist (line 412)
योगदान करने के कई तरीके
linking to internal hash #writing-a-readme that does not exist (line 401)
मैत्रीपूर्णREADME

I am getting this error. What should I do?

linking to internal hash #writing-a-readme that does not exist (line 602)
more than just a set of instructions
linking to internal hash #writing-your-contributing-guidelines that does not exist (line 403)
योगदान CONTRIBUTING फ़ाइल  का उपयोग करके

_site/hi/getting-paid/index.html

External link https://www.ashedryden.com/blog/the-ethics-of-unread-labor-and-the-oss-community failed: 404 No error

HTML-Proofer found 8 failures!

Hello @jamestitus299 , thank you for the contributions! Is this PR the one to use instead of #3083 ?
The errors you're seeing are because the internal links that use the ../page/#anchor-name syntax are still using the English names for the headers that they will link to. I think you can change those links to use the Hindi names, like this example from the Korean translation:
[ 수 있도록 [즉각 대응](../building-community/#악당에게-관용을-베풀지-마세요)


fix error where * (indicating unsaved work) disappears after clicking save even when cancelled

Open a design. Make a modification. The filename in the tab will have a * to indicate unsaved work.
When saving, this * is removed based on state.ui_state.changed_since_last_save. However, it is removed even if the user cancels the save after the Save Dialog window has opened.
Probably state.ui_state.changed_since_last_save is being prematurely updated. This should change so that it is updated only upon a successful save.

Update: This seems to be a pretty tough problem to solve, since it involves detecting whether the user hit the cancel button on the Save dialog, but browser security restrictions make it hard to see what the user did with the dialog. (Same reason it is hard to see what new filename they chose, as in #282.
https://github.com/jimmywarting/StreamSaver.js
https://github.com/eligrey/FileSaver.js
Seems to be not possible with FileSaver.js, which appears to use the same approach we are using here.
https://github.com/eligrey/FileSaver.js/issues/126
https://github.com/eligrey/FileSaver.js/issues/187
https://github.com/eligrey/FileSaver.js/issues/389
https://github.com/eligrey/FileSaver.js/issues/569
Seems like it might be possible with StreamSaver.js.
Seems this is a fairly universal problem:
https://stackoverflow.com/questions/41334881/detect-when-user-accepts-to-download-a-file

I don't think we need to know what happened with the Save dialog. Since we use the nonemptiness of the Undo stack as a proxy for unsaved work, perhaps we can just have middleware that checks the stack and changes the title appropriately when it goes from empty to nonempty and vice versa.

I removed "high priority" from this, because I realized that it doesn't actually affect whether the user is warned about leaving with unsaved work. It only affects whether the title accurately reflects whether there is unsaved work.

Are you sure we can use the nonemptiness of the Undo stack? Saving a design doesn't seem to clear the undo stack. I think there are currently false positives in regards to the window warning the user about unsaved work. Ex: If you make an edit and save and then try to close the window, the warning will still pop up, even though the work has been saved.
I guess we could fix both the false-positive warnings and this title issue by making it so that the undo stack changes to empty whenever user saves, but I can easily see this leading to unwanted behavior. For instance, after saving a design, the user might want to undo some steps, but if the undo stack is cleared, then they cannot do that.
We might need a different way to detect unsaved changes besides using undo stack

I'm sure there is a "standard" logic to handle this. Maybe try searching around a bit and see what people recommend.


Zend\Db\Adapter\Driver\Pdo\Result Not using \PDO::FETCH_ASSOC in current() method

public function getById($id)
{
$stm = $this->db->createStatement('SELECT * FROM User WHERE id = ?');
$rowset = $stm->execute(array($id));
$row = $rowset->current();
}
current() is using FETCH_ARRAY instead of FETCH_ASSOC as it is supposed to be

Did you check the test suite? Maybe that's the expected behavior...

Can I force it to be \PDO::FETCH_ASSOC in current() call or elsewhere?

Marking as awaiting author updates: please check the test suite first.

\PDO::FETCH_ASSOC is hardcoded in Zend\Db\Adapter\Driver\Pdo\Result line 119:
$this->currentData = $this->resource->fetch(\PDO::FETCH_ASSOC);

It should be impossible not to use \PDO::FETCH_ASSOC.
@Ocramius:
The test suite only contains a single test for current(), that's all: ZendTest\Db\Adapter\Driver\Pdo\ResultTest

That is why I am surprised because it is hardcoded. But it happens to me with the code I posted, it seems that it is using \PDO::FETCH_ARRAY. I cannot find a reason for that. I have attached an screenshot:

Your screenshot shows exactly what \PDO::FETCH_ASSOC should do. It shows an array with 5 named elements:

$row['id'] has value 5
$row['email'] has value<EMAIL_ADDRESS>$row['password'] has value 1234
etc.

What do you think var_dump($row); should display?

Yes. Sorry, I mean \PDO::FETCH_OBJ. I was confused because I was thinking on ASSOC as an object, but it clearly wasn't.
My confusion becomes because in a previous method current() returns to me an Object:
public function findAll()
{
$rowset = $this->db->query('SELECT * FROM User', Adapter::QUERY_MODE_EXECUTE);
    $users = new \ArrayObject();

    $count = $rowset->count();

    for ($i=0; $i < $count; $i++) {
        $row = $rowset->current();
        $user = new User($row->id, $row->email, $row->password, $row->role, $row->date);
        $users->append($user);
        $rowset->next();
    }

    return $users;
}

In this case I take an object using current. But they are different classes:

Zend\Db\Adapter\Driver\Pdo\Result
Zend\Db\ResultSet\ResultSet

The second one is using FETCH_OBJ.
So nothing more to say here, only it will be good if we could also use FETCH_OBJ in Zend\Db\Adapter\Driver\Pdo\Result for current() method.
Thank you.


Added personal course on Linkedin Learning

I recently worked on a course for Linkedin Learning on Chaos Engineering and thought I would add it here.

Thanks for your contribution 👍


Update default registry to Cellery Hub

Purpose

Update default registry to Cellery Hub

Goals

Update default registry to Cellery Hub

Approach

Update default registry to Cellery Hub

User stories

N/A

Release note

N/A

Documentation

N/A

Training

N/A

Certification

N/A

Marketing

N/A

Automation tests

Unit tests

N/A

Integration tests

N/A

Security checks

Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes
Ran FindSecurityBugs plugin and verified report? yes
Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes

Samples

N/A

Related PRs

N/A

Migrations (if applicable)

N/A

Test environment

N/A

Learning

N/A

Codecov Report

Merging #464 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #464   +/-   ##
=======================================
  Coverage   82.29%   82.29%
=======================================
  Files          29       29
  Lines         864      864
  Branches       65       65
=======================================
  Hits          711      711
  Misses        109      109
  Partials       44       44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fb36fa...a2d4db2. Read the comment docs.


feat: update dcl-crypto to @dcl/crypto->remove web3x

Had to install the peer deps here too,  ajv-keywords and ajv-errors, to avoid this hole headache with ajv and @dcl/crypto -> @dcl/schemas:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.317%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
365

Relevant Lines:
415

💛  - Coveralls


feat(testcomponent): add background prop to TestComponent

BREAKING CHANGE: The new background prop on TestComponent is mandatory

:tada: This PR is included in version 2.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[FEATURE] BlackJack game in react

Description
place the bet and win
Screenshots

Additional information
No response

@panwar8279 please assign it to me

Hi @abansal15 , I have assigned this task to you. Kindly complete your work within 10 days. Make sure you will make your game in react. Good luck!

@panwar8279 raised the pr can you please review it


chore: bdd-spring-1574266191 to 0.0.1

chore: Promote bdd-spring-1574266191 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[SPARK-30416][SQL] Log a warning for deprecated SQL config in set() and unset()

What changes were proposed in this pull request?

Put all deprecated SQL configs the map SQLConf.deprecatedSQLConfigs with extra info about when configs were deprecated and additional comments that explain why a config was deprecated, what an user can use instead of it. Here is the list of already deprecated configs:

spark.sql.hive.verifyPartitionPath
spark.sql.execution.pandas.respectSessionTimeZone
spark.sql.legacy.execution.pandas.groupedMap.assignColumnsByName
spark.sql.parquet.int64AsTimestampMillis
spark.sql.variable.substitute.depth
spark.sql.execution.arrow.enabled
spark.sql.execution.arrow.fallback.enabled

Output warning in set() and unset() about deprecated SQL configs

Why are the changes needed?
This should improve UX with Spark SQL and notify users about already deprecated SQL configs.
Does this PR introduce any user-facing change?
Yes, before:
spark-sql> set spark.sql.hive.verifyPartitionPath=true;
spark.sql.hive.verifyPartitionPath	true

After:
spark-sql> set spark.sql.hive.verifyPartitionPath=true;
20/01/03 21:28:17 WARN RuntimeConfig: The SQL config 'spark.sql.hive.verifyPartitionPath' has been deprecated in Spark v3.0.0 and may be removed in the future. This config is replaced by spark.files.ignoreMissingFiles.
spark.sql.hive.verifyPartitionPath	true

How was this patch tested?
Add new test which registers new log appender and catches all logging to check that set() and unset() log any warning.

Test build #116099 has started for PR 27092 at commit 722ddaa.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20891/
Test PASSed.

Test build #116099 has finished for PR 27092 at commit 722ddaa.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116099/
Test PASSed.

@HyukjinKwon Please, have a look at the PR.

@cloud-fan @maropu Please, have a look at the PR.

Test build #116164 has started for PR 27092 at commit f9a2dcd.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20956/
Test PASSed.

Test build #116164 has finished for PR 27092 at commit f9a2dcd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116164/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21082/
Test PASSed.

Test build #116292 has started for PR 27092 at commit e93f587.

Test build #116299 has started for PR 27092 at commit 496ca8c.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21090/
Test PASSed.

Test build #116292 has finished for PR 27092 at commit e93f587.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
  case class DeprecatedConfig(key: String, version: String, comment: String)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116292/
Test PASSed.

Test build #116299 has finished for PR 27092 at commit 496ca8c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116299/
Test PASSed.

@MaxGekk mind resolving conflicts?

Test build #116349 has started for PR 27092 at commit faf88e8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21140/
Test PASSed.

Test build #116349 has finished for PR 27092 at commit faf88e8.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116349/
Test FAILed.

jenkins, retest this, please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21162/
Test PASSed.

Test build #116371 has started for PR 27092 at commit faf88e8.

Test build #116371 has finished for PR 27092 at commit faf88e8.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116371/
Test FAILed.

@viirya, mind asking it again to the r sysadmin? It starts to fail again:
* checking CRAN incoming feasibility ...Error in .check_package_CRAN_incoming(pkgdir) :
  dims [product 24] do not match the length of object [0]
Execution halted

@viirya, mind asking it again to the r sysadmin? It starts to fail again:
* checking CRAN incoming feasibility ...Error in .check_package_CRAN_incoming(pkgdir) :
  dims [product 24] do not match the length of object [0]
Execution halted

Sure, just asked CRAN admin for help. :)

@HyukjinKwon Although I don't get reply, looks like it was fixed because I saw successful build from other PR.

retest this please

Test build #116416 has started for PR 27092 at commit faf88e8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/21205/
Test PASSed.

Test build #116416 has finished for PR 27092 at commit faf88e8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/116416/
Test PASSed.

Thanks, @viirya
Merged to master.


feat: export plugins

Adds plugins export for manual plugin registration in project

@astandrik, Hi! I think it's a bad idea to export types PluginObjectSettings, PluginObject inside Text plugin to a shared index.ts.
If you still want to do this, then let's change the name of the type: PluginObjectSettings -> PluginTextObjectSettings, PluginObject -> PluginTextObject.
And someday in a major version I will change the name in the file Text.tsx

@jhoncool yeah you right
fixed

@jhoncool
commited fixes in Readme and exports
check again plz


Deploy pangeo hubs from CI

Ref https://github.com/2i2c-org/pilot-hubs/issues/599

This one line commit is probably the single most misleading indication of complexity that 2i2c has pushed so far 😅

Congrats to everybody on another important step forward 🎉


xdebug doesn't work on windows with remote_host = host.docker.internal

I work on Windows 10 + docker desktop + Ubuntu WSL2 + WP Local Docker 2.8.0 + Xdebug 2.9.8
The debugger don't catch any breakpoint with the default configuration
docker-php-ext-xdebug.ini
xdebug.remote_enable = 0
xdebug.remote_autostart = 0
xdebug.remote_host = host.docker.internal
xdebug.profiler_enable = 0
xdebug.profiler_output_dir = /var/www/html/wordpress/

host
# Added by Docker Desktop
<IP_ADDRESS> host.docker.internal
<IP_ADDRESS> gateway.docker.internal
# To allow the same kube context to work on the host and the container:
<IP_ADDRESS> kubernetes.docker.internal
# End of section

Finally I found the solution here
I don't know if it is the better solution but with this configuration it work fine
xdebug.remote_enable = 1
xdebug.remote_autostart = 1
; MacOS only
;xdebug.remote_host = host.docker.internal
; otherwise should be ip address of the host machine because docker container cannot find the host by localhost
xdebug.remote_host = <IP_ADDRESS>
xdebug.profiler_enable = 0
xdebug.profiler_output_dir = /var/www/html/wordpress/

Maybe it should be added to the documentation.

I can confirm this solved my problem as well on Catalina.


DB connector registered twice

Because of a bug in the DSC all connectors have been registered with a random guid as id. With version > 6.0.0 they have their normal ids again. Now the connectors are registerd twice. E.g. the DB connector.
There should be an option to delete a connector manually in the Broker Admin UI.
Additionally there needs to be a concept of how to deal with connectors that do not exist any more but do not deregister themselves from the broker.

The reason could be that one of the DB connectors is coming from indexing.


Fix broken initialization of Firebase::Admin::Messaging::MulticastMessage

Hello.
I found a broken initialization of Firebase::Admin::Messaging::MulticastMessage. The class does not have topic method nor condition method.
I brought those descriptions from https://firebase.google.com/docs/reference/fcm/rest/v1/projects.messages.

Thanks for submitting this PR. Can I ask you to add a test to this Pull Request as well?

I added a quite minimum test to cover this fix. How about 2519fa7?

@ohbarye thanks for your contribution, this small test will do :)

I just issued a new release with this fix (0.3.1)

Thanks for your review and quick release!


First example in "Testing Flask Applications" doc fails

Expected Behavior
I am attempting to follow the example in http://flask.pocoo.org/docs/1.0/testing/
I expect to see all tests pass after these steps:
git clone https://github.com/pallets/flask.git
cd flask
git checkout 1.0.2
cd examples/tutorial
python3 -m venv venv
. venv/bin/activate
pip install -e .
pip install '.[test]'
pytest
pip install pytest
printf 'import os\nimport tempfile\n\nimport pytest\n\nfrom flaskr import flaskr\n' > tests/test_flaskr.py
pytest

Actual Behavior
Instead, the result of the final pytest call is:
======================= test session starts ========================
platform darwin -- Python 3.6.5, pytest-3.6.1, py-1.5.3, pluggy-0.6.0
rootdir: /Users/anthonyaylward/Documents/web-projects/flask/examples/tutorial, inifile: setup.cfg
collected 24 items / 1 errors

============================== ERRORS ==============================
______________ ERROR collecting tests/test_flaskr.py _______________
ImportError while importing test module '/Users/anthonyaylward/Documents/web-projects/flask/examples/tutorial/tests/test_flaskr.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/test_flaskr.py:6: in <module>
    from flaskr import flaskr
E   ImportError: cannot import name 'flaskr'
!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!
===================== 1 error in 0.52 seconds ======================

Environment

Python version: 3.6.5
Flask version: 1.0.2

The import statements are sufficient to reproduce the issue, so I don't think any other code is necessary for the example

For context, the import statements are from a code example in the section "The Testing Skeleton" of the article "Testing Flask Applications" at http://flask.pocoo.org/docs/1.0/testing/, which reads:

import os
import tempfile

import pytest

from flaskr import flaskr

@pytest.fixture
def client():
    db_fd, flaskr.app.config['DATABASE'] = tempfile.mkstemp()
    flaskr.app.config['TESTING'] = True
    client = flaskr.app.test_client()

    with flaskr.app.app_context():
        flaskr.init_db()

    yield client

    os.close(db_fd)
    os.unlink(flaskr.app.config['DATABASE'])

While it seems clear that this example test_flaskr.py is not compatible with the current version of the flaskr example, I am not sure how I need to change it to correct the error. If possible, I'd like to learn how to create a working test_flaskr.py so I can follow along with the testing article.

It seems that the testing doc is not updated with the new flaskr tutorial. In this case, I recommend you to use the old code before the doc is updated:
$ git checkout 0.12.4

You are welcome. Please close this issue.

Did an issue get created to update the tutorial?

The tutorial is up to date. Many pages in the docs, including this one, need updating. There's nothing wrong with what the page says, it just references an old code example.

If you'd like to create an issue or a PR, go for it!

Just reproduced the error. I will update the testing doc and create a pull request!


Can't create EC2 Node Templates from UI as Standard User on master

What kind of request is this:
bug
Steps to reproduce:

Install latest master-head Rancher
Create an standard user
Login as a standard user
Create an EC2 cloud credential
Try creating a node template

Result:
MissingParameter: The request must contain the parameter AWSAccessKeyId

Other details that may be helpful:
Can't reproduce on v2.5-head 87006de
Linode provider is working on master.
Environment information

Rancher version: master-head (02/24/2021) 465bb3b
Installation option: HA/Single

Dup of https://github.com/rancher/rancher/issues/31319. Closing this one


⚠ Secret Website 3 has degraded performance

In 2ab52a0, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 21399 ms

Resolved: Secret Website 3 performance has improved in d3aa811.


Support file uploads on file system component

This can be useful for uploading multiple files at once into S3 or similar.

@josevalim is this issue still available to start working on?

@josevalim is this tas still available to be worked on?

Yes, please!

Yes, please!

Thank you. Let me look into this


Endpoint is only available on fleetapi

Looks like they've removed the owner API for vehicles.
GET https://owner-api.teslamotors.com/api/1/vehicles json decode error: {"response":null,"error":"Endpoint is only available on fleetapi. Visit https://developer.tesla.com/docs for more info","error_description":""}
Energy calls still work on owner API.

As an alternative, the products call still works and gives a vehicle list.

Other discussion: https://github.com/teslamate-org/teslamate/issues/3629

Looks like it might only be the vehicles (list) call, as other vehicle calls work, e.g. vehicle data, honk.


Package libav-tools is not available

Attempting to build s2i-minimal-notebook and getting this:
Package libav-tools is not available, but is
| referred to by another package. This may mean that the package is missing, has been obsoleted, or is only available from another source However the following packages replace it:   ffmpeg  E: Package 'libav-tools' has no installation candidate Removing intermediate container 4c5f956fd32a error: build error: The command '/bin/sh -c apt-get update &&     apt-get install -y --no-install-recommends libav-tools rsync &&     apt-get clean &&     rm -rf /var/lib/apt/lists/*' returned a non-zero code: 100

Addressed in new version, but the whole repository/image has also been marked as obsolete with warning it should not be used. This should really have been done a long time ago, or even at the outset made clear was an example only and shouldn't have been used with anyone interested creating their own.


International 5.55 Hotfix opcodes

"ActorCast": "0x00a9",
"ActorControl": "0x01c8",
"ActorControlSelf": "0x035a",
"AddStatusEffect": "0x01e9",
"RequestUseAction": "0x02a2",
"RequestUseAction2": "0x02f6",
"SkillResultResponse01": "0x0283",
"SkillResultResponse08": "0x025b",
"SkillResultResponse16": "0x015d",
"SkillResultResponse24": "0x0091",
"SkillResultResponse32": "0x0169",

Confirmations appreciated.

Can confirm that these are what I was able to find also (minus AddStatusEffect as it wasn't part of my search)

Confirmed working

Working perfectly! Thanks for the post.

no issues here, thanks man

Feels like any buffs on self still weave poorly.

working :D

works for me, could you provide and further instructions for finding these additional to what's in the post? I'll be honest and say once I turn on use IPC type finder I have no idea what I'm looking for in the log... Would be great to understand this further so I can search for these on my own if need be. 😊

Works great for me

Thank you for the contribution!


could not init cloud provider "azure": error unmarshaling JSON: json: cannot u              nmarshal number into Go struct field Config.cloudProviderBackoff of type bool

Is this a request for help?:
---Yes
Is this an ISSUE or FEATURE REQUEST? (choose one):
---Issue
What version of acs-engine?:
---latest
Orchestrator and version (e.g. Kubernetes, DC/OS, Swarm)
K8S
What happened:
When deployed using ACS-Engine with 3 master and 4 agents with custom vnet we got below error when trying to start kubelet service
Oct 21 05:39:12 k8s-master-37491860-0 docker[1678]: Error: failed to run Kubelet              : could not init cloud provider "azure": error unmarshaling JSON: json: cannot u              nmarshal number into Go struct field Config.cloudProviderBackoff of type bool
From deploy.json:
"cloudProviderBackoff": {
"defaultValue": "",
"metadata": {
"description": "Enable cloudprovider backoff?"
},
"type": "string"
},
From:parameters.json:
"cloudProviderBackoff": {
"value": "false"
},
After furthering reading the source code from ACS-engine:
https://github.com/kubernetes/kubernetes/blob/master/pkg/cloudprovider/providers/azure/azure.go
It is defined as below:
CloudProviderBackoff bool json:"cloudProviderBackoff" yaml:"cloudProviderBackoff"
Not sure related or not found below
https://stackoverflow.com/questions/24480835/go-decoding-json-int-into-string
https://ethereum.stackexchange.com/questions/955/uncaught-error-could-not-decode-json-cannot-unmarshal-array-into-go-value-of
I found below template
https://github.com/Azure/acs-engine/blob/master/pkg/acsengine/transformtestfiles/k8s_master_upgrade_template.json
Is this working?

cc @jackfrancis


feat(icons): add peanut icons

closes #2318
What is the purpose of this pull request?

[x] New Icon

Description
Adds a peanut and a peanut-off icon, as per #2318  and #924
Icon use case
See #2318
Alternative icon designs
See #2318
Icon Design Checklist
Concept

[x] I have provided valid use cases for each icon.
[x] I have not added any a brand or logo icon.
[x] I have not used any hate symbols.
[x] I have not included any religious or political imagery.

Author, credits & license

[x] The icons are solely my own creation.

Naming

[x] I've read and followed the naming conventions
[x] I've named icons by what they are rather than their use case.
[x] I've provided meta JSON files in icons/[iconName].json.

Design

[x] I've read and followed the icon design guidelines
[x] I've made sure that the icons look sharp on low DPI displays.
[x] I've made sure that the icons look consistent with the icon set in size, optical volume and density.
[x] I've made sure that the icons are visually centered.
[x] I've correctly optimized all icons to three points of precision.

Before Submitting

[x] I've read the Contribution Guidelines.
[x] I've checked if there was an existing PR that solves the same issue.

Feels a little bulbous to me, can we somehow make it cuter?

Feels a little bulbous to me, can we somehow make it cuter?

Do you mean something like this by being less bulbous?

I purposefully kept it very geometric, I personally find the rounded version cuter, but to each its own, I guess. 😄

It remains a no from me, it feels not penutty enough for me.

Can you respond to my question in https://github.com/lucide-icons/lucide/pull/2340#issuecomment-2257707145 though?

It remains a no from me, it feels not penutty enough for me.

Can you respond to my question in https://github.com/lucide-icons/lucide/pull/2340#issuecomment-2257707145 though?

I don't know, it just doesn't look like a peanut.

Simple simple:

Open lucide studio


How to enable php-fpm

Describe the bug
How to enable php-fpm
Version

[ ] I have checked releases and the bug exists in the latest patch version of v1 or v2.
[x] v2
[ ] v1

Runners

[ ] GitHub Hosted
[ ] Self Hosted

Operating systems

PHP versions

To Reproduce

Expected behavior

Screenshots/Logs

Additional context

Are you willing to submit a PR?

Only cli is supported by the action, may I know your use-case for php-fpm and OS you are using.
On Ubuntu, for PHP 5.6 to PHP 7.4 you can add this step
- name: Add php-fpm
  env:
    version: ${{ matrix.php-versions }}
  run: |
    sudo apt-get install -y php$version-fpm
    sudo service php$version-fpm start

Thanks for the workaround! However it doesn't work with PHP 8.
In Bref we run PHP-FPM in some tests to test the behavior of the FastCGI proxy. Would enabling php-fpm be something that could be considered?
Thanks!

@mnapoli I will check that and get back to you.

php-fpm -v
PHP 8.0.0-dev (fpm-fcgi) (built: Oct  5 2020 01:06:08)
Copyright (c) The PHP Group
Zend Engine v4.0.0-dev, Copyright (c) Zend Technologies
    with Zend OPcache v8.0.0-dev, Copyright (c), by Zend Technologies

@mnapoli php-fpm with PHP 8.0 for now is installed by default and should be in PATH.
When PHP 8.0 is released as stable, the above workaround to install php-fpm will work for PHP 8.0 as well.

Thanks a lot!
Funnily enough, it seems php-fpm is already installed in other PHP versions, for example 7.4:
Run if [ "$version" != "8.0" ]; then sudo apt-get install -y php$version-fpm; fi
Reading package lists...
Building dependency tree...
Reading state information...
php7.4-fpm is already the newest version (7.4.10-1+ubuntu18.04.1+deb.sury.org+1).
0 upgraded, 0 newly installed, 0 to remove and 11 not upgraded.

But then when PHP tries to run php-fpm:
exec: php-fpm: not found

In case it helps here is the related build: https://github.com/brefphp/bref/pull/767/checks?check_run_id=1210149707
If you have any idea that could help, I'd love it :)

The apt package puts php-fpm binary in /usr/sbin.
You can add a line to copy it to /usr/bin which will be in PATH.
- name: Setup php-fpm
  if: matrix.php != '8.0'
  env:
    version: ${{ matrix.php }}
  run: |
    sudo apt-get install php$version-fpm
    sudo cp /usr/sbin/php-fpm$version /usr/bin/php-fpm # copy to /usr/bin
    sudo service php$version-fpm start
    sudo service php$version-fpm status
- name: Test php-fpm
  run: php-fpm -v

Test workflow - https://github.com/shivammathur/test-setup-php/actions/runs/289826117/workflow

@shivammathur Thanks

Thank you I got everything working now, that was really helpful!


Issue #67 Minishift integration test rewrites and grammar fixes

@robin-owen Seems to me it remained technically accurate, pulling it. Thank you for the help!


[BUG] Unable to get correct MaxIntervalCeiling in OnSubscriptionRequested for ICD

Reproduction steps
When using ReadHandler::ApplicationCallback to implement a custom strategy, you will not be able to get the MaxIntervalCeiling in OnSubscriptionRequested for ICD devices.
We only have GetReportingIntervals API and it get mMaxInterval but is overridden.
https://github.com/project-chip/connectedhomeip/blob/5224cec13d97a8746a8d1a9da70bc16a859d8ee7/src/app/ReadHandler.cpp#L744 https://github.com/project-chip/connectedhomeip/blob/5224cec13d97a8746a8d1a9da70bc16a859d8ee7/src/app/ReadHandler.cpp#L794
Bug prevalence
100%
GitHub hash of the SDK that was being used
5224cec13d97a8746a8d1a9da70bc16a859d8ee7
Platform
core
Platform Version(s)
No response
Anything else?
No response

@lpbeliveau-silabs

More details https://csamembers.slack.com/archives/C036A932BQ8/p1728399013259439

@yunhanw-google @mkardous-silabs @andy31415 I think we also need cherry-pick this commit to v1.4-branch.


How to get and control main camera?

Hi, I'm working on fake 3D and sprite stacks with GDevelop (Game engine with pixi as core)
I'm trying put some 3D object on canvas, just a cube to follow a 2D cube
I create a cube and put as child of 2D, but when I move a scene, the 3D camera stucks
I try create a new Camera() for renderer but when I update positions nothing happens
Imgur
this is possible?

Thanks for your time!
I'll try again


Don't get the project like yours Demo

I don't get after installation your project like your demo given in this repository.
What should I change? Please suggest me.

sdfsf'

You need to give more information to get assistance.

Closing due to inactivity


switch inherent as_{ref,mut} methods to std traits where possible

suggested by clippy, seems reasonable to me
this change is non-breaking

there's no point to this now that it's been implemented elsewhere


How to temporally agregate SI & TI values?

The README.md file suggests that maximum values of both per-frame SI & per-frame TI should be used to represent the overall SI & TI values of a scene. However, when I refer to ITU-T Rec. P.910 (07/22), clause 6.3.4 "Aggregation of SI/TI scores" claims that I should rather use the average to aggregate per-frame TI & SI scores.
So what temporal aggregation method is recommended in the end—taking the maximum per-frame value or averaging per-frame values?

The README actually is citing an old version of P.910. We recommended using averages as a better approximate for overall complexity, since the max is prone to outliers.
Some more background on aggregations here: Robitza, W., Rao Ramachandra Rao, R., Göring, S., & Raake, A. (2021). Impact of spatial and temporal information on video quality and compressibility. 2021 13th International Conference on Quality of Multimedia Experience, QoMEX 2021, 65–68.

Addressed in 35c83d6


Problem with steeaming

Hi i have a problem. When i try to stream through aniwatch it is stuck on this phase. Sometimes it streams normally but other time is just wont stream.

Update to latest nightly


COB not decayed at all after rig just comes into pump range

one of my rigs just got in range of the pump and calculated COB way wrong (didn't decay it at all) and started over-SMB'ing... i shut it off and did a temp target and avoided a low, but how do i figure out what went wrong - what data do we need from the rig? (it is still off - i can turn it back on and stop the cron and copy files off...)

just to be sure, I re-installed oref0 0.5.2 (from scratch, and also setup from scratch - i.e., removed old src/oref0 and myopenaps dirs) on this rig and as soon as the loop started again it did a similar errant SMB microbolus based on an undecayed COB (total of all carbs consumed 3-5 hours prior).  this time we were in a better BG and the microbolus was smaller so i let it go.  the next loop had the correct COB (0).  so it appears this only affects the first successful loop (either after install or after pump comes into range from being out of range for a long time).

I've seen the "lack of data" affecting oref1 in this way too, although slightly different circumstances. I had intermittent phone signal and 45 mins of no SGV readings resulted in a data gap followed by a repetition of the COB that had been present before before the signal dropped.
There was an SMB on that calculation, but the COB were decayed within 3 SGV readings.
Mine occurred from data entered into NS. @Tynbendad was yours from NS or the pump bolus wizard?

All our carbs are entered via pump bolus wizard.

Mine were from Nightscout. It suggests that when there isn't a a gap in data collection, the first time that the carbs are pulled after the gap, it uses the full extent of carb history and rather than interpolating a decay based on time and the carb absorption rate in preferences.json it uses the full value. It then decays them based on time administered and a few glucose readings, getting back to where it should be between 15 mins and an hour after repelling the data.
I think this is the same issue as when I've been seeing the zombie carbs, as it nearly always occurs when I get home after work, and the home rigs pick up the pump for the first time since I left that morning, then use the carb data from nightscout undecayed.

Sorry - that should be "when there is a gap in data collection"

i see this... mealCOB was 0 on other rigs {"carbs":68,"boluses":0,"mealCOB":68,"currentDeviation":null,"maxDeviation":0,"minDeviationSlope":0}
here is around same time on other rig:
{"carbs":68,"boluses":10,"mealCOB":0,"currentDeviation":6.2,"maxDeviation":6.64,"minDeviationSlope":-0.26}
note the "null" on bad rig
i only find currentDeviation in a few places in oref0 source... autosense mainly - going to try to turn that off on the bedroom rig (where i've been seeing this a lot).

#589 may help with this
the Deviation stuff is used by UAM in this case, not autosens.  It looks like certain scenarios result in insufficient data to calculate it properly, so for now the safest thing to do is just set mealCOB=0 when that happens.

Please re-test with the latest dev branch and close this issue if fixed or update it if not.

i've been testing with this on dev branch on all my rigs and things are going ok, although i haven't specifically seen the issue, its likely happened & been dealt with properly without my noticing.
am closing issue - thanks!


Build from Source on Visual Studio 2019 v16.5.4 Error MSB8036 (Windows SDK not found)

Environment
Windows build number: 10.0.18363.778
PowerToys version: 0.16

Steps to reproduce
I cloned the repository and followed the instructions in the dev docs to build PowerToys.
Expected behavior
I have Visual Studio 2019 with the "Desktop Development with C++" component installed, so the runner should build without errors.
Actual behavior
I get the following two errors when building the solution:
1>------ Build started: Project: notifications, Configuration: Debug x64 ------
1>C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(777,5): error : The OutputPath property is not set for project 'notifications.vcxproj'.  Please check to make sure that you have specified a valid combination of Configuration and Platform for this project.  Configuration='Debug'  Platform='x64'.  This error may also appear if some other project is trying to follow a project-to-project reference to this project, this project has been unloaded or is not included in the solution, and the referencing project does not build using the same or an equivalent Configuration or Platform.
1>Done building project "notifications.vcxproj" -- FAILED.
2>------ Build started: Project: notifications_dll, Configuration: Debug x64 ------
2>M:\Projects\Repos\PowerToys-master\packages\Microsoft.Windows.CppWinRT.2.0.200117.5\build\native\Microsoft.Windows.CppWinRT.targets(109,9): error MSB8036: The Windows SDK version 10.0.17134.0 (or later) was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution".
2>Done building project "notifications.vcxproj" -- FAILED.

It seems to be a problem with the notifications project, but I can't tell how to fix it. The property page for the project has no output path specified and it also says the platform toolset (v142) isn't installed, although it definitely is.
Screenshots

Looks like those docs are out of date, you need Windows SDK installed.

Looks like those docs are out of date, you need Windows SDK installed.

I have the Windows SDK installed through Visual Studio. I also tried installing the SDK version mentioned in the error (10.0.17134.0) but the error persisted.

I solved the first error by setting Output = $(SolutionDir)$(Platform)$(Configuration)
Not sure it's correct, but I took example from other projects, and it removed the error.
Still fighting to get rid of the SDK error. I have a newer version (10.0.18362.0) than the one required (10.0.17134.0) installed, and I tried retargeting the project, but I still can not compile it...

Update: uninstalling the Windows SDK from add/remove programs and reinstalling it did the trick!

@yuyoyuppe can you check if there is anything that need to be done in the notifications project?

@enricogior $(SolutionDir)$(Platform)$(Configuration) is a default OutDir for vcxprojs, so we don't need to set it explicitly, we only do that when we need to override it with something else, e.g. in ImageResizerExt.vcxproj.
I'm guessing the empty $OutDir that @mousebyte experienced was caused by an error in some Imported system .props project, e.g. Microsoft.Cpp.Default.props or Microsoft.Windows.CppWinRT.props, due to corrupted/missing Windows SDK.

PR https://github.com/microsoft/PowerToys/pull/4013 should help fix this also to be sure everything is there.
You do need 17134 to best of my knowledge


Package size seems unreasonably big

The package install size of Razzle weighs 178MB:
https://packagephobia.now.sh/result?p=razzle
Seems mainly because of 20+ postcss related dependencies all around 1-2MB individually and rxjs adding 17MB.
Might be some opportunities to decrease this size.

@Siilwyn hello, maybe adding "sideEffects": false to package.json help you. this will help tree-shaking do its job better.
if you are using CSS or SASS in your project just specify them in sideEffects
"sideEffects": ["*.css"]

Hi @nimaa77 unfortunately that won't help since this is about the package install size. I've looked a bit more into this issue and looks like this size is caused by including dependencies for all plugins!

that's not that much big
if you fetch those packages once, they are going to be stored inside the yarn/npm cache storage on your local machine, if you are using CI/CD you have to enable cache between pipelines and in this way node_modules will be available between each step of CI/CD setup
sorry for my bad English :)

It's still a waste of space and 50+ MB packages really are uncommon.
Besides using Razzle in the context of serverless functions becomes harder since most cloud providers limit the size, e.g. AWS Lambdas can only be 50MB.

do you have any ideas about how we can fix this?

@nimaa77 I think somewhere a dependency of packages/razzle is requiring some example or maybe a devDependency down the line that in turn requires other dependencies?
Tried to look into it but got stuck since I can't seem to find out how the packages are published to replicate locally at least. Do you know more about this perhaps?

I don't know about the dependencies, but I think you can skip downloading dev dependencies with adding --production to install command:
npm install --production

one other thing that could be useful is that you can fork razzle and remove things you don't want and just deploy in inside Github Package Registry or just put the Github repo link into package.json

you can also watch for releases and get notified when a new version gets released so you don't miss anything

Does the size shrink if you bundle an app that uses razzle? I find this concerning, as I would like to push razzle into a lambda func for ssr.

As razzle has no runtime, you only need it in devDependencies, so it adds almost nothing to a production build.
I installed in a clean project here and got 139MB, majority from rxjs / jsdom / webpack:
 flightstats ✭ yarn why rxjs
yarn why v1.22.4
warning package.json: No license field
[1/4] 🤔  Why do we have the module "rxjs"...?
[2/4] 🚚  Initialising dependency graph...
warning No license field
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Reasons this module exists
   - "razzle#react-dev-utils#inquirer" depends on it
   - Hoisted from "razzle#react-dev-utils#inquirer#rxjs"
info Disk size without dependencies: "16.93MB"
info Disk size with unique dependencies: "16.98MB"
info Disk size with transitive dependencies: "16.98MB"
info Number of shared dependencies: 1
✨  Done in 0.71s.
 flightstats ✭ yarn why webpack
yarn why v1.22.4
warning package.json: No license field
[1/4] 🤔  Why do we have the module "webpack"...?
[2/4] 🚚  Initialising dependency graph...
warning No license field
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Reasons this module exists
   - "razzle" depends on it
   - Hoisted from "razzle#webpack"
info Disk size without dependencies: "2.82MB"
info Disk size with unique dependencies: "8.82MB"
info Disk size with transitive dependencies: "24.78MB"
info Number of shared dependencies: 98
✨  Done in 0.72s.
 flightstats ✭ yarn why jsdom
yarn why v1.22.4
warning package.json: No license field
[1/4] 🤔  Why do we have the module "jsdom"...?
[2/4] 🚚  Initialising dependency graph...
warning No license field
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Reasons this module exists
   - "razzle#jest#jest-cli#jest-config#jest-environment-jsdom" depends on it
   - Hoisted from "razzle#jest#jest-cli#jest-config#jest-environment-jsdom#jsdom"
info Disk size without dependencies: "5.18MB"
info Disk size with unique dependencies: "9.28MB"
info Disk size with transitive dependencies: "21.28MB"
info Number of shared dependencies: 43
✨  Done in 0.69s.

This size is only in dev, if you use razzle in a lambda you are adding the dependencies in the wrong way. The way we could get the size down is to make css support be a plugin. But I think a CRA alternative like razzle should do css by default. If the output bundle is big. That is another case. Closing


Update CAMARA Connectivity Insights API.yaml

Fixes #6
What type of PR is this?
Add one of the following kinds:

bug

What this PR does / why we need it:
Corrects wrong shortname for API in basepath
Which issue(s) this PR fixes:
Fixes #6
Special notes for reviewers:
Changelog input
v0.1.1 Corrects wrong shortname for API in basepath

Additional documentation
This section can be blank.
docs

Several comments:

There is no need to align the API basepath with the mailing list acronym
Instead you should maybe even avoid an acronym if possible and think about a more developer friendly basePath
Please don't change the version number with every PR which will go into main branch. Use something like 0.1.0-wip until you do a release in the sub project (there is currently no release with has used 0.1.0 as API version number. If you wan't to distinct the current work in progress from the initial contribution then 0.2.0-wip could make sense

egarding the basepath: I can't find any guidance in API Design Guidelines regarding this - and several other APIs have these abbreviated ID's in their basepaths (/qod/ , /eds/, /ti/, /dvi/) .  I'm happy to change but would be good to get a consistent position across APIs - I don't recall it being discussed in Commonalities but can raise  a Discussion if not.

See my comment in the issue. There you find the good examples, you picked the bad ones :-)
The guidelines say:

URI with lowercase and hyphens. URIs must be "human readable" to facilitate identification of the offered resources. Lowercase words and hyphenation (kebab-case) help achieve this best practice. For example: /customer-segments

Thanks @hdamker , commit added to reflect 'connectivity-insights' as basepath.

@hdamker please can you confirm the new commit meets your requested changes..?

basepath changed to /connectivity-insights/
version change to 0.1.0-wip

Many thanks!

Superseded by PR 15

@Kevsy  I'm getting currently too many notifications from GitHub. Yes, the commit would have had met my request. Sorry that it is too late now and you had to solve it with a new PR.

@hdamker understood, and no problem at all! Thanks for the good feedback :)


is.mobile()

There are numerous portable devices that are available in the market today, each designed to serve a different purpose. Here is a list of some common portable devices:
Smartphones
Tablets
Laptops
Smartwatches
Portable speakers
Headphones
E-readers
Portable gaming consoles
Portable hard drives
Digital cameras
Fitness trackers
Portable power banks
Handheld GPS devices
Portable DVD players
Handheld gaming devices
Smart home assistants (e.g., Amazon Echo, Google Home)
Portable projectors
Portable air purifiers
Portable document scanners
Portable printers.
This is by no means an exhaustive list, as there are many more portable devices available in the market today, and new ones are being developed all the time.


[SERV-423] Update logging and dependencies (security fix)

Add YMD to logging output
Add ability to configure logging TZ
Update project's dependencies (security fix)
Update parent project
Add logging file to container (not just console)
Eclipse made an if/else cleanup/simplification

The format of the timestamp here looks good. Although, I'm seeing a bunch of output from logback that look like errors, starting here.

I believe this one is ready for re-review too now.


Improve PagerDuty templating

WIP on some nits.
@brian-brazil thoughts on that as a default level of information?
This stuff a string list of alerts into a single field. Having full JSON objects might be an option too. But more complicated and not generally supported by clients (e.g. OpsGenie).

OpsGenie does support a JSON map for details (up to 8k chars long) - see details param documented at https://www.opsgenie.com/docs/web-api/alert-api#createAlertRequest

@jimmidyson good to know about the limit, thanks.

Added configurable resolve timeout.

:+1:


Achievement details & unlock rate

Hi,
I have this for example:
steam.apps.get_app_details("504230", filters="achievements")

And it returns this:
{
   "504230":{
      "success":true,
      "data":{
         "achievements":{
            "total":32,
            "highlighted":[
               {
                  "name":"Celeste",
                  "path":"https://cdn.akamai.steamstatic.com/steamcommunity/public/images/apps/504230/f8563120e18b88ff7e31b03ff6fcb61c5553b1ac.jpg"
               },
               {
                  "name":"Forsaken",
                  "path":"https://cdn.akamai.steamstatic.com/steamcommunity/public/images/apps/504230/6d16bf0629b862295a62b2d92ab22a94dc593903.jpg"
               },
               {
                  "name":"Archaeology",
                  "path":"https://cdn.akamai.steamstatic.com/steamcommunity/public/images/apps/504230/7544829d732b63de52eb0e68c796a68e8153c26f.jpg"
               },
               {
                  "name":"Checking Out",
                  "path":"https://cdn.akamai.steamstatic.com/steamcommunity/public/images/apps/504230/7e202a373754eac26194d75d6ba82e7fcc48ea42.jpg"
               },
               {
                  "name":"Breathe",
                  "path":"https://cdn.akamai.steamstatic.com/steamcommunity/public/images/apps/504230/fc3f2ae7d42ce92886c166aff6e9868b6dd9c518.jpg"
               },
               {
                  "name":"In the Mirror",
                  "path":"https://cdn.akamai.steamstatic.com/steamcommunity/public/images/apps/504230/902474b484af5d94aeaa22d74e3559c47e94beec.jpg"
               },
               {
                  "name":"Reflection",
                  "path":"https://cdn.akamai.steamstatic.com/steamcommunity/public/images/apps/504230/82f006e8c91ec81c8af98f7e5c59ad2ea1f8b0b1.jpg"
               },
               {
                  "name":"Strawberry Badge",
                  "path":"https://cdn.akamai.steamstatic.com/steamcommunity/public/images/apps/504230/64cffde21bf6fba1d3749e751a5772765f95357c.jpg"
               },
               {
                  "name":"Strawberry Medal",
                  "path":"https://cdn.akamai.steamstatic.com/steamcommunity/public/images/apps/504230/0e3b7b3e990ea0e212df36054e31521d29da21ca.jpg"
               },
               {
                  "name":"Impress Your Friends",
                  "path":"https://cdn.akamai.steamstatic.com/steamcommunity/public/images/apps/504230/9b043fec21f1028d306f0908b401c86d8869c334.jpg"
               }
            ]
         }
      }
   }
}

Is it possible to add these things:

Achievement Details
Global Unlock Rate
apiName?

With apiName I mean the following, it returns this when I check for example:
user_achievements = steam.apps.get_user_achievements("redacted", "504230")

Returns:
{
   "playerstats":{
      "steamID":"redacted",
      "gameName":"Celeste",
      "achievements":[
         {
            "apiname":"CH7",
            "achieved":1,
            "unlocktime":1710068747
         },
         {
            "apiname":"CH1",
            "achieved":1,
            "unlocktime":1709924417
         },
         {
            "apiname":"CH2",
            "achieved":1,
            "unlocktime":1709925745
         },
         {
            "apiname":"CH3",
            "achieved":1,
            "unlocktime":1709935466
         },
         {
            "apiname":"CH4",
            "achieved":1,
            "unlocktime":1709984637
         },
         {
            "apiname":"CH5",
            "achieved":1,
            "unlocktime":1710006604
         },

But because the apiname isnt in the get_app_details I can't check these values to see which name / details belong to which unlocked achievement.
Also how come it only shows 9 achievements and not all the 32?
Thank you very much in advance.

Will take a look at this over the weekend! Vacation at the moment

Will take a look at this over the weekend! Vacation at the moment

Cheers, maybe I'll try to do a pull request before the weekend.
Enjoy your holiday!

This is what I had in mind:
{
   "playerstats":{
      "steamID":"redacted",
      "gameName":"Celeste",
      "achievements":[
         {
            "apiname":"CH6",
            "name":"Reflection",
            "details":"Complete Chapter 6"
            "unlocked_by":"6.434321%"
            "image": https://cdn.akamai.steamstatic.com/steamcommunity/public/images/apps/504230/82f006e8c91ec81c8af98f7e5c59ad2ea1f8b0b1.jpg"
            "achieved":1,
            "unlocktime":1710068747
         },

@zeroquinc Hey wow ya I got a PR and asked for updates. Will make updates to this and get a release out tomorrow!

@zeroquinc Hey wow ya I got a PR and asked for updates. Will make updates to this and get a release out tomorrow!

Thanks, in the meanwhile I created my own API translation for my project to see if it worked, and if you pass the "l" parameter you get the achievement details, only not the ones that are hidden, so that kinda sucks.
https://github.com/zeroquinc/Steamcord/blob/main/api/game.py
I kinda fixed that by scraping "completionists.me" website once and save the descriptions to a json.
https://github.com/zeroquinc/Steamcord/blob/main/src/steam/functions.py

@zeroquinc issue will be closed! In the new release


Add packages 'componentm' and 'componentm-devel' to nightly

Checklist:

[X] Meaningful commit message - please not Update build-constraints.yml

[X] At least 30 minutes have passed since Hackage upload

[X] On your own machine, in a new directory, you have successfully run the following set of commands (replace $package with the name of the package that is submitted, $version is the version of the package you want to get into Stackage):
stack unpack $package-$version
cd $package-$version
stack init --resolver nightly
stack build --resolver nightly --haddock --test --bench --no-run-benchmarks

Thanks, merged


[Bug]: Playground runner sometimes crashes when example execution time out

What happened?
In case if example execution takes longer than a set time limit runner might crash when context exceeds it's deadline when runner performs cache access
Issue Priority
Priority: 2 (default / most bugs should be filed as P2)
Issue Components

[ ] Component: Python SDK
[ ] Component: Java SDK
[ ] Component: Go SDK
[ ] Component: Typescript SDK
[ ] Component: IO connector
[ ] Component: Beam examples
[X] Component: Beam playground
[ ] Component: Beam katas
[ ] Component: Website
[ ] Component: Spark Runner
[ ] Component: Flink Runner
[ ] Component: Samza Runner
[ ] Component: Twister2 Runner
[ ] Component: Hazelcast Jet Runner
[ ] Component: Google Cloud Dataflow Runner

.take-issue


Surface Hub: note for creating accounts using EAC

Description:
According to user feedback, using the Exchange Admin Center to create Surface Hub device user accounts requires on-premises Active Directory to synchronize from, for that method to work.
Change proposed:
Add a note saying

This method will only work if you have an on-premises Active Directory that you are syncing from.

directly below the header title of the second section.

Closes #3295

@DaniHalfin @lizap @jaimeo @Justinha @mjcaparas @greg-lindsay - Can anyone of you please assist to check, approve and merge the content of this PR based on issue #3295?
Thank you.

@illfated A question about the MD for Tips, Notes and Warnings: does it make a difference  if there is a space after the >. In other words: >does this render > differently to this?

@illfated A question about the MD for Tips, Notes and Warnings: does it make a difference if there is a space after the >. In other words: >does this render > differently to this?

Good question. I have not seen any difference on the docs.microsoft.com pages whether the space is there or not, but I assume it can be worth adding the space, just to be on the safe side.

@DaniHalfin @lizap @jaimeo @Justinha @mjcaparas @greg-lindsay - We would like to follow up on this. Can anyone of you please assist to check, approve and merge the content of this PR based on issue #3295?
Thank you.