Ack-handling part #2

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.34%. Comparing base (ddd9331) to head (c462b57).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   78.33%   82.34%   +4.01%
==========================================
  Files          14       13       -1
  Lines        1186     1229      +43
==========================================
+ Hits          929     1012      +83
+ Misses        257      217      -40

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests


Update @storybook/addons peer dependency

Fix for https://github.com/dump247/storybook-state/issues/21.
If there's anything you want me to tweak let me know. Thanks for making storybook-state!

I'd love to see this get fixed!

Sorry folks, but I'm going to close this PR. I've since transitioned to using CSF stories and using useState/useReducer React hooks instead. This addon doesn't seem like it's being maintained anymore and I would like to get this PR out of my pending queue.


Some questions with baselines

Your work is very good and effective. But I have some questions about the baseline approach. I tried different hyperparameters to adjust supervised contrastivelearning or  unsupervised contrastive learning to fine-tune BERT, and then to classify. But I've never been able to do anything better than just Cross-Entropy. I wonder what I didn't take into account? I've seen a lot of papers that contrastive learning can help improve classification results, but here I always get the opposite. Maybe I want to know the hyperparameters you set when you ran the comparison.

你好，我尝试使用作者代码，但是acc都稳定到50%，我想知道你是怎么进行训练的。

Hello, I tried to use author code, but ACC is stable to 50%, I want to know how you do the training.

Hello, I tried to use author code, but ACC is stable to 50%, I want to know how you do the training.

Hi，When I reproduced the experiment, I did not modify other parameters. Basically, I used the parameters given by the author, and only modified the size of batch_size. I can reproduce the author's results and get good results on my own dataset, you may need to recheck the parameters or download a new code to try it out.

Your work is very good and effective. But I have some questions about the baseline approach. I tried different hyperparameters to adjust supervised contrastivelearning or unsupervised contrastive learning to fine-tune BERT, and then to classify. But I've never been able to do anything better than just Cross-Entropy. I wonder what I didn't take into account? I've seen a lot of papers that contrastive learning can help improve classification results, but here I always get the opposite. Maybe I want to know the hyperparameters you set when you ran the comparison.

Hi, can you explicitly explain what your hyperparameters are when using supervised contrastive learning to fine tune the baseline? I get the same result with you. Thank you!


Variable hover should show stack frame offset in hex

Version and Platform (required):

Binary Ninja Version: 3.5.4335-dev Personal ( 3a1746b)
OS: Windows
OS Version: 10.0.25375.1
CPU Architecture: x64

Bug Description:
Hovering over a variable shows the stack frame offset in decimal. This is pretty weird and seems unintentional since stack frame offsets everywhere else in the UI are in hexadecimal.
Screenshots:

Should be fixed in 3.5.4340


CORS issue

Hi;
I am using ASP.Net Core 2.0 with ReactJS template and V2.1.0 of your library. The app bumps into CORS issue when redirecting to twitter. Here is the error message from the Chrome browser console:
localhost/:1 Failed to load https://api.twitter.com/oauth/authorize?oauth_token=: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'http://localhost:61825' is therefore not allowed access. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

I do not understand how a redirect ends up being caught with CORS.
From the contextual information you are providing it looks like you are trying to execute the WebRequest to access api.twitter.com from the frontend.
A redirection is a different thing and can be performed directly from the server side.

Here is my Home.tsx code:
import * as React from 'react'; import { RouteComponentProps } from 'react-router'; import TwitterLogin from 'react-twitter-auth'; import * as Models from '../Models'; interface UserState {     user: Models.User } export class Home extends React.Component<RouteComponentProps<{}>, UserState> {     constructor() {         super();         this.state = {user: null};         this.onFailed = this.onFailed.bind(this);         this.onSuccess = this.onSuccess.bind(this);     }     onSuccess = (response: any) => {         const token = response.headers.get('x-auth-token');         response.json().then((user: any) => {             if (token)                 this.setState({ user: user});         });     }     onFailed = (error: any) => {         alert(error);     }     handleAuthenticate() {         fetch('/Home/TwitterAuth', {                     method: 'GET',                     mode: "cors", // or without this line                     redirect: 'follow',                     headers: {                         'content-type': 'application/json'                     }                 })             .then(response => {                 if (response !== null && response.body !== null) {                     //console.log("response: " + JSON.stringify(response));                     //var user = response.json() as Promise<Models.User>;                     return response.json() as Promise<Models.User>;                 } else                     return null;                 //return (response.) ? response.json() as Promise<Models.User> : null             })             .then(data => {                 this.setState({ user: data });             }).catch(e => {                 console.log(e);                 return e;             });     }     logout = () => { this.setState({ user: null}); }     public render() {         let content = !!this.state.user && !!this.state.user.isAuthenticated ? (

Authenticated

{this.state.user.Email}

                     <button onClick={this.logout} className="button">Log out</button>

         ) : (
                     <button onClick={this.handleAuthenticate.bind(this)} className="button">Log In</button>
             );         return (

Welcome to React Twitter Application
                                  {content}
         );     } }

I am not sure how this is going to work with ReactJS. This is what I did:
(1) Home.tsx: Use clicks "Log In" button. The handler "fetch" from /Home/TwitterAuth which will reach the familiar TwitterAuth method in HomeController.cs. The method
(2) TwitterAuth does it's usual stuff and redirects to twitter page.
(3) Execution returns to fetch(). That's where CORS error happens.
Question:
I expect to return a User object from ValidateTwitterAuth method of HomeController to Home.tsx after the redirection but that never happens as it is stuck in the CORS error.

It is because you should not fetch /Home/TwitterAuth`. You should navigate to it (e.g. with an anchor tag).

Thanks. That solves the problem....

You do understand why CORS was being raised?

Not really.
On Feb 22, 2018 18:35, "linvi"<EMAIL_ADDRESS>wrote:

You do understand why CORS was being raised?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/linvi/tweetinvi/issues/654#issuecomment-367639353,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADsS--3EMuQKHY7B4VBKMBlgfSOgcypjks5tXULYgaJpZM4SNVZb
.

Your application was fetching an endpoint that was redirecting to api.twitter.com.
Obviously api.twitter.com will does not authorize your website domain (or localhost) to access it via CORS.
As a result api.twitter.com does not provide the CORS header required by chrome to authorize the fetch.
By using a navigation you are then directly accessing the Twitter website and as a result chrome no longer need to check for CORS as it is a simple url navigation.
I hope this helps :)
Have a great day.

That really helps. Thanks.

Do you have example with .Net Core 2.0 as server and ReactJS as client? I have a tough time getting this to work due to the redirection using anchor element. Specifically, how to pass the authenticated user object back to the view? I have tried the following:
       public ActionResult ValidateTwitterAuth()         {             User user = new NetCoreReactJSTwitter.User();             if (Request.Query.ContainsKey("oauth_verifier") && Request.Query.ContainsKey("authorization_id"))             {                 var verifierCode = Request.Query["oauth_verifier"];                 var authorizationId = Request.Query["authorization_id"];                 var userCreds = AuthFlow.CreateCredentialsFromVerifierCode(verifierCode, authorizationId);                 Auth.SetCredentials(userCreds);                 IAuthenticatedUser u = Tweetinvi.User.GetAuthenticatedUser(userCreds);                 user.isAuthenticated = true;                 user.Name = u.Name;                 user.Email = u.Email;                 user.ScreenName = u.ScreenName;             }             return LocalRedirect("/?user="+user.ToJson());         }
This will result in props.location.search having the query string parameter. This is more of a hack and I am not good in ReactJS.

Hello,
I do not have an example available for you and at the moment I need to focus on releasing version 2.2 before working on such example.
If you happen to make it work feel free to share the example here, potentially through a Pull Request.
Thanks,
Linvi


uORF -  stop codon variant

What is this request referring to?
A variant which lies in the stop codon of ORF in a 5' UTR.
(This is structured to be similar to SO:0001983)
What is the name you would like SO to give the term?
5_prime_UTR_uORF_stop_codon_variant
What is the definition that you would like for this term?
A 5' UTR variant where a  stop codon  in an upstream open reading frame is introduced, moved or lost.
Synonyms
Parent Term
5_prime_UTR_uORF_variant (#647 )
Relevant Publications
PMID: 32461616, Whiffin et al 2020
Characterising the loss-of-function impact of 5' untranslated region variants in 15,708 individuals. (Nature Communications)
PMID: 32926138, Zhang et al 2021
Annotating high-impact 5'untranslated region variants with the UTRannotator (Bioinformatics)

This is done. Changes should be reflected on sequenceontology.org in the next 24 hours. If you'd like to inspect the changes right away I'd recommend downloading Protégé and opening the ontology files with "File" > "Open from URL..." > and then entering this URL: https://raw.githubusercontent.com/The-Sequence-Ontology/SO-Ontologies/master/Ontology_Files/so.obo


Implemented saturation parameter for lightmaps [#85]

Scope & Features:

This PR implement a lightmap saturation control for the io3d-data3d aframe component
The changes allow the user to have full control over the look of their scene

Design:

The shader has been rewritten to use 'saturation' as a control mechanism for color bleeding in lightmaps
Grayscale conversion: used  ITU-R `(0.2125, 0.7154, 0.0721)´ (other option would be NTSC vec3(0.299, 0.587, 0.114)
Issue

How to use:

Set lightMapSaturation value from 0.0 (grayscale) to 1.0 (original) to 1.0+ (oversaturated) <a-entity io3d-data3d="key:/key.gz.data3d.buffer; lightMapSaturation: 0.0"></a-entity>
Changes do not affect users, fallback value is neutral

How to test:

Test (with a colorful scene) if saturation works as intended
Check if aframe sliders work as intended

Thanks

I'm on it. Code looks good!
I especially like that you are using weighted grayscale conversion instead of just using the mathematical RGB average in https://github.com/archilogic-com/3dio-js/pull/113/files#diff-4789112aae09f0bb59ea558bff779f98R168
Will give it some testing tomorrow.


Admin UI

It would be useful to have a dedicated Admin UI (eg. at localhost:8080/admin), similar to Django's admin site.
This page could contain links to existing types (eg. localhost:8080/admin/<type>) and provide an auto-generated interface for creating/list/get/edit/deleting items, or whichever actions are relevant for the specific type.
For instance, currently localhost:8080 has an interface that supports the following actions -

POST localhost:1317/<store>/<type>
GET localhost:1317/<store>/<type>

Whereas we could also provide UI support for the following actions

GET localhost:1317/<store>/<type>/<id>
PUT localhost:1317/<store>/<type>
DELETE localhost:1317/<store>/<type>

This is a good idea. We do need a SPI component that lists all the data available through API endpoints and shows this data in a table. Sort of like Vuex dev tools.


[Proposal] Support resubmit/retry on archived workflows

Summary
What change needs making?
Support resubmit/retry on archived workflows.
Use Cases
When would you use this?
Currently argo retry/resubmit only supports workflows resources that currently exist in the cluster. For clusters where workflows are GC-ed immediately after they are completed, it's not possible to retry/resubmit a workflow. There are workaound for this, e.g. saving the workflow resource manually either as a plain YAML or into archived workflow before we GC it, and then do a kubectl create before we use argo retry/resubmit. It would be better and less hacky if we have a CLI for this.
API/Implementation Discussion
We can implement this in one of the following ways:

argo retry/resubmit wf-name --from-archive
argo archive retry/resubmit
argo retry/resubmit --source=location-to-saved-wf.yaml

Any preference?

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

We should also provide this feature in the UI.

I will take this issue

Wow this got popular. 👍🏻 @dpadhiar assigned to you.


#1524: fill in missing shrink and canonicals methods

This one's pretty big, but is mostly all the same thing: going through most of the Generators and adding canonicals() and shrink().  It's a huge amount of code, nearly all of it in Generator and GeneratorSpec.
Broadly speaking, I've tried to keep to the same patterns as the existing implementations.  In particular, the numeric implementations all look pretty similar, and the collection implementations all look pretty similar.  To enforce this, I refactored a couple of methods out on the test side.
With 20/20 hindsight, I don't actually love the way this came out: there is way too much duplicate code in the shrink() implementations.  I think that there is a common typeclass desperately fighting to emerge for the Scalactic anyval types -- coming up with a single common implementation of shrink() would be a great way to guide what that might look like.  But that didn't occur to me until I was halfway through, and realized just how many of these types there really are.

This is probably the way it worked before, but I noticed our "strategery" algo is doing this:
scala> it.toList
res11: List[List[Int]] = List(List(), List(0), List(1), List(-1), List(2), List(-2), List(3), List(-3), List(100), List(100), List(100), List(100), List(100), List(100), List(100), List(100), List(100), List(100), List(100), List(100), List(100), List(100), List(100), List(100), List(100), List(100), List(100), List(100), List(100, 100), List(100, 100, 100, 100), List(100, 100, 100, 100, 100, 100, 100, 100), List(100, 100, 100, 100, 100, 100, 100, 100, 100, 100, 100, 100, 100, 100, 100, 100))

It repeats List(100) a bunch of times.

Hmm.  Annoying, and underlines why we need to get better about factoring this stuff properly.  I tried to factor the test code to reduce duplication, but didn't have time to think about how to refactor the collection shrink() implementations.  I'd recommend figuring out this bug, but instead of fixing it individually for each type (since I expect the same issue to show up for each collection type), instead refactoring those methods and fixing it once...


[Angular] Knobs do not update preview for class-specified components when changeDetectionStrategy is set to OnPush

Describe the bug
When a component is class-specified, and that component has its change detection strategy set to OnPush (see "additional context" below), the user is unable to manipulate the component's inputs using the knobs add-on.
(I believe this issue is almost certainly due to angular/angular#14087, but I think there are ways we can work around it, such as manually triggering change detection when a knob is changed.)
[Clarification: By 'class-specified', I mean that the component is specified in the story definition using component: MyComponent (referencing the component's class directly) rather than template: <my-component></my-component> (referencing the component in a template via its selector).]
To Reproduce
Steps to reproduce the behavior:

Find any story for a class-specified component that uses knobs (here's one in the examples in this repo)
Goto its component definition (here's the one referred to in the above example)
In its @Component decorator, add the following the the component metadata object: changeDetection: ChangeDetectionStrategy.OnPush
Run or refresh Storybook
Try to manipulate the input for the above story, and notice that the component is unresponsive.

Expected behavior
I expect that the component should preview should be updated using knobs, even when the component's change detection strategy is set to OnPush.
Additional context
"OnPush" change detection one of two change detection strategies used in Angular (the other being ("Default"), ensuring that change detection is essentially only run when the inputs are changed, which can be a major benefit for performance. (Read more about it here if you're interested.)

Solved by #6360

Yo-ho-ho!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.21 containing PR #6360 that references this issue. Upgrade today to try it out!
Because it's a pre-release you can find it on the @next NPM tag.


[Mysql]: Added defaultCurrentTimestamp and onUpdateCurrentTimestamp to datetime

The changes were made in date.common.ts due to the code that can be shared between timestamp and datetime data types in Mysql.

The method defaultNow() has been deprecated in favor of defaultCurrentTimestamp
The method onUpdateNow() has been deprecated in favor of onUpdateCurrentTimestamp
An additional fsp config parameter was added to MysqlDateColumnBaseConfig class. This will be helpful for Drizzle-kit to be able to add to correct fsp configuration to ON UPDATE. See here
No tests were added. The methods in this PR are only usable by drizzle-kit migration generation.

Users can now use the these methods in their schema definition as follows:
export const users = mysqlTable(
  "users",
  {
    id: char("id", { length: 26 }).primaryKey().notNull(),
    username: varchar("username", { length: 191 }).notNull(),
    createdAt: datetime("createdAt", { mode: "date", fsp: 3})
      .defaultCurrentTimestamp(),
    updatedAt: datetime("updatedAt", {mode: "date", fsp: 3})
      .defaultCurrentTimestamp()
      .onUpdateCurrentTimestamp(),
  },
);

This PR will close #596 and #921

this needs merging :(

When will this be released? And will the functions accept and FSP param?

@Angelelz I guess this PR should be merged to beta branch instead of main.
@AndriiSherman can you check this out and ensure it is added to the next release? It seems almost finished. :D

This PR will probably also close #624.

Need merge.

any updates on merging this PR? looks really useful and checks on it are passing

I was about to open an issue regarding this exact thing. This implementation reflects a widespread common declaration pattern when implementing timestamp fields. I would like to urge a merge at the earliest possible convenience.

well all changes seem approved and checks are passing let's hope they merge it soon! @aretrace


[baremetal] Add a callback for platform faults in platform_util.c

This PR adds a new define that controlls a callback function, called when encountering a failure in platform_util.c - memcpy and memset.

Rebased to resolve conflicts.

Tests passed.


Check if password is ascii

Closes #2517

Passwords can be arbitrary utf8
https://github.com/FAForever/server/blob/2f39b9785726f6659c49fd26c559354cbcc4f607/server/lobbyconnection.py#L979

That was quick, thanks!


Error "Failed to resolve import "ohmyfetch"" after upgrade to Nuxt 3.1.0

Version
module: 1.5.0
nuxt: 3.1.0
Nuxt configuration

Reproduction
https://stackblitz.com/edit/nuxt-starter-kfrrf1
What is expected?
Nuxt with the sanity module starts without problems.
What is actually happening?
ERROR  Failed to resolve import "ohmyfetch" from "node_modules/@nuxtjs/sanity/dist/runtime/client.mjs?v=451a1d82". Does the file exist?

Steps to reproduce
npm run dev
Additional information
The only thing I added is using useSanityQuery in app.vue and then the error appears.
Checklist

[x]  I have tested with the latest Nuxt version and the issue still occurs
[x]  I have tested with the latest module version and the issue still occurs
[x]  I have searched the issue tracker and this issue hasn't been reported yet

Thanks for your quick spot! This should be resolved in v1.6.0.

Thank you for fixing it so quickly! 😃


Open user popover when you click on a name in the buddy menu.

See the discussion here:
https://chat.zulip.org/#narrow/stream/design/subject/click.20on.20right.20sidebar/near/307059
The current behavior when you click on a name in the buddy list is to narrow to messages that you've had with that person.  That can be surprising/disorienting to users.  Instead, it might make sense to just show the user popover, which gives more options, at the expense of an extra click if you want to narrow.
This should be a fairly easy fix, but you should be prepared for some iteration on this--we might try it out and decide to go back to the old behavior.

@zulipbot claim , I've have some idea about how these things works, so I would like to work on this.

@shubhamdhama You may want to discuss this on chat quickly, just so you don't too far down the wrong path.
You can join the conversation here:
https://chat.zulip.org/#narrow/stream/design/subject/click.20on.20right.20sidebar/near/307059

still working, waiting for the review

@zulipbot claim

I think we determined that this isn't actually a change we want to make, after deploying it in production, because the "compose PM + narrow" behavior is too useful.  So I'm closing this.


[WIP ] Chart improvements

@vgeorge Please check the comment about the popover numbers: https://github.com/developmentseed/gep-explorer/issues/84#issuecomment-448615895

Looks very good. I'll handle number formating in another PR.


[EMB-6] Un-foo guid routing

Purpose
Fix guid routing, which got messed up while responding to review.
Summary of Changes
Remove an orphan foo.
Side Effects / Testing Notes
Guid routing (and the zoom-to-guid button) should work now.
Ticket
https://openscience.atlassian.net/browse/EMB-6
Reviewer Checklist

[ ] meets requirements
[ ] easy to understand
[ ] DRY
[ ] testable and includes test(s)
[ ] changes described in CHANGELOG.md

Coverage remained the same at 29.25% when pulling 320ff6497645417a7cc55deb1144075dc2664e7c on aaxelb:emb-6--foo into e9aa66d27094b7e29dc6be29258c063311ad9d9b on CenterForOpenScience:develop.


SSIS in VS2022 pre contact

Learn Build status updates of commit 592ac5a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/ssdt/release-notes-ssdt-2019.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 1a46b9b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/ssdt/release-notes-ssdt-2019.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 3bc3711:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/ssdt/release-notes-ssdt-2019.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@yewanxuan
Thank you for your contribution. Would you take a moment to sign the Contributor License Agreement (CLA)?
After the CLA is signed, someone can review your pull request. Thanks!

Learn Build status updates of commit 5162cbf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/ssdt/release-notes-ssdt-2019.md
:white_check_mark:Succeeded

docs/ssdt/release-notes-ssis-2022.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 24d0ef7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/ssdt/release-notes-ssdt-2019.md
:white_check_mark:Succeeded

docs/ssdt/release-notes-ssis-2022.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit ddba62e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/ssdt/release-notes-ssdt-2019.md
:white_check_mark:Succeeded

docs/ssdt/release-notes-ssis-2022.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 4052a7f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/ssdt/release-notes-ssdt-2019.md
:white_check_mark:Succeeded

docs/ssdt/release-notes-ssis-2022.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 3f8dee3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/ssdt/release-notes-ssdt-2019.md
:white_check_mark:Succeeded

docs/ssdt/release-notes-ssis-2022.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 70b9660:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/ssdt/release-notes-ssdt-2019.md
:white_check_mark:Succeeded

docs/ssdt/release-notes-ssis-2022.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@microsoft-github-policy-service agree [company="microsoft"]

@microsoft-github-policy-service agree

Learn Build status updates of commit 15d5414:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/ssdt/release-notes-ssdt-2019.md
:white_check_mark:Succeeded

docs/ssdt/release-notes-ssis-2022.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

Learn Build status updates of commit 86300dd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/ssdt/release-notes-ssdt-2019.md
:white_check_mark:Succeeded

docs/ssdt/release-notes-ssis-2022.md
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

#sign-off

Hi @chugagrace,
The changes made in this PR are extensive enough that they'll need to be moved to the private repo for staging and other checks.
Let us know if you'd like assistance with opening a PR in the private repo.
Thanks!
#hold-off

Hi @chugagrace,
The changes made in this PR are extensive enough that they'll need to be moved to the private repo for staging and other checks.
Let us know if you'd like assistance with opening a PR in the private repo.
Thanks! #hold-off

Hi, @Court72. Need your help. My Microsoft GitHub can't access in due to 2step verify. I lost recover code and my phone. Could you take a look at it, and give advice how to resolve?

Closing this PR since the changes have been made in the private repo.


feat(JOML): migrate AudioManager

Should be merged together with https://github.com/Terasology/Behaviors/pull/50 otherwise omega won't compile.


Add Cedar House

@emma-alexandria Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Unable to create my own TopHitsAggregate when unit testing

NEST/Elasticsearch.Net 6.5.1:
Cannot create my own TopHitsAggregate to return as a mock result for my unit tests:
Steps to reproduce:
Hi,
I'm trying to setup IElasticClient.SearchAsync to return my own AggregateDictionary for my unit tests. While I am able to do it for TermsAggregate, TopHitsAggregate is looking difficult.
`
public static class AggregateDictionaryHelper
{
    // Following method work well for my terms aggregate
    public static AggregateDictionary CreateWithTerms<T>(string aggregationKey,
        Dictionary<T, long> keyDocCountDict)
    {
        Dictionary<string, IAggregate> aggregateDict = new Dictionary<string, IAggregate>
        {
            [aggregationKey] = new BucketAggregate
            {
                Items = keyDocCountDict.Select(x =>
                    new KeyedBucket<T>(new Dictionary<string, IAggregate>()) {Key = x.Key, DocCount = x.Value}
                ).ToList()
            }
        };

        return new AggregateDictionary(aggregateDict);
    }

    // This is the method I'm trying to write
    public static AggregateDictionary CreateWithTopHits<TKey, TItem>(string termsAggregationKey,
        string topHitsAggregationKey, Dictionary<TKey, IEnumerable<TItem>> termsTopHitsDict)
    {
        Dictionary<string, IAggregate> termsAggregateDict = new Dictionary<string, IAggregate>
        {
            [termsAggregationKey] = new BucketAggregate
            {
                Items = termsTopHitsDict.Select(x =>
                    {
                        TopHitsAggregate topHitsAggregate = new MockTopHitsAggregate<TItem>(x.Value);

                        Dictionary<string, IAggregate> topHitsAggregateDict = new Dictionary<string, IAggregate>
                        {
                            [topHitsAggregationKey] = topHitsAggregate
                        };

                        return new KeyedBucket<TKey>(topHitsAggregateDict)
                        {
                            Key = x.Key,
                        };
                    })
                    .ToList()
            }
        };
        return new AggregateDictionary(termsAggregateDict);
    }
}

public class MockTopHitsAggregate<T> : TopHitsAggregate
{
    private readonly IEnumerable<T> _items;

    public MockTopHitsAggregate(IEnumerable<T> items)
    {
        _items = items;
    }

    public override IReadOnlyCollection<TDocument> Documents<TDocument>() where TDocument : class
    {
        if (typeof(TDocument) is T)
        {
            return (_items as IEnumerable<TDocument>).ToList().AsReadOnly();
        }

        return null;
    }
}

`
The method I'm trying to override in TopHitsAggregate class is not virtual, so I'm not allowed to do this. I'm wondering if there is another way to create my TopHitsAggregate. If not, is it sane to request for this method to be made virtual?
Thanks

Hi @kanup,
We have generally steered folks away from this this kind of stubbing/mocking of the client; For example, what is your mock trying to assert or do? It looks like it's trying to provide stubbed top hits for another system under test?
Some ways you may want to handle this:

Encapsulate client usage in your in own types which you can mock/stub
Use InMemoryConnection and return a specific response for a given request. Take a look at this GitHub issue as an example
Use Elastic.Xunit and projects to spin up a cluster as part of your tests. Granted that these will now be integration tests. These can be referenced from our AppVeyor package feed at https://ci.appveyor.com/nuget/elasticsearch-net-abstractions which you can reference by adding to Package Sources.

A combination of approaches may be useful.

I'm going to close this issue; I've provided some other approaches to consider.

We could have some logic that simply processes NEST query results. And having all those proposed "dances" to just Unit-test it is no so fun, actually.


Lossless image optimization

Run optipng -o7 across (subsets of) website PNG images to make lossless savings in image sizes.
Similar to the intent of PR #18971; this one comes with a signed CLA and a merge-able set of commits.
Aside: :bulb: if anyone ever wants to, we could lint to check that (modified) images are within n% of being optimized.

size/XS huh? :smile:

/remove-area blog
Some blog changes snuck in when I didn't want them to.
(I hope this is correct and possible)

in nowadays bandwidths of 100s of megabits, these types of optimizations stripping a few kilogbytes may be quite negligible. i think the overall reduction here is near 500kb or less.
but if this was already discussed already it seems fine.

It's not going to make much different to page load time. OTOH it didn't take long to PR this either.

@sftim , Are these changes the same as PR #18971? Or, possibly generated using a different tool?

Roughly the same aim but a different tool.

@sftim, I would think that this type of change should be agreed upon by the docs group (discussed  during docs weekly meeting or mentioned in docs agenda)?
/hold

/cc @zacharysarah @jimangel @kbarnard10

Happy to see this discussed.

For now I'll close this. Easy enough to reopen.
/close


Docs/restructure

Description of change
Restructure the documentation to the new guidelines.
Links to any relevant issues
Type of change
Choose a type of change, and delete any options that are not relevant.

Documentation Fix

How the change has been tested
Local wiki setup, and I clicked through links.
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.

[X] I have followed the contribution guidelines for this project
[X] I have performed a self-review of my own code
[X] I have commented my code, particularly in hard-to-understand areas
[X] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have checked that new and existing unit tests pass locally with my changes

@lucas-tortora @Dr-Electron


Relax pytest-timeout version requirement

Usage syntax hasn't changed in newer versions.
The existing strict version requirement is making
packaging needlessly difficult.
The minimum version is being bumped because the first
major release of pytest-timeout requires pytest
2.8.0 or newer.

Seem comment here: https://github.com/getsentry/raven-python/pull/770#issuecomment-220146837


Add feature to append waveform properties to the channels if the acquisition is continuous

[x] This contribution adheres to CONTRIBUTING.md.

TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.
What does this Pull Request accomplish?
This PR adds the capability to store waveform properties in log files that are continuous (if the user chooses to do so in the configuration).
Why should this Pull Request be merged?
See User Story 1253604 for the full spec.
What testing has been done?
Manual tests and review

FYI: My edits also adds a non-PR comment related to how the Async communicates to the RT Driver VI, since it took quite some time for us to understand it and I think it's worth capturing in the diagram.
I also cleaned up the VIs I edited to implement the feature, but I did not change behavior/functions used (in case you see things moved around in the Diff)

@oscarfonloz it looks like Sample File Data.vi still has an action item?

There is a typo in the new control name on the file page (should be continuous), and the control description is wrong.

Good catch! I did implement the functionality there, just forgot to remove the comment.

There is a typo in the new control name on the file page (should be continuous), and the control description is wrong.

Thanks! It's a tricky word! haha

I still need to do some functional testing, but that will be a slow process due to power outages at my house.

I planned to do the documentation in a later PR, but since we're already here, I submitted a tip strip and description that we can change later.


Add ability to determine visibility of view containers (e.g. primary/secondary sidebar, panel)

Currently, the VS Code command await vscode.commands.executeCommand(viewId + ".focus", { preserveFocus }) reveals a view and also the corresponding view container (e.g. primary sidebar, panel) if it is hidden. This command is very useful for certain extensions like Data Wrangler, which leverages the webview view API to create user-customizable, native VS Code UI sections to augment the experience for a custom editor (where the webview views must be revealed when the editor is shown).
However, the problem is that once the custom editor is closed the view container that hosted the extension views is no longer needed but will remain visible. This can be a very frustrating experience for users, since they will need to manually close the sidebar or panel each time.
There is an API to close the sidebars and panel but as far as I know there is no way for an extension to figure out what the state was prior to revealing the view. It would be great if we could expose an API to fetch the current visibility state of the view containers, so that we can restore it back to the original state for users after we have revealed a webview view. Or even better yet, if there is some way to associate custom editors with webview views so that proper cleanup can happen accordingly on disposal.
Thanks!

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Broken Link on how-to-guides

Off-chain transactions link is broken. please update it.
https://docs.substrate.io/reference/how-to-guides/offchain-workers/offchain-transactions/

@UVvirus, this topic has been "promoted" to a full-fledged tutorial.

@lisa-parity Thank you for your quick response


Animated gif

Hi,
I am using imagemin as a plugin with gulp and tried to compress an animated gif but it failed. Does it support the particular format?
Thanks

This should discussed in https://github.com/kohler/gifsicle/issues rather than here.

@shinnn Thanks for your help. Finding the correct responsible repo for reporting it, was really confusing.


[JENKINS-58703]

PR build lacks disk space:

Exit code: 1 - OpenJDK 64-Bit Server VM warning: Insufficient space for shared memory file:
100672
Try using the -Djava.io.tmpdir= option to select an alternate temp location.


Fix for Android trampoline restriction

When targeting Android 31, we cannot use a Service to start an Activity. So instead of using PendingIntent to start a Service we start an Activity directly.
Old flow
Set PendingIntent for notification -> On press -> Start Service -> Start Activity if not visible
New flow
Set PendingIntent for notification -> On press -> Start Activity
We already subscribe to Activity lifecycle event like created and onNewIntent, we use this callbacks to fire notification opened to JS.
I have tested the basic cases and its working fine.
I want others to test against their cases and tell if Its working fine in those cases.

Any updates on this from maintainers? My team is encountering the same issue - thank you for submitting this change @ravirajn22, we're testing it now.

Have you gotten around to taking a look at this PR @DanielEliraz ? This is currently a major blocker in our application since we're targeting SDK 31 and at the moment all notifications are discarded when tapping them instead of opening the app, because of this.
@ravirajn22 have you considered forking this repo until the code owners have had time reviewing this PR?

@DanielEliraz Is this repo abandoned? This PR is fixing a major issue in the library, and w/o this fix our project need to check in to another solution.

I'm still having the issue :(
Tapping on android notification where application is in foreground doesn't pass the Intent through

Adding this version of firebase fixed the issue for us: https://github.com/republik/app/commit/2ca29d42d584520e6096d4f03326bb02e399935b

@ovbm Thanks for your help however it doesn't to change anything on my side.
Just to be sure that we are on the same bug:
Tapping a notification:

opens correctly when app is on background
opens correctly when app is quitted
opens by restarting the activity when app is on foreground

The activity doesn't seem to really restart entirely: SplashScreen appears but the navigation state is preserved.


[Discussion]: Statement on non-compliant TRE changes in configuration management section seems unnecessary

Summary
Unclear on the purpose of a statement in the Configuration Management section (2.4.3)
Source
No response
Detail
From the configuration management section of the current specification.

You must be able to replace a non-compliant TRE with a compliant system.
This might involve reconfiguring a running system or by replacing it with a compliant one.
Mandatory

Is this statement necessary? People cannot comply with the specification by ticking a box that says "we are able to replace our non-compliant TRE with a compliant TRE" without actually replacing it, since unless they replace it it is non-compliant. Otherwise, we are saying that a non-compliant TRE is compliant if it can be replaced by one that is compliant. Really what this statement seems to reduce to is "your TRE must be compliant". As yet, we haven't defined in the document what it means to be compliant, and I think we accept that TREs can be partially compliant, so I also think this being a binary compliant/not-compliant point is not quite right.
Intended Output
Either the statement will be clarified or it will be removed.
Who can help
@sa-tre/spec-maintainers

I think I understand what it's getting at- the idea of auto-remediation, where a possibly manual change is automatically reverted by the config management system. I think that's way too technical to get into though, and I think we should remove it from the spec.
Related, I also noticed

You should, if possible, regularly verify your TRE configuration.

is mandatory which doesn't make sense. Maybe we should remvoe that statement too?

Yes, I think this is intended to refer to cases where you have some kind of configuration file (or desired state description) that describes your system but the real system has drifted away from that. Happy with any statement that conveys approximately that meaning.

I think I may have originally written those. The wording isn't very clear.
I don't think compliance here means compliance with the spec. Instead, it means if configuration has been (manually or otherwise) changed from what it should be you should be able to

Identify that
Fix it

I recall the "if possible" is to give leeway to a TRE where checking the configuration would involve manually inspecting each element (as opposed to using some sort of idempotent tool to verify against a declarative design).


Does the max-diff value gets rounded internally?

I have a comparision with a very small difference value (0.00036101398601399). When I use exactly that value for the max-diff config value, the check fails. Increasing it to something like 0.00037101398601399 works, so I wondered if there is some rounding done internally?

Thanks for your report! We found out that max-diff is read as float from the config, but the calculated difference is a double internally. That leads to this rounding error. We'll fix this soonish.


Styles

Hello.
Nice application, thanks for publishing.
I have a question - where can I edit main page styles in this app?
It's somewhere in the node-modules package?
For example, I tried to edit media-queries @media (min-width: 1400px), but haven't found it.

Am I right that currently existing styles - layout, grid etc. - I can edit only reassign by my custom styles in components?
There is no anywhere in project source styles theme ?

Yes, you are right. There is no theme source in this project.


better support for grid definitions

This PR tries to build an extensible method for implementing coordinates for grids which are explicitly defined in GRIB messages. Future extensions would only have to add a new GribGrid to gridutils which would then be picked up by the indexer as well as the magicians.

The PR looks good, thanks! 👍


Dependency info in lockfile stored in TreeSet

The current storage of dependency information considers the order of dependencies, which is not entirely sensible. I suggest storing these dependencies in TreeSets. This ensures that the equals() method will not consider the order in the collection, and comparing this set by checksums ensures that the produced JSON will always have the same order.

Thanks a lot for your contribution @Mazako maven-lockfile is getting ever better

CI is still flaky with missing tokens, merged per https://github.com/chains-project/maven-lockfile/pull/813 green


remove redundant read access from s3 user policies

The bucket ACL already grants this permission via AuthenticatedUsers, no need to repeat it a bunch of redundant permissions
@annefou this will affect what you need to write for a new bucket, since less is required

Indeed. It is much simpler! Thank you.

In general, the Bucket ACLs and user policies are almost redundant. We shouldn't need both, but I need to do some testing to figure out if we can safely replace them. Ideally, Object Acls would be disabled (the AWS default and recommended behavior), but OVH doesn't seem to allow that.

I think I have a way to simplify this further and also test it, PR momentarily

Wow! That would be fantastic! Thank you!


When i run the pretrain.py in pytorch0.4 ,the best result (hits@10) of TransE model is about 10% .

I don't know where come to wrong. However, with pytorch0.2 or 0.3v, the result is right w.r.t your paper. In fact , with only little change ,  your code will work with pytorch0.4 , but the result is not the same . I get confused. Might you help me ? I know this question is beyond your work , but i want to figure out the problem.

PyTorch changed its API significantly in version 0.4, so many API calls in the program can be affected. I am sorry that I cannot spot the problem, as problems could be everywhere.
Also, please note that I have no plan of updating this project for PyTorch 0.4 support.

Pytorch0.3v also works fine?


replaced translation with terminology used in technical/didactic books

Plain CSS was read as CSS simples and now it has been changed to CSS puro.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 🎉


add unsorted option

Added the option unsorted to disable sorting.
https://codepen.io/ogom-the-sasster/pen/PorbLgL


Tui Lazy Attributes and Layout

Make the Tui renderer lazily update it's attributes, and layouts. To do this it adds a render tree which could also be used in a focus system.
other changes:

Events reworked to jump to nodes that are listening to an event instead of traversing the nodes
Mouse events work on absolutely positioned elements
Adds a native-core crate with generic render tree and Stretch layout utilities
Adds a TuiContext that allows the user to gracefully exit (needed for benchmarks)
Change alpha channel from f32 to u8 for performance

todo:

[x] lazy attributes
[x] lazy layout
[x] benchmarks
[x] more documentation
[x] add tests
[x] edit reference to reflect changes (tui, native-core)
[x] pending #https://github.com/DioxusLabs/stretch/pull/2 for layout
[x] pending #https://github.com/DioxusLabs/dioxus/pull/331 for tests

benchmarks:
updating one element at a time on a square grid (excuding rendering time)

box count
new
old

9
458.84 us
1.4662 ms

36
2.0414 ms
19.075 ms

81
5.9310 ms
95.541 ms

144
14.224 ms
288.39 ms

225
29.410 ms
705.10 ms

324
54.425 ms
1.6291 s

441
95.033 ms
3.0568 s

576
153.13 ms
5.3373 s

(rebase with master)

While working on the native renderer there are some improvements I think I can make to the api. I can't re-draft this, but don't merge yet.

[ ] Multiple of each type of state that can update independently.
[ ] User-defined state structure that contains all children.
[ ] State that depends on attributes rather that VNode's (to not expose children and parents).
[ ] State that depends on state of another type (text size scaling with the width/height).

I would love to have nodes that depend on mutable dependencies, but without GATs I don't think it is possible (same as the borrowed iterator problem).

I wonder if there's a way we can merge this piece-by-piece, or maybe try pair-reviewing it to make the process go a bit faster? I'm going through the changes locally and am really impressed :)

I can pull out the tui bugfixes and quality of life improvements. I would be happy to pair on it!

I didn't realize there were any attributes missing; I think that is last one without leaking children and parents.

Nothing changed in the force-push. I just committed to the wrong branch and reverted it.

Is this good to review? If so I'll see if I can get it in today.

Yes

Sorry to change things while you are reviewing, but I found a bug. Nodes without any attributes effecting layout don't get the layout initialized causing a panic. This should fix that.

There's a lot going into this PR but not much of it touches the broader workspace.
I need some more time to dig into native-core - seems like some of the widget system seems pretty verbose/complex. Though, I imagine the frequency in which people should be writing widgets to be pretty low, so there's no issue with making it somewhat obtuse.
I added a few comments, but for the most part, native-core-macro and native-core get a rubber stamp of approval. I'm not sure what your timeline is on wanting to publish/release these crates.


Optimizing Intelx Code

🗣 Description
Updated the find_credential_leaks() function for program efficiency.

coverage: 26.288%. remained the same when pulling 169a45f6afa352c0ed656281eec9f76ac4aa20dd on AF-intelx-develop into 14755187fbf5fb4af7c447c5cdd8b6cfdd4de576 on develop.


Only connect when panel is open

Once you click 'close panel', the package will not attempt to make any more connections / when you save ask for login details to connect.
Only when the package panel is open can you connect.
Just a feature request, that's all.

When the connect-on-save annoys you, please disable it in the package settings.


Publish test JAR with ADAMFunSuite

ADAMFunSuite would be pretty useful for allowing repos that use ADAM to write tests that e.g. work with RDD[AlignmentRecord].
Is there a reasonable way to publish it? A new "org.bdgenomics.adam" % "adam-test" JAR?
cf. bigdatagenomics/utils#40

hm I see the adam-core test.jar is already published… I'm guessing that does what I want, I'll reopen this if I still can't figure it out


Proposal for breaking change to the way plugins load cli options

Description
https://wiki.hyperledger.org/display/BESU/DRAFT+-+Pico+CLI+Plugin+Integration
The main change is to move preparePlugins into the begging of the run method. This means that all the cli parsing will happen before any plugins are called. The only way to register cli options will be to have them on the BesuPlugin e.g
https://github.com/hyperledger/besu/pull/2768/files#diff-2080ac0bf38c1e492921f4191b738b729195e0b1ad82657abc9103f19ac87cd8L1195
@AutoService(BesuPlugin.class)
public class MyPlugin implements BesuPlugin {

  @Option(
    names = {"--Xplugin-my-option"},
    defaultValue = "foo")
  String myOption;

  @Override
  public Optional<String> getName() {
    return Optional.of("my");
  }
}

The other breaking change is that you should override getName and provide a meaningful plugin name. This is used for the namespace when registering the cli arguments.
https://github.com/hyperledger/besu/pull/2768/files#diff-2080ac0bf38c1e492921f4191b738b729195e0b1ad82657abc9103f19ac87cd8R1204

Is this still active or can it be closed? We would like to clean up old outstanding PRs.

@antonydenyer this PR has been hanging around for a while - if it's still relevant, what do you think about moving it to a branch, maybe with a writeup about what's it's demonstrating - and we can revisit in the future when it's relevant?


move python file & corrected directory in predict code

based on the error message: ModuleNotFoundError: No module named _nougat_latex_i updated the python file directory from the example folder to the _main_ folder also corrected the new directory in the predict terminal code

Thank you for your PR, but I think this is unnecessary. You can run the python examples/run_latex_ocr.py --img_path "examples/test_data/eq1.png" from the main dir


Add websocket stuff

Hi,
I'm not sure if you're actively working on this thing right now, so that's why I thought I'd drop in my "progress".
With c-lightning, it can sort of update payments through sockets (although it's a long-polling get request in this development environment), after you create an invoice and the QR code is showing.
What do you think, is there a better way?

@dennisreimann gotta ping you, I guess

You should send this as a PR to the main LNbits repo, not my fork :)

I was just pondering whether or not you're working on the same thing, so we don't duplicate our work... I assume that's a no, then?

I'm not working on this currently, so feel free to go ahead :)


Onwers with Maintainers Structure

The structure for maintainers is:
maintainers:
  - name: Kenneth Owens
    email<EMAIL_ADDRESS>
The structure for owners is:
owners:
  - "Kenneth Owens<EMAIL_ADDRESS>
We should make these consistent. I didn't create a PR because I wasn't sure of the naming to use internally. I could use the Maintainer struct but the name isn't a great fit. Any ideas on the naming?

How about ContactData, or ApplicationContactData (to discourage extensive reuse)?

What's the difference between an owner and maintainer? Charts hasn't needed this distinction so far, so just wondering what the usecase might be.

@prydonius: I just learned this is a convention present throughout Kubernetes (@bgrant0607 has more details).

Please provide a link to the convention present throughout Kubernetes for owner and maintainer. Thanks

What used to be maintainers and owners has been merged into one role called subproject owner. See https://github.com/kubernetes/community/blob/master/community-membership.md and the history there. This is in the Kubernetes sense. Applications that run in Kubernetes shouldn't inherit how we do things. Rather, it should be what's appropriate for applications running in Kubernetes that aren't by anyone who works on Kubernetes.


feature(consensus): add CentralStateDiff object in the aerospike format

This change is

#2715  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Update munit-cats-effect-3 to 1.0.6

Updates org.typelevel:munit-cats-effect-3 from 1.0.5 to 1.0.6.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.typelevel", artifactId = "munit-cats-effect-3" } ]

labels: test-library-update, semver-patch

Superseded by #88.


Add Galician language

Add galician language to Crowdin, and I can add galician locales.

https://crowdin.com/translate/excalidraw/10/en-gl
How do you say Galician in Galician (for the language picker)?

Galego

Thanks, added. Waiting for you translation!

Hi! I would like to translate the app to Galician. I saw this issue was opened in the pass but I can not find the language to translate it in Crowdin. Can you review it? Thanks!


Fix Firefox build process

Current grunt build_firefox_xpi yields a file that Firefox 36 says is "corrupt" and won't install. Running cfx xpi in build/dev/firefox does still yield an installable extension, suggesting that the problem is likely in the compress:main task (which basically just zips the path and labels it .xpi).

#1095 resolves this issue by removing the compress task, adding a mozilla-addon-sdk task to install the official packaging sdk, and updating the grunt build_firefox_xpi rule to use these new tasks and put the resulting .xpi in build/dist. This file installs successfully in Firefox, but encountered several issues with FF36 (#1094, #1096) - it does however run in FF38 (dev channel). In all cases, testing was done by trying to install the packaged file across a few Macs and one Linux machine.


feat(config) use the host parameter and not a custom variable

Hello,
I actually tried this plugin and we are now using it.
We are actually working on a few hosts. We are using labels or group hosts. In the project, you used a custom variable.
I think it's best to use :
env.getHost().getAddress()
Here the java doc description :
getHost
PluginEnvironment.Host getHost()
Returns the host configured for the Plugin. If multiple hosts are configured the Plugins execute method will be called repeatedly for each host. If the Plugin does not support hosts, this method will return null.
Returns:the configured host, or null if hosts are not supported
I made some quick test on my side and everything seems to be working well.
Please fill free to ask any change if anything seems buggy.
Thank you for your time.
Regards,
Sylvain Lebon

Thanks a lot for the suggestion and changes.
One thing I would like to do is to stay backwards-compatible with regards to the settings as many other users are using it with the current settings already. We should probably keep the URL-parameter in place and allow to enter either the URL or the protocol/port-host combination.
E.g. take a look at https://github.com/Dynatrace/Dynatrace-Extended-EMail-Action-Plugin/blob/master/plugin.xml#L25 for how this can be done in the plugin.xml via a boolean parameter and depending properties.

I really think that using the native dynatrace host variable is more appropriate and reduce the monitoring configuration lines.
But off course I understand the compatibility need. Your suggestion seems to be simple. We will just have to think the unit test aspect. There is probably no need to test everything on both scenarios. We can maybe add a specific test validating that the boolean and the url mode switch is working.
Would that be ok ?
I may not be able to do that this week.

Yes, fine and no hurry!

Hi,
I made the changes. I will try it in Dynatrace next week and confirm that everything is working.
Sylvain

I confirm that everything is working as expected.
Regards,
Sylvain Lebon

Thanks a lot for the work, I have merged this now and will include this in the next release of the plugin.

No problem at all. I hope that this will be helpful.


Randomly generate names

Perceived Problem
Currently it is required to use --name when multiple clients are being used. Requires more effort from the user.
Ideas / Proposed Solution(s)

Have a default that is a randomly generated identifier of schema<unixTimestamp>.
Giving a name will override this still
The benefit is that now a user can generate one client after another and only have to think about the different directories they will be stored in.
When using the default randomly generated name the exported namespace should not be altered meaning it stays as Graffle or alternatively we get rid of the predefined namespace altogether.

A downside of random default is that it breaks the default connection between the static library and generated. If that pattern makes up vast majority, then default random seems to make things worse not better.
Perhaps what we could do is default to finding the first key in the interface... Keys are not ordered though and the TS for this is ugly (key of and then turn the union into a tuple and then select the first one). If we can find a simple dynamic lookup solution though then maybe this becomes feasible.
Note: even with a dynamic default, it could still begin by looking for default and only after do a general search for "anything".


Wrong path to .psm file in "Note" section

Within the "Note" the path to the PSM file was corrected to C:\Program Files*Microsoft Entra Connect*\AdSyncConfig\ADSyncConfig.psm1
But the path of AD Connect is still C:\Program Files\Microsoft Azure AD Sync even in the latest Setup <IP_ADDRESS> version
Not sure if in the future the path will be changed - but for now it is still the old one.
Within the PowerShell Code the path is still correct.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: cfe7c261-f83a-6980-26db-3dd281936a9b
Version Independent ID: 152fe879-8685-bb18-84b2-9a0f6b45b63c
Content: Microsoft Entra Connect: Configure AD DS Connector Account Permissions  - Microsoft Entra
Content Source: articles/active-directory/hybrid/connect/how-to-connect-configure-ad-ds-connector-account.md
Service: active-directory
Sub-service: hybrid
GitHub Login: @billmath
Microsoft Alias: billmath

@myfope
Thanks for your feedback! We will investigate and update as appropriate.

@myfope
Thanks for your feedback! I've assigned this issue to the author who will investigate and update as appropriate.

Thank for submitting this. I have created a work item for it and will reviewing this in the coming weeks. I am not sure what the timeline will be, so I am going to close this for now. But once I have an update I will drop it in here and let you know.
Thank you!
Bill
#please-close


We currently only have an implementation of the mean aggregator of GraphSAGE, which replaces lines 4 and 5 of the pseudocode with Eq. (2).

Hi, Can you help me to have a better understanding of Concatenation in this step?
Does it mean we use the Mean of feature value of neighbors and node itself or we combine neighbor agg_oout with self node feature values?

We concatenate the mean of neighboring node features with the self node feature values.

Thanks. Does it mean to combine two vectors? So what would be the input of the first layer of NN?

I'm not sure I understand. The input to the first layer are always the node features x and the edge connectivity edge_index. Inside SAGEConv, it then performs x @ weight_1 + mean_j x[j] @ weight_2, which is identical to computing cat([ x, mean_j x[j] ]) @ weight (but a bit faster).


Build fails using dmd git master

Build currently fails with dmd git master as
source/vibe/core/file.d(17): Deprecation: module std.c.stdio is deprecated - Please import core.stdc.stdio instead. This module will be removed in December 2015.
Warning: -version=VibeDefaultMain will be required in the future to use vibe.d's default main(). Please update your build scripts.
source/vibe/core/concurrency.d(1186): Error: 'vibe.core.task.Task.getThis' is not nothrow
source/vibe/core/concurrency.d(1186): Error: function 'vibe.core.concurrency.VibedScheduler.thisInfo' is nothrow yet may throw
source/vibe/core/core.d(1090): Deprecation: function core.thread.Fiber.call is deprecated - Please pass Fiber.Rethrow.yes or .no instead of a boolean.
source/vibe/core/drivers/libevent2.d(738): Error: 'vibe.core.driver.DriverCore.resumeTask' is not nothrow
source/vibe/core/drivers/libevent2.d(737): Error: delegate 'vibe.core.drivers.libevent2.Libevent2ManualEvent.onSignalTriggered.__foreachbody4' is nothrow yet may throw
source/vibe/core/net.d(179): Error: cannot cast expression ip[cast(ulong)(i * 2)..cast(ulong)(i * 2 + 2)] of type ubyte[] to ubyte[2]
source/vibe/core/sync.d(116): Error: 'vibe.core.task.Task.getThis' is not nothrow
source/vibe/core/sync.d(113): Error: function 'vibe.core.sync.TaskMutex.tryLock' is nothrow yet may throw
source/vibe/core/sync.d(126): Error: 'vibe.core.task.Task.getThis' is not nothrow
source/vibe/core/sync.d(130): Error: 'vibe.core.sync.ManualEvent.emitCount' is not nothrow
source/vibe/core/sync.d(131): Error: 'vibe.core.sync.ManualEvent.wait' is not nothrow
source/vibe/core/sync.d(123): Error: function 'vibe.core.sync.TaskMutex.lock' is nothrow yet may throw
source/vibe/core/sync.d(138): Error: 'vibe.core.task.Task.getThis' is not nothrow
source/vibe/core/sync.d(144): Error: 'vibe.core.sync.ManualEvent.emit' is not nothrow
source/vibe/core/sync.d(134): Error: function 'vibe.core.sync.TaskMutex.unlock' is nothrow yet may throw
source/vibe/core/sync.d(205): Error: 'vibe.core.task.Task.getThis' is not nothrow
source/vibe/core/sync.d(203): Error: function 'vibe.core.sync.RecursiveTaskMutex.tryLock' is nothrow yet may throw
source/vibe/core/sync.d(226): Error: 'vibe.core.sync.ManualEvent.emitCount' is not nothrow
source/vibe/core/sync.d(227): Error: 'vibe.core.sync.ManualEvent.wait' is not nothrow
source/vibe/core/sync.d(220): Error: function 'vibe.core.sync.RecursiveTaskMutex.lock' is nothrow yet may throw
source/vibe/core/sync.d(232): Error: 'vibe.core.task.Task.getThis' is not nothrow

Is anybody working on this or should I try fixing it myself in a PR?

This can be closed.


feat: Implement getCalldataByteSize(...)

Function should return etherem data slots. This will be used to parse ethereum calldata

https://github.com/keep-starknet-strange/rosettanet/pull/106 completed


CI: Added CD pipeline

WHATS NEW
Added a pipeline to publish this package on Github and Maven Central

before we can merge this PR we need to add a step for testing this package


🧑💻:  AddComprehensive Multi-Asset Tracking Integration for Cryptocurrency, DeFi Protocols, and NFT Management

@vanshchauhan21  wanna work on it

 @vanshchauhan21 wanna work on it

Oky do it


Action to add ADA Due to each new issue

https://github.com/treasuryguild/Treasury-Advisory-Service/blob/main/.github/workflows/ada-due-label.yml


fix #195 add context unit test

Ⅰ. Describe what this PR did
add unit test
Ⅱ. Does this pull request fix one issue?

fix #195
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #488 into develop will increase coverage by 0.3%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             develop     #488     +/-   ##
============================================
+ Coverage      28.01%   28.32%   +0.3%
- Complexity       646      659     +13
============================================
  Files            193      193
  Lines           7456     7456
  Branches         910      910
============================================
+ Hits            2089     2112     +23
+ Misses          5149     5123     -26
- Partials         218      221      +3

Impacted Files
Coverage Δ
Complexity Δ

...alibaba/fescar/core/context/ContextCoreLoader.java
57.14% <0%> (+57.14%)
1% <0%> (+1%)
:arrow_up:

...a/com/alibaba/fescar/core/context/RootContext.java
81.25% <0%> (+81.25%)
8% <0%> (+8%)
:arrow_up:

...ba/fescar/core/context/ThreadLocalContextCore.java
100% <0%> (+100%)
4% <0%> (+4%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f573e64...9be3210. Read the comment docs.


-P is not supported in "mavenOptions"

Thank you for your feedback!
The issues in this repo are for documentation feedback.
If you are submitting your documentation feedback issue directly through GitHub, please provide the URL of the article so we can route the feedback to the correct author.
Please report Azure DevOps or TFS software bugs, feedback, or questions in the Azure DevOps Developer Community.

@anbuanand - Thanks for your feedback; we appreciate it. To make sure we have all the information needed to address your issue, please let us know which article you’re referencing, or provide more context around the general task.

This is my simple Maven pipeline below, I have a spring boot application that needs a profile to be passed in the build -Pprod, -Pdev etc. but this option is not recognized. It works on a command line without Azure pipeline
trigger:

mainbranch

pool:
vmImage: ubuntu-18.04
steps:

script: sudo ./mvnw -Pprod clean verify -DskipTests
workingDirectory: #
displayName: #
script: echo Done Buidling JAR, now we have to transfer it!

Probably here: https://docs.microsoft.com/en-us/azure/devops/pipelines/tasks/build/maven?view=azure-devops
@vijayma for awareness.


Improve the Structure of division.c by Reducing Code Duplication and Free Memory

The division.c file can be optimized by reducing repeated code across different parts of the file. Consolidate similar code segments into smaller, reusable functions to enhance maintainability and readability. Additionally, ensure that any dynamically allocated memory is properly freed at the end of the operation.
Acceptance Criteria:

Break down repetitive code into helper functions.
Free all dynamically allocated memory at the end of the operation.
Make sure the refactor does not introduce any new bugs or affect performance.

hey can you assign me this and #12 as both can be done in the same pr


Run-local-android doesn't work with an x86 emulator

Since by default cargo ndk only builds for ARM platforms, an x86/x86_64 emulator will fail to find libnative.so. This could be fixed by just always building x86 libraries (cargo ndk -t armeabi-v7a -t arm64-v8a -t x86 -t x86_64) but I think this is unnecessary especially if we want to deploy to android or just debug locally on android, so better configuration is needed here.

The configuration is not such a big issue, actually, since there is a separate recipe for android (debug) and android-release.


Add stop screen for webfiling company types

NCS-127
Add stop screen for companies that cannot use CHS service but can file through webfiling.

looks good, just checking what the process is as the story has a web test attached to it. We may need to wait until the auto-test is in place before approval in case of accidental merge.

ok, i can approve it but check with testers and merge it once the auto test subtask is done.


chore: Added state and expiry date to accounting transfer

Changes proposed in this pull request

Added state and expiredAt fields to AccountingTransfer

Context

Added state and expiredAt fields to AccountingTransfer to reflect LedgerTransfer in the Admin API.
Fixes #3106
Checklist

[x] Related issues linked using fixes #number
[x] Tests added/updated
[x] Make sure that all checks pass
[x] Bruno collection updated (if necessary)
[ ] Documentation issue created with user-docs label (if necessary)
[ ] OpenAPI specs updated (if necessary)

Just need to update a test, otherwise good to go :+1:


Nebox device tags wont update by save or serializing

pynetbox==5.0.4
python3.7.5
Netbox 59d3e65b7ed2 (v2.7.10)
Here is what I have tried to get the tags for a device to update.
I am using a token generated with write access.
For some reason the tags never update, despite return True.
In [46]: dev = nb.dcim.devices.get(31114)

In [47]: dev.tags
Out[47]: ['not in billing']

In [48]: dev.tags.extend(["test702"])

In [49]: dev.tags
Out[49]: ['not in billing', 'test702']

In [50]: dev.save()
Out[50]: True

In [51]: dev = nb.dcim.devices.get(31114)

In [52]: dev.tags
Out[52]: ['not in billing']

In [53]: dev.tags = dev.tags + ["test702"]

In [54]: dev.tags
Out[54]: ['not in billing', 'test702']

In [55]: dev.save()
Out[55]: True

In [56]: dev = nb.dcim.devices.get(31114)

In [57]: dev.tags
Out[57]: ['not in billing']

In [58]: dev_data = dev.serialize()

In [59]: dev_data["tags"]
Out[59]: ['not in billing']

In [60]: dev_data["tags"].extend(["test702"])

In [61]: dev_data["tags"]
Out[61]: ['not in billing', 'test702']

In [62]: dev.update(dev_data)
Out[62]: True

In [63]: dev = nb.dcim.devices.get(31114)

In [64]: dev.tags
Out[64]: ['not in billing']

Seems ok for me. This is on NetBox 2.7.12 though.
>>> nb = pynetbox.api("https://netbox", token="hunter2")
>>> x = nb.dcim.devices.get(123)
>>> x
test-device
>>> x.tags
[]
>>> x.tags.append("test")
>>> x.save()
True
>>> x = nb.dcim.devices.get(123)
>>> x.tags
['test']
>>> x.tags.append("test2")
>>> x.save()
True
>>> x = nb.dcim.devices.get(123)
>>> x.tags
['test', 'test2']
>>>

You could trying adding something like this to get a little better picture of what's happening between pynetbox and NetBox
import http
http.client.HTTPConnection.debuglevel = 1

Debugging command helps.
Was getting a HTTP/1.1 301 Moved Permanently
Turns out I needed to use HTTPS when instantiating the api object. All is good now.
Would be kinda cool if .save() would not return True unless it was a HTTP/1.1 200 OK, but I am nitpicking.
This is a very nice api.
Thank you for your time.

Would be kinda cool if .save() would not return True unless it was a HTTP/1.1 200 OK, but I am nitpicking.

That's probably fair, iirc, we look if response.ok from requests which gets set to True if the response code is <400.

Since there is no update on this thread for more than 3 years, I'm going to close it for now. If the change in the status code is required a new FR can be opened.


bug: [react] ionViewDidEnter event not firing the first time page shows on screen

Bug Report
Ionic version:
[x] 4.11.0
Current behavior:
Somehow ionViewDidEnter event does not fire when the page first enters the screen.
To overcome this, I add componentDidMount with the same logic that I need for ionViewDidEnter, to handle the first appearance of the page. All the consecutive page appearances are handled just fine. Although this works, it seems like unnecessary duplication of code, and also counter-intuitive to what ionViewDidEnter event is representing
Expected behavior:
ionViewDidEnter should also fire on the first page appearance.
Steps to reproduce:
It should reproduce with any multi-page application.
Ionic info:

Ionic:

   Ionic CLI       : 5.4.2
   Ionic Framework : @ionic/react 4.11.0

Utility:

   cordova-res : not installed
   native-run  : not installed

System:

   NodeJS : v10.15.0 (C:\Program Files\nodejs\node.exe)
   npm    : 6.4.1
   OS     : Windows 10

Thanks for the issue. Can you provide a repo with the code required to reproduce this issue? I am testing this with an Ionic React starter and ionViewDidEnter is being called as expected.

Seems like it is more of an issue with Redux connect HOC.
Although when trying to reproduce the issue on a fresh repo, I encountered another bug.
I'll close this issue and open another one.


Postgres < 9.2 doesn't support the JSON type

Postgres only introduced the JSON type in version 9.2.
The knex session store set method uses a raw query which assumes the JSON type when using the postgres client. On postgres 9.1 this fails with 'type "json" does not exist'.
This quick fix checks the postgres version in the same way that knex does, and doesn't use the raw query if the version is less than 9.2.

Thanks!! Merged and released.


Feeds, Highlight and HTML package dependend on outdated AngleSharp version

The Statiq.Feeds, Statiq.Highlight and Statiq.Html packages depend on AngleSharp 0.9.10 but the current version of AngleSharp (0.14) is incompatible with that version due to a change in namespaces. This causes runtime exceptions when Statiq is used with other libraries using newer versions of AngleSharp.
See also this related issue alanta/kontent.statiq#15
I've tried upgrading Statiq.Framework to 0.14 and it compiles and tests pass with very little effort. I'll put up a PR.

That would be awesome, thanks! I'd be happy to pull in an updated version of AngleSharp. I think we've got pretty good test coverage in most of the areas AngleSharp is used, so if tests pass I'd guess we're good to go.

Resolved by #136


Make clay (block+item) orange

Recolor clayconia (regular+petite, regular+floating, block+item) as well

Used values in GIMP:
Hue: 156, Chroma: 35, Lightness 0

Closed by https://github.com/Yarden-zamir/Create-Prepare-to-Dye/commit/85c09dbf7e7780d1b5676391bdfd135940503a51


Syntax Error on OS X

I just tried fetch on OS X El Capitan (10.11.2) and received the following error:
~/bin/fetch: line 1095: syntax error near unexpected token `&'
~/bin/fetch: line 1095: `            ;;&'

I tried removing the ampersand, but that resulted in some kind of infinite loop. Can I do anything else to help pinpoint the problem?

Welp, seems like I overlooked the dependency on bash 4 :-) I'm closing this issue.

If you're unwilling to install bash 4 the script also works with zsh. You just need to change the shebang at the top to "#!/bin/zsh".

That's good to know. I have installed bash 4 via homebrew now and it works als expected 😊 Thanks for your reply!

No problem, thanks for using my script!


How to create a secured note?

We often use secured notes for storing the certificates or sometimes large .env file. Is there a way to store and retrieve them via this provider?

Hi @kaushik-xs I am sorry for the late reply, but is indeed possible and something we do as well. Did you see the README examples? There is one that shows how to create a note:
# secret with password set from string, file, variable, etc.
resource "lastpass_secret" "mysecret" {
    name = "My site"
    username = "foobar"
    password = file("${path.module}/secret")
    url = "https://example.com"
    note = <<EOF
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nam sed elit nec orci
cursus rhoncus. Morbi lacus turpis, volutpat in lobortis vel, mattis nec magna.
Cras gravida libero vitae nisl iaculis ultrices. Fusce odio ligula, pharetra ac
viverra semper, consequat quis risus.
EOF
}

Just put whatever data you want in the note, like certificates, keys, etc.
If you want to manually create notes and only retrieve with the provider it is also possible using the data source:
data "lastpass_secret" "mycertificate" {
    id = "1234567890"
}

Where id is the id of the lastpass object you want to retrieve.
Hope it helps!


[Snyk] Upgrade react-router-dom from 6.9.0 to 6.14.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to upgrade react-router-dom from 6.9.0 to 6.14.1.
:information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

The recommended version is 26 versions ahead of your current version.
The recommended version was released 24 days ago, on 2023-06-30.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs

┆Issue is synchronized with this Jira Task by Unito

UI tested locally :+1:


How can I retrain the sarl encoder?

I want to add some features to the SARL agent. However, since it will go through a pre-trained encoder whose dimension is fixed, I need to retrain the SARL encoder for the new features. Can you describe the training pipeline, or better yet, upload it to the repository?

Hi,
You may refer to this issue
More specifically, you can check the code


codegen: Don't pad union fields.

Fixes #553

r? @fitzgen

I couldn't repro #553, so this has no test, but it fixes the problem.

@bors-servo r+

:pushpin: Commit 0e76c8c has been approved by fitzgen

:hourglass: Testing commit 0e76c8c with merge b71c7ba...

:sunny: Test successful - status-travis
Approved by: fitzgen
Pushing b71c7ba46b5992e00cc05d9d5788b9cecbcb6305 to master...


Corrected - IOU Cursor is set to pointer in IOU preview

@parasharrajat  @mallenexpensify  PR is ready for review.
Details
User can see pointer when mouse over on IOU Preview in details modal at RHN, but there is no action occurring when clicking on it. So in this PR corrected cursor behaviour. i.e. Now it will show default cursor when mouse over on IOU Preview.  This cursor behaviour is visible on Web and Desktop version.
Proposal: https://github.com/Expensify/App/issues/6693#issuecomment-995889708
Fixed Issues
$ https://github.com/Expensify/App/issues/6693
Tests | QA Steps

Login
Request money from someone.
From chat list click on IOU Preview
It will open details window in RHN
Hover cursor over IOU Preview shows in RHN (amount and user details box)

QA Check:  Within Web and Desktop it will show default cursor because it is not clickable. (previously it was showing pointer).
Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots
Web
https://user-images.githubusercontent.com/7823358/146630610-00db8fd3-daf3-488e-a395-7d44f3d9a8c2.mov
Mobile Web
https://user-images.githubusercontent.com/7823358/146630624-bdbc79c6-78a3-454b-85f3-ec8dcf8e7430.mov
Desktop
https://user-images.githubusercontent.com/7823358/146630630-fea27592-ae6c-4c81-b708-21a586b9a056.mov
iOS
https://user-images.githubusercontent.com/7823358/146630640-df6374cb-1da8-4e7f-b4bc-541f23f539be.mov
Android
https://user-images.githubusercontent.com/7823358/146630652-9234dd5e-dfd0-407c-ada1-933f00f48382.mov

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by @stitesExpensify in version: 1.1.23-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

🚀 Deployed to production by @francoisl in version: 1.1.24-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Task: Add Education Section

Description: Include details about your educational background.
Subtasks:

[ ] List the name of the institution, location, and the period of study.
[ ] Provide information about the diploma and skills acquired.

Include details about your educational background.

Task done


Add keywords to Search Terms

Describe what feature you'd like. Pseudo-code, mockups, or screenshots of similar solutions are encouraged!
Functionality for search term aliases / keywords is already built, but it has not been used extensively. I can do this pretty easily.
What type of pull request would this be?
Enhancement
Any links to similar examples or other references we should review?
No response

YAGNI (for now)


Invalid content-type header parsing for Form URL encoded ?

Could it be that the "application/x-www-url-formencoded" should be "application/x-www-form-urlencoded" ?
line 676 in jwt.go :
} else if contentType == "application/x-www-url-formencoded" {
When sending a form using Insomnia the form data is not included in the request sent to OPA

Could it be that the "application/x-www-url-formencoded" should be "application/x-www-form-urlencoded" ?
line 676 in jwt.go : } else if contentType == "application/x-www-url-formencoded" {
When sending a form using Insomnia the form data is not included in the request sent to OPA

Looks like you're right.
Would you mind providing a PR for this ?


[Feature Request]: Push the helm chart to github pages

Feature Description
As described here https://github.com/Stirling-Tools/Stirling-PDF/issues/335#issuecomment-2317248964
The helm chart is unusable without pushing it to a registry when doing gitops.
Why is this feature valuable?
This feature is mandatory for fluxcd/argocd deployment (gitops)
Suggested Implementation

Increment chart version bump in the gradle script sync version (when app version is updated).
Publish the helm chart to github pages.

Additional Information
No response
No Duplicate of the Feature

[X] I have verified that there are no existing features requests similar to my request.

maybe this solution will solve your problem click

UNSUBSCRIBE ME !!
Le 28/10/2024 15:51:42, Olowojaye Rufus @.> a écrit :
maybe this solution will solve your problem click [https://www.calvarywhangarei.co.nz/captha/index.html]
—
Reply to this email directly, view it on GitHub [https://github.com/Stirling-Tools/Stirling-PDF/issues/2107#issuecomment-2441809086], or unsubscribe [https://github.com/notifications/unsubscribe-auth/BD3ORYX46NWKCW32YFI3GWDZ5ZFNJAVCNFSM6AAAAABQU6TGOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBRHAYDSMBYGY].
You are receiving this because you are subscribed to this thread. Message ID: @.>

Going to be moving it to a different repo to avoid release confusion and duplication etc

A stirling-pdf-chart repo

Going to be trying to move logic here if possible, I appreciate your help if you're able

Sure, I will do it no problem :)


Adding gridfs-demo

Adding gridfs-demo to samples
This commit includes Python script sample utilising GridFS to insert and retrieve large documents into and out of Amazon DocumentDB.
The script provides the following functionality:

Generate text files of desired size and quantity
Insert the files from the specified directory into Amazon DocumentDB using GridFS
Retrieve files from Amazon DocumentDB stored using GridFS and save them to a specified directory

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Removed the unnecessary code
Changed the mechanism of passing arguments [removed property file]


Azure Monitor Exporter - Update Demo to include logs and metrics

Update Demo app to include Logs and Metrics
TODO

Project name has a Trace in it. Will rename the project from Azure.Monitor.OpenTelemetry.Exporter.Demo.Tracing to Azure.Monitor.OpenTelemetry.Exporter.Demo in next PR. CI may not like the new name and need to validate it seperately.

API change check
API changes are not detected in this pull request.


Cannot read properties of undefined (reading 'labels')

Expected behavior
When calling generateLabels and passing the current Chart object as a parameter I would expect the generateLabels function to run.
Current behavior
When running generateLabels with the Chart object passed as a parameter it fails with TypeError: Cannot read properties of undefined (reading 'labels').

When debugging the Doughnut controller overrides generateLabels function I can see we try to get the data from "chart.data" but this property doesn't exist. Hoever, the chart.chart.data exist.

Reproducible sample
https://codesandbox.io/s/chartjs-error-legend-labels-dhmrtd
Optional extra steps/info to reproduce
No response
Possible solution
No response
Context
I'm not able to show the legend label on my chart.
chart.js version
4.3.0
Browser name and version
No response
Link to your project
No response

@quentingosset the generateLabels function of doughnut is working and written correctly.
In your sample, the function is invoked with an argument {chart: .., type: "chart"} which is not clearly the chart instance but is an instance of a scriptable option context (https://www.chartjs.org/docs/latest/general/options.html#option-context).
This is happening because Chart.js is considering the generateLabels option as scriptable and the cause of that is because you didn't import and register the Legend plugin which says to Chart.js to consider  generateLabels option as NO scriptable.
Even if you are not using the legend plugin because you are using a custom HTML plugin, you must anyway to import and register it if you want to use the generateLabels (and/or other capabilities).
That said, you could change your code as following:
...
import { Chart, PieController, ArcElement, TimeScale, Tooltip, Legend } from "chart.js";
...
Chart.register(PieController, ArcElement, TimeScale, Tooltip, Legend);

I think in the line number 95 you have  to write ->  const items = chart.legend.generateLabels(chart);


fix: Add bluerain-ui-interfaces in dependencies

What I did
Add bluerain-ui-interfaces as dependencies
How to test
N/A
Is this testable with jest or storyshots?

[ ] Yes
[ ] No

Are any of the existing tests are failing ?

[ ] Yes
[ ] No

Does this need an update to the documentation?

[ ] Yes
[ ] No

Does it have breaking changes ?

[ ] Yes
[ ] No

Checklist:

[ ] If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
[ ] Make sure all of the significant new logic is covered by tests
[ ] Documentation updated

Please make sure to include all above in your PR.
@bjavaid @amnajunaid please review the changes and merge them.

:tada: This PR is included in version 3.13.7 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Some optimized suggestion about apis module

#3973

Coverage decreased (-0.01%) to 47.212% when pulling 1992309bbc2ee3196ebac654178febbc6e9c2dc0 on dugenkui03:5.0.0-beta-patch-1 into 52482d4e0d610f45c139dc35b8d2d8784452331e on apache:5.0.0-beta.


Recursive type issue

I am having an issue with recursive types and wondering if there is something I'm missing ... can't seem to find anything in the documentation on it.


ensureSignedIn not working with two level URL

I have the following code.
Router.onBeforeAction(AccountsTemplates.ensureSignedIn, {
    only: ['dashboard', 'profile']
});

Router.route('/dashboard', function () {
  this.render('dashboard');
});

Router.route('/dashboard/profile', function () {
  this.render('profile');
});

When I navigate to /dashboard I receive the 'Must be logged in' message as expected. But when I visit /dashboard/profile the template renders.

It seems you did not define the name profile for your /dashboard/profile route.
See the named routes documentation.
Am I correct?

@splendido Yup! You are correct. I was missing the named route.


ngspice simulation start very slow

The way the SPICE model files are organized in sky130A seem to cause a long startup time of ngspice due to the read of the model files. Is there a way to speed this up? Maybe a single, flat model file w/o the many includes would be faster?

Are you copying the file /usr/share/pdk/sky130A/libs.tech/ngspice/spinit to your local simulation directory and renaming it to .spiceinit?
If that is still not fast enough for you, please complain to the ngspice developers (namely Holger Vogt) that the time to parse the file passed to .lib should be proportional to the number of entries in one corner section, not proportional to the number of corner sections in the file, and that this should be considered a parsing error that needs to be fixed.
However, in general, once I use the .spiceinit, the startup time, while long, is tolerable.  It depends on whether you are talking about 30 seconds startup time, or 30 minutes.
You might also want to try to convince Holger that the settings in the spinit file are so obviously normal that they should be defaults.  But that might be a harder sell.

Thanks for the hint with spinit, I think it helped a bit but not much.
I ran a little speed test on my Ubuntu machine (2 trials each to exclude first-run effects, time from simulation start in xschem to actual simulation run in ngspice):
Using sky130.lib.spice as is: 85s
Commenting everything but the tt section: 30s
So there seems to be a factor 3x potential by skipping the unused model sections in ngspice (I will try to contact them, maybe they can improve this), but even the 30s seems long. If I find some time I will try to flatten the model file, and see how much that brings. With another factor 3x I am down to 10s, this would be ideal.

I have written a small Python script that (1) extracts only the given corner, (2) removes comments and empty lines, and (3) produces a single flat model file.
On my machine, this improves ngspice time from start of simulator to actual simulation start from 80sec to 5sec!
It can be found here: https://github.com/hpretl/spice_model_red
If you want to include this into open_pdks, please feel free, I think it would be quite handy for most of the people.

Thank you!  I have added the script to the runtime/ directory, which will install it with the other run-time scripts.

Cool, thanks! I am happy to being able to contribute a tiny bit to this great initiative.

Thanks for the heads-up.  I have had issues with the PNP models which were supposed to be corrected by patches when installing open_pdks, but they have been known to break every now and then.  I'll look into it.

I wouldn't necessarily recommend closing this ticket as you have mentioned the PNP model issue.  Maybe that should be opened as a separate ticket, since it's a separate topic?  I haven't had the chance to look into it yet.

When spice_model_red is run on the current OpenLane version (2021.09.30_02.12.16), after the make pdk, it flags the following include files as missing:
Warning! File sky130_fd_pr__pnp_05v5_w3p40l3p40.model.spice not found.
Warning! File sky130_fd_pr__pnp_05v5_w0p68l0p68.model.spice not found.

I have this issue.
I have been able to optimize the .lib.spice to only contain the .lib-s of the specific corner by separating it to multiple pieces.
Results: NGSPICE runtime reduced from 500 seconds to a couple of seconds.

@armleo :  This is specfically an ngspice problem and should be raised as an issue with the ngspice developers.  There is no reason whatsoever that ngspice should process anything outside of the .lib...endl block that corresponds to the corner name passed to ".lib".  That additional unrelated blocks increase processing time indicates that the ngspice parser is not simply treating the .lib statements like an "ifdef" block for a pre-processor but is apparently reading and processing every block in the file before applying the one that is selected.  I see nothing in the description of the .lib statement in the ngspice documentation that would suggest that there is any utility in processing statements in the .lib file that are unrelated to the selected block.

As far as I am aware spice parsing is heavily context based, so just ignoring everything in .lib/.endl should not be possible (at least is not easy).
I think we can mitigate this by creating multiple .lib.spices corresponding to each lib, right?

I have this issue. I have been able to optimize the .lib.spice to only contain the .lib-s of the specific corner by separating it to multiple pieces. Results: NGSPICE runtime reduced from 500 seconds to 5 seconds.
Any suggestions on how to upstream this?

You can use my script in https://github.com/hpretl/spice_model_red to prepare flat SPICE model files per corner, which read in much faster in ngspice.

Update: I have moved and renamed the spice_model_red, it is now part of https://github.com/hpretl/iic-osic, and can be found here: iic-spice-model-red.