Error in latest develop_build ADCIRC-WW3

Hello, while trying to run the latest develop_build version of ADCIRC-WW3, I encountered the following terminating errors in the PET000.ESMF_LogFile.

In previous versions of ADCIRC-WW3 I wasn't getting these errors. Instead, I was getting something like this, but they were not terminating errors:

Do you know what the problem might be?
@saeed-moghimi-noaa @pvelissariou1 @aliabdolali
Angelos

Angelos hi,
I don't know where these field names come from.
In CoastalApp none of these fields are defined or used anywhere.
What is the version of ESMF you are using?
Are you sure that you don't have something funny set in your environment?
We have never seen these field names before.
How did you compile CoastalApp?
Takis
Panagiotis Velissariou, Ph.D., P.E.
UCAR Scientist
National Ocean and Atmospheric Administration
National Ocean Service
Office of Coast Survey CSDL/CMMB
Physical Scientist - Project Lead
cell:<PHONE_NUMBER>
email: @.***
On Mon, Nov 14, 2022 at 10:38 AM sarriegi @.***> wrote:

Hello, while trying to run the latest develop_build version of ADCIRC-WW3,
I encountered the following terminating errors in the PET000.ESMF_LogFile.
[image: image]
https://user-images.githubusercontent.com/77630268/201714668-f8b4fabd-9b2d-433d-b5e4-fdcbaa2c5a1e.png
In previous versions of ADCIRC-WW3 I wasn't getting these errors. Instead,
I was getting something like this, but they were not terminating errors:
[image: image]
https://user-images.githubusercontent.com/77630268/201715008-38a25853-f2f8-4859-9e2c-db8c4e82476c.png
Do you know what the problem might be?
@saeed-moghimi-noaa https://github.com/saeed-moghimi-noaa @pvelissariou1
https://github.com/pvelissariou1 @aliabdolali
https://github.com/aliabdolali
Angelos
—
Reply to this email directly, view it on GitHub
https://github.com/noaa-ocs-modeling/CoastalApp/issues/146, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/APC7TP5JGJLSHJU3LFBY4FLWIJTHBANCNFSM6AAAAAASAAORZQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

Hello @pvelissariou1 I am using esmf version 8.0.1. Should I use a different version? I compiled CoastalApp with an already pre installed parmetis library, by setting PARMETISHOME and running the command:
./build.sh --compiler intel --platform hatteras --component "ADCIRC WW3 ATMESH"
Angelos

Hi Angelos,
This is correct. Make sure to do a full cleaning before any compilation,
running:
./build.sh --compiler intel --platform hatteras --component "ADCIRC WW3
ATMESH" --clean 3
Takis
Panagiotis Velissariou, Ph.D., P.E.
UCAR Scientist
National Ocean and Atmospheric Administration
National Ocean Service
Office of Coast Survey CSDL/CMMB
Physical Scientist - Project Lead
cell:<PHONE_NUMBER>
email: @.***
On Mon, Nov 14, 2022 at 12:09 PM sarriegi @.***> wrote:

Hello @pvelissariou1 https://github.com/pvelissariou1 I am using esmf
version 8.0.1. Should I use a different version? I compiled CoastalApp with
an already pre installed parmetis library, by setting PARMETISHOME and
running the command:
./build.sh --compiler intel --platform hatteras --component "ADCIRC WW3
ATMESH"
Angelos
—
Reply to this email directly, view it on GitHub
https://github.com/noaa-ocs-modeling/CoastalApp/issues/146#issuecomment-1314174971,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APC7TP2XDWRR4O6YHDQ2Z4DWIJ557ANCNFSM6AAAAAASAAORZQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@Saeed Moghimi - NOAA Affiliate @.***> @sarriegi
The ESMF fields you have issues with:
wind_and_windstress_misalign_angle, wavz0, charnk, misalg
are not defined or used anywhere in CoastalApp or in ESMF.
So it should be some kind of customization from your part I think.
Takis
Panagiotis Velissariou, Ph.D., P.E.
UCAR Scientist
National Ocean and Atmospheric Administration
National Ocean Service
Office of Coast Survey CSDL/CMMB
Physical Scientist - Project Lead
cell:<PHONE_NUMBER>
email: @.***
On Mon, Nov 14, 2022 at 2:30 PM Panagiotis Velissariou - NOAA Affiliate <
@.***> wrote:

Hi Angelos,
This is correct. Make sure to do a full cleaning before any compilation,
running:
./build.sh --compiler intel --platform hatteras --component "ADCIRC WW3
ATMESH" --clean 3
Takis
Panagiotis Velissariou, Ph.D., P.E.
UCAR Scientist
National Ocean and Atmospheric Administration
National Ocean Service
Office of Coast Survey CSDL/CMMB
Physical Scientist - Project Lead
cell:<PHONE_NUMBER>
email: @.***
On Mon, Nov 14, 2022 at 12:09 PM sarriegi @.***>
wrote:

Hello @pvelissariou1 https://github.com/pvelissariou1 I am using esmf
version 8.0.1. Should I use a different version? I compiled CoastalApp with
an already pre installed parmetis library, by setting PARMETISHOME and
running the command:
./build.sh --compiler intel --platform hatteras --component "ADCIRC WW3
ATMESH"
Angelos
—
Reply to this email directly, view it on GitHub
https://github.com/noaa-ocs-modeling/CoastalApp/issues/146#issuecomment-1314174971,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APC7TP2XDWRR4O6YHDQ2Z4DWIJ557ANCNFSM6AAAAAASAAORZQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

@sarriegi
I suggest you to continue using the older version of the CoastalApp that works for you.  @pvelissariou1 need to make sure the minimal configuration for WW3+Atmesh is working 1st. When he finished with the test on his side then you may test your cases perhaps with your upgraded Atmesh.
cc @aliabdolali
Best
@saeed-moghimi-noaa

Thank you @saeed-moghimi-noaa and @pvelissariou1, I realized now that these fields come from an upgrade that Xuanyu Chen had made to the atmesh.F90 and atmesh_mod.F90 files.
Angelos


Fixed a memory leak in CloseSource

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


CI fails with Terra main branch

Information

Qiskit Optimization version: main (latest)
Python version: 3.6-3.9
Operating system: Ubuntu (CI)

What is the current behavior?
CI fails test.algorithms.test_min_eigen_optimizer.TestMinEigenOptimizer.test_samples_qaoa_2_qasm
It is due to Terra's QAOA change https://github.com/Qiskit/qiskit-terra/pull/6396
Details https://github.com/Qiskit/qiskit-terra/issues/6424 and https://github.com/Qiskit/qiskit-terra/issues/6425
Steps to reproduce the problem
https://github.com/Qiskit/qiskit-optimization/actions/runs/843965790
test.algorithms.test_min_eigen_optimizer.TestMinEigenOptimizer.test_samples_qaoa_2_qasm
---------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):

      File "/opt/hostedtoolcache/Python/3.6.13/x64/lib/python3.6/site-packages/ddt.py", line 182, in wrapper
    return func(self, *args, **kwargs)

      File "/home/runner/work/qiskit-optimization/qiskit-optimization/test/algorithms/test_min_eigen_optimizer.py", line 249, in test_samples_qaoa
    self.assertEqual(len(result.raw_samples), 32)

      File "/opt/hostedtoolcache/Python/3.6.13/x64/lib/python3.6/unittest/case.py", line 829, in assertEqual
    assertion_func(first, second, msg=msg)

      File "/opt/hostedtoolcache/Python/3.6.13/x64/lib/python3.6/unittest/case.py", line 822, in _baseAssertEqual
    raise self.failureException(msg)

    AssertionError: 28 != 32

What is the expected behavior?
CI passes the unit tests
Suggested solutions
We need to wait for update of Terra or merge #136

Fixed by #136


Update Version Files in edgex-go After Branch

After the edinburgh branch is cut the following version files need to be incremented to 1.1.0
https://github.com/edgexfoundry/edgex-go/blob/master/VERSION
https://github.com/edgexfoundry/edgex-go/blob/master/version.go

Why 1.1.0 and not 1.0.0?


MGMT-18490: Add shell completion to CLI RPM

Installs the BASH autocompletion script for Flightctl CLI via the RPM.

Just some comments, packaging needs some time, but fedora has excellent documentation for almost everything.


Parameter sidx null value in POST when using Grouping

I have a Datagrid with a quote complex QueryBuilder and groupingView setup:
    protected function getQueryBuilder()
    {
		$qb = $this->em->createQueryBuilder();
	    $qb->select(array(
	    		'PARTIAL c.{id, number}',
	    		'PARTIAL tke.{id, date}',
	    		'PARTIAL u.{id, email}'
	    	))
	    	->from('Entity\Contract', 'c')
	        ->join('c.timekeepingEntries', 'tke')
	        ->leftJoin('tke.user', 'u')
	    	->groupBy('c.id')
	    	->addGroupBy('tke.date')
	    	->addGroupBy('u.id')
	        ->orderBy('c.id', 'DESC')
	        ->addOrderBy('tke.date', 'ASC')
	        ->addOrderBy('u.email', 'ASC')
	    ;

       return $qb;
    }

Without Grouping the POST params look like this:
_search	false
nd<PHONE_NUMBER>822
page	1
rows	10
sidx
sord	asc

This is the POST params result after I added the groupingViewOptions:
_search	false
nd<PHONE_NUMBER>809
page	1
rows	10
sidx	c.number asc, null
sord	asc

            ->setQueryBuilder($this->getQueryBuilder())
            ->enableSearchButton(true)
            ->enableGrouping(true)
            ->setGroupingViewOptions(array(
            	'groupField' => ['c.number'],
            	'groupOrder' => ['asc']
            ))

Is my configuration wrong and causing the null value for sidx	c.number asc, null ?
This causes Doctrine to file after the request with:
[Semantical Error] line 0, col 279 near 'null ASC': Error: 'null' is not defined.

@zender I've seen you committing something to this bundle last month.
Wiill you continue to maintain it?
Maybe you could help me with this issue since the bundle suits my use case well and it only depends on the grouping config.
Thanks in advance!


[stable/jenkins] new configurable parameter to change nodeUsageMode value

Currently, the default value of nodeUsageMode is set to 'NORMAL'.
And we cannot change it whatsoever (at least I couldn't have found it for two hours ;) ) via configurable parameters passed to helm command, therefore one needs to remember to manually change that parameter in jenkins configuration site (kubernetes component).
This parameter is quite important one, as wrong value of it, can end up with accidental jobs execution on a wrong node - which might be really serious.
So this feature request is simple, I believe/hope, and would require to add new configuration parameter called e.g. agent.nodeUsageMode with default value NORMAL.
Thanks a lot,
Cheers
Tomek

Hi, is anyone able to tell me whether this ticket could be implemented or at least whether this ticket is formally well created?


Introduce legalName in the API

Part of https://github.com/opencollective/opencollective/issues/3689
Items with the :test_tube: icon are things that should be covered by unit tests.

[x] Add a legalName (string, default=null) field on the Collectives model
[x] The mutation(s) to edit accounts should accept a legalName as argument :test_tube:
[x] On GQLV2 Account object, add a legalName field. The resolver should take care of checking the permissions :test_tube::

[x] Field should always be visible for admin(s) of the account
[x] Field should always be visible for host accounts
[x] We should create a new SEE_LEGAL_NAME context permission and check it with getContextPermission

[x] Use setContextPermission for SEE_LEGAL_NAME in all contexts where we want to allow it :test_tube:

[x] For expense payees, if remoteUser has the host admin permissions
[x] For financial contributors, if remoteUser has the host admin permissions

[x] When generating the tax form on HelloWorks, use the legalName if available :test_tube:
[x] When submitting an expense, if legalName is defined, make sure it matches the payout method (bank account) :test_tube:

Extracted CSV implementation to a separate issue since it's a different service. This one is all done!

Oops, we still need to merge https://github.com/opencollective/opencollective-api/pull/6545 for it to be considered completed.

Oops, we still need to merge opencollective/opencollective-api#6545 for it to be considered completed.

Yes, I missed this one; I'll go through your final review for this today and hopefully we can merge it this week. 🙂

This is done


"LoadingServer is unreachable"

Homebrew install (brew install gorilla-cli), M3 MacBook Pro running macOS 14.4.
Just installed Gorilla, then when trying to run it, I get
tedneward@Teds-MBP-16 bin % gorilla say hello
⠹ LoadingServer is unreachable.
Try updating Gorilla-CLI with 'pip install --upgrade gorilla-cli'

But when I run pip (using pip3 since that's what was installed with my Python, which was also Homebrew-installed), I get:
tedneward@Teds-MBP-16 bin % pip3 install --upgrade gorilla-cli
error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try brew install
    xyz, where xyz is the package you are trying to
    install.

    If you wish to install a Python library that isn't in Homebrew,
    use a virtual environment:

    python3 -m venv path/to/venv
    source path/to/venv/bin/activate
    python3 -m pip install xyz

    If you wish to install a Python application that isn't in Homebrew,
    it may be easiest to use 'pipx install xyz', which will manage a
    virtual environment for you. You can install pipx with

    brew install pipx

    You may restore the old behavior of pip by passing
    the '--break-system-packages' flag to pip, or by adding
    'break-system-packages = true' to your pip.conf file. The latter
    will permanently disable this error.

    If you disable this error, we STRONGLY recommend that you additionally
    pass the '--user' flag to pip, or set 'user = true' in your pip.conf
    file. Failure to do this can result in a broken Homebrew installation.

    Read more about this behavior here: <https://peps.python.org/pep-0668/>

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 668 for the detailed specification.

Any hints or ideas what's going on in my Gorilla install?

Same here! Checkout https://github.com/ShishirPatil/gorilla/issues/436 Seems HTTPs certificate is expired
Btw seems there are 2 repos for same thing. But the one I created the issue in seems to have more recent activity. Though this one is the repo listed in PyPi's package metadata 🤔

I added verify=False to /opt/homebrew/Cellar/gorilla-cli/0.0.10_1/libexec/lib/python3.12/site-packages/go_cli.py
https://github.com/gorilla-llm/gorilla-
cli/blob/6e05036417b3bfe9dcf9ad00bb670161382ddb2d/go_cli.py#L246
I do not reccomend doing this. I just wanted to see the system work.

I added that to my installed copy, and it worked long enough to present me with the menu of options, then after selecting one there were all sorts of SSL errors, so I think that was my issue. I took the change back out, and I'll wait for a fix before proceeding with any further Gorilla exploration.

Hey Folks, thank you for raising the issue. This was indeed due to the https certificate having expired. I have renewed it now and everything should work as is. Thanks again @tedneward @davidlj95 @bdmorin for flagging this!!

I'm getting the same error, I'm running it on an ARM based mac too.

I hope you're good, I get the  ⠹ LoadingServer is unreachable message, running on Linux.

Fixed again https://github.com/ShishirPatil/gorilla/issues/668#issuecomment-2418939366


Update test deps (as of 2019-03-12Z)

This pull request derives from #537. So needs to be handled after that.

This pull request just updates Saxon 9.9 version used for testing.

@cirulls
Merged this test configuration update.


etcd: ability to enable/disable ETCD_PEER_CLIENT_CERT_AUTH

Some installation are failing to authenticate with peers due to
etcd picking up/resoling the wrong node.
By setting 'etcd_peer_client_auth' to "False" you can disable peer client cert
authentication.
Signed-off-by: Sébastien Han<EMAIL_ADDRESS>

Can we move ahead with this? That's a really simple patch that doesn't change the default behavior in any way.
Thanks in advance.

@mattymo

@ArchiFleKs, can we merge this? Thanks

@chapsuk, if you have time to look at this one too :) thanks!

ci check this

It seems that the CI error is unrelated to that PR.

LGTM and ci is green, but i don't know why it can be useful for production 😄
need one more +1 for merge

Thanks @ant31 and @chapsuk

@leseb I'm merging as it's harmless, but I'd rather fix the issue to pick up the right node.


Using with "numeric" type

Hello. I need to validate data of type "numeric" a.k.a. decimal or string of digits (see numeric type in postgresql). In schema v5 there is formatMinimum and formatMaximum, but it does not support "numeric" type. Using parseFloat in js is not an option, because you know the result of 0.1+0.2. Any suggestions?

You can define custom format "numeric" - it can have functions for both validation and for comparisons: https://github.com/epoberezkin/ajv#addformatstring-name-stringregexpfunctionobject-format

It would be nice if we have something like this by default, I think. Thank you!


List of loans to be modified in the Library catalogue

Loans_Documents_to_be_modified.xlsx

[ ] In Sheet loans, you'll find the ongoing loans currently linked with Migrated unknown item.
Column A: Loan PID
Column B: Item where to attach the loan
=> Please change the loans to the correct item

[ ] In Sheet documents, you'll find the manually migrated documents today.
Column A: CDS Recid
Column B: ILS pid
Column C: Creation date (when needed)
Column D: Type of record: ILSSYNC or Migrated
Column E: Indication when the initial record became a MULTIPART + VOLUMES (Not sure how you do the linking in this case)
=> Please Ensure the redirection is done correctly for the Migrated items, and linking is ok for ILSSYNC.

done


Help for using schema registry with protobuf in .Net

Different scenarios and questions to use schema registry with protobuf in .Net

How can we specify the key.subject.name.strategy and value.subject.name.strategy in .net?
How to set async serializer and deserializer for protobuf serializer? The serializer class is generated by protoc tool.
How can we specify the schema version when using Protobuf serialization with .net? Does specifying of version depend on the GUI setting from the control center for the topic?

Should both consumer and producer use the same serializer class generated by protoc tool?
If the consumer and producer want to use a different version (upstream or downstream), should the consumer and producer use the specific version serializer class?
Can we generate different class names other than the name specified in proto file? For example, I have used the user proto file from the sample, protoc generates c# class with name user, but I want to change it to ProducerUserMessage.

How can we specify the key.subject.name.strategy and value.subject.name.strategy in .net?

These are properties of the serializer config https://github.com/confluentinc/confluent-kafka-dotnet/blob/master/src/Confluent.SchemaRegistry.Serdes.Protobuf/ProtobufSerializerConfig.cs#L116 . Note that previously they were properties of SchemaRegistryConfig, but those have been depreciated.

How to set async serializer and deserializer for protobuf serializer? The serializer class is generated by protoc tool.

See the protobuf example: https://github.com/confluentinc/confluent-kafka-dotnet/blob/master/examples/Protobuf/Program.cs . note that on the consume side you need to use sync-over-async

How can we specify the schema version when using Protobuf serialization with .net?

The class you generate with protoc has an embedded schema. When you produce a message, schema registry is used to look up (or register) the id associated with that schema. this is done automatically behind the scenes. The settings you have a screen shot of come into play if you attempt to use a new schema (i.e. generate an updated class with protoc) - they determine when schema registry will reject the new schema as being incompatible.

Should both consumer and producer use the same serializer class generated by protoc tool?

The big idea with schema registry is that this is not required. i would recommend setting schema compatibility to full, then you can change either the producer or consumer schema (to within compatibility rules), and it will work (within the limitations of missing fields etc).

If the consumer and producer want to use a different version (upstream or downstream), should the consumer and producer use the specific version serializer class?

with protobuf, we only support 'specific' (i.e. strongly typed) serializers, so you must.

Can we generate different class names other than the name specified in proto file? For example, I have used the user proto file from the sample, protoc generates c# class with name user, but I want to change it to ProducerUserMessage.

I don't know off the top of my head, generally you wouldn't.

Thanks for the reply.
For the third question, you have replied that the schema registry will take care of by looking at the associated Id of the schema. Some follow up questions below.

Can a producer with a class generated for the user.proto (which has two fields) and consumer with class generated for the user.proto (which has three fields) can work seamlessly without any errors?
And if my service has both producer and consumer code, how can we or the system differentiate the serializer class because both of them have the same name(User)?


ported to 24w33a (1.21.2 snapshot)

thanks, looks good.
but gonna leave the pr open for now in case things change again in snapshots, will wait for major release to merge

closing due to #85 being merged


Add EOS Detroit as a startup

Hello,
Adrian Laurenzi directed me to this site through Detroit Blockchainers. We at EOS Detroit would love to join this Detroit startup community. Thanks!

Thanks for the pull request!! Welcome to the #StartupDetroit community!


DRILL-7474: Reduce size of Drill's tar.gz file

Excluded aws-java-sdk-bundle dependency, only required aws libraries added instead.
Cleared format-excel module from unused dependencies.

JIRA: DRILL-7474

@agozhiy is there any statistics how size has changed?

@arina-ielchiieva,
Before: 403942K
After: 308749K
(~93M difference)
Slightly bigger than in 1.16.0 (283120K), but not so critical (we have some new features after all).

Awesome! Thanks for making the changes.
Additionally tested S3 connection on your branch, everything works fine.
+1


check if, besides OrThrow, another "Thrower" is needed to include more context

OrThrow now replaces the chain of Exceptions with a new one.
Many stores the chain and silently moves on.
=> Look for other places, situations where these behaviours might improve the error reporting.

The current approach improves upon pre 1.1 error reporting. Given this new setup, the results can still be improved, but the minimal goal is achieved. Another redesign will be part of the 1.2 effort.


Different result in go and C function: LoadFontEx

Hi I'm struggling with text output and almost gave up.
And As I see main problem is function : LoadFontEx
It works in C, I took an example about text and have such string :
Font fontTtf = LoadFontEx("Ubuntu-Regular.ttf", 256, 0, 2048);
in the log output:

INFO: FILEIO: [Ubuntu-Regular.ttf] File loaded successfully
INFO: TEXTURE: [ID 3] Texture created successfully (16384x16384 - 1 mipmaps)

in Go I have such string:
	font := rl.LoadFontEx("Ubuntu-Regular.ttf", 256, &s, 2048)
and in the logs :
INFO: FILEIO: [Ubuntu-Regular.ttf] File loaded successfully
INFO: TEXTURE: [ID 3] Texture created successfully (512x512 - 1 mipmaps)

and of course there is no any output in the window of go version.
And all works perfect with C version.
I'm writing here because I see project looks alive and maybe some one has solution.
OS:
MacOS 11
arm64
Go:
1.16.3
go-raylib:
v0.0.0-20210424023010-5a21bdadf8d6

Today
I took the time to look at this issue

@vladimirschuka

No problems found on my macbook pro
OS:
MacOS 10.14.6
Intel i7
Can you give me the raylib c version commit you compared?

@vladimirschuka

Also tested on the M1 version of the macbook air, no problem
I used examples font_loading to test

Thank you.
Strange, I felt that it sounds silly,
I installed raylib from homebrew
brew info raylib
raylib: stable 3.5.0 (bottled), HEAD
Simple and easy-to-use library to learn videogames programming
https://www.raylib.com/
/opt/homebrew/Cellar/raylib/3.5.0 (18 files, 2.8MB) *
  Poured from bottle on 2021-04-25 at 23:46:22
From: https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/raylib.rb

Could you please give me a hint where I should look, to fix my problem.
Thanks a lot

Can you post the full code？
Or clone my project and run examples text font_loading

@vladimirschuka by the way, you shouldn't need to install raylib from homebrew. It comes with this library, so just running go get github.com/chunqian/go-raylib@master will install it where it needs to be for Go.

go get github.com/chunqian/go-raylib@master is not the latest commit
use go get -u github.com/chunqian/go-raylib
The full process and full code will be more helpful

Thank you guys.
I found a problem, I took example from another repository and now I understood that important 2 thing, what i missed:
1)
func init() {
	runtime.LockOSThread()
}

font := rl.LoadFontEx("Ubuntu-Regular.ttf", 32, nil, 2048)
befor it was
font := rl.LoadFontEx("Ubuntu-Regular.ttf", 32, &s, 2048) where &s is  &int32(0)


upstream: gradually decrease outlier detector's ejection time multiplier when host stays healthy

Commit Message:
gradually decrease outlier detector's ejection time multiplier when node stays healthy
Additional Description:
Each time a host is ejected by outlier detector, the ejection time is increased. That increased ejection time stays with the host and is never decreased. This PR adds logic to gradually decrease the ejection time when node stays healthy.
Risk Level: Low
Testing: Added unit test.
Docs Changes: Updated outlier detector section.
Release Notes: No
Platform Specific Features:
Fixes #6016

/retest

Needs main merge, thanks.
/wait

/retest

/retest

max_ejection_time with default 30s may break compatibility
FYI https://github.com/istio/istio/issues/30181

@cpakulski Why is the default value enforced for "max_ejection_time" instead of retaining the old behaviour if "max_ejection_time" is not provided. I understand the intent of adding the max_ejection_time and it is a good change. However it breaks people (see https://github.com/istio/istio/issues/30181)  if base_ejection_time is set above 5m (the default value of max_ejection_time)
How about

Enforcing max_ejection_time only when it is explicitly provided or base_ejection_time < 5m (the default max_ejection_time if not provided) otherwise leave the current behaviour as is.

WDYT?
cc: @mattklein123 for your thoughts as well?

@ramaraochavali What is exactly the problem? Are the nodes ejected prematurely?

No the problem is config is rejected by Envoy

Let me check, but it should not be rejected. The max ejection time should be capped at base_ejection_time and never increase (if base_ejection_time > max_ejection_time) or max_ejection_time is not specified.

@cpakulski More details, This is the error we are getting "outlier detector's max_ejection_time cannot be smaller than base_ejection_time" when it is rejected.
This validation is failing https://github.com/envoyproxy/envoy/blob/de8c5059baf575aaafdcc42572f7b019824987ba/source/common/upstream/outlier_detection_impl.cc#L286
I think we should skip that validation if max_ejection_time is not set.
Since you get defaulting it here https://github.com/envoyproxy/envoy/blob/de8c5059baf575aaafdcc42572f7b019824987ba/source/common/upstream/outlier_detection_impl.cc#L254 by the time it gets there it will always have value. Probably you should capture if it is set or not in a boolean and skip this

I am working on the fix and would like to keep the logic fairly clean. First I will add unit test which fails and then correct it.

The issue is fixed in https://github.com/envoyproxy/envoy/pull/14962.

@cpakulski Thank you so much.


Emoji parser enforces a space delimiter

I am just wondering why the emoji parser enforces the space delimiter in https://github.com/lunet-io/markdig/blob/master/src/Markdig/Extensions/Emoji/EmojiParser.cs#L84-L88.
I guess I would like to remove this restriction so I can have md like:
A sentence :smiley:.
Or another sentence :smiley:, more text.

I don't remember exactly why I required this in the first place. Maybe that's not a necessary condition, but will need some tests...

@xoofx submitted #89, I have added a couple more tests, but you may want more, not sure ?


fixed example code

The sample code in the README.md file was missing a colon to work :)

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   71.37%   71.37%
=======================================
  Files           5        5
  Lines         262      262
=======================================
  Hits          187      187
  Misses         63       63
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0cdc72...bc71a04. Read the comment docs.


Export an outlook email to Html and send it by KP

Hello,
i've prepare an email on outlook, and i want to send the same email with the same texte format contents (signature)
I export the email to html with outlook save as option, when i try to use the email and send it by using KP, it return an error, is there any tool to convert outlook (html) emails to KP format,

The King Phisher message format is HTML, it's just enhanced with templating from the Jinja 2 engine. I was not able to reproduce this problem. My guess is that if the HTML is looking invalid when loaded as a message template it is probably due to the complexity used by outlook. You should try to remove unnecessary HTML and then reload it into King Phisher.

Thank you i'ev tried to copy the html outlook code on KP html email editor, i've just a probleme how can i  add an attached email to email signature,  i mean i've a logo to be added to the signature and it must be sended as attached file , how can i attache it ,

Read the wiki on how to embed images into messages. I recommend the second technique, the local one.

I'm using the second technique but how can i apply some html format on the image
ex :

The jinja function inserts it's own img tag. If you want to add formatting you need to do something that wraps the img tag / inline_image function.

can you take a look at the sended txt file

No I can not. This is an issue with your HTML and not an issue with King Phisher itself. I can't help you create your template, we have plenty of resources and references to help you. Look through the wiki in the King Phisher repo and the example templates in this repo.
If you run into an issue with King Phisher itself then we can talk.


Add Travis.yml file for testing

Please do not merge this until the Travis goes green.  Which is trickier than it sounds.

That's got it!


FY2020Q4 content refresh

includes content refresh from FY2020Q3
run through all exercise steps in associated MSLearn module to validate good working order
update code samples to reflect MSLearn HOL exercise refresh & updates
updated steps & fixed typos where necessary
updated slides where necessary

NOTE: all IDs and users are from M365 demo tenants. No PII present

Looks like that's not necessary... those were used to show the underlying REST calls, but I don't see it in the exercise either.


VCRedist 2010 full version number not detected by Winget

Brief description of your issue
Latest VCRedist 2010 x64 in winget-pkgs is 10.0.40219.

https://github.com/microsoft/winget-pkgs/tree/master/manifests/m/Microsoft/VCRedist/2010/x64
(This is actually 10.0.40219.**325**)

Problem is that there have been several releases 10.0.40219.x, but Winget does not seem to detect the 4th version number position. Newest right now: 10.0.40219.473.

https://github.com/abbodi1406/vcredist/tree/master/source_links#microsoft-visual-c-2010-redistributables---v10
https://learn.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?view=msvc-170#visual-studio-2010-vc-100-sp1-no-longer-supported

Output from winget list vcredist
C:\Users\olavb>winget list vcredist
Name                                                               Id                           Version       Source
---------------------------------------------------------------------------------------------------------------------
Microsoft Visual C++ 2013 Redistributable (x86) - 12.0.40664       Microsoft.VCRedist.2013.x86  12.0.40664.0  winget
Microsoft Visual C++ 2015-2022 Redistributable (x86) - 14.34.31931 Microsoft.VCRedist.2015+.x86 14.34.31931.0 winget
Microsoft Visual C++ 2015-2022 Redistributable (x64) - 14.34.31931 Microsoft.VCRedist.2015+.x64 14.34.31931.0 winget
Microsoft Visual C++ 2010  x64 Redistributable - 10.0.40219        Microsoft.VCRedist.2010.x86  10.0.40219    winget

C:\Users\olavb>

Adding a newer version to winget-pkgs probably would likely not offer users with previous versions installed an upgrade.
This behavior from Winget is probably expected, because the uninstall registry info does not have all the info to properly detect the full version number.
Screenshot from registry

A workaround to get full version info is:
Get-ItemPropertyValue -Path 'Registry::HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\VisualStudio\10.0\VC\VCRedist\x64' -Name 'Version'

Anyways, is there anything winget-cli can do, or should do, to be able to catch edge cases like this? Add ability for custom detection methods maybe?
Steps to reproduce
Install: winget install --id Microsoft.VCRedist.2010.x64 --silent
List: winget list Microsoft.VCRedist.2010.x64
Expected behavior
Full version number is displayed.
Actual behavior
4th digit/position of the version number is missing, thus can't validate whether newer versions are available.
Environment
Windows Package Manager v1.4.10173
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.19045.2486
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.19.10173.0

Since the version number in the current manifest is missing its 4th tuple, this should be updated to append .325.
Since a new version 10.0.40219.473 is available, a new manifest for it should be submitted, so it can be installed with Winget.

I'm not sure that's the best solution here.
WinGet is going to use the "displayVersion" from Windows Apps & Features for comparison.
If the installer isn't writing the full value to the registry, the comparison logic will create a false positive for the latest version being installed for any users with an earlier version where the reported value matches.

If the installer isn't writing the full value to the registry, the comparison logic will create a false positive for the latest version being installed for any users with an earlier version where the reported value matches.

I believe it's actually even worse than that - creating a false negative. Versions are treated as if they have an infinite number of trailing .0. This is why 1.0.0 and 1.0 are considered equal. I believe what would end up happening if the 4th number was set would be that the PackageVersion would always be greater than the DisplayVersion, since 10.0.40219.473 is greater than 10.0.40219.0 (Trailing 0 shown for clarity), which would result in an upgrade loop.

That's different from how .NET treats version numbers, where 1.0.0 would be considered newer than 1.0.
If sorting [System.Version[]]('1.0','1.0.0') descending, 1.0.0 ends on top. And [system.version]('1.0') -eq [system.version]('1.0.0') is $false

.NET version numbers appear to have 4 tuples, and fill with -1s when not specified:
PS C:\> [System.Version]'1.0'
Major  Minor  Build  Revision
-----  -----  -----  --------
1      0      -1     -1

PS C:\> [System.Version]'1.0.0'
Major  Minor  Build  Revision
-----  -----  -----  --------
1      0      0      -1


Accuracy of Released Image Classification Models

Dear @rkrasin,
Thank you for your fantastic Data Set. Would you please kindly inform us the accuracy (i.e., F1-Score) of your released models (i.e., ResNet 101 image classification model and Inception V3 model) on validation set?

Hi @ahkarami,
thank you for your kind words. While I played my part, the dataset is a work of many people, and most thanks should go to the Google management that funded the work and have the permission to release that much internal knowledge.
As for the accuracy of the most recently released models, I think @nalldrin has the most to say. After all, I left Google in May 2017, and no longer in the loop.

Dear @rkrasin,
Thank you for your time and response.

@ahkarami after some thought, the answer to your question can be obtained in a dyi fashion:

Download validation set images from Google Cloud Storage, as described in: https://github.com/cvdfoundation/open-images-dataset#download-images-with-bounding-boxes-annotations
Run the classifier on each of the image (optionally, with a few random crops)
Compute the score you want.

I will do it myself on the weekend, unless someone gets the score published before that.

So, as promised, I have started doing so, and realized that the images are not actually publicly released. The registration form at CVDF website has to be signed before any pixels are released.
I plan to document the steps required to get the access for the benefit of everyone else. The alternative way is to use Google Cloud Transfer Service. That will take about a week, so I will first try the CVDF hosted option.
The first thing I did is to fill out the form as below:
Name: Ivan Krasin
Organization: Myself
Gmail / Gmail Associated Account<EMAIL_ADDRESS>Usage of Dataset (e.g. training object detector for academia research): unrestricted use

I expect the request to be denied based on my answer about the usage of the dataset. In that case, I will go the slow path.

Actually, I've already have the email that says the request is approved:
Hello,

Thanks for signing up to download Open Images Dataset. This is a confirmation that you successfully register to download the dataset.Please follow the instruction on the Github page to download the dataset.

All images have a CC BY 2.0 license. Note that CVDF does not own the copyright of images and the image license is subject to change by the image owner.

If you have any question, please contact<EMAIL_ADDRESS>
Best,
Common Visual Data Foundation

Nice!

And indeed, the access works:
$ gsutil ls gs://open-images-dataset/
gs://open-images-dataset/test/
gs://open-images-dataset/train/
gs://open-images-dataset/validation/

$ gsutil ls gs://open-images-dataset/test/*.jpg | wc -l
125436

Then I have copied the images on my Google Compute Engine instance. Not the most optimized chain of command-line commands, but here we are:
$ mkdir -p ~/out/openimages/{test,validation}
$ cd ~/out/openimages/test
$ gsutil -m rsync gs://open-images-dataset/test/ .
<wait for 15 minutes>
$ ls | wc -l
125436
$ cd ~/out/openimages/validation
$ gsutil -m rsync gs://open-images-dataset/validation/ .
<wait for 5 minutes>
$ ls | wc -l
41620

Note that test + validation sets are 50 GB in total.
The next step is to run both classifiers (v1 and v2) on all images and produce two CSV files for later analysis. I will probably skip all further details until the scores are obtained. The critical step, getting the images, confirmed to be working.

Hi, sorry for not noticing this thread sooner. A few points of clarification. First, we are providing the image classification checkpoints more as a courtesy than to serve as a competitive baseline model and we haven't provided any official guidance as to how to evaluate them. That said, internally we tracked the AP and mAP scores over the validation+test sets: .587 and .506 respectively for the v2 checkpoint. You should be able to approximately reproduce this by calculating it yourself over the test+val sets.

For what it's worth, I downloaded the v2 checkpoint:
#! /bin/bash

mkdir -p /tmp/open_image/checkpoint/
wget -nc -nv -O /tmp/open_image/checkpoint/oidv2-resnet_v1_101.ckpt.tar.gz\
    https://storage.googleapis.com/openimages/2017_07/oidv2-resnet_v1_101.ckpt.tar.gz

cd /tmp/open_image/checkpoint
tar -xvf oidv2-resnet_v1_101.ckpt.tar.gz

and simply ran these metrics on the predictions:
    from sklearn import metrics
    metric_dict['micro_map'] = metrics.average_precision_score(labels.ravel(), scores.ravel())
    average_precision = [metrics.average_precision_score(labels[:, i], scores[:, i]) for i in range(scores.shape[-1])]
    average_precision = [np.nan_to_num(a) for a in average_precision]
    metric_dict['macro_map'] = np.mean(average_precision)

and I got losses and predictions with something like this:
    sess = tf.Session()
    g = tf.get_default_graph()
    with g.as_default():
        saver = tf.train.import_meta_graph(checkpoint_path + '.meta')
        saver.restore(sess, checkpoint_path)

        input_values = g.get_tensor_by_name('input_values:0')
        predictions = g.get_tensor_by_name('multi_predictions:0')
        true_labels = tf.placeholder(
            dtype=tf.float32, shape=[None, _NUM_CLASSES], name='labels')

        # using a TF Record generator here...
        data = data_generator(_SPLITS_TO_PATHS[split], repeat=False, parser=parser)

        stored_predictions = []
        stored_labels = []
        for idx, v in enumerate(data):
            images = v['image']
            labels = v['label']
            preds = sess.run(predictions, feed_dict={
                input_values: images,
                true_labels: labels
            })

            stored_predictions.append(preds)
            stored_labels.append(labels)

I get AP of 0.423 and 0.424 on the validation and test sets respectively, and mAP of 0.088 and 0.0892. Would be good if someone else can confirm or validate these results/code?
I was easily able to fine-tune the last layer of InceptionV3 and achieve mAP of 0.541 and 0.542 on validation/test and AP of 0.447 and 0.433.

Dear @btaba,
Thank you very much for your answer. I think your work is really valuable. However, I think your obtained results (especially mAP) is so low. As I remembered, I got F1-Score ~ 34.2% after only 15 epochs of training a customized ResNet50 model on the validation set (but with my own special training code on PyTorch, which I have used many tricks on it). By the way, your work is really valuable.
As Open Images is a Multi-Label Image Classification data set, so I recommend you to report your results via F1-Score. You can easily report it via sklearn library, something like below:
from sklearn.metrics import fbeta_score beta = 1.0 fbeta_score(true_labels, predictions > threshold, beta, average='samples')

@ahkarami I also computed F1 for a threshold of 0.5, but I think AP and mAP may be more useful since they don't depend on the threshold. Nevertheless, I get 0.423/0.424 on validation/test for micro F1 and 0.088/0.089 for macro F1 for the resnet checkpoint. For the fine-tuned Inception v3 I get 0.515/0.515 and 0.372/0.377 for micro and macro F1 respectively.

Dear @btaba,
Thank you for your useful information. Just as a note, I remembered that threshold of 0.3 would be better for the ResNet checkpoint.
Thank you

@ahkarami I also computed F1 for a threshold of 0.5, but I think AP and mAP may be more useful since they don't depend on the threshold. Nevertheless, I get 0.423/0.424 on validation/test for micro F1 and 0.088/0.089 for macro F1 for the resnet checkpoint. For the fine-tuned Inception v3 I get 0.515/0.515 and 0.372/0.377 for micro and macro F1 respectively.

Thanks for your test. Was "the fine-tuned Inception v3" trained on the validation dataset or train dataset? I wonder why it could achieve much higher mAP than the released resnet101 model?

Hi, sorry for not noticing this thread sooner. A few points of clarification. First, we are providing the image classification checkpoints more as a courtesy than to serve as a competitive baseline model and we haven't provided any official guidance as to how to evaluate them. That said, internally we tracked the AP and mAP scores over the validation+test sets: .587 and .506 respectively for the v2 checkpoint. You should be able to approximately reproduce this by calculating it yourself over the test+val sets.

Could you comment on why @btaba got a much smaller mAP? Used different mAP definition? Thanks.

Just a note on the released checkpoint: it was trained primarily using the
machine generated labels (I used human verifications if available,
otherwise machine predictions). No fine-tuning on human verifications was
performed. So it's easy to see how the mAP and other metrics can be
massively improved by a little fine-tuning.
-Neil
On Wed, Oct 10, 2018, 8:17 AM Mengye LYU<EMAIL_ADDRESS>wrote:

Hi, sorry for not noticing this thread sooner. A few points of
clarification. First, we are providing the image classification checkpoints
more as a courtesy than to serve as a competitive baseline model and we
haven't provided any official guidance as to how to evaluate them. That
said, internally we tracked the AP and mAP scores over the validation+test
sets: .587 and .506 respectively for the v2 checkpoint. You should be able
to approximately reproduce this by calculating it yourself over the
test+val sets.
Could you comment on why @btaba https://github.com/btaba got a much
smaller mAP? Used different mAP definition? Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openimages/dataset/issues/59#issuecomment-428613615,
or mute the thread
https://github.com/notifications/unsubscribe-auth/Aa9xhSpSW5INUAlBQ4fdEQYfumR8QKqQks5ujg-UgaJpZM4Q3fKg
.

@nalldrin makes sense.
@mylyu I trained on the train set exclusively. Predicted 5000 classes, but I believe the whole dataset was updated recently.


is mapValues called on skipped lines?

Documentation Is:

[ ] Missing
[ ] Needed
[x] Confusing
[ ] Not Sure?

Please Explain in Detail...
I am a little unclear on whether the mapValues function is called for skipped lines.
I assumed that it would not be called for skipped lines, but when writing some tests it seems like the mapValues function is being called for a skipped line.
My test data:
t,u,v,w
a,101,1.02,2.02
b,101,1.03,2.03

My csv-parser.Options :
  opts: {
    headers: [ 'id', 'timestamp', 'x', 'y' ],
    skipLines: 1,
    mapHeaders: [Function: mapHeaders],
    mapValues: [Function: mapValues]
  }

The error I see in my mapValues function when I run my tests.
    Error during date parsing: {
      filePath: '/xxx/tests/custom-headers.csv',
      header: 'timestamp',
      value: 'u',
      index: 1,
      opts: {
        headers: [ 'id', 'timestamp', 'x', 'y' ],
        skipLines: 1,
        mapHeaders: [Function: mapHeaders],
        mapValues: [Function: mapValues]
      }
    }

Your Proposal for Changes
I think it's fair to assume that the mapValues function would skip the number of lines defined by the skipLines option.
If this is not the intent, and you don't agree that it's fair to assume that the mapValues function would not be run on skipped lines, then please close this ticket.
If it is the intent of the parser to skip these lines then either I am doing something wrong or there's a bug.
If the library was designed to run the mapValues function on skipped lines but you agree that it is a fair assumption that it shouldn't, then we should update the documentation to let users know that mapValues will be run on skipped lines.
Thanks!

Doesn't look like there are any tests for mapValues that use the skipLines option.


Fix leaky tests.

Introduced by:
https://github.com/flutter/flutter/pull/150721
https://github.com/flutter/flutter/pull/150661

I'm curious what the leak is here? Those FocusNodes are instantiated within each test. What's leaking outside of the tests?

I see this already got an approval, but without answering my question. Please don't merge this until someone explains what's being leaked in the tests.

I'm curious what the leak is here? Those FocusNodes are instantiated within each test. What's leaking outside of the tests?

Leak tracker watches that every disposable, created by the test's callback, is disposed. And there is no way for it to detect if the disposable is test-only. There are some huristics to detect a helper method in the testing library.
The focusNode is created inside the test's callback and never disposed. So there is a question if it may be the tested feature created forgot to dispose a disposable.
Does this help?

So you're saying there's some kind of tracker that's identifying non-leaks as possible leaks?
If so, isn't the better answer to improve that tracker?
Did you look at the specific changes that you made? Were there any actual leaks, or were you just making changes so that the inspector stopped complaining?

Ah... Approved before seeing your comment @matthew-carroll. I approved because leak or not I personally think it's good practice to dispose of disposables.

I approved because leak or not I personally think it's good practice to dispose of disposables.

I think the question is - is there actually an opportunity for leaks? I don't generally think it's a good practice to add code that isn't needed and doesn't solve anything. Otherwise, that code tends to become untouchable because nobody is quite sure why it exists.
So I'm still trying to get an answer to my originally question. Does anyone know if there's actually a single leak in this code?

I approved because leak or not I personally think it's good practice to dispose of disposables.

I think the question is - is there actually an opportunity for leaks? I don't generally think it's a good practice to add code that isn't needed and doesn't solve anything. Otherwise, that code tends to become untouchable because nobody is quite sure why it exists.
So I'm still trying to get an answer to my originally question. Does anyone know if there's actually a single leak in this code?

The answer depends on definition of a leak.
For me it is clear why this code exist. There is de-facto rule: if a piece of code creates disposable object, it should take care about disposing it.

The answer depends on definition of a leak.
For me it is clear why this code exist. There is de-facto rule: if a piece of code creates disposable object, it should take care about disposing it.

If you're enforcing a standard policy, and you want to keep enforcing it, that's up to you. But no, the definition of a leak isn't amorphous. Either dangling references exist in memory after the test completes, or they don't. Either there is a leak, or there isn't. I haven't seen any comment so far that identifies an actual leak. All I've heard is that there's some tool which automatically flags any objects with a dispose() method for which the dispose() method is not explicitly called in a test. That does not imply a leak.

And yes, there is a tool that auto-detect not-disposed objects.

I would suggest considering an improvement to that tool so that it doesn't refer to a bunch of non-leaks as leaks. And/or I would include a written policy about how every test is expected to work with disposables. If that policy already exists, please feel free to link that here.

The answer depends on definition of a leak.
For me it is clear why this code exist. There is de-facto rule: if a piece of code creates disposable object, it should take care about disposing it.

If you're enforcing a standard policy, and you want to keep enforcing it, that's up to you. But no, the definition of a leak isn't amorphous. Either dangling references exist in memory after the test completes, or they don't. Either there is a leak, or there isn't. I haven't seen any comment so far that identifies an actual leak. All I've heard is that there's some tool which automatically flags any objects with a dispose() method for which the dispose() method is not explicitly called in a test. That does not imply a leak.

And yes, there is a tool that auto-detect not-disposed objects.

I would suggest considering an improvement to that tool so that it doesn't refer to a bunch of non-leaks as leaks. And/or I would include a written policy about how every test is expected to work with disposables. If that policy already exists, please feel free to link that here.

Yes, leak tracker catches not leaks, but risks of a leak, we are just shortening the phrasing. Even if a test is not leaking, but some objects are not disposed, there can be code paths that create actual leaks.


PulltoRefresh occasionally breaks click events in iOS Safari

We use PulltoRefresh in our web-app and ran into an issue where click events on certain elements were sometimes not firing in Safari on iOS (latest version, 15.3.1).
The situation occurred then clicking/tapping elements within the PulltoRefresh mainElement. The touchstart, touchmove, and touchend events would always fire correctly. They should be followed by mousedown, mouseover, and click events, but in some cases that would not happen.
After some debugging, this turned out to be caused by PulltoRefresh recognising a pull gesture, and cancelling the other events. When that became clear, it was easily resolved by setting PulltoRefresh’s distIgnore option to a higher value than the default of 0 (I went with 10).
In our situation, this issue would occur even when using an Apple Pencil and touching the screen very short and lightly. I.e., from my perspective, this was definitely not a pull gesture, though apparently the browser recognised it as such.
I want to report this here so others can be aware of this, and don’t need to go debugging so much as I had to do.
Additionally, its might be useful to add a warning about this in the readme file with the distIgnore option, or even use a higher default value than 0 perhaps?

iOS has been notoriously for changing their behavior every couple of versions. Since I don't have access to the Apple Pencil, I think someone that has experienced the issue and done the research would be better to add a troubleshooting section in the readme, would you be willing to do that?
Another idea that might work is using the shouldPullToRefresh callback, there you could listen to the events and block the pull to refresh if some specific behavior doesn't look like a pull to refresh.
Thanks for the heads up, it's really good seeing someone doing their research.

I can confirm that this is happening on safari iOS


Complete rewrite of API wrapper:

updated to v1 API
revised class / method names (sorry, new interface is v similar)
composer installer
update readme file with basic usage
cleaner code

Not all API functionality is fully contained in this wrapper, and not documented on our api.buckybox.com
Please contact<EMAIL_ADDRESS>for fuller details.

@infertux - can you merge this into the master branch. I still don't permissions to merge it, don't know why. Noooooooob.

Nice work cleaning up that code @dangermouse117 :+1:


Fix AppVeyorCI build

http://www.us.apache.org/ mirror doesn't archive Maven versions :'(

:white_check_mark: Build jmxtrans 104 completed (commit https://github.com/jmxtrans/jmxtrans/commit/501bb2f5fb by @gquintana)

I would suggest #650 as a slightly more standard option for the same result...

The Maven Wrapper is a brilliant solution to this problem. <3

Brilliant might be a strong word, but yeah, it is nice...


Can't list datashare accounts

Describe the bug
I just installed datashare extension and trying to play a little to get familiar with it. The first command throws and exception.
Command Name
az datashare account list Extension Name: datashare. Version: 0.1.0.
Errors:
'expiresIn'
Traceback (most recent call last):
python3.6/site-packages/knack/cli.py, ln 215, in invoke
    cmd_result = self.invocation.execute(args)
cli/core/commands/__init__.py, ln 654, in execute
    raise ex
cli/core/commands/__init__.py, ln 718, in _run_jobs_serially
    results.append(self._run_job(expanded_arg, cmd_copy))
...
    result = func(*args, **kwargs)
core/pipeline/policies/_authentication.py, ln 93, in on_request
    self._token = self._credential.get_token(*self._scopes)
azure/cli/core/adal_authentication.py, ln 64, in get_token
    return AccessToken(token, int(full_token['expiresIn'] + time.time()))
KeyError: 'expiresIn'

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az datashare account list --resource-group {}

Expected Behavior
Environment Summary
Linux-4.15.0-1089-azure-x86_64-with-debian-stretch-sid
Python 3.6.10
Installer: DEB

azure-cli 2.7.0

Extensions:
datashare 0.1.0

Additional Context

@jiasli can you take a look at the AccessToken error message? Is it related to https://github.com/Azure/azure-cli/issues/9427?

It is caused by track2 support issue in azure cli core and I am fixing it now.

The fix https://github.com/Azure/azure-cli/pull/14187 is done. please try with azure cli 2.9.1.


Release <IP_ADDRESS>

Hey folks,
I was just wondering why there is no release for version <IP_ADDRESS>?
Good stuff you're doing here!
Max

Oh sorry will prepare both for 2.4.1 and 2.50

So release <IP_ADDRESS> and <IP_ADDRESS>


Fix Arches Core bug causing card & widget order to not be honoured

Resolved this in arches core release 7.4.0


How to deal with ArrayCollections / ObjectSelect

I am using Formidable as an alternative to ZF3 forms and am liking it for its simplicity. However, I am wondering how to use it in more complicated forms?
For instance, if I have an Entity: Customer that has an option to select multiple Products, how do I go about doing this with Formidable?
In ZF3 I would create something like this:
$this->add(
[
'type' => 'DoctrineModule\Form\Element\ObjectSelect',
'name' => 'products',
'options' => [
'object_manager' => $this->objectManager,
'target_class'   => 'Domain\User\Products',
],
'attributes' => [
'multiple' => true,
]
]
);
When creating my form, it would have a multi-select option with all the products in it.
I am struggling to work out how to do this with Formidable?
Any suggestions would be appreciated!

Sorry for the late reply, I was too distracted with life :)…
In Formidable, you'd create a RepeatedMapping which would wrap around a normal FieldMapping, to which you'd assign a formatter which resolves IDs (from the select) to actual entities and the other way around.


CORS error on Vercel

When deploying on Vercel, seems that CROS error has reoccurred due to same-origin policy

even I added cros middleware in server side. The entry in development will be like
require('dotenv/config')
const express = require("express")
const cors = require("cors")
const app = express()

const routes = [require("./routes/warps"), require("./routes/player")]

app.use(cors()) // Remember to use cors to allow testing internally.
app.use("/api", routes)

// You could also set something up like so to use one off endpoints
// api.use("/api/importWarps", "./importWarps.js")
console.log('Please be aware that API URL under production mode will be',process.env.VITE_API_URL)

app.listen(3000)

Also I'll try to handle these code gracefully between prod&dev builds later for this method looks quite cubersome.

Added envDir and defined the envDirhelped me achieve getting the same env variable on both C/S sides, which means Vite can handle all env vars while in Node(Server) side you still need to keep an eye on features provided by dotenv.
export default defineConfig({
  plugins: [vue()],
	envDir: '../',
  resolve: {
    alias: {
      '@': fileURLToPath(new URL('/client/src', import.meta.url)),
    },
  },
})

https://vitejs.dev/guide/env-and-mode.html#env-files
https://vitejs.dev/config/shared-options.html#envdir

Added environmental variables in Vercel and redeployed it in production mode manually solve this problem successfully.
Please make sure in the Vercel setting:

General -> Build & Development Settings: set Output Directory to /client/dist/ and set Install Command to pnpm install --frozen-lockfile=false, both override original values
Enviromental Variables: add new variable with "VITE_API_URL" as key and "https://astral-express-test.vercel.app/api/importWarps?" as value, the base url should be reaplaced to your deployment domain under production.


ML model

The current model is a model I made using Teachable Machine.
A better model, maybe a custom one built by someone, would be better.
If any changes to the model are made, please

make changes to ./model/model.py.
make sure that the output format is correct on the output page.
change README.md by removing 'Teachable Machine' from the text. (If the model is built by someone else.)
add any more details to CONTRIBUTING.md for local project setup.

Problems with the current model: #5


Remote start from Lovelace yaml producing error

I’m getting the following error when trying to remote start from the Lovelace ui:
‘remote_start command failed for Subaru Ascent: Climate preset 'None' does not exist‘
I built the UI per the YAML example.
I’m assuming something else is needed?  I see references to climate in the separate service section of the readme- so probably user error on my part (apologies!)

You'll need to make a climate preset selection first (using the select.<vehicle_name>_climate_preset entity) before attempting remote start. See https://github.com/G-Two/homeassistant-subaru/issues/41

Closing as stale / nothing to fix.


Improve Item transformation performance

From profiling, these areas would have the most effect if improved:

Refdata mapping, especially the hybrid type
Stripping strings from whitespace

Not perfect, but much better. @banerjek


Can I install with HACS?

Is it possible to install this addon with HACS?

No, only on Hass Operating system / Hassio


python get stuck after error

Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

Description of the bug
I hope this is the right place to arise a problem,
I'm using pyaedt with Maxwell,
When I execute a wrong string in python the console gets stuck and I need to kill the Maxwell process.

Steps To Reproduce
For example,
m3d = Maxwell3d(projectname='test', designname='test', non_graphical=False, new_desktop_session=True)
m3d['sim_I_peak'] = 'pwl()'
Which Operating System are you using?
Windows
Which Python version are you using?
3.8
Installed packages
pyaedt 0.6.55

@cristianbabetto Hello, the problem is that once you connect to an aedt session you need to release it correctly otherwise it won't allow it. This is a limitation of the AEDT API.
Few workarounds:

use release_desktop method at the end. if the method fails you can still reconnect to that session (maybe with another call to Maxwell3d and then release it
use the with. Example
with Desktop() as d:
m3d = Maxwell3d(projectname='test', designname='test', non_graphical=False, new_desktop_session=True)
m3d['sim_I_peak'] = 'pwl()'

in this way any error in the with will trigger the exit (which will trigger the release_desktop).
I hope it helps
Massimo

@maxcapodi78 I tried 23R1 with the latest pyaedt 0.6.55 on one of my PC and I got this error, but I have never noticed this issue. In fact, on my second PC with 21R2 and pyaedt 0.6.22 I get an error but the console is still responding so that I can enter a correct command or execute further commands. I uninstalled 23R1 for space reasons so now I can't try again but I'm quite sure that this strange behavior was not present in the past. I worked a bit with pyaedt and I remember I was able to "try commands and retry again" without this problem.
Please, let me know.

@maxcapodi78 Could you please confirm or not that in the previous combination of Maxwell 21R2 and pyaedt 0.6.22 there were no issues like this?

Hi @cristianbabetto ,
We can not reproduce this issue, I think as @maxcapodi78 mentioned, the AEDT session was not correctly released. Please try again, in version 23.1, PyAEDT is connecting AEDT through GRPC, you can disable it and use the legacy COM:
import pyaedt
pyaedt.settings.use_grpc_api = False
app = pyaedt.Hfss(specified_version="2022.2", non_graphical=False, new_desktop_session=True)
app.release_desktop()
Please close the issue if you think it could be closed.

Thanks for tour support.


Disable acceleration 3D

My cellphone doesn't support acceleration 3D and the app closes soon after execution. Have some way to disable the animations that need acceleration 3D?
09-02 11:52:22.323 29796-30424/chat.rocket.android E/AndroidRuntime: FATAL EXCEPTION: RecordFBO GL render
Process: chat.rocket.android, PID: 29796
Theme: themes:{}
java.lang.RuntimeException: eglCreatePbufferSurface: EGL error: 0x3005
at io.repro.android.grafika.gles.b.a(Unknown Source)
at io.repro.android.grafika.gles.b.a(Unknown Source)
at io.repro.android.grafika.gles.c.a(Unknown Source)
at io.repro.android.grafika.gles.g.(Unknown Source)
at io.repro.android.p$b.e(Unknown Source)
at io.repro.android.p$b.run(Unknown Source)`

This issue may be caused by Repro SDK, which is removed in #36


LANTERN-726: Added a day check to handle the 31st of the month special case (Integration test bug)

Pull requests into this repository require the following checks to be completed by the submitter and reviewers.
Submitter:

[x] Administrative tasks are complete.

This pull request describes why these changes were made.
The JIRA ticket links to this PR.
The JIRA ticket for this PR is:

[x] Tests are complete.

Tests are included and test edge cases.
Tests have been run locally and pass.

[x] Code review has been performed.

Code diff has been done and checked to ensure only expected code is being committed.
A linter for the language has been run.

Primary Reviewer:

[ ] Code works.

Code has been run locally and the basic functionality affected by the PR has been checked.
Edge cases have been checked to ensure behavior is as expected.

[ ] Code review has been performed.

Code is maintainable, reusable, efficient, and correct.
Code accomplishes the tasks purpose.
Code follows style guidance appropriate for the language, including passing linter checks.
Code is well commented (which does not mean verbosely commented).

[ ] Tests are complete.

Tests are included and test edge cases.
Tests have been run locally and pass.

Merger:
Prior to merging, ensure that all checks have been completed. Delete the branch after the merge
is complete.

@rishi-salunkhe-mettle Reviewed and Approved based on 382, please assign within Mettles for Github PR Reviewer approval


Transaction Submission Sizes

Transaction Submission Size Limits(2kb, 3kb, 4kb, 5kb?). Will be good to have a max size to avoid accidental sends on rogue TXs and to prevent maliciously large TXs

single TX size set to 3kb


Problem with spline16

I use:
# Imports
import vapoursynth as vs
core = vs.get_core()
# Loading Plugins
core.std.LoadPlugin(path="I:/workspace/Hybrid/debug/64bit/vsfilters/Support/fmtconv.dll")
core.std.LoadPlugin(path="I:/workspace/Hybrid/debug/64bit/vsfilters/SourceFilter/FFMS2/ffms2.dll")
# source: 'F:\TestClips&Co\files\test.avi'
# current color space: YUV420P8, bit depth: 8, resolution: 640x352, fps: 25, color matrix: 470bg, yuv luminance scale: limited, scanorder: progressive
# Loading source using FFMS2
clip = core.ffms2.Source(source="F:/TestClips&Co/files/test.avi",cachefile="E:/Temp/avi_078c37f69bb356e7b5fa040c71584c40_853323747.ffindex",format=vs.YUV420P8,alpha=False)
# making sure input color matrix is set as 470bg
clip = core.resize.Point(clip, matrix_in_s="470bg",range_s="limited")
# making sure frame rate is set to 25
clip = core.std.AssumeFPS(clip=clip, fpsnum=25, fpsden=1)
# Setting color range to TV (limited) range.
clip = core.std.SetFrameProp(clip=clip, prop="_ColorRange", intval=1)
original = clip
clip = core.fmtc.resample(clip=clip, kernel="bicubic", w=1280, h=704, interlaced=False, interlacedd=False)
original = core.fmtc.resample(clip=original, kernel="bicubic", w=1280, h=704, interlaced=False, interlacedd=False)
# adjusting output color from: YUV420P16 to YUV420P8 for FFvHuffModel (i420@8)
clip = core.resize.Bicubic(clip=clip, format=vs.YUV420P8, range_s="limited")
# adjusting for FilterView
if (original.format.id != clip.format.id):
  if (original.format.color_family == vs.RGB and clip.format.color_family != vs.RGB):
    original = core.resize.Bicubic(clip=original, format=clip.format.id, matrix_s="470bg", range_s="limited")
  elif (original.format.color_family == clip.format.color_family):
    original = core.resize.Bicubic(clip=original, format=clip.format.id, range_s="limited")
  else:
    original = core.resize.Bicubic(clip=original, format=clip.format.id, matrix_in_s="470bg", range_s="limited")
stacked = core.std.StackHorizontal([original,clip])
# set output frame rate to 25.000fps
stacked = core.std.AssumeFPS(clip=stacked, fpsnum=25, fpsden=1)
# Output
stacked.set_output()

which works fine.
Problem is when I replace:
clip = core.fmtc.resample(clip=clip, kernel="bicubic", w=1280, h=704, interlaced=False, interlacedd=False)
original = core.fmtc.resample(clip=original, kernel="bicubic", w=1280, h=704, interlaced=False, interlacedd=False)

with:
clip = core.fmtc.resample(clip=clip, kernel="spline16", w=1280, h=704, interlaced=False, interlacedd=False)
original = core.fmtc.resample(clip=original, kernel="spline16", w=1280, h=704, interlaced=False, interlacedd=False)

preview in Vapoursynth Editor crashes (no error editor just closes).
Using:
VSPipe.exe -p --y4m c:\Users\Selur\Desktop\test.vpy e:\Test.y4m

it sometimes crashes for example at "Frame: 274/429" (no error) and other times it runs through the clip.
Is this a bug or am I doing something wrong here?

Correction, this does not seem to be related to the kernel. Same happens with bicubic, seems problem seems to happen when core.fmtc.resample is used multiple times in a script.

Thank for the report. I’m going to check this.

I tried to reproduce the issue but I couldn’t make it crash. Did you encounter this kind of crash with other scripts or videos?

Just tried, still crashes here.
Using a different source and a different source filter and changing the script to:
# Imports
import vapoursynth as vs
core = vs.get_core()

# Loading Plugins
core.std.LoadPlugin(path="I:/Hybrid/64bit/vsfilters/Support/fmtconv.dll")
core.std.LoadPlugin(path="I:/Hybrid/64bit/vsfilters/SourceFilter/LSmashSource/vslsmashsource.dll")

# loading source
clip = core.lsmas.LibavSMASHSource(source="G:/TestClips&Co/files/5000frames.mp4")

# resizing
original = clip
clip = core.fmtc.resample(clip=clip, kernel="spline16", w=1280, h=960, interlaced=False, interlacedd=False)
original = core.fmtc.resample(clip=original, kernel="bicubic", w=1280, h=960, interlaced=False, interlacedd=False)
# original = core.resize.Bicubic(clip=original, width=1280, height=960) # <- Works

# stacking
stacked = core.std.StackHorizontal([original,clip])

# Output
stacked.set_output()

it still crashes for me, attached the file I used:
5000frames.zip
Tried a few other sources too.
Cu Selur

Deems to be a threading issue, since when using core = vs.get_core(1) instead of core = vs.get_core() it works,...

Still no luck at reproducing the crash. I tried with and without Avstp, in 32 and 64 bits, with different number of threads on Vapoursynth… I’ll try to find a Ryzen machine to make some tests on AMD.

I tried this on a Ryzen 3600, no crashes. Maybe this is also related to your video source somehow. Can you upload a samlpe?
p.s. you should use core = vs.core instead of vs.get_core() as it is deprecated :-)

I'm also unable to reproduce this with the source and scripts provided on a Ryzen 3700X (VS-53 and dlls from their respective github pages).

Okay, a few things:

I realized, vspipe works fine it's just vsviewer&vsedit that crash.
VSPipe.exe -p c:\Users\Selur\Desktop\test.vpy e:\deleteMe.raw works fine
when using core = vs.core instead of vs.get_core() vsViewer/vsedit do not crash.

-> no clue why this is happening on my systems, but using core = vs.core is a usable workaround for me. :)


SCT logo is now being copied to the installation folder {SCT_DIR}

Requirements

[*] Is there a issue open describing the motivation for this pull request ?
[ ] Does the pull request need an update of the documentation ?
[ ] Does the pull request need additional test(s) ?
[ ] Clean up the warnings generated by the style guide

Description of the Change
Added the necessary code to copy {SCT_DIR}/documentation/imgs/* , this would avoid the import error for sct_plugins (flseye)
Steps and Constraints
[The steps of reproducing the pull request]
Applicable Issues
Implements or Fixes #1868

Pull Request Test Coverage Report for Build 8882

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 2.184%

Totals

Change from base Build 8878:
0.0%

Covered Lines:
508

Relevant Lines:
20184

💛  - Coveralls

Pull Request Test Coverage Report for Build 8882

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 2.184%

Totals

Change from base Build 8878:
0.0%

Covered Lines:
508

Relevant Lines:
20184

💛  - Coveralls

Pull Request Test Coverage Report for Build 8882

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 2.184%

Totals

Change from base Build 8878:
0.0%

Covered Lines:
508

Relevant Lines:
20184

💛  - Coveralls


ENYO-1094: Made changes so that pause and time display position correctly when RTL ...

...applied
Issue:
Pause and Time display positions are swapped when RTL applied.
Fix:
Made required changes in CSS/LESS so to support correct behavior.
Enyo-DCO-1.1-Signed-off-by: Rakesh kumar<EMAIL_ADDRESS>

PR on master isn't required


Add possibility to configure radvd valid lifetime

Before this pull request can be accepted you must first sign a CLA as described at https://www.pfsense.org/about-pfsense/#cla. Please read for more details.

Changed the pull request according to your feedback

Point taken on the defaults, but the possibility exists that the default in radvd will change silently or does not conform with the documentation, at which point the help text is misleading. If the default is configured explicitly in an else {} block, there is no ambiguity as the default you claim will be 'baked in' to the generated radvd configuration.

Yeah okay, you're right. I'll do another pull request soon


ae01.alicdn.com should not be blocked

if you block ae01.alicdn.com, no pictures of the products are displayed when browsing aliexpress
consider removing it from the list

Hi @mgx0.  The domain ae01.alicdn.com is blocked by virtue of Dan Pollock who curates his list at someonewhocares.org.
You can reach him at pollock at theorem.ca.
Closing.


integral_image_generic to support specific memory manager

Was this not working?

Hi Davis
It was working, but unfortunately I have to wait for approval of our legal
department which is now, as I learned, a standard process before
contributing to open-source projects.
As soon as that is approved, I will reopen the PR, unless you will have
done those trivial changes yourself.
Thank you for your understanding and have a nice day.
Lukas
On Wed, Mar 17, 2021 at 10:43 AM Davis E. King @.***>
wrote:

Was this not working?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/davisking/dlib/pull/2324#issuecomment-800980206, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AIZFLRHBSAUNKTDSBAHJGB3TECBUTANCNFSM4ZHDAHNQ
.

No worries, I’ll wait for you to get approval  :)


psycopg2 -> psycopg2-binary

Psycopg2 is deprecated for 2 years now. It's one of the dependencies in this library.
In my project I use psycopg2_binary-2.8.4. Then your dependency, psycopg2-2.8.4, breaks my setup because it can't find pg_config.
Please just change this dependency. I don't think you should expect any regressions.
My current workaround is to install your package with --no-deps.

psycopg2 is not deprecated at all.
I've already opened and closed the PR #85 about psycopg2-binary
As you can read from the author of psycopg in the documentation:

Note: The psycopg2-binary package is meant for beginners to start playing with Python and PostgreSQL without the need to meet the build requirements.
If you are the maintainer of a publish package depending on psycopg2 you shouldn’t use ‘psycopg2-binary’ as a module dependency. For production use you are advised to use the source distribution.

https://www.psycopg.org/docs/install.html#binary-install-from-pypi
I suggest to you to use psycopg2 in your projects too.

Thanks for linking to the source. You are right.
It would be a nice feature to require only one of of those two packages but I don't think is doable.
I stand corrected. Thank you.


Add hooks for Cloud-J repository for use with GEOS-Chem

Name and Institution (Required)
Name: Lizzie Lundgren
Institution: Harvard University
Describe the update
This PR brings in the infrastructure for including and building Cloud-J which is needed for GEOS-Chem 14.3.
NOTE: This PR requires that Cloud-J is added to mepo to clone GEOS-ESM/Cloud-J branch geos/develop as new directory Cloud-J/@Cloud-J.
Expected changes
See the GEOS-Chem 14.3.0 version page.
Required companion PRs

https://github.com/GEOS-ESM/geos-chem/pull/4
https://github.com/GEOS-ESM/HEMCO/pull/12

Tagging @christophkeller

Please merge into branch geos/latest_gcc

Looks fine. I can update the relevant components.yaml once this is merged. Two things:
@lizziel would you mind updating the changelog?
@mmanyin It would be good to get the ok from you on the new Cloud-J repo, too.

@christophkeller Thanks for the chance to look things over. In the latest release of this repo, directories like GMI and TR don't exist, they are populated from separate repo's during the 'mepo clone' step.  Contrast that with the approach taken here, where a Cloud-J subdirectory is introduced as part of the Chem repo...  Is the difference due to the fact that we have full control over GMI and TR, while we need a thin layer between the Cloud-J distribution and GEOS, to make them play well together?  Perhaps @mathomp4 would care to comment.

@mmanyin, I created a subdirectory for Cloud-J to contain the Cloud-J repo populated during mepo clone in order to keep the GEOS-specific CMakeLists.txt file out of Cloud-J. This is how we do it for GEOS-Chem and HEMCO which is why I chose to do it this way.

@mathomp4, I will push updates to changelog this afternoon. I just realized this PR also includes a HEMCO-related update for compatibility with my HEMCO and GEOS-Chem PRs that go with this.

Once everything is in, I'll give it a go. CMake is pretty flexible. One question. Are these:
set (MODEL_GEOSCHEM TRUE) # Will need to rework to use with GMI instead
set (MAPL_ESMF TRUE)

used internally in the Cloud-J CMake? I just don't see anything using them in this PR.

@mathomp4, changelog is now all set. Yes, MODEL_GEOSCHEM and MAPL_ESMF are used within the Cloud-J repository.


Window Resizing (OSX)

I don't seem to be able to resize the window past certain points. Please see attached gif.
OSX 10.10.5

@paradox41 I'll look into that. it could be electron bug.

Great! Thanks for looking into it. If it is a bug with electron, I'm
willing to file it there as well.
On Oct 23, 2015 1:33 PM, "Prince John Wesley"<EMAIL_ADDRESS>wrote:

@paradox41 https://github.com/paradox41 I'll look into that. it could
be electron bug.
—
Reply to this email directly or view it on GitHub
https://github.com/princejwesley/Mancy/issues/22#issuecomment-150640908.

@paradox41 Its not a electron bug. Fix will be available in v2 branch.

Awesome. Thank you for the quick turn around.
On Oct 23, 2015 1:40 PM, "Prince John Wesley"<EMAIL_ADDRESS>wrote:

@paradox41 https://github.com/paradox41 Its not a electron bug. Fix
will be available in v2 branch.
—
Reply to this email directly or view it on GitHub
https://github.com/princejwesley/Mancy/issues/22#issuecomment-150642747.

Merged to master


Add context databases

What
Add context databases info including sale counts, last sold info, etc.

:tada: This PR is included in version 1.40.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Implement quickcheck::Arbitrary for data types

Alright, here's a go at #286. This adds a quickcheck-gen feature (it can't be just quickcheck because it also needs to enable rand - unless you require the user to also enable rand explicitly) and a subcrate time-quickcheck-tests that tests that feature.
I've intentionally left Instant out since it seems like values of that type aren't intrinsically meaningful on their own. It also seems quite easy to obtain an Instant from a Duration if needed, and that type does get an Arbitrary implementation.

I'll take a look at this when I get a chance.
Don't worry about the CI status right now; I had a change on the v0.3 branch that accidentally broke some things.

If you rebase on the v0.3 branch, you should be able to trivially add quickcheck-gen to the std,rand group, which would add it to CI without doubling the number of checks run.

I'm not sure what you mean, I don't see anything like that in Cargo.toml. Maybe I'm not familiar enough with Cargo...

One thought about the license files: Should the author name be changed to "Jacob Pratt et al."? That would (correctly) indicate that I'm not the sole copyright owner.

Sounds like a reasonable idea. Do you also want to do something to the authors fields in the Cargo.toml files? I don't think my contributions here are enough for me to be considered an author of the library proper, just wondering your thoughts on the time-benchmarks/Cargo.toml file for example.

Overall, things look good!

Thanks!

If you rebase on the v0.3 branch, you should be able to trivially add quickcheck-gen to the std,rand group, which would add it to CI without doubling the number of checks run.

I'm not sure what you mean, I don't see anything like that in Cargo.toml. Maybe I'm not familiar enough with Cargo...

This is in the .github/workflows/build.yaml file. There are a couple lines with --group-features there; I think it'll make more sense once you see that.

One thought about the license files: Should the author name be changed to "Jacob Pratt et al."? That would (correctly) indicate that I'm not the sole copyright owner.

Sounds like a reasonable idea. Do you also want to do something to the authors fields in the Cargo.toml files? I don't think my contributions here are enough for me to be considered an author of the library proper, just wondering your thoughts on the time-benchmarks/Cargo.toml file for example.

Adding people to the "authors" fields is presumably something that you just know when it's the time to do. Though adding a generic "time contributors" is never a bad idea.
With regard to the benchmarks, I believe you're already listed there!

If you rebase on the v0.3 branch, you should be able to trivially add quickcheck-gen to the std,rand group, which would add it to CI without doubling the number of checks run.

This is in the .github/workflows/build.yaml file. There are a couple lines with --group-features there; I think it'll make more sense once you see that.

Oh, ok, did you mean the serde,rand group?

With regard to the benchmarks, I believe you're already listed there!

Yeah, since I did write all of that sub-crate, I took the liberty of claiming authorship of that one. ^^ But I figured while we're on the subject I'd ask your thoughts on it. I don't know how likely it is that I'll remain the "main" author as it continues evolving in the future, but I guess it's just a matter of adding new ones when it seems appropriate.

Oh, ok, did you mean the serde,rand group?

Yeah, just looked over the previous comment and I'm not sure why I put that.

Yeah, since I did write all of that sub-crate, I took the liberty of claiming authorship of that one. ^^ But I figured while we're on the subject I'd ask your thoughts on it. I don't know how likely it is that I'll remain the "main" author as it continues evolving in the future, but I guess it's just a matter of adding new ones when it seems appropriate.

Absolutely! If it ever truly matters (which realistically is unlikely), I'd just switch the order of the names. As it's not published on crates.io, it's less of an issue.

Also, just ran across this post on Reddit. Perhaps it may be possible to use the quickcheck feature name after all, so long as the internal name is changed (which can ironically be changed right back with a simple use statement).

Nice find! That does indeed seem to work quite fine.

One question as I'm just about done with the history and verification: The implementation for UtcOffset appears to be able to generate UtcOffset { seconds: -86_400 } as values. Am I correct in this reading? If so, removing the - 1 on the generation of the range would make this not the case, correct?

Ping @emlun — it's just the question in my previous comment that is blocking merging this.

Oh, sorry, I didn't notice. I'd say no, since the subtraction happens before the negation, so with size = 86_400 the lower bound would be -(86_400 - 1) = -86399.
However, there is indeed another bug here: with size = 0, the range ends up being [1, 0) which is invalid and causes a panic. I'll fix that.

I figured you just didn't see it — no big deal. I've just cleaned up history again, and will merge this pending CI.

Great, thanks! :smile:


The input field of the document ID doesn't display when creating a document for one Mongo account

Repro Steps:

Drill down one Mongo account -> Database -> Collection.
Right click one collection and select 'Create Document'.
Check whether the input field of the document ID displays or not.

Expect:
The input field of the document ID displays.

Actual:
The input field of the document ID doesn't display and no 'id' displays in the created document.

Looks like a duplicate of #381.

This isn't a dupe of 381, but it is by design. See https://github.com/Microsoft/vscode-cosmosdb/issues/477


Supertest fails on Content-Type

Supertest says the content-type is text/plain, but when I use Postman or Chrome devtools and check the network tab, it correctly shows the content-type as text/html.
describe('Core controller unit tests:', function() {
    before(function(done) {
        request = request('http://localhost:3001');

        done();
    });

    describe('Loading the homepage', function() {
        it('should return 200 from GET /', function(done) {
            request
                .get('/')
                .expect('Content-Type', /html/)
                .expect(200, done);
        });
    });

    after(function(done) {
        done();
    });
});

@gjohnson this still doesn't work for me..I'm positive my content-type is correct, can you take a look at this?

@gjohnson when using an API tester like the Postman Chrome app, I get the content-type as text/html, so what is going on exactly?

+1 always getting  "text/html; charset=utf-8" no matter what I do.
    it('should respond with a 200 if the posted body is valid', function(done) {
        request(app)
            .post('/user/', {
                json: true,
                body: helpers.getUser()
            })
            .set('Accept', 'application/json')
            .expect('Content-Type', /json/)
            .expect(function(response) {
                debugger;
                response.res.json.id.should.eql('123');
            })
            .expect(200)
            .end(done);
    });

app.post('/user/', validate({body: helpers.getUserSchema()}), function(req, res) {
   res.set('Content-Type', 'applicaton/json');
   res.json({
        id: '1234'
    });
});

same here

@gjohnson any status on this?

@ilanbiala not sure it will help, maybe you should try setting the accept header of your supertest request.
    request(app)
            .get('/')
            .set('Accept', 'application/json')
            .expect('Content-Type', /json/)
            .expect(200, done);

@ilanbiala can you attach the sample Postman request and response (with headers) that is working for your example? Is there some server redirect that is happening with the requests as that could change the response types.
We use expect Content-Type in almost all our tests and it works for json, html, etc.

Hi all, I don't think there is anything wrong with supertest, or superagent.
Here is a quick test file I wrote that shows things working as they should for a basic express set up.
var request = require('supertest')
  , express = require('express');

var app = express();

app.post('/user/json', function(req, res) {
   res.set('Content-Type', 'application/json');
   res.json({
        id: '1234'
    });
});

app.post('/user/html', function(req, res) {
   res.set('Content-Type', 'text/html');
   res.send('id: 1234');
});

describe('POST /user/json', function(){
    it('should respond with a json 200 response setting Accept header', function(done) {
        request(app)
            .post('/user/json', {
                json: true,
                body: '{"id":"100","name":"Mike"}'
            })
            .set('Accept', 'application/json')
            .expect('Content-Type', /json/)
            .expect(200)
            .end(done);
    });
    it('should respond with a json 200 not setting Accept header', function(done) {
        request(app)
            .post('/user/json', {
                json: true,
                body: '{"id":"100","name":"Mike"}'
            })
            .expect('Content-Type', /json/)
            .expect(200)
            .end(done);
    });
});

describe('POST /user/html', function(){
    it('should respond with an html 200 response setting Accept header', function(done) {
        request(app)
            .post('/user/html', {
                json: true,
                body: '{"id":"100","name":"Mike"}'
            })
            .set('Accept', 'application/json')
            .expect('Content-Type', /html/)
            .expect(200)
            .end(done);
    });
    it('should respond with an html 200 not setting Accept header', function(done) {
        request(app)
            .post('/user/html', {
                json: true,
                body: '{"id":"100","name":"Mike"}'
            })
            .expect('Content-Type', /html/)
            .expect(200)
            .end(done);
    });
});

Does supertest match Content-Type: application/json; charset=/whichevercharset/ with .expect('Content-Type', /json/) ?
What should I write to make it do it ?

@danielmihai  yes if you pass a regex as the second argument to .expect it will match in your example.
ie:
.expect('Content-Type', /json/)  will match application/json; charset=utf-8

Just FYI for other dummies like me whose tests failed on .expect("Content-Type", /json/)
My mistake was refactoring this bit of code from
res.status(statusCode).send(err); // err is an object

to
res.status(statusCode).send(message); // string from the err object

When the correct way would be
res.status(statusCode).send({ message, });

By default if the data is not inside curly brackets it will be rendered as html, not json. And the reason why I couldn't see it with Postman was because it still sends err-objects while in development environment, not test. Every day I relearn something new...

`request(app)
.get('/')
.expect('Content-Type','text/html; charset=utf-8')
.end(done);
});

while work perfectly whereas request(app)
.get('/')
.expect('Content-Type','text/html')
.end(done);
});`

won't work because the http header received adds an encoding of utf-8

You could use a regexp to match your expected content type. /text/html/
would pass your test.
On Tue, Mar 28, 2017 at 2:18 PM, Simo<EMAIL_ADDRESS>wrote:

`request(app)
.get('/')
.expect('Content-Type','text/html; charset=utf-8')
.end(done);
});
while work perfectly whereasrequest(app)
.get('/')
.expect('Content-Type','text/html')
.end(done);
});`
won't work because the http header received adds an encoding of utf-8
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/visionmedia/supertest/issues/187#issuecomment-289738784,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABzKA4SGG70kSVqw3EBhJRtGNTpkvr37ks5rqOyVgaJpZM4DFFa6
.

it is work to return as json~
describe('Loading the homepage', function() {
      it('should return 200 from GET /', function(done) {
            request
            .get('/')
            .set('Content-Type', 'application/json')
            .expect(200, done);
       });
});

Had this error in an older project using https://www.npmjs.com/package/express-force-https ... not a very popular package, but it will cause Express to always return 302 with html/text when using Supertest. With the tests expecting Content-Type of /json/ of course. Easy fix was to not use this package in test env. Commenting here in the off chance it saves someone else several hours of googling and debugging.

@LeoLiu1209 Thank you. Your solution works perfectly for me. I've to comment out .expect('Content-Type', /json/) and the test run smoothly but when I deleted the line that I 've commented out the test failed. Why is that? I'm a newbie.
describe('POST /api', function() {   it('responds with json', function(done) {     request(app)       .post('/api')       .send({url: 'https://google.com'})       .set('Content-Type', 'application/json')       // .expect('Content-Type', /json/)       .expect(200)       .end(function(err, res) {         if (err) return done(err);         done();       });   }); });

Had the same problem. Just need a little bit of code refactoring.
What solved the problem for me was:
Didn't pass:
notesRouter.get('/', (request, response) => { 	response.send('
Hello World!
') })
Passed:
notesRouter.get('/', (request, response) => {   const message = '
Hello World
' 	response.json({message}) })

Same error any help please
describe('GET /api/auth/:id',()=>{
it('should return user by id in database',async()=> {
const id = 2

const res = await app.get(/api/auth/${id})
res.should.have.a('object')
})
})

JOB
GET api/job/:id
should return  post by id:
Uncaught AssertionError: expected 'text/html; charset=utf-8' to include 'application/json'
at /home/felex/DevCon/test/jobs.test.js:74:21
at Test.Request.callback (node_modules/superagent/lib/node/index.js:716:12)
at IncomingMessage. (node_modules/superagent/lib/node/index.js:916:18)
at IncomingMessage.emit (node:events:539:35)
at endReadableNT (node:internal/streams/readable:1345:12)
at processTicksAndRejections (node:internal/process/task_queues:83:21)

I'm getting error on testing .Any help please

Thanks @mikelax!
.post('/campaignunits/1/tvschedule', {
                json: true,
                body: '{ data: "test" }'
            })
            .set('Accept', 'application/json')

works without any errors.


Install stand-alone program via Setuptools “entry points”

The Setuptools “entry points” feature parses a specified Python callable, and will at install time set up external entry points. For “console scripts” this installs a stand-alone program for the specified entry point.
Please add a “console_scripts” entry point to install a stand-alone ‘adventure’ program.

This requires resolution of issue #7 to allow import of the __main__ module.
At https://notabug.org/bignose/python-adventure/commits/feature/wip/stand-alone-program (specifically, https://notabug.org/bignose/python-adventure/commit/7e0ade5342ae6f3fd1a0b1c677b7e5338c34d31e) is my suggested change to address this.

Since this is a sample Python 3 project, I prefer to advertise its Python-ness very strongly by having folks invoke it explicitly through python3 -m …. Or, better yet, by playing from the Python prompt. I am not interested in competing with the official C version of Colossal Caves, which is what I hope folks will install when they want a normal system command that lets them play Adventure, so to avoid competition with the original let’s keep invoking this Adventure with Python.