Add set_cover_position support in cover/command_line

Description:
The set_cover_position support is achieved by appending the position number (1~100) after the command_set_position command.
In my case, I'm using a http GET request to control my cover. The command_set_position is set as "curl -X GET http://mycoverurl/set/" in my configuration. So if I need to set the position at 50, it will execute command "curl -X GET http://mycoverurl/set/50".
Also, something like this needed to add in const.py to make this work:
CONF_COMMAND_SET_POSITION = "command_set_position"
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for configuration.yaml (if applicable):
  - platform: cmd_line_v2
    covers:
      test_cover:
        command_open: "curl -X GET http://mycoverurl/cw"
        command_close: "curl -X GET http://mycoverurl/ccw"
        command_stop: "curl -X GET http://mycoverurl/stop"
        command_state: "curl -X GET http://mycoverurl/stat"
        command_set_position: "curl -X GET http://mycoverurl/set/"

Checklist:

[x] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @francofff,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

Could not find a documentation PR related to this PR. Added docs-missing label.

This PR is targeting master branch. Please open a new PR based off dev branch that targets the dev branch.


StadiaController isn't recognized anymore

So I used the pad for a year now, but it just stopped being recognized by Windows 11.
I even installed a fresh copy of Windows 11, but to no avail.
Software I installed:
-VC Redist x64
-WinDesktopRuntime 6.0.6 x64
-ViGEmBus_1.21.332_x64_arm64
-stadiacontroller.exe & ViGEmClient.dll
-StadiEm
-StadiaWireless
Normally I'd start "stadiacontroller.exe", a cmd window would pop up telling me the pad has been recognized.
Now I don't get any notes in the cmd, it just stays empty and the pad isn't recognized.
I also installed the following software, which can detect my PS4, but alas not the Stadia controller:
-DS4 Windows
-XOutput
-JoytoKey
-x360ce
Any idea why the stadiacontroller.exe isn't working anymore?
Edit:
In x360ce I can check if a pad is detected and it is indeed. It recognizes and visually displays of my inputs.
I also can add my Stadia controller to map buttons. This seems to work from all the mentioned software.

Unfortunately I don't have my Stadia controller anymore so I can't troubleshoot. Does x360ce recognize all inputs, including the analog values?
My understanding (which might be wrong and/or outdated) is that USB devices can be acquired exclusively by software. If some software is getting exclusive access to the controller, stadiacontroller won't be able to connect to it.
The Stadia controller, on top of the raw USB interface, also sends "standard" controller events that can be recognized without stadiacontroller, but those are limited (notably, some analog inputs aren't recognized as such).
Hopefully this helps troubleshoot the problem.


Node-Sass 4.5.3 download url fail

Hi
We have a build server that build our web app.
It is failing due to the node-sass package not being able to be downloaded.
Previous Url (Worked 100%)
https://github.com/sass/node-sass/releases/download/v4.5.3/win32-x64-57_binding.node
Url Now (Not working)
https://github.com/sass/node-sass/releases/download/v4.5.3/win32-x64-64_binding.node
This is a big issue for us because our build server does not cache npm packages so this is failing
Please regard this as urgent
Kind Regards
Pieter du Buisson

You need<EMAIL_ADDRESS>for Node 10 support.
On Tue., 15 May 2018, 10:16 am TechedImpala<EMAIL_ADDRESS>wrote:

Hi
We have a build server that build our web app.
It is failing due to the node-sass package not being able to be downloaded.
Previous Url (Worked 100%)
https://github.com/sass/node-sass/releases/download/v4.5.3/win32-x64-57_binding.node
Url Now (Not working)
https://github.com/sass/node-sass/releases/download/v4.5.3/win32-x64-64_binding.node
This is a big issue for us because our build server does not cache npm
packages so this is failing
Please regard this as urgent
Kind Regards
Pieter du Buisson
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/sass/node-sass/issues/2380, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAjZWK0yz8_pIpkatWFM7gEJ0M3-THarks5tyo7ggaJpZM4T_FjK
.


Chips

🗒 General
Would love if someone could help us add chips to our Storybook. We've got two versions that differ by size. Functionality follows Material-UI's chips.

💻 Usage
These are meant to be used as tags or as indicators of what's been selected in a dropdown!

📐 Specs
You can access specs in our Figma UI Kit. Click on the 'Chips' page on the left hand side.

🔮 Future

Can I work on it ? 👍

Thanks @ayshiff


issue under retainer invoice edit page

[x] after cloning the amount on the retainer invoice edit page . the updated data not showing in edit page

issue closed


Using @bugsnag/js with cypress

code in test.cy.js
describe('My First Test', () => {
  it('Does not do much!', () => {
    var Bugsnag = require('@bugsnag/js');
    Bugsnag.start({
      apiKey: Cypress.env("API_KEY"),
    });
    Bugsnag.notify(new Error(`Error example`), null, (err, event) => {
      if (err) {
        console.log('Failed to send report because of:\n' + err.stack);
      } else {
        console.log('Successfully sent report "' + event.errors[0].errorMessage + '"');
      }
    });
  })
})

console till log Successfully sent report Error example, but bugsnag dashborad never show it. And i can't see any error

Hi @daiaimfirst, Would you be able to write in to<EMAIL_ADDRESS>with some details about you Bugsnag account, namely which organisation and project do you expect this error to appear in. If you could also share the API key you are using that would be helpful.

Hi @johnkiely1. Thank you
I was find the reason. it seems Cypress test case doesn't use nodejs engine (browser). And here is my solution https://docs.cypress.io/api/commands/task (Execute code in Node)


scrypt support in generate_password_hash/check_password_hash

Starting with Python 3.6, scrypt (RFC 7914) is available in the standard library as hashlib.scrypt. As it is a more recent, arguably "safer" alternative to PBKDF2, it would be splendid to be able to use it for password hashes as well.
Due to it's nature, it is not available via hashlib.new('scrypt', …) and, thus, would require extra support in Werkzeug, similar to PBKDF2.
Since Werkzeug requires at least v3.6 of Python anyway, older versions need not be handled.
I couldn't dig up any previous discussions about it. Has this been considered and evaluated before?

If you need extended hashing support, use Passlib.

Fair enough.
For the record, I suggested adding support for it because it would not introduce a new dependency and spare users from having to install Passlib while still getting easy access to a "modern" PBKDF (as bcrypt isn't available without an additional dependency).

I'm not referring to a new dependency when I refer to "added complexity". Just adding more paths for special cases in generate_password_hash is more complexity on its own. For most applications, generate_password_hash will be just fine. For anyone considering upgrading their security from there, they'll want to use Passlib anyway for all the other features it provides.

I'm not referring to a new dependency when I say "adding support". Just adding more paths for special cases in generate_password_hash is more complexity to support.

I had read it that way, and I agree. Thank you for clarifying nevertheless.

I haven't heard about passlib before so I looked them up

Source: last commit is less then a week ago; 14 contributors
PyPI
Eli Collins: Main developer
StackOverflow: 39 questions

Although there are other contributors, there seem not to be that many.

https://github.com/pallets/werkzeug/issues/2654


Research on Wikidata

Wikidata will be used in the project and its need to be make a research about it!

Thank you @tutkubayri , Im closing the issue


Remove Travis CI

Removes Travis in favor of only using Github Actions
Closes #365

The failure here is fixed by #366


Fixes numerous issues.

Closes #3: Should handle unknown characters in dashboard event output more
gracefully.
Closes #8: Now returns event count after filtering, except for with JS
expressions.
Closes #9: Q now exits dash.
Closes #12: Help should now have consistent capitalization.
Closes #7: Scope run now has more examples.
Closes #4: Commands which fail validation now print help.
Closes #1: Failed executions now prompt to clean empty session.
Closes #19: Log Regex is now smarter about picking up log directories or
files.
Closes #17: scope metrics -c no longer fails silently.
Closed #23: rearranges scope dash to be more compact.

This has reverted @jrcheli commit and we'll need to resolve how to handle this to make tests succeed. Will chat Monday.

This has reverted @jrcheli commit and we'll need to resolve how to handle this to make tests succeed. Will chat Monday.

@iapaddler can you review? We should be ready to merge. I'm working on getting tests running better/more successfully in another branch.

@iapaddler can you review? We should be ready to merge. I'm working on getting tests running better/more successfully in another branch.


Updated 1inch connector to v4

Updated 1inch connector to v4 on all the chains

[x] Build updated connector.
[ ] Deploy new connector and comment addresses.
[ ] Add to the dsa-connect - link the PR
[ ]  Add to the docs - link the PR

Already deployed with - https://github.com/Instadapp/dsa-connectors/pull/143


Loader for snapshot image

From AP-3661
Sometimes when I click on a story, the snapshot image takes a few moments to load. In the meantime, the panel where it goes is just empty. I would like to see a loader appear there immediately to maintain Storybook's snappy local feel.

This was overlooked in the initial implementation, but it should look like this:

Figma source

I bumped up priority here because sometimes they take a while to load with no indication that anything is loading.


CVE5.0 CWE vs cepec

JSON format ofCWE is
      "problemTypes": [
        {
          "descriptions": [
            {
              "lang": "en",
              "cweId": "CWE-129",
              "description": "CWE-129 Improper Validation of Array Index",
              "type": "CWE"
            }
          ]
        },
        {
          "descriptions": [
            {
              "lang": "en",
              "cweId": "CWE-77",
              "description": "CWE-77 Improper Neutralization of Special Elements used in a Command ('Command Injection')",
              "type": "CWE"
            }
          ]
        }
      ],

But capec is:
      "impacts": [
        {
          "capecId": "CAPEC-102",
          "descriptions": [
            {
              "lang": "en",
              "value": "CAPEC-102 Session Sidejacking"
            }
          ]
        },
        {
          "capecId": "CAPEC-107",
          "descriptions": [
            {
              "lang": "en",
              "value": "CAPEC-107 Cross Site Tracing"
            }
          ]
        }
      ],

Since cweId and type are not language specific, shouldn't they be outside the descriptions array?

In Vulnogram these two fields appear as editable drop-downs. As you type letters in the box, the list of suggestions gets smaller. The suggested line is what that goes into value field, and capecId or cweId is computed based on value. Removing the IDs from being shown in drop-downs may make it complicated in few use cases. While this is redundant, I feel it is OK given other benefits (being able to see the ID in the drop-down itself).

This isn’t about the UI, but about how it appears in the JSON.
I believe it should reder just like impacts:
impacts : [
{
type: ‘CWE’,
cweId: ‘CWE-123’,
descriptions: [
{
lang: ‘en’,
Description: ….

If this is how it is in the schema, I’ll raise it with the schema project, but it could be a vulnogram bug too.


failed to create rec_alg client

Hi developers,
I faced a problem, when I trying to run the Recommendation example
I run the command:
seldon-cli --debug rec_alg --action create --client-name reuters -f reuters.conf
connecting to zookeeper-1:2181,zookeeper-2:2181,zookeeper-3:2181 [SUCCEEDED]
Invalid client[reuters]
error: error executing remote command: Error executing command in container: Error executing in Docker Container: 1
the file reuters.conf is below:
{
"defaultStrategy": {
"algorithms": [
{
"config": [
{
"name": "io.seldon.algorithm.inclusion.itemsperincluder",
"value": 1000
},
{
"name": "io.seldon.algorithm.external.url",
"value": "http://reuters-example:5000/recommend"
},
{
"name": "io.seldon.algorithm.external.name",
"value": "reuters-example"
}
],
"filters": [],
"includers": [
"recentItemsIncluder"
],
"name": "externalItemRecommendationAlgorithm"
}
],
"combiner": "firstSuccessfulCombiner"
},
"recTagToStrategy": {}
}
could you tell me what should I do to analysis the problem to workaround it?
or how to debug the problem. thanks very much

know the problem, thanks, close it


Add ReviewIndex /reviews and /profiles endpoints (resolves RS-181)

Add ReviewIndex support

Add /reviews endpoint
Add /profiles endpoint

At first I was going to do some refactoring to crate a parent class for Datashake::ReviewIndex::Client and Datashake::ReviewIndex::Client to put common code there, but actually there is no so much of it, so I'm not sure if I really should do that. Please let me know if you have any thoughts on it.

@blimp666 With regards on whether to merge the two client classes. I would keep them separate for now. If we end up adding the third identical class, then let's consider :)


Add rust-playpen-buffer and rust-playpen-region for sharing code.

This will create (and shorten) a URL with the code on
play.rust-lang.org.

r? @nikomatsakis
(rust_highfive has picked a reviewer for you, use r? to override)

I don't know if message is the best way to inform the user of the shortened URL.

I also don't like the last-line hack, which is working around the fact that the buffer created by url-retrieve includes all the HTTP headers.


Cirrus: Track VM Image calling GCE project

With multiple containers projects updating VM Image metadata,
it would be very difficult to discover which Cirrus-CI setup
was responsible.  Add the GCE project name to the list
of metadata labels to update when this container runs.  This
will give more context as to which images are currently in use.
Signed-off-by: Chris Evich<EMAIL_ADDRESS>

Sure, LGTM

/lgtm

/approve


Automate creation of releases

We should create a way to automate new releases.
Ideally, the process is triggered from the creation of a github release. This would build and push a new release to PyPI.
It would also be nice if we could automate the updating of the changelog

Process is not too bad and documented in PUBLISHING.md


Floating labels in input groups

Prerequisites

[X] I have searched for duplicate or closed feature requests
[X] I have read the contributing guidelines

Proposal
Regular inputs can be wrapped in a input-group. When doing this, some small css tweaks are being done e.g. setting the correct rounding on the input, increasing the z-index of the focus on the input, ...
The suggestion is to also allow floating labels to be used in an input-group.
Right now, when using a form floating input in combination with a button in an input group,

the right-upper and right-lower corner is still rounded (when button is at end),
the focus of the input is appearing below the button, while on regular input, the z-index is increased to 3.

Motivation and context
We are using a floating input password field in combination with a button in an input group to show/hide the password.
It's a (simple) addition on what is currently existing.

Duplicate of #34513.


Comments on a PR with a large amount of matches aren't hidden

I'm not sure what the cause of this is, but suddenly, comments have stopped being hidden in a particular PR with a very large amount of matches (using contains: …). If more was logged during execution, such as the number of matched comments by the applied filter, it could perhaps help to debug the problem.

It seems like the following line restricts the number of comments to 100, which would explain the behavior I'm seeing:
https://github.com/int128/hide-comment-action/blob/d810ffb6defc92bbfd236ac607f8f0a8a5dc7bbb/src/queries/comments.ts#L10
Since it's also sorting descending by UPDATED_AT, I suspect the same 100 comments to be returned on every query, if a PR has more than 100 comments.

I think it should say

It seems like the following line restricts the number of queried comments to 100, which would explain the behavior I'm seeing:
https://github.com/int128/hide-comment-action/blob/d810ffb6defc92bbfd236ac607f8f0a8a5dc7bbb/src/queries/comments.ts#L10
Since it's also ordering the comments descending by UPDATED_AT, I suspect the same 100 comments to be returned on every query for a PR with more than 100 comments.

That line should say first: 100, not last: 100, to at least get the newer elements.
The other option is to implement pagination


etcdserver: skip updating attr if the member does not exist

quick fix. We need to fix the TODOs soon.

@spacejam Can you give it a try? Thanks!

the code lgtm. I could follow up to solve the TODO.

Sorry for the super slow response!  This survives in my buggy environment!  Nice work!


On-chain bitcoin:Account visibility issue.

https://user-images.githubusercontent.com/62699947/153598424-e983cd28-1d2b-48a6-83ae-707f85a76b04.MP4

When I unhide this account and click "view account", it takes me to a Lightning account that looks like any other account(Such as checking/savings account). If we go out of this account and reopen that hidden Lightning account, it looks the same as the Lightning account.
In case of Archive account  we have to clear that particular account before archiving, but for on-chain bitcoin when I click "Continue" to archive this account,it immidiatly archive that Even though there are many transactions in that account.

In case of Archive account we have to clear that particular account before archiving, but for on-chain bitcoin when I click "Continue" to archive this account, still it immidiatly archive that Even though there are many transactions in that account.


feat: workspace contributors page (new design)

Description
Implements /workspace/[id]/contributors page that includes the following:

[ ] Contributor List/Table

[X] Contributor data (name, last contributions, etc.)
[ ] PR Histogram (based on range)

[ ] Controls

[ ] Change range
[ ] Search contributors by name
[ ] Sort by (TBD)

Design:

What type of PR is this? (check all applicable)

[X] 🍕 Feature
[ ] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents
Relates to #2578

Mobile & Desktop Screenshots/Recordings

Steps to QA

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[ ] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

Closing, will revive in a new PR once https://github.com/open-sauced/api/issues/725 goes through with a better design.


Access "active folder"

Is there a way to get the active workspace folder (e.g. in a task)
or is it otherwise possible to implement this, i.e., via something like ${activeFolder}?
Moreover, a way to set the active folder ( like "cmake.setActiveFolder(<name>)" ) would be useful too.

Can you try the variables ${workspaceFolder} for path or ${workspaceFolderBasename} for folder name? Might not be accurate in all the scenarios of tasks.json usage, let us know if they work for your case.
Regardless of how these variables above work for you, the extension can also expose a command that would return or set the activeFolder. Your tasks.json would access these with the command syntax: ${command:cmake.activeFolder} instead of the variable syntax ${activeFolder}. I opened work item https://github.com/microsoft/vscode-cmake-tools/issues/1715 for this.

This is actually a little irritating:
the variable ${workspaceFolder} always gives you the first(!) "path" entry in the "folders" array within the *.code-workspace file
(variable ${workspaceFolderBasename} only gives you the piece after the last slash in the path path tail of ${workspaceFolder}).
Now, changing the first(!) "path" entry in the "folders" array does also change the "active folder"!
On the other hand, changing the "active Folder" (via menus) does not change the first(!) "path" entry or the order of entries in the "folders" (this is actually good, since I would'nt want the folders array be changed in such a way).
After all, yes, ${command:cmake.activeFolder}, would be helpful.


support for groups memberships

currently there's not an API available to manage group level memberships, but the tool should still be able to tell if group memberships in the input file do not match whats in snyk and list them

resolved in 2.0

resolved in 2.0


GitHub workflows and nats upgrade

I tested it and it all works.
will add mage automation for doing a release to GitHub later, but this does some nice cross platform smoke testing for now

Let's try it.
P.S.: I made a v10 update before which included an update to all other packages as well.

Super . Thanks . I will have a try when I get time .


Fix zookeeper expose metrics port on kubernetes yaml

Fixes #5600
Motivation
Fix zookeeper kubernetes annotations for prometheus pull metrics from port 8000
Modifications
1.change deployment/kubernetes/*.yaml file

Hi @sijie, can you please take a look?


"\xE9" from ASCII-8BIT to UTF-8

Sorry for bothering, it's me again(embarrased),  I had googled around, but with no luck, so I ask here again...
Below is the situation:
evernote-open-note  or evernote-browser  is fine;
however, after evernote-create-note or  editing the note from evernote-open-note, evernote-save-note shows
"\xE9" from ASCII-8BIT to UTF-8.
the last .evernote-mode.log shows:
E, [2014-11-26T12:06:05.256885 #5251] ERROR -- : ["/usr/bin/enclient.rb:1916:in `eval'", "/usr/bin/enclient.rb:1916:in`run'", "/usr/bin/enclient.rb:1947:in `'"]
I think it's a encoding problem, but have no idea how to debug, please give me some advice, thank you.

Same issue here. Its anoying. The problem is that some characters are not recognized, like quotation marks. After load a note on emacs buffer, convert to TEXT format, edit and trying to save again, it shows such message. The problem, I guess, is that emacs reads some characters, and saving the note it does not allowed the characters as it were converted into the buffer in the edit mode. Any idea how to fix this?

Is there a chance either of you could create a text file that triggers the bug? That would give me a place to start.

I have similar error too.
I got this error when I'm writing Japanese character.
Here is example text I got error:
あいうえお
I hope it helps to figure out the error

I fixed the error by changing enclient.rb. It could lead other bugs so at this point I just paste diff here.
diff ~/Downloads/enclient.rb /home/ryan/pkgs/evernote-mode/evernote-mode/ruby/bin/enclient.rb
548,549c548,549
<       Formatter.to_ascii @title, @content, *@tag_names
<

  Formatter.to_ascii @title,*@tag_names

587,588c587
<       Formatter.to_ascii @title, @notebook_guid, @content, *@tag_names
<

Formatter.to_ascii @title, @notebook_guid, *@tag_names

I fixed bug by changing enclient.rb. I'm not sure side effect of this so this time I just put diff below
548,549c548,549
<       Formatter.to_ascii @title, @content, *@tag_names
<
---
>       Formatter.to_ascii @title,*@tag_names
>
587,588c587
<       Formatter.to_ascii @title, @notebook_guid, @content, *@tag_names
<
---
> 	Formatter.to_ascii @title, @notebook_guid, *@tag_names

I send pull-request to fix this issue.
Please see this pull request.
https://github.com/pymander/evernote-mode/pull/28

When I try to make any note that has japanese title like "タイトル", I still faced exactly same error.
Thank you.
itsumi


Fix markdown headings by adding a space between # and the text

Add spaces between the hashes each markdown heading that didn't have them.
Platforms affected
n/a
Motivation and Context
Basically the headings won't be formatted correctly unless the markdown has a space between the #'s and the heading text. This is recommended in the Heading Best Practices of this somewhat official Markdown Guide.
Fixes #1214
Description
I only updated instances with two hashes or more, seems like most of the instances with one hash at the start are intentional and part of code rather than a heading.
Pretty simple, basically just two regex find and replaces in VS Code, one for the leading ### and one for any trailing ###
Find: ^(##+)(\w)
Replace with: $1 %2
Find: (\w)(##+)$
Replace with: $1 $2
Testing
Have not tested this specifically. Checked through each file in the diff to ensure each place was intended to be a heading and not just #s in code or something.
Checklist

[x] I've run the tests to see all new and existing tests pass
[x] I added automated test coverage as appropriate for this change
[x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[x] I've updated the documentation if necessary

Tests came back successful :+1:
Thank you for your contribution.


feat: add events for do-not-evict blocking deprovisioning

Fixes #223
Description
Adds a new deprovisioning event for blocking deprovisioning. Consolidation has it's own bucket of items where this is already handled, but Expiration and Drift do not have this. This will be even more so used for Node Disruption Gates.
Added some suite tests as well.
How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

25 of 30 (83.33%)  changed or added relevant lines in 7 files are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.06%) to 81.213%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controllers/deprovisioning/helpers.go
4
5
80.0%

pkg/controllers/deprovisioning/drift.go
4
6
66.67%

pkg/controllers/deprovisioning/expiration.go
4
6
66.67%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/node/controller.go
7
73.53%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
6385

Relevant Lines:
7862

💛  - Coveralls


Screen Won't Go Back From QR Code

I'm unable to get my screen to display the status screen again after showing a QR code. Is there a command that can do that?

sudo pkill fbi or sudo killall -3 fbi
to remove the QRcode
sudo init 5 and sudo init 3
to restart the touchscreen

Great, thank you.


Make migration cancel tests reliable

What this PR does / why we need it:
Instead of trying to run stress tests and trying to abort the migration
on an overloaded VMI, create a MigrationPolicy which throttles the
migration speed to 1Mi which creates a huge time window for canceling
the migration.
It works in parallel since we can limit the throtteling to the test
namesapce without changing the global configuration and it even makes the tests
faster because we don't have to wait for the guest to be fully booted.
Fixes tests like
Tests Suite: [rfe_id:393][crit:high][vendor:cnv-qe@redhat.com][level:system][sig-compute] VM Live Migration Starting a VirtualMachineInstance live migration cancelation should be able to cancel a migration [sig-storage][storage-req][test_id:2731] with RWX block disk from block volume PVC

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Special notes for your reviewer:
Release note:

NONE

/cc @dhiller
/cc @xpivarc

/retest
Compute jobs were canceled by prow.

Migration tests are passing, but running them again to be sure they are fine:
/test pull-kubevirt-e2e-k8s-1.21-sig-compute-migrations
/test pull-kubevirt-e2e-k8s-1.22-sig-compute-migrations
/test pull-kubevirt-e2e-k8s-1.23-sig-compute-migrations

/retest

/retest

/approve

/retest

/retest

/override pull-kubevirt-e2e-k8s-1.21-sig-storage
/override pull-kubevirt-e2e-k8s-1.23-sig-storage
The storage tests fail on a migration test which should only be run on the migration lane. Will be fixed in #7194.
Skipping the checks for now to stablilize the migration tests and bring the test in.


JSONDecodeError during reclaim

Description
The following crash happened when using the reclaim command.
Consider installing rusty-rlp to improve pyrlp performance with a rust based backend
2021-02-12 12:39.02 start cmd                      eth_rpc_endpoint=http://parity.goerli.ethnodes.brainbot.com:8545
2021-02-12 12:39.03 Using account                  account=0x5a3B85ece0056aab6de2AB163Ca34EF38838365b
Writing log to /Users/paul/.raiden/scenario-player/scenario-player-reclaim-eth_2021-02-12T12:39:03.log
Traceback (most recent call last):
  File<EMAIL_ADDRESS>line 193, in _run_module_as_main
    "__main__", mod_spec)
  File<EMAIL_ADDRESS>line 85, in _run_code
    exec(code, run_globals)
  File "/Users/paul/Projects/brainbot/scenario-player/scenario_player/__main__.py", line 9, in <module>
    main()  # pylint: disable=no-value-for-parameter
  File "/Users/paul/Projects/brainbot/scenario-player/venv/lib/python3.7/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/Users/paul/Projects/brainbot/scenario-player/venv/lib/python3.7/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/Users/paul/Projects/brainbot/scenario-player/venv/lib/python3.7/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/Users/paul/Projects/brainbot/scenario-player/venv/lib/python3.7/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/Users/paul/Projects/brainbot/scenario-player/venv/lib/python3.7/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "/Users/paul/Projects/brainbot/scenario-player/scenario_player/main.py", line 141, in wrapper
    return func(*args, **kwargs)
  File "/Users/paul/Projects/brainbot/scenario-player/scenario_player/main.py", line 175, in wrapper
    return func(*args, environment=_load_environment(environment), **kwargs)
  File "/Users/paul/Projects/brainbot/scenario-player/scenario_player/main.py", line 157, in wrapper
    return func(*args, **kwargs)
  File "/Users/paul/Projects/brainbot/scenario-player/scenario_player/main.py", line 454, in reclaim_eth
    reclamation_candidates = get_reclamation_candidates(data_path, min_age)
  File "/Users/paul/Projects/brainbot/scenario-player/scenario_player/utils/reclaim.py", line 136, in get_reclamation_candidates
    keyfile_content = json.loads(keyfile.read_text())
  File<EMAIL_ADDRESS>line 348, in loads
    return _default_decoder.decode(s)
  File<EMAIL_ADDRESS>line 340, in decode
    raise JSONDecodeError("Extra data", s, end)
json.decoder.JSONDecodeError: Extra data: line 1 column 5 (char 4)

Expected Behavior
A clear and concise description of what you expected to happen. Do not leave anything to the imagination (even if you think it's "common sense", or "obvious").

Didn't happen again


Removed UIWebView From the Library.

As Apple declared UIWebView as deprecated from ios 12.1 and so I removed UIWebView from the SwiftR and After all We already providing support for the WkWebview.

Since UIWebView was replaced I can't connect to Hub. Any other changes we need on client or server side?


[AutoRelease] t2-datadog-2022-10-20-74723(Do not merge)

https://github.com/Azure/sdk-release-request/issues/2985
Live test success
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1031

issue link:https://github.com/Azure/sdk-release-request/issues/2985


Create 'cancel' button for sessions and meetings

[ ] Cancel button should set a date of when the session/meeting was canceled.
[ ] Cancel action will email guardians/mentors who signed up about the cancelation.

This ticket will also cover removal of Session is_public flag.

This issue was moved to CoderDojoChi/c2#79


Fix/ci and lint

swc dependency explaination: https://github.com/swc-project/swc/issues/7203

@huan Please checkout this PR that fixes lint and dependency issue. So that we can continue working on new features.

About the swc dependency: can we create another issue in our repo so that we can track it?
Thanks!

Thanks!
It would be great if we could file an issue for tracking this problem to make it more apparent to the community.


tetrio-desktop: migrate to fixup-yarn-lock

Description of changes
part of #240174
nix-build . -A tetrio-desktop
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

I'm curious, for our needs we only actually need the resulting node_modules folder that we would get after installing the package's yarn.lock/package.json. Is there a more ergonomic way to get that? Otherwise, looks good.

@huantianad sorry no better idea.

@Stunkymonkey all good, i was just wondering if there was a convenient function that provided the pre-installed node_modules, but all good if there isn't.


[QUESTION] Minimum MarkLogic Version Required?

I have seen lots of closed issue notices come through in the last hours; this is great!
I'm currently running ML v8 and was not clear about backward compatibility.
Checked the README and did not see mention of minimum ML version.
As an example, I raised these issues:
#18
#17
#16
Should updating typings resolve them against my current ML version and codebase?
Thanks in advance

From what I saw, most of them were actually addressed, but not marked closed yet. Did you try out any of the non-tagged releases: 0.3.1, 0.4.0, 0.4.1, and 0.4.2? If not, can you try?
And could you also try the 0.5.0 tag of this repo? I am unsure how well it will work against ML v8, but a confirmation about how well it works with ML v9 would be nice too..

I was able to retro-fit a v0.4.2 tag, based on the last changed made by Christy..

I hadn't tried an updates as I was not aware there'd been changes (no close notifications were being sent). I will have a play in the coming days.
Thank you for the great effort!


Make the run command accept just a role, and we will find the index

This makes it so we can run something like...
ttmscalr run watcher -f rc -c "echo 'helloworld'"
This will find the index of a watcher role, which we don't care to know.

LGTM


KAKU device status return to “on”

Sometimes couple (not all) of my kaku devices shows it’s status (in Home app) as “on” when it actually “off”. I turn it off and after few minutes or on next app launch turned-off device is “on” again.
Plugin was reinstalled, device cache was cleared but with no effect

Could you provide more information? First: if you turn a device off using Apple Home, does the device turn off (the real device, not the one on your screen)? Second: what is the device type of the devices that don’t work? You can find this number in the homebridge logs (it’s the number behind your device name).

If device is OFF but in Home app it shows as ON, after first click it shows OFF, and then works properly (ON and OFF as it should be) But if I leave it OFF, after few minutes it shows as ON again (but device is OFF).
Pardon me, I didn’t understand what do you mean. In homebridge logs my activity using Kaku plugin didn’t shows anything (only Initializing during server boot).
Kaku device is Start line smart socket.

It seems like the current status is not synced to the KAKU cloud (can’t do anything about this, the ICS-2000 should do that). Maybe it’s something temporary (once I rebooted my router and the ICS-2000 didn’t sync with KAKU cloud). You could try rebooting your router and / or ICS-2000.
Yes, the plug-in shows only info during initialising. The plug-in shows something like “loaded device from cache: [device name]: [device type, this is an integer]”. Could you please specify this integer?

Both Router and ics-2000 was rebooted many times. This problem not starts yesterday.
BTW On my previous homebridge instance on raspberry first plugin installation works without issues. After reinstall on raspberry and then on mac later something went wrong
Device type is 1

@childledj sorry for late reply, but is this issue solved or still happening? If solved, please close the issue. If not, maybe try change device data for device type 1 using the config.


Fixed broken link to ci status badge

Image shields have made a breaking change lately.
This is documented in https://github.com/badges/shields/issues/8671
(TOC has been autoformatted on save. I can revert that if you wish)

CI was already broken on main branch. I haven't tried to fix it on my side.

Thanks Maël for your contribution! Would you be able to revert the changes in the table of contents?

Created #31 to address the failing workflow.

Toc has been reset to original state


Asset editor page broken in beta by auth changes

We embed the asset editor in https://shakao.github.io/arcade-sprite-pack/. We were using beta, but it stopped loading the page so we moved back to release. To repro:

Go to https://shakao.github.io/arcade-sprite-pack/
Inspect and look for the iframe with src https://arcade.makecode.com/--asseteditor
Change the src to https://arcade.makecode.com/beta--asseteditor
See error

Stack trace:
pxtasseteditor.js:1 Uncaught TypeError: a.mountVirtualApi is not a function
    at Object.102../compiler (pxtasseteditor.js:1)
    at c (pxtasseteditor.js:1)
    at pxtasseteditor.js:1
    at Object.15../cloud (pxtasseteditor.js:1)
    at c (pxtasseteditor.js:1)
    at pxtasseteditor.js:1
    at Object.128../auth (pxtasseteditor.js:1)
    at c (pxtasseteditor.js:1)
    at pxtasseteditor.js:1
    at Object.14../app (pxtasseteditor.js:1)
    at c (pxtasseteditor.js:1)
    at pxtasseteditor.js:1
    at Object.8../cloud (pxtasseteditor.js:1)
    at c (pxtasseteditor.js:1)
    at pxtasseteditor.js:1
    at Object.59../auth (pxtasseteditor.js:1)

Closing this. https://shakao.github.io/arcade-sprite-pack/ seems already broken with live.


DocsArchive-<IP_ADDRESS>Auto archive content

Please don't merge this PR until target archive repo PR https://github.com/OPS-E2E-PPE/docs-archive-test-source-version-target/pull/89 is merged into live branch.
Auto archive content to https://github.com/opstest2/docs-archive-test-source-version-target.git

Docs Build status updates of commit fe2ffe5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.redirection.json
:white_check_mark:Succeeded

versioningArchiveSourceFolder/TOC.yml
:white_check_mark:Succeeded
View (sql-server-2014 || azuresqldb-current || azuresqldb-mi-current || azure-sqldw-latest || >= aps-pdw-2016 || >= sql-server-2016 || >= sql-server-linux-2017 || sql-server-previousversions || sqlallproducts-allversions)

versioningArchiveSourceFolder/docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


fix: improve compatibility with other plugins

If the heading already has an id set by another plugin, use it; otherwise, set the id.

ref: https://github.com/syntax-tree/mdast-util-toc/blob/c96a9eb446a8426b53cf2b68cf6655f3f2600420/lib/search.js#L96

Since Astro sets the id of the headings in rehype, it is not possible to get the id from the remark plugin.
ref: https://github.com/withastro/astro/blob/297571eb98509a63f894d6fff912775b637a1482/packages/markdown/remark/src/rehype-collect-headings.ts


feat: automatically create background thread pools

Make the size of the background thread pool created by
google::cloud::ConnectionOptions` configurable. A future change will
set the default size to something more sensible than "one", though this
would need to be by service, for example, a subscription or publisher
should use several threads, but the admin APIs are probably fine with
one.
Fixes #4650

This change is

PTAL.


Fixed an issue where browser crashes if component re-renders during slideshow animation

You can reproduce this issue in my website.
https://hinaser.github.io/react-slideshow/web/
Solution is simple.
When componentWillUnmount is called, set this.willUnmount = true.
Cancel/Stop tween animation if(this.willUnmount).
That's it.

Hi all sorry I’ve not responded yet. Currently not with my system. I will
attend to this soon
On Fri, 7 Sep 2018 at 7:24 PM, Bodo Tasche<EMAIL_ADDRESS>wrote:

Hm...this is weird. After looking at your code I tried to find my code
where I already did this. And it is gone. No wonder this is back to not
working state sadly.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/andela-foladeji/react-slideshow/pull/13#issuecomment-419525733,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AQh7AKEmGFqAh5JWnZ2sz8km-yvhu8sCks5uYrn2gaJpZM4WfHRq
.

--
Oladeji Femi
Software Developer
Github: https://github.com/andela-foladeji
Twitter, FB: @femidotexe
"If you always do what is easy, your life will be hard"

@Hinaser thanks for this fix

@bitboxer I'm sorry I must have messed things up when I switched to tweenjs cos I remember merging your PR. Sorry about the mix up


rename Plugin class in AWSDBAutoScaling

Hi,
To fix issue : https://github.com/sbstjn/serverless-dynamodb-autoscaling/issues/23
With Serverless 1.22
I had to rename the plugin Class "Plugin" into another name.
Regards,
Fef

Thanks for the PR 👍
Is there any explanation why this fixes #23 ? o.O


Change return type of listen()

I suggest changing the return type of listen() from (), the unit type to Result<!, ListenError>. This would better document what listen is supposed to do (i.e. never return, unless there was a error setting it up), and it would be more idiomatic Rust. Safe functions in Rust usually don't panic, with some exceptions (like an out of bounds index on an array). This would also require you to create some error type representing possible errors in executing listen.
It would be a breaking change, although pretty easy for users to fix - just change listen() to listen().unwrap() to get the old behavior.

Fixed in master.
I decided against "!" because it's an experimental feature.


pull request for e2e test at 12/08/2016 23:56:01

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Make advanced config examples

Using multiple [[gateway]]

e.g. reusing the same channel on another gateway, or another channel with the same account.
People get really creative sometimes. See https://github.com/42wim/matterbridge/issues/822 for example config

I'm trying to do this:
Slack-gerneral --bridge-- Mattermost-townsquare using MM-user slackbot
IRC-#channel --bridge-- Mattermost-Irc using MM-user irc-bot
Both to the same Mattermost server, this is the toml:
[slack]
        [slack.test]
                Token="xoxb-uniuq code"
                PrefixMessagesWithNick=true

[mattermost]
        [mattermost.irc]
                Server="<IP_ADDRESS>:8065"
                Team="mb-test"
                Login="irc-bot"
                Password="password1"
                NoTLS=true
                PrefixMessagesWithNick=true
                RemoteNickFormat="[{PROTOCOL}] <{NICK}> "
                EditDisable=true

        [mattermost.slack]
                Server="<IP_ADDRESS>:8065"
                Team="mb-test"
                Login="slackbot"
                Password="password2"
                NoTLS=true
                PrefixMessagesWithNick=false
                EditDisable=true

[irc]
        [irc.server]
                Server="irc.test.com:6697"
                Nick="User3"
                PrefixMessagesWithNick=true
                RemoteNickFormat="[{PROTOCOL}] <{NICK}> "
                NickServNick="User3"
                NickServPassword="password3"
                UseTLS=true
                UseSASL=true
                SkipTLSVerify=false

[[gateway]]
        name = "mygateway"
        enable=true

        [[gateway.in]]
                account ="slack.test"
                channel = "general"

        [[gateway.out]]
                account="mattermost.slack"
                channel="town-square"

        [[gateway.inout]]
                account="mattermost.irc"
                channel="irc"

        [[gateway.inout]]
                account="irc.server"
                channel="#channel"

This makes doesn't work, since Slack text comes over to irc-bridge, which isn't wanted.

Hi! Firstly is this still going on?
Secondly, I do use multiple gateways like manually linking/bridging some rooms (17) between 2 IRC networks, plus 4 rooms over matrix. Are you asking something like this?

@kaotisk-hund yes something like that :-)
Feel free to create a page with examples/explanation on https://github.com/42wim/matterbridge/wiki/Gateway-config-(advanced)


Brain example : problem to use the constructor PNetwork

Hello Nick,
i have copy paste your brain exemple in Processing and add the constructor PNetwork.java in a new tab in Processing (as I did with your other example).
But I read this in the monitor
The constructor PNetwork(brainexemple, float[], float[], float[][]) is undefined.
What have I done wrong?
Happy to see that you keep on developing other application with the kuramato model ;)

Hey @bvking! Thanks for the heads up.
Have you downloaded and installed the most recent release? I changed the interface a little, so that error would probably appear with previous versions of the library.
Yep! Just started laying groundwork for more interesting applications (including Chimera states :).


EKF: optical flow improvements

Partially addresses https://github.com/PX4/Firmware/issues/6347

Enables takeoff in position control mode when the OF sensor is out of focus and quality metric fails acceptance test by setting flow measurements to a value equivalent to zero horizontal velocity.

If optical flow is lost and then resumed in flight and there is no other means of determining position (eg GPS), the position will be set to the last known position when optical flow was lost.

Because I am running OSX Sierra, I have been unable to test the proposed ecl EKF changes using the gazebo sim as the gazebo installer is incompatible with my OS version.

@priseborough With the change flow_quality_good || !_control_status.flags.in_air I get valid local positions and I can enable position mode, but commander takeoff does not work. I guess it's because the global position is never valid https://github.com/PX4/Firmware/blob/master/src/modules/commander/commander.cpp#L1205

@ChristophTobler The EKF cannot set global position as valid when operating with optical flow only because the WGS-84 origin of the local earth frame is not known.

@priseborough in lpe I allow users to specify origin lat lon. Maybe something like that would be a good compromise.

@jgoppert rather than specifying it in the estimator, should we make it a system level parameter so that multiple algorithms can use it?

@priseborough, totally agree, also for sensor noise specs would save a lot of space when we have time.

@ChristophTobler @priseborough Where is this standing?

Discussions about adding externally set origins to estimators or modifying controllers to be able to operate in local coordinates should not be blocking this PR.

@LorenzMeier I think this is good to go in

@priseborough Will it be merged to ecl and px4 in near future? Because current flow code in ekf2 is not usable without GPS fix


[T3A5][W14-A1]Lim Jie

Resubmission

Accepting this PR without a review because another of your PRs for this tutorial was reviewed in detail.


Back-testing previous survey years to ensure compatibility

The Echopop codebase was built using the 2019 data. There are known issues that will require changes for older survey years, but some unforeseen changes may also be necessary for more recent survey years. This a running list of survey years that have been confirmed to work when processing them within Echopop:

[x] 2023
[x] 2021
[x] 2019
[x] 2017
[ ] 2015
[ ] 2013
[ ] 2012
[ ] 2011
[ ] 2009
[ ] 2007
[ ] 2005
[ ] 2003
[ ] 2001
[ ] 1998
[ ] 1995

Changelog for each year
🕵 = activate investigation
Last edit: 6 December 2024 11:36 PT
2023

Several strings required for NAME_CONFIG [f8667b]:
cluser name, frequency, species_code, strata_index, strata index, weight_in_haul
Updated how lower- and uppercase column names are handled due to inconsistent usage (implemented in #308)

2021

A re-indexing change [bb95f1b] was required for distributing stratified abundance and biomass estimates over the weight proportions during the apportionment step in Survey.kriging_analysis

2017

Several strings required for NAME_CONFIG [0e512e0]:
cluster number, haul  start, inpfc

2015

Inconsistent handling of whitespace in certain files (e.g. 2015_biodata_catch.xlsx) are not truly empty but contain empty spaces parsed as strings like " ". This causes the pandera validators to (correctly) flag these as invalid entries since these validators are unable to coerce the values into their expected datatypes (e.g. float, int). 🕵


MSR 2013 Challenge

URL
http://2013.msrconf.org/challenge.php
Contact
Chair of Challenge: Alberto Bacchelli<EMAIL_ADDRESS>Note: Cite the data as shown:

@INPROCEEDINGS{MSRChallenge2013,
author={Alberto Bacchelli},
title={Mining Challenge 2013: Stack Overflow},
booktitle={The 10th Working Conference on Mining Software Repositories},
year={2013},
pages={to appear}
}

Data
The 2013 data is all from Stack Overflow. They have an XML-formatted "dump" from Stack Overflow with irrelevant entries removed, though I'm not sure what exactly this is a dump of. (file size >7GB) They also provide a progresqul-formatted dump of the same data.
XML: http://2013.msrconf.org/challenge_data/201208_stack_overflow_official.tar.bz
progresql: http://2013.msrconf.org/challenge_data/201208_stack_overflow_postgres_dump.tar.bz

Added as msr13, data uploaded.


implement facefilter using exported public API

Further discussion is required.
Some background is available towards the bottom of: https://github.com/elucideye/drishti/issues/574
CMake currently exports a zero dependency wrapper interface via src/lib/drishti/drishti (when used as a shared library at least), which mirrors the internal OpenCV based processing modules.  This provides a clean integration for projects that aren't using Hunter, but does add some class duplication and additional maintenance.  When using Hunter to manage dependencies, it should be much easier to use the direct OpenCV based API (which is not currently exported).  It might make sense to move towards using the later as the primary API with optional support for the wrapper interface for projects that don't use Hunter.

Added in #701


Update payout curve

https://github.com/get10101/10101/pull/1542 introduces a new payout curve.
We want to extend this payout curve to

include the fee in the margin
remove payouts which are below dust (Note: this needs some investigation, maybe the payout function in rust-dlc does this already)

remove payouts which are below dust (Note: this needs some investigation, maybe the payout function in rust-dlc does this already)

Payouts below dust are not included by rust-dlc. It looks like they are added to the other party's output.


refactor: rename "noProxy" to "onlyNonProxyOwner"

Closes #156.

@PaulRBerg, aside from the 2 minor suggestions, I see no other issues with this PR.

Thanks, @IaroslavMazur - I have made a few changes here and there in my latest commit. Can you have another final look, please?

Thanks, @IaroslavMazur - I have made a few changes here and there in my latest commit. Can you have another final look, please?

Went through the 4 new commits. Everything seems alright. 👍


[Pods] Preserve the local-cli directory

In continuation of the discussion here in #363, the global react-native-cli refers to the local-cli directory when run inside the project. But when installed via Pods, this folder is deleted as it is not listed in the preserve_paths config in the pod spec.

please review!

:+1: this would be very helpful

Apologies, this change by itself does not make the react-native bundle command work as it assumes it to be inside the node_modules folder always. Closing PR.


[Request] Add icons to bookmarks links

Hi,
instead of the standard svg icon beside the link
I would like to have (as other users) the ability to change it to a local or remote icon file.
That would help a lot as an icon  is more speaking than a text.

Before:
After:

Suggestion of formating
Collection:
  - Bucket:
      - url: https://example.com/
      - ico: example.png

or (google favicon api)
Collection:
  - Bucket:
      - url: https://example.com/
      - ico: https://www.google.com/s2/favicons?domain=${domain}&sz=${size}

or (base64)
Collection:
  - Bucket:
      - url: https://example.com/
      - ico: data:image/png;base64,...

Anything that works is welcome.
// update
Here https://github.com/maximtrp/tab a lite similar project by @maximtrp with icons integration capability.

any chance that this feature will be implemented?

@franden I'm currently not planning to work on this feature anytime soon, but PRs are welcome.


[BUG]: No upsert, neither with REPLACE nor with INSERT ON DUPLICATE KEY UPDATE, super important to avoid extra round-trips and bloated code

What version of drizzle-orm are you using?
latest
What version of drizzle-kit are you using?
latest
Describe the Bug
Pretty much the title, with both you can do upserts. Former replaces the entire row while latter updates selected fields. You could do raw sql but an upsert shouldn't be a big thing and supported natively. Here a bit more context on both: https://www.javatpoint.com/mysql-upsert
Expected behavior
No response
Environment & setup
MySQL but I guess with others too

onClonfictDoUpdate could be the work-around, does it reliably work with MySQL?

Ok, closing again and playing around with onConflictDoUpdate, guess that's the solution

Having the same issue, what's onClonfictDoUpdate? I can't find any reference. ON DUPLICATE KEY UPDATE should be added imho.


Comparison on memories

In #46, @sampsyo said:

[comparisons] Should probably only be supported for primitive/numeric types (not memories, for example).

Should be not allow stuff like a[0] == 0? Constant comparisons might be fine, but what would this mean and what would the hardware look like:
for (...) unroll 3 {
  if (a[i] < 10) { a[i] := 1 }
}

(Search might require comparisons on dynamic memory locations)

Aha, over in #46, I did not mean to argue against allowing a[0] == 0 because a[0] (presumably) has a primitive type. I just didn't want to support a == b where a and b are both memories.
I think that example looks OK—provided that we let the read and write to a[i] happen in separate logical timesteps. The hardware could contain both a read and write connection to a. It would could have three logical time stages:

Send the index for i to the memory a to read a value.
A comparator.
A write to a gated by an "and" so it only actually sends the message if the result of the comparison is true.


Multiple items can be added to 'dashboard' outputs view

Added "Add to Dashboard" to right-click context menu for code cells
Added outputs are displayed in a list in a single "Dashboard" view

excellent progress great idea using the panel!


Please add links to places where people can find experienced help for customization of their template

I really suck at customizing these go template fragment files, and would rather have someone else come up with a more professional looking design. I wonder where all of you get help? Surely you're not all web designers?

I've realized I have bigger problems, it's not just upgrading castanet that breaks everything, but also upgrading hugo (on its own) breaks everything. So I would have to first find a hugo specialist to upgrade hugo to the latest. Then I would have to find a castanet specialist to upgrade the castanet template.
So some basic info on where to hire hugo peope, and template customization people (for castanet) would help.
At this stage, I've come to terms with leaving everything as is, and am considering switching to something else entirely, it's a lot more work to maintain than I'm comfortable with. But knowing where help is available might make others feel more confident in choosing hugo + castanet.


Late binding fix

To avoid 'User-defined type not defined' errors, you need late binding of the forms component - Microsoft Forms 2.0 Object Library.  Use the following.
Public strClip As String    ' for clipboard strings to be saved
Private Sub TestClipboard
getClipboard            ' save clipboard data
' do whatever custom handling is required
setClipboard            ' retrieve clipboard data
End Sub
Private Sub getClipboard()
Dim MyDataObject As Object
On Error Resume Next
Set MyDataObject = CreateObject("New:{1C3B4210-F441-11CE-B9EA-00AA006B1A69}")
MyDataObject.GetFromClipboard
strClip = MyDataObject.GetText

End Sub
Private Sub setClipboard()
Dim MyDataObject As Object
On Error Resume Next
Set MyDataObject = CreateObject("New:{1C3B4210-F441-11CE-B9EA-00AA006B1A69}")
MyDataObject.SetText strClip
MyDataObject.PutInClipboard

End Sub
I hope this helps you.  I spent a lot of time figuring this late binding issue out.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 5a391455-0cf5-8a5c-f017-22315af2a45e
Version Independent ID: 90cd1fc3-648a-cdca-7fc7-df5b0f3e1e5c
Content: Copy, GetFromClipboard, GetText methods, DataObject object example
Content Source: Language/Reference/User-Interface-Help/copy-getfromclipboard-gettext-methods-dataobject-object-example.md
Product: office
GitHub Login: @o365devx
Microsoft Alias: o365devx

@wmclaxton Thanks for this submission.
@brreich Bryan, can you verify that this sample is okay?


Add path for v1 and v2 trusted books

Using tooltip to identify if content is in book root or inside content folder

Pull Request Test Coverage Report for Build 298276871

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 39.906%

Totals

Change from base Build 298235477:
0.0%

Covered Lines:
20097

Relevant Lines:
46189

💛  - Coveralls

What is this fixing? And why are you using tooltip? When I think of a tooltip I think of just what's displayed when a user mouses over an item - which doesn't really seem to be a logical thing to use for determining whether content is in the root or a content folder.

Trusted books where not fully functional in the new jupyter book version, because the isNotebookTrustedByDefault method was only checking for notebooks under the 'content' folder.
I used the tooltip because it contains the path of the notebook already, but I changed it and build the path again, so the code it's easier to understand.

Does this fix #12858?

Does this fix #12858?

Yes 😃

Does this fix #12858?

Yes 😃

Awesome. Can you put that in the description of the PR?


Adds rpc method for anvil to drop all pending transactions

Motivation
Fixes #7249

Solution
Added a new rpc method, and added the corresponding implementation in the mod.rs file for pool.

Now iterating over the ready transactions map and dropping them too.

Moved to a clear function as requested @mattsse


NTR: single-stranded DNA-dependent GTPase activity

GO term name: single-stranded DNA-dependent GTPase activity
Definition:
Catalysis of the reaction: GTP + H2O = GDP + phosphate; this reaction requires the presence of single-stranded DNA, and it drives another reaction.
Aspect: Molecular Function
Relationships:
Ancestor Chart
is_a GTPase activity (GO:0003924) --> is_a GTPase activity,  coupled (NTR)--> is_a DNA-dependent GTPase activity (NTR) --> is_a single-stranded DNA-dependent GTPase activity (NTR)
References:
PMID: 26277776
Figure 6
I've used GO:0043142 (Single-stranded DNA-dependent ATPase activity) as a reference.
Thanks,
Javier K.
CACAO participant

[Term]
+id: GO:0061745
+name: GTPase activity, coupled
+namespace: molecular_function
+def: "Catalysis of the reaction: GTP + H2O = GDP + phosphate; this reaction directly drives some other reaction." [GOC:dph, PMID:26277776]
+is_a: GO:0003924 ! GTPase activity
+created_by: dph
+creation_date: 2015-11-11T12:47:56Z
+
+[Term]
+id: GO:0061746
+name: single-stranded DNA-dependent GTPase activity
+namespace: molecular_function
+def: "Catalysis of the reaction: GTP + H2O = GDP + phosphate; this reaction requires the presence of single-stranded DNA, and it drives another reaction." [GOC:dph, PMID:26277776]
+is_a: GO:0061745 ! GTPase activity, coupled
+created_by: dph
+creation_date: 2015-11-11T12:50:19Z
+


Error in REST handler: Invalid atomic update value for $__original_remove. Expected an object, received function

Same code was working fine before I updated some lib modules to their later versions. I believe, those libs were totally irrelevant to the code below. I am not sure whether this error belongs here or in some other module, but I am logging it here with below error logs pointing in feathers:rest module:

feathers:rest REST handler calling find from /auth/instagram +19s
feathers:rest REST handler calling get from /auth/instagram/callback?code=acc66d95cd0f4bd49888f5153beb61a2&state=true +987ms
feathers-authentication:oauth2 Updating user: 575516a41764b5b4cd1fdd85 +2s
feathers:rest Error in REST handler: Invalid atomic update value for $__original_remove. Expected an object, received function +5ms
feathers-authentication:middleware An authentication error occurred. +6ms Error: Invalid atomic update value for $__original_remove. Expected an object, received function
at Query._castUpdate (D:\Dev\workspace\WebstormProjects\ES6\angular2-esnext-starter\node_modules\mongoose\lib\query.js:2323:13)
at Query.update (D:\Dev\workspace\WebstormProjects\ES6\angular2-esnext-starter\node_modules\mongoose\lib\query.js:2106:22)
at Function.update (D:\Dev\workspace\WebstormProjects\ES6\angular2-esnext-starter\node_modules\mongoose\lib\model.js:2054:13)
at Object.patch (D:\Dev\workspace\WebstormProjects\ES6\angular2-esnext-starter\node_modules\feathers-mongoose\lib\service.js:247:27)
at D:\Dev\workspace\WebstormProjects\ES6\angular2-esnext-starter\node_modules\feathers-hooks\lib\hooks.js:74:31
at new Promise (D:\Dev\workspace\WebstormProjects\ES6\angular2-esnext-starter\node_modules\core-js\modules\es6.promise.js:193:7)
at D:\Dev\workspace\WebstormProjects\ES6\angular2-esnext-starter\node_modules\feathers-hooks\lib\hooks.js:58:16
at run (D:\Dev\workspace\WebstormProjects\ES6\angular2-esnext-starter\node_modules\core-js\modules\es6.promise.js:89:22)
at D:\Dev\workspace\WebstormProjects\ES6\angular2-esnext-starter\node_modules\core-js\modules\es6.promise.js:102:28
at flush (D:\Dev\workspace\WebstormProjects\ES6\angular2-esnext-starter\node_modules\core-js\modules_microtask.js:18:9)
at _combinedTickCallback (internal/process/next_tick.js:67:7)

Please guide me where I should look for answers.
Thanks.

This looks like a Mongoose error. Can you try and see if it works with the toObject hook?

Here is the output after applying the suggested hook:
`
D:\Dev\workspace\WebstormProjects\ES6\angular2-esnext-starter\server\services\user\hooks\index.js:47
hooks.toObject({}),
^
TypeError: hooks.toObject is not a function
at Object. (D:\Dev\workspace\WebstormProjects\ES6\angular2-esnext-starter\server\services\user\hooks\index.js:47:15)
at Module._compile (module.js:541:32)
at Object.Module._extensions..js (module.js:550:10)
at Module.load (module.js:456:32)
at tryModuleLoad (module.js:415:12)
at Function.Module._load (module.js:407:3)
at Module.require (module.js:466:17)
at require (internal/module.js:20:19)
at Object. (D:\Dev\workspace\WebstormProjects\ES6\angular2-esnext-starter\server\services\user\index.js:5:15)
at Module._compile (module.js:541:32)
at Object.Module._extensions..js (module.js:550:10)
at Module.load (module.js:456:32)
at tryModuleLoad (module.js:415:12)
at Function.Module._load (module.js:407:3)
at Module.require (module.js:466:17)
at require (internal/module.js:20:19)
`

Can you put up a breaking example to reproduce?

Looks like your suggestion is working and I was making an error putting it the right way. It confronted me while I was putting up the example.
const service = require('feathers-mongoose');
const hooks = require('feathers-hooks');

I was using
hooks.toObject({});
instead of
service.hooks.toObject({});
So, it works and feel free to close this issue.
Many thanks for your help.


Update q param to take list of str

Addresses issue #82. Tested with the following and it worked:
from newsapi import NewsApiClient
import os

api_key = os.environ.get("NEWSAPI_KEY")

api = NewsApiClient(api_key=api_key)

r = api.get_everything(q=["Wave Inc", "Space Power Technologies", "Emrod"])

Check result in debug console:
>>> r.get('status')
'ok'

Thanks for the update


FaceLivenessDetector orientation

Before opening, please confirm:

[X] I have searched for duplicate or closed issues.

Which UI component is this feature-request for?
Liveness
Please include any relevant guides or documentation you're referencing
https://github.com/aws-amplify/amplify-ui-android/blob/main/liveness/src/main/java/com/amplifyframework/ui/liveness/ui/FaceLivenessDetector.kt
Please describe your feature-request in detail.
The screen orientation lock function on line 102 of the FaceLivenessDetector.kt source could lock it in the app's current orientation rather than just in portrait mode. This way, the liveness screen could run in both orientations.
Currently if you run a LivenessSession in an application that runs in landscape orientation, the SDK forces the orientation to portrait mode causing the application to crash.
Initialization steps (if applicable)
No response
Code Snippet
// Put your code below this line.

amplifyconfiguration.json
No response
Additional information and screenshots

@gabriel-amorim Please provide a stacktrace of the crash. The FaceLivenessDetector UI is only designed to work in portrait at this moment.

@tylerjroach
It happens when you pass 'disableStartView = true' to FaceLivenessDetector.
FATAL EXCEPTION: main
Process: com.postomirian.sam, PID: 25039
java.lang.IllegalArgumentException: Trying to create LifecycleCamera with destroyed lifecycle.
at androidx.camera.lifecycle.LifecycleCameraRepository.createLifecycleCamera(LifecycleCameraRepository.java:107)
at androidx.camera.lifecycle.ProcessCameraProvider.bindToLifecycle(ProcessCameraProvider.java:503)
at androidx.camera.lifecycle.ProcessCameraProvider.bindToLifecycle(ProcessCameraProvider.java:363)
at com.amplifyframework.ui.liveness.camera.LivenessCoordinator$1.invokeSuspend(LivenessCoordinator.kt:141)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
at android.os.Handler.handleCallback(Handler.java:942)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:226)
at android.os.Looper.loop(Looper.java:313)
at android.app.ActivityThread.main(ActivityThread.java:8757)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:571)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1067)
Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@7b42b80, Dispatchers.Main]

I was able to reproduce this issue and find the root cause:
When disableStartView = true is set the relevant code looks like this:
// in compose
LockPortraitOrientation()
ChallengeView()

fun ChallengeView() {
    val lifecycleOwner = LocalLifecycleOwner.current
    coordinator = LivenessCoordinator(lifecycleOwner)
}

class LivenessCoordinator(lifecycleOwner) {
    init {
        MainScope().launch {
            getCameraProvider(context).apply {
                    bindToLifecycle(lifecycleOwner)
            }
        }
    }
}

The main issue is that we create two LivenessCoordinators, each with their own LifecycleOwner,  but then initializing the first coordinator is delayed enough that the LifecycleOwner is destroyed before it can be used.
SImple solution: just check if the owner is valid before using it.  Which works... the first time you run the liveness check; if you try to restart the check it'll either enter an infinite loop of switching from landscape to portrait or just crash with this same error.  I'll update this issue if I make any progress.

This change was released with Amplify UI v1.1.2, @gabriel-amorim please see if that has resolved your issue!


Error when calling requestSync

When trying to call requestSync in NodeJS the follow undocumented error is shown:
Failed {
  "error": {
    "code": 403,
    "message": "The caller does not have permission",
    "status": "PERMISSION_DENIED"
  }
}

Operation is the same with an API key and Service account.
The same API Key and agentUserId will work with curl!

Are you using both an API key and a service account key?

I have tried Just API Key. Just Service account and both. It all cases this command fails.
reportState works with no issue.

Here is my function:
`function testsync() {
    const { smarthome } = require('actions-on-google');
    const app = smarthome({
        key: 'AIAAASyBiHC1G4SXefqsbYxUHIawAAAAAAA' // Changed from Actual Key

    });
    // ...
    // New device is added for user
    app.requestSync('1NMWK8AAAEVscJzceSJuLmvGAAA') // Changed from Actual UID
        .then((res) => {
            console.log('Worked', res)
        })
        .catch((res) => {
            console.log('Failed', res)
        });
}`

Further Testing:
With incorrect UID:
Failed {
  "error": {
    "code": 404,
    "message": "Requested entity was not found.",
    "status": "NOT_FOUND"
  }
}

With Incorrect API KEY:
Failed {
  "error": {
    "code": 400,
    "message": "API key not valid. Please pass a valid API key.",
    "status": "INVALID_ARGUMENT",

To add to the error message. The Sync Event Occurs. Stack driver shows the following error:
SYNC: Request ID<PHONE_NUMBER>82431064 failed with code: OPEN_AUTH_FAILURE

To Add account linking works fine. The device is sync is working the device can be controlled from home. The command errors but the sync occurs and home is updated.
Help...

I was able to have it work fine when using the sample with just a service account key.

It works but I get the error above along with the OPEN_AUTH_FAILURE in stackdriver. I have no idea why and there seems to be very little debugging ? Where are the permissions it is referring to?

Open Auth Failure refers to some issue with the account linking.

This issue has been migrated to the public issue tracker:
https://issuetracker.google.com/issues/142048841


feat: new menu row

add new menu row
config the menu inside config/_default/menus/menu.es.toml and modify the variable extra_main

Se tiene que agregar las páginas relacionadas con el nuevo menú

thanks for working on that @EverVino
The second menu is overlapping with the text behind .. could you take a look into that please?

@xmnlab overlapping menu fixed

superseded  by #66


Search Keyboard Shortcut

🚀 Feature
Search Shortcut (ex. s key or / key) functionality for DocSearch search bar to automatically put the cursor in the search bar. This would be similar to how you can hit s or / to select the GitHub search bar.
Have you read the Contributing Guidelines on issues?
Yes
Motivation
Make it easier to access the website search.
Pitch
This feature would make it easier for users navigating the site to search the page by keeping their hands on the keyboard with a shortcut vs having to use the mouse to click on the search bar.

+1 for this! Though I have heard that DocSearch is releasing a new version soon that should be the one they are using on https://docsearch.algolia.com/ (where you hit Ctrl + K), so maybe Docusaurus just needs to implement this new theme when it releases?

Maybe we can add keyboard support as a core feature to Docusaurus 2.
How it works - plugins can register keyboard shortcuts which Docusaurus will attach as a global event listener and show a list of all supported shortcuts on the website when the user types ?, like Reddit:


apparently isn't working on iOS 8.3

https://docs.google.com/spreadsheets/d/1lLlBNzGC78ETjzcSaTpkugLUBqB2wQa2__gxDc10Yl0/htmlvi
ew?pli=1&sle=true#gid=0

It is indeed working on iOS 8.3 and up!


Recommended way to position drawing within canvas?

What is the recommended way to change the position where the bitmap is drawn on the canvas using draw2canvas()? I noticed that x and y are hardcoded to start at 0 in the function definition (below) and using context.moveTo() does not seem to have any effect.
https://github.com/tomchen/bdfparser-js/blob/71a4ee35ddabe2dd6d2a060e03004e285e43e9c4/src/bdfparser.ts#L1796-L1829

I created a PR #3 that might be one way of doing this internally without using transformations.

@jordan-loeser Hi, I plan to update bdfparser js and python libs soon to v3, merging all PRs, solving all issues, and adding a feature to generate pixelated SVG from Bitmap (and perhaps even convert an entire BDF font to pixelated SVG font, which would be a little complicated to implement but very useful though)
I'm wondering if I can apply your modification in PR #3, which was closed because you deleted your branch, but I suppose that was not because you thought your modif was bad but just to clean up your forked repos, right? I guess it's good to add x, y as new options in draw2canvas().


Weekly scrum - [March 27 to April 3]

Please comment on this issue with answers the following questions:
what have I done this week?
what will I do next week?
what is holding me back? (if applicable)
Expected length: 1-2 sentences per item.

what have I done this week? Cleaned up create book and update book page
what will I do next week? Nothing, the project ended.
what is holding me back? (if applicable) N/A

what have I done this week? Display currently logged in user on top of page header, update user email validation regex, review PRs.
what will I do next week? Nothing, the project ended.
what is holding me back? (if applicable) N/A

what have I done this week? Completed shopping-cart functionality & checkout
what will I do next week: adding additional tests
what is holding me back? (if applicable) N/A

Added Book Viewer

Added Book Shower

Added Admin.html

Refactored index.html

Added S3 integration

What have I done this week? Book recommendations.
What will I do next week? N/A
What is holding me back? N/A


applescript can not tell chrome execute js code

I have open Allow Javascript from Apple Events in View menu.

my problem, sorry.


Fix interpreter when shared library pthread is missing

Resolves #11792

I assume this fix is only for unix, right? Because it still fails on mac.

I can confirm this patch (ported to :darwin) also works, but then it fails when linking libiconv

Righ! And once you fix it for iconv (by conditionally removing it on darwin) it fails on dl. Then conditionally removing that works fine, though I guess it might also fail for some other libraries.
For instance on Mac I have this, and I suspect it's similar on every Mac:
$ find /usr/lib -name "*pthread*"
/usr/lib/system/libsystem_pthread.dylib
/usr/lib/system/introspection/libsystem_pthread.dylib

so there's no "pthreads" library... maybe they are all on some "libsystem" thing on Mac, no idea.

All right. It seems on MacOS/darwin a number of core libraries are all provided by libsystem. That includes libc, libm, libpthread, libpoll, and libdl. There should be symbolic links for these libraries, but apparently that doesn't seem to work for our use case. But the point is, we can drop explicitly mentioning any of these libraries on darwin. They just refer to libsystem.

for iconv we can remove it in interpreted mode (/x86-darwin-macos/.../iconv.cr):
{% unless flag?(:interpreted) %}
  @[Link("iconv")]
{% end %}

libiconv should be available as a separate library on macOS, though... isn't it? AFAIK it's at least not part of libsystem.

You're right, when set the path to the library it works fine. But it confuses me that when we don't link it, it works. Does it mean it uses the compiler's?

Yes. All symbols that are available in the compiler binary are available to interpreted programs.


Fixed a typo

Purpose
Fix a little typo in the README file
Goals
Just fixing a typo
Approach
N/A
User stories
N/A
Release note
N/A
Documentation
N/A
Training
N/A
Certification
N/A
Marketing
N/A
Automation tests
N/A
Security checks
N/A
Samples
N/A
Related PRs
N/A
Migrations (if applicable)
N/A
Test environment
N/A
Learning
N/A

@ftoresan Thanks for the contribution!


Room walls should be dark when underground and bright when on the surface level.

Bg color constraints are probably sufficient.

Or should they?


Add tutorials for atomistic models

This build on top of #405 and add new tutorial about how to use the new metatensor atomistic models.

📚 Documentation preview 📚: https://metatensor--431.org.readthedocs.build/en/431/

Can you rebase against the current master? I will do a review asap.

I'm working on a second tutorial, I should be able to rebase & send both here tomorrow.

Ok, second tutorial is in! Let me know what you think

Very nice. Can we use a switch so that the notebook version uses chemiscope for visualization?
It's nice to have the plot exported to sphinx gallery but still it's much nicer to see this in the full chemiscope glory when  downloading the notebook.


feat: KONFLUX-3902 POC support of CI workflow as a rulechain for a co…

…mponent
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue ticket number and link
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:

[ ] I have performed a self-review of my code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[ ] I have updated labels (if needed)

@psturc Looks like a compilation issue
Rebasing (1/1)

Successfully rebased and updated detached HEAD.
[e2e-test] ./mage -v ci:teste2e
[e2e-test] # github.com/konflux-ci/e2e-tests/magefiles/rulesengine/repos
[e2e-test] rulesengine/repos/e2e_repo.go:283:43: undefined: fmt
[e2e-test] rulesengine/repos/e2e_repo.go:288:6: undefined: klog
[e2e-test] rulesengine/repos/e2e_repo.go:305:4: undefined: klog
[e2e-test] rulesengine/repos/e2e_repo.go:317:6: undefined: klog
[e2e-test] rulesengine/repos/e2e_repo.go:320:6: undefined: klog
[e2e-test] rulesengine/repos/e2e_repo.go:331:5: undefined: klog
[e2e-test] rulesengine/repos/e2e_repo.go:332:5: undefined: klog
[e2e-test] rulesengine/repos/e2e_repo.go:336:4: undefined: os
[e2e-test] rulesengine/repos/e2e_repo.go:337:4: undefined: os
[e2e-test] rulesengine/repos/e2e_repo.go:356:5: E2ETestRulesCatalog redeclared in this block
[e2e-test] 	rulesengine/repos/e2e_repo.go:269:6: other declaration of E2ETestRulesCatalog
[e2e-test] rulesengine/repos/e2e_repo.go:337:4: too many errors
[e2e-test] Error: error compiling magefiles
[e2e-test] make: *** [Makefile:25: ci/test/e2e] Error 1

@psturc Looks like a compilation issue
Rebasing (1/1)

�[KSuccessfully rebased and updated detached HEAD.
[e2e-test] ./mage -v ci:teste2e
[e2e-test] # github.com/konflux-ci/e2e-tests/magefiles/rulesengine/repos
[e2e-test] rulesengine/repos/e2e_repo.go:283:43: undefined: fmt
[e2e-test] rulesengine/repos/e2e_repo.go:288:6: undefined: klog
[e2e-test] rulesengine/repos/e2e_repo.go:305:4: undefined: klog
[e2e-test] rulesengine/repos/e2e_repo.go:317:6: undefined: klog
[e2e-test] rulesengine/repos/e2e_repo.go:320:6: undefined: klog
[e2e-test] rulesengine/repos/e2e_repo.go:331:5: undefined: klog
[e2e-test] rulesengine/repos/e2e_repo.go:332:5: undefined: klog
[e2e-test] rulesengine/repos/e2e_repo.go:336:4: undefined: os
[e2e-test] rulesengine/repos/e2e_repo.go:337:4: undefined: os
[e2e-test] rulesengine/repos/e2e_repo.go:356:5: E2ETestRulesCatalog redeclared in this block
[e2e-test] 	rulesengine/repos/e2e_repo.go:269:6: other declaration of E2ETestRulesCatalog
[e2e-test] rulesengine/repos/e2e_repo.go:337:4: too many errors
[e2e-test] Error: error compiling magefiles
[e2e-test] make: *** [Makefile:25: ci/test/e2e] Error 1

@Dannyb48  I was not working on this PR, but these ones:

https://github.com/konflux-ci/e2e-tests/pull/1344
https://github.com/konflux-ci/e2e-tests/pull/1348

ah, ok. My bad @psturc . So we can close this PR out right then? or do we still want to keep it open for reference?

I think we can close it


Make href independent of file ending semantics.

VSCode allows .html or .htm as file endings for html files, but when you href to (for example) file.html which is actually named file.htm, the link does not work. This is more a theory question, or a lazy request - someone please fix this!

So the example is

You are saying the link does not work because the file on disk/on the server is named x.html not x.htm?

Correct! Thanks for considering this feature-fix.
On Wed, Apr 14, 2021 at 12:36 AM Martin Aeschlimann <
@.***> wrote:

So the example is

You are saying the link does not work because the file on disk/on the
server is named x.html not x.htm?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/vscode/issues/121151#issuecomment-819300641,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASHVF3LOYVUEY3X5NAHXPYDTIVAXRANCNFSM422PMC4A
.

Shall I take up this issue? If it isn't resolved @Cole-Henrich


Added PureScript language definition

Added PureScript language definition with test cases and examples.

Thank you for making this language definition @sriharshachilakapati!
I will review it once the issue with the many generated files is resolved. This should be quite simple. My guess is that you ran npm i instead of npm ci. The output of uglify is very sensitive to the specific uglify version used.
Deleting the local node_modules folder (and reverting changes to package.json and package-lock.json, if any), and then running npm ci, followed by npm run build should fix the issue.

I was using pnpm instead of npm and it didn't respect that lock file. My bad, will correct that and push soon.

The syntax of PureScript follows closely to that of Haskell, and hence I derived this from Haskell's one. Will reply to the comments one by one.

I derived this from Haskell

It's ok to use another language as the base but we usually use the extend function to do so. The function basically copies a language and lets you make some changes to it. With extend, PureScript can be implemented like this:
Prism.languages.purescript = Prism.languages.extend('haskell', {
	'keyword': /\b(?:ado|case|class|data|derive|do|else|if|in|infixl|infixr|instance|let|module|newtype|of|primitive|then|type|where)\b/,
	'import_statement': {
		// The imported or hidden names are not included in this import
		// statement. This is because we want to highlight those exactly like
		// we do for the names in the program.
		pattern: /((?:\r?\n|\r|^)\s*)import\s+(?:[A-Z][\w']*)(?:\.[A-Z][\w']*)*(?:\s+as\s+(?:[A-Z][_a-zA-Z0-9']*)(?:\.[A-Z][\w']*)*)?(?:\s+hiding\b)?/m,
		lookbehind: true,
		inside: {
			'keyword': /\b(?:import|as|hiding)\b/
		}
	},
	// These are builtin variables only. Constructors are highlighted later as a constant.
	'builtin': /\b(?:when|unless|liftA1|apply|bind|discard|join|ifM|identity|whenM|unlessM|liftM1|ap|compose|otherwise|top|bottom|recip|eq|notEq|degree|div|mod|lcm|gcd|flip|const|map|void|flap|conj|disj|not|mempty|compare|min|max|comparing|clamp|between|sub|negate|append|add|zero|mul|one|show|unit|absurd)\b/,
});

The main benefits of this approach are that you have to write less code and that improvements from the extended language will trickle down (e.g. I will make a pull to fix the exponential backtracking in Haskell).
Please use the above code. It's equivalent to your current approach.
I will close all comments on patterns that are identical to Haskell's ones.

@RunDevelopment I've updated the definition to use extend, but now the test cases are failing.
1) Testing language 'purescript'
       – should pass test case 'builtin_feature':
     Error: Cannot extend 'haskell' because it is not defined in Prism.languages.
      at Object.extendTest (tests/helper/checks.js:27:10)
      at Object.object.<computed> [as extend] (tests/helper/checks.js:7:10)
      at eval (eval at <anonymous> (tests/helper/prism-loader.js:66:18), <anonymous>:3:46)
      at languageFunction (tests/helper/prism-loader.js:67:57)
      at /Users/sriharshachilakapati/Projects/prism/tests/helper/prism-loader.js:69:4
      at handleId (dependencies.js:269:13)
      at loadComponentsInOrder (dependencies.js:291:4)
      at Object.load (dependencies.js:437:12)
      at Object.loadLanguages (tests/helper/prism-loader.js:56:57)
      at Object.createInstance (tests/helper/prism-loader.js:38:18)
      at Object.runTestCase (tests/helper/test-case.js:58:29)
      at Context.<anonymous> (tests/run.js:32:16)
      at processImmediate (internal/timers.js:458:21)

Where do I specify that dependency in test suite?

My bad. You have add "require": "haskell" to PureScript in components.json (and rebuild).

Thank you for contributing @sriharshachilakapati!

@RunDevelopment Thanks for your patience in guiding me through the PR. By the way, may I know if there are any plans for a release anytime soon?

any plans for a release anytime soon?

No. We release rather infrequently, so maybe in a few weeks?
However, all merged features are available right now on the download page.

I'm asking cause I came here from another project. If released, I can directly update the package.json file there and it should work for me.

@sriharshachilakapati I can't commit to anything in particular, but I will spend some time going through PRs and looking at what we should include in our next release.
@RunDevelopment We get this question a lot. We may want to consider either a regular release cycle and/or automating the release process.

@mAAdhaTTah I was thinking about a regular release cycle too (maybe monthly?) and automating sounds good. How would we go about automating? (I always hand it off to you after making the changelog, so how involved is the process of making a new release?)

It's not super involved, I think you really just need publish perms. But if we can set up a bot to do this stuff for us, it would be a lot easier.

Perms?
We could set up a bot with GH actions. They finally support manual triggers.
I'm not sure who can use these triggers thou. Would be a problem if anybody could make a new release.

perms => permissions.
We could definitely have the bot only act in response to certain users (org members, probably). I'll create an issue to flesh this out a bit.

I can see I've narrowly missed the boat here, but I've always felt that highlighting some arbitrary set of "built-in" functions from isn't very true to the spirit of these languages, since there isn't actually anything special about them.
There was a discussion about this in the Haskell Vscode plugin, and it was decided to remove it.


unitegallery doesn't work with chrome

I copied files under unitegallery-master\package to Apache\htdocs.
I could visit default.html or some other pages with Edge and Firefox.
but it didn't work with Chrome.
bellow are the errors:
Uncaught ReferenceError: jQuery is not defined
Uncaught SyntaxError: Invalid or unexpected token

close it for this issue disappeared


Fix app where app would crash before playing the game

If the user tries to scroll down before playing the game for the first time, updateLabel would try and unwrap an Optional and fail, because it can't find the appropriate SKSpriteNode.

Thanks!


docs: docker command update

docker command update in README.md
Fixes Issue #3437

Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] My change requires changes to the documentation.
[x] I have updated the documentation accordingly.
[ ] All new and existing tests passed.
[ ] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

The current command is the good and the latest one. The command you are updating was v1 of compose. You can check below. Closing the PR. Thank you for the effort

https://docs.docker.com/engine/reference/commandline/compose_up/


[composer] don't show completely blank right sidebar

Not a big deal, but confusing to see a blank section of an app (especially on mobile where it takes over the screen). A label like "Comments: none" would be an improvement[1].

[1] Though I'm actually not sure what can be in the right sidebar, is it only comments or also other stuff?

Dupe of https://github.com/dxos/dxos/issues/7604


Cannot do a copy for a selection

OS version and name:
Hyper.app version:

I am not able to do copy Ctrl+shift+c on the screen.  I do a selection, I click on ctrl and then the selection disappears.

[x] I am on the latest Hyper.app version
[ ] I have searched the issues of this repo and believe that this is not a duplicate

OS version and name:
Hyper.app version:
Link of a Gist with the contents of your .hyper.js:
Relevent information from devtools (CMD+SHIFT+I on Mac OS, CTRL+SHIFT+I elsewhere):
The issue is reproducible in vanilla Hyper.app:

Issue

duplicate


Update mdoc, sbt-mdoc to 2.2.21

Updates

org.scalameta:mdoc
org.scalameta:sbt-mdoc

from 2.2.20 to 2.2.21.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta" } ]

labels: library-update, semver-patch

Superseded by #181.


Rewards account not updated when creating new wallet

Describe the bug
I forgot my wallet password, so I created a new wallet via the CREATE button. The new wallet address is shown on the wallet tab, but a different wallet address is shown on the Smeshing screen under Rewards Account.
To Reproduce
Steps to reproduce the behavior:

Open the application
Under "Forgot your password?", click CREATE
Set a new wallet password
Compare the wallet address on the Smeshing and Wallet tabs.

Expected behavior
I expected the Rewards Address to match the new wallet address.
Screenshots

Desktop (please complete the following information):

OS: Linux Mint XFCE
Version 0.0.6

Additional context
None.

This issue should be resolved as soon as we add the Set coinbase account account command. See #494 .


move elavator up or down

the robot shall move the elavator up or down for a specified duration
the robot shall move the elavator at a specified speed.

closed


feat: auto dismissible Fab List

Feature Request
Ionic version:

[x] 4.x
Describe the Feature Request

I've run into trying to have an ion fab list being dismissible. Adding an onBlur event and closing the fab here is a bit flakey, especially because the icon takes most of the space and the button never recieves focus.
Describe Preferred Solution

adding an attribute to the IonFab component such as, dismissable=true and default could be either true or false
Describe Alternatives

an alternative is adding onBlur event and calling close within.
Related Code

Additional Context

Thanks for the feature request. Fab List components already auto dismiss when selecting a button. Can you please clarify the feature you are requesting?


Improve ui kill and scale error messages

We should improve the error message writing, as it is not clear what exactly is the issue. This error message (introduced in mesosphere/marathon-ui#396) is displayed when one tries to kill a task and scale an app which is locked by a deployment.
 If you want to stop any current deployment of the app and force a new one to kill the task and scale it, press the OK button

@orlandohohmeier Great, looking at improving Marathon alerts and feedback overall in general.
For this particular example, what copy would you recommend?

@orlandohohmeier I could do with your help on the wording. We're looking at introducing a "title" to dialogs. With that in mind, it might read something like this:
Title: "Warning: ${appId} Is Currently Deploying"
Description: "To scale to ${requestedInstances} instances, the current deployment will have to be stopped, and a new task started."
Actions: "Stop Current Deployment And Scale", "Cancel"

@leemunroe Sorry, I've missed your earlier comment. I really like the introduction of a title. It is a huge improvement! Regarding the message, I think we should make crystal clear that forcefully stopping a deployment is dangerous and could screw things up. Besides this, I'm not sure if we know the number of requested instances within the modal component... What do you think about the following:
Title: "Warning: ${appId} Is Currently Deploying"
Description: "In order to kill the tasks and scale to  ${requestedInstances || "a new number of"} instances, the current deployment will have to be forcefully stopped, and a new one started. Please be cautious, as this could result in unwanted states."
Actions: "Stop Current Deployment And Scale", "Cancel" (preselected)
/cc @aquamatthias

Please see https://github.com/mesosphere/marathon/issues/2831#issuecomment-169384707 for a full list of dialog messages.


Update README.md

Fixed Typo of Basel Face Model

With link https://faces.dmi.unibas.ch/bfm/main.php


Bug Report - Jerky terminal

Environment
Microsoft Windows [Version 10.0.18362.207]
Windows Terminal version (if applicable): 0.2.1831.0

Steps to reproduce
Open Windows Terminal,
Press Windows + Tab,
In the Windows Timeline,
Click on the Terminal,
When returning to Terminal,
The terminal seems to jerk for a fast moment and return to its original spot.
Expected behavior

There should not be a jerky transition when returning back to Windows Terminal through Windows + Tab.

As far as I know (and see) it's Windows "UI" problem, not Terminal's one and yeah - should be fixed because sometimes is annoying as hell 😂

@TayYuanGeng You still seeing this? It's been a few years, so it's possible other OS updates might have just taken care of this for us. I'm not sure we really have any control over how the Terminal window behaves in the Win+Tab menu, but we can always forward a bug along to that team if needed.


Feature/rspec3

Coverage increased (+0.09%) to 97.034% when pulling 0b6efffb3620fbd224e4bd96761d163b776a0c49 on feature/rspec3 into 5c6cb346ea25087e152cf52d6ca83906464617bb on master.

Coverage increased (+0.09%) to 97.034% when pulling 0b6efffb3620fbd224e4bd96761d163b776a0c49 on feature/rspec3 into 5c6cb346ea25087e152cf52d6ca83906464617bb on master.

Coverage increased (+0.09%) to 97.034% when pulling 0b6efffb3620fbd224e4bd96761d163b776a0c49 on feature/rspec3 into 5c6cb346ea25087e152cf52d6ca83906464617bb on master.

Coverage increased (+0.09%) to 97.034% when pulling 0b6efffb3620fbd224e4bd96761d163b776a0c49 on feature/rspec3 into 5c6cb346ea25087e152cf52d6ca83906464617bb on master.

Coverage increased (+0.09%) to 97.034% when pulling 4e55d272e8543191299e581d1e9c35d5b8506926 on feature/rspec3 into 5c6cb346ea25087e152cf52d6ca83906464617bb on master.