Rename new tooling API types to avoid the term "intermediate model" to avoid conflict with things already called "intermediate models"

Context
Use "streamed" instead of "intermediate model" and add some validation:

Renamed BuildController.sendIntermediate(model) -> send(value)
Renamed IntermediateModelListener -> StreamedValueListener
Renamed listener type's onModel(model) to onStreamedValue(value)
Renamed BuildActionExecuter.setIntermediateModelListener() -> setStreamedValueListener()
Renamed some internal type names.
BuildController.send() fails when the build action is running in a Gradle version that does not support value streaming.
The build fails when BuildController.send() is used when no listener has been registered to handle the value.

Contributor Checklist

[ ] Review Contribution Guidelines
[ ] Make sure that all commits are signed off to indicate that you agree to the terms of Developer Certificate of Origin.
[ ] Make sure all contributed code can be distributed under the terms of the Apache License 2.0, e.g. the code was written by yourself or the original code is licensed under a license compatible to Apache License 2.0.
[ ] Check "Allow edit from maintainers" option in pull request so that additional changes can be pushed by Gradle team
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[ ] Ensure that tests pass sanity check: ./gradlew sanityCheck
[ ] Ensure that tests pass locally: ./gradlew <changed-subproject>:quickTest

Reviewing cheatsheet
Before merging the PR, comments starting with

❌ ❓must be fixed
🤔 💅 should be fixed
💭 may be fixed
🎉 celebrate happy things

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.

Pre-tested commit build failed. Click here to see all build failures.

@bot-gradle test and merge

I've triggered a build for you. Click here to see all failures if there's any.


loading state_dict

I run the code in Running Uni-Fold( I change some paths)as this:
bash run_unifold.sh /home/input_fasta/1.fasta /home/output /path/to/database/directory 2020-05-01 multimer_ft /home/Uni-Fold/all_model/multimer.unifold.pt
model name is : multimer_ft
model parameters file is:multimer.unifold.pt(in section 'Downloading the pre-trained model parameters')
but I meet this bug:

could u help me?

It looks like the parameters doesn't download completely.
Maybe you can download from google drive via command : gdown https://drive.google.com/uc?id=1A9iXMYCwP0f_U0FgISJ_6BX7FXZtglvV

@rabbit-0001 is the issue solved?

Thanks,I have solved this issue
btw, this code covert open-fold model to uni-fold, would u mind giving a link to download open-fold model file

@rabbit-0001 refer to this https://github.com/aqlaboratory/openfold/blob/main/scripts/download_openfold_params.sh

hi
I run the command
bash run_unifold.sh /zhangyudi/alphafold-2.3.1/7XAC.fasta      dummy_test/   /zhangyudi/alphafold_data/   2020-05-01    $model_name    multimer.unifold.pt
model name  : multimer_ft
I met this problem

And I have use the command which had beed mentioned, but it doesn't work
gdown https://drive.google.com/uc?id=1A9iXMYCwP0f_U0FgISJ_6BX7FXZtglvV
can u help me?

@addsg Hi there. It seems that you are using a monomer model while providing a multimer checkpoint.

Can you tell me the $model_name variable you are using? By default I think it was model_2 which is a monomer model.
Is your target case a monomer or multimer? Please use model name "multimer_ft" for multimer models.

model name : multimer_ft
and my target case is a multimer

sorry I missed the model name you provided. Could you please double check that 1. the code is the newest and 2. the checkpoint is correct and 3. you are using the model name you suggest?
The reason is that I see in your message the target_feat has shape 22, but if you use multimer_ft as the model name it should be set as 21. See the code https://github.com/dptech-corp/Uni-Fold/blob/b1c89a2cebd4e4ee4c47b4e443f92beeb9138fbb/unifold/config.py#L509 and https://github.com/dptech-corp/Uni-Fold/blob/b1c89a2cebd4e4ee4c47b4e443f92beeb9138fbb/unifold/config.py#L589C9-L589C9.

Sorry, I make a mistake. I use a wrong model name. thank u!


Not able to see internal logs for events

Expected Behavior
In a previous version of the legacy SDK (com.amplitude:android-sdk:2.38.3), we were able to see internal logs for events, this picture below shows some examples:

Current Behavior
When we switch to the new SDK version com.amplitude:analytics-android:1.5.0, we don't see these logs. We've tried using INFO, WARN and DEBUG as log levels without any success. Also, I noticed this behavior in the sample project of this repo. Is this made on purpose?
Environment

Device OS and Version: Android 11, Android 12, Android 13

Hi @hjdealba96 , thanks for reporting this!
We are collecting the feedback to enhance the current log/debug output information. This is currently on our roadmap. Please let us know if you have other related feedback too!
Thanks!

Hi @hjdealba96 ,
We have added the event log (with debug level), and released in 1.6.0. Please try it out!
Closing this issue, and thank again for supporting us!


Command lines should be built using shellescape

I’ve created a silly directory named "a;b" (just to break things) and edit a file test.c in that directory.
ALEInfo tells me:
(finished - exit code 0) ['/bin/bash', '-c', 'gcc -S -x c -fsyntax-only -iquote /tmp/a;b -std=c11 -Wall - < /tmp/vO5KCPQ/11/test.c']

and, of course, the dummy command "b" is indeed run…
To build commandlines, fnameescape is not enough, shellescape should be used.
There are many uses of fnameescape in the source code, I guess a big part of them, if not all, should be shellescape.

Thank you for reporting this, this has been fixed.


Update ArtifactHub with how to run

We need to add to the instructions on ArtifactHub how to bring up Ortelius once it has been downloaded.

@sachajw Can you verify the new steps to bring up Ortleius once you have installed locally?

For the local dev environment on a Kind cluster the Terraform automation takes care of the following:

Kind K8s cluster
Deploying Ortelius from the Helm Charts in Artifact Hub
Please refer too https://github.com/ortelius/dev-env-setup for more info

Updated the ortelius-charts/charts/ortelius/README.md with access info. Should display in ArtifactHub now.


HL-533, HL-566 | Augment mock user

Description :sparkles:
Shared backend: Add is_staff & is_superuser support to mock user
Add settings to control mock user's is_staff and is_superuser values:

settings.MOCK_USER_IS_STAFF -> mock user's is_staff value

If the setting is not set at all then will default to False

settings.MOCK_USER_IS_SUPERUSER -> mock user's is_superuser value

If the setting is not set at all then will default to False

The mock user is created by MockAuthenticationRequestView which is
mapped to oidc's authenticate endpoint
(See backend/shared/shared/oidc/urls.py) if NEXT_PUBLIC_MOCK_FLAG is set
HL-Backend:

Set MOCK_USER_IS_STAFF and MOCK_USER_IS_SUPERUSER to True by default

Refs HL-566
HL-Backend: Update NEXT_PUBLIC_MOCK_FLAG related permission handling
BaseApplicationViewSet.get_queryset:

Refactor logical structure for readability, should not change effect

ApplicationStatus.is_editable_status:

Previously NEXT_PUBLIC_MOCK_FLAG allowed to edit all statuses. Now
NEXT_PUBLIC_MOCK_FLAG allows to edit both handler's and applicant's
statuses.
Update related test_is_editable_status_with_anonymous_user test

UserSerializer.is_terms_of_service_approval_needed:

Don't require terms of service to be approved when
NEXT_PUBLIC_MOCK_FLAG is on

Refs HL-566
HL-Backend: Don't validate pay subsidies in RECEIVED to HANDLING change
Also update translations:

"python manage.py makemessages --no-location -l fi -l sv -l en"
Add Finnish and Swedish translations for

"Start date cannot be empty"
"End date cannot be empty"

Refs HL-533
...
TODO:

Clean up code, properly fix conditional endpoint mocking (i.e. cleaner than the proof of concept version)

Issues :bug:
HL-533, HL-566
Testing :alembic:
Screenshots :camera_flash:
Additional notes :spiral_notepad:

Codecov Report

Merging #1486 (66693ff) into develop (7b80e2d) will increase coverage by 29.68%.
The diff coverage is 88.09%.

@@             Coverage Diff              @@
##           develop    #1486       +/-   ##
============================================
+ Coverage    64.97%   94.65%   +29.68%
============================================
  Files         1037      314      -723
  Lines        28398    14305    -14093
  Branches      2983        0     -2983
============================================
- Hits         18452    13541     -4911
+ Misses        9492      764     -8728
+ Partials       454        0      -454

Impacted Files
Coverage Δ

backend/shared/shared/oidc/urls.py
81.25% <79.54%> (+3.47%)
:arrow_up:

backend/benefit/calculator/api/v1/serializers.py
96.03% <80.00%> (+0.07%)
:arrow_up:

backend/benefit/applications/api/v1/views.py
96.13% <100.00%> (ø)

backend/benefit/applications/enums.py
96.00% <100.00%> (ø)

...efit/applications/tests/test_application_status.py
100.00% <100.00%> (ø)

backend/benefit/helsinkibenefit/settings.py
95.07% <100.00%> (+0.07%)
:arrow_up:

backend/benefit/users/api/v1/serializers.py
90.62% <100.00%> (+0.30%)
:arrow_up:

...ackend/shared/shared/oidc/tests/test_mock_views.py
100.00% <100.00%> (ø)

backend/shared/shared/oidc/views/mock_views.py
94.59% <100.00%> (ø)

backend/benefit/terms/models.py
84.21% <0.00%> (-9.48%)
:arrow_down:

... and 724 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Document the new checker misc-use-anonymous-namespace

This checker is interesting because AFAIK it goes against LLVM's own convention. 😬 (It's been a while since I coded C++ 😦 )

I do appreciate the vigilance from Sylvestre, but I would prefer if we did not litter the history with merge committing one checker at a time. Would it be bad if we only imported the new checker labels once per (LLVM|CodeChecker) release? Do we have a functionality that allows users to user their own labelling config file from their home, without having to build a package themselves, @vodorok? (If we don't, can we have a ticket about it at least?) Being too bleeding edge means that we'd be defaulting on checkers that could get removed before the next LLVM release hits the market.

@whisperity as you wish, you are upstream, you decide :)
However, I am not sure to see what is the issue ? (commits are cheap)
Doing it incrementally when they arrive is easy and spreads the work

Indeed there's merit to both ways. What I'm trying to prevent is accidentally default-enabling (or sensitive, which is also used by plenty of our clients) a checker that's not up to spec for some reason (e.g. bugprone-unchecked-optional-access which crashes, misc-const-correctness which is slow). LLVM's master is not a stable thing so it's not a good idea to add something in the window where it might be reverted, even.
Nevertheless, having a user-specific profile option that doesn't need to write system directories (in the case of the PyPI package) would have benefits because that way some of the people who use codechecker to drive a custom clang (that has checkers our upstream cfg doesn't know about) could set it without having to manually rebuild the package every now and then.
And diffing between two tags makes it relatively easy to see how many new checks were labelled between CCh releases.


Port over ClimaAtmos-needed changes

Currently, ClimaAtmos is overwriting some methods in RRTMGP to function properly. This PR ports over these modifications. This PR requires additional work:

[ ] replace hard-coded constants with somehow passed-in parameters
[ ] Add documentation for the newly added parameters
[ ] Add paper/equation references to the newly added equations.

@dennisYatunin, this is perhaps not high priority, but can I assign you to follow this through?

@szy21 Can you send a reference for this optical depth computation for gray radiation?

Here is the reference we used to calculate gray radiation optical depths: https://journals.ametsoc.org/view/journals/clim/21/15/2007jcli2065.1.xml (equations 1 and 3).

I believe the plan is to replace the gray optical properties calculation in https://github.com/CliMA/RRTMGP.jl/blob/main/src/optics/GrayOpticsKernels.jl#L39
The current function uses same optical properties definition for longwave and shortwave cases. This needs to be updated to support longwave/shortwave specific definitions.
The corresponding tests are in https://github.com/CliMA/RRTMGP.jl/blob/main/test/gray_atm.jl
cc: @szy21 @charleskawczynski

@dennisYatunin @charleskawczynski I can give this a try if you don't have enough time. I may need some help on the coding side though.

Could I separate this task into two PRs, one for changing the optical depth function and adding the reference, and one for replacing hard-coded constants? I may need some help for the latter one.

Yes, I think splitting up the PR is fine

superseded by #339


⚠ Punto de Fuga has degraded performance

In f8c88bc, Punto de Fuga (http://puntodefugapodcast.com) experienced degraded performance:

HTTP code: 200
Response time: 11889 ms

Resolved: Punto de Fuga performance has improved in 79f5d67.


Negative numbers hang Pixie UI max_num_records

Describe the bug
Using negative numbers on the Pixie UI max_num_records field causes the system to hang.
To Reproduce

Open Pixie UI
Type a negative number(ex. -100) on the max_num_records
Watch UI hang

Expected behavior
It's expected to return 0 records
Screenshots

Logs
pixie_logs_20220601150922.zip
App information (please
complete the following information):

Pixie version: 0.7.10+Distribution.fb7da3f.20220531183919.1
K8s cluster version: 1.21
Node Kernel version: 5.4.0-1066-gke
Browser version: Version 101.0.4951.64 (Official Build) (x86_64)

@aimichelle , not sure if this is UI or backend related. Based on that we should set the priority appropriately.


scripting/shell interface to config

Should openssl have a command to make config data available to shell scripts?  If we think of a config file looking like:
[sectionname]
key = value

Then some possible examples:
openssl config -sections

openssl config -keys SECTIONNAME

openssl -config -value SECTION KEYNAME

(Of course, a -conf flag would be supported also)

What's the objective?

I would find it useful, maybe others would as well.  For example, pulling the HMAC digest and key for a provider?  Generating config can be done just via echo statements so that's not needed.


feat: trust wallet connection

What is the purpose of the change:
Added trust wallet connection
Linear Task
Linear Task URL
Brief Changelog

Add new module for trust wallet

Testing and Verifying
Test on local is successfully

Please check this one @MaxMillington

@CryptoAssassin1 @kamal-sutra can you review?

No Tx is working on Trust Wallet Mobile app.
Getting Not Found page when try to do tx.

@CryptoAssassin1 Would you show me with video screenshot?
And would you tell me your device name?
I can't get same error on my device(Android)

@forbesus Im using Andriod 11.
https://github.com/osmosis-labs/osmosis-frontend/assets/103904125/c34b0701-76b2-4bfb-8abf-81794be1a87c

Same for me

Hello, @CryptoAssassin1 @kamal-sutra
I just updated code
Would you check again? cc: @MaxMillington

@forbesus still the error persists.

I can't check that work on my local environment
Could you create for test environment for me?
@kamal-sutra

@kamal-sutra the new build is not approved.
@MaxMillington can you please approve the build.

Still same error.

Hello @CryptoAssassin1
I think, we need projectId for Trustwallet
How about you? cc: @MaxMillington @kamal-sutra

I pushed updated code.
Would kindly you approve the build? @MaxMillington
And please review again @CryptoAssassin1 @kamal-sutra

@forbesus still getting same error on Mobile "Not found"

Hello @CryptoAssassin1
I just checked it with Keplr and Leap wallet. but It's not working well as same error with me.
https://app.osmosis.zone
The above site is not working well on mobile.
So that problem is not my side's problem.
Would you check it?

@forbesus main app is working fine on mobile just did a tx using Keplr mobile

I wanna create same environment with test server.
Would you give me projectId for me?
@CryptoAssassin1 @MaxMillington @kamal-sutra
3b4be8cf0d2bb54ce3fd6639fce12254 is test projectId that I created

@forbesus The same error for me too on TW. Keplr and Leap are working fine.

@forbesus you shouldn't need a project id from us. The one you created, (assuming you did it here: https://cloud.walletconnect.com/sign-in) should be fine

Hello @MaxMillington @CryptoAssassin1 @kamal-sutra
Would you check again?

@forbesus still same error

Currently Trust wallet is not support mobile wallet sign, I think

Currently mobile version is not working because of support.
How about deploying only web extension?
@CryptoAssassin1 @MaxMillington @kamal-sutra

@forbesus I've reached out to Trust Wallet team on this

Alright, great. @MaxMillington and I will wait on their response. I think it's a good call for now, and I'll also wait on your decision to disable mobile pending the update from Trust Wallet.

@forbesus I've reached out to Trust Wallet team on this

Hello @MaxMillington
I am waiting reply

i didn't get any answer from your team
would you tell me how to do this process?
@MaxMillington @CryptoAssassin1 @kamal-sutra

@forbesus Let's disable mobile

I disabled mobile wallet @MaxMillington
would you check it again?

@CryptoAssassin1 @kamal-sutra to check once the build is finished

@forbesus Deposits/Withdraws are unavailable for many important assets like TIA, Dydx, USDC, FET etc

@kamal-sutra Trust wallet don't support these tokens i think

Looking good otherwise. Approved.

there is some update 2 weeks ago @CryptoAssassin1
that part is updated another guy correctly
if i fix that, that will be conflict

would you approve again? @MaxMillington

there is some update 2 weeks ago @CryptoAssassin1
that part is updated another guy correctly if i fix that, that will be conflict

@JoseRFelix

@JoseRFelix can you take a look? I think otherwise this is about ready to be merged

Hello @MaxMillington
I pulled latest stage branch yesterday, so problem was fixed
you can check it here https://github.com/osmosis-labs/osmosis-frontend/pull/3231#pullrequestreview-2110305567
cc: @JoseRFelix

@forbesus please reach out to<EMAIL_ADDRESS>regarding the bounty payment

Thank you @MaxMillington

@forbesus can you forward the email also to<EMAIL_ADDRESS>and<EMAIL_ADDRESS>Thanks

Sure, I just sent email

@forbesus When clicked on Trust wallet to connect, it is not popping-up the wallet to login

@forbesus I got this error once when swapping, but after reconnecting the wallet it worked fine.


added legal links

Issue Resolved:#759
added legal links in the footer like terms of service, disclaimer etc.
before:

after:

Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
Fixes:  #759
Description
[Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.]

Type of PR

[ ] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes. Make sure to attach before & after screenshots in your PR.]
Checklist:

[ ] I have made this change from my own.
[ ] I have taken help from some online resources.
[ ] My code follows the style guidelines of this project.
[ ] I have performed a self-review of my own code.
[ ] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[ ] My changes generate no new warnings.
[ ] I have tested the changes thoroughly before submitting this pull request.
[ ] I have provided relevant issue numbers and screenshots after making the changes.

@Janmejai24 Your pull request has been successfully merged! Don't stop here—continue contributing by addressing more issues and aiming to become a top contributor. Exclusive swag awaits for those who go the extra mile!
Great contribution ! 🎉


CookieNotValidError

Hi! Everything worked for me. And now suddenly ceased with here such here error.

{"name":"CookieNotValidError","message":"Cookie sessionid you are searching found was either not found or not valid!"}

Nothing changed in the code.  Cookies cleaned. What could be the reason?

It seems that cookies host changed from i.instagram.com to instagram.com
However, simple change of HOSTNAME from constants.js does not help. Looks like instagram changed something else in their api

I understand the problem is not only mine?

I have a strange soft it works with the version of Instagram <IP_ADDRESS>.68. It works fine. Requests go all also to i.instagram.com

Just got this error when i tried to log in. Are there any workarounds?

Workaround if you are building with a local copy of instagram-private-api, change /v1/cookie-storage.js line 21 from
self.storage.findCookie(CONSTANTS.HOSTNAME, '/', name, function(err, cookie) {
to
self.storage.findCookie('instagram.com', '/', name, function(err, cookie) {
I refactored this to CONSTANTS.COOKIE_DOMAIN.
Seems to work, not sure of the ramifications..

It is true that the domain in cookies has changed. Change the cookie-storage.js string CONSTANTS.HOSTNAME for CONSTANTS.HOSTNAME.slice(2)

I think IG has rolled back the change they made that broke us. I'm getting the CookieNotValid/sessionid exception now when using my workaround above. Reverting that hack (or using i.instagram.com for COOKIE_DOMAIN) resolves the issue... So we're back to normal I guess?

Yeah, it seems that i can login again, thanks for you response @mellodev

I currently do face the same issue. I'll try the workaround.

IG now uses both domains. i.instagram.com and instagram.com
function CookieStorage(cookieStorage) {
    this.storage = Promise.promisifyAll(cookieStorage);
}

CookieStorage.prototype.getCookieValue = function (name,host=CONSTANTS.COOKIEHOSTNAME) {
    return this.storage.findCookieAsync(host, '/', name)
    .then(cookie=>{
        if(!_.isObject(cookie) && host === CONSTANTS.COOKIEHOSTNAME){
            return this.getCookieValue(name,CONSTANTS.HOSTNAME)
        }else if(!_.isObject(cookie)){
            throw new Exceptions.CookieNotValidError(name);
        }else{
            return cookie;
        }
    });
};

CookieStorage.prototype.getCookies = function (host=CONSTANTS.COOKIEHOSTNAME) {
    return this.storage.findCookiesAsync(host, '/')
    .then(cookies=>{
        if(!cookies && host === CONSTANTS.COOKIEHOSTNAME){
          return this.getCookies(CONSTANTS.HOSTNAME)
        }else {
          return cookies || [];
        }
    });
};

Sorry, but hot-patching third-party code isn't a preferred way to fix problems. @IvanMMM is there any chance you could do a PR so this can be fixed and merged and packaged right away?

@ifedapoolarewaju Would you do a PR based on your patch on your fork?

@ifedapoolarewaju That's not the best fix. I'l explain why. Let's say you want to check if session contains valid cookies.
Easiest way to do it is to check for session._cookiesStore.storage.idx['i.instagram.com']['/']['sessionid'], but in your case you will have to check for two places.
I recommend you to write all cookie files to the same store, same as searching for them at the same place. Don't care about IG domain.

\client\v1\jar.js
RequestJar.prototype.setCookie = function(cookieOrStr, uri, options) {
    cookieOrStr = cookieOrStr.replace(/Domain=\.?instagram\.com;\s?/,'');
    uri = this.rewriteUri(uri);
    return this._jar.setCookieSync(cookieOrStr, uri, options || {});
};

Its an issue with Async writing to file in tough-cookie-filestore package

@glazkoman @checho221 Mine are fine, since I use redis database as cookie storage

@IvanMMM yes it is completely different. Anyway fixed already
Thanks

Well i just said that not working for me @IvanMMM , so how can i prevent cookie rewrite on CookieNotValidError exeption?

Hey guys,
I'm still getting a
"CookieNotValidError: Cookie `sessionid` you are searching found was either not found or not valid!"

after installing the most recent version. "instagram-private-api": "^0.6.7",

@fostergn this is related to async writting like @glazkoman said, so you have to workaround in order to do not call CookieFileStorage twice or more times, so you have to call it sync for now.

does this mean creating the session sync instead of async @checho221 ? I'm currently:
  const device = new Client.Device(account.instagram.username);

  const storage = new Client.CookieMemoryStorage();

  const session = await Client.Session.create(device, storage, account.instagram.username, account.instagram.password)

does this mean instead calling const session = Client.Session.create(device, storage, account.instagram.username, account.instagram.password)
Thanks in advance for responding 👍

@fostergn  No, i mean  new Client.CookieFileStorage method, just call it sync and dont call it twice at time

@checho221 I'm running this as a functionless server, so I'm using CookieMemoryStorage() instead of CookieFileStorage(). I'm not invoking new Client.CookieMemoryStorage() twice and I assume that the code I've posted above is calling it async unless you mean calling Client.Session.create() should be done sync?

I'm still blocked on this. Wondering if I need to setup like a public webtask in order for someone to reproduce the issue

@IvanMMM could you please show a code example of how to use redis-cookie-monster as your storage when doing the login? I'm already using the new files from your branch, I just need to know how to use it now. Thanks in advance.

@yuceltoluyag >= 0.7 Version still having issues with cookies, look https://github.com/dilame/instagram-private-api/issues/632
Using 0.7 Version and old cookies work while changing i.instagram.com to instagram.com, but i found that is not always working, i am getting CookieNotValidError sometimes but is is disastrous because it is writing user.json files empty with 0kb, and it is breaking all functions

Hello. I want to user instagram-private-api that created from you. I want
to say that I used it 2 years ago, and everything is OK. But I see now that
you are doing changes. Global change TypeScript. I have a question. Can I
create session after login, and that session token using any request to
isntagram? For example if I want to get user (123789) last image (568974)
all liked accounts, I must do login, get user, get user image, and get
image liked account. I want to use token to do this steps. Can you help me?
Thank you. Regards from Vahagn.


No tagging when masking user's elfeed-feeds with another list and running elfeed-update.

I want to write a function that would update a different feed list each time it is called.
(defun update-a-different-feed-list-each-call ()
  (let ((elfeed-feeds (make-a-random-feed-list)))
    (elfeed-update)))

The function make-a-random-feed-list behaves correctly, producing a legal feed list each time, feed lists like:
'(("https://example.com/blog/rss" blog example)
  ("https://example.com/podcast/rss" podcast example))

The function elfeed-update adds new entries to the elfeed database with only the unread tag, without blog, example, or podcast.
If I define the function in this way:
(defun update-a-different-feed-list-each-call ()
  (setq elfeed-feeds (make-a-random-feed-list))
  (elfeed-update))

each of the new entries has the expected tags, but the user defined list of feeds is overwritten.
How do I provide a dynamically generated feed list for elfeed from which to fetch entries and properly tag them while also not overwriting the user configuration?

This one also only adds the "unread" tag:
(defun update-a-different-feed-list-each-call ()
  (let ((old-elfeed-feeds elfeed-feeds))
    (setq elfeed-feeds (make-a-random-feed-list))
    (elfeed-update)
    (setq elfeed-feeds old-elfeed-feeds)))


MultipleFileUploadEditor not able to upload file on host server

Hi,
I install aplication on windows server host , but MultipleFileUploadEditor not able to upload file. I get file, but cannot  be attached in form.
When I manualy add to nvrachar max filed in DB, it show attach file in form.
On my computer everything work ok.
Please help .

Check upload folder has write file permission

Hi, do you mean folder where picture is ?

Yes, the problem is folder read write perm...
Tnx


Reduce assembly time by disabling assemblyCacheOutput

Migrated from: https://github.com/snowplow/snowplow/issues/1668

@jbeemster have you tested whether this worked? It was still really slow when I did this for the Scala Stream Collector (https://github.com/snowplow/snowplow/issues/1665)

@fblundun no I did not get a chance to test it as of yet.  I just pulled it from the assembly.  I was thinking that your idea of beefing out our VMs might be the smarter route to solving the slow build issues.

Woops did not see your update!  So we need to start building in host instead of guest?

Sounds like the current plan is to get a build server, and meanwhile hope that the author of sbt-assembly works out what's causing the problem...


[bugfix] geohash lat/long is reversed

This allows support for reversing geohashes. Note that the default option was the wrong way.

Codecov Report

Merging #5695 into master will decrease coverage by 0.01%.
The diff coverage is 20%.

@@            Coverage Diff             @@
##           master    #5695      +/-   ##
==========================================
- Coverage   63.49%   63.48%   -0.02%
==========================================
  Files         360      360
  Lines       22934    22941       +7
  Branches     2555     2555
==========================================
+ Hits        14562    14564       +2
- Misses       8357     8362       +5
  Partials       15       15

Impacted Files
Coverage Δ

superset/viz.py
81.21% <16.66%> (-0.1%)
:arrow_down:

...src/explore/components/controls/SpatialControl.jsx
33.72% <25%> (-0.43%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80e7778...26a528d. Read the comment docs.


error using ONNXHelper

Hi,
I have created an ONNX model with Python (a neural network trained with Tensorflow and Keras), and I am tring to use ONNXHelper for using this neural network in Anylogic. But when execute the simulation I obtain this error:
Could not initialize class onnx_wrapper.OnnxHelper
In more detail:

I configurate teh ONNXhelper like that:

Am I doing something wrong?
Thanks for everything!
Belén Arroyo

Hi, so for your first problem, dyk what version you were on previously? Just useful info for my reference.
Also, in the second problem, the class it's looking for (red_neuronal.Simulation) is referring to the Simulation experiment of your current model (assuming it's named something like "Red Neuronal"). My guess is that it's some obscure AL issue from updating? Try closing your model, then restarting AL, and relaunching the experiment.

Hi,
I used the version of Anylogic 8.8.1. I did the steps that you explain there:
https://github.com/t-wolfeadam/AnyLogic-ONNX-Helper/wiki/Technical-Details#re-exporting-the-library
But it still didn't work. Finally, I upgrade my version of Anylogic, now I have the version <IP_ADDRESS>.2307181708. I add again the ONNXLibrary that you have in your git, and now I obtain this error:

Could the problem be in the way I have converted my trained model to ONNX format in Python? I use this command:
from tf2onnx.keras2onnx_api import convert_keras
proto = convert_keras(model)
onnx.save(proto, "test.onnx")
Thanks for everything!
Best regards,
Belén

Hi,
I solved the problem. I was exporting the model to the ONNX file from Python incorrectly. Now the problem is that the result I get for the prediction is different that the prediction I obtain with Python. Is the order of the input variables the same as you use when train the model?
I attach the model, the simulation in Anylogic and the Python script where I make the prediction.
test.zip
Thanks for everything!
Best regards,
Belén

Hi! So I was unable to load your pkl file - it appears issues in my version of keras (v2.7.0, Py3.9) likely being different from yours. However, I was able to load the onnx file and it shows the same results both in Python and AL.

My guess is that it's something in the conversion to ONNX that's lost or incomplete. I'm closing as it's not an issue related to the ONNX lib, but feel free to LMK if you have any other Qs. You can also try using my Pypeline library to load and query the pkl file that way, thus allowing you to use the unconverted format.


No link to scala code for https://trino.io/episodes/41.html Hudi

No link to Sagar Sumit scala code for https://www.youtube.com/watch?v=aL3PfMjvFM4&t=4671s

https://github.com/bitsondatadev/trino-getting-started/blob/main/hudi/trino-hudi-minio/hudiTestSync.scala


BurpBountyExtension line 174: Index 1 out of bounds for length 1

hi, at GenericScan.java  line 417
                                  if (grep.split(",")[1].equals("Or")) {
                                        grep_index = grep_index + 1;
                                        if (!grep.split(",")[2].equals("")) {
                                            greps_final.get(grep_index).add(grep.split(",")[2]);
                                        }
                                    }

throw error : Index 1 out of bounds for length 1
maybe
                                    if (grep.split(",")[1].equals("Or")) {
                                        if (!grep.split(",")[2].equals("")) {
                                            greps_final.get(grep_index).add(grep.split(",")[2]);
                                            grep_index = grep_index + 1;
                                        }
                                    }

Hi @a0xpg !
Thanks for the issue, sorry Im bussy and haven't time...
Yes this is the error, in the runResPScan and runReqPScan methods it is already set like this, but I would forget to fix it in the runAScan.
I will update the jar version of github, meanwhile you can download this jar and test it:
https://drive.google.com/file/d/1fZOmwZiTOW4V0S9rISiLbG7Ly_12ih0-/view?usp=sharing
Best regards.


Change render viewport resolution

The render viewport resolution is 640x480 by default. For example, is there an easy way to change this value to 1024x1024?
I searched for the issues and documentation but could not find any straightforward solution.
I am new to Mujoco and dm_control. I have seen discussions that involve manually creating a glfw window and assigning it to mujoco, but I did not find an equivalent process in dm_control.
I appreciate if someone can provide some link or some example code.

https://mujoco.readthedocs.io/en/latest/XMLreference.html#visual-global-offwidth


Add Cloud Adoption Guide to landing page

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/_images/cloud-adoption.svg
:white_check_mark:Succeeded
View

docs/_images/cloud-design-patterns.svg
:white_check_mark:Succeeded
View

docs/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/_images/cloud-adoption.svg
:white_check_mark:Succeeded
View

docs/_images/cloud-design-patterns.svg
:white_check_mark:Succeeded
View

docs/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


🚀 Feature: scaffolder optionally passes request to action handler

🔖 Feature description
Either through the context object, or as a separate argument, it should be possible to expose the request object from the express router in case there is a need for headers or request metadata.
🎤 Context
In my use case, I'm calling a microservice from a scaffolder action, and the security team has requested user request information as part of the required fields which is not available during the action, since the scaffolder only forwards req.params from the express router.  This has also been mentioned in the backstage discord's #scaffolder channel by another group on January 19 2024.
I've seen someone raise an issue that this is potentially a security smell, but I'm not well-versed enough in security to be able to comment one way or the other.
✌ Possible Implementation
Approximate concept:
scaffolder-backend/src/service/router.ts
// existing code:
const values = req.body.values

const template = await authorizeTemplate(
  { kind, namespace, name },
  token,
);

// proposed addition, kludgy, can definitely be improved
if (template.spec.EXPERIMENTAL_contains_request) {
  values.req = {...req} // potentially do some kind of destructuring to avoid exposing auth headers.
}

👀 Have you spent some time to check if this feature request has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

Hey :wave:
Thanks for raising this!
Yeah, I think unfortunately, it's a little bit of a security problem here for us to store request objects. They can contain sensitive credentials which we don't want to expose to actions without explicitly marking them as secrets.
What's the use case here? Do you just want to decorate user-agent headers on the request to the downstream service?
You have access to the backstageToken in the actions which contains some user information from who triggered the request too if you're wanting to pass that along?


Add an optional share button to the Web view?

It would be a usability boost if we could share a webpage from the Webview.
To me, ideally, there could be a setting letting you swap one of the buttons in the bottom bar with a button that triggers the Android share sheet.

There's two ways to share right now:

Swipe up and press the share button connected to the post. This only shares the HN link or the main webpage though.
Press open in browser and share from there.

I think these are enough as the last one covers the case where the user has navigated to some new webpage and (more generally) need more tools than the webview provides (such as sharing).


Handle asynchronous functions

The order of execution of the functions is unpredictable, due to the not handled async code

With this commit asynchronous functions are temporarily handled by using only synchronous functions to write to the filesystem.
If it is necessary to increase performance, open another dedicated issue.

Merged into branch


Redeem request handler

Stared working on it as PR #177 is dependent on implementation of this ticket.


Upgrade to latest jupyter lsp and skip intellisense when inside a cell

As a counter part to this PR: https://github.com/microsoft/vscode-jupyter/pull/7924 this PR removes notebook intellisense from the python extension.

No, looks good to me, i'm just checking why some test are falling

Updating to latest main bits. Looked like there were errors in some Terminal tests (which shouldn't have been impacted by the changes in this pr)

@paulacamargo25 the tests that are failing are also failing in other PRs. See this one here:
https://github.com/microsoft/vscode-python/runs/3900589033?check_suite_focus=true
Can we submit this change over the failures?


namespaceSelector label should be kubernetes.io/metadata.name

Setup
I enabled network policies to allow traffic only from my prometheus instance:
networkPolicies:
  enabled: true
  prometheus:
    namespace: monitoring
    port: 9090
    labels: {}

This creates the following network policy:
# Source: opencost/templates/networkpolicy.yaml
apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: opencost-opencost
  namespace: opencost
spec:
  podSelector:
    matchLabels:
      app.kubernetes.io/name: opencost
  policyTypes:
    - Ingress
    - Egress
  ingress:
    - from:
      - podSelector:
          matchLabels:
            app.kubernetes.io/name: prometheus
        namespaceSelector:
          matchLabels:
            name: monitoring
      ports:
      - port: 9003
  egress:
    - to:
      - podSelector:
          matchLabels:
            app.kubernetes.io/name: prometheus
        namespaceSelector:
          matchLabels:
            name: monitoring
      ports:
      - port: 9090

Issue
Target is down. Prometheus cannot scrape the opencost pod.
Custom Fix
According to docs the label key name should be kubernetes.io/metadata.name
Current implementation
namespaceSelector:
  matchLabels:
    name: monitoring

Working implementation:
namespaceSelector:
  matchLabels:
    kubernetes.io/metadata.name: monitoring

In my setup I use an external Prometheus and deployed my own networkPolicy. Therefore I am not affected. I shortly installed Prometheus with the docs from OpenCost and both labels got set:

So, if using the docs to setup OpenCost, it should not be a breaking change if switching to the official label. However if it is a custom setup, it may breaks. An other approach would be to add something like podLabels and namespaceLabels to the networkPolicy part, in order to support custom labels.
Any thoughts from the maintainers on this?

So to clarify, do we need to change
https://github.com/opencost/opencost-helm-chart/blob/main/charts/opencost/templates/networkpolicy.yaml#L27
and
https://github.com/opencost/opencost-helm-chart/blob/main/charts/opencost/templates/networkpolicy.yaml#L41
to
kubernetes.io/metadata.name: {{ .Values.networkPolicies.prometheus.namespace }}
in the templates?

We'll gladly take a PR with the change, just wanted clarification

This was fixed
https://github.com/opencost/opencost-helm-chart/blob/main/charts/opencost/templates/networkpolicy.yaml#L27


LinkDatabase auto update on Sync

LinkDatabase processor and config, to keep LinkDatabase up to date.
Not sure I entirely agree with the disabling of event handlers in general though. They are there for a reason. Is this a global setting actually?  can that behaviour be disabled?

You cannot currently disable event disabling. Having events run during Unicorn is a bit of a hand grenade. Sure you can have semi-benign events like link db updates or index updates. But you can also have deadly ones that try to move items around as you load them, or rename items, or otherwise cause massive performance issues with syncing (and you know where people would come with those issues...).
The original reason for event disabling was that "Sitecore serialization does it" (and it still does).

TODO (and @cassidydotdk I mean for me, unless you want to take this on):

Move this config into a syncConfiguration dependency so that individual configurations can choose to use it or no
Add index updating as an option to the same sync config dependency
Add max concurrency as an option as well (#80, works for non-template configs)
Console output for link and index execution, since at times it might take a while. See if we can batch/queue index updates somehow?

Index updating can be a pipeline just like this one, which can resolve the dependency and if it should run, run it.

I think the use case for Unicorn differs from "regular" Sitecore Serialization. The original feature was always meant to be something like; "I'm a developer, and I'm about to test this 1337 script on some content - I better make a backup before I run it". At least that is how I interpret it, given you need to be in the "Developer" role to even access it.
Unicorn is used in a broader setting. For instance we've used Unicorn to deploy (in full or partially) content to UAT environments and to pull content backwards from Live environments. And when used like this, keeping the LinkDB up to date is important. This would probably also apply to other events as well however - like updating indexes and so on.
I do see the problem with over zealous event handlers though.
Perhaps this feature should be changed, so instead of "just" updating LinkDB - we could instead find a way of defining which events we're ok with running?  this would then by default be a selection of Sitecore OOTB events. Thoughts?

Events are pretty much an all or nothing thing, but the whitelist you propose is more or less what I'm suggesting above - to allow you to select on a per configuration basis that you care about indexing and link DB.
So for developery things where it probably does not matter (templates, renderings), you can have mad speed. And for content, where it may matter, you can enable the handlers to make it get updated.

Yea ok, I see your point. So this syncConfiguration dependency...  not sure I've looked at that. Got any pointers?    I don't mind pitching in here, seeing that I care quite a bit for this particular feature ;-)

Note to self: need to make sure transparent sync respects this config for links and index when files are updated

I won't be able to use this PR directly since I needed to make wider config changes, but refer to https://github.com/kamsar/Unicorn/commit/b0c2e89e4997e15323f5830449429cb612f5d7a0 for an initial implementation.

And https://github.com/kamsar/Unicorn/commit/e3775eb040733ee2f05b5794c0752bccd16e5cc6 gives transparent sync the same updating capabilities.
That said the implementation is imperfect, in that it cannot handle deletions. This is because the index and link DB APIs both require Item. At the point the sync completes, or when TpSync signals a file change has completed, the deleted item is gone from the DB so we have nothing to use to tell those APIs to get rid of the item.
We might be able to get around it for indexes in part by keeping deleted items' URI around. I'm open to your suggestion/PR if you have ideas around improving this.

Of note for the item deletions, we might be able to hitch directly into https://github.com/kamsar/Unicorn/blob/master/src/Unicorn/Evaluators/SerializedAsMasterEvaluator.cs#L54 (NOTE: we don't directly have Item here either, only IItemData. Introducing a dependency on Item is a bit ugly since we like abstracted APIs, but it'd be where the items get toasted.

Closing this PR. Feel free to open a new PR with tweaks to the implementation I made, or an issue with comments.


[mattermost-team-edition] read only file system ONLY FOR >=5.30

When i run mattermost images >= 5.30 mattermost wont start due to Error: failed to load configuration: failed to create store: unable to load on store creation: failed to persist: failed to write file: open /mattermost/config/config.json: read-only file system
image:
  repository: mattermost/mattermost-team-edition
  tag: 5.31.0-rc2
  imagePullPolicy: IfNotPresent

When i switch to older versions like 5.29.1 mattermost will start.

@r3kzi I faced the same issues. I think solution is to add fsGroup in the deployment manifest.

@r3kzi I faced the same issues. I think solution is to add fsGroup in the deployment manifest.

@debarshibasak i think so too :-) Do you think this project here is open for PR's? Based on the already opened PR it seems abandoned.

@debarshibasak i think so too :-) Do you think this project here is open for PR's? Based on the already opened PR it seems abandoned.

@debarshibasak @r3kzi do you have a workaround using the current Helm Chart?
It seems like the current focus is on the Mattermost Operator these days..

I think the best approach is to move the configuration to the DB, which is supported since 5.12 and then we avoid this thing, but that also will require changing things in the chart and also might have some breaking change.
I will look around for ways to fix that

Please fix this issue ASAP, 5.29 is out of support since 2021-02-15!

Another opertunity is to use a init container which has the configmap mounted and just copies the config to the right place in the filesystem. This approach should not break compatibility.
When I find some time at the weekend I will create a PR.

Yes, this is a problem, but since some releases ago MM supports the config in the DB, I think this will be the correct approach to deal with that, and any special configuration we can set as an environment variable.
I will work on that to get this fixed in the next following weeks

Dear @cpanato ,
Any updates on this issue ?

Yes, this is a problem, but since some releases ago MM supports the config in the DB, I think this will be the correct approach to deal with that, and any special configuration we can set as an environment variable.

Or where can I get a documentation on setting the config.json on the postgres database? Since the documentation on mattermost.com refers to server installation and on kubernetes installation config.json is still read-only and gives error when I try to mattermost config migrate XXX, I am a little stuck.
Thanks.
PS: I am new to the community but loved the platform. So, as a new comer, sorry if I had unrelated questions.

@OgulcanCankaya I'm planning to refactor the Mattermost helm TE chart, but I did not have time yet to focus on this.
sorry for any issues, I will start working on this next week.

Thanks for quick response, in my company I am trying to set a Mattermost culture which can give us the freedom of keeping our own data but I am unable to meet some feature requests :) . Thats why I asked. I will work on a workaround for this issue. If successfull, I will share my solution from here for kubernetes installations.
Good days to y'all

I'm very interested on this one too, let us know if there is a way to help you on this one.

Company is wanting to move to MM from Slack. This is blocking us right now.

Hi @NeckBeardPrince ,
There is a workaround. From the helm charts's values.yaml file, edit "extraEnvVars:" part and add
name: MM_CONFIG
value: postgres://postgres.........../mattermost

this way the system configuration will be added to the database. Therefore no read-only filesystem problem. But after that, make a backup with the database and try to restore. Than you can be sure.
@cpanato if you guys can fix the image/charts we will still be grateful. Thanks for the work.

Hi @NeckBeardPrince ,
There is a workaround. From the helm charts's values.yaml file, edit "extraEnvVars:" part and add
name: MM_CONFIG
value: postgres://postgres.........../mattermost

this way the system configuration will be added to the database. Therefore no read-only filesystem problem. But after that, make a backup with the database and try to restore. Than you can be sure. I was able to use 5.35 image after that.
@cpanato if you guys can fix the image/charts we will still be grateful. Thanks for the work.

Thanks for pointing this out! I had to redo most of my configuration in the GUI but it worked without problems.
I could then also upgrade to MM 5.35.1 which is the latest version.

No problem at all @belfhi , happy to help
Thinking @cpanato has work to do, I buried myself into the configuration documentation. But I think that we might need a solution for

I had to redo most of my configuration in the GUI but it worked without problems.

this too.
Also, I found an error which is also connected to the filesystem ownership and permissions, data and plugin directories in the container are root owned. This also creates an error of filesystems and users cannot upload a profile picture and etc. We are able to change the data directory but we can not change the plugins directory and therefore we can not install plugins. Should I open a new issue about this ? Because I believe that if we can upload a predetermined configuration to the database we can edit it. Can you guys help me out a little?
Thnx.
Btw, I quit my job so I no longer have access to the systems but I can replicate them somehow for you guys.


remove generated file data/python_parser.py, and add demo target in Makefile

https://github.com/we-like-parsers/pegen/issues/61

@MatthieuDartiailh

Since you added a description to the readme a changelog entry would not help that much so merging. Thanks for your contribution.


Unable to use Gitea OAuth

Component
server
Describe the bug
During integration with Gitea (v1.21.4 - latest stable) I encountered impossibility to successfully establish connection between these tools (Gitea and Woodpecker-server)
Testing was done on fresh install of Gitea as well as fresh install of Woodpecker-server using single binaries in Go.
All secrets down are just for testing not used in production.
System Info
Ubuntu 22.04 LTS - amd64 platform, fresh install

woodpecker-server - version 2.3.0, amd64, single Go binary

gitea - version 1.21.4, amd64, single Go binary

Additional context
Woodpecker-server .env file
WOODPECKER_OPEN=true
WOODPECKER_HOST=http://{{woodpecker-server_ip}
WOODPECKER_SERVER_ADDR=:80
WOODPECKER_GITEA=true
WOODPECKER_GITEA_URL=http://{{gitea_ip}}
WOODPECKER_GITEA_CLIENT=6b9afe7b-3762-47ac-9229-215132a632b7
WODDPECKER_GITEA_SECRET=gto_qppqoqkhni2ygpvqnlzdc6rbpnsttwxw6oyx46hx56hmw2f3h26q
WOODPECKER_LOG_LEVEL=debug
WOODPECKER_GITEA_SKIP_VERIFY=true
WOODPECKER_ADMIN=testadmin

Gitea Config

Error from Woodpecker-server debug log
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/api/stream.go:82 > user feed: connection closed
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/router/middleware/logger.go:59 > ip={{client_ip}} latency=471058.889328 method=GET path=/api/stream/events status=200 user-agent="Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0"
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/router/middleware/logger.go:59 > ip={{client_ip}} latency=0.106724 method=GET path=/login status=303 user-agent="Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0"
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/router/middleware/logger.go:59 > ip={{client_ip}} latency=0.094983 method=GET path=/authorize status=303 user-agent="Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0"
9:47PM ERR ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/api/login.go:53 > cannot authenticate user error="oauth2: \"unauthorized_client\" \"invalid empty client secret\""
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/router/middleware/logger.go:59 > ip={{client_ip}} latency=846.891801 method=GET path=/authorize status=303 user-agent="Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0"
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/router/middleware/logger.go:59 > ip={{client_ip}} latency=0.039107 method=GET path=/login status=303 user-agent="Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0"
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/router/middleware/logger.go:59 > ip={{client_ip}} latency=0.044988 method=GET path=/login/error status=200 user-agent="Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0"
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/router/middleware/logger.go:59 > ip={{client_ip}} latency=0.240156 method=GET path=/web-config.js status=200 user-agent="Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0"
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/router/middleware/logger.go:59 > ip={{client_ip}} latency=0.039593 method=GET path=/assets/custom.css status=200 user-agent="Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0"
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/router/middleware/logger.go:59 > ip={{client_ip}} latency=0.078753 method=GET path=/assets/custom.js status=200 user-agent="Mozilla/5.0 (X11; Linux x86_64; rv:122.0) Gecko/20100101 Firefox/122.0"
9:47PM DBG ../../woodpecker/src/github.com/woodpecker-ci/woodpecker/server/api/stream.go:63 > user feed: connection opened

Error from Gitea debug log

2024/02/01 21:47:46 ...eb/routing/logger.go:102:func1() [I] router: completed GET /login/oauth/authorize?client_id=6b9afe7b-3762-47ac-9229-215132a632b7&redirect_uri=http%3A%2F%2F{{woodpecker-server_ip}}%2Fauthorize&response_type=code&state=woodpecker for {{router_ip}}:53446, 303 See Other in 199.0ms @ auth/oauth.go:362(auth.AuthorizeOAuth)
2024/02/01 21:47:46 ...eb/routing/logger.go:102:func1() [I] router: completed POST /login/oauth/access_token for {{router_ip}}:45254, 400 Bad Request in 442.7ms @ auth/oauth.go:618(auth.AccessTokenOAuth)
2024/02/01 21:47:47 ...eb/routing/logger.go:102:func1() [I] router: completed POST /login/oauth/access_token for {{router_ip}}:45254, 400 Bad Request in 379.7ms @ auth/oauth.go:618(auth.AccessTokenOAuth)

Validations

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]

Logs says "oauth2: \"unauthorized_client\" \"invalid empty client secret\"". Does the secret/env var really exist in the container?


Replace Behaviour with Behavior

Description
Provide a brief description of the PR's purpose here.
Fixes #381

Failing tests are just because we don't provide access to the OpenEye license from forks. Thanks for the fix!


Make kubectl explain work with kapp-controller CRDs

The kubectl explain command is a great way to get documentation about resources.
Currently, the App CRD does not provide documentation via kubectl explain:
$ kubectl explain app.spec
KIND:     App
VERSION:  kappctrl.k14s.io/v1alpha1

DESCRIPTION:
     <empty>

Thanks for opening this @alexbrand. I think it makes sense to provide descriptions for our CRDs.
I haven't fully looked into it yet, but we can look into how knative eventing approached the problem for more consideration into it.

yeah, should be able to do that with bump to CRD v1 (https://github.com/vmware-tanzu/carvel-kapp-controller/issues/38) and addition of openapiv3schema field.

also, controller-gen crd now supports v1, so that could be all auto generated

This should now be available with our upgrade to CRD v1. With regard to the example above (kubectl explain app.spec), it would be nice for us to add description comments for each field and regenerate the CRD schemas using the ./hack/gen-crds.sh. Currently, we have limited comments for fields:
$ k explain app.spec
KIND:     App
VERSION:  kappctrl.k14s.io/v1alpha1

RESOURCE: spec <Object>

DESCRIPTION:
     <empty>

FIELDS:
   canceled     <boolean>
     Canceled when set to true will stop all active changes

   cluster      <Object>

   deploy       <[]Object>

   fetch        <[]Object>

   noopDelete   <boolean>
     When NoopDeletion set to true, App deletion should delete App CR but
     preserve App's associated resources

   paused       <boolean>
     Paused when set to true will ignore all pending changes, once it set back
     to false, pending changes will be applied

   serviceAccountName   <string>

   syncPeriod   <string>
     Controls frequency of app reconciliation

   template     <[]Object>

We do have descriptive comments on our website for each CR that could be added above each field in the source:

https://carvel.dev/kapp-controller/docs/latest/app-spec/
https://carvel.dev/kapp-controller/docs/latest/packaging/

This way descriptions will show up with each field using kubectl explain.

Moving this to the unprioritized-backlog for now but we'll accept contributions for this.

confirmed that this has been resolved (probably in 0.20.0)

I am going to reopen this as we still want to track work mentioned in comment above. Part of this issue is that there are also not a lot of field descriptions for our CRs through kubectl explain.

Removed the carvel-triage label to prevent the GH actions bot from adding the stale label.


Removed auto-decoding from std.conv.parse (part 2)

Benchmark code here: https://gist.github.com/JackStouffer/af53d497532a864f56a5b53cb35cd438
Gives about a 40% speed increase:
# old
$ ldc2 -O5 -release -boundscheck=off test.d && ./test
Total time: 5 secs, 266 ms, 64 μs, and 3 hnsecs

# new
$ ldc2 -O5 -release -boundscheck=off test.d && ./test
Total time: 3 secs, 295 ms, 663 μs, and 7 hnsecs

Ping @9il

Current coverage is 88.68% (diff: 100%)

Merging #4674 into master will decrease coverage by <.01%

@@             master      #4674   diff @@
==========================================
  Files           121        121
  Lines         73826      73832     +6
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          65471      65476     +5
- Misses         8355       8356     +1
  Partials          0          0

Powered by Codecov. Last update 77bee52...7d53423

LGTM

Please add small msg to change log

@9il Done

@JackStouffer  please add test with global __gshared char[] integer number and pragma(inline, false) for parse functions. 4x-5x is large number, so,  we need to be sure that LDC optimisation does not brake the test.

@JackStouffer please add test with global __gshared char[] integer number and pragma(inline, false) for parse functions. 4x-5x is large number, so, we need to be sure that LDC optimisation does not brake the test.

IIRC @klickverbot pointed out that a good way to prevent LDC optimizations is to use separate files & annotate the tested methods with extern.
I have a small repo for benchmark scripts which are separately compiled and then linked, maybe that helps you?

btw, pragma(inline, false) works correctly only in the recent LDC alpha, or master

Rebased.
Will add extra test when I get time.

@9il I updated the benchmark code here to your requests: https://github.com/dlang/phobos/pull/4597

Ping @9il

This doesn't look right. Most code should stay the same. The only change is at the top level, where decodable strings should be replaced with byChar or .representation.

Where is part 1? I hope it doesn't make similar changes... :)

@andralex Here's the problem, as outlined here

The reason why this is so messy is parse takes its range by ref, so byCodeUnit cannot be used without using refRange, which requires using &r, which is unsafe. So the only solution left is to do it manually with a bunch of static ifs.

I tried putting the refRange.byCodeUnit in a @trusted block, but that resulted in a speed pessimization (I'm guessing due to the inability to inline at that point).

@JackStouffer then just work on a temporary and in the end assign the reference from it. It's a classic.

I don't understand. Operate on a temporary and reassign it how?
If I make a copy of p inside of parse and then use byCodeUnit on that, the copy of p is copied again by byCodeUnit and that is advanced and not the copy of p. So I would still have to manually popFront the copy in order to reassign it to p.

Ping @andralex @9il

@JackStouffer it is save to reassing ubyte array to string after intefer parsing. Please implement Andrei's suggestions

I will get back to this eventually. I'm a bit swamped with school and work right now, so maybe around Thanksgiving.

@JackStouffer thanks, ping me when ready.

Closed in favor of https://github.com/dlang/phobos/pull/5015


Need manually free return memory  when use td_receive in  ptyhon ?

when i use python to call the libtdjson.so . Need i should free the return of function td_receive manually? i think the fuction return c_char_p.

No, the message will be freed automatically on the next function call.

thanks


Foreign key and references clash

GORM Playground Link
https://github.com/go-gorm/playground/pull/315
Description
The preload in the example on the 'Created' field fails in the last version of Gorm. It can be fixed in that version by using references:CreatedBy;foreignKey:PK as the tag, otherwise it will try to join on the CreatedBy field of Account instead of the `PK field.
This used to work in version 1.20.7. Is this supposed to be like this?

seems works with latest version.


etcdv3: we handle watch errors, so don't log them at Error level

One of our customers sees these ERROR logs periodically because of
compaction:
<date> [ERROR][427981] felix/watcher.go 128: Watch channel error error=etcdserver: mvcc: required revision has been compacted

To be precise, about 2 times per week.  But they investigate any ERROR
logs, and as these are actually benign and expected, they should be
downgraded.
Release Note
Downgrade a benign ERROR log that occurs when etcdv3 datastore is compacted.

I'm sorry but I failed delete the branch after merging the pull request.

Cherry pick from https://github.com/projectcalico/calico/pull/5547


Highlitghting is broken after update to Sublime 3 Build 3114

I've tried closing all files in all projects, removing the package, closing Sublime, opening it and installing the package again, the issue persists.

#106 This should repair it

How do you edit that file? Where does it live on my computer ( on a mac )

@ndran You need to install the PackageResourceViewr package first.
Then Ctrl (Command for mac)+Shift+P -> Open Resource -> Laravel Blade -> blade.sublime-syntax
This will open the file for you. Edit and save as usual

Thank you! @overcrookd

thanks @overcrookd

Thank you!  @overcrookd


Cannot read property 'state' of undefined. using createFluidNavigator

I am converting my existing createStackNavigator code to start using fluid navigator but can't figure out how to pass the navigation prop.
My old render code looks like
const routeConfig = ngData.tabs.reduce((routes, tab) => {
    routes[nodeId + '/' + tab.tabId] = {
        screen: (screenProps) => (<ConnectedNode  ..... navigation={navProp} />),
        navigationOptions: ({ navigation }) => {
            navProp = navigation;
            .
            .
            .
        }
    }
    return routes;
}, {});

const StackNav = new createStackNavigator(routeConfig, {
    initialRouteName: this.defaultRoute,
    onTransitionEnd: (props) => (
        navigatorMgr.onTransitionEnd(nodeId, props)
    ),
    transitionConfig: () => ({
        containerStyle: {
            backgroundColor: backgroundColor,
            flexGrow: 1
        }
    })
});

return (
            <View style={css} onLayout={layoutFn}>
                <StackNav />
            </View>
        )

I am changing the createStackStackNav to createFluidNavigator
const StackNav = createFluidNavigator(routeConfig, {
                    initialRouteName: this.defaultRoute,
                    onTransitionEnd: (props) => (
                        navigatorMgr.onTransitionEnd(nodeId, props)
                    ),
                    transitionConfig: () => ({
                        containerStyle: {
                            backgroundColor: backgroundColor,
                            flexGrow: 1
                        }
                    })
                });

const { navigation } = this.props;
return (
            <View style={css} onLayout={layoutFn}>
                <StackNav />
            </View>
        )

but this fails because the navigation prop is not set properly when it gets to createNavigator.js. Where and how does the navigation prop get set? what am i missing ?

I also just tried the example at<EMAIL_ADDRESS>and I get the following error
ExceptionsManager.js:76 TypeError: Cannot read property ‘state’ of undefined
This error is located at:
in Navigator (at App.js:122)
in RCTView (at View.js:44)
in App (at renderApplication.js:34)
in RCTView (at View.js:44)
in RCTView (at View.js:44)
in AppContainer (at renderApplication.js:33)
Any ideas ?

Any luck? It seems to that a recent change in react-navigation is causing this.


"Buy Now" button does not present a "guest" flow option when cards (funding icons) are enabled.

I'm using an unbranded "buy now" button with the cards displayed.
(label: 'buynow', fundingicons: true, branding: true)
With past versions, after pressing the "Buy Now" button, the modal presented a choice of paying with an account or a "guest" credit card checkout flow without an account.
With 4.0.229, after selecting "buy now" the modal presents only two options:  sign in, and enter a card to create an account.
Only clicking on a card image presents the modal with a guest option.
Is this new behavior?
If so, was the change intentional?
Steps to reproduce:
navigate to https://developer.paypal.com/demo/checkout/#/pattern/buynow
click "buy now"

Experienced the same issue.

Hey guys, this is intentional. The goal here is to present the buyer with the flow they've intentionally chosen. Clicking a card button will open up guest checkout, and the PayPal button will open member/signup. In layouts where the cards are not displayed, the PayPal button will act as a catch-all and the buyer will be presented the option to checkout as a guest once they're in the Checkout flow.

Thank you for clarification. Much appreciated.


Latest

Coverage increased (+0.01%) to 98.832% when pulling bf002d97efa74e5b6f84f2ac6598c1a04077e207 on iOffice:latest into b2d7d4c4a9a37d5ab7c85eccdcd056fbfaf27506 on lovell:master.


App hangs and eventually throws an AccessViolationException when getting text from a RichEditBox and updating the UI too quickly

Hello, I'm working on an app that relies on the RichEditBox control (Brainf*ck#) and I keep getting AccessViolationExceptions every now and then.
I've found another way to reproduce one of these, it usually happens whenever I get the text from the RichEditBox too quickly and then edit the UI.
This is the usual crash popup I get: http://i.pi.gy/PQql.png (the underlined text says "Unhandled win32 exception in ...").
Unfortunately VS won't let me create a crash dump (that option is grayed out) so I don't have that right now. Still, I'll be happy to share the code and more details on the issue if that can help.

The program '[11364] Brainf_ck-sharp.UWP.exe' exited with code -1073741819 (0xc0000005) 'Access violation'.

This is the general idea: I'm displaying some UI overlays over the RichEditBox to show the whitespaces and the tab characters in the text. I do this by retrieving the text every time it changes, getting the coordinates of every ' ' and '\t' character, then adding a new UI element in a Canvas that overlays the RichEditBox.
I know it would probably be better to just have a Win2D canvas on top of the RichEditBox and to draw the overlays in there, I'll probably look into it in the future, for now I'm just using actual UI elements (plus, I wouldn't have discovered this issue if I had used Win2D from the start).
Edit: I've implemented the overlays with a Win2D CanvasControl behind the RichEditBox and everything seems to be working fine (I'm keeping the 500ms delay just in case though). Still, that AccessViolationException shouldn't be thrown when working with simple UWP controls.
I'm using a SemaphoreSlim object to make sure that I'm never getting the text from the RichEditBox or adding new UI elements concurrently, but I'm still getting that AccessViolationException.
Note: the whole thing works fine most of the times, but if I just keep the spacebar key down so that the RichEditBox keeps quickly adding spaces in the text, the crash eventually happens (that's why I think it could be a synchronization issue or something like that).
I've solved this by adding a 500ms delay between the TextChanged event and when I actually update the UI, and by making sure I never update the UI with less than a 500ms interval between each call. Also, I'm skipping new TextChanged events if they happen before 500ms since the last one that got handled.
This seems to have fixed the issue (as a workaround), so I guess there's some kind of synchronization problem within the RichEditBox or somewhere in one of the UWP libraries.
I know the description can be a bit vague, so again, I'll be happy to share the source and the steps needed to reproduce the issue. Thank you in advance for your help!
Sergio

Hi Sergio, thank you for reaching out.
We believe that we have fixed both this issue and the one mentioned here, as both stemmed from the same issue. As you mention above, the root cause of this bug had to do with a multi-threaded timing issue between the XAML framework control and the underlying text stack.
This fix should be coming your way in an upcoming Windows Insider build post-Fall Creators Update (build numbers higher than 17000+). Please reach out if you find that this issue still hits.


[RHCLOUD-17536] Add /sources/:id/check_availability Endpoint

Adds the endpoint to request an availability status for a source.
It basically follows this flow:

Lookup source (and basically all of its subresources)
Loop through applications, sending http requests to the configured endpoint (set in deploy/clowdapp.yml)
Loop through endpoints, checking to see if the source is a satellite source, then proceeding to produce kafka messages for the source.

# TODO:

[x] tests, shouldn't be too bad.

/reset

/retest

/retest


Could not resolve './Deselect'

How can I resolve the following error?
*✓ 287 modules transformed.
Could not resolve './Deselect' from node_modules\vue-select\src\components\childComponents.js
error during build:
Error: Could not resolve './Deselect' from node_modules\vue-select\src\components\childComponents.js
at error (C:\laragon\www\fig\node_modules\rollup\dist\shared\rollup.js:158:30)
at ModuleLoader.handleResolveId (C:\laragon\www\fig\node_modules\rollup\dist\shared\rollup.js:22345:24)
at C:\laragon\www\fig\node_modules\rollup\dist\shared\rollup.js:22319:26
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

This occurs when running yarn build

I managed to fix this myself.
The import statements in the childComponents.js file were referencing vue files.
I updated this file to include the vue file extension for the referenced files.
So I changed:
import Deselect from './Deselect'
to
import Deselect from './Deselect.vue'
This update corrected the issue.

C:\laragon\www\fig
λ ls -lh  node_modules\vue-select\src\components
total 39K
-rw-r--r-- 1 clawes 1049089 649 Nov 30 21:15 Deselect.vue
-rw-r--r-- 1 clawes 1049089 431 Nov 30 21:15 OpenIndicator.vue
-rw-r--r-- 1 clawes 1049089 35K Nov 30 21:15 Select.vue
-rw-r--r-- 1 clawes 1049089 135 Dec  2 17:22 childComponents.js
C:\laragon\www\fig
λ cat node_modules\vue-select\src\components\childComponents.js
import Deselect from './Deselect.vue'
import OpenIndicator from './OpenIndicator.vue'
export default {
Deselect,
OpenIndicator,
}

Hi @clawes , sorry for the late response. If I am not wrong, the best way you should have solved this instead of changing the vue-select library would be to check how you are importing vue-select in the InfiniteSelect and JigSelect components.
If the components are importing from vue-select/src/..., change them to simply import from vue-select.
This is because previously we were using a temporal fork of vue-select that supports vue3 but we recently reverted back to the original vue-select package since they upgraded to support vue 3.

Summary:

In both resources/js/JigComponents/InfiniteSelect and resources/js/JigComponents/JigSelect, Change the following import:

import vSelect from "vue-select/src/index";  //<--- Replace this
import vSelect from "vue-select";  //<--- With this

In package.json, ensure you are using the latest vue-select ("vue-select": "^4.0.0-beta.1") and update the node modules.


Limit number of entities queried per update

This is basically a major performance fix, because if we can weaken our updates so that we're only querying a configurable, say... 10 entities per tick? and updating their relevant sites appropriately, we could completely flatten the mod's performance curve. A (possibly unwanted; maybe acceptable) side effect would be that, with more entities tracked, it takes longer for each specific site to be updated; this also potentially complicates the ore/minute calculation, though if we push that down into a per-entity property, we can totally make it work.
Mechanically, this would involve keeping track of entities in a master reference table, where for each entity we remember its position (as the primary key?), quantity, and probably ore/min, which sites could thereafter reference into (ideally also with a reverse reference -- when you have the entity, be able to reach the site(s) containing it to update them).
For further enhancement, I'm thinking it's a good idea to keep a non-persistent reference table to the actual entities, such that we can then avoid running a surface.find_entities every time we want the new quantity of a known entity (non-persistent because keeping it in global.* slows down the save/load times).
Also relevant, with #46 we can avoid querying entities that aren't within a miner's range, and thus speed things up even more.

While implementing #98, it turns out the save/load slowdown from keeping entities in global.* is manageable -- on the test machine, it's about 10-ish seconds for 62k entities, while a more reasonable 4k entities weren't even noticeable. We can't avoid persisting the entity cache (because desyncs), but we don't actually have to.
Tracking the rate-of-change per entity rather than per-site sounds interesting, so we'll move that out into its own issue. It's not clear that it'll make much difference, though.


Subemitter emission at end now correctly emits at end

Particles were previously arbitrarily emitting "at end" at 95% of lifetime. Probably worked ok for most particles, but for long living particles it's really really visible.

Remember to capitalize your commit messages ;)

Thanks!


feat(minifier): remove unnecessary "use strict"

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#8174
#8173  👈 (View in Graphite)
#8172
main

How to use the Graphite Merge Queue
Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This is not ideal, I'll try something else later.


Nuttx next cmake, modify nsh script syntax to wrap variables in {} as required

modify the syntax of environment variables to encase those that are not standalone in braces { } to ensure the nuttx_next nsh parser expands them correctly

Nice!


Adding MailChimpConnectorProfile

Fixes # This PR adds the MailChimp connector profile using api_key connection.

@remitache please take a look on PR I created to your branch - fixed few problems with profile etc https://github.com/remitache/cdk-appflow/pull/1

@remitache thanks for your contribution, really appreciate.
@rpawlaszek @kozub please double check and approve

Related issue: #152


Context menu is not working in Angular 9

I have updated my application from angular 8 to 9.
ngx-contextmenu is not at all working in angular 9.
I have updated the packages version to recent also but still context menu is not showing up.
Any help would really appreciated!!

Angular: 9
CDK/Material<EMAIL_ADDRESS>Browser(s): Chrome and firefox
Operating System ( Ubuntu):

ngx-contextmenu is not part of this repo. You should file your issue here: https://github.com/isaacplmann/ngx-contextmenu

Thanks Totati.
I have filed the same there


fix(aws-ecs): set memoryReservationMiB in LoadBalancedEcsService

Previously, only memoryLimitMiB was being set in the constructor. This would cause an unexpected validation error when a LoadBalancedEcsService was instantiated with memoryReservationMiB only specified. This fix correctly sets both fields.
Fixes #2263

Pull Request Checklist

[ ] Testing

Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
CLI change?: coordinate update of integration tests with team
cdk-init template change?: coordinated update of integration tests with team

[ ] Docs

jsdocs: All public APIs documented
README: README and/or documentation topic updated
Design: For significant features, design document added to design folder

[ ] Title and Description

Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
Title: use lower-case and doesn't end with a period
Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"

[ ] Sensitive Modules (requires 2 PR approvers)

IAM Policy Document (in @aws-cdk/aws-iam)
EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

Added and updated a test.

Squashed commits


New ROS 2 port of cartographer_ros - tracking issue

We plan to make a new ROS 2 port of cartographer_ros that is in sync with master.
There is already a port of cartographer_ros that is based on tag 1.0.0 of cartographer_ros, but hasn't been synchronized anymore besides minor fixes. Now that cartographer is maintained again as a community-driven project, we decided together with the OSRF that a new ROS2 port should be created here.
The rough plan so far:

We will archive a snapshot of the existing port on a read-only branch ros2-dashing-1.0.0. Studying the diff of this branch to the ROS1 release-1.0 branch will be very useful as a basis for an up-to-date port. :heavy_check_mark:
We will start a ros2-dashing branch because we can't have the ROS1 and ROS2 versions on the same branch. The goal is to be compatible with Dashing up to Foxy. master will remain the branch for ROS1 as it is right now. :heavy_check_mark:
Doing the largest bunch of work: the actual port. We see two possible strategies (open for discussion, see also #1557):

Create a new branch from master and apply similar changes like the ones that were added in the original ROS2 port.
Start with ros-dashing-1.0.0 and work your way up by cherry-picking each missing commit from master and adapting it to ROS2.
(my gut feeling is that the first one is easier, but this would need to be tried out)

Create pull requests, ideally multiple ones instead of one huge bulk change, and merge them into ros2-dashing.
CI will be set up once we reach a first working prototype.
Documentation needs to be reviewed and changed if required.
Demo data bagfiles should be made compatible with ROS2.
Once we reach a stable state, we want to do a release in coordination with OSRF.

Note: As this is currently just a rough plan, we will probably need to spawn new issues for refining some of the work packages  (as "ros2" labeled issues).

This issue aims to provide an entry point for people who are interested to contribute, ideally with experience in ROS2 and Cartographer. Feel free to comment here.

Would definitely love to get involved as I have been getting my hands dirty with the source code recently. Any leads on where to start would be appreciated.

Hi, I'd also like to help, for starters, I am currently using Cartographer in one of my projects, from the ros2 repository. If I want to move to ROS2 Foxy, I'll also need to upgrade rplidar repository to this distro. As for creating this version, will there be some kind of release? I'd rather not start working before some huge feature gets added. As for the way of working, I think the best would be to branch off the latest commit here, and base work on https://github.com/cartographer-project/cartographer_ros/pull/1488.
How does that sound?

Hi @3473f and @Serafadam, thanks for joining the discussion! I have just updated the description with more details that we discussed this week in a maintainers meeting. Would be great if you can have a look and let us know what you think and if this is something you would like to contribute to.

As for creating this version, will there be some kind of release?

Yes, that's the goal. To have a new release and then in the future also more frequent releases.

As for the way of working, I think the best would be to branch off the latest commit here, and base work on #1488.

I also think so, as I wrote now in the description.

Hi @MichaelGrupp, sorry for the late reply! that definitely sounds interesting. I have a lot of my plate in the next two weeks, after which I can start contributing regularly to this port.

Create a new branch from master and apply similar changes like the ones that were added in the original ROS2 port.
I'd rather follow this approach as well. The only case I'd find starting from the current ROS2 port useful is if it was a few commits behind, but it seems that Cartographer has changed a lot since then.

@MichaelGrupp Great initiative! My team has good experience using Cartographer and wants to switch our current robot system from ROS1 to ROS2. Right now, Cartographer is the only dependency that is still blocking this migration. So, we are willing to help. Let us know how we can contribute!

Hi, to give you an update: I actually started doing some things myself already:

we have a ros2-dashing branch that we can use for PRs
I opened a PR for setting up a first continuous integration infrastructure: #1543
another PR for porting cartographer_ros_msgs: #1542

I started it this way because this repo actually includes 3 ROS packages cartographer_{ros, ros_msgs, rviz} and the message package is needed for the others (and also rather easy to port).
Once these are merged (I plan to follow up in the next days), we can go on with porting the cartographer_ros package, which is the biggest one. Here it would be awesome if someone of you could do the deep-dive into to the code, I probably won't have so much time for this in the next weeks.
What do you think? Feel free to comment also on the open current pull requests of course.

@MichaelGrupp Sounds like a reasonable plan. Regarding deep-dive into cartographer_ros, do you already have an overview which nodes/scripts can be ported on their own? Those could end-up being individual items in a check-list and separate PRs. With such a list, it could be easier to commit to taking on individual items.

@airballking I like this idea. I opened an extra issue for this because it maybe goes a bit too much into detail for this tracking issue: https://github.com/cartographer-project/cartographer_ros/issues/1557

If you need IMU data ROS2 driver, SBG Systems has developed one: available on the repo

* Create a new branch from `master` and apply similar changes like the ones that were added in the original ROS2 port.

This is the strategy that I applied here: https://github.com/cartographer-project/cartographer_ros/pull/1622
I believe most of the work is done. Still needs extensive testing, parameter check, performance review and complementary features to be converted (rviz!)

Rviz is now supported in ros2 galactic in our PR https://github.com/cartographer-project/cartographer_ros/pull/1622 . Any suggestions on how to move forward with a proper ros2 galactic release ? Current ros2 bin release is from a very old version of both the library and the wrapper (with only cartographer_node working).
We are planning to discuss and add lifecycle support next.

Is there a planning for Port it to Humble Hawksbill ?
@doisyg

Yes, it was released to Rolling and Humble a couple of months ago already. See
https://discourse.ros.org/t/rolling-and-soon-humble-release-of-both-cartographer-and-cartographer-ros-v2-and-call-for-testing/25137
and
https://www.linkedin.com/posts/guillaume-doisy-b707362b_super-happy-to-finally-see-cartographer-fully-activity-6924372671514247169-UK7L?utm_source=share&utm_medium=member_desktop


connect hangs at "readStates" in 0.0.5

Browser console shows:
http://nuc2:8082 app.js:829:11
Connect ok app.js:845:13
read variables app.js:892:13
null app.js:947:13
(1) […]

0: {…}

acl: Object { owner: "system.user.admin", ownerGroup: "system.group.administrator", permissions: 1636, … }

file: "apollonhome.json"

isDir: false

modifiedAt:<PHONE_NUMBER>266

stats: Object { size: 554 }

<prototype>: Object { … }

length: 1

<prototype>: Array []
app.js:948:13
Received 13199 states. app.js:907:15
Stored 13199 states. app.js:915:15
QuotaExceededError: The quota has been exceeded. app.js:923
    readVariables http://nuc2:8082/minuvis/builder/dist/js/app.js:923
    onack http://nuc2:8082/minuvis/builder/dist/js/socket.io.js:8
    onpacket http://nuc2:8082/minuvis/builder/dist/js/socket.io.js:8
    exports http://nuc2:8082/minuvis/builder/dist/js/socket.io.js:8
    emit http://nuc2:8082/minuvis/builder/dist/js/socket.io.js:6
    ondecoded http://nuc2:8082/minuvis/builder/dist/js/socket.io.js:6
    exports http://nuc2:8082/minuvis/builder/dist/js/socket.io.js:8
    emit http://nuc2:8082/minuvis/builder/dist/js/socket.io.js:6
    add http://nuc2:8082/minuvis/builder/dist/js/socket.io.js:6
    ondata http://nuc2:8082/minuvis/builder/dist/js/socket.io.js:6
    exports http://nuc2:8082/minuvis/builder/dist/js/socket.io.js:8
    emit http://nuc2:8082/minuvis/builder/dist/js/socket.io.js:6
    onPacket http://nuc2:8082/minuvis/builder/dist/js/socket.io.js:7
    setTransport http://nuc2:8082/minuvis/builder/dist/js/socket.io.js:7
    emit http://nuc2:8082/minuvis/builder/dist/js/socket.io.js:6
    onPacket http://nuc2:8082/minuvis/builder/dist/js/socket.io.js:7
    onData http://nuc2:8082/minuvis/builder/dist/js/socket.io.js:7
    onmessage http://nuc2:8082/minuvis/builder/dist/js/socket.io.js:8

Hello Apollon77,
Yes this is a known issue.
Please install from Branch https://github.com/minukodu/ioBroker.minuvis/tree/dev/006/121
Or wait some days until it is published

I think I can wait :-)

Please try V0.0.6

worx!


How to Show two components

How to show two components, one below the other?

@darioajr I am not sure I understand what you mean

@toystars  i want to use two picker component at same screen......
but when i use it the arrayof first multiSelect override by the second multiselect array.......
like first picker code is
<MultiSelect
hideTags
items={this.state.dataSource1}
uniqueKey="id"
ref={(component) => { this.multiSelect = component }}
onSelectedItemsChange={this.onSelectedItemsChange1}
selectedItems={this.state.selectedItems}
selectText="Select Building"
searchInputPlaceholderText="Search Items..."
onChangeInput={ (text)=> console.log(text)}
altFontFamily="ProximaNova-Light"
tagRemoveIconColor="#45B3E8"
tagBorderColor="#45B3E8"
tagTextColor="#45B3E8"
selectedItemTextColor="#45B3E8"
selectedItemIconColor="#45B3E8"
itemTextColor="black"
displayKey="name"
searchInputStyle={{ color: '#45B3E8' }}
submitButtonColor="#45B3E8"
submitButtonText="Submit"
/>
second picker  code is......
<MultiSelect
hideTags
items={this.state.dataSource2}
uniqueKey="id"
ref={(component) => { this.multiSelect = component }}
onSelectedItemsChange={this.onSelectedItemsChange2}
selectedItems={this.state.selectedItems2}
selectText="Select Features"
searchInputPlaceholderText="Search Features..."
onChangeInput={ (text)=> console.log(text)}
altFontFamily="ProximaNova-Light"
tagRemoveIconColor="#45B3E8"
tagBorderColor="#45B3E8"
tagTextColor="#45B3E8"
selectedItemTextColor="#45B3E8"
selectedItemIconColor="#45B3E8"
itemTextColor="black"
displayKey="name"
searchInputStyle={{ color: '#45B3E8' }}
submitButtonColor="#45B3E8"
submitButtonText="Submit"
/>
please point out where i have to change ......


[RFC] Hug Conditionals in JSX

Conditionals are very common in JSX and it is unfortunate that they take up so much vertical space in the current prettier.
This pull request does a few tweaks:

It hugs ConditionalExpression (ternary) and LogicalExpression (&&) inside of {} in a jsx child, not an attribute
It doesn't output parenthesis if your parent is a LogicalExpression (&&)

Fixes #317

Nice!!

Cool, looks good to me!

Hello. How do I config this option? I need have prettier global or in a project it will work?

@yuritoledo there is no configuration option for this behavior. Please see https://prettier.io/docs/en/option-philosophy.html


[spi_device] Skeleton design (adding dummy gates and passthrough)

This PR is to add passthrough path from the spi host system to downstream spi_flash through spi_device (and hopefully spi_host later). This PR defines the interface between spi_device IP and spi_host IP also creates cmd/payload memory (which currently in single clock domain but later async).

LGTM eunchan, just a couple of comments.

I've put a comment to not forget to replace the mux into explicit mux cell. Thanks for the tip.

ah okay sounds good. So the capture is not command dependent, that makes
sense.
Could we have problems though if we get so many read commands that the cmd
memory / FIFO fills up?
On Wed, Jul 15, 2020 at 1:01 PM Eunchan Kim<EMAIL_ADDRESS>wrote:

@eunchan commented on this pull request.
In hw/ip/spi_device/rtl/spi_device.sv
https://github.com/lowRISC/opentitan/pull/2794#discussion_r455308007:

.tl_i (tl_sram_h2d [1]),
.tl_o (tl_sram_d2h [1]),

.req_o    (cmdmem_a_req),
.gnt_i    (cmdmem_a_req),  //Always grant when request
.we_o     (cmdmem_a_write),
.addr_o   (cmdmem_a_addr),
.wdata_o  (cmdmem_a_wdata),
.wmask_o  (),           // Not used
.rdata_i  (cmdmem_a_rdata),
.rvalid_i (cmdmem_a_rvalid),
.rerror_i (cmdmem_a_rerror)
);

// SRAM Wrapper

It is prim_ram but behaves like FIFO for each part (logic isn't there).
Below RAM has two distinct area (command, addr FIFO / Payload FIFO). Each
section we can replace them to async FIFO.
I think we cannot merge this cmd memory with the 2kB DPSRAM. I plan to put
every commands received into cmd sram so there's no time to put it to main
DPSRAM while reading the data from the memory if it is read command.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/2794#discussion_r455308007,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RSTOEOJSUKP5DA2SYO3R3YDJVANCNFSM4OXAQAPA
.

ah okay sounds good. So the capture is not command dependent, that makes sense. Could we have problems though if we get so many read commands that the cmd memory / FIFO fills up?

yeah I also thought about it. But the read command (into the internal 2kB memory) takes time to transfer the payload. So I assumed the software has enough time to pop the command/ address up. If not, we can make the logic to skip pushing the read commands.

sounds good. I think this may be a good question for the system and
software folks.
They can probably give better guidance on how they might make use of the
read commands or if they prefer you to filter them out.
On Wed, Jul 15, 2020 at 1:09 PM Eunchan Kim<EMAIL_ADDRESS>wrote:

ah okay sounds good. So the capture is not command dependent, that makes
sense. Could we have problems though if we get so many read commands that
the cmd memory / FIFO fills up?
yeah I also thought about it. But the read command (into the internal 2kB
memory) takes time to transfer the payload. So I assumed the software has
enough time to pop the command/ address up. If not, we can make the logic
to skip pushing the read commands.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/lowRISC/opentitan/pull/2794#issuecomment-658982797,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAH2RST7WIE3TEWYNYKDJJDR3YEJHANCNFSM4OXAQAPA
.