Introduces AutoGenBench

Why are these changes needed?
This PR introduced AutoGenBench -- a tool for running common benchmarks, and other templated tests, with the AutoGen framework. It replaces the former "testbed" tool, and lives in the same location in the repository: samples/tools/testbed
For full details, see the AutoGenBench README.md
TL;DR:
It is a (pip) installable module that handles benchmarking and evaluation tasks. An example session might resemble the following:
autogenbench clone HumanEval
cd HumanEval
autogenbench run Tasks/r_human_eval_two_agents.jsonl
autogenbench tabulate results/r_human_eval_two_agents

Where:

autogenbench clone HumanEval downloads and expands the HumanEval benchmark scenario.
autogenbench run Tasks/r_human_eval_two_agents.jsonl runs the tasks defined in Tasks/r_human_eval_two_agents.jsonl
autogenbench tablue results/r_human_eval_two_agents tabulates the results of the run

Related issue number
Closes #995 , #987 , #996
Supersedes #997
Checks

[ ] I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
[ ] I've added tests (if relevant) corresponding to the changes introduced in this PR.
[ ] I've made sure all auto checks have passed.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e571099) 26.53% compared to head (23fd4bf) 26.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1048      +/-   ##
==========================================
- Coverage   26.53%   26.34%   -0.19%
==========================================
  Files          28       28
  Lines        3807     3807
  Branches      865      865
==========================================
- Hits         1010     1003       -7
- Misses       2726     2732       +6
- Partials       71       72       +1

Flag
Coverage Δ

unittests
26.34% <ø> (-0.14%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@afourney code formatting issues were fixed by running pre-commit run --all-files from my side. Also fixed some minor wording issues.

@afourney code formatting issues were fixed by running pre-commit run --all-files from my side. Also fixed some minor wording issues.

Thanks. I'll re-install pre-commit hooks on my end, and hope the issues don't come back.

i'll try this out , seems really interesting and useful

suggest renaming tag testbed to autogenbench post this merge for improved discovery of tags.

Nice PR! Left very minor feedback. Otherwise looks fantastic!

I added a draft of a blog post. @qingyun-wu to review.

suggest renaming tag testbed to autogenbench post this merge for improved discovery of tags.

I'm going to give this a try, but it's going to be a little tough -- the autogenbench clone command works by linking to the repo, and the path is part of the current deployment so existing PyPI installs will at least temporarily break.

NOTE: Once this is merged, and before deleting the "autogenbench" branch, we will need to follow-up with another super-quick PR to point "autogenbench clone" to the main branch. I can't do that now because the files don't exist in that branch yet, so manual testing will break. I suspect this will be a one-time issue.

NOTE: Once this is merged, and before deleting the "autogenbench" branch, we will need to follow-up with another super-quick PR to point "autogenbench clone" to the main branch. I can't do that now because the files don't exist in that branch yet, so manual testing will break. I suspect this will be a one-time issue.

Can you fix in the code? First try via main and if the file doesn't exists fall back to the other branch?

NOTE: Once this is merged, and before deleting the "autogenbench" branch, we will need to follow-up with another super-quick PR to point "autogenbench clone" to the main branch. I can't do that now because the files don't exist in that branch yet, so manual testing will break. I suspect this will be a one-time issue.

Can you fix in the code? First try via main and if the file doesn't exists fall back to the other branch?

I added a --branch switch to the clone command.
Now you can do:
autogenbench clone --branch autogenbench HumanEval

to clone from this branch. Otherwise it defaults to main.

@ekzhu @qingyun-wu @victordibia @sonichi @rickyloynd-microsoft
Folks, I'm trying to get more eyeballs on this so that we can get this merged this week. Thanks @gagb for the earlier review.
If testing, be sure to use the "--branch autogenbench" parameter with the clone command since the files don't yet exist in main.

This might be minor (or not): folder names should all use lowercase and underscores following Python convention. For special terms e.g., benchmark names such as AutoGPT, GAIA, it may make sense to keep them as is, but other general names such as folders Scripts Templates, Tasks, I think it better to use all lowercase.

Thanks, @afourney, for the tremendous effort and fantastic work! This might be minor (or not): folder names should all use lowercase and underscores following Python convention. For special terms e.g., benchmark names such as AutoGPT, GAIA, it may make sense to keep them as is, but other general names such as folders Scripts Templates, Tasks, I think it better to use all lowercase.

Yeah, that's unfortunately both minor (in terms of complexity), and also a lot of work to fix (in terms of files to change, and testing to do). Can this be handled in a PR after?


mediaInitializationFailure

I'm getting this error and I don't understand why. I have followed the steps in this readme and created my certificates using openssl pkcs12 -export -out <certificate_name>.pfx -inkey <path_to_cert_files>/privkey.pem -in <path_to_cert_files>/cert.pem
I'm new to VS and I couldn't find a way to run PsiBot.Service directly from inside VS (I'm using VS 2022, hope that's not a problem)
I've run the visual studio as admin to dev build the PsiBot.Service (using PsiBot.Service.csproj) and admin cmd to execute the dev build (PsiBot.Service\bin\Debug\net48\PsiBot.Service.exe).
I've also installed the .pfx certificate using certutil -user -p 1234 -importPFX "openssl_cert.pfx" and it is showing in the certmanager.
Is there a problem with the type of certificate or something else can cause this exception?
Is there another way to create a certificate that will work in windows?
fail: Microsoft.AspNetCore.Server.Kestrel[13]
Connection id "0HMO5NAONLSLR", Request id "0HMO5NAONLSLR:00000002": An unhandled exception was thrown by the application.
Status Code: 0
Microsoft.Graph.Communications.Core.Exceptions.ServiceException: Code: mediaInitializationFailure
Message: Media platform failed to initialize
---> System.InvalidOperationException: Cannot access the certificate's private key. Make sure that the process has enough permissions to access the private key. Only CSP-stored certificates are supported by the media platform, CNG/KSP certificates are not supported. ---> System.NotSupportedException: The certificate key algorithm is not supported.
   at System.Security.Cryptography.X509Certificates.X509Certificate2.get_PrivateKey()
   at Microsoft.Skype.Bots.Media.CertificateManager.Validate(X509Certificate2 certificate, String fqdn)
   --- End of inner exception stack trace ---
   at Microsoft.Skype.Bots.Media.CertificateManager.Validate(X509Certificate2 certificate, String fqdn)
   at Microsoft.Skype.Internal.Bots.Media.InternalMediaPlatform.Initialize(MediaPlatformSettings settings, IConfigurationManager configurationManager, Boolean isTest)
   at Microsoft.Graph.Communications.Calls.Media.MediaCommunicationsClientBuilderExtensions.SetMediaPlatformSettings(ICommunicationsClientBuilder statefulClientBuilder, MediaPlatformSettings mediaSettings)
   --- End of inner exception stack trace ---
   at Microsoft.Graph.Communications.Calls.Media.MediaCommunicationsClientBuilderExtensions.SetMediaPlatformSettings(ICommunicationsClientBuilder statefulClientBuilder, MediaPlatformSettings mediaSettings)
   at PsiBot.Services.Bot.BotService.Initialize() in C:\Work\affect-cx-exps\PsiBot\PsiBot\PsiBot.Service\Bot\BotService.cs:line 105
   at PsiBot.Services.Startup.<>c.<ConfigureServices>b__4_2(IServiceProvider provider) in C:\Work\affect-cx-exps\PsiBot\PsiBot\PsiBot.Service\Startup.cs:line 42
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteRuntimeResolver.VisitScoped(ScopedCallSite scopedCallSite, ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ServiceLookup.DynamicServiceProviderEngine.<>c__DisplayClass1_0.<RealizeService>b__0(ServiceProviderEngineScope scope)
   at Microsoft.Extensions.DependencyInjection.ActivatorUtilities.GetService(IServiceProvider sp, Type type, Type requiredBy, Boolean isDefaultParameterRequired)
   at lambda_method.lambda_method(Closure , IServiceProvider , Object[] )
   at Microsoft.AspNetCore.Mvc.Controllers.ControllerFactoryProvider.<>c__DisplayClass5_0.<CreateControllerFactory>g__CreateController|0(ControllerContext controllerContext)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.<InvokeInnerFilterAsync>d__13.MoveNext()
   --- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.<InvokeNextResourceFilter>d__23.MoveNext()
   --- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Rethrow(ResourceExecutedContext context)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.<InvokeFilterPipelineAsync>d__18.MoveNext()
   --- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.<InvokeAsync>d__16.MoveNext()
   --- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.AspNetCore.Builder.RouterMiddleware.<Invoke>d__4.MoveNext()
   --- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpProtocol.<ProcessRequests>d__188`1.MoveNext()

The steps in the readme for creating the cert are incorrect, at least for windows.
Use this repo instead:
https://github.com/rmbolger/Posh-ACME
https://poshac.me/docs/v4/Tutorial/#your-first-certificate


Is this library being maintained?

I see no release after Jan 15, 2017 and many issues open for a very long time and many pull requests not merged. Is this library even being maintained?

Maintainers are having a hard time maintaining this library. Contributors are much appreciated to fix issues and keep opening PRs so that we can keep this library up for the community.

v4.0.0 has been published on Hex.


feat(containerised-test): TODOs → GitHub Issues

Description of the change
Converts TODOs found inline in a codebase to GitHub issues.
Benefits
Extracts TODOs that can wither in the codebase without discussion into a more readily discussed and estimated Issue.
The original author of the TODO will be assigned, so they can add additional context, implement, or remove the TODO.
When the TODO is removed, the corresponding issue should be closed automatically.
Possible drawbacks
TODOs are scattered across our services, with around ~40 open TODOs through the codebase.
This will produce a lot of noise on our issue tracker.

I put this workflow into the containerised-test flow to simplify its roll out.
Ideally, we would consolidate all of our common CI into one action that can be added to all the services, however calling reusable workflows from reusable workflows is not yet supported.


One Command test outputs text to stdout

This specific commands test outputs usage: foo to stdout. This output is only visible if some other test in "commands" package fails.
Ideally, tests should output nothing to stdout, as all their output should be captured and asserted.

Duplicate of #

Leave a comment


Fix Titles for Don'ts and Julie's Bio

[x] Fix color for background and text: starting with the title "DO NOT SHAKE HANDS..." the red background and white font are gone.
[ ] Fix Title for Julie's bio "About the author:" header is not correctly configured and has an additional curly bracket.

Fixed. You can close.

Ack! sorry. Julie's Bio still needs to be fixed.

Hi @monicacecilia, could you please take a screenshot of the issue? I can't seem to find it

Here @danimiba:

Dear @danimiba - I see that this is fixed. Thanks!

Requested fix for header in Julie's bio in #33


What is Classification

What is a team classification? I'm not sure what to put on this parameter (although I can leave it blank), and I can't find a way to read the value from existing teams.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: bd6bccff-1bef-c88c-ff70-2ccdfb48ecc0
Version Independent ID: 01f33478-352d-c7ae-0c49-784fa1c1fd67
Content: Set-Team (teams)
Content Source: teams/teams-ps/teams/Set-Team.md
Service: teams-powershell
GitHub Login: @kenwith
Microsoft Alias: kenwith

@officedocsbot assign @yogkumgit

@officedocsbot assign @yogkumgit

@dariomws306  Thank you very much for the contribution and updating the documentation with PR. @rpstester Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

@officedocsbot close


PermissionError when restart runing the code

try to run chmod 777 /content/drive/MyDrive/Python3/dist-packages/selenium give selenium folder more access

Restarting the current runtime solves the problem


React native support

I really love what you guys have been doing with stitches  and have been loving it so far!
Any idea if react native is in the roadmap, I think the community would benefit a lot from this

Hi 👋🏻
I've been working on the RN version of Stitches here: https://github.com/Temzasse/stitches-native
The core functionality is pretty much ready but I'm quite badly stuck with the TS typings. Any help with the typings would be very much welcome! 👐🏻
@peduarte do you have any tips about how could I utilize the existing types of Stitches in the RN version? I see that you have gone the declaration route instead of adding types to the implementation itself. I've been trying to type the implementation in my version and it gets super tricky 😄  Would you be open to sharing the learnings of your TS journey with Stitches?

@Temzasse hi! Nice 💯

utilize the existing types of Stitches in the RN version?

We're currently working on a TS specific sprint. Expect lots of TS changed over the next few weeks. Right now, I cant recommend anything, because its likely everything will change.
When we release the new TypeScript work, I'll post an update here!

FYI: I believe this is the TS PR Pedro referred to: https://github.com/modulz/stitches/pull/659 👀

Uuuh nice! 👍🏻 I'll take a look 👀
I actually managed to get the TypeScript part working with the current typings from Stitches repo by copy-pasting them into my repo and modifying the types to work with React Native.
I still need to write some docs for React Native specific stuff and test the lib more (and maybe write some actual tests 🙈) and then I would be ready to publish the first version of stitches-native so that people can try it out 🙂

The TS sprint was a success and we have since launched v1.0.0. Does this work for stitches-native, @Temzasse. Should we close this?

Hey @jonathantneal - do you have any near plans to support react-native as part of modulz directly? stitches-native from @Temzasse is a really good starting point, but would be nice to have support for both out of the box!
imagine: @stitches/core , @stitches/react, @stitches/react-native 😍

@jonathantneal I haven't had the time to incorporate the updated typings from v1 yet but I'll try to get it done as soon as possible. There are a few other smaller things that also need to be implemented in stitches-native but we should be quite close to the initial release 🤞🏻
Maybe we can keep this issue open until the first proper release of stitches-native is out? (there is a pre-release out already so that I was able to reserve the name on npm 😄)

@Temzasse one issue I see with the implementation is that it doesn't use dynamic window dimensions for media queries. Since RN doesn't have native breakpoints, this would be required via a hook. It's what we use for Dripsy. As a result, changing screen size won't update styles. Have you considered a way around this?

Stitches Native TS update
@jonathantneal I got the new Stitches v1 types working in Stitches Native apart from one issue in RN specific ThemeProvider that I haven't yet figured out (slapped an any to it for now since it doesn't really affect the DX).
There is a new pre-release version that people can try out: npm install stitches-native@canary
Next steps
I still need to comb through the Stitches API and verify that I'm not missing anything important in Stitches Native.
One thing that I know is still missing is the composability of css and styled thingies, eg:
const sharedCssA = css({ /* styles */ });
const sharedCssB = css({ /* styles */ });

const CompA = styled('View', sharedCssA, sharedCssB);
const CompB = styled('View', CompA);

Stitches Native currently only supports the simple version of composing styled components:
const CompA = styled('View', { /* styles */ });
const CompB = styled(CompA, { /* styles */ });

Not sure if it's enough that you are able to spread as many css objects inside a styled object 🤔
const cssA = css({
  backgroundColor: '$background',
});

const cssB = css({
  alignItems: 'center',
  justifyContent: 'center',
});

const Comp = styled('View', {
  flex: 1,
  ...cssA,
  ...cssB,
});

I guess the drawback is that you can't really use variants etc since the last one would overwrite the previous ones.

@nandorojo could you open an issue about this in the Stitches Native repo so that we could discuss this topic there? 🙂

@Temzasse one issue I see with the implementation is that it doesn't use dynamic window dimensions for media queries. Since RN doesn't have native breakpoints, this would be required via a hook. It's what we use for Dripsy. As a result, changing screen size won't update styles. Have you considered a way around this?

I’m unsure if we should leave this open, direct the discussion to stitches-native, or seek to merge stitches-native into our repository. I’d like to hear your ideas, @Temzasse, before knowing what action to take here.

@Temzasse will do. One other suggestion is not not allow the styled function to accept strings. This would break tree shaking, causing of all of RN to import, especially on web.

I’m unsure if we should leave this open, direct the discussion to stitches-native, or seek to merge stitches-native into our repository. I’d like to hear your ideas, @Temzasse, before knowing what action to take here.

My 2 cents: if the core Stitches team is willing to merge stitches-native, that might be less responsibility on one person's shoulders, and probably better for consumers of the lib as well.
Can't wait to try Stitches with RN, either way! Thanks @Temzasse !

Yes! I think it's a good idea to merge. Thank you for considering it!

I’m unsure if we should leave this open, direct the discussion to stitches-native, or seek to merge stitches-native into our repository. I’d like to hear your ideas, @Temzasse, before knowing what action to take here.

I'm definitely open to any of the above 👍🏻
@LucasUnplugged had a good point that merging stitches-native to the main Stitches repo would help reduce some of the maintenance burden from me, and in the future it would be easier to have both Stitches for Web and Stitches for React Native evolve hand in hand without too much divergence.
However, I'm also happy keeping stitches-native as a separate project and you can direct any discussion to stitches-native repo. In any case It would be cool to get more contributors aboard in order to make it a more community driven effort 🙂
Here are some pros and cons for the merging idea that came to my mind:
Pros:

Better documentation (if RN specific docs can be included in stitches.dev)

Also better discoverability since Stitches is already making a name in the CSS-in-JS land

More trust from devs (official solution vs. 3rd party solution)
Keeping TS types up-to-date would be much easier (this is a big one for me 😄)
Possibility to get help with the implementation from the Stitches core team

Cons:

Forcing Modulz to take responsibility of something that is not part of their core product (I'm under assumption that you don't do any RN stuff?)
Burdening Modulz with RN specific issues that would make the maintenance of stitches more challenging and laborious

Stitches Native update

Fixed the lack of composability in css and styled
Updated the docs about supported token types
Published a new canary version

The way forward
@jonathantneal have you and the rest of the team had the opportunity to think about the idea of merging Stitches Native into the Stitches repo?
I feel like Stitches Native is now ready for wider usage. There are still things to do like writing tests (🙈) and refining the docs but the core functionalities should be pretty much in place (unless I have missed something).
One challenge that I have is that I'm not currently able to dog food Stitches Native at my company or in side project so it's difficult to make sure that there are no unhandled edge cases. I'm considering publishing 0.1.0 version (or maybe even 1.0.0) on npm to encourage people to install and try out Stitches Native.

OT: @nandorojo I didn't know your library, looks interesting I'll check it out 😄  thank you

@mtt87 Thank you for your feedback 🙏
Here's my response to the various topics:
TypeScript

The types are definitely the hardest part of the library implementation and there is definitely improvements to be made. However, I think it's important to note that the way theme tokens are referenced in Stitches via magic strings is inherently unsafe (unless you use the theme object directly) so I feel like that is a tradeoff that one has to just accept if you want to take advantage of the "magic".
Fixing React Native specific issues like the fontWeight (which can cause hard crashes) is definitely something we want to fix, but I don't think handling things like lineHeight difference between Web and Native is the concern of the library. There are other platform differences such shadows that also need to be handled differently so my view is that those kind things should be left to the user to handle (for shadows Stitches Native already provides a utils based solution example in the docs).

Nesting/selectors

This is also another limitation that I think just has to be accepted. I understand the pain of not being able to style child components within the parent via selectors - I have many times wished that it would be possible 😁
You are right that the power of compound variants is not as great in RN as it is in the Web. Did you have any ideas how we could make this better and more suitable for RN? I wouldn't want to diverge from the Stitches API too much but if there is a much better way to handle some aspect it might make sense to create a RN specific API for it.

In a perfect world there would be an universal styling library that would map 1-1 between Web and Native but I think that is not practically feasible due to the inherent differences between the platforms. I totally understand that when creating design systems / component libraries it would be nice to share as much as possible but I feel like the sharing part should mostly happen at the design token level. Implementing shareable components will probably lead to an implementation that is not optimized for either platform. Sorry if this sounds harsh - I just wanted to share my philosophy about this subject 😅

I like the discussion here.
Here’s my take: we should embrace the way that React Native works, rather fit it to be like CSS.
Nested selectors and pseudo elements give you convenience, but don’t scale well for a component-based design system. I think it’s actually a good limitation of React Native to not have these.
I recommend this talk from the creator of React Native for Web, it really solidified that perspective for me: https://youtu.be/tFFn39lLO-U
I’ll also be talking about this topic at Next.js Conf in a few days: https://nextjs.org/conf/speakers/fernando

In a perfect world there would be an universal styling library that would map 1-1 between Web and Native but I think that is not practically feasible due to the inherent differences between the platforms.

I agree, but the baseline for these styles should be React Native’s styling system, not CSS. If that’s the case, then we can in fact get the 1-1 mapping. React Native’s styling system lends itself to work well on web. CSS, on the other hand, is too low level and coupled to HTML to be used on other platforms.
I’m not sure what the right answer is in the case of porting Stitches and its variants, but I think we can take the best of stitches, and still lean into React Native (+ Web)’s styling philosophy.
I came to this conclusion after using Dripsy in production for beatgig.com for about a year, where my original goal was also to copy all the CSS options from theme UI.
I hope that makes sense.

I didn't look at the codebase but all these styling properties are already correctly typed
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-native/index.d.ts#L932
Shouldn't stitches-native somehow extend these types?

@peduarte any official update from the dev team on this ?

Hey everyone 👋
We don't currently have plans to add official react-native support.
@Temzasse The stitches-native does look very promising and I really like how well you're documenting the API so I'd be very happy to merge a PR to add it to the list of community built packages

@hadihallak here's the PR 😉


AMBER changes - move functions from utils to amber; parse output for errors

Attempting to handle #94 and #102 - moving AMBER functionality from utils to amber (leaving skeleton function calls in place for backwards compatibility) while also adding some processing of AMBER tleap and antechamber outputs to look for obvious errors, eliminating some silent failures.
Also at the same time added checking of tleap-input filenames for spaces, which result in failures as tleap  can't handle filenames containing spaces.

Overall looks good to me, +1 if travis passes.

I had to make some other adjustments because (as I began using these) I found that the AMBER tools (tleap in particular) print the "ERROR" message for some things which are not technically an error (i.e. parameters are successfully written), such as the system charge not being an integer. This was particularly an issue for build_mixture_prmtop since the systems are modestly large so a slightly nonzero charge for a monomer can accumulate significantly overall. The AMBER output parser now checks to NOT flag this error as a problem.

@kyleabeauchamp - FTR, import .utils fails with a syntax error. I've just replaced it with import openmoltools.utils as utils which I think is what's needed.

I'm happy with whatever works here.  It's a little hairy now because we've got utils.py importing amber.py as part of our backwards compatibility support.
In the future, the import of amber.py from within utils.py might have to happen inside the various deprecated function calls, as otherwise we might have a confusing circular import.

Yes, it fails the tests for probably that reason. I'd not thought about the circular support aspect. Let me try and address that.

OK, we're good now. Merging.


Expand existing variables

This is my crack at #29. It's not in a working state, as I have zero experience with parsing before this (and I'm still quite new to Haskell as well). Currently, I get an error like so when running parseFile:
*** Exception: Text.Megaparsec.Prim.many: combinator 'many' is applied to a parser that may consume no input.
CallStack (from HasCallStack):
  error, called at ./Text/Megaparsec/Prim.hs:376:11 in megaparsec-5.0.1-Kbr1rj2aE5WBrRq6kJu93J:Text.Megaparsec.Prim

Hi @habibalamin, thanks very much for your contribution! @mrkkrp is more experienced with the parsing code in dotenv than I am at this point. Perhaps he has some feedback?

I have started working on this again, but I'm really kind of busy with family stuff and another, higher priority project that I haven't found the time to finish this off (as you said, there are a few problems with the PR as it is).
If anyone wants to pick this up, they're welcome to, but just say so here so I don't keep working on it on my downtime.
Sent from my iPhone

On 27 Feb 2017, at 14:14, Mark Karpov<EMAIL_ADDRESS>wrote:
@mrkkrp commented on this pull request.
In src/Configuration/Dotenv/Parse.hs:

value = (quotedValue <|> unquotedValue) <?> "variable value"
where

quotedValue   = quotedWith ''' <|> quotedWith '"'
unquotedValue = many (noneOf "'" \t\n\r")

quotedValue   = quotedWith SingleQuote <|> quotedWith DoubleQuote
unquotedValue = Unquoted <$> (many $ fragment "'" \t\n\r")
This happens because you should never nest one many into another one. Since many parses zero or more occurences, it succeeds even when its argument parser doesn't match at at all. And if something succeds without consuming input/advancing parser in many, it'll run it indefinitely. First many is where you say, and the second (inner) many is in literalValueFragment. I propose the following technique:

Use some intead of many, so fragments can't be empty.
Empty values just have zero fragments: [].
There are other minor issues, but they are not important at this point, we will talk about them when the PR is more complete. BTW, good work for a person new to Haskell!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Took a couple hours, but I got it (after I realised I could play around with the miniparsers in GHCi). @mrkkrp anything you want me to do before this can be incorporated?

You can test with this:
# .env
ABC="$HOME"
DEF="${HOME}"
GHI='$HOME'
JKL=HOME
MNO=$HOME
PQR=''
STU=""
VWX=
YZ='still'

# test.sh

# Run with below lines commented and uncommented, just to prove that the shell works the same way.
# ABC="$HOME"
# DEF="${HOME}"
# GHI='$HOME'
# JKL=HOME
# MNO=$HOME
# PQR=''
# STU=""
# VWX=
# YZ='still'

echo $ABC
echo $DEF
echo $GHI
echo $JKL
echo $MNO
echo $PQR
echo $STU
echo $VWX
echo $YZ

Test with .env by:
stack exec -- dotenv -f .env ./test.sh

Test the shell's (bash's?) parser by uncommenting the variable setters and running (with set -u, if you like, to make sure the shell does bind the variables):
./test.sh

Fixing tests now.


File is gone if you save remote file while it's loading

If I work with remote server. I open a file & while it's loading the tab is empty. If I add anything and save. File is gone.

VSCode Version: Code 1.11.2 (6eaebe3b9c70406d67c97779468c324a7a95db0e, 2017-04-13T07:56:42.517Z)
OS Version: Darwin x64 16.4.0
Extensions:

Extension
Author
Version

EditorConfig
EditorConfig
0.9.3

ftp-simple
humy2833
0.4.16

theme-onedark-sublime
joshpeng
0.3.6

@Artkoch can you try to reproduce this with our insiders build where we reworked our file watcher:

run insiders via http://code.visualstudio.com/Download#insiders
open settings and set "files.useExperimentalFileWatcher": true
restart

If it still reproduces, here is another workaround that will help: set "workbench.editor.closeOnFileDelete": false in settings.


help: Update/add a few user docs.

Doesn't need a review, but parking here since wasn't sure if I should merge this close to the release.
Also, let me know if you think I should hold on the first commit. My thought is that it'll take a few weeks for google to index it anyway.

I merged everything but the starred messages  one; I don't think it makes sense to merge that one unless we offer the setting in the release.  (We should quickly discuss if we're going to include it default-off; might be a good idea)

I think including it in the release, default-off is fine. I do find the current styling distracting (so would want to change it), but I don't think that styling change needs to block it.

OK, did that.  In which case we should address my comment above (explaining the workflow) and integrate this.


If a large number of "Another Songs" are set, the song title will not be displayed.

Nice to meet you, excuse me for the sudden request.
In Another Song, if there are nearly 10 Another Songs per song, some of them will be blank even if the Name name (name) and Change Vocals columns (vocal_disp_name) are set. (A similar phenomenon was observed in Japanese and English.)
I don't know if this is a problem with the game or with the DIVA MOD loader, but is it possible to fix it?

(postscript) Occurred when another_song.length=11 or greater. It doesn't happen with another_song.length=10.

Are you sure this is not a PV DB sorting issue? Since if you go to 10, you'd need to sort like:
.0.
.1.
.10.
.2.
.3.
and on.

 It worked perfectly. Thank you very much!


view doesn't load on Tizen browsers on v1.4.7

Describe the bug
After updating to v1.4.7 (latest branch), vis doesn't load on my fridge's integrated tablet (Samsung Tizen) anymore. It stays at the spinning wheel forever. Switching back to v1.4.6 solves this immediately.
Access using other systems (Edge / Firefox) always works.
To Reproduce
Update to vis 1.4.7
Open vis on a Tizen based browser
Expected behavior
vis should work as in previous versions.
Screenshots & Logfiles
No entry in iobroker's log.
Versions:

Adapter version: 1.4.7
JS-Controller version: 3.3.22
Node version: 14.18.2
Operating system: Ubuntu 20.04

Additional context
Might be related to #424

How old is that system? it is k on that sometimes libraryies like socketio or such do not work anymore on too old systems

Difficult to tell because it's a closed system. OS is Tizen 4 and the firmware is dated 05/2021. In my case it's a "Family Hub" refrigerator but the same OS is used on Samsung TVs.

Does 1.4.6 of vis work for you?
@GermanBluefox could it be that this "unicode regex" breaks it for some browsers? We also had issues with "self compiled" noejs, so the unicode regex support in browsers might be an issue?
https://caniuse.com/mdn-javascript_builtins_regexp_unicode if "samsung internet 4" means "Tizen 4" then yes ... not supported

Yes, 1.4.6 works without problems. I'll update the topic's name.

Same for Lenovo Essential Tab7 with Fully Browswer or Chrome. Installing back v1.4.6 did the trick, but in adapter view still shows as version 1.4.7.
This tab can't be updated anymore.

@GermanBluefox https://github.com/mathiasbynens/regexpu ?! ;-)) (at least for reference maybe)

Das gleiche bei Fully Browser Fire HD 10 1.4.7 i. O. // 1.4.7 lädt nicht

I removed some ES6 code in 1.4.9. Please try

@GermanBluefox Just tested 1.4.12 on my Tizen-fridge and everything seems to work as expected. Thanks!
I'm closing this because this issue was only related to this specific browser.


Add GitHub actions release workflows

We're migrating off of ossrh-releaser and will release JVM artifacts via GitHub Actions. This is a modified release action copied from the new one we use for Heroku repositories. It's untested at this point. After this PR has been merged, I can test the action from a branch so there will be hopefully one follow-up PR at most. :)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8079f0f) 89.30% compared to head (2158ebd) 89.30%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #445   +/-   ##
=========================================
  Coverage     89.30%   89.30%
  Complexity      342      342
=========================================
  Files            66       66
  Lines          1188     1188
  Branches         82       82
=========================================
  Hits           1061     1061
  Misses          118      118
  Partials          9        9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


style: use new logo

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.733%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
359

Relevant Lines:
375

💛  - Coveralls


Core: Call to resetInternals removed in remote validation callback

Hi,
The modification is related to the following issues, which although marked as closed don't seem to be properly fixed:
https://github.com/jquery-validation/jquery-validation/issues/12
https://github.com/jquery-validation/jquery-validation/issues/1669
https://github.com/jquery-validation/jquery-validation/issues/1375
From the user point of view the issue is that fields in a form which has at least one field with remote validation will be "unhighlighted" if the remotely validated field has a valid default value (remote validation is successful and any other invalid field is cleared out);
Validation error messages are still shown on the interface, but the invalid fields are shown as valid (the CSS class is reset)
Thanks,
Leonardo

Thanks for your contribution! I'll take a look at it as soon as possible!

Is there anybody alive here?

I'd be alive, but I cannot pull it! :-)

@Arkni
Any reason for not merging this PR ?

It needs a test, otherwise we just go round in circles :)

@leonardospina

It needs a test, otherwise we just go round in circles :)

Can you do the test ?

Mmmm I should set up a project on purpose, quite hard to find the time (I
moved company 2 years ago, that issue was spotted in a previous company
project, working with all different technologies now...)
----------------------------------
The worst thing about listening to Iron Maiden for the first time is that
you cannot listen to Iron Maiden for the first time ever again.
On Tue, 17 Jan 2023 at 09:54, julien-tschappat @.***>
wrote:

@leonardospina https://github.com/leonardospina
It needs a test, otherwise we just go round in circles :)
Can you do the test ?
—
Reply to this email directly, view it on GitHub
https://github.com/jquery-validation/jquery-validation/pull/2242#issuecomment-1385122740,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACVVRA7OG6IQ56UEHQFWII3WSZT4DANCNFSM4GHF2KAA
.
You are receiving this because you were mentioned.Message ID:
@.***>

@leonardospina
OK, I'll look if I can do something. But can you give me access to your jquery-validation fork repository ? Otherwise I think I will have to do a new PR

@julien-tschappat should be done can you try and access

@bytestream
I've added the test. Let me know if something else is required.
FYI : @leonardospina

Many thanks @julien-tschappat :)

Thank you @leonardospina @julien-tschappat @bytestream.

My pleasure.


fix typo

Hi, @peacewong , would you help review this?
Thanks, kelu.

Hi, @peacewong , would you help review this?
Thanks, kelu.

I think it's better to submit to the dev branch

Thanks for the reply, @casionone . I will do it later.
Thanks, kelu.

Hi, @casionone , I open another pr for this. ref: https://github.com/apache/incubator-linkis-website/pull/71
Let's close this.


Orienteer REST module

Done in https://github.com/OrienteerBAP/wicket-jersey. No need in some Orienteer specific REST endpoints. Otherwise, that will be tracked separately.


Rpi starts activity in profile much slower than others in the cluster; when cancelled before rpi starts running, doesn't cleanup correctly

A leader/worker and three other workers are part of a cluster. Worker3 has a slower running rpi. I started a basic profile that turned on stirring at 400 rpm, the turned it off after 1.2 minutes.
When profile began, stirring on leader, worker1, worker2 started. I cancelled the profile before worker3 started stirring. The first three pioreactors cancelled the profile/stirring action correctly, while worker3 did not and stirring activated soon after.

I think this is a non-issue since we don't recommend the RPi Zeros anymore


Add annotations for nullability and length

These are only present on the declarations in the C API.
New macros

VMA_NULLABLE
VMA_NOT_NULL
VMA_NULLABLE_NON_DISPATCHABLE
VMA_NOT_NULL_NON_DISPATCHABLE
VMA_LEN_IF_NOT_NULL

On clang VMA_NOT_NULL and VMA_NULLABLE are defined as _Nonnull and
_Nullable. Clang will use these annotations to generate diagnostics
when these functions or structs are incorrectly used.
VMA_NULLABLE_NON_DISPATCHABLE and VMA_NOT_NULL_NON_DISPATCHABLE are
not defined on platforms where Vulkan's non-dispatchable handles are not
pointers; on platforms where they are, these macros are defined to be
VMA_NULLABLE and VMA_NOT_NULL respectively.
LEN_IF_NOT_NULL is not defined for any compiler. It is included to
mirror the len attribute in the Vulkan XML spec in order to aid in
development of other language bindings for this library.
It was tempting to use C's array syntax (foo(int len, int arr[len]))to
specify lengths, however this is not possible to use with optional
pointers, nor is it possible to use inside structs. For the sake of
consistency only VMA_LEN_IF_NOT_NULL is used (additionally neither
clang not gcc generate warnings for function misuse when the array
length specifier is anything but an integer literal).

Also correct a couple of typos
Also add assert on ppName in vmaGetPoolName

Closes #114

Thanks! This is excellent! There are some preliminary haskell bindings generated using these annotations here: https://github.com/expipiplus1/vulkan/blob/vma/VulkanMemoryAllocator/src/Graphics/VulkanMemoryAllocator.hs
I'll upload these to Hackage after giving them a test drive.

@adam-sawicki-a I just noticed that I had included the rejected Add const qualifier to handles where possible commit in this PR. You might want to revert that if that's still considered rejected! Sorry!

Thanks for this quality contribution!
Including #117 is fine - I decided I will eventually merge it.
Should VMA_LEN_IF_NOT_NULL have its parameter as string "" or not? You mixed this in your code.

Yeah, it can be any expression and I couldn't think of a better way of saying VkPhysicalDeviceMemoryProperties::memoryHeapCount. Perhaps the comment here could be improved https://github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator/pull/115/commits/08bc59bee51b3cc8eb11a43595ec17e66f1346b2#diff-44540aefde48c442bbf9b6a5c0fc3fdeR2002 to mention say that in this case it is passed as a string to be parsed by whatever program is consuming this information.
Another way of putting it would be VMA_LEN_IF_NOT_NULL(VkPhysicalDeviceMemoryProperties.memoryHeapCount) but I think that might obscure the meaning.

Let me know when your Haskell binding is finished or in Beta stage and I will add it to the list in VMA README.md.

I made some fixes in your code. Please take a look and see if they are correct (e.g. VMA_NOT_NULL -> VMA_NOT_NULL_NON_DISPATCHABLE for VkInstance).

Thanks for double checking! I made a few comments.

OK, fixed. Thanks again!


S3 multiparts - support ACLs

Fixes #5252

Codecov Report

Merging #5255 (9dde99b) into master (6d68a51) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5255      +/-   ##
==========================================
- Coverage   95.94%   95.93%   -0.01%
==========================================
  Files         688      688
  Lines       68988    68986       -2
==========================================
- Hits        66189    66185       -4
- Misses       2799     2801       +2

Flag
Coverage Δ

servertests
36.16% <20.00%> (-0.01%)
:arrow_down:

unittests
95.88% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/s3/models.py
96.12% <100.00%> (+0.52%)
:arrow_up:

moto/s3/responses.py
95.52% <100.00%> (+<0.01%)
:arrow_up:

moto/resourcegroupstaggingapi/models.py
82.93% <0.00%> (-0.60%)
:arrow_down:

moto/sns/models.py
96.83% <0.00%> (-0.40%)
:arrow_down:

moto/route53/responses.py
96.05% <0.00%> (-0.33%)
:arrow_down:

moto/sqs/models.py
96.73% <0.00%> (-0.18%)
:arrow_down:

moto/config/models.py
99.21% <0.00%> (-0.14%)
:arrow_down:

moto/ssm/models.py
94.50% <0.00%> (-0.11%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d68a51...9dde99b. Read the comment docs.


tile_potential in buildable_pops works

but cwtools tells me, its an error

Can you add example code?

buildable_lich_pop = {
cost = {
influence = 600
energy = 5000
minerals = 5000
}
potential_build = {
	has_ethic = ethic_fanatic_militarist
	has_ascension_perk = ap_lich
}

tile_potential  = {
	exists = planet
	planet = {
		count_pops = { limit = { is_species = buildable_lich_pop } count < 1 }
	}
}

species = {
	name = "lich"
	name_list = "AI"
	class = "DEAD"
	portrait = "default_robot"
	traits = {
		trait = "trait_lich"
	}
	new_pop_resource_requirement = {
		type = lich_food
		value = 72.0
	}
	pops_auto_growth = 1.0

	pops_can_be_colonizers = no
	pops_can_migrate = no
	pops_can_reproduce = no
	pops_can_join_factions = no
	pop_maintenance = 0
	pops_can_be_slaves = no
	can_generate_leaders = no
	pops_have_happiness = no
	consumer_goods = no
	pop_ethics = no

}

}

ok, i added a pull request with this

can also close this one


fix: add NetworkPolicy for DSP apiserver pod self traffic

Description of your changes:
The DSP apiserver implements TLS by relying on the OpenShift service cert signer. In order to get this to work nicely with our openshift-oauth sidecar, we set the Kubernetes service as the upstream for the oauth container. This means that all incoming traffic to DSP goes like this:
client -> DSP service -> DSP oauth -> DSP service -> DSP apiserver
DSP oauth and DSP apiserver are in the same pod. We haven't explicitly created a NetworkPolicy to allow that, but it works on AWS and OpenStack-based clusters. For some yet to be determined reason, it doesn't work on IBM / Calico / Secure-By-Default clusters.
Add a NetworkPolicy entry to allow the DSP pod to talk to itself on 8888 and 8887. This fixes the issue where DSP(oauth) can't talk to DSP(apiserver) via the service (that fronts both containers / the pod).
The issue resolved by this Pull Request:
Resolves https://issues.redhat.com/browse/RHOAIENG-14571
Testing instructions
Provision a managed IBM Cloud OpenShift with SBD enabled.
Install the master release of DSPO. Create a DSPA. Verify that you can't connect to this DSPA's route. You'll see timeout errors in the DSPA oauth containter log.
Update to this PR's build of DSPO. Create another DSPA. Verify that you CAN connect to this DSPA's route. You won't see timeout errors in the DSPA oauth containter log.
Checklist

[x] The commits are squashed in a cohesive manner and have meaningful messages.
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has manually tested the changes and verified that the changes work

/cc @jgarciao

A new image has been built to help with testing out this PR: quay.io/opendatahub/data-science-pipelines-operator:pr-719
An OCP cluster where you are logged in as cluster admin is required.
To use this image run the following:
cd $(mktemp -d)
git clone git@github.com:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/719/head
git checkout -b pullrequest 1667e6d394c329c3f806783029abe3c5db78b448
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-719"

More instructions here on how to deploy and test a Data Science Pipelines Application.


Add automated build for Apple Silicon processors

Related https://github.com/ceifa/steamworks.js/pull/17

See github/roadmap#528

Related https://github.com/ceifa/tiktoken-node/pull/14


"Invalid parameters" error when sending an event from W3bstream Studio

How to reproduce
# Configure w3bstream
# 1. deploy the official log example applet
# 2. Create a publisher
# 3. Send a default event from the UI

You get the notification: "Invalid parameters"
Sending the curl command is a bit more detailed:
curl--location--request POST 'localhost:8888/srv-applet-mgr/v0/event/project_01'--header 'Content-Type: text/plain'--data - raw '{"header":{"event_type":"ANY","pub_id":"001","token":"eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJQYXlsb2FkIjoiOTAxMDIxMTEzMjE1MjgzMiIsImlzcyI6InczYnN0cmVhbSIsImV4cCI6MTY2ODYxNTExMH0.wiXEpHIcxU7HODApMeNFREXZliyfzRnASW6JPNOfS8A","pub_time":1668611513312},"payload":{"example":"This is an example payload"}}'

{
    "key": "badRequest",
    "code": 400000000,
    "msg": "invalid parameters",
    "desc": "",
    "canBeTalk": false,
    "id": "",
    "sources"<EMAIL_ADDRESS>    "fields": [{
        "field": "payload",
        "msg": "json: cannot unmarshal object into Go struct field Event.payload of type string",
        "in": "body"
    }]
}

I see that the default event message is now reflecting the example recalled in https://github.com/machinefi/w3bstream-studio/issues/33, however, it seems the "raw string" improvement reported in the same issue is not implemented correctly: if I select payload = JSON from the drop-down I still have to manually escape the double quotes to make it work:
This works:
"payload": "{
    \"example\": \"This is an example payload\"
  }"

same issue for me

Any update on this issue?
Also, notice that when we switch Payload to "TEXT", it should not disable syntax Highlighting.

Any update on this issue?
Also, notice that when we switch Payload to "TEXT", it should not disable syntax Highlighting.
@uu-z

hi @simonerom  sorry for the late reply
you could try using the latest version of studio before merging yet
https://github.com/machinefi/w3bstream/pull/229
it's worked for log wasm with JSON mode

The fix works for me


[FLINK-16471][jdbc] develop PostgresJDBCCatalog

What is the purpose of the change
add PostgresJDBCCatalog to connect to postgres metadata so that users can leverage it in Flink SQL and don't have to manually specify schemas.
Brief change log

added AbstractJDBCCatalog as common parents for all jdbc catalog impls
added JDBCCatalog as user-facing skeleton
added PostgresJDBCCatalog

Verifying this change
added a few UT and IT
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (docs)  docs will added later on

cc @KurtYoung @lirui-apache @JingsongLi @wuchong

@JingsongLi  can you take another look?

Sorry for late reply.
Should we add SPI for catalogs?

Thanks for the review! Adding it to SPI will be in another PR.
I'll merge this PR now since all comments have been addressed.


Added support for Notifications that use DispatchSource

Using a DispatchSource is less wasteful of CPU power as per PostgreSQL documentation.
A parametrized init for Connection.Notification is needed so an application using Notifications does not need to import CPostgreSQL.
Fixed a compiler warning about an unused variable.

This is really nice, thank you! Personally I wouldn't mind eliminating the old solution for notifications altogether, in favor of using Dispatch.
What do you think, @sroebert?

@tanner0101 I think this would remove the need for a pure swift driver.

Nice work, this is much better than the existing function with sleeping. This should simply replace the old one. I added some review comments.

To test the error handling code  at 206-207 the test needs to close the connection. Then it crashes in the deinit because that tries to close it, too. Is there a reason close() doesn't set cConnection to nil and then compared to nil before calling PQfinish? Otherwise, I'll fix it.

I actually think the close function is not correct in this case. Close should check if it is connected and only close in that case, otherwise it should simply do nothing. So the validateConnection should not be there in my opinion.

PQfinish is documented as freeing the memory and "must not be used again". That means there is no way to query if the connection is open without a crash. So it comes back to my previous question. Make cConnection nullable or add a flag for the connection state?
Generally I'd want to make it optional, but that is an API breaking change.

Ok, yeah that is a tricky one. I would also go for making it optional. I know it is a breaking change, but at the same time, I doubt there will be many (if any) libraries out there, making direct use of this property.
What about making this property deprecated, changing it to a var that points to a new optional property, throwing a fatal error if it is nil.

reset() and close() were marked as throws because they called validateConnection(). The connection status isn't checked after the call to PQreset(). Therefore, an error is thrown if the connection is invalid (isn't that the reason reset() is called?) but not if the reset fails.
I think reset() should only throw an error if PQStatus() is CONNECTION_BAD after the call to PQreset(). Throwing an error if already closed will fail current tests. Thoughts?
Along the same line, I think close should not through an error if already closed. It is throwing an error if isConnection is false. That would mean it would not throw errors anymore, so should close() no longer be marked as throws, or keep it for compatibility?

Yes, that is exactly what I meant. I like the idea of throwing an error is reset does not properly reset.
About compatibility, I find it a bit hard, as it is a breaking change, but again, I doubt anyone is using this directly currently. And I don't like the idea of keeping it a throwing function when it does not. So in my opinion we should change it to not throwing.

Any idea what the problem with travis is? I see some message about brew and vapor.

Here are a couple of possible fixes: https://github.com/PowerShell/PowerShell/issues/5062
Either add a homebrew environment variable, or move the location of brew update. Seems like an issue with a recent brew upgrade.

can someone merge this if it all good?

@mlilback - Can you update the .travis.yml file to move the brew update line above other brew commands? That should solve the failing tests. Thanks!


Add Stringer & TextMarshaler interface

For more human-friendly logging/debugging & integrating with go's json serialization.

Thanks for look at this. Fixed the tests (they should definitely have been from the unmarshal!) and ran gofmt.


How to use namespaces

Hello, can you provide an example how to use namespaces.
I assume this one is incorrect?
        u, _ := gomasio.GetURL("my.domain", func(opts *gomasio.URLOptions) {
		opts.Scheme = "wss"
		opts.Path = "/socket.io/some_namespace/"
	})

Sorry, It is unsupported yet.


Is there any way to make the particular test execution skip on conditional basis?

Hi Team,
I have below test cases.
@Test
public void test1(){
   // Test case1
}

@Test
public void test2(){
   // Test case2
}

I want test1() will execute if some condition will satisfy and test2() if other.
Is there any way to make the particular test execution skip on the conditional basis?

@Test
public void test1(){
   if (!someConditions) {
      throw new SkipException();
   }
   // Test case1
}

@Test
public void test2(){
   if (!someOtherCondition) {
      throw new SkipException();
   }
   // Test case2
}

or use a listener (IInvokedMethodListener , IHookable or IInvokedMethodListener ) to filter test execution: http://testng.org/doc/documentation-main.html#testng-listeners
If you need more details, please use stackoverflow instead.


UI tests do not run concurrently even when all required arguments are provided

My Behave framework uses Python 3.10 and behave 1.2.6
I have UI test in 1 feature file with 10 scenarios.
The command I run is:
behavex -t @{my_tag} --parallel-processes 10 --parallel-scheme scenario --no_capture -D browser=chrome -D vault_key={vault_key} -D project_path={project_path}
But still the scenarios are executed sequentially and not concurrently.
1 Chrome browser window opens at a time

Hi @IrynaIeremeichuk , we have been reviewing the implementation and we do not see the reason for the scenarios not to be running in parallel. Unless the scenarios are tagged with the @SERIAL tag, they should run in parallel.
One common problem is that only one instance of chrome browser can be opened at a time in a machine, so if you need to run your tests in parallel you need a multi-browser implementation like selenium grid, otherwise the other parallel session cannot continue until the session using the chrome browser finishes
Regards


Add ability not to add classes to div/label/input

Hi,
Right now simple form produces markup like:

* Name<input class="string required" id="user_name" name="user[name]" required="required" size="50" type="text" />

I would like to strip it to:

* Name<input id="user_name" name="user[name]" required="required" size="50" type="text" />

I can't find any reason, why break DRY rule (same classes in 3 elements), plus I think, that in a lot of use cases (eg. mine) that additional classes(generally) are completely useless.

A pull request would be welcome, although this may not be a very good idea because label.string is a faster selector than .string label.


Assigning static Variables with NodePath not possible

Would it be possible to allow static variables to be assigned with NodePath?
This is useful for referencing Nodes in/from a Singleton (e.g. referencing a constant HUD Element from Globals)

Found the issue, I was not including Static with the Binding Flags.  This will be in the next release of GodotSharpExtras.


Make CURL dependency PRIVATE in CMake

It seems like CURL should be a private dep(?).
Even though that means nothing for a static library, at least
it makes it clearer that the interface used by librequest(_static)
is not tied to CURL in any way and its consumers don't need
to see CURL headers.
Seems to me that CURL is not used in the public C++ API and is
hidden in code. It should be the same for CMake, since
it's the same for gRPC (although that seems to be linked
statically).
Signed-off-by: Andrei-Florin BENCSIK<EMAIL_ADDRESS>

I might be terribly wrong on this one but it seemes weird to have the CURL target (and all its include dirs and whatnot) propagated when I compiling and linking my application with librequest.so.


chore: copy new license file

Description

added copy commands to dockerfiles and github workflows

Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:

[x] DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
[x] Copyright and license header are present on all affected files
[x] If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

Relates to #430


Card Import Refactors

Purpose of PR
We were double importing packages unnecessarily and also double packaging card-related extensions files. This PR tries to clean up those changes.
Changes.

Removes functions that resolved paths.
Leaving packaging of extensions up to code managing extensions.

todos

There are slight issues with packaging cards with HTML and other assets. Need to document and test that approach.

Closing PR because #973 addresses this


Create quay.io/ansible/python-builder container image

This is our first commit of the python-builder container image. We'll be
using this in multi-stage builds for ansible-runner, and any other
python project that needs to compile python wheels, and install them.
This is based on opedevorg/python-builder image used in opendev.org.
Signed-off-by: Paul Belanger<EMAIL_ADDRESS>

recheck

recheck

recheck

Pull-request updated, HEAD is now 8653d21cc222e180a0ea8f16da904efd568828ed

Pull-request updated, HEAD is now 36f9a6eceb2f428181ae655eabe453bd8fab1424


[feature]: need to log the keploy mode

Is there an existing feature request for this?

[X] I have searched the existing issues

Summary
Currently, the keploy mode variable is not logged. It can help notify users when keploy is recording, testing, or off and also brief them about the behavior of that mode.
Why should this be worked on?
This became a need because users where incorrectly setting the mode variable and it became difficult to actually understand if keploy was initialized to the right mode. These logs will help understand more about keploy.

Hey @re-Tick I wanted to take up this one can you assign it to me

Hi @partik03, I am assigning this issue to you. Please feel free to discuss the changes here

@re-Tick Sorry I started working on it when you suggested it to me. I have created a PR for the same. Next time I'll make sure to get the issue assigned before starting to work on it.


The page is not fully displayed.

Issue / Feature - issue
FolioReader version -  0.5.4
FolioReader Stock / Modified -
Android SDK - Android Oreo (API 27)
Mobile / Tablet / Emulator Info -  Mobile device, Samsung J7
Crash / Error - No crash
Steps to reproduce / Describe in detail -

Please, check your sample with attached file
Any page of book is shown partly (not full). I need to scroll horizontally from start to end

What can I do to fix it?
epub_mg_a_thanksgiving_story_0.zip

@alinababenkoavantize It looks like epub is Fixed Layout (FL) epub. Right now we don't support FL epubs.


Update Identity-SummarizeGuestTenantActivity.kql

Adding AppDisplayName on the summarize

Feel free to reject, but adding AppDisplayName so you can see what the Guest user is hitting in the tenant, rather than just that a user hit the portal.

Was actually looking at this query a few days ago and thinking it to update it to include applications, is this a better outcome though? This way the apps are tied back to the tenant id
//Summarize the domain names, the count of users and list of users for each guest tenant connecting to your Azure AD tenant
SigninLogs
| where TimeGenerated > ago (30d)
| project
TimeGenerated,
UserPrincipalName,
HomeTenantId,
AADTenantId,
Id,
ResourceTenantId,
ResourceIdentity,
UserId,
AppDisplayName
| where UserId != "00000000-0000-0000-0000-000000000000"
| where ResourceIdentity != ''
| where HomeTenantId != ''
| where HomeTenantId != AADTenantId
| extend GuestDomain = split(UserPrincipalName, '@')[-1]
| summarize
['Guest Domain Names']=make_set(GuestDomain),
['Distinct User Count']=dcount(UserPrincipalName),
['List of Guest Users']=make_set(UserPrincipalName),
['List of Applications']=make_set(AppDisplayName),
['Count of Applications']=dcount(AppDisplayName)
by HomeTenantId
| sort by ['Distinct User Count'] desc

Maybe?  I thought about that, but then you don't know which users were hitting which app.  There may be a better way to smash them together potentially, but if UserA hits both the portal and M365D, and UserB hits just the Portal, I want to know that delination.  May also be interesting to know if they got hit with a CAP.
Yours:

Mine:

Yeh I think both work to be honest, could make the case either way, adding the app in one way is definitely useful so lets merge it. You can ultimately still add additional filters after the summarization anyway

merged to main


solved the task

You should not edit the original class functionality. Rather you should implement the function as an override in your declared class.

Thanks for the feedback but due to the little to no experience in python syntax i couldn't do this solution but I'll try to get it right before 9am.


[release-1.13] use protobuf getter functions for nil-safe in tracing provider config

Fixes https://github.com/istio/istio/issues/40906

@ingwonsong: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security_istio_release-1.13
5628876916e3aa368b5b7a1bb77cdc1b36d8513b
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

@ingwonsong: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

integ-security_istio_release-1.13
5628876916e3aa368b5b7a1bb77cdc1b36d8513b
link
true
/test integ-security

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Add tests

We're covering quite a bunch of corner cases now and should add tests for them.

Testing infrastructure has been added in 77d4c4c and c5722de. Now we need an extensive set of tests.

We have pretty good test coverage in the soon to be merged graph branch, so I'm closing this issue.


docs(ts/guide/hierarchical-dependency-injection): fix typo: app/estore.service.ts -> app/restore.service.ts

Thanks.


Issue #161

Update matchmediaquery to 0.3.0
If values are specified, always use them over window
Tests

The two tests there seem fine - you can drop that failing test and I'll merge and publish as a new minor release

@contra done

I'll do this as a breaking release actually, since this could break some usages.


Add getLocalPublic(), getFereratedPublic()

issue
Add local parameter to Timelines#public #25
change detail

Add parameter for public timeline and tag timeline.

Deprecated Timelines#getPublic()
Add Timelines#getLocalPublic()
Add Timelines#getFederatedPublic()
Deprecated Timelines#getTag()
Add Timelines#getLocalTag()
Add Timelines#getFederatedTag()

Codecov Report

Merging #26 into master will decrease coverage by 0.83%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master     #26      +/-   ##
===========================================
- Coverage     24.44%   23.6%   -0.84%
  Complexity       52      52
===========================================
  Files            36      36
  Lines           450     466      +16
  Branches         58      60       +2
===========================================
  Hits            110     110
- Misses          335     351      +16
  Partials          5       5

Impacted Files
Coverage Δ
Complexity Δ

...va/com/sys1yagi/mastodon4j/api/method/Timelines.kt
21.87% <0%> (-21.88%)
3 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d2d31f...9a599de. Read the comment docs.