Error in reading 'theta' in all analysis steps

Hi Sam,
I've been encountering difficulty in center finding, alignment, and reconstruction which I believe are all because of some error with theta. I imported one stack of tiff as the prenormalized data. Based off of the fact that the scan is 180˚ and there are 726 number of projections, I see that tomopyui shows the correct angle step when I select the tiff folder. I also know that if there is no 'theta' input, then tomopy (not tomopyui) have a function where it assumes the angle step is evenly spaced between 180˚ for all projections (https://tomopy.readthedocs.io/en/latest/ipynb/tomopy.html). I am guessing tomopyui could do this too. However, I got the below error:
(Thanks in advance!)
ValueError                                Traceback (most recent call last)
File ~\tomopyui\tomopyui\widgets\helpers.py:308, in ReactiveTextButton.run_callback(self, *args)
306 self.button.icon = self.icon_during
307 self.button.description = self.description_during
--> 308 self.callback()
309 self.button.button_style = self.button_style_after
310 self.button.icon = self.icon_after
File ~\tomopyui\tomopyui\widgets\center.py:371, in Center.find_center_on_click(self, *args)
369 prj_imgs, ds_value = self.get_ds_projections()
370 angles_rad = self.projections.angles_rad
--> 371 self.current_center = find_center(
372     prj_imgs,
373     angles_rad,
374     ratio=0.9,
375     ind=self.index_to_try,
376     init=self.center_guess,
377 )
378 self.center_textbox.value = self.current_center
File ~.conda\envs\tomopyui\Lib\site-packages\tomopy\recon\rotation.py:124, in find_center(tomo, theta, ind, init, tol, mask, ratio, sinogram_order)
88 """
89 Find rotation axis location.
90
(...)
121     Rotation axis location.
122 """
123 tomo = dtype.as_float32(tomo)
--> 124 theta = dtype.as_float32(theta)
126 if sinogram_order:
127     dy, dt, dx = tomo.shape
File ~.conda\envs\tomopyui\Lib\site-packages\tomopy\util\dtype.py:99, in as_float32(arr)
98 def as_float32(arr):
---> 99     arr = as_ndarray(arr, np.float32)
100     return as_dtype(arr, np.float32)
File ~.conda\envs\tomopyui\Lib\site-packages\tomopy\util\dtype.py:88, in as_ndarray(arr, dtype, copy)
86 def as_ndarray(arr, dtype=None, copy=False):
87     if not isinstance(arr, np.ndarray):
---> 88         arr = np.array(arr, dtype=dtype, copy=copy)
89     return arr
ValueError: Unable to avoid copy while creating an array as requested.
If using np.array(obj, copy=False) replace it with np.asarray(obj) to allow a copy when needed (no behavior change in NumPy 1.x).
For more details, see https://numpy.org/devdocs/numpy_2_0_migration_guide.html#adapting-to-changes-in-the-copy-keyword.

I think #58 should fix it -- I didn't have numpy versions locked down to v1, and numpy v2 was installed when you created your environment.
You can probably fix your current environment by doing (untested):
conda activate <your env>
conda install numpy=1.26

Or something similar. Or, you can delete your conda environment and start over after pulling the latest changes from github (git pull).

Hi Sam,
Thanks for the feedback.
Installing the 1.26 version of numpy solves the problem perfectly!
Peter


[Work in progress] Separation of concerns using Vue

Trying out new conventions with Vue.
Using TypeScript and Templates, supporting Sass for styling.

This relates to https://github.com/solid/solid-panes/issues/72

We've decided to use React for this purpose going forward.


Add French translation

This PR add French translation for Gitea website.
Signed-off-by: Thibault Meyer<EMAIL_ADDRESS>

Closed since forked repository deleted.


AddJsonFile throws invalid directory name when optional is true

var builder = new Microsoft.Extensions.Configuration.ConfigurationBuilder()
.SetBasePath(env.ContentRootPath)
.AddJsonFile(@"C:/myDirectory/mySub/appsettings.json", optional: true)
When adding a configuration file during app startup, the above code will throw an exception if the "C:/myDirectory/mySub/" directory does not exist. Since this is set as an optional file, the directory should not need to exist.

Related https://github.com/aspnet/FileSystem/issues/199

We really need this to work when the directory is missing because in Antares we watch some config files that don't exist yet, not their parent folder is there. So the configuration (and the file watcher) should support watching a folder and files in folders that don't exist yet.
It's required by the Antares integration work items. cc @glennc

Looks like we can fix this for absolute paths by walking up the path and creating the physical file provider against that directory leaving the rest of the path for the file, i.e.
Updating the code here: https://github.com/aspnet/Configuration/blob/dev/src/Microsoft.Extensions.Configuration.Ini/IniConfigurationExtensions.cs#L76
            if (provider == null && Path.IsPathRooted(path))
            {
                // Find a directory that exists to root the file provider against
                var directory = Path.GetDirectoryName(path);
                var pathToFile = Path.GetFileName(path);
                while (!string.IsNullOrEmpty(directory) && !Directory.Exists(directory))
                {
                    pathToFile = Path.Combine(Path.GetFileName(directory), pathToFile);
                    directory = Path.GetDirectoryName(directory);
                }
                provider = new PhysicalFileProvider(directory);
                path = pathToFile;
            }

Sound reasonable?
cc @divega

I think that would work.. My only concern is perf if you end up watching the disk's root and there's a lot of file watching.
Btw, that change is not just for ini files, right?

3ea670863e44a8047b31f2552b4c4f9a6a2c236b


add support for customizing icons

@Olli thanks for your contribution! Please fix the linter errors:
https://travis-ci.org/feimosi/baguetteBox.js/jobs/445689660

For anyone subscribed to this issue, this functionality has just been released based on #245


Avoid entering password in version-controlled file

In step Generate the Database Schema one should update the appsettings.json file in the sample project with the connection string of the Azure SQL Database.
The connection string contains a password while the appsettings.json is version controlled. It is a bad/dangerous habit to store sensitive data in a version-controlled file.
If the goal of this edit is only to run the migrations, you should consider passing the connection string directly to dotnet ef database update (connection parameter). Alternatively, if one wants to run the app locally but connected to the cloud database, you should consider using Secret Manger.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: df55b676-8ff7-1470-3525-d0edfd406af6
Version Independent ID: ac264c26-7196-870b-760f-94a97ae437e8
Content: Deploy an ASP.NET Core and Azure SQL Database app to Azure App Service - Azure App Service
Content Source: articles/app-service/tutorial-dotnetcore-sqldb-app.md
Service: app-service
GitHub Login: @alexwolfmsft
Microsoft Alias: alexwolf

@kszicsillag
Thanks for your feedback! We will investigate and update as appropriate.

kszicsillag,  Thanks for the feedback! Your feedback has been shared with the content owner for further review.

This was addressed in the revised version of this tutorial, thank you.
#please-close


Create bpa.txt

@nikolsam First stage of verification passed, official domain for Belgrade Business and Arts Academy of Applied Studies is bpa.edu.rs as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@nikolsam Thank you for your patience while waiting for a review and processing your request. Pull request merged. Please start applying for JetBrains educational subscription at https://www.jetbrains.com/shop/eform/students in an hour, to allow the changes to propagate through JetBrains systems.


Can't pass exercise c4_LifecycleHooks need_to_cancel when upgrade reactor-core package.

I use the code below
        AtomicBoolean canceled = new AtomicBoolean(false);

        Flux<Integer> temperatureFlux = room_temperature_service()
                .doOnCancel(() -> canceled.set(true)) //todo: change this line only
                ;

        StepVerifier.create(temperatureFlux.take(0))
                    .expectNextCount(0)
                    .verifyComplete();

        Assertions.assertTrue(canceled.get());

The test case can pass when i use  reactor-core:3.4.14.
But it can't pass when is use reactor-core:3.5.0-m2.
Is this a bug of reactor-core:3.5.0-m2 or has the behavior changed on eactor-core:3.5.0-m2?
I don't know how to fix it.

Hi, thanks for reporting this issue. It might be due to change of behavior in next major version, but since it's a milestone version it's early for me to support it. Is there a specific reason why you are using milestone versions?
I didn't try it but looks like you may resolve it if you change take(0) to take(1) and expectNextCount(0) to expectNextCount(1)

It works.
Thank you very much. I use the milestone version because i start learn spring boot 3.


fusermount3: mounting over filesystem type 0x01021997 is forbidden

when I used this in wsl2, I got the error:

fusermount3: mounting over filesystem type 0x01021997 is forbidden

plz help

try mounting by root

fixed?

Try mounting it under the home directory.  Anything that is in their, "compatibility," layer stuff flat-out DOES NOT WORK (Funny this...).  The problem is that you're using one of the mapped to POSIX behavior "integration mounts"- which does a lot of things, well, WRONG.  No named pipes, this...
As typical of Microsoft, they've implemented things their way and it is not at-all supported for things like named pipes (Yocto will not build in a direct path to a storage volume- you will need a proper ext3/4, btrfs, etc to do builds with it-   So Docker atop it will be needed for this sort of thing or using VirtualBox (I'll presume that NOBODY in their right mind will use VMWare due to their new licensing...) ior a Full HuperX session setup instead.


assert error when trying to run emotions.py?

Hi,
I was interested in trying out your emotions.py function, but when I use the following inputs:
python emotions.py serialized_network --kaggle,
I get the error in deepbelief.py line 504:
assert np.all(mins >=0.0) and np.all(maxs < 1.0 + 1e-8)
Assertion error
Am I doing something wrong with how I'm calling the function?

As discussed via email, the issue stands from the data not being present.
You need to write the Kaggle data into 'train.csv' and 'test.csv' for it to work.
This needs some clean up,  can you please file a separate issue to clean this up: require flags for the data and check in the files that I used?
Thanks!


Fix known Python 3 issues

Check if this PR fulfills these requirements:

[x] My changes respect the Kodi add-on development rules
[x] I have read the CONTRIBUTING document.
[x] I made sure there wasn't another one Pull Requests opened for the same update/change
[x] I have successfully tested my changes locally

Types of changes

[ ] New feature (non-breaking change which adds functionality)
[ ] Feature change (non-breaking change which change behaviour of an existing functionality)
[x] Improvement (non-breaking change which improve functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description
This fixes the known Python 3 issues reported by kodi-addon-checker, tox and pylint.

@Smeulf This should be using the best possible implementations for iter*.
Now on to porting the rest (unicode, urllib, etc.)

@CastagnaIT This requires #196 to be merged first.

Catch-22. For testing Python 3 support, there is only a Windows binary. It appears that this Python 3 build does not ship with pycryptodome, even though it appears to be installed, it is not. As a result I am stuck at that for testing.

So with this PR a lot of things work on Python 3 (locally using integration tests) as I cannot test it for real. There are still a few issues, but service.py works fine and some of the views as well (I haven't tested them all).

to understand, then integration works only locally, for every pullrequest nothing will be verified

@CastagnaIT Correct, we cannot enable the integration tests if they fail in Travis. That is still a work in progress.
Also, this PR currently includes the removal of mysql-connector-python, but the script.module.mysql.connector will not be merged (become available) until our add-on plugin.video.netflix is accepted. So we cannot included those changes just yet.
Not sure what you prefer to do ?

So I think this is ready to be merged as well, but please do test this branch on your systems. I can't guarantee it will work on Python 3, as it is only tested locally outside of Kodi. But lacking a real usable Python 3 system at the moment, I would be willing to propose this upstream.
But we have to be certain this branch works as well as before, on Python 2 !

As a reminder, Python 3 is still not enabled in Kodi, so if it still works on Python 2, it will be ok.
Python3 is a recomandation from Kodi team to ensure migration when switching to Python3. But we will have some time to fix the potential remaining issues before it becomes a final release.
I'll run some tests on Windows and then on RPi hopefully tomorrow, focused on Library export, StreamContinuity and ResumeManager. Plus some basic playing tests of course :)

@Smeulf We have been testing it the whole evening, watching Netflix ;-)
But I don't use some of the advanced functionality (MySQL, Library, etc.) and I don't have any integration tests for those. We do need to have unit tests and more integration tests.
Also, if I cannot test the add-on in Kodi, it is likely that we are testing against a framework that does not closely mimic a real Kodi Python 3 environment.
In any case, to me, with my limited testing, it works fine on Kodi Leia, on Windows, RPi and Android.

But I don't use some of the advanced functionality (MySQL, Library, etc.) and I don't have any integration tests for those. We do need to have unit tests and more integration tests.

I do have the requierement for those tests, including SQL.
It will be manual, but I know what to check.
It won't be as safe as integrated tests, but limit the issues.

At first start. Then I restarted and the error diseapear. Sorry more log is unavailable.
2019-09-11 16:47:11.305 T:1672459120   ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--                                              - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!                                             Error Type: <type 'exceptions.ImportError'>                                             Error Contents: No module named future.utils                                             Traceback (most recent call last):                                               File "/storage/.kodi/addons/plugin.video.netflix/service.py", line 17, in <module>                                                 from resources.lib.globals import g                                               File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/globals.py", line 21, in <module>                                                 from future.utils import iteritems                                             ImportError: No module named future.utils                                             -->End of Python script error report<--

Plus I have an arror with MySQL, and I can't browse My List as an example.
https://paste.kodi.tv/iqelayubol.kodi

I couldn't reproduce the SQL error on LibreELEC x86 (virtual machine).
Looks like a Pi issue(?). I'll try to get a more comprehensive log (remove the try block) in the late evening.

After removing the try block in db_base_mysql / _execute_query, now that's interesting:
MySQL error Failed processing format-parameters; Python 'newstr' cannot be converted to a MySQL type:
https://paste.kodi.tv/sumucopeni.kodi

removal of mysql-connector-python

@CastagnaIT Correct, we cannot enable the integration tests if they fail in Travis. That is still a work in progress.
Also, this PR currently includes the removal of mysql-connector-python, but the script.module.mysql.connector will not be merged (become available) until our add-on plugin.video.netflix is accepted. So we cannot included those changes just yet.
Not sure what you prefer to do ?
Update: I guess the best way forward is move those changes (that would break the add-on) to #200 instead, and leave that one open until we are ready to release?

i agree with you move the removal of mysql-connector-python to the other PR, so we can merge this pr (after fixes) without breaking nothing

@Smeulf You should have future as this is now a requirement for the plugin.

I saw future being installed, but at first run I had that error. No more after, but I remember we had some error like that before and some module couldn't be loaded on OSMC. So it's more a warning than anything.

By 'some error like that' I mean 'an error at first run in LibreELEC I couldn't reproduce after, but had other consequences in other environments'

@Smeulf Yes, there is a general issue with Kodi that newly installed modules do not take effect immediately and you need to restart Kodi (or reboot) in order to make it work.

So in relation to MySQL you will have to fix this yourself.
Personally I don't like the MySQL integration and the complexity it adds to the code.
I have it disabled, and it is still trying to use it (and reports it) before falling back.
I also don't see what the MySQL integration brings, people run Netflix from all kinds of devices without any MySQL integration and I think our add-on should work exactly like that.
I have similar doubts with the Library synchronization. I think functionality like that are a distraction (and complexity that the majority of users are not looking for), and that we should focus on creating a Netflix add-on that works as well as the official Netflix offerings.

I also don't see what the MySQL integration brings, people run Netflix from all kinds of devices without any MySQL integration and I think our add-on should work exactly like that.

It brings synchronization betweek devices for:

Resume points
StreamContinuity (Per profile Language selection)
Library export.

So when I start watching a show in the living room I set in english with french subtitles, I can restart the same show, in the same language, at the same point in the bedroom if I want to.
Till we can't send watched status to Netflix, it's important to me.
About library, it's been discussed for a long time: it's also a matter of unification between different sources (local and streams), plus it allows the use of Trackt.

And it's been a lot of work to get that level of functionality, now it works (maybe it's not perfect) but I'd be pleased if we don't break everything ^^

Till we can't send watched status to Netflix, it's important to me.

Wouldn't it be better to look into sending this information to Netflix so it works everywhere instead?
Also, I have exactly what you want as part of Kodi. All my Kodi boxes are connected to MySQL and they show what has been watched and remember the offset automatically. I don't need the Netflix addon to take care of this.

Wouldn't it be better to look into sending this information to Netflix so it works everywhere instead?

Sure it would, but for now, no one has a clue on how to do it, Even ascidisco was stucked... If you can find something for sure it would be awesome.

All my Kodi boxes are connected to MySQL and they show what has been watched and remember the offset automatically

If you never change the language for a tv show, sure you can't see the benefit of shared stream continuity data.
Same, as you don't use library export (witch is present since early alphas of the addon btw), you can't see there's no sync of the exported items without a shared db, and an issue with the resume point workaround because it can't see the video was exported...

<videolibrary>
    <importwatchedstate>true</importwatchedstate>
    <importresumepoint>true</importresumepoint>
    <cleanonupdate>true</cleanonupdate>
 </videolibrary>

Those settings just says you import watched status and resumepoints from NFO if they exists when scanning the sources.
You gain the watched status and resume points because every "plugin://plugin.video.netflix...." "files" you watch are stored in the "files" table of the database. But if you use the library export feature, then  the resume workaround can't work, because strm files are playlist and can't be resumed (Kodi behaviour it seems they are not ready to change...)

If you never change the language for a tv show, sure you can't see the benefit of shared stream continuity data.

We always watch the audio in the native language, and subtitles in English (except if it is Dutch).
Never had any issues though. Kodi takes care of this.

Same, as you don't use library export (witch is present since early alphas of the addon btw), you can't see there's no sync of the exported items without a shared db, and an issue with the resume point workaround because it can't see the video was exported...

I have no clue what library export does, or why this would be useful to me. And I wonder how many people are looking for this. But if you think it is worth it, fine. It does add a lot of complexity that I would prefer to disable.

You gain the watched status and resume points because every "plugin://plugin.video.netflix...." "files" you watch are stored in the "files" table of the database.

Ok, so the majority of the people have this out of the box with Kodi MySQL integration (except the language not being remembered on other devices) And we are adding our own MySQL integration (and lots of complexity) because of an issue in Kodi when doing library exports? That seems the wrong trade-off IMO.

About library, it's been discussed for a long time: it's also a matter of unification between different sources (local and streams), plus it allows the use of Trackt.

The unification of local videos and VOD content is something Kodi should facilitate and is something I don't understand they haven't figured this out (maybe they do, haven't seen any design). The same is true wrt. TV/Radio and online TV/Radio streams in add-ons. You would expect that add-on content could be registered (and expired) as Movies/TVshows/TV or Radio and it would appear where it belongs.
This should not be something the add-on has to develop itself and it should not require a user to create a database instance and table in order to get this working.

because of an issue in Kodi when doing library exports

And to make it working correctly (ie retreive labels, etc). Try to play around with the export without the sql, and see the differences on your other client...

This should not be something the add-on has to develop itself and it should not require a user to create a database instance and table in order to get this working.

You found the right work: "Should". If you have any other way to make it work correctly on multiple devices, please share :) For now, until Kodi evolves, I'm not sure there's one...

And to make it working correctly (ie retreive labels, etc). Try to play around with the export without the sql, and see the differences on your other client...

Again, I don't see why I would want to export to my Kodi library. Not sure what "retrieve labels" is and why I would care. The Netflix add-on works fine as it is.

For now, until Kodi evolves, I'm not sure there's one...

So you think it is only logical that every add-on implements this themselves. I am convinced this is worse than not having this functionality at all (until it is part of Kodi). But that is probably because I don't mind to set the language myself on every device. (I have 3 but I seldom continue to watch the same program on another device, and I wonder how many users are in that same situation).

So you think it is only logical that every add-on implements this themselves

Never said that.
My point is we're (all people creating add-ons I think, including you) trying to do the best with what we have in our hands: a Python framework lacking a lot of functionality and events regarding Kodi (Even if I have to mention it's getting better and better every year)
And here, to fix issues and keep this add-on alive, and fix with functions that was already present but was not compatible with a shared Kodi db.
You're free not to care about people using the functions the add-on offers, but that's not a reason to break them...
Anyway, that's not my call, it's @CastagnaIT one, so he will remain the one with the last word.

@Smeulf I don't want to break anything, I am just questioning the complexity and maintainability of the code. And the trade-offs that have been made. For all I care it can stay the way it is. But the complexity also makes it harder to test all the different use-case and combinations of functionality. So I cannot take responsibility for things I cannot test.

So I cannot take responsibility for things I cannot test.

I do understand.
I was just explaining what was the benefits of the MySQL connection, and saying it'd be pleased if we don't remove it...... :D


Hot config reloading

Ideally, the bot should monitor the config file for changes. When a change occurs to the file, it should update the app state.
This will allow users to change the bot behavior without restarting the running app.

Thanks for pointing this out. It will need further discussion, but the classic way is to send a HUP signal for configuration reloads.  If you see benefit in auto-reloading on change versus sending a signal, what I'm thinking:

Create a configuration option to enable this (default is disabled)
Always have the default HUP signal style enabled.


@firebase/database: FIREBASE WARNING: Exception was thrown by user callback. TypeError: Cannot read property 'myID' of undefined

Version info

Angular: ^5.2.0
Firebase: ^4.13.1
AngularFire: ^5.0.0-rc.6.0
Other (e.g. Node, browser, operating system) (if applicable): Firebase Hosting
Test case
getLocations(radius: number, coords: Array<number>) {
        this.geoFire.query({
            center: coords,
            radius: radius
        })
        .on('key_entered', (userKey, location, distance) => {

            const existAlready = this.hits.value.filter(h=>h.userKey === userKey)

            if(existAlready.length > 0){
                return
            }

            const u = this.userList.query.ref
                          .child(`/${userKey}`)
                          .on('value',s=>{
                            const {name, address} = s.val()
                            console.log(s.val())
                            let hit = {
                                location,
                                distance,
                                name,
                                address,
                                userKey
                            }

                            let currentHits = this.hits.value
                            currentHits.push(hit)
                            this.hits.next(currentHits)

                            this.eventService.sendMessage(Constants.EVENT_MESSAGES.LOADING, true)

                          })
        })
    }

Basically what i am doing is fetching the current location and passing it to the function above

Steps to reproduce
I am using angularfire with geofire for a location based app for fetching locations around my user. It works perfectly on my dev machine, but as soon as i build and deploy to firebase hosting, I get a very strange error

@firebase/database: FIREBASE WARNING: Exception was thrown by user callback. TypeError: Cannot read property 'myID' of undefined

What i am doing basically is fetching the current location and passing it to the function above, the function is meant to fetch nearby locations and then put them in a behavioursubject. It works well in development like a said, but its a big NO NO on the firebase hosting server.

Expected behavior
I expect to get back the locations around me saved in firebase.

Actual behavior
I am getting an error as stated above.

I am facing the same problem using the exact setup except for  angularfire2 ^5.0.0-rc.7.

I am having the same issue as well! In dev the code runs fine, onceI switch to ng build --prod i get the following message when i run the app Cannot read property 'myID' of undefined

same here

same here

same here!

same here. Is the fix planned down the line?

same here

I ran into this issue today and it seemed to be related to having a logged in Firebase auth state. I pushed the same code to two different Firebase hosting projects and it worked on one and not the other. The site that worked was logged out. Once I clear cookies etc for the broken site and logged in again it started working.

Same problem for me, it throws the error for some users, and works for some other users.

same here. works for the first time but when I close the browser and open the hosted site I get this error.

Is there any update from the Firebase team on this?

No, i posted the issue at stackoverflow and no answers from anyone.. how can we open a bug at firebase?
https://stackoverflow.com/questions/50402963/firebase-database-exception-was-thrown-by-user-callback-typeerror-cannot-rea

same to me :(

Same :-(

I think we should close this issue, since it not problem from angularfire, it is firebasejs sdk

@hiepxanh, really? Found a solution?

Not sure how you can be sure it's not a problem with angularfire as the people reporting it all seem to be using angular - or at least I can't find others experiencing this problem.  I'm seeing the same problem as everyone else, only when compiled with --prod.

I'm getting the same exception but only when I'm trying to access my website from my workplace proxy. At home I can connect without any issues.

I found a workaround : https://stackoverflow.com/questions/50402963/firebase-database-exception-was-thrown-by-user-callback-typeerror-cannot-rea
But it doesn`t explain the main problem.

I am having the same issue as well! In dev the code runs fine, once I switch to ng build --prod i get the following message when i run the app Cannot read property 'myID' of undefined

Same issue here, it seems that if you delete Firebase's cookies it will work, however once those are available it just starts spitting the error. Maybe that's why many people reported it as an issue which is not always easily reproducible.

@angelnikolov, That is true. The issue is affecting only the system of the developers (presumably) who have ping the application from a dev environment (thereby creating the login cookie) and then try to access them from a prod env. To avoid this issue, one can clear the cookies and hitting the prod env. Or just give it to your tester or manager who aren't using the dev env. It will work for them. Either ways, this is still and issue and needs attention from the angularfirebase, Not a P1 though.

I have solved this issue.  I'm using React and it solved this error !
Thank you very much

Ths same problem with already bundled (--prod) and deployed to hosting app. After weeks of work has eventually crashed with this error

@mubashshirul Thank you! Worked like a charm

@mubashshirul 's solution worked good, but error sporadically appeared not only on developer but on clients' computers too. Now after using ng build --prod  --build-optimizer=false everything is OK for more than a week.

I Experienced the same problem as @aroncal . At first, I thought it was a problem related to the user login token timing out, but no, it seems to be network disconnect and reconnect related. I will try to downgrade to firebase#4.12.1 myself and see if it works

forgot password reset link , see the video link completely solved
https://youtu.be/daGZO6YAkRg

No official fix for this yet? It's still alive even on a wrong GitHub project, since the problem is apparent when using only the JS Database / library.

@mubashshirul 's solution worked good, but error sporadically appeared not only on developer but on clients' computers too. Now after using ng build --prod --build-optimizer=false everything is OK for more than a week.

This is working to our case. in our case removing the localstorage item didn't help.
I changed from ng build --prod --aot --build-optimizer to ng build --prod --aot --build-optimizer=false

Why this issue is closed if now on 2021 is still occurring with --prod devices?


[e2e]: delegator-lowperms tag main default slsa3

Repo: https://github.com/slsa-framework/example-package/tree/v47.0.451
Run: https://github.com/slsa-framework/example-package/actions/runs/11221280185
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.delegator-lowperms.tag.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.delegator-lowperms.tag.main.default.slsa3.yml
Trigger: push
Branch: v47.0.451
Date: Mon Oct  7 18:08:50 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/v47.0.451
Run: https://github.com/slsa-framework/example-package/actions/runs/11221280185
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.delegator-lowperms.tag.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.delegator-lowperms.tag.main.default.slsa3.yml
Trigger: push
Branch: v47.0.451
Date: Tue Oct  8 07:22:15 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/v47.0.452
Run: https://github.com/slsa-framework/example-package/actions/runs/11241091957
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.delegator-lowperms.tag.main.default.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.delegator-lowperms.tag.main.default.slsa3.yml
Trigger: push
Branch: v47.0.452
Date: Tue Oct  8 18:14:16 UTC 2024
Tests are passing now. Closing this issue.


Add 2020 to timeline

This PR adds a dot to country timeline that point to the 2020 commitment of countries to submit new NDC's
Pivotal

@Bluesmile82 , @simaob actually the dot link does not point to any page. I think it would be nice to point to the WRI document about 2020 NDC's enhancement.
What do you think?

Hi Javi, I haven't checked it yet, but might be good to make it have a different colour to differentiate from the other dots. In regards to the link, maybe ask in the Basecamp thread to understand if that's something they'd be keen on.

Waiting for a response in basecamp


[Site] Multiple burger menu in Mobile view for Docs Page

Current State of the GetNighthawk.dev site
Currently, there are 2 burger menus when we switch to the mobile view on the Docs page.
Desired State of the GetNighthawk.dev site
As discussed in the March 29th 2021 website meeting: Addition of a floating menu for the Docs section. In a similar way as it is on https://reactjs.org/docs/getting-started.html Any other suitable way of doing this can also be approached.

Contributor Resources

See the Contributing to getnighthawk.dev Website
See the Project Site section of GetNighthawk project doc

Hey @vinayaksh42 , Can I work on this?
Along with this, the texts in on the site aren't aligned properly in Mobile view. Will fix that too with this🚀
Screenshot:

@adithyaakrishna sure, I will assign this issue to you
For the Mobile view problem you can create a new issue and work under it.

hey, @adithyaakrishna are you still working on this issue?
Feel free to contact me on slack in case you are facing any block while implementing the new changes.

Hey, I would like to take up this issue 😃

Hey, I would like to take up this issue 😃

Sure, please go ahead

I am sorry @Jashpatel1 , i am busy with some work . Is it fine if i take some time ? its fine with me if anyone else is interested in taking up this issue ✌🏽

can i take up this issue?

Yes sure @kaushambisharma 💯

@kaushambisharma's on the job! 😄

Hi , @kaushambisharma are you still working on this issue?
Feel free to reach out on Slack in case you are facing any blockers

@vinayaksh42 yes i am, will certainly do :)

@vinayaksh42 yes i am, will certainly do :)

Hey @kaushambisharma are you still working on this issue?

if anyone's not working on this issue can I work on this ? @vinayaksh42 @leecalcote

should I work on this @warunicorn19, or any newcomer should ?

@shubham-tyagi  You can work on this issue 🚀

@shubham-tyagi are you working on this issue? Otherwise, I can start working on this?

Hey @msaini0r thanks for stepping up, I was caught up in other issues.

@msaini0r any progress to speak of?

@msaini0r any progress to speak of?

You will have a pr by tomorrow. @leecalcote

You will have a pr by tomorrow. @leecalcote

@leecalcote I am working on this issue. When I am trying to change the CSS for the navigation bar, it is changing for the whole mobile view not just for the docs section. Just wanted to confirm this issue is only for the docs section or for the whole mobile view to make a new floating navigation bar?
Below gif is just a sample.

@vinayaksh42 can confirm.

Hi @msaini0r, For this issue we actually want to change the docs navigation menu and not the website's navigation menu. Basically the navigation menu that is used for going from one section of the documentation to the other. Right now, when we switch to mobile view in Docs section, We get two burger menus. One for the website navigation and one for the docs navigation. We want to change the docs navigation burger menu to a different format so that we have two distinct navigation menus when in mobile view (Docs page). I hope this clears up your doubt, feel free to message me on Slack if you require more information

@leecalcote @shubham-tyagi I am unassigning myself, I am not able to solve this issue.

@vinayaksh42 @leecalcote I think we should put all the options in the main navbar.

@anirudh-bukka Would you like to give this a try?

@anirudh-bukka Would you like to give this a try?

@adithyaakrishna , I have mostly will have my Finals and Labs in a week, so I am not sure if I will be able to spend time on this issue. But I will let you know and work on this if they are postponed.

I would like to give it a shot.

Thanks @Sunnyio, for taking this up.


Rename defaultMemoize to lruMemoize

This PR:

[X] Renames defaultMemoize to lruMemoize
[X] Updates JSDocs to include name change
[X] Updates README to include name change
[X] Renames defaultMemoize files to match lruMemoize

Let's do it


Lodash dependency is a security vulnerability

Need to update lodash, because of security vulnerabilities: https://nodesecurity.io/advisories/577

Have tried updating lodash locally, but some tests are failing even with the existing lodash version - is there anything else needed to be done apart from having a local kafka server and running npm run test?

Need to update lodash, because of security vulnerabilities: https://nodesecurity.io/advisories/577

Thanks, loadash updated in version 3.2.10

Have tried updating lodash locally, but some tests are failing even with the existing lodash version

Which exactly tests?


Error using JSON schema

Test case:
{
	"$schema": "http://json.schemastore.org/package"
}

Error

Unable to load schema from 'http://json.schemastore.org/package'. No schema request service available

The JSON worker of the monaco editor does not try to load any references by default.
But if you enable the option enableSchemaRequest, the browser's fetch-API is used.

Can this be enabled on https://microsoft.github.io/monaco-editor/?

Not sure why you want this to be enabled.
But if you want to try it out, use this in the playground
monaco.languages.json.jsonDefaults.diagnosticsOptions.enableSchemaRequest = true;

monaco.editor.create(document.getElementById("container"), {
	value: '{\n  "$schema": "https://raw.githubusercontent.com/SchemaStore/schemastore/master/src/schemas/json/package.json",\n  "author": {}\n}',
	language: "json"
});

BTW, the alternative of enabling loading is passing the schema through the configuration.
As you will see, there are restrictions on what web pages can load.

Very cool, thank you. I always use JSON with schema, very helpful.

@aeschli When I include monaco.languages.json.jsonDefaults.diagnosticsOptions.enableSchemaRequest = true; I get:
Cannot assign to 'enableSchemaRequest' because it is a constant or a read-only property.

(property) monaco.languages.json.DiagnosticsOptions.enableSchemaRequest?: boolean | undefined

If set, the schema service would load schema content on-demand with 'fetch' if available`

Is that a bug?

You are right, the default settings are not meant to be modified.
This is the currect code:
monaco.languages.json.jsonDefaults.setDiagnosticsOptions({ validate: true, allowComments: false, schemas: [], enableSchemaRequest: true})

monaco.editor.create(document.getElementById("container"), {
	value: '{\n  "$schema": "https://raw.githubusercontent.com/SchemaStore/schemastore/master/src/schemas/json/package.json",\n  "author": {}\n}',
	language: "json"
});


ENH: Add pca

Closes #104.
Is there a better way to compare float matrices are almost equal?

Thanks for the PR! I'm really looking forward to reviewing it :D
As for your question, rulinalg has an assert_matrix_eq! macro which has good support for floating point comparison. This was released in 0.3.7 and so you may need to bump the version up in rusty-machine to access it.

Updated to use assert... macro. Pls review when u have a time.

As the weekend is finally here I'll have some time tomorrow to go over all of these PRs. Thank you again for the amount of effort you've put into them - there's a lot of things here that I've been trying to find time to do for a while!

Thanks for updating this so quickly!
I wont be able to take a look for a couple of days sadly. I had a quick glance and it looked good to me. There was just one thing (that I might have missed). Have you handled the case where a matrix has more columns than rows?

I have been feeling a little conflicted about having PCA implement the UnSupModel trait. I worry that the predict function doesn't make much sense. It seems the flow would be something like:
// The data that I want to reduce to principal components
let data = Matrix::new(...);

// Train a new pca model
let mut pca = PCA::default();
pca.train(&data);

// Reduce the data to get components
let p_components = pca.predict(&data);

I was thinking that maybe the Transformer trait would be a better fit?
What do you think? I think it's safe to say that you know more than about this than I.

Thanks for making these changes! The code looks good to me now - but I'd still like to discuss whether the predict function is really a good fit here. I'm using the sklearn documentation as a reference.

Yeah, Transformer should be clear. How about below definition?
    pub trait Transformer<T, U> {
        /// Transform inputs.
        fn transform(&self, inputs: &T) -> LearningResult<U>;

        /// Fit the transformer using inputs.
        fn fit(&mut self, inputs: &T) -> LearningResult<()>;
    }

I feel .transform should return transformed data using components, rather than components itself. It is the same as sklearn (also, R's predict behaves as the same).

I feel .transform should return transformed data using components

I agree. The approach I would take would be to have the transform function transform the data, store the components in the PCA model, and then return the transformed inputs. I mean like this:
impl<T: Float> Transformer<Matrix<T>> for PCA {
    pub fn transform(&mut self, inputs: Matrix<T>) -> LearningResult<Matrix<T>> {
        let (components, transformed_inputs) = do_pca(inputs);
        self.components = Some(components);
        Ok(transformed_inputs)
    }
}

This is definitely not perfect. Sadly the API needs a little tweaking but really it is impossible to describe all possible machine learning actions with a small set of traits. Because of this we need to try and stretch the traits a little.
With all that said, I think updating the Transformer definition as you have isn't a bad idea. I just wanted to explain the idea behind the current trait a little.

I think that with the new Transformer trait changes we can get this PR in a position to merge.

@sinhrks just pinging you on this. Let me know if you plan to complete the work now that the Transformer changes are in place.

Sure, will do.

Note that #176 will land soon too (hopefully I'll check it over and merge tomorrow)

This is great. May it be successfully rebased and merged. I am going to start using it for some machine learning work.

I'm inclined to merge this now and let making it use Transformer rather than UnsupModel a separate issue. (To be blunt about it, "integrating ancient PRs so that the project can be alive rather than dead" is currently a higher priority than "avoid API instability on master.")

By the power vested in me as Acting Deputy Lieutenant Comaintainer (junior grade) of rusty-machine, this has been rebased and merged (#188).
@sinhrks thank you!! :sparkling_heart:
@posix4e The rusty-machine maintainers regret the delay. Good luck with your work!—please file an issue if you have any problems.


style: let the reader decide if something is simple or easy

We should refrain from using words like "easy!" or "simply" or "just" or "extremely easy" or "to show you how easy it really is", etc. Let the reader assess how hard a particular step is for them and not stress them out that it should have been easy.
This is something which bothered me quite a lot when reading through the academy for the first time, hence I decided that toning the whole academy down in this regard will be one of my first proposed changes.
This PR is rather large and I'm sorry for that. Most of the changes just remove one word from a sentence, as the sentence works completely the same without it. In some cases it was necessary to rewrite the sentence.

Replaces https://github.com/apify/apify-docs/pull/1028. The original PR ended up having huge merge conflicts with current master.

Huge thanks for the review! ❤ This PR will continue here: https://github.com/apify/apify-docs/pull/1201 I'll document all additional changes in the description.


Increase branch coverage

Add in total 10 additional tests that target

scrapy.http.request.form._get_inputs,
scrapy.http.request.form._get_form,
scrapy.http.request.form._get_clickable,
scrapy.utils.curl.curl_to_request_kwargs or
scrapy.utils.python.get_func_args

that increase the current branch coverage of the functions.
This issue should probably be split into multiple issues regarding the specific functions once we have figured out which functions need additional tests.

The test that is added for get_func_args enhances branch coverage of the file python.py från 66% to 67%.

The test that is added for _get_inputs enhances branch coverage of the file form.py from 97% to 98%.


Support unmyelinated axons in morphometrics

Checklist

[x] I've given this PR a concise, self-descriptive, and meaningful title
[x] I've linked relevant issues in the PR body
[x] I've applied the relevant labels to this PR
[ ] I've added relevant tests for my contribution
[ ] I've updated the documentation and/or added correct docstrings
[x] I've assigned a reviewer
[x] I've consulted ADS's internal developer documentation to ensure my contribution is in line with any relevant design decisions

Description

I'll add test/documentation when the feature is ready.
In its current state, this feature can be used as follows:

the user specifies the -u flag. This will toggle unmyelinated_mode and the morphometrics script will only look for prediction suffixed "_seg-uaxon". Axon and myelin masks will NOT be loaded/processed in this mode.
a CSV file is saved alongside the _index and _uaxon-index images.

Note that currently, in unmyelinated_mode:

colorization flag is ignored
border info flag is ignored

Linked issues

Resolves #795

Ok so the feature is ready to test. To try this, simply run the axondeepseg_morphometrics with the -u flag. I suggest taking an arbitrary image + axon segmentation, the renaming the prediction to have suffix _seg-uaxon instead of _seg-axon.

I tested it and it works on my end. I can review it once it is not marked as a draft.

@Stoyan-I-A thank you for testing. The PR is now ready for review. I'll add tests + documentation if the logic is ok with you and @mathieuboudreau.

Ok everything is finalized here - ready for final review.


FFmpeg.AutoGen  <IP_ADDRESS> dll not found for kernel32 on linux

This is the lib i'm using to interface C# to ffmpeg. It was the best I could find.
Maybe this is because it's working with the windows dlls. I just ran my code and it's throwing a dll not found for kernel32. For this line _format = ffmpeg.avformat_alloc_context(); I think it's the lib I got from NuGet  FFmpeg.AutoGen <IP_ADDRESS> per their github it will work in linux. If I understand it, we need to compile it ourselves with exact locations of the ffmpeg libraries.

there is a FFmpeg.AutoGen.dll.config I think I need to find out where the files are on ubuntu and put them in there and compile it and give the new dll to openviii and everything should just work? shrugs

Looks like I need FFmpeg 3.4.5 "Cantor" I'm following directions from https://seanthegeek.net/455/how-to-compile-and-install-ffmpeg-4-0-on-debian-ubuntu/ to compile it. I'm just swapping out 4.0.
I'll put a setting up ffmpeg on linux help.txt or something in the repo.

Well I was wrong heh the config file they had with this was listing the old version of ffmpeg. but 3 months ago he updated it to 4.1

He said the fix involved putting the full path to the libraries in FFmpeg.AutoGen.dll.config
<configuration>   <dllmap os="osx" dll="avcodec-57" target="/opt/local/lib/libavcodec.57"/>   <dllmap os="osx" dll="avfilter-6" target="/opt/local/lib/libavfilter.6"/>   <dllmap os="osx" dll="swresample-2" target="/opt/local/lib/libswresample.2"/>   <dllmap os="osx" dll="avformat-57" target="/opt/local/lib/libavformat.57"/>   <dllmap os="osx" dll="avutil-55" target="/opt/local/lib/libavutil.55"/>   <dllmap os="osx" dll="swscale-4" target="/opt/local/lib/libswscale.4"/>   <dllmap os="osx" dll="postproc-54" target="/opt/local/lib/libpostproc.54"/>   <dllmap os="osx" dll="avdevice-57" target="/opt/local/lib/libavdevice.57"/>   <dllmap os="linux" dll="avcodec-57" target="libavcodec.57"/>   <dllmap os="linux" dll="avfilter-6" target="libavfilter.6"/>   <dllmap os="linux" dll="swresample-2" target="libswresample.2"/>   <dllmap os="linux" dll="avformat-57" target="libavformat.57"/>   <dllmap os="linux" dll="avutil-55" target="libavutil.55"/>   <dllmap os="linux" dll="swscale-4" target="libswscale.4"/>   <dllmap os="linux" dll="postproc-54" target="libpostproc.54"/>   <dllmap os="linux" dll="avdevice-57" target="libavdevice.57"/> </configuration>
I tied a few different variations and it didn't seem to work. Maybe Monday I'll get it to work. Monogame has a similar file. MonoGame.Framework.dll.
Related issues:
https://github.com/Ruslan-B/FFmpeg.AutoGen/issues/27#issuecomment-219403806
https://github.com/Ruslan-B/FFmpeg.AutoGen/issues/89

Well I found out today it is detecting the libraries correctly. It's just using a windows only function. Submitting a bug report maybe I'll try to fork and push update to him. Though my update doesn't make everything work it just doesn't throw an exception anymore.

https://stackoverflow.com/questions/55405051/kernel32-not-found-when-using-ffmpeg-autogen-4-1-0-2-in-mono-linux
I posted on this before I realized it was a bug issue not a troubleshooting one.

It's working now with custom build of ffmpeg-autogen. He will update the real one when he is back from vacation.


[DOC] links to docker hub in README.md are deprecated

Report incorrect documentation
in README.md, the links to docker hub still point at the deprecated images.
Location of incorrect documentation
Readme.md line 8

Describe the problems or issues found in the documentation
base should point to (rapidsai/base)
notebooks should point to (rapidsai/notebooks).
Steps taken to verify documentation is incorrect
List any steps you have taken:
clicked on the existing links and found the deprecation notice on docker hub.
Suggested fix for documentation
Update the links

Fixed by #662


README.md pointer to JDK isn't right

The pointer to the Oracle Java 1.8 JDK is to the JRE, not the JDK.

Corrected in bd2cf5617ff0386ba4fb17a8e4194cc888e4220d

Fixed.


Save main sass file when saving imported files

When using a common Sass structure of having one main.sass file which imports all other sass files, it can be tedious when editing an imported file since you must save that file, then save main.sass as well so that it can compile everything.
What would be easier is if when saving an imported file, main.sass will be saved and then the Sass will be compiled. I looked through the readme and didn't find any way of doing this. Did I miss something or is there a workaround available? Thanks.

Apologies I found the solution in the docs, must have missed it: https://atom.io/packages/sass-autocompile

Great ;)


Upgrade operations could overwrite OIDC, admin list and autoscaler params

Description
Message from @ebensom

Hi @gopher,
Am I thinking right that after the autoscaler params can be changed as part of SI update , this piece of code in cluster upgrade process is incorrect, as it overwrites operation.ProvisioningParameters (latest params obtained from instance) with the original ProvisioningParameters used during provisioning, so effectively undoing user changes in autoscaler settings.

https://github.com/kyma-project/control-plane/blob/7485d4eba7bd058ec0795bd258d7249504b7cdc6/components/kyma-environment-broker/internal/process/upgrade_cluster/initialisation.go#L118-L127
Expected result
n/a
Actual result
n/a
Steps to reproduce
n/a
Troubleshooting
n/a

The upgrade cluster operation takes provisioning parameters instead of the newest (modified by an update).
AC:
provide a e2e unit test described below
Expected result
The following scenario is passing:
Provision SKR,
Update autoscaler params,
Trigger upgrade cluster
assert that cluster upgrade request contains autoscaler params set in previous step (2)


Move command palette into app.

This is one potential route we can take, offering the application's command palette instance as an attribute of JupyterLab instead of making it a plugin. But it's a fairly opinionated stance and has pros and cons.
Can we discuss this sometime before Friday?
cc: @sccolbert @ellisonbg @blink1073 @jasongrout

It feeds into a larger discussion of the least obtrusive way to handle dependency injection's semantics for users: the long list of arguments we currently pass might not be optimal.

What's the advantage of having the palette be a private (accessible) attribute instead of a plugin? Just one less argument for the DI framework?
My initial reaction is -1, since it would be harder to customize the palette and sets that particular ui component apart from other components.

We are treating the command palette as a core part of the interface right now, with screenshots and documentation in the landing/about page. So we should probably change the language used to describe it in the about page to indicate that even though it's part of the "default" build of JupyterLab, it's still a plugin and can be extended, etc.

But aside from that, I don't have any issue with it being a plugin. It was an attribute before the mono-repo. With the current master, post-mono-repo, it is a plugin. In this PR, it's an attribute again, but we could leave it as a plugin.

Based on further discussion, we decided that it should continue to reside as a separate plugin, since there is nothing fundamentally different between this and the top level menu, and we have to draw the line somewhere, so we say that the app only contains the attributes defined in the base class.


Add configurable priority class as part of the helm chart template

Is your feature request related to a problem?
Please describe a clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
I'd like to have a way from the helm chart to change the priority class for the Robusta runner and forwarder pods.
Describe the solution you'd like
A clear and concise description of what you want to happen.
A priorityClassName field should be added in the helm values.yaml file under both the kubewatch and runner sections, as well as added to the forwarder and runner templates.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Thanks for the PR @dzliang100
Closing it


A bouton "renew membership" should be available

When the membership is about to expire, cutecoin should display a "renew membership" which would send a new membership document.

Added in https://github.com/ucoin-io/cutecoin/commit/5ff086b9c316bcc568054d8b3ee977e3986364db


Rename gas price per pubdata for more clarity

What ❔
Why ❔

Checklist

[ ] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[ ] Tests for the changes have been added / updated.
[ ] Documentation comments have been added / updated.

Already included as part of the following release: https://github.com/matter-labs/era-contracts/pull/167


example(multipart): add multipart example

Codecov Report

Merging #57 (3aa4add) into master (ea3cbb8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #57   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           29        29
  Lines          291       291
  Branches        32        32
=========================================
  Hits           291       291

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea3cbb8...3aa4add. Read the comment docs.


fixFix hive p2 cases.

Proposed changes
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Update Project Portfolio

Pull Request Test Coverage Report for Build 471

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 84.114%

Totals

Change from base Build 470:
0.0%

Covered Lines:
2748

Relevant Lines:
3267

💛  - Coveralls


Profiling init configs built with straight.el

straight.el appears to be incompatible with ESUP, the Emacs Start-Up Profiler. What is the right way to profile dotemacsen that are fixtured with straight.el?

Works for me, with the following code in init.el and running M-x esup after initial installation from an otherwise empty ~/.emacs.d:
(defvar bootstrap-version)
(let ((bootstrap-file
       (expand-file-name "straight/repos/straight.el/bootstrap.el" user-emacs-directory))
      (bootstrap-version 5))
  (unless (file-exists-p bootstrap-file)
    (with-current-buffer
        (url-retrieve-synchronously
         "https://raw.githubusercontent.com/raxod502/straight.el/develop/install.el"
         'silent 'inhibit-cookies)
      (goto-char (point-max))
      (eval-print-last-sexp)))
  (load bootstrap-file nil 'nomessage))

(straight-use-package 'esup)

This is running command-line Emacs 26.1 from Homebrew --with-cocoa --with-modules on OS X 10.11.6.
Could you provide some steps to reproduce the problem? FWIW, my own Emacs configuration uses ESUP.

Works for me in emacs 27.0.50 on GNU/Linux.
I had this problem before and I think (but I'm not sure it is the reason) it disappeared after upgrading emacs from 26.1 to 27.0.50.

I had the same issue here - I tried updating emacs as stated above but it didn't help.  In the end I noticed a that some error messages referenced my ~/.recentf file so I disabled that module and deleted the file and esup started working. YMMV.

This thread is being closed automatically by Tidier because it is labeled with "waiting on response" and has not seen any activity for 90 days. But don't worry—if you have any information that might advance the discussion, leave a comment and the thread may be reopened :)


Reduce the set of modules to build for container deliverable.

Thanks @stefannegrea for this PR to add a slim build of just the necessary components for Openshift.  I have made a couple of small changes.  @lucasponce please review the support for an openshift profile.  Moving forward we may tweak the plugin line-up, this was a first guess.

A preliminar comment.
In alerting we normally fork and we create PR from your own repo to upstream.
Let's not create branches on hawkular-alerts repo for substitute a fork/clone step.
That creates risk because you commit on upstream for a working branch instead of origin (your clone).
In gitthub things can be done in thousand of variations, and everything may be correct but let's follow this on alerting.
Thanks.

I'm not going to block this PR.
I'm going to merge but a couple of things:

Please, let's delete the working branch and next time use a fork/clone steps.
skipTests should not go on profile, if this profile is needed in travis or similar simply adding at command line has the same effect, skipping tests on profiles increase the risk of lack testing coverage.
Thanks @stefannegrea.

In alerting we normally fork and we create PR from your own repo to upstream.

+1, I meant to mention that to @stefannegrea, please just use your own forked repo for PR branches in the future.

In general, I am against adding a skipTests inside a profile.

Certainly a good thing to not have that in general.  I'm guessing in this packaging profile that the reason is to avoid pulling in and therefore productizing test deps.   I'm thinking this may be standard practice for this sort of thing, but @stefannegrea should verify.

@lucasponce, I will follow your fork convention for future PRs.
Regarding skipTests, skipping tests is a requirement because the build is done in a bare build environment with no network access. Plus, we want to avoid anything test related (compiling tests, pulling in test dependencies, or attempting to run tests). I would not have done this for any other profiles, but this is the default mode for productization.


do not merge /Quick change everything

Why?
Linking.canOpenURL returns a promise - binding will not wait for it to complete before assigning the URL to the link (ending up with 'undefined' links). This avoids that issue by calculating the URL when the button is clicked and calling it directly from there.

That's a good point about Linking.canOpenUrl() not resolving immediately - nice catch!
I'm confident your solution will work; perhaps you'd like to consider the following solution too however, which takes a slightly different approach to where Linking.canOpenUrl() is called.

Start from original react-native-autolink lib.
Replace the call to Linking.openUrl() in the onPress callback with an adaptation of what you have currently:

Linking.canOpenURL(url).then(supported => {
    if (!supported) {
        // this.getFallbackUrl is like this.getUrl but has a different switch statement, that uses
        // fallback https:// scheme for all link types (twitter, instagram, etc)
        Linking.openURL(this.getFallbackUrl(match));
    } else {
        Linking.openURL(url);
    }
});

A benefit of the approach is that you will be adding functionality to the AutoLink component (while leaving getUrl() untouched), which may help if we'd like to submit a PR to the upstream project.


 All four threads are sleeping, presumably waiting on the same lock. It smells like a race condition. What are the conditions gcpp is waiting for?
Error message
An example of a stuck gcpp:
strace shows gcpp process in a futex lock:
$ sudo strace -p 50665
Process 50665 attached
futex(0x7ffdcf5e515c, FUTEX_WAIT_PRIVATE, 6, NULL

All threads are in a sleeping state:
54625 10:06:22 - gcpp --algorithm=arrow -x 5 -X 120 -q 0 -j 1 -r ../../../quiver-split/refs/000006F/ref.fa aln-000006F.bam -o cns.fasta,cns.fastq,cns.vcf
    - 00:00:30 S -
    - 00:00:00 S -
    - 10:05:50 S -
    - 00:00:00 S -

The logs for this job have not been updated in over two days:
$ pwd
/home/mmetzger/MELC-2E11/4-polish/quiver-run/000006F
$ ll
total 1228
drwxrwxr-x    3 mmetzger mmetzger    4096 Nov  8 11:47 ./
drwxrwxr-x 3064 mmetzger mmetzger   69632 Nov 10 21:00 ../
-rwxrwxr-x    1 mmetzger mmetzger     244 Nov  8 11:47 run-P9805140e6da041.bash*
-rw-rw-r--    1 mmetzger mmetzger 1136209 Nov  8 22:10 run-P9805140e6da041.bash.stderr
-rw-rw-r--    1 mmetzger mmetzger    4291 Nov  8 11:47 run-P9805140e6da041.bash.stdout
-rw-rw-r--    1 mmetzger mmetzger     187 Nov  8 11:47 run.sh
-rw-rw-r--    1 mmetzger mmetzger     355 Nov  8 11:47 task.json
-rw-rw-r--    1 mmetzger mmetzger     569 Nov  8 11:47 task.sh
-rw-rw-r--    1 mmetzger mmetzger     251 Nov  8 11:47 template.sh
drwxrwxr-x    2 mmetzger mmetzger    4096 Nov  8 11:49 uow-00/
-rw-rw-r--    1 mmetzger mmetzger     324 Nov  8 11:47 user_script.sh
$ date
Mon Nov 11 11:26:07 PST 2019

The logs show we are only halfway done with the job
$ tail run-P9805140e6da041.bash.stderr
>|> 20191109 06:09:29.492 -|- INFO       -|- AddResult -|- 0x7f1ad0bb2700|| -|- Processed window [3578500,3579000) (3579000/6925811 bases of contig '000006F')
>|> 20191109 06:09:37.623 -|- INFO       -|- AddResult -|- 0x7f1ad0bb2700|| -|- Processed window [3579000,3579500) (3579500/6925811 bases of contig '000006F')
>|> 20191109 06:09:45.107 -|- INFO       -|- AddResult -|- 0x7f1ad0bb2700|| -|- Processed window [3579500,3580000) (3580000/6925811 bases of contig '000006F')
>|> 20191109 06:09:52.937 -|- INFO       -|- AddResult -|- 0x7f1ad0bb2700|| -|- Processed window [3580000,3580500) (3580500/6925811 bases of contig '000006F')
>|> 20191109 06:10:00.856 -|- INFO       -|- AddResult -|- 0x7f1ad0bb2700|| -|- Processed window [3580500,3581000) (3581000/6925811 bases of contig '000006F')
>|> 20191109 06:10:08.462 -|- INFO       -|- AddResult -|- 0x7f1ad0bb2700|| -|- Processed window [3581000,3581500) (3581500/6925811 bases of contig '000006F')
>|> 20191109 06:10:15.633 -|- INFO       -|- AddResult -|- 0x7f1ad0bb2700|| -|- Processed window [3581500,3582000) (3582000/6925811 bases of contig '000006F')
>|> 20191109 06:10:22.417 -|- INFO       -|- AddResult -|- 0x7f1ad0bb2700|| -|- Processed window [3582000,3582500) (3582500/6925811 bases of contig '000006F')
>|> 20191109 06:10:29.348 -|- INFO       -|- AddResult -|- 0x7f1ad0bb2700|| -|- Processed window [3582500,3583000) (3583000/6925811 bases of contig '000006F')
>|> 20191109 06:10:36.595 -|- INFO       -|- AddResult -|- 0x7f1ad0bb2700|| -|- Processed window [3583000,3583500) (3583500/6925811 bases of contig '000006F')
$ tail run-P9805140e6da041.bash.stdout
Mir
/home/mmetzger/MELC-2E11/4-polish/quiver-run/000006F
Fri Nov  8 11:47:07 PST 2019
Mir
/home/mmetzger/MELC-2E11/4-polish/quiver-run/000006F/uow-00
Fri Nov  8 11:47:07 PST 2019
Mir
Fri Nov  8 11:47:07 PST 2019
VC_IGNORE_ERROR='0'
USE_BLASR='0'

To Reproduce
As far as we can tell it is random, but we consistenly see it during the 4-polish phase. The problem is non-deterministic; we can successfully complete the job running it manually but that does not recreate the failure condition.
Expected behavior
We expect gcpp to return with or without error.

(see also #225)
It must be repeatable somehow. Maybe try running manually on the same system where it hangs, which as similar an environment as possible.

Somewhere from 1-10 gcpp chucks get stuck each time we run this over the last month. Different chucks each time. There were more that were stuck when using more system resources (1 when using 10% of threads, 10 when using all threads).
When the gcpp processes are stuck I can manually run the exact gcpp command in the same environment as the stuck run and it will run. But the whole FALCON-unzip process doesn’t pick back up. I don’t know how to manually type in the entire rest of the commands for the polish phase into the command line.
Do you know how to wake up these processes? Alternatively, I can manually run the stalled processes, but then I need to find out how to tell FALCON-unzip that it was done and it can continue.

Success!
It was able to run successfully when the section for the polish step in the fc_unzip.cfg file was modified to have a lower memory per job. There may be something about system resource conflicts that led to the stalling, and then some loop in the programming made it so that it could never recover even with full system resources available.
The final configuration that worked used about 50% of total server threads, and 50% of total memory, with no other significant programs running. Lower memory use-per-job (12800) did not seem to slow the running of the polish step down very much, with the added benefit that it finished without stalling.


[ACCSEC-19204] logging documentation

Jira Ticket

ACCSEC-19204

Description

Document exposed classes for logging
Add an explanation to the README of how to use logging

          1 Warning

:warning:
The Pull Request summary does not contain the commit message convention

  Generated by :no_entry_sign: Danger

          1 Warning

:warning:
The Pull Request summary does not contain the commit message convention

  Generated by :no_entry_sign: Danger

          1 Warning

:warning:
The Pull Request summary does not contain the commit message convention

  Generated by :no_entry_sign: Danger


Xcode 12 updates.

@LaurentiuUngur
Thank you for PR.
But, you can't change versions.
So please undo these changes, and create new PR (with clean commits).

@krimpedance Thanks, I will. What is the minimum iOS version it should support ? iOS 9 and 10 I think it's too old

@LaurentiuUngur
Some apps have to support older versions, so you shouldn't change that.

If dropping very old iOS versions is not allowed, then there's no point in creating another PR.


Allow custom local address resolvers.

Commit Message:
Additional Description:
#27881 introduces the concept of EDS clusters with hosts that have multiple (potentially > 2) IP addresses.
The current implementation of UpstreamLocalAddressSelector limits the number of source addresses in BindConfig artificially to 2, and further requires that the addresses be of different address families.
The workaround for this (if we need to specify more than 2 source addresses or have multiple addresses from the same family) is to use a custom address resolver that resolves the bind config address to nullptr (and therefore ignore it) and call bind in a customised SocketInterfaceImpl to a local source address determined by the SocketInterfaceImpl specialisation.
This PR makes it possible to define a custom local address selector, that makes it easy to work with a custom address resolver to pick the right source address based on the upstream address selected by HappyEyeballsConnectionImpl
Risk Level: Low
Testing: Added test.
Docs Changes: Yes
Release Notes: Yes
Platform Specific Features: N/A

/retest

/assign @adisuissa

This PR makes it possible to define a custom local address selector, that makes it easy to work with a custom address resolver to pick the right source address based on the upstream address selected by HappyEyeballsConnectionImpl

If we have multiple addresses for the same family, then what criteria are used to select source address from those same family addresses?

This PR makes it possible to define a custom local address selector, that makes it easy to work with a custom address resolver to pick the right source address based on the upstream address selected by HappyEyeballsConnectionImpl

If we have multiple addresses for the same family, then what criteria are used to select source address from those same family addresses?

We have use cases where-in the source address selection is to be done based on the subnet of the selected IP address of the upstream. This PR leaves the selection criteria of the source address up to the extension implementation.

/retest

Looks like @adisuissa forgot to tag this one
/wait

/retest

/retest

/retest

please hold off pushing CI for the next few hours while we push through CVE related patch releases, thanks

please hold off pushing CI for the next few hours while we push through CVE related patch releases, thanks

Apologies. I missed the slack message.

np, kicked CI - ill announce shortly - still have a few release runs to get through

/retest

@soulxu and @adisuissa could you please take another look?

General LGTM, last few comments

Thanks! Overall LGTM, modulo small nits. Please add an integration test for this feature.
/assign-from @envoyproxy/senior-maintainers

Hi Adi, thanks so much for reviewing again. I have a added a test point where I create a custom upstream local address selector (see StaticClusterImplTest.CustomUpstreamLocalAddressSelector in test/common/upstream/upstream_impl_test.cc. Is there something else/more that you would like to see tested?

Thanks! Overall LGTM, modulo small nits. Please add an integration test for this feature.
/assign-from @envoyproxy/senior-maintainers

Hi Adi, thanks so much for reviewing again. I have a added a test point where I create a custom upstream local address selector (see StaticClusterImplTest.CustomUpstreamLocalAddressSelector in test/common/upstream/upstream_impl_test.cc. Is there something else/more that you would like to see tested?

This is a unit-test, no?
It will be beneficial to add an integration-test, to ensure that the feature works as intended in an end-to-end fashion.

/retest

Thanks! Overall LGTM, modulo small nits. Please add an integration test for this feature.
/assign-from @envoyproxy/senior-maintainers

Hi Adi, thanks so much for reviewing again. I have a added a test point where I create a custom upstream local address selector (see StaticClusterImplTest.CustomUpstreamLocalAddressSelector in test/common/upstream/upstream_impl_test.cc. Is there something else/more that you would like to see tested?

This is a unit-test, no? It will be beneficial to add an integration-test, to ensure that the feature works as intended in an end-to-end fashion.

Hi Adi, I've added an integration test. Could you please take a look?

Looks like @adisuissa is OOO. @lizan as the assigned Sr Maintainer can you review, please.

/retest

/retest

/retest

/retest

@pradeepcrao please resolve merge conmflict. LGTM otherwise

/wait

LGTM, thanks!
@pradeepcrao it seems need a main merge.

/retest

@pradeepcrao the failure in the mobile_compile_time_options / cc_test_no_yaml test is real. @RyanTheOptimist can you help resolve this error please?
/wait

/retest

/wait

/retest

After this PR, I'm getting an error launching my standard instances. Any ideas on what is going on here? A config change required?
[2023-09-08 09:27:09.517][12285440][critical][main] [source/server/server.cc:134] error initializing config '  sync-service-envoy-v3.json': Didn't find a registered implementation for '' with type URL: 'envoy.config.upstream.local_address_selector.v3.DefaultLocalAddressSelector'
[2023-09-08 09:27:09.517][12285440][info][main] [source/server/server.cc:988] exiting
Didn't find a registered implementation for '' with type URL: 'envoy.config.upstream.local_address_selector.v3.DefaultLocalAddressSelector'

After this PR, I'm getting an error launching my standard instances. Any ideas on what is going on here? A config change required? /cc @pradeepcrao
[2023-09-08 09:27:09.517][12285440][critical][main] [source/server/server.cc:134] error initializing config '  sync-service-envoy-v3.json': Didn't find a registered implementation for '' with type URL: 'envoy.config.upstream.local_address_selector.v3.DefaultLocalAddressSelector'
[2023-09-08 09:27:09.517][12285440][info][main] [source/server/server.cc:988] exiting
Didn't find a registered implementation for '' with type URL: 'envoy.config.upstream.local_address_selector.v3.DefaultLocalAddressSelector'

You should not need a config change. What is sync-service-envoy-v3.json?

After this PR, I'm getting an error launching my standard instances. Any ideas on what is going on here? A config change required? /cc @pradeepcrao
[2023-09-08 09:27:09.517][12285440][critical][main] [source/server/server.cc:134] error initializing config '  sync-service-envoy-v3.json': Didn't find a registered implementation for '' with type URL: 'envoy.config.upstream.local_address_selector.v3.DefaultLocalAddressSelector'
[2023-09-08 09:27:09.517][12285440][info][main] [source/server/server.cc:988] exiting
Didn't find a registered implementation for '' with type URL: 'envoy.config.upstream.local_address_selector.v3.DefaultLocalAddressSelector'

You should not need a config change. What is sync-service-envoy-v3.json?

What do you use to build Envoy? Can you provide repro steps?
The only place envoy.config.upstream.local_address_selector.v3.DefaultLocalAddressSelector is used is here, https://github.com/envoyproxy/envoy/blob/main/source/common/upstream/upstream_impl.cc#L349-L354 and the factory registration is a dependency for upstream_impl.cc : https://github.com/envoyproxy/envoy/blob/main/source/common/upstream/BUILD#L396

This PR adds a core "extension" : https://github.com/envoyproxy/envoy/blob/main/source/common/upstream/default_local_address_selector_factory.cc#L72

This PR adds a core "extension" : https://github.com/envoyproxy/envoy/blob/main/source/common/upstream/default_local_address_selector_factory.cc#L72

Should this new extension be included in https://github.com/envoyproxy/envoy/commits/main/source/extensions/extensions_build_config.bzl ?

This PR adds a core "extension" : https://github.com/envoyproxy/envoy/blob/main/source/common/upstream/default_local_address_selector_factory.cc#L72

Should this new extension be included in https://github.com/envoyproxy/envoy/commits/main/source/extensions/extensions_build_config.bzl ?

It should not need to be there as it's not in source/extensions and is already a build dependency for a core target.
Can you confirm if adding it there fixes the issue for you?

I just built in a different work environment and same thing. bazel-bin/source/exe/envoy-static.stripped --config-path configs/envoyproxy_io_proxy.yaml generates the error. There must be an extension that I'm compiling out that it now required.
# See bazel/README.md for details on how this system works.
EXTENSIONS = {
    # Access loggers
    "envoy.access_loggers.file": "//source/extensions/access_loggers/file:config",
    "envoy.access_loggers.open_telemetry": "//source/extensions/access_loggers/open_telemetry:config",
    "envoy.access_loggers.stdout": "//source/extensions/access_loggers/stream:config",
    "envoy.access_loggers.stderr": "//source/extensions/access_loggers/stream:config",

    # Clusters
    "envoy.clusters.dynamic_forward_proxy": "//source/extensions/clusters/dynamic_forward_proxy:cluster",
    "envoy.clusters.logical_dns": "//source/extensions/clusters/logical_dns:logical_dns_cluster_lib",
    "envoy.clusters.static": "//source/extensions/clusters/static:static_cluster_lib",
    "envoy.clusters.strict_dns": "//source/extensions/clusters/strict_dns:strict_dns_cluster_lib",

    # Compression
    "envoy.compression.brotli.compressor": "//source/extensions/compression/brotli/compressor:config",
    "envoy.compression.brotli.decompressor": "//source/extensions/compression/brotli/decompressor:config",
    "envoy.compression.gzip.compressor": "//source/extensions/compression/gzip/compressor:config",
    "envoy.compression.gzip.decompressor": "//source/extensions/compression/gzip/decompressor:config",

    # Health checkers
    "envoy.health_checkers.tcp": "//source/extensions/health_checkers/tcp:health_checker_lib",
    "envoy.health_checkers.http": "//source/extensions/health_checkers/http:health_checker_lib",
    "envoy.health_checkers.grpc": "//source/extensions/health_checkers/grpc:health_checker_lib",

    # HTTP filters
    "envoy.filters.http.alternate_protocols_cache": "//source/extensions/filters/http/alternate_protocols_cache:config",
    "envoy.filters.http.buffer": "//source/extensions/filters/http/buffer:config",
    "envoy.filters.http.cache": "//source/extensions/filters/http/cache:config",
    "envoy.filters.http.compressor": "//source/extensions/filters/http/compressor:config",
    "envoy.filters.http.cors": "//source/extensions/filters/http/cors:config",
    "envoy.filters.http.csrf": "//source/extensions/filters/http/csrf:config",
    "envoy.filters.http.decompressor": "//source/extensions/filters/http/decompressor:config",
    "envoy.filters.http.dynamic_forward_proxy": "//source/extensions/filters/http/dynamic_forward_proxy:config",
    "envoy.filters.http.ext_authz": "//source/extensions/filters/http/ext_authz:config",
    "envoy.filters.http.health_check": "//source/extensions/filters/http/health_check:config",
    "envoy.filters.http.jwt_authn": "//source/extensions/filters/http/jwt_authn:config",
    "envoy.filters.http.local_ratelimit": "//source/extensions/filters/http/local_ratelimit:config",
    "envoy.filters.http.oauth2": "//source/extensions/filters/http/oauth2:config",
    "envoy.filters.http.original_src": "//source/extensions/filters/http/original_src:config",
    "envoy.filters.http.ratelimit": "//source/extensions/filters/http/ratelimit:config",
    "envoy.filters.http.rbac": "//source/extensions/filters/http/rbac:config",
    "envoy.filters.http.router": "//source/extensions/filters/http/router:config",

    # Listener filters
    "envoy.filters.listener.http_inspector": "//source/extensions/filters/listener/http_inspector:config",
    # NOTE: The original_dst filter is implicitly loaded if original_dst functionality is
    #       configured on the listener. Do not remove it in that case or configs will fail to load.
    "envoy.filters.listener.original_dst": "//source/extensions/filters/listener/original_dst:config",
    "envoy.filters.listener.original_src": "//source/extensions/filters/listener/original_src:config",
    # NOTE: The proxy_protocol filter is implicitly loaded if proxy_protocol functionality is
    #       configured on the listener. Do not remove it in that case or configs will fail to load.
    "envoy.filters.listener.proxy_protocol": "//source/extensions/filters/listener/proxy_protocol:config",
    "envoy.filters.listener.tls_inspector": "//source/extensions/filters/listener/tls_inspector:config",

    # Network filters
    "envoy.filters.network.direct_response": "//source/extensions/filters/network/direct_response:config",
    "envoy.filters.network.ext_authz": "//source/extensions/filters/network/ext_authz:config",
    "envoy.filters.network.http_connection_manager": "//source/extensions/filters/network/http_connection_manager:config",
    "envoy.filters.network.local_ratelimit": "//source/extensions/filters/network/local_ratelimit:config",
    "envoy.filters.network.ratelimit": "//source/extensions/filters/network/ratelimit:config",
    "envoy.filters.network.rbac": "//source/extensions/filters/network/rbac:config",
    "envoy.filters.network.sni_dynamic_forward_proxy": "//source/extensions/filters/network/sni_dynamic_forward_proxy:config",
    "envoy.filters.network.tcp_proxy": "//source/extensions/filters/network/tcp_proxy:config",

    # UDP filters
    "envoy.filters.udp_listener.udp_proxy": "//source/extensions/filters/udp/udp_proxy:config",

    # Stat sinks
    "envoy.stat_sinks.open_telemetry": "//source/extensions/stat_sinks/open_telemetry:config",
    "envoy.stat_sinks.statsd": "//source/extensions/stat_sinks/statsd:config",

    # Tracers
    "envoy.tracers.opentelemetry": "//source/extensions/tracers/opentelemetry:config",

    # Transport sockets
    "envoy.transport_sockets.raw_buffer": "//source/extensions/transport_sockets/raw_buffer:config",
    "envoy.transport_sockets.tcp_stats": "//source/extensions/transport_sockets/tcp_stats:config",
    "envoy.transport_sockets.internal_upstream": "//source/extensions/transport_sockets/internal_upstream:config",
    "envoy.transport_sockets.upstream_proxy_protocol": "//source/extensions/transport_sockets/proxy_protocol:upstream_config",

    # CacheFilter plugins
    "envoy.extensions.http.cache.file_system_http_cache": "//source/extensions/http/cache/file_system_http_cache:config",
    "envoy.extensions.http.cache.simple": "//source/extensions/http/cache/simple_http_cache:config",

    # Http Upstreams (excepting envoy.upstreams.http.generic which is hard-coded into the build so not registered here)
    "envoy.upstreams.http.http": "//source/extensions/upstreams/http/http:config",
    "envoy.upstreams.http.tcp": "//source/extensions/upstreams/http/tcp:config",
    "envoy.upstreams.http.udp": "//source/extensions/upstreams/http/udp:config",
    # "envoy.upstream.local_address_selector": "//source/extensions/upstream:default_local_address_selector_factory",

    # IO socket
    "envoy.io_socket.user_space": "//source/extensions/io_socket/user_space:config",
    "envoy.bootstrap.internal_listener": "//source/extensions/bootstrap/internal_listener:config",

    # QUIC extensions
    "envoy.quic.deterministic_connection_id_generator": "//source/extensions/quic/connection_id_generator:envoy_deterministic_connection_id_generator_config",
    "envoy.quic.crypto_stream.server.quiche": "//source/extensions/quic/crypto_stream:envoy_quic_default_crypto_server_stream",
    "envoy.quic.proof_source.filter_chain": "//source/extensions/quic/proof_source:envoy_quic_default_proof_source",
    "envoy.quic.server_preferred_address.fixed": "//source/extensions/quic/server_preferred_address:fixed_server_preferred_address_config_factory_config",

    # UDP packet writers
    "envoy.udp_packet_writer.default": "//source/extensions/udp_packet_writer/default:config",
    "envoy.udp_packet_writer.gso": "//source/extensions/udp_packet_writer/gso:config",

    # Key value store
    "envoy.key_value.file_based": "//source/extensions/key_value/file_based:config_lib",

    # RBAC matchers
    "envoy.rbac.matchers.upstream_ip_port": "//source/extensions/filters/common/rbac/matchers:upstream_ip_port_lib",

    # DNS Resolver
    # c-ares DNS resolver extension is recommended to be enabled to maintain the legacy DNS resolving behavior.
    "envoy.network.dns_resolver.cares": "//source/extensions/network/dns_resolver/cares:config",
    # apple DNS resolver extension is only needed in MacOS build plus one want to use apple library for DNS resolving.
    "envoy.network.dns_resolver.apple": "//source/extensions/network/dns_resolver/apple:config",

    # Header Validators
    "envoy.http.header_validators.envoy_default": "//source/extensions/http/header_validators/envoy_default:config",

    # Early Data option
    "envoy.route.early_data_policy.default": "//source/extensions/early_data:default_early_data_policy_lib",
}

# These can be changed to ["//visibility:public"], for  downstream builds which
# need to directly reference Envoy extensions.
EXTENSION_CONFIG_VISIBILITY = ["//:extension_config", "//:contrib_library", "//:examples_library", "//:mobile_library"]
EXTENSION_PACKAGE_VISIBILITY = ["//:extension_library", "//:contrib_library", "//:examples_library", "//:mobile_library"]
CONTRIB_EXTENSION_PACKAGE_VISIBILITY = ["//:contrib_library"]
MOBILE_PACKAGE_VISIBILITY = ["//:mobile_library"]

# Set this variable to true to disable alwayslink for envoy_cc_library.
# TODO(alyssawilk) audit uses of this in source/ and migrate all libraries to extensions.
LEGACY_ALWAYSLINK = 1

I'm unblocked for now going back to the commit before this one with git checkout 2cb9401202cc1fb6ac7c33317c7197754462da46 in case anyone else is affected

@pradeepcrao I've worked it out. If you have build --define library_autolink=disabled defined in a custom .bazelrc the resulting binary won't run any config with the error above being produced


[SP-4599] - Backport of PDI-16074 - "Load file content in memory" ste…

…p does not output additional filename field

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f ui/build.xml clean-all resolve jacoco && ant -f ui/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  ui/src/org/pentaho/di/ui/trans/steps/loadfileinput/LoadFileInputDialog.java

You were right @cravobranco, just updated a new PR

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
ant -Dtestreports.dir=bin/reports/unit-test -f ui/build.xml clean-all resolve jacoco && ant -f ui/build.xml checkstyle publish-local

Cleanup Commands
rm -r ~/.ivy2/local || echo no publish local to remove

Changed files
  ui/src/org/pentaho/di/ui/trans/steps/loadfileinput/LoadFileInputDialog.java


cat flights-Apr2014.csv | ./mapper.py | sort | ./reducer.py > output.txt

Hi Benjamin,
Trying to follow the video where the following command was used:
cat flights-Apr2014.csv | ./mapper.py | sort | ./reducer.py > output.txt
Is it accurate that we should use the file from the github path data/flight_data.zip, file name ontime_flights.tsv? Not sure if tsv and csv file format is the cause for the error encountered.
Currently getting the error message :
IndexError: list index out of range
File "./mapper.py", line 20, in map
self.emit(row[14], row[31])
Can point out which mapper.py file and which input file (csv or tsv) should we use? :)

Hi @doremoteph7 perhaps try the CSV file in data/ontime.zip? I think this is the dataset that was used in the avgdelay code snippets.


Missing documentation on performing CRUD operations using Xrm.WebApi.online.execute or Xrm.WebApi.online.executeMultiple

Hello
I have a requirement to bulk update more than 500 opportunity products i used the simple Xrm.WebApi.updateRecord request in a loop but it appears that it takes too much time to finish i found in msdn documentation Xrm.WebApi.online.executeMultiple requst and i really need to use it but the problem i can't find any example or documentation on how to perform crud operation. can you please publish a some simple examples on crud operation

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 560b6655-dab7-f77a-ac70-ef0274ada48c
Version Independent ID: b2f7adea-c6fd-a46f-23c0-d5ac3cd1f955
Content: Xrm.WebApi.online.execute (Client API reference) in Dynamics 365 Customer Engagement
Content Source: ce/developer/clientapi/reference/Xrm-WebApi/online/execute.md
Service: crm-online
GitHub Login: @KumarVivek
Microsoft Alias: kvivek

Request a documentation here please for the benefit of consultants in using this API for CRUD operations. I have found out a way here and documented for the benefit of the community - https://debajmecrm.com/2019/02/11/crud-operations-using-executemultiple-in-dynamics-365/. But since so many follow Microsoft Docs, an updated documentation with proper examples is hugely appreciated.

What abount sample code on how to execute a bound actions?


getting different offset when running Phenotagger example file

I ran PhenoTagger_tagging.py on the example/input/ex.BioC.XML file. The output is similar to the example/output/ex.BioC.XML file, but the offset of the annotations is shifted by 114 characters, see screenshot below. Why is that happening?

The original output ignored the previous text. For example, the extracted concept "schizophrenia" 's offset is 344, it is the offset of the current sentence. In fact, current sentence's begin offset is 114, so its exact offset in the documment should be 344+114=458. The new output fixs the bug. Please ignore the original output example. I will update it.


Question: WW Monks and Storm,Earth, and Fire

More a question to see if there is a possible fix for this 1 spell that causes issues with being able to castsequence this one spell. It's also broken in wow's own macro system so i think the answer is no.
/cast Storm, Earth, and Fire is usable in wow's macro system as well as GSE.
Trying to use it in a /castsequence seems to break it because a sequence is normally broken up by , (comma's) which the spell uses so the sequence see's this as multiple spells.
Is there some kind of magic that can be done to fool the client to ignore the additional comma's on this one spell?
Statics.BaseSpellTable[152173] = 137639 -- Serenity -> Storm, Earth and Fire << also in statics, i am not sure if this is important but would the macro break on the line for missing the comma after Earth or would it be ignored by using the spellid?

Cant use SEF in a /castsequence  No way GSE can work around that.


added support for sluggable umlauts/accents

Fixes #1065

this is a backward compatibility break and a nasty one because it cannot be noticed easily. this change cannot be merged. What I suggest you to do is to use custom transliteration function:
$sluggableListener->setTransliterator(['YourStaticTransliteratorClass', 'staticTranslaterationMethod']);

Or with symfony dependency injection
services:
    gedmo.listener.sluggable:
        class: Gedmo\Sluggable\SluggableListener
        tags:
            - { name: doctrine.event_subscriber, connection: default }
        calls:
            - [ setAnnotationReader, [ "@annotation_reader" ] ]
            - [ setTransliterator, [["YourStaticTransliteratorClass", "staticTranslaterationMethod"]]]

Hello, and thank you for your contribution.
In the interest of spring cleaning and package modernization, I'm going through and closing old issues and pull requests that have had no recent activity, do not have associated tests, or have failing tests.
If you are still experiencing this issue or wish to contribute an up-to-date pull request, please create a new issue.
Thank you!


Propagate "row limit reached" warning on dashboard

Is your feature request related to a problem? Please describe.
Situation:

I have dashboards with tables with row limits.
End-users are querying data large enough to hit row limits.

Problem: the data is truncated silently -- the end-user has no idea that their data is not accurate.
Describe the solution you'd like
Chart view has a clear warning that a row limit is reached. Propagate this up to the dashboard view.
Describe alternatives you've considered
None.

NOTE: reaching the row limit isn't always an issue or relevant information, it depends on the type of visualization and the intent/expectations of the person assembling the viz or dashboard.


chore: bdd-gh-1586070320 to 0.0.1

chore: Promote bdd-gh-1586070320 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[FEATURE REQUEST] custom location feature

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The author is very big, I don’t know how to add a function to find content in a custom location, for example: h5-moible, h5-app, h5-login, among them, moible, app, and login need to scan in a custom location.

Good morning!
could you provide an example of your custom location?
I'm not entirely sure what you're asking for

Good morning!
could you provide an example of your custom location?
I'm not entirely sure what you're asking for

Similar to fuff, the location to be scanned is replaced by the fuzz keyword

ahh, gotcha. That's not currently supported. Also, we're already tracking that feature in #242. Closing this as a duplicate.
Thank you for taking the time to put this in!


Definition of cutoff

Another beginner question. Regarding the cutoff as displayed in the model evaluations: how exactly is it defined. I searched the documentation, but couldn't find a clear definition - I guess it's a term data scientists know by heart and I'm just too newbie to know it. ;)
Could anyone help out a with a definition (which we could maybe also include in the documentation)?

I just stumbled on a definition of cutoff in the documentation of the util function precision_recall_by_user (btw, the definitions of precision and recall in the documentation of this function are just duplicates):
If I get this right, then it is the number of recommendations that have been made for a user. So applied to the precision-recall tables: does that mean that when evaluating the model the validator iterates over the validation data and makes k (cutoff, with k in [1,10]) recommendations for all the users and then calculates precision-recall based on the hit ratios?

Thanks @ubuntudroid, that's good feedback. @hoytak, does the definition given by @ubuntudroid above sound correct for cutoff?
We should use this issue to track updating the API docs and user guide to provide a clear definition of cutoff.

If I am understanding this correctly, the precision and recall in the table are the same as precision@k and recall@k. @ubuntudroid, so I think you are basically on point.  Here's a detailed explanation of calculation

Yes, it's precision@k and recall@k, where k is the cutoff.