Sessions not being cleaned up correctly when tests end

Unless the session is explicitly "ended" when the test ends the sessions in phantom are being left open. I discovered this when my phoenix server started receiving duplicate messages from 2 browsers. What was happening is that the first test ran, connected to the channel, and executed the test. When the test ended the phantom was being checked back in but the session wasn't being deleted from the phantom. You normally wouldn't see this sort of issue. It only cropped up because we drive several user actions from external devices and those devices broadcast their data over a separate phoenix channel to all connected clients (which in practice is only ever 1 client).
You can fix this issue by explicitly calling Wallaby.end_session(session) in your setup block like this:
setup %{session: session} do
  on_exit fn ->
    Wallaby.end_session(session)
  end
end

But, we should account for this in Wallaby so the end user doesn't have to care about these things. My initial thinking is that we can set up a monitor or a link to the calling process when it checks out a wallaby session. Then when we detect a DOWN signal from the process we can clean up the session ourselves. We'll also need to handle the case where we get a down signal but the user has manually checked in the process.

I'm getting some strange behavior /w Wallaby and PhantomJS, and wondering if it is related to this issue.
After running my tests (even if I've excluded all feature tests), I see the following output in the console:
Finished in 0.1 seconds
1 test, 0 failures

Randomized with seed 100114
/bin/sh: line 10:  4732 Killed: 9               "$@"    <---------- This only shows up after Wallaby installed

And then after the test suite has exited, I end up with a pile of phantomJS processes still running:
$ ps aux ....

brandon           5047   0.0  0.3  3674612  43052   ??  S    11:16AM   0:19.34 /Users/brandon/.nvm/versions/node/v6.9.1/lib/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs --webdriver=49414 --local-storage-path=/var/folders/4h/4f2vml1952g4brhb9f9y65wr0000gn/T/tva1ml
brandon           5046   0.0  0.3  3674128  43636   ??  S    11:16AM   0:19.34 /Users/brandon/.nvm/versions/node/v6.9.1/lib/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs --webdriver=49412 --local-storage-path=/var/folders/4h/4f2vml1952g4brhb9f9y65wr0000gn/T/1l1hl82
brandon           5044   0.0  0.3  3677684  43364   ??  S    11:16AM   0:19.30 /Users/brandon/.nvm/versions/node/v6.9.1/lib/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs --webdriver=49416 --local-storage-path=/var/folders/4h/4f2vml1952g4brhb9f9y65wr0000gn/T/1k05fkk
brandon           5045   0.0  0.3  3675660  43648   ??  U    11:16AM   0:19.31 /Users/brandon/.nvm/versions/node/v6.9.1/lib/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs --webdriver=49409 --local-storage-path=/var/folders/4h/4f2vml1952g4brhb9f9y65wr0000gn/T/a8txx8
brandon           5043   0.0  0.3  3675676  44048   ??  S    11:16AM   0:19.31 /Users/brandon/.nvm/versions/node/v6.9.1/lib/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs --webdriver=49411 --local-storage-path=/var/folders/4h/4f2vml1952g4brhb9f9y65wr0000gn/T/1atb2sx
brandon           5042   0.0  0.3  3674612  43920   ??  U    11:16AM   0:19.31 /Users/brandon/.nvm/versions/node/v6.9.1/lib/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs --webdriver=49415 --local-storage-path=/var/folders/4h/4f2vml1952g4brhb9f9y65wr0000gn/T/1ghbgxd
brandon           5041   0.0  0.3  3675636  43636   ??  S    11:16AM   0:19.35 /Users/brandon/.nvm/versions/node/v6.9.1/lib/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs --webdriver=49413 --local-storage-path=/var/folders/4h/4f2vml1952g4brhb9f9y65wr0000gn/T/hrfuh8
brandon           5040   0.0  0.3  3676160  44132   ??  S    11:16AM   0:19.33 /Users/brandon/.nvm/versions/node/v6.9.1/lib/node_modules/phantomjs-prebuilt/lib/phantom/bin/phantomjs --webdriver=49410 --local-storage-path=/var/folders/4h/4f2vml1952g4brhb9f9y65wr0000gn/T/n3svmz

Every time my tests run, these processes multiply, until my computer dies. I have to run a killall phantomjs to make this all work out.
I've tried throwing this into my feature case (as per above):
  # https://github.com/keathley/wallaby/issues/174
  setup %{session: session} do
    on_exit fn ->
      Wallaby.end_session(session)
    end
  end

But this doesn't seem to help. Any hints?

@brandonparsons was this happening using master? Or the most recent release? Did the version of phantom change when you installed it through brew?

@keathley I was using the most recent release of wallaby (not master).
To be honest I'm not sure if the version of phantomjs changed. I could have a peek when I'm back on that computer and check if it helps.

Closing sessions automatically when tests end has been merged and released.


Updated w-table doucmentation to note the 'headers.sortable' property

This property already exists on the component but the documentation was lacking it in the API reference.

 Using branches now. New pull request here


feat: upload vulnerabilities to dashboard

As title says. Related to vulnerability tasks.

Currently being used in https://github.com/ansys/pyansys-geometry/pull/1071


Disclaimer for ESAS

We need a disclaimer proposal for ESAS.
The current one was adapted from another dataset.

A disclaimer text was proposed in the Google doc. Should I copy it here?

We should put the file here and I will copy that to the website.

Here is the link with the review of the ESAS website pages:
https://docs.google.com/document/d/1JaDbchwtM5Z9E84ICkxpZKEJCv7mGes9lJMgXXx_Wpg/edit#heading=h.lnwz9o48dby9
Nicolas Vanermen
Instituut voor Natuur- en Bosonderzoek
(Research Institute for Nature and Forest)
Havenlaan 88, bus 73, 1000 Brussel
+32 486 361 582
On Tue, May 10, 2022 at 10:02 AM Carlos Manuel Silva Pinto <
@.***> wrote:

@peterdesmet https://github.com/peterdesmet: Where is the disclaimer?
We can only find the home page in google docs.
[image: image]
https://user-images.githubusercontent.com/8705477/167579350-ad49e1e9-f65b-48df-b565-f8f3a6110b4a.png
—
Reply to this email directly, view it on GitHub
https://github.com/ices-tools-dev/esas/issues/80#issuecomment-1122060498,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABYKGXJSXONHGBC3JXC34LTVJIJZTANCNFSM5UONSEFA
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

This is the text for the disclaimer:

Please acknowledge the following conditions before downloading data:

All public data are licensed under the Creative Commons (CC BY 4.0) license.
You have sole responsibility for correct and appropriate data interpretation.
Results, conclusions, and/or recommendations derived from the data do not imply endorsement from ICES.
You are requested to inform ICES of any suspected problems in the data.
Derived data products are based on public and restricted data.

The full ICES data policy and terms of use can be viewed here.
Restricted Data
Some data in the European Seabirds At Sea (ESAS) are classified as restricted by the data rights holder(s) and licensed under the ICES Biodiversity License. You can request full access to those data at the discretion of the data rights holder(s).

Note sure we have to mention the "Derived data products are based on public and restricted data.", since there aren't any derived data products yet.

standard disclaimer revised for ESAS https://github.com/ices-tools-dev/esas/blob/main/disclaimer-download

Done, have we agree to list all the data custodians or to put a reference to ESAS dateset?

I think the idea was to list the data providers:

In the ESAS metadata (in a reference system)
(Potentially) the ESAS homepage
The included ones in the disclaimer file

I assume this issue is mostly about the disclaimer file, but not that the disclaimer popup is not centered:

Done, have we agree to list all the data custodians or to put a reference to ESAS dataset?

as Peter says, the main reference would be the Full Metadata Record;

Create a metadata record for the ESAS dataset.
ICES will create a first draft of the metadata record and Nicolas or Peter can review the metadata record.

ICES European Seabirds at Sea (ESAS) Database ->  ICES European Seabirds At Sea (ESAS) database

the disclaimer is 99% ready, just missing the link to the metadata URL for the dataset

@cmspinto the URL is now included in https://github.com/ices-tools-dev/esas/blob/main/disclaimer-download
@peterdesmet the metadata record for reference:
http://gis.ices.dk/geonetwork/srv/eng/catalog.search#/metadata/7a6151e4-812b-4455-97a2-74c5102d418f

@neil-ices-dk Metadata record looks good! The spatial extend can be bigger (especially south). I think the total bounding box is:
80N,-40E -> 10N,30E

thanks @peterdesmet updated as below:

This looks nice indeed. Will we include a list of the data providers there?

good point, i forgot that - will look into how best to put them in

[ ] ICES European Seabirds at Sea (ESAS) Database -> ICES European Seabirds At Sea (ESAS) database
[ ] Hyperlink instead of full webadress
[ ] Adjust font size of text under Restricted Data

[x] ICES European Seabirds at Sea (ESAS) Database -> ICES European Seabirds At Sea (ESAS) database

@Osanna123 can you also change it in DATSU adn Reco?

[ ] Database -> database


Communication: Add virtual scrolling to communication overview page

Checklist
General

[ ] I tested all changes and their related features with all corresponding user types on a test server.
[ ] This is a small issue that I tested locally and was confirmed by another developer on a test server.
[ ] Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
[ ] I chose a title conforming to the naming conventions for pull requests.

Client

[ ] I followed the coding and design guidelines and ensured that the layout is responsive.
[ ] Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
[ ] I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
[ ] I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
[ ] I documented the TypeScript code using JSDoc style.
[ ] I added multiple screenshots/screencasts of my UI changes.
[ ] I translated all newly inserted strings into English and German.

Motivation and Context

Description

Steps for Testing

Prerequisites:

1 Instructor
2 Students
1 Programming Exercise with Complaints enabled

Log in to Artemis
Navigate to Course Administration
...

Prerequisites:

1 Instructor
2 Students
1 Exam with a Programming Exercise

Log in to Artemis
Participate in the exam as a student
Make sure that the UI of the programming exercise in the exam mode stays unchanged. You can use the exam mode documentation as reference.
...

Review Progress

Code Review

[ ] Review 1
[ ] Review 2

Manual Tests

[ ] Test 1
[ ] Test 2

Test Coverage

Class/File
Branch
Line

Screenshots

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@780fa98). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #5835   +/-   ##
==========================================
  Coverage           ?   84.56%
  Complexity         ?    12053
==========================================
  Files              ?      962
  Lines              ?    38799
  Branches           ?     4207
==========================================
  Hits               ?    32809
  Misses             ?     3688
  Partials           ?     2302

Flag
Coverage Δ

server
84.56% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


fix(close): update close--outline, close--solid

Adds in close--outline, renamed current close--outline to close--solid
Changelog
New

close--outline

Changed

renamed close--outline to close--solid

:tada: This PR is included in version 7.0.4 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Using arte.tv fetcher

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2021.12.17
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log

PASTE VERBOSE LOG HERE

Description

WRITE DESCRIPTION HERE
xxx@yyy:~$ youtube-dl https://www.arte.tv/fr/videos/107479-000-A/elle/
[ArteTV] 107479-000-A: Downloading JSON metadata
ERROR: Unable to download JSON metadata: HTTP Error 404: Not Found (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
xxx@yyy:~$ youtube-dl -U
youtube-dl is up-to-date (2021.12.17)
So what !!!

https://github.com/ytdl-org/youtube-dl/issues/30927#issuecomment-1121174218

https://github.com/ytdl-org/youtube-dl/issues/30980


CRM457-1986 - Use correct formatting for defendant details

Description of change
Link to relevant ticket
Notes for reviewer
Uses Defendant 1 (lead), Defendant 2, Defendant 3... instead of Main Defendant, Additional Defendant 1 etc

I have a feeling this stuff is checking the visible page text, not the HTML, so won't be there, but so long as this PR is open we can verify easily enough once the other one is merged.

Pretty sure you're right yeah


Add MLS Service

Summary

Adds a MLS delivery service, with a moderately thought through API spec. Subject to change, but I want to get something in to scaffold the service, even if some of the endpoints wind up changing.
Adds a few wrapper types for the message formats that will be published to the network

One idea I'd like to plant here is if we are able to make any of these endpoints less MLS-specific? For example, by introducing a generic OrderedTopic concept, or a generic SingleUseTopic?

I'm open to ordered topics. I'd like to get a better understanding of what you'd want a SingleUseTopic to do.
Even with that, I think the PublishToGroup is going to be pretty MLS-specific until we have a better commit resolution strategy. That one requires not just ordering, but also rejection of messages from past epochs so that the client can refresh their state and retry the request.

Just spitballing, a SingleUseTopic deletes payloads as they are read. An OrderedTopic requires payloads to have two fields, currentEpoch and nextEpoch, and publishes fail if currentEpoch doesn't match the current epoch. I say this with low confidence, I think you're deeper into what the actual validation logic would be than I am


v6 chatbot - Text highlighting not working properly in dark theme

Text highlighting not working properly in dark theme and also the file type (YAML in following image) can be hardly seen.

This looks related to https://github.com/patternfly/virtual-assistant/issues/114. The YAML issue isn't documented. Thanks for the heads up; we'll take a look!


Examine use of USBserial on ESP32-S3

Noted by @BrotherCreamy, using the USB as a Serial interface (like on ESP32S3 devices) does not work.
This needs to be examined and potentially fixed.

I am wondering if you could try again with the latest release?

Closing this as no answer given.


ZeroDivision error when trying simple example

I tried the following PGCL program:
nat X;
nat Y;

X := poisson(10);
Y := iid(bernoulli(0.2), X);
observe(Y = 1);
?Ex[X]
!Print

I get the following output:
[...]
  File "[redacted]/Prodigy/prodigy/distribution/generating_function.py", line 823, in normalize
    raise ZeroDivisionError
ZeroDivisionError

Am I doing something wrong?

For me this code you presented works fine and outputs
\underbrace{\frac{2XYe^{-10}e^{8 X}}{(2 - e^2)*e^{-2} + 1}}_{\text{SymPy}} = \underbrace{\frac{e^{-10+8X} \cdot Y X}{e^{-2}}}_{\text{GiNaC}}

used commit: a24203c3211e96276c5b371c3a4886a81fc62d60

Ah, I did not realize I had to use the new-update branch. (I was using main.) On the other branch, it works.


UI Interface outside the area on iPad Pro 12,9”

As you see on the screenshot the interface is outside the control area.
Tested with app ver. 5.x.x and iPad Pro 12,9”

Hey @grzegorz914
thx, already fixed in the next version, just looking for some other bugs before pushing it :)

Nice, also the camera view screen do not have correct aspect ratio.

Nice, also the camera view screen do not have correct aspect ratio.

Yes, as mentioned here https://github.com/seydx/homebridge-camera-ui/issues/124
Like the widgets on the dashboard, you can resize the camera tiles on Camview and camera.ui will store the size and positions for you in localStorage.
I will try to find another solution for this problem in a later version

@grzegorz914
like here:
https://user-images.githubusercontent.com/34152761/148979915-9c5fe1ce-613e-4eb2-8d65-550f2a9c7d5c.mov

Ah OK I see this possibility now, thanks.

@grzegorz914
Just saw it, you can add camera.ui from Safari to home screen, it looks so much better as PWA instead of a normal web page :P

Yes, I know this possibility, as a tip You can add Hyperlink to the plugin config in my screen.

In other things, are you think about add PTZ control?

Yes, ONVIF is good standard and will be nice to have this as next feature.

As you see on the screenshot the interface is outside the control area. Tested with app ver. 5.x.x and iPad Pro 12,9”

Fixed in v5.0.4

Yes, I know this possibility, as a tip You can add Hyperlink to the plugin config in main screen.

Added in v5.0.4

Updated, all working correct.

One more thing, the menu button is in background back the camera view:

One more thing, the menu button is in background back the camera view:

v5.0.5-beta.0

Yes I wanted to keep it a little transparent so that it does not disturb

I think for better experiences You need reserve som space in top area for interface control elements.

I think for better experiences You need reserve some space in top area for interface control elements.

I think I will add an "auto hide" function to hide the buttons after a certain time and show them again when tapping the screen

This is also very good idea.


表单回填的时候会破坏表单的只读状态

Help us to manage our issues by answering the following:

How would you tag this issue?

Bug

Describe your issue:

What is the current behavior?

表单回填的时候部分表单，只读状态失效

What is the expected behavior?

只读状态不会被破坏

Which versions of UForm?

"@uform/next": "^0.3.9",

Did this work in previous versions of UForm?

不清楚

If your issue is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via Bug Report Template on CodeSandbox
. https://codesandbox.io/s/dawn-cdn-rsiv8

复现步骤 点击按钮即可


OSError: microsoft/OmniParser does not appear to have a file named preprocessor_config.json.

I tried to use the model directly from the Hugging face portal.
After running code below both in Pycharm with Jupiter server and Google collab:
`# Load model directly
from transformers import AutoProcessor, AutoModelForVisualQuestionAnswering
processor = AutoProcessor.from_pretrained("microsoft/OmniParser")
model = AutoModelForVisualQuestionAnswering.from_pretrained("microsoft/OmniParser")`
I got error: OSError: microsoft/OmniParser does not appear to have a file named preprocessor_config.json. Checkout 'https://huggingface.co/microsoft/OmniParser/tree/main' for available files..
It seems I'm not the only one with this issue: https://huggingface.co/microsoft/OmniParser/discussions/20

@GustawB How did you able to run with transformers?

@berkantay My understanding is that hugging face repo is not really meant to be run with transformers. It only contains weights that needs to be downloaded in order to run the github repo. So if you want to play with the OmniParser, cloning github repo and following the tutorial seems like the only "normal" solotion to run it.

@GustawB Thank you for the clarification. I actually couldn't wait and started to play with it on a serverless GPU environment. But it could be much much simpler with the transformers anyways.


Mention already implemented commands missing from README

There were only two commands missing from the README that had been
implemented but not yet mentioned in the examples section.  This commit adds
a quick example of both so that users can be more aware of the available
functions without having to search in perl5's Shell::Command, which itself
redirects to ExtUtils::Command for a list of the implemented commands.

Replaced by better version of PR in #12.


fix: disable cloud_logs provision

Description
Currently cloud logs is not supported in most of the region, which is causing the pipeline to fail if the test runs in a region in which cloud logs is not supported.

Release required?

[ ] No release
[x] Patch release (x.x.X)
[ ] Minor release (x.X.x)
[ ] Major release (X.x.x)

Release notes content

Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
/run pipeline

Checklist for reviewers

[ ] If relevant, a test for the change is included or updated with this PR.
[ ] If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

/run pipeline

:tada: This issue has been resolved in version 3.29.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


boards: add iCEBreaker Bitsy

Add the iCEBreaker bitsy -- a relatively straightforward / smol platform. :)
https://github.com/icebreaker-fpga/icebreaker/tree/master/hardware/bitsy-v1.0a

Thanks!


Yuma

--- small fixes from singletons PR that can be merged easily into master

One minor nit, approving to unblock since it doesn't really make a difference.


Add support for async checkpointing

What does this PR do?

Fixes #11561
Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

[x] Was this discussed/approved via a GitHub issue? (not for typos and docs)
[x] Did you read the contributor guideline, Pull Request section?
[x] Did you make sure your PR does only one thing, instead of bundling different changes together?
[ ] Did you make sure to update the documentation with your changes? (if necessary)
[ ] Did you write any new necessary tests? (not for typos and docs)
[x] Did you verify new and existing tests pass locally with your changes?
[x] Did you list all the breaking changes introduced by this pull request?
[x] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

[x] Is this pull request ready for review? (if not, please submit in draft mode)
[x] Check that all items from Before submitting are resolved
[x] Make sure the title is self-explanatory and the description concisely explains the PR
[x] Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?
Make sure you had fun coding 🙃
cc @borda @awaelchli @ananthsub @ninginthecloud @rohitgr7 @otaj @akihironitta

after discussion with @carmocca
the design
class AsyncCheckpointIO(CheckpointIO):
    def __init__(self, checkpoint_io=None):
        self._checkpoint_io = checkpoint_io

    @setter
    def checkpoint_io(...):
        ...

    def save_checkpoint(self, checkpoint, filepath)
        async_launch(self._checkpoint_io.save_checkpoint, checkpoint, filepath)

and in the Trainer, the user can just pass
Trainer(plugins=[AsyncCheckpointIO()])

we will attach the appropriate checkpoint if not already attached. This will enable async checkpointing for existing plugins by providing async behavior without any code modification.

Probably worth mentioning in the docs (for now) is that ANY error raised in the thread will not be raised in the main thread.
So if you get an io error with torch.save for example, it won't be surfaced like ever.
Rabbit hole alert: A way to handle this would be to catch the exception in the function passed to the executor, and then add it to a shared variable. The main thread could then periodically check whether there was an error and raise it.

Great work @rohitgr7!!

Thanks @awaelchli @carmocca @otaj for great reviews and discussion.


Highlighting fails

Greetings,
It appears that syntax highlighting fails for portions of a .tsx file when a needed ReturnType is inserted into an arrow function. Also, when operating on a .tsx file, object destructuring fails to be syntax highlighted as it is with .jsx files.
I have previous tried disabling each plugin and re-enabling them individually with no success.
To me, it appears like adding the ReturnType causes VIM to interpret the proceeding code as a syntax error? I'm not too sure.
When it does get highlighted correctly, page-up or page-down on the module file will cause the code after the entered ReturnType to be highlighted in green (matching the highlight color of the ReturnType (eg: {(): ReactElement => { most of code in here gets highlighted green }}).
Also, syntax highlighting within objects (eg: css={{ height: "100%" }}) doesn't work at all.
Editor: Neovim v0.3.8
Colorscheme: Gruvbox
FIletype: typescript.tsx
Plugins (for TypeScript/JavaScript):

yuezk/vim-js
HerringtonDarkholme/yats.vim
maxmellon/vim-jsx-pretty
pangloss/vim-javascript
styled-components/vim-styled-components

@alexseitsinger Could you provide the code snippets and screenshots if possible?

No syntax highlight for props (with/without parameters):

Syntax highlighting is all green (using this component). (with/without parameters):

I've only recently begun to adopt TypeScript, so it is possible that I'm doing something wrong, leading to incorrect highlighting...
Thanks for your time.

After further investigation, it appears this issue may be connected to limitations of the 'HerringtonDarkholme/yats.vim' plugin.


Communication Identity | Idempotency implementation

Description

Regenerated the REST client from the latest Swagger file

Repeatability headers (Repeatability-Request-Id & Repeatability-First-Sent) are generated, added and sent to the API when using this library.

Added a new API version CommunicationIdentityServiceVersion.V2023_08_01 that is now the default API version.
Updated recordings for tests (pending)
Updated CHANGELOG & README

Swagger : Communication Identity Swagger
Swagger Spec PR : https://github.com/Azure/azure-rest-api-specs/pull/22306
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-communication-identity

Hi @mjafferi-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

This is blocked for now. Will work on it once service changes are deployed.

This is blocked for now. Will work on it once service changes are deployed.

Hi @mjafferi-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

This is blocked for now. Will work on it once service changes are deployed.

Hi @mjafferi-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

This is blocked for now. Will work on it once service changes are deployed.

Hi @mjafferi-msft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

This is blocked for now. Will work on it once service changes are deployed.


Portuguese language

Portuguese on roadmap?

Hi we current don't have that data. Collecting the dataset takes a lot of time. We are planning to release the training code so that the open-source community can train by themselves

https://github.com/myshell-ai/MeloTTS/blob/main/docs/quick_use.md

myshell 上有一些模型可能会满足您的需求https://github.com/myshell-ai/MeloTTS/blob/main/docs/quick_use.md。我们还计划发布训练代码供社区训练更多语言

上面模型能下载到本地使用吗

@Zengyi-Qin these Portuguese voice models are really good, but we can't use them, right? I mean for finetuning or training from scratch


Add documentation for spacefish API

Description

Ported over and updated the API documentation from spaceship:
https://github.com/denysdovhan/spaceship-prompt/blob/master/docs/API.md
Updated SUMMARY.md to include links to the API documentation and sections
Updated CONTRIBUTING.md to include the API documentation

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation (not affecting end-user functionality)

Checklist:

[ ] I have checked that no other PR duplicates mine
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[ ] I have updated the tests accordingly.

@Snuggle regarding ;s in if statements, I tried to just stick with the code style used in the doc examples
I'm thinking of making a code style doc in the future 😄


Metric Deviation?

Hi,
I was reading the paper linked in your description and noticed a deviation in the way you calculate the normalized distance.
While in the paper, the distance is calculated as:
(union - 2 * intersect) / (union - intersect),
which can be rewritten as
1 - (intersect / union - intersect),
your implementation uses
1 - 2 * (intersect / union),
which yields a different result. Do you have any explanation for this behavior?

Hi,
Cool to see interest in this project, it was a fun one :) I wrote that a
very long time ago and haven't really touched it/used it since then. It's
very possible there are bugs in the implementation, and I don't really
remember if this was intentional or not (probably not).
-Tyler
On Thu, Apr 27, 2017 at 1:09 AM Benjamin Murauer<EMAIL_ADDRESS>wrote:

Hi,
I was reading the paper linked in your description and noticed a deviation
in the way you calculate the normalized distance.
While in the paper, the distance is calculated as:
(union - 2 * intersect) / (union - intersect),
which can be rewritten as
1 - (intersect / union - intersect),
your implementation uses
1 - 2 * (intersect / union),
which yields a different result. Do you have any explanation for this
behavior?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/TylerGoeringer/PyGram/issues/2, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYXP3bzn--XZCBjjl_Ua4nj88OqEnPdks5r0E0zgaJpZM4NJ4FD
.

Hi,
OK thanks! I'll let you know if we have established any substantial results using your library and maybe I'll make a fork to test my attributions.
Great work, otherwise!


How can i change the charset in a new image

Hi,
I tried to create a new image with oracle 11g (file Dockerfile.11202) adding the variable "NLS_LANG = PORTUGUESE_BRAZIL.WE8MSWIN1252" and the database continues to be installed with the default charset...
Does anyone have a hint where I'm going wrong?

Hi @Pedro-Guilherme,
11g XE is only available in UTF-8, so you can't change the character set. See here in the old documentation.

Hey @gvenzl and thanks for these nice images!
Just for completeness: can the NLS_LANG be set in newer versions of Oracle? I'm currently trying out your gvenzl/oracle-xe:21.3.0-slim but i wasn't able to change the default character set by setting the NLS_LANG environment variable. I also didn't find anything in the startup- or init-code so i was wondering if this is possible somehow?

Found a solution, see https://github.com/gvenzl/oci-oracle-xe/issues/83#issuecomment-1128730830


Remove storage.MockClient from worker tests

Partial #103

Codecov Report

Merging #123 (8b1d2a3) into main (34a101f) will decrease coverage by 14.12%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #123       +/-   ##
===========================================
- Coverage   72.15%   58.03%   -14.12%
===========================================
  Files          55       55
  Lines        3024     3029        +5
===========================================
- Hits         2182     1758      -424
- Misses        663     1128      +465
+ Partials      179      143       -36

Components
Coverage Δ

garden-app
58.03% <100.00%> (-14.12%)
:arrow_down:


Support optional manifests

The idea behind optional manifests is that the absence of an API on a cluster, where a BundeDeployment is applied to, may not cause the failure of the complete deployment.
Taking ServiceMonitor as an example, an operator provider may want the resource to get created on clusters where Prometheus is installed but not to fail the installation on other clusters.

I think this might be something we could solve with operator-framework/operator-controller#384, which would allow extension authors to define parameters to be used with their bundles.
Cluster admins could enable/disable pieces of the bundle's manifests using these parameters (e.g. Extension.spec.params.enableServiceMonitor) . If we went with this approach:

Operator authors would have fine-grained control different groupings of components/configuration.
Admins can define the values of those parameters to pick and choose supported components/configurations.
OLM treats the final parameterized manifests as required. If an API is unavailable, a failure will occur, and the admin can revisit their parameter values to resolve the issue.

I worry a bit about individual optional objects. As a trivial example, if ServiceMonitor is not available, then it might not make sense to create the monitored Service either. I think I would prefer an approach where the extension author and the admin can mutually contribute to an OLM-provided API (e.g. bundle parameters/extension values) that can accommodate different cluster configurations but still results in an explicit deterministic set of manifests applied to the cluster.
@fgiloux Do you think that would be a viable solution?

@joelanford isoperator-controller #384 what you meant? Its title is "Ability to configure permissions an Operator has" and there is no description. I am not seeing how it relates to "Cluster admins could enable/disable pieces of the bundle's manifests using these parameters (e.g. Extension.spec.params.enableServiceMonitor)"
From what I understand from your comment:

Operator authors would have fine-grained control different groupings of components/configuration.
Yes that would be needed

Admins can define the values of those parameters to pick and choose supported components/configurations.
That is OK but not the best UX. Ideally this would get automatically configured depending on an cluster condition, e.g. availability of an API. This is similar to Helm capabilities.

Oops. That was a typo. I edited my comment to correct the link (https://github.com/operator-framework/operator-controller/issues/381)

Ideally this would get automatically configured depending on an cluster condition

Ah ha! I see. So a feature that accepts both cluster input and administrator input in order to determine the content of the resulting manifests. That sort of API would still allow this kind of problem to be solved:

if ServiceMonitor is not available, then it might not make sense to create the monitored Service either.

But without requiring admins to know which knobs to turn to get a compatible outcome.

So a feature that accepts both cluster input and administrator input in order to determine the content of the resulting manifests.

Yes


After generation set cursor end

Added the option (by default enabled to preserve the current behavior) to preserve the position of the cursor after a prediction, or move it to the end of the new text.
The use for this would be to allow the user to start writing right away after the generation is done.
It may have been interesting to add a space after the last word generated by the AI, but I'm not sure it would always have the desired effect, so it merely overrides the default behavior of preserving the cursor with no further modifications. If there's a selection, it will be preserved, however.

lgtm, thank you for your contribution!


testing: codeflare: config: add cpu_all_schedulable profile

/test codeflare-e2e cpu_all_schedulable keep

/test codeflare-e2e cpu_all_schedulable

/test codeflare-e2e cpu_all_schedulable

/test codeflare-e2e cpu_all_schedulable

test passed, merging


Resp protocol parser when given a command ending with a newline

To reproduce,

Start a pelikan resp service somehow (e.g. momento proxy)
Run netcat to connect to the resp port and type outGET test<enter>

This will cause pelikan to panic and crash. The root cause is this line here: https://github.com/pelikan-io/pelikan/blob/main/src/protocol/resp/src/request/mod.rs#L89

I will fix this shortly


accumulateChanges supports only a single value per attribute

I'm trying to write a watcher to persist data externally, but I'm getting the error, "accumulateChanges supports only a single value per attribute"
Here is the code (stored in file persist-test.js):
import { Program } from "witheve";

let prog = new Program("persist test");

prog.load(`
~~~
search
  sort = math/range[start: 1 stop: 1]

commit
  [#counter #persist sort count: 0]
~~~
`);

prog.watch("Export #persist tagged data to a tiddler", ({find, record, lookup}) => {
  let rec = find("persist");
  let {attribute, value} = lookup(rec);

  return [
    rec.add(attribute, value)
  ];
})
.asObjects(({adds, removes}) => {
  console.log("obj add  " + JSON.stringify(adds));
  console.log("obj rem  " + JSON.stringify(removes));
});

And I'm running it like this:
node build/src/cli.js -H build/programs/persist-test.js

If I change the watch block to instead look like this:
prog.watch("Export #persist tagged data to a tiddler", ({find, record, lookup}) => {
  let counter = find("counter");
  let {count, sort} = counter;

  return [
    record("counter", {count, sort})
  ];
})

then I don't get the error and I get some reasonable looking output:
obj add  {"tag|counter|count|0|sort|1":{"tag":"counter","sort":1,"count":0}}
obj rem  {}

The first example will work fine if you use asDiffs to retrieve the
output rather than asObjects. This is an implementation shortcut rather
than a conceptual issue, and should be fixed prior to shipping a public
release. We can use this issue to track it. I'm also happy to provide
technical details on how and why this occurs if you'd find it of value.
On Fri, Jun 9, 2017, 20:02 btheado<EMAIL_ADDRESS>wrote:

I'm trying to write a watcher to persist data externally, but I'm getting
the error, "accumulateChanges supports only a single value per attribute"
Here is the code (stored in file persist-test.js):
import { Program } from "witheve";
let prog = new Program("persist test");
prog.load(`
search
  sort = math/range[start: 1 stop: 1]

commit
  [#counter #persist sort count: 0]

`);
prog.watch("Export #persist tagged data to a tiddler", ({find, record, lookup}) => {
let rec = find("persist");
let {attribute, value} = lookup(rec);
return [
rec.add(attribute, value)
];
})
.asObjects(({adds, removes}) => {
console.log("obj add  " + JSON.stringify(adds));
console.log("obj rem  " + JSON.stringify(removes));
});
And I'm running it like this:
node build/src/cli.js -H build/programs/persist-test.js
If I change the watch block to instead look like this:
prog.watch("Export #persist tagged data to a tiddler", ({find, record, lookup}) => {
let counter = find("counter");
let {count, sort} = counter;
return [
record("counter", {count, sort})
];
})
then I don't get the error and I get some reasonable looking output:
obj add  {"tag|counter|count|0|sort|1":{"tag":"counter","sort":1,"count":0}}
obj rem  {}
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/witheve/Eve/issues/843, or mute the thread
https://github.com/notifications/unsubscribe-auth/AATKDrDqQ6f0dMTZWTB6HhwTuu63mbiNks5sCgcpgaJpZM4N1_h4
.

Thanks. I tried asDiffs and it worked fine. I was using asObjects because having the attributes and values for each entity grouped together into a single object was convenient.
I think I can write the code myself to group the array of EAV by entity, but will I run into the same issue which is the reason for your implementation shortcut?

You should be fine since you know the potential arity of each attribute in
the specific case of the counter. The issue is purely representational --
in JS, it's incredibly cumbersome to work with an array where an attribute
is known to be scalar. It's equally unfortunate to deal with a series of
scalars when the attribute is intended to be used as a set. In the future,
asObjects will be capable of using the AST of your document to determine
intended attribute arity, but for now it always assumes scalar.
For the generic case you're looking to implement, you should still be fine.
Since you're not really looking to work with the values (just pickle and
unpickle them) always treating all attributes as sets is perfectly fine.
If you run into any issues here, feel free to reach out. I'm happy to help
however I can.
On Fri, Jun 9, 2017, 20:32 btheado<EMAIL_ADDRESS>wrote:

Thanks. I tried asDiffs and it worked fine. I was using asObjects because
having the attributes and values for each entity grouped together into a
single object was convenient.
I think I can write the code myself to group the array of EAV by entity,
but will I run into the same issue which is the reason for your
implementation shortcut?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/witheve/Eve/issues/843#issuecomment-307539023, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AATKDvm3XLYJvzm3csJOvg-AROFuKQc-ks5sCg5QgaJpZM4N1_h4
.

Thanks for the tip on treating the attributes as sets. I have used it in my code at https://github.com/btheado/tweve/blob/494ffa1360db9d62c8b67de9a97989eb0217a164/src/plugins/btheado/tweve/eve-widget.js#L78 and it seems to work.


Monochromaticity turned off when Global Illumination is enabled but set to None

Maybe this is as intended, but I would have expected the behavior to be the same as were Global Illumination disabled. If it is intended, could the documentation be updated to further explain what the None setting entails?

It's intended. It's indirectly documented in the description of "Monochrome Vision Color" but frequently missed. Maybe I'll add "None (monochrome)" as an option if this is requested.

What might a Perfect Vision use case be for having Global Illumination enabled but set to None?

With None the scene is not filled with dim/bright light. In default Foundry with Global Illumination everything is fill with dim light (technically every token gets infinite dim vision) which makes dim light sources basically invisible. With None everything is illuminated according to the Darkness Level only. No extra light is added. This way you have three instead of just two brightness levels, and the visuals of light sources say unaffected.

I get that's what "None" does by itself, but I'm wondering if there'd be any feature loss if Perfect Vision exhibited a consistent behavior regardless of light origin, be it an actual light source placed in the world or light coming from Global Illumination. At a high level it's all light or a lack thereof. Global Illumination set to None and no light source objects illuminating an area is functionally the same as Global Illumination disabled and no light source objects illuminating an area.

I had None originally as Scene Light. Not sure if that is better. Global Illumination means everything in line-of-sight is visible, and PV's setting Global Illumination Light determines what, or if, light fills the scene. But I chose to have it all in color always, reason being, if everything is visible, there must be some light, so it can't be monochrome.

I see now that Global Illumination still reveals everything even when it's set to None (an annoying undocumented side effect). I'm not sure what the solution is given that.


Fixing bug with FromVar hoisting

A combination of math type spec, copy-prop, nested loops and invariant hoisting is required to repro this bug. We end up hoisting a FromVar from a region where it doesn't need a bailout to one where it does. We should then use the value type of the src in the destination region to put the right bailout on FromVar.

This change is

@LouisLaf @pleath

lib/Backend/GlobOpt.cpp, line 18503 [r1] (raw file):
If this is the src of a FromVar, shouldn't the sym always be a Var (i.e. IsTypeSpec() == false) ?

Comments from Reviewable

@nmostafa You're right. Thanks

:+1:


[BUG] Close API requires "hidden" permission

Describe the bug
Even with the indices:admin/close permission, you can't close an index. You also need the indices:admin/close* permission, which isn't listed in OpenSearch Dashboards.
Added: It's not clear to me if this is a problem with the OpenSearch plugin or OpenSearch Dashboards plugin. Have we considered a "list permissions" REST API (GET _plugins/_security/api/permissions/ so that it's easier to get the authoritative list of all permissions?
To Reproduce
Steps to reproduce the behavior:

As admin, create a new user.
Create test-index and index a couple documents.
Create the following role:

PUT https://localhost:9200/_plugins/_security/api/roles/test
{
        "cluster_permissions": [
        ],
        "index_permissions": [
            {
                "index_patterns": [
                    "test-index"
                ],
                "dls": "",
                "fls": [],
                "masked_fields": [],
                "allowed_actions": [
                    "indices:admin/close",
                    "indices:admin/open"
                ]
            }
        ]
    }

Map the new role to the new user.
As the new user, send the following request:

POST https://localhost:9200/test-index/_close

Note the error:

{
    "acknowledged": false,
    "shards_acknowledged": false,
    "indices": {
        "test-index": {
            "closed": false,
            "failedShards": {
                "0": {
                    "failures": [
                        {
                            "shard": 0,
                            "index": "test-index",
                            "status": "FORBIDDEN",
                            "reason": {
                                "type": "security_exception",
                                "reason": "no permissions for [indices:admin/close[s]] and User [name=test, backend_roles=[], requestedTenant=null]"
                            }
                        }
                    ]
                }
            }
        }
    }
}

As admin, update the role:

https://localhost:9200/_plugins/_security/api/roles/test
{
        "cluster_permissions": [
        ],
        "index_permissions": [
            {
                "index_patterns": [
                    "test-index"
                ],
                "dls": "",
                "fls": [],
                "masked_fields": [],
                "allowed_actions": [
                    "indices:admin/close",
                    "indices:admin/close*",
                    "indices:admin/open"
                ]
            }
        ]
    }

As the new user, send the request again:

POST https://localhost:9200/test-index/_close

Success.
Expected behavior
The indices:admin/close* permission should either not be necessary or should be included in the Dashboards UI.

[Triage] Hi @shanilpa, do you have any thoughts on how to best handle this issue?
This issue remains relevant. Users given an error stating they need a permission should be able to assign that permission from the list. There are also "hidden" permissions which are not intuitive.

Make permissions not hidden (i.e. permissible actions in the YAML file of the security plugin)
Add permission being missed to drop-down list

@scrawfor99 A couple of clarifying questions here before I make any UX recommendations.

It looks like we are already working on making these "hidden" permissions available in the dropdown as mentioned in this issue. Am I missing something here? Are these permissions special and need to be treated differently from the others?

"Users given an error stating they need a permission should be able to assign that permission from the list.

As I understand it only an admin user has access to the Dashboards security plugin therefore they are the only ones that can assign permissions. I think it would be very risky to allow any user to self assign permissions from the list. Not sure I fully get what you meant by this statement, could you clarify?

Hi @opensearch-project/security,
This issue was tagged for 2.6.0. Can you close it if it was resolved or tag is to be tracked for next iteration?
Thanks!

This is released in 2.6.0. Closing issue.


chore: updated otel dependencies

refs 75234
OTel has released 1.x versions. See https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md#101--experimental-0270
IMO I would not update to it now, but maybe add a ticket to ensure our otel exporter still works with 1.x?

Good idea!

For history purposes, I created this branch https://github.com/instana/nodejs/pull/450/files where I confirm that OTel is working with version 1.x.x
I will take it from there :)
Cheers


How to validate internal services?

Hello Team,
I have 2 services running inside K8s but they are not exposed to the outer world through ingress/loadbalancer. We are using it inside K8s with gRPC. Is there a way to test the service endpoints for those services or "microservice_available_and_healthy" is enough?

The microservice_available_and_healthy action is probably something to be mindful of. It's our first action and it tried to be clever by assuming a microservice was a clearly defined thing. Today, the approach tend to be to consider your pods/deployments as their own thing and consider what you can learn at that level.
You can learn from anywhere, in your case, because your services aren't directly visible to the internet, maybe they still have an impact in the overall workflow your user is following? Maybe at a higher level?
For instance, assume I'm killing a cache server, I'm not going to learn if the cache is up or not? But I am interested in understand the increased latency for my users when they connect to the application.
Try to locate the level at which you are interested in learning something new and look there, even if you impact something deeper and lower level.
does this make sense?

You could run the experiment from the cluster itself (run chaostoolkit as a pod/job?)

No pb. Another solution, use a probe to query your monitoring solution for deleted pods?

yes, that seems easy :)


Add telemetry point measuring latency to configured cache server

In order to quantify developer experience, we need to understand the latency between a dev box and the configured cache server. This can go in the heartbeat, or in enlistment info.

Start with investigating the telemetry stream to see the timings of the read-object hook.
Compare against users with no configured cache server.

let start = ago(14d);
ParsedEvents("Trace2.Summary", start)
| extend Repo = tostring(Payload.params['remote.origin.url'])
| where Repo endswith '_git/os'
//
// Only include Trace2 commands that dynamically fetched an object.
//
| extend ReadObjectCount = toint(Payload.read_object['count'])
| where ReadObjectCount > 0
//
// Get the total wait time that the command waited for those blobs.
// (Ignoring the pre-computed the per-command average.)
//
| extend ReadObjectTotal = todouble(Payload.read_object.elapsed)
//
// Get the cache server used by the command (if set).
//
| extend CacheServer = tostring(Payload.params['gvfs.cache-server'])
//
// Compute average per-blob wait time across all commands.
//
| summarize c=sum(ReadObjectCount), t=sum(ReadObjectTotal) by CacheServer
//
//
//
| extend AverageBlobFetchTime = c/t
//
|project CacheServer, c, t, round(AverageBlobFetchTime, 3)

I just sent email with a DB query to show timing data.


Databasetransactions are not reverted

While viewing the mail in the browser, the database is used for some variabels in the mail.
Everything needed to view the mail stays in our database, even after closing down the mail.
In the find method of the mailviewer.php, the mailable is returned at line 68, but the rollback is done at line 71.
The database rollback is never done, if a mailable is returned.
What we think is the solution is to render the mail, then rollback the transaction and returning the mail.

sorry I missed this issue earlier somehow. Why would we want to rollback the transaction though?  We need that data to be persisted so that we can use them in the view. Feel free to re-open the issue if you feel something is missing.


GH-390 Fix compatibility with the custom Godot minimal theme

Fixes #390

Applied to main (=2.1) and branch 2.0.


[Facebook Adapter] Add Handover Protocol Support

Proposed Changes
Add the classes and / or methods to handle Handover Protocol events in the Facebook Adapter.
Also, make changes in the existing sample bot project to reflect this. Add a second bot to pass control between them both.
Details

Added Microsoft.Bot.Builder.Adapters.Facebook.SecondaryTestBot project.

Microsoft.Bot.Builder.Adapters.Facebook.TestBot renamed to Microsoft.Bot.Builder.Adapters.Facebook.PrimaryTestBot.

Added classes FacebookPassThreadControl, FacebookRequestThreadControl, FacebookTakeThreadControl, FacebookThreadControl to represent new Facebook data models.

Added class HandoverConstants to hold common values to be shared among adapter and bots.

Modified unit tests to reflect new changes.

On MS as 2949


Experience with 4D or higher parameter spaces

I've been utilizing the BayesOpt library to optimize parameter spaces across different dimensions within my project. While the optimization process has been smooth for 2 and 3-dimensional spaces, I've encountered challenges when scaling up to 4 dimensions.
In 2D and 3D, the optimization proceeds as expected, eventually converging on the best parameter combinations. Although the computational time for 3D is slightly longer than for 2D, it's within reasonable bounds.
However, when transitioning to 4D spaces, I've noticed a deterioration in the optimization results. Despite increasing the iteration count, I've had to halt the process at 2000 iterations due to excessive calculation time.
Are there any specific considerations or adjustments necessary when working with higher dimensional spaces in the BayesOpt library. Are there certain parameters or settings that I should be mindful of for 4D optimization? Additionally, are there any potential oversights on my part that could be impacting the optimization process?
I also tried different 4D models,but the results are the same for all of them.
Please let me know if additional information is needed.

Hi @BSchuett-fzi,
I assume that your function is reasonably well conditioned and differentiable. If that's the case, 2000 iterations really should not happen.
One quick and easy thing to try: By default, this optimizer uses the Matern kernel with an isotropic lengthscale setting. If your problem is not isotropic, I could see this causing issues. You can use
# instatiate the optimizer
...
# replace kernel
kernel = Matern(nu=2.5),
            alpha=1e-6,
            normalize_y=True,
            n_restarts_optimizer=5,
            length_scale=np.ones(4), # default = 1.0
            random_state=optimizer.random_state
)
optimizer.set_gp_params(kernel=kernel)
# optimization loop
...

to replace it with an isotropic one.
Let us know if this helps.

Thanks for your hint.
I'm sorry to ask, but do I still use a GaussianProcessRegressor? I have this code now:
gp = GaussianProcessRegressor(kernel = Matern(nu=2.5),
                            alpha=1e-6,
                            normalize_y=True,
                            n_restarts_optimizer=5,
                            length_scale=np.ones(4),  # default = 1.0
                            random_state=optimizer._random_state)
            optimizer.set_gp_params(kernel=gp)

But the length_scale is not an existing argument. I use scikit-learn  1.3.2.

Hi @BSchuett-fzi,
I will close this issue for now with the hope that the problem has been fixed. If it persits, feel free to reopen.


Get rid of the restriction that the container should be named "tensorflow"

Right now to deploy a TFJob, the pod must contain a container named tensorflow. The idea with this was to support sidecar containers. But if there is only a single container for a worker, we shouldn't enforce the restriction that it should be named tensorflow
/cc @jlewi @gaocegege

SGTM.

The constraint of naming the container 'tensorflow' is fine when there are sidecars. But if there is only a single container per pod (which is not an uncommon scenario), it doesn't make sense of have this restriction.

So we could drop the requirement that a container be named TensorFlow if there is a single container but I'm not sure I like the idea of only imposing the requirement of having a container named TensorFlow when there is more than 1 container.
If there is a single container that isn't named "TensorFlow" can't we just provide a very clear error message that explains how to fix things?

I meet a problem when I am fixing #532 , I found that it is hard to set the default port for tensorflow container if we do not know which one is it.
Consider that we have two containers in the pod and one is tensorflow container named "my-name", and a sidecar named "sidecar". We need to set the default port for the tensorflow container since it does not have one. Then we can not do it without the name "tensorflow" since we do not know which one is the real tensorflow container.

What do we want to do in 0.3.0? Do we leave the behavior as is or do we change it?

We can not change it since we need it to find the port and generate cluster spec.

Per the above closing this issue.


update eslint and introduce prettier formatter in webportal

update eslint config:

use standard eslint config
use react-hooks to avoid hook errors.

use prettier to unify file format:

semi: true
trailing comma: all
single quote: true

remove marketplace related codes
remove unused packages and move some to dev-dependencies
Currently all react-hooks/exhaustive-deps warnings are suppressed because it will affect the code. And will check further usage of react hooks.

closes #3235


chore: bdd-sbhg-import-1588562262 to 0.0.1

chore: Promote bdd-sbhg-import-1588562262 to version 0.0.1

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
If they are not already assigned, you can assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


[hex view] Blinking cursor causes constant high CPU usage

At every timer tick the whole hex view is redrawn, which causes high CPU usage even when there's no user interaction.
IMO we should remove that blinking and then mark focus with solid border and lack of it with dashed border (or something similar).

fixed in wip/adami/hexedit-rebase

fix merged to master


Add Aria: Table

https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Table_Role

Hello @kendallgassner  mam , I want to work here can you please help me on how to run this project on local machine?

So sorry for the late response!
In order to test this

globally install vsce:
https://www.npmjs.com/package/vsce
run vsce package -> this will generate a .vsix file
install the vsix file to vscode to test!

This is helpful link explain installing the vsix file: https://codeburst.io/develop-and-publish-your-own-vscode-extension-dafd9729148a

Can I work on this for the OSD contribution ?

Hi Kendall. I'd like to work on this.


Python 3 compatibility / porting.

Does Twisted Conch support Py3 now?

Last upstream commit seems to be from 14th September 2016, is Twisted dead?

Seems Twisted Conch is not yet Py3 capable...
2018-03-16 10:25:52+0000 [twisted.conch.ssh.factory.SSHFactory] Unhandled Error
Traceback (most recent call last):
File "/Users/robe8437/Documents/Python/envs/general_dev/lib/python3.6/site-packages/twisted/python/log.py", line 86, in callWithContext
return context.call({ILogContext: newCtx}, func, *args, **kw)
File "/Users/robe8437/Documents/Python/envs/general_dev/lib/python3.6/site-packages/twisted/python/context.py", line 122, in callWithContext
return self.currentContext().callWithContext(ctx, func, *args, **kw)
File "/Users/robe8437/Documents/Python/envs/general_dev/lib/python3.6/site-packages/twisted/python/context.py", line 85, in callWithContext
return func(*args,**kw)
File "/Users/robe8437/Documents/Python/envs/general_dev/lib/python3.6/site-packages/twisted/internet/selectreactor.py", line 149, in _doReadOrWrite
why = getattr(selectable, method)()
---  ---
File "/Users/robe8437/Documents/Python/envs/general_dev/lib/python3.6/site-packages/twisted/internet/tcp.py", line 1073, in doRead
protocol.makeConnection(transport)
File "/Users/robe8437/Documents/Python/envs/general_dev/lib/python3.6/site-packages/twisted/internet/protocol.py", line 510, in makeConnection
self.connectionMade()
File "/Users/robe8437/Documents/Python/envs/general_dev/lib/python3.6/site-packages/twisted/conch/ssh/transport.py", line 543, in connectionMade
self.sendKexInit()
File "/Users/robe8437/Documents/Python/envs/general_dev/lib/python3.6/site-packages/twisted/conch/ssh/transport.py", line 565, in sendKexInit
NS(b','.join(self.supportedPublicKeys)),
builtins.TypeError: sequence item 0: expected a bytes-like object, str found
Maybe we can subclass it and override methods that require updating? < @tnich @Bifrozt @bang-uin  thoughts?

Any news on this, I get this with Twisted 18.7.0 and Python3.

Ok I stand corrected it does work!
But now you have to prefix a lot of the strings with b for a byte array. E.g. the key looks now like this:
publicKeys = {
    b'ssh-rsa': keys.Key.fromString(data=sshkeys.SERVER_PUBLIC_KEY)
}


Allow for folder creation in Note filename.

Very nice plugin!
I think it would be beneficial if we could automatically create folders based on the filename template. For example I wanted to automatically include the collection in the filename like this:
<%= it.collections.map(c => c.path.join("/")) %>/<%= it.citekey ?? it.DOI ?? it.title ?? it.key %>.md

However no matter what I do it always replaces the / with _. Even if I only type:
foo/bar.md

it still creates a note called foo_bar.md.

This would definitely make synchronisation between Zotero and Obsidian even more seamless. Integrating them even further, like with the annotation side pannel.

Bump

Bump


No need in i-bem block, if we want only elems

if our block depends on i-bem__i18n
we expect { block: 'i-bem', elem: 'i18n'  }
not { block: 'i-bem', elems: ['i18n']  }

The main idea during the comparison of actual and expected deps is to transform them to the comparable form, this way the expected deps in the diff may be shown in a long form.
It seems that the variant { block: 'i-bem', elems: ['i18n'] } is valid too and there will be no diff if the actual deps will be { block: 'i-bem', elem: 'i18n' }.


dotnet core packages are missing from packages.microsoft.com

https://packages.microsoft.com/config/ubuntu/20.04/packages-microsoft-prod.deb shows 404 and all apt install command are failed due to packages not found in prod pool

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 80707602-f283-e796-d3b8-3287fbc011dc
Version Independent ID: 1d732b15-9e64-633a-000c-ad96d9d3818a
Content: Install .NET on Ubuntu - .NET
Content Source: docs/core/install/linux-ubuntu.md
Product: dotnet
Technology: dotnet-install
GitHub Login: @adegeo
Microsoft Alias: adegeo

This should have been fixed now per https://github.com/dotnet/core/issues/6381#issuecomment-863274298

I believe the main discussion is at dotnet/sdk#18304 hopefully it gets working 100% soon!

duplicate of #24711

duplicate of #24711


Fix NicoNico Track

NicoNico removed their getflv API sometime this march. I implemented this blog post's solution and referenced this library's JSON repackaging.

I have many points to raise about this PR.

Is an account necessary to stream tracks?
1b. If it is, why is this source manager initialised with default values of null if it's unusable?
It is advisable to use a ScheduledExecutor over a Timer.
Parsed JSON responses should really be using the library-provided JsonBrowser class as it's a little more resilient to unexpected response changes.
A lot of lines need breaking up into separate statements, for example, request.setEntity(new StringEntity(processJSON(loadVideoMainPage(httpInterface)).toString()));.
4b. The monolithic function processJSON should also be split up into several lines rather than trying to create a JSONObject inside a JSONObject inside a JSONObject inside a ...
If the sendHeartbeat function is detrimental to being able to stream a track, it should not be handled gracefully but instead stop the processing of the track as it would be unrecoverable.

Thank you so much for the fast response and feedback, so sorry about the issues with the code. I'm self-taught and first made the changes while modifying a music bot so I'm not too familiar with standard practice. I'll rewrite to to align with the feedback.
An account is not necessary to stream most tracks, and I haven't found a track that needs an account to access it. However, the niconico.py library still has a login feature, so I left it in as a precaution in case there's some scenario where it's needed.

There is no need to close this, you can simply push additional commits to this pr
We will squash this anyway

Tried using JsonBrowser as an alternative but am not sure if this is what the syntax should be looking like, let me know if this is acceptable:

Additionally, I'm a college student so I may be busy, but I will try to get this resolved as quickly as possible.

I've tried to implement the changes as advised, still unsure about processJSON but let me know what else I could do.

It resolves https://github.com/Walkyst/lavaplayer-fork/issues/85

I've tried to implement the changes as advised, still unsure about processJSON but let me know what else I could do.

You're on the right track with it but still looks extremely bulky. Is every field there really necessary for playback?

Seems like almost every field is necessary, I've tried to remove each of them in testing but only content_uri and priority can be omitted without the request 400'ing. I'll also join the discord, might be more convenient to discuss changes I should make there.

Moving discussion to https://discord.com/channels/1082302532421943407/1183572413213053038

Done.


Adjoint and Controlled metabloqs / protocols

Given a bloq, we often want an adjoint (inverse) or controlled version of it.
Full support for these meta-operations includes

a method that a bloq user can call to get the adjoint or controlled version of a bloq
some encapsulation of the default behavior: i.e. by default, we get the adjoint by reversing the order of subbloqs and taking the adjoint of each subbloq. We get a controlled bloq by controlling all of the subbloqs.
a way for bloq authors to provide specialized adjoint or controlled versions of a bloq.

I'm imagining implementing the second point as class ControlledBloq(Bloq): and class Adjoint(Bloq): where these "metabloqs" have a bloq: Bloq attribute. So you could have cx = ControlledBloq(Prepare(...)).
Note that ControlledBloq already exists; but points (1) and (3) do not exist for the "controlled protocol".

#565 -- does this for adjoint

https://github.com/quantumlib/Qualtran/pull/600 -- Controlled and CtrlSpec. Closing this roadmap item
Follow-up issues:

https://github.com/quantumlib/Qualtran/issues/648
https://github.com/quantumlib/Qualtran/issues/649
https://github.com/quantumlib/Qualtran/issues/650


Refactor project name

Changed project name from
seedu.addressbook to f12b2.todoapp
Fixes #93

Will leave this issue aside for now


Adds support for Linux/Windows valet ports

Hey @andreiio 👋
I've been using this package successfully for about a year or so on macOS, then recently needed to run a development environment on a Linux OS.
I found a port of Valet for Linux here: https://cpriego.github.io/valet-linux/, which uses a different directory for configuration.
This PR adds code to check process.platform and inject the correct directory for macOS, Linux, and Windows.

Thanks!


Add *.sublime-syntax

removed UUID which wasn't referenced
marked comment block as unimplemented
created LICENSE file

updated year to 2016

updated README with badges and compatibility table
added *.sublime-syntax for future use with ST3

see commits for details

/cc @hydrixos

Thanks for your fixes and for improving the readme!


nixos/gitlab-runner: support multiple services

Motivation for this change
This is a rebase of https://github.com/NixOS/nixpkgs/pull/84139
A more declarative module for gitlab-runner with support for multiple services.
Inspired by @arianvp's module.
Main changes:

Multiple runner services can be registered.
Automatic registration via registration token so same config can be used on many machines.
Runner services is registered/unregistered only when needed (idempotent).
Dead runner services are removed from config on start/reload.
DynamicUser is used so no need for static user and group.
Support for running nix in docker via host nix-daemon.

What is missing:

Global configuration could only be changed by editing /var/lib/gitlab-runner/.gitlab-runner/config.toml. Fixed.

Please comment if you think that something else is missing or would be great to have.
Example config with four runner services:
{ config, pkgs, lib, ...}:
with lib;
{
  services.gitlab-runner = {
    enable = true;
    services = {
      # runner for building via nix in docker
      nix = {
        registrationConfigFile = pkgs.writeText "gitlab-runner-nix-registration" ''
          CI_SERVER_URL=https://gitlab.com/
          REGISTRATION_TOKEN=<token1>
        '';
        dockerImage = "alpine";
        dockerVolumes = [
          "/nix/store:/nix/store:ro"
          "/nix/var/nix/db:/nix/var/nix/db:ro"
          "/nix/var/nix/daemon-socket:/nix/var/nix/daemon-socket:ro"
        ];
        dockerDisableCache = true;
        preBuildScript = pkgs.writeScript "setup-container" ''
          mkdir -p -m 0755 /nix/var/log/nix/drvs
          mkdir -p -m 0755 /nix/var/nix/gcroots
          mkdir -p -m 0755 /nix/var/nix/profiles
          mkdir -p -m 0755 /nix/var/nix/temproots
          mkdir -p -m 0755 /nix/var/nix/userpool
          mkdir -p -m 1777 /nix/var/nix/gcroots/per-user
          mkdir -p -m 1777 /nix/var/nix/profiles/per-user
          mkdir -p -m 0755 /nix/var/nix/profiles/per-user/root
          mkdir -p -m 0700 "$HOME/.nix-defexpr"

          . ${pkgs.nix}/etc/profile.d/nix.sh

          ${pkgs.nix}/bin/nix-env -i ${concatStringsSep " " (with pkgs; [ nix cacert git openssh ])}

          ${pkgs.nix}/bin/nix-channel --add https://nixos.org/channels/nixpkgs-unstable
          ${pkgs.nix}/bin/nix-channel --update nixpkgs
        '';
        environmentVariables = {
          ENV = "/etc/profile";
          USER = "root";
          NIX_REMOTE = "daemon";
          PATH = "/nix/var/nix/profiles/default/bin:/nix/var/nix/profiles/default/sbin:/bin:/sbin:/usr/bin:/usr/sbin";
          NIX_SSL_CERT_FILE = "/nix/var/nix/profiles/default/etc/ssl/certs/ca-bundle.crt";
        };
        tagList = [ "nix" ];
      };
      # runner for building docker images
      docker-images = {
        registrationConfigFile = pkgs.writeText "gitlab-runner-docker-images-registration" ''
          CI_SERVER_URL=https://gitlab.com/
          REGISTRATION_TOKEN=<token2>
        '';
        dockerImage = "docker:stable";
        dockerVolumes = [
          "/var/run/docker.sock:/var/run/docker.sock"
        ];
        tagList = [ "docker-images" ];
      };
      # runner for executing stuff on host system
      # make sure to add required packages (including git!)
      # to `environment.systemPackages`
      shell = {
        registrationConfigFile = pkgs.writeText "gitlab-runner-shell-registration" ''
          CI_SERVER_URL=https://gitlab.com/
          REGISTRATION_TOKEN=<token3>
        '';
        executor = "shell";
        tagList = [ "shell" ];
      };
      # runner for everything else
      default = {
        registrationConfigFile = pkgs.writeText "gitlab-runner-default-registration" ''
          CI_SERVER_URL=https://gitlab.com/
          REGISTRATION_TOKEN=<token4>
        '';
        dockerImage = "debian:stable";
      };
    };
  };
  environment.systemPackages = with pkgs; [ git ];
}

Things done

[X] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[X] Fits CONTRIBUTING.md.

@FRidh @misuzu Is there an option to define additional options? E.g. some things are missing:

S3 cache
Pull policy
Session server
Sentry DSN

@FRidh @misuzu Is there an option to define additional options? E.g. some things are missing:

S3 cache
Pull policy
Session server
Sentry DSN

Yes, there is registrationFlags.

@misuzu Thanks for the fast response. I can't really add anything manually, as this is an automated setup. Will the remaining complex options like s3 cache and session server also be added soon?

@misuzu Thanks for the fast response. I can't really add anything manually, as this is an automated setup. Will the remaining complex options like s3 cache and session server also be added soon?

You can configure cache using registrationFlags:
   --cache-type value                                           Select caching method [$CACHE_TYPE]
   --cache-path value                                           Name of the path to prepend to the cache URL [$CACHE_PATH]
   --cache-shared                                               Enable cache sharing between runners. [$CACHE_SHARED]
   --cache-s3-server-address value                              A host:port to the used S3-compatible server [$CACHE_S3_SERVER_ADDRESS]
   --cache-s3-access-key value                                  S3 Access Key [$CACHE_S3_ACCESS_KEY]
   --cache-s3-secret-key value                                  S3 Secret Key [$CACHE_S3_SECRET_KEY]
   --cache-s3-bucket-name value                                 Name of the bucket where cache will be stored [$CACHE_S3_BUCKET_NAME]
   --cache-s3-bucket-location value                             Name of S3 region [$CACHE_S3_BUCKET_LOCATION]
   --cache-s3-insecure                                          Use insecure mode (without https) [$CACHE_S3_INSECURE]

I can try adding other global options.

@max-wittig please take a look at https://github.com/NixOS/nixpkgs/pull/86946
See https://discourse.nixos.org/t/call-for-testing-gitlab-runner-module/6765 for how to quickly test it.

@misuzu I've tested it now with this MR, but I'm just getting the old gitlab-runner (12.4.1). Is there any way to specify the latest runner. I've seen the package option but I'm not sure how to bump something there. Should already be at pkgs.gitlab-runner

@misuzu I've tested it now with this MR, but I'm just getting the old gitlab-runner (12.4.1). Is there any way to specify the latest runner. I've seen the package option but I'm not sure how to bump something there. Should already be at pkgs.gitlab-runner

12.4.1 is in 19.09. You can upgrade to 20.03 or unstable for latest version.

@misuzu I just noticed that, but ran into another problem. Every 2nd deployment or so, the config.toml stays empty:

gitlab-runner is happy with an empty config, but I'm not 😄

the config.toml stays empty

Please share your config.

@misuzu Thanks for all the help!
services.gitlab-runner = {
    enable = true;
    checkInterval = 15;
    package = latestPkgs.gitlab-runner;
    #concurrent = ${vars.concurrent};
    services = {
      docker-images = {
        registrationFlags = [
          "--cache-type"
          "s3"
          "--cache-shared"
          "--cache-s3-server-address"
          "s3.amazonaws.com"
          "--cache-s3-access-key"
          "${vars.s3_access_key}"
          "--cache-s3-secret-key"
          "${vars.s3_secret_key}"
          "--cache-s3-bucket-name"
          "some-aws-bucket"
          "--cache-s3-bucket-location"
          "eu-central-1"
          "--docker-pull-policy"
          "always"
        ];
        registrationConfigFile = pkgs.writeText "gitlab-runner-nix-registration" ''
          CI_SERVER_URL=https://gitlab-url/
          REGISTRATION_TOKEN=${vars.token}
        '';
        #dockerAllowedImages = "vars.docker_whitelist}";
        dockerImage = "some-registry.com:some-image:stable";
        dockerVolumes = [
          "/mnt/projects/sstate-cache:/home/projects/sstate-cache:rw"
        ];
        executor = "docker";
        maximumTimeout = 86400;
        dockerDisableCache = true;
        environmentVariables = {
          CONCURRENCY_LEVEL = vars.concurrent;
        };
        #tagList = ["${vars.tags}"];
      };
    };
  };

@max-wittig this config is working fine on my server. Please check the logs: journalctl -u gitlab-runner.service.

No errors in the journal. Looks good, but doesn't work.

No errors in the journal. Looks good, but doesn't work.

Please share a full log: start journalctl -f -u gitlab-runner.service and in different console run systemctl restart gitlab-runner.service

Doesn't change anything, as it's the registration part that writes this empty config file that doesn't work, not the runner start part.

Doesn't change anything, as it's the registration part that writes this empty config file that doesn't work, not the runner start part.

That's exactly what i want to see, there is no logs from gitlab-runner-configure in your screenshot.

Ah I guess I had some registration parameter wrong. Can we implement some sort of error for this? Like fail the nixos switch if this happens?

Ah I guess I had some registration parameter wrong. Can we implement some sort of error for this? Like fail the nixos switch if this happens?

Maybe. I have to understand what happened to do that.

I think the registration failed. I had this message: https://gitlab.com/gitlab-org/gitlab-runner/-/issues/2862

@misuzu Thanks again for the great work you did here and sorry for my stupid questions 😉

@misuzu The registration error from the runner actually looks like this:

@misuzu Thanks again for the great work you did here and sorry for my stupid questions

Don't worry. Thanks for testing!

@misuzu The registration error from the runner actually looks like this:

I have updated pull request, now this should fail on activation.

Ah nice! Thanks. One more thing. The name of the runner cannot be overriden currently, right? Could that be configurable, too? 😄

Ah nice! Thanks. One more thing. The name of the runner cannot be overriden currently, right? Could that be configurable, too?

You can use something else instead of docker-images for prefix but suffix is needed to check if runner must be re-registered when configuration is changed.

Ah I see.  Thanks

This should have been mentioned in the release notes.


default boudingbox should come from config

the map should be center on the current city.
this setting should come from config file.
config file should contains the city bounding box instead of the center.
leaflet can calculate the most adpated zoom
We should use
map.panInsideBounds(city_boundingbox)

instead of
map.setView(city_center, 13);

Add this in config/public.json
"bounding_box": {
    "south_west": [3.704, 43.523],
    "north_east": [4.056, 43.686]
  }


DQN pong example doesn't work off the shelf

Describe the bug

Running the DQN example on pong generates the following error when generating a gif:
  File ".../lib/python3.9/site-packages/coax/utils/_misc.py", line 475, in generate_gif
    assert env.render_mode == 'rgb_array', "env.render_mode must be 'rgb_array'"

This is likely due to some recent updates to gym. Currently, on gym==0.26.2 I observe the following:
import gym
env = gym.make('PongNoFrameskip-v4', render_mode="rgb_array")
print(env.render_mode) # prints None

Thanks for reporting this @thisiscam and thanks so much for digging into this @benjaminbeilharz
Would you mind filing a bug upstream in https://github.com/openai/gym ?
I'll review your PR now.

@KristianHolsheimer I have filed an issue here: https://github.com/openai/gym/issues/3166
Thanks for your work on coax :)

Fixed by #38


Sentry Automatic Instrumentation for React Navigation

Description
A follow up task for SPIKE: investigate reported latency issues #2293.
Implement Automatic Instrumentation - React Navigation.
Acceptance Criteria RUM metrics in Sentry

Transactions Per Minute
Cold Startup Time
Warm Startup Time
Most Slow Frames
Most Regressed

Was completed by #1632, but we recently ran out of event quota.


WithStyles type error

We have lots of class components that we're slowly converting to functional components. I didn't find much documentation on migrating classes, so below is a dumbed down version of a type error we're getting.
Given we have a class such as:
import * as React from 'react';
import { withStyles } from 'tss-react/mui';
import { WithStyles } from '@mui/styles';

type Props = WithStyles<'root'>;

const styles = () => ({
  root: {
    backgroundColor: 'red',
  },
});

export class MyComponent extends React.Component<Props> {
  render() {
    const { classes } = this.props;

    return
testing
;
  }
}

export default withStyles(MyComponent, styles);

When we go to use this component, we get:
Property 'classes' is missing in type '{}' but required in type '{ classes: ClassNameMap<"root">; }'.

We're using the WithStyles type from @mui/styles to define the Props type of the MyComponent class component where classes is required. In tss-react, there is no equivalent WithStyles type.
We could define our own WithStyles type on our end, or satisfy the type checker by replacing type Props = WithStyles<'root'>; with:
type Props = {
  classes: {
    root: string;
    // ...
  };
};

However we'd have to add <MyComponent classes={{ root: 'my-class' }} /> wherever we use this class.
Is this something that tss-react should cover?

Hello @jaalah,
You're right, the documentation wasn't clear enough about this usecase.
I just updated it: https://docs.tss-react.dev/api/withstyles#with-class-components
Also, update tss-react
I hope it solves things for you.

@jaalah OMG I just saw your donation, thank you so much, it's the first donation I received ever after all these years of OSS work.  Needless to say, it means the world to me!

@jaalah, Hold on, I'm making an other update to improve the DX

There you go:  https://docs.tss-react.dev/api/withstyles#with-class-components
Let me know if it fits your needs!


Is this a good way to solve 'XXX is not installed', after new policy that all apps are installed to /Applications

Related to #13201. After atom.app auto-updated to version 1.8.0, the directory name in Caskroom/atom/1.7.4 is still the old version number. In this case brew cask seems not able to recognize that the application has been updated. Then I simply rename the directory to 1.8.0, and everything seems to work fine. Is this a valid solution for all other apps?

This isn’t related to that issue. We don’t have upgrade functionality, so any way you decide to upgrade is both fine an unsupported. This would have happened before the change to moving anyway. You’d need to change the directory’s name, you can just leave it be and it will work just as well.


nixos/sniproxy: remove unused logDir option

This never configured where SNI should log to, as it's up to the user to
provide the full sniproxy config (which can be configured to log to a
file).
This option only produced a ExecStartPre script that created the folder.
Let's use LogsDirectory to create it. In case users want to use another
directory for logs, they can override LogsDirectory or set their own
ExecStartPre script.
Motivation for this change
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Not familiar with sniproxy, but how to configure where the application logs to in the first place? It surely won't follow LogsDirectory, which would be a awesome.

Not familiar with sniproxy, but how to configure where the application logs to in the first place? It surely won't follow LogsDirectory, which would be a awesome.

See the example for services.sniproxy.config.
It can be configured to log to a file or syslog, but it's up to the user to configure.
Considering all these examples, keeping the log folder creation, but moving it to LogsDirectory= (and getting rid of the option) makes things more aligned with the rest of nixpkgs.


Needs updated for V9

:D

Is there any progress being made on this?

marked as compatible

Is it actually compatible though?

Oh no, I've just changed the comparability for fun /s
There shouldn't be any reason it shouldn't work.

Thanks so much.

Though I cannot find any examples so I will defer to your expertise. Thank you for the module


[GSK-1199] Implement websocket to get worker status

Description
The idea of this PR is to implement a WebSocket to provide a channel through which the backend can send the ML Worker status without any request from the front.
This improvement will be divided into two phases:
1- Implement WebSocket on back and frontend, send the worker status periodically from Spring app, and update Vue components to use websocket instead of store. (CURRENT PR)
2- Make the backend only send a message to the channel when the worker status change, instead of sending it every N seconds. Also, send the last worker status whenever a new subscriber appears.
Related Issue
GSK-1199 (available on Linear)
Type of Change

[ ] 📚 Examples / docs / tutorials / dependencies update
[ ] 🔧 Bug fix (non-breaking change which fixes an issue)
[ ] 🥂 Improvement (non-breaking change which improves an existing feature)
[ ] 🚀 New feature (non-breaking change which adds functionality)
[x] 💥 Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🔐 Security fix

@henchaves on my end I don't get notifications when running Giskard in production mode (in docker).
Also when testing in dev mode I had to use the UI for a bit before I started receiving ML Worker connected/disconnected messages:

I installed a blank instance
connected the worker - no notification ❌
disconnected the worker - no notification ❌
created project, connected/disconnected worker - no notification ❌
ran the onboarding code and connected/disconnected worker - no notification ❌
opened the test suite and connected/disconnected worker - got notification ✅

Well, it should be enabled on a global level (except for the login page). It's important to know if a worker gets disconnected even if you're not immediately using it

@andreybavt, I added worker notifications for all components inside Main.vue. Can you try again the use cases you mentioned? I tried it on my side, and it's working now.

@henchaves , sure I'll retest now. Did you try in Docker too?

I also spotted an unhandled corner case: when you logout (available with a paid license) you don't unsubscribe from the websocket events and thus still continue receiving the notifications

@andreybavt, everything should be working now (including using Docker)

@henchaves ok, I'm checking again and then it's good to merge

@henchaves , one other thing I noticed is that the security question isn't solved in this PR. You can connect to this WS endpoint and send/receive STOMP messages from any client without being authenticated

Once the build passes it should be OK to merge


obsidian: 1.7.4 -> 1.7.5

https://obsidian.md/changelog/2024-11-04-desktop-v1.7.5/
addresses a deprecation warning omitted due usage of to convert

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 353717

x86_64-linux

:white_check_mark: 1 package built:

obsidian

aarch64-linux

:white_check_mark: 1 package built:

obsidian


Handle many to many to avoid indexing a whole object

By making the user only chose one field of the related collection we avoid indexing whole objects

PR #265 addresses this issue I think


rbd: snapshot namespace related changes

Added following macros required by snapshot namespace functions:
a. RBD_SNAP_NAMESPACE_TYPE_USER
b. RBD_SNAP_NAMESPACE_TYPE_GROUP
c. RBD_SNAP_NAMESPACE_TYPE_TRASH
Wrapper to following snapshot namespace functions:
a.  rbd_snap_get_namespace_type() - To get the namespace to which snapshot belongs to.
b.  rbd_snap_get_trash_namespace() -  To get more information about the snapshot which is in Trash.

Fixes: https://github.com/ceph/go-ceph/issues/300
Signed-off-by: Mudit Agarwal<EMAIL_ADDRESS>Checklist

[ ] Added tests for features and functional changes
[ ] Public functions and types are documented
[ ] Standard formatting is applied to Go code

@nixpanic PTAL

@nixpanic PTAL

just minor things, looks good to go once these are addressed

Forgot to address the comments, fixed now.
Also, this should not create any conflict because its a new file.


Showing theme from oh-my-zsh is not complete

When using zplug to use theme (themes/robbyrussell) of oh-my-zsh, the little arrow in the beginning of the prompt is missing.
My .zshrc is:
[[ -d ~/.zplug ]] || {
    curl -fLo ~/.zplug/zplug --create-dirs https://git.io/zplug
    source ~/.zplug/zplug && zplug update --self
}
source ~/.zplug/zplug

zplug "zsh-users/zsh-completions"
zplug "zsh-users/zsh-history-substring-search"
zplug "zsh-users/zsh-syntax-highlighting", nice:19
zplug "plugins/git", from:oh-my-zsh, if:"which git"
zplug "plugins/osx", from:oh-my-zsh, if:"[[ $OSTYPE == *darwin* ]]"
zplug "themes/robbyrussell", from:oh-my-zsh

if ! zplug check --verbose; then
    printf "Install? [y/N]: "
    if read -q; then
        echo; zplug install
    fi
fi

zplug load

The right prompt should be:
➜ ~

and now it's:
~

At last, I'm using Mac OS X El Capitan, zsh from homebrew.

Thank you for your report.
Okay, I'll reproduce your problem soon.

I have found the problem. I noticed that the same problem has occurred even if I use antigen or zgen.
Workaround:
https://github.com/robbyrussell/oh-my-zsh/blob/master/themes/robbyrussell.zsh-theme
- local ret_status="%(?:%{$fg_bold[green]%}➜ :%{$fg_bold[red]%}➜ %s)"
+ ret_status="%(?:%{$fg_bold[green]%}➜ :%{$fg_bold[red]%}➜ %s)"

Now I try to solve this problem...

Thank you. It works now.
I had noticed this local variable, but I was not aware that this was the root cause. Thank you anyway. Should we report to oh-my-zsh so that plugin managers (zplug, antigen or zgen) can seamlessly select various themes?

I think it's worth it but I don't know if oh-my-zsh owner will merge your PR/issue.

This can be closed, yes?


HOTFIX-Set flag to regenerate metadata xml on bulk metadata update

This hotfix needs to be applied to master. Once I get +1 I will ask @mjstealey to do this merge.

@hyi Can you review this small PR?

@mjstealey I would have liked to deploy this work for testing by @yirugi before applying this as a hotfix to master.

@aphelionz Can you look at this PR and decide if we should make it a hotfix or not?

@pkdash Go for it - hotfix.

@mjstealey can you merge this to master and then update www? This PR has been created from master.

@pkdash - Please verify that fix has been properly applied to www

@mjstealey Thanks. Will do the checks.


Possible bug in LinearAlgebra testing module

I had trouble with LinearAlgebra Exercise 8 after submitting my code
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
<ipython-input-17-ec126a7665cf> in <module>
      2
      3 @exercise
----> 4 def is_matrix_unitary(a : Matrix) -> bool:
      5     n = len(a)
      6     print(n)

~/Projects/QuantumKatas/tutorials/LinearAlgebra/testing.py in exercise(fun)
      7 # Exercise decorator, specifying that this function needs to be tested
      8 def exercise(fun):
----> 9     tests[fun.__name__](fun)
     10     return fun
     11

~/Projects/QuantumKatas/tutorials/LinearAlgebra/testing.py in is_matrix_unitary_test(fun)
    425         if i > 0:
    426             --i
--> 427             a = edge_unitary_matrices[i]
    428         elif result:
    429             a = gen_unitary_matrix()

IndexError: list index out of range

Notice line 426 --i does not decrement the value of i in Python:
$ python3
Python 3.7.4 (default, Sep  7 2019, 18:27:02)
[Clang 10.0.1 (clang-1<IP_ADDRESS>)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> i = 2
>>> --i
2
>>> i
2
>>>

edge_unitary_matrices has 2 elements https://github.com/microsoft/QuantumKatas/blob/master/tutorials/LinearAlgebra/testing.py#L405.

Thank you for reporting this! Indeed this test is broken. Weird, I was sure I solved through all the tasks when I was reviewing this...