gtkwave: 3.3.87 -> 3.3.89

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools.
This update was made based on information from https://repology.org/metapackage/gtkwave/versions.
These checks were done:

built on NixOS
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/evcd2vcd -h got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/evcd2vcd --help got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/evcd2vcd -V and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/evcd2vcd -v and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/evcd2vcd --version and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/evcd2vcd -h and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/evcd2vcd --help and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/fst2vcd -h got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/fst2vcd --help got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/fst2vcd -V and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/fst2vcd -v and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/fst2vcd --version and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/fst2vcd -h and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/fst2vcd --help and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2fst -h got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2fst --help got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2fst help got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2fst -V and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2fst -v and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2fst --version and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2fst version and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2fst -h and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2fst --help and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2fst help and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/fstminer -h got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/fstminer --help got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/fstminer -V and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/fstminer -v and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/fstminer --version and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/fstminer -h and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/fstminer --help and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/lxt2miner -h got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/lxt2miner --help got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/lxt2miner -V and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/lxt2miner -v and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/lxt2miner --version and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/lxt2miner -h and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/lxt2miner --help and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/lxt2vcd -h got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/lxt2vcd --help got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/lxt2vcd -V and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/lxt2vcd -v and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/lxt2vcd --version and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/lxt2vcd -h and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/lxt2vcd --help and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2lxt -h got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2lxt --help got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2lxt help got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2lxt -V and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2lxt -v and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2lxt --version and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2lxt version and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2lxt -h and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2lxt --help and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2lxt help and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2lxt2 -h got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2lxt2 --help got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2lxt2 help got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2lxt2 -V and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2lxt2 -v and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2lxt2 --version and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2lxt2 version and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2lxt2 -h and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2lxt2 --help and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2lxt2 help and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2vzt -h got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2vzt --help got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2vzt help got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2vzt -V and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2vzt -v and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2vzt --version and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2vzt version and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2vzt -h and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2vzt --help and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vcd2vzt help and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vzt2vcd -h got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vzt2vcd --help got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vzt2vcd -V and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vzt2vcd -v and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vzt2vcd --version and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vzt2vcd -h and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vzt2vcd --help and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vztminer -h got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vztminer --help got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vztminer -V and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vztminer -v and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vztminer --version and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vztminer -h and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vztminer --help and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/gtkwave -h got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/gtkwave --help got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/gtkwave help got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/gtkwave -V and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/gtkwave -v and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/gtkwave --version and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/gtkwave version and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/gtkwave -h and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/gtkwave --help and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/gtkwave help and found version 3.3.89
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vermin -h got 0 exit code
ran /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vermin -h and found version 3.3.89
found 3.3.89 with grep in /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89
directory tree listing: https://gist.github.com/69f7a88d0a20c6860e8ee145090b3375

cc @thoughtpolice @viric for review

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: gtkwave
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: gtkwave
Partial log (click to expand)
shrinking /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vermin
shrinking /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/evcd2vcd
shrinking /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/vzt2vcd
shrinking /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/shmidcat
shrinking /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin/twinwave
gzipping man pages under /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89/bin
patching script interpreter paths in /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89
checking for references to /build in /nix/store/njhhnirg6nvrvkx8n6fb3nzwzj491h34-gtkwave-3.3.89...

Success on aarch64-linux (full log)
Attempted: gtkwave
Partial log (click to expand)
shrinking /nix/store/bnjwv7rlklbc6xrav9z0gd3n4rg6jmlc-gtkwave-3.3.89/bin/ghwdump
shrinking /nix/store/bnjwv7rlklbc6xrav9z0gd3n4rg6jmlc-gtkwave-3.3.89/bin/fstminer
shrinking /nix/store/bnjwv7rlklbc6xrav9z0gd3n4rg6jmlc-gtkwave-3.3.89/bin/vcd2fst
shrinking /nix/store/bnjwv7rlklbc6xrav9z0gd3n4rg6jmlc-gtkwave-3.3.89/bin/fst2vcd
shrinking /nix/store/bnjwv7rlklbc6xrav9z0gd3n4rg6jmlc-gtkwave-3.3.89/bin/evcd2vcd
gzipping man pages under /nix/store/bnjwv7rlklbc6xrav9z0gd3n4rg6jmlc-gtkwave-3.3.89/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bnjwv7rlklbc6xrav9z0gd3n4rg6jmlc-gtkwave-3.3.89/bin
patching script interpreter paths in /nix/store/bnjwv7rlklbc6xrav9z0gd3n4rg6jmlc-gtkwave-3.3.89
checking for references to /build in /nix/store/bnjwv7rlklbc6xrav9z0gd3n4rg6jmlc-gtkwave-3.3.89...


Feature request: table rows sizing control

Great tools, love your work!
The only thing I have qualms with is the fact that tables aren't able to be sized. At the moment, if a string in the table is long enough it will compress the other columns and misaligned the table's formatting. I suggest that the dashes in the table's syntax increases the priority and/or width of a column in order to fix this issue.
Perhaps by using padding percentage per column, or setting the width of the TDs?
Cheers.

The table syntax is just standard Markdown, which doesn't allow for changing the table widths. However you can accomplish what you want by writing your tables in HTML using inline styling to control their size. Read up on how to do that here. Good luck!


v1.0.5 breaks hooks that update the Entry

We've been using a Hook to add line number and file name information to the Entry for a long time.  Unfortunately https://github.com/sirupsen/logrus/pull/707 has broken our Hook.  Since it copies the Entry, our updates to it are lost when the fireHooks method returns.
Our hook used this pattern to avoid mutating the Entry while it may have been read by another thread:
newData := make(log.Fields, len(entry.Data)+2)
for k, v := range entry.Data {
	newData[k] = v
}
newData["__file__"] = path.Base(frame.File)
newData["__line__"] = frame.Line
entry.Data = newData

but that no longer works.  I think that simply mutating the existing data map would be broken too.
This seems to work for a quick fix since it's the copy that gets logged out instead of the original Entry:
- entry.fireHooks()
+ entry = entry.fireHooks()
...
- func (entry Entry) fireHooks() {
+ func (entry Entry) fireHooks() Entry {
 	entry.Logger.mu.Lock()
 	defer entry.Logger.mu.Unlock()
 	err := entry.Logger.Hooks.Fire(entry.Level, &entry)
 	if err != nil {
 		fmt.Fprintf(os.Stderr, "Failed to fire hook: %v\n", err)
 	}
+	return entry
 }

I'll put up a PR for that.

Yes, that broke existing functionality and I think allowing hooks to modify entries before other hooks dispatch them is something nice to have as logger.

hello， any update about this issue?  It seems that fix from @fasaxc has not been merged yet.  I use v1.0.5 and meet the same issue...

Hello this logrus issue should be fixed on master branch, let me know if everything works as expected.

Looks like the fix is working, but not for the formatted equivalents (Debugf, Warnf, etc.). So, I think there is more to do for this one.
From here: https://github.com/projectcalico/node/pull/208#discussion_r275992402

@caseydavenport : Note that I wasn't testing the latest version, but only 1.0.6 and 1.1.0. Maybe it's fixed in 1.4.1…


Super Hexagon: Hint Machine doesn't detect the process is closed / killed

HintMachine version: Dev Branch
Game: Super Hexagon
Game / Emulator version: Steam
Bug description
Easy repro: Launch game. Connect with Hint Machine. Alt-F4 game.

Fixed in c9b46fa


wsl installation seems failed: Nothing was processed. Reboot system.

While setting up Ubuntu via Microsoft store, the system seems stacked and I have to reboot, before finishing wsl install (I think). After reboot, I tried to re-install wsl using "wsl --install" but powershell says "noting was processed. you have to reboot system." (note: since I am using Windows10 21H2 Japanese, then true message is in Japanese.) with no error code shown. This is first time wsl install. Of course reboot PC does not help.
I am sorry if this is known, I googled similar message but could not find a solution.
Other wsl command like without argument, it shows help message only (same behavior with wsl --help). Windows Subsystem and VM platform are enabled.

What version of WSL are you using?

This is very frustrated that today I power-on the PC something update was executed and after logging in, "wsl -l -v" said "there is no distribution installed" which is completely different response... Now I can retry, it seems something was blocked reboot process of this subsystem but it was cleaned by the update.
I am very sorry that I was not able to reach this situation, even rebooted multiple times three days ago, and waste your time.


Add QueryParamDecoder helpers to work with fallible decoders

I just did
import java.time.ZoneId

val decoder: QueryParamDecoder[ZoneId] = value => QueryParamDecoder[String].decode(value)
  .andThen { str =>
    Validated.catchNonFatal(ZoneId.of(str))
      .leftMap(ex => ParseFailure(str, ex.getMessage))
      .toValidatedNel
  }

to avoid a server-side error on malformed input. As far as I know, there's no better way of doing this. I think that might be a common enough example (interacting with APIs that throw, or return ValidatedNel[ParseFailure, A]) - and would like to suggest adding some helper, like
//in trait QueryParamDecoder[T]
def emap[U](f: T => ValidatedNel[ParseFailure, U]): QueryParamDecoder[U]

This would make the above a bit more concise:
val decoder: QueryParamDecoder[ZoneId] = QueryParamDecoder[String].emap(str => Validated.catchNonFatal(...).leftMap(...).toValidatedNel)

but it would still require the hassle of catchNonFatal + mapping the exception to a ParseFailure + toNel. We could also add a type alias for ValidatedNel[ParseFailure, T] (or a newtype), and provide catchNonFatal on its companion object. The above snippet would now be:
val decoder: QueryParamDecoder[ZoneId] = QueryParamDecoder[String].emap(str => QueryParamParseResult.catchNonFatal(ZoneId.of(str)))

I'd love to hear some feedback about this :)

I'm :+1: on a function like emap.  Is circe your inspiration here?  Any other prior art?  I'd like to get the name right.
Type aliases are something we have historically come to regret.  I'm a slight :-1: on that.
I don't think we're changing any instances, so I'm :-1: on a newtype.  Circe's emapTry looks close to what you're trying to accomplish with the catchNonFatal.

Yeah, circe was part of my inspiration. It also has a type alias for the decoding result.
emapTry looks a bit like what I need, but auto-catching would be even more handy... although I don't need it that often, after all.
BTW in this particular usecase I dropped QueryParamDecoder and went for directly extracting the parameter from the request object.

I just stumbled upon the same problem and would in high favour of adding the non-auto-catching version (can also do a PR). As for the auto-catching, I'm not sure that's a good idea.
Naming: emap is for me bound to Either (as circe's Decoder has it that way and e in front indicates) - though emapTry (circe) adds the Try in the end…maybe emapValidated then and emap for plain Either?

Fixed by #2656.


ko deps

Executables built from go modules retain information about their dependencies in the binary itself. For example, from this repo you can do go build ./ then go version -m ko to see the binary's deps:
ko: go1.16
	path	github.com/google/ko
	mod	github.com/google/ko	(devel)
	dep	github.com/BurntSushi/toml	v0.3.1	h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
	dep	github.com/PuerkitoBio/purell	v1.1.1	h1:WEQqlqaGbrPkxLJWfBwQmfEAE1Z7ONdDLqrN38tNFfI=
	dep	github.com/PuerkitoBio/urlesc	v0.0.0-20170810143723-de5bf2ad4578	h1:d+Bc7a5rLufV/sSk/8dngufqelfh6jnri85riMAaF/M=
...snip

This information is retained in the binary we stuff into the image. You can use crane to extract the binary from a ko-built image, and get this information back:
crane export gcr.io/imjasonh/ko-98b8c7facdad74510a7cae0cd368eb4e@sha256:3f5f306228f7fc1275f774cb9bff9850c5e65694a4e1020c48d9af5f0da25ea1 - | tar -Oxf - /ko-app/ko > ko
chmod +x ko  # tar drops the executable bit :-/
go version -m ko

(see crane recipes.md)
NB: this used to require the image was built with --disable-optimizations, I think this stopped being the case recently, maybe with Go 1.16.
We can package this up into a ko command, e.g., ko deps $img that:

pulls and extracts the binary, assuming a ko-built image (i.e., the only file in /ko-app/)
puts the binary in some tmp dir
chmod +xes it
go version -ms it, possibly just passing any remaining flags to
(best effort) deletes the tmp file

If the image wasn't built with ko, or the binary can't be found, or the binary doesn't contain this information for whatever reason, we'll fail, but over time I expect this information to only become more available over time, and more thorough.
This could be a lightweight alternative to full SBOMs, since the information is in the binary itself, stamped there by the Go build tool which we generally consider to be trustworthy, and not extracted from there and put somewhere else by some other tool. If you're using the default distroless base image (which consumers can tell by the base image annotations, and verify independently if they want), then there's not a lot else to worry about in the image.

PoC: https://github.com/google/ko/compare/main...imjasonh:ko-deps
go run ./ deps gcr.io/imjasonh/ko-98b8c7facdad74510a7cae0cd368eb4e@sha256:3f5f306228f7fc1275f774cb9bff9850c5e65694a4e1020c48d9af5f0da25ea1
/var/folders/bb/l0yfqc6d6kb5zm5f9ktyx0nw0000gn/T/ko985461010: go1.16
	path	github.com/google/ko
	mod	github.com/google/ko	(devel)
	dep	github.com/BurntSushi/toml	v0.3.1	h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
	dep	github.com/PuerkitoBio/purell	v1.1.1	h1:WEQqlqaGbrPkxLJWfBwQmfEAE1Z7ONdDLqrN38tNFfI=
	dep	github.com/PuerkitoBio/urlesc	v0.0.0-20170810143723-de5bf2ad4578	h1:d+Bc7a5rLufV/sSk/8dngufqelfh6jnri85riMAaF/M
...


[BugFix] Fix error in incremental clone introduced by #15935

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes #
Problem Summary(Required) ：

PR #15935 introduced a new mechanism that an incremental clone can fall back to a full clone if there are too many rowsets need to be copied. But the fallback code return a NotFound error rather than OK, this will cause clone to fail.
I0127 00:46:02.271173  7878 snapshot_manager.cpp:112] make primary snapshot tablet:334728 cur_version:65905 missing_version_ranges:65662 timeout:180
I0127 00:46:02.271206  7878 tablet_updates.cpp:2954] get_rowsets_for_snapshot: too many rowsets for incremental clone #rowset:244 #rowset_for_full_clone:1 tablet:334728 #version:1 [65905.1 65905.1@0 65905.1] #pending:0
W0127 00:46:02.271214  7878 agent_server.cpp:308] fail to make_snapshot. tablet_id:334728 msg:Not found: get_rowsets_for_snapshot: too many rowsets for incremental clone #rowset:244 #rowset_for_full_clone:1 tablet:334728 #version:1 [65905.1 65905.1@0 65905.1] #pending:0

This PR fixes this bug.
Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto backported to target branch

[x] 2.5
[x] 2.4
[x] 2.3
[x] 2.2

run starrocks_admit_test

run starrocks_admit_test

run starrocks_admit_test

@Mergifyio backport branch-2.5

@Mergifyio backport branch-2.4

@Mergifyio backport branch-2.3

@Mergifyio backport branch-2.2


workspace_redis_fix

Description
Hi.
I changed redis installation and added enabling redis php extension in workspace container.
Redis extension was not enabled at all.
And I changed redis installation because of this issue
I used James M's answer
Motivation and Context
With this changes in workspace container I can run
php artisan command:some_command_using_redis
without error
Class 'Redis' not found
Types of Changes

[x] Bug fix (non-breaking change which fixes an issue).
New feature (non-breaking change which adds functionality).
Breaking change (fix or feature that would cause existing functionality to not work as expected).

Definition of Done Checklist:

[x] I've read the Contribution Guide.
I've updated the documentation. (refer to this for how to do so).


Cannot Detect Device

SUMMARY
Using latest node-red docker image and simplest possible flow including node-red-contrib-amazon-echo, my Echo Dot Gen 2 does not detect the new device.
ECHO DEVICES
Echo Dot Gen 2
CONFIGURATION

[
    {
        "id": "b086970.b6efa68",
        "type": "tab",
        "label": "Test Amazon Echo Hub",
        "disabled": false,
        "info": ""
    },
    {
        "id": "ab63c24f.c22c3",
        "type": "amazon-echo-hub",
        "z": "b086970.b6efa68",
        "port": "8001",
        "enableinput": true,
        "x":<PHONE_NUMBER>665039,
        "y": 72.00000762939453,
        "wires": [
            [
                "5ed91aba.792fc4"
            ]
        ]
    },
    {
        "id": "5ed91aba.792fc4",
        "type": "amazon-echo-device",
        "z": "b086970.b6efa68",
        "name": "Test Device",
        "topic": "/cmd/test",
        "x":<PHONE_NUMBER>5527344,
        "y": 73.00000667572021,
        "wires": [
            [
                "3c366ba2.471924"
            ]
        ]
    },
    {
        "id": "3c366ba2.471924",
        "type": "debug",
        "z": "b086970.b6efa68",
        "name": "",
        "active": true,
        "tosidebar": true,
        "console": false,
        "tostatus": false,
        "complete": "false",
        "x":<PHONE_NUMBER>195312,
        "y": 73.00000762939453,
        "wires": []
    }
]

CONSOLE OUTPUT

node-red2   |
node-red2   | ><EMAIL_ADDRESS>start /usr/src/node-red
node-red2   | > node $NODE_OPTIONS node_modules/node-red/red.js -v $FLOWS "--userDir" "/data"
node-red2   |
node-red2   | 4 Oct 18:38:51 - [info]
node-red2   |
node-red2   | Welcome to Node-RED
node-red2   | ===================
node-red2   |
node-red2   | 4 Oct 18:38:51 - [info] Node-RED version: v1.0.0
node-red2   | 4 Oct 18:38:51 - [info] Node.js  version: v10.16.3
node-red2   | 4 Oct 18:38:51 - [info] Linux 4.4.132-1075-rockchip-ayufan-ga83beded8524 arm LE
node-red2   | 4 Oct 18:38:52 - [info] Loading palette nodes
node-red2   | 4 Oct 18:38:52 - [debug] Module: node-red-contrib-amazon-echo 0.1.8
node-red2   | 4 Oct 18:38:52 - [debug]         /data/node_modules/node-red-contrib-amazon-echo
node-red2   | 4 Oct 18:38:52 - [debug] Module: node-red-node-rbe 0.2.5
node-red2   | 4 Oct 18:38:52 - [debug]         /usr/src/node-red/node_modules/node-red-node-rbe
node-red2   | 4 Oct 18:38:52 - [debug] Module: node-red-node-tail 0.0.3
node-red2   | 4 Oct 18:38:52 - [debug]         /usr/src/node-red/node_modules/node-red-node-tail
node-red2   | 4 Oct 18:38:56 - [info] Settings file  : /data/settings.js
node-red2   | 4 Oct 18:38:56 - [info] Context store  : 'default' [module=memory]
node-red2   | 4 Oct 18:38:56 - [info] User directory : /data
node-red2   | 4 Oct 18:38:56 - [warn] Projects disabled : editorTheme.projects.enabled=false
node-red2   | 4 Oct 18:38:56 - [info] Flows file     : /data/flows.json
node-red2   | 4 Oct 18:38:56 - [debug] loaded flow revision: 93850d7fe56209be08a6fce2f4d91543
node-red2   | 4 Oct 18:38:56 - [debug] red/runtime/nodes/credentials.load : no user key present
node-red2   | 4 Oct 18:38:56 - [debug] red/runtime/nodes/credentials.load : using default key
node-red2   | 4 Oct 18:38:56 - [debug] red/runtime/nodes/credentials.load : keyType=system
node-red2   | 4 Oct 18:38:56 - [warn]
node-red2   |
node-red2   | ---------------------------------------------------------------------
node-red2   | Your flow credentials file is encrypted using a system-generated key.
node-red2   |
node-red2   | If the system-generated key is lost for any reason, your credentials
node-red2   | file will not be recoverable, you will have to delete it and re-enter
node-red2   | your credentials.
node-red2   |
node-red2   | You should set your own key using the 'credentialSecret' option in
node-red2   | your settings file. Node-RED will then re-encrypt your credentials
node-red2   | file using your chosen key the next time you deploy a change.
node-red2   | ---------------------------------------------------------------------
node-red2   |
node-red2   | 4 Oct 18:38:56 - [info] Starting flows
node-red2   | 4 Oct 18:38:56 - [debug] red/nodes/flows.start : starting flow : global
node-red2   | 4 Oct 18:38:56 - [debug] red/nodes/flows.start : starting flow : b086970.b6efa68
node-red2   | 4 Oct 18:38:56 - [info] Started flows
node-red2   | 4 Oct 18:38:56 - [info] Server now running at http://<IP_ADDRESS>:1880/

##### STEPS TO REPRODUCE
Docker container started using the following docker-compose.yml:

version: '3.7'
services:
  node-red:
    container_name: node-red2

    image: nodered/node-red

    user: root

    volumes:
      - /docker/node-red2/config:/data

    network_mode: host

    restart: unless-stopped

##### ACTUAL RESULTS

Node-Red gui shows Amazon Echo Hub as being "online" but no new devices detected when I initiate a scan either from the Alexa app or the Dot.

What am I doing wrong here?

Thanks

Hi @namirda. Echo will try to connect on port 80, and your Amazon Echo Hub is running on port 8001.

Thanks @datech  - I though the port 80 restriction was only for Gen3 devices?
I have tried restarting the container mapping port 80 on the host to 8001 in the container but still no joy.

be sure you're correctly respecting the map procedure, the instructions has been posted here in some threads, we all are using here this way and works to everybody

Yep, I haven't noticed that you are using Dot v2.
I'm thinking of a few potential issues:
- Node Red instance and Echo Dot are in separate broadcast domains (different networks).
"network_mode: host" configuration will set your Docker container to use your host network.
Can you confirm that your Docker host and the Echo Dot are using the same network?
- Amazon Echo Hub is not accessible by the Echo dot.
Can you confirm that you can open: http://<docker-ip>:<hub-port>/api/description.xml

@datech - thanks for your help...

Yes - docker host and echo dot are both in the same network
Yes - I can access description.xml using curl from the docker host which is headless - and also from my laptop using a browser.

When the Amazon Echo Hub says that it is online, what does that mean exactly??

It just means that the hub is successfully started on the selected port.
To check that the discovery procedure is working you can run the SSDP server in debug mode by setting an env variable DEBUG="node-ssdp:*"
I've used the following commands on my Linux box.
export DEBUG="node-ssdp:*";
node-red

If Echo Dot and the Hub can communicate with each other, you have to find similar log messages on the console
node-ssdp:server Setting LOCATION header "http://<hub-ip>:80/description.xml" on message ID 574436eb7a65d496 +1ms
  node-ssdp:server Sending a message to <echo-ip>:50000 +2ms

chances are your router is blockeing the broadcast ARP, I have lo clue if Echo does reply to ping, but it would be useful to try to ping Echo from your Raspberry, if it replies then your network is ok

@datech - thanks.
I have set the DEBUG environment variable as you suggested. The log file is now very large but I can see the ssdp records which you described:
node-red2   | 2019-10-04T21:12:25.920Z node-ssdp:server Setting LOCATION header "http://<IP_ADDRESS>:8001/description.xml" on message ID f297e63c12a8449b node-red2   | 2019-10-04T21:12:25.920Z node-ssdp:server Sending a message to <IP_ADDRESS>:50000
where <IP_ADDRESS> is the ip of the echo and <IP_ADDRESS> is the ip of the docker host.
I do not see any error messages in the console.
There are a lot of new records generated in the console when I try to discover new devices - so it does look as if the dot and hub are communicating. However discovery still fails.
@Barabba11 - Thanks. My Echo does NOT respond to pings. Does yours?

I haven't tried it, I can't now sorry, anyway they are communicating, so it's not influent. Network is ok

@Barabba11, @datech   - Yes it looks as if the network is probably OK - but there is still no device discovery. What else can be going wrong here?

Having the same issue with Node-Red in docker. I too can access the description.xml.

Sorry, solved my issue reading your Wiki...should have read more :)
https://github.com/datech/node-red-contrib-amazon-echo/wiki/Troubleshooting
Running with --user 0 --network host did the trick.

I have the same issue as @namirda does have it.
It does not matter if my node-red running on port 80 or on 8080 with modified iptables. Is there any solution?

Chances are you not correctly remap the port to 80, or 80 is in use by something else

Can someone who has figured this make a walkthrough showing how they did it. Everyone is talking way over my head. I have no idea where these commands are coming from or going to.

Has it worked one time? Never?
WHich platform are you using? Raspberry?
Are you connected with cable, wifi or both?
If you connect to the IP of your device, on port 80, what is the result appearing?

https://github.com/datech/node-red-contrib-amazon-echo/issues/5
Read this carefully

I am using an UnRaid server. It worked when I had it on a Raspberry Pi.
It has never worked on UnRaid.
My server is connected through a cable and my echo devices are all wireless.
My UnRaid Server is running on <IP_ADDRESS>, NodeRed is <IP_ADDRESS>:1880, if I use <IP_ADDRESS>:80 it takes me to my Unraid Server Homepage

<IP_ADDRESS>:80 it takes me to my Unraid Server Homepage

You got the problem, the port 80 is already in use, you need absolutely to free it from this "Unraid Server Homepage", google to know how to

Alright sweet. Got that taken care of, Unraid Server Homepage moved to port 8080. However, <IP_ADDRESS>:80 doesn't take me anywhere now. "Unable to connect"

have you tried restart? You need to be sure the port 80 will be used from this module, try a netstat -a. To test it open the address of your Unraid server in browser and you will see a 404 error, means the server works. Actually I don't know which is the right address to type to have a proper answer

it's a pity no one here writes the answer...

sudo iptables -t nat -L --line-numbers (if it doesn't say anything about 8083/your port, then it's clear that it doesn't work)
sudo iptables -I INPUT 1 -p tcp --dport 80 -j ACCEPT
sudo iptables -A PREROUTING -t nat -i eth0 -p tcp --dport 80 -j REDIRECT --to-port 8083
For the Node-Red Adapter insert port 8083 at the "Amazon Echo Hub" node and click deploy in the upper right corner and it works or it finds the devices and it is green.
Another time sudo iptables -t nat -L --line-numbers (see if it says 8083, if it does then it should work)
Now the whole thing must be saved permanently if the device is restarted
sudo apt-get install iptables-persistent
sudo bash -c "iptables-save > /etc/iptables/rules"  | or service iptables save |  if the 1 does not work, in any case the problem is the saving

It does not work with most of them because it is not saved permanently and the port forwarding is gone again at the next restart. Therefore save the iptable or port forwarding at the end.

 Deshalb am Ende das iptable bzw. die Portweiterleitung speichern.

I've used the following commands on my Linux box.
export DEBUG="node-ssdp:*";
node-red

@datech - where is this set?  I've confirmed that I can connect to http://x.x.x.x/api/description.xml but am at a loss as to where to go next


ACCUMULO-4424 Start thrift servers immediately on ha components

@ctubbsii @billierinaldi might be interested in this one. I need to write some tests, but I verified that things are working as expected in a local installation.

Just pushed an IT for this change in 2f060a4.

b36d9a8 sends HTTP/503 with the error message instead of propagating the exception.

+1 to the strategy. Haven't checked out the code to test. The test case looks good, though.


Custom dimensions

I am having trouble with specifying custom dimensions.
I do this:
Ti.App.Tracker.trackEvent({
category: "testcategory",
action: "test/trackevent",
label:"testlabel",
value: 1,
customDimension:{
1:Ti.App.getVendorId(),
2:Ti.App.idcliente
}
});
I can see "testcategory", I can see action and label - but I cannot find any custom dimensions in Google Analytics.
Am I maybe mistaken of where I search for them?
PS: I have found more information how to configure custom dimensions. Is the code above correct? Do the keys of "customDimension" array have to be integer or string? Is it necessary to have custom dimensions configured in the project before I can see any input?

Sorry, it all works fine.

@annakozy2011 I am experiencing the same problem. How did you solve it?
Thanks

Sorry, I don't remember now. It was almost a year ago and I have not seen that app for at least half a year.

I have it like this in that app, and according to my comment, seems like it worked back then :
Ti.App.GoogleAnalytics = require('analytics.google');
Ti.App.Tracker = Ti.App.GoogleAnalytics.getTracker(GA_key);
Ti.App.Tracker.setUser({
userId:Ti.App.getVendorId(),
category: "icatalog",
action: "start",
customDimension:{
1:Ti.App.getVendorId(),
2:Ti.App.idcliente
}
});

Thank you @annakozy2011 !
My code looks exactly like yours but my Analytics Dashboard shows nothing...
This is really odd!

Maybe there is some trick in the setup of analytics, but I don't have the password to that account now, nor do I remember how I eventually managed to see it.

I see. It´s been a long time. :)
Thank you for your reply.


rename internals of Grimoire to Grimoire

Honestly, got kind of annoyed with the length of "ForbiddenGrimoire" while adding the Grimoire exhume power. This is to make it more consistent internally.

Unfortunately, we can't update the IDs of cards that have already appeared in a release build without breaking existing save files that contain the card (ie, every wanderer run), so I don't think we can do this one


posibility of a 2.30.9 release for father with less strict docz version dependency

Hi, @PeachScript ,
Issue Description
I noticed that a vulnerabilities is introduced in<EMAIL_ADDRESS>Vulnerability(high severity) CVE-2020-15366 affects package ajv(versions:<6.12.3).
The above vulnerable package is referenced by<EMAIL_ADDRESS>via:
<EMAIL_ADDRESS>➔<EMAIL_ADDRESS>➔<EMAIL_ADDRESS>➔<EMAIL_ADDRESS>➔<EMAIL_ADDRESS>Since<EMAIL_ADDRESS>is referenced by 1,711 downstream projects (e.g., @antv/chart-node-g6 0.0.4 (latest version), titans-react 0.4.26 (latest version), gennlife-doui 0.0.61 (latest version), @cmonelink/components 1.1.8 (latest version), @likone/alarm 1.0.1 (latest version)), the vulnerability CVE-2020-15366 can be propagated into these downstream projects and expose security threats to them via the following package dependency paths:
(1<EMAIL_ADDRESS>➔<EMAIL_ADDRESS>➔<EMAIL_ADDRESS>➔<EMAIL_ADDRESS>➔<EMAIL_ADDRESS>➔<EMAIL_ADDRESS>......
If<EMAIL_ADDRESS>removes the vulnerable package from the above version, then its fixed version can help downstream users decrease their pain.
Given the large number of downstream users, could you help update your package to remove the vulnerability from<EMAIL_ADDRESS>?
Fixing suggestions
In<EMAIL_ADDRESS>maybe you can kindly try to perform the following upgrade :
docz 1.2.0 ➔ 2.3.1;
Note:
docz@2.3.1(>=2.0.0-rc.0) transitively depends on<EMAIL_ADDRESS>which has fixed the vulnerability CVE-2020-15366.
Thank you for your attention to this issue and welcome to share other ways to resolve the issue.^_^

Thanks, father 2.x is no longer maintained, issue will be closed.


Add new features.

Hi @izzisolomon ,
It would be possible to add new features like:

Be able to customize the color of the text and the background of the menu, for example a menu with a dark theme.
Link: https://i1.wp.com/www.androidinterview.com/wp-content/uploads/2014/08/android-option-menu3.jpg
Give the possibility to each element of the menu to have an icon.
link: https://i.ytimg.com/vi/spSvaWcDPOw/maxresdefault.jpg

@Angelk90 The library is using the native android popup menu which doesn't support Icons/different background colors.

@izzisolomon : But I think there will be a way to do it natively, those are native apps.

@Angelk90 there certainly is a way, just not by using the native popup, it can be done by creating a custom view. I may add support for that in the near future.


Change grpc version to 1.4.0.

/cc zhangkun83@

Codecov Report

Merging #381 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #381      +/-   ##
============================================
+ Coverage     91.45%   91.49%   +0.04%
  Complexity      583      583
============================================
  Files            97       97
  Lines          2305     2305
  Branches        208      208
============================================
+ Hits           2108     2109       +1
  Misses          142      142
+ Partials         55       54       -1

Impacted Files
Coverage Δ
Complexity Δ

...a/io/opencensus/trace/export/SpanExporterImpl.java
91.66% <0%> (+1.66%)
6% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57bec53...ce1ed19. Read the comment docs.


docs for radians function

http://package.elm-lang.org/packages/elm-lang/core/latest/Basics#radians
I stumpled on this while trying to implement the Haversine formula for a distance calculator. Looking at the source, it looks like radians is a function that just return whatever float you give it https://github.com/elm-lang/core/blob/14c737397c76ce1ea16c15009943ad56fa9e4b6d/src/Basics.elm#L67
I think this is more of a question than a bug, but can someone elaborate on purpose of this? When would you need something like this? In any case I think it would be helpful to add another line or two in the docs that explain what this is for, because when I stumpled on the description I sure was confused :)

radians : Float -> Float
Convert radians to standard Elm angles (radians).

Sorry if I'm just being obtuse here. That's really not the goal.

@Ahrengot I agree. Shouldn't radians convert from degrees to radians, and furthermore, degrees should convert from radians to degrees ?
There's a semantics issue here. degrees should convert from radians to degrees, but it does the opposite.

I would say its for better self documentation, you could also see them as type annotations, so you have type degrees and type radians
angle = radians 3.14 is more obvious than angle = 3.14

@Gabgab2003 Thanks. Created a PR for the documentation on this.

@ybakos Thank you, hope it gets merged. I like the explanation in the PR :)


Splash page redesign

Includes built with section, blocks alchemy agreement
Add Alchemy (get html snippet from x48)
Add Blocknative

Two options here

Infomercial style overview page

Add section for “built with”

Splash page needs to show useful information that explains simply how the product works

Should probably include some nice images

No more than 4 pages total (this is flexible but use this as guidelines)

Splash

Main overview pane (what does yearn do)

Partners

Built with

Footer (social, links etc)

For any metrics visible on splash we need to make sure the metrics are available before committing

If metrics are not available the overview page is blocked

Figure out what is needed to unblock and make bugs

Need mobile designs for overview page

Simple splash (zapper style)

When wallet is not connected show splash

When wallet is connected show main site when user visits yearn.finance (/vaults)… zapper does /dashboard

Allow user to “log out” to go back to the splash page

Splash page shows very basic information on one page with a button to connect wallet (see zapper)

Splash page links to documentation, faq, partners

Intentions here are:

Splash page does not get in the way for users who have aleady logged in

This is a major annoyance for sushi/uniswap/compound

Imagine if zapper made you click “enter” every time you viewe their site

New users are exposed to useful basic information

Out of scope for v2, will be included in v3


Azure Automation also wanted to be compared.

Hi Team,
In this page, could you also compare Azure Automation with Logic Apps etc?
In my scenario, I was confusing which solution to use when I automate Azure SQL Database related operation (like daily bulk insert from Azure Storage).
Thanks for the consideration!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 82ee9751-961d-7109-63d6-813b1862c632
Version Independent ID: 583d1b2f-9c1a-3580-9d14-37bb551eaf44
Content: Integration and automation platform options in Azure
Content Source: articles/azure-functions/functions-compare-logic-apps-ms-flow-webjobs.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

@yutaro113 Thanks for the feedback! I have assigned the issue to the content author to investigate further and update the document as appropriate.

Thanks @yutaro113 for the feedback. We actually have an article specifically for comparison of automation services, which we do link to: Choose the automation services in Azure. This article does a much better automation-specific comparison. I'll try to make the link more pronounced.


Bug when creating new teams from clean install

I believe this is the issue that Christian Martorella reported

Yes, that is correct.  But now I am experiencing a different error:

When I click New team, a new team with a Random name is created (Team-xlsd)
In the team page, there is an input (Team Name:)  that seems to be supposed to allow you to change the name with a save button. If I  introduce a new name and click save, nothing happens. I get a "File saved ok" in a green tag, but the team name stays the same (Team-xlsd)

Any idea where is the error?

Yeah, I think I had the same error yesterday. Let me take a look at it

Btw a way to go around this is to edit the files directly on the data folder (which allows you to name them better).
The API already supports renaming (need to wire that in the UI)

@laramies can you try now?
It's not perfect but it should at least create the new team using the UI
here it is working in action on the QA server (http://<IP_ADDRESS>)

on the projects page http://<IP_ADDRESS>/view/project/bsimm

click on the 'new team' link, which should lead to this page:

go to edit tab

change the title

open the raw tab to confirm it was changed

change a couple mappings

confirm they were saved

confirm they shown up in the 'table view'

and on the 'radar' view

latest version as just deployed to http://<IP_ADDRESS>/ doesn't show this issue any more
@laramies can you try again?


Overview

I spotted a missing link so I read through the pages again and made a few small changes. Should be very quick to review

@robertswh Have reviewed the changes, all looks good.

fixes #31


Minimise FSharp.Core version

proj-info currently uses FSharp.Core at a very late version, 8.0.400. Could we instead use the earliest possible version, to maximise compatibility with consumers? (I'd raise the PR myself except I'm waiting for https://github.com/ionide/proj-info/pull/211 to land, because I can never get Paket to work right.)

Done - the libraries that don't have a direct FCS dependency target 6.0 now, the ones that do are in sync with whatever version of FCS they may use.


"toolbar" is not scrollable

Sometimes, the share button (the last one on the "toolbar") is partly obscured/completely hidden, and there's no way to scroll horizontally to use it.
Please see attached screenshot (pinned tweet vs tweet below)

apparently, just the toolbar is scrollable, rather than the entire tweet "card". never mind.


Prefix validation is inconsistent for OBOfoundry ontologies not in identifiers.org

In the case of MONDO, the validity checks are self-contradictory in that some checks are looking for the MONDO: prefix embedded in IDs whereas others expect it not the be there so some tests fail in either case.

test_valid_mappings expects no prefix in ID whereas
test_normalized_identifiers expects the prefix to be embedded in the ID.

In this particular case, MONDO doesn't appear in identifiers.org so the expectation to have the namespace embedded in the ID wouldn't have come from there, so should probably be expected to not be embedded.

Generalizing the issue above, the problem is that in this code: https://github.com/biopragmatics/biomappings/blob/master/src/biomappings/utils.py#L140-L155:
    resource = bioregistry.get_resource(prefix)
    if resource is None:
        raise InvalidPrefix(prefix)
    if prefix not in {"ncit"}:
        norm_identifier = resource.miriam_standardize_identifier(identifier)
        if norm_identifier != identifier:
            raise InvalidNormIdentifier(prefix, identifier, norm_identifier)
    miriam_pattern = resource.miriam.get("pattern") if resource.miriam else None
    if not miriam_pattern:
        pattern = resource.get_pattern_re()
    else:
        pattern = re.compile(miriam_pattern)
    if pattern is not None and not pattern.match(identifier):
        raise InvalidIdentifierPattern(prefix, identifier, pattern)

we have a corner case where resource.miriam_standardize_identifier checks if the resource has an obofoundry attribute, and if it does, it assumes the prefix has to be in the ID. However, if that check passes, and we don't raise an error, the function keeps going and since miriam_pattern is None, if gets resource.get_pattern_re() which returns resource.pattern if it's set, and in case of MONDO it is set.


Audio logs

Produces logs like media> start something.mp3
Left the filename extension so it's easier to distinguish between audio and video.

good to go after comments

@ctsims addressed comments, should be all set


Renamed output files

Hi, I thought some more consistent output filenames would be nice.
What would you think about

co2footprint-<timestamp>.txt -> co2footprint_trace_<timestamp>.txt
co2footprint-<timestamp>.summary.txt -> co2footprint_summary_<timestamp>.txt
co2footprint-report-<timestamp>.html -> co2footprint_report_<timestamp>.html
?

Would it make sense to make use of the Nextflow trace wording? Then it would be somehow analogous to the nf-core execution_report_* and execution_trace_* naming.
If yes, then I would also rename the variable names to avoid confusion

OK, ready for review. I also added using a timestamp to the example custom config file.


move dialog settings to another script to fix exported game issues

There's a problem when you try to export game and launch it, you'll get a grey screen. In the log there's errors about  Unknown class: "EditorPlugin" presumably because editor classes aren't exported. The problem is that escoria-dialog-simple plugin exports it's class name to other scripts which get settings via it. So I've moved settings to separate script that extends Resource same as ESCProjectSettingsManager. It fixes the problem.

Thanks for this. I have a couple comments, but first, addons/escoria-dialog-simple/esc_dialo_simple_settings.gd has a typo in the filename (I'm sure you can see it now).
The issue you bring up is valid but also highlights something I think we overlooked: The core has an explicit reference to a class located in a plugin, which is not a good idea, e.g. what if someone wants to implement their own dialog manager?
@StraToN @balloonpopper can you see any issues or challenges in moving ESCDialogPlayer (and its state machine) into the Simple Dialog addon? One thing we'll need to do is make sure that ESCProjectSettingsManager is somehow exposed so that the Simple Dialog addon can get at things like the speech folder, speech file extension, etc.

I fixed typo and whitespaces, also I forgot to commit changes to project file, now it's there.

The issue you bring up is valid but also highlights something I think we overlooked: The core has an explicit reference to a class located in a plugin, which is not a good idea, e.g. what if someone wants to implement their own dialog manager?

We have two solutions:

either define a hook mechanism for any user to personalize some parts of the dialog manager. But then we'd need to define what hooks would be necessary for each needs.
or allow a plugin to override the default behavior. Which would still require to design a clear API for this purpose.

@StraToN @balloonpopper can you see any issues or challenges in moving ESCDialogPlayer (and its state machine) into the Simple Dialog addon? One thing we'll need to do is make sure that ESCProjectSettingsManager is somehow exposed so that the Simple Dialog addon can get at things like the speech folder, speech file extension, etc.

ESCProjectSettingsManager is a static class filled with static const values, so it can be used from anywhere, including a plugin.
I am a bit mixed about the idea of moving ESCDialogPlayer out of core. That would mean that any plugin that needs to use it will have to include it (as-is or edited for their own purpose). Again in that case I'd go in favor of some mechanism allowing one to override the default ESCDialogPlayer behavior if needed.

Let’s discuss further on Discord when you have time. On Feb 15, 2023, at 10:59 AM, Julian Murgia @.***> wrote:
The issue you bring up is valid but also highlights something I think we overlooked: The core has an explicit reference to a class located in a plugin, which is not a good idea, e.g. what if someone wants to implement their own dialog manager?
We have two solutions:
either define a hook mechanism for any user to personalize some parts of the dialog manager. But then we'd need to define what hooks would be necessary for each needs.
or allow a plugin to override the default behavior. Which would still require to design a clear API for this purpose.
@StraToN @balloonpopper can you see any issues or challenges in moving ESCDialogPlayer (and its state machine) into the Simple Dialog addon? One thing we'll need to do is make sure that ESCProjectSettingsManager is somehow exposed so that the Simple Dialog addon can get at things like the speech folder, speech file extension, etc.
ESCProjectSettingsManager is a static class filled with static const values, so it can be used from anywhere, including a plugin.
I am a bit mixed about the idea of moving ESCDialogPlayer out of core. That would mean that any plugin that needs to use it will have to include it (as-is or edited for their own purpose). Again in that case I'd go in favor of some mechanism allowing one to override the default ESCDialogPlayer behavior if needed.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: @.***>

@skogach I sincerely apologize for the time we took for reviewing and merging this PR. Thanks a lot!
Fixes https://github.com/godot-escoria/escoria-issues/issues/354
Closes https://github.com/godot-escoria/escoria-demo-game/pull/684


fix project url in setup.py conf

This lib works on windows?
I did not see any mention in pypi trove classifiers on setup.py, of which operating system are supported.
Recently discovered a CI Server on Windows( http://www.appveyor.com/ ). It works much like the travis ci.
https://pypi.python.org/pypi?%3Aaction=list_classifiers


COLMO 燃气热水器气量统计和水量统计

设备类型及型号 (或SN)
Gas Water Heater 511CB216 (0), 0000E3211511CB2161A051XXXXXXXXXX
新功能的描述
美的美居 app 中含气量统计及水量统计，请求 HA 更新相关数据采集。

插件 zip：
0xE3_511CB216.zip

抓包请求接口：https://mp-prod.smartmidea.net/mas/v5/app/proxy
请求数据（出于隐私隐去6位id）：

{
  "msg": "dayReportV2",
  "params": {
    "applianceId": "192414534XXXXXX",
    "authUserId": "52XXXXXX"
  }
}

返回数据（出于隐私隐去6位id）：

{
  "retCode": "0",
  "desc": "success",
  "result": {
    "applianceId": "192414534XXXXXX",
    "hotwaterUse7": "178.6,39.9,180.4,138.3,82.7,55.4,37.5",
    "hotwaterUsem": "176.8,41.7,110.1,225.4,31.9,137.2,74.2,100.6,39.2,137.7,25.4,176.1,150.5,152.9,39.1,35.3,94.9,1.9,122.0,97.7,58.4,228.1,22.5,9.0,178.6,39.9,180.4,138.3,82.7,55.4,37.5",
    "hotwaterUsey": "2760.0,2292.1,1812.5,1673.8,1720.9,1717.6,1760.1,1791.9,2030.6,2492.3,3090.0,2447.4",
    "gasUse7": "0.9,0.2,0.9,0.7,0.4,0.3,0.2",
    "gasUsem": "0.9,0.2,0.5,1.0,0.1,0.7,0.3,0.5,0.2,0.7,0.1,0.8,0.7,0.7,0.2,0.2,0.4,0.0,0.6,0.5,0.3,1.1,0.1,0.0,0.9,0.2,0.9,0.7,0.4,0.3,0.2",
    "gasUsey": "13.1,10.2,6.8,5.3,4.5,3.8,3.6,4.2,6.2,9.2,14.3,11.8",
    "durTime7": "31.5,5.7,28.7,22.3,12.7,7.8,6.1",
    "durTimem": "29.5,6.3,25.1,40.4,5.6,23.0,12.1,16.0,5.6,27.8,5.0,30.1,25.0,25.7,5.6,5.2,17.2,0.3,20.9,16.2,9.3,38.2,3.2,1.4,31.5,5.7,28.7,22.3,12.7,7.8,6.1",
    "durTimey": "505.8,454.8,362.7,326.7,323.1,364.1,387.6,376.8,383.0,449.3,544.0,407.9",
    "wInsertDt": "2024-01-28 08:52:04",
    "date": "2024-01-27"
  }
}

同求。使用抓包的参数重新请求，提示sign 不正确，也不知道这个sign的计算方法是啥。


Improper topN caching when sorting by postaggregator

When a topN is sorting by a postaggregator, the postaggregator name is part of the query cache key but the definition is not. But, the postaggregator should be part of the cache key too, since it's used to determine which result rows to keep for a particular segment in the cache. If the postaggregator is redefined but keeps the same name, the query improperly uses previously cached results.
I think fixing this for real will require adding a getCacheKey method to PostAggregators.
If we want to hold off on that until 0.10.0 then we could work around it in the meantime by disabling caching for any topN query that sorts on a postaggregator. But this has a performance cost that could hit more people than the bug does.

Is this a "forever" kind of bug, or a regression?

@drcrallen forever

Disabling caching seems a little heavy handed unless there's a way to enable the old behavior where postagg sorted topN's can be cached.
I suggest making this a 0.10.0 ticket with the solution of adding getCacheKey to post aggregators, and having any "temporary" solution be a different ticket.

+1 on disabling caching on topNs sorted by post agg and fixing as part of 0.10.0

One more way to fix this in 0.9 can be to add another Interface CacheablePostAggregator that defines getCacheKey and have all the internal post aggs impls use it. Now in the query If the post agg is cacheable we cache the query otherwise its not cached. I think this will solve the issue without impacting performance for most of the use cases.
Only performance impact will be for users who have defined custom post aggs via extensions, which they can work around by modifying their impls to make it cacheable.

That solution sounds workable @nishantmonu51. What do you think about a Cacheable interface instead, so people can do implements PostAggregator, Cacheable? This way, in 0.10.0 if we make the PostAggregator interface extend Cacheable, old source files will continue to work, and we won't have an unused "CacheablePostAggregator" interface floating around.

Tagging incompatible since odds are we will fix this by changing PostAggregator.

Thanks @gianm and @nishantmonu51 for the guide. I'm working in this.

@jihoonson since 0.10.0 allows incompatible changes, imo the best way to address this is just adding a getCacheKey method to the PostAggregator interface.

@gianm, thanks. I'll focus on that point.


ISPN-13233 configuration doc updates

https://issues.redhat.com/browse/ISPN-13233
The diff is probably a little scary: +9,376 lines. But this PR overhauls the Configuration Guide with the following changes:

Adds clustered cache mode diagrams from an illustrator for both community and downstream.
Adds diagram for off-heap memory (JVM memory space) and removes the bucket array with address link pointers. Dan and Wolf both agreed in review it was too low level.
Re-organizes cache mode assemblies so topics map to the correct information type: concept, task, reference.
Removes broken links and extraneous information. Some of the content for cache modes
s/replication mode/replicated caches and s/distributed mode/distributed caches
Includes an editing pass for local and clustered cache mode topics.
Changes several headings to improve readability and scan-ability. (More than three words in titles, include keywords that match configuration parameters...)
Changes headings to sentence casing.
Updates to procedures for configuring eviction, expiration, and off-heap memory.
Added configuration examples under discrete second level headings to include XML,JSON,YAML, and ConfigurationBuilder.

Did you really mean to add documentation/src/main/asciidoc/titles/configuring/configuring.html  ?

No, I'm not entirely sure how that got in there. I have gitignore configured for .html files. Will remove, thanks for the catch.

@oraNod great work!

Merged


[HOLD for payment 2024-07-24] [$250] QBO - "Required" remains enabled when all tags are disabled

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number:  1.4.83-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team
Issue found when executing PR https://github.com/Expensify/App/pull/42972
Action Performed:
Precondition:

Account is connected to QBO

Go to staging.new.expensify.com
Go to workspace settings
Go to Tags
Click Classes
Toggle on Required
Select all tags
Disable all tags

Expected Result:
"Required" will be disabled and locked when all tags are disabled (same behavior when all categories are disabled)
Actual Result:
"Required" remains enabled when all tags are disabled
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/ffbee882-3d37-4f3e-829a-0d358b45d4e0
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01f4ad944ec831b5b7
Upwork Job ID:<PHONE_NUMBER>150271805
Last Price Increase: 2024-06-13
Automatic offers:

akinwale | Reviewer | 102740102
Krishna2323 | Contributor | 102740104

Issue OwnerCurrent Issue Owner: @akinwale

@cead22  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@Krishna2323's proposal works here since it follows the same method of an already existing implementation for categories.
🎀👀🎀 C+ reviewed.

Contributor: @Krishna2323 paid $250 via Upwork
Contributor+: @akinwale paid $250 via Upwork.
@akinwale plz complete the BZ checklist below?
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@] Determine if we should create a regression test for this bug.
[ ] [@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@BZ] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[x]  [@] The PR that introduced the bug has been identified. Link to the PR:
[x]  [@] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[x]  [@] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression. The specific functionality was not implemented.

[x]  [@] Determine if we should create a regression test for this bug.
[x]  [@] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps
Precondition: Account is connected to QBO

Launch Expensify.
Navigate to the settings for the workspace connected to QBO.
Navigate to Tags.
Toggle the Required switch.
Select all tags.
Disable all tags.
Verify that the "Required" switch is disabled and locked when all tags are disabled.

Do we agree 👍 or 👎?

Thanks @akinwale , test case created!
https://github.com/Expensify/Expensify/issues/416507


⚠ Fortnite has degraded performance

In 81c98e1, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1604 ms

Resolved: Fortnite performance has improved in 7cba4c2.


resolution not set

When running container via docker run -e RESOLUTION=1920x1080 dorowu/ubuntu-desktop-lxde-vnc the resolution stays 1024x768 (shown in settings) even from fresh container.
I tried to connect from VNC client (vinagre) and HTTP interface, same resolution on both.
Is there any additional setting ?

Thank you  very much ! Will try it once its pushed.


Some elements turning into None in html output with md_in_html

import markdown
md = markdown.Markdown(extensions=["markdown.extensions.md_in_html"])
test = """

time
amplitude

0
0
0

"""
print(md.convert(test))

Which gives me -

None

None
time
amplitude

0
0
0

Rather than

time
amplitude

0
0
0

Which is what I'm expecting - note the extra None before the
 in
 and in the first header.

Yup, looks like another bug in the new HTML parser, unfortunately. Looks like we need a None check somewhere before inserting some text content.

I think I may have a fix.

Here is a simpler case:

foo

Note that the text content of the second
 is empty. Presumably, Element.text is None rather than an empty string as it should be. We should probably just address this in the serializer to avoid None in any output.

@facelessuser if you have a fix, go for it. Although we should probably do something with the serializer as well.

@waylan I'm not sure what you mean in regards to the serializer.

I've created pull #1050. We can discuss additional changes there if more than what I'm doing needs to be addressed.

@waylan I'm not sure what you mean in regards to the serializer.

My thinking was that there could be any number of other situations in which the text of an Element is None. We should never render that as None. However, I have since looked at the serializer and see that every call to write(text) is nested within a if text check, so the serializer already accounts for this.
It would seem that the issue is isolated to parsing the content of an Element as Markdown, which your fix addresses. So nevermind.


Unable to find a specification for GoogleAds-IMA-iOS-SDK (= 3.18.4) depended upon by RNBitmovinPlayer

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
Unable to find a specification for GoogleAds-IMA-iOS-SDK (= 3.18.4) depended upon by RNBitmovinPlayer
Expected Behavior
Install pods for RNBitmovinPlayer
Steps To Reproduce
yarn add bitmovin-player-react-native
cd ios
# Bitmovin pods source url
source 'https://github.com/bitmovin/cocoapod-specs.git'
What platform(s) are you experiencing the issue on?

[ ] Android
[ ] Android TV / Fire TV
[x] iOS
[ ] tvOS

Player React Native SDK version
0.64.0
Device
IOS
Environment
"react": "17.0.1",
"react-native": "0.64.0",
IOS: '14.0'
Stream URL (Optional)
No response
Additional information / Code snippets / Screenshots

Hi @IamMasterWayne
Just a quick note to confirm whether you received our previous reply and did this resolve your issue?
Best regards,
James

Hi @IamMasterWayne  Since we have not heard back from you on this question we will close this out and assume our guidance has resolved your issue. if you are still having issues please do raise a ticket through you Bitmovin support Dashboard


makeTestSuite improvements

[x] modules to be exported as a static config without using makeTestSuite.
[x] focus on a mask file by giving ! to the path to the mask.

[ ] allow to pass path to the result without extension.

modules to be exported as a static config without using makeTestSuite.
not feasible


Add tests for /sparql and /ldf endpoints and leveldb serialization

More tests are needed across the entire API.

Done - released in v4.0.1


Restrict deployment for normal user

I'm closing this issue, because tracking features will be moved to GitHub discussions. Github issues will be only for bugs.
Version 4 is in full focus. v3 related issues will be closed, if it is not a critical bug.
Thanks for your understanding.


Support more wallet

Such like: TokenPocket, ImToken etc...

Does it mean creating more in this folder
/packages/assets/src/wallets

Does it mean creating more in this folder
/packages/assets/src/wallets

and packages/wagmi/src/wallets

/packages/assets/src/wallets directory contains the fundamental information about wallets, and it includes wallet information for any blockchain.
packages/wagmi/src/wallets directory contains the WalletFactory that has been adapted for Ethereum, based on wagmi, and is used to construct a Wallet.
You can start by adding the basic information in /packages/assets/src/wallets. As for the implementation of WalletFactory in wagmi, it needs to be thought through carefully.

/packages/assets/src/wallets 这个里面是钱包的基础信息，不管什么链的钱包信息都写在里面。
packages/wagmi/src/wallets 这个里面是适配以太坊后基于 wagmi 扩展的 WalletFactory，用于构造出 Wallet。
可以先补充 /packages/assets/src/wallets 里面的基础信息，至于 wagmi 中的 WalletFactory 如何实现还要再好好想一下。

https://github.com/ant-design/ant-design-web3/issues/399#issuecomment-1869837134

我来收集这些信息吧，TP, ImToken, OKX

For support more wallet with WalletConnect, I have a idea about it: https://github.com/ant-design/ant-design-web3/issues/414


Improve wle reg/unreg robustness

When RegisterWorkload fails(maybe workloadgroup not exist), close the stream and make retry originated from sidecar. This is to make istiod stateless in this case.

use patch instead of update for unregister

make connect/disconnect time readable

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
4f64b70a2b12610c5530b4817f763c97b4e57aaf
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
4f64b70a2b12610c5530b4817f763c97b4e57aaf
link
/test release-notes_istio

unit-tests_istio
4f64b70a2b12610c5530b4817f763c97b4e57aaf
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

lgtm except for using Patch in the unregister flow. That's probably what's failing the test.

The ut failure is because the time format precision is not enough.  Not related to patch

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
4f64b70a2b12610c5530b4817f763c97b4e57aaf
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
844a4f9a37c7ca69e7e5a6c3558219bd1d46c23f
link
/test integ-ipv6-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

unit-tests_istio
4f64b70a2b12610c5530b4817f763c97b4e57aaf
link
/test unit-tests_istio

integ-ipv6-k8s-tests_istio
844a4f9a37c7ca69e7e5a6c3558219bd1d46c23f
link
/test integ-ipv6-k8s-tests_istio

integ-security-k8s-tests_istio
844a4f9a37c7ca69e7e5a6c3558219bd1d46c23f
link
/test integ-security-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest

The race still stands.. when disconnecting and reconnecting to a different pilot, we may end up un-setting the label.. we need to use update on unregister

The race still stands.. when disconnecting and reconnecting to a different pilot, we may end up un-setting the label.

I do not see any bad result, the "istio.io/disconnectedAt" is just a indication the latest disconnect timestamp. When it reconnects to a new pilot,  this annotation is always kept, and it does not influence the cleanup either

The delayed cleanup logic checks if we have the controller annotation set. That patch will unset that label.

The delayed cleanup logic checks if we have the controller annotation set. That patch will unset that label.

Hmm, you mean "istio.io/workloadController".

Yes. Eventually we won't need to worry about that.. we've talked about doing a heartbeat based implementation that won't require it.  It handles an edge case where istiod crashes and the associated proxy never re-connects, we'll have a hanging WorkloadEntry. See a comment from Shriram in the design doc if you're curious.
As far as this PR is concerned, we do use the workloadController annotation to decide whether or not to cleanup and use it to indicate that the WorkloadEntry has its associated proxy still connected to some istiod instance.

Yeah, Let me fix it. Should be easy, we can check if this wle belongs to me, i will do cleanup. Otherwise, leaves it.

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
5d9ecd2656b0e6e1d284435c08a746be048283d8
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
5d9ecd2656b0e6e1d284435c08a746be048283d8
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
5d9ecd2656b0e6e1d284435c08a746be048283d8
link
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following tests failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
5d9ecd2656b0e6e1d284435c08a746be048283d8
link
/test integ-multicluster-k8s-tests_istio

unit-tests_istio
5d9ecd2656b0e6e1d284435c08a746be048283d8
link
/test unit-tests_istio

integ-pilot-k8s-tests_istio
5d9ecd2656b0e6e1d284435c08a746be048283d8
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-pilot-k8s-tests_istio
a8419432b9f82576434e5d7b683093f6efc59d75
link
/test integ-pilot-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-k8s-tests_istio

@hzxuzhonghu: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

integ-multicluster-k8s-tests_istio
a8419432b9f82576434e5d7b683093f6efc59d75
link
/test integ-multicluster-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


Add multi-language (internationalisation and localisation)support

Add multi-language (internationalisation and localisation)support using I18next and react-i18next

Fixed as part of PR #109

Fixed as part of PR #109

Oh my bad, I also worked on the same


Issue using chai-enzyme alongside chai-jquery

The root of the problem appears to stem from the fact that chai-jquery uses checked as a property:
expect($(node)).to.be.checked;

While chai-enzyme implements it as an assertion method:
expect(wrapper).to.be.checked();

If I call chai.use with chai-jquery first, chai-enzyme chokes while trying to add the checked assertion (chaiWrapper.addAssertion(checked, 'checked')):
Uncaught TypeError: Cannot read property 'is' of undefined
If I call chai.use with chai-enzyme first, chai-jquery overwrites the checked assertion as a property.
Any ideas on how to make them play nice together?

noop matchers are a huge antipattern. Could we convince chai-jquery to make a breaking change to make that be a function matcher?
They don't even have to make it breaking - they could make the getter do the assertion, and return a noop function that could be invoked.

i have push access to chai-jquery and can do the change and release another major version...
...however, it seems pointless to tackle those specific cases, since we are planning to rework the entire chai.js plugin system... timing is unclear but @keithamus might have an idea
until then I will suggest to implement a workaround... an assertion that overwrites both jquery's and enzyme's checked and invokes the necessary code depending on the input
otherwise it simply feels like treating the symptoms and not the underlying cause

since we are planning to rework the entire chai.js plugin system... timing is unclear but @keithamus might have an idea

Timeline for this is many months away. Maybe we will have it by end of this year.

until then I will suggest to implement a workaround... an assertion that overwrites both jquery's and enzyme's checked and invokes the necessary code depending on the input

As unpleasant as this might be, it sounds like the easiest workaround IMO.

They don't even have to make it breaking - they could make the getter do the assertion, and return a noop function that could be invoked.

We tried doing this in chai core. Suffice it to say that it did not end well and we reverted it pretty quickly.

otherwise it simply feels like treating the symptoms and not the underlying cause

This issue highlights a failing in the current chai plugin system. We should absolutely (and are planning to) fix this, but it will take a long time. I don't have an answer for the best workaround for now - sorry 😞

when you rework it, can you prevent noop function matchers? It's a hugely bad pattern to use, and it makes mocha unusable in ES3 environments (browsers many of us still have to support).

@ljharb I don't want to hijack this thread, so I'll just say we have an issue (https://github.com/chaijs/chai/issues/585) which details what the new plugin interface will look like. Plugins will be abstracted away from decisions like property based assertions, and it will be determined by interface.

Hi guys, it's been a while and I guess the chai plugin system wasn't updated yet. But, can anyone post some feasible solution or workaround or hack to solve this issue meanwhile?
In my case, some of my modules have unit tests for jQuery based UI and another for React based, so if I only get an idea how to initialize chai per module then I would use chai-jquery and chai-enzyme independently. Although it seems if I call chai.use once the plugin stays there forever until I restart the browser. I couldn't figure out a way to initialize chai within a module scope. Is there a way to do so?


[AIRFLOW-2617] add imagePullPolicy config for kubernetes executor

Make sure you have checked all steps below.
JIRA

[ ] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-2617

Description

[ ] Here are some details about my PR, including screenshots of any UI changes:
I think this configuration of imagepullPolicy is required for kubernetes executor. When the newer airflow image of the work node is built, it needs to be configured by configuring imagepullpolicy=always

worker_container_repository = airflow
worker_container_tag = latest
worker_container_image_pull_policy = Always

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #3500 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3500   +/-   ##
=======================================
  Coverage   77.14%   77.14%
=======================================
  Files         203      203
  Lines       15123    15123
=======================================
  Hits        11667    11667
  Misses       3456     3456

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f4d681...85993ef. Read the comment docs.


Add RuboCop testing

Adds rubocop to standardize syntax
Let me know if there is anything you don't agree with

Things I don't agree with:

Removal of trailing commas. I prefer them as they make diffs easier to read through when items are added to arrays and/or hashes.
%w() over %w[]. Using brackets makes it obvious (or at least more so) that one is dealing with an array than parentheses does.
backticks over %x(). This might be a weird one, but when writing bash scripts I use $() over backticks as backticks are considered legacy, see SC1077 and SC2006.
Spaces before/after {} for one-line hashes. Don't really see the benefit of adding spaces?
Opening/closing {} for method calls where they're actually not needed. Very much a personal preference without any real motivation for it, but I prefer to have them as it's appealing :).

I'd also prefer if each "rule" change had its own commit as it would make it easier to discard certain changes.

Removal of trailing commas. I prefer them as they make diffs easier to read through when items are added to arrays and/or hashes.

This was inconsistent throughout so i picked one, will force a trailing comma

%w() over %w[]

This will affect all % shortcuts, not just %w

backticks over %x()

The 2 links you mentioned are on the shell side, not ruby side

Spaces before/after {} for one-line hashes

forces consistency, i can force Style/SpaceBeforeBlockBraces either way

Opening/closing {} for method calls where they're actually not needed.

Can you elaborate on this?  not following what you are referring too
Hash.new vs {}?

I'd also prefer if each "rule" change had its own commit as it would make it easier to discard certain changes.

Thought about it, but sometimes a line is affected by several rules so its hard to revert a commit in the middle

This was inconsistent throughout so i picked one, will force a trailing comma

Ah :)

This will affect all % shortcuts, not just %w

That's unfortunate :/.

The 2 links you mentioned are on the shell side, not ruby side.

I know, which is why I said it was weird :). I don't agree with the motivation for using %x() though, and would prefer %x|<command>| over `<command>`.

forces consistency, i can force Style/SpaceBeforeBlockBraces either way

Not really sure what this means? Is there a rule for forcing spaces before block braces but not for hashes? If so that sounds fine.

Can you elaborate on this? not following what you are referring too
Hash.new vs {}?

Sure. What I was referring to was method calls as:
opts[:env_path] = value_for_platform_family({
  'debian' => '/etc/default/kafka',
   'default' => '/etc/sysconfig/kafka',
})

Whereas the rubocop rules suggests that the {} should be stripped. Does that make sense?

That's unfortunate :/.

scratch that... looks like Style/PercentLiteralDelimiters allows config per % shortcut, force %w to be []? or stay consistent with everything else with ()

I know, which is why I said it was weird :). I don't agree with the motivation for using %x() though, and would prefer %x|| over <command>.

will look more at this

Not really sure what this means? Is there a rule for forcing spaces before block braces but not for hashes? If so that sounds fine.

I can force a space or no space, (actually the cop is Style/SpaceInsideBlockBraces)
Will look more if i can only force inside blocks and not hashes

Whereas the rubocop rules suggests that the {} should be stripped. Does that make sense?

Gotcha, this is Style/BracesAroundHashParameters.  It suggests removing them since they are redundant.

scratch that... looks like Style/PercentLiteralDelimiters allows config per % shortcut, force %w to be []? or stay consistent with everything else with ()

Right now I'm leaning towards having anything that creates arrays/lists use [] and use () for the rest. Including %x(), so there doesn't have to be some weird special case for that :).

Gotcha, this is Style/BracesAroundHashParameters. It suggests removing them since they are redundant.

Yeah. On second thought I don't really have a strong preference for this, so it's okay to include that rule (i.e. remove the redundant braces).

Cool, thanks for all the feedback! i will work on updates today

The the spaces after { and before } i can do a couple different things

Force no spaces for both hashes and block params
Force no spaces for hashes and no space after { in a block but a space before } in a block

The way the SpaceInsideBlockBraces cop works, is no space for everything, or spaces for everything except the { of a block

Besides the formatting in the last comment, i think i addressed the feedback

@mthssdrbrg any further thoughts?

addressed all feedback

You want me to squash the commits or are you good with the history?

I'm good with the history, and I was hoping to merge this yesterday but I wanted to go through the changes one more time but ran out of time, will get to it tonight.
Thanks a lot for the contribution (and your patience!) @shortdudey123.

Cool and no problem! :)

Merged in 584b40e9a6474012b8ac9a6a0afe4e2236462f78.


DataSet: allow hiding values by low value-base

for example: hide all values of a variable that have less than 30 counts
give option to add a weight and look for weighted counts

handled by Chainmanager? or expand rules in meta?

minimize redundant aggregation processing
conditions get lost while saving meta?

done!


MissingPluginException(No implementation found for method getAll on channel flutter: plugins.flutter.io/shared_preferences)

I'm trying to access the shared preferences through a service's callbackHandler but my app crashed with this exception **

MissingPluginException(No implementation found for method getAll on channel flutter: plugins.flutter.io/shared_preferences)

**

My Code Snippent

void backgroundMain() {
WidgetsFlutterBinding.ensureInitialized();
startmooding();
}
void callService(){
var channel = const MethodChannel('com.xxxx/xxxx');
var callbackHandle = PluginUtilities.getCallbackHandle(backgroundMain);
channel.invokeMethod('startService', callbackHandle.toRawHandle());
}
void startmooding() async{
String ass;
Stream.periodic(Duration(seconds: 1)).listen((_) async {
await SharedPreferences.getInstance().then((SharedPreferences sp) {
ass = sp.getString("assets");
print(ass);
});
if(ass != null)
{
bubbleOverlay.openVideoBubble(ass,
startTimeInMilliseconds: 00000, controlsType: ControlsType.STANDARD);
print("startOverlay");
}
});
}
2. flutter doctor
$ flutter doctor -v
[√] Flutter (Channel stable, 1.22.0, on Microsoft Windows [Version 10.0.19041.572], locale en-US)
• Flutter version 1.22.0 at C:\Users\ThinkPad\Downloads\flutter
• Framework revision d408d302e2 (5 weeks ago), 2020-09-29 11:49:17 -0700
• Engine revision 5babba6c4d
• Dart version 2.10.0
[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at C:\Users\ThinkPad\AppData\Local\Android\Sdk
• Platform android-30, build-tools 30.0.2
• ANDROID_HOME = C:\Users\ThinkPad\AppData\Local\Android\Sdk
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
• All Android licenses accepted.
[√] Android Studio (version 4.0)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 50.0.1
• Dart plugin version 193.7547
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
[!] Connected device
! No devices available
! Doctor found issues in 1 category.

Hi @rehamalraee
You should reply to the first issue you reported (https://github.com/flutter/flutter/issues/69881).
I'm going to close this as a duplicate of https://github.com/flutter/flutter/issues/69881. Please share the code snippet on that issue instead of creating another one.
Thank you


shopify pipeline

Planned Pipeline Info
Please provide info below when opening the issue to give use heads-up on what is planned.

name of the pipeline to be used by dlt init and to be placed in pipelines folder: [e.g. pipedrive]
category and description of the pipeline: [e.g. CRM, loads the relevant data from pipedrive api]

You can fill the data below when writing spec.
Use Cases
Please provide descriptions up to 3 most important use cases that users of this pipeline do. Those use cases will be:

implemented
reviewed
demonstrated in pipeline script
documented
use case description is not only targeted at the developers but also by people creating test account and doing demos.

Sources / Resources / Endpoints
Define pipeline interface to the user in terms of sources and resources.

enumerate all the sources with information form which endpoints the data comes from
ideally provide the config arguments to each source (ie. start dates, report ranges etc.)
you can use pseudocode to show how you intend to use the source
provide the default write disposition for resources in the source (all append, all replace?)
in the sources identify the incremental and merge resources and specify them in a reasonable way (ideally by giving the cursor columns - what is the last value really?, primary keys and merge keys).

Customization
Enumerate everything that goes beyond standard dlt building blocks. Suggest the implementation

use of state
in the code or as additional transform, filter or map function
ask dlt team for help if it looks like complex software task

Test account / test data

specify what data you expect in the test dataset. otherwise refer to use cases
specify what kind of account access you need, include tool's name, required plan or features needed

Implementation tasks
Below you have a proposal for implementation tasks

[ ] implement all the described sources, resources and endpoints
[ ] make sure that the Use Cases can be easily executed by the pipeline's user by providing demonstrations of all the use cases in the [pipeline_name]_pipeline.py
[ ] all the use cases are tested
[ ] if there are any customizations you must test them, including unit tests for custom code

Planned Pipeline Info
Please provide info below when opening the issue to give use heads-up on what is planned.

name of the pipeline to be used by dlt init and to be placed in pipelines folder: [e.g. pipedrive]
category and description of the pipeline: [e.g. CRM, loads the relevant data from pipedrive api]

You can fill the data below when writing spec.
Use Cases
Please provide descriptions up to 3 most important use cases that users of this pipeline do. Those use cases will be:

implemented
reviewed
demonstrated in pipeline script
documented
use case description is not only targeted at the developers but also by people creating test account and doing demos.

Sources / Resources / Endpoints
Define pipeline interface to the user in terms of sources and resources.

enumerate all the sources with information form which endpoints the data comes from
ideally provide the config arguments to each source (ie. start dates, report ranges etc.)
you can use pseudocode to show how you intend to use the source
provide the default write disposition for resources in the source (all append, all replace?)
in the sources identify the incremental and merge resources and specify them in a reasonable way (ideally by giving the cursor columns - what is the last value really?, primary keys and merge keys).

Customization
Enumerate everything that goes beyond standard dlt building blocks. Suggest the implementation

use of state
in the code or as additional transform, filter or map function
ask dlt team for help if it looks like complex software task

Test account / test data

specify what data you expect in the test dataset. otherwise refer to use cases
specify what kind of account access you need, include tool's name, reuired plan or features needed

Implementation tasks
Below you have a proposal for implementation tasks

[ ] implement all the described sources, resources and endpoints
[ ] make sure that the Use Cases can be easily executed by the pipeline's user by providing demonstrations of all the use cases in the [pipeline_name]_pipeline.py
[ ] all the use cases are tested
[ ] if there are any customizations you must test them, including unit tests for custom code

done :)


[Flutter Web] evaluateJavascript is broke in latest version.

Environment

Technology
Version

Flutter version
3.19.1

Plugin version
6.0.0

macOS version
Sonoma 14.2.1

Device information: MacBook Pro. 14-inch, 2023.
Description
Expected behavior:
[Flutter Web]
inAppWebViewController.evaluateJavascript(source: "functionName();"); works perfectly fine in flutter version 3.16.4.
Current behavior:
[Flutter Web]
inAppWebViewController.evaluateJavascript(source: "functionName();"); stopped working in flutter 3.19.1.
Steps to reproduce

Upgrade to latest version of flutter.
add the html initial file to InAppWebView (which has a script file connected to the html with the following function name 'abc') .
Store the web view controller in a variable.
onWebViewCreated: (InAppWebViewController controller) {
inAppWebViewController = controller;
},
call inAppWebViewController.evaluateJavascript(source: "abc();"); somewhere in the app, mostly in onTap property of an inkwell.
the 'abc' function present in the script file is never triggered.

Summarry
I'm currently using flutter web and the inAppWebViewController.evaluateJavascript was working perfectly fine in version 3.16.4. I recently upgraded to 3.19.1 and it stopped working. There was no code modification.
Please let me know me if you need anything else. Really appreciate the work you have done for this package.

up


speed up the bisect

speed up the bisect like crossfilter has done

This would undo the fix for https://github.com/jashkenas/underscore/issues/1850 and work done in #1954


Unbound variable in download

Description
An unbound variable error occurs in download unit tests on Mac OS, probably due to an empty array.
not ok 142 fail for missing URL
# (from function `assert_output' in file test/test_helper/bats-assert/src/assert_output.bash, line 194,
#  in test file test/download.bats, line 48)
#   `assert_output "Error: download requires URL."' failed
#
# -- output differs --
# expected : Error: download requires URL.
# actual   : /Users/runner/work/biapy-bashlings/biapy-bashlings/src/download.bash: line 78: @: unbound variable
# --
#

Fixed by following recommendations from Expanding Bash arrays safely with set -u.


Add deprecation warning to postinst script

Firezone 0.7.x will be the last release to support Omnibus.

Pull Request Test Coverage Report for Build ac0813eb18b2cda80306975b4e7058ca5924a6b6-PR-1282

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 67.76%

Totals

Change from base Build 0cdc3ec1a340e3f6c405214fd71cc6963159a446:
0.0%

Covered Lines:
1322

Relevant Lines:
1951

💛  - Coveralls

Fixes #1279