Is there a way to run gremlin Monkey Tests on third party URLs?

Is it possible to run Gremlin tests on third party URLs or external websites? For e.g. If I want to run gremlin on Twitter.com, what would I have to do? I've not tried it yet, but I'm thinking a framework like nightwatch.js might be handy, but I'm not sure about how to go about it.

You can use the bookmarklet and execute it on every website.
Take a look at
https://github.com/marmelab/gremlins.js#installation
and
https://rawgit.com/marmelab/gremlins.js/master/bookmarklet.html

Ah I see. That worked. On a couple of sites. There's no getting around the CSP though? I'm trying to run gremlin on Facebook and Inbox, but CSP prevents gremlin from running on these sites. Works like a charm on Medium though

Not sure if you can bypass CSP. Maybe there's a browser setting.

Hey folks. The Marmelab team is attempting to clean up the Issues backlog. With that, we're closing issues that have been open for an one or more years.
We really appreciate the folks have taken the time to open and comment on this issue. Please don't confuse this closure with us not caring or dismissing your issue, feature request, discussion, or report. If the issue pertains to a bug, please re-test for the bug on the latest version of gremlins.js.
The best way to report problems with gremlins.js 2.0 is to file new issues.


ValueError: End of central directory record (EOCD) signature not found

Hi guys. I try to analyze an APK file:
a, d, dx = AnalyzeAPK(apk_path)
however, it raises an error:

Traceback (most recent call last):
File "/home/iot/Documents/Zijing/Ollama/main.py", line 18, in
StaticAnalysis.test_apk(args.apk_path)
File "/home/iot/Documents/Zijing/Ollama/Android/StaticAnalysis.py", line 201, in test_apk
a, d, dx = AnalyzeAPK(apk_path)
File "/home/iot/.local/lib/python3.10/site-packages/androguard/misc.py", line 57, in AnalyzeAPK
a = apk.APK(_file, raw=raw)
File "/home/iot/.local/lib/python3.10/site-packages/androguard/core/apk/init.py", line 273, in init
self.zip = ZipEntry.parse(filename, False)
File "/home/iot/.local/lib/python3.10/site-packages/apkInspector/headers.py", line 410, in parse
eocd = EndOfCentralDirectoryRecord.parse(apk_file)
File "/home/iot/.local/lib/python3.10/site-packages/apkInspector/headers.py", line 59, in parse
raise ValueError("End of central directory record (EOCD) signature not found")
ValueError: End of central directory record (EOCD) signature not found

Does it mean the apk file cannot be analyzed? Thank you.

I can't rule out the APK doesn't have an EOCD header, but this looks like a bug in apkInspector EndOfCentralDirectoryRecord.parse():
        chunk_size = 1024
        offset = 0
        signature_offset = -1
        file_size = apk_file.seek(0, 2)
        while offset < file_size:
            position = file_size - offset - chunk_size
            if position < 0:
                position = 0
            apk_file.seek(position)
            chunk = apk_file.read(chunk_size)
            if not chunk:
                break
            signature_offset = chunk.rfind(b'\x50\x4b\x05\x06')  # end of Central Directory File Header signature
            if signature_offset != -1:
                eo_central_directory_offset = position + signature_offset
                break  # Found End of central directory record (EOCD) signature
            offset += chunk_size
        if signature_offset == -1:
            raise ValueError("End of central directory record (EOCD) signature not found")

If the EOCD header signature happens to be positioned so that it overlaps two chunks (e.g. 1026 bytes before EOF) it will not be found. You could either just offset += chunk_size - 4 or append the first 4 bytes of the previous chunk (if any) after reading a new one to catch those cases.
Of course most APKs would not have a comment field in the EOCD, let alone one that's more than 1kb.

hey @Ma-Zijing  and @obfusk great work in pinpointing this edge case, thank you. I have already pushed a patched version to fix this issue and I included a test case as well.

@erev0s @obfusk I guess it's because when I download the apk file, sth goes wrong and the apk file is broken :(
Anyway, thank you for your help :)

@Ma-Zijing maybe you can share the link to the apk to check it out and make sure?

@erev0s Of course. I upload the apk file below:
0D77604D2B4424A716C8802125C4FE062E784709810A6A555CC4C081AE9780FE.zip

because it is not an apk

I thought that might be it (stuff like that has happened to me as well) but thanks to that I did spot an unhandled edge case :)


typo fix

typo fix

Thank you for submitting this pull request.
The existing text is correct. The term Organizations SCP in the modified sentence is meant to be the service name Organizations and resource SCP. Organizations is short for AWS Organizations.


Fixing Firefox regression with calc date; bug in shared library

Pass in ?w=1 to ignore whitespace changes, this change is relatively simple. I've replaced the calculation of selected month. It appears it was regressed here: https://github.com/blargity/toolkit-for-ynab/commit/5e8976b3adbeb956f081f5d44bf67411610d5636. We may want to validate these larger merges separately.
I've also adjusted the calculation so that it is correct. Previously it was returning 1 month too early. This is likely the root cause for people reporting the calculation was incorrect.
Tested in FF and Chrome

@blargity  @iamnafets
FYI - This looks fine, but it will conflict with #127 as pacing is one of the features impacted by the refactor from egens.
Conflict with pacing/main.js
I saw no conflicts with shared/main.js
It looks like the important change from this commit is line 23 . Any conflicts after 137 should probably use the refactored code from #127 (replacing for loop with changedNodes.has('budget-inspector') )

@iamnafets, how do we validate these larger merges separately?
My ideal is that we stuff that involves many features using the same file into a python script so we're all just working on our own folders and there's much less merging to begin with and the build system just combines it all based on what's in the folders.
Not sure what you mean by validating these. Do you mean doing it on a different branch then merging that into Master when we're happy, or?

I think we're good with 09bb47cdad16d866f202efaffac1877404f70f91. Please let me know if I F'ed it up again.

@egens It doesn't return the correct value for me without this change. When you run ynabToolKit.shared.parseSelectedMonth() directly from console, does it return the correct month?

@iamnafets I'm on January
ynabToolKit.shared.parseSelectedMonth()
Mon Feb 01 2016 00:00:00 GMT+0300 (MSK)

Aha! Your time zone is +3, mine is -8. I assume the way this is calculated flips based on the TZ. Let me see if I can fix it.

https://github.com/blargity/toolkit-for-ynab/pull/134

Nice work guys!


Correct metadata URL path regex

Fixes problem with /metadata/non-fdi-type/ endpoint returning the wrong data.

Codecov Report

Merging #238 into develop will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           develop     #238   +/-   ##
========================================
  Coverage    92.73%   92.73%
========================================
  Files           56       56
  Lines         1913     1913
  Branches       180      180
========================================
  Hits          1774     1774
  Misses         117      117
  Partials        22       22

Impacted Files
Coverage Δ

datahub/metadata/views.py
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35048b5...e32550d. Read the comment docs.


Split a string in Balanced Strings

Link for the problem : https://leetcode.com/problems/split-a-string-in-balanced-strings/
Add your code in the 'split_string_in_balanced_string' .
Mention the time complexity at the end
It would be great if you can write the approach before coding , go through other files for reference

Hello , I would like to work on this issue, could you please assign it to me

Yes sure , go ahead


bugfix: global transaction hook repeat execute

[ ] I have registered the PR changes.

Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?

fixes #5595
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

The hook is called by TransactionalTemplate, and the Participant's judgment is inside the class defaultGlobaltransaction, so I'm wondering again if I should underlay the hook call into defaultGlobaltransaction? Or the other way around, make defaultGlobaltransaction's behavior more pure, and all the prevention of duplicate calls and permission control is handled by TransactionalTemplate?
钩子是TransactionalTemplate调的，而Participant的判断是在defaultGlobaltransaction这个类里面的，所以我再想是否应该将hook的调用下层到defaultGlobaltransaction中？或者反过来，让defaultGlobaltransaction的行为更加单纯，所有的防止重复调用，权限控制都由TransactionalTemplate来处理？

角色判断修改为提前处理

Unit tests need to be fixed before merging can take place


[WIP] [DEPS] Bump Hadoop 3.3.1

Why are the changes needed?

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

only for miniyarn

Codecov Report

Merging #757 (dfca351) into master (5c5d43b) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head dfca351 differs from pull request most recent head 445f250. Consider uploading reports for the commit 445f250 to get more accurate results

@@          Coverage Diff           @@
##           master    #757   +/-   ##
======================================
  Coverage    0.00%   0.00%
======================================
  Files         122     122
  Lines        4749    4749
  Branches      576     576
======================================
  Misses       4749    4749

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c5d43b...445f250. Read the comment docs.

I didn't see benefits of Hadoop 3.3.1 :(

Spark just skipTests on JDK 11 and 17 in GA
https://github.com/apache/spark/blob/a9947cbd716b83e2f65dfec035c7abf29ea40922/.github/workflows/build_and_test.yml#L467

Codecov Report

Merging #757 (e88937e) into master (f4094d6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #757   +/-   ##
=========================================
  Coverage     73.10%   73.10%
  Complexity       41       41
=========================================
  Files           175      175
  Lines          6848     6848
  Branches        835      835
=========================================
  Hits           5006     5006
  Misses         1441     1441
  Partials        401      401

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4094d6...e88937e. Read the comment docs.

thanks, merged to master


Exporter still exports even if Mesos is unavailable

When Mesos is not available, messages like Get http://<IP>:5051/metrics/snapshot: dial tcp <IP>:5051: getsockopt: connection refused appear in the log, but the exporter stays up and just does not export the Mesos metrics. This makes it hard to detect such failures.

The metrics that remain do however contain reference to the failed/error attempts at scraping for metrics.
`mesos_collector_errors_total`

I.e. this behaviour is desirable.

https://prometheus.io/docs/instrumenting/writing_exporters/#failed-scrapes states:

Failed scrapes
There are currently two patterns for failed scrapes where the application you’re talking to doesn’t respond or has other problems.
The first is to return a 5xx error.
The seconds is to have an myexporter_up (e.g. haproxy_up) variable that’s 0/1 depending on whether the scrape worked.
The latter is better where there’s still some useful metrics you can get even with a failed scrape, such as the haproxy exporter providing process stats. The former is a tad easier for users to deal with, as up works in the usual way (though you can’t distinguish between the exporter being down and the application being down).

This exporter is using a third option that is not part of the official documentation: It uses a counter that is incremented for each scape failure. In general though, it works. I am therefore closing this issue as "works for me".
To make it easier for users to get started, I might add a few example alerts though.


FFmpeg exited with code: 8 and signal: null

Describe the bug
Hello, I have been stuck on a problem for 2 days.
I would like to install 2 cameras of the brand "Imou" in the home application on my iPhone.
So I installed homebridge on my Ubuntu (Ubuntu is installed on a raspberry pi 5) and I also installed camera.ui in order to configure my cameras.
First I retrieved the RTSP URL addresses of my cameras and I checked that they work well in VLC.
So I configure the plugin and add my cameras, I enter the RTSP address, I activate the audio and I restart my plugin.
If I go to the camera.ui interface I see my 2 cameras and they are functional. However if I add my 2 cameras to Homekit it is displayed well in it, I also have the thumbnail but if I launch the live video stream it loads infinitely and in the homebridge console I have the following error: "FFmpeg exited with code: 8 and signal: null"
(I installed ffmpeg on my ubuntu with the command "sudo apt install ffmpeg" but that doesn't change anything)
I don't know what to do to resolve this error...
before that I tested the installation of homebridge on my raspberry pi 5 in several ways:

Homebridge installed on raspberry os
Homebridge OS

It was the same problem with also other problems in addition like the "Restart video analysis" in loop
before buying my raspberry I had done the test on a windows 11 VM in Manager Hyper V and it worked perfectly well, no errors, access to my cameras in the interface camera.ui but also in Homekit.
I don't understand why it works in a Windows 11 VM but not on my raspberry because the configuration is exactly the same.
I wanted to buy a raspberry to make a homebridge but I find myself unable to make my cameras work in homekit.
Logs
LogHomebridgeCameraUI.txt
Screenshots

Environment

Node.js Version: v20.17.0
Homebridge Version: v1.8.4
Camera UI Version: v5.0.27
Operating System: Ubuntu Noble (24.04.1 LTS)
Browser: Chrome

[!IMPORTANT]
🚀 New Version in Development 🚀
A new version of camera.ui is currently under active development - in progress are advanced works on the alpha version (for a closed group of testers) and the public beta will be available soon.
Stay tuned for exciting updates:
https://github.com/seydx/camera.ui/issues/448

[!CAUTION]
This version will not be developed, current bugs will not be fixed and new features will not be introduced.


use metrics internally

See discussion here https://github.com/calyptia/plugin/pull/11#discussion_r887996280

I see. All right.


Enable OptimizeBufferReuse for simple Target Wrappers

Waiting for NLog ver. 4.5

This change is

Current coverage is 82% (diff: 100%)

Merging #1923 into master will increase coverage by <1%

@@             master      #1923   diff @@
==========================================
  Files           285        285
  Lines         19436      19443     +7
  Methods        2947       2947
  Messages          0          0
  Branches       2263       2263
==========================================
+ Hits          15823      15847    +24
  Misses         3060       3060
+ Partials        553        536    -17

Powered by Codecov. Last update 3e87ca7...b7321e2


"Node is already used in another tree" error when using "using static" (C# 6)

I can't repro this in a small case on Deck, but we're seeing this when trying to use using static in one of our projects. I'll try to gather more info/repro when I get time, but posting it for now in case the report/stack might be useful.
Adding the using static doesn't cause issues, but once we try to use it we see this error during compilation. We're using it for one of our own classes, not a built-in one.
Error		Error: Node is already used in another tree.
Parameter name: child    at ICSharpCode.NRefactory.CSharp.AstNode.AddChild[T](T child, Role`1 role)
   at ICSharpCode.NRefactory.CSharp.AstNodeCollection`1.Add(T element)
   at ICSharpCode.NRefactory.CSharp.AstNodeCollection`1.ReplaceWith(IEnumerable`1 nodes)
   at Bridge.Translator.PreconverterFixer.VisitInvocationExpression(InvocationExpression invocationExpression)
   at ICSharpCode.NRefactory.CSharp.InvocationExpression.AcceptVisitor[T](IAstVisitor`1 visitor)
   at Bridge.Translator.PreconverterFixer.VisitChildren(AstNode node)
   at ICSharpCode.NRefactory.CSharp.DepthFirstAstVisitor`1.VisitReturnStatement(ReturnStatement returnStatement)
   at ICSharpCode.NRefactory.CSharp.ReturnStatement.AcceptVisitor[T](IAstVisitor`1 visitor)
   at Bridge.Translator.PreconverterFixer.VisitChildren(AstNode node)
   at ICSharpCode.NRefactory.CSharp.DepthFirstAstVisitor`1.VisitBlockStatement(BlockStatement blockStatement)
   at ICSharpCode.NRefactory.CSharp.BlockStatement.AcceptVisitor[T](IAstVisitor`1 visitor)
   at Bridge.Translator.PreconverterFixer.VisitChildren(AstNode node)
   at ICSharpCode.NRefactory.CSharp.DepthFirstAstVisitor`1.VisitMethodDeclaration(MethodDeclaration methodDeclaration)
   at ICSharpCode.NRefactory.CSharp.MethodDeclaration.AcceptVisitor[T](IAstVisitor`1 visitor)
   at Bridge.Translator.PreconverterFixer.VisitChildren(AstNode node)
   at ICSharpCode.NRefactory.CSharp.DepthFirstAstVisitor`1.VisitTypeDeclaration(TypeDeclaration typeDeclaration)
   at ICSharpCode.NRefactory.CSharp.TypeDeclaration.AcceptVisitor[T](IAstVisitor`1 visitor)
   at Bridge.Translator.PreconverterFixer.VisitChildren(AstNode node)
   at ICSharpCode.NRefactory.CSharp.DepthFirstAstVisitor`1.VisitNamespaceDeclaration(NamespaceDeclaration namespaceDeclaration)
   at ICSharpCode.NRefactory.CSharp.NamespaceDeclaration.AcceptVisitor[T](IAstVisitor`1 visitor)
   at Bridge.Translator.PreconverterFixer.VisitChildren(AstNode node)
   at ICSharpCode.NRefactory.CSharp.DepthFirstAstVisitor`1.VisitSyntaxTree(SyntaxTree unit)
   at ICSharpCode.NRefactory.CSharp.SyntaxTree.AcceptVisitor[T](IAstVisitor`1 visitor)
   at Bridge.Translator.Translator.Preconvert(MemberResolver resolver)
   at Bridge.Translator.Translator.Translate()
   at Bridge.Build.GenerateScript.Execute()

Struggling to get a small repro of this... Lots of small unrelated changes seem to cause it to disappear, so it's hard to strip down and keep the project compiling, while removing things code I can't share.
For example, this code causes it (when there are certain other classes/etc.):
		public override ReactElement Render()
		{

			var a = DOM.Div(
				null,
				Row(null, null, "Name"),
				Row(null, null, "Branding")
			);
			return null;
		}

Yet if I just call the Row method (the one imported via using static) twice like that without it being inside here, it works fine. However, removing other classes caused the above code to work fine too!

Hi @DanTup – Any luck making a Deck that might reproduce this issue? This looks like something we would want to ensure is functional within 16.x.

Unfortunately not - I couldn't even repro locally in a clean project and the weirdest changes seemed to cause the error to go away. I'm out of office till Tuesday now but I'll see if I can get some time to try again next week.
I don't think it's critical (it's compile-time and you can just drop the using static and use the type name) so I wouldn't hold up any release for it.

I'm going to close the issue, but if a reproducible case is ever established, we'll gladly reopen.


set qps and burst for rest config

What is the purpose of the change
set qps and burst for rest config
Brief changelog

default rest config qps is 5, and burst is 10
set qps with default  50, and default burst to 100.

Verifying this change
./authority --rest-config-qps=100 --rest-config-burst=200
Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
[ ] Run `mvn clean compile --batch-mode -DskipTests=false -Dcheckstyle.skip=false -Drat.skip=false -Dmaven.javadoc.skip=true to make sure basic checks pass.

Codecov Report

Merging #1064 (7842035) into refactor-with-go (2e663f3) will decrease coverage by 0.31%.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##           refactor-with-go    #1064      +/-   ##
====================================================
- Coverage             63.96%   63.66%   -0.31%
====================================================
  Files                    29       29
  Lines                  2323     2323
====================================================
- Hits                   1486     1479       -7
- Misses                  740      746       +6
- Partials                 97       98       +1

see 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add equivalent of object-property-newline for import declaration

object-property-newline

While formatting preferences are very personal, a number of style guides require that object properties be placed on separate lines for better readability.
Another argument in favor of this style is that it improves the readability of diffs when a property is changed:

Examples of incorrect code for this rule:
import {createMovieMatcher,matcher} from './../src/movieRecognizer';

Examples of correct code for this rule:
import {
    createMovieMatcher,
    matcher
} from './../src/movieRecognizer';

Sounds good to me. Would prefer having an option like "always" / "never" on this rule, so that one could decide to go the opposite way if preferred.

Is this still a work in progress? This was posted in 2016

yep.

try https://github.com/gmsorrow/eslint-plugin-modules-newline

Given that exists as a model, it seems like someone could make a PR to add it here.

It would also be nice if you could have an as-needed option which takes the configured maximum line length (or you just configure it again with the rule) and puts it on one line if it fits within the line length but breaks it up into multiple lines if it doesn't.
There is a VSCode extension that made this feature pretty configurable so some things might be nice to implement into such an ESLint rule: https://marketplace.visualstudio.com/items?itemName=dozerg.tsimportsorter

The other plugin is archived now. I've implemented a rule that always forces a new line in Canonical plugin:

export-specifier-newline
import-specifier-newline

Still happy to accept a PR here for it.


⚠ Bofrost.de has degraded performance

In b0a3dbd, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1167 ms

Resolved: Bofrost.de performance has improved in a3457b7 after 21 minutes.


Issue in readme: relation with nadir & incidence angles

Hi,
I was struggling with the following paragraph:
"The off-nadir angle and the incidence angle are related. When the off-nadir angle is low (high incidence angle) then the two angles sum to about 90, so one can be calculated from the other. However, at high off-nadir angles with high altitude sensors the curvature of the earth has an impact and their sum will be less than 90. If only providing one of the two angles, the off-nadir angle is preferred.".
From my understanding and researches, the off-nadir represents the angle from the satellite point of view and the normal, and the incidence_angle represents the one form the observed pixel and the normal.
Meaning, both are quite similar, especially when the altitude is low as the surface of the Earth could be considered flat, and slightly different when the curvature of the Earth is more impacting.
Meaning, not the sum of both is nearby 90, but the difference of both is nearby 0.
I am get wrong, but everything I can find on Internet get me to this conclusion.
I think there is just a misunderstanding between this relation, and the zenith & elevation relation (which is : "sum of zenith and elevation gives 90).
Doc: https://ww2.mathworks.cn/help/radar/ug/spaceborne-synthetic-aperture-radar-performance-prediction.html
Cheers,

PRs are welcome!


FormattingOptions should match the LSP's

Hi!
The LSP describes more formatting features than what VSCode can provide. Therefore, the LanguageClient can only handle part of the protocol's available parameters (see the related issue : microsoft/vscode-languageserver-node#617)
In particular, the FormattingOptions interface should contain more fields:
export interface FormattingOptions {
	/**
	 * Size of a tab in spaces.
	 */
	tabSize: number;
	/**
	 * Prefer spaces over tabs.
	 */
	insertSpaces: boolean;
	/**
	 * Trim trailing whitespace on a line.
	 */
	trimTrailingWhitespace?: boolean;
	/**
	 * Insert a newline character at the end of the file if one does not exist.
	 */
	insertFinalNewline?: boolean;
	/**
	 * Trim all newlines after the final newline at the end of the file.
	 */
	trimFinalNewlines?: boolean;
}

If there is also a way to pass more options (the [key: string]: boolean | number | string; part of the protocol) it would be extra nice, but I don't know if that should be done by vscode of handled directly by the language-client lib.
Also, since we're here, maybe this type and the protocol's should be extended with a lineWidth parameter which is common to a lot of formatters and we need in the case of the OCaml LSP (see issues on ocaml-lsp and on the ocaml-vscode plugin)

I don't think that's needed, all those trimming features are built into VS Code itselves and no formatter is needed for that. We have a "catch-all" signature for various different options: https://github.com/microsoft/vscode/blob/af3c79edcbc5b353b1ed3a69bca2ae95831ad089/src/vs/vscode.d.ts#L3417-L3420
I honestly think that enough, because it kinda matches what vs code offers by default and other options can be defined (and read) by extensions themselves

But then there is a mismatch between protocol usage and vscode itself.
When writing a language server, one expects to receive formatting options through DocumentFormattingParams.options : FormattingOptions.
And although the interface exposes more, VSCode only passes part of that information to the provider here, because modes.FormattingOptions is a more restricted type than the one exposed in vscode.d.ts.
Not being able to use these parameters creates a discrepancy between vscode and other editors may pass the information there.
It would be ok for vscode not to implement pass them, but then the protocol should probably also deprecate these parameters and ask the server implementers to go lookup in the workspace configuration for these options.

And although the interface exposes more, VSCode only passes part of that information to the provider here, because modes.FormattingOptions is a more restricted type than the one exposed in vscode.d.ts.

This isn't a problem of VS Code but the LSP client library. It is free to add whatever option it wants. fyi @dbaeumer

We added theses options for editor which don't have built in support for this and need to depend on a formatter.


Coming up empty?

I'm trying this out for Komodo/KomodoEdit, command output:
github_changelog_generator -u Komodo -p KomodoEdit -t REMOVED                                                                                [16:38:13]
Performing task with options:
{:tag1=>nil,
 :tag2=>nil,
 :format=>"%Y-%m-%d",
 :output=>"CHANGELOG.md",
 :exclude_labels=>["duplicate", "question", "invalid", "wontfix"],
 :pulls=>true,
 :issues=>true,
 :verbose=>true,
 :add_issues_wo_labels=>true,
 :add_pr_wo_labels=>true,
 :merge_prefix=>"**Merged pull requests:**",
 :issue_prefix=>"**Closed issues:**",
 :bug_prefix=>"**Fixed bugs:**",
 :enhancement_prefix=>"**Implemented enhancements:**",
 :author=>true,
 :filter_issues_by_milestone=>true,
 :compare_link=>true,
 :unreleased=>true,
 :unreleased_label=>"Unreleased",
 :branch=>"origin",
 :user=>"Komodo",
 :project=>"KomodoEdit",
 :token=>"REMOVED"}

Found 0 tags
Received issues: 92
Fetching merged dates... Done!
Filtered pull requests: 11
Filtered issues: 81
Fetching events for issues and PR: Done!
Fetching closed dates for issues: Done!
Fetching tags: Done!
Sorting tags..
Generating log..
Done!
Generated log placed in /home/nathan/Projects/komodo-changelog/CHANGELOG.md

CHANGELOG.md:
# Change Log

\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*

It's kind of weird that it says  :branch=>"origin", rather than "master", but I could find no obvious way to change that..

@Naatan Hi.
The problem, that you dan't have any tags in this repo.
Found 0 tags

It seems, that you are using outdated version. In new version You will found Yellow warring message in the beginning:

Warning: Can't find any tags in repo. Make sure, that you push tags to remote repo via 'git push --tags'

I'll try updating, but is it required to have tags? Could this operate strictly on Milestones?
I don't want to generate a changelog on commits, just on issues / milestones.

@Naatan

I'll try updating, but is it required to have tags?

Until now - yes.

Could this operate strictly on Milestones?

It's not easy to implement, because Change log is time-based file. In my scenario milestones used only to fix issues, that closed not wrong time range.
Milestones don't have any bindings to the time by themself. So I don't know, how to compound change log only from milestones.
Also, not all milestones should be included to change log. So we have to add separate list distinguish them.

I don't want to generate a changelog on commits, just on issues / milestones.

Only issues and pull requests. Commits are not supported yet anyway (#51 for details)

BDW: about branch - you are right. Actually - it's means remote. I will fix this typo.

Hi, i was about to ask this same question becuase i expected to get an unrealeased section similar to that what you have in this projects changelog. Does this only show up after the first tag because "Unrealeased" is not a tag in this repo but yet it shows up in the changelog.

@osiloke You're right. It Unreleased start works if you have at least 1 tag in repo.
But it's possible to modify this logic. I add new issue, related with this feature #228.
Have a lot of work next month. But will be glad to accept PR with this feature. :wink:


serialization.cpp error

please help

More information please
Where does this occur?
This seems completely unrelated to SScript

I assume this is fixed, closing!


MCMT generalized gate accepts a label kwarg that seems ignored

Information

Qiskit Terra version: main @ c3792f9d
Python version: 3.6
Operating system: osx 10.15.7

What is the current behavior?
mcmt from library allows a label kwarg, but it doens't go anywhere?
Steps to reproduce the problem
The generalized gate MCMT accepts a label kwarg, which it will set to be self.label, but as a subclass of QuantumCircuit, it does not look like this attribute will be read anywhere (or at least, I couldn't find anywhere where it was used.)
>>> from qiskit.circuit.library import *
>>> MCMT(XGate(), 3, 1, label='foo').draw()

q_0: ──■──
       │
q_1: ──■──
       │
q_2: ──■──
     ┌─┴─┐
q_3: ┤ X ├
     └───┘
>>> MCMT(XGate(), 3, 1, label='foo').name
'mcmt'
>>> MCMT(XGate(), 3, 1, label='foo').to_instruction()
<qiskit.circuit.instruction.Instruction at 0x14b031898>
>>> MCMT(XGate(), 3, 1, label='foo').to_instruction().label
>>> MCMT(XGate(), 3, 1, label='foo').to_instruction().name
'mcmt'

What is the expected behavior?
Suggested solutions

>>> MCMT(XGate(), 3, 1, label='foo').label
foo

>>> MCMT(XGate(), 3, 1, label='foo').label
foo

True, but that is equally true for any python class :). My point was more that MCMT accepts a label kwarg (like an Instruction subclass) but is a subclass of QuantumCircuit, so none of the supporting code (around drawing, converting, serializing, ...) will find this label.

I think a label doesn't make much sense for the MCMT since it's not drawn as a box but as multicontrolled gate. We could make label be the label of the controlled gate, or (probably the better, cleaner solution) just remove it.

After some investigation, it looks like label is actually not ignored, though I imagine this is a bug.
When multiple target qubits are used, the name of the QuantumCircuit created for broadcast is set to the value of label. When control() is called on the resulting gate, that name is actually eventually used in some special-casing in add_control.py::control.
if gate.name == "x":
   controlled_circ.mct(q_control, q_target[bit_indices[qargs[0]]], q_ancillae)
elif gate.name == "rx":
  ...

I was able to get different circuits by specifying a special-cased label.
Default (label="2-X")
mcmt1 = MCMT(XGate(), num_ctrl_qubits=1, num_target_qubits=2)
print(mcmt1.qasm())

OPENQASM 2.0;
include "qelib1.inc";
gate c2-X q0,q1,q2 { cx q0,q1; cx q0,q2; }
qreg q[3];
c2-X q[0],q[1],q[2];

label="x"
mcmt2 = MCMT(XGate(), num_ctrl_qubits=1, num_target_qubits=2, label="x")

OPENQASM 2.0;
include "qelib1.inc";
qreg q[3];
cx q[0],q[1],q[2];

@kdk

This was addressed with #7161.


pip install orionsdk gets version 0.3

Pip repo needs to be updated

+1

waiting for version 0.4.0 to be published to pypi

+1

+1


RequestAnimationFrame instead of setTimeOut

I've implemented requestAnimationFrame instead of setTimeOut, should be a bit more efficient.
It uses a fallback to setTimeOut if the browser does not support requestAnimationFrame.
I also used the Google Closure Compiler to create the minified version.*

Mostly the standard benefits of requestAnimationFrame.
Hopefully the resize will be detected in the same frame as the resize actually happens, causing less delay between the resize and the event being triggered and better synchronizing the event with CSS Transformations and animations.
Also requestAnimationFrame uses a smart way of measuring the time before starting the next. This way there is no set delay between polling but the browser calculates the best time when to update.
This way the browser will automatically throttle the updates when the hardware is underpowered or for example the tab is not active.
The drawbacks of this method are that the browser chooses how often the event is fired and not the standard delay you set. Also it might cause more redraws than needed. The redraw problem could be fixed by giving the requestAnimationFrame function the context where the resize will be happening. But the single event loop design would need to be changed for that.
Giving context to requestAnimationFrame could also lead to better optimization for example when the element is scrolled out of view.

In your solution, when using requestAnimationFrame, how would you clear a timeout?

Hmm, did not think about that.
There is a clearTimeOut() version for requestAnimationFrame tho.
I'll look at it tonight and update the patch.


dependency issue

Hi,
I'm getting the following error after updating to nuxt 1.0.0
This dependency was not found:
/.nuxt/client.js in multi webpack-hot-middleware/client?name=client&reload=true&timeout=30000&path=/__webpack_hmr ./.nuxt/client.js

It seems it has something to do with the eslint-loader in the nuxt.config.js.
When i disable it, it does compile. It is still the default template:
            if (isDev && isClient) {
                config.module.rules.push({
                    enforce: 'pre',
                    test: /\.(js|vue)$/,
                    loader: 'eslint-loader',
                    exclude: /(node_modules)/
                })
            }
        }

Any idea what could be the issue here?

This question is available on Nuxt.js community (#c33)

I get the same issue - completely new install: I did the following:
npm i -g create-nuxt-app
npx create-nuxt-app nuxt002
npm run dev

Result:
 ERROR  Failed to compile with 1 errors                                                                                12:44:22

This dependency was not found:

* E:\simonl\Documents\_dev\!learning\nuxt002\.nuxt\client.js in multi webpack-hot-middleware/client?name=client&reload=true&timeout=30000&path=/__webpack_hmr ./.nuxt/client.js

To install it, you can run: npm install --save E:\simonl\Documents\_dev\!learning\nuxt002\.nuxt\client.js

 OPEN  http://localhost:3000

I tried: npm install --save E:\simonl\Documents\_dev\!learning\nuxt002\.nuxt\client.js but got:
npm ERR! code ENOLOCAL
npm ERR! Could not install from "..\simonlDocuments_dev!learningnuxt002.nuxtclient.js" as it does not contain a package.json file.

npm ERR!      C:\Users\simonl\AppData\Roaming\npm-cache\_logs\2018-02-09T12_50_16_608Z-debug.log

Not sure if this is a nuxt, create-nuxt-app or webpack issue. Any ideas?

Also, I just tried:
vue init nuxt-community/starter-template nuxt003
npm i
npm run dev

I got the same error.

Ouch! NUXT is very broken - I've now followed the Starting from Scratch instructions and still get the error! What have I missed here?

@simonl65 Perhaps you're missin eslint-loader - try to do npm i -D eslint-loader.
If it works then I'll add a PR adding it to nuxt package.json.

@dotnetCarpenter Thanks for your response. I actually discovered it was due to an exclamation mark in my folder path (which I think webpack doesn't like) so I'm using underscores instead! I'll try-out your suggestion though and let you know.

No change :-( Here's my console log:
$ npm i -D eslint-loader
npm WARN<EMAIL_ADDRESS>requires a peer of<EMAIL_ADDRESS><5.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

+<EMAIL_ADDRESS>added 7 packages in 11.026s

simonl@HAPPY MINGW64 ~/Documents/_dev/!learning/my-first-nuxt-app (section_2)
$ npm run dev

><EMAIL_ADDRESS>dev C:\Users\simonl\Documents\_dev\!learning\my-first-nuxt-app
> nuxt

  nuxt:build App root: C:\Users\simonl\Documents\_dev\!learning\my-first-nuxt-app +0ms
  nuxt:build Generating C:\Users\simonl\Documents\_dev\!learning\my-first-nuxt-app\.nuxt files... +2ms
  nuxt:build Generating files... +13ms
  nuxt:build Generating routes... +8ms
  nuxt:build Building files... +35ms
  nuxt:build Adding webpack middleware... +1s
  ████████████████████ 100%

Build completed in 0.959s

 ERROR  Failed to compile with 1 errors                                                                                22:51:45
This dependency was not found:

* C:\Users\simonl\Documents\_dev\!learning\my-first-nuxt-app\.nuxt\client.js in multi webpack-hot-middleware/client?name=client&reload=true&timeout=30000&path=/__webpack_hmr ./.nuxt/client.js

To install it, you can run: npm install --save C:\Users\simonl\Documents\_dev\!learning\my-first-nuxt-app\.nuxt\client.js

 OPEN  http://localhost:3000

Same again after doing npm i -D eslint.

Is the error message at least about another loader than eslint?
On Thu, Mar 22, 2018, 23:55 simonl65<EMAIL_ADDRESS>wrote:

Same again after doing npm i -D eslint.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nuxt-community/starter-template/issues/48#issuecomment-375483980,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACq81s8MdU9yuem_0BrlmyuanLSwiAXks5thCvjgaJpZM4RZAWA
.

I've not looked at it since my last comment. I got around it by ensuring I had file paths that webpack is hapy with.
What error message are you seeing?

Hi Sir @simonl65
Currently, im using starter-template for nuxt.
Then, eventually I added Vuetify.
I've noticed that v-select is rendered differently from the sample on the official website.

This is the structure of the component for v-select

Sorry - I can't help you. I think you'll need to post a new issue for that - I don't think that's got anything to do with this issue.

Got the same issue after updating all packages to their latest version. One of them was probably messing around with the project.

same issue :(

same issue here

To be sure, this is on Windows right?

I had the same problem, fixed when I ran this and re-created project from scratch:
npm install -g @vue/cli @vue/cli-init

Yes windows, to be clear on what I did : create-nuxt-app -> no server option -> pushing my changes on github. Then I go on another computer, I clone the project and I run npm i and npm run dev and it gave me the error.

in my case, devDependencies was missing:
eslint-loader

Anyone else still experiencing this?
ERROR in multi webpack-hot-middleware/client?name=client&reload=true&timeout=30000&path=/__webpack_hmr ./.nuxt/client.js
Module not found: Error: Can't resolve 'eslint-loader' in 'C:\...'

  "dependencies": {
    "cross-env": "^5.2.0",
    "nuxt": "^2.0.0",
    "express": "^4.16.3",
    "element-ui": "^2.4.6",
    "@nuxtjs/axios": "^5.0.0"
  },
  "devDependencies": {
    "nodemon": "^1.11.0",
    "babel-eslint": "^8.2.1",
    "eslint": "^5.0.1",
    "eslint-loader": "^2.0.0",
    "eslint-plugin-vue": "^4.0.0"
  }

I got the same issue, but I solved.
You can see file nuxt.config.js.
build:{
extend(config, ctx) {
// Run ESLint on save
if (ctx.isDev && ctx.isClient) {
config.module.rules.push({
enforce: 'pre',
test: /.(js|vue)$/,
loader: 'eslint-loader',
exclude: /(node_modules)/
})
}
},
}
remove node extend.

I'm facing this now. I never used to have these issues with the prior version of nuxt. Newer version of Nuxt seems to have a lot of issues.
For example I was working on a project all day saturday w/o any issue. I return to it today and do npm run dev and suddenly i cant load it on localhost and it complains about eslint-loader and eslint when I was having no problem for 8 hours on saturday while working on it.

can we reopen this issue

uninstalled eslint and eslint-loader, and commented out the build section mentioned by @denlly and finally got the project to run on npm run dev. pretty concerning though since, as I mentioned, I was working on this for hours without an issue only to have this issue pop up when returning days later. never experienced that with nuxt before.


Implement support for KotlinX Serialization

This change adds support for a new code-gen argument, implementKSerializable, which results in the annotation kotlinx.serialization.Serializable being added to data classes during codegen.
New discussion opened here
Approach
A new argument has been added to the Kotlin code generator and Gradle plugin, at implementKSerializable. When set to true, the code generator annotates data classes with @kotlinx.serialization.Serializable.
If both JVM serialization and KotlinX serialization are enabled, the code generator properly qualifies with java.io.Serializable and import kotlinx.serialization.Serializable. The two are optional and usable independent of each other.
For the moment, this is filed on top of these other PRs to avoid conflicts, since they all touch the code generator; these can be rebased away, though:

#194
#192

Transitive dependency needs
Users of this code will need to include the KotlinX Serialization compiler plugin in their build, with:
plugins {
  kotlin("plugin.serialization")

  // -- or --
  alias(libs.plugins.kotlin.serialization)  // version catalog

  // -- or --
  id(libs.plugins.kotlin.serialization.get().pluginId)  // multi-module build with version catalog
}

And a dependency on KotlinX Serialization Core, for the annotation, at version 1.5.0 or greater:
dependencies {
  api("org.jetbrains.kotlinx:kotlinx-serialization-core:1.5.0")

  // -- or --
  api(libs.kotlinx.serialization.core)
}

[versions]
# ...
kotlinx-serialization = "1.5.0"  # or greater for newer Kotlin metadata versions
# ...

[libraries]
# ...
kotlinx-serialization = { module = "org.jetbrains.kotlinx:kotlinx-serialization-core", version.ref = "kotlinx-serialization" }
# ...

I stopped short of adding an api dependency to Pkl's Kotlin runtime library to avoid adding it to consumer dependency graphs downstream. This could easily be added, though, if preferable. Gradle will generally select the newest available version in a user's build, but builds that don't include KotlinX Serialization already will have to download it if it is added this way, of course.
IDEA and Kotlin warn appropriately if the compiler is not included.
Changelog

feat(codegen): add support for kotlin Serializable annotation
feat(gradle): add implementKSerializable argument
test(codegen): add test for KotlinX serialization support
test(codegen): add test for both Java and KotlinX serialization
test(gradle): add test for compiling with KotlinX serialization
chore: update lockfiles

Hey @bioball, sorry I missed your review here! I'll take a look. The problem with sealed classes is a bigger issue that may need some design attention before this feature ships.


AssertionError: Require normal BAM for Sentieon TNhaplotyper

Hi, I am trying using Sentieon  TNhaplotyper to call somatic variant for tumor-only samples. But the pipeline complains this error:

AssertionError: Require normal BAM for Sentieon TNhaplotyper

My yaml file is as below:

details:

analysis: variant2
genome_build: hg38
algorithm:
aligner: bwa
trim_reads: atropos
adapters: [truseq2, polya, illumina]
variantcaller: [vardict, mutect2, varscan, freebayes, mutect]
svcaller: [lumpy, manta, cnvkit, delly]
variant_regions: /ngs/zhengu/3214551_Covered.bed
mark_duplicates: false
recalibrate: false
realign: false
effects: snpeff
remove_lcr: true
min_allele_fraction: 1
ensemble:
numpass: 3
use_filtered: false

Sorry about that— we don’t support the tumor only mode for TNhaplotyper;
for it to work you’d need to supply a panel of normals.
On Sat, Sep 28, 2019 at 7:43 AM hliu2016<EMAIL_ADDRESS>wrote:

Hi, I am trying using Sentieon TNhaplotyper to call somatic variant for
tumor-only samples. But the pipeline complains this error:
AssertionError: Require normal BAM for Sentieon TNhaplotyper
My yaml file is as below:
details:

analysis: variant2
genome_build: hg38 to do multi-sample variant calling, assign samples
the same metadata / batch metadata: batch: your-arbitrary-batch-name
algorithm:
aligner: bwa
trim_reads: atropos
adapters: [truseq2, polya, illumina]
variantcaller: [vardict, mutect2, varscan, freebayes, mutect]
svcaller: [lumpy, manta, cnvkit, delly]
variant_regions: /ngs/zhengu/3214551_Covered.bed
mark_duplicates: false
recalibrate: false
realign: false
effects: snpeff
remove_lcr: true
min_allele_fraction: 1
ensemble:
numpass: 3
use_filtered: false

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bcbio/bcbio-nextgen/issues/2958?email_source=notifications&email_token=AADFG6WINM7HFXHY3NCIQ5TQL47MVA5CNFSM4I3N2NQ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HOJX6VA,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADFG6WGCPDQN6YTPRWJY5LQL47MVANCNFSM4I3N2NQQ
.

@roryk
Thanks for your reply. It is said that Sentieon TNhaplotyper uses the same probability model of gatk but run very faster than gatk. So, I should use TNhaplotyper rather than mutect2 in calling somatic variants?

Hi @hliu2016,
We haven't looked at the TNhaplotyper in a while and don't have a good idea of how well it is doing,  I would just use mutect2.


Add missing If-Match header

This PR contains changes related to the updating of a business scenario task. When using the API to create a POC, I have found that the eTag of the businessScenarioTask is required using the If-Match header when trying to update a task. I have updated the documentation and HTTP example to reflect this.

[!NOTE]
The following guidance is for Microsoft employees only. Community contributors can ignore this message; our content team will manage the status.

After you've created your PR, expand this section for tips and additional instructions.

do not merge is the default PR status and is automatically added to all open PRs that don't have the ready to merge label.
Add the ready for content review label to start a review. Your PR won't be reviewed until you add this label.
If your content reviewer requests changes, review the feedback and address accordingly as soon as possible to keep your pull request moving forward. After you address the feedback, remove the changes requested label, add the review feedback addressed label, and select the Re-request review icon next to the content reviewer's alias. If you can't add labels, add a comment with #feedback-addressed to the pull request.
After the content review is complete, your reviewer will add the content review complete label. When the updates in this PR are ready for external customers to use, replace the do not merge label with ready to merge and the PR will be merged within 24 working hours.
Pull requests that are inactive for more than 6 weeks will be automatically closed. Before that, you receive reminders at 2 weeks, 4 weeks, and 6 weeks. If you still need the PR, you can reopen or recreate the request.

For more information, see the Content review process summary.

@TarkanSevilmis , can you please review and approve this PR? Thanks!

Looks good for update, but the header is also required for delete and that one seems to be missed in the documentation too.

Thank you, I missed that. I have now updated the delete endpoint to also include the missing If-Match header

@CamyH please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Looks good for update, but the header is also required for delete and that one seems to be missed in the documentation too.

Hi mate, any movement on this?


Container code doesn't change , when I modify  the source code in my local machine

I want an add a new API in src/api/v2.js. I made all the changes and rerun the container but it doesn't affect the container
code. I didn't know how to achieve this one.
so kindly help me with this problem.

make sure you switch to dev with ./piston switch dev then you can run ./piston docker_compose build and ./piston docker_compose up


Code examples in README should show how to import the used library components

This will help users get up to speed with the library faster and more frictionlessly.

This issue is part of JOSS review https://github.com/openjournals/joss-reviews/issues/6575


ImportError: cannot import name 'cuda_utils' from partially initialized module 'vllm'

When I use -tp >1 , the error occurs!
env:
8*MI210
images:embeddedllminfo/vllm-rocm:vllm-v0.2.1.post1

@wpf19911118 can you post your error? We are trying to reproduce it.

I made a mistake. When I started the benchmark test, it automatically loaded the vllm related libraries from the source code.


Upload final data + labels to zenodo and add/check link

Final data and additional BBQ labels are not on zenodo: https://doi.org/10.5281/zenodo.4980359
The link in the paper was also updated.


Add apt-get update to the setup.sh

Otherwise, some packages might fail to download.

please approve this. openssl won't work unless this is in

This is because 7.17.0 is missing OpenSSL, but changing .env to ELK_VERSION=7.17.6 or newer working like a charm.


Made the Prime Checker

I wrote the C++ code I will try to implement the C and Python code soon. Please accept my pull request.

I wrote the C++ code I will try to implement the C and Python code soon. Please accept my pull request.

@Tirtharaj-Talukdar  I can only merge this PR after the algorithm has been implemented in all four languages.

Is there anything available only for C++

Is there anything available only for C++

No

I wrote the C++ code I will try to implement the C and Python code soon. Please accept my pull request.

Wrote the code for the other 4 languages.  Please accept my PR

Hey please check out my new commits. Thank You.

@Tirtharaj-Talukdar Just wait for some time till the PR is checked! 😁, Thanks for contributing

@Tirtharaj-Talukdar Kindly ⭐ this PR

Thanks a Lot


The terminal process failed to launch: Path to shell executable “___” is not a file of a symlink.

Does this issue occur when all extensions are disabled?: No

VS Code Version: 1.59.0
OS Version: Linux x64 Ubuntu 20 Node 14.16 (NVM)

The terminal process failed to launch: Path to shell executable "___" is not a file of a symlink.
___ is logtalk, in my case. I believe vscode is trying first to find the executable in my directory, but failing on first try. The call is from an extension; the name of the language in the extension is the same, and I the name of the object used in the extension is the same.
Steps to Reproduce:

Put a folder with the name of the executable you want to launch in your home directory
Try to launch the executable as an object from an extension.
--

___ is logtalk, in my case. I believe vscode is trying first to find the executable in my directory, but failing on first try. The call is from an extension; the name of the language in the extension is the same, and I the name of the object used in the extension is the same.

This is confusing me. Can you please reiterate it in a different way?


Add tests for cluster.run run within the cluster itself.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#944  👈
#934
#937
#936
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rohinb2 and the rest of your teammates on  Graphite

Merge activity

Jun 30, 5:33 PM EDT: @rohinb2 started a stack merge that includes this pull request via Graphite.


Read an account from the service

As a developer
I need Read an account from the service
So that So that I can get the data and start working on the project.
Details and Assumptions
* [document what you know]

Acceptance Criteria
gherkin
Given [some context]
When [certain action is taken]
Then [the outcome of action is observed]


Calculation of usage costs

The arduino will send the auth-command and also after the use of the device the logout with the time. There are multiple categories of the costs.

@n15c Should i include billing information (one-time, per time-interval, mixed, etc) into the devices or should we leave this to the API?


It should not be mandatory to set version in dependencyManagement

Good afternoon,
When processing the dependencyManagement, I believe that you do not have to check that the dependencies have a defined version for the following reason:
https://github.com/openrewrite/rewrite/blob/23db64458562e4012aadc9654b52133c1c16af53/rewrite-maven/src/main/java/org/openrewrite/maven/internal/RawMavenResolver.java#L153
If the purpose of the parent POM in defining a dependencyManagement is to exclude a transitive dependency and make sure that any child referencing the dependency does not load the excluded transitive dependencies, I do not see the need to specify the version, it should be the child who defines the version it needs. If the version is defined it can lead to unexpected consequences. If an older version is specified, you force the child to use the older version, and it may fail.
For example, in my case, I have defined in the parent POM the following dependencyManagement to exclude from the spring-ws library the spring-core library.
  <dependencyManagement>
        <dependencies>
            <dependency>
                <groupId>org.springframework</groupId>
                <artifactId>spring-ws</artifactId>
                <exclusions>
                    <exclusion>
                        <groupId>org.springframework</groupId>
                        <artifactId>spring-core</artifactId>
                    </exclusion>
                </exclusions>
            </dependency>
        </dependencies>
  </dependencyManagement>

I think this has been fixed now @jvillarb. Please let me know if we've missed something!


[UI] Make custom amount selection more explicit on Withdraw flow

Overview
In the current implementation the "Custom Amount" option is not explicitly obvious for users to make use of. We need to surface this option more deliberately.
Task Checklist

[ ] Update the Withdraw flow to make the "Custom Amount" option more explicit and clear

Closing in favor of https://github.com/webb-tools/webb-dapp/issues/1405; added switch in withdrawal flow to enable easy toggle between fixed and custom amount.


Increase leeway on TestCustomQueryProcessDeletionSeconds.test_default

I have seen this fail and probably other tests need more leeway too

Same with tests/mock_vws/test_flask_app_usage.py::TestProcessingTime::test_default


frontend: MainInfoSection: Correctly handle null backLink

This fix explicitly handles the null case in getBackLink() to ensure that no back button will be shown, as defined in MainInfoSectionProps.
Fixes: #2033
Testing

[ ] Go to frontend/src/components/crd/Details.tsx and set backLink to null in the MainInfoSection component
[ ] Open a cluster in Headlamp (npm start) and navigate to the Custom Resources page
[ ] Click on a CRD and ensure that the back button does not appear on the CRD page

I think instead just not adding the backLink would work for this(or backLink=false. If no backLink is supplied, then no back link is used.
Can you please explain a bit more why this is necessary?

I think instead just not adding the backLink would work for this(or backLink=false). If no backLink is supplied, then no back link is used.
Can you please explain a bit more why this is necessary?

@illume The backLink value is by default the empty string '', and the spec for backLink specifies a difference between passing in the empty string and a null value:
/** The route or location to go to. If it's an empty string, then the "browser back" function is used. If null, no back button will be shown. */
Previously passing in a null value did the same thing as passing in the empty string. Unless this is the intended behavior, we are missing the functionality to handle the null string as specified

Yeah. By default we have had the backLink, so we should just fix the null case which is what docs mean. The backLink={false} should also be the same as null.

Ran into merge conflict issues...reopening here #2040

We shouldn't close PRs because of merge conflicts. I am reopening this and closing the new one since this one has the context from previous reviews.

you could likely drop the MainInfoSection part to make it frontend: Fixes handle null backLink

this is a nit but the MainInfoSection part could be left off to make it frontend: Fixes handle null backLink

Why? I think the only thing not according to format is the first :. Normally we do frontend MainInfoSection: MESSAGE


Portfolio: Completed Desktop Version

This pull request includes the following updates for the desktop version of the portfolio:

[ ] responsive styling for desktop view
Top page
Cards section
Bottom page
Contact page

Please review.

Dear Reviewer,
To ensure that the portfolio is responsive and compatible with various viewport sizes, I made the following updates:

[ ] Used percentiles for the desktop viewport width of 1440px.

[ ] Incorporated vw measurement to keep the contents responsive on a minimum viewport width of 768px.

Thank you for taking the time to review these updates. Let me know if you have any questions or suggestions for further improvements.
Best regards,
Zafron 😃

@Owusu-Desmond
Thanks a lot for the review 😄


Some of the GW/SE page concordances are '0'

In the page concordance table, some of the values are "0".
In the new Opas system, these are displayed as page links, but the code should be changed to skip over these and not embed the footnote or link.

Fixed and rebuilt SE locally.  It will copy over to AWS and should be detected next time a full reload is selected (otherwise it doesn't detect any changes in the _Archive section.


DONOTSUBMIT: Add trace support for OTLP

Description
Adds trace support for OTLP.
Creating this PR now so that the integration tests can run, but it's not ready for submission yet.
Related issue

b/239598894 b/207217898
How has this been tested?

Checklist:

Unit tests

[ ] Unit tests do not apply.
[ ] Unit tests have been added/modified and passed for this PR.

Integration tests

[ ] Integration tests do not apply.
[ ] Integration tests have been added/modified and passed for this PR.

Documentation

[ ] This PR introduces no user visible changes.
[ ] This PR introduces user visible changes and the corresponding documentation change has been made.

Minor version bump

[ ] This PR introduces no new features.
[ ] This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
[ ] This PR bumps the version.

The design doc mentions that both metrics and traces need to be defined when using combined, but the following config passes:
combined:
  receivers:
    otlp:
      type: otlp
traces:
  service:
    pipelines:
      otlp:
        receivers:
          - otlp

Is this a bug, or was the intent of the design doc that metrics and traces need to be defined in the merged config, not the user config? I interpreted the design doc as referring to the user config.

Is this a bug, or was the intent of the design doc that metrics and traces need to be defined in the merged config, not the user config? I interpreted the design doc as referring to the user config.

You're correct that this is the behavior as-implemented.
We don't have any mechanism to apply validations to the user config. I think I'm assuming that users are unlikely to unintentionally try to enable traces without metrics, so it's not worth trying to hack around that.

Another config that is allowed but I think ought not to be:
combined:
  receivers:
    otlp:
      type: otlp
    otlp2:
      type: otlp
metrics:
  service:
    pipelines:
traces:
  service:
    pipelines:
      otlp:
        receivers:
          - otlp
          - otlp2

Another config that is allowed but I think ought not to be:
combined:
  receivers:
    otlp:
      type: otlp
    otlp2:
      type: otlp
metrics:
  service:
    pipelines:
traces:
  service:
    pipelines:
      otlp:
        receivers:
          - otlp
          - otlp2

I agree, that's only broken because two receivers are trying to bind the same (default, in this case) port. Checking that at validation time seems very difficult to do right (https://en.wikipedia.org/wiki/Time-of-check_to_time-of-use#Preventing_TOCTOU) but I suppose we could at least do a string comparison to see if two receivers use the exact same string as a listen address.


[$250] [CRITICAL] Multiple workspaces get created when someone either refreshes the page, or drops off and returns later.

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: v9.0.65-1
Reproducible in staging?: Y
**Reproducible in production?:**Y
**If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:**N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation : #convert thread
Action Performed:

Sign-up on expensify.com
Choose the “1-9” option on the home page (signUpQualifier: vsb)
Get redirected to new.expensify.com
Observe a workspace is created
Don’t complete the onboarding modal steps (hasCompletedGuidedSetupFlow: false)
Refresh the page
Observe another workspace is created
Type in expensify.com in the browser URL and click enter
Get redirected to new.expensify.com (classicRedirect.dismissed: false)
Another workspace is created

Expected Result:
If we’ve created a workspace for the new sign-up already, don’t create another one when they refresh or return.
Actual Result:
We create a workspace every time they refresh or get redirected to NewDot and haven’t completed the onboarding modal steps yet.
Workaround:
N/A
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Standalone
[ ] Android: HybridApp
[ ] Android: mWeb Chrome
[ ] iOS: Standalone
[ ] iOS: HybridApp
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Refreshing the page
https://github.com/user-attachments/assets/2587d4c0-7191-4ab6-847b-960ca1c30785
Returning to expensify.com
https://github.com/user-attachments/assets/9525a801-2360-46d3-b663-512c919403da
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021859580489556912069
Upwork Job ID:<PHONE_NUMBER>556912069
Last Price Increase: 2024-11-21

Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @FitseTLT

@nkdengineer This is coming from your PR here https://github.com/Expensify/App/pull/51839/files
We should not be creating the workspace on each mount forever. Only if there is no group policy the user is admin of yet

Proposal
Please re-state the problem that we are trying to solve in this issue.
Multiple workspaces get created when someone either refreshes the page, or drops off and returns later.
What is the root cause of that problem?
We are already returning early in case there is onboarding policy id set but on refresh the useOnyx will not make the data available and the effect runs too early
https://github.com/Expensify/App/blob/2d2555b173b47c0bce0b1c16b275f1f98639664c/src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx#L61-L62
What changes do you think we should make in order to solve the problem?

We should first check that onBoarding Policy ID data is loaded not loading
https://github.com/Expensify/App/blob/2d2555b173b47c0bce0b1c16b275f1f98639664c/src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx#L48
    const [onboardingPolicyID, onboardingPolicyIDResults] = useOnyx(ONYXKEYS.ONBOARDING_POLICY_ID);

if (!isVsb || !!onboardingPolicyID || isLoadingOnyxValue(onboardingPolicyIDResults)) {
            return;
        }

What alternative solutions did you explore? (Optional)

@jayeshmangwani I see the offending PR is just on the fence of the 1 week regression period and it was paid out. I think its fair if you will review this PR as part of regression still. Let us know if that sounds fine with you
@FitseTLT I think your solution makes sense, you also need to add the isLoading to the useEffect dependency but sounds good.

@jayeshmangwani I see the offending PR is just on the fence of the 1 week regression period and it was paid out. I think its fair if you will review this PR as part of regression still. Let us know if that sounds fine with you
@FitseTLT I think your solution makes sense, you also need to add the isLoading to the useEffect dependency but sounds good.

Yep I only missed it when commenting the proposal 👍

@trjExpensify I requested to become a contributor through email, but I have not received feedback for a few days. Is there another way to do this?

@jayeshmangwani I see the offending PR is just on the fence of the 1 week regression period and it was paid out. I think its fair if you will review this PR as part of regression still. Let us know if that sounds fine with you

Yes, I am definitely fine with it. We missed the case during testing

@mountiny, @FitseTLT 's Suggestion looks good to me here. Should I raise a PR quickly, or will @FitseTLT do it?

@jayeshmangwani I am already preparing 👍

Cool, please do it

Contributor details
Your Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~016c50704f37520a88

We should not be creating the workspace on each mount forever. Only if there is no group policy the user is admin of yet

I already did it but missed the refresh case. The reason is useOnyx return the onboardingPolicyID is undefined at the first time if we don't have cache data.

PR ready for review 👍

Yep, sounds good!

Slack access is still restricted, you will be notified when that's resolved, but there's no timeline I can give you on it.
Regardless, gaining access to Slack isn't a requirement to start putting proposals forward on issues labelled Help wanted. Have you looked at the issues available as I mentioned here.

@trjExpensify Thanks I will do just that.

I am finishing the checklist now. Also, @trjExpensify there is no payment due for me here, as the issue was coming from the PR where I was the C+

BugZero Checklist:

[x] [Contributor] Classify the bug:

Bug classification

Source of bug:

[ ] 1a. Result of the original design (eg. a case wasn't considered)
[x] 1b. Mistake during implementation
[ ] 1c. Backend bug
[ ] 1z. Other:

Where bug was reported:

[x] 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
[ ] 2b. Reported on staging (eg. found during regression or PR testing)
[ ] 2d. Reported on a PR
[ ] 2z. Other:

Who reported the bug:

[ ] 3a. Expensify user
[x] 3b. Expensify employee
[ ] 3c. Contributor
[ ] 3d. QA
[ ] 3z. Other:

[x] [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/51839#issuecomment-2520096398

[ ] [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A

[x] [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

For the regression test, I would say the testing steps will be sufficient here.
Regression Test Proposal

Sign up on expensify.com.
Choose the “1-9” option on the home page (signUpQualifier: vsb).
Get redirected to new.expensify.com.
Observe that a workspace is created.
Do not complete the onboarding modal steps (hasCompletedGuidedSetupFlow: false).
Refresh the page on web or close and re-open the app on native.
Verify that another workspace is not created.

Do we agree 👍 or 👎

I am finishing the checklist now. Also, @trjExpensify there is no payment due for me here, as the issue was coming from the PR where I was the C+

Ah okay, so just payment to @ishpaul777 and @FitseTLT. Is that correct?

Is that correct?

Yes

Payment summary as follows:

$250 to @ishpaul777 for the C+ review (can you accept the offer, please!
$250 to @FitseTLT for the fix (offer sent!)

@trjExpensify accepted

Paid you!

Thanks! Accepted offer!

Paid, closing!


Fix: Typo on motivation json file for spanish

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the main branch of freeCodeCamp.
[x] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Fixed missing accents on compliments and motivationalQuotes for spanish.

LGTM 🥳
@Mikadifo Thank you for taking care of that.

Thank you for your continued contribution to our project. We have reviewed your pull request and are happy to accept these changes.
Please continue to watch for issues labelled help wanted, as these will be additional opportunities to contribute.


Better RakugoMenu

Now RakugoMenu is as 2 Control nodes VRakugoMenu (vertical version), HRakugoMenu (horizontal version).
But there code is almost the same except one line - it shouldn't be that way.
Fortunately I discover that I can have vertical, horizontal and even gird version at once extending from GridContainer.

partialy done in #187 and #188


Error creating Digital Twins using API

Initially I would like to be able to create a space with Digital Twins Service Management APIs.
I followed the steps for creating the Digital Twins resource, as well as registering an application in Azure Active Directory. With the client ID, log in to Digital Twins Service Management APIs
after that I created a body for create a space
Following the model described in Digital Twins Service Management APIs.
I executed the request and I get error in the attached document.
I give it a SpaceSubtype and it gives me System Error, I have searched the Microsoft documents about it and I don't find much, nor any tutorial about creating a Space, or any resource that manages Digital Twins from Digital Twins Service Management APIs,or or from Azure Functions. The only thing that has worked for me is the Gets, but they don't return anything because I still can't post. Could you help me on this with documentation or some example, .
Thanks
errors.pdf

I'll move this issue to the Digital Twins repository


12.1.1

Thanks!  Add a changelog entry and I'll get this merged and built.

https://copr.fedorainfracloud.org/coprs/carlwgeorge/ripgrep/build/1858399/

https://copr.fedorainfracloud.org/coprs/carlwgeorge/ripgrep/build/1858399/


Investigate correctness of the suggested EuroVoc concepts

Make sure that only acceptable Concepts are considered, especially the ones with non-numerical IDs like http://eurovoc.europa.eu/c_a62dbeba

It is actually correct.


feat: implement simple spread attributes

As discussed in Discord, here's a simple PR for some basic spread attributes support for items implementing IntoIterator<Item= (&'static str, Attribute)>.
Essentially, you can do the following:
let attrs = ["value", 1.into_attribute()];
view! { <input {..attrs} /> }

and it'll spread the attributes from the iterator into the component as if they were applied normally.
I've tested it and it seems to work correctly, this is my first PR to leptos as well so no idea if I did any of this correctly but please let me know. :)

Wow this is great, thanks so much. I should've done this ages ago.
This will also allow me to add something to <Component/>s like an attr: syntax and also the spread syntax, and interpret both of those as something like "pass a prop named attributes which is a Vec<&'static str, Attribute> to the component.
So you can have
#[component]
pub fn Input(attrs: Vec<(&'static str, Attribute)>) -> impl IntoView {
  view! {
    <input class="fancy-input" {...attrs}/>
  }
}

view! {
  <Input attr:type="text" attr:placeholder="Hello!"/>
}

I'll do that in a separate PR of course.

Thank you for letting me do it! :) And that syntax sounds great, if you'd like I can make a PR for that or something similar, whatever you'd like (it's the exact reason I wanted spread props in the first place so I'm more than happy to implement it :) ).

If you want to work on it, that would be awesome! You may have time to get to it sooner than I do.

Awesome! I'll get something worked out. :)


/creative gives error message when used

Hey there, I mentioned a bit ago I was having trouble with the error message and just wanted to get the issue report made out since it's been a bit and I still can't find the culprit
I'm using the latest version, 1.0.7 and way too many mods, you can see the log for the list but I almost don't know that it's going to help very much
The log is quite long so I've isolated exactly when I tried to use the command: latest.log
Here's what the log says when using in the overworld:
[03:44:23] [Server thread/INFO] (building_dimension) Player : UltimuShadow is switching to creative dimension
[03:44:23] [Server thread/INFO] (building_dimension) Saving position for UltimuShadow at (-10.063967538003608, 87.5777683166755, -6.885902726474604)
[03:44:23] [Server thread/INFO] (building_dimension) Saving inventory for UltimuShadow
[03:44:23] [Render thread/INFO] (Minecraft) [CHAT] An unexpected error occurred trying to execute that command
latest.log
And in the building world:
[03:44:56] [Server thread/INFO] (building_dimension) Player : UltimuShadow is switching to survival dimension
[03:44:56] [Server thread/INFO] (building_dimension) Loading game mode for UltimuShadow
[03:44:56] [Server thread/INFO] (building_dimension) Saving inventory for UltimuShadow
[03:44:56] [Render thread/INFO] (Minecraft) [CHAT] An unexpected error occurred trying to execute that command
Are you using a custom command to move the player to the building dimension that could be causing a conflict? Or have any ideas on what kind of mod would interfere with it, so I can isolate it a little easier?

Hello,
It's probably because it cannot find the destination, I'm using a custom function made with the Fabric API which shouldn't require anything except the Fabric API mod which should be included with every modpacks.
Are you planning on getting started very soon (on your server / solo) ?
I could either release a quick patch that would allows to identify the source and then release a patch once i found the source
Or you wait for a few hours (maximum tomorrow night) and i release the 2.0.0 version of the mod I'm working on that could fix it and if it doesn't will have way better checks that should allows to find the source of the bug since I'll completely changing how the mods works (and would lose any inventory in the creative dimension)

I am a bit early and 2.0.0 should be out.
The one thing i remove was the achievements that are not saved for now since they are a bit painly to work with but i will work on them very soon.
The new version has a lot more debugging integrated that should allow you to give me where exactly is the error and correct it pretty fast.
Also it has support for the Nether and the end (other customs dimensiosn should work but i haven't tested yet)

Hello, have you tried with the 2.0 version ?

Thanks a lot for your reply and the encouragements.
I got them working and tested a bit, the next version should come soonish, I had a lot of work for school.

Ah you know what, that's a good point, I have Trinkets installed as well and a shulker box slot on top of that so that's 27 slots to smuggle through at a time, I hadn't tested that before but it definitely warrants interest. I'll check it out when it drops!


Mixed Reality native objects in Unity

Adding documentation on how to access native Holographic frame objects in Unity

Docs Build status updates of commit bc9bb35:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

mixed-reality-docs/TOC.md
:white_check_mark:Succeeded
View

mixed-reality-docs/unity-xrdevice-advanced.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@thetuvix to review


Translations entered on results page missing from JSON

On the results page, the user can enter translation for free-text elements entered during the questionnaire. After entering these translations, saving the JSON does not save the translations. They have to be re-entered.

Hi! Just wondering if that's a feature request or if that's a bug?
As in: are the French text boxes supposed to be there at all? (I assume this is to support users in producing bilingual reports?)

I've quickly looked at the behavior and although the content of French translation boxes (or English if you ran the survey in French) for the results are in the exported documents, there is no trigger to save it to the JSON file.
In order to update the JSON with the text boxes there would need to a "save the translation" function.
It's doable but then I'm wondering if it the most practical way of letting the users fill in bilingual assessment forms. Might have a look at saving the results content to an editable text-based document instead?
Or have people fill in the assessment in both official languages? Just trying to figure out best way forward to meet the need :grinning:

The French (or English) capture boxes on the result page are there to generate the bilingual PDF version which is downloadable at the bottom of the page. These bilingual docs are needed to publish the results on the open gov portal. See Issue #132 and Issue #133.
A button "save the translations" would work. I had hoped that the save button already present at the top of the result page (Issue #120) could play that role.
I see the JSON as the current work in progress. It should be able to persist any and all work done by the user so far, so that it can be loaded and resumed later. The "Save" button available throughout should serve the role of making the full json ready.

Not sure if this is useful, but it may be possible to use a calculated value to add the translation data to the surveyjs' json. The expression of the calculated value would call a custom function that would assemble the translation data. The JSON load would need to be modified to extract this data before it is re-calculated.

@MrDeshaies Thank you for your comments. I found in the results page, the section showing different from the Export at the bottom. E.g. Project Details is located in Section 3.1 under Section3, but in export section, it is located outside section3, at the beginning. Could you confirm if this is by design?

Yes, I confirm the ordering of project details is intended to be different between the results page, and the PDF.  When completing the AIA, the user wants to see his score and requirements; since he just completed the AIA, he knows the details of the project.  However, the PDF export is meant for a member of the public, who wants to understand details about the project (3.1) first; the score and impact level is a secondary consideration for members of the public.


Deployment Reverse Proxy Setup

Being able to deploy the full docker-compose.yml stack as is in non-dev environments, ie. staging or production, would be very comfortable. Apparently we can do that seamlessly, but still flexibly, by providing yet another reverse proxy setup
server {
    listen       80;
    server_name  rabbitmq.fishtank;
    location / {
        proxy_pass http://rabbitmq.localhost:8888;
    }
}

server {
    listen       80;
    server_name  prometheus.fishtank;
    location / {
        proxy_pass http://prometheus.localhost:8888;
    }
}

server {
    listen       80;
    server_name  grafana.fishtank;
    location / {
        proxy_pass http://grafana.localhost:8888;
    }

}

server {
    listen       80;
    server_name  indexer.fishtank;
    location / {
        proxy_pass http://indexer.localhost:8888;
    }
}

server {
    listen       80;
    server_name  trade.fishtank;
    location / {
        proxy_pass http://trade.localhost:8888;
    }
}

This should later be integrated into a potential deployment pipeline or at least checked into Git.

Done


GetArticle from html string

Hi,
Can you please add possibility to parse article from html string without having to extract it from the uri? It looks like the constructor Reader(string uri, string text) prepares parsing without having to call the uri. But when calling GetArticle it will still get new html content from the uri.

This should be the intended behaviour. It's a bug and I will fix it. Thanks for having found it.


convert to filescoped namespaces

convert to filescoped namespaces
use collection expressions
removed prefix m_ from private fields

Alright. You convinced me. Would you like me to change it in this PR or in another one?

I don't mind - wherever is most convenient (:

@fluffynuts I've adjusted the names with the help of the refactoring in rider and added the missing entries in .editorconfig.


added ability to use prevalidate with complex objects in a hash as a pa...

...rameter
This current library validates complex objects just fine (issue #224), however, the errors object is not being populated with the errors from the complex objects that are also being validated.
For an example model and view:

 var User = Backbone.Model.extend({
    validation: {
        name: {
            required: true
        } ,
        'address.street': {
            required: true
        }
    }
});

var NewUserView = Backbone.View.extend({
    ...  // template, render, intialize, events
    submitUser: function() {
        var rawUserFormData = {
            name: this.$el.find('input.name').val(),  // empty string
            address: {
                street: this.$el.find('input.street').val(), // empty string
                city: this.$el.find('input.city').val()
            },
            .....
           var newUser = new User();
           var errors = newUser.preValidate(rawUserFormData);

           if(errors) {
               // do something with errors in ui
               return;
           }
           newUser.set(rawUserFormData);
           newUser.save();
        };
    }
});

Before this PR, this is what the errors object will look like:
     {
        'name': 'Name is required'
     }

But afterward, all of the validation items set in the model will populate the errors object:
    {
        'name': 'Name is required' ,
        'address.street': 'Address. street is required'
    }

I did change the preValidate signature param name (there were a lot of 'value' floating around), but can easily change that back.

the errors object is not being populated with the errors from the complex objects that are also being validated.

Good one, man! We'll be packaging this in the next release.

@chiefGui thanks!!  I'm happy to write a little bit on how this new behavior works.  Just to make sure I understand the request, do you want me to edit the existing README for this repository?  Or create another file?

The community have to thank you for this contribution, man.
Anyway, create a flat README.md file because a few things will change in the next update(s) then I can't guarantee the file will have the same structure and to avoid conflicts, just create a new one and link it here if possible.
Thank youuu!!


Transform op - database is not picked from metadata

Describe the bug
with DAG(dag_id="test", schedule=None, start_date=datetime(1970, 1, 1)) as dag:
    @aql.transform
    def select(input_table: Table):
        return "SELECT * FROM my_db.my_schema.my_table LIMIT 4;"  # {{ input_table }} was also failing
    select(
        input_table=Table(metadata={"schema": "my_schema", "database": "db"}, name="my_table", conn_id="my_conn_id"),
        output_table=Table(name="fritz_test_1234")
    )

snowflake.connector.errors.ProgrammingError: 090105 (22000): 01a77af0-0605-96b0-0000-682112f6e8ae: Cannot perform SELECT. This session does not have a current database. Call 'USE DATABASE', or use a qualified name.
ref: https://astronomer.slack.com/archives/C02B8SPT93K/p1665414029917169
Version

Astro: 1.1.1

To Reproduce
Try the above code.
Expected behavior
If the DB is not specified in the connection we should be able to pick from metadata.

This looks like a problem when using snowflake. I quickly tested the  bigquery worked fine

For the hook creation in astro-sdk we tightly depends the airflow connection
for example
 @property
    def hook(self) -> BigQueryHook:
        """Retrieve Airflow hook to interface with the BigQuery database."""
        return BigQueryHook(gcp_conn_id=self.conn_id, use_legacy_sql=False)

Snowflake hook expects the database, schema, etc., so the ideal place to set these values is a connection only. Even in our case we do
 @property
    def hook(self) -> SnowflakeHook:
        """Retrieve Airflow hook to interface with the Snowflake database."""
        return SnowflakeHook(snowflake_conn_id=self.conn_id)

If a user is setting up the schema, and database in the input and output table in the transform operator which value should we use from input_table or output_table or will we create multiple hooks? it looks a little bit complicated to me in the current design.
For now, I have modified the create_database method to accept conn_id as well as a table and I'm passing the output table from the base database class and setting the schema and database in the snowflake hook if the table metadata has these values.
I'll if fix the CI if people will agree with the approach. PR https://github.com/astronomer/astro-sdk/pull/1117


Azure App Service Deploy (Preview) failing consistently - An unknown error has occurred

Environment

Server - Azure Pipelines

Account: tagdat
Project Name: Geodis
Build Name: Geodis Portal
Build No: 20181218.1

Agent - Hosted

Queue: Hosted Ubuntu 1604

Issue Description
Azure App Service Deploy task has started to fail consistently with a very obscure error:

An unknown error has occurred. Check the diagnostic log for details.

Seems to occur during the KuduSync operation. The task is set to Version 4.* (Preview), and the same build is successfully deployed to a different app in another region.
Task logs
Verbose log
Error logs
2018-12-18T22:54:34.7692805Z Running deployment command...
2018-12-18T22:54:34.7696500Z ##[debug][GET]https://tagdat-geodis-staging.scm.azurewebsites.net/api/deployments/3f6f829eeb8048cea583fc5dd6f33428/log/e22354db-ed0b-4b84-91d8-3d895ddfd12d
2018-12-18T22:54:35.3857645Z ##[debug]getDeploymentLogs.  Check the diagnostic log for details.
2018-12-18T22:54:35.3948334Z ##[error]Failed to deploy web package to App Service.
2018-12-18T22:54:35.3957448Z ##[debug]Processed: ##vso[task.issue type=error;]Failed to deploy web package to App Service.
2018-12-18T22:54:35.3957711Z ##[debug]Deployment Failed with Error: Error: Package deployment using ZIP Deploy failed. Refer logs for more details.
2018-12-18T22:54:35.3958034Z ##[debug]task result: Failed
2018-12-18T22:54:35.3958342Z ##[error]Error: Package deployment using ZIP Deploy failed. Refer logs for more details.
2018-12-18T22:54:35.3958584Z ##[debug]Processed: ##vso[task.issue type=error;]Error: Package deployment using ZIP Deploy failed. Refer logs for more details.
2018-12-18T22:54:35.3959421Z ##[debug]Processed: ##vso[task.complete result=Failed;]Error: Package deployment using ZIP Deploy failed. Refer logs for more details.

Workaround - switching Azure App Service Deploy to v3.* works.

@jameshowe Can you share complete debug logs at<EMAIL_ADDRESS>Set variable System.debug with value 'true' in the release and deploy again. Share logs generated.

@SumiranAgg the verbose log I included is the log for that task action with system.debug=true enabled. What other logs are you looking for?

Can you share kudu trace. Visit kudu Url: https://tagdat-geodis-staging.scm.azurewebsites.net/api/vfs/LogFiles/kudu/trace
Try to find a file around below timestamp as per the logs shared:
"log_time":"2018-12-18T22:50:42.834369Z"
This might have more information about the failure. Please share that trace if possible.

@SumiranAgg unfortunately I can't see any file for that date, I think the logging may only be enabled for last 24 hours as I can only see logs for today. FWIW I've had problems before deploying on Linux via Kudu Sync using v4.* (Preview), now that it's been fixed switching to v3 I'll switch back to v4 and post report back if it starts failing again.

@ian-a-anderson - can you please share the logs to RM_Customer_Queries at microsoft.com

@ian-a-anderson Can you share more information? What package type are you deploying, which runtime stack is selected, what is the error message you see?

K, shared

On May 10, 2019, at 8:47 AM, Muthukumaran Kasiviswanathan<EMAIL_ADDRESS>wrote:
@ian-a-anderson https://github.com/ian-a-anderson - can you please share the logs to RM_Customer_Queries at microsoft.com
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/microsoft/azure-pipelines-tasks/issues/9118#issuecomment-491276509, or mute the thread https://github.com/notifications/unsubscribe-auth/AAUIX4N4MGLZPINVCSSFLX3PUVVGLANCNFSM4GLFCMLA.

@SumiranAgg We are deploying a PHP Zip file to Azure App Service for Linux on a Premium (P1V2) Linux App Service Plan. It fails during the Kudu Sync step while processing files:
2019-05-08T04:06:36.2389539Z Command: "/home/site/deployments/tools/deploy.sh"
2019-05-08T04:06:36.2389838Z Handling Basic Web Site deployment.
2019-05-08T04:06:36.2390093Z Kudu sync from: '/tmp/zipdeploy/extracted' to: '/home/site/wwwroot’
…
….
2019-05-08T04:06:36.2403894Z Processed 11560 files...
2019-05-08T04:06:36.2404111Z Processed 14025 files...
2019-05-08T04:06:36.2404338Z An unknown error has occurred. Check the diagnostic log for details.
2019-05-08T04:06:36.2478968Z ##[error]Failed to deploy web package to App Service.
Note that we deploy this exact same Zip file to identical (Premium P1V2) Windows instances without issue. This problem is intermittent, and specific to App Service For Linux deployments. We have seen this occur in multiple Azure Regions - so this isn't a flaky instance or zone-specific issue. It seems like a bug in the Azure App Service Deploy task itself, which only occurs on App Service For Linux deployments. Azure Support staff have mentioned that it appears to be causing a Docker Container restart, which is killing the deployment process.

@ian-a-anderson  this seems like an issue on app service side. I have created a bug with Kudu team to investigate further #2972

@ian-a-anderson
Since this issue is being tracked on Kudu side, so closing this one.?
Also, if some other info is to added, the customer can directly add it here only projectkudu/kudu#2972

i face the same error now

@PhilipsonJoseph @v-nagarajku - pls follow up with Product to prioritise this on AppService team

Reproduction Steps:

Create a new React app with npx create-react-app my-app
Add a GitHub actions workflow using the sample node.js-webapp-on-azure.yml
Run the workflow to deploy to a Linux F1 Azure App Service

Unfortunately it does not seem to fail consistently - so I am unsure what causes it.

Experiencing a similar issue

Ditto. Consistently failing. :-(

Facing the same issue... I tried to deploy a default Next js to azure web app


Usability: accessing private repos

if I have a private repo (or more than 1 !!!) it asks all the passwords at the beginning. Very inconvenient. I'd suggest skipping automatic repo update or skipping private repos update and initiating then after explicit "refresh" for a repo or global "Refresh all".
Unchecked repos can be displayed as a placeholder block, mentioning something like "This is a private repo and requires login. Please press me to update". I can design this.
So:

user runs abapgit
it checks each repo, if repo requires pass, it falls back to the place holder
Placeholder can be also done clickable like a big button ("...press ME to update...")
the user can press "Refresh All" at the top to refresh all repos (the login dialog should show the repo name)

Relevant: #45, #202

also see https://github.com/larshp/abapGit/issues/207 it is mainly to avoid refreshing a lot of repositories.
If there are 5 repositories installed, typically a developer is working on one at a time. So the hiding allows for hiding 4 of them, and only have one being automatically refreshed.
Perhaps the private repo issue and hiding feature can be combined somehow.

hi,
errors have now been isolated to each repository in https://github.com/larshp/abapGit/commit/b8cbfbc0e2e106e91240a3980057f72d0b162ea2 and hide feature implemented in https://github.com/larshp/abapGit/commit/6575f9834f4830c740f7e19338acc629c56facb2
can you try again and see if it works better with the new features?

Show/Hide is good for sure. Adds a lot of convenience. :)
I would also store default email per repo per user. Kind of login manager. The lcl_login_manager is only for background for the moment. I'll look into it later in a separete ticket. So closing this one for now.

login manager, see #251