Better handling of count alerts

A very common use case is to alert if the count of some event is higher than some threshold over a time window. For example, errors, timeouts, logins, requests. Currently we can simulate this by adding a point to InfluxDB with a meaningless value (e.g. 1) each time the event occurs. We can then compare the count of these values over a window and compare it against the alert threshold. We only use the Batch Kapacitor nodes, by the way.
The problem is, this doesn't work well if the count violates the threshold for one batch, then drops to zero, since we don't get the alert OK state because a batch with zero points is not emitted. If the next time the count goes over zero it also goes over the threshold, we'll miss the second alert. This gets more likely to occur as the event we're monitoring for becomes rarer. Obviously an alerting system has to work reliably for users to trust it, so we disabled (the frequently requested) alerting by count feature.
While I haven't tested this, I imagine similar issues would crop up if we used deadman's switch with group-by. E.g. how do we know to alert for some tag set if we haven't seen it before?.
I fully understand that InfluxDB may be reluctant to return counts of zero instead of not returning results, since it can't guess tag values for those empty points. But perhaps Kapacitor can overcome this limitation.
Below, I use the term "tag set" to refer to one specific combination of tag values.
Non grouped by tag alerts
We can simply check if a batch has produced no points and infer a count of zero (or a NaN/error for other aggregations) for that batch. I don't mind if we keep emitting batches with a count of zero after the first one, since the main goal is to allow the alert to reset back to OK.
Grouped by tag alerts
For the group by case, we may not want to keep running and processing alerts for a steadily growing number of tag sets, so once the count for some tag set drops to zero we could only emit the next batch with a count of zero and not emit subsequent batches until we see another point (i.e. forget about that instance of the alert for that specific tag set). This should allow the alert to reset to OK and stop consuming resources.
The same behavior could be achieved for the deadman functionality, with a caveat. We wouldn't be able to alert for low counts on tag sets that have never been seen before, but since the "normal" state is to have points being produced constantly (which is why we want to alert when we stop seeing them), this shouldn't be an issue in practice. Once we've seen at least one point for some tag set, we can emit a batch with a count of zero for it the next time we evaluate the batch, then forget about it until we see points for it again.

@lpalm Thanks for the detailed write up.
Currently the deadman switch works are you describe with one exception, that it will never forget a given tag set and will continue to emit 0 for it forever. I like the suggestion of dropping it after a single 0 has been emitted.
Also in the case that the deadman's switch receives no points at all it will emit 0s for a nil tag set so that you know that nothing is being received.
Using example of errors this TICKscript should do what you want...
batch
    |query(''' SELECT value FROM errors''')
       .period(1m)
       .every(1m)
    |deadman(0.0, 2m)

or if you need more control you can use the stats node directly which is what deadman uses under the hood.  https://docs.influxdata.com/kapacitor/v0.13/nodes/stats_node/
https://docs.influxdata.com/kapacitor/v0.13/nodes/query_node/#deadman
something like
batch
    |query(''' SELECT value FROM errors''')
       .period(1m)
       .every(1m)
     |stats(2m)
     |derivative('emitted')
            .unit(2m)
            .nonNegative()
     |alert()
         ...

I believe this will work as you expect, but if I have misunderstood please clarify.

@lpalm Also note that |count is not used explicitly since each point represents an event and the counting is being done implicitly via the stats node.

Hi Nathaniel,
Thanks for the information. Sounds like deadman/StatsNode will do exactly what we'd like it to do for counts dropping below a threshold. But what about alerting if a count goes above a threshold (let's say, 10 in one minute), and making sure that it resets back to OK if the count drops to zero?
And a tangential question about the use of nonNegative: If we take the derivative() (current - previous) and add .nonNegative(), doesn't that mean that we're skipping negative derivatives (i.e. when the 'emitted' value becomes smaller), and thus not alerting when the 'emitted' value drops below the threshold, since the derivative would always be negative when that happens?

Yes, nonNegative skips values where the derivative would be negative. But the emitted value is an increasing counter (total points emitted since task started), it never decreases. So the derivative will go to 0 but not negative.

Got it. Thank you. My final outstanding question is if there is a way to alert the second time if some count goes above the threshold, drops to zero, then goes above the threshold again.

@lpalm It should alert the second time. Do you mean only alert if it happens twice?

I was under the impression that for a batch with zero points, no window was emitted, so that we could miss alerts. E.g. Let's say we want to alert if the count goes above 5 and we have the following sequence of counts at each batch evaluation:
0 // No window emitted, OK
3 // Window emitted, below threshold, OK
6 // Above threshold, CRITICAL -> alert
0 // No window emitted, CRITICAL still, but no state change, so no alert
10 // Above threshold, but since we're still on critical, a second message isn't sent
Sounds like by using the stats node, we'll actually emit windows for the times we get zero datapoints and go back to the OK state on the fourth window above, allowing the fifth window to trigger the alert for a second time. I just wanted to confirm that this was the case.

@lpalm  Yes, you are correct. The stats node will emit the 0 and resolve the alert so that it will trigger a critical a second time.
Although you will run into a second problem, which is that the emitted value is the number of windows emitted not the number of points in the window. I have debated the usefulness of this and I think its time to change the emitted count for batch edges to be the number of points in the batch. I'll be playing around with this for a bit and let you know what I do.

Much appreciated. Feel free to close this if you plan on letting me know in a different way. All my questions here are answered.

@lpalm  Thanks, see #605 for info on how the StatsNode will count batches. In short is being changed to be by number of points not number of  batches.

Querying over this thread as it seems to match my usecase.
Now, since the statsNode return the number of points. I am in a fix how it works with the queryNode's every and period property.
Like the example above where a batch is return every 1 min with the data of 1 min while the stats node emits data every 2 mins.
Is the flow something like
at t=0, the script started.
at t= 1m, the batch returned 'n' points from last 1m(period) influx data
at t= 2m, the batch returned 'm' points from last 1m influx data
stats node emits n+m points or n points only? since the query for influx data triggered by every at 2m in the timeline would take time to return ?
I an just starting up with tick stack. Sorry if I am thinking otherwise.
It would be helpful to get some idea behing every, period property and how stats node adds with it.
@nathanielc


Script to Integrate RAETracker with TrackingMetrics

Hey @ProfFan can you check out this PR to see if it's valid to merge? This script Andrew01.swift outputs the plots and images we went over on Friday. We will improve it over time, but I wanted to merge it since it does fulfill the functionality of integrating the RAETracker with TrackingMetrics to output metrics over n number of sequences.

Thanks for reviewing @ProfFan! Do you mind meeting this PR? I don't have write access to the repository so I can't merge it myself.

Thanks for reviewing @ProfFan! Do you mind meeting this PR? I don't have write access to the repository so I can't merge it myself.


Updated my profile

I just updated my profile on the website to fix the broken links and update my CV.

If you changed your handle, you might need to change it in the projects


login issue

Describe the bug
m trying to implement this with expo project
when the user login for the first time it return null token and doesnt navigate to next page , the second login works , is there any solve for this issue ?
To Reproduce

Would be great if you could post some of your source code so we can see your issue.


Access denied

Cant connect, no idea why.
Regards.

This is beacuse the character/corp/alliance is not on the allowed list in pathfinder.ini
You can find instructions here: https://github.com/exodus4d/pathfinder/wiki/INI-FILES#pathfinderini
And the relevant config lines here: https://github.com/exodus4d/pathfinder/blob/master/app/pathfinder.ini#L73


Use yarn workspaces on master

See https://github.com/storybooks/storybook/pull/1803#issuecomment-332990394

This is happening on my machine:

This doesn't look right to me:
https://circleci.com/gh/storybooks/storybook/13728?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

This is happening on my machine
Which yarn version do you have?

I can confirm this on my machine now.
I tested bootstrapping everything, cra-kitchen-sink, docs


peazip: 9.9.0 → 9.4.0

The tag 9.9.0 was accidentally created and is not an actual release of a new version.
Fixes #259270.
Description of changes

changed version to 9.4.0 and updated source hash accordingly

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 260284 run on x86_64-linux 1

1 package built:

peazip


Add documentation for the settings UI

Only the Add documentation for the settings UI commit is to be reviewed here; the earlier one is part of previous pull request.


build(webpack): remove publicPath so webpack_public_path can be used to host assets

This will allow host to upload assets in CDN using  __webpack_public_path_ as mentioned here.
For other cases host can load using script tag which will take care of loading the assets from CDN as shown here

[x] Tested  __webpack_public_path_ is working for non CRA apps
[x] Update Readme

Blockers

[x] It's not working in the CRA app, check here

EDIT
It's working fine with CRA as well I checked the same example in local. Looks like an issue with the code sandbox.
Works fine with non-CRA apps and CRA apps as well.

Haven't tried locally yet. So if CRA users don't supply __webpack_public_path_ (where exactly?), they'll need to switch from /excalidraw-assets to static/js/excalidraw-assets?

Haven't tried locally yet. So if CRA users don't supply __webpack_public_path_ (where exactly?), they'll need to switch from /excalidraw-assets to static/js/excalidraw-assets?

Haven't tried locally yet. So if CRA users don't supply __webpack_public_path_ (where exactly?), they'll need to switch from /excalidraw-assets to static/js/excalidraw-assets?

@dwelle so for CRA(Since CRA internally serves lazy loading assets from static/js path so the assets need to be copied to public/static/js)
But if it needs to be served from a different URL for example cdn then PUBLIC_URL needs to be updated as in env variable or CLI then the assets will be served from {PUBLIC_URL}/static/js path

Haven't tried locally yet. So if CRA users don't supply __webpack_public_path_ (where exactly?), they'll need to switch from /excalidraw-assets to static/js/excalidraw-assets?

@dwelle so for CRA(Since CRA internally serves lazy loading assets from static/js path so the assets need to be copied to public/static/js)
But if it needs to be served from a different URL for example cdn then PUBLIC_URL needs to be updated as in env variable or CLI then the assets will be served from {PUBLIC_URL}/static/js path

This change would help us a lot at Slite! If there is anything we could do to help push this forward, let me know!

This change would help us a lot at Slite! If there is anything we could do to help push this forward, let me know!

Yep, this change will help host apps to host their assets and works fine with CRA(downloading the example and setting public URL works) and non-CRA apps. I have been waiting for code sandbox issue to get resolved so the example doesn't break but looks like it will take some time. I am ok with merging it. @dwelle what do you say?

Forgot to get back to this. Feel free to merge. :+1:

Will add this in next release which we will be doing soon 🎉


Check that theme support tags in style.css are being supported.

Rule type:
ERROR
Rule:
ERROR | Verify that tags in style.css that are related to theme support are being supported by the theme.

Rule as it is found in the handbook.
Core Functionality and Features
The theme tags in style.css and description must match the what the theme actually does in respect to functionality and design.
Ref: https://make.wordpress.org/themes/handbook/review/required/#core-functionality-and-features

custom-header -> if present must have add_theme_support('custom-header')
custom-background -> if present must have add_theme_support('custom-background')
custom-logo -> if present must have add_theme_support('custom-logo')
post-formats -> if present must have add_theme_support('post-formats')
featured-images -> if present must have add_theme_support('post-thumbnails')
featured-image-header -> if present must have add_theme_support('post-thumbnails')
custom-menu -> if present must use register_nav_menu() or wp_nav_menu()
Theme check file covering this rule:
There really is no theme check covering this rule.
Note that this is a different sniff then Issue #28.
Notes for implementation:

This sniff will rely on the $theme_data array from the AbstractThemeSniffClass. More specifically the tag list.
This sniff will rely on the $sniff_helper array from the AbstractThemeSniffClass. More specifically the theme supports list.
Testing will require that a style.css file is in the same folder as the test file.

To do:

[ ] Create unit tests
[ ] Create new sniff
[ ] Adjust existing WPCS / PHPCS sniff and send in PR upstream.
[ ] Add existing sniffname sniff to the ruleset.

I have this sniff ready to go, however it uses the $sniff_helper array from the proposed WordPress_AbstractThemeSniff class.

Related PRs #56 #55

This can't be done properly with PHPCS.


Fix exit_recursed_scope_type dtor cleaning requestor early

Because of disabled RVO, exit_recursed_scope_type destructor was called on return statement in recursed_scope_type::reset, making the call ineffective. This change allows to use it as intended when RVO is disabled.

Thank you!
The shared_ptr<> will undo the performance provided by the recursed pattern. Another approach to try is to make exit_recursed_scope_type moveable and only set that->requestor = nullptr when that != nullptr. The move constructor would make sure that only the destination had that != nullptr

@kirkshoop Thank you for clarification. I have applied the changes as you have described.

Looks great!


feat(CategoryTheory): coskeletal simplicial objects

A simplicial object X is n-coskeletal if the identity natural transformation X is a right extension of its
restriction along (Truncated.inclusion (n := n)).op recorded by rightExtensionInclusion X n.
Co-Authored-By: Mario Carneiro and Joël Riou

This implements a suggestion made in #19057.

This is much nicer now. Thank you so much @joelriou. I'm sorry I made this so much more complicated than it had to be.
Let me know if you'd like me to add the dual IsSkeletal.

(boarding a plane so I'm removing awaiting author somewhat optimistically...)

Now, it looks good enough for me!
maintainer merge


New behavior for calendar button

I find more productive a long press to go in the current day and tap once to show month calendar view.
Let me know what is your opinion about this.
Perhaps it would require a switch that reverses behavior according to the user’s preference?

I find more productive a long press to go in the current day and tap once to show month calendar view.
Let me know what is your opinion about this.
Perhaps it would require a switch that reverses behavior according to the user’s preference?

I think it's really possible to add a switch to the settings to control the expected reaction of the button


docker run fails with dependency error

Running the docker build and docker run on master is giving me this error:
module.js:540
    throw err;
    ^

Error: Cannot find module 'glob'
    at Function.Module._resolveFilename (module.js:538:15)
    at Function.Module._load (module.js:468:25)
    at Module.require (module.js:587:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/usr/src/app/server.js:8:14)
    at Module._compile (module.js:643:30)
    at Object.Module._extensions..js (module.js:654:10)
    at Module.load (module.js:556:32)
    at tryModuleLoad (module.js:499:12)
    at Function.Module._load (module.js:491:3)

I verified on a second machine.

I believe that the issue is that glob is listed as a dev dependency

Thanks for reporting this, and for the fix!


Update keycloak basic deployment guide

Red Hat Single Sign-On Operator does not yet support KeycloakRealmImport, so we need to put these changes behind the upstream/downstream switch.


Question: What is the correct method for adding custom buttons to Geoman?

Apologies if this is documented somewhere but I was trying to add a custom button to the geoman toolbar which participated in the button toggling that the existing buttons perform.
You can see in this fiddle that the top button toggles any other buttons which are toggled when clicked but not the other way around. Existing buttons do not toggle off the custom button when clicked.
https://jsfiddle.net/Imbick/hxt07L5j/
I may well be doing this completely wrong but couldn't find any documentation on what is the correct technique for this.

This week we will release a new Version where you can create custom buttons.
Look into: #602

This week we will release a new Version where you can create custom buttons.
Look into: #602

Thanks @Falke-Design, glad to hear it's progressing.


Migrate away from bintray.com services since it's shutting down

The download links on https://www.boost.org/users/download/ use dl.bintray.com for downloads.
On https://bintray.com/boostorg page there's a large banner:
"Attention: All Bintray services will be deprecated and your accounts will be disabled on May 1st 2021."
this links to https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter
It is necessary to migrate away from bintray.com services before the shutdown. The schedule is explained in the link above.

Yes; we are working on an alternative. When we have something to announce, it will be on the website and the mailing lists.


Can I use LSTM networks with PPO?

The documentation doesn’t mention any explicit limitation and external papers have used LSTM before.
I get the following error when I try it with CartPole. Preset file: CartPole_ClippedPPO_LSTM.txt
InvalidArgumentError (see above for traceback): You must feed a value for placeholder tensor 'main_level/agent/main/online/network_0/middleware_lstm_embedder/Placeholder_1' with dtype float and shape [1,256]
[[node main_level/agent/main/online/network_0/middleware_lstm_embedder/Placeholder_1 (defined at ../coach/rl_coach/architectures/tensorflow_components/middlewares/lstm_middleware.py:65)  = Placeholderdtype=DT_FLOAT, shape=[1,256], _device="/job:localhost/replica:0/task:0/device:CPU:0"]]

I added support for clippedPPO with LSTM in PR number #156 with presets for CartPole and Mujoco.
You can check it out and see if the implementation suits your use case, as there are a few different ways you can approach implementing an LSTM middleware into ClippedPPO.


Cannot run unit tests for .NET core in dll with target platform x64 via IDE

Description

Changing the platform to x64 and building the project. Discovery kicks in, but no tests are reported in the TestWindow.

Steps to reproduce

Create a .NET core unit test project.
Change the target platform configuration to x64.
Build the solution

Expected behavior

The tests should get discovered.

Actual behavior

Discovery ends and no tests are discovered.

No repro.


Support for DartDoc macros (Android Studio)

@guidezpl commented on Oct 1, 2020, 12:01 PM UTC:
Original issue is #2524
I haven't seen this feature work on Android Studio since it was closed.
This issue was moved by stevemessick from flutter/flutter-intellij#4930.

any update on this? how to turn on this functionality on packages like riverpod?

Android Studio Bumblebee | 2021.1.1 Patch 3
Build #AI-211.7628.21.2111.8309675, built on March 16, 2022
Runtime version: 11.0.11+0-b60-7590822 x86_64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 12.3.1
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 16
Registry: external.system.auto.import.disabled=true, ide.instant.shutdown=false
Non-Bundled Plugins: Dart (211.7817), org.jetbrains.kotlin (211-1.6.20-release-275-AS7442.40), io.flutter (66.0.1)
Flutter (Channel stable, 2.10.4, on macOS 12.3.1 21E258 darwin-x64, locale en-RU)

We're going to change the dartdoc macro support significantly; I'm closing this for now.


Fix rate limit burst refresh for graphsync

After dt/gs session hits the burst limit, it is necessary wait for the token bucket to refil before restarting the session. The wait was happening but was also emptying its bucket.  So when the session restarted there was no burst and rate limiting would happen immidiately after reading the next block or two.  This fixes this to wait without emptying the bucket.
Other changes:

Improved logging
AllowPeerFunc only retruns bool. It is up to the function to log any errors, not legs.  Also returning the error does not allow any decision beyond what the boolean return value already does.

Codecov Report

Merging #124 (b7455f3) into main (537fb80) will increase coverage by 0.24%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   65.08%   65.32%   +0.24%
==========================================
  Files          21       21
  Lines        2088     2091       +3
==========================================
+ Hits         1359     1366       +7
+ Misses        563      561       -2
+ Partials      166      164       -2

Impacted Files
Coverage Δ

subscriber.go
79.55% <66.66%> (+0.44%)
:arrow_up:

dtsync/syncer.go
87.50% <80.00%> (+4.57%)
:arrow_up:


Update sa-secret-remote.yaml sample to include b64 encoding sample

@sseago agree, it is already in the README, but I was going back through filling these samples out and couldn't remember the command off the top of my head so decided it might be helpful to others as well.


Epic 1: Display Dog Breed

As a user, I would like to be able to see a box that can show a dog breed so that I can know where the output will be.

[ ] issue #51
[ ] issue #52
[ ] issue #57

Please add a short description for each task.


Duplicate macro completions

Given
#[macro_export]
macro_rules! foo {}
$0

We get two foo completions instead of one. The problem seems to be that foo appears twice in the scope even though it should only be there once.

The macro is available both from the legacy macro_rules! scope, as well as in the non-legacy macro scope in the crate root due to the #[macro_export]. Seems like we need to make sure to only add it once when looking for completion items.

I think IntelliJ has some general infrastructure for deduping completion items relatively late in the process. For us, I think it's better to sick with not producing duplicates in the first place, which indeed might need some special code for macros

IMO it's legitimate for names to be returned multiple times from a scope, so we should be deduping all names we get from process_all_names.

We would have to do this for every single name, since even non-macros can be in scope multiple times. This snippet shows S twice in the completion list:
mod m {
    pub struct S;
}

use m::S;

fn main() {
    use m::S;

    S$0
}

The same thing happens for shadowed local variables.

The shadowed local appearing twice has a FIXME somewhere as well iirc.

Naively, I'd expect it to be a contract of process_all_names that it doesn't yield shadowed names.

Naively, I'd expect it to be a contract of process_all_names that it doesn't yield shadowed names.

Maybe :thinking: It'd have to keep track of all yielded names, which not every consumer might need.
Another interesting question: If we have the same name in different namespaces (module foo and local foo), do we yield two completions? If not, what do we show?

If we have the same name in different namespaces (module foo and local foo), do we yield two completions? If not, what do we show?

For the flyinport proposals, we render the completion label as name (fully qualified path) so should have no issues.
If the name is already in scope, it's rendered without the path (it's not a flyimport anymore, so a separate module is responsible for those)

To be clear, I'm not asking what we do right now, but what we should do 😄 flyimport is a separate thing of course, but if both are in scope, it's arguably the same completion -- it has the same effect when inserted.

Although, maybe the completions for type items in value context should always append :: -- it's the only token that can follow if a value is expected, I think? So then you'd have two completions, foo and foo:: :thinking:


2018_U3 retagged?

https://github.com/01org/tbb/archive/2018_U3.tar.gz
On the 31/03 the sha256 was a0be619c741ee399de740ee7192c41a92fbbc7a8f3bda3032d6d6167e13f9dac
Currently the sha256 is 23793c8645480148e9559df96b386b780f92194c80120acce79fcdaae0d81f45
We need to confirm that the checksum change is legitimate before we can update the Homebrew formula.

Yes, the release 2018 U3 has been retagged to include updates for conda-forge integration.


add the pod alias to istioctl x describe pod

Please provide a description of this PR:
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[x] User Experience
[ ] Developer Infrastructure

Please check any characteristics that apply to this pull request.

[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@monsteredc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

lint_istio
f9fb158a0c7a44cbf0d34d2fdd8b5933353ad5f6
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@monsteredc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

lint_istio
f9fb158a0c7a44cbf0d34d2fdd8b5933353ad5f6
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@monsteredc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

lint_istio
f9fb158a0c7a44cbf0d34d2fdd8b5933353ad5f6
link
/test lint_istio

release-notes_istio
f9fb158a0c7a44cbf0d34d2fdd8b5933353ad5f6
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@monsteredc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Rerun command

lint_istio
f9fb158a0c7a44cbf0d34d2fdd8b5933353ad5f6
link
/test lint_istio

release-notes_istio
f9fb158a0c7a44cbf0d34d2fdd8b5933353ad5f6
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


Don't analyze .SARIF files by default.

The reason is that SARIF files themselves are reporting data captured in other files. Currently, the background analyzer interferes with the SPAM development process because it analyzes log files as well as targets that contain, for example, insecure patterns.
We could add a deny list regex to the SARIF configuration settings file, when available, that has this default:
FileNameDenyRegex=^.*.\sarif$
And file name matching this regex would be excluded from analysis.

should this be part of the SPAM or should we add this logic in the sarifer?

should this be part of the SPAM or should we add this logic in the sarifer?

we add this in the sarifer option. So, all configurations will be there.

we add this in the sarifer option. So, all configurations will be there.


Rewrite predictor code to avoid writing into subarrays.

See #1162
(Close #1216)

@pdfjsbot test

TEST-UNEXPECTED-FAIL | eq tutorial | in chrome | rendering of page 7 != reference rendering

intermittent failure #1043


card component for maintenance staff created

maintenance card component that displays apporiate data regarding WOs, once clicked the card will open up a modal that is a form to edit the WO data

 As maintenance, I would like a card component that shows information regarding my work orders

 As maintenance, I would like a card component that shows information regarding my work orders

You seem to be very competent in implementing the form handling. Your code is easy to follow. However, I've never seen the way you the method you are using for managing uploads ? what does new fileReader() do exactly ? Also curious about the toISOString() method .

The fileReader method does exactly as the name implies. Once a file is selected from your computer, this method allows the browser to read what the file is from your computer.  In the file upload function, the function starts out by reading whatever file is selected. Then we are grabbing the data of the file, in this case, an image and finally turning it into base64 with the readAsDataURL method and setting it to the state. As of right now, this is only a temporary solution to implement our file uploads, we have talked about finding a third-party service in which we would upload the files to them and then in return just get back a URL. In regards to the toISOString method, this is just a method that formats dates to yyyy-mm-dd.

You seem to be very competent in implementing the form handling. Your code is easy to follow. However, I've never seen the way you the method you are using for managing uploads ? what does new fileReader() do exactly ? Also curious about the toISOString() method .

The fileReader method does exactly as the name implies. Once a file is selected from your computer, this method allows the browser to read what the file is from your computer.  In the file upload function, the function starts out by reading whatever file is selected. Then we are grabbing the data of the file, in this case, an image and finally turning it into base64 with the readAsDataURL method and setting it to the state. As of right now, this is only a temporary solution to implement our file uploads, we have talked about finding a third-party service in which we would upload the files to them and then in return just get back a URL. In regards to the toISOString method, this is just a method that formats dates to yyyy-mm-dd.


Define a PRD and get it approved by the cost management PM

A PRD should be written for the Operator Development with a features list in a Google Doc.
DoD:

Curator team needs to approve.
Sergio needs to approve.
Cost Management Engg team needs to approve.

Deadline: 02/09/2022

The draft is being prepared here : https://docs.google.com/document/d/1JdIM7jf8mMi5as8ZZX84Mjw5m5-U45WyhHWkeIoCuRQ/edit?usp=sharing

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
/lifecycle rotten

The draft is being prepared here : https://docs.google.com/document/d/1JdIM7jf8mMi5as8ZZX84Mjw5m5-U45WyhHWkeIoCuRQ/edit?usp=sharing

Hi I was trying to figure out what is going on in this issue, but the Google doc is locked from being able to read it. May I recommend project materials be at least read-only for the public view?

@quaid The document is available for Red Hatters. I got a request from<EMAIL_ADDRESS>We are working towards developing MVP and we will make an announcement by the second week of June 2022 to the Operate First community.

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close

@sesheta: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


pr_checker: consider LITE CI as a ci requirement

Fixes: https://github.com/nodejs/node-core-utils/issues/225

Can we make a release with this fix?

@vsemozhetbyt Done in https://github.com/nodejs/node-core-utils/releases/tag/v1.12.0


Add azurestackhci cli extension

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

azurestackhci

The change looks good from my perspective (azurestackhci feature team)

Please Fix CI issues. Thanks

/azp run

Please Fix CI issues. Thanks

All checks have passed. Can you take a look, please?

Thanks, @kairu-ms


Fix #808 - adjust text label calculations to be more accurate, flexible, and thus balance the vertical space

sweet! 👍


emit pv id even if there is not yet cost data

Regression testing shows no impact for the happy path (pv.Cost = pvWithCost.Cost).
Actual testing done on a user's cluster.

Looks good. What was the bug that necessitated this?

There are certain PV classes (CSI providers) for which we don't pull pricing data from AWS but instead rely on reconciliation to update pricing.


bridge for mailman 2.x

A couple projects already exist for this, just need to be integrated
https://github.com/pteichman/mailman-rss
https://pypi.org/project/mailman-rss/

See https://github.com/RSS-Bridge/rss-bridge/issues/1069


enhance fails when data is already enhanced

When an input file contains e.g. the columns max_llh and one wants to (re)compute the max_llh, it raises an exception when concatenating.

I think this is obsolete, as the enhancing is now done by the new lyDATA library.


Using Autofac with EntityFrameworkSagaRepository

Per the Stack Overflow question:
http://stackoverflow.com/questions/42028364/need-an-example-for-entity-framework-when-registering-saga-repositories-with-aut
Need the ability/example to configure Autofac to provide the saga repository via the container, including some way to register/connect the ClassMapping to the repository.

It seems that to support proper configuration with multiple mappings per context, the saga context factory needs to be changed. Currently, you can only have one saga instance and mapping per context. @maldworth am I right? I see that each registration of saga repository will require individual context but they are all just DbContext.
I think the context needs to allow multiple mappings. The TSaga type parameter is not use anywhere in the SagaDbContext, therefore having this limitation is artificial. One context can map as many instance types as we like. I have no working EF setup but I can fix this (I think). But @maldworth please let me know if I should of you take this one.

Hey @alexeyzimarev
I'm looking at the NHibernate code and trying to figure out what the ISessionFactory is doing. I'm not that familiar with NHibernate, but I think you are right, I might have to alter the SagaDbContextFactory to handle open generics (which is I think what ISessionFactory is doing).
What I'm not sure about is when would you use this feature? If you want to have One ReceiveEndpoint handle 2+ types of sagas?
I can take a look at this hopefully this weekend

I already submitted a PR
On Fri, 10 Feb 2017 at 02:07, maldworth<EMAIL_ADDRESS>wrote:

Hey @alexeyzimarev https://github.com/alexeyzimarev
I'm looking at the NHibernate code and trying to figure out what the
ISessionFactory is doing. I'm not that familiar with NHibernate, but I
think you are right, I might have to alter the SagaDbContextFactory to
handle open generics (which is I think what ISessionFactory is doing).
What I'm not sure about is when would you use this feature? If you want to
have One ReceiveEndpoint handle 2+ types of sagas?
I can take a look at this hopefully this weekend
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MassTransit/MassTransit/issues/790#issuecomment-278827803,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACsMVfOlkR2dgcOkGujDsDXKhOSbFtdUks5ra7hCgaJpZM4L2ooq
.

--
Med vennligst hilsen / Best regards,
Alexey V. Zimarev

Ok, here is the thing. ISessionFactory is used to produce the ISession instances. It holds the connection configuration and all the mappings. SessionFactory has some heavy lifting, related to the configuration so it is expensive to create. This is why it is a singleton. ISession is just a unit of work - easy and fast to create, short lifecycle. Unfortunately, EF have chosen some strange approach to combine these two in one class DbContext and hide the heavy lifting under the first constructor call, caching the configuration and reusing it when new instances are created. This leads to all these question on why the hell after I have added some new mappings on runtime and create new DbContext instance, it does not see them. Well, configuration is implicitly cached and you need to explicitly reload it.
The NH saga session factory is just setting some useful defaults and loads the mappings.
SagaDbContextFactory at the other hand can load only one mapping. It has two type parameters, one of those is not used but I assume you have added it to be more explicit in what is being configured. However, people not only use DbContext to work with sagas. This service can use EF for other things too. So if DbContext is registered in the container as IDbContext, the question for the container would be - how to understand, which one to use? DbContext is a unit of work, usually people prefer to have one context for one database connection. Assuming, one database is used for the whole service, it would be preferred to have one registration of DbContext for the whole service, which has mappings both for some service persistence, plus for all saga mappings.
DbContext has an overload that you use to add one specific saga mapping when the context is being configured for the first time. That overload can also add all mappings from a specified assembly. I added such a context factory so people can register that factory and use it to register the context like this:
builder.Register(c => new AssemblyScanningSagaDbContext(typeof(MySagaMapping).Assembly,
    connectionString).As<DbContext>();
builder.Register(c => new EntityFrameworkSagaRepository<MySaga>(
    () => c.Resolve<DbContext>()).As<ISagaRepository<MySaga>>().SingleInstance();

I hope it makes sense.

Ok that helps me understand a bit more what NHibernate is doing. Yes DBContext is indeed itself a unit of work.
In a DBContext if you wanted it to access other tables with the one registration, You'd have something like this.
public class MyLibraryDbContext : SagaDbContext<BorrowState, BorrowStateMap>
{
	public MyDbContext()
		: base("myConnectionString")
	{
#if DEBUG
		Database.Log = (o) => System.Diagnostics.Debug.WriteLine(o);
#endif
	}

	public virtual IDbSet<Book> Books { get; set; }
	public virtual IDbSet<Author> Authors { get; set; }

	// You could add this, but you can always get it from the context with this.Set<TSaga>() which is what MassTransit does
	public virtual IDbSet<BorrowState> BorrowState { get; set; }

	protected override void OnModelCreating(DbModelBuilder modelBuilder)
	{
		modelBuilder.Configurations.Add(new BookConfiguration());
		modelBuilder.Configurations.Add(new AuthorConfiguration());

		// Must call this, so it will map the SagaDbContext BorrowState
		base.OnModelCreating(modelBuilder);
	}
}

Where the limitation lies is what if I had another state machine for my library? Maybe for new library users SagaDbContext<RegisterNewUserState, RegisterNewUserStateMap>.
Well, now I can't have those two state machines in my library DB Context (only inherit one class)
Do I do this?
public class MyLibraryDbContext : SagaDbContext<BorrowState, BorrowStateMap> {}

or this
public class MyLibraryDbContext : SagaDbContext<RegisterNewUserState, RegisterNewUserStateMap> {}

??
Is that what we'd like to add? The ability to have multiple Saga's with just one DBContext? If so, I can look into adding this feature.

Well, you can just use one context. The code that I provided above solves this issue. The scanning context uses native EF feature to scan the assembly for mappings and do all configuration automatically. Isn't this a solution?

Peeked at your PR. Yes this works, but I probably didn't interpret the StackOverflow question correctly. I would have thought the ownness of that would be the developer using EF.
i.e., using the example above
public class MyLibraryDbContext
{
        ...
	public virtual IDbSet<Book> Books { get; set; }
	public virtual IDbSet<Author> Authors { get; set; }
	public virtual IDbSet<BorrowState> BorrowStates { get; set; }
        public virtual IDbSet<RegisterNewUserState> RegisterNewUserStates { get; set; }
        ...

	protected override void OnModelCreating(DbModelBuilder modelBuilder)
	{
		modelBuilder.Configurations.AddFromAssembly(typeof(GetYourAssembly).Assembly);
	}
}

But I guess there's no harm to provide that class as a convenience AssemblyScanningSagaDbContext in MassTransit for developers who want to use it.

I agree there is a way to do it by creating your own DbContect child but as you said if we have it out of the box it might save someone a bit of time.

@phatboyg can you close this one?


Symfony 3 compatibility

Symfony 3.0 uses getBlockPrefix instead of getName, and fully-qualified
class names instead of string names for form types. Maintained
getName() method for backwards compatibility.

Fixed in a BC way in 9e4ae7e675ac0fff9a829e5fe400b4a8c2e2802c

Thanks! Sorry I missed that one.


After importing a resource, a diff is created on __defaults property on next preview

After importing a resource (e.g. ResourceGroup) utilizing the pulumi.ResourceOptions.import_ and pulumi.ResourceOptions.id properties, the next preview command detects a diff on the (internal??) property __defaults and Pulumi wants to replace the existing (imported) resource.
Expected behavior

After successfully imported a resource, the next preview command shall display no differences.
Current behavior

A diff is detected  on the __defaults property:

Steps to reproduce

Create a resource group in Azure e.g. with az group create -l westus -n MyResourceGroup
Import the resource group using the following code and pulumi up.

Data of the existing resource group is retrieved by the following endpoint 'https://management.azure.com/subscriptions/{wl_subscription}/resourcegroups/{rg_managed_resources}?api-version=2020-10-01

Perform a pulumi preview
Difference is reported and Pulumi wants to recreate the imported (existing) Resource Group

Context (Environment)

Using the Automation API to automatically import existing cloud resources.
The complete source code, that has been created to verify this issue, can be provided on request.
Affected feature

@lblackstone did anyone at Pulumi looked at this issue already?

Seems to be a pretty old issue which still lingers around.
https://github.com/pulumi/pulumi/issues/2579

As proposed by @stack72 I setup a small Pulumi program to test the import of a Azure Resource Group:

Performing the import:

Status: successful

After a refresh, Pulumi still shows a diff on the __defaults attribute:

For reference puposes I attached my two test programs here:

pulumi-import-test-classic: A "classic" Pulumi program
pulumi-import-test: A Python program which utilizes the Automation API and performs "automatic" import of Azure resources by getting the required information (property data) via the ARM API (HTTP REST calls)

pulumi-import-test.tar.gz
pulumi-import-test-classic.tar.gz

Sorry for the trouble here @tmeckel. I actually thought this had been fixed recently - so am surprised it is still surfacing in the repo. We'll need to look back into this.
FWIW - I believe this is different than the issue in #2579, which is about the non-interactive display mode. Though it's possible something has changed since that issue was filed.

@lukehoban @stack72 The issue with __defaults shows up as well with "normal" Azure resource deployment using TypeScript/Javascript. Luckily the diff on __defaults  does not lead to a resource replacement in this case.

@lukehoban @stack72 is there any update on this issue here?

@tmeckel was this resolved? Im encountering something similar (with the aws provider).

@peterhriser You didn't share any code but I suspect you might have fallen into the same trap as I did when I used the import functionality of Pulumi the first time. Rule: Never ever assign the  id property of  the ResourceOptions class. Only assign the id of the resource you wanna import to the import_ property. When I changed my code that way, the above issue vanished. Pulumi still prints differences on __defaults but there will be no changes.

Pulumi still prints differences on __defaults but there will be no changes.

This can't be the desired behavior of the tooling. When importing and running up or preview on freshly imported resources, I do not want to wade through all of the attached __defaults that it says are changing, when nothing has changed and I am about to apply it across my entire infrastructure. What's the deal?
I am using the pulumi import command as described, and copying the outputted code directly to my stack.


nginx enable module http_realip_module

Is your feature request related to a problem? Please describe.
can not recognize real IP if requests going via Cloudflare to firezone nginx
Describe the solution you'd like
during build platform please add for compile nginx "--with-http_realip_module"
Additional context
for external reverse proxy compatible or for possibility work with CDN's like Cloudflare

Hey @lixtechdev, we are dropping support of Omnibus-based deployments (see #1304) so there will be no nginx shipped with Firezone. Right now you can upgrade to using Docker-based deployment which is using Caddy and it should already support getting real IP from the headers.


Clarify that services don't need to be attached to special networks

File: ee/ucp/interlock/deploy/configure.md
HRM users expect to have to attach services to networks that have the com.docker.ucp.mesh.http: true label. Interlock does not require this. Add a clarifying note that makes this clear.

Closing this ticket due to its age, and the impending refactor. If you think this is in error, feel free to reopen. Thanks!

This is still relevant, and could be reopened (I don't seem to have permission to reopen it)


[docs] Add README.md for ERNIE Bot Agent

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (24e2f29) 66.21% compared to head (5574b74) 66.21%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #222   +/-   ##
========================================
  Coverage    66.21%   66.21%
========================================
  Files           60       60
  Lines         3019     3019
========================================
  Hits          1999     1999
  Misses        1020     1020

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Enable TLS-e by default

As there is no longer an external dependency, TLS-e can now be enabled by default (with explicit opt-out e.g for adoption).
Depends-On: https://github.com/openstack-k8s-operators/dataplane-operator/pull/754
Depends-On: https://github.com/openstack-k8s-operators/edpm-ansible/pull/612
Related: OSPRH-2038

/hold

/retest crc_storage error

/retest

/retest

recheck

/retest

/test openstack-operator-build-deploy-kuttl

/test openstack-operator-build-deploy-kuttl

/test openstack-operator-build-deploy-kuttl

recheck

/test openstack-operator-build-deploy-kuttl

/recheck

/remove-hold

https://github.com/openstack-k8s-operators/dataplane-operator/pull/754 merged and
https://github.com/openstack-k8s-operators/data-plane-adoption/pull/393 to explicitly disable TLSe for adoption so should be good to merge now

recheck

maybe you need to update the go.mod with the latest dataplane

maybe you need to update the go.mod with the latest dataplane

yes, thought I would get CI with it from depends-on but seems not

recheck

recheck

recheck

recheck

recheck

recheck

recheck

recheck

recheck

recheck

/hold RDO ci down

/remove-hold

recheck

recheck

recheck

recheck

recheck

recheck

recheck

recheck

recheck

recheck

/hold tempest failing, metadata api unreachable from VM

recheck

/remove-hold


Deploy to Cloudflare Pages - fetch issue

Hello!

I'm trying to deploy a storefront for MedusaJS v2 on Cloudflare Pages using next-on-pages, however for some reason fetch is not fetching products from an endpoint.

I have checked Cloudflare pages documentation and change the runtime to edge and set auth.type to jwt from config to disable fetch credentials but still have the same issue.

Hey @olivermrbl , here is the cloudflare pages URL: https://cart-staging.pilotinstitute.com/dk/store

Do you have any server logs displaying an error? I can't seem to find anything about this other than a bunch of old issues describing problems with SSR on Cloudflare Pages due to missing fetch compatibility.

@olivermrbl , in the server logs, I see only the request made from middleware to get regions but I don't see the request to fetch products. Storefront is not calling products endpoint.

This is what I have catched here https://github.com/medusajs/nextjs-starter-medusa/blob/main/src/lib/data/regions.ts#L62

Thanks @sgirones . Exists any quick workaround for that issue, please? Maybe, I can create a custom sdk client?

can you try his snapshot? https://github.com/medusajs/medusa/pull/10446#issuecomment-2519786252
The PR checks if the credentials field is supported before adding it

Thanks @sgirones , works with this snapshot!


coo.io v1.7.1 fat gem doesn't include Ruby 3.0 binaries

On Windows, users still couldn't use cool.io v1.7.1 fat gem.
rubygems complains as follows:
cool.io-1.7.1-x64-mingw32 requires ruby version < 2.8.dev, >= 2.4, which is
incompatible with the current version, ruby 3.0.0p0
rake aborted!

@ashie, @repeatedly Anyone have a chance to take a look this issue...?


Netezza migration to Azure SQL DB missing

there is no description about Migration to Azure SQL DB (single instances / pool). In some documentation you recommend to consider SQL DB for operational workloads, but there is not even a single page with recommendation about Netezza migration to Azure SQL DB.

Thanks for reporting - this issue is under review. This is a Microsoft Internal DevOps Bug ID # 419405

We have this article about Netezza migration.
https://docs.microsoft.com/en-us/azure/cloud-adoption-framework/migrate/azure-best-practices/analytics/analytics-solutions-netezza
Hopefully this helps.
Thanks!


[Bug Report] AntMaze envs ignore seed parameters

Hello! Seems like there are some problems with AntMaze tasks in terms of setting seeds. The following code:
import numpy as np
import random
import gym
import d4rl

np.random.seed(0); random.seed(0)
env = gym.make("antmaze-umaze-v1", seed=0)
env.seed(0); env.action_space.seed(0); env.observation_space.seed(0)
env.reset()

np.random.seed(0); random.seed(0)
env = gym.make("antmaze-umaze-v1", seed=0)
env.seed(0); env.action_space.seed(0); env.observation_space.seed(0)
env.reset()

outputs different initial states which is not good.
There was an issue https://github.com/Farama-Foundation/D4RL/issues/23 about the same problem for HalfCheetah tasks. Did the fix influenced AntMaze?

Same here.


Fix url images

URL of the images and links pointed to the site in production.
Description
I implemented the methods where we can pass the search parameters to make it more dynamic.
I have implemented the methods to convert the absolute paths of the images into relative paths.
Additionally, I have developed a method to eliminate duplicate images that are found both in the 'ArticleImage' column (main image) and in the summary and content of the post. This has been done to avoid redundancy of images on the same blog.
I implemented the methods to fix the img and href tag links still pointing to production.
How Has This Been Tested?
I tested the methods locally by passing several example parameters:
"DomainToReplace": "http://www.example.ca"
"DomainToReplace": "//www.example2.ca"
"DomainToReplace": "http://www.example.com"
Also replace, for example, http://location-name.example.com with "/locations/location-name/" which is how it works on the production site but with a redirect. With this method we do not need the redirect
Massachusetts, Mesa, Phoenix and Colorado Springs
Change them to locations/name
Massachusetts, Mesa, Phoenix and Colorado Springs
Screenshots (if appropriate):
(image intentionally removed during triage)
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

@alejoroman0605  FYI, I edited the PR description.


Cannot use double precision with wiener filtering

🐛 Bug
It seems because of this line: https://github.com/sigsep/open-unmix-pytorch/blob/master/openunmix/filtering.py#L301, where dtype is not provided and fixed, trying to use wiener filtering with double precision will fail.
  File "/Users/defossez/projs/demucs/env/lib/python3.8/site-packages/openunmix/filtering.py", line 472, in wiener
    y = expectation_maximization(y, mix_stft, iterations, eps=eps)[0]
  File "/Users/defossez/projs/demucs/env/lib/python3.8/site-packages/openunmix/filtering.py", line 301, in expectation_maximization
    y[t, ...] = torch.tensor(0.0, device=x.device)
RuntimeError: Index put requires the source and destination dtypes match, got Double for the destination and Float for the source.

To Reproduce
Call wiener filtering function with a magnitude that is float64, and complex spectrogram of the mixture that is complex128.
Expected behavior
Expected call to succeed with high precision inputs.
Environment
PyTorch version: 1.9.0
Is debug build: False
CUDA used to build PyTorch: None
ROCM used to build PyTorch: N/A

OS: macOS 11.4 (x86_64)
GCC version: Could not collect
Clang version: 11.0.0
CMake version: version 3.19.1
Libc version: N/A

Python version: 3.8.8 (default, Feb 24 2021, 13:46:16)  [Clang 10.0.0 ] (64-bit runtime)
Python platform: macOS-10.16-x86_64-i386-64bit
Is CUDA available: False
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A

Versions of relevant libraries:
[pip3] numpy==1.20.2
[pip3] torch==1.9.0
[pip3] torchaudio==0.9.0
[pip3] torchvision==0.9.1
[conda] blas                      1.0                         mkl
[conda] mkl                       2019.4                      233
[conda] mkl-service               2.3.0            py38h9ed2024_0
[conda] mkl_fft                   1.2.0            py38hc64f4ea_0
[conda] mkl_random                1.1.1            py38h959d312_0
[conda] numpy                     1.20.2                   pypi_0    pypi
[conda] torch                     1.8.1                    pypi_0    pypi
[conda] torchaudio                0.8.1                    pypi_0    pypi
[conda] torchvision               0.9.1                    pypi_0    pypi

@adefossez good catch... will add this soon.

Sounds good! I assume then you actually don't use double precision for Open Unmix despite the note in the comments?

I remember when we ported this @aliutkus had problems getting stable results with float32, thus requiring doubles. Then we were able to fix this at some point (either this or the torch implementations improved over time)....


Renaming Token loses connection to objects

Describe the bug
If a token like border radius is applied to an object, and the specific token name is changed, the object loses the connection to that token
To Reproduce
Steps to reproduce the behavior:

apply border radius to a rectangle
Change name of token within Figma Tokens
rectangle lost it's connection to that token

Expected behavior
I would imagine I could just change the name
Screenshots or Screencasts
If applicable, add screenshots to help explain your problem.
Figma file (optional)
Send us the link to a Figma file containing a reproducible example
JSON (optional)
If possible, attach the JSON that leads to this bug.

Also came here to point this out. Would be very nice to be able to freely re-name tokens and maintain the connection.

Closing this in favor of https://github.com/six7/figma-tokens/issues/211


Make sure we have database integrity checks

Need to include tests which explicitly include multiple data types and test the integrity of the object store

[x] Test adding same inputs but small change to header (different hash but data will be the same)
[x] Test adding same inputs but small change to data values (data itself should be updated)
[x] Test same inputs but hourly and minutely data added (should be able to access both)

See branch test_db_integrity and PR #406

There was an incident at the code retreat where data in the object store disappeared (or access to this disappeared when) which I have tried to reproduce but have not been able to so far. May need to keep adding tests around this to make sure this can't occur again.


Add Balsa, GParted, Boxes, Fuse & Virt-manager

Add Balsa, GParted, Boxes, Fuse, Virt-manager, changed description of bottles, and added category Emulators and compatibility layers

Thanks!


Can you please explain more thoroughly how to use?

I'm trying the ConsoleApp project and args -train questions-words.txt -output output.txt
I get a FileNotFoundException filename "output"
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)
at System.IO.File.Open(String path, FileMode mode, FileAccess access)
at Word2Vec.Net.Distance.InitVocub() in Word2Vec.Net-master\Word2Vec.Net\Distance.cs:line 115
I remove the .txt from output and re-run and get an OverflowException
Arithmetic operation resulted in an overflow.
at Word2Vec.Net.Distance.InitVocub() in Word2Vec.Net-master\Word2Vec.Net\Distance.cs:line 124

Hi john! There is old version of Word2Vec implementation. I'll push the update very soon. i think, in a few days. Generally you must set input and output filenames.
Word2VecBuilder.Create()
.WithTrainFile("trainingFile.txt")
.WithOutputFile("outputFile.txt")
.Build();

awesome :) Is the project still pure C#? I noticed some c and compiled libraries in the dev branch

Johnearnshaw,
The exception with following code:
var distance = new Distance("output");
You must specify a path to the output file instead of "output" arg.

Hi, this is an awesome project. Can you please add function that helps us extract the vector of a word directly? or is there already a function in there that I am missing?
Thanks for this Word2Vec implementation in C#

@syedmohsinbukhari, to be honest i don't understand. Can you explain what do you mean?


Complex inputs?

starting to work on this in https://github.com/kylemath/DeepEEG/pull/17,
as a first try, just concatenate the values

https://arxiv.org/pdf/1705.09792.pdf

https://github.com/ChihebTrabelsi/deep_complex_networks

Closed with:
https://github.com/kylemath/DeepEEG/commit/498148f206bc96476d57f77da777b2f91ab8b080


Update to new dotnet domain

Related: https://github.com/dotnet/core/issues/9671

@SteveL-MSFT FYI, small but somewhat urgent

sorry can't help but I would merged this if I had the access to do so


Make Flutter repos sound null safe

This is a companion issue to https://github.com/dart-lang/sdk/issues/49169; this tracks making the various flutter/ github repos sound null safe. This means the code both needs to be converted to a min. SDK dep of Dart 2.12, and, not exclude any files from null safety (i.e., via a language tag in the file).
This issue is meant to track the remaining tech debt towards getting the repos sound null safe (i.e., tests which were excluded from null safety during an initial conversion, ...). Exclusions which are intentional - for example, exclusions to specifically test the behavior of pre-null-safe code - aren't meant to be tracked as part of this issue.
Repos

[x] flutter/packages - no exclusions
[x] flutter/samples - no exclusions
[x] flutter/website - no exclusions
[x] flutter/codelabs - no exclusions
[ ] flutter/flutter#110017
[ ] #110021
[ ] #110020
[ ] flutter/gallery#752
[ ] flutter/devtools#4399

cc @mit-mit for fyi

flutter/packages - no exclusions

fuchsia_ctl has a bunch of tests with Dart 2.4 tags, and neither imitation_game or web_benchmarks has ever been converted (they use pre-2.12 constraints).

Ah, thanks. This search just looked for // @dart =  2.8, 2.9, 2.10, and 2.11.

Exclusions which are intentional - for example, exclusions to specifically test the behavior of pre-null-safe code - aren't meant to be tracked as part of this issue.

@devoncarew where are we tracking those then? For example https://github.com/flutter/flutter/issues/110021 has only that category left.

where are we tracking those then?

We aren't explicitly, but if you see the very end of the first comment here: https://github.com/dart-lang/sdk/issues/49169
We are asking people to annotate those types of exclusions with a special comment that we can grep for ('// null_safety_optout_testing'). That'll make identifying and removing all those locations a fairly time-boxed exercise.

From looking around, it doesn't look like we've used null_safety_optout_testing in any other repos. I suspect when we're ready to remove the intentional exclusions, we'll need to perform another git grep of the various repos.

OK, that makes sense: let's remove all known uses, and then see what's left.

All done 🥳

Reopening as https://github.com/flutter/flutter/issues/110020 was reopened


Expose geospatial data about other bees in your swarm.

Summary
Expose information about the geographical location of other bees in the swarm.
This would enable bee-desktop to provide users with views such as this:

Motivation
Users of IPFS and IPFS-Desktop (like me), are regularly delighted with the cartographical representation of peers in the user's network.
As a user of bee-desktop, I would also like to feel this delight.
Implementation
I am not personally willing to implement this feature, as I simply don't have the capability right now.
But if it ended up being something simple enough to expose on an interface, for bee-desktop to retrieve data from, then it ought to be relatively trivial to then e.g. plot those on an OpenStreetMap, to see where all the other bees are, and show their ENS names etc.
Drawbacks
I guess there is always the security risk of showing people's precise locations.

The good news is that there is a map in the current design. That is not yet implemented in the current version. The idea is to use the IP addresses of the peers and use a Geo IP database to map them to city level, therefore providing reasonable privacy.
Also check out https://swarmscan.resenje.org in the meanwhile.

Why not use little bee icons to represent peers.
It would be cute.

see https://swarmscan.io/


Add ch upgrade command or include message on how to upgrade

Is your feature request related to a problem? Please describe.
When a new version is released, user has to find this repo and follow instructions in the README. Instructions to upgrade should be clear from the CLI when it says a new version is released.
Describe the solution you'd like
Add a command (i.e. ch upgrade) that automatically upgrades the CLI by downloading the latest binary and replacing the existing file. This should be safe on all OS's since the OS should manually load the binary into memory and it wouldn't matter if process binary is replaced.
Describe alternatives you've considered
Print out the link to the repository instructions on how to upgrade, or print specific terminal commands to run to upgrade depending on if it's running in Windows or Unix (WSL2, macOS, normal Linux).
Additional context
n/a?

Resolving for now. Additional implementation to do self-download is not something I have time to safely implement and providing upgrade command is convenient enough for users. If someone disagrees, please comment, re-open, or create new issue.


Throws DB Access denied in prod env

Worked nicely in staging, but throws Access denied in production:

(17:51:29) [current] rake db:seed_fu filter=02_stores
== Seed from /[...]/releases/20111107164213/db/fixtures/02_stores.rb
rake aborted!
Access denied for user 'root'@'localhost' (using password: NO)
Tasks: TOP => db:seed_fu

Looks like it doesn't respect the conf in database.yml
Full log:

(17:55:12) [current] rake db:seed_fu filter=02_stores --trace
** Invoke db:seed_fu (first_time)
** Invoke environment (first_time)
** Execute environment
** Execute db:seed_fu
== Seed from /.../releases/20111107164213/db/fixtures/02_stores.rb
rake aborted!
Access denied for user 'root'@'localhost' (using password: NO)
/kunden/339168_20354/.gem/ruby/1.8/gems/mysql2-0.2.7/lib/mysql2/client.rb:42:in connect' /kunden/339168_20354/.gem/ruby/1.8/gems/mysql2-0.2.7/lib/mysql2/client.rb:42:in initialize'
/kunden/339168_20354/.gem/ruby/1.8/gems/mysql2-0.2.7/lib/active_record/connection_adapters/mysql2_adapter.rb:14:in new' /kunden/339168_20354/.gem/ruby/1.8/gems/mysql2-0.2.7/lib/active_record/connection_adapters/mysql2_adapter.rb:14:in mysql2_connection'
/kunden/339168_20354/.gem/ruby/1.8/gems/activerecord-3.0.9/lib/active_record/connection_adapters/abstract/connection_pool.rb:229:in send' /kunden/339168_20354/.gem/ruby/1.8/gems/activerecord-3.0.9/lib/active_record/connection_adapters/abstract/connection_pool.rb:229:in new_connection'
/kunden/339168_20354/.gem/ruby/1.8/gems/activerecord-3.0.9/lib/active_record/connection_adapters/abstract/connection_pool.rb:237:in checkout_new_connection' /kunden/339168_20354/.gem/ruby/1.8/gems/activerecord-3.0.9/lib/active_record/connection_adapters/abstract/connection_pool.rb:191:in checkout'
/kunden/339168_20354/.gem/ruby/1.8/gems/activerecord-3.0.9/lib/active_record/connection_adapters/abstract/connection_pool.rb:187:in loop' /kunden/339168_20354/.gem/ruby/1.8/gems/activerecord-3.0.9/lib/active_record/connection_adapters/abstract/connection_pool.rb:187:in checkout'
/usr/lib/ruby/1.8/monitor.rb:242:in synchronize' /kunden/339168_20354/.gem/ruby/1.8/gems/activerecord-3.0.9/lib/active_record/connection_adapters/abstract/connection_pool.rb:186:in checkout'
/kunden/339168_20354/.gem/ruby/1.8/gems/activerecord-3.0.9/lib/active_record/connection_adapters/abstract/connection_pool.rb:94:in connection' /kunden/339168_20354/.gem/ruby/1.8/gems/activerecord-3.0.9/lib/active_record/connection_adapters/abstract/connection_pool.rb:317:in retrieve_connection'
/kunden/339168_20354/.gem/ruby/1.8/gems/activerecord-3.0.9/lib/active_record/connection_adapters/abstract/connection_specification.rb:97:in retrieve_connection' /kunden/339168_20354/.gem/ruby/1.8/gems/activerecord-3.0.9/lib/active_record/connection_adapters/abstract/connection_specification.rb:89:in connection'
/kunden/339168_20354/.gem/ruby/1.8/gems/activerecord-3.0.9/lib/active_record/transactions.rb:207:in transaction' /kunden/339168_20354/.gem/ruby/1.8/gems/seed-fu-2.0.1/lib/seed-fu/runner.rb:35:in run_file'
/kunden/339168_20354/.gem/ruby/1.8/gems/seed-fu-2.0.1/lib/seed-fu/runner.rb:26:in run' /kunden/339168_20354/.gem/ruby/1.8/gems/seed-fu-2.0.1/lib/seed-fu/runner.rb:25:in each'
/kunden/339168_20354/.gem/ruby/1.8/gems/seed-fu-2.0.1/lib/seed-fu/runner.rb:25:in run' /kunden/339168_20354/.gem/ruby/1.8/gems/seed-fu-2.0.1/lib/seed-fu.rb:28:in seed'
/kunden/339168_20354/.gem/ruby/1.8/gems/seed-fu-2.0.1/lib/tasks/seed_fu.rake:41
/kunden/339168_20354/.gem/ruby/1.8/gems/rake-0.9.2/lib/rake/task.rb:205:in call' /kunden/339168_20354/.gem/ruby/1.8/gems/rake-0.9.2/lib/rake/task.rb:205:in execute'
/kunden/339168_20354/.gem/ruby/1.8/gems/rake-0.9.2/lib/rake/task.rb:200:in each' /kunden/339168_20354/.gem/ruby/1.8/gems/rake-0.9.2/lib/rake/task.rb:200:in execute'
/kunden/339168_20354/.gem/ruby/1.8/gems/rake-0.9.2/lib/rake/task.rb:158:in invoke_with_call_chain' /usr/lib/ruby/1.8/monitor.rb:242:in synchronize'
/kunden/339168_20354/.gem/ruby/1.8/gems/rake-0.9.2/lib/rake/task.rb:151:in invoke_with_call_chain' /kunden/339168_20354/.gem/ruby/1.8/gems/rake-0.9.2/lib/rake/task.rb:144:in invoke'
/kunden/339168_20354/.gem/ruby/1.8/gems/rake-0.9.2/lib/rake/application.rb:112:in invoke_task' /kunden/339168_20354/.gem/ruby/1.8/gems/rake-0.9.2/lib/rake/application.rb:90:in top_level'
/kunden/339168_20354/.gem/ruby/1.8/gems/rake-0.9.2/lib/rake/application.rb:90:in each' /kunden/339168_20354/.gem/ruby/1.8/gems/rake-0.9.2/lib/rake/application.rb:90:in top_level'
/kunden/339168_20354/.gem/ruby/1.8/gems/rake-0.9.2/lib/rake/application.rb:129:in standard_exception_handling' /kunden/339168_20354/.gem/ruby/1.8/gems/rake-0.9.2/lib/rake/application.rb:84:in top_level'
/kunden/339168_20354/.gem/ruby/1.8/gems/rake-0.9.2/lib/rake/application.rb:62:in run' /kunden/339168_20354/.gem/ruby/1.8/gems/rake-0.9.2/lib/rake/application.rb:129:in standard_exception_handling'
/kunden/339168_20354/.gem/ruby/1.8/gems/rake-0.9.2/lib/rake/application.rb:59:in run' /kunden/339168_20354/.gem/ruby/1.8/gems/rake-0.9.2/bin/rake:32 /usr/bin/rake:19:in load'
/usr/bin/rake:19
Tasks: TOP => db:seed_fu

Seed fu doesn't doesn't handle connecting to the database - Rails does that. Are you sure you have your RAILS_ENV and database.yml set correctly?

If it needs RAILS_ENV=production appended to the command (which I think it does), then I guess it'd be a good idea to document it, maybe make an addition to the examples.

RAILS_ENV needs to be set to whatever environment you are trying to seed.


When creating a new repository which already exists local you should not be required to input a remote URL

I'm guessing the current code gets the remote URL by looking for the origin remote.
However, that assumes there is such a remote. For repos that are really local, instead of realizing there is no remote at all, it gets an empty URL and then fails later when trying to check the URL scheme.

this is already done :P


using OC to create prefix-list and gnoi to terminate Octa

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.5%

Totals

Change from base Build<PHONE_NUMBER>9:
0.0%

Covered Lines:
1983

Relevant Lines:
3573

💛  - Coveralls


Fixed First Column in Mat Table

Bug, feature request, or proposal:
Feature Request
What is the expected behavior?
In few cases where we have a horizontal scrolling, would require the first column to be fixed. Similar to the column lock/freeze that we do in excel
What is the current behavior?
Currently horizontal scrolling table scrolls the entire table
What are the steps to reproduce?
https://angular-material2-issue-wfbfte.stackblitz.io
The first 2 columns in the table should be a fixed one and others to scroll when scrolled horizontally.
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Is there anything else we should know?

@andrewseguin : Any updates on this ?

Dupe of https://github.com/angular/material2/issues/5890

@agokulravikumar Working on the feature now along with sticky header and footer, currently the highest priority upcoming feature


⚠ Fortnite has degraded performance

In 38b33e7, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1528 ms

Resolved: Fortnite performance has improved in 35785f0.


Convert from multirust to rustup

Rename the crates and remove the "multirust" bin. There's certainly more to do, but this is the big stuff.

Travis seems to have disappeared, but otherwise r=me when this is ready

@bors r=alexcrichton


Add catalog endpoint

[x]  GET /orgs/id/catalogs endpoint
[x]  GET /orgs/{id}/catalogs/{name} endpoint
[x] Initialise catalog repo on first query in organisation scope
[x] spotguide.yaml/spotguide.json available

Resources
Depends
Options

fixes #478

Please squash Make lint happy to the first commit


CAD-710 textual log output

adapt to upstream changes

Usually a bad idea to reference git commits that are not on master.
I think that is why that CI build failed.

obsolete


Relative PERSISTENCE_DATA_PATH does not appear to work

My docker file:
version: '3.4'
services:
  weaviate:
    image: weaviate-branch-master
    ports:
      - 8765:8080
    environment:

      PERSISTENCE_DATA_PATH: './data'

    CONTEXTIONARY_URL: contextionary:9999
      QUERY_DEFAULTS_LIMIT: 25
      AUTHENTICATION_ANONYMOUS_ACCESS_ENABLED: 'true'
      ENABLE_MODULES: 'text2vec-contextionary'
      DEFAULT_VECTORIZER_MODULE: 'text2vec-contextionary'
      AUTOSCHEMA_ENABLED: 'false' # Important to add custom WPSOLR data types
  contextionary:
    environment:
      OCCURRENCE_WEIGHT_LINEAR_FACTOR: 0.75
      EXTENSIONS_STORAGE_MODE: weaviate
      EXTENSIONS_STORAGE_ORIGIN: http://weaviate:8080
      NEIGHBOR_OCCURRENCE_IGNORE_PERCENTILE: 5
      ENABLE_COMPOUND_SPLITTING: 'false'
    image: semitechnologies/contextionary:en0.16.0-v1.0.2

After starting weaviate, there is no data created in the local docker file's folder.

The path ./data you created is relative to the containers file system which is not persistent by default. To map it to a local folder on your disk you need to mount a Docker Volume.
For example:
services:
  weaviate:
    image: weaviate-branch-master
    environment:
      PERSISTENCE_DATA_PATH: '/var/lib/weaviate'
    volumes:
     - '/path/on/your/machine:/var/lib/weaviate'

Perfect.


ContextCredentialsAutoConfiguration Issue

Environment

Java 10.0.1
Spring Boot 1.5.14.RELEASE
spring-cloud-aws-autoconfigure 1.2.2.RELEASE
spring cloud: Edgware.SR3

Issue
I am having some trouble with org.springframework.cloud.aws.autoconfigure.context.ContextCredentialsAutoConfiguration
When running my app locally inside Docker with the following environment variables set:
cloud.aws.credentials.accessKey=xxx
cloud.aws.credentials.secretKey=yyy

my app works as I expect. However, when I run it on docker on an EC2 instance with the same environment variables the app fails when calling SQS due to the not having permission.
I have set:
cloud.aws.stack.auto=false
cloud.aws.credentials.instance.profile=false

both locally and on EC2.
Should I define my own com.amazonaws.auth.AWSCredentialsProvider bean or should the default auto config behaviour be enough? I am confused about why the auto config seems to be favouring an instance profile or some other credentials over the ones provided via the environment.

I think you want cloud.aws.credentials.instanceProfile=false ?

Closing due to age of the question. If you would like us to look at this issue, please comment and we will look at re-opening the issue.


feat: Add chai cheatsheet

What does this PR do?

Add chai cheatsheet

For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

closes https://github.com/EbookFoundation/free-programming-books/issues/8157
cc: @LuigiImVector , @davorpa  & @eshellman


Custom Watch Options & Add an Install Method

Pool English... add a method to custom watch options and add a method to install fast in China.

Approve!


Link to oidcc_plug in README

coverage: 86.898%. remained the same when pulling dcf650e27d3838c1a272e9da9dc872a9ce195b8a on link_oidcc_plug into 254bb76660abb63ce9b9b9ec95e38a187ee5ffe2 on main.


youtube-music: fix trayicon and source provenance

Description of changes
The libappindicator was missing in the package so the tray icon wasn't appearing.
In addition I corrected the source provenance.

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[X] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/1495


allow to provide a separate key combo for documentation

it seems that for modifier+key combinations, the event triggers with the english key, even if the layout is in another language (at least for me, using english+hebrew layouts). this seems inherent in javascript. while the best solution is for the framework to map the non english characters to their english equivalent when handling key presses, it seems this is tricky (if possible). an alternative is to just allow to pass a key combination that will be used in the documentation. so while binding to alt+t, the documentation will show alt+א

I'm not in control of this, as all hotkey-specific binding is handled by mousetrap.  You may want to open a ticket there

I was suggesting that an optional parameter will be allowed and that will be used for documentation. So I call with both alt+t and alt+א, you pass alt+t to mousetrap and show alt+א in the documentation ('?')


Data Hosting Deployment

"Create provisioning resources and undertake deployment(s)."
Already being worked on as an aside of #5 and the developments by @jemrobinson under the IceNetETL repository

For data uploads we should try to use Azure Storage Explorer.

[ ] James R to provide SAS token
[ ] James B to test ASE usage from pipeline into Azure

Hosting is in place and the upload works. This is maintained/deployed using IceNetETL


A minor inconsistency with the split style theming

the clock module icons are not colored like the rest which doesnt fit style
i hope you implement it in such a way that we can remove the date and the clock icon will still display with the split style colouring

How did you enable this?

import any theme having "_split" with its name

oh and just realized this was fixed in the latest commit
thanks closing this issue now


PageSpeed InSlides Error

Hi,
I am facing with  API error when I try to analyze a URL. I am using only page speed insights API key.
The API works well with an another page speed insight project that I am working on.
Thanks for the help,

)

Changing the API variable in pagespeed.js solved my issue issue. const API_KEY = 'your key'.
Also I have the  pug compile issue after this.

You are supposed to change the file name of dot.env to .env, then the API key is found and you don’t have to edit the source code.

You are supposed to change the file name of dot.env to .env, then the API key is found and you don’t have to edit the source code.

Hi Thomas,
Thanks for the answer, yes it worked with Linux.


Create a deeper reference implementation for Tanzu Community Edition

Description
This would be a deeper guide than our getting started guide. It would talk about topics like getting traffic into the cluster, architecture diagrams, and other content to help folks start forming how to architect their cluster/platforms.
Location
TODO
Additional Context
Please feel free to add topics you feel should be in this deeper reference implementation for TCE.

These are important assets to have. Putting in the icebox for now until we analyze our next milestone. Realistically we don't have any prioritization around this.


Social media icons?

Love the theme, simple and easy to use.
I was wondering how to add social media icons to a contacts page? html or md?

a possible solution is to use fontawesome svg icons. But I am new to Hugo, under which directory is fontawesome placed under?

Hi there! I'm glad you like the theme!
Font Awesome has instructions for using their SCSS version with Sass. This theme's Sass files are here.
Alternatively, Feather offers some tidy open source icons in svg form that you can include as images, or using the svg code in your page.


[CNVS Upgrade] Fix up the nodes view

This PR fixes up the Nodes view:

I fixed the double padding between the panel header and the panel content in the ResourceBarChart
I fixed the dark graph colors in the nodes grid view
I moved the width and margin properties of the nodes grid sidebar to the sidebar itself rather than random children (it was confusing)
I fixed some erroneously defined transition properties, so toggling the task list will transition as intended
I replaced the old, yucky, native input checkbox with the new, yummy, fancy checkbox from reactjs-components.

The FilterHeadline margins seem a little tight, but that's everywhere in the app, so I'll address that in a future PR.

thank you for this tasty 🍰

Thanks for all the clean up @jfurrow!


$() should accept an existing element.

Imagine the following example:
You are using a third-party library, that returns a raw element object. Now you want to edit this using Cash - how?
var elem = document.createElement("div");
var $e = $(elem); // Error: Can't run querySelectAll on this object.

How could this be made working?

+1 This would be very useful.

this should absolutely work. this happens in chrome?

This actually works, my bad. This issue can be closed :)


Question on the Azure Search .Net SDK latency

Hi,
It is probably a stupid question but I wonder if using Azure Search with the .Net SDK is not going to create an extra latency as we channel requests from the client to the web app controller which in turn will call the azure search engine, whereas the most straightforward will be to call the azure search instance directly from Javascript. Is that a correct reasoning?
Thanks
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 62162979-3bcf-4557-a11a-b74d7b121581
Version Independent ID: d6560736-a54c-c3e2-9333-83936c066360
Content: How to use Azure Search from a .NET Application
Content Source: articles/search/search-howto-dotnet-sdk.md
Service: search
GitHub Login: @brjohnstmsft
Microsoft Alias: brjohnst

@Ponant Thanks for the feedback! We are currently investigating and will update you shortly.

@Ponant Yes, there will be more latency if you have a web app between your client and your search service. However, we still recommend this architecture in most cases because otherwise you could be putting api-keys at risk by exposing them to the client. What we recommend is that you call your search service directly from JavaScript running in the browser only if you're fine with your data being publicly disclosed and your browser-based client uses a query api-key (definitely not an admin api-key).

@brjohnstmsft Thank you for the reply.
@Ponant We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and tag me in your reply. We will gladly continue the discussion.


Improve e2e completion tests to have better mock responses

Previously the mock completion handler would just always serve up some results. This caused a lot of flakiness in tests because immediately after accepting a completion another completion might show up (resulting in intermittent extra "suggest" events logged and extra ghost text in the editor).
This change extracts the code being completed and only returns results where the typed prefix matches a defined mock response. This prevents tests getting any unwanted completions.
Mostly these flakes showed up on Windows GH bots (which I'm trying to enable), the other bots seemed pretty consistent.
Test plan
These are changes to the e2e tests that run on the bots with pnpm test:e2e.

@DanTup I just realised I've made a (possibly incorrect) change here which impacts this diff.
We have some racey conditions where telemetry logs can sometimes come in a different order. I uncovered this by removing an artificial delay from our commands in this PR: https://github.com/sourcegraph/cody/pull/1561
It feels like we shouldn't be relying on the order of telemetry logs to assert functionality, but it seems this is providing useful value here - and I'm worried not doing this will cause bugs.

I'll look into fixing this now, we can keep the current functionality for most tests and make an exception for the tests that are affected by the racey logs

@umpox do you mean you think these tests will be flaky now you've removed the sort? The bots are currently green (with your change merged in), but I don't know if they're consistent. With this PR there should be fewer events and they should be more consistent than before, although as-is (with your change and this), it does assume the completion events are suggested -> accepted -> suggested -> accepted.

@DanTup The fixup tests will be flaky, these tests should be OK. The race condition was only with commands so doesn't affect completions. Doesn't need to block this PR just wanted to raise that these tests don't technically check the order on latest main, PR to fix that: https://github.com/sourcegraph/cody/pull/1625/files?diff=split&w=1

Ah, I see. Before your change the completion test logs events were being sorted because they were also flaky, so I suspect your PR failure is because you're now asserting the order of them.
I think this PR landing will possibly fix that, so it may be better to wait to merge until after this, or restore the code that sorted the completion events before comparing and add a TODO to remove it after this PR lands (I'll wait for @dominiccooney to respond to comments above before merging).

@dominiccooney I responded to some comments above I'm interested in your thoughts on. Thanks!


[ISSUE #8584] fix missing brokerName in sendMessageBack request

Which Issue(s) This PR Fixes

Fixes #8584
Brief Description

How Did You Test This Change?

Codecov Report
Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.19%. Comparing base (a1ea1eb) to head (60d7fc3).

Files
Patch %
Lines

...ocketmq/client/consumer/DefaultMQPullConsumer.java
0.00%
1 Missing :warning:

...ocketmq/client/consumer/DefaultMQPushConsumer.java
0.00%
1 Missing :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8585      +/-   ##
=============================================
- Coverage      47.27%   47.19%   -0.08%
+ Complexity     11467    11450      -17
=============================================
  Files           1277     1277
  Lines          89342    89342
  Branches       11480    11480
=============================================
- Hits           42234    42168      -66
- Misses         41918    41970      +52
- Partials        5190     5204      +14

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Add svelte exports field to package json when running package command

Describe the problem
SvelteKit currently has a heuristic in place which tells Vite which packages are Svelte packages (for noExternal stuff) by looking up the package.json content and seeing if there's a svelte property.
The svelte-kit package command does not currently set this field.
Describe the proposed solution
Use the same logic that is used for the main entry to produce a svelte entry.
Alternatives considered
A workaround for now is for users to specify this field in their package.json themselves as it's copied over as of lately.
Importance
would make my life easier
Additional Information
The svelte key is likely more of a historical thing at this point, and deserves some more thought regarding the new developments, but for now the quick fix is to just add this field

From Rich:
originally the reason for pkg.svelte was, IIRC, so that a package could expose uncompiled files alongside a standalone dist file, but the latter use case is rare enough that i'm not sure it's worthwhile. and it's very blunt — it's package-level, whereas if we need it at all it should probably be a new key on pkg.exports alongside import and require
we are, however, using it inside Kit to automatically add Svelte component libraries to ssr.noExternal, so to answer @dummdidumm's question above, yes we probably should be adding it to those package.json files. but maybe it ought to be a boolean instead of an entry point? idk. it's all got a bit messy; we designed it in ~2017 without sufficient foresight
anyway i gtg but this probably warrants full discussion

I just tested this out and it seems Vite is able to deal with a Svelte package packaged through the package without the svelte field, maybe because of "type": "module" and the exports field.
So I'm not 100% sure at this point how to proceed here. Should we deprecate this convention now that it seems to work?
On an unrelated note: I noticed that Vite was not able to deal with exports besides the default export, so deep exports from exports like "./foo": "./Foo.svelte" did not work. I don't have time to look into this right now, just leaving this here for visibility.

Seems like there's a case where an error occurs: #1856 . So this thing should likely be added somehow.

Without pkg.svelte being defined, the library has to be added to SvelteKit projects as a regular dependency otherwise they will get the Must use import to load ES Module error. I assume, because find_svelte_packages fails to detect them https://github.com/sveltejs/kit/blob/69b92ec16ce92b86bc5a540daa8ddbd84ba400ef/packages/kit/src/core/utils.js#L85-L100
and I guess regular dependencies automatically get included under vite.ssr.noExternal?
Would it make sense to also check pkg.exports for any entrypoints with a .svelte extension?

That might get fixed by https://github.com/vitejs/vite/pull/4450


Implement a changelog

Detailed Description
Implement a changelog (CHANGELOG.md)
Context
It's good practice and will be useful in the future.
Possible Implementation
I will create the Changelog file and then update it with releases so far.
In the future, contributors should document there changes before merging their work.

https://keepachangelog.com/en/1.0.0/


Fix check in parse_charset

So, I'm not entirely sure if this is how it's supposed to be resolved. I was using ttf-parser as a fuzzer for my subsetter, and realized that parse_charset has this check to return None when there is only one glyph (i.e. the .notdef glyph) in the font. This means that it will fail to parse the cff table in that case. However, I would argue that a font with just the .notdef glyph should be perfectly fine in theory (even though in practice this obviously doesn't make a lot of sense), because the .notdef glyph can have outlines as well.

I'm not sure. If we have just one glyph in a font then charset will be empty. But I guess this way we would have an empty charset and not None. Very confusing.
Ok, I guess this change is correct.

Can you replace the check with number_of_glyphs == 0 for readability?

Then parse_charset should accept NonZeroU16 and not u16.


New package: SchneeHertz.ExHentaiMangaManager version 1.5.5

[X] Have you signed the Contributor License Agreement?
[X] Have you checked that there aren't other open pull requests for the same manifest update/change?

[X] Does your manifest conform to the 1.5 schema?

Microsoft Reviewers: Open in CodeFlow

Hi @SpecterShell,
Unfortunately, I'm not sure that this package will pass the Policy 2.7 check.


Issue-562 | Added code changes to update pod scheduling error message…

Details about code changes
https://github.com/bluek8s/kubedirector/issues/562
Testing
Created 5 member ubuntu cluster

Couple of pods scheduling failed because of less resource availability in the k8s cluster.

Then untainted the master node so that some of the pods can be scheduled on master.

Change in kd node id 5 status - Configured And No Scheduling Error Message

Plz add some details here about what you tested and an example of what the relevant status fields look like in one of the test cases.

Just a couple of minor fixes noted above, then this will be ready to merge.

Sorry I'm logged into my personal GitHub account rather than corporate. Lemme switch...

OK this should make it more official. :-) Just a couple of minor fixes noted above, then this will be ready to merge.


Update how-to-data-source-plugins-managed-identity.md

Update Grafana Enterprise data sources according to: https://learn.microsoft.com/en-us/azure/managed-grafana/how-to-grafana-enterprise

Hi @braieralves, thank you for your suggestion. Can you also add Sumo Logic? It's a new data source plugin for Grafana Enterprise customers.

Hello, @maud-lv .
Done :)