🔧 [2.2] fix: Fixed Issue #10308

Issue Reference
#10308

Checked and Found that the issue has been fixed and now working fine.
Screenshot -> https://prnt.sc/tx2_8KbixiEF


'from augment import Augmenter' Problem and GPU Restrictions

I have a compilation problem while trying to run your CampER code.

Although I installed the augment library (or augment tool) with 'pip install augment', I do take the following error:
"Traceback (most recent call last):
File "~/CAMPER/Code/CampER-main/main.py", line 9, in
from data import *
File "~/CAMPER/Code/CampER-main/data.py", line 8, in
from augment import Augmenter
ImportError: cannot import name 'Augmenter' from 'augment' (~/CAMPER/Code/CampER-main/.../lib/python3.9/site-packages/augment.py)"
Do I install, by any chance, a wrong library? Could you enlighten it?

I have a quick question on GPU memory capacity.

Now, I haven't been able to pass over the compilation process. But, in case that I passed it, I would need to have a simple answer to the following GPU capacity question:
'NVIDIA A100 40G GPU' is listed as a requirement. If I have 32 GB GPU working, then, with longer running times, is there any chance to run the code on 32GB GPU or 40GB GPU memory is a must?
Thanks for your time.

Thanks for your questions.
The error about importing 'Augmenter' is due to the code version. The 'Augmenter' is not used in this version, so you can just delete line 8 in data.py 'from augment import Augmenter'. Thanks for your reminder. I have updated data.py.
As for the GPU capacity, you can try to decrease the batch size, but the performance may be affected.


Receiving an [NSInvalidArgumentException] in DFU Library following 4.2.2 Pod update

Hi,
I'm receiving the following error following updating the DFU Library pod to the latest (v4.2.2)
NSInvalidArgumentException', reason: 'attempt to scroll to invalid index path: <NSIndexPath: 0x2810bed80> {length = 2, path = 0 - 1}'
The error occurs when I segue into the DFU update screen of my code.
I've narrowed the issue down to the DFU Library update. It does not happen on the previous version of your library.
Also, the class name is not indicated in the error so, I suspect you will need to use a symbolic breakpoint to debug.

Hi @mostafaberg - I'm no longer encountering this issue and am therefore closing this ticket.
Thanks!


Add redhat collection

https://issues.redhat.com/browse/HACBS-2370

Lgtm. Is it every rule, or most rules?

Lgtm. Is it every rule, or most rules?

Most rules. I skipped the external_parameters because that's for SLSA Provenance v1.0, and the github one for obvious reasons.


Is there a callback?

Is there a callback once a diagram is drawn?

Is there a callback once a diagram is drawn?


Editor crashes upon adding arguments to BTCallMethod

Currently the Editor is crashing when attempting to add arguments to BTCallMethod, either when increasing the argument array size or clicking Add Element.
Internally the crash happens due to derefencing a null Object pointer.
Here's the backtrace:
#0  Object::get (this=0x0, p_name=..., r_valid=r_valid@entry=0x0) at core/object/object.cpp:317
#1  0x00005555582bd3b0 in EditorProperty::get_edited_property_value (this=0x55557673bea0) at ./editor/editor_inspector.h:162
#2  EditorPropertyBBParam::_get_edited_param (this=this@entry=0x55557673bea0) at modules/limboai/editor/editor_property_bb_param.cpp:44
#3  0x00005555582bd646 in EditorPropertyBBParam::_notification (this=this@entry=0x55557673bea0, p_what=p_what@entry=45) at modules/limboai/editor/editor_property_bb_param.cpp:313
#4  0x00005555582c00cb in EditorPropertyBBParam::_notificationv (this=0x55557673bea0, p_notification=45, p_reversed=false) at modules/limboai/editor/editor_property_bb_param.h:32
#5  0x000055555a90ad76 in Object::notification (this=0x55557673bea0, p_notification=p_notification@entry=45, p_reversed=p_reversed@entry=false) at core/object/object.cpp:837
#6  0x0000555559e46dca in ThemeOwner::_owner_context_changed (this=this@entry=0x555576b965c0) at scene/theme/theme_owner.cpp:101
#7  0x0000555559e471fe in ThemeOwner::set_owner_context (this=0x555576b965c0, p_context=<optimized out>, p_propagate=true) at scene/theme/theme_owner.cpp:87
#8  0x0000555559526417 in Control::set_theme_context (this=0x55557673bea0, p_context=0x55556eab2aa0, p_propagate=80) at scene/gui/control.cpp:2472
#9  0x000055555952a3a6 in Control::_notification (this=0x55557673bea0, p_notification=10) at scene/gui/control.cpp:3184
#10 0x0000555557cd3881 in Control::_notificationv (this=0x55557673bea0, p_notification=10, p_reversed=false) at ./scene/gui/control.h:48
#11 0x0000555558158fb0 in Container::_notificationv (this=0x55557673bea0, p_notification=10, p_reversed=false) at ./scene/gui/container.h:37
#12 0x00005555582bf1f8 in EditorProperty::_notificationv (this=0x55557673bea0, p_notification=10, p_reversed=p_reversed@entry=false) at ./editor/editor_inspector.h:58
#13 0x00005555582c00dc in EditorPropertyBBParam::_notificationv (this=0x55557673bea0, p_notification=10, p_reversed=false) at modules/limboai/editor/editor_property_bb_param.h:32
#14 0x000055555a90ad76 in Object::notification (this=this@entry=0x55557673bea0, p_notification=p_notification@entry=10, p_reversed=p_reversed@entry=false) at core/object/object.cpp:837
#15 0x00005555594107c2 in Node::_propagate_enter_tree (this=this@entry=0x55557673bea0) at scene/main/node.cpp:262
#16 0x0000555559410afe in Node::_set_tree (this=0x55557673bea0, p_tree=0x55555f6334d0) at scene/main/node.cpp:3011
#17 0x0000555559411c0a in Node::_add_child_nocheck (this=this@entry=0x555576bdadf0, p_child=<optimized out>, p_child@entry=0x55557673bea0, p_name=..., p_internal_mode=p_internal_mode@entry=Node::INTERNAL_MODE_DISABLED) at scene/main/node.cpp:1404
#18 0x0000555559415b59 in Node::add_child (this=0x555576bdadf0, p_child=0x55557673bea0, p_force_readable_name=<optimized out>, p_internal=Node::INTERNAL_MODE_DISABLED) at scene/main/node.cpp:1436
#19 0x000055555941f31b in Node::add_sibling (this=0x555576dd8d50, p_sibling=0x55557673bea0, p_force_readable_name=80, p_force_readable_name@entry=false) at scene/main/node.cpp:1446
#20 0x0000555558a24b4f in EditorPropertyArray::update_property (this=0x55557696b430) at editor/editor_properties_array_dict.cpp:410
#21 0x0000555558a216ec in EditorPropertyArray::_length_changed (this=0x55557696b430, p_page=1) at editor/editor_properties_array_dict.cpp:609
#22 0x0000555558a2e1d9 in call_with_variant_args_helper<EditorPropertyArray, double, 0ul> (p_instance=<optimized out>, p_method=<optimized out>, p_args=<optimized out>, r_error=...) at ./core/variant/binder_common.h:304
#23 0x0000555558a2e21a in call_with_variant_args<EditorPropertyArray, double> (p_instance=<optimized out>, p_method=<optimized out>, p_args=p_args@entry=0x7fffffffae20, p_argcount=p_argcount@entry=1, r_error=...) at ./core/variant/binder_common.h:418
#24 0x0000555558a2e2b9 in CallableCustomMethodPointer<EditorPropertyArray, double>::call (this=0x555576c313c0, p_arguments=0x7fffffffae20, p_argcount=1, r_return_value=..., r_call_error=...) at ./core/object/callable_method_pointer.h:98
#25 0x000055555a721472 in Callable::callp (this=this@entry=0x555577058130, p_arguments=p_arguments@entry=0x7fffffffae20, p_argcount=p_argcount@entry=1, r_return_value=..., r_call_error=...) at core/variant/callable.cpp:56
#26 0x000055555a911431 in Object::emit_signalp (this=0x555576ef7df0, p_name=..., p_args=0x7fffffffae20, p_argcount=1) at core/object/object.cpp:1134
#27 0x000055555942389c in Node::emit_signalp (this=0x555576ef7df0, p_name=..., p_args=0x7fffffffae20, p_argcount=1) at scene/main/node.cpp:3762
#28 0x0000555558235c6e in Object::emit_signal<double> (this=0x555576ef7df0, p_name=...) at ./core/object/object.h:923
#29 0x000055555961ae0d in Range::_value_changed_notify (this=0x555576ef7df0) at scene/gui/range.cpp:48
#30 0x000055555961aea9 in Range::Shared::emit_value_changed (this=<optimized out>) at scene/gui/range.cpp:58
#31 0x000055555961af34 in Range::set_value (this=this@entry=0x555576ef7df0, p_val=<optimized out>) at scene/gui/range.cpp:92
#32 0x0000555558bfc6a9 in EditorSpinSlider::gui_input (this=0x555576ef7df0, p_event=...) at editor/gui/editor_spin_slider.cpp:65
#33 0x000055555952a118 in Control::_call_gui_input (this=this@entry=0x555576ef7df0, p_event=...) at scene/gui/control.cpp:1797
#34 0x00005555594662d4 in Viewport::_gui_call_input (this=this@entry=0x55555f6339e0, p_control=<optimized out>, p_input=...) at scene/main/viewport.cpp:1603
#35 0x0000555559473b59 in Viewport::_gui_input_event (this=0x55555f6339e0, p_event=...) at scene/main/viewport.cpp:1835
#36 0x0000555559477c99 in Viewport::push_input (this=0x55555f6339e0, p_event=..., p_local_coords=80, p_local_coords@entry=false) at scene/main/viewport.cpp:3371
#37 0x0000555559499ea7 in Window::_window_input (this=0x55555f6339e0, p_ev=...) at scene/main/window.cpp:1620
#38 0x00005555594ba032 in call_with_variant_args_helper<Window, Ref<InputEvent> const&, 0ul> (p_instance=<optimized out>, p_method=<optimized out>, p_args=<optimized out>, r_error=...) at ./core/variant/binder_common.h:304
#39 0x00005555594ba092 in call_with_variant_args<Window, Ref<InputEvent> const&> (p_instance=<optimized out>, p_method=<optimized out>, p_args=p_args@entry=0x7fffffffd3d0, p_argcount=p_argcount@entry=1, r_error=...) at ./core/variant/binder_common.h:418
#40 0x00005555594ba131 in CallableCustomMethodPointer<Window, Ref<InputEvent> const&>::call (this=0x55556eac20b0, p_arguments=0x7fffffffd3d0, p_argcount=1, r_return_value=..., r_call_error=...) at ./core/object/callable_method_pointer.h:98
#41 0x000055555a721472 in Callable::callp (this=this@entry=0x7fffffffd460, p_arguments=p_arguments@entry=0x7fffffffd3d0, p_argcount=p_argcount@entry=1, r_return_value=..., r_call_error=...) at core/variant/callable.cpp:56
#42 0x00005555578868ae in Callable::call<Ref<InputEvent> > (this=this@entry=0x7fffffffd460) at ./core/variant/variant.h:863
#43 0x000055555787d9e1 in DisplayServerX11::_dispatch_input_event (this=<optimized out>, p_event=...) at platform/linuxbsd/x11/display_server_x11.cpp:4037
#44 0x000055555787da93 in DisplayServerX11::_dispatch_input_events (p_event=...) at platform/linuxbsd/x11/display_server_x11.cpp:4013
#45 0x000055555a6e32ea in Input::_parse_input_event_impl (this=this@entry=0x55555d769320, p_event=..., p_is_emulated=p_is_emulated@entry=false) at core/input/input.cpp:770
#46 0x000055555a6e3fe5 in Input::flush_buffered_events (this=0x55555d769320) at core/input/input.cpp:1041
#47 0x0000555557880ab9 in DisplayServerX11::process_events (this=0x55555dfba4a0) at platform/linuxbsd/x11/display_server_x11.cpp:5138
#48 0x000055555785e8b3 in OS_LinuxBSD::run (this=this@entry=0x7fffffffd820) at platform/linuxbsd/os_linuxbsd.cpp:941
#49 0x000055555785d142 in main (argc=<optimized out>, argv=0x7fffffffde28) at platform/linuxbsd/godot_linuxbsd.cpp:86

I can't reproduce it in both module and extension. Which LimboAI revision, Godot version and platform do you use?

Godot: e42141fe8a1f6ec4cf910a02defc2d6ade58cb1a
LimboAI: 5909735add70cd0498eef9c544abecacb4bdcf83

Recently I've been stumbling upon some race conditions within the Editor itself -- let me take a closer look. I wonder if it's one of those.

I'm currently targeting 4.2 branch for development, and planning to switch to master after 4.3 gets to beta3/rc. So I didn't test it vs bleeding edge. There might be issues.

That's alright. I'll try to help close the gap against the bleeding edge a bit if I can. I want to stick to the bleeding edge version because some race conditions my hardware was stumbling upon have been fixed there.

I'm currently targeting 4.2 branch for development

I can't reproduce the crash when using that branch either. Something changed upstream. I'll bisect the issue.

The offending commit is https://github.com/godotengine/godot/pull/87085 -- it either made the issue apparent or introduced a new one. I think it's the latter.

So it crashes somewhere in the BBParam property editor, and it's related to theming. Maybe, it's worth checking the code that deals with theming in the property editor itself?

I'm not sure what's really happening now -- I disabled ASLR to track some memory values and now I'm also crashing on a commit that previously worked. I need to bisect again.
What I've been able to pinpoint so far is that EditorProperty::set_object_and_property does not get called when updating the array size, which is why EditorPropertyBBParam::object is null and crashes when trying to dereference it I believe.

Are you using some specific build options that I could try to reproduce the issue?
Mine are:  platform=linuxbsd target=editor linker=mold dev_build=yes debug_symbols=yes tests=yes

I just finished bisecting again and now it looks like https://github.com/godotengine/godot/commit/db7175458a0532f1efe733f303ad2b55a02a52a5 is causing the crash.
I'm using:
scons -Q -s platform=linuxbsd dev_mode=yes dev_build=yes udev=yes target=editor debug_symbols=yes precision=single bits=64 optimize=debug compiledb=yes linker=gold tests=yes werror=no -j$(nproc)

So it means that instead of deferred adding property as a child, it's now added immediately. That might cause the object and property to be set after the notification() fires. Maybe, the initialization code from THEME_CHANGED could be delayed enough for the object pointer to be set.

I just finished bisecting again and now it looks like godotengine/godot@db71754 is causing the crash.
I'm using:
scons -Q -s platform=linuxbsd dev_mode=yes dev_build=yes udev=yes target=editor debug_symbols=yes precision=single bits=64 optimize=debug compiledb=yes linker=gold tests=yes werror=no -j$(nproc)

Yeah, I think you found the real culprit. I looked at the initialization code in THEME_CHANGED and _setup and I think it needs to go to update_property or be delayed.

I looked at the initialization code in THEME_CHANGED and _setup and I think it needs to go to update_property or be delayed.

Makes sense. I did a rough test by removing add_property_editor from here:
https://github.com/limbonaut/limboai/blob/b220a9f4181ef67a47bbe2146f5f6a51355899d1/editor/editor_property_bb_param.cpp#L386
And I don't get a crash anymore.
I'll follow up tomorrow on this.


Add a "GetAll" NetworkHandler

It should go through the map array and send the client requests to spawn a tile with existing data in the spot the tile is in. It should take a x value and a y value representing the top left corner of a 15*15 square. (Representing the size of the viewport)

I've almost got this working, I just need to finish debugging everything now that I have a way to test it.


Get map of interface name to index

Needs more thorough testing

  		if val, err := strconv.Atoi(match[1]); err == nil {

separate impl from join

Refers to: netsh/netsh.go:126 in 7f904d2. [](commit_id = 7f904d28d78d6b262c24cb15dfc7a2c5422e3dd8, deletion_comment = False)


Use pnpm to manage extensions' dependencies

Right now, each extension has its own isolated node_modules folder. Some extensions may share common dependencies, so it takes extra disk space to install duplicated packages, it also downloads the same thing more than once.
pnpm can solve this problem: It uses symlinks/hardlinks to avoid downloading the same package twice. It also faster than both npm and yarn (in my personal experience).

A good article that shows the disk space savings of pnpm vs npm/yarn: NPM, Yarn and PNPM: Which Package Manager Should You Use for SharePoint Framework Projects?

@joaomoreno Does it makes sense what user is suggesting?

@sandy081 Although you're not asking me, your question make me confuse. What do you meant by "makes sense"? Is my suggestion above not clear enough? Perhaps I'm assuming something: Does VS Code use npm at all?

No, Code doesn't use npm at all, all extensions need  to pack their node_modules folder into the vsix extension package.

So I'm assuming things. Silly me.


[WIP] export api and internal/updater

Move api and 'internal/updater under pkg
Signed-off-by: akihikokuroda<EMAIL_ADDRESS>

api is already exported. I think I'd prefer to leave that where it is.

OK.  It's much easier.  I close this PR and create a new one just for updater.


Dealing with errors

Taking the discussion from #13 to the top level.
Once an API reaches a certain complexity it becomes necessary to communicate errors back to the client. We'll have to decide how to represent errors as part of a Yaks::Resource, so formats can take that error info and represent it. This needs to be able to carry enough info so formats with explicit support for error info can use that. On the other hand formats that don't have explicit specifications for errors should still be able to render them using (sub)resources and attributes.
In Collection+JSON the situation is pretty simple, it is allowed to add an extra "error" key at the top level, which MAY contain "error", "code" and "message" (see the spec)
{
  "error" :
  {
    "title" : STRING,
    "code" : STRING,
    "message" : STRING
  }
}

For JSON-API it's still under discussion. Long thread but some good stuff there.
For Siren, people also haven't decided yet, but there's a proposal gist
Mason does have it specified in their spec
They have an optional "@error" key, similar to CJ, but more extensive: it can also contain "@code" and "@message", but also "@messages" (list of string), "@controls" (hypermedia controls), "@httpStatusCode". Unfortunately they don't have forms (with fields) (more about why that matters in a sec), it's a format that's in the "response template" school of hypermedia controls.
For Ticketsolve what we do is we have a separate ErrorMapper. Any exception that's raised in our API endpoints (~= controllers) gets caught and passed to the ErrorMapper. This renders a resource with http_code, type, and message attributes, e.g. (in HAL)
{
  "http_code": 404,
  "message": "Couldn't find Show with id=8735283249999",
  "type": "record_not_found",
  "_links": {
    "profile": [
      {
        "href": "http://api.ticketsolve.com/profile/error"
      }
    ]
  }
}

If a form embedded in an API response is submitted, and this causes a validation error, then we raise a special exception, which holds a reference to the form object. In that case an error response like above is rendered, but it also includes the form, with error messages embedded in the form fields (you'll notice that Yaks::Resource::Form::Field has an error attribute).
All of that as a bit of background. I still want to spend some more time going over the discussion happening over at JSON-API, cause there are some good pointers there, but from what I've seen so far...
Summarizing
Errors can either be represented as a top-level entity (Siren, last example above), or as part of another resource (CJ, Mason). The latter I find a bit odd, how can you still return a proper resource if the operation that was requested didn't succeed, but I'm sure there are use cases.
Secondly the error itself seems to commonly have

a string "type" / "code" to identify the error
a single string "message"
some formats repeat the HTTP code. This may seem redundant but I know from experience this can be useful

Then you have things like these

["name can't be empty", "email address is invalid"] (Mason "@messages")

{"first_name": ["can't be empty"], "email": ["email is invalid"]} (allows mapping back to UI fields, some examples of that in the JSON API thread)

{"type": "text", "name": "first_name", "error": ["can't be empty"]} (i.e. what we are currently doing, embed the form-field specific errors inside a form representation).

Note that formats that do 1) or 2) could take 3) and collapse it into what they need.
So... with all that in mind, I would suggest we represent errors as their own Yaks::Resource (or possibly a subclass Yaks::ErrorResource), where we standardize which attribute names to use for a top level message string, error code, http code, maybe others. You can either serialize this at the top level, or include it as a subresource under the error link relation.
Formats can do a couple different things with this

just render it like any other resource, in case the format has no explicit support for it
map the attributes to whatever is the standardized name in a given format
render embedded forms with fields errors as is, or
extract the messages and represent them in isolation.

Finally a remark about including extra error information on an otherwise "regular" response. This I would do by passing it in the Rack environment. If you have all your mappers inherit from a BaseMapper, then you can do something like this
class BaseMapper < Yaks::Mapper
  has_one :error, if: -> { env['api.error'] }, mapper: ErrorMapper
end

So any controller can set "api.error" to sideload that information into the response that is being rendered.

@plexus Just listing some of the options and potential issues with each.
Subclass e.g. Yaks::ErrorResource

Are standard resources and error resources the only two types of Yaks resource we would ever need?
Using this approach, it would be expected that we are rendering an error, and only an error. No sideloading errors.

Tags on a resource
E.g. The mapper has a tags method, where you would pass tags (e.g. :error) to the resource that gets built

Same issue with no sideloading
Allows more possibilities than just errors, but that may not be necessary (and not as clear what tags are supported, or even what they are for)

A convention for attributes.
E.g. by convention, store error-related data in a hash under the attribute _errors

Simple, and would just require implementing by the formatters.
Possibility of clashing with actual attribute names
Might be a little bit more work for one to set up the mapper given they'd have to construct the hash.

error_attributes
Similar to using convention for attributes, but we have a method in the mappers that works just like attributes, but maps to a specific attribute in the resource.
attributes :id, :name, :data, tags: :errors
A mix of tags and error_attributes

@danelowe I wrote up a concrete proposal in #112, please have a look if you can and see if you have any feedback or input.


Logo rotation speed must be consistent on different screen rates

See https://stackoverflow.com/questions/66323325/canvas-is-drawing-with-inconsistent-speed-requestanimationframe

Fixed by 7a6ee7301646ca63f0e478053bdcc16693c65c84


Consider creating development mirrors

Engineers can be blocked for some time until needed release of Iglu Central is out.
I propose to publish mirrors of dev-branches on separate domain - if I'm pushing branch schema/616 - Travis pushes content of this branch on some domain backed by S3 (like iglucentral-dev.com/schema/616), so I could use iglucentral-dev.com/schema/616 as registry in resolver config and access required schema at http://iglucentral-dev.com/schema/616/schemas/com.snowplowanalytics.snowplow.storage/redshift_config/jsonschema/1-0-0). Could be released for each PR, without tags.
This is just more convenient than spinning-up own static HTTP server. As downside, I afraid configs could end up polluted with dev registries.

/cc @jbeemster

Added a new S3 bucket website at: http://iglucentral-dev.com.s3-website-us-east-1.amazonaws.com/


Software template for Keycloak

As an Assemble contributor or demo'er
I want a Keycloak software template
So that I can spin a Keycloak instance to use for Backstage authentication
Acceptance:
Automatically provision operator
Automatically provision instance
Automatically provision service accounts / RBAC

software template

Is there a definition/description about what is a software template ? Why do you want to spin an instance using k8s resources, chart, etc instead of using a controller or application on the platform able to provision such a service, app from a package + parameters using the input of the user ? Delegating such a work on the platform could simplify the work to maintain for assemble tens of yaml, templates, ... WDYT ? @davgordo

Thanks for your thoughts @cmoulliard I agree that the way this automation is packaged could be re-imagined. Helm is a convenient way for us to express the components we need in the short term, and I have an idea to compose as a "chart of charts" (just for now) to collect parameters in one place for someone installing the platform. I have a feeling that maintaining this "master chart" is not sustainable. An operator or controller of some kind could nicely encapsulate platform operations. I hope that short term scaffolding with a GitOps controller + Helm templating at least helps to inform later implementations.

closed by #18


Add r2 list objects

Description
Add missing R2 list objects support.
Came up in wrangler, wanted to add it here too but it's not a part of publicly documented API so feel free to close.
Has your change been tested?
Yes
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[ ] This change is using publicly documented in cloudflare/api-schemas
and relies on stable APIs.

closing this for now due to missing public documentation. if we can get the endpoints documented, this will automatically make it's way into v2.


inconsistency between reactive and shallowReactive

Version
3.0.0
Reproduction link
https://codepen.io/SeregPie/pen/MWeamRG
Steps to reproduce
let object = {a: {b: 1}};
console.log(isReactive(shallowReactive(object).a)); // false
console.log(isReactive(reactive(object).a)); // false

but
let object = {a: {b: 1}};
console.log(isReactive(reactive(object).a)); // true
console.log(isReactive(shallowReactive(object).a)); // true

let object = {a: ref(1)};
console.log(isRef(reactive(object).a)); // false
console.log(isRef(shallowReactive(object).a)); // false

but
let object = {a: ref(1)};
console.log(isRef(shallowReactive(object).a)); // true
console.log(isRef(reactive(object).a)); // true

What is expected?
The order of the function calls should not matter, because those functions do not alter the original object.
What is actually happening?
Some unexpected things.

Maybe some clear definitions are needed.
Here are my proposals.
// nested object
let object = {a: {b: 1}};
console.log(isReactive(shallowReactive(object).a)); // should always be false
console.log(isReactive(reactive(object).a)); // should always be true

// ref in object
let object = {a: ref(1)};
console.log(isRef(shallowReactive(object).a)); // should always be false
console.log(isRef(reactive(object).a)); // should always be false

// nested ref in object
let object = {a: {b: ref(1)}};
console.log(isRef(shallowReactive(object).a.b)); // should always be true
console.log(isRef(reactive(object).a.b)); // should always be false

// special cases
let object = {a: {b: 1}};
console.log(shallowReactive(reactive(object)) === reactive(object)); // should always be true
console.log(reactive(shallowReactive(object)) === shallowReactive(object)); // ???

you cannot pass the same object to two different reactive, ref, etc functions. It has to be a different object every time:
console.log(isReactive(shallowReactive({a:{b:1}}).a)); // should always be false
console.log(isReactive(reactive({a:{b:1}}).a)); // should always be true


feat: add method add_link to Changelog

Description
Add a public add_link method to Changelog to allow the user to add a link to content added to the changelog such as the link to a related issue.
Summary of changes

chore(Cargo.lock): update dependencies getrandom to version 0.2.14 and uuid to version 1.8.0
feat(Cargo.toml): add uuid dependency with version 1.8.0 and features ["v4"]
feat(changelog.rs): add method add_link to Changelog struct
feat(test): add test for adding a link to Changelog
refactor(parser.rs): change log level from debug to trace in Parser struct
refactor(token.rs): change log level from debug to trace in tokenize function
docs(changelog.rs): add example for adding a link to the list of links
chore(Cargo.lock): update package versions

@napalmpapalam

@napalmpapalam  requested change has been implemented.

Released under the 0.1.4


Add ITK-SNAP 3.6.0

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[ ] brew cask style --fix {{cask_file}} reports no offenses.
[x] The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

[x] Named the cask according to the token reference.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.
[x] Checked there are no open pull requests for the same cask.
[x] Checked the cask was not already refused in closed issues.
[x] Checked the cask is submitted to the correct repo.

The style check failed because the download URL doesn't match the main page. Can you guys please verify that?

I was waiting to read the doc you gave me so that I could answer.
I thought 3.4.0 should be here and 3.6.0 in homebrew-versions. Anyway I don't think many people use the stable version. Thanks for reviewing.

I was waiting to read the doc you gave me so that I could answer.

I checked the appcast and realised that following the example in the doc wouldn't work in this case.

I thought 3.4.0 should be here and 3.6.0 in homebrew-versions.

3.6.0 looks like it is the current version.

http://www.itksnap.org/pmwiki/pmwiki.php?n=Downloads.SNAP3

3.6.0 looks like it is the current version.

In the downloads page there are three versions:

Latest
Stable
Nightly

Since the stable seems old and the latest seems stable, I guess what makes sense is adding the latest here and the nightly in versions. What do you think?

Sorry, you're right, I missed the stable version. I followed the latest version on the homepage and the sourceforge page.

I guess what makes sense is adding the latest here and the nightly in versions

If a nightly cask would be of use to you please feel free to submit a PR to caskroom/versions to add it.

Thank you for your contribution.


feat: allow very_good create .

Status
READY/IN DEVELOPMENT/HOLD
READY
Description
Allows . as a project name (like flutter create .)
Type of Change

[x] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑 Chore

fixes https://github.com/VeryGoodOpenSource/very_good_cli/issues/969

this is ready for review.
by the way, the repo had 37 broken tests when I cloned it on my machine. I was wondering if I should submit those as issues.

Fixed the formatting issue by updating from main via #1003 so CI is now passing. @wolfenrain can we get a review here?

Pinging @wolfenrain

sure thing, let me know if there's anything I need to do.

sure thing, let me know if there's anything I need to do.

The CI seems to be failing on some tests, mind having a look at that? I suspect that the tests are failing because of wrong parameters (might mean it isnt backwards compatible like we hoped?)

I can't tell which tests are failing. See this issue for more details https://github.com/VeryGoodOpenSource/very_good_cli/issues/1162


Fix https://github.com/mozilla/thimble.webmaker.org/issues/1091 - don't fail to rewrite a CSS file due to a missing file in a url()

We were being too aggressive in our error handling with the CSSRewriter (similar to the problem we found with the HTMLRewriter earlier).  Instead of failing fast when a file is not found, we should warn and keep going.

r+


Record that freshness tests are available for BQ

Freshness tests were added for BigQuery in https://github.com/dbt-labs/dbt-bigquery/pull/1072 and released with dbt-bigquery 1.7.3.
What are you changing in this pull request and why?
Updates documentation to indicate that freshness tests are now available for BigQuery. Freshness tests were added for BigQuery in https://github.com/dbt-labs/dbt-bigquery/pull/1072 and released with dbt-bigquery 1.7.3.
Checklist

[x] Review the Content style guide so my content adheres to these guidelines.
[x] For docs versioning, review how to version a whole page and version a block of content.
[ ] Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

hey @elyobo , thanks for opening this up and apologies for the delay here! we've merged a pr https://github.com/dbt-labs/docs.getdbt.com/pull/5080 that adds bq to the supported list. however, I'll triple check the version info you added and will perform a fast follow pr. in the meantime, I'll close this pr since it's been addressed. thank you again! ✨


Autodiff

Hi guys,
I've seen a lot of things in terms of ML frameworks, however for my work as a research I find autodiff very usefull (e.g. symbolic graph manipulation). On the other hand arrayfire seems like the perfect the backend for such framework, as it seemsly can be adopted for GPUs and so on (I'm still interested if there is any chance of adding somehow fallback to cuDNN where possible).
Since I've atempted such things, and however lack the experience of well written performance code, was wondering how open are you guys to such proposal and would anyone be interested in giving help for making better code generation to arrayfire.
I understand this is not your main goal, but I find arrayfire probably as best candidate for a computational backend, while autodiff gives a few orders of magnititude productivity. If I happen to this I do intend to do it in c++.

@Botev We already have an issue open for this: https://github.com/arrayfire/arrayfire-ml/issues/2
Can you make your suggestions and link any technical papers over there?


Poor man fix of the CUDA FP8 return output

Poor man fix of the CUDA FP8 return output
The output should be a single tensor to be cased rather than 2 when output dtype is not FP8. Issues reported at: #643

Closed as torch 2.5.0 dev has refactored to output 1 output for torch._scaled_mm


Exception calling "GetResponse" with "0" argument(s): "The operation has timed out"

Exception calling "GetResponse" with "0" argument(s): "The operation has timed out"
At C:\Projects\libsfw2\libsfw-ps\Export-JsonManifest.ps1:132 char:9
+         $WebRequest = $WebRequestQuery.GetResponse()
+         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : WebException

Whilst this is not going to provide output, the file will be verified by the C#/.Net application that follows, odf.dll
try
{
    & dotnet "C:\odf\optechx.DownloadFile.dll" $AbsoluteUri $DownloadFilePath
    Write-Output "$([System.Char]::ConvertFromUTF32("0x1F7E2")) DOWNLOAD VERIFIED"
}
    catch
{
    "$([System.Char]::ConvertFromUTF32("0x1F534")) UNABLE TO DOWNLOAD FILE"
    return
}

GHTicket logging required at this step, where there is a catch { }


Control repair ticket per-invocation

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
Retry either creates repairs for all failures or none, depending on the configuration setting.  I'd love some finer grain control.
Describe the solution you'd like
Some options:

Disable repair creation when on_error is specified even if it's globally enabled.  Since the user is obviously handling the situation in the script/automation, the repair seems redundant.  I don't LOVE this option.
Add a 'repair' boolean to 'data' so each call to retry can manually specify whether to create a repair or not.  If this is specified, it should override the global setting.  If this is not specified the global setting should be used to determine whether to create a repair.

Describe alternatives you've considered
I guess I could disable repairs globally and add them back in on_error when I want them, but this seems a bit clumsy.
Additional context
There are several places where I'd like to retry an action, but failures are transient and rendered irrelevant after a few minutes.  Don't get me wrong, I'll keep an eye on the logs for this, but the repairs are just noise.  Then there are places where a retry failure is a Very Bad Thing(tm), and I really want the visible repair.

@amitfin if you're amenable to this, I wouldn't mind opening a PR in a day or two.  Just oddly busy today and tomorrow, and I wanted to get your opinion of the feature before I code something pointless (in case there's a better way or you have something else in mind).

v3.1.0 adds a repair parameter (documentation is here).
@gdgib , please comment if it addresses the use case.

I wasn't expecting you to not only like the idea but implement it so fast I didn't even have time to comment.  I sincerely appreciate it.  Not only does that address the use case, it is exactly what I was thinking.  Thank you very much @amitfin.  I am impressed and grateful.


Mirrornode returns a total supply of 0 even when some accounts hold the token.

Description
The mirrornode returns a total_supply of 0 for the testnet USDC token: link, but this is not accurate as some accounts hold the token: link.
Steps to reproduce

Search for this token (0.0.429274) on the Testnet HashScan: https://hashscan.io/testnet/token/0.0.429274?p=1 and check the total supply.
Verify that some accounts hold the token: https://testnet.mirrornode.hedera.com/api/v1/tokens/0.0.429274/balances

Additional context

Hedera network
testnet
Version
v0.1.0
Operating system
None

In data returned by mirror node, total_supply is "0". So HashScan displays the expected value.
Could you file an issue in mirror-node ?
Closing.

Done: https://github.com/hashgraph/hedera-mirror-node/issues/8433


HtmlControl content isn't assigned

I trying to use a HtmlControl but the XAML loader throws exception Portable.Xaml.XamlObjectWriterException: The value  for 'Content' property is null
Also I tried to assign Content\Text parameter, but the loader throws exception too.
There is a MainWindows.xaml:
<Window xmlns="https://github.com/avaloniaui"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        Title="AvaloniaApplication2">
  <HtmlControl>

  </HtmlControl>
</Window>

and Designer's (Loader says it too) log:
Portable.Xaml.XamlObjectWriterException: The value  for 'Content' property is null
   at Portable.Xaml.XamlObjectWriterInternal.OnWriteGetObject()
   at Portable.Xaml.XamlServices.Transform(XamlReader xamlReader, XamlWriter xamlWriter, Boolean closeWriter)
   at Avalonia.Markup.Xaml.AvaloniaXamlLoaderPortableXaml.LoadFromReader(XamlReader reader, AvaloniaXamlContext context)
   at Avalonia.Markup.Xaml.AvaloniaXamlLoaderPortableXaml.Load(Stream stream, Object rootInstance, Uri uri)
   at Avalonia.DesignerSupport.DesignWindowLoader.LoadDesignerWindow(String xaml, String assemblyPath)
   at Avalonia.DesignerSupport.Remote.RemoteDesignerEntryPoint.<>c__DisplayClass17_0.<OnTransportMessage>b__0()

Html control hasn't been updated in a long time, what do you want from html control? I have a possible alternative see... https://github.com/VitalElement/CefGlue.Core which allows you to embed chrome engine to view Web pages or html, it's not so lightweight though, but does work

Thanks, I was exploring Avalonia and found this control. I have not any tasks for this. Thanks for suggestion.

Can we exclude this project from Avalonia?

I think that's probably a good idea

I've moved the project into a separate repo.


An event has multiple consumer then what will be happen ?

Yes, you are right. But it works when debug the code, without debug it consume first consumer then change PersistMessage messageStatus.

Yes, you are right. But it works when debug the code, without debug it consume first consumer then change PersistMessage messageStatus.

I added a sample for RegisterNewUser endpoint and after that publish an event user-created and consume this event in multiple consumers (Flight-Services and Passenger-Services) and it's work correctly.
You can check these changes in this PR: #43


Black Screen on Terminal

Type: Bug
I've been using VSCode for a coupIe months now, and had to reinstall Windows because of a couple other problems. But after I did, I can't see any characters in the terminal. There's just a black box masking the code behind it, sometimes not even covering the entire terminal. I tried changing the gpu acceleration setting as well, and that worked, but when I tried running it, it instead created a new tab with the code but still with the black box. I don't know why this happened, it was working before I reinstalled Windows. I've tried changing the terminal colors and reinstalling VSCode. Is there a fix to this problem?
Here's a screenshot of the terminal: https://github.com/microsoft/vscode/assets/132013493/e5c5e962-564c-4fc6-bf6d-c07bab4d1b72
VS Code version: Code 1.80.0 (660393deaaa6d1996740ff4880f1bad43768c814, 2023-07-04T15:06:02.407Z)
OS version: Windows_NT x64 10.0.22621
Modes:

System Info

Item
Value

CPUs
AMD Ryzen 7 7700X 8-Core Processor              (16 x 4500)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.15GB (24.14GB free)

Process Argv
--crash-reporter-id 82712a87-12fc-40bb-8ca1-3de1b9d73211

Screen Reader
no

VM
0%

Possibly historically related: #65958, #121244.
Does setting terminal.integrated.gpuAcceleration to "off" fix it?
Related on Stack Overflow: Whenever I use the terminal for VScode, theres a black box that covers a section of it up

/duplicate #187198


Custom aggregation functions

Currently trying to use a custom aggregation function (like group_concat on MySQL) runs into an "Invalid group by aggregation" error.
Example (using Person class from the docs):
def groupConcat[T] = quote {
    (t: T,sep: String) => infix"GROUP_CONCAT($t SEPARATOR $sep)".as[String]
 }
db.run(quote{ query[Person].groupBy(.age).map{ case(a,p) =>
  (a,groupConcat(p.map(.name),":"))
} })

@deterdw Could you test it using 0.4.1-SNAPSHOT? Make sure to have the Sonatype snapshots resolver configured.

@fwbrasil Sorry I missed this earlier, but it works now. This is great. Thank you!


Searching for "unit" comes up with no results.

Expected behaviour
All posts with the word "unit" in them.
Actual results:
No results whatsoever.
Steps
https://chat.zulip.org/#narrow/search/unit is one such example in the Zulip Zulip. In general, just use the top searchbar to search for "unit".
This is on the webapp, but seems platform-agnostic; production Zulip instances, as far as I know

This originates in a word list used to generate what is eventually the hunspell-en-us Ubuntu package (thanks @alexmv for that pointer), and as such I've opened https://github.com/en-wl/wordlist/issues/359. I'm unsure what the maintenance status of that repository is, there seem to have been no public commits since mid-2021, though there was some light activity in a few issues conversations in 2022. There's some further discussion on CZO about potentially investigating using Snowball for stemming (the default engine in PostgreSQL) instead of Hunspell, but for now, no conclusive plans on a workaround Zulip-side.

Tagged with the "dependencies" label that we use for tracking issues in upstream projects.


Inconsistent behavior inside docker

Hello everyone. My first time using rebar resulted in me stumbling upon a bug. In short, rebar eunit may or may not exit completely. In some cases it hangs after copying the src files into .eunit. Unfortunately this does not happen 100% off the time. It only happens occasionally. You can find the source for building the troublesome image at: https://github.com/ahawkins/docker-rebar-bug. I've also opened up a bug on docker here: https://github.com/docker/docker/issues/8910 since not sure where the fault is. You can test your setup by running: docker run --rm -it ahawkins/rebar-bug. The success/failure conditions are documented in the linked github repo.

After having the same issue, I played around with docker's storage backend, and that seems to be significant. I was able to reproduce with aufs backend but not with devicemapper backend. (This flag (-s) should be given when starting the docker service.)

Sorry, spoke too fast. It only became less reproducible: went from triggered 100% of the times to ~2/10 times.

/cc @ferd @tsloughter

Would that point to a purely docker issue compared to anything else?  I'm not sure what could fix it if rebar otherwise works fine on OSX, Windows, BSD, multiple linux distros and so on.

@ferd, if that question was aimed at me, I don't feel qualified to say, but I don't think that's an unreasonable conclusion. Hard to say without knowing the root cause of this issue.

I've marked this as a question and a bug given we're not quite sure who can fix this or if it's even our fault then.

Hi, this issue was closed in an attempt to do quick basic filtering. All tickets prior to March 2017 were closed and will be reopened on a per-request basis, please give rebar3 a try and feel free to reopen if it's a pressing issue that is still unresolved.


Allow for instantly opening live share links that are sent in chat.

In my experience, collaboration invites in VS code do not always appear when the user just launched vscode and we have to resort to sharing a link. Perhaps it would be possible to make it clickable in the live chat such that it instantly starts the session. (or let it generate a new invite?)

Please open live share issues/feature requests here: https://github.com/MicrosoftDocs/live-share/issues


Added Note feature to Developer Guide.

Added:

Chapter on Notes to Developer Guide
Class Diagram in .puml format for Note classes
Sequence Diagram in .puml format for addition of Notes.
Refactored packaging for Commands and Parsers.

Thanks for repackaging and making the codebase neater!


i cant download packages . igot error installing packages

Prerequisites

[ ] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description
[Description of the issue]
Steps to Reproduce

[First Step]
[Second Step]
[and so on...]

Expected behavior: [What you expect to happen]
Actual behavior: [What actually happens]
Reproduces how often: [What percentage of the time does it reproduce?]
Versions
You can get this information from copy and pasting the output of atom --version and apm --version from the command line. Also, please include the OS and what version of the OS you're running.
Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

i tried to install  atom packages put i get an error message
Unable to download https://www.atom.io/api/packages/atom-beautify/versions/0.30.9/tarball: getaddrinfo EAI_AGAIN www.atom.io:443
please i need your help

Thanks for reaching out!  This seems like a network/DNS issue?  Try again later and see if that helps or if you can test from another network, maybe give that a try as well.

We require the template to be filled out on all new issues and pull requests so if you can open a new issue with the template filled out, that would be helpful for us. We do this so that we can be certain we have all the information we need to address your submission efficiently. This allows the maintainers to spend more time fixing bugs, implementing enhancements, and reviewing and merging pull requests.
Thanks for understanding and meeting us half way :grinning:


Update Node & Ruby version in the documentation

Context
We recently updated Node to v10.15.1 and Ruby to v2.4.5, we should therefore update the documentation.
File example:
https://github.com/CartoDB/cartodb/blob/master/doc/manual/source/install.rst#nodejs

We can leverage that issue to update precompile assets documentation command to npm run build:dev instead of grunt.

I think everything is up to date now: https://github.com/CartoDB/cartodb/pull/14692/files
Can we close this?


Preparation for Release of Version 1.3.0

This pull request adds the task parallelism pattern identification to the available pattern detectors of the discopop explorer.

@aryamazaheri
It seems that i'm not able to perform the update of the branch.
Could it be bc. of missing permissions etc?


[DeviceInfo] Caching values for device info.

Device info values are fetched via COMRPC for the first time and are stored in a cache. Further queries are fetched from the cache.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Will be raising a simplified version than this.


sign: dont convert input buffers to utf8 strings

binary payloads would get mangled due to the unnecessary string
conversion, which should go the other way around
Fixes: https://github.com/brianloveswords/node-jws/issues/50

I would like to take a shot at https://github.com/brianloveswords/node-jws/issues/68, but it depends on this fix. Any movement on this?


Docs reorg: audit new URLs

URLs are hard to change, so we want the new URLs to be well named. We want to be confident that they will last us in the future, even if the slug is longer.
To do this, you'd look at https://github.com/Qiskit/documentation/blob/main/scripts/patterns-reorg/redirects.json. Each line has the original URL on the left, and the new URL on the right, but without the guides/ prefix showing. For example, line 2 "start/install": "install-qiskit", means start/install -> guides/install-qiskit
--
If you want to look at the page title for context, it may be helpful to instead look at entries.py, like this:
https://github.com/Qiskit/documentation/blob/640bd7ae0764aca8b3c05fc1f0020331e3f50d9c/scripts/patterns-reorg/entries.py#L35-L39
The first value is the page title. from_file is the old URL (minus the extension). slug is the new URL without the guides/ prefix.
--
You can leave suggestions as a comment on this issue.

I do have a vague, maybe-unfounded concern that page titles do change more often than URLs, so if we try to be too precise in our filenames, those could go stale. Thoughts @beckykd ?

I do have a vague, maybe-unfounded concern that page titles do change more often than URLs, so if we try to be too precise in our filenames, those could go stale. Thoughts @beckykd ?

I totally agree. For example, qiskit-serverless is titled "Qiskit Serverless Workloads", and right now it's the only page about Qiskit Serverless. But we could imagine adding more pages about Qiskit Serverless in the future. The qiskit-serverless page would still probably act like the introduction page to the tool, so maybe we'd do something like this:
Qiskit Serverless
|-  Introduction to Qiskit Serverless (qiskit-serverless)
|_ Advanced workflows (qiskit-serverless-advanced-workflows)

In other words, it is good to keep the page name generic as qiskit-serverless because it is flexible to us renaming Qiskit Serverless Workflows to Introduction to Qiskit Serverless. Whereas the URL qiskit-serverless-workflows would have been overly precise.
--
On the other end of the spectrum, a page like configuration is way too generic.

Are actual file names changing then? For example "start/install": "install-qiskit" ?

Yes, every single file is going to need a redirect from the old folders like start/ to the new guides/ folder. That means that now is our opportunity to rename the files if we want.

They seem mostly fine, but I think we should pull any with articles in the file names:
"transpile/create-a-transpiler-plugin": "create-transpiler-plugin",
"run/run-jobs-in-session": "run-jobs-session"

I propose:

circuit-visualization -> visualize-circuits
quantum-serverless -> qiskit-serverless (I think we have an issue open for that already)
circuit-construction -> construct-circuits
unitary-synthesis -> synthesize-unitary-operators
representing-quantum-computers -> represent-quantum-computers
building_noise_models -> build-noise-models
stabilizer-circuit-simulation -> simulate-stabilizer-circuits
primitives-get-started -> start-with-primitives or get-started-with-primitives
fair-share-queue -> fair-share-scheduler
verify/index -> debug or debugging-tools
execution-modes-intro -> execution-modes

This is now complete. Thank you everyone!


Crate test layer does not work if no logging configured

the crate test layer expects to read the host and port from the stdout of the crate process. if no logging is configured, the layer will wait infinitely.

@jukart fix is in master


[QUESTION] Serve static files from inside package

I am struggling a bit to get static file serving to work properly for an installed package.
I have a static mount setup like follows:
app.mount("/static", StaticFiles(directory="mypackage/static"), name="static")

This works fine if I run via uvicorn and I'm in the folder with my code.  However, in my more "production" like setup, Im installing my code via pip and thats where things seem to break.
When I run:
pip install mypackage
uvicorn mypackage.app:app

It errors out because the directory is no longer present, relative to where uvicorn is running.
I've tried leveraging the packages argument in starlette as well, but to no avail:
app.mount("/static", StaticFiles(directory="mypackage/static", packages=["mypackage"]), name="static")

When I run this, it errors out saying:
  File "/usr/lib/python3.8/site-packages/mypackage/main.py", line 10, in <module>
    app.mount("/static", StaticFiles(directory="mypackage/static", packages=["mypackage"]), name="static")
  File "/usr/lib/python3.8/site-packages/starlette/staticfiles.py", line 51, in __init__
    self.all_directories = self.get_directories(directory, packages)
  File "/usr/lib/python3.8/site-packages/starlette/staticfiles.py", line 71, in get_directories
    assert (
AssertionError: Directory 'statics' in package 'mypackage' could not be found.

Not really sure why this is.  Is there a better approach to this?  I can only think of sort of hacky ways of doing it, like leveraging __file__, but wanted to make sure I wasn't missing something obvious first.
Thanks!
-Tim

If you are creating an installable Python package, then you have to make sure that you are adding those files as data files included in the distributable.
You can uncompress your sdist and your wheels to make sure they contain your static files and their location.
But for production deployment, it might be easier, more robust, and with better performance to deploy with Docker. And you don't have to deal with the details of building a Python package.
Check the docs here: https://fastapi.tiangolo.com/deployment/


[ci skip] adding user @sloosvel

Hi! This is the friendly automated conda-forge-webservice.
I've added user @sloosvel as instructed in #6.
Merge this PR to add the user. Please do not rerender this PR or change it in any way. It has [ci skip] in the commit message to avoid pushing a new build and so the build configuration in the feedstock should not be changed.
Please contact conda-forge/core to have this PR merged, if the maintainer is unresponsive.
Fixes #6

@sloosvel, could you please confirm here for the record that you are ok to become a maintainer?

sure!


drivers: i2s: Make the stm32 i2s driver use a msgq

Currently uses a home grown ringbuffer and a semaphore with irq locks.

A quite welcome change. Could you mention how you tested it (particularly on which HW)  ?
Review might be delayed by few weeks due to the on going release, but definitely something we should look into closely.


Add a webmail

Why not add a webmail ?
Roundcubemail or something lighter...
With this feature, a user will be able to set out of office message easily without connecting to SSH

Perhaps this could help : https://github.com/vbotka/ansible-freebsd-mailserver-roundcube

Indeed, this is in my plan to add given it is my primary mode of emailing.
Also especially the sieve management functionality for filtering, which I abuse a lot.
For the first few releases, I want to get backend sorted out, especially getting maintenance scripts for adding users/aliases and changing passwords. I can't promise this to be there in I the first few alpha/beta releases where I need to get the mailserver working first.
But I do have some good news, I just did and end-to-end test, which lets me still receive emails and send emails. So I am doing the first release this weekend :)
I am going to start writing the INSTALLATION.md and should be good to go.

Sounds like  good idea.

Looking this a bit, we have through options, mysql, postgresql or sqlite. Personally I think sqlite is plenty for a small mail server. I'll leave this up to @epsilon-0 though.

I think we could start with sqlite, and if we get too request for MariaDB, or PostgreSQL we ll migrate.

Here are some basic notes on how we might set t his up with httpd.
pkg_add roundcubemail
rcctl php73_fpm enable
rcctl php73_fpm start
rcctl httpd enable
rcctl httpd start

# IP or interface to listen on. You can use * to listen everywhere.
# egress is an alias for the default route interface.
ext_if="egress"
domain="mail.yourdomain.com"

types { include "/usr/share/misc/mime.types" }

server $domain {
				listen on $ext_if port 80
				block return 301 "https://$domain$REQUEST_URI"
}

server $domain {
        listen on $ext_if tls port 443
        directory index "index.php"
        root "/var/www/roundcubemail"

	tls {
            certificate "/etc/ssl/example.crt"
            key "/etc/ssl/private/example.key"
        }

        location "/.ht*"             { block }
        location "/README"           { block }

        location "/*.php*" {
                fastcgi socket "/var/www/run/php-fpm.sock"
        }
}

Remove the ext_if variable, better to keep the egress keyword like in pf.conf file.

I have never configured httpd before, so please bear with me. Do I just remove ext_if and where I have that in my config put egress?


Smoothed Moving Average Indicator

Feature request for a Smoothed Moving Average:
The first value for the Smoothed Moving Average is calculated as a Simple Moving Average (SMA):
SUM1=SUM (CLOSE, N)
SMMA1 = SUM1/ N
The second and subsequent moving averages are calculated according to this formula:
SMMA (i) = (SUM1 – SMMA1+CLOSE (i))/ N
Where:
SUM1 – is the total sum of closing prices for N periods;
SMMA1 – is the smoothed moving average of the first bar;
SMMA (i) – is the smoothed moving average of the current bar (except the first one);
CLOSE (i) – is the current closing price;
N – is the smoothing period.

A lot of source suggested that it is also known as Wilder's Moving Average (example), which we have implementation in LEAN. I've also looked into the calculation of our existing WMA, they looked the same to me.

Is there something wrong with the formula?
You say SUM1=SUM (CLOSE, N), but most probably it should be as SUM1=SUM (CLOSE(1), N), or even better and more clear SUM(i)=SUM (CLOSE(i), N).
So when you define the SMMA (i) = (SUM1 – SMMA1+CLOSE (i))/ N I guess that you need the SUM(i) and not SUM(1)...
What about the SMMA1 – is the smoothed moving average of the first bar;? Really we need the first one? for example for SMMA(3) we need smma of the first bar(what ever "frist bar" means since we have periods) or SMMA(i-1)?
So at the end we have:
SMMA (i) = (SUM(i) – SMMA(i-1)+CLOSE (i))/ N
wdyt? Thanks!

A lot of source suggested that it is also known as Wilder's Moving Average (example), which we have implementation in LEAN. I've also looked into the calculation of our existing WMA, they looked the same to me.

Closing issue as resolved as per LS comment


Bring metric names in compliance with prometheus standards

https://prometheus.io/docs/instrumenting/writing_exporters/#naming

Closing this after merge of #44.


Fixed #27635 -- Used secrets module in django.utils.crypto.

https://code.djangoproject.com/ticket/27635
This is an alternate pull request following on from https://github.com/django/django/pull/11357#issuecomment-492839409.
The first commit fixes the fallback in the absence of a secure pseudo-random number generator and adds a test. The second commit switches over to using the secrets module. And the (optional) third commit drops support for the fallback given that it didn't work before the first commit fixed it anyway. We could remove it as I'm not aware of any complaints that this never worked.

@pope1ni Thanks!


Add #[unsafe_no_drop_flag] to types with a destructor

Blocked by #6.

@michaelwu r?

I guess I should rebase now that #6 has been merged.

tl;dr - Go ahead and rebase.
I've looked at rust drop flag handling a bit today.. and I think this is probably the right thing to do. At the very least, not much worse than before. The tricky thing is that I want to also autogenerate hooks into the C++ destructors, which is a problem due to the possibility of drop being called multiple times. If we can find at least one pointer field in the struct though, we might be able to use that to check for 0x1d to determine whether the C++ destructor should be called. If not, drop has to be implemented manually.

@bors-servo r=michaelwu

Oh silly me… Anyway @michaelwu I rebased it, LGTM!


Invalid "Azure CLI Terms of Use" link

Azure CLI Terms of Use link returns 404: https://aka.ms/AzureCliLegal
Possibly related to https://github.com/Azure/azure-cli/issues/7825

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: fb42002e-9aa3-233d-9832-353235b7cd0f
Version Independent ID: e8b320b1-5805-67ba-46b2-48111861facc
Content: Azure CLI configuration options
Content Source: docs-ref-conceptual/azure-cli-configuration.md
Service: azure-cli
GitHub Login: @dbradish-microsoft
Microsoft Alias: dbradish

Thanks for the feedback! I have assigned the issue to the doc author to update appropriately.

@beatcracker , thank you for bringing this to our attention.  This link is being fixed and will publish on Thursday, May 14th, 2020.


Add compatibility for Mochawesome Report Generator 3.x

To address #7
Need to add Mochawesome Report Generator as a peer dependency

https://github.com/adamgruber/mochawesome-report-generator/blob/3.0.0/CHANGELOG.md

Released v2.0.0 today which supports MARGE 3.x


Fix screens following migration to Bootstrap3

kie-wb-common
(master) http://github.com/droolsjbpm/kie-wb-common/commit/dec71a9c1

Thanks @manstis!


There are a lot of bugs, I have summarized them.

Dear friends，
I found that there are a lot of bugs in your package, I have summarized them as follows:
Firstly, there have been continuous errors in not importing load_default_simulations.
Secondly, the input path for weather data always reports errors, apparently due to setting an absolute path in apsim_file.
Thirdly, apart from your version of code, I always find that the check_completed import is not included in the packages I download on Pypi. It seems that your code has been updated and this part has not been updated in a timely manner.
Anyway, I failed to run the model. Please solve the above problems. Many thanks.
Best,
Zheng

Hi Zheng, could you specify the version or branch on which you experience these errors. Just so that we are able to ensure that the upcoming versions have them resolved.
At this point, this package is still undergoing dramatic changes, I hope you are aware of that.
Thanks
Stephen

Hi Stephen,
Thank you for your reply.
The errors I encountered occurred on version <IP_ADDRESS>. I'm aware that the package is still undergoing significant changes, and I appreciate the team's efforts to improve it.
Please let me know if you need any additional information to assist with resolving these issues in future updates.
Thanks again for your support.
Best regards,
Zheng

Hello Zheng,
We've resolved most of the bugs; however, we haven't identified any issues with the experiment module in its current form. Please try following the example code below and report any problems you encounter. Let us know which version of APSIM and Python you are using.
If you plan to edit the cultivar, first add the replacement module through the GUI, and in that replacement module, specify the target crop you intend to edit.
from pathlib import Path
from experiment_utils import _run_experiment, experiment_runner
from apsimNGpy.experiment.set_ups import define_parameters as define_factor
from set_ups import set_experiment
from apsimNGpy.parallel.process import custom_parallel
from apsimNGpy.experiment.main import Experiment
if __name__ == '__main__':
    path = Path.home().joinpath('scratchT')
    path.mkdir(exist_ok=True)
    from apsimNGpy.core.base_data import load_default_simulations

    # import the model from APSIM.
    # if we simulations_object it,
    # returns a simulation object of apsimNGpy, but we want the path only.
    # model_path = load_default_simulations(crop='maize', simulations_object=False, path=path.parent)
    model_path = load_default_simulations('maize').path

    FactorialExperiment = Experiment(database_name='test.db',
                                     datastorage='test.db',
                                     tag='th', base_file=model_path,
                                     wd=path,
                                     use_thread=True,
                                     skip_completed=True,
                                     verbose=False,
                                     test=False,
                                     n_core=6,
                                     reports={'Report'})

    FactorialExperiment.add_factor(parameter='Carbon', param_values=[1.4,0.2, 0.4, 0.9, 2.4, 0.8], factor_type='soils',
                                   soil_node='Organic')
    FactorialExperiment.add_factor(parameter='FBiom', param_values=[0.045, 1.4, 2.4, 0.8], factor_type='soils',
                                   soil_node='Organic')

    # # cultivar is edited via the replacement module, any simulation file supplied without Replacements appended
    # # to Simulations node, this method will fail quickly
    # FactorialExperiment.add_factor(parameter='grain_filling', param_values=[300, 450, 650, 700, 500], cultivar_name='B_110',
    #                                commands='[Phenology].GrainFilling.Target.FixedValue', factor_type='cultivar')

    FactorialExperiment.clear_data_base()
    # os.remove(FactorialExperiment.datastorage)
    FactorialExperiment.start_experiment()
    sim_data = FactorialExperiment.get_simulated_data()[0]
    mn = sim_data.groupby(['FBiom', 'Carbon'])['Yield'].mean()
    "if we dont see any variationa for each of the factors then it is not working configure again"
    print(mn)
    print(len(FactorialExperiment.factors))


Filters not available in Query Editor

I'm submitting a ...
Question / Support request
For bug report please include this information:

Grafana 3.1.1-1470047149
Zabbix 3.0
zabbix plugin is latest version
Ubuntu 14.04

I am not sure why I am unable to see the filters while building my graphs. Its not clear if it is because of the version of Zabbix I am using or if there might be something misconfigured somewhere.

@joshughes can you reload screenshots?

THis was just a documentation issue... The docs show a filter box that I assume is for an older version. New version you just have to add the regex right into the field.

@joshughes  Where are you looking for the docs? I added getting started guide: http://docs.grafana-zabbix.org/guides/gettingstarted/

I ended up on this page... because I was trying to get some information about templates.
https://github.com/alexanderzobnin/grafana-zabbix/wiki/Usage#templates
On that page there are a few outdated screen shots... When I found my way back to your getting started page... I realized that the screens there were up to date.
Basically I have a need for templates and regex in data sources... so I was going back and forth between those two resources and got a bit confused.

Seems, I need to add deprecation notice to wiki.


feat: Support object soft delete

do not merge until the RestoreObjectRequest changes (remove the Object body) have been published in Google.Apis.Storage.v1.

@jskeet this can now be merged. Last commit are the changes required because of the Discovery based breaking changes. PTAL.


Fix for :freecam locking mouse in the center of the screen due to shift-lock activation

I was recently informed of a bug where if you turn on free-cam while you have shift-lock on, it will lock your mouse to the center of your screen (and it will stay locked until you do the bug again or rejoin).
After fixing this, I also found out that the reverse happens, where shift-lock can be toggled while in free-cam, and if you exit freecam during this, the same issue occurs.
I have thoroughly tested this—no more cursor locks.

Found another issue (ensures camera moves with mouse in freecam without holding right click. Also when it forced you to hold right click, it will break if you release before you toggle off freecam). This has been fixed now.
Tested thoroughly with these changes, I see no more issues.

This is extremely hard to show but you can somewhat see my mouse getting locked prior to the fix (after I disable debugmode)
Before fix (0:23):
https://youtu.be/rKd1Iv1kj28
After fix:
https://youtu.be/65XnvktZOBY

This is extremely hard to show but you can somewhat see my mouse getting locked prior to the fix (after I disable debugmode)
Before fix (0:23): https://youtu.be/rKd1Iv1kj28
After fix: https://youtu.be/65XnvktZOBY

@Dimenpsyonal ^ for PoF, is there anything else needed?


[FEATURE] Entangle pydantic with sqlalchemy

Is your feature request related to a problem? Please describe.
With pydantic v2, we can easily generate pydantic models from sqlalchemy tables, substantially eliminating duplication.
https://docs.pydantic.dev/latest/usage/models/
Let's do that!
Blocked by pydantic v2 transition.

cc #574


Empty constructor with comment inide adds an invalid ,

Expected Behavior
internal class DataSource constructor(
    // pending
)

Should not be reformatted even with ij_kotlin_allow_trailing_comma = true
Observed Behavior
This is the "formatted" source:
internal class CouponEventsNetworkDataSourceImpl constructor(,
    // pending
)

As you can see ktlint adds an incorrect ,.
If I set ij_kotlin_allow_trailing_comma = false this behaviour goes away.
It also complain with this:

/path.kt:3:62: Missing newline after "(" (wrapping)

And that is not true. (this second issue is present on ktlint 1.46.1 too)
Your Environment

Version of ktlint used: 0.47.0
Relevant parts of the .editorconfig settings: ij_kotlin_allow_trailing_comma = true

Duplicate of #1602


minor: release V2.2.0

Codecov Report

Merging #452 (b732b5c) into V2.2.X (42eba5e) will increase coverage by 7.84%.
The diff coverage is 87.90%.

@@            Coverage Diff             @@
##           V2.2.X     #452      +/-   ##
==========================================
+ Coverage   62.47%   70.32%   +7.84%
==========================================
  Files         245      270      +25
  Lines       19901    19705     -196
==========================================
+ Hits        12434    13858    +1424
+ Misses       7467     5847    -1620

Impacted Files
Coverage Δ

apps/backend/agent/signals.py
66.66% <0.00%> (+9.52%)
:arrow_up:

...ckend/components/collections/agent_new/__init__.py
100.00% <ø> (ø)

...ps/backend/periodic_tasks/cache_scope_instances.py
52.17% <0.00%> (-1.68%)
:arrow_down:

...backend/periodic_tasks/collect_auto_trigger_job.py
100.00% <ø> (ø)

apps/backend/urls.py
100.00% <ø> (ø)

apps/backend/views.py
66.06% <ø> (+9.48%)
:arrow_up:

apps/core/concurrent/__init__.py
100.00% <ø> (ø)

apps/core/concurrent/constants.py
100.00% <ø> (ø)

apps/core/concurrent/controller.py
96.66% <ø> (ø)

apps/core/concurrent/lock.py
88.88% <ø> (ø)

... and 194 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee49cd5...b732b5c. Read the comment docs.

趁着这个版本，把copyright中的2021更新到2022


#1555685562 -  write more test to increase  test coverage

What does this PR do?

Write more unit tests to take coverage above 80%

Description of Task to be completed?

Write unit test cover more cases

How should this be manually tested?

Clone and setup this repo locally
Run  npm run test

Any background context you want to provide?

None

What are the relevant pivotal tracker stories?
https://www.pivotaltracker.com/story/show/155585562
Screenshots (if appropriate)
Questions:
N/A

Pull Request Test Coverage Report for Build 47

0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
19 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.8%) to 78.409%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

server/controllers/ideaController.js
0
1
0.0%

Files with Coverage Reduction
New Missed Lines
%

server/controllers/ideaController.js
19
70.1%

Totals

Change from base Build 45:
0.8%

Covered Lines:
257

Relevant Lines:
315

💛  - Coveralls


Add demo example working with server side

Is possible add an example about a variation of the current example but retrieving the data from the server side? It for a more realistic scenario.
Thank you

@manueljordan,
Do you want a RESTful/SOAP/Whatever HTTP API example? It really depends on the programming language you are using on the server-side.

A PHP example would be great also .Thanks

sorry, i can't help for this, can someone help?


For Atom entry add  elements where rel="alternate"

For entry Atom XML, we should add a <link> element with rel="alternate" that links to the HTML version of the entry.
So, in http://example.com/APP/event/c7dc0058-99b9-482e-8f71-1f463d2295a9/ we should have a <link href="http://example.com/event/c7dc0058-99b9-482e-8f71-1f463d2295a9/" rel="alternate"/>.
This should be done at:
/APP/event/<id>/
/APP/agent/<id>/

This is related to unt-libraries/codalib#12 I believe


fix(responsive): layout breakpoint calculation

GitHub Issue (If applicable): #965
PR Type
What kind of change does this PR introduce?

Bugfix

What is the current behavior?
given only {normal, wide, widest} are provided:

What is the new behavior?

PR Checklist
Please check if your PR fulfills the following requirements:

[x] Tested code with current supported SDKs
[ ] Tested the changes where applicable:

[ ] UWP
[ ] WinUI
[ ] iOS
[ ] Android
[ ] WASM
[ ] MacOS

[ ] Updated the documentation as needed:

[ ] General Doc Update
[ ] Controls Doc Update
[ ] Extensions Doc Update
[ ] controls-styles.md
[ ] lightweight-styling.md (LightWeight Styling Resource Keys)

[ ] Runtime Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
[x] Contains NO breaking changes
[x] Associated with an issue (GitHub or internal)
[x] Commits must be following the Conventional Commits specification.

fixme: add tests


Integration with prometheus instance configured to use a basepath

Describe the bug
I configure my custom prometheus path as described in Settings. I have verified this path, and have performed manual GET calls (using curl) on it. All good.
I still see "metrics are not available due to missing or invalid Prometheus configuration".
I suspect the following is the cause:
My cluster has been provisioned with an instance of prometheus whose basepath is /prometheus. As such, GET prometheus:9090 responds with a 302 to location "/prometheus"
To Reproduce
Steps to reproduce the behavior:

Configure prometheus with a basepath of /prometheus
Configure your cluster's custom prometheus path
See error

Expected behavior
Lens should honor 302 response location headers?
Should show me metrics
I'm not sure if Lens provides error logs anywhere. If someone can clarify this for me I can add some logs from the app
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

Lens Version:
OS: [e.g. OSX]
Installation method (e.g. snap or AppImage in Linux):

Logs:
When you run the application executable from command line you will see some logging output. Please paste them here:
Your logs go here...

Kubeconfig:
Quite often the problems are caused by malformed kubeconfig which the application tries to load. Please share your kubeconfig, remember to remove any secret and sensitive information.
your kubeconfig here

Additional context
Add any other context about the problem here.

Prometheus service address should handle base path now.


Feature Suggestion: Can you support self defined note type and multi-fields splits

I've defined my own note type in Anki and the type has more than 2 fields (front and back), let's say 3 with name field1, field2 and field3.
Can you please support parsing according to the number of fields in self defined note type?
I've came up with the following format:
## Card 1 field 1 content line 1

field 1 content line 2

field 1 content line 3

%

field 2 content line 1

field 2 content line 2

...

%

field 3 content line 1

field 3 content line 2

...

---<note type, if not specified, use the default note type in config> // This is a split for cards

## Card 2 field 1 content line 1

field 1 content line 2

field 1 content line 3

%

field 2 content line 1

field 2 content line 2

...

%

field 3 content line 1

field 3 content line 2

...

---<note type> // This is a split for cards

## Card 3 field1 content line 1
...

I would appreciate if you can add this feature, this would helps a lot, so that I can easily switch to my own defined note type and construct self-defined cards with self-defined style.
In the end, thanks for developing this wonderful add-on for anki. It has already speed up my progress of card construction.

Thanks for raising @Lucid-A
It’s something I’ll have to think about, parsing for a specific note type may be out of scope to be honest as it’s very customary.
I’ll see what solutions can be provided though

Thank you for taking consideration about this idea!
Parsing for a user-defined note type maybe too customary, but maybe using a general note type that can be auto generated due to various fileds number, which can be easily converted to user-defined note type can be the solution?


Remap UIDs on image pull/push and pass down UID mapping config down to LXC backend

Can you please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
git commit --amend -s --no-edit && git push -f

Did you have a new PR to replace this one?  Just wondering why you closed it.

@duglin, yes, this needs a little fix.  Will create a new PR.


License radio buttons: revert active links and turn into info icons

Default usability for radio buttons on this page has been overridden (my bad).
Suggested improvement: take the links for each license's info and use an info icon () to open the link instead of the license text.

Done
https://culibrary.atlassian.net/browse/ARXIVNG-990


Update README

The README has various out-of-date references, for example:

BlockStore has been renamed to VolumeSnapshotter
there are various pre-1.0 references that can be removed
we probably want to switch from gcr.io/heptio-images to the DockerHub velero org prefix for image names

Let's get this updated.

Also:

update value for the provider flag on install to include the prefix velero.io/
add info for how to use the plugins flag to add plugins during install.

Change download link to point to: https://velero.io/docs/master/install-overview/#install-the-cli


Cow: Watch carolinaannjohn.com

Cow requests the watch of the watch_keyword carolinaannjohn\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

Approved by Mast in Charcoal HQ

carolinaannjohn\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.


[clkmgr] Correct the disable condition

previously, if RefCnt is set to 1, the disable condition
would basically never be met, and thus once activated, the
measurement could never be properly disabled.

Signed-off-by: Timothy Chen<EMAIL_ADDRESS>

@jeoongp
@jdonjdon
FYI

I will patch this in and try the external clock test.

I will patch this in and try the external clock test.

btw, can you make sure to take the latest push? i just made another fix.


all_device_types_app console issue (CON-1092)

When using the UART0 for console I/O the all_device_types_app works as expected. But when I set the USB/JTAG serial port for the console on a ESP32-C6 Devkit, I get the following output:
I (665) main_task: Calling app_main()
I (685) app_main:

Enter command 'create --device' for a list of available devices
esp32c6>
esp32c6>
esp32c6>
esp32c6> ;R[31R[31;R[31R[31;R[31R
Unrecognized command
esp32c6> R[31;0
Unrecognized command
esp32c6>
esp32c6>
esp32c6> ;R[31;0
Unrecognized command
esp32c6>
esp32c6>
esp32c6>
esp32c6> 31;0
Unrecognized command
esp32c6>
esp32c6>
esp32c6>
esp32c6> [31R
Unrecognized command
Writing to serial is timing out. Please make sure that your application supports an interactive console and that you have picked the correct console for serial communication.
Writing to serial is timing out. Please make sure that your application supports an interactive console and that you have picked the correct console for serial communication.
Writing to serial is timing out. Please make sure that your application supports an interactive console and that you have picked the correct console for serial communication.

When I comment out example::console::init(); in app_main.cpp but still leave CONFIG_ENABLE_CHIP_SHELL=y then I get proper log messages of the Matter stack and a prompt shows up where I can enter Matter and Wifi commands without any issues.
Is there anything that needs to be configured in static void initialize_console(void) in esp_matter_console_helpers.cpp to make the console work over the USB/JTAG serial for selecting a device type?
Environment

ESP-Matter Commit Id: 8bd97db
ESP-IDF Commit Id: v5.1.2
SoC (eg: ESP32 or ESP32-C3): ESP32-C6 DevkitM-1
Host Machine OS: MacOS

Try a different terminal program, these ";R[31R[31;R[31R[31;R[31R" are responses to escape sequence queries from the terminal.

Did you use the UART or USB port on C6?
If you used the USB port then you need to enable CONFIG_ESP_CONSOLE_USB_SERIAL_JTAG config option.

@shubhamdp CONFIG_ESP_CONSOLE_USB_SERIAL_JTAG  is enabled, and as mentioned, the log output and the chip-shell commands work as expected when using the USB port. The issue is related to the console that is added in esp_matter_console_helpers.cpp

I built light with CONFIG_ESP_CONSOLE_USB_SERIAL_JTAG=y and I was able to use the console. Is this still an issue, if yes, can you please share the sdkconfig.

@sdrasti Please provide the requested details. Or close the issue if resolved

@shubhamdp @dhrishi
With the light example app running on a ESP-C6 I got the Matter Console also working along with the logging console without any issues. It seemed to me, as if the the problem was linked to the code in esp_matter_console_helpers.cpp (that adds additional commands to the matter console for choosing a device types) of the all_device_types_app. Anyhow, I haven't tried to track down the issue any further, so I would close this issue then.

@shubhamdp @dhrishi
With the light example app running on a ESP-C6 I got the Matter Console also working along with the logging console without any issues. It seemed to me, as if the the problem was linked to the code in esp_matter_console_helpers.cpp (that adds additional commands to the matter console for choosing a device types) of the all_device_types_app. Anyhow, I haven't tried to track down the issue any further, so I would close this issue then.


[FR] Compatibility with Tasks plugin 📅 date format, change date on rollover

I'm using this in conjunction with the Tasks  plugin. I always make sure to set a date on any task in a daily note, so that any task that hasn't been rolled over can be surfaced as overdue, but also to list upcoming tasks etc.
When rolling over tasks in a daily note that is formatted with date, the date isn't changed and as such will appear wrong if queried. In my case I pull in tasks using Tasks plugin from other notes with this date, and a such a rolled over task with date formatting will still appear in the daily note, even if it now lives in the daily note it rolled over to.
My request is therefore if it would be possible to look for 📅 YYYY-MM-DD in a task when rolling over, and if found, change it to the date that the daily note has which it is rolling over into.
Thanks for a great plugin!

Hi @Zebrazilla, thank you for your FR.
I don't think this is a good idea as it leads to strange behaviour. I use the Tasks plugin as well and I e.g. use the daily note to collect ToDos that might be in the future. So if the plugin starts to manipulate the information contained in the ToDo the risk of loosing important information is too high. For that reason, we will never manipulate the content of the ToDo.


Redisson connections release while command execution attempt failed

We faced an issue in following Azure Redis Cluster configuration:

master1 <-> slave1
master2 <-> slave2

Version of Redisson 3.15.4, Redis 4.0.14
Configuration:
clusterServersConfig:
idleConnectionTimeout: 10000
connectTimeout: 15000
timeout: 3000
retryAttempts: 3
retryInterval: 1500
failedSlaveReconnectionInterval: 3000
failedSlaveCheckInterval: 60000
subscriptionsPerConnection: 5
clientName: null
subscriptionConnectionMinimumIdleSize: 1
subscriptionConnectionPoolSize: 50
slaveConnectionMinimumIdleSize: 24
slaveConnectionPoolSize: 64
masterConnectionMinimumIdleSize: 24
masterConnectionPoolSize: 64
readMode: "MASTER"
subscriptionMode: "MASTER"
nodeAddresses:
- "rediss://...."
threads: 16
nettyThreads: 32
codec: !<org.redisson.codec.FstCodec> {}
transportMode: "NIO"
After few restarts of Redis we see following errors all the time:
org.redisson.client.RedisTimeoutException: Unable to acquire connection! RedissonPromise [promise=ImmediateEventExecutor$ImmediatePromise@5123a990(failure: java.util.concurrent.CancellationException)]Increase connection pool size. Node source: NodeSource [slot=8616, addr=null, redisClient=null, redirect=null, entry=null], command: (BLPOP), params: [{job-scheduler-executor:org.redisson.executor.RemoteExecutorService}, 0] after 0 retry attempts","2":"at org.redisson.command.RedisExecutor$2.run(RedisExecutor.java:187)","3":"at io.netty.util.HashedWheelTimer$HashedWheelTimeout.expire(HashedWheelTimer.java:672)","4":"at io.netty.util.HashedWheelTimer$HashedWheelBucket.expireTimeouts(HashedWheelTimer.java:747)","5":"at io.netty.util.HashedWheelTimer$Worker.run(HashedWheelTimer.java:472)","6":"at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)","7":"at java.base/java.lang.Thread.run(Unknown Source)\n"}}
And we have a question:

When RedisExecutor executes its command and retryTimeout happened then:
1.1. Error message is assigning to exception variable
1.2. Then attemptPromise is cancelling
1.3. Then attemptPromise.onComplete happens which calls releaseConnection
1.4. There is a code

which do not release connection if connectionFuture.isSuccess() == false (and this condition always met in case of timeout or I am wrong?).
And looks like that its never releases this connection and free connection counter semaphore is not releasing at all here.
Is it expected behavior? Should we always have connectTimeout less than retryInterval?
And in case when 2nd attempt fails too, we still see in the logs "after 0 retry attempts" because we already have "exception" variable set on previous step.

which do not release connection if connectionFuture.isSuccess() == false (and this condition always met in case of timeout or I am wrong?).

Connection isn't released if it wasn't acquired.

And looks like that its never releases this connection and free connection counter semaphore is not releasing at all here.
Is it expected behavior?

If connectionFuture was canceled then it's released at ConnectionPool line 245.

Should we always have connectTimeout less than retryInterval?

Redisson doesn't connect each time since connections are pooled.

Connection isn't released if it wasn't acquired.
If connectionFuture was canceled then it's released at ConnectionPool line 245.

ConnectionPool:245 calls .remove method which adds listener to removedListeners in Semaphore but who will increment counter in Semaphore in this case? What if we already acquired all connections and counter is 0?
Here is the link to the logs where we always have failure while commands sent to 2nd master node of redis (<IP_ADDRESS>:15002 myself,master - 0<PHONE_NUMBER>000 19 connected 8192-16383):
logfile
It's not from the beginning but we were not able to collect it from beginning due to rolling logs. And it's reproducing pretty rare after restarts of some nodes (we saw that 2nd master and it's slave was restarted few times before this starting happen)
Additionally, there we always see "RedisTimeoutException:CancellationException Unable to acquire connection .... after 0 retry attempts" and at the same time for the same command we see lines like "attempt 2 for command (BLPOP) and params", "attempt 3 for command (BLPOP) and params" (we have configuration with max 3 attempts).
Restart of an application resolves the problem
Could you please take a look?

I fixed AsyncSemaphore race condition which may cause this issue. https://github.com/redisson/redisson/commit/34d2e4de3a8b6cc9170fe7b5d82d40498fe60f1e

I'm closing this. Let me know if you reproduce it with 3.16.1+ version.

Tried to reproduce on 3.16.1 but wasn't able anymore. Looks like that it's working


DataMigration version matters

[Our customers faced strange behaviours during the data migration when they've used OLD version of the tool. Problem was related with problem of moving (webformstep metadata).
Will be good to add in Note section something like : "it is recommended to use latest version of DataMigration tool. For information on downloading the Configuration Migration tool, see Download tools from NuGet."]
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ed7fa454-57bc-86bf-74cd-c51b622607a4
Version Independent ID: 3efa0e3c-d9f2-cc50-aa9d-f77f2ca7dc3f
Content: Migrate portal configuration - Power Apps
Content Source: powerapps-docs/maker/portals/admin/migrate-portal-configuration.md
Service: powerapps
GitHub Login: @neerajnandwana-msft
Microsoft Alias: nenandw

Thank you for reaching out. Documentation has been updated.


Feature add - Find match count (issue #4805)

Hi all!
This is my first contribution to the project (and first time looking at this codebase)–so I apologize ahead of time if I have missed anything obvious. What I've done here is try to implement a simple match count for the find bar.
Please let me know if there's something I have misplaced or just done wrong. I'm open to feedback and look forward to contributing more to this project.

Any progress on this?  I'm glad there has been others interested in a such a simple but extremely useful piece of information about a document.

Applied this patch manually for some older version.
Works for me. Thank you!

@andyparisi Could you rebase your branch I think this is good to go.

To make this perform better, we should probably do what the native find bar does in Firefox and stop counting matches above some reasonable threshold. In Firefox, the default value is 100.

The calculation of the number of matches shouldn't be an issue here, but yes we should probably limit matches somewhere else in the code. This can be in a different PR though.

Merged by c2e70ea7268222ffc48039f6c613269ee0e3f6d4
Thank you for the patch


[Code health] Cleanup survey activation

Towards https://github.com/google/ground-android/issues/1490

LocalValueStore already sets the last active survey id during init. So, there is no need to explicitly invoke survey activation in HomeScreenFragment anymore.

Verified by running the app locally with app data cleaned.
@gino-m  PTAL?

Codecov Report

Merging #1503 (d8a41e2) into master (6772772) will increase coverage by 0.60%.
The diff coverage is n/a.

:exclamation: Current head d8a41e2 differs from pull request most recent head 9390240.  Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

"Survey activation" in terms of code refers to activeSurveyIdFlowable returning the last survey_id value (in case of first load) and latest value (whenever survey gets switched).
Since the underlying implementation of this flowable is BehaviorProcessor, it automatically replays the last value when subscribed


Clarify writing in 'Declarations' section

This series replaces 'later' with 'to the right of', mentions "indenting or positioning" for clarity, and corrects the name of the evaluate function in the "bad" example to match the function name in the "good" example.

My local branch name should be 703-declarations-case, but I'll leave it as-is.
This branch addresses #703 .

@etiennesegonzac I humbly request a quick review and merge of this documentation change to style-guide. Thanks for all things Elm!


505: fail with message when webhook not enabled and minReplicas is nil

We have two methods to avoid the nil pointer exception.
Method 1 is to provide a default value for the possible nil fields just like in the admission webhook. However adding default value in the code could potentially make it harder to find where the config value comes from when debugging. And it also require us to change two places if we were to change the default value logic.
Method 2 is simple: fail early but with hint messages on what caused the issue and how to resolve the issue. It guides the user to use a newer version of function-mesh with webhooks enabled.
Fixes #505
fix #505

@imaffe do we need to update the docs for this PR? Thanks

I think we can put the logic to determine if spec.minReplicas is nil at the beginning of the reconciliation

close by https://github.com/streamnative/function-mesh/pull/582


ablog: move to by-name, fix build and update

Description of changes
ZHF #312250

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 312250 run on x86_64-linux 1

2 packages built:

ablog
ablog.dist

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3963


Added Sparkle

Checklist

[x] I made something good today 💐.
[x] I put links in the correct format: [Tool](link) — description.
[x] My description starts with the lower-case letter and ends with the full stop.
[x] I put the tool in the alphabetical order.

Optional

[x] I added the appropriate labels: free, open-source or mac.
[x] I put the tool only to one category.
[x] I followed Contribution Guidelines.

@duncanwilcox, Sparkle is a great tool. Thanks for adding it :)


[QUESTION] Risk Scoring Module Errors

I occasionally get the following error from the Risk Scoring Module. I'm curious if you think it's my logic app(s) or is there an actual bug? I really notice it on a Defender for Cloud Incident with the title of "Traffic detected from IP addresses recommended for blocking"
Thoughts?
{
  "error": {
    "code": "BadRequest",
    "message": "Http request failed: the server did not respond within the timeout limit. Please see logic app limits at https://aka.ms/logic-apps-limits-and-config#http-limits."
  }
}

@mikedizzle if you look at the Calculate-RiskScore logic apps run history, is it occasionally taking more than 2 minutes to complete?  The Logic Apps customer connector seems to have issues when the module takes more than 2 minutes to execute.
If that is the case there's 2 potential workarounds for the issue.
If you are sending more than 20 inputs to the scoring module, which is unlikely but possible, you may want to edit the Calculate-RiskScore logic app and inside the logic app locate the 'For each' step.  On that steps context menu, click Settings.  Then, set concurrency control to on and increase the degree of parallelism to 50.  Click done and then save the logic app.  This should result in the logic app running faster.
If you are sending less than 20 items to the risk scoring logic app but still exceeding the the 2 minutes there are 2 options:
Consider changing the scoreperitem to no on some of the input data.  This will impact the score (see the docs on the scoring module), but it will speed up processing.
The other options is to call the Calculate-RiskScore module through the Logic Apps connector (instead of the STAT connector).  When calling through the Logic Apps connector, it will support async processing which will allow the caller to wait longer than 2 minutes for the response.

Thanks for these suggestions. I'll try them out.