Suggested Celestia Client Architecture

This issue is a writeup of how to build a Celestia client that will act as the underlying DA client for rollups clients to verify. Once consensus is reached, this can be formalized with a document on the specs
One thing to note is that Celestia is an SDK chain running CometBFT consensus. Thus we can reuse the tendermint client for most of the client logic.
However Celestia has some important key modifications it needs to make.
The first is that rollup block data (header + txs) are committed to in the DataHash of the CometBFT header. In the 07-tendermint client, we discard this information when compressing the header down to a consensus state. However, it is necessary that we add the DataHash to the consensus state for DA verification.
*Note theoretically, one could add this as metadata in the client store, thus outside the consensus state itself. But I find that to be a bit hacky and not in keeping with the client and proof semantics.
The second thing we will need to do is to allow different types of proofs to be handled by the Celestia light client VerifyMembership and VerifyNonMembership methods.
Of course we will want to continue supporting standard proofs against the app hash, but in order for the celestia light client to serve as DA verification for rollup clients, it will also need to support inclusion proofs against the data hash stored in the consensus state.
The proposal here would be to unmarshal the proof []byte sent to VerifyMembership into a specific type:
type CelestiaProof struct {
    ProofType enum
    Proof []byte
}

The ProofType enum will select one of a specific set of supported proof types (e.g. AppHashInclusionProof, DataHashInclusionProof, DataHashBlockDataProof)
Based on the prooftype specified, the VerifyMembership unmarshals the underlying proof accordingly and executes proof-specific verification logic.
*Note there are multiple types of proofs that can be verified against the data hash. So we should support those at separate enums.
IMPORTANT: The caller that wishes to do the verification should be the one to set the ProofType enum and wrap provided proof in a CelestiaProof. Do not allow relayers or untrusted users to set the enum themselves as this could be a potential attack vector
Discussion with @nashqueue needed to understand which proof types will need to be supported.
TLDR;
Changes to Tendermint Client needed:

Add data hash to ConsensusState on UpdateClient
Support multiple proof types and verification logic in VerifyMembership endpoint

Importing this implementation should capture all cases https://github.com/celestiaorg/nmt/blob/master/proof.go

Importing this implementation should capture all cases https://github.com/celestiaorg/nmt/blob/master/proof.go

I'm curious if we should be rather using ShareProof or if the raw nmt proof is the desired option?

Yes that would make sense. The proof verification would live in the nmt.

Hey @nashqueue, I've looked into duplicating the 07-tendermint and modifying some parts to create a celestia (da client) which rollkit clients written as wasm contracts will call back to.
In order to get the code together, we'll likely need to iron some dependency issues which I'll mention below.
Firstly, I'll give an outline below of the changes that we discussed would be required and a rough idea of what I had in mind.

Extend the ConsensusState to include the DataHash, i.e. the data availability root

message ConsensusState {
  option (gogoproto.goproto_getters) = false;

  // timestamp that corresponds to the block height in which the ConsensusState
  // was stored.
  google.protobuf.Timestamp timestamp = 1 [(gogoproto.nullable) = false, (gogoproto.stdtime) = true];
  // commitment root (i.e app hash)
  ibc.core.commitment.v1.MerkleRoot root = 2 [(gogoproto.nullable) = false];
  // hash of next validator set
  bytes next_validators_hash = 3 [(gogoproto.casttype) = "github.com/cometbft/cometbft/libs/bytes.HexBytes"];
+ // commitment data availability root (i.e data hash)
+ ibc.core.commitment.v1.MerkleRoot data_availability_root = 4 [(gogoproto.nullable) = false];
}

Adding this is pretty straight forward and on client updates we can easily add the DataHash here (ref):
consensusState := &ConsensusState{
	Timestamp:            header.GetTime(),
	Root:                 commitmenttypes.NewMerkleRoot(header.Header.GetAppHash()),
	NextValidatorsHash:   header.Header.NextValidatorsHash,
+       DataAvailabilityRoot: header.Header.GetDataHash(),
}

Add a new Proof type for celestia clients which can support one of multiple proof types. This allows the celestia client to be used synonymously to how the 07-tendermint client already works today, but additionally would support the ShareProof type against the DataAvailabilityRoot, for rollkit clients to prove inclusion of blob data in the square.

We can use a protobuf oneof type to support both the ShareProof and MerkleProof (23-commitment). Regular merkle proofs will prove application state against the AppHash, whereas the share proofs will prove against the DataHash.
// Proof defines a message type which encapsulates a proof operation.
message Proof {
    oneof op {
        // ics23 based merkle proof used for celestia application state
        ibc.core.commitment.v1.MerkleProof app_proof = 1 [(gogoproto.nullable) = false];
        // celestia share proof used for celestia data availability layer
        celestia.core.v1.proof.ShareProof data_availability_proof = 2 [(gogoproto.nullable) = false];
    }
}

We would then modify the VerifyMembership methods of the lightclient to support unmarshalling proof []byte to this type. I imagine it would look something like this, type switching on the proof:
var proof types.Proof
if err := cdc.Unmarshal(proofBz, proof); err != nil {
   return errorsmod.Wrap(commitmenttypes.ErrInvalidProof, "failed to unmarshal proof into celestia proof type")
}

switch p := proof.Op.(type) {
case *celestia.ShareProof:
    shareProof := p.DataAvailabilityProof
    return shareProof.Validate(consensusState.GetDataAvailabilityRoot())
case *commitmenttypes.MerkleProof:
    merkleProof := p.AppProof
    return merkleProof.VerifyMembership(cs.ProofSpecs, consensusState.GetRoot(), merklePath, value)
}

Regarding the dependency issues I mentioned at the start of the comment. Essentially, at the moment it's hard to plug celestia.core.v1.proof.ShareProof directly in here. There seems to exist two different ShareProof types which I've found.
One maintained in celestia-core and one maintained in celestia-app. Note, the typeURL I used previously is that of the one maintained in celestia-app.

https://github.com/celestiaorg/celestia-app/blob/main/pkg/proof/proof.pb.go#L266
https://github.com/celestiaorg/celestia-core/blob/main/proto/tendermint/types/types.pb.go#L1508

I think it may be problematic to consume protos from celestia-core due to the cometbft fork. It seems the raw Go type ShareProof is created by converting the protobuf type and this is what we need to call Validate(dataHash) on.
If we are going to import any of these protobuf messages we would need them to be published to BSR (buf schema registry) which atm, I don't think they are, but its fairly trivial to set it up. Would be happy to create an issue if needs be or help out.
If we will use the ShareProof maintained in celestia-app, then we may need to potentially move some code around to be able to convert and call the appropriate Validate() method. Happy to discuss this stuff synchronously tomorrow also!

If we use the same client for app hash proofs and data hash proofs, then we will need to also have the custom self-client validation in. Because we will also need to validate self consensus state with the added datahash.
Arguably, might make sense to have a standard TM client for connection Celestia app to other chains. But have the custom Celestia DA client as a dependency for rollup clients

Agree! Simplifying it to only use as a DA client for rollup clients is probably the way to go. We can just remove the protobuf oneof type and unmarshal only ShareProofs in VerifyMembership to use with the DataHash. Connections between celestia-app and other chains can continue to use regular 07-tendermint clients.


'train_names.txt'   what it is?

After i run pre_process.py successfully, i run train.py but failed. The error shows me that 'FileNotFoundError: [Errno 2] No such file or directory: 'train_names.txt''. i have no this file. What's worse, i do not know anything about this file 'train_names.txt'. What should i do?

After runing data_gen.py , you can get that

Right.


Moved the signal to its own file to avoid import errors. Fixes #158

I tried to add tests but seems you can only tests signals using Mock.
Please let me know if anything else is needed.

Just a minor nit for the docs, then this is good to go 👍 Thank you for working on this, @camilonova! 🌞

@jezdez Thank you for the patience 🌴


Image Caching & Placeholder Image

Hi,
I m just facing an issue with Image Caching. When the activity is launched, there is a flickr among the banner images in Slider View. Also the placeholder image is not staying there if the image is not loaded from the URL.
Please help me out.
Thanks

use this after (.image)
.imagePlaceHolder(R.drawable.placeholder_image)


16bit PNG images from Inkscape are encoded wrongly

Describe the bug
16-bit RGB/RGBA images from inkscape are encoded without error, but incorrectly, in both VarDCT and modular modes
To Reproduce
cjxl 16bit_rgba.png 16bit_rgba.jxl
djxl 16bit_rgba.jxl preview.png

Expected:

Encoded and then decoded 16bit_rgb.png:

Encoded and then decoded 16bit_rgba.png:

Sources (8bit_rgb.png 16bit_rgb.png 16bit_rgba.png source.svg):
sources.zip
Environment

OS: Linux
Compiler version: clang version 15.0.6
CPU type: x86_64
cjxl/djxl version string: cjxl v0.9.0 6b1e5b0 [AVX2,SSE4,SSSE3,SSE2]
inkscape version:  Inkscape 1.2.2

Additional context
Related: https://old.reddit.com/r/jpegxl/comments/1328u57/a_particular_png_file_couldnt_be_converted/
imagemagick's identify -verbose 16bit_rgba.png  output contains
  Depth: 16/8-bit
  Channel depth:
    red: 8-bit
    green: 8-bit
    blue: 8-bit
    alpha: 1-bit

Looks like cjxl isn't properly handling the sBIT chunk when it reads PNGs.
In these 16-bit images, sBIT is indicating that the image was resampled from 8 bits, and cjxl is detecting that and creating an 8-bit JXL, but apparently not scaling the samples correctly(?)
dec/apng.cc:709
If I strip out the sBIT chunk, cjxl produces a correct 16-bit JXL.

If I may comment here, my understanding of sBIT is it is a special-purpose chunk that is not expected to be read by decoders unless they have a particular reason to do so.
Here is an 8-bit grayscale png consisting of four colours: 0xFF, 0xF0, 0x00, 0x0F. The sBIT is set to 4. If decoders strictly adhered to the sBIT you would only see black and white, but instead you can see all four different shades:

Ignoring sBIT would be valid, but I think cjxl has a good reason to interpret it (more so than a browser or image viewer). It's essentially signalling that the image would have used fewer bits if PNG supported it, and that the correct way to losslessly decode the original is to discard the "filler". By reading sBIT, cjxl can preserve the real bit depth and avoid wasting bytes on the insignificant bits (which I guess will typically contain some kind of dithering pattern that won't compress particularly well).


Add the Utility pallet

This will be useful to batch transactions, for example to create a collection, set the metadata and lock it.

Closed by #4


Make Tutorial how to mint from Mobile wallet on KodaDot

We would like to show people how to mint on KodaDot straight from mobile
Best if you are English native speaker with good accent and amazing studio mic, tutorial should be in ENGLISH
Tutorial should have this steps

[ ] brief introduction -- onboarding voice video
[ ] setup wallet for first timers
[ ] how to mint your stuff from mobile, use simple mint probably
[ ] collect stuff
[ ] show screens like spotlight and series

Once Xylo does the V3 redesign, i'll jump on this.

Once Xylo does the V3 redesign, i'll jump on this.

We have already v4

👋

👋

👋


Document form component validation error messages

What is the context of this PR?
Updated the following components and patterns to include error validation documentation and examples:
Components

Access codes

Also renamed 'uac' pattern folders to 'access-code' *** BREAKING CHANGE ***

Checkboxes

Also updated all examples to be more realistic use cases and use legendIsPageTitle

Dates
Durations
Input

Also changed prefix/suffix background colour to match secondary buttons
Also updated width-constrained examples to use correct number classes

Mutually exclusive
Radios
Select
Summary
Textarea
Upload

Patterns

Dates
Download resources
Durations

Also removed unnecessary time example

Email addresses
Feedback
Find a support centre
Numeric values
Send a web form

Also fixed any typos in the content, and adjusted heading levels for consistency across similar templates.
How to review

Check all examples and error documentation for all the patterns and components listed above.
Check there are no issues with access codes after the folder name change

 Issue #1569: Upload component doesn't call onsField or onsFieldset so in turn, doesn't call onsError, so the validation pattern can't be used with it.

Ive noticed that all the error examples have the pattern error example then sample error messages, except for access codes. Maybe we should reverse this on access codes so it fits in with the rest. Also there is no error examples for the experimental patterns ("Find a support centre" and "Download resources")

I think it's better to show the example first, but some examples where it's a full page, I think are too long, so you'd miss the content.  This is why I flipped the order of these examples.

Ive noticed that all the error examples have the pattern error example then sample error messages, except for access codes. Maybe we should reverse this on access codes so it fits in with the rest. Also there is no error examples for the experimental patterns ("Find a support centre" and "Download resources")

I think it's better to show the example first, but some examples where it's a full page, I think are too long, so you'd miss the content. This is why I flipped the order of these examples.

Do we still not want examples for "Find a support centre" and "Download resources" though?

Ive noticed that all the error examples have the pattern error example then sample error messages, except for access codes. Maybe we should reverse this on access codes so it fits in with the rest. Also there is no error examples for the experimental patterns ("Find a support centre" and "Download resources")

I think it's better to show the example first, but some examples where it's a full page, I think are too long, so you'd miss the content. This is why I flipped the order of these examples.

Do we still not want examples for "Find a support centre" and "Download resources" though?

Yeah I'll add those now.


blender 4.2 cannot export shapekey with amature

Describe the bug
Cannot export shapekey with Amature
To Reproduce
Steps to reproduce the behavior:
Add a Cube
Set some shape keys
Add a Amature
Attach the Cube to Amature
Export to gltf
import the gltf file, the cube does not have any shape keys
Expected behavior
shapekey can be exported in 4.1.1
Screenshots
the cube with shape key and amature

modifier

gltf export settings

import glft file

Version

OS: Win10 19045.4651
Blender Version 4.2

Hello,
No bug here, and no change in behavior since 4.1
As described in tooltip, applying modifiers prevent exporting shapekeys, because of limitation in Blender api bpy.
Closing this ticket

Hello, No bug here, and no change in behavior since 4.1 As described in tooltip, applying modifiers prevent exporting shapekeys, because of limitation in Blender api bpy. Closing this ticket

The only modifier is amature. There's no other modifier. In 4.1(and 3.6.8, 2.93), shapekeys can be exported with amature.

Sorry, my bad.
I can reproduce now


Does this work on Android?

I didn't see anything mentioned in the docs or whatever...but would it just show iOS emojis or is there a different set for Android?

@timothyerwin I did not test w/ android but it should just "work". Curious to hear your experience.

It's working nicely, I'm using it in my android app!
Demo.png

@jamesloper did u encounter any textinput padding issue? Also the Smileys & Emoticon 's y is truncated.
Android it loads noticeably slow, did u do any extra performance improvement work?


Fix Documentation CI task

Currently the Documentation CI task takes a while because it builds all the vcpkg dependencies unnecessarily. Fixing this will make the steps below faster.

Forgot to include: we should also review Doxygen log and fix problems it reports.
Additionally, we should change CI Documentation task to fail on Doxygen errors so that we avoid them going forward.

I wanted to mention a cool feature while I'm thinking about it, because I almost forgot about it myself. We have the ability to pull examples from tests and include them in the generated docs. Which is pretty nice because it allows us to make sure the examples compile and even function correctly. See the docs for the Plane constructors for an example:
https://cesium.com/learn/cesium-native/ref-doc/classCesiumGeometry_1_1Plane.html#a80cb61ea891fe39d6468eca8dbb67291

Split off fixing issues in the Doxygen log into issue #1010 to better keep track.

Fixed in #1011.


Create images on instance precreate and pick credentials.

Do not do a mapping of images to hostmaps. Still validate instance uuid in ExternalTemplateInstanceFilter.

LGTM

not LGTM, need to review further.

This needs more tests or please point me to existing test that ensure that this functionality still works.

Start a container.  Image is created, the correct registryCredentialId gets assigned to the instance
Start a container from native docker. Image is created, the correct registryCredentialId gets assigned to the container
Start a container from a service: Image is created, the correct registryCredentialId gets assigned to the container

Also rebase

This is a blocker issue.  Please prioritize this bug.

Service Discovery tests look good, so LGTM

@ibuildthecloud LGTU?

On Google Groups, someone has indicated that things error out with Auth Required even though auth has not changed since the last successful container deployment.  Can you make sure this is not an issue with this PR?

Couple random comments.

ImageDaoImpl can be removed by just creating a new method on GenericResourceDAO for createAndSchedule that takes just an object.
All tests use "sim:" images.  This isn't needed anymore for the simulator.  Can you switch to "docker:"
I'm guessing the sim imageregcredlookup class doesn't need to exist.


Move C++ library source out of aspnet/SignalR

Is there a way to link to all the source code from libraries that the C++ client uses?

Or at least start with moving the gtest source out of our repo

I 10000% agree

Even submodules would be a step in the right direction :). Or having the build script download the gtest sources (only when it knows for sure it's going to run the tests)

Propose for 2.2.0-mq


workflows/check-by-name: print failed command output

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Oh I was surprised to not get requested as a reviewer automatically, but I figured it out :sweat_smile: https://github.com/NixOS/nixpkgs/pull/261698

Although, I think if it printed anything we should've seen it already..

This should be fully fixed with https://github.com/NixOS/nixpkgs/pull/261741

Btw here's a workflow run where we can see the effect of this PR, but as I suspected no extra information is printed by the git ls-remote: https://github.com/NixOS/nixpkgs/actions/runs/6558134544/job/17811091261#step:2:17
Anyways, I merged https://github.com/NixOS/nixpkgs/pull/261741, so this should be fixed now.

@Artturin where is the "escape hatch" from these tests, like you asked for in https://github.com/NixOS/nixpkgs/pull/263082#issuecomment-1776685453 ?
I'm very disturbed by the fact that, contrary to discussion, these checks have been designed so that if there is a bug in the tests you can't fix the test within the same PR that it's obstructing.  You have to file a separate PR to fix the test and then wait for Hydra to advance the channel before you can resume work on the obstructed PR.  The by-name checks are even foolishly using include_str!("eval.nix") to further ossify the whole mess.
This is absurd.
This is precisely the problem with ofborg being out-of-tree, and we're making it worse.
This is not what was agreed to.
Right now the only way to fix broken tests is to simply disable the github action.  As it stands that is precisely what I will do if I have a PR that gets blocked by malfunctioning tests.

@Artturin where is the "escape hatch" from these tests, like you asked for in #263082 (comment) (and I added in bde78f5)

The currently unfixable (or very difficult to fix) splicing issues are not the same as a fixable test

I'm very disturbed by the fact that, contrary to discussion, these checks have been designed so that if there is a bug in the tests you can't fix the test within the same PR that it's obstructing. You have to file a separate PR to fix the test and then wait for Hydra to advance the channel before you can resume work on the obstructed PR. The by-name checks are even foolishly using include_str!("eval.nix") to further ossify the whole mess.

Relevant issue https://github.com/NixOS/nixpkgs/issues/256788
Architecture team is available at the architecture team room

@Artturin where is the "escape hatch" from these tests, like you asked for in #263082 (comment) (and I added in bde78f5)

The currently unfixable (or very difficult to fix) splicing issues are not the same as a fixable test

I'm very disturbed by the fact that, contrary to discussion, these checks have been designed so that if there is a bug in the tests you can't fix the test within the same PR that it's obstructing. You have to file a separate PR to fix the test and then wait for Hydra to advance the channel before you can resume work on the obstructed PR. The by-name checks are even foolishly using include_str!("eval.nix") to further ossify the whole mess.

Relevant issue https://github.com/NixOS/nixpkgs/issues/256788
Architecture team is available at the architecture team room

@amjoseph-nixpkgs I have no idea how the splicing relates to this PR here, they seem totally unrelated.
And the supposed issue with the by-name check I'm already discussing with you in https://github.com/NixOS/nixpkgs/pull/252057 (which would probably better in a separate issue), it's totally unrelated to this PR here too. And the include_str! problem is also unrelated, and it's already tracked in https://github.com/NixOS/nixpkgs/issues/257748.
And if you think the above issues aren't tracked appropriately, please open a new one and ping me.

I have no idea how the splicing relates to this PR here

Nor do I.  My comment was about the need for an escape hatch from malfunctioning checks.

I have no idea how the splicing relates to this PR here

Nor do I. My comment was about the need for an escape hatch from malfunctioning checks.

The splicing check test isn't malfunctioning.

I have no idea how the splicing relates to this PR here

Nor do I. My comment was about the need for an escape hatch from malfunctioning checks.

The splicing check test isn't malfunctioning.

Alright, malfunctioning or counterproductive checks then.


about question 18

Is "diagonal" not a line in two ways in a rectangle? One way is from left top to right down. Another way is from right top to left down. Or I understand the diagonal in matrix wrongly.. Then just ignore this issue.
If my guess is right, i would give a suggestion for an answer (using clumsy indexing way, not so clever):
z = np.zeros((5, 5), int)
z[1, 0], z[1, -1] = 1, 1
z[2, 1], z[2, -2] = 2, 2
z[3, 2], z[3, -3] = 3, 3
z[4, 3], z[4, -4] = 4, 4
print(z)

output is:
[[0 0 0 0 0]
 [1 0 0 0 1]
 [0 2 0 2 0]
 [0 0 3 0 0]
 [0 4 0 4 0]]

For matrix, it is usually the diagonal of the identity matrix.


Unrecognized font family

Getting error Unrecognized font family 'Museo Sans 500' in iOS simulator only. App works fine on android emulator.
Environment
Environment:
OS: macOS High Sierra 10.13.3
Node: 9.3.0
Yarn: Not Found
npm: 5.7.1
Watchman: 4.9.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4443003
Packages: (wanted => installed)
react: 16.2.0 => 16.2.0
react-native: 0.53.2 => 0.53.2
Expected Behavior
App should properly open the app.
Actual Behavior
getting red screen.

Steps to Reproduce

Downloaded "Museo Sans 500.ttf" and add in the folder /assets/fonts/
Add "rnpm": {
"assets": [
"./assets/fonts/"
]
} in package.json
Run the command below in terminal:
react-native link
react-native run-ios throws error.

Looks to me that you are missing the native side step of adding it to the Info.plist: https://medium.com/react-native-training/react-native-custom-fonts-ccc9aacf9e5e
If following the linked guide fixes the issue for you, please close it afterwards.

The third step in the above mentioned steps adds the font in info.plist.
Extract from my info.plist
<key>UIAppFonts</key> 	<array> 		<string>Museo Sans 500.ttf</string> 	</array>
Still getting the same issue.

Ok, then I suggest you double check in the Font Book that the name is the right one; there are instances when the name of a font is not the same in Android & iOS (ex. MuseoSans500 vs Museo Sans 500). Double check in XCode too.

I checked in the Xcode and also in the Font Book. It says 'Museo Sans 500' as shown below:
Also, I did 'Erase all Content and Settings' and restarted the device. Then ran: react-native run-ios.
The issue persists.

@pKanijam in that window (FontBook), go to View -> Show font info (I don't know the exact name in the menu) and you should see something like this:

And you should use the PostScript Name and this doesn't work, you can use the next code:
for (NSString* family in [UIFont familyNames])
  {
    NSLog(@"%@", family);

    for (NSString* name in [UIFont fontNamesForFamilyName: family])
    {
      NSLog(@"  %@", name);
    }
  }

That you should place in "AppDelegate.m", after NSURL *jsCodeLocation;
And of course, after use it, you should delete it.

Exactly as @LuisUrrutia is saying 👍
An other link that should explain the 'name difference' visually is in the example here: https://hiddentao.com/archives/2017/03/10/get-custom-fonts-working-in-react-native/ . (as you can see the FontFamily name is different)

@react-native-bot I tested it in the latest version of RN (0.54.0) and I already reproduced the issue.

Issue resolved following the instructions above.
Thanks @LuisUrrutia, your instructions helped me to find the proper font name to use for iOS build.
Thanks @kelset, your last link helped me to organise my stylesheet properly and get the proper fonts on both iOS and android.

Thank you very very much @LuisUrrutia , you save my life. I spend more then 3 hour to find YOUR SOLUTION..


why CloseSafeProducer#close method do nothing in case cache is null ?

https://github.com/spring-projects/spring-kafka/blob/01154a9dd0bcd8dbe8a3dd683177812a47e4293d/spring-kafka/src/main/java/org/springframework/kafka/core/DefaultKafkaProducerFactory.java#L532
DefaultKafkaProducerFactory#CloseSafeProducer create producer without cache, this means that every CloseSafeProducer#close invocation does nothing, shouldn't invoke delegate's close method instead in this case ?

Same question? why not  invoke delegate's close method?

Same question. why not invoke delegate's close method?

@duke2002 Don't ask questions on old, closed issues; and don't ask questions in issues at all; ask questions on Stack Overflow on in GitHub discussions.
See the javadocs:
/**
 * The {@link ProducerFactory} implementation for a {@code singleton} shared {@link Producer} instance.
 * <p>
 * This implementation will return the same {@link Producer} instance (if transactions are
 * not enabled) for the provided {@link Map} {@code configs} and optional {@link Serializer}
 * implementations on each {@link #createProducer()} invocation.
...

The KafkaProducer javadocs recommend using a single producer within an application.
The cache is only present when transactions are being used, and then only for producer-initiated transactions or when producerPerConsumerPartition is false.
For the simple, non-transactional, use case, the delegate is left open for reuse.


Diversity in technical ability

[Note: I explicitly do not consent to the code of conduct as it is due to multiple issues]

we explicitly honor diversity in [...] technical ability

To me that is essentially saying that you cannot "discriminate" against people who write crap code by not merging their pull requests. This is unacceptable for any tech project imaginable.
If this is supposed to mean something else, it should be clarified.

Your point is well made. The authors did not intend that all project must accept all pull requests from all people with no considerations of their technical abilities of the merit of the code. I guess we assumed that most people would understand that treating people with respect does not mean accepting everything they contribute. Sorry if that point was not clear or if our assumption was too narrow. If you can suggest a better wording, that will help clarify this point for others reading this who might have concluded what you did.
The intent: it would be unacceptable to mistreat someone based on their technical abilities. When a project does not accept a pull request (for what ever reason) most would not consider that a mistreatment of someone's dignity, but a technical judgement call. Projects make judgement calls all the time. Project leaders explain their judgement rationally (e.g. "We decided not to port this kernel code to VB.") but they don't have to engage in mistreatment (e.g. adding a pejorative put-down statement attacking the person who made the suggestion). Healthy communities welcome the perspectives of many, including those who are new to tech (or new to the project's technical focus area). Those with differing (or downright poor) tech-abilities might still be able contribute to the projects successfully (perhaps by working on less-technical aspects of the projects and learning along the way). And those who have nothing to contribute can be treated warmly still since they obviously want to help the project, and maybe will by getting others to help out instead.

I think the problem here is that the word "discriminate" is overbroad for the contexts where it is being used.  In a literal sense it means "distinguish between", and in the common construction "discriminate against" it means "distinguish and treat differently" -- but that covers far more than "distinguish and mistreat".
I would suggest changing
We will not tolerate discrimination based on any of the protected characteristics above

to
We will not tolerate harassment based on any of the protected characteristics above

Then perhaps this item should be removed from the list of special "explicitly forbidden" characteristics, because what you actually intended should be covered by a standard "no personal attacks" clause which is already understood to be part of the code of conduct of most projects even if they don't write it down.

This was previously discussed in https://github.com/todogroup/opencodeofconduct/issues/33

Thanks for your feedback. See https://github.com/todogroup/opencodeofconduct/issues/84.


fixed typos in ppo tutorial

Description
This PR includes corrections of several typos and a minor rephrasing in the PPO tutorial.
Motivation and Context
The motivation for this change is to improve the readability and clarity of the PPO tutorial. It addresses some minor spelling errors and rephrases sentences to enhance comprehension. This doesn't fix an open issue but contributes to the overall quality of the tutorial content.

[ ] I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes
What types of changes does your code introduce? Remove all that do not apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds core functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Documentation (update in the documentation)
[ ] Example (update in the folder of examples)

Checklist
Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

[x] I have read the CONTRIBUTION guide (required)
[x] My change requires a change to the documentation.
[ ] I have updated the tests accordingly (required for a bug fix or a new feature).
[x] I have updated the documentation accordingly.

Cool 👌
I’ll check the version in pytorch/tutorials. On first glance, it seems that most of the typos aren’t present there. In the paragraph with “Out rollout data has a shape of…” there is a backtick missing though, so that’s one thing that’s gotta be fixed.
On 26. Jun 2023 at 12:52 +0200, Vincent Moens @.***>, wrote:

@vmoens approved this pull request.
Wonderful looks great!
We should also have a look at the version in pytorch/tutorials and see if these are present there also (we have duplicated versions of some tutorials for historical reasons, and the plan is to deprecate this version and link it to the official pytorch one in a near future)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


[Trivial][ML] GMM unpersist RDD after training

What changes were proposed in this pull request?
unpersist instances after training
How was this patch tested?
existing tests

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/128/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/4017/
Test PASSed.

Test build #91825 has started for PR 21562 at commit 1945ff4.

Test build #91825 has finished for PR 21562 at commit 1945ff4.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91825/
Test PASSed.

@felixcheung Would you mind make a final pass? Thanks!

sure, LGTM.


Update to use new WIT import/export syntax

This commit is an attempt/start to update wasmtime-py to be able to handle the new WIT import/export syntax.
This is a work in progress and the following are items that I'm not sure how to handle:

rust/wasi_snapshot_preview1
Currently, ci/wasi_preview1_component_adapter.wasm was built from wasmtime's main branch and rust/wasi_snapshot_preview1 is not used.

tests/test_table.py
Contains two commented out sections which have comments giving the reason for this.

Manual testing
$ python3 -m venv test_env
$ source test_env/bin/activate
(test_env) $ find . | grep -E "(/__pycache__$|\.pyc$|\.pyo$)" | xargs rm -rf
(test_env) $ pip install coverage flake8==4.0.1 pytest pycparser pytest-flake8 pytest-mypy pycryptodome
(test_env) $ pip install -e .
(test_env) $ pytest

Looks good! Happy to merge when you're happy with the commit history.

Thanks! I've squashed the commits now :+1:


Lack of support of hostNetwork

Helm chart doesn't support setting hostNetwork parameter which is useful for deployments in AWS EKS using non-default Calico CNI.

Closing as the pr is merged. @marinoborges if this doesn't fix your issue open a new issue. Thanks for the contribution.


engine mappings ui.vi doesn't refresh until you switch types

In order to get the Visualization screen to properly refresh, you have to switch between "Inputs and Outputs" and "Processing". This has lead to a lot of mistakes while debugging by forgetting to manually force the page to refresh.

To be clear about the issue:
You open visualization page, it shows things fine.
You switch to a different page, change some mappings, then switch back to the visualization page.
Visualization page has not updated.  Switch visualization view between I/O and processing, and viz page now correct again.
Yes?

exactly


[Question] Headless live Dash player used for load or presence testing

Hi,
Is there a way to run the Shaka player "headless" (without GUI, run from a command line) in order to verify the feed requests result in non 4XX/5XX errors, and also to possibly do load testing?

Hello @mlondon1, out of the box this is not possible. However, you can import Shaka Player into NodeJs as long as you fake certain media objects - for example the video object.

Thanks, any chance you could provide a little more detail?

Shaka Player depends on the browser to handle all media functions. In order for ShakaPlayer to run without a browser it needs those objects and functions faked. I have talked with another engineer on the team and the three main objects that you would need to fake are:

Video
MediaSource
SourceBuffer

Lastly you could need to import a node module that implements xhr to handle networking requests.

As a proof-of-concept, a colleague of mine built Shaka into an Electron app and was able to achieve playback. Perhaps you could do something similar?

Yes, Electron and things like it will work because they are actually complete browsers.
Node, however, is just a JS environment.  It is better suited for command-line tasks, but does not provide the media-related APIs we use.
If your goal is just to get Shaka to parse manifests and request segments, you don't need to do much more than stub out video and MediaSource.  For example, video.play() doesn't have to do anything, and SourceBuffer.appendBuffer only has to invoke an event.
You may also be able to repurpose some of the fakes we use in unit tests.  See simple_fakes.js in test/test/util/.

Hi @mlondon1 ,  I'm also searching for similar solution. Did you find solution for this? i would like to know your status on this. Please let me know if you found any alternative solution.
Thanks
Dinesh

An option I failed to mention before is to use Karam. We use Karam to run all our tests. If you look at our build/test.py and karma.conf.js you can see how we configure Karam to run our tests.

I was going to use Headless Chrome, but that seemed like a lot of overhead to run a whole browser so I started writing my own Dash parser in Python.
I am not a JavaScript expert so I had trouble getting the Shaka tests running to parse the live Dash stream as the code is complex.
If one of the Shaka developers could give general steps to run the test and stub/mock the non-essential components that might help, but not sure how much effort that is.

On Aug 3, 2017, at 9:05 AM, U Dinesh<EMAIL_ADDRESS>wrote:
Hi @mlondon1 , I'm also searching for similar solution. Did you find solution for this? i would like to know your status on this. Please let me know if you found any alternative solution.
Thanks
Dinesh
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Using headless Chrome would be the easiest option since it wouldn't require any extra work and would operate the same as a normal production app.  It will also avoid stubbing out components that would affect behavior.
If you want to just run the DashParser, all you need to do is to setup a fake NetworkingEngine to make network requests.  It also requires a valid DOMParser, which there are some implementations in node.
However, this will only give you the parsed manifest.  In your original question, you wanted to check for segment network errors and load testing.  The DashParser will only parse the manifest, not make segment requests.  To test the segments, you'll need to either make the network requests yourself using the manifest object, or use the whole Player, which would require stubbing out a lot of the media APIs.

It seems like this has been solved, at least insofar as we can do anything to solve it from Shaka Player.  If you would like help exploring other options besides headless Chrome or bootstrapping DashParser in node.js, please let us know and we can reopen.  Thanks!


Upgrade alpha-church

Hi,
I've made a few fixes to Alpha-Church

Wrong homepage set in theme.toml
Broken link to image in a page
Broken Javascript (which had been noticed at one point in the initial commit, but disappeared and I think I've now got it).

(PS - is raising a new issue the best way to alert the theme team to updates?)

Hi Daniel,
theme updates aren't scheduled. A rule of thumb is that an update of all themes happen usually at least once a week. Unless there

is a broken theme demo
a very noticeable bug
a theme has been added recently and the theme demo isn't perfect yet

or similar issues. I usually try to avoid update requests for a single theme. The reason is that this repository already contains 220+ Hugo themes. It can get tedious with such numbers if a update requests happens for every minor feature. That's what I try to avoid.
Your requests would be covered by the last scenario is the list above. Don't takes this comment as offense. It's just a measure to avoid too much avoid during the maintenance of this repository.
While updating themes I pull the latest changes (by default from the master branch) and update the references to the latest commit in each theme. Hence I suggest to commit / merge only changes that are ready to be used in production.
Give me a moment and your theme will be updated on the theme site.

@digitalcraftsman thanks for the information. And not at all offended - if I'd known there was a regular update schedule I wouldn't have worried about raising the topic.
Thanks!


Add database framework

Research a good database framework to use;
Add a sample test with unit tests and integration test;
Add a step on generate-app.sh to generate the API with or without a database.
For the integration test:
How to guarantee that the database will be good for the testing?
Should I create a database on sqllite for testing or a container?
How to version the database?

I am learning more about sequelize orm, and I think that is not the best option here.
For advanced query, the use of an orm is not recommended ... so I will implement the pg and other database frameworks.
This will help switch the database framework and it will be better in a clean arch
It will be easy to add an option on the generator as well
I think that I will continue using sequelize-cli to version the database
BTW nice article -> https://blog.logrocket.com/why-you-should-avoid-orms-with-examples-in-node-js-e0baab73fa5/


[firebase_core]: Firebase.initializeApp works locally on flutter web, but throws exception on deploy done in AWS Amplify

Is there an existing issue for this?

[X] I have searched the existing issues.

Which plugins are affected?
Core
Which platforms are affected?
Web
Description
After running the flutterfire configure command on terminal, setting all platforms and calling the Firebase.initializeApp method, The flutter app is initializing normally on android, ios and web locally. However, when the web app is deployed to production, it does not initialize. I am not using Firebase Hosting. Both the deploy and hosting of the web app are being done at AWS Amplify.
I caught the following exception in the browser console:

An error occurred configuring Firebase: PlatformException(channel-error, Unable to establish connection on channel., null, null)

All dependencies are up to date. I checked if the firebase_options.dart file contained the correct credentials, which it did.
Reproducing the issue
1- Run flutterfire configure in the root of your flutter project
2- select platforms android, ios and web
3- Call
try {
      await Firebase.initializeApp(
        options: DefaultFirebaseOptions.currentPlatform,
      );
      FirebaseAnalytics analytics = FirebaseAnalytics.instance;
      await analytics.logAppOpen();
      material.WidgetsFlutterBinding.ensureInitialized();
} on Exception catch (e) {
      print('An error occurred configuring Firebase: $e');
}

in your main.dart file
4- run flutter build web on a terminal
5- deploy the web build (not to firebase hosting, but to AWS Amplify)
6- open the app in any web browser and open console tab
7- it will show the following exception:

An error occurred configuring Firebase: PlatformException(channel-error, Unable to establish connection on channel., null, null)

Firebase Core version
3.1.1
Flutter Version
3.22.2
Relevant Log Output
An error occurred configuring Firebase: PlatformException(channel-error, Unable to establish connection on channel., null, null)

Flutter dependencies

Expand Flutter dependencies snippet

Dart SDK 3.4.3
Flutter SDK 3.22.2
sprint_wave_fe 2.0.5+26

dependencies:
- amplify_auth_cognito 1.8.0 [amplify_analytics_pinpoint amplify_analytics_pinpoint_dart amplify_auth_cognito_dart amplify_core amplify_flutter amplify_secure_storage async flutter meta path plugin_platform_interface]
- amplify_flutter 1.8.0 [amplify_core amplify_secure_storage aws_common collection flutter meta]
- amplify_storage_s3 1.8.0 [amplify_core amplify_db_common amplify_storage_s3_dart aws_common flutter meta path_provider]
- auto_scroll_text 0.0.7 [flutter]
- bcrypt 1.1.3
- cached_network_image 3.3.1 [cached_network_image_platform_interface cached_network_image_web flutter flutter_cache_manager octo_image]
- clipboard 0.1.3 [flutter]
- community_material_icon 5.9.55 [flutter]
- country_ip 3.0.0 [http]
- custom_refresh_indicator 3.1.0 [flutter meta]
- dartz 0.10.1
- dio 5.4.1 [async http_parser meta path]
- dotted_border 2.1.0 [flutter path_drawing]
- expand_widget 3.1.1 [flutter]
- firebase_analytics 11.1.0 [firebase_analytics_platform_interface firebase_analytics_web firebase_core firebase_core_platform_interface flutter]
- firebase_core 3.1.1 [firebase_core_platform_interface firebase_core_web flutter meta]
- fl_chart 0.66.2 [equatable flutter]
- flutter 0.0.0 [characters collection material_color_utilities meta vector_math sky_engine]
- flutter_flavor 3.1.3 [flutter]
- flutter_keyboard_visibility 6.0.0 [meta flutter_keyboard_visibility_platform_interface flutter_keyboard_visibility_linux flutter_keyboard_visibility_macos flutter_keyboard_visibility_web flutter_keyboard_visibility_windows flutter]
- flutter_localizations 0.0.0 [flutter intl characters clock collection material_color_utilities meta path vector_math]
- flutter_native_splash 2.4.0 [args flutter flutter_web_plugins html image meta path universal_io xml yaml ansicolor]
- flutter_svg 2.0.10+1 [flutter http vector_graphics vector_graphics_codec vector_graphics_compiler]
- flutter_widget_from_html_core 0.15.1 [csslib flutter html logging]
- go_router 13.2.0 [collection flutter flutter_web_plugins logging meta]
- google_fonts 6.1.0 [flutter http path_provider crypto]
- icons_launcher 2.1.7 [args image path universal_io yaml]
- image_picker 1.0.7 [flutter image_picker_android image_picker_for_web image_picker_ios image_picker_linux image_picker_macos image_picker_platform_interface image_picker_windows]
- in_app_review 2.0.9 [flutter in_app_review_platform_interface]
- infinite_scroll_pagination 4.0.0 [flutter flutter_staggered_grid_view sliver_tools]
- intl 0.19.0 [clock meta path]
- mime 1.0.5
- nested 1.0.0 [flutter]
- package_info_plus 6.0.0 [ffi flutter flutter_web_plugins http meta path package_info_plus_platform_interface web win32]
- pin_code_fields 8.0.1 [flutter]
- provider 6.1.1 [collection flutter nested]
- share_plus 9.0.0 [cross_file meta mime flutter flutter_web_plugins share_plus_platform_interface file url_launcher_web url_launcher_windows url_launcher_linux url_launcher_platform_interface ffi web win32]
- shared_preferences 2.2.2 [flutter shared_preferences_android shared_preferences_foundation shared_preferences_linux shared_preferences_platform_interface shared_preferences_web shared_preferences_windows]
- translator 1.0.0 [http]
- url_launcher 6.2.5 [flutter url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows]
- web 0.5.1
- webview_flutter 4.7.0 [flutter webview_flutter_android webview_flutter_platform_interface webview_flutter_wkwebview]
- whatsapp_unilink 2.1.0

dev dependencies:
- flutter_lints 2.0.3 [lints]
- flutter_test 0.0.0 [flutter test_api matcher path fake_async clock stack_trace vector_math leak_tracker_flutter_testing async boolean_selector characters collection leak_tracker leak_tracker_testing material_color_utilities meta source_span stream_channel string_scanner term_glyph vm_service]

transitive dependencies:
- _flutterfire_internals 1.3.38 [collection firebase_core firebase_core_platform_interface flutter meta]
- amplify_analytics_pinpoint 1.8.0 [amplify_analytics_pinpoint_dart amplify_core amplify_db_common amplify_secure_storage aws_common device_info_plus flutter meta package_info_plus path_provider]
- amplify_analytics_pinpoint_dart 0.3.8 [amplify_core amplify_db_common_dart amplify_secure_storage_dart aws_common aws_signature_v4 built_collection built_value collection drift intl meta path smithy smithy_aws uuid]
- amplify_auth_cognito_dart 0.10.13 [amplify_analytics_pinpoint_dart amplify_core amplify_secure_storage_dart async aws_common aws_signature_v4 built_collection built_value clock collection convert crypto ffi fixnum http intl js json_annotation meta oauth2 path smithy smithy_aws stream_transform uuid win32 win32_registry worker_bee]
- amplify_core 1.8.0 [async aws_common aws_signature_v4 collection graphs intl json_annotation logging meta retry stack_trace uuid]
- amplify_db_common 0.3.6 [amplify_db_common_dart drift flutter path path_provider]
- amplify_db_common_dart 0.3.7 [amplify_core async aws_common drift meta path sqlite3]
- amplify_secure_storage 0.4.4 [amplify_secure_storage_dart async file flutter meta path path_provider path_provider_windows]
- amplify_secure_storage_dart 0.4.4 [async aws_common built_collection built_value ffi file js meta path win32 worker_bee]
- amplify_storage_s3_dart 0.3.11 [amplify_core amplify_db_common_dart async aws_common aws_signature_v4 built_collection built_value drift fixnum json_annotation meta path smithy smithy_aws]
- ansicolor 2.0.2
- archive 3.6.1 [crypto path]
- args 2.4.2
- async 2.11.0 [collection meta]
- aws_common 0.6.5 [async built_collection built_value collection http2 js json_annotation logging meta mime os_detect path stream_transform uuid]
- aws_signature_v4 0.5.2 [async aws_common collection convert crypto json_annotation meta path]
- boolean_selector 2.1.1 [source_span string_scanner]
- built_collection 5.1.1
- built_value 8.8.1 [built_collection collection fixnum meta]
- cached_network_image_platform_interface 4.0.0 [flutter flutter_cache_manager]
- cached_network_image_web 1.2.0 [cached_network_image_platform_interface flutter flutter_cache_manager]
- characters 1.3.0
- clock 1.1.1
- collection 1.18.0
- convert 3.1.1 [typed_data]
- crclib 3.0.0 [meta tuple]
- cross_file 0.3.4+1 [meta web]
- crypto 3.0.3 [typed_data]
- csslib 1.0.0 [source_span]
- device_info_plus 10.1.0 [device_info_plus_platform_interface ffi file flutter flutter_web_plugins meta web win32 win32_registry]
- device_info_plus_platform_interface 7.0.0 [flutter meta plugin_platform_interface]
- drift 2.14.1 [async convert collection js meta stream_channel sqlite3 path]
- equatable 2.0.5 [collection meta]
- fake_async 1.3.1 [clock collection]
- ffi 2.1.0
- file 7.0.0 [meta path]
- file_selector_linux 0.9.2+1 [cross_file file_selector_platform_interface flutter]
- file_selector_macos 0.9.3+3 [cross_file file_selector_platform_interface flutter]
- file_selector_platform_interface 2.6.2 [cross_file flutter http plugin_platform_interface]
- file_selector_windows 0.9.3+1 [cross_file file_selector_platform_interface flutter]
- firebase_analytics_platform_interface 4.1.0 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
- firebase_analytics_web 0.5.8 [_flutterfire_internals firebase_analytics_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins]
- firebase_core_platform_interface 5.1.0 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 2.17.2 [firebase_core_platform_interface flutter flutter_web_plugins meta web]
- fixnum 1.1.0
- flutter_cache_manager 3.3.1 [clock collection file flutter http path path_provider rxdart sqflite uuid]
- flutter_keyboard_visibility_linux 1.0.0 [flutter_keyboard_visibility_platform_interface flutter]
- flutter_keyboard_visibility_macos 1.0.0 [flutter_keyboard_visibility_platform_interface flutter]
- flutter_keyboard_visibility_platform_interface 2.0.0 [flutter meta plugin_platform_interface]
- flutter_keyboard_visibility_web 2.0.0 [flutter_keyboard_visibility_platform_interface flutter_web_plugins flutter]
- flutter_keyboard_visibility_windows 1.0.0 [flutter_keyboard_visibility_platform_interface flutter]
- flutter_plugin_android_lifecycle 2.0.17 [flutter]
- flutter_staggered_grid_view 0.7.0 [flutter]
- flutter_web_plugins 0.0.0 [flutter characters collection material_color_utilities meta vector_math]
- graphs 2.3.1 [collection]
- html 0.15.4 [csslib source_span]
- http 1.2.1 [async http_parser meta web]
- http2 2.3.0
- http_parser 4.0.2 [collection source_span string_scanner typed_data]
- image 4.2.0 [archive meta xml]
- image_picker_android 0.8.9+3 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface]
- image_picker_for_web 3.0.2 [flutter flutter_web_plugins image_picker_platform_interface mime]
- image_picker_ios 0.8.9+1 [flutter image_picker_platform_interface]
- image_picker_linux 0.2.1+1 [file_selector_linux file_selector_platform_interface flutter image_picker_platform_interface]
- image_picker_macos 0.2.1+1 [file_selector_macos file_selector_platform_interface flutter image_picker_platform_interface]
- image_picker_platform_interface 2.9.3 [cross_file flutter http plugin_platform_interface]
- image_picker_windows 0.2.1+1 [file_selector_platform_interface file_selector_windows flutter image_picker_platform_interface]
- in_app_review_platform_interface 2.0.5 [flutter url_launcher plugin_platform_interface platform]
- js 0.6.7 [meta]
- json_annotation 4.8.1 [meta]
- leak_tracker 10.0.4 [clock collection meta path vm_service]
- leak_tracker_flutter_testing 3.0.3 [flutter leak_tracker leak_tracker_testing matcher meta]
- leak_tracker_testing 3.0.1 [leak_tracker matcher meta]
- lints 2.1.1
- logging 1.2.0
- matcher 0.12.16+1 [async meta stack_trace term_glyph test_api]
- material_color_utilities 0.8.0 [collection]
- meta 1.12.0
- oauth2 2.0.2 [collection crypto http http_parser]
- octo_image 2.0.0 [flutter]
- os_detect 2.0.1
- package_info_plus_platform_interface 2.0.1 [flutter meta plugin_platform_interface]
- path 1.9.0
- path_drawing 1.0.1 [vector_math meta path_parsing flutter]
- path_parsing 1.0.1 [vector_math meta]
- path_provider 2.1.2 [flutter path_provider_android path_provider_foundation path_provider_linux path_provider_platform_interface path_provider_windows]
- path_provider_android 2.2.2 [flutter path_provider_platform_interface]
- path_provider_foundation 2.3.2 [flutter path_provider_platform_interface]
- path_provider_linux 2.2.1 [ffi flutter path path_provider_platform_interface xdg_directories]
- path_provider_platform_interface 2.1.2 [flutter platform plugin_platform_interface]
- path_provider_windows 2.2.1 [ffi flutter path path_provider_platform_interface win32]
- petitparser 6.0.2 [meta]
- platform 3.1.4
- plugin_platform_interface 2.1.8 [meta]
- retry 3.1.2
- rxdart 0.27.7
- share_plus_platform_interface 4.0.0 [cross_file flutter meta mime plugin_platform_interface path_provider uuid]
- shared_preferences_android 2.2.1 [flutter shared_preferences_platform_interface]
- shared_preferences_foundation 2.3.5 [flutter shared_preferences_platform_interface]
- shared_preferences_linux 2.3.2 [file flutter path path_provider_linux path_provider_platform_interface shared_preferences_platform_interface]
- shared_preferences_platform_interface 2.3.2 [flutter plugin_platform_interface]
- shared_preferences_web 2.3.0 [flutter flutter_web_plugins shared_preferences_platform_interface web]
- shared_preferences_windows 2.3.2 [file flutter path path_provider_platform_interface path_provider_windows shared_preferences_platform_interface]
- shelf 1.4.1 [async collection http_parser path stack_trace stream_channel]
- sky_engine 0.0.99
- sliver_tools 0.2.12 [flutter]
- smithy 0.6.4 [async aws_common built_collection built_value collection convert crypto fixnum http_parser intl json_annotation meta path retry shelf typed_data xml]
- smithy_aws 0.6.3 [aws_common aws_signature_v4 built_collection built_value collection convert crclib crypto intl json_annotation meta path smithy xml]
- source_span 1.10.0 [collection path term_glyph]
- sprintf 7.0.0
- sqflite 2.3.3+1 [flutter sqflite_common path]
- sqflite_common 2.5.4 [synchronized path meta]
- sqlite3 2.4.0 [collection ffi js meta path]
- stack_trace 1.11.1 [path]
- stream_channel 2.1.2 [async]
- stream_transform 2.1.0
- string_scanner 1.2.0 [source_span]
- synchronized 3.1.0+1
- term_glyph 1.2.1
- test_api 0.7.0 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph]
- tuple 2.0.2
- typed_data 1.3.2 [collection]
- universal_io 2.2.2 [collection meta typed_data]
- url_launcher_android 6.3.0 [flutter url_launcher_platform_interface]
- url_launcher_ios 6.2.5 [flutter url_launcher_platform_interface]
- url_launcher_linux 3.1.1 [flutter url_launcher_platform_interface]
- url_launcher_macos 3.1.0 [flutter url_launcher_platform_interface]
- url_launcher_platform_interface 2.3.2 [flutter plugin_platform_interface]
- url_launcher_web 2.3.1 [flutter flutter_web_plugins url_launcher_platform_interface web]
- url_launcher_windows 3.1.1 [flutter url_launcher_platform_interface]
- uuid 4.3.3 [crypto sprintf meta fixnum]
- vector_graphics 1.1.11+1 [flutter http vector_graphics_codec]
- vector_graphics_codec 1.1.11+1
- vector_graphics_compiler 1.1.11+1 [args meta path_parsing xml vector_graphics_codec path]
- vector_math 2.1.4
- vm_service 14.2.1
- webview_flutter_android 3.15.0 [flutter webview_flutter_platform_interface]
- webview_flutter_platform_interface 2.10.0 [flutter meta plugin_platform_interface]
- webview_flutter_wkwebview 3.12.0 [flutter path webview_flutter_platform_interface]
- win32 5.2.0 [ffi]
- win32_registry 1.1.2 [ffi win32]
- worker_bee 0.2.4 [async aws_common built_collection built_value collection js meta path stack_trace stream_channel stream_transform]
- xdg_directories 1.0.4 [meta path]
- xml 6.5.0 [collection meta petitparser]
- yaml 3.1.2 [collection source_span string_scanner]

Additional context and comments
No response

@JacoNeto Thank you for reporting this issue. Did you try using Firebase Hosting? Did it work? I'm curious if it would work while AWS Amplify does not.

This should be placed before initializing Firebase app as well:
material.WidgetsFlutterBinding.ensureInitialized();

This should be placed before initializing Firebase app as well:
material.WidgetsFlutterBinding.ensureInitialized();

Thank you for the answer @russellwheatley, but this is already being done. As I said, it's working well in android, ios and web locally.

@JacoNeto Thank you for reporting this issue. Did you try using Firebase Hosting? Did it work? I'm curious if it would work while AWS Amplify does not.

I just deployed a version of our application with Firebase Hosting for testing. Indeed, there was no error with this approach. It looks like it is some issue with the integration with Firebase Code and AWS Amplify.

@JacoNeto I suggest that you open an issue with AWS Amplify. Since it was working locally and with Firebase Hosting, FlutterFire has nothing to do with this issue.


Is there a way to watch a folder?

Is there a way to watch a folder? so whenever a new video appears it will execute the script?

Where you deployed this. In a vps or heroku or anywhere.


Update verifying Relayer Proofs which check the XcmpChannelRoots instead of just the MmrRoot hack

Currently in pallet-xcmp-message-stuffer the extrinsic submit_xcmp_proof verifies an mmr proof from the relayer via a manually updated root (Which is just for testing purposes and is in no way secure) called update_root().
Need to replace the current approach by checking the current XcmpChannelMmrRoot for the particular channel_id instead which is updated in a trustless manner.

Closed in favor of #112


Error loading file:No playable sources found

please help, Error loading file:No playable sources found ,i ensured in the network inspect that path to the file location is correct.
my view code is----------

 [
                            'file' => 'E:\php\yii\proj#1\backend\views\file-storage\uploads\1.mp4'
                        ]
                    ]) ?>

my web.php code is------------
'components'=>[
 'jwplayer' => [
            'class' => 'wadeshuler\jwplayer\JWConfig',
            'key' => '/lq0VD8Briz9rSMS2ftRaI2foxKQw53JgF4EYg==',  // <-- Your Key Here!!
        'playerOptions' => [
            'autostart' => true,
            'sharing' => [
                'sites' => ['facebook', 'twitter'],
            ],
        ],
    ]
],

added some js files also and my id----------

Please fix your post. Your code preview is broken and you also do not show your full view code for displaying the widget.
You don't need to include any of your own JS files... The extension loads it all for you..

index.txt
web.txt

here is files please resolve the problem

The path to your file is incorrect, or check the video codec.
I am leaning towards your path being incorrect. You only put the filename, which would indicate your file would be in /frontend/web/your-video.mp4. If that is the case, then try to start with a slash like /your-video.mp4. If that doesn't work, try to use the full exact URL to it. If it still doesn't work, then check JWPlayer's supported codecs and inspect your own using MediaInfo.


Update readme for client and other packages

This is a draft PR for the purpose of preparing readme documents for the 0.10.0 release. The readme docs will be used for reference documentation on our docs site.
Steps to update a typical readme with reference documentation:

If a readme does not exist, create one with an introduction, some usage examples, etc.
Add doc comments to exported methods and types.
Add doc-snippets tokens around the comments and types or method signatures.
Use the doc-snippets CLI tool to inject the snippets into the readme doc.

You can copy the doc-snippets setup and configuration from repos where this has been done.
The aforementioned steps won't make sense for every package. Feel free to adapt as necessary!
TODO:

[x] @polywrap/client-js
[x] @polywrap/core-client-js
[x] @polywrap/client-config-builder-js
[x] @polywrap/core-js
[x] polywrap (CLI)
[x] @polywrap/test-env-js
[ ] @polywrap/uri-resolvers-js
[ ] @polywrap/uri-resolver-extensions-js
[ ] @polywrap/package-validation
[ ] @polywrap/wasm-js
[ ] @polywrap/plugin-js
[ ] @polywrap/tracing-js
[ ] @polywrap/result
[ ] @polywrap/msgpack-js
[ ] @polywrap/wrap-manifest-types-js
[ ] @polywrap/polywrap-manifest-types-js
[ ] @polywrap/logging-js
[ ] @polywrap/asyncify-js
[ ] @polywrap/os-js

Should we consider merging this and opening documentation issues for the remaining packages?

Should we consider merging this and opening documentation issues for the remaining packages?

Yeah, I think that's a good idea. It will prevent later work fixing merge conflicts.

@dOrgJelli I think I addressed all of your comments. I updated the client config builder readme. All code examples now use snippets that build with yarn build. We can use yarn build:fast to just build the source code.
I think it's in much better shape and ready for a new review!


[bug] HTML drop event not firing

Describe the bug
The drop event isn't triggered, and I tried in Safari to make sure and it works
Reproduction

Create a new tauri app
Open the console
Paste and execute the following line: location = "https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/drop_event"
Go to the Result section and the example isn't working

Expected behavior
The drop event should be triggered
Platform and versions
Environment
  › OS: Mac OS 12.6.0 X64
  › Node.js: 18.10.0
  › npm: 8.19.2
  › pnpm: 7.9.0
  › yarn: 1.22.19
  › rustup: 1.25.1
  › rustc: 1.67.0-nightly
  › cargo: 1.67.0-nightly
  › Rust toolchain: nightly-aarch64-apple-darwin

Packages
  › @tauri-apps/cli [NPM]: 1.1.1
  › @tauri-apps/api [NPM]: 1.1.0
  › tauri [RUST]: 1.1.1,
  › tauri-build [RUST]: 1.1.1,
  › tao [RUST]: 0.14.0,
  › wry [RUST]: 0.21.1,

App
  › build-type: bundle
  › CSP: unset
  › distDir: ../dist
  › devPath: http://localhost:3000/
  › framework: React

App directory structure
  ├─ temp.db
  ├─ dist
  ├─ node_modules
  ├─ public
  ├─ src-tauri
  ├─ .vscode
  └─ src

Stack trace
No response
Additional context
No response

Duplicate of a few issues like #3558, #3277 etc.
You need to disable Tauri's own file drop mechanism by either setting fileDropEnabled to false in tauri.conf.json or by using the respective Builder methods if you're dynamically creating the windows in code.
Alternatively you can use that file drag & drop mechanism (via the tauri://file-drop event) instead, if you only need the file paths in your frontend and not the file contents.

Oh sorry, I searched through the issues, but I thought those weren't related, my bad. Thanks @FabianLars for the answer!


Thumbnail generate shell error

It seems there are some issues with the shell to genrate thumbnails/
It says
Error: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'ModelName.dir' in 'field list'

Finally i found out the solution. In fact there isn't anywhere mentioned that.
In model i have to set
'fields' => array(
'dir' => 'fieldname'
)
Great job !!

This configuration option is mentioned in the basic example.


[Caffe Frontend] Add support for Power layer

Add support for Power layer

@fernchen @FrozenGene
Can you take a look at this PR, please? Thanks!

@fernchen @FrozenGene Can you take a look at this PR, please? Thanks!

I hava update commit, please help check it again.


Joint limit didn't work

Hi,
I'm a student and I'm trying to use MuJoCo for simulation modeling of dexterous hand.
I'm looking for some help with joint limit setting.
Here is a model which explains my question:
https://github.com/Ddeconelee/hand/blob/master/UR5_three_fingers_hand.xml
Here is a screenshot, illustrating my question:

I set joint range in [0 : 1.5708] and joint limit as true, but when I use the actuator6 "IandMbending02", those joints' limits don't work, rotate joints such as mid_ joint2 become negative.

Hi @Ddeconelee, were you able to fix your issue?

Hi @Ddeconelee, I suspect the problem is here, your position actuator is set to be allowed to push the joint to 12.217 radians, and has a quite a high gain (100 Nm/radian). Joint limits are soft in MuJoCo, so if you push on them hard enough you will be able to take them past their limit. Try applying (12.217 - 1.57) * 100 Nm to one of your fingers and see what happens...
:stuck_out_tongue_winking_eye:  (please don't do that)

@yuvaltassa Thank you very much for your answer. I tried to change Ctrlrange and Kp, but it didn't work. Is there any other way to restrict the joint to rotate in a negative direction (this obviously doesn't conform to common sense)?

If you attach a zip file with a loadable model I will take a look.

@yuvaltassa git@github.com:Ddeconelee/three_finger_hand_zip.git Thanks.

three_finger_hand.zip
This is the file, thanks!

Okay, the model loads fine, I don't see any joints that bend in a strange way. What am supposed to look at?

@yuvaltassa
I want to make the proximal joint (joint1) of the finger bend forward, that is, when I control the actuator IandMbending02, the middle joint (joint2) and the distal joint (joint3) keep the zero angle unchanged (so I set the range (0:1.57)), but due to the angular coupling relationship between the three joints (tendon matrix Index&Middlefinger bending), when the proximal joint bends, the middle and distal joints bend to a negative angle, and the angle restriction is unsuccessful, as shown in the figure. In addition to setting the angle range, what ways can I keep the mid and distal joint at zero when the proximal joint bends forward?

Thanks!

Sorry, none of this is happening in the model you attached above. In the model I have the fingers barely move in response to the actuators.

three_finger_hand_zip.zip
Sorry,I have uploaded the correct version.

I "fixed" this by making the joint limits stiffer in line 29:
<joint armature="0.01" damping=".1" solreflimit="4e-3 1" solimplimit=".95 .99 1e-3"/>

But really you shouldn't need this. Having these crazy high gains like this is a sign of bad design. You need to think carefully about your tendon coefs. Also you have tendon range defined but limited is not set to true so the tendon ranges are not doing anything...


[Model Serving]: Implement external route for models

Feature description
Add the ability to create a route for the model server (Mocks):

Add a check in the modal created in #642 to add a new external route.
Add the logic to create a new route on model server creation.
Add the ability to display the route on #649

Close this in favor of #642


So slooow

Hi.
First of all, great work.
But I use the HTTP JSON Api via mopidy I send this json:
{"method":"core.library.search","jsonrpc":"2.0","id":402,"params":{"query":{"any":["blink"]},"uris":["local:","spotify:","youtube:"]}}

And if I search on youtube its getting extremely slow, sometimes i never get a result..
But If I search without youtube everything works fast and always get result.
I use Rpi 2. and the latest modidy 1.0.0 and the latest mopdy-youtube version.

@dz0ny Any ideas what we can do here? Does pafy support timeouts or similar?

I think somehow the mopidy server should handle the timeout. Because it could happen with any other extension

Socket timeout is already at 600s, could it be just network issues? Btw each initial discovery for "track" consumes about 1MB. http://i.imgur.com/Ya9xMVd.png and is quite slow.
You can test yourself with mitmproxy+root cert:
env HTTPS_PROXY=http://localhost:8888 ytdl "https://www.youtube.com/watch?v=QnxpHIl5Ynw" -a

@szuniverse can you please start mopidy with
# env pafydebug=1 mopidy

and do the same query that is slow to you.

Even though this is not active at the moment, I'd leave the note that using a process pool of 16 in underpowered low-core devices is one of the reasons to make it slower (and fail to retrieve results with youtube-dl).
In my RPi1 I've changed it to 2 processes only and it reduced to 1/5 of the time (from 3min to little over 30s), though still hard to use...

Have you tried with Kostas's PR about performance improvements? I want to test it but my SD card died on me last week...  That'd be good to have someone test it on Rpi1 :)


2.0?

Is this still being worked on?
I was waiting for the 2.0.0 release before investing in this, but the release milestone for that has come and gone

Hey @yonaskolb! Thanks for filing this issue. Yes it's still being worked on, I've been a tad busy this past few weeks so I haven't had a chance to fix that final bug and do a bit of testing. I'll get the release out by tomorrow.

Is tvOS supported at the moment?

I believe the existing version supports tvOS, 2.0 definitely does although potentially only basic application targets at the moment.

Hi @yonaskolb! I've just released 2.0.0. Please note this is a fairly major upgrade as you'll see from the release notes, so if you encounter any oddities not captured by our automated tests please feel free to file an issue!


social media icons styling done

I have styled the social media icons , plz review it and add hacktoberfest tag

@qashifpeer If you can then do the same for the rest pages as well and also try to fic the white space below the footer

Yes sure I will do it.. could you add tag hacktoberfest plz
On Fri, 28 Oct 2022, 12:41 pm Samarth - TMSL, @.***>
wrote:

@qashifpeer https://github.com/qashifpeer If you can then do the same
for the rest pages as well and also try to fic the white space below the
footer
—
Reply to this email directly, view it on GitHub
https://github.com/SamarthTMSL/samarthtmsl.github.io/pull/80#issuecomment-1294557282,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASJPAA623K5TSFCHTIJZ3WDWFN4CBANCNFSM6AAAAAARQCIGGI
.
You are receiving this because you were mentioned.Message ID:
@.***>

We have already added the tag and the repo is under HacktoberFest so no need to worry your prs will definitely count🤞


Include node() in getting TS table type status

change to include the node in getting the (TS table) type status.

+1

+1

No Thumbs, merging.


-Server switch

Attempted to use the -Server switch on Exchange 2016 CU11 and it did not work.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: cf6e1bcc-a2b8-fa56-220b-c1366342004e
Version Independent ID: 5c8a40b9-7aa5-c2e1-88e4-6ade4b1d3386
Content: New-OfflineAddressBook (exchange)
Content Source: exchange/exchange-ps/exchange/email-addresses-and-address-books/New-OfflineAddressBook.md
Service: exchange-powershell
GitHub Login: @chrisda
Microsoft Alias: chrisda

@rtpcrew, the parameter description says "This parameter is available or functional only in Exchange Server 2010." and the Applicable: tag only has the value Exchange Server 2010.
So, the parameter is only available in Exchange 2010.


Is there a way to use static tables schemas for sql-scratchpad autocomplete?

In my use case I would only need to use this editor, to save sql queries in my react app.
I have the schema of the tables in a javascript obejct.
Is there a way to make sql-scratchpad autocomplete recognize this schemas and work offline?

Hi @Branyer! Thank you for your question.
/autocomplete endpoints retrieves schema info from the connected/plugged-in databases so it cannot recognise the static table schema in javascript object.
But Hue is open source ;) so I think you can try tweaking the sql-scratchpad UI calls to go via a method which works the same way /autocomplete does in the backend but it retries schema info from your javascript object.
Hope it helps!

Closing this issue since this was answered!


Feature Request - Onroad Screen Off

Could you please add Onroad Screen Off while driving ? Thanks
such as
https://github.com/sunnyhaibin/openpilot/commit/cc7767ba5c7c84050ea5bd985bcb377a5f83de3a

+1 to this feature request, helps my partner especially as she is sensitive to light when driving at night


Dynamic memory call mapping in AFR crypto layer

Dynamic memory calls in AFR crypto layer override other memory call mappings. calloc is always mapped to prvCalloc and free is always mapped to vPortFree.
The mapping can be seen at: https://github.com/aws/amazon-freertos/blob/master/libraries/freertos_plus/standard/crypto/src/iot_crypto.c#L254
Platform should provide an ability to override default crypto malloc/free calls to its implementations. It would be great if an option is added to override the default mappings of the calls.
Thank you!

We are still working on the fix. Leave this issue open.

Is there any active development ongoing for this issue ?
https://github.com/aws/amazon-freertos/pull/1713 relies on this issue being fixed

@sachin0x18,
This has been blocked by an effort to sub module mbedTLS, once that is checked in to the repository I will reopen a pull request that resolves this issue.
I apologize for the lack of transparency regarding this.

@sachin0x18,
I have implemented this, and will open a PR soon. I am close, but one platform is not working yet.

https://github.com/aws/amazon-freertos/pull/1898 implements this, I will go ahead and close this issue. Please reopen it if something was missed.


nvme,mana: ensure completions are read and written in order

The NVMe completion entry is a 16-byte value, and it contains a phase bit that the NVMe driver reads to determine when a completion in the queue is valid. To ensure the driver observes a consistent completion entry, the phase bit must be written by the device after the rest of the entry, and it must be read by the driver before the rest.
The memory access machinery in OpenVMM does not provide many ordering guarantees, especially on ARM64. Ensure accesses are performed in the right order via two atomic 8-byte accesses, plus proper fences, in the NVMe emulator and driver.
There's a similar bug in MANA. Fix this, too.

Perhaps we should consider giving accesses through GuestMemory implicit acquire/release semantics to avoid the explicit fences in the emulators. This would be free on x86 but would have a small penalty on ARM64. We would need to measure.
The fences in the drivers are probably OK, though.


Add "install://" links to support the spread of decentralized clients

So, we've been seeing a lot of feature discussion in GitHub issues, which is great!  But why should feature development need to go through GitHub at all?  Rotonde is decentralized: you can implement the features you want and use them right away.
The problem is, even if you implement a set of features, nobody else will use them unless they're convenient to install.  So, let's add "install://" links!  When you enter an "install://" link in the operator field, Rotonde looks for an "install.js" file in the corresponding dat:// archive and runs it.
The Rotonde client comes with an install.js script which replaces the user's index.html, updating the scripts to point to the newly-installed client.  This makes it easy to install a new client just by linking it to somebody.  We highlight install links in the feed so you can click them and install things even more easily.
Running arbitrary JavaScript would be a pretty big security problem on the normal web, but in Rotonde the damage is limited to your own portal, and you can always roll things back.  I think this could be an interesting experiment.  Let me know what you think!

This is definitely interesting! We were talking about how to do bots & services, and this seemed to be one of the easier ways to do them.
The reason I stayed away from implementing this functionality was a hesitation on its impact on Rotonde, Beaker & Dat wrt malicious scripts. But I might have been overthinking waaay too much.
I love the install:// path!
If we go down this route, I think what would be even more interesting is if installs were modular i.e. instead of installing an entire client you can install many smaller modules, each with new functionality.
At the same time I think the ability to switch your entire client is nice, maybe that could be something separate?
Thoughts?
also hella good job on merging prs & generally managing the repos @ianh 🙌

Switching an entire client would then mean to switch the set of modules you compose?
Earlier today I tried dat://5276ca2f92b6d508933ac4b01ef9078938f69bed9ca15c462617f531641b7a6b/index.html to see just @eelfroth's posts, but still being able to switch to see normal clients.
I then clicked in the menu to open the library and source, but just saw portal code.
I assume the change would be hidden in the client code... which i probably would find by checking the link hidden in the index.html? ...i would also like to see a DIFF, because even though i would like to add that change to my profile, i might rather add the feature but in a different visual way but reading the DIFF would show me the crucial parts and what api calls to make or what data to select to make that change happen

How would this compare with the app:// feature coming in beaker 0.8?

@serapath

I assume the change would be hidden in the client code
you are correct: I changed my portal's index.html to point to my development fork of rotonde-client.
the install script @ianh proposes makes this more convenient, by allowing users to switch their client right from the operator.

some suggestions to take this further:
· we could make a new repository for install:// links…
· the version number in the interface could link to the client dat

@alanz the App Scheme is currently categorized as 'Dead' in the beaker readnme. I guess this means that app:// is never coming…

Whoops, nope, that's an old readme line. App scheme was dead then revived, and coming in the next major release. Fixing now.

@cblgh Yeah, modular installs would be cool.  Managing modularity is hard, though: you need a way to see all the modules you have installed and uninstall them individually.  Properly testing all the interactions between modules is even harder, so things are likely to break and need troubleshooting (usually uninstalling all your modules and reinstalling them one-by-one).
With this system, somebody can assemble a collection of modules into a client archive and share that with others.  Uninstallation is as simple as installing a new client, and the client itself should work just as well for anyone who installed it as it did for the person who made it.
@serapath Installing a new client means updating the links in the index.html to load Rotonde's source code from a different dat archive—the entire behavior of the page could change.  A diff could be interesting, though it might end up being very big or hard to read.
@alanz Apps can coexist with the existing personalized homepages.  You can choose whether to navigate directly to a dat:// URL, using the Rotonde version installed at that page, or to browse through an app, using the Rotonde version you've installed as an app.  The install:// feature only changes the version you get when you navigate to the page directly.

We've spent some time wondering if Beaker could have tooling for this someday -- A way for an application to say "I'm willing to load modules that fit the following shapes." The browser would give UIs for configuring the modules loaded, and could read from a local index/library to find available modules. Users would build out their library of modules, and might even have modules that they use across multiple apps.
It's a similar core premise to what web extensions do by injecting scripts into the page. However if we let the application manage the loading of those modules, the module introduction can be much better structured. Script injections usually latch onto parts of the DOM or monkey patch code, which is brittle. If the app is consciously loading the module, it can do a better job of integrating it to the codebase via its own hooks.

@ianh modular isn't TOO dramatic. see vscode, atom, vim, sublime etc as examples.

Hey @neauoire -- does this sound like something which should be part of Rotonde? Or should we close this?

(FWIW, I think this is less necessary now that the client is being auto-updated from github again.)

I think we should revisit this now.

I haven't merged because I was waiting for actual modules to be install-able, or to have a use case, but I think I have a use case now. I've added a small drawing tool, that makes it really easy to create lightweight media content. I will try to replicate the install flow with the Dotgrid tool as an installable.

Cool, looking forward to it! The way "install://" works in this pull request doesn't support that use case very well (it's more for installing an entire new client) so it's probably not worth keeping this open.

Yeah, but the idea is perfect. So, thanks :)


Tupha/support card level select action uwp

Card-level selectAction works as specified in the Proposed Solution from https://github.com/Microsoft/AdaptiveCards/issues/1199

Hey there. The fact that UWP Renderer doesn't support selectAction is really missing for our implementation, that's why I looked for this merge. I forked the current master branch and created a nuget package out of it. However the selectAction is still not working in UWP renderer. Am I missing something? this merge should already closed the gap?

@BenAffleckIsBatman can you open a new issue with your app's details and we can continue the conversation there?

@tuanh118 sure! Did so #1572.


Broken basePath with AbstractPathProvider in version 2.5.0 of springfox-swagger2

Version 2.5.0 (same in 2.6.0)
Bug: AbstractPathProvider extension point is broken for swagger2 due to this code block in Swagger2Controller:

    Swagger swagger = mapper.mapDocumentation(documentation);
    if (isNullOrEmpty(swagger.getHost())) {
      final UriComponents uriComponents = componentsFrom(servletRequest);
      swagger.basePath(Strings.isNullOrEmpty(uriComponents.getPath()) ? "/" : uriComponents.getPath());
      swagger.host(hostName(uriComponents));
    }

Here you can see that even if the new path is getting to the Swagger object (line 1), it gets overwritten when "getHost" is checked. According to the swagger spec the host isn't even required, so this kind of assumptions should not be made.
On the other hand, the basePath is overwritten when a host is not provided which is the main reason for this bug.
The last version that we know that works is 2.3.1.
Sample implementation of AbstractPathProvider:
    class BasePathAwareRelativePathProvider extends AbstractPathProvider {
        private String basePath;

        public BasePathAwareRelativePathProvider(String basePath) {
            this.basePath = basePath;
        }

        @Override
        protected String applicationPath() {
            return basePath;
        }
        ...
    }

This is the commit that breaks this:
https://github.com/springfox/springfox/commit/a1ceac24e7cd0c646a6217391baa9d8a44fdb324

@danielbcorreia this was introduced to allow the application to work correctly in a load balanced environment. Not sure what is breaking here, the fact that the host name isn't what was supplied or that the host name is incorrect?

Specifying the hostname is optional. It's fine to assume the hostname from the current servlet context as it was done before, even though that field is optional in the swagger spec, but overwriting the basePath when the hostname is not supplied creates a lot of issues.

Issues like? Could you provide a breaking test or an example?

Sample entrypoint (springboot):

@EnableSwagger2
@SpringBootApplication
public class SampleAPI {

    public static void main(String[] args) {
        SpringApplication.run(SampleAPI.class, args);
    }

    @Value("${api.basePath:}")
    public String apiBasePath;

    @Bean
    public Docket newsApi() {
        return new Docket(DocumentationType.SWAGGER_2)
                .apiInfo(apiInfo())
                .pathProvider(new BasePathAwareRelativePathProvider(apiBasePath))
                .select().apis(RequestHandlerSelectors.withMethodAnnotation(ApiOperation.class))
                .paths(regex(".*"))
                .build();
    }

    private ApiInfo apiInfo() {
        return new ApiInfoBuilder()
                .title("Sample API")
                .build();
    }

    class BasePathAwareRelativePathProvider extends AbstractPathProvider {
        private String basePath;

        public BasePathAwareRelativePathProvider(String basePath) {
            this.basePath = basePath;
        }

        @Override
        protected String applicationPath() {
            return basePath;
        }

        @Override
        protected String getDocumentationPath() {
            return "/";
        }

        @Override
        public String getOperationPath(String operationPath) {
            UriComponentsBuilder uriComponentsBuilder = UriComponentsBuilder.fromPath("/");
            return Paths.removeAdjacentForwardSlashes(
                    uriComponentsBuilder.path(operationPath.replaceFirst(basePath, "")).build().toString());
        }
    }
}

Setting an environment variable here (-Dapi.basePath=/something) still causes the "basePath" property of the swagger spec to be "/" (forward slash).
If you step through the code, you will see that the basePath is fine in this line:
Swagger swagger = mapper.mapDocumentation(documentation);

(https://github.com/springfox/springfox/commit/a1ceac24e7cd0c646a6217391baa9d8a44fdb324#diff-e390517b6c056ed00ed0f28b8b4d3b77R82)
But then it gets overwritten when the hostname check is done.

@danielbcorreia Perhaps you don't need to use a path provider. All you may need is to use the docket#pathMapping("/something") api.

That's a workaround that actually doesn't work for us. It changes all operations to have a /something prefix, instead of changing the "basePath" property on the swagger spec.

Hmmm so the base path is specific to the docket?

how does your controller look? Could you give me an example based on below?

@Controller
@RequestMapping("???")
class SomethingController {
     @RequestMapping("???")
     public void someMethod() {
     }
}

What is your context path?
Do you perhaps have a dynamic dispatch servlet configured?

At the end of the day, in the docket we're trying to map reality using configuration. So somehow in your world the docket is not configuring things correctly. Without a concrete example or details its hard to be helpful.

@RestController
public class PingController {

    @ApiOperation(value = "Ping endpoint", notes = "Ping endpoint")
    @RequestMapping(value = "/ping", method = RequestMethod.GET, produces = MediaType.TEXT_PLAIN_VALUE)
    @ApiResponses(value = {@ApiResponse(code = 200, message = "OK")})
    public ResponseEntity<String> ping() {
        return ResponseEntity.ok("pong");
    }
}

We're just trying to set the "basePath" property on the swagger spec to be, for example, "/something" (instead of the default "/").
This was working before the change that I mentioned for X-Forwarded-Host was introduced. The blank/null host should not mean that the basePath should be touched.
We can avoid the problem by setting the hostname ourselves before that code takes place, but that is another workaround, and that is an optional field on the swagger spec.
In my opinion, a further check needs to exist when you check for isNullOrEmpty(swagger.getHost()), so you don't override the basePath when you don't need to. We are not using X-Forwarded-Host, so our basePath should not be overwritten.
I can try to put together a pull request to try to fix this.

I've encountered the same problem and found version 2.3.1 to indeed function as expected. We are hosting a site with external url "http://site.com/apicall" but which is stored on a local folder. Swagger uses this folder somehow as base url, giving "try it out" calls like "http://site.com/folder/apicall" which is obviously not right and the base url needed to be corrected to be "/". Using the pathProvider (and even added an override for getApplicationBasePath() on top of the code for the BasePathAwareRelativePathProvider by @danielbcorreia  ), the path was still "/apicall". After moving back to version 2.3.1 the base url works flawlessly again (however, this version suffers from issue #1280 which is quite painful). Is it possible to correct the base url in a different way using 2.6.0 , or correct the property position in a different way using 2.3.1 .... or is this an issue I would just have to wait for v 2.7.0?

The path provider or any of the usages haven't changed at all since 2.3.1. I suspect this is a changed behavior from spring 4.1.x -> 4.2.x. What ever you're using to front the service/proxy is not setup correctly.

Hi guys.
I have the same issue on my docket configuration.
I have more than one version of an api. So, I have two docket definitions with the basePath set to api-context/version:
Example:
people/v1
people/v2
but as @danielbcorreia point, the basePath is overriden if host is not configured.
The url of my swagger is: http://localhost:8080/swaguer-ui.html
My service endpoint is: http://localhost:8080/people/v1
I think if I define a basePath, I want to ensure the swagger json use them.
My workaround attempt is to discover the host, and set them at the Docket creation. But at this moment, I'm searching a solution to do this.

I create a workaround by adding a filter to v2/api-docs and create a new document with the current host and setting them to document cache.
It works, but i'm waiting for a fix to this issue.
Thanks.

Is this available in a SNAPSHOT build for testing?


Evaluate methods for converting javascript to typescript

Feature Request
Desired behaviour
There are a few utilities that could speed up this migration.
For example ReSharper https://blog.jetbrains.com/dotnet/2015/02/05/ways-and-advantages-of-migrating-javascript-code-to-typescript/ may be able to do some conversion although the resulting code will still need fixes.
Evaluate this using the free trial https://www.jetbrains.com/resharper/ and see if this is useful. We can get a copy of the full version if it proves useful.

Some additional food for thought.
https://weblog.west-wind.com/posts/2016/Sep/12/External-JavaScript-dependencies-in-Typescript-and-Angular-2 has some work on using javascript dependencies.
https://angular.io/docs/ts/latest/guide/upgrade.html#!#making-angularjs-dependencies-injectable-to-angular may also be worth a read

This seems out of date now


Tensorflow probability error in _fit_model_vi

When attempting to fit a CPLVM model using the _fit_model_vi function, I ran into the following error:

I suspect this may be due to some Tensorflow API update? When running this code I was on Tensorflow 2.5.0 (the oldest version available on pypi), though the package appears to have been developed using 2.3.0.
The code used to produce the above error is:
from cplvm import CPLVM

foreground_data = target_adata.layers['count'].T
background_data = background_adata.layers['count'].T

cplvm = CPLVM(k_shared=10, k_foreground=10)

approx_model = CPLVMLogNormalApprox(
    background_data,
    foreground_data,
    10,
    10
)

model_output = cplvm._fit_model_vi(
    background_data,
    foreground_data,
    approximate_model = approx_model,
    compute_size_factors=True,
    is_H0=False,
    offset_term=False
)

Hmm thanks for noticing this one too. I think this might be due to a mismatch between the specification CPLVM and the approximate model. For example, if the CPLVM has an offset_term, but the approximate model doesn't (or vice versa, which might be your case), you might see this error.
I added a couple Exception raises that hopefully throw more informative messages, but let me know if you still run into issues.

Closing this since I'm no longer running into the issue. Thanks for the help!


Adds Ruby 3.2 to the CI matrix

I'm not sure if Ruby 3.2 will work with Rails 6.0 or 6.1. One or both of those may need to be excluded.

Looks like it worked without issues. Thank you!


chore: remove machine taint code

Fixes #N/A
Description
Removes logic that uses the unschedulable taint for Machines
How was this change tested?
make presubmit && make apply
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

6 of 7 (85.71%)  changed or added relevant lines in 2 files are covered.
12 unchanged lines in 4 files lost coverage.
Overall coverage decreased (-0.02%) to 79.51%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pkg/controllers/disruption/controller.go
2
3
66.67%

Files with Coverage Reduction
New Missed Lines
%

pkg/controllers/provisioning/scheduling/topology.go
2
84.53%

pkg/controllers/provisioning/scheduling/topologygroup.go
2
96.75%

pkg/scheduling/storageclass.go
2
81.82%

pkg/controllers/disruption/pdblimits.go
6
76.47%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
8250

Relevant Lines:
10376

💛  - Coveralls


[SPARK-6379][SQL] Support an implicit conversion from udf"name" to an UDF defined in SQLContext

This is useful for using pre-defined UDFs in SQLContext;
val df = Seq(("id1", 1), ("id2", 4), ("id3", 5)).toDF("id", "value")
df.sqlContext.udf.register("simpleUdf", (v: Int) => v * v)
df.select($"id", udf"simpleUdf"($"value"))

Can one of the admins verify this patch?

Can't we make this explicit by using "callUDF"?

You mean df.select($"id", callUDF($"value"))?

I meant something like
df.select($"id", callUDF("simpleUDF", $"value"))

Ok, I'll try to refine my codes.

@rxin fixed, and plz check it.

Once you have updated, can you also update the PR description, as this becomes the commit message.  Thanks!

The description updated and the patch fixed.

I'll fix soon.

ok to test

Test build #30095 has started for   PR 5061 at commit f858aff.

Test build #30095 has finished for   PR 5061 at commit f858aff.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.
This patch does not change any dependencies.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30095/
Test PASSed.

Thanks!  Merged to master.


Create Bill Details Page Component (UI Mockup)

Please do work for this task in a branch called issue-XXX.


Using an invalid email address in forms, will result in Swift_RfcComplianceException

When I input an invalid email address (e.g. 'm') in an email field, I get a php exception:
Swift_RfcComplianceException
Address in mailbox given [m] does not comply with RFC 2822, 3.6.2.

Someone in the forum mentioned, that it is possible to enable HTML5 client side check:
http://getgrav.org/forum#!/?Swift_RfcComplianceException
However, this option does nothing, because I have it enabled, please check if this is true?
PS: In the docs I found nothing mentioned about validation rules

Can you please put this in the forms plugin issues tracker:
https://github.com/getgrav/grav-plugin-form/issues