Added a conversion for the union operator and a test

Small steps towards #12

Codecov Report

Merging #21 into main will increase coverage by 0.76%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   76.41%   77.18%   +0.76%
==========================================
  Files          24       25       +1
  Lines         653      675      +22
==========================================
+ Hits          499      521      +22
  Misses        154      154

Impacted Files
Coverage Δ

dask_sql/context.py
100.00% <100.00%> (ø)

dask_sql/physical/rel/logical/__init__.py
100.00% <100.00%> (ø)

dask_sql/physical/rel/logical/union.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d71c144...18cf14b. Read the comment docs.


[quantizer] add fc-1d rewrite

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

您好，我已经收到您的邮件，我会尽快查看并在第一时间回复您。

您好，我已经收到您的邮件，我会尽快查看并在第一时间回复您。


Exception causing Python HTTP server to crash

Empire Version
Latest master branch
OS Information (Linux flavor, Python version)
Ubuntu 16.04, python 2.7.12
Expected behavior and description of the error, including any actions taken immediately prior to the error. The more detail the better.
I get this error after removing some active agents without killing. Perhaps it is from removing an agent without killing it, causing it to continue to callback with invalid parameters?
I should also note that Empire tends to stop working when having many clients for some reason. The error does not occur, but the python web server will stop working silently while the interface shows no warning, only nothing will be able to connect.
Screenshot of error, embedded text output, or Pastebin link to the error
----------------------------------------
Exception happened during processing of request from ('xx.xx.xx.xx', xxxxx)
Traceback (most recent call last):
  File "/usr/lib/python2.7/SocketServer.py", line 290, in _handle_request_noblock
    self.process_request(request, client_address)
  File "/usr/lib/python2.7/SocketServer.py", line 318, in process_request
    self.finish_request(request, client_address)
  File "/usr/lib/python2.7/SocketServer.py", line 331, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/usr/lib/python2.7/SocketServer.py", line 652, in __init__
    self.handle()
  File "/usr/lib/python2.7/BaseHTTPServer.py", line 340, in handle
    self.handle_one_request()
  File "/usr/lib/python2.7/BaseHTTPServer.py", line 310, in handle_one_request
    self.raw_requestline = self.rfile.readline(65537)
  File "/usr/lib/python2.7/socket.py", line 480, in readline
    data = self._sock.recv(self._rbufsize)
error: [Errno 104] Connection reset by peer
----------------------------------------

Any additional information
This causes the server to crash, which causes it to stop communicating with agents.

this traceback shows a issue in the Python core, this may be a bug with Pythons SocketServer. Let me see what we can do to prevent an entire crash.

Thank you! What about the server crashing during heavier loads and over time? Sometimes it happens with ~10 agents. It will work for a few hours, then it suddenly become unresponsive. The UI is fine, but the python server stops working, and I don't think it ever become responsive again. When loading the url, there is a timeout. Could it be because of thread limits? I will look into it because it is very annoying to have to restart the Empire every time this happens, and it can cause you to miss agents. With fewer agents it lasts much longer sometimes a day, but eventually it could stop working.

@redt3am we really don't know right now. *not a good answer

I believe this issue should be fixed once matter is merged with 2.0 beta since we now use flask


Add Hedera Hashgraph

Signed-off-by: nikolay<EMAIL_ADDRESS>Description
Adds Support for Hedera Hashgraph
Depends on PR

How to test
Same way as other EVM chains

Types of changes

Checklist

[x] Create pull request as draft initially, unless its complete.
[x] Add tests to cover changes as needed.
[x] Update documentation as needed.
[x] If there is a related Issue, mention it in the description.

If you're adding a new blockchain

[x] I have read the guidelines for adding a new blockchain.

There are several issues with this PR:

This PR is adding an EVM chain, while Hedera does not seem to be an Ethereum clone
The provided Explorer link and sample transaction/account does not seem to be valid, e.g. https://mainnet-public.mirrornode.hedera.com/api/v1/transactions/0x9edaf0f7d9c6629c31bbf0471fc07d696c73b566b93783f7e25d8d5d2b62fa4f
Where do the provided coin/chainIDs (288, 295) come from?  Official coinID seems to be 3030 (see https://github.com/satoshilabs/slips/blob/master/slip-0044.md)
The build fails, there is no TWBlockchainTypeHedera.

Please clarify, consult https://developer.trustwallet.com/wallet-core/newblockchain, rework.
Closing for now.


hugo should generate page regardless of date of post.

Recently I encountered a very confusing problem: a posts could be perfectly generated on my local machine, but never generated on Netlify, even when I force Netlify using the same version of  Hugo as mine(0.58.1). And this post has the same front matters settings as my previous posts. I just couldn't figure out why.
After a few of frustrating guessings and experiments, it turns out that Hugo implies that a post won't be generated if its date is head of local datetime. However, my timezone is ahead of Netlify server's by several hours. My today is the tomorrow of Netlify server. After I set the timezone of Netlify to mine, everything works correctly.
I find this implication quite unintuitive. Hugo should generate page regardless of date of post or at least give user a warning. Would be very appreciated if this implication can be removed. Thanks!

See the -F or --buildFuture flag. You can move this discussion to the Hugo Discourse forum. But in such cases, simply setting the TZ env var in Netlify is the right thing to do [ref].

@kaushalmodi Yeah TZ method is the exact solution I use.
However it's certainly not  obvious to find out for newbies like me who can hardly reads the full document and all the build flags and lives several timezones far from most hosting service.  IMHO a decent software like Hugo should provide a nice default settings to prevent such thing from happening.
I do understand there are more important things to do and maybe something important I'm missing. So please forgive my rants and feel free to close this issue.


Fixed typos in documentation

No any descriptions needed. just 3 typos. Cheers! 👍

Thanks a lot @skywinder!


Zend\Db\Sql\Sql would benefit from multiple batch inserts and updates

At the moment when using:
$sql = new Sql($this->adapter);
One has to repeatedly do inserts which is very inefficient since it results in two SQL INSERTs.
$insert = $sql->insert('Table')->values(array(
// row 1 data
));
$insert = $sql->insert('Table')->values(array(
// row 2 data
));
It would be good to have a insertMultiple->values(array(
array(),
array(),
));
which could result in a batch SQL INSERT.

+1


refactor connect module to accomodate json posts and other usecases

Refactored _request method in connect module to receive url args and params/data separately.
This allows us to have params/data as a list instead of dict.
Added support for sending JSON post by sending is_json flag to _request
Added order margins API
Fixed few tests

@joeirimpan Don't merge this yet. Lets @ranjanrak also go through this and run it locally and test.

Good to merge this, fix for exit_order method response with order_id, seems fine too.


Interoperability between RaggedExperiment and maftools

Hi!
Is there a way or do you know scripts from anyone for transcribing a RaggedExperiment object easily to a  maftools one?
Thank you!
Pedro

Hello Pedro,
Sorry for the late reply. There is an option to convert MAF object to MultiAssayExperiment. I believe it can then be converted to RaggedExperiment.
I hope this helps.


Crosshair: Configurable stroke and strokeWidth

Adds support for configurable stroke and strokeWidth crosshair circles.
Also fixes the issue with the missing circle at zero Y axis values.
@reb-dev Can you please generate new Angular wrapper for this? I'm getting problems with it again on my end.
Requested by @shyakadavis in #338

Hey @rokotyan , I added a commit with the updated wrapper. npm run generate throws errors with node version 18 for some reason. I will try to find a fix in the future.


Hey Tim how's it going?

Hey @betatim just seeing how you are doing today?

@betatim never answered my question 😭


Decide on one way of span creation

We have things like acquire release etc and we also have a tracer api with start/finish etc. We should decide on one - the API most likely.

Fixed in https://github.com/spring-cloud/spring-cloud-sleuth/commit/05540b9d2e2f9644afc612f2cd85d6aa9a4c9417


Add ability to granualarly filter events

What does this PR do?
continuing https://github.com/jenkinsci/datadog-plugin/pull/353 to support filtering events by event name in addition to filtering by category
Description of the Change
Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

[ ] Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
[ ] PR title must be written as a CHANGELOG entry (see why)
[ ] Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
[ ] PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
[ ] PR should not have do-not-merge/ label attached.
[ ] If Applicable, issue must have kind/ and severity/ labels attached at least.

Looks good overall!
small nit: it would be good to have add a sort of eventName attribute to the classes in order to have something like DatadogUtilities.shouldSendEvent(this.eventName).

small nit: it would be good to have add a sort of eventName attribute to the classes in order to have something like DatadogUtilities.shouldSendEvent(this.eventName).

Good point, we thought about this but then decided it was better to be able to check the event name before creating the event. What do you think of creating static variable for event name in the classes and that way we can still have the property tied to the class but not need to create an instance first? Also while investigating this I found a bug with the shouldSendEvent logic so I fixed that!

@sarah-witt Great! And yes making it static would be perfect 👌


Laravel Sessions

I noticed with Laravel 5 + that each request creates a new session and this is causing issues tracking data with the tracker. For example if i wanted to track a users particular referral_id using the log it would create a brand new session for each request meaning that the only way to track that user would be using there IP Address which is not ideal.
Doing abit of research myself it seems Laravel changed the way sessions work so that if they are used Globally outside the Request Middleware they will not be tracked and a new session would be generated. Not sure if this is the cause but this is not ideal as it means the log becomes huge and tracking reliable data becomes a problem.
Any advice or tips to get around this would be appreciated.

I'm seeing the same issue on installation - overall the package looks awesome and installation went smoothly - but this is a deal breaker for me.  We use database session driver in dev and memcache in prod - not sure if that would make a different - and I've only tried this in dev.

Same problem here.

Should be fixed on next version.


Vulkan headers

I noticed that, we are using GLFW with GLFW_INCLUDE_VULKAN, do wee really need Vulkan-Headers submodule ?

Not true


Enhance build process

[x] Reduce number of failures down to 0.
[x] Speed up compilation (investigate any form of caching?).

Possible other things to explore:

Drop JSX to see impact on compilation speed, maybe use traceur instead of babel (?)
Drop Browserify (use webpacks instead)
Drop Gulp (use makefiles instead)

@ZeHiro, I've changed the build process to speed it up. For local development, you'll need to install the dev dependencies. Now, compiling the client is really fast (the first compilation takes up to 4 seconds on my machine, and next rebuilds take less than half a second). Any feedback would be appreciated, cheers!

Remaining tasks:

[ ] Write a Makefile for these commands + a few other commands (like install, install-debian, etc.)
[ ] Explain that dev.sh uses inotify and how to raise the max_user_watches number:
echo 1048576 | sudo tee /proc/sys/fs/inotify/max_user_watches


OCPBUGS-32709: Add conditions to LVMCluster status

This PR adds two new conditions to LVMCluster CR:

ResourcesSynced: Indicates whether the resources maintained by the operator are reconciled without any issues.
VolumeGroupsReady: Indicates whether the volume groups maintained by the operator are in a ready state.

The state and the readiness of an LVMCluster CR is also now calculated using these conditions.

Codecov Report
Attention: Patch coverage is 87.03704% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 78.63%. Comparing base (0816722) to head (b6562b3).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
+ Coverage   77.61%   78.63%   +1.02%
==========================================
  Files          27       28       +1
  Lines        1961     1999      +38
==========================================
+ Hits         1522     1572      +50
+ Misses        320      310      -10
+ Partials      119      117       -2

Files
Coverage Δ

api/v1alpha1/lvmcluster_types.go
100.00% <ø> (ø)

internal/controllers/lvmcluster/controller.go
67.56% <100.00%> (+3.66%)
:arrow_up:

internal/controllers/lvmcluster/status.go
85.26% <85.26%> (ø)

/hold

/retest

/retest

/jira refresh

/unhold


Weird issue when building rustc

I'm setting up a brand new computer, so it's time to build rustc! I've installed MSVC 2017, and
When doing so, I get a
couldn't determine visual studio generator
if VisualStudio is installed, however, consider running the appropriate vcvars script before building this crate

If I run vcvars, nothing changes. Same failure.
If I build rustc inside of the Developer Command Prompt, it builds just fine. gets further but fails for other reasons.
This might be a rustc bug bug I figured I'd file it here first... any ideas?

Ah this crate actually just delegates to the cc crate. That crate's detection of MSVC tools and such is super gnarly and surely bug prone with various flavors of MSVC installations. Want to move the issue over there though and I can try to tag other folks in?
(cc is used for all rustc-related MSVC detection as well, so this failing probably means that rustc will fail as well)

Done


iox-#2277 Add nodiscard to iox containers when pushing/emplacing fails

Notes for Reviewer
This PR adds [[nodiscard]] on any iox container APIs which may fail and return false if a container is at capacity
Pre-Review Checklist for the PR Author

[x] Code follows the coding style of CONTRIBUTING.md
[x] Tests follow the best practice for testing
[x] Changelog updated in the unreleased section including API breaking changes
[x] Branch follows the naming format (iox-123-this-is-a-branch)
[x] Commits messages are according to this guideline

[x] Commit messages have the issue ID (iox-#123 commit text)
[x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[x] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[x] Relevant issues are linked
[x] Add sensible notes for the reviewer
[x] All checks have passed (except task-list-completed)
[x] Assign PR to reviewer

Checklist for the PR Reviewer

[ ] Consider a second reviewer for complex new features or larger refactorings
[ ] Commits are properly organized and messages are according to the guideline
[ ] Code according to our coding style and naming conventions
[ ] Unit tests have been written for new behavior
[ ] Public API changes are documented via doxygen
[ ] Copyright owner are updated in the changed files
[ ] All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
[ ] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

References

Closes #2277

Yeah, unfortunately no update on my end. It was a bit more involved than I initially thought. I don't anticipate having time to do this for a little while, though I do really think it would be worthwhile, both for consumers as well as for iceoryx in general. I'm fine closing the ticket if you don't want to leave the open ticket around

@pbarone-latai no problem. Keep your time. It is not necessary to close the PR if you intend to work on it later :)


Run validation on xmls using the ENA validator

To validate XMLs:

[x] Ensure XMLs don't have properties not allowed by ENA

[x] delete identifiers tag
[x] delete accession attribute in sample
[x] randomize "alias" attribute in sample

[x] Send them to ENA dev environment
~[ ] Look up report API to retrieve results~
[x] Write up results

First item commited to checklist-converter repo

Full script is available here
The output folder of the script used in the previous ticket (retrieve xmls from ena using biosamples accessions) can be used as an input for this script.
The output is a folder containing all the receipts. These receipts contain the result of the validation.

This is done, at least for the purpose of this ticket. Comparison and results will be discussed in #25


bug: globalComponentsDeclaration doesn't work with pnpm workspaces

TypeScript with globalComponentsDeclaration doesn't generate components.d.ts when using pnpm and workspaces in the attached image's folder structure.
If I separate it to a regular folder with just the client application, then it is generated correctly.

Not sure if I got it, can you provide more context?

Ah, please disregard this issue. I'm not sure what the problem was, but it's now working for me with the pnpm workspaces. Thanks for this plugin, it's great.
I can create a new issue, but the generated components.d.ts has incorrect paths on my Windows system:

If I change all '' to '/' then it works correctly with TypeScript definitions

Fixed, thanks


Access client IP from SDK

We can already get the IP when using WAGI through the REMOTE_ADDR environment variable, but there's no way to access the client's IP when using the SDK.
Maybe we could use this standard way that proxies use to forward requests

@radu-matei Could/should we add it to the request record in http-types.wit, or is that set in stone?

Updating the request object is a breaking change — we should seriously consider it before we approach stabilization, and this might be suitable for adding.
https://github.com/fermyon/spin/blob/c0f2b3fd6ff5751772f9f90bbb25d017475f6e6e/crates/http/src/lib.rs#L351-L361
In the meantime, we could consider adding the information in the way @ecumene suggested — https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-For

Resolved by #1298


Clang treat uint32_t on MacOS as int

Hi to all.
I know that this repo is not about clang, but I dont know another place. On SO noone wants to answer clang questions so I will ask here if you dont mind.
I used clang on MacOS to generate bindings to Vulkan and found that clang treats uint32_t and uint64_t  as int and long instead uint and ulong as it does on WIndows.
So, I want to ask is this by design? Because typedef is pointing to typedef unsigned int uint32_t;
Does someone faced with this and know how to fix it?
P.S. I am using clang 11.0 from xcode

@tritao Is there any suggestions regarding this issue?

@QuantumDeveloper not by me at present but I can tell you that I've asked in the IRC channel of LLVM many times and with some patience there always is someone who can help. You can try there.

@ddobrev How I can get there? Can you point me please?

@QuantumDeveloper you can find it at https://llvm.org/ -  irc.oftc.net #llvm. Then you use any IRC client you like, or just the browser if you so prefer.

.Is there any reason that you can't use the parsing and AST support provided by CppSharp?
Any limitations that might not fit your use case?
We use the Clang C++ API directly, we don't have much experience with using libclang / C API, in fact we found a couple limitations that forced us to migrate to the C++ API years ago.

@tritao  Unfortunately CppSharp not fully fit my requirement (it very cool lib, but I found some limitations) For current moment I wrote my own analogue of CppSharp (maybe with less functionality) but it generates the interop code, which exactly match my needs and can be configured at most points (because C code sometimes in unpredictable from the parsing perspective and a lot of method should be configured manually)
Thats why I decided to write my own lib using libclang.
Anyway, thanks, I will ask clang developers at discord channel. Didnt see they have it.

OK, no worries, good luck in figuring it out.


Build baselines for TREC 2019 DL Track

Official corpus has been released! https://github.com/microsoft/TREC-2019-Deep-Learning

@rodrigonogueira4 since the corpus is also Tsv, should we build a specific collection reader into Anserini so that we don't have to convert first to Json?

@lintool, It makes sense, but the expanded docs from doc2query would still need to be indexed the json converter, right? We could add an argument for the collection reader pointing to the expansion terms, but that might be confusing to the users.

Resolved with #723.
Re: doc2query for DL, let's tackle in a different issue... but augmenting the documents externally would not require any additional code in Anserini itself.


Improve UI

Add favicon
Improve main to set a min height
Small improvements to search bar

The overall design is already good so I don't think I could help much, good job boys


Introduce create ticket script

The script automates github issue to Jita ticket mirroring.

Please note that for deployment, it is recommended to use a setup file: https://docs.python.org/3/distutils/setupscript.html
If this is for internal use only, then you do not need it.
If you want to maintain it for others to use, you need it.

Please note that for deployment, it is recommended to use a setup file: https://docs.python.org/3/distutils/setupscript.html
If this is for internal use only, then you do not need it. If you want to maintain it for others to use, you need it.

Thanks
For now we start with internal use.

Thanks
addressed comments,
didn't add yet tests, most of them are pretty tricky because the github status changes (unless we look always on all the history),
and we can't create issues on Jira in tests (we can just check for example a known issue exists).
Also didn't upload yet new quay.io images (but did change the Dockerfile), will do this at the end

https://github.com/oshoval/github2jira/compare/25d5236..1ec43529beb4c60bec1990ca11006430516f98a0
I think this should include all the pushes (some of them hidden in others, and some are small)

Refactor the issue class

Added unit tests for Issue class

added more unit tests
added --issue feature

thanks, addressed comments,
working on adding to CI (might need to merge it before, but maybe not, lets see)

CI runs now per PR (will make mandatory for merges)
https://github.com/oshoval/github2jira/blob/main/.github/workflows/main.yml
(tweaks might be needed to the above yml)

refactor the config according comment

fixed pylint to use tests/ on CI as well

Thanks, addressed some as we spoke (resolved ones), working on the rest

addressed rest of the comments

addressed comment

added some more tests, and tests/common lib

The production code seems good, I only had small comments about it, nothing major.
The unit tests require more work. Although I will not insist on it, please note that the unit tests are still suppose to check scenarios and not individual methods. I mean:

checking that you can filter the relevant github issues.
Opening a Jira ticket, based on some data.
Failing to open a Jira ticket or contacting github.
Not finding any relevant issues on github to process.

Etc...

Thanks,
some of those sound as e2e,
I prefer to not develop this project any deeper right now in aspect of tests, and provide as is.
In case we decide we can improve it later.

addressed some of the comments

Thanks, addressed rest of the comments (unless unresolved)

since some Jira servers will deprecate basic auth and move to PAT, support it

I do not think they are, as the intention is to unit test scenarios that have meaning (if possible).

Some aren't possible.
For example check Jira created issue, i already checked the jira create data.
Beside this the only thing the function does is call the real Jira lib, which we can't do in unit test.
this function even doesn't return a value (just assert in case of error, and i don't try to catch it anyhow even on main)
Anyhow as we said, I prefer to first publish an initial version, and upon needs to develop it,
maintaining of it is very easy, and i don't see we need to invest it any deeper right now.

thanks, addressed comments

Thanks for the great review Edy


Spellchecked some stuff

I spellchecked some stuff and made edits so it is more factually accurate.

In my previous contribution, I did use code from Bonk Commands(made by LEGENDBOSS123) to get the packet and info about it.


bug about Psychic Terrain

when tapu lele is attacked by skills like sucker punch, the damage should be 0.

#114


How to fixed the grid size in the mayavi?

Dear, author,
I found that if only one object is in the scene, the grid size is larger than the two objects in the scene.
My code is below.
    # Compute the voxels coordinates
    grid_coords = get_grid_coords(
        [voxels.shape[0], voxels.shape[1], voxels.shape[2]], voxel_size
    )

    # Attach the predicted class to every voxel

    grid_coords = np.vstack([grid_coords.T, voxels.reshape(-1)]).T

    # Remove empty and unknown voxels
    occupied_voxels = grid_coords[(grid_coords[:, 3] > 0) & (grid_coords[:, 3] < 255)]

    # Draw occupied voxels
    plt_plot = mlab.points3d(
        occupied_voxels[:, 0],
        occupied_voxels[:, 1],
        occupied_voxels[:, 2],
        occupied_voxels[:, 3],
        colormap="viridis",
        scale_factor=voxel_size - 0.5 * voxel_size,
        mode="cube",
        opacity=1.0,
        vmin=0,
        vmax=12,
    )

    colors = np.array(
        [
            [100, 150, 245, 255],
            [100, 230, 245, 255],
            [30, 60, 150, 255],
            [80, 30, 180, 255],
            [100, 80, 250, 255],
            [255, 30, 30, 255],
            [255, 40, 200, 255],
            [150, 30, 90, 255],
            [255, 0, 255, 255],
            [255, 150, 255, 255],
            [75, 0, 75, 255],
            [175, 0, 75, 255],
            [255, 200, 0, 255],
            [255, 120, 50, 255],
            [0, 175, 0, 255],
            [135, 60, 0, 255],
            [150, 240, 80, 255],
            [255, 240, 150, 255],
            [255, 0, 0, 255],
        ]
    ).astype(np.uint8)

    plt_plot.glyph.scale_mode = "scale_by_vector"

    plt_plot.module_manager.scalar_lut_manager.lut.table = colors

    mlab.show()
    mlab.savefig(filename=save_path)

Hi @rockywind, I don't understand your problem?
The grid_size is defined here:
# Compute the voxels coordinates
  grid_coords = get_grid_coords(
      [voxels.shape[0], voxels.shape[1], voxels.shape[2]], voxel_size
  )

It doesn't depend on the objects.

Dear author,
The grid size is 0.25. But some objects grid size  drawed in the picture is larger than anthor. I am confused.

Dear author,
Just like two pictures below.
Their grid size is 0.25. But the first one picture's grid size looked larger the the sencond one.

The voxel's shape is 400 * 400 * 25 in all scenes, and the voxel size is 0.25.
I can't find any scale factor in the code.
I found that the grid size is smaller with the object's number increase.

Did you set the viewpoint? You can follow this post to set the mayavi viewpoint
https://anhquancao.github.io/blog/2022/how-to-define-viewpoint-programmatically-in-mayavi/


Registration examples in DI extentions table

Fixes #14977
Internal Review Topic (direct link to Service registration methods section)
Given that the table focuses on other info (e.g., signatures, automatic disposal, etc.), any objection to making all of the examples singletons?
Thanks @natenho 🏍 and @serpent5! 🎸

The last two examples (Add{LIFETIME}<{SERVICE}>(new {IMPLEMENTATION}) and Add{LIFETIME}(new {IMPLEMENTATION})) only apply for AddSingleton, which is the only variant that can be given an implementation instance to use. {LIFETIME} isn't really a placeholder for those, as it will only ever be Singleton. Do you think this should be treated differently, somehow?
The text before the table (Each service registration extension method offers overloads that are useful in specific scenarios.) also suggests that the overloads apply to all of AddSingleton, AddScoped, and AddTransient, but the two in question just don't exist as overloads for the latter two.

ping @anurse


Have semi-positives been used for training?

I noticed that in the VIGOR dataset, each query (ground image) not only has one positive satellite image but also has three semi-positives, which are not specifically aligned with the query image. However, I didn't see them being used as positive samples in your code. Can I assume that one query (ground image) is only paired with one satellite image in training？

Hi，I want to ask about the dataset .  I download the CVUSA dataset.But the format of the content inside the dataset doesn't correspond to the way the data is loaded in the code.Do you meet the same question?

About this dataset..

About this dataset.
CVPR subset-selected

bingmap
splits
streetview
all.csv

I noticed that in the VIGOR dataset, each query (ground image) not only has one positive satellite image but also has three semi-positives, which are not specifically aligned with the query image. However, I didn't see them being used as positive samples in your code. Can I assume that one query (ground image) is only paired with one satellite image in training？

How can I download the vigor?I found the file I downloaded is broken.. Could you help me through my wechat？（13613677455 ）

@mksasx I think the code provided by the author is running well. Perhaps you should check the dataset's path configuration or refer to the previously closed issues. I am sorry that I have no right to share the VIGOR dataset with you. Please ask the author for help.

@dyx30 I have some problem in running this model. And I want to ask you about some questions . I would appreciate it if you could help me and contact me in wechat.  My wechat number is<PHONE_NUMBER>5.Thx!!!

@dyx30 Thx！！！

I noticed that in the VIGOR dataset, each query (ground image) not only has one positive satellite image but also has three semi-positives, which are not specifically aligned with the query image. However, I didn't see them being used as positive samples in your code. Can I assume that one query (ground image) is only paired with one satellite image in training？

Yes，in TransGeo，we did  not use the semi positive samples in the VIGOR dataset. Thanks for clarification about the codebase.

Hi，I want to ask about the dataset . I download the CVUSA dataset.But the format of the content inside the dataset doesn't correspond to the way the data is loaded in the code.Do you meet the same question?

Based on my experiments，the code works well on CVUSA dataset. The VIGOR download link is provided by OneDrive and you need stable network connection to download them.

What is the format of that all.csv, and why is the latitude and longitude in the one I downloaded, and also missing the ATTENTION folder?

@Jeff-Zilence @dyx30

@dyx30

@mksasx

@dyx30 I also heve a question

@dyx30

@dyx30 I would appreciate it if you can reply to me ! Thx!!


Close WAL file once it becomes inactive

This approach will allow to do not flush all dirty pages are contained in the cache to the disk for a long time. Till this moment early changes will be logged into the WAL will be flushed to the disk and we may safely remove them. This change is related to https://github.com/orientechnologies/orientdb/issues/6421 .

Fixed


Tweaked the representation of nets and buffers in the Show command graph.

Two tweaks to the generated graph.

Nets changed from a diamond shapes to plain text with the net name. This provides the visual load of the nets while preserving their names.

Buffers changed from a period shape to a plain text with the label "[BUF]", providing hint what they are while keeping the visual load low

Before

After

Dot files
Archive.zip

Personally, I find it unconvincing that the new representation is any better (or any worse) than the old one. Both have issues in slightly different ways.

2. Buffers changed from a period shape to a plain text with the label "[BUF]", providing hint what they are while keeping the visual load low

This makes buffers more visible, why? I suspect this is because it looks better when used with -colors, but it makes the output more cluttered. Just recently we removed an explicit BUF label, and this would change it back.

@povik, the rationale behind the "[BUF]" is to provide to readers an indication what that node mean.  Below are the three version of the buffer. The "[BUF]" one provide a balance between providing the information while keep low clutter.

is to provide to readers an indication what that node mean

Yosys developers already know what the node means though.

@whitequark, yes, it targets new readers, eliminating the question "what does this dot mean?", without much burden on readers that already know.

This yosys application suggests that the diagram is also targeting users and learners. I hope that is still the case.

The reason I changed the "BUF" nodes to a dot was that there were a lot of issues filed by confused users that asked how to make yosys remove the buffers (that didn't really exist in the netlist, but were just a visual representation for two connected wires) and I got tired of answering them. I haven't seen any new questions like that filed since the change, so I feel quite confident in saying that the dot shape is less confusing to users.

Thanks @nakengelhardt.  I will restore the 'point' shape and will submit a new clean PR.

For the plaintext I guess it can be an option, I personally dislike the wide space between the place where the arrow points and the actual text, especially for short wire names, but I can see that it's a taste question. The default should remain the diamond but I would be ok with a generic option to override it, something like show -wireshape foo.

Sounds good. Thanks.
On Thu, Feb 29, 2024 at 10:14 AM N. Engelhardt @.***>
wrote:

For the plaintext I guess it can be an option, I personally dislike the
wide space between the place where the arrow points and the actual text,
especially for short wire names, but I can see that it's a taste question.
The default should remain the diamond but I would be ok with a generic
option to override it, something like show -wireshape foo.
—
Reply to this email directly, view it on GitHub
https://github.com/YosysHQ/yosys/pull/4247#issuecomment-1971693738, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAQVMQOV6BREUCJBKNL2TWDYV5XZVAVCNFSM6AAAAABD7Q37QSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZRGY4TGNZTHA
.
You are receiving this because you modified the open/close state.Message
ID: @.***>

Hi @nakengelhardt, I have the -wireshape code working, but before I send a PR, I would like to ask you one more question.
You mentioned that you dislike the space in the plaintext nodes and I found a way to eliminate it (see below). Would you consider  having this is the new default (and only) behavior, resulting with simpler code, or should I go ahead with the --wireshape PR?
Original/default:

With -wireshape=plaintext:

BTW, https://edotor.net/ is a great site to experiment with .dot files.

Opening for the ongoing discussion.


After not successfully implementing your example, I tried to write the for loop as you did with slight modification. Namely, the problem I am trying to solve is to select different regions on the same image.
For every selected point, I run expandToSquare:
var expandToSquare = function(point) {
  return ee.Geometry.Point(point).buffer(10).bounds()
}

so this is the list of squares:
var samplePoints = samples.coordinates();
var sampleSquares = samplePoints.map(expandToSquare);

For a single image, the following example works fine (export the neighborhood of 3rd point from the list):
Export.image.toDrive({
    image: drone_image_unscaled,
    description: 'test',
    scale: 0.1,
    region: sampleSquares.get(2)
  });

If I try to run the following, none of the tasks appears:
var samplesCount = sampleSquares.size();
for (var i = 0; i < samplesCount; i++) {
xport.image.toDrive({
    image: drone_image_unscaled,
    description: i,
    scale: 0.1,
    region: sampleSquares.get(i)
  });
}

I would be thankful if you could provide a suggestion either how to implement for loop or how to create a collection of images, suitable to use your library, after selecting various regions of the same underlying image.
Here is the link to my current implementation
And this is the screenshot of the problem I am trying to solve (select multiple samples of the image and save them to separate images):

I made it working the following way:
var sampleSquaresList = sampleSquares.getInfo()
sampleSquaresList.map(function(f){
    var index_f = sampleSquaresList.indexOf(f)
    Export.image.toDrive({
      image: drone_image_unscaled,
      description: 'test_' + index_f.toString(),
      folder: text,
      scale: 0.1,
      region: f
    });

by calling sampleSquares.getInfo(), I got the list on the client side and there it was possible to call map without return.


Remove dalli-elasticache wrapper

The dalli-elasticache wrapper is for auto-discovering elasticache endpoints.
However due to recent updates with AWS Elasticache, this behaviour is no longer
needed. What's more is this gem has a non parameterised 60s timeout when
autodiscovering and causes Alephant to hang for a long time on each request
if the provided elasticache endpoint is unreachable.
This change switches to using the Dalli client directly.

I've also had to pin the travis version of JRuby back, as it appears to be failing on <IP_ADDRESS>
I'll create a ticket for upgrading/fixing ruby 2.5 and <IP_ADDRESS> support

Any specs for the issue? We only know it's fixed due to debugging...

It's difficult to write specs for the specific issue as the bug lies somewhere inside the dalli-elasticache gem, not within our code, and also only seems to apply when autodiscovering an elasticache endpoint which we wont want it to actually do in our tests (or at all anymore). I'll add some generic specs for this client class though as it looks completely untested(❗) , but even if this was tested I imagine the dalli-elasticache behaviour would have been mocked out anyway.


Improve float formatting in CSV output

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.379%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
607

Relevant Lines:
617

💛  - Coveralls


arti: 1.1.10 -> 1.1.11

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/arti/versions.
meta.description for arti is: An implementation of Tor in Rust
meta.homepage for arti is: https://gitlab.torproject.org/tpo/core/arti
meta.changelog for arti is: https://gitlab.torproject.org/tpo/core/arti/-/raw/arti-v1.1.11/CHANGELOG.md
Updates performed

Rust version update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.1.11 with grep in /nix/store/74lxn6v3anapql2b32rn9sg72xbjdlzy-arti-1.1.11
found 1.1.11 in filename of file in /nix/store/74lxn6v3anapql2b32rn9sg72xbjdlzy-arti-1.1.11

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
arti

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/74lxn6v3anapql2b32rn9sg72xbjdlzy-arti-1.1.11 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A arti https://github.com/r-ryantm/nixpkgs/archive/d52e7fea87498f4eb82a988d09780c4a4e02eafc.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/d52e7fea87498f4eb82a988d09780c4a4e02eafc#arti

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/74lxn6v3anapql2b32rn9sg72xbjdlzy-arti-1.1.11
ls -la /nix/store/74lxn6v3anapql2b32rn9sg72xbjdlzy-arti-1.1.11/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

arti

Maintainer pings
cc @marsam for testing.

Result of nixpkgs-review pr 272275 run on x86_64-linux 1

1 package built:

arti


[FEAT] Add metadata for long horizon datasets

Is your feature request related to a problem? Please describe.
I would like to have metadata for the long-horizon datasets (for example, test size, validation size and horizon).

Hi @RawaaM! The new name of the nixtlats library is neuralforecast. So you should use pip install neuralforecast. :)


[RESTEASY-2171] JsonBindingProvider use incorrect charset encoding

Issue: https://issues.jboss.org/browse/RESTEASY-2171

@iweiss thanks a lot for your work on this. However, I'm closing this PR because we don't need the fix on branch 3.6 atm. I've cherry-picked your commit into https://github.com/resteasy/Resteasy/pull/1906 for master. We'll also need a backport to branch 3.7, but I can do that later together with other commits. If you want this for EAP 7.2.x stream, the branch to use is 3.6.1.SPx.


Add documentation

Codecov Report

Merging #45 into master will decrease coverage by 0.12%.
The diff coverage is 57.14%.

@@             Coverage Diff              @@
##             master      #45      +/-   ##
============================================
- Coverage     73.95%   73.82%   -0.13%
  Complexity      472      472
============================================
  Files            66       66
  Lines          1739     1742       +3
  Branches        117      117
============================================
  Hits           1286     1286
- Misses          385      388       +3
  Partials         68       68

Impacted Files
Coverage Δ
Complexity Δ

...main/java/co/elastic/apm/api/TracerRegisterer.java
80% <100%> (ø)
2 <2> (ø)
:arrow_down:

...i/src/main/java/co/elastic/apm/api/ElasticApm.java
42.5% <40%> (-3.45%)
6 <1> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 913fd0c...3f1b5a4. Read the comment docs.


Empty values from time to time

Version of home_assistant

0.116.1
Version of the custom_component

v1.1.8
Describe the bug
Since last update the weather values are empty from time to time.

Debug log

2020-10-08 23:54:19 ERROR (MainThread) [custom_components.dwd_weather] Unexpected error fetching DWD Weather Coordinator for Wuerzburg data: type NoneType doesn't define __round__ method
Traceback (most recent call last):
  File "/srv/ha/lib/python3.8/site-packages/homeassistant/helpers/update_coordinator.py", line 143, in async_refresh
    self.data = await self._async_update_data()
  File "/srv/ha/lib/python3.8/site-packages/homeassistant/helpers/update_coordinator.py", line 131, in _async_update_data
    return await self.update_method()
  File "/home/homeassi/.homeassistant/custom_components/dwd_weather/connector.py", line 51, in async_update
    return await self._hass.async_add_executor_job(self._update)
  File "/usr/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/homeassi/.homeassistant/custom_components/dwd_weather/connector.py", line 99, in _update
    ATTR_FORECAST_TEMP: int(round(temp_max, 0)),
TypeError: type NoneType doesn't define __round__ method

Thanks for reporting the issue. I fixed this in v1.1.9.

Thanks for the fast fix!


Enable CheckStyle Plugin in pulsar-zookeeper-utils

Motivation
currently, the pulsar-zookeeper-utils module is not protected by the checkstyle-plugin.
Modifications

Enable CheckStyle Plugin
Fix checkstyle violations

Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?

[x] no-need-doc
java checkstyle changes, no need doc.

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks


mac-28 lost external connection from phone device.

Type of Request
bug
Infrastructure Environment
LUCI, Github, Cocoon scheduler, Autosubmit, etc...
What is happening?
mac-28 lost external connection from phone device.

Steps to reproduce
Step 1:
Step 2:
..
Step n:
Expected results
I expect to see X when Y is finished.

Rebooting machine to restore connection.


🌟 Expanding the collection of shortcodes for the theme

Is your feature request related to a problem? Please describe.
When writing for my blog, there are a few shortcodes which I would have liked to have available, but aren't currently. These include:

gallery: show all the pictures inside a given directory (with a regex filter for the name)
carousel: image slider (same as gallery for images source)
github repo: preview of a github repo with language and forks and stars details

Describe the solution you'd like
Create the mentioned shortcodes and add them to the theme.
Describe alternatives you've considered
N/A
Additional context
These are some features I'd be happy to implement myself and contribute to this amazing project, if there is an actual demand for it. I will try my best to implement them for my blog anyway, but if people agree that they would also like them, I may polish the code a bit more and do a PR here.
Example Usage:

gallery

# To add all png images in a directory:

{{< gallery source="img/*.png" >}}

# To add all pngs that contain `gallery_` in the name:

{{< gallery source="img/gallery_*.png" >}}

carousel

# To add all png images in a directory:

{{< carousel source="img/*.png" >}}

# To add all pngs that contain `gallery_` in the name:

{{< carousel source="img/gallery_*.png" >}}

github

{{< github user="mirceanton" repo="mirceanton.com" >}}

# or simply

{{< github url="https://github.com/mirceanton/mirceanton.com" >}}

Reference links:

gallery

the downside for this one is that it requires us to put all images inside the static/ directory instead of using page bundles

carousel
github repo

This sounds really awesome @mirceanton can I ask you to break it down into three tickets?
Also, would be able to provide any reference implementations or PRs for any of the above?

@nunocoracao I don't have them working the way I want them to yet. Once (if) I get it all sorted out, I will create individual issues and PRs for them!
I can't provide an estimated timeline as HTML, CSS & JS aren't exactly my specialty, so there will be a learning curve.

Awesome thanks @mirceanton let's split the tickets because I don't mind picking some of them up if I have time. I can also do it if I have time, if tou can first I would be thankful.

Alright then! I'll create the tickets a bit later today.

@nunocoracao Closing this as individual tickets have been created per shortcode:

#426
#427
#428

cool thanks


window.showModalDialog()

<EMAIL_ADDRESS>commented:

window.showModalDialog() needs to be implemented. Including how it handles scoping and semi blocking other code execution in browser.

Disclaimer:
This issue was migrated on 2013-03-15 from the project's former issue tracker on Google Code, Issue #172.
:star2:   2 people had starred this issue at the time of migration.

This would have to be implemented in Webkit.  It is not clear to me whether it ever was implemented in Webkit, but it is deprecated and is in the process of being removed from Chrome, Firefox, and IE:

http://tjvantoll.com/2012/05/02/showmodaldialog-what-it-is-and-why-you-should-never-use-it/
https://blog.chromium.org/2014/07/disabling-showmodaldialog.html
https://developer.mozilla.org/en-US/docs/Web/API/Window/showModalDialog
https://twitter.com/jacobrossi/status/588353411168346113

I am therefore inclined to say that it is not a feature PhantomJS should add.


rollup fix

There's a lot more here than the "rollup fix" which isn't actually a fix, as that scss is obviously needed.


undeclared use of _id, _email when building in xcode

Describe the bug
When following instructions from here: https://docs.bugsnag.com/platforms/ios/symbolication-guide/ the build process fails in xCode.
Steps to reproduce

Follow instructions in link, and try to build in xCode

Environment

Bugsnag version: 6.4.1
CocoaPods version: 1.9.3
iOS/tvOS/macOS version(s): 12
Simulator or physical device: Both
Xcode version: 12.01

Hi @inctor, we haven't been able to reproduce this. Have you tried clearing your cache? We've seen Cocoapods lose entire source files sometimes, and found that deleting ~/Library/Caches/CocoaPods can help. Let us know if that makes any difference.

Closing as we haven't received a response, but if this is still causing issues then please share further details on how to reproduce the issue and we can re-open.

Closing as we haven't received a response, but if this is still causing issues then please share further details on how to reproduce the issue and we can re-open.

Hey @yousif-bugsnag and @mattdyoung ,
i tried looking into it again, but the issue still occurs..
i tried deleting caches and removing all installed pods, and also all node_modules, and reinstall it all, but the issue still occurs.
I followed this guide: https://docs.bugsnag.com/platforms/react-native/react-native/
and then the iOS Symbolication guide here: https://docs.bugsnag.com/platforms/ios/symbolication-guide/
I've attached pictures of the errors that occur.. Can you help?

Hey @yousif-bugsnag and @mattdyoung ,
i tried looking into it again, but the issue still occurs..
i tried deleting caches and removing all installed pods, and also all node_modules, and reinstall it all, but the issue still occurs.
I followed this guide: https://docs.bugsnag.com/platforms/react-native/react-native/
and then the iOS Symbolication guide here: https://docs.bugsnag.com/platforms/ios/symbolication-guide/
I've attached pictures of the errors that occur.. Can you help?

@inctor
It looks like this is for a React Native project - can you confirm?
If so can you let us know which version of React Native you're using and which version of bugsnag-js you've integrated?
Do you see the same issue if you create a new React Native project and integrate Bugsnag in the same way?
If you have a reproduction example you can share that would help us diagnose. You can email us at<EMAIL_ADDRESS>if you don't want to share this publicly on the issue.

Closing this as we haven't been able to reproduce the error you're seeing, but if you have a reproduction case you can share with us we'd be happy to re-open and investigate further.


st2 action list broken

Dear support,
After we installed a customized pack, it fails to run command "st2 action list":
root@a474eb9015f2:~/.pip# st2 action list
ERROR: 'ascii' codec can't encode characters in position 0-1: ordinal not in range(128)
attached packs for your reference.

cms.zip

ok, I also figured out this issue, it's due to Chinese character in action metadata files.
so, seems version 2.2.1 is not support unicode like Chinese character?

Confirming it's a bug on latest st2:
$ st2 --version
st2 2.4dev

$ cat /etc/default/locale
# Created by cloud-init v. 0.7.9 on Mon, 19 Jun 2017 19:10:24 +0000
LANG="en_US.UTF-8"


Standalone cli fix

This continues from #58 and addresses #60
This PR does a few things

Outputs embedding parameters in a readable format in standalone cli
Makes sure that the ordination is properly centered
Removes cross-validation at the end (so that it won't hang)

Feel free to test this out.  This branch can be installed via
pip install git+https://github.com/mortonjt/rhapsody.git@standalone-cli-fix

Ok, @afvrbanac just did a quick test of rhapsody on her machine.  Merging this in. Thanks!


Plugin Conflict Homepage and File Color

Details
When Homepage updating to 4.0.6, the plugin File Color stops working - coloring notebooks in colors
In 4.0.4 is OK
4.0.6:

4.0.4:

Steps to reproduce
No response
Debug information
No response
Operating systems
No response
Checklist

[X] I updated to the latest version of the plugin.

Duplicate of #104, the fix for this will be released in an upcoming version.


Allow non-admin to access preferences

Issue
#306
Addresses # (issue)

[x] This change addresses the issue in full
[ ] This change addresses only certain aspects of the issue
[ ] This change is a dependency for another issue
[ ] This change has a dependency from another issue

Description
Allows non-admins to pull listing preference data.
Also makes the preference page more resilient to failures by avoiding an infinite rendering loop if there's an error fetching preferences, and failing to load if there's an error.
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Prototype/POC (not to merge)
[ ] This change is a refactor/address technical debt
[ ] This change requires a documentation update
[ ] This change requires a SQL Script

How Can This Be Tested/Reviewed?
Log in as a non-admin and try to edit listing preferenes. Notice how the page doesn't freeze. :)

[x] Desktop View
[ ] Mobile View
[ ] Test A
[ ] Test B

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have reviewed the changes in a desktop view
[ ] I have reviewed the changes in a mobile view
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have assigned reviewers
[ ] I have updated the changelog to include a description of my changes

Working on fixing the tests


Try to be more precise when type mismatches occur

I don't know how unification works exactly, so this may be too much to ask. But, say you take this example:
x = 1
y = "hello"

z = x + y

which yields this error message:
-- TYPE MISMATCH --------------------------------------------------------------

This expression is triggering a type mismatch.

3|
4| z = x + y
5|     ^^^^^

To be more specific, as I infer all the types, I am seeing a conflict between
this type:

   number

and this type:

   String

which is a great error message. But is it possible to actually tell which of x or y is the number or the string. Like, say something like:
-- TYPE MISMATCH --------------------------------------------------------------

This expression is triggering a type mismatch.

3|
4| z = x + y
5|     ^^^^^

It would seem that you called

(+) : number -> number -> number

with

x : number

and

y : String

I made some tweaks that make it pretty easy to add hints to certain constraints for a relatively low cost. Turns out this was pretty easy to do! Here's the new message:
-- TYPE MISMATCH --------------------------------------------------------------

The right argument of (+) is causing a type mismatch.

3|
4|     x + y
5|         ^

To be more specific, as I infer all the types, I am seeing a conflict between
this type:

    number

and this type:

    String

Is it difficult to provide even more context? I feel like Hassan's example with y : String and the type signature of (+) was pretty much ideal, but not sure how much harder that is than this.

@rtfeldman, that is significantly harder. I am able to give contextual hints about subregions, but I don't have a way to hint about specific types that have been inferred. This would help with normal function application as well. I think this can be a separate issue.
@TheSeamau5, the improvement should be live on the 1234 site.

:+1: Makes sense!

Yay! thanks!


⚠ ClamAV has degraded performance

In d0c5d03, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 246 ms

Resolved: ClamAV performance has improved in c778b9d.


Add a rule to check OpenSearch Dashboards capitalization

What changed, and why it matters
After the fix from @tvainika in #270, add a rule to make sure that the linter catches this if it happens again

#273 will fix the build error, merge that first


Kserve with TorchServe Performance is very slow compared to standalone

There is a noticeable performance difference when running StandAlone Torchserve and Kserve with TorchServe.
The difference in performance is 8:1 where Standalone Torchserve with just Kserve V2 Service Envelope performs 8 times better than routing requests to TorchServe through Kserve Model Server.
Is the performance difference as expected?
Could someone help with the ideal setup scenarios to get the best performance when running Torchserve with Kserve?

@gavrishp Can you create an issue under pytorch/serve as the code is maintained there not in kserve repository.

Related issue I created for suggesting remove the kserve model serve routing layer
https://github.com/pytorch/serve/issues/2373

@yuzisun For serving torch models in production what would you suggest is the ideal approach would be using kserve or any other native framework?

@yuzisun For serving torch models in production what would you suggest is the ideal approach would be using kserve or any other native framework?

Which version of KServe you are using  and if you can share the inference service yaml?

Using Kserve 10.1
yaml template
apiVersion: "serving.kserve.io/v1beta1"
kind: "InferenceService"
metadata:
  name: "<name>"
  namespace: "<namespace>'
  annotations:
    "sidecar.istio.io/inject": "false"
    autoscaling.knative.dev/scale-to-zero-pod-retention-period: "5m"
spec:
  predictor:
    minReplicas: 1
    containers:
    - name: "kserve-container"
      image: "<image>"
      resources:
        limits:
           cpu: {{ .Values.n_cpu }}
           memory: {{ .Values.memory_limit }}
           nvidia.com/gpu: {{ .Values.n_gpu }}

Right now we are experimenting by using standard vision models as a base. Goal is to run custom containers with torch nlp and vision models.

@gavrishp I am confused, this is not torchserve but custom container?

In the image section, setting "pytorch/torchserve:latest-gpu".
This way I can run torchserve on a custom container without the kserve wrapper in it.

In the image section, setting "pytorch/torchserve:latest-gpu". This way I can run torchserve on a custom container without the kserve wrapper in it.

That's what I guessed, smart !

In the image section, setting "pytorch/torchserve:latest-gpu". This way I can run torchserve on a custom container without the kserve wrapper in it.

That's what I guessed, smart ! Are you able to get batching working with kserve in that case ?

That's what I guessed, smart ! Are you able to get batching working with kserve in that case ?
Thanks! :) I noticed the torchserve batching does not work whenever Kserve v1, v2 is used.

Particularly here, they tend to pick only the first item in the batch for processing.
https://github.com/pytorch/serve/blob/master/ts/torch_handler/request_envelope/kserve.py#L27
https://github.com/pytorch/serve/blob/master/ts/torch_handler/request_envelope/kservev2.py#L116
Throws an error when batching value is set more than 1. Looks like another feature request?

That's what I guessed, smart ! Are you able to get batching working with kserve in that case ?

Thanks! :) I noticed the torchserve batching does not work whenever Kserve v1, v2 protocol is used directly by hitting the Netty server.
Particularly here, they tend to pick only the first item in the batch for processing. https://github.com/pytorch/serve/blob/master/ts/torch_handler/request_envelope/kserve.py#L27 https://github.com/pytorch/serve/blob/master/ts/torch_handler/request_envelope/kservev2.py#L116
Throws an error when batching value is set more than 1. Looks like another feature request?

Missing feature! Let's definitely create an issue in pytorch/serve and we can discuss in the meeting.


Changed LoginForm and UserInfo

Changed LoginForm and UserInfo, now they will use the API for the login and retrieve the user information

Pinging the sgt @effepielle since it hooks to security


Typo #01 in CSS lesson 09. Spellcheck

Hello team,
I would like to report a typo in this page.
The sentence Three common ways to align text is should be replaced with Three common ways to align are.
The context suggests that the sentence is about the three common ways to align text.
Please see the attached image for more context. 👇

+2 complete! https://github.com/codedex-io/curriculum/commit/e0f357097f0b8789227d8338dd0dc235585f7648


by a semantic version constraint matched against a Composer dependency not working

The "by a semantic version constraint matched against a Composer dependency" approach does not work. We receive the following output:
 ------ ---------------------------------------------------------
  Line   packages/site_codappix/ext_localconf.php
 ------ ---------------------------------------------------------
  10     Package "typo3/cms-core" is not installed via Composer.
 ------ ---------------------------------------------------------

I tried to debug via xdebug and it looks like the !InstalledVersions::isInstalled call is heading to phpstan phar version and its own packages composer dependencies instead of the actual project dependencies.

thanks for reporting. it works in my tests as expected.
could you create a small reproducing repo? It might be something specific to typo3

Thanks for your fast response, and sure: https://github.com/DanielSiepmann/phpstan-todo-by-issue-52
I broke our setup down to the minimum. It seems the issue is caused by typo3/minimal dependency.
Removing that dependency removes the issue.
So not really related to TYPO3 I guess, but to metapackages in general? I'm not too deep into this topic.

thanks for the repro. as soon as typo3/minimal is removed from the repro it starts to work. it seems one of the dependencies is fiddling with autoloading

I could further reduce to only include typo3/cms-core and typo3/cms-backend.

I think it will be fixed with https://github.com/staabm/phpstan-todo-by/pull/54 - I need a proper automated test for staabm/phpstan-todo-by to land it though.
could you work on thatß

fix released in https://github.com/staabm/phpstan-todo-by/releases/tag/0.1.17

Thank you very much for such a fast fix.
I'll give it a try tomorrow and only respond if we still have issues :)


Tic Tac Toe Game (HTML, CSS, JS)

To create an issue, edit this template to fill your details as well as describe your issue and then post it.
add 'x' to the relevant to define you

[x] Hacktoberfest Participant
[x] Contributor

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

I want to add a CSS and JavaScript-based project to this repository. The project is called Tic Tac Toe game.
Kindly assign this issue to me. Thank you😊

sure!


Document Get() returns Error with 404 status and nil *GetResult

Please use the following questions as a guideline to help me answer
your issue/question without further inquiry. Thank you.
Which version of Elastic are you using?
[ ] elastic.v2 (for Elasticsearch 1.x)
[ ] elastic.v3 (for Elasticsearch 2.x)
[X] elastic.v5 (for Elasticsearch 5.x)
[ ] elastic.v6 (for Elasticsearch 6.x)
Please describe the expected behavior
I was expecting a GetService Get() request that does not find a Document to follow similar semantics outlined for the Elastic Java client (https://www.elastic.co/guide/en/elasticsearch/client/java-rest/6.0/java-rest-high-document-get.html#java-rest-high-document-get-response), specifically "Note that although the returned response has 404 status code, a valid GetResponse is returned rather than an exception thrown. Such response does not hold any source document and its isExists method returns false.".
Please describe the actual behavior
A Get() on a Document ID that does not exist returns an error with status 404 and a nil *GetResult, rather than setting GetResult{Found: false}.
Any steps to reproduce the behavior?
I'm mostly curious if this is by design or an unintended divergence from what Elastic's Java REST client does. If this is the intended behavior, is the suggested route to us IsNotFound(), or directly use PerformRequestWithOptions to ignore 404 errors or another approach?

Hmm... we had that in #754 a while ago. Seems like there's a difference between the low-level Java client and the high-level Java client. Maybe something changed on the server-side between then and now?
I'm afraid I cannot change the behavior between minor versions as that would be a breaking change. So the only chance we have is to change the behavior with 7.x.

OK, thanks for letting me know. It might be use to update to example in the docs as it seems to imply the Found field used:
From the example in the docs:
// Get tweet with specified ID get1, err := client.Get().     Index("twitter").     Type("tweet").     Id("1").     Do(context.Background()) if err != nil {     // Handle error     panic(err) } if get1.Found {     fmt.Printf("Got document %s in version %d from index %s, type %s\n", get1.Id, get1.Version, get1.Index, get1.Type) }

@andrew-leung Thanks. I've update the example code.


[bug] Inserting Div resets text to be center aligned

Describe the bug
When inserting a new div into the page, text is rest to be center aligned instead of the left aligned chosen previously.
The undo buttons dont undo this change either, they do undo the insertion of the div but the text remains center aligned.

@winslet , is the expected behavior in this case for text alignment to adhere to the parent's configuration?

Hmm I just closed and restarted Onlook and I cant seem to replicate the bug any longer - im going to try and grab you a screencap of the problem.
But yes - when inserting a new div, then I would expect the text to remain with its current settings.

 I'll close this issue for now.

I see. That's weird. Please let me know if it resurfaces :)


ml_get errors;

Vdebug 2.0.0  @ 2ebf27b1ffb6752f0ba6cf4ec6be0a7498897d48
I'm trying to figure out how to reliably reproduce this issue, but there seems to be a problem in management of the DebuggerStatus window. At some point, Vdebug enters a state where any command triggers errors akin to this:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/bdoherty/.vim/bundle/vdebug/python3/vdebug/debugger_interface.py", line 47, in run
    self.session_handler.run()
  File "/Users/bdoherty/.vim/bundle/vdebug/python3/vdebug/session.py", line 65, in run
    self.listen()
  File "/Users/bdoherty/.vim/bundle/vdebug/python3/vdebug/session.py", line 42, in listen
    self.start_listener()
  File "/Users/bdoherty/.vim/bundle/vdebug/python3/vdebug/session.py", line 49, in start_listener
    self.ui().set_status("listening")
  File "/Users/bdoherty/.vim/bundle/vdebug/python3/vdebug/ui/vimui.py", line 170, in set_status
    self.windows.status().set_status(status)
  File "/Users/bdoherty/.vim/bundle/vdebug/python3/vdebug/ui/vimui.py", line 634, in set_status
    self.insert("Status: %s" % str(status), 0, True)
  File "/Users/bdoherty/.vim/bundle/vdebug/python3/vdebug/ui/vimui.py", line 460, in insert
    lambda: self.command(lineno))
  File "/Users/bdoherty/.vim/bundle/vdebug/python3/vdebug/ui/vimui.py", line 345, in insert
    self._buffer[:] = remaining_buffer
vim.error: Vim:E315: ml_get: invalid lnum: 81

Where the error is always about ml_get caused by set_status
The only way I can stop this from happening is to restart vim.

Closing this as it seems to be a bug in vim rather than this plugin.

Thanks for the info. Really appreciate it.

I just updated vim to 8.1.350 and the problem has not reproduced. Great work on the plugin!

Reopening this as I'm still encountering it frequently. Once I figure out a reliable reproduction method, I will share it.

I also that there can be some improvement about window management. Especially as the vim python bindings offer a class for buffers and windows and tabs and so on but we keep our own ids around.  But then again that would be a major rewrite of window management of vdebug so it seems like a lot of work...

Yeah, it's definitely a big chunk of work, but I'm encountering frequent bugginess around that, and I think it'd be worth the investment. It looks like it's really a matter of using the [:] = [] python expression on a hidden buffer, so maybe it's as simple as ensuring that the buffers aren't hidden when that happens, though I do think it's more of a vim-level issue

@bendoh ml_get errors, are you having these on Linux, Mac or Windows

I just updated to d3d1672 with @lucc's changes, and it's pretty broken. The windows don't appear in the right place at all. Did this get tested?
My issues occur on a mac, with the following vim:
 % vim --version
VIM - Vi IMproved 8.1 (2018 May 18, compiled Sep  6 2018 13:43:23)
macOS version
Included patches: 1-350
... +python3 -python ...

This problem frequently occurs when I'm using my php testing tool along with Vdebug, where I often hide the various Debugger buffers during a session to navigate the code. Subsequent invocations of Vdebug cause this problem repeatedly until I can reset its state or just restart vim.
I suspect the problem here is mostly to do with a failure to detect when buffers have been hidden, because the windowing code switches between instances of HiddenBuffer, where the buffer is just a string, and VimBuffer, where it appears to be tied to an actual buffer object. This is where the bug occurs: when the VimBuffer actually refers to a hidden buffer, and assignments to _buffer[:] trigger the ml_get issue because that operation is invalid on a hidden buffer (though, imho, it shouldn't be!)
Possibly related, if I start a debugging session, and then go to one of the Debugger buffers, and attempt to delete it, I get a pretty bleak message:

Error detected while processing BufWinLeave Autocommands for "DebuggerStack":
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/Users/bdoherty/.vim/bundle/vdebug/python3/vdebug/debugger_interface.py", line 101, in mark_window_as_closed
    self.session_handler.ui().mark_window_as_closed(window)
  File "/Users/bdoherty/.vim/bundle/vdebug/python3/vdebug/ui/vimui.py", line 105, in mark_window_as_closed
    self.windows.window(name).mark_as_closed()
  File "/Users/bdoherty/.vim/bundle/vdebug/python3/vdebug/ui/vimui.py", line 441, in mark_as_closed
    self.destroy()
  File "/Users/bdoherty/.vim/bundle/vdebug/python3/vdebug/ui/vimui.py", line 495, in destroy
    vim.command('bwipeout %s' % self.name)
vim.error: Vim(bwipeout):E937: Attempt to delete a buffer that is in use

If I go to the DebuggerLog window and load DebuggerStack buffer instead, I start getting the ml_errors, too. There's definitely some funkiness in tracking the windows. I don't think it's too bleak to figure out, but it might require rewriting parts of the UI file.

Something went wrong there, the python cleanup changes were resetted


langchain_aws/llms/bedrock.py "stop_sequence" hardcoded for msg_type == "message_delta" - breaks with bedrock guardrails with langchain agents

Hello,
In langchain_aws/llms/bedrock.py the "stop_sequence" hardcoded for msg_type == "message_delta" -
Shouldn't this be captured using the LLM provider type with self._get_provider()
This breaks integration with bedrock guardrails and langchain agents when guardrails intervene

 elif msg_type == "message_delta":
            return AIMessageChunk(
                content="",
                response_metadata={
                    "stop_reason": stream_response["delta"]["stop_reason"],
                    **"stop_sequence": stream_response["delta"]["stop_sequence"],**
                },
            )

If there are any workarounds for this fix please let me know. adding a stop_sequence key name map works for other issues but not in this case, when guardrails intervene and enter the msg_type == "message_delta" block
llm.provider_stop_sequence_key_name_map = {'anthropic': 'stop_sequences',
                                                            'amazon': 'stopSequences',
                                                            'ai21': 'stop_sequences',
                                                            'cohere': 'stop_sequences',
                                                            'mistral': 'stop'}


Do you need to exclude customers with no repeat purchases before fitting the bg/nbd model?

Do you need to exclude customers with no repeat purchases before fitting the bg/nbd model?
I have come across many different tutorials where the bg/nbd model is fitted to RFM data created using lifetimes.utils.summary_data_from_transaction_data(). Some of the tutorials claim that you must: "exclude customers for which we have no repeat purchases, i.e. frequency or frequency_cal is 0. The Pareto/NBD and BG/NBD models we will use focus exclusively on performing calculations on customers with repeat transactions. "
Whereas other tutorials do not perform that filtering. In additon, I cannot find any mention of the from article "Counting Your Customers” the Easy Way: An Alternative to the Pareto/NBD Model"
Does anyone now what the correct way is?

Hey @blackswanafrag,
lifetimes was deprecated 4 years ago; pymc-marketing is the successor project:
https://github.com/pymc-labs/pymc-marketing
To answer your question, non-repeat customers are only excluded when fitting a Gamma-Gamma Model. The Pareto/NBD and BG/NBD models will not converge if non-repeat customers are excluded due to the underlying statistical assumptions, but after the GGM has been fit, it can be used to run predictions for the full dataset, including non-repeat customers. Hope this helps.

Thanks @ColtAllen, I will have a look. Could you please develop a bit on the underlying statistical assumptions that says that the model should be fit on non-repeat customers as well? The tutorials claiming that the model should not, does not provide any explanation to their claim. I guess they may have miss understood the model or confused it with GGM?

Could you please develop a bit on the underlying statistical assumptions that says that the model should be fit on non-repeat customers as well?

Every BTYD model is built around a transaction process that is conditional on an unobservable dropout process (i.e., customers keep making purchases until they "die"). The choice of statistical process for either is what defines the model. Both the BG/NBD and Pareto/NBD models assume the time between transactions is exponentially distributed, but differ in the dropout assumptions. Although these models are fit to the number of repeat transactions per customer, the dropout processes still assume and allow for one-time customers, because they are prevalently common in practice. Completely excluding them from the dataset will violate this assumption as well as reality.
To be honest, there aren't many sources out there that directly state this, because I discovered it while working on my first CLV project. I tried excluding non-repeat customers and could not get a working model. To complete the project I actually forked this library and took over its development, before merging efforts with the pymc-marketing project.

Thanks for the good and elaborate answer!

@ColtAllen Do you know if the latest version of lifetimes in pip is still valid and gives reliable CLV predictions? Or did you find any bugs that you addressed and fixed when merging in to the pymc-marketing project?

The lifetimes models themselves are still able to reproduce results in research, and reliable enough to use for unit testing during development.
The two most significant bugs in lifetimes are that monetary values in calibration_and_holdout_data aren't aggregated properly, and vague scipy errors are sometimes raised due to the array-based user API.
The first bug has been fixed:
https://github.com/pymc-labs/pymc-marketing/pull/572
The second one as well, but we're currently upgrading the user-facing API. At this time only ParetoNBDModel has the latest version:
https://www.pymc-marketing.io/en/stable/notebooks/clv/pareto_nbd.html
We've also improved the likelihood function of both models for more stable and reliable model fitting:
BG/NBD
Pareto/NBD


Alerts and Dialogs

Modals, Alerts, Dialogs.... all need added.

Adding components is so easy and work well i think there's no need to implement the other native dialogs (alerts, date/time pickers, etc,).


Terminal in connecting...

Describe the bug
A clear and concise description of what the bug is.
When open a terminal on windows 10 machine

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Environment (please complete the following information):

Lens Version:
OS: [e.g. OSX]
Installation method (e.g. snap or AppImage in Linux):

Logs:
When you run the application executable from command line you will see some logging output. Please paste them here:
error: [SHELL-SESSION]: failed to open a local shell Error launching WinPTY agent: Security check failed: pipe client pid (6940) does not match agent pid (18204) {"stack":"Error: Error launching WinPTY agent: Security check failed: pipe client pid (6940) does not match agent pid (18204)\n    at new WindowsPtyAgent (C:\\Users\\ChandraSekharMallu\\AppData\\Local\\Programs\\Lens\\resources\\app.asar\\node_modules\\node-pty\\lib\\windowsPtyAgent.js:83:36)\n    at new WindowsTerminal (C:\\Users\\ChandraSekharMallu\\AppData\\Local\\Programs\\Lens\\resources\\app.asar\\node_modules\\node-pty\\lib\\windowsTerminal.js:51:24)\n    at spawn (C:\\Users\\ChandraSekharMallu\\AppData\\Local\\Programs\\Lens\\resources\\app.asar\\node_modules\\node-pty\\lib\\index.js:29:12)\n    at C:\\Users\\ChandraSekharMallu\\AppData\\Local\\Programs\\Lens\\resources\\app.asar\\node_modules\\@lensapp\\core-main\\dist\\index.js:3982:17\n    at getOrInsertWith (C:\\Users\\ChandraSekharMallu\\AppData\\Local\\Programs\\Lens\\resources\\app.asar\\node_modules\\@lensapp\\utilities\\dist\\index.js:697:19)\n    at ensureShellProcess (C:\\Users\\ChandraSekharMallu\\AppData\\Local\\Programs\\Lens\\resources\\app.asar\\node_modules\\@lensapp\\core-main\\dist\\index.js:3979:69)\n    at Object.openShellProcess (C:\\Users\\ChandraSekharMallu\\AppData\\Local\\Programs\\Lens\\resources\\app.asar\\node_modules\\@lensapp\\core-main\\dist\\index.js:3997:42)\n    at async C:\\Users\\ChandraSekharMallu\\AppData\\Local\\Programs\\Lens\\resources\\app.asar\\node_modules\\@lensapp\\core-main\\dist\\index.js:4132:7"}

Kubeconfig:
Quite often the problems are caused by malformed kubeconfig which the application tries to load. Please share your kubeconfig, remember to remove any secret and sensitive information.
your kubeconfig here

Additional context
Add any other context about the problem here.

Hello cherry-koerber,
Thank you for reaching out to Lens support!
Thank you for reporting a bug.
We are working on your issue. Stand by for further updates.
Best Regards,
Tikhon Kudinov
Lens Support Engineer
Mirantis, Inc


Prevent form from submitting when pressing Enter on input

Cannot you instead making sure that onSubmit has the same effect than clicking on the button?

@xdamman onSubmit now has the same effect as clicking on the butotn

Awesome. Thanks!


[AI API] API download and export/import related errors

Description
The downloaded and exported (using APICTL) AI API contains an encrypted value as the key under api.yaml file.
    endpoint_security:
      sandbox:
        apiKeyValue: <encrypted value>

When trying to import the exported AI API using APICTL, we are trying to encode this key value assuming that it is not already encrypted at [1].
We need to fix this behavior so that either we export an un-encrypted value, so that import will work as is. If not, we have to export an encrypted value and import flow should assume the value that is being passed is already encrypted.
[1] https://github.com/wso2/carbon-apimgt/blob/master/components/apimgt/org.wso2.carbon.apimgt.rest.api.publisher.v1.common/src/main/java/org/wso2/carbon/apimgt/rest/api/publisher/v1/common/mappings/PublisherCommonUtils.java#L1147-L1148
Steps to Reproduce

Create, deploy and publish an AI API
Download the API using either or both of these options:

Download the created API using the Publisher portal UI
Also exported the created AI API using APICTL

Attempt to import the AI API using either or both of these options:

Import using API import REST API
Import AI API using APICTL

Affected Component
APIM
Version
4.4.0

This is the expected behavior


Operating MTV with non-cluster admin users

MTV 2.5
Resolves https://issues.redhat.com/browse/MTV-431 by:

Adding information describing the differences between what admins and non-admins can see and do in MTV
Discussing permission set options for non-admins

Previews:

https://file.emea.redhat.com/rhoch/non_admin/html-single/#admins-and-non-admins [Section 4.1 and 4.1.1]
https://file.emea.redhat.com/rhoch/non_admin/html-single/#non-admin-permissions_cli  [Section 5.1]

@ahadas Please review.

@ahadas @qiyuann Please review.


updated StratisBitcoinFullNode submodule to master 1.1.14

No need for this as we can have a newer latest version.


PF: Fix kite logo for OSX

Description of Changes
Before

After

[x] Included a screenshot or animation (if affecting the UI, see Licecap)

The kite logo was being scaled as a pixmap and then passed to the icon which would distrot the icon for scale factor that did not adjust to specific ratios. I edited the Kite logo images (in SVG) so that the image includes a padding, like most of the Font Awesome icons. I based the size to 16 and left a padding of 1, which results in a kite logo of 14px (effective) height. This removes the need to pass a custom scale factor, and since the icon is used as is, it does not get distorted.
As an extra for this PR I removed the padding o the layout between icons and text which results in a better UI and reduced status widgets total width.
Issue(s) Resolved

Fixes #10442
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @goanpeca

@goanpeca, could you describe what was the previous problem?

Updated

Maybe we need to decrease a little bit the height of the icon (leaving some space between the image itself and the canvas vertically)

The image is now a 16x16 and the actual Icon is occupying 14px. With the previous scale factor it was 13.6px, so this is close enough and already has the padding you suggest @dalthviz.
Or are you asking for something different 🙃 ?

Basically that's it, yep. It looked for me a little bit bigger that's all. Besides that this LGTM :+1:

It looked for me a little bit bigger that's all.

Yes, it is 0.4 px bigger :-p. Sharp eye ;-)

Failing tests are unrelated


FilePickerUploader bugs fixed

folder combobox should change automatically when folder path is set
prevent to change folder combobox, while "UsePersonalFolder" is true
set file combobox filters on preRender. (onload happen too soon, so action links can not change filters!)
Note: dumb git detect so many changes because of CRLF  :|

Before we can process this pull request, we need an associated Jira so that the QA team has a good description of the problem that is trying to be resolved.  Optimally the Jira would include a description of the steps needed to reproduce the error, the expected behavior and the actual observed behavior which is in error.
You can log the issue at https://dnntracker.atlassian.net

https://dnntracker.atlassian.net/browse/DNN-8223

Hi @Yeganloo , can you please add detail information on JIRA to clarify whats the issue you want to resolve, and how to reproduce the issue. this can make great help for us to review the changes and QA team verify whether  the changes really resolve the problem. thx so much!


Examples of Protein residue mutation?

Dear TIES developers,
I would like to setup some FEP simulations for a protein-peptide system where I mutate a residue of the peptide. This seems similar to TIES-PM (https://doi.org/10.1021/acs.jctc.8b01118), except the mutation is in the peptide ligand. The examples only include small molecule ligand modifications. Are point mutations of proteins also possible with this version of TIES?
It would be really great if you can share a small example of how to do this.
Best,
Amin.

Hi Amin,
Sorry for the slow reply. We have a separate workflow for proteins, since they are larger it can be harder to compute the hybrid structure. We would be happy to share with you the scripts needed for protein mutations if you would like?
We have only tested the code in this GitHub repo with small drug like molecules but depending on the size of the peptide it could work. Do you have any details you could share about the system size or maybe an example system we could help you get working?
Cheers,
Alex

Thanks a lot for your response and sorry for my delayed reply.
The system I am trying to study is around 300 residues long protein and a 14 residue long peptide.
I would like to mutate a single residue of the peptide at a time to estimate the change in affinity.
I would be really thankful if you can share the scripts. I can try them on my system and report back the results.
Thanks,
Amin.

Sure no problem, my colleague @apbhati1 can send through the scripts shortly.
A 14 residue long peptide might also be small enough to use the code in this repo. @bieniekmateusz could you please comment on if TIES 20 will work with a 14 residue long peptide?
Cheers,
Alex

14 residue might be just about the limit of what our superimposition can do, but I would expect it to take around 30 minutes. Thanks, Mat


Browser self-test

Add a background component to run a self-test for running the ARENA to determine if the user may have performance issues due to system load, browser, OS, hardware, or network. It could be done quickly before trying to render a scene so that we can pause and warn the user of potential performance issues giving them a list of features to possibly disable. User decisions may be situational.

Capturing earlier discussion.:
Video games have long set expectations of system performance requirements. Unfortunately we have no box to put them on, but it could be a system test somewhere up front like Setup A/V, with a set of checks, maybe a collapsed by default check like the Github Actions
There may also be much more aggressive QoS knobs that might help.  Like don’t load any background models before dropping straight to flat jitsi interface.

Added health check system in https://github.com/conix-center/ARENA-core/pull/349.


feat!: drop React 17 support

@pcattori & @ryanflorence mentioned in #7021 that we would do this

In order to support optional entry files and npx remix reveal - we had some logic in @remix-run/dev that detects the react version and uses/outputs react 17/18-compatible versions of entry.server/entry.client.  I removed all of that in 399f697 now that everything is react 18 + streaming.


[Docs] Sort the widgets alphabetically in the widget-reference section

Describe the problem
The widgets need to be listed alphabetically in the summary section of the documentation

hi @Nikhil-Curefit , will you be working on this issue yourself? If not, can I take this up as part of Hacktoberfest?

@JoelLau I'm not! Please take this up!

@JoelLau I don't see a PR raised for this issue so I'm unassigning you. Feel free to come back to this when you have the time :)

Can I pick this up @JoelLau ?

hey sorry, things got a bit crazy at work. please go ahead and re-assign this issue to someone else. thanks for asking @snehal199 !

@snehal199 It's all yours! 🎉
Please don't forget to read the Contribution Guidelines. Would appreciate if you can open a PR within the next 2 days.
Also, check out the Appsmith Challenge where you can win some cool swag by inviting your friends to contribute to this project as well.

Thanks @mohanarpit ! Will start working on the issue right away :smiley:


feature request: make scipy.stats.pearsonr accept 2-D arrays

I'd love to see scipy.stats.pearsonr modified to allow 2-D arrays to be passed, with one column per variable and one row per observation.  The output would be a pair of 2-D arrays--one for the Pearson correlation coefficient and one for the p-value.  Currently, obtaining something like this requires a pair of nested loops, with scipy.stats.pearsonr being called once for each pair of variables.

I know this is probably no more relevant for you, but maybe it could help someone else.
you can convert your data to a pandas dataFrame, and apply the function pandas.DataFrame.corr with parameter method='pearson'. https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.corr.html
The only (regrettable) difference is that this function does not return p-val.

I still do such tests.  Thank you!

At some point @swallan or @DominicChm might be vectorizing mannwhitneyu to respond to gh-12837; perhaps this would be a good follow-up.

@Phillip-M-Feldman would gh-13312 close this issue, from your perspective? It allows pearsonr to process nd-arrays, but it is just for convenience, not speed.

This sounds fine.
On Wed, Dec 30, 2020 at 6:00 PM Matt Haberland<EMAIL_ADDRESS>wrote:

@Phillip-M-Feldman https://github.com/Phillip-M-Feldman would gh-13312
https://github.com/scipy/scipy/pull/13312 close this issue, from your
perspective? It allows pearsonr to process nd-arrays, but it is just for
convenience, not speed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/scipy/scipy/issues/9307#issuecomment-752815827, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAIEDRF5EVUKOL5FJBVKYJTSXPLNLANCNFSM4FW7T5RQ
.

I don't think gh-13312 would address this as requested, actually. I think the request is for it to work more like spearmanr, which is an oddball in terms of the way it's vectorized.

On the other hand, if the decorator in gh-13312 were applied to this function, I think the user could achieve the desired behavior by passing in arrays of shapes (n_var, 1, n_obs) and (1, n_var, n_obs) and taking the statistic along the last axis.

@tirthasheshpatel @tupui thought you might be interested in this one as we try to make the stats interface more consistent. We might think that pearsonr should be vectorized like spearmanr, as they are both correlation functions. But the behavior of spearmanr (and np.corrcoef) is unusual:
from scipy.stats import mannwhitneyu, spearmanr
x = np.random.rand(3, 10); y = np.random.rand(3, 10)
mannwhitneyu(x, y, axis=1).statistic.shape  # (3,)
spearmanr(x, y, axis=1)[0].shape  # (6, 6)

It does pairwise comparisons between every row of x and y with every other row of x and y.
If we hope to make the scipy.stats interface more consistent, I think we'd want it to be vectorized like essentially other function; e.g.
pearsonr(x, y, axis=1)[0].shape  # we would want (3,), not (6, 6)

If the user wants to do pairwise comparisons, then they can do:
z = np.concatenate([x, y], axis=0)
pearsonr(z[:, np.newaxis, :], z[np.newaxis, :, :], axis=2)[0].shape

What do you think?
What do we do about the existing behavior in spearmanr? Leave it alone? Deprecate the 2D behavior then replace it, or create a new function and deprecate the old one?

@tirthasheshpatel @tupui @Kai-Striega what do you think? Shall we get the deprecation in before 1.9.0 branches so we can vectorize these consistently?

#1924 #625  I think pearsonr should essentially behave like np.corrcoef + pvalue
https://github.com/scipy/scipy/pull/16133#issuecomment-1120223399

Which other functions in stats do you think should behave that way? Or would spearmanr and pearsonr be the only exceptions to the usual system?

kendalltau would be the third correlation measure (pandas treats those 3 the same, AFAIR)
For example we can use those 3 to define elliptical copulas, kendalltau is also commonly used for bivariate copulas where we only need a single correlation/dependence coefficient.
However, kendalltau is not "naturally" vectorized
For statsmodels, I have an old PR with few more outlier robust cov/corr functions.
More general it would be relevant for all pairwise dependence/distance/association measures.
It also depends a bit on the common usecase:
cov, corr and it's variant are very often (or mostly) multivariate measures with the corresponding matrix returns.
For kendalltau and spearmans rho, scipy is the main package for the descriptive statistics, p-values are most of the time a bonus feature.
Hypothesis test functions are mainly for one, two or k- sample cases, with e.g. possibly vectorized (stratified) two-sample case.
Multiple testing like all pairwise comparisons are usually treated as a separate issue, and can be implemented for the specific multiple contrasts like in tukeyhsd. or multiple comparison to a control.
I would not treat those test functions as matrix/multivariate function because that is a special case extension that does not dominate the usage.

another distinction
Most of the 2-sample tests assume independent samples, there is no underlying multivariate structure. It's just comparing different independent samples. (correlation in tukeyhsd comes from the contrast of comparisons and not from the correlation of the underlying data).
In the multivariate cases like MANOVA, repeated measures ANOVA or general correlated samples we are back to having to handle the correlation across samples in a joint way.
example:
Testing equality of 2 correlations depends on whether they have one of the variables in common or not.
If we want to test more than two independent correlations, then it's better to go back to the matrix return of cov/corr/...

after another coffee break:
I get what I'ms saying boils down to whether a function is mainly for multivariate analysis or for analysis k (= 1, 2, 2) independent sample.
IMO, corr, cov, pearsonr, kendalltau and spearmanr are in the multivariate camp, the bivariate off-diagonal element is just a special case.

corr and cov are not in SciPy.
Because you did not mention them, shall we assume that pointbiserialr, weightedtau, linregress, and all the other "Correlation functions" should be vectorized as usual, and only perasonr, kendalltau, and spearmanr would get this special treatment?

I used corr and cov as generic term for any king of correlation or covariance measures
pointbiserialr is redundant and just for name recognition
The difference is that it has two different types in x and y, So I would think that the cross-correlation would be the most appropriate in the multivariate case.
I never looked at weightedtau, vectorizing to correlation matrix might not gain anything computationally compared to a loop and I have no idea about use cases
linregress is just used as single linear regression, nothing multivariate about it, If vectorization is available, then it can be in be parallel of separate cases.
I guess the same theil and siegel slopes (I never used them)
I don't know how 2-d sommersd works, My scipy version is too old
AFAIR, I have only seen sommersd and related measures in references that used it for 2 random variables (2 sample case).
I guess it's mainly for comparison of 2 multinomial samples. (2-d, r x s contingency tables)
I'm not sure what the main use cases for related higher dimensional contingency tables would be.
statsmodels has only stratified contingency tables as higher dim where the underlying structure is vectorization of independent sub-contingency tables.

(after another break)
I would put sommersd in a similar category as the correlations measures for ordinal association.
One possible multivariate extension would be to return an asymmetric association matrix with sommersd(x, y) in the upper (?) triangular matrix and sommersd(y, x) in the lower triangular matrix.
But that's purely theoretical, I've never seen a usecase like that. And I don't know if there are interesting followup analyses that would use it.


Update point-to-site-entra-vpn-client-windows.md

Removed Grammatical errors.

@cherylmc
Can you review the proposed changes?
Important: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#please-close