mugc traceback issue (from gitter)

Marcellus Easley - @marcelluseasley reported on gitter an issue that looks like something odd in mugc, needs research to confirm/fix.
13:22 yes here is a snippet of the traceback
13:06:23 File "/vendor/mugc.py", line 54, in resources_gc_prefix 13:06:23 funcs = list(manager.list_functions(options.prefix)) 13:06:23 File "/usr/local/lib/python2.7/site-packages/c7n/config.py", line 27, in getattr 13:06:23 raise AttributeError(k) 13:06:23 AttributeError: prefix mugc.py references the prefix attribute, but it was my understanding that prefix= is no longer supported

not sure how that's being invoked prefix is definitely supported for setting on lambdas and mugc reports, it i'm a little unclear how this traceback happened unless your using mugc as a library (as opposed to the normal cli usage),  @marcelluseasley  do you have the full traceback?


bootrom is known

LOL I was gonna open a pull request right now about that ;)

I'll be rewriting this entire page.

Why?

It was out of date. Removed and now just link to 3dbrew.


Issue #16: Fix the error on invocation by cargo toml-lint

This PR closes the #16 issue.
The original issue was that the Cargo.toml file was used as a positional argument, and the system was set to expect that. However, from my research, cargo plugins prefer either subcommands or flags. Thus, when we would type cargo toml-lint instead of cargo-toml-lint, it would consume toml-lint as the positional argument and complain about the Cargo.toml.
I have fixed that by doing two things:

Add a -t/--target option to the binary
Set Cargo.toml as a default value for the target option.

The result is that the arguments to the CLI are more consistent now and the UX is simpler as well (cargo toml-lint, instead of specifying the whole file path).
This has also been added to the README.
Signed-off-by: Ali Sajid Imami<EMAIL_ADDRESS>

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@alfiedotwtf Hey. Just bumping this up. I made the suggested changes and reverted the cosmetic issues. Thanks.


Goerli etherscan doesn't have ERC1155 route

Goerli Etherscan doesn't have the ERC1155 tx route.
This prevents that route getting needlessly called.
We should check from time to time if it starts working.

check from time to time

@JamesSmartCell can we abuse the test suite for this too? Like https://github.com/AlphaWallet/alpha-wallet-android/issues/3104. It’s the only way that survives any bus factor


Inconsistency between default X-Frame-Options and Content-Security-Policy

Hi
I was going to submit this as a PR, but I thought it’d be easier to just note this as an issue because I haven’t signed the CLA.
There appears to be inconsistency between the default values for Content-Security-Policy and X-Frame-Options. I'm not sure if this will cause any problems in how browsers interpret it (I don't think it should because of https://www.w3.org/TR/CSP2/#frame-ancestors-and-frame-options). However, it seems likely to cause developer confusion or live site issues when browsers fully remove support for X-Frame-Options (see https://www.chromestatus.com/features/6450843930853376) and are left allowing framing everywhere due to the lack of a frame-ancestors 'self'; directive.
Is this something you've thought about?
Hope this is helpful.
Stuart
PS: Great work on this library. I started creating the same thing on my commute this morning, but then when I came back online I noticed you’d already done it. Nice one!
PPS: I appreciate you likely have a legal department that has instructed the use of a CLA, but without a seamless online process for doing this it is likely to constrain open contribution to the library. For example, I would have happily submitted this as a code change to save you the work if it had been easier. (Of course, you’re still free to decide that it’s not in line with where you want to take the library). I hope this is received as constructive feedback.

firstly, wanted to apologize for the delay in responding.
secondly, i believe we may have (or soon will) a better CLA workflow, but haven't added it to this project yet. I'm investigating and will update this thread with any updates.

for your issue in particular, if i understand it correctly, the idea is to add frame-ancestors 'self'; to the CSP to do the following:

make the CSP policies consistent with the Frame Options in the current world
in the future, when Frame Options goes away, we maintain consistent behavior

is that correct?

lastly, glad to hear you find this bundle useful :)

following up on the CLA workflow, there's a simple, streamlined version where we're using HelloSign to get the CLAs signed. I'll update the READMEs.

Hi, thanks for responding.
Yes, you've summarised my comments correctly. My main concern is one of consistency. I think the default policy in both X-Frame-Options and Content-Security-Policy should be consistent with each other. What the values are set to is potentially open for debate - e.g. by default, I'm guessing most sites do not need framing at all and can therefore default to DENY and 'frame-ancestors: 'none'` - but I'm going on a bit of a tangent from the point now :-)


Implement helpers for certain useful/hard-to-type  operations

Such as margin, padding, display and visibility.

Margin and padding have been implemented already. I will now generalize them to eliminate code duplication. Also, I will implement display and visibility helpers soon.


another seg fault issue

sorry..
step 1. binary executes, results in help menu.
(scaff10x) [macmanes@premise genome]$ scaff10x
Program: scaff10x - Genome Scaffolding using 10X Chromium Data
Version: 4.2

Usage: scaff10x -nodes 30 -longread 1 -gap 100 -matrix 2000 -reads 10 -score 20 -edge 50000 -link 8 -block 50000 -plot barcode_lengtg.png <input_assembly_fasta/q_file> <Input_read_1>> <Input_read_2> <Output_scaffold_file>
       nodes    (30)    - number of CPUs requested
       matrix   (2000)  - relation matrix size
       reads    (10)    - step 1 and 2: minimum number of reads per barcode
       link     (8)     - step 1 and 2: minimum number of shared barcodes
       read-s1 (8)     - step 1: minimum number of reads per barcode
       read-s2 (10)    - step 2: minimum number of reads per barcode
       link-s1  (8)     - step 1: minimum number of shared barcodes
       link-s2  (10)    - step 2: minimum number of shared barcodes
       edge     (50000) - edge length to consider for scaffolding
       score    (20)    - minimum average mapping score on a barcode covered area
       block    (50000) - length to determine for nearest neighbours
       longread (1)     - contigs were produced using PacBio or ONT reads
                (0)     - contigs were produced from short reads such as Illumina
       file     (0)     - do not output the sam file in order to save disk space
                (1)     - sam file from bwa is saved
       gap      (100)   - gap size in building scaffold
       sam      ()      - previously aligned sam file by bwa
       bam      ()      - previously aligned bam file by longrange
       plot     (barcode_lengtg.png) - output image file on barcode length distributions

step 2. seg fault with dat file
(scaff10x) [macmanes@premise genome]$ scaff10x -data reads.dat Neotomodon_alstoni_10x_v6.fasta Neotomodon_alstoni_10x_v7.fasta
Segmentation fault

here is the dat file
q1=/mnt/lustre/macmaneslab/shared/pero_genomes/Neotomodon_alstoni/reads/NEAL_S1_L006_R1_001.fastq.gz
q2=/mnt/lustre/macmaneslab/shared/pero_genomes/Neotomodon_alstoni/reads/NEAL_S1_L006_R2_001.fastq.gz

step 3. segfault with passing reads on the command line
(scaff10x) [macmanes@premise genome]$ scaff10x Neotomodon_alstoni_10x_v6.fasta ../reads/NEAL_S1_L006_R1_001.fastq.gz ../reads/NEAL_S1_L006_R2_001.fastq.gz  Neotomodon_alstoni_10x_v7.fasta
Segmentation fault

Hi Matt,
I have seen anything wrong here for the usage of the code. For any run of scaff10x, it produces a directory such as tmp_rununik_***** to process all the files. Could you tell me the contents in the directory, by doing "ls -lrt"?
Thanks,
Zemin

Sorry I haven't seen anything wrong.

It's empty:
(scaff10x) [macmanes@premise genome]$ ls -lthr tmp_rununik_165217
total 0

@zning-sanger, do you have a small test dataset I could use to make sure this it is not a problem with the installation?

Scratch that. I've identified the bug:
/mnt/lustre/macmaneslab/macmanes/Scaff10X/src/scaff-bin/scaff10x  /mnt/lustre/macmaneslab/shared/pero_genomes/Neotomodon_alstoni/genome/Neotomodon_alstoni_10x_v6a.fasta /mnt/lustre/macmaneslab/shared/pero_genomes/Neotomodon_alstoni/reads/NEAL_S1_L006_R1_001.fastq.gz /mnt/lustre/macmaneslab/shared/pero_genomes/Neotomodon_alstoni/reads/NEAL_S1_L006_R2_001.fastq.gz  Neotomodon_alstoni_10x_v234.fasta
File not in the working directory!
Input target assembly file1: /mnt/lustre/macmaneslab/shared/pero_genomes/Neotomodon_alstoni/genome/Neotomodon_alstoni_10x_v6a.fasta
File not in the working directory!
Input read1 file: /mnt/lustre/macmaneslab/shared/pero_genomes/Neotomodon_alstoni/reads/NEAL_S1_L006_R1_001.fastq.gz
File not in the working directory!
Input read2 file: /mnt/lustre/macmaneslab/shared/pero_genomes/Neotomodon_alstoni/reads/NEAL_S1_L006_R2_001.fastq.gz
sh: /mnt/lustre/macmaneslab/macmanes/Scaff10X/src/scaff-bin/scaff-bin/scaff_fastq: No such file or directory
Error running command: /mnt/lustre/macmaneslab/macmanes/Scaff10X/src/scaff-bin/scaff-bin/scaff_fastq -name tarseq -len 10 /mnt/lustre/macmaneslab/shared/pero_genomes/Neotomodon_alstoni/genome/Neotomodon_alstoni_10x_v6a.fasta tarseq.fastq tarseq.tag > try.out

See the path for scaff_fastq? It thinks it's in /mnt/lustre/macmaneslab/macmanes/Scaff10X/src/scaff-bin/scaff-bin/, there is an "extra" scaff-bin/ in the path. I'm guessing this is not intentional, but I can confirm when I make that directory and copy all the executables in there, that things seem to be working - at least I do not have the same seg fault.

Thanks Mat for the information. I don't know how you installed the package. I just did a test
$ git clone  https://github.com/wtsi-hpag/Scaff10X.git
$ cd Scaff10X
$ ./install.sh
By setting CC= /software/gcc-4.9.2/bin/gcc, it works on the test sample.
Let me know if you have further issues.
Thanks again,
Zemin


Compile problem on gcc for single precision

Compilation can not be executed on the gcc environments
I have just tried gcc -6.3.0, -8.2.0. The other environments are not available for me.
The error messages are the below:

${HOME}/OpenFAST/modules-local/servodyn/src/ServoDyn_Driver.f90:118:100:
   call SrvD_JacobianPInput( Time, u(1), p, x, xd, z, OtherState, y, misc, ErrStat, ErrMsg, dYdu)
                                                                                1

Error: Type mismatch in argument ‘dydu’ at (1); passed REAL(4) to REAL(8)
make[2]: *** [modules-local/servodyn/CMakeFiles/servodyn_driver.dir/src/ServoDyn_Driver.f90.o] Error 1

This pull requset is just for the safe compilation for single precision version of openfast.
I have not examined the reg-tests yes, but this modifications works fine for me.

Dear @NobuhiroKUSUNO,
I'm not really familiar with compiling with gcc (hopefully someone else can comment on that), but we can't approve this pull request based on my brief skim of your changes.  The choice of what KIND each REAL variable is declared as in OpenFAST (ReKi, R8Ki, SiKi, DbKi, or QuKi) was determined carefully based on consideration of the numerics each variable undergoes to ensure that the solution is accurate whether you compile in single or double precision.
Again, I'll let someone else comment on your issue associated with compiling OpenFAST unaltered with gcc.
Best regards,

Thank you for comments, @jjonkman.
I was afraid of the destroy of your careful choice of the precision.
I will think out another way to compile the single-precision OpenFAST.

@NobuhiroKUSUNO: I always compile OpenFAST in single precision (using Visual Studio/Intel Fortran), and do not get the kind of errors you are reporting. The error message you have says that the ServoDyn driver has an error. I think you could fix the problem with one line of code, which I have modified in https://github.com/OpenFAST/openfast/pull/161.

@bjonkman: I could compile OpenFAST  in single precision by GCC-8.2.0. Thanks!


Add missing ` to the end of two docstrings

Hi!
I believe two of your docstrings were missing trailing backticks :)

@teodorlu thank you!


[feat] Quests description links formatting

Currently, quest descriptions are completely static text.
This issue is to allow encoding links in the quest description of the format [link example](http://link-endpoint.com). So when displaying the quest description, links will be appropriately displayed and clickable to link to other locations.
References

Frontend quest descriptions

Thanks for volunteering for this issue @addegbenga
Please comment here so I can assign you, if you're still interested.

Ready to work on this.


update the docs list and default to 2.5.1

This change adds 2.5.1 to the available docs list and sets the default version displayed to 2.5.1

Added DO NOT MERGE until the release is finalized,


Update CSR Signers description

update the CSR Signers description, make it more readable.

/sig auth

@liggitt Applied suggestions from review, PTAL thanks.

/lgtm
/approve


update rst -> artifact

also: there was some whitespace after nuklear and my editor didn't like it :(

Thank you.


Assets not included

I have tested this plugin with vite default example. The assets are built in a dir in the dist folder. I also use
{ useRecommendedBuildConfig: true } but nothing change.
What am I missing? How can I get a single html file in the dist folder after build?

I don't know what you're missing. Please provide a reproducible issue and I'll be happy to look. Also, please check out this example and compare to your own setup:
https://github.com/richardtallent/vite-plugin-singlefile-example

Thanks for the replay,
It is very easy to reproduce my situation.
just
npm create vite@latest
and add single file plugin
npm run build.
There are still assets directory and a svg files that did not added into the single file.
Thanks

I think what @makerstorage is taking about is the limitation of not including images. Like, if you create an empty react app you will have something like this (with NO images):

I think the problem is here:

If you change (manually, of course) that src to ./assets/react-35ef61ed.svg (notice the dot at the beginning) images will load:

It would be great if this project could just use the base property of the build when something is not inlined (like images) so you can just configure it like build: "./" in the vite.config.ts. Obviously, I don't know if this is possible, but it seems that everything works perfectly with JS, but the problem is that images should be referenced with a relative path in order to make it work as a single html file with file protocol

That's what I am saying. Thanks for the clarification @JuanQP

Inlining of SVG isn't supported directly by Vite, so it isn't supported directly here either. You'll need to use something like https://github.com/jpkleemans/vite-svg-loader, or put your SVG directly into the template.

If it's more important to load the assets and having everything in a single file is not that important, have a look at this small plugin I've made and check if it suits your needs. I've used it with a few small projects I have without problems.
https://github.com/JuanQP/vite-plugin-make-offline

@makerstorage @JuanQP
Problem
Hi, I encountered exactly the same situation (Vite + React + vite-plugin-singlefile) and noticed that logos are not rendered correctly. I also noticed that even the official test project vite-plugin-singlefile-example would build a html that the favicon cannot be rendered on the browser tab in offline mode (check the console error).
Reason
The root cause is that static resources (such images like favicon.ico / *.svg / *.png, etc.) in public folder are copied to ${build.outDir} by Vite and not inlined by this plugin. However, as @makerstorage suggested, we CAN use relative paths for these not-inlined files.
Solution
In vite.config.ts,

Set base to './' to enable relative path.
We also need to change the build.assetsDir to '' to make Vite generated asset files (.js / .css) in ${build.outDir}'s root, instead of default ${build.outDir}/assets. Then Vite can put correct urls in these files, considering that our final HTML with inlined js / css is placed together with above copied static resources.

I fixed this and make it as the recommended build config (see PR #86 ). Before it's merged, you can set useRecommendedBuildConfig to false and apply above solution.
P.S.
In my version of Vite (5.0.11), if I put svg files in src/assets/, I can get them correctly inlined in the HTML source. So it seems like Vite now can inline SVG?

In my version of Vite (5.0.11), if I put svg files in src/assets/, I can get them correctly inlined in the HTML source. So it seems like Vite now can inline SVG.

So you can put images in src to make it inlined by this plugin, or put them in public as static resources un-touched.


Tooltips

We need a tooltip solution that use Portals and doesn't require any state handling or lots of boilerplate. It should be easy to wrap existing content with a tooltip.

Places we want tooltips:

[ ] The "Create New Portfolio flow, at the "Seed Phrase for Your Portfolio, when the user click copy button. See the animation here: https://framer.cloud/jTdrj
[ ] In the "Dashboard", select a currency, click "Deposit", and when you click copy button it should have the same tooltip and animation as the above item. See: https://framer.cloud/tKpjW
[ ] Better tooltips for the charts. The current ones are ugly and follow the mouse. The tooltip should be pinned to their origin points.

@lukechilds @kevva I think we should also have a tooltip for the "regenerate seed phrase" button. Thoughts?

I think most people will know what it does but definitely no harm in adding a tooltip for more clarity.


ReplaceAll is not a function error

Request type

[x] Correction or update

Details
The document page that explains string.replaceAll throws an error when you run the demo setup. When I google the error many stackoverflow posts mention that it is not a valid function. Any clarification on this would be much appreciated.
ReplaceAll MDN Page.

 What browser version are you using? Please check the compat table: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replaceAll#Browser_compatibility

Thank you @Elchi3 I was on FF 76, and after updating to 77 it worked now. I jumped the gun without checking the supported version table! Apologies.


streams/crossings extracts - column type incompatible

Pulling from the posted .gdb is a nice workaround vs trying to page through the api. Unfortunately esri file geodatabases appear not to support a boolean type and ogr is translating the habitat columns to an integer. This is not compatible with existing map layer definitions in qgis. Maybe a -sql  statement in the ogr2ogr command can fix?
$ ogrinfo bcfishpass.gdb streams -so
INFO: Open of `bcfishpass.gdb'
      using driver `OpenFileGDB' successful.

Layer name: streams
Geometry: Multi Line String
....<etc>
spawning_model_ch: Integer (0.0)
spawning_model_co: Integer (0.0)
spawning_model_sk: Integer (0.0)
spawning_model_st: Integer (0.0)
spawning_model_wct: Integer (0.0)
rearing_model_ch: Integer (0.0)

https://github.com/NewGraphEnvironment/dff-2022/blob/master/scripts/background_layers.sh#L61

I'd post as geopackage but user feedback about accessing that format (especially for large layers like streams) has been poor.

Interestingly, sqlite/geopackage boolean support is much the same as file geodatabase:
https://www.sqlite.org/datatype3.html#:~:text=SQLite does not have a,literals 1 and 0 respectively
But ogr2ogr does a better job at encoding the than with the file geodatabase driver:
spawning_model_ch: Integer(Boolean) (0.0)
spawning_model_co: Integer(Boolean) (0.0)
spawning_model_sk: Integer(Boolean) (0.0)
spawning_model_st: Integer(Boolean) (0.0)
spawning_model_wct: Integer(Boolean) (0.0)
rearing_model_ch: Integer(Boolean) (0.0)
rearing_model_co: Integer(Boolean) (0.0)
rearing_model_sk: Integer(Boolean) (0.0)
rearing_model_st: Integer(Boolean) (0.0)
rearing_model_wct: Integer(Boolean) (0.0)

Using the -sql option and wrapping the habitat columns like cast(spawning_model_ch as boolean) as spawning_model_ch, works fine.
But:

this requires spelling out the required columns in this query, creating yet another place where column names will have to be updated with model changes
dumping streams to flatgeobuf on the web server avoids having to make the casts - and makes for much faster downloads

I'll host flatgeobuf versions of the data. It is more redundant data but the format is really nice for quick downloads. Also handy as a fast input to tippecanoe if we move to storing the streams as vector tiles in the project.

Test of extracting VICT from the two file formats:

fgb: 9s
zipped .gdb: 12m4s

I think the redundant data is ok

fixed with 065b288a16ddfb684092d206ae4e54df473e3a18. Extracts are now pretty quick.


feat(stryker): #438 Extensive config validation

@simondel I went ahead and changed as many of the error messages as possible to follow the format "Value {value} is invalid for {field}. Expected {expectation}." I left one pair of backticks in the messages (around the field) for back consistency.

Awesome! Looking good :) @nicojs  Shall we merge this?

Great job! 🥇


chore(docs): update docs regarding generated library's files

Closes #34

Coverage remained the same at 92.982% when pulling c585a5d9ff0822affa65b2cb40a313a56703c3ca on chore_docs into 53771d601b83b5cba3fda8da6f3b8848136654c9 on dev.


Add option to export chat history

Requesting the ability to export the last n lines of chat. This was mentioned in issue #2713, but this was quite some time ago. Would it be feasible to add?
It would help a lot with CC-moderation, as taking screenshots is a time-consuming process.

I can't really imagine a UX for this which isn't terrible.

This would be very nice to have.

the external plugin, https://github.com/MarbleTurtle/ChatSnips, has the ability export a transcripts of chat to an image.


Proper output of ddouble numbers

Right now operator<< simply prints the hi and lo part. Ideally, we want to change that so that we can simply print the number.

I've gotten this done, I wrote a function with signature
string to_string(DDouble d, size_t nDigits = 34)
Want me to PR and you can incorporate however works best for you (such as <<)?

Or I can just share the function, it's self contained, whatever's easier for you.

Feel free to open a PR!

Done. You'll probably want to make it follow your style better.


🤗 [REQUEST] - WaveCoder-Ultra-6.7B

Model introduction
WaveCoder 🌊 is a series of large language models (LLMs) for the coding domain, designed to solve relevant problems in the field of code through instruction-following learning. Its training dataset was generated from a subset of code-search-net data using a generator-discriminator framework based on LLMs that we proposed, covering four general code-related tasks: code generation, code summary, code translation, and code repair.
Model URL
https://huggingface.co/microsoft/wavecoder-ultra-6.7b
Additional information (Optional)
We use the code base from magicoder (https://github.com/ise-uiuc/magicoder) and evalplus (https://github.com/evalplus/evalplus), anyone can reach the score by running the following command:
MODEL_KEY=deepseek-ai/deepseek-coder-6.7b-base
MODEL=microsoft/wavecoder-ultra-6.7b

DATASET=humaneval
SAVE_PATH=evalplus-$(basename $MODEL)-$DATASET.jsonl
SANITIZED_PATH=humaneval_result/evalplus-$(basename $MODEL)-$DATASET-sanitized.jsonl

python -m experiments.text2code \
  --model_key $MODEL_KEY \
  --model_name_or_path $MODEL \
  --save_path $SAVE_PATH \
  --dataset $DATASET \
  --temperature 0.0 \
  --top_p 1.0 \
  --max_new_tokens 512 \
  --n_problems_per_batch 28 \
  --n_samples_per_problem 1 \
  --n_batches 1

echo "$MODEL"
evalplus.evaluate --dataset $DATASET --samples $SAVE_PATH

Decontamination
embedding
Author
Yes
Data
No
Security

[X] I confirm that the model is safe to run which is not designed to produce malicious code or content.

Integrity

[X] I confirm that the model comes from unique and original work and does not contain any plagiarism.

Hi, @ganler, Could we possibly provide the test code? In fact, we found in other issues that we can use the test code from magicoder for testing. I look forward to receiving your reply.
https://github.com/evalplus/evalplus/issues/40

also cc @answers111

Thank you, let's concentrate the discussion thread on #169 (now there are too many WaveCoder threads...)


Any documentation?

Is there any documentation on how to enable this?

Unfortunately due to other commitments I abandoned this project years ago.
As far as I remember is a play2.1 project, as long as you ensure connection to a mongodb and create initial accounts (reverse engineer it based on the models) it should run but project is far from complete and for production environment would require a ton of optimisations to generate the heatmaps in reasonable times


Network Error: ldap: response channel closed

I'm trying to protect an application wich load many .js files.
Actual behavior
On first app access, I'm requested to authenticate, then I also need to authenticate for each subsequent file load.
Expected behavior
I should authenticate once, and my authentication reused for next files access.
I can see in FF console that the first request ends with http 200, and all next requests by a 401 while there is effectively the right header in all subsequent requests Authorization:"Basic xxxx".
I can see in the responses headers X-Ldapauth-Trace:"Failed to authenticate: LDAP Result Code 200 "Network Error": ldap: response channel closed". They also appear a lot in ldap-auth-proxy logs.
(How can I send you log traces privately?)

Let me try to reproduce this. A side note - my main use case is auth backend, and you are using it as proxy, right?

@pinepain exact

I've just tested using the "auth backend" pattern and it seems to work fine, but it add some configuration overhead.
Also, chain start to be long in my case: traefik -> nginx (=> ldap-auth-backend) -> app(gunicorn). It would be nice if I can suppress the nginx stack.

Problem is probably hidden in the "auth backend" pattern because of proxy_cache_key "$http_authorization"; instruction.

Regards nginx use with traefik, Have you looked into https://docs.traefik.io/configuration/entrypoints/#forward-authentication instead of proxying? I'm not sure traefik can cache auth response but even though it could be more effective to use traefik for proxying as ldap-auth-proxy has very primitive proxy, it's more for fast drop-in to get some auth asap, I'm not sure it's fully qualified for production use in proxy mode, but maybe it is good enough, dunno, need to look into how it's done in traefik and other, will appreciate any feedback here.

@pinepain didn't knew about ability for Traefik to forward authentication, I have to look this, thanks for the input!

Hello, @pinepain and @kumy
Apologies for piggybacking on this thread :-)
@kumy, have you had any success running ldap-auth-proxy with Traefik using forward authentication? I'm trying to set up LDAP authentication for my app, all bundled in a Docker Swarm stack:
version: "3"

services:
  xxxxx:
    image: xxxxx
    ports:
      - "3838:3838"
    user: root
    volumes:
      - "/var/run/docker.sock:/var/run/docker.sock"
    deploy:
      mode: replicated
      replicas: 5
      placement:
        constraints: [node.role == worker]
      labels:
        - "traefik.port=3838"
        - "traefik.frontend.rule=PathPrefix:/"
        - "traefik.backend.loadbalancer.stickiness=true"
        - "traefik.docker.network=xxxxx_default"
        - "traefik.frontend.auth.forward.address=http://{{ ansible_host }}:8888"
        - "traefik.frontend.auth.forward.trustForwardHeader=true"
    networks:
      - default

  traefik:
    image: traefik
    command: --docker --docker.swarmMode --docker.watch --api --loglevel=DEBUG
    ports:
      - "80:80"
      - "3939:8080"
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
    deploy:
      mode: replicated
      replicas: 1
      placement:
        constraints: [node.role == manager]
    networks:
      - default

  ldap:
    image: pinepain/ldap-auth-proxy
    ports:
      - "8888:8888"
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
    deploy:
      mode: replicated
      replicas: 1
      placement:
        constraints: [node.role == manager]
    networks:
      - default
    environment:
      - LOG_LEVEL=debug
      - LISTEN=:8888
      - LDAP_SERVER=xxxxx
      - LDAP_BASE=xxxxx
      - LDAP_BIND_DN=xxxxx
      - LDAP_BIND_PASSWORD=xxxxx
      - LDAP_USER_FILTER=xxxxx
      - HEADERS_MAP=xxxxx
      - UPSTREAM=http://{{ ansible_host }}/

networks:
  default:
      driver: overlay
      driver_opts:
        com.docker.network.driver.mtu: 1450

However, when I authenticate with my credentials, it gets stuck, with logs flooded with the following messages:
time="2018-12-19T13:57:48Z" level=debug msg="Malformed auth header value"
time="2018-12-19T13:57:48Z" level=debug msg="GET / 401"
time="2018-12-19T13:57:48Z" level=debug msg="Headers: map[xxxxx], Attributes: map[xxxxx]"

I'm not sure if that's Traefik's fault (I suspect it removes the authorization header) or something wrong with my configuration.

Hi @cosi1, sorry no input from my side, as I didn't have time yet to migrate to such config, but I'm interested in a working configuration example ;)

@kumy Thanks anyway! When (if) I finally make it work, I'll post my solution here :-)
@pinepain Could you please elaborate how exactly the "auth backend" mode works? If I understand correctly, Traefik expects forward authentication mechanisms to simply return a response with status code 200, without redirection. I'm not sure about the Authorization header, but I can't help wondering why it's ldap-auth-proxy, and not Traefik that complains about this missing header (Malformed auth header value). Moreover, I get GET / requests from ldap-auth-proxy - why??? ;-)

Hi there, I just hit this issue in k8s with ingress-nginx. During auth I create and close ldap connection on each request, which may cause troubles to the upstream LDAP server, which IMO is causing the error we seen. In a typical web app there is main page load where normally first auth occurs and then when page content loaded and parsed, all resources (css, js, images) start loading, which is a good bunch of requests within a short time. Keeping connection hanging forever was causing pita for me before (using in-house quickly written script), so this is why i'm opening it every time.
To address this issue, I'm adding caching of successfully authed creds for 5min (it's hardcoded atm, not sure it worth to change it to some other value, though, PR is welcomed). It should be addressed in #12 and available in 0.2.0 release. I will really appreciate any feedback.

Closing as it should be addressed by 0.2.0 and there was no feedback that the issue occurs after that.


moment picker calendar display issue in mobile view

Hi,
i am using moment picker to filter my data by date, I am facing the display calendar issue in mobile view, the dimension is 414x736, which is iPhone 6/7/8 plus
screenshot:

Expected:

Note: I am not setting any additional CSS for the calendar for mobile view for any dimension.
any help would be appreciated :)

Can anyone help me with this :(


Fix minutes display condition in time formatting

I saw that records with times like 2:00:30.069 were displayed as 2:30.069 (example found here).
This could fix it, but I have no environment to test it.

Thanks, but I'll change to Openplanet's Time::format() function, this was implemented in the latest version


Started system container as non-root, but not able to start the docker daemon and run any docker commands

I have been struggling with this. I built a system image with this Dockerfile:
FROM ubuntu:18.04

RUN apt-get update && \
    apt-get install -y gcc build-essential wget curl nano ca-certificates curl gnupg lsb-release sudo && \
    mkdir -p /etc/apt/keyrings && \
    curl -fsSL https://download.docker.com/linux/ubuntu/gpg | sudo gpg --dearmor -o /etc/apt/keyrings/docker.gpg && \
    echo "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.gpg] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable" | sudo tee /etc/apt/sources.list.d/docker.list > /dev/null && \
    echo "Installing docker-ce-cli" && \
    apt-get update && \
    apt-get -y install docker-ce docker-ce-cli containerd.io docker-compose-plugin

# COPY docker_pull_inner_image.sh /usr/bin
# RUN chmod +x /usr/bin/docker_pull_inner_image.sh && docker_pull_inner_image.sh && rm /usr/bin/docker_pull_inner_image.sh

RUN useradd -u 1003 -m kokleong
RUN usermod -a -G root kokleong
RUN echo 'root:docker' | chpasswd
RUN echo 'kokleong:docker' | chpasswd
USER kokleong

and started the container with command docker run -ti --rm --name sysbox-test sysbox:v1. By default I will appear as "kokleong" in the system container. Once I am inside the system container, I am not able to start the docker daemon by doing dockerd and use any docker commands at all. Anyone knows how to get around with this without starting the container with docker run -ti -u 0 --rm --name sysbox-test sysbox:v1 with the -u 0 flag
As can be seen in the Dockerfile, I even added "kokleong" to "root" group. Any help is appreciated.

Hi @kokleong9406, have you tried to add your user to the docker group?
https://docs.docker.com/engine/install/linux-postinstall/

Hi @rodnymolina, thanks for the tips. I am now able to run docker commands after adding my user to the docker group

Great @kokleong9406, let us know if any other questions. I am closing this issue now.


I can't recognize picture tags with saucenao\iqdb

And speaking of bugs, I ran into the fact that the tags for the saucenao\iqdb picture are not assigned. And it would be a little-known picture, but I specifically took from the same danbooru, and tags just did not appear.
(Although in the very first run of the application, i was able to pull the tags for the iqdb\saucenao picture, but after that, I never got around to doing it again.)

The most obvious reasons of the same behavior I have in my environment were:

the host of a remote search engine is temporarily unavailable.
the host of a booru with tags is temporarily unavailable.
I had retrieved tags after a totally bad tag run and the picture has blocking marks (special marks are stopping repeated tag retrieving to reduce traffic; but you can free remove this blocking marks in the picture screen from the block "Pollee tag sources").

Sometimes reasons was more exotic due to bugs in program logic. So, I looked through the logs by Ctrl+Shift+I and got some additional info.

Am I doing it wrong?
For example, I add a picture => Edit =>Load tags from Saucenao for current files => Predict tags by neuronet
And one time the tags themselves were added to the picture, all the other times I had to add each tag manually.

First, you can check Saucenao API key in Edit / Settings (Ctrl+,) / Tag sources / Saucenao. Then you can check your daily limit on the same screen.
BTW IQDB do not request api key so I don't know what exactly happened.
Neuronet prediction is a separate options. If you have already downloaded the model files, you can predict tags even if booru don't know about the image. It is usually a bit long procedure the first time.

When i check saucenao daily limits:
30s: 0 (limit 4)
24h: 0 (limit 100)
When i try to load tags from saucenao after add api:
All files in query are already inspected for tags

Looks like unused free limits. So you can still use Saucenao with it.
You can remove the pollee mark from the picture after the unsuccess attempt (in the picture screen) and try get tags again.

I tried it, but nothing changed.
The tags were not added.

Yes, it's strange. If you remove pollee marks of boorus and search engines from the picture, you can still get tags.
What is output to the console in developer tools (Ctrl+Shift+I)?

I think I got it.
Maybe the problem is that it's trying to take tags from pixiv (that's the topmost source links in saucenao), and it can't do it.

That's it, now I think I've finally figured it out.
Started vpn and tried again to get tags through saucenao and everything was successful.
Maybe there's a way to add ISP blocking bypass/proxy to your program?

So it's case #2 (a booru is unavailable).

I guess it probably works through chrome (considering the kind of console in your program).
It's Electron framework with Chromium browser engine. Full add-ons are not supported: https://www.electronjs.org/docs/latest/api/extensions

Maybe there's a way to add ISP blocking bypass/proxy to your program?
I think it can be solved with low-level packages like https://www.npmjs.com/package/https-proxy-agent
It's not a simple way ofcource.

I have added proxy options to app roadmap.

I have added proxy options to the app roadmap.

Would it be possible to add a url field to enter automatic proxy settings? (like in firefox)


Broken builds after 11.09.2020 that says a container can't connect to MySQL

Description
All builds for our applications started failing from 14.09.2020 due to some changes in ubuntu-latest image. Instead of initialise a database and running Ruby tests it's raising an error that it can't connect to MySQL server.
Area for Triage:

Question, Bug, or Feature?:
Bug
Virtual environments affected

[ ] macOS 10.15
[X] Ubuntu 16.04 LTS
[X] Ubuntu 18.04 LTS
[X] Ubuntu 20.04 LTS
[ ] Windows Server 2016 R2
[ ] Windows Server 2019

Expected behavior
I expected build to run correctly and broke only on failed tests, not on missing MySQL server or something.
Actual behavior
As I wrote before, instead of running tests I'm getting this build error:
rails aborted!
Mysql2::Error::ConnectionError: Can't connect to MySQL server on 'mysql' (115)
/usr/local/bundle/gems/mysql2-0.5.2/lib/mysql2/client.rb:90:in `connect'
/usr/local/bundle/gems/mysql2-0.5.2/lib/mysql2/client.rb:90:in `initialize'
/usr/local/bundle/gems/activerecord-6.0.0/lib/active_record/connection_adapters/mysql2_adapter.rb:24:in `new'
/usr/local/bundle/gems/activerecord-6.0.0/lib/active_record/connection_adapters/mysql2_adapter.rb:24:in `mysql2_connection'
/usr/local/bundle/gems/activerecord-6.0.0/lib/active_record/connection_adapters/abstract/connection_pool.rb:879:in `new_connection'
/usr/local/bundle/gems/activerecord-6.0.0/lib/active_record/connection_adapters/abstract/connection_pool.rb:923:in `checkout_new_connection'
/usr/local/bundle/gems/activerecord-6.0.0/lib/active_record/connection_adapters/abstract/connection_pool.rb:902:in `try_to_checkout_new_connection'
/usr/local/bundle/gems/activerecord-6.0.0/lib/active_record/connection_adapters/abstract/connection_pool.rb:863:in `acquire_connection'
/usr/local/bundle/gems/activerecord-6.0.0/lib/active_record/connection_adapters/abstract/connection_pool.rb:587:in `checkout'
/usr/local/bundle/gems/activerecord-6.0.0/lib/active_record/connection_adapters/abstract/connection_pool.rb:431:in `connection'
/usr/local/bundle/gems/activerecord-6.0.0/lib/active_record/connection_adapters/abstract/connection_pool.rb:1111:in `retrieve_connection'
/usr/local/bundle/gems/activerecord-6.0.0/lib/active_record/connection_handling.rb:231:in `retrieve_connection'
/usr/local/bundle/gems/activerecord-6.0.0/lib/active_record/connection_handling.rb:199:in `connection'
/usr/local/bundle/gems/activerecord-6.0.0/lib/active_record/tasks/database_tasks.rb:59:in `check_protected_environments!'
/usr/local/bundle/gems/activerecord-6.0.0/lib/active_record/railties/databases.rake:15:in `block (2 levels) in <top (required)>'
/usr/local/bundle/gems/railties-6.0.0/lib/rails/commands/rake/rake_command.rb:23:in `block in perform'
/usr/local/bundle/gems/railties-6.0.0/lib/rails/commands/rake/rake_command.rb:20:in `perform'
/usr/local/bundle/gems/railties-6.0.0/lib/rails/command.rb:48:in `invoke'
/usr/local/bundle/gems/railties-6.0.0/lib/rails/commands.rb:18:in `<top (required)>'
bin/rails:4:in `require'
bin/rails:4:in `<main>'
Tasks: TOP => db:schema:load => db:check_protected_environments
(See full trace by running task with --trace)
##[error]Process completed with exit code 1.

My configuration files are:
./.github/workflows/docker_ci.yml:
name: Docker CI

on:
  pull_request:
    branches:
      - development
      - master
  push:
    branches:
      - development
      - master
      - release/*

jobs:
  build:
    runs-on: ubuntu-latest

    steps:
    - uses: actions/checkout@v2
    - name: Run Spec
      run: docker-compose -f docker-travis.yml run spec
    - name: Run Test
      run: docker-compose -f docker-travis.yml run test

./docker_travis.yml:
version: '2'

services:
  mysql:
    image: my-company/mysql:5.7
    environment:
      MYSQL_RANDOM_ROOT_PASSWORD: 'true'
      MYSQL_DATABASE: 'development'
      MYSQL_TEST_DATABASE: 'test'
      MYSQL_USER: 'admin'
      MYSQL_PASSWORD: 'password'
    volumes:
      - mysql:/var/lib/mysql

  redis:
    image: redis:5.0-alpine
    command: redis-server
    volumes:
      - redis:/var/lib/redis/data

  spec:
    build: .
    image: my-company/private-image:test
    command: bin/rails db:schema:load db:sql:run spec
    working_dir: /app/user
    env_file: .env.test
    depends_on:
      - mysql
      - redis

  test:
    image: my-company/private-image:test
    command: npm run test-ci
    working_dir: /app/user
    env_file: .env.test
    depends_on:
      - mysql
      - redis

volumes:
  mysql:
  redis:

Don't get misguided by docker_travis.yml filename, we're using GitHub Actions for CI.
Anyway, I tried to check docker-compose -f docker-travis.yml run spec on my localhost environment and it works like a charm and the problem seems to be with changes introduced between 11.09.2020 (date of last good build) and 14.09.2020 (first broken build after week end) to virtual-environments. I tried to use other environments like ubuntu-16.04 and ubuntu-20.04, but without success. Only for ubuntu-16.04 one build succeeded, but it was only once.
Repro steps
Currently it's not possible to reproduce this issue by people outside our company as we're using private docker images. Sorry for that, I have hope that someone will give me at least a small advice how to resolve/debug this issue.

Hello @dloranc , could you please check correlation between image version of your builds and build health around these dates? Range between a few latest green builds and a few first failed ones.
Image version can be found in Set up job step:

OK, so last four green builds have:

or if you prefer to have it written down:
Current runner version: '2.273.0'
Operating System
  Ubuntu
  18.04.5
  LTS
Virtual Environment
  Environment: ubuntu-18.04
  Version: 20200901.1
  Included Software: https://github.com/actions/virtual-environments/blob/ubuntu18/20200901.1/images/linux/Ubuntu1804-README.md
Prepare workflow directory
Prepare all required actions
Download action repository 'actions/checkout@v2'

Red builds have:

Current runner version: '2.273.2'
Operating System
  Ubuntu
  18.04.5
  LTS
Virtual Environment
  Environment: ubuntu-18.04
  Version: 20200914.1
  Included Software: https://github.com/actions/virtual-environments/blob/ubuntu18/20200914.1/images/linux/Ubuntu1804-README.md
Prepare workflow directory
Prepare all required actions
Download action repository 'actions/checkout@v2'

One red build (not first, but later one) have Version: 20200908.1.

Hello, @dloranc
I can't reproduce the issue with default mysql-5.7
jobs:
  build:
    runs-on: ubuntu-latest

    steps:
    - uses: actions/checkout@v2
    - name: Run client
      run: docker-compose -f docker-compose.yml run client 2>&1 | tail -n 5

docker-compose.yml:
version: '3'
services:
  mysql:
    image: mysql:5.7
    environment:
      MYSQL_RANDOM_ROOT_PASSWORD: 'true'
      MYSQL_DATABASE: 'development'
      MYSQL_TEST_DATABASE: 'test'
      MYSQL_USER: 'admin'
      MYSQL_PASSWORD: 'password'
    volumes:
      - mysql:/var/lib/mysql
  redis:
    image: redis:5.0-alpine
    command: redis-server
    volumes:
      - redis:/var/lib/redis/data
  client:
    image: ubuntu
    command: bash -c "apt update &>/dev/null && apt-get install -y mariadb-client &>/dev/null && mysql -uadmin -ppassword -hmysql -e 'SHOW DATABASES;'"
    depends_on:
    - mysql
    - redis
volumes:
  mysql:
  redis:

@al-cheb Thank you for the help. I tried it too, but it didn't work.
Anyway, we solved this issue by moving tests from docker-compose to GitHub container, so you can close it.

@dloranc , Thank you. Closed.


Suggestion: Wise Old Man Dashboard

To allow for easier group management, we could allow group leaders to access a "Dashboard" that allows them to manage their group(s) as well as the Discord bot.
The theory:
Anybody could create a WiseOldMan account. Group leaders can add multiple groups to their Dashboard using the verification code given on creation. After the group is added to your Dashboard, you no longer need to use the code to manage your group as long as you are signed in. Maybe an optional Discord sign in option?
The Dashboard could also have a integration with the Discord bot, allowing the group leader to add the bot to servers they own and change the bot's configurations.
Pros:

Makes contacting group leaders easier
Allows group leaders to approve applications to their groups (if that feature is added)
Email alerts become a possibility with account creation (could be useful for being notified of applicants, etc)
Easier group management
Manage groups Patreon perks (tbd)

Cons

Lots of work/time
Would require significant security
Likely to cost more to run

This will require an authentication system, Discord is most likely the chosen provider. However, it's a huge undertaking and brings up some questions regarding ownership.
Let's say we introduce Discord auth and allow you to edit your groups by logging in with Discord. What happens to groups that were created and managed with a verification code?
Would you be able to "redeem" ownership with Discord by inserting your verification code? Then at some point we'd need to invaidate that code, but if there's multiple group leaders? How does permission management look like? Would you have to invite other admins?
I'll probably be revisiting this topic next year, but not anytime soon. Closing until that time comes.


Threadsafety of Parser::parse() and client side support for response callbacks

Hello,
great job so far with your jsonrpcpp.
It's easy to use. One thing that came to me while using it was, that trying to use it with a server with
lots of parallel jsonrpc calls, the parser callbacks cannot be used in a multi-threaded environment because they lack synchronisation with the manipulation of the callback container. So if the callback library is changing, while there is heavy load on the line, this could cause some unexpected behaviour. Would be nice, if you might integrate this in a future release.
A second thing that would be nice to have is a callback wrapper for responses on the client side, to support asynchronous call handling.
I wrapped both of those things arround from outside so far.
If you need any assistance I'd be glad to help with a fork.
Best regards and keep going.

Hi!
Regarding this issue, can this library be used in a multi-threaded application?


Almost nothing is giving admin warnings

Description
Everything from some nades to micro bomb implants to the AME being overloaded to the PA being turned on does not give admins an alert

most of this seems to have been fixed, but 2 big ones remain, both the micro bomb and the cluster nade dont give an admin warning still


Fix link markdown

Remove a space from the Soft Actor-Critic link markdown.

Duplicate of #54

I'm going to close this since it's a duplicate.


Updating for base-4.14 (ghc 8.10)

Resolving dependencies...
cabal: Could not resolve dependencies:
[...]
[__2] next goal: fltkhs:setup.base (dependency of fltkhs)
[__2] rejecting: fltkhs:setup.base-<IP_ADDRESS>/installed-<IP_ADDRESS> (conflict:
fltkhs => fltkhs:setup.base>=4.5 && <4.14)

This might just require bumping the base dependency in the custom-setup field of fltkhs.cabal.

#168 prevents that from working, actually.

For posterity, one workaround is to use the following cabal.project:
source-repository-package
  type: git
  location: git://github.com/deech/fltkhs.git
  subdir: fltkhs
  tag: 272d225e641e9b6161df82066e9a4b919c0e812a

packages: .


Guide how to migrate to "AD-Pro Authentication" plugin

Description
Added simple guide how to replace "DNN.ActiveDirectory"  by Glanton "AD-Pro Authentication" module.
Changes made

guide added to the Readme file

Recommend this be added in a more appropriate place like AD-Pro Authentication documentation.


Function to check if a class machine is state_machine

https://bugzilla.redhat.com/show_bug.cgi?id=1203426
A class is a state machine class if it has atleast one
state field defined.

@gmcculloug @Fryguy @tinaafitz
Please review

:+1:


✨ path.name

:tada: This PR is included in version 1.4.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Kafka message filtering

Description
This PR enables filtering of Kafka messages in the message feed.
Fixes #122
Type of change

[ ] Documentation (non-breaking change that adds or improves the documentation)
[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (non-breaking, back-end change that speeds up the code)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Breaking change (whatever its nature)

Key checklist

[ ] All tests pass (eg. python -m pytest)
[ ] The documentation builds and looks OK (eg. python -m sphinx -b html docs docs/build)
[ ] Pre-commit hooks run successfully (eg. pre-commit run --all-files)

Further checks

[ ] Code is commented, particularly in hard-to-understand areas
[ ] Tests added or an issue has been opened to tackle that in the future. (Indicate issue here: # (issue))

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.55%. Comparing base (b796434) to head (0f4da91).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage   80.55%   80.55%
=======================================
  Files          26       26
  Lines         324      324
=======================================
  Hits          261      261
  Misses         63       63

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Retrieve production DB credentials from AWS Secrets Manager

Pull Request Test Coverage Report for Build 3138

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.919%

Totals

Change from base Build 3137:
0.0%

Covered Lines:
1447

Relevant Lines:
1493

💛  - Coveralls


Use Istio snowdrop models

Purpose

Fixes https://github.com/ballerinax/kubernetes/issues/299.

Goals

Use Snowdrop istio library for the models of the istio artifact generation and tests. This gives cleaner code.

Approach

Use snowdrop's istio model classes.

Codecov Report

Merging #300 into master will decrease coverage by 0.45%.
The diff coverage is 83.47%.

@@             Coverage Diff              @@
##             master     #300      +/-   ##
============================================
- Coverage     79.02%   78.57%   -0.46%
+ Complexity      753      689      -64
============================================
  Files            65       65
  Lines          3171     3034     -137
  Branches        330      287      -43
============================================
- Hits           2506     2384     -122
- Misses          512      515       +3
+ Partials        153      135      -18

Impacted Files
Coverage Δ
Complexity Δ

...ernetes/models/istio/IstioVirtualServiceModel.java
100% <ø> (ø)
7 <0> (-4)
:arrow_down:

...va/org/ballerinax/kubernetes/KubernetesPlugin.java
78.88% <ø> (ø)
16 <0> (ø)
:arrow_down:

...etes/handlers/openshift/OpenShiftRouteHandler.java
90% <0%> (ø)
7 <0> (ø)
:arrow_down:

...lerinax/kubernetes/handlers/DeploymentHandler.java
87.17% <0%> (ø)
27 <0> (ø)
:arrow_down:

...inax/kubernetes/handlers/ResourceQuotaHandler.java
88.23% <0%> (ø)
7 <0> (ø)
:arrow_down:

...ernetes/handlers/PersistentVolumeClaimHandler.java
91.66% <0%> (ø)
5 <0> (ø)
:arrow_down:

...andlers/openshift/OpenShiftBuildConfigHandler.java
91.07% <0%> (ø)
5 <0> (ø)
:arrow_down:

...ballerinax/kubernetes/handlers/IngressHandler.java
87.32% <0%> (ø)
8 <0> (ø)
:arrow_down:

...org/ballerinax/kubernetes/handlers/JobHandler.java
71.25% <0%> (ø)
9 <0> (ø)
:arrow_down:

...org/ballerinax/kubernetes/handlers/HPAHandler.java
90.9% <0%> (ø)
7 <0> (ø)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ec2eef...4b35918. Read the comment docs.


V2 Fix, Refresh UI before Scene switch (in case last bg 192+ overwrote it)

Please check if the PR fulfills these requirements

[x] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix

What is the current behavior? (You can also link to an open issue here)
Unlike 1.2.1, if you load a background between 192-256 tiles, then a background with less than 192 tiles, the text box will be using garbage tiles from the last bg. #454

What is the new behavior (if this is a feature change)?
Reverts to 1.2.1 where UI tiles are loaded every time before the next scene, in case they were overwritten.
Dialogue still corrupt on scenes 192-256, but fine again once you move to a sub 192 unique tile map.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Users must refresh their engine if ejected for this change to take effect.

Other information:

Ah oops, thanks for fixing.
I'd suggest I look at preventing the image tiles from even overflowing past 192 but I guess people are probably depending on that functionality now for more complex images when the UI isn't needed

Yes, there's projects using the 192 overflow for title screens and cutscenes.
If we do introduce a hard limit I think we should also offer a (advanced) setting to control tile distribution per scene.

Okay no problem I think for now we can leave it as is


My CPU using 100%

I have put gpu id in my training command. And the training using fully my gpu. After that, it using my cpu 100%. Can anyone face this problem? I need help. Thanks you!

In the phrase: 2019-08-01 09:57:23.847939: W tensorflow/core/kernels/draw_bounding_box_op.cc:122] Bounding box (-853,95,-728,254) is completely outside the image and will not be drawn.
and tensorflow global step:
It makes cpu 100%, I think the reason come from preprocessing phrase


bpf,test: Define BPF_TEST macro for map-in-map/prog-map initialization

Please see the commit message for more details.
bpf,test: Define BPF_TEST macro for map-in-map/prog-map initialization

@aspsk That syntax looks nice to me, but it only works for map-in-map initialization, right? If so, I'd keep the BPF_TEST macro as is for other purposes and define another macro like BPF_TEST_MAP_INIT(...).

@aspsk That syntax looks nice to me, but it only works for map-in-map initialization, right? If so, I'd keep the BPF_TEST macro as is for other purposes and define another macro like BPF_TEST_MAP_INIT(...)

So, the macro should work for any code block, but, yes, for long code blocks ifdefs look better. (Just didn't want to have more ifdefs around :-) )

Also, another concern is "somewhere globally" is not so trivial

This could be just a build flag: -DBPF_TEST(...)= or -DBPF_TEST(...)=__VA_ARGS__.
But ok, if this is simpler to just have a testable BPF_TEST, then use it. And cleanup code with BPF_TEST_MAP_INIT and friends when possible.

We don't need to run tests since this just defines the macro, and no one uses it.


List.sliding() should return List<List>

As mentioned in Gitter, in version 2.0.0, List.sliding() returns an Iterator<IndexedSeq> instead of a List<List> (as in previous 1.2.2 version).
It seems reasonable to go back to 1.2.2 version's return type to avoid having to call toList() everytime we call List.sliding()

Thinking again about it justifies the current implementation. sliding() and grouped() are Iterable operations. Forcing a Set to return a Set when sliding is not a good idea. Iterator is a good choice, it also lets us convert the sliding() elements to a Traversable.


Update sbt to 1.3.0

Updates org.scala-sbt:sbt from 1.2.8 to 1.3.0.
Release Notes/Changelog
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-sbt", artifactId = "sbt" } ]

labels: semver-minor

Superseded by https://github.com/coursier/coursier/pull/1378.


[Investigation] Templates/ISOs are not removed but marked as Inactive

Probably not an issue, but worth investigating the reason why templates/ISOs are not deleted in database (the removed column stays NULL) after deleting a template/ISO. The ticket is raised after some doubts on the reviews of PR #4047
ISSUE TYPE

Other

COMPONENT NAME
API, templates, ISOs

CLOUDSTACK VERSION
All versions

CONFIGURATION
N/A
OS / ENVIRONMENT
N/A
SUMMARY
Deleting a template/ISO does not actually remove it, but set it to Inactive and hidden
STEPS TO REPRODUCE
Remove a template/ISO

EXPECTED RESULTS
Template/ISO removed in database

ACTUAL RESULTS
Template/ISO state = 'Inactive' but removed column not changed

Cc @Spaceman1984 looks like GC issue, have you seen this or can you discuss with @nvazquez and investigate/fix?

I'll take a look @rhtyd

I'm not sure what the original problem was, I have traced the active/inactive fields to a commit in 2013. In the git log there is speak of some kind of problem that was solved from version 2.1.x to do with the removed column not being correctly used.
Fixed the problem with offerings and templates.  These two items due to a previous patch all the way back in 2.1.x versions uses the removed column incorrectly.  No one fixed since then.  Hence, there's a bunch of findbyidincludingremoved calls in the cloudstack code around these two items.

abbae2aa Alex Huang<EMAIL_ADDRESS>on 2013/08/27 at 02:30

@rhtyd Like @nvazquez said, there is no issue here, just a question about design choices.

ok, this means we'll have to look for those find including removed calls and try to make sure the removed column is correctly filled at the correct moment. (future version for now)

Looks liked fixed in https://github.com/apache/cloudstack/pull/4748
@nvazquez can you check?

Tested - fixed confirmed. Thanks @Pearl1594 @rhtyd


Memory leak in string construction

Hello,
I am inspired by your code and currently developing a cffi-based pysam alternative which works with Pypy. While testing your code I found that
ffi.new('kstring_t *', {'m': 0, 'l': 0, 's': ffi.NULL})
causes memory leak, so I replaced it with Pythonic way. You can find the change here:
https://github.com/pjb7687/hts-python/commit/cd35d6f15221bb09c218d0f978c0b92c560fcdd6
Maybe there would be better way to do this? Thank you so much for your contribution!
Best regards,
Jeongbin Park

Thanks for reporting.
I didn't know about the memory leak. I think the better solution is to just free kstr.s


Create add1.md

Docs Build status updates of commit 1c39651:
:warning: Validation status: warnings

File
Status
Preview URL
Details

shan/add1.md
:warning:Warning
View
Details

shan/add1.md

Line 1, Column 1: [Warning: require add-only] Missing required attribute: 'add-only'.
Line 1, Column 1: [Warning: require not-add-only] Missing required attribute: 'not-add-only'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


[CIVP-18337] Update stream logging to address notebook log colors

Update stream logging to address notebook log colors.
Changes

Reconfigure stream logging logger:

INFO level logs will be sent to stdout
WARNING and above level logs will be sent to stderr

Log all errors to the stream logger
Update docs for both loggers

This has been tested by integration with a python3 notebook docker image & test log messages. Info level messages show up in black, warning+ messages show up in red:

@mikesaelim Can you review? This PR reworks how we configure our stream logger. The build error is the same as ticketed here: https://civisanalytics.atlassian.net/browse/CIVP-18425


Ease GitLab CI usage by providing a ready to use Docker image

Currently the steps to use jreleaser without maven or gradle on GitLab CI are tedious, and do need a lot of additional steps.
Instead of fetching and downloading jreleaser manually, it could be already prepackaged into a ready to use docker image.
As GitLab docker executor is always checking out the project to a structure which somehow reflects the project path, the current limitations of the docker image, with /workspace is limiting.
Furthermore if somebody outside of the javaworld would want to use the jreleaser they most likely only want to have an easy way of just calling jreleaser full-release instead of java -jar jreleaser-cli.jar full-release.
eg the new snippet for GitLab CI would look like
# Create a release
release:
  # using the new image
  image: jreleaser/jreleaser-slim:<version>
  # Bind to `deploy` stage
  stage: deploy
  # Set environment variables accordingly
  variables:
    JRELEASER_GPG_PASSPHRASE: $GPG_PASSPHRASE
    JRELEASER_GPG_PUBLIC_KEY: $GPG_PUBLIC_KEY
    JRELEASER_GPG_SECRET_KEY: $GPG_SECRET_KEY
    JRELEASER_GITLAB_TOKEN: $GL_PAT
    # Disable shallow cloning so that JReleaser can diff between tags
    # to generate a changelog
    GIT_DEPTH: 0
  #  Execute JReleaser
  script:
    - jreleaser full-release

This could be beneficiary in keeping a clean and simple build and reduce the needed boilerplate for the execution of jreleaser.

i would also provide an pull request with the dockerfile etc. I am just curious if i should create also a Dockerfile.tpl and if i should create a new tag, or should i modify the existing one?

I like the idea. Perhaps there could be 2 Docker images: slim and full. Full would required snap and any other tools that the slim image does not offer. The -full image would also require configuration for creating Docker images with JReleaser.
If I understood correctly, when running the new Docker image on GitLab the /workspace volume should be mapped automaticallly?

GitLab maps the projects into a build folder - eg. the project web path is /group/subgroup/project the resulting path for the build within the docker image will be /build/group/subgroup/project, and the whole project is mapped into this folder. Additionally it will also be the entry point for the job.
My plan would be to just generate a wrapping shell script for jreleaser and make it accessible on the PATH for easy usage, and this could than easily be called from anywhere.

OK. I suppose GitLab also sets some default environment variabes that may be automatically exposed to the docker image, in which case the wrapper script can figure out how to adjust paths, right?

https://docs.gitlab.com/ee/ci/variables/predefined_variables.html
Yes there are plenty if needed. Eg. CI_PROJECT_DIR which points to that directory

OK, so at the moment there can be only a single Dockerfile per distribution. If there current behavior and the proposed behavior can live inside the same image then modifying the templates at src/distributions/jreleaser/docker/ would be good enough. Version 0.2.0 does not currently copy additional scripts/files into the assembly directory if not mistaken. It might work if the target executable is automatically placed in src/distributions/jreleaser/docker/assembly/wrapper.tpl and would be mapped to out/jreleleaser/jreleaser/package/docker/assembly/wrapper.
If that's not the case then that's a missing feature that would need to be added.

Just checked an additional files placed under src/distributions/jreleaser/docker/assembly/ are not automatically copied into the container due to the default Dockerfile.tpl in use. The workaround is to generate the template and fix the COPY instruction.
https://github.com/jreleaser/jreleaser/issues/84


Extract first image into the blog image during BlogML import

Now when there is post via metablogapi, the first picture is extracted and put into the "blog image" filed.
It would be cool to do the same during the import from BlogML

Have re-opened this since the PR addresses importing an image if the image exists in the attachments collection but if we want to extract the image based on the first image tag found in the markup, than that's a different story.


feat(ci): srtool to use on-chain-release-build feature

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 11.21%. Comparing base (bae5887) to head (805ae3f).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main     #249   +/-   ##
=======================================
  Coverage   11.21%   11.21%
=======================================
  Files          34       34
  Lines        2577     2577
  Branches     2577     2577
=======================================
  Hits          289      289
  Misses       2285     2285
  Partials        3        3


Adjust defaults for better performance out of the box

This adjusts the default values for batchSizeBytes and concurrentGpuTasks to make concurrent 2x larger and the batch batch 1/2 the original size. In theory this should keep the amount of memory used on a GPU the same, but in practice it usually means a little less maximum memory usage because multiple tasks don't always have their maximum usage at the same time. Although for operations where all of the data for a task has to be kept in GPU memory at once, like some window operations, this is going to make the maximum memory usage much worse.
In practice that is fine because of the reliability retry work that is still ongoing. This should allow us to still run those queries.
I did some testing on dataproc with T4 GPUs using NDS. I kept all of the config settings the default except for enough to set up the cluster and turn on the plugin.
The average time went from a mean time of 27:32 to 23:54. That is a 15.2% speedup.
Of the 103 queries 13 of them got slower by a total of 9.43 seconds ( I can look into why they got slower if someone is interested in me doing that)  and of those only query60, query69, and query76 has a statistically significant slow down according to a T-test with a p-value cutoff of 0.05.
On the flip side query95 got 51% faster and saved a total of 17.17 seconds, and query23_part2 for 44.23 seconds faster (a speedup of only 36%, but still a lot of time).
This should improve the out of the box experience for most customers without any help from the auto-tuner or us.  It is still not perfect, but it is a good step in the right direction.

build


Authentication

@CodiumAI-Agent /review

PR Reviewer Guide 🔍

 ⏱ Estimated effort to review [1-5]
4

 🧪 Relevant tests
No

 🔒 Security concerns
- Sensitive Information Exposure: The use of JWT tokens requires careful handling of secrets and proper configuration of token expiration and renewal. The PR should ensure that the JWT_SECRET is securely managed and not exposed in the code or logs.
- Insecure Authentication Handling: The changes in the user model and the new authentication routes could potentially allow for unauthorized access if not properly secured, especially concerning the handling of Google login and JWT token generation.

 ⚡ Key issues to review

Possible Security Vulnerability: The PR removes the requirement for a password on the user model (password: { type: String }), which could lead to security issues if not handled properly elsewhere in the code.

Authentication Logic Concern: The logic for handling Google logins and sign-ups seems to bypass traditional password checks, which could be a security risk if not implemented with proper checks and balances.

Error Handling: The error handling in the new routes does not differentiate between different types of errors, which could make debugging more difficult and user feedback less clear.


CI/CD setup for beehive repository.

We need to have CI/CD setup to check if any new modifications breaks existing functionality. Also to run static checks.

cc @srivatsav123 @pavan187

can i have a try? But I  have permission to set travis-ci.


[periscope] fix playlist extraction (Issue #9967)

The JSON response changed and the extractor needed to be updated in order to gather the video IDs.

Fixes issue #9967

Cherry-picked in 347227237b5a101c3bed260f8efbdbfe65c5f196, thanks.


[RHCLOUD-16920] Add deployment strategy

Note that merging this will change the deployment strategy on puptoo and others in stage

/retest

/retest


Add ability to include contents of a directory with mayday

Current situation
I want to include the contents of /sys/fs/pstore/ in a mayday tarball in order to capture kernel panic stack traces, but I can't find a way to do it.
The file section only works on regular files and not directories recursively, and I've tried two ways of running a command to get the contents of /sys/fs/pstore:
command:
     {
      "args": ["find", "/sys/fs/pstore", "-t", "f", "-exec", "cat", "{}"],
      "link": "pstore"
      },

and
     {
      "args": ["cat", "/sys/fs/pstore/*"],
      "link": "pstore"
      },

Since the command isn't executed in a shell, globbing doesn't work, and I h ave no idea why find doesn't work, but it doesn't.
I'm also filing a separate issue for including boot logs.
Impact
We have to rely on SSH to get panic information. This is a huge pain.
Ideal future situation
I'm able to include the contents of an arbitrary directory, or find works.
Implementation options
Honestly, I have no idea what the best way of doing this is.

Just FYI,
find /sys/fs/pstore -t f -exec cat {} will not work work.
Please try running find /sys/fs/pstore -type f -exec cat {} \; instead.

PR https://github.com/flatcar-linux/mayday/pull/7 for directory support was merged and scheduled for inclusion in the next Alpha and Edge release, then the following Beta and Stable releases.


Is it safe to override listener callback ?

Hi,
I want to be able to completely stop from listening to a queue if this is possible, otherwise if this is not possible, would it be fine to register a new empty (for example) callback on the same queue ?
Like to unregisted a queue I would put
queueService.listen('queue_1', (message, control) =>  {}, options)

Thank you in advance.

Hi @yanna92yar !
If I understand correctly, you want to register listeners during runtime?
That use case is currently not really supported by us.
Override at the moment is also not supported, but that could be a quick change.

Hi @raschan
Thank you so much for the response !
Yes at runtime; We have been using queueService.listen without any problems.
Could you confirm please that passing a new callback (empty in this case) would simply override the old one ?
Thanks !

nothing special about the callback (if you mean my implementation ?), it is isolated and just run a simple function on message.
So my initial need is not really to replace it, just to unlisten from a queue.

As I said, sadly, that is not supported at the moment. I'll see what can I come up with in the weekend, and get back to you

@yanna92yar added a removeListener function on the QueueService, should work as expected

Thank you so much, I appreciate your responsiveness !
Kindly


Supermium on ReactOS?

Anyone tried Supermium on ReactOS?

I didn't work when I tried it, but it might work with some tweaks

Until asking someone, why don't you try it yourself and report here?

It crashed for me. Here's the stack trace that WinDbg gave me along with some debug output from ReactOS:

It appears to be an exception caused by the process allocating too much memory, likely caused by GetLogicalProcessorInformationEx. Does this build of ReactOS contain the function or is it relying on progwrp?

It is a stub according to https://github.com/search?q=repo%3Areactos%2Freactos GetLogicalProcessorInformationEx&type=code.

I can provide a better stack trace if I had PDBs of the 32-bit version of 121-HF.

Hi. I also want to have PDB-files for 32-bit build of this project.
I have seen that you have created x64 debug-build already with relevant pdb-s:
https://github.com/win32ss/supermium/releases/tag/v121-dbg
But there is only x64, Not x32.

I have now added a 32 bit debugging build.

How do I debug it using WinDbg?

Making Supermium run on XPSP3 is a job for win32ss.
But making Supermium, that already runs fine on XPSP3, running fine on ReactOS, is a job for the ReactOS developers.
We don't want him to hack his application, but we do want to actually improve our OS regarding its compatibility.
This report should be closed. Except from maybe a few tips where we do currently suck, nothing should be asked from win32ss in this context.

There are still cases where it crashes under Windows XP though.

Yes, but that doesn't belong into this ticket either. But deserves its own ticket, if (or as soon) it can be reproduced reliably.

There are already tickets for them. Let's wait to see if it works under ReactOS after they are fixed.

I guess it is a ReactOS bug then.


DBZ-7798 Fix documentation for header variable in filters (part 2)

Fixes DBZ-7798
Refs https://github.com/debezium/debezium/pull/5500

The original PR missed another occurrence of headers vs. header.

@jpechane Sorry for the inconvenience but the original PR missed one occurrence.

Thanks for the catch @joschi, applied!


[SPARK-27263][HistoryServer] Hide Hadoop Properties table in Environment page if it's empty

What changes were proposed in this pull request?
Hadoop Properties in Environment Page is introduced in spark 3.0 version. if we open the older version event log with spark 3.0 history server, hadoop properties tab is showing empty.
To make same as older version, if the hadoop properties table is empty, we are not showing empty table.
How was this patch tested?
manually tested, added the test snap
Before fix

After Fix

Please review http://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Jenkins, ok to test

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9240/
Test PASSed.

Test build #103875 has started for PR 24193 at commit 34a5032.

Test build #103875 has finished for PR 24193 at commit 34a5032.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103875/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9253/
Test PASSed.

Test build #103890 has started for PR 24193 at commit 786da8a.

I would not change this; it's not necessarily better to totally hide the table

Test build #103890 has finished for PR 24193 at commit 786da8a.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/103890/
Test FAILed.

Hi, @shivusondur . We can do this, but we usually don't merge a PR when there is a negative opinion like the above. If you don't mind, could you close this PR? You can use your patch on your internal fork.

@dongjoon-hyun
Thanks for your suggestion, Sure i will close it.
@srowen  and @felixcheung
Thanks for your thoughts and comments

Thank you for understanding, @shivusondur .


Calendar import

I try to import Calendar like this:
import { Calendar } from 'react-datepicker2'
But I get the Error
React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.
Anyhow when I try to use it like this: import Calendar from 'react-datepicker2', it is shown as a DatePicker.

It fixed when I upgraded from 2.0.5 to latest version.


[CONTRIB][CC] Enhance cc.cross_compiler

Enhance cc.cross_compiler to take str argument.
Remove cc.build_create_shared_func as it is dupilicated with cross_compiler
Add examples to cc.cross_compiler

cc @FrozenGene @merrymercy @apivovarov

@FrozenGene please take another look

Thanks @tqchen @jroesch It is Merged.


Added sudo setcap for make install target on linux

Fixes #967

Codecov Report

Merging #968 (9dbaa80) into master (ac59bca) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #968   +/-   ##
=======================================
  Coverage   31.77%   31.77%
=======================================
  Files          94       94
  Lines        9191     9191
=======================================
  Hits         2920     2920
  Misses       5965     5965
  Partials      306      306

Flag
Coverage Δ

unittests
31.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[flutter_tools] Dump backtrace on ios app startup timeout

Add debugging for https://github.com/flutter/flutter/issues/101059 and https://github.com/flutter/flutter/issues/95582

Can you add a test that pauses and dumps the bt to
https://github.com/flutter/flutter/blob/74cdc422077d81f9ab40ed7e7e658d88e42d7a7e/packages/flutter_tools/test/general.shard/ios/ios_deploy_test.dart#L94

Done, PTAL


Scrollbar is not removed when groups are collapsed

Steps to reproduce:
1.) Open the example "Custom Groupings" in the master branch
2.) Collapse as many groups as needed to make the content less high than the grids viewport
Result: The scrollbar stays visible but is not usable.(Seems to be a new one)

Hmm. I can't reproduce this one. What browser are you using?

I'm using Chrome 40.0.2214.93 m. It seems okay with Firefox.

Can you open up a console window to the project and run grunt build, then refresh the page in Chrome and see if that fixes the issue?

I already did this a few times, but i did it again and the problem still remains in chrome.


HDFS-16037. Possible Resource Leak in org.apache.hadoop.hdfs.tools.offlineImageViewer#FSImageLoader

This PR fixes the issue mentioned here.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 17s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s

The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m 45s

trunk passed

+1 :green_heart:
compile
1m 31s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
1m 22s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
1m  7s

trunk passed

+1 :green_heart:
mvnsite
1m 28s

trunk passed

+1 :green_heart:
javadoc
0m 58s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 35s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 23s

trunk passed

+1 :green_heart:
shadedclient
18m 11s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 14s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m  9s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
1m  8s

the patch passed

-1 :x:
blanks
0m  1s
/blanks-eol.txt
The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-0 :warning:
checkstyle
0m 55s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 16 new + 113 unchanged - 1 fixed = 129 total (was 114)

+1 :green_heart:
mvnsite
1m 11s

the patch passed

+1 :green_heart:
javadoc
0m 46s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
1m 15s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
spotbugs
3m 12s

the patch passed

+1 :green_heart:
shadedclient
16m  0s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
365m 31s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 41s

The patch does not generate ASF License warnings.

457m 33s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor

hadoop.hdfs.TestDFSShell

hadoop.cli.TestErasureCodingCLI

hadoop.hdfs.server.namenode.ha.TestBootstrapStandby

hadoop.hdfs.server.namenode.ha.TestEditLogTailer

hadoop.hdfs.server.namenode.TestDecommissioningStatus

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3046/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3046

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 29f8b8f3a197 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c4cf40b9fceeb1cd2178e8b10929f12156eb83b1

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3046/1/testReport/

Max. process+thread count
2711 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3046/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.


'Matrix4Tween' test failing on Windows due to floating point comparison

The following test is failing on Windows:
  test('Matrix4Tween', () {
    final Matrix4 a = new Matrix4.identity();
    final Matrix4 b = a.clone()..translate(6.0, -8.0, 0.0)..scale(0.5, 1.0, 5.0);
    final Matrix4Tween tween = new Matrix4Tween(begin: a, end: b);
    expect(tween.lerp(0.0), equals(a));
    expect(tween.lerp(1.0), equals(b));
    expect(
      tween.lerp(0.5),
      equals(a.clone()..translate(3.0, -4.0, 0.0)..scale(0.75, 1.0, 3.0))
    );
    final Matrix4 c = a.clone()..rotateZ(1.0);
    final Matrix4Tween rotationTween = new Matrix4Tween(begin: a, end: c);

    // Failures on the next two lines.
    expect(rotationTween.lerp(0.0), equals(a));
    expect(rotationTween.lerp(1.0), equals(c));

    expect(
      rotationTween.lerp(0.5).absoluteError(
        a.clone()..rotateZ(0.5)
      ),
      moreOrLessEquals(0.0)
    );
  });

These floating point comparisons are failing due to a difference of values < 1e-16, but this doesn't seem to be an issue on other platforms. Might be worth investigating further according to @Hixie.

Hi @bkonyi
This test no longer seems to fail on any platform.

flutter doctor -v
[√] Flutter (Channel master, 1.21.0-2.0.pre.114, on Microsoft Windows [Version 10.0.18362.900], locale et-EE)
   • Flutter version 1.21.0-2.0.pre.114 at C:\Development\flutter_master
   • Framework revision ddb8e6e3bf (7 hours ago), 2020-07-22 20:00:07 -0700
   • Engine revision dcc9a4048d
   • Dart version 2.9.0 (build 2.9.0-21.0.dev 9dca49e71e)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
   • Android SDK at C:\Users\Isa\AppData\Local\Android\sdk
   • Platform android-30, build-tools 30.0.0
   • Java binary at: C:\Users\Isa\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6626763\jre\bin\java
   • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
   • All Android licenses accepted.

[√] Chrome - develop for the web
   • Chrome at C:\Program Files (x86)\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.6.4)
   • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
   • Visual Studio Community 2019 version 16.6.30309.148
   • Windows 10 SDK version 10.0.18362.0

[√] Android Studio (version 4.0)
   • Android Studio at C:\Users\Isa\AppData\Local\JetBrains\Toolbox\apps\AndroidStudio\ch-0\193.6626763
   • Flutter plugin version 47.1.2
   • Dart plugin version 193.7361
   • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] VS Code (version 1.47.2)
   • VS Code at C:\Users\Isa\AppData\Local\Programs\Microsoft VS Code
   • Flutter extension version 3.12.2

[√] Connected device (5 available)
   • SM G950F (mobile)       • ce12171c51cc001c03 • android-arm64  • Android 9 (API 28)
   • sdk gphone x86 (mobile) • emulator-5554      • android-x86    • Android 11 (API 30) (emulator)
   • Windows (desktop)       • windows            • windows-x64    • Microsoft Windows [Version 10.0.18362.900]
   • Web Server (web)        • web-server         • web-javascript • Flutter Tools
   • Chrome (web)            • chrome             • web-javascript • Google Chrome 84.0.4147.89

• No issues found!

Can you confirm?
Thank you

If you can't confirm I'd just go ahead and close this (I'll have to setup Flutter on my Windows machine again to reproduce which is a bit of a pain).

Alright, closing as not reproducible.


Rollups: null amount doesn't prevent count rollups

Critical Changes
Changes

Count rollups work even with a null amount on the Opportunity.

Issues Closed
New Metadata
Deleted Metadata

closing this because it got rolled into another branch/PR


Merge feature people

Merging branch feature/people into master.
feature/people adds support for multiple search resources, tabbed results, breadcrumbs, and profile pages. These features are currently disabled/hidden (except tabs and breadcrumbs).

The last commit has some new changes that have not been reviewed yet.

cc @jinhyukchang

@feng-tao I'll cleanup the test code in a follow up commit.

thanks @danwom


[WIP] Fix FunctionNode.retained_outputs

func.outputs is a tuple of weakrefs of VariableNodes.

[ ] Add test

Added a test.
Without the fix, the test fails with the following message, while I've not investigated why the grad wasn't computed.
        # (x: Variable) requires grad
        # (y1_grad: ndarray) does not require grad
        gx, = chainer.grad([y1], [x], [y1_grad], enable_double_backprop=True)

        # assert gx == exp(x) * y1_grad
        xp.testing.assert_allclose(
            gx.array,
            xp.exp(x.array) * y1_grad)

        gx_, = chainer.grad([gx], [x], [x_grad_grad])
        xp.testing.assert_allclose(
>           gx_.array,
            gx.array * x_grad_grad)
E       AttributeError: 'NoneType' object has no attribute 'array'

jenkins, test this please.

Jenkins CI test (for commit 260e0d0725621414bfe10576a156b5140c6aefc0, target branch master) succeeded!

LGTM!


Create Push Notification UI/UX for User Engagement

As a member of the development team, I want to design and implement a compelling push notification UI/UX system to enhance user engagement within the Cashback Connections application. The objective is to create a notification system that effectively communicates with users, reminding them of potential deals, providing updates on their earnings goal progress, and offering tooltips to optimize their payouts. Key goals include:

Notification Types: Define and design different notification types, such as deal alerts, earnings updates, and tips for increasing cashback earnings. Each type should have a distinct and visually appealing representation.

Visual Consistency: Ensure that the notification UI/UX maintains visual consistency with the overall design of the Cashback Connections application. Notifications should be visually cohesive with the existing UI elements.

Interactive Elements: Integrate interactive elements into the notifications. For example, allow users to directly access relevant deals, earnings details, or tips by tapping on the notification.

Scheduled Notifications: Implement a scheduling system for notifications to send them at appropriate times. For instance, deal alerts may arrive when users are near participating merchants.

Localization: Consider localization aspects to support different languages and regions. Notifications should be clear and relevant to users across various locations.

By creating a push notification UI/UX system, we aim to enhance user engagement within the Cashback Connections application. Users should receive valuable information and reminders related to deals, earnings, and optimizing their cashback rewards, leading to a more rewarding and interactive user experience.

Notification Types
1. Earnings Notifications
Purpose: Inform users about their earnings, cashback milestones, and cashback window updates.
Examples:

"Congratulations! You've earned $10 cashback." (I am pretty sure that Kard has this built in to their API. Make sure to check during the scoping.)
"You're just $5 away from your next cashback milestone!"

2. Reminder Notifications
Purpose: Remind users of expiring cashback windows, incomplete actions, or deadlines.
Examples:

"Heads up! Your cashback window expires in 2 days."
"Quick tip: Scan your recent purchases and unlock more savings."
"Link your 7-11 account to earn more!"

3. Offer Notifications
Purpose: Highlight new offers, exclusive deals, and opportunities to earn more cashback.
Examples:

"Discover new offers at your favorite stores and boost your earnings."
"We found a deal for you! Get 5% cashback at McDonald's this weekend."
"New offers available at your Walmart!"

4. Redemption Notifications
Purpose: Guide users through the cashback redemption process. (Not sure if this is something Propel handles automatically @mike-audi I know you had mentioned something about cashing out. Also here is the song "Cashin' Out" by Ca$h Out)
Examples:

"Your cashback is ready for redemption.
"Redeem your cashback earnings in just a few clicks."


"Toggle Terminal" Keyboard Shortcut not working | Code Exploration

VSCode Version: Code - Exploration Version 1.34.0-exploration 2019-05-09T07:43:26.671Z
OS Version: MacOS 10.14.4

In the latest version of VSCode Exploration the keyboard shortcut to call the integrated terminal ctrl+` does not work. In VSCode Insider and in VSCode Stable it works without problems. All settings are identical (synchronized with "Settings Sync").
What's also very strange is that if I want to change the keyboard shortcut manually and type in the right key combination, ctrl+[IntlBackslash] is displayed.

@electricarts  can you check if this happens on the Insiders build?

No. In the Stable and the Insider Build (Version 1.34.20-insider) the Key Command works.

This is a known issue until we pick up the official electron builds.


WASM serialization calls std::vector::resize(SIZE_MAX)  which always leads to crash

file: libraries/wasm-jit/Source/WASM/WASMSerialization.cpp
line: 384
OutputStream::capacity() always returns SIZE_MAX, so std::vector::resize(SIZE_MAX) always leads to crash. Please comment it out. Thanks.
void serialize(OutputStream& stream,UserSection& userSection)
{
         userSection.data.resize( sectionStream.capacity() ? sectionStream.capacity() : 1 );
}

The latest WAVM source code has commented it out, but EOS doesn't synchronize with it.
https://github.com/EOSIO/eos/blob/master/libraries/wasm-jit/Source/WASM/WASMSerialization.cpp

which version of EOS did you find to have this bug?

just the latest version of EOS,  master branch.

Hmm.. it indeed looks like a bug

This serialize() function is for saving compiled WASM bytecode to disk file, which is seldom used.

Is it used anywhere in EOSIO? There are a many parts of WAVM that are not used in EOSIO and at least on first glance I'm not seeing where this is used. If it is possible to encounter this crash with nodeos or cleos I would encourage you to file details at
https://hackerone.com/eosio
because it would likely be eligible for the bug bounty problem.

It is used by the assembly utility "eosio-wast2wasm" to save compiled WASM bytecode to file.
Mybe it's obsolete due to the standalone EOS contract sdk?

Okay that is true, I had forgot about eosio-wast2wasm since its purpose has been entirely superseded by eosio.cdt. I will see about removing this tool from future releases.

Tool removed from 1.7.1 & 1.8 thanks


Error in splitting the edgelist

@LucaCappelletti94 Hi Luca, I am using Graph embedding using Skipgram jupyter notebook file to embed a heterogenous graph containing genes as nodes and two different edge types. I receive this error message when I run Split the graph into two edge partitions:
ValueError                                Traceback (most recent call last)
 in
1 assert graph > training
2 assert graph > validation
----> 3 assert (training + validation).contains(graph)
4 assert graph.contains(training + validation)
5 assert not training.overlaps(validation)
ValueError: The two given graphs have overlapping edges, this is not supported since it's an undefined behaviour.
Can you please help me with this issue? Thanks.

Hello Vida, could you send me the report of the graph (and the graph files)?

I have identified the root of the issue (which is also relevant for a previous problem encountered by @justaddcoffee ). We have not defined the behaviour of the connected holdouts for multigraphs (graphs with multiple edge types).
We should have a call on the topic, to choose how to proceed.

Hello Vida, could you send me the report of the graph (and the graph files)?

Hi Luca,
{'selfloops_rate': '0.000014785572238609565',
'bidirectional_rate': '1',
'unique_node_types_number': '0',
'degrees_mode': '1',
'degrees_mean': '48.229260755883054',
'degrees_max': '1399',
'degrees_median': '15',
'singleton_nodes': '0',
'is_directed': 'false',
'unique_edge_types_number': '2',
'strongly_connected_components_number': '93',
'nodes_number': '16828',
'connected_components_number': '93',
'edges_number': '811602',
'density': '0.002866012642969043',
'traps_rate': '0',
'degrees_min': '1'}

I have identified the root of the issue (which is also relevant for a previous problem encountered by @justaddcoffee ). We have not defined the behaviour of the connected holdouts for multigraphs (graphs with multiple edge types).
We should have a call on the topic, to choose how to proceed.

Sure. Thanks. I will schedule a meeting with you and Peter. Does 10 am (ET) = 4 pm (Italy) work for you?

I could do 10AM

@LucaCappelletti94 Luca, can we talk about this issue tomorrow? Thanks.

@LucaCappelletti94 Sorry. I missed the meeting because of some issues with outlook on my machine. Did you discuss this problem?

What about 11 am (ET) = 5pm Italy?

We are addressing this issue in this new holdout method: https://github.com/LucaCappelletti94/ensmallen_graph/issues/16

I close this issue as we are addressing it in LucaCappelletti94/ensmallen_graph#16 and https://github.com/monarch-initiative/syntheticLethalityNetwork/issues/231