Docs (zenith): generate CLI reference

The reference docs for the CLI has been managed manually until now. This is only for the new "zenith" docs.
👀 Preview docs
To generate
go run ./cmd/dagger gen

Experimental commands

[!WARNING]
In order for commands to be picked up in docs, I removed the Hidden option in "zenith" commands (context), and "marked" them as experimental instead. \cc @shykes @sipsma

Modules group
I placed the Dagger modules commands in a group so it's presented separately from the others, and clearly marked Experimental:

❯ dagger help
The Dagger CLI provides a command-line interface to Dagger.

Usage:
  dagger [command]

Dagger Modules (Experimental):
  call        Call a module function
  functions   List available functions
  module      Manage Dagger modules

Additional Commands:
  completion  Generate the autocompletion script for the specified shell
  help        Help about any command
  login       Log in to Dagger Cloud
  logout      Log out from Dagger Cloud
  query       Send API queries to a dagger engine
  run         Run a command in a Dagger session
  version     Print dagger version

[truncated]

Listing instead of hiding is better if we want people to try this out.
Experimental notice in --help
You can still use and see the help for hidden commands, it just doesn't show on parent commands, but if you happen to go straight to dagger call --help, there was no indication it's experimental. I've added a section in the --help command to clarify this.

❯ dagger mod --help
Manage Dagger modules. By default, print the configuration of the specified module in json format.

Usage:
  dagger module [flags]
  dagger module [command]

Aliases:
  module, mod

EXPERIMENTAL:
  dagger module is currently under development and may change in the future.

Examples:
dagger mod -m /path/to/some/dir
dagger mod -m github.com/dagger/hello-dagger

Available Commands:
  init        Initialize a new Dagger module
  install     Add a new dependency to a Dagger module
  publish     Publish a Dagger module to the Daggerverse
  sync        Synchronize a Dagger module

[truncated]

Experimental notice in reference docs
The current reference docs has a note on experimental commands, in addition to another one at the top of each page (since it's the zenith docs). In this PR there's no control over adding it back until we fork the code that generates to content (see next section), or manipulate the produced output.
Since the whole docs is marked "experimental", and it's targeted to zenith, I don't think it's worth it to worry about this.
What's next?
We're using a cobra util to generate the docs. I've reimplemented part of it for greater control over the .mdx file that gets written. We can take even more control by forking and changing the rest of the code if we want to make some improvements. I suggest we leave that for another PR though.
I think this is good enough to replace what we have now. The priority is providing up-to-date information in docs, especially since we've merged changes that remove the download, up , and shell commands, but also change how dagger call works.
Some changes I'd like to make later (in docs):

fix dagger completion, by wrapping examples in long description in code blocks (regex)
fix casing in SEE ALSO lists
put usage line just below short description
trim examples in doc generation rather than on command definition

go run ./cmd/dagger gen

Should this command be added to the Docusaurus startup so the reference is generated every time?
If so, should the reference MDX file be added to  docs/.gitignore?

The current reference docs has a note on experimental commands, in addition to another one at the top of each page (since it's the zenith docs). In this PR there's no control over adding it back until we fork the code that generates to content (see next section), or manipulate the produced output. Since the whole docs is marked "experimental", and it's targeted to zenith, I don't think it's worth it to worry about this.

I did not understand the above. I see that the experimental warning appears as expected in the generated doc so I'm not clear on what the impact is, or if any further changes are needed when these docs are promoted to current: https://github.com/dagger/dagger/pull/6509/files#diff-4ecc8c7f989aaa70051d50def2004e291ef32f25099e3cf57d8c69ce54396f90R11

Right now there's two notices:

In this PR you only have the first one.

go run ./cmd/dagger gen

Should this command be added to the Docusaurus startup so the reference is generated every time?

Since we want to modularize these things, I was thinking about adding it there soon. But putting it on docusarurus startup sgtm! How do you do that?

If so, should the reference MDX file be added to docs/.gitignore?

I think it's ok to commit this file, we can just add a linguist-generated to .gitattributes.

Right now there's two notices:
In this PR you only have the first one.

OK thanks. I think this is fine.

Should this command be added to the Docusaurus startup so the reference is generated every time?

Since we want to modularize these things, I was thinking about adding it there soon. But putting it on docusarurus startup sgtm! How do you do that?

Similar to what we did for the API docs, you could add a command to package.json (https://github.com/dagger/dagger/blob/main/docs/package.json#L15) and then invoke it as part of the netlify build (https://github.com/dagger/dagger/blob/main/docs/netlify.toml#L2). I believe this was originally set up by @slumbering, pinging him in case he has a different suggestion.

If so, should the reference MDX file be added to docs/.gitignore?

I think it's ok to commit this file, we can just add a linguist-generated to .gitattributes.

OK

Should this command be added to the Docusaurus startup so the reference is generated every time?

Since we want to modularize these things, I was thinking about adding it there soon. But putting it on docusarurus startup sgtm! How do you do that?

Similar to what we did for the API docs, you could add a command to package.json (https://github.com/dagger/dagger/blob/main/docs/package.json#L15) and then invoke it as part of the netlify build (https://github.com/dagger/dagger/blob/main/docs/netlify.toml#L2). I believe this was originally set up by @slumbering, pinging him in case he has a different suggestion.

I decided to place it in mage:

./hack/make docs:generateCli - (new) just the cli reference docs
./hack/make docs:generate - the above + graphql schema (previous behavior)
./hack/make generate - (new) sdk:all:generate + docs:generate (\cc @vito)

LGTM! Helder also separately let me know that this is good to merge today, so doing that now


[v1.10] Consider VPC's secondary CIDRs during cilium_host IP restoration

This is a custom v1.10 backport of

#19341 by @hemanthmalla

Once this PR is merged, you can update the PR labels via:
$ for pr in 19341; do contrib/backporting/set-labels.py $pr done 1.10; done

@gandro changes LGTM. Thanks for backporting this. These are the exact same changes going into 1.11 as well right ?

Oh, I didn't realize the v1.11 backport also had conflicts. I did the backport independently of that, but it looks like the main conflict (in the if ipv6 branch in restoreCiliumHostIPs) was resolved exactly in the same manner. So the two look identical to me.

/ci-aks-1.10

/ci-aks-1.10


Discover the repository branch layout link doesn't seem to work at all

Nothing happens when the link is clicked (not only during project indexing) :/
Discover Branch Layout action is available under Ctrl+Shift+A and can be launched, however.
~It would be nice to find the other places that can be affected by indexing (i.e. are not DumbAware although they should be), or even maybe provide a more systematic way to detect them.~ EDIT: likely not relevant for this issue

Tested on 0.7.0 (released)
Works for both missing- and empty- machete file.

Slack discussion update
A possible solution is to use a button instead of the link.
We gain the ability to test the feature in particular then.

I also confirm. Link is not treated as link but rather ordinary, blue text.


Move throttle check from land detector to posctrl

This commit is an attempt to fix a race condition happening on takeoff
between the land detector and the multicopter position controller.
Previously, an auto-takeoff leads to the following events:

A takeoff setpoint is given.
The thrust setpoint spikes because we don't enter smooth takeoff yet.
The land detector detects a takeoff because of the high thrust.
The position controller sees the landed state transition and
initiates the smooth takeoff. Thrust goes back down.
Depending on control gains the takeoff is successful or fails
if the smoothing takes too long which causes thrust to be too low, so
the land detector detects land again.

The two obvious problems with this are:

The intermittent spike.
The failed takeoff because of the smoothing leads to a delay..

With this change, the logic for a takeoff detection is moved from the
land detector to the position controller.
The events are now:

A takeoff setpoint is given.
The position controller detects the takeoff setpoint and initiates
the smooth takeoff.
As thrust ramps up, the land detector detects the take off.

In the same way, we now detect the intent to takeoff in manual,
altitude, control, position control in the position controller instead
of in the land detector.
Most credit of this fix goes to @Stifael and @MaEtUgR.
This works in jMAVSim but needs outdoor testing.
Outdoor tests to do:

Takeoff and land in manual, check if land detection works as expected.
Takeoff and land in POSCTL, check if land detection and auto-disarm work as expected.
Do a mission including takeoff and land, check land detection, auto-disarm.
Do a mission where you are already flying when you upload the mission which includes (by accident) a takeoff waypoint).

there is one small bug.
if I am in position control and arm, then the vehicle should stay idle until the throttle is above some threshold. however, it ramps up right after I arm.

Thanks @MaEtUgR. I'll tag it for test flights, and propose to include it for 1.7.
Tests to do:

Takeoff and land in manual, check if land detection works as expected.
Takeoff and land in POSCTL, check if land detection and auto-disarm work as expected.
Do a mission including takeoff and land, check land detection, auto-disarm.
Do a mission where you are already flying when you upload the mission which includes (by accident) a takeoff waypoint).

ran a few tests on a pixhawk 1 with v3
https://logs.px4.io/plot_app?log=437ccce1-e95a-476a-ae29-5412f55d578b
https://logs.px4.io/plot_app?log=93035e89-d736-406c-8edf-c05c207582cc
https://logs.px4.io/plot_app?log=3dd22574-1837-4c6a-81ce-93e884d57fe6
stable take-offs and landing; slight bounce when touching down in position mode but overall good performance

@santiago3dr thank you for testing this!

@bkueng one thing I see looking at the log is that CPU usage spikes right before arming. Could it be something busy looping for the land detection or is this usual?

There's a spike after disarming. This is normal and was there before, but it could have become more visible now due to shifting things a bit. It's the param saving on the lpwork queue (saving total flight time or updated ekf mag bias params).

@bkueng thanks. That's all good then.

I tested it as well with aero. Takeoff and landing for manual, altitude, position, auto takeoff, reposition and mission were all as expected. No false positive.
i think this is good to go


Travis coverage

This change is

Coverage decreased (-4.09%) to 61.684% when pulling 109c5ae7e9f446eed5b052edc9ba56edda705d8f on tyll:travis_coverage into 48ed8dcc465e920c66b102d6025389084ece76b7 on nmstate:master.

Coverage decreased (-4.09%) to 61.684% when pulling 109c5ae7e9f446eed5b052edc9ba56edda705d8f on tyll:travis_coverage into 48ed8dcc465e920c66b102d6025389084ece76b7 on nmstate:master.

I do not understand the intent in this PR.

Why path to py3.8 is added? Do we have tests running with py3.8?
The added path/s for tox also seem strange, these should have been managed inside the tox virtenv for the things running with tox. The existing paths worked for the integration tests which we do not run from tox.
The artifact addition of dmesg logs are unrelated to the coverage, unless I miss something.

I do not understand the intent in this PR.

Why path to py3.8 is added? Do we have tests running with py3.8?

Uh, I confused this with the system role. Fedora 32 is going to use Python 3.8. I can remove the commits from this PR for now.

The added path/s for tox also seem strange, these should have been managed inside the tox virtenv for the things running with tox. The existing paths worked for the integration tests which we do not run from tox.

What do you mean with managing the paths inside the tox virtenv? It is the config file for coverage that we use to fix the paths before uploading the files to coveralls.

The artifact addition of dmesg logs are unrelated to the coverage, unless I miss something.

I can put this into its own PR. When I submitted the PR it looked like NM died (the dbus service was not available) but it was not clear from the log files. I hoped to get some info from dmesg but it seems it did not die, now.

Changes do not affect the production code and therefore we can skip the CI verification on an up-to-date branch (change rebased).


graph.getPluginInstance('fullscreen') return undefined ,the graph is a instance of Graph

Describe the bug / 问题描述
const fullScreenPlugin: Fullscreen = graph.getPluginInstance('fullscreen');
console.log(fullScreenPlugin);//undefined
fullScreenPlugin.request();
Reproduction link / 重现链接
No response
Steps to Reproduce the Bug or Issue / 重现步骤
No response
G6 Version / G6 版本
🆕 5.x
Operating System / 操作系统
macOS
Browser / 浏览器
Chrome
Additional context / 补充说明
No response

Did you config fullscreen plugin in graph options? Could you provide the codes.

const fullScreenPlugin: Fullscreen = graph.getPluginInstance(
    'plugin-fullscreen-0',
  );
  fullScreenPlugin.request();

生效了。
原因是 graph.context.plugin.extensionMap是plugin-fullscreen-0不是fullscreen
但是用起来很别扭，期待团队早日更新

Did you config fullscreen plugin in graph options? Could you provide the codes.

Yes,this is my code
plugins: [
      'minimap',
      'fullscreen',
      ...
]

my dependencies version is "@antv/g6": "^5.0.16",
you can try it.

The main reason is that once you do not assign a key for the plugin, G6 will generate one automatically. Hence, if you want to get the plugin instance, you'd better configure as follows:
Graph options:
plugins: [
  'minimap',
  {
    type: 'fullscreen',
    key: 'fullscreen'
  }
]

Use:
import type { Fullscreen } from '@antv/g6';

const fullscreen = graph.getPluginInstance<Fullscreen>('fullscreen');

@Yuhemei Hi, we enhanced the getPluginInstance API in https://github.com/antvis/G6/pull/6215, you can use it in the next version, but its return is ambiguous, so it will print a warning in console.


Add HTTPBoot support

This is a series of patches to add HTTPBoot support to shim.

Updated the headers and wording.

I've tested the patches in Plugfest 2016, and it worked on the systems that support HTTPBoot IPv4/IPv6.

Thanks, pushed to master.


adding molecule class that will read xyz and sdf

Everything looks fine! This closes #1! We closed our first issue!!


Update github actions.

Describe the bug
The CI on GitHub is now reporting deprecation warnings about actions that use Node 16. Most (all?) actions we use now seem to have rolled out Node 20 versions which we can drop in.
To Reproduce
Look at reports from github actions.

The latest versions of the actions involved in this issue are checkout@v4 and setup-python@v5. I've submitted a PR to check if the updated versions will solve the issue.


infomodel artifacts repository pom id and naming

ID and naming of infomodel artifacts should be changed to:
<repository>
    <id>eis-ids-public</id>
    <name>Releases of IDS Infomodel (IAIS)</name>
    <url>https://maven.iais.fraunhofer.de/artifactory/eis-ids-public</url>
</repository>

https://github.com/International-Data-Spaces-Association/IDS-Messaging-Services/commit/98239bcec979d57519d8bcda17f5ec8a8dd330ea


replace libpng from google source to github source

since google source will be blocked for people behind the wall, we could use the official release of libpng in github

Can one of the admins verify this patch?

@girving: glennrp maintains libpng so this seems like a trustworthy github dependency -- what do you think?

Seems fine to me.  Note that the only risk of attack occurs when we change the hash.

Jenkins, test this please.


What is the best way to install fastlane

Question Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Question Subject
Hi,
I don't have a clear idea about this. What is the best way to install fastlane?
Very often I have problems with versions and plugins...
I'm using Catalina.
Should I use RubyGems or Homebrew?
Some people say I shouldn't use ruby included in the operating system, and they recommend rvm (for having different versions of ruby) and bundler (to manage gems).
Is that the best way?
When using rvm, should I use "sudo gem install fastlane -NV" or "gem install fastlane -NV"?
Thanks a lot.

Use bundler and keep your ruby version up to date.

@Cyberbeni Thanks.
But, if I do that, does that mean I will use ruby included with Catalina?
I have read that is not a good idea.


nodejs append records api

Awesome to see this!


Robot arm flailing wildly during startup before going to home position.

There was a stray '0 position' set instead of the proper 'home position'.
Fixed in 10dc643f7ae5c002b24dad995419b5eaa108fd9b


Zonestamp breaks when a query parameter is added

Original https://github.com/hartman/zonestamp-toolforge/issues/1 by @tgr

Works: https://zonestamp.toolforge.org/1618671635
Doesn't work: https://zonestamp.toolforge.org/1618671635?fbclid=IwAR3bJL9ows_qdHHrsXwMvBRtErrvBsVdMD8XinrX2k9RE3bV7916Z4Yq_dI
Obviously this is a big problem for sharing events on social media.
Upstream does not seem to have this issue: https://zonestamp.com/1617962599?fbclid=IwAR3bJL9ows_qdHHrsXwMvBRtErrvBsVdMD8XinrX2k9RE3bV7916Z4Yq_dI

We modified the .lighttpd file config
Then we learned we had to do webservice stop/start instead of webservice restart


Implicit package selection

As noted in #35, templ currently requires a `{% package "packageName" %} at the top of each file.
This is the same behaviour as Go, but to make it faster to write templates, the following approach could be used:

[ ] Ensure that the parser supports missing package instructions, and inserts them into the object model.
[ ] Ensure that templ fmt inserts missing package instructions.

The automatic package algorithm:

Uses the contents of the package instruction in the *.templ file if there is one.
Uses main as the package if a directory context is not available.
Uses the name of the directory as the package name, but lowercased / adjusted as per https://go.dev/ref/spec#identifier

This is simpler than attempting to read any Go files that already exist in the directory and will work for most cases.

To test the fmt command, I used a sample file:
{% templ test() %}
Hello
{% endtempl %}

templ fmt rewrote it to include:
{% package testimplicitpackage %}

Closed in https://github.com/a-h/templ/commit/4234940d8305b6cb025fc26fbd3f945cc2fbe329


ServeTypeScript import statement only imports a single file

Summary
When using ServeTypeScript to import multiple typescript files, the generated file (in-memory), contains only one typescript file, and the original file content selected in config doesn't appear in the memory. Example, if you have 4 files: main.ts, a.ts, b.ts, c.ts, and main.ts import all 3 files, only one of them will appear in browser, and the main.ts content is missing in the memory file.
Steps To Reproduce The Bug

Write the config choosing the realPathSync of main.ts file

import { ServeTypeScript } from "../deps.ts";
const serveCompiledTs = ServeTypeScript({
  files: [
    {
      source: Deno.realPathSync("./frontsystem/main.ts"), // the path to the actual TypeScript file
      target: "/ts/frontsystem.min.ts",
    },
  ],
});

Write main.ts to import 4 other files

//main.ts
import { A } from "./models/A.ts";
import { B } from "./util/B.ts";
import { C } from "./views/C.ts";
import { D } from "./views/D.ts";
const B = new B();
console.log("I'm working");
//models/A.ts
class A {
    public name: string;
    constructor(){
        this.name = 'name';
    }
}
//same to other files

Run the server.
Verify the file at the browser.

Expected Behavior
All files imported together
Suggested Solution(s)
Still learning, sorry
Additional Context
Files used in the original problem has more than 300 lines each

I believe this is because Deno.compile isn't converting the export lines. @Jictyvoo the resulting file only shows the contents of one file because the compiled file has errors when it's compiled, whcih are:

const B = new B() will not work (same goes for other files, external issue), and must be changed to const b = new B().
Deno.compile isn't converting export syntax (external/internal issue)

Currently checking if Deno.compile is acting as it should
i think this highlights that we should throw errors in more cases, such as these so it doesn't 'look like' everything went ok when the server is ran, when in reality, it didn't
FYI The errors seen are from viewing the console in the browser - You can see the compild result by running Deno.compile in the deno repl

UPDATE: Seems both Deno.compile and Deno.transpileOnly won't strip exports, essentially not making them browser compatible - @crookse i think we might have to go with https://doc.deno.land/builtin/unstable#Deno.bundle

@Jictyvoo for the time being, you might have to use deno bundle to manually transpile the files

@ebebbington thanks for the support.
On my example const B = new B() was incorrect, is b sorry for the error.
Will you update the middleware to use Deno.bundle?

@Jictyvoo it would need to be discussed first, but I personally think we’ll end up going with it as it seems to be the only solution

@Jictyvoo , this will be released in the next 24 hours. stay tuned!


fix: modify the download link of ingress-controller 0.1.0

Fixes:
modify the download link of ingress-controller 0.1.0
Related to : https://github.com/apache/apisix-ingress-controller/issues/146

@gxthrj Note, all unofficial actions are blocked, i will update the website manually today.

The fix is wrong; please see the original issue for details


Fix thread-safety in C API's PredictSingleRow

The single row predictor methods in the C APi are not thread safe as reported in https://github.com/microsoft/LightGBM/issues/3751 and https://github.com/microsoft/LightGBM/issues/3675. This fixes both reports. Thank you https://github.com/tarunreddy1018 for the detailed reports!
By using a unique lock instead of the shared lock the timings are very similar, but predictions are correct.
Remarks for future work:

Even so, by designing a small C++ benchmark with a very simple LGBM model, more threads on a simple model are slower than the single-thread case. This is probably due to very small work units, the lock contention overhead increases.
We should in the future benchmark with more complex models to see if supporting
threading on these calls is worth it in performance gains.
If not, then we could choose to not to provide thread-safety and remove the locks altogether for maximal throughput (though people that didn't read the documentation carefully might be surprised that such methods were not thread-safe).

We should in that case use non-shared resources so there is no synchronization required and multiple calls can be issued in parallel with no lock contention.

See https://github.com/microsoft/LightGBM/issues/3751 for timings of the small benchmark and the benchmark gist https://gist.github.com/AlbertoEAF/5972db15a27c294bab65b97e1bc4c315

Hello, can anyone merge this fix?

Hello, can anyone merge this fix?

Hi @AlbertoEAF
Is that possible to expose single row related APIs in python/R package?

Hi @AlbertoEAF
Is that possible to expose single row related APIs in python/R package?

Hello @guolinke :)
It's totally possible, their API are very similar to the non-single row methods so it shouldn't be difficult at all.
In python's case we could replace the input pandas dataframe by something lighter like a numpy array.

Hello @guolinke :)
It's totally possible, their API are very similar to the non-single row methods so it shouldn't be difficult at all.
In python's case we could replace the input pandas dataframe by something lighter like a numpy array.


open-watcom-v2-unwrapped: unstable-2023-03-20 -> unstable-2023-05-17

Description of changes
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

open-watcom-v2
open-watcom-v2-unwrapped

open-watcom-v2.passthru.tests passes.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build open-watcom-v2 open-watcom-v2.passthru.tests

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/2246


./initrd-flash: line 292: flash.idx: No such file or directory

Hi. I was trying to flash my ORIN NX 16 GB + custom carrier but now I get these errors:
1 > sudo ./initrd-flash
Starting at 2024-04-15T12:35:37
Machine:      custom-carrier
Rootfs device: nvme0n1p1
Found Jetson device in recovery mode at USB 1-6
== Step 1: Signing binaries at 2024-04-15T12:35:37+01:00 ==
cp: cannot stat 'signed/*': No such file or directory
cp: cannot stat 'signed/flash.xml.tmp': No such file or directory
sed: can't read flash.xml.tmp: No such file or directory
cp: cannot stat 'signed/*': No such file or directory
cp: cannot stat 'signed/flash.xml.tmp': No such file or directory
sed: can't read flash.xml.tmp: No such file or directory
./initrd-flash: line 292: flash.idx: No such file or directory
ERR: no SPI or eMMC boot partition entries found
ERR: signing failed at 2024-04-15T12:35:42+01:00

This started happening randomly, I could flash this same image yesterday with no problems.
Any idea or how I can debug this?

Have you looked in the log file to see where the signing failed?
And have you followed the guidelines on the wiki for creating a custom MACHINE definition?

Welcome to Tegra Flash
version 1.0.0
Type ? or help for help and q or quit to exit
Use ! to execute system commands

[   0.0270 ] tegrasign_v3.py --key None --getmode mode.txt
[   0.0272 ] Assuming zero filled SBK key
[   0.0245 ] tegra234-p3767-0000-p3509-a02.dtb has no overlay_dtb files.
[   0.0245 ] Concatenating dtbo files to tegra234-p3767-0000-p3509-a02.dtb
[   0.0249 ] Concatenating L4TConfiguration-rcmboot.dtbo,tegra234-p3767-overlay.dtbo,tegra234-p3767-0000-p3509-a02-hdr40.dtbo to tegra234-p3767-0000-p3509-a02_overlay.dtb
[   0.0251 ] Concatenating bl dtb:(tegra234-p3767-0000-p3509-a02_overlay.dtb), to cpubl binary: rcmboot_uefi_jetson.bin
[   0.0277 ] Get magic id
[   0.0281 ] tegraparser_v2 --get_magic bootloader_stage2
[   0.0285 ] CPBL
[   0.0287 ] partition type bootloader_stage2, magic id = CPBL
[   0.0313 ] tegrahost_v2 --chip 0x23 0 --align rcmboot_uefi_jetson_with_dtb_aligned.bin
[   0.0320 ] tegrahost_v2 --chip 0x23 0 --magicid CPBL --appendsigheader rcmboot_uefi_jetson_with_dtb_aligned.bin zerosbk
[   0.0325 ] adding BCH for rcmboot_uefi_jetson_with_dtb_aligned.bin
[   0.1251 ] tegrasign_v3.py --key None --list rcmboot_uefi_jetson_with_dtb_aligned_sigheader.bin_list.xml --pubkeyhash pub_key.key --sha sha512
[   0.1252 ] Assuming zero filled SBK key
[   0.1334 ] Warning: pub_key.key is not found
[   0.1311 ] tegrahost_v2 --chip 0x23 0 --updatesigheader rcmboot_uefi_jetson_with_dtb_aligned_sigheader.bin.encrypt rcmboot_uefi_jetson_with_dtb_aligned_sigheader.bin.hash zerosbk
[   0.1391 ] Copying rcmboot_uefi_jetson_with_dtb_sigheader.bin.encrypt to /media/user/builds/myos.tegraflash
[   0.1391 ] Signed file: /media/user/builds/myos.tegraflash/rcmboot_uefi_jetson_with_dtb_sigheader.bin.encrypt
ERR: signing failed at 2024-04-15T11:58:59+01:00

Yes. I was able to flash the same image days ago (no modifications).

I think this issue started after I started messing around with i2cset

That log extract doesn't look complete - there's likely an error being reported by the NVIDIA tools somewhere earlier in the log.
Adding some tools like i2c-utils to your build is unlikely to cause a flashing failure.  More likely it's something to do with your storage layout file.

Hi. Sorry for delaying, the workaround and problem are described here: https://forums.developer.nvidia.com/t/re-flashing-orin-fails-after-using-i2cset/289658

I'm gonna close this issue then. Any objection or concern ?

I'm sorry to open that again. I'm facing the exact same problem when I'm trying to make a demo for disk encryption. So after making a small data-partition.img and encrypting it with luks passphrase. I've modified also the sizes in external-flash.xml.in. But at the end I get that response. If you know what is root cause of such problem would be helpful.
Starting at 2024-08-28T05:26:43+02:00 Machine:       p3509-a02-p3767-0001 Rootfs device: nvme0n1p1 Waiting for Jetson to appear on USB.........[found: 3-2.4] == Step 1: Signing binaries at 2024-08-28T05:26:51+02:00 == cp: cannot stat 'signed/*': No such file or directory cp: cannot stat 'signed/flash.xml.tmp': No such file or directory sed: can't read flash.xml.tmp: No such file or directory == Step 2: Boot Jetson via RCM at 2024-08-28T05:27:18+02:00 == Found Jetson device in recovery mode at USB 3-2.4 == Step 3: Sending flash sequence commands at 2024-08-28T05:27:23+02:00 ==


Bug: Try to get device model list through the API

I'm trying to use the API to get device models and I have this error :

I tried to get the device list to try another command and I had no problem to do so :

I had an older version of the portal, device model endpoint had a different name.


Battery Example?  Much of the AXP2101 support doesn't work or just returns junk.

Using the V1.1 with 0.2.0 the battery doesn't appear to work at all.  It did not charge on ANY usb power source.
It will not turn on without USB power.
In my loop I have:
`
if (M5.Axp.isCharging())
{
M5.lcd.clearDisplay(TFT_BLACK);
M5.Lcd.setCursor(0, 0);
M5.Lcd.println("Charging...");
M5.Lcd.printf("%0.2f% (%0.0fma) %0.2fV \n", M5.Axp.GetBatteryLevel(), M5.Axp.GetBatChargeCurrent(), M5.Axp.GetBatVoltage());
SleepProcessor(500000); // low power sleep for 0.5 sec
return;

}
`
On 0.1.5 this showed something like 68.00% 96.6mA 4.16V
On 0.2.0 it shows 67.93 (-1mA) 3.80V
I didn't see a battery example and to be honest, charging the older one has always been a bit hit and miss, I thought I charged it only to find it flame out after a random time between 5 mins and 6 hours.
I suppose a suitable example would be like charging a phone, you plug it in, if on USB it shoudl show the charging page, otherwise show a normal page and the battery charge level.
Again, I may be victim to changed between the versions, but if there is documentation I can't easily find it.
Edit: I disconnected and reconnected the battery and now powers up off the battery.  Its very buggy.  Still doesn't charge.

So charge current doesn't work.  And charging is always true:
bool AXP::isCharging() {
    if (_pmic == pmic_axp192) {
        return axp192.isCharging();
    }
    return true;
}

If its an axp192 then work properly otherwise just lie?
Come on guys, what are you playing at?  How to tell if its on charge?

I see battery current is now in amps rather than milliamps.  An example of how to use the settings, like the charge current etc. would be very useful.

Hello @DrJaymz
you could try to use M5Unified library instead which supports many (if not all) M5Stack devices.
I've created a battery monitor example for M5Core2 v1.1 here.
Thanks
Felix

Hello @DrJaymz
you could try to use M5Unified library instead which supports many (if not all) M5Stack devices.
I've created a battery monitor example for M5Core2 v1.1 here.
Thanks Felix

Thanks I will try that, what is the guidance on using the unified library?
I can't find anything that says if you're using M5Core2 library you can move to trhe unified library but the following things may require extra work.....
Going back to my initial issue, I just looked at the m5core2 library and its not really fit for purpose, its like they just tried to get rid of the compiler errors and called it fixed.
To get charging status: M5.Axp.isACIN();
For current I used: M5.Axp.GetBatCurrent() * 1000;
Note that current is in amps now not milliamps as before, which is why my old code which was a sprintf("%0.1f",M5.Axp.GetBatCurrent()) showed nothing at all.


filter_criteria not works for source kinesis stream: aws_lambda_event_source_mapping

https://github.com/terraform-aws-modules/terraform-aws-lambda/blob/f4861b751c5f89daecc2788069d67baaf4653b75/examples/event-source-mapping/main.tf#L43
Here is my filter_criteria:
filter_criteria {
filter {
pattern = jsonencode({
data: {
typeId: [210],
locally: [{"exists": true}]
}
})
}
}

Here is an example of event sourcing with Kinesis Streams:
https://github.com/terraform-aws-modules/terraform-aws-lambda/blob/eface07424982cea49edd4f6665e05741490b370/examples/event-source-mapping/main.tf#L50-L61


feat(ssg): support strict types in diff funcs

About this change—what it does

adds support for strict types in diff functions

Why this way

to make the strict types function properly

acceptance tests: https://github.com/aiven/terraform-provider-aiven/actions/runs/3686897628


October webinar graphic

Related Issue
No response
Description
The October webinar is about Dashboard 2.0.
See PR #1202 for the details.

Hi @iskerrett here it is. Is the info correct?

Yes it is.

Great! I'll add it to the pr


Refactor userVmDetailsDao field and remove unusued fields

Description

This PR refactors a duplicated field vmDetailsDao and _uservmDetailsDao into userVmDetailsDao.
vmDetailsDao, uservmDetailsDao --> userVmDetailsDao
It also removes several unused injected vars as well i.e.;
_domainDao, rulesMgr, _vguTypesDao, _configDepot

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):
How Has This Been Tested?
I have recompiled CloudStack in my local environment and ran the virtual machine related Marvin smoke tests.

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
Testing
[ ] I have added tests to cover my changes.
[ ] All relevant new and existing integration tests have passed.
 I'll keep you posted as I make progress.

@DaanHoogland @rafaelweingartner @resmo @marcaurele I am new to this community and I would like to ask for your assistance with reviewing of this PR.

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2183

@blueorangutan package

@dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2184

@rafaelweingartner checked the attributes, it seems like they can be set to private. I will modify them and do some tests before pushing again

@blueorangutan package

@dhlaluku a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


upgraded SDK to .NET Core 2.1 in build system

@pshrosbree had to revert back to XUnit 2.3.1 - the dotnet-xunit CLI command that we depend on for running the unit tests is no longer available as of XUnit 2.4.0. We'll need to replace the way the build system works with XUnit in order to work around that particular issue, but I didn't quite feel like biting that off just yet.

Fair enough. Not sure what is new in 2.4.0, but do like to be current, especially in the netstandard/netcoreapp stuff.


support Docker Tomcat setup without automatic instance start up

When the cookbook is used to set up a Docker image, the service that starts the instance is triggered. It is undesirable there. By using a parameter, e.g. tomcat.auto_start we can prevent it.

First off I'm very sorry that it's taken so long to get back to you on this issue.  For a significant period of time there was no active Chef Software Inc. maintainer for this repository and things languished.  We're now actively maintaining this cookbook again, and as part of that I've rewritten the cookbook with new custom resources for installing Tomcat from Apache Org sources.  This will ship in an upcoming 2.0 release and then we'll remove the existing recipes and providers in a future 3.X release.  With those new providers I believe the need for this change goes away so I'm going to close this out.  I encourage you to give the new providers a try and let me know if we can tackle more Tomcat management without the attributes bloat the current code suffers from.  They're on the master branch and once the documentation and testing improves a bit they'll be released as a 2.0 cookbook.


Fix 'ensure_authed_acces' typo in guardian lesson

Thanks to @nscyclone who pointed me to this problem while reviewing the translation of this lesson.
This PR fixes a typo in listing. While we declare ensure_authed_acces pipeline, we use ensure_authed_acces*s* then.

I suppose I've already fixed this in #889.

Yep, that's already merged. :)


chore(main): release 1.9.1

:robot: I have created a release beep boop
1.9.1 (2024-10-07)
Bug Fixes

correction name (because bun bundler has no keepName like esbuild) (c8f628a)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/Basalt-Lab/basalt-logger/releases/tag/v1.9.1 :sunflower:


10 feature/MiniMapUi (Prefab added and removed from gameview)

Why is this merge request being submitted?
Mini Map implementation, added the camera and the image to a prefab container in order to avoid scene conflicts with game view.
What does this merge request add functionality wise?
Adds a mini map to the game
How has the code been tested?
[ ] Automated tests
[ ] Manual tests (specify what you've done)
Run it with from the start of the game and seems to be working fine
Yet to test it with several players.
[ ] New feature (never existed before)
[ ] Feature update (enhancing already existing feature)
[ ] Breaking feature (changes the already existing way of how the process works)

@KiyanSomji  you need to do this on https://github.com/benedekdaniel/Gravitational-Waves


backups: select random node to download backup

When chosing a node to download our backup, we should prevent the same node from downloading the backups all the time.
In the case we get a "preferred" topology, this is left to the kubernetes scheduler/CSI controllers: they should select different preferred nodes.
In the case we have no preferred topology given to use, we should do our own random selection. Otherwise we end up with the same node being chosen to download backups all the time, while the others sit idle.

LGTM. Thanks @WanzenBug !


fix: incomplete coverage config

There was a slight error in the default coverage configuration in pyproject.toml.
This PR fixes the error and switches from the old exclude_lines to the newer and (I believe) recommended exclude_also.

Thanks!


Video Keeps playing in Background after dismissing the ViewController

When you enter fullscreen mode and back to normal mode.  then you dismiss or pop the viewController Player keeps playing in the background which leads me to think the playerView is not released from Memory.  This happens with the provided TestProject.
I think there is a retain cycle issue with the  "nonFullscreenContainer"  property,  making it weak solved the problem for me.

thank you! care to do a pr? @Ezimetjan

I just sent a pull request.

I just submitted a pull request.

I just submitted a pull request.


Please add ability to add custom descriptions to conditions for non 5e systems.

Being able to hover over the icon to see the name & description of a condition the way you can in a 5e system if using DFreds Convenient Effects would be great.
Perhaps an option to load the list of existing conditions with a blank box to enter our own condition "notes" or full descriptions would be nice if possible. Then when hovering over the icon, it will show the added description.

Hover over which icon exactly? The ones on the token status effects that appear when right clicking? Sorry, just a bit confused.
You can of course duplicate any effect and change the description in the custom effect that appears. As long as you keep the same name, CE will always choose the custom one over the existing one.

I'm sorry, I should have specified that I'm using the 3.5e Game System and Convenient Effects doesn't load for that system.
I thought maybe Effects Panel could just allow for generic editing of conditions that are loaded. Or a Convenient Effects for 3.5e would also be nice.
Specifically, I'm referring to hovering over the icons that appear top right (left of the chat window). I was under the impression that hovering over them in 5e displays their description text. So I was hoping for that in the 3.5e system.

Oh, gotcha. So the description field used to be an addition that Convenient Effects made, but now it is part of native Foundry v11. Effects Panel will choose the native field over the CE field (and CE removed support for its v11 version). So I think the solution here is to wait for 3.5e to update to v11 and they can either add descriptions themselves or you can add them after in the effect editor.


Make it visibly easier to see what files were changed in part of a PR

This part to show which changed files are in the PR isn't visibly obvious to users:

After checking out a PR, it's not clear in the Explorer what files are part of the PR:

Users in the study were confused about the state of their local files once checking out a PR.

@tanhakabir when a PR is checked out we switch to the "Changes in PR" view. Is there something else we could do to that view to make it more clear that these are PR changes?

I think this is an improvement from before! I'm happy with this now and we can see if we hear more feedback otherwise


Clarify the URL for the discovery example

This is a small clarification, but I think the guidelines can be extended further with the following information:
For demo purposes using a CoreOS instance the assets created in the tutorial can be put in the following directory structure:
./hello
./images
./images/example.com
./images/example.com/hello-0.0.1-linux-amd64.aci.asc
./images/example.com/hello-0.0.1-linux-amd64.aci
./pubkeys.gpg

/etc/hosts can be modified as follows:
core@core-01 ~ $ cat /etc/hosts
<IP_ADDRESS> core-01
<IP_ADDRESS> example.com

If Docker is available, we can easily host the discovery page:
docker run -d --name nginx -v $(pwd):/usr/share/nginx/html:ro -p 80:80 nginx:mainline-alpine

Effectively seeing rkt discovering & verifying the image:
sudo rkt run --insecure-options=http,pubkey --debug example.com/hello:0.0.1

Explanation of the --insecure-options=http,pubkey:

http: Allow HTTP connections. Be warned that this will send any credentials as clear text.
pubkey: Allow fetching pubkeys via insecure connections

Although I realize Docker may not be available on the environment of the user going through these steps (I was using CoreOS itself to step through these guides, doing all golang compilation in a Docker golang:1.6 container.)

Very useful patch. LGTM

@so0k I think that proposing the whole nginx path would be a bit overkill for this guide. Instead, showing the final directory structure would be good for double-checking, IMHO.
In the meanwhile, thank you for this! I'm merging as-is for the moment, feel free to propose further refinements.


Rework Automerge workflow

Issue
https://github.com/networkservicemesh/.github/issues/71

There is noupdate-dependent-repositories workflow in this repo


Missing image on freecodecamp.rocks/news/

File should live at "/news/content/images/2018/12/FCC-logo-white.png" but appears to be missing.

Even Quincy's avatar photo is not there next to the news articles.

The image URLs are pointing to freecodecamp.rocks, I'm guessing we are not hosting images there, hence the 404 error.
Making them point to freecodecamp.org should resolve the issue.

We spun up a test instance of news for .rocks to point at. More so for us to test infrastructure and to ensure we could proxy it correctly.
I wouldn't worry too much about this.

Thanks for reporting. I have update this in the overview PR linked above.


RFC 0029: Add notes on attachments and MTCs

Here's an attempt to capture the outcome of #198
cc @dhh1128 @kdenhartog

Discussed and agreed to on community call, 2019-12-11


fix: fix runv configure doc

Signed-off-by: zhangyue<EMAIL_ADDRESS>
Ⅰ. Describe what this PR did
fix small typo, use ps -a to see stopped and created container.
Ⅱ. Does this pull request fix one issue?

None.
Ⅲ. Why don't you add test cases (unit test/integration test)? (你真的觉得不需要加测试吗？)
no need.
Ⅳ. Describe how to verify it
no need.
Ⅴ. Special notes for reviews
No need.

LGTM


Which port number needs to be open to do update for VM

Is port 80 or 443 is the correct port number needs to be open to do update?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0bd94c0c-f17e-8db8-98fd-0a2d6b92be3e
Version Independent ID: 5e8515fe-0f31-f175-1a30-eaa37cfafb9d
Content: Tutorial - Monitor and update Linux virtual machines in Azure
Content Source: articles/virtual-machines/linux/tutorial-monitoring.md
Service: virtual-machines-linux
GitHub Login: @cynthn
Microsoft Alias: cynthn

Solved by myself, closing. Thanks.

@KeiroKamioka0000 Please post your findings. It may help the community

Since it use update management. The port number 443 should be open.
https://docs.microsoft.com/en-us/azure/automation/automation-update-management#ports

@KeiroKamioka0000 Thanks.


Project and controller

Summary: Implements all non-export Project methods, and the methods that are directly needed in the new implementations.
Goal: Maintain functionality, add viable methods.
Specifically Includes:

Implementation of Project methods
Implementation of has(blockType) for BlockLibrarySet, change of its return type
Changed name of addBlockDefinition in block_library.js (we know what we're adding to a block library)

This change is

Review status: 0 of 4 files reviewed at latest revision, 7 unresolved discussions.

src/controller/project_controller.js, line 168 at r1 (raw file):

  addBlockDefinition(blockDef, libraryName) {
    this.project.addBlockDefinition(blockDef, libraryName);
    this.tree.addBlockNode(blockDef.name, libraryName);

Nit: use blockDef.type() since we have that getter function?
(Though I suppose it doesn't really matter all Too Much)

src/controller/project_controller.js, line 273 at r1 (raw file):

  rename(resource, newName) {
    //TODO: restrict names.
    resource.setName();

Did you mean to pass in a parameter?

src/model/block_library_set.js, line 72 at r1 (raw file):

  /**
   * Returns whether or not a named block is in the library set.

I suggest you rename this function to getLibrary()because the name of the function makes it sound like this returns a boolean (though it does offer the same/more information than would a hasBlock() function). Also possibly reword the jsdoc to correspond.

src/model/block_library_set.js, line 74 at r1 (raw file):

   * Returns whether or not a named block is in the library set.
   * @param {string} blockType The name of the block to be found.
   * @return {Object} The block library that has the block or null.

@return {?BlockLibrary}?
(the ? means could be null, I believe)

src/model/project.js, line 116 at r1 (raw file):

  /**
   * Adds a block definition to the project.

"[...] to the given BlockLibrary in the Project." ?

src/model/project.js, line 122 at r1 (raw file):

   */
  addBlockDefinition(blockDef, libraryName) {
    const library = this.librarySet.has(blockType);

Is it has() or hasBlock() that you meant to call? I don't think I see a has() function in BlockLibrary.

src/model/project.js, line 229 at r1 (raw file):

   */
  hasBlock(blockType) {
    return this.librarySet.hasBlock(blockType);

If the library set class's hasBlock() now returns a BlockLibrary, this return type should also return a BlockLibrary. (Or you might also rename it per my previous comment.)

Comments from Reviewable

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 8 unresolved discussions.

src/controller/project_controller.js, line 273 at r1 (raw file):

  rename(resource, newName) {
    //TODO: restrict names.
    resource.setName();

Not using newName.  Use it or remove it.

src/model/block_library_set.js, line 72 at r1 (raw file):
Previously, chynu (celine choo) wrote…
I suggest you rename this function to getLibrary()because the name of the function makes it sound like this returns a boolean (though it does offer the same/more information than would a hasBlock() function). Also possibly reword the jsdoc to correspond.

+1.  If you want, you can also have a function called hasBlock or has that just returns whether this function returned null.  (Sorry, convoluted phrasing.)
The question there is whether you would ever use it rather than using the version that returns the library.

Comments from Reviewable

Review status: all files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.

src/controller/project_controller.js, line 168 at r1 (raw file):
Previously, chynu (celine choo) wrote…
Nit: use blockDef.type() since we have that getter function?
(Though I suppose it doesn't really matter all Too Much)

Done.

src/controller/project_controller.js, line 273 at r1 (raw file):
Previously, chynu (celine choo) wrote…
Did you mean to pass in a parameter?

Whoops; using it now.

src/controller/project_controller.js, line 273 at r1 (raw file):
Previously, rachel-fenichel (Rachel Fenichel) wrote…
Not using newName.  Use it or remove it.

Whoops; using it now.

src/model/block_library_set.js, line 72 at r1 (raw file):
Previously, rachel-fenichel (Rachel Fenichel) wrote…
+1.  If you want, you can also have a function called hasBlock or has that just returns whether this function returned null.  (Sorry, convoluted phrasing.)
The question there is whether you would ever use it rather than using the version that returns the library.

Done.

src/model/block_library_set.js, line 74 at r1 (raw file):
Previously, chynu (celine choo) wrote…
@return {?BlockLibrary}?
(the ? means could be null, I believe)

Cool thanks

src/model/project.js, line 116 at r1 (raw file):
Previously, chynu (celine choo) wrote…
"[...] to the given BlockLibrary in the Project." ?

Done. (also changed from name to just the library itself)

src/model/project.js, line 122 at r1 (raw file):
Previously, chynu (celine choo) wrote…
Is it has() or hasBlock() that you meant to call? I don't think I see a has() function in BlockLibrary.

changed to getLibrary

src/model/project.js, line 229 at r1 (raw file):
Previously, chynu (celine choo) wrote…
If the library set class's hasBlock() now returns a BlockLibrary, this return type should also return a BlockLibrary. (Or you might also rename it per my previous comment.)

made a has

Comments from Reviewable

Review status: 1 of 4 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

Comments from Reviewable

:

Review status: 1 of 4 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

src/model/project.js, line 122 at r2 (raw file):

   */
  addBlockDefinition(blockDef, libraryName) {
    library.add(blockDef);

This is equivalent to the single line getLibrary(libraryName).add(blockDef). I recommend removing the this to avoid later maintenance.

src/model/project.js, line 214 at r2 (raw file):

   */
  //TODO #52: move warning from BlockLibraryController to ProjectController.
  isDirty() {

Is this being replaced with something else?

Comments from Reviewable

Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 6 unresolved discussions, some commit checks failed.

src/model/block_library_set.js, line 85 at r2 (raw file):

   * @return {?BlockLibrary} The block library that has the block or null.
   */
  getBlock(blockType) {

This name still doesn't match what the function is doing.  getLibrary?  getContainingLibrary?

src/model/project.js, line 121 at r2 (raw file):

   * @param {!BlockLibrary} library The library to add it to.
   */
  addBlockDefinition(blockDef, libraryName) {

Now you're using an undefined variable.  Eslint should be warning you about these things.

Comments from Reviewable

Review status: all files reviewed at latest revision, 6 unresolved discussions, some commit checks failed.

src/model/project.js, line 121 at r2 (raw file):
Previously, rachel-fenichel (Rachel Fenichel) wrote…
Now you're using an undefined variable.  Eslint should be warning you about these things.

I'll check out my configuration

src/model/project.js, line 122 at r2 (raw file):
Previously, AnmAtAnm (Andrew n marshall) wrote…
This is equivalent to the single line getLibrary(libraryName).add(blockDef). I recommend removing the this to avoid later maintenance.

Done.

src/model/project.js, line 214 at r2 (raw file):
Previously, AnmAtAnm (Andrew n marshall) wrote…
Is this being replaced with something else?

Yup; warnIfUnsaved in either the EditorController or the controllers it manages

Comments from Reviewable

Review status: 2 of 4 files reviewed at latest revision, 6 unresolved discussions, some commit checks failed.

src/model/block_library_set.js, line 85 at r2 (raw file):
Previously, rachel-fenichel (Rachel Fenichel) wrote…
This name still doesn't match what the function is doing.  getLibrary?  getContainingLibrary?

Fixed (should've been getLibrary)

Comments from Reviewable

Reviewed 2 of 2 files at r3.
Review status: all files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.

Comments from Reviewable

Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

Comments from Reviewable


reverse if test in strwlc()

static const char * strlwc(const char * in, char *out, unsigned len)
{
    ...
    while ( in[i] != '\0' && i < len-1) {
        out[i] = (char)tolower((int)in[i]);
        i++ ;
    }
    ...
}

Test on i value should be done before being used :
while ( i < len - 1 && in[i] != '\0')

Can provide a bit more explanations about this issue ?

You're right, there is no issue with the original code, my bad.


flyway command line option -X does not show update / delete count

Im using flyway-3.2.1 and -X (debug mode) dont show the update count.
Axel, pls let me know where we need to see this?

Axel, I've verified this multiple times, its not showing update counts.. Im using oracle.

As seen in image, delete stmt @ line #1 should delete 32 rows. it dont show any update/delete count.

Duplicate of #1174 - please see my comments there on comment on that issue instead of opening new ones for the same problem


Feat: Add Backend Functionality to the Website

We need to integrate backend functionality into our  website to enhance its performance and provide essential features. This will involve setting up a server-side framework, implementing API endpoints, and connecting to a database for product management, user authentication, and order processing.
@harshit1142 assign this issue to me with hacktoberfest and hacktoberfest-accepted tag

@suryapratap04 it is a pure front-end website


Fixed : Enable-RootUser showing password on console

Execution is verified.
08/13/2018 17:29:41 : [INFO ] ~~~~~~~~~~~~~~~TEST END : VERIFY-DEPLOYMENT-PROVISION~~~~~~~~~~
08/13/2018 17:29:41 : [INFO ] CURRENT - PASS    - 1
08/13/2018 17:29:41 : [INFO ] CURRENT - FAIL    - 0
08/13/2018 17:29:41 : [INFO ] CURRENT - ABORTED - 0
08/13/2018 17:29:41 : [INFO ] Checking background cleanup jobs..
08/13/2018 17:29:41 : [INFO ] Removed 0 context files.
08/13/2018 17:29:41 : [INFO ] Cycle Finished.. TC-91986
08/13/2018 17:29:41 : [INFO ]
Test Results Summary
ICA test run on 08/13/2018 17:23:07
ARM Image under test Canonical : UbuntuServer : 16.04-LTS : latest
Total Executed TestCases        1 (       1 Pass,        0 Fail,        0 Abort)
Total Execution Time(dd:hh:mm) 0:0:6
XML file: TestConfiguration
VERIFY-DEPLOYMENT-PROVISION Execution Time: 6.52 minutes
	VERIFY-DEPLOYMENT-PROVISION : PASS
		  FirstBoot : PASS
		  FirstBoot : Call Trace Verification : PASS
		  Reboot : PASS
		  Reboot : Call Trace Verification : PASS
Logs can be found at .\TestResults\2018-13-08-17-23-01-6957


environmental variable $HOME for home dir

The script uses:
confdir="/home/$USER/.config/video-wallpaper"
But sometimes it is not there, e.g. in my case it would be /$USER/.config/video-wallpaper.
Can you use $HOME instead?
confdir="$HOME/.config/video-wallpaper"

I'll make a commit.
Thanks for the suggestion.


Finish first cut of dom-inspector

dom-inspector is half-done. It needs styling and some fine-tuning of its tree adapter to not create empty children.

Fixed in https://github.com/elematic/inspector-elements/commit/c5d3b456d9e9b86d339c163d4c94e08bf6f4eba2


Translation into Spanish language

Greetings, I would like to contribute to the project by translating it into Spanish. Spanish is my native language so don't panic, but a lot of Spanish speakers are still limited by the language so this is primarily to help them.
Thanks in advance and for your time. Keep up the great work.

I am also a native Spanish speaker! I would also like to contribute by translating to Spanish.


Implement OLLAMA_MAX_KEEP_ALIVE environment variable

In cooperative server environments, it is desirable to cap the keep_alive value of models to a maximum duration. This enables server administrators to guarantee that models are unloaded at some point if they are not needed anymore.
For this, I propose to introduce the  OLLAMA_MAX_KEEP_ALIVE environment variable, which allows the administrator to specify a maximum keep alive value at which all other requests will be capped. This additionally disallows indefinite loading of models.

I'd find OLLAMA_MIN_KEEP_ALIVE really helpful in my case.

I'd find OLLAMA_MIN_KEEP_ALIVE really helpful in my case.

Isn't that the opposite of what @jhbruhn  means?

I'd find OLLAMA_MIN_KEEP_ALIVE really helpful in my case.

Isn't that the opposite of what @jhbruhn means?

Yes, sorry, I meant in addition to @jhbruhn's change. They seem to be complimentary changes, and

I'd find OLLAMA_MIN_KEEP_ALIVE really helpful in my case.

Isn't that the opposite of what @jhbruhn means?

Yes, sorry, I meant in addition to @jhbruhn's change. They seem to be complimentary, and just a few lines more to implement. Setting them both would allow you to have an acceptable range of values, i.e. a minimum of 1 hour, a maximum of 24.

Depending on the maintainers feedback I could add that as well.


Unable to locate package openh264

Please advise how to resolve this error while installing openh264 on Ubuntu 16.04
I followed below steps:
add-apt-repository ppa:djcj/hybrid
apt-get update
apt-get install openh264
Reading package lists ..done
Building dependency .. Done
Reading state information .. Done
E: Unable to locate package openh264

Additionally on Ubuntu 18.04 I tried
add-apt-repository ppa:djcj/tools
apt-get update
apt-get install openh264
Still got the same error as above.

I am also facing the same issue in Ubuntu 18.04.

Any news on this?

I am also facing the same issue in Ubuntu 16.04.


(SC-CEN-18) Printing of pages is not possible

Bugs from TEI, 08.10.15 - n.9

the user can use the "print" option in the popup menu, clicking on the left button.

Of course. He/she also can take an screenshot :-). But It is expected a more "executive level" report

When we will sell a product we will think to this "executive level"; for now, it's far far beyond the scope of Riscoss

New feature for generating reports of a risk analysis session has been added. The results are shown as an HTML page in a new window. By printing the page as a pdf file, the results are printed as shown in the HTML page.


Add an text input for providing additional information to prompt

This would allow users to refine the default prompt with use case-specific rules.

I'm carrying out this activity through a separate branch


perf(es/minifier): check whether a function is pure with O(1) cost

Description:
We might need to pass a giant pure function list to the SWC minifier as esbuild did here.
The current implementation could slow the minifier.

BREAKING CHANGE:

Related issue (if exists):

Can we have those list also in swc minifier? (itself)

Absolute yes. I would do it in another PR.
We might need to provide an option(enable by default) to disable it. Because users might do some hacky things to the environment.

We have pristine_globals

We have pristine_globals

Get it.

I think we can use a hash set of (JsWord, JsWord).
Is there more complex expression other than those globals?

I think we can use a hash set of (JsWord, JsWord). Is there more complex expression other than those globals?

Yes. Dealing Expr::Member and Expr::Ident should be enough base on the input here.


请问，运行这个代码仓库，可以实现论文的效果吗？微调的多模态模型可以访问嘛？

Thank you for your interest! We are conducting further training and more extensive experiments, and will open-source the models afterwards.


qb-multicharacter not showing outfits

After updating everything and migrating, for some reason the character select has everyone has  a default danny (skindata.model = nil)
even tho its in the playerskins table
i forced it to use the model from playerskins for now but still doesnt load the outfits?
As soon as i fly in tho it loads properly... Just not at the select menu!

the skindData was not decoding the json format from database, my error


[formrecognizer] Add recordings to MANIFEST

Fixes #25528

API change check
API changes are not detected in this pull request.


Remove unused modifiable param

What is the purpose of the change
Remove unused modifiable param

Codecov Report

Merging #8411 (1eb5434) into 3.0 (e2d1ec0) will decrease coverage by 0.53%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.0    #8411      +/-   ##
============================================
- Coverage     63.58%   63.05%   -0.54%
+ Complexity      313      311       -2
============================================
  Files          1074     1099      +25
  Lines         45211    46022     +811
  Branches       6807     6925     +118
============================================
+ Hits          28749    29018     +269
- Misses        13272    13741     +469
- Partials       3190     3263      +73

Impacted Files
Coverage Δ

...mon/src/main/java/org/apache/dubbo/common/URL.java
39.19% <100.00%> (+0.18%)
:arrow_up:

...ain/java/org/apache/dubbo/common/URLStrParser.java
85.27% <100.00%> (-0.23%)
:arrow_down:

...figcenter/file/FileSystemDynamicConfiguration.java
0.00% <0.00%> (-59.53%)
:arrow_down:

...nfigcenter/nop/NopDynamicConfigurationFactory.java
50.00% <0.00%> (-50.00%)
:arrow_down:

...nfig/configcenter/nop/NopDynamicConfiguration.java
25.00% <0.00%> (-37.50%)
:arrow_down:

...ng/transport/dispatcher/all/AllChannelHandler.java
62.06% <0.00%> (-34.49%)
:arrow_down:

...o/registry/zookeeper/ZookeeperRegistryFactory.java
66.66% <0.00%> (-33.34%)
:arrow_down:

...tore/zookeeper/ZookeeperMetadataReportFactory.java
66.66% <0.00%> (-33.34%)
:arrow_down:

...ookeeper/ZookeeperDynamicConfigurationFactory.java
66.66% <0.00%> (-33.34%)
:arrow_down:

...fig/configcenter/TreePathDynamicConfiguration.java
60.00% <0.00%> (-25.72%)
:arrow_down:

... and 188 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2d1ec0...1eb5434. Read the comment docs.


APEXCORE-725 Add username/password config to jdbc operator test.

R: @amberarrow

Looks OK, other than the minor comment.

done

@amberarrow can you please LGTM or merge the PR.

Will do
On May 26, 2017 7:21 PM, "Thomas Weise"<EMAIL_ADDRESS>wrote:

@amberarrow https://github.com/amberarrow can you please LGTM or merge
the PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/apache/apex-malhar/pull/624#issuecomment-304420537,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACYeievhYBuA4AHiBXX1lm3C23agz7T4ks5r94iTgaJpZM4NhcCx
.

Not sure why the title on this PR says APEXCORE-725 -- maybe from an earlier overwritten commit.


srb rbi update does not follow sorbet/config

Input
$ srb rbi update

sorbet/config contents:
--dir
.
--ignore
build/

Observed output
Running command: update

👋 Hey there!

This script will get this project ready to use with Sorbet by creating a
sorbet/ folder for your project. It will contain:

- a config file
- a bunch of 'RBI files'

RBI stands for 'Ruby Interface'; these files define classes, methods, and
constants that exist, but which Sorbet doesn't always know about.

⚠  Heads up:

To set up your project, this script will take two potentially destructive
actions:

1.  It will require every file in your project. Specifically, every script in
    your project will be run, unless that script checks if __FILE__ == $PROGRAM_NAME
    before running any code, or has the magic comment # typed: ignore in it.

2.  It will add a comment to the top of every file (like # typed: false or
    # typed: true, depending on how many errors were found in that file.)

❔ Would you like to continue? [Y/n] Traceback (most recent call last):
        3: from /Users/alexstephen/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/sorbet-0.4.4298/bin/srb-rbi:232:in `<main>'
        2: from /Users/alexstephen/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/sorbet-0.4.4298/bin/srb-rbi:76:in `main'
        1: from /Users/alexstephen/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/sorbet-0.4.4298/bin/srb-rbi:76:in `gets'
/Users/alexstephen/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/sorbet-0.4.4298/bin/srb-rbi:76:in `gets': No such file or directory @ rb_sysopen - update (Errno::ENOENT)

If I run srb init (which docs say is an alias for srb rbi update), my sorbet/config is ignored and replaced with the default sorbet/config

Expected behavior

I would expect new RBI files to be created with all files in build/ being ignored.

I also found that editing sorbet/config after running srb init and then running srb rbi update overwrote the sorbet/config file.

I've outlined a proposed change that I think makes a better distinction between srb update and srb init on this PR: https://github.com/sorbet/sorbet/pull/1066#issuecomment-505953603
I'll implement the change in that PR. Please weigh in on that proposal, since it would solve the problem you mention in this issue.

Going to close this in favor of Tapioca
https://sorbet.org/blog/2022/07/27/srb-tapioca


Indicator plan: Update page title

We recently updated the link to this page to be more intuitive: "Indicator plan" instead of "Print/Grid Report": https://tola-activity-demo.mercycorps.org/indicators/program_report/442/
The page still has the old title. Please update to "Indicator plan"

This is done.


[skimag] add extractor

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[x] New extractor (Piracy websites will not be accepted)
[ ] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

Description of your pull request and other information
add an extractor for skimag.com videos

Better for this to be in JWPlatformIE._extract_urls imo


[New Port Request]

Library name: goodform
Library description: MsgPack/JSON Validation (msgpack.org[C++11])
Source repository URL: https://github.com/jonathonl/goodform
Project homepage : same as source repository

If you wish to add this port in the future, you can reopen this issue, but we're closing it for now.


feat: implement React wrapper

This PR adds the React wrapper to the library. The wrapper components are created temporarily during the build and removed after it.

Codecov Report

:exclamation: No coverage uploaded for pull request base (lit-migration@7513422). Click here to learn what that means.
The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@               Coverage Diff                @@
##             lit-migration    #2171   +/-   ##
================================================
  Coverage                 ?   92.71%
================================================
  Files                    ?       53
  Lines                    ?     2403
  Branches                 ?      254
================================================
  Hits                     ?     2228
  Misses                   ?      174
  Partials                 ?        1

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!


Token expired error - GW does not fetch new token

I found that error message in the logs repeating now for more than 40 Minutes since I used the App (and closed it again).
Expected behaviour would be that GW fetches the login again and gets a new token.
When manually restarting container the login is immeditely fetched by the Gateway.

@cybersmart-eu should be fixed in 0.5.2, docker image is build so feel free to try and report back

@cybersmart-eu It is

ok, can confirm issue fixed, after 15 Minutes (900s) login has been fetched by GW.


Installation of OpenCl-SDK might be outdated

Hello everyone,
I am a beginner so I may be wrong, but I believe the installation instructions for the OpenCl-SDK are outdated.
Specifically the line:
function devshell { Enter-VsDevShell -InstallPath "C:\Kellekek\Microsoft\VisualStudio\2019\BuildTools" -SkipAutomaticLocation -DevCmdArguments "-arch=x64 -no_logo" }
Here, it is referring to some Kellekek directory and also the 2019 version of Visual Studio, not 2022
My Installation is not able to proceed forward from this point on, any help?

I am also confused by this command.


builtin.Get Time incorrectly returns current epoch for 1970-01-01 00:00:00 instead of 0

To reproduce in master:
*** Test Cases ***
Get Time at epoch
    ${get_time_val}=    Get Time    format=epoch    time_=1970-01-01 00:00:00
    Should Be Equal As Strings    ${get_time_val}    0    Time strings are not equal

Running the above test results in:
FAIL: Get Time.Get Time at epoch
Status of 'Get Time at epoch' should have been PASS but it was FAIL.

Error message:
Time strings are not equal:<PHONE_NUMBER> != 0

It looks like in line 3327 of builtin.py that parse_time returns 0 (expected I assume), and that when 0 is provided as  time_ argument to get_time (robottime.py line 200), the following line returns time.time():
time_ = int(time_ or time.time())

I tested the provided example locally and it failed with this error:

Time strings are not equal: -7200 != 0

That 7200 means two hours which is kind of logical because I'm in Finland which is UTC+2. That said, DST is now active so I'm not sure should it be actually three hours. Anyway, the value is totally different than<PHONE_NUMBER> that you got. Which time zone are you?
Could you test what you get with the following example using DateTime? In my case it also fails with -7200.0 != 0 so these two keywords agree.
*** Settings ***
Library       DateTime

*** Test Cases ***
DateTime
    ${x} =    Convert Date    1970-01-01 00:00:00    result_format=epoch
    Should Be Equal    ${x}    ${0}

That's interesting. I am currently British Summer Time (UTC+1).
Running the suggested passes for me.

There's clearly a bug in the code. time_ = int(time_ or time.time()) uses the current time if time_ is zero. It's default is None so it should be something like time_ = int(time.time() if time_ is None else time_). That int conversion looks a bit strange as well and I may change that too, but ti's not related to this issue.

The reason the original example as well as the example I provided both fails when I run them like -7200.0 != 0 is that 1970-01-01 00:00:00 is considered a local time and we were UTC+2 then. -7200 is thus just right. My example succeeds if you are somewhere that was in UTC+0 when that  local time occurred. And due to the bug in our code the original example fails in that case. Luckily the bug is easy to fix.

The original example fails the same way as in the original description here in Finland if the timestamp is changed to 1970-01-01 02:00:00.

Nice, thank you.


EIP-1884: Reprice trie-size dependent opcodes

What was wrong?
Fixes #1826
How was it fixed?
Changed pricing, and added selfbalance opcode, added tests.
Bonus simplification in the insufficient stack exception.
To-Do

[x] Add tests defined in the EIP
[x] Rebase on #1828

[x] Clean up commit history

[x] Add entry to the release notes

Cute Animal Picture

I'll send the SSTORE one christoph's way, since he worked on that last time, so I am switching this review request from christoph to @pipermerriam .

Are you up for pairing with me on it today? I'm starting to spin a little bit on what approach to take to build the test. I haven't used the filler before, and maybe I'm doing it wrong.

@carver I can do it tomorrow (Friday).  I'm not confident the fillers are the right tool but happy to work with you to find out if it is.

Piper from other channel:

let's leave your tests as is and forget the fillers for now


Filter FAR config file

Newest version of FAR has the config file in the distribution whereas previous versions didn't. This causes an overwrite conflict on upgrade, so filter it out. @pjf

You are the best! Thank you!


Labels break when switching from 0.97.6 to 0.97.7

Updating from 0.97.6 to 0.97.7 causes the labels on a prefixed input field jump off the form. Please see the screenshots attached below.
It seems that the change that breaks the labels might be the addition of width: calc(100% - 3rem); to the elements.
0.97.6

0.97.7

I'm trying to reproduce this in a Plunker, will comment here once I get it done.

+1

Happening to me in Chrome as well. This should be an higher priority issue.

I'm having the same problem in Chrome 52, macOS 10.11.6.
The weird thing is the bug shows only when I add the input field dynamically through Javascript. It looks fine when it's already included in my html.

just ran into this issue. It appears to arise from the different browser implementation in calculating position for absolutely positioned elements when left is not explicitly specified. Not sure if this is a browser vendor bug or an ambiguous part of the spec. The fix on materialize's level would be to add left: 0 to the label element

I cannot reproduce it in 0.98.2
Closed due inactivity, feel free to reopen it if it is still necessary, in that case, please provide a way to reproduce it. like a codepen


Fix onChange interface

Please, refer to #1
Kind regards

Hello,
Thanks for your help.
Commit merged.


docs: fix alignment issues on homepage

Hi,
the cards on the homepage had some alignment issues on mobile:
Before:

After:

The problem was that the grid row containing the cards was nested within the grid row containing the title and all that was needed was to un-nest them.
This PR also tries to improve the alignment of the Github star button in the navbar:
Before:

After:

The Github button fix is a bit hacky and not perfect (it can't be fixed this way as either mobile or desktop would be a tiny bit misaligned, this is because the main styling is provided by the buttons.js script) but I feel like this solution is better than what was there before.

The star button is much better! I had spent some time trying to get that to look decent — thanks for doing it successfully!
And welcome @EArazli as a contributor!

@EArazli I don't think this warning matters much, let me know if you disagree

@max-sixty I'll look at it again, but in any case, the unsafe code was there before my change, I only changed the nesting of some  tags so whatever this is was present beforehand. I'll probably open a PR adding noopener and noreferrer to this code & other occurrences once I read up on it a bit more. But as long as we only link to trusted pages this shouldn't be a security risk, especially because the DOM of prql-lang.org can't really contain any sensitive user information 😅

especially because the DOM of prql-lang.org can't really contain any sensitive user information 😅

Yes this was my thought too! :)


Repository: Missing reports - Performance reports per county/facility/program

These reports should allow us to answer the following questions:

How many labs performed well/badly in a given program/county?
Obtain a list the individual labs passed/failed.
Bar/column graph showing the number passed/failed/both side by side per county/program

the first point is already in the graphs summary...wo we will add the 2&third


[Enhancement][opensearch] Allow user-defined labels on pvcs

Is your feature request related to a problem? Please describe.
Our PVCs get backuped based on a policy defined in the PVC label. However it's currently not possible to define additional labels for the PVC (instead the global labels are applied if .Values.persistence.labels.enabled is true).
Describe the solution you'd like
I'd like to define additional labels that are added besides the global labels.
Describe alternatives you've considered
I don't see another way of doing it.
Additional context

[Triage]
I see the PR https://github.com/opensearch-project/helm-charts/pull/555 is already created for this change, thanks for your contribution @simonstumpf.

Waiting for the backport to 1.x before closing this.
Thanks.

@peterzhuamazon
Thanks!
Should I merge my branch into the 1.x branch or the main?

Hey @simonstumpf please create a PR to 1.x branch.

@prudhvigodithi Im a little bit confused. I've created the PR, but there are too many changes? Do you see what I did wrong?

@simonstumpf you need to clone 1.x--> add your changes-->then please create the PR to 1.x.

@prudhvigodithi Im a little bit confused. I've created the PR, but there are too many changes? Do you see what I did wrong?

Added steps here:
https://github.com/opensearch-project/helm-charts/pull/599#issuecomment-2358934979

Resolved, closing now.


Add documentation for Security rule CA5378 (DoNotSetSwitch) in FxCopAnalyzers

Rule implementation: https://github.com/dotnet/roslyn-analyzers/blob/master/src/Microsoft.NetCore.Analyzers/Core/Security/DoNotSetSwitch.cs#L23

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f1295961-36c4-75a0-f50a-c5d86159746c
Version Independent ID: 3d4bba1e-0d05-f577-3b78-65dd6ab10635
Content: Security Warnings - Visual Studio
Content Source: docs/code-quality/security-warnings.md
Product: visual-studio-windows
Technology: vs-ide-code-analysis
GitHub Login: @gewarren
Microsoft Alias: gewarren

Bootsrapped: https://github.com/paulomorgado/MicrosoftDocs-visualstudio-docs/tree/paulomorgado/ca5378

I think we can close this issue.
the ca5378 page is available at: https://docs.microsoft.com/en-us/visualstudio/code-quality/ca5378?view=vs-2019

Awesome, thanks @eddynaka.


ApplicationInsights: Uses plural for operation group name

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information

[ ] The title of the PR is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
[ ] Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
[ ] If applicable, the PR references the bug/issue that it fixes.
[ ] Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

[ ] I have read the contribution guidelines.
[ ] My spec meets the review criteria:

[ ] The spec conforms to the Swagger 2.0 specification.
[ ] The spec follows the guidelines described in the Swagger checklist document.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR.

Automation for azure-sdk-for-java

Automation for azure-sdk-for-go

@ericc1103 -- Operation IDs are intended to be <plural-noun>_<verb> -- this corrects a glitch in the spec. Please review and approve.
@amarzavery  @vladbarosan  @dsgouda @shahabhijeet   -- FYI - this is technically a breaking change, but necessary to correct a bad API.

@fearthecowboy are we good to merge here ?


fq: 0.3.0 -> 0.4.0

Description of changes

Upgrade to 0.4.0 including these changes.
Things done

Built on platform(s)

[x] x86_64-linux
[x] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 220206 run on x86_64-linux 1

1 package built:

fq


Update flow-bin to 0.26.0

There's quite a few optimization improvements between 0.20.1 and 0.26.0. Locally, running flow on a small project drops from 30+ seconds to less than a second.

0.27.0 is available now.

Hi,
There is a tonne of things broken with this plugin and it needs a new reporter. Repurposing JSHint reporters was a bad idea.
I'm currently working on an improved version, I'll close this PR and release 5.0 soon.
Sorry for the wait.
Cheers

I just released 1.0.0 :smile:

@charliedowler it works great, thanks a lot!!!


Question: How to use argocd-vault-plugin for multiple Vault instances

Is there any way to use argocd-lovely-plugin with multiple instances of argocd-vault-plugin, meaning that we can use multiple instances of vault and each argocd-vault-plugin will be configured to work with the specific vault? The current setup expected just one instance of the vault.
Thanks

Humm, to do this you need two differently named (or differently versioned which would be weird) copies of lovely-vault-plugin.
You could do this by building a derived version of the docker image with /home/argocd/cmp-server/config/plugin.yaml having a different name. Or a shell script to patch this in at startup.
It seems useful to be able to drive the name of lovely via an environment variable, so you could do this without needing to do any more work than just add one more config to the plugin. I'll look into that.

I see that you have implemented this feature. Could you give me please some example how to use it? Let's say I have two vaults which use different VAULT_ADDR environment variable...
Many thanks

Install the plugin twice, with different names:
spec:
  template:
    spec:
      containers:
        - name: lovely-plugin-foo
          image: ghcr.io/crumbhole/lovely-vault-plugin:0.20.1
          env:
          - name: VAULT_ADDR
            value: http://vault.foo
          - name: PLUGIN_NAME
            value: lovely-vault-plugin-foo

and again with
spec:
  template:
    spec:
      containers:
        - name: lovely-plugin-bar
          image: ghcr.io/crumbhole/lovely-vault-plugin:0.20.1
          env:
          - name: VAULT_ADDR
            value: http://vault.bar.com
          - name: PLUGIN_NAME
            value: lovely-vault-plugin-bar

You probably actually want to get the envFrom secrets, but I hope this gives you the idea.
Use the plugin by the value from PLUGIN_NAME, so you'd set in the application
spec:
  source:
     plugin:
        name: lovely-vault-plugin-foo

In this case we're overriding both plugin names with different ones, but you could only set one PLUGIN_NAME, and then the other would be called the default lovely-vault-plugin

I've just tried it and it works like a charm!
Thanks

Good stuff. Thanks for letting us know.


Updated: Multi-wire usage of GetNW% issue #74

I'll look at this in a bit.

Tested on meta, seems to work with a quick test

The changes look sane yeah.


Disable printing the tree when writing an error

Hi, is it possible to disable printing the tree?
Why ?
Every time I use the error function, it prints the whole tree. While it might be useful in specific cases, having it by default is terrible (at least for my use case).
I find myself with 3k of lines displaying my tree for every error. So, 2999 lines are useless while one is relevant.
How to do it?
I didn't find anything about this. Did I miss an option or something?
Otherwise, I would ask as a feature request the possibility to disable this behavior ;).
In the meantime, I commented the line displaying it.

Thank you for the input. You get really blind to what other users need when you write these kinds of plugins, so input is honestly GREATLY appreciated!I share your opinion that this should be an option to toggle that is disabled by default. Nice that you've found a workaround for now, but the next version of Log will definitely include this option.


RPM-GPG-KEY-ripple-release return 404

I have Install rippled on Ubuntu with Alien refer refer to this page.
However https://mirrors.ripple.com/rpm/RPM-GPG-KEY-ripple-release return 404 and I could not Verify the signature on the rippled software package .
Retrieving https://mirrors.ripple.com/ripple-repo-el7.rpm
Preparing...                          ########################################
Updating / installing...
ripple-repo-1-2.el7.centos            ########################################
curl: (22) The requested URL returned error: 404 Not Found
error: https://mirrors.ripple.com/rpm/RPM-GPG-KEY-ripple-release: import read failed(2).

thanks for reporting this issue - this was a temporary service outage and should be working again now.


ArgoCD healthcheck and GrafanaDashboard

Is your feature request related to a problem? Please describe.
I created an ArgoCD healthcheck to show if ArgoCD app (and related GrafanaDashboard resource) is OK or not. If the Dashboard has some issue, it is not replicated in the status of the GrafanaDashboard object. It is just not resynced.
Here is the error message in the grafana-operator that I want to be propagated to the object (here: the dashboard json is broken on purpose - title changed to "title-break"):
2024-03-10T13:24:47Z	ERROR	GrafanaDashboardReconciler	error reconciling dashboard	{"controller": "grafanadashboard", "controllerGroup": "grafana.integreatly.org", "controllerKind": "GrafanaDashboard", "GrafanaDashboard": {"name":"tag-server.json","namespace":"ssp"}, "namespace": "ssp", "name": "tag-server.json", "reconcileID": "8ed6f103-b4e2-470a-9652-7e3c8e9a2329", "dashboard": "tag-server.json", "grafana": "external-grafana", "error": "status: 400, body: {\"message\":\"Dashboard title cannot be empty\",\"status\":\"empty-name\"}"}

Describe the solution you'd like
I propose to update status.lastMessage with this error message (like it is done in GrafanaDatasource: "error 400: Dashboard title cannot be empty")
Describe alternatives you've considered
Meanwhile, I'm waiting for 5 minutes since the last resync and set the status of the healthcheck about failure to sync for more than 5 minutes and a plea to check in grafana-operator logs.
Additionally - it can be nice to make the status of the object to following usual k8s resources convention like:
...
status:
  conditions:
  - lastProbeTime: null
    lastTransitionTime: "2024-01-28T07:02:32Z"
    status: "True"
    type: Initialized
  - lastProbeTime: null
    lastTransitionTime: "2024-03-10T12:45:09Z"
    status: "True"
    type: Ready
  - lastProbeTime: null
    lastTransitionTime: "2024-03-10T12:45:09Z"
    status: "True"
    type: DashboardReady
  ...
  uid: ....
  hash: ....
  lastResync: "2024-01-28T07:02:32Z"

Additional context
My current ArgoCD healthcheck:
apiVersion: v1
kind: ConfigMap
metadata:
  name: argocd-cm
data:
  resource.customizations: |
   "grafana.integreatly.org/GrafanaD*":
      health.lua.useOpenLibs: true
      health.lua: |
        local hs = {}
        if obj.status ~= nil then
          if obj.status.lastMessage ~= nil then
            hs.status = "Degraded"
            hs.message = obj.status.lastMessage
            return hs
          end
          if obj.status.NoMatchingInstances ~= nil then
            hs.status = "Degraded"
            hs.message = "No matching grafana instances found"
            return hs
          end
          if obj.status.hash ~= nil and obj.status.lastResync ~= nil and obj.status.uid ~= nil then
            local lastResync = os.time({year=string.sub(obj.status.lastResync, 1, 4), month=string.sub(obj.status.lastResync, 6, 7), day=string.sub(obj.status.lastResync, 9, 10), hour=string.sub(obj.status.lastResync, 12, 13), min=string.sub(obj.status.lastResync, 15, 16), sec=string.sub(obj.status.lastResync, 18, 19)})
            local diff = os.difftime(os.time(), lastResync)
            if diff <= 300 then
              hs.status = "Healthy"
              hs.message = "The resource already synced at " .. obj.status.lastResync
              return hs
            else
              hs.status = "Degraded"
              hs.message = "The resource last synced more than 5 minutes ago, at " .. obj.status.lastResync .. ". Please check the grafana-operator logs for more information"
              return hs
            end
          end
        end
        hs.status = "Progressing"
        hs.message = "Still creating the Object"
        return hs

Hi @zelig81 , that is really nice.
We are currently working on getting alert support added to the grafana-operator as can be seen here: https://github.com/grafana/grafana-operator/pull/1420.
In it, we are using conditions.
When it gets merged we are planning to change the other CRs to match how status is managed in the alert. How exactly they will look like we haven't decided.
So in short, your issue is in our TODO, we just haven't created any issue for it. So this will be a great way for us to keep track of it. Thank you.
When those changes get merged, it would be great if we can work on custom health checks for ArgoCD and write some docs about it.

I would be delighted to assist with this. Just please let me know the format of the conditions.

In general, we just need to understand which status/condition will be relevant for which of 4 states of the resource in terms of ArgoCD (Progressing; Healthy; Degraded; Suspended(if relevant) )
It will be most nice to have all the types of CR to follow this convention (Grafana, GrafanaFolder, GrafanaDatasource, GrafanaDashboard, GrafanaAlertrule...). Although it can look a little bit strange, it will allow us to make a single ArgoCD healthcheck to rule them all :)
And to add the healthcheck straight to https://github.com/argoproj/argo-cd

let's continue the conversation in slack

Hi, i don't know the status of this issue but i got a few information to add as of v5.14:
I noticed that when deploying resources with argoCD if the resource fails to sync it will keep the status field empty on argo and are marked as healthy and synced, in this case the CR also shows status: {}
The only resource that seems to be working is GrafanaNotificationPolicy, showing the status degraded and the error message when there is an issue


Code formatter?

What do people think of adding a code formatter to setuptools?
I like the idea, though I don't know if I am up to setting it up. I don't love black, but if that's the lowest-effort way to go, I'm fine with it. I'm also OK with something like yapf. My personal preference would be if someone created a yapf configuration that basically reproduces black, but with '' instead of "" and possibly 80-char line length (but I also don't care about that really).
Thoughts @jaraco @benoit-pierre @jmbowman?
Also, if we do this, I'd like it to wait until after we've cleared out the PR backlog from the sprints this past weekend. Running a code formatter on the existing codebase will cause a lot of merge conflicts with existing PRs.

Your instincts are exactly aligned with mine. I've been adopting black, because that seems to have the broadest adoption... but if I made any changes, I'd make the same choices. That said, in my other projects, I'm adopting black unmodified to have one less deviation to manage.

possibly 80-char line length

I can't believe there are still developers using 80-char line widths! It's driving me completely crazy to so every second line in a 2000+ line long file being cut up into pieces, making it completely unreadable.  :nauseated_face:
IMO. If you don't have an screen & editor capable of at least 140 char width, you probably should not develop with it. Especially if you don't know how to setup you editor for auto-wrapping if really necessary.
Please stop the <140 madness!

@pganssle I use split screens for side-by-side development, I think that's a very common workflow. My screen is not wide enough to comfortably fit 280 characters across, and if it were I'd probably prefer to split it into 3 panels of 100...
In any case, I think the point of things like PEP 8 and black is that there's no point having an argument about the style, just pick something and do it. The only problem I have is that black goes a different way than the common recommendations within PEP 8. It's not a huge deal, though.