prod build task doesn't compile ts files into one file

I'm submitting a ...  (check one with "x")
[ x ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see use [gitter](https://gitter.im/mgechev/angular2-seed) or [stackoverflow](https://stackoverflow.com/questions/tagged/angular2)

Current behavior

Expected behavior

It creates a js file for each component in dev, in prod none are outputted..
Minimal reproduction of the problem with instructions

run gulp build.prod
What is the motivation / use case for changing the behavior?

The intended behavior should create one js file.
Please tell us about your environment:

Angular Seed Version: aaaaf75

1.0

Node: node --version = 7.1

Probably the issue is related to malfunctioning fork of the seed. The build is passing and one of the requirements for this is the production build to work successfully.
Closing the issue for now. If it turns out that it's not a support request related to broken configuration I will reopen it and work on the potential issue.

ERROR: H:/angular-seed-master/src/client/app.module.ts[44, 2]: file should end w
ith a newline
ERROR: H:/angular-seed-master/src/client/main.ts[35, 5]: file should end with a
newline
ERROR: H:/angular-seed-master/src/client/assets/ts/global/global-const.ts[3, 43]
: file should end with a newline
ERROR: H:/angular-seed-master/src/client/assets/ts/global/globals.ts[6, 3]: file
should end with a newline
ERROR: H:/angular-seed-master/src/client/assets/ts/global/globals.ts[6, 2]: trai
ling whitespace
ERROR: H:/angular-seed-master/src/client/assets/ts/global/globals.ts[3, 13]: Mis
sing semicolon
ERROR: H:/angular-seed-master/src/client/assets/ts/components/layout/header/head
er.ts[23, 29]: missing whitespace
ERROR: H:/angular-seed-master/src/client/assets/ts/components/layout/header/logo
.ts[11, 27]: missing whitespace
ERROR: H:/angular-seed-master/src/client/assets/ts/components/layout/header/navi
gation.ts[11, 33]: missing whitespace
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[28, 58]: The property "menu" that you're trying to access does not exist in the
class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[28, 67]: The property "active" that you're trying to access does not exist in t
he class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[28, 84]: The method "onSelect" that you're trying to access does not exist in t
he class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[29, 38]: The property "menu" that you're trying to access does not exist in the
class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[30, 25]: The property "menu" that you're trying to access does not exist in the
class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[1, 1]: The property "menu" that you're trying to access does not exist in the c
lass declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[1, 1]: The property "menu" that you're trying to access does not exist in the c
lass declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[34, 61]: The property "menu" that you're trying to access does not exist in the
class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[34, 70]: The property "dropdown" that you're trying to access does not exist in
the class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[34, 79]: The property "menu" that you're trying to access does not exist in the
class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[35, 73]: The method "onSelect" that you're trying to access does not exist in t
he class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[36, 46]: The property "menu" that you're trying to access does not exist in the
class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[37, 33]: The property "submenu" that you're trying to access does not exist in
the class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[1, 1]: The property "menu" that you're trying to access does not exist in the c
lass declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[28, 58]: The property "menu" that you're trying to access does not exist in the
class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[28, 67]: The property "active" that you're trying to access does not exist in t
he class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[28, 84]: The method "onSelect" that you're trying to access does not exist in t
he class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[29, 38]: The property "menu" that you're trying to access does not exist in the
class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[30, 25]: The property "menu" that you're trying to access does not exist in the
class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[1, 1]: The property "menu" that you're trying to access does not exist in the c
lass declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[1, 1]: The property "menu" that you're trying to access does not exist in the c
lass declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[34, 61]: The property "menu" that you're trying to access does not exist in the
class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[34, 70]: The property "dropdown" that you're trying to access does not exist in
the class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[34, 79]: The property "menu" that you're trying to access does not exist in the
class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[35, 73]: The method "onSelect" that you're trying to access does not exist in t
he class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[36, 46]: The property "menu" that you're trying to access does not exist in the
class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[37, 33]: The property "submenu" that you're trying to access does not exist in
the class declaration.
ERROR: H:/angular-seed-master/src/client/templates/global/header/navigation.html
[1, 1]: The property "menu" that you're trying to access does not exist in the c
lass declaration.
ERROR: H:/angular-seed-master/src/client/assets/ts/components/layout/footer/foot
er.ts[10, 29]: missing whitespace
ERROR: H:/angular-seed-master/src/client/assets/ts/components/layout/footer/navi
gation.ts[10, 39]: missing whitespace
ERROR: H:/angular-seed-master/tools/config/project.config.ts[27, 1]: trailing wh
itespace
ERROR: H:/angular-seed-master/tools/config/project.config.ts[37, 1]: trailing wh
itespace
ERROR: H:/angular-seed-master/tools/config/project.config.ts[39, 85]: trailing w
hitespace
ERROR: H:/angular-seed-master/tools/config/project.config.ts[40, 85]: trailing w
hitespace
ERROR: H:/angular-seed-master/tools/config/seed.config.ts[190, 1]: trailing whit
espace
ERROR: H:/angular-seed-master/tools/tasks/project/build.assets.dev.ts[26, 5]: fi
le should end with a newline
ERROR: H:/angular-seed-master/tools/tasks/project/build.assets.dev.ts[19, 65]: t
railing whitespace
[13:38:33] Finished 'tslint' after 6.35 s
[13:38:33] Starting 'build.assets.prod'...
[13:38:34] Finished 'build.assets.prod' after 1.57 s
[13:38:34] Starting 'build.html_css'...
Node#moveTo was deprecated. Use Container#append.
[13:38:58] Finished 'build.html_css' after 23 s
[13:38:58] Starting 'copy.prod'...
[13:38:58] Finished 'copy.prod' after 680 ms
[13:38:58] Starting 'build.js.prod'...
Error: ENOENT: no such file or directory, open 'H:\angular-seed-master\dist\tmp
templates\global\body.html'
at Object.fs.openSync (fs.js:584:18)
at Object.fs.readFileSync (fs.js:491:33)
at getFileData (H:\angular-seed-master\node_modules\gulp-inline-ng2-template
\parser.js:284:17)
at H:\angular-seed-master\node_modules\gulp-inline-ng2-template\parser.js:24
8:22
at H:\angular-seed-master\node_modules\async\dist\async.js:3830:24
at replenish (H:\angular-seed-master\node_modules\async\dist\async.js:946:17
)
at H:\angular-seed-master\node_modules\async\dist\async.js:950:9
at eachOfLimit (H:\angular-seed-master\node_modules\async\dist\async.js:975:
24)
at H:\angular-seed-master\node_modules\async\dist\async.js:980:16
at _parallel (H:\angular-seed-master\node_modules\async\dist\async.js:3829:5
)
H:\angular-seed-master>

Error: ENOENT: no such file or directory, open 'H:\angular-seed-master\dist\tmp
templates\global\body.html'
at Object.fs.openSync (fs.js:584:18)
at Object.fs.readFileSync (fs.js:491:33)
at getFileData (H:\angular-seed-master\node_modules\gulp-inline-ng2-template
\parser.js:284:17)
at H:\angular-seed-master\node_modules\gulp-inline-ng2-template\parser.js:24
8:22
at H:\angular-seed-master\node_modules\async\dist\async.js:3830:24
at replenish (H:\angular-seed-master\node_modules\async\dist\async.js:946:17
)
at H:\angular-seed-master\node_modules\async\dist\async.js:950:9
at eachOfLimit (H:\angular-seed-master\node_modules\async\dist\async.js:975:
24)
at H:\angular-seed-master\node_modules\async\dist\async.js:980:16
at _parallel (H:\angular-seed-master\node_modules\async\dist\async.js:3829:5
)

Looks like an issue in the fork. Maybe you've missed module.id.

All my components, modules have module.id
@Component({
moduleId: module.id,
selector: 'phx-body',
templateUrl: '../../../../../templates/global/body.html',
})


PointOfInterest template and Information template added

Hello Oğuzhan,
Thank you for your work on the flutter_carplay plugin.
I have extended this to support the Information Template and the PointOfInterest Template. Furthermore, I have added the documentation and the sample program.
It would be nice if you could take a look at this and merge it into the plugin.
Kind regards
Olaf

Version 1.0.2 has been published in pub.dev. Check it out here. 🎉


Serializer Specific Caching

Expected Behavior
Passing one record to multiple serializers should result in 2 separate cached responses.
ProjectSerializer
ProjectListingSerializer
Actual Behavior
Cache only returns the first serialized instance of the record, regardless of what serializer is being called.
ProjectSerializer is called first
ProjectListingSerializer returns ProjectSerializer response
Steps to Reproduce the Problem

Create SerializerA and SerializerB
Pass SerializerA record A
Pass SerializerB record A

Proposed Solution
The cache key should include the serializer name by default.  If I create two separate serializers with separate attribute and relationship sets, the result of one cache should not be shared with the other.  Caching should happen at a Model + Serializer level.
If there is no opposition, I will work on the solution shortly.

@kpheasey I'm looking at this and I'm not sure this is a bug.
Starting with the #51 the cache options support the namespace and version. These both can be configured to use the serializer name. Consider:
cache_options store: Rails.cache, namespace: 'fast-jsonapi.<YOUR SERIALIZER TYPE>', expires_in: 1.hour

Could you confirm this is solving your issue?

This should be fixed as of #51


Customize AKS version

Changes

Customize AKS version
As current default AKS (1.22.6) has regression issues and causes PV/PVC failure and application gateway ingress failure in WLS on AKS offer.
@edburns  and I agreed to use a stable version in the offer to avoid such kind of potential exceptions in the future.
This pr allow the customer to use well-tested aks version or input his desired version.
The well-tested version is saved in aks-well-tested-version.json, see #142 , current tested version is 1.21.9. We will test and update the AKS version periodically.

Enhance UI for domain home source type and clear pv/pvc statement

Test pv/pvc mounting in the pipeline
Enable PV/PVC mounting in the testing parameter file.

Test cases

Use existing AKS instance -> deployed successfully
Use valid well-tested AKS version -> deployed successfully with the well-tested AKS version
Use invalid well-tested AKS version -> deployed successfully with the default AKS version
Input valid AKS version -> deployed successfully with the input AKS version
Input invalid AKS version -> failed.
Pipeline test with valid well-tested AKS version: https://github.com/galiacheng/weblogic-azure/actions/runs/2293347399

Test against the renamed parameter done.

At 2022-05-11 engineering meeting

Instead of an arbitrary text field where the user can put in any version, how about a drop down which is populated with the set of versions derived from the intersection of the versions listed at the operator docs and the aks docs.

Hello @mriccell , here is the proposed UI text:
AKS supports a range of Kubernetes versions. This offer is tested with with a specific Kubernetes version known to work with WebLogic server on AKS; click 'Learn more' to the find the version information.
[Learn more](https://aka.ms/wls-aks-well-tested-version)

Use latest supported AKS Kubernetes version

If yes, use the latest supported AKS Kubernetes version; if no, input a version using the known supported versions listed in the document linked above.

@rosemarymarano please give this wording your review, as well as the related operator docs PR

This offer is tested with with -> typo
WebLogic server -> WebLogic Server

This offer is tested with with -> typo WebLogic server -> WebLogic Server

Fixed in https://github.com/oracle/weblogic-azure/pull/140/commits/3f8410df245b946bbdc5678999f8d017613fc082

Successful pipeline: https://github.com/galiacheng/weblogic-azure/actions/runs/2310799825


d_a_sail 100%

it matches
most of the variable names totally suck, but I've taken care to use inlines and avoid obvious fakematches.
the unused bss pattern seems identical to the one in d_a_tag_msg and d_a_movie_player so I copied it from there.
lmk what you think

I've addressed everything in your review. the weak functions are out of order so I've not updated configure.py


feat: NPG-5184 - Added initial structure of the catalyst_dapp_connector package

Description

The added initial structure of the catalyst_dapp_connector package
Type of Change

[ x ] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑 Chore

@minikin Hi Sasha, we didn't want to ask you right away what could be the problem, but after all the tests we did, we couldn't solve the problem with Analyze and Format check... With Check spelling, we have a problem in that the name of the wallet is recognized as an error. Other checks are clear, but we are unable to sort out the format and analysis. What should we pay attention to in order to pass these tests?

@teske00

spell checker: we just need to add words mentioned in warnings to the dictionary.
formater: have you tried to run melos bootstrap and then melos run format?

@minikin When I want to run the "melos run format" or "melos lint:all" commands, I get this error (ScriptNotFoundException: The script format could not be found in the 'melos.yaml' file.). What else can I do to format the files in the right format?

@teske00 We need to update the melos.yaml file:
Please replace:
  lint:all:
    run: melos run analyze && melos run format
    description: Run all static analysis checks.

With:
  lint:
    run: melos run analyze
    description: Run all static analysis checks.

  format:
    run: melos exec dart format . --fix
    description: Format code.


Server Side data return not working

The data coming from the server side is not loaded into the dropdown list when we add dselect (If I don't use the dselect add-on, the data reload works).
The code HTML:
Country
<select name="dc_countryID" id="country" class="form-select rounded-0 selectlist">
<option value="0">Select</option>
<option value="0">USA</option>
<option value="0">Brazil</option>
</select>

State
<select name="dc_stateID" id="states" class="form-select rounded-0 selectlist">
<option value="0">Select</option>
</select>

City
<select name="dc_cityID" id="cities" class="form-select rounded-0 selectlist">
<option value="0">Select</option>
</select>

Javascript code: (#states and #cities select tag ID)
let selectList = document.querySelectorAll('.selectlist');
if (selectList != null) {
  for (const sl of selectList) {
	  dselect(sl, { search: true });
  }
}

$(document).ready(function(){

$("#country").on("change",function() {
var countryID = $(this).val();

$.ajax({
  url: "action_ajax.php",
  type: "POST",
  cache: false,
  data: {countryID:countryID},
  success: function(data) {
  console.log(data);
  $("#states").html(data);
},
  error: function (jqXHR, textStatus, errorThrown) {
  errorFunction();
}

});
});

$("#states").on("change",function() {
var statesID = $(this).val();

$.ajax({
  url: "action_ajax.php",
  type: "POST",
  cache: false,
  data: {statesID:statesID},
  success: function(data) {
  console.log(data);
  $("#cities").html(data);
},
  error: function (jqXHR, textStatus, errorThrown) {
  errorFunction();
}
});
});
});

hey @Fzoltan87, if you want it to work after you load the data from the server side, add the dselect after you load the $("#states") data,
success: function(data) {
console.log(data);
$("#states").html(data);
dselect(document.querySelector('#states'));
},
same for the cities one.
I had the same issue and that was the best way i could make it work.

hey @Fzoltan87, if you want it to work after you load the data from the server side, add the dselect after you load the $("#states") data,
success: function(data) { console.log(data); $("#states").html(data); dselect(document.querySelector('#states')); },
same for the cities one.
I had the same issue and that was the best way i could make it work.

Hy, Do you only need to call the dselect function here (success:function(data))?
You don't need this code then?
let selectList = document.querySelectorAll('.selectlist');
if (selectList != null) {
for (const sl of selectList) {
dselect(sl, { search: true });
}
}

the reason why it's not working, is because you're adding to the #states and #cities dynamically (aka from the server) after you load the page. the javascript code would work if you were loading that data at the beginning.
I have a main dropdown that has all the data populated for example #states only and use the javascript for that one. then when #states changes, update cities and use the dselect on success to update the #cities one to use it. (or you can get rid of the javascript code in general and use:
$(document).ready(function () {
dselect(document.querySelector('#states'));
});

I managed to solve it. The country dropdown does not close after selection. The county and city drop-down list closes automatically. Any ideas?


From client send a custom ping message every 30sec and check for the pong message

I have a working client that is connected to a server. The client is getting the messages from the server but the connection is dropped because the server is expecting a custom pong message every 30 sec.
How can a achieve this?

By "custom pong message" do you mean a websocket pong frame (as defined in RFC 6455 section 5.5.3) or just a standard message with special format?
This library allows low level operations (such as sending pong messages) using the method sendFrame
If you need to detect when a ping has been received, you can use the callback onWebsocketPing

Sorry I did a typo, mz client need to send a ping message like this one {"op":"ping"} every 30 seconds, how can I send this message every 30 secs?

Thats pretty simple, you can use either Timer or ScheduledExecutorService for calling a method every 30 seconds.
See https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/concurrent/ScheduledExecutorService.html#scheduleAtFixedRate(java.lang.Runnable,long,long,java.util.concurrent.TimeUnit) and https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/util/Timer.html#scheduleAtFixedRate(java.util.TimerTask,long,long)
Something like this:
ScheduledExecutorService scheduler = Executors.newScheduledThreadPool(1);
scheduler.scheduleAtFixedRate(() -> webSocketServer.send("{\"op\":\"ping\"}"), 0, 30, TimeUnit.SECONDS);

Thanks, this does make sense!

I can see a sendPing() method in Java(to ping from client), kindly let me know how I can send custom ping messages using java script?


Some questions about the file diffusion.py

Hello! Thanks for your great job for the implementation of DDPM with pytorch. It is my first time to do some research on diffusion model. After reading the file diffusion.py, I have several questions about the code and wonder I got some wrong understanding.
(1)In Line 144, there is a operation to restrict the value of x_{0} into (-1,1), but this function only return the value of mean and variance. I wonder if this line is unnecessary?
(2)I also have some problems with the function of the variable self.mean_type. I can understand that if self.mean_type='epsilon', the model can predict the epsilon_{theta} with loss function in Line 42: loss = F.mse_loss(self.model(x_t, t), noise, reduction='none'). I wonder if self.mean_type= 'xprev' or 'xstart', the loss function used to train the model should be changed as the model is required to predict the original sample x_{0} and former sample x_{t-1}? For example, if self.mean_type='xstart', loss = F.mse_loss(self.model(x_t, t), x_{0}, reduction='none')?

The same question. I guessed the author was going to test different sampling algorithms which were not publicly recognized.


Documentation issue BGFX_RESET_FLIP_AFTER_RENDER.

I'm looking at following documentation: BGFX_RESET_FLUSH_AFTER_RENDER and BGFX_RESET_FLIP_AFTER_RENDER.
The documentation of bgfx::reset() parameters says:

BGFX_RESET_FLUSH_AFTER_RENDER - Flush rendering after submitting to GPU.
BGFX_RESET_FLIP_AFTER_RENDER - This flag specifies where flip occurs. Default behavior is that flip occurs before rendering new frame. This flag only has effect when BGFX_CONFIG_MULTITHREADED=0.

While the documentation of the actual constants themselves says:

BGFX_RESET_FLUSH_AFTER_RENDER
Flush rendering after submitting to GPU. This flag specifies where flip occurs. Default behavior is that flip occurs before rendering new frame. This flag only has effect when BGFX_CONFIG_MULTITHREADED=0.
BGFX_RESET_FLIP_AFTER_RENDER

As I'm still trying to figure out what they do, I'm not sure what is correct, but I'm guessing the top one. Quick question: do these flags influence all backends?

While the documentation of the actual constants themselves says:
As I'm still trying to figure out what they do, I'm not sure what is correct, but I'm guessing the top one.

You're not parsing that correctly...
This is how you should read it:
https://bkaradzic.github.io/bgfx/bgfx.html#_CPPv4N4bgfx5resetE8uint32_t8uint32_t8uint32_tN13TextureFormat4EnumE

BGFX_RESET_FLUSH_AFTER_RENDER - Flush rendering after submitting to GPU.

BGFX_RESET_FLIP_AFTER_RENDER - This flag specifies where flip occurs. Default behaviour is that flip occurs before rendering new frame. This flag only has effect when BGFX_CONFIG_MULTITHREADED=0.

Quick question: do these flags influence all backends?

Yes. Flush is underlying API dependent (so it might have different behaviour on different APIs on the same HW), and flip order is bgfx specific and affects all backends equally.

You were too quickly I believe. Scroll a bit further down after following the link you gave. Check this: https://bkaradzic.github.io/bgfx/bgfx.html#c.BGFX_RESET_FLUSH_AFTER_RENDER

Thanks for the quick response about FLIP being bgfx specific. However; FLIP does influence the behaviour and fixes my 1 frame delay. However, AFIAK, I didn't compile with MULTITHREADED=0, but just put in in singletreaded mode at runtime, by calling renderFrame() before init().
Could it be that the documentation is outdated here with respect to the BGFX_CONFIG_MULTITHREADED=0 requirement?

https://bkaradzic.github.io/bgfx/bgfx.html#c.BGFX_RESET_FLUSH_AFTER_RENDER

Ok that's just IDL/doxygen mess up.

Could it be that the documentation is outdated here with respect to the BGFX_CONFIG_MULTITHREADED=0 requirement?

No. With multithreading that's effectively noop, because flip would happen immediately regardless if it's at the end of rendering or not. In singlethreaded mode, flip would be blocked with whatever sequential work you have.

Try again:
https://bkaradzic.github.io/bgfx/bgfx.html#c.BGFX_RESET_FLUSH_AFTER_RENDER


Add MonadCont instance and mepLeftEff

There is a ContEff but no instance for MonadCont, so I added the instance.
I also added the convenient function mapLeftEff corresponding to mapLeft.
e.g.)
import Control.Monad.Cont
import Control.Monad.Except
import Data.Extensible
import Data.Extensible.Effect.Default

testCont = leaveEff . flip runContDef return . callCC $ \exit -> do
  exit 0
  return 1

testEither :: Either String Int
testEither = leaveEff . runEitherDef . mapLeftEff show $ throwError 0

>> testCont
0
>> testEither
Left "0"

Thanks


Start updating TextBox for piet text changes

This is an attempt to integrate a bit of the new text stuff in to the TextBox widget.
Most of this code is a refactor that splits the actual manipulation of the buffer and selections into a new Editor struct that can be used to implement other text-editing widgets.
Apart from that, there are two other commits; one of them changes TextBox from being Widget<String> to be Widget<TextStorage + EditableText>, and the second adds a TextBox::multiline constructor, as a demo of multiline editing.
The multiline stuff is half-baked; the textbox does not support vertical scrolling. Ultimately it should be rewritten (maybe using @jneem's #1248 work?) so that it uses more standard scroll machinery; but this will be a bit fiddly, and I don't want to sink into it right now. I'll write up an issue detailing how I think this should work, though, and maybe someone can take it up?
This also includes a tweak to examples/styled_text.rs to show a multiline texbox; I'm going to replace this with a simple markdown preview app, but that work is mostly done but it's on another computer, and will have to wait til I get to the studio (perhaps later today?)

Besides the delete button comment, everything here worked (on Windows).

Thanks @justinmoon I'll take a look!


Added KUBELET_EXTRA_ARGS to kubelet service

What this PR does / why we need it:
Added the KUBELET_EXTRA_ARGS environment to the kubelet service unit. That way the user can override the kubelet flags via setting the KUBELET_EXTRA_ARGS environment variable and restarting the kubelet service.
Which issue(s) this PR fixes:
Fixes #996
Release note:
Added KUBELET_EXTRA_ARGS to kubelet service

What about https://github.com/gardener/gardener/blob/fe48899cd17746b0db8f0de7a0be1529c9a31548/charts/seed-operatingsystemconfig/original/templates/kubelet/_kubelet-config-file ?

Please have a look at this discussion here: https://github.com/gardener/gardener/pull/1040
Currently users are working around our reconciliation since we are not using the KUBELET_EXTRA_ARGS when starting the kubelet service.

Great, thanks @afritzler. You have decided to list it as first arg while https://kubernetes.io/docs/setup/independent/kubelet-integration/ supplies it as last arg. What's better/what do we want?

We moved it not to the end https://github.com/gardener/gardener/commit/4903a750e26640e5aac192d178970d18259fc768

Thx!


init() got an unexpected keyword argument 'new_adata_key'

When I try to run the "scatlasvae.pipeline.run_transfer" step, I get the following error: init() got an unexpected keyword argument 'new_adata_key'. I am confused by this because there does not seem to be a 'new_adata_key' in "huARdb_v2_GEX.CD8.hvg4k.supervised.model".

Please install an updated version of scAtlasVAE via:
pip install scatlasvae==<IP_ADDRESS> or pip install –upgrade scatlasvae
This should fix the issue. Feel free to reach me again if the issue persists.


python3Packages.starlette: 0.16.0 -> 0.17.1

Motivation for this change
Update to latest upstream release 0.17.1
Change log:

https://github.com/encode/starlette/releases/tag/0.17.1
https://github.com/encode/starlette/releases/tag/0.17.0

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

I tried nixpkgs-review on this PR and it hung. However, the package builds for Python 3.9 and Python 3.8. It failed for Python 3.7 for what seems like an unrelated reason (it looks like flake8 doesn't build for 3.7).

Result of nixpkgs-review pr 146980 run on x86_64-linux 1

4 packages failed to build:

python38Packages.cirq
python38Packages.cirq-rigetti
python39Packages.cirq
python39Packages.cirq-rigetti

30 packages built:

dyndnsc
esphome
home-assistant
platformio
python38Packages.dependency-injector
python38Packages.elastic-apm
python38Packages.envoy-reader
python38Packages.fastapi
python38Packages.ha-philipsjs
python38Packages.httpx-socks
python38Packages.ismartgate
python38Packages.json-logging
python38Packages.pyquil
python38Packages.respx
python38Packages.slowapi
python38Packages.starlette
python39Packages.dependency-injector
python39Packages.elastic-apm
python39Packages.envoy-reader
python39Packages.fastapi
python39Packages.ha-philipsjs
python39Packages.httpx-socks
python39Packages.ismartgate
python39Packages.json-logging
python39Packages.pyquil
python39Packages.respx
python39Packages.slowapi
python39Packages.starlette
soco-cli
theharvester

Result of nixpkgs-review pr 146980 run on x86_64-linux 1

4 packages failed to build:

python38Packages.cirq
python38Packages.cirq-rigetti
python39Packages.cirq
python39Packages.cirq-rigetti

30 packages built:

dyndnsc
esphome
home-assistant
platformio
python38Packages.dependency-injector
python38Packages.elastic-apm
python38Packages.envoy-reader
python38Packages.fastapi
python38Packages.ha-philipsjs
python38Packages.httpx-socks
python38Packages.ismartgate
python38Packages.json-logging
python38Packages.pyquil
python38Packages.respx
python38Packages.slowapi
python38Packages.starlette
python39Packages.dependency-injector
python39Packages.elastic-apm
python39Packages.envoy-reader
python39Packages.fastapi
python39Packages.ha-philipsjs
python39Packages.httpx-socks
python39Packages.ismartgate
python39Packages.json-logging
python39Packages.pyquil
python39Packages.respx
python39Packages.slowapi
python39Packages.starlette
soco-cli
theharvester


Catalog Next Package - Conditional Installation of Catalog

This issue covers conditional installation of the catalog. In concept, it will determine whether the resource is already installed and will forego retrieval. A force_install option is provided to override default behavior and will result in an unconditional (re) install.

[ ] Determine if resource is already installed
[ ] If force option is true, re-install
[ ] Record elapsed timings (zero if already present and not forced to re-install)

Technical Requirements
The signature of the initialize() function at this point will resemble:
function initialize( { timingCallback, force_option } )

This issue is closed since it is superseded by user requirements.


[AutoDiff] disable SIL/verify_all_overlays.py for "_Differentiation"

It is failing so I'll disable it to fix the tests until we fix it.

@swift-ci please smoke test

@swift-ci please smoke test linux

@swift-ci please smoke test linux


Fix editing action

Fix - after editing an action, it remains in place (because order is important), and does not jump to the very bottom.

Why not add inserting to all lists? Sorry, I didn't work on this project for some time so I don't remember why exactly I made it this way.

Other lists are sorted alphabetically. The order in them is not important. Insert an editable element in the same place does not make sense.

Looks good, thank you!


Out of bounds nanosecond timestamp

Make sure these boxes are checked before submitting your issue - thank you!

[yes ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ ] I have reproduced the issue with at least the latest released version of superset.
[ ] I have checked the issue tracker for the same issue and I haven't found one similar.

Superset version
0.23.2
Expected results
Actual results
2018-11-27 04:54:20,096:ERROR:root:Out of bounds nanosecond timestamp: 2289-01-01 00:00:00
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/pandas/core/tools/datetimes.py", line 303, in _convert_listlike
    values, tz = tslib.datetime_to_datetime64(arg)
  File "pandas/_libs/tslib.pyx", line 1884, in pandas._libs.tslib.datetime_to_datetime64
TypeError: Unrecognized value type: <class 'str'>

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/superset/viz.py", line 325, in get_df_payload
    df = self.get_df(query_obj)
  File "/usr/local/lib/python3.5/dist-packages/superset/viz.py", line 162, in get_df
    df[DTTM_ALIAS], utc=False, format=timestamp_format)
  File "/usr/local/lib/python3.5/dist-packages/pandas/core/tools/datetimes.py", line 373, in to_datetime
    values = _convert_listlike(arg._values, True, format)
  File "/usr/local/lib/python3.5/dist-packages/pandas/core/tools/datetimes.py", line 306, in _convert_listlike
    raise e
  File "/usr/local/lib/python3.5/dist-packages/pandas/core/tools/datetimes.py", line 294, in _convert_listlike
    require_iso8601=require_iso8601
  File "pandas/_libs/tslib.pyx", line 2156, in pandas._libs.tslib.array_to_datetime
  File "pandas/_libs/tslib.pyx", line 2339, in pandas._libs.tslib.array_to_datetime
  File "pandas/_libs/tslib.pyx", line 2307, in pandas._libs.tslib.array_to_datetime
  File "pandas/_libs/tslib.pyx", line 2301, in pandas._libs.tslib.array_to_datetime
  File "pandas/_libs/tslib.pyx", line 1669, in pandas._libs.tslib.convert_datetime_to_tsobject
  File "pandas/_libs/tslib.pyx", line 1848, in pandas._libs.tslib._check_dts_bounds
pandas._libs.tslib.OutOfBoundsDatetime: Out of bounds nanosecond timestamp: 2289-01-01 00:00:00
2018-11-27 04:54:20,098:ERROR:root:'NoneType' object has no attribute 'fillna'
Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/superset/views/core.py", line 1059, in generate_json
    payload = viz_obj.get_payload()
  File "/usr/local/lib/python3.5/dist-packages/superset/viz.py", line 293, in get_payload
    payload['data'] = self.get_data(df)
  File "/usr/local/lib/python3.5/dist-packages/superset/viz.py", line 1139, in get_data
    df = self.process_data(df)
  File "/usr/local/lib/python3.5/dist-packages/superset/viz.py", line 1044, in process_data
    df = df.fillna(0)
AttributeError: 'NoneType' object has no attribute 'fillna'

Steps to reproduce

timestamp: 2289-01-01? What does the data look like in the DB? This may be a pandas bug on their  pandas.to_datetime method.

Is there any resolution on this issue?


Cannot read property 'display_name' of undefined

Everything worked fine, but suddenly I get a blank white screen when I open Mattermost desktop app.
I can see this error in devtools console:
Loading zoom plugin index_bundle.js:28189
Loading bigbluebutton plugin index_bundle.js:28189
Loaded zoom plugin index_bundle.js:28189
websocket connecting to wss://mattermost.meridia.land/api/v4/websocket index_bundle.js:28195 TypeError: Cannot read property 'display_name' of undefined
webview.addEventListener.e @ index_bundle.js:28195 index_bundle.js:28195
Uncaught TypeError: Cannot read property 'display_name' of undefined
Screenshot: https://prnt.sc/ltg2bb
For other users in our company, everything works fine.
I can't recall anything that changed on my system, except that I have cloned this repo https://github.com/electron-react-boilerplate/electron-react-boilerplate and installed dependencies + installed Yarn.
OS: MacOS Mojave
Mattermost v: 4.2.0
Npm v: 6.5.0
Any ideas ?

As far as looking the error, it seems that webapp failed to load data by some reason. So I feel it should happen also on web browsers though, would you check? And are other users also using the desktop app on macOS?

As far as looking the error, it seems that webapp failed to load data by some reason. So I feel it should happen also on web browsers though, would you check? And are other users also using the desktop app on macOS?

The browser version works fine. I have tested both on Firefox and Chrome.
Other users use desktop apps both Windows and MacOS and they have no such problem.
Any other logs I can provide?

Closing this as there is a workaround,

Was able to reproduce this issue.
The steps are - clicking on your own username in left sidebar.
Same happens both on Mac and Windows machines.

It also happened to me when I clicked on my own username on the left sidebar under DIRECT MESSAGES. Then for a half a second I was able to see my whole workspace when I went through all the possible menu items, but the gray screen came straight back.

I can now also confirm that this bug can be reproduced by trying to add yourself to DIRECT MESSAGES list.

It also happened when I left one of the channels, but this time reloading a window helped, so I guess it's a different, but related issue.

Hi all, what Mattermost server version are you on?

We get the same error when we open email notifications.
No errors in the server logs. Only the browser DevConsole shows the

Cannot read property 'display_name' of undefined

Server version 5.17.0.

Closing as inactive.


fixes undefined name "encode_hex"

Coverage decreased (-0.05%) to 49.486% when pulling 673254c22b0d023abcc0fe57c08be8a1372434ed on AndreMiras:feature/fix_undefined_name_encode_hex into a001c07ff5838a62f522227e629b5a029a37b25c on ethereum:develop.


Add audit logging support with a default logging policy

Enable Kubernetes API audit logging with a default logging policy. When
desired, users can provide their custom audit policy rules using an
ansible variable.
Fixes #138
Signed-off-by: Alexander Brand<EMAIL_ADDRESS>

@erictcgs can you review for whether this would address your needs?


Text become jagged at specific zoom ratio

Attach (recommended) or Link to PDF file here: pdfjs bug.pdf
Configuration:

Web browser and its version: Chromium 87

Operating system and its version: Windows 10 20H2

PDF.js version: 2.7.533

Is a browser extension: it's the demo

Steps to reproduce the problem:

Open the linked "pdfjs bug.pdf"
Set zoom to 125%

What is the expected behavior? (add screenshot)
Smooth text (screenshot of PDF-XChange)

What went wrong? (add screenshot)
Jagged text (screenshot of PDF.js)

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):
https://mozilla.github.io/pdf.js/web/viewer.html

Duplicate of #8201


Flutter 3.13 Compatibility

Hi and thanks for the nice package.
On Flutter 3.13 I get the following compilation errors with version sliver_tools: ^0.2.12:
: Error: A value of type 'RenderObject?' can't be assigned to a variable of type 'AbstractNode?'.
sliver_stack.dart:282

'RenderObject' is from 'package:flutter/src/rendering/object.dart' ('/C:/flutter/packages/flutter/lib/src/rendering/object.dart').
object.dart:1
'AbstractNode' is from 'package:flutter/src/foundation/node.dart' ('/C:/flutter/packages/flutter/lib/src/foundation/node.dart').
node.dart:1
final AbstractNode? targetParent = renderObject.parent;
^
: Error: The method 'markNeedsLayout' isn't defined for the class 'AbstractNode?'.
sliver_stack.dart:283
'AbstractNode' is from 'package:flutter/src/foundation/node.dart' ('/C:/flutter/packages/flutter/lib/src/foundation/node.dart').
node.dart:1
Try correcting the name to the name of an existing method, or defining a method named 'markNeedsLayout'.
if (targetParent is RenderObject) targetParent.markNeedsLayout();

@robert-virkus This should be already fixed in 0.2.12, can you double check that the pubspec lock is also using 0.2.12?

Thanks for your quick response, this was a flutter pub upgrade problem on my side.


applied workaround of ics files with TZID before DATE in DTSTART/DTEND

This pull request work arounds a problem in the ics parse module which seem to have problems with ics files containing event where the TZID comes before DTSTART/DTEND and thus always returns the ev.start/ev.end in string format. Thus we do the conversion on our own until the ics parser module is fixed.

Thanks

Thanks for merging the PR. However, please make sure to als run npm publish

I can merge from Browser, but to publish I need a PC. :) and I don't have
yet.
2017-02-12 2:00 GMT+01:00 Jens Maus<EMAIL_ADDRESS>
Thanks for merging the PR. However, please make sure to als run npm
publish
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/ioBroker/ioBroker.ical/pull/11#issuecomment-279188099,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEXqgGwlptau82q0QFBBCvEScNL55ScUks5rblmmgaJpZM4L-I1N
.


MAINT: Fix various code issues like the direct iteration over dictionaries.

Add assert statement in tests.
Remove unused variables.
Do not use mutable variables in method's signatures.

Codecov Report
Attention: Patch coverage is 66.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 76.45%. Comparing base (1ee0d5c) to head (d2d15d4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4490      +/-   ##
==========================================
- Coverage   81.43%   76.45%   -4.98%
==========================================
  Files         110      110
  Lines       53482    53482
==========================================
- Hits        43551    40889    -2662
- Misses       9931    12593    +2662


Update useFieldArray codeExample

Description

Need to Add a curly bracket to the end of example

oh wow thank you 🙏


[BUG] Mobile BYOM Issue: How to generate .tflite models form export?

Describe the issue
I want to get .tflite model. I have an app which can deploy tensorflow lite models, while it only accepts .tflite file. I followed the instructions here, and in the end it says the model can be .tflite exported. But I don't know how to get .tflite model files.
To Reproduce
I ran command below to learn the usages, but no options like "--target-runting tflite".
python -m qai_hub_models.models.llama_v2_7b_chat_quantized.export -h

Then I ran the command below, and only .bin models are downloaded.
python -m qai_hub_models.models.llama_v2_7b_chat_quantized.export --device "XR2 Gen 2 (Proxy)"

Expected behavior
I want to get LLM files of .tflite type.
Host configuration:

OS and version: Windows 10 (in virtual python env)
Browser:  chrome
QAI-Hub-Models version: latest of this issue posted

@XinyuGroceryStore
You can download the model using the Python API, below is minimal example.
The default target seems to be TFLITE models (notice no target passed in submit_compile_job).
import qai_hub as hub
import torch
from torchvision.models import mobilenet_v2

torch_model = mobilenet_v2(pretrained=True)
torch_model.eval()

input_shape = (1, 3, 224, 224)
example_input = torch.rand(input_shape)
traced_torch_model = torch.jit.trace(torch_model, example_input)

compile_job = hub.submit_compile_job(
    model=traced_torch_model,
    device=hub.Device("QCS6490 (Proxy)"),
    input_specs=dict(image=input_shape),
)

target_model = compile_job.get_target_model()
target_model.download("mobilenet_v2.tflite")

Thank you. But I want to use llama-2 model that was mentioned in Qualcomm AI Hub. Can you tell me the python api including llama-2 or llama-3 model?在 2024年8月27日，16:36，Midi12 @.***> 写道：
@XinyuGroceryStore
You can download the model using the Python API, below is minimal example.
The default target seems to be TFLITE models (notice no target passed in submit_compile_job).
import qai_hub as hub
import torch
from torchvision.models import mobilenet_v2
torch_model = mobilenet_v2(pretrained=True)
torch_model.eval()
input_shape = (1, 3, 224, 224)
example_input = torch.rand(input_shape)
traced_torch_model = torch.jit.trace(torch_model, example_input)
compile_job = hub.submit_compile_job(
model=traced_torch_model,
device=hub.Device("QCS6490 (Proxy)"),
input_specs=dict(image=input_shape),
)
target_model = compile_job.get_target_model()
target_model.download("mobilenet_v2.tflite")
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Hi @XinyuGroceryStore , thank you for the question. Llama family of models are a bit different than others on AI Hub Models, as you've noticed. For these models, you need to run the export.py yourself to generate the model.
For llama2 you need to fetch the weights from Meta. Follow ReadMe and steps here: https://github.com/quic/ai-hub-models/tree/main/qai_hub_models/models/llama_v2_7b_chat_quantized.
Once you have followed the steps in the ReadMe when you export model from qai-hub-models, it upload .aimet model on AI Hub.
.aimet model has .onnx model in it
You can download source model from compile job to get .onnx model
https://github.com/quic/ai-hub-models/tree/main/qai_hub_models/models/llama_v2_7b_chat_quantized#export-for-on-device-deployment


Redraw right part when scrolling

See #1261. Right wave part isn't draw in the last canvas when use zoom process in multi canvas.

I see a strange test which exit function, it can be delete.
Now the loop can use correct bound for range peaks, change last set.

@awenger63 build fails, see https://travis-ci.org/katspaugh/wavesurfer.js/builds/346325083#L520

Thanks @thijstriemstra.

@awenger63 it would be really great if we could add tests for this (because we have infrastructure for that). I'm afraid it's the only way to really verify this. See https://github.com/katspaugh/wavesurfer.js/blob/master/spec/wavesurfer.spec.js for example, and that directory in general: https://github.com/katspaugh/wavesurfer.js/blob/master/spec/
if you have questions, i'd be happy to help.

@thijstriemstra my questions are how I can install all (wavesurfer project and infrastructure) on my  Netbeans to work easily ? Because today I don't arrive to use the local npm directory in my Netbean with github. Perhaps I do something wrong. Is it exist documentation to learn modify and runing your js ? than if I can add test for the project, I will do it.

@awenger63 follow these steps: https://github.com/katspaugh/wavesurfer.js#development
And run npm run test

OK thanks you, I take a look and make feedback

@thijstriemstra After lot issues for install npm wavesurfer.js, now compile webpack failed
ERROR in ./src/wavesurfer.js Module parse failed: Unexpected token (177:18) You may need an appropriate loader to handle this file type. | export default class WaveSurfer extends util.Observer { |     /** @private */ |     defaultParams = { |         audioContext: null, |         audioRate: 1, webpack: Failed to compile.
Could you help me to resolve it ?

@awenger63 what version of webpack are you using? what commands did you use to produce this error message?

In node-modules inside wavesurfer.js directory it is version 3.11.0
Commands use : npm run start  or  npm run test
Other point, I take a look to the files in spec directory that they are using for test. In case of this pull request, I think it isn't possible to test like this because the validation need to be see on the layout. Redraw process is putting lines on canvas element (fisrt, middle, last ...) . How is it possible to test and validated drawing had done ?

There's an open pr for visual regression testing, allowing us to compare the test results (an image) visually: https://github.com/katspaugh/wavesurfer.js/pull/1210
Can you paste the full error here including the commands you typed?

C:\Users\awenger\AppData\Roaming\npm\node_modules\npm\node_modules\wavesurfer.j
s>npm test

<EMAIL_ADDRESS>test C:\Users\awenger\AppData\Roaming\npm\node_modules\np
m\node_modules\wavesurfer.js
karma start karma.conf.js

webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
webpack: wait until bundle finished:
ERROR in ./src/wavesurfer.js
Module parse failed: Unexpected token (177:18)
You may need an appropriate loader to handle this file type.
| export default class WaveSurfer extends util.Observer {
|     /** @private /
|     defaultParams = {
|         audioContext: null,
|         audioRate: 1,
webpack: Failed to compile.
07 03 2018 16:37:04.388:INFO [karma]: Karma v2.0.0 server started at http://0.0.
0.0:9876/
07 03 2018 16:37:04.388:INFO [launcher]: Launching browser Chrome with unlimited
concurrency
07 03 2018 16:37:04.408:INFO [launcher]: Starting browser Chrome
07 03 2018 16:37:06.857:INFO [Chrome 64.0.3282 (Windows 7.0.0)]: Connected on so
cket Vs3dYzv-00BXWzbVAAAA with id 62635110
Chrome 64.0.3282 (Windows 7.0.0) ERROR
{
"message": "Uncaught Error: Module parse failed: Unexpected token (177:18)\n
You may need an appropriate loader to handle this file type.\n| export default c
lass WaveSurfer extends util.Observer {\n|     /* @private /\n|     defaultPar
ams = {\n|         audioContext: null,\n|         audioRate: 1,\nat spec/plugin-
api.spec.js:85:1\n\nError: Module parse failed: Unexpected token (177:18)\nYou m
ay need an appropriate loader to handle this file type.\n| export default class
WaveSurfer extends util.Observer {\n|     /* @private /\n|     defaultParams =
{\n|         audioContext: null,\n|         audioRate: 1,\n    at Object.define
Property.value (spec/plugin-api.spec.js:85:7)\n    at webpack_require (spec/
plugin-api.spec.js:35:30)\n    at Object. (spec/plugin-api.spec.js:93
:77)\n    at webpack_require (spec/plugin-api.spec.js:35:30)\n    at Object.
defineProperty.value (spec/plugin-api.spec.js:78:18)\n    at spec/plugin-api.spe
c.js:81:10\n    at webpackUniversalModuleDefinition (spec/plugin-api.spec.js:14:
24)\n    at spec/plugin-api.spec.js:15:3",
"str": "Uncaught Error: Module parse failed: Unexpected token (177:18)\nYou
may need an appropriate loader to handle this file type.\n| export default class
WaveSurfer extends util.Observer {\n|     /* @private /\n|     defaultParams
= {\n|         audioContext: null,\n|         audioRate: 1,\nat spec/plugin-api.
spec.js:85:1\n\nError: Module parse failed: Unexpected token (177:18)\nYou may n
eed an appropriate loader to handle this file type.\n| export default class Wave
Surfer extends util.Observer {\n|     /* @private */\n|     defaultParams = {\n
|         audioContext: null,\n|         audioRate: 1,\n    at Object.defineProp
erty.value (spec/plugin-api.spec.js:85:7)\n    at webpack_require (spec/plug
in-api.spec.js:35:30)\n    at Object. (spec/plugin-api.spec.js:93:77)
\n    at webpack_require (spec/plugin-api.spec.js:35:30)\n    at Object.defi
neProperty.value (spec/plugin-api.spec.js:78:18)\n    at spec/plugin-api.spec.js
:81:10\n    at webpackUniversalModuleDefinition (spec/plugin-api.spec.js:14:24)
n    at spec/plugin-api.spec.js:15:3"
}
Chrome 64.0.3282 (Windows 7.0.0) ERROR
{
"message": "Uncaught Error: Module parse failed: Unexpected token (177:18)\n
You may need an appropriate loader to handle this file type.\n| export default c
lass WaveSurfer extends util.Observer {\n|     /** @private /\n|     defaultPar
ams = {\n|         audioContext: null,\n|         audioRate: 1,\nat spec/util.sp
ec.js:85:1\n\nError: Module parse failed: Unexpected token (177:18)\nYou may nee
d an appropriate loader to handle this file type.\n| export default class WaveSu
rfer extends util.Observer {\n|     /* @private /\n|     defaultParams = {\n|
audioContext: null,\n|         audioRate: 1,\n    at Object.defineProper
ty.value (spec/util.spec.js:85:7)\n    at webpack_require (spec/util.spec.js
:35:30)\n    at Object. (spec/util.spec.js:94:77)\n    at webpack_r
equire (spec/util.spec.js:35:30)\n    at Object.defineProperty.value (spec/uti
l.spec.js:78:18)\n    at spec/util.spec.js:81:10\n    at webpackUniversalModuleD
efinition (spec/util.spec.js:14:24)\n    at spec/util.spec.js:15:3",
"str": "Uncaught Error: Module parse failed: Unexpected token (177:18)\nYou
may need an appropriate loader to handle this file type.\n| export default class
WaveSurfer extends util.Observer {\n|     /* @private /\n|     defaultParams
= {\n|         audioContext: null,\n|         audioRate: 1,\nat spec/util.spec.j
s:85:1\n\nError: Module parse failed: Unexpected token (177:18)\nYou may need an
appropriate loader to handle this file type.\n| export default class WaveSurfer
extends util.Observer {\n|     /* @private */\n|     defaultParams = {\n|
audioContext: null,\n|         audioRate: 1,\n    at Object.defineProperty.v
alue (spec/util.spec.js:85:7)\n    at webpack_require (spec/util.spec.js:35:
30)\n    at Object. (spec/util.spec.js:94:77)\n    at webpack_requi
re (spec/util.spec.js:35:30)\n    at Object.defineProperty.value (spec/util.sp
ec.js:78:18)\n    at spec/util.spec.js:81:10\n    at webpackUniversalModuleDefin
ition (spec/util.spec.js:14:24)\n    at spec/util.spec.js:15:3"
}
Chrome 64.0.3282 (Windows 7.0.0) ERROR
{
"message": "Uncaught Error: Module parse failed: Unexpected token (177:18)\n
You may need an appropriate loader to handle this file type.\n| export default c
lass WaveSurfer extends util.Observer {\n|     /** @private /\n|     defaultPar
ams = {\n|         audioContext: null,\n|         audioRate: 1,\nat spec/wavesur
fer.spec.js:85:1\n\nError: Module parse failed: Unexpected token (177:18)\nYou m
ay need an appropriate loader to handle this file type.\n| export default class
WaveSurfer extends util.Observer {\n|     /* @private /\n|     defaultParams =
{\n|         audioContext: null,\n|         audioRate: 1,\n    at Object.define
Property.value (spec/wavesurfer.spec.js:85:7)\n    at webpack_require (spec/
wavesurfer.spec.js:35:30)\n    at Object.module.exports (spec/wavesurfer.spec.js
:95:77)\n    at webpack_require (spec/wavesurfer.spec.js:35:30)\n    at Obje
ct.defineProperty.value (spec/wavesurfer.spec.js:78:18)\n    at spec/wavesurfer.
spec.js:81:10\n    at webpackUniversalModuleDefinition (spec/wavesurfer.spec.js:
14:24)\n    at spec/wavesurfer.spec.js:15:3",
"str": "Uncaught Error: Module parse failed: Unexpected token (177:18)\nYou
may need an appropriate loader to handle this file type.\n| export default class
WaveSurfer extends util.Observer {\n|     /* @private /\n|     defaultParams
= {\n|         audioContext: null,\n|         audioRate: 1,\nat spec/wavesurfer.
spec.js:85:1\n\nError: Module parse failed: Unexpected token (177:18)\nYou may n
eed an appropriate loader to handle this file type.\n| export default class Wave
Surfer extends util.Observer {\n|     /* @private */\n|     defaultParams = {\n
|         audioContext: null,\n|         audioRate: 1,\n    at Object.defineProp
erty.value (spec/wavesurfer.spec.js:85:7)\n    at webpack_require (spec/wave
surfer.spec.js:35:30)\n    at Object.module.exports (spec/wavesurfer.spec.js:95:
77)\n    at webpack_require (spec/wavesurfer.spec.js:35:30)\n    at Object.d
efineProperty.value (spec/wavesurfer.spec.js:78:18)\n    at spec/wavesurfer.spec
.js:81:10\n    at webpackUniversalModuleDefinition (spec/wavesurfer.spec.js:14:2
4)\n    at spec/wavesurfer.spec.js:15:3"
}
npm ERR! Test failed.  See above for more details.
C:\Users\awenger\AppData\Roaming\npm\node_modules\npm\node_modules\wavesurfer.j
s>

C:\Users\awenger\AppData\Roaming\npm\node_modules\npm\node_modules\wavesurfer.j
s>npm start

<EMAIL_ADDRESS>start C:\Users\awenger\AppData\Roaming\npm\node_modules\n
pm\node_modules\wavesurfer.js
npm run build:plugins && npm run build:htmlinit && webpack-dev-server --config
./build-config/webpack.dev.main.js

<EMAIL_ADDRESS>build:plugins C:\Users\awenger\AppData\Roaming\npm\node_m
odules\npm\node_modules\wavesurfer.js
webpack --config ./build-config/webpack.prod.plugins.js

Hash: bdf1bfdaf9a7748df4f0
Version: webpack 3.11.0
Time: 250ms
Asset     Size  Chunks             Chunk Names
wavesurfer.timeline.js.map   3.2 kB       0  [emitted]  timeline
wavesurfer.timeline.js  3.51 kB       0  [emitted]  timeline
wavesurfer.regions.js  32.5 kB       2  [emitted]  regions
wavesurfer.minimap.js  16.6 kB       3  [emitted]  minimap
wavesurfer.microphone.js  14.9 kB       4  [emitted]  microphone
wavesurfer.mediasession.js  6.28 kB       5  [emitted]  mediasession
wavesurfer.elan.js  3.43 kB       6  [emitted]  elan
wavesurfer.cursor.js  3.43 kB       7  [emitted]  cursor
wavesurfer.spectrogram.js  24.7 kB       1  [emitted]  spectrogram
wavesurfer.spectrogram.js.map  28.9 kB       1  [emitted]  spectrogram
wavesurfer.regions.js.map  37.6 kB       2  [emitted]  regions
wavesurfer.minimap.js.map    19 kB       3  [emitted]  minimap
wavesurfer.microphone.js.map  17.2 kB       4  [emitted]  microphone
wavesurfer.mediasession.js.map  6.93 kB       5  [emitted]  mediasession
wavesurfer.elan.js.map  3.18 kB       6  [emitted]  elan
wavesurfer.cursor.js.map  3.19 kB       7  [emitted]  cursor
[0] ./src/plugin/timeline.js 329 bytes {0} [built] [failed] [1 error]
[1] ./src/plugin/minimap.js 13.3 kB {3} [built]
[2] ./src/plugin/regions.js 29.1 kB {2} [built]
[3] ./src/plugin/spectrogram.js 21.3 kB {1} [built]
[4] ./src/plugin/cursor.js 254 bytes {7} [built] [failed] [1 error]
[5] ./src/plugin/microphone.js 11.5 kB {4} [built]
[6] ./src/plugin/mediasession.js 2.88 kB {5} [built]
[7] ./src/plugin/elan.js 258 bytes {6} [built] [failed] [1 error]
ERROR in ./src/plugin/elan.js
Module parse failed: Unexpected token (56:10)
You may need an appropriate loader to handle this file type.
|     }
|
|     Types = {
|         ALIGNABLE_ANNOTATION: 'ALIGNABLE_ANNOTATION',
|         REF_ANNOTATION: 'REF_ANNOTATION'
ERROR in ./src/plugin/cursor.js
Module parse failed: Unexpected token (69:18)
You may need an appropriate loader to handle this file type.
|      * @type {CursorPluginParams}
|      */
|     defaultParams = {
|         hideOnBlur: true,
|         width: '1px',
ERROR in ./src/plugin/timeline.js
Module parse failed: Unexpected token (70:14)
You may need an appropriate loader to handle this file type.
|     // event handlers
|     /** @private */
|     _onScroll = () => {
|         if (this.wrapper && this.drawer.wrapper) {
|             this.wrapper.scrollLeft = this.drawer.wrapper.scrollLeft;
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>build:plugins: webpack --config ./build-config/web pack.prod.plugins.js
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build:plugins script.
npm ERR! This is probably not a problem with npm. There is likely additional log
ging output above.
npm ERR!      C:\Users\awenger\AppData\Roaming\npm-cache_logs\2018-03-07T15_39_
37_426Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>start: npm run build:plugins && npm run build:html init && webpack-dev-server --config ./build-config/webpack.dev.main.js
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional log
ging output above.
npm ERR!      C:\Users\awenger\AppData\Roaming\npm-cache_logs\2018-03-07T15_39_
37_456Z-debug.log
C:\Users\awenger\AppData\Roaming\npm\node_modules\npm\node_modules\wavesurfer.j
s>^A

That's strange. What version of NPM are you using? Can you update to the latest? Here's how a regular windows built should look like: https://ci.appveyor.com/project/katspaugh/wavesurfer-js/build/1.0.209/job/0ov8b99pka4ifulh

node v8.9.4
npm v5.7.1

@thijstriemstra I make a new installation. now webpack v4.1.0 : need to change package.json to add  --mode production option.
When i running building => same error parsing wavesrufer.js
When i running start =>

webpack --mode production --config ./build-config/webpack.prod.plugins.js

C:\Users\awenger\AppData\Roaming\npm\node_modules\wavesurfer.js\node_modules\we
bpack-cli\bin\webpack.js:439
throw err;
^
ValidationError: SourceMap DevTool Plugin Invalid Options
options.namespace should be string
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>build:plugins: webpack --mode production --config ./build-config/webpack.prod.plugins.js
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build:plugins script.

@awenger63 you should use webpack 3, 4 is very new and haven't tested it with wavesurfer yet. If you're still having issues perhaps try building on a Ubuntu image but it's weird that appveyor is fine and your machine isn't.

OK, I change webpack to v3.11 and remove change in package.json. = same result
I see this https://stackoverflow.com/questions/33469929/you-may-need-an-appropriate-loader-to-handle-this-file-type-with-webpack-and-b and make new test without change !
This take lot of time at this moment. I will retry later in other machine or hope someone know this issue ...
Thanks a lot @thijstriemstra

This was fixed with #1570 (afaik).


'InternalSelectableMathState' is missing implementations for these members:

Error: Cannot run with sound null safety, because the following dependencies
don't support null safety:
package:facebook_audience_network

For solutions, see https://dart.dev/go/unsound-null-safety
/C:/src/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_math_fork-0.3.3+1/lib/src/widgets/selectable.dart:407:7: Error: The non-abstract class 'InternalSelectableMathState'
is missing implementations for these members:
TextSelectionDelegate.copySelection
TextSelectionDelegate.cutSelection
TextSelectionDelegate.pasteText
TextSelectionDelegate.selectAll
Try to either
provide an implementation,
inherit an implementation from a superclass or mixin,
mark the class as abstract, or
provide a 'noSuchMethod' implementation.

class InternalSelectableMathState extends State
^^^^^^^^^^^^^^^^^^^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/services/text_input.dart:985:8: Context: 'TextSelectionDelegate.copySelection' is defined here.
void copySelection(SelectionChangedCause cause);
^^^^^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/services/text_input.dart:965:8: Context: 'TextSelectionDelegate.cutSelection' is defined here.
void cutSelection(SelectionChangedCause cause);
^^^^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/services/text_input.dart:973:16: Context: 'TextSelectionDelegate.pasteText' is defined here.
Future pasteText(SelectionChangedCause cause);
^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/services/text_input.dart:979:8: Context: 'TextSelectionDelegate.selectAll' is defined here.
void selectAll(SelectionChangedCause cause);
^^^^^^^^^
Unhandled exception:
Bad state: Unsupported Null Safety mode NonNullableByDefaultCompiledMode.Invalid, in null.
#0 ProgramCompiler.emitModule (package:dev_compiler/src/kernel/compiler.dart:472:9)
#1 JavaScriptBundler.compile (package:frontend_server/src/javascript_bundle.dart:152:33)
#2 FrontendCompiler.writeJavascriptBundle (package:frontend_server/frontend_server.dart:650:47)
#3 FrontendCompiler.compile (package:frontend_server/frontend_server.dart:558:9)
#4 listenAndCompile. (package:frontend_server/frontend_server.dart:1135:11)
the Dart compiler exited unexpectedly.

Error: Cannot run with sound null safety, because the following dependencies
don't support null safety:

package:facebook_audience_network

For solutions, see https://dart.dev/go/unsound-null-safety
/C:/src/flutter/.pub-cache/hosted/pub.dartlang.org/flutter_math_fork-0.3.3+1/lib/src/widgets/selectable.dart:407:7: Error: The non-abstract class 'InternalSelectableMathState'
is missing implementations for these members:

TextSelectionDelegate.copySelection
TextSelectionDelegate.cutSelection
TextSelectionDelegate.pasteText
TextSelectionDelegate.selectAll
Try to either
provide an implementation,
inherit an implementation from a superclass or mixin,
mark the class as abstract, or
provide a 'noSuchMethod' implementation.

class InternalSelectableMathState extends State
^^^^^^^^^^^^^^^^^^^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/services/text_input.dart:985:8: Context: 'TextSelectionDelegate.copySelection' is defined here.
void copySelection(SelectionChangedCause cause);
^^^^^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/services/text_input.dart:965:8: Context: 'TextSelectionDelegate.cutSelection' is defined here.
void cutSelection(SelectionChangedCause cause);
^^^^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/services/text_input.dart:973:16: Context: 'TextSelectionDelegate.pasteText' is defined here.
Future pasteText(SelectionChangedCause cause);
^^^^^^^^^
/C:/src/flutter/packages/flutter/lib/src/services/text_input.dart:979:8: Context: 'TextSelectionDelegate.selectAll' is defined here.
void selectAll(SelectionChangedCause cause);
^^^^^^^^^
Unhandled exception:
Bad state: Unsupported Null Safety mode NonNullableByDefaultCompiledMode.Invalid, in null.
#0      ProgramCompiler.emitModule (package:dev_compiler/src/kernel/compiler.dart:472:9)
#1      JavaScriptBundler.compile (package:frontend_server/src/javascript_bundle.dart:152:33)
#2      FrontendCompiler.writeJavascriptBundle (package:frontend_server/frontend_server.dart:650:47)

#3      FrontendCompiler.compile (package:frontend_server/frontend_server.dart:558:9)

#4      listenAndCompile. (package:frontend_server/frontend_server.dart:1135:11)

the Dart compiler exited unexpectedly.

Duplicate of #7.


only log [Run Config] Current config: <etc> when running from config

I'm getting the [Run Config] Current config: output when I run my game with the regular play button, which makes it look like it's running from the config runner, but it's not: the 'main' scene is ran instead of the custom one in the mentioned config. So it seems like incorrect behavior.

It's due to limitations with Godot addons.
Godot's plugin interface doesn't offer much in terms of setting up the scene being played, you can pass any kind of data between the editor and game. I need some form of communication with the played game for run configs to work, so my solution was to save the config info into the project settings, which will be read by the autoload when the game starts.
Because all the data is in the project setting, it comes into effect regardless of how the scene was run. So I treated the run button more like an optional button you can use that will run the custom scene, while the native button still uses the config, just not its set scene.
There's probably some way to make it work by temporarily setting flags in the project setting or to a separate file, but it's all super hacky and error-prone so I decided against it.

To clarify: if I run the game using the regular play button, it doesn't run the scene configured in the config, whereas it does when I run using the additional button. So it's not exactly the same behavior, and that's confusing – especially when there's a log entry that makes it seem like it should be.
I don't know what the technical solution here is either! I'm just confused and that confusion is stopping me from taking this plugin to the rest of my team, even though it is almost precisely what I was looking for.

To clarify: if I run the game using the regular play button, it doesn't run the scene configured in the config, whereas it does when I run using the additional button.

The config runner has two parts: the environment variables and the custom "Run Scene". The environment variables come into effect regardless of which button you use. The [Run Config] log is to notify that the environment variables from a config are applied, not necessary that a scene from the config is used.
The Run Scene, as you said, only comes into effect if you use the additional run button due to the limitations I mentioned. I already clarified this behavior in the readme:

Run Scene: For this to come into effect, you have to run from the custom run button. Using the regular play buttons will use the respective scene of said button

but I understand the confusion because of the [Run Config]. Regardless, I made it like this because my main use case for run configs is the environment variables and I just added the Run Scene as a bonus feature, so I didn't see an issue when it doesn't always line up with the logged output.
That being said, I don't have much of an option here. Either:

I remove the Run Scene feature to reduce confusion.
I modify the log message to clarify that environment variables are applied, but not necessarily the run scene.

Both of which don't do much IMO. If you want option 2, then you are free to modify this line here:
https://github.com/poohcom1/godot-run-configs/blob/b74c9cc82b1894426731d566f666818bf98ffefd/addons/run-configs/run-config-manager.gd#L26-L28

I think being able to run a different scene with the click of a button is a core feature of this addon so I hope you won't remove it. And I think modifying the log message to state that the environment variables were applied does clarify it a little. I've personally changed the print message to:
print("Applied environment variables for '%s' configuration." % config.name)

I'll update the main message and add a warning like this:

It appears when using Custom Scene mode and you ran from a different scene since this is the only kind of scene where you can detect a mismatch, and it's probably the main use case for Run Scene anyway.
I'm also considering just removing the Main Scene and Current Scene options and just leaving Custom Scene from the config options since you can already do that with the native buttons. I think this could help make the intention of the button more clear, but I'm not sure. Let me know if you think that's a good idea.

Yeah, that's already way better. I'm personally not a fan of the colored output as it 1. hints at the logs being warnings, and 2. really pulls your attention to it which I don't think is really necessary here. Regarding the Main Scene and Current Scene options: I think you're right but I would even suggest to go further than that: to make the custom scene a mandatory field for each environment. That way the button in the play bar doesn't have to ever be disabled and the functionality and your new warnings make it clear what's happening.


Maybe there is one problem in implementing the class PrioritizedReplayBuffer

In the file https://github.com/hill-a/stable-baselines/blob/master/stable_baselines/common/buffers.py,
(line 206) total = self._it_sum.sum(0, len(self._storage) - 1)
Use the above code to compute the total priorities and set param end of function self._it_sum.sum to len(self._storage) - 1.
But in the file https://github.com/hill-a/stable-baselines/blob/master/stable_baselines/common/segment_tree.py,
(line 75) end -= 1 which is called by the function self._it_sum.sum also subtract by 1.
Has it been repeatedly subtracted by 1?
from stable_baselines.common.buffers import PrioritizedReplayBuffer buffer = PrioritizedReplayBuffer(100, 0.6) x = np.array([1.]) for _ in range(10):     buffer.add(x, x, x, x, x) print(buffer._it_sum.sum(0, len(buffer._storage-1)))#result:9.0 print(buffer._it_sum.sum(0, len(buffer._storage)))#result:10.0
If changing len(buffer._storage-1) to len(buffer._storage-1), I can get the correct result.
If I misunderstood the code, please let me know.

I do not quite understand what is the issue. Could you reformat your example code with triple-ticks (``` like this ```)? Also the suggested change is the same.

I do not quite understand what is the issue. Could you reformat your example code with triple-ticks (like this)? Also the suggested change is the same.

Sorry for that. I have modified my question.

Thank you! Now I see the issue. Yes, I think there is one extra end -= 1, and because of it the last added item is not included in the sampling. This can be tested with
from stable_baselines.common.buffers import PrioritizedReplayBuffer
buffer = PrioritizedReplayBuffer(100, 0.6)
x = np.array([1.])
for i in range(10):
    x = np.array([i])
    buffer.add(x, x, x, x, x)
print(buffer.sample(10, beta=0.5))
print(buffer.sample(10, beta=0.5))
... # You will never see state "9" in sampled experiences (state nor next state)

A PR to fix this would be welcomed :). I am not sure where the extra "-1" should be fixed exactly given the documentation of the functions. Also an update to tests for this change would be nice.

By the way, the codes for calculating weights in the function sample of the class PrioritizedReplayBuffer   can be simplified.
change
p_min = self._it_min.min() / self._it_sum.sum()
max_weight = (p_min * len(self._storage)) ** (-beta)
p_sample = self._it_sum[idxes] / self._it_sum.sum()
weights = (p_sample * len(self._storage)) ** (-beta) / max_weight

to
weights2 = (self._it_sum[idxes] / self._it_min.min()) ** (-beta)

This can be derived by simple mathematical derivation.
I also did some experiments to verify this with the following code.
from stable_baselines.common.buffers import PrioritizedReplayBuffer

buffer = PrioritizedReplayBuffer(100, 0.6)
x = np.array([1.])
for i in range(10):
    x = np.array([i])
    buffer.add(x, x, x, x, x)
#update priorities [0.05 0.1  0.15 0.2  0.25 0.3  0.35 0.4  0.45 0.5 ]
buffer.update_priorities(np.arange(10), np.linspace(0.05, 0.5, 10))
data = buffer.sample(10, beta=0.5)
weights1 = data[-2]
idxes = data[-1]
weights2 = (buffer._it_sum[idxes] / buffer._it_min.min()) ** (-0.5)
print(weights1 - weights2)

The result is all 0.
The original codes are more like the formula of the paper, but the simplified codes I think are much faster.

Nice catch! It indeed checks out. I do not know how much faster it would be (the bottleneck is in the segment tree summing), but it is more compact and also easier to understand by just looking at the computation.
Feel free to make a PR that includes these two changes :)

Thank you! Now I see the issue. Yes, I think there is one extra end -= 1, and because of it the last added item is not included in the sampling. This can be tested with
from stable_baselines.common.buffers import PrioritizedReplayBuffer
buffer = PrioritizedReplayBuffer(100, 0.6)
x = np.array([1.])
for i in range(10):
    x = np.array([i])
    buffer.add(x, x, x, x, x)
print(buffer.sample(10, beta=0.5))
print(buffer.sample(10, beta=0.5))
... # You will never see state "9" in sampled experiences (state nor next state)

A PR to fix this would be welcomed :). I am not sure where the extra "-1" should be fixed exactly given the documentation of the functions. Also an update to tests for this change would be nice.

I agree with you. This change is just a little trick. and maybe cause little impact. I would make a PR later. Thank you.

Hello, does this mean that Prioritized Experience Replay in DQN isn't working in Stable Baselines ?

@Jogima-cyber
Dare I say most of it is working, except the last added sample is not included in the random sampling process. Given the number of samples in buffer this is seems like a minuscule error (which still should be fixed!), but I can not say for sure if the effect on learning is small.

@Jogima-cyber
Dare I say most of it is working, except the last added sample is not included in the random sampling process. Given the number of samples in buffer this is seems like a minuscule error (which still should be fixed!), but I can not say for sure if the effect on learning is small.
@UPUPGOO
Any update on PR for this? I am asking to check if somebody is working on this and wants to make a PR out of it. If not, I can add it.

Sorry for late replay. I did a PR  but it seemed not pass. You can update this. Thank you.


Why SSR docs are so leak of information?!

I'm trying to add code splitting to my existing SSR react app. but provided information in this link is so limited!
https://www.smooth-code.com/open-source/loadable-components/docs/server-side-rendering/
For example, there isn't any details and descriptions about loadable-stats.json, what is it doing exactly, what is ChunkExtractor, how is it looks like in a "simple" real world example. just some complex codes without any info!

@pouyajabbarisani Because it's enough ! The code that works is just like the docs:
const extractor = new ChunkExtractor({
      statsFile: path.resolve(__dirname, 'loadable-stats.json'),
      entrypoints: ['client'],
    });
const markup = renderToString(
<ChunkExtractorManager extractor={extractor}><App /></ChunkExtractorManager>
);

What is the ChunkExtractor and loadable-stats.json and exactly what they do?!
what is the loadable-stats.json's content?!

I got it. It's Webpack automatically making that.  :)


Improved the banner quality

i have improved the quality of the banner successfully from this to this
old one

new one

@GVishnudhasan could you please add the labels - hacktoberfest-accepted, and the level

@GVishnudhasan could you please increase the level for the effort i put, please


Changing seek auto-play to option

I have a situation where i'd like to seek and have it paused. Adding this as an option to media.py but keeping the default as auto-play.

Ok to merge when linting errors fixed.

This PR seems to have gone stale. Closing it. You can reopen it when you're ready to finish it.


Semi-Hausdorff

This is another example of a property properly between T2 and T1. I'm trying to complete the picture as best I can: we have a nice chain of implications for T2, KC, WT2, US, T1, but, Locally Hausdorff, Semi-Hausdorff, and Retracts are Closed are properties that may or may not fall in line as far as I can tell.

Should this PR be reviewed separately from #420?
In any case, I think the terminology "semi Hausdorff" here is not optimal.  "Semi Hausdorff" has been used in other contexts in the literature, specifically for spaces where distinct points can be separated by disjoint semi-open sets.  The use of that terminology in Banakh's paper is possibly made up for the occasion.  So I have asked about it in a comment to this:
https://mathoverflow.net/a/435864
Let's see what he replies.  It's maybe a similar situation as the term "P-space".  Morita had also introduced the term "P-space" with a completely different meaning, and now P-spaces in the sense of Morita are called "Morita P-spaces" (see Encycl. of General Topology, p. 202).  Similarly, one possibility would be to call the property something like "Banakh semi-Hausdorff" or "(Banakh) semi-Hausdorff"?

Should this PR be reviewed separately from #420?

Yeah - I'm actually working on a preprint related to this PR, and I'm using pi-Base to organize my work as I go. But I didn't want to blow this up too big, so I'm leaving the rest of the work as a draft PR until this is resolved and merged back into #420.

Taras Banakh replied.  The paper https://www.ams.org/journals/proc/2017-145-03/S0002-9939-2016-13318-2/ he mentioned seems very interesting.  See in particular the diagram after Definition 2 on p. 1376 that summarizes many implications between properties.  We should check how much of this is already in pi-base.  This article also seems a better reference for the notion of "semi-Hausdorff".  What do you think?

Alternatively, we just go with "semi-Hausdorff" in the current sense in pi-base for now.  I personally don't care too much about semi-open sets, but if pi-base ever gets to that one, we can revisit and change as necessary.

I need to look into the semi-open characterization. I like that semi-Hausdorff aligns with our existing semiregular property, and we can always do "Semi-Hausdorff (Banakh)" vs "Semi-Hausdorff (name)". or maybe "Semi-Hausdorff (regular)" vs "Semi-Hausdorff (semiopen)"?

This article also seems a better reference for the notion of "semi-Hausdorff". What do you think?

I think so. Moving this back to draft until I've had a chance to review things a bit and make appropriate changes.

I need to look into the semi-open characterization. I like that semi-Hausdorff aligns with our existing semiregular property, and we can always do "Semi-Hausdorff (Banakh)" vs "Semi-Hausdorff (name)". or maybe "Semi-Hausdorff (regular)" vs "Semi-Hausdorff (semiopen)"?

Yeah, or for now we could do "Semi-Hausdorff" by itself with "Semi-Hausdorff (Banakh)" as an alias.

I added the Proc AMS reference as well as the more recent paper. I don't think folks will be searching for the property using "Banakh", so with these references I don't think an alias is necessary today. (And perhaps the co-author should be included as well when/if we do.)

Actually I think spaces/S000184/properties/P000099.md is bogus, due to changes made in the paper to make the space US.
In general this space has a lot going on beyond the immediate need at hand. I still wonder if a simpler counterexample can be found...

For now I've dropped Banakh's space - I could add the existing example that's RC+SemiT2 but not KC, but it's a bit technical and I'm trying to see if I can work out a more elegant (for this purpose) construction that gets RC+SemiT1 but not US.


Missing TOTAL ENERGY, ELECTRONIC ENERGY, and CORE-CORE REPULSION

Short Version: Versions of MOPAC prior to 2022 reported a TOTAL ENERGY, ELECTRONIC ENERGY, and CORE-CORE REPULSION in the output file. These outputs are now suppressed by default, but they are still accessible by using the DISP keyword.
Medium Version: These outputs have been suppressed because they were observed to be a common source of confusion among MOPAC users. MOPAC's semiempirical models are designed to reproduce heats of formation, and their primary energetic output is a predicted heat of formation. The additional outputs of TOTAL ENERGY, ELECTRONIC ENERGY, and CORE-CORE REPULSION represent an arbitrary decomposition of the heat of formation that do not have any independent physical meaning and notably lack any dispersion corrections that have been introduced in recent models. The DISP keyword clearly reports the decomposition of the heat of formation into these terms and a dispersion correction, when applicable. This is in contrast with conventional quantum chemistry calculations that typically report a physically meaningful "total energy" and "total electronic energy".
Long Version: Semiempirical thermochemistry and its implementation in MOPAC have long focused on directly modeling molecular heats of formation, rather than modeling the total energy of a molecule and relying on more expensive vibrational calculations to produce the vibrational and entropic contributions to a predicted heat of formation. This decision was highly beneficial at a time when computational resources were limited, as it enabled a direct connection to available reference data (i.e. experimental heats of formation) for fitting models and avoided the need to perform expensive vibrational calculations in the process of predicting heats of formation, which were of direct interest to experimentalists using MOPAC. The downside of this decision was that a minimal-basis Hartree-Fock model doesn't contain any terms that looked like a non-trivial vibrational contribution (a model limitation) and formal access to a purely electronic energy requires a cumbersome and expensive removal of an explicit vibrational contribution (a computational limitation). In practice, these downsides are not very relevant because the vibrational/entropic contributions that differentiate a heat of formation from a formation energy can be approximated as conformation-independent atomic corrections. This approximation is roughly comparable to the underlying accuracy of MOPAC's models, and it is a sensible, practical way to repurpose MOPAC's outputs as pure energies rather than heats (e.g. if MOPAC is used to drive molecular dynamics). As the accuracy of semiempirical models continues to improve, it will eventually be important to be more mindful and careful about the distinction between modeling formation energies and heats of formation.

Hi,
thanks for explaining this change clearly. One side-effect is that it causes a few issues when using a recent Conda build with the ASE MOPAC interface https://wiki.fysik.dtu.dk/ase/ase/calculators/mopac.html#module-ase.calculators.mopac

The TOTAL ENERGY value was used as the calculated potential energy value for the purposes of ASE optimisers etc. So now a default (actually 1SCF GRADIENTS) calculation returns forces but no potential energy. This is surprising to e.g. optimisers and dynamics routines that expect to track the energy.
Adding the DISP keyword restores this energy, but a new occurrence of 'FINAL HEAT OF FORMATION' trips up the text parser. We can fix that easily enough with a more specific regex.
I note that MOPAC doesn't seem to mind if DISP is specified more than once, so the simplest approach from ASE's end may be to always append DISP to the keyword set.

So it looks like the ASE parser can be updated in a backward-compatible way. But I would like to ask if it seems reasonable from MOPAC's perspective for ASE to keep using the TOTAL ENERGY value. This will be used within optimisers, dynamics routines etc. Would you recommend, for example, that the dispersion energy is added to the total for this purpose? Is it likely to make any practicaly difference if we simply switch to using the FINAL HEAT OF FORMATION as the reported "potential energy"?


[FEATURE-REQUEST] custom html tag for show/edit page

Describe the problem you're proposing to solve
Since the show and edit are on the same page it would be good to be able to put custom HTML tags that aren't submitted as well. For example, there is no easy way to display a big image on the show/edit page. I know that this can be done via custom Ecto type but in my case, I already have a custom Ecto type from my upload lib (Arc/Waffle). Also, I'm not a fan of adding an admin logic code to the application code.
Describe the solution you'd like
be able to add custom html tags to show/edit form so something like:
  def form_fields(_) do
    [
      status: %{choices: [{"Valid", "valid"}, {"New", "new"}, {"Invalid", "invalid"}]},
      id_card_front: %{name: "ID Front", type: :safe_html, value: fn v -> "<img src='#{v.url}'" end }

    ]
  end

Describe alternatives you've considered
I was considering going with a custom page for the moment.
Additional context
Add any other context or screenshots about the feature request here.
I can try to implement it but first, I need to know whether this kind of approach is ok with you guys. Or maybe you know some other alternatives that don't require a custom Ecto type since.
Cheers
Piotr

I've been playing around and basically, something like that would do the trick :
https://github.com/aesmail/kaffy/compare/master...sulphur:master

Hey @sulphur
Thanks for opening this issue.
I do see the need for this. However, I feel like it needs to be discussed a bit more to come up with a well-designed solution.
Currently, we have the "custom types" solution which does work for your case (as can be seen here and here). Admittedly, it's more involved by design and your solution is much simpler for simpler cases.
Your changes seem good and working, but it needs to be a bit more "integrated" and polished.
I believe if we're adding a :safe_html type, we should make it universal and maybe use it internally to build the other fields.
Something like:
def build_text_field(), do: something() |> build_safe_html()
def build_image_field(), do: logic() |> build_safe_html()
def build_safe_html(), do: {:safe, some_html}

This way, in the future, if we want to add more fields, it would have a standard way of doing it.
I like this feature, but let's explore a few more implementations so we can decide on how to proceed.

Yeah, I totally agree my "example" was just to illustrate the need ;) the real solution should be something more elaborate ;) like the one you suggest. I had the same idea about having a generic function that is used by specific functions that facilitate the display.

I have a very similar need... I'd like to customize a form field with a custom input, but I'm also already using a custom type and don't like to mix application code with web (admin).
So maybe the form_fields could accept something like
def form_fields(_) do
    [
      id_card_front: %{name: "ID Front", type: CustomType }
    ]
  end

and this custom type must have the function def render_form(conn, changeset, form, field, options) similar to the approach that you already have, but a bit more flexible since doesn't need to be an ecto type.

Hi,
@aesmail I've created a image_preview type and rename safe_html to custom_html i haven't combined

I've created a PR here : https://github.com/aesmail/kaffy/pull/161

@jotaviobiondo I agree. It does make sense to provide type with a module which handles how the field is rendered. I think this will be the case for the next release.


VSCode might get string comments

Hi there!
Just wanted to bump you with this: https://github.com/microsoft/vscode/issues/95408
Been trying to figure out why VSCode does not show string TSDocs. Basically if this get fixed the classnames in this project can get proper documentation, allowing you to show what css the classnames produce, with links to their documentation etc. Would be an awesome addition 😄

That would be very cool. Thanks!


Update sendMessageCompletion to handle BLEManagerError with human-readable message

Update sendMessageCompletion to handle BLEManagerError.noData case with human-readable message

For example current method returns: "The operation couldn’t be completed. (SwiftOBD2.BLEManagerError error 5.)" for "No DATA" whilst running "DTC". It's not user friendly.

that makes sense thanks


add releases

Signed-off-by: Jim Bugwadia<EMAIL_ADDRESS>Added release versions and moved GitHub to footer. Also added line breaks to fix "About Kyverno" rendering.

main.kyverno.io is a broken link when accessing release v1.4.1

fixed


Text import failed

Imported old text
The number of rows is different

@xjgames
This may be due to the fact that you exported the text in version 2.3, but are importing it in 2.5


make chart data generic and mutable

chart data is now generic instead of using the awkward std::any::Any
data must be specified on instantiation and remain the same type throughout (don't see much use case for changing type)
if you don't want to have any data use () as shown in the 3d chart example
data can be mutated via set_data which takes a callback similar to egui's ui.input()
cleaned up some code with clippy suggestions
examples and docs have been updated :)
thank you for the wonderful crate!

Sorry for not noticing this earlier, not sure why I didn't just do this. I'll take a look at it after I get some coffee. Changes made in the new version should be easy to implement.

I made the following minor changes:

Changed .data to .get_data so it doesn't conflict with the current function naming scheme, where a function without a prefix like get_ or set_ is often a setter that consumes itself.
Added a return type to .set_data to allow more flexability and be more similar to the egui data set methods.
Changed the callback to an FnOnce since it will only be called once.
Fixed examples in lib.rs and README.md
I really appreciate the time you took to contribute! Anything else you can suggest? Any changes you don't like?

Also just adapted the code to 0.3.0, went pretty smoothly

Just realised there probably isn't much point to use a callback for set_data - might as well just give a mutable reference but apart from that I really appreciate the merge ❤

Oh wait there's also another thing I guess probably restrict builtin chart types to a feature since a lot of the time people won't use them - also std::time::Instant doesn't compile on wasm afaik

I'll decide on what is most efficient with the .set_data funciton. Callback provides a nice isolated scope for you to modify the data but it's kinda unusual and perhaps overly complicated.
Eh, perhaps, I think they're useful if I'm honest but on the following point it probably wouldn't be a bad idea.
I don't really use wasm at all so I completely overlooked no_std. Not sure how well it works I should probably make an example.
Arcs are just faster to clone and work with, so long as the data doesn't need to mutate. Video explaining why here.

I'll decide everything tomorrow I need to wake up in 8 hours and go to work though so not the best time to fix this lol

Gotcha thx for answering

* you should probably put the builtin chart types behind a feature since most people won't use them

* std::time::Instant doesn't exist on wasm so the timechart stuff won't work there (the above would avoid this problem but wouldn't allow any future builtins or you could put the type in the example or you could use the instant crate but you don't really want another dependency so I think probably just put in the example)

I'm not quite sure how I'm going to get it working with wasm yet, apparently plotter supports it but it also requires backends to implement the Error trait, which is in the standard library only. I'll have to look at it when I have more time; I'm currently on lunch break, I'm a little confused.

Wasm isn't no std it just doesn't have the time and fs modules due to platform agnostics

Also you uncapitalised some of the code in the readme :p

Also you uncapitalised some of the code in the readme :p

I know there is a typo in the commit but it is fixed. Melatonin kicking in and I wanted to knock this out of the way lol
It's kinda embarrassing how many times I try to yank a block in vim and accidentally hit 'u'. And even more embarrassing in that I don't even notice it most of the time until I get compile errors.
I'll work on making charts a separate feature in another branch, I think this code achieves the goal it was set for though and I'll go ahead and merge it. Thanks again!

Thanks!