Disable firewall checks if Little Snitch or Netbarrier are installed

They're a replacement for macOS' firewall, so it stands to reason that the firewall would be disabled.
I couldn't spot a way to set some sort of global flag in the hjson, and then not run certain tests if a flag is / isn't set - is that something that should be done elsewhere?

They're a replacement for macOS' firewall, so it stands to reason that the firewall would be disabled.

Excellent idea. I don't have Little Snitch or Netbarrier installed on a test machine; do you know what commands can be used to check whether they are installed?

I couldn't spot a way to set some sort of global flag in the hjson, and then not run certain tests if a flag is / isn't set - is that something that should be done elsewhere?

That's a neat idea. In general, there is an awful lot of copied/pasted code with small changes in the Hjson currently.
One way to do this would be to turn a lot of this reusable code into bash functions that take arguments, and which always get prepended to commands. This would provide a little API that config checks can call and make the test expressions relatively brief and simple.

Excellent idea. I don't have Little Snitch or Netbarrier installed on a test machine; do you know what commands can be used to check whether they are installed?

I have machines with both, I'll check Netbarrier tomorrow but for Little Snitch it's just a matter of checking to see whether the Little Snitch Daemon process is running. So pgrep "Little Snitch Daemon" would work, it'll either return the PID or it'll return nothing (if it's not running).

One way to do this would be to turn a lot of this reusable code into bash functions that take arguments, and which always get prepended to commands. This would provide a little API that config checks can call and make the test expressions relatively brief and simple.

This should probably be broken out into a new issue, but I agree, that seems to make a lot of sense.

@fluffypony as for your suggestion about an API and keeping commands conditional, these will be satisfied by issues https://github.com/kristovatlas/osx-config-check/issues/85 and https://github.com/kristovatlas/osx-config-check/issues/107

@kristovatlas awesome, great job:)

This is partially satisfied by https://github.com/kristovatlas/osx-config-check/issues/77
@fluffypony if you want to look into NetBarrier I'd find that help. In the meantime, I consider this sufficiently satisfied for the next milestone.


Code Review

Review against requirements
Confirm:
Data Access and Processing

[x] function should turn variables into factors with appropriate levels
[x] Make the API request and handle errors
[x]  Parse the API response and convert to tibble
[x] Return the processed data
[x] valid date values between 2010 - 2022
[x] Ensure the function allows the user to specify the year of the survey (default: 2022)
[x] one numeric variable other than PWGTP must be returned (?in addition to?)
[x] Check returned variables (Defaults: [PWGTP=ALWAYS,AGEP=OPTIONAL,USER_PROVIDED={user specified list}]
list includes: AGEP, GASP, GRPIP, JWAP (time), JWDP (time), and JWMNP)
[x] one categorical variable must be returned
[x] Allow the user to specify categorical variables to be returned (default: SEX).
[x] Convert specified numeric variables into appropriate numeric or time values
[x] Convert specified categorical variables into factors with appropriate levels
[x] Validate that the specified variables are within the allowed set returned
[x] Allow the user to specify the geography level (All, Region, Division, or State; default: All)
[x] Validate that the specified geography level is one of the allowed values
[x] Include an optional argument to subset the data based on specified Regions, Divisions, or States.
[x] Ensure subsetting is done on the API call itself.

Muiti-Year Function

[x] date range should span multiple years of survey data and all other options specified n Project 1 document
[x]  This function should call your single year function as many times as needed and then combine the data into one final tibble (a year variable should be included in this final tibble)
[x] Add a custom class to the tibble for summarizing purposes #5

Summary Function tasks:

[x] means
[x] standard deviations for numeric variables
[x] counts for categorical variables
[x] Ensure the document is well-structured and provides a clear explanation of the thought process and function usage
[x] Submit the link to the rendered webpage for grading
[x] Develop a narrative throughout the document, including an introduction, discussion of methods, and examples

Plot Function

[x] generic plot for a census class tibble that plots one categorical and one numeric

Markdown Narrative

[x] Describe process for creating and testing functions
[x] Section for investigatino something "interesting" (e.g. Do the differences between JWAP and JDAP equal JWMNT?)

Done


Auto Renew

Set UPass to automatically renew.
Renewal can be done:

On a set day of the month
When the next month is available (either by checking to see if its available, or using Translink's sms notification)

I am working on a feature that enables the user to setup a reminder in the app for each month. The notification then enables the user to update his UPass via the app.

Check out the notifications branch, we've done a little bit of work to get this started that you can build off of.

Will do that


ClassHolderTransformer does not receive LocalDate

Hi,
first of all congratulations for your work. I have been working for several years with gwt and I am impressed by your project.
I am using teavm to transpile my ui code to javascript by I have a problem with LocalDate.
I have seen your explanation at JSR 310? #56 and I understand it.
I have written a ClassHolderTransformer to deal with LocalDate but it does not work. In fact, my ClassHolderTransformer is not being asked to transform LocalDate, though I see it is being asked to transform any other class that I use.
This is my code:
``
package io.mateu.ui.teavm.plugin;
import org.teavm.diagnostics.Diagnostics;
import org.teavm.model.*;
import org.teavm.model.util.ModelUtils;
import java.time.LocalDate;
import java.time.LocalDateTime;
/**

Created by miguel on 15/8/17.
*/
public class MateuTransformer implements ClassHolderTransformer {
public MateuTransformer() {
}
public void transformClass(ClassHolder cls, ClassReaderSource innerSource, Diagnostics diagnostics) {
 System.out.println("revisando " + cls.getName() + "");

 if (cls.getName().equals(LocalDate.class.getName())) {
     substitute(cls, innerSource, SimpleLocalDate.class);
 } else if (cls.getName().equals(LocalDateTime.class.getName())) {
     substitute(cls, innerSource, SimpleLocalDateTime.class);
 } else return;

}
private void substitute(ClassHolder cls, ClassReaderSource classSource, Class clase) {
System.out.println("sustituyendo " + cls.getName() + " por " + clase.getName());
 ClassReader subst = classSource.get(clase.getName());

 // vacia la clase (campos y metodos)
 for (FieldHolder field : cls.getFields().toArray(new FieldHolder[0])) {
     cls.removeField(field);
 }
 for (MethodHolder method : cls.getMethods().toArray(new MethodHolder[0])) {
     cls.removeMethod(method);
 }

 // copia el contenido (campos y metodos) de la clase sustituta
 for (FieldReader field : subst.getFields()) {
     cls.addField(ModelUtils.copyField(field));
 }
 for (MethodReader method : subst.getMethods()) {
     cls.addMethod(ModelUtils.copyMethod(method));
 }

}
}
``

And this is the output:
[INFO] Building JavaScript file
revisando io.mateu.ui.Port
revisando java.lang.Object
revisando java.lang.Class
revisando java.lang.reflect.AnnotatedElement
revisando java.lang.String
revisando java.io.Serializable
revisando java.lang.Comparable
revisando java.lang.CharSequence
revisando java.lang.Thread
...
revisando java.util.regex.UnicodeCategory
revisando java.util.regex.UnicodeCategoryScope
revisando java.util.regex.IntArrHash
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11.315 s
[INFO] Finished at: 2017-08-15T20:46:09+02:00
[INFO] Final Memory: 33M/598M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.teavm:teavm-maven-plugin:0.5.1:compile (web-client) on project sample-app-core: Unexpected error occured: Error rendering class io.mateu.ui.sample.client.TestDate. See a cause for details: Can't provide name for method as it was not found: java.time.LocalDate.now()Ljava/time/LocalDate; -> [Help 1]
[ERROR]
So it seems my classhotldertransformer is being called for any class but for LocalDates :(
Can you please give me any clue of what I am doing wrong? Is there any other way to use LocalDate with teavm?
Thanks and best regards,
Miguel

You should not do this way. See how TeaVM port of JDK is built. Please, look at classlib module. You should follow the same pattern, if you want to add some classes to java.* package.

Hi Alexey,
thanks a lot for your quick response.
So, should I fork the classlib module and add a org.teavm.classlib.java.time.TLocalDate class?
I have not been able to find where are org.teavm.classlib.xxx classes read from, so I'm not sure if it is enough to add the class. I see the teavm.properties file with content
packagePrefix.java=org.teavm.classlib classPrefix.java=T
but I have not seen any reference to this file.
Also, it seems the classlib project is mainly adding the org.teavm.classlib.impl.JCLPlugin.
In order to leave the classlib dependency as is, would it be possible to add the org.teavm.classlib.java.time.TLocalDate in another artifact, as an independent maven dependency?
Thanks,
Miguel

You can add a separate jar file to classpath which contains classes in org.teavm.classlib package and this should work as expected. Another way is to add custom teavm.properties with corresponding prefixes.

Ok. Perfect.
I will try.
Thanks a lot, Alexey
2017-08-22 10:37 GMT+02:00 Alexey Andreev<EMAIL_ADDRESS>
You can add a separate jar file to classpath which contains classes in
org.teavm.classlib package and this should work as expected. Another way
is to add custom teavm.properties with corresponding prefixes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/konsoletyper/teavm/issues/297#issuecomment-323958754,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATum0cVAs_UgWkK3VrSkiczqqvjMPWc1ks5sapNhgaJpZM4O39zn
.


Same functionality as rewrite branch of Docile.jl?

I am currently using the rewrite branch of Docile.jl for documentation generation of Hecke and I am very happy with it (thanks). Will Lapidary.jl have the same functionality (or maybe it does already)? In particular I make heavy use of the ability to "dispatch" doc strings. I never dump all docstrings associated to a function at one place of the documentation. Instead I use @(function1(::argument1)) at one place and @(function1(::argument2)) at another place. Will this feature be available in Lapidary?

Will Lapidary.jl have the same functionality

Yes. That's the plan. Most basic parts are already done, though will need some polish before general release once I've got some time.

I never dump all docstrings associated to a function at one place of the documentation. Instead I use @(function1(::argument1)) at one place and @(function1(::argument2)) at another place. Will this feature be available in Lapidary?

Yes, you should be able to get the same result using something like
...

    {docs}
    function1(::argument1)

...

    {docs}
    function1(::argument2)

...

{docs} blocks can contain more than one function/type, so you can do
...

    {docs}
    function1(::argument1)
    function1(::argument2)

...

to avoid having dozens of {docs} blocks.
Also, @module{Hecke} syntax is replaced by
...

    {meta}
    CurrentModule = Hecke

...

Doesn't look as though Hecke uses any other features currently, so that should cover everything. If there's anything else unclear in the readme just give me a shout.

Awesome! Thanks a lot!


Add rosbag2 qos override documentation

rosbag2 added a new feature for Foxy where users can specify QoS policy overrides from the CLI to record/playback topics offering different QoS policies.
This adds documentation on how to use the feature.
Part of ros2/rosbag2#125 and ros2/rosbag2#357.
Part of ros-tooling/aws-roadmap#244.
Signed-off-by: Anas Abou Allaban<EMAIL_ADDRESS>

@maryaB-osr Could I get a review on this please?
Let me know whether I need to move things around.

It looks like your Tutorials.rst page is out of date. The sections are organized a bit differently now: https://index.ros.org/doc/ros2/Tutorials/
So there is actually an intermediate section you can put this tutorial in


Tips for next release?

Thx for the excellent work!! Being looking forwards to the next release, would like to know a little bit about the time point... i see extra nice features merged into master already...
Regards!

I think the next release will be after this issue https://github.com/STRML/react-grid-layout/issues/1004 will be fixed. I'm working on it

I think the next release will be after this issue #1004 will be fixed. I'm working on it

Thx a lot, seem "tons" of people waiting for the draging feature from outside to be shipped, lol

looking forward to publishing

The new version has been released!
https://github.com/STRML/react-grid-layout/releases/tag/0.17.0


@ at the end of the program causes an error

Thanks to StackExchange user DLosc for pointing this one out.
If the program ends in a @ the interpreter will throw a invalid character error.

Fixed with 8254a44364b430c39a6b542de2c38ff6997c8058.


bcm2835-bootfiles: use the latest firmware to support booting the rpi2 1.2

This is still being tested.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Please port this on master too @michal-mazurek

connect https://github.com/resin-os/meta-resin/issues/519


Bug Fixes

Coverage increased (+0.05%) to 83.571% when pulling 2f2a810337da1590e69c443e5068b590693155aa on gabrielburnworth:staging into 9ebdd399dd85c6ffa7ad7b00e934b987a8065906 on FarmBot:staging.


Two New Datasets

As we move forward with testing out new functionality on this package, I am adding two new datasets that relate to one another and can be used to test joins potentially.

I'll merge this in with the others once they've all been approved and I've synced with @dbeatty10 on semvar.

Not useful not that we're testing with pytest in #65


Adding chart for SignalFx agent

This is a new chart for our Kubernetes metric agent.  Our company is a new member of the CNCF, which I believe means we signed the Contributor agreement.

Thanks for the PR. Please make sure you read and understand our guidelines. You should base your chart on the initial setup you get with helm create using Helm 2.8+.

Hi, please get your CLA signed, and then we'll ok this for testing.  Thanks!

Ok, I'm working with my company's CNCF point person to link up my email to our corporate CLA signature so that I can sign this as an employee.

Ok, I should be good to go with the CLA.

/assign

@unguiculus I made all of the changes you requested except for the one that I had a question on above.  What do you suggest about that?

/ok-to-test
this lgtm, @unguiculus can you give it another quick look to see if your comments were addressed?

Ok, I did the first option since we don't have any kind of default values for the access token.  Thanks.

@keitwb great, thanks!
/lgtm


Unable to rebuild the ARM_CL and follow the instruction to reproduce the result

Output of 'strings libarm_compute.so | grep arm_compute_version':
arm_compute_version=v21.02 Build options: {'Werror': '0', 'debug': '1', 'asserts': '0', 'neon': '1', 'opencl': '1', 'os': 'linux', 'arch': 'arm64-v8a'} Git hash=b'5682f000a9e6682be0cf3d2ef5289851cd933433'
Platform:
Hikey970
Operating System:
Linux

Problem description:
Hello Ehsan. First of all, Thanks for open source this great project.
I try to replicate your result. I download your project by the following command. (I guess the README should be updated )
git clone https://github.com/Ehsan-aghapour/ARMCL-pipe-all/ But Here are some problems I faced:

I used scons Werror=0 -j16 debug=0 asserts=0 neon=1 opencl=1 os=linux arch=arm64-v8a to build the ARM-CL. However, it shows the following warnings and errors:

aarch64-linux-gnu-g++: internal compiler error: Killed (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-6/README.Bugs> for instructions.
scons: *** [build/src/graph/backends/NEON/NEFunctionFactory.os] Error 4
aarch64-linux-gnu-g++: internal compiler error: Killed (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-6/README.Bugs> for instructions.
scons: *** [build/src/graph/backends/CL/CLFunctionsFactory.os] Error 4
examples/graph_mobilenet_all_pipe_sync.cpp: In constructor ‘GraphMobilenetExample::GraphMobilenetExample()’:
examples/graph_mobilenet_all_pipe_sync.cpp:67:5: warning: ‘GraphMobilenetExample::input_descriptor2’ should be

I tried following the "Running in Linux part" : cp /system/lib64/egl/libGLES_mali.so $lib_dir/libOpenCL.so
But May I ask when Can I find the libOpenCL.so?

3.I tried to use the following  command to test
./build/examples/graph_alexnet_all_pipe_sync --threads=4 --threads2=2 --total_cores=6 --partition_point=3 --partition_point2=5 --order=G-L-B --n=60
but it shows these errors, I guess maybe this is due to unsuccessful building.
./build/examples/graph_alexnet_all_pipe_sync: symbol lookup error: /home/Micro_SD_shunya/hungyang/ARMCL-pipe-all/library/libarm_compute_graph.so: undefined symbol: _ZN11arm_compute7logging14LoggerRegistry3getEv

Also, I follow and use the following "Running in Linux part"

but it turns out with the following messages:
WARNING: Skipping invalid option 'Neon'!
WARNING: Skipping invalid option '/home/Micro_SD_shunya/hungyang/ARMCL-pipe-all/alexnet/'!
WARNING: Skipping invalid option '/home/Micro_SD_shunya/hungyang/ARMCL-pipe-all/alexnet//go_kart.ppm'!
WARNING: Skipping invalid option '/home/Micro_SD_shunya/hungyang/ARMCL-pipe-all/alexnet//labels.txt'!
Thanks again :)

Sorry for the late response. We were re-booting our Hikey 970 so I cannot test it in time.
After trying build-up you suggest (scons Werror=1 -j8 debug=0 neon=1 opencl=0 os=linux arch=arm64-v8a build=native), I got the following error:
utils/GraphUtils.cpp: In constructor 'arm_compute::graph_utils::ReceiverAccessor::ReceiverAccessor(bool, unsigned int)':
utils/GraphUtils.cpp:212:60: error: unused parameter 'maximum' [-Werror=unused-parameter]
ReceiverAccessor::ReceiverAccessor(bool tran, unsigned int maximum)
^~~~~~~
utils/GraphUtils.cpp: In constructor 'arm_compute::graph_utils::ReceiverAccessor2::ReceiverAccessor2(bool, unsigned ``int)':
utils/GraphUtils.cpp:219:62: error: unused parameter 'maximum' [-Werror=unused-parameter]
 ReceiverAccessor2::ReceiverAccessor2(bool tran, unsigned int maximum)
^~~~~~~

I guess I will try to look again at how ARM-CL GitHub suggests us to build and see if it works.
Thanks in advance :)

Hi,
No problem.
It is a warning that considered it as error. Set werror, debug, asserts
flags to 0.
Best,
Ehsan
On Tue, Aug 31, 2021, 4:38 PM Hung-Yang Chang @.***>
wrote:

Sorry for the late response. We were re-booting our Hikey 970 so I cannot
test it in time.
After trying build-up you suggest (scons Werror=1 -j8 debug=0 neon=1
opencl=0 os=linux arch=arm64-v8a build=native), I got the following error:
utils/GraphUtils.cpp: In constructor
'arm_compute::graph_utils::ReceiverAccessor::ReceiverAccessor(bool,
unsigned int)':
utils/GraphUtils.cpp:212:60: error: unused parameter 'maximum'
[-Werror=unused-parameter]
ReceiverAccessor::ReceiverAccessor(bool tran, unsigned int maximum)
^~~~~~~
utils/GraphUtils.cpp: In constructor
'arm_compute::graph_utils::ReceiverAccessor2::ReceiverAccessor2(bool,
unsigned ``int)':
utils/GraphUtils.cpp:219:62: error: unused parameter 'maximum'
[-Werror=unused-parameter]
ReceiverAccessor2::ReceiverAccessor2(bool tran, unsigned int maximum)
^~~~~~~
[image: image]
https://user-images.githubusercontent.com/70759685/131522479-51115dd1-d8e0-447c-b527-e6edd9bf6136.png
[image: image]
https://user-images.githubusercontent.com/70759685/131522545-7eb3205f-ff09-48fc-8496-20c9bcfa7dc6.png
I guess I will try to look again at how ARM-CL GitHub suggests us to build
and see if it works.
Thanks in advance :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Ehsan-aghapour/ARMCL-pipe-all/issues/1#issuecomment-909298900,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALPQ3E4X2FAMYOQH5QCTKTTT7TSNTANCNFSM5C4SW6MA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

@Ehsan-aghapour
Thanks for your instant reply,
I was able to use  scons Werror=0 -j4 debug=0 asserts=0 neon=1 opencl=0 os=linux arch=arm64-v8a build=native
to build the environment on HiKey 970.
After export lib, I was able to ./build/examples/graph_alexnet_all_pipe_sync --threads=4 --threads2=2 --total_cores=6 --partition_point=3 --partition_point2=5 --order=G-L-B --n=60 to benchmark.
The result shows as follow:
./build/examples/graph_alexnet_all_pipe_sync
Threads : 4
Small Cores Threads : 2
Target : CL
Data type : F32
Data layout : NHWC
Tuner enabled? : false
Cache enabled? : false
Tuner mode : Normal
Tuner file :
MLGO file :
Fast math enabled? : false
Image file :
Labels file : transfer
Partition point is : 3
Second partition point is : 5
Order is : G-L-B
Total number of cores is : 6
Run network for 60 times.
First partition point:3
Second partition point:5
Total parts:8
start running third graph ...
start running first graph ...
start running second graph ...
Running Inference ...
stage1_input_time: 0.00264753 ms
stage1_inference_time: 96.5089 ms
stage1_total_time: 96.5115 ms
stage2_input_time: 107.626 ms
stage2_inference_time: 22.1759 ms
stage2_total_time: 129.802 ms
stage3_input_time: 71.0915 ms
stage3_inference_time: 58.6052 ms
stage3_total_time: 129.697 ms

Frame rate is: 7.70404 FPS
Frame latency is: 356.01 ms

Test passed
Thanks for the help.

However, I was still unable to solve problem 4 in the original question:
I follow and use the following "Running in Linux part"

but it turns out with the following messages:
WARNING: Skipping invalid option 'Neon'!
WARNING: Skipping invalid option '/home/Micro_SD_shunya/hungyang/ARMCL-pipe-all/alexnet/'!
WARNING: Skipping invalid option '/home/Micro_SD_shunya/hungyang/ARMCL-pipe-all/alexnet//go_kart.ppm'!
WARNING: Skipping invalid option '/home/Micro_SD_shunya/hungyang/ARMCL-pipe-all/alexnet//labels.txt'!
Thanks again :)

Hi,
Sorry for the late reply. I missed your message.
Would you please let me know the exact command that you use for running?
Best regards,
Ehsan
On Fri, Sep 10, 2021, 7:14 AM Hung-Yang Chang @.***>
wrote:

Closed #1 https://github.com/Ehsan-aghapour/ARMCL-pipe-all/issues/1.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Ehsan-aghapour/ARMCL-pipe-all/issues/1#event-5282067234,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALPQ3E6RSVXHJCALHPXJBK3UBFWJJANCNFSM5C4SW6MA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Hi @Ehsan-aghapour
No worries, I was able to reproduce part of your work on my own end.
I will re-open the issue or open a new issue if I have any questions.
Thanks for your help :)

Great. You're welcome.
Best,
Ehsan
On Fri, Sep 10, 2021, 9:09 AM Hung-Yang Chang @.***>
wrote:

Hi @Ehsan-aghapour https://github.com/Ehsan-aghapour
No worries, I was able to reproduce part of your work on my own end.
I will re-open the issue or open a new issue if I have any questions.
Thanks for your help :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Ehsan-aghapour/ARMCL-pipe-all/issues/1#issuecomment-916625581,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALPQ3E72AH7NEXOL4KQJCFDUBGDX3ANCNFSM5C4SW6MA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


[ENH] Deconcat columns enh #478

PR Description
This PR adds a boolean kwarg preserve_position to pyjanitor function deconcatenate_column. The default is set to False to avoid introducing breaking changes.
When preserve_position=True
df.columns change from [... id ...] into [... col1, col2, ...]
When preserve_position=False (default)
df.columns change from [... id ...] into [... id ... col1, col2]

This PR resolves #478.

PR Checklist

Please ensure that you have done the following:

[x] PR in from a fork off your branch. Do not PR from <your_username>:master, but rather from <your_username>:<branch_name>.

[x] If you're not on the contributors list, add yourself to AUTHORS.rst.

Quick Check
To do a very quick check that everything is correct, follow these steps below:

[x] Run the command make check from pyjanitor's top-level directory. This will automatically run:

black formatting
pycodestyle checking
running the test suite
docs build

Once done, please check off the check-box above.
If make check does not work for you, you can execute the commands listed in the Makefile individually.
Code Changes

If you are adding code changes, please ensure the following:

[x] Ensure that you have added tests.
[x] Run all tests ($ pytest .) locally on your machine.

[x] Check to ensure that test coverage covers the lines of code that you have added.
[x] Ensure that all tests pass.

Documentation Changes

If you are adding documentation changes, please ensure the following:

[x] Build the docs locally.
[x] View the docs to check that it renders correctly.

Relevant Reviewers

Please tag maintainers to review.

@ericmjl

Oh wow, my apologies--yet to find my way in testing and not yet sure about what is causing the reduction in testing coverage and what remedies I should make.
@ericmjl also have additional questions regarding tests:

Where is the dataframe for testing originally generated and where in the repo can I see how it is loaded for all the pieces in test folder?
When writing tests, what should I be more aware of regarding test coverage?
Is it possible/okay to only test function that involves new changes? (I had been using make test yesterday that ran all the tests; this may not have been necessary?)

I added tests but not certain if my approach is proper. Will dig deeper into TDD but if you have recommendations/suggestions, please let me know. Thanks!!

Regarding your questions on tests, here’s my answers:

Where is the dataframe for testing originally generated and where in the repo can I see how it is loaded for all the pieces in test folder?

It is found in tests/conftest.py. All of the test fixtures (i.e. “constants”) that are shared across modules are found there.

When writing tests, what should I be more aware of regarding test coverage?

I would focus on getting the core functionality as well-tested as you can. I’m not worried about coverage as much as getting the test expressing the right thing.

Is it possible/okay to only test function that involves new changes? (I had been using make test yesterday that ran all the tests; this may not have been necessary?)

Yes! To do so, at the command line, run:
$ pytest -k test_myfunction_name  # replace with the correct function name

The -k flag can be discovered by running
$ pytest -h

@ericmjl I made the changes and docs render correctly. When you have a chance please review and let me know if anything else could be improved. Also, thank you so much for all the suggestions and answers!
Another side note about the notebook-based examples on docs:
Because the code cells currently do not allow horizontal scrolling, when code lines run long (it is a layout issue; not because those lines have run over the 80 character limit) they can get chopped off. Are there options to control overflow behaviors for the code cells?

Thanks @shandou!
On the issue:

Because the code cells currently do not allow horizontal scrolling, when code lines run long (it is a layout issue; not because those lines have run over the 80 character limit) they can get chopped off. Are there options to control overflow behaviors for the code cells?

Let’s bring this up in a separate GitHub issue, and continue the conversation there.

Thanks for the PR, @shandou!

Thanks @shandou!
On the issue:

Because the code cells currently do not allow horizontal scrolling, when code lines run long (it is a layout issue; not because those lines have run over the 80 character limit) they can get chopped off. Are there options to control overflow behaviors for the code cells?

Let’s bring this up in a separate GitHub issue, and continue the conversation there.

@ericmjl Correction: Just checked again and the code cells actually allow horizontal scroll if I do a mouse click on them. So I think we are good (I think users who want to copy/paste code snippets would apply a mouse click) :)


Proposal of new docs after WAF fixes

Product Version(s):

Issue:

Link to docs preview:

SME review:

[ ] An SME has approved this change.

DOCS review:

[ ] A member of the docs team has approved this change.

Additional information:

Merge checklist:

[ ] Deploy preview inspected wherever changes were made
[ ] Build completed successfully
[ ] Test have passed

All of the items have been addressed in WAF updates for 3.18. No need to merge. Closing out.


joern-scan too-many-loops query not working when using the new C frontend

Example source file
void bad() {
    while (1) {}
    while (1) {}
    while (1) {}
    while (1) {}
    while (1) {}
}

void good() {
    while (1) {}
    while (1) {}
    while (1) {}
    while (1) {}
}

Example outputs
New frontend
❯ ./joern-scan --overwrite --tags all --language newc too_many_loops.c
Result: 1.0 : Cyclomatic complexity higher than 4: too_many_loops.c:1:bad

Fuzzy frontend
❯ ./joern-scan --overwrite --tags all --language c too_many_loops.c

Result: 1.0 : Cyclomatic complexity higher than 4: too_many_loops.c:1:bad
Result: 1.0 : More than 4 loops: too_many_loops.c:1:bad

This isn't an issue with the new frontend. Rather, the querydb fetched by
./joern_scan --updatedb

still included the old version of the too-many-loops query that was using the parserTypeName to filter controlStructures, instead of the controlStructureType field. This has already been fixed in query-database.


Testpage ControlAddin

Hi guys,
is there a way to use a usercontrol (control-addin) on a test page somehow?
Are there any ideas on how to test those?
Thanks & Best Regards
J

Thank you for reaching out. Your request could be reporting a product bug not related to the AL application extensibility. Please reach out to the relevant support channels:

For collaboration in preview or beta versions of AL Language in Visual Studio Code (aka ModernDev), use GitHub (https://github.com/microsoft/al).
For Microsoft partners, for versions already in general availability and supported, file requests through Microsoft Partnersource (https://mbs.microsoft.com/partnersource/).
For ISVs/VARs who have discovered a bug in a in preview or beta version, use MS Collaborate (https://docs.microsoft.com/en-us/collaborate/).
For Business Central customers who have issues or found bugs, please contact your Microsoft partner.
For the new features please submit a product suggestion on https://aka.ms/bcideas

For questions not yet identified as being bugs, Yammer could be better.

It;s now posted there: https://www.yammer.com/dynamicsnavdev/#/Threads/show?threadId=1357549857865728


Data with resets (legal nonmonotonic timestamps) incorrect rendering

Problem:
For example OPF files have a reset field which annotates a new sequence starts. It is perfectly legal for the new sequence to have a different/older timestamp than the previous sequence. This is detected as non-monotonicity in time and causes the graph to be incorrectly rendered.
Solution:

if detected combination hasResets, the timestamp is ignored and we use iterations.

[ ] it would be nice to show the "original time" field, currently it gets suppressed.

Note:

I'm thinking if we should avoid the hassle with timestamp parsing at all, and just stick with iteration for xdata and show timestamp as a normal field; as suggested above.

Thoughts @jefffohl @rhyolight ?

@breznak said:

It is perfectly legal for the new sequence to have a different/older timestamp than the previous sequence.

@scottpurdy Is this true?

What code are we talking about here? In the OPF, it is perfectly valid to have resets and older timestamps afterward. But what graph are we talking about?

@scottpurdy just visualization specific problem here. For DyGraphs we need functions (one fn value at given time), OPF with resets does not ensure that, so we should represent the data differently, not plotted as function of time, but as fn of iteration number(step).

Ahh got it. Yes that sounds right. We should use the record number for the x-axis and timestamps just as labels.

Thanks @scottpurdy

Reopening for discussion if we should :

ditch the timestamp and use iterations for x-data
keep using time where possible (current)


Fix Onnx.GroupNormalization Torch->Linalg Lowering

Fixed by https://github.com/llvm/torch-mlir/pull/3658


Suggestion: consider distribute this framework as bower package too

As per title, I think many users would love to just do bower install t3 to install this framework, like me ; ).
Is there any plan to distribute this on bower?
Also, speaking of bower, npm install t3 is also a common way for people (those who use browserify for example) to download this framework.

By the way, the author is above is me (used a company account by mistake).

You can already do npm install t3js (see http://t3js.org/docs/getting-started/installation).
We skipped bower packaging as it seems like the trend is towards using npm for client packages (especially since the jQuery plugin registry closed).
Will npm install work for your use case?

Yeah, fair enough. Personally I forked this project and added it as a submodule. What I was thinking is that there are projects which are heavily dependent on bower so giving those users a bower package would be easier for them to maintain. But as you said the trend is going towards npm.

Cool, closing for now. I'd prefer to wait until someone tells us they can't use T3 without Bower support before we go through the process of adding Bower. We're switching to using just npm for this and it's refreshing. :)


[WFLY-14957] Add needed module dep to allow deployment transformer to…

… access WildFlySecurityManager
Fixes fix for https://issues.redhat.com/browse/WFLY-14957

EE 9 Tests:
https://ci.wildfly.org/viewLog.html?buildId=262997&tab=buildResultsDiv&buildTypeId=WF_Ee9BootableJarLinuxJdk8
https://ci.wildfly.org/viewLog.html?buildId=262995&tab=buildResultsDiv&buildTypeId=WF_WildFlyPreviewLinuxJdk11


Add options to plot time-varying effects

Coverage decreased (-10.4%) to 65.816% when pulling 2810bbd1e197f086574d69c57eb8bdc601713624 on add-plot-tvbeta into f9b2f667c496c4e0b43d990d268934a7b8b476b9 on develop.

Coverage decreased (-10.4%) to 65.816% when pulling 2810bbd1e197f086574d69c57eb8bdc601713624 on add-plot-tvbeta into f9b2f667c496c4e0b43d990d268934a7b8b476b9 on develop.

Coverage decreased (-10.4%) to 65.816% when pulling 2810bbd1e197f086574d69c57eb8bdc601713624 on add-plot-tvbeta into f9b2f667c496c4e0b43d990d268934a7b8b476b9 on develop.

Coverage decreased (-10.4%) to 65.816% when pulling 2810bbd1e197f086574d69c57eb8bdc601713624 on add-plot-tvbeta into f9b2f667c496c4e0b43d990d268934a7b8b476b9 on develop.

Coverage decreased (-10.4%) to 65.816% when pulling 2810bbd1e197f086574d69c57eb8bdc601713624 on add-plot-tvbeta into f9b2f667c496c4e0b43d990d268934a7b8b476b9 on develop.

Coverage decreased (-10.4%) to 65.816% when pulling 2810bbd1e197f086574d69c57eb8bdc601713624 on add-plot-tvbeta into f9b2f667c496c4e0b43d990d268934a7b8b476b9 on develop.

Coverage increased (+2.4%) to 78.571% when pulling 9cf10a163ef112a54572e656a255246a8dad7160 on add-plot-tvbeta into f9b2f667c496c4e0b43d990d268934a7b8b476b9 on develop.

Coverage increased (+2.4%) to 78.571% when pulling 9cf10a163ef112a54572e656a255246a8dad7160 on add-plot-tvbeta into f9b2f667c496c4e0b43d990d268934a7b8b476b9 on develop.

Coverage increased (+2.4%) to 78.571% when pulling 9cf10a163ef112a54572e656a255246a8dad7160 on add-plot-tvbeta into f9b2f667c496c4e0b43d990d268934a7b8b476b9 on develop.


The "timeout" is not work on FireFox browsers while doing Registration or Authentication

@abergs
Issue description: the "timeout" is not work on Firefox browsers while doing Registration or Authentication
Reproduced on "Use as 2FA/MFA" tab: https://www.passwordless.dev/mfa#heroFoot
I waited for more than 2 minutes, seem like it's don't pop-up the timeout dialog like Chrome and Microsoft Edge
I tried to reproduce on Chrome and Microsoft Edge, they are worked as my expected. Here are the screenshots:

(This issue happens same for Authentication)

Is this related to the timeout passed to the nagivator.credentials... API? If so I've experienced various inconsistencies around how that behaves across different browsers, especially in relation how errors are surfaced and also whether the call blocks. I don't think there's anything that can be done about it from the fido2-net-lib side though, including the samples.

This is actually a bug in Windows 10 WebAuthn API itself, as it is ignoring the timeout, even if I pass it directly through WinAPI. Chrome apparently bypasses it by explicitly cancelling the operation. So this is IMO not an issue of fido2-net-lib.


[Turborepo]  unable to run example apps from create-turbo due to transpilation error

What version of Turborepo are you using?
(create-turbo) 1.6.2
What package manager are you using / does the bug impact?
Yarn v1
What operating system are you using?
Mac
Describe the Bug
Unable to run apps in a fresh create-turbo repo due to transpilation error:
web:dev: error - ../../packages/ui/Button.tsx
web:dev: Module parse failed: Unexpected token (3:9)
web:dev: You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
web:dev: | import * as React from "react";
web:dev: | export const Button = () => {
web:dev: >   return <button>Boop</button>;
web:dev: | };
web:dev: |

Expected Behavior
Should be able to run & open the example apps.
Running the same commands but using the previous version (npx<EMAIL_ADDRESS>works as expected.
To Reproduce

run create-turbo
npx create-turbo@latest (this is currently version 1.6.2)

>>> TURBOREPO

>>> Welcome to Turborepo! Let's get you set up with a new codebase.

? Where would you like to create your turborepo? my-turbo
? Which package manager do you want to use? yarn

>>> Created a new turborepo with the following:

 - apps/web: Next.js with TypeScript
 - apps/docs: Next.js with TypeScript
 - packages/ui: Shared React component library
 - packages/eslint-config-custom: Shared configuration (ESLint)
 - packages/tsconfig: Shared TypeScript `tsconfig.json`

>>> Success! Created a new Turborepo at "my-turbo".
Inside that directory, you can run several commands:

  yarn run build
     Build all apps and packages

  yarn run dev
     Develop all apps and packages

Turborepo will cache locally by default. For an additional
speed boost, enable Remote Caching with Vercel by
entering the following command:

  npx turbo login

We suggest that you begin by typing:

  cd my-turbo
  npx turbo login

cd into the newly created directory & run the app
cd my-turbo
yarn run dev

yarn run v1.22.18
$ turbo run dev --parallel
• Packages in scope: docs, eslint-config-custom, tsconfig, ui, web
• Running dev in 5 packages
• Remote caching disabled
web:dev: cache bypass, force executing a1c187e9bb403a9a
docs:dev: cache bypass, force executing 3d6a8bf4f5f48c8e
web:dev: $ next dev
docs:dev: $ next dev --port 3001
web:dev: ready - started server on <IP_ADDRESS>:3000, url: http://localhost:3000
docs:dev: ready - started server on <IP_ADDRESS>:3001, url: http://localhost:3001
docs:dev: warn  - Invalid next.config.js options detected:
web:dev: warn  - Invalid next.config.js options detected:
docs:dev:   - The value at .experimental has an unexpected property, transpilePackages, which is not in the list of allowed properties (adjustFontFallbacks, amp, appDir, browsersListForSwc, cpus, craCompat, disableOptimizedLoading, disablePostcssPresetEnv, esmExternals, externalDir, fallbackNodePolyfills, forceSwcTransforms, fullySpecified, gzipSize, incrementalCacheHandlerPath, isrFlushToDisk, isrMemoryCacheSize, largePageDataBytes, legacyBrowsers, manualClientBasePath, modularizeImports, newNextLinkBehavior, nextScriptWorkers, optimizeCss, optimisticClientCache, outputFileTracingRoot, pageEnv, profiling, proxyTimeout, runtime, scrollRestoration, serverComponents, sharedPool, sri, swcFileReading, swcMinify, swcMinifyDebugOptions, swcPlugins, swcTraceProfiling, urlImports, workerThreads).
docs:dev:
docs:dev: See more info here: https://nextjs.org/docs/messages/invalid-next-config
web:dev:   - The value at .experimental has an unexpected property, transpilePackages, which is not in the list of allowed properties (adjustFontFallbacks, amp, appDir, browsersListForSwc, cpus, craCompat, disableOptimizedLoading, disablePostcssPresetEnv, esmExternals, externalDir, fallbackNodePolyfills, forceSwcTransforms, fullySpecified, gzipSize, incrementalCacheHandlerPath, isrFlushToDisk, isrMemoryCacheSize, largePageDataBytes, legacyBrowsers, manualClientBasePath, modularizeImports, newNextLinkBehavior, nextScriptWorkers, optimizeCss, optimisticClientCache, outputFileTracingRoot, pageEnv, profiling, proxyTimeout, runtime, scrollRestoration, serverComponents, sharedPool, sri, swcFileReading, swcMinify, swcMinifyDebugOptions, swcPlugins, swcTraceProfiling, urlImports, workerThreads).
web:dev:
web:dev: See more info here: https://nextjs.org/docs/messages/invalid-next-config
docs:dev: warn  - You have enabled experimental feature (transpilePackages) in next.config.js.
docs:dev: warn  - Experimental features are not covered by semver, and may cause unexpected or broken application behavior. Use at your own risk.
web:dev: warn  - You have enabled experimental feature (transpilePackages) in next.config.js.
web:dev: warn  - Experimental features are not covered by semver, and may cause unexpected or broken application behavior. Use at your own risk.
docs:dev:
web:dev:
web:dev: event - compiled client and server successfully in 739 ms (159 modules)
docs:dev: event - compiled client and server successfully in 755 ms (159 modules)

Open the web or docs app (localhost:300[0|1])

web:dev: error - ../../packages/ui/Button.tsx
web:dev: Module parse failed: Unexpected token (3:9)
web:dev: You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
web:dev: | import * as React from "react";
web:dev: | export const Button = () => {
web:dev: >   return <button>Boop</button>;
web:dev: | };
web:dev: |
web:dev: wait  - compiling /_error (client and server)...
web:dev: error - ../../packages/ui/Button.tsx
web:dev: Module parse failed: Unexpected token (3:9)
web:dev: You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
web:dev: | import * as React from "react";
web:dev: | export const Button = () => {
web:dev: >   return <button>Boop</button>;
web:dev: | };
web:dev: |

Reproduction Repo
No response

it also has been mentioned in https://github.com/vercel/turbo/discussions/346

For anyone visiting the thread, in case you missed it in the report, an easy workaround is to use the previous version
npx<EMAIL_ADDRESS>

Same here!

Thank you @chris-olszewski! 🙏

Please help me.

@leopard930418 can you open a new issue with some more information? That doesn't seem to be a related error.


.listenTo method does not work

I hope I have not missed anything; I think I have found an error in 0.8: The Backbone method listenTo does not seem to work.
Collection example:
this.listenTo(this, 'add', this.emitRooms);

Error: TypeError: Object [Object Collection] has no method 'listenTo'
Same goes for models.

Hey, this appears to have been dropped with the Backbone dependency in 0.8. I'm not sure what the intention was here, but there's a discrepancy between the API and the documentation. I'm not sure which needs to be corrected though.
Is listenTo particularly useful?

Biggest problem was probably naming version 0.8.0 as such instead of 1.0.0 due to the breaking change nature of it. We should follow semver more closely in the future to avoid these issues and frustration.
Anyway, in this particular case I don't think .listenTo() has any particular advantage over .on(), so the above could probably be written as:
this.on('add', this.emitRooms);

Actually, with semver anything under 0.x is considered breaking. I meant to remove listenTo from the docs, it was a convention from Backbone that doesn't serve much of a purpose if you don't have long-lived objects like you do on the client.

Good point @tgriesser. So we'll still be in a state of turmoil for some time I guess :)

The project leadership of Bookshelf recently changed. In an effort to advance the project we close all issues older than one year.
If you think this issue needs to be re-evaluated please post a comment on why this is still important and we will re-open it.
We also started an open discussion about the future of Bookshelf.js here https://github.com/bookshelf/bookshelf/issues/1600. Feel free to drop by and give us your opinion.
Let's make Bookshelf great again


location state is not persisted for initial route

https://github.com/FormidableLabs/redux-little-router/blob/master/src/enhancer.js#L34
The location returned by the history listener does not return state (and thus query) for the initial route.  Reproduce using this flow:

On a new tab, load a URL with at least one querystring value
Perform an action on the page that results in a push to a new url with different query values
Press the browser's back button

Expected: the query object should be available on the ROUTER_LOCATION_CHANGED action payload
Result: the query is an empty object (key is undefined and hash is an empty string as well).
I spent a little time trying to track down the root cause, but had to move onto other things, so reproduction steps is the best I can give you at the moment.

reproduced: https://giphy.com/gifs/bugshot-l4FGorVhHrrXvHZLO/fullscreen

Reproduced: https://gfycat.com/ValuableVillainousCanvasback

Workaround for the moment seems to be immediately dispatching a replace action using the initial location's pathname and search:
const initialLocation = store.getState().router;
if (initialLocation) {
  store.dispatch(initializeCurrentLocation(initialLocation));
  // Hack workaround for https://github.com/FormidableLabs/redux-little-router/issues/165
  store.dispatch(replace(`${initialLocation.pathname}${initialLocation.search}`));
}

While debugging something similar (no key set on initial load) I managed to replace the snippet above with:
store.dispatch(replace({}));

@skattyadz: That will wipe out the query string entirely. packState() will return:
{
  search: '',
  state: {
    reduxLittleRouter: {
      query: {},
      options: {}
    }
  }
}

If you'd rather pass an object to replace(), you can do:
dispatch(replace({
  pathname: routerState.pathname
  search: routerState.search
}));

@gshively11's workaround leaves off the hash if there is one. Since I'm not rendering on the server or anywhere that doesn't have window.location, I'm just doing:
dispatch(replace(window.location.href));

Weird, I can't seem to repro this in the demo. Might have to do with the fact that it's SSRing. @justrossthings if you get a chance, can you send me a repro repo? Otherwise I'll try to disable SSR and reproduce in the demo.

...wait, that's just react-redux-boiler right? I'll clone and investigate

@tptee probs won't be repro from react-redux-boiler as I've changed it a bit, plus it's not using v14 & i imagine the fix for https://github.com/FormidableLabs/redux-little-router/issues/144#event-1134080963 would have fixed this

Finally reproduced, even in SSR. This is going to require some refactoring :/


pydeck: Allow an empty layer argument in Deck object

Background
Address #4493

Change List

Handle empty layers
Add test case

Coverage remained the same at 80.192% when pulling f2ad83057f9b611c58132a4726b7cfa3e20c42d2 on ajd/fail-on-empty-layers into d29ba8d58b52dbb59ef5b1fa669e1d83710feafb on master.


GridView is glitchy when set_column_width is used with masked highlight layers

This task is automatically imported from the old Task Issue Board and it was originally created by Mateusz Czapliński.
Original issue is here.

Steps to reproduce

In the code of the grid_view debug scene, use the set_column_width FRP to change column widths for a GridView instance which has a masked layer enabled both for highlights and for selection. For example, change the following line: https://github.com/enso-org/enso/blob/f233ea66b37969b84a224e462014853f00db285e/lib/rust/ensogl/example/grid-view/src/lib.rs#L127 to     let view = &grid_views[2];.
Compile the changed code and open the grid_view debug scene.
Hover the mouse over the entries of the GridView mentioned in point (1) above.
Click the mouse over some entries of the GridView mentioned in point (1) above.

Expected

The entry hovered by mouse should be highlighted.
When clicking the mouse over an entry, this entry should become selected.
The text of hovered and clicked entries should be correctly positioned horizontally.

Actual

When hovering the mouse over the entries, the hover highlight jumps between the hovered entry and some other entries.
When clicking the mouse over an entry, a different entry is sometimes selected instead.
The text of the hovered and clicked entries is not correctly positioned along the horizontal axis.

See the video linked below for a demonstration of the behaviors mentioned above (note: in the video, the change from point (1) above was applied to the GridView in top-left corner of the debug scene).
https://drive.google.com/file/d/1N1zOtlhzik7laiRrSV8vzwdEg2l8_ueD/view?usp=sharing

EnsoGL is removed.


Retain cycle rule

Inviting myself to your PR here. But, doesn't this fit more in Best Practices/Tips and Tricks section than in the main style guide?

@htinlinn invite yourself to every PR :)

@htinlinn I think thinking about retain cycle should be a standard at Prolific, that's something we often forget to do, we should be very careful about it. IMHO it should live in the Swift rules.

@ThibaultKlein totally agree. We should probably even check for them as part of the audits that we do. But to me, this feels like something you should be doing anyways vs a nicer way of doing things which is what most of the style guide has been about.

Agree with Linn on this. There is valid information here, but this isn't an enforcable style as much as it is an aspect others might not be aware of.

@Haud @htinlinn I understand your points, I updated to move it to best practices

:+1:
Looks good to me. HOw about you @htinlinn ?

Next thing we add we should add a toc to best practices

:+1:

@ThibaultKlein @htinlinn has this been updated based on Linn's comments? If not, can we get that sorted as soon as possible, por favor?

Completely forgot about this guy, I updated

@Haud @htinlinn ?

Gave my :+1: before; @htinlinn is the last hold out.

:+1:


Paste and ctrl-A broken in number-only fields in Safari and Firefox

OS: Mac OS
Browsers: Safari 8.0.4, Firefox 37.0.1
When I copy & then paste, for example, credit card information using keyboard (Cmd + V) nothing happend. No information in input and in card representation.
In Chrome and Opera - no bug.

+1

Thank you for the report and triaging, much appreciated!
I can replicate this issue — marking as a bug and will take a look. My guess is that the validation on fields like the card number and expiration restricts the keypresses to paste and/or select. If you want to take a look and open a PR, I'm happy to help in any way I can!

Not just Ctrl+A, but it seems most shortcuts stop working when the field has focus. Ctrl+W, Ctrl+T. Tested in Firefox 39.0 on Linux.
A quick look reveals the issue lies within payment.coffee keyboard handling. I did not investigate further.

Yeah, the behavior of this is all over the map, but does seem to be rooted either in restrictNumeric() or binding to keypress vs. keydown or something. I really don't know, but the behavior is erratic.
Firefox/Mac 40.0

All modifier-key based shortcuts are blocked when a number field is active.

Safari/Mac 8.0.7

Window/app commands (Command-Q, Command-T, Command-W) work, but Command-C/X/V/A (Copy/Cut/Paste/Select) don't, and probably others.

Chrome 44.0.*

Everything seems to work fine.

Adding on to @reefdog comment.
restrictNumber() does what it is supposed to do which is to return whether the argument is a number or not. The problem with that is the method is invoked on keypress and the side effect is that it prevents the default action of non-numbers like 'v' as in 'ctrl+v' or 'cmd+v'. I actually think Safari and Firefox are correct in its interpretation of the library.
Breaking copy/paste is a huge anti-pattern and can be seen as a deal breaker for most devs.
In my opinion, If people aren't validating numbers on the backend their doing it wrong anyways. I suggest that validation doesn't happen on keypress and the library reduces the scope of validation overall. This library should do just enough validation to change the background of the card and just enough to mask the inputs.

The documentation states:

Chrome does not fire the keypress event for known keyboard shortcuts
So if you use keypress, Chrome will not allow you to overwrite keyboard shortcuts, whereas Firefox and Safari will.

As for the actual issue, it lies within one of your dependencies.
https://github.com/jessepollak/payment/blob/master/src/index.coffee#L283
The restrictNumeric function has the conditional for e.ctrlKey. I updated the js file to check for e.originalEvent.ctrlKey, and that seemed to work.

Copy and paste works. CTRL-A and CTRL-E (on macOS, that is Emacs-style, beginning of line and end of line).

Please close this issue


Audio and Visual Caching Overhaul

Pros:

Better memory management!
Best of both worlds
Returns assets instead of paths when using paths.hx
Buttery smooth when restarting and going into chart editor
Doesn't lag much with Lua

Cons:

Paths.hx no longer returns the actual path unless you're using getPath (very easy to circumvent in most cases)
not 100% tested with mod support
Removes the persistent caching option because this does that but without destroying your computer

when this finishes doing the action imma see how my shit pc can handle psych then

Ok, this is cool.

Ok, this is cool.


chore(Makefile): update docker-go-dev to 0.14.0

[Current coverage][cc-pull] is 42.30% (diff: 100%)

Merging [#393][cc-pull] into [master][cc-base-branch] will increase coverage by 0.26%

@@             master       #393   diff @@
==========================================
  Files            25         25
  Lines          1144       1144
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            481        484     +3
+ Misses          632        629     -3
  Partials         31         31

Powered by Codecov. Last update [b583180...e280141][cc-compare]
[cc-base-branch]: https://codecov.io/gh/deis/builder/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/deis/builder/compare/b58318052a57b1afafbb49883c276d53d40b9912...e280141aaa6fc17b87937c9130b88494ca544f99?src=pr
[cc-pull]: https://codecov.io/gh/deis/builder/pull/393?src=pr


Handle string list for extra siblings of description

As observed in https://github.com/itzg/docker-minecraft-server/issues/2545 the description field of a ping response can sometimes have an extra siblings which is a simple list of strings, such as this response from Paper 1.20.4:
{"version":{"name":"Paper 1.20.4","protocol":765},"enforcesSecureChat":true,"description":{"text":"Foo","extra":["Bar"]},"players":{"max":20,"online":0}}

This behavior seems to be specifically tracking changes announced by Mojang in https://www.minecraft.net/en-us/article/minecraft-java-edition-1-20-3.
I have tested this change for backward compatibility where Paper 1.20.2 responds with
{"version":{"name":"Paper 1.20.2","protocol":764},"enforcesSecureChat":true,"description":{"extra":[{"text":"Bar"}],"text":"Foo"},"players":{"max":20,"online":0}}

Nice catch! Can you add a testcase for this scenario?

Certainly. Sorry, I hadn't noticed the tests file up a level.

I just wanted to see if you had any concerns about the test related changes.

Can you add newlines at the end of the JSON file & actions YAML?

Certainly! I really should setup IntelliJ to enforce that for me 😄

Oh, it appears the os.ReadFile API was only added in Go 1.16. Can you revert that change in a follow-up? I did not notice that the CI did not run as part of this MR 😬

Oh, I'm sorry about that. I guess the CI didn't run for this PR since it was newly introduced in the branch.
I'd actually recommend keeping the go.mod compatibility at 1.12 and I revert the change I made since then it advertises the backward compatibility of the library.

...but using a modern version of Go is good too 😀


CLI Instance Sorting

Issue #, if available: #21, #52, #122
Description of changes:
Implemented instance type sorting for CLI users through the cmd/pkg/sorter package. Users can specify either a json path to a field in the instancetypes.Details struct or they can use one of the hard-coded shorthand values, which use the quantity CLI flags as keys, in order to specify what field to sort instance types by.
json path parsing is done through the use of the following library: https://github.com/oliveagle/jsonpath
This PR is made in response to the following comment in another PR: https://github.com/aws/amazon-ec2-instance-selector/pull/138#discussion_r922584886
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Very useful feature, any ETA for the release?

@asychev hopefully by tomorrow!


[WIP] Trace picker updates

Okay!
So this is not quite ready yet. I've built out the views and I built out a little modal provider that we can use with other modals if we want to keep it.

General structure of the updates:
I've added two new props to PlotlyEditor:
advancedTraceTypeSelector which enables everything, and traceSelectorConfig which passes our default configs to the enhanced trace type selector. The default config values are coming from some constants I ported over from streambed which you can see here. Let me know if this data structure should change.
I have created a ModalProvider.js which passes two functions through context to anywhere in the application: openModal(component) and closeModal(). We call openModal and pass it a component -> see here.
I have also created a Modal.js component that we can pass params to. Currently it accepts a title param for the header, and then we can pass it content via children wrapped in <ModalContent>...</ModalContent> I might just bake this in rather than using a sep wrapper component for this. The Modal.js takes care of animating in/out.
Where I need help // cc @VeraZab @nicolaskruchten
I am not exactly sure the best way to hook up the TraceTypeSelector.js to be able to affect the larger application state (change chart types, only allow X type charts if Y type chart is already selected (see here), etc. Currently I am passing the same props that we pass to the drop down to the TraceTypeSelector.js, but I will need some guidance moving forward.
Things I still need to do:

[x] Hook up the enhanced picker to actually change the trace type
[ ] Convert the new chart type images to react svg components (and add the last 2 from @fabric-8)
[ ] Provide a way for people to pass in custom images along with their custom data
[ ] Possible default image/icon for a chart type that is passed but does not have a plotly image / provided image
[x] Allow item actions to be customizable

Will resolve: #238

Convert the new chart type images to react svg components
do you mean by this: put these icons into the plotly-icons repo?

@VeraZab possibly -- these svgs are a lot more complex (various strokes, different colors) -- but it might make sense to add them. I'll have to either manually make them into components or adjust our generating scripts for them.

To make the Modal change the plot, you have the updateContainer prop, you can pass it the value of the chart that the user clicks on. So for ex, for a timeseries chart, we have to make sure the timeseries value is passed on. It's a custom type. Careful with the custom types. We have that function plotlyTraceToCustomTrace to make those conversions, it takes container as an argument (gd.data).

but it might make sense to add them there.

yup, I think it does make sense to add them there

A few comments:

Looks great!
regarding the 2d/3d chart exclusion, basically in this component there needs to be some check of what's currently in the figure, and then some decision about which chart types to grey out. We can implement this after the basic version is done in a separate PR, but I don't see this as "affects the larger application state" so much as "conditionally renders based on state" if you see what I mean...
(Vera beat me to it)

re how to wire things in to the bigger context, take a look at how the other widget/field pairs work.
basically your TraceTypeSelector is an unconnected widget, and the TraceSelector is a field which connects it. So the field will pass you a prop of your choice bound to its props.updatePlot which you need to call whenever the user makes a choice.

hey @aulneau!
we've discussed this a little bit here: https://github.com/plotly/react-plotly.js-editor/issues/260#issuecomment-364287520
And finally decided not to put these as separate trace types into the chart picker: 'error bars', 'animations', 'timeseries'. Would you remove them from the picker, please.

Okay I've started going through and creating lists based off of the icons that Fab has made, and the list I pulled from streambed, and the list contained here in this editor and this is what I've got so far:
Trace types with category and icon -> here
Trace types with icon but no category -> here
Trace types with no icons and no category -> here
Also @VeraZab and @nicolaskruchten do we want to couple the category type in with the trace type, eg:
A
    {
        value: 'scatter',
        label: _('Scatter'),
        category:CHART_CATEGORY.BUSINESS,
    },

or do we want to keep trace types clean and do something like:
B
    {
        value: 'scatter',
        label: _('Scatter'),
    },
---
const categories = [
  {
    value: 'statistics',
    label: _('Statistics'),
    traces: ['scatter', 'line', ...more],
  },
  ...
];

I am leaning more towards A.

I like A, it's DRYer

Okay -- I have added all the trace types that have icons into categories.
cc @VeraZab @nicolaskruchten @jackparmer for any suggestions on moving trace types to a more appropriate category:

Hmmm. How attached are we to our existing categorization scheme, @jackparmer ? It seems a bit limiting at this point if we're adding all the other trace types...
Maybe we want to use a more function-oriented approach like this? https://datavizcatalogue.com/search.html or https://visual.ly/community/infographic/how/graphic-continuum
There are bunch of other organization types here https://github.com/widged/data-for-good/wiki/Visualisation-::-Choosing-a-chart

Hmmm. How attached are we to our existing categorization scheme

Not attached to it at all. I'm sure y'all can come up with something much better.

Here's a slightly different typology which includes all 3 carpet types and might fit into a 4-row/8-column grid.

Simple (8, first row)

Scatter
Bar
Line
Area
Heatmap
Contour
Table
Pie

3D (5, second row)

3D scatter
3D line
3D surface
3D mesh
Pointcloud

Maps (3, second row)

Choropleth
Satellite
Atlas

Distributions (5, third row)

box
violin
histogram
2d histogram
2d contour histogram

Finance (2, fourth row)

OHLC
Candlestick

Specialized (7, fourth row)

Ternary
Polar
Parallel Coordinates
Sankey
Carpet
Scatter Carpet
Carpet Contour

I like it! Only thing is pointcloud isn't 3d. I think we should have a 7th column called "2d WebGL" that has scattergl, pointcloud, scatterpolargl, and heatmapgl. This will be good for us - it's too hard to play around with the WebGL trace types currently.

I was thinking that the GL types would be like a checkbox or something rather than a first-class citizen in this trace-picker. The user looking at this might not want to make the "underlying technology" choice at this point...?
What's pointcloud if not 3-d?

+1 Checkbox/switch sounds great to me. Maybe on the top-right here? One side of the switch says D3/SVG and the other side says WebGL?

What's pointcloud if not 3-d?

This magical trace type that @monfera wrote for uber refresh rates with lots of 2d scatter data:
https://codepen.io/monfera/pen/BLjJVZ
https://plot.ly/javascript/pointcloud/
If people want to plot a stupid # of x-y points interactively, we point them to pointcloud

One downside to the SVG vs WebGL thing at the trace-picker level is that then 3D would need to go under WebGL, right?

I would label it "2d WebGL" and keep 3d charts under both views

OK so my initial thinking about the checkbox was outside of this modal. If we want to have the GL versions on this modal, I would go with a separate section called "WebGL accelerated" or something with those trace types in there.

👍  "WebGL accelerated" column. I don't have a strong preference about the WebGL display as long as they are easy to access like the other trace types.

@aulneau do you have enough input to move forward with this PR? We will probably want to shuffle the categories again later in the future, so we probably don't need to nail it all down right now/this PR should leave things easy to change in that department :)

@nicolaskruchten yep! going to add some final touches and it should be ready for another review this afternoon :)

Okay, I've added the new categories and placed the trace types in them as we have decided (let me know if any should be moved around).
I think something we should discuss is if we want to have the amounts in each column so varied:

To try and prevent the columns from being so long, I've made a version that if there are more than 4 items in a column, that column will break into 2 sub-columns:

Thoughts? cc @VeraZab @jackparmer @nicolaskruchten

Oh my original suggestion had been different in two ways:

rows as opposed to columns
allow multiple groups per row, so that e.g. Maps and Distributions could sit on one row to make things less ragged

@aulneau Yes that makes def. more sense given the uneven amount of items – Think the bar below the titles is not necessary though, but vertical bar helps to keep things seperate
Rows vs. Columns:

Row More flexible/robust in regards of layout, also better if trace types are being added or removed

"Other" plot cats might get pushed out of the view, so user might have to scroll to see all cats

WebGL:
From a user perspective, how is WebGL different from 3d? Isn't that just a technical diff a user potentially doesn't really care about when choosing his trace type?

(porting some of my comments from private chat with @aulneau)
we could do something like a grid/block system:

which would degrade reasonably well on narrow screens.
Also, keep in mind that this selector needs to be a bit dynamic: not every instantiation of this editor will want to have the same chart types/categorizations. So a dynamic type-to-category and category-to-layout specification would be good, even if we put a lot of though into the default one. Also we are likely to add chart types over time, so even if we land on something really balanced right now, it might break the minute we add a new type ;P

(also, +1 on merging WebGL and 3D)

Here are the potentially-upcoming chart types: https://github.com/plotly/plotly.js/issues/2221

@nicolaskruchten @aulneau Def. like this approach, seems like the best thing to do 👍

LGTM. Merging WebGL + 3d sounds good too, I don't have a strong opinion.
Keep in mind there will be 4 more 3d types by end of month (cone, volume,
isosurface, and streamtube)
On Mon, Feb 12, 2018 at 1:29 PM, Nicolas Kruchten<EMAIL_ADDRESS>wrote:

Here are the potentially-upcoming chart types: plotly/plotly.js#2221
https://github.com/plotly/plotly.js/issues/2221
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/plotly/react-plotly.js-editor/pull/311#issuecomment-365013123,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABx4aorMI-jv3NOGzex_BFfYBEBE9SKuks5tUIDAgaJpZM4R9RqN
.

Okay -- I have implemented the layout updates. Hurray for css grid! (will have to create a fallback flex version)

The only things left I have are:

[ ] get icons converted to react components (slightly hung up because these are more complex and include css in the svgs)
[ ] abstract out icon to be replaced if the user wants to supply their own
[ ] update the select to be a button when this trace picker is enabled

Oh yeah, I really like this new layout! :D

looks sooo good @aulneau !!!

He's a wizard! 🔮
On Wed, Feb 14, 2018 at 4:30 PM, VeraZab<EMAIL_ADDRESS>wrote:

looks sooo good @aulneau https://github.com/aulneau !!!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/plotly/react-plotly.js-editor/pull/311#issuecomment-365751430,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABx4amA7PyqjgVR_5UaDNT4O6KRoU5F4ks5tU1CJgaJpZM4R9RqN
.

Very nice @aulneau! Also seems like we need a few more icons? :)

@fabric-8 I am currently using the same icons for Scatter GL, Scatter Polar GL, and Heatmap GL, but we don't have an icon to use for Point Cloud.
I've updated some of the icon names in plotly-icons to reflect all the trace types we have (I've also added a flag so we can render simple icons versus the new ones if we ever need to).

I've currently disabled the "Actions" functionality as I don't have a list of all the tutorials we want to link to for each trace type, and I am not sure how to implement the functionality we have in chart studio where when you click on See a basic example. it will load up that kind of trace type with data. Probs best to do the actions bit in a follow up PR so this one isn't delayed forever.
Fab is in the process of re-exporting out our SVG's so that there are no styles embedded in style tags, which has been preventing me from converting them to react components. Once those are good to go, this PR should be able to be merged (barring any new changes/fixes recommended via @VeraZab or @nicolaskruchten :) )

Are we going to add all three carpet trace types (carpet, scattercarpet, contourcarpet) to this selector? Do we need separate icons for each?

Come to think of it, if Finance gets a section with 2 types and Maps with 3, might be worth adding a Carpet section with 3? That would unbalance the layout a bit though :(

Yeah -- I do think if we keep adding more and more sections, the general layout breaks down a bit. Also I think there might be an upper limit where this grid layout still makes sense vs a list view.

The carpets are a bit of fringe trace type. Not huge use cases outsideof aerospace as far as I know.
One idea for carpets that I had is a "carousel" where you can click a left/right pointer to get a different "variety" of carpet plot, but this carousel would take up the same real estate as a normal icon. We could do the same thing for the 2d histograms.

Maybe instead of a carousel we could just have a fly-out menu appear when you click on certain trace types, to choose a specialization/variant. That would definitely save some space and work well with the WebGL-vs-SVG thing. We could group OHLC and candlestick into a single "Finance" icon. Box and Violin group nicely also etc.

Also I think there might be an upper limit where this grid layout still makes sense vs a list view.

Yeah @aulneau that would make sense to me

so I've just commented out a few traces, because they're not going to go into the editor just now:
('scatterpolargl', 'pointcloud', 'scatterpolar', 'carpet', 'sankey', 'parcoords', 'violin')
and this is what the layout currently looks like without them:

Could we readjust a little

I think I'd vote here to make these adjustments, and merge this pr in. We have all the icons for the currently integrated traces in the editor. We can make smaller prs to integrate the rest, and make layout improvements as we go.

@aulneau checked out your branch and played around with it, looks good! let's merge!
and then when all icons are in plotly-icons we can make those changes in another pr. thanks!! 🎉

ok, I think I resolved all rebase issues here, going to merge and if anything was missed then we'll see pretty soon :)


register orangery.is-cool.dev

Requirements

[x] You have completed your website.
[x] The website is reachable.
[x] The CNAME record doesn't contain https:// or /.
[x] There is sufficient information at the owner field.
[x] Your website is not hosting on the following due to SSL issues: Vercel, Netlify

Description
My portfolio website
Link to Website

orangery.is-cool.dev

I have read the CLA Document and I hereby sign the CLA


ORA-12545 because of tnsnames.ora entry

Not sure if something could be done, but when trying to explicitely connect to XE from docker itself I got ORA-12545 Connect failed because target host or object does not exist.
Checking with LSNRCTL I found the following
LSNRCTL> status XE
Connecting to (DESCRIPTION=(ADDRESS=(PROTOCOL=TCP)(HOST=33817b96c0aa)(PORT=1521))(CONNECT_DATA=(SERVER=DEDICATED)(SERVICE_NAME=XE)))
TNS-12545: Connect failed because target host or object does not exist
 TNS-12560: TNS:protocol adapter error
  TNS-00515: Connect failed because target host or object does not exist
   Linux Error: 110: Connection timed out

I can see docker is giving me a different  hostname: (d57f5951434b), so updating the file solved this. I don't know if this could or should be achieved programatically in the startup.sh
Im running elementary OS 0.3.2 64 bits (Ubuntu 14.04) with 14.04 xe image and custom DNS in the run parameters.

It's weird. I do replace the hostname in the startup.sh.
How did you use this image?

From reading startup.sh, I had the same impression.
I run the image like the example in the docker hub. I enabled ipv4 address forwarding
sysctl net.ipv4.conf.all.forwarding=1

and set a  custom dns. It looks like this:
docker run -d -p --dns=10.x.x.x 49160:22 -p 49161:1521 wnameless/oracle-xe-11g:14.04.4

The OS where docker runs is Virtualized and the host pc is running through a VPN (im using the same DNS from the VPN in the docker run command.

Can use the latest image instead of 14.04.4?
The 14.04.4 branch is a bit outdated.

Sure.
I'll take a look at it tomorrow on my main pc :)

Tried the latest image and it seems to work fine, even on Ubuntu 14.04 based distros. Checked the latest commit to startup.sh https://github.com/wnameless/docker-oracle-xe-11g/commit/25c689e8139901e1d4173a702b77bc99c6afe8d5#diff-10d392d9a96a6d149734665c9e21618c and does exactly what it should now, even with my custom dns configuration:
root@671e899db66b:~# cat /u01/app/oracle/product/11.2.0/xe/network/admin/tnsnames.ora
# tnsnames.ora Network Configuration File:

XE =
  (DESCRIPTION =
    (ADDRESS = (PROTOCOL = TCP)(HOST = 671e899db66b)(PORT = 1521))
    (CONNECT_DATA =
      (SERVER = DEDICATED)
      (SERVICE_NAME = XE)
    )
  )

EXTPROC_CONNECTION_DATA =
  (DESCRIPTION =
    (ADDRESS_LIST =
      (ADDRESS = (PROTOCOL = IPC)(KEY = EXTPROC_FOR_XE))
    )
    (CONNECT_DATA =
      (SID = PLSExtProc)
      (PRESENTATION = RO)
    )
  )

root@671e899db66b:~# sqlplus system/oracle@XE

SQL*Plus: Release <IP_ADDRESS>.0 Production on Tue Jul 19 16:58:47 2016

Copyright (c) 1982, 2011, Oracle.  All rights reserved.

Connected to:
Oracle Database 11g Express Edition Release <IP_ADDRESS>.0 - 64bit Production

SQL>

Thanks a lot


ADDED - custom params to route

Hello,
Commit who add the ability to add params to route link.
Workaround : Link to edit with other fields that the edit button.
This solves the problem of not being able to prompt text like action.

@InfinityWebMe Hey thanks for the PR. Can you elaborate a little?
Not really clear what we are enabling here


Fix overflow and z index

Associated issue: #3
The overflow problem was fixed by setting the overflow prop of the Box component that wraps the main panel and sidebar. This change needed to be made in both src/App.js and the README file.
The z-index problem was only in the README file. src/App.js uses '1' (the correct value) but the README shows '100', which causes the FormClose icon to be hidden behind AppBar.

thanks for your contribution


Add AWS pricing and IAM links

Why:
Pricing and IAM links were missing.
What's being changed:

Check off the following:

[x] I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
[x] For content changes, I have reviewed the localization checklist
[x] For content changes, I have reviewed the Content style guide for GitHub Docs.

Seeking a quick 👍 from @jpadams<EMAIL_ADDRESS>

Thanks for opening this PR @imjohnbo ! ✨ Can you ping @github/docs-content when you're ready for a content review and ready for us to merge this? That'll get it on the first responder's radar to request a review ⚡

Thanks so much for opening a PR @imjohnbo! I'll get this triaged for review ⚡


Accessibility: Heading includes Emoji

The heading is “Cookies” with a cookie emoji in front of it. This emoji is directly placed within the text of the h2 element and thus becomes part of the heading. If screen reader software is set to read emojis, the heading would be read aloud as “cookie Cookies.” It may be better to remove the cookie image from the h2 element and place it separately so that it can then be hidden from assistive software.

Oops, wrong plugin


use shifts in place of mul / div on powers of 2

Codecov Report
Base: 66.38% // Head: 98.99% // Increases project coverage by +32.60% :tada:

Coverage data is based on head (216f9d6) compared to base (bc2945c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##              1.2     #858       +/-   ##
===========================================
+ Coverage   66.38%   98.99%   +32.60%
===========================================
  Files         105       48       -57
  Lines        4287     2477     -1810
  Branches      548      362      -186
===========================================
- Hits         2846     2452      -394
+ Misses       1420       15     -1405
+ Partials       21       10       -11

Flag
Coverage Δ

foundry
?

production
99.20% <ø> (+0.47%)
:arrow_up:

reference
98.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

contracts/lib/TokenTransferrer.sol
100.00% <ø> (+25.00%)
:arrow_up:

contracts/lib/ReentrancyGuard.sol
77.77% <0.00%> (-11.12%)
:arrow_down:

reference/lib/ReferenceOrderCombiner.sol
96.71% <0.00%> (-3.29%)
:arrow_down:

reference/lib/ReferenceOrderValidator.sol
97.26% <0.00%> (-2.22%)
:arrow_down:

contracts/lib/OrderCombiner.sol
98.71% <0.00%> (-1.29%)
:arrow_down:

reference/lib/ReferenceCriteriaResolution.sol
98.05% <0.00%> (-1.01%)
:arrow_down:

reference/lib/ReferenceFulfillmentApplier.sol
98.14% <0.00%> (-0.95%)
:arrow_down:

contracts/lib/CounterManager.sol
100.00% <0.00%> (ø)

contracts/lib/OrderFulfiller.sol
100.00% <0.00%> (ø)

contracts/lib/ZoneInteraction.sol
100.00% <0.00%> (ø)

... and 79 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


mGuard

What is the sc4s version ?
sc4s version=3.22.5
Is there a pcap available?
no
What the vendor name?
Phoenix Contact
What's the product name?
mGuard
** Feature Request description: **
new filter
** Should it support TCP or UDP?**
both
** Do you want to have it for local usage or prepare a github PR? **
local

Please send me pcap file on email<EMAIL_ADDRESS>

@mccain007 without pcap files (with log messages that producing your device) we can't implement parser for you

Understood I was trying to get the pcap from the admin for mguard but he  hasn’t replied
Get Outlook for iOShttps://aka.ms/o0ukef

From: Ilya @.>
Sent: Thursday, May 9, 2024 10:59:09 AM
To: splunk/splunk-connect-for-syslog @.>
Cc: mccain007 @.>; Mention @.>
Subject: Re: [splunk/splunk-connect-for-syslog] mGuard (Issue #2435)
@mccain007https://github.com/mccain007 without pcap file (with log messages that producing your device) we can't implement parser for you
—
Reply to this email directly, view it on GitHubhttps://github.com/splunk/splunk-connect-for-syslog/issues/2435#issuecomment-2102831559, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6GWLEP4FACDYFDVZVV7MJ3ZBOFL3AVCNFSM6AAAAABHCHIUQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBSHAZTCNJVHE.
You are receiving this because you were mentioned.Message ID: @.***>

Here is what the customer sent me:
Here we go @.***:~$ sudo tcpdump host XX.XX.XX.229
tcpdump: verbose output suppressed, use -v[v]... for full protocol decode
listening on ens192, link-type EN10MB (Ethernet), snapshot length 262144 bytes
11:21:58.536095 ARP, Request who-has grp01.XXX.gov tell hqw-ntx-esx01.XXX.gov, length 46
11:22:33.125109 IP mdm.XXX.gov.46215 > grp01.XXX.gov.syslog: SYSLOG user.notice, length: 85
11:22:38.350866 ARP, Request who-has XXXgrp01.XXX.gov tell mdm.XXX.gov, length 28
11:22:38.351017 ARP, Reply XXXgrp01.XXX.gov is-at XXX:30:e7 (oui Unknown), length 46
11:22:55.612299 IP mdm.XXX.gov.46215 > XXXgrp01.XXX.gov.syslog: SYSLOG user.notice, length: 72
11:23:18.767188 IP mdm.XXX.gov.46215 > XXXgrp01.XXX.gov.syslog: SYSLOG user.notice, length: 63
11:23:23.918855 ARP, Request who-has XXXgrp01.XXX.gov tell mdm.XXX.gov, length 28
11:23:23.919074 ARP, Reply XXXgrp01.XXX.gov is-at XXX:30:e7 (oui Unknown), length 46
^C
8 packets captured
8 packets received by filter
0 packets dropped by kernel
do you want me to send you whats being captured by SC4S?  i can't connect to his server to do a pcap from the sc4s end.

From: Paul McCain @.>
Sent: Thursday, May 9, 2024 11:53 AM
To: splunk/splunk-connect-for-syslog @.>; splunk/splunk-connect-for-syslog @.>
Cc: Mention @.>
Subject: Re: [splunk/splunk-connect-for-syslog] mGuard (Issue #2435)
Understood I was trying to get the pcap from the admin for mguard but he  hasn’t replied
Get Outlook for iOShttps://aka.ms/o0ukef

From: Ilya @.>
Sent: Thursday, May 9, 2024 10:59:09 AM
To: splunk/splunk-connect-for-syslog @.>
Cc: mccain007 @.>; Mention @.>
Subject: Re: [splunk/splunk-connect-for-syslog] mGuard (Issue #2435)
@mccain007https://github.com/mccain007 without pcap file (with log messages that producing your device) we can't implement parser for you
—
Reply to this email directly, view it on GitHubhttps://github.com/splunk/splunk-connect-for-syslog/issues/2435#issuecomment-2102831559, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A6GWLEP4FACDYFDVZVV7MJ3ZBOFL3AVCNFSM6AAAAABHCHIUQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBSHAZTCNJVHE.
You are receiving this because you were mentioned.Message ID: @.***>

Hello, @mccain007 Send me please pcap file with raw logs that producing your device.
I already mentioned https://github.com/splunk/splunk-connect-for-syslog/issues/2435#issuecomment-2102831559

@mccain007 problem of your tcpdump that we can't see here log message content.
Please use official guide for tcpdump

@mccain007 I closing this issue, because you haven't provide me pcap file, and I waiting for it month.
When you will provide I reopen this issue. You know that without examples of your log message impossible create a parser


Missing WH type in Signatures dropdown list

Pathfinder Version: 1.4.0
Wormhole type D382 is not listed in the Type drop down in the Signatures section

@Raisten Thanks for the report.
That´s interesting. AFAIK is D382 a static WH (not wandering).
J142547 has 2 statics (O477 B274).
So there are 2 options:

CCP changed the statics for this WH
The data used by Pathfinder is outdated (same for Anoiks end ellatha)
This was a bug in the Eve Client

Do you have have a chance to re-scan that system so we could verify that **D382 ** is a true static of that system?
Source:

http://anoik.is/systems/J142547
http://www.ellatha.com/eve/WormholeSystemview.asp?key=142547

Wandering WH may have the same type as static WH. So some hole may have D382 static and another wandering D382. I lived in C2 like 6 or 7 years ago but I remember it happened from time to time. Even if it changed, leaving such possibility for wandering WH in PF shouldn't hurt or be misleading IMHO.


Use the method parameter's runtime (instance) type to find the validator instead of its declared type

Fixes #46

Merged, thank you!


Under certain conditions, setting "Void excess..." on a Disk Drive starts voiding when one disk is full.

Issue description:
In a Disk drive with two 64k storage disks, setting "Void excess items and fluids" on and adding a whitelist filter for one item, the items get voided when only one disk is full.
What happens:
Items get voided in a disk drive when one disk gets full.
What you expected to happen:
Items should get voided when all disks are full, not just one.
Steps to reproduce:

Setup a disk drive.
insert 2 empty 64k storage disks
add a whitelist filter for one item
Set up a way to import large numbers of that item into the system
Watch how the item starts getting voided when the first disk gets full

Industrial Hemp Fiber is being inserted into the system:

RS Interface getting Hemp Fiber:

Version (Make sure you are on the latest version before reporting):

Minecraft: 1.10.2
Forge:<IP_ADDRESS>7
Refined Storage:refinedstorage-1.2.25

Does this issue occur on a server? [yes/no]
Not tested.
If a (crash)log is relevant for this issue, link it here:
[pastebin/gist/etc link here]

If I disable "Void excess items..." the second disk starts to fill up. As soon as I enable "Void excess items..." again, the voiding restarts and no new items get into the second disk.

Setting "Compare ore dictionary" to Yes makes the second disk accept items... weird.

This is intended behavior.


GH-37266: [CI][C++] Avoid clobbering build type with CMAKE_ARGS

Since CMAKE_ARGS could in some circumstances (conda-forge) override CMAKE_BUILD_TYPE, pass it first and let our own choice override it.

Closes: #37266

@github-actions crossbow submit conda

@kou Does this look ok?

Can we use our environment variable such as ARROW_CMAKE_ARGS instead of CMAKE_ARGS?
If we keep using CMAKE_ARGS, we may have a similar problem later again.
(In general, conda users should use CMAKE_ARGS to build their CMake based projects (not conda packages)?)

I've tried your solution in https://github.com/apache/arrow/pull/37272

If conda recommends using CMAKE_ARGS, I'm OK with this approach.
Otherwise I like #37272.

I suspect it might be necessary to set up the correct toolchain and options (such as ar and friends)?
@xhochy @h-vetinari Could you shed some light on this?

Not sure where best to answer across 3 different threads. Yes, we set a bunch of things in CMAKE_ARGS, but that's mostly internal to our setup. I guess we should rename that eventually to something less prone to conflicts (but that would mean changing a lot of feedstocks ATM).
I don't understand why the CI for conda builds here ever would need to build non-Release builds, but either ordering CMAKE_ARGS to the beginning (as this PR does) or renaming it should be fine.
Does that answer the questions?

I don't understand why the CI for conda builds here ever would need to build non-Release builds, but either ordering CMAKE_ARGS to the beginning (as this PR does) or renaming it should be fine.
Does that answer the questions?

It does, but what should be the preffered solution? Should we use conda's CMAKE_ARGS?

Should we use conda's CMAKE_ARGS?

For conda builds (using conda compilers, with those activation scripts), generally yes, unless you do the (minimum) equivalent bits of the activation scripts yourself (i.e. setting certain paths). But from my POV, you're not obligated to do it in any particular way in your own CI, and should go with whatever is most understandable / maintainable.
I also still don't understand why you're doing debug builds with conda, but assuming that as a given, I'd say it's probably less surprising to rename the respective variable, i.e. follow #37272.

Sure. As you found out, the compiler stack that comes with that is more geared towards the needs of conda-forge. You can also strip the release flag out of CMAKE_ARGS with a simple sed, if you want.
I'm happy to help here, though in this case I don't see an approach that's obviously the best. It's a kind of  "off-label" usage, and no variant is perfect.

Ok, so let's use ARROW_CMAKE_ARGS to decouple ourselves from conda-forge, then.


[BUG]: Problem with Approvals relating to 'Admin | App Archive and Clean Up - Check Approvals and Archive'

Describe the bug
A clear and concise description of what the bug is.
Component (please tell us which flow or app you are experiencing issues with):
Governence - Version 1.18

'Admin | App Archive and Clean Up - Check Approvals and Archive' and maybe 'Admin | Flow Archive and Clean Up - Check Approvals and Archive'

To Reproduce
Steps to reproduce the behavior:
The 'Admin | App Archive and Clean Up - Check Approvals and Archive' is switched on.
Then there is an error if ANY Approval is attempted e.g. even with the 'Dummy' Test approval.
Encountered a general permissions error trying to access the CDS database. This could be caused by modification of the approvals administrator or user roles, or by an incompatible plugin.
Expected behavior
For approvals / rejections to work, when the flows are switched on.
There was a ticket with the same issue that has been closed. I don't think this can be a platform issue as I have created the COE on our Tenant in Another environment and have the same issue.
Thanks
Laurence

Hello. Are you saying that you get a permissions error running any flow approval in the CoE environment?

Yes, but only when 'Admin | App Archive and Clean Up - Check Approvals and Archive' is switch on. If I switch it off, the approval will then work.

We have a local repro of this. Will let you know what we hear.

Thanks for using CoE and posting this. The product team made some shifts which require we make some changes too.
Can you please see if the attached resolves this for you?
CenterofExcellenceAuditComponents_1_19_managed.zip

Sorry someone had added components to the solution I was unaware of. Try this instead.
CenterofExcellenceAuditComponents_1_20_managed.zip

Thanks, I will try this out and let you know. Do you know if the problem was caused by the rollout of Dataflex?

I've tested in our environment and that looks like it has resolved the issue:

Thanks for the help
Laurence

Wonderful. Thank you for using CoE!


remove unused ReadUint64 and ReadUintN functions

Codecov Report

Merging #1628 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1628      +/-   ##
==========================================
- Coverage   87.44%   87.38%   -0.06%
==========================================
  Files          98       98
  Lines        6256     6228      -28
==========================================
- Hits         5470     5442      -28
  Misses        560      560
  Partials      226      226

Impacted Files
Coverage Δ

internal/utils/byteorder_big_endian.go
100% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b74c7...2297bc1. Read the comment docs.


Move left activity bar to bottom

The activity bar on the left (is it called  that way?) takes too much screen real estate.
It would therefore be better to make it horizontal and either on the top or on the bottom of the content sidebar

I guess it actually makes sense to do that if one's using a vertical monitor.
@mojo2012 I think you'll be better off just hiding it and learning the shortcuts for changing view. Or you may use my Commands extensions to add buttons for this to the statusbar:


Provide repository to package.json for WebJars compatibility

I am trying to use tiny-warning with webjars.org and get the following error:
The metadata was missing a required field: /repository/url
This could be easily fixed by adding the information to the package.json:
"repository": {
  "type" : "git",
  "url" : "..."
}

Thanks in advance!

PR welcome!

Fixed with #4


Input with IconButton as Adornment doesn't render correctly in RTL direction

[x] This is not a v0.x issue.
[x] I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior
When any form or text field with InputAdornment is in RTL direction, then input label should be right aligned and Adornment Icon should not overlap label or text of the input.
Current Behavior
When a Material UI form with an input field which has IconButton as Adornment is rendered in RTL direction mode then the IconButton overlaps the input field label and input field label does not follow RTL direction.
Steps to Reproduce
Link: https://codesandbox.io/s/znlo3qq994

Go to the above link
Look for text fields with Input Adornment
Observe the overlapping of icon on label

Context
We are using Material UI in our applications which support LTR and RTL direction modes. We have Password change form where we are using  icon to show or hide entered password but when this form is used in RTL mode then the Eye Icon overlaps the input Label. This issue has been easily replicated in Material UI official documentation website here if we change direction of the page to RTL.
Your Environment

Tech
Version

Material-UI
v3.2.0

React
16.4.1

Browser
Chrome

@rajhans84 Follow our RTL guide and you will be good: https://material-ui.com/guides/right-to-left/#right-to-left (it's working with the docs).

@rajhans84  This may be an issue with a browser extension of yours. I'm using LastPass as a password managers which adds its own adornments to inputs and this probably breaks the page layout:

Everything is normal in an incognito window.
I don't have the issues you described with our docs though.


Install SSL certificate on invenio-dev

Everything is set up and working fine on the AWS side. Docker needs to be reconfigured on the instance.

Troubleshooting with Ian and Mike did the trick.


add ninja

After some more thought. I think we can add this if you actually see it being used. Right now, everything else that we depend on is typically used from the global namespace (such as rtop, refmt (for editor support) and ocamlmerlin). Will people use ninja from the command line, not as part of a package build/install process? I think we should add this to the globals if they use it on the CLI, else add it to the application/library dependency if it's usually only called as part of a build. Thoughts?

Baked into bs-platform since v1.5.2

Woohoo!


[msal-angular] Update guard with version detection for canLoad

This PR updates the MSAL Guard to check the version of Angular used by applications to determine whether to return a loginFailedRoute or boolean in the canLoad interface.
This PR addresses issue #2923.

Coverage increased (+4.1%) to 86.59% when pulling 4889c5479e2f05dcb94955886d428237b46c6aa7 on angular-canload-change into 888e35f5c10b95f0c229a1f714477d8a246b80a3 on dev.

Coverage increased (+4.1%) to 86.59% when pulling 4889c5479e2f05dcb94955886d428237b46c6aa7 on angular-canload-change into 888e35f5c10b95f0c229a1f714477d8a246b80a3 on dev.

When will this update be available as I'm facing this issue when trying to use alpha-3 package.

When will this update be available as I'm facing this issue when trying to use alpha-3 package.

@anuj-shukla The latest versions of msal-browser and msal-angular were released last night. Please update using npm install<EMAIL_ADDRESS>@azure/msal-angular@alpha and give the new version a try.


Aggregate bonded - Cosigner have to open tx details to check if it has to be signed

Steps:

Announce a few aggregates bonded from multisig account with minimum approval 3 (one cosigner)
Go to the second cosigner and sign one of the partial transactions.
Logout and login because of bug https://github.com/nemgrouplimited/symbol-desktop-wallet/issues/1487
Go to the transactions list. Now you can see a few partial transactions. One of them is already signed by this cosigner but there is no way to tell which one without opening details.

Expected result: It should be already visible on the list that the account has to sign partial.

Resolved.

Tested in Sprint-fixes branch , good to go for the integration branch

@bassemmagdy @AnthonyLaw there is a small issue. Right after signing tick is not presented. I have to switch to another account and go back and after that tick is presented. It should be right after signing if possible.
Video: https://share.getcloudapp.com/nOuP5znl

Fixed in integration.