no images found?

without me changing anything (at least on purpose) suddenly this error materialized this morning:
Traceback (most recent call last):
File "Desktop/instaRaider.py", line 231, in
count = raider.getImageCount(url)
File "Desktop/instaRaider.py", line 27, in getImageCount
count = re.findall(r'\d+', countsCode.group())
AttributeError: 'NoneType' object has no attribute 'group

It's because Instagram recently went through a redesign, which launched yesterday. A lot of elements have changed, so everything is broken unless the author decides to fix it.

that unfortunately makes sense and explains why InstaRaider suddenly could not find any images.

I will try to get this fixed by Monday. Unfortunately there is not much I can do about Instagram redesigning the website, other than to change the CSS selectors each time it happens.

I totally understand, i am in no rush, it just was very convenient:)
On Jun 13, 2015 6:57 PM, "Amir Kurtovic"<EMAIL_ADDRESS>wrote:

I will try to get this fixed by Monday. Unfortunately there is not much I
can do about Instagram redesigning the website, other than to change the
CSS selectors each time it happens.
—
Reply to this email directly or view it on GitHub
https://github.com/akurtovic/InstaRaider/issues/12#issuecomment-111769795
.

Thanks for the great script.
I am waiting for the update.
I have this error now:
File "./instaRaider.py", line 240, in
count = raider.getImageCount(url)
File "./instaRaider.py", line 30, in getImageCount
count = re.findall(r'\d+', countsCode.group())
AttributeError: 'NoneType' object has no attribute 'group'
Mustafa

Thank you very much for code
and i'm waiting for the update
i have same error

I still haven't worked through all of the issues caused by the latest redesign, but InstaRaider is now back to at least somewhat functioning. It will save the first 24 images, which is how many are loaded on the first page. I'll try to get the rest of the profile to load in the coming days.

I have now fixed all the issues that were introduced by the redesign. Along with fixing the errors, I also refactored a lot of the code and removed the ability to specify a number of images to save. I have also update the README to document the new usage. I'm marking this issue as closed. If there are any new bugs or issues that crop up due to these changes, please open a new issue.


Doc:  How to change environment variables for Connecting BC Program Data on GitHub

Description:
We need an instruction manual for how to change the location of the Connecting BC Program Data spreadsheet
AC:

[x] Step by step document on how to change environment variables for the Connecting BC Program Data
- [x]  SP Site, Doc name, Doc library

Hey team! Please add your planning poker estimate with Zenhub @AntBush @marcellmueller @rafasdc

@rafasdc can we check off the AC?

Done, sorry!


Add Kofko Blog by Alberto Colombo

You want to add your news to this huge list!
That's great.  I'd love to add it.  If you can share where your content is I'd love to only link to it.  To do this I need the way to get the data.
If you have a RSS feed, that works best.  However if I have to get it differently I can do that too, I just need to know where this data is.

Title: Kofko Blog by Alberto Colombo
Category: Techblog with servicenow stuff
RSS Link or Other Endpoint: https://blog.kofko.xyz/feed.xml

Added


Option to show just the module graph

Fixes #4
This is an initial stab at allowing just a high-level overview of the module graph with --collapse-modules.

[ ] There's some places that don't handle ModuleDecl yet, not sure why CI doesn't give a warning for those

calligraphy 'src/*' -p out.png --collapse-modules

I thought it would be nice to hide the entire functionality behind a single flag, but now that I've written it, I think I might prefer https://github.com/jonascarpay/calligraphy/issues/4#issuecomment-1110617467. It requires more flags to get the same result as the above graph, but it would be more flexible, and integrates nicely and predictably with the existing logic.
One other possible design:

Add a top-level node for each module, with all declarations as its children
Add a dissolve phase that, for each node type, adds a --dissolve-* option to remove that node type but keep its children. This would be turned on by default for modules to get the original behavior. This should be enough to be able to replicate the above graph.
Additionally, if dissolving happens after collapsing, and only affects non-empty nodes (--keep-empty? on by default?), you would only need --collapse-modules.

I'm not sure if dissolving would ever be useful outside of modules, though. If not, it's just a roundabout way of achieving  https://github.com/jonascarpay/calligraphy/issues/4#issuecomment-1110617467

Unfortunately, HIE files (GHC?) can't tell you whether a module is hidden or exposed. Having dashed outlines for hidden modules would've been neat.

I ended up adding it as a special case to the Collapse phase (8ae6aa557e97431bb8beb50bdbf44cc0fd70b6e9), which is now called the NodeFilter phase (12ecd1c409fb23b5c47de71f28ad1c3ff6b52005).
I initially implemented --collapse-modules as described in https://github.com/jonascarpay/calligraphy/pull/5#issue-1216940797 and https://github.com/jonascarpay/calligraphy/pull/5#issuecomment-1110726279, but it turns out that having a top-level node for modules just isn't very useful in contexts other than collapsing modules. Besides, it was arguably hackier that the current implementation, because the module node doesn't actually correspond to any actual declaration. To the degree that it's a kludge now, it's at least a) honest about that b) easy to change should anyone get a better idea and c) at a point in the pipeline where we don't break the abstraction for literally the entire downstream.


Upload App to Team does not behave as guide says

My experience when I uploaded my App, was I clicked Upload -> Org Wide {something like that, it was my only option} and the upload kicked off. I still cannot find the App to deploy or use it, and when I try to upload again, it errors saying it exists already.
Sorry if this is common sense to most of you, I'm new to much of this infrastructure & technology.
I had lots of issues getting the script to run right, the connect-pnp command just brought up an authentication window then froze. Took me along time to get past that issue (I was using an In-Private browser for my service account, and third party cookies are required for that modules authentication to work, once I enabled the cookies it worked fine) but I still got errors trying to setup my connectors, bad entry point (I got past the first part of this by removing one of the parameters of each command, the Resourcegroupid maybe, because the command got 1 result with just the connector name) this provided resourceid, however the commands to authenticate just gave a white window or more bad entry point errors and these commands couldn't sustain removing a parameter, so I manually authenticated my connectors in the api connections workspace.
I think I mitigated all my errors & mistakes, but I'm sure I've done irreparable harm lol, but if anyone can help me get the App accessible so I can test I'd be very thankful.
Microsoft E5 licensing, power automate free, power apps plan 1, pnp.powershell version 1.6.0, Az versions were all different but I did try to update and nothing downloaded. My Teams connection was nowhere available in Apps for me to use it on the Flow import, had to add a new one... But I can see it in API connectors.
Thanks for any help, I am learning but as easy as low/no code sounds, it's anything but 🤣
Notes: When the script asks for the Service Account password, please enter the password for your Service Account created earlier.* This never happened for me, I authenticated to Azure, Azure AD, Azure CLI, then pnp.powershell (all using global admin, even though there is a comment in the code that says I should be logging into PNP with the service account, I believe it retrieves my token )
OK, a piece of additional information.... I CAN see my App in the Teams Administration Workspace, but not in the Desktop App. I tried searching from the Apps area and the Team I deployed the App to (It errors now if I do it, saying it is already there). I checked my Org Policy and all of my 3rd party App Policies are ON. I did go into my App Policies (Defaults) and saw that third party apps were off in one area, so I turned them on, made sure even though it was default, that I assigned a Policy package with those defaults to my Teams Group. I still do not see the App in the Desktop App, but perhaps it takes a bit of time to sync now that I changed Policy, so I will wait a bit.
OK, I solved my biggest dilemma, I shut down Teams and Office and deleted my cached data, started the App back up, and then when I followed the steps to upload it directly to the Teams App, I was not limited to Organization, I also had Team or Channel, and was able to get it deployed to my Tab.
Now, I am seeing an error when I check availability though...
CheckTeamAvailability.Run failed: { "error": { "code": "WorkflowTriggerIsNotEnabled", "message": "Could not execute workflow '129ce41e-b737-42a9-9958-c89103af829c' trigger 'manual' with state 'Disabled': trigger is not enabled." } }
Going to leave this issue open until I can triage and fix this problem.

OK, So I have dug, read, studied and pulled my hair out, I am way to new to this to be trying to tackle this task and expect to be successful. So I would like to ask a few questions while I plan on ripping it out and starting over.

When I export the App and change the ID number and zip it back up and Upload it, does that essentially render the App unable to be editted, and if so does the original copy not stay in the Tenant that I could upgrade and re-export? I lost the ability to EDIT or Restore to a 2 day old build atfer doing this so I think that may be the cause.
Also, when I export and upload the App, it then becomes a custom App and I also could not see the flows for it to troubleshoot them, is that another aspect of exporting and uploading as a new custom App? Do the Flows just go away or is there a way I do not know of to get back into them?
Lastly, now that we can script building Templated Groups using the Graph API, is that an easier process to get going for a total newb? I can build a request form with approvals and have the build be scripted so it is consistent.
I had a LOT of trouble just getting everything to install without errors, and really never did. Reading a part of the script, it mentions that I should sign into PNP with the service account, but the deployment instructions say to wait until the connectors are built and it does the authentication part. Also it NEVER asks me to enter my ServiceAccount password like the deployment guide says it will, and I cant find that in the script. Has that changed or am I just way off track and missing something?

Thank You for any advice/help you can offer!

Well, I gave up and deleted everything our of my tenant last night. Going to try a fresh istall and see if I fair better. Closing this case, but if you have time to answer any of my questions, I could sure use the knowledge :).


Doc for "Table System fields" says audit fields like SystemCreatedAt can be used in keys, but AL gives errors (AL0306)

This page says

It's possible to use audit fields in a key. The platform doesn't automatically index these fields in any way.

...but if I want to add a key on SystemCreatedAt to avoid an info warning when sorting by that on a page, I can't, as apparently my own table can't find its own 'implicitly available' audit field... and the same goes for the other 3 audit fields too:

Is this in reality intended to work? If so, please let newly declared tables do what the documentation says we can. If not, let's arrange for the documentation to be fixed.
Thanks!
Name: AL Language
Id: ms-dynamics-smb.al
Description: AL development tools for Dynamics 365 Business Central
Version: 8.4.586670
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-dynamics-smb.al

The fix for this issue has been checked in to the master branch. It will be available in the bcinsider.azurecr.io/bcsandbox-master Docker image starting from platform build number 22.0.48153.0 and VS Code Extension Version 11.0.698501.
If you don’t have access to these images you need to become part of the Ready2Go program: aka.ms/readytogo
For more details on code branches and docker images please read:
https://blogs.msdn.microsoft.com/nav/2018/05/03/al-developer-previews-multiple-releases-and-github/
https://freddysblog.com/2020/06/25/working-with-artifacts/


Render targets are not auto-mipmapped

Textures attached to render targets ignore the auto-mipmap flag. I suspect we should be calling gl.generateMipmap in the pc.Device#updateEnd function.

Fixed in 5d9f0f42d8d0ddc0b6aa64b206c715d3e9b5ed39


Method to display errors

It would be helpful to include error strings as props for cases like:

DateRangePicker
Must select a start date
Must select an end date

SingleDatePicker
A date is required

Or possibly passing down custom errors as props.

Somehow I missed the required={true} prop on the DateRangePicker, but I don't see how it recognizes when the form is being submitted. Also it would still be a nice improvement to have the ability to alter the presentation of the .DateInput's by passing styles/classNames rather than just error messages (which is still nice).

Hi @ctrlaltdylan, as you noticed required={true} is a html form attribute that I believe will prevent you from submitting a form. However, there's still won't be an error message (or any error styling) or anything like that and I don't think it'll do much in the react ecosystem where things tend to be done client-side.
If you have a proposal for how this would look design-wise (maybe even just applying an error class to the inputs)? I feel like the details are not entirely hashed out.
To be fair, the parent component that you are writing should have access to the date values so you should be able to write your own error message a la
onSubmit() {
  if (!this.state.startDate || !this.state.endDate) {
    this.setState({ showErrorMessage: true });
  } else {
    // handle form submit
  }
}

render() {
  return (
    <div>
      {this.state.showErrorMessage && "Please enter a start date"}
      <DateRangePicker ... />
      <button type="submit" onClick={this.onSubmit}>Submit</button>
    </div>
  );
}

The only thing missing would be some sort of error styling on the drp itself. Is that something you are interested in/think is valuable? What would that look like?

That shouldn’t be the case if you extend via the theme, instead of trying to override with a .css file.

@ljharb perhaps I wasn't being very clear. My experience is the opposite of your statement, but let me elaborate.
As I understand, there are two ways to apply custom styles to the date picker - overriding with a .css file, or providing your own theme implementation.
By overriding with .css, I am able to apply the styles I like in respect to showing the date picker field in an error state. This works great, and I have no issues with this approach. This breaks down if you go to use a Theme though.
When providing custom styles via a theme, I am unable to style for an error state because as far as I know from looking at the theme there is no concept of "error" in the interface. Additionally, the styles generated from the theme all have an !important flag, so overriding these with a custom .css sheet isn't great.
However - my suggestion is that if there was an error prop on the date picker that would add a classname when true that caused a theme configured reactDates.border.input.borderError style to be applied, react-dates and it's theme could support an error state. This would work much like when the input is focused, which causes a theme configured reactDates.border.input.borderFocused style to be applied.

@ljharb yes! That's a far more succinct way to say it.
Although I do think there's still going to need to be a way to "activate" those error state styles on the date picker - i.e., an error bool prop.
Happy to help put a feature like this together as well.

@majapw, what are your thoughts?

Still relevant


Detect false comment on function def line

I have this function:
def to_csv(csv_filename = "#{Time.now.to_s.delete(' ')}.csv")
    require 'csv'
    # Get all unique keys into an array:
    keys = flat_map(&:keys).uniq
    CSV.open(csv_filename, 'wb') do |csv|
      csv << keys
      each do |hash|
        # fetch values at keys location, inserting null if not found.
        csv << hash.values_at(*keys)
      end
    end
  end

Expected behavior
Rubocop should not show any comment, or not the one that show now
Actual behavior
Rubocp said:
Do not place comments on the same line as the def keyword. [Style/CommentedKeyword]
Steps to reproduce the problem
Define the function inside a ruby script in my case I'm using emacs
RuboCop version
rubocop -V
0.48.1 (using Parser <IP_ADDRESS>, running on ruby 2.1.6 x86_64-darwin16.0)

and ruby version 2.1.6

I can't duplicate this issue on master or the latest release. There were some bugs fixed in that cop in versions 0.52.0 and 0.52.1. Try upgrading.


-changed and added files for a better conda installtion

-created modules for every script file
-removed conda build recipe for visualizer

./visualizer/scripts/viz does not work anymore, please fix


Reveal H2 Web Console Context

Please bundle the H2 web console and provide the context to access the DB contents.

@cconnar Do you have a pull request to submit ?

@lgrateau I do not, although it's not for a lack of trying.  The web console is a fantastic out of the box feature of H2 that allows for accessing the filesystem DBs and writing SQL against them.
The ODM standalone is running H2 by default, but it seems the web console is not enabled in a Spring config somewhere or the URI isn't registered with Liberty.  In either case, I am unsure of how to proceed.


Is there a way to implement a method on any object?

Here is an example in RuRu:
https://github.com/NullVoxPopuli/case_transform-rust-extensions/blob/30c7394562c07d0034b66e297a65dcf3fd718403/ext/case_transform/src/lib.rs#L80
Basically, it just allows passing of any type to a method, and you try converting to something until you get what you want.
Maybe there is a way to do this with Generics?
I know the implementation of each method I want per type -- just not sure how to go about it (String, Symbol, Array, and Hash)

I believe this is now possible – see the new json_builder example I added in #128. Feel free to reopen if that doesn't work for some reason!


RAT not working

When ever someone clicks on my rat it dose'nt connect to me i have port forwarded my ip and let the connection through my fire wall can someone please help me?

Portforward router
Disable Firewall
Check Port at canyouseeme.org


Tests enhancement

This pull request has changes to the following files:

tests/basic.rs
Added the following test cases for enhanced coverage of range iteration, random operations, and batched writes :

range_iterate_random()
range_iterate_overlap()
range_iterate_sparse_keys()
get_put_many_random()
get_put_many_delay()
get_put_delete_variable_entry()
override_one_random()
override_many_random()
batched_overwrite()
batched_overwrite_delete()

Cargo.toml
Added rand crate and updated the tokio dependency to include the “time” feature.

If you run "just fix-formatting" all the tests should pass.

If you run "just fix-formatting" all the tests should pass.

Done c44489d


Caching Mechanism

Just came up with the initial design for implementing the caching mechanism.

The source API is dead, closing this issue now.


star.stroked corresponds to the wrong codepoint

Description
Currently star.stroked corresponds to U+2605 Black Star instead of U+2606 White Star.
(This is the same codepoint as star.filled)
Reproduction URL
No response
Operating system
No response
Typst version

[X] I am using the latest version of Typst

Fixed by https://github.com/typst/typst/commit/79c2ec8f6fbaf1e7e31cbcfde88ffb05bcf21d98


Ia 931 deactivate user

Won't this create problems with history logs/polio country manageres and maybe some other places where profiles are displayed?

err possible, seems I was hasty and didn't  think of it, it will indeed pose problem in the audit log.


Badge loading screen and styles. Resolves #133

Added badge loading screen and simple error screen if load fails.

Tested locally and worked as expected.


Rename repo and package to deeprank-core

@LilySnow can you confirm that we can pick up this issue? (You mentioned you wanted to ask someone who might reference this repo by the current name?)


Example: SVG Basic shapes from https://developer.mozilla.org/en-US/docs/Web/SVG/Tutorial/Basic_Shapes

only test in Firefox, screenshot:

Can you cargo fmt this PR
so checks pass? Thanks!

Thank you!


could you please provide data_src.mp4  and data_dst.mp4

i haven't got a clue to the file data_src.mp4  and data_dst.mp4  . could you give it into the git repositories? Many thanks to you . my friend.

Sorry, movie files are too big to upload.  You'll have to download the videos yourself and put it into the folder.  I got those videos from the main deep fake program.  Just make sure to rename which ever videos you choose to data_dst and data_src


Lift linalg.generic to linalg.batch_matmul + transpose + arith.ext*

This is a key step in https://github.com/openxla/iree/issues/15158: the workload there consists of a couple of linalg.generic ops, and the first one, doing most of the arithmetic, is essentially a batch matmul, and can be lifted to an actual linalg.batch_matmul is we're willing to also create some transposes and around it.  Doing that will then compose with work on data-tiling and ukernels for the resulting flavors of linalg.batch_matmul.
Pasting here a function doing just that first linalg.generic to be handled here:
#map = affine_map<(d0, d1, d2) -> (d1, d2)>
#map1 = affine_map<(d0, d1, d2) -> (d0, d1, d2)>
#map2 = affine_map<(d0, d1, d2) -> (d0, d1)>
module {
  func.func @transpose_extend_batch_matmul(%arg0: tensor<32x128xi16>, %arg1: tensor<11008x32x128xi4>) -> tensor<11008x32xi32> {
    %c0_i32 = arith.constant 0 : i32
    %cst = arith.constant 0.000000e+00 : f32
    %0 = tensor.empty() : tensor<11008x32xi32>
    %1 = linalg.fill ins(%c0_i32 : i32) outs(%0 : tensor<11008x32xi32>) -> tensor<11008x32xi32>
    %2 = tensor.empty() : tensor<11008xf32>
    %3 = linalg.fill ins(%cst : f32) outs(%2 : tensor<11008xf32>) -> tensor<11008xf32>
    %4 = linalg.generic {indexing_maps = [#map, #map1, #map2], iterator_types = ["parallel", "parallel", "reduction"]} ins(%arg0, %arg1 : tensor<32x128xi16>, tensor<11008x32x128xi4>) outs(%1 : tensor<11008x32xi32>) {
    ^bb0(%in: i16, %in_0: i4, %out: i32):
      %5 = arith.extsi %in : i16 to i32
      %6 = arith.extui %in_0 : i4 to i32
      %7 = arith.muli %5, %6 : i32
      %8 = arith.addi %7, %out : i32
      linalg.yield %8 : i32
    } -> tensor<11008x32xi32>
    return %4 : tensor<11008x32xi32>
  }
}

Also since https://github.com/openxla/iree/pull/15273 is nearly ready, just waiting on the same LLVM integrate as I'm blocked on anyway, I'll rebase on that, so I won't duplicate the work to expand dims.  Just need to create the missing batch_vecmat named op.

The big #15296 is done and ended up including both of the above upstream PRs, so none of that is needed anymore if you just pull main now. And #15310 is merged too.

The big #15296 is done and ended up including both of the above upstream PRs, so none of that is needed anymore if you just pull main now. And #15310 is merged too.

Cool, I have finished the implementation for the vecmat case. I still need to add some tests and implementations for matvec and matmul, but that should not be much work. For now, I'll rebase and make a new draft PR while I finish up the rest of the cases

@Max191 @bjacob I think we are able to lift the case to linalg.batch_matmul + transpose + cast ops. Can we mark it done?

yes!


Is there an API we can call to return the extracted text in utf-8 encoding

Is there an API we can call to return the extracted text in utf-8 encoding ?
I am using tika python version 1.15

once you get the extracted text in python, just follow this guide for Python 3.x to turn the text into utf-8.

@chrismattmann I followed the link you mentioned but it doesn't clarify anything to me.
It says UTF8 is the default when using Python 3.
But my point is ... is there any default with respect to how PDF files themselves are encoded? Do our scripts need to check something in their metadata before proceeding to grab the text and output to a local text file?
I am trying to extract text from some PDFs mainly in French, Portuguese and Spanish.
My script produces UTF8 text files correctly formatted most of the time (i.e., the accented words look like in the PDF).
I made a list of files and a loop for calling tika.
But it fails for some of the PDFs in the loop, and I can't tell why.
If I open the produced wrong text file in Notepad++, the tildes are never over the letters (like they were in the pdf). Sometimes they appear after the letter, and sometimes before.
Could this be related to differences in the way the PDFs were produced?
If I look at the properties of the failing pdf file I see it was created with application LaTeX with hyperref, and in PDF productor it says pdfTeX-1.40.19
Many thanks in advance for your help


Registry sync should not delete profiles when failing to sync

Currently the way that the sync works is that it deletes all the content of the aws config that was created by granted, and then it fetches the new configuration and writes it back into the config file. If there is any error syncing a registry, all the other profiles are added into the config file.
I encountered this behavior the other day when I couldn't find any of the profiles I expected. The reason was that at the beginning of the workday I forgot to connect to the company VPN, which means that the first time I used assume it tried to sync my profiles but couldn't reach the remote repository and thus deleted most of my profiles from my config. I didn't notice this until later when I was very confused.
My suggestion would be that the configuration should have some kind of marker that shows which registry a profile was synced from. If syncing from a particular registry fails, print an error but don't delete that section.

Hi @Nevon, thank you for raising this issue. Currently you can use --prefix-all-profile flag with granted registry add to add your registry name as prefix to show which registry a profile was synced from.
On the registry sync failure case, removing the whole section on error was so that user will have visibility if there is some issues with the latest remote registry sync and can quickly update it. But in your case it was caused on the user end which is a bit of a problem. I will have a look on how we can make this experience better. Thanks  again for raising this!

Just hit this myself:
[i] Syncing Profile Registries
[!] Sync failed for registry o11n
[Γ£ö] Completed syncing Profile Registries

[Γ£ÿ] Granted couldn't find any AWS profiles in your config file or your credentials file
[i] You can add profiles to your AWS config by following our guide:
[i] https://docs.commonfate.io/granted/getting-started#set-up-your-aws-profile-file

I had valid config of course, remote git repo is unreachable during sync (with no way to skip sync when running assume) so sync fails and config is deleted

Fixed in #569


Disable broken test until issue is fixed

This flakey test was blocking other merges/releases so has been disabled:
https://github.com/alphagov/whitehall/issues/6279
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠

Hi MR RASHID A H HUSSEIN I keep forgetting about the next weekend and next week I think we are going back

Thanks for the approval @andysellick but the issue has been fixed now by Richard, so I'm going to close this.


Add keyable property

Add keyable properties which maps to Ember's keyEvent testing helper.
page = create({
  foo: keyable('keypress', 13, 'span', { at: 3 })
});

@juanazam: Nice!
I notice that there are no tests to make sure that the component-test version (with a this context) works. This is actually a bit of an issue with new features in general.
Want me to take a stab at these?

@jeradg I agree that it would be awesome to test this with the component-test version. I have mixed feelings about waiting for this to be merged before that is ready. I will give it a try these next days and see how easy it is. The tedious thing about this is to make the current test code work and also making sure the example makes sense with this property.

@juanazam @san650:
I we could use some agreement on what standard to meet before merging a feature into master. Do we need to have both acceptance and integration test support? Or is just one enough, and full support can be added in a separate PR?
I personally feel like we should not release features that don't work for both component and acceptance tests.
We're advertising that the addon supports both acceptance and integration tests, but it's unclear how true that is over the last couple of releases. I'm happy to take the lead on the component test part. But I think in general supporting both should be part of any PR.
Thoughts?

@jeradg In an ideal world I would rather have support for both at the same time (including test for both cases). Right now doing tests for both cases is a bit difficult, it would be wise to spend some time re organizing the test code to make it easy to test new properties when creating them for both scenarios.

I'm not sure if these feature is needed. Also, the PR is pretty old so it should be updated. I'll close the PR for now and let's chat about the feature.


Better type handling in harness, support COUNT(*) expressions and CAST

I know I say it in the comments but I'll mention it here again: I don't want to come across as being pedantic with the requests. I just want the codebase to remain consistent and as high-quality as possible for as long as we can, before we inevitably have to start working fast and hacking things to meet customer demand. The better the foundation, the easier we'll have it later on.
Preferably, all of this would be rules in some static analyzer, but I have no clue how to set that up, so it's PR comments for now. I probably should write some analyzer or linter or something, as this will break down once I'm no longer the only reviewer.

I think all this is taken care of but github is still blocking merge, not sure why. Want to stamp?


Newer OptiScaler

Hey, is it possible to invlude a newer version of optiscaler?
https://www.nexusmods.com/site/mods/986?tab=description

Currently bundled version achieves its goal well and seems to be the most stable. I'm waiting until 0.7 hit the main branch to move forward with any potential fixes that might be required.
For now you can upgrade Optiscaler yourself by replacing $HOME/fgmod/dlss-enabler-upscaler.dll with a newer version but it's not an intended change and you might see issues. First thing I would watch out for is UseFGSwapChain which might need to be set to false, disabling Opti's FG.


Document that you can call runApp again

This is such a fundamental property of the system that we forgot to
document it.
Fixes #6818

LGTM

Landing this almost-certainly-harmless patch on red to trigger a rerun of the bots.


Need fields from Plum for display

The "part note" and abstract should both come thought. After discussion w/ @escowles, it might be easier if Plum caches the jsonld from bibdata, and we pull it + these fields from Plum for indexing, rather than bibdata directly.

This might also help us with the Browse Group problem (if a Collection in Plum and also something we can turn into a browse group).


add maven plugin to generate report crosscheck jenkins / confluence

Hi this is a small plugin to generate specialized report trying to compare what we have done on the confluence page and what is detected on the junit report for external and licence
Hope it can help @geertjanw the "missing/hidden issue"
At  the moment
69 module with external issues
68 modules with licencing issues
Remains at bottom must be 0 or its triaging issue
within netbeans run maven > generate
on jenkins mvn clean install site (would it nice if it can be launch after each build, and on confluence page changes)

Looks really awesome, can't wait to see it in use.

Look good. Thanks for doing this!


feat: improve the configuration of concurrent servicetopology-endpoints workers

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:
Which issue(s) this PR fixes:

Fixes # 1910
Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

/lgtm


Protect against null IContractResolver on JsonPatchDocumentOfT

While working on a pull request I caused many of the JSON patch related tests to fail with null reference exceptions. I fixed the errors in my PR by not assigning null but I noticed that JsonPatchDocumentOfT doesn't have any [NotNull] checks on its ContractResolver property and constructor arguments.
https://github.com/aspnet/Mvc/blob/64e726d2b26422c5452475627e4afaba307edec3/src/Microsoft.AspNet.JsonPatch/JsonPatchDocumentOfT.cs

merged 38748b54eb7ef8e7cba2365d0621fcf4826dda4b


Add sample app for order-submission-rule function

Part of https://github.com/Shopify/core-issues/issues/61156 (part 2 - docs - to come soon)
Added a sample app for the new order-submission-rule function, to give devs a quick-start to build on the new api. The app changes the order submission target based on a configured cartTotal threshold:
if total < threshold {
  // checkout to order
} else {
  // checkout to draft
}

Opted for a very similar setup to the payment-customization sample-app.
Note: there is no UI portion for managing these rules yet, that will be tracked here.
Tophat
Setup
Repurposing the setup instructions from the bughunt doc.

Setup (steps 0-2 in the doc)
Init a new app using the new template from this branch:

npm init @shopify/app@nightly -- --template https://github.com/Shopify/function-examples/sample-apps/order-submission-rules\#dr/order-submission-rule-example

Create the app (step 3.3 in the doc) - make sure you toggle the beta on for your new app to see the new API.
Deploy the functions:

npm run deploy

Function 1: JS

Create a configuration for the JS function using graphql (step 5 in the doc)

set a cartTotal that you can easily test both above and below
Note: use the "$app:order-submission-rule-js" namespace for adding metafields

Verify that the function affects B2B checkouts correctly (checkout to draft when total > config, order when total < config)

Function 2: Rust

Create a configuration for the Rust function using graphql (step 5 in the doc) - don't forget to delete the JS configuration

set a cartTotal that you can easily test both above and below
Note: use the "$app:order-submission-rule-rust" namespace for adding metafields

Verify that the function affects B2B checkouts correctly (checkout to draft when total > config, order when total < config)

/shipit


Fix bug where PDFReader ignores extra_info

Description
Fixing a bug where PDFReader doesn't add extra_info into document metadata when return_full_document == True. Also, I fixed an apparent bug in PDFReader where, when extracting the text from each PDF page and merging into a single document (i.e., when return_full_document == True), the page texts are naively concatenated into a single string with no separator. This will lead to situations where the last word of page 1 is literally concatenated with the first word of page 2, etc. I added a newline separator instead (open to suggestions, a simple space character might suffice). Also, added new tests to test PDFReader behaviors related to loading data and metadata.
Fixes #13290
New Package?
Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

[ ] Yes
[x] No

Version Bump?
Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

[x] Yes
[ ] No

Type of Change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Added new unit/integration tests
[ ] Added new notebook (that tests end-to-end)
[x] I stared at the code and made sure it makes sense

Suggested Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I ran make format; make lint to appease the lint gods

Thanks @nerdai for the review! Logan and I agree to bring in fpdf2 as a dev dependency for my tests, I must not have declared this properly. I put it under [tool.poetry.group.dev.dependencies] in the local pyproject.toml, do you know if I need to declare it elsewhere?

Thanks @nerdai for the review! Logan and I agreed to bring in fpdf2 as a dev dependency for my tests, I must not have declared this properly. I put it under [tool.poetry.group.dev.dependencies] in the local pyproject.toml, do you know if I need to declare it elsewhere?

It might just be a pants related issue. Trying to take a look into this now :)

lol @joelrorseth i'm playing around with github cli and i may have closed your PR by acccident 😂


Incorrect Light Color option for light group

Issue

I created a light group containing only Hue White Ambiance bulbs in Deconz. These bulbs can only change the temperature but not color. Nevertheless, when the group is exposed to HomeKit through homebridge-hue, it receives the option to change the color too, which will fail if you really do so. This makes it impossible to adjust their temperature in Home app due to the interface.
Notice that when only lights are exposed, the HomeKit correctly hide the color option for these bulbs.
Not sure if this bug belongs to deconz or homebridge-hue.
Log Messages

Debug Files

Homebridge-hue simply exposes the attributes that deCONZ exposes for the group.


GA Test: Test core Satellite functionality

This should be able to be done once the rotation date support is in place: We should make sure ca rotation is still functional

Went through one general one through and things behaved appropriately. Need to redo the process and check more into the console, etc.

[ ] CA rotation
[ ] Pod subnet specification
[ ] Service subnet specification
[ ] Patch Upgrades

Portieris test passed e2e in Satellite environment


iohook not found with Electron

Expected Behavior
iohook should work. Would like to use iohook in the front-end however cannot get it to work.

Current Behavior

Tried generating ABIs for both NodeJS and Electron and added sufficient parts to package.json. Have tried uninstalling, reinstalling, using https://www.electronjs.org/docs/tutorial/using-native-node-modules. Read multiple bug reports and articles and watched videos all to no avail. I believe it might be to do with Electron running a separate runtime version, however I've even tried editing the code to require the file by its absolute path and that still does not work.

Possible Solution

Steps to Reproduce (for bugs)

Install iohook using NPM (npm i iohook -s)
Run Electron (electron .)

const electron = require('electron'),
          iohook = require('iohook');

Context

Trying to do keystroke and mouse detection for an on-screen counter in Electron.
Your Environment

Version used: v0.6.6
Environment name and version (e.g. Chrome 39, node.js 5.4): Node.JS v11.10.1; Electron v9.1.0
Operating System and version (desktop or mobile): Desktop (Windows 10)
package.json:

  "iohook": {
    "targets": [
      "node-67",
      "electron-80"
    ],
    "platforms": [
      "win32",
      "darwin",
      "linux"
    ],
    "arches": [
      "x64",
      "ia32"
    ]
  }

iohook does not yet work with Electron 9 on Windows and 0.6.6 failed to achieve compatibility, see https://github.com/wilix-team/iohook/issues/241. On Windows for iohook to work you must use Electron <9.

Still get the same issue after downgrading to Electron 8.3.4 despite someone saying that works in the post.

For Electron 8.3.4 your package json should now have
"targets": [       "electron-76",       "node-72"     ]
for Electron 8 and Node 12. Node 12.13.0 is the one paired with Electron 8.3.4. Unless you are intentionally using a different Node version with your Electron setup (you mentioned Node.JS v11.10.1 above)?

I am using node 12.13.0 and iohook 0.6.6 on windows and doesn't work, I get the same error saying the module was not found even the module is there. I tried adding the targets to my package json and still doesn't work.
Any idea why it doesn't work?

Node.JS v11.10.1 is working with Electron and is not the issue.

Unless there are features in v12 which iohook utilises which causes an error, however it seems unlikely.

Just checked with node v11.10.1 and doesn't work as well :/

any update on this... i am facing the same issue

An update: I've had multiple confirmations that this problem was resolved by installing Microsoft Visual C++ Redistributable on the machines via https://support.microsoft.com/en-au/help/2977003/the-latest-supported-visual-c-downloads.
These issues are all related:
#167
#193
#195
#224
#245

What about Mac users? Right after I call require('iohook'), my electron process stops:
Process exited with code 0
I'm using electron 9.1.2

I've reinstalled Microsoft Visual C++ Redistributable and reinstalled iohook with no avail.

@marcelblum thank you very much....no docs where telling that stuff in that explicit form like you did.

Any update?

@PiggyPlex lot of updates to iohook since you originally posted, have you tried the latest version, which now works through latest Electron v11.x?

@marcelblum I'm having the same issue...
Error: Cannot find module 'D:\myprojects\full-projects\bindbox\node_modules\iohook\builds\electron-v85-win32-x64\build\Release\iohook.node'
Any feedback on this issue?

@marcelblum I'm having the same issue...
Error: Cannot find module 'D:\myprojects\full-projects\bindbox\node_modules\iohook\builds\electron-v85-win32-x64\build\Release\iohook.node'
Any feedback on this issue?

你解决了吗

@marcelblum I'm having the same issue...
Error: Cannot find module 'D:\myprojects\full-projects\bindbox\node_modules\iohook\builds\electron-v85-win32-x64\build\Release\iohook.node'
Any feedback on this issue?

你解决了吗

No, i had to use an older version of electron and electron-rebuild package.


Add Institut Teknologi Sains dan Kesehatan PKU Muhammadiyah Surakarta

@iamhry First stage of verification passed, official domain is itspku.ac.id as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@iamhry Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Pass global values when creating rancher-monitoring-crd

This PR addresses https://github.com/rancher/dashboard/issues/4548 my making it so that the same global values used to create the rancher-monitoring chart are also used when creating the rancher-monitoring-crd chart.
When you configure values.global.cattle.systemDefaultRegistry, a value is now included in the network request:

This is passing all the values from the parent chart, not just the special global ones.  Those other values could have any unknown consequence for the child chart (which isn't necessarily just CRDs).

@vincent99 I have changed it to:
values:      this.addGlobalValuesTo({ global: values.global }),


[DOCS] Added casting to hybrid script doc and fixed pass infra doc

Thanks @electriclilies @zhiics !


Highlight unused variables in XSLT/XPath

Source code should be highlighted to mark variable names that are declared but never used.

merged branch onto master

Completed.


Issue with OutputOnlyGenotypedAnimals option

Dear AlphaGenes team
Im using Alphaimpute2, to impute SNP array data ( ~ 60K SNPs) from offspring  to WGS (~ 7M SNPs) to the parents . Also I have a pedigree file from 15 generations back (~ 85 K animals).
My issue is that the generated output has imputed data from all the fish, included those on the pedigree. However I only require the imputation from the genotyped animals.
On the Alphaimpute v.1.9 manual (I cant find the manual for the v2.0) there is an option called Outputonlygenotypedanimals. I’ve tried this option but it looks like it does not work for the last version of alphaimpute (at least for me). I’ve tried not using the pedigree for the imputation, and it works in terms that I only have the output for the offspring. However, my idea is to use the pedigree information as well, to improve the accuracy of the analysis.
It is possible to use the "Outputonlygenotypedanimals" on the v2? I wrote this option on the last box (BOX 8; Output), as shown below:
= BOX 8: Output =============================================================
WellPhasedThreshold         ,99.0
ResultFolderPath            ,Results
OutputOnlyGenotypedAnimals  ,Yes
I appreciate your help
Cheers

Hi @Agustinopulus would you care to share what solved the issue? Thanks!

Hi @gregorgorjanc
I figured it out that Alphaimute 2.0 doesn't recognize the parameter file necessary for the v 1.9. ( I realized this after trying several changes on the parameter file, e.g. imputation and phasing particles). Therefore, is not yet possible to output only the genotyped animals on Alphaimpute 2.0. Rather, the output shows all the animals, even those included in the pedigree that are not genotyped.
In my case removed the not-genotyped animals through the UNIX command line.

@Agustinopulus I see. This makes more sense. AlphaImpute2 is a new project with a completely different codebase! But as you say, this can be manged in multiple ways.


Longer UIDs without existing lookup

Problem:
Our UIDs were too short.
Fix:
I made them longer
Commit Details: (< vv pls delete this section if's not relevant)

Took each UID
Added characters
Put it back

Manual Tests:
I hereby swear that:

[ ] the UIDs are longer
[ ] I have not created duplicate UIDs

Fixes #[ticket_number] (<< pls delete this line if it's not relevant)

closing for now, will revisit later


Missing override on text label

Just noticed that the label "preview" in the NFT creation form doesn't include the typography override to use the serif font (used on the other label).

Closing this issue as this won't be prioritized


PartitionKey: Fixes NullRef in toString handling for None for PartitionKey.ToString()

Pull Request Template
Description
Missing ToString() handling for PartitionKey.None results in NullRef Exception as opposed to more useful content.  Breaks some logging scenarios.  Identified by @ray2k.
This bugfix is similar to the one merged from: #3480
Type of change
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)

Closing issues

Obligatory comment to boost visibility on this if possible. This breaks any kind of instrumentation that logs partition keys which is annoying to work around.

/azp run

/azp run


HDFS-17282. Reconfig 'SlowIoWarningThreshold' parameters for datanode.

Description of PR

The threshold related to SlowNodes is https://issues.apache.org/jira/browse/hdfs-16396 dynamic reconfig is supported in, SlowLogThreshold also needs to support reconfig to easily dynamic adjustment of log output on DN.
The cost of rolling up DN increases and requires a longer time.

How was this patch tested?
Add Unit Test.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 47s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
47m 32s

trunk passed

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 13s

trunk passed

+1 :green_heart:
mvnsite
1m 23s

trunk passed

+1 :green_heart:
javadoc
1m 10s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 41s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 20s

trunk passed

+1 :green_heart:
shadedclient
39m 37s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 15s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 15s

the patch passed

+1 :green_heart:
compile
1m 10s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
1m 10s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  2s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 110 unchanged - 1 fixed = 112 total (was 111)

+1 :green_heart:
mvnsite
1m 15s

the patch passed

+1 :green_heart:
javadoc
0m 57s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 32s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 22s

the patch passed

+1 :green_heart:
shadedclient
40m 36s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
255m  4s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 53s

The patch does not generate ASF License warnings.

407m 53s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6338/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6338

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 8fdef4b916e7 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0c5bfe219f70ea4367a63c2683cb0e85771ab7fd

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6338/1/testReport/

Max. process+thread count
2599 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6338/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Hi @ayushtkn, Please help review this pr when you are available, Thanks.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
48m 29s

trunk passed

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 14s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
1m 22s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 40s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 20s

trunk passed

+1 :green_heart:
shadedclient
40m 13s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
compile
1m  8s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
1m  8s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  1s
/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 110 unchanged - 1 fixed = 112 total (was 111)

+1 :green_heart:
mvnsite
1m 12s

the patch passed

+1 :green_heart:
javadoc
0m 55s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 27s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 21s

the patch passed

+1 :green_heart:
shadedclient
39m 35s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
252m 31s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 57s

The patch does not generate ASF License warnings.

405m 29s

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6338/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6338

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux d49067a1bb66 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / d6655b99df73ae4792fa99726123148d662bbc13

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6338/2/testReport/

Max. process+thread count
2273 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6338/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 48s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
detsecrets
0m  0s

detect-secrets was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
49m 58s

trunk passed

+1 :green_heart:
compile
1m 21s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
compile
1m 13s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
checkstyle
1m 11s

trunk passed

+1 :green_heart:
mvnsite
1m 21s

trunk passed

+1 :green_heart:
javadoc
1m  9s

trunk passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 36s

trunk passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 19s

trunk passed

+1 :green_heart:
shadedclient
39m 33s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 11s

the patch passed

+1 :green_heart:
compile
1m 14s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javac
1m 14s

the patch passed

+1 :green_heart:
compile
1m  7s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
javac
1m  7s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  2s

hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 110 unchanged - 1 fixed = 110 total (was 111)

+1 :green_heart:
mvnsite
1m 14s

the patch passed

+1 :green_heart:
javadoc
0m 56s

the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04

+1 :green_heart:
javadoc
1m 31s

the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~20.04-b08

+1 :green_heart:
spotbugs
3m 20s

the patch passed

+1 :green_heart:
shadedclient
40m 56s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
251m 23s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

406m 10s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6338/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/6338

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets

uname
Linux 9875ddf1dc0b 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 1afb4e31b6dc9c8d837205cca741e018325de4f7

Default Java
Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6338/3/testReport/

Max. process+thread count
2107 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6338/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.


TRG 7.02 License and copyright header

guess you modified the chart file before releasing so an update for the year of copyright is needed.
https://github.com/eclipse-tractusx/vas-country-risk/blob/bc123370e27fbe4609d78e43a1986c964996ebbf/charts/country-risk/Chart.yaml#L2
https://github.com/eclipse-tractusx/vas-country-risk/blob/bc123370e27fbe4609d78e43a1986c964996ebbf/charts/country-risk/charts/country-risk-backend/Chart.yaml#L2-L3

Info from @fabiodmota:
But also this as already the fixes on the header copy right , because i had already updated the main branch after the 3.0.9 release that you are evaluating .
https://github.com/eclipse-tractusx/vas-country-risk/blob/a0084e53ad56f9524f779f4a81b73c416d1e8e3f/charts/country-risk/values.yaml#L2C1-L2C39


[DO NOT MERGE] Test Travis

Travis didn't run a build for https://github.com/bitcoinops/bitcoinops.github.io/pull/366. Testing whether it'll pick up the same branch in a different PR.

This unblocked Travis


Release of 2.16.0

I have plan to release next version in a few days - 1 - 2 of June
List of issues and PR: https://github.com/mojohaus/versions/milestone/14?closed=1

No #966?


Classic Controller or GameCube Controller support.

I know nothing about coding or GitHub but I loved you app. I just want to request a a feature that lets you switch between Wii Classic Controller or GameCube Controller and the Wiimote and works on the DSU API.
Thank You! (I had no idea how else to reach out to you so this was the best way).

Button layout for Classic Controller was added in v0.4.0. It's not very ergonomic imo, if you have any suggestion please let me know.


clean up bert related code for nlu model

Description
This PR is for cleaning up Bert related code for NLU model. Instead of rewriting, I directly import it from huggingface transformers. Besides, I removed all modules not used in our model for minimal realization.
Type of change
Please check the options that are relevant.

[ ] Bug fix (non-breaking change that fixes an issue)
[ ] Proposes a change (non-breaking change that isn't necessarily a bug)
[x] Refactor
[ ] New feature (non-breaking change that adds a new functionality)
[ ] Breaking change (fix or feature that would break some existing functionality downstream)
[ ] This is a unit test
[ ] Documentation only change
[ ] Datasets Release
[ ] Models Release

Type of requested review

[x] I want a thorough review of the implementation.
[ ] I want a high level review.
[ ] I want a deep design review.

Before and After
The general change:

model_output.py: remove this file since everything can be imported from transformers.
modeling_outputs.py: remove this file since everything can be imported from transformers.
modeling_utils.py: remove this file since everything can be imported from transformers.
modeling_bert.py: keep needed and remove modules not been used.
decoder_with_loss.py: directly import BertOnlyMLMHead from transformers.

I also update config.yml and requirement to use new docker image and fix the failed unit test caused by wrong version of norfair library.
Testing
To check the training process, run
python tools/nsp_scripts/train_model.py --batch_size 32 --data_dir droidlet/artifacts/datasets/annotated_data/ --dtype_samples 'annotated:1.' --tree_voc_file droidlet/artifacts/models/nlu/ttad_bert_updated/caip_test_model_tree.json --output_dir ./test_outputs --num_epochs 3

Checklist:

[x] I have performed manual end-to-end testing of the feature in my environment.
[ ] I have added Docstrings and comments to the code.
[ ] I have made changes to existing documentation where needed.
[ ] I have added tests that show that the PR is functional.
[ ] New and existing unit tests pass locally with my changes.
[ ] I have added relevant collaborators to review the PR before merge.
[ ] [Polymetis only] I ran on hardware (1) all scripts in tests/scripts, (2) asv benchmarks.

I'm relying heavily on @aszlam's review on this since this was added back in the day when Yacine and Rebecca were committing to this folder.
Also, can you look into why the locobot tests are failing ?

It was caused by out-of-date version of transformer. I will build a new docker image and upload to docker hub this afternoon.

-Is there a reason some of the bert related files have been deleted here ? (modeling_output, utils etc)

All deleted files are directly copied from Transformers and have no changes. The plan says "importing lots of things that can be pulled directly from huggingface transformers, rather than rewriting". I am not sure if I should keep these files. I will ask Arthur for details.


DynamicMap and exceptions

DynamicMap runs a generator function. When that function encounters an exception, the DynamicMap stops, but is does not show the original exception, but a stop iteration instead. The DynamicMap should also show the original exception.

The generator mode for DynamicMaps is now deprecated, so there's no longer any need to handle this.


Trouble with Endianness

Probably the same issue as #1422
I have a definition for a MOV instruction that I've had to define as follow:
:MOV [rs+imm3],rd is (op2_7=0x4d & rd & rs & imm3) {
*:1 (rs+imm3) = rd[24,8];
}
It's the same situation as in the other issue issue.  Big endian instruction decode, Little endian memory.  In ldefs I've set endian="little", and instructionEndian="big". In the sinc I've done define endian=big.  This largely works, as instructions are fairly straightforward to implement, and Ghidra treats multibyte data in the memory correctly.  The above makes the decompiler use the right byte of the register.
My question really then, is this going to cause any issues for me down the line where bytes might be in the wrong order? Should I instead treat the whole thing as little endian, and just do the combine myself when I have multibyte values in instructions?

I had originally thought this was an issue with how SUBPIECE works, as the docs say that is the p-code equivalent to :x, (x) and [x,n], however the compiled sla seems to do it entirely with STORE, not using SUBPIECE at all.

@tahg how did you get it working this far? I spent some time playing the endianness flags and giving up after a while but without getting anywhere, really.

The data endianess in ldefs must match the slaspec 'set endian'.  The ldef instruction endianess setting is a runtime indicator which impacts instruction token byte ordering only.  I believe you should use 'set endian=little' in the slaspec.

Is this still an issue for you?  Can this ticket be closed?


Dialog is 100% transparent when upgrading to RC dialog

I'm submitting a bug report

Library Version:
<EMAIL_ADDRESS>and rc.1.0.3

Please tell us about your environment:

Operating System:
Windows 10

Node Version:
6.2.0

NPM Version:
3.8.9

JSPM OR Webpack AND Version
JSPM 0.16.32

Browser:
Chrome

Language:
ESNext

Current behavior:
Expected/desired behavior:
When upgraded from Beta Dialog to RC dialog all dialog views are now 100% transparent.
When I revert to Beta dialog<EMAIL_ADDRESS>everything works.
There is some problem with opacity.

Did you update the custom elements names accordingly(ai- => ux-)? Also if you have custom styles you'll have to update all places where you have ai-.

So @StrahilKazlachev this is breaking change? I need in all my custom elements update:

<ai-dialog-footer
to appropriate ux variants such as ux-dialog right?
Did not noticed this is breaking change sorry. I will close this ticket now.


Correctly create QueryBuilder with $indexBy parameter

1. Why is this change necessary?
It provides ability to created indexed queries with Shopware'e ModelRespoitory
2. What does this change do, exactly?
Minor fix which allows to use $indeBy in QueryBuilder in case of repositories based on Shopware's ModelRepository.
3. Describe each step to reproduce the issue or behaviour.
Create query builder in shopware's repository using second parameter - it will be disregarded.
4. Please link to the relevant issues (if any).

5. Which documentation changes (if any) need to be made because of this PR?

6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Please fill out our pull request template, same rules for every contributor. 😃
https://developers.shopware.com/contributing/contribution-guideline/

I've updated the description in accordance to the guidline.

Ping @mitelg
This is pretty straightforward fix - is there any issue with it?

ping @shopwareBot

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-20476
Please use this issue to track the state of your pull request.

Hi @xrogers
thank you for the PR! We have reviewed your changes and they will be merged soon.
We wish you a merry christmas.


ACLs do not work inside containers

hey,
I run the following script:
#!/bin/bash

getfacl .

setfacl -d -m u::rwx,g::rwx,o::rwx .
setfacl -m u::rwx,g::rwx,o::rwx .

getfacl .

mkdir test

ls -al

On Linux Fedora, installed on bare metal with ext4 as file system, I get:
# file: .
# owner: me
# group: me
user::rwx
group::rwx
other::rwx

# file: .
# owner: me
# group: me
user::rwx
group::rwx
other::rwx
default:user::rwx
default:group::rwx
default:other::rwx

total 24
drwxrwxrwx+  3 me me 4096 Aug  3 14:19 .
drwxrwxr-x. 19 me me 4096 Aug  3 14:10 ..
-rw-rw-r--.  1 me me  126 Aug  3 14:18 full.sh
drwxrwxrwx+  2 me me 4096 Aug  3 14:19 test

With a Fedora base image on boot2docker, MacOS X as a base system, I get:
# file: .
# owner: root
# group: root
user::rwx
group::rwx
other::rwx

# file: .
# owner: root
# group: root
user::rwx
group::rwx
other::rwx
default:user::rwx
default:group::rwx
default:other::rwx

total 24
drwxrwxrwx+  3 root root 4096 Aug  3 14:19 .
drwxrwxr-x. 19 root root 4096 Aug  3 14:10 ..
-rwxrwxrwx.  1 root root  126 Aug  3 14:18 full.sh
drwxr-xr-x+  2 root root 4096 Aug  3 14:19 test

Mind the difference in access rights on test, as reported by ls. It seems that Access Control Lists do not work here.
boot2docker uses AUFS, I observed the same with OverlayFS and a Fedora host system. It does work with device mapper and a fedora host. Is this a file system bug, e.g. a bug in AUFS/OverlayFS or is it a docker bug?

Hi!
Please read this important information about creating issues.
If you are reporting a new issue, make sure that we do not have any duplicates already open. You can ensure this by searching the issue list for this repository. If there is a duplicate, please close your issue and add a comment to the existing issue instead.
If you suspect your issue is a bug, please edit your issue description to include the BUG REPORT INFORMATION shown below. If you fail to provide this information within 7 days, we cannot debug your issue and will close it. We will, however, reopen it if you later provide the information.
This is an automated, informational response.
Thank you.
For more information about reporting issues, see https://github.com/docker/docker/blob/master/CONTRIBUTING.md#reporting-other-issues

BUG REPORT INFORMATION
Use the commands below to provide key information from your environment:
docker version:
docker info:
uname -a:
Provide additional environment details (AWS, VirtualBox, physical, etc.):
List the steps to reproduce the issue:
1.
2.
3.
Describe the results you received:
Describe the results you expected:
Provide additional info you think is important:
----------END REPORT ---------
#ENEEDMOREINFO

I don't believe AUFS supports ACLs... I would be surprised if overlayfs supported them.

Yeah, not sure about overlayfs, but I don't think AUFS supports this; https://github.com/docker/docker/issues/1070#issuecomment-20624664 and https://github.com/docker/docker/issues/1070#issuecomment-22206125

@alexkamp I'm going to close this issue, because I don't think there's anything Docker can do here, but feel free to comment here after I've closed this :+1:

Just to be sure I understand here:  If I'm running Docker for Mac, does this mean I can't use, inside a container, any software that relies on ACLs?  That seems like the upshot of this conversation, and a pretty significant restriction.  Do I understand correctly?


State of JS 2021 keeps geting 504 Gateway Time-out

I've been trying to access State of JS on different days but still I'm always getting a 504 Gateway Timeout error everytime I try to access the survey.

Sometimes it seems it works fine but suddenly I get again the blank page. :(

Seems, it is not only about 504

The response times from the graphql endpoint appear to increase over a sessions lifetime before continuously timing out.

It's a memory issue with the server when it's under high load. Not much I can do right now besides restart it; but we're in the process of migrating to a better stack.


[BUG] FAISS IVF PQ training throws action_request_validation_exception when nlists parameter is specified

What is the bug?
Specifying any value for nlists (even default value of 4) during training of FAISS IVF-PQ model throws an error
How can one reproduce the bug?

I have ~100K 384d vectors in train-index
Try to train the modelPOST /_plugins/_knn/models/my-model/_train
{
  "training_index": "train-index",
  "training_field": "train-field",
  "dimension": 384,
  "description": "My models description",
  "method": {
      "name":"ivf",
      "engine":"faiss",
      "space_type": "l2",
      "parameters":{
        "nlists": 2048,
        "nprobes": 128,
        "encoder":{
            "name":"pq",
            "parameters":{
                "code_size": 8,
                "m": 8
            }
        }
      }
  }
}

Error!{
  "error" : {
    "root_cause" : [
      {
        "type" : "action_request_validation_exception",
        "reason" : "Validation Failed: 1: Invalid parameter for method \"ivf\".;"
      }
    ],
    "type" : "action_request_validation_exception",
    "reason" : "Validation Failed: 1: Invalid parameter for method \"ivf\".;"
  },
  "status" : 400
}

Removing the nlists specification from parameters works without error

What is the expected behavior?
Model should train with nlists parameter specified
What is your host/environment?

OS: Docker (https://opensearch.org/samples/docker-compose.yml)
Version: 1.3.2

Do you have any screenshots?
NA
Do you have any additional context?
NA
Any help is highly appreciated!

Hi @stephenleo , oops I think this is a documentation bug. The parameter is nlist, not nlists.
Ill go ahead and open an issue to fix it here: https://opensearch.org/docs/latest/search-plugins/knn/knn-index/#ivf-parameters

Cloising in favor of https://github.com/opensearch-project/documentation-website/issues/669. PR has been submitted.


More papers to upload

See email titled "Please upload"
Modeling and Control of Multi-Energy Dynamical Systems: Hidden Paths to Decarbonization
https://www.sciencedirect.com/science/article/pii/S037877962200654X
Also the attached paper to appear in
Women in Power: Research and Development Advances in Electric Power Systems.
(Edts: Jill Tietjen, Marija ilic and Lina Bertling Tjernberg), Springer Nature 2022, Cham, Switzerland.
https://www.dropbox.com/s/wh0ix8210t707ew/Ilic_WomeninPower_08012022.pdf?dl=0

duplicate of #70


[Enhancement]upadte gptneox convert script

Let the model conversion script of GPTNeoX be applicable not only to GPTNeoX-20B but also to all model files trained using GPTNeoX 1.X.

Can you provide a checkpoint to verify the correctness of the modification?

Can you provide a checkpoint to verify the correctness of the modification?

Sorry, the checkpoint I used to verify the script cannot be provided.
Maybe later, when I find some appropriate checkpoint files.


[Feature] SGLang using  JSON as template config file needs improve

Checklist

[X] 1. If the issue you raised is not a feature but a question, please raise a discussion at https://github.com/sgl-project/sglang/discussions/new/choose Otherwise, it will be closed.
[X] 2. Please use English, otherwise it will be closed.

Motivation
{
"name": "my_model",
"system": "<|im_start|>system",
"user": "<|im_start|>user",
"assistant": "<|im_start|>assistant",
"sep_style": "CHATML",
"sep": "<|im_end|>",
"stop_str": ["<|im_end|>", "<|im_start|>"]
}
this is not general , I think jinja is more popular such as huggingface tgi、vllm、interlm、QWEN， they all use jinjia as the chat template, this JSON format really needs to impove, no needs to build another wheel, right?
Related resources
No response

ref https://github.com/sgl-project/sglang/pull/1104


ClrStaticTypeWrapper.PopulateMembers method exposes only declared members at the specified type

ClrStaticTypeWrapper.PopulateMembers method is incorrectly including BindingFlags.DeclaredOnly to get the type members. The consequence it is now impossible to use members inherited by the type in JS.

It's likely this code is either going away, or at least moved into a separate package, so I'm not going to make any changes to ClrStaticTypeWrapper for the forseeable future.  I'll keep the issue open in case I reconsider.

Paul,
I would recommend you preserve the support for CLR in Jurassic. This is a one of the biggest benefits compared to other JS engines like V8 where support for the CLR is unlikely or will most probably be much slower. The ability to use CLR is beneficial in cases where there is no easy support for particular functionality in JS. Case in point : working with RSA keys and and signature generation.
There is JS project in development, but it is terribly huge and incomplete.


Anerdw: Watch watchshopbd.com

Anerdw requests the watch of the watch_keyword watchshopbd\.com. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

watchshopbd\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Cow in Charcoal HQ


Introduce keywords for actions to filter on (for 4679)

@alexandrudima maybe you could give me some feedback on https://github.com/Microsoft/vscode/pull/5432/commits/eebd22d93e82aa03e635e74ae8134d8159c8905b
The motivation is to be able to provide an array of keywords when registering an editor action so that we have means to find the action in the command palette in addition to the label of the action. We can then pass in english (non translated) words to fix https://github.com/Microsoft/vscode/issues/4679

@bpasero just small suggestion, you can use #4679 instead of 4679 to have a reference/link on pull request and commit history.

👍

no unit tests?


Unable to setup (leap-cross-window)

Hi,
I haven't been able to setup bidirectional search.
My config
require('leap')
vim.keymap.set({'n', 'x', 'o'}, 's', "(leap-cross-window)")
Error I get when i try to use this mapping "no targetable windows"
how do I set up bidirectional search?

See FAQ. On the right hand side you should use function () require('leap').leap { target_windows = { vim.fn.win_getid() } } end.  There is no predefined <Plug> key for bidirectional search in the current window (<Plug>(leap-cross-window) jumps to the other windows on the tab page).
P.S.: No need to require('leap') if you don't want to set something in the opts table.

Thank you


Ignore .eslintcache

Add .eslintcache to .gitignore file to disables its tracking. This file is unnecessary in the git tree.
Reference: https://github.com/facebook/create-react-app/issues/10161

I've added it only to the root since the templates don't come with ESLint. Should we also ignore it on the templates?

I've added it only to the root since the templates don't come with ESLint. Should we also ignore it on the templates?

This is honestly user-dependant if they use eslint.
It's like adding .vscode, .vs, .gitkraken or any other tool that creates a directory/files.
The user should add the products of their tools to the .gitignore

This is honestly user-dependant if they use eslint.
It's like adding .vscode, .vs, .gitkraken or any other tool that creates a directory/files.
The user should add the products of their tools to the .gitignore

@dudeisbrendan03 I agree that it's user-dependant on the template, but the root repo comes with ESLint

@dudeisbrendan03 I agree that it's user-dependant on the template, but the root repo comes with ESLint

@dudeisbrendan03 I agree that it's user-dependant on the template, but the root repo comes with ESLint

See your point

@dudeisbrendan03 I agree that it's user-dependant on the template, but the root repo comes with ESLint

See your point

I think this has already been solved (but not yet released) in #9977

I think this has already been solved (but not yet released) in #9977

Thanks @LauraBeatris, we've actually made the decision to move this cache so it won't clutter your directory anymore... look out for that in the next release!
See https://github.com/facebook/create-react-app/pull/9977

Thanks @LauraBeatris, we've actually made the decision to move this cache so it won't clutter your directory anymore... look out for that in the next release!
See https://github.com/facebook/create-react-app/pull/9977


Make logging outputs configurable.

I'm assuming this pull request was created by mistake. If not, reply back.


[main] Upgrade to latest dependencies

Cron -knative-prow-robot
/cc knative-sandbox/eventing-writers
/assign knative-sandbox/eventing-writers
Produced by: knative-sandbox/knobots/actions/update-deps

/retest

@matzew @aliok would you mind taking a look at this? :pray:

It goes back to 0.36.7, b/c
go: finding module for package knative.dev/eventing/test/rekt/resources/svc
go: finding module for package knative.dev/eventing/test/test_images/heartbeats
go: found knative.dev/eventing/test/test_images/heartbeats in knative.dev/eventing v0.36.7
go: found knative.dev/eventing/test/rekt/resources/svc in knative.dev/eventing v0.36.7

than, when I do something like:
knative.dev/eventing v0.36.7-0.20230414062450-43a255466a78

I see again that the patch does not apply, which is addressed here: https://github.com/knative-sandbox/eventing-kafka-broker/pull/3039

/close
replaced by #3041


Proposal: more flexible argument extraction and signature testing

This started out as a more general fix for #643 but it has evolved into a larger refactor with a number of open questions, so I'm submitting it as a draft PR initially for discussion:
Overview
Issue #643 discusses the idea of verifying a signature that was computed over something other than just the request body content, and the related PR #644 provides an implementation of one special case of this general idea, concatenating one or more request header values to the end of the body data before calculating the signature.  However there are many variations on this theme, for example

#455 talks about validating (rather complex) signatures over a string built up from several different request headers
#512 the HMAC is computed over the body data but the signature value that you compare with has to be extracted as a substring of one of the request headers, not the whole header value.
#336 and #601 are not about signatures but still ask for a way to combine different parts of the payload into a single argument extraction

In this PR I've tried to come up with a general way to support cases like those as well.
The implementation is in two parts:

I've introduced a new Argument type "source": "template", where the argument value is computed by evaluating a Go template against a context derived from the Request.  This lets you combine values from different headers, take substrings, etc.
I've refactored the various payload-hmac-* "match" rules into a new "check-signature" rule type, which gives the option to use an Argument for the "string-to-sign" as well as the one for the reference signature value.

Together these let you compute signatures over any combination of the body, headers and query parameters, concatenated together with no delimiter, newlines, colons, etc. as required by your particular webhook sender.
Template argument type
- source: template
  name: |
    {{- .BodyText -}}:{{- .GetHeader "x-request-id" -}}

The template argument type evaluates a Go template to build the argument value.  The template context gives access to all the things that the other argument types provide, including

the raw payload (.Body as a []byte, .BodyText as a string)
the parsed JSON/XML payload (.Payload)
URL query parameters (.Query)
request headers (the raw map as .Headers, but also the .GetHeader "name" function in the example above that canonicalises the header name the same way as a "source": "header" argument would do)
webhook's own request ID (.ID)
the remote address, content type and request method (.RemoteAddr, .ContentType and .Method)

I've deliberately not exposed the whole of the RawRequest from the internal Request struct.
The check-signature rule type
I've refactored all the payload-hmac-sha1/256/512 match types into a new kind of rule.  The old
{
  "match":
  {
    "type": "payload-hmac-<type>",
    "secret": "secret",
    "parameter":
    {
      "source": "header",
      "name": "X-Signature"
    }
  }
}

is now expressed as
{
  "check-signature":
  {
    "algorithm": "<type>",
    "secret": "secret",
    "signature":
    {
      "source": "header",
      "name": "X-Signature"
    }
  }
}

However, as well as "algorithm", "secret" and "signature", you can now specify "string-to-sign" as another argument, which could be a simple argument like a single header
{
  "check-signature":
  { "algorithm": "sha256", "secret": "secret",
    "signature":
    {
      "source": "header",
      "name": "X-Signature"
    },
    "string-to-sign":
    {
      "source": "header",
      "name": "Digest"
    }
  }
}

or it could be a template argument like the example above
- check-signature:
    algorithm: sha256
    secret: my-secret
    signature:
      source: header
      name: x-signature
    string-to-sign:
      source: template
        name: |
          {{- .BodyText -}}:{{- .GetHeader "x-request-id" -}}

Backwards compatibility
I've made sure that existing hooks files (YAML and JSON) will still parse as before, with the payload-hmac-* match rules being converted to check-signature rules during the loading process.  The only wrinkle is if you want to start using templates in arguments and you need to parse the hooks file itself as a template, then it can get quite fiddly to escape the runtime templates from the parse-time engine.  To mitigate this I've added a -template-delims CLI option to change the delimiters used for the parse-time template engine, so you can say -template-delims='[[,]]' and then use [[ getenv "..." ]] for the parse-time template and {{ .GetHeader "..." }} for the runtime ones.

Open questions for discussion
Are Go Templates the right paradigm?
Go templates are very flexible, but should we stick with something simpler and with fewer gotchas around whitespace handling etc.?  #512 mentions cel-go as an alternative.
Template context
Is the template context appropriate?  Are there other things we could/should expose to the templates, or more sensible names for the things that are already there?
Do we want to add some more useful functions to the template engine?  One extreme would be to introduce something like Sprig, the same function library used by Helm.  This includes functions for things like date parsing and formatting, which would also open up a way to use template arguments to check things like "is the Date header less than 15 minutes old":
- match:
    type: "value"
    value: "true"
    parameter:
      source: template
      name: |
        {{- (.GetHeader "date" | toDate "Mon Jan 2 15:04:05 MST 2006").After (now | dateModify "-15m") -}}

Though something like that probably deserves its own dedicated rule type.

I haven't had much time to commit to webhook in a while, but this PR got my attention.  Kudos for making a great PR and explaining the situation well.
Regarding templates, see this discussion.  I feel like HCL is probably too complex and may hem us in in some areas.  For purely adding a template language to our existing configs, I'd vote for expr.  See what you think about it.
I'm curious if we could solve the various hmac scenarios with templates instead of extending the config schema with the check-signature and string-to-sign stuff.  I like the simplicity of the existing schema and am not against extending it to make it easier on the end users, but some of these hmac requirements are pretty complex.  I'd recommend thinking through the template feature more to see how far it can take us.

Iterating on this idea using expr while trying to stick with the match model:
# Assumes the hmac() function could derive the hash function and secret from the match stanza.
- match:
    type: hmac-sha256
    secret: secret
    parameter:
      source: expr
      name: |
        hmac($bodyText + ":" + getHeader("x-request-id")) == trimPrefix(getHeader("x-signature"), "sha256:")

- match:
    type: value
    value: true
    parameter:
      source: expr
        name: |
          date(getHeader("date")) > now() - duration("15m")

I've been wanting to implement this for a while now, but never got the necessary focus time...
I agree with @moorereason that some generic expressions format would be a more human readable format compared to Go templates, but either way it would be a long awaited huuuge improvement to webhook.
At my full time job, I used to work a lot with mapbox mapping SDK which includes expressions for data styling, the bottom line is that it was very simple to learn and very powerful to use. Here's a documentantion page for those, maybe it could serve as a source of inspiration for this.

Thanks for the feedback.  I haven't forgotten about this - I do like the look of expr and I intend to see if I can re-work this PR to use that instead of text/template, but this is a personal project rather than a work-related one so I may not have time to do it properly until nearer Christmas.

Thanks for the feedback. I haven't forgotten about this - I do like the look of expr and I intend to see if I can re-work this PR to use that instead of text/template, but this is a personal project rather than a work-related one so I may not have time to do it properly until nearer Christmas.

Of course :-) Happy holidays!


Support changing the PUID/PGID

+1 for this please, I would love to be able to run this as nobody instead of root

I will see if I get it running, in best case it will only require changes in the nginx.conf, some chown commands and a user switch in the start.sh

@dontcrash can you please test #246 ?

@dontcrash can you please test #246 ?

Seems to work ok! No more root :D

merged it into develop, please test again

I‘ve pushed it to latest

Works fine on my Ubuntu server, tried it on Mac for funsies but the nobody account is -2, unsure if this is a Mac specific quirk that can be addressed by making a new user with no shell, no login etc and a >0 integer or if accepting negative integers would solve it

Please disregard, I was doing something definitely non-standard!

No issue :)

@dontcrash but one question for my interests, how did you found my fork?

I was looking for a version of npm that didn't use a version of OpenSSL from three years ago, and a version of nginx from a year ago!


[BUG] Updating to 1.4.3 breaks production build with Vite rollup error

Describe the bug
I updated to @shopify/hydrogen 1.4.3 from 1.4.2., and I'm getting the following error on production builds via Github Actions:
$ shopify hydrogen build --target node
[STARTED] Building node code
vite v2.9.15 building SSR bundle for production...
transforming...
✓ 38 modules transformed.
[vite]: Rollup failed to resolve import "/app/dist/client/index.html?raw" from<EMAIL_ADDRESS>This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`
[FAILED] [vite]: Rollup failed to resolve import "/app/dist/client/index.html?raw" from<EMAIL_ADDRESS>[FAILED] This is most likely unintended because it can break your application at runtime.
[FAILED] If you do want to externalize this module explicitly add it to
[FAILED] `build.rollupOptions.external`

━━━━━━ Error ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
    [vite]: Rollup failed to resolve import "/app/dist/client/index.html?raw" from<EMAIL_ADDRESS>    This is most likely unintended because it can break your application at runtime.
    If you do want to externalize this module explicitly add it to
    `build.rollupOptions.external`

To Reproduce

Create a production build, in my case, via Github Actions using ubuntu-latest as the build container.

Additional context
Add any other context about the problem here. eg.

Hydrogen version: 1.4.3
Docker image: ubuntu-latest

The only thing that changes from 1.4.2 to 1.4.3 is some implementation details of the Cart component so this might not be related to the version.
Can you try using Node 18 and making sure node_modules is not cached?
Also, can you check if /app/dist/client/index.html file exists after this error? It should be created during the build but before throwing this error.

I am having a similar issue. It was happening with @shopify/hydrogen 1.2.0, so I upgraded to 1.4.3, which did not change anything. I have no issues building locally, but the deploy with oxygen and github actions fails every time.

@diemonster Thanks for the tip, but sadly that doesn't seem to be the issue for me...
@frandiox Ive updated to use Node 18, nothing is being cached and my .../dist/client/index.html exists although it does not have the script tag with the entry-client module like my project's index.html does... Any other ideas?
For completeness, I'm attaching my errors along with my GitHub workflow file.
🛠 Building the application...
yarn run v1.22.19
$ shopify hydrogen build
[STARTED] Building worker code
vite v2.9.15 building SSR bundle for production...
transforming...
✓ 2 modules transformed.
[vite]: Rollup failed to resolve import "/home/runner/work/pax-shopify-hydrogen/pax-shopify-hydrogen/dist/client/index.html?raw" from<EMAIL_ADDRESS>This is most likely unintended because it can break your application at runtime.
If you do want to externalize this module explicitly add it to
`build.rollupOptions.external`
[FAILED] [vite]: Rollup failed to resolve import "/home/runner/work/pax-shopify-hydrogen/pax-shopify-hydrogen/dist/client/index.html?raw" from<EMAIL_ADDRESS>[FAILED] This is most likely unintended because it can break your application at runtime.
[FAILED] If you do want to externalize this module explicitly add it to
[FAILED] `build.rollupOptions.external`

━━━━━━ Error ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
    [vite]: Rollup failed to resolve import "/home/runner/work/pax-shopify-hydrogen/pax-shopify-hydrogen/dist/client/index.html?raw" from<EMAIL_ADDRESS>
Workflow:
name: Oxygen Deployment

on:
  workflow_dispatch:
  push:

jobs:
  deploy:
    name: Deploy to Oxygen
    timeout-minutes: 30
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2

      - name: Setup node.js
        uses: actions/setup-node@v3
        with:
          node-version: '18'
          check-latest: true

      - name: Install dependencies
        id: 'install-dependencies'
        run: yarn

      - name: Build and Publish to Oxygen
        id: deploy
        uses: shopify/oxygenctl-action@v4
        with:
          path: ./
          oxygen_deployment_token: ${{ secrets.OXYGEN_DEPLOYMENT_TOKEN_65651 }}
          build_command: 'HYDROGEN_ASSET_BASE_URL=$OXYGEN_ASSET_BASE_URL yarn build'

      - name: Create GitHub Deployment
        uses: shopify/github-deployment-action@v1
        if: always()
        with:
          token: ${{ github.token }}
          environment: 'preview'
          preview_url: ${{ steps.deploy.outputs.url }}
          description: ${{ github.event.head_commit.message }}

my .../dist/client/index.html exists although it does not have the script tag with the entry-client module like my project's index.html does

That's fine, the entry-client script tag is only for development. This index.html should contain different script tags generated during the client build.

I am having a similar issue. It was happening with @shopify/hydrogen 1.2.0, so I upgraded to 1.4.3, which did not change anything. I have no issues building locally, but the deploy with oxygen and github actions fails every time.

There's some kind of mismatch between the local and the CI environment but not sure what it could be apart from what I already mentioned. You are not changing the build output path in your yarn build or in vite.config.js, right?
In any case, if you can't find what's different between the two environments, you can try this workaround. Create a new <root>/worker-entry.ts file where you manually specify the path to your files:
import handleRequest from './src/App.server'; // Path to your App.server
import indexTemplate from './dist/client/index.html?raw'; // Path to your built index.html

declare global {
  // eslint-disable-next-line no-var
  var globalThis: {
    Oxygen: {env: any};
    [key: string]: any;
  };
}

export default {
  async fetch(
    request: Request,
    env: unknown,
    context: {waitUntil: (promise: Promise<any>) => void}
  ) {
    if (!globalThis.Oxygen) {
      globalThis.Oxygen = {env};
    }

    try {
      return (await handleRequest(request, {
        indexTemplate,
        cache: await caches.open('oxygen'),
        context,
        buyerIpHeader: 'oxygen-buyer-ip',
      })) as Response;
    } catch (error: any) {
      return new Response(error.message || error.toString(), {status: 500});
    }
  },
};

Then, change the build command to shopify hydrogen build --entry worker-entry.
Since you are manually resolving the path to your files, you should not see the index.html not found issue (as long the paths in this file are correct).

EvalError: Code generation from strings disallowed for this context

Yeah that doesn't sound like anything familiar in Hydrogen 🤔
Closing this issue since the main problem seems to be solved 👍


Mark Style/StringHashKeys as unsafe autocorrect

We noticed that this auto-correction by this cop can cause bugs
where strings are explicitly expected as hash keys.

Before submitting the PR make sure the following are checked:

[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

Here the entire cop is unsafe, not just it's auto-correct.

@bbatsov Yep I have updated the code to mark it as unsafe.