unsupported type for out/i686-nodeos-linux-musl/bin/ld (link)

I'm trying to addapt NodeOS cross-toolchain to use prebuild images, main issue here is that I'm not using node-gyp but instead I'm generating the toolchain with some bash scripts. So far, I've managed to create a node-gyp and prebuild compatible tar.gz file, but when trying to install that prebuild image I get unsupported type for out/i686-nodeos-linux-musl/bin/ld (link) as error.
Are symbolic links not valid files for prebuild? Why? How can I be able to fix this? I've not uploaded my changes because they are not yet ready and also I'm waiting for prebuild-install so I can be able to use my own generate script instead of node-gyp, but if you want I can be able to upload them before that.

I've investigated a bit, and if I'm not wrong it's not a problem of prebuild but instead of tar-fs not allowing entries of type link. Any idea?

I've done a pull-request to fix the problem with tar-fs, now I've got an error directly related to prebuild (I've updated the issue title).
I'm getting the error Missing .node file in archive. Reviewing the code I've seen that it check for an entry on the tar file with the extension .node to consider it valid, and since I'm not packaging a Node.js compiled module I don't have any of them. Seems there's the option to define an updateName function, but since the check is against a global private variable this is useless. What we can do here? Maybe add an option to explicit tell him the location of the binary? Is there any other idea?

I think maybe we are taking a bad approach here. Why would we need to check if the archive file is valid after downloading it? We are going to download the tar.gz using prebuild, the user don't need to know anything about it since he will not download it by hand, so we don't need to check for its validity after download, in that case maybe we should do it before uploading it, isn't it?

Download is not done by prebuild-install module, clossing.


ray-tracing captures are not tracked correctly

When trimming, in state tracking (before the frame range) we write out the buffer contents for an AS directly rather than writing commands to recreate the AS in the state setup block.  This is not guaranteed to work and I'm surprised that we sometimes see it succeed.

I closed above issue as duplicate, but still it contains very valuable insights:
It appears that gfx-reconstruct is relying on the opaque capture address obtained from vkGetDeviceMemoryOpaqueCaptureAddress to infer the corresponding vkDeviceMemory for a given address retrieved from vkGetAccelerationStructureDeviceAddress.
...
Opaque addresses should not be compared or offset against one another. A buffer's opaque capture address can be completely different from its BufferDeviceAddress
we need to keep in mind those address-spaces can/will be distinct.
thank you @dorian-apanel-intel for pointing that out.


[ALLUXIO-3340] support -h -s --memory --header options in du CLI

https://alluxio.atlassian.net/browse/ALLUXIO-3340

@aaudiber Thanks for the review and great suggestions! Addressed all the comments, PTAL.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/588/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/590/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/615/
Test PASSed.


Fix pack block tx order for write and readonly tx

遍历交易时，判断有没有相同key的只读或者读写交易，需要保证只读交易在读写交易前打包。

Codecov Report

Merging #304 (34947d5) into master (1eafe63) will decrease coverage by 0.07%.
The diff coverage is 26.31%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
- Coverage   45.80%   45.73%   -0.08%
==========================================
  Files         138      138
  Lines       12270    12311      +41
==========================================
+ Hits         5620     5630      +10
- Misses       5497     5530      +33
+ Partials     1153     1151       -2

Impacted Files
Coverage Δ

bcs/ledger/xledger/tx/mempool.go
29.89% <5.88%> (-0.59%)
:arrow_down:

bcs/ledger/xledger/tx/node.go
44.71% <66.66%> (+4.89%)
:arrow_up:

bcs/ledger/xledger/state/state.go
47.26% <100.00%> (ø)

bcs/consensus/tdpos/common.go
52.17% <0.00%> (-2.90%)
:arrow_down:

bcs/consensus/tdpos/tdpos.go
46.44% <0.00%> (-1.90%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eafe63...34947d5. Read the comment docs.

Codecov Report

Merging #304 (34947d5) into master (1eafe63) will increase coverage by 0.04%.
The diff coverage is 26.31%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   45.80%   45.84%   +0.04%
==========================================
  Files         138      138
  Lines       12270    12311      +41
==========================================
+ Hits         5620     5644      +24
- Misses       5497     5516      +19
+ Partials     1153     1151       -2

Impacted Files
Coverage Δ

bcs/ledger/xledger/tx/mempool.go
29.89% <5.88%> (-0.59%)
:arrow_down:

bcs/ledger/xledger/tx/node.go
44.71% <66.66%> (+4.89%)
:arrow_up:

bcs/ledger/xledger/state/state.go
47.26% <100.00%> (ø)

bcs/consensus/xpoa/xpoa.go
53.29% <0.00%> (+1.01%)
:arrow_up:

bcs/network/p2pv1/conn.go
61.22% <0.00%> (+6.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1eafe63...34947d5. Read the comment docs.

Codecov Report

Merging #304 (f0686c4) into master (dcc1e24) will increase coverage by 0.05%.
The diff coverage is 25.64%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   45.70%   45.76%   +0.05%
==========================================
  Files         138      138
  Lines       12284    12327      +43
==========================================
+ Hits         5615     5641      +26
- Misses       5514     5534      +20
+ Partials     1155     1152       -3

Impacted Files
Coverage Δ

bcs/ledger/xledger/tx/mempool.go
29.79% <5.66%> (-0.69%)
:arrow_down:

bcs/ledger/xledger/tx/node.go
44.71% <66.66%> (+4.89%)
:arrow_up:

bcs/ledger/xledger/state/state.go
47.26% <100.00%> (ø)

bcs/consensus/xpoa/xpoa.go
51.26% <0.00%> (-1.02%)
:arrow_down:

kernel/consensus/base/driver/chained-bft/smr.go
41.33% <0.00%> (+0.74%)
:arrow_up:

bcs/consensus/tdpos/tdpos.go
47.88% <0.00%> (+0.93%)
:arrow_up:

bcs/network/p2pv1/server.go
58.74% <0.00%> (+1.39%)
:arrow_up:

bcs/contract/xvm/code_manager.go
66.36% <0.00%> (+2.72%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcc1e24...f0686c4. Read the comment docs.

Codecov Report

Merging #304 (f0686c4) into master (dcc1e24) will increase coverage by 0.06%.
The diff coverage is 25.64%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   45.70%   45.77%   +0.06%
==========================================
  Files         138      138
  Lines       12284    12327      +43
==========================================
+ Hits         5615     5643      +28
- Misses       5514     5532      +18
+ Partials     1155     1152       -3

Impacted Files
Coverage Δ

bcs/ledger/xledger/tx/mempool.go
29.79% <5.66%> (-0.69%)
:arrow_down:

bcs/ledger/xledger/tx/node.go
44.71% <66.66%> (+4.89%)
:arrow_up:

bcs/ledger/xledger/state/state.go
47.26% <100.00%> (ø)

bcs/consensus/xpoa/xpoa.go
51.26% <0.00%> (-1.02%)
:arrow_down:

kernel/consensus/base/driver/chained-bft/smr.go
41.33% <0.00%> (+0.74%)
:arrow_up:

bcs/network/p2pv1/server.go
58.74% <0.00%> (+1.39%)
:arrow_up:

bcs/consensus/tdpos/tdpos.go
48.82% <0.00%> (+1.87%)
:arrow_up:

bcs/contract/xvm/code_manager.go
66.36% <0.00%> (+2.72%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcc1e24...f0686c4. Read the comment docs.

Codecov Report

Merging #304 (dbf78e3) into master (d4fb5dc) will increase coverage by 1.15%.
The diff coverage is 69.75%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   45.73%   46.89%   +1.15%
==========================================
  Files         138      138
  Lines       12295    12444     +149
==========================================
+ Hits         5623     5835     +212
+ Misses       5518     5443      -75
- Partials     1154     1166      +12

Impacted Files
Coverage Δ

bcs/ledger/xledger/tx/mempool.go
46.48% <63.77%> (+16.00%)
:arrow_up:

bcs/ledger/xledger/tx/node.go
70.41% <79.22%> (+30.59%)
:arrow_up:

bcs/ledger/xledger/state/state.go
47.26% <100.00%> (ø)

bcs/network/p2pv2/server.go
51.33% <0.00%> (-1.07%)
:arrow_down:

kernel/consensus/base/driver/chained-bft/smr.go
41.33% <0.00%> (+0.74%)
:arrow_up:

bcs/consensus/tdpos/tdpos.go
47.88% <0.00%> (+0.93%)
:arrow_up:

bcs/consensus/tdpos/common.go
55.07% <0.00%> (+2.89%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4fb5dc...dbf78e3. Read the comment docs.

Codecov Report

Merging #304 (dbf78e3) into master (d4fb5dc) will increase coverage by 1.25%.
The diff coverage is 69.75%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   45.73%   46.98%   +1.25%
==========================================
  Files         138      138
  Lines       12295    12444     +149
==========================================
+ Hits         5623     5847     +224
+ Misses       5518     5432      -86
- Partials     1154     1165      +11

Impacted Files
Coverage Δ

bcs/ledger/xledger/tx/mempool.go
46.48% <63.77%> (+16.00%)
:arrow_up:

bcs/ledger/xledger/tx/node.go
70.41% <79.22%> (+30.59%)
:arrow_up:

bcs/ledger/xledger/state/state.go
47.26% <100.00%> (ø)

bcs/network/p2pv2/server.go
51.33% <0.00%> (-1.07%)
:arrow_down:

kernel/consensus/base/driver/chained-bft/smr.go
41.33% <0.00%> (+0.74%)
:arrow_up:

bcs/consensus/tdpos/tdpos.go
48.82% <0.00%> (+1.87%)
:arrow_up:

bcs/consensus/xpoa/xpoa.go
53.29% <0.00%> (+2.03%)
:arrow_up:

bcs/consensus/tdpos/common.go
55.07% <0.00%> (+2.89%)
:arrow_up:

bcs/network/p2pv1/conn.go
61.22% <0.00%> (+6.12%)
:arrow_up:

... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4fb5dc...dbf78e3. Read the comment docs.

Codecov Report

Merging #304 (48ae6c6) into master (98a60b5) will increase coverage by 0.61%.
The diff coverage is 71.68%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   45.80%   46.41%   +0.61%
==========================================
  Files         138      138
  Lines       12299    12458     +159
==========================================
+ Hits         5634     5783     +149
  Misses       5509     5509
- Partials     1156     1166      +10

Impacted Files
Coverage Δ

bcs/ledger/xledger/tx/mempool.go
46.53% <63.04%> (+16.05%)
:arrow_up:

bcs/ledger/xledger/tx/node.go
73.37% <86.25%> (+33.54%)
:arrow_up:

bcs/ledger/xledger/state/state.go
47.26% <100.00%> (ø)

bcs/contract/native/runtime.go
13.18% <0.00%> (-50.55%)
:arrow_down:

bcs/contract/native/contract_process.go
58.82% <0.00%> (-10.09%)
:arrow_down:

bcs/network/p2pv1/conn.go
55.10% <0.00%> (-6.13%)
:arrow_down:

bcs/contract/native/process_manager.go
68.42% <0.00%> (-3.51%)
:arrow_down:

bcs/consensus/tdpos/tdpos.go
47.88% <0.00%> (-0.94%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98a60b5...48ae6c6. Read the comment docs.

Codecov Report

Merging #304 (0585d30) into master (191d55e) will increase coverage by 1.01%.
The diff coverage is 67.28%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   45.65%   46.66%   +1.01%
==========================================
  Files         139      139
  Lines       12346    12503     +157
==========================================
+ Hits         5636     5835     +199
+ Misses       5557     5497      -60
- Partials     1153     1171      +18

Impacted Files
Coverage Δ

bcs/ledger/xledger/tx/mempool.go
45.01% <55.88%> (+14.53%)
:arrow_up:

bcs/ledger/xledger/tx/node.go
73.37% <86.25%> (+33.54%)
:arrow_up:

bcs/ledger/xledger/state/state.go
47.26% <100.00%> (ø)

bcs/consensus/tdpos/common.go
52.17% <0.00%> (-2.90%)
:arrow_down:

bcs/consensus/tdpos/tdpos.go
46.94% <0.00%> (-1.88%)
:arrow_down:

bcs/consensus/xpoa/xpoa.go
52.28% <0.00%> (-1.02%)
:arrow_down:

bcs/consensus/tdpos/schedule.go
42.98% <0.00%> (-0.91%)
:arrow_down:

kernel/consensus/base/driver/chained-bft/smr.go
41.33% <0.00%> (+0.74%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 191d55e...0585d30. Read the comment docs.

Codecov Report

Merging #304 (0585d30) into master (191d55e) will increase coverage by 1.13%.
The diff coverage is 68.66%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   45.65%   46.78%   +1.13%
==========================================
  Files         139      139
  Lines       12346    12503     +157
==========================================
+ Hits         5636     5850     +214
+ Misses       5557     5482      -75
- Partials     1153     1171      +18

Impacted Files
Coverage Δ

bcs/ledger/xledger/tx/mempool.go
45.46% <58.08%> (+14.98%)
:arrow_up:

bcs/ledger/xledger/tx/node.go
73.37% <86.25%> (+33.54%)
:arrow_up:

bcs/ledger/xledger/state/state.go
47.26% <100.00%> (ø)

bcs/consensus/xpoa/xpoa.go
52.28% <0.00%> (-1.02%)
:arrow_down:

bcs/consensus/tdpos/schedule.go
42.98% <0.00%> (-0.91%)
:arrow_down:

kernel/consensus/base/driver/chained-bft/smr.go
41.33% <0.00%> (+0.74%)
:arrow_up:

bcs/network/p2pv1/conn.go
61.22% <0.00%> (+6.12%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 191d55e...0585d30. Read the comment docs.

Codecov Report

Merging #304 (cdd5090) into master (191d55e) will increase coverage by 0.95%.
The diff coverage is 64.82%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   45.65%   46.60%   +0.95%
==========================================
  Files         139      139
  Lines       12346    12541     +195
==========================================
+ Hits         5636     5845     +209
+ Misses       5557     5523      -34
- Partials     1153     1173      +20

Impacted Files
Coverage Δ

bcs/ledger/xledger/tx/mempool.go
44.23% <53.24%> (+13.74%)
:arrow_up:

bcs/ledger/xledger/state/state.go
47.78% <68.42%> (+0.51%)
:arrow_up:

bcs/ledger/xledger/tx/node.go
73.37% <86.25%> (+33.54%)
:arrow_up:

bcs/consensus/tdpos/common.go
52.17% <0.00%> (-2.90%)
:arrow_down:

bcs/consensus/tdpos/tdpos.go
46.94% <0.00%> (-1.88%)
:arrow_down:

bcs/consensus/xpoa/xpoa.go
52.28% <0.00%> (-1.02%)
:arrow_down:

kernel/contract/sandbox/mem_xmodel.go
75.32% <0.00%> (-1.00%)
:arrow_down:

bcs/contract/evm/creator.go
26.00% <0.00%> (-0.99%)
:arrow_down:

bcs/consensus/tdpos/schedule.go
43.43% <0.00%> (-0.46%)
:arrow_down:

kernel/contract/sandbox/xmcache.go
48.06% <0.00%> (-0.38%)
:arrow_down:

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 191d55e...cdd5090. Read the comment docs.

Codecov Report

Merging #304 (cdd5090) into master (191d55e) will increase coverage by 1.05%.
The diff coverage is 66.00%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   45.65%   46.70%   +1.05%
==========================================
  Files         139      139
  Lines       12346    12541     +195
==========================================
+ Hits         5636     5857     +221
+ Misses       5557     5512      -45
- Partials     1153     1172      +19

Impacted Files
Coverage Δ

bcs/ledger/xledger/tx/mempool.go
44.67% <55.19%> (+14.19%)
:arrow_up:

bcs/ledger/xledger/state/state.go
47.78% <68.42%> (+0.51%)
:arrow_up:

bcs/ledger/xledger/tx/node.go
73.37% <86.25%> (+33.54%)
:arrow_up:

kernel/contract/sandbox/mem_xmodel.go
75.32% <0.00%> (-1.00%)
:arrow_down:

bcs/contract/evm/creator.go
26.00% <0.00%> (-0.99%)
:arrow_down:

kernel/contract/sandbox/xmcache.go
48.06% <0.00%> (-0.38%)
:arrow_down:

bcs/ledger/xledger/state/xmodel/xmodel_snapshot.go
13.55% <0.00%> (-0.24%)
:arrow_down:

bcs/ledger/xledger/state/tx_verification.go
14.38% <0.00%> (-0.06%)
:arrow_down:

bcs/consensus/tdpos/schedule.go
43.89% <0.00%> (ø)

... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 191d55e...cdd5090. Read the comment docs.

Codecov Report

Merging #304 (c03d154) into master (cffcfcd) will increase coverage by 1.01%.
The diff coverage is 66.79%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   45.63%   46.64%   +1.01%
==========================================
  Files         139      139
  Lines       12362    12550     +188
==========================================
+ Hits         5641     5854     +213
+ Misses       5567     5523      -44
- Partials     1154     1173      +19

Impacted Files
Coverage Δ

bcs/ledger/xledger/state/xmodel/xmodel_verify.go
46.66% <50.00%> (+3.80%)
:arrow_up:

bcs/ledger/xledger/tx/mempool.go
45.11% <57.79%> (+14.63%)
:arrow_up:

bcs/ledger/xledger/state/state.go
47.78% <68.42%> (+0.51%)
:arrow_up:

bcs/ledger/xledger/tx/node.go
73.37% <86.25%> (+33.54%)
:arrow_up:

bcs/network/p2pv1/conn.go
55.10% <0.00%> (-6.13%)
:arrow_down:

bcs/contract/xvm/code_manager.go
63.63% <0.00%> (-2.73%)
:arrow_down:

bcs/consensus/xpoa/xpoa.go
51.26% <0.00%> (-2.04%)
:arrow_down:

bcs/ledger/xledger/state/xmodel/xmodel.go
62.85% <0.00%> (-1.43%)
:arrow_down:

kernel/consensus/base/driver/chained-bft/smr.go
41.33% <0.00%> (+0.74%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a05a2f5...c03d154. Read the comment docs.

Codecov Report

Merging #304 (d4839bd) into master (a05a2f5) will increase coverage by 0.78%.
The diff coverage is 59.00%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   45.63%   46.42%   +0.78%
==========================================
  Files         139      141       +2
  Lines       12371    12621     +250
==========================================
+ Hits         5646     5859     +213
- Misses       5572     5582      +10
- Partials     1153     1180      +27

Impacted Files
Coverage Δ

bcs/ledger/xledger/tx/tx.go
39.50% <40.00%> (-0.37%)
:arrow_down:

bcs/ledger/xledger/tx/mempool.go
43.52% <48.93%> (+13.04%)
:arrow_up:

bcs/ledger/xledger/state/state.go
47.29% <57.14%> (+0.03%)
:arrow_up:

bcs/ledger/xledger/tx/node.go
71.67% <82.55%> (+31.85%)
:arrow_up:

bcs/network/p2pv1/conn.go
55.10% <0.00%> (-6.13%)
:arrow_down:

kernel/engines/xuperos/engine.go
40.14% <0.00%> (-4.78%)
:arrow_down:

bcs/consensus/pow/pow.go
39.54% <0.00%> (-3.43%)
:arrow_down:

kernel/contract/sandbox/xmcache.go
46.61% <0.00%> (-1.45%)
:arrow_down:

bcs/network/p2pv2/server.go
51.33% <0.00%> (-1.07%)
:arrow_down:

bcs/consensus/xpoa/xpoa.go
52.28% <0.00%> (-1.02%)
:arrow_down:

... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Codecov Report

Merging #304 (d4839bd) into master (a05a2f5) will increase coverage by 0.73%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   45.63%   46.37%   +0.73%
==========================================
  Files         139      142       +3
  Lines       12371    12674     +303
==========================================
+ Hits         5646     5877     +231
- Misses       5572     5618      +46
- Partials     1153     1179      +26

Impacted Files
Coverage Δ

bcs/ledger/xledger/tx/tx.go
39.50% <40.00%> (-0.37%)
:arrow_down:

bcs/ledger/xledger/tx/mempool.go
43.95% <50.53%> (+13.47%)
:arrow_up:

bcs/ledger/xledger/state/state.go
47.29% <57.14%> (+0.03%)
:arrow_up:

bcs/ledger/xledger/tx/node.go
71.67% <82.55%> (+31.85%)
:arrow_up:

kernel/engines/xuperos/engine.go
40.14% <0.00%> (-4.78%)
:arrow_down:

kernel/contract/sandbox/xmcache.go
46.61% <0.00%> (-1.45%)
:arrow_down:

bcs/network/p2pv2/server.go
51.33% <0.00%> (-1.07%)
:arrow_down:

bcs/consensus/xpoa/xpoa.go
52.28% <0.00%> (-1.02%)
:arrow_down:

kernel/consensus/base/driver/chained-bft/smr.go
40.59% <0.00%> (-0.75%)
:arrow_down:

bcs/contract/native/runtime.go

... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Codecov Report

Merging #304 (907a242) into master (a05a2f5) will increase coverage by 0.72%.
The diff coverage is 56.53%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   45.63%   46.36%   +0.72%
==========================================
  Files         139      141       +2
  Lines       12371    12668     +297
==========================================
+ Hits         5646     5873     +227
- Misses       5572     5615      +43
- Partials     1153     1180      +27

Impacted Files
Coverage Δ

bcs/ledger/xledger/tx/mempool.go
42.33% <46.04%> (+11.85%)
:arrow_up:

bcs/ledger/xledger/tx/tx.go
39.87% <50.00%> (+<0.01%)
:arrow_up:

bcs/ledger/xledger/state/state.go
46.78% <59.09%> (-0.48%)
:arrow_down:

bcs/ledger/xledger/tx/node.go
71.67% <82.55%> (+31.85%)
:arrow_up:

bcs/network/p2pv1/conn.go
55.10% <0.00%> (-6.13%)
:arrow_down:

kernel/engines/xuperos/engine.go
39.58% <0.00%> (-5.34%)
:arrow_down:

bcs/contract/xvm/code_manager.go
63.63% <0.00%> (-2.73%)
:arrow_down:

bcs/consensus/xpoa/xpoa.go
51.26% <0.00%> (-2.04%)
:arrow_down:

kernel/contract/sandbox/xmcache.go
46.61% <0.00%> (-1.45%)
:arrow_down:

... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Codecov Report

Merging #304 (907a242) into master (a05a2f5) will increase coverage by 0.54%.
The diff coverage is 56.53%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   45.63%   46.18%   +0.54%
==========================================
  Files         139      142       +3
  Lines       12371    12721     +350
==========================================
+ Hits         5646     5875     +229
- Misses       5572     5666      +94
- Partials     1153     1180      +27

Impacted Files
Coverage Δ

bcs/ledger/xledger/tx/mempool.go
42.33% <46.04%> (+11.85%)
:arrow_up:

bcs/ledger/xledger/tx/tx.go
39.87% <50.00%> (+<0.01%)
:arrow_up:

bcs/ledger/xledger/state/state.go
46.78% <59.09%> (-0.48%)
:arrow_down:

bcs/ledger/xledger/tx/node.go
71.67% <82.55%> (+31.85%)
:arrow_up:

bcs/network/p2pv1/conn.go
55.10% <0.00%> (-6.13%)
:arrow_down:

kernel/engines/xuperos/engine.go
39.58% <0.00%> (-5.34%)
:arrow_down:

bcs/contract/xvm/code_manager.go
63.63% <0.00%> (-2.73%)
:arrow_down:

bcs/consensus/xpoa/xpoa.go
51.26% <0.00%> (-2.04%)
:arrow_down:

kernel/contract/sandbox/xmcache.go
46.61% <0.00%> (-1.45%)
:arrow_down:

... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

lgtm

Codecov Report

Merging #304 (62636c8) into master (26f7097) will increase coverage by 1.05%.
The diff coverage is 56.83%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   45.30%   46.36%   +1.05%
==========================================
  Files         142      141       -1
  Lines       12488    12668     +180
==========================================
+ Hits         5658     5873     +215
+ Misses       5669     5617      -52
- Partials     1161     1178      +17

Impacted Files
Coverage Δ

bcs/ledger/xledger/tx/mempool.go
42.33% <46.51%> (+11.85%)
:arrow_up:

bcs/ledger/xledger/tx/tx.go
39.87% <50.00%> (+<0.01%)
:arrow_up:

bcs/ledger/xledger/state/state.go
46.78% <59.09%> (+0.10%)
:arrow_up:

bcs/ledger/xledger/tx/node.go
71.67% <82.55%> (+31.85%)
:arrow_up:

bcs/network/p2pv1/conn.go
55.10% <0.00%> (-6.13%)
:arrow_down:

bcs/consensus/xpoa/common.go
77.41% <0.00%> (-3.23%)
:arrow_down:

bcs/consensus/xpoa/xpoa.go
51.26% <0.00%> (-1.02%)
:arrow_down:

bcs/consensus/tdpos/tdpos.go
47.88% <0.00%> (-0.94%)
:arrow_down:

bcs/contract/native/runtime_docker_darwin.go

kernel/consensus/base/driver/chained-bft/smr.go
41.33% <0.00%> (+0.74%)
:arrow_up:

... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Codecov Report

Merging #304 (62636c8) into master (26f7097) will increase coverage by 0.93%.
The diff coverage is 56.83%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   45.30%   46.24%   +0.93%
==========================================
  Files         142      142
  Lines       12488    12721     +233
==========================================
+ Hits         5658     5883     +225
+ Misses       5669     5660       -9
- Partials     1161     1178      +17

Impacted Files
Coverage Δ

bcs/ledger/xledger/tx/mempool.go
42.47% <46.51%> (+11.99%)
:arrow_up:

bcs/ledger/xledger/tx/tx.go
39.87% <50.00%> (+<0.01%)
:arrow_up:

bcs/ledger/xledger/state/state.go
46.78% <59.09%> (+0.10%)
:arrow_up:

bcs/ledger/xledger/tx/node.go
71.67% <82.55%> (+31.85%)
:arrow_up:

bcs/consensus/xpoa/xpoa.go
51.26% <0.00%> (-1.02%)
:arrow_down:

kernel/consensus/base/driver/chained-bft/smr.go
41.33% <0.00%> (+0.74%)
:arrow_up:

bcs/contract/xvm/code_manager.go
66.36% <0.00%> (+2.72%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Avoid encode/decode overhead with b64 strings for type binary

We are using this in a performance sensitive capacity and wanted to avoid using base64 strings, which get encoded/decoded more than once, when the data type passed by Flutter's StandardMethodCodec for typed lists, FlutterStandardDataType has a data property that can be pulled off and passed to RTCDataBuffer's alloc call directly. This also lets us avoid encoding/decoding our raw binary on the Dart side to b64 in order to use these data channels.

Would it be alright if I just added .vscode wholesale to the .gitignore?

Canceling this and moving PR to our master branch

I've just realized that these changes are iOS specific and have not tested for android, so this is not ready to merge until I can find some time to verify nothing is broken, unless anybody else is interested in taking that on.

Yes, we can wait for the android part of the test to merge without problems, maybe we can write an demo of the binary transfer in the examples, before I tested the string type data transfer in flutter-webrtc-demo/blob/master/lib/src/call_sample/data_channel_sample.dart.

I think we should also add some inline documentation on the use of the datachannel, and how its usage can now differ between ios and android until native binary support is implemented for that platform so people know what's up.

It should also be noted that this is a breaking change to the public API, and with this change, the usage of that API now varies between ios and android. We should at least edit the library so that on android it encodes and decodes with base64 transparently so that at least the API will be consistent on both platforms.

To clarify, I believe the API is much more logical with this change, it's important to be aware that it IS breaking.

It seems that we should create a DataBuffer class, defined by a constructor to be string or binary, for example: DataBuffer.fromBinary(Uint8List data), DataBuffer(String sting);
class DataBuffer {
  dynamic _data;
  bool _isBinary;

  DataBuffer(String string) {
    this._data = string;
    this._isBinary = false;
  }
  DataBuffer.fromBinary(Uint8List binary) {
    this._data = binary;
    this._isBinary = true;
  }

  bool get isBinary => _isBinary;

  String get string => _data;

  Uint8List get binary => _data;
}

This way we can limit the data type to String or Uint8List anyway.

Yeah, DataBuffer approach would be definitely better
And my 5 cents about android: this will create a lot of overhead due to passing buffer from native to java and back to native, unless top 1 requested feature is implemented: https://github.com/flutter/flutter/issues/7053
I don't need this feature right now, but if I would, then passing string path and handling it's transfer on java side would be a better option, but it's way too different from original webrtc

@Codeusa It was dynamic because it could be either a Uint8List or a String (and Dart does not have union types). DataBuffer seems like a better solution, though.

Okay I'm implementing the requested changes now. For send, I'm going to do something more like this:
class DataBuffer {
  dynamic _data;
  bool _isBinary;
  DataBuffer(String text) {
    this._data = text;
    this._isBinary = false;
  }
  DataBuffer.fromBinary(Uint8List binary) {
    this._data = binary;
    this._isBinary = true;
  }
  DataBuffer.fromBase64Binary(String encodedBinary) {
    this._data = base64.decode(encodedBinary);
    this._isBinary = true;
  }
  bool get isBinary => _isBinary;
  String get text => _data;
  Uint8List get binary => _data;
  String get binaryInBase64 => base64.encode(_data);
}

  /// Send a message to this datachannel.
  /// To send a string message, pass "text" to [type]
  /// And use the default constructor to instantiate a [DataBuffer]
  /// for the [buffer] parameter.
  /// To send a binary message, pass "binary" to [type]
  /// and pass a [DataBuffer] constructed with [DataBuffer.fromBinary].
  Future<void> send(String type, DataBuffer buffer) async {
    dynamic data;
    if (buffer.isBinary) {
      if (Platform.isAndroid) {
        data = buffer.binaryInBase64;
      }
      else {
        data = buffer.binary;
      }
    }
    else {
      data = buffer.text;
    }
    await _channel.invokeMethod('dataChannelSend',
        <String, dynamic>{ 'peerConnectionId': _peerConnectionId,
        'dataChannelId': _dataChannelId,
        'type': type,
        'data': data});
  }

And something symmetrical for the event listener. This will keep the public API the same for each platform.

And for eventListener:
  void eventListener(dynamic event) {
    final Map<dynamic, dynamic> map = event;
    switch (map['event']) {
      case 'dataChannelStateChanged':
        //int dataChannelId = map['id'];
        String state = map['state'];
        if (this.onDataChannelState != null)
          this.onDataChannelState(rtcDataChannelStateForString(state));
        break;
      case 'dataChannelReceiveMessage':
        //int dataChannelId = map['id'];

        String type = map['type'];
        dynamic data = map['data'];
        DataBuffer buffer;
        if (type == 'binary') {
          if (Platform.isAndroid) {
            buffer = DataBuffer.fromBase64Binary(data);
          }
          else {
            buffer = DataBuffer.fromBinary(data);
          }
        }
        else {
          buffer = DataBuffer(data);
        }

        if (this.onMessage != null)
          this.onMessage(type, data);
        break;
    }
  }

So that again, even on android the DataBuffer passed to the listener will contain binary.

I think I'll also change the name of DataBuffer to RTCDataChannelMessage, since that's actually what it represents.

Side note: I would recommend using the triple-slash dartdoc notation instead of the classic javadoc style. I will use that style in this change.

I will merge it first. Later we may need to do the same processing for Android parts by removing  if (Platform.isAndroid){ and using java.lang.String, bytes[] to maintain the consistency of the plugin communication layer.
Regarding the annotation style, it may be handled together when the final document is online, https://github.com/cloudwebrtc/flutter-webrtc/issues/36, don't worry, it's good now.


Baud Rate Config

Hello,
I have a baud rate that doesn't seem to be an option in the calculator software or other standard tables online.  It's a somewhat older system, and the only number I have to go off is 9600 - the value of a setting named Baud Rate in the main software.  Any guidance would be much appreciated.
Thank you.

I suspect you are not looking at a CAN device, but instead an RS-232 serial device.

I have one device connected to another using a 9-pin D connector, with 3 pins present - CAN High, CAN Low, and ground.  The receiving device is the one with a UI and that's where it has a setting for Baud Rate which is required to be set to 9600 for this implementation.  I just don't know exactly what that setting is referring to.  I'd like to be able to split the connection and read the messages using the CAN shield.

If you feel you need to continue the discussion, you can reopen the issues.


Integrate changes from NERSC GPU hackathon.

See https://github.com/BlueBrain/CoreNeuron/pull/713 for context.
We should not merge this until https://github.com/BlueBrain/CoreNeuron/pull/713 is also ready to merge and https://github.com/BlueBrain/nmodl/pulls?q=is%3Apr+is%3Aopen+base%3Ahackathon_main is empty.

Codecov Report

Merging #783 (8535e82) into master (6434099) will increase coverage by 0.01%.
The diff coverage is 11.32%.

@@            Coverage Diff             @@
##           master     #783      +/-   ##
==========================================
+ Coverage   61.42%   61.44%   +0.01%
==========================================
  Files         205      205
  Lines       29849    29895      +46
==========================================
+ Hits        18335    18368      +33
- Misses      11514    11527      +13

Impacted Files
Coverage Δ

src/codegen/codegen_acc_visitor.cpp
0.54% <0.00%> (-0.05%)
:arrow_down:

src/codegen/codegen_acc_visitor.hpp
0.00% <ø> (ø)

src/codegen/codegen_c_visitor.hpp
91.86% <ø> (ø)

src/solver/newton/newton.hpp
94.33% <ø> (ø)

test/unit/codegen/codegen_c_visitor.cpp
100.00% <ø> (ø)

src/codegen/codegen_c_visitor.cpp
68.50% <50.00%> (+0.03%)
:arrow_up:

src/language/templates/visitors/ast_visitor.cpp
52.53% <0.00%> (-0.36%)
:arrow_down:

test/unit/visitor/semantic_analysis.cpp
100.00% <0.00%> (ø)

src/visitors/semantic_analysis_visitor.cpp
100.00% <0.00%> (ø)

src/visitors/semantic_analysis_visitor.hpp
100.00% <0.00%> (ø)

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6434099...8535e82. Read the comment docs.


make pkg.Installable and pkg.InputAddressedPaths return array

Summary
How was it tested?

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

#1842  👈
#1837
main

This stack of pull requests is managed by Graphite.


i2 Connect - Code Lists list in the i2 Connect forms

Hello to everyone,
I have a question about how to define code lists in the i2 Connect connectors forms: in the config.son connector file, where we define the forms that appear in ANB for the information search, we can also define drop-down lists with values for the user to choose from (as “Gender” list, "male - female").
Apart from defining them explicitly in the "possibleValues" property, >> can the values of that list be obtained from a query to a database? Or from a text file?
Thanks.
Luis.

Hi Luis
I will check in with our development folks and either they or I will get back to you.
Cheers

Hi Tony.
Thanks.
I am going to post another question in a minute.
Thanks.
Enviado desde Correohttps://go.microsoft.com/fwlink/?LinkId=550986 para Windows
De: Tony @.>
Enviado: jueves, 3 de marzo de 2022 11:09
Para: @.>
CC: @.>; @.>
Asunto: Re: [i2group/analyze-connect] i2 Connect - Code Lists list in the i2 Connect forms (Issue #11)
Hi Luis
I will check in with our development folks and either they or I will get back to you.
Cheers
—
Reply to this email directly, view it on GitHubhttps://github.com/i2group/analyze-connect/issues/11#issuecomment-1057883906, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AT4WH3U5D2LV7RKZ7THJOILU6CFVLANCNFSM5PZ6YZWQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>

Hi Luis
You can do what you are asking but if the contents were to change,  the server admin would need to reload the gateway  for that change to be available.
The configuration doesn't need to be hardcoded in a .jsonfile.
Dynamic configuration can be achieved by building  the configuration response at runtime, the same as any other response to a request... so it can be built in your code.
If you wish you can also make your connector have user or group specific configurations as shown  here.
Cheers

Oh, Good.
Thanks very much!!
I’ll pass this to the guys (customer is building the connector) to see if they undestand it.
Enviado desde Correohttps://go.microsoft.com/fwlink/?LinkId=550986 para Windows
De: Tony @.>
Enviado: jueves, 3 de marzo de 2022 11:41
Para: @.>
CC: @.>; @.>
Asunto: Re: [i2group/analyze-connect] i2 Connect - Code Lists list in the i2 Connect forms (Issue #11)
Hi Luis
You can do what you are asking but if the contents were to change, the server admin would need to reload the gateway for that change to be available.
The configuration doesn't need to be hardcoded in a .jsonfile.
Dynamic configuration can be achieved by building the configuration response at runtime, the same as any other response to a request... so it can be built in your code.
If you wish you can also make your connector have user or group specific configurations as shown here.https://i2group.github.io/analyze-connect/content/example-connectors/user-configuration.html
Cheers
—
Reply to this email directly, view it on GitHubhttps://github.com/i2group/analyze-connect/issues/11#issuecomment-1057911009, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AT4WH3UVFRGILJ6HQ725HVLU6CJLVANCNFSM5PZ6YZWQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID: @.***>

@logicalis-i2
Hi Luis
Did the customer you were asking the question for understand the information you passed back to them regarding this issue?

Hi Tony.
I passed the info to the customer, so I believe with that answer we are done.
You can close the case.
Many thanks.
Enviado desde Correohttps://go.microsoft.com/fwlink/?LinkId=550986 para Windows
De: Tony @.>
Enviado: lunes, 28 de marzo de 2022 15:41
Para: @.>
CC: @.>; @.>
Asunto: Re: [i2group/analyze-connect] i2 Connect - Code Lists list in the i2 Connect forms (Issue #11)
@logicalis-i2https://github.com/logicalis-i2
Hi Luis
Did the customer you were asking the question for understand the information you passed back to them regarding this issue?
—
Reply to this email directly, view it on GitHubhttps://github.com/i2group/analyze-connect/issues/11#issuecomment-1080667165, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AT4WH3SY5EMZJDYFCZKRU5TVCGZH3ANCNFSM5PZ6YZWQ.
You are receiving this because you were mentioned.Message ID: @.***>

Great!
Thank you.


Installation error: universal online installer of ESP-IDF V5.0.1 with C6 target coverage (IDFGH-9698)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
v5.0.1
Operating System used.
Windows
How did you build your project?
Command line with CMake
If you are using Windows, please specify command line type.
PowerShell
What is the expected behavior?
Hello, Unfortunately I am not able to use my ESP32-C6 DEVKITC-1. That is because I am not able to install ESP-IDF V5.0.1 which is the only version that supports C6 targets. Please find attached the error message and the log file. I have no firewall or proxy server issues.
I am new to ESP32 ecosystem, all what I need for the moment is to flash my C6 and send commands to scan and associate the C6 WiFi to an access point.
Anyone could give support please? BR

ADH.Setup.Log.2023-03-21.001.txt
What is the actual behavior?
ESP-IDF V5.0.1 installation error
Steps to reproduce.
try to install the universal online installer of ESP-IDF V5.0.1 with C6 target coverage, using window installer from the page: https://dl.espressif.com/dl/esp-idf/?idf=4.4
Build or installation Logs.
No response
More Information.
No response

Hi @loraahd. Please see https://github.com/espressif/esp-idf#esp-idf-release-and-soc-compatibility. ESP32-C6 is going to be supported by the upcoming v5.1 release (currently the master branch). It is not supported in v5.0.1.
Here is the work-in-progress support status issue: https://github.com/espressif/esp-idf/issues/10423

Hi @loraahd. Please see https://github.com/espressif/esp-idf#esp-idf-release-and-soc-compatibility. ESP32-C6 is going to be supported by the upcoming v5.1 release (currently the master branch). It is not supported in v5.0.1.
Here is the work-in-progress support status issue: #10423

thanks @dobairoland

I will share some steps that I did to setup my tools on Windows, including built-in JTAG debugging on VScode.
To support the C6, you need to use the Master branch.
Please note that this is no official guide
1. Install ESP-IDF and TOOLS

Create the following installation folders:

ESP-IDF folder: C:/dev/idf/
ESP-IDF TOOLS folder: C:/dev/tools/

Download the Universal Online installer
Apply any fix it may present during the pre-installation system check.
Select the option to download the software: Download ESP-IDF
Select the latest version (pre-release): master (development branch)
Choose the ESP-IDF folder from step 1 using the Browse... button
Choose the ESP-IDF TOOLS folder from step 1 using the Browse... button

This may also create a subfolder by itself

Select Full installation

Check ESP32-C6 under Chip Targets
Check all the boxes under Drivers

Continue all steps...

2. Update OpenOCD package in tools.json

Edit the tools.json file

C:/dev/idf/tools/tools.json

Win32 and Win64 - Change to the followig version or the lastest release to support debugging the ESP32-C6:

Line 771: name to "v0.12.0-esp32-20230221"
Line 774 and 779: sha256 to "85d1f72f442f8e362655040e22b9ff2666432ac3d9022c8238725e3349b3fad1"
Line 765 and 780: size to "2491691"
Line 776 and 781: url to "https://github.com/espressif/openocd-esp32/releases/download/v0.12.0-esp32-20230221/openocd-esp32-win32-0.12.0-esp32-20230221.zip"

Save changes

3. Setup paths

Open Command prompt with Admin rights
Change directory to the IDF folder

cd C:\dev\idf

Run the install script

install.bat
This should install all the tools, python virtual env and paths.

Run the export script

export.bat

Varify that all the paths and tools are installed correctly

Open Winodows Environment variables
Check if IDF_PATH says C:\dev\idf
Check if IDF_TOOLS_PATH says C:\dev\tools\Espressif
Check if Path includes %IDF_PATH%\tools

4. Manually check if the tools work

Follow the steps on the ESP-IDF Programming Guide.

5. Setup VSCode with ESP-IDF plugin

Open VSCode
Install the Espressif IDF plugin
Choose the advanced setup option
Select the following information

Download server: Github
ESP-IDF version: Find ESP-IDF in your system
ESP-IDF directory: C:\dev\idf
ESP-IDF Tools directory: C:\dev\tools\Espressif
Install, should skip most steps since everything is already installed.

6. Use example project: hello world

Press F1 and select ESP-IDF: Show Examples Projects
Choose hello_world
Select a folder where the project subfolder will be saved

e.g. C:\dev\projects\

Select the correct Serial port
Select the correct Target
Run Menuconfig

Set the correct Flash size
Maybe set lower optimisation

Build project
Select JTAG as flash method
Flash program

7. Debug program

Add the following section to the launch.json:{
  "name": "GDB",
  "type": "cppdbg",
  "request": "launch",
  "MIMode": "gdb",
  "miDebuggerPath": "C:\\dev\\tools\\Espressif\\tools\\riscv32-esp-elf-gdb\\12.1_20221002\\riscv32-esp-elf-gdb\\bin\\riscv32-esp-elf-gdb.exe",
  "program": "${workspaceFolder}/build/${command:espIdf.getProjectName}.elf",
  "windows": {
    "program": "${workspaceFolder}\\build\\${command:espIdf.getProjectName}.elf"
  },
  "cwd": "${workspaceFolder}",
  "environment": [{ "name": "PATH", "value": "${config:idf.customExtraPaths}" }],
  "setupCommands": [
    { "text": "target remote :3333" },
    { "text": "mon reset halt" },
    { "text": "thb app_main" },
    { "text": "flushregs" }
  ],
  "externalConsole": false,
  "logging": {
    "engineLogging": true
  }
}

Start OpenOCD server
First upload program by JTAG after every hardreset before debugging, else debug session fails to connect.
Start debug session by using GDB under run and debug tab

Program should automaticly break at app_main()

[Optional] Add SVD file to the main directory of the project with the name esp32.svd

The ESP32-C6 support is currently being developed. Therefore, if you want to use the ESP32-C6 you need to use the master branch (which support most of the features already).
I cannot say anything about the ETA of the next official release.
When you use the setup, please remove all folders related to the IDF setup and start over using this option:

Hello,
just noticed that I have the warnings below. knowing that I am not using a proxy or a firewall that can block the access to the servers!

Looks like you are unable to connect to the servers, maybe the program is being blocked?
Good luck!

Hello,
I've solved server access related issues. I've installed the master branch of the online IDF with C6 support. The, under CMD, I set target as follows: C:\dev\idf\examples\get-started\hello_world>id.fpy --preview set-target esp32c6
but it exits with the following error:
CMake Error at C:/dev/idf/tools/cmake/component.cmake:479 (add_library):
Cannot find source file:
C:/dev/idf/components/unity/unity/src

Indeed, src folder is missing.
why am I having that error? how to fix it?
thanks
BR


content doesn't seem to work with ng-repeat

Hi, I'm using Drop.js with Angular.js and have a question:
ng-repeat doesn't seem to work inside a content DOM element?
My minimal non-working demo here: https://plnkr.co/edit/UcSC3x?p=preview
Having an ng-repeat directive inside a content element produces
"TypeError: Cannot read property 'insertBefore' of null"

In the DOM tree, the ng-repeat element is commented

Could you suggest why ng-repeat is commented and if there's any work-around?

My problem is solved on StackOverflow: http://stackoverflow.com/q/34820111/1270459


Burn imprecision in OUSD will happen in centuries with yield

Report from Rappie via Immunefi:
Description
There is a bug present in the OUSD contract. Calling the burn function on an address with zero balance causes the totalSupply to go down. This happens because of an incorrect/incomplete check for rounding errors.
The end result is a situation where the sum of all balances exceeds the total supply. This is a dangerous situation which can lead to many unforeseen consequences.
The same burn function also contains another (smaller) bug, causing an revert because of arithmetic overflow.
I will explain both bugs in more detail below.
The bug is present in the deployed code on the Ethereum mainnet: https://etherscan.io/address/0x33db8d52d65f75e4cdda1b02463760c9561a2aa1#code
For demonstrational purposes I will be using the code from the origin-dollar repository on Github: https://github.com/OriginProtocol/origin-dollar/tree/f94d5567c57e8c541e7d1e80d1362e19fc453ac7
The bug is present in both codebases.
Bug 1 - incorrect totalSupply
The bug resides in the following code block:
// Remove the credits, burning rounding errors
if (
currentCredits == creditAmount || currentCredits - 1 == creditAmount
) {
// Handle dust from rounding
_creditBalances[_account] = 0;
} else if (currentCredits > creditAmount) {
_creditBalances[_account] = _creditBalances[_account].sub(
creditAmount
);
} else {
revert("Remove exceeds balance");
}
The main reason for the bug is this line:
currentCredits == creditAmount || currentCredits - 1 == creditAmount
https://github.com/OriginProtocol/origin-dollar/blob/f94d5567c57e8c541e7d1e80d1362e19fc453ac7/contracts/contracts/token/OUSD.sol#L411
This line is the check of the first if statement, and is meant for situations where small rounding errors will get burned. However, it does not account for the sitation where currentCredits is 0. In this case the code below will set the balance to zero (which it already is) and lowers the total supply (which shouldn't happen).
A simple extra if statement fixes the issue:
if (creditAmount == 0) {
revert("Burn from zero balance");
}
Thanks to this if nothing will happen when you try to burn tokens from an address with balance 0, as it should be.
I'm sure there are more elegant and gas-efficient solutions. This code fixes the bug and passes the testsuite.
Bug 2  - revert from arithmetic overflow
This bug has no security related impact. It's still a bug though, so why not fix it while we're at it :)
It resides in the same line of code:
currentCredits == creditAmount || currentCredits - 1 == creditAmount
This time it is the right part of the or (||). When the balanze is zero, currentCredits will be 0 and currentCredits - 1 will underflow. This causes a revert in Solidity 0.8. We can prevent this by calculating the difference upfront using an "iif".
Proposed solution, containing both bugfixes:
uint256 creditDifference = currentCredits > creditAmount
? currentCredits - creditAmount
: creditAmount - currentCredits;
if (creditAmount == 0) {
revert("Burn from zero balance");
}
if (creditDifference <= 1) {
// Handle dust from rounding
_creditBalances[_account] = 0;
} else if (currentCredits > creditAmount) {
_creditBalances[_account] = _creditBalances[_account].sub(
creditAmount
);
} else {
revert("Remove exceeds balance");
}
POC
const hre = require("hardhat");
const ethers = hre.ethers;

async function main() {
  // Get signer
  [deployer] = await ethers.getSigners();

  // Deploy OUSD token
  const OUSD = await ethers.getContractFactory("OUSD");
  const token = await OUSD.deploy();
  await token.deployed();

  // Initialize token
  await token.initialize("Name", "Symbol", deployer.address);

  // Initial mint
  await token.mint(deployer.address, ethers.BigNumber.from(10).pow(14));

  // Scale the supply so rounding errors start occurring
  // [DVF: This line simulates 1000x yield]
  await token.changeSupply(ethers.BigNumber.from(10).pow(17));

  // Burn from a random address with zero tokens
  const RANDOM_ADDRESS = "0x00000000000000000000000000000000deadbeef";
  await token.burn(RANDOM_ADDRESS, 42);

  // Print token amounts. Deployer balance is now higher than total supply.
  const balance = await token.balanceOf(deployer.address);
  const totalSupply = await token.totalSupply();
  console.log("Total balance: ", balance.toString());
  console.log("Total supply: ", totalSupply.toString());

  // Script output:
  //
  // $ yarn hardhat run scripts/poc-changesupply-burn.js
  // Total balance:<PHONE_NUMBER>00000000
  // Total supply:<PHONE_NUMBER>9999958
  //
}

main()
  .then(() => process.exit(0))
  .catch((error) => {
    console.error(error);
    process.exit(1);
  });

The deployed version of OUSD actually has 1e36 based precision, rather than an 1e18 precision. You can see this by looking at ousd.rebasingCreditsHighres(). (We have been keeping it at 1e18 in our github source so that our tests work on the edge of the where it starts loosing precision).
Because of this, this rounding burn issue doesn't appear until OUSD has earned about 10,000,000,000x yield from here.
Using brownie fork on mainnet:
>>> from world import *
>>> ousd.changeSupply(ousd.totalSupply()*int(1e6), {'from': vault_core})
>>> RANDOM_ADDRESS = "0x00000000000000000000000000000000deadbeef"
>>> ousd.burn(RANDOM_ADDRESS, 42, {'from': vault_core})
FAIL
>>> ousd.changeSupply(ousd.totalSupply()*int(1e1), {'from': vault_core})
>>> ousd.burn(RANDOM_ADDRESS, 42, {'from': vault_core})
FAIL
>>> ousd.changeSupply(ousd.totalSupply()*int(1e1), {'from': vault_core})
>>> ousd.burn(RANDOM_ADDRESS, 42, {'from': vault_core})
FAIL
>>> ousd.changeSupply(ousd.totalSupply()*int(1e1), {'from': vault_core})
>>> ousd.burn(RANDOM_ADDRESS, 42, {'from': vault_core})
FAIL
>>> ousd.changeSupply(ousd.totalSupply()*int(1e1), {'from': vault_core})
>>> ousd.burn(RANDOM_ADDRESS, 42, {'from': vault_core})
FAIL
>>> ousd.changeSupply(ousd.totalSupply()*int(1e1), {'from': vault_core})
>>> ousd.burn(RANDOM_ADDRESS, 42, {'from': vault_core})

It doesn't seem like a zero burn can happen until past 400 years into the future, if we have 5% average yield during that time. So it's not an immediate need to change.
That said, I'm a fan of things that work the way they should, and we should consider if / how we want to implement these changes. There are also other rounding issues with the OUSD ERC20 that are currently non-issues because of the high internal precision.


[stable/sonatype-nexus] Use official sonatype nexus image. Keep default admin123 password.

What this PR does / why we need it:
Use official sonatype-nexus docker image which is more up-to-date.
Special notes for your reviewer:

The securityGroup change allows the pvc to be usable (proper permissions) by Nexus.
NEXUS_SECURITY_RANDOMPASSWORD keeps the default admin password admin123 like the HELM install output says.

Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @tsiddique

/ok-to-test

/assign

/lgtm

@davidkarlsen  This PR has already been applied and the change is fine by me, but changing an image and only updating patch version is unacceptable.
https://semver.org/

PATCH version when you make backwards compatible bug fixes.


full page refresh on mobile

Say we have routes.js, consider the following:
<BrowserRouter>
   <NewContextCheck>
      <Switch>
         <Route exact path="/@:username" component={ProfilePage} />
      </Switch>
   </NewContextCheck>
</BrowserRouter>

and a link somewhere in the page:
<Link<EMAIL_ADDRESS>    { user.name }
</Link>

Clicking the link will cause the page to refresh(instead of just rendering the ProfilePage component), but wrapping
{ user.name } in  won't cause a full page refresh.
I also used Link to wrap a  and clicking the image will cause a full page refresh. This time adding the  doesn't fix it anymore:
<Link<EMAIL_ADDRESS>
</Link>

It acts this way only on mobile(chrome devtools).
v4.2.2

Something else external to the library is going on if that's not working. I'd ask about this on Stack Overflow or Reactiflux where there are a lot more people ready to help you out. Thanks!


Question

Issue in ./help/tags/ui/managing-resources/rules.md
Re: "Enabled
If enabled, when an event is triggered at runtime, the rule’s conditions and actions are added to a processing queue–based on the order you have defined–and processed one at a time on a FIFO basis. The tag waits for the completion of the component before moving onto the next one."
Does this apply within rule or also outside of the rule itself... for example:
Rule 1, window load, order 49
Rule 2, window load, order 50
Does rule 1 complete before rule 2 or just start  before rule 2?

Thank you for submitting this issue. We will review the documentation and make the necessary updates as quickly as possible. Tracking internally in https://jira.corp.adobe.com/browse/PLAT-113154.

@lucky-committ - note that rules themselves execute in sequence, regardless of how their rule components are sequenced. Rule 1 will complete before Rule 2 starts.
The documentation has now been updated. Please read:

https://experienceleague.adobe.com/docs/experience-platform/tags/ui/rules.html?lang=en#rule-ordering
https://experienceleague.adobe.com/docs/experience-platform/tags/ui/rules.html?lang=en#sequencing

If you find additional updates that are required, please open a new issue.


feat: handle cow swap minimums using error monads

Description

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

closes #
Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Current dependencies on/for this PR:

develop

PR #5081   👈

This comment was auto-generated by Graphite.


Possible memory leak with transaction managed repo generation.

The SQLCommand and SQLConnections both do not seem to be disposed when used in transaction managed calls. Wrap both in usings to ensure that they're disposed when finished to avoid memory issues.

Fixed with #33


fix: index out of range for descending query

Signed-off-by: smallYellowCat<EMAIL_ADDRESS>What problem does this PR solve?
When execute descending query and there is a ColVal with bitmapOffset>0 in the data, a panic may occur.
Issue Number: close #99
What is changed and how it works?
Function logic problem, modify function parameters.
https://github.com/openGemini/openGemini/blob/71dbe9a19b58242ebd5a60d1a553f26b151c492c/engine/immutable/reader.go#L505-L508
bitmapOffset should be uint32(col.BitMapOffset). Because what we want to flip is col's bitmap
How Has This Been Tested?

[x] TestDecodeColumnData

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@4243a29). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage        ?   62.74%
=======================================
  Files           ?      311
  Lines           ?    71960
  Branches        ?        0
=======================================
  Hits            ?    45152
  Misses          ?    23599
  Partials        ?     3209

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

thx @smallYellowCat


Minor mixin tweaks and cleanup

Moved mixin related changes out of #122

Take advantage of Access Widener to avoid needeng to use mixin's Accessors.
Formatting cleanups
Fixed ambiguios mixin references
Marked added members as Unique (ensures we don't override vanilla class members, or members added by other mods)
Improve the collision mixin's code

Thank you again!


[Bug]: In the git connected appCheckbox enable and disabling for a page has a issue

Is there an existing issue for this?

[X] I have searched the existing issues

Description
In the git connected appCheckbox enable and disabling for a page has a issue
https://www.loom.com/share/bd1408ee30f74870a7e81235f9f5819e
Steps To Reproduce

Add a app and connect it to git
Add 2 to 3 pages in the app
Go to admin setting
Now add a custom role
Open the entire app and queries
Nor check the create role for page 2
The queries of the page 1 will get checked

Public Sample App
No response
Issue video log
No response
Version
localhost

@RakshaKShetty How is it related to git?

@AnaghHegde this issue happening with the Git connected apps


Add libharfbuzz for drawtext support

Hi! This is the friendly automated conda-forge-webservice.
I've started rerendering the recipe as instructed in #224.
If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!
Here's a checklist to do before merging.

[ ] Bump the build number if needed.

@conda-forge-admin please rerender


Sheet files are too big

Hello,
Thank you for making this awesome Fork!
Sheet files loaded with Emoji Mart Vue by default has very big size, for example 7.5MB for 64x64 twemoji and 13.3MB for apple (but readme.md says: 1.82MB and 2.94MB respectively).

I think this is because they are taken from the wrong directory on unpkg. I found this line:
<EMAIL_ADDRESS>But in the React's Emoji Mart, sheets are taken from (note sheets-256):
<EMAIL_ADDRESS>So, when I change sheets to sheets-256 it seems the files back to normal size as documented.

Have published update as version 2.6.4


generate UT on API

Sample https://github.com/Azure/azure-sdk-for-java/pull/29660
(tests on model exists before this PR)

For now, only test the client methods. Fluent methods would be similar, but not yet done.
Also skip some LRO tests, which is hard to write UT properly.

Coverage (overall about 27% line)

Better when switched to fluent method (30%)


[5.1] Fix fluent interface on Route->middleware()

Fix for 5.1 LTE. This is still present in 5.2 and master.
PhpStorm doesn't correctly resolve the fluent interface following the call to middleware():
Route::get('/{subs?}', [function () {
    return view('layout');
}])
    ->middleware('auth')
    ->where(['subs' => '.*']) // Method 'where' not found in class array
    ->name('dashboard');

cc: @danielstqry

Should be $this|array i think?

Stepping out in my forgivable ignorance: why does the order matter? Is there a phpdoc best practice I'm not aware of?

Stepping out in my forgivable ignorance: why does the order matter? Is there a phpdoc best practice I'm not aware of?

It makes no difference, but laravel has a standard that generally objects go first, then scalars in alphabetical order, then null.

Awesome, thanks @GrahamCampbell, that's what I didn't know :+1: Thanks for explaining!


First Commit

This my first commit to this repository

Hi, thanks for the effort but a program in python has already been accepted. You can try out any new language which you don't know much about!


Update web-sites-traffic-manager.md

@tjoudeh : Thanks for your contribution! The author, @cephalin, has been notified to review your proposed change.

Verified editorial correction. Thanks!


Duplicate MarkdownPreviewHandler folder name in previewpane folder

There are two folders with name MarkdownPreviewHandler and MarkDownPreviewHandler under same folder previewpane with project files distributed in both folders.

Yes, I saw them too!
Make you up!!!

The URL below is where I saw them.
https://github.com/microsoft/PowerToys/tree/master/src/modules/previewpane

Seems like it has been fixed.


Windows Error "File is in use by another application or user"

I have downloaded a document from my mail client to keybase private folder. When I tried opening the file I get below error. There is no other application accessing this file(Checked it using process explorer ). I tried copying the file to another folder in keybase, I still see the same problem. I was able to open the file after copying the file to local storage from keybase.

my log id: 488fd13c7f4a461eded77e1c and
397e4d68bad4a1c97350661c(Uploaded using keybase log send -n 1000000 as earlier I had issues uploading huge files and it failed silently in the background)

@taruti?

I did not see this error again. Closing it


Material Design UI version and license

It's not very clear what UI library this project depends on and what version it's using.
There are no comments or licenses (must be retained in some cases) in the JS/CSS files
It appears that its using the following https://github.com/material-components/material-components-web
This libraries license states: "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software."
 * @license
 * Copyright 2016 Google Inc.
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 */

Thank you for this issue, i will read about what I need to add to my repository.
As I right undastand - just add this text in my License file.

MatBlazor is also MIT and file LICENSE.md was added.
So, this "permission notice" already was in  LICENSE.md  file.
Now, I have added line Copyright (c) 2014-2018 Google, Inc.
So, as I have right undastanding of this licence - that's what I need?

I am not a license expert, however, I think the license needs be in the JS/CSS files, as these are the only files which are available to us when we download the Nuget package.
"The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software."
Also, can you please list the version of material-components-web that this project uses. I'd like to contribute but I'm not sure which version to base the code from.

Thank you.
Now in js boundle I have License of Material Design UI and other.


Calculation of numTrainSamplesPerEpoch & batchSize Value

TensorFlow version 1.12
Python version 3.5
Operating system - Windows 10

We have numTrainSamplesPerEpoch as 25000 set in DataLoader.py and batchSize as 50 in Model.py. In my case, My input image count varies when I am training my model every time, so what's formula / best way to calculate numTrainSamplesPerEpoch & batchSize based on input image count to get best possible accuracy.

Try different values ("hyperparameter search") and see how the results change. There is no formula to get these parameters.


Added alt tag from the title of the book to each book image result

Description
I added alt tag based on the book title to the image for each result that came out of the search.
Alt attributes are important in terms of on-page optimization for two reasons:

Alt text is displayed to visitors if any particular image cannot be loaded (or if the images are disabled).
Alt attributes provide context because search engines can’t “see” images.

Checklist

[x] I am making a proper pull request, not spam.
[x] I've checked the issue list before deciding what to submit.

Related Issues or Pull Requests
Pull Request
Add relevant screenshot or video (if any)
New:

Old:

hi, can you check this @wasimreja


BUG: Casting negative numbers to unsigned char error

Casting negative numbers to unsigned char is an undefined behavior.  Apple Silicon results in zero, Intel results in wrap around values.
ctest -V -R itkBSplineScatteredDataPointSetToImageFilterTest05
This test cast an image of Vector<double,3> pixels to and image of Vector<unsigned char, 3> pixels inconsistently across platforms.  Then the test was performed to compute differences of the output images.
The test was comparison was re-written to take the magnitude of the Vector<double,3> pixels and multiplies them into a range of approximately 0-255 for the (now) scalar output image.  This output image is easier to visualize and compute results.
PR Checklist

[X] No API changes were made (or the changes have been approved)
[X] No major design changes were made (or the changes have been approved)

Tests are not written robustly.  They depend on consistent behavior when casting from signed double to unsigned char.  That behavior is undefined, and is different on Apple Silicon vs Intel.

I believe these other failing tests will need similar changes.
itkSymmetricEigenAnalysisImageFilterTestDoNotOrder
itkSymmetricEigenAnalysisImageFilterTestOrderByMagnitude
itkSymmetricEigenAnalysisImageFilterTestOrderByValue
Images of floating point vector pixels are cast to unsigned char inconsistently.

@dzenanz  I would like your feedback before I do similar changes to the other 3 failing tests on Apple Silicon.

NOTE: M2 mac build completed successfully with these changes: https://open.cdash.org/viewTest.php?onlypassed&buildid=8530717


Syntex support

I am the author of the Rustler library, which depends on easy_plugin for its compiler plugin. I am currently looking at supporting stable rust, and therefore planning to make my compiler plugin optionally use syntex.
Is it technically possible for this crate to support syntex?

I imagine it is possible, and I have thought about adding syntex support. I initially decided to put it off because I wasn't sure how difficult it would be to have both a nightly plugin interface and a stable syntex interface. I'll look into it.

I have looked at it a little bit, if I'm not mistaken syntex makes it fairly easy to support both interfaces.
Serde does it by having a cargo feature, and doing conditional imports based on that.

I'll have a look, see if it seems feasible.

It is feasible, currently adding synthex support to a quasiquoting crate I wrote that I recently refactored this crate to use. Once I am done with that, I will move to this crate.

v0.8.0 has been released with syntex support. Just pass the stable Cargo feature and you are good to go.

Oh wow, that was very fast!
Thanks for the help!


Parsing error: Unexpected token, expected "]" (eslint-loader)

Here's an error I get if I use any relatively new (in the last 3 or so years) features of typescript:
ERROR in ../linear/src/elements.tsx
Module Error (from /mnt/c/Users/thoma/OneDrive/Documents/devel/linear/node_modules/@react-workspaces/react-scripts/node_modules/eslint-loader/dist/cjs.js):

  Line 5:41:  Parsing error: Unexpected token, expected "]"

  3 | import classes from './classes';
  4 |
> 5 | type PropsOf<T> = JSX.IntrinsicElements[T];
    |                                         ^
  6 |
  7 |
  8 | export const A:

It looks to me like the issue is that eslint-loader is pegged to exactly 3.0.3 here: https://github.com/react-workspaces/create-react-app/blob/master/packages/react-scripts/package.json#L47

closed by https://github.com/react-workspaces/create-react-app/pull/23


Benchmark

Can you have a benchmark for the algorithms.

Sure, you can use go test -bench . in the source directory to run some internal benchmarks. They try to simulate a real-world resize scenario and are mostly useful to see if changes to the source code affect the algorithms' performance somewhat. There are probably some projects that compare the performance of this package to other scaling packages, but you'd have to search for that.

Here: https://github.com/fawick/speedtest-resize


Add support for custom fonts in the database

Add support for custom fonts in the database
Currently, custom fonts require manually modifying the items.json file.
Add support to store and persist them in the database.

Add support for custom fonts in the database

@Pandaxyz-xd Hey! Would you like to work on this? :) Do you intend to ask to be assigned?

yes

@Pandaxyzzz I assigned it to you! I encourage you to make a draft PR and discuss as you go through. :) Best wishes!

okay! Thanks!!!


Question: How to use with Custom Identity Provider?

I would like to use the react implementation of this widget, but I'm not sure how it works with a Custom Identity Provider. As far as I see, I don't have access to the custom_identity_provider object which is shown in the documentation: https://developers.livechat.com/docs/extending-chat-widget/custom-identity-provider

Hello, @mrsamse 👋 thanks for reporting the issue.
You are right, the LiveChat Chat Widget supports an advanced feature called Custom Identity Provider. Still, at the moment, Chat Widget Adapters does not expose a way to pass such provider via props into LiveChatWidget component (regardless of the chosen framework).
It's a good topic for enhancement in the package 👌 Because of that, I have changed the label from "bug" to "enhancement", as your issues do not relate to any miss functionalities of currently supported features.
We will plan to add the support for passing Custom Identity Provider to the Chat Widget instantiated via adapters 👍 We will use this issue to drop further updates how it's going so stay tuned 😉


Fix hash key ranges when splitting a shard

Changes Introduced
Fixes hash key ranges of new shards when a shard is split. Starting and ending keys were swapped.
Applicable linked issues
https://github.com/etspaceman/kinesis-mock/issues/378
Checklist (check all that apply)

[x] This change maintains backwards compatibility
[x] I have introduced tests for all new features and changes
[ ] I have added documentation covering all new features and changes
[x] This pull-request is ready for review

Thanks for the bugfix and contribution!


Python 3.7

Hi there.. its seem Python 2 will be dead on Jan 2020.. any tweak for this code to be run on Python 37 ?

I just tweaked the code so it runs for both python2 and python3.
See commit: https://github.com/LingDong-/linedraw/commit/2cfeb04e0da585c4e0bbba04c587d50cf5bcc39e
Mostly just adding parenthesis around print statements and using // for integer division.
Tested a bit on python 2.7.15 and 3.7.4, and everything seems to work.
If you find any problems please let me know.
Thanks

lol.. im putting ( ) when following the error.. but then there is more to that..
thank you very much for the code.


Please can we bump version of golang for Travis tests to 1.10?

version 1.8.3 is now fairly old-ish and I'm finding that there are changes and missing functions when developing with 1.10 and then submitting PRs upstream.  Are there reasons why moving to the latest go isn't possible or desirable?

There's no reason at all not to do so! I just forgot to do so myself... Let's bump.


Tips

I would find usefull:

display() returns the number of rows
if the table is larger than screen it autoadapts

By the way, good job, thank you.

display() returns the number of rows

^-- Unless I'm misunderstanding, you can count the number of rows in the array you pass to injectData() right? You could modify this library to have a new function to get the count, but it seems like extra work.

if the table is larger than screen it autoadapts
^-- I don't have a suggestion for this, as there are many variables that would go into even possibly attempting this, but I've implemented the centering of the table if the data is smaller than the width if that is something you're interested in. You can either PR from my fork to yours, use my fork, or wait until a pending PR I have on this library for something else is merged and then I can submit that PR on this library as well.


⚠ File access (beta) has degraded performance

In 8ee2aa2, File access (beta) (https://beta.fyle.uk/file/fish) experienced degraded performance:

HTTP code: 503
Response time: 2396 ms

Resolved: File access (beta) performance has improved in 96a23f2.


Fixed NodeJS config capitalization, Java agent provider File class namespace and agent version remote_file logic.

Title is pretty self-explanatory.

Fixed the NodeJS cookbook default attribute to avoid a nasty capitalization issue with the New Relic agent (looks like this was already fixed/honored in the corresponding resource provider.
Java agent provider was throwing a uninitialized constant Chef::Provider::File::SEPARATOR error due to a missing Ruby namespace resolution operator. Fixed that.
Java agent provider was not using it's own code for setting the proper file path and name of the Java agent JAR. Fixed! Also updated the ChefSpec unit test to keep coverage with this change.

Forgot to lint after changes and missed a rubocop violation. I will reissue a pull request with fixed included.


Change hover effect on popup items

Fixes #1441
The icon itself has a separate hover animation
Any feedback @llaske?

Nice fix :+1:
BTW could we avoid the double highlight on icon?

We could not include the "icon" class (which has this hover effect) when we are using the Icon component in a popup, since we already are using the item-icon class.
What do you think?

What do you think?

Update your PR, I will have a look.

Added a prop to handle it, Could you check this? @llaske

@VishnuVardhanBR smart fix :clap:
Two remarks:

I'm not a big fan of the property name includeIconClass , I think disableHoverEffect will be better.
With this fix the popup header item lost fully its hover effect effect, it will be nice to fix the header item too.

Made changed, could you check this @llaske ?

The idea was to highlight the whole header to be consistent with items.

The idea was to highlight the whole header to be consistent with items.

I misunderstood, made changes now, can you please check @llaske ?

Good. Thanks


Fix the cp command in the release publish task

Changes
Before Tekton Pipelines v0.24.x, $HOME and workDir were implicitly set,
which rendered the cp command redundant and hid the issue.
Partially fixes tektoncd/plumbing#856
Signed-off-by: Andrea Frittoli<EMAIL_ADDRESS>/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Docs included if any changes are user facing
[ ] Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes
NONE

/test check-pr-has-kind-label


Check if LIG is already at DB

Codecov Report

Merging #18 into master will decrease coverage by 0.25%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   70.51%   70.25%   -0.26%
==========================================
  Files          13       13
  Lines         970      975       +5
==========================================
+ Hits          684      685       +1
- Misses        286      290       +4

Impacted Files
Coverage Δ

...ng_oneview/ml2/drivers/oneview/database_manager.py
38.35% <16.66%> (-1.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2978632...dca2007. Read the comment docs.


Comprehensive example task running training workload on GPUs using Jobset

Comprehensive example task running training workload on GPUs using Jobset
Addresses issue#: https://github.com/kubernetes-sigs/jobset/issues/429

@uroy-personal The goal of that issue was to have real examples with GPUs. This seems to be restating our examples.

If you don't have access to GPUs, it may be worth leaving this issue open for someone else. I also do not have access to GPUs or the means to acquire them so I am out also.
Our hope is to have a real example with training on a GPU so people can see how this is used in practice.

Thanks @kannon92 ,
Let me unassign the issue.


License for this package

Hallo,
First of all thanks for your work.
Do you mind setting a license for your package ? (MIT like meteor).
I cannot not use it without it.
Many thanks,
Herve

yep, done.


Encountering AttributeError running Cassini example

I'm attempting to run SpiceyPy 2.1.0 on a Mac Pro (late 2013) running Mac OS X ver. 10.12.6 under Python 2.7.13. The documentation gives an example running SpiceyPy beginning on page 9 called the Cassini Position Example. The code has been attached to this note named cassini-2.py.txt. In running this example I noticed the following.

The command spice.tkvrsn("TOOLKIT") does not output the toolkit version as cited in the documentation
All remaining messages output to standard output are identical to what is shown in the example in the documentation.
Lastly, an AttributeError is encountered with the message:
Traceback (most recent call last):
File "/Users/user/Desktop/Cassini_Example/cassini-2.py", line 86, in
ax.plot(positions.T[0], positions.T[1], positions.T[2])
AttributeError: 'list' object has no attribute 'T'

From what I can tell, positions is a list 4000 elements long, where each element is a Cartesian position vector for each interstitial point in time and that
ax.plot(positions.T[0], positions.T[1], positions.T[2])
is attempting to reshuffle positions so that X, Y and Z components form the first, second and third arguments respectively.
The questions I have are:

Am I interpreting things correctly?
How do I correct the error?

Please advise.
cassini-2.py.txt

I believe I found a workaround for the ArrtibuteError. I took the positions list and used numpy.vstack function to stack the arrays vertically and stored the stacked arrays in a new variable xyz_pos. Then in function plot, sliced xyz_pos for the Xx, Y and Z components to be plotted (see attached file).
Hope this helps.
cassini-3.py.txt

I believe I found a workaround for the ArrtibuteError. I took the positions list and used numpy.vstack function to stack the arrays vertically and stored the stacked arrays in a new variable xyz_pos. Then in function plot, sliced xyz_pos for the Xx, Y and Z components to be plotted (see attached file).
Hope this helps.
cassini-3.py.txt

@OrbitalMechanic what toolkit version is being output? If it is not N66 then something is wrong.
second, it sounds like I neglected to update the cassini example in the documents for the new version. Currently it looks like it is returning a list of tuples which I think used to return a numpy array. Using Vstack is a more than reasonable solution and I could just update the example to include it, but I am still curious about the version mismatch.

Andrew,
Thanks for getting back to me. The CSPICE version I get is N0066, so I have the correct version of CSPICE installed.
f you wish to  use my workaround in the SpiceyPy documentation, please be all means feel free to use it.
Lastly, from taking a closer look at the Cassini example, it seems to me that the example was run in Jupyter, is that correct?
Once again, thanks for getting back to me.
Sam Dupree.

Yes, it was run in a jupyter notebook, hence the missing print calls.


Delay at the measurements of ram and cpu

Describe The Bug
Hello,
with the update to 4.56.1 the measurements from the start page / dashboard are delayed. In previous version the loads are very exactly and fast.
Now, is very slow and inaccurate. Load injections are no longer displayed.
The refresh rate needs to be set high again.
Greetings
Patrick
Logs
No response
Config
No response
Homebridge UI Version
4.56.1
Homebridge Version
1.7.0
Node.js Version
18.19.0
Operating System
Raspberry Pi OS / Raspbian
Environment Info
None
Raspberry Pi Model
Raspberry Pi 4 B

Hi @HackyPaddy can you try the beta version of the UI? see if this has improved? there are options in the widget settings to set the refresh rate of each 'graph' widget


REST: maybe return 204 if the provide return value is empty?

Need to check the specs and everything but it might make sense to return 204 and no content-type if there's ultimately nothing to return (instead of sending back an empty JSON or whatever).

No. 204 is for requests where an action is to be performed. If we get a resource and there's nothing, then either an empty 200 is better (indicating success but with nothing returned explicitly) or a 404 if there's no resource.


Add ability to coerce garbage collection of lost tasks.

https://github.com/mesosphere/marathon/pull/4004 added more TASK_LOST handling and garbage collection, but sometimes a bad event occurs and a task really is lost during the process. An operator might not want to wait until task_lost_expunge_gc for the tasks to be reaped, and would like for select task ids to be expunged immediately.
This ask is that there be a way to immediately expunge lost tasks (by task id) that are waiting for garbage collection.

This is probably addressed by https://github.com/mesosphere/marathon/commit/25ce737e39a370a151c119022b8d16523f04e990

Hi @drcrallen,
through #4117 it should be possible to expunge immediately after receiving TASK_LOST. Could you retest your issue in 1.3.0-RC5?
Thanks
Johannes

@unterstein unfortunately the only deployment workflow I have right now is what can be found in the mesosphere repository.

looks like marathon_1.3.0-1.0.502 might be available, but I'm not sure what the mapping of 1.0.502 to RC? is.

Installed marathon=1.3.0-1.0.502.ubuntu1404 from deb http://repos.mesosphere.io/ubuntu trusty-testing main and [Kill] button works as expected.
Upgrade process acted weird where marathon thought more application instances were running than really were, but killing the superfluous ones fixed the problem.

Thanks!

Awesome :)


A lot of fixes 💯

We've fixed:

Camera
Player's movement
Game loop
Map scaling

The CI is failing because testSlimeFollowBat fails, maybe @jackmounts have a look at it

Please fix tests and we can merge this


Run APIM testgrid build job for each build in WSO2 Jenkins CI

Description:
We need to periodically run product-apim build for each build that has happened in WSO2 Jenkins instance. [1]. The latest stable distribution ZIP can be downloaded from [1].
When this is in place, whenever a build has failed, we need to generate the report and send it as a mail.
Approach:
We can use the periodic build trigger support available in the testgrid jenkins instance for this purpose.
[1] https://wso2.org/jenkins/job/products/job/product-apim_2.x/lastStableBuild/org.wso2.am$wso2am/
Affected Product Version:
0.9.0-m16
Steps to reproduce:
N/A
Related Issues:
#509

@kasunbg : Currently, APIM CF scripts are based on pre-packaged AMIs. Thus, in order to complete this we need to either separate APIM deployment from AMI (as in Identity Server scripts) or have another job to create an AMI based on latest build (that's what Imesh has suggested).

@harshanL, I see. So, I guess we need an immediate workaround solution, and a long-term solution.
For the immediate solution, we can use pre-packaged AMIs. At build time, we should add the new pack into the AMI. Since AMIs are immutable, we will have to create a new AMI based on the pre-packaged AMI.
This new AMI will be the input into the cloudformation scripts.

This is done.


Causes crashes when used with the newest Embeddium.

Embeddium  0.3.0
TexTrue's Embeddium Options 0.1.3
game 1.20.1
crash-2024-01-30_17.59.08-client.txt

I'll be releasing a new version to fix this later on.


User Switching via HOSContract.METHOD_GET_HOS

Summary
This PR updates the HOSContract to version 0.4 to support multi-user logins to allow for driver switching to be reflected in the HOS Consumer application when querying HOSContract.METHOD_GET_HOS.
For the HOS Consumer to support the user switching the KEY_HOS(sometimes referred to as active driver) will need to know the username provided by IdentityContract.DriverSession.username during the IdentityConsumers(ELD app) query METHOD_GET_LOGIN_CREDENTIALS.
There is an  RFC currently open for discussion that this work is intended for.
The most notable callout from the RFC is the need to remove Parcel as our means of data transfer within Bundle. Parcel does not like having missing data if the applications communicating do not have matching Class versions.
We've decided to show the work required for Option 2 on the RFC above as that is the preferred direction we would like to go. This allows us to have less Class name changes in the future to support backwards compatibility.
One change to note below is HOSTeamData. To cleanly pass a list of HOSData we've now placed that within it's own object called HOSTeamData that contains the ArrayList<HOSData. This allows the JSON conversion to be called without needing a list conversion or TypeToken.
Data Objects
Version = 0.4
HOSStatusV2(0.3) -> HOSData(0.4)
HOSClockV2(0.3)  -> ClockData(0.4)
ArrayList(0.3) -> HOSTeamData(0.4)
HOSData -> Returned from HOSContract.METHOD_GET_HOS within KEY_HOS
username addition
{
  "clocks": ClockData[],
  "logoutAction": "",
  "manageAction": "",
  "username":""
}

HOSTeamData -> Returned from HOSContract.METHOD_GET_HOS within KEY_TEAM_HOS
{
  "teamHosData": [
    {
      "clocks": ClockData[],
      "logoutAction": "",
      "manageAction": "",
      "username":""
    },
    {},...
  ]
}

Sample Provider Bundle Call
From the provided Java object
HOSData hosData = createHosData(); //Provider implementation of createHosData()
result.putString(HOSContract.KEY_HOS, gson.toJson(hosData));

or straight from JSON itself
String jsonData = getHOSJson() //Provider generated
result.putString(HOSContract.KEY_HOS, jsonData);

Sample Consumer Bundle Call
HOSContract.HOSData hosData = gson.fromJson(result.getString(HOSContract.KEY_HOS), HOSContract.HOSData.class);

@treverthomasET @pnc I just want to be clear about the expected object shape, should this PR be merged.
Can you please confirm that the expected object should look like this, with just a single array for all drivers' HosData?
If so, is the expectation that the driver currently operating the vehicle is first in the array?
{
    "teamHosData": [
      {
        // HosStatus for driver
        "clocks": ClockData[],
        "logoutAction": "",
        "manageAction": "",
        "username":""
      },
      {
        // HosStatus for coDriver1
        ...
      },
      {
        // HosStatus for coDriver2
        ...
      },
      ...
    ]
}

From my understanding, this is an example of what is not expected:
{
    "hosData": {
        // HosStatus for driver
        "clocks": ClockData[],
        "logoutAction": "",
        "manageAction": "",
        "username":""
    },
    "teamHosData": [
      {
        // HosStatus for coDriver1
        ...
      },
      {
        // HosStatus for coDriver2
        ...
      },
      ...
    ]
}

@BoKlassen Ah I can see how that could be confusing. I've updated the Data Objects section above to hopefully clear it up slightly for any other future readers:
When the HOS Consumer calls HOSContract.METHOD_GET_HOS we will be expecting your second definition where
KEY_HOS contains HOSData for the driver
{
"hosData": {
        // HosStatus for driver
        "clocks": ClockData[],
        "logoutAction": "",
        "manageAction": "",
        "username":""
    },
}

and KEY_TEAM_HOS will contain HOSTeamData corresponding to any team drivers/co drivers
{
"teamHosData": [
      {
        // HosStatus for coDriver1
        ...
      },
      {
        // HosStatus for coDriver2
        ...
      },
      ...
    ]
}


.gwy file not uploading

Hello,
I tried to upload a .gwy file but it did not work.

Hi @ArushiPradhan , I see that there is a problem. Can you send me the specific file that caused the error by makl (and indicate whether I can include it in our public repository for testing).

Hi @ArushiPradhan - can you check whether this problem has been resolved? I have made fixes to the GWY reader.


Adds index.js to purchase integration folder to fix north compatibility

North imports all modules (or better: *.js) found in each the integrations folders in contrib. Since the nag-categories.js file is no source in itself, this breaks North. Added a quickfix but not sure if this may break Bloom?
Alternatively we just fix it in North, i.e. ignore the Purchase integrations (since they are not active anyway...)

I'll test this today, but as an alternative we could also move the nag-categories.js to integrations/utils/ instead? That's kind of what it is anyway :)

yep it works, i.e. at least doesn't crash the app on launch ;)