DBInstance/DBCluster password updates on secret ref changes

This patch adds a new feature to the rds-controller allowing users to
update their DBInstance and DBCluster passwords, by modifying the
secretReference (namespace, name or key).
Prior to this patch the controller wasn't able to update DBInstance
and DBCluster passwords due to it's inability to calculate the
difference between a desired and observed states. The fact that the
API doesn't return any information about the password combined with the
controller unable to detect changes of the secret refs
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/retest

/retest

/retest

/lgtm


clarification about trx.raw and objection.raw ?

Hi,
something i often wonder:
do trx.raw (when trx is created by transaction.start()) and objection.raw are the same ?

trx is just a knex transaction, so trx.raw is the knex raw method. objection.raw is a wrapper around knex.raw with some additional methods.


docs(README.md): Update antd-mobile example code

TL;DR: antd-mobile changed their naming convention for css related files.
you can find detailed context at this issue

Coverage remained the same at 100.0% when pulling 062ee40be8e9bc80b4b5e6b8fc22220590e07897 on adoji92:adoji92-patch-1 into 1abde00e0011e5b6da46f691d4a55553fba534e6 on Brooooooklyn:master.

It looks great，thank you


Add warning for @ prefix in build.transpile

Describe the feature
Summary
Warn users about incorrect @scoped/package usage instead of scoped/package in build.transpile array.
Background
Following an upgrade from Nuxt 3.12.4 to 3.13.1, usage of the @hyperdx/lucene from another Nuxt layer suddenly threw an error:
The requested module '/_nuxt/@fs/.../monorepo/frontend/node_modules/@hyperdx/lucene/lib/lucene.js?v=7e5012eb' does not provide an export named 'toString'

This issue seems related to https://github.com/nuxt/nuxt/issues/28631
I was able to solve the problem by adding
build: {
    transpile: [
      "hyperdx/lucene",
    ],
  },

to my nuxt.config.ts. As pointed out in https://github.com/nuxt/nuxt/issues/24064#issuecomment-1788740269,

Note in the transpile array there is no @ before typeform/embed,

the @ scope prefix from the npm package name needed to be omitted.
It would be helpful to get a warning or error message about the (presumably) incorrect @ prefixing of packages to be transpired.
Alternatives and questions

Could the implementation be changed to work correctly with @scoped/packages?
Would this better be fixed in another package?

Additional information

[X] Would you be willing to help implement this feature?
[ ] Could this feature be implemented as a module?

Final checks

[X] Read the contribution guide.
[X] Check existing discussions and issues.

This is a bug - you should be able to add '@hyperdx/lucene`. Would you be able to provide a reproduction? 🙏


System.AggregateException

When the todo:TodoListBaseAddress value in app.config is changed to the web app address from default https://localhost:44321, the following error is thrown.
System.AggregateException
HResult=0x80131500
Message=One or more errors occurred.
Source=mscorlib
StackTrace:
at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
at System.Threading.Tasks.Task.Wait()
at TodoListDaemon.Program.Main(String[] args) in C:\gitClones\active-directory-dotnet-daemon-master\TodoListDaemon\Program.cs:line 82
Inner Exception 1:
HttpRequestException: An error occurred while sending the request.
Inner Exception 2:
WebException: The underlying connection was closed: An unexpected error occurred on a send.
Inner Exception 3:
IOException: Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host.
Inner Exception 4:
SocketException: An existing connection was forcibly closed by the remote host

@WindowsQuery this means that your Web API is not running at teh expected address
Check that this works and is indeed at that URL.
The Aggregate Exception is only due to async calls ran synchronously.

The link works. It is when the same value is provided to add key="todo:TodoListBaseAddress" that it fails. And, should it not open the browser with that URL instead of http://localhost:9184/?
I am not sure if this is a working sample.

I have also just run through the example code. As the OP reported, everything works when the service runs locally.  When I deploy the service to Azure I'm also getting exception
"Unable to read data from the transport connection: An existing connection was forcibly closed by the remote host."
I successfully deployed my app to https://todoservice{omitted}.azurewebsites.net

My console app is configured correctly:
<add key="todo:TodoListBaseAddress" value="https://todoservice{omitted}.azurewebsites.net" />

Quick follow-up:  I redeployed the service as HTTP (not HTTPS!), changed the app registration reply and home page urls to http as well, and at that point the client could call the service successfully.  So, the web service itself is functioning.  It just is not working once the website is secured.
One thing I noticed in the steps is that one of the azure service deploy steps stated:

From the Settings -> Reply URLs menu, update the Sign-On URL, and Reply URL fields to the address of your service

I assume we're talking about the App Registration entry in Azure AD?  I found the setting called "Reply Url", but not "Sign-On URL", so instead I set the Reply URL, and the application's Home Page.  If there is a setting called Sign-On, I could not find it via the instructions.
Was this crucial, and if so, where can it be located?

Thanks for the heads-up @SgtSpamCan; things change quickly in the portal and we need to update our README.mds
@kalyankrishna1
If you have capacity, would you want to apply the new deployment steps to this sample?

@jmprieur  I'm honored to have you on the thread. Quick question: Was there something I missed regarding a Sign-On url?  Or is it no longer relevant?  Just trying to get my sample code working :-)

Hi, i had the same issue, fixed it with before making the post:
ServicePointManager.SecurityProtocol |= SecurityProtocolType.Tls11 | SecurityProtocolType.Tls12;
Some reason TLS 1.0 is always used, and changing the min TLS version in the App Service settings doesnt seem to work.

Did you try updating the sample to work with .NET Framework 4.7.2 ? it ensure TLS 1.2 is used.

Did you try updating the sample to work with .NET Framework 4.7.2 ? it ensure TLS 1.2 is used.

No, i was just running it as it was. Like you mention, updating it to 4.7.2 ensures TLS is used and removes the need to explicitly declare it.


After custom exception handler, if fail, how to put on failed

Hello all.
I've writed a custom exception handler and i'm retrying some jobs after a count number of failures.
After that max_retries reaches the limit, i want to put them in the failed queue.
I didn't figured out how this behavior should be implemented.
After retry, im returning an exception MaxTriesReached, and checking it on my custom exception.
If it's that, should go to failed.
But not happening...
Anyone have some scenario to help me out ?
Thanks in advance.

(assuming you mean "should go to failed queue")
I ran into a similar issue recently, I got around it by adding a second exception handler that moves to the failed queue...
RQ_EXCEPTION_HANDLERS = [
    'myapp.job_exception_handler',
    'myapp.move_to_failed_queue']

def move_to_failed_queue(job, *exc_info):
    worker = get_worker(job.origin)
    worker.move_to_failed_queue(job, *exc_info)
    return True

if you don't want everything moving to the failed queue you can keep just the one custom exception handler and do the move there...
RQ_EXCEPTION_HANDLERS = [
    'myapp.job_exception_handler']

def job_exception_handler(job, *exc_info):
    # ...
    # exception handler logic
    # ...

    worker = get_worker(job.origin)
    worker.move_to_failed_queue(job, *exc_info)

Thank @jsoa.
I will put this logic inside my exception and when i face this, i can put the job into failed from there ;)
Will test it ... Thanks once again ;)


don't enumerate figures and code snippets

We have no reason to keep a running enumeration on our figures and/or code snippets, and when numfig is set to True in docs/conf.py, it causes code snippets and figures with captions to have their caption prepended with Listing #. We can turn this back on and reckon with captions later if need be, but let's turn it off for now.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 90.703%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2556

Relevant Lines:
2818

💛  - Coveralls


How to reject Registration and Logins if request is not made from a client

In the scenario where IS4 is on myidentityserver.com and an MVC client on mvcclient.com, the current quickstart allows anyone to go directly  to myidentityserver.com and register as a user, without coming from the MVC client. Is there a way to forbid registration/authentication if the user does not access IS4 from the MVC client?

It's a normal MVC app at this point.
If the request comes via the OIDC endpoint - there must be a valid authorize URL on the returnUrl parameter - you could check for that.


Meta issue for formatting

[ ] [Indentation after inserting an argument and after a function call #481]
[ ] [MoveUp Line Auto-Indent #484]
[x] [Automatic whitespace formatting on Enter #640]
[x] [Editing python after inline if statement invalid indent #726]
[ ] [Automatic indentation inside brackets #701]
[ ] [Indentation level of else:-type lines is not reduced #771]

@MikhailArkhipov This issue along with auto import feature are what we are missing the most yet they gets the least attention. 2019 is coming in 10 days, will we ever see auto import or auto indent at this rate?

@DonJayamanne When are these going to be addressed? You mentioned stability issues were a priority, but now Jupyter and notebook issues are taking precedence over everything else. Auto Import and these formatting features are what the community is after. Did you do a survey to measure demand for notebook/these features? Because I'm fairly certain more users would demand quality of life improvements over a feature that hasn't had nearly enough upvotes?

Jupyter and notebook issues are taking precedence over everything else.

Not sure where you are getting this information. We have a completely separate team working on that. And another dedicated team working on language server.

understand that there were other priorities but 2019 is coming in 10 days, will we ever see auto import or auto indent at this rate?

We have a team working on the language server. As you mentioned they are working on stabilizing the LS. Assistance in speeding up this work such as testing development build, PRs, PR reviews is always welcome.
Please be patient.

If you're looking for a solution to most of these problems right now, you can try this extension I wrote

Closing in favour of #481.


Cycle Evergreen Animated Server Icons

name: Evergreen Animated Server Icon Cycling
about: Changes to the season logic to allow for cycling of icons daily
Closes #229

This adds the four animated versions of the default logo to the evergreen icons and alters the season logic to allow for seasons to contain a list of items that can be cycled through daily
Hope this is okay :D

I think you could just make it always use a tuple for icons because even with only a single element in the tuple, it should work (the cycle will just appear to do nothing since the index will never change).

Surely that means that all of the already-set icon URLs will need to be changed in the future? There might be times where only one is needed and whoever sets it will set it as a string rather than a tuple. I just think to be safe the logic should check for string or sequence

Yes, it means everything will need to be a tuple and I don't think it's a bad thing. Maybe others have different opinions on this. You've already done the work so I don't mind leaving it in but if I were to do this from scratch I would have not bothered supporting both strings and tuples as it makes the implementation simpler.

Done the other changes - although I'd love and appreciate getting more opinions on whether to convert all icon variables to tuples or support both formats


Polyline Crash on Undefined Globe Fix

For #5146. Ellipsoid assignment moved to update and check added for globe. Without the globe the polyline is drawn as a straight line segment. Hopefully this is appropriate behavior?

Looks good @WilliamKHo, thanks!  Can you update CHANGES.md and add a unit test?  The user who reported the issue posted a link to a sandcastle example that reproduces the crash in this post: https://groups.google.com/forum/#!msg/cesium-dev/UboMKwwn8Xk/noMUrTS7CQAJ

Hey please look over this?

Looks good!  You have a merge conflict though, so merge in master and we'll get this in

Ok should be good now!

:+1: thanks!


[SPARK-27520][CORE][WIP] Introduce a global config system to replace hadoopConfiguration

What changes were proposed in this pull request?
hadoopConf can be accessed via SparkContext.hadoopConfiguration from both user code and Spark internal. The configuration is mainly used to read files from hadoop-supported file system(eg. get URI/get FileSystem/add security credentials/get metastore connect url/etc.)
We shall keep a global config that users can set and use that to track the hadoop configurations.
This pr implements it with three main features showed below:

using ThreadLocal to track Hadoop Configuration, so that concurrent jobs could use their own Hadoop Configurations

provide set method by wrapping a Hadoop Configuration to allow user to modify Hadoop Configuration globally

provide SparkContext.withHadoopConf(){} method to allow user to modify Hadoop Configuration temporary

How was this patch tested?
TODO

Can one of the admins verify this patch?

cc @jiangxb1987

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10420/
Test PASSed.

Test build #105131 has started for PR 24530 at commit d217d95.

Test build #105131 has finished for PR 24530 at commit d217d95.

This patch fails MiMa tests.
This patch does not merge cleanly.
This patch adds the following public classes (experimental):
class SparkHadoopConf(conf: Configuration)

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105131/
Test FAILed.

Also, getHadoopConf doesn't sound like a great name, can we think out a better one?

Also, getHadoopConf doesn't sound like a great name, can we think out a better one?

Any suggestion ? Something like what ?

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10705/
Test PASSed.

Test build #105442 has started for PR 24530 at commit 8fe58c4.

Test build #105442 has finished for PR 24530 at commit 8fe58c4.

This patch fails due to an unknown error code, -9.
This patch does not merge cleanly.
This patch adds no public classes.

Build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105442/
Test FAILed.

Test build #105444 has started for PR 24530 at commit f3f217f.

Test build #105444 has finished for PR 24530 at commit f3f217f.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105444/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10708/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10711/
Test PASSed.

Test build #105448 has started for PR 24530 at commit e75b51f.

Test build #105448 has finished for PR 24530 at commit e75b51f.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105448/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10723/
Test PASSed.

Test build #105461 has started for PR 24530 at commit d5ccf63.

Test build #105461 has finished for PR 24530 at commit d5ccf63.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/105461/
Test PASSed.

@jiangxb1987 Could you have another look please ?

@jiangxb1987 Any update?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12056/
Test PASSed.

Test build #106839 has started for PR 24530 at commit 9946fb7.

Test build #106839 has finished for PR 24530 at commit 9946fb7.

This patch fails Java style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class SparkHadoopConf(var conf: Configuration)

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106839/
Test FAILed.

@Ngone51 please fix the Java style tests failure, thanks!

Jenkins, retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/12183/
Test PASSed.

Test build #106983 has started for PR 24530 at commit 9946fb7.

Test build #106983 has finished for PR 24530 at commit 9946fb7.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class SparkHadoopConf(var conf: Configuration)

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/106983/
Test PASSed.

Build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/15698/
Test PASSed.

@Ngone51 are you still working on it?


Political overlay disappeared migrating to v11 from v10

Where can I find the political overlay for my world saved? I have a backup, not sure where or how to import it.

For a given scene, you can find it in the scene's flags. Here's an example:
"flags": {
   "polmap": {
      "visible": true,
      "gmAlpha": 0.33,
      "playerAlpha": 0.5,
      "history": {
         "events": [
            [
               {
                  "shape": 3,
                  "vertices": [
                     2200,
                     1039.2304845413264,
                     2175,
<PHONE_NUMBER>521045,
                     2125,
<PHONE_NUMBER>521045,
                     2100,
                     1039.2304845413264,
                     2125,
                     1082.5317547305483,
                     2175,
                     1082.5317547305483,
                     2200,
                     1039.2304845413264
                  ],
                  "x": 0,
                  "y": 0,
                  "fill": "0xffa800"
               }
            ],
            ...
         ],
         "pointer": 5
      }
   }
}

If you have your v10 world data backed up, you can find the data in worlds/<world>/data/scenes.db.
The module is not yet updated for v11, though, please see #10.


ASCII STL with empty name cannot be read

When loading an ASCII mesh which has the first line as 'solid ',
numpy-stl issues a warning:

ASCII STL files should start with solid . The application that produced this STL file may be faulty, please report this error. The erroneous line: b'solid'

And then falls back to binary loading which also fails.
The name of the solid is optional, I believe.

"The erroneous line: b'solid'"
The fix is to convert it from bytes literals to unicode literals.
To clarify b'solid' == 'solid' will return False.

I don't think that's relevant at all, even though I'm not really aware of prefixes. What I've seen inside stl.py is that get() strips the line, so from 'solid ' it becomes 'solid'. Then its beginning is compared with 'solid ' and the warning is printed. Obviously it would not happen with any non-empty name.

But I might be on the wrong track here... Now I've added a name and get RuntimeError: (True, "b'outer loop' should start with b'facet normal'").

Alright, disregard that. I have some other issue with the way I write my STL files, it seems. This warning gets printed with literally any STL ASCII file with an empty name (and shouldn't be), but the minimal ASCII file actually gets loaded, so it's not critical. Numpy-stl is 2.7.0 from pip, using python 3.5.2.
python3 -c "from stl import mesh; m = mesh.Mesh.from_file('min.stl.txt'); print('Points count ' + str(len(m.points)))"
min.stl.txt

Clear.
It is a warning message, yet no Exception is raised if the mesh is in proper order.
(tried adding some other polygons, no issue with loading, although it complains about the header).
Maybe we can think about adding support for empty headers. Technically an ASCII STL can be valid with empty header, although the trailing whitespace after solid is still mandatory.

Issue is with line 156 in stl.py. Stripping whitespace will flag the technically correct b'solid ' the same as b'solid' which should indeed raise the warning.
    if not line.startswith(b('solid ')) and line.startswith(b('solid')):
        cls.warning('ASCII STL files should start with solid <space>. '
                    'The application that produced this STL file may be '
                    'faulty, please report this error. The erroneous '
                    'line: %r', line)

should be moved to within the get method.

I think it might be best to simply remove that check, it probably doesn't matter anyhow :)


3D car doesnt show in the started data

When i replay the started data the 3d car doesn't show me i dont know why. I uncheck and recheck the vehicle model because says status error and after says status ok but i dont see any car in 3d.

did you manage to resolve it? I have the same issue!


No extension method "normalized" on Vector3 with C#

Operating system or device, Godot version, GPU Model and driver (if graphics related):
Windows 10, Godot 3.0 beta 1 with AMD R5
Issue description:

Tried to normalize a Vector3 using .normalize() method with C#, it used to work in alpha 2 and there's a method reference in the class but now I get the following error:

Steps to reproduce:
Create a variable of type Vector3 and normalize it.
Link to minimal example project:

GodotSharpTest.zip

isn't it Normalized with an uppercase N?

Yes, the methods in core types use PascalCase now.


Change token Contract owner to Timer Contract

Continue from https://github.com/OpenWorldVision/OpenWorld-Project-Management/issues/26 completion


Move CallStack to Exception::CallStack

And remove explicit filter of function prefix names since they are handled in Exception::CallStack.skip(__FILE__).
Since CallStack was nodoc, there is no deprecation needed.

But caller returns the callstack and it's not related to any exception.

Alternatives to keeping it on the top level I see are Crystal and Debug. None of these seems like a perfect fit though. I don't think it really matters where it lives as it's a nodoc type mostly transparent to the user. Exception makes sense since that's its main consumer in stdlib. I've seen languages categorizing their caller into their exception framework and providing it there as something like Exception.current_callstack or so. So I think this is fine really.

caller returns an Array(String), so is more an implementation dependency than a return value.
I added some documentation to it and clarify the return type.
To fully hide the CallStack as it was intendend the Exception#callstack property needs to also be :nodoc:.

caller returns an Array(String), so is more an implementation dependency than a return value.

Oh, yeah, makes sense 👍

Heads up: this PR broke BC with Crystal 0.34.0.

In what way did id break something? As far as I can see it's merely an internal refactor.

If someone relied on CallStack being defined in the top-level namespace then this PR broke it - I know it's :nodoc:-ed, just saying.


Interop plans

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

I managed to get the NSS interop tests running by adding --sysctl net.ipv6.conf.lo.disable_ipv6=0 to docker run (see my experimental PR).
Other things that I think could be improved:

make shallow  copies with git clone and git submodule update (add --depth=1)
look into possibilities of pre-building the docker image in some registry to save tim

Hi @ep69,
Thanks!
I have checked the possibilities and this time I went for the GitHub Container Registry, it could be an option to consider. Currently, the image resides here
We should make the image source (docker file) public too. Will we just upload the source in the repo for reference?
Docker file:
FROM fedora:latest
RUN dnf -y update
RUN dnf -y install perl
RUN dnf -y install git tmt-all
RUN dnf -y remove openssl
RUN mkdir /root/bin
RUN echo '#!/bin/bash /openssl/util/wrap.pl /openssl/apps/openssl' > /root/bin/openssl & chmod +x /root/bin/openssl
RUN git clone --depth=1 -b interop-plans https://github.com/not4pedro/openssl.git
WORKDIR /openssl/
RUN  git submodule update --depth=1 --init interop
RUN ./config --banner=Configured no-asm no-makedepend enable-fips --strict-warnings && perl configdata.pm --dump
RUN make -s -j4
WORKDIR /openssl/interop

In terms of layers of this docker file, I see there is still room for improvement too.

I think the best next step would be to create an official PR in openssl project. I am pretty sure they won't like a dependency on the image registry in your personal profile, so make the first version as is with building the image on the fly and suggest to use openssl registry as a speed improvement, if desired.


Misplaced files after running synx

After running synx on our project my file system had a new Testing folder within our project folder that included some tests that should have been with the other tests in the separate Testing folder we have. The organization of the files in the Xcode project looked correct. When I pushed the app to our remote repo, the Testing folder within our main project folder didn't exist. As a result the files that had been put in that folder were no longer accessible to anyone pulling from the remote repo.
I have the output from running synx but it contains sensitive information related to the purpose of the app  we are developing at LinkedIn so won't share it publicly. I will share the relevant parts with names changed to protect sensitive information.
From looking at the output I have an idea of what went wrong. In the "Syncing files that are included in Xcode project..." step the file structure for the Testing folder included all the files in their right place except for one missing one that ended up in the new Testing folder subfolder of our main project folder.
Link to what the output looks like
In  "Syncing files that are not included in Xcode project.." step the structure of the Testing folder
includes that exact missing file in the right place but doesn't include the other test that ended up in the Testing subfolder of our main project folder.
Link to what the output looks like
Even after fixing this issue locally and pushing it, the file structure in our remote repo is still wrong.
I appreciate help understanding this issue and avoiding it in the future.

The organization of the files in the Xcode project looked correct. When I pushed the app to our remote repo, the Testing folder within our main project folder didn't exist.

That makes me think that your issue might be related to https://github.com/venmo/synx/issues/64
Where is your .git relative to your project?

.git is at the same level as our MainProjectFolder and the Testing folder.

Hey @mathonsunday,
Could you provide file trees for the following --

What the relevant areas of the xcode project looked like before Synx
What the relevant areas of project on disk looked like before Synx
What the relevant areas of the xcode project looked like after Synx (this should hopefully be the same as 1)
What the relevant areas of project on disk looked like after Synx

Thanks!

Thanks for the response Mark. I  have decided to stop our team from using synx instead of sinking any more time into debugging the problem.


Move event struct into timeboard graph definition

Fixes issue with PR #60 where event struct was in base of the graph struct instead of graph.Definition.

What's better than a PR? A fix for the PR very shortly after :) Thanks for being quick!


install typing_extensions

Checklist before submitting

[x] Did you read the contributor guide?
[ ] Did you update any affected documentation?
[ ] Did you write any tests to validate this change?

Description
Added to resolve the following test failure:
Failed test: Run PyTorch test_jit_fuser_te
Running test_jit_fuser_te ... [2020-12-28 14:27:15.606876]
Executing ['/opt/conda/envs/opence-conda-env-20201228141615/bin/python', 'test_jit_fuser_te.py'] ... [2020-12-28 14:27:15.606927]
Traceback (most recent call last):
  File "test_jit_fuser_te.py", line 28, in <module>
    from test_jit import backward_graph, all_backward_graphs, get_lstm_inputs, get_milstm_inputs, \
  File "/home/builder/refresh_16Dec/pytorch/test/test_jit.py", line 8, in <module>
    from jit.test_recursive_script import TestRecursiveScript  # noqa: F401
  File "/home/builder/refresh_16Dec/pytorch/test/jit/test_recursive_script.py", line 5, in <module>
    import typing_extensions
ModuleNotFoundError: No module named 'typing_extensions'
Traceback (most recent call last):
  File "test/run_test.py", line 745, in <module>
    main()
  File "test/run_test.py", line 728, in main
    raise RuntimeError(err_message)
RuntimeError: test_jit_fuser_te failed!

Review process to land

All tests and other checks must succeed.
At least one maintainer must review and approve.
If any  maintainer requests changes, they must be addressed.

I was still seeing this failure with py38 so added another PR - https://github.com/open-ce/pytorch-feedstock/pull/29

I was still seeing this failure with py38 so added another PR - https://github.com/open-ce/pytorch-feedstock/pull/29


Link to the publication's whitehall-admin URL from the CSV export

The default not being whitehall-admin.ENV.alphagov.co.uk was
confusing to people using the CSV export feature as they then had to
copy and paste the path onto the end of a whitehall-admin URL. This
makes whitehall-admin.ENV.alphagov.co.uk the default (using the
existing Whitehall.admin_host method) and gives the ability to
specify a hostname (e.g. www.gov.uk) in the parameters for
admin_edition_url.

Thanks to @evilstreak for helping with this!

This means that we can get rid of host: Whitehall.admin_host parameters in all calls to admin_edition_url, as it's now the default. Should I do that now?
A search reveals their existence in https://github.com/alphagov/whitehall/blob/master/test/unit/helpers/govspeak_helper_test.rb#L42, https://github.com/alphagov/whitehall/blob/master/lib/tasks/export.rake#L80, https://github.com/alphagov/whitehall/blob/master/lib/tasks/export.rake#L121, https://github.com/alphagov/whitehall/blob/master/lib/whitehall/exporters/redirector_document_mappings.rb#L24, and all through https://github.com/alphagov/whitehall/blob/master/lib/whitehall/exporters/redirector_document_mappings.rb.

That sounds like a good idea to me

@evilstreak Done.

:+1:

LGTM :+1:

Thanks!


Improve the robustness of polygons imported via gdal.

When importing polygons via gdal, automatically invert loops representing polygons larger than half of the Earth's surface. Add a command line flag to disable this, in case these polygons are expected (instead of being the result of incorrect polygon winding order - the common case). Additionally, verify that loop geometry is still valid once it's marshalled into the compact world. In rare cases, quantisation during point conversion and invalidate geometry, and if this happens, we drop the loop.

lgtm 🫠


Storage- / Crafting-Terminal show double amount of items

If you connect double chests to an inventory connector the amount of items is wrongly shown double the amount.
E.g. you have 1 Book in a double chest but the storage terminal shows 2.
On verion <IP_ADDRESS> with 67 other mods. The error occurs even with only the storage mod present.
Fabric Loader 0.11.6

This was fixed in 1.1.12 of Tom's Storage


Update export-paginated-report.md for SSO with SQL and Dataverse

Making it more clear for how to use an access token with Azure SQL and Dataverse when the user has set SSO on the credentials.

@bradsy : Thanks for your contribution! The author(s) have been notified to review your proposed change.


Can't unindent automatically for Verilog files

I actived the verilog language mode of CodeMirror by following code, and it can works well.
define(function (require, exports, module) {
  'use strict';

  var LanguageManager = brackets.getModule("language/LanguageManager");

  LanguageManager.defineLanguage("systemverilog", {
    name: "Systemverilog",
    mode: "verilog",
    fileExtensions: ["v", "sv", "vh", "svh"]
  });
});

But only one problem is that, brackets can't unindent automatically when I type some keywords like "end", "endtask", "endfunction", etc, which were suppost to be.
And I tried with CodeMirror's demo, it can works correctly. So I think there may be an issue or I made some mistakes.

@vfraloo Hii.. Changes has been merged into master. Can you please verify and close the issue if fixed..

Verified. Indentation is working fine.. Closing..


Handle Region Initialization for FedRAMP

On non-govcloud account the operator expects there to be a default subnet to be used when creating and terminating ec2 instances. Per https://docs.aws.amazon.com/govcloud-us/latest/UserGuide/govcloud-ec2.html#govcloud-ec2-vpc govcloud accounts may or may not have a default subnet. Therefore, when in govcloud env, AAO needs to create a vpc, one subnet, run the ec2 instance, tear it all down.

Codecov Report

Merging #674 (c191048) into master (34f6f7a) will decrease coverage by 0.38%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #674      +/-   ##
==========================================
- Coverage   31.55%   31.17%   -0.39%
==========================================
  Files          47       47
  Lines        4649     4706      +57
==========================================
  Hits         1467     1467
- Misses       3084     3141      +57
  Partials       98       98

Impacted Files
Coverage Δ

pkg/awsclient/client.go
0.00% <0.00%> (ø)

pkg/controller/account/account_controller.go
13.50% <0.00%> (-0.17%)
:arrow_down:

pkg/controller/account/ec2.go
0.00% <0.00%> (ø)

pkg/awsclient/tags.go
0.00% <0.00%> (ø)

/hold

/retest

/lgtm

/hold cancel


add support for RGBAF16 pixel format.

Tested both bitmap and writeable bitmap:
var bmp = new WriteableBitmap(new PixelSize(100, 100), new Vector(96, 96), PixelFormat.RgbaF16);

                using var framebuffer = bmp.Lock();

                var span = new Span<FPixel>(framebuffer.Address.ToPointer(), 100 * 100);

                for (int i = 0; i < (100 * 100); i++)
                {
                    span[i].R = (Half)1.0f;
                    span[i].A = (Half)1.0f;
                }

                image.Source = bmp;

You can test this PR using the following package version. 11.0.999-cibuild0028328-beta. (feed url: https://pkgs.dev.azure.com/AvaloniaUI/AvaloniaUI/_packaging/avalonia-all/nuget/v3/index.json) [PRBUILDID]

We probably want to add a full range of pixels formats rather than just adding them one-by-one? I notice that currently our pixel format enum is in the Avalonia.Platform namespace which means its kind of an implementation detail anyway.
We could add a PixelFormat struct like in WPF or use the WUFFS encoding that skia uses

Closing this PR temporarily due to inactivity. Please ping me if this needs to be reopened.


Create expectations for foundation draft

With the intent to merge the Node.js Foundation and JS Foundation being announced, those interested in the continued support of Node.js and JS-related projects are working through expectations and structure for what the potential new foundation could look like.
This document is for the initial phase of work for the Bootstrap team to draft requirements that overlap with scope of the Board in order to provide an outline and structure for the foundation attuned to the needs of the projects and ecosystem stakeholders who have participated.
If lines are removed from this document, it may not be because they have been -1ed for application in the design of the new foundation but may in fact just be outside of the scope of this particular document.
This document is intended to be delivered to the Node.js Foundation and JSF Boards in order to outline the recommended structure of the foundation and to inform the Bylaws first draft.

I'd also recommend reading section 4.5 from either bylaws concerning the circumstances by which the board can remove a member.

From today's meeting
Sections of bylaws that merit a lot of attention include:

composition of board
composition of committees
what it takes to amend bylaws
how decisions are made
different classes of members and who/how gets on the board

Since there has not yet been an update to this PR should we remove it from tomorrow's agenda?

We will likely want to update this file with content from here: https://github.com/nodejs/bootstrap/pull/7/files#diff-ad1ebdc23d253b21a8c6f6669edc6083
@hackygolucky, would you like me to PR it in to your fork, or open a new PR with both PR's content?

here are the bits referred to by @amiller-gh
- Communicated scope for the foundation and board
- Annual reviews of staff, NPS, board, programs, support services to projects for accountability and incremental improvement
- The Foundation staff, executive director, and board should follow a "servant leadership" style.
- Non-corporate member representation in budget / finance subcommittee
- Projects values should drive foundation focus and priority
- No "pay to play" in technical participation
- Earmarking allowed with flexibility in budgeting for concerns and needs of individual projects
- Value satisfaction: regular feedback from projects

@rubys Thanks for all the work with #8 I think it goes a long way to inform what should be here, especially because the ByLaws are arguably the only area that needs to be signed off on before we figure out concretely whether the merger moves forward–it's the area that projects+boards+exec should be in complete overlapping agreement on in the venn diagram of responsibilities of making the foundation tick. Governance otherwise lies in the hands of the project(s).
@MylesBorins @rubys Looking through previous meeting notes and recent issues, have their been any major decisions in meetings that we think MUST be in this doc i.e. dealbreaker level of items to be in the ByLaws that should be here? Anything to highlight in the existing ByLaws of both foundations that we could request to be punted explicitly to the projects' responsibility instead?
@jasnell is there anything that was highlighted in the survey re: the merger that is an excellent concern to be surfaced as an expectation? I think the requests around accountability help cover a lot but I don't want to overlook something.

Per requests in the last Bootstrap meeting, drafted this thing up HERE after incorporating past expectations documents along with discussions we've been having in this PR. Unless there are any objections, I will close this PR in order to follow the proposal process we have now shipped.

Closing as discussed in the meeting


Run command

Add a basic run command (with no flags for now) 🐨. This is a rewrite of #133 using now engine-api.
# libcompose run <service> <command>
$ ~docker/libcompose/libcompose-cli run web ls
WARN[0000] Note: This is an experimental alternate implementation of the Compose CLI (https://github.com/docker/compose)
bin  boot  dev  etc  home  lib  lib64  media  mnt  opt  proc  root  run  sbin  srv  sys  tmp  usr  var
$ ~docker/libcompose/libcompose-cli run web /bin/sh
WARN[0000] Note: This is an experimental alternate implementation of the Compose CLI (https://github.com/docker/compose)
# ls
bin  boot  dev  etc  home  lib  lib64  media  mnt  opt  proc  root  run  sbin  srv  sys  tmp  usr  var
# echo foo > /bar
# cat bar
foo

[x] Clean / refactor a bit the container.go side of this PR. container.go (and docker package) needs some cleaning / refactoring. <- will do in another PR.


[JAVA API] Java samples build with gradle, Kotlin sample

@dkurt

@likholat could you please resolve conflict?

@dkurt are you OK to merge this PR?

@likholat, @alvoron, sorry for delay. PR looks good to me except one comment. Please take a look.


Generation failed

Failed to generate repository with this cookiecutter template. Tried with another python virtual environment and installed all the packages, still unsuccessful.

can you tell us what operating system you're using, and the full path of the directory in which you're creating the cookiecutter?

can you tell us what operating system you're using, and the full path of the directory in which you're creating the cookiecutter?

I'm on windows 10, and the full path of the directory is
C:\Users\pmces\Documents>
And the template is downloaded at
C:\Users\pmces.cookiecutters\cookiecutter-napari-plugin
I tried on other diectories and disks on my computer, failed as well, for this same issue.

thanks!  will try to reproduce and figure it out

Thanks very much!!!

can you try one more thing for me, and type where git on your command line (where you were running the cookiecutter command)

one more thing... I haven't been able to reproduce it yet, including on windows... Can you paste the entire process here?  (including all of the inputs you used)?  Does it happen even if you just accept all of the defaults?

I tried this on one of my college's computer and it works.
It seems to be an issue with my computer.
I merged my D volume last month to C volume, and reinstalled anaconda to C volume, where it was previously on D. I guess this may cause some issues when cookiecutter trying to locate the files.
Is it possible to set the right path/file location for cookiecutter manually?

It seems to be an issue with my computer.

yeah, I tried to reproduce this a number of ways and couldn't.  I will say that you'll probably need to have git installed for cookiecutter to work, but in my case, when I uninstalled it, I got a very clear error that no version control system was found.  (not the label syntax incorrect error).  So I'm still unable to tell you what went wrong in your specific case

Is it possible to set the right path/file location for cookiecutter manually?

I'm not sure, would need to look through cookiecutter for that.


Unify callback structures

This branch removes the C++ callbacks structures and uses the plain C message_type_support_callbacks_t and service_type_support_callbacks_t
@dirk-thomas @tfoote @wjwwood ping

lgtm

lgtm

Thanks for your reviews.


cmd/compile: slice update with self subslice - write barrier probably not needed (?)

Commit b8543397 (CL 98757) changes encoding/binary to use explicit offset instead of buf = buf[1:] idiom with the rationale that buf = buf[1:] is slice data pointer update which in turn is done with write barrier, while using buf[offset] explicitly does not need to update buf slice pointer and so does not need to issue GC write barrier. The commit cites significant speedup for encoding/binary under GOGC=1 and notes that While running make.bash, over 5% of all pointer writes come from encoding/binary doing struct reads.
It was then noted there that instead of explicitly using offset and avoiding buf = buf[1:] update idiom for performance reasons, it would be better to instead teach the compiler to know that slice updates with destination array pointer pointing to the same array's underlying object as of original slice, e.g. as in
buf = buf[1:] does not need write barrier at all.
The conversation there contains the rationale for current compiler behaviour but also brings questions and arguments for why it can be done. It was suggested to move the conversation to the issues, so here it goes.

@josharian thinking out loud maybe it is better to instead teach the compiler to know that slice updates with destination array pointer pointing to the same array's underlying object as of original slice, e.g. as in
buf = buf[1:]

does not need write barrier at all?
The rationale (to my limited write barriers understanding) is that it is whole allocated object that is shaded by write barrier:
//     writePointer(slot, ptr):
//         shade(*slot)
//         if current stack is grey:
//             shade(ptr)
//         *slot = ptr
...
// 1. shade(*slot) prevents a mutator from hiding an object by moving
// the sole pointer to it from the heap to its stack. If it attempts
// to unlink an object from the heap, this will shade it.
//
// 2. shade(ptr) prevents a mutator from hiding an object by moving
// the sole pointer to it from its stack into a black object in the
// heap. If it attempts to install the pointer into a black object,
// this will shade it.

(https://github.com/golang/go/blob/d7eb4901/src/runtime/mbarrier.go#L21)
func shade(b uintptr) {
        if obj, span, objIndex := findObject(b, 0, 0); obj != 0 {
        ...

(https://github.com/golang/go/blob/d7eb4901/src/runtime/mgcmark.go#L1211)
func findObject(p, refBase, refOff uintptr) (base uintptr, s *mspan, objIndex uintptr) {
        s = spanOf(p)
        ...

(https://github.com/golang/go/blob/d7eb4901/src/runtime/mbitmap.go#L354)
and so for buf = buf[1:] the slice, either before or after the update, will be pointing to inside the same allocated object -> thus the mutator for sure won't hide the allocated object from GC and so there is no need to shade it with such updates.
Doing so in the compiler will fix the performance issue this patch solves, as well as automatically remove write barriers in other, probably many, places thus helping not only speed but also code size (#6853).
I appologize if there is something trivial preventing doing this, that I missed.
Kirill
/cc @aclements

@aclements says:
The danger here is subtle. We haven't done this because the update to buf could be racy and if we did this that race could break GC. Specifically, if one goroutine executes buf = buf[1:] without a write barrier while another executes buf = x with a write barrier, it's possible for the final value of buf to continue pointing to the original buf allocation, but for the garbage collector to think it points to the x allocation and free the original buf allocation.
Of course, racy Go programs are undefined, but right now the garbage collector is immune to these sorts of non-type-safety-breaking "benign" races (this is obviously a somewhat fuzzy argument, since races let you break type safety and that lets you break memory safety, and saying anything formal about "benign" races is notoriously impossible so what I'm saying is probably not true anyway, but we try :)

@dgryski says:
@aclements It would be interesting to see the effect such an update would have on code size and performance to know how much we're leaving on the table with this safety check on.

me says:
@aclements thanks for explaining. Am I right that with write-barriers enabled for both racy buf updates, the mechanism that prevents GC from deallocating wrong object is that in the current GC written ptr is always shaded too (https://github.com/golang/go/blob/go1.10-1-g678dede7bc/src/runtime/mbarrier.go#L162 (go1.10), https://github.com/golang/go/blob/0add9a4dcf/src/runtime/mwbbuf.go#L226 (tip)) ?
By the way the thread that performs buf = x with write barrier will always do shade(*slot). If there is buf = buf[1:] racing with buf = x, even if the former does not use write barrier, the shade(*slot) of buf = x thread will shade original buf object in any case (it either sees buf or buf+1 as *slot but they both actually lead to the same allocated object). If so, since shade actually greys an object and grey objects never become white - only eventually black, we can say that original buf underlying object will stay alive - not deallocated, and so it is safe to do buf = buf[1:] without write barrier.
But this goes contrary to what you say, and so there is probably some mistake on my side. Could you please explain where the above logic fails?
I'm GC newbie so please forgive me if I miss something well-known.

@josharian says:
@navytux would you mind opening a new issue and migrating this (interesting) discussion there? We tend to try to keep all conversation on CLs and issues. Thanks!

By the way the thread that performs buf = x with write barrier will always do shade(*slot). If there is buf = buf[1:] racing with buf = x, even if the former does not use write barrier, the shade(*slot) of buf = x thread will shade original buf object in any case (it either sees buf or buf+1 as *slot but they both actually lead to the same allocated object). If so, since shade actually greys an object and grey objects never become white - only eventually black, we can say that original buf underlying object will stay alive - not deallocated, and so it is safe to do buf = buf[1:] without write barrier.

@aclements, would you mind to please provide your feedback here?
If there is a chance write barriers could be avoided on slice updates it would be a pity to miss 1.11, because, even though Go is compiled, performance is sometimes too painfull, especially when GC bits are intermixed.
Thanks beforehand,
Kirill

@navytux, good call. You're right that we can do this optimization now. It wasn't safe the last time we considered it, but the barrier has changed since then.
Consider two goroutines:
goroutine A does buf = buf[1:]:

r1 = buf.ptr
buf.ptr = r1+1

goroutine B does buf = s:

r2 = s.ptr
r1 = buf.ptr
shade(r1)
shade(r2)
buf.ptr = r2

(Ignoring len and cap, which a race could obviously shear, but that's an orthogonal problem.)
Since the reads commute with each other and everything commutes with shade, the only orderings that matter are A1/B5, A2/B2, and A2/B5. This leads to four schedules worth considering:

A1-A2, B1-B5. This is simply a sequential schedule.
A1, B1, B2, A2, B3-B5. The original buf.ptr is no longer reachable. It was shaded, but this is harmless.
A1, B1-B5, A2. The original buf.ptr is still reachable, but this is okay because B3 shaded it.
B1-B5, A1-A2. Again, this is simply a sequential schedule.

Prior to the hybrid barrier, we didn't have step B3, which is what makes the third schedule above safe.

@aclements thanks a lot for feedback and coming with the patch. I'm glad my observation could be useful.
@josharian thanks also for triggering whole this topic with b854339.

Status update: CL 105258 started to implement the idea but also along the way decided to generalize WB relax rule so that anything could happen between corresponding load and store in the same goroutine, including other writes to pointer in question. That generalization however brought correctness issues because now the race problem could be e.g. 3-body problem of 2 goroutines and GC, for example:
( buf.ptr initially points to A )

G1
G2
GC

r1 = buf.ptr

buf.ptr = new(alloc B)

begin, enable WB

scan G2.stack

r2 = buf.ptr

buf.ptr = r1 (no WB; last use of r1)

scan G1.stack (marks A)

end

use r2

where G2.r2 results pointing to B while B was not marked.
( https://go-review.googlesource.com/c/go/+/105258/3/src/cmd/compile/internal/ssa/writebarrier.go#49 )

I do not have exact proof, but if we allow to omit generating write barrier only when:

write to pointer points to the same allocation as last seen by current goroutine for that pointer.

there won't be situations where intermediate buf.ptr instability could be leaking to another goroutine without being eventually marked, like in example above for G1 -> G2 leak of B:

if update to pointers points to another allocation as last seen by current G - either by reading that pointer or by writing to it - we just generate WB as we do currently. This way there is no chance for another goroutine to observe either current write, or later write, even if that later write would point back to original allocation, with GC missing to mark corresponding object as live.

if update to pointer points to the same allocation as last seen by current G - we know that without WB we are safe against write races from another mutator because WB triggered from that mutator would shade both inserted and deleted objects (see e.g. https://github.com/golang/go/issues/24314#issuecomment-379380829 for details).
additionally for this case, if WB is runtime disabled at the time of the write, because enabling or disabling WB happens a) only with the world stopped and b) even with planned safepoints everywhere still atomically with respect to

if writeBarrier.needed {
    // perform write-barrier notification to GC
}

generated code parts, we can say that all mutators would see WB either enabled or disabled consistently, and so if WB is not yet enabled GC is not yet running and thus, even though there is race for write, GC will start scanning stacks and heap only later after the race is over and this way cannot miss to mark survived objects as live.

@aclements I understand we are in code freeze now, but CL 105258 was mailed before the freeze and so it would be a pity not to get it finished for Go1.11. Like I already said even though Go is compiled, performance is sometimes too painfull, especially when GC bits are intermixed, especially taking into account that slice self-update idiom is very common. It would be a pity to miss relaxing write-barriers for this common case ...
I appologize if I miss something and this optimization still cannot be applied even with my corrected rule.
Thanks beforehand,
Kirill
/cc @cherrymui

Silence... "words are very unnecessary - they can only do harm..."


run-server should know if you've run install-apps

Please can you skip moving the WAR file into the apps folder if you have ran 'install-apps' so it uses the XML rather than the WAR

Hi, can you elaborate on this issue? I don't believe run-server should affect anything with how the war or loose app is installed.

OK so I run install-apps which creates the .war.xml file, and then run-server - there is now the WAR file in the apps/ folder which there wasn't before running the server.
as I'm on a Unix-based system, I can delete the WAR just after it's created, so the Liberty runtime falls back to using the .xml file (with hot reloading) but it'a a nuisance doing this every server start

@JamesBlandford Is this still an issue for you? We completely changed how run-server works in the 3.x release (and it's called run now). We also combined install-apps with deploy and only support the deploy goal now.

Since there has been no activity on this issue in the last 4 years, I am closing it.


add to-do-list role to functions for db access

need to add AWS role to-do-list to CRUD functions in order to access DynamoDB.

ok


fix(tickets): Making max tickets configurable by env var

:tada: This PR is included in version 4.2.5 :tada:
Your semantic-release bot :package::rocket:


Fix SingularMatrix exception

Looks like omitting kind="scatter",diag_kind="histogram" from pairplot signature causes SingularMatrix exception

Thank you so much, seems this broke due to a new version of seaborn. Seems to be broken in other notebooks as well, will fix

NP:) Thank you for the great course


how am i doing?

have i answered all your questions, still feeling a bit nervous of finding my way round the system
let me know if i ahve passed the test ?

You've passed with flying colours @elysabethc5 ! Thanks so much for being responsive.

thats great to hear. i am enjoying it. so thanks to you as well.


Issue #3811 fixed

Issue: #3811

@vaishaliwebkul
url issue fixed

@vishal-webkul
footer middle content is a localized field so implement this for all locale.
Also getting a blank page when adding CMS page to other locales https://prnt.sc/u5elm9

functionality is working fine.


Fix outside window dragging

Fixes #11081.
Before #11024, which introduced the #11081 regression, we checked for
this.viewport_.getRootNode().contains(target)

In #11024, this was changed to
this.viewport_.contains(target)

This is obviously not the same, and the reason for the problem. Now that we have a rootNode calculated already, the fix is easy.

I added another commit which resolves the same issue for maps in web components (not a regression, never worked). Because that if block is quite involved, I placed more comments so it is easier to understand.


Why aren't nLog custom event properties rendering through an email target?

When I write nLog events to a file or to the database target, the LongMessage field renders correctly. But when I write to email, I get an empty string where my long message should be. Any ideas why outputting properties would work in a database target but not work in an email target?

<target name="mail"
xsi:type="Mail"
smtpServer="smtp.abc.com"
smtpPort="25"
html="true"
addNewLines="true"
encoding="UTF-8"
priority="High"
replaceNewlineWithBrTagInHtml="true"
smtpUserName="user.name"
smtpPassword="password"
subject="Your report request number ${event-properties:ReportRequestId}"
<EMAIL_ADDRESS>to="{all-event-properties:format=[key]=[ToEmail]:separator=,:includeCallerInformation=true"

How to send Custom value as TO email id to the target ?

The value assigned to="{all-event-properties:format=[key]\=[ToEmail]:separator=,:includeCallerInformation=true" is not a valid NLog Layout, so it will just be used as literal-text.
Can you provide an example of how you are calling the NLog Logger, and gives the custom value for use in the to="..." ?
See also: https://github.com/NLog/NLog/wiki/Context
See also: https://github.com/NLog/NLog/wiki/Layouts

Closing issue as answered, due to inactivity.


Not bypassing ouo.io

Domain
https://ouo.io
Link
https://ouo.io/W0WO4w
Version
0.0.0
What browsers are you seeing the problem on?
Chrome
What OS are you seeing the problem on?
Windows
Anything else?
Version 0.2182.0

You were probably the first to encounter that link, so that's why you had to wait. ouo.io utilizes a crowd bypasses due to the timer, so we cannot bypass it automatically. I was able to instantly get to the mega.nz link (video below).
https://user-images.githubusercontent.com/45770865/210405135-d96bab91-2af6-4653-9d1e-86dd932728c1.mp4


Teams Bot 1-1 ConversationUpdate Events

I'm struggling with the same situation in a few different Teams bots I've written, and trying to determine if I've just misunderstood the docs. When the bot is side-loaded to a test tenant, and then added to a 1-1 conversation, I'm getting two conversationUpdate/MemberAdded events. However, BOTH events contain BOTH user (i.e. end user and bot). I would have expected either one event, with both Members, or two events, one with each user, but not the SAME event 100% duplicated. Is this what is meant above by "It also receives an update when it has been added for the first time specifically for personal conversations."? If so, how do I deal with this scenario, as there's no way to differentiate the two duplicated events. I've posted more on SO, but with no responses: https://stackoverflow.com/questions/60140079/microsoft-teams-side-loaded-app-multiple-conversationupdate-events-firing

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9da6a6eb-8756-fffd-ecc3-07cde897e709
Version Independent ID: 72686dc8-d677-9b8d-2405-7684d537a100
Content: Handle bot events - Teams
Content Source: msteams-platform/resources/bot-v3/bots-notifications.md
Product: msteams
GitHub Login: @laujan
Microsoft Alias: anclear

Duplicate of #1355


[Entitas:] Add mechanism to filter entities based on component values in a reactive system

This issue attempts to provide a solution for #165
History:
PR #189 added filter condition to matchers
After implementing a solution I removed it in a future version, see #190

[...] It's very convenient, but it has an overall negative effect on performance [...]

Suggestion:
Add a new interface, e.g. IFilterEntities which can be implemented by reactive systems

Hi, I added IFilterEntities
Initially, this should enable us to filter entites based on component values, e.g.
public class KillSystem : IReactiveSystem, IFilterEntities {

    public TriggerOnEvent trigger { get { return CoreMatcher.Health.OnEntityAdded(); } }

    public bool filter(Entity entity) {
        return entity.health.value <= 0;
    }

    public void Execute(List<Entity> entities) {
        foreach(var e in entities) {
            // no need to check for health here anymore, yay
            e.flagDestroy = true;
        }
    }
}

Basically, IFilterEntities can now potentially replace the other existing interfaces IEnsureComponents and IExcludeComponents, since we can now express that in one simple filter(entity) method. This will also simplify the internal implementation of ReactiveSystem since we only have to check on single method now.
I'm thinking of deprecating IEnsureComponents and IExcludeComponents in favour of IFilterEntities.
What do you guys think?

If this O(n) filter implementation scales equally well as IEnsureComponents did, sure!
In a recent gamejam project, I actually had to create an "Impassible" negative entity because IEnsureComponents couldn't reliably filter based on some external rules (a boolean array containing a collision map).


added wc-autoloader gulp task https://github.com/elmsln/issues/issues…

relates to https://github.com/elmsln/issues/issues/159
Added a gulp task to search for customElement.define statements in build directory.
Gathers a list of statements and outputs a file called wc-autoloader.json with the following information
[
    {
        "monaco-element"<EMAIL_ADDRESS>    },
    {
        "extensible-toolbar"<EMAIL_ADDRESS>    },
    {
        "figure-label"<EMAIL_ADDRESS>    },
    {
        "full-width-image"<EMAIL_ADDRESS>    },
    {
        "h-a-x"<EMAIL_ADDRESS>    },
    {
        "h5p-element"<EMAIL_ADDRESS>    },
    {
        "undoer-element"<EMAIL_ADDRESS>    },
    {
        "hax-upload-field"<EMAIL_ADDRESS>    },
    {
        "haxcms-basic-theme"<EMAIL_ADDRESS>    },
    {
        "haxcms-minimalist-theme"<EMAIL_ADDRESS>    },
    {
        "haxcms-user-theme"<EMAIL_ADDRESS>    },
    {
        "basic-template"<EMAIL_ADDRESS>    },
    {
        "minimalist-template"<EMAIL_ADDRESS>    },
    {
        "lrn-math-controller"<EMAIL_ADDRESS>    },
    {
        "lrn-shared-styles-demo"<EMAIL_ADDRESS>    },
    {
        "lrndesign-gallery"<EMAIL_ADDRESS>    },
    {
        "lrndesign-sidenote"<EMAIL_ADDRESS>    },
    {
        "sortable-list"<EMAIL_ADDRESS>    },
    {
        "outline-designer"<EMAIL_ADDRESS>    },
    {
        "page-scroll-position"<EMAIL_ADDRESS>    },
    {
        "they-live"<EMAIL_ADDRESS>    },
    {
        "undo-manager"<EMAIL_ADDRESS>    },
    {
        "custom-style"<EMAIL_ADDRESS>    },
    {
        "dom-bind"<EMAIL_ADDRESS>    },
    {
        "dom-module"<EMAIL_ADDRESS>    },
    {
        "vaadin-lumo-styles"<EMAIL_ADDRESS>    },
    {
        "vaadin-material-styles"<EMAIL_ADDRESS>    },
    {
        "datepicker-slide-from-left-animation": "build/es6/app-datepicker/animations/datepicker-slide-from-left-animation.js"
    },
    {
        "datepicker-slide-from-right-animation": "build/es6/app-datepicker/animations/datepicker-slide-from-right-animation.js"
    },
    {
        "app-datepicker": "build/es6/app-datepicker/app-datepicker.js"
    },
    {
        "local-time": "build/es6/time-elements/dist/time-elements.js"
    }
]

Awesome thank you! Now I just gotta get the .tag piece working

Yeah I'm not sure how that works.  Some way of load the javascript of each file and executing to find the value of an object.


update definitions for emission value / emission factor value

Description of the issue
Update definitions for emission value / emission factor value.
Ideas of solution
Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[ ] I already read the latest version of the workflow for this repository
[ ] The goal of this ontology is clear to me

I am aware that

[ ] every entry in the ontology should have an annotation
[ ] classes should arise from concepts rather than from words
[ ] class or property names should follow the UpperCamelCase

Should this include a definition for emission factor or emission factor value?
Suggestions for emission factor:
The emission factor is the ratio between the amount of pollution generated and the amount of a given raw material processed. The term may also refer to the ratio between the emissions generated and the outputs of production processes. https://stats.oecd.org/glossary/detail.asp?ID=761

emission value can't be found and emission factor got deleted in #368 (as it's a quantity) so this can get moved to the second release

I think  we have to distinguish between different types of emission values.

An emission value that is directly connected to the emission process. This is e.g. the combustion of fuels where the carbon content of the fuels is oxidized. A practical example is a CO2 emission value of 96 t/TJ for hard coal.
An emission value that is only indirectly connected to the emission process as it is calculated from the emissions and some activity data that is not directly related to the combustion. A practical example is a CO2 emission value of 900 g/kWh for a coal power plant with the produced electrical energy as activity data.
An emission value that covers that e.g. greenhouse gases are directly emitted without a chemical conversion process. This can be e.g. methane leakage from a gas grid or emission of F-gases from air conditioning.

So the first and second emission value are related to combustion and other chemical conversion processes while the second one the leaking itself is the emission process. Maybe we need different types (subclasses?) of our emission process? Like emission from a conversion process and emission from leakage?
In UNFCCC terminology the first and third emission value is called emission factor while the second one is called implied emission factor.

The IPCC defines emission factor as:

A coefficient that quantifies the emissions or removals of a gas per unit activity. Emission factors are often based on a sample of measurement data, averaged to develop a representative rate of emission for a given activity level under a given set of operating conditions.

(Glossary of the 2019 Refinement to the 2006 IPCC Guidelines for National Greenhouse Gas Inventories)

When it comes to modelling I can only use one general type of emission factor. So I would be fine with only one label emission factor and the definition from IPCC.
I think emission factor is also an example of what we call "attribute", so we would need to relate it to a process class.
A suggestion for this relation is:  `energy transformation' has_process_attribute 'emission coefficient'
Or if the issue with the subclasses of energy transformation (#372) is solved than the relation could be for example:
'coal power unit' participates in 'energy transformation' has_process_attribute 'emission factor'
for all fossil power plants.

An emission factor an also applied to combustion fuels, e.g. natural gas has an emission factor of about 56 t CO2/TJ.

Yes true, but I think it should be related to the combustion fuel and the combustion process. As the definition says its "quantifies the emissions per unit activity." An activity is always a process in my understanding.
So we would need to relate combustion fuel to the combustion process and the emission factor. Additionally we could relate combustion fuel or specific power units to energy transformation and emission factor.

Yes true, but I think it should be related to the combustion fuel and the combustion process. As the definition says its "quantifies the emissions per unit activity." An activity is always a process in my understanding.

Yes, exactly. An emission factor is always connected to a process.

So we would need to relate combustion fuel to the combustion process and the emission factor. Additionally we could relate combustion fuel or specific power units to energy transformation and emission factor.

The emission process does not necessarily be a combustion process. If you think e.g. about the methane leakage emissions from a gas well the relevant process is the production of gas and not the combustion. And if you think of some industrial process emissions like F-gas emissions they are not connected to any fuel at all.

My suggestion would be to keep the definition of emission factor generic, for example use the one from IPCC and then relate it to the classes which are already included in the OEO. So an additional relation could be to made to primary energy mining.
We don't have a class industrial process ... Maybe we could put an editor note, that emission factors can also be applied to industrial processes?

Adapting the IPCC definition I propose the following definition: An emission factor is a quantity value that quantifies the emissions or removals of a gas per unit activity. The superclass would then be quantity value.

No one objected against my proposal from 27 August so I think it is ready for implementation. I'll do that.


Cast PyArrow schema to large_* types

Fixes #791
For consistency, we should always cast to large types when inferring pyarrow schema from Iceberg Schema, and when scanning using the physical_schema of the fragment

@HonahX could I ask for you to merge this in? It'll help unblock me in https://github.com/apache/iceberg-python/pull/786/files


Refactor io crate

Done on top of #2234
Do various refactorings to the io crate. These are all trivial to review except the bigish commit: d3d3e50f Move error code to submodule which is code move only.
Can go in with one ack (only after 2234 obviously).

Oh, I might be out of line here. Code in consensus::encode uses the same whitespace style as the original io code.

Needs rebase.


cant access Session in other API

I use netcore, i have two API, one API Set Session value HttpContext.Session.SetString("GoogleProvider", info.ProviderKey);
And one API get this session but result is null. HttpContext.Session.GetString("GoogleProvider");

That's a bit vague. Are these two different Actions, Controllers, or completely separate applications?

Yes, i have two controller : AccountController(api/account/registry) is set Session and AuthorizationController(connect/token) is get Session,

My code :
AccountController
[HttpGet("ExternalLoginCallback")]
[AllowAnonymous]
public async Task ExternalLoginCallback(string returnUrl = null, string remoteError = null)
{  ....
HttpContext.Session.SetString("MySession", info.ProviderKey);
...
}
AuthorizationController :
[HttpPost("~/connect/token"), Produces("application/json")]
[AllowAnonymous]
public async Task Exchange(OpenIdConnectRequest request)
{
var dataSession = HttpContext.Session.GetString("MySession");
//dataSession is null
}

My Setting in Status.cs :
services.AddDistributedMemoryCache();
public void ConfigureServices(IServiceCollection services)
{
services.AddMemoryCache();
services.AddSession();
}
public void Configure(IApplicationBuilder app)
{
app.UseSession();
app.UseMvc(routes =>
{
routes.MapSpaFallbackRoute( name: "spa-fallback",  defaults: new { controller = "Home", action = "Index" });
});
}

Many thank you. I need n't use session in API because it will make my application vulnerable to this class of attack. I will try other way.


chore: Reconfigure metrics that are duplicated

Fixes #N/A
Description
Reconfigured Karpenter metrics that are duplicated (workqueue metrics, renames of existing metrics).
How was this change tested?
Does this change impact docs?

[ ] Yes, PR includes docs updates
[ ] Yes, issue opened: #
[x] No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 79.069%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
5927

Relevant Lines:
7496

💛  - Coveralls

Will this PR include the change from upstream? Also we should include the changes to the docs in this PR


Adding new site (non-booru)

What steps will reproduce the problem?
Using other bulk image downloaders for downloading Hentai Foundry galleries is hard because it doesn't always download the total number of pictures.
What is the expected behavior? What do you get instead?
Would it be possible to add Hentai Foundry to the list of sites?
How often does this problem occur? On which sources?
What version of the program are you using? On what operating system?
Please provide any additional information below
Sorry if this may not be an issue but I didn't know where to post. Would be nice if someone were to help me

That's technically possible.
However, if it's a gallery-type website, it'll have to wait for #917 first, as gallery sources are not supported at the moment.


Design Security Keys UI/UX

To discuss specs on Wednesday with team.

Do we still need those with the new secutiry keys flow?

closing in favor of #308


add react-primitives target

@mxstbr Here it is :)
Couple of things:

I add some abstraction in InlineStyle.js and StyledNativeComponent.js to pass the Stylesheet instead of requiring it from react-native. Probably need to change the name StyledNativeComponent but I was short on idea.
The tests are failing on my machine for RN with Cannot find module 'ReactElementType' from 'ReactRef.js'. I'm opening this to get the result from the CI 🤞

Sorry, I don't know of any prior discussions and haven't read the code yet ^^
Why do we need this when with react-native-web the user can theoretically just alias react-native to react-native-web in babel or webpack?

For use with the other platforms that react-primitives support (currently only Sketch using react-sketchapp) but as react-as-a-platform grows, I'm expecting more to appear and hopefully we will converge toward a "standard" set of primitives on each platform.

Awesome! So I think the last outstanding issue is this one here:

Instead of doing this, the InlineStyle model should become a factory function that accepts an RN/RP StyleSheet.
have look on how some other models do it :) This is the closest example obviously: https://github.com/mathieudutour/styled-components/blob/c65a1cb54d81eddbac48fa845627e48fb007d3ef/src/models/ComponentStyle.js#L11
So instead of passing your StyleSheet in, we can pass the generated InlineStyle in

Hum I did change it. Isn't it you meant? https://github.com/mathieudutour/styled-components/blob/d21ef5ef28a07bf6700002f35e723524d62f8f0d/src/models/InlineStyle.js#L26

I'm so excited, I've been wanting to make this happen for a while now! Can't wait to use this :blush:

@mathieudutour It's not quite what I meant :smile: so basically in ComponentStyle we're doing this:
export default (nameGenerator: NameGenerator, flatten: Flattener, stringifyRules: Stringifier) => {

So the signature of that export is (...args) => ComponentStyle.
For InlineStyle we can do the same:
export default (StyleSheet: StyleSheet) => {
  class InlineStyle {
    // ...
  }

  return InlineStyle
}

It's the pattern that we've adopted throughout the repo :wink:

I think I get it. Is that right?

@mathieudutour That's perfect! :heart:
@mxstbr Since you're around, do you have time to review this as well :smile:

Great work @mathieudutour - excited to play with it.
@philpl echoing Mathieu's answer - react-primitives actually exposes react-native-web as the renderer for web — aliasing is the simple solution but I'm super super excited about the promise of react-primitives as a universal abstraction for every platform. Also I really want react-sketchapp & styled-components to be BFFs.

Also I really want react-sketchapp & styled-components to be BFFs.

:+1:
If @geelen veto's this to be in core for whatever reason I'll personally copy and paste this to make styled-components-primitives with the hackiest imports ever 😜

This is so dope

Sorry friends, was on the road all last week and basically not checking the issue tracker at all. I'm super keen for SC to support react sketchapp (that screenshot got me :shaq_wiggle_gif:) but I'm not clear on how this diff makes that possible, or what the downsides would be.
I just watched Leland's talk and I think I understand the concept, but it looks like you're deleting the styled-components/native endpoint in this PR? I certainly don't have a problem with introducing a styled-components/primitives endpoint (or even a new package down the line) to get this out there and see how it feels, but I wouldn't want it to be the only interface to Native yet. I'm also not sure about how the platform-specific extensions would work across a library boundary like this...
Personally, I'm big on the ideas of unifying UI development workflow but I'm also firmly in the camp that the web has very specific problems and I'm not willing to compromise on the API for more generality. It's why things like nesting are in SC, despite being specific to real web CSS.
That said, I'm extremely interested to see where this leads so assuming that there are no breaking changes I think we should push this out under a styled-components/primitives entry point and get some real-world feedback.

There is no breaking change, I removed the native.js file because there is already a folder called “native” with an index.js inside. I did it following the feedback of @philpl, shall I roll back?

I removed the native.js file because there is already a folder called “native” with an index.js inside

I'm unsure if that'll do what we want it to, let's revert that change for now to make 100% sure nothing breaks and ship this?

done

Sorry this was my mistake. You can indeed remove those extra entry points.

No worries. Done

:tada:

Going to write a blogpost about this release, this is a big deal!

This is dope


When using in table view there are issues

No animation no swipe to dismiss when presenting from table view ...

Hi! Can you provide me


Sparta @693 colonists, worse performance than without rimthreaded, but stable.

Player.log
modlist.txt

Directly after posting this it crashed :)

Closing bug. Many bugs have been fixed since this was reported. Please reopen in new bug report using the new templates if this issue persists.


The map data contains trees that aren't included in the tree lists

This seems particularly true of trees in Oakland, e.g., Crepemyrtle (scientific Lagerstroemia indica).  If they're not on the tree lists, there's no way to add another one of that type.  Also, in the Edit dialog, there's no drop-down in the name fields, as they don't match any tree types we know about.
Should we generate a list of tree types from the database and build the list from that?

Yes, anything can be typed manually, even if there are no autocomplete suggestions.  But if there are known tree types in an area, seems like it would be nice to make it easy for someone to plant another.


tripleee: Blacklist alpha\Wmax

tripleee requests the blacklist of the following keyword(s):

alpha\Wmax - MS search

alpha\Wmax has been seen in 0 true positives, 0 false positives, and 0 NAAs.


WinError 2

Describe the bug

To reproduce

Could someone tell me where anime-dl installs to when using choco on windows and specifically how I can add mpv to path to fix this?

choco doesnt install anime dl
choco installs python
and using python's pip we install anime dl
so uhh, you can run
import anime_downloader
print(anime_downloader.__file__)

to get the folder where the code is stored at
as for how to add smth to the PATH, look at https://helpdeskgeek.com/windows-10/add-windows-path-environment-variable/

thanks


Update sys-dm-db-log-info-transact-sql.md

@savjani
Can you review the proposed changes?
When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


feat: support only build one plugin to testing specified WasmPlugin

Ⅰ. Describe what this PR did
Support only build one plugin to testing specified WasmPlugin
Ⅱ. Does this pull request fix one issue?

No
Ⅲ. Why don't you add test cases (unit test/integration test)?
no need
Ⅳ. Describe how to verify it
make ingress-wasmplugin-test
PLUGIN_NAME=request-block make ingress-wasmplugin-test
Ⅴ. Special notes for reviews
No

Codecov Report

Merging #371 (666f690) into main (f9ffda2) will decrease coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
- Coverage   41.96%   41.90%   -0.06%
==========================================
  Files          44       44
  Lines        5877     5877
==========================================
- Hits         2466     2463       -3
- Misses       3239     3241       +2
- Partials      172      173       +1

see 1 file with indirect coverage changes

@Xunzhuo @johnlanni please help me to review this PR.

Can we test against multiple wasm plugins ? @Hinsteny

Can we test against multiple wasm plugins ? @Hinsteny
yes, we can. if no parameter of plugin name is specified, all plugins in the wasm-go extensions directory are compiled for testing by default.


Update with Incorrect Title

Update with Incorrect Title for Apps30 and Apps40

Thanks @cheahengsoon I missed those one


[BUG] Elasticdump Performance Problems - Could use some tips on how to benchmark

Context
In order to help us troubleshoot issues with this project, you must provide the following details:

ElasticDump version - 6.94.1
Elasticsearch version - 7.17
Node.js version (note that nodejs v10+ is required for this tool) - v16.19.0
Full command you are having issue with (with inputs and outputs)

/path/to/location/.nvm/versions/node/v16.19.0/bin/elasticdump \
    --input=${inputserver}/<my_index_name> \
    --httpAuthFile=/path/to/location/elasticsearch-opensearch-utils/opensearch_migration_scripts/dumpfile \
    --output=${outputserver}/<my_index_name> \
    --limit 2500 \

Describe the bug
I am getting slower than expected performance with Elasticdump. I am sorry if I picked the wrong label, I'm not fully sure its a bug on Elasticdump entirely - but I've been running Elasticdump over many indices now, and I get varying results, and I can't seem to solve it. (Thanks by the way - this tool is a lifesaver trying to migrate to AWS Opensearch).
I will try to give as much detail as possible, I have been testing my own speeds, with changing the limit in the dump and I can't seem to get consistent speeds. I'm looking to see if this is a problem with running Elasticdump over and over, or how to properly optimize and benchmark.
Benchmarking
I have already tried to look through previous issues for help and many of them suggest making sure I properly benchmark first to ensure I can properly tune Elasticdump - which makes sense to me. However, I was unsure of what specifically to benchmark (I tried to google and of course found many results) - but if there would be something I can do to benchmark specific performance tests that matter most for Elasticdump's operations, that would be great. Any guidelines or tips of what to check/what to test for!
Limit
I have tried to play around with limit (default is 100). I tried to bump it up to 1000, and slowly did my own performance tuning (basic) to measure speeds. I tried:

1000
2500
5000
10K
25K

I would try to measure the speeds of each operation:
i.e. Got 2500 objects from source to Elasticsearch - and see how long that takes.
For example, that would take 2 seconds per.
And then compare it to a different limit.
i.e. Got 5000 objects from source to Elasticsearch
In that case it took 4 seconds per - but effectively the 2500 limit, did the same. (2500 at 2 seconds, hits 5000k by 4 seconds - so same speed at 2500 limit and 5000 limit) - So they were equal. (in this test)
I did notice at some larger ones (10k, 25k limit) it would be slower sometimes compared to the speed of each 5K limit, but other tiems faster.
So that is where some of my questions are - is the limit speed solely dependent on the cluster (performance of cluster? how much computer it has)?  or is dependent at index level?
For example - would fields/field limit of an index matter? I did some rough testing and it's too small of a sample size - but would something like this matter? (reference on field count: https://stackoverflow.com/questions/40586020/get-the-number-of-fields-on-an-index/40655667#40655667)
It could be coincidence but on multiple indices that were similar size doc.counts, I tried to check the field size on them. The indices that had a small field size (like 40) seemed to be faster, and the indices with a large field size (100, even 800) were slower. Would more fields cause the slowness? All things equivalent otherwise? i.e. 2 indices, both 1 million records, both using 5k limit, but completely polar opposite number of fields in the 2 indices. Is this even something I have to worry about (maybe I'm overthinking?)
Should I be changing limit based on field size?
Additional context
If there is any other information I can provide, or tests needed to run, please let me know. I hope this isn't the wrong spot, or a wrong use of the issues, I was just spinning my wheels after reading all the documentation and as much issues I could search for relevant to this.
So far the tool has been great on 99% of my indices, cause they are small, however there are 2-3 that are 20-50 million records, and one ran in 4 hours (testing various limits) and now the next 20 million one has taken over 8 - so that's where this started - I'm trying to figure out why I am seeing such different times (double the hours) for seemingly similar sized indices (but again there must be more to it than just doc.count in an index).
I have a 300 million index coming up, and that is my main concern based on my overnight times of running just on 20 million.

There is a lot of things you can do to improve throughput, but saying that is directly related to the library is a bit hasty.

Try modifying the fields returned (maybe you don't need all the fields)
Try increasing the resources to NODE (NODE_OPTIONS="--max_old_space_size=700000").
Try tuning elasticsearch.

All in all there is so much that can be done. It's really for a library to do all these things and provide flexibility and frankly it's beyond the capabilities of the library.
A document size is different. You know your data, the library makes no assumptions. Tune the settings until you get something desired. Beyond that there isn't much I can say, and this is true for any library that dumps data.


New Category: Lists and New Rule: List markup must be explicit

New Category: Lists
New Rule:  List markup must be explicit
Requirement or recommendation:  Recommended
There is no standard for the list markup available in Section 508 so this is highly recommended to ensure that the list markup is explicit to users of screen readers.
Purpose/description:
Lists that appear to be implicit without the proper list markup. Common practices involve tables that list items, visually indented list (without list markup) or bullet or image that marks each list item visually as a list.
A proper list structure helps users of assistive technologies like screen readers understand the hierarchical structure and position of list items. This structure helps them determine the number of list items in the list and the list hierarchy of nested lists as well.
Standards:
WCAG 1.0 Priority 2
3.6 Mark up lists and list items properly
WCAG 2.0 Level A
1.3.1 Information and Relationships

List rule 1 and 2 address the use of list markup


Domain activation is Failed

App Id: d1zzhxo7z7xvoc
Region: us-west-2
Step: Domain activation
Status: Failed

Note: Do not include information that is sensitive in nature such as your domain name, company etc.

Issue/question
A clear and concise description of what the issue/question is.
I'm trying to activate a domain (swimfire.com) from a recently transferred domain that was at GoDaddy and is now at Route53.  I only have the www subdomain.  It fails at Domain Activation after SSL has been configured.
Error message
Error message: One or more of the CNAMEs you provided are already associated with a different resource.
Additional information
Please add any other relevant information. Please feel free to include screenshots.

Refer to our documentation to troubleshoot domain setup.
https://docs.aws.amazon.com/amplify/latest/userguide/custom-domain-troubleshoot-guide.html
https://docs.aws.amazon.com/amplify/latest/userguide/custom-domain-troubleshoot-guide.html#i-get-a-cnamealreadyexistsexception-error
Let us know if you're still facing issues.

Refer to our documentation to troubleshoot domain setup.
https://docs.aws.amazon.com/amplify/latest/userguide/custom-domain-troubleshoot-guide.html
https://docs.aws.amazon.com/amplify/latest/userguide/custom-domain-troubleshoot-guide.html#i-get-a-cnamealreadyexistsexception-error
Let us know if you're still facing issues.

It looks like swimfire.com is already use for another AWS resource.  You will need to remove it from the other resource to add to an Amplify app. We are going to close this issue.  Please let us know if you need further assistance.

It looks like swimfire.com is already use for another AWS resource.  You will need to remove it from the other resource to add to an Amplify app. We are going to close this issue.  Please let us know if you need further assistance.


Need FIO Transaction History Solution for Wallets and Exchanges

Tracks the discussion regarding the different approaches to providing FIO token transfer and other transaction history for wallets and exchanges.
Exchanges do need a history node.  What types of nodes do they need?  History / Elastic Search / Dfuse / cc's Chronicle.  They probably want to own their own, and it needs to be simple.

Discussed with BPs. The decision was to keep supporting V1 history, but also make sure other solutions, such as Hyperion, are supported. We will minimize adding any new functionality to V1 history to reduce future maintenance.
Closing.

Discussed with BPs. The decision was to keep supporting V1 history, but also make sure other solutions, such as Hyperion, are supported. We will minimize adding any new functionality to V1 history to reduce future maintenance.
Closing.


Update error examples and add reference for x-correlator

What type of PR is this?
Add one of the following kinds:

bug
correction

What this PR does / why we need it:

update error examples in YAML (see commit https://github.com/camaraproject/NumberVerification/commit/83fd1a22e4bba08c068b3fa2b654ba0d4138d37e)
add a reference for x-correclator (see commit https://github.com/camaraproject/NumberVerification/commit/65b1db0d15582f041a2eea68006bbe46ec71fd3f, with small fix https://github.com/camaraproject/NumberVerification/commit/73ee72f9468ef66a5343c65d1c8179c4b3e804b2)

Which issue(s) this PR fixes:

Fixes #127

@AxelNennker can you please approve this PR? I need the approval of another codeowner.
It is just to fix a PR that Ludovic created but since he is on holiday we couldn't update it so we have create it again.
Thanks!

Hi @hdamker, I think that we can merge this PR if you are okey with it. It's okey for me if  you prefer to wait for @AxelNennker review.

@fernandopradocabrillo Yes, same changes as @bigludo7 had done and they LGTM. Will merge on behalf.


Public Event Request on Codeunit 1290 - SOAP Web Service Request Mgt. - Procedure CreateSoapRequest

We need a new Event on Codeunit 1290 - SOAP Web Service Request Mgt. - Procedure CreateSoapRequest:
local procedure CreateSoapRequest(RequestOutStream: OutStream; BodyContentInStream: InStream; Username: Text; Password: Text)
var
XmlDoc: DotNet XmlDocument;
BodyXmlNode: DotNet XmlNode;
//INIT INSERT
IsHandled: Boolean;
//END INSERT
begin
//INIT INSERT
OnBeforeCreateSoapRequest(RequestOutStream, BodyContentInStream, XMLDoc, UserName, Password, TraceLogEnabled, IsHandled);
If IsHandled then
exit;
//END INSERT
CreateEnvelope(XmlDoc, BodyXmlNode, Username, Password);
AddBodyToEnvelope(BodyXmlNode, BodyContentInStream);
XmlDoc.Save(RequestOutStream);
TraceLogXmlDocToTempFile(XmlDoc, 'FullRequest');
end;
The new event would be:
//INIT INSERT
[IntegrationEvent(false, false)]
local procedure OnBeforeCreateSoapRequest(  var RequestOutStream: OutStream; var BodyContentInStream: InStream; var XmlDoc: DotNet XmlDocument; var Username: Text; var Password: Text; var TraceLogEnabled: Boolean; var IsHandled: Boolean)
begin
end;
//END INSERT

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.


Ch. 4: Exercise 12

Hello Aurelien,
I did ex.12 on my own and had problem with troubleshooting.
In my case early stop works 1 out of 10 times and stopped after less than 20 iterations (IMO it depends on random initialization). That behavior doesn't seems correct to me. After 2 days of troubleshooting I rebuilt the code so that it can be compared line-by-line against yours. And turns out that early stop to works following conditions must be met:

implementation MUST have regularization. (partial derivatives have no regularization part in the book)
pair (learning rate and regularization hyperparameter) must be big enough (0.1, 0.1). If it would be (0.01, 0.1) , (0.1, 0.01) and so on even 5M iterations didn't hit the early stop.

May be worth to point out those caveats in exercise statement.

Good catch, thanks a lot @IvanKuchin , I'll add a note.