feat: overhauling how we process parameters to support required defaults

🚥
Fix RM-3369

🧰 Changes
This completely overhauls how we process and ingest request body payloads and parameter metadata so that we now augment any supplied data with any required request body payload property or parameter that has a documented default.
For example in the USPTO example spec it has a  POST /{dataset}/{version}/records operation with a dataset and version path parameter and an object payload. When you run this currently without sending any body or metadata we'll make an API call to /{dataset}/{version}/records with an empty payload.
With these fixes, since dataset and version are required parameters, and have documented defaults, and because in its object payload there is a criteria property with a default of *:* now when you make an API call with sdk.post('/{dataset}/{version}/records) we'll hit /oa_citations/v1/records with a payload of { criteria: '*:*'} all without the user having to do anything.
It is very neat and works pretty well!
This functionality also mostly functions identicaly to how we handle form defaults in the reference guide, I'm just using a different library for traversing our JSON Schema and composing defaults.
🧬 QA & Testing
See the new tests I wrote or you can run this code to see it in action:
const spec = require('@readme/oas-examples/3.0/json/uspto.json');
spec.servers[0].url = '{scheme}://httpbin.org/anything';

const sdk = require('.')(spec);

sdk.post('/{dataset}/{version}/records').then(res => {
  console.log(res);
});

/*
{
  args: {},
  data: '',
  files: {},
  form: { criteria: '*:*' },
  headers: {
    Accept: 'application/json',
    'Accept-Encoding': 'gzip,deflate',
    'Content-Length': '14',
    'Content-Type': 'application/x-www-form-urlencoded',
    Host: 'httpbin.org',
    'User-Agent': 'api (node)/4.2.0',
    'X-Amzn-Trace-Id': '<<REDACTED>>'
  },
  json: null,
  method: 'POST',
  origin: '<<REDACTED>>',
  url: 'https://httpbin.org/anything/oa_citations/v1/records'
}
*/

@readmeio/api-tooling I'm merging this in because I'm already in merge hell with the changes here and #399 so if you manage to take a look at this this week please still leave feedback and I'll address them in different PRs.


Expose port 9173 in Dockerfile

The exporter listens on 9010, but the image exposes 9110. I think this was a typo introduced recently.

Good spot,
Looking at this in more detail, Prometheus folk ask that the exporter runs on a port above 9100.
It looks like 9110 is in-fact in-use already (https://github.com/prometheus/prometheus/wiki/Default-port-allocations).
Looking at the list, 9173 seems to be free. I don't mind accepting an updated pull-request for Dockerfile + app if you fancy? That or i'll create one.
I'll reserve 9173 in their docs now.

PR updated to port 9173

Awesome, thanks @joshbenner!


No longer found in the VS Code extension list

Hi,
as mentioned in the title, as far as I can see this extension is no longer available.
Is there any way to use it only based on the github repo?
Thanks in advance :)

it's here:
https://marketplace.visualstudio.com/items?itemName=mintlify.document
does this link not work for you?

this product has been sunsetted

Hi, thanks for letting me know. Cheers!


marathon doesn't start correctly post-reboot on single control-node installs

After running `playbooks/reboot-hosts.yml', marathon may not start correctly. Frequently, it ends up stuck in a loop where it is repeatedly trying to connect to zookeeper:
Jun 26 20:48:21 default marathon[765]: [2015-06-26 20:48:20,859] INFO Connecting to Zookeeper... (mesosphere.marathon.Main$:37)
Jun 26 20:48:21 default marathon[765]: [2015-06-26 20:48:20,859] INFO Initiating client connection, connectString=zookeeper.service.consul:2181 sessionTimeout=10000 watcher=com.twitter.common.zookeeper.ZooKeeperClient$3@cd73642 (org.apache.zookeeper.ZooKeeper:379)
Jun 26 20:48:21 default marathon[765]: [2015-06-26 20:48:20,877] WARN Unable to connect to Zookeeper, retrying... (mesosphere.marathon.Main$:43)

But, zookeeper is up and running at the time:
echo ruok | nc zookeeper.service.consul 2181
imok

Simply restarting marathon gets things going again. This seems to only affect installs with a single control node (a default vagrant build, for example).

Is this a bug we should open with Marathon?

When consul is in maintenance mode, zookeeper.service.consul cannot be resolved. Marathon starts before the reboot-hosts playbook disables maintenance mode post-reboot. And it appears Marathon cannot recover from this once it has started - even when the host can subsequently resolve  zookeeper.service.consul. So, yeah, I think it would be nice to have it fixed in marathon - I'll open an issue. Should we put in a workaround for now? Trigger a marathon restart after disabling consul maintenance mode in the reboot-hostsplaybook? Or change the marathon service definition to use a wrapper script that ensures it can reach zookeeper before starting marathon? Something else?

Workaround sounds good. It takes a while for Marathon to fix issues, and version 0.9 will refactor the storage backend, so we don't know how it will affect ZK connectivity.


[match] Improved SEO in docs

So when people search for decrypt they find this, via https://twitter.com/ylatuya/status/773781316018008064

👍


lightouse audit workflow via gh actions

introduce a lighthouse audit workflow for each deploy preview, as per this documentation

oops, seems theres a race condition with the gh-actions to build the demo site somehow? definately something to come back to!


Introduces session key for session creation

Describe Your Changes

Adds session key to database to allow facilitators easier search
Also forces session to include students with same session key (ensures randomization)
Session "login" requires session key

Non-Obvious Technical Information
Checklist Before Requesting a Review

[X] The code runs successfully.

closes #159


Ignore false-positive E1101 pylint errors

Summary Change Description
Some dynamically generated properties can cause E1101 errors, adding
these to generated_members in pylint config gets rid of those errors.
Also bumped pylint version to match current one used by superlinter.
Affected Issue Numbers
Code Review Notes
Checklist

[ ] All issue requirements satisfied (or no linked issues)
[ ] Linting passes.
[ ] Migrations created & committed (or no model changes)
[ ] Tests implemented (or no code changes)
[ ] All tests pass

I believe I have merged this idea in, but with regex changes, though I wonder if I did it backwards.  I will close/delete this, though, thanks.


Complete assembly compiler for string operations

@dr-orlovsky I need some clarification on Splt.
Firstly, Docstring says that sometimes "zero-length string" should be put. ByteStr, however, has a 0-based length. This means ByteStr with 0 length has one character. Maybe we can define "zero-length string" as len = 0 && all bytes are set to 0?
Secondly, I am not sure if this docstring is correct. It occured to me that the sentence should be other way around; if offset value is greater than string length, operation would always fail.

I think this issue (and the whole macro assembly compiler) is outdated because we have a proper standalone compiler for now: https://github.com/pandoracore/aluasm
However your questions and valid and deserve a dedicated issues. I can't answer on them right afay and need to look deeply by myself.


Improve Collada Export

Added option to export custom vertex normals:
https://github.com/simlu/voxelshop/commit/b8be8dde33ba21ebf98613fa4ffe4443702f3dcf

Lots of changes, here are the important ones:

added option to triangulate by color (required for vertex coloring)
added vertex coloring (option)
removed legacy exporter (since functionality is now covered by normal exporter)
added option for non overlapping / non skewed uvs
minor improvements to exporter dialog
fixing t-junction problems is now an issue
added option to export textured voxels with main exporter
restructured collada export dialog

Reference Pull Request:
https://github.com/simlu/voxelshop/pull/13

This is basically done. Still need to improve the texture combine speed since exporting textured voxels can make this really slow, but I moved that out into a separate issue (https://github.com/simlu/voxelshop/issues/16). Will merge shortly.


unfilled bug: when item.disabled is a function, it is now called on item.click

unfilled bug: when a menu.item.disabled element is a function, and it evaluates to false (item is enabled), the item callback was not called, as if item was disabled. This version check if menu.item.disabled is a function, and calls it as stated in the doc, when the item is clicked.

erf, forget it, this change was done on an old version. Moreover, it isn't he most efficient way. Now, I don't enough about github to cancel my commit (I guess I can't). sorry about it.


Changelog is outdated

The most recent version in the changelog is 5.0.0, but npm is already offering 5.4.1. Can you please document what has changed since 5.0.0?
Since this is a security-related component, I would like to see changes being documented properly.

Yes, we will handle this.


Adding 155-Min-Stack.kt

File(s) Modified: 155-Min-Stack.kt
Language(s) Used: kotlin
Submission URL: _https://leetcode.com/submissions/detail/765291828/_

Thanks, @Raven1233!


Symbol compilation

Hi all !
I have  a model with a state x of dimension 2:
x = zeros(N,2)
for i in 1:N
  x[i,1:2] ~ P
  y[i] ~ Normal(x[i,1], 1.0/sqrt(x[i,2]))
end
...
chain = sample(model(data), sampler)
println(chain.names)

The symbol x is compiled in a weird way when I run println(chain.names).  Could that be easily solved ?
Best,
Emile

A way to solve that would be to handle assume statement with tuple on the left-hand side:
  x[i], z[i] ~ P

Would that be hard to implement ?


Refactor product listing facets as a CMS component, mapping to ProductRefinementComponent

Using the generic page layout, we can now render CMS components using the backend configuration. The backend provides a ProductLeftRefinements slot with a "ProductRefinementComponent" component.

#1075 and #1076 are similar and also similar to the one marcin did a while ago


Can't Display GUI

What steps will reproduce the problem?

Hi there, I have an issue is that when I run the code on spyder, I'm expecting it to display a gui window, even though the Python app is running,nothing happens. I've tried so many times but it doesnt work. Please help!!!

Hi @buunghi,
I don't understand your issue, are you creating a gui window in your code and it is not appearing in Spyder? Have you tried your code on a python interpreter and see if the gui window is created?
Please post a screenshot, or provide me an example to try to reproduce this in my end.
Thanks for reporting!

Closing due to lack of response.


meta-interpreter to enumerate parameters and drive interpreters

solved by https://github.com/ReMobidyc/ReMobidyc/pull/199


[test] Introduce facilities to test CMake code

Also provide a simple test to characterize the current behaviour around
LTO -- this is mainly to show how CMake tests may be structured.

@swift-ci please smoke test

I found myself adding CMake testing as part of other PRs I am iterating on (e.g. #37568, #37908), so I thought it could be a good idea to land that part on its own.

@swift-ci please test Windows

@swift-ci please smoke test


Better exit handling when background thread is still running

Currently, if the process exits while the background thread that decodes HTML for "Find in Files" is still running, that thread is suspended. This is not a good approach: the thread could be suspended while allocating memory and holding a lock in the memory allocator, for example.

Fixed by @5a270eff329bc9585b1685caabbb1d7207bf19c1


Better support for categorical predictors

Hi i am also interested in the above. I had an idea, not sure how hard it would be to implement. I have a good example.
Basically I am trying to model gas and electricity consumption. Now its fairly obvious that this depends on businesses working weeks. So in this case we would have 7 (0,1) flags for the day of the week. However in all likely hood what i expect to dominate is a weekend weekday effect. If i give the 7 columns with day of week flags i expect that MARS would find it harder to find a weekday weekend effect as it would have to use 7 variables to do this. Where as if i where to simply give a weekday/weekend flag as this would only require 1 variable, MARS would find this less 'costly' to fit and is more likely to find a match.
But in the above case where i provide 7 day of week flags plus a weekend/weekday flag i am essentially choosing how to split the week up, where as i would hope MARS could do this itself.
I wonder if MARS could derive from the 7 day of week flags that days 1-5 are the same and 6-7 the same, and create a variable that is less costly within the algorithm to fit.

When passed a xdata entry of strings it makes a set of flag columns 1 for each categorical data point (this would make things more convenient and allow the 2) )
Once MARS has done the initial over fit it sees if the the parameters fitted for say  Monday to Friday are essentially the same and as such can be grouped. the grouped version creates a new variable, which is added tot he list of variables. Now MARS is refitted with weekday, weekend as well as the 7 day of week flags. Thus if we don't get a good enough fit p[er complexity of the 7 day of week flags, the weekend weekday effect can dominate.  Once grouped the complexity cost of fitting them is reduced.

I suppose with 2) you could use brute force and find every combination of the 7 day of week flags but i expect this will create a massive amount of categorical flags: using N choose R i get 127 flags from 7.
The above example is kinda obvious and i can work around it, but there are other cases where say i am forecasting 100 counter parties. Say some are offices and some are factories, if I had categorical flag for each site then i would like MARS to find the groups of sites. say one set are factories and one set are offices.
This could well be beyond scope or take too long for MARS to fit but i thought i would mention it if you where thinking about modifying categorical predictors.
Cheers

@Fish-Soup, there is some existing work on MARS for categorical variables.  See here:
http://media.salford-systems.com/library/MARS_V2_JHF_LCS-108.pdf
The discussion of categorical variables starts on page 13.  It seems quite similar to what you suggest.  My initial plan would be to implement the technique described.  However, I'm not sure how soon it will happen.  If you feel like reading it, I would be interested to learn your thoughts on whether the proposed techniques would meet your needs.  The paper is, unfortunately, rather wordy, though.

Not wanting to be a stick in the mud, but series with categorical
predictors can also be modeled by more traditional means, including state-
space methods developed and taught by people like Durbin, Koopman,
Harvey, Poole, West, and Harrison. If time -- basically an index of
successive dependent observations -- is less important, then the
generalized additive models that Wood so ably describes[1], even if they
are frequentist, warrant a look. Because I'm a Bayesian I must caution,
however, that these are so flexible, it's possible these are
essentially model-free, unless strong priors are applied to components,
like the [2]g-priors[3] of Bové, Held, and Kauermann[4].
Earth/MARS might produce low m.s.e., but it can be hard to constrain
model elements, and harder to interpret such constraints in problem-
specific terms.

Jan Galkowski

On Wed, Apr 26, 2017, at 05:26, Fish-Soup wrote:

Hi i am also interested in the above. I had an idea, not sure how hard
it would be to implement. I have a good example.> Basically I am trying to model gas and electricity consumption. Now
its fairly obvious that this depends on businesses working weeks. So
in this case we would have 7 (0,1) flags for the day of the week.
However in all likely hood what i expect to dominate is a weekend
weekday effect. If i give the 7 columns with day of week flags i
expect that MARS would find it harder to find a weekday weekend effect
as it would have to use 7 variables to do this. Where as if i where to
simply give a weekday/weekend flag as this would only require 1
variable, MARS would find this less 'costly' to fit and is more likely
to find a match.> But in the above case where i provide 7 day of week flags plus a
weekend/weekday flag i am essentially choosing how to split the week
up, where as i would hope MARS could do this itself.> I wonder if MARS could derive from the 7 day of week flags that days
1-5 are the same and 6-7 the same, and create a variable that is less
costly within the algorithm to fit.

When passed a xdata entry of strings it makes a set of flag
columns 1 for each categorical data point (this would make things
more convenient and allow the 2) )
Once MARS has done the initial over fit it sees if the the
parameters fitted for say  Monday to Friday are essentially the
same and as such can be grouped. the grouped version creates a new
variable, which is added tot he list of variables. Now MARS is
refitted with weekday, weekend as well as the 7 day of week flags.
Thus if we don't get a good enough fit p[er complexity of the 7
day of week flags, the weekend weekday effect can dominate.  Once
grouped the complexity cost of fitting them is reduced.> I suppose with 2) you could use brute force and find every combination
of the 7 day of week flags but i expect this will create a massive
amount of categorical flags: using N choose R i get 127 flags from 7.> The above example is kinda obvious and i can work around it, but there
are other cases where say i am forecasting 100 counter parties. Say
some are offices and some are factories, if I had categorical flag for
each site then i would like MARS to find the groups of sites. say one
set are factories and one set are offices.> This could well be beyond scope or take too long for MARS to fit but i
thought i would mention it if you where thinking about modifying
categorical predictors.> Cheers

— You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub[5], or mute the
thread[6].>

Links:

https://www.crcpress.com/Generalized-Additive-Models-An-Introduction-with-R-Second-Edition/Wood/p/book/9781498728331
https://arxiv.org/pdf/1108.3520.pdf
https://arxiv.org/pdf/1108.3520.pdf
https://arxiv.org/pdf/1108.3520.pdf
https://github.com/scikit-learn-contrib/py-earth/issues/156
https://github.com/notifications/unsubscribe-auth/AD3HBzWO3p6E-Oa4aFUSj-zCPTb2cxtPks5rzw3IgaJpZM4NImFJ

@jcrudy I had a quick read of the document. It seems to be in line with what I was thinking. I wonder if something aproaching this could also be applied to continuous data where by you could split two region's into non continous chunck's.  In my example sometimes with time  factories turn on and start consuming on say a specific day of the year.  MARS normally acts a bit idly around this jump in demand a's the underlying distribution is not smooth but Mars tries to make it so.
@empirical-bayesian I will look into gam's currently I have a mixture of continous and catagoricall data. Overall MARS is fitting it well.

@Fish-Soup It would certainly be possible to add something like that.  For now, though, I think the trick from our issue #141 discussion is the closest that you'll get.  If I do get around to implementing the subsetting approach described in that paper, though, perhaps in the process I'll think about this as well.
@empirical-bayesian I would definitely agree that with only categorical variables the case for using MARS is not that strong.  Although, with the automatic subset selection process described in that paper it might be stronger.  The main advantage of MARS over GAM, as I've seen them implemented (and I'm no expert on this), is the automatic search for interactions.  However, I believe GAM has its own advantages, such as a greater variety of loss functions.  I'm not sure what functionality GAM offers for missing data.

I haven't dug into py-earth's implementation for multiple interactions
and especially automatic search.  I am leery, however, because if a
significant interaction is tested using a traditional hypothesis test,
then seeking multiple ones needs correction for multiple testing, per
familywise error rates and the like. (See Efron, Large-Scale
Inference, 2010, and, in particular, false discovery rate control.)
Interactions are also tough to validate ... If there's a particular high
order combination of attribute predictors which enter an interaction,
the number of observations (responses bound to predictors) for each such
interaction are smaller, possibly much smaller. Moreover the number of
observations across interactions is not likely to be balanced, unless
the experimental design is done to assure this.

Jan

On Thu, May 11, 2017, at 14:09, Jason Rudy wrote:

@Fish-Soup[1] It would certainly be possible to add something like
that.  For now, though, I think the trick from our issue #141[2]
discussion is the closest that you'll get.  If I do get around to
implementing the subsetting approach described in that paper, though,
perhaps in the process I'll think about this as well.> @empirical-bayesian[3] I would definitely agree that with only
categorical variables the case for using MARS is not that strong.
Although, with the automatic subset selection process described in
that paper it might be stronger.  The main advantage of MARS over GAM,
as I've seen them implemented (and I'm no expert on this), is the
automatic search for interactions.  However, I believe GAM has its own
advantages, such as a greater variety of loss functions.  I'm not sure
what functionality GAM offers for missing data.> — You are receiving this because you were mentioned. Reply to this
email directly, view it on GitHub[4], or mute the thread[5].>

Links:

https://github.com/fish-soup
https://github.com/scikit-learn-contrib/py-earth/issues/141
https://github.com/empirical-bayesian
https://github.com/scikit-learn-contrib/py-earth/issues/156#issuecomment-300871938
https://github.com/notifications/unsubscribe-auth/AD3HB6ZQVDhhd7BqNEsAy1z6QbTreRUpks5r407tgaJpZM4NImFJ

@jcrudy Hi yeah i still mean to try the approach in #141 , Other stuff just keeps coming up that I need to solve first. And yeah I mainly mentioned my idea in case you did get to implementing the categorical data improvements as it did seem like an consistent addition.
@empirical-bayesian For my current simulations the interaction terms are very important. I'm sure its possible to model them with more care in other approaches. But currently I need a method to apply to a few different problems as their delivery is time critical. Once i have decent solutions across the board I will look into other approaches. I just currently find MARS quite easy to use and understand the output.

Definitely agreed about the dangers of considering many possible interactions.  MARS does make use of various methods to reduce the risk of overfitting, but I would always recommend cross-validation with MARS or any other machine learning technique.


Add implementation of depthwise deconvolution.

Implementation of the depth-wise deconvolution plus extension of the depth-wise convolution to support a multiplier of other than 1.

Thanks!


The section/instructions about ensuring use of the OME portal is not clear

Section:
https://docs.microsoft.com/en-us/microsoft-365/compliance/manage-office-365-message-encryption?view=o365-worldwide#ensure-all-external-recipients-use-the-ome-portal-to-read-encrypted-mail
The steps provided, specifically the powershell command below, just create a transport rule that references the one template you already have.  It doesn't mention or consider that you want to force OME portal use and not allow decryption in Outlook.
New-TransportRule -name "" -FromScope "InOrganization" -ApplyRightsProtectionTemplate "" -ApplyRightsProtectionCustomizationTemplate "

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 33bb6e61-f899-955c-948d-bf17f0168fea
Version Independent ID: be8ea691-3547-a442-d2ca-617e17225740
Content: Manage Office 365 Message Encryption - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/manage-office-365-message-encryption.md
Service: o365-seccomp
GitHub Login: @KCCross
Microsoft Alias: krowley

@paulypoteat Thank you for your feedback. Per the transport rule, you are using the template "OME Configuration" with Encrypt only, The template"Ome Encryption" by default has OTP Enabled Set to True so it will force OME portal use and not allow decryption in outlook.

Hope this helps!
Thanks
Sri

@msbemba Thank you very much for the contribution and sharing this explanation. @paulypoteat Hope this comment is helpful for you. If you see a documentation update is required, please feel free to open an issue for the same. We proceed here to close it. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


 To consolidate services, we are migrating everyone over to the OS Hub style EMs by the end of February. At that point, we will be ready to shut down the service supporting OAR EMs.
Expected Behavior

Support for the OAR EM endpoint is disabled
All traffic to OAR EMs is routed to OS Hub EMs

CAN label on this because we will need to confirm that everyone is transitioned to the OS Hub style EM.

To be updated 3/1

@mariel-oar - moved this to backlog since it's not actionable ATM!

Hey team! Please add your planning poker estimate with Zenhub @jwalgran @mstone121 @TaiWilkin


config:set encloses values with apostrophes when using a Dockerfile

All string config values get enclosed by apostrophes.
e.g. dokku config:set NODE_ENV=production
Generates the config export NODE_ENV='production'
in the files /home/dokku/app/ENV and /dokku/app/DOCKERFILE_ENV_FILE
The problem only occurs when using a custom Dockerfile in the root directory of the pushed repo.
I believe setting environment variables like that won't work in docker:
docker run -e NODE_ENV='production'
They needs to be written as:
docker run -e 'NODE_ENV=production'

I confirm this behavior.
All environment variables are enclosed by single quote.
dokku: master 70e1e5d14dc79907ae7b8afd28d6b88f5b7c7efd
Custom Dockerfile

Hrm. We have a test for this.... Are you seeing behavior in your app that would indicate these are not getting injected correctly?

Yep!
I think simplest test will be:
dokku config:set TEST_VAR=foobar

#!/bin/bash

echo $TEST_VAR

expected: foobar
actual: 'foobar'

@michaelshobbs are you testing a Dockerfile app in that test?

Yes but its naive. I'll sort it out.
https://github.com/progrium/dokku/blob/70e1e5d14dc79907ae7b8afd28d6b88f5b7c7efd/tests/unit/config.bats#L60-L66


redux devtools dispatch not working

I looks like if I try to dispatch an action from devtools it doesn't work...
Can you confirm that?

@Kiho could you please answer this one?

I am not sure understand question correctly, only a few actions were implemented here. https://github.com/redux-zero/redux-zero/blob/master/src/devtools/devtoolsMiddleware.spec.ts#L31


feat(tutorial): complete step 5

Closes #
My Bluemix URL: https://carbon-tutorial-tiagocunha.mybluemix.net/#/
Changelog
New

{{new thing}}

Changed

{{change thing}}

Removed

{{removed thing}}

Per instructions in the tutorial step 5, please include your mybluemix.net URL for your deployed app in your pull request description.

updated:  https://carbon-tutorial-tiagocunha.mybluemix.net/#/


SAK-29252 - Remove portal chat backward compatibility with neoportal

Removed from portal chat exclusive code for neoportal. Now all reference are just for Morpheus

Do you know whay this won't merge cleanly?

It seems that travis failed from previous PR and it is preventing merging. I don't see anything disruptive in my commit. Just changing some js lines.

@csev Now that travis build is fine, automatic merge is possible. I closed & reopened this PR to force travis build once I saw that the project was building was fine again.

LGTM


feat: add influx utilities packages

Replaces the pull requests #257 and #51 which are now too old.
Closes: #257
Closes: #51

From Skyra Lounge:

@kyranet @favna, By the way, as long as PR is not merge we would not be able to manage interactions like commands in order to separate the different iteractions by type by adding a type tag because otherwise with autocomplete it will be completely distorted I think.
What do you think ?


Remove friendly_name attribute from twitch sensor

Breaking change

Remove unnecessary friendly_name attribute as requested in https://github.com/home-assistant/home-assistant/pull/31122#discussion_r380917570
Proposed change

Type of change

[ ] Dependency upgrade
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New integration (thank you!)
[ ] New feature (which adds functionality to an existing integration)
[ ] Breaking change (fix/feature causing existing functionality to break)
[x] Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
sensor:
  platform: twitch
  client_id: <client_id>
  oauth_token: <oauth_token>
  channels:
    - gronkh

Additional information

This PR fixes or closes issue: fixes #
This PR is related to PR: #31122
Link to documentation pull request:

Checklist

[ ] The code change is tested and works locally.
[x] Local tests pass. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.
[x] I have followed the development checklist
[x] The code has been formatted using Black (black --fast homeassistant tests)
[ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[ ] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

[x] No score or internal
[ ] 🥈 Silver
[ ] 🥇 Gold
[ ] 🏆 Platinum

Thanks!


Variable viewer should not rely on just the class name, but instead the fully qualified type name as well as the base classes

Assume I have a class named DataFrame and I want a variable viewer for this.
Unfortunately, all Pandas DataFrames will be treated as DataFrame types and will result in my variable viewer being invoked.

Suggestion - We should consider the namespace, not just the class name.

Similarly assume I created a variable viewer for Pandas DataFrame,
A user writes code that sub classes pandas data frames and creates a variable for this.
Now my variable viewer will not show up because we look specifically for this type.
We already have issues reported for this for data frame viewer.

Suggestion - We should consider the base classes not just the type name
E.g. when I created a viewer for Widgets, there are tones of widgets out there and each Jupyter widget is a separate class that inherits the Widget class from IPyWidgets.
Hence there's no way for me to know the name of the widget class, all I know is the fact that my variable viewer can handle any class that inherits the IpyWidgets... widget class.
Suggestion
I would suggest variable viewer extract the __mro__ from the type name and keep track of that.
Then extensions can say they support variables of type fully.qualified.namespace.types in notebook-variable-visualizer.supportedTypes
E.g. I know all widgets inherit ipywidgets.widgets.widget.Widget, hence I can store that in notebook-variable-visualizer.supportedTypes.
And internally the variable viewer (VS Code and Jupyter extesnion) should track the MRO as well.
I think this makes sense, as using just the class name is not sufficient.
Without this change, I (my variable viewer extesnion) have to fetch the variables myself using the same code as Jupyter Extension, then find out the widget variables, and then find the name & type of that variable.
E.g. if user has a widget variable named plot and type is k3d.plot.Plot, now I have to write python code to get the base classes of this using __mro__
Then I get the following
(k3d.plot.Plot,
 ipywidgets.widgets.domwidget.DOMWidget,
 ipywidgets.widgets.widget.Widget,
 ipywidgets.widgets.widget.LoggingHasTraits,
 traitlets.traitlets.HasTraits,
 traitlets.traitlets.HasDescriptors,
 object)

Given that ipywidgets.widgets.widget.Widget is one of the base classes, I know the variable plot can be handled by my widget viewer and then I need to now dynamically update the notebook-variable-visualizer.supportedTypes with the value k3d.plot.Plot

Not sure how to verify this as I believe the API is different now.
I tried the old approach it does not work, neither does my work around.
I am assuming there's a new context variable, tried the following and that too does not work
"when": "variableExtensionId === ms-toolsai.jupyter && ipywidgets.widgets.widget.Widget in variableInterfaces"

Figured it out,
"when": "ipyWidgetVariableType in variableInterfaces"

    vscode.commands.executeCommand(
        'setContext',
        'ipyWidgetVariableType',
        'ipywidgets.widgets.widget.Widget'
    );

Works now, thanks


Avoid regenerating crates unnecessarily

First of all, thanks for the awesome tool.
It really feels like an improvement over build scripts for code generation.
I use cargo px to generate ICU data for display purposes with icu_datagen.
However, cargo px regenerates the data module every build, which means that dependent crates also get rebuilt on every run.
It would be nice if we could tell cargo px a set of "input files" and it only regenerates the crate when those files change.
For now, I work around that by running cargo px only to regenerate the crate and using cargo normally otherwise.
But long term, it would be nice to not have to keep the difference in mind.

Hey!
This behaviour is by design. Generators can be fairly complex and cargo px defaults to always invoking the generator, making it responsible for determining if there is any work to be done.
I plan to build some auxiliary libraries to make this straightforward for the most common cases, such as keeping track of changes to a set of files.
It looks somewhat like this:
use std::path::Path;
use std::fs::File;
use std::io::{self, Read};
use sha2::{Sha256, Digest};

fn compute_checksum(paths: &[&Path]) -> io::Result<String> {
    let mut hasher = Sha256::new();

    for path in paths {
        if let Ok(file) = File::open(path) {
            let mut reader = io::BufReader::new(file);
            let mut buffer = [0; 8192]; // Buffer size (adjust as needed)

            loop {
                let bytes_read = reader.read(&mut buffer)?;
                if bytes_read == 0 {
                    break;
                }
                hasher.update(&buffer[..bytes_read]);
            }
        } else {
            // If file doesn't exist or cannot be opened, consider it as an empty file
            let empty_data: &[u8] = &[];
            hasher.update(empty_data);
        }
    }

    let result = hasher.finalize();
    Ok(format!("{:x}", result))
}

You can store the checksum in the metadata section of the manifest of the generated crate using toml_edit.
If the checksum is unchanged, you skip re-generating the module:
// Read the contents of the Cargo.toml file
let toml_content = fs::read_to_string(
    cargo_px_env::generated_pkg_manifest_path().unwrap()
).expect("Failed to read Cargo.toml");

// Parse it
let mut doc = toml_content.parse::<Document>().expect("Failed to parse Cargo.toml");

// Access the metadata.source.checksum field
let old_checksum = doc["package"]["metadata"]["source"]["checksum"]
        .as_value_mut();

I hope this helps!


Fix deprecated usage of functions in feacalc

Right now feacalc throws an error, which I traced to

2 instances of sum omitting the dims keyword argument
one is in sad, the other is basically a copy of it, maybe sad can be called instead?
Plus the log10 looks like it is supposed to be broadcasted
Float64 should replace float64
Indexing in sad looks old and doesn't work now but I still get BoundsErrors even after updating that.
The readall in soxread should also be changed, and maybe also use an open do block?

Yes it looks like this code hasn't been used in many versions of Julia, incl version 1.
Since you already put some effort in this, any chance you can fix this and submit a PR?

Yes, thanks!


Add collection model for responses

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Earlier request to kytos topology API can result in unhandled exceptions by topology event handler

Hi,
If we restart Kytos with sdx_topology enabled, we can have errors like this:
2023-08-24 13:43:20,958 - ERROR [kytos.core.helpers] [helpers.py:147:handler_context] (thread_pool_app_0) listen_to handler: <function Main.listen_event at 0x7f12443101f0>, args: (<Main(sdx_topology, stopped<PHONE_NUMBER>37088)>, KytosEvent('kytos/topology.port.created', {'switch': 'aa:00:00:00:00:00:00:01', 'port': 1, 'port_description': {'alias': 'Ampath1-eth1', 'mac': 'f2:a4:dd:09:1a:4f', 'state': None}}, 0)) traceback: Traceback (most recent call last):,   File "/usr/local/lib/python3.9/dist-packages/urllib3/connection.py", line 174, in _new_conn,     conn = connection.create_connection(,   File "/usr/local/lib/python3.9/dist-packages/urllib3/util/connection.py", line 96, in create_connection,     raise err,   File "/usr/local/lib/python3.9/dist-packages/urllib3/util/connection.py", line 86, in create_connection,     sock.connect(sa), ConnectionRefusedError: [Errno 111] Connection refused, , During handling of the above exception, another exception occurred:, , Traceback (most recent call last):,   File "/usr/local/lib/python3.9/dist-packages/urllib3/connectionpool.py", line 699, in urlopen,     httplib_response = self._make_request(,   File "/usr/local/lib/python3.9/dist-packages/urllib3/connectionpool.py", line 394, in _make_request,     conn.request(method, url, **httplib_request_kw),   File "/usr/local/lib/python3.9/dist-packages/urllib3/connection.py", line 239, in request,     super(HTTPConnection, self).request(method, url, body=body, headers=headers),   File "/usr/lib/python3.9/http/client.py", line 1255, in request,     self._send_request(method, url, body, headers, encode_chunked),   File "/usr/lib/python3.9/http/client.py", line 1301, in _send_request,     self.endheaders(body, encode_chunked=encode_chunked),   File "/usr/lib/python3.9/http/client.py", line 1250, in endheaders,     self._send_output(message_body, encode_chunked=encode_chunked),   File "/usr/lib/python3.9/http/client.py", line 1010, in _send_output,     self.send(msg),   File "/usr/lib/python3.9/http/client.py", line 950, in send,     self.connect(),   File "/usr/local/lib/python3.9/dist-packages/urllib3/connection.py", line 205, in connect,     conn = self._new_conn(),   File "/usr/local/lib/python3.9/dist-packages/urllib3/connection.py", line 186, in _new_conn,     raise NewConnectionError(, urllib3.exceptions.NewConnectionError: <urllib3.connection.HTTPConnection object at 0x7f12428253d0>: Failed to establish a new connection: [Errno 111] Connection refused, , During handling of the above exception, another exception occurred:, , Traceback (most recent call last):,   File "/usr/local/lib/python3.9/dist-packages/requests/adapters.py", line 486, in send,     resp = conn.urlopen(,   File "/usr/local/lib/python3.9/dist-packages/urllib3/connectionpool.py", line 755, in urlopen,     retries = retries.increment(,   File "/usr/local/lib/python3.9/dist-packages/urllib3/util/retry.py", line 574, in increment,     raise MaxRetryError(_pool, url, error or ResponseError(cause)), urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='<IP_ADDRESS>', port=8181): Max retries exceeded with url: /api/kytos/topology/v3/ (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f12428253d0>: Failed to establish a new connection: [Errno 111] Connection refused')), , During handling of the above exception, another exception occurred:, , Traceback (most recent call last):,   File "/usr/local/lib/python3.9/dist-packages/kytos/core/helpers.py", line 143, in handler_context,     result = handler(*args),   File "//var/lib/kytos/napps/kytos/sdx_topology/main.py", line 189, in listen_event,     if event is not None and self.get_kytos_topology():,   File "//var/lib/kytos/napps/kytos/sdx_topology/main.py", line 78, in get_kytos_topology,     kytos_topology = requests.get(,   File "/usr/local/lib/python3.9/dist-packages/requests/api.py", line 73, in get,     return request("get", url, params=params, **kwargs),   File "/usr/local/lib/python3.9/dist-packages/requests/api.py", line 59, in request,     return session.request(method=method, url=url, **kwargs),   File "/usr/local/lib/python3.9/dist-packages/requests/sessions.py", line 587, in request,     resp = self.send(prep, **send_kwargs),   File "/usr/local/lib/python3.9/dist-packages/requests/sessions.py", line 701, in send,     r = adapter.send(request, **kwargs),   File "/usr/local/lib/python3.9/dist-packages/requests/adapters.py", line 519, in send,     raise ConnectionError(e, request=request), requests.exceptions.ConnectionError: HTTPConnectionPool(host='<IP_ADDRESS>', port=8181): Max retries exceeded with url: /api/kytos/topology/v3/ (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f12428253d0>: Failed to establish a new connection: [Errno 111] Connection refused')),

This happens probably due to earlier requests to topology API, when the server is still booting UP. We should have error handler there and a retry mechanism with considers a retry interval, and possibly overlapping requests (since we will have multiple topology.updated / port.created events at the begin)

sdx_topology napps have a version control method that determines when to initiate an initial request to the Kytos topology API. This is controlled by the SDX-LC app.


Eye button is hard to click on mobile

Increase the touch target size in password-field default theme

Closing this for now. We need a common aligned approach for all elements in general. Current take on this is that button sizing is a theme's (Valo) responsibility.


[Bug]: v0.4.2 python3.8 TypeError: 'type' object is not subscriptable (python3.9 syntax)

Your current environment
The output of `python collect_env.py`

🐛 Describe the bug
python -m vllm.entrypoints.openai.api_server --model microsoft/Phi-3-mini-4k-instruct --dtype auto --max-model-len 2000
Error
File ".../python3.8/site-packages/vllm/entrypoints/openai/api_server.py", line 37, in <module>
    _running_tasks: Set[asyncio.Task[Any]] = set()
TypeError: 'type' object is not subscriptable

Used python3.10 syntax

cc @rkooo567 is this file checked by mypy? It is strange that it passes mypy checking.

cc @rkooo567 is this file checked by mypy? It is strange that it passes mypy checking.

I guess that type checking is disabled for imported items due to setting follow_imports = "skip".

Also it is not fully covering every case yet. I made is type check subdirectories, but cross directories are not checked yet (it requires us to pass mypy vllm/ --config... which requires another 200 issues to fix)


setting dev.i915.perf_stream_paranoid via boot.kernel.sysctl doesn't persist reboots

Describe the bug
It appears that boot.kernel.sysctl don't automatically apply its configuration to the system correctly.
Steps To Reproduce
Steps to reproduce the behavior:

Stick the following into configuration.nix:

boot.kernel.sysctl = {
    "dev.i915.perf_stream_paranoid" = false;
};

Run nixos-rebuild switch
Optionally reboot, optionally repeat step 2
sysctl dev.i915.perf_stream_paranoid will still report 1

Expected behavior
sysctl dev.i915.perf_stream_paranoid should report 0
Additional context
Manually running systemctl restart systemd-sysctl after step 2 or 3 will make step 4 report the expected value.
Notify maintainers
@Mic92 @flokli
Metadata
┌─[~]
└─[charles@worky]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.10.64, NixOS, 21.05.3208.8dd8bd8be74 (Okapi)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.15`
 - channels(root): `"nixos-21.05.3208.8dd8bd8be74"`
 - channels(charles): `""`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:
  - "boot.kernel.sysctl"

the systemd-sysctl already has a restartTrigger for /etc/sysctl.d/60-nixos.conf
    systemd.services.systemd-sysctl =
      { wantedBy = [ "multi-user.target" ];
        restartTriggers = [ config.environment.etc."sysctl.d/60-nixos.conf".source ];
      };

for me the service gets restarted (monitored with journalctl -xe -f --unit=systemd-sysctl) when i change the value of "vm.swappiness" = 101;

Hmm okay, trying this shows that it does actually work on my machine, but only after manually nixos-rebuild switching; it still won't apply automatically at boot. Your monitoring command shed some light on the source of the problem, it emitted
systemd-sysctl[736]: Couldn't write '0' to 'dev/i915/perf_stream_paranoid', ignoring: No such file or directory

while booting. But, I'm still not sure exactly how to resolve that

what files are in /proc/sys/dev/i915

┌─[~]
└─[charles@worky]$ exa -T /proc/sys/dev/i915
/proc/sys/dev/i915
├── oa_max_sample_rate
└── perf_stream_paranoid

does doing sudo sysctl -w dev.i915.perf_stream_paranoid=0 manually work

repeat 10000 { cat /proc/sys/dev/i915/ } run this in zsh and rebuild and then check the output to check if the file disappears at some point
sadly inotifywait does not work on /proc files therefore we cant use this command
$(nix-build '<nixos>' -A inotify-tools)/bin/inotifywait -m /proc/sys/vm/swappiness

looks like this is a issue on other distros too
https://forum.manjaro.org/t/cant-change-dev-i915-perf-stream-paranoid-to-0/66339
the command run by the systemd service can be run manually by doing
$(nix-build '<nixos>' -A systemd)/lib/systemd/systemd-sysctl

if this is an upstream issue and can't be fixed on our side then at least this should work
networking.localCommands = ''
  ${pkgs.procps}/bin/sysctl -w dev.i915.perf_stream_paranoid=0
''

does doing sudo sysctl -w dev.i915.perf_stream_paranoid=0 manually work

Yeah, it does

repeat 10000 { cat /proc/sys/dev/i915/ } run this in zsh and rebuild and then check the output to check if the file disappears at some point
sadly inotifywait does not work on /proc files therefore we cant use this command
$(nix-build '<nixos>' -A inotify-tools)/bin/inotifywait -m /proc/sys/vm/swappiness

I tried the repeat command a few times but didn't see any errors

looks like this is a issue on other distros too
https://forum.manjaro.org/t/cant-change-dev-i915-perf-stream-paranoid-to-0/66339
the command run by the systemd service can be run manually by doing
$(nix-build '<nixos>' -A systemd)/lib/systemd/systemd-sysctl

Oh that's unfortunate. That command does work, though I have to run it as root. It appears to run without root but won't actually affect anything.

if this is an upstream issue and can't be fixed on our side then at least this should work
networking.localCommands = ''
  ${pkgs.procps}/bin/sysctl -w dev.i915.perf_stream_paranoid=0
'';

This does indeed work. Thank you!

i only know that that sysctl option has this issue so the title should include it

@stale This is still relevant.


slack join link has expired

https://github.com/malloydata/malloydata.github.io/blob/752f6ba1960325e18c7fa3fc707a44a1db4bc72a/docs/_src/index.md?plain=1#L18

yeesh 😵💫 thanks Steve!


attachment shearing not working

when you share an attachment file with a user, the user can't view the content of the attachment and it doesn't give any errors.

Hi @MrJico, thanks for share your error. I see the file in the screenshot is private, How do you share the file? could you give us more details, please? :) Thank you

same https://docs.erpnext.com/docs/user/manual/en/sharing
just for and attachemnt doc.

Yes I tried to replicate it and it happens, and happens without external storage selected too, with standard filesystem.
Please try at your side. So not an app issue, and a Frappe issue or I am not doing something wrong!
Please leave the field blank and save and check again with normal functionality:

I shared like this:

Thanks for your time @MrJico

@MrJico the doc is readable, but file is not downloable if private. You can see here:
For file being downloadable, Frappe checks this:

Then, in this line, the value of doc.is_private = 1, so continue with next lines:

Then returns False (line 85) for has_permission:

Then the file is not readable, (even you are reading the File document). Please add the issue to Frappe Framework or do a fix and a Pull Request to solve it :)
Thank you @MrJico

thanks sir, i needed to verify on my side first, that really is a very bad short coming for erpnext, i will try to figure it out and make a pull request to the main frappe branch, other wise will just open a new issue for it.

after a bit more digging i found out that if the file is not attached it doesn't check the permissions at all and just return false, so they don't check if the file is not attached.

by checking if the document is shared, we can over come this with using frappe.share.get_shared(             doc.doctype, user=user, filters=[["share_name", "=", doc.name]]         )

can you please verify ?

one other thing is that the user even if he has only read access, can toggle the is private flag, once then the permission manager kicks in for the next times, so this seems to be another bug in the system

after a bit of digging i found the bug. it is due to the if statement

and to fix it simply adding another check will be sufficient

any updates ?

Thankyou for your investigation @MrJico. Knowing that is not an issue of this repository, please do a pull request Frappe respository, please. Thanks again for your help :)

thanks sir, i am not very familiar  with frappe so if you could just validate it, i will migrate this issue to frappe.

@MrJico not an DFP External Storage issue, but I am trying to help you. Things I need to replicate your issue correctly:
1. Screenshot of user roles, permissions and type of user
Roles & permissions

Type of user

Please, check what happens if you attach the file to other document user has access, what happens? Can it read it then?
Tell me exactly your Frappe version and commit possition, please.
I do not want to close it yet and want to help you :) Thanks @MrJico

if i understand you correctly, if you link the attachment to a document and the user has access to that document it has no problems, this only happens if the attachment is not linked to any document.
as for the version i don't think matters, because as far as i looked nothing has changed in the way they process files, but i use version 14 latest update on production, and docker for local at 9321153b793edda5b896d41d300812664533cf91

if i understand you correctly, if you link the attachment to a document and the user has access to that document it has no problems, this only happens if the attachment is not linked to any document.

Yest that's it, could you check at your side, please?

if i understand you correctly, if you link the attachment to a document and the user has access to that document it has no problems, this only happens if the attachment is not linked to any document.

Yest that's it, could you check at your side, please?

my answer is me describing how its now.

Not having personal free time to check it. I close because is not related to this app and related to how Frappe works sharing files internally.


zero: A whitelist alternative to the current blacklist

It would be great to add new behavior to zero plugin. Now it only blacklists fields. With whitelist option plugin will clear everything what is not whitelisted.

Thanks!


Crash when using Blade's echo to render enum

Laravel Version: 9.3.8
PHP Version: 8.1.0

Description:
Not sure if this is a bug per se, but when using Blade's echo function to render an enum it throws an exception.
I guess this is expected, but it'd be nice to add a check for this in the echo function and either render the name if it's a non-backed enum, or the value for a backed enum.
https://github.com/laravel/framework/blob/da859e7c1d67278d79ad95410c7656e6b4f8e7be/src/Illuminate/Support/helpers.php#L109-L121
Steps To Reproduce:
return view('my-view', [
    'enum' => MyEnum::myValue,
]);

// view
{{ $enum }}

htmlspecialchars(): Argument #1 ($string) must be of type string, MyEnum given

Maybe something like this:
if ($value instanceof \UnitEnum) {
    $value = $value->value ?? $value->name;
}

I guess another option would be to use the Htmlable interface directly in enums.

Heya, thanks for submitting this.
This seems like a feature request or an improvement so I'm converting this to a discussion instead. It's best to post these in the discussions section in the future to get support for your idea. After that you may send a PR to the framework. Please only use the laravel/framework issue tracker to report bugs and issues with the framework.
Thanks!


Used vendored openssl for macosx builds

Travis CI's OSX environment causes the build to dynamically link to<EMAIL_ADDRESS>which isn't installed by default on mac machines. For consistency with the linux binary, we can use the vendored-openssl feature to sidestep this issue, which will eliminate having to install<EMAIL_ADDRESS>for users consuming the release binary. This increases the build size for macos by ~2mb.

i am very happy to merge this so long as we feel confident that the binary produced improves the experience (i expect it will but am not sure!)


Don't multi-target MicroComGenerator.

What does the pull request do?
#6902 changed MicroComGenerator to be multi-targeted which was causing problems building in VS. When building a <ProjectReference> with ReferenceOutputAssembly == false the project was getting built with no target framework, causing:
error MSB4057: The target "GetTargetPath" does not exist in the project.

Instead single-target MicroComGenerator to net6.0 and include the source files directly into _build.csproj (which can't yet be converted to net6.0).

Yeah we can do that, assuming there's no complications.


removed fletcher32

removed flether32 filter for hdf5 files as we do md5checksum separately

Codecov Report

Merging #20 (ca72f4a) into main (bf56e28) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #20   +/-   ##
=======================================
  Coverage   17.19%   17.19%
=======================================
  Files           8        8
  Lines        1064     1064
=======================================
  Hits          183      183
  Misses        881      881

Impacted Files
Coverage Δ

bigplanet/bp_extract.py
45.16% <ø> (ø)

bigplanet/bp_process.py
3.47% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf56e28...ca72f4a. Read the comment docs.


Add methods to deposit/withdraw assets from the protocol

Must use PayableProxy for ETH
Must set allowance for other tokens
Must include option to withdraw all

Fixed in #7


AR_data for custom synthetic data made with Isaac Sim Replicator

Hello,
How can I create AR_data for the json file for custom synthetic dataset so that I can use it for CenterPose evaluator?
Currently, CenterPose evaluator expects AR_data as a field in the json annotation.

@monajalal Hi, do you know how to get AR_data now? I also encountered this problem when training in TAO centerpose.

@monajalal @mujiwob Hi, did you find any solution to get AR_data for the json file? I have encountered the same issue while training in TAO centerpose.

@monajalal @mujiwob Hi, did you find any solution to get AR_data for the json file? I have encountered the same issue while training in TAO centerpose.

No. I found that AR_data is part of the Objectron dataset, but I don't know how to get it in the synthetic dataset by Isaac Sim.
I just commented out the relevant code in centerpose_evaluator.py to skip this part, which made the training go on. However, the inference results after training are not good, I don't know if it is because of the lack of AR_data or my dataset is not good enough.

I have bypassed this problem by assigning all fields in AR_data to 0, and then trained on my dataset of 20k images. finally,  the results were good, so I guess AR_data has no impact on the current training process.

@Jason-xy So I think my poor results are probably due to the dataset. Is your dataset generated by Isaac Sim? If so, could you share the yaml setting files for generating the data and training? Thanks!


print pretty evaluation results

Hi, I make a little improvement on the logging final evaluation results to make it pretty shown in the terminal, like the style of Detectron. A member variable name is added to class COCODataset and PascalVOCDataset respectively to print the dataset name as well.
The difference for an evaluation on a COCO dataset is shown below,

Before:

2019-06-14 16:07:48,853 maskrcnn_benchmark.inference: 63 INFO: OrderedDict([('bbox', OrderedDict([('AP', 0.5359167831416695), ('AP50', 0.8276995117961133), ('AP75', 0.5836435926893688), ('APs', 0.3651809329419521), ('APm', 0.6116254313370
206), ('APl', 0.6981901486909216)])), ('keypoints', OrderedDict([('AP', 0.6421389106709793), ('AP50', 0.862267027540821), ('AP75', 0.696589535122375), ('APm', 0.5861582705697495), ('APl', 0.7319674179840127)]))])
(base)

After:

2019-06-14 16:07:48,853 maskrcnn_benchmark.inference: 63 INFO: Dataset: keypoints_coco_2014_minival
Task: bbox
AP, AP50, AP75, APs, APm, APl
0.5359, 0.8277, 0.5836, 0.3652, 0.6116, 0.6982
Task: keypoints
AP, AP50, AP75, APm, APl
0.6421, 0.8623, 0.6966, 0.5862, 0.7320

Hi @fmassa, adding name attribute to the datasets is just for print the dataset name before the evaluation results like the format in Detectron. It's ok if you think it's unnecessary to add it.
So, how should I do to revert the name and keep the change to the repr?

Hi @fmassa, I've removed name attribute and only keep the change to the repr.


How attach .exe files?

I would like to attach MongoDB files to generated by pkg .exe file. I planning to run it using exec. I added mongo path to package.json:
  "pkg": {
    "assets": "client/**/*",
    **"scripts": "mongo/**/*"**
  }

Unfortunately, after running pkg I got an error:
> Error! Unexpected character '�' (1:2)
  C:\htdocs\[project_name]\dist\mongo\bsondump.exe

So I have questions:

Is it even possible to attach some exe files to my package?
If yes how can I do it?
Is there any different possibility to pack MongoDB app files and generated by pkg exec to one exe file?

Did you try to add the .exe to "assets"?


[Question] Chat Groups for Communication

❓ Question
Dear all,
To facilitate technical exchange and Q&A, we prepare the following chat groups:

QQ Group: 883949936
Slack Group: rlltedevelo-msx2832.slack.com

Feel free to join them!😁😁😁
Checklist

[X] I have checked that there is no similar issue in the repo
[X] I have read the documentation
[X] If code there is, it is minimal and working
[X] If code there is, it is formatted using the markdown code blocks for both code and stack traces.

How can we create a Slack account from rlltedevelo-msx2832.slack.com?

Here is the invitation for the slack workspace:
https://rlltedevelo-msx2832.slack.com/join/shared_invite/zt-27d3ws5b8-facjIISWZwz1QL9DFXRMtg#/shared-invite/email

The current invitation link for the slack workspace is:
https://rlltedevelo-msx2832.slack.com/join/shared_invite/zt-27d3ws5b8-facjIISWZwz1QL9DFXRMtg#/shared-invite/email


Write CHANGELOG

I wrote it! https://github.com/mactkg/vscode-sonic-pi/commit/a993174aadf28f85b46d98512f1d72b1211c60ee


Fix raw type warnings in symbol implementations

Checklist

[x] User relevant changes are recorded in CHANGES.txt
[x] Touched code is covered by tests
[x] Documentation has been updated if necessary
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

actually it is not compiling

actually it is not compiling

pushed a fixup


Update checkpoint tests to use new version 0.26.0

What does this PR do?
daily tests pass: https://github.com/mosaicml/composer/actions/runs/11601544804

What issue(s) does this change relate to?

Before submitting

[ ] Have you read the contributor guidelines?
[ ] Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
[ ] Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
[ ] Did you update any related docs and document your change?
[ ] Did you update any related tests and add any new tests related to your change? (see testing)
[ ] Did you run the tests locally to make sure they pass?
[ ] Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

new daily tests pass: https://github.com/mosaicml/composer/actions/runs/11601544804


SelectionGroup labels should wrap around the inputs

If we can update the markup so that the label wraps around the input rather than being a sibling we would be able to use Bootstrap default styles and be able to remove the "for" and "aria-describedby" selectors.

Pointers how to fix this: Install the http://github.com/silverstripe/silverstripe-frameworktest module, run dev/build, then open the newly created "BasicFieldsTest" page. There's a SelectionGroup at the bottom of the "Option" tab in the CMS. It's rendered by the SelectionGroup.ss template in silverstripe-admin/themes/cms-forms (NOT the main one in framework)

This is assigned to Jess.


[Question] In gltfloading, how do I control the initial placement?

I have written a gltf loader function based on this example and the model loads without an error. However, my camera position and scene are naturally different. How would I best go about controlling initial translation, rotation, and scale like I would for an obj file?

I figured it out. If anyone else happens along later, apply your translate, rotate, and scale values using glm to nodeMatrix in drawNode.

Can you elaborate? What do you want to achieve? In my glTF PBR sample e.g. I simply calculate a bounding box of the glTF scene and then center and scale the scene according to that. Other (more recent) glTF models even contain camera positions that could be used for initial setup.

I have a class that manages the loading and placement of a glTF asset. The placement includes a translation, rotation, and scale value. This class manages the descriptor sets needed for the glTF asset and a render pipeline. There is an update method where the placement can be updated (and update UBOs, etc.) given camera position and lights, and a method to render the glTF asset. Both are given frame into, including a command buffer. The render pass, swap chain, and camera are managed outside the class.
I had trouble getting this to work for your pbr example, so I decided to try a simpler case first. I can load the loading sample glTF file but it come in upside down and small. I can't seem to figure out how to properly translate, rotate, and scale it. I tried applying these values in draw and drawNode, but though I can rotate it to the correct orientation, the components are no longer positioned properly.
On the Vulkan Discord channel, it was suggested that these would best be applied for the pbr sample in Model::LoadNode here:
		// Generate local node matrix
		glm::vec3 translation = glm::vec3(0.0f);
		if (node.translation.size() == 3) {
			translation = glm::make_vec3(node.translation.data());
			newNode->translation = translation;
		}
		glm::mat4 rotation = glm::mat4(1.0f);
		if (node.rotation.size() == 4) {
			glm::quat q = glm::make_quat(node.rotation.data());
			newNode->rotation = glm::mat4(q);
		}
		glm::vec3 scale = glm::vec3(1.0f);
		if (node.scale.size() == 3) {
			scale = glm::make_vec3(node.scale.data());
			newNode->scale = scale;
		}
		if (node.matrix.size() == 16) {
			newNode->matrix = glm::make_mat4x4(node.matrix.data());
		};

However, I'm not to that point yet with the pbr sample. The damaged helmet appears to load small in the scene, but the frame rendering freezes and then it crashes. Here is the console output in the debugger:
Window's framebuffer is currently transparent.
available extensions:
	VK_KHR_device_group_creation
	VK_KHR_external_fence_capabilities
	VK_KHR_external_memory_capabilities
	VK_KHR_external_semaphore_capabilities
	VK_KHR_get_physical_device_properties2
	VK_KHR_get_surface_capabilities2
	VK_KHR_surface
	VK_EXT_debug_report
	VK_EXT_debug_utils
	VK_EXT_metal_surface
	VK_EXT_swapchain_colorspace
	VK_MVK_macos_surface
	VK_KHR_portability_enumeration
required extensions:
	VK_KHR_surface
	VK_EXT_metal_surface
	VK_EXT_debug_utils
	VK_KHR_portability_enumeration
	VK_KHR_get_physical_device_properties2
Device count: 2
physical device: AMD Radeon Pro 5500M
Present mode: V-Sync
Swap chain image format = 50
2022-07-22 09:17:25.639095-0500 bare-metal[72533:1551688] [plugin] AddInstanceForFactory: No factory registered for id <CFUUID 0x600000eac120> F8BB1C28-BAE8-11D6-9C31-00039315CD46
2022-07-22 09:17:25.774183-0500 bare-metal[72533:1551688] [plugin] AddInstanceForFactory: No factory registered for id <CFUUID 0x600000ea8d20> 30010C1C-93BF-11D8-8B5B-000A95AF9C6A
Monitor: (1280, 720)
Model at models/smooth_vase.obj contains 5545 vertices.
Model at models/flat_vase.obj contains 23894 vertices.
Model at models/quad.obj contains 4 vertices.
Device's maxPushConstantsSize = 4096
Loading scene from ../scenes/glTF/DamagedHelmet/glTF-Embedded/DamagedHelmet.gltf
validation layer: Validation Error: [ VUID-VkSamplerCreateInfo-magFilter-parameter ] Object 0: handle = 0x7fa23083b218, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x260626f8 | vkCreateSampler: value of pCreateInfo->magFilter (32759) does not fall within the begin..end range of the core VkFilter enumeration tokens and is not an extension added token. The Vulkan spec states: magFilter must be a valid VkFilter value (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/mac/1.3-extensions/vkspec.html#VUID-VkSamplerCreateInfo-magFilter-parameter)
validation layer: Validation Error: [ VUID-VkSamplerCreateInfo-minFilter-parameter ] Object 0: handle = 0x7fa23083b218, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x41aef78b | vkCreateSampler: value of pCreateInfo->minFilter (32759) does not fall within the begin..end range of the core VkFilter enumeration tokens and is not an extension added token. The Vulkan spec states: minFilter must be a valid VkFilter value (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/mac/1.3-extensions/vkspec.html#VUID-VkSamplerCreateInfo-minFilter-parameter)
validation layer: Validation Error: [ VUID-VkSamplerCreateInfo-magFilter-parameter ] Object 0: handle = 0x7fa23083b218, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x260626f8 | vkCreateSampler: value of pCreateInfo->magFilter (32759) does not fall within the begin..end range of the core VkFilter enumeration tokens and is not an extension added token. The Vulkan spec states: magFilter must be a valid VkFilter value (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/mac/1.3-extensions/vkspec.html#VUID-VkSamplerCreateInfo-magFilter-parameter)
validation layer: Validation Error: [ VUID-VkSamplerCreateInfo-minFilter-parameter ] Object 0: handle = 0x7fa23083b218, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x41aef78b | vkCreateSampler: value of pCreateInfo->minFilter (32759) does not fall within the begin..end range of the core VkFilter enumeration tokens and is not an extension added token. The Vulkan spec states: minFilter must be a valid VkFilter value (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/mac/1.3-extensions/vkspec.html#VUID-VkSamplerCreateInfo-minFilter-parameter)
validation layer: Validation Error: [ VUID-VkSamplerCreateInfo-magFilter-parameter ] Object 0: handle = 0x7fa23083b218, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x260626f8 | vkCreateSampler: value of pCreateInfo->magFilter (32759) does not fall within the begin..end range of the core VkFilter enumeration tokens and is not an extension added token. The Vulkan spec states: magFilter must be a valid VkFilter value (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/mac/1.3-extensions/vkspec.html#VUID-VkSamplerCreateInfo-magFilter-parameter)
validation layer: Validation Error: [ VUID-VkSamplerCreateInfo-minFilter-parameter ] Object 0: handle = 0x7fa23083b218, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x41aef78b | vkCreateSampler: value of pCreateInfo->minFilter (32759) does not fall within the begin..end range of the core VkFilter enumeration tokens and is not an extension added token. The Vulkan spec states: minFilter must be a valid VkFilter value (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/mac/1.3-extensions/vkspec.html#VUID-VkSamplerCreateInfo-minFilter-parameter)
validation layer: Validation Error: [ VUID-VkSamplerCreateInfo-magFilter-parameter ] Object 0: handle = 0x7fa23083b218, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x260626f8 | vkCreateSampler: value of pCreateInfo->magFilter (32759) does not fall within the begin..end range of the core VkFilter enumeration tokens and is not an extension added token. The Vulkan spec states: magFilter must be a valid VkFilter value (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/mac/1.3-extensions/vkspec.html#VUID-VkSamplerCreateInfo-magFilter-parameter)
validation layer: Validation Error: [ VUID-VkSamplerCreateInfo-minFilter-parameter ] Object 0: handle = 0x7fa23083b218, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x41aef78b | vkCreateSampler: value of pCreateInfo->minFilter (32759) does not fall within the begin..end range of the core VkFilter enumeration tokens and is not an extension added token. The Vulkan spec states: minFilter must be a valid VkFilter value (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/mac/1.3-extensions/vkspec.html#VUID-VkSamplerCreateInfo-minFilter-parameter)
validation layer: Validation Error: [ VUID-VkSamplerCreateInfo-magFilter-parameter ] Object 0: handle = 0x7fa23083b218, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x260626f8 | vkCreateSampler: value of pCreateInfo->magFilter (32759) does not fall within the begin..end range of the core VkFilter enumeration tokens and is not an extension added token. The Vulkan spec states: magFilter must be a valid VkFilter value (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/mac/1.3-extensions/vkspec.html#VUID-VkSamplerCreateInfo-magFilter-parameter)
validation layer: Validation Error: [ VUID-VkSamplerCreateInfo-minFilter-parameter ] Object 0: handle = 0x7fa23083b218, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x41aef78b | vkCreateSampler: value of pCreateInfo->minFilter (32759) does not fall within the begin..end range of the core VkFilter enumeration tokens and is not an extension added token. The Vulkan spec states: minFilter must be a valid VkFilter value (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/mac/1.3-extensions/vkspec.html#VUID-VkSamplerCreateInfo-minFilter-parameter)
Loading took 7102.728409 ms
Loading environment from ../scenes/environments/papermill.ktx
Generating cube map with 7 mip levels took 187.605405 ms
Generating cube map with 10 mip levels took 57.156416 ms
Generating BRDF LUT took 19.695214 ms
Generating cube map with 7 mip levels took 187.702262 ms
Generating cube map with 10 mip levels took 55.119632 ms
validation layer: Validation Error: [ UNASSIGNED-CoreValidation-Shader-InconsistentSpirv ] Object 0: handle = 0x7fa23083b218, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x6bbb14 | SPIR-V module not valid: [VUID-StandaloneSpirv-DescriptorSet-06491] DescriptorSet decoration on target <id> '152[%inUVW]' must be in the StorageBuffer, Uniform, or UniformConstant storage class
  OpDecorate %inUVW DescriptorSet 0

validation layer: Validation Performance Warning: [ UNASSIGNED-CoreValidation-Shader-OutputNotConsumed ] Object 0: handle = 0xbe01bb0000000206, type = VK_OBJECT_TYPE_SHADER_MODULE; | MessageID = 0x609a13b | Vertex attribute at location 3 not consumed by vertex shader
validation layer: Validation Performance Warning: [ UNASSIGNED-CoreValidation-Shader-OutputNotConsumed ] Object 0: handle = 0xbe01bb0000000206, type = VK_OBJECT_TYPE_SHADER_MODULE; | MessageID = 0x609a13b | Vertex attribute at location 4 not consumed by vertex shader
validation layer: Validation Performance Warning: [ UNASSIGNED-CoreValidation-Shader-OutputNotConsumed ] Object 0: handle = 0xbe01bb0000000206, type = VK_OBJECT_TYPE_SHADER_MODULE; | MessageID = 0x609a13b | Vertex attribute at location 5 not consumed by vertex shader
validation layer: Validation Performance Warning: [ UNASSIGNED-CoreValidation-Shader-OutputNotConsumed ] Object 0: handle = 0xbe01bb0000000206, type = VK_OBJECT_TYPE_SHADER_MODULE; | MessageID = 0x609a13b | Vertex attribute at location 6 not consumed by vertex shader
validation layer: Validation Error: [ VUID-vkCmdDrawIndexed-None-02697 ] Object 0: handle = 0x2894590000000072, type = VK_OBJECT_TYPE_PIPELINE; Object 1: handle = 0x2d93ac000000006f, type = VK_OBJECT_TYPE_PIPELINE_LAYOUT; Object 2: handle = 0x3955880000000205, type = VK_OBJECT_TYPE_PIPELINE_LAYOUT; | MessageID = 0x9888fef3 | vkCmdDrawIndexed(): VkPipeline 0x2894590000000072[] defined with VkPipelineLayout 0x2d93ac000000006f[] is not compatible for maximum set statically used 0 with bound descriptor sets, last bound with VkPipelineLayout 0x3955880000000205[] The Vulkan spec states: For each set n that is statically used by the VkPipeline bound to the pipeline bind point used by this command, a descriptor set must have been bound to n at the same pipeline bind point, with a VkPipelineLayout that is compatible for set n, with the VkPipelineLayout used to create the current VkPipeline, as described in Pipeline Layout Compatibility (https://vulkan.lunarg.com/doc/view/<IP_ADDRESS>/mac/1.3-extensions/vkspec.html#VUID-vkCmdDrawIndexed-None-02697)
validation layer: Validation Error: [ UNASSIGNED-CoreValidation-DrawState-PipelineLayoutsIncompatible ] Object 0: handle = 0xada3b000000001fd, type = VK_OBJECT_TYPE_DESCRIPTOR_SET; Object 1: handle = 0x2d93ac000000006f, type = VK_OBJECT_TYPE_PIPELINE_LAYOUT; | MessageID = 0x33073516 | vkCmdDrawIndexed(): VkDescriptorSet 0xada3b000000001fd[] bound as set #0 is not compatible with overlapping VkPipelineLayout 0x2d93ac000000006f[] due to: VkDescriptorSetLayout 0x5684940000000068[] from pipeline layout has 4 total descriptors, but VkDescriptorSetLayout 0xe79ae00000001fb[], which is bound, has 5 total descriptors.

Process finished with exit code 9


(WIP) Type Declaration for Header plugin

Created tsconfig.ts , header.d.ts and index.ts
Added types section in package.json

Because of using Vite, your d.ts file might be missed after compiling. There is a plugin that can copy declaration files to the dist folder.

Please, update eslint config to use codex/ts

Resolved by #108


use in query instead of several or

@hajoeichler @emmenko please review

So, you remove the sortBySku in this case and we are back to sortById.
Does sort have any impact here on performance?

I've tested both (sort by SKU and sort by ID) and have not seen any difference.


Excess electricity chart does not display losses of underground pumped storage

Closed with https://github.com/quintel/etsource/commit/1b48892e23dae9ef208ff726ec1ce3fb5807a27a


about delete clause

Can Mapd support delete one table from another table , like :
delete from table1 , table2 where table1.field1 = table2.field1 and table1.field2 = table2.field2 ?

+1
Sent with GitHawk


textNode in rangy selection contains self-referencing previousSibling in safari

See screenshot below.

Looks like this happens in the native getSelection() method in safari.

This is a very annoying bug in safari. In the end I mitigated the problem by finding the index using the textContent of the textNode and its parent. This is not perfect though.

Bizarre. I've seen bugs like that in IE before but not Safari.
How do I reproduce the bug?

Hi @timdown
In my app, you can reproduce by:

make a list item,
then make a new one after,
at the beginning of the second item, back space, to merge the second one into the first one
press enter, to make the second one a new list item again
press Tab at the beginning of the second item, the selection triggered during keydown of the tab is going to lead to this error.

If you then do
console.log(  window.document.querySelector('li:nth-child(2)') )

and look at the result, in the console it shows multiple copies of the textNode with the same content as the original textNode of the second li, but the view shows only one.
At the same time, if you print out the textContent, it is correct.
Best,
Ge


Define the game's narrative progression

[ ] #49

The narrative progression was defined in the "Progresión de narrativa" section of our GDD.
GDD: https://docs.google.com/document/d/1iHbk6SjNvEBSYVCmc0KMylksYg6bwNcP/edit#heading=h.6peewwbjdj1d


Make RollbarFilter dependency-injectable for rollbar-web

One of our users is programmatically constructing information usually contained in web.xml. In the proccess, they are initializing the Rollbar object before creating the RollbarFilter object. They want to be able to pass their already initialized Rollbar object to RollbarFilter.
Currently, this is functionality is only available inside com.rollbar.web.filter namespace due to the private constructor. We need to change the private constructor to publish to expose this functionality.

thanks for the exceptional, prompt attention, @ArturMoczulski!


Runtime error is raised when iterating tree in Python3.7

This error occurs in function iter_slice(self, slice: slice) -> Iterator[Record].
Since python 3.5, when StopIteration is raised inside a generator, it is replaced with RuntimeError. The alternative is return. (See in https://www.python.org/dev/peps/pep-0479/)
I have verified this change.

Hi, makes sense. Would you mind sending a PR?

I have just checked the code in github, it is already fixed 3 years ago by you. But it is not fixed in the pip package(version 0.0.3).

Right, I should make a release to PyPI.


Handle situation when not get first ROS messages OR stop getting message

If we run the code, but don't give a MOCK wind sensor, then it will still run, but it will keep thinking it is going downwind, and then regenerate a new path, frantically turning. We should properly handle not getting our first sensor data point AND for losing sensor connection.
Can be re-created by running:
roscore
then
rosrun local_pathfinding main_loop.py
then
rosrun local_pathfinding MOCK_global_planner.py
then
rosrun local_pathfinding MOCK_controlller_and_boat.py

@haakov 's idea: have method in Sailbot class like def hasReceivedAllMessages() -> bool. Call this from main_loop.py before starting

@haakov 's idea: have method in Sailbot class like def hasReceivedAllMessages() -> bool. Call this from main_loop.py before starting

To test, instead of running roslaunch local_pathfinding all.launch

rosrun local_pathfindng main_loop.py
will say "waiting for first global path" waiting for first gps
rosrun local_pathfinding MOCK_global_planner.py rosrun local_pathfinding MOCK_controller.py
Check that main loop doesn't run, add some warns or something

To test, instead of running roslaunch local_pathfinding all.launch

rosrun local_pathfindng main_loop.py
will say "waiting for first global path" waiting for first gps
rosrun local_pathfinding MOCK_global_planner.py rosrun local_pathfinding MOCK_controller.py
Check that main loop doesn't run, add some warns or something


Document Optimistic Roots OffChain Infra

Problem
Document the architecture, message flow, and contract interactions of off-chain infra.
Impact
Help with audit. Serves as a reference for how off-chain infra will interact with the contract changes
Proposed Solution
Gather finalized core logic and describe the mechanics, extend existing tech spec, and add a visual the provides a full view
Acceptance Criteria

[ ] Document that is public
[ ] Message flow diagram

Syncing with @LayneHaber to figure out what docs are needed here.

Found out what is needed, will add to Notion docs.

Documented offchain docs and hand off to @LayneHaber.

Provided the needed input to audit.
https://www.notion.so/connext/Messaging-Layer-Audit-Scope-826b9ac2d43d47bf9f46bb4145aa6527?pvs=4#4c238bb58d6844c6a5b4e65171aa7e6f


Property naming of HttpContext is inconsistent across View and Controller

In a Controller, the HttpContext is accessed through the HttpContext property, but in a view it is accessed through Context. This seems a little inconsistent. It's not too bad since IntelliSense makes it pretty clear.
Certainly doesn't seem RC2-blocking, but it felt a little odd while I was testing.

We should look at what the naming was in MVC 5.x. I vaguely recall that we kept this naming, inconsistent or not, due to legacy.

I checked and it's the same as MVC 5.x, and we did keep it consistent on purpose.

Sounds like a good enough reason to me :). Thanks for checking!

Well it's a pretty bad reason really, but, you know, because reasons 😄

Maybe we need to add a [PlzJustStopThisIsTheWayItIsBecauseBackCompat] attribute so we can have a tool auto-respond to these kind of issues.

Or we just make the breaking changes now, while we can ;)

+1 for breaking all the things!!! :dancers:
I guess, at this point no one cares about further breaking changes, especially if they can be fixed with search&replace.
Honestly, I'm not sure if I can still deal with a stable API. I'm afraid working with RTM will get really boring. How should I start my day without my build server telling me that stuff broke again?!? :D

You guys already made a breaking change with removing the "Http" prefix from some action results like "HttpBadRequest". The explanation was that the Core 1.0 is a new framework and it is fine. I believe for consistency, this one here can be made "HttpContext" in the views.

@ivaylokenov the distinction we've made on these types of breaking changes is whether an app's code is likely to reference this type by name or not. In the case of Context/HttpContext it's quite often in user's code, so it could be an annoying change. The ActionResult types however appear less frequently in code. Most code uses the "factory" methods on Controller, e.g. return BadRequest(...) as opposed to return new BadRequestResult(...) (or whatever). So the actual type name is normally hidden.

@Eilon I was talking about the factory methods in the controller class too. This was the breaking change and I believe a lot of app's code bases used these:
https://github.com/aspnet/Mvc/commit/75c05be2f71837c1094eb42ad8c283979bbdfbef

@ivaylokenov wow, your memory is far better than mine!

@Eilon Well, I am stalking these repositories like they are my own. I know more than 60% of the code maybe. There is no better place for C# design and performance know-how in my opinion. 👍


Affiliation data format and parsers

Develop a portable data format for storing and transferring information about the affiliations between individuals and organizations
This will be a special case of a more general serializable data format that is both machine- and human- readable (e.g. YAML)
Deliver this format, and tooling for parsing and writing it in Python, as code in BigBang

Is this the same as #352?

What can we pull from the IETF Datatracker? Or from RFCs which list affiliations of authors/editors in the credits? Or from some other data source?
And then drop that into a dataframe or some basic format, so that it can be consumed by other code working on analysis of organizational influence/distribution within working groups.

See #25 for discussion of this.
DataTracker attendance data is a nice source for affilation and nationality data for IETF members.
An actionable way to approach this might be:

Develop the affiliation data format and corresponding object, which tracks individuals, their email addresses (with times/duration), their affiliations (with times/duration), their nationalities (with times/duration) (where duration is inferred from time point data).
Have a script for population such an object from IETF Attendance data as an example of how to do it.
demonstrate how this can be used to plot affiliate interactions in a notebook as per @Christovis 's visualizatiosn from IAB-AID-1

Ultimately, such an object could wrap an ORM with an actual database behind it, and/or work with the entity resolution code to better resolve (its own) organization/affiliation references.


only try color transform if original icc is correct

What is the reason for this change?

I'm working on a making the conformance test work with other decoder, which typically don't write out the iccs.


Removed dead links

Closes #572

@Rick-Anderson If you have time, please check this PR.

@Jadhielv  thanks!


Issues and Suggestions

Some results with issues:
Issue >
CHECK #19: OpenSSL is up to date.... FAILED!
Although I am hitting "Y" it's not getting fixed after re-running the script.
macOS:ch moeirs$ openssl version
OpenSSL 1.0.2k  26 Jan 2017
Suggestion >
CHECK #24: Bluetooth is disabled.... FAILED!
This is shouldn't be part of the check process since many users user bluetooth devices and everyone should be aware that it should be turned off whenever necessary. It could be done by checking if Bluetooth sharing is disabled or not and make sure it doesn't accept sharing automatically.
Suggestion >
CHECK #42: Google DNS servers are used by default on all network interfaces.... FAILED!
Why using Google DNS is recommended? I personally don't think so. As of my experience, Google DNS is pretty slow compared to OpenDNS which is a much faster more secure to use. (Actually it depends on location, Namebench is great to tell) If you want to take it further, default DNS with DNSCrypt installed is way much secure.
Suggestion >
CHECK #99: All Google Chrome web browser profiles block Flash cookies.... FAILED!
Adobe Flash is one of the most insecure platforms out there, and I truly believe that the script should scan and make sure Flash player is not installed on macOS and also, Flash is blocked from the browser itself; manually done via chrome://flags.
Two things to be checked here:

Prefer HTML over Flash --> should be enabled.
Run all Flash content when Flash setting is set to "allow" --> sometimes we whitelist flash websites or forget them allowed when want to access something, so it's better for this option to be disabled, so even whitelisted websites cannot run Flash.

This is can be combined with CHECK #100, blocking/disabling/uninstalling Flash, system wide.
My results are good enough if I exclude GPGSuite and Bluetooth.
CHECK #109: OSX/Keydnap malware is not present.... PASSED!
Configurations passed total:                 97 (88.99%)
Configurations failed or skipped total:      10 (9.17%)
Configurations passed without applying fix:  94 (86.24%)
Configurations passed after applying fix:    3 (2.75%)
Configurations failed and fix failed:        3 (2.75%)
Configurations failed and fix skipped:       0 (0.00%)
Configurations failed and fix declined:      7 (6.42%)
Configuration checks skipped:                0 (0.00%)
Thanks a lot for this amazing creation.
Aside request although it's going to be hard to do but it would be just great to run a specific check. instead of running all of them. This could be unnecessary but it's pretty handy if it can be done.

Thanks for the feedback! Much appreciated.

Although I am hitting "Y" it's not getting fixed after re-running the script.

I need to fix this.

This is shouldn't be part of the check process since many users user bluetooth devices and everyone should be aware that it should be turned off whenever necessary.

Fair point. Unfortunately there's no check for "user turns off Bluetooth when using it," and there are various things that can go wrong when you are using Bluetooth intentionally. For this reason, I believe I set disabling Bluetooth to either "recommended" or "experimental," rather than "required." I'll think about it some more, though.

Why using Google DNS is recommended? I personally don't think so. As of my experience, Google DNS is pretty slow compared to OpenDNS which is a much faster more secure to use.

This is true. Most users are not using any custom DNS, which is generally less secure than using a custom one like Google or OpenDNS. I hoped that users who are savvy enough to use custom DNS infer that this is the intended effect, but I could make this more clear by updating the language at the very least.

I truly believe that the script should scan and make sure Flash player is not installed on macOS and also, Flash is blocked from the browser itself; manually done via chrome://flags.

Thanks for the suggestion -- I'll look into this.

Aside request although it's going to be hard to do but it would be just great to run a specific check. instead of running all of them.

Absolutely. I'm pretty sure I opened an issue for this feature, and plan to implement it.

Not everyone uses Homebrew so maybe there should be a flag disabling the check
I believe recent versions of MacOS now use LibreSSL instead OpenSSL (still shipped) so it's not clear to me if this is still a required check
Is there a way to track and display all the commands successfully executed at the end of a script run so that we can store it later for running on a different machine?
WebGL configured to default to block should be an acceptable setting?
Additional Chrome extensions to test for: HTTPS Everywhere and Privacy Badger
Add check/change for Safari hyperlink auditing. See el1t/uBlock-Safari#36

defaults write com.apple.Safari com.apple.Safari.ContentPageGroupIdentifier.WebKit2HyperlinkAuditingEnabled -bool false

It looks to me like set_openssl_latest_path.sh is not getting called, so on my system it is still finding OpenSSL 0.9.8zh 14 Jan 2016, instead of the version 1.0.2l that is currently available.
And note that 1.0.2l is later than the string the code is looking for, which is 1.0.2h.

I also note that you're checking for the last successful software update, but you're apparently requiring it to be the same day as the script that is running?  Don't you want to convert that date/time string to a ctime integer since the Epoch and then compare that to the current date/time string converted to a ctime, and then require that there be a certain maximum distance that is allowed between these values?
So, if you wanted it to be within the last 24 hours, you could check if the difference is 86400 seconds or less -- assuming there hasn't been a Leap Second inserted today by NTP.

Hmm.  The check for git needs to be updated, too.  I have git version 2.13.6, but the check is for 2.9.3.

Same for curl -- curl 7.54.0 >> 7.50.1, but the test still fails.

Is there a way to disable the Safari checks for plugins being disabled?  Because I have plugins that help me keep my Safari browser secure, and I certainly don't want them being disabled.

For GPG, I don't think we want to try to force EncryptNewEmailsByDefault.  Sign by default, sure.  But encrypt by default?  No.

@kristovatlas -- Do you want me to open separate issues for all the additional things I've found so far, or shall I continue to list them here?
And yes, I'm assuming that I will be sending you PRs for at least most of the things I find.  Unless you don't want PRs, of course.

Your preference. PRs welcome!


Data preprocessing with multi-gpus

Hi LCM teams, thanks for your great work, I am trying to use your prepare_wikipedia script to deal with my own data. Right now, I have a 1 node with 8 gpus, but I found that this pipeline is super slow, and it seems that only this is only using one gpu. Could u help me to figure out how to use multi-gpus and prallel, with this script?

+1


The application templates should be able to use OCI artifacts for helm

If I specify my helm chart in an AppChart using an oci:// link, it fails with this error:
Deploying application ...

❌  error pushing app to server: can't deploy app: Internal Server Error: unable to lookup chart "oci://registry.digitalocean.com/helmtesting/epinio-stateful/epinio-stateful-application:0.1.15", missing registry client

Here's the line generating the error https://github.com/helm/helm/blob/fa6ba5bb29bd7f8bde3a264ea63ff97a4ff0fe5a/pkg/action/install.go#L679

That is in the helm/helm package, i.e. the helm reference implementation. I do not see us fixing that.
Also, you specification is incomplete IMHO. You have two ways of specifying a chart in the AppChart resource.
For one, as a curl-able link. Example:
spec:
  helmChart: https://github.com/epinio/helm-charts/releases/download/epinio-application-0.1.17/epinio-application-0.1.17.tgz

For two, as a combination of repository and chart name (plus version). Example:
spec:
  helmRepo: https://epinio.github.io/helm-charts
  helmChart: epinio-application:0.1.17

Which of these forms did you use, exactly ?
My speculation is:
spec:
  helmRepo: oci://registry.digitalocean.com/helmtesting/epinio-stateful
  helmChart: epinio-stateful-application:0.1.15

or similar. How badly off am I ?

no further replies, closing


Repeating HashTags

Describe the bug
HashTags repeat on double clicking Favourite button
ScreenShot

Would you like to work on the issue?

[ :heavy_check_mark:  ] Yes
[ ] No
Other:

Call removeAllViews() while checking that chipGroup is null or not in EventViewHolder or don't add if child count  >0

just adding removeAllViews() while chipGroup is not null . solves issue.


Add missing dependencies to SimpleContractDisplay

Follow-up of #8958, they have been missed there.
ckan compat add 1.8

Merging now so CKAN users aren't left with a completely broken mod due to missing dependencies.
Didn't do an in-dept review, maybe it could use another tag, but I think we got the most important stuff.


sphinx_autorun: repo not available anywhere

sphinx_autorun is required to build todoman's doc, but no repo seems to be available. It is needed if we want to have a Debian package of it.

Repository: https://gitlab.com/hobarrera/sphinx-autorun
PyPI/packages: https://pypi.python.org/pypi/sphinx-autorun/1.0.0

Repository: https://gitlab.com/hobarrera/sphinx-autorun

I should have mentioned that I already seen this, but that it 404's

Silly, silly me, the repo was private (so the link worked for me). Fixed now.

I can now open https://gitlab.com/hobarrera/sphinx-autorun in a browser, but I can't clone the repo:
$ git clone https://gitlab.com/hobarrera/sphinx-autorun.git
Cloning into 'sphinx-autorun'...
Username for 'https://gitlab.com':

Use git via ssh. I've never used git over https, so I've no idea how to configure that.

? I just want to copy the repo without a gitlab account.
$ git clone http://gitlab.com/hobarrera/sphinx-autorun.git
Cloning into 'sphinx-autorun'...
Username for 'https://gitlab.com': ^C

Doesn't this work?
git clone git@gitlab.com:hobarrera/sphinx-autorun.git

Again, I've never used git+https, so I can't help there at all.

$ git clone git@gitlab.com:hobarrera/sphinx-autorun.git
Cloning into 'sphinx-autorun'...
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

If you don't know how to publish a repo to the public on gitlab, can!t you just clone it to github?

Dah, yeah, looks like switching the repo from private to public is bugged and isn't giving you access.
Here's a mirror: https://github.com/hobarrera/sphinx-autorun

Great, thanks!

If you don't know how to publish a repo to the public on gitlab, can!t you just clone it to github?

Oh, I did make it public, it seems there's a bug and making it public made the page public, but not the repo (LAME!).