Fix bug where the linen Module state is reused.

For example in scan the transform_fn is called twice.
This led to mis counting compact call default names (see test case)

Codecov Report

Merging #2025 (8c6a16b) into main (f7947da) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2025   +/-   ##
=======================================
  Coverage   74.85%   74.86%
=======================================
  Files          59       59
  Lines        5035     5037    +2
=======================================
+ Hits         3769     3771    +2
  Misses       1266     1266

Impacted Files
Coverage Δ

flax/linen/transforms.py
96.62% <100.00%> (+0.02%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7947da...8c6a16b. Read the comment docs.

Hopefully no one depends on wonky default names in checkpoints

You can't depend on it because the behavior changes between init and apply (only init was wrong and apply would fail with param not found)


Add abseil to gRPC Core

This is a test PR to add Abseil to gRPC Core.
Code changes:

Make grpc_core::InlinedVector an alias to absl::InlinedVector
Make grpc_core::Optional an alias to absl::optional

Build pipeline changes:

Support abseil targets (absl/*) on bazel
Support abseil on cmake

abseil-cpp.cmake to add directory path.
Update CmakeLists.txt.template to use abseil-cpp.cmake.

Added GRPC_USE_ABSL flag.
Added abseil filegroups. (# = 98)

gen_build_yaml.py to populate this from abseil BUILD file.

Support wrapped language.

PHP
Cocoapod (Resolve abseil path, Suppress warning on abseil)
Python: Added abseil path,  Workaround manylinux1 problem.

Change test scripts not to remove abseil.

grpc_build_artifacts_multiplatform

Thanks, Nico!


[BUG] flickr30k only shows 1 caption instead of all 5 captions

Hi when trying out deeplake on loading the flickr30k dataset, it seems like only 1 of the 5 captions is returned by the dataset object. Here is the minimal code to reproduce the bug:
import deeplake
ds = deeplake.load('hub://activeloop/flickr30k', )
ds[0].texts.data()

// {'value': ' A young adult in the middle of a road waving flags of red , white , and black .'}

Any I missing out any step?

Hi @jh8011nyu. Thank you for reporting the issue. I don't believe you're doing anything wrong. It looks like the dataset was not uploaded properly. We'll re-upload it and will let you know when that's done.

Hi @jh8011nyu The dataset has been re-uploaded with all the captions. Thank you for pointing our this issue.

thanks for the quick fix!


fix: remove whitespace

Force to push BE + FE to PROD

:tada: This PR is included in version 0.27.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


node: --experimental-loader requires --experimental-modules be enabled

<EMAIL_ADDRESS>start G:\php_dnmp\www\wechaty-puppet-xp

cross-env NODE_OPTIONS="--no-warnings --loader=ts-node/esm" node examples/ding-dong-bot.ts

node: --experimental-loader requires --experimental-modules be enabled
npm ERR! code ELIFECYCLE
npm ERR! errno 9
npm ERR<EMAIL_ADDRESS>start: cross-env NODE_OPTIONS="--no-warnings --loader=ts-node/esm" node examples/ding-dong-bot.ts
npm ERR! Exit status 9
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

Try to install the latest version
npm install wehaty-puppet-xp@next

Sorry,The correct instruction is:
npm install wechaty-puppet-xp@next

It seems that your Node.js version is below 14.
Please upgrade Node.js to 16 to fix your issue.
Link to

https://github.com/wechaty/wechaty.js.org/issues/1295

Error: Could not locate the binding file. Tried: node_modules/frida/build/frida_binding.node
Easy solution: use a server outside of China to get an unblocked network connection.
Hard solution: download frida_binding.node from https://github.com/frida/frida/releases/ manually, then put it into node_modules/frida/build folder.
Explanation:

frida is using prebuild-install to install binary files from GitHub Release.
If your server has any trouble with visiting the Amazon S3 servers (which is all the GitHub release artifacts are hosted on), then your NPM install will fail to download the binary files (frida_binding.node in our case).
@Lny-nice Look at the content above, it will help

如果微信多开了会咋样


Added optional delimiter for ls command

This features allows to optionally pass an additional parameter for the command ls, specifying a delimiter to be used when printing on the standard output the files stored on the micro:bit. This feature is optional, meaning that it won't affect the current behavior of the software when a delimiter is not specified (i.e. it is back-compatible and should not break any code that depends on the current behavior of microfs).
The issue
In the current version of microfs, the files stored on the micro:bit are listed separated by a whitespace (' ') delimiter. This is problematic/confusing if a user uploads on the micro:bit files that have a white space in the name itself. For example, if a user upload (i.e. with put) the files main.py and my file.py, the command python microfs ls  prints on the console main.py my file.py. This behavior can lead to confusion (e.g., it looks like there are three files on the file system) and makes difficult to create automation tools that rely on correctly listing the files.
The solution
To solve this problem we can introduce an optional parameter following the ls command. If not specified, white space (' ') is chosen as default, leaving the behavior of microfs as in the current version. Alternatively the user can input a string delimiter. Following the example above, we could run now the command python microfs ls , and the output would be main.py,my file.py - which is less ambiguous than the output shown before.
Example usage
Assuming the files A, B, and C stored on the micro:bit
python microfs ls => A B C
python microfs ls ' ' => same as above => A B C
python microfs ls , => A,B,C
python microfs ls ',' => A,B,C
python microfs ls ';' => A;B;C

My apologies, I should have checked better. One last-minute change introduced a bug. For the time being I close this request. I am happy to re-open another one with the bug fixed.

Hi @makinteract - thank you for your engagement and no problem at all..! Always happy to receive contributions. :slightly_smiling_face:


Update CL - BTE to include updated disclosure -extractor

Add support for multiple architecture.
Update disclosure extractor

I'm only browsing and not sure if you wanted my review, but LGTM at a skim.

What's the story here?

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Handle the edge case where you slice 0

[-0:] is the same as [0:], and radically different for how, e.g. [-1:] vs [1:] works. Derp.
Solves the issue of the entire display getting closed down when you (sometimes) turn off the node representation widget.
Closes the last part of #189

Run pip check
pyiron-base 0.5.36 has requirement sqlalchemy>=2.0.9, but you have sqlalchemy 1.4.46.
Error: Process completed with exit code 1.

I forgot to un-pin sqlalchemy in the pyiron_ontology conda env file, so I need to go bump that and bump my dependency here too.


Saving tiles with the ROI index

Feature

Saving tiles with the ROI index
Pitch

When we save tiles in a loose fashion as jpg or png give an option to save tiles with the ROI index or append whatever is in the column 'roi_name'.
Alternatives

Additional context

I am trying to train a model with tile level labels.

Thanks! This is definitely something we can do.
As a heads up - Slideflow does have some experimental functionality for training models using tile-level labels supplied via an arbitrary pandas dataframe, although this feature is not yet complete. Our goal is to eventually provide users with the ability to train models with arbitrary tile-level labels or labels inferred from regions of interest.
Implementing what you suggest would be a good temporary measure. I'll add it to our version 2.2 feature list.

Just wanted to provide a quick update: we've finished the backend work needed for this and anticipate this feature will be included in version 2.2 (next 1-2 weeks). I'll update this issue once the feature is released.

Ok - we've built out a ton of functionality in the 2.2.0 release to support tile-level labels! In fact, Slideflow now has a full, end-to-end strongly supervised training platform. This section of the docs should get you started.
To summarize:

You can now add labels to ROIs. Studio makes this easy (see here)
You can export ROI labels for an entire dataset using Dataset.get_tile_dataframe() (see here), which will yield a dataframe like this:

>>> df = dataset.get_tile_dataframe()
>>> df.head()
                loc_x  loc_y  grid_x  grid_y roi_name roi_desc label    slide
slide1-608-608  608    608    0       0      ROI_0    None     tumor    slide1
slide1-608-864  608    864    0       1      ROI_0    None     tumor    slide1
slide1-608-1120 608    1120   0       2      ROI_0    None     tumor    slide1
...

You can use these labels to train a strongly-supervised model (see here)

Let me know if you have any feedback or encounter any issues!


[stable/metabase] allow setting jetty options

Signed-off-by: Kash Law<EMAIL_ADDRESS>
What this PR does / why we need it:
This PR allows users to set jetty variables. In our case, we want to set the MaxThreads value.
Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/ok-to-test

/approve
/lgtm

Thanks for your contribution 👍


Update gvisor-tap service by using nmcli and binary from container image

This patch do following

Create a tap device using nmcli with a hard coded mac address, this mac address is mapped in the crc daemon lease which provide <IP_ADDRESS> IP address to the VM.
copy the vm binary from container image and put it to /usr/local/bin
modify gvisor-tap-vsock service to use the vm binary instead running the container using podman

https://github.com/containers/gvisor-tap-vsock/pull/202 is exploring something similar.

I've done some work on this in https://github.com/cfergeau/snc/tree/gvisor_service
However for testing I used the podman branch and https://github.com/cfergeau/snc/tree/podman-gvisor-service , which worked fine. I'll have to test the openshift changes ^^


Installation error - prisma

I am trying to run chainlit inside a container build with the following Dockerfile
FROM python:3.11-slim-buster
WORKDIR /app

RUN apt-get update && \
    apt-get install nodejs -y && \
    apt-get clean

COPY requirements.txt /app
#RUN  pip install --upgrade pip
RUN  pip install -r requirements.txt

COPY . /app

RUN prisma generate
ENV HOST=<IP_ADDRESS>
ENV LISTEN_PORT 8000
EXPOSE 8000
CMD ["/bin/bash", "launch_scripts/chainlit_app_custom.sh"]

When I try to run it I get the following error:
chat_ui-chat_ui-1  | 2023-06-29 09:03:53 - Loaded .env file
chat_ui-chat_ui-1  | 2023-06-29 09:03:54 - Your app is available at http://localhost:8000
chat_ui-chat_ui-1  | ERROR:    Traceback (most recent call last):
chat_ui-chat_ui-1  |   File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 677, in lifespan
chat_ui-chat_ui-1  |     async with self.lifespan_context(app) as maybe_state:
chat_ui-chat_ui-1  |   File "/usr/local/lib/python3.11/contextlib.py", line 204, in __aenter__
chat_ui-chat_ui-1  |     return await anext(self.gen)
chat_ui-chat_ui-1  |            ^^^^^^^^^^^^^^^^^^^^^
chat_ui-chat_ui-1  |   File "/usr/local/lib/python3.11/site-packages/chainlit/server.py", line 65, in lifespan
chat_ui-chat_ui-1  |     from prisma import Client, register
chat_ui-chat_ui-1  |   File "<frozen importlib._bootstrap>", line 1229, in _handle_fromlist
chat_ui-chat_ui-1  |   File "/usr/local/lib/python3.11/site-packages/prisma/__init__.py", line 45, in __getattr__
chat_ui-chat_ui-1  |     raise RuntimeError(
chat_ui-chat_ui-1  | RuntimeError: The Client hasn't been generated yet, you must run `prisma generate` before you can use the client.
chat_ui-chat_ui-1  | See https://prisma-client-py.readthedocs.io/en/stable/reference/troubleshooting/#client-has-not-been-generated-yet
chat_ui-chat_ui-1  |
chat_ui-chat_ui-1  | ERROR:    Application startup failed. Exiting.

I thought it was an error in my application and used prisma generate as explained in the error, but it still did not work.
So I went back to the basics:
pip install chainlit==0.4.2 --force-reinstall
chainlit hello

And still got the same error:
ERROR:    Traceback (most recent call last):
  File "/usr/local/lib/python3.11/site-packages/starlette/routing.py", line 677, in lifespan
    async with self.lifespan_context(app) as maybe_state:
  File "/usr/local/lib/python3.11/contextlib.py", line 204, in __aenter__
    return await anext(self.gen)
           ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/chainlit/server.py", line 65, in lifespan
    from prisma import Client, register
  File "<frozen importlib._bootstrap>", line 1229, in _handle_fromlist
  File "/usr/local/lib/python3.11/site-packages/prisma/__init__.py", line 45, in __getattr__
    raise RuntimeError(
RuntimeError: The Client hasn't been generated yet, you must run `prisma generate` before you can use the client.
See https://prisma-client-py.readthedocs.io/en/stable/reference/troubleshooting/#client-has-not-been-generated-yet

ERROR:    Application startup failed. Exiting.

Any ideas of what may be happening?

Hey the generate command is supposed to be handled by Chainlit. Can I see your chainlit run ... command and your .chainlit/config.toml? Also is there already a chat.db file in your .chainlit folder?


Update callbacks.py corrected term names in doc

In reference to the issue #34965
Corrected the "accuracy" and "val_accuracy" terms as returned by the callback (history object) instead of the short documented versions acc/val_acc .

@googlebot I signed it!

@Jaskaran170599 Can you please resolve conflicts? Thanks!

@gbaned conflicts resolved , please review.

Closing outdated PR, sorry that we weren't able to review it in time.


[ROCM] Adjust run_cpu.sh to match pycpp config in cpu.bazelrc

This likely will result in overall less tests, but it's perhaps more appropriate.
It also matches the current config in: https://github.com/ROCmSoftwarePlatform/tensorflow-upstream/blob/develop-upstream/tensorflow/tools/tf_sig_build_dockerfiles/devel.usertools/cpu.bazelrc
which is used upstream

retest cpu-pycpp please

retest Ubuntu-GPU-single please


Engage Hashicorp for Terraform Cloud Business

Describe the issue
We tried to procure Terraform Cloud earlier but the people we were dealing with left and the licensing model they had proposed was not well thought out.  We were intending to fix that and then everyone left Hashicorp.
Hashicorp Terraform has launched a new Terraform Cloud offering called Cloud Business
Hashicorp presented this to us several weeks ago but at the time the cost structure was in a preliminary form that didn't fit our needs.
We want to check the cost structure of Terraform Cloud Business because if it will end up being within the same range of our current cost footprint for Terraform Cloud, the features of Terraform Cloud Business have some appeal to facilitating the management of Terraform code org wide.
Which Sprint Goal is this issue related to?

Note: 'Milestone' is a ZenHub term that we use synonymously with 'Sprint'.

The 'Milestone' description (created in ZenHub) should clearly list Sprint Goals. This section should indicate which 'goal' this issue is related to.
Additional context

If this does not work out, we may consider cloud hosted terraform enterprise that we manage.
Product brief

Definition of done

Reconnect with TF (PO has latest contact info)
Escalate to high level (person who sets pricing at Terraform)
Explain that we want an Enterprise model that aligns win win growth incentives for both CPF and TF.
Confirmation that the cost structure is the same as what was shown to us before, or if not
A brief synopsis of how much it would cost us under the new cost structure vs what value we would get

Sent email to initiate engagement to Stefania on 09-14-21.

Warren/Audra met with Blair Schmulach and Sam Gabrail to focus on our business needs. The Business Tier looks to be a better fit and provides the features we need. Next steps are for Hashicorp to provide a few options for pricing for our consideration (next week).


RBAC: Implement a default role

Issue submitter TODO list

[X] I've searched for an already existing issues here
[X] I'm running a supported version of the application which is listed here and the feature is not present there

Is your proposal related to a problem?
If the UI have RBAC role defined and a user come with an identity that doesn't belong to any of this roles then the UI display nothing (like no cluster found)
Describe the feature you're interested in
A way to solve that would be to define a default role in the RBAC config of the Kafka-ui. In my mind it would be a Read only role by default, but user could want something else. So just been able to define a role by default with a list of permissions would be the best option I think.
Describe alternatives you've considered
No response
Version you're running
custom build 3740
Additional context
No response

A good idea from #4105: use regexp for role matching?
subjects:
   - provider: oauth
      type: role
      value: ".*"

same here ... wondering if there's a time frame for this enhancement...

@sankhyan @githubwalvarado this repo is not maintained (#4255), see https://github.com/kafbat/kafka-ui and https://github.com/kafbat/kafka-ui/issues/344

Thanks @Haarolean ! Apologies! Will bug you on that repo then :D


Script to export all descriptors from a 3D reconstruction

The goal is to collect descriptors from successful reconstructions in order to use them to build a voctree using only meaningful descriptors.

You can read the code from SfM_Localization_Single_3DTrackObservation_Database in order to see the way I have used to parse all the descriptor that relates the current reconstruction.

Thx for the tip!


Add schema for book and label classes

Changes I have made in this PR:

Create schema file for Label and Book classes

STATUS: APPROVE :heavy_check_mark: :heavy_check_mark:  :champagne:
Hi @benardop
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉 :clap: :clap: :100:

To highlight :champagne:

All linters are passing :heavy_check_mark:
Good commit history :heavy_check_mark:
Good PR description :heavy_check_mark:

Optional suggestions
Recommendations with the [OPTIONAL] prefix and won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application._
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please ping me @shaqdeff   when you comment so I can receive the notification or use slack with the same name.


Wrong nameserver values

Describe the bug
Domain logist.it nameservers return wrong values.
To Reproduce
Steps to reproduce the behavior:
>>> whois.query('logist.it').name_servers
['e', 'ns1.nss.ee', 'ns2.nss']

Expected behavior
Nameservers should have values "ns1.nss.ee" and "ns2.nss.ee".
Version:
Whois version 0.9.18

fixed in https://github.com/DannyCork/python-whois/pull/250


dendron-cli doesn't include latest migrationVersion (0.83.0 / 0.84.0)

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

[ ] Workspace.  VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
[ ] Lookup.  Dendron's Lookup Command
[ ] Views.  Dendron Preview, Tree View, Side Panels in the UI
[ ] Schema.  Dendron Schemas
[ ] Pod.  Data import from / export to Dendron
[ ] Publish.  External Site Publish
[ ] Markdown.  Markdown features, such as syntax support and features

Describe the bug
The latest dendron-cli should provide a path to migrate to the latest dendron.yml config (version: 5 from either 0.83.0 or 0.84.0). It currently does not. I think these releases have provided new preview: and publishing: config sections.
To Reproduce
Steps to reproduce the behavior:

Install latest dendron-cli
Run npx dendron dev show_migrations
See that some migration versions have been removed, and also that latest migration versions are not included

18:33 $ npx dendron --version
0.84.0
18:33 $ npx dendron dev show_migrations
======Available Migrations======

Make note of the version number and use it in the run_migration command

e.g.)
> dendron dev run_migration --migrationVersion=0.64.1

---------------------------------------------
version          | description
---------------------------------------------
0.55.2           | migrate note lookup config
0.51.4           | migrate scratch config
0.47.1           | migrate journal config
0.46.0           | update cache
---------------------------------------------

run_migration also doesn't have other available options ([choices: "0.55.2", "0.51.4", "0.47.1", "0.46.0"]):
19:00 $ npx dendron dev run_migrations --help
dendron dev <cmd>

commands related to development of Dendron

Positionals:
  cmd  a command to run
      [string] [required] [choices: "generate_json_schema_from_config", "build",
      "bump_version", "publish", "sync_assets", "prep_plugin", "package_plugin",
    "install_plugin", "enable_telemetry", "disable_telemetry", "show_telemetry",
                                             "show_migrations", "run_migration"]

Options:
  --version           Show version number                              [boolean]
  --help              Show help                                        [boolean]
  --wsRoot            root directory of the Dendron workspace
  --vault             name of vault
  --quiet             don't print output to stdout
  --upgradeType       how to do upgrade
                              [choices: "major", "minor", "patch", "prerelease"]
  --publishEndpoint   where to publish              [choices: "local", "remote"]
  --extensionTarget   extension name to publish in the marketplace
                                                 [choices: "dendron", "nightly"]
  --fast              skip some checks
  --migrationVersion  migration version to run
                               [choices: "0.55.2", "0.51.4", "0.47.1", "0.46.0"]

Expected behavior
Latest migration versions should be available.
Desktop (please complete the following information)

OS: Pop!_OS 21.10
Versions (all that apply to bug):

Dendron CLI: 0.84.0

0.84.0 won't have a migration entry but there should be one for 0.83.0 (which is when the publishing namespace migration happened). I'll get this fix in before the early seed snap.

@jonathanyeung Just letting you know that I've already created a task note for this. I'll add it this week's oncall note so you don't make a duplicate task.


How to get yaw and pitch values after panorama export

I see the "yaw" and "pitch" values in my data.js file and recognize it as radians but how do I determine what those values should be after the panorama has been made and exported (for instance, if I wanted to move a hotspot manually)?

One way would be to open the equirectangular image and check the pixel coordinates of the point. Alternatively, you could also implement something that prints the coordinates when a point is clicked on the viewer.


Coach notifications are not handled

This is an edge case which has come up recently. There is currently a patch, but the actual fix will take some time.

Not going to handle this right now.


App Crash in android - Huawei - Android 7

Exception in HostObject::get for prop 'SimCardsManager': java.lang.NoClassDefFoundError: android.telephony.euicc.EuiccManager

EuiccManager added in API level 28

Should I upgrade minSdkVersion to 28, do you think you could recommend other solutions to fix the crash?

HI  @odemolliens ,
I have same issue, what should I do if user's device API is less than 28?

Did you manage to find something working ? Application is crashing on every device Android 8 and less even with condition isEsimSupported to false

Solution is  :
let SimCardsManagerModule
  if ((Platform.OS === 'android' && Platform.Version >= 28)) {
     SimCardsManagerModule = require('react-native-sim-cards-manager').default
  }


Use emoji presentation for emoji found in normal text

This is a follow-up to:

#1104

That issue was narrowed to cover situations where we explicitly know we're working with an emoji. Still open are situations where a literal emoji character appears as part of some user-generated text:

TextNode in message content, corresponding to a text element in the HTML. As far as I know there's no longer a way to generate a message with emoji in a text node, though there used to be — compare this test message yesterday, where the only emoji is in an emoji span, to the message from 2020 it's quoting, where the same Markdown source produced some literal emoji following an emoji span.

… Oh, here's one way: write a literal emoji character inside a code span or code block. See these example messages.

Topics, channel names, users' names, organization names, and other places where more-or-less-arbitrary plain text appears.

Like #1104, this doesn't affect most emoji — newer emoji, including those added in the emoji boom, have only emoji presentations. Probably ❤ U+2764 HEAVY BLACK HEART, aka :heart: in Zulip, is the most conspicuous affected example: currently we show it as ❤ (the text presentation), but we should instead show ❤ (the emoji presentation).
Implementation
Probably the way to control this is through the ordering of font choices: put an emoji font first, before plain-text fonts. The tricky part is that we'll need a reduced emoji font (at least compared to Noto Color Emoji): one that doesn't have glyphs for characters like U+0020 SPACE and U+0030..0039 DIGIT ZERO..DIGIT NINE, which are perfectly normal characters for ordinary text and should still be shown in text presentation.
For details, see https://github.com/zulip/zulip-flutter/issues/1104#issuecomment-2518782312 and https://github.com/zulip/zulip-flutter/issues/1104#issuecomment-2518860390 .
One further thought beyond those comments: for drawing the line in a principled way between characters like U+0020 SPACE that should stay in text presentation despite appearing in Noto Color Emoji, and characters like U+2764 HEAVY BLACK HEART that should get the emoji presentation, one candidate is to use the code point's Unicode General_Category value:

for code points in category So (Symbol, Other) that appear in the emoji font, assume they should get the emoji presentation;
for code points in any other category, assume they shouldn't, even if they're in the emoji font.

That rule gives the right answer for U+0020 SPACE, U+2764 HEAVY BLACK HEART, and all the other examples I looked at. More study would be needed to validate the rule before running with it.

I think having any emoji in these situations is fairly uncommon. Combined with most emoji not being affected (as discussed above), this seems pretty uncommon so I think it's a low-priority issue.
As the implementation section (and the linked comments) discusses, this also may be a fairly involved task to carry out.

Zulip web appears to have the same issue — again, when a literal emoji does make it through. See this example message and the one after it for literal emoji in message content; or this for an emoji in a topic.
OTOH Zulip web does respect U+FE0F VARIATION SELECTOR-16 when it appears after a literal emoji, which is supposed to request emoji presentation. See this message for such an emoji in message content and  this one for a topic.
(These observations of Zulip web are what I see at the moment in Chrome on my Linux desktop.)
By contrast our current behavior (even after #1108) is that we show the text presentation even when the emoji code point is followed by U+FE0F VARIATION SELECTOR-16; see those same example messages.
So Zulip web's behavior when a literal emoji does get through is what Unicode TR 51 prescribes for contexts like "plain web pages", but better would be to follow what's prescribed for "informal environments like texting and chats". The latter is what Zulip web already does for almost all emoji inside message content.


Handle a nil password when not_common_password validation runs

We were experiencing undefined method downcase' for nil:NilClass` in our project when we tried to create a user without specifying a password. This fixes the problem.

It shouldn't be possible to create a user without specifying this password. I'd say that the error message you're receieving is a feature, not a problem.


Add support for automatic reminder comments

The feature needs to be explicitly enabled via a command-line argument. A comment including the priority and a reference to the team website will be added to tickets in the query.
See: https://progress.opensuse.org/issues/113797

I tested this manually for now to avoid creating too many comments. See an example comment which appears as me because I'm using my own API key for testing.


fix: avoid nil pointer reference when overriding route with KongIngress

See: #186

Codecov Report

Merging #188 into master will increase coverage by 1.83%.
The diff coverage is 68.18%.

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   18.86%   20.69%   +1.83%
==========================================
  Files          24       24
  Lines        2322     2319       -3
==========================================
+ Hits          438      480      +42
+ Misses       1846     1798      -48
- Partials       38       41       +3

Impacted Files
Coverage Δ

internal/ingress/controller/kong.go
1.13% <0%> (+0.06%)
:arrow_up:

internal/ingress/controller/util.go
52.5% <81.08%> (+52.5%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 894e966...6c049ae. Read the comment docs.


Fix hidden tooltips issue in code editor

[x] I have followed (at least) the PR section of the contributing guide.

I fixed the issue of tooltip being hidden. Tested other usages of split pane all seems still fine, however I'm not really sure what was meant by split pane overflow being hidden 🤔 I'm trying to think of a reasons but can't come up with anything, for me it seems logical that the consumer would be controlling overflow 🤔

This doesn't fix the problem at the root, we'll still see the issue in dialogs:

There may be legitimate reasons to have the editor nested in a container with hidden overflow. Isn't there a way we can make monaco-editor attach these tooltips to the body or something?

Oh, good catch, I will take a look 🙇

Closing as per https://github.com/mui/mui-toolpad/pull/682


docs: fix icon documentation in tree view

🙋 Documentation Request
Treeview documentation for icon expanded and collapsed is mixed up (is inverse):

💁 Possible Solution
https://github.com/microsoft/fluentui-blazor/blob/61ef3de5e4fa21376fd10d7b7d7d05834dd0a21f/src/Core/Components/TreeView/FluentTreeItem.razor.cs#L80-L94
Either: for collapsed, correct the ref tag to point to collapsed; for expanded correct the ref tag to point to expanded.

Or, if this is really intended, then a quick explanation on why that is the case would be useful.

Looks right to me. It clearly says when IconExpanded is not set then IconCollapsed will be used and vice versa.

But why would you want a default from a state X to be displayed in !X case? It seems counter intuitive to me that expanded uses collapsed icon, if expanded has no icon of its own.

This is just a fallback for situations were people want to specify only 1 icon (and where the icon does not necessarily have to show an expanded/collapsed state!!)


Remove caching in table parameters

This removes the caching of settings and mappings in table parameters.
If the settings/mappings methods are called and the builders are afterwards
mutated, then settings/mappings will be cached and not reflecting the latest state.
Summary of the changes / Why this improves CrateDB
Checklist

[x] Added an entry in CHANGES.txt for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

@mkleen Looks like a fix, should it be backported?

I ran into this while working on another task. So you would suggest to backport that ?

This does not fix an actual user issue, but it is definitely fixing a wrong behavior in the code base.

These methods are used heavily, but it looks never twice. However, i think it's a good to backport this. Should this go with a change entry ?

What change entry would you then suggest if it never caused an issue?

Good point, lets skip it.

Both 4.7 and 4.8 ?


Fix #1214: Sphinx 4  overflow

This adds a max-width to the Sphinx 4 dl.property to prevent the overflowing of the pre tag that was occurring when placed inside this dl.
This specific dl class is set to display:inline-block, which doesn't deal very well with the white-space:pre from the pre tag. Adding a max-width to the dl.property should fix it.
Altered CSS
html.writer-html4 .rst-content dl:not(.docutils) .property,
html.writer-html5 .rst-content dl[class]:not(.option-list):not(.field-list):not(.footnote):not(.glossary):not(.simple) .property {
  display: inline-block;
  padding-right: 8px;
  max-width: 100%;
}

Fixes #1214

Thanks :)

Np. This will probably have to wait for the current release to move forward thought.

This looks like a good change to include in 1.0, our first release supporting Sphinx 4.


easy way to have a custom AntiforgeryValidationException Error Page

Hello, currently I have a .net core app (some parts are Razor Pages), currently we also share the same cookie with an old webforms app (thanks owin).
Currently if I try to Login with the same browser window in two tabs (i.e. same happens inside the old app), I will get an 400 response without a body, which is really really ugly.
I actually tried everything to get rid of it (even disabling AntiForgery for Login, which I guess does not work?!) but what I actually wanted to do is having a nice looking error page.
Currently that is what is happening inside my logs:
Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.AutoValidateAntiforgeryTokenAuthorizationFilter[1]
      Antiforgery token validation failed. The provided antiforgery token was meant for a different claims-based user than the current user.
Microsoft.AspNetCore.Antiforgery.AntiforgeryValidationException: The provided antiforgery token was meant for a different claims-based user than the current user.
   at Microsoft.AspNetCore.Antiforgery.Internal.DefaultAntiforgery.ValidateTokens(HttpContext httpContext, AntiforgeryTokenSet antiforgeryTokenSet)
   at Microsoft.AspNetCore.Antiforgery.Internal.DefaultAntiforgery.ValidateRequestAsync(HttpContext httpContext)
   at Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.ValidateAntiforgeryTokenAuthorizationFilter.OnAuthorizationAsync(AuthorizationFilterContext context)
info: Microsoft.AspNetCore.Mvc.RazorPages.Internal.PageActionInvoker[3]
      Authorization failed for the request at filter 'Microsoft.AspNetCore.Mvc.ViewFeatures.Internal.AutoValidateAntiforgeryTokenAuthorizationFilter'.

it would be great if there was a way to have an event where I can actually handle the exception and post a nice looking error page to the user, i.e. something like "you probably already logged in inside another tab" or if it is not login based (do something different).
however the issue is either one of the following:

it's not possible in an easy way to show/redirect a razor view view nice looking error details
the easy way is not documented in any way

i.e. and no it's not a programmer error if a user tries to login twice. (https://github.com/aspnet/Mvc/issues/8276)

Have you tried creating your own error handler as explained in the error handling docs? You should be able to catch the AntiforgeryValidationException there and e.g. invoke some nice looking error page that way.

sadly, AntiforgeryValidationException will get converted into a error 400 somewhere in the Antiforgery Filter chain.

Hmm, you are right, the ValidateAntiforgeryTokenAuthorizationFilter does that and there is unfortunately no way to hook into that.
Allowing to hook into that, using some event system (like with the authentication stack) or by splitting up the validation, is probably too complicated and unfortunately, authorization filters are also called before exception filters (so you cannot just throw from authorization filters and have an exception filter handle it).
Also unfortunately, returning a result from an authorization filter short-circuits the MVC filter pipeline, so one couldn’t even inspect the result to handle the BadRequestResult differently in some way.
But what we could do maybe is create a custom InvalidAntiforgeryResult that also just produced a 400 but also allowed some hook when it is being executed. So one could maybe configure it through the AntiforgeryOptions and specify a custom InvalidAntiforgeryResult handler? I think I’ll give that idea a try and see how it feels.

well having something in context.Items which says "this 400 result was caused by xyz" would be enough since there is a app.UseStatusCodePages however at the moment it's not easy to know if the framework itself caused the error 400.

I just pushed a WIP PR for this over at https://github.com/aspnet/Mvc/pull/8604 that implements the idea outlined above. You would use it like this to configure a redirect for example:
services.AddAntiforgery(options =>
{
    options.ValidationFailedResultHandler = ctx =>
    {
        ctx.Response.Redirect("/anti-forgery-error");
        return Task.CompletedTask;
    };
});

As part of the PR @poke sent, Antiforgery filter returns an IActionResult with a well known type - IAntiforgeryValidationFailedResult. The guidance is to write a IAlwaysRuntResultFilter that tests for this type. See https://github.com/aspnet/Mvc/blob/ddbe0fef2617f94a42312f002860f8f45145f11d/test/WebSites/BasicWebSite/Filters/RedirectAntiforgeryValidationFailedResultFilter.cs

well the outcome of the PR is really good, thanks @poke! and Asp.Net Core Team!


Dec 252 - Improve the nav experience on beehive (Part II)

:one: DEC-293

Added link to the collection home page in the dropdown menu. (ShowcaseDropDown component)

:two: DEC-294

Set a minimum width of 350px for dropdown menu (css)
Added some additional styling including padding, colors, and font-sizing to make menu look like it actually belongs on the site (css)
Add $white scss variable to quiet hound about using hex codes not in variables.

:three: DEC-295

On subpages, title is all on one line. (css)

:four: DEC-296

Increased font size on title of subpages. (css)

:five: DEC-297

Removed dropdown from home page since it is redundant with the listing on the bottom of the page. This is done by checking a dropdown boolean in the CollectionPageHeader React component.

@jonhartzler :ok_hand: Those changes have been pushed.

:+1:


Multi organization and multi-channel contract version conflicts bug

Description
Two organizations A、B are deployed on channel 1 and  org B is deployed on channel 2 separately. Both channels have the same contract (and the contract name is also the same). When the version of channel 2 contract is upgraded, the contract with the same name in channel 1 cannot be used properly and endorsement errors will occur (in this case, only channel 1 contract can be upgraded to the same version)
Two organizations, A、B, are both in channel 1 and org A、org B are also in channel 2. Both channels deploy the same contract (and the contract name is the same). After the version upgrade of channel 2 contract, the contract with the same name in channel 1 can be used normally.
Steps to reproduce
No response

Please provide exact reproduction steps.
e.g. are you using v2.x chaincode lifecycle? What are the series of lifecycle calls made? What client is invoking? What invoke calls are made?


Updating won't ever finish

Hi there,
Whenever there is a new version out, and I click the Update button, it seems to never actually finish, and the button stays on "Updating..."

When I reload Atom, I see the update actually has done it's job, i.e. the new version is there and works. It's just that the Update button on the Settings View doesn't seem to have gotten the memo.
Now, I figured at first it might be a bug on Atom's Settings View, but then I noticed that this only ever happens with this one package.
All other community packages I have (several dozens) finish just fine on their own.

That's so weird. Not really sure how this happens or where we get triggered. As far as I know, we don't do anything fancy on install - just present ourselves as a typical package.

It could still be a Settings Updater issue of some sort, it's just weird that it has happened only ever with this package for the last few patches and minor versions.

I've been using atom-script since Atom 1.0, but I've seen it successfully update maybe twice. Usually a restart is needed, until then the update hangs and the plugin does not work.
I have not experienced this issue with other plugins.

@dessant It was fixed in last release. Next updates will end successfuly

@nixel2007 you mean 3.6.3? The issue was still there as I updated to the last version earlier today.
Please reopen.

@dessant this issue was solved IN 3.6.3. Next releases will work correctly

Ah, because during the last update Atom was still trying to deactivate a buggy script version, ok, it is clear now. :wink:

The same was the case while updating from 3.6.3 to 3.7.0.

@dessant could you provide any logs from console (ctrl-alt-i)? if there any

There were no errors or anything, maybe it is https://github.com/atom/settings-view/issues/532?

Guys, as the OP I'm inclined to close this off. I have since seen this behavior with many other packages and it's most likely related to the Settings View issue @dessant has just linked to. Please subscribe to that issue instead.


Issues with Nuxi CLI 3.7?

Hi everyone! 👋
With Nuxt 3.7, we have introduced a brand new CLI - nuxt/cli. We are thrilled to share our exciting plans for it, along with numerous improvements. However, there might be unforeseen regressions associated with the new CLI.
In such cases, we apologize for any inconvenience caused. Please take a moment to review the open issues as there might already be a known issue being tracked. If not, please don't hesitate to open a new issue.
Thank you!

Thanks
Where gone nuxi start  ?
command not found in 3.7.0
 npm run start

> start
> nuxt start

Nuxt CLI (nuxi)                                                                                8:16:21 PM

USAGE nuxi add|analyze|build-module|build|cleanup|_dev|dev|devtools|generate|info|init|module|prepare|preview|test|typecheck|upgrade

I'm encountering an issue with the command-line interface (CLI) while attempting to build the application in GitHub Actions. The problem arises when it attempts to install dependencies. My project follows a monorepo architecture, and within the workspace managed by pnpm, "nuxi" is one of the projects.

@YumaInaura We have added back the start command (alias to preview) in latest nuxi release please try to upgrade.
@mitch1009 Would you mind to open an issue in nuxi with ideally reproduction and some more CI logs?

@YumaInaura We have added back the start command (alias to preview) in latest nuxi release please try to upgrade.
@mitch1009 Would you mind to open an issue in nuxi with ideally reproduction and some more CI logs?

Definitely am on it. Thanks for the response

@pi0

We have added back the start command (alias to preview) in latest nuxi release please try to upgrade.

i did not know start command is alias of preview command.
its good update thanks!

After two more minor versions, I think we can close this issue here ☺
If there are CLI-related problems, suggestions or feedback, please use the https://github.com/nuxt/cli/ repo! 👏🏻


On edit->paste operation text gets pasted into multiple files

This has been an issue that I have observed on random since I started using Visual Studio Code. I occasionally find my source code polluted with random text. I cant reproduce this again but I still wanted to share because the issue is vary destructive and annoying.
So what happens is that occasionally on pasting text into tab that is currently in focus, the text will also get inserted into files that are in other tabs.
I don't know how to provide a proper repro because this happens on random. In average I experience this issue one in every two days.

/needsMoreInfo including version, platform and list of extensions. Help\About is a good source of some of this information. If you had used Help\Report Issue it would have included all this automatically in the new GH issue.

/needsMoreInfo including version, platform and list of extensions. Help\About is a good source of some of this information. If you had used Help\Report Issue it would have included all this automatically in the new GH issue.


Invalid property names: PerPerson/email

Hi! Can you help us with one issue pelase ?
We have a business case where we need to update SFSF with information from Active Directory and are trying to setup the email update using SuccessFactors writeback, we recieve the following error when we use the mapping for email.
With standard connector we are getting this error message:
Failed to update User<EMAIL_ADDRESS>in SuccessFactors; Error: Missing mapping for property emailType. For email writeback, the emailType property is mandatory. This operation was retried 0 times. It will be retried again after this date: 2020-03-31T12:55:43.6603024Z UTC
when we are adding emailType we are getting this error message
Failed to process User<EMAIL_ADDRESS>Error: Message: Message: The remote server returned an error: (400) Bad Request. Web Response: { "error" : { "code" : "COE_PROPERTY_NOT_FOUND", "message" : { "lang" : "en-US", "value" : "[COE0021]Invalid property names: PerPerson/email. Please check the property name in Admin Center > OData API Data Dictionary or entity metadata. Ensure there were no data model changes that removed this field, and please execute a refresh metadata to ensure the cache is not corrupted." } } } Web Response: { "error" : { "code" : "COE_PROPERTY_NOT_FOUND", "message" : { "lang" : "en-US", "value" : "[COE0021]Invalid property names: PerPerson/email. Please check the property name in Admin Center > OData API Data Dictionary or entity metadata. Ensure there were no data model changes that removed this field, and please execute a refresh metadata to ensure the cache is not corrupted." } } }. This operation was retried 0 times. It will be retried again after this date: 2020-03-31T18:23:05.0964305Z UTC
We are using the standard SFSF field for email address.
Is there anything we are missing with the attriute mapping ? What about email type ? as there are several (Business, Private, Other) Do we need to include that attribute in the mapping as well ?
Is "email" property attribute mapped correctly in Azure ? in SFSF ODATA Dictionary email address is not in "email" field but "emailAddress"
is it updating the standard element email in Employee profile ? or emailInfo section ?
Thank you for your help !

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ed074cb3-7c71-0728-10d5-d1f991162e67
Version Independent ID: 0ed1eddb-f8d2-172b-0cc5-ed5f94a9b1e6
Content: Tutorial: Configure SuccessFactors writeback in Azure Active Directory
Content Source: articles/active-directory/saas-apps/sap-successfactors-writeback-tutorial.md
Service: active-directory
Sub-service: saas-app-tutorial
GitHub Login: @cmmdesai
Microsoft Alias: chmutali

@kdziembaj Thanks for the feedback !  I have assigned this issue to content author to investigate and update the document as appropriate.

@kdziembaj Thanks for your feedback. There was a bug in the implementation that we have now fixed so the mapping allows you to flow the emailType attribute. Here are the steps to fix this issue:

Restore the mapping
Please set the emailType attribute to the picklistID for business email. You can use this ODATA query to get the picklistID for business email in your tenant.

https:///odata/v2/Picklist('ecEmailType')?$expand=picklistOptions&$select=picklistOptions/id,picklistOptions/externalCode&$format=json
Set the "id" value corresponding to "externalCode=B" as a constant mapping.
3) Save the mapping.
I will update the document also for these steps.

#please-close


Add change log file.

Hi, as I can see, you carefully fill tags and labels for issues in your repo.
For such cases I create a github_changelog_generator, that generate change log file based on tags, issues and merged pull requests from :octocat: Issue Tracker.
This PR add change log file to your repo (generated by this script).
You can check, how it is look like here: Change Log
Some essential features, that has this script:

it exclude not-related to changelog issues (any issue, that has label question duplicate invalid wontfix )
Distinguish issues according labels:

Merged pull requests (all merged pull-requests)
Bug fixes (by label bug in issue)
Enhancements (by label enhancement in issue)
Issues (closed issues w/o any labels)

Generate neat Change Log file according basic change log guidelines.

You can quickly update this file in future by the simple run script: github_changelog_generator vikmeup/SCLAlertView-Swift in your repo folder and it makes your Change Log file up-to-date again!
Hope you find this commit as useful. :wink:

Todo al banco America


[Suggestion/Question] Compatibility

Would it be possible to have some info on compatibility? Is this compatible with AI improvements or certain other performance mods?

tias

try it and see is the info you'll get, I cannot test every use case


Add german wordlist

Hi,
I added a German wordlist as first commit to your awesome library.
I don't know if the words in there meet requirements but I tried to peek into the other wordlists to get a sense of what words are good.
I'll start using CardanoSharp in my projects and contribute more in the future.
You might want to add CardanoSharp to the Tools section of the Cardano Developer Portal.

Thanks for the PR. We can definitely validate the words. We want to make sure they are correct so we stay compliant

Alright I'm very confused as to why there isnt an already established German wordlist

alright so heres my thought. since there is no official german wordlist, lets roll with your list. if an official list ever pops up, we can make it German2 or something along those lines. we would need to support both lists.

@tweakch CardanoSharp.Wallet 0.1.1 has your PR
Example Usage
var mnemonic = _keyService.Generate(24, WordLists.German);
var entropy = _keyService.Restore(mnemonic, WordLists.German);

thank you for your contribution

Thank you sounds good. Will try it out later.
Could you provide me with some links and resources to study?


API - Test env.appName

@alexandrudima

[ ] any os

#5297, Make sure that you can get to the appName via the extension api, check the docs etc

:white_check_mark: "Code - OSS Dev" when running in dev mode


New ObjectMeta method in AWSResource interface

Problem:
Current implementation of AWSResource.SetObjectMeta(metav1.ObjectMeta) accepts the concrete type k8s apimachinery/metav1.ObjectMeta, while AWSResource.MetaObject() returns the k8s apimachinery/metav1.Object interface.
When trying to update the AWSResource metadata from AWSResource.MetaObject() , it does work because a pointer type is returned from all the AWSResource implementations in ACK but it is not explicit for code readers.
A sample current approach looks like
obj := res.MetaObject()
annotations.AddX(obj)

While a more readable approach would be
obj := res.ObjectMeta()
updatedObj := annotations.AddX(obj)
res.SetObjectMeta(updatedObj)

Possible solutions
a) add another method AWSResource.ObjectMeta() which returns the concrete type k8s apimachinery/metav1.ObjectMeta. This concrete return type can be updated and then set into AWSResource with AWSResource.SetObjectMeta method.
b) Create a factory method NewObjectMeta(metav1.Object) metav1.ObjectMeta inside k8s apimachinery. This method will allow the conversion of any metav1.Object interface implementation to be used as metav1.ObjectMeta

Is there a particular issue that you are trying to solve that requires this solution? I think there is a strong reason to keep the object meta that comes with a given AWSResource. If you require changing particular fields, like finalizers or annotations, I think those should be handled separately.

Is there a particular issue that you are trying to solve that requires this solution? I think there is a strong reason to keep the object meta that comes with a given AWSResource. If you require changing particular fields, like finalizers or annotations, I think those should be handled separately.

I am trying to update the metadata/annotations here. https://github.com/aws-controllers-k8s/runtime/pull/46
Maybe I am overthinking this but it seems weird to me that these methods accept interface type parameter, perform updates and do not return the updated object. (What If implementation of the interface is not a pointer type. Sounds like a bad assumption to me honestly.) Hence I wanted these methods that cause side-effects to be explicit and have a return type.
Anyways, currently in the above mentioned PR, I did follow exactly how we are updating the finalizers and it works. https://github.com/kubernetes-sigs/controller-runtime/blob/v0.9.6/pkg/controller/controllerutil/controllerutil.go#L352
Please  let me  know if I am overthinking it or it makes sense to add return  types to methods with side-effects without explicit pointer type in the parameters.

Okay, I see what you mean - I just checked out your annotations PR.
Are you suggesting that we should be returning a deep copy of the object meta when returning it? I think it's necessary for some code paths that the method returns the original - because modifications to it are then directly applied (as you show in your first code example). You would prefer to treat it as an immutable object?

"Are you suggesting that we should be returning a deep copy of the object meta when returning it?"

No, we can return the same object after modifying it in the method call.

"You would prefer to treat it as an immutable object?"

Not necessarily. Even if we mutate the same object, having a return type of same object helps being explicit. (Like we do when we return latest objects from AWSResourceManager.Update() calls )


Documentation: WakeOnLan dependency on systemd.network is not clear to users

Problem
Its not clear to users that networking.interfaces.<name>.wakeOnLan requires systemd-networkd
Proposal
Relocate the current wakeOnLan configuration setting to a subset of systemd.network and provide an alternative that creates a oneshot per interface to enable the policy the user specifies leveraging ethtool.
OR

Update the documentation to state that it leverages systemd-networkd, for example, Whether to enable wol on this interface using systemd-networkd.
Add a dependency on systemd-networkd and  warn users if they use wakeOnLan without it.

Checklist

[x] checked latest Nixpkgs manual (source) and latest NixOS manual (source)
[x] checked open documentation issues for possible duplicates
[x] checked open documentation pull requests for possible solutions

Add a :+1: reaction to issues you find important.

networking.interfaces.<name>.wakeOnLan requires systemd-networkd

What makes you believe that?
https://github.com/NixOS/nixpkgs/blob/6afb255d976f85f3359e4929abd6f5149c323a02/nixos/modules/tasks/network-interfaces.nix#L1437-L1445

WOL isn't working on my system and I don't have systemd-networkd enabled.
If not systemd-networkd what else reads /etc/systemd/network/40-eth0.link?

What's weird is that the "normal" scripted networking in NixOS (without using systemd-networkd) was working fine with WoL until around last month.  As I reported in what is probably a duplicate issue of this one at this point ( https://github.com/NixOS/nixpkgs/issues/339082 ), this was working fine without also using systemd-networkd, but recently broke, at least on all of my affected systems.

That's interesting, it might be worth checking to see if there were any changes to how WOL works but for me this was working fine back around 21.05 and then all of a sudden stopped working. Other than finding that it seems it requires the system to be using 'systems.network' I've just been too lazy to implement a new solution. I might give that a go if I have time this winter break.

No, it does not require systemd-networkd (at least not by design).

If not systemd-networkd what else reads /etc/systemd/network/40-eth0.link?

The answer is in systemd.link(5):

A plain ini-style text file that encodes configuration for matching network devices, used by systemd-udevd(8) and in particular its net_setup_link builtin.

We have systemd-udevd even when systemd-networkd is not enabled. This is why the wake-on-LAN implementation is shared by the scripted and networkd backends.
If it isn't working, that's a bug we should track in https://github.com/NixOS/nixpkgs/issues/339082. Unless someone recently (and deliberately) removed scripted backend support for wake-on-LAN, this isn't a documentation problem and we can close this issue.

It's definitely worth mentioning the systemd-networkd and systemd.link/systemd-udevd associations for the networking.interfaces.<name>.wakeOnLan.enable option so it appears in the description of the option search web interface at search.nixos.org.  I know that is at least being extracted from nixpkgs directly which means that knowledge will be directly in the repository at that point.
Probably worth mentioning in the user manual also.  But I have no idea at the moment how that is being maintained in relation to the nixpkgs repo itself.


Possible to do not fullscreen?

Hey kolbyjack. Really loving the wallpaper module. I've got it all set up using icloud and it works perfect. However, I'm thinking I actually want to have my photos be much smaller, only because I'm having issues with sometimes reading text. I'm honestly wanting to use some CSS to put them within a "polaroid" looking border thats rotated, off center using the code below (snagged from another github for a diff photo module). However, yours is the best (and only) I can find that utilizes iCloud for showing photos
I'll be the first to admit I'm not the greatest at coding, though I can generally troubleshoot or slog my way thru some stuff. I'm not sure where to start with my goal, though. I've changed position on your config to say upper_third, but then its on top of everything. If I add _below, then its just black (no error config screen tho).
Any tips on how I can push the photos using your module to something other than fullscreen?
I've tried using the code below and it doesnt do anything, not sure if it is calling some code from the original module (MMM-Instagram)
Another thing I had considered was setting up a cronjob to actually use that instagram module and download files automatically, but I was trying to avoid so as to not fill up my memory card on the rpi 4
#MMM-Wallpaper-image {
box-shadow: 10px 10px 15px #aaa;
padding: 10px 10px 30px 10px;
border: 1px solid #bfbfbf;
background-color: #fff;
transform: rotate(-6deg);
-ms-transform: rotate(-6deg);
-webkit-transform: rotate(-6deg);
}

If your photos are making the text unreadable, you could try changing the filter config.  I actually have mine set to grayscale(0.5) brightness(0.3), which is a little darker than the default, and makes everything a little more readable.
As for shrinking the image and adding a polaroid-like border, that may be possible, you could try editing MMM-Wallpaper.css like so:
.MMM-Wallpaper .wallpaper {
  position: fixed;
  left: 50%;
  top: 50%;
  transform: translateX(-50%) translateY(-50%) rotate(-6deg);
  box-shadow: 10px 10px 15px #aaa;
  padding: 10px 10px 30px 10px;
  border: 1px solid #bfbfbf;
  background-color: #fff;
}

.MMM-Wallpaper .tall {
  width: 30%;
}

.MMM-Wallpaper .wide {
  height: 30%;
}

You can try playing with the .wide and .tall values to adjust the size of the images, and the left and top values of .wallpaper can move the image to where you want it on the screen.

Thanks, going to give it a shot now! Appreciate you taking the time to send
that!
On Tue, Oct 13, 2020 at 10:16 PM Jon Kolb<EMAIL_ADDRESS>wrote:

If your photos are making the text unreadable, you could try changing the
filter config. I actually have mine set to grayscale(0.5) brightness(0.3),
which is a little darker than the default, and makes everything a little
more readable.
As for shrinking the image and adding a polaroid-like border, that may be
possible, you could try editing MMM-Wallpaper.css like so:
.MMM-Wallpaper .wallpaper {
position: fixed;
left: 50%;
top: 50%;
transform: translateX(-50%) translateY(-50%) rotate(-6deg);
box-shadow: 10px 10px 15px #aaa;
padding: 10px 10px 30px 10px;
border: 1px solid #bfbfbf;
background-color: #fff;
}
.MMM-Wallpaper .tall {
width: 30%;
}
.MMM-Wallpaper .wide {
height: 30%;
}
You can try playing with the .wide and .tall values to adjust the size of
the images, and the left and top values of .wallpaper can move the image to
where you want it on the screen.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kolbyjack/MMM-Wallpaper/issues/24#issuecomment-708111776,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLD7HTS3U3VBOBF5EED3DDSKUCWDANCNFSM4SOS6J5Q
.

Man! It works, and absolutely PERFECTLY! THANK YOU!
On Tue, Oct 13, 2020 at 10:16 PM Jon Kolb<EMAIL_ADDRESS>wrote:

If your photos are making the text unreadable, you could try changing the
filter config. I actually have mine set to grayscale(0.5) brightness(0.3),
which is a little darker than the default, and makes everything a little
more readable.
As for shrinking the image and adding a polaroid-like border, that may be
possible, you could try editing MMM-Wallpaper.css like so:
.MMM-Wallpaper .wallpaper {
position: fixed;
left: 50%;
top: 50%;
transform: translateX(-50%) translateY(-50%) rotate(-6deg);
box-shadow: 10px 10px 15px #aaa;
padding: 10px 10px 30px 10px;
border: 1px solid #bfbfbf;
background-color: #fff;
}
.MMM-Wallpaper .tall {
width: 30%;
}
.MMM-Wallpaper .wide {
height: 30%;
}
You can try playing with the .wide and .tall values to adjust the size of
the images, and the left and top values of .wallpaper can move the image to
where you want it on the screen.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/kolbyjack/MMM-Wallpaper/issues/24#issuecomment-708111776,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ARLD7HTS3U3VBOBF5EED3DDSKUCWDANCNFSM4SOS6J5Q
.

Hey @kolbyjack. Just curious, still loving the tweak ya gave me. I'm wondering, is there a way to change the width and height % depending on if the photo is portrait or landscape? The settings I have are 50% for both and I changed the top to 35% and its great for portrait, Landscape photos it shrinks down pretty small to fit the same width. Could honestly probably grow by to like 50% for width or something

The .MMM-Wallpaper .tall style should take effect for portrait photos, and .MMM-Wallpaper .wide should take effect for landscape.


Inline links not recognized in lists or with other text.

Picture of the result:

To be precise, is the issue that you have a field like
Field:: This is some [[text]].

and when you render it using a query, it is not properly linking the links? If so, fixing this right now.

Correct! Thank you!

I believe both issues have been fixed in 0.2.11 - give it a try.

Looks perfect! Thank you! 🙏


Fix Google Play Services check in release builds

Description
The check for GMS fails in release builds but works in dev builds. This usually points to something related to proguard. A method that was needed by this library was getting stripped by proguard in release mode, so adding that to the rules fixes it.
Follow issue from the library here: https://github.com/react-native-device-info/react-native-device-info/pull/1302
Other changes
Also upgraded the library itself thinking that might fix it, but it didn't. On the issue they are discussing a different fix so worth keeping an eye on it.
Tested
Enabled minify in debug mode (in build.gradle) and looked for the "Google Mobile Services" log.
How others should test
Run an emulator with google play services installed and then run:
adb logcat | grep "Google Mobile Services"
Related issues

Fixes #1046

Backwards compatibility
Yes.

Hey @MuckT  Can you please let us know if we have to test anything from our side.
Thanks!!
CC: @etuleu


Non-starter on windows with MLJAR studio

Hi, Looks amazing and just what I need - Tried to get it running in MLJAR studio in windows, but it's a non-starter due to a known bug in Jupyter it seems. People posting bugs about it since early this year. Try to install the mercury extension in order to satisfy the requirements for this workbook to run it, but no-go. You get this error on any extension install from MLJAR studio.
Error when performing an action.

Reason given:

Error: ERROR: Could not open requirements file: [Errno 13] Permission denied:

Perhaps a newer version of Jupyter fixes it, but I do not see their fix documented yet.

Hi @pjsgsy,
Thank you for opening the issue. I got few questions:

What would you like to build? What tool are you looking for?
Is MLJAR Studio working for you? Are you able to start app and execute code recipes?
MLJAR Studio is using anaconda for managing Python environment. I think we can add functionality to install packages from requirements.txt file.
In this month we are planning to release new code recipes for training ML models with scikit-learn. We plan to release Python notebooks showing how ML pipelines can be created in MLJAR Studio.

In case of any problems, questions please let me and @aplonska know. MLJAR Studio is in early days and we need feedback from users.
All the best,
Piotr

Hi @pjsgsy,
A lot of mixed problems are here. Please give me some time, and I will prepare AutoML workbooks for you that will work with MLJAR Studio. I'll do my best to have it this week. Let's be in touch!


ci: add code coverage, mac & windows runners

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@2005a34). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage        ?   20.23%
=======================================
  Files           ?       16
  Lines           ?     2100
  Branches        ?        0
=======================================
  Hits            ?      425
  Misses          ?     1675
  Partials        ?        0

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


style: :lipstick: update about links to have a more modern feel

Description
This PR updates the look of the about links (i.e., the buttons on our landing pages).
With these changes, I'm moving away from the Sprout "look and feel" that we got from Mjølner earlier, but these buttons look more "modern" (in my opinion).
Before (+ hover):

Now (+ hover):

What do you think? :) 🌱
Reviewer Focus

This PR needs a quick review.

I like the new colours, but I like the round buttons better...

Oh - you made them round, they are lovely!

I think the white on green might trigger the accessibility contrast issue, but I think we should plan regular accessibility checks to make sure things are ok. Not a problem right now though.

@lwjohnst86  You're right - the hover doesn't have a high enough contrast. But I figured it was ok when the non-hover button contrast is high enough?


Add info how to use this plugin

Btw, did you get a chance to approve my request to install renovate here?

Btw, did you get a chance to approve my request to install renovate here?

there's no request that I can see

Btw, did you get a chance to approve my request to install renovate here?

there's no request that I can see

Rip, requested one (again).

approved it


Register running containers on startup

Fixes #8.
On listener startup, running containers info are fetched from Docker API, and stored in the container map, before listening to docker events.
This PR refactors also the Docker API interface, using the Docker Go client.

This is great. I’ll get this merged and released tomorrow.

Thank you, @josegonzalez 👍


KAFKA-2072: Add StopReplica request/response to o.a.k.common.requests

This PR adds StopReplica request and response as it is required by @ijuma for KAFKA-2411. Migration of core module is addressed a separate PR (#141).
@ijuma Could you review it? @gwenshap Could you take a look as well?

Failure is not related to this one.
kafka.consumer.MetricsTest > testMetricsLeak FAILED

@ijuma Thank you for the review. I think that I have addressed most of your comments.

LGTM. As this doesn't change any running code, it's low-risk.

Thanks for the patch. LGTM.


Potential bug in numeric handling where_clause for filters

Note that Datasette does already have special logic to convert parameters to integers for numeric comparisons like >:
https://github.com/simonw/datasette/blob/c4c9dbd0386e46d2bf199f0ed34e4895c98cb78c/datasette/filters.py#L203-L212
Though... it looks like there's a bug in that? It doesn't account for float values - "3.5".isdigit() return False - probably for the best, because int(3.5) would break that value anyway.

Originally posted by @simonw in https://github.com/simonw/datasette/issues/1671#issuecomment-1075432283

My hunch is that this mechanism doesn't actually do anything useful at all, because of the type conversion that automatically happens for data from tables, see:

#1671

So either remove the self.numeric type conversion bit entirely, or prove that it is necessary and upgrade it to be able to handle floating point values too.


Fix the wrong repository link

Fixing it allows users to find the codebase faster.

Duplicate of https://github.com/tokio-rs/tokio-metrics/pull/17


Logs are not sent to Splunk Cloud even though available within splunk-kubernetes-logging container

What happened:
Logs from standard output are not being sent to splunk cloud, even though they do appear within the splunk-kubernetes-logging container in /var/log/containers/
For example, the following output logs but are not shown/sent to splunk cloud
kubectl exec -ti production-splunk-connect-for-kubernetes-splunk-kubernetes9r8z2 cat /var/log/containers/production-app-f9e08ac43fcd6d403aea3a20facbf0823049afaa638bff6fb60adb4c95417353.log

Error logs
2020-08-06 18:18:13 +0000 [info]: #0 stats - namespace_cache_size: 6, pod_cache_size: 18, namespace_cache_api_updates: 33, pod_cache_api_updates: 33, id_cache_miss: 33, pod_cache_host_updates: 73, pod_wat
ch_gone_notices: 3
2020-08-06 18:18:43 +0000 [info]: #0 stats - namespace_cache_size: 6, pod_cache_size: 18, namespace_cache_api_updates: 33, pod_cache_api_updates: 33, id_cache_miss: 33, pod_cache_host_updates: 73, pod_wat
ch_gone_notices: 3
2020-08-06 18:18:48 +0000 [info]: #0 disable filter chain optimization because [Fluent::Plugin::KubernetesMetadataFilter, Fluent::Plugin::RecordTransformerFilter] uses `#filter_stream` method.
2020-08-06 18:19:13 +0000 [info]: #0 stats - namespace_cache_size: 7, pod_cache_size: 18, namespace_cache_api_updates: 34, pod_cache_api_updates: 34, id_cache_miss: 34, pod_cache_host_updates: 73, pod_wat
ch_gone_notices: 3
2020-08-06 18:19:43 +0000

What you expected to happen:
Logs should be appearing from all container's standard output in splunk cloud
How to reproduce it (as minimally and precisely as possible):

global:
  logLevel: info
  splunk:
    hec:
      indexName: k8s-logging
      host: http-inputs-MY-INPUT.splunkcloud.com
      port: 443
      token: MY_TOKEN
      protocol: https
      insecureSSL: false
      clientCert: |
      clientKey: |
      caFile: |
  kubernetes:
    clusterName: my-cluster

splunk-kubernetes-logging:
  fluentd:
    exclude_path:
      - /var/log/containers/*_ntnx-system_*.log
  containers:
    pathDest: /var/nutanix/docker/containers

splunk-kubernetes-metrics:
  kubernetes:
    useRestClientSSL: false

Anything else we need to know?:
Environment:

Kubernetes version (use kubectl version):

Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.10", GitCommit:"f3add640dbcd4f3c33a7749f38baaac0b3fe810d", GitTreeState:"clean", BuildDate:"2020-05-20T13:51:56Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

Ruby version (use ruby --version):

ruby 2.5.5p157 (2019-03-15 revision 67260) [x86_64-linux]

OS (e.g: cat /etc/os-release):

NAME="Red Hat Enterprise Linux"
VERSION="8.2 (Ootpa)"
ID="rhel"
ID_LIKE="fedora"
VERSION_ID="8.2"
PLATFORM_ID="platform:el8"
PRETTY_NAME="Red Hat Enterprise Linux 8.2 (Ootpa)"
ANSI_COLOR="0;31"
CPE_NAME="cpe:/o:redhat:enterprise_linux:8.2:GA"
HOME_URL="https://www.redhat.com/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"

REDHAT_BUGZILLA_PRODUCT="Red Hat Enterprise Linux 8"
REDHAT_BUGZILLA_PRODUCT_VERSION=8.2
REDHAT_SUPPORT_PRODUCT="Red Hat Enterprise Linux"
REDHAT_SUPPORT_PRODUCT_VERSION="8.2"

Splunk version: helm chart 1.4.2
Others:

looks like its humming along, what search are you running? Looks to be going in the main index?

looks like its humming along, what search are you running? Looks to be going in the main index? Can you see fluentd starting tail on the logs you expect?

Yes it does try to tail the logs I expect, but at the end it also shows the following error:
06 19:47:23 +0000 [info]: #0 disable filter chain optimization because [Fluent::Plugin::KubernetesMetadataFilter, Fluent::Plugin::RecordTransformerFilter] uses `#filter_stream` method.

When querying on the cloud, they don't show up at all.

these are not related..

these are not related..
try this search
index=foo sourcetype::kube:container:*

Oddly enough, I'm getting logs but nothing outside of the namespace splunk-connect is running on 👎

🤷🏼♂ please review your running configmap and the logs output from the pod. If the pod picks up the logs, then not sure what you have borked...

🤷🏼♂ please review your running configmap and the logs output from the pod. If the pod picks up the logs, then not sure what you have borked...if you are getting logs from our namespace then the collector is working. Please review the readme about searching for metadata in Splunk

You're right logs were making it there but the search was borked, I got a hold of support and it seems that there was an issue with the fields in the Splunk Cloud side.
The search was broken and I was able to get the logs using the following query
index=k8s-logging cluster_name::my-cluster


puppetlabs/stdlib: Allow 8.x

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

okay, this requires a new elastic_stack release


Producers and consumers throw PulsarClientException.AlreadyClosedException

Describe the bug
Pulsarclientexception is thrown by producer and consumer applications running in the online environment AlreadyClosedException.
Pulsar v2.8.1

Could you provide more information to help us to find problem?

Could you provide more information to help us to find problem?

1.There is no error information in the broker's log.
2.allowAutoTopicCreation=false
3.The memory of zookeeper is set "-Xms2g -Xmx8g -XX:MaxDirectMemorySize=8g", and the GC pause time may reach 4s if the autopurge operation is performed once every 24 hours.

When I tested the environment simulation, I found that if it was in broker.conf, allowAutoTopicCreation=false,
use"bin/pulsar-perf consumer -q 10 -n 1-st shared -s consumersych persistent://public/default/test-string1” commad to test, then execute "bin/pulsar-admin topics delete partitioned topic -f persistent://public/default/test-string1",
after that, pulsar perf throws an error similar to the online environment, but actually my online environment has not done any action.

I think i can work on it.

I have a question about the conditions under which pulsarclientexception will be thrown AlreadyClosedException?

Could you provide more information to help us to find problem?
Now I use jmap dump to generate files. Can I add wechat to chat?


WIP: Feat/multiple reports resolution

Ticket
https://github.com/VirtusLab/strapi-plugin-comments/issues/145 point no. 3
Summary
What does this PR do/solve?
Provides ability to resolve multiple abuse reports at once
Test Plan

Add couple reports against the comment
Open the resolution panel
Mark more than one and click "Resolve selected"

Codecov Report

Merging #148 (688fb29) into master (e794a9b) will increase coverage by 4.87%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   61.97%   66.84%   +4.87%
==========================================
  Files           9        9
  Lines         547      552       +5
  Branches      210      211       +1
==========================================
+ Hits          339      369      +30
+ Misses        205      180      -25
  Partials        3        3

Flag
Coverage Δ

unittest
66.84% <0.00%> (+4.87%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

server/services/admin.ts
29.75% <0.00%> (+24.57%)
:arrow_up:

server/services/common.ts
77.32% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e794a9b...688fb29. Read the comment docs.


[python3] Support arm

Describe the pull request

What does your PR fix?
Fixes #21497

Update the value for supports  to support arm on non windows.
"supports": "!uwp & !(windows & arm)"
Note: No need to test feature.

Any results here?

I will take over this PR.

For pybind11:arm64-windows:
CMake Error at G:/21528/vcpkg/downloads/tools/cmake-3.21.1-windows/cmake-3.21.1-windows-i386/share/cmake-3.21/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Python (missing: Python_LIBRARIES Interpreter Development
  Development.Module Development.Embed) (found version "3.10.1")

Thanks for the fix!


TimePicker 问题，点击左边的图标，当鼠标移到时间器上时，马上就自动隐藏了

ElementUI version

OS/Browers version

Vue version

Reproduction Link

Steps to reproduce
What is Expected?
What is actually happening?

已经修复过了
注意看 changelog

fixed in #210


[Coverity CID :205648]Memory - corruptions in /arch/arc/core/mpu/arc_mpu_v3_internal.h

Static code scan issues seen in File: /arch/arc/core/mpu/arc_mpu_v3_internal.h
Category: Memory - corruptions
Function: arc_mpu_init
Component: Architectures
CID: 205648
Please fix or provide comments to square it off in coverity in the link: https://scan9.coverity.com/reports.htm#v32951/p12996

https://github.com/zephyrproject-rtos/zephyr/pull/20588


Logs all attributes, even if no change has been made

Whenever I update a model, it logs all attributes, not only those that has been changed. Maybe this is default behaviour, idk. However, I expected that it only logged changes, whereas for me, it logs all attributes that I defined in $logAttributes; even if the values are untouched and hence 100% similar.
I've been digging in the code and can't find any options or similar. If I remove the $logAttributes in the model, it logs an empty array (as expected)

@LasseRafn check #57

For Laravel v9 and ActivityLog v4
Im doing this tutorial without tinker, im using the views Blade... Its almost the same think. Just kind of custom code be cause the ActivityLog package update...
use Spatie\Activitylog\Traits\LogsActivity;
use Spatie\Activitylog\LogOptions;

class YourModel extends Authenticable
{

use LogsActivity;

           protected $fillable = [
                      'x',
                       'y',
                       'z',
              ];

            //This function is important, if you dont add this function it will be fail
             public function getActivitylogOptions(): LogOptions
            {
                  return LogOptions::defaults()->logOnly(['*']);
            }

}


Feature request: People property type

Hey Meshcloud! It would be amazing if you could return the people property type. If it just returned as an array joined as a string I think this would be incredibly useful for most purposes using Markdown.
Something like this?
return value.people.map((person) => person.name).join(", ");

We do support downloading image blocks on pages (see https://github.com/meshcloud/notion-markdown-cms#supported-blocks) which are files in notion API, so in theory embedding files as assets in the same way should be trivial to add.
I'm not sure though because you say file property type, which is a page-level attribute. Can you sketch up some markdown and directory structure how this should look like?

Hi @JohannesRudolph, please have a look at PR #14 and let me know what you think


fix: detect dirty state when changes are staged

Fixes #61
Introduces test logic in ci/test_package.sh to avoid regressions

@jbweston, ping


fix 2D display when variables in very different scales

@DanaJomar
When variables are in very different dimensions, say one varies from 1 to 10 and the other one from 1 to 5000, the plot is so narrow that you can't see the image. This is corrected by addig the param aspect="auto"

oh yes, I see it now thanks for the fix!


Life Time Drops Date Filter Addition

Can a filter be added for date before/after for Lifetime Drops?  Similar to what's on Mission Data but for visualization purposes as the filters are spawned from the same process. Thank you, David!!!

Will be added in the next beta

Cool, sounds amazing, David! Appreciate it!

Fixed in latest release.


units: 2.22 -> 2.23

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/gnu-units/versions.
meta.description for units is: Unit conversion tool
meta.homepage for units is: https://www.gnu.org/software/units/
Updates performed

Version update

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.23 with grep in /nix/store/bb8g92z33mgn8zlqll361n9kmnj2jvqr-units-2.23
found 2.23 in filename of file in /nix/store/bb8g92z33mgn8zlqll361n9kmnj2jvqr-units-2.23

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath
octavePackages.miscellaneous
octavePackages.vrml
units

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/bb8g92z33mgn8zlqll361n9kmnj2jvqr-units-2.23 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A units https://github.com/r-ryantm/nixpkgs/archive/08e7fe9f69ce24470baa8823ea40513c45c6add8.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/08e7fe9f69ce24470baa8823ea40513c45c6add8#units

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/bb8g92z33mgn8zlqll361n9kmnj2jvqr-units-2.23
ls -la /nix/store/bb8g92z33mgn8zlqll361n9kmnj2jvqr-units-2.23/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package marked as broken and skipped:

octavePackages.vrml

2 packages built:

octavePackages.miscellaneous
units

Maintainer pings
cc @vrthra for testing.

I want to adopt this.


[BUG] Explicit examples for Open API query parameters do not use the defined "style"

Describe the bug
With the component below the query params are not rendered correctly.
The example below gives the uri: uri: 'http://localhost/api/product/v1/products?page=number&page=size'
To Reproduce
Steps to reproduce the behavior:

Make a GET path with the component below in the parameter
Run the schemathesis CLI command

If possible, please post a minimal version of your API schema that cause this behavior:
components:
  parameters:
    page:
      in: query
      name: page
      description: Page number
      required: false
      style: deepObject
      explode: true
      schema:
        type: object
        additionalProperties: false
        properties:
          number:
            type: integer
            minimum: 1
            maximum: 100
            example: 1
          size:
            type: integer
            minimum: 1
            maximum: 100
            example: 15

Expected behavior
I would expect an uri like:  'http://localhost/api/product/v1/products?page[number]=1&page[size]=15'
Additional context
It looks like this worked in the past:
https://github.com/schemathesis/schemathesis/issues/599

Hi @m-develops,
Thank you for reporting! Unfortunately, I can't reproduce it with the schema you provided.
import requests
import schemathesis
from hypothesis import given, settings

SCHEMA = {
    "openapi": "3.0.2",
    "info": {
        "title": "Test",
        "description": "Test",
        "version": "0.1.0"
    },
    "paths": {
        "/data": {
            "get": {
                "parameters": [
                    {
                        "$ref": "#/components/parameters/page"
                    }
                ],
                "responses": {
                    "200": {
                        "description": "OK"
                    }
                }
            }
        }
    },
    "components": {
        "parameters": {
            "page": {
                "in": "query",
                "name": "page",
                "description": "Page number",
                "required": False,
                "style": "deepObject",
                "explode": True,
                "schema": {
                    "type": "object",
                    "additionalProperties": False,
                    "properties": {
                        "number": {
                            "type": "integer",
                            "minimum": 1,
                            "maximum": 100,
                            "example": 1,
                        },
                        "size": {
                            "type": "integer",
                            "minimum": 1,
                            "maximum": 100,
                            "example": 15,
                        }
                    }
                }
            }
        }
    }
}

schema = schemathesis.from_dict(SCHEMA)

@given(case=schema["/data"]["get"].as_strategy())
@settings(max_examples=25)
def test(case):
    request = requests.PreparedRequest()
    request.prepare(
        method="GET",
        url="http://localhost",
        params=case.query,
    )
    print(request.url)

Running the above with the current Schemathesis version via pytest -s test_example.py outputs the following:
http://localhost/
http://localhost/
http://localhost/
http://localhost/?page=
http://localhost/?page%5Bsize%5D=15&page%5Bnumber%5D=30
http://localhost/?page%5Bnumber%5D=1
http://localhost/?page%5Bnumber%5D=93&page%5Bsize%5D=2
http://localhost/?page%5Bnumber%5D=55
http://localhost/?page%5Bnumber%5D=55&page%5Bsize%5D=16
http://localhost/?page%5Bnumber%5D=98
http://localhost/?page%5Bnumber%5D=98&page%5Bsize%5D=32
http://localhost/?page%5Bnumber%5D=32&page%5Bsize%5D=32
http://localhost/?page%5Bnumber%5D=66
http://localhost/?page%5Bnumber%5D=66&page%5Bsize%5D=73
http://localhost/?page%5Bsize%5D=58&page%5Bnumber%5D=20
http://localhost/?page%5Bsize%5D=58&page%5Bnumber%5D=58
http://localhost/?page%5Bsize%5D=58&page%5Bnumber%5D=1
http://localhost/?page%5Bsize%5D=2
http://localhost/?page%5Bsize%5D=2&page%5Bnumber%5D=7
http://localhost/?page%5Bsize%5D=7&page%5Bnumber%5D=7
http://localhost/?page%5Bsize%5D=7&page%5Bnumber%5D=1
http://localhost/?page%5Bsize%5D=26&page%5Bnumber%5D=55
http://localhost/?page%5Bsize%5D=26&page%5Bnumber%5D=26
http://localhost/?page%5Bsize%5D=26
http://localhost/?page%5Bsize%5D=100

Which corresponds to urlencoded variants of URLs similar to what you provided in the "Expected behavior" section. I also observe the same behavior via Schemathesis CLI running against a JSON file of the schema above.
How did you find those invalid URLs? Was it CLI or Python tests? Did I miss something important in the schema? What Schemathesis / Python / Hypothesis versions are you using?

Hi @Stranger6667,
Thanks for the quick response.
It looks related to using the --checks all with the cli.
When i am using the command below the result depends on using --checks all or not:
schemathesis run --hypothesis-max-examples=10 --store-network-log=test-results/schemathesis-log.yaml --base-url=http://localhost/api specification/dummy-api.yaml
Network log with option --checks all, here only the uri http://localhost/api/data?page=number&page=size is generated:
schemathesis-log-with-checks-all.log
Network log without option --checks all, this still has the uri http://localhost/api/data?page=number&page=size but also others like you mentioned:
schemathesis-log-without-checks-all.log
Yaml file i used:
info:
  title: Test
  description: Test
  version: 0.1.0
paths:
  /data:
    get:
      parameters:
        - $ref: '#/components/parameters/page'
      responses:
        '200':
          description: OK
components:
  parameters:
    page:
      in: query
      name: page
      description: Page number
      required: false
      style: deepObject
      explode: true
      schema:
        type: object
        additionalProperties: false
        properties:
          number:
            type: integer
            minimum: 1
            maximum: 100
            example: 1
          size:
            type: integer
            minimum: 1
            maximum: 100
            example: 15

Thank you for providing more info! The problem is that explicit examples are not transformed to the proper representation. For the schema above, Schemathesis generates Case(query={'page': {'number': 1, 'size': 15}}) as an explicit example (it goes first in the request log). But it should be Case(query={'page[size]': 1, 'page[number]': 15}) instead

The fix is released in 3.7.7. Feel free to reopen the issue if it doesn't fix your case :)

Thank you again for reporting the issue!


Question(s)

Does this mod have a discord?

It does now! Figured it'd be good to make a central spot for my mods, as I have others in the works too.
https://discord.gg/SxN7JtzUyX


google site verification and GA

Closed in https://github.com/GDGND/gdgnd.github.io/commit/f15608fc6bf0d511021663788666f84b0daa7c0e


Still maintained?

First, just want to say this library looks pretty awesome and I've been having a lot of fun getting my hands dirty, thanks for all of this work!
I have encountered some difficulty, specifically with getting values out of events. I found one solution that seems to work here, but it involves defining a function which makes an external call to identity, i.e. its doing some magic type-cast.
Additionally, I wanted to be able to read the values submitted within a form tag, but found that was also super tricky,
e.g.
...
    let handle_submit e =
        let v = e |> _ in (* ??? *)
        set_some_state(v) in
    form
      [| onSubmit handle_submit |]
      [ input [||] [] ]
...

Any ideas on how to fix this?
In addition, I am wondering if this library is still being maintained, as I see there haven't been any commits in a while, and it seems people have gravitated more towards Reason-React. My interest in this repo stems from the fact that I can use an existing OCaml repo without modification.
So, my question: is the library still being maintained, and if not, is there a reason besides lack of interest, or is there a technical reason why this wasn't the right way to solve the problem? If it is the former, I would love to be part of an effort to bring it back up to speed :)

By the way, it may be the case that the library is "finished" in that there are no more changes to be made and it fully captures the intended scope for some version of React. In which case, I'd still be interested in expanding out the documentation provided someone can help me get through the problem-areas I've encountered.

Hey @benbellick
We polished jsoo-react as the minimum to be able to study the possibility to use jsoo at ahrefs. After a lot of debate we settle down with Melange and put all of our resources there. The pain points of jsoo were mostly about integration with JS ecosystem, the boxed primitive types, the lack of community and the familiarity from our frontend team, to name a few.
That being said, there's a bunch of work put into jsoo-react that makes it possible to use and extend, but it's far from finished, if you feel encouraged to pick some issues I'm happy to guide you.
Besides this, I would like to recommend Melange :) since we are making sure it's getting very good support from dune and seamless usage within OCaml codebases.

@davesnx I see, that makes a lot of sense. Thanks for the response!
The way I view the melange vs. jsoo comparison is about whether or not your preference is nice interplay with existing OCaml code vs. existing JS code. In my use case, I wanted to work with an existing OCaml codebase, which is why I wanted to try and make this library work.
One pain point I encountered (which I believe also exists in ReasonReact) is that I had to do some type-unsafe stuff to read in input information from an input field. My understanding is that an html input is always a string, and so it would be safe to have the library just return the value as a string.
As a really out of context example, I have a codebase where I wanted to read in a string from an input here:
(* Some file *)
              input
                [|
                  type_ "number";
                  value (string_of_int divisor_count);
                  onChange (fun e ->
                      e |> React.Event.Form.target |> Getters.value
                      |> int_of_string_opt
                      |> (* more processing... *)
                |]
                [];
(* in getters.mli file*)
val value : Ojs.t -> string [@@js.get]

Point of emphasis is the use of the Getters.value function, which is generated by using gen_js_api. After figuring it out, it isn't so bad, but it took me a while to figure out the exact way to make it work.
Is there a reason why we can't just have a function which takes in the value produced by React.Event.Form.target and returns a string directly? And the same for ReasonReact. If this seems reasonable, I'm happy to open an issue and work on it in both repositories. Thanks!!


fix parent paths, dot filenames

Had problems with patterns like in the added test cases, seems to fix them.

Thx! I'll review this and comment with any suggestions I find.

Looks great. Nice work! merging in now. I will release this and publish a new version of atom-javascript-refactor

Note, I'm also adding more cases to the relative and specifier test fixtures to ensure we have full coverage for this usage.

Thanks, same to you! Just saved me a lot of tedious work :smile:
There was one case it still didn't pick up on - require('path/to/foo')(). I don't know enough about jscodeshift to know how to fix that.

@jspaine is you can open an issue to capture this use case I'll track it down.