CatalogsWithCleanIntegrationTest: Failing test on Windows

This IT serves to document the problem.
When building a project using this gradle plugin in an IDE on windows
it is necessary restart the gradle daemon process (causing it to
release open file handles) to allow a clean to occur after using
this feature (catalogs resolved with classpath:/maven: scheme).
The cause is suspected to be a lost InputStream inside XJC maybe from the
CatalogResolver#resolveEntity(String,String) implementation from
xml-resolver:xml-resolver:1.2 that isn't being closed.  As XJC is built
more like a command line tool no one may have noticed.
Another commit will fix the URLClassLoader.close() use in this plugin
but that does not fix this issue.
Things already tried to resolve it with no luck so far, intercept
CatalogResolver#resolveEntity(String,String) inside this plugin at
ExtensibleCatalogResolver#resolveEntity(String?,String?): InputSource
Here it has been tried to force close all open InputStream's returned
and setByteStream(null).  As maybe the API spec allows this to happen,
forcing the caller to open and manage their own InputStream.
Here it has been tried to collect all open InputStream's returned leaving
them open for the caller, collected into a static ConcurrentLinkedQueue.
Then at the exit point of the XJC plugin somewhere around the end of
AbstractXjcGeneratorWorkAction#doExecute(Options) call a static method
to enumerate and force close them.  Did not fix problem.
Other options to try...
Build a ClassLoader the XJC main gets to use and monitor everything,
then cleanup after it.  Like the ConcurrentLinkedQueue idea above
but with a more global view, not just the XML catalog usage.
Copy the JAR to a $TMPDIR location (outside of gradle $buildDir and
have URLClassLoader reference that.  Security headache?  The JARs end
up littered around not deleted.
These assume XJC is the cause and that use of ClassLoader has visiblity.
Link to commit IT  https://github.com/unbroken-dome/gradle-xjc-plugin/pull/47/commits/066478ff674a7d0055107bbb0ba840d2c9df655b

Link to commit to fix https://github.com/unbroken-dome/gradle-xjc-plugin/pull/47/commits/95625b829887de035f9d024ef75a8201a20253f3
Ugly but effective :)


Cert files not work

hi Xoseperez,

I try to add these lines below to docker-compose.yml

    secrets:
      - ca.pem
      - cert.pem
      - key.pem
# If using custom certificates:
secrets:
  ca.pem:
     file: ./ca.pem
  cert.pem:
    file: ./cert.pem
  key.pem:
    file: ./key.pem

I create SSL Cert follow this guideline https://www.thethingsindustries.com/docs/the-things-stack/host/docker/certificates/#using-custom-certificates

i try to import ca.pem to Microsoft Management Console under certificate folder or try to import certificate in Browers but it still now recoginize by browser. Could you please help me with this issue ?

This is a wrapper around the official docker image and it creates the certificates itself... should probably check if there are certificates supplied by the user. Will add this soon.

Hi @hakaiderii
Latest version (1.2.2) supports secrets to provide custom certificates the same way the official image does.


Question concerning installation

Hi,
I have a short question. The locations where I want to deploy a NuGet Gallery, don't always have a visual studio xxxx installed on that server.
What would be the best / recommend way to install the NuGetGallery on a server where I don't have Visual studio installed?
Isn't possible to have access to a 'simple' msi (or other type of installer) to install the NuGet gallery? That would really simplify a lot of things for a lot of ITpros.
It there any plan to add this for example on this github page (or in the powershell gallery for example) as a downloadable package? That would be really great! (Or probably it exists, and I simply missed it?)

Hi @Stephanevg , unfortunately we don't have an MSI package, or other method to simply install the Gallery on a VM with no Visual Studio.
Many users choose to use NuGet.Server instead, which is much simpler to configure: https://docs.microsoft.com/en-us/nuget/hosting-packages/nuget-server
But this depends on your requirements.
If you still would like to deploy NuGetGallery, my recommendation will be to start with deploying the Gallery on a machine with VS installed, according to the instructions in our Readme. After you are done with setting up the web.config to match your requirements, in order to move the Gallery to a different machine, install on that machine .NET Framework 4.6, a SQL DB and IIS/IIS express. Copy the NuGetGallery folder as is, and set IIS to use it.

Hi @skofman1
Thanks for answer!
Could it be possible that you guys make that available (via a Feature request) ?
It is really a struggle for non developpers to implement a NugGet Server.
Having a MSI would really simplify the complete installation process, and be of a big help for the entiere community.

Hey there @Stephanevg! Can you explain why you would like to setup your own instance of the NuGet Gallery? The Gallery is

Sorry for the noise - I closed this issue by accident 😅
An MSI would certainly simplify the Gallery's installation! Out of curiosity, why are you trying to setup your own instance of the NuGet Gallery? Like @skofman1 mentioned, many users run NuGet.Server instead as it is easier to install.

no worries @loic-sharma :)
My primary need is to setup a nuget.server it to be able to deploy a package using PowerShell (Install-Package). The possibility to 'easily' host a package is a component that is missing- Today, for that reason, and this https://github.com/OneGet/oneget/issues/6 most sysadmins tend to go towards competitors product (such as Chocolatey).

@Stephanevg , the purposes of NuGet and Chocolatey are different. NuGet hosts packages to be used by .NET developers while Chocolatey hosts software. Both use similar protocols to install packages.
The simplest way to host packages without the need to install anything is by using a folder on a local/network folder.  Checkout the instructions here: https://docs.microsoft.com/en-us/nuget/hosting-packages/local-feeds

There's a similar issue already tracked here: https://github.com/NuGet/NuGetGallery/issues/2397
Closing as duplicate.


NCCL issue training with two GPUs

I ran into this issue (https://github.com/NVIDIA/nccl/issues/1125)  when trying to replicate the instructions from the README. Since the blog posts mentions that the training was done on two GPUs is there a workaround for the NCCL issue with 1 or 2 GPUs?
Ran
$ python train.py --model_name meta-llama/Llama-2-70b-hf --batch_size 2 --context_length 2048 --precision bf16 --train_type qlora --use_gradient_checkpointing true --use_cpu_offload true --dataset alpaca --reentrant_checkpointing true
The error trace looks like -
torch.distributed.DistBackendError: NCCL error in: ../torch/csrc/distributed/c10d/ProcessGroupNCCL.cpp:1691, internal error - please report this issue to the NCCL developers, NCCL version 2.19.3
ncclInternalError: Internal check failed.
Last error:
Attribute busid of node nic not found

I haven't encountered that issue before. Can you try the fix suggested here by doing export CUDA_VISIBLE_DEVICES=1, 0 and seeing if that changes things?

I think that trick only works if you have more than two cards and this way you can make 0,1 not be the first two. In any case I just tried this workaround and unfortunately it doesnt work. Will try to compile nccl from source with this patch and see if that fixes things - https://github.com/NVIDIA/nccl/issues/1125#issuecomment-1878385150


Added sort by date published and popularity for news

With reference to #3
Added sort-by options : Top, Date Published, Popularity.
Changed the newsApi end point from '/top-headlines' to '/everything' with source as a query parameter so as to use sorting options.


TODO: Core: Test: TestBase: Investigate slow method at 65k iterations with long text string

@gubanotorious could you explain more about this issue?

I didn't create it, I just created the card.  Someone put a TODO in the code - I believe it was @AboimPinto.   Search the code for the comment / issue number for more detail.


Option to include passed checks in result output

This library is quickly becoming the recommended option for automatic IaC policy validation within CI pipelines.  Most of these CI applications include a way of publishing and/or displaying test results - unit tests, integration tests, and now security scans.
The current result output only shows failed tests.  There are two problems I see with this --

If no checks applied, the user is given a false sense of security that their package is good to go.  Imagine this in the case of unit tests - the lack of tests is not the same as "all tests passed".

For users with a significant number of custom checks, it's hard to identify which ones applied to a particular Terraform module.

Ideally, there should be a way to output all of the checks that applied, as well as the result status - Passed or Failed.  This could be enabled via a command line argument (--extended-output).  This would allow CI pipelines to automatically publish all applicable checks, or fail builds that did not have a proper number of checks applied (i.e. must have at least one check).

Opened #627 to solve for this. Waiting on feedback from the maintainers.

Hey @Malagari - commented on the original PR https://github.com/tfsec/tfsec/pull/624#issuecomment-785376642

Thanks @owenrumney, I'll take a look at the snippet you referenced and see if I can make something work there.  Admittedly this was a first pass at the problem and it started to touch more places than I would have liked.  Now that I'm more familiar with the repo, I'll see if there's a way I can simplify the solution.  I'm going to kill #627 in the meantime to not clutter the PR list.

That's cool @Malagari  - we're always welcoming off contributions and I'm more than happy to work through this one with you. See what you come up with and I'll sleep on it and see what I wake up with. it may not be the option I think it is but worth a look!

This seems to be way cleaner than the first pass I took at it.  I still need to update the default formatter, but the output is generating correctly with less intrusion in to the rest of the codebase.  The Scanner object could also eventually take a set of options rather than passing in individual parameters from the startup.
https://github.com/Malagari/tfsec/pull/2/files

Hey @Malagari  - sorry for the delay in merging, its in now


Confusing assertion message with different prototypes

Given a test:
  it("should give helpful messages", function() {
    function Foo() {this.x = 10;}
    let a = {x: 10};
    let b = new Foo();
    expect(a.constructor).toBe(Object);
    expect(b.constructor).toBe(Foo);
    expect(a).toEqual(b);
  });

the test fails (rightfully) on the last assertion, but the message gives you:
      Error: Expected { x: 10 } to equal { x: 10 }
      + expected - actual

which isn't helpful.
Shouldn't the message tell me that the objects compare as different because they have a different constructor?

Currently, is-equal returns a boolean, so this info might be hard to detect. However, I could see a parallel API that returned a reason for not being equal. @mjackson, let me know if this is something you'd find helpful here.

Another way around that could possibly be to detect the situation "X and Y compare as different but the resulting diff is empty" and work out a different message in that case.

I ended up making this anyways - upgrade to v1.5.0 of is-equal, and require('is-equal/why') to get a function that returns the empty string when is-equal would return true, otherwise it returns a string with the reason for the inequality.

Thanks, @ljharb.
Turns out generating good default error messages is one of this library's main responsibilities; something I didn't really anticipate when I first built it.
I'm happy to accept a PR if you'd like to take a shot at a better error message here @Kos.

Closing this for now. Please feel free to make a PR if it's a pain point.


Can't resolve 'animated/lib/targets/react-dom'

I get this error in  react-swipeable-views: 0.13.4  version
AND
"@material-ui/core": "^4.8.0",
"@material-ui/icons": "^4.5.1",
"react": "^16.12.0",
"react-dom": "^16.12.0",
import Animated from 'animated/lib/targets/react-dom
I check react-swipeable-views/package.json compare myproject package.json
It is missing ”animated": "^0.2.1" ？

Duplicate of #564


Not Downsizing to new iframe height

Hi, I am using a bootstrap template, and when you resize the page so that it has a very small width, when returning to the full width, the iframe does not resize.
In the log it states that no iframe resize detected, but there was in fact a change in the size.
Only when I refresh the page does the height of the iframe resize to encompass the content.

See #70 for some suggestions on working around this bug.


Correct Typing in IPC Schemas

COMMIT_MSG to be elucidated
This commit fixes the type definitions in ipc_field to match that in the
schema definitions: https://github.com/apache/arrow/blob/main/format/Schema.fbs#L82-L430.

This PR should only be merged after #29 .

Also this PR will fail against main as it will break the Rust modelling.


Fix 'out of memory' failures when calculating statistics of large HCs

#2997

@AronNovak please review


❓ [Question] How do you install torch-tensorrt (Import error. no libvinfer_plugin.so.8 file error)?

❓ Question

ImportError: libnvinfer_plugin.so.8: cannot open shared object file: No such file or directory
cuda and cudnn is installed well.
I installed pytorch and nvidia-tensorrt well in conda environment
and then install torch-tensorrt via pip
pip3 install torch-tensorrt -f https://github.com/pytorch/TensorRT/releases

but when I import torch-tensorrt, it gives importError
ImportError: libnvinfer_plugin.so.8: cannot open shared object file: No such file or directory
>>> import torch_tensorrt
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/user_name/miniconda3/envs/pytorch/lib/python3.9/site-packages/torch_tensorrt/__init__.py", line 11, in <module>
    from torch_tensorrt._compile import *
  File "/home/user_name/miniconda3/envs/pytorch/lib/python3.9/site-packages/torch_tensorrt/_compile.py", line 2, in <module>
    from torch_tensorrt import _enums
  File "/home/user_name/miniconda3/envs/pytorch/lib/python3.9/site-packages/torch_tensorrt/_enums.py", line 1, in <module>
    from torch_tensorrt._C import dtype, DeviceType, EngineCapability, TensorFormat
ImportError: libnvinfer_plugin.so.8: cannot open shared object file: No such file or directory

What you have already tried
>>> import torch
>>> torch.cuda.is_available()
True
>>> torch.cuda.device_count()
8
>>> torch.cuda.current_device()
0
>>> torch.cuda.get_device_name(0)
'NVIDIA RTX A5000'
>>> torch.__version__
'1.12.0'
>>> import tensorrt

Environment

Build information about Torch-TensorRT can be found by turning on debug messages

PyTorch Version (e.g., 1.0): 1.12

CPU Architecture: x86_64

OS (e.g., Linux): Linux

How you installed PyTorch (conda, pip, libtorch, source): conda

Build command you used (if compiling from source):

Are you using local sources or building from archives:

Python version: 3.9.7

CUDA version: 11.4

GPU models and configuration: NVIDIA RTX A5000

Any other relevant information:

Additional context

I followed this(https://github.com/pytorch/TensorRT/issues/1026#issuecomment-1119561746)
and fixed the problem

I encountered this problem because the version of tensorrt is 10.0.1, I fixed the problem，pip install tensorrt==8.6.1


vector_comm.py _update_move_base_params error

It looks like inside of the experimental gain tuning branch, vector_comm.py changes the function call definition to _update_move_base_params
Specifically it goes from:
 def _update_move_base_params(self,config): to  def _update_move_base_params(self):
This causes an error because this function subscribes to the topic /move_base/DWAPlannerROS. The exact line is:
rospy.Subscriber("/move_base/DWAPlannerROS/parameter_updates",Config,self._update_move_base_params).
Since the 2nd argument is no longer in the definition for _update_move_base_params, ros throws an error:
[ERROR] [WallTime:<PHONE_NUMBER>.388957] bad callback: <bound method VectorDriver._update_move_base_params of <vector.vector_comm.VectorDriver instance at 0x7f0896ed9b00>> Traceback (most recent call last):   File "/opt/ros/indigo/lib/python2.7/dist-packages/rospy/topics.py", line 720, in _invoke_callback     cb(msg) TypeError: _update_move_base_params() takes exactly 1 argument (2 given)
What was the reason for removing the config argument? And what should be the fix? Remove the subscriber or add the argument back in.

The argument was accidentally removed should be (self,config). I can update it if you want.

Got it, thanks! I can go ahead and update it. no worries!

For some reason when doing the formal merge into the master the problem went away. Maybe when I merged the first time into a branch, I did it wrong.
Anyways, closing since this isn't an issue anymore.


Remove "Something went wrong" prefix on error messages

This sort of thing should be handled at the end client level.
From https://github.com/getAlby/lightning-browser-extension/pull/3066#pullrequestreview-1919348400

Fixed by https://github.com/getAlby/nostr-wallet-connect-next/pull/95


Next version

Added

size method
contains method

Removed

Pull Request Test Coverage Report for Build 10

0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.923%

Totals

Change from base Build 4:
0.0%

Covered Lines:
1

Relevant Lines:
1

💛  - Coveralls


Allow to configure keys to select password

For example I start typing but the password I need is a choice that is not immediate. It would be great to allow for Tab for example to select the key I want. Like, instead of having to press the Down/Up keys, I could use Tab/Shift+Tab, or the sort Ctrl+j/Ctrl+k, etc..
Great software, thanks!

Good idea, I think shortcuts for Tab/Shift+Tab would be sensible to have by default.
Different shortcuts could then be set in the configuration file.


Fix: For multiple trees

If there is more than one tree (more than one root element with null parent_id) I need filter the trees using modifyChildQueryUsing, but there is no efect on root elements, and it's not possible to show ONLY elements of one tree, insted the plugin show elements of the filtered tree plus other roots elements of different trees.

modifyQueryUsing is for the root level.
modifyChildQueryUsing is for sub levels.

@AquaroTorres

Thanks !


Specify settings .env file with TAKAHE_ENV_FILE

Allows specifying the settings file using TAKAHE_ENV_FILE=whatever.env with .env as the default.
TAKAHE_ENV_FILE=test.env pytest
TAKAHE_ENV_FILE=local.env python manage.py runserver

If you rebase the tests should pass and I can merge this.
FWIW, I landed a commit to automatically use test.env when pytest is running, so that should solve your actual problem here with less typing.

Rebased

I tweaked the PR because the explicit Settings(env_file=...) overrides for every manage.py because pytest is in my venv.

Yeah, this is better than my hack from last night!


duplicit ccxt\Exchange::request() removed

PHP Fatal error:  Cannot redeclare ccxt\Exchange::request() in /app/inc/ccxt/ccxt.php on line 1211

Thx, this is left over after a recent change. Merging!


hi. do you have any video for explain ?

@pyvim

Hi, @glerinsonum. You mean videos for explanation that how works this package? Anyway I haven't any video.

@pyvim
I would like to knows How I can do and what I can do with this script that contains syntax of python.
I love Maltego Program. Sincerely. Bro. Friend.
I'm focused to Pipl.com https://github.com/piplcom/piplapis-python
I would your help. Tell me one example. That to learn how i can do I to have view the statistics of piplapis into Maltego. https://pipl.com/api/
There said email ( input<EMAIL_ADDRESS>Output. name, education, username, address.
Tell me and send me video, how I can works with python using pipl to Maltego, or ruby. please.
i beseech thee. be this favour voluntarity for me.
God bless you. For the API key, is sample_key.

@pyvim Make one video. To learn. How I can works with python. for Maltego.

SDAS

@pyvim SA

Make one video. To learn. How I can works with python. for Maltego.
CORDIALLY. THANK YOU.  @pyvim


MediaSession

Hello TAG!
I'm requesting a TAG review of:

Name: MediaSession API
Specification URL: https://wicg.github.io/mediasession/
Explainer: https://github.com/WICG/mediasession/blob/master/explainer.md
Example code:

https://xxyzzzq.github.io/sandbox/media-session/full-test.html
https://beaufortfrancois.github.io/sandbox/media-session/playground.html

Primary contacts: @xxyzzzq @mounirlamouri

Further details (optional):

Relevant time constraints or deadlines: we would like to ship in Chrome M-57, so preferably before Feburary.
[x] I have read and filled out the Self-Review Questionnare on Security and Privacy. The assessment is here.
[x] I have reviewed the TAG's API Design Principles

We'd prefer the TAG provide feedback as (please select one):

[x] open issues in our Github repo for each point of feedback
[ ] open a single issue in our Github repo for the entire review
[ ] leave review feedback as a comment in this issue and @-notify

@slightlyoff notes: there should be by-design similarity to image file types from Notifications API & Manifest file. We should avoid proliferating types of image metadata formats...

Explainer looks nice! All the following feedback is based on reading the explainer...

The term MediaSession seems odd given what the feature does (I acknowledge that this comes from Andriod). Seems more like a "Media Control Extensions"
metaData and playbackState, do these represent the last set value or the state that the UA is in? These may need to be Async if the APIs will represent the UA's current state.
Should 'muted' be included in the MediaSessionAction enum? e.g., many browsers have an option to 'mute' a tab--is this a scenario that should be included?
For the 'artwork' (MediaImage), are these the right members for good responsive image design? Have the RICG folks been contacted? I think they'd have a good perspective.
Might be nice to be able to have more direct control over a particular action-handler, e.g., especially for the play/pause state changes. E.g., is there an opportunity to provide input for an action handler, as opposed to just metadata input?
No way to unsetActionHandler? What happens if you set the same action handler twice?
There's lots of potential metadata to include, how/why did you pick this particular subset? e.g., why not genre, year, etc.? (Not sure if you saw this 2014 Recommendation "Metadata API for Media Resources 1.0"? http://www.w3.org/TR/2014/REC-mediaont-api-1.0-20140313/. It's part of the Semantic-web line of documents, but does have some specific metadata fields that might be thoughtfully considered.)
Have the "remote playback API" folks been contacted? There may be an opportunity to unify some of  these concepts with those concepts? (https://github.com/w3ctag/spec-reviews/issues/145)
MediaSession as global instance... various platforms will certainly have their conventions. The management of mediaSession between a single apps iframes and between multiple tabs in a browser environment seem like essentially the same problem. If there is a security concern then consider [SecureContext], but otherwise, I wonder if adding author-management for this complexity is worth the effort. I have a hunch UA's will do the right thing, and even if they don't, the OS will need to do the right thing when brokering access between Apps and sites (even in different browsers) all competing for the mediasession instance. I'm not sure to what extent it makes sense to try to solve this problem in the spec.

Thanks for the feedback, I'm replying to these individual issues.

Our pleasure! Keeping this issue open--we'll check-in again at our next F2F to see how the individual linked issues are coming along. Thanks again--we're very happy to be able to help!

I'll be following up on the individual issues. We are otherwise done with this parent review issue. Thanks for asking for TAG review!


Bug tô export APK html

Godot version
4.0
System information
Android
Issue description
there is a bug in godot on mobile when i make a project in godot mobile when i export in apk or html the export option is out of scale and the bug has not been resolved i would like to solve this long bug so i can export my projects i hope that be resolved long and thank you
Steps to reproduce
Export APK html without out of scale
Minimal reproduction project
Simulator hand spinned in godot

out of scale

What does this mean? Is it outside of the window? Then this is a duplicate of #73130

the bug has not been resolved

Have you reported it? Has anyone? If it is not the bug above, why would it have been solved by itself?

Em sáb., 3 de jun. de 2023 14:02, A Thousand Ships @.***>
escreveu:

out of scale
What does this mean? Is it outside of the window? Then this is a duplicate
of #73130 https://github.com/godotengine/godot/issues/73130
the bug has not been resolved
Have you reported it? Has anyone? If it is not the bug above, why would it
have been solved by itself?
—
Reply to this email directly, view it on GitHub
https://github.com/godotengine/godot/issues/77811#issuecomment-1575071231,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3IC6RXMWVBBLQA4SWM2USLXJNU25ANCNFSM6AAAAAAYZMRTLM
.
You are receiving this because you authored the thread.Message ID:
@.***>

Did you mean to send an empty reply?

Duplicate of https://github.com/godotengine/godot/issues/73130.


Feature request: Simplify XmlSwitchPipe with session keys

Describe the issue
The XmlSwitchPipe has an attribute sessionKey and getInputFromSessionKey, which I find quite confusing, as they have different behaviors. I think usage would be simplified if the sessionKey-attribute could be deprecated in some way, using the getInputFromSessionKey. I'm not sure how this could be done while keeping compatbile with the current XmlSwitchPipe-implementation.
Reporter
Ricardo

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Screenshots
If applicable, add screenshots to help explain your problem.
Configuration
Please provide the configuration of the Pipe or Receiver with the problem.

Input
Please provide an example of the input message.
Alternatively, provide a Ladybug report.

Environment
Please go to the console of your Frank, click on 'Information' and copy-paste the results here.

Additional Environment

DBMS: [e.g. Oracle, MSSQL, MariaDB, MySql, PostgreSQL]
Browser: [e.g. Chrome, Safari, Edge, Firefox]

Additional Context
Add any other context about the problem here. (f.e. ladybug report / test adapter with larva test)

Duplicate of #806


[Review]  Event RPC

Part of #966
#[derive(Debug, Clone)]
pub struct AnnotatedMoveOSEvent {
    pub event: Event,
    pub sender: AccountAddress,
    pub tx_hash: Option<H256>,
    // pub event_data: Vec<u8>,
    pub timestamp_ms: Option<u64>,
    // pub block_height: Option<u64>,
    pub parsed_event_data: AnnotatedMoveStruct,
}

Should we include the tx_hash in the Event? If needed, we should record the tx_hash with Event in the EventStore.
Should we include the timestamp_ms and when to fill the timestamp?
parsed_event_data is not unified with other Annotated structs.

I suggest removing the tx_hash and timestamp, making the Event a pure event.
@baichuan3 @wow-sven

ok, I will remove tx_hash and timestamp, and unify the parsed_event_data


Fixed #62: Rancher agent connection retry handling

Added a sleep to the for loop, and have it waiting 10 minutes for the
server to come available. Also, added some additional logging to let
users know it is attempting to reach server, unable to reach or can
reach.

Sanitize the url in the method. I did a quick scan, and it wasn't immediately obvious we are dumping the CATTLE_URL var to a log file in other places.

LGTM


a11y: avatar group aria-label and i18n

From https://github.com/vaadin/vaadin-avatar/issues/10#issuecomment-656802750

anonymous should be customizable (i18n)
<vaadin-avatar-group>should get an additional aria-label with an i18n-able string like "Currently active users"

Just an idea; add a count of current active users as variable. "Currently {{count}} active users"


[Bug]: cargo shuttle init: Could not query the latest version of shuttle-runtime

What happened?
While running cargo shuttle init, after selecting the web framework it panics with Could not query the latest version of shuttle-runtime
Version
cargo-shuttle 0.14.0 (but I have also tested 0.13.0 with the same problem)
Which operating systems are you seeing the problem on?
Linux
Which CPU architectures are you seeing the problem on?
ARM64
(specifically I'm running asahi linux on mac mini)
6.2.0-asahi-11-1-edge-ARCH  aarch64 GNU/Linux
Relevant log output
# Short backtrace

thread 'main' panicked at 'Could not query the latest version of shuttle-runtime', cargo-shuttle/src/init.rs:985:33
stack backtrace:
   0: rust_begin_unwind
             at /rustc/2c[...]74/library/std/src/panicking.rs:575:5
   1: core::panicking::panic_fmt
             at /rustc/2c[...]74/library/core/src/panicking.rs:64:14
   2: cargo_shuttle::init::get_latest_dependency_version
   3: cargo_shuttle::init::cargo_shuttle_init
   4: cargo_shuttle::Shuttle::run::{{closure}}
   5: cargo_shuttle::main::{{closure}}
   6: tokio::runtime::park::CachedParkThread::block_on
   7: tokio::runtime::runtime::Runtime::block_on
   8: cargo_shuttle::main
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

# Full backtrace and context

❯ RUST_BACKTRACE=full cargo shuttle init
How do you want to name your project? It will be hosted at ${project_name}.shuttleapp.rs.
✔ Project name · tststststs

Where should we create this project?
✔ Directory · tstststs

Shuttle works with a range of web frameworks. Which one do you want to use?
· axum

thread 'main' panicked at 'Could not query the latest version of shuttle-runtime', /home/oatman/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cargo-shuttle-0.14.0/src/init.rs:985:33
stack backtrace:
   0:     0xaaab01446a1c - std::backtrace_rs::backtrace::libunwind::trace::ha0deed5dc23ee505
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93:5
   1:     0xaaab01446a1c - std::backtrace_rs::backtrace::trace_unsynchronized::h924cfead2aff5443
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
   2:     0xaaab01446a1c - std::sys_common::backtrace::_print_fmt::h199f3cb0058a3585
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/std/src/sys_common/backtrace.rs:65:5
   3:     0xaaab01446a1c - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h862f17917f2c8213
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/std/src/sys_common/backtrace.rs:44:22
   4:     0xaaab0146f424 - core::fmt::write::h7f12d187fe61b77e
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/core/src/fmt/mod.rs:1254:17
   5:     0xaaab0144189c - std::io::Write::write_fmt::h6048f25565582382
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/std/src/io/mod.rs:1698:15
   6:     0xaaab01446864 - std::sys_common::backtrace::_print::hd38d7361d7d2a4e1
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/std/src/sys_common/backtrace.rs:47:5
   7:     0xaaab01446864 - std::sys_common::backtrace::print::h7e4a2ed892f5173f
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/std/src/sys_common/backtrace.rs:34:9
   8:     0xaaab014485d4 - std::panicking::default_hook::{{closure}}::ha8056671b69510e2
   9:     0xaaab014483c4 - std::panicking::default_hook::h406699bc7969c49c
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/std/src/panicking.rs:288:9
  10:     0xaaab01448a7c - std::panicking::rust_panic_with_hook::he2bac1390d9d1f8a
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/std/src/panicking.rs:691:13
  11:     0xaaab0144896c - std::panicking::begin_panic_handler::{{closure}}::h9044bbe96c2c9391
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/std/src/panicking.rs:582:13
  12:     0xaaab01446e48 - std::sys_common::backtrace::__rust_end_short_backtrace::h5c73f57261750ceb
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/std/src/sys_common/backtrace.rs:150:18
  13:     0xaaab014486f0 - rust_begin_unwind
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/std/src/panicking.rs:578:5
  14:     0xaaab00767770 - core::panicking::panic_fmt::hf5f60a2900cd370d
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/core/src/panicking.rs:67:14
  15:     0xaaab009f2160 - cargo_shuttle::init::get_latest_dependency_version::h154a11fb46854cd3
  16:     0xaaab009f16b4 - cargo_shuttle::init::cargo_shuttle_init::h21782a8cce89764c
  17:     0xaaab008d05a0 - cargo_shuttle::Shuttle::run::{{closure}}::hb077998f0ab5a30d
  18:     0xaaab008f190c - tokio::runtime::park::CachedParkThread::block_on::hc969d5cb36ef51b3
  19:     0xaaab007fa7fc - tokio::runtime::scheduler::multi_thread::MultiThread::block_on::h7dcc1d5579a2c64a
  20:     0xaaab00869bb4 - tokio::runtime::runtime::Runtime::block_on::h4e0c7de1ba0fc8ae
  21:     0xaaab00832e78 - cargo_shuttle::main::h285b5bc1aa2e8f75
  22:     0xaaab008e40dc - std::sys_common::backtrace::__rust_begin_short_backtrace::h0b34db2bbaa178da
  23:     0xaaab007baac8 - std::rt::lang_start::{{closure}}::hdc84d690a6807c4e
  24:     0xaaab01437aac - core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once::h5a23cd6a07960a38
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/core/src/ops/function.rs:287:13
  25:     0xaaab01437aac - std::panicking::try::do_call::h8ca37b37e4fae4e7
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/std/src/panicking.rs:485:40
  26:     0xaaab01437aac - std::panicking::try::h74252f8f81d27dc4
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/std/src/panicking.rs:449:19
  27:     0xaaab01437aac - std::panic::catch_unwind::ha74244482ee54d1e
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/std/src/panic.rs:140:14
  28:     0xaaab01437aac - std::rt::lang_start_internal::{{closure}}::he25f3312cd172cc2
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/std/src/rt.rs:148:48
  29:     0xaaab01437aac - std::panicking::try::do_call::h5f3204433e0f8bf6
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/std/src/panicking.rs:485:40
  30:     0xaaab01437aac - std::panicking::try::hcb3971aa1c7de371
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/std/src/panicking.rs:449:19
  31:     0xaaab01437aac - std::panic::catch_unwind::h097a52ed34474c08
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/std/src/panic.rs:140:14
  32:     0xaaab01437aac - std::rt::lang_start_internal::h6547485790670ccc
                               at /rustc/c609da59d9fc05b1c7dc879d79700ccd8140b5fc/library/std/src/rt.rs:148:20
  33:     0xaaab00832f7c - main
  34:     0xffff28f47b80 - <unknown>
  35:     0xffff28f47c60 - __libc_start_main
  36:     0xaaab00767cf0 - _start
                               at /build/glibc/src/glibc/csu/../sysdeps/aarch64/start.S:81
  37:                0x0 - <unknown>

Duplicate declaration

[X] I have searched the issues and there are none like this.

I have installed cargo-shuttle both from source and cargo binstall no dice

inside the discord walled garden, we are talking about how this seems to be caused by sparse registries not playing well with cargo-edit. I've switched to stable which I believe shouldn't have sparse enabled, but it's not worked either.
Debugging continues...!

Ah, so sparse registries are enabled by default on nightly? I'm not sure just switching it back to git will fix the bug either, I think the cache would still need to be updated. So I would try the suggestions from discord, running cargo update/upgrade/fetch in a crate which depends on shuttle-runtime v0.14.0. Unfortunately I still haven't reproduced the bug, so I can't test it myself

Trying those now.
I think you might be able to just rustup default nightly to reproduce it?

I've tested this on both my aarch64 m1 machines, and my x86_64 surface pro, and I think because I always use nightly, this upstream bug happens on all of them, despite switching to stable.

The upstream problem seems to be caused by https://github.com/killercup/cargo-edit/issues/841

Thank you for getting to the bottom of this and finding a work-around! For visibility I'll reiterate what I said regarding this issue in our conversation on discord:
We have been planning a refactor of our init function to rather bootstrap projects from templates (e.g. our examples repo). That would resolve this issue as well, since we would no longer rely on cargo-edit to fetch the latest version. We're about to start on this next week, and it should be good to go within a few weeks. Until them I'll look around for an intermediate solution, and I'll also add your work-around to our docs to minimize the time people need to spend debugging this.

MSRV By Framework, plus notes

actix

1.59
https://github.com/search?q=repo%3Aactix%2Factix-web nightly&type=code

axum

1.60

rocket

https://rocket.rs/v0.5-rc/guide/upgrading/#stable-release-channel
"Our recommendation is to develop locally on the nightly channel but build and deploy for production on the stable channel."

tide

?

tower

1.49.0

poem

1.64.0

salvo

1.59

serenity

1.53

async closures

https://github.com/serenity-rs/serenity/blob/46087950bb197817df19f16da0f457202d6f93ca/examples/e05_command_framework/src/main.rs#L265

2024 https://lang-team.rust-lang.org/roadmaps/roadmap-2024.html#looking-forward

hyper/warp

?

thruster

"stable"

The Problem
The biggest problem I see is that Rocket has always (and still does today) recommend nightly, and many projects have nice-to-have or quality-of-life features that they mention in their documentation, though not as strongly as Rocket. This will mean that a small number of users are using nightly.
Nightly breaks shuttle init, and once broken it's not obvious how to un-break it, likely you'd have to come here to figure it out.
I look forward to the fix! Thank you for your work, team :-)

Oh, I just realised the beta channel is also 1.70.0, which would break this too.

I just added reproducible fix instructions to my comment here https://github.com/shuttle-hq/shuttle/issues/821#issuecomment-1525317860

Perfect, thanks! One of our contributors has volunteered to help out with the refactor of init as well, so we should be able to get this resolved soon. :crossed_fingers:

Wonderful news! Thanks to everyone who is helping out :tada:
My extremely scientific poll of my audience suggest that this fix could improve the lives of 20% of your potential users!

@oddgrd can this be closed now? Not sure if the problems that @iamwacko referred to here are solved.

Yes, it was caused by cargo-edit trying to get_latest_version, so it should be fixed since we  no longer rely on that.


[chart]Big number display tooltip with incorrect time granularity in dashboard

Expected results
A big number chart is added to a dashboard with "time grain" override.
The tooltip of the big number chart in the dashboard should show the data point with respect to the selected "time grain" in dashboard.
For example,

When select week, the tooltip should show start date -- end date, e.g. 2021-04-19 -- 2021-04-23.
When select day, the tooltip should show date, e.g. 2021-04-19.

Actual results
When looking at the chart on explore page, it works correctly.

However, the same chart in the dashboard behave unexpectedly.

When select week, the tooltip show month, e.g. Mar 2020
When select day, the tooltip shows month, e.g. Mar 2020.

How to reproduce the bug

Create a big number chart.
Put it in a dashboard with time grain override.
Set time grain.
Check tooltip.

Environment
(please complete the following information):

superset version: superset version
python version: python --version
node.js version: node -v

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Only the first chart's tooltip is wrong, all the other charts in the same dashboard are correct.

I inspected the react component with chrome debugger and the first chart received "P1M" while the second chart received "P1W".

@kristw thanks for the details~ are you planning to fix it 😅
cc @EBoisseauSierra


Moved link time build options out of compile time options

Moved link time build options out of compile time options
Issue
A link time option is set in the compile time options and has no effect, the file is not stripped and remains a larger size.
I ran with cmake version 3.23.1 and compiler GNU 9.4.0
To repeat:
mkdir build
cd build
cmake -DCMAKE_BUILD_TYPE=Release ..
make VERBOSE=1
ls -l libisotp.so
file libisotp.so

Current code:
-rwxr-xr-x 1 xxxxx xxxxx 16800 Feb  9 12:43 libisotp.so
libisotp.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=bb5eaf2d1b5224dc699c21a17cf76d283f06cbef, not stripped

Running after PR change:
-rwxr-xr-x 1 xxxxx xxxxx 14472 Feb  9 12:43 libisotp.so
libisotp.so: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=5d5c9d947e2c6969e47f7ecae5bf1414d9878751, stripped

The file is smaller and stripped.
No change for the static library build.
Other points to note
The PR used target_link_libraries which is available in cmake version 3.10. If you're happy to move the cmake version up to 3.13, target_link_options may be better.
https://cmake.org/cmake/help/latest/command/target_link_options.html
This issue was originally noticed when compiling with clang (version 13.0.1) which will fail the build with the following error:
[ 50%] Building C object CMakeFiles/isotp.dir/isotp.c.o
clang: error: argument unused during compilation: '-s' [-Werror,-Wunused-command-line-argument]

Below is the make output showing th -s option passed during compiling, but not linking which is resolved in this PR. -O2 is passed at compile time, but -O3 is used by cmake when in release build. During compile, the last optimisation level specified is used, -O2. At link only -O3 is present.
[ 50%] Building C object CMakeFiles/isotp.dir/isotp.c.o
/usr/bin/cc -Disotp_EXPORTS -I/home/xxxxx/temp/isotp-c -O3 -DNDEBUG -fPIC -fPIC -Werror -Wall -Wno-unknown-pragmas -O2 -s -MD -MT CMakeFiles/isotp.dir/isotp.c.o -MF CMakeFiles/isotp.dir/isotp.c.o.d -o CMakeFiles/isotp.dir/isotp.c.o -c /home/xxxxx/temp/isotp-c/isotp.c
[100%] Linking C shared library libisotp.so
/usr/local/bin/cmake -E cmake_link_script CMakeFiles/isotp.dir/link.txt --verbose=1
/usr/bin/cc -fPIC -O3 -DNDEBUG -shared -Wl,-soname,libisotp.so -o libisotp.so CMakeFiles/isotp.dir/isotp.c.o

Hi there!
Thanks for the contribution!
Seems I completely oversaw that.
Changes seem good and workflows pass. LGTM.
I don't have anything to test currently, but as you've not changed any of the logic, I don't see any issues that may arise. I'll merge it with the master branch.


[BUG]: ndarray<> fails on read-only buffer object

Problem description
when accessing numpy array with ndarray<>, nanobind fails when binding on a read-only object.
seems that
https://github.com/wjakob/nanobind/blob/a965f5b85a800ffe98856b184e528df1ecd05501/src/nb_ndarray.cpp#L165
PyBUF_RECORDS requires write permission. errors ValueError: buffer source array is read-only
Reproducible example code
#include <nanobind/nanobind.h>
#include <nanobind/ndarray.h>

namespace nb = nanobind;

NB_MODULE(myext, m) {
  m.def("foo", [](nb::object o) {
    auto a = nb::cast<nb::ndarray<>>(o);
    printf("%ld\n", a.ndim());
  });
}

>>> import myext
>>> import numpy as np
>>> a = np.broadcast_to(1, (2, 3))
>>> b = np.arange(16)
>>> myext.foo(a)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
RuntimeError: nanobind::cast_error
>>> myext.foo(b)
1

nanobind currently doesn't have the concept of a read-only tensor and so refusing this unsafe cast seems reasonable. I might consider adding a special nb::ndarray<nb::ro, ..> annotation (perhaps with alias `nb::ndarray_ro<..>`` ) that is able to accept such arrays. Would that fix your problem?

I might consider adding a special nb::ndarray<nb::ro, ..> annotation

At least one other user would definitely appreciate that! :-)
I could probably offer a PR, if you like.

Yes, a special annotation fixed my problem and make semantics clear. Looking forward to this feature!

@eirrgang @zingdle can you take a look at PR #217 and let me know if this addresses your needs?

@eirrgang @zingdle can you take a look at PR #217 and let me know if this addresses your needs?

Ah, okay. The C++ accessors on the ndarray object will respect the const-ness, and the dltensor member is private anyway. The dlpack interface necessarily loses the const-ness, but there's no way around that until dlpack grows "read-only" semantics.
I'm not seeing any modification to the o.__dlpack__ support. Shouldn't it be disabled or force a copy when re-sharing a buffer that was provided read-only, or from a const object? (How does numpy handle that?) Sorry, I'm less familiar with the dlpack use cases. If this is within the scope of the comment about dlpack ignoring ro, maybe there should be a stronger admonition or warning.
For numpy and buffer protocol users, though, it looks great to me! Thanks!

The dlpack interface necessarily loses the const-ness, but there's no way around that until dlpack grows "read-only" semantics.

DLPack supports a read-only flag as of https://github.com/dmlc/dlpack/pull/113. But the details of the Python interface aren't worked out, and in any case nobody is using this new versioned flavor of DLPack yet. I plan to update nanobind once there are some implementations of the interface to test against..

I'm not seeing any modification to the o.dlpack support. Shouldn't it be disabled or force a copy when re-sharing a buffer that was provided read-only, or from a const object? (How does numpy handle that?) Sorry, I'm less familiar with the dlpack use cases. If this is within the scope of the comment about dlpack ignoring ro, maybe there should be a stronger admonition or warning.

nanobind generally ignores constness in function parameters and return values. Ignoring the read-only flag in the DLPack interface seems to me inline with this overall behavior. PR #217 implements a limited form of const tracking for nd-arrays because we need this flag to be able to fully interface with NumPy (which is far more strict).


Support Pasting Properly on all iOS devices

I store my login credentials for my osu! account in 1Password. When I go to log into osu! on my iPhone, I discovered there's no easy way to paste my password into the ingame password text box without having to type it in manually.
While there is a system-level "paste" button on iPad, there isn't one on iPhone. And since the ingame textboxes are separate from UIKit, at present, tapping the text box won't make the system "Paste" popover graphic appear.
There's probably 2 ways we can go about making this whole experience better.

(Easy) Add a custom accessory bar to the iOS iPhone keyboard that contains a custom paste icon. This would bring it in line with the same behaviour as iPad.
(Harder, but better) Extend the text box behaviour in osu!framework that when a user taps on it while it's already selected, it'll present the system "Paste" popover.

Out of curiosity, does three-finger-anti-pinch not work already?

Oh! I hadn't tried that before.
I just gave it a try. It works if you do it over the keyboard. If you try and do it over the osu! UI, it'll dismiss the login dialog.
That's a decent enough workaround during development. But keeping in mind that's an iOS 13 only API, so it won't work on older supported iOS versions.

Cool. I can make it work over the game as well.

(Noting this here mainly for my benefit.)
Talking with smoogi today. Apparently this might be easier to do completely in-engine, which would have the benefit of supporting Android as well.
Next place to check is IHasContextMenu interface in order to add a contextual menu to TextBox.
Could be temporarily cased for mobile devices via something like ContextMenuContainer with presentation logic such as  if (mouseLeftDown && timeSinceMouseLeftDown > 1000 && mobileDevice) showMenu();


python312Packages.glyphslib: 6.7.2 -> 6.8.0

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.glyphslib is: Bridge from Glyphs source files (.glyphs) to UFOs and Designspace files via defcon and designspaceLib
meta.homepage for python312Packages.glyphslib is: https://github.com/googlefonts/glyphsLib
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 6.8.0 with grep in /nix/store/c1ca3f3w4vrwlbxjvrjxdilhq0lm6gzr-python3.12-glyphslib-6.8.0
found 6.8.0 in filename of file in /nix/store/c1ca3f3w4vrwlbxjvrjxdilhq0lm6gzr-python3.12-glyphslib-6.8.0

Rebuild report (if merged into master) (click to expand)

20 total rebuild path(s)

20 package rebuild(s)

First fifty rebuilds by attrpath

fira-math
fontbakery
python311Packages.babelfont
python311Packages.collidoscope
python311Packages.fontbakery
python311Packages.fontfeatures
python311Packages.fontmake
python311Packages.glyphsets
python311Packages.glyphslib
python311Packages.glyphtools
python312Packages.babelfont
python312Packages.collidoscope
python312Packages.fontbakery
python312Packages.fontfeatures
python312Packages.fontmake
python312Packages.glyphsets
python312Packages.glyphslib
python312Packages.glyphtools
smc-chilanka

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/c1ca3f3w4vrwlbxjvrjxdilhq0lm6gzr-python3.12-glyphslib-6.8.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.glyphslib https://github.com/r-ryantm/nixpkgs/archive/54bba9e856766964b7b04ae56a4c6bba29bd040f.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/54bba9e856766964b7b04ae56a4c6bba29bd040f#python312Packages.glyphslib

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/c1ca3f3w4vrwlbxjvrjxdilhq0lm6gzr-python3.12-glyphslib-6.8.0
ls -la /nix/store/c1ca3f3w4vrwlbxjvrjxdilhq0lm6gzr-python3.12-glyphslib-6.8.0/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

6 packages failed to build:

fira-math
python311Packages.fontmake
python311Packages.fontmake.dist
python312Packages.fontmake
python312Packages.fontmake.dist
smc-chilanka

28 packages built:

fontbakery (python312Packages.fontbakery)
fontbakery.dist (python312Packages.fontbakery.dist)
python311Packages.babelfont
python311Packages.babelfont.dist
python311Packages.collidoscope
python311Packages.collidoscope.dist
python311Packages.fontbakery
python311Packages.fontbakery.dist
python311Packages.fontfeatures
python311Packages.fontfeatures.dist
python311Packages.glyphsets
python311Packages.glyphsets.dist
python311Packages.glyphslib
python311Packages.glyphslib.dist
python311Packages.glyphtools
python311Packages.glyphtools.dist
python312Packages.babelfont
python312Packages.babelfont.dist
python312Packages.collidoscope
python312Packages.collidoscope.dist
python312Packages.fontfeatures
python312Packages.fontfeatures.dist
python312Packages.glyphsets
python312Packages.glyphsets.dist
python312Packages.glyphslib
python312Packages.glyphslib.dist
python312Packages.glyphtools
python312Packages.glyphtools.dist

Maintainer pings
cc @barinov274 for testing.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 334577 at 54bba9e8 run on x86_64-linux 1

4 packages failed to build:

fira-math
python311Packages.fontmake
python312Packages.fontmake
smc-chilanka

14 packages built successfully:

fontbakery (python312Packages.fontbakery)
python311Packages.babelfont
python311Packages.collidoscope
python311Packages.fontbakery
python311Packages.fontfeatures
python311Packages.glyphsets
python311Packages.glyphslib
python311Packages.glyphtools
python312Packages.babelfont
python312Packages.collidoscope
python312Packages.fontfeatures
python312Packages.glyphsets
python312Packages.glyphslib
python312Packages.glyphtools

This appears to break the fontmake tests
        attributes = (
>           data.names.get(glyph_name)
            or data.alternative_names.get(glyph_name)
            or data.production_names.get(glyph_name)
            or {}
        )
E       AttributeError: 'list' object has no attribute 'names'

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.glyphslib is: Bridge from Glyphs source files (.glyphs) to UFOs and Designspace files via defcon and designspaceLib
meta.homepage for python312Packages.glyphslib is: https://github.com/googlefonts/glyphsLib
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 6.8.1 with grep in /nix/store/c9rhfn0pjayffxi3jwp0s3pbrv7b8rjb-python3.12-glyphslib-6.8.1
found 6.8.1 in filename of file in /nix/store/c9rhfn0pjayffxi3jwp0s3pbrv7b8rjb-python3.12-glyphslib-6.8.1

Rebuild report (if merged into master) (click to expand)

20 total rebuild path(s)

20 package rebuild(s)

First fifty rebuilds by attrpath

fira-math
fontbakery
python311Packages.babelfont
python311Packages.collidoscope
python311Packages.fontbakery
python311Packages.fontfeatures
python311Packages.fontmake
python311Packages.glyphsets
python311Packages.glyphslib
python311Packages.glyphtools
python312Packages.babelfont
python312Packages.collidoscope
python312Packages.fontbakery
python312Packages.fontfeatures
python312Packages.fontmake
python312Packages.glyphsets
python312Packages.glyphslib
python312Packages.glyphtools
smc-chilanka

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/c9rhfn0pjayffxi3jwp0s3pbrv7b8rjb-python3.12-glyphslib-6.8.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.glyphslib https://github.com/r-ryantm/nixpkgs/archive/1282b23db2a628e74b634dc15e145543a46a498d.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/1282b23db2a628e74b634dc15e145543a46a498d#python312Packages.glyphslib

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/c9rhfn0pjayffxi3jwp0s3pbrv7b8rjb-python3.12-glyphslib-6.8.1
ls -la /nix/store/c9rhfn0pjayffxi3jwp0s3pbrv7b8rjb-python3.12-glyphslib-6.8.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

34 packages built:

fira-math
fontbakery (python312Packages.fontbakery)
fontbakery.dist (python312Packages.fontbakery.dist)
python311Packages.babelfont
python311Packages.babelfont.dist
python311Packages.collidoscope
python311Packages.collidoscope.dist
python311Packages.fontbakery
python311Packages.fontbakery.dist
python311Packages.fontfeatures
python311Packages.fontfeatures.dist
python311Packages.fontmake
python311Packages.fontmake.dist
python311Packages.glyphsets
python311Packages.glyphsets.dist
python311Packages.glyphslib
python311Packages.glyphslib.dist
python311Packages.glyphtools
python311Packages.glyphtools.dist
python312Packages.babelfont
python312Packages.babelfont.dist
python312Packages.collidoscope
python312Packages.collidoscope.dist
python312Packages.fontfeatures
python312Packages.fontfeatures.dist
python312Packages.fontmake
python312Packages.fontmake.dist
python312Packages.glyphsets
python312Packages.glyphsets.dist
python312Packages.glyphslib
python312Packages.glyphslib.dist
python312Packages.glyphtools
python312Packages.glyphtools.dist
smc-chilanka

Maintainer pings
cc @barinov274 for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python312Packages.glyphslib is: Bridge from Glyphs source files (.glyphs) to UFOs and Designspace files via defcon and designspaceLib
meta.homepage for python312Packages.glyphslib is: https://github.com/googlefonts/glyphsLib
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 6.8.2 with grep in /nix/store/6z1i400i34jvgrpa9iyg8w9q010520w9-python3.12-glyphslib-6.8.2
found 6.8.2 in filename of file in /nix/store/6z1i400i34jvgrpa9iyg8w9q010520w9-python3.12-glyphslib-6.8.2

Rebuild report (if merged into master) (click to expand)

20 total rebuild path(s)

20 package rebuild(s)

First fifty rebuilds by attrpath

fira-math
fontbakery
python311Packages.babelfont
python311Packages.collidoscope
python311Packages.fontbakery
python311Packages.fontfeatures
python311Packages.fontmake
python311Packages.glyphsets
python311Packages.glyphslib
python311Packages.glyphtools
python312Packages.babelfont
python312Packages.collidoscope
python312Packages.fontbakery
python312Packages.fontfeatures
python312Packages.fontmake
python312Packages.glyphsets
python312Packages.glyphslib
python312Packages.glyphtools
smc-chilanka

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/6z1i400i34jvgrpa9iyg8w9q010520w9-python3.12-glyphslib-6.8.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python312Packages.glyphslib https://github.com/r-ryantm/nixpkgs/archive/3b3cb4c2d18cc0683009e3e44ca5a6cec745c7af.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/3b3cb4c2d18cc0683009e3e44ca5a6cec745c7af#python312Packages.glyphslib

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/6z1i400i34jvgrpa9iyg8w9q010520w9-python3.12-glyphslib-6.8.2
ls -la /nix/store/6z1i400i34jvgrpa9iyg8w9q010520w9-python3.12-glyphslib-6.8.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

34 packages built:

fira-math
fontbakery (python312Packages.fontbakery)
fontbakery.dist (python312Packages.fontbakery.dist)
python311Packages.babelfont
python311Packages.babelfont.dist
python311Packages.collidoscope
python311Packages.collidoscope.dist
python311Packages.fontbakery
python311Packages.fontbakery.dist
python311Packages.fontfeatures
python311Packages.fontfeatures.dist
python311Packages.fontmake
python311Packages.fontmake.dist
python311Packages.glyphsets
python311Packages.glyphsets.dist
python311Packages.glyphslib
python311Packages.glyphslib.dist
python311Packages.glyphtools
python311Packages.glyphtools.dist
python312Packages.babelfont
python312Packages.babelfont.dist
python312Packages.collidoscope
python312Packages.collidoscope.dist
python312Packages.fontfeatures
python312Packages.fontfeatures.dist
python312Packages.fontmake
python312Packages.fontmake.dist
python312Packages.glyphsets
python312Packages.glyphsets.dist
python312Packages.glyphslib
python312Packages.glyphslib.dist
python312Packages.glyphtools
python312Packages.glyphtools.dist
smc-chilanka

Maintainer pings
cc @barinov274 for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.


Callumhaslam map

Updates to MAP credential layer 3 complete.
Please review! Thanks, Bree

please merge to the main branch when complete.


Update Solution to VS 2015

Update the basic solution to 2015 and remove StyleCop dependency.

Completed conversion and unit tests. StyleCop inspector still has a lot of bugs, so I'm not going to enforce it for now.


Update version to 1.1.25-2 on staging

Update version to 1.1.25-2

🚀 Deployed to staging by @OSBotify in version: 1.1.25-2 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Implement defgen and defgenp

defgen and defgenp will be used to define generator functions and private generator functions. There is a defmatchgen in the tailored library on master which will be used as the backing for this.
List of work:

[ ]  Add defgen and defgenp to list of function types the Translator module looks for.
[ ]  Add defgen and defgenp to list of function types the ModuleCollector module checks for when finding functions in a module
[ ]  Update Def.make_function and Function.make_anonymous_function to add generator flag to JavaScript Function AST as well as use defmatch or defmatchgen where applicable
[ ]  Update Defmodule module with any changes if needed

defgen hello("Parker") do
  "hello Parker"
end

defgen hello(name) do
  "hello #{name}"
end

defgen hello() do
  "hello World"
end

These will also be able to use yield which is defined at #185


Possibility of webpack based version of this seed

With @gdi2290 very exciting announcement made here:
https://github.com/AngularClass/angular2-webpack-starter/issues/1686
Curious what the interest is in having a webpack based version of this seed which may be based off https://github.com/AngularClass/angular2-webpack-starter
The gulp based workflow of this seed works well however some folks prefer webpack over gulp and I've always wanted to build a webpack version of this for my own purposes, just polling.

@NathanWalker I am maintaining a similar (not fully working, missing NS atm) version of this seed based on AngularClass's starter. https://github.com/JonnyBGod/angular2-webpack-advance-starter
Would be glad to collaborate on this.

@JonnyBGod excellent! Yes will do. We may want to start from scratch when the overhaul is complete in above but I'll start to look at what you got thanks!

I vote for the webpack version

@NathanWalker I am up for starting from scratch and just take what I learned from my repo.
We should start discussing the vision for the new project. What are the goals and what we don't want to do.
I was hoping at some point to make it an angular/cli extension, but this depends on the plugin architecture they will adopt. In my opinion angular/cli does what we need for web projects, just lacks the extensibility we need to enable electron and nativescript apps in the same project.
I have been also thinking on a more monorepo lerna style approach where we would have 3 different projects within the same repo, web, desktop and mobile. Probably easier to keep and coordinate but also easy to share parts between them.

+1 for webpack support. Webpack rocks!

@NathanWalker would be nice to have this project run on webpack. We'll most likely be able to contribute as currently it's a much better foundation to move forward. We found ourselves strugling with asset size optimizations. This is an area where webpack can come in with support for tree shaking and lazy-loading

We have to face it.... systemJS is stale.... I've given it months, combined with JSPM, and "amazing" undocumented settings, all in the waste bin... Even the NG team has evicted towards Webpack.
And I do NOT want to sound negative!!!!! We all, you guys, everybody, are / is working to the extreme here! Every other few days there is a new release, enabling a startup of 2.5 to 4.0 seconds, with AOT... It is only frustrating to see (an)other project(s) is struggling to keep this pace....
I've followed the angular-seed with great interest since last year June, a lot has changed, and not only for the good. And now TeamMaestro comes along. Maybe shaking things up a bit, who knows....? Even though the angular-seed(-advanced) is doing a great job.....

For now definitely take a look here:
https://github.com/TeamMaestro/angular-native-seed
Just as proof of concept and for more options the expansion of AngularClass seed may happen in future.


Add textAndIcons to (non-article) body

Part of #9849

[x] Add TextAndIcons to Page content type

Second point: the pre-existing cases of MediaObjectList that we want to update are ones where the images used are iconographic and display at a constricted width, more in line with how we've created Text and icons

Sounds good, thank you for explaining!


tty detection for mintty

Over time, ripgrep has grown its own tty detection code which includes a hack for (seemingly reliably) detecting the presence of a tty on Windows inside mintty. Would you be interested in a PR that brings it to this crate?
There isn't much code, but you can see it all here: https://github.com/BurntSushi/ripgrep/blob/master/src/atty.rs
There is a pretty long issue on the topic of mintty detection here, which includes the provenance of the hack: https://github.com/BurntSushi/ripgrep/issues/94 --- Spoiler alert: it's what git does.

Absolutely! It never amazes me how complicated windows makes solving this seemingly simple problem


Fix Update Tests in the last commit by editing person util

Actually after thinking about it, I think equals() and hashcode() should account for all variables instead, I should've added the optional variables to hashcode instead of removing it from equals


MS Graph API Request Timeout Querying Azure Active Directory Service

A large environment with many thousands of user and group objects.
Timeouts happen after about 30 minutes of consistent querying using delta queries with $expand criteria for user manager, group members and group owners.
Objects are requested and read in pages.
Timeouts also occur when looking up user objects by object id expanding the "manager" field.
Some timeout happen after about 30 minutes of waiting, others, after over 14 hours.

Timeout querying groups (took over 14 hours to get this error after sending the request query):
Microsoft.Graph.ServiceException: Code: timeout  Message: The request timed out.
---> System.Threading.Tasks.TaskCanceledException: A task was canceled.
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Graph.HttpProvider.d__19.MoveNext()
--- End of inner exception stack trace ---
at Microsoft.Graph.HttpProvider.d__19.MoveNext()  --- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Graph.HttpProvider.d__18.MoveNext()  --- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Graph.BaseRequest.d__35.MoveNext()  --- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Graph.BaseRequest.d__31`1.MoveNext()  --- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Graph.GroupDeltaRequest.d__2.MoveNext()  --- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
Timeout querying a user by object id (took about 30 minutes to get this timeout):
System.AggregateException: One or more errors occurred.
---> Microsoft.Graph.ServiceException: Code: timeout  Message: The request timed out.
---> System.Threading.Tasks.TaskCanceledException: A task was canceled.
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Graph.HttpProvider.d__19.MoveNext()
--- End of inner exception stack trace ---
at Microsoft.Graph.HttpProvider.d__19.MoveNext()  --- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Graph.HttpProvider.d__18.MoveNext()  --- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Graph.BaseRequest.d__35.MoveNext()  --- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Graph.BaseRequest.d__31`1.MoveNext()  --- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
at Microsoft.Graph.UserRequest.d__6.MoveNext()  --- End of stack trace from previous location where exception was thrown ---
at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)

Intended for MS graph. Filed in error


README Sample Code Improvements

Just tried the sample code from the README on iOS and if you've not asked permission before it will never ask permission with this snippet
var status = await Permissions.CheckStatusAsync<SaveMediaPermission>();

if (status != PermissionStatus.Granted)
    return;

await MediaGallery.SaveAsync(MediaFileType.Video, filePath);

The status will be Unknown and it will leave the method before actually asking for permission.
Additionally, it might be good to note that if you try to save without a file extension, i.e.: await MediaGallery.SaveAsync(MediaFileType.Image, "myScreenshot"); there will be an exception.
Great work btw! Making a video on this soon! :)

@jfversluis Hi. Thanks.
Unfortunately, my English is not very good.And it's hard enough for me to write documentation, But I will try to fix it soon

Don't worry about it! I don't mean write a lot of Docs, just update the sample code here: https://github.com/dimonovdd/Xamarin.MediaGallery#saveasync
So that it works OK with the permissions for iOS.
And an extra bullet here: https://github.com/dimonovdd/Xamarin.MediaGallery#ios-1
Something like:

Make sure to add a file extension when calling SaveAsync(), else it will result in an exception

Let me know if you need any help :)


mitmproxy: 6.0.2 -> 7.0.2

Bisected through mitmproxy to find the test that was causing the build to fail.
Turns out it's https://github.com/mitmproxy/mitmproxy/commit/36ebf11916704b3cdaf4be840eaafa66a115ac03
My guess is that this is caused by the fact that builds are not executed inside of a terminal, although that's just a guess.
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 137436 at 8ac8c33d run on aarch64-linux 1

2 packages built successfully:

mitmproxy (python39Packages.mitmproxy)
python38Packages.mitmproxy

Result of nixpkgs-review pr 137436 run on x86_64-linux 1

2 packages built:

mitmproxy (python39Packages.mitmproxy)
python38Packages.mitmproxy


Update docs for contributors

@bors r+

:pushpin: Commit ab0c1df54bafb7e1b30dd0c2b2b19c96c25111aa has been approved by JohnTitor
It is now in the queue for this repository.

:hourglass: Testing commit ab0c1df54bafb7e1b30dd0c2b2b19c96c25111aa with merge 2b6b8f3d6ed5cb349033cc7373de1cef778dc7be...

:broken_heart: Test failed - checks-actions

@bors retry

:hourglass: Testing commit ab0c1df54bafb7e1b30dd0c2b2b19c96c25111aa with merge d12151cbd4167a9fe8fc58745063033a0acc0417...

:boom: Test timed out

@bors retry

:hourglass: Testing commit ab0c1df54bafb7e1b30dd0c2b2b19c96c25111aa with merge 9b2a163b005646e14c6547e50d872d399ae273a3...

:sunny: Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 9b2a163b005646e14c6547e50d872d399ae273a3 to main...


Inconsistencies in the handling of misspelled URLs

Bug description
I've tried to implement a login workflow with the REST API and I encountered some difficulties with the endpoints ending with a trailing /.
A bit of context
The first endpoint is /api/v1/security/login. But for some reason, I added a / at the end (it looked like /api/v1/security/login/) and when I tried the query, it promptly responded with :
{
    "errors": [
        {
            "message": "404 Not Found: The requested URL was not found on the server. If you entered the URL manually please check your spelling and try again.",
            "error_type": "GENERIC_BACKEND_ERROR",
            "level": "error",
            "extra": {
                "issue_codes": [
                    {
                        "code": 1011,
                        "message": "Issue 1011 - Superset encountered an unexpected error."
                    }
                ]
            }
        }
    ]
}

Okay, this is a problem I agree with 100%... It's my fault and the API interrupts the request, telling me I've probably misspelled the URL.
By deleting the unnecessary /, I get my access_token; all's well.
The issue
Assuming the / was a problem, I quickly removed it from the other two endpoints (/api/v1/security/csrf_token/ & /api/v1/security/guest_token/).
Then I tried to request these endpoints and got a timeout (from my backend which is configured to TO after 10s).
Seeing as the first endpoint TELLS me that I've made a mistake, it didn't occured to me that it could be a spelling issue...
No timeout from Superset, no error, nothing...
So I think my issue is more of an open question than a real problem: why do the second and third endpoints end in / and why do they behave differently from the first?
Thank you for reading through this and I hope you have a wonderful day.
How to reproduce the bug
Correct way to handle spelling issue of endpoint

take the /api/v1/security/login endpoint and add a trailing /
send the request
get a wonderful error response

Wrong way

take either /api/v1/security/csrf_token/ or /api/v1/security/guest_token/ and remove the trailing /
send the request
grow old with your grand-kids waiting for a response

Screenshots/recordings
No response
Superset version
master / latest-dev
Python version
3.9
Node version
16
Browser
Chrome
Additional context
No response
Checklist

[X] I have searched Superset docs and Slack and didn't find a solution to my problem.
[X] I have searched the GitHub issue tracker and didn't find a similar bug report.
[ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

I guess that the login endpoint behave differently because it's handled by flask-login?
If so, I get that it's not an issue per se but it's still a bit confusing 🤔


Command line interface

It would be cool if you could add a cli so one can call $ ulid on the command line.

The JS implementation is pretty minimal – what about opening this issue for a different implementation like oklog/ulid?

I think the JS version is really easy to install via npm. That's why it's a good place for the cli.
My workaround at the moment is this script:
#! /usr/bin/env node

const ulid = require('/Users/adrian/.config/yarn/global/node_modules/ulid')
const value = ulid()

process.stdout.write(value.toLowerCase())

Good point, ease of installation is important! It wouldn't be hard for you to turn that script into a CLI, according to the NPM docs.

I could do. Will it be merged @alizain ?

Yep, a CLI is totally fine, I'd be happy to accept a PR for it.


CUDA_SETUP: WARNING!

The following error occurred when using the 'Python - m bitsandbytes' instruction:
===================================BUG REPORT===================================
Welcome to bitsandbytes. For bug reports, please submit your error trace to: https://github.com/TimDettmers/bitsandbytes/issues
================================================================================
CUDA_SETUP: WARNING! libcudart.so not found in any environmental path. Searching /usr/local/cuda/lib64...
C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\site-packages\bitsandbytes\cuda_setup\main.py:136: UserWarning: WARNING: The following directories listed in your path were found to be non-existent: {WindowsPath('/usr/local/cuda/lib64')}
  warn(msg)
CUDA SETUP: WARNING! libcuda.so not found! Do you have a CUDA driver installed?
C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\site-packages\bitsandbytes\cuda_setup\main.py:136: UserWarning: WARNING: No libcudart.so found! Install CUDA or the cudatoolkit package (anaconda)!
  warn(msg)
C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\site-packages\bitsandbytes\cuda_setup\main.py:136: UserWarning: WARNING: No GPU detected! Check your CUDA paths. Proceeding to load CPU-only library...
  warn(msg)
CUDA SETUP: Loading binary C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\site-packages\bitsandbytes\libbitsandbytes_cpu.so...
argument of type 'WindowsPath' is not iterable
CUDA_SETUP: WARNING! libcudart.so not found in any environmental path. Searching /usr/local/cuda/lib64...
CUDA SETUP: WARNING! libcuda.so not found! Do you have a CUDA driver installed?
CUDA SETUP: Loading binary C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\site-packages\bitsandbytes\libbitsandbytes_cpu.so...
argument of type 'WindowsPath' is not iterable
CUDA SETUP: Problem: The main issue seems to be that the main CUDA library was not detected.
CUDA SETUP: Solution 1): Your paths are probably not up-to-date. You can update them via: sudo ldconfig.
CUDA SETUP: Solution 2): If you do not have sudo rights, you can do the following:
CUDA SETUP: Solution 2a): Find the cuda library via: find / -name libcuda.so 2>/dev/null
CUDA SETUP: Solution 2b): Once the library is found add it to the LD_LIBRARY_PATH: export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:FOUND_PATH_FROM_2a
CUDA SETUP: Solution 2c): For a permanent solution add the export from 2b into your .bashrc file, located at ~/.bashrc
Traceback (most recent call last):
  File "C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 187, in _run_module_as_main
    mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
  File "C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 146, in _get_module_details
    return _get_module_details(pkg_main_name, error)
  File "C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 110, in _get_module_details
    __import__(pkg_name)
  File "C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\site-packages\bitsandbytes\__init__.py", line 7, in <module>
    from .autograd._functions import (
  File "C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\site-packages\bitsandbytes\autograd\__init__.py", line 1, in <module>
    from ._functions import undo_layout, get_inverse_transform_indices
  File "C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\site-packages\bitsandbytes\autograd\_functions.py", line 9, in <module>
    import bitsandbytes.functional as F
  File "C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\site-packages\bitsandbytes\functional.py", line 17, in <module>
    from .cextension import COMPILED_WITH_CUDA, lib
  File "C:\Users\Administrator\AppData\Local\Programs\Python\Python310\lib\site-packages\bitsandbytes\cextension.py", line 22, in <module>
    raise RuntimeError('''
RuntimeError:
        CUDA Setup failed despite GPU being available. Inspect the CUDA SETUP outputs above to fix your environment!
        If you cannot find any issues and suspect a bug, please open an issue with detals about your environment:
        https://github.com/TimDettmers/bitsandbytes/issues

If you could help me, thank you very much!

I used the 'nvcc -- version' and 'set cuda' instructions to check the version of cuda
d:\Downloads\MiniGPT-4-main\MiniGPT-4-main>nvcc --version
nvcc: NVIDIA (R) Cuda compiler driver
Copyright (c) 2005-2023 NVIDIA Corporation
Built on Wed_Feb__8_05:53:42_Coordinated_Universal_Time_2023
Cuda compilation tools, release 12.1, V12.1.66
Build cuda_12.1.r12.1/compiler.32415258_0

d:\Downloads\MiniGPT-4-main\MiniGPT-4-main>set cuda
CUDA_PATH=C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.1
CUDA_PATH_V12_1=C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.1

Did you get it working?

Check, if your 'CUDA_HOME' environment variable is set correctly. If not, do so.

This issue might be resolved by upgrading via pip install -U bitsandbytes. However, note that Windows is currently not supported. You can find more information here: #30

Bitsandbytes was not supported windows before, but my method can support windows.（yuhuang）
1  open folder J:\StableDiffusion\sdwebui，Click the address bar of the folder and enter CMD
or WIN+R, CMD  。enter，cd /d J:\StableDiffusion\sdwebui
2  J:\StableDiffusion\sdwebui\py310\python.exe -m pip uninstall bitsandbytes
3 J:\StableDiffusion\sdwebui\py310\python.exe -m pip uninstall bitsandbytes-windows
4 J:\StableDiffusion\sdwebui\py310\python.exe -m pip install https://github.com/jllllll/bitsandbytes-windows-webui/releases/download/wheels/bitsandbytes-0.41.1-py3-none-win_amd64.whl
Replace your SD venv directory file（python.exe Folder） here（J:\StableDiffusion\sdwebui\py310）


increase the torch.dynamo cache limit size in torch.compile mode

increase cache limit size in torch.dynamo to avoid out of memory issue in torch.compile mode

please add a comment: as this change will be reverted with actual fix
done


feat: Add release notes for 0.53.1

Add release notes for:

https://blog.vega.xyz/incident-report-validator-nodes-down-in-mainnet-2ac2f724d67e

Ready for review but not to be merged until mainnet is full back:

https://stats.vega.trading/


"L" key repeats infinitely after unlocking Windows

I'm loving the new key repeat feature introduced in #541! However it's introduced a small bug. When I press meta+L to lock my computer, then unlock it, the L key is still held down and repeats infinitely until another key is pressed. This happens even after typing my password to unlock (although KMonad is never active in that text box).
Steps to reproduce

Open a text document, make sure the cursor is in a place to type.
Lock your computer with meta+L
Unlock the computer

Expected behavior: Nothing should appear in the text document.
Actual behavior: L's begin to appear until another key is pressed (e.g. llllllllllllllllllllllllllllllllllllllll)

Hey @whitbur,
If I'm reading the situation right:

KMonad receives the 'real' M-L and sets it internally as pressed (which starts the repeat process)
KMonad sends the first simulated M-L to Windows, which then proceeds to lock the screen
In the locked mode, it /looks/ like Windows takes full control of the keyboard
In this locked mode, you release M-L (because the last 3 steps happened before you could release M-L)
When you then unlock windows KMonad gets control again, but the release has already happened so we never learn of it.

An actual fix to this problem seems mind-bending: figure out when Windows takes away our control and then make context-dependent decisions on how to update the state.
A practical fix seems straightforward: I'm thinking that if you were to lock windows with a keymacro KMonad would never get into this mistaken state. You could lock Windows by defining a tap-macro that sends a tap of M-L to Windows. These tap-macros trigger on just a press, tap all of their buttons except the last one (which they only press, and then release when the button is released). However, we can define a tap-macro with a final null-button like this: #(M-L XX).
You could assign that macro to any button that you wish to use to lock windows, or you could have a meta-layer where you rebind all buttons to their Meta'd versions, and then use this macro to ensure that the L in that layer can only be tapped (not pressed).
I hope you can find contentment with the practical fix, because tackling the actual issue seems... unfeasible :D.

It's interesting -- I actually can't get a M-L to go through kmonad. Binding a key to lmet and tapping gets me the windows menu properly, and binding a key to l taps the l key. But M-l and (around lmet l) both output nothing, with no effect.
Logs show that kmonad is trying to output lmet+l. In both cases this is the output with -l debug:
--------------------------------------------------------------------------------
Received event: Press <kp->
Running hooks
Emitting: Press <met>
Registering untimed hook: 1
Emitting: Press <l>

--------------------------------------------------------------------------------
Received event: Release <kp->
Running hooks
Emitting: Release <l>
Emitting: Release <met>

The tap-macro with final null-button also doesn't output anything, here are the logs:
--------------------------------------------------------------------------------
Received event: Press <kp->
Running hooks
Emitting: Press <met>
Emitting: Press <l>
Emitting: Release <l>
Registering untimed hook: 1
Registering untimed hook: 2
Emitting: Release <met>

--------------------------------------------------------------------------------
Received event: Release <kp->
Running hooks

There's a similar problem when hitting ctrl-c to close the program. It hangs until another button is pressed and then repeats ccccccccccccc into the terminal until another key is pressed or released. I suspect this is probably the OS's repeat mechanism, not kmonad's, since the process has already terminated. It's weird that this didn't happen before, though.

It sounds like a limitation around how we capture keyboard input in Windows, which is a lot less robust then under Linux.

It's weird that this didn't happen before, though.
It seems to make sense: before the keyboard would get stuck in a c-is-still-pressed state whenever this happened, but we didn't notice, because we didn't actually start a key-repeat process, and so it fixed itself with further use without any consequences. Now, however, the thread is still running in the background, so it just starts pressing c the moment we wake up. Might also have to do with the fact that, in Windows, repeat events are actually just presses, so to windows it just looks like some is mashing the c key.

Maybe we could try and notice when the OS suspends us and automatically stop any repeat-thread, but that's so out-of-scope at the moment that I wouldn't get my hopes up for the next... demidecade ;).

Looks like supporting key-repeat in Windows cause additional problems.
https://github.com/kmonad/kmonad/issues/315#issuecomment-1051725356

It sounds like a limitation around how we capture keyboard input in Windows, which is a lot less robust then under Linux.

I know this is a little crazy, but what if we didn't ignore key repeat events (on any OS), but instead used them to trigger kmonad repeats? Windows knows it's not repeating the keys, it's not sending repeat events. We'd lose the ability to decide exactly when and how frequently repeat happens, but we'd get more consistent behavior by relying on the OS here.

I know this is a little crazy, but what if we didn't ignore key repeat events (on any OS), and instead used them to trigger kmonad repeats?

I did give this some thought, but I am very strongly against this idea for 2 reasons:

Repeating only makes sense in very specific button circumstances, like when you want to emit an a by holding a. Perhaps also if you want to execute some command over and over on every event-tick. However, for a large collection of our buttons, repeating makes no sense at all (repeating a tap-hold for example, or a layer-toggle is nonsensical). So, semantically 'repeating' is very much something-of-specific-outputs, and I don't want to clutter the semantics of KMonad. In fact, I'm trying to unclutter them further :-).

I think there is a very simple but beautiful pattern that we can capture if we learn to express keyboard inputs not as simple sequences of disjointed events, but as gestures composed of certain sequences. This is still speculative, but I suspect there are some nice abstractions to be found here, and I would like to try to work on those when we've gotten all the IO stuff a bit more... well groomed.

Looks like supporting key-repeat in Windows cause additional problems.

Ahh yeah, these look like the same issue. I should probably merge them. Anyone objecting to moving the conversation to the older issue?

Looks like supporting key-repeat in Windows cause additional problems.

Ahh yeah, these look like the same issue. I should probably merge them. Anyone objecting to moving the conversation to the older issue?

I think it's better to continue the discussion here as this is more specific. The title of that issue may cause confusion. However, to "merge" these, we can re-post important info from that issue here.

Looks like supporting key-repeat in Windows cause additional problems.

Ahh yeah, these look like the same issue. I should probably merge them. Anyone objecting to moving the conversation to the older issue?

I think it's better to continue the discussion here as this is more specific. The title of that issue may cause confusion. However, to "merge" these, we can re-post important info from that issue here.

Hah, you're right. How did I miss the fact that the original issue was very different? Lack of mindfulness. I keep forgetting: "Slow is smooth & smooth is fast". :)

So, should note that Linux sends key repeats with a different code than "down"; down is 1 and repeat is 2. However, Windows will repeatedly send down 1 on key repeats instead of a different value.
Here's how I implemented key repeat in my kmonad-inspired project.
https://github.com/jtroo/kanata/blob/main/src/kanata.rs#L174

On init, store a map of physical key position -> valid repeat outputs.
When an OS repeat event occurs for a physical key, compare its mapping in 1. against the active keycodes in kanata
If there is an intersection in the 2 sets of

the 1. mapping
active keycodes
then send the corresponding key event for the active keycode

It's not perfect but I haven't encountered any practical issues with this implementation yet.

Here's how I implemented key repeat in my kmonad-inspired project.

@jtroo: Waaa, that's a cool project :-). I'm flattered that you liked KMonad so much you wanted to roll something similar.
In regards to your solution, it seems like a very viable solution. My problem currently is lack of time and higher priorities (both inside and outside of KMonad). I also want to separate the model representation of the keymap from the actual IO-performing of the remap first, but then this kind of solution only in the KeyIO bit might make a lot of sense. That way we can keep the model pure and easy to reason about, but provide a more robust form of key-repeat.
Also, I'm guessing there might be things I can do with catching signals and auto-terminating all repeat-threads in the background etc.etc. Just.. so many problems, with so many more potential solutions, but  only 10 fingers, and programming goes button by button by button by button..

@jtroo:
Nice project! :+1:
Quick question: Inkanata, does key-repeat work in Linux VT / TTY? Assuming you didn't implement a kanata-native key-repeat functionality.

@MuhammedZakir Thanks!
Key repeat in kanata is based solely on waiting for the OS repeat events from the /dev/input device and it does indeed still work in a TTY.


preliminary bladebit2 disk support

Draft for:

[ ] Deleting tmp files, needs bb2d to name them accordingly, may involve handling a subdirectory.

@altendky anything I can do to help getting this merged?

  Is it working alright for you?  I guess we can leave the temp file cleanup just not implemented at this point.

Kicking CI

Not yet, but I'm considering to try and test plotman + bladebit + soon to be plot compression. As far as I understand, that's not available yet in the regular madmax plotter and should be available with bladebit.

Plot compression hasn't gotten to beta yet from Chia.  I'll have to add some options for the compression control as well.  Anyways, I'll try to get this merged to development and you can do some testing if you have a chance and I'll plan to get Bladebit CUDA and compression support when they are out anyways.  Feel free to ping with an issue when they are released for beta if I don't make up a PR first.

I know its not ready yet, but we should probably have the regular bladebit disk working in preparation just in case :)


Misc. GH workflow improvements and hardness

read per commit

ci-awscni

ci-aks

ci-eks

ci-gke

ci-l4lb

@aanm Just in case: none of the triggers above (ci-aks, etc.) have run code from this PR. If you want to test changes to the workflow, you need to switch to pull_request ;)

@aanm Just in case: none of the triggers above (ci-aks, etc.) have run code from this PR. If you want to test changes to the workflow, you need to switch to pull_request ;)

oh nice catch. I've pushed a commit with all uncommented out and all of them worked except one, which is now fixed as well. Thanks