Db\Adapter\Driver\Connection throwing different exceptions

I'm not sure how I am supposed to handle this scenario:
I tested to insert a duplicated constraint in a table (using Sql\Insert), to see what kind of error I'd get, and I got a PDOException thrown by PDO::query(), because I'm using PDO driver. But what if I changed to another driver? I wouldn't get PDOException, but a different one. Shouldn't Driver\[Driver]\Connection make sure to catch specific exceptions thrown by their resources (if they do, like PDO) and throw a common Connection Exception if something was catched? Otherwise I would have to write a catch for every possible exception thrown by all the different drivers. If I'm missing something, what is it? What's the correct way to handle this?

This issue has been closed as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.html


SD Onboarding - Go Live Coordination

Acceptance Criteria

[ ] Confirmed with STLT when they want to start receiving (date)
[ ] Removed quality filter in prod settings = allowNone()
[ ] Removed quality filter in staging settings = allowNone()
[ ] Set Customer status = active

Done.


Unify @PlanningId usage across quickstarts

@PlanningId usage is a bit inconsistent across the quickstarts, use it on all problem fact & entity classes.
13.1. @PlanningId
For some functionality (such as multithreaded solving and real-time planning), Timefold needs to map problem facts and planning entities to an ID. Timefold uses that ID to rebase a move from one thread's solution state to another's.
To enable such functionality, specify the @PlanningId annotation on the identification field or getter method, for example on the database ID:
Current status:
timefold-quickstarts/use-cases/employee-scheduling - @PlanningId defined both on planning entity and problem facts
timefold-quickstarts/use-cases/food-packaging - @PlanningId defined on a single planning entity, not on problem facts
timefold-quickstarts/use-cases/facility-location - @PlanningId not used at all

For the quickstarts that switched to UI-has-full-solution-state (school timetabling and vehicle routing* currently), we've also changed the ID type to String. All quickstarts will sooner or later be refactored accordingly.
That new approach has no database, so no need to keep it a number.
Motivation: most users want to reuse their own ID for input data such as an employee (name is not unique and often obfuscated) and that ID type can be anything from a number to an UUID. String always fits.


Mapbox fixes and dataset option

Three change for the Mapbox geocoder:

Added a new option :dataset for Mapbox to specific datasets other than the default "mapbox.places"
Use [long,lat] rather than [lat,long] with Mapbox API
Added tests more generally to catch this sort of bug

Thank you! Only thing I would suggest, in the future, is to make separate commits for each bugfix and feature (ideally, this should have been at least two commits). Small/clean commits are extra important in open source projects where the commit author may be unavailable in the future to help resolve a conflict or trace the origin of a bug.


Minor issues

@teixeirak
I will use this issue to ask you a few things that I need your input with

[x] In HISTORY percent.mortality there is 8 records with value "<<100%" and 184 with "<100%". I am ignoring them to calculate range  (in metadata) but I want to make sure you want to keep that (especially the "<<100%")

[x] In HISTORY plothistoryID.v1 I get 5722 for the max and you had 2477. Is that normal ?

[x] In metadata of HISTORY levels I am replacing the range I find by NA, OK ?

[x] In MEASUREMENTS measurementID.v, I get max = 17172 while yours is 4797. Is that normal ?

[x] In MEASUREMENTS dupcode there is 1 "d", should I replace by "D"?

[x] In MEASUREMENTS dupcode should D/DC, and DC/D be the change to be one or the other ?

[x] In MEASUREMENTS dupcode should D/M and M/D be the change to be one or the other ?

[x] In metadata of PLOTS year.establishment.oldest.trees, why is range "-" and not "##-##" ?

[ ] Once all above is solved. Can I remove range column of all metadata files and keep only Min and Max ?

[ ] Do we want to keep/rename column indicates.site.that.lacks.info.direct.from.pub in SITES ? It does not appear in metadata

[ ] In paper. I get different number of variables than you. Are you looking at primary only and "merging" Carbon and Biomass into individual variables for the count ?

[x] Can  we really compare the number of geographic.area between new and old version since we are not using the same method ? I get 249 for tropical sites (apparently it was 178 before).

[ ]  I (and maybe the reader) need more guidance to fill (and maybe retrieve) the numbers in the following sentence : "Of the 2,731 plot records, 1,206 (44%) contain records of dates of establishment of the oldest cohort of trees, ## (#%) contain records of initiation of a post-disturbance cohort, ## (#%) contain records for one or more major disturbances, ## (#%) contain records for one or more non-stand clearing disturbances, and ## (#%) contain records for one or more management events."

Please leave these
In HISTORY plothistoryID.v1 I get 5722 for the max and you had 2477. Is that normal ?
I think what happened here is that your number refers to the entire version 1, whereas mine refers to only TropForC-db (the published component). Stick with yours.
In metadata of HISTORY levels I am replacing the range I find by NA, OK ?
I'm not sure I understand this question. But on a related note, for all metadata files, please replace range with min, max, and mean (as in sites metadata).*
In MEASUREMENTS measurementID.v, I get max = 17172 while yours is 4797. Is that normal ?
I think what happened here (and above) is that your number refers to the entire version 1, whereas mine refers to only TropForC-db (the published component). Stick with yours.
In MEASUREMENTS dupcode there is 1 "d", should I replace by "D"?
yes
In MEASUREMENTS dupcode should D/DC, and DC/D be the change to be one or the other ?
yes. either is fine
In MEASUREMENTS dupcode should D/M and M/D be the change to be one or the other ?
yes. either is fine
In metadata of PLOTS year.establishment.oldest.trees, why is range "-" and not "##-##" ?
my mistake
Once all above is solved. Can I remove range column of all metadata files and keep only Min and Max ?
Yes, please do
Do we want to keep/rename column indicates.site.that.lacks.info.direct.from.pub in SITES ? It does not appear in metadata
no, I'll delete it for pub version
In paper. I get different number of variables than you. Are you looking at primary only and "merging" Carbon and Biomass into individual variables for the count ?
yes, primary only. There's one part of the text where I merge them, but they are separate in the number presented in the abstract"
Can we really compare the number of geographic.area between new and old version since we are not using the same method ? I get 249 for tropical sites (apparently it was 178 before).
It's not exactly comparable, but should be close. There's a bunch of tropical data that wasn't published in the first version. To double check, you could see how many you get counting only the sites published in the first version (<=503)
I (and maybe the reader) need more guidance to fill (and maybe retrieve) the numbers in the following sentence : "Of the 2,731 plot records, 1,206 (44%) contain records of dates of establishment of the oldest cohort of trees, ## (#%) contain records of initiation of a post-disturbance cohort, ## (#%) contain records for one or more major disturbances, ## (#%) contain records for one or more non-stand clearing disturbances, and ## (#%) contain records for one or more management events."
I will fill this in (and also try to clarify for the reader).

Indeed I get 248 geographic areas records published in first version and 580 new ones.
Also,  do we want a range of establishment.ID in metadata of PLOTS ? or should I keep "-"

Let's delete reference to the old number of plots.

Please remove range for all metadata files, and replace with min, max, and mean. Does that get at your question? (I'm not sure I understand.)

Sorry it was not clear. I am asking if it is relevant to calculate the Min and Max of establishment.ID or if I should keep it blank.

Do you mean the reference of number of geographic.area in the paper when you say "delete reference to the old number of plots." ?

Yes, please do include those. They are relatively meaningless, but should be included as part of the metadata standards.
On Dec 14, 2017, at 3:38 PM, ValentineHerr <notifications<EMAIL_ADDRESS>wrote:
Do you mean the reference of number of geographic.area in the paper when you say "delete reference to the old number of plots." ?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHubhttps://github.com/forc-db/ForC/issues/46#issuecomment-351829049, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGD7joZjFrp8UnbVcJAdjImxu-6BMXnvks5tAYcngaJpZM4RChH3.


Update bug_report.md

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #2659 into master will increase coverage by 0.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2659      +/-   ##
==========================================
+ Coverage   64.67%   65.14%   +0.46%
==========================================
  Files         200      202       +2
  Lines        9844     9773      -71
  Branches     1898     1852      -46
==========================================
  Hits         6367     6367
+ Misses       3205     3134      -71
  Partials      272      272

Impacted Files
Coverage Δ

.../amplify-appsync-simulator/src/mqtt-server/util.ts

...psync-simulator/src/data-loader/dynamo-db/index.ts

...sync-simulator/src/velocity/value-mapper/mapper.ts

...lify-appsync-simulator/src/velocity/util/errors.ts

...mplify-appsync-simulator/src/resolvers/function.ts

...y-appsync-simulator/src/resolvers/unit-resolver.ts

...es/amplify-appsync-simulator/src/velocity/index.ts

...amplify-appsync-simulator/src/mqtt-server/index.ts
0% <0%> (ø)

...y-appsync-simulator/src/schema/directives/index.ts
0% <0%> (ø)

...psync-simulator/src/utils/expose-graphql-errors.ts
0% <0%> (ø)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fea52c...616f5c1. Read the comment docs.

LGTM!


I can't seem to change the font size.

I tried editing size:10 to size:3 but it didn't change.

Did you edit the lua file?
You need to edit style_ass_tags = "", to be style_ass_tags = "{\\fs3}",

Nope, that didn't work :( I Must be doing something wrong, I want it like you have it in the previews, it's MASSIVE for me
https://i.imgur.com/LBufbK4.jpg

That's odd. Do you have a script-opt file for playlistmanager? In case you have then you need to edit the value in there since it will override the lua config.
Like so style_ass_tags={\fs3}, you can also try adjusting scale_playlist_by_window=yes to no if it helps with size.

Changed scale_playlist_by_window=yes, to no as you said.
https://0x0.st/zo0u.png it's still WAY TOO big. Would you like me to upload my configs?

I see. Yes, I could try to reproduce this with your configs.
As a sanity check can you confirm that changing some other of the settings makes a change in behavior. For example edit the playlist_header setting to have some random string in it. After restarting this string should be visible when you open the playlist.

LUA;
https://ghostbin.com/paste/5am3e
.conf
https://ghostbin.com/paste/6mjeq

From whatI can see and what i've added it should work,  just well. Fine? but it's being odd.

You need to either delete your conf file or then edit conf file line 64 to style_ass_tags={\fs3}. The conf file will override the settings in lua file so any changes ton the lua file will have no effect in the presence of a conf file.

Thanks, lmfao. My bad there.