route to get/fetch all products

created a route to get/fetch all products and created the get_products function that returns the list of dictionaries showing the id, name, and expiration date.

Good work, Isaac. I made 2 changes:

Changed the route name from /get_product to /get_products
Changed the return line from jsonify(dict_products, status=200) to jsonify(dict_products), 200

Explaination for 2): Yours was an incorrect usage of jsonify: The jsonify() function is meant to serialize only the first argument into JSON. By passing multiple arguments like dict_products and status=200, you're causing an error. Instead, use jsonify(dict_products) and return the status code separately.


Release Candidate 1.1.0_1

Minor updates and changes, with a possible abandonment of Vero 2

Checks failed, but are currently flawed. They should probably be removed


feat(CI): add git hooks and improve tests to calculate file hash first

What
./install_githooks.sh copies the committed two hooks to .git/hooks.
Add Wasm type that adds a hash method so tests can calculate the expected hash instead of hard coding it.
Why
Prevent users from commit code that won't pass fmt. Also must pass tests and clippy before pushing.
Hard coding hash makes tests fail if the resulting wasm file changes, which can happen for example when upgrading the compiler version or updating deps.
Known limitations
If the hooks are updated devs need to rerun the script.

@leighmcculloch I couldn't figure out how to make this opt-in.  But I could look into that if you'd prefer not forcing this on users.  But I do think it will save CI actions from failing as much.

Also is push all we need?

I don't think cargo-husky has an opt-in built-in. It has an opt-out though with CARGO_HUSKY_DONT_INSTALL_HOOKS=true.
I don't mind about whether we use this or not. I'm personally likely to opt out, but that's not hard.
I'll defer to @tsachiherman @paulbellamy and co.

Something I and some others do to avoid discovering clippy warnings late is we enable clippy in VSCode. That way we get immediate in-editor feedback about clippy warnings. If you don't have that enabled that may be another way to get the same result.
If you don't have VSCode configured this way and want to try it out, these are the settings to add:
    "rust-analyzer.checkOnSave.command": "clippy",
    "rust-analyzer.checkOnSave.extraArgs": [
        "--",
        "-Wwarnings",
        "-Wclippy::all",
        "-Wclippy::pedantic",
    ],

I use -W for everything in VSCode so they show up as warnings and not errors, so I can distinguish compile errors from them in the editor.

I have it too, but when I'm doing quick edits I find myself ignoring the warnings. Or sometimes like it tests they fail to show up sometimes.  I've also been having issues with rust-analyzer since I started a couple months ago and I suspect it's because it's rebuilding each save.
Personally in general I'd prefer to fail before a push then after.

@paulbellamy This version of husky, copies the scripts checked into the repo and places it in the .git/hooks local folder.  It runs with a cargo test  as a build.rs so it will always find the root of the repo. This also means that it's not random scripts or code;  It's a published crate and a checked in script.
However, as you point out it could cause issues for some users. So perhaps it's better if we just have the script.

This also means that it's not random scripts or code; It's a published crate and a checked in script.
What happens in the case where a user forks the code and submits a PR. If I check that out and run cargo test it will start executing their scripts?

This also means that it's not random scripts or code; It's a published crate and a checked in script.

What happens in the case where a user forks the code and submits a PR. If I check that out and run cargo test it will start executing their scripts?

I think that this problem might be unavoidable. Before checking out a PR, you would need to review it online and check it out only in case you believe it's not dangerous.

@willemneal could you please resolve the merge conflict ?


windows 8

What steps will reproduce the problem?
1. not working on windows 8
2.
3.

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?

Please provide any additional information below.

Original issue reported on code.google.com by<EMAIL_ADDRESS>on 10 Jan 2014 at 10:37

What version of Windows 8 are you using? It will only work in 32 bit version of windows as it depends on the Java Joystick library that only supports 32 bit Windows.
https://sourceforge.net/projects/javajoystick/files/JavaJoystick/0.7/joystick-0-7.zip/download


using println sometimes causes a "zombie" bar to appear

the zombie bar is just an uncleared bar that has been replaced on a newline by the correct, active version.
But it's jarring because i'm using MultiProgress and now It often makes me think another task/bar has been created.
To be clear, I have programmed all my bars to .finish_and_clear(). When they are not visible, i know my program is not working... Yet I scroll up in my history and I see bars. (if logs came in during a bar) and sometimes there isn't even a log in between the zombie bars and the active bars.
The content of the "println" are the pretty formated logs from tracing if that makes a difference, they can be long,and typically have about 3 or 4 newlines.
Is this a known issue, is it a feature and not a bug? is there some way to switch off this behavior?
It's unfortunate, because I want progress bars and logs, at the same time! :D

Try With #460?

Unfortunately zombies appear to be equally as present running that commit...
indicatif = { git = "https://github.com/chris-laplante/indicatif.git", rev = "32a0cd7761e0ce91fe057b8873fcfa565afbd7c4" }

...in my Cargo.toml.

Can you share the code you are trying?

You mention the messages to println contain newlines. I think this is probably what is tripping up the MultiProgress. It doesn't currently attempt to count how many lines are actually displayed. #460 doesn't change that situation.
As a temporary workaround, can you try using MultiProgress::suspend to print the messages? E.g.
mp.suspend(|| eprintln!("messages\nmessages")));

I am creating the logs via tracing like this fmt::Layer::default().pretty() I take the &[u8] buffer from tracing and plug it directly into MultiProgress, like this mp.println(String::from_utf8_lossy(buffer))
an example of the zombies (on your commit) looks like this: (they are all zombies)

with the suspend trick mb.suspend(|| std::io::stderr().lock().write_all(buffer)); (using stderr().lock() so that I don't have to parse the bytes as a String) I am still getting zombies:

Two other questions:

How are you adding the bars to MultiProgress? Are you using add or one of the insert_ methods?
Can you confirm that the zombie issue disappears when you don't print logs to the screen, whether via println or suspend?

I am using mb.add()
when no logs are being printed.... I am STILL getting zombies!!

In fact, this minimal example (on your commit) works! (haven't tested it on the crates.io release):
// cargo add tracing
// cargo add tracing-subscriber
// cargo add indicatif
// cargo add once_cell

use indicatif::{MultiProgress, ProgressBar};
use once_cell::sync::Lazy;
use std::{io::Write, time::Duration};
use tracing::{info, subscriber::set_global_default};
use tracing_subscriber::{
    fmt::{Layer, MakeWriter},
    prelude::__tracing_subscriber_SubscriberExt,
    Registry,
};

static MB: Lazy<MultiProgress> = Lazy::new(|| MultiProgress::new());

fn main() {
    let mb = MB.clone();

    let logs = Layer::default()
        .pretty()
        .with_writer(RedirectedWriter::new(|buffer: &[u8]| {
            MB.println(String::from_utf8_lossy(buffer))
        }));
    let subscriber = Registry::default().with(logs);
    set_global_default(subscriber).unwrap();

    std::thread::spawn(move || loop {
        let pb = ProgressBar::new_spinner();
        pb.enable_steady_tick(Duration::from_millis(250));
        let pb = mb.add(pb);
        std::thread::sleep(Duration::from_secs(1));
        pb.finish_and_clear();
    });

    std::thread::spawn(move || loop {
        info!("hello world");
        std::thread::sleep(Duration::from_millis(250));
    })
    .join()
    .unwrap();
}

// tracing boilerplate

#[derive(Clone)]
pub struct RedirectedWriter {
    f: fn(&[u8]) -> std::io::Result<()>,
}

impl RedirectedWriter {
    pub fn new(f: fn(&[u8]) -> std::io::Result<()>) -> Self {
        Self { f }
    }
}

impl Write for RedirectedWriter {
    fn write(&mut self, buf: &[u8]) -> std::io::Result<usize> {
        (self.f)(buf)?;
        Ok(buf.len())
    }

    fn flush(&mut self) -> std::io::Result<()> {
        Ok(())
    }
}
impl MakeWriter<'_> for RedirectedWriter {
    type Writer = Self;

    fn make_writer(&self) -> Self::Writer {
        self.clone()
    }
}

Maybe the only other interesting thing I am doing to the progressbars, is every time a stage of processing is progresses. I clone the pb (I clone because I can't move it out of the struct which impls Drop... I guess I could std::mem::swap with a fresh pb that I don't add to the mb, if you need me to)
then I .set_style() on the cloned be to update the progress bar with new a template. I don't interact with the mb. i don't add it again or anything.

Look! Run this code for a while, you will see zombies:
use indicatif::{MultiProgress, ProgressBar, ProgressStyle};
use once_cell::sync::Lazy;
use std::time::Duration;

static MB: Lazy<MultiProgress> = Lazy::new(|| MultiProgress::new());

fn create_bar() {
    std::thread::spawn(move || loop {
        let pb = ProgressBar::new_spinner();
        pb.enable_steady_tick(Duration::from_millis(100));
        let _pb = MB.add(pb);
        let __pb = _pb.clone();
        std::thread::spawn(move || {
            let mut i = 0;
            loop {
                i += 1;
                let pb = _pb.clone();
                pb.set_style(ProgressStyle::with_template(&i.to_string()).unwrap());
                std::thread::sleep(Duration::from_millis(123));
            }
        });
        std::thread::sleep(Duration::from_secs(5));
        __pb.finish_and_clear();
    });
}

fn main() {
    loop {
        create_bar();
        std::thread::sleep(Duration::from_secs(2));
    }
}

I think the issue is that you are starting the ticker before adding the progress bar to the MultiProgress. When I run your example I do indeed get zombies, but when I tweak it as follows I don't:
use indicatif::{MultiProgress, ProgressBar, ProgressStyle};
use once_cell::sync::Lazy;
use std::time::Duration;

static MB: Lazy<MultiProgress> = Lazy::new(|| MultiProgress::new());

fn create_bar() {
    std::thread::spawn(move || loop {
        let pb = ProgressBar::new_spinner();
        let _pb = MB.add(pb);
        _pb.enable_steady_tick(Duration::from_millis(100));
        let __pb = _pb.clone();
        std::thread::spawn(move || {
            let mut i = 0;
            loop {
                i += 1;
                let pb = _pb.clone();
                pb.set_style(ProgressStyle::with_template(&i.to_string()).unwrap());
                std::thread::sleep(Duration::from_millis(123));
            }
        });
        std::thread::sleep(Duration::from_secs(5));
        __pb.finish_and_clear();
    });
}

fn main() {
    loop {
        create_bar();
        std::thread::sleep(Duration::from_secs(2));
    }
}

That's frustrating because in my actual code, the only place where i mb.add() I do so, and then set .enable_steady_tick()
The other interesting moments happen state changes, I clone the pb then .set_style() and give it a new style. But there is no more interaction with mb it has been added already`, the only behaviours I need are to change the style and kill it when done

@chris-laplante here is the entirety off my interaction with indicatif. (it's not too much) if you're curious as to the cause of the bug:
https://gist.github.com/arifd/51499d11b19ef3be7409ce1c49820ed9

That's frustrating because in my actual code, the only place where i mb.add() I do so, and then set .enable_steady_tick()
The other interesting moments happen during state changes, I clone the pb then .set_style() and give it a new style. But there is no more interaction with mb since it has been already added, the only behaviours I need are to change the style and kill it when done

Does your output end up going into scrollback? In order words, are you trying to display more lines than there are rows in your terminal?

@chris-laplante here is the entirety of my interaction with indicatif. (minus the PROGRESS.println(String::from_utf8_lossy(buffer)) logs which happens in another mod) (it's not too much) if you're curious as to the cause of the bug: https://gist.github.com/arifd/51499d11b19ef3be7409ce1c49820ed9

I don't see any reason why this shouldn't work :(.

That's frustrating because in my actual code, the only place where i mb.add() I do so, and then set .enable_steady_tick()
The other interesting moments happen during state changes, I clone the pb then .set_style() and give it a new style. But there is no more interaction with mb since it has been already added, the only behaviours I need are to change the style and kill it when done

Does your output end up going into scrollback? In order words, are you trying to display more lines than there are rows in your terminal?
It's hard for me to provide you a good screenshot unfortunately, but yes, i will get zombies, even before all the rows have been filled up with content, and even without any logs being printed.
In this screenshot there did happen to be a couple logs but then I got zombies anyway.
The zombies in this screen shot are the lines beginning with [645, 664, 688, 645, 664, 645, 664, 645, 664, 688]. In fact, we can know they are zombies, because we never work the same ID at the same time. Apart from that, in real life you can see the spinner is stuck.

Without code that I can run myself it's hard to say :/. The best chance of getting this fixed is if you can come up with a self-contained reproducer. I know that's easier said than done but for inspiration you can look at the render tests: https://github.com/console-rs/indicatif/blob/main/tests/render.rs. If you could implement your reproducer as a render test, that'd be even better.
Besides that, looks like you're using Visual Studio Code? Can you try running your program in a different terminal emulator? This is to rule out issues with vscode's escape sequence processing.

Okay sure, I'll try to get at it over the weekend. Cheers.

I get what I think is a similar issue with the following code:
fn main() {
    let multi_progress = MultiProgress::new();
    let style = ProgressStyle::with_template("[{elapsed_precise}] {bar:40.cyan/blue} {pos:>7}/{len:7} {msg}")
        .unwrap()
        .progress_chars("##-");

    let threads_count: u64 = 10;
    let operations_count: u64 = 100;

    // Start 10 threads
    let threads = (0..threads_count)
        .map(|thread_index| {
            // Add a progress bar for each thread
            let pb = multi_progress.add(ProgressBar::new(operations_count));
            pb.set_style(style.clone());
            pb.set_message(format!("Thread #{}: running", thread_index));

            thread::spawn(move || {
                // Start 100 operations in each thread
                for operation_index in 0..operations_count {
                    // Print a single line anywhere (e.g. on thread 5, operation 50).
                    // The printed line is not visible (which I assume is expected)
                    // and a few zombie bars are spawned instead.
                    if thread_index == 5 && operation_index == 50 {
                        println!("Hello, World!");
                        pb.set_message(format!("Thread #{}: running (println was here)", thread_index));
                    }

                    // Simulate 20ms of work
                    thread::sleep(Duration::from_millis(20));

                    // Update the progress bar
                    pb.inc(1);
                }
            })
        })
        .collect::<Vec<_>>();

    for thread in threads {
        thread.join().unwrap();
    }
    println!("All threads finished");
}

indicatif = "0.17.2"
(Tested on Windows 11, with both PowerShell and Command Prompt)

(Tested on Windows 11, with both PowerShell and Command Prompt. indicatif = "0.17.2")

This is expected - a bare println! bypasses all the MultiProgress machinery and throws off the line counts. To fix your code, just replace the println!("Hello, World!"); with pb.println("Hello, World!");  :slightly_smiling_face:


Fix support for raw volumes

Hey,
thanks for this nice project. I use it currently very heavily. I found a bug when I try to use raw volumes then I got the following message:
* libvirt_domain.template: Error creating libvirt domain: virError(Code=1, Domain=10, Message='internal error: process exited while connecting to monitor: 2017-12-11T19:57:09.278580Z qemu-system-x86_64: -drive file=/var/lib/libvirt/images/template_docker,format=qcow2,if=none,id=drive-virtio-disk1: Image is not in qcow2 format')

The problem is that the image is correctly converted as raw image, but the libvirt definition is not correct and assumes that it's an qcow2 image.
My solution is to check the file extension like you do when using a volume from url. Futhermore I added the file exentsion to qcow2 volumes so that anything except qcow2 will be defined as raw.

This seems to be related to (or maybe in conflict with) #183.

@solidnerd  we are going to merge soon this PR which will adress this pb in more generic way,
thank you for your PR :sunflower:
https://github.com/dmacvicar/terraform-provider-libvirt/pull/380


Create useDisclosure composable

Pull request checklist
Please check if your PR fulfills the following requirements:

[X] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been reviewed and added / updated if needed (for bug fixes
/start features)

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?
N/A

What is the new behavior?

Adds the useDisclosure composable, similar to the Chakra react hook
Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

@codebender828 I updated the naming of the emit methods per your suggestion.
I also attempted to add JSDocs and typing to improve IDE intellisense. I would like your thoughts on this. This is the last commit so I could simply revert it if you don't want it. 😄


Invalid args applied to npx playwright test

Hi there!
First of all, thanks for making this adapter! I've got the installation and config down, and I can now correctly see my tests in the test summary. However, when I actually run the tests, I can see the following in the test output:

npx playwright test --no-coverage --testLocationInResults --verbose --json --outputFile=/var/folders/5t/wrvwpv150cq3b9c_2gpn
04 page$' --forceExit /<path-to-my-test-file.spec.ts>

This causes playwright to throw an error: error: unknown option '--no-coverage'. I get the same error if I copy and paste this command myself. In testing, actually none of the args are valid args.
I checked the Playwright command line docs, and couldn't find those args either.
Perhaps you can help enlighten me as to what is happening? I have l a very simple setup, and didn't set up any of those args in the config of neotest/this adapter myself.

Hi!
It seems these flags are from neotest-jest.
But it's difficult to say exactly how they ended up being passed to playwright, or more importantly, how to fix it, without knowing more about the config/project structure.


Query Caching , lots of multiple repeated SQL commands

Query Caching is not working

Steps to Reproduce

enable SQL logging in settings
LOGGING = {  'version': 1,  'filters': {      'require_debug_true': {          '()': 'django.utils.log.RequireDebugTrue',      }  },  'handlers': {      'console': {          'level': 'DEBUG',          'filters': ['require_debug_true'],          'class': 'logging.StreamHandler',      }  },  'loggers': {      'django.db.backends': {          'level': 'DEBUG',          'handlers': ['console'],      },      'django': {          'handlers': ['console'],          'level': 'INFO',          'propagate': False,      },  } }

./manage.py shell

from wagtail.core.models import Page

interact with model instance or model.specific ,  everytime a property is accessed, see SQL 30+ statements being called repeatedly when accessing properties of the instance.

from my_regular_simple_django_model import AReguarNonWagtailModel

interact with AReguarNonWagtailModel, accessing properties more then once

Sql is not being called repeatedly as expected (only on first property access)

is there a way to avoid the deluge of repeated SQL statements -- Am I'm missing something in my configuration?
Any other relevant information.
(Mostly I'm checking in the pycharm debugger)

I have confirmed that this issue can be reproduced as described on a fresh Wagtail project: (no)

Technical details
Django==4.1.3 wagtail==4.1.1 psycopg2-binary==2.9.5 python3.11
MacOSX

Hi @leonh - thanks for the feedback.
Improving the database performance is something we're very much interested in, but this report doesn't really give us any information beyond "it's executing a lot of queries", and without specific details there's no real way for us to act on this or determine a point when it can be considered 'fixed'.
If you can identify specific queries that are candidates for being eliminated or made more efficient, we'll be happy to investigate further.

I think this might be a pycharm related issue , if I open a "pycharm console"  shell session I see the following (note repeated queries on property access).


Fix deprecation warning in helper function

This fixes the deprecation warning raised by moneyphp. In the next release of moneyphp, passing the currency to the money parser as a string will result in an error.

Good one, thanks!


Getting sourcemaps to work

What is the trick for getting sourcemaps to work correctly with the stacktraces in AWS logs?
I've currently got require('source-map-support').install(); after all other imports in a file /src/lambdas/webhook.ts.
Webpack config looks like this:
var path = require('path');

module.exports = {
  entry: {
    '/src/lambdas/webhook': './src/lambdas/webhook.ts',
    '/src/lambdas/queue-poller': './src/lambdas/queue-poller.ts',
    '/src/lambdas/queue-worker': './src/lambdas/queue-worker.ts',
  },
  target: 'node',
  devtool: 'source-map',
  resolve: {
    modules: [
      path.join(__dirname, 'src'),
      path.join(__dirname, 'node_modules')
    ],
    extensions: ['', '.ts', '.js']
  },
  module: {
    loaders: [
      { test: /\.ts(x?)$/, loader: 'ts-loader' }
    ]
  },
  resolve: {
    extensions: ['.ts', '.js'],
  },
  output: {
    libraryTarget: 'commonjs',
    path: path.join(__dirname, '.webpack'),
    filename: '[name].js'
  },
};

Here is the contents of the uploaded zip:
 ⇒ unzip -l .serverless/trebuchet.zip
Archive:  .serverless/trebuchet.zip
  Length      Date    Time    Name
---------  ---------- -----   ----
     3020  02-24-2017 22:37   src/lambdas/queue-poller.js
     3140  02-24-2017 22:37   src/lambdas/queue-poller.js.map
     2956  02-24-2017 22:37   src/lambdas/queue-worker.js
     3073  02-24-2017 22:37   src/lambdas/queue-worker.js.map
  3655773  02-24-2017 22:37   src/lambdas/webhook.js
  5682470  02-24-2017 22:37   src/lambdas/webhook.js.map
---------                     -------
  9350432                     6 files

The output for both logged exceptions and unhandled exceptions is still using the full bundle.
Am I missing something from the source-map-support config?
If everything is working correctly should the logged and unhandled exceptions be using the stacktraces from the sourcemap?

Has anybody figured out how to get source-map-support to work? In my case I'd like source-maps to be used in the trace when I invoke a function locally. As shown in the readme: serverless webpack invoke --function <function-name>

In my case, I believe the issue was with my tsconfig file.  I can't speak to other languages/frameworks though.  Since then, we've moved to using serverless-typescript-plugin since we're not building a UI and don't have as much to gain for the added complexity of webpack.

Okay, thanks for following up!
@HyperBrain Perhaps #151 would have some impact on getting source-map-support to work when invoking a function locally?

@benjaminwood I think so. We should check for the source-map support as soon as the native Serverless invoke is used. Then any problems can be finally solved.
I'll take care of #151 soon so that we can proceed.

Thanks @HyperBrain, that'd be awesome!

@benjaminwood A V3 RC is released now on npm<EMAIL_ADDRESS>Would be cool if you can try to get the sourcemap support running with serverless invoke local 😃

Hey @HyperBrain I ran into an error before my handler would be called. To ensure it is related to the new version of serverless-webpack, I confirmed that if I roll-back to an older version things work as expected (by using serverless webpack invoke)
Here's a backtrace:
https://gist.github.com/benjaminwood/65a9f3a346f9c5cf24e9a28b48778ee1
Perhaps this should have its own/new issue. I'm happy to create one, let me know. Thanks for working on this! You've been making lots of progress on this package which is real exciting.

It looks like a configuration problem. Could you post the function definition of the export function and the webpack config? If you've not done that already, you should switch to automatic entry resolution with slsw.lib.entries though.

Just went through the callstack again. It's definitely a configuration issue - your entry is "main" but your handler is "handler". This makes it impossible for the plugin to find the handler. Please change your "entry" definition to be entry: slsw.lib.entries and your output filename to [name].js. This makes sure that the entries are reverse resolvable to the handlers (which are started by sls invoke local).

In my webpack config it was defined as: entry: './handler.js',
However, changing it to entry: slsw.lib.entries as you suggested resolved this. Thank you for your help, and I apologize for being a noob. 😄
🎉🎉🎉And with that.... source-map-support works! 🎉🎉🎉
Thanks again!

@benjaminwood Great to hear that this solved your problem 👍 . You're not a "noob" - the feature is quite new, so many people just don't know that it exists 😄

This issue is solved with v3. Will be closed as soon as #175 is merged.


Design: Button with Link styling

In order to maintain accessibility, "links" that do not lead to a new page, ie open a modal, should be "buttons" using the html "< button >" tag.  Because this is important for accessibility, we should make it easy to do through the design system.
This ticket:
Create a "LinkButton" component which has all of the styling options of a link, but renders an 'button' tag and accepts button props.

Is this different than a minimal button?


Fix work stealing queue issue

Not fixed yet but it is better...
Looping over the benchmark with my fix i reach 5-10 iters, while no fix 0-1

Not actually the real issue is misuse of WorkStealingDeque, you cannot have threads steal work and push at the same time via round robin to their queues.


[PROPOSAL] Host unreleased versions of the docs site

What kind of business use case are you trying to solve? What are your requirements?
We have: https://opensearch.org/docs/1.2/dashboards/index/ which only came out for the 1.2 release. But when we bump our version for OpenSearch Dashboards, we would have to point to an older version of docs even thought the branches are accessible to the public.
What is the problem? What is preventing you from meeting the requirements?
https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/package.json#L15 is used by the docs service to point the links internally to the correct version of docs. For branches if we don't want potential 404s then we need to point older version of the docs or latest.
What are you proposing? What do you suggest we do to solve the problem or improve the existing situation?
Host the next upcoming release docs with some indication that it's unreleased so that we can point branches to that version for it's intended release.
What are your assumptions or prerequisites?
none
What are remaining open questions?
How to ensure not to make people confused for latest being "latest released".

Can we get this bumped up in priority?

Another issue: https://github.com/opensearch-project/documentation-website/blob/main/_clients/javascript.md
The NPM client is currently on 1.0.2 but main points https://opensearch.org/docs/latest/clients/javascript/ which points to https://opensearch.org/docs/1.2/clients/javascript/. This would confuse me because I would assume that I am reading the docs for JS client version 1.2.x.

@kavilla - can you please clarify? Is this still an issue? Thanks!

@kavilla - can you please clarify? Is this still an issue? Thanks!

@hdhalter yes I would assume so.
To clarify any documentation links added inline to components that don't exist in a previous release will basically be dead links. Take vis builder for example. Developers can't really include code that referenced: https://opensearch.org/docs/latest/dashboards/visualize/visbuilder/ until the version was released because the doc site only gets updated upon version release.
So if there was any code reference to the this link, developers would have to be okay with the 404 and re-route to so default route and verify on the day of release.
If the doc site followed the branching strategy that allowed for documentation to be hosted prior to release then in-application links to new docs can be verified prior to the day of release.

Hi @kavilla - I'm marking this as 'wontfix' due to having no bandwidth for fixing anything related to our branching strategy. If we move to a different architecture for our docs, we may be able to do something to solve this, but until then, I'm going to close this issue. In the meantime, if you come up with an easy solution and resources to apply it, please let me know. Thanks!


The flatpickr does not work in ie

https://jsfiddle.net/tj2Lo4z7/
An  SCRIPT438 error code occurs.
I got the message 'The object does not support the 'from' property or method'.
The flatpickr official site examples also do not work for the same reason.
Your Environment

flatpickr version used:  4.3.0
Browser name and version: ie 11
OS and version: Widow10

Hi khamkim,
Thank you for the report. I was able to replicate and pinpoint the issue to the Array method from that's not implemented at all in IE.
This will be fixed soon, but in the meantime, you can use a small polyfill to get it going: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/from#Polyfill


[pytest] Ni interface tests

Tests partially implemented
Tests implemented

ni
interface
id

Tests remaining

ni
interface
interface

ni
interface
subinterface

Impolemented in other PR #89


improve: enable select text by dblclick

at first, i would like to thank you for that nice plugin!
i tried to fix the issue that editors can not select text by doubleclick.
in the first try, i checked the tagName of the mousedown-event's target.
i add a condition to only preventDefault, if tagName is not input or text-area.
unfortenetly there are some more tags, if for example a writer field is included in the block.
second iteration i checked the event's target for an ancestor of type '.k-input'
i changed the condition to only preventDefault, if there is none.
we tested with text, textarea, url,  writer with text, code, link.... thats works quite nicely.
would be nice, if you can have a look.
Thx.

tested this, would be great to have this merged!

Hey thanks for your work on this!


How do we create a "apns-push-type": "background" notification for IOS?

I would like to send a header of "apns-push-type": "background".
As the apple documentation says you must send this header to make the notification a background notification so that the app can process the notification in the background. using the application:didReceiveRemoteNotification:fetchCompletionHandler: method.
Here is the documentation that describes this:
https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/sending_notification_requests_to_apns/
And here:
https://developer.apple.com/documentation/usernotifications/setting_up_a_remote_notification_server/pushing_background_updates_to_your_app?preferredLanguage=occ

@stephanoparaskeva there is no such a capability as for now
will add it to the roadmap
Will let you know

Closed due to inactivity. Please create a new issue if needed.


Add support for wxkg

If you want to add support for the scene switch(cjkg) i can test and debug the plugin for you.

Because i bought one few days ago

Do i need a special subscription because the "data reporting" tab is not displayed for me.

No need. Can you take a picture?

Maybe only virtual device have "data reporting"... It's okay, you can enable the homebridge debug mode and upload your logs during physical and app control process.

Oh sorry i thought that the device was cjkg but it is wxkg. I fyoz want to add support for this i can send you the logs.

data = {
"result": {
"category": "wxkg",
"functions": [],
"status": [
{
"code": "switch_mode1",
"type": "Enum",
"values": "{"range":["click","press"]}"
},
{
"code": "switch_mode2",
"type": "Enum",
"values": "{"range":["click","press"]}"
},
{
"code": "battery_percentage",
"type": "Integer",
"values": "{"unit":"%","min":0,"max":100,"scale":0,"step":1}"
}
]
},

data = { "result": { "category": "wxkg", "functions": [], "status": [ { "code": "switch_mode1", "type": "Enum", "values": "{"range":["click","press"]}" }, { "code": "switch_mode2", "type": "Enum", "values": "{"range":["click","press"]}" }, { "code": "battery_percentage", "type": "Integer", "values": "{"unit":"%","min":0,"max":100,"scale":0,"step":1}" } ] },

Ok, from the data, It's a stateless switch and we can only get event on HomeKit and can not control it. Please enable the homebridge debug mode (see readme troubleshooting), and press the physical switch, single press, double press, long press, I don't know, it depends on your device. Then you can see the mqtt messages from homebridge logs.
I need to know the exactly meaning of {"switch_mode1": "click"}, {"switch_mode1": "press"}, thanks :)

Sure i'll do it when i am at home.

"status": [
{
"2": "single_click",
"code": "switch_mode2",
"t": "4",
"value": "click"
}
"status": [
{
"1": "single_click",
"code": "switch_mode1",
"t": "5",
"value": "click"
}
]
"status": [
{
"2": "long_press",
"code": "switch_mode2",
"t": "11",
"value": "press"
}
]
"status": [
{
"1": "long_press",
"code": "switch_mode1",
"t": "1670342532",
"value": "press"
}
]

I have 2 Buttons on this thing and it accept a long press and a click.

So click means single click, press means long press right?

Yes, correct

I've submitted 1.7.0-beta.2, please have a try :) I don't have home hub, not able to test.

Sure i am not home bow i'll test ur later.

It works perfect! Thank you for updating the plugin.

I update the plugin with some modification:

Fix fake click event during plugin initialization.
Hide single/double/long click for unsupported devices.

And there may still have some possibility of fake event due to #32 , it's a known issue and still working on it.
Please try if the second modification take effects. I don't have home hub and these three buttons are always disabled for me, I don't know if it can be hidden or disabled.
1.7.0-beta.3.

Ah sorry it works now it just needed a few restarts

Great :)


Nukies broken on master

nukies spawn but nobody is placed in control of them on mapload. happened around the time of the nukie naming PR. unsure if this is the cause though. #8692

Did someone redo the nukie shuttle recently?

It was more likely the Opt-In stuff that was merged at the same time. I somehow doubt my like 3 line PR of changing their names had an effect. It worked on local too, so.

#8541 the other pr to touch nukies during the publish that broke it

So nothing with that PR seems to be the issue. Everything goes through fine. The mind gets put into the Nukies. It seems something is happening in the round start sequence that is putting the Mind back into the normal human. It is probably the same bug that was causing the rounds to not start.

this should be closed


OSError: Error: The file ... was not created.

From the log, the first error I could find was ValueError: Data exceeds wave file size limit, raised by scipy, specifically in line 78 of splitAudio:
wavfile.write(filename, SAMPLE_RATE, outputAudioData)
In .TEMP, it generates the output, however it is missing the audio, most likely due to the wavfile being unable to get created. The .wav files in this folder are also empty, but there are 4 in .CACHE, all 2.71GB in size.
I'm assuming the problem here is that the file is too long, but in that case then the program would have a limit on the length of the video. My input is 4:13:31 long as well.
Is there a way to circumvent this? Maybe adding an option that allows for splitting a video into 2 if it gets too long, or maybe something like --split_every 120 which would mean split every 2 hours (120 minutes). Having to manually split my video into segments takes time due to re-encoding, and since the script effectively reconstructs the video from images and wav files, it seems easier to do it during construction.

Scipy being limited to 2 hours is an issue that I've known about for a long time and is something I want to fix.
However, splitting the video  seems overkill since it's only the audio that's too big.
The best solution, I think, would be to create new audio files internally when it's too big for scipy to handle and then concatenate them before muxing with the video again.

Yeah, understandable. I felt like I should at least try and provide an approach as to how it can be circumvented. If there's a way to concatenate wav files then that would solve the issue pretty well.

I'm running a 4 hour and 40 minute video to see where the error is happening. What surprised me was is that for me, it completed just fine.
It gave me a video that was shorten to 4 hours and 16 minutes.
Running from fastVideo.py
Finished.
took 6553.2 seconds (1:49:13)

I understand that you were running this with originalMethod.py instead of fastVideo.py like I did, but I though they both had the same underlying problem which is why I was shocked when it outputted perfectly.
Not to say that there's no limit for fastVideo, just that it was way higher than I thought it was.

I'll try running the script on a 5+ hour video I have. Maybe the error is unrelated to the length? I'm not sure what exactly triggered the error in that case, but that's weird. Hopefully it was just a weird fluke.

Actually, what is the difference between originalMethod.py and fastVideo.py? This is the command that I'm running:
python .\auto-editor\auto-editor.py --video_speed 1.2 --silent_speed 999999 --frame_margin 5 --silent_threshold 0.05 --cut_by_this_track 2 --no_open
Does auto-editor.py use originalMethod.py by default?

originalMethod.py splits every frame into a jpeg then chooses new frames to be put back into a new video. fastVideo.py uses cv2 to read and write frames more quickly while doing hard work like converting compressed video into a standalone frame a lot less.
auto-editor chooses which script to run based on how good each one is and if it supports the options the user wants.
I'm pretty sure the code I just pushed to master will solve your problem so I'm closing this issue.


Change references to "WFS 3" to "OGC API - Features - Part 1: Core"

Not sure what the acronym for it is, but we should figure it out (OGCAPIFP1C?, lol).
Also mention that OGC API - Features - Part 1: Core was previously WFS 3.
I'm glad to make the changes, but I wanted some indication as to if we should do it or not first.

OGC still figures out the acronym. Until they made the first release under the new name, I'd leave it as it is. People know it still as WFS3 and OGC ist still working on the new names etc.

Will it be OAFeat 1.0?! 🤣
See https://github.com/opengeospatial/oapi_common/issues/35#issuecomment-509598050


Visual Studio Code (with the ‘golang’ extension) very, very slow?

Dear Sir,
PROBLEM:
Why is Visual Studio Code (with the ‘golang’ extension) so very, very slow?
ANALYSIS:

I am running Windows 10 on a desk top PC.
Processor: Intel(R) Core(TM) i3 CPU 540 @ 3.07GHz 3.06 GHz
Installed Memory (RAM): 4.00 GB (3.87 GB usable)
System type: 64-bit Operating System, x64-bassed processor

I am running Visual Studio Code Version 1.12.1
Commit f6868fce ...
Date 2017-05-04T21:26:50.689Z
Shell 1.6.6
Renderer 56.0.2924.87
Node 7.4.0

I am using the ‘golang’ extension.

I have the following in a file called ‘helloworld.go’:-
package main
import "fmt"
func main() {
fmt.Println("hello world")
}
I type ‘go run helloworld.go’ in the terminal area and it takes 11 (sometimes 20) minutes to get a response
Why is it so very, very slow?
I would be very grateful for any advice.
Thank you
Mike

VSCode Version: Code 1.12.1 (f6868fce3eeb16663840eb82123369dec6077a9b, 2017-05-04T21:26:50.689Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions:

Extension
Author
Version

Go
lukehoban
0.6.61

Steps to Reproduce:

Please file your issue against the Go extension https://marketplace.visualstudio.com/items?itemName=lukehoban.Go.


Create a "Backend Level Storage" Design Doc

Hi! I've had a little bit of conversation on the side with @yanniboi and @neon-inkblast about the backend storage for levels (JSON files) and images, but I was thinking it might be valuable to put together a "formal" document about:

Current State: Functionality and implementation of yanniboi's existing level storage from the level design jam last year
Desired functionality for this project (should it work with remote, in-browser, in-game, what data should each level include, etc)
Implementation Options (and proposed solution)

I don't think it needs to be too formal, but it would be valuable to understand where we're at and where we're going, and because for anyone coming along later who wants to contribute and understand how we're planning on approaching the backend storage.
Question: Should the document should be written via a markdown file with a Pull Request for getting feedback? A Discussion or on this Issue itself and then go into the wiki?

Discussing this on: https://github.com/LPGameDevs/EditarrrPublic/discussions/47


It is possible to hide columns even with rememberState set to false

It is PR for issue #836
Just let me know what do you think. :) @paveljanda

Ping @paveljanda @f3l1x

I will ask fot the last time.
@f3l1x @paveljanda
If it will not help, I will be forced to create my own fork :/

Thanks :)

@paveljanda Thx 👏

@RiKap Please see:
1, https://github.com/contributte/datagrid/issues/934
2, https://github.com/contributte/datagrid/releases/tag/v6.5.1
3, Diff: https://github.com/contributte/datagrid/compare/v6.5.0...v6.5.1


Don't accept my file since today

Hi guy,
Hope you're all doing well !
I get a weird problem with the plugin today, I cannot select the library file to replace all the symbols like previously. I get this message : Sorry, that file is not a Library. Add it as a Library and try again.
It works perfectly yesterday with the same file. I've uninstalled the plugin and reinstalled it but nothing work :-/. Someone can help me ?

I solved my problem ! I delete my file from the library and relinked it as a library.
It works now :-)

Great 😄  As a guess, maybe the file moved on your filesystem - so Sketch no longer thought of it as a library


Fix oembed with playlist links

NOT TESTED!
Oembeds don't seem to work locally so not sure how to test it. http://localhost:9090/$/oembed <--- gives not found page

will push this up to salt.odysee.tv for testing
(also not sure how to test locally)

Didn't worked.
https://salt.odysee.tv/$/oembed?url=https://salt.odysee.tv/$/playlist/01d05ed3b470a271e799a27216a3550340a189d4
Tried to add some debug info to the error to see what's happening there

Didn't checked the isPlaylist check earlier,  that probably was the issue. Will still leave the debug info in case there is some other issues.


COM redirecting cause wrong end of line

I have barcode reader "Virtuos HT-900" It emulate COM port. I setting up end of line to "CR"
It works well in Debian, but if i redirect the device via FreeRDP, I give "LF" instead "CR"
Even if I set "CLRF", i give "LFLF"
So I think it is FreeRDP's problem. I use version 1.1.0-beta1 (git 1.1.0-beta+2013071101-162-g770c67).
script, that I use:
/u:user /d:domain /p:password /kbd:0x405 /serial:COM4,/dev/ttyACM0 /v:ServerIP

@xgimp can you test if this problem still exists on the latest master. For Ubuntu,Debian and Fedora you can use our nightly packages (https://ci.freerdp.com/job/freerdp-nightly-binaries/).

i tried night-build (version 2.0.0-dev (git n/a) ). With it I am not able to open redirected COM
FreeRDP returns:
[15:29:23:312] [6761:6767] [WARN][com.winpr.comm] - Requested an incompatible input buffer size: 65520, keeping on with a 4096 bytes buffer.
same error in latest master version.

@xgimp please make a try with: /serial:COM4,/dev/ttyACM0,Serial,permissive
"Serial" doesn't means much but the "permissive" mode will ignore a few errors. Sometimes ignoring such errors or limitations is enough to make working a device.

It works with nigtly, here is FreeRDP output:
[07:44:54:471] [2936:2938] [INFO][com.freerdp.channels.rdpdr.client] - registered device #1: COM4 (type=1 id=1)
[07:45:09:988] [2936:2942] [WARN][com.winpr.comm] - Requested an incompatible input buffer size: 65520, keeping on with a 4096 bytes buffer.
[07:45:09:988] [2936:2942] [WARN][com.winpr.comm] - Requested an incompatible output buffer size: 16384, keeping on with a 4096 bytes buffer.
[07:45:09:988] [2936:2942] [WARN][com.winpr.comm] - [permissive]: whereas it failed, made to succeed IoControlCode=[0x1B0008] IOCTL_SERIAL_SET_QUEUE_SIZE, last-error: 0x4C7
[07:45:10:767] [2936:2993] [WARN][com.winpr.comm] - Attempt to set XonLimit with an unsupported value: 0
[07:45:10:768] [2936:2993] [WARN][com.winpr.comm] - Attempt to set XoffLimit with an unsupported value: 65520
[07:45:10:769] [2936:2993] [WARN][com.winpr.comm] - [permissive]: whereas it failed, made to succeed IoControlCode=[0x1B0064] IOCTL_SERIAL_SET_HANDFLOW, last-error: 0x32
[07:46:41:030] [2936:4139] [WARN][com.winpr.comm] - SERIAL_DTR_CONTROL:ON and SERIAL_RTS_CONTROL:OFF cannot be different, HUPCL will be set since it is claimed for one of the both lines.
[07:46:41:030] [2936:4139] [WARN][com.winpr.comm] - Attempt to use the unsupported SERIAL_DSR_HANDSHAKE feature.
[07:46:41:030] [2936:4139] [WARN][com.winpr.comm] - Attempt to use the unsupported SERIAL_ERROR_ABORT feature.
[07:46:41:031] [2936:4139] [WARN][com.winpr.comm] - [permissive]: whereas it failed, made to succeed IoControlCode=[0x1B0064] IOCTL_SERIAL_SET_HANDFLOW, last-error: 0x32

@xgimp if the latest nightly work can the issue be closed?

Yes, thank you both for help.


WinUI Bug: Progress rings do not display in content dialogs in Windows 11

WinUI Toolkit Bug Report

Name of component or part of Toolkit:
ProgressRing
ContentDialog
Describe the bug:
Progress rings do not display inside Content Dialogs in Windows 11 when created programmatically. This is also true when created in XAML but the results vary. For example, if the content dialog is created in XAML but the progress ring is created and added to the dialog programmatically, it will sometimes work. It will almost always work when the ring is added to the dialog after the dialog appears on screen, e.g. using the ContentDialog.Opened event.
Version Info:  started using in ver 2.6.1 but still seeing issue in 2.7
Additional context:
Using the new styling, progress rings no longer show in content dialogs.
This is also true in Windows 10 when both the content dialog and the progress ring are created in XAML, and the ProgressRing.IsIndeterminate property is set to true. If ProgressRing.IsIndeterminate is set to 'false' and progress is manually reported, it will work correctly.
This is also true when using old style progress bars in new style content dialogs in Windows 11, but will work when progress is manually reported much like the progress ring issue mentioned above in Windows 10.
This is also true when using the old style progress rings in the new style content dialogs in Windows 11.
New style progress bars seem to work as expected.

Hi @MB-Xer , is this an issue you saw with the Figma toolkit? From the description, it sounded like this is an issue with XAML or with the implemented components themselves?

Thanks @alejo4000. This does not have to do with the Figma toolkit. This is an issue I noticed in a UWP app when placing a Microsoft.UI.Xaml.Controls.ProgressRing inside of a Microsoft.UI.Xaml.Controls.ContentDialog and is specific to Windows 11.
The only necessary steps to reproduce this are to install and set up the Microsoft.UI.Xaml Nuget package, programmatically create a content dialog with a progress ring as its content (making sure both controls are from the Microsoft.UI.Xaml namespace), and display the dialog on a Windows 11 box. The dialog will appear but the progress ring does not.
I did make a bit of progress narrowing down a potential cause. In the Microsoft.UI.Xaml.Controls.ContentDialog styling found here: https://github.com/microsoft/microsoft-ui-xaml/blob/main/dev/CommonStyles/ContentDialog_themeresources.xaml, there is a new Rectangle overlay named "SmokeLayerBackground" (line 236). If I change that to a Grid and set the background of the grid to the same ContentDialogSmokeFill resource, everything seems to work fine. I don't have an explanation why that would cause an issue in Windows 11 specifically or why changing it to a Grid fixes it.

I'm redirecting this and updating the title so it will be seen by the correct team.

Wow, I was going nuts with this bug. This is not even related with being dynamically created.
It happens on my side when I use the new ContentDialog style. If I remove the new style, the ProgressRing appears as expected.

I'm also seeing this with winui 3 from windows app sdk 1.1 on windows 10; it's possible to make it work by 'poking' it a bit - for example, if I use it with a fixed value and increase the value over time, it works after the first few updates. For indeterminate mode, this makes it start working:
    progressRing.IsIndeterminate(false);
    progressRing.IsActive(true);
    progressRing.Value(0);
    co_await winrt::resume_after(std::chrono::milliseconds(100));
    co_await uiThread;
    progressRing.Value(100);
    progressRing.IsIndeterminate(true);

any news about this bug?

@shelllet it's fixed in the latest update

@shelllet it's fixed in the latest update
@ArchieCoder
why my application  do not display ProgressRing  control in content dialogs,   the version  of WindowsAppSdk i used is 1.1.4.

<StackPanel Orientation="Horizontal" HorizontalAlignment="Center" VerticalAlignment="Center">
      <ProgressRing IsActive="True" Width="100" Height="100" Foreground="Green" IsIndeterminate="True"></ProgressRing>
</StackPanel>

@shelllet oh sorry, it is fixed for UWP apps. However, with your info about WinAppSdk, this is for a WinUI app. Good luck!

It seems it still not works in WindowsAppSdk 1.2.4. Will this be fixed for WinUI 3 at all?

It's been almost two years. It's a spinner in a dialog box. Seriously?

Still not working in Win SDK!

It seems it still does not work in WindowsAppSdk 1.2.4. Will this be fixed for WinUI 3 at all?
Here is fredemmott's workaround translated to c#:
    private async Task BugWorkaround() {
        this.progressRing.IsIndeterminate = false;
        this.progressRing.IsActive = false;
        await Task.Delay(System.TimeSpan.FromMilliseconds(100));
        this.progressRing.IsActive = true;
        this.progressRing.IsIndeterminate = true;
    }

I call this method in the constructor of the control (without await obviously).

Oh my god. It's been three (3) years and this is the only workaround that works. They haven't fixed it since this issue is created.

@duncanmacmichael could we get some info from team here?

I see no ProgressRing issues using Windows 10 and WASDK 1.5.240205001-preview1.
Others may want to confirm that this is still a problem with the latest WASDK .5.240205001-preview1 release on Windows 11 only.

In my UWP app, there are occasions that my radio buttons don't have the selected dot when it is checked. I suspect a bug under the hood that makes all these weird UI bugs happening.

@duncanmacmichael could we get some info from team here?

Hi, we do have an internal bug item opened for this and are tracking it, but other than that I don't have any updates from the team at this time. Thanks for checking!

Thank you for info and I have one request for you. I know it could be really time consuming to reply to every bug, but could be possible to sometimes answer for replies? It could help raise trust in team they are working on something. Thank you very much

A fix for this has been submitted and should be available in the 1.6 release.
There is a known issue with Loading/Loaded/Unload events that can cause an unloaded event to be fired when the element is in the tree.  This happens when an element is removed and readded to the tree in a single frame.  That is what is happening here.  The content dialog is remove and re-added to the tree to adjust z-order with the smoke layer causing the situation to arise.
The fix for the erroneous event is most likely too much of a breaking change for a dot release, so we have worked around it and in the color picker's Unloaded event we only discard the ring animation if the element was not added back.

The bug still exists. ProgressRing is not visible on Windows 11 in UWP app. On Windows 10 works as expected.


Cinderwisp doesn't use rune ability to finish off Bronze Guardian

Haven't tested on other bosses.

Or maybe it does... I'll look into this a bit more, so you can ignore me for now.


Implement Push API methods

There's a test (CompletenessTest) that interrogates the API and lists methods we've not implemented yet.
I'm gonna raise separate issues for each thing that needs implementing which will make it easier to split the work.
These are the Push methods that need to be implemented.

flickr.push.getSubscriptions
flickr.push.getTopics
flickr.push.subscribe
flickr.push.unsubscribe

I wonder if we can omit these for the next release... subscriptions are new and the methods may change


Better PHPs, made code for sending and receveing text messages

i can't merge it's telling me
This branch has conflicts that must be resolved
i also linked to chat.php in the forums :)

@RoadRunner-Dollars Solved


Is there someway to skip refine on langchain agent query

Is there someway to skip refine on langchain agent query。redefine answer is not better。

It's not really possible to disable it, it's a necessary part of the process. Some LLMs struggle with it though.
Are you using GPT-3.5? It's been struggling with the refine part for the last week or so.
I've been working on a new refine template. Maybe try something like this:
from langchain.prompts.chat import (
    AIMessagePromptTemplate,
    ChatPromptTemplate,
    HumanMessagePromptTemplate,
)

from llama_index.prompts.prompts import RefinePrompt

# Refine Prompt
CHAT_REFINE_PROMPT_TMPL_MSGS = [
    HumanMessagePromptTemplate.from_template("{query_str}"),
    AIMessagePromptTemplate.from_template("{existing_answer}"),
    HumanMessagePromptTemplate.from_template(
        "I have more context below which can be used "
        "(only if needed) to update your previous answer.\n"
        "------------\n"
        "{context_msg}\n"
        "------------\n"
        "Given the new context, update the previous answer to better "
        "answer my previous query."
        "If the previous answer remains the same, repeat it verbatim. "
        "Never reference the new context or my previous query directly.",
    ),
]

CHAT_REFINE_PROMPT_LC = ChatPromptTemplate.from_messages(CHAT_REFINE_PROMPT_TMPL_MSGS)
CHAT_REFINE_PROMPT = RefinePrompt.from_langchain_prompt(CHAT_REFINE_PROMPT_LC)
...
index.query("my query", similarity_top_k=3, refine_template=CHAT_REFINE_PROMPT)

Yes，I’m using 3.5。I came up with a new prompt early on, forcing it not to
change the original answer structure, but to optimize the original answer,
and achieved good results. Another reason I want to close it is that the
performance will have a relatively large impact after opening it,
especially for relatively long answers and streams cannot be used. I will
continue to see how to deal with it. Do you have any good suggestions for
this one? Thanks.
Logan @.***>于2023年4月24日 周一00:55写道：

It's not really possible to disable it, it's a necessary part of the
process. Some LLMs struggle with it though.
Are you using GPT-3.5? It's been struggling with the refine part for the
last week or so.
I've been working on a new refine template. Maybe try something like this:
from langchain.prompts.chat import (
AIMessagePromptTemplate,
ChatPromptTemplate,
HumanMessagePromptTemplate,
)
from llama_index.prompts.prompts import RefinePrompt
Refine Prompt
CHAT_REFINE_PROMPT_TMPL_MSGS = [
HumanMessagePromptTemplate.from_template("{query_str}"),
AIMessagePromptTemplate.from_template("{existing_answer}"),
HumanMessagePromptTemplate.from_template(
"I have more context below which can be used "
"(only if needed) to update your previous answer.\n"
"------------\n"
"{context_msg}\n"
"------------\n"
"Given the new context, update the previous answer to better "
"answer my previous query."
"If the previous answer remains the same, repeat it verbatim. "
"Never reference the new context or my previous query directly.",
),
]
CHAT_REFINE_PROMPT_LC = ChatPromptTemplate.from_messages(CHAT_REFINE_PROMPT_TMPL_MSGS)
CHAT_REFINE_PROMPT = RefinePrompt.from_langchain_prompt(CHAT_REFINE_PROMPT_LC)
...
index.query("my query", similarity_top_k=3, refine_template=CHAT_REFINE_PROMPT)
—
Reply to this email directly, view it on GitHub
https://github.com/jerryjliu/llama_index/issues/1293#issuecomment-1519109584,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJG5REBGQG2QOHNUNMLC3GTXCVNG7ANCNFSM6AAAAAAXIKKQHQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

It's not really possible to disable it, it's a necessary part of the process. Some LLMs struggle with it though.
Are you using GPT-3.5? It's been struggling with the refine part for the last week or so.
I've been working on a new refine template. Maybe try something like this:
from langchain.prompts.chat import (
    AIMessagePromptTemplate,
    ChatPromptTemplate,
    HumanMessagePromptTemplate,
)

from llama_index.prompts.prompts import RefinePrompt

# Refine Prompt
CHAT_REFINE_PROMPT_TMPL_MSGS = [
    HumanMessagePromptTemplate.from_template("{query_str}"),
    AIMessagePromptTemplate.from_template("{existing_answer}"),
    HumanMessagePromptTemplate.from_template(
        "I have more context below which can be used "
        "(only if needed) to update your previous answer.\n"
        "------------\n"
        "{context_msg}\n"
        "------------\n"
        "Given the new context, update the previous answer to better "
        "answer my previous query."
        "If the previous answer remains the same, repeat it verbatim. "
        "Never reference the new context or my previous query directly.",
    ),
]

CHAT_REFINE_PROMPT_LC = ChatPromptTemplate.from_messages(CHAT_REFINE_PROMPT_TMPL_MSGS)
CHAT_REFINE_PROMPT = RefinePrompt.from_langchain_prompt(CHAT_REFINE_PROMPT_LC)
...
index.query("my query", similarity_top_k=3, refine_template=CHAT_REFINE_PROMPT)

Yes，I’m using 3.5。I came up with a new prompt early on, forcing it not to
change the original answer structure, but to optimize the original answer, and achieved good results.
Another reason I want to close it is that the performance will have a relatively large impact after opening it, especially for relatively long answers and streams cannot be used. I will continue to see how to deal with it. Do you have any good suggestions for this one? Thanks.

The best option for limiting the refine is usually using a smaller chunk size (and if using a vector index, you can use index.query(..., response_mode="compact"), which helps when your similarity_top_k is greater than 1)

The best option for limiting the refine is usually using a smaller chunk size (and if using a vector index, you can use index.query(..., response_mode="compact"), which helps when your similarity_top_k is greater than 1)

Thanks，I will try it tomorrow ！

Hi @xingcici, did you get the solution for this issue. I got the same problem.


client_max_body_size seems has no effect

I got wierd problem. Running nginx container behind nginx-proxy. Wordpress inside. I have set client_max_body_size nginx container (http, server, location sections), i have set it in http sections of nginx-proxy in nginx.conf, i also have it in vhost.d/default. I have set correspnding php.ini variables in php container. However max upload size is still limited by 2M. Cant figure out whats wrong. Is there any idea how i can fix this?

here is my PR:
https://github.com/jwilder/nginx-proxy/pull/858
I hope it can help you.

@Evzin are you getting HTTP 413 Request entity too large, or some other error?

I just ran to the same issue.
Error: 413 Request Entity Too Large, although /etc/nginx/conf.d/upload.conf sets client_max_body_size 10M;

I was able to provide this parameter by writing client_max_body_size 4096M into /etc/nginx/conf.d/larger_body.conf. After restarting the container, the previous "413 Request Entity is Too Large" stopped occurring.


Make possible to create a SigningService with an owned String

The SigningService has an inner type of Cow<'static, str>, but no public way of constructing it with an owned value (there's only from_static). Another function or trait implementation should be added to be able to create it from String.

This went out with smithy-rs 0.36.0.


Remove TestGoroutineLeak unit tests.

We are seeing some flakes on these tests because some goroutine fluctuation:
https://github.com/kubernetes/node-problem-detector/pull/275#issuecomment-499306727
Removing the tests, as it's most robust to test leakage in a soak/stress test, rather than unit test.

Seems Lantao wrote the test, so:
/assign @Random-Liu

/ok-to-test

The test doesn't make sense. Not sure why someone (me...) added it.

/lgtm
/approve

Thanks Lantao!


As a SEM student I will write the reports for: Pop of people living in cities & not living in cities ( for continent, region OR country)

bto3toc0-2@#


Xcode 10.2 / Swift 5 support

Please, release a new version with Xcode 10.2 / Swift 5 support. There's already a PR #22 available and ready to be merged.

Is there anybody maintaining this project? This issue was opened almost one month and a half ago with a working PR and it's still open

@jgongo I had a previous PR (to update to Swift 4.2) merged within a reasonable timeframe, but this one is taking an exceptionally long time unfortunately.

@jgongo I had a previous PR (to upgrade to Swift 4.2) merged within a reasonable timeframe, but unfortunately this seems to be taking an exceptionally long time. I currently have my dependency management tool pointing to my fork, feel free to do the same for the time being.

Is this library abandoned?


blacklist x-schema protocol

as titled

@neraliu please review
c.c. @maditya

i accidentally merged this, and review is still needed to confirm such a merge.


Could not find com.google.android.gms:play-services-ads-lite:12.0.1.

Having trouble building my Android app with the command react-native run-android. Got this error:
Nicholass-MacBook-Pro:MonsterHunterWorld nicholaslie$ react-native run-android
Scanning folders for symlinks in /Users/nicholaslie/Documents/Personal/React Native/MonsterHunterWorld/node_modules (16ms)
JS server already running.
Building and installing the app on the device (cd android && ./gradlew installDebug)...
Incremental java compilation is an incubating feature.

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':app'.
> Could not resolve all dependencies for configuration ':app:_debugApk'.
   > A problem occurred configuring project ':react-native-admob'.
      > Could not resolve all dependencies for configuration ':react-native-admob:_debugPublishCopy'.
         > Could not find com.google.android.gms:play-services-ads-lite:12.0.1.
           Searched in the following locations:
               file:/Users/nicholaslie/Library/Android/sdk/extras/google/m2repository/com/google/android/gms/play-services-ads-lite/12.0.1/play-services-ads-lite-12.0.1.pom
               file:/Users/nicholaslie/Library/Android/sdk/extras/google/m2repository/com/google/android/gms/play-services-ads-lite/12.0.1/play-services-ads-lite-12.0.1.aar
               file:/Users/nicholaslie/Documents/Personal/React Native/MonsterHunterWorld/android/sdk-manager/com/google/android/gms/play-services-ads-lite/12.0.1/play-services-ads-lite-12.0.1.aar
               file:/Users/nicholaslie/Library/Android/sdk/extras/android/m2repository/com/google/android/gms/play-services-ads-lite/12.0.1/play-services-ads-lite-12.0.1.pom
               file:/Users/nicholaslie/Library/Android/sdk/extras/android/m2repository/com/google/android/gms/play-services-ads-lite/12.0.1/play-services-ads-lite-12.0.1.aar
               file:/Users/nicholaslie/Documents/Personal/React Native/MonsterHunterWorld/android/sdk-manager/com/google/android/gms/play-services-ads-lite/12.0.1/play-services-ads-lite-12.0.1.aar
           Required by:
               MonsterHunterWorld:react-native-admob:unspecified > com.google.android.gms:play-services-ads:12.0.1
         > Could not find com.google.android.gms:play-services-basement:12.0.1.
           Searched in the following locations:
               file:/Users/nicholaslie/Library/Android/sdk/extras/google/m2repository/com/google/android/gms/play-services-basement/12.0.1/play-services-basement-12.0.1.pom
               file:/Users/nicholaslie/Library/Android/sdk/extras/google/m2repository/com/google/android/gms/play-services-basement/12.0.1/play-services-basement-12.0.1.aar
               file:/Users/nicholaslie/Documents/Personal/React Native/MonsterHunterWorld/android/sdk-manager/com/google/android/gms/play-services-basement/12.0.1/play-services-basement-12.0.1.aar
               file:/Users/nicholaslie/Library/Android/sdk/extras/android/m2repository/com/google/android/gms/play-services-basement/12.0.1/play-services-basement-12.0.1.pom
               file:/Users/nicholaslie/Library/Android/sdk/extras/android/m2repository/com/google/android/gms/play-services-basement/12.0.1/play-services-basement-12.0.1.aar
               file:/Users/nicholaslie/Documents/Personal/React Native/MonsterHunterWorld/android/sdk-manager/com/google/android/gms/play-services-basement/12.0.1/play-services-basement-12.0.1.aar
           Required by:
               MonsterHunterWorld:react-native-admob:unspecified > com.google.android.gms:play-services-ads:12.0.1
         > Could not find com.google.android.gms:play-services-gass:12.0.1.
           Searched in the following locations:
               file:/Users/nicholaslie/Library/Android/sdk/extras/google/m2repository/com/google/android/gms/play-services-gass/12.0.1/play-services-gass-12.0.1.pom
               file:/Users/nicholaslie/Library/Android/sdk/extras/google/m2repository/com/google/android/gms/play-services-gass/12.0.1/play-services-gass-12.0.1.aar
               file:/Users/nicholaslie/Documents/Personal/React Native/MonsterHunterWorld/android/sdk-manager/com/google/android/gms/play-services-gass/12.0.1/play-services-gass-12.0.1.aar
               file:/Users/nicholaslie/Library/Android/sdk/extras/android/m2repository/com/google/android/gms/play-services-gass/12.0.1/play-services-gass-12.0.1.pom
               file:/Users/nicholaslie/Library/Android/sdk/extras/android/m2repository/com/google/android/gms/play-services-gass/12.0.1/play-services-gass-12.0.1.aar
               file:/Users/nicholaslie/Documents/Personal/React Native/MonsterHunterWorld/android/sdk-manager/com/google/android/gms/play-services-gass/12.0.1/play-services-gass-12.0.1.aar
           Required by:
               MonsterHunterWorld:react-native-admob:unspecified > com.google.android.gms:play-services-ads:12.0.1
         > Could not find com.google.android.gms:play-services-ads-license:12.0.1.
           Searched in the following locations:
               file:/Users/nicholaslie/Library/Android/sdk/extras/google/m2repository/com/google/android/gms/play-services-ads-license/12.0.1/play-services-ads-license-12.0.1.pom
               file:/Users/nicholaslie/Library/Android/sdk/extras/google/m2repository/com/google/android/gms/play-services-ads-license/12.0.1/play-services-ads-license-12.0.1.aar
               file:/Users/nicholaslie/Documents/Personal/React Native/MonsterHunterWorld/android/sdk-manager/com/google/android/gms/play-services-ads-license/12.0.1/play-services-ads-license-12.0.1.aar
               file:/Users/nicholaslie/Library/Android/sdk/extras/android/m2repository/com/google/android/gms/play-services-ads-license/12.0.1/play-services-ads-license-12.0.1.pom
               file:/Users/nicholaslie/Library/Android/sdk/extras/android/m2repository/com/google/android/gms/play-services-ads-license/12.0.1/play-services-ads-license-12.0.1.aar
               file:/Users/nicholaslie/Documents/Personal/React Native/MonsterHunterWorld/android/sdk-manager/com/google/android/gms/play-services-ads-license/12.0.1/play-services-ads-license-12.0.1.aar
           Required by:
               MonsterHunterWorld:react-native-admob:unspecified > com.google.android.gms:play-services-ads:12.0.1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 20.356 secs
Could not install the app on the device, read the error above for details.
Make sure you have an Android emulator running or a device connected and have
set up your Android development environment:
https://facebook.github.io/react-native/docs/getting-started.html

I'm currently using react-native-admob version 2.0.0-beta.5
"react-native-admob": "^2.0.0-beta.5",
My top-level build.gradle:
// Top-level build file where you can add configuration options common to all sub-projects/modules.

buildscript {
    repositories {
        jcenter()
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:2.2.3'

        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files
    }
}

allprojects {
    repositories {
        mavenLocal()
        jcenter()
        maven {
            // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
            url "$rootDir/../node_modules/react-native/android"
        }
    }
}

My app-level build.gradle:
apply plugin: "com.android.application"

import com.android.build.OutputFile

/**
 * The react.gradle file registers a task for each build variant (e.g. bundleDebugJsAndAssets
 * and bundleReleaseJsAndAssets).
 * These basically call `react-native bundle` with the correct arguments during the Android build
 * cycle. By default, bundleDebugJsAndAssets is skipped, as in debug/dev mode we prefer to load the
 * bundle directly from the development server. Below you can see all the possible configurations
 * and their defaults. If you decide to add a configuration block, make sure to add it before the
 * `apply from: "../../node_modules/react-native/react.gradle"` line.
 *
 * project.ext.react = [
 *   // the name of the generated asset file containing your JS bundle
 *   bundleAssetName: "index.android.bundle",
 *
 *   // the entry file for bundle generation
 *   entryFile: "index.android.js",
 *
 *   // whether to bundle JS and assets in debug mode
 *   bundleInDebug: false,
 *
 *   // whether to bundle JS and assets in release mode
 *   bundleInRelease: true,
 *
 *   // whether to bundle JS and assets in another build variant (if configured).
 *   // See http://tools.android.com/tech-docs/new-build-system/user-guide#TOC-Build-Variants
 *   // The configuration property can be in the following formats
 *   //         'bundleIn${productFlavor}${buildType}'
 *   //         'bundleIn${buildType}'
 *   // bundleInFreeDebug: true,
 *   // bundleInPaidRelease: true,
 *   // bundleInBeta: true,
 *
 *   // whether to disable dev mode in custom build variants (by default only disabled in release)
 *   // for example: to disable dev mode in the staging build type (if configured)
 *   devDisabledInStaging: true,
 *   // The configuration property can be in the following formats
 *   //         'devDisabledIn${productFlavor}${buildType}'
 *   //         'devDisabledIn${buildType}'
 *
 *   // the root of your project, i.e. where "package.json" lives
 *   root: "../../",
 *
 *   // where to put the JS bundle asset in debug mode
 *   jsBundleDirDebug: "$buildDir/intermediates/assets/debug",
 *
 *   // where to put the JS bundle asset in release mode
 *   jsBundleDirRelease: "$buildDir/intermediates/assets/release",
 *
 *   // where to put drawable resources / React Native assets, e.g. the ones you use via
 *   // require('./image.png')), in debug mode
 *   resourcesDirDebug: "$buildDir/intermediates/res/merged/debug",
 *
 *   // where to put drawable resources / React Native assets, e.g. the ones you use via
 *   // require('./image.png')), in release mode
 *   resourcesDirRelease: "$buildDir/intermediates/res/merged/release",
 *
 *   // by default the gradle tasks are skipped if none of the JS files or assets change; this means
 *   // that we don't look at files in android/ or ios/ to determine whether the tasks are up to
 *   // date; if you have any other folders that you want to ignore for performance reasons (gradle
 *   // indexes the entire tree), add them here. Alternatively, if you have JS files in android/
 *   // for example, you might want to remove it from here.
 *   inputExcludes: ["android/**", "ios/**"],
 *
 *   // override which node gets called and with what additional arguments
 *   nodeExecutableAndArgs: ["node"],
 *
 *   // supply additional arguments to the packager
 *   extraPackagerArgs: []
 * ]
 */

project.ext.react = [
    entryFile: "index.js"
]

apply from: "../../node_modules/react-native/react.gradle"

/**
 * Set this to true to create two separate APKs instead of one:
 *   - An APK that only works on ARM devices
 *   - An APK that only works on x86 devices
 * The advantage is the size of the APK is reduced by about 4MB.
 * Upload all the APKs to the Play Store and people will download
 * the correct one based on the CPU architecture of their device.
 */
def enableSeparateBuildPerCPUArchitecture = false

/**
 * Run Proguard to shrink the Java bytecode in release builds.
 */
def enableProguardInReleaseBuilds = false

android {
    compileSdkVersion 23
    buildToolsVersion "23.0.1"

    defaultConfig {
        applicationId "nicholaslie.monsterhunterworld"
        minSdkVersion 16
        targetSdkVersion 26
        versionCode 95
        versionName "1.0.36"
        ndk {
            abiFilters "armeabi-v7a", "x86"
        }
    }
    signingConfigs {
        release {
            if (project.hasProperty('MYAPP_RELEASE_STORE_FILE')) {
                storeFile file(MYAPP_RELEASE_STORE_FILE)
                storePassword MYAPP_RELEASE_STORE_PASSWORD
                keyAlias MYAPP_RELEASE_KEY_ALIAS
                keyPassword MYAPP_RELEASE_KEY_PASSWORD
            }
        }
    }
    splits {
        abi {
            reset()
            enable enableSeparateBuildPerCPUArchitecture
            universalApk false  // If true, also generate a universal APK
            include "armeabi-v7a", "x86"
        }
    }
    buildTypes {
        debug {
                manifestPlaceholders = [excludeSystemAlertWindowPermission: "false"]
        }
        release {
            minifyEnabled enableProguardInReleaseBuilds
            proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
            manifestPlaceholders = [excludeSystemAlertWindowPermission: "true"]
            signingConfig signingConfigs.release
        }
    }
    // applicationVariants are e.g. debug, release
    applicationVariants.all { variant ->
        variant.outputs.each { output ->
            // For each separate APK per architecture, set a unique version code as described here:
            // http://tools.android.com/tech-docs/new-build-system/user-guide/apk-splits
            def versionCodes = ["armeabi-v7a":1, "x86":2]
            def abi = output.getFilter(OutputFile.ABI)
            if (abi != null) {  // null for the universal-debug, universal-release variants
                output.versionCodeOverride =
                        versionCodes.get(abi) * 1048576 + defaultConfig.versionCode
            }
        }
    }
}

dependencies {
    compile project(':react-native-device-info')
    compile project(':react-native-i18n')
    compile project(':react-native-billing')
    compile project(':react-native-admob')
    compile fileTree(dir: "libs", include: ["*.jar"])
    compile "com.android.support:appcompat-v7:23.0.1"
    compile "com.facebook.react:react-native:+"  // From node_modules
    compile project(':react-native-photo-view')
}

// Run this once to be able to run the application with BUCK
// puts all compile dependencies into folder libs for BUCK to use
task copyDownloadableDepsToLibs(type: Copy) {
    from configurations.compile
    into 'libs'
}

Been stuck for hours trying to find a solution for this. Tried downgrading to a previous version, unlink and relinking the library, removing the node_modules folder and performing a fresh npm install also don't work. Any ideas?

Getting the same error. I`m also using "react-native-admob": "^2.0.0-beta.5"

Finally got this to work after spending an entire day. I think it's caused by my outdated Gradle tools. What you need to do to fix this is open your android folder in Android Studio (project_root/android), until you get something similar to this in the Project (left-hand pane).

Android Studio can scan for the project dependencies and see if there's any issues with the Gradle files in all of them. What I did is simply upgrade by Gradle definition and tools by using Android Studio.
Once you've done this, try re-running react-native run-android and it should work once again. Hope this helps!

I did following change and got worked

//compile 'com.google.android.gms:play-services-ads:+'

compile 'com.google.android.gms:play-services-ads:11.0.2'


Address shadowing divergence in reftest, update semantics doc

This commit addresses a case where MP model and property tests diverge (https://github.com/awslabs/mountpoint-s3/pull/1066). The issue was caused by the reference not correctly implementing the shadowing order defined in #4f8cf0b. This commit fixes the reference model, and clarifies the semantics arising from concurrent MPUs.
This is not a breaking change, as it only impacts the reference tests.
This does not need a Changelog entry, as the change does not impact Mountpoint's behaviour.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).

This PR closes #1066.


fix: start dedicated process for runtime logging

Current dependencies on/for this PR:

main

PR #94   👈

PR #95

This comment was auto-generated by Graphite.


Restore branch

This pull request includes fixed to binary and binary to fixed conversion using multiplication and getting the exponent from the command line.

Hmm; I'm not sure what's going on… this still seems to have branched from the wrong place! main.rs is appearing as a completely new file. Maybe we should work though this git mess together?


Exposing a stored procedure to detect whether security is enabled on

snappy cluster or not.
Changes proposed in this pull request

Exposing a stored procedure to detect whether security is enabled on snappy cluster or not. This needs to be done for the smart connector mode.
Fixing kafka utils clean-up for DUnit tests.

Patch testing
Manually tested using snappy-shell. Scalatests and DUnit tests for snappy streaming sink also covers this change.
Is precheckin with -Pstore clean?
Yet to be checked.
ReleaseNotes changes
(Does this change require an entry in ReleaseNotes? If yes, has it been added to it?)
Other PRs
https://github.com/SnappyDataInc/snappydata/pull/1249

Not required anymore as the security status of the cluster can be checked from smart connector mode by attempting to take a JDBC connection.


Error handling for device connection needed

Application crashes on device errors (e.g. start application when no device is plugged in).

Startup is now fixed, now needs error handling in the case of device being disconnected and reconnected while running.


⚠ Spryr has degraded performance

In b507906, Spryr (https://spryr.com) experienced degraded performance:

HTTP code: 200
Response time: 5165 ms

Resolved: Spryr performance has improved in 7d98981 after 21 minutes.


Replace Carbon with ApplicationServices

This is macOS only.
Rather than linking to the Carbon framework, I'm pretty sure you can just link to the ApplicationServices framework, and in SystemMonitor_macos.cpp replace the include with ApplicationServices/ApplicationServices.h. I think that's the only usage of Carbon anyway.
Similarly, linking to this framework (here) only needs to be done if OCIO_HEADLESS_ENABLED is not defined (on another note, I couldn't find if this is enabled by CMake, I've been enabling it manually by adding it to the compiler flags).
I could submit a PR, but it might take time to go through legal.

A PR would certainly be welcome @SRHMorris.


Size are not applied to the text[BUG]

Describe the bug
I add size to the text, but I don't see changes
To Reproduce
this is my code:
draw.component.html
<svg-text ... [size]="sizeText" [color]="colorText" ></svg-text>
draw.component.ts
export class DrawComponent implements OnInit {
...
public sizeText: number;
...
ngOnInit() { ...  this.sizeText = 8; ... }
}

Expected behavior
I want to see a smaller text.
Screenshots

Desktop (please complete the following information):

OS: Windows 8
Browser Google Chrome
Version 80.0.3987.149

Additional context
Angular 8
demo

Hi @oduvanka !
Thank you. I was able to reproduce the issue and will try to make a release either later today or tomorrow. Will inform you here.

Hi @oduvanka .
Bug has been fixed in release v1.0.2.
Please, let me know if the issue still persists.

Thank you, problem solved )))))))))))


infinite loading screen and disconnected from RGL

Definitely insufficient info to confirm this mod indeed has the issues related to this issue. Provide info as much as you can. It would be great if you could provide how to reproduce.


Vcpkg cmake presets

use vcpkg to manage deps
use CMake presets to manage build configurations
update ziti-sdk to v0.32.0

@ekoby I have started a package build on this branch to test.
https://github.com/openziti/ziti-tunnel-sdk-c/actions/workflows/cpack.yml?query=branch%3Avcpkg-cmake-presets

@ekoby I have started a package build on this branch to test.
https://github.com/openziti/ziti-tunnel-sdk-c/actions/workflows/cpack.yml?query=branch%3Avcpkg-cmake-presets

@qrkourier this needs to be changed to add run-vcpkg step and use an appropriate CMake preset.
We can probably refactor those steps into one action (similar to ziti-sdk-c)

the windows-arm64 archive contains amd64 stuff.


WebSearch: default sorting per collection

Currently, several sorting (or ranking) algorithm can be configured per every collection in Invenio (master and earlier). However the default sorting configuration is silently set to be "Latest First", which, in Invenio master and earlier, is not even possible to deactivate.
At INSPIRE, "Latest First", where the date is computed from the bibliographic metadata, is a perfect default for the "HEP" (i.e. the Literature collection), the "Conferences" and "Jobs" collections. However it is sub-optimal for e.g. the "HepNames" (i.e. People collection), "Experiments", "Institutions" and "Journals" collection, where a default alphabetical sorting on the key name is making more sense.

Invenio-Collections package has been simplified. This feature can be done by creating custom template with default sorting option for Invenio-Search-JS.


extensions/v1beta1 -> apps/v1

Proposed changes
extensions/v1beta1 will be deprecated in 1.16. See release notes - https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.15.md#deprecations-and-removals
Types of changes
What types of changes does your code introduce?
Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist
Put an x in the boxes that apply.

[x] I have read the CONTRIBUTING doc
[x] I have read the CLA
[x] I have added necessary documentation (if appropriate)
[x] Any dependent changes have been merged and published in downstream modules

While you are at it I would recommend you to change the following deprecations to

https://github.com/splunk/splunk-connect-for-kubernetes/blob/develop/helm-chart/splunk-kubernetes-objects/templates/deployment.yaml#L1
https://github.com/splunk/splunk-connect-for-kubernetes/blob/develop/helm-chart/splunk-kubernetes-metrics/templates/deploymentMetricsAggregator.yaml#L1

Updated.  Please review again.

I'll need to update this.  Just realized today during testing that apps/v1 requires an explicit selector field.

Please review again.


feature request: skip local storage for backups

It would be great to have an option to back-up straight to cloud storage as otherwise, with larger datasets, the local storage requirements get quite big. Alternatively, an option to not keep local backups would also be fine (currently setting retention: 0 does nothing).

lately I am a bit busy. I will try to do this when I have time. welcome to send a PR

Hi, could you test this one maxisam/mgob:dev.113
You just need to set retention to 0 in the plan. thx!

Will check and report shortly.

It doesn't seem to work. The dump is still copied over to /storage after the backup. I double-checked that I'm running the correct image as advised above.

 Could you test dev.115 ?

No problem, thanks a lot for taking a look. I've rolled out the new version, but no luck. It's still copying the file over to /storage after the backup is complete. Here's a snippet of the container log:
time="2022-12-23T13:05:08Z" level=info msg="On demand backup started" plan=testdb-daily
time="2022-12-23T13:06:03Z" level=info msg="new dump" archive=/tmp/testdb-daily-1671800708.gz err="<nil>" mlog=/tmp/testdb-daily-1671800708.log
time="2022-12-23T13:06:03Z" level=info msg="Local backup finished Local backup finished `/tmp/testdb-daily-1671800708.gz` -> `/storage/testdb-daily/testdb-daily-1671800708.gz` Duration: 122.00008ms" plan=testdb-daily
time="2022-12-23T13:06:08Z" level=info msg="S3 upload finished " plan=testdb-daily
time="2022-12-23T13:06:08Z" level=info msg="Clean up temp finished Temp folder cleanup finished, `/tmp/testdb-daily-1671800708.gz` is removed." plan=testdb-daily
time="2022-12-23T13:06:08Z" level=info msg="On demand backup finished in 1m0.604096637s archive testdb-daily-1671800708.gz size 270 MB" plan=testdb-daily

I've validated using the correct image, dev.115. Let me know if there's anything else I can do on my side.

Do you set retention: 0 on that plan?

dev.116 should work!  This must be the punish from the unit test God.

Works like a charm, thanks a lot for this! :tada:

Thanks for testing! Here is the release https://github.com/maxisam/mgob/releases/tag/1.10.14


Data Upload API Documentation solution

User Story
As a developer using an API
I expect to understand how to format my API requests
So that I can integrate with the API for my use case

API Gateway can serve swagger JSON via the /docs endpoint of your API:
https://code.mendhak.com/api-gateway-self-hosted-documentation/

Definition of done

[ ] docs-as-code solution chosen - include the written justifications on this issue.
[ ] baseline patterns of documentation established, with all current endpoints documented as an example
[ ] working demonstrable documentation solution

https://github.com/ministryofjustice/modernisation-platform-environments/pull/2507

https://editor.swagger.io/ good for editing docs


Add all artifacts to maintainers and issue lists when wildcard is used

Fixes #2911
Allows each component to define extra artifact names, those then inherit the same maintainers and issue tracker(s) as the parent component.
A more straightforward approach might be to just define paths explicitly for each component without using *, but since the last element of path sometimes doesn't match the component name and the component name takes precedence, I decided to add a new field to Definition for defining the extra components.

define paths explicitly for each component without using *

Needs to be tested first. For some plugins that moved groupIds a few times we had to remove the old ones due to permission target length limitations at the time.


[DOCFIX] Add fix to errors that new users might get

Adding fix to errors that new users might get

Codecov Report

Merging #13573 (ff5d462) into master (1a4841c) will decrease coverage by 26.16%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #13573       +/-   ##
=============================================
- Coverage     43.76%   17.60%   -26.17%
+ Complexity     9039     2665     -6374
=============================================
  Files          1377     1377
  Lines         79873    79867        -6
  Branches       9709     9709
=============================================
- Hits          34956    14060    -20896
- Misses        41973    64565    +22592
+ Partials       2944     1242     -1702

Impacted Files
Coverage Δ

...a/alluxio/master/file/DefaultFileSystemMaster.java
15.99% <0.00%> (-48.72%)
:arrow_down:

.../alluxio/underfs/cephfs/CephFSUnderFileSystem.java
0.00% <0.00%> (ø)

...mon/src/main/java/alluxio/shell/CommandReturn.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...mon/src/main/java/alluxio/util/ExceptionUtils.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/src/main/java/alluxio/wire/AlluxioProxyInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

.../src/main/java/alluxio/wire/AlluxioMasterInfo.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/main/java/alluxio/job/meta/JobIdGenerator.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...n/src/main/java/alluxio/stress/BaseParameters.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...src/main/java/alluxio/client/UnderStorageType.java
0.00% <0.00%> (-100.00%)
:arrow_down:

...main/java/alluxio/underfs/options/ListOptions.java
0.00% <0.00%> (-100.00%)
:arrow_down:

... and 659 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c219d25...ff5d462. Read the comment docs.

alluxio-bot, merge this please

alluxio-bot, cherry-pick this to branch-2.6 please


Update Function interface

@deerzq @yolken @hectorgon @spencerde @christhetree

@deerzq thanks for review, all updated!

some nits, overall LGTM


Serve bors from root URL

I am not 100% sure this will work with the lets encrypt refreshing but I don't know of a good way to test that. We can always "just" refresh manually though if needed or so, I don't think we need to worry about that right this minute. I do believe it should work though.
r? @pietroalbini

Thanks!


Bug with Border in Transparent Image

When I use a transparent image then the border is not has a fix size.

Could you explain your issue more please?

I  use a image with transparent background. That time my border color fill the transparent part of image.

I have that issue too. Please resolve.

I have this issue too! :(


Apply the special COVID-19 related rules for SSP

This introduces a new question to see if the worker is self-isolating for Coronavirus on or after 13 March 2020. If so, new rules for qualifying for SSP apply. In all other cases, the calculation remains the same.
https://trello.com/c/td0XUZol/1834-5-urgent-amend-statutory-sick-pay-calculator-for-coronavirus
Co-authored-by: Alan Gabbianelli<EMAIL_ADDRESS>Reverts alphagov/smart-answers#4387, which was a reversion of the original PR alphagov/smart-answers#4382

I believe this is good to go now, so merging.