Fix multi-user capabilities MRTK2 tutorials so content aligns correctly for all users

Describe the bug
This is tracking an issue from the ASA project

https://github.com/Azure/azure-spatial-anchors-samples/issues/403

The bug describes on the MRTK tutorial is not correctly aligning content of all HoloLens 2 users joined to the same sharing session. We should investigate and fix any bugs in the sample code that is causing this misalignment.
Details
The original creator of the source bug writes:

Hi,
I'm using unity 2020.3.42f1, I'm running it with a PUN app and have 2 different hololens where I deploy the application (+my computer)
I'm doing my bachelor project on the multi-user capabilities of the Hololens. I have tried to follow this tutorial: https://learn.microsoft.com/en-us/windows/mixed-reality/develop/unity/tutorials/mr-learning-sharing-01
Everything is working fine with the pun app, and I am able to view the players inside of the Room. The only thing missing for making it a shared experience is to have the coordinate system of all the different players to be the same. I have tried to introduce an azure spatial anchor to to share the location of the table (the object in the SharedPlayGround that defines the coordinate system of the position of the players) to the players so that their coordinate system lines up. The anchor is shared with the Sharing Module script and the Anchor Module.
But whenever I deploy the application on two different hololens the position dosen't match up. (the player is also represented with a sphere and it dosen't coincide with the real position of the player.
How to run the app:
wearer A:
start an azure session
creates a local anchor
shares this anchor
(these steps seem to work as the have the correct logs)
wearer B:
start an azure session
get the anchor
And here the issue occurs, the anchors seems to move a bit but it's position dosen't coincide with the position of anchor A -- here you can see the logs:

I don't know if the null reference is the root of my issue. Another idea I have, is that maybe the environment isn't scanned enough before creating the achor (but I have a log telling me if that was the case - and it dosen't get printed so are we fine ?)
It would help me so much if you could help me, I have been struggling with this problems for weeks.

Hi @AMollis,
We appreciate your feedback and thank you for reporting this issue.
Microsoft Mixed Reality Toolkit version 2 (MRTK2) is currently in limited support. This means that Microsoft is only fixing high priority security issues. Unfortunately, this issue does not meet the necessary priority and will be closed. If you strongly feel that this issue deserves more attention, please open a new issue and explain why it is important.
Microsoft recommends that all new HoloLens 2 Unity applications use MRTK3 instead of MRTK2.
Please note that MRTK3 was released in August 2023. It features an all new architecture for developing rich mixed reality experiences and has a minimum requirement of Unity 2021.3 LTS. For more information about MRTK3, please visithttps://www.mixedrealitytoolkit.org.
Thank you for your continued support of the Mixed Reality Toolkit!


Be able to silence the license output logging

I have a multimodule project with maaaany classes. My build log is completely polluted with all the format/remove statements per file.
It would be nice to be able to suppress that output in case of success.

can't you just skip the execution ?

@McFoggy Are you suggesting that the solution to silencing the verbose logging output is to not use the plugin at all? Then no, I can't just skip the execution :)

so you would expect just a kind of 'resume' instead of the full log, right?

Something like a 'quiet' property similar to the javadoc-plugin, assertj-plugin etc etc

did you already tried the quiet property of the plugin?
You should be able to set it via plugin configuration:
<plugin>
    <groupId>com.mycila</groupId>
    <artifactId>license-maven-plugin</artifactId>
    <version>X.Y.ga</version>
    <configuration>
        <quiet>true</quiet>
...
</plugin>

or override via a runtime property license.quiet as in mvn license:check -Dlicense.quiet=true

Yeah I found that property I don't remember if I'm still having a problem, I'll close this issue until I remember :P


Zoom Browser window，table does not display normaly?

Description
Zoom Browser window，table does not display normaly?
Zoom Browser window

Your environment
mac and windows system browser

Hey @allan2coder
Can you send me over a demo where this issue can be replicable?
I wasn't able to replicate it with this demo https://handsontable.com/docs/6.2.0/demo-hiding-columns.html

Closing this as we can't replicate the issue.


fix: popover display issue of safari

Description
This PR is a hacky fix to the radix popover and dialog issue in safari
What i did

refactored the popover to use a predefined useState to handle the open and close state manually
set the open state to true on icon click
added a mousedown event listener to the document to know detect when a user clicks outside the popover content so i can set the open state to false.
also added an addition useEffect to set the open state to false when users select a date( can be reverted if it is not necessary)

What type of PR is this? (check all applicable)

[ ] 🍕 Feature
[x] 🐛 Bug Fix
[ ] 📝 Documentation Update
[ ] 🎨 Style
[ ] 🧑💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test
[ ] 🤖 Build
[ ] 🔁 CI
[ ] 📦 Chore (Release)
[ ] ⏩ Revert

Related Tickets & Documents
fixes #1144

Mobile & Desktop Screenshots/Recordings
Before
https://github.com/open-sauced/app/assets/62995161/cb11c435-9bf8-4e61-860b-910c8535f882
After
https://github.com/open-sauced/app/assets/62995161/ea14a093-a818-4da5-9bff-796b8e6ff265

Added tests?

[ ] 👍 yes
[x] 🙅 no, because they aren't needed
[ ] 🙋 no, because I need help

Added to documentation?

[ ] 📜 README.md
[ ] 📓 docs.opensauced.pizza
[ ] 🍕 dev.to/opensauced
[ ] 📕 storybook
[x] 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?

Just remembered we have this also in the create highlight form... adding this fix there shortly

This is good for review now @open-sauced/engineering


Barebones - base contracts

Create the simplest smart account with modular verification, for quick audit and dApp integrations.
To keep simple this will initially not be 6900+4337 compatible.

Single ECDSA verifier


[MRESOLVER-320] Return to original pool setup

There was some information lost on the way how we got to current master: artifact and dependency was ALWAYS weak, and the "cause" commit 6dda69980cf4c13228a4f6561bfa0d8384a0be68 modified ONLY the descriptor pool (was hard by mistake, made it weak). This also explain why we saw with yourkit excess Xpp3 and model building requests as well (as starting with 1.8.x descriptors/POMs were GCed, while before they were not). And Peter also saw a lot of Artifact ctors, something I with my patch did not (as my patch modified that pool as well). Finally, this may also explain the 550MB vs 1.1GB diff as well, as it is huge.
This PR essentially returns the state of affairs to pre 1.8.x resolver state re data pools, but also adds ability to "tune" each three of them separately.
Maven 3.8.x (well, resolver in it) was:

artifact = weak
dependency = weak
descriptor = hard (by mistake, intent was weak), reported as MRESOLVER-250

Maven 3.9.0 used resolver that contained fix for MRESOLVER-250:

artifact = weak
dependency = weak
descriptor = weak

This is why we saw bazillion of model building requests, as POMs were GCed and they were rebuilt continuosly.
My original patch was way too aggressive, as it did:

artifact = hard
dependency = hard
descriptor = hard

Finally, this PR does:

artifact = weak
dependency = weak
descriptor = hard (intentionally)

With this PR now all these configurations are possible.

https://issues.apache.org/jira/browse/MRESOLVER-320

What do numbers say now?

My licensed YK is on desktop linux, so will have them tomorrow. But all in all, I think my original patch got a bit "carried away", and this really returns things how they were supposed to be after all... IMHO, this is safe to merge, as not only this returns "original state", but also makes possible to tune all. At the end, we may want to change some defaults, but that's it.

@psiroky ping, and would be nice if you could get some numbers tomorrow as well

I will run some more tests tomorrow. So far I just tried to run the validate -Dversion.enforcer.plugin=3.2.1 -T8 (on Quarkus again), which seems to be almost on par with Maven 3.8.7 (9s vs 9.3s, and vs 11s for Maven 3.9.0).
However, I also got this exception in one of the runs
Caused by: java.lang.NullPointerException: Cannot invoke "org.eclipse.aether.graph.Dependency.getArtifact()" because "dependency" is null
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollectionContext.set (DefaultDependencyCollectionContext.java:75)
    at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.doRecurse (DfDependencyCollector.java:261)
    at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.processDependency (DfDependencyCollector.java:236)
    at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.processDependency (DfDependencyCollector.java:137)
    at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.process (DfDependencyCollector.java:125)
    at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.doRecurse (DfDependencyCollector.java:284)
    at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.processDependency (DfDependencyCollector.java:236)
    at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.processDependency (DfDependencyCollector.java:137)
    at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.process (DfDependencyCollector.java:125)
    at org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.doCollectDependencies (DfDependencyCollector.java:107)
    at org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies (DependencyCollectorDelegate.java:247)
    at org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies (DefaultDependencyCollector.java:95)
    at org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies (DefaultRepositorySystem.java:327)
    at org.apache.maven.enforcer.rules.dependency.ResolveUtil.resolveTransitiveDependencies (ResolveUtil.java:101)
    at org.apache.maven.enforcer.rules.dependency.DependencyConvergence.execute (DependencyConvergence.java:65)
    at org.apache.maven.plugins.enforcer.EnforceMojo.executeRuleNew (EnforceMojo.java:351)
    at org.apache.maven.plugins.enforcer.EnforceMojo.executeRule (EnforceMojo.java:325)
    at org.apache.maven.plugins.enforcer.EnforceMojo.execute (EnforceMojo.java:248)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:342)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:330)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:213)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:175)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:76)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:163)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:160)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:193)
    at org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call (MultiThreadedBuilder.java:180)
    at java.util.concurrent.FutureTask.run (FutureTask.java:317)
    at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:577)
    at java.util.concurrent.FutureTask.run (FutureTask.java:317)
    at java.util.concurrent.ThreadPoolExecutor.runWorker (ThreadPoolExecutor.java:1144)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run (ThreadPoolExecutor.java:642)
    at java.lang.Thread.run (Thread.java:1589)

I am not sure if this is related to these changes, but it seemed suspicious as it is coming from the DfDependencyCollector, so figured I would mention it here. It is quite rare, I only got this error once in 100 runs (so maybe this there all the time and I was just "lucky" to never encounter it). In any case, it seems like something we should eventually take a look at.

Def sus, will look tomorrow. Thanks!

My results with new baseline, as I decided to move "closer" to Petr case (I was building master that is moving target):
Project (tag): https://github.com/quarkusio/quarkus/releases/tag/2.16.1.Final
OS: Linux Fedora 37 WS (6.1.11-200.fc37.x86_64)
Java: Temurin-17.0.6+10
No MAVEN_OPTS present.
Cmd: /usr/bin/time -f "%e sec -- %M -- %I -- %O" mvn validate -Dversion.enforcer.plugin=3.2.1 -T8 (no settings.xml)

3.8.7:                     25.92 sec -- 3957056 -- 0 -- 624

3.9.0:                     32.96 sec -- 2282404 -- 0 -- 624

3.9.1patch:
weak+weak+hard (default):  26.70 sec -- 3967968 -- 0 -- 624
hard+hard+hard:            26.12 sec -- 3839500 -- 0 -- 624
weak+weak+weak:           218.16 sec -- 2510952 -- 0 -- 720 HIT same NPE as Petr!!!
none+none+none:           242.61 sec -- 2426684 -- 0 -- 624

So some conclusions or proposals:

remove "none", it makes no sense? (time growth is huge but memory is not less than with 3.9.0)
seems "descriptor" weak is culprit of NPE Petr and I saw, will look into it more

With fix/commit 202134e7e2aecd1aed10397c63675d6ed0a21cef (weak pool misbehave) new numbers:
3.9.1patch:
weak+weak+hard (default):  24.41 sec -- 2018196 -- 0 -- 624
hard+hard+hard:            23.68 sec -- 2000336 -- 0 -- 624
weak+weak+weak:            35.43 sec -- 1719268 -- 0 -- 624
none+none+none:           242.61 sec -- 2426684 -- 0 -- 624

The "none" pool removed, as it makes no sense. The users can "play" with "hard" (heap aggressive) or "weak" (GC friendly) pools.

While this looks fine, what about the NPE?

Fix for NPE (caused by "misbehaving" weak InternPool) is also here in commit 202134e7e2aecd1aed10397c63675d6ed0a21cef. Simply put, original (already merged) weak pool MAY return null, where it never should do that (did not check for WeakReference value nullability).

Updated PR description that will become commit message of squashed PR to reflect all the changes here.


Tensorboard callback fail when using

I'm running into a similar error message to issue 9828, that when calling Tensorboard callback, at epoch end I got an AttributeError: 'float' object has no attribute 'item'
However in that issue the problem was caused by keras-lr which I did not use. The error did not appear when I preload validation images into ndarrays, but once I switched to use generator for validation_data, I start getting this error.
Traceback (most recent call last)
D:\Code\mura\vggnet.py in train(resize, load_param, grayscale, bpart, num_pick, batch_size, epochs, learning_rate, decay, l1, l2, **kwargs)
    293         validation_data=input_generator(valid_df, batch_size, img_size, grayscale),
    294         validation_steps=math.ceil(valid_df.shape[0]/batch_size),
--> 295         callbacks=[tfboard]
    296     )
    297     print('****** Training time: %s' % (datetime.datetime.now() - start_time))

d:\code\mura\env\lib\site-packages\keras\legacy\interfaces.py in wrapper(*args, **kwargs)
     89                 warnings.warn('Update your `' + object_name +
     90                               '` call to the Keras 2 API: ' + signature, stacklevel=2)
---> 91             return func(*args, **kwargs)
     92         wrapper._original_function = func
     93         return wrapper

d:\code\mura\env\lib\site-packages\keras\engine\training.py in fit_generator(self, generator, steps_per_epoch, epochs, verbose, callbacks, validation_data, validation_steps, class_weight, max_queue_size, workers, use_multiprocessing, shuffle, initial_epoch)
   2266                         break
   2267
-> 2268                 callbacks.on_epoch_end(epoch, epoch_logs)
   2269                 epoch += 1
   2270                 if callback_model.stop_training:

d:\code\mura\env\lib\site-packages\keras\callbacks.py in on_epoch_end(self, epoch, logs)
     75         logs = logs or {}
     76         for callback in self.callbacks:
---> 77             callback.on_epoch_end(epoch, logs)
     78
     79     def on_batch_begin(self, batch, logs=None):

d:\code\mura\env\lib\site-packages\keras\callbacks.py in on_epoch_end(self, epoch, logs)
    869             summary = tf.Summary()
    870             summary_value = summary.value.add()
--> 871             summary_value.simple_value = value.item()
    872             summary_value.tag = name
    873             self.writer.add_summary(summary, epoch)

AttributeError: 'float' object has no attribute 'item'

I was using model.fit_generator and this is how I implemented:
    tfboard = keras.callbacks.TensorBoard(log_dir=log_path, write_grads=True)
    history = model.fit_generator(
        input_generator(train_df, batch_size, img_size, grayscale, imggen),
        steps_per_epoch=math.ceil(train_df.shape[0]/batch_size),
        epochs=epochs,
        verbose=2,
        validation_data=input_generator(valid_df, batch_size, img_size, grayscale),
        validation_steps=math.ceil(valid_df.shape[0]/batch_size),
        callbacks=[tfboard]
    )

and this is what the generator looks like:
def input_generator(df, batch_size, img_size, grayscale, imggen=None):
    """
    Generator that yields a batch of training images with their labels
    Args:
        df: Dataframe that contains all the images need to be loaded
        batch_size: Maximum number of images in each batch
        grayscale: Import image as grayscale or RGB
        img_size: Image size to resize the image to if not equals IMG_SIZE
        imggen: ImageDataGenerator used to apply perturbation. If None,
            then no perturbation is applied.

    Yields: List of training images and labels in a batch

    """
    while True:
        # loop once per epoch
        df = df.sample(frac=1).reset_index(drop=True)
        for g, batch in df.groupby(np.arange(len(df)) // batch_size):
            imgs = []
            labels = []
            for index, row in batch.iterrows():
                img = dataset.load_image(row["path"], grayscale)
                if img_size != IMG_SIZE and img_size > 0:
                    img = dataset.resize_img(img, img_size)
                if imggen:
                    img = imggen.random_transform(img)
                imgs.append(img)
                labels.append(row["label"])

            yield np.asarray(imgs), np.asarray(labels)

The float value that caused this issue is from one of the custom metric that I was using. For some reason if I set validation_data to be the image, the metric will be returned as numpy.float32, but with generator, the value is in float32. Both the generator and the image in ndarray has datatype of numpy.float64. I'm really confused at the moment.
The custom metric in interest looks like:
class BinaryRecall(keras.layers.Layer):
    """Stateful Metric to calculate the recall over all batches.
    Assumes predictions and targets of shape `(samples, 1)`.

    Reference:
        https://github.com/keras-team/keras/blob/master/tests/keras/metrics_test.py

    # Arguments
        name: String, name for the metric.
    """

    def __init__(self, name='global_recall', **kwargs):
        super(BinaryRecall, self).__init__(name=name, **kwargs)
        self.stateful = True
        self.true_positives = keras.backend.variable(value=0, dtype='int32')
        self.possible_positives = keras.backend.variable(value=0, dtype='int32')

    def reset_states(self):
        keras.backend.set_value(self.true_positives, 0)
        keras.backend.set_value(self.possible_positives, 0)

    def __call__(self, y_true, y_pred):
        """Computes the recall in a batch.
        # Arguments
            y_true: Tensor, batch_wise labels
            y_pred: Tensor, batch_wise predictions
        # Returns
            The overall recall seen this epoch at the completion of the batch.
        """
        y_true = keras.backend.cast(y_true, 'int32')
        y_pred = keras.backend.cast(keras.backend.round(y_pred), 'int32')
        true_pos = keras.backend.cast(keras.backend.sum(y_pred * y_true), 'int32')
        poss_pos = keras.backend.cast(keras.backend.sum(y_true), 'int32')

        self.add_update(
            keras.backend.update_add(self.true_positives, true_pos),
            inputs=[y_true, y_pred]
        )
        self.add_update(
            keras.backend.update_add(self.possible_positives, poss_pos),
            inputs=[y_true, y_pred]
        )
        true_pos = keras.backend.cast(self.true_positives * 1, "float32")
        poss_pos = keras.backend.cast(self.possible_positives * 1, "float32")
        return true_pos / (keras.backend.epsilon() + poss_pos)

This is actually more of a StatefulMetric issue than the TensorBoard callback. A cast is missing somewhere in validate generator is my guess.

Thank you for the response. I'm not too familiar with the keras code base, I would assume the "validate generator" is what passes the validation metric to the TensorBoard callback inside keras?

Looks like the issue has been fixed in 2.2.2. Closing the issue.


Leverage "no patch" option soon to be released in IVADOMED

IVADOMED currently has a new feature (though not released in a pip version yet) that allows segmenting an image without patching during this step, which could resolve issues we occasionally encounter related to cutting the images in patches (eg straight lines that cut through the image masks).
There remains questions about what we'll want the default behaviour to be, because this is a memory intensive feature (not all computers will have suffiient RAM to work on images larger than a certain size, and this will vary between users).
We'll also need to test this feature vs our current behaviour on a range of test images (eg diffferent models, different axon sizes).

Cross-referencing the ivadomed PR that implemented the feature: https://github.com/ivadomed/ivadomed/pull/1101
We should have a new PyPI release of ivadomed next week so we can move forward with this issue.

ivadomed v2.9.7 was released and integrated in ADS in #693.


Create special-characters.html

I no longer have access to this github account. Can this be closed?


Extended Class doesn't init in Event  - Cannot read property 'call' of undefined

Bin link
Code
/*jshint esnext: true */

class Shape {
  constructor() {
    console.log("Init Shape")
  }
}

class Circle extends Shape {
  constructor() {
    super()
    console.log("Init Circle")
  }
}

// It's ok
var circle = new Circle()

window.addEventListener("click", () => {
  // It's not ok
  var circle = new Circle()
})

Error:
"TypeError: Cannot read property 'call' of undefined
    at new Circle (vixoko.js:25:71)
    at vixoko.js:36:16"

Huh, day  after already work...

Doesn't work with babel. (Not forget click on area)


Solution to GPU not detected in Windows WSL

This is the solution to https://github.com/TimDettmers/bitsandbytes/issues/336 and a few other issues about GPU not being
seen in Windows WSL.
TL;DR: The CUDA driver installed on Windows host is stubbed inside the WSL 2 as libcuda.so and we need to include
that directory location in LD_LIBRARY_PATH

This is actually written in the Nvidia documentation, however is missing in the wsl installation page.
https://docs.nvidia.com/cuda/cuda-installation-guide-linux/#mandatory-actions

Yes, @nivibilla - It's in the Linux sections - but not the windows WSL sections.
FYI, the WSL Ubuntu environment uses /etc/ld.so.cache.d/ files for the majority of those librarues, so setting them in LD_LIBRARY_PATH is not strictly needed, but nothing mentions the need to include  /usr/lib/wsl/lib directory.

You're right, it should be mentioned in the docs for clarity. I didn't have issues with installing cuda this way and it worked for me. Just wanted to let you know.

Can we get this merged? It's simply an addition to errors_and_solutions.md. @TimDettmers

Thank you, this is a great addition to the docs! Sorry for taking so long to respond here. Could you add this commit to the latest branch on main. I made a mess with a force push when pushing private code for the 4-bit beta.


Another security strategy

OIDC with Keycloak is making the gateway an OAuth2 Client and Spring gateway saves a session id to convert session -> accessToken.
I don't want the gateway to save any user state in cache, maybe need to change the implementation and maybe keycloak won't be useful for what a want. I want the gateway to be stateless.

I have done study around this and the spring gateway integration with Keycloak is based in session. For this project I decided to keep the integration using session on the client-side as it is.
The downstreams will still be stateless, they will receive the access token from spring cloud gateway and validate the token and the authorization.


Update call-sharing-and-group-call-pickup.md

Adding limitation on ring order, and cleaning up the limitations
QUESTION: //what does characters signify? I am not sure that this is referring to

Closing this PR, made updates in separate PR.


Multiple SocketCAN instance support.

Adding support for multiple socketCAN interfaces by
making use of instances of DT_DRV_COMPAT for
network devices instead of a single network interface
Each socketCAN instance has a corresponding
DT Node named net_canbus<0>,<1>.
The net_canbus DT Node needs to be a child of the CAN DT Node.
The CAN and socketCAN devices can be accessed
by applications by parent child DT macros.
SocketCAN applications can access socketCAN node and
hence the network interface with its node id.
Tested on RDDRONE board.
Signed-off-by: Benjamin Perseghetti<EMAIL_ADDRESS>Co-authored-by: Sumit Batra<EMAIL_ADDRESS>

After some more thinking, I think we cannot rely on interface ordering here. The interface ordering is not guaranteed and might change for example between different zephyr release. Would there be any other way to distinguish the canbus interface, like address or name etc, that could be used to select the network interface?

In our latest socketcan driver changes we have bound the net_canbus DT node with its parent can or flexcan node.
Now the author of the board dts and SoC dtsi has a free will to define any net_canbus node under any CAN node.
The applications can use socketcan node id to access the socketcan device.

@sumitbatra-nxp  @bperseghetti
What is the summary here?
I'm trying to follow the thread, do we need to propose a change to the zephyr-specific-chosen-nodes
https://docs.zephyrproject.org/latest/build/dts/api/api.html#zephyr-specific-chosen-nodes
in order to have multiple CAN interfaces running simultaneously (likely with differing protocols)
(See MR-CANHUBK344 board as an example hardware. There are six CAN busses)

do we need to propose a change to the zephyr-specific-chosen-nodes

No. I am working on a different approach.

Thanks @henrikbrixandersen
Just in case it is relevant, note that on a board like MR-CANHUBK344 there are also different types of PHY interfaces and they could have some differing control signals. I don't think this would have an impact at this level. But i just wanted to mention it in case it impacts the software architecture.

Thanks @henrikbrixandersen
Just in case it is relevant, note that on a board like MR-CANHUBK344 there are also different types of PHY interfaces and they could have some differing control signals. I don't think this would have an impact at this level. But i just wanted to mention it in case it impacts the software architecture.

Thanks. That does not impact the solution here, as GPIO-controlled CAN transceivers are already supported.

do we need to propose a change to the zephyr-specific-chosen-nodes

No. I am working on a different approach.

@henrikbrixandersen Is there a WIP branch/PR for your approach/work that you could potentially reference in the comments of this PR?

@henrikbrixandersen Is there a WIP branch/PR for your approach/work that you could potentially reference in the comments of this PR?

Unfortunately, the work is not yet ready for consumption/review. I have done a few refactoring PRs in the last month, which lead up to adding this. The basic idea is to have CAN_DEVICE_DT_DEFINE() automatically register the CAN controller device as a network interface based on whether SocketCAN is enabled in Kconfig or not (inspired by the ieee 802.15.4 drivers).


Possible Simplifciation of useSelectDropdown

Currently, useSelectDropdown uses a substate to keep state, but it seems all the state is synchronized from other entities that also keep the same state. So I guess we may be able to remove the store.
The state required from the SelectDropdown component is:

the currently selected value.
If the dropdown is open or not.
The current item to highlight when the mouse moves.

The current value comes from the props. I think we should not have it as a local state. Currently, we have it as local state in two forms value, and commitValue. Why do we need a commit value can't we call onChange right away?
Regarding the dropdown open or not, and the current item to highlight state, it seems downshift provides a useSelect hook for this state, and we are using it, but then we synchronize it to our store. Can't we rely on downshift state as the source of truth?
I think the synchronization of state may be related to the issue https://github.com/ItsJonQ/g2/pull/201 and https://github.com/ItsJonQ/g2/issues/202.

Resolved in https://github.com/ItsJonQ/g2/issues/223

Resolved in https://github.com/ItsJonQ/g2/issues/223


Meal types and meal courses

As a result of the ICBO 2022 FoodOn food processing hackathon on Sept 25, discussion arose on formalizing meal types as a kind of food consumption process, and courses/dishes.

Feedback appreciated!

P.s. there is resistance to creating classes of [culture] x breakfast food as precomposed terms.  Even at a regional level application of breakfast food may entail a different set of foods, which are not accepted by all people in that region.  Same with other meal category foods.

JFO Meeting (2022-10-27) Follow-up: I think dishes are food preparations that can be "slotted" into "meal courses" (which are 1 or more dishes as we discussed in meeting). As we were closing  there were questions regarding "dessert course" vs "dessert dish" and I just want to capture my thoughts on it for next time: I think we should keep dessert course and it's relativity to other courses, but that we shouldn't have "dessert dish" as that doesn't seem like a useful shadow term - perhaps instead "confectionary dish" (or something similar) which would be an option that could be "slotted" into "dessert course" when applicable.

Just need to define what a "confectionary dish" is ;-) but I agree it is a kind of preparation that can be slotted into a meal course  as discussed during the meeting

Just need to define what a "confectionary dish" is ;-) but I agree it is a kind of preparation that can be slotted into a meal course as discussed during the meeting

I agree! And I lean towards going off the definition for "confectionary food product" we discussed in #222
Additionally: It might be worth considering (in parallel to all this meal stuff) adding things like "dessert", "breakfast", "lunch", etc. as label claim classes because it's not unusual to see a "breakfast bar" or "kids lunch food pack" where people apply these labels but there's actually no guarantee of at what meal consumption occurs.

Updated diagram from FoodOn curation call Oct 27:

Yeah, I'm not sold on adding "Western Diet Breakfast Dish" and "Korean breakfast dish" either. I feel like "Western"/"Korean" are a "style" (e.g. like "italian-style" currently in FoodOn) while "breakfast is just a label claim (or something similar) - both of which could be applied to a "dish" when needed but shouldn't be precomposed unless in high demand.

Korean is a geographic location and can be defined yet Western is usually anything "non-Asian" hence not useful here. Also consider where Asian is 40+ countries and such we cannot use "asian" either.

confectionary

Korean is a geographic location and can be defined yet Western is usually anything "non-Asian" hence not useful here. Also consider where Asian is 40+ countries and such we cannot use "asian" either.

In regards to Asian, I suggest we plan for the future and have each country. Yet for top level grouping we can use the common Southeast Asian (then dive deeper into Thailand, Malaysia, Singapore, Indonesia, Cambodia, Los/Myanmar...), Northeast Asia (China, Korean, Japan, Taiwan, ...), South Asian (India, Sri Lanka, Pakistan, ...)

As a result of the ICBO 2022 FoodOn food processing hackathon on Sept 25, discussion arose on formalizing meal types as a kind of food consumption process, and courses/dishes.

Feedback appreciated!

I also posted this as separate issue, (just learning protocol in this platform/forum - A very common name for a time specific meal period is "supper", usually a meal occasion after dinner or instead of dinner after 10pm/ 22:00, then if folks go for some food much later after midnight (such as after bars/dancing/drinking) it can still be called supper of often referred to as "midnight snack" (this within Northeast and Southeast Asian context since in much or Europe such as Spain a majority of full service/fine dinning restaurants don't even open for dinner until 9pm)

Updated diagram from FoodOn curation call Oct 27:  Canape is used in certain settings such as formal party, reception, event as well.

As a result of the ICBO 2022 FoodOn food processing hackathon on Sept 25, discussion arose on formalizing meal types as a kind of food consumption process, and courses/dishes.

Feedback appreciated!

Dinner is not the main meal in some parts of the world, I believe in Spain, lunch is considered more of the main meal.

Hi Robert,
It is possible to set up a separate issue for each term (as you did with https://github.com/FoodOntology/foodon/issues/266 ), but I think we can at least handle preliminary discussion on this thread for what we want to capture for named things and their synonyms and semantics!

Robert, here's a short intro about the choice between "pre-composing", i.e. creating a single term for a category, like "korean breakfast dish", versus having a database express such a thing expressed as a 2 variable structure, e.g. "korean" x "breakfast dish", or more generally, "country" x "meal dish" (say, as a few columns of a database "dish type" table).  Above I said "I threw in "Western Diet Breakfast Dish" and "Korean breakfast dish" just for illustration" - I meant that as a thought exercise about where those items would hypothetically fit. I don't think we do want to pre-compose them.
In FoodOn we do have a list of countries to draw from (currently OBO's GAZETTEER ontology) for use in that kind of "country" x "meal dish" expression.
The question about "western diet" - we actually had a discussion about this in a past JFOW call and came up with the ONS term "globalized diet" with synonym "western diet":  It has a long definition.  We can't really make a logical definition, but to me it seems useful to have this term as a kind of keyword that we can associate with studies that purport to be about western diet.
That same question - do we need this term, and for what purpose - can be asked of any of the dish terms, and as well whether there is a best primary term in the case where a number of terms seem synonymous. If we find variations at work - dinner means this in one (cultural) context, and that in another, then we create a parent term that encompasses both senses of a term if that is possible, and then qualify the underlying terms by their context.  This can get tricky, and sometimes we have to look at kinds of synonymy - broad, narrow, related, exact - to see if there's a solution.  E.g. maybe
main meal:

related synonym: dinner
related synonym: lunch

This exposes the challenge of mapping natural language terms to ontology ones.
What you said about canape suggests that it is an exact synonym for snack, unless what a "canape" references is a (mysteriously defined) subset of snacks?  If canape is simply used in the context of certain events, but still references the same set of foods that "snack" does?
snack:

exact synonym: canape

In the above diagram it looks like we would try to define "midnight snack" as a snack which is input to a "nighttime meal" process?
etc.

We have started a separate thread https://github.com/FoodOntology/foodon/issues/271 to discuss analysis of when to precompose terms or not.  Regarding this thread, I think we'd precompose terms for cuisine around the world by region or culture, but we wouldn't precompose cuisine x meal type to avoid a combination bomb!

Re. meal as a kind of food consumption process, "we need help defining (and researching related definitions in OBO Foundry) for:
food ingestion: ~ having food inside digestive tract (as opposed to intravenous feeding?)
vs
food consumption: physical (aka teach a robot) act of getting food into body (mastication, salivation, + dexterity ...?)
Is one a component of the other?

Here's a revision that seeks to simplify things a bit.  Not all the way there, but closer... I don't think we would add the "Needed in research?" items unless requested to do so.


TACM12K dataset preprocessing

How can I to obtain the embeddings of paper and author in the TACM12K dataset. The code is not found in the rllm.

For simplicity, the embeddings in the dataset were obtained using all-MiniLM-L6-v2. The embedding of the model is 384 dimensions. This model we only carried out a simple processing, there are still some imperfections. A more reasonable approach will follow. If the embeddings in the data set do not meet the requirements, you can perform your own embeddings as needed. Welcome to communicate.

Issue was fixed. Thanks for the assistance


ARROW-6091: [Rust] [DataFusion] Implement physical execution plan for LIMIT

@nevi-me @sunchao @paddyhoran Please review when you can. Thanks.

@nevi-me @sunchao @paddyhoran Any objection to me merging this one?


[integrating megablocks with open_lm] Question about megablocks + FSDP

Hello! I'm trying to integrate megablocks with our open source LLM training library (open_lm), which uses native torch FSDP.
For some reason I am consistently seeing worse performance than my dense baselines at the same compute budget. I'm a bit stumped as to why, and I was wondering if you could provide any pointers on things to watch out for wrt integrations.
To integrate your library:

I replace our feedforward layer with a Megablocks MoE: https://github.com/mlfoundations/open_lm/pull/115/files#diff-ae20e8018bed746c1e2ec41d171f99755ef714e018909a94b5097687ea80c3a4R230-R239

I add a megablock_moe at every other layer (like in Switch/GShard): https://github.com/mlfoundations/open_lm/pull/115/files#diff-ae20e8018bed746c1e2ec41d171f99755ef714e018909a94b5097687ea80c3a4R319-R322

I add the load balancing loss: https://github.com/mlfoundations/open_lm/pull/115/files#diff-52f1d1b2a425f93f57435d70bdac50ded09d6495ee2b417f999869c18cbbcbd9R198-R203

Am I missing anything else?
One hypothesis I have is that something is going wrong when I use Megablocks with FSDP.
Here is our FSDP wrapper:
https://github.com/mlfoundations/open_lm/blob/main/open_lm/main.py#L454-L462
Is there anything I need to change in the FSDP arguments to make sure FSDP doesn't interfere with all2alls?  Currently it wraps the Transformer Block module, of which the MoE is a part of.
Thanks for your help!

Hi! Could you share some more details on your benchmark? MoE training performance depends on a range of factors including your particular model configuration as well as how you choose to apply different kinds of sharding. FSDP could be one of the contributors here, but it'll be helpful to know what you're running to understand what might be the bottleneck.

Sure! I am running some small experiments; 41M and 87M parameter autoregressive LMs on 8 x 40GB A100s, trained for 20B tokens a combination of the RedPajama corpus and the Pile. I am only applying moe_weight_parallelism for these models.
Actually, since I added the load balancing loss (I realized I was not including it properly originally), my validation perplexities are looking more intuitive....
41M (dense): 27.6 ppl
41M (32 experts, top-2 routing): 21.2 ppl
87M (dense): 18.7 ppl
87M (32 experts, top-2 routing): 16.6 ppl
I plan to try to sweep across a variety of settings to confirm. Is there a particular setting that would be good for verifying performance at a small scale?
Another thing I would like to ask --  when I try to train a 160M parameter MoE (32 experts, top-2 routing) or larger with the same compute budget, I get this memory error:
    self.feed_forward = MoE(moe_args)
  File "megablocks_moe.py", line 446, in __init__
    self.experts = ParallelMLP(args)
  File "megablocks_moe.py", line 118, in __init__
    self.mlp = mlp.MLP(args)
  File "megablocks/layers/mlp.py", line 110, in __init__
    self.w2.copy_(create_moe_expert_weights(
  File "megablocks/layers/mlp.py", line 36, in create_moe_expert_weights
    master_weights = torch.empty(
torch.cuda.OutOfMemoryError: CUDA out of memory. Tried to allocate 1.12 GiB. GPU 0 has a total capacty of 39.56 GiB of which 278.56 MiB is free. Process 896914 has 4.82 GiB memory in use. Process 896913 has 4.82 GiB memory in use. Including non-PyTorch memory, this process has 4.82 GiB memory in use. Process 896911 has 4.82 GiB memory in use. Process 896912 has 4.82 GiB memory in use. Process 896907 has 6.64 GiB memory in use. Process 896908 has 3.70 GiB memory in use. Process 896909 has 4.82 GiB memory in use. Of the allocated memory 2.81 GiB is allocated by PyTorch, and 1008.85 MiB is reserved by PyTorch but unallocated. If reserved but unallocated memory is large try setting max_split_size_mb to avoid fragmentation.  See documentation for Memory Management and PYTORCH_CUDA_ALLOC_CONF```

I have turned on both `expert_model_parallelism` and `moe_weight_parallelism`. Any thoughts on how to get past it?

You're using weight parallelism in addition to FSDP? Those are basically the same thing and I'm not sure what'd happen using both at once...
Nice results! That's starting to look pretty good!
re: memory error, that model will have <10GB of parameters total so even with no weight sharding they should fit in a single 40GB GPU. I think you're using a lot of activation memory so I'd try turning down the batch size. That being said, it looks like you're OOMing when the MoE weights are created...

Oh! good point, I'll remove weight parallelism...
yeah, the memory error is a mystery to me, and it does OOM before it starts training...the hidden dimension of the 160M parameter model is just 768. I'll keep digging and circle back!

Ah, the OOM was resolved by adding the device=torch.distributed.get_rank() in Arguments!

Ahhh that makes sense :) You probably want torch.cuda.current_devices(). I think that get_rank() will give you problems when you go to more than 8 ranks.

Hi @tgale96 , just wanted to let you know that we've successfully integrated megablocks into openLM. We can close this comment now!
For your (and others) reference, here are the results we obtain on our A100 cluster:
Compute budgets

Compute type
41M
87M
160M
410M
830M

Number of nodes
1
1
1
2
4

Number of tokens
20.0B
20.0B
20.0B
20.0B
20.0B

Perplexity
Model ppl
toks/sec/gpu

Number of Experts
41M
87M

1
27.61
18.68

8
19.85
14.66

Tokens/sec/GPU

Number of Experts
41M
87M
160M
410M
830M

1
141.2K
106.0K
95.5K
30.3K
16.0K

8
69.5K
66.6K
66.2K
18.5K
9.2K

Training Parameters

Number of Experts
41M
87M
160M
410M
830M

8 experts
68.9M
165.4M
360.6M
1.1B
2.4B

32 experts
164.5M
439.9M
1.0B
3.5B
7.9B

Inference Parameters

Number of Experts
41M
87M
160M
410M
830M

2 experts
45.0M
96.8M
190.7M
509.2M
1.1B

Amazing! This looks excellent :)
re: throughput, would you mind sharing your MoE config for each training run? i.e., the parallelism strategy, batch/sequence length, model dims, and any other arguments you passed to MegaBlocks? Your numbers look pretty good, but I suspect we can improve quite a bit :)


Nuget Package Manager for single project fails to load after adding RingCentralSDK

Posted this on Stack Overflow, then RingCentral devcommunity, and now I've been told to put it here.
I'm on VS 2015, targeting .net 4.5.2, my "Nuget Package Manager for Visual Studio" in Extensions and Updates shows <IP_ADDRESS>1.
I added all dependencies of RingCentralSDK package separately:
- Microsoft.Bcl
- Microsoft.Bcl.Async
- Microsoft.Bcl.Build
- Microsoft.Net.Http
- Newtonsoft.Json
- Portable.BouncyCastle-Signed
- PubnubPCL

Then I right click on my project, pick "Manage Nuget Packages...", the tab opens, in the "Installed" subtab I can see the 7 packages.
Now, I install the RingCentralSDK package. My output is fine:
Attempting to gather dependency information for package 'RingCentralSDK.1.0.0' with respect to project 'MyProj', targeting '.NETFramework,Version=v4.5.2'
Attempting to resolve dependencies for package 'RingCentralSDK.1.0.0' with DependencyBehavior 'Lowest'
Resolving actions to install package 'RingCentralSDK.1.0.0'
Resolved actions to install package 'RingCentralSDK.1.0.0'
Adding package 'RingCentralSDK.1.0.0' to folder 'C:\code\packages'
Added package 'RingCentralSDK.1.0.0' to folder 'C:\code\packages'
Added package 'RingCentralSDK.1.0.0' to 'packages.config'
Successfully installed 'RingCentralSDK 1.0.0' to MyProj
========== Finished ==========

Now, I check again the Manage Nuget Packages for this specific project, and instead of seeing the list of packages, I get a yellow band:
Error occured                  Show erros in output         Dismiss

And in the "Package Manager" output, the error is:
ZIP archive contains unsupported data structures.

In my packages folder, the folder "RingCentralSDK.1.0.0" seems ok, but then I don't anything about nuget packages format.
I cannot uninstall RingCentral via the package manager as it's not showing, nor any other one, which is really annoying. I had an error when trying to do it via the command line. I reverted my changes (or remove the line in packages.config for my project), and the Nuget Package Manager tab works fine again. This is also affecting the "Managet Nuget Packages for Solution".
What can I do to fix this?

Let me investigate and get back to you later. One possibility: when we created the NuGet package, we used the latest NuGet binary NuGet Version: <IP_ADDRESS>5 on Mac.  Maybe there are compatibility issues between NuGet binary and the NuGet Package Manager.

I just did a quick test by creating a brand new project with Visual Studio 2015 on Windows 10.
Visual Studio Menu :point_right: Tools :point_right: NuGet Package Manager :point_right: Package Manager Console
In Package Manager Console, I executed the following command:
Install-Package RingCentralSDK

Everything seems find and here is the final packages.config:
<?xml version="1.0" encoding="utf-8"?>
<packages>
  <package id="Microsoft.Bcl" version="1.1.10" targetFramework="net40" />
  <package id="Microsoft.Bcl.Async" version="1.0.168" targetFramework="net40" />
  <package id="Microsoft.Bcl.Build" version="1.0.21" targetFramework="net40" />
  <package id="Microsoft.Net.Http" version="2.2.29" targetFramework="net40" />
  <package id="Newtonsoft.Json" version="8.0.3" targetFramework="net40" />
  <package id="Portable.BouncyCastle-Signed" version="<IP_ADDRESS>" targetFramework="net40" />
  <package id="PubnubPCL" version="<IP_ADDRESS>" targetFramework="net40" />
  <package id="RingCentralSDK" version="1.0.0" targetFramework="net40" />
</packages>

The experiment described above proves that at  least it works with the Package Manager Console.
It seems that you are using some graphical tool. I have never used that before. Let me have a try.

I can reproduce the issue with the GUI tool. I am investigating.

Fixed in RingCentralSDK 1.0.1-alpha1
It turns out that the NuGet package created on Mac is not compatible with Visual Studio NuGet GUI tool.
You can install the latest version by
Install-Package RingCentralSDK -Pre

Or if you prefer GUI:

At first I thought I still had the error after installing 1.0.1alpha. So I removed the reference, closed VS, deleted both 1.0.0 and 1.0.1alpha from the packages folder, re-opened VS, readded the reference.... and now it's fine. Thank you.

Today I did some testing and I came to the following conclusion:

New project will have no problem with 1.0.1 version or later
For old project which have 1.0.0 installed. You need to follow the following steps:

UnInstall RingCentralSDK
Close VS
Delete packages folder in your project
Delete packages folder in ~/.nuget/
Launch VS
Install RingCentralSDK

I need to do the above because nuget has cache. If I don't do it the problem just persists. I don't know the exactly reason but the above steps did work for me.


token fail to refresh when use multi tab

Bug report
Describe the bug
token fail to refresh when use multi tab
To Reproduce

on supabase dashboard, set token expiration, make it short e.g. 180 seconds
signing in with this.supabase.auth.signIn({email, password});
open site on new tab, so we have 2 tabs open now
open devtools and wait for token refresh request

Expected behavior
like firebase https://firebase.google.com/docs/auth/admin/manage-sessions
Screenshots

System information

OS: [linuxmint]
Browser [chrome version 99]
Version of supabase-js: [1.32.1]
Version of Node.js: [14.17.0]

Seems to be related to https://github.com/supabase/gotrue-js/issues/213


Create new columns in sample_summary.tsv

Created 3 new columns:
opxv_reads_1 -> filepath to seqtk output, reads file 1
opxv_reads_2 -> filepath to seqtk output, reads file 2
final_assembly -> filepath to final assembly
Test command:
nextflow run main.nf --indir /scicomp/groups-pure/Projects/scbs_mpob/JRowell_ick4/mpox_testing/paired/ --outdir /scicomp/groups-pure/Projects/scbs_mpob/JRowell_ick4/mpox_testing/results/ --project_name test -config /scicomp/reference/nextflow/configs/cdc-dev.config -profile singularity,rosalind

PR checklist

[ x] This comment contains a description of changes (with reason).
[x] If you've fixed a bug or added code that should be tested, add tests!

[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/mpxvassembly branch on the nf-core/test-datasets repository.

[ ] Make sure your code lints (nf-core lint).
[x] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[x] Usage Documentation in docs/usage.md is updated.
[x] Output Documentation in docs/output.md is updated.
[ ] CHANGELOG.md is updated.
[x] README.md is updated (including new tool citations and authors/contributors).

Make sure outputs are full paths to fasta and fastq, even if user input is a relative path.

I've added a line to convert relative to absolute paths for outdir

Right now this code only outputs a path for final_assembly if there is a <sample>.final.fa file.  If there are only <sample>.draft.fa  assemblies, these are ignored and the column is left blank. Is this the expected behavior or should I modify?

@mikeyweigand Right now this code only outputs a path for final_assembly if there is a <sample>.final.fa file. If there are only <sample>.draft.fa assemblies, these are ignored and the column is left blank. Is this the expected behavior or should I modify?

Agree this makes the most sense, current 'ask' is to streamline capture of necessary inputs for TOSTADAS, to which you wouldn't send a draft contig fasta.


Restart order is to be reverse stop order

Is your feature request related to a problem? Please describe.
Current restart order is InstanceGroup --> GCE --> SQL
But GCE or Instance Group Node depends on SQL then launch may be fail.
Describe the solution you'd like
Restart order is to be reverse stop order.
Additional context
No

done by #38


Are these all of columns in summary statistics require to run LDpred.py coord?

Hi,
I'm trying to run the test data with LDpred.py.
Here is my error message that I have now.
Traceback (most recent call last):
File "LDpred.py", line 300, in
main()
File "LDpred.py", line 285, in main
coord_genotypes.main(p_dict)
File "/data1/home/jungj7/00_Pipeline/08_GRS/LDpred/ldpred/ldpred/coord_genotypes.py", line 566, in main
sum_stats_parsers.parse_sum_stats(h5f, p_dict, bimfile, summary_dict)
File "/data1/home/jungj7/00_Pipeline/08_GRS/LDpred/ldpred/ldpred/sum_stats_parsers.py", line 73, in parse_sum_stats
control_n=p_dict['control_n'], **ss_args)
File "/data1/home/jungj7/00_Pipeline/08_GRS/LDpred/ldpred/ldpred/sum_stats_parsers.py", line 161, in parse_sum_stats_custom
assert eff in header_dict, 'Effect size column not found in summary statistic file'
AssertionError: Effect size column not found in summary statistic file
And I looked at the file of sum_stats_parsers.py and noticed that there is

Can anyone help on this issue? Do I have to have each column of summary statistics to run LDpred.py?
Thank you.

You have to change the header in this way:

chr     pos     ref     alt     reffrq  info    rs       pval    effalt

When you will run the command remember to write --ssf-format STANDARD

You have to change the header in this way:

chr pos ref alt reffrq info rs pval effalt

All these columns are required.
When you will run the command remember to write --ssf-format STANDARD.

Alternatively, you can use
--ssf-format CUSTOM  --chr CHR   --pos pos  --A1 A1  --A2 A2 --rs rs  --pval pval  --eff EFF

to provide a more flexible input option (might also need to specify --beta if your summary statistics is in the form of beta instead of OR

@choishingwan @jPontix Thanks for the help on this reply!


Android: User B does not receive 3 verification codes while User B performing sign up flow using invitation code when User A (indian number) invites User B (indian number)

Frequency: 100%
iOS App version: Android Playstore build : 1.6.1 (104794404).
Repro on Android Device: Samsung Galaxy S5 (6.0.1), Samsung Galaxy Grand Prime (5.0.1)
Testing Account:<PHONE_NUMBER> /backup Key
Repro Steps:

UserA : Launch the app and Login with test account1
UserA : Invite User B with SMS using indian phone number
UserB : Receives invitation code in indian phone number and Perform signup flow
UserB : Navigate to ‘Start Verification’ page and Wait for getting verification
UserB : Observe

Current Behavior: User B does not receive 3 verification codes
Expected Behavior: User B should be receive 3 verification codes after sending verification code
Investigation: Sometimes UserB gets received only 1 or 2 verification code
Attachment1: Android_Verification code does not get received.mp4 (Bug observe at 4:16 min)

I believe this has been addressed by the recent verification work.

Hi @tarikbellamine  I have verified issue once but getting verification error while verifying Indian phone number. hence for now i am reopening this ticket.
Note: I don't have enough money hence not able to check with second time.

Hi Ankit-- does this still reproduce? downgrading to P2 for now as well

Hi @nityas  I have verified using Android internal build v1.6.0(1004294325)  and Test Flight build v1.6.0(36) & observed that user B able to get 3 verification codes.
Devices: Samsung Galaxy A5(7.0)

Closing since it looks fixed and we don't have invitation codes anymore


[JS] Fix several issues found in pdf in #13269

app.alert and few other function can use an object as parameter ({cMsg: ...});
support app.alert with a question and a yes/no answer;
update field siblings when one is changed in an action;
stop calculation if calculate is set to false in the middle of calculations;
get a boolean for checkboxes when they've been set through annotationStorage instead of a string.

/botio test

/botio integrationtest

/botio integrationtest

/botio integrationtest


Added Quicksort Algorithm

Thanks, @darshak4278  for your contribution, you are doing great, please don't forget to star this repo.


:ReactNative:Running '[node, -e, try {console.log(require('@react-native-community/cli').bin);} catch (e) {console.log(require('react-native/cli').bin);}]' command failed.

Description
can't running app
:ReactNative:Running '[node, -e, try {console.log(require('@react-native-community/cli').bin);} catch (e) {console.log(require('react-native/cli').bin);}]' command failed.

What went wrong:
A problem occurred evaluating script.

Could not find method exec() for arguments [ReactNativeModules$_getCommandOutput_closure16@40814d12] on object of type org.gradle.api.internal.provider.DefaultProviderFactory_Decorated.

Steps to reproduce
I try reinstall env
https://reactnative.dev/docs/environment-setup.

React Native Version
0.70.8
Affected Platforms
Runtime - Android, Build - MacOS
Output of npx react-native info
System:
    OS: macOS 14.2.1
    CPU: (8) arm64 Apple M1
    Memory: 106.28 MB / 8.00 GB
    Shell: 3.2.57 - /bin/bash
  Binaries:
    Node: 18.16.0 - ~/.nvm/versions/node/v18.16.0/bin/node
    Yarn: 1.22.21 - /usr/local/bin/yarn
    npm: 9.5.1 - ~/.nvm/versions/node/v18.16.0/bin/npm
    Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
  Managers:
    CocoaPods: Not Found
  SDKs:
    iOS SDK:
      Platforms: DriverKit 23.2, iOS 17.2, macOS 14.2, tvOS 17.2, watchOS 10.2
    Android SDK:
      API Levels: 23, 28, 29, 30, 33, 33, 34
      Build Tools: 28.0.3, 29.0.0, 30.0.2, 30.0.3, 31.0.0, 33.0.0, 33.0.1, 34.0.0
      System Images: android-33 | Google APIs ARM 64 v8a, android-33 | Google Play ARM 64 v8a
      Android NDK: Not Found
  IDEs:
    Android Studio: 2023.1 AI-231.9392.1.2311.11330709
    Xcode: 15.1/15C65 - /usr/bin/xcodebuild
  Languages:
    Java: 17.0.9 - /usr/bin/javac
  npmPackages:
    @react-native-community/cli: Not Found
    react: 18.1.0 => 18.1.0
    react-native: 0.70.8 => 0.70.8
    react-native-macos: Not Found
  npmGlobalPackages:
    *react-native*: Not Found

Stacktrace or Logs
Caused by: org.gradle.internal.metaobject.AbstractDynamicObject$CustomMessageMissingMethodException: Could not find method exec() for arguments [ReactNativeModules$_getCommandOutput_closure16@a15bcec] on object of type org.gradle.api.internal.provider.DefaultProviderFactory_Decorated.

Reproducer
none
Screenshots and Videos

We can't help without a reproducer sadly + you're on a unsupported version of React Native.

0.70.8

We can't help without a reproducer sadly + you're on a unsupported version of React Native.

can you tell me, what version does it support? @cortinico

Here they are: https://github.com/reactwg/react-native-releases/#which-versions-are-currently-supported

close android studio and open from terminal with  open -a /Applications/Android\ Studio.app help me

Same for Windows RN 0.74-rc4

Same problem on Mac M1 RN 0.74.1

ReactNative:Running '[node<EMAIL_ADDRESS>config]' command failed.

FAILURE: Build failed with an exception.

Where:
Script<EMAIL_ADDRESS>line: 401

Same problem on Windows RN 0.74.3

:ReactNative:Running '[node, -e, try {console.log(require('@react-native-community/cli').bin);} catch (e) {console.log(require('react-native/cli').bin);}]' command failed.

FAILURE: Build failed with an exception.

Where:
Script<EMAIL_ADDRESS>line: 397

Same problem

facing same problem in RN 0.74. please open the issue

For the ones who are facing this problem with supported versions of React native :
replace in you AndroidManifest.xml:
<manifest xmlns:android="http://schemas.android.com/apk/res/android>"
with:
<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="<your package name>">


fix bug,channel receiver in debug is blocked by self io

channel receiver in wait_pid function would be blocked by self io opertion

@Burning1020 ,can u help for this commit

@zmrush How did you exec into the vm? There is no keywords when connected to hvsock until input CONNECT 1025.

@zmrush How did you exec into the vm? There is no keywords when connected to hvsock until input CONNECT 1025.

i dont understand your question. but i think exec into vm has nothing to do with 'input connect 1025 using the io'. In other words, it has already exec into the vm?

@zmrush How did you exec into the vm? There is no keywords when connected to hvsock until input CONNECT 1025.

i dont understand your question. but i think exec into vm has nothing to do with 'input connect 1025 using the io'. In other words, it has already exec into the vm?

@Burning1020

@zmrush Sorry, maybe I was misunderstood. So what's the specific problem you got? What's the influence of blocking receiver? Please give more details.

@zmrush Sorry, maybe I was misunderstood. So what's the specific problem you got? What's the influence of blocking receiver? Please give more details.

@Burning1020 blocking receiver may cause memory increase unexpectedly.

@Burning1020 blocking receiver may cause memory increase unexpectedly.

OK, so how to reproduce it? I'd like to investigate it


Don't export tinyxml2 internal details.

That should be done by tinyxml2 itself.  Also, this doesn't work
on earlier versions of cmake (3.10, in particular).
Signed-off-by: Chris Lalancette<EMAIL_ADDRESS>Along with https://github.com/ros2/tinyxml2_vendor/pull/8, this is an alternative to #190.  This seems to fix the problems when building with rosbag2 (along with https://github.com/ros2/rosbag2/pull/403), and also seems to work for building the nav2_rviz_plugins that originally motivated #192.
@Karsten1987 FYI.

for my understanding, why does #190 not work for the nav2_rviz_plugins?

for my understanding, why does #190 not work for the nav2_rviz_plugins?

I think it would, but it just seems that exporting this at all from pluginlib is the wrong way to go.  That is, if we merge this and ros2/tinyxml2_vendor#8, we get the same benefit but it is more "correct".

I tried this patch but I am getting the following error with this change. Any way to fix it? New to ros so maybe a rookie mistake.
--- stderr: rosbag2_storage
librosbag2_storage.so: undefined reference to `tinyxml2::XMLNode::Value() const'
librosbag2_storage.so: undefined reference to `tinyxml2::XMLNode::FirstChildElement(char const*) const'
librosbag2_storage.so: undefined reference to `tinyxml2::XMLDocument::XMLDocument(bool, tinyxml2::Whitespace)'
librosbag2_storage.so: undefined reference to `tinyxml2::XMLNode::NextSiblingElement(char const*) const'
librosbag2_storage.so: undefined reference to `tinyxml2::XMLDocument::LoadFile(char const*)'
librosbag2_storage.so: undefined reference to `tinyxml2::XMLDocument::~XMLDocument()'
librosbag2_storage.so: undefined reference to `tinyxml2::XMLElement::Attribute(char const*, char const*) const'
librosbag2_storage.so: undefined reference to `tinyxml2::XMLElement::GetText() const'

I tried this patch but I am getting the following error with this change. Any way to fix it? New to ros so maybe a rookie mistake.

You also need ros2/tinyxml2_vendor#8

So I'm actually going to close this one out, since it is a weaker version of #190 (that was my mistake, I misunderstood what they both did).  We'll continue in #190 instead.


#16087 recreate editors on mode switch instead of hiding

DateTime editors on Linux have an issue with sending selection events when they are invisible, we will change it by disposing of not needed editors on mode switch. Also we don't want to trigger Modify event when setting date to text editor
Closes #16078

Now timestamp values with calendar view just don't show actual data

Now calendar stopped working in external editor Ctrl + Enter

verified


500 Internal Server Error

Hello, there is an error 500 when accessing over https, please tell me what my error is. Attach docker-compose file and logs.
version: '3'

services:
  db:
    image: postgres:alpine
    restart: always
    volumes:
      - db:/var/lib/postgresql/data
    env_file:
      - db.env

  app:
    image: nextcloud:fpm-alpine
    restart: always
    volumes:
      - nextcloud:/var/www/html
    environment:
      - POSTGRES_HOST=db
    env_file:
      - db.env
    depends_on:
      - db

  web:
    build: ./web
    restart: always
    volumes:
      - nextcloud:/var/www/html:ro
    environment:
      VIRTUAL_HOST: ls.example.org
      LETSENCRYPT_HOST: ls.example.org
      LETSENCRYPT_EMAIL<EMAIL_ADDRESS>    depends_on:
      - app
    networks:
      - proxy-tier
      - default

  proxy:
    build: ./proxy
    restart: always
    ports:
      - 80:80
      - 443:443
    labels:
      com.github.jrcs.letsencrypt_nginx_proxy_companion.nginx_proxy: "true"
    volumes:
      - certs:/etc/nginx/certs:ro
      - vhost.d:/etc/nginx/vhost.d
      - html:/usr/share/nginx/html
      - /var/run/docker.sock:/tmp/docker.sock:ro
    networks:
      - proxy-tier

  letsencrypt-companion:
    image: jrcs/letsencrypt-nginx-proxy-companion
    restart: always
    volumes:
      - certs:/etc/nginx/certs
      - vhost.d:/etc/nginx/vhost.d
      - html:/usr/share/nginx/html
      - /var/run/docker.sock:/var/run/docker.sock:ro
    networks:
      - proxy-tier
    depends_on:
      - proxy

volumes:
  db:
  nextcloud:
  certs:
  vhost.d:
  html:

networks:
  proxy-tier:

etsencrypt-companion_1  | 2020-08-20 12:19:17,433:ERROR:simp_le:1417: CA marked some of the auth
orizations as invalid, which likely means it could not access http://example.com/.well-known/acme
-challenge/X. Did you set correct path in -d example.com:path or --default_root? Are all your dom
ains accessible from the internet? Please check your domains' DNS entries, your host's network/fi
rewall setup and your webserver config. If a domain's DNS entry has both A and AAAA fields set up
, some CAs such as Let's Encrypt will perform the challenge validation over IPv6. If your DNS pro
vider does not answer correctly to CAA records request, Let's Encrypt won't issue a certificate f
or your domain (see https://letsencrypt.org/docs/caa/). Failing authorizations: https://acme-v02.
api.letsencrypt.org/acme/authz-v3/6660010153
letsencrypt-companion_1  | 2020-08-20 12:19:17,450:INFO:simp_le:401: Saving account_key.json
letsencrypt-companion_1  | 2020-08-20 12:19:17,451:INFO:simp_le:401: Saving account_reg.json
letsencrypt-companion_1  | Challenge validation has failed, see error log.
letsencrypt-companion_1  |
letsencrypt-companion_1  | Debugging tips: -v improves output verbosity. Help is available under
--help.
letsencrypt-companion_1  | /app
letsencrypt-companion_1  | Sleep for 3600s
#...
letsencrypt-companion_1  | 2020/08/20 12:20:11 Debounce minTimer fired
letsencrypt-companion_1  | 2020/08/20 12:20:11 Contents of /app/letsencrypt_service_data did not change. Skipping notification '/app/signal_le_service'

FWIW, I run a very similar setup via https://github.com/dataminelab/docker-jenkins-nginx-letsencrypt and am experiencing this error too using the latest tag. I pinned jrcs/letsencrypt-nginx-proxy-companion at v1.13 instead and that is working again.

I think I got the same problem as you. The 500 is returned by the nginx config in my case. Can you verify that?
docker-compose exec proxy cat /etc/nginx/conf.d/default.conf

Yes, definitely the file is the same

Okay for my case I had started the docker ONCE with a typo LETENCRYPT_HOST. After I fixed the Typo and added the mission S I just restarted the server. This was not sufficient to refresh the environement variables.
You may consider to print out the ENV values: docker-compose exec web bash -c env and validate the correct LETSENCRYPT_HOST is exposed.

Sorry, this mistake was not made by me

Just updated and rebuilt my docker image and I'm getting error 500 from nginx. It seems to be the Let's Encrypt is not getting a new certificate. I didn't change any settings or configurations, just let docker-compose to a rebuild that pulled from the repo.

@kogeletey I see that you are using your own modified version of nginx-proxy :
proxy:
    build: ./proxy

Could you switch back to jwilder/nginx-proxy, test again, and report if the issue persists ?

I tried using the official nginx proxy. The error is the same

Okay, next could you follow the troubleshooting advices in https://github.com/nginx-proxy/docker-letsencrypt-nginx-proxy-companion/blob/master/docs/Invalid-authorizations.md ?

Just had this issue.
Seems like nginx.tmpl got updated, you will have to use A record for (example.com) and (www.example.com) if both are added in your VIRTUAL_HOST, LETSENCRYPT_HOST, LETSENCRYPT_EMAIL variables.
This solved my issue.

@codekuu can you explain further what you mean by "you will have to use A record for @ and www if both are added in your [envvars]" ?

I added both www.example.com and example.com to the [envvars], it seems like example.com pointed to my IP address (from the dns) but www.example.com pointed to nothing. Seems like nginx-letsencrypt just crashes when receiving a "NoneType" instead of creating a certificate for example.com and ignoring www.example.com. (Should create cert for example.com, but catch Exception for www.example.com)
Output:
/etc/nginx/certs/example.com /app
Creating/renewal example.com certificates... (example.com www.example.com)
2020-10-07 08:48:29,767:INFO:simp_le:1414: Generating new certificate private key
2020-10-07 08:48:31,505:ERROR:simp_le:1396: CA marked some of the authorizations as invalid, which likely means it could not access http://example.com/.well-known/acme-challenge/X. Did you set correct path in -d example.com:path or --default_root? Are all your domains accessible from the internet? Please check your domains' DNS entries, your host's network/firewall setup and your webserver config. If a domain's DNS entry has both A and AAAA fields set up, some CAs such as Let's Encrypt will perform the challenge validation over IPv6. If your DNS provider does not answer correctly to CAA records request, Let's Encrypt won't issue a certificate for your domain (see https://letsencrypt.org/docs/caa/). Failing authorizations: https://acme-v02.api.letsencrypt.org/acme/authz-v3/7725902331
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/simp_le.py", line 1370, in finalize_order
    finalized_order = client.poll_and_finalize(order)
  File "/usr/lib/python3.7/site-packages/acme/client.py", line 712, in poll_and_finalize
    orderr = self.poll_authorizations(orderr, deadline)
  File "/usr/lib/python3.7/site-packages/acme/client.py", line 736, in poll_authorizations
    raise errors.ValidationError(failed)
acme.errors.ValidationError
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/simp_le.py", line 1443, in persist_new_data
    order = finalize_order(client, order)
  File "/usr/lib/python3.7/site-packages/simp_le.py", line 1397, in finalize_order
    raise Error('Challenge validation has failed, see error log.')
simp_le.Error: Challenge validation has failed, see error log.
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/usr/lib/python3.7/site-packages/simp_le.py", line 1565, in main
    return main_with_exceptions(cli_args)
  File "/usr/lib/python3.7/site-packages/simp_le.py", line 1549, in main_with_exceptions
    persist_new_data(args, existing_data)
  File "/usr/lib/python3.7/site-packages/simp_le.py", line 1464, in persist_new_data
    chain=None,
  File "/usr/lib/python3.7/site-packages/simp_le.py", line 1128, in persist_data
    plugin.save(new_data)
  File "/usr/lib/python3.7/site-packages/simp_le.py", line 557, in save
    key = self.dump_key(data.key)
  File "/usr/lib/python3.7/site-packages/simp_le.py", line 455, in dump_key
    return OpenSSL.crypto.dump_privatekey(self.typ, data.wrapped).strip()
AttributeError: 'NoneType' object has no attribute 'wrapped'
Unhandled error has happened, traceback is above
Debugging tips: -v improves output verbosity. Help is available under --help.
/app
Sleep for 3600s

After I pointed www.example.com to the correct IP, flushed my DNS server and restarted the container running the website it worked:
/etc/nginx/certs/example.com /app
Creating/renewal example.com certificates... (example.com www.example.com)
2020-10-07 09:03:17,482:INFO:simp_le:1414: Generating new certificate private key
2020-10-07 09:03:22,328:INFO:simp_le:396: Saving key.pem
2020-10-07 09:03:22,329:INFO:simp_le:396: Saving fullchain.pem
2020-10-07 09:03:22,329:INFO:simp_le:396: Saving cert.pem

I have no clue why it worked before and stopped working when nginx.tmpl got update...

Seems like nginx-letsencrypt just crashes when receiving a "NoneType" instead of creating a certificate for example.com and ignoring www.example.com. (Should create cert for example.com, but catch Exception for www.example.com)

This is the ACME client (simp_le) responsibility. Contributions to this project are welcome.
Having correctly configured DNS is fourth on the requirements list.

I have no clue why it worked before and stopped working when nginx.tmpl got update...

I highly doubt this has anything to do with an nginx.tmpl update, this is most probably coincidental.
If you happen to have misconfigured DNS, nothing in nginx.tmpl will circumvent this.

By the way from the traceback of simp_le you are using an outdated version of the Docker image. Please update to the newest tagged release.

Hi, I had the same issue, and after adding a CAA record and other kind of fix I always get the error 500.
At last, it was a _ in the url of my server (VIRTUAL_HOST=test_0.mydomain.com). I removed this _ and now it works !


Support axum-connect code gen

Hi 👋
I wrote axum-connect, which implements the Connect protocol for use with axum. It's designed to mix proto-based services into existing codebases, happily co-existing alongside more traditional HTTP endpoints. Seeing as you target buf.build I'll digress and assume prior knowledge in this area.
The code generator for axum-connect leaves an awful lot to be desired. It doesn't fit well into polyglot codebases (which is frankly the whole point of axum-connect) nor does it work at all with buf.build. I've had a moonshot item on my list since inception: to support buf.build remote execution for code gen. I just came across your codebase today.
Would you be willing to accept a PR to add support for axum-connect service definitions? I think I can do most (maybe all) the heavy lifting. This would involve:

[ ] A new directory/workspace-member protoc-gen-axum-connect

[ ] The code generator is already based on prost
[ ] There were a lot code-gen hacks I added that need to be done away with
[ ] Supports any axum-connect specific configuration. None as of right now
[ ] Determine if we should require protoc-gen-prost (or possibly protoc-gen-prost-crate) as well as protoc-gen-prost-serde. Both are required for axum-connect to make any logical sense. I don't know enough yet to say what the right answer is here; open to suggestions?

[ ] Publish protoc-gen-axum-connect to buf.build's community plugins for remote code-gen

The code generator itself is very simple, it adds a single function (scoped to a mod) for each proto service RPC. That function is analogous to axum's get and post functions, that wrap a high-order function in a future for use with Axum's extractors. Overall axum-connect is a very simple project, the bulk of the complexity is in the monstrously complicated type definitions for handlers.

Hey :wave:
I'd definitely be interested in being able to support code generation for axum-connect, particularly as this appears to be within the prost ecosystem of services. I know that I've had discussions before about potentially having tonic extended to support the connect protocol, but I'd be happy to incorporate a generator that would support the service.
Of note, I am a little behind in updating the code generation to support the newest features in the latest versions of prost and tonic (although existing generation hasn't been breaking, which has been nice, and allowed me to delay specific attention there.)
Feel free to submit a PR, and I can work on reaching out to the buf folks to see if they want to accept it in as a remote plugin, assuming all stabilizes well.

Will do! Hopefully I'll have some time coming up soon to get that done. I've chatted with the Buf devs before as well, so I'll be on their radar when you talk to them.


STORM-3083 Upgrade HikariCP version to 2.4.7

Please refer https://issues.apache.org/jira/browse/STORM-3083 for more details

This can be safely ported back to 1.x-branch as well.

+1


Added Vim command sequences below 3 of 4 examples

I think this helps a lot. New users want to know what's going on in the GIFs. It's better to have the commands directly below the GIFs than having them hidden on the issue tracker.


Use a virtual filesystem

Allow usage of many games by using a virtual filesystem to launch different modpacks or flavors

Found a library: https://github.com/pwssnk/py-usvfs

Implemented. Turns out not many executable installers respect the vfs.


Fix Custom API Save Button Typo

Fixes a small typo in the save button on the Custom API page in the web version.

Thanks for the pr


When someone signs THE CLA, we need to revalidate the PRs they have open against the orgs

It sounds so simple, but it probably isn't!
So basically once someone signs THE CLA we need to revalidate the existing PRs they have open. How do we do this? Not a clue. There's some code in the dr-cla project that does it, and it seems to be the kinda brute force way of doing so, but it might be totally fine.
I don't read Scala well but most of the implementation can be found here: https://github.com/salesforce/dr-cla/blob/10e29d42a11632060f941fae6001f03654c6320c/app/utils/GitHub.scala#L487
If we can do it in a more efficient manner, cool. If we can't, who cares. We might be able to store PRs that failed validation in postgres as they come in for validation and use that to more "smartly" revalidate them, but that could be lossy? Hard to say. It's the implementors choice as to what we do here.

I think this is fixed by: https://github.com/sonatype-nexus-community/the-cla/pull/61


Operate on tensors rather than tuple-of-tensors?

Hi Xuechen - I appreciate I'm bombarding this repository with a lot of issues/PRs.
Something we've recently found over in torchdiffeq#115 is that it's noticeably more efficient to have the internals of the library operate on tensors, rather than tuples-of-tensors, and have the adjoint method simply torch.cat its different channels together.
Of course this also makes the code a whole lot cleaner, and I expect easier to develop going forward.
Not something I've got time to put together a PR for I'm afraid, but I thought I'd flag this up as something you might be interested in over here.

Hi Patrick,
Thanks for the note! It's interesting that using torch.cat for the output can speed things up by much. I definitely learned something here.
I'll try to patch this up over a weekend in the future, and feel free to open up other issues even if you don't have cycles to work on them. Really appreciate it!

No problem. More issues to follow!

Done in #37.


operator-no-unspaced detects comment as code

The following code:
// ...
// ...
$breakpoints: (
    laptop: 1200px,     /* 992px - 1200px */
    tablet: 991px,      /* 768px -  991px */
    mobile: 767px,      /*   0px -  767px */
);

fails with on current version 3.5.3:
 4:25  ✖  Expected single space before "/"   scss/operator-no-unspaced
 4:25  ✖  Expected single space after "/"    scss/operator-no-unspaced
 4:26  ✖  Expected single space before "*"   scss/operator-no-unspaced
 4:43  ✖  Expected single space after "*"    scss/operator-no-unspaced
 4:44  ✖  Unexpected newline after "/"       scss/operator-no-newline-after
 4:44  ✖  Expected single space before "/"   scss/operator-no-unspaced
 5:25  ✖  Expected single space before "/"   scss/operator-no-unspaced
 5:25  ✖  Expected single space after "/"    scss/operator-no-unspaced
 5:26  ✖  Expected single space before "*"   scss/operator-no-unspaced
 5:34  ✖  Expected single space after "-"    scss/operator-no-unspaced
 5:43  ✖  Expected single space after "*"    scss/operator-no-unspaced
 5:44  ✖  Unexpected newline after "/"       scss/operator-no-newline-after
 5:44  ✖  Expected single space before "/"   scss/operator-no-unspaced
 6:25  ✖  Expected single space before "/"   scss/operator-no-unspaced
 6:25  ✖  Expected single space after "/"    scss/operator-no-unspaced
 6:26  ✖  Expected single space before "*"   scss/operator-no-unspaced
 6:26  ✖  Expected single space after "*"    scss/operator-no-unspaced
 6:34  ✖  Expected single space after "-"    scss/operator-no-unspaced
 6:43  ✖  Expected single space after "*"    scss/operator-no-unspaced
 6:44  ✖  Unexpected newline after "/"       scss/operator-no-newline-after
 6:44  ✖  Expected single space before "/"   scss/operator-no-unspaced

This comments should not be detected as operator.

Thanks! I'll have a look at it.

Hmm.. I can't get your example to fail in a unit test, and it also does not fail in my test project that I use for debugging stylelint issues.
Is there some other code that you are using addition to your example that could cause it to fail?

Closing this as inactive. Let's reopen if something new comes up.

@kristerkari  Sorry for the late reply it seems to be an issue with the value-keyword-case:
{
  "plugins": [
    "stylelint-scss"
  ],
  "rules": {
      "value-keyword-case": "lower",
      "scss/operator-no-unspaced": true,
      "scss/operator-no-newline-after": true
  }
}

{
  "name": "test-for-stylelint",
  "version": "1.0.0",
  "scripts": {
    "lint": "stylelint css/*.scss"
  },
  "license": "ISC",
  "devDependencies": {
    "stylelint": "^9.10.1",
    "stylelint-scss": "^3.5.4"
  }
}

$breakpoints: (
    laptop: 1200px,     /* 992px - 1200px*/
    tablet: 991px,      /* 768px -  991px*/
    mobile: 767px,      /*   0px -  767px*/
);

So I think its not really related to stylelint-scss more to stylelint itself as the value-keyword-case does change something which should not be changed:
Related to https://github.com/stylelint/stylelint/issues/3847


Add fast pairwise rolling correlation function

@idrisr
def rolling_corr_pairwise(df, window):
   all_results = {}

   for col, left in df.iteritems():
       all_results[col] = col_results = {}
       for col, right in df.iteritems():
           col_results[col] = rolling_corr(left, right, window)

   return Panel(all_results)

added a slightly more efficient version of this. It's fairly speedy


deps: pin request to ~2.81.0

Checklist

[X] npm install && npm test passes
[X] commit message follows commit guidelines

Description of change
Required for "node < 4" compatibility and is congruent with npm
Fixes: https://github.com/nodejs/node-gyp/issues/1299

Another thing, if we ever decide to upgrade the node-gyp in the v4.x and v6.x branches, that too would result in duplication: their copies of npm are stuck on<EMAIL_ADDRESS>Not the end of the world, just something to keep in mind.

Another thing, if we ever decide to upgrade the node-gyp in the v4.x and v6.x branches, that too would result in duplication: their copies of npm are stuck on<EMAIL_ADDRESS>
I'll test if <2.82.0 get npm to dedup...

Indeed setting to <2.82.0 allows deduping:
$ npm ls | grep req
<EMAIL_ADDRESS>d:\code\4node\test-npm-request\npm
| +--<EMAIL_ADDRESS>deduped
| +--<EMAIL_ADDRESS>deduped
+--<EMAIL_ADDRESS>

@refack can you also give the minimum version in that specifier if you use <? I think right now you’d match any version of request before 2.82.0, up from 0.8.3 (which I assume does not work :))

I think right now you’d match any version of request before 2.82.0, up from 0.8.3 (which I assume does not work :))

Ack.
Did some bisecting - minimal version to pass npm test is 2.9.0.

thanks!

Ping @refack.


bug: "There is no data provider registered that can provide view data" error is displaying in commands table

Version
1.90
Describe the bug
after install the "cody" extension i couldn't able to use it properly
Expected behavior
It want to work well
Additional context
No response

Suffering the same issue here. There's a couple more on the forum. Hopefully we get some feedback on this soon. You'd do well to expand on the details though. Otherwise there's a risk that the only response you'll get is "Insufficient information to handle your ticket, please follow our guidelines on how to properly submit a bug report". I'll be sure to post back to you if I receive help before you do. Please do the same.

Cody automagically started working again this morning for me. How's it looking on your end?

Thank you for reporting this issue. To fix this we need more details about what IDE, version, etc. you're using on what operating system so we can reproduce the error that you're seeing.


Update _common.yaml homeassistant*.yaml for Vietnamese Languages

Added  the _common.yaml and homeassistant*.yaml for Vietnamese Languages

@dinhchinh82 we need at least as many test sentences as there are templates :+1:

@dinhchinh82 we need at least as many test sentences as there are templates 👍

@synesthesiam I just updated some test sentences. Please check.

Very close @dinhchinh82! Just need tests for one file, and fix the language in another.

Very close @dinhchinh82! Just need tests for one file, and fix the language in another.

@synesthesiam I just updated more test cases and fix the language id.