TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/32639

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/34923

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/50077

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/65629

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/87335

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/95383

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/97413

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/100567


No bot to use

This needs a bot to use it, with features similar to the old bot

[ ] Global vars with EXTERNAL
[ ] Reactions with EXTERNAL
[ ] Calling other's tags with EXTERNAL?
[ ] Making your own tags
[ ] Leaderboard of most used tags

[ ] Global vars with EXTERNAL
[ ] Reactions with EXTERNAL
[ ] Calling other's tags with EXTERNAL?
[ ] Making your own tags
[ ] Leaderboard of most used tags

B# solves these issues.


Home Page

as a User
I load the page
it loads a list of wishlists (the endpoint is GET /wishlist)
each wishlist has an arrow pointing down, the name of the wishlist, and the author
When I click a wishlist
It expands.
When it is expanded, the arrow is pointing up, there is a divider under the name and author, and there is a list of the items.
Ignore the checkboxes, add icon, delete icon, and edit icon for now
Done:

[ ] closed
[ ] expanded

I would recommend using an accordian to implement the expanding feature of each wishlist.


Fix styles for MoneyRequestHeader

@luacmartins please review
cc @grgia @parasharrajat
?w=1 review reccomended
Details
After reverting the styles back to what they were originally in this PR: https://github.com/Expensify/App/pull/18465 I went back to the drawing board to see how we could get the header to show properly for when we're using an AvatarWithDisplayName
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/270587
Tests
(Internal, dev)
Apply the following diff to your local code:
diff --git a/src/components/ReportActionItem/IOUAction.js b/src/components/ReportActionItem/IOUAction.js
index a7fe3f1710..6835776a87 100644
--- a/src/components/ReportActionItem/IOUAction.js
+++ b/src/components/ReportActionItem/IOUAction.js
@@ -67,7 +67,7 @@ const defaultProps = {

 const IOUAction = (props) => {
     const launchDetailsModal = () => {
-        Navigation.navigate(ROUTES.getIouDetailsRoute(props.chatReportID, props.action.originalMessage.IOUReportID));
+        Navigation.navigate(ROUTES.getReportRoute(props.action.originalMessage.IOUReportID));
     };

     const shouldShowIOUPreview = (
diff --git a/src/pages/home/ReportScreen.js b/src/pages/home/ReportScreen.js
index 6d573fe567..e32e41bc53 100644
--- a/src/pages/home/ReportScreen.js
+++ b/src/pages/home/ReportScreen.js
@@ -40,6 +40,7 @@ import getIsReportFullyVisible from '../../libs/getIsReportFullyVisible';
 import EmojiPicker from '../../components/EmojiPicker/EmojiPicker';
 import * as EmojiPickerAction from '../../libs/actions/EmojiPickerAction';
 import TaskHeaderView from './TaskHeaderView';
+import MoneyRequestHeader from '../../components/MoneyRequestHeader';

 const propTypes = {
     /** Navigation route context info provided by react navigation */
@@ -243,6 +244,17 @@ class ReportScreen extends React.Component {
         // (which is shown, until all the actual views of the ReportScreen have been rendered)
         const shouldAnimate = !shouldFreeze;

+        const moneyRequestHeader = this.props.report.type === 'iou' && this.props.report.reportID === '5571340985182399'
+            ? <MoneyRequestHeader report={this.props.report} policies={this.props.policies} personalDetails={this.props.personalDetails} />
+            : (
+                <HeaderView
+                    reportID={reportID}
+                    onNavigationMenuButtonClicked={() => Navigation.navigate(ROUTES.HOME)}
+                    personalDetails={this.props.personalDetails}
+                    report={this.props.report}
+                />
+            );
+
         return (
             <ScreenWrapper
                 style={screenWrapperStyle}
@@ -275,12 +287,7 @@ class ReportScreen extends React.Component {
                                     errors={addWorkspaceRoomOrChatErrors}
                                     shouldShowErrorMessages={false}
                                 >
-                                    <HeaderView
-                                        reportID={reportID}
-                                        onNavigationMenuButtonClicked={() => Navigation.navigate(ROUTES.HOME)}
-                                        personalDetails={this.props.personalDetails}
-                                        report={this.props.report}
-                                    />
+                                    {moneyRequestHeader}
                                 </OfflineWithFeedback>
                                 {Boolean(this.props.accountManagerReportID) && ReportUtils.isConciergeChatReport(this.props.report) && this.state.isBannerVisible && (
                                     <Banner

Replace the reportID in this line:
const moneyRequestHeader = this.props.report.type === 'iou' && this.props.report.reportID === '5571340985182399'

... with the reportID of an IOU report you have locally.

Click the IOU
See that you are taken to a blank component that renders the MoneyRequestHeader:
Make sure everything at the top header is aligned:

Go to Settings -> Preferences, make sure the header is aligned

Load an attachment, make sure the attachment preview header is aligned:

Offline tests

N/A

QA Steps

None, this component cannot be accessed in the App just yet without modifying the code directly.

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

@rushatgabhane @parasharrajat coming from this post, this is an EC3 issue so whoever can review first should do it.

seems like @parasharrajat is on it now

Thanks @parasharrajat! Updated!

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Tests good @parasharrajat let us know if you wont be able to get to this review

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[ ] MacOS / Chrome / Safari
[ ] MacOS / Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Atually did the testing and we are good to go

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

The issue should have been created automatically, since the PR points to an E/E internal issue. Not sure why it wasn't created.

Created payment issue here

Its created only when C+ approved the PR and Rajat could not do that after it was merged.

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
failure ❌

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.12-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Configure pylint to run as native pre-commit hook

This changes the pylint entry configured for pre-commit to be run as a native pre-commit hook rather than a local hook.
local hooks are described here:  https://pre-commit.com/#repository-local-hooks
Pros:

pylint will now run automatically as a pre-commit hook for contributors that have installed the pre-commit hooks with pre-commit install
the version of the pre-commit hook as specified in the rev key is a reference to the version of the hook and in this case specifies the pylint version to use
In the future, if necessary, the python version can also be specified in the pre-commit configuration if differences are found between the hook being run locally and via pre-commit

Cons:

due to the nature of pre-commit hooks and caching, the dependencies and sometime their versions for pylint to run need to be specified in the pre-commit configuration in addition to the tox.ini as well as the test-requirements.txt, This comes with operational overhead when they need to set or modified.
there is documentation in the dev version of pylint that suggests the hook only works with a local installation of pylint. It is unknown today exactly what this might mean in the future: https://pylint.pycqa.org/en/latest/user_guide/pre-commit-integration.html

If it becomes necessary to revert to a local hook in the future, the amount of work to do so should not be major, it would basically be a fail forward PR effectively reverting this one.

Blocking until #799 (comment) that keeps being marked by @ssbarnea as resolved will actually start being discussed.

Can you please be explicit because I am sure there is no comment that applies to the current code. You had lots of comments which were resolved.

Can you please be explicit because I am sure there is no comment that applies to the current code. You had lots of comments which were resolved.

When you follow that link, this is what you'll see (I've copied it for you):

This introduces differing indentation, keep it the same as above.
Also, what is the justification for maintaining a copy-paste of the dependency list and loosing the ability to pin the transitive deps via constraints/lock files?

I've emphasized the ignored but most important part of the comment.

The PR description is rendered as "No description provided." meaning that it does not address the concern either.

Well that second part was missed. Still, even reading it now I find it outside the scope of the PR.
We did not had any pining before, we don't lose ability to pin after. We use  pre-commit for all linters and I want to be able to use it directly, something that is do almost always before exploding a change. Having it as a manual check that works only from tox makes little to no sense.
local pre-commit hooks are problematic as the tool is unable to install them.

Well that second part was missed. Still, even reading it now I find it outside the scope of the PR.

This PR existence by itself goes against those concerns and the original intent of setting it up like this. So it is most definitely in the scope. At least a legitimate reason for blocking this PR.

We did not had any pining before, we don't lose ability to pin after.

It was on my list. And losing the ability has nothing to do with the prior presence of the constraints.

Having it as a manual check that works only from tox makes little to no sense.

It does, right after starting to take the reproducibility into the consideration.

We use pre-commit for all linters and I want to be able to use it directly, something that is do almost always before exploding a change.

Using something is not a good enough reason to actively prevent reproducibility, is it? It's definitely more important not to have random problems for unknown reasons reproducible in only specific env.

local pre-commit hooks are problematic as the tool is unable to install them.

That depends on the definition of what's problematic. Having non-reproducible linting runs is arguably more problematic.

Does having this as a native pre-commit hook include it in the list of checks run by pre-commit when it is installed? pre-commit install  If this is the case, that would be one benefit.  I've recently installed the pre-commit hooks and appreciate the checks automatically happening prior to the commit....

@cidrblock okay, if it's clearly documented in the PR description/commit that there are benefits and disadvantages, and that some of the problems were decided to be acceptable, I can live with that. But it should be transparent and it would be useful to also explain how to revert/fix the problems once they happen so that the tribal knowledge doesn't only live in a few people's heads.

@webknjaz This is perfectly reasonable, a great idea, and no one should expect less. I particularly like the idea of having trade off mentioned. I'll remember to ask for that when it's not clear.

@ssbarnea I'll add a better description with some pros/cons and rollback details in the AM if you don't beat me to it.

@ssbarnea @webknjaz Can you review the updated description for accuracy?  I think I understand this, at least now more than I did a couple months ago.


Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Build.Locator

Hi there,
I tried to init the toolspath for my Analyzer.
Somehow the toolspath can not be found.

I ran into the following error message:
Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Build.Locator, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=9dff12846e04bfbd'. Das System kann die angegebene Datei nicht finden. File name: 'Microsoft.Build.Locator, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=9dff12846e04bfbd'    at Ionide.ProjInfo.Init.init()    at ExpectoTemplate.main(String[] argv) in C:\Users\tforkmann\Documents\1_Tests\AzureTackle.Analyzer\tests\AzureTackleAnalyzer.Tests\Main.fs:line 10
Any idea what could be the reason for that?
I also just installed the newest VS build tools.
Environment (please complete the following information):

OS: Windows 10
Ionide version: 5 preview3
dotnet SDK version: 5.0.100

Is the code OSS? Can you show me the Paket.deps and Paket.lock files?

Of cause it is :)
But not working yet ;)
https://github.com/tforkmann/AzureTackle.Analyzer

Locator should be marked as copy_local: false here https://github.com/tforkmann/AzureTackle.Analyzer/blob/master/paket.dependencies#L25
Any other MsBuild library should, but Locator is actually the one that needs to be deployed with your software.
Here's how we set up MsBuild deps in FSAC:
https://github.com/fsharp/FsAutoComplete/blob/new-project-system/paket.dependencies

That worked! Thanks


Followed the standard docker install and not getting the first time setup

I followed the standard install exactly, only changing the parts that need to be changed such as the secrets and volume mappings. When I access the webpage I get just a login page. The only thing I did "differently" was that I set it up using portainer and in portainer I loaded the .env file into the stack instead of having the .env file with the compose file. So maybe that's why but all the variables I can check without logging in seem to have worked (I can see the port number is exposed and the correct volume directory has been filled with files).

Run docker compose logs backend and attach the output, I can help you debug it.

Sorry for the late reply, busy holiday season. Your suggested helped me discover the issue myself. The log said that the csrfTrustedOrigins needed http:// or https:// before it, I just had the URL. After adding that, deleting all the created files and volumes, and redeploying it worked as expected. Thanks for the clue!


How to uninstall

Microsoft PowerToys version
0.81.0
Installation method
GitHub
Running as admin
No
Area(s) with issue?
General
Steps to reproduce
I believe it is already uninstalled but it keeps popping up, it's not showing on remove add and programs
✔ Expected Behavior
To be removed completely after using the uninstaller
❌ Actual Behavior
It is still installed but not showing on installed apps
Other Software
No response

Can you try to install PowerToys again and then reuninstalling it?
/needinfo


Wrong number of session for pgbouncer ?

Hi,
While parsing a pgbouncer file, I have some trouble interpreting the "Simultaneous sessions" graph and its key value. See:

pgbadger-num-session-per-min.png

the key values in the report are
Session Peak
580 sessions
2017-12-21 12:04:17 Date

When parsing myself the log looking for session login/closing, I found another graph. See log-num-session-per-min.png

Is this a bug ? A misunderstanding on my side ?
Thanks,

Commit 20cb253  changes the title "Number of sessions (1 minute average)" into  "Number of sessions/second (1 minute average)". The statistic represent an average perl second of all session opened during the interval, here 1 minute and 5 minutes by default. I think this is the reason of the misunderstanding.
Min and Max are the minimal and maximum number of sessions opened at a second during the interval.


Fix version output

Currently only outputs:
$ vegas-credentials --version
vegas-credentials version development

Implemented in rewrite branch. Waiting for merge & publish.


Fix SE/SR links in CHANGELOG.

@swift-ci Please smoke test and merge

Isn't this https://github.com/apple/swift/pull/24087/files

Totally is! Thanks @slavapestov


EnergyCost Option under EVE not available

Hi Erik
I have connected a Xiaomi Smart Plug (Zigbee version) to my infrastructure. This plug monitors the power consumption and shows at the same time also the energy cost. All works fine, just one thing is missing. Based on EveHome webpage the cost per kWh should be configurable under Setting -> General (https://www.evehome.com/en/blog/all-features-eve-energy). But I don't see the option "Energy Cost" listed there.
Is it possible that this only works if Eve App identifies a power monitoring plug from their company?
I guess currently it takes a default cost of 0.23 per kWh.
Kind regards, Martin

I wouldn't know.  I recently set a new test environment with a new home on another iCloud account, and indeed, Eve doesn't show the Enegery Cost.  I do have some first-generation Eve Energy plugs hidden away in a cupboard, that I used previously with my production home.
The Total Cost and Projected Cost are pretty useless anyways: they don't account for multi-tiered rates, nor for any fixed monthly costs.   I have different rates for (work) day vs night (incl. weekends and public holidays).  Of course neither the Eve Energy (nor any Zigbee plug) nor the Eve app would know what rate is active at what time, but my smart electricity meter reports this though Homebridge P1.
Eve seems to somehow retrieve the average rate per country.  I don't know where they get it from, nor how often this is updated (my iPad shows "Last updated: 3 March 2021" instead.

I added Homebridge Hue to the test home and now Eve does show the Energy Cost.  Homebridge Hue exposes some innr SP120 and some Heiman plugs.  Both these plus types expose Total Consumption, Consumption, Current, and Voltage.  What does the Xiaomi plug expose?  Do you see Eve history on the Total Consumption?  I think Total Cost is linked to Total Consumption and Projected Cost to Consumption

Hi Erik. Thank you for your fast reply!
Yes true, we also have different rates here in Switzerland depending on the time of the day or if its weekend or not. I see in your eve application that Energy Cost setting is available. I checked on my ipad but it does look differently. No Energy Cost option available. Strange. I am using version 5.0.2.
The Eve history shows all nicely, total consumption, consumption, current, ... Just wanted to adjust the cost pero kWh but as you wrote, only makes limited sense.
here the printscreens, sorry all in German

I read German, no problem.  It looks like you don't expose the /lights resource (to switch the plug on and off)?  That's probably required for Eve to recognise the plug as "Eve Energy".
I cannot see from the screen print whether the sensor also exposes (current) Consumption (in W).  deCONZ should either expose a ZHAConsumption /sensors resource with additional state.power, or a separate ZHAPower /sensors resource.  I don't know the Xiaomi plug, but knowing Xiaomi (to the extent that's possible), they probably use different clusters for state.consumption and state.power.

ah, that's it! Yes, it does show as different cluster. Power and Consumption are on one, but the corresponding plug (light) is detached and only shows (when navigating to detail) the power button.

OK, there's something odd in your configuration.  deCONZ exposes the plug as three different resources.  Homebridge Hue should combine them into one accessory with one service, but it looks like there's three different services.  Could you attach the debug dump file and capture and attach a debug log file?  See the FAQ how to do that.

that is odd. in deCONZ I see all three functionality listed below each other.

In the log file I see that under ID 00158D0002FB3C54 the consumption and power sensors are listed, however the switches are not listed at all and I have installed 5 switches (from IKEA and Xiaomi). Am I using wrong setting of your plugin?
homebridge.log.txt

You're not exposing /lights resources through Homebridge Hue.  The wireless switches are exposed, according to your log.  I don't know where you got the other services in Garten, but not from Homebridge Hue.

ah, understood! very likely the lights get in via the "Homebridge Platform Deconz" plugin that I had installed first. I will test it out.

I am going to close this issue. It seems to be on my Eve app somehow. Last entry in this forum: https://forum.smartapfel.de/forum/thread/4118-eve-für-homekit-eintrag-für-energiekosten-messung-nicht-vorhanden/ has the same issue. and they are not using your plugin. So nothing wrong with your plugin. When I have a solution I can still add it to this thread.
Thanks again for your help Erik! At least now the devices are listed a lot nicer :)


Country name in French

Please, there is an error in nomination of Morocco in French
Morocco is Maroc in French not Moroc, can I control the nomination?

@briouyaasmae Thank you. Released in v2.0.20.


Add support for [BREAKING CHANGES] tag in travis-ci

Signed-off-by: Riddhesh Sanghvi<EMAIL_ADDRESS>

We can merge for now. Will have to update in docs.

Closing in favour of https://github.com/EasyEngine/easyengine/pull/1175


Network mode awsvpc (fargate) conflicts with hostname

Fargate services requires network mode to be awsvpc. This conflicts with the hostname that is set by deplojo (were hostname is not allowed for awsvpc modes).
This results in an error while deploying the services:
botocore.errorfactory.ClientException: An error occurred (ClientException) when calling the RegisterTaskDefinition operation: hostname is not supported on container when networkMode=awsvpc.
If we apply a check on network mode, that would do the trick.
https://github.com/labd/ecs-deplojo/blob/fb7b153f84916c751c9e699a643b41f63af773eb/src/ecs_deplojo/task_definitions.py#L222-L229

This issue is fixed in version 0.9.2, released to pypi as well: https://pypi.org/project/ecs-deplojo/

This issue is fixed in version 0.9.2, released to pypi as well: https://pypi.org/project/ecs-deplojo/


Issue Title : Info about the related issue (Aim of the project) : Name: GitHub ID: Idenitfy yourself: Closes: #issue number that will be closed through this PR  Describe the add-ons or changes you've made 📃 Give a clear description of what have you added or modifications made

Issue Title :Add a link on navbar and add venues and how many match played at that stadium.
Name: Patel Yashkumar Amitbhai
GitHub ID:  https://github.com/patelyash5208
Idenitfy yourself: contributer
Closes: #20
Describe the add-ons or changes you've made 📃
Add vanue page and link the navbar of home page

Please add this pull request @Nirvik07

@patelyash5208 check everything and if you face  any problem with Hacktoberfest point system related to my repo, ping me in discord. Discord Id : babe07#7187


python311Packages.exitcode: init at 0.1.0

Description of changes
Preferred system exit codes as defined by sysexits.h
https://github.com/rumpelsepp/exitcode
Required for #257633

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 257636 run on x86_64-linux 1

4 packages built:

python310Packages.exitcode
python310Packages.exitcode.dist
python311Packages.exitcode
python311Packages.exitcode.dist


Kr1m Attempt3 - XGBoost Hype

Kr1m Attempt3 - XGBoost Hype!

Hello! Thanks for this... it scores 0.556. Cheers!


Add minBy, maxBy

I often want to determine the minimum or maximum element from a list by a certain criterium that can be derived from each list element. For instance, let's say I have a list of strings and want to determine the longest one.
Currently, min and max expect a comparison function that receives two entries, then returns a negative number, zero, or a positive number depending on whether the first element is less than, equal to, or greater than the second element, respectively.
So currently, I'd write my query as
Query.from(stringValues).max((a, b) => a.length - b.length);

This certainly works well for many situations, but it tends to get a bit verbose in many cases.
Many other libraries (such as Lodash) offer additional methods minBy and maxBy. They expect a callback that takes a single value and returns the corresponding comparison value.
If iterable-query supported these methods, I could write the example above as
Query.from(stringValues).maxBy(s => s.length);

Would it be better to have minBy/maxBy or a fn.propertyComparer function? The propertyComparer route would avoid over-cluttering the Query api:
// fn/common.ts
export function propertyComparer<T extends object, K extends keyof T>(key: K): (a: T, b: T) => number {
  return (a: T, b: T) => compare(a[key], b[key]);
}

// usage:
from(…).min(fn.propertyComparer("length"))

I went ahead with minBy/maxBy.
Fixed in 7a179038a1af7e1c649f0ff61549046b09b31a19<EMAIL_ADDRESS>now on npm)

Wow, that was quick! Thanks!

Keep the suggestions coming. Once I improve the test coverage a bit I'll publish a 1.0.0 release.


error occurs on click button

======== Exception caught by gesture ===============================================================
The following assertion was thrown while handling a gesture:
'package:flutter/src/widgets/navigator.dart': Failed assertion: line 4595 pos 12: '_debugLocked': is not true.
Either the assertion indicates an error in the framework itself, or we should provide substantially more information in this error message to help you determine and fix the underlying cause.
In either case, please report this assertion by filing a bug on GitHub:
https://github.com/flutter/flutter/issues/new?template=2_bug.md
When the exception was thrown, this was the stack:
#2      NavigatorState._pushEntry (package:flutter/src/widgets/navigator.dart:4595:12)
#3      NavigatorState.push (package:flutter/src/widgets/navigator.dart:4511:5)
#4      NavigatorState.pushNamed (package:flutter/src/widgets/navigator.dart:4243:12)
#5      _MyHomePageState.build. (package:mlm_project/ui/home_new.dart:46:33)
#6      _InkResponseState._handleTap (package:flutter/src/material/ink_well.dart:989:21)
#7      GestureRecognizer.invokeCallback (package:flutter/src/gestures/recognizer.dart:193:24)
#8      TapGestureRecognizer.handleTapUp (package:flutter/src/gestures/tap.dart:608:11)
#9      BaseTapGestureRecognizer._checkUp (package:flutter/src/gestures/tap.dart:296:5)
error occurs when click on float button for change page
i am using emulator for debugging
flutter doctor -v is as below
F:\FlutterSdk\flutter_windows_2.2.3-stable\flutter\bin>flutter doctor -v
[√] Flutter (Channel stable, 2.5.3, on Microsoft Windows [Version 10.0.19042.1348], locale en-US)
• Flutter version 2.5.3 at F:\FlutterSdk\flutter_windows_2.2.3-stable\flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision 18116933e7 (9 weeks ago), 2021-10-15 10:46:35 -0700
• Engine revision d3ea636dc5
• Dart version 2.14.4
[√] Android toolchain - develop for Android devices (Android SDK version 31.0.0)
• Android SDK at F:\AndroidSdk
• Platform android-31, build-tools 31.0.0
• ANDROID_SDK_ROOT = F:\AndroidSdk
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
• All Android licenses accepted.
[√] Chrome - develop for the web
• Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[√] Android Studio (version 2020.3)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.10+0-b96-7249189)
[√] Connected device (3 available)
• Android SDK built for x86 (mobile) • emulator-5554 • android-x86    • Android 10 (API 29) (emulator)
• Chrome (web)                       • chrome        • web-javascript • Google Chrome 96.0.4664.110
• Edge (web)                         • edge          • web-javascript • Microsoft Edge 94.0.992.38
• No issues found!

Hi @gurjeetsinghsainig, this is a fairly common issue and is usually caused by wrong code implementation.
See possible solutions below
https://stackoverflow.com/questions/66713072/flutter-navigator-failed-assertion-debuglocked-is-not-true-on-navigator-p
https://github.com/flutter/flutter/issues/49779
I'll go ahead and close this now as it is not a bug or feature request. If you disagree, please write in the comments and I will reopen it.


Added __order argument to mutate that specifies ordering in which columns are assigned

Fixes #6

This looks great, but I have one additional check I'd like it to make-- making sure the items in columns are the same as the items in kwargs, in addition to the length check.

Added along with tests


[Idea]: Add restriction to using /mvtp

Describe the feature
I would like to see a feature added where /mvtp can only be used if the player is near the spawn point of the world they're in. Players are abusing the /mvtp system to move to another world, and back, to effectively teleport to spawn, and I don't want that. I'm explicitly against /TP commands for players, to encourage world exploration and keep the difficulty.
How is the feature useful to all Multiverse users?
Setting a radius restriction can allow admins to force players to be near the spawnpoint to use /mvtp. A feature that I find very desirable.
Agreements

[X] I have searched for and ensured there isn't already an open issue regarding this.

This looks like a very specific feature that should be achieve by a spawn plugin. You probably better off with like a sign or portal at spawn instead of using to commands.


nsjail: git-2015-08-10 -> 2.1

Motivation for this change
Bump to a more recent and stable release of the tool
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

@bosu you might want to review although it's been a while since your init of the package :)

FWIW, it is fine by me.


Feature request : Automatic export for deal auction

Hello,
Can you provide a script to automatically prepare the deals for the auction bidding on SWAN?
Our system can make files ready like /swan/swandealabc.tgz
If you can handle it from there , my suggesion is that your script copies the file to a directory ( on my server / there needs to be a configurable variable for that ) where it can be downloaded.
From my scripts , i will call your script then like :  /runthisscript.sh filenametoprocess.tgz.

User need to create an API token first, then they need to have several APIs for project working:
using config.toml set the API key and API token.
Post public deals with POST Deal API.
The data preparation will be another batch job which it not related to the current task.
Assume you ready have a folder of 2GB each files, you can combine them to the file size as you want. then generate a car file for processing
Car file is better for user than tgz right? or a tgz will be better, then the miner created the car file?
Thanks.


Improve AWAKE flow to handle concurrent requests

Writing down some thoughts that Brooke and I had late last year, not because I think that should be implemented in this PR, but because I think it could inform the design for the protocol state:
When there's more than 2 participants in a websocket channel for device linking, we should track the protocol state for all of them (maybe until a maximum of 10 or 100 or 1000) and simultaneously execute the AWAKE protocol with all of them.
When the step for "comparing the numbers on both devices" comes, instead of showing the user numbers, we show the user a number input and they have to enter the number that they see on the other device themselves.
This both serves as a check "are you connecting with the device you think you're connecting?" as well as a way to identify the device you want to connect with, if there's multiple devices that successfully went through every previous step of the AWAKE protocol.
(I thought I had written up an issue for that, but I can't find it :/ )
Again, just to inform the design code-wise. I personally find it helpful seeing ways that code might evolve in the future.

Originally posted by @matheus23 in https://github.com/fission-suite/webnative/issues/335#issuecomment-1009782161

When the step for "comparing the numbers on both devices" comes, instead of showing the user numbers, we show the user a number input and they have to enter the number that they see on the other device themselves.

Which device do they enter the pin on? The device(s) they are linking (the consumers) or the device that is delegating credentials (the producer)?
In the current version of the whitepaper, the consumer generates the pin:

The requestor displays a challenge (PIN code) to the user. It sends the PIN and DID/signing key (encrypted with the AES key) over pubsub. The UCAN holder decrypts and displays this PIN to the user and asks them to confirm that it matches. If it matches, you are talking to the correct machine, and you have the DID to delegate to 🎉

Would we want to update this so the producer generates the pin and each consumer verifies the pin by entering it into an input?

The other way around: The producer enters the pin. And the consumers keep being the ones to generate the PIN.
Don't think of the PIN as a password. It's just a random, kept-secret-from-the-other-consumers ID for the user to figure out which device they're linking with.
Sidenote: It's really unlikely that two consumers generate the same pin (assuming consumers choose random PINs & we're capping the protocol at 100 concurrent states).

Blocked by whitepaper changes.

This is more of a priority now that Bluesky has decided to adopt AWAKE!

More details on how to improve this here: https://github.com/fission-suite/webnative/issues/358
Maybe we want to consolidate these into one issue? 🤔

It's happening here: https://github.com/ucan-wg/awake


Update DOI and intro

Update DOI to point to versionless deposit on Zenodo (so it will always point to latest version)
Update DOI badge
Place DOI badge under title as is custom
Update description
Place <hr> to separate description from the draft text in the rest of the README

I copied what Zenodo said was the versionless DOI:

Maybe that page on Zenodo is incorrect, the DOI is different in the Markdown vs the line above.


Initial implementation of multitester

Implements part of #72.
I wanted to work on this first because it should help me find the problem in the add implementation.
Test failures now look like this:
__addsf3 - Args: 1<PHONE_NUMBER>
  rustc-builtins: Some(0)
  compiler_rt:    Some(14950609)
  gcc_s:          None
__addsf3 - Args: 1 632426600
  rustc-builtins: Some(0)
  compiler_rt:    Some(0.00000000000000030889195)
  gcc_s:          None
__addsf3 - Args: 1 316213300
  rustc-builtins: Some(0)
  compiler_rt:    Some(0.0000000000000000000000000013696648)
  gcc_s:          None

[snip]

thread 'float::add::tests::_test::__addsf3' panicked at '[quickcheck] TEST FAILED. Arguments: (1, 1)', /home/matt/.cargo/registry/src/github.com-1ecc6299db9ec823/quickcheck-0.3.1/src/tester.rs:118

It currently prints all of the errors, if that's undesirable we'd need to remove the shrinkers or modify quickcheck.

Nice!

@homunkulus r+
Thank you, @mattico :+1:

:pushpin: Commit 02140cd has been approved by japaric

:hourglass: Testing commit 02140cd with merge 954e3b7...

:sunny: Test successful - status-appveyor, status-travis
Approved by: japaric
Pushing 954e3b70959ba8c6df6fc564a5f758f518b44286 to master...


mdformat mkdocs

messed up lines:

112                    extra spaces
121 - 129          extra spaces
174                    - [ ] **
others

zz Pre-work Checklist DevOps-Security-Member drakeredwind01 #36 1.md
zz Pre-work Checklist DevOps-Security-Member drakeredwind01 #36 2.md

Thanks for submitting an issue and trying out mdformat-mkdocs!
There are a couple of issue with the source file that need to be manually resolved before mdformat will know how to parse. For the below examples, I generated the HTML with the online CommonMark app: https://spec.commonmark.org/dingus
Markdown treats indents as part of the language (https://spec.commonmark.org/0.31.2/#indented-code-blocks). For example:

- [x] Install Terraform Docs locally by following the instructions of the installation guide mentioned in [Installing Terraform docs](https://github.com/hackforla/devops-security/blob/main/CONTRIBUTING.md#installing-terraform-docs)

    #### WINDOWS

    - if you have windows you first need [scoop](https://scoop.sh/#/)
    - run scoop command

Renders to HTML as a nested list in this case:

[x] Install Terraform Docs locally by following the instructions of the installation guide mentioned in Installing Terraform docs

WINDOWS

if you have windows you first need scoop

run scoop command

Or if line 102 had been a paragraph instead of a list, then the indented text would be rendered as a code block:

Text

	#### WINDOWS

- if you have windows you first need [scoop](https://scoop.sh/#/)
- run scoop command

Code within lists needs to be on its own line and in a fenced block (e.g. ```):
<!-- 2.md Lines 107:110 (unindented and code blocks moved to new lines) -->

run scoop command
```cmd
scoop bucket add terraform-docs https://github.com/terraform-docs/scoop-bucket
scoop install terraform-docs
```

if you don't have scoop run install it by running the following in powershell
```powershell
iex (new-object net.webclient).DownloadString('https://get.scoop.sh')
```

if you get following error in red letters run the bellow command PowerShell requires an execution policy in [Unrestricted, RemoteSigned, ByPass] to run Scoop. For example, to set the execution policy to 'RemoteSigned' please run 'Set-ExecutionPolicy RemoteSigned -Scope CurrentUser'.

Renders to:

run scoop command

			scoop bucket add terraform-docs https://github.com/terraform-docs/scoop-bucket
scoop install terraform-docs

if you don't have scoop run install it by running the following in powershell

					iex (new-object net.webclient).DownloadString('https://get.scoop.sh')

if you get following error in red letters run the bellow command PowerShell requires an execution policy in [Unrestricted, RemoteSigned, ByPass] to run Scoop. For example, to set the execution policy to 'RemoteSigned' please run 'Set-ExecutionPolicy RemoteSigned -Scope CurrentUser'.

Oh, I think I might have misunderstood a few things:

I see now that 1.md is the original text
And that the nested header within the list on line 102 was intended

With that understaning, I've pushed a formatted version of 1.md that appears to pass mdformat logic for review here: https://github.com/KyleKing/mdformat-mkdocs/pull/39/files
You can see the changes I made in this diff: https://github.com/KyleKing/mdformat-mkdocs/pull/39/commits/897290716ac37e873c165370cf15962180767c8a

Also, TIL that this is valid Markdown:

iex (new-object net.webclient).DownloadString('https://get.scoop.sh')

I've created a feature request to support it, but it might be a week or two before I have time again: #40

Took awhile, but I finally have a patched version of mdformat-mkdocs which should correctly format the provided sample file. Let me know if you run into any additional issues. I've tested running against the original file here: https://github.com/KyleKing/mdformat-mkdocs/pull/42/commits/3a71535946e78a0aecfa81febfb395934450aad4?w=1 (using uv: #42)


[APPM-1033] Restricting app visibility

 Under the 'Global Policies' under the 'Create New Web Application' page lists a global policy named 'Restrict Visibility'. This gives an impression where by adding users roles into the corresponding field we are restricting the corresponding users from accessing the app. However, the intention is otherwise. Thus the Field label should be rephrased. Suggestions : "Visible To", "Visibility Restricted To".   When you click a letter in the current 'Restrict Visibility' field not only lists roles, but also app versions (REF: Snip20150723_34.png). Reference: https://wso2.org/jira/browse/APPM-1033

Web app functionalities are not related to IoT server at the moment, hence closed.


Summary all and each domain and history

Summary Include:

Last backup datetime
Last backup file size and name
Total size of a bqckup (Database and Files)
Total files
Storage Name
Schedule (daily | weekly | monthly)
Next Backup (datetime)
Local Backup

Commands:
bqckup summary --site domain1.com
bqckup summary

bqckup history --site domain1.com
bqckup history

History include :

backup name : abc (weekly)
last backup date :
last database file size :
last file file size :
status (success/failed)


Series Provider Remake not handling Nones correctly

Series provider has an error when a ingestion class returns None. This is because I try to access data off of the result before checking if its None
validated_merged_result = self.__generate_resulting_series(seriesDescription, timeDescription, series_storage_results.data, data_ingestion_results.data)


Update README.md

The newer releases of the windows containers have fixed the 'localhost' issue that was previously being experienced, so I've updated the readme to match.

The "hairpin" problem still affects ltsc2016 and 1709 hosts. Can you update your changes to reflect that it only works on newer hosts?

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: Lampei sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Sorry about that.  I've updated the section to include the old method for getting the IP address for the container, but added the section mentioning how to do it for newer hosts.

Thanks @Lampei, I've added a few minor nits.

changes applied

actually need to make one adjustment...the port should be 8000 even for the IP address one, right?  As the example exposes port 8000:80

Not quite. 8000 is the mapped port in this example.
When you're accessing the container directly on the host, you're accessing the actual port exposed in the container (in this case). If you're going through the NAT (either via WinNAT on http://localhost:<mapped-port-on-host> or from an external machine via http://fqdn:<mapped-port-on-host>

OK, switched it back again

Thanks for the contribution!


[1pt] Refactor the redux files

Simplify the reducers and actions

IMplemented in PR https://github.com/piero-vic/house-booking-front-end/pull/12


unclear behavior of increment function in the Number field

Describe the bug
When we have a number field and a form input number provided to it say "5" when we try to apply the increment to it by entering a increment value to it say 10, the increment does not apply to the input value provided rather starts from 0 and increments by the number provided for increments. It is not clear how the increment should be applied to the input value,
Steps to reproduce

Create a new form
Add a number form element
To the number field add a form input value as "5"
In the properties panel enter the increment value as "10"
Click on the up arrow in the preview of the number field we could see that the increment is not applied to the number inputted but starts from 0

https://user-images.githubusercontent.com/85225325/211042575-5385ef92-0d26-4318-9b12-971cfe429fa0.mp4
Expected behavior
Unclear behavior of increment function in the Number field
Environment

OS: [ Windows 10]
Camunda Modeler Version: [5.7.0 rc-1]
Execution Platform: [ Camunda Cloud]

Additional context
No response

This is expected behavior, the increment doesn't dictate the amount that the arrow increments by, but rather the increments which are valid for the field.
It seems here that the confusion is more one of language than anything else.

Ah, actually there's a bigger bug at play here, the validation for the increment doesn't work anymore. If the validation was there the behavior would be crystal clear. Will provide a fix shortly.

Fixed upstream via https://github.com/bpmn-io/form-js/commit/9b339dc275752b3f560199faf4159608b2d669b0

https://github.com/camunda/camunda-modeler/pull/3422 restores the validation to provide additional guidance to the user:


How to reduce the number of classes ?

I want to retrain the model with my custom dataset with only 3 classes. What are the changes that I should do? Should I edit the model file?

You have to add the number of classes when you generate the model using  the gen_model.sh script. So in your case you would just do:
$ ./gen_model.sh 3


Question: I have a linking problem

Hi, all.
I followed the example here(https://github.com/janjongboom/jerryscript/tree/the-answer)
I cloned that repository and got the following error when I ran make file.
Scan: FEATURE_STORAGE
Scan:
Scan: mbed
Scan: env
Compile: launcher.cpp
Link: mbedos5
./BUILD/NUCLEO_F446RE/GCC_ARM/jerryscript-mbed/jerryscript-mbed-launcher/source/setup.o: In function `jsmbed_js_load_magic_strings()':
setup.cpp:(.text._Z28jsmbed_js_load_magic_stringsv+0x6c): undefined reference to `jsmbed_js_magic_string_count'
setup.cpp:(.text._Z28jsmbed_js_load_magic_stringsv+0x70): undefined reference to `jsmbed_js_magic_string_lengths'
setup.cpp:(.text._Z28jsmbed_js_load_magic_stringsv+0x74): undefined reference to `jsmbed_js_magic_strings'
setup.cpp:(.text._Z28jsmbed_js_load_magic_stringsv+0x78): undefined reference to `jsmbed_js_magic_string_values'
collect2: error: ld returned 1 exit status
[ERROR] ./BUILD/NUCLEO_F446RE/GCC_ARM/jerryscript-mbed/jerryscript-mbed-launcher/source/setup.o: In function `jsmbed_js_load_magic_strings()':
setup.cpp:(.text._Z28jsmbed_js_load_magic_stringsv+0x6c): undefined reference to `jsmbed_js_magic_string_count'
setup.cpp:(.text._Z28jsmbed_js_load_magic_stringsv+0x70): undefined reference to `jsmbed_js_magic_string_lengths'
setup.cpp:(.text._Z28jsmbed_js_load_magic_stringsv+0x74): undefined reference to `jsmbed_js_magic_strings'
setup.cpp:(.text._Z28jsmbed_js_load_magic_stringsv+0x78): undefined reference to `jsmbed_js_magic_string_values'
collect2: error: ld returned 1 exit status

[mbed] ERROR: "python" returned error code 1.
[mbed] ERROR: Command "python -u /home/parallels/dev2/jerryscript/targets/mbedos5/mbed-os/tools/make.py -t GCC_ARM -m NUCLEO_F446RE --source . --source ../../ --build ./BUILD/NUCLEO_F446RE/GCC_ARM -j0 -D CONFIG_MEM_HEAP_AREA_SIZE=(1024*16)" in "/home/parallels/dev2/jerryscript/targets/mbedos5"
---
make: *** [all] Error 1

Any help will be greatly appreciated.

Adding @janjongboom and @thegecko as this seems to be related to the mbed OS port.

@limjunsung That branch is quite outdated... Can you run through the 'TheAnswer' example with https://github.com/armmbed/mbed-js-example? The C++/JS bindings will be exactly the same so you can follow along, but mbed-js-example is constantly updated.
Just built it for NUCLEO_F446RE and it builds & links fine...

@janjongboom Thank you for your reply. I have confirmed that it works well. Actually, I really want to make real-time javascript interpretor running on mbed os 5. So, I tried to run the example that you wrote (https://github.com/janjongboom/mbed-js-repl-example), but it shows error message below whenever I run the command 'gulp --target=NUCLEO_F446RE'.
Compile [ 99.2%]: jerry_port_mbed.c
[Warning] jerry_port_mbed.c@61,7: implicit declaration of function 'strlen' [-Wimplicit-function-declaration]
Compile [ 99.5%]: stm_spi_api.c
Compile [ 99.7%]: test_env.cpp
Compile [100.0%]: repl_js.cpp
[Warning] repl.h@111,49: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
[Warning] repl.h@133,49: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
[Warning] repl.h@189,49: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
[Warning] repl.h@207,28: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
[Warning] repl.h@212,33: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
[Warning] repl.h@257,45: variable length array 'buffer' is used [-Wvla]
Link: mbedos5
/Users/junsunglim/gcc-arm-none-eabi-6_2-2016q4/bin/../lib/gcc/arm-none-eabi/6.2.1/../../../../arm-none-eabi/bin/ld: ../../../out/NUCLEO_F446RE/mbedos5.elf section `.text' will not fit in region `FLASH'
/Users/junsunglim/gcc-arm-none-eabi-6_2-2016q4/bin/../lib/gcc/arm-none-eabi/6.2.1/../../../../arm-none-eabi/bin/ld: region `FLASH' overflowed by 18196 bytes
collect2: error: ld returned 1 exit status
[ERROR] /Users/junsunglim/gcc-arm-none-eabi-6_2-2016q4/bin/../lib/gcc/arm-none-eabi/6.2.1/../../../../arm-none-eabi/bin/ld: ../../../out/NUCLEO_F446RE/mbedos5.elf section `.text' will not fit in region `FLASH'
/Users/junsunglim/gcc-arm-none-eabi-6_2-2016q4/bin/../lib/gcc/arm-none-eabi/6.2.1/../../../../arm-none-eabi/bin/ld: region `FLASH' overflowed by 18196 bytes
collect2: error: ld returned 1 exit status

[mbed] ERROR: "python" returned error code 1.
[mbed] ERROR: Command "python -u /Users/junsunglim/dev/mbed-js-repl-example/build/jerryscript/targets/mbedos5/mbed-os/tools/make.py -t GCC_ARM -m NUCLEO_F446RE --source . --source ../../ --source /Users/junsunglim/dev/mbed-js-repl-example/node_modules/mbed-js-repl/. --source ../../../source --build ../../../out/NUCLEO_F446RE -j0 -D CONFIG_MEM_HEAP_AREA_SIZE=(1024*16)" in "/Users/junsunglim/dev/mbed-js-repl-example/build/jerryscript/targets/mbedos5"
---
make[1]: *** [all] Error 1
make: *** [all] Error 2
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: Command `make BOARD=NUCLEO_F446RE EXTRAS=/Users/junsunglim/dev/mbed-js-repl-example/node_modules/mbed-js-repl/.` exited with code 2
    at ChildProcess.handleSubShellExit (/Users/junsunglim/dev/mbed-js-repl-example/node_modules/gulp-run/command.js:166:13)
    at Object.onceWrapper (events.js:290:19)
    at emitTwo (events.js:106:13)
    at ChildProcess.emit (events.js:191:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)

Could you give me a advice that solves the problem?

@limjunsung For some reason the REPL uses 150K more flash, which makes it fail linking on most targets (except K64F)... Not sure why it uses so much. Hope to spend some time on it this week. The map file is a lot bigger, so would be good to dig through there.

Quick inspection: probably because it relies on libstdc++ and that uses a lot of flash. Let's see if that can be fixed.

So stringstream has a much larger footprint than I thought. Uses 140K of flash... Let's see if I can rewrite without stringstreams.

@limjunsung I wrote a patch here: https://github.com/janjongboom/mbed-js-repl/pull/1, now it compiles and links against NUCLEO_F446RE.

@janjongboom It works well!!!! Thank you soooooo much!!


removed token secret since this is an open source repo

Codecov Report

Merging #10 (1b0c3ea) into main (5c6b5ec) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   95.12%   95.12%
=======================================
  Files           7        7
  Lines         164      164
  Branches       22       22
=======================================
  Hits          156      156
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c6b5ec...1b0c3ea. Read the comment docs.


Installing Plugin

Forgive me for being an idiot...but how exactly do i install this plugin???

Copy the .js, .json and .css files to a new folder under the .obsidian\plugins folder in your vault, restart Obsidian and enable the plugin in Obsidian settings.

Don't worry @Quasaur. The plugin should be in the official list of community plugins within a few weeks, it'll be much simpler at that point. For now, follow @tijmenvdk's instructions.


adding WebSocketClientSession with pooling for websockets

For another project, I wrote a class called WebSocketClientSession that implements websocket connection pooling with support for multiple endpoints. It is basically a cross between aiohttp.BaseConnector and aiohttp.ClientSession.
This morning I packaged it and wrote some functional tests, but I was thinking that this might be better as addition to the main aiohttp library. It adds a class and requires very minor changes to the aiohttp.websocket_client.ClientWebSocketResponse class (including a release coroutinemethod) and the aiohttp.ClientSession.ws_connect method. If you are interested in this feature, I would be happy to do a PR, if not, I'll keep it as a separate package. Thanks for your time in advance.
The new class would be something like this:
class WebSocketClientSession:

    def __init__(self, *, conn_timeout=None, force_close=False, limit=None,
                 client_session=None, loop=None,
                 ws_response_class=ClientWebSocketResponse):
        if loop is None:
            loop = asyncio.get_event_loop()
        self._closed = False
        if loop.get_debug():
            self._source_traceback = traceback.extract_stack(sys._getframe(1))
        self._conns = {}
        self._acquired = defaultdict(list)
        self._conn_timeout = conn_timeout
        self._force_close = force_close
        self._limit = limit
        self._waiters = defaultdict(list)
        self._loop = loop
        self._ws_response_class = ws_response_class
        if client_session is None:
            client_session = ClientSession(
                loop=self._loop, ws_response_class=self._ws_response_class)
        self._client_session = client_session

    @property
    def force_close(self):
        return self._force_close

    @property
    def limit(self):
        return self._limit

    @asyncio.coroutine
    def close(self):
        if self._closed:
            return
        self._closed = True

        try:
            if hasattr(self._loop, 'is_closed'):
                if self._loop.is_closed():
                    return
            for key, data in self._conns.items():
                for websocket in data:
                    yield from websocket._close()

            for websocket in chain(*self._acquired.values()):
                yield from websocket._close()

        finally:
            if self._client_session is not None:
                self._client_session.close()
                self._client_session = None
            self._conns.clear()
            self._acquired.clear()

    @property
    def closed(self):
        return self._closed

    @property
    def client_session(self):
        return self._client_session

    @asyncio.coroutine
    def ws_connect(self, url, *,
                   protocols=(),
                   timeout=10.0,
                   autoclose=True,
                   autoping=True):

        parsed = urlparse(url)
        host = parsed.hostname
        port = parsed.port
        scheme = parsed.scheme
        ssl = scheme in ["https", "wss"]
        key = (host, port, ssl)

        if self._limit is not None:
            while len(self._acquired[key]) >= self._limit:
                fut = asyncio.Future(loop=self._loop)
                self._waiters[key].append(fut)
                yield from fut

        websocket = self._get(key)
        if websocket is None:
            try:
                if self._conn_timeout:
                    websocket = yield from asyncio.wait_for(
                        self._create_connection(
                            url, protocols, timeout, autoclose, autoping, self,
                            key),
                        self._conn_timeout, loop=self._loop)
                else:
                    websocket = yield from self._create_connection(
                        url, protocols, timeout, autoclose, autoping, self,
                        key)

            except asyncio.TimeoutError as exc:
                raise aiohttp.ClientTimeoutError(
                    'Connection timeout to host %s:%s ssl:%s' % key) from exc

        self._acquired[key].append(websocket)
        return websocket

    def _get(self, key):
        conns = self._conns.get(key)
        while conns:
            websocket = conns.pop()
            if websocket.closed:
                websocket = None
            else:
                return websocket
        return None

    @asyncio.coroutine
    def _release(self, key, websocket, *, should_close=False):
        if self._closed:
            return
        acquired = self._acquired[key]
        try:
            acquired.remove(websocket)
        except ValueError:  # pragma: no cover
            pass
        else:
            if self._limit is not None and len(acquired) < self._limit:
                waiters = self._waiters[key]
                while waiters:
                    waiter = waiters.pop(0)
                    if not waiter.done():
                        waiter.set_result(None)
                        break

        if self._force_close:
            should_close = True

        if should_close:
            yield from websocket._close()
        else:
            conns = self._conns.get(key)
            if conns is None:
                conns = self._conns[key] = []
            conns.append(websocket)

    @asyncio.coroutine
    def _create_connection(self, url, protocols, timeout, autoclose, autoping,
                           ws_client_session, key):
        resp = yield from self._client_session.ws_connect(
            url,
            protocols=protocols,
            timeout=timeout,
            autoclose=autoclose,
            autoping=autoping,
            ws_client_session=ws_client_session,
            key=key)
        return resp

    def detach(self):
        self._client_session = None

All of the source/tests can be found here: https://github.com/davebshow/aiowebsocketclient

The main question is: for reusing websocket connection client session should downgrade websocket to normal connection, which is forbidden.
Is I'm wrong?
If downgrading after UPGRADE command is impossible what is intention for keeping websocket connection pool?
Would you provide an use case?

I see your point. I was thinking about keeping them open during concurrent message sending and receiving to a server, while limiting the max number and reusing sockets after they are released, instead of getting new socket each time. Something like:
ws_session = WebSocketClientSession(limit=500)

@asycnio.coroutine
def task(url, msg, session):
    ws = session.ws_connect(url)
    ws.send_str(msg)
    resp = yield from ws.receive()
    return resp

tasks = []

for x in range(1000):
    tasks.append(task('http://<IP_ADDRESS>:33270', str(x), ws_session))

results = yield from asyncio.wait(tasks)

Maybe that doesn't make sense. If not no problem. Thanks!

@davebshow You may useasyncio.Semapthore for that without inviting WebScoketClientSession class.


Decide on the GPA/Education/Position feature

These three features seem to behave oddly and have been temporarily removed from the feature list, yet they all seem promising. Their logic needs to be adjusted, and maybe combined, to see if they could become useful. If they can't, then they should be dropped.

The three features have been combined into a single feature that takes the higher of either the education or work experience.


Error when IP times out

Describe the bug
When scanning ips and URLs, that does not respond before timeout, pyjarm throw an Error log/message. in some cases in stops the remaining scans, but not everytime.
Expected behavior
No error log, but maybe a status: no connection(not responding  and a result of JARM:<PHONE_NUMBER>0000000000000000000000000000000000000000000000000000
Current behavior
Makes the runtime increase alot, while hanging all scans it seems.
Throws and full error log, with a traceback to asyncio.
and gives a result of : JARM: |||,|||,|||,|||,|||,|||,|||,|||,|||,|||.
i see that this is the JARM ERROR for Total failure, but compared to the salesforce codebase this scenario seems to eat up alot more time somehow..
Possible solution
Any fix, or work around will be appreciated
Steps to reproduce
open console/powershell
run:
pyjarm "IP-address that does not respond"
output > see further down.
Screenshots
See console output...
Context
When running a scan either single or from list/file, it throws a Error everytime an ip does not respond, the console out further down is from scanning a single ip.. This behaviour is quite different from the salesforce code base...
Besides the Error message, its takes up alot of time, even with low timeouts..
this becomes a issues/worry, when doing last batch scans.. Especially since its not clear if its a impactfull error or can be ignored..
Any way to help clear my misunderstading, misuse or issue..?
Environment

Version used:
newest version and, python 3.9.x
Win10 and Windows Server 2016

<>
Console Output:
pyjarm <IP_ADDRESS>
Target: <IP_ADDRESS>:443
ERROR:root:Unknown Exception scanning ScanTarget(host='<IP_ADDRESS>', port=443)
Traceback (most recent call last):
File "c:\program files\python\lib\site-packages\jarm\connection\connection.py", line 47, in jarm_data
reader, writer = await Connection.prep_connection(conn_target)
File "c:\program files\python\lib\site-packages\jarm\connection\connection.py", line 25, in prep_connection
reader, writer = await asyncio.open_connection(
File "c:\program files\python\lib\asyncio\streams.py", line 52, in open_connection
transport, _ = await loop.create_connection(
File "c:\program files\python\lib\asyncio\base_events.py", line 1041, in create_connection
sock = await self._connect_sock(
File "c:\program files\python\lib\asyncio\base_events.py", line 955, in _connect_sock
await self.sock_connect(sock, address)
File "c:\program files\python\lib\asyncio\proactor_events.py", line 702, in sock_connect
return await self._proactor.connect(sock, address)
asyncio.exceptions.CancelledError
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "c:\program files\python\lib\asyncio\tasks.py", line 489, in wait_for
fut.result()
asyncio.exceptions.CancelledError
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "c:\program files\python\lib\site-packages\jarm\scanner\scanner.py", line 97, in scan_async
result_list = await Scanner.gather_with_concurrency(concurrency, tasks)
File "c:\program files\python\lib\site-packages\jarm\scanner\scanner.py", line 25, in gather_with_concurrency
return await asyncio.gather((sem_task(task) for task in tasks))
File "c:\program files\python\lib\site-packages\jarm\scanner\scanner.py", line 23, in sem_task
return await task
File "c:\program files\python\lib\site-packages\jarm\connection\connection.py", line 124, in jarm_connect
output = await asyncio.wait_for(fut, timeout=timeout)
File "c:\program files\python\lib\asyncio\tasks.py", line 491, in wait_for
raise exceptions.TimeoutError() from exc
asyncio.exceptions.TimeoutError
c:\program files\python\lib\asyncio\runners.py:47: RuntimeWarning: coroutine 'Connection.jarm_connect' was never awaited
_cancel_all_tasks(loop)
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
JARM: |||,|||,|||,|||,|||,|||,|||,|||,|||,|||
<>
pyjarm www.virkerdenhervirkelig.dk
Target: www.virkerdenhervirkelig.dk:443
ERROR:root:Unknown Exception scanning ScanTarget(host='www.virkerdenhervirkelig.dk', port=443)
Traceback (most recent call last):
File "c:\program files\python\lib\site-packages\jarm\validate\validate.py", line 9, in validate_target
info = socket.getaddrinfo(
File "c:\program files\python\lib\socket.py", line 953, in getaddrinfo
for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno 11001] getaddrinfo failed
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "c:\program files\python\lib\site-packages\jarm\scanner\scanner.py", line 97, in scan_async
result_list = await Scanner.gather_with_concurrency(concurrency, tasks)
File "c:\program files\python\lib\site-packages\jarm\scanner\scanner.py", line 25, in gather_with_concurrency
return await asyncio.gather((sem_task(task) for task in tasks))
File "c:\program files\python\lib\site-packages\jarm\scanner\scanner.py", line 23, in sem_task
return await task
File "c:\program files\python\lib\site-packages\jarm\connection\connection.py", line 117, in jarm_connect
target_family, _, _, _, target_addr = Validate.validate_target(
File "c:\program files\python\lib\site-packages\jarm\validate\validate.py", line 13, in validate_target
raise PyJARMInvalidTarget("Invalid Target Host")
jarm.exceptions.exceptions.PyJARMInvalidTarget: Invalid Target Host
JARM: |||,|||,|||,|||,|||,|||,|||,|||,|||,|||

Hi @lordeamon,
Thanks for filing this issue. We'll look into it and see if we can modify the behavior we have here to be closer to the behavior of the original implementation.

Hi @lordeamon,
Thanks for filing this issue. We'll look into it and see if we can modify the behavior we have here to be closer to the behavior of the original implementation.


fix: Make Plugin Executor Main and init Pod Honour Workflow Controller Log Level

Make Plugin Executor Main and init Pod Honour Workflow Controller Log Level
Signed-off-by: sid8489<EMAIL_ADDRESS>

Fixes
Make Plugin Executor Main and init Pod Honour Workflow Controller  LogLevel Configuration.
Motivation
If one wants to see debug logs of the executor main container there is no way to do so currently. This fixes that
Modifications
Have added loglevel flags to the Container args.
Verification
Builded workflow controller and set workflow controller log level to debug. Below logs shows log level is taking effect

Closing stale PRs

Superseded by #12929


isDraggingOver results are unituative

These should only highlight pink when the dragged item overlaps: https://svelte.dev/repl/e25569ee35c046af8b98c1650a264ba6?version=3.24.1

Work done to enable #9 (removing the code forcing the use of the after placement, and replacing the "midpoint" check with a CoM check) seems to have fixed this.


Add try_clone for TcpStream

From the discussion in #553
I also updated the client/server example to use try_clone instead of Arc, as well as added a small test.

Not sure why this is failing on windows, is anyone able to point me in a direction here?

@atbentley I'm unsure, but it seems this might be an issue in mio:
---- cloned_streams stdout ----
thread 'cloned_streams' panicked at 'cannot register an I/O event source: Os { code: 87, kind: Other, message: "The parameter is incorrect." }', src\libcore\result.rs:1188:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

We're not passing any extra parameters to the underlying OS primitives here; so it feels like it's coming from a lower level. This makes me wonder if going down the Arc route isn't the more reliable option.

I believe this is the same problem as in https://github.com/tokio-rs/tokio/issues/774


[WIP] Fix for hosts using SNI (issue #207)

This is a fix for hosts using SNI as reported in issue #207. I took the liberty of cherry-picking this commit from the work @ganskef has done to investigate and fix the issue.
@ganskef -- do you know if there's anything else that needs to be done before this can be merged?

Hi @jekh, thank you much for integrating it. I was unsure, if it's better to use java.net.InetSocketAddress instead of primitives, but I think it's ok. What do yot think?
It's neccessary to change the interface, since it's a mayor problem. Using SSLEngine in a client without host and port causes no Host Name Verification is done. LittleProxy has accepted a certificate from Google for a wrong host. I hope this is fixed now, but it lacks proper tests.
Please see: http://www.cs.utexas.edu/~shmat/shmat_ccs12.pdf

I was unsure, if it's better to use java.net.InetSocketAddress instead of primitives, but I think it's ok. What do yot think?

Do you mean specifically in MitmManager#serverSslEngine(InetSocketAddress remoteAddress)? One possible problem might occur when connecting directly to an IP address rather than through a hostname. The call to InetSocketAddress.getHostName() in SelfSignedMitmManager will cause a reverse lookup, which is probably not going to give correct results. In Java 7 there is a getHostString() method that will not attempt a reverse lookup, but it does not exist in Java 6 (which is currently LP's minimum Java version).
I agree, we should definitely add some tests for this. Do you have any suggestions for scenarios to test? I'm not familiar enough with SNI to know what we actually need to test here.

Ups, I've missed to send this mail, but now:
Yes, I mean MitmManager#serverSslEngine(InetSocketAddress remoteAddress)
compared with SelfSignedSslEngineSource.newSslEngine(String, int).
Should both methods use InetSocketAddress? These are published
interfaces. It should not be modified so often.
And what's the difference to ProxyToServerConnection.serverHostAndPort?
I would like to add InetSocketAddress to
SelfSignedMitmManager.clientSslEngineFor(SSLSession). I need the host to
create a certificate for the client connection for the given host name.
While offline, I can't use the upstream cert or I have to cache it too.
I've got a simple test case with https://netty.io in LittleProxy-mitm.
Netty supports SNI, so it should be possible to build a test-server with
SNI. There are more ideas from the PDF, like a valid cert with a wrong
CN, to check Host Name Verification. I'm looking at Nettys tests at the
moment.
Today: Host Name Verification is not happens by default. It seems to be
difficult to be secure with Java 6, if not using the built in
HttpsURLConnection.
Am 24.05.2015 um 23:32 schrieb Jason Hoetger:

I was unsure, if it's better to use java.net.InetSocketAddress
instead of primitives, but I think it's ok. What do yot think?

Do you mean specifically in
MitmManager#serverSslEngine(InetSocketAddress remoteAddress)? One
possible problem might occur when connecting directly to an IP address
rather than through a hostname. The call to
InetSocketAddress.getHostName() in SelfSignedMitmManager will cause a
reverse lookup, which is probably not going to give correct results. In
Java 7 there is a getHostString() method that will not attempt a reverse
lookup, but it does not exist in Java 6 (which is currently LP's minimum
Java version).
I agree, we should definitely add some tests for this. Do you have any
suggestions for scenarios to test? I'm not familiar enough with SNI to
know what we actually need to test here.
—
Reply to this email directly or view it on GitHub
https://github.com/adamfisk/LittleProxy/pull/210#issuecomment-105063317.

Yes, I mean MitmManager#serverSslEngine(InetSocketAddress remoteAddress) compared with SelfSignedSslEngineSource.newSslEngine(String, int). Should both methods use InetSocketAddress? These are published interfaces. It should not be modified so often.

The InetSopcketAddress javadoc describes it as:

This class implements an IP Socket Address (IP address + port number) [...] It provides an immutable object used by sockets for binding, connecting, or as returned values.

For certificate impersonation purposes, we don't need an IP socket to connect to, we actually need a literal hostname and port (is that correct?). So it would make sense to actually pass in a hostname and a port, rather than use InetSocketAddress for a purpose it is not designed for. I think a String + int combination, or possibly a guava HostAndPort object, would be better suited in this case. (I'm leaning toward String + int just because of its simplicity.)

And what's the difference to ProxyToServerConnection.serverHostAndPort?

Part of ProxyToServerConnection's job is to resolve the serverHostAndPort into an IP socket address that the proxy can connect to. So we couldn't replace ProxyToServerConnection.serverHostAndPort with an InetSocketAddress (nor would we want to).

I would like to add InetSocketAddress to SelfSignedMitmManager.clientSslEngineFor(SSLSession). I need the host to create a certificate for the client connection for the given host name. While offline, I can't use the upstream cert or I have to cache it too.

I think String + int or HostAndPort are preferable over InetSocketAddress, for the same reasons they would be preferred in MitmManager.

For the certificates issue only the hostname without a port is needed. So use String + int or HostAndPort. It's yours.

I've tested, this fix is ignored with Java 6. It fails with an internal_error :-( . But, it should be possible to give a more concrete exception. For now, we support Java 6 and what's about Android. Has to be tested...

For the certificates issue only the hostname without a port is needed. So use String + int or HostAndPort. It's yours. Edit: I mean SelfSignedMitmManager.clientSslEngineFor(SSLSession, String) without a port.

@ganskef -- you're the SSL expert, so I would defer to you! One thing I noticed: the JDK's SSLContext#createSSLEngine takes both a hostname and a port. I have no idea why it requires the port, though.

I've tested, this fix is ignored with Java 6. It fails with an internal_error :-( . But, it should be possible to give a more concrete exception. For now, we support Java 6 and what's about Android. Has to be tested...

Under Java 6, the change fails with just "internal_error"? Java's SSL error handling information is woefully inadequate. Maybe we should start from the ground up with bouncy castle and design the MitmManager and SslEngineSource interfaces the way we want them, without being tied to the Java SSL implementation.

Hi @jekh, are you comfortable with this. Please replace the InetSocketAddress with String and int. It's better than before.
Are we able to merge this too or is it neccessary to ask anybody. I'm a newbie with GitHub and with the process maintaining LittleProxy.

Hi @jekh I've tried to modify your PR, but it was not was I expected. I've created a new branch named pr/210 in adamfisk. Please help.
Should I create a PR from it to merge and delete this branch? Or should I delete the branch and do it again my repository?

is the problem fixed? i caught the same err

at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:137) [io.netty.netty-all-4.0.33.Final.jar:4.0.33.Final]
	at java.lang.Thread.run(Thread.java:745) [na:1.7.0_65]
Caused by: javax.net.ssl.SSLException: Received fatal alert: internal_error
	at sun.security.ssl.Alerts.getSSLException(Alerts.java:208) ~[na:1.7.0_65]
	at sun.security.ssl.SSLEngineImpl.fatal(SSLEngineImpl.java:1619) ~[na:1.7.0_65]
	at sun.security.ssl.SSLEngineImpl.fatal(SSLEngineImpl.java:1587) ~[na:1.7.0_65]
	at sun.security.ssl.SSLEngineImpl.recvAlert(SSLEngineImpl.java:1756) ~[na:1.7.0_65]
	at sun.security.ssl.SSLEngineImpl.readRecord(SSLEngineImpl.java:1060) ~[na:1.7.0_65]
	at sun.security.ssl.SSLEngineImpl.readNetRecord(SSLEngineImpl.java:884) ~[na:1.7.0_65]
	at sun.security.ssl.SSLEngineImpl.unwrap(SSLEngineImpl.java:758) ~[na:1.7.0_65]
	at javax.net.ssl.SSLEngine.unwrap(SSLEngine.java:624) ~[na:1.7.0_65]

@shijinkui yes, the problem in this PR is been fixed. But your stack trace isn't matching to it.


Support pydantic 1.9

Addresses #82

Codecov Report

Merging #83 (4bed664) into main (47c2498) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   96.53%   96.53%
=======================================
  Files          11       11
  Lines         865      865
=======================================
  Hits          835      835
  Misses         30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47c2498...4bed664. Read the comment docs.


🚀🚧 Prepare 0.7.1 release

This PR is a preparation for the 0.7.1 release, requiring a partial revert of #153
Change summary

🚧 Change version to 0.7.1
🚧 Revert raising of min python and pyglotaran version

Checklist

[ ] ✔ Passing the tests (mandatory for all PR's)

After this PR is merged we need to partially revert it again because of python>3.8 only code and dependencies.


Bug: Function doesn't support blockless if statements

Error: a IfStmt's then must be a BlockStmt

Here is the code that produced it.
if (id && 'resolverContext' in id)
      return table.getItem({
        key: { pk: { S: `ACCOUNT#${id}` }, sk: { S: `ACCOUNT#${id}` } },
      });

Fixed it by adding a block after if.

Function doesn't support table.getItem, only $AWS.DynamoDB.GetItem()
Function is not compiled to the Functionless AST, or it shouldn't be unless something else went wrong higher up

Could you share more of the code?

Error: a IfStmt's then must be a BlockStmt

I believe this is happening, will test with StepFunction


updated python dependencies

added specific version of commonmark
removed awscli (not needed in the image)

:+1:


query default OBM by node to reveal secret

@RackHD/corecommitters @zyoung51 @uppalk1 @keedya @tannoa2

Resolves https://github.com/RackHD/RackHD/issues/304#issuecomment-231249473

:+1: