Removed equals & hashcode from data classes

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes https://github.com/google/android-fhir/pull/691#discussion_r694285443
Description
Remove equals & hashcode from data classes
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one:Code health
Screenshots (if applicable)
Checklist

[x] I have read and acknowledged the Code of conduct
[x] I have read How to Contribute
[x] I have read the Developer's guide
[x] I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
[x] I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
[x] I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
[x] I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
[x] I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

Codecov Report

Merging #753 (22ee097) into master (1aaa887) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #753      +/-   ##
============================================
- Coverage     52.80%   52.70%   -0.11%
+ Complexity      196      195       -1
============================================
  Files            47       47
  Lines           981      981
  Branches        136      136
============================================
- Hits            518      517       -1
  Misses          380      380
- Partials         83       84       +1

Impacted Files
Coverage Δ

.../google/android/fhir/db/impl/dao/LocalChangeDao.kt
66.66% <0.00%> (-2.09%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aaa887...22ee097. Read the comment docs.


Introduce SetFromList for efficient Set result

Hi, I face a similar issue with https://github.com/xetorthio/jedis/issues/907.
This PR is my solution to eliminate overhead of Set creation from List.
The core idea is introducing SetFromList class. For this we can

Eliminate Set creation overhead including both memory and time
Fast set iteration by backed ArrayList

Here is result.
You can see test code HERE
LinkedHashSet creation Timing avg : 86.44 ms
SetFromList creation Timing avg : 0.0 ms

LinkedHashSet iteration Timing avg : 8.0 ms
SetFromList iteration Timing avg : 2.55 ms

I've commented some notes, but LGTM overall.
Thanks for your effort!
Btw, it's trade off between speed of creation / iteration and speed of membership check / deletion.
If we really need to provide O(1) on contains() we should stick HashSet.
But our method signature don't promise it, and IMO users may use return value to iterate more than checking membership, so it would be fine to change it.
@xetorthio @marcosnils
I'd like to hear your opinion. Thanks!

Please note that it doesn't check duplication on constructor. It heavily relies on Redis response, so we should use this to only proper places.

@HeartSaVioR
Thank you for you review.
For that trade off(creation/iteration vs. membership/deletion) you mentioned, that's my assumtions.
I write it down here.

Iteration of Set is dominant than membership check. eg) deserialize byte[] to specific type
Deletion is rare
If membership check is big problem, then user can create HashSet again. Although it looks little complicate, but overall cost is same as before.

Yes. Important thing is "We don't promise that it returns HashSet.". So focusing Set's basic features is enough.
Btw, maybe it would be better to change its name to more descriptive way, like SetFromNonDuplicateList or SetFromUniqueElementsList, or more proper name.
My last concern is improper usage of SetFromList. It never checks origin list, so we should explain its limitation, and maybe comment couldn't be enough.

@HeartSaVioR As naming we can change the class name but as you said someone can still use it improper way. So I think naming is not a big deal but I wanna listen other collaboratos' opinions.

@itugs @HeartSaVioR PR LGTM!.
@HeartSaVioR please give a last review and feel free to merge!.

@marcosnils How about its name? I commented below earlier, and want to know your opinion. Thanks!

Btw, maybe it would be better to change its name to more descriptive way, like SetFromNonDuplicateList or SetFromUniqueElementsList, or more proper name.
My last concern is improper usage of SetFromList. It never checks origin list, so we should explain its limitation, and maybe comment couldn't be enough.

@HeartSaVioR IMHO the class name it's fine. Maybe we can clarify it's limitations through javadoc and make it an InnerClass from BinaryJedis so nobody can use it incorrectly outside Jedis. As long as we control merges then we shouldn't encounter any proble,s
If we make it an inner class then we should see how to test it as it won't be accessible from the tests.

I'm OK to leave as it is when we can't find a way to test inner (private) class with javadoc.
Or we can make class package private and test with same package, but I also think it doesn't look good.
I'll give it a try some more, and merge as it is if all things seems not good.

@HeartSaVioR One quick way to test private inner class is by reflection.
It is impossible to cast instance as SetFromList, by casting to Set testing itself is possible.
(And yes, it is not so pretty.)
Constructor<?> con = Class.forName("redis.clients.jedis.BinaryJedis$SetFromList").getDeclaredConstructor(List.class);
con.setAccessible(true);

Set cut = (Set)con.newInstance(new ArrayList<String>());

As @marcosnils said, the collaboratos can review and control PRs, I don't think this is necessary.

@itugs That class can be used outside of Jedis. I talked with Marcos and he agree we would be better to hide class.

@itugs Maybe I misunderstood you. We're agreed to hide SetFromList, but test matters now.
If you mean test is not necessary, I'm OK.

@HeartSaVioR OK, than I'll hide SetFromList to inside of BinaryJedis and fix my test case.

@HeartSaVioR @marcosnils I move SetFromList to inside of BinaryJedis.

@HeartSaVioR @itugs I like it much better now. LGTM.

LGTM, I'll merge it.
@itugs Thanks for you effort!

Thank you!


MultilingualQuery values() and values_list()

I finally made time to write tests.

this project is dead. closing all issues/PRs. sorry for the notification.


Bug Report: arrow keys dont work on html version

Please check for duplicates, similar issues or closed issues with the same problem, as well performing simple troubleshooting steps (such as deleting the export folder if it's an issue with compiling, reinstalling Kade Engine) before submitting an issue.
If you are playing a downloaded version of the game, what operating system are you using?
Windows (x86), Windows (x86_64), Linux, or macOS? Specify below.
What version of the game are you using? Look in the bottom left corner of the main menu.
Have you identified any steps to reproduce the bug? If so, please describe them below. Use images if possible.
Please describe your issue. Provide extensive detail and images if possible.

no detail?

for slightly more specifics, WASD works but arrow keys are broken in the latest html5 versions.


⚠ Bofrost.de has degraded performance

In 2ecbaea, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1418 ms

Resolved: Bofrost.de performance has improved in a9191cd after 15 minutes.


Add an --enforce-strict-order option

Force a mismatch in the order of the export-ignore entries to render the comparison as invalid.

Available with bc162616127b29c2a601668cc8802626f60d7001.


feat: veANC - Gauge Controller

Summary of changes
This PR creates a new contract to add support for gauge weights. These gauge weights will be associated with supported collaterals, which will be used to control the ANC distribution to borrowers.
The implementation references GaugeController contract of Curve.

 veANC - Gauge Controller Contract


Tetherfi Hotspot failed to start - Broadcast Error

App version: 20231015-1
Android: 12
Device: Moto e6 plus
When I try to start the Tetherfi hotspot, I get this error:

I already tried reseting to the default settings and rebooting my device, but the problem persists. I've also collected the debugging log of when this error happens:
[D] Creating service
[D] Starting runner!
[D] Starting Proxy!

[D] START NEW NETWORK
[D] WiDi Status Changed: Starting
[D] Creating WifiP2PManager Channel
[D] Updated foreground notification: NotifyId(id=42069): ServerNotificationData(status=Starting, clientCount=0, blockCount=0)
[W] No Group owner address in connection intent
[W] Group is ERROR, cannot re-use
[D] Creating new wifi p2p group
[E] Unable to create Wifi Direct Group
java.lang.RuntimeException: Broadcast Error: Error
	at com.pyamsoft.tetherfi.server.widi.WifiDirectNetwork$createGroup$3$listener$1.onFailure(SourceFile:23)
	at android.net.wifi.p2p.WifiP2pManager$Channel$P2pHandler.handleMessage(WifiP2pManager.java:960)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7870)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
 Broadcast Error: Error
[W] Group failed creation, stop network
[D] Stop existing WiFi Group
[W] Failed to stop network: Busy
[D] Close Group failed but continue teardown anyway
[D] Close WiFiP2PManager channel
[D] Reset last info refresh times
[W] Stopping network after Group failed to create
[D] WiDi Status Changed: WiFiDirectError(reason=Error, throwable=java.lang.RuntimeException: Broadcast Error: Error)
[D] WifiP2PManager Channel died! Do nothing :D
[D] Shutdown event received!
[D] Shutdown event received!
[D] Stopping Wi-Fi Direct Network...
[D] Updated foreground notification: NotifyId(id=42069): ServerNotificationData(status=WiFiDirectError(reason=Error, throwable=java.lang.RuntimeException: Broadcast Error: Error), clientCount=0, blockCount=0)
[D] Stop Foreground Service!

Could you help me @pyamsoft ?

Thanks for the logs, very helpful!
Unfortunately it seems like the wifi p2p manager is rejecting your attempt.
https://developer.android.com/reference/android/net/wifi/p2p/WifiP2pManager#ERROR
Error code "Error" could unfortunately be just about anything.
Is your device able to use WiFi Direct for other functions?
This may be the API wake up call to move to starting a Local Hotspot API instead in the codebase. I will read up about how that API works and may be able to provide Local Hotspot as an alternative connection Broadcast

Do the recent changes in version 38 resolve your problem? Does rebooting the device hosting the hotspot change anything?

Do the recent changes in version 38 resolve your problem? Does rebooting the device hosting the hotspot change anything?

Hey! I've tested v38 now but the problem persists. Rebooting the host device does not seem to have any effect.
I'll try to manually test WiFi Direct functions next week

Unfortunate to hear. If Wifi direct is sending an internal error like your situation here, then either something else is using it (but normally that would report as BUSY instead of ERROR) or your device may just be incompatible :(
In your system settings, under Wifi, do you have a Wifi Direct option? Maybe in the overflow menu?

Hey, sorry for the late answer, it's been some very busy months.

I do have that button in my Android settings. I've tested Wi-Fi direct, and I can connect to another Wi-Fi direct android phone, and also connect to a regular WiFi network at the same time.

Hi, thanks for getting back. I know life can be busy, it happens :)
Well unfortunately, I am not sure where else to go from here.
From the code side, all I am able to do as a Dev is say "hey WiFi direct, turn on"
And WiFi direct can either say "yes, error, or busy"
In your case its just saying "busy" but nothing exists to convey to TetherFi why its busy or what you can do to make it not busy.
I'd look through other apps you have running just in case something else is expecting to use WiFi direct. Common things I've seen are things like Android Auto and some printer software or IoT devices like assistants or cameras.
Sorry to say, I don't know what else I can do here :(

I ran logcat while I tried to start the TetherFi hotspot, and I found this:
04-07 21:34:47.264  1684  2843 E SupplicantP2pIfaceHal: Can't call groupAdd_1_2: ISupplicantP2pIface is null
04-07 21:34:47.270  9086  9086 E (WifiDirectNetwork.kt:366): Unable to create Wifi Direct Group
04-07 21:34:47.270  9086  9086 E (WifiDirectNetwork.kt:366): java.lang.RuntimeException: Broadcast Error: Error

I went down the rabbit hole and I can only conclude that this issue is caused by LineageOS. I'm on LineageOS 19.1, Android 12.
Is there an alternative to WifiP2pManager? Earlier you mentioned:

This may be the API wake up call to move to starting a Local Hotspot API instead in the codebase. I will read up about how that API works and may be able to provide Local Hotspot as an alternative connection Broadcast

Hey nice job!
I really don't know where to go from here, you would probably have to report to lineage, since I have no control over the virt iface level of WiFi direct.
I've investigated Wifip2p local hotspot APIs since our very initial discussion, but the local hotspot is not a full replacement for WiFi p2p, so it wouldn't be an easy switch - I'm not even fully sure if it would be viable.
I would take this over to lineage and see what they say. Thanks for all your very cool work!


Get-Keypairpem is failing on windows servers

Does bouncy Castle not work on Windows Servers? I get failures after Initialize bouncycastle is run

Hello,
Yes it sure does, this is how the signing of the requests to the Chef
server is done.
That is odd. Can I ask how you installed poshchef?
Can you post an image of the failure?
Russell
On 22 Jan 2016 01:39, "beaudryj"<EMAIL_ADDRESS>wrote:

Does bouncy Castle not work on Windows Servers? I get failures after
Initialize bouncycastle is run
—
Reply to this email directly or view it on GitHub
https://github.com/POSHChef/POSHChef/issues/57.

I figured it out, it had to do with my line endings on the pemfile :/

OK I am pleased you found it.
I will have a look and make it so that it is not as sensitive to the line
endings or at least give a warning.
Russell
On 22 January 2016 at 15:19, beaudryj<EMAIL_ADDRESS>wrote:

I figured it out, it had to do with my line endings on the pemfile :/
—
Reply to this email directly or view it on GitHub
https://github.com/POSHChef/POSHChef/issues/57#issuecomment-173947810.


Lambda: ecs-lifecycle-hook-terminate.py Raising exception

I have set up a cloud watch event rule with a rule just with lambda responsible for ec2 terminating lifecycle but I am getting below error.
 START RequestId: c388ff12-950f-49dc-a4e0-1d9b0bdf7417 Version: $LATEST
Recieved event
{
    "version": "0",
    "id": "cc9dc08f-16bd-8f36-ad8f-410a8a74706f",
    "detail-type": "EC2 Instance-terminate Lifecycle Action",
    "source": "aws.autoscaling",
    "account": "account-id",
    "time": "2019-04-30T18:25:56Z",
    "region": "us-east-1",
    "resources": [
        "arn:aws:autoscaling:us-east-1:account-id:autoScalingGroup:5532977d-22a7-4b06-b33a-3b0e0e29ba94:autoScalingGroupName/EC2ContainerService-testing-EcsInstanceAsg-E1YSQ3BF4NGK"
    ],
    "detail": {
        "LifecycleActionToken": "96876f0e-aa5b-48f1-92e4-4305b739792a",
        "AutoScalingGroupName": "EC2ContainerService-testing-EcsInstanceAsg-E1YSQ3BF4NGK",
        "LifecycleHookName": "clusterDrain",
        "EC2InstanceId": "i-04f772f7d7cba97ed",
        "LifecycleTransition": "autoscaling:EC2_INSTANCE_TERMINATING"
    }
}

Recieved Lifecycle Hook message
{
    "LifecycleActionToken": "96876f0e-aa5b-48f1-92e4-4305b739792a",
    "AutoScalingGroupName": "EC2ContainerService-testing-EcsInstanceAsg-E1YSQ3BF4NGK",
    "LifecycleHookName": "clusterDrain",
    "EC2InstanceId": "i-04f772f7d7cba97ed",
    "LifecycleTransition": "autoscaling:EC2_INSTANCE_TERMINATING"
}

Determining our ECS Cluster name . . .
Exception: cannot use a string pattern on a bytes-like object
END RequestId: c388ff12-950f-49dc-a4e0-1d9b0bdf7417

I have not followed whole architecture, as I only wanted to use the lambda with the termination lifecycle of the ec2 instance.
Is it a known issue?

Hi @ethicalmohit, thank you reporting this issue!
In order for the lambda to work properly, the EC2 instance needs to be  part of ECS cluster. This is derived from the EC2 user-data which contains a command to inject the cluster name into ECS agent config files. Lambda is using the following regular expression search pattern: "ECS_CLUSTER\s?=\s?(.*?)\s" against user data script to figure it out.
On failure lambda raises an exception which means this instance isn't a ECS cluster member so ASG can proceed with termination.
In case you'd like to test this solution end-to-end, please follow steps described here:
https://aws.amazon.com/blogs/compute/automatically-update-instances-in-an-amazon-ecs-cluster-using-the-ami-id-parameter/

The instance is obviously the part of the ECS cluster.
It works after changing the code as below.
 clustername = re.search("ECS_CLUSTER\s?=\s?(.*?)\s", str(userdata))

@ethicalmohit thank you for pointing it out and providing the solution. The change has been merged into master branch.


"list_units" not working correctely

So i was trying to get a list of all units as in the doc's, but it doesn't work because returns a empty vector
fn test_status() {     let units = systemctl::list_units(None, None); // all units     let is_ok = units.is_ok();     println!("{}", is_ok);     let new_units = units.unwrap();     println!("{}", new_units.len()); }
output
true 0
Test in the terminal
 systemctl list-units | wc -l                199
I'm i doing something wrong or is something broken

after some digging I found out that  "list_units" isn't the only one that isn't working correctly, the function responsible to pack everything has a lot of issues, some of the examples i found are :

session-2.scope it fails because of the number in the name and

systemd-fsck-root.service this one i don't understand why but I'm going to leave this here

○ systemd-fsck-root.service - File System Check on Root Device
     Loaded: loaded (/usr/lib/systemd/system/systemd-fsck-root.service; enabled-runtime; preset: disabled)
     Active: inactive (dead)
  Condition: start condition failed at Sat 2023-02-25 17:29:32 WET; 57min ago
             └─ ConditionPathIsReadWrite=!/ was not met
       Docs: man:systemd-fsck-root.service(8) ```

Also i will make a commit trying to fix the initial problem

#11

Part of the problem is solved for example systemd-fsck-root.service is solved, but all units with number will result in errors, if someone can find a fix for this problem it would be appreciated

@hubblexplorer the newest commit on main should fix this. Can you please recheck? Here https://github.com/gwbres/systemctl/actions/runs/5589518960/jobs/10217918506#step:8:1832 at least is a unit with a number.


Username is already taken message in sing up menu

Username is already taken message in sing up menu

fixed by linking the database in the testing laptop of kabo , (false call)


Refactored code and added ability to find missing translations

I came up with a solution to issue #2 by taking these actions:

Redefined analyzeFiles method to return a Map, so that we can later display in which file(s) a missing key had appeared
Renamed findUnusedTranslations to findDifferenceInTranslations for clarity
Refactored findDifferenceInTranslations method so that we can use it to find both unused and missing translations

I tested the updated code on a production app that has ~2900 translation keys (one locale). It found 816 unused translations 😞and 16 missing translations 🙂.
Resolves #2

sorry, didn't have time to try this out yet 😞

thanks! and sorry again for the long wait... 😞


wrap ruins the ability to get the function name

function foo(a) { return a }
R.wrap(foo, (foo, b) => console.log(foo(b))).name // "n"

I realize why this happens, but it would be great if it didn't do this.

As far as I'm aware there's no solution which satisfies our requirements:

works in all supported environments; and
doesn't use eval or new Function(…).

I personally don't have a serious objection to new Function(…), but the general JS community is averse to anything that involves any form of eval, for mostly good reasons.  This is the only form I find occasionally unobjectionable.
I would love to hear of a solution to this that doesn't run afoul of @davidchambers' two rules.  Any ideas?

For what it's worth, I totally get that this is a hard problem. I just find myself having a list of wrapped functions and having no way to really be introspective on that list.

We might be able to set the name on the functions that get curried, etc with something like:
function _setFnName(fn, name) {
  Object.defineProperty(fn, 'name', { configurable: true, value: name });
  return fn;
}

Which would work as a nice-to-have in environments that support it, but we would need to be sure that nothing breaks in the other environments. In the environments I have easy access to, it appears to work in Node, Firefox and Chrome.

That's an ES6 feature that looks as though it doesn't work in IE (not tested.)
It certainly would be nice to have.

Just tried this in both IE8 and IE9 and while name isn't set automatically it does appear to be happy having it set explicitly.
function foo(x) { return x; }
foo.name; // undefined
Object.defineProperty(foo, 'name', { configurable: true, value: 'id' });
foo.name; // "id"

I've thrown a proof of concept up onto a branch if people want to have a poke at it.
https://github.com/ramda/ramda/compare/master...scott-christopher:function-names
If we were to go down this path, I suspect we'd probably take a hit in performance.

Performance could be improved if an extra name parameter were added to the internal curry functions rather than reading and setting the function name during each pass, however I didn't really feel like updating every single function in the process for just a proof of concept :)

Catching up on a bunch of old stuff.  This is very nice!  MDN told me that it wouldn't work for IE, but I hadn't tried to test.
I would love to revisit some of the metadata ideas that @megawac has promoted here.  This performance hit would not be an issue if much of our currying/arity juggling, delegation, naming was all handled through metadata.

I haven't had time to really look into this xhangeset but note that using eval/Function may cause issues with some content security policies

Yes, that's always been a concern with anything that uses new Function().  I have some thoughts for how to code without that, and I might just have the time to try them out next week.


Feature request: function to call process.extract with ProcessPoolExecutor (hidden API detail) and multiple names matched to fixed candidates, scorer, limit and chunksize(processpoolexecutor argument)

It seems it would be handy. A annoying problem with this is that sometimes you want to cancel\avoid a name with app specific requirements and you have to rebuild the list (which if you're using a API like this is likely huge), so a function that filtered in place and a return that indicated if a name was filtered before running process.extract would be nice.
Im unsure if this is possible with named arguments in the process.extract function instead of positional arguments, because of the way executor.map works by repeating iterables for all function arguments...

Never mind, figured how to do this, I think.


estimateFees failed with code 400

Either if I call the method from LCDClient.tx or if it gets called from other functions (as createAndSignTx()) this function fails with code 400.
The call to /cosmos/tx/v1beta1/simulate is failing somehow.

did you tried to bombay? public nodes for bombay-12 testnet are in re-syncing after software upgrade.
retry after /blocks/latest returns  block.eight larger than 7000004

Will it be available after block 7000004?

No I was trying in main net connected to https://lcd.terra.dev on columbus-5.

We have the exact same issue on our side, any help would be appreciated.

what kind of messages are failed? i've simulate some kind of messages with terra.js and it works.

The following code that was working on columbus-5 before the soft fork now no longer works, not sure if its only related to our account.
The error we are seeing is:
message: 'account sequence mismatch, expected 266, got 265: incorrect account sequence: invalid request'
The code triggering the error is:
const account = lcdClient.auth.accountInfo(sourceAddress);
const signerDataArray = [{
  publicKey: account.getPublicKey(),
  sequenceNumber: account.getSequenceNumber()
}];

const feeResult = await lcdClient.tx.estimateFee(signerDataArray, options);

I don't understand why its getting an incorrect sequence number when its fetching it right from the on-chain...

@corymsmith did you tried multiple times within a block? you have to increase sequence manually.
and getSequenceNumber() don't fetch from the chain. it returns pre-fetched sequence. actual fetching is done by auth.accountInfo(). softfork is not relevant.

No, this fails with a single call. auth.accountInfo is what I meant by fetching from chain.
After some more digging, this fails when run against our own node (that is in sync) with the error message: account sequence mismatch, expected 266, got 265: incorrect account sequence: invalid request but against the public lcd.terra.dev it works with sequence number 265.
Our node is in sync so I don't see how that account state can be out of sync. We recently rebooted from a snapshot after the soft fork and thats when this all started.

Could you post the wallet address?

The address is terra195kvgyq0ut99a655jpcgdge220afxmgfscnml6
On Sun, Dec 19, 2021 at 6:39 PM Paul Kim @.***> wrote:

Could you post the wallet address?
—
Reply to this email directly, view it on GitHub
https://github.com/terra-money/terra.js/issues/188#issuecomment-997520102,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAABZEYZAJ2ITLBNZ4DHPXLUR2CNDANCNFSM5KGCIK2A
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Thanks,
Cory Smith
http://ca.linkedin.com/in/corysmith/
http:/twitter.com/smixx http://twitter.com/smixx

Also we are running the following on our node https://github.com/terra-money/core/releases/download/v0.5.13/terra_0.5.13_Linux_x86_64.tar.gz

@corymsmith could you please create a separate issue for your problem which is not related to this issue? Thanks.

@tuloski Created a new issue here: https://github.com/terra-money/terra.js/issues/189

@tuloski does it still happen?

@Vritra4 a few days ago yes. Not trying anymore and using a fixed fee for now.


doc(Topology.Category.TopCat.Basic): fix links

The trivial link was linking to Init.Core and topology.category.TopCat.adjunctions is from Lean 3 and not valid anymore in Lean 4.

Welcome to mathlib, and thanks for your contribution!
I have marked your PR with awaiting-review (otherwise, it can easily get overlooked). (This trick is also documented in the contribution guidelines; if you haven't already, you may want to take a look.)

Thanks!
bors merge


Build chromium OS with local browser

I noticed that in file overlay-rpi3/make.conf the way of building browser is set to local.
CHROME_ORIGIN=LOCAL_SOURCE.
Then I cloned a copy of chrome source code and put it in, and sync the code by command
git clone https://chromium.googlesource.com/chromium/src.git
sync_chrome --tag=77.0.3865.126 --reset  $brower_path

By restarting build_parckage, cros_sdk found the browser souce code, but reported an error like this:
=== Start output for job chromeos-chrome-77.0.3865.126_rc-r1 (0m3.0s) ===
chromeos-chrome-77.0.3865.126_rc-r1: >>> Emerging (1 of 1) chromeos-base/chromeos-chrome-77.0.3865.126_rc-r1::chipset-bcm2837 for /build/rpi3/
chromeos-chrome-77.0.3865.126_rc-r1:  * Running stacked hooks for pre_pkg_setup
chromeos-chrome-77.0.3865.126_rc-r1:  *    sysroot_build_bin_dir ...                                          [ ok ]
chromeos-chrome-77.0.3865.126_rc-r1:  * Running stacked hooks for post_pkg_setup
chromeos-chrome-77.0.3865.126_rc-r1:  *    python_eclass_hack ...                                             [ ok ]
chromeos-chrome-77.0.3865.126_rc-r1:  * Running stacked hooks for pre_src_unpack
chromeos-chrome-77.0.3865.126_rc-r1:  *    python_multilib_setup ...                                          [ ok ]
chromeos-chrome-77.0.3865.126_rc-r1: >>> Unpacking source...
chromeos-chrome-77.0.3865.126_rc-r1:
chromeos-chrome-77.0.3865.126_rc-r1:  * If you want to develop or hack on the browser itself, you should follow the
chromeos-chrome-77.0.3865.126_rc-r1:  * simple chrome workflow instead of using emerge:
chromeos-chrome-77.0.3865.126_rc-r1:  * https://chromium.googlesource.com/chromiumos/docs/+/master/simple_chrome_workflow.md
chromeos-chrome-77.0.3865.126_rc-r1:
chromeos-chrome-77.0.3865.126_rc-r1:  * CHROME_ORIGIN VALUE is LOCAL_SOURCE
chromeos-chrome-77.0.3865.126_rc-r1: Building Chromium with additional media codecs and containers.
chromeos-chrome-77.0.3865.126_rc-r1:  * Using GN from /home/hao/work/chrome_root/src/buildtools/linux64/gn
chromeos-chrome-77.0.3865.126_rc-r1: >>> Source unpacked in /build/rpi3/tmp/portage/chromeos-base/chromeos-chrome-77.0.3865.126_rc-r1/work
chromeos-chrome-77.0.3865.126_rc-r1:  * Running stacked hooks for post_src_unpack
chromeos-chrome-77.0.3865.126_rc-r1:  *    asan_init ...                                                      [ ok ]
chromeos-chrome-77.0.3865.126_rc-r1:  * Running stacked hooks for pre_src_prepare
chromeos-chrome-77.0.3865.126_rc-r1:  *    enable_cxx_exceptions ...                                          [ ok ]
chromeos-chrome-77.0.3865.126_rc-r1: >>> Preparing source in /build/rpi3/tmp/portage/chromeos-base/chromeos-chrome-77.0.3865.126_rc-r1/work/chromeos-chrome-77.0.3865.126_rc ...
chromeos-chrome-77.0.3865.126_rc-r1:  * /home/hao/work/chrome_root should be set here properly
chromeos-chrome-77.0.3865.126_rc-r1:  * Applying widevine_gni.patch ...                                       [ ok ]
chromeos-chrome-77.0.3865.126_rc-r1: >>> Source prepared.
chromeos-chrome-77.0.3865.126_rc-r1: >>> Configuring source in /build/rpi3/tmp/portage/chromeos-base/chromeos-chrome-77.0.3865.126_rc-r1/work/chromeos-chrome-77.0.3865.126_rc ...
chromeos-chrome-77.0.3865.126_rc-r1:  * Building with the compiler settings:
chromeos-chrome-77.0.3865.126_rc-r1:  *   CFLAGS = -pipe -fno-split-dwarf-inlining -faddrsig -Wno-unknown-warning-option
chromeos-chrome-77.0.3865.126_rc-r1:  *   CXXFLAGS = -pipe -fno-split-dwarf-inlining -D__google_stl_debug_vector=1 -faddrsig -Wno-unknown-warning-option -stdlib=libc++
chromeos-chrome-77.0.3865.126_rc-r1:  *   CPPFLAGS =
chromeos-chrome-77.0.3865.126_rc-r1:  *   LDFLAGS = -Wl,-O2 -Wl,--as-needed -stdlib=libc++
chromeos-chrome-77.0.3865.126_rc-r1: /mnt/host/depot_tools/gclient runhooks --force
chromeos-chrome-77.0.3865.126_rc-r1: Error: client not configured; see 'gclient config'
chromeos-chrome-77.0.3865.126_rc-r1:  * ERROR: chromeos-base/chromeos-chrome-77.0.3865.126_rc-r1::chipset-bcm2837 failed (configure phase):
chromeos-chrome-77.0.3865.126_rc-r1:  *   (no error message)
chromeos-chrome-77.0.3865.126_rc-r1:  *
chromeos-chrome-77.0.3865.126_rc-r1:  * Call stack:
chromeos-chrome-77.0.3865.126_rc-r1:  *     ebuild.sh, line 124:  Called src_configure
chromeos-chrome-77.0.3865.126_rc-r1:  *   environment, line 4503:  Called die
chromeos-chrome-77.0.3865.126_rc-r1:  * The specific snippet of code:
chromeos-chrome-77.0.3865.126_rc-r1:  *           CFLAGS="${CFLAGS} ${EBUILD_CFLAGS[*]}" CXXFLAGS="${CXXFLAGS} ${EBUILD_CXXFLAGS[*]}" LDFLAGS="${LDFLAGS} ${EBUILD_LDFLAGS[*]}" "${cmd[@]}" || die;
chromeos-chrome-77.0.3865.126_rc-r1:  *
chromeos-chrome-77.0.3865.126_rc-r1:  * If you need support, post the output of `emerge --info '=chromeos-base/chromeos-chrome-77.0.3865.126_rc-r1::chipset-bcm2837'`,
chromeos-chrome-77.0.3865.126_rc-r1:  * the complete build log and the output of `emerge -pqv '=chromeos-base/chromeos-chrome-77.0.3865.126_rc-r1::chipset-bcm2837'`.
chromeos-chrome-77.0.3865.126_rc-r1:  * The complete build log is located at '/build/rpi3/tmp/portage/logs/chromeos-base:chromeos-chrome-77.0.3865.126_rc-r1:20191209-015843.log'.
chromeos-chrome-77.0.3865.126_rc-r1:  * For convenience, a symlink to the build log is located at '/build/rpi3/tmp/portage/chromeos-base/chromeos-chrome-77.0.3865.126_rc-r1/temp/build.log'.
chromeos-chrome-77.0.3865.126_rc-r1:  * The ebuild environment file is located at '/build/rpi3/tmp/portage/chromeos-base/chromeos-chrome-77.0.3865.126_rc-r1/temp/environment'.
chromeos-chrome-77.0.3865.126_rc-r1:  * Working directory: '/build/rpi3/tmp/portage/chromeos-base/chromeos-chrome-77.0.3865.126_rc-r1/work/chromeos-chrome-77.0.3865.126_rc'
chromeos-chrome-77.0.3865.126_rc-r1:  * S: '/build/rpi3/tmp/portage/chromeos-base/chromeos-chrome-77.0.3865.126_rc-r1/work/chromeos-chrome-77.0.3865.126_rc'
chromeos-chrome-77.0.3865.126_rc-r1: >>> Failed to emerge chromeos-base/chromeos-chrome-77.0.3865.126_rc-r1 for /build/rpi3/, Log file:
chromeos-chrome-77.0.3865.126_rc-r1: >>>  '/build/rpi3/tmp/portage/logs/chromeos-base:chromeos-chrome-77.0.3865.126_rc-r1:20191209-015843.log'

Do I need to set any other configuration to build the OS together with browser? It's not a problem for me whether CHROME_ORIGIN is LOCAL_SOURCE or from server. I simply want to build a image by myself. Thanks!

@fydeos-alpha Could you help, sir?

I encount the same problem.

Remove CHROME_ORIGIN=LOCAL_SOURCE from make.conf will make it easier. We can't build Chrome from the source code at google server for the "GFW" issue.

Removed CHROME_ORIGIN=LOCAL_SOURCE. It started to download source code from google server. But it did start to build without complicated configuation and syncing.

@killmind what's your meaning of "build without complicated configuration and syncing"?

When you clone the repository of chrome brower locally, it seems you would need to run sync_chrome manually to that local copy. I'm still investigating it.

I think the guide should be integral with everything inside to avoid confusion for beginners.
The raspberry_pi overy uses local source, which needs download chromium code first, and mount with cros_sdk.
To get chromium code
fetch --nohooks chromium

If it is broken, run this to continue or sync later.
gclient sync

There's problem to get WebRTC branch, and you may have to add this into ~/.gitconfig
[remote "origin"]
        fetch = +refs/branch-heads/*:refs/branch-heads/*

To sync with specific tag to match with raspbarry_pi overlay like r77, you need do this in chromium code, after first code syncing.
cd src
git checkout 77.0.3865.126
cd ..
gclient sync

After syncing, adding this line to end of .gclient in parent of src directory
target_os = ['chromeos']

Then you run cros_sdk to mount local chromium source code
cros_sdk --chrome-root ${chromium_path}

In cros_sdk environment, you could see chromium code mounted at /home/${your_account}/chrome_root directory. Then you can run build_packages or use "emerge-${BOARD} chromeos-base/chromeos-chrome" to build chromium.


Cmake no longer needs Find deps config files

Tested on Windows (with Vcpkg) and Linux (without Vcpkg).
There was also added a missing include to compile on linux.
WARNING: Now the cmake command only needs to know the Vcpkg installation
dir in the var VCPKG_ROOT.

PS C:\Users\Chris\Downloads\DiscordCoreAPI-cmake-find-deps> cmake -S . --preset=Windows-Release -DVCPKG_ROOT="C:/vcpkg"
Preset CMake variables:

  CMAKE_BUILD_TYPE="Release"

-- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.22000.
CMake Error at Library/CMakeLists.txt:53 (find_package):
  By not providing "Findnlohmann_json.cmake" in CMAKE_MODULE_PATH this
  project has asked CMake to find a package configuration file provided by
  "nlohmann_json", but CMake did not find one.

  Could not find a package configuration file provided by "nlohmann_json"
  with any of the following names:

    nlohmann_jsonConfig.cmake
    nlohmann_json-config.cmake

  Add the installation prefix of "nlohmann_json" to CMAKE_PREFIX_PATH or set
  "nlohmann_json_DIR" to a directory containing one of the above files.  If
  "nlohmann_json" provides a separate development package or SDK, be sure it
  has been installed.

-- Configuring incomplete, errors occurred!
See also "C:/Users/Chris/Downloads/DiscordCoreAPI-cmake-find-deps/Build/Release/CMakeFiles/CMakeOutput.log".
See also "C:/Users/Chris/Downloads/DiscordCoreAPI-cmake-find-deps/Build/Release/CMakeFiles/CMakeError.log".
PS C:\Users\Chris\Downloads\DiscordCoreAPI-cmake-find-deps>```


mscolab manage user invite problem

When a creator invites someone using manage users there is sometimes a traceback created

Fatal error in MSS 7.0.4. on Linux-5.4.0-125-generic-x86_64-with-glibc2.27
Python 3.10.4 | packaged by conda-forge | (main, Mar 24 2022, 17:38:57) [GCC 10.3.0]

Please report bugs in MSS to https://github.com/Open-MSS/MSS

Information about the fatal error:

Traceback (most recent call last):
  File "/home/reimar/miniconda3/envs/mssdev/lib/python3.10/site-packages/requests/models.py", line 971, in json
    return complexjson.loads(self.text, **kwargs)
  File "/home/reimar/miniconda3/envs/mssdev/lib/python3.10/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/home/reimar/miniconda3/envs/mssdev/lib/python3.10/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/home/reimar/miniconda3/envs/mssdev/lib/python3.10/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/reimar/PycharmProjects/MSS/mslib/msui/mscolab_admin_window.py", line 256, in add_selected_users
    res = res.json()
  File "/home/reimar/miniconda3/envs/mssdev/lib/python3.10/site-packages/requests/models.py", line 975, in json
    raise RequestsJSONDecodeError(e.msg, e.doc, e.pos)
requests.exceptions.JSONDecodeError: Expecting value: line 1 column 1 (char 0)


Module 1.1 Assignment

Given what you have learned about Git, why would you want to use Git in your classroom?

👋 Hi @jyounggo you are missing your answer for the question above. Please post it here in this thread.

Version control such Git is required for students to learn how to save and manage their code.
It is essential especially for team projects as well.

👋 Hi @jyounggo you are missing your answer for the question above. Please post it here in this thread.

@arelia Can you check again?


Remove scipy from Windows env

Closes #3 (if tests pass)

Fails in the same way as https://github.com/climlab/climlab-rrtmg/pull/5 without scipy in the env.
So I'll close this and we'll keep scipy for now.


Memory Leak

I had glimpse on in my app and noticed that while it was on in web.config (not active in the browser) causes a huge memory leak in IE.
normally my app uses around 50MB. turning on glimpse and it jumps up to 150 in around 500 requests and memory usage just goes up.
I tried looking at the app using ANTS memory profile and it shows as unmanaged memory

I'm seeing exactly the same problem. Unmanaged memory leaks like crazy with Glimpse enabled on both IISExpress and IIS. The managed heap is stable. The app ultimately throws an OutOfMemoryException and dies.

I think I might know what the issue is, just wondering if you can disable the View tab and see if the same thing happens? http://getglimpse.com/Help/Configuration "Blacklist for plugins". I suspect its a problem with the serialization of the the View Model. If this is the case, blacklist the plugin will show it up.

I've opened up a new thread that might be related to the IIS memory leaks issue
https://github.com/Glimpse/Glimpse/issues/126


[code-infra] Break package dependency cycles

This PR removes dependency cycles (as reported by Lerna and pnpm on another branch) between workspace packages.
I moved tests that verify integration between packages into test/integration.
This change allows us to unlock Lerna version (pinned in #40029) and solves an issue with Lerna on the pnpm branch (the version command was failing because of the cycles).

his surprises me a bit. Intuitively I'd expect it to be the other way around. @mui/material depending on @mui/system.

That's styles, not system. Anyway, it turns out neither depends in production on the other (styles is a legacy package), so I'm moving it from back to devDependencies.

That's styles, not system.

oops, right, that's what I meant 🙂


Seller Details not provided

I testet the order process about hundred times and I can not find out why sometimes the seller details are not provided in Amazon Seller Central - Payment Details.
What could be the reason why sometimes the seller details are empty (not provided)? I am using the same code without changes.
Is this a browser cache problem? If so how to solve it?
I also found out that after the buyer loggs in and the shipping addresses and the payments methods are shown (for selection) after 3 seconds the payments methods are loaded again (you can see flash it).
I have 4 different test accounts for testing payments. I login with first acount and test the payment, then login with next account and test payment. Is this a probem?
This also happens in the demo example SampleCartDemo - OneTimePayments.
Is this reloading the reason why sometimes the seller details are not provided in seller central?
What else could be a reason why seller details are not provided (the sourcecode is always the same):
The session variables? The access token? What else? How to solve it?
Thank you.

I'll need to investigate this further to get to the bottom of it for you.
Please submit a support case using the following link:
https://sellercentral.amazon.com/gp/contact-us/contact-amazon-form.html
Be sure to select "Amazon Pay" and then "Amazon Pay Issues" to ensure your question is routed to the correct support queue.

Maybe the problem is located here:
   <script type="text/javascript">
        new OffAmazonPayments.Widgets.AddressBook({
            sellerId: "YOUR_MERCHANT_ID",
            onOrderReferenceCreate: function (orderReference) {
                /* make a call to the back-end that will set order reference details
                 * and get order reference details. This will set the order total
                 * to 19.95 and return order reference details.
                 *
                 * Get the AddressConsentToken to be sent to the API call
                 */
               var access_token = "";
                $.post("Apicalls/GetDetails.php", {
                    orderReferenceId: orderReference.getAmazonOrderReferenceId(),
                    addressConsentToken: access_token,
                }).done(function (data) {
                   $("#get_details_response").html(data);
                });
            },
            onAddressSelect: function (orderReference) {
            },
            design: {
                designMode: 'responsive'
            },
            onError: function (error) {
                // your error handling code
            }
        }).bind("addressBookWidgetDiv");
        new OffAmazonPayments.Widgets.Wallet({
            sellerId: "YOUR_MERCHANT_ID",
            onPaymentSelect: function (orderReference) {
            },
            design: {
                designMode: 'responsive'
            },
            onError: function (error) {
                // your error handling code
            }
        }).bind("walletWidgetDiv");
    </script>

I think the wallet widget is called BEFORE the results of $.post("Apicalls/GetDetails.php" are here.
This does not occur on every payment, but randomly again and again.
When I remove the calls for the addressbook widgets and move the call for $.post("Apicalls/GetDetails.php" into the wallet widget object call ( to omitt the addressbook widget for digial goods), then the problem (seller details not privided) disappears.
So the problem must be located in the code above!
I think we need subsequent calls for "getdetails" and "addressbook widget", but here they seem to be not subsequent (asyonchronous javscript result on..events).
If you understand what I mean you can test it, reproduce it and solve it.

This issue was corrected in the update made to the SetPaymentDetails.php file back in August 2017.  The original version of the file did not wrap the AddressBook widget inside a window.onAmazonPaymentsReady callback.  That was likely leading to the issues you were observing relating to the load order.  The current version should work properly.


Clear deprecation warnings in Julia 0.7

There are still warnings like
WARNING: abs{T <: Number}(x::AbstractArray{T}) is deprecated, use abs.(x) instead.

but that would require dropping support for Julia 0.4 in order to clear them.  Anyway, abs(array) is used only in tests, the source code shouldn't have deprecations.
Also warnings in the tests have been cleared, using @compat.

I think this PR is quite straightforward and unquestionable, so absent objections I'll merge it tomorrow.


Scene with texture resource corrupts when the autoload preload it

Godot version
from 4.1.dev3 to 4.2.dev
System information
Godot v4.1.dev3 - Windows 10.0.19044 - GLES3 (Compatibility) - AMD Radeon(TM) Vega 8 Graphics (Advanced Micro Devices, Inc.; 31.0.14051.5006) - AMD Ryzen 5 2500U with Radeon Vega Mobile Gfx (8 Threads)
Issue description
autoload game.gd
extends Node
var node = preload("res://scene/node.tscn")

node.tscn
One child node sprite with godot icon.
When the project doesn't have a .godot folder (e.g. cloning from github)
Opening node.tscn brings up a popup window stating that the scene is corrupt or invalid.
The following error can only be seen on the console(4.1.stable).
ERROR: Unable to open file: res://.godot/imported/icon.svg-218a8f2b3041327d8a5756f3a245f83b.ctex.
   at: (scene/resources/texture.cpp:847)
ERROR: Failed loading resource: res://.godot/imported/icon.svg-218a8f2b3041327d8a5756f3a245f83b.ctex. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:273)
ERROR: Failed loading resource: res://icon.svg. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:273)
ERROR: res://scene/node.tscn:9 - Parse Error:
   at: _parse_node_tag (scene/resources/resource_format_text.cpp:283)
ERROR: Failed loading resource: res://scene/node.tscn. Make sure resources have been imported by opening the project in the editor at least once.
   at: (core/io/resource_loader.cpp:273)

And the editor outputs
scene/resources/packed_scene.cpp:92 - Condition "nc == 0" is true. Returning: nullptr
editor/editor_data.cpp:626 - Index p_idx = 1 is out of bounds (edited_scene.size() = 1).

Restarted the editor, the corrupted message disappeared, and I was able to open the scene normally.
Bisect reveals that the problem stems from the commit Fix multi-threaded resource loading #74405 4.1.dev3
Although this is a minor issue that can be resolved by restarting the editor, I chose to report it anyway, maybe it's related to other scene corruption issues?
Steps to reproduce

Create an autoload with var sceneA = preload(sceneA).
Create a sceneA and add a sprite with a texture.
Exit the editor and delete the .godot folder.
Re-open the project, open sceneA and a message will pop up that the sceneA is corrupted.
Restart the window without deleting the .godot folder, then you can open sceneA normally.
Delete the .godot folder, reopen the editor, and you will find the scene is corrupted again.

editor version >= 4.1.dev3
Minimal reproduction project
AutoLoadPreloadScene.zip

Same issue here, but restarting the editor does not fix for me. I can only open the .tscn in the editor by removing the preload line from the attached script. This is only an editor bug; I cannot open/edit the .tscn in the editor with the preload in place, but everything works fine when running the project.

I too deleted the contents of the .godot  then reimported it to resolve an unrelated error to only get a set of new problems. I started experiencing this behavior with one of my level in the editor. One odd thing was that I ran the game and teleported to the level in game and it ran just fine. But I could not access the same level in the editor.
Not sure if this is really caused by the same problem, but I experienced similar behavior in 4.1.1
scene/resources/resource_format_text.cpp:283 - res://levels/OutdoorLevel.tscn:444 - Parse Error:

Failed loading resource: res://levels/OutdoorLevel.tscn. Make sure resources have been imported by opening the project in the editor at least once.

editor/editor_data.cpp:626 - Index p_idx = 1 is out of bounds (edited_scene.size() = 1).


Creating a Tunnel Availability and Failover Guide

Reframing this page to highlight the benefits.

@abelinkinbio Are these instructions missing some steps? As in, you need to create a configuration file and route traffic before doing cloudflared tunnel run <NAME>?

I don't think it's necessary here. Presumably these users already have a Tunnel configured and they're simply spinning up a replica. No need to do any rework on tha


DOWNLOAD FAILED 1 [LB]

I have dockerized UnicornLoadBalancer, FFMPEG & Transcoder.  I have it working successfully when Plex and LoadBalancer are running in the same container but when I try to have them separate I get a "DOWNLOAD FAILED 1 [LB]" when debugging.  In both instances I have the Transcoder running in a separate docker container.  The LoadBalancer container is mapped to the SQLITE path of Plex (otherwise it crashed due to inaccessibility to the SQL database), I've also mapped the PLEX_PATH_SESSIONS and PLEX_PATH_USR paths to the LoadBalancer container.
All containers are running on the same system for this test.  I've updated the FFMPEG path as well so I'm not sure what I'm missing.
Thank you.

Can you give us your configuration values ?


ChildFragmentManager question

Hi
is this lib work with fragments??
And can I manage it like this way?
I have a fragment with layout
<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:orientation="vertical">

    <include layout="@layout/layout_toolbar" />

    <FrameLayout
        android:id="@+id/fragment"
        android:layout_width="match_parent"
        android:layout_height="0dp"
        android:layout_weight="1"/>

    <View
        android:layout_width="match_parent"
        android:layout_height="1dp"
        android:background="@color/black" />

    <LinearLayout
        android:id="@+id/llTabHost"
        android:layout_width="match_parent"
        android:layout_height="56dp"
        android:orientation="horizontal">

    </LinearLayout>
</LinearLayout>

Then I init bar
 bottomBar = BottomBar.attach(rootView.findViewById(R.id.llTabHost), savedInstanceState);
add items and change fragment on tab listener
        getChildFragmentManager()
                        .beginTransaction()
                        .add(R.id.fragment, Fragment.newInstance())
                        .commit();

Bar is visible and it seems the fragment added some where but it is not showing in the fragment container. Any suggestions?

Sorry it seems I found what's wrong
I just need to set container on attach method not rootView
  View rootView = inflater.inflate(R.layout.fragment_shift_tabs, container, false);
   bottomBar = BottomBar.attach(container, savedInstanceState);

No, it added to my activity instead fragment

Yes it works with Fragments.
You need not specify the LinearLayout (@+id/llTabHost) in the XML just for the BottomBar.
In your Activity,
mBottomBar = BottomBar.attach(this, savedInstanceState);

then add a listener to the BottomBar like so, and update the fragments
        mBottomBar.setOnTabClickListener(new OnTabClickListener() {
            @Override
            public void onTabSelected(int position) {
                switch (position){
                    case 0:
                    getSupportFragmentManager().beginTransaction().replace(R.id.fragment,MyFragment.newInstance()).commit();

                    break;
                }
            }
            @Override
            public void onTabReSelected(int position) {

            }
        });

@PsyGik It will work but not as expected. I have one activity and stack of fragments in it and only one fragment should have the bottomBar. When I popBack fragment with bottomBar I expect that the bottomBar will be destroyed with the fragment but it attached to my activity.

@PingForward, I'm sorry I misread your original query. I get it now. You want the BottomBar to be in a single Fragment. Try this in your Fragment's OnCreate
@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
    View view = inflater.inflate(R.layout.my_fragment_layout, container, false);
    initViews(view);

    BottomBar bottomBar = BottomBar.attach(view, savedInstanceState);
    bottomBar.setItems(
        new BottomBarTab(R.drawable.ic_recents, "Recents"),
        new BottomBarTab(R.drawable.ic_favorites, "Favorites"),
        new BottomBarTab(R.drawable.ic_nearby, "Nearby")
    );

    return bottomBar;
}

@PsyGik thanks! Works now.

Happy to help! Have fun coding! 💻

Hi!
First of all thank you for this awesome library.
Im following this particular issue, about using fragments in BottomBar, i followed the code you posted:
`mBottomBar.setOnTabClickListener(new OnTabClickListener() {
@Override
public void onTabSelected(int position) {
switch (position){
case 0:
getSupportFragmentManager().beginTransaction().replace(R.id.fragment,MyFragment.newInstance()).commit();
                break;
            }
        }
        @Override
        public void onTabReSelected(int position) {

        }
    });`

But im having an erros on this method: newInstance()

@brunochichava, that is just a Fragment factory method. Nothing to do with this library.

I have a same issue here.A activity opens the a fragment based on navigationview. then that fragment is having the BottomBar, but earlier i was returning the rootview of fragment(which failed in IllegalStateException ). then on seeing this one i changed to returning the buttonbar, but now the listeners for button bar is not working.

I got i cleared the above error. by populating the items from xml. It always got returning -1 when adding inside the code.


<EMAIL_ADDRESS>resolves to beta.5-1 with yarn install

Bug Report
Warning during yarn install:
warning "<EMAIL_ADDRESS>has incorrect peer dependency "<EMAIL_ADDRESS>After yarn cache clean && rm -rf node_modules && rm yarn.lock && yarn install in my yarn.lock file I have this:
"<EMAIL_ADDRESS>  version "1.0.0-beta.5-1"
  resolved<EMAIL_ADDRESS>
With npm install the correct dependency is resolved.
I do not know if it is related to yarn or Covalent.
What is the expected behavior?
No warning, and correct dependency of "@covalent/core": "^1.0.0-beta.6"
Which version of Angular and Material, and which browser and OS does this issue affect?
    "@angular/material": "2.0.0-beta.8",
    "@angular/cdk": "2.0.0-beta.8",
    "@covalent/core": "^1.0.0-beta.6"

did you try yarn upgrade? can't think of a reason why this is failing.

yarn upgrade does the same. It is more likely to be a yarn issue. I have checked Covalent in yarn registry and seems fine. Do you guys use yarn without an issue?

I have upgraded yarn to v0.27.5, wich did not solve the issue.
There are 2 things that can solve it (although the bug - in most likely yarn - still exists):

edit yarn.lock by hand to use beta.6 (which will be overwritten to the wrong dependency on a yarn upgrade)
use fixed dependency version in package.json: "@covalent/core": "1.0.0-beta.6"

It looks like yarn thinks beta.5-1 is greater then beta.6 :)
Interesting.
As this is not covalent related, I close the issue.

huh, that's weird. Gonna add faqs to this since people might encounter this issue.

I have same issue and install beta 6 "npm install<EMAIL_ADDRESS><EMAIL_ADDRESS>etc"
Usually "npm install @covalent/core@latest" should do the trick but it didn't work with beta 6.


Various cleanups

I accumulated these while working on other code.

R: @chamikaramj

LGTM

retest this please

Coverage decreased (-0.3%) to 70.15% when pulling 899562006d016e2e9e73c08381e48e8e70a0d90c on robertwb:cleanup into 0be61dbb5cb44d08edf2ffbb09dce1d810683aa5 on apache:master.


fixes BaseNodeRenderer#find_render when node is nil

@earoberson Can you please add a testcase for code change? Thanks!

Fixes #21


chore(ci): switch to dedicated Firefly runners

Codecov Report

Merging #1286 (9c66fdc) into main (5f9afe2) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1286   +/-   ##
=======================================
  Coverage   99.97%   99.98%
=======================================
  Files         308      308
  Lines       20698    20698
=======================================
+ Hits        20692    20694    +2
+ Misses          5        3    -2
  Partials        1        1

see 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


ci: add workflow_dispatch and schedule once a week

Since CI is only triggered when pushing to either the main branch or some PR, it can be unused for long periods. For instance, last time main CI run here was 3 months ago: https://github.com/antmicro/raviewer/actions?query=branch%3Amain.
This PR adds the workflow_dispatch event to allow triggering runs without pushing code changes.
Moreover, a weekly run is scheduled, to avoid long periods without CI testing.

Note that github automatically disables the periodic jobs if there are not pushes for some period anyway (I think it is 3 months currently?)

Yes, it's 90 days by default. Yet, with this PR we will get weekly runs during that 3 month period.


MDT links do not mention Win 10 support

The links about referring to MDT refer to a version of MDT which, apparently, doesn't support Windows 10 in the What's new and release information sections of the linked resource.
https://docs.microsoft.com/en-us/sccm/mdt/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6c72fef0-0e1e-b3b1-2ca2-27df7e2c7f1f
Version Independent ID: 117497b2-a7c6-45ba-d101-31e1e432dafa
Content: Deploy Windows 10 with the Microsoft Deployment Toolkit (Windows 10)
Content Source: windows/deployment/deploy-windows-mdt/deploy-windows-10-with-the-microsoft-deployment-toolkit.md
Service: unspecified
GitHub Login: @mtniehaus
Microsoft Alias: greglin

@officedocsbot assign @mypil

@theboymango Thank you for reaching out.  I'll have a look and get it fixed soonest.

@theboymango - please assist to give updates on the clarification question from lindspea? Thank you.

@theboymango - We appreciate any feedback that improves the content in the Microsoft docs but we haven't had any response from you so we are going to close this issue.
Please feel free to re-open this issue if there is a specific area of the docs that we can improve or make better. Thank you.

@officedocsbot close


html_sidebars with dict deprecated in Sphinx

Running make html with the latest version of the docs gives the following warning:

sphinx/builders/html.py:1095: RemovedInSphinx20Warning: Now html_sidebars only allows list of sidebar templates as a value. Support for a string value will be removed at Sphinx-2.0.

This is because we're specifying html_sidebars as a dict.
We should fix this soon.

Also mentioned in #1736

I had a look at resolving this but it does not seem to be an issue at least on my machine.
I understand from #1736 tox can enter other packet versions but i am confident its using sphinx 2.
Is there some other way of running this that would produce the error ?

[pip pip 09:36] tox -e docs
GLOB sdist-make: /root/pip/setup.py
docs inst-nodeps: /root/pip/.tox/.tmp/package/1/pip-19.2.dev0.zip
docs installed: alabaster==0.7.12,Babel==2.7.0,certifi==2019.6.16,chardet==3.0.4,docutils==0.14,idna==2.8,imagesize==1.1.0,Jinja2==2.10.1,MarkupSafe==1.1.1,packaging==19.0,pip==19.2.dev0,Pygments==2.4.2,pypa-docs-theme==0.0.1,pyparsing==2.4.0,python-docs-theme==2018.7,pytz==2019.1,requests==2.22.0,setuptools==41.0.1,six==1.12.0,snowballstemmer==1.9.0,Sphinx==2.0.1,sphinxcontrib-applehelp==1.0.1,sphinxcontrib-devhelp==1.0.1,sphinxcontrib-htmlhelp==1.0.2,sphinxcontrib-jsmath==1.0.1,sphinxcontrib-qthelp==1.0.2,sphinxcontrib-serializinghtml==1.1.3,urllib3==1.25.3,wheel==0.33.4
docs run-test-pre: PYTHONHASHSEED='4186122816'
docs run-test-pre: commands[0] | python -c 'import shutil, sys; shutil.rmtree(sys.argv[1], ignore_errors=True)' /root/pip/tests/data/common_wheels
docs run-test-pre: commands[1] | python /root/pip/tools/tox_pip.py wheel -w /root/pip/tests/data/common_wheels -r /root/pip/tools/tests-common_wheels-requirements.txt
Collecting setuptools>=40.8.0 (from -r tools/tests-common_wheels-requirements.txt (line 8))
Using cached https://files.pythonhosted.org/packages/ec/51/f45cea425fd5cb0b0380f5b0f048ebc1da5b417e48d304838c02d6288a1e/setuptools-41.0.1-py2.py3-none-any.whl
Saved ./tests/data/common_wheels/setuptools-41.0.1-py2.py3-none-any.whl
Collecting wheel (from -r tools/tests-common_wheels-requirements.txt (line 9))
Using cached https://files.pythonhosted.org/packages/bb/10/44230dd6bf3563b8f227dbf344c908d412ad2ff48066476672f3a72e174e/wheel-0.33.4-py2.py3-none-any.whl
Saved ./tests/data/common_wheels/wheel-0.33.4-py2.py3-none-any.whl
Skipping setuptools, due to already being wheel.
Skipping wheel, due to already being wheel.
docs run-test: commands[0] | sphinx-build -W -d /root/pip/.tox/docs/tmp/doctrees/html -b html docs/html docs/build/html
Running Sphinx v2.0.1
19.2
loading intersphinx inventory from https://packaging.python.org/objects.inv...
loading intersphinx inventory from https://www.pypa.io/en/latest/objects.inv...
building [mo]: targets for 0 po files that are out of date
building [html]: targets for 27 source files that are out of date
updating environment: 27 added, 0 changed, 0 removed
reading sources... [  3%] cookbook
reading sources... [  7%] development/configuration
reading sources... [ 11%] development/contributing
reading sources... [ 14%] development/getting-started
reading sources... [ 18%] development/index
reading sources... [ 22%] development/release-process
reading sources... [ 25%] development/vendoring-policy
reading sources... [ 29%] index
reading sources... [ 33%] installing
reading sources... [ 37%] logic
reading sources... [ 40%] news
reading sources... [ 44%] quickstart
reading sources... [ 48%] reference/index
reading sources... [ 51%] reference/pip
reading sources... [ 55%] reference/pip_check
reading sources... [ 59%] reference/pip_config
reading sources... [ 62%] reference/pip_download
reading sources... [ 66%] reference/pip_freeze
reading sources... [ 70%] reference/pip_hash
reading sources... [ 74%] reference/pip_install
reading sources... [ 77%] reference/pip_list
reading sources... [ 81%] reference/pip_search
reading sources... [ 85%] reference/pip_show
reading sources... [ 88%] reference/pip_uninstall
reading sources... [ 92%] reference/pip_wheel
reading sources... [ 96%] usage
reading sources... [100%] user_guide
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
preparing documents... done
writing output... [  3%] cookbook
writing output... [  7%] development/configuration
writing output... [ 11%] development/contributing
writing output... [ 14%] development/getting-started
writing output... [ 18%] development/index
writing output... [ 22%] development/release-process
writing output... [ 25%] development/vendoring-policy
writing output... [ 29%] index
writing output... [ 33%] installing
writing output... [ 37%] logic
writing output... [ 40%] news
writing output... [ 44%] quickstart
writing output... [ 48%] reference/index
writing output... [ 51%] reference/pip
writing output... [ 55%] reference/pip_check
writing output... [ 59%] reference/pip_config
writing output... [ 62%] reference/pip_download
writing output... [ 66%] reference/pip_freeze
writing output... [ 70%] reference/pip_hash
writing output... [ 74%] reference/pip_install
writing output... [ 77%] reference/pip_list
writing output... [ 81%] reference/pip_search
writing output... [ 85%] reference/pip_show
writing output... [ 88%] reference/pip_uninstall
writing output... [ 92%] reference/pip_wheel
writing output... [ 96%] usage
writing output... [100%] user_guide
generating indices...
writing additional pages... search
copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.
The HTML pages are in docs/build/html.
docs run-test: commands[1] | sphinx-build -W -d /root/pip/.tox/docs/tmp/doctrees/man -b man docs/man docs/build/man -c docs/html
Running Sphinx v2.0.1
19.2
loading intersphinx inventory from https://packaging.python.org/objects.inv...
loading intersphinx inventory from https://www.pypa.io/en/latest/objects.inv...
building [mo]: targets for 0 po files that are out of date
building [man]: all manpages
updating environment: 13 added, 0 changed, 0 removed
reading sources... [  7%] commands/check
reading sources... [ 15%] commands/config
reading sources... [ 23%] commands/download
reading sources... [ 30%] commands/freeze
reading sources... [ 38%] commands/hash
reading sources... [ 46%] commands/help
reading sources... [ 53%] commands/install
reading sources... [ 61%] commands/list
reading sources... [ 69%] commands/search
reading sources... [ 76%] commands/show
reading sources... [ 84%] commands/uninstall
reading sources... [ 92%] commands/wheel
reading sources... [100%] index
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
writing... pip.1 { } done
build succeeded.
The manual pages are in docs/build/man.
_______________________________________________________ summary _______________________________________________________
docs: commands succeeded
congratulations :)

@pganssle @webknjaz any help on moving this forward would be appreciated.

If you're looking for requirements, they are here: https://github.com/pypa/setuptools/blob/67344c9/docs/requirements.txt#L1

@adamRogerson judging from your log, it looks like it's fixed.
cc @pganssle

This is definitely still not fixed, since html_sidebar is still using a dict. You can see the failure in this Travis job.
I recommend trying to reproduce it locally with:
rm -rf .tox
tox -e docs

@adamRogerson It seems that you have a weird dev version of pip installed. I can't say I understand exactly why that log seems to succeed with Sphinx >= 2.0, but I'd try with a vanilla Python 3 environment without any dev versions of anything installed.


Home Assistant Warning for version key in manifest file.

I am receiving the following warning in the HA logs.
2021-04-14 21:27:38 WARNING (MainThread) [homeassistant.loader] No 'version' key in the manifest file for custom integration 'googlewifi'. As of Home Assistant 2021.6, this integration will no longer be loaded. Please report this to the maintainer of 'googlewifi'

Fixed in release 0.1.25


Do you know what changed recently?

I know this is a problem with copilon.nvim and not copilot.lua. Mr pope has issues turned off though, and I figure maybe someone knows here due to the knowledge sharing between these 2 projects.
Do you know what happened recently with autocompleting the text? it is atrocious, like when it makes a suggestion, Its like its treated as "real text" now, so when i move up/down with the cursor, I cant type "through" the incorrect stuff anymore and just ignore it, now it actually affects cursor movement as if its real text
Im wondering if anyone else notices this, it truly ruins the experience :[

Do you know what happened recently with autocompleting the text? it is atrocious, like when it makes a suggestion, Its like its treated as "real text" now, so when i move up/down with the cursor, I cant type "through" the incorrect stuff anymore and just ignore it, now it actually affects cursor movement as if its real text

Can you share a recording? I can't reproduce it.

Not sure how to copy this but here is a screenshot, will try to get a recording when im back home

I just rolled back to commit 38a41d0d78f8823cc144c99784528b9a68bdd608 and everything works as it did.

@matijas-05 so you noticed it too? How would you describe it? It's a bit hard to explain.
I've been trying to record a loom video for @MunifTanjim but it will work perfectly when recording, and as soon as I close it it will come back in a fury... I tried about 5 or 6 times and just gave up.
It basically has tons of "artifacts" and junk which doesn't clear if you type too fast, and they actually completely obscure movement/actual typing as if they're real text.

@matijas-05 so you noticed it too? How would you describe it? It's a bit hard to explain.
I've been trying to record a loom video for @MunifTanjim but it will work perfectly when recording, and as soon as I close it it will come back in a fury... I tried about 5 or 6 times and just gave up.
It basically has tons of "artifacts" and junk which doesn't clear if you type too fast, and they actually completely obscure movement/actual typing as if they're real text.

In my case the time it takes to come up with a suggestion is longer, also when you overwrite a part of the suggestion and accept it, your input that overwrote the suggestion gets added after it.

Yes, I also noticed that for sure as a secondary issue.
The primary issue as well I noticed is that normal mode actually wont move "through" text but around it, it will jump over entire lines

I made a comment on copilot.vim commit but it seems he can't produce it. Perhaps there is some indirect problem with the formatting of the responses or something, with the new agent.js? So perhaps the behavior is correct in copilot.vim not breaks in copilot.lua, even though only the agent.js changed

Heres a quick example of the issue @matijas-05 encountered.  The other issues arent as common but Ill try to get other looms as they come up
https://www.loom.com/share/e3f7407e1fb64857942b66a501935aec

@matijas-05 so you noticed it too? How would you describe it? It's a bit hard to explain.
I've been trying to record a loom video for @MunifTanjim but it will work perfectly when recording, and as soon as I close it it will come back in a fury... I tried about 5 or 6 times and just gave up.
It basically has tons of "artifacts" and junk which doesn't clear if you type too fast, and they actually completely obscure movement/actual typing as if they're real text.

In my case the time it takes to come up with a suggestion is longer, also when I overwrite a part of the suggestion and accept it, the input that overwrote the suggestion gets added after the suggestion.

Same. Tried tweaking things, but realized it's not working properly anymore.

same here

Hi everyone,
I also noticed the same issue, so I made a few tests:

Following tpope's advice, I reverted the agent to the previous version => Same issue (So this is not due to copilot.vim)
I partially reverted the changes of commit dcaaed5 which modifies the schedule() function in the suggestion file (https://github.com/zbirenbaum/copilot.lua/commit/dcaaed5b58e6c2d395bca18d25d34e6384856722#diff-5f63348c80e3035904e43971249bc360c91fca0a972cca6e51b90ff4246fa1abR405) => This fixes the issue 👍

@MunifTanjim I don't really know what this clear() function does, but when it's not called on every schedule() call, the suggestion is not cleared when we keep writing while their is a suggestion shown, so if we decide to accept the suggestion after writing a few additional characters, those characters are being added at the end of the suggestion like shown by @9mm video.
And I don't know why but this simple change also fixes the issue with the suggestion taking more time to appear.
Was there a crucial point to moving the clear() call inside the !is_enabled() condition?
If not, just moving the call will fix everything for us.
But if the change is still needed, we'll have to think of how to fix the condition to call it.

Ok so I just noticed this lua code is simply trying to replicate tpope's vimscript code (https://github.com/github/copilot.vim/blob/5b19fb001d7f31c4c7c5556d7a97b243bd29f45f/autoload/copilot.vim#L415)
We can see that the condition is a little bit different in the lua implementation, so I guess this is why we have issues here.
I will try to fix this locally, and if it works I'll create a PR but since i don't know either codebases, if anyone feels comfortable doing it, please go ahead 🙏

@meeehdi-dev that is awesome, especially because you also fixed the delay issue. Nice!! Hopefully this gets merged or looked at soon as this is killin me

@meeehdi-dev that is awesome, especially because you also fixed the delay issue. Nice!! Hopefully this gets merged or looked at soon as this is killin me

As @matijas-05 mentioned, you can still rollback to commit 38a41d0d78f8823cc144c99784528b9a68bdd608 while this gets fixed.

After further investigation it seems to me there is a drift between this plugin's lua code and tpope's.
For example, the function UpdatePreview (https://github.com/github/copilot.vim/blob/release/autoload/copilot.vim#L331) looks way different than its lua equivalent update_preview (https://github.com/zbirenbaum/copilot.lua/blob/master/lua/copilot/suggestion.lua#L228)
I don't know if it is intended or not, but let's say it is.
The difference in behavior we end up with is that tpope's code updates the suggestion when the user inputs new characters while the suggestion is shown, so his plugin has no issue of additional characters appearing at the end of the accepted suggestion.
I'll wait for the maintainers to tell us what's the best course of action now that we know where the problem comes from.

@meeehdi-dev he replied here with a possible fix, are you able to test it? https://github.com/zbirenbaum/copilot.lua/issues/259
I'm not at my computer atm but I figured I would put it here anyway as you were investigating that issue, so might be easy for you to test

@meeehdi-dev he replied here with a possible fix, are you able to test it? #259
I'm not at my computer atm but I figured I would put it here anyway as you were investigating that issue, so might be easy for you to test

The issue doesn't appear anymore after this fix, with the same options i mentioned above (debounce=500) 👍

Noice. Sorry for getting back so late.
Let's reopen if the issue comes back again.

Thanks!! Nice work, looks great so far for me

I did skim this issue before I opened #259 but it wasn't clear this was the same issue. Sorry for the redundancy -- but hopefully the sleuthing I did in #259 was helpful to @MunifTanjim (and thanks again!)

Yep, the description in #259 helped me reproduce the issue. Thanks for that 🙌🏼 @jtackaberry


feat: init e2e workflow setup

✨ Codu Pull Request 💻
Fixes #(issue)

NA

Pull Request details

Created a workflow to run e2e tests under e2e env with pre-seeded db and github app setup
Requires few secrets to to added for db and github app setup

Any Breaking changes

None

Associated Screenshots

None

The tests will start passing once this PR merged and rebased into the e2e workflow branched

@NiallJoeMaher @John-Paul-Larkin
I am not having access to add secrets to the repo, if any of you could create a new supabase instance and add the
E2E_DATABASE_URL in the secret we'll have a persistent E2E DB
Also we need to create github oauth client for testing github auth flows
That will require similar secrets please refer to the workflow implementaion

@pkspyder007 - Do you think we should use an e2e database url or just give it a database URL it can use instead (rather than having a separate one). Eg. if we used DATABASE_URL would there be any issue?

@pkspyder007 - Do you think we should use an e2e database url or just give it a database URL it can use instead (rather than having a separate one). Eg. if we used DATABASE_URL would there be any issue?

@NiallJoeMaher The current setup uses DATABASE_URL only I have just named secret to have E2E in the name so its clear to understand what this DB url exactly is.
Our E2E_DATABASE_URL will contain link to a postgres db with seeded data.

Also wanna add that running a docker image will utilise more resource and cost us more and lead to increased the CI times.

@NiallJoeMaher have a look whenever you get time
few action items

check for login test flakiness
fix seeding
updating and revamping skipped tests
move tests results to report on PR and host traces to something like S3


Carousel refinements

Addresses #79 and #65

@cparaiso -- thanks!
I hope we can update to a release with these changes soon.


September release notes still appearing

It's almost November and I'm still annoyingly getting September's Release Notes. Specifically right-clicking in Filezilla to view, but also happens in other situations when open via file association.

I don't understand: "getting September's Release Notes" for what product?

vscode...

what version of VS Code are you using?

So I opened VS Code to check that and the release notes popped up again.
Was version 1.28.1, I have just updated to 1.28.2.
Maybe it was a 1.28.1 glitch, will post if it happens again.

Thanks 👍

Please see if you can find any logged output that could help us find the source of the issue:

run code --verbose from the command line and attach the output
in Code select Help | Toggle Developer Tools and select the Console
attach any output you see in the Console you can find

Thanks!

On VS Code 1.28.0, when running code --verbose, I got the following console output:
[main 6:09:13 PM] Starting VS Code
[main 6:09:13 PM] from: c:\Program Files\Code\resources\app
[main 6:09:13 PM] args: { _: [],
  help: false,
  h: false,
  version: false,
  v: false,
  wait: false,
  w: false,
  diff: false,
  d: false,
  add: false,
  a: false,
  goto: false,
  g: false,
  'new-window': false,
  n: false,
  'unity-launch': false,
  'reuse-window': false,
  r: false,
  'open-url': false,
  performance: false,
  p: false,
  'prof-startup': false,
  verbose: true,
  logExtensionHostCommunication: false,
  'disable-extensions': false,
  disableExtensions: false,
  'list-extensions': false,
  'show-versions': false,
  nolazy: false,
  issue: false,
  'skip-getting-started': false,
  'skip-release-notes': false,
  'sticky-quickopen': false,
  'disable-restore-windows': false,
  'disable-telemetry': false,
  'disable-updates': false,
  'disable-crash-reporter': false,
  'skip-add-to-recently-opened': false,
  status: false,
  s: false,
  'file-write': false,
  'file-chmod': false,
  'driver-verbose': false,
  trace: false }
[main 6:09:13 PM] Resolving machine identifier...
[main 6:09:13 PM] Resolved machine identifier: f7ccb7ab8a38063ffc32e4cce804bb36d075140a81e6e9670b73b694b783fa48
[main 6:09:13 PM] update#setState idle
[main 6:09:13 PM] windowsManager#open
[2552:1026/180914.498:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[2552:1026/180914.506:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[2552:1026/180914.518:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[main 6:09:14 PM] windowsService#whenSharedProcessReady
[main 6:09:14 PM] windowsService#getRecentlyOpened 1
[main 6:09:14 PM] windowsService#startCrashReporter
[2552:1026/180915.010:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[2552:1026/180915.014:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[main 6:09:15 PM] IPC#vscode-workbenchLoaded
[main 6:09:15 PM] windowsService#setRepresentedFilename 1
[main 6:09:15 PM] windowsService#getWindowCount
[2552:1026/180915.234:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[main 6:09:15 PM] IPC#vscode:broadcast vscode:changeColorTheme {"baseTheme":"vs-dark","background":"#1e1e1e"}
[2552:1026/180915.250:INFO:CONSOLE(1409)] "%c INFO", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1409)
[2552:1026/180915.334:INFO:CONSOLE(3294)] "Extension is not compatible with Code 1.28.0. Extension requires: ^1.28.1.", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (3294)
[2552:1026/180915.412:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[2552:1026/180915.415:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[main 6:09:15 PM] RequestService#request https://vscode-update.azurewebsites.net/api/update/win32-x64/stable/431ef9da3cf88a7e164f9d33bf62695e07c6c2a9
[main 6:09:15 PM] windowsService#isFocused 1
[2552:1026/180916.870:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[2552:1026/180916.882:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[2552:1026/180916.887:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[2552:1026/180916.902:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[2552:1026/180916.986:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[2552:1026/180917.002:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[2552:1026/180917.002:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[2552:1026/180917.002:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[2552:1026/180917.002:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[2552:1026/180917.002:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[2552:1026/180917.002:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[main 6:09:17 PM] windowsService#setRepresentedFilename 1
[main 6:09:17 PM] windowsService#getWindowCount
[2552:1026/180917.628:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[2552:1026/180918.423:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[2552:1026/180918.704:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[main 6:09:43 PM] update#checkForUpdates, state =  idle
[main 6:09:43 PM] update#setState checking for updates
[main 6:09:43 PM] RequestService#request https://vscode-update.azurewebsites.net/api/update/win32-x64/stable/431ef9da3cf88a7e164f9d33bf62695e07c6c2a9
[main 6:09:43 PM] update#setState downloading
[main 6:09:43 PM] update#setState downloaded
[2552:1026/180946.656:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[main 6:09:46 PM] windowsService#toggleDevTools 1
[2552:1026/180947.313:VERBOSE1:CONSOLE(8192)] "Main._createAppUI: 17.483154296875ms", source: chrome-devtools://devtools/bundled/inspector.js (8192)
[2552:1026/180947.349:VERBOSE1:CONSOLE(8192)] "Main._showAppUI: 36.10302734375ms", source: chrome-devtools://devtools/bundled/inspector.js (8192)
[2552:1026/180947.401:VERBOSE1:CONSOLE(8192)] "Main._initializeTarget: 7.385986328125ms", source: chrome-devtools://devtools/bundled/inspector.js (8192)
[main 6:11:09 PM] windowsService#setRepresentedFilename 1
[main 6:11:10 PM] windowsService#setRepresentedFilename 1
[2552:1026/181112.503:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[main 6:11:12 PM] windowsService#openAboutDialog
[main 6:11:21 PM] update#applyUpdate, state =  downloaded
[main 6:11:21 PM] update#setState updating
[main 6:11:37 PM] windowsService#closeWindow 1
[main 6:11:37 PM] Lifecycle#window-before-close 1
[main 6:11:37 PM] Lifecycle#unload() 1
[2552:1026/181137.859:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[2552:1026/181137.859:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[main 6:11:37 PM] Lifecycle#unload(): unload continues without veto 1
[2552:1026/181137.859:INFO:CONSOLE(1408)] "%cTRACE", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (1408)
[main 6:11:37 PM] Lifecycle#onBeforeWindowClose.fire()
[main 6:11:37 PM] Lifecycle#window-before-close 1
[main 6:11:37 PM] Lifecycle#window-close 1
[main 6:11:37 PM] Lifecycle#window-closed 1
[main 6:11:37 PM] Lifecycle#onShutdown.fire()
[main 6:11:37 PM] Lifecycle#window-all-closed
[main 6:11:37 PM] Lifecycle#before-quit
[main 6:11:37 PM] Lifecycle#onBeforeShutdown.fire()
[main 6:11:37 PM] App#will-quit: disposing resources

Note there's only one error:
[2552:1026/180915.334:INFO:CONSOLE(3294)] "Extension is not compatible with Code 1.28.0. Extension requires: ^1.28.1.", source: file:///C:/Program Files/Code/resources/app/out/vs/workbench/workbench.main.js (3294)

When opening the developer tools inside VS Code, I also saw an error coming from some extensionService.js saying much the same thing. Sorry for not being more precise, I didn't copy & paste that one and have since updated VS Code to 1.28.2, which appears to have solved the problem for me.

@stakx does this reproduce if you change the user data directory: code --user-data-dir <some empty directory>

@stakx is any other state not persisting when you start normally? e.g. the list of opened editors

No, like I said, I have since updated to 1.28.2 and that made the problem disappear for me. I just posted that log from earlier in case it helps anyone.

Ok, waiting for @forepointmc to chime in

I updated to 1.28.2 a couple of weeks ago and haven't had the issue since


Adds a bnd-process goal to generate service descriptors

We move most BND plugins to run in the process-classes phase. This way service descriptors and the manifest are already available to Unit tests.
However a target/classes/module-info.class file is problematic for many Maven plugins, so we keep the jar BND goal to add it directly to the JAR file.
Closes #69

Solved in #77


Feature/ast 11451 add empty projects

By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change.

References

Include supporting link to GitHub Issue/PR number

Testing

Describe how this change was tested. Be specific about anything not tested and reasons why. If this solution has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Checklist

[x] I have added documentation for new/changed functionality in this PR (if applicable).  If documentation is a Wiki Update, please indicate desired changes within PR MD Comment
[x] All active GitHub checks for tests, formatting, and security are passing
[x] The correct base branch is being used

Checkmarx AST – Scan Summary & Details – 92667052-f1cc-4afc-87bb-b9fdec406076
No New Or Fixed Issues Found


std and boost filesystem support

Hello, Erik.
Thank you for your library.
I suggest to support both boost::filesystem & std::filesystem which make your library more "soft" or flexible.
For that I've re-worked std::filesystem support to allow use with older compilers and standards.
This PR can be used as reference or just merged as is.
Now supported any combinations for it
cmake -S. -Bbuild - will use c++17 by default and std::filesystem
cmake -S. -Bbuild -DCMAKE_CXX_STANDARD=11 -DUSE_BOOST_FILESYSTEM=ON -will use c++11 and boost::filesystem
cmake -S. -Bbuild -DUSE_BOOST_FILESYSTEM=ON - will use c++11 but boost::filesystem

Hey @snikulov thank you for your contribution. Let me have a look!

Can you check the ci build results. Something went wrong there.

@erikzenker fixed missed export for adaptation interface


Add connection_data base_address and port

With this patch
https://github.com/aholzinger/nmos-cpp/commit/98e773d077962e304d2d86054cd4b9aa38c21130
a user/client can extract also connection_data::base_address and port with sdp_parameters.

I believe this is unnecessary since the information is already extracted by get_session_description_transport_params and thus also by the convenience function parse_session_description.


"Previous" text in post view is not linked

From the post view, the "previous" text is not linked to anything regardless of whether there are multiple unread posts or where you are located in paging order. The below image is located at post 2 of 16. I am using the current Miniflux hosted version as of 7/23/2018

I'm not able to reproduce your issue, either by using keyboard shortcuts or by clicking on the entry link. The previous link is supposed to be deactivated only if you are reading the first item of the list.
Is it something that you encountered often?

@fguillot I can very consistently reproduce this in Firefox 61.0.1 and Chrome 67.0.3396.99 on Windows and Ubuntu Linux. I have even disabled all browser plugins to ensure that was not an issue.

I have the same problem, using Firefox 68.0.1 and Chrome/Brave  0.67.125 on Windows 8/64. In addition, the only the "J" and ">" commands work on the keyboard. The "Previous" button works on my OnePlus 6T and Samsung tablet

Same problem here. Previous "keyboard shortcut" does nothing and the previous link, doesn't link to anything when reading the unread section.

I'm not able to reproduce your issue, either by using keyboard shortcuts or by clicking on the entry link. The previous link is supposed to be deactivated only if you are reading the first item of the list.
Is it something that you encountered often?

If you start at the top of your unread list, and then view the second item, the previous link is not available. I think this is because the app has marked it as read and then removed it from the unread list. It's bad UI tho IMO - I often want to go back to a previous article in the list but am unable to and have then navigate to the history link to find it.


Incorrect image

The image for customized grouping seems to be the incorrect one as it does not reflect the described code and seems to be the same as the previous image.

Document details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

 New images are required for the doc - we will fix as soon as we can!


add Object oriented Programming Guide

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Add Object Oriented Programming Guide

Thank you for opening this pull request.
This is a standard message notifying you that we’ve reviewed your pull request and have decided not to merge it. We would welcome future pull requests from you.
Thank you and happy coding.


Avoid Windows Rollup Headaches

@rollup/rollup-win32-x64-msvc

This package is required in Windows.
If we add it to package.json as a dependency, then npm install breaks on Linux.
How can we solve this?
Can we add it as an optional dependency maybe?

Some ideas from ChatGPT:
To handle platform-specific dependencies in your package.json, you can use the optionalDependencies field. This allows the dependency to be installed only if the platform supports it, preventing installation errors on incompatible systems. Here's how you can do it:

Add the @rollup/rollup-win32-x64-msvc package as an optional dependency in your package.json.

{
  "name": "your-project",
  "version": "1.0.0",
  "dependencies": {
    // other dependencies
  },
  "optionalDependencies": {
    "@rollup/rollup-win32-x64-msvc": "*"
  }
}

Use os and platform specific conditions in your build scripts if needed.

This way, npm will attempt to install @rollup/rollup-win32-x64-msvc only if it is compatible with the system. If it's not compatible, the installation will simply skip it without breaking the process.
If you need to ensure that your project works on multiple platforms, you may also consider using platform-specific install scripts in your package.json to manage these dependencies conditionally. Here's an example of how you might set up scripts for different operating systems:
{
  "scripts": {
    "postinstall": "node ./scripts/install-dependencies.js"
  }
}

Then, create a scripts/install-dependencies.js file to handle the conditional installation:
const { exec } = require('child_process');
const os = require('os');

if (os.platform() === 'win32') {
  exec('npm install @rollup/rollup-win32-x64-msvc', (error, stdout, stderr) => {
    if (error) {
      console.error(`Error installing @rollup/rollup-win32-x64-msvc: ${error}`);
      return;
    }
    console.log(stdout);
    console.error(stderr);
  });
}

This script will check the platform and install the necessary dependency only if the system is Windows. This approach ensures that your project setup remains robust across different operating systems.


Fix test failure

Accidentally removed condition to throw exception when setBuildbotIndex was called with an argument equal to the last previous known index.

I was surprised when you kept the equal sign last time, but figured it was intentional since you corrected the comment as well.

I mistook that check for another one up above that was supposed to be without an equals sign, hence the confusion