--source-dir folder name with whitespace causes failure to run ash tool

naming a --source-dir folder path something that contains a whitespace character, e.g. my scan vs. my-scan causes ash to fail to run.
Re-create:
mkdir "my scan"
cd "my scan"
git clone <repo to scan>
cd <repo to scan>
ash --source-dir .

Hey @climbertjh2, this should be fixed with PR #64. Please clone the latest version and try again when you get a chance.

It appears to work - thanks for updating.  Closing this issue.


Create migration to import licences from Publisher

More info in the commits ->
Successful run in Staging: https://deploy.blue.staging.govuk.digital/job/run-rake-task/218466/console
Running the script again (after already importing licences): https://deploy.blue.staging.govuk.digital/job/run-rake-task/218468/console
Post migration
Finder Frontend

Specialist Publisher

Trello:
https://trello.com/c/RvKrQhgS/1676-create-import-mechanism-to-migrate-publisher-licences-into-specialist-publisher
⚠ This repo is Continuously Deployed: make sure you follow the guidance ⚠
Follow these steps if you are doing a Rails upgrade.

Hey Leena, thanks for the review! I believe I've addressed all your comments.
The PR will need updating (only the spec) if https://github.com/alphagov/specialist-publisher/pull/2216 is merged before this.


kubie:  0.7.3 -> 0.8.4

Motivation for this change
Version update.  Also includes bash completion.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@ofborg eval

bummer that you didn't just merge #86240 but oh well I guess


NodePattern improvements

This make NodePattern a better Ruby citizen:

provides valuable information with to_s / inspect
compatible with dup, YAML and Marshal.
method pattern gives access to the original pattern given when calling new
add comparison (==)

The one environment failing is having trouble with bundle; clearly not related to these changes.

Thanks @marcandre! All these improvements are really nice. 🙇
If you're interested in working more on the node patterns, there is an open issue.

Can you fix the name of the + prefix commit?

Can you fix the name of the + prefix commit?

Sorry, I don't understand

You've got a commit message titled "+ Make NodePattern serializable and al.". Likely you didn't mean to put the plus there.

You've got a commit message titled "+ Make NodePattern serializable and al.". Likely you didn't mean to put the plus there.

Oh, I see where Github shows that in the discussion above, but I've amended the PR since. Check the "commits" tab for the up to date list.

My bad. Thanks for working on this!


Fix all lint errors in lens

Since my VSCode reported a lot of lint errors, I fixed them all.

I mean it quickly drifts not just here but anything in progress. thanks for the help!

Revert license header changes! 🙇

thanks again @tacigar !


Attempt to use the build-in Lora.networks Lora/LyCORIS models lists

Fixed and formatted result of PRs #255 and #257.

This breaks entirely the extra networks tab, you can't press Refresh anymore.

This breaks entirely the extra networks tab, you can't press Refresh anymore.

I've replicated the bug and fixed it in committ 41626d2, but I discovered it is not related to this change. The issue was there before with SD.Next and had just gone unnoticed.
Instead, it has to do with force-refreshing the TI embeddings, which tag-autocomplete requests at the same time to ensure the list is up to date. What caused the issue to manifest now is that in a recent update of SD.Next, the "Model autoload on server start" setting seems to have broken. The model at least on my side doesn't autoload even with the option checked in the current version.
Refreshing embeddings requires a model, so it would trigger an on-demand load. The issue was that gradio didn't detect that by itself and I couldn't figure out how to tell it to, so the progress spinner would hang itself up.
So now I only request an embedding refresh if I know a model is already loaded, which fixed the issue.
However, it will also mean that in case of no cached list existing, embedding completion or new additions will be unavailable in SD.Next until the first model load.

Uhm, just tested and it hangs again on Refresh on A1111


[QUESTION] Is there a way to set window size ?

I wondering if there is a way to set window size ...
Unfortunately, I have not found how to do it in documentation

@hassandraga I saw you in this commit added those APIs https://github.com/webui-dev/python-webui/commit/4d022ba83ff59e4331914d4f8bce20ce9a5363c0
Could you update Python package ?

Thanks a lot !!


Removal of empty chunks doesn't update all imports

Describe the bug
In Astro we are updating to use vite:css-post for bundling instead of doing it our own thanks to the new viteMetadata property.
One thing that this plugin does is when there is a CSS chunk that only contains CSS, the JS bundle gets removed and any imports of that bundle are removed.
It uses a regexp to find import statements to remove. That code is here. However the code assumes the import statement is using double quotes.
I'm not sure why, but in Astro these become double quotes. As far as I can tell this isn't something Rollup lets you control. I'm not sure why it is happening, perhaps because we bundle to ESM?
Updating this regex to work with either single or double quotes would fix the issue. I'm willing to submit a PR to fix.
Reproduction
https://github.com/withastro/astro/runs/6595302507?check_suite_focus=true
System Info
System:
    OS: macOS 12.0.1
    CPU: (10) x64 Apple M1 Pro
    Memory: 32.51 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.19.1 - ~/.volta/tools/image/node/14.19.1/bin/node
    Yarn: 1.22.18 - ~/.volta/bin/yarn
    npm: 6.14.16 - ~/.volta/tools/image/node/14.19.1/bin/npm
  Browsers:
    Chrome: 101.0.4951.64
    Safari: 15.1

Used Package Manager
pnpm
Logs
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

It also happened when esbuild: false. https://stackblitz.com/edit/vitejs-vite-pcufvl?terminal=dev


New command: list orphan Office 365 groups

@waldekmastykarz @VelinGeorgiev
It is a good practice to find teams and groups without owners. Can we write a seperate command for this?

command graph o365group listorphan --includeSiteUrl

Alternatively we can add an option in graph o365group list command.

graph o365group list --orphan

Thoughts?

Very nice idea! I like the second option better. Would you like to pick it up yourself?

@waldekmastykarz
Sure, I will on this.

Excellent! I appreciate your help! 👏

Thank you @waldekmastykarz. I will work on this tomorrow.

Submitted the pull request. Thank you.


os-openconnect - no place to enter second password

Important notices
Before you add a new report, we ask you kindly to acknowledge the following:

[x] I have read the contributing guide lines at https://github.com/opnsense/plugins/blob/master/CONTRIBUTING.md

[x] I have searched the existing issues and I'm convinced that mine is new.

[x] When the request is meant for an existing plugin, I've added its name to the title.

Is your feature request related to a problem? Please describe.
This is a reopening of #1752. Here's a summary from that issue:

The Cisco AnyConnect client has a "second password" field used for 2FA codes and commands. For example, you can enter in "push" into this second field to have DUO Authenticator activate a prompt on your mobile phone to validate that it was actually you trying to login with your account.
I would like to have this second password field available in the OpenConnect web UI. From what I've read elsewhere online, OpenConnect itself supports this feature, so in theory it should be easy to add to the web UI.

I unfortunately don't have the expertise to make this happen, but it is definitely still something that would be useful as more and more VPNs move to 2FA, and I felt like a closed issue doesn't inspire any change like an open issue does.
Thanks!

Assuming this password is not static, how and where would you think the input form would be implemented? It's easy on a client, but the firewall has no way to initiate a password input to you?

Yes, the 2nd password would be dynamic, and that does create a bit of an awkward situation to handle. I think maybe just have it offer an input box on the configuration page that shows up after you hit connect, and it waits for the code/authorization (would be neat if it supported "push" to send a duo request too) before fully connecting.
The obvious drawback here is that you'd not be able to connect automatically, but in my limited testing, I seem to be able to remain on my VPN connection indefinitely with the regular client and my particular VPN server, not requiring a reauth unless the connection goes down. So, it'd probably be workable enough for anyone who has to deal with this type of setup (or at least, I think it's the best that's reasonably possible unless some sort of custom scripting is involved to somehow acquire the 2nd code), and it's obviously less seamless, but at least it'd be possible.

I don't mind discussing a proof of concept, but I can see that this is going to be more work than worth it. For core functionality I'd decline but plugins could offer an (impractical) solution for it.
challange=<code> && sudo -S <<< "<sudo_password>" echo I am super user && { printf '<vpn_password>\n'; sleep 1; printf "$challange\n"; } | sudo openconnect <server_name> --user <vpn_username> --passwd-on-stdin

From https://askubuntu.com/questions/1043024/how-to-run-openconnect-with-username-and-password-in-a-line-in-the-terminal

That's fair, it's an unfortunately awkward situation. Thank you for taking the time to talk about it though. Hopefully an easier/better method can be determined at some point.


Expected Results for PyTorch run_lm1b_base.sh

I wanted to know the expected test perplexity for the lm1b base model. It would be especially great if you could upload the training log file if possible. I wanted to include the results in my ICML paper.

We don't have numbers for that particular setting. In our paper, we used a base model with N_LAYER=20, D_MODEL=1024, D_INNER=6144 for lm1b and obtained a test perplexity of 23.5 (See Table 4 of https://arxiv.org/pdf/1901.02860.pdf).

For the pytorch script, the lm1b base model uses N_LAYER=18, D_MODEL=1024, D_INNER=4096 for 0.36 billion parameters. After 500K training step, my test perplexity was 30.25. My work uses a memory compressed version of the Adam optimizer. Would you consider this test score unreasonable?

I would expect a (much) better perplexity given the model size.

Then, do you have the log files for the original LM1B base model in the paper?
In this issue https://github.com/kimiyoung/transformer-xl/issues/1, you said that you ran the base models in PyTorch.

No I don't have access to the log files at this point. The base model results in Table 4 of our paper were also produced using TF. Try N_LAYER=20, D_MODEL=1024, D_INNER=6144 and I believe the pytorch version will also likely get close to 23.5. As for N_LAYER=18, D_MODEL=1024, D_INNER=4096, have you run the model as is to see the performance?

When I use the run_lm1b_base script I see this? However, this behavior doesn't seem correct - oscillating around 65 perplexity.
#params = 357812065
#non emb params = 245532672
----------------------------------------------------------------------------------------------------
| Eval  12 at step    48000 | time: 5132.39s | valid loss  4.16 | valid ppl    64.240
----------------------------------------------------------------------------------------------------
| epoch   1 step    48200 |  48200 batches | lr 0.000244 | ms/batch 1410.03 | loss  4.13 | ppl    61.889
| epoch   1 step    48400 |  48400 batches | lr 0.000244 | ms/batch 1294.38 | loss  4.14 | ppl    62.738
| epoch   1 step    48600 |  48600 batches | lr 0.000244 | ms/batch 1266.15 | loss  4.17 | ppl    64.460
| epoch   1 step    48800 |  48800 batches | lr 0.000244 | ms/batch 1268.40 | loss  4.18 | ppl    65.431
| epoch   1 step    49000 |  49000 batches | lr 0.000244 | ms/batch 1273.59 | loss  4.19 | ppl    66.287
| epoch   1 step    49200 |  49200 batches | lr 0.000244 | ms/batch 1266.28 | loss  4.18 | ppl    65.394
| epoch   1 step    49400 |  49400 batches | lr 0.000244 | ms/batch 1264.99 | loss  4.18 | ppl    65.567
| epoch   1 step    49600 |  49600 batches | lr 0.000244 | ms/batch 1302.28 | loss  4.20 | ppl    66.799
| epoch   1 step    49800 |  49800 batches | lr 0.000244 | ms/batch 1266.97 | loss  4.20 | ppl    66.702
| epoch   1 step    50000 |  50000 batches | lr 0.000244 | ms/batch 1267.11 | loss  4.16 | ppl    64.154
| epoch   1 step    50200 |  50200 batches | lr 0.000244 | ms/batch 1266.39 | loss  4.14 | ppl    62.508
| epoch   1 step    50400 |  50400 batches | lr 0.000244 | ms/batch 1266.90 | loss  4.16 | ppl    63.760
| epoch   1 step    50600 |  50600 batches | lr 0.000244 | ms/batch 1265.40 | loss  4.15 | ppl    63.486
| epoch   1 step    50800 |  50800 batches | lr 0.000244 | ms/batch 1289.09 | loss  4.14 | ppl    62.990
| epoch   1 step    51000 |  51000 batches | lr 0.000244 | ms/batch 1270.12 | loss  4.14 | ppl    62.907
| epoch   1 step    51200 |  51200 batches | lr 0.000244 | ms/batch 1266.82 | loss  4.16 | ppl    64.348
| epoch   1 step    51400 |  51400 batches | lr 0.000244 | ms/batch 1266.81 | loss  4.15 | ppl    63.356
| epoch   1 step    51600 |  51600 batches | lr 0.000243 | ms/batch 1266.01 | loss  4.15 | ppl    63.264
| epoch   1 step    51800 |  51800 batches | lr 0.000243 | ms/batch 1297.72 | loss  4.17 | ppl    64.703
| epoch   1 step    52000 |  52000 batches | lr 0.000243 | ms/batch 1270.37 | loss  4.16 | ppl    64.097
----------------------------------------------------------------------------------------------------
| Eval  13 at step    52000 | time: 5119.55s | valid loss  4.13 | valid ppl    61.921
----------------------------------------------------------------------------------------------------
| epoch   1 step    52200 |  52200 batches | lr 0.000243 | ms/batch 1402.27 | loss  4.17 | ppl    64.870
| epoch   1 step    52400 |  52400 batches | lr 0.000243 | ms/batch 1270.55 | loss  4.17 | ppl    64.691
| epoch   1 step    52600 |  52600 batches | lr 0.000243 | ms/batch 1266.28 | loss  4.16 | ppl    64.062
| epoch   1 step    52800 |  52800 batches | lr 0.000243 | ms/batch 1266.92 | loss  4.16 | ppl    64.056
| epoch   1 step    53000 |  53000 batches | lr 0.000243 | ms/batch 1291.17 | loss  4.26 | ppl    70.585
| epoch   1 step    53200 |  53200 batches | lr 0.000243 | ms/batch 1271.03 | loss  4.20 | ppl    66.751
| epoch   1 step    53400 |  53400 batches | lr 0.000243 | ms/batch 1271.76 | loss  4.16 | ppl    64.147
| epoch   1 step    53600 |  53600 batches | lr 0.000243 | ms/batch 1284.31 | loss  4.18 | ppl    65.402
| epoch   1 step    53800 |  53800 batches | lr 0.000243 | ms/batch 1271.13 | loss  4.19 | ppl    65.710
| epoch   1 step    54000 |  54000 batches | lr 0.000243 | ms/batch 1294.83 | loss  4.17 | ppl    65.039
| epoch   1 step    54200 |  54200 batches | lr 0.000243 | ms/batch 1271.26 | loss  4.17 | ppl    64.620
| epoch   1 step    54400 |  54400 batches | lr 0.000243 | ms/batch 1269.98 | loss  4.18 | ppl    65.041
| epoch   1 step    54600 |  54600 batches | lr 0.000243 | ms/batch 1271.97 | loss  4.17 | ppl    64.832
| epoch   1 step    54800 |  54800 batches | lr 0.000243 | ms/batch 1271.84 | loss  4.16 | ppl    64.159
| epoch   1 step    55000 |  55000 batches | lr 0.000243 | ms/batch 1270.68 | loss  4.16 | ppl    64.344
| epoch   1 step    55200 |  55200 batches | lr 0.000243 | ms/batch 1294.90 | loss  4.17 | ppl    64.787
| epoch   1 step    55400 |  55400 batches | lr 0.000243 | ms/batch 1280.10 | loss  4.20 | ppl    66.789
| epoch   1 step    55600 |  55600 batches | lr 0.000242 | ms/batch 1269.64 | loss  4.23 | ppl    68.416
| epoch   1 step    55800 |  55800 batches | lr 0.000242 | ms/batch 1272.26 | loss  4.20 | ppl    66.791
| epoch   1 step    56000 |  56000 batches | lr 0.000242 | ms/batch 1270.36 | loss  4.21 | ppl    67.023
----------------------------------------------------------------------------------------------------
| Eval  14 at step    56000 | time: 5126.69s | valid loss  4.18 | valid ppl    65.364
----------------------------------------------------------------------------------------------------
| epoch   1 step    56200 |  56200 batches | lr 0.000242 | ms/batch 1400.62 | loss  4.20 | ppl    66.641
| epoch   1 step    56400 |  56400 batches | lr 0.000242 | ms/batch 1294.03 | loss  4.18 | ppl    65.534
| epoch   1 step    56600 |  56600 batches | lr 0.000242 | ms/batch 1278.80 | loss  4.18 | ppl    65.627
| epoch   1 step    56800 |  56800 batches | lr 0.000242 | ms/batch 1271.03 | loss  4.22 | ppl    67.794
| epoch   1 step    57000 |  57000 batches | lr 0.000242 | ms/batch 1271.45 | loss  4.17 | ppl    64.446
| epoch   1 step    57200 |  57200 batches | lr 0.000242 | ms/batch 1280.95 | loss  4.20 | ppl    66.547
| epoch   1 step    57400 |  57400 batches | lr 0.000242 | ms/batch 1296.23 | loss  4.16 | ppl    64.168
| epoch   1 step    57600 |  57600 batches | lr 0.000242 | ms/batch 1278.13 | loss  4.17 | ppl    64.582
| epoch   1 step    57800 |  57800 batches | lr 0.000242 | ms/batch 1269.62 | loss  4.16 | ppl    64.314
| epoch   1 step    58000 |  58000 batches | lr 0.000242 | ms/batch 1284.13 | loss  4.14 | ppl    62.884
| epoch   1 step    58200 |  58200 batches | lr 0.000242 | ms/batch 1284.32 | loss  4.17 | ppl    64.793
| epoch   1 step    58400 |  58400 batches | lr 0.000242 | ms/batch 1272.11 | loss  4.17 | ppl    64.411
| epoch   1 step    58600 |  58600 batches | lr 0.000242 | ms/batch 1293.54 | loss  4.18 | ppl    65.501
| epoch   1 step    58800 |  58800 batches | lr 0.000242 | ms/batch 1277.37 | loss  4.20 | ppl    66.846
| epoch   1 step    59000 |  59000 batches | lr 0.000242 | ms/batch 1275.10 | loss  4.20 | ppl    66.643
| epoch   1 step    59200 |  59200 batches | lr 0.000241 | ms/batch 1270.24 | loss  4.19 | ppl    66.168
| epoch   1 step    59400 |  59400 batches | lr 0.000241 | ms/batch 1281.45 | loss  4.20 | ppl    66.690
| epoch   1 step    59600 |  59600 batches | lr 0.000241 | ms/batch 1269.60 | loss  4.18 | ppl    65.125
| epoch   1 step    59800 |  59800 batches | lr 0.000241 | ms/batch 1290.70 | loss  4.16 | ppl    64.041
| epoch   1 step    60000 |  60000 batches | lr 0.000241 | ms/batch 1269.11 | loss  4.20 | ppl    66.848
----------------------------------------------------------------------------------------------------
| Eval  15 at step    60000 | time: 5141.84s | valid loss  4.23 | valid ppl    68.582
----------------------------------------------------------------------------------------------------

It has been a known issue that using DIV_VAL > 1 (i.e., using adaptive embeddings) might cause instability of optimization (See #24). Try decreasing init_std or increasing the number of warmup steps.

@kimiyoung I ran run_lm1b_base script in 16GB memory nvidia gpu, but it occurs OOM. When I decrease BSZ from 256 to 64, it ran well. But I think convergence of this configuration may cost 4 times of the time-cost. Whether any variable can be stored in cpu not gpu?

For the pytorch script, the lm1b base model uses N_LAYER=18, D_MODEL=1024, D_INNER=4096 (about 0.36 billion parameters). After 500K training step, my test perplexity was 30.25. My work uses a memory compressed version of the Adam optimizer. Would you consider this test score unreasonable?
The test set perplexity which is 30.25 is got by the default pytorch script(run_lm1b_base script) only modified the gradient optimizer(a memory compressed version of the Adam optimizer)? Did you modify other hyper parameters?


Sticky iOS :hover states on ion-button

Bug Report
Ionic Info
Ionic:

   ionic (Ionic CLI)          : 4.1.1 (/usr/local/lib/node_modules/ionic)
   Ionic Framework            : @ionic/angular 4.0.0-beta.7
   @angular-devkit/core       : 0.7.5
   @angular-devkit/schematics : 0.7.5
   @angular/cli               : 6.1.5
   @ionic/ng-toolkit          : 1.0.8
   @ionic/schematics-angular  : 1.0.6

System:

   NodeJS : v10.9.0 (/usr/local/Cellar/node/10.9.0/bin/node)
   npm    : 6.4.0
   OS     : macOS High Sierra

Describe the Bug
When clicking on an ion-button on the device/simulator, (or in the browser with Mobile emulation on) will trigger the :hover state until clicking elsewhere in the window.
Meaning that the button remains set to opacity: .6;
Steps to Reproduce
Steps to reproduce the behavior:

Place an ion-button on a page
View on browser mobile-emulation, simulator, or on device
Click it

Related Code
https://stackblitz.com/edit/angular-ionic4-test-vgwruu
Expected Behavior
Button on device returns to opacity: 1; after clicking. More specifically the --opacity variable should
Additional Context
Possibly similar to https://github.com/ionic-team/ionic/issues/14934
It's probably a good idea to disable hover states on the device? But I opened a new issue as it seems this is a more specific scope of task

Fixed by @juanmiguelbesada !


Where to find the datasets?

I can't find the datasets at https://github.com/huggingface/datasets/tree/master/datasets, and I suspect they may have changed their names/structure (as in subj-> subjqa). Where can I find the version of datasets that you used?

Hi guillemram97, the dataset can be found at https://huggingface.co/gpt3mix. We have made our new movie review dataset public (rt20) as well.

There are sst2 and rt20 in that repository. Where can I find the other datasets?

We have plans to update more datasets in the future but we don't have a specific timeline. Meanwhile, you could prepare custom datasets referencing the data format.


Move util-appmacro to sbt as core-macros

This commit moves everything behind the old util-appmacro over to
sbt/sbt.
appmacro has been renamed as core-macros. It is indeed the project
that defines the main logic to manipulate macros, and defines interfaces
that are then implemented by main-settings. Because of this strong
relationship between these two modules, I find that they have to stay
together and be able to be modified in one commit. I've realised this
while hacking on the macro changes for the usability of sbt.
The reason for this change is because the logic of this module is really
tight to the implementation of sbt and, I would even say, essentially
define the sbt DSL.

This is not ready yet. Hold tight.

Last commit should make it ready.

The PR is missing the actual (pre-name) history that took place in sbt/sbt. I am guessing that directory specification needs util/appmacro.

The PR is missing the actual (pre-name) history that took place in sbt/sbt such as sbt/util@c95df46.

It isn't (wasn't) because that history is already here, given this is sbt/sbt: https://github.com/sbt/sbt/commit/1c22478ed
Having merged #3211 we now have multiple versions of the same history within the same repository; see 1c22's filter-branch mutilated twin: https://github.com/sbt/sbt/commit/087e386c9

Oh wow, that's sad 😢


FCPE fails to import

When trying to use FCPE as a f0 extractor the following error appears: [Errno 2] No such file or directory: 'exp/f0bce_test_R004_cu0\\config.yamI'
It's looking for a config.yaml file for the FCPE model, but this shouldn't be the case.

#38  was submitted to address this issue.

Thank you for your PR. I'll move the path to pretrain/fcpe after marge the PR.


[WIP] Applied email address validation in Provision virtual machines form

https://bugzilla.redhat.com/show_bug.cgi?id=1110649
Added a required_method and required_regex key to the miq_provision_dialogs_template.yaml
both under the :owner_email dialog entry.
Included a default expression that can be modified by an end-user to suit their tastes.

@syncrou This is looking good.  Also need to update the other dialogs in the product/dialogs/miq_dialogs directory that expose the :owner_email field with the new validation method and regex.

@gmcculloug - Made the changes to the other dialog templates.

@syncrou Here is a regex we use elsewhere in the product for email validation: https://github.com/ManageIQ/more_core_extensions/blob/master/lib/more_core_extensions/core_ext/string/formats.rb#L4.  We should update the dialogs to use this one.

@gmcculloug - Please Review

:+1:


Add native histogram version of objstore_bucket_operation_duration_seconds

I'd like to propose to add native histogram version of objstore_bucket_operation_duration_seconds so dependent projects can take advantage and migrate to native histograms. This would require bumping client_golang:
-       github.com/prometheus/client_golang v1.12.2
-       github.com/prometheus/common v0.36.0
+       github.com/prometheus/client_golang v1.17.0
+       github.com/prometheus/common v0.44.0

I can do the PR.
Out of scope: objstore_bucket_operation_transferred_bytes . Although that could be made into a native histogram with factor==2 (schema==0).

Let's do it, this nice upgrade has been long due 👍 What is the blocker for enabling native histograms for objstore_bucket_operation_transferred_bytes? We could limit the number of buckets if that's the concern.

Let's do it, this nice upgrade has been long due 👍
What is the blocker for enabling native histograms for objstore_bucket_operation_transferred_bytes? We could limit the number of buckets if that's the concern.

No blocker, I'm just trying to keep my scope in check, but then I'll do it as well!


Release 1.5.1

Please approve the release of zhmccli 1.5.1 to Pypi.
Main review point: Do we expect more bug fixes that should be included?

Coverage: 31.631% (+0.006%) from 31.625% when pulling e8bd40836e5547c8ffdf289dc305abaf792f394d on release_1.5.1 into feae4383e5430e2730baaef8a4cff17681624f21 on stable_1.5.

zhmcclient 1.7.0 is now the minimum version for zhmccli.


Unable to add generic connection to bot file

Project
Virtual Assistant
Description
Hi, I am trying to add the AAD connection to my bot file from powershell and I am getting "SyntaxError: Unexpected token \ in JSON at position 1".
I am running the following command (that I copied and pasted from https://github.com/Microsoft/AI/blob/master/solutions/Virtual-Assistant/docs/virtualassistant-createvirtualassistant.md and just updated the connection name)
msbot connect generic --name "Authentication" --keys "{\"Azure Active Directory v2\":\"Azure Active Directory v2\"}" --bot GGVADevMaster.bot --url "portal.azure.net"

To Reproduce

Ensure your bot file is unencrypted and it doesn't contain the generic connection for authentication.
Run the command specified above from powershell and you'll get:

Expected behavior
I would like to be able to add the connection from the command line as described in the documentation.
Additional context
As a workaround, I manually edited the bot file and added the following json fragment:
{
  "type": "generic",
  "configuration": { "Azure Active Directory v2": "Azure Active Directory v2" },
  "name": "Authentication",
  "url": "portal.azure.net"
}

Is this a bug? or am I doing something wrong?

I think the key here might be Powershell having different escape characters. I'll tyr it out and see if I can repro.

I am able to repro. It works correctly in command prompt and gives the error in PS. I tried the string several different ways and haven’t gotten it working yet in PowerShell.

K, thanks, it does also work for me from command prompt (I normally use PS).
Regarding PS, I tried the PS option (with variables) and I get "Missing URL" (probably something with the quotes also)

This issue provides a workaround for PS #191
I'll add this to known issues in the meantime.


Unit tests of HealthCheck failed, since current user does not have permissions to open ICMP socket

Health-check unit-tests requires elevated permission on current system, since it uses https://github.com/go-ping/ping
Can we have unit-tests run independently of current system (just mock tests and env) ?
16:41:58 === RUN   TestHealthChecker
16:41:58 Running Suite: Health Checker Suite
16:41:58 ===================================
16:41:58 Random Seed:<PHONE_NUMBER>
16:41:58 Will run 11 of 11 specs
16:41:58
16:41:58 Statistics when update is called with a sample space
16:41:58   should correctly compute the statistics
16:41:58   /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/statistics_test.go:19
16:41:58 ���
16:41:58 ------------------------------
16:41:58 Controller when a remote Endpoint is created
16:41:58   should start a Pinger and return the correct LatencyInfo
16:41:58   /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/healthchecker_test.go:125
16:41:58 I1214 16:41:50.094637  118946 healthchecker.go:90] CableEngine HealthChecker started with PingInterval: 3, MaxPacketLossCount: 4
16:41:58 I1214 16:41:50.100881  118946 healthchecker.go:140] CableEngine HealthChecker started pinger for CableName: "submariner-cable-west-192-68-1-20" with HealthCheckIP "<IP_ADDRESS>"
16:41:58 I1214 16:41:50.110789  118946 healthchecker.go:140] CableEngine HealthChecker started pinger for CableName: "submariner-cable-north-192-68-1-20" with HealthCheckIP "<IP_ADDRESS>"
16:41:58 ���
16:41:58 ------------------------------
16:41:58 Controller when a local Endpoint is created
16:41:58   should not start a Pinger
16:41:58   /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/healthchecker_test.go:153
16:41:58 I1214 16:41:50.216293  118946 healthchecker.go:90] CableEngine HealthChecker started with PingInterval: 3, MaxPacketLossCount: 4
16:41:58 ���
16:41:58 ------------------------------
16:41:58 Controller when a remote Endpoint is deleted
16:41:58   should stop the Pinger
16:41:58   /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/healthchecker_test.go:160
16:41:58 I1214 16:41:50.890831  118946 healthchecker.go:90] CableEngine HealthChecker started with PingInterval: 3, MaxPacketLossCount: 4
16:41:58 I1214 16:41:50.990906  118946 healthchecker.go:140] CableEngine HealthChecker started pinger for CableName: "submariner-cable-west-192-68-1-20" with HealthCheckIP "<IP_ADDRESS>"
16:41:58 ���
16:41:58 ------------------------------
16:41:58 Controller when a remote Endpoint is updated when the HealthCheckIP was changed
16:41:58   should stop the Pinger and start a new one
16:41:58   /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/healthchecker_test.go:183
16:41:58 I1214 16:41:51.104539  118946 healthchecker.go:90] CableEngine HealthChecker started with PingInterval: 3, MaxPacketLossCount: 4
16:41:58 I1214 16:41:51.110186  118946 healthchecker.go:140] CableEngine HealthChecker started pinger for CableName: "submariner-cable-west-192-68-1-20" with HealthCheckIP "<IP_ADDRESS>"
16:41:58 I1214 16:41:51.190896  118946 healthchecker.go:140] CableEngine HealthChecker started pinger for CableName: "submariner-cable-west-192-68-1-20" with HealthCheckIP "<IP_ADDRESS>"
16:41:58 ���
16:41:58 ------------------------------
16:41:58 Controller when a remote Endpoint is updated when the HealthCheckIP did not changed
16:41:58   should not start a new Pinger
16:41:58   /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/healthchecker_test.go:197
16:41:58 I1214 16:41:51.390876  118946 healthchecker.go:90] CableEngine HealthChecker started with PingInterval: 3, MaxPacketLossCount: 4
16:41:58 I1214 16:41:51.791195  118946 healthchecker.go:140] CableEngine HealthChecker started pinger for CableName: "submariner-cable-west-192-68-1-20" with HealthCheckIP "<IP_ADDRESS>"
16:41:58 ���
16:41:58 ------------------------------
16:41:58 Controller when a remote Endpoint is has no HealthCheckIP
16:41:58   should not start a Pinger
16:41:58   /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/healthchecker_test.go:207
16:41:58 I1214 16:41:52.402196  118946 healthchecker.go:90] CableEngine HealthChecker started with PingInterval: 3, MaxPacketLossCount: 4
16:41:58 I1214 16:41:52.413009  118946 healthchecker.go:104] HealthCheckIP ("") and/or CableName ("submariner-cable-west-192-68-1-20") for Endpoint "west-submariner-cable-west-192-68-1-20" empty - will not monitor endpoint health
16:41:58 ���
16:41:58 ------------------------------
16:41:58 Pinger when the IP is reachable
16:41:58   should periodically update the statistics
16:41:58   /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:54
16:41:58 I1214 16:41:52.902719  118946 pinger.go:85] Starting pinger for IP "<IP_ADDRESS>"
16:41:58 E1214 16:41:52.990811  118946 pinger.go:67] Unable to start pinger for IP "<IP_ADDRESS>": listen ip4:icmp : socket: operation not permitted
16:41:58
16:41:58 ��� Failure [0.789 seconds]
16:41:58 Pinger
16:41:58 /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:15
16:41:58   when the IP is reachable
16:41:58   /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:53
16:41:58     should periodically update the statistics [It]
16:41:58     /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:54
16:41:58
16:41:58     Timed out after 0.700s.
16:41:58     Expected
16:41:58         <*healthchecker.LatencyInfo | 0xc0004b6a50>: {
16:41:58             ConnectionError: "Failed to create the pinger for the remote endpoint IP \"<IP_ADDRESS>\": listen ip4:icmp : socket: operation not permitted ",
16:41:58             ConnectionStatus: "unknown",
16:41:58             Spec: {Last: "0s", Min: "0s", Average: "0s", Max: "0s", StdDev: "0s"},
16:41:58         }
16:41:58     not to equal
16:41:58         <*healthchecker.LatencyInfo | 0xc000505620>: {
16:41:58             ConnectionError: "Failed to create the pinger for the remote endpoint IP \"<IP_ADDRESS>\": listen ip4:icmp : socket: operation not permitted ",
16:41:58             ConnectionStatus: "unknown",
16:41:58             Spec: {Last: "0s", Min: "0s", Average: "0s", Max: "0s", StdDev: "0s"},
16:41:58         }
16:41:58
16:41:58     /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:47
16:41:58
16:41:58     Full Stack Trace
16:41:58     github.com/submariner-io/submariner/pkg/cableengine/healthchecker.glob..func1.4(0x5)
16:41:58     	/home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:47 +0x90
16:41:58     github.com/submariner-io/submariner/pkg/cableengine/healthchecker.glob..func1.5.1()
16:41:58     	/home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:55 +0x2e
16:41:58     github.com/onsi/ginkgo/internal/leafnodes.(*runner).runSync(0xc00052a480, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/leafnodes/runner.go:113 +0xb8
16:41:58     github.com/onsi/ginkgo/internal/leafnodes.(*runner).run(0xc00052a480, 0x3, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/leafnodes/runner.go:64 +0xcf
16:41:58     github.com/onsi/ginkgo/internal/leafnodes.(*ItNode).Run(0xc0005026c0, 0x163cf20, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/leafnodes/it_node.go:26 +0x64
16:41:58     github.com/onsi/ginkgo/internal/spec.(*Spec).runSample(0xc00032e690, 0x0, 0x163cf20, 0xc0003b3500)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/spec/spec.go:215 +0x5b5
16:41:58     github.com/onsi/ginkgo/internal/spec.(*Spec).Run(0xc00032e690, 0x163cf20, 0xc0003b3500)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/spec/spec.go:138 +0x101
16:41:58     github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).runSpec(0xc0001f5cc0, 0xc00032e690, 0x0)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/specrunner/spec_runner.go:200 +0x10f
16:41:58     github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).runSpecs(0xc0001f5cc0, 0x1)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/specrunner/spec_runner.go:170 +0x120
16:41:58     github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).Run(0xc0001f5cc0, 0xc000532f30)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/specrunner/spec_runner.go:66 +0x117
16:41:58     github.com/onsi/ginkgo/internal/suite.(*Suite).Run(0xc000410620, 0x7fabaa311128, 0xc000010100, 0x148cf5c, 0x14, 0xc000502380, 0x2, 0x2, 0x16773c0, 0xc0003b3500, ...)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/suite/suite.go:79 +0x586
16:41:58     github.com/onsi/ginkgo.RunSpecsWithCustomReporters(0x163db40, 0xc000010100, 0x148cf5c, 0x14, 0xc000502360, 0x2, 0x2, 0x2)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/ginkgo_dsl.go:229 +0x217
16:41:58     github.com/onsi/ginkgo.RunSpecsWithDefaultAndCustomReporters(0x163db40, 0xc000010100, 0x148cf5c, 0x14, 0xc0004a9718, 0x1, 0x1, 0x40c9e8)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/ginkgo_dsl.go:217 +0xad
16:41:58     github.com/onsi/ginkgo.RunSpecs(0x163db40, 0xc000010100, 0x148cf5c, 0x14, 0x212baf80364046)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/ginkgo_dsl.go:208 +0xf1
16:41:58     github.com/submariner-io/submariner/pkg/cableengine/healthchecker_test.TestHealthChecker(0xc000010100)
16:41:58     	/home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/healthchecker_suite_test.go:17 +0x96
16:41:58     testing.tRunner(0xc000010100, 0x151c818)
16:41:58     	/mnt/skynet-data/ocp-install/miniconda/envs/conda-test/go/src/testing/testing.go:909 +0xc9
16:41:58     created by testing.(*T).Run
16:41:58     	/mnt/skynet-data/ocp-install/miniconda/envs/conda-test/go/src/testing/testing.go:960 +0x350
16:41:58 ------------------------------
16:41:58 Pinger when the IP is not reachable
16:41:58   should mark a failure
16:41:58   /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:65
16:41:58 I1214 16:41:53.691735  118946 pinger.go:85] Starting pinger for IP "<IP_ADDRESS>"
16:41:58 E1214 16:41:53.692032  118946 pinger.go:67] Unable to start pinger for IP "<IP_ADDRESS>": listen ip4:icmp : socket: operation not permitted
16:41:58 ���
16:41:58 ------------------------------
16:41:58 Pinger when the pinger timeout expires
16:41:58   should continue to update the statistics
16:41:58   /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:82
16:41:58 I1214 16:41:53.702052  118946 pinger.go:85] Starting pinger for IP "<IP_ADDRESS>"
16:41:58 E1214 16:41:53.702149  118946 pinger.go:67] Unable to start pinger for IP "<IP_ADDRESS>": listen ip4:icmp : socket: operation not permitted
16:41:58
16:41:58 ��� Failure [4.189 seconds]
16:41:58 Pinger
16:41:58 /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:15
16:41:58   when the pinger timeout expires
16:41:58   /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:72
16:41:58     should continue to update the statistics [It]
16:41:58     /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:82
16:41:58
16:41:58     Timed out after 4.079s.
16:41:58     Expected
16:41:58         <*healthchecker.LatencyInfo | 0xc0004b7a40>: {
16:41:58             ConnectionError: "Failed to create the pinger for the remote endpoint IP \"<IP_ADDRESS>\": listen ip4:icmp : socket: operation not permitted ",
16:41:58             ConnectionStatus: "unknown",
16:41:58             Spec: {Last: "0s", Min: "0s", Average: "0s", Max: "0s", StdDev: "0s"},
16:41:58         }
16:41:58     not to equal
16:41:58         <*healthchecker.LatencyInfo | 0xc0002c8000>: {
16:41:58             ConnectionError: "Failed to create the pinger for the remote endpoint IP \"<IP_ADDRESS>\": listen ip4:icmp : socket: operation not permitted ",
16:41:58             ConnectionStatus: "unknown",
16:41:58             Spec: {Last: "0s", Min: "0s", Average: "0s", Max: "0s", StdDev: "0s"},
16:41:58         }
16:41:58
16:41:58     /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:47
16:41:58
16:41:58     Full Stack Trace
16:41:58     github.com/submariner-io/submariner/pkg/cableengine/healthchecker.glob..func1.4(0x3)
16:41:58     	/home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:47 +0x90
16:41:58     github.com/submariner-io/submariner/pkg/cableengine/healthchecker.glob..func1.7.3()
16:41:58     	/home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:83 +0x2e
16:41:58     github.com/onsi/ginkgo/internal/leafnodes.(*runner).runSync(0xc00052a960, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/leafnodes/runner.go:113 +0xb8
16:41:58     github.com/onsi/ginkgo/internal/leafnodes.(*runner).run(0xc00052a960, 0x3, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/leafnodes/runner.go:64 +0xcf
16:41:58     github.com/onsi/ginkgo/internal/leafnodes.(*ItNode).Run(0xc000502b40, 0x163cf20, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/leafnodes/it_node.go:26 +0x64
16:41:58     github.com/onsi/ginkgo/internal/spec.(*Spec).runSample(0xc00032e870, 0x0, 0x163cf20, 0xc0003b3500)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/spec/spec.go:215 +0x5b5
16:41:58     github.com/onsi/ginkgo/internal/spec.(*Spec).Run(0xc00032e870, 0x163cf20, 0xc0003b3500)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/spec/spec.go:138 +0x101
16:41:58     github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).runSpec(0xc0001f5cc0, 0xc00032e870, 0x0)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/specrunner/spec_runner.go:200 +0x10f
16:41:58     github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).runSpecs(0xc0001f5cc0, 0x1)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/specrunner/spec_runner.go:170 +0x120
16:41:58     github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).Run(0xc0001f5cc0, 0xc000532f30)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/specrunner/spec_runner.go:66 +0x117
16:41:58     github.com/onsi/ginkgo/internal/suite.(*Suite).Run(0xc000410620, 0x7fabaa311128, 0xc000010100, 0x148cf5c, 0x14, 0xc000502380, 0x2, 0x2, 0x16773c0, 0xc0003b3500, ...)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/suite/suite.go:79 +0x586
16:41:58     github.com/onsi/ginkgo.RunSpecsWithCustomReporters(0x163db40, 0xc000010100, 0x148cf5c, 0x14, 0xc000502360, 0x2, 0x2, 0x2)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/ginkgo_dsl.go:229 +0x217
16:41:58     github.com/onsi/ginkgo.RunSpecsWithDefaultAndCustomReporters(0x163db40, 0xc000010100, 0x148cf5c, 0x14, 0xc0004a9718, 0x1, 0x1, 0x40c9e8)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/ginkgo_dsl.go:217 +0xad
16:41:58     github.com/onsi/ginkgo.RunSpecs(0x163db40, 0xc000010100, 0x148cf5c, 0x14, 0x212baf80364046)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/ginkgo_dsl.go:208 +0xf1
16:41:58     github.com/submariner-io/submariner/pkg/cableengine/healthchecker_test.TestHealthChecker(0xc000010100)
16:41:58     	/home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/healthchecker_suite_test.go:17 +0x96
16:41:58     testing.tRunner(0xc000010100, 0x151c818)
16:41:58     	/mnt/skynet-data/ocp-install/miniconda/envs/conda-test/go/src/testing/testing.go:909 +0xc9
16:41:58     created by testing.(*T).Run
16:41:58     	/mnt/skynet-data/ocp-install/miniconda/envs/conda-test/go/src/testing/testing.go:960 +0x350
16:41:58 ------------------------------
16:41:58 Pinger when the pinger is stopped
16:41:58   should no longer update the statistics
16:41:58   /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:92
16:41:58 I1214 16:41:57.891238  118946 pinger.go:85] Starting pinger for IP "<IP_ADDRESS>"
16:41:58 E1214 16:41:57.891487  118946 pinger.go:67] Unable to start pinger for IP "<IP_ADDRESS>": listen ip4:icmp : socket: operation not permitted
16:41:58
16:41:58 ��� Failure [0.211 seconds]
16:41:58 Pinger
16:41:58 /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:15
16:41:58   when the pinger is stopped
16:41:58   /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:87
16:41:58     should no longer update the statistics [It]
16:41:58     /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:92
16:41:58
16:41:58     Timed out after 0.200s.
16:41:58     Expected
16:41:58         <*healthchecker.LatencyInfo | 0xc0003fb8f0>: {
16:41:58             ConnectionError: "Failed to create the pinger for the remote endpoint IP \"<IP_ADDRESS>\": listen ip4:icmp : socket: operation not permitted ",
16:41:58             ConnectionStatus: "unknown",
16:41:58             Spec: {Last: "0s", Min: "0s", Average: "0s", Max: "0s", StdDev: "0s"},
16:41:58         }
16:41:58     not to equal
16:41:58         <*healthchecker.LatencyInfo | 0xc0004b7ce0>: {
16:41:58             ConnectionError: "Failed to create the pinger for the remote endpoint IP \"<IP_ADDRESS>\": listen ip4:icmp : socket: operation not permitted ",
16:41:58             ConnectionStatus: "unknown",
16:41:58             Spec: {Last: "0s", Min: "0s", Average: "0s", Max: "0s", StdDev: "0s"},
16:41:58         }
16:41:58
16:41:58     /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:47
16:41:58
16:41:58     Full Stack Trace
16:41:58     github.com/submariner-io/submariner/pkg/cableengine/healthchecker.glob..func1.4(0x3)
16:41:58     	/home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:47 +0x90
16:41:58     github.com/submariner-io/submariner/pkg/cableengine/healthchecker.glob..func1.8.2()
16:41:58     	/home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:93 +0x52
16:41:58     github.com/onsi/ginkgo/internal/leafnodes.(*runner).runSync(0xc00052ab40, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/leafnodes/runner.go:113 +0xb8
16:41:58     github.com/onsi/ginkgo/internal/leafnodes.(*runner).run(0xc00052ab40, 0x3, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/leafnodes/runner.go:64 +0xcf
16:41:58     github.com/onsi/ginkgo/internal/leafnodes.(*ItNode).Run(0xc000502d40, 0x163cf20, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/leafnodes/it_node.go:26 +0x64
16:41:58     github.com/onsi/ginkgo/internal/spec.(*Spec).runSample(0xc00032e960, 0x0, 0x163cf20, 0xc0003b3500)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/spec/spec.go:215 +0x5b5
16:41:58     github.com/onsi/ginkgo/internal/spec.(*Spec).Run(0xc00032e960, 0x163cf20, 0xc0003b3500)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/spec/spec.go:138 +0x101
16:41:58     github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).runSpec(0xc0001f5cc0, 0xc00032e960, 0x0)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/specrunner/spec_runner.go:200 +0x10f
16:41:58     github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).runSpecs(0xc0001f5cc0, 0x1)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/specrunner/spec_runner.go:170 +0x120
16:41:58     github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).Run(0xc0001f5cc0, 0xc000532f30)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/specrunner/spec_runner.go:66 +0x117
16:41:58     github.com/onsi/ginkgo/internal/suite.(*Suite).Run(0xc000410620, 0x7fabaa311128, 0xc000010100, 0x148cf5c, 0x14, 0xc000502380, 0x2, 0x2, 0x16773c0, 0xc0003b3500, ...)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/internal/suite/suite.go:79 +0x586
16:41:58     github.com/onsi/ginkgo.RunSpecsWithCustomReporters(0x163db40, 0xc000010100, 0x148cf5c, 0x14, 0xc000502360, 0x2, 0x2, 0x2)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/ginkgo_dsl.go:229 +0x217
16:41:58     github.com/onsi/ginkgo.RunSpecsWithDefaultAndCustomReporters(0x163db40, 0xc000010100, 0x148cf5c, 0x14, 0xc0004a9718, 0x1, 0x1, 0x40c9e8)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/ginkgo_dsl.go:217 +0xad
16:41:58     github.com/onsi/ginkgo.RunSpecs(0x163db40, 0xc000010100, 0x148cf5c, 0x14, 0x212baf80364046)
16:41:58     	/home/jenkins/go/pkg/mod/github.com/onsi/ginkgo@v1.14.2/ginkgo_dsl.go:208 +0xf1
16:41:58     github.com/submariner-io/submariner/pkg/cableengine/healthchecker_test.TestHealthChecker(0xc000010100)
16:41:58     	/home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/healthchecker_suite_test.go:17 +0x96
16:41:58     testing.tRunner(0xc000010100, 0x151c818)
16:41:58     	/mnt/skynet-data/ocp-install/miniconda/envs/conda-test/go/src/testing/testing.go:909 +0xc9
16:41:58     created by testing.(*T).Run
16:41:58     	/mnt/skynet-data/ocp-install/miniconda/envs/conda-test/go/src/testing/testing.go:960 +0x350
16:41:58 ------------------------------
16:41:58
16:41:58 JUnit path was configured: /home/jenkins/workspace/debug_job/subm_pkg_junit.xml
16:41:58
16:41:58 JUnit report was created: /home/jenkins/workspace/debug_job/subm_pkg_junit.xml
16:41:58
16:41:58
16:41:58 Summarizing 3 Failures:
16:41:58
16:41:58 [Fail] Pinger when the IP is reachable [It] should periodically update the statistics
16:41:58 /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:47
16:41:58
16:41:58 [Fail] Pinger when the pinger timeout expires [It] should continue to update the statistics
16:41:58 /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:47
16:41:58
16:41:58 [Fail] Pinger when the pinger is stopped [It] should no longer update the statistics
16:41:58 /home/jenkins/go/src/github.com/submariner-io/submariner/pkg/cableengine/healthchecker/pinger_test.go:47
16:41:58
16:41:58 Ran 11 of 11 Specs in 8.109 seconds
16:41:58 FAIL! -- 8 Passed | 3 Failed | 0 Pending | 0 Skipped
16:41:58 --- FAIL: TestHealthChecker (8.40s)
16:41:58 FAIL
16:41:58 coverage: 79.4% of statements
16:41:58 FAIL	github.com/submariner-io/submariner/pkg/cableengine/healthchecker	8.998s
16:41:58 ?   	github.com/submariner-io/submariner/pkg/cableengine/healthchecker/fake	[no test files]

The Pinger wraps the ping lib so the tests use the lib to test the interaction between the two. If we used a mock then we'd be making assumptions about the real implementation which wouldn't be ideal. So either the user or system needs the proper permissions as outlined in https://github.com/go-ping/ping.  The Dapper image is setup properly - it is assumed folks would normally run make unit as is done in CI. I can do a precheck and skip the tests with a warning.

Right, but this is more of a functional test (needs some level of integration with the system).
I would disable this test, or just detect if a permission error happened, so then it's skipped.

https://github.com/submariner-io/submariner/pull/1034


Add note about different between helpers

Alternative wording to #1726 ping @myronmarston @sdhull (@samphippen)

This works too ¯\_(ツ)_/¯


Play/Pause button missing, cannot pause/resume media with Panasonic Viera TV's

Home Assistant release (hass --version):
0.54.0
Python release (python3 --version):
3 (Hass.io Default)
Component/platform:
media_player/panasonic_viera
Description of problem:
Play/Pause button missing, cannot pause/resume media
Expected:
Visible Play/Pause button, ability to pause/resume media
Problem-relevant configuration.yaml entries and steps to reproduce:
media_player:
  - platform: panasonic_viera
  - host: IP_TO_TV
  - mac: MAC_OF_TV
 - name: "My TV"

Own Viera branded TV by Panasonic (Reproduced on TX-32AS520E)
Turn on TV
Notice absence of play/pause button

Additional info:
Calling the media_player service media_play_pause will actually pause and resume the content on the TV.

Seems to not be just isolated to the Panasonic TV component. My roku also seems to have the play/pause button missing as of 0.54

Hello,
I have the same issue with the version 0.58.0.
Also, The state is always "ON", I can't set the state to "OFF".
Thank you


Corpses that never decay

Corpses that are loaded via Inanimate::load and should de-populate don't fade away. This is likely due to how we're counting down using timestamps as opposed to a monotonically decreasing counter - or how we're generally managing it via timestamps. Because time is weird.

Well, pretty sure this was due to corpses not having a destruction timer set on them when they were first created. Think this should fix it.


Customize loading spinner position and appereance

Screenshot

Description
This spinner (loader) cannot be customized. It's always positioned in the middle of iframe, so user on our page sometimes don't see something is happenning if the iframe is in lower part and they see just part of is (like a grey rectangle.)
We cannot apply styles on it, because they are loaded with the content itself after the spinner dissapear.
Design input
I suggest the possibility to reposition the spinner (set the top/left percent position) OR display multiple spinners OR add custom style to the spinner OR modify directly its html. Also it would be great to be able to upload custom spinner.

All of the things you're asking for here could be contributed in a PR as feature additions (positioning improvements, additional classes needed for CSS, or even a customizable path in the config for a custom image, as we do in with the app logo). I'll move this to an Ideas thread, since it belongs there more so than as an Issue/bug.


APEXMALHAR-2320 #resolve #comment use SerializationBuffer implement F…

…SWindowDataManager.toSlice()

@davidyan74 Please review

@davidyan74 Please review

LGTM. @chandnisingh can you also review? I'll merge if this looks good to you.

z

@chandnisingh @davidyan74 Applied comments. Please review

I'm ok with the change. @chandnisingh any other concerns?

@brightchen  can you quickly rebase this with the current master? I'll merge it.

@davidyan74 Rebased


Introduce trunk.io into repo

With the introduction of trunk.io, formatting and linting of files within the repository is handled by one single source. This tool will reduce the overhead related to formatting files during development (via CLI or IDE extension), as well as during git commits via the integrated git-hooks feature.
There's also git actions available for trunk, enforcing correct formatting and linting throughout the repo. To run trunk on all non-diff files, run trunk check -a.
This is more a want than a need. Feedback is welcome!

Hi Topher097,
I really appreciate the contribution, it's always interesting to see what tools are out there.
Unfortunately due to the nature of this repository being almost entirely nix, I would prefer to use the available options within the nix ecosystem to accomplish this job. I prefer to use the built in nix fmt command that is enabled by the root flake. Nix makes it quite easy to use in a github action workflow as well without hiding or abstracting any of the steps. Linting is handled by stylix in a similar if not less formal way.
I am excited to see where trunk.io can fit into my workflows, but it likely won't be here.
I hope you have a great weekend!
Eric


Fix to base_prediction for gemm and perf_tree

Closes #393.

The only way to test it is to have some CI with GPU which we don't have at the moment unfortunately 😞

The only way to test it is to have some CI with GPU which we don't have at the moment unfortunately 😞

Oh yah.  That.  :-P


chore: Included githubactions in the dependabot config

This should help with keeping the GitHub actions updated on new releases. This will also help with keeping it secure.
Dependabot helps in keeping the supply chain secure https://docs.github.com/en/code-security/dependabot
GitHub actions up to date https://docs.github.com/en/code-security/dependabot/working-with-dependabot/keeping-your-actions-up-to-date-with-dependabot
https://github.com/ossf/scorecard/blob/main/docs/checks.md#dependency-update-tool
Signed-off-by: naveen<EMAIL_ADDRESS>

I'm absolutely not going to add dependabot to this project. I think it's destructive for open source projects and I don't want anything to do with it. I'm open to an alternative, like renovate, that is more prudent about when it suggests updates.
Please stop sending PRs to this project without discussing the change first in an issue or in the project chat at https://chat.asciidoctor.org. Thanks.

I think it's destructive for open source projects

I want to clarify my stance. Dependabot has routinely flooded open source projects with PRs that generate noise and drown out real contributions, clutter up the PR list with a plethora of boilerplate entries, drive contributors away or forces them to turn off notifications to avoid the PR spam, and soak up the limited time of maintainers on chores that rarely improve the state of the project. In other words, the whole focus on the project ends up shifting to tweaking version numbers. I hate that this is happening in OSS, and I loathe Dependabot for it. And the justification for those changes is rarely more than the fact that the version number increased by one digit. Using an fixed version is not inherently insecure. There has to be a legitimate justification for the upgrade, and I think that upgrade can be handled in a much more responsible way than to pummel the project with automated PRs.

This should help with keeping the GitHub actions updated on new releases.

We're already using the recommended major version tag syntax so that GitHub Actions always uses the latest release of the major version line.
uses: actions/checkout@v2

and
uses: ruby/setup-ruby@v1


[aes] pad fragments before decrypting

IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information

ADD DESCRIPTION HERE
Fixes # Padding of encrypted data for AES /CBC  mode.
Few hls links were showing errors Data must be padded to 16 byte boundary in CBC mode .
This bug was previously fixed in a previous version, but somehow the fix got removed in updates.
Template

Before submitting a pull request make sure you have:

[x] At least skimmed through contributing guidelines including yt-dlp coding conventions
[x] Searched the bugtracker for similar pull requests
[x] Checked the code with flake8 and ran relevant tests

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:

[x] I am the original author of this code and I am willing to release it under Unlicense
[ ] I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

[ ] Fix or improvement to an extractor (Make sure to add/update tests)
[ ] New extractor (Piracy websites will not be accepted)
[x] Core bug fix/improvement
[ ] New feature (It is strongly recommended to open an issue first)

This was originally attempted in https://github.com/yt-dlp/yt-dlp/pull/1298 and then reverted since it was giving wrong decrypted data. I don't remember the details, but @shirt-dev should know more


[Feature] xrc wxSplitterWindow code generator [sf#8]

Reported by qwelnor on 2003-05-20 12:31 UTC
please implement wxSplitterWindow XRC generator.
wxSplitterWindow XRC resource is now implemented in
current (CVS) version of wxWindows library.

Commented by agriggio on 2003-05-22 11:22 UTC
Logged In: YES
user_id=375945
added, but not tested (I haven't the CVS version at the
moment), although it should work. Tell me if I'm wrong
Alberto

Commented by qwelnor on 2003-05-23 06:59 UTC
Logged In: YES
user_id=764770
It now seems to be working though I did not tested all the
properties wxSplitterWindow has.


N_m3u8DL-CL it's duplicating the movie length

Too many days I go I was trying to download some videos from Amazon but the downloader had been duplicating the movie length for no reason.  For example this movie:

Its length is approximately 1h52m18s but when I paste the .mpd file to N_m3u8DL-CL its given me a wrong timing (length) like this:

Can you please fix this error as soon as you can?

Same issue #503
Download artifacts from here: https://github.com/nilaoda/N_m3u8DL-CLI/actions/runs/1202972652

Same issue #503
Download artifacts from here: https://github.com/nilaoda/N_m3u8DL-CLI/actions/runs/1202972652

Thank you so much bro, now it works properly.


Cant install addon

hello im trying to install your addon,im running hass.io 0.95.4,HassOS 2.12 on raspberry pi 3b+,when i try to install it doenst work,thanks for your work

this on log system:
19-07-10 21:28:41 INFO (SyncWorker_5) [hassio.docker.interface] Pull image mgrayson/armhf-risco-hass-bridge tag 0.1.
19-07-10 21:28:42 ERROR (SyncWorker_5) [hassio.docker.interface] Can't install mgrayson/armhf-risco-hass-bridge:0.1 -> 404 Client Error: Not Found ("pull access denied for mgrayson/armhf-risco-hass-bridge, repository does not exist or may require 'docker login'").

I could be wrong but i think it's a custom component, as opposed to an add on ?

It's an add-on, i installed it successful, I am using hassio on HassOs

I currently dont have a ARM build (needed to run on a pi). You can manually pull the code and build a container in the short term.

I currently dont have a ARM build (needed to run on a pi). You can manually pull the code and build a container in the short term.

Damn it, now i've to learn how to do that :D

Let me take a look over the weekend and see if I can push a build for you

is it also possible to make this a custom componennt instead of an add-on ?

You're welcome to fork the repo and give that a try

well, i have no idea where to start :) , not a developer :)

same problem here... trying  to install the add-on on hass.io:
Can't install mgrayson/armhf-risco-hass-bridge:0.1 -> 404 Client Error: Not Found ("manifest for mgrayson/armhf-risco-hass-bridge:0.1 not found").
thx

it would be nice, to have a working add-on on ARM :)


[Laravel 4] Creating user with Permissions is throwing InvalidArgumentException

Hi,
I'm having a little bit of trouble while creating a user and assigning permissions.
When creating the user i get this exception
InvalidArgumentException: Invalid value [1] for permission [superuser] given.

The permissions array is this
array('superuser' => '1', 'admin' => '1')

I'm creating the user like this
$inputs = Input::except('csrf_token', 'password_confirmation', 'groups');
$user = Sentry::getUserProvider()->create($inputs)

But if i use the example on the docs/users/create it works..

Hi guys,
This may be due permissions,
try by using unset before assigning value , like below
unset($user->permissions );
$user->permissions = array('superuser' => 0, 'admin' => 0);
Let me know if you still getting this error or if it worked for you, or try few more sort of thing as assigning null, array()...


feat(useBoolean): new function

Can you share some use cases on this? This might be too simple that can be done without it.

Like this useToggle. It can be used on button switches. And just for convenience.

I prefer the interface like const [on, toggle] = useToggle(true) just like react-use. And since it's pretty easy to get/set in Vue, I think just having the toggle function is quite enough, get() / set() feels a bit overdo.

Yeah, but I am thinking that useCounter is more like a demo utils rather than something that will be used in the real world 😅

I'd prefer useToggle as it gives the sense that it's used for creating toggle functions easily. What do you think?

OK, useBoolean is a bit strange 😂

Thanks!


Add physical_range="per-channel" for EDF export

Fixes #12493 by adding physical_range="per-channel". The default behavior remains physical_range="auto", which sets the physical range per channel type. However, in some cases where channels vary wildly in their ranges (mainly due to different offsets), which is often the case if the amplifier used no DC HP filter (e.g. Biosemi), setting individual physical ranges per channel ensures that each channel uses the maximum resolution afforded by the EDF format (only 16 bits). This seems to be perfectly compatible with the EDF standard (please correct me if I'm wrong), but I've added a note that some tools might be incompatible with such EDF files.

Done @mscheltienne. BTW, LMK if "per-channel" follows MNE conventions, or if "per_channel" would be better (or if you have a better term).

apply_function has a param "channelwise". That would avoid the question of whether to use hyphen or underscore. Off the top of my head IDK if we're consistent about that for multi word special string param values

Maybe let's go with the str channelwise to match that argument name, but I would be against adding a new parameter to the function.
But no strong feelings either way.

Maybe let's go with the str channelwise to match that argument name, but I would be against adding a new parameter to the function.

agreed; sorry my last message wasn't clear but i did mean using the string, not adding a separate param

Thanks @cbrnr! I will definitely use this in my EDF exports!

I'd only use this when you really need it though, because it seems like some programs (EEGLAB?) cannot properly handle EDF files with individual channel ranges. So basically, whenever you have zero-mean signals, you don't need it and you can just use "auto".


Check Context Managers Capabilities for In-Line Decorators

Context managers (with) can serve as a bridge between in-line decorators' call. Check feasibility, till then implementing an interface to bridge the gaps between the same.

Helpful Links: SO-Q9213600.


Event is not triggered with built Electron App(Macos)

When I launch the app at development mode. All thing is ok.  After I build the App, Event is not triggered
Expected Behavior
The event should be triggered
Current Behavior
The event is not triggered with built Electron App
Possible Solution
: (
Steps to Reproduce (for bugs)
Your Environment

Version used: 0.6.5
Electron: 5.0.11
Macos: 10.14.6

After approving the system rights, Open the app again, the event is triggered.  but every time open the app,  System freezes 2 - 3 seconds.   like this https://github.com/wilix-team/iohook/issues/178


clarify training output log of textpredictor

Job PR-1429-3 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-1429/3/index.html


validation-test: mark test as XFAIL

TBD generation is not constrained to Darwin and it trips on the linker
synthetic __ImageBase.    This should
temporarily allow us to enable validation tests on Windows.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@swift-ci please test

@swift-ci please test macOS platform

Build failed
Swift Test OS X Platform
Git Sha - 3cefb7b3f7ec5bf7fb1ca3c569e7bfbc23c00a79

@compnerd I will restart macOS testing in few.

@swift-ci please test macOS platform


Publish containers to dockerhub with "master" tag

Codecov Report
Base: 66.61% // Head: 66.59% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (87fd224) compared to base (45cfc24).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #732      +/-   ##
==========================================
- Coverage   66.61%   66.59%   -0.03%
==========================================
  Files          87       87
  Lines       12771    12771
==========================================
- Hits         8508     8505       -3
- Misses       4263     4266       +3

Impacted Files
Coverage Δ

fedimint-server/src/net/peers.rs
91.40% <0.00%> (-0.27%)
:arrow_down:

fedimint-server/src/net/connect.rs
94.94% <0.00%> (-0.26%)
:arrow_down:

client/client-lib/src/lib.rs
85.92% <0.00%> (-0.14%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[BACKEND] Remove workarounds for 3d shapes of SharedMemoryObject

Is there something that can be tested? Or is this NFC?

Is there something that can be tested? Or is this NFC?

Existing tests can guarantee the correctness. I'm fixing it now.

It's not very "NFC" because I will change some interfaces to SharedMemoryObject


Update to ocaml-git > 3.2.0

Yes, apparently it's that simple.

Or not :-) You'll need to update the opam-repo checkout hash in the Dockerfile so that the new library is found in the image

pushed to live-engine to test


Boom Table 1.4.0 does not work with Grafana 7.1.5 (Windows)

I just updated the Grafana plugin Boom Table from version 1.2.0 to 1.4.0. But the table shows really nothing. Version 1.2.0 works fine  with Grafana 7.1.5. Can you please fix this version?
Kind regards, Marc Wagner

Hello,
Same issue here, grafana version : grafana-7.1.5. Version 1.4.0 dosent work so i downgrade to 1.3.0.
Thanks

Any news on that?
We were facing the same issue (No data values) with version 1.4 and Grafana 7.2.1.
We had to downgrade the plugin to version 1.3.0 to make it work with Grafana 7.


syntax error/exception not shown in notebook

I just put this code in my notebook '(if (=1 1) "true" "false")'.
Observed:
On my terminal, the output was "Unable to resolve symbol =1", but notebook didn't show any error output.
Expected:
Notebook output to show error/trace/exception

Thanks @codinguncut, there was a bug that was sending back an 'ok' message when there was an exception. I fixed that and we can actually see the exceptions now.


Oculus 2 issues on boilerplate example

I tried the glitch example on oculus browser and found this:
-When movement mode activated I cant rotate my rig with right stick
-When using hand tracking, after some time I get a black screen, I still listen audio, when I click menu button on left controller I can see the site on the oculus browser and turn VR again and console is showing this:
aframe-extras.controls.min.js:1 Uncaught TypeError: Cannot read properties of null (reading 'mapping')
at i.getJoystick (aframe-extras.controls.min.js:1:17649)
at i.isRotationActive (aframe-extras.controls.min.js:1:15760)
at i.updateRotation (aframe-extras.controls.min.js:1:15857)
at i.tick (aframe-extras.controls.min.js:1:15149)
at HTMLElement.value (a-scene.js:739:34)
at HTMLElement.value (a-scene.js:789:36)
at bind.js:12:17
at onAnimationFrame (three.js:18890:1)
at XRSession.onAnimationFrame (three.js:9460:1)
Also im trying to implement boilerplate example into my flat VR project, im using aframe-chromakey-material.min.js but its not working, I can hear the audio but video doesn't show
And finally, is it necessary to activate any flags on oculus browser? or should I leave it as default
Thank you

When movement mode activated I cant rotate my rig with right stick

This was fixed in

https://github.com/n5ro/aframe-extras/pull/373

When using hand tracking, after some time I get a black screen, I still listen audio, when I click menu button on left controller I can see the site on the oculus browser and turn VR again and console is showing this:

This was fixed in

https://github.com/n5ro/aframe-extras/pull/385

Look at #7 for the latest urls to use.
I don't know about aframe-chromakey-material, you probably want to create an issue with a reproducible example on their repository if you didn't.

Thanks @vincentfretin, when I get time I will update this example to have the correct URLs. Right now between new baby and job I am a little swamped.

No worries, even if you're a little swamped, you were quite reactive merging my PRs :D  Thanks for that.
Yeah you should wait that I debug and fix the issues I found with gamepad-controls before merging the changes of #7. I'll keep updating the PR if I do other fixes anyway. People can just get the changes and modify their glitch on their own.

You can close.


Update spark.adoc

Thank you for submitting a pull request!
Please make sure you have signed our Contributor License Agreement (CLA).
We are not asking you to assign copyright to us, but to give us the right to distribute your code without restriction. We ask this of all contributors in order to assure our users of the origin and continuing existence of the code.
You only need to sign the CLA once.

[x] I have signed the Contributor License Agreement (CLA)

Fixed small typo

CI failure looks like an issue with some unrelated tests failing. LGTM.

Cherry picked to master branch. Thanks for the PR!


Remove old packages

As an example, highlight-80+-mode and clojure-test-mode don't appear to have been in melpa for quite some time and have been deprecated a long while ago.

Fixed in e1a4e0b9a4d7873d1278ea013ee3f31e035a3287 and 3bb4c9df6d5b5ab8e1335df8cf2cf5afc0e69d17


BrowserKit not available on clean Silex installation

Hi all,
this afternoon while bootstrapping a new project I've started writing acceptace/functional test cases and got this error: PHP Fatal error:  Class 'Symfony\Component\BrowserKit\Client' not found in /root/projects/opengrid/vendor/symfony/http-kernel/Client.php on line 30
I've started to dive deep into the issue and the only way I managed to get it sorted is by manually requiring "symfony/browser-kit": "~2.7|3.0.*" as a require dependency in my compose.json.
It seems that out of the box it's impossible to write functional test cases (and use WebTestCase) for Silex. browser-kit is listed as a dev dependency for Silex, could this be the issue? If that's the case, isn't more appropriate to list it in require rather than require-dev as it is required to write production test cases for anyone using Silex?

Well, you can use other tools than BrowserKit to write your tests depending on your preference (even if the example shown in the doc describe the BrowserKit usage). This is why it is not set as a required dependency. This is the same reason that twig is not a required dependency: even though there is a builtin integration for Twig, you are free not to use it and use a different tool instead.
Btw, the documentation page about the WebTestCase mentions this need: http://silex.sensiolabs.org/doc/testing.html#webtestcase

My bad for missing the highlight from the docs. That would have saved me some time :)
Other than that, it's true that you might want to use something different from BrowserKit but I still think that it should be part of silex given how tight WebTestCase is with it. If I decide to use PHPSpec for example, I do expect to include whatever additional package to make my test run. On contrary, I would not expect to include something to use the base test class shipped with the project.
Clearly, this is just my take on it and I hope it helps.


[Beginner][Document]Add v2.3.0 release note

https://github.com/OpenTenBase/OpenTenBase/issues/8
Modify 2.3.0.md
Add 2.3.0-en.md
Add 2.3.0-release-note.txt in OpenTenBase:
https://github.com/OpenTenBase/OpenTenBase/pull/53

@bartdong done

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Switch sha1 calculations done by rust sha1 crate to openssl

I was reading on Discord that the reason for switching to the OpenSSL SHA-1 implementation is because of the issue of the RustCrypto crate not support ASM on some platforms, notably MSVC, which has a noticeable impact on performance.
Hopefully this can help: https://github.com/RustCrypto/hashes/pull/450.

Thanks!
Truth to be told, I don't know if the OpenSSL SHA1 is making any performance difference on Windows. The inline ASM will certainly solve this. I was looking at how to implement the SHA1 in inline ASM but decided it was slightly beyond the scope of what I wanted to attempt right now.


Use PPR

Description
closes #88
Type of Change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

PPR does not seem to work yet for pages that are fully dynamic, the /issues page for ex, throws a 500 error.
I'll open a PR on nextjs repo for that.


Provide a circuit-breaker in the case that the consumer falls excessively behind producers

Kafka partitions have a limited buffer, and a well maintained Kafka environment will have controls over the size of that buffer - it will not be infinite (limited by time and/or size).
Unlike traditional queuing systems, Kafka does not have the concept of a "queue full" condition, or even the concept of consuming messages. It simply tracks the offsets that different consumers have seen on a continual stream of messages.
This means that if your consumers fall too far behind your producers, and a size-based log is configured, then Kafka will discard messages in-flight.
In Ethconnect there's currently no feedback when this happens. The messages are just lost. This is problematic for applications that are relying on Ethconnect to reliably stream all their transactions in - fire&forget style. If they overrun the input of messages, they can end up with missing receipts.
So this issue tracks a new feature enhancement, to provide an option that causes the sending side of Ethconnect, to have a background task running to monitor the gap between the messages being sent, and the offset being consumed.
The logic proposed is pretty simple:

Before sending a message, after the payload has been constructed, we call the circuit breaker:

We provide the size of the []byte that will be sent

The circuit breaker keeps track of the average size of all these requests
The circuit breaker regularly polls Kafka to check how things are looking (configurable interval - 1 min etc.)

Uses the consumer interface to query partitions and high water marks:

https://pkg.go.dev/github.com/Shopify/sarama#NewConsumerFromClient

Uses the offset manager interface to query consumer group offsets:

https://pkg.go.dev/github.com/Shopify/sarama#NewOffsetManagerFromClient

Requires the safe buffer size to be passed in as a configuration parameter

Complex to query this, and should not be the full size because there's estimation involved
Example would be if a 100MB Kafka retention is configured, then the config would be set with a 75MB safe buffer

Uses the size estimation combined with the gap between the HWM and NextOffset for the consumer group

Estimates the amount of data in the buffer

Always logs this, to give a running commentary in the logs of the offset gap
Closes the circuit breaker if there's an excessive gap

After a bunch of prototyping, it seems like the route of having a separate consumer using the above approach has a lot of both code and runtime overhead.
The circuit breaker would have to have its own Consumer on each partition, to be able to query the high water marks. This means both code complexity, and an extra burden on the Kafka brokers.
Given that the overwhelmingly most common pattern today is that both the consumer and producer run in the same Go process, I will be changing the coding for this first implementation of the feature such that the consumer updates the circuit breaker stats directly as it is running. Based on its consumption from Kafka.


TestStackdriverRbacTCPDryRun flake

cc @kyessenov @lei-tang

It's not a flake but caused by https://github.com/envoyproxy/envoy/issues/22583.

Should be fixed by https://github.com/envoyproxy/envoy/pull/30807.


powerpoint autoshapes

Hello,
is there is any way of saving an autoshape as a jpeg file outside or if you know a way to do it? I can see the xml properties of it but I am not sure how to generate the autoshapes after that.
regards,
Gaurav

Not to my knowledge. This would require a renderer of some type. It's not inconceivable that someone would write such a thing, but rendering is outside the scope of python-pptx.


chore: add info messages to solc install/compile

Add informational messages to solc installation and compilation.
The compilation of a project could give the appearance of a hanging program because of downloading and installing solc. Informational messages allow the user to know what's happening and why it might take more than expected.

@mattsse -- The reason I made the contributions here is that all these steps are exposed via a single function call in the forge build, as far as i understood it.
I agree with your approach.  Let me riff on that as it is on the edge of my rust understanding.

@mattsse agree on the hook for logging to stdout, good idea.


Reproducible builds

Description
To make sure releases, checksums and signatures are reproducible, make some of the following modifications listed in https://goreleaser.com/customization/build/#reproducible-builds
Acceptance criteria

[ ] Read and implement gorelease reproducible buils configuration

Complexity: 1

Oh ! I see that I implemented (accidentally) the following :
"Modify mod_timestamp: by default this is empty string, set to {{.CommitTimestamp}} or a constant value instead."
So probably yes it fixes #15


Merge 3.0.x

👋 any chance this might be getting patched in 2.x ?
Thank you!

Yes, see this comment: https://github.com/pallets/werkzeug/pull/2804#issuecomment-1788097959

Thank you, @ThiefMaster!


Validation errors in update profile call

Hi, I'm having an issue with the UpdateProfile call. I'm retrieving the profile from Beanstream and updating the billing and card info but the card info isn't updated after the call. Is possible to achieve this in a single call for billing and card info?

I had this challenge as well. I had to do separate calls to update the billing info and the card.
I went with something like this
`
PaymentProfile profile = beanstream.Profiles.GetProfile(profileId);
        Card profileCard = beanstream.Profiles.GetCard(profileId, 1);

        profileCard.Update(profileRequest);

        ProfileResponse response = beanstream.Profiles.UpdateCard(profile.Id, profileCard);

        if (response.Code == "1")
        {
            profile = beanstream.Profiles.GetProfile(response.Id);
        }
        else
        {
            throw new ApplicationException($"Error updating profile card {response.Code}");
        }

        profile.Update(profileRequest);

        response = beanstream.Profiles.UpdateProfile(profile);

        if (response.Code == "1")
        {
            profile = beanstream.Profiles.GetProfile(response.Id);
        }
        else
        {
            throw new ApplicationException($"Error updating profile address {response.Code}");
        }`


Viewing both unit and instrumentation test coverage

Really nice job with codecov! But is there currently a way to see unit and instrumentation test coverages separately in Codecov? Would be really useful.

Hey @riwnodennyk currently there is and even more so in our next release.
In both cases you will need to submit the coverage in separately. Here is an example:
# current release
bash <(curl -s https://codecov.io/bash) -b unittests -f unittests.coverage.xml
bash <(curl -s https://codecov.io/bash) -b instrumentation -f instrumentation.coverage.xml

The -b is replacing the build argument

# future (next release)
bash <(curl -s https://codecov.io/bash) -F unittests -f unittests.coverage.xml
bash <(curl -s https://codecov.io/bash) -F instrumentation -f instrumentation.coverage.xml
``
> The `-F` is used as a "flag".


Paket: 1.18.2 -> 5.179.1

Motivation for this change
The build for Paket currently is failing and is outdated. This PR will bring it up-to-date, although it won't build from source anymore.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Fits CONTRIBUTING.md.

This probably needs backporting to 18.09 as well (#45960)

@GrahamcOfBorg build dotnetPackages.Paket

No attempt on aarch64-linux (full log)
The following builds were skipped because they don't evaluate on aarch64-linux: dotnetPackages.Paket
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Attempted: dotnetPackages.Paket
Partial log (click to expand)
'tools/netcoreapp2.0/runtimes/win/lib/netstandard2.0/System.Security.Cryptography.ProtectedData.dll' -> '/nix/store/y8v94dkmsdwsi1gis17ifrpxr13dyj4w-Paket-5.179.1/lib/dotnet/Paket/tools/netcoreapp2.0/runtimes/win/lib/netstandard2.0/System.Security.Cryptography.ProtectedData.dll'
'tools/paket.exe' -> '/nix/store/y8v94dkmsdwsi1gis17ifrpxr13dyj4w-Paket-5.179.1/lib/dotnet/Paket/tools/paket.exe'
/nix/store/y8v94dkmsdwsi1gis17ifrpxr13dyj4w-Paket-5.179.1 /build
/build
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/y8v94dkmsdwsi1gis17ifrpxr13dyj4w-Paket-5.179.1
patching script interpreter paths in /nix/store/y8v94dkmsdwsi1gis17ifrpxr13dyj4w-Paket-5.179.1
checking for references to /build in /nix/store/y8v94dkmsdwsi1gis17ifrpxr13dyj4w-Paket-5.179.1...
/nix/store/y8v94dkmsdwsi1gis17ifrpxr13dyj4w-Paket-5.179.1

Thank you!

Success on x86_64-darwin (full log)
Attempted: dotnetPackages.Paket
Partial log (click to expand)
'tools/netcoreapp2.0/runtimes/win/lib/netstandard2.0' -> '/nix/store/4xn6z28yd3ghprrb22iz0ri2b191nkaj-Paket-5.179.1/lib/dotnet/Paket/tools/netcoreapp2.0/runtimes/win/lib/netstandard2.0'
'tools/netcoreapp2.0/runtimes/win/lib/netstandard2.0/System.Net.Http.WinHttpHandler.dll' -> '/nix/store/4xn6z28yd3ghprrb22iz0ri2b191nkaj-Paket-5.179.1/lib/dotnet/Paket/tools/netcoreapp2.0/runtimes/win/lib/netstandard2.0/System.Net.Http.WinHttpHandler.dll'
'tools/netcoreapp2.0/runtimes/win/lib/netstandard2.0/System.Security.Cryptography.ProtectedData.dll' -> '/nix/store/4xn6z28yd3ghprrb22iz0ri2b191nkaj-Paket-5.179.1/lib/dotnet/Paket/tools/netcoreapp2.0/runtimes/win/lib/netstandard2.0/System.Security.Cryptography.ProtectedData.dll'
'tools/paket.exe' -> '/nix/store/4xn6z28yd3ghprrb22iz0ri2b191nkaj-Paket-5.179.1/lib/dotnet/Paket/tools/paket.exe'
/nix/store/4xn6z28yd3ghprrb22iz0ri2b191nkaj-Paket-5.179.1 /private/tmp/nix-build-Paket-5.179.1.drv-0
/private/tmp/nix-build-Paket-5.179.1.drv-0
glibPreFixupPhase
post-installation fixup
patching script interpreter paths in /nix/store/4xn6z28yd3ghprrb22iz0ri2b191nkaj-Paket-5.179.1
/nix/store/4xn6z28yd3ghprrb22iz0ri2b191nkaj-Paket-5.179.1

backported: 4aea85a89f1


Removed "My" from links in SUI

Removed My from “My Services”, “My Orders”, “My Requests”.  Pivotal ticket https://www.pivotaltracker.com/story/show/138278105

@chriskacerguis wait what?


Configuration tweaks

Make consumer retry backoff configurable, use 10s by default.
Allow opting out of reading the Errors channel, by setting Consumer.AckErrors and/or Producer.AckErrors to false.
Fix some documentation.

Discussion

The retry backoff for the JVM producer is 200ms, we use 10,000ms. :+1:/:-1:?
I am kind of inclined to default AckErrors to false, at least for the consumer. The Errors channel is not very useful, because the consumer will retry anyway and keep on going. Figuring out in what scenario you should stop the consumer, because not all errors are created equal. Ideally we would have a way to detect whether somebody is consuming the channel, but I haven't figured out a way.
I'd rather add a Consumer.Timeout setting, so you can make the consumer stop if no messages have been received for an x amount of time.

@Shopify/kafka

I don't really like having to tell how you are going to use the API by setting some config flags. So one idea that I had was setting all the Ack* values to false by default, and then turning them on as soon as you call Errors(), or Successes(). Unfortunately because we start producing/consuming right away after creating the Producer or PartitionConsumer, this could lead to messages/errors not being reported in certain concurrency scenarios. Not sure if there's a way around that.

I don't understand the desire to be able to blindly ignore errors, that's very non-idiomatic go.

Because it's basically not an error, it's a warning - at least in the Consumer. In the async producer I also see it as valid to ignore errors in AP scenarios.

I'd rather add a Consumer.Timeout setting, so you can make the consumer stop if no messages have been received for an x amount of time.

I have no technical objections, I just don't see the use case. In the vast majority of cases I can think of you just want to keep consuming forever or until an external signal is received?

Because it's basically not an error, it's a warning - at least in the Consumer.

Hmm, that's fair I guess, although there are some errors that indicate something more serious is wrong.

In the async producer I also see it as valid to ignore errors in AP scenarios.

That's also true, but I think that should generally be an explicit choice for the user, as opposed to just forgetting or not realizing, and ending up with different guarantees than they want. In that cause, launching a goroutine to drain it is not much more work than setting the flag, so I'm not sure the flag adds much value.

Hmm, that's fair I guess, although there are some errors that indicate something more serious is wrong.

Exactly. However, because right now all errors are treated equally and the burden is placed on the user to figure out whether something more serious is wrong. This is why I like a timeout value. If you haven't seen any events for x seconds, you know something more serious is wrong.

If you haven't seen any events for x seconds, you know something more serious is wrong.

Or it's just a really quiet topic.

I think, even in the cases that something more serious is wrong, the consumer should be able to recover once the cluster recovers. I cannot think of a case where e.g. shutting down and restarting the consumer adds any value to just letting it recover on its own.

Updated.

One nit, otherwise LGTM I think


What HTML markup is allowed in message?

The anchor tag is supported in the message text and a hyperlink is display in AzDevOps web pages but various formatting tags (bold, strong, font, span, div) are ignored and not rendered, although they are preserved in the message text when you list the messages.
Please update the docs to indicate which HTML markup is supported.
It would be very useful to allow formatting tags to be rendered.
This is a replacement for Azure/azure-cli-extensions#1057

@ishitam8 - could you help me understand the support limitations here?

Removing the bug tag since the functionality is intentional, but the documentation seems to be lacking.

@softwarecraft ,
I don't think complete formatting capabilities are available for message banners.
Can you please tell me the exact message you were looking for to be rendered?
I can check with the concerned team and ask them if there is any workaround.
Thanks

At the very least HTML anchor tag is supported, I've implemented that and it works.
It would be useful to support basic formatting, eg as listed in my issue (bold, strong, font, etc).
It is inconsistent to support HTML anchor tag and no other HTML or formatting. Why would you do that?
Either way, the docs should be explicit about what formatting is supported.


How to implement TIDE for custom dataset?

In my dataset i have one half as COCO dataset and other half as custom added dataset. So now, how should i check performance of model? Can you please explain in step by step?

same question

same question

Same question

+1

+1

pycocotools' dataset abstraction does not provided an API that's ergonomic for non-COCO data, but this library does; it's why I'm trying it out. Make a Data instance for you ground truth data, and one for your test data, fill them up using the add_* methods, and then trigger evaluation. I just noticed that Tide does NOT rle compress masks as you add them, so beware of high RAM usage. Data.add_detection and friends to NOT rle compress masks as you add them... hopefully it won't complain if you compress them using calls to pycocotols before passing them in.

Any updates regarding adding your own custom dataset drivers?

If someone wants an example of what @drewm1980 had mentioned to get a custom dataset driver working, here's an example of another non-COCO-related dataset working (VOC2007): https://gist.github.com/vjsrinivas/56ca6e209adf23be17b9d2266b288c71
It's still calculating the 101-point interpolation in COCO AP so it is not equal to VOC2007 mAP eval, but you can probably adjust it to get the same output values.


Remove the extra "default" authentication created when editing a container provider.

Description
Remove the extra "default" authentication created when editing a container provider.
PR #9947 solved the removal of the extra "default" authentications only in cases where the
params[:default_password] was not blank (this is not always true), this PR fixes that,
and remove the extra authentication in all the cases where the external management system
is container manager.
(*) The bug is for Darga, but this bug exist also in master.
Bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1370576

@miq-bot add_label providers/containers, ui, bug
@simon3z @AparnaKarve @zeari please review

@AparnaKarve can you please review?  Thx, Dan

@miq-bot add_label wip
while writing the sepc for this bug found that the current fix does not fix the bug.

@miq-bot remove_label wip
Added a new rspec test that checks update that only change the providers name. without this PR such an update action will result in a new authentication named "default".

Added a bugzilla link for 5.7:
https://bugzilla.redhat.com/show_bug.cgi?id=1361012

LGTM :+1:
@miq-bot assign chessbyte

This PR also solves:
https://bugzilla.redhat.com/show_bug.cgi?id=1389278

Euwe Backport details:
$ git log -1
commit 062f09401268ee52919091914c361a484c75294f
Author: Oleg Barenboim<EMAIL_ADDRESS>Date:   Tue Nov 1 15:03:11 2016 -0400

    Merge pull request #11504 from yaacov/remove-extra-default-authentication-for-ems-containers

    Remove the extra "default" authentication created when editing a container provider.
    (cherry picked from commit bfe87e83aaaa2c5318f524a788a8fcab4a946424)

    https://bugzilla.redhat.com/show_bug.cgi?id=1361012
    https://bugzilla.redhat.com/show_bug.cgi?id=1389278

@miq-bot  add_label blocker,
This needs to get into darga

@bazulay @chessbyte https://github.com/ManageIQ/manageiq/pull/12367 is a port of this PR to darga

Backported to Darga via https://github.com/ManageIQ/manageiq/pull/12367


Make button hints clickable

This PR doesn't really fix any issue.
But, it adds a fun little easter egg to the editor — the button icons in keyboard hints are now clickable:
https://user-images.githubusercontent.com/43412083/135757386-7d836fea-d549-4428-843a-fbf5384f8187.mp4
I think this would be a nice, fun addition to the project. Any critique/suggestions are welcome!

https://github.com/microsoft/vscode/wiki/How-to-Contribute#pull-requests

As much as I'd like to follow the issue-first principle for this pull request, I can't possibly figure out how to frame this contribution as an issue. "Key icons should be clickable"? I'm not sure if that issue makes sense.
But if that's the standard procedure, I'll do it. Would that be better?

But, it adds a fun little easter egg to the editor

Sorry, but we aren't up for fun easter eggs.