chore(litmus-portal): Added subject and context fields while workflow creation and fixed some minor bugs

Signed-off-by: Amit Kumar Das<EMAIL_ADDRESS>
Proposed changes
This PR adds:

Subject field in the workflow maninfest
Context field for chaos engines
Fixed name and description change bug in verify and commit page
Minor bug fixes

Types of changes
What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

[ ] New feature (non-breaking change which adds functionality)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices applies)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

[ ] I have read the CONTRIBUTING doc
[ ] I have signed the commit for DCO to be passed.
[ ] Lint and unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works (if appropriate)
[ ] I have added necessary documentation (if appropriate)

Dependency

Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

There's a minor deepscan issue found, can you fix it?


generate fake data in struct arrays

Add capability to populate array type elements in structs

I love this addition. Im going to merge this into my develop and make some slight changes(things like add a fakesize:number(otherwise random number)) and get the code coverage to be a little higher.

I was looking at adding one more addition to this: use fake:"3:{firstname}" to allow generating arrays with multiple elements for a function
what do you think?

Ya i hear ya. The thought behind having a separate tag is in the future if i need to add another tag type I wouldnt have to try to squeeze everything into a single string.

Let me know if you want to add fakesize tag or if you want me to add it

I pushed to develop if you want to add it.

it seems a bit overkill to have a separate tag just for the array size, unless you envision having it also used in other scenarios.
I'm not sure what the conventions/expectations are there either, but i haven't come across other modules using multiple tags.
i get that the number on its own is a bit odd/vague and have been trying to think of/find a better convention
following the validator module convention (https://godoc.org/gopkg.in/go-playground/validator.v9) one option might be;

'fake:"size=3,{password}"' for an array of strings with applied function
'fake:"size=3"' for an array of structs


Add dtype choice in step type/functions

Is your feature request related to a problem? Please describe
In a personal project, I had to be very efficient in the memory management, my reward were taking a lot of space. In my case I needed to change the reward and the discount to float16 instead of float32. I had to copy over the types file to do the modification locally. However I feel like some use case may need this flexibility.
Describe the solution you'd like
Give an extra parameter to the step functions to give dtype. (Example with one of them)
def truncation(
    reward: Array,
    observation: Observation,
    discount: Optional[Array] = None,
    extras: Optional[Dict] = None,
    shape: Union[int, Sequence[int]] = (),
    dtype: jnp.dtype = jnp.float32,
) -> TimeStep:
    """Returns a `TimeStep` with `step_type` set to `StepType.LAST`.

    Args:
        reward: array.
        observation: array or tree of arrays.
        discount: array.
        extras: environment metric(s) or information returned by the environment but
            not observed by the agent (hence not in the observation). For example, it
            could be whether an invalid action was taken. In most environments, extras
            is None.
        shape: optional parameter to specify the shape of the rewards and discounts.
            Allows multi-agent environment compatibility. Defaults to () for
            scalar reward and discount.
    Returns:
        TimeStep identified as the truncation of an episode.
    """
    discount = discount if discount is not None else jnp.ones(shape, dtype=dtype)
    extras = extras or {}
    return TimeStep(
        step_type=StepType.LAST,
        reward=reward,
        discount=discount,
        observation=observation,
        extras=extras,
    )

I would be happy to do the PR.

Misc

[x] Check for duplicate requests.

I think that would be a nice addition, happy to review it :smile:

To be honest I think the discounts should probably be booleans while they are stored in the timestep because for me they just indicated end of episode, but I think this would add nice flexibility

My only issue is that this strays from the original dm_env api where it is a float so it can represent both RL discount (gamma) and done.
Let's definitely add it as an argument, but for the default I'm not sure if boolean or float32 is best @clement-bonnet any thoughts on this?

To my knowledge, having the discount as a float is more common than as a boolean for the reasons you mentioned @sash-a. I would keep it a float unless there are strong reasons to do otherwise :)

Great then if you could add the argument with a default of float32, I'm happy to accept the PR

Great then if you could add the argument with a default of float32, I'm happy to accept the PR

The PR is available for review :)


release: 2022 12 08

:tada: This PR is included in version 2.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Plans for v3 Major

I am currently working on planning for v3, the next major release of this simple library.
I'd love feedback on the plans, if you have any.
New Features and Fixes

Hooks. A useOnline hook for easy and advanced use. Addresses #22.
TypeScript. Library written in TS. Declarations included in package. Addresses #18.
Ping Performance. Single ping every interval no matter how many components and hooks use it. Addresses #23.

Breaking Changes

Remove Detector component. Because hooks are now available, we can remove this render-prop component. Render props can be hard, and caused issues for some people. (for example #25 and #27)

Non-Breaking Changes

Remove PropTypes. PropTypes bloat the bundle. They aren't necessary with TypeScript.

Do you have a tentative API for useOnline you can show?

Here are my current thoughts:
const online = useOnline(options);

where online is boolean and options is something like
interface Options {
  browserEventsEnabled?: boolean;
  pollingInterval?: number;
  pollingTimeout?: number;
  pollingEnabled?: boolean;
  pollingURL?: string;
  pollingMethod?: string;
}

What is browserEventsEnabled and its default?

💡 What if you the polling functionality was independent of the hook/component?

as stated in the readme94% of worldwide (98% of US) browser traffic supports the web spec, so why always bundle it?
better tree shaking
puts the onus on the user to determine when/if needed via browser detection?

for >90% of uses:
import { useOnline } from 'react-detect-offline'
...
const online = useOnline()
if (online) return <Online />
return <Offline />

User decides to perform browser detection and supply default polling
import { useOnline, setupPoll } from 'react-detect-offline';

let poller;
if (oldBrowser) {
  poller = setupPoll(options)
}

...
const online = useOnline({ poller });

the created poller from setupPoll would have a .subscribe() method that returns an unsubscribe clean up method?

Oh that's a really interesting idea. What about just having two hook exports?
import { useOnline, useOnlineWithPolling } from 'react-detect-offline';

@chrisbolin i like the idea of two hook exports, but maybe splitting is just taking it too far? Maybe it's fine to just include the polling since th size is so small anyways?

My preference is to allow the developer to specify polling behavior in the provider.
<DetectOffline pollMs={15000}>
  {children}
</DetectOffline>

Awesome!  Do you have an ETA on v3?  For the current version, how would I set a state var once the app goes offline, and set it back when it goes online?

Hi @chrisbolin, Are you working on useOnline Hook? If not I'd like to work on it.

i’d say go for it.
On Fri, Mar 27, 2020 at 15:29 Mohammadreza Ziadzadeh <
<EMAIL_ADDRESS>wrote:

Hi @chrisbolin https://github.com/chrisbolin, Are you working on
useOnline Hook? If not I'd like to work on it.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/chrisbolin/react-detect-offline/issues/36#issuecomment-605323219,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABJBFE2ZLBYJYCL74DPUQ2TRJULFDANCNFSM4HCQQMYA
.

--
Brian Hartz
www.hartzis.me http://www.hartzis.me/about
<EMAIL_ADDRESS>

@themzed yeah definitely take a swing at all :)
There are other offline hooks too, though, if you don't want to build your own: https://github.com/rehooks/online-status


Add Debian topic

Please confirm this pull request meets the following requirements:

[x] I followed the contributing guidelines: https://github.com/github/explore/blob/main/CONTRIBUTING.md.
[x] I have no affiliation with the project I am suggesting (as a maintainer, creator, contractor, or employee).

Which change are you proposing?

[ ] Suggesting edits to an existing topic or collection
[x] Curating a new topic or collection
[ ] Something that does not neatly fit into the binary options above

Editing an existing topic or collection
I'm suggesting these edits to an existing topic or collection:

[ ] Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
[ ] Content (and my changes are in index.md)

Please replace this line with an explanation of why you think these changes should be made.

Curating a new topic or collection

[x] I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
[x] My folder contains a *.png image (if applicable) and index.md
[x] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

I believe this topic should be curated as similar topics are (ex Ubuntu, a fork of Debian), and it is recognized enough to warrant a curated topic.

Something that does not neatly fit into the binary options above

[ ] My suggested edits are not about an existing topic or collection, or at least not a single one
[ ] My suggested edits are not about curating a new topic or collection, or at least not a single one
[ ] My suggested edits conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Please replace this line with an explanation of your proposed changes.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Ah, looks like we still have a few CI failures to deal with.
1) Failure:
topics::debian topic#test_0017_has matching logo, when logo key exists [/home/runner/work/explore/explore/test/topics_test.rb:198]:
should not specify logo debian.svg when file does not exist

  2) Failure:
topics::debian topic#test_0018_has a matching logo key, when logo exists [/home/runner/work/explore/explore/test/topics_test.rb:212]:
logo key should be debian.png, but was debian.svg

  3) Failure:
topics::debian topic#test_00[25](https://github.com/github/explore/runs/6294574421?check_suite_focus=true#step:4:25)_follows the Topic Page Style Guide [/home/runner/work/explore/explore/test/topics_test.rb:[31](https://github.com/github/explore/runs/6294574421?check_suite_focus=true#step:4:31)0]:
Use open source without a hyphen.
Expected "Debian, also known as Debian Linux, is a GNU/Linux distribution composed of open-source software, developed by the Debian Project." to not include "open-source".


add locale to url

Now I can write
routes
.add('index', '/:lang(ru|en)?', 'index')
.add('about', '/:lang(ru|en)?/about', 'about')
...

It is possible to release?
routes
.add('i18n', '/:lang(ru|en)?/:path?', ':path');

Im try to add custom handler but it work only on server
function customHandler(args) {
  const {req, res, route, query} = args;
  const path = query.path ? query.path : '';
  app.render(req, res, `/${path}`, query);
}

Is the way to customize on client?

Not yet, but it’s a good idea! We could make the page parameter optionally accept a function, that receives the paramus and returns the page

If anyone wants to look into this right away, changes need to be done here and here

I would love this funcitonality it looks exactly what I need


Documentation on https site is out of date

The current https site serves docs for the 4.0 version of bootstrap, while http defaults to 4.1.

Known issue - see #26441 for more details. It's caused by a service worker caching the docs.
If you're using Chrome - open Chrome Devtools, open Application tab and then Application > Clear Storage. Then tap the 'Clear site data' button to wipe service worker storage etc. That'll fix it for you.

Gotcha. Seems like there is hesitance to remove the service worker stuff - it's obviously broken to me, but probably provides some value to the project.
Closing since the original issue was closed.


Store webhook payloads

The code around payloads is not defensive enough, we get a number of errors on webhook notify that are impossible to track down. We should store similar to Github's webhook interface. This should be easy enough, and doesn't require a user-facing UI. This will be mostly for debugging, and can be cleaned out periodically. Maybe even just cache the results?

The issue this was targeting was resolved by using per-project webhook urls. However, this should still remain open as a feature, having the last X webhook attempts would be very useful for user self-support.


Return data from sandbox to background

Hey,
As far as i understand from source only CDP Events are passed to background from sandbox. Is there any way to return some gathered data to background then?
I'm trying to make an extension that can be invoked by externalMessage so it can be received in background only. That is why i'm trying to find out if result of puppeteer script can be passed with simple return, other than passing data via console.log or something :)

Hi @bestplay9384
You can directly execute puppeteer script in background using puppeteer-extension-transport package.
Checkout this example
https://github.com/gajananpp/puppeteer-extension-transport/tree/main/examples/extension-v3

Hey @gajananpp,
I can't. I've external puppeteer scripts for different websites, i'm fetching one and needs to eval it. There is no possibility to eval in background since manifest v3 :/

@bestplay9384, yes creating or migrating to v3 extension is really difficult if it involves working with eval. I thought about your use case but couldn't think of any direct way to send data back to background. I hope at least they would provide chrome.runtime.sendMessage api in sandbox page in future. For debugging purpose in this extension, i am storing all the CDP commands and their responses in an object in background page, maybe something like that could be done if only response has to be gathered.
https://github.com/gajananpp/puppeteer-ide-extension/blob/main/src/background.ts#L129-L133


Feedback wanted: Media Explorer tool

Web sites make it increasingly harder to see full size pictures or watch videos in the browser-native player with controls and the option to save them. You can use Browser Developer Tools to work around that, but you need to know how. We are considering adding a "media explorer" to the browser to make that easier.
The Media Explorer would be a tool that allows you to scan the current document for images, videos embedded in the current docunent and linked to and display them as a sortable table. You can click each of the entries to get a media preview and you can choose to download them individually or as a zip in bulk. The following mockup shows what that could look like.

You can read up more details in the explainer and we would love to know what other features you would like to see.

I think this makes more sense to be an extension or in the sidebar, instead of being included in the developer tools as the target audience is general public and not specifically developers.
Have you considered the potential copyright issues that may arise from allowing users to download content from any website?
I am guessing this plugin only works for content with standard format like mp4, gif and not youtube, netflix etc.


mqtt dynamic signals

#428 first
#175 issue
load signals dynamically, tests are included.

I am not fond of restart_needed polling, could it be made more event based instead of references and polling?

I am open to suggestions

there are no tests for new functionality banned_signals.

the last test in integration_tests is a test for banned_signals

This change makes it more easily configurable from my understanding, however, there is a small change which has a rather big impact.
The change of config, from being a whitelist(publish_signals) to a blacklist(banned_signals) this will make it harder to update at customer site. Why this change of course?
What I thought to be the future of this component/interface would be like an option in the IO connections view to enable a signal being published with a simple checkmark or something. I think a whitelist is better for that purpose.
@omarhogni I think we need to make a documentation in regards to future of this components interface and functionality based on our first trial. Maybe we could use Github Projects for it, if it is beneficial.

Regardless of weather this function is implemented or not, there are invaluable tests in this PR that should be finished and merged. I can change this PR to tests only and implement dynamic signals. Thoughts?

Let's reopen if we need this feature


SerializableMessage as part of API

This PR removes @Internal annotation from SerializableMessage. This interface is used in core-java for binding generic parameters. So we cannot hide it.

@dmdashenkov, PTAL.


"pipenv run" intercepts its command-line options when specified after command

hobbes:backend cdunklau$ pipenv run pip --help
Usage: pipenv run [OPTIONS] COMMAND [ARGS]...

  Spawns a command installed into the virtualenv.

Options:
  --three / --two  Use Python 3/2 when creating virtualenv.
  --python TEXT    Specify which version of Python virtualenv should use.
  -h, --help       Show this message and exit.

...that should have been the help for pip, but I got pipenv run's help.
Looks like this comes down to how click handles things. The workaround is simply to use --. Both pipenv run -- pip --help and pipenv run pip -- --help give me pip's help output. This also appears to happen for the other pipenv run options: --two, --three, and --python.
I'd expect at least a mention in the pipenv run help output about this, if preventing click's normal behavior isn't feasible.

I believe this to be a bug in the way click has been implemented.  Marking it for fixing.

The click docs point this feature out. I'm 95% sure this thing is what's needed, unfortunately I don't have enough time to investigate the effects WRT pipenv. There's a nice example there though.

Thanks for the help @cdunklau!

This should be fixed in the next release.  It needs a better fix...I'm a bit of a noob when it comes to Click so if anyone else has a better solution please submit a PR!

Could we get another release please? 😄

@jacebrowning We've been in the process of getting final pieces in for the minor release. I'm not sure they'll be ready soon though, so I can look at cutting 8.3.0 at lunch.

@jacebrowning, 8.3.0 is now released.


[Notification] Change Ntfy, Gotify, Pushover from Webhook to framework

📃 Description
This PR changes Ntfy, Gotify, Pushover,  to use a framework instead of Web hooks.
🪵 Changelog
➕ Added

ntfy Php library
gotify php library
pushover php library
Add support to token based auth on ntfy to close https://github.com/alexjustesen/speedtest-tracker/issues/1668
Make the payload its own service, to be reused on other notifications
Make the notifications.speedtest-completed view general, to be reused on other notifications

✏ Changed

Switch ntfy to use markdown for the layout.
Switch pushover to use html for the layout

📷 Screenshots
If this PR has any UI/UX changes it's strongly suggested you add screenshots here.

Close, because of rework first.


Translation to Spanish: Verify and update translation of gear-up-for-success.json

[x]  Browse Camper News
[x]  Reference our Wiki
[x]  Join our LinkedIn Alumni Network
[x]  Commit to a Goal and a Nonprofit

[X] Learn how Free Code Camp Works
[X] Create a GitHub Account and Join our Chat Rooms
[X] Configure your Code Portfolio
[X] Join a Campsite in Your City
[X] Learn What to Do If You Get Stuck

This issue is closed by https://github.com/FreeCodeCamp/FreeCodeCamp/commit/e474f5338522a3e61f70d9c8f61f8a02eb3a0797.


Read timeout on InfluxDB-cxx

I have a multi-threaded program that is writing 100k write with 10K batches and at the same time reading values from the same table. I see this error and I have tried a few options however not been successful.
Thread 0: inserting 100000 random rows
Thread 3: inserting 100000 random rows
Thread 1: inserting 100000 random rows
Thread 2: inserting 100000 random rows
Thread 4: inserting 100000 random rows
Thread 5: inserting 100000 random rows
Thread 6: inserting 100000 random rows
Thread 7: inserting 100000 random rows
Exception: influx-cxx [treatCurlResponse]: Timeout was reached
Exception: influx-cxx [treatCurlResponse]: Timeout was reached
Exception: influx-cxx [treatCurlResponse]: Timeout was reached
Exception: influx-cxx [treatCurlResponse]: Timeout was reached
Exception: influx-cxx [treatCurlResponse]: Timeout was reached
Exception: influx-cxx [treatCurlResponse]: Timeout was reached
Exception: influx-cxx [treatCurlResponse]: Timeout was reached
Exception: influx-cxx [treatCurlResponse]: Timeout was reached
terminate called after throwing an instance of 'influxdb::ConnectionError'
  what():  influx-cxx [treatCurlResponse]: Timeout was reached

I tried and increased the write-timeout for coordinator in the influxdb.conf
[coordinator]
 The default time a write request will wait until a "timeout" error is returned to the caller.
   write-timeout = "600s"
   #max-concurrent-queries = 0
   #query-timeout** = "0s"

[http]
#Added these timeouts
read-timeout = "600s"
write-timeout = "600s"

[subscriber]
   http-timeout = "1800s"

then I restarted the influxDB. I don't see how to increase the read-timeout and see this is happening. could you please help me on how to increase the timeout from default 10s to something larger? I see that after 10 seconds the timeout is happening.

The Http timeout is hardcoded to 10 sec here. For a quick test you can change these two lines.

It worked for me. I suggest to add support of changing this. the write and read timeouts vary in the applications.

@pkoosha could you have a look at #220? It introduces a new transport configuration which provides support for this option.


Lumina requests support

Would be nice to be able to request function information from Lumina servers without IDA Pro running.

yes, this would be a fascinating research project!

i had done some inspection of ida.wll to see how IDA constructs the hashes it sends to Lumina. I don't recall this being trivial, and seemed to include information about the stack layout to signature the function. fortunately, this was pretty obvious to find in the DLL, so it remains a feasible project.

This might be relevant:

https://github.com/synacktiv/lumina_server
https://www.synacktiv.com/publications/investigating-ida-lumina-feature.html

This project as well:
https://github.com/naim94a/lumen


Make adb_debug.py able to use python-rsa if M2Crypto is unavailable.

python-rsa is installed by default on Ubuntu.
Make fastboot_debug.py a standalone executable.

Actually, to be nicer, I'll merge it as-is and make my proposed changes a pull-request. That way you get unblocked faster

The main issue is that I don't know what is part of the API and what isn't. So I didn't want to change the M2CryptoSigner API and made the PythonRSASigner "compatible enough". In our use case, we don't read the file from disk so we need to be able to pass it as argument.


Spring XD startup scripts for xd-admin and xd-container don't add messagebus jars to classpath

Spring XD startup scripts for xd-admin and xd-container don't add the messagebus jars to their classpaths.  This caused a NoClassDefFoundError of the Rabbit ConnectionFactory during runtime when I tried to use RabbitMQ as a message transport.
I was able to fix it by customizing the script to include the jars in /lib/messagebus/rabbit.  I'm not sure how y'all wanna handle including the messagebus jars moving forward.  I'll gladly submit a PR sometime soon if you're swamped with other tasking.
Please see https://stackoverflow.com/q/44419903/3813155 for more details.

@ealexhaywood Thank you for your willingness to contribute!
Spring XD is redesigned as Spring Cloud Data Flow and is scheduled for End-of-Life, End-of-Availability, and End-of-Support by July 2017.
Please read the announcement here: http://projects.spring.io/spring-xd/


how do i get the runing time of every layers separately?

Please make sure that the boxes below are checked before you submit your issue. If your issue is an implementation question, please ask your question on StackOverflow or join the Keras Slack channel and ask there instead of filing a GitHub issue.
Thank you!

[ ] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/fchollet/keras.git --upgrade --no-deps

[ ] If running on TensorFlow, check that you are up-to-date with the latest version. The installation instructions can be found here.

[x] If running on Theano, check that you are up-to-date with the master branch of Theano. You can update with:
pip install git+git://github.com/Theano/Theano.git --upgrade --no-deps

[ ] Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short).

@xzj6795365 please close this issue since it duplicates https://github.com/fchollet/keras/issues/6805


[confidentialledger] Address lint rule "composition-over-inheritance"

Reacts to https://github.com/Azure/typespec-azure/pull/3756

@timotheeguerin: Does this look safe/correct?  There are no changes to the generated autorest.


Add option to toggle activity overlay in the Wintertodt Plugin

Is your feature request related to a problem? Please describe.
The wintertodt plugin shows the number of roots and kindlings in the inverntory
Describe the solution you'd like
I would like it to be toggle-able so I can turn it off as it's not something i need to see on screen
Describe alternatives you've considered
n/a
Screenshot

added in eae4e0b


pull request for e2e test at 01/06/2017 01:15:59

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


vim-plug is not working properly

using coc.nvim and vim-plug, the following error message is shown.
[coc.nvim] extension "es7-react-js-snippets" doesn't contain main file
I can see the repository is successfully installed in autoload folder, so in .config/nvim/autoload/plugged/vscode-es7-javascript-react-snippets the folder exists, but according to the error message, in this folder, there should be out/index.js, but there is no such folder and file

Please look here #103 and check if you have a proper setup. I do not use coc.nvim so I can't test it by myself but seems like this solves an issue.
Plug 'dsznajder/vscode-es7-javascript-react-snippets', {
      \ 'do': 'yarn install --frozen-lockfile && yarn compile' }

@dsznajder it might be silly question but how can I trigger the snippet?? using tab? Again sorry for silly question and thx for good reply

@tgkei Could you provide some error stack for that?

@tgkei Could you provide some error stack for that?
When it comes to trigger snippets it depends on your setup. You can configure VSCode for tab trigger but there is also search for snippets.

Sorry for my Coc setting had some issues. After fixed coc everything works fine thx!

@tgkei I'm having a similar issue. What was your issue in coc settings?

@tgkei do you mind sharing was you changed in the Coc setting? I'm also curious on this setup. I think I'm going to just use VScode for next.js right now, but I'd love to have this in vim.


Fix Protobuf lint issues

Is your feature request related to a problem? Please describe.
Running buf lint in proto/proto gives a lot of output (example below).  We should:

[ ] Fix the existing lint issues (this could be in multiple PRs, though since it involves breaking changes to protos, it's better to do it sooner rather than later)
[ ] Enable buf lint in CI (by uncommenting that part of the Github Actions file).

Example:
~/c/p/p/p/proto (main|✔) $ buf lint
penumbra/client/v1alpha1/client.proto:18:9:Service name "ObliviousQuery" should be suffixed with "Service".
penumbra/client/v1alpha1/client.proto:19:67:RPC response type "CompactBlock" should be named "CompactBlockRangeResponse" or "ObliviousQueryCompactBlockRangeResponse".
penumbra/client/v1alpha1/client.proto:20:3:"penumbra.core.chain.v1alpha1.ChainParameters" is used as the request or response type for multiple RPCs.
penumbra/client/v1alpha1/client.proto:20:23:RPC request type "ChainParamsRequest" should be named "ChainParametersRequest" or "ObliviousQueryChainParametersRequest".
penumbra/client/v1alpha1/client.proto:20:52:RPC response type "ChainParameters" should be named "ChainParametersResponse" or "ObliviousQueryChainParametersResponse".
penumbra/client/v1alpha1/client.proto:21:59:RPC response type "ValidatorInfo" should be named "ValidatorInfoResponse" or "ObliviousQueryValidatorInfoResponse".
penumbra/client/v1alpha1/client.proto:22:44:RPC response type "KnownAssets" should be named "AssetListResponse" or "ObliviousQueryAssetListResponse".
penumbra/client/v1alpha1/client.proto:65:9:Service name "SpecificQuery" should be suffixed with "Service".
penumbra/client/v1alpha1/client.proto:66:25:RPC request type "NoteCommitment" should be named "TransactionByNoteRequest" or "SpecificQueryTransactionByNoteRequest".
penumbra/client/v1alpha1/client.proto:66:71:RPC response type "NoteSource" should be named "TransactionByNoteResponse" or "SpecificQueryTransactionByNoteResponse".
penumbra/client/v1alpha1/client.proto:67:56:RPC response type "ValidatorStatus" should be named "ValidatorStatusResponse" or "SpecificQueryValidatorStatusResponse".
penumbra/client/v1alpha1/client.proto:68:25:RPC request type "IdentityKey" should be named "NextValidatorRateRequest" or "SpecificQueryNextValidatorRateRequest".
penumbra/client/v1alpha1/client.proto:68:68:RPC response type "RateData" should be named "NextValidatorRateResponse" or "SpecificQueryNextValidatorRateResponse".
penumbra/client/v1alpha1/client.proto:69:64:RPC response type "BatchSwapOutputData" should be named "BatchSwapOutputDataResponse" or "SpecificQueryBatchSwapOutputDataResponse".
penumbra/client/v1alpha1/client.proto:70:58:RPC response type "Reserves" should be named "StubCPMMReservesResponse" or "SpecificQueryStubCPMMReservesResponse".
penumbra/core/dex/v1alpha1/dex.proto:180:5:Enum value name "OPENED" should be prefixed with "POSITION_STATE_ENUM_".
penumbra/core/dex/v1alpha1/dex.proto:180:5:Enum zero value name "OPENED" should be suffixed with "_UNSPECIFIED".
penumbra/core/dex/v1alpha1/dex.proto:183:5:Enum value name "CLOSED" should be prefixed with "POSITION_STATE_ENUM_".
penumbra/core/dex/v1alpha1/dex.proto:186:5:Enum value name "WITHDRAWN" should be prefixed with "POSITION_STATE_ENUM_".
penumbra/core/dex/v1alpha1/dex.proto:189:5:Enum value name "CLAIMED" should be prefixed with "POSITION_STATE_ENUM_".
penumbra/core/governance/v1alpha1/governance.proto:10:5:Enum value name "ABSTAIN" should be prefixed with "VOTE_".
penumbra/core/governance/v1alpha1/governance.proto:10:5:Enum zero value name "ABSTAIN" should be suffixed with "_UNSPECIFIED".
penumbra/core/governance/v1alpha1/governance.proto:11:5:Enum value name "YES" should be prefixed with "VOTE_".
penumbra/core/governance/v1alpha1/governance.proto:12:5:Enum value name "NO" should be prefixed with "VOTE_".
penumbra/core/governance/v1alpha1/governance.proto:13:5:Enum value name "NO_WITH_VETO" should be prefixed with "VOTE_".
penumbra/core/ibc/v1alpha1/ibc.proto:17:53:Field name "connectionOpenInit" should be lower_snake_case, such as "connection_open_init".
penumbra/core/ibc/v1alpha1/ibc.proto:18:52:Field name "connectionOpenTry" should be lower_snake_case, such as "connection_open_try".
penumbra/core/ibc/v1alpha1/ibc.proto:19:52:Field name "connectionOpenAck" should be lower_snake_case, such as "connection_open_ack".
penumbra/core/ibc/v1alpha1/ibc.proto:20:56:Field name "connectionOpenConfirm" should be lower_snake_case, such as "connection_open_confirm".
penumbra/core/ibc/v1alpha1/ibc.proto:22:47:Field name "channelOpenInit" should be lower_snake_case, such as "channel_open_init".
penumbra/core/ibc/v1alpha1/ibc.proto:23:46:Field name "channelOpenTry" should be lower_snake_case, such as "channel_open_try".
penumbra/core/ibc/v1alpha1/ibc.proto:24:46:Field name "channelOpenAck" should be lower_snake_case, such as "channel_open_ack".
penumbra/core/ibc/v1alpha1/ibc.proto:25:50:Field name "channelOpenConfirm" should be lower_snake_case, such as "channel_open_confirm".
penumbra/core/ibc/v1alpha1/ibc.proto:26:48:Field name "channelCloseInit" should be lower_snake_case, such as "channel_close_init".
penumbra/core/ibc/v1alpha1/ibc.proto:27:51:Field name "channelCloseConfirm" should be lower_snake_case, such as "channel_close_confirm".
penumbra/core/ibc/v1alpha1/ibc.proto:29:42:Field name "recvPacket" should be lower_snake_case, such as "recv_packet".
penumbra/core/ibc/v1alpha1/ibc.proto:33:43:Field name "createClient" should be lower_snake_case, such as "create_client".
penumbra/core/ibc/v1alpha1/ibc.proto:34:43:Field name "updateClient" should be lower_snake_case, such as "update_client".
penumbra/core/ibc/v1alpha1/ibc.proto:35:44:Field name "upgradeClient" should be lower_snake_case, such as "upgrade_client".
penumbra/core/ibc/v1alpha1/ibc.proto:36:49:Field name "submitMisbehaviour" should be lower_snake_case, such as "submit_misbehaviour".
penumbra/core/ibc/v1alpha1/ibc.proto:80:10:Field name "clientID" should be lower_snake_case, such as "client_id".
penumbra/core/ibc/v1alpha1/ibc.proto:81:23:Field name "clientState" should be lower_snake_case, such as "client_state".
penumbra/core/ibc/v1alpha1/ibc.proto:82:10:Field name "processedTime" should be lower_snake_case, such as "processed_time".
penumbra/core/ibc/v1alpha1/ibc.proto:83:10:Field name "processedHeight" should be lower_snake_case, such as "processed_height".
penumbra/core/ibc/v1alpha1/ibc.proto:91:23:Field name "consensusState" should be lower_snake_case, such as "consensus_state".
penumbra/core/stake/v1alpha1/stake.proto:74:5:Enum value name "BONDED" should be prefixed with "BONDING_STATE_ENUM_".
penumbra/core/stake/v1alpha1/stake.proto:74:5:Enum zero value name "BONDED" should be suffixed with "_UNSPECIFIED".
penumbra/core/stake/v1alpha1/stake.proto:75:5:Enum value name "UNBONDING" should be prefixed with "BONDING_STATE_ENUM_".
penumbra/core/stake/v1alpha1/stake.proto:76:5:Enum value name "UNBONDED" should be prefixed with "BONDING_STATE_ENUM_".
penumbra/core/stake/v1alpha1/stake.proto:85:5:Enum value name "INACTIVE" should be prefixed with "VALIDATOR_STATE_ENUM_".
penumbra/core/stake/v1alpha1/stake.proto:85:5:Enum zero value name "INACTIVE" should be suffixed with "_UNSPECIFIED".
penumbra/core/stake/v1alpha1/stake.proto:86:5:Enum value name "ACTIVE" should be prefixed with "VALIDATOR_STATE_ENUM_".
penumbra/core/stake/v1alpha1/stake.proto:87:5:Enum value name "JAILED" should be prefixed with "VALIDATOR_STATE_ENUM_".
penumbra/core/stake/v1alpha1/stake.proto:88:5:Enum value name "TOMBSTONED" should be prefixed with "VALIDATOR_STATE_ENUM_".
penumbra/core/stake/v1alpha1/stake.proto:89:5:Enum value name "DISABLED" should be prefixed with "VALIDATOR_STATE_ENUM_".
penumbra/custody/v1alpha1/custody.proto:20:9:Service name "CustodyProtocol" should be suffixed with "Service".
penumbra/custody/v1alpha1/custody.proto:22:46:RPC response type "AuthorizationData" should be named "AuthorizeResponse" or "CustodyProtocolAuthorizeResponse".
penumbra/view/v1alpha1/view.proto:20:9:Service name "ViewProtocol" should be suffixed with "Service".
penumbra/view/v1alpha1/view.proto:28:5:"penumbra.view.v1alpha1.SpendableNoteRecord" is used as the request or response type for multiple RPCs.
penumbra/view/v1alpha1/view.proto:28:45:RPC response type "SpendableNoteRecord" should be named "NotesResponse" or "ViewProtocolNotesResponse".
penumbra/view/v1alpha1/view.proto:31:67:RPC response type "QuarantinedNoteRecord" should be named "QuarantinedNotesResponse" or "ViewProtocolQuarantinedNotesResponse".
penumbra/view/v1alpha1/view.proto:39:42:RPC response type "WitnessData" should be named "WitnessResponse" or "ViewProtocolWitnessResponse".
penumbra/view/v1alpha1/view.proto:42:16:RPC request type "AssetRequest" should be named "AssetsRequest" or "ViewProtocolAssetsRequest".
penumbra/view/v1alpha1/view.proto:42:46:RPC response type "Asset" should be named "AssetsResponse" or "ViewProtocolAssetsResponse".
penumbra/view/v1alpha1/view.proto:45:5:"penumbra.core.chain.v1alpha1.ChainParameters" is used as the request or response type for multiple RPCs.
penumbra/view/v1alpha1/view.proto:45:25:RPC request type "ChainParamsRequest" should be named "ChainParametersRequest" or "ViewProtocolChainParametersRequest".
penumbra/view/v1alpha1/view.proto:45:54:RPC response type "ChainParameters" should be named "ChainParametersResponse" or "ViewProtocolChainParametersResponse".
penumbra/view/v1alpha1/view.proto:48:54:RPC response type "FmdParameters" should be named "FMDParametersResponse" or "ViewProtocolFMDParametersResponse".
penumbra/view/v1alpha1/view.proto:51:5:"penumbra.view.v1alpha1.SpendableNoteRecord" is used as the request or response type for multiple RPCs.
penumbra/view/v1alpha1/view.proto:51:60:RPC response type "SpendableNoteRecord" should be named "NoteByCommitmentResponse" or "ViewProtocolNoteByCommitmentResponse".
penumbra/view/v1alpha1/view.proto:57:5:"penumbra.view.v1alpha1.TransactionsRequest" is used as the request or response type for multiple RPCs.
penumbra/view/v1alpha1/view.proto:57:27:RPC request type "TransactionsRequest" should be named "TransactionHashesRequest" or "ViewProtocolTransactionHashesRequest".
penumbra/view/v1alpha1/view.proto:57:64:RPC response type "TransactionHashStreamResponse" should be named "TransactionHashesResponse" or "ViewProtocolTransactionHashesResponse".
penumbra/view/v1alpha1/view.proto:59:5:"penumbra.view.v1alpha1.TransactionsRequest" is used as the request or response type for multiple RPCs.
penumbra/view/v1alpha1/view.proto:59:59:RPC response type "TransactionStreamResponse" should be named "TransactionsResponse" or "ViewProtocolTransactionsResponse".

Hey @erwanor, I just added some protoc docs to the dev guide in https://github.com/penumbra-zone/penumbra/pull/1559, but I neglected to mention buf. As you tackle addressing the linter's recommendations, consider tacking on a section to https://guide.penumbra.zone/main/dev/protobuf.html so that future maintainers can get started quickly.

Following #1629, it looks like the only remaining issue is about request/response naming:
~/c/p/p/proto (main|…) $ buf lint
proto/penumbra/client/v1alpha1/client.proto:20:67:RPC response type "CompactBlock" should be named "CompactBlockRangeResponse" or "ObliviousQueryServiceCompactBlockRangeResponse".
proto/penumbra/client/v1alpha1/client.proto:21:3:"penumbra.core.chain.v1alpha1.ChainParameters" is used as the request or response type for multiple RPCs.
proto/penumbra/client/v1alpha1/client.proto:21:23:RPC request type "ChainParamsRequest" should be named "ChainParametersRequest" or "ObliviousQueryServiceChainParametersRequest".
proto/penumbra/client/v1alpha1/client.proto:21:52:RPC response type "ChainParameters" should be named "ChainParametersResponse" or "ObliviousQueryServiceChainParametersResponse".
proto/penumbra/client/v1alpha1/client.proto:22:67:RPC response type "MutableChainParameter" should be named "MutableParametersResponse" or "ObliviousQueryServiceMutableParametersResponse".
proto/penumbra/client/v1alpha1/client.proto:23:59:RPC response type "ValidatorInfo" should be named "ValidatorInfoResponse" or "ObliviousQueryServiceValidatorInfoResponse".
proto/penumbra/client/v1alpha1/client.proto:25:44:RPC response type "KnownAssets" should be named "AssetListResponse" or "ObliviousQueryServiceAssetListResponse".
proto/penumbra/client/v1alpha1/client.proto:75:25:RPC request type "NoteCommitment" should be named "TransactionByNoteRequest" or "SpecificQueryServiceTransactionByNoteRequest".
proto/penumbra/client/v1alpha1/client.proto:75:71:RPC response type "NoteSource" should be named "TransactionByNoteResponse" or "SpecificQueryServiceTransactionByNoteResponse".
proto/penumbra/client/v1alpha1/client.proto:76:56:RPC response type "ValidatorStatus" should be named "ValidatorStatusResponse" or "SpecificQueryServiceValidatorStatusResponse".
proto/penumbra/client/v1alpha1/client.proto:77:25:RPC request type "IdentityKey" should be named "NextValidatorRateRequest" or "SpecificQueryServiceNextValidatorRateRequest".
proto/penumbra/client/v1alpha1/client.proto:77:68:RPC response type "RateData" should be named "NextValidatorRateResponse" or "SpecificQueryServiceNextValidatorRateResponse".
proto/penumbra/client/v1alpha1/client.proto:78:64:RPC response type "BatchSwapOutputData" should be named "BatchSwapOutputDataResponse" or "SpecificQueryServiceBatchSwapOutputDataResponse".
proto/penumbra/client/v1alpha1/client.proto:79:58:RPC response type "Reserves" should be named "StubCPMMReservesResponse" or "SpecificQueryServiceStubCPMMReservesResponse".
proto/penumbra/custody/v1alpha1/custody.proto:22:46:RPC response type "AuthorizationData" should be named "AuthorizeResponse" or "CustodyProtocolServiceAuthorizeResponse".
proto/penumbra/view/v1alpha1/view.proto:28:5:"penumbra.view.v1alpha1.SpendableNoteRecord" is used as the request or response type for multiple RPCs.
proto/penumbra/view/v1alpha1/view.proto:28:45:RPC response type "SpendableNoteRecord" should be named "NotesResponse" or "ViewProtocolServiceNotesResponse".
proto/penumbra/view/v1alpha1/view.proto:31:67:RPC response type "QuarantinedNoteRecord" should be named "QuarantinedNotesResponse" or "ViewProtocolServiceQuarantinedNotesResponse".
proto/penumbra/view/v1alpha1/view.proto:39:42:RPC response type "WitnessData" should be named "WitnessResponse" or "ViewProtocolServiceWitnessResponse".
proto/penumbra/view/v1alpha1/view.proto:42:16:RPC request type "AssetRequest" should be named "AssetsRequest" or "ViewProtocolServiceAssetsRequest".
proto/penumbra/view/v1alpha1/view.proto:42:46:RPC response type "Asset" should be named "AssetsResponse" or "ViewProtocolServiceAssetsResponse".
proto/penumbra/view/v1alpha1/view.proto:45:5:"penumbra.core.chain.v1alpha1.ChainParameters" is used as the request or response type for multiple RPCs.
proto/penumbra/view/v1alpha1/view.proto:45:25:RPC request type "ChainParamsRequest" should be named "ChainParametersRequest" or "ViewProtocolServiceChainParametersRequest".
proto/penumbra/view/v1alpha1/view.proto:45:54:RPC response type "ChainParameters" should be named "ChainParametersResponse" or "ViewProtocolServiceChainParametersResponse".
proto/penumbra/view/v1alpha1/view.proto:48:54:RPC response type "FmdParameters" should be named "FMDParametersResponse" or "ViewProtocolServiceFMDParametersResponse".
proto/penumbra/view/v1alpha1/view.proto:51:5:"penumbra.view.v1alpha1.SpendableNoteRecord" is used as the request or response type for multiple RPCs.
proto/penumbra/view/v1alpha1/view.proto:51:60:RPC response type "SpendableNoteRecord" should be named "NoteByCommitmentResponse" or "ViewProtocolServiceNoteByCommitmentResponse".
proto/penumbra/view/v1alpha1/view.proto:57:5:"penumbra.view.v1alpha1.TransactionsRequest" is used as the request or response type for multiple RPCs.
proto/penumbra/view/v1alpha1/view.proto:57:27:RPC request type "TransactionsRequest" should be named "TransactionHashesRequest" or "ViewProtocolServiceTransactionHashesRequest".
proto/penumbra/view/v1alpha1/view.proto:57:64:RPC response type "TransactionHashStreamResponse" should be named "TransactionHashesResponse" or "ViewProtocolServiceTransactionHashesResponse".
proto/penumbra/view/v1alpha1/view.proto:61:5:"penumbra.view.v1alpha1.TransactionsRequest" is used as the request or response type for multiple RPCs.
proto/penumbra/view/v1alpha1/view.proto:61:59:RPC response type "TransactionStreamResponse" should be named "TransactionsResponse" or "ViewProtocolServiceTransactionsResponse".


Add configuration by code for System.Runtime.Caching memory options

The only way to configure the memory pressure or limits of the System.Runtime.Caching.MemoryCache based handle is via app/web.config.
The implementation already supports named caches, there could be at least overloads for the builder extension methods to define the following three properties...
//Create a name / value pair for properties
var config = new NameValueCollection();
config.Add("pollingInterval", "00:05:00");
config.Add("physicalMemoryLimitPercentage", "0");
config.Add("cacheMemoryLimitMegabytes", "10");

//instantiate cache
var cache = new MemoryCache("CustomCache", config);

API proposal:
.WithSystemRuntimeCacheHandle("CustomCache", pollingInterval: TimeSpan.FromMinutes(5), physicalMemoryLimitPercentage: 0, cacheMemoryLimitMegabytes: 10);

@nflash sounds good,
I think you'd have to add 2 additional extension methods for adding the handle, basically the same ones which already exist but with the addition of the new options.
Make sure the options are totally optional and the old way via web/app config will still work.
But that's only one way to configure it:

Not sure if we have to add it to the old web/app configuration system as you can already configure it there anyways.
Configuration via MS.Extensions.Configuration, like json files. I can figure that one out later though.

Yup, feel free to send a PR :)


ubootOdroidN2: init

Description of changes
Adds a u-boot build for the N2 and N2+.
Requires proprietary blobs from https://github.com/LibreELEC/amlogic-boot-fi
U-boot wiki for the boards: https://u-boot.readthedocs.io/en/latest/board/amlogic/odroid-n2.html
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Added meson64-tools package and updated the uboot builder to utilize it.

Thanks! Changed package description and tooling binary output names as suggested.

Rebased on master and removed unnecessary dependency yacc which is included in bison.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1084


Use content attachments API

Updating this app to use the new content attachments API.

@wilhelmklopp @probot/maintainers Wanted to bump this conversation to get some ideas on how to roll this out. I see a couple of options:

Remove all issue/pull request unfurls, but add a few domains that can be unfurled explicitly by content reference domains.
Keep the issue/pull request unfurls in place for non-content reference domains, so some "special" domains will unfurl using content references
Don't use content references at all and keep this working as it is today.

To do one of the first two, we'd need to decide which domains should be used as content_references. Some of the top ideas:

Twitter
Stack Overflow
Reddit
Spectrum.chat
GitHub.community (is this allowed?)

Basically any site that uses open graph would work, but these are ones that seem super relevant to developers. I think I'd be ok turning anything else off, since GitHub links are now automatically turned into hover cards, and end up not rendering properly when it's not public.


Fix missing translation for in app dapp connection success banner

Description
There is a banner text for in app dapp connection success, it was added in #2178 but removed accidentally in #2209 - not sure what happened, but #2209 was open for a long time (broken CI maybe) so probably a bad crowdin sync somewhere along the way.
Other changes
N/A
Tested
N/A
How others should test
N/A
Related issues
N/A
Backwards compatibility
N/A

It's weird Crowdin tried to remove that key 🤔
What do you thinking of not approving Crowdin PRs if they touch the base translation?

It's weird Crowdin tried to remove that key 🤔 What do you think of not approving Crowdin PRs if they touch the base translation?

yeah totally, i'll update the crowdin script to be like the other ones where we check for the expected changed files

Hey @MuckT as N/A is mentioned in how to test hence we are skipping this PR.
Thanks..


Instrument class taxonomy - Draft

we need to define a space of instruments that will be known / predicted.
medleydb has one: http://medleydb.weebly.com/description.html#metadata
others to fold in?

Here's the wordnet slice for musical instruments.

Here's the wordnet slice for musical instruments.

Looks quite complete to me. Maybe a little bit too complete? However, I guess the "base-taxonomy" can be rather big–the task itself can then deal with a subset.
Btw: Wordnet is written in Prolog so it might be easier to directly parse the HTML output :)

RWC has some: https://staff.aist.go.jp/m.goto/RWC-MDB/rwc-mdb-i.html
IMSLP (unstructured): http://imslp.org/wiki/IMSLP:Abbreviations_for_Instruments
Let's see what the UPF guys use in the Jamendo corpus.

As part of the AudioCommons project in which UPF and QMUL collaborate with Jamendo, we are planning to at least partially define an instruments taxonomy for instrument classification. This is also what we need here so I guess it would make a lot of sense to combine efforts. Our idea is to concentrate on the taxonomy that Jamendo is using, which you can see here: https://licensing.jamendo.com/en/catalog (go down and click on the instruments tab).
The hierarchy only contains 7 main groups and then a relatively large number of instruments in each group. As I said before, we still have not discussed much about which ones to include or whether we should further expand the hierarchy into more levels. However I'll be happy to share things between Omec and AudioCommons and I'll also try to get AudioCommons people responsible for the taxonomy involved in this conversation.
To be honest, I would favour some kind of taxonomy derived from existing data (or existing and working initiatives such as Jamendo) rather than some generic instruments taxonomy that can become really complex but maybe less meaningful from an information retrieval point of view.

Agreed, the Jamendo taxonomy is probably a good place to start ... 2.5 of the 7 are a little odd for my tastes: Popular and Other are catch-alls, and Electronic is going to be messy. If ImageNet can accomplish this for 1000+ objects, I'm sure we can sort out a few dozen instruments.
What I'd really like to do is identify a few folks to take full ownership of this and make a proposal. There's enough work to go around, and this is largely independent of everything else that needs to be accomplished mechanically. The deliverable of this issue will be something like a JSON schema / namespace, that can be dynamically accessed (as a web resource) and used to populate the possible tag space of an annotation UI. This might be nicely achieved as a JAMS namespace, but maybe @bmcfee has opinions on this.
I'll be spawning other issues / TODOs, but folks should jump on this one if it interests them.

Maybe you want to take a look at: http://isophonics.org/content/musical-instrument-taxonomies
ImageNet is great because it is based on WordNet - that is a "semantic space", an ontology. Quoting the ImageNet web site: "Each meaningful CONCEPT in WordNet, possibly described by multiple words or word phrases, is called a 'synonym set' or 'synset'". Maybe is a good idea to use one of these ontologies, similarly as ImageNet uses WordNet as a backbone. As far as I know, musical concepts are not well represented in WordNet. This is why I propose taking a look to the link above.
I agree that  the Jamendo taxonomy is probably a good place to start, specially because it is the most easy option (audio and taxonomy are already available). However, using a complete and well structured ontology as a backbone might be a bigger step for a "sustainable MIR evaluation" since the annotation efforts are oriented towards fully solving the task. These ontologies are supposed to completely describe the "instruments space" and probably are more complete than a regular taxonomy.
Please note that this comment contradicts Frederic position :). Maybe a compromise between taxonomy derived from existing data vs. complex instruments taxonomy should be found. We can deal with this situation by simply annotating the data in batches, where the first release could be based in existing data from Jamendo - of course, tied to a complex instruments taxonomy. That is, if I understood well from your paper, what you pretend by proposing an incremental evaluation: find an easy start, and move on towards fully solving the task.
And most importantly, I think that now is time for discussing which reference complex instruments taxonomy we want to have as MIR community. Otherwise we are wasting our annotation efforts and we cannot compare results!
As a final remark, and to motivate you to use these more complete taxonomies (ontologies, semantic spaces):  some researchers in the computer vision field claim to have bridged the semantic gap. Why? Because the results in the ImageNet Challenge show that researchers are now able to predict concepts (WordNet semantic space) from raw data (pixels of an image). Wouldn't it be great to move towards that direction?

I'm interested in this problem and would be happy to take responsibility.
I'm involved in developing an ontology for sound events.  Currently it has
~600 nodes, some 120 of which are musical instruments; the structure is
pretty shallow, and the coverage is not trying to be definitive for musical
purposes, but it's supposed to span the distinctions that a "typical"
listener can easily make.  I'm not proposing this as a solution, but it
does mean I have some experience with the difficulties of creating this
kind of thing.
I'm interested in broad input here.  My impression is that there's a
tendency to get excessively technical and fine-grained.  Wikipedia leans on
Hornbostel–Sachs https://en.wikipedia.org/wiki/Hornbostel–Sachs, which I
guess is the favored scheme for ethnomusicologists, but which strikes me as
a bit pedantic.
My ideal would be to have a hierarchy with a few dozen
readily-distinguishable instruments that could be quickly and reliably
judged by non-expert listeners, then to provide for finer distinctions
within those classes to cover cases where more detailed labeling is
important.
Of course, the idea of the "typical" listener is hugely problematic, since
it's so dependent on experience.  I personally think it's reasonable to
expect people to distinguish a tenor and soprano sax, but I would have a
lot of trouble naming any instruments from other cultures like China,
India, etc.  I suspect the solution might be to give up on universality and
instead go for multiple parallel hierarchies specialized for particular
music styles.
DAn.
On Tue, Aug 30, 2016 at 2:02 AM, jordipons<EMAIL_ADDRESS>wrote:

Maybe you want to take a look at: http://isophonics.org/content/
musical-instrument-taxonomies
ImageNet is great because it is based on WordNet - that is a "semantic
space", an ontology. Quoting the ImageNet web site: "Each meaningful
CONCEPT in WordNet, possibly described by multiple words or word phrases,
is called a 'synonym set' or 'synset'". Maybe is a good idea to use one of
these ontologies, similarly as ImageNet uses WordNet as a backbone. As far
as I know, musical concepts are not well represented in WordNet. This is
why I propose taking a look to the link above.
I agree that the Jamendo taxonomy is probably a good place to start,
specially because it is the most easy option (audio and taxonomy are
already available). However, using a complete and well structured ontology
as a backbone might be a bigger step for a "sustainable MIR evaluation"
since the annotation efforts are oriented towards fully solving the task.
These ontologies are supposed to completely describe the "instruments
space" and probably are more complete than a regular taxonomy.
Please note that this comment contradicts Frederic position :). Maybe a
compromise between taxonomy derived from existing data vs. complex
instruments taxonomy should be found. We can deal with this situation by
simply annotating the data in batches, where the first release could be
based in existing data from Jamendo - of course, tied to a complex
instruments taxonomy. That is, if I understood well from your paper,
what you pretend by proposing an incremental evaluation: find an easy
start, and move on towards fully solving the task.
And most importantly, I think that now is time for discussing which
reference complex instruments taxonomy we want to have as MIR
community. Otherwise we are wasting our annotation efforts and we cannot
compare results!
As a final remark, and to motivate you to use these more complete
taxonomies (ontologies, semantic spaces): some researchers in the computer
vision field claim to have bridged the semantic gap. Why? Because the
results in the ImageNet Challenge show that researchers are now able to
predict concepts (WordNet semantic space) from raw data (pixels of an
image). Wouldn't it be great to move towards that direction?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/omec/bedevere/issues/2#issuecomment-243341314, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAhs0WuY5lMuGnsLEYpHvPbnNj39oDhmks5qk8dggaJpZM4JgYwm
.

Awesome! thanks for volunteering. :o)
I agree, the HS categorization, while right, is like animal species for wordnet -- a bit overkill for our "version zero" purposes, I think.
Perhaps the taxonomy discussion is a bit easier if we peer a little bit down the road to where future iterations could go. One possible progression:

now: a smallish taxonomy of instruments over a decently large collection
next: more instruments, more data
later: non-musical sounds, general sound source identification

If this is the general roadmap at 30k feet, then our immediate goals are something like

identify an initial set of K music instrument classes
design a generic approach to defining this taxonomy such that it can be expanded, i.e. there will be multiple versions
begin to plan for / acknowledge instruments that are not captured in the v0 taxonomy, but otherwise punt for now

In this formulation, it'd be sufficient to draw that line at, say, "the top 100 instrument labels in the Jamendo collection" (less those like "synthesizer" or "computer" because obviously). Then, we can define a mapping into our more general, scalable taxonomy, that can be expanded as we move beyond this collection and these instruments.
For my part, if we can, as a community, solve 100-class instrument recognition over web scale collections, that would be flat out amazing. And then we can tackle the next 100 or 1000 instruments once proving to ourselves we can get that far. I think an overarching goal of this project is going to aim for the simplest thing that gets us to a meaningful result that we can iterate on.
thoughts?

forgot to mention:

My ideal would be to have a hierarchy with a few dozen readily-distinguishable instruments that could be quickly and reliably judged by non-expert listeners, then to provide for finer distinctions
within those classes to cover cases where more detailed labeling is important.

+1000

My ideal would be to have a hierarchy with a few dozen readily-distinguishable instruments that could be quickly and reliably judged by non-expert listeners, then to provide for finer distinctions within those classes to cover cases where more detailed labeling is important.

+1 as well, but I think we must make an effort first to define the task, even if our definition is vague, wrong or incomplete. I have the feeling that some decisions in terms of instrument taxonomy will have to do with it, such as level of complexity. Or maybe just the kind of annotations we gather, I don't know.
For now, I also agree that we should probably focus on things that the average person could identify, even if that means that our dataset is initially biased towards Western music. The same goes with the initial set of instruments; I agree with @dpwe.
In any case, given that defining the instrument taxonomy will not be a straightforward task, should we maybe start with task definition, use case and data?

One possible response:

task definition: "Select all musical instruments you hear in the following recording."
use case: "As a maintainer of a large audio library, I want to know what instruments occur in a given recording so that I can take subsequent action on this knowledge."
data: N second excerpts drawn from popular creative commons content, i.e. Jamendo

One extra source of instruments is MusicBrainz: http://musicbrainz.org/instruments
The criteria for inclusion here is "there exist at least 2 recordings in the MusicBrainz database which use this instrument". This means that every instrument on the list is related to at least a few recordings in MB.
It shouldn't be difficult to get a rank of most popular instruments, which could help to choose the most common ones in an initial list. This could also serve as a ground-truth for confirming annotations (although the annotations in MB are likely from metadata [cd listings] instead of user-listening)

May I add, love the discussion, but can we add to this proposal 'here is the database back-end features inside annotation storage we require to implement this'? Can we then attach it to #5 ?

As a start, will this require a meta-table describing instrument groups? Do we need search capability on audio linked metadata to find all annotations of particular instruments?

Are there any additional data needed in separate tables? Do they require references to annotators? genre or other metadata linked to specific audio?

been getting some great feedback while taking this show on the road -- one solid suggestion I wanted to repeat here is to aim for tractability / minimal ambiguity, and thus improving our chances of a successful experiment, i.e. keep it simple.
A ballpark of ≈25 instruments in year one is probably a good goal, prevents over-reaching, and might make it easier to grow the taxonomy into hierarchies later (guitar -> [guitar-acoustic-nylon, guitar-electric-clean, ...], voice -> [voice-male, voice-female, voice-choir], and so on).
I'm curious to dig into the Jamendo collection and see what track instrument tag occurrence counts look like. Might help steer things a little bit. Thoughts?

Hi,
I'll extract the Jamendo instruments taxonomy from their site and also gather a list of instrument annotations from the metadata. I'll upload data here so we can have a look.
I guess I'll have collected all the data between today and monday.

coooool, that'd be great! Specifically I was planning on trying to compile a JSON dump like
{
  track_id_0000: [ instrument_A, instrument_D ...],
  track_id_0001: [ instrument_C, instrument_X ...],
  ...
}

so that we could (a) sample track IDs based on instrument occurrence, (b) take a look at the trackwise co-occurrence matrix, and (c) look at an overall instrument distribution. Is that what you were thinking or something better / different?

Sooner than expected (how many times does this ever happen?), I could collect the data and I just uploaded it to the repo:

Dictionary with Jamendo's instruments taxonomy
Dictionary with Jamendo's instruments taxonomy with instruments as keys
Instrument annotations per track (as @ejhumphrey mentioned)

(please feel free to move files around in other folders, I did not know where to place them so I created this structure hoping that other people will do similar things for their taxonomies/data and will upload it in sibling folders)
The instruments taxonomy has been manually gathered from Jamendo Licensing explore catalog interface.
Please remember that we're just computing this from a ~20k tracks set from Jamendo for which we already have data (including audio in flac format). There is more content in Jamendo that we can probably also use.
For your enjoyment, here are the 25th most used instrument annotations in the Jamendo data we have:

instrument
count

drum
5762

voice
4921

piano
4102

synthesizer
2121

bass
2061

guitar
1769

electricguitar
1631

keyboard
1156

computer
1096

acousticguitar
727

strings
577

saxophone
360

cello
224

trumpet
196

violin
156

sampler
154

drummachine
154

flute
145

classicalguitar
138

electricpiano
129

accordion
123

harp
85

percussion
80

orchestra
78

ukulele
71

Here's a similar table to frederic's, with the number of instrument annotations in MusicBrainz.
Note that this only finds annotations present on recordings ("Person x played instrument y on recording z"). This relation also exists at an Album level. Voice/vocals isn't included as it's a separate relation type.
Some instruments are children of instruments that also exist in the list (saxophone/alto, guitar/bass/electric/acoustic/etc). Some relationships contain additional attributes, "solo", "additional", "guest", "background", which I haven't included.
Is it useful for this to get more data from this database? Any ideas about what to do next?

We have a preliminary matching of the tracks from jamendo to musicbrainz (only ~1000 of the 20k that we have, though). We could see how many of those matches also have attributes and if they match to the Jamendo data.
We can group some instruments by a single parent higher in the hierachy
We can split instruments based on solo/guest/background attributes
We can add release-level attributes (where we make the assumption that this instrument is performed on all tracks in the release)

SELECT lat.name, count(*)
FROM l_artist_recording lar
JOIN link l ON lar.link = l.id
JOIN link_type lt ON l.link_type = lt.id
JOIN link_attribute la ON l.id = la.link
JOIN link_attribute_type lat ON la.attribute_type = lat.id
WHERE lt.name = 'instrument'
GROUP BY lat.name
ORDER BY count(*) DESC;

             name                  | count

--------------------------------------|--------
piano                                 | 259005
drums                                 | 145927
guitar                                | 138879
violin                                | 100461
bass                                  |  87235
trumpet                               |  58697
cello                                 |  52158
percussion                            |  49340
keyboard                              |  47182
bass guitar                           |  37654
trombone                              |  35779
tenor saxophone                       |  33763
organ                                 |  31263
double bass                           |  28030
electric guitar                       |  26737
harpsichord                           |  24955
viola                                 |  23758
flute                                 |  21689
saxophone                             |  21389
guest                                 |  21364
alto saxophone                        |  21080
strings                               |  21029
acoustic guitar                       |  19213
solo                                  |  17243
guitars                               |  16383
clarinet                              |  16360
synthesizer                           |  15424
electric bass guitar                  |  10378
additional                            |   9525
baritone saxophone                    |   9186
oboe                                  |   7861

based on the already awesome efforts of @alastair and @ffont, I put together this instrument taxonomy proposal for further discussion.
https://docs.google.com/document/d/14Dx8X_sjYLZa4TVfdYM0ti83zwVlMuaYdfqqGO8a4Fo/edit?usp=sharing
In the interest of getting on with things and hitting our two-week milestone (https://github.com/cosmir/open-mic/milestone/1), this will be open for a week, at which point we should put together a JSON schema and submit as a pull request.
sound good?

AFAIK, this is the final taxonomy, right?
If so, someone familiar with JAMS please create a JSON file, and I'll publish it, along with an HTML-friendly version, in the website.
Do we have any (sort of) official audio samples for each instrument?

Plucked string

Guitar
Ukulele
Bass
Mandolin
Banjo

Orchestral string

Violin
Cello

Wind

Flute
Clarinet
Oboe
Saxophone

Brass

Trombone
Trumpet

Keys

Harpsichord
Organ
Piano
Accordion
Electric Piano
Synthesizer

Percussion

Cymbals
Drums
Glockenspiel

Other

Voice
Harmonica
Harp

We could easily find some in Freesound ;)
I can contribute finding a number of example sounds from Freesound for each instrument.
I guess we should have a page for this with links/embeds to the sounds?
We probably also need non-isolated examples of instruments (i.e. in "polyphonic" music).
This will be better found outside Freesound.


The reference to the document in the commenter's comment is incorrect.

Hi,
The commenter will include a link to the document in their comments, but that link is not currently valid (not sure if it is for all comments)
see: https://github.com/mugioka/tfsec-example-project/pull/1

fixed by #20


Handling labels web

Handling labels created
Label create, update, delete, label list added.
Label create is possible in create issue page, issue list page and label list page

need to check

need to check

to resolve conflict

to resolve conflict


Search action

abc

@dashwave /review

@dashwave /review

@dashwave /review

@dashwave /review

@dashwave /review

@dashwave /review

@dashwave /review

@dashwave /review

@dashwave review

@dashwave /review

@dashwave /review

@dashwave /review

@dashwave /review

@dashwave /review

@dashwave /short-review


install: A few minor patches

install: Add a spinner for container deployment
This can take substantial time.
Signed-off-by: Colin Walters<EMAIL_ADDRESS>
install: Be verbose for EFI creation and bootloader install
We previously changed the rootfs mkfs invocation to be
verbose; for consistency let's do the same for the EFI partition
as well as the bootloader run just so people can see
what's going on more.
Signed-off-by: Colin Walters<EMAIL_ADDRESS>
bootloader: Drop --src-root /
It's the default.
Signed-off-by: Colin Walters<EMAIL_ADDRESS>

I think we can ignore the failing tests here, the cargo fmt one is fixed in another PR, and I think the other rhel integration test fixes are in flight in another PR too.

On Tue, May 21, 2024, at 2:07 PM, John Eckersberg wrote:

👍 I sanity checked this on my system, it was too fast to actually see
the spinner but I verified it omits the Deployment complete output
and instead just puts out done as expected. I'm assuming if the
deployment was slower I would see the actual spinner 😄

If you're testing with podman-bootc you need
https://github.com/containers/podman-bootc/pull/37
and its followup in https://github.com/containers/podman-bootc/pull/41
to see the spinner.


Server not starting in ruby-2.4.1

Tests are failing after ruby-2.4.1 update with:
SunspotTest::TimeOutError: Solr failed to start after 60 seconds

It turns out that the ping url has changed

It was actually a different issue related to webmock in test.


⚠ Turnos 24x7 has degraded performance

In 9b72e7d, Turnos 24x7 (https://reservas-dev.alternativasinteligentes.com/) experienced degraded performance:

HTTP code: 200
Response time: 1015 ms

Resolved: Turnos 24x7 performance has improved in 2d40f39.


I am using react slick slider on click on colors i have i want to change the image of carousel

you can refer above image if user clicks on red color the car change to red color car image and same goes with other. how to achieve this. i am not able to change the active index

You can use custom paging feature
https://react-slick.neostack.com/docs/example/custom-paging
You can use CSS to place the dots at required position.
If the custom paging doesn't work for your use case, you can try slickGoTo
https://react-slick.neostack.com/docs/example/slick-go-to


Error being swallowed when listing providers?

Bug Report

(I'm a terraform user rather than developer, sorry if I've got these details wrong)

services/resources/mgmt/2016-02-01/resources?
48.1.0, I think

I'm using terraform, and seeing the azurerm provider hang at a point where it lists providers. I've raised https://github.com/terraform-providers/terraform-provider-azurerm/issues/9662, but they haven't got back to me yet, so I figured I'd see whether I could understand any of this myself.
I am a golang novice so may be way off base: is it possible that there's a missing return here?  Could that cause an error to be lost and, if so, might that result in these symptoms??
Even if this is completely wrong, any insight you can offer on what might be going wrong would be much appreciated!

The missing return does seem suspicious.  @ArcturusZhang can you please take a look?

The missing return does seem suspicious. @ArcturusZhang can you please take a look?

Yes it is the root cause. I will fix this for all the RPs in the next version of SDK


Added description to package.json

closes #59

:tada: This PR is included in version 2.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Support eSpeak

I've fixed eSpeak in this PR https://github.com/thevickypedia/py3-tts/pull/6
ie this https://github.com/willwade/py3-tts
we can link to my repo for now
to do it I really should rework sapi and espeak (both using py3-tts) in tts-wrapper which would make more sense first

NB syntax is - wierd (?) for espeak and SAPI #53
from tts_wrapper import SAPIClient, SAPITTS
client = SAPIClient('espeak') # eSpeak
client = SAPIClient('sapi') #SAPI
client = SAPIClient('nsss') #NSSS MacOS
# Initialize the TTS engine
tts = SAPITTS(client)


MINOR Handle new Gradle exit code behavior in deflake.yml

Gradle will now exit with 1 if any test fails, flaky or not. Update deflake.yml to handle this new behavior.

Small fix @chia7712, PTAL


Proposition value is unclear

discussion service (free OR services (paid) ?

For now we should fight to reduce text and push everything public and only
button the site should be an email us or like I said: For questions &
inquiries, email<EMAIL_ADDRESS>bigggg
On Thursday, February 4, 2016, Clément Renaud<EMAIL_ADDRESS>wrote:

discussion service (free OR services (paid) ?
—
Reply to this email directly or view it on GitHub
https://github.com/duangish/duangish.github.io/issues/21.

I resolved with edits.


Latest Dev Branch Update 35min Ago just scans for objects

Expected Behavior
Catching pokemon, using pokestops
Actual Behavior
Just scaning for objects
Steps to Reproduce
Starting the bot
i went back to master branch
Other Information
OS: Win7
Git Commit: (run 'git log -n 1 --pretty=format:"%H"' and paste it here)

I got the same issue when getting latest from dev branch. Hopes Developers can realize this soon.

I had this issue as well. Running pip install -r requirements.txt update and then deleting ./data/last-location* and ./data/cells* fixed the issue for me.

Always clear configs and old data on every new update.
@Kujawadl provided the fix.


Move Virtual Controllers to use Force instead of setting Linear Velocity directly.

So, here's a fun issue!
Right now, when you get moved around due to atmos pressure differences, the virtual controller for this sets a LinearVelocity.
Of course, this linear velocity must be unset sometime, so in the update method it is deccelerated as long as you're not weightless.
Notice a flaw?
If you get spaced due to atmos and then try throwing items to get yourself back to the station... You'll quickly notice it doesn't work.
This is why we should move virtual controllers to use forces, so we can do newtonian movement.

deprecated

The fifth incursion was defeated by PJB
Good night

reeee momentum moment when?

reeee momentum moment when?

WYCI got em


Read Generic info from D3 GameTable

This might be generally useful. The ReadString function should probably be replaced with a StreamReader method, I'd personally split ReadCString into a 0-terminated and \n-terminated variant. Not sure if you mind the Vector3Color helper.

Updated to use ReadCString and the Color(Vector3) constructor.


added changes to test CI

I am testing CI integration. This is PR is not for actual consideration.

This change is

going to close this while I figure out permissions.


Add links to HOWTOs from the main README

Started looking at this and raising an issue since there are different scopes:

Just add a link to the directory next to the "HOWTO guides" bullet under What is Flax?
Add sub-bulleted examples or link in "Utilities and patterns" (e.g., distributed training, polyak averaging)
Add a section much like the "Try Flax now by forking one of our starter examples" (e.g., example code for frequently-asked questions)

@avital @marcvanzee

We have (perhaps temporarily, not sure yet) deprecated HOWTOs after the move to Linen, so I'm closing this. We'll be trying to add more short "pattern notes" that aren't formally tested and simply live as small markdown files.


⭕package es6 bundles

Codecov Report

Merging #406 into master will increase coverage by 0.07%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
+ Coverage   83.45%   83.52%   +0.07%
==========================================
  Files         194      194
  Lines        4103     4103
  Branches      627      627
==========================================
+ Hits         3424     3427       +3
+ Misses        677      674       -3
  Partials        2        2

Impacted Files
Coverage Δ

src/legacy/connect/connectApi.ts
61.86% <ø> (ø)
:arrow_up:

src/client/client.ts
68.75% <ø> (ø)
:arrow_up:

src/common/privateFunctions.ts
81.08% <ø> (ø)
:arrow_up:

src/legacy/connect/index.ts
0% <0%> (ø)
:arrow_up:

src/legacy/bootstrap/index.ts
0% <0%> (ø)
:arrow_up:

src/legacy/enrollment/index.ts
0% <0%> (ø)
:arrow_up:

src/legacy/deviceDirectory/index.ts
0% <0%> (ø)
:arrow_up:

src/legacy/update/index.ts
0% <0%> (ø)
:arrow_up:

src/legacy/accountManagement/index.ts
0% <0%> (ø)
:arrow_up:

src/legacy/certificates/index.ts
0% <0%> (ø)
:arrow_up:

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbf35c0...180a8da. Read the comment docs.


propertMapping values not reflecting on newly deployed VM

I deployed VM by modifying deploy_ova.py and passed required configuration. I added Key:value under propertyMapping, but when VM is successfully deployed on ESXi host, i dont see any key:value being set on the VM, for e.g. root password, hostName etc.

@neo1205 - I know it's been a while since you posted, but did you ever get this resolved? My OVF has some custom properties, like:
property = (vim.vApp.PropertyInfo) [
   (vim.vApp.PropertyInfo) {
      dynamicType = <unset>,
      dynamicProperty = (vmodl.DynamicProperty) [],
      key = 0,
      classId = '',
      instanceId = '',
      id = 'activation_code',
      label = 'Activation Code',
      type = 'string',
      typeReference = '',
      userConfigurable = true,
      defaultValue = '',
      value = <unset>,
      description = 'Activation Code'
   },

and I'm trying to set them with:
    properties = [
        vim.KeyValue(key='activation_code', value=activation_code)
    ]
    cisp = vim.OvfManager.CreateImportSpecParams(entityName=vm_name, propertyMapping=properties)

But the VM doesn't apply the passed values. Any help would be greatly appreciated!


stake-pool: DepositStake only issues tokens for delegation.stake + min(undelegated_stake_rent, additional_lamports)

Fixes https://github.com/solana-labs/solana-program-library/issues/2260

@joncinque some notes on the choices made:

Additional lamports can be 0 or stake_lamports, and correspondingly, stake_deposit_lamports is delegation.stake + rent or delegation.stake, depending on the situation. I believe it has something to do with differences in how merging is performed depending on whether a stake account is fully activated (rent becomes inactive lamports) or is activating (rent becomes delegation.stake lamports).
The way I got it to work consistently is to consider the amount "credited" towards the total_stake_lamports and towards pool tokens to be the newly added delegation.stake + additional_lamports capped at the limit of the rent amount.
When the stake is fully active, all rent will fully use up the quota of additional_lamports, hence result in an adequate solution.

Looks great, thanks for the work!


[WIP] initial TensorFlow TFRecord integration with Keras

About TFRecords: https://www.tensorflow.org/api_guides/python/python_io
Code Source: https://github.com/indraforyou/keras_tfrecord
Primary Author: Indranil Sur @indraforyou
License: MIT (same as Keras)

@farizrahman4u How do I configure this code to pass on the theano backend? This code is a keras API for tensorflow TFrecords, so even the theano backend will need access to tensorflow by definition. Perhaps something like what's done in keras/backend/init.py?

By definition, this would be a feature that can only be used with the TensorFlow backend.

Well in theory it could probably run on the theano backend if tf is available strictly for dataset loading, but that should probably be addressed when there is a user that needs it.
@patyork I'm not sure what changes to make, what's the best way to skip this file when the tensorflow backend is not available?
Also, is the proposed datasets location appropriate? I was split between there and the backends folder...

It would run with the Theano backend in very specific circumstances, where the performance impact would negate any benefits that may or may not come from having the image preprocessing in an unusable graph.

TF would have to be installed
TF would have to be configured to either use the CPU, or to not allocate all GPU memory
The output from the TF graph would have to converted to Numpy arrays on the CPU before being passed to the Theano graph (negating any performance benefit of image processing on the GPU)
Compilation time of the TF graph alone would probably negate any performance gain, and that graph is not even usable within Theano
The data preprocessing is still limited by what TF provides (or you write yourself)

And no, any backend-specific code needs to be in the corresponding *_backend.py file.
Also, you're main problem is a compilation error: from keras.backend import tf should be import tensorflow as tf

And no, any backend-specific code needs to be in the corresponding *_backend.py file.

Are you saying I should move tfrecord.py directly into keras_contrib/backend/tensorflow_backend.py before it can be merged? Not completely sure that's the best fit yet, but I could do that.
All TFRecord code will depend on TF unless someone implemented a python+protobuf only backend for loading them, not actually that hard but also probably not high priority for anyone. I might implement something that converts TFRecord datasets to the more commonly used keras dataset formats though.

Also, you're main problem is a compilation error: from keras.backend import tf should be import tensorflow as tf

Thanks, I don't know how I missed that one.

any backend-specific code needs to be in the corresponding *_backend.py file.

I stand by this statement; how you go about moving all references to TensorFlow/tf.* into that file is up to you, but given that this is entirely tensorflow functionality, I don't see how it would be possible to split it up in any meaningful way. Also, the datasets module is about downloading/loading/returning actual numpy data for a specific dataset (e.g. mnist_data = keras.datasets.mnist.load_data()); it is not a place for generic data loading.
If you do manage to split up the code, I'd image the TF specific stuff goes into the TF backend, and any usage of that functionality might be in the preprocessing/image.py file.

any backend-specific code needs to be in the corresponding *_backend.py file.
I stand by this statement;

No problem! I'll move it right over.

specific dataset (e.g. mnist_data = keras.datasets.mnist.load_data()); it is not a place for generic data loading.

I plan to write/integrate a couple of specific datasets over the next few weeks. One of those is only available as TFRecords.

Before adding tests, is this the best design? Is there perhaps a way the existing fit() functions in keras/keras models could be parameterized to reduce the duplicate code necessary to support the new TFRecord data format and thus the backend code could reduce duplication and become much more minimal?

I would argue its a bad design.. I quickly made the code working to meet @ahundt 's bounty deadline. Rewrite of both compile and fit can be avoided.
I would suggest to make an extra param say tfrecord and pass it to compile(). In compile() if the param is True,  sample_weight, targets placeholders are not enabled. The param can be saved as a member of the model and be used in the fit function appropriately.

@indraforyou so you're suggesting that for upstream Keras-2?
I don't think a parameter explicitly named tfrecord would necessarily be ideal, since it wouldn't help with the next format added. Probably the best option in the end would be like what's done for the tensorflow backend, where a data format backend could be incorporated and specialized for HDF5 and tfrecord.
However, data format backends seems much larger scope. Perhaps the current basic function is sufficient for the moment and a separate issue should be created until there is both more interest and a dataset available?

Nice work! This feature is definitely interesting since it's a problem in a lot of organizations. HDF5 and tfrecord seem to be the 2 format of choice. I will try to review the PR today and add some comments. The integration in a clean way seems tricky.

@farizrahman4u that merge seemed to break travis

We could maybe merge this PR when it will be repaired and warn the user that it is an experimental feature? This way we will be able to test tfRecord with Keras and see where we could integrate these functionalities in the core code. What do you think?

@tboquet I would because I've tested it manually, but I can't accept pull requests. If you want to try out the code you can clone it from my fork or do it with github's hub command line command. https://github.com/github/hub

I'll try during the weekend and I will also open a PR to fix the pep8 errors. Weird that it's showing up here.

Thank you @indraforyou , @ahundt for this excellent work. This was much needed for my project and it works like a charm. Also this patch was one of the reason I switched from TFLearn to Keras around 5 days ago.
I have few questions to extend this work further.

How can one use validation data in fit_tfrecord function?
How to do the data augmentation?

@tboquet What are the next steps to merge this?
@ibadami have you been using this?
Is anyone interested in pushing this functionality through to be merged?

Hi @ahundt, what's the status on this? These are nice functionalities especially with the tf.contrib.data library.

I think it needs some reworking. I tried to discuss the next steps at https://github.com/tensorflow/tensorflow/issues/8787 but haven't really heard back.

hi @ahundt
thanks for spearheading this movement. commented on the tensorflow issue to show some interest.

I've done a second round of this upstream, I'd appreciate some testing + fixes + review from anyone who is interested:
https://github.com/fchollet/keras/pull/6928
I'll probably close this pull request soon since https://github.com/fchollet/keras/pull/6928 will be a significant improvement once it works.

@ahundt sounds good!

https://github.com/fchollet/keras/pull/6928 now passes the unit tests so I'm closing this.


Someone attend HSPC meeting Sept 28-30 in Phoenix, AZ

HSPC Meeting – September 28-30 – Phoenix, AZ
Please join us for our next HSPC meeting, September 28 – 30 in Phoenix, AZ. The meeting will be held at the Scottsdale Conference Center and Resort.
Please note that in order to cover the costs of the meeting, there will be a $300 registration fee per person. Registration information forthcoming.
HSPC Agenda 201509

I took a look at the agenda...there is a mix of technical and other...let me know if we need to send someone senior and or tech otherwise happy to go and take notes

Given the timing - is this conference no longer an option and we can close this issue?


Mobile View Not Responsive

Hi Gaurav, I really like this component and am getting it to work nicely with react-headroom. In your demo versions when using the dev tools to checkout mobile view everything looks fine. That said, when I check the mobile view in my app (starting from scratch) it is not translating and the sidenav is out of view. I'm not able to pinpoint the difference in the elements currently, nor am I seeing any media queries...if you have any input or if this is a bug please let me know. Thanks in advance for your help!
Casper

Hi Casper,
Thanks! I'm glad you like it.
About the responsive issue, it might be possible that some media quires based css or any css reset rules on your app is overriding sidenav's css. Can you share the code if possible.
Also make sure there is no css overrides for nav element(<nav>), if this is the case you can use prop navStyle to set default css with !important rule to make it work.

Gaurav


transaction/provider-org@type and transaction/receiver-org@type should use an OrganisationType codelist dropdown

transaction/provider-org@type and transaction/receiver-org@type both allow freetext rather than insisting types come from the OrganisationType codelist. Validation doesn’t appear to catch this, either when saving the transaction or when marking the activity as complete.

@andylolz Thank you very much. Your assistance is much appreciated.


[Bug]: Erroneous/Unnecessary PermitRootLogin warning during installation

Description
During the installation process I get the following error:
###############################################################################
WARNING: PermitRootLogin is not enabled in /etc/ssh/sshd_config.
It is set to yes
no. Should be prohibit-password, yes or without-password.

Please make sure it is set, otherwise Coolify cannot connect to the host system.

(Currently we only support root user to login via SSH, this will be changed in the future.)
###############################################################################

However, the PermitRootLogin is set to yes (confirmed via manual testing and running sshd -T|grep permitrootlogin.
Minimal Reproduction (if possible, example repository)

Run curl -fsSL https://cdn.coollabs.io/coolify/install.sh | bash as root

Exception or Error
No response
Version
4.0.0-beta.285

I am unable to reproduce this issue, please upgrade to the latest version of Coolify v4 and try again, and if this is still an issue, feel free to reopen this issue or create a new one.


[#11584] dddx_bound is set twice for PiecewiseJerkPathOptimizer

fixes #11584

linked issue: https://github.com/ApolloAuto/apollo/issues/11584


expose bounds class

I have to use bounds class, to my plugin for implement #230 in clusters marker

please fix merge conflicts, thanks!

#317 new pr


error: linking with rust-lld failed: exit status: 1

Problem
Hi I following the https://lowenware.com/blog/osdev/aarch64-bare-metal-program-in-rust/
try to test aarch64 bare-metal under QEMU.
Seems meet error and I can't find how to solution.
(I've try a lot way from google search....)
~/.cargo/bin/aarch64-bare-metal$ rustup target add aarch64-unknown-none
info: component 'rust-std' for target 'aarch64-unknown-none' is up to date
~/.cargo/bin/aarch64-bare-metal$ cargo -v xbuild --target=aarch64-unknown-none.json
error: failed to run rustc to learn about target-specific information
Caused by:
process didn't exit successfully: rustc - --crate-name ___ --print=file-names -Cembed-bitcode=yes --target /home/hank/.cargo/bin/aarch64-bare-metal/aarch64-unknown-none.json --crate-type bin --crate-type rlib --crate-type dylib --crate-type cdylib --crate-type staticlib --crate-type proc-macro --print=sysroot --print=cfg (exit status: 1)
--- stderr
error: Error loading target specification: may not set is_builtin for targets not built-in. Run rustc --print target-list for a list of built-in targets
error: "/home/hank/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/cargo" "rustc" "-p" "alloc" "--release" "--manifest-path" "/tmp/cargo-xbuildsuBC5o/Cargo.toml" "--target" "aarch64-unknown-none.json" "--" "-Z" "force-unstable-if-unmarked" failed with exit code: Some(101)
Steps
No response
Possible Solution(s)
No response
Notes
No response
Version
~/.cargo/bin/aarch64-bare-metal$ cargo version --verbose
cargo 1.57.0-nightly (c7957a74b 2021-10-11)
release: 1.57.0
commit-hash: c7957a74bdcf3b11e7154c1a9401735f23ebd484
commit-date: 2021-10-11
host: x86_64-unknown-linux-gnu
libgit2: 1.3.0 (sys:0.13.23 vendored)
libcurl: 7.79.1-DEV (sys:0.4.49+curl-7.79.1 vendored ssl:OpenSSL/1.1.1l)
os: Ubuntu 18.04 (bionic) [64-bit]

What command did you run that gave you that error message? What did you do to set up the environment?

You need to remove the is_builtin field from the aarch64-unknown-none.json target spec file.  That field is no longer allowed to be set (https://github.com/rust-lang/rust/pull/86062), so it needs to be removed if you are building the spec from --print target-spec-json.
Closing as this isn't related to cargo.  If you have further issues with getting started with some bare metal development, I suggest trying one of the user forums or chat platforms like discord.

Okay~~Many thanks for your help.


Playlist finder

Hello,
I am curious to build a tool that looks through a list of played songs, and detects playlists based on song repetition.
Would this database-builder help with that or would you recommend looking at other open source last.fm projects?

Hi @renesemela ! Thank you for your MA work, it is very good! I'm hoping to use the db file you shared. I saw the links for other datasets in the README, but the actual original datasets are no longer on those pages. Instead they have small subsets. Do you or the Brno University happen to still have the MSD? I'm not looking for music tracks just the dataset.
Many thanks!!!
New Last.fm Dataset 2020 for music auto-tagging purposes. This dataset is based on the concept of the original Last.fm Dataset which is based on the [Million Song Dataset] <--- no longer available there
(http://millionsongdataset.com/).
This dataset is a by-product of my masters's thesis (see repository).