Do we need a general interface that all system outputs are explorable and filtered?

Something like this: http://datalab.nlpedia.ai/#/normal_dataset/617685b833e51a7edda1cecb/dataset_samples  @OscarWang114 @lyuyangh (or maybe see @neubig 's opinion)
This is what we have now: http://explainaboard.inspiredco.ai/systems

@pfliu-nlp Interesting, I think it could be an extended functionality in the current "single system analysis" feature we have. It could be potentially useful since the histograms we provide have a fixed range (e.g., a bar represents sentence length 1 to 100 and cannot be changed). So if users want to explore cases with sentence lengths 1 to 50, they'll have to do it themselves. With this feature, we provide users the flexibility of browsing and filtering the system outputs by the criteria they define.

From Pengfei:
Some background about user-oriented & real-time bucketing and Evaluation:
Here is one similar case, from Rubrix:
https://rubrix.readthedocs.io/en/stable/guides/metrics.html#2.-Rubrix-Metrics-for-NER-training-sets
More generally, users can have a query q, then the tool (e.g., ExplainaBoard) can calculate  performance(metric, dataset|q)
where q could be

one condition that decides a bucket of test samples, e.g,  sentence length > 10
a bucketing rule, e.g., sentence length: (0,10] [20, 30], [30,]
a bucketing dimension and number of buckets, e.g., sentence length, 3
two bucketing dimensions and number of buckets e.g., sentence length, entity length, 3x3
other more

So far, we can assume that we have tabular data, where each row consists of (1) test sample or id information , (2)features  (3) predictions
Then what we need to do to achieve the above query-oriented & real-time bucketing and evaluation is:

sample searching w.r.t  the given query
evaluation over samples

All the above is just for single system analysis, and queries could also be made over multiple systems.
Note that most of the time, (1)(2) can be obtained directly from datalab, and users just need to add (3) into datalab's test set

I think @pfliu-nlp's idea is great. Using a query instead of buttons/sliders is flexible and saves work on the frontend. We can parse the query in the web interface and call the relevant functions in the SDK to get the analysis results. We can start working on this feature after the feature for saving sufficient statistics is implemented?


Improve authorization middleware

Improve authorization middleware to cover everything under /prod except static files and Toolpad dev server.
This way, the same middleware can be used to redirect to sign in and protect the RPC, among other things.

Looks good. Annoying that we have a parallel dev and prod implementation. A more ideal implementation would be one single function which switches on/off certain middleware based on a dev flag. That would guarantee consistency in ordering of the middlewares between the two environments. The challenge would be to avoid loading vite in prod. That's what causes high memory spikes on startup, even if a vite devserver isn't initialized.


Additional tests for #3168

These were a part of tests @lifthrasiir was preparing for https://github.com/PyO3/pyo3/issues/3165, and I believe it's worthy to add them (any single of them fails in the current main branch).

I moved the two commits from #3175 here as I could not push a rebase there.
bors r+


Some SVG elements misplaced when using Internet Explorer

In this example, lines are misplaced by half their stroke-width, both horizontally and vertically: jsFiddle.
Using Internet Explorer 11. No problems in Chrome.

Hmm, I have a similar issue on IE11 (no problems in Chrome or FF).
I'm using MathJax to display MathML content. The content is on a 'span', then I convert the html element to canvas (using html2canvas v.0.4.1). The problem is on IE11 the mathML content is cut off and misplaced.
Please help.
Thanks!

+1


Reader not discovered in handoff mode on S700 Devkit

Describe the bug
The following versions cause discoverReaders to never return a reader to connect to:
implementation("com.stripe:stripeterminal-core:3.8.0")
implementation("com.stripe:stripeterminal-handoffclient:3.8.0")

While 3.7.0 seems to work fine:
implementation("com.stripe:stripeterminal-core:3.7.0")
implementation("com.stripe:stripeterminal-handoffclient:3.7.0")

I also have this problem while using 0.0.1-beta.20 of this package:
...
"@stripe/stripe-terminal-react-native": "0.0.1-beta.20"
...

While 0.0.1-beta.19 works fine.
I'm using this issue as reference for how to setup handoff mode.
To Reproduce
Steps to reproduce the behavior:

Install 0.0.1-beta.20 and build example-app
Deploy example-app through Stripe on physical S700 Devkit
Try to discover readers in handoff discovery mode
No readers discovered

Expected behavior
It should discover readers in the latest version.
Screenshots
If applicable, add screenshots to help explain your problem.
Stripe Terminal React Native SDK version

^0.0.1-beta.20

Smartphone (please complete the following information):

Device: S700 Devkit
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Updated my original description to change the Android package versions to 3.7.0 as that is the latest version that I can get to work.

I having this issue even using a bluetooth reader.

@thelight413 are you using an S700 device or something else?

I'm using my android phone and an android tablet. I was also having issues connecting to the reader even if it was discovered. But only on a fresh install, not when I restart the app.

Make sure that your connection token is not cached from your api. The provider makes several calls for a connection token and they all have to be new tokens. I was having a similar issue and that was the cause.I also cannot use beta20 of this package as the reader will not be discovered when on a physical device and not in simulated mode.On Aug 15, 2024, at 5:25 PM, thelight413 @.***> wrote:
I'm using my android phone and an android tablet. I was also having issues connecting to the reader even if it was discovered. But only on a fresh install, not when I restart the app.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

@rlfrahm I even recreated the issue on the example app. I am using render as a backend.

I had the same intermittent troubles when getting started. It wasn't until I reached out to Stripe on their Discord that it finally started working at least partially. I'd recommend opening a ticket there: https://discord.com/invite/stripe

@rlfrahm for your issue, did you wait till the sdk initialized?

Hello,
I have a similar issue using the Java/Kotlin SDK.
I get the following error message with the android sample app:
discoveryCallback onFailure
com.stripe.stripeterminal.external.models.TerminalException: RPC application error INVALID_REQUEST with message Invalid device_type: must be one of bbpos_wisepad3, stripe_m2, stripe_s700, bbpos_chipper2x, bbpos_wisepos_e, verifone_P400, simulated_wisepos_e, or mobile_phone_reader
    at com.stripe.stripeterminal.handoffclient.HandoffAidlRpcListener.onComplete(HandoffAidlRpcListener.kt:48)
    at com.stripe.core.aidlrpc.AidlRpcListener$Stub.onTransact(AidlRpcListener.java:74)
    at android.os.Binder.execTransactInternal(Binder.java:1021)
    at android.os.Binder.execTransact(Binder.java:994)

The error message seems to suggest that stripe_s700 are accepted for Handoff dicovery, but maybe not stripe_s700_devkit ?

@rlfrahm for your issue, did you wait till the sdk initialized?

Yes

Hello, I have a similar issue using the Java/Kotlin SDK.
I get the following error message with the android sample app:
discoveryCallback onFailure
com.stripe.stripeterminal.external.models.TerminalException: RPC application error INVALID_REQUEST with message Invalid device_type: must be one of bbpos_wisepad3, stripe_m2, stripe_s700, bbpos_chipper2x, bbpos_wisepos_e, verifone_P400, simulated_wisepos_e, or mobile_phone_reader
    at com.stripe.stripeterminal.handoffclient.HandoffAidlRpcListener.onComplete(HandoffAidlRpcListener.kt:48)
    at com.stripe.core.aidlrpc.AidlRpcListener$Stub.onTransact(AidlRpcListener.java:74)
    at android.os.Binder.execTransactInternal(Binder.java:1021)
    at android.os.Binder.execTransact(Binder.java:994)

The error message seems to suggest that stripe_s700 are accepted for Handoff dicovery, but maybe not stripe_s700_devkit ?

I've confirmed that with Stripe staff that the S700 devices should be in handoff mode and it's working for me now after downgrading versions. Are you by chance using production api keys or something? DevKit's only work in test mode.

I contacted my Stripe sales representative. He had to activate some flag in our stripe account to enable Apps on Devices. It works fine now. :green_circle:

@thelight413 i think your issue could be related to https://github.com/stripe/stripe-terminal-react-native/issues/789. Can you give it a try on the latest beta.21 release and let us know if that solves the issue?

it's working for me now after downgrading versions.
@rlfrahm is your issue related to Android version specifically? Have you tested with both Android and RN SDKs?

@nazli-stripe I believe this is now resolved in beta.21.


ionic problem

E:\Projects\HelleWord>ionic build android --release
[WARN] ionic build is for building web assets and takes no arguments. See ionic build --help.
   Ignoring argument android. Perhaps you meant ionic cordova build android?

[INFO] Running app-scripts build:
[18:35:10]  build dev started ...
[18:35:10]  clean started ...
[18:35:10]  clean finished in 20 ms
[18:35:10]  copy started ...
[18:35:10]  deeplinks started ...
[18:35:11]  deeplinks finished in 33 ms
[18:35:11]  transpile started ...
[18:35:14]  transpile finished in 3.49 s
[18:35:14]  preprocess started ...
[18:35:14]  copy finished in 3.71 s
[18:35:14]  preprocess finished in 139 ms
[18:35:14]  webpack started ...
[18:35:23]  webpack finished in 8.94 s
[18:35:23]  sass started ...
[18:35:24]  sass finished in 1.33 s
[18:35:24]  postprocess started ...
[18:35:24]  postprocess finished in 15 ms
[18:35:24]  lint started ...
[18:35:24]  build dev finished in 14.06 s

ionic cordova prepare
cordova prepare

You have been opted out of telemetry. To change this, run: cordova telemetry on.
Discovered plugin "cordova-plugin-statusbar" in config.xml. Adding it to the project
[18:35:29]  lint finished in 4.55 s
Failed to restore plugin "cordova-plugin-statusbar" from config.xml. You might need to try adding it again. Error: Failed to fetch plugin https://github.com/apache/cordova-plugin-statusbar.git via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
Error: cmd: Command failed with exit code 1 Error output:
npm ERR! code ENOGIT
npm ERR! No git binary found in $PATH
npm ERR!
npm ERR! Failed using git.
npm ERR! Please check if you have git installed and in your PATH.
npm ERR!      C:\Users\Looops1\AppData\Roaming\npm-cache_logs\2017-10-11T13_05_34_365Z-debug.log
[ERROR] An error occurred while running cordova prepare (exit code 1).

You have posted this on entirely the wrong project, and not followed the issue template.

ionic cordova build android --release

Hi @dhruvil31,
You probably want to move this issue to the ionic repo; https://github.com/ionic-team/ionic


MPRIS question

Dear all,
I just tested your application on my ubuntu system and works like a charm! I have two questions though:
I am using MPRIS to control the application from the terminal for example:
dbus-send --print-reply --dest=org.mpris.MediaPlayer2.spotifywebplayer /org/mpris/MediaPlayer2 org.mpris.MediaPlayer2.Player.PlayPause . Although that the functionality is there I have to send a SIGINT to dbus-send as it stalls. Do you know why this is happening?
In addition is it possible upon the application startup to start playing music immediately from a specific list (using MPRIS or terminal arguments)?
Cheers,
Panos

Please refer to support for keyboard media controls to fix the your SIGINT stall issue
MPRIS does have an openUri function which I had previously set up to play a certain track URI but the functionality has been accidentally removed as seen by Controller Line 127 where the function playTrack is not defined however this is what it should look like until I can implement it next
function playTrack (uri) {
     if (uri.indexOf('spotify:track:') < 0) return;
     SpotifyApi.api.request('player_play_track', [this.player_id, uri, 0, undefined]);
}

If you want to test this you can press Ctrl-Shift-I (letter i) to enter the Dev Console and input this into the console:
SpotifyApi.api.request('player_play_track', ['main', 'spotify:track:2ASYhdpeSSKBpY83i10Xz0', 0, undefined])

Dear @Quacky2200 ,
Thank you very much for your fast and complete reply! I have one last question, I want to try to build the source also for my Raspberry PI v3 with an arm processor.
Could you point out the procedure (it is the same like v1.0.0 that is in the readme or something changed to the current version)? Spotify web works fine with chromium on RPI and if an export to it is possible, then it can become easily adapted by a lot of people (there is no spotify-client for RPI!)
Cheers,
Panos

I am afraid that I don't have much experience trying to the application to work on a Raspberry Pi. However assuming you could find an ARM compatible pepper flash for Chrome, download Node.js and have some experience programming then I think you'd be able to just about pull it off.
Firstly it would be better to start off with a newer version of the application since it doesn't rely on Node and Electron binaries like v1.0.0. You could then use npm to install Electron, after that you would need to place the ARM libpepperflash.so in ./plugins/. The application will find the plugin with a processor suffix (aka 'x64', 'ia32', 'arm64') such as libpepperflash-arm64.so. You will also need to able to compile native bindings for d-bus support (at the moment I cannot remember all the libraries that I have installed to be able to compile them but any missing library modules will be easily searchable so that you can install them later). After that you should be able to use the application on the Pi but it would probably be quite slow as Chromium is heavy for ARM devices.

Thanks @Quacky2200 , the reason that I am interested in porting this player to RPI is to use some GPIO buttons to change the music via MPRIS and not using the graphical interface at all (start it minimized).
I will let you know with a PR if I made it, for now I consider this issue closed!
Cheers,
Panos


'hostname' is not found in schema

Describe the bug
Hello, unsure whether this is a bug or not.
I've consumed this package in our nx repo where I'm using a "ui" project that contains some stuff, I'm making a 'ui-e2e' repo which has successfully installed and generated the project.
Without making any futher modifications to what has been generated, i get the following error when trying to run the e2e tests:

To reproduce
Steps to reproduce the behavior:

generate e2e proj yarn nx generate @mands/nx-playwright:project <APP-NAME>-e2e --project <APP-NAME> and install playwright dependencies (my proj name is ui, therefore ui-e2e)
Run generated test which just checks the url is truthy

Expected behaviour:
Should spin up localhost and run playwright test, passing as it only checks the baseURL is truthy
Actual behaviour
Get the error 'hostname' is not found in schema as shown in screenshot.
Apologies if I've missed something obvious here in order for this to work out the box, I'd appreciate any guidance! Many thanks 🙏

Hi @Iress-AlexNorris!
I've tried this on our repository and on a different repository but I'm unable to reproduce this issue.
Looking at the steps you mentioned in the description, I can't see anything wrong assuming the full commands you run were:

yarn add --dev @mands/nx-playwright
yarn nx generate @mands/nx-playwright:project ui-e2e --project ui
yarn nx e2e ui-e2e

Is there any additional information you could provide please? Maybe a link to a repo where this issue is reproducible, although I appreciate this may not be possible for you in case of a private repo.

Hi @andreacaldera, apologies i forgot to reply/close this issue as it turned out it was just my NX configuration that was messed up and i didn't configure my projects correctly and tried again and it works.
Many thanks!

@Iress-AlexNorris just ran into the same issue, do you remember what was wrong with your NX config?

@Iress-AlexNorris ran into this issue as well. Do you recall what you did to resolve this? The only difference I can think of is that I install and run with npm and not yarn.

I am seeing this issue too. I tried creating new nx workspaces, with npm and yarn. Both result in seeing this error.

Here is one https://github.com/boskiv/playw-hostname
➜  playw git:(master) yarn nx e2e playw-e2e
yarn run v1.22.19
$ /Users/iskiridomov/code/personal/not-published/playw/node_modules/.bin/nx e2e playw-e2e

> nx run playw-e2e:e2e

 >  NX   'hostname' is not found in schema

 ——————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

 >  NX   Ran target e2e for project playw-e2e (505ms)

    ✖    1/1 failed
    ✔    0/1 succeeded [0 read from cache]

   View structured, searchable error logs at https://nx.app/runs/hv39mkRE7z

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
➜  playw git:(master)

Thanks @boskiv, this is indeed a problem so will re-open this issue and work on a fix.
As a temporary solution maybe you could use:
yarn nx serve playw
yarn nx e2e playw-e2e --skipServe

cc @Lina90Karo @amkoehler @412andrewmortimer


Deploy the dang site

Deployed on this commit: https://github.com/joelouthan/book-theologicus/commit/76573308fc4ee8896d495b9d2a596b7a6b95f1ea


[Suggestion] [1.18/1.19] Config to lower sky culling y-level

If you get to y level 60 or below (or y level -60 for superflat worlds), the lower half of the sky gets culled:
Normal sky:

Below y level 60

It would be nice to have an option to disable it / edit the y-level this happens at.

Don't think I've ever ran into something like this when testing. I'll have to see if there's anything I can do to fix this.

You can now control this using the void_culling_level value in the environment section in the 1.3.2 update.


allow dataframes of different lengths to be concatenated when divisions are unknown

[x] Tests added / passed
[x] Passes black dask / flake8 dask

This PR makes it possible to join series and dataframes when their lengths differ. I believe this PR would make dask more consistent with it's own behavior and with pandas  (see code block below). I removed one test which made sure an error was thrown when concatenating dataframes of various lengths, but all others pass.  This PR will also be helpful in a separate PR where I am implementing the mode function https://github.com/dask/dask/pull/5958#discussion_r389158341 in dask as mentioned in https://github.com/dask/dask/issues/5744.
s1 = pd.Series([1, 2])
s2 = pd.Series([1, 2, 3])
s3 = pd.concat([s1, s2], axis=1)  # completes successfully

s1 = dd.from_pandas(pd.Series([1, 2]), npartitions=1)
s2 = dd.from_pandas(pd.Series([1, 2, 3]), npartitions=1)
s3 = dd.concat([s1, s2], axis=1).compute()  # completes successfully

s1 = dd.from_pandas(pd.Series([1, 2]), npartitions=1)
s2 = dd.from_pandas(pd.Series([1, 2, 3]), npartitions=1)
s1.divisions = (None, None)
s2.divisions = (None, None)
s3 = dd.concat([s1, s2], axis=1).compute()  # prior to this PR threw error "ValueError: Concatenated DataFrames of different lengths"

I believe that this can result in incorrect results.  I am not confident that this is a safe change.

Agreed. Pandas aligns as part of concat. I think as written this would not do alignment (which would be very expensive to do) so you'll get the wrong result..

Here is an example:
s1 = pd.Series([1, 2], index=pd.Index([5, 6]))
s2 = pd.Series([1, 2, 3], index=pd.Index([2, 3, 6])
s3 = pd.concat([s1, s2], axis=1)  # shape = (4, 2)

# Using this PR
sd1 = dd.from_pandas(s1, npartitions=1)
sd2 = dd.from_pandas(s2, npartitions=1)
sd1.divisions = (None, None)
sd2.divisions = (None, None)
sd3 = dd.concat([sd1, sd2], axis=1).compute()  # shape = (3, 2)

#s3
Out[16]:
     0    1
2  NaN  1.0
3  NaN  2.0
5  1.0  3.0
7  2.0  NaN

# sd3
     0  1
0  1.0  1
1  2.0  2
2  NaN  3

There is a UserWarning generated when sd3 is created:
/home/grout/projects/dask/dask/dataframe/multi.py:1052: UserWarning: Concatenating dataframes with unknown divisions.
We're assuming that the indexes of each dataframes are
 aligned. This assumption is not generally safe.
  "Concatenating dataframes with unknown divisions.\n"

Thank you all for your comments.  I am going to close this PR since I'm not prepared to make this change right now.
I was not able to reproduce @groutr's example (different versions of pandas?), but here is variation of @groutr's example which did show erroneous results for me in case I or someone else picks this back up again in the future.
import pandas as pd
import dask.dataframe as dd

s1 = pd.Series([1, 2, 3, 4], index=pd.Index([5, 6, 7, 8]))
s2 = pd.Series([1, 2, 3], index=pd.Index([2, 3, 5]))
s3 = pd.concat([s1, s2], axis=1)

# Using this PR
sd1 = dd.from_pandas(s1, npartitions=2)
sd2 = dd.from_pandas(s2, npartitions=2)
sd1.divisions = (None, None)
sd2.divisions = (None, None)
sd3 = dd.concat([sd1, sd2], axis=1).compute()

# sd3 is not as expected


Suggestion: real sized images brainstorming

This is not really an issue but something to brainstorm for a possible idea
Something that I like in "viewnior" (the default image viewer we use) is that it opens my images in their real size by default (or at least with my settings), this means that if the image is small, the window showing it is small (in their real size), and if is big, well, maybe is limited to my max-resolution...
So when im working on something and I want to know the quality of an image, i simply open it fast in viewnior to see that (so if the image has a low quality it will show me a not-so-big window), or maybe a resized photo to know if was in their original size or if was resized a bit smaller, that is much more friendly than "looking to the image size numbers", wich also the correct feeling of "how many pixels it fits on my screen?"
Update:
Oh, i just tried it and i got how it works... if you open multiple images with it, the window-size is set to a fixed size (and the images are resized to it), thats the same behaviour of entice, but if you open a single image, the window opened is on the size of the image (and thus, showing it on real-size dimensions), that is quite friendly!
By othe side I see that if the image is bigger than the screen resolution (or more exactly a 80% of it), it shows it resized instead of real-size :thinking:

please update to the latest git, i've fixed some issues
in the settings (right click), there is an option to autofit the image. Uncheck it and entice, will display the image at its size
check the title bar for the real image size and zoom %

@Thanatermesis by default, the image is fitte to the window.

to unfit it, press 'f' key
if you want to disable 'best fit' at startup, open settings and uncheck the corresponding option

@Thanatermesis about resizing the window to the size of the image, rage has a 'n' shortcut. Would it be sufficient for you ?

yes 'n' sounds like to do the job :)
what i wonder if is entice should be set like "n" by default when is run to display a single image

@Thanatermesis  'n' shortcut implemented
about the default behavior, idon't know. I'll think about it

or entice -real-size file.jpeg
-real-size would do the same than 'n' shortcut
would it be sufficient ?

the argument is not needed if we have the 'n' key :)
but i just wonder what makes you think is not good to have by default (only when a single-image is passed to be opened), of course if there's a "max" limit to not have a window bigger than the screen size

i can add an option to the settings if you want. You set it once and for all

no, it will not work
@Thanatermesis actually, when I pass one file, i parse the directory. So i can notice there is only one file if the directory has 1 image in it. So, i am not sure that it is very interesting to resize the window. Strike 'n' should be enough
or, like best fit, i can add an option so that the window is always resized by default for all images
tell me what you prefer


Set database name via environment variable

Allow to specify a custom database name using the VELUM_DB_NAME environment variable.
The code falls back to the old value when the environment variable is not set.
This is needed to solve some issues with the new CI system.

I think we should backport this to the 1.0 branch. Any objections?


Voucher in mulichannel

I want to merge this change because adds vouchers to a multichannel solution.

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: CU-6a5ty2 Add mutation to create/update voucher in channels

Task linked: CU-6a5tyh Add model to store Voucher data per channel

Task linked: SALEOR-160 Migrate old data to multichannel approach


Advice for combining aerial fog color

Hi Eric, first of all, I´m sorry because this cannot be considered an issue. Your work is amazing and I really enjoyed implementing this. 👍
I have problems combining the aerial fog color with the scene´s color. To my understanding, this should be a postprocess at the end of frame.
However, if I feed final pixel color to retrieve the aerial fog I lose all "indirect lighting" contribution of my scene. This is due to the fact that for computing the sun irradiance your implementation is using the normal of the surface, therefore all surface which is pointing away from the sun looks black or almost black.
Is this even the correct way of doing it? I don´t know if I am missing something important. Thank you very much :)

Yes, it is possible to adapt the algorithm to use it as a postprocess effect. See for instance http://gamedevs.org/uploads/deferred-rendering-of-planetary-terrains-with-accurate-atmospheres.pdf.


Some recognization problem

hi,
Thank you for sharing such demo, it is perfect
i am developing a score play app on mobile, i use audio unit to record, but i found sometime, when i play the piano for [4D,6D], it recognized [4D], but not every time, do you have such problem?
And sometime i play more pitches one time, i will miss one or two.

In 4D, 6D, 4 and 6 mean an octave? (also, D mean pitch?)

In 4D, 6D, 4 and 6 mean an octave? (also, D mean pitch?)

YES

Sry.
Today, I will test latency and certain notes are not recognized and leave a comment.


Test for Paris-Traceroute MDA

Paris-traceroute's MDA algorithm outputs a graph that doesn't fit the trace test by a long shot:
# paris-traceroute --a mda -q 1 <IP_ADDRESS>
mda to <IP_ADDRESS> (<IP_ADDRESS>), 30 hops max, 30 bytes packets
0 None -> <IP_ADDRESS> [{ 0*1, 0*2, 0*3, 0*4, 0*5, 0*6, 0*7, 0*8 } -> {  1*1, 1*2, 1*3, 1*4, 1*5, 1*6, 1*7, 1*8 }]
1 <IP_ADDRESS> (gateway) -> <IP_ADDRESS> [{ 1*1, 1*2, 1*3, 1*4, 1*5, 1*6, 1!7, 1!8 } -> {  2 1, 2 2, 2 3, 2 4, 2 5, 2 6 }]
Lattice:
None -> [ <IP_ADDRESS> ]
<IP_ADDRESS> -> [ <IP_ADDRESS> ]
<IP_ADDRESS>

Need to design a test for this.

Note after conferring with the PuNDIT people:  This is not what they're using.  It's just plain paris-traceroute.


c# imageelement GetAttribute("visual") retturn System.Collections.Generic.Dictionary`2[System.String,System.Object]

The problem
I use method FindElementsByImage, it return not similar elements and I want to debug process.
I change settings
driver.SetSetting("getMatchedImageResult", true);
driver.SetSetting("imageMatchThreshold", 0.5);
but when I try use he_col.First().GetAttribute("visual") I get string "System.Collections.Generic.Dictionary`2[System.String,System.Object]"
Environment

Appium version 1.21.0
Desktop OS/version windows 10
Node.js version 14.16.0
Mobile platform/version Android 11
Real device xiaomi

Could you share the appium server log as well?

as you can seein log good data, but in visual studio not good

This was fixed in appium@beta: https://github.com/appium/appium-base-driver/pull/489


Issue with 3D scene items inheritance

I have the following issue with current master with example/plot3dSceneWindow.py:
File "examples/plot3dSceneWindow.py", line 136, in <module>
    clipPlane = items.ClipPlane()  # Create a new clipping plane item
  File "silx/gui/plot3d/items/clipplane.py", line 52, in __init__
    Item3D.__init__(self, parent=parent, primitive=plane)
  File "silx/gui/plot3d/items/core.py", line 92, in __init__
    qt.QObject.__init__(self, parent)
TypeError: __init__() missing 1 required positional argument: 'plane'

The issue is with PyQt5 (tested with 5.12.1 and 5.14.2) but with PySide2 it works fine.
This looks to be due to https://github.com/silx-kit/silx/commit/d9a11d543c5885346562e161ed46a19c19ff23bf
ClipPlane is the only item with this issue, so it seems to be related to the fact that the mix-in takes an argument (as PlaneMixIn does).

This is related to this: https://www.riverbankcomputing.com/static/Docs/PyQt5/multiinheritance.html?highlight=inheritance and the method resolution order.


Latest symplify/coding-standard requires abandoned package

https://github.com/Symplify/Symplify/blob/9f5a461b202a2d7f76ade6fcee953d4ddbc96485/packages/CodingStandard/composer.json#L13
Maybe it was just forgotten in composer and isn't actually used?

The package itself is deprecated, but still used in Symplify 5.
It's removed in Symplify 6.

I'll unabbandone it now, since I get more confused report like this.
Thanks for feedback.


Switch to C++17

Just seeing if everything compiles first.

Fingers crossed!

Looks like some errors from jsbindings.cpp, but maybe these are legitimate?

Looks like some errors from jsbindings.cpp, but maybe these are legitimate?

Weird, let me pull the branch and play around with this.


Hyundai Ioniq? Already has ACC & LKAS

If I were to get a Hyundai Ioniq, is it possible to use this software with it, considering it already has these features? I see something about the CAN-bus hacking... wondering if anyone has ever tried this on a Hyundai or know how to get started.

I will love to use test it with my Hyundai i30, let us know is it feasible.

Same goes for me. Would love to test on hyundai i30

I would test it for my Hyundai i40. Could you share some more info. on it?

is it possible to test with Hyundai Accent Manual?

You can only control a car that already has built in safety features
Built in LKAS means you can add steering
Built in ACC means you can add accelerator+brake

any luck? its been a year?


ADOP-2488: Fix fortify open-redirect issues

Change description

Updates save and redirect call to confirm that the url redirecting to is valid (uses existing logic as the check to ensure the 'next page' is valid too.
Ensure lang is coming from the list of supported languages (it was, but now it's more compliant with fortify...)

JIRA link
ADOP-2488
Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

Have tested the changes, all functionality expected at this stage/version of adoption-web


IntelD415 unity RealSenseSDK2.0 couldn't open the intelD415 camera

window10/C#  Unity's SDK2.0 couldn't open the intelD415 camera
ExternalException: rs2_pipeline_start_with_config(pipe:000000000086AD20, config:000000000086AEA0) Rethrow as Exception: Couldn't resolve requests
Can someone help me to solve this problem, thank you very much

Hi,
I am stuck too, getting same error. If you got the answer post it here please.

same here


UIExplorer TextInput auto scroll view example

I've been struggling to try to get my view to scroll up when a <TextInput> is focused. I looked at UIExplorer for guidance and didn't see anything. I've looked around for solutions and found several regarding wrapping content in a <ScrollView> and then using refs and callbacks to move content dynamically on focus() and blur() I think it would be a great addition to update the example app, UIExplorer, to show this use case. It seems quite common from my experience and questions like those below:
http://stackoverflow.com/questions/29313244/how-to-auto-slide-the-window-out-from-behind-keyboard-when-textinput-has-focus
http://stackoverflow.com/questions/30546742/react-native-how-to-move-screen-up-on-textinput
http://stackoverflow.com/questions/29685421/react-native-hide-keyboard

I found this on Stackoverflow - worked for me nicely.

/**
 * Handle resizing enclosed View and scrolling to input
 * Usage:
 *    <KeyboardHandler ref='kh' offset={50}>
 *      <View>
 *        ...
 *        <TextInput ref='username'
 *          onFocus={()=>this.refs.kh.inputFocused(this,'username')}/>
 *        ...
 *      </View>
 *    </KeyboardHandler>
 *
 *  offset is optional and defaults to 34
 *  Any other specified props will be passed on to ScrollView
 */
'use strict';

var React=require('react-native');
var {
  ScrollView,
  View,
  DeviceEventEmitter,
}=React;

var myprops={
  offset:34,
}
var KeyboardHandler=React.createClass({
  propTypes:{
    offset: React.PropTypes.number,
  },
  getDefaultProps(){
    return myprops;
  },
  getInitialState(){
    DeviceEventEmitter.addListener('keyboardDidShow',(frames)=>{
      if (!frames.endCoordinates) return;
      this.setState({keyboardSpace: frames.endCoordinates.height});
    });
    DeviceEventEmitter.addListener('keyboardWillHide',(frames)=>{
      this.setState({keyboardSpace:0});
    });

    this.scrollviewProps={
      automaticallyAdjustContentInsets:true,
      scrollEventThrottle:200,
    };
    // pass on any props we don't own to ScrollView
    Object.keys(this.props).filter((n)=>{return n!='children'})
    .forEach((e)=>{if(!myprops[e])this.scrollviewProps[e]=this.props[e]});

    return {
      keyboardSpace:0,
    };
  },
  render(){
    return (
      <ScrollView ref='scrollView' {...this.scrollviewProps}>
        {this.props.children}
        <View style={{height:this.state.keyboardSpace}}></View>
      </ScrollView>
    );
  },
  inputFocused(_this,refName){
    setTimeout(()=>{
      let scrollResponder=this.refs.scrollView.getScrollResponder();
      scrollResponder.scrollResponderScrollNativeHandleToKeyboard(
        React.findNodeHandle(_this.refs[refName]),
        this.props.offset, //additionalOffset
        true
      );
    }, 50);
  }
}) // KeyboardHandler

module.exports=KeyboardHandler;

@yamill Thank you for sharing!

You can use my plugin
https://github.com/baijunjie/react-native-input-scroll-view


Enable @wordpress/stylelint-config

Which issue, if any, is this issue related to?

See https://github.com/stylelint/stylelint-ecosystem-tester/issues/39

Is there anything in the PR that needs further explanation?

Blocked on https://github.com/WordPress/gutenberg/pull/59933
Gutenberg uses a bespoke setup to emulate workspaces.
I would like to avoid adding support for their custom setup and instead wait until they align with standard npm workspaces.

I would like to avoid adding support for their custom setup

Agree. Let's wait for upstream improvement.

see also WordPress/gutenberg#65681

Thank you for linking that @Mouvedia
Nice to see that this is something they are actively working on.

WordPress/gutenberg#66272

WordPress/gutenberg#66272 has been merged.


fix video not showing on iOS Safari by playsinline

Hi Vincent,
In the browser example code, I found videos are not showing properly on iOS safari, like black screens or not auto played... These bugs could be fixed by simply add playsinline attribute to the video tag for the iOS 10 afterwards. For iOS 9 onwards could use library like iphone-inline-video.
Thanks.
Leo

Heyho,
Thanks for the fix!


feat: Use generic configurator for maps

This PR tries to use generic configurator for maps:

to be able to better manage changes to the maps configuration (and to prepare for handling of Ordinal Measures),
to be more consistent with the way other encodings are handled (e.g. to enable segment field we have to select a dimension via a select element, while for maps we use checkbox to show layer).

Design changes approved by @AnninaWalker :)

I do not see the former bugs that we had on maps with the canton borders being offseted on Edge 🎉

LGTM, 👏 , I've added suggestions to improve selectors/actions in test. Feel free to move this to another issue, if it cannot be tackled right now.


Couldn't downlaod csv in given location

I tried downloading csv file of the chart(table format) in the local location, when I debug the code it gets into the exportChart function inside explore/exploreUtils/index.js and when it reaches the final line , the output is in the form of payload response such as,
{datasource: {…}, force: true, queries: Array(1), form_data: {…}, result_format: 'csv', …}
datasource: {id: 2, type: 'table'}
force: true
form_data: {datasource: '2__table', viz_type: 'table', slice_id: undefined, cache_timeout: undefined, url_params: undefined, …}
queries: [{…}]
result_format: "csv"
result_type: "full"
[[Prototype]]: Object
I expanded the output and checked, but there were only the table name and id in the place of datasource, I coulnd't understand whether how to download that datasource as a csv file in local location ?

not reproducible on master, I am able to download csv of table chart.
if you could provide superset version, chart version someone will be able to help.

not reproducible on master, I am able to download csv of table chart. if you could provide superset version, chart version someone will be able to help.

@mayurnewase Did you able to download by editing the code and giving the location manually (making it to download inside certain folder) ? Because when I tried changing the code, as it is a react some article mentioned that it is not possible to give the location explicitly in client side

This is likely fixed by now, and is pretty out of date if not. If people are still encountering this in current versions (3.x) please open a new Issue or a PR to address the problem.


add apis to read the performance data

the appium already has a way to gather the performance data by log.
but If the resulting data format is set to a log file, the user should conduct another parsing to show the data on the screen.
also I think user wants to decide the moment to read the data and associate the performance data and other information like test case #.
so I’d like to add apis to gather the performance data.

The CLA bot is having problems. Ignore it.

@heeseon the CLA bot is not having problems anymore, but you need to configure your git client to use your github email or username. See https://help.github.com/articles/setting-your-email-in-git/

What I have to do more?

One last thing: Can you squash into a single commit?

Sorry, I can't understand what you mean. Could you explain it more in detail?

I mean that we would like this functionality to be in a single commit, rather than 24. Git provides functionality to "squash" the commits so that we do not have irrelevant things in the commit history.
You can google it. This is a good introduction: https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/

Thank you for your answer. I understand what you mean. I can do it 9 hours later.

Is something wrong to squash merge in github?

Did doing it manually not work? It is generally better in our experience to give the author the control. I can do it if you don't want to.

I need history that I did contribute the open source. If you do it as my account, so I have the history, than please help me.
But I still have to contribute something more to appium like crash report, please guide me to do myself it next time.
Thank you!!!

Whatever we do, you will be in the history. We want that as much as you!
And we appreciate all your work
On Fri, Nov 11, 2016 at 5:53 PM heeseon hwang<EMAIL_ADDRESS>wrote:

I need history that I did contribute the open source. If you do it as my
account, so I have the history, than please help me.
But I still have to contribute something more to appium like crash report,
please guide me to do myself it next time.
Thank you!!!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/appium/appium-android-driver/pull/186#issuecomment-260074446,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACfkUlJB5O4H3TEAxbCquIbPZ7ybKAzjks5q9PIAgaJpZM4KkTo2
.

then now am I contributor for appium-android-driver ?
How I check it? I can't check my name both in master branch and in contributor list ?

You can see the contributors here: https://github.com/appium/appium-android-driver/graphs/contributors


Add 2 community examples running on nRF52840 microcontroller

Can you order these alphabetically in the list, ignoring superfluous words like "swift-for"

I did it per platform, as that seemed to be the logic applied so far


Error updating hive class

When I try update a hive class, following this rules, I get this error: Unhandled Exception: type 'Null' is not a subtype of type 'List' in type cast

Version

Platform:  Android
Flutter version: 2.0.1
Hive version: 2.0.2
hive_flutter: ^1.0.0
hive_generator: ^1.0.1
build_runner: ^1.12.2

Try setting default value for added not-nullable properties.
@HiveField(6, defaultValue: const [])
List<String> notes;

Try setting default value for added not-nullable properties.
@HiveField(6, defaultValue: const [])
List<String> notes;

defaultValue can only be boolean
The argument type 'List' can't be assigned to the parameter type 'bool'

You have to upgrade hive and hive_generator to latest version. It's a new feature.

Try setting default value for added not-nullable properties.
@HiveField(6, defaultValue: const [])
List<String> notes;

defaultValue can only be boolean
The argument type 'List' can't be assigned to the parameter type 'bool'

You have to upgrade hive and hive_generator to latest version. It's a new feature.

Its work, thanks.


MKV Files won't play on some devices due to MIME type

This application looks to use video/x-mkv as the mime-type header for .mkv files, but some devices seem to rely on video/x-matroska.
Also tried to download the source to try to fix it myself, but the solution relies on having the SQLite interop dll's for the Util project. Not sure where to get them (tried the obvious official site, but they didn't give me the actual interop dll's.)

The SQLite stuff, and other dependencies, should be installed with nuget which is available for Window (incl. MS VS integration) and *nix via mono (MonoDevelop also has nuget integration built-in without requiring any additional installation IIRC)

At least for me it works without the interop libraries (Windows 7 and Lubuntu 14.10)

@JimmyJonesJr is correct. The "video/x-mkv" is incorrect and prevents the Roku 3 from seeing the files. The authoritative matroska.org confirms on https://matroska.org/technical/specs/notes.html that the MIME type should be "video/x-matroska". I have created pull #31 to this aim and can confirm it works on the Roku 3.

I know this issue is old, but I just stumbled across simpleDLNA, and am experiencing the same problem with MKV and Roku Streaming Stick+. This application seems to be the only one of it's kind, without installing something heavier that wants to do unnecessary transcoding, etc. Does anyone have a Windows binary with @matthew1471 's fix? Any update planned?

Does anyone have a Windows binary with @matthew1471 's fix?
@meztup I got you covered :)
I ran into the same problem myself and actually found binaries of Matthew's on antonio-bakula/ fork's site. (Kudos for that.) Check at the bottom http://www.antoniob.com/simple-dlna-fork

There really is nothing quite like SDLNA. It's good to see people are still interested in working on it.


Fix for #36

That fixed the issue for me, although I'm not sure if initial intent was to store gem lists as role attributes.

So, is this ever going to get pulled in?

@gregsymons:
TDI is a nice idea and all, but it's not practical. I don't think this repo is maintained or ever really was past its initial commit.
Monitoring daemons and exception handling are the real assertions of infrastructure as code


DEP Sync operation in SCCM requires manual input

Add clarification to the Hybrid scenario document indicating that the DEP sync operation between Intune and Apple is triggered "on demand" rather than through an automated task. To initiate the DEP Sync, the admin will have to click the "DEP Sync" button on the SCCM console under "All Corporate owned devices" to initiate the sync.

@pphadke,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@NathBarn Please review. @mention me when it's ready to merge.

@mtillman #sign-off Thanks!

@pphadke Thanks for your update. I made a couple of small edits per MS style guidance.


Prototype: Remove BAC modules

Build the general functionality to remove a BAC module from the user database

Released with version <IP_ADDRESS>


Reorder and tidy up Storybook component list

Feature Description
We would like to reduce the chaos inside the storybook component list, by moving and reordering current stories into groups that share the same component base.
e.g. sbb-menu and sbb-menu-action should stay in the same group sbb-menu, with all the others of the same kind.
Documentation should be moved and merged too, from the single component story to the main one.
Component list (TBD)

[ ] sbb-accordion (contains sbb-accordion-group + sbb-accordion)
[ ] sbb-alert (contains sbb-alert-group + sbb-alert)
[ ] sbb-button
[ ] sbb-card (contains sbb-card-badge + sbb-card)
[ ] sbb-chip
[ ] sbb-clock
[ ] sbb-dialog
[ ] sbb-divider
[ ] sbb-footer
[ ] sbb-group
[ ] sbb-header (contains sbb-header-action + sbb-header)
[ ] sbb-icon
[ ] sbb-image
[ ] sbb-journey-header
[ ] sbb-link (contains sbb-link-list + sbb-link + sbb-skiplink-list)
[ ] sbb-logo
[ ] sbb-map-container
[ ] sbb-menu (contains sbb-menu-action + sbb-menu)
[ ] sbb-navigation (contains sbb-navigation-action + sbb-navigation-list + sbb-navigation-marker + sbb-navigation-section + sbb-navigation)
[ ] sbb-selection-panel
[ ] sbb-signet
[ ] sbb-tab (contains sbb-tab-group + sbb-tab-title)
[ ] sbb-tag (contains sbb-tag-group + sbb-tag)
[ ] sbb-teaser (contains sbb-teaser-hero + sbb-teaser)
[ ] sbb-title
[ ] sbb-tooltip (contains sbb-tooltip-trigger + sbb-tooltip)
[ ] form-elements
[ ] timetable

In my opinion we need to discuss this topic as there are various issues with the idea:

Merging storybook...

...increases complexity of storybook files which makes them more difficult to understand from user perspective and more difficult to handle from our side.
...will increase costs for Chromatic drastically, as we can't use the story collection anymore for a lot of stories (e.g. in sbb-menu you have play stories but if also all stories of the sbb-menu-action will be included (which now inly cost 7 snapshots in Chromatic) then you will have a lot more snapshots (e.g. for 5 stories of sbb-menu-action you will then have 5*7 snapshots).

Automatic API documentation will not be useful anymore as all child components API don't show up e.g. in the group component.

In my opinion we shouldn't do this story but either create a separate documentation platform manually (e.g. https://lyne.sbb.ch) or rely on UX documentation (https://digital.sbb.ch). Storybook is also meant as kind of visual unit testing for each component or child component and not to be a full documentation platform.
As a light improvement we can maybe in child components better point to group components or vice versa so it's clearer in documentation to where something belongs.

Discussed via Teams with @jeripeierSBB. Currently preferred solution would be to group the relevant components in a folder together and not to move any components to internal.


fix some bugs

I found two bugs in the original codes and fixed them.
1: In set_scale_and_out_sz function, when out_shape is not None, the out_shape should be list(out_shape) + list(in_shape[len(out_shape):]) when backbend is numpy, since we need retain last dims.
2: Also in set_scale_and_out_sz function. The number of conv or period is the numerator of scale_factor other than the denominator, so we should find an approximate fraction with a limited numerator.

Everything seems to work well. Good fixes, thanks!
Only two things:

Can you drop the timing in the comments there?
Readme comment in brackets (out_shape / in_shape) is inaccurate, the scale_factor does not have to equal that, even in the by_conv case. Eg., you have sz 5 and upscale by 3/2. You can do it by_convs accurately with scale 1.5. out_sz will then be 8 != 5 * 1.5. (original was also inaccurate, it said scale_factor * in_sz whereas it should just be scale_factor)

Nice job, much appreciated. If you want to contrib more, you are welcome to (In particular I've been wanting to create a good ipynb with comparisons to other methods and many tests [compare to matlab simple cases, compare torch<->np for many configs etc, interactive flickering between result images to visually show misalignment that exists in other methods as opposed to this one etc.], and checking whether the weight multiplication can be done faster with einsum)

Thank you for your reply. I dropped unnecessary comments in the code. Also, your proposal is pretty interesting since I think the right resize is a subtle but essential component in many image processing problems, I am willing to participate in the follow-up progress.


Added popular VScode theme Night Owl

I also the formatted readme file.
@RunDevelopment , please review these changes.

@RunDevelopment , Thanks for the generous suggestion . Quickly fixing it.

I'm really sorry for the delay @SimpleIndian!
LGTM;


Wp-Cron not running as usual...

Confirmation

[X] My issue isn't already found on the issue tracker.
[X] I have replicated my issue using the latest version of the plugin and it is still present.

WordPress version
5
Cloudflare-WordPress version
4
PHP version
7
Expected result
Cron should run every minute, because woocommerce will run 'action_scheduler_run_queue' every minute. action scheduler is very important to run every minute if not some woocommerce task will run very very late.
Actual result
Cron will not run every minute.
Steps to reproduce

Install Wordpress
Install Woocommerce
Logout. Clear browser's site data including cookies.
Open browser's developer console, and move to network tab, and filter it using 'cron' as a keyword
Keep refreshing until wp-cron.php shows up (which will never happen until cloudflare TTL timeout)

Additional factoids
No response
References
No response

Thanks for raising this @erikdemarco however I'm not quite sure how this is related to the plugin's functionality. I suspect this is more a configuration issue that has been enabled on your domain and isn't related to the plugin itself. I'd suggest you review your cache settings within the Cloudflare Dashboard (not WordPress) and work through it from there.
Please let me know if I've misunderstood the issue here however if I have, can you please elaborate more on why this a bug in the plugin?

Thanks for raising this @erikdemarco however I'm not quite sure how this is related to the plugin's functionality. I suspect this is more a configuration issue that has been enabled on your domain and isn't related to the plugin itself. I'd suggest you review your cache settings within the Cloudflare Dashboard (not WordPress) and work through it from there.
Please let me know if I've misunderstood the issue here however if I have, can you please elaborate more on why this a bug in the plugin?

Hi @jacobbednarz
The way WP-Cron works is like this:
Every time a person calls one of your page. Every time WordPress goes to work, it checks to see if there are any cron jobs that need done.
If cloudflare makes every single call/pageload not hitting our server. How can WP-Cron know its time to run? Because there is nothing triggering the WP itself to run.
How to fix this is, Cloudflare plugin needs to check what it the smallest interval of wp-cron event. And then it should make 1 pageload for 1 visitor to hit our server. So WP-Cron can be triggered.

I still don't think that is an issue for the plug-in to solve. Have you had a look at overriding cache options for that path via the dashboard?


Inconsistent BITPOS: BITPOS bit=1 unaligned+full word+reminder

Steps to reproduce
Run the commands mentioned in the test on Line 326 in the file https://github.com/AshwinKul28/dice-tests/blob/main/tcltests/unit/bitpos.tcl#L326
Expected output
The expected output when the above set of commands when run on Redis
Expected [r bitpos str 1]

Observed output
The observed output when the above set of commands when run on DiceDB
216 (context: type eval line 10 cmd {assert {[r bitpos str 1]

The steps to run the test cases are mentioned in the README of the dice-tests repository.
Expectations for resolution
This issue will be considered resolved when the following things are done:

Changes in the dice repository code to meet the expected behavior.
Successful run of the tcl test behavior.

You can find the tests under the tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

Setup DiceDB locally
Setup Redis 7.2.5 locally
Setup DiceDB CLI

Hi @lucifercr07 , can you assign this task to me?

Hi @lucifercr07
Can I take this up ? Would love to work on it.
Thanks

@Nijin-P-S @jainbhavya53 Assigned other issues to both of you. Let's have a single issue on your plate at a time. Once that's completed you can pick other opened issues.

Hi @AshwinKul28 Can I take this up?

Hi @AshwinKul28 @lucifercr07 , can I please pick this up?

@dankot12 assigned, thanks for contributing.

Hello @dankot12,
There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.
We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.
Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.
Thanks again.

Hi @arpitbbhayani , thanks for reaching out. This issue was blocked due to #638 which was merged a couple of days ago. Please allow me one more day to complete this issue. Thanks

Hi @lucifercr07, I ran the tcl test for the unit test case that was failing and after the addition of APPEND cmd (#638), the unit test now passes.
Output:
[ok]: BITPOS bit=0 starting at unaligned address (0 ms)
[ok]: BITPOS bit=1 starting at unaligned address (0 ms)
[ok]: BITPOS bit=0 unaligned+full word+reminder (2 ms)
**[ok]: BITPOS bit=1 unaligned+full word+reminder (2 ms)**
[ok]: BITPOS bit=1 returns -1 if string is all 0 bits (5 ms)
[ok]: BITPOS bit=0 works with intervals (4 ms)
[ok]: BITPOS bit=1 works with intervals (2 ms)

In order to run the tcl tests, I made changes to the patch file (PR here: https://github.com/AshwinKul28/dice-tests/pull/11) as the patch file was outdated. @AshwinKul28, please review the changes when possible.
I think we can now close this issue. Please let me know what you think.

Hello @dankot12,
There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.
We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.
Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.
Thanks again.

Hi @arpitbbhayani @lucifercr07 @AshwinKul28 , this issue is already solved with other PRs. This issue can be closed now as I already mentioned above with appropriate tests.

Closing, merged as part of https://github.com/DiceDB/dice/issues/638


The complete Space Travelers'  Hub

What we did in this PR Me @Mofuhidy  and @tjay1760 :

Fetches data from the SpaceX API and stores it in Redux
Render lists of rockets, and missions.
Allows users to reserve rockets and join missions
Shows a "Reserved" badge and "Cancel reservation" button for reserved rockets
Shows an "Active Member" badge and a "Leave mission" button for missions that the user has joined
Lists all reserved rockets, and missions in the My Profile section

Testing:

Covered key components and functionalities with unit tests using React Testing Library and Jest.
Ensured all tests passed successfully.

Thank you for your review!

Thank you very much for your review @muneebulrehman 😸

You Approved our project but in the dashboard, it does not change the button to submit @muneebulrehman ?

You Approved our project but in the dashboard, it does not change the button to submit @muneebulrehman ?

@Mofuhidy, It should be approved by now. My internet went down the moment I was marking it as approved in the dashboard. Sorry for any inconvenience caused.

@muneebulrehman  Yeah now it's approve Thank you very much 😄🌹


Locally add style sheet delegates

set style interface should provide the possibility of adding style delegates to the style sheet, so that you can locally (where the elementum is) overwrite part of the style

solved with new style system


Add "collect-logs.ps1" script to deployment

Right now if the UI fails the user has a very hard time collecting logs. Make this process easy by providing a ps1 file that collects logs. This process will need to be run as administrator to access the log location

closed


[MINOR] Added list of SUPPORTED_MODELS to README

Codecov Report

Merging #132 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   85.37%   85.37%
=======================================
  Files          33       33
  Lines        1921     1921
  Branches       44       44
=======================================
  Hits         1640     1640
  Misses        281      281

Impacted Files
Coverage Δ

python/sparkdl/transformers/named_image.py
90.06% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a556c86...4f7e586. Read the comment docs.

I've tested this locally, so I'm going to merge it.


[Question]: Which examples are still working with the breaking changes of v0.74

Question Validation

[X] I have searched both the documentation and discord for an answer.

Question
New to llama_index, though mostly familiar with ML & Python etc
I can get the v0.74 demo code (below) working... but all the Jupyter examples I've tried are failing.
Is this due to the breaking changes of v0.74?
from llama_index import VectorStoreIndex, SimpleDirectoryReader
documents = SimpleDirectoryReader('data').load_data()
index = VectorStoreIndex.from_documents(documents)
query_engine = index.as_query_engine()
response = query_engine.query("What did the author do growing up?")
print(response)
`11

how is it breaking? that looks correct to me. Did you set your openai key?
If you are running in a notebook, you might need to set the API key in the env vars, as well as directly on the module
import openai
openai.api_key = "sk-..."

thanks,
I did have an expired OpenAI keyearlier.. but there are other issues
eg with/examples/paul_graham_essay/SentenceSplittingDemo.ipynb
LookupError                               Traceback (most recent call last)
Cell In[1], line 35
     29         f.write(
     30             "\n-------\n\n{}. Size: {} tokens\n".format(idx, len(tokenizer(doc.text)))
     31             + doc.text
     32         )
     34 nltk_splitter = NLTKTextSplitter()
---> 35 text_chunks = nltk_splitter.split_text(document.text)
     36 doc_chunks = [Document(text=t) for t in text_chunks]
     37 tokenizer = globals_helper.tokenizer

File ~/miniconda3-mac-silicon/envs/coreml_jupyter/lib/python3.10/site-packages/langchain/text_splitter.py:1008, in NLTKTextSplitter.split_text(self, text)
   1006 """Split incoming text and return chunks."""
   1007 # First we naively split the large input into a bunch of smaller ones.
-> 1008 splits = self._tokenizer(text)
   1009 return self._merge_splits(splits, self._separator)

File ~/miniconda3-mac-silicon/envs/coreml_jupyter/lib/python3.10/site-packages/nltk/tokenize/__init__.py:106, in sent_tokenize(text, language)
     96 def sent_tokenize(text, language="english"):
     97     """
     98     Return a sentence-tokenized copy of *text*,
     99     using NLTK's recommended sentence tokenizer
   (...)
    104     :param language: the model name in the Punkt corpus
    105     """
--> 106     tokenizer = load(f"tokenizers/punkt/{language}.pickle")
    107     return tokenizer.tokenize(text)

File ~/miniconda3-mac-silicon/envs/coreml_jupyter/lib/python3.10/site-packages/nltk/data.py:750, in load(resource_url, format, cache, verbose, logic_parser, fstruct_reader, encoding)
    747     print(f"<<Loading {resource_url}>>")
    749 # Load the resource.
--> 750 opened_resource = _open(resource_url)
    752 if format == "raw":
    753     resource_val = opened_resource.read()

File ~/miniconda3-mac-silicon/envs/coreml_jupyter/lib/python3.10/site-packages/nltk/data.py:876, in _open(resource_url)
    873 protocol, path_ = split_resource_url(resource_url)
    875 if protocol is None or protocol.lower() == "nltk":
--> 876     return find(path_, path + [""]).open()
    877 elif protocol.lower() == "file":
    878     # urllib might not use mode='rb', so handle this one ourselves:
    879     return find(path_, [""]).open()

File ~/miniconda3-mac-silicon/envs/coreml_jupyter/lib/python3.10/site-packages/nltk/data.py:583, in find(resource_name, paths)
    581 sep = "*" * 70
    582 resource_not_found = f"\n{sep}\n{msg}\n{sep}\n"
--> 583 raise LookupError(resource_not_found)

Just a comment:
many of the Jupyter examples are advanced level and don't seem to return much to the user...
I'll try look around for some more "I'm just. starting with llama_lindex" level examples

OK, the other was "user impatience"
Jupyter is very subtle about telling you it "is processing"
.. while other apps have spinner.. Jupyter just puts an asterix next to the processing that is running...

Sounds like you got it mostly figured out!
We are actually working on a giant docs refactor right now. Should be out in the next day or two. I hope you and others end up finding it helpful!

thanks Logan,
Yes.. the docs could do with some improvements. I have decades of development experiences.. but am new to ML. Many of the documents seems to be aimed at users with medium to advanced prior knowledge/experience in the space. For me that is not the case.
I like how langchain divides their docs into "Components" and "Use Cases".. this helps ease the learning curve and increase user/developer progress and satisfation.
Perhaps a glossary. For me also high level explanations help a lot. "Overall Concepts" Diagrams.
Keep up the great work 🏆

@ianscrivener about to merge the refactor in a few minutes! I hope you like it 🙏 still room to improve, but I think the flow and organization is much better


Create Tx and Conn interfaces to allow prepared statements to be used in transactions

sql.DB allows creating a Statement using DB.Prepare, and later this prepared statement can be used inside a transaction using tx.Stmt(). For this to work, both the statement and the transaction must be using the same underlining *sql.DB.
This library returns a raw *sql.Tx for transactions, but a custom Stmt for Prepare, which can't be used with tx.Stmt().
This MR creates Tx and Conn interfaces matching database/sql, and makes sure that transactions and statements works the same as the default ones.

Let's wait for the test result


[mesheryctl] improve the error messages shown to users for "mesheryctl pattern"

Description: Improve the error messages in mesheryctl commands from the user's perspective.
Commands in scope of this issue: mesheryctl pattern, mesheryctl pattern list, mesheryctl pattern apply, mesheryctl pattern view, mesheryctl pattern delete

We need to make sure of the following things

There are proper error messages when users

Give more arguments to a command than required
Misspell a command
Do not give the required input via flags or args
Use the command without any arguments or flags.

The error messages being displayed to users are meaningful from user's perspective. And if applicable, a potential fix for the problem should be shown too.  For example

"failed to unmarshal response body" could be modified to "couldn't process JSON response from server"
"manifest not found" could be modified to "manifest not found. Please provide the path to the app manifest."

@nishantwrp can you please assign me this issue? I want to work on it

@nik132-eng plesse confirm that you have mesheryctl built and that you’ve read the uX CLI considerations in Meshery Docs by showing output of you locally built CLI and dropping a copy of on of the UX guidelines in a comment.

@nishantwrp I updated the description to include the issue template's original resources in addition to your custom note.

since I see no updates , I am here to confirm that I have my setup ready . Can I go on with this @nishantwrp @leecalcote ?

Yeah sure @legendarykamal!


How to Wrap root with another parent?

Hi Just a question, is there a way to wrap the preferencefx window content into another Node?
I just want to wrap all the content in a stackpane... thank you.

Hi,
Yes that's possible. Check the "node" demo to see how it works: https://github.com/dlemmermann/PreferencesFX/tree/develop/preferencesfx-demo/src/main/java/com/dlsc/preferencesfx/node
You can also clone this repository and run the demo application to see it in action.
Hope that helps!


Image download button animation not right

Describe the bug
This is a design issue. The animation on hovering over the download button is a bit uncanny. There is a color shift towards a lighter green and the white text turns black. This gives a weird look to the entire process:

Expected behavior
Regular buttons animate in a more subtle way, clearly showing all different states (idle, hover, clicked). For example:

Occurs on every desktop browser.

@brenoferreira @kgodey
How about:

Giving it rounded corners as that of the above buttons
Keeping the text color white
Giving a slightly darker green color on hover

Closing this issue since it was fixed in #323.


reload configmap

Describe the bug
Using examples, I wrote one,but I found the app not reload configmap after execute 'kubectl edit cm demo-configmap', Then I delete the pod of app, it can get the latest config
Sample
my bootstrap.yaml

@damon008 , can you try naming your ConfigMap the same as the spring application?. Something like:
apiVersion: v1
kind: ConfigMap
metadata:
  name: edge-admin
  namespace: your-namespace

The management.endpoint.restart.enabled: "true" property is not really mandatory, at least in the latest releases.
Adding to that, I have been able to make that work on Greenwich.SR4 (and SR1, SR2, SR3).
        <spring-boot.version>2.1.8.RELEASE</spring-boot.version>
        <spring-cloud.version>Greenwich.SR4</spring-cloud.version>
        <spring.cloud.k8s.version>1.1.1.RELEASE</spring.cloud.k8s.version>

Unfortunately, if I change to Hoxton.SR1 the changes in a ConfigMap won't be reloaded anymore.

@lubumbax I add application.yaml for mybatis and server port and so on in my project.Does it have any influence?

what is the views of the official spring?

@lubumbax  do what you  said, the app run failed,
show the log:

@lubumbax I add application.yaml for mybatis and server port and so on in my project.Does it have any influence?

Not sure what "mybatis" means.
Combining an application.yaml with ConfigMap is fine. You can also add a bootstrap.yaml to that if you want. You can add properties to either of them.
I prefer (like many others) adding all possible app/service properties to ConfigMap and only those that are most critical for the app to start to bootstrap.yaml. That said, I would get rid of application.yaml and put as much as possible in ConfigMap.
The views of the official spring are well documented here:
https://cloud.spring.io/spring-cloud-static/spring-cloud-kubernetes/1.1.1.RELEASE/reference/html/#kubernetes-propertysource-implementations
My advise is that you make a thorough read of that chapter and see if something rings a bell.
A bit more about application.yaml vs bootstrap.yaml here.
Regarding the last screenshot, I can't really say what causes that exception. What dependencies have you added to your POM (assuming you are using Maven)?

@lubumbax
it print log when I edit cm configmap-name，it show me that it reload

The following levels of reload are supported (by setting the spring.cloud.kubernetes.reload.strategy property): * refresh (default): Only configuration beans annotated with @ConfigurationProperties or @RefreshScope are reloaded.
I use @ConfigurationProperties ，but I can not get the new value from the configmap of what I edit.

@lubumbax  Can you show your demo?

@lubumbax
Hello, I found what happened.After add db such as mybatis or redis when use the springcloud-kubernetes with configmap, the configmap can not be reloaded.
you can try when add db resource such as redis or mysql.
------------------ 原始邮件 ------------------
发件人<EMAIL_ADDRESS>发送时间: 2019年12月24日(星期二) 晚上6:56
收件人<EMAIL_ADDRESS>抄送: "530840587"<530840587<EMAIL_ADDRESS>主题: Re: [spring-cloud/spring-cloud-kubernetes] reload configmap (#506)
@lubumbax I add application.yaml for mybatis and server port and so on in my project.Does it have any influence?
Not sure what "mybatis" means.
Combining an application.yaml with ConfigMap is fine. You can also add a bootstrap.yaml to that if you want. You can add properties to either of them.
I prefer (like many others) adding all possible app/service properties to ConfigMap and only those that are most critical for the app to start to bootstrap.yaml. That said, I would get rid of application.yaml and put as much as possible in ConfigMap.
The views of the official spring are well documented here:
https://cloud.spring.io/spring-cloud-static/spring-cloud-kubernetes/1.1.1.RELEASE/reference/html/#kubernetes-propertysource-implementations
My advise is that you make a thorough read of that chapter and see if something rings a bell.
A bit more about application.yaml vs bootstrap.yaml here.
Regarding the last screenshot, I can't really say what causes that exception. What dependencies have you added to your POM (assuming you are using Maven)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.

@lubumbax   Do you have a similar problem?

Not really. I added the following dependencies to one of my services:
        <dependency>
            <groupId>org.springframework.data</groupId>
            <artifactId>spring-data-redis</artifactId>
        </dependency>
        <dependency>
            <groupId>redis.clients</groupId>
            <artifactId>jedis</artifactId>
            <version>2.9.0</version>
            <type>jar</type>
        </dependency>

Then configured a JedisConnectionFactory bean that connected to Redis running on another service.
A change in the ConfigMap of that service triggered reload.

@lubumbax  What kind of your JedisConnectionFactory? and about mysql , what kind of mybatis? about the bean

you can try this:
<dependency>
			<groupId>org.springframework.boot</groupId>
			<artifactId>spring-boot-starter-data-redis</artifactId>
		</dependency>
		<dependency>
			<groupId>org.springframework.boot</groupId>
			<artifactId>spring-boot-starter-redis</artifactId>
			<version>1.4.7.RELEASE</version>
		</dependency>

In my project, this can not

I try what uou said, I found it not reload before delete pod

I would need to get a link to a code repo with a sample application reproducing the issue; please provide it here.

@lubumbax
the demo code:
Base on
<parent>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-starter-parent</artifactId>
        <version>2.1.8.RELEASE</version>
        <relativePath/>
    </parent>

	<properties>
		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
		<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
		<java.version>1.8</java.version>
		<swagger.version>2.6.1</swagger.version>
		<xstream.version>1.4.7</xstream.version>
		<pageHelper.version>4.1.6</pageHelper.version>
		<fastjson.version>1.2.51</fastjson.version>
		<shiro.version>1.3.0</shiro.version>
		<!-- <kubernetes-client-version>6.0.1</kubernetes-client-version> -->
		<kubernetes-client-version>5.0.0</kubernetes-client-version>
		<fabric8-kubernetes-client.version>4.6.1</fabric8-kubernetes-client.version><!-- 对应k8s v1.15.3 -->
		<springcloud.version>Greenwich.SR4</springcloud.version>
		<springcloud.kubernetes.version>1.1.1.RELEASE</springcloud.kubernetes.version>
		<mysql.version>5.1.46</mysql.version>
	</properties>

redis :
<dependency>
            <groupId>org.springframework.data</groupId>
            <artifactId>spring-data-redis</artifactId>
        </dependency>
        <dependency>
            <groupId>redis.clients</groupId>
            <artifactId>jedis</artifactId>
            <type>jar</type>
        </dependency>

redis bean:
@Configuration
@EnableCaching
public class RedisCacheConfig extends CachingConfigurerSupport {
    private Logger logger = LoggerFactory.getLogger(RedisCacheConfig.class);

    private static JedisPool jedisPool;

    @Autowired
    private EnvConfig envConfig;

    /**
     * redis连接工厂
     */
    @Bean
    public JedisPool redisPoolFactory() {
        logger.info("redis url: " + envConfig.getSpring_redis_host() + ":" + envConfig.getSpring_redis_port());
        JedisPoolConfig jedisPoolConfig = new JedisPoolConfig();
        jedisPoolConfig.setMaxIdle(8);
        jedisPoolConfig.setMaxWaitMillis(10000);
        if(StringUtils.isBlank(envConfig.getSpring_redis_pwd())) {
        	 jedisPool = new JedisPool(jedisPoolConfig, envConfig.getSpring_redis_host(), Integer.parseInt(envConfig.getSpring_redis_port()), 10000);
        } else {
        	 jedisPool = new JedisPool(jedisPoolConfig, envConfig.getSpring_redis_host(), Integer.parseInt(envConfig.getSpring_redis_port()), 10000, envConfig.getSpring_redis_pwd());
        }
        return jedisPool;
    }

    public JedisPool getJedisPool(){
    	if(null == jedisPool){
    		redisPoolFactory();
    	}
    	return jedisPool;
    }

demo:
        @Autowired
	private RedisCacheConfig redisCacheConfig;

	@GetMapping(value = "/getTest")
	public String getTest() {
		Jedis jedis = null;
		try {
			JedisPool jedisPool = redisCacheConfig.getJedisPool();
			jedis = jedisPool.getResource();
			return envConfig.getBase_path();
		}
		catch (JedisException e) {
			logger.error("get redisResource failed", e);
		}
		catch (Exception e) {
			// TODO Auto-generated catch block
			e.printStackTrace();
		}
		finally {
			if (jedis != null) {
				jedis.close();
			}
		}
		return null;
	}

In EnvConfig, the value of base_path can not reload after edit cm

@lubumbax
Can you show your demo code?

@lubumbax
I care what kind of your pom?

After I edit cm, the log show it change and refresh.

but I cannot get the edited value with redis or mybatis (mysql), and if I remove db or some pertinent dependence of db (redis). or  I means if use db or redis in the project, it also can not reload the newest value after edited the configmap,but if without db or redis, it can

I am sorry but I don't really know why redis or mysql configuration would not be reloaded after a config change

@lubumbax  Can you show your all demo with redis or mysql?

would you please give this spin with version 1.1.3.BUILD-SNAPSHOT and report back your findings

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.


ML pipeline to run Classification tasks using Images in the Database

Description
This Pull Request Implements a pipeline to run classification tasks using the images in the database. The code for this PR resides at 2 places. First one is completely in the folder labellab_ML-Models/ . The rest of the changes in the code have been made in the file labellab-server/controller/classification/classificationControls.js
The changes can be broken down into following parts :

A flask app is created and setup in the folder labellab_ML-Models/ .
The flask app is used to interact with the various ML models supported by LabelLab.
A sample model MobileNet has been added which is used of multiple object detection and is lightweight as well as fast.
Now a request is made to this new flask server inside the file classificationControls.js
An image file is sent to the flask server which in turn returns the labels of various objects present in the image sent.

Fixes #285
This PR is related to my other Pull Request #365 which makes use of the flask app created here. These 2 Pull Requests together implement the pipeline as well as backend purely in flask
Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Model has been tested on various images. It gives good performance, but is unable to detect small entities like eraser.
Tests have been made by making requests using Scripts.

Test Configuration:
The tests were performed on Ubuntu 16.04 Machine.

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

This will be properly addressed in https://github.com/scorelab/LabelLab/issues/424 and https://github.com/scorelab/LabelLab/issues/425.