Python and R caching

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2633/Build result: FAILURE[...truncated 7 lines...] > /home/jenkins/git2/bin/git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > /home/jenkins/git2/bin/git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1885/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains 8f5e6a0335ccee70c6a1b51f8d6cbfa7c73cb188 # timeout=10Checking out Revision 8f5e6a0335ccee70c6a1b51f8d6cbfa7c73cb188 (origin/pr/1885/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f 8f5e6a0335ccee70c6a1b51f8d6cbfa7c73cb188 > /home/jenkins/git2/bin/git rev-list b38a1c5a35404152a1cc4e2b782329c3ae65d254 # timeout=10Triggering ADAM-prb ? 2.6.2,2.10,2.2.1,centosTriggering ADAM-prb ? 2.6.2,2.11,2.2.1,centosTriggering ADAM-prb ? 2.7.3,2.10,2.2.1,centosTriggering ADAM-prb ? 2.7.3,2.11,2.2.1,centosADAM-prb ? 2.6.2,2.10,2.2.1,centos completed with result SUCCESSADAM-prb ? 2.6.2,2.11,2.2.1,centos completed with result FAILUREADAM-prb ? 2.7.3,2.10,2.2.1,centos completed with result SUCCESSADAM-prb ? 2.7.3,2.11,2.2.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Jenkins, retest this please.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2634/Build result: FAILURE[...truncated 7 lines...] > /home/jenkins/git2/bin/git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > /home/jenkins/git2/bin/git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1885/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains 8f5e6a0335ccee70c6a1b51f8d6cbfa7c73cb188 # timeout=10Checking out Revision 8f5e6a0335ccee70c6a1b51f8d6cbfa7c73cb188 (origin/pr/1885/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f 8f5e6a0335ccee70c6a1b51f8d6cbfa7c73cb188 > /home/jenkins/git2/bin/git rev-list 8f5e6a0335ccee70c6a1b51f8d6cbfa7c73cb188 # timeout=10Triggering ADAM-prb ? 2.6.2,2.10,2.2.1,centosTriggering ADAM-prb ? 2.6.2,2.11,2.2.1,centosTriggering ADAM-prb ? 2.7.3,2.10,2.2.1,centosTriggering ADAM-prb ? 2.7.3,2.11,2.2.1,centosADAM-prb ? 2.6.2,2.10,2.2.1,centos completed with result SUCCESSADAM-prb ? 2.6.2,2.11,2.2.1,centos completed with result FAILUREADAM-prb ? 2.7.3,2.10,2.2.1,centos completed with result SUCCESSADAM-prb ? 2.7.3,2.11,2.2.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2635/Build result: FAILURE[...truncated 7 lines...] > /home/jenkins/git2/bin/git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > /home/jenkins/git2/bin/git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1885/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains f04cf650bdf92faa338e1e4f666a4725a6115dac # timeout=10Checking out Revision f04cf650bdf92faa338e1e4f666a4725a6115dac (origin/pr/1885/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f f04cf650bdf92faa338e1e4f666a4725a6115dac > /home/jenkins/git2/bin/git rev-list 8f5e6a0335ccee70c6a1b51f8d6cbfa7c73cb188 # timeout=10Triggering ADAM-prb ? 2.6.2,2.10,2.2.1,centosTriggering ADAM-prb ? 2.6.2,2.11,2.2.1,centosTriggering ADAM-prb ? 2.7.3,2.10,2.2.1,centosTriggering ADAM-prb ? 2.7.3,2.11,2.2.1,centosADAM-prb ? 2.6.2,2.10,2.2.1,centos completed with result SUCCESSADAM-prb ? 2.6.2,2.11,2.2.1,centos completed with result FAILUREADAM-prb ? 2.7.3,2.10,2.2.1,centos completed with result SUCCESSADAM-prb ? 2.7.3,2.11,2.2.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Jenkins, retest this please.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2636/
Test PASSed.

@heuermh  @fnothaft I added the functions to the GenomicDatsets, let me know if this is what you meant

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2638/
Test PASSed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2641/Build result: FAILURE[...truncated 7 lines...] > /home/jenkins/git2/bin/git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > /home/jenkins/git2/bin/git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1885/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains bd7fd8b7ec40f24e0adc6d35ea2fc1cb7ff73ee5 # timeout=10Checking out Revision bd7fd8b7ec40f24e0adc6d35ea2fc1cb7ff73ee5 (origin/pr/1885/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f bd7fd8b7ec40f24e0adc6d35ea2fc1cb7ff73ee5 > /home/jenkins/git2/bin/git rev-list 483e384cdb7a2c70d060ae1f0bad78185dac9da0 # timeout=10Triggering ADAM-prb ? 2.6.2,2.10,2.2.1,centosTriggering ADAM-prb ? 2.6.2,2.11,2.2.1,centosTriggering ADAM-prb ? 2.7.3,2.10,2.2.1,centosTriggering ADAM-prb ? 2.7.3,2.11,2.2.1,centosADAM-prb ? 2.6.2,2.10,2.2.1,centos completed with result SUCCESSADAM-prb ? 2.6.2,2.11,2.2.1,centos completed with result FAILUREADAM-prb ? 2.7.3,2.10,2.2.1,centos completed with result SUCCESSADAM-prb ? 2.7.3,2.11,2.2.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2645/Build result: FAILURE[...truncated 7 lines...] > /home/jenkins/git2/bin/git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > /home/jenkins/git2/bin/git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1885/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains 61d96a565ee68d5df559ce8e9aa2cae56db308e0 # timeout=10Checking out Revision 61d96a565ee68d5df559ce8e9aa2cae56db308e0 (origin/pr/1885/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f 61d96a565ee68d5df559ce8e9aa2cae56db308e0 > /home/jenkins/git2/bin/git rev-list 19bbe8fb4d36b65e55c67f33a177ae38fe510d1e # timeout=10Triggering ADAM-prb ? 2.6.2,2.10,2.2.1,centosTriggering ADAM-prb ? 2.6.2,2.11,2.2.1,centosTriggering ADAM-prb ? 2.7.3,2.10,2.2.1,centosTriggering ADAM-prb ? 2.7.3,2.11,2.2.1,centosADAM-prb ? 2.6.2,2.10,2.2.1,centos completed with result SUCCESSADAM-prb ? 2.6.2,2.11,2.2.1,centos completed with result FAILUREADAM-prb ? 2.7.3,2.10,2.2.1,centos completed with result SUCCESSADAM-prb ? 2.7.3,2.11,2.2.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2646/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2648/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2650/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2651/
Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2652/
Test PASSed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2654/Build result: FAILURE[...truncated 7 lines...] > /home/jenkins/git2/bin/git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > /home/jenkins/git2/bin/git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1885/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains c71ccf4631760d115a5a6179ccae8ad04ce6b1b3 # timeout=10Checking out Revision c71ccf4631760d115a5a6179ccae8ad04ce6b1b3 (origin/pr/1885/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f c71ccf4631760d115a5a6179ccae8ad04ce6b1b3 > /home/jenkins/git2/bin/git rev-list e719c8864ceae02632c33e8b4e9c3f0cae893fca # timeout=10Triggering ADAM-prb ? 2.6.2,2.10,2.2.1,centosTriggering ADAM-prb ? 2.6.2,2.11,2.2.1,centosTriggering ADAM-prb ? 2.7.3,2.10,2.2.1,centosTriggering ADAM-prb ? 2.7.3,2.11,2.2.1,centosADAM-prb ? 2.6.2,2.10,2.2.1,centos completed with result FAILUREADAM-prb ? 2.6.2,2.11,2.2.1,centos completed with result FAILUREADAM-prb ? 2.7.3,2.10,2.2.1,centos completed with result FAILUREADAM-prb ? 2.7.3,2.11,2.2.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Jenkins, retest this please.

Jenkins, retest this please.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2655/Build result: FAILURE[...truncated 7 lines...] > /home/jenkins/git2/bin/git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > /home/jenkins/git2/bin/git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1885/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains c71ccf4631760d115a5a6179ccae8ad04ce6b1b3 # timeout=10Checking out Revision c71ccf4631760d115a5a6179ccae8ad04ce6b1b3 (origin/pr/1885/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f c71ccf4631760d115a5a6179ccae8ad04ce6b1b3 > /home/jenkins/git2/bin/git rev-list c71ccf4631760d115a5a6179ccae8ad04ce6b1b3 # timeout=10Triggering ADAM-prb ? 2.6.2,2.10,2.2.1,centosTriggering ADAM-prb ? 2.6.2,2.11,2.2.1,centosTriggering ADAM-prb ? 2.7.3,2.10,2.2.1,centosTriggering ADAM-prb ? 2.7.3,2.11,2.2.1,centosADAM-prb ? 2.6.2,2.10,2.2.1,centos completed with result FAILUREADAM-prb ? 2.6.2,2.11,2.2.1,centos completed with result FAILUREADAM-prb ? 2.7.3,2.10,2.2.1,centos completed with result FAILUREADAM-prb ? 2.7.3,2.11,2.2.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

From looking at Jenkins, needs a ./scripts/format-sources.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2656/Build result: FAILURE[...truncated 7 lines...] > /home/jenkins/git2/bin/git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git --version # timeout=10 > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > /home/jenkins/git2/bin/git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > /home/jenkins/git2/bin/git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > /home/jenkins/git2/bin/git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > /home/jenkins/git2/bin/git rev-parse origin/pr/1885/merge^{commit} # timeout=10 > /home/jenkins/git2/bin/git branch -a -v --no-abbrev --contains 89131e6feb1742709144e9b14ab058ead3c98767 # timeout=10Checking out Revision 89131e6feb1742709144e9b14ab058ead3c98767 (origin/pr/1885/merge) > /home/jenkins/git2/bin/git config core.sparsecheckout # timeout=10 > /home/jenkins/git2/bin/git checkout -f 89131e6feb1742709144e9b14ab058ead3c98767 > /home/jenkins/git2/bin/git rev-list c71ccf4631760d115a5a6179ccae8ad04ce6b1b3 # timeout=10Triggering ADAM-prb ? 2.6.2,2.10,2.2.1,centosTriggering ADAM-prb ? 2.6.2,2.11,2.2.1,centosTriggering ADAM-prb ? 2.7.3,2.10,2.2.1,centosTriggering ADAM-prb ? 2.7.3,2.11,2.2.1,centosADAM-prb ? 2.6.2,2.10,2.2.1,centos completed with result FAILUREADAM-prb ? 2.6.2,2.11,2.2.1,centos completed with result FAILUREADAM-prb ? 2.7.3,2.10,2.2.1,centos completed with result FAILUREADAM-prb ? 2.7.3,2.11,2.2.1,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

Jenkins, retest this please.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2659/
Test PASSed.

I think this is all set @fnothaft let me know if there is anything else that is needed

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2667/
Test PASSed.

Thanks @akmorrow13! Merged manually as<PHONE_NUMBER>0b4f7de9f38c6df9cdd8ede9b25a47.


The argument type 'String?' can't be assigned to the parameter type 'String'.

I am facing this error and I don't know what the solution should be.  I am trying to build a YouTube player but getting this error and I am not sure if I understand it.
Can someone please help me with this?
I can also add the code if someone wants.

Dart supports sound null safety, meaning that types can be nullable or non-nullable but not both.
so if you're trying to assign a non-nullable value to a nullable value you'll get an edit-time error.
To handle this error you can use ?? syntax and assign a defualt value like so:
String? nullableString;
String nonNullableString = nullableString ?? 'default';

or
You can check if the value of the variable is not null and act accordingly, like so:
String? nullableString;

if (nullableString != null) {
   // At this point, we are certain that the value isn't null so we can assign it anywhere inside the scope of our if block.
}

The issue tracker is specifically for bug reports and feature request; see https://flutter.dev/community for a list of other resources where you can get help with your own code.
Closing as this is not a Flutter bug.

@or-adar So I canged the data type for videoId from var to string and re-wrote it as
var videoId
and redefined the statement where I was getting an error as
void initState() {     super.initState();     _controller = YoutubePlayerController(       initialVideoId: videoId =           YoutubePlayer.convertUrlToId(widget.youtubeLink) !,
I think this will work if anyone else faces same issues


Remove build folder from source code in GIT

In GitLab by @jberlin on Jul 29, 2022, 17:28
Unless there is a good reason to keep the compiled code together with the source code:
https://earth.bsc.es/gitlab/es/autosubmitreact/-/tree/master/build
I would suggest to completely remove this folder since takes space and is not useful to have it under git, unless of course as it was mentioned before there is a strong and good reason,
@mcastril @cgutierr

In GitLab by @ltenorio on Oct 10, 2023, 16:41
marked this issue as related to #87

In GitLab by @ltenorio on Oct 10, 2023, 16:44
mentioned in commit 22e42f7d561729917bd57e045e20f552d5d426e0

In GitLab by @jberlin on Jul 29, 2022, 17:39
mentioned in issue autosubmit_api#3


Captcha doesnt render because of failing IMagick

Following situation:
We have a webserver that is running a modified ImageMagick Version + the GD extension
The IMagick extension is not working normally due to personal optimizations its just working for a specified set of tasks.
Now Yii Captcha is checking if a the extension imagick is loaded then use it otherwise check for gd and use it.
because of the server configuration (wich a developer cant change allways) that behavior isnt really helpful. it would be better if we could choose between the used extension in Captcha and set it via config option at CaptchaAction level.
Stacktrace:
[error][ImagickException] exception 'ImagickException' with message 'Failed to query the font metrics' in vendor/yiisoft/yii2/captcha/CaptchaAction.php:318
Stack trace:
#0 yii2/captcha/CaptchaAction.php(318): Imagick->queryfontmetrics(Object(ImagickDraw), 'rlhzaa')
#1 yii2/captcha/CaptchaAction.php(245): yii\captcha\CaptchaAction->renderImageByImagick('rlhzaa')
#2 yii2/captcha/CaptchaAction.php(134): yii\captcha\CaptchaAction->renderImage('rlhzaa')
#3 [internal function]: yii\captcha\CaptchaAction->run()
#4 yii2/base/Action.php(92): call_user_func_array(Array, Array)
#5 yii2/base/Controller.php(151): yii\base\Action->runWithParams(Array)
#6 yii2/base/Module.php(455): yii\base\Controller->runAction('captcha', Array)
#7 yii2/web/Application.php(83): yii\base\Module->runAction('site/captcha', Array)
#8 yii2/base/Application.php(375): yii\web\Application->handleRequest(Object(yii\web\Request))
#9 frontend/web/index.php(18): yii\base\Application->run()

could be done by adding a property: $imageLibrary, which is null by default meaning auto detect and could be set to 'gd' or 'imagick'


haskellPackages.brittany is broken

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

nix-shell -I nixpkgs=channel:nixos-unstable -p haskellPackages.brittany

Additional context
building '/nix/store/7q09dgvlqwv122vjfclwnzlpa673d1q5-butcher-<IP_ADDRESS>.drv'...
setupCompilerEnvironmentPhase
Build with /nix/store/vhy7g5rrvsmivg7xf7s3n0n3hiq5hxv9-ghc-8.8.3.
unpacking sources
unpacking source archive /nix/store/xw6ji7727hfi1gfj1sghjj4pc0mcc9d6-butcher-<IP_ADDRESS>.tar.gz
source root is butcher-<IP_ADDRESS>
setting SOURCE_DATE_EPOCH to timestamp<PHONE_NUMBER> of file butcher-<IP_ADDRESS>/src/UI/Butcher/Monadic/Types.hs
patching sources
Replace Cabal file with edited version from mirror://hackage/butcher-<IP_ADDRESS>/revision/1.cabal.
compileBuildDriverPhase
setupCompileFlags: -package-db=/build/setup-package.conf.d -j4 -threaded
copying path '/nix/store/ac30x2sxy076i00mj7qh2jlbk7dl73za-bash-interactive-4.4-p23' from 'https://cache.nixos.org'...
[1 of 1] Compiling Main             ( Setup.hs, /build/Main.o )
Linking Setup ...
configuring
configureFlags: --verbose --prefix=/nix/store/dd5l6ncbv04bqgjvni7d04czhdh48sd7-butcher-<IP_ADDRESS> --libdir=$prefix/lib/$compiler --libsubdir=$abi/$libname --docdir=/nix/store/7vr7j45mcpczqvkhqkdabddv76kqzdfq-butcher-<IP_ADDRESS>-doc/share/doc/butcher-<IP_ADDRESS> --with-gcc=gcc --package-db=/build/package.conf.d --ghc-option=-j4 --disable-split-objs --enable-library-profiling --profiling-detail=exported-functions --disable-profiling --enable-shared --disable-coverage --enable-static --disable-executable-dynamic --enable-tests --disable-benchmarks --enable-library-vanilla --disable-library-for-ghci --ghc-option=-split-sections --extra-lib-dirs=/nix/store/41wfbvck73xbrlyjy9pk9b0lw6c1pp6g-ncurses-6.2/lib --extra-lib-dirs=/nix/store/c5sxlc593sqm3qr5rfl85phsl2mwbgpd-libffi-3.3/lib --extra-lib-dirs=/nix/store/rfh8jp8gphy21kzchc6v47x6mbg9sqfq-gmp-6.2.0/lib
copying path '/nix/store/35hb71frwcrzsza8zqij7bfxq8q4bkng-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/d4am5r7cgz5vv54m5jl3y96dzsb4jrh6-conduit-1.3.2' from 'https://cache.nixos.org'...
Using Parsec parser
Configuring butcher-<IP_ADDRESS>...
CallStack (from HasCallStack):
  die', called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:1022:20 in Cabal-<IP_ADDRESS>:Distribution.Simple.Configure
  configureFinalizedPackage, called at libraries/Cabal/Cabal/Distribution/Simple/Configure.hs:475:12 in Cabal-<IP_ADDRESS>:Distribution.Simple.Configure
  configure, called at libraries/Cabal/Cabal/Distribution/Simple.hs:625:20 in Cabal-<IP_ADDRESS>:Distribution.Simple
  confHook, called at libraries/Cabal/Cabal/Distribution/Simple/UserHooks.hs:65:5 in Cabal-<IP_ADDRESS>:Distribution.Simple.UserHooks
  configureAction, called at libraries/Cabal/Cabal/Distribution/Simple.hs:180:19 in Cabal-<IP_ADDRESS>:Distribution.Simple
  defaultMainHelper, called at libraries/Cabal/Cabal/Distribution/Simple.hs:116:27 in Cabal-<IP_ADDRESS>:Distribution.Simple  defaultMain, called at Setup.hs:2:8 in main:Main
Setup: Encountered missing or private dependencies:
base <0 && <999

builder for '/nix/store/7q09dgvlqwv122vjfclwnzlpa673d1q5-butcher-<IP_ADDRESS>.drv' failed with exit code 1
cannot build derivation '/nix/store/hd2g3gmx3raca928gi4dg11477yh54v1-brittany-<IP_ADDRESS>.drv': 1 dependencies couldn't be built

Metadata

system: "x86_64-linux"
host os: Linux 5.4.32, NixOS, 20.09pre221706.b61999e4ad6 (Nightingale)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.4
channels(philipp): ""
channels(root): ""
nixpkgs: /nix/store/cwcrm4pnrhgpflzbnzq4nqzg73n7hkld-source

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/nixos-manager-manage-your-nixos-configuration-graphically/6685/14

@pmiddend If you (or anyone else reading this) wanted to figure out what was wrong with brittany and send a PR fixing it, we would be happy to merge it in.

It needs butcher_1_3_3_1

@xaverdh Please feel free to send a PR with that override.

Well its fixed on master anyway, since butcher was updated there.

@xaverdh Thanks for letting me know.
I'll go ahead and close this since brittany is building on both haskell-updates and master currently.


Stale replicas left on some nodes

Stale replicas left on some nodes taking up space.
I found my storage on my nodes to be very uneven, but I looked at the replicas directory on each node and found a lot of PVCs that were not active, I have no clue why there are here, I only have 6 volumes so there is not a ton of volumes.
I don't know how to reproduce but I feel it has to do when a node reboots for maintenance, the replica needs to rebuild and something is being left behind.  I see some system snapshots but those don't seem to be deletable by UI and I have delete system snapshots after rebuild = true
I would expect the nodes to be cleaned up properly and not have uneven storage.  After my manual cleanup all nodes are even again which is what I would expect to always be the case.

Longhorn version: 1.24
Installation method (e.g. Rancher Catalog App/Helm/Kubectl): Helm
Kubernetes distro (e.g. RKE/K3s/EKS/OpenShift) and version: K3S

Number of management node in the cluster: 3
Number of worker node in the cluster: 3

Node config

OS type and version: Debian Raspian Bullseye
CPU per node: 4
Memory per node: 8
Disk type(e.g. SSD/NVMe): SSD
Network bandwidth between the nodes: 1 Gbit

Underlying Infrastructure (e.g. on AWS/GCE, EKS/GKE, VMWare/KVM, Baremetal): Baremetal
Number of Longhorn volumes in the cluster: 6

pi@glenn:/mnt/data $ cd replicas/
pi@glenn:/mnt/data/replicas $ ls
pvc-024ae84c-face-40ca-9c3f-c3574cee3c64-99332f16  pvc-623a2dbc-ca12-40f4-a9d4-ae0d327d485d-ce470719
pvc-024ae84c-face-40ca-9c3f-c3574cee3c64-eb3c13e8  pvc-623a2dbc-ca12-40f4-a9d4-ae0d327d485d-e803b548
pvc-1ab33903-d61f-4937-99a9-a334eadbba1b-523f2adc  pvc-9560dbae-14bf-44e0-a3fb-228a2290694a-9db53cdb
pvc-47730168-745c-460c-b9f1-41dc801727df-61ab24e9  pvc-9560dbae-14bf-44e0-a3fb-228a2290694a-df2f6b58
pvc-47730168-745c-460c-b9f1-41dc801727df-7724a33a  pvc-9560dbae-14bf-44e0-a3fb-228a2290694a-fd34d564
pvc-623a2dbc-ca12-40f4-a9d4-ae0d327d485d-c0bb2ada  pvc-ac552a77-152a-47a2-9f44-76f85f969ac0-7ad5e069

Thanks @braucktoon for reporting
It seems related to the enhancement orphan replica cleanup: https://github.com/longhorn/longhorn/issues/685


Add concept of salary grants and make bursaries more generic

This PR adds support for collecting information about salary grants - which apply to the School direct (salaried) and Early years (salaried) routes.
Salary grants are basically the same as bursaries - they have a value £ and they apply for certain subjects. Mostly what's different is the language.
To do this, I've made the existing bursary functionally more generic in name - it now calls it financialSupport and has a type.
Testing:

Add a trainee on a School direct (salaried) or Early years (salaried) route
Add course details where the allocation subject ends up with one of those that has salary grants (all of early years or chemistry, computing, maths, physics, languages, classics or biology)
When in funding section, the user is now asked about salary grants and is shown the correct value.

Salary grant page (school direct)

Summary card

Salary grant page (early years salaried)

Looks good — Although I think the question "Are you applying for a salary grant for this trainee?" feels a bit 'informational', like we're asking out of interest. Something like "Do you want to apply for a salary grant for this trainee?" would be clearer that this is the start of the user applying for a grant.
I also think we should add (as a separate story) guidance on what the user can expect from the salary application process on the confirmation page.
cc @gregknight1

Looks good — Although I think the question "Are you applying for a salary grant for this trainee?" feels a bit 'informational', like we're asking out of interest. Something like "Do you want to apply for a salary grant for this trainee?" would be clearer that this is the start of the user applying for a grant.
I also think we should add (as a separate story) guidance on what the user can expect from the salary application process on the confirmation page.
cc @gregknight1

I'll defer to @gregknight1 on thoughts about framing this. I think originally we had some worry that this might not be the method through which applications get made - so having this passive language covered both bases. That still might be the case.

Will have time to take a look at the content on this tomorrow after chatting to Ed about it this afternoon. @edwardhorsford @ralph-hawkins


Introduce dockest & jest

Introducing the libraries for trivial testing
The test file is more or less a placeholder to get things going

thanks!! <3


language model evaluation at idx = 0

hi, I'm still looking for computing perplexity with GLM.
Just look into the recent updates on evaluation/{dataset.py, tasks.py} about language model task.
The code inside dataset.py:LanguageModelTaskDataset:297  is
        if idx == 0 or self.config.unidirectional:
            prompt, text = tokens[:1], tokens[1:]
        else:
            prompt_length = self.config.max_seq_length - 1 - self.config.generation_length
            prompt, text = tokens[:prompt_length], tokens[prompt_length:]

        # ..... skip ....
        return {
            "tokens": np.array(prompt + [mask_id, sop_id] + text[:-1], dtype=np.int64),
            "targets": np.array(prompt + [mask_id] + text, dtype=np.int64),
            "position_ids": np.arange(0, seq_length, dtype=np.int64),
            "attention_mask": attention_mask < 0.5,
            "loss_masks": np.array([0] * (len(prompt) + 1) + [1] * len(text), dtype=np.int64),
        }

at idx==0, you take the full text as prompt input and also the output text.
It would lead to absolutely lower PPL. Because model has a full view of what it needs to predict.
Why wouldn't set the prompt to empty list?

Hello @lomizandtyd, I think prompt = tokens[:1] only takes the first character of the text not the full text.

yeah, my fault

I still got the question: Why wouldn't set the prompt to empty list?

I still got the question: Why wouldn't set the prompt to empty list?

This is a mistake of mine, the prompt should be an empty list, I will fix it.

Got.


chore: clone last commit

Description
This PR clones the last commit as it is already the case for Appveyor.

Not highly relevant. I think we can close this PR.


User story 3 list messages

Add "Delete Room" button to delete all rooms (in case it's getting too crowded), add active room window and room-related messages.

Looks great! 👍 👂 🐰 🍰


Please check Search.php for syntax error

Hello MarkLogic, recently while using PHP Rest API code, I got an error involving the word 'collection' not being a defined constant.
https://github.com/marklogic/mlphp/blob/master/api/MarkLogic/MLPHP/Search.php
Line 340: public function setCollection($collection)
Line 342: $this->collection = collection;
should this really be: $this->collection = $collection;  ? (Dollar sign in front of word collection).
I changed it in my copy of the code and then the code functioned as expected.

Yes, you are correct. This was corrected in the dev branch where the current active development is taking place.


Updated Lithuanian locale.

Updated Lithuanian locale, added missing entries.
Proof of testing: https://imgur.com/a/Ax6CP3l

Thanks :)


Feature: dependency checks based on diagrams for nx and lerna monorepos

Content of the Pull Request
This pull requests features dependency checks between packages of nx/lerna monorepos using PlantUML diagrams.
Implementation
The feature extends the graph api by supplying an alternative source for dependency graphs.
Tests
The feature is integration tested.

@c-harding would you volunteer for a review? I think you the only maintainer of the project.

Thank you for the review and for spotting the mistakes. I am missing the permissions to merge. Can you please merge this PR (and maybe the other approved PR as well). Thank you!

Merged, version 5.4.0


fix/tcp: heartbeat not being sent on some cases

There was a scenario where hearbeat implementation would fail:

if peer A is sending data to peer B and never receives a heartbeat
it'll eventually conclude that peer B has disconnected (even if it was
still getting acks at the tcp level).

To fix the problem, we should only take last_write_activity into
consideration to compute the heartbeat timeout.

This change is

r? @canndrew
(maidsafe_highfive has picked a reviewer for you, use r? to override)

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Update versions of external projects to match those used by drake

Thanks for opening the PR to share your modifications.  Unfortunately I can't accept everything in this PR as it prevents me from maintaining director packages.  Some parts of this PR are fine, like upgrading the versions of eigen and lcm etc, but I can't currently take the parts that modify URLs from which vtk precompiled is fetched or homebrew.

but I can't currently take the parts that modify URLs from which vtk precompiled is fetched or homebrew.

Why? You can make pull requests like anyone else on the homebrew repo.

FYI @stonier. Seems Drake will have to continue to run its own CI on Director after all.


Added capability of migrating wallet through the node.js wrapper (#895)

We have previously reverted https://github.com/hyperledger/aries-vcx/pull/906 feature to expose wallet migration in nodejs wrapper. This brings the code back - reverts the revert.

Added capability of migrating wallet through the node.js wrapper

Codecov Report

Merging #919 (527272d) into purge/vdrtools-zmq (a1b1e9a) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@                  Coverage Diff                   @@
##           purge/vdrtools-zmq     #919      +/-   ##
======================================================
- Coverage               44.22%   44.16%   -0.07%
======================================================
  Files                     416      416
  Lines                   29178    29177       -1
  Branches                 6218     6218
======================================================
- Hits                    12905    12887      -18
- Misses                  12495    12515      +20
+ Partials                 3778     3775       -3

Flag
Coverage Δ

unittests-aries-vcx
44.16% <0.00%> (-0.07%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed
Coverage Δ

libvdrtools/indy-api-types/src/lib.rs
50.00% <0.00%> (-30.00%)
:arrow_down:

... and 5 files with indirect coverage changes


fix: wip testing native image support in Java Spanner JDBC

PR to test Native Image support in Java Spanner JDBC against the CI.

Notes: It looks like we're not running the parallel tests in the presubmit for standard Java. Removing the exclusion (for testing purposes) to see how they behave.

Closing this PR as it was meant for debugging.


[Identity] We had an extra type issue that slipped through our last PR

This is my bad, I assumed it wouldn’t have issues, or otherwise it would complain on the PR, but since it’s a manual test, it required me to build it manually, which I didn’t. Please review 🙏

I want to continue improving these manual tests through this issue: https://github.com/Azure/azure-sdk-for-js/issues/17489


Unhandled error during execution of scheduler flush

Version
3.0.5
Reproduction link
https://jsfiddle.net/hm3f19rx/3/
Steps to reproduce

Set an empty array as a data() return
Add a web request in the mounted() hook (I used Axios)
Set the empty array to the result of the web request
Use v-for to loop over that array and render it

What is expected?
The array is rendered as normal.
What is actually happening?
Nothing gets rendered - my entire application breaks.  Vue warn says:
Unhandled error during execution of scheduler flush. This is likely a Vue internals bug.

I first ran into this issue on my @ionic/vue project and assumed it was an issue with Ionic itself.  However, even without Ionic components this issue is still prominent.  Any fixes for this are very much appreciated, since this has fully halted the development of  my Vue application.

the data you ask for doesn't have an author field (at least not all of them do), so project.author.username throws an error:

the data you ask for doesn't have an author field (at least not all of them do), so project.author.username throws an error:


Provide example project with .arb files

It would be great to have an example project showing the .arb workflow so it can be emulated easily.
There was at one point https://github.com/dart-lang/sample-polymer-intl/ but it seems to have disappeared.

Any updates here @alan-knight? I'm about done with generating ARB from our strings so wanted to see better examples of things.

OK, the sample is back. It's pretty trivial, and there's been a lot of
instability around reflectable/initialize/analyzer, but there's a version
that works (at least today, on my machine :-) at
https://github.com/alan-knight/polymer_intl
On Tue, Jan 5, 2016 at 5:58 PM Don<EMAIL_ADDRESS>wrote:

Any updates here @alan-knight https://github.com/alan-knight? I'm about
done with generating ARB from our strings so wanted to see better examples
of things.
—
Reply to this email directly or view it on GitHub
https://github.com/dart-lang/intl/issues/84#issuecomment-169194001.

Not exactly easy to emulate, but it's also possible to look at test/message_extraction, which tests the flow. If your run debug.sh from there it will do the file generation steps and leave the results visible instead of cleaning them up after the tests run. There's a magic step in there for getting them translated, implemented by make_hardcoded_translation.dart, but otherwise it's pretty close to real.

Awesome! Thank you sir!
Any chance you can add some stuff where the string has a variable in it? From whats there it looks like the corresponding @ value in the JSON is only required for those.

Added. Also noted that ARB is out of date, but the data files there are, um, closer. They're the map structure from ARB, without the register call.


Exception in thread "main" firrtl.FirrtlInternalException: No width: UnknownType

bug report
What is the current behavior?
$ cat input1.firrtl
circuit main :
  module main :
    node a = dshl(UInt<64>(0), rem(UInt<1>(1), SInt<32>(0)))

$ java -cp firrtl.jar firrtl.stage.FirrtlMain -o /dev/null -i input1.firrtl 2>&1 | head -1
Exception in thread "main" firrtl.FirrtlInternalException: No width: UnknownType

Please tell us about your environment:
Using firrtl-1.5.2.
$ uname -srio
Linux 4.4.0-31-generic x86_64 GNU/Linux

To clarify: the bug is that the SFC should reject this circuit because rem(UInt, SInt) is illegal. This has to be either rem(UInt, UInt) or rem(SInt, SInt). CInferTypes is crashing when it sees this.
Example MFC output (which looks to be doing the right thing):
Foo.fir:3:32: error: operand signedness must match
    node a = dshl(UInt<64>(0), rem(UInt<1>(1), SInt<32>(0)))
                               ^

Yes, the error is the fact that this is an internal error, which no input should be able to cause.

Suggestion:

wrap a try {...} catch (Exception e) around the call into code that processes (such as type checks) a particular expression and
in the catch clause just print out the file and line number of the expression (and maybe a dump of the expression syntax) and then re-throw the exception.

Now, if there is an internal error / stack trace, then at least the user has some idea where in the input file the syntax occurs that was being processed when the internal error occurred.  This would help a lot.


Could you add a PKGBUILD for building linux with llvm?

@fokx If you are compiling the kernel just for yourself, then building via PKGBUILD only complicates the build. Therefore, I use a manual kernel build. https://www.archlinux.club/
kbuild helps me to automate the kernel build, I will update the script soon. It will also support out of tree builds and automatic building and merging of branches from git for kernel development. Also, I don't use heavy kernels, and I build a minimal kernel configuration and it only takes a couple of minutes to build the kernel.


Suite Setup in Redfish.Systems.Eventlog.Test Event Service does not apply to all test cases

The suite setup in redfish/systems/eventlog/test_event_service.robot requires that the variables ${REMOTE_SERVER_IP} and ${HTTPS_PORT} not be empty. But ${REMOTE_SERVER_IP} has no default value. Consequently, until it is defined, both test cases in the suite fail. However, one of the two cases, Verify Event Service Available, does not require these two variables.
The suite setup requirement should be converted into a test requirement for the other test - the only test that requires the two variables.

Suite Setup Execution
    [Documentation]  Do the suite setup.

    Should Not be Empty  ${REMOTE_SERVER_IP}
    Should Not be Empty  ${HTTPS_PORT}

HTTPS_PORT  by default we know 443 , however the remote server IP where the event is configured to sent is dependent on user setup and not something, we should default.
That's why the above is check is done at the suite set up.
Having said that, at least we can add the Documentation to tell user how to set it up.

I talked to @adathatri about the aim of this test, so looks like it doesn't need any valid IP to do validation. The scope of this suite is to be able to add another web server IP and it should get added to the subscription.
@adathatri can u just assign a random IP and clear up the subscription once done ?

Commit up https://gerrit.openbmc-project.xyz/c/openbmc/openbmc-test-automation/+/51304
This should do for now, till we add newer test cases to do real event notification testing using the remote web server capable to listen to the traffic events coming to it


Adding Sardine to the list of libraries

Addition of Sardine, a live coding library for Python 3.10+. Maintained, with active recent development.

Thanks!


Update isDAC logic to use SN_C to create alignment between BE and FE

@KameronKerger
This is the new truth table, is this accurate?

@KameronKerger - Thanks! this simplifies things!
Also a quick note that when TA_PERC = 0, that actually means that the value is "less than 1%", so I'll assume those should stay as Partially right?
Sorry for it being so cryptic, however I'm doing that to make sure I code it correctly. :)

if SN_C = TRUE, then DAC is YES (nothing else matters for the YES / NO / PARTIALLY)

it can only be PARTIALLY if SN_C is FALSE.

Updated truth table:


Python:  cannot import name 'Hnsw' from 'azure.search.documents.indexes.models

Describe the bug
Hnsw cannot seem to be imported from this package azure.search.documents.indexes.models.  It's giving me exception:

I tried reinstalling azure-search but still out of luck.  I went to Azure SDK for python and can't seem to find this class (Hnws)
To Reproduce
Steps to reproduce the behavior:

Go to the box prior to populate the memory.
Click on execute button
See error

Expected behavior
It will execute without an exception.
Screenshots
If applicable, add screenshots to help explain your problem.
Platform

OS: Windows
IDE: VS Code
Language: Python

Additional context
Add any other context about the problem here.

Can you tell us which version of Semantic Kernel and Azure AI Search that you are using?

Closing due to inactivity.


Custom Validator: req, withParams use in project file

We just had a situation where one of our designers needed to add a custom validator. The src/common.js does not export what is shown in the "Custom Validators" Section in the documentation:
import {withParams, req} from './common'
export default withParams({type: 'required'}, req)

The withParams and req object get imported from the module with a local path. How would one import it inside a project when adding validators to the project folder? Thanks!

Sure, that's a fail on documentation part. I never intended to make those common building blocks public, as those are not validators really. I refactored them out once and forgot that docs are autogenerated from the source. As you can see in the code you pasted in, required is an public equivalent of req. Also withParams is exported from vuelidate/lib/validators.
First of all, if you are not using $params in your application, you can skip this altogether and simply write a JS function.
export const isHello = value => value === 'hello'

If you want to use meaningful $params with that, you have to wrap it in withParams.
import {withParams} from 'vuelidate/lib/validators'
export const isHello = withParams({type: 'isHello'}, value => value === 'hello')

Shall we leave this open as commit and PR target until the doku is fixed?

I've looked at the example in #31 but that doesn't seem to work for me. I was able to follow the "with_params" example in #137 and get it to work, but don't really understand the need for withParams and can't find any instruction on it in the docs.
For this one I just have a simple case where I want to check is a string is a valid date.  (This works)
import isValid from 'date-fns/is_valid'

export default withParams({ type: 'isValidDate' }, dateValue => {
  if (dateValue) {
    return dateValue.length === 10 ? isValid(new Date(dateValue)) : dateValue.length === 0
  }
  return true
})

But for my next validation, I need to check that the date given is after a date in another field.
How can I pass both values to the function to be compared?
A specific solution would be great, but even better would be a more generalized writeup on how to make custom validators that have access to values in the data model.
I'm not trying to take over this thread, but it seems like the right place to post about the docs being unclear on custom validators.

Just wanted to leave a note that I'm wandering in issues tab to get more understanding of how custom validators should be written. Good to see I'm not the only one confused about them.

@pjar I do see that trend, but I also notice that people simply expect certain things to be more complicated than really required. Just write a plain old function. Anything that takes a value and returns a boolean (or Promise) will do just fine. The only necessary complication arises when you plan to use $params feature. In that case withParams wrapper will help you. I bet thought that this feature is rarely used.

It looks like you can now use import { withParams } from 'vuelidate' instead of 'vulidate/lib/validators'

I can't import { withParams } from nowhere. Places I tried:

"vuelidate"
"vuelidate/lib/validators"
"vuelidate/lib/params"
"vuelidate/lib/withParams"
"vuelidate/lib/withParamsBrowser"
"vuelidate/lib/validators/common"

I got a reference error for process is undefined.
Here is the call stack:
index.js?ca99:3 Uncaught ReferenceError: process is not defined
    at eval (index.js?ca99:3)
    at Object../node_modules/process-nextick-args/index.js (app.js:3153)
    at __webpack_require__ (app.js:679)
    at fn (app.js:89)
    at Object.eval (_stream_readable.js?46dd:26)
    at eval (_stream_readable.js:1016)
    at Object../node_modules/readable-stream/lib/_stream_readable.js (app.js:3215)
    at __webpack_require__ (app.js:679)
    at fn (app.js:89)
    at eval (readable-browser.js?7125:1)

I don't have much time lately to improve the docs on my own, but If anyone would make a PR I'll find a moment to review it and release.

thank you @vinstah for clarifying us :)

@ AlexandreBonneau I'm not sure if this is on purpose, but you pointed out two solutions that actually are implemented :D  Validators are both bound to component instance and it's also passed as a second argument for convenience. Remember that arrow functions doesn't carry context, you have to use full functions (or second param). You've got a point on docs though :) I'll soon have some time budget to work on vuelidate again, so I'll might address that. PRs are always welcome too!


Setting vehicle part config causes downstream ConnectionRefusedError: [WinError 10061]

Hi,
Not sure if this is a bug or user error, but whenever I set a part config on a vehicle then call another command on the vehicle (such as changing the AI settings) I get the following error:
Traceback (most recent call last):
  File "C:\envs\beamng\Lib\site-packages\beamngpy\connection\prefixed_length_socket.py", line 36, in _recv_exactly
    received = self.skt.recv(min(BUF_SIZE, length))
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ConnectionAbortedError: [WinError 10053] An established connection was aborted by the software in your host machine

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\project_path\scripts\example.py", line 21, in <module>
    vehicle.ai_set_mode("manual")
  File "C:\envs\beamng\Lib\site-packages\beamngpy\api\vehicle\ai.py", line 41, in set_mode
    self._send(data).ack('AiModeSet')
  File "C:\envs\beamng\Lib\site-packages\beamngpy\connection\connection.py", line 275, in ack
    message = self.recv()
              ^^^^^^^^^^^
  File "C:\envs\beamng\Lib\site-packages\beamngpy\connection\connection.py", line 267, in recv
    message = self.connection.recv(self.req_id)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\envs\beamng\Lib\site-packages\beamngpy\connection\connection.py", line 209, in recv
    message = self.skt.recv()
              ^^^^^^^^^^^^^^^
  File "C:\envs\beamng\Lib\site-packages\beamngpy\connection\prefixed_length_socket.py", line 64, in recv
    packed_length = self._recv_exactly(self.HEADER_BYTES)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File C:\envs\beamng\Lib\site-packages\beamngpy\connection\prefixed_length_socket.py", line 38, in _recv_exactly
    self.reconnect()
  File "C:\envs\beamng\Lib\site-packages\beamngpy\connection\prefixed_length_socket.py", line 83, in reconnect
    self.skt.connect((self.host, self.port))
ConnectionRefusedError: [WinError 10061] No connection could be made because the target machine actively refused it

This example reproduces the behavior:
from beamngpy import BeamNGpy, Scenario, Vehicle

beamng = BeamNGpy(
        host='localhost', port=64256,
        home='C:\Program Files (x86)\Steam\steamapps\common\BeamNG.drive')
beamng.open(launch=True)
scenario = Scenario('west_coast_usa', 'ai_sine')
vehicle = Vehicle('ego_vehicle', model='etk800', license='AI')
scenario.add_vehicle(vehicle, pos=(-769.1, 400.8, 142.8), rot_quat=(0, 0, 1, 0))
scenario.make(beamng)
beamng.scenario.load(scenario)
beamng.scenario.start()

# Setting a part config respawns vehicle as expected
vehicle.set_part_config(vehicle.get_part_config())

# vehicle.disconnect()
# vehicle.connect(bng=beamng)

# Error occurs here unless disconnect/connect lines are uncommented above
vehicle.ai_set_mode("manual")

If the lines
# vehicle.disconnect()
# vehicle.connect(bng=beamng)

are uncommented above, the error does not occur. Reconnecting to the vehicle after setting the part config wasn't required in older versions of beamngpy.
Tested with:
Windows 11
Python 3.9 and 3.11 (managed by conda)
BeamNG 0.32
beamnypy==1.29

Hello @garethjns,
Thank you for reporting the issue with the set_part_config function in BeamNGpy. We appreciate your detailed explanation and the example you provided. We will investigate this issue and work on a fix as soon as possible.

Hi, this is fixed in BeamNGpy v1.30, which has just been released. Thank you for the report.


Feat: Support Remote Span

Create a new filter to extract remote span and active.
Hook the QueueListener that add a RemoteSpanAction when a job is waiting. This may either be the remote span or the span created by the OpenTelemetryServletFilter.
Restore the remote span in the RunListener from RemoteSpanAction
Add an integration test about remote trigger tracing

Fix #617  #679

Testing done

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue

Hi, @kuisathaverat
It would be grateful if you could take a moment to review my change
Your feedback is essential, and I'm committed to making any adjustments you suggest to ensure this change aligns with the project's goals. Thank you for considering my contribution.

If you add a parameter to the job to export the environment variable OTEL_EXPORTER_OTLP_HEADERS='traceparent: 00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01' that does not require changes in the plugin

If you add a parameter to the job to export the environment variable OTEL_EXPORTER_OTLP_HEADERS='traceparent: 00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01' it'd do the same, that does not require changes in the plugin

@kuisathaverat
I would appreciate your guidance on how to extract the remote span sent from another Jenkins instance through the HTTP header. Could you kindly provide advice on where I can find information regarding the OTEL_EXPORTER_OTLP_HEADERS configuration?

Could you kindly provide advice on where I can find information regarding the OTEL_EXPORTER_OTLP_HEADERS configuration?

The pipeline has the environment variable OTEL_EXPORTER_OTLP_HEADERS exported if you configure it, see https://github.com/jenkinsci/opentelemetry-plugin#getting-started

Could you kindly provide advice on where I can find information regarding the OTEL_EXPORTER_OTLP_HEADERS configuration?

The pipeline has the environment variable TRACEPARENT exported if you configure it, see https://github.com/jenkinsci/opentelemetry-plugin#getting-started and https://github.com/jenkinsci/opentelemetry-plugin/blob/master/docs/job-traces.md#environment-variables-for-trace-context-propagation-and-integrations

@kuisathaverat
I'd like to implement this new feature to support remote span sent from another Jenkins server like below
Jenkins A -> Jenkins B

In the above case, we want the job on Jenkin B to have the same trace id if it's triggered by the Jenkins remote build API.
I believe my change is required to extract it from the HTTP header. Otherwise, the plugin creates a completely new trace.

Is it ready for review? Code looks great.

Is it ready for review? Code looks great.

I'm ok. Please tell me if anything I can improve.

In the above case, we want the job on Jenkin B to have the same trace id if it's triggered by the Jenkins remote build API.
I think it requires some change in this plugin to extract traceparent from the HTTP header. Otherwise, a completely new trace is created for a new job (at Jenkins B in the above case).

I do not like the idea of adding an HTTP filter to process an HTTP header provider by the user to use it in code as a parent span, because it is possible to do exactly the same configuring a parameter in the Jenkinns B pipeline and no changes on code are needed. In both cases, Jenkins A has to pass the header, in the case you propose as HTTP header, in the current implementation as a parameter in the job REST call. I am not sure that worth the risk of processing an HTTP header from an unknown source with unknown content.

In the above case, we want the job on Jenkin B to have the same trace id if it's triggered by the Jenkins remote build API.
I think it requires some change in this plugin to extract traceparent from the HTTP header. Otherwise, a completely new trace is created for a new job (at Jenkins B in the above case).

I do not like the idea of adding an HTTP filter to process an HTTP header provider by the user to use it in code as a parent span, because it is possible to do exactly the same configuring a parameter in the Jenkinns B pipeline and no changes on code are needed. In both cases, Jenkins A has to pass the header, in the case you propose as HTTP header, in the current implementation as a parameter in the job REST call. I am not sure that worth the risk of processing an HTTP header from an unknown source with unknown content.

@kuisathaverat
Regarding your security concerns, I plan to refine the approach by specifically extracting the remote span only matching the Jenkins remote build endpoints only, which is a POST method request with paths like /job/<jobname>/build or /job/<jobname>/buildwithparameter. This approach aligns with Jenkins' built-in security controls, as Jenkins jobs typically require a token for triggering in a production environment.
This feature aims to facilitate the tracking of "distributed" builds across multiple Jenkins instances, especially when some of the jobs are configured as freestyle projects. For those jobs, it requires some fundamental changes to your existing code.

Thanks  @topikachu
@kuisathaverat I wouldn't worry about this as all instrumented applications look for trace context header, whatever they are instrumented with OTel or with another technology.

I would prefer to have a flag/setting to enable/disable this feature and not enable it by default.

@kuisathaverat and @cyrille-leclerc
I added a new option "otel.instrumentation.jenkins.remote.span.enabled". It is false/disabled by default.

One last thing, Could you add some documentation about the flag? something like this https://github.com/jenkinsci/opentelemetry-plugin/blob/master/docs/setup-and-configuration.md#tcp-keepalive

One last thing, Could you add some documentation about the flag? something like this https://github.com/jenkinsci/opentelemetry-plugin/blob/master/docs/setup-and-configuration.md#tcp-keepalive

I added one line in the "Advanced configuration settings". Please check.


fs/vfs/fs_stat.c: fill file size for mtd inode

Summary
Now when stat() is calling for mtd device it also set size of file as number of bytes of all sectors related to this mtd device.

Sorry I don't have nxstyler.

Sorry I don't have nxstyler.

It's in the repo, you can use it like that ./tools/checkpath.sh -f file_name
or pipe it with git: git diff --name-only | xargs ./tools/checkpath.sh -f

Sorry @xiaoxiang781216, I've done patch online in github. In fact I'm currently working in another branch of PX4 NuttX. Could you please make suggestion changes and squash? Or I can do, it but latter.

Just a clarification.  Let me know if I am mistaken.  These changes only work with stat():
int stat(FAR const char *path, FAR struct stat *buf);

In that case the path will map to a block or MTD driver inode.  But his would NOT work with fstat(), would it?
int fstat(int fd, FAR struct stat *buf);

In this case, the fd will be a reference to an (unlinked) character driver proxy (drivers/bch).  file_fstat() would call inode_state() with the inode of the character driver.  There is nothing in the inode->i_flags that would indicate that this is such a proxy so it would assume a regular character driver and return zero size.
Is this problem?

Yes, these patches are only for block and MTD inode. And bch will return zero size, yes.
So the options there is detect file type in user space and use BIOC_GEOMETRY ioctl (I did this in my case), or do check here in fs_stat.c, but it will leads to dependence/includes of bch driver, I suppose it's not a good way?
It is not a big problem, just missed functional. I don't know it there any demand in such thing. For me my workaround is enough.
--
@xiaoxiang781216 I start working on corrections for this mtd patch, will push it soon.

Yes, these patches are only for block and MTD inode. A bch will still return zero size as before.
So the options there is detect file type in user space and use BIOC_GEOMETRY ioctl (I did this in my case), or do check here in fs_stat.c, but it will leads to dependence/includes of bch driver, I suppose it's not a good way?

I would say that you can just call the BIOC_GEOMTRY ioctl command unconditionally.  No harm if it is not supported; you should get the -ENOTTY error inresponse (ENOTTY is always used in ioctl() implementations if the command is not supported).
Is there a similar IOCTL command for MTD?

Yes, you are right, I mean that I also check just S_IFCHR mode.

Is there a similar IOCTL command for MTD?

MTDIOC_GEOMETRY as @xiaoxiang781216  supposed

BIOC_GEOMETRY and MTDIOC_GEOMETRY fill different structures.

We could at least the logic in a separate function that hides the complexities and just returns the underlying media size if there is one.
@xiaoxiang781216 If BIO_IOCTL returns success, should we continue to treat the driver as a character driver?  I would think we would want to continue to hide the character driver proxy identity and report this as a block driver, not a character driver.  A character driver with a size is kind weird.
Similarly for MTD drivers, the character driver should be hidden.  We should continue with the illusion that we just opened the block or MTD driver and not expose the character driver proxy.

@xiaoxiang781216 I won't merge this.  I will wait for your final assessment.

I've replace the patch according to @xiaoxiang781216 instructions. I didn't test this in action, just successfully build it.
Of course the approach with separate universal ioctl function returning underlying media size, as @patacongo suggested, will be much better.

Of course the approach with separate universal ioctl function returning underlying media size, as @patacongo suggested, will be much better.

According to the the things Xiang said, he is started some work on a mystery change.  But my impression is that we should hide the character driver all together.  If there were logic like this in inode_stat(), then I think we complete the illusion).
type = inode type
size = 0;

if <type == character driver> then
    if <BIOC_GEOMETRY succeeds> then
        type = block driver
        calculate size
    else if <MTDIOC_GEOMETRY succeeeds them
        type = MTD driver
        calculate size
    endif
    Create the state buffer based on the type
endif

That is a gross over-simplification, but I think we could use the ioctls to distinguish if a character driver if a proxy for a block or mtd driver, then hide the character driver altogether.

Of course the approach with separate universal ioctl function returning underlying media size, as @patacongo suggested, will be much better.

According to the the things Xiang said, he is started some work on a mystery change. But my impression is that we should hide the character driver all together. If there were logic like this in inode_stat(), then I think we complete the illusion).

Yes, I think it is a good idea to hide the proxy(bch and ftl) from user since we add the proxy transparently.

type = inode type
size = 0;

if <type == character driver> then
    if <BIOC_GEOMETRY succeeds> then
        type = block driver
        calculate size
    else if <MTDIOC_GEOMETRY succeeeds them
        type = MTD driver
        calculate size
    endif
    Create the state buffer based on the type
endif

That is a gross over-simplification, but I think we could use the ioctls to distinguish if a character driver if a proxy for a block or mtd driver, then hide the character driver altogether.

The order need change like this:
if <type == character driver> then
    if <MTDIOC_GEOMETRY succeeeds them
        type = MTD driver
        calculate size
    else if <BIOC_GEOMETRY succeeds> then
        type = block driver
        calculate size
    endif
    Create the state buffer based on the type
endif

since MTD proxy(FLT) implment BIOC_GEOMETRY too.


How do I load an image?

How do I load an image?

If you want to load real image , you first need to project the image into latent space, refer to https://github.com/rosinality/stylegan2-pytorch/blob/master/projector.py, then you could load the latent and reconstruct the real image. I will add this feature later, but it is not currently under consideration


[v2.24.0] 'forseti_db' should get from the yaml file and not from the flags

This is because when I run ps -ef | grep forseti in the server, it is displaying the plain text of forseti_db's credential.
Forseti Version:

git checkout tags/v2.24.0

Example:
Started Forseti service in background:
nohup forseti_server \
   --endpoint "localhost:50051" \
   --forseti_db "mysql+pymysql://root:forseti_user:<PASSWORD>@x.x.x.x.x:3306/forseti_security" \
   --services scanner model inventory explain notifier \
   --config_file_path "/xx/xx/forseti-security/configs/server/forseti_conf_server.yaml" \
   --log_level=debug \
   --enable_console_log &

ps -ef | grep forseti

Output:

/usr/bin/python3 /usr/local/bin/forseti_server --endpoint localhost:50051 --forseti_db mysql+pymysql://forseti_user:@x.x.x.x:3306/forseti_security --service

Tried to echo'd the $CONFIG_FLAGS the file and exported it but no avail.

export CONFIG_FLAGS="--endpoint localhost:50051 --forseti_db mysql+pymysql://forseti_user:@x.x.x.x:3306/forseti_security --services scanner model inventory explain notifier --config_file_path /xx/xx/forseti-security/configs/server/forseti_conf_server.yaml --log_level=debug --enable_console_log"

Appreciate if someone could advise on this.
Thank you.

Hi @unrealmind, sorry for the delay. I'm sorry, can you help provide some more info on what the issue is? Is the problem that anybody with access to the VM can see the password in plaintext from the command line?


Teleop gives error on run

ISSUE TEMPLATE ver. 0.4.0

Which TurtleBot3 platform do you use?

[x ] Burger
[ ] Waffle
[ ] Waffle Pi

Which ROS is working with TurtleBot3?

[ ] ROS 1 Kinetic Kame
[ ] ROS 1 Melodic Morenia
[ x] ROS 1 Noetic Ninjemys
[ ] ROS 2 Dashing Diademata
[ ] ROS 2 Eloquent Elusor
[ ] ROS 2 Foxy Fitzroy
[ ] etc (Please specify your ROS Version here)

Which SBC(Single Board Computer) is working on TurtleBot3?

[ ] Intel Joule 570x
[ ] Raspberry Pi 3B+
[ ] Raspberry Pi 4
[x ] etc (simulation)

Which OS you installed on SBC?

[ ] Raspbian distributed by ROBOTIS
[ x] Ubuntu MATE (16.04/18.04/20.04)
[ ] Ubuntu preinstalled server (18.04/20.04)
[ ] etc (Please specify your OS here)

Which OS you installed on Remote PC?

[ ] Ubuntu 16.04 LTS (Xenial Xerus)
[ ] Ubuntu 18.04 LTS (Bionic Beaver)
[x ] Ubuntu 20.04 LTS (Focal Fossa)
[ ] Windows 10
[ ] MAC OS X (Specify version)
[ ] etc (Please specify your OS here)

Specify the software and firmware version(Can be found from Bringup messages)

Software version: [x.x.x]
Firmware version: [x.x.x]

Specify the commands or instructions to reproduce the issue.
roslaunch turtlebot3_teleop turtlebot3_teleop_key.launch

Copy and Paste the error messages on terminal.
Traceback (most recent call last):
File "/home/ammar/catkin_ws/devel/lib/turtlebot3_teleop/turtlebot3_teleop_key", line 7, in
with open(python_script, 'r') as fh:
FileNotFoundError: [Errno 2] No such file or directory: '/home/ammar/catkin_ws/src/turtlebot3/turtlebot3_teleop/nodes/turtlebot3_teleop_key'
[turtlebot3_teleop_keyboard-1] process has died [pid 46422, exit code 1, cmd /home/ammar/catkin_ws/devel/lib/turtlebot3_teleop/turtlebot3_teleop_key __name:=turtlebot3_teleop_keyboard __log:=/home/ammar/.ros/log/8d3bebdc-8ff0-11ec-983b-15a7f8611f80/turtlebot3_teleop_keyboard-1.log].

Hello. Thank you for your question.
It seems the Turtlebot3 package is not installed properly.
Please refer to the link below and reinstall the Turtlebot3 package.
[Noetic version] PC Setup
Thank you.

This issue will be closed due to prolonged inactivity. Please try again with the Humble or Noetic versions, and if the issue persists, feel free to reopen it.


Deploy Checklist: New Expensify 2022-10-28

Release Version: 1.2.21-4
Compare Changes: https://github.com/Expensify/App/compare/production...staging
This release contains changes from the following pull requests:

[x] https://github.com/Expensify/App/pull/10959
[x] https://github.com/Expensify/App/pull/11653
[x] https://github.com/Expensify/App/pull/11784
[x] https://github.com/Expensify/App/pull/12030
[x] https://github.com/Expensify/App/pull/12078
[x] https://github.com/Expensify/App/pull/12080
[x] https://github.com/Expensify/App/pull/12124
[x] https://github.com/Expensify/App/pull/12136
[x] https://github.com/Expensify/App/pull/12149
[x] https://github.com/Expensify/App/pull/12176
[x] https://github.com/Expensify/App/pull/12192
[x] https://github.com/Expensify/App/pull/12193
[x] https://github.com/Expensify/App/pull/12196
[x] https://github.com/Expensify/App/pull/12202
[x] https://github.com/Expensify/App/pull/12211
[x] https://github.com/Expensify/App/pull/12216

Deploy Blockers:

[x] https://github.com/Expensify/App/issues/12275
[x] https://github.com/Expensify/App/issues/12281

Deployer verifications:

[ ] I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
[ ] I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

:rocket: All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.21-4 :rocket:

Checking https://github.com/Expensify/App/pull/12193 off since it is also noQA

Interim summary
PR https://github.com/Expensify/App/pull/11784 failing with https://github.com/Expensify/App/issues/12265. repro in PROD checking off
PR https://github.com/Expensify/App/pull/12124 is failing due to https://github.com/Expensify/App/issues/12249
PR https://github.com/Expensify/App/pull/12136 looks PROD QA. Are we ok to check off?

Regression is completed
Deploy Blocker
#12275
Open PRs
PR https://github.com/Expensify/App/pull/12124 is failing due to https://github.com/Expensify/App/issues/12249. It is PR fail, so we did not add DeployBlocker label. Pls double check
PR https://github.com/Expensify/App/pull/12136 looks PROD QA. Are we ok to check off?

Hi @mvtglobally. I agree with #12249 being a bug, but not a deploy blocker. I've checked off #12124 as the PR test steps are passing (at least on the first use).

#12275 is now reproducable on prod, so this is not a mobile regression. Continueing to move forward once the last regression is resolved

I checked off the final blocker, #12281 as it was not reproducible for me on web or iOS

Switch Report is looking better in the App performance timing dashboard. Homepage initial render is worse, but we are aligned on the fact that this is due to a change in the timing logic and doesn't accurately represent a regression.

The only new crashlytics issues were from the SVG library crash that was resolved in the last deploy. I cleared up the console while I was there.

Okay, all is good except this bug which was raised against an old issue. I have asked for help with testing as I'm unable to proceed past the 2nd step.

@chiragsalian kindly tested the issue above and wasn't able to reproduce it. @Expensify/applauseleads if you are still able to reliably reproduce this, please open a new issue and I'll investigate further:

:shipit:


go version

Hi!
Which version of go do you need?
I tried on version 1.21.1 but it didn't work

Hi!
What error do you get?

I fixed it thankyou
but still i have one problem
i have 3 upgraded loc but it dosent showing my locations

I fixed it thankyou but still i have one problem i have 3 upgraded loc but it dosent showing my locations

Probably something is not right with the acquisition of locations list. I don't know what exactly :man_shrugging: If you feel it is important, file a separate issue or maybe even look into windscribe extension code to port their API and send a pull request.


Object with two names, what would be best to do?

We have a kind of small issue with an object it has two names “HD189733” and “HD 189733b”
so the DRS thinks they are two different guys.
Ideally we would like to use the whole data set for constructing the templates for telluric correction.
The question were to change the DRSOBJN keyword

in the pp files?
in the e2dsff files?

Another option is to extract independently HD 189733b  and use the copy the already existing HD189733 template
to a HD189733B template and do the telluric correction
using
RUN_FTELLU1 = True
RUN_FTELLU2 = False
RUN_FTELLU3 = False
ideas?
Cheers!
Andres

I think this will hopefully be fixed with these "aliases" we have, in the future - please make a note of it to add it to the aliases column in the google sheet when it is finalized.
Best thing you can do for now is update the raw files from CFHT to correct the OBJECT key - they will then go through the DRS, or as you say edit the pp files (but then you have to remember to do this if you re-preprocess in the future.

Actually I'm also going to tag @vandalt as he is dealing with the google sheet of object names.

The scripts I use to manage the Google sheet should automatically  flag cases like this in the future. It did for this specific one, so "HD 189433b" has been added in the alias column. I'll let @njcuk9999 close the issue, because maybe he wants to keep it open until this has been fully included in the DRS.

Yep I'll leave this open until I've confirmed a few things internally:

when do we update the database with this google sheet
what order do we try to get the object details
tests that this actually works on good/bad object names


Belma Jakupovic

Code complementing evaluation article about hexagonal architecture in java

Closing PR as per instructions from email

Closing PR per email instructions after updating code


Gives FileNotFoundError

$ discurses

Gives this error
Traceback (most recent call last):
  File "/usr/bin/discurses", line 11, in <module>
    load_entry_point('discurses==0.2.4', 'console_scripts', 'discurses')()
  File "/usr/lib/python3.5/site-packages/pkg_resources/__init__.py", line 560, in load_entry_point
    return get_distribution(dist).load_entry_point(group, name)
  File "/usr/lib/python3.5/site-packages/pkg_resources/__init__.py", line 2648, in load_entry_point
    return ep.load()
  File "/usr/lib/python3.5/site-packages/pkg_resources/__init__.py", line 2302, in load
    return self.resolve()
  File "/usr/lib/python3.5/site-packages/pkg_resources/__init__.py", line 2308, in resolve
    module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/usr/lib/python3.5/site-packages/discurses/__init__.py", line 1, in <module>
    import discurses.discord
  File "/usr/lib/python3.5/site-packages/discurses/discord.py", line 10, in <module>
    import discurses.config as config
  File "/usr/lib/python3.5/site-packages/discurses/config.py", line 10, in <module>
    with open(CONFIG_FILE_PATH, 'r') as file:
FileNotFoundError: [Errno 2] No such file or directory: '/home/nagra/.config/discurses.yaml'

https://github.com/topisani/Discurses#authentication
That should help


Implement Polymer stuff to make the mod fully server sided

https://polymer.pb4.eu/0.4.x/

Might not work with GUI stuff though.


Improve buildUrl function

The buildURL function was expecting either an array or an object for pathParams. Depending on what it receives it generates a path URL or a query URL. That was not optimal in some situations.
I’ve changed the signature of the function to expect pathParams - array and queryParams - object. This way we can generate a url with both a path and query.
This is helpful in situations where users of the library would like to generate links to user account, contact or payment request but they also need to have some additional query params.
In the past the payment createRequest function was generating different paths depending on whether one provides a subject (it was difficult to match such paths and created a lot of overhead). Now the path is always the same:
/network/:network_address/:user_address/:amount if the user needs additional params to that url they are added as query params ?subject=1&note=note etc
fixes #336

Codecov Report

Merging #349 into master will increase coverage by 0.32%.
The diff coverage is 77.27%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9254e8...8b1099a. Read the comment docs.

https://en.wikipedia.org/wiki/Uniform_Resource_Identifier
the call it component -> queryParams -> queryComponent ? Or maybe just query since the function name is buildURL, so query in this context should signify query component


improve injection code, make backwards compat explicit, make ssl-api explicit

This PR introduces the following changes:

make the injection-code more readable
make the injection-code more explicit with regards to version-specific backwards-compat
introduce dedicated ssl.context.mock_wrap_socket to mirror stdlib api
convert MocketSSLContext.wrap_socket and .wrap_bio to instance-methods to mirror stdlib api
introduce dedicated urllib3.mock_ssl_wrap_socket methods mirror urllib3 api
use a real ssl.SSLContext in MocketSSLSocket instead of urllib3.ssl_wrap_socket

coverage: 98.876% (-0.4%) from 99.255%
when pulling 199e90344a90d5ea9210b801202e2ed577df5e22 on betaboon:refactor-inject
into 0da27224ad800297c4d120e740e1ba263da0327a on mindflayer:main.

coverage: 98.876% (-0.4%) from 99.255%
when pulling 199e90344a90d5ea9210b801202e2ed577df5e22 on betaboon:refactor-inject
into 0da27224ad800297c4d120e740e1ba263da0327a on mindflayer:main.

coverage: 98.876% (-0.4%) from 99.255%
when pulling 199e90344a90d5ea9210b801202e2ed577df5e22 on betaboon:refactor-inject
into 0da27224ad800297c4d120e740e1ba263da0327a on mindflayer:main.

coverage: 98.876% (-0.4%) from 99.255%
when pulling 199e90344a90d5ea9210b801202e2ed577df5e22 on betaboon:refactor-inject
into 0da27224ad800297c4d120e740e1ba263da0327a on mindflayer:main.

coverage: 98.876% (-0.4%) from 99.255%
when pulling 199e90344a90d5ea9210b801202e2ed577df5e22 on betaboon:refactor-inject
into 0da27224ad800297c4d120e740e1ba263da0327a on mindflayer:main.

I like the function _replace, it makes the code cleaner. I am not sure I see the need for dividing the injecting code into sub-functions. I feet it's a bit of over-engineering with no real benefit. The module is clearly there already (socket/ssl/etc).
I will sleep on it, but I am not 100% sure I like this level of abstraction for something that simple as patching Python modules.

Also, have a look at code coverage, not sure what happened but it went down.

sure. take your time.
i my mind having a dedicated place for each injection logic is more readable, especially considering the python- or urllib3-version specific things.

That's the other thing, I don't think we need to add a new dependency for something as simple as trying to import something or not, I'd keep the with contextlib.suppress(ImportError) instead. It's more robust and easier to maintain.

sleep on it and ping me tomorrow and I'll take care of whatever decision you come to :)

I've just had an idea. It would be nice if we had a dictionary of everything we patched, with the real and the mocked version, and use it to bring the status back, instead of using variables to know of I patched it or not that thing.

I'll give it a try

It could be literally used both ways. As a way to define the monkey-patches and their counterparts.

ok.
i just pushed the following changes:

removed packaging
removed the individual functions from inject.py
introduced something that might be close to your idea


Fix issue #5621: [Bug]: Resolver fails to "Install OpenHands" when ta…

…gged with @openhands-agent on a comment on an PR without the "fix-me"
End-user friendly description of the problem this fixes or functionality that this introduces

[ ] Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions
This is not a bad idea from openhands, break down the if / elif and re-order, so that it checks for labels where there really are labels for example.

Link of any specific issues this addresses
Fix #5621 https://github.com/All-Hands-AI/OpenHands/issues/5465

To run this PR locally, use the following command:
docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:aef7879-nikolaik   --name openhands-app-aef7879   docker.all-hands.dev/all-hands-ai/openhands:aef7879

@malhotra5 I think we can close this one?

Yep this can be closed!


Add a generic for the option value

Since Vue 3.3, there is a generic feature which allows us to pass a custom type down to our component.
Doing this will allow the following:

Remove the forced type Option = { value: string }.
Still provide typing to users without passing an value: any.

There has been some discussions about that feature here: https://github.com/TotomInc/vue3-select-component/issues/4#issuecomment-2053491705

Published in v0.2.0 🎉


Gmail Android shrinking to fit screen

Hi,
I am beginning to use Ink as my goto source for building responsive email templates. Whilst working on private work and using Campaign Monitor for testing purposes I am seeing a recurring issue.
Gmail on Android is shrinking to fill the screen. Making text pretty unreadable. I have done some experimentation to isolate what is going on but have not identified what is causing it. So I have loaded the provided 'sidebar-hero' template into CM to test that. I used the Zurb inliner and did not let CM modify the code on import.
Code imported into Campaign Monitor
https://gist.github.com/freemagee/380c00cd3388cb1076f5#file-sidebar-hero-html
I know Ink is not responsive on Gmail Android, I do not mind about the layout. I just do not want the text to shrink. Any light shed on this is great. Thanks.
Example on Campaign Monitor

Hello, I've had the same problem and did some tests to find out what was going on.
It comes form the min-width: 580px applied to the
More informations here: http://foundation.zurb.com/forum/posts/24189-font-size-on-gmail-with-zurb-ink

Hi Trouba,
Thank you for posting about this. I still use the Ink system and am happy I now know how to prevent this issue in Gmail. I will do some tests of my own and post back here.
Let's silently hope that Gmail responsive support can only get better!

Hi freemagee,
I had no feedback regarding this issue from the Zurb team. So if you find a way to get rid of the min-width:580px without beaking the grid let me know :) I will do some tests too.

Any conclusion?

You can get rid of the many min-width css but it breaks the grid.
Sadly for now I'm back at customizing MailChimp templates until a solutions to this comes up.

I'm getting the same problem.

It's taken a while to come back to this, but I have tested the Zurb sidebar-hero template and commented out references to min-width. Tested on Campaign Monitor, inlined by Campaign Monitor.
The result is this:

Code used here:
https://gist.github.com/freemagee/9937feeefdfb561fbf93#file-sidebar-hero-mod-html
So as you can see the text is not squished anymore. It also looks fine in the other preview windows in Campaign Monitor:
http://ecomms.keyparker.co.uk/screens/r/05F6704F60D95E88
Obviously there are some visual problems, that could probably be addressed. They are outside my scope here.
So I am left feeling not completely sure what the min-width achieves in the Zurb template. I tried some of the techniques from this article:
http://webdesign.tutsplus.com/tutorials/creating-a-future-proof-responsive-email-without-media-queries--cms-23919
But they did not solve this particular problem in relation to Zurb Ink and Android Gmail. Any other insights please add it to the follow up.

This still seems to be an issue with Zurb.  My advice is to design an email that works in gmail for mobile and other mobile clients that don't support media queries first. Once you're satisfied with how it looks there, use media queries to make it tough it up for the mobile clients and desktop apps that do support media queries.

That is a good advice, but Zurb Ink is supposed to be an email framework, and you can't make an email framework without dealing with Gmail (or Inbox). So this issue is a big issue for Ink.

I agree with NelsonScott's advice (a bit like the mobile first approach in RWD) but I think trouba's reasoning is sound too.
The real world use of Zurb Ink with regards to myself is that I started a new work project and needed a robust framework to build a responsive email with. I am leaning on the many man hours that have been put into something like Zurb Ink that right now I can not personally spend on rolling my own framework. It's the same logic why I might use Zurb Foundation when prototyping a webapp etc.
Zurb Ink does pretty much meet my needs and I have used it many times since February when I first began working with it. But with Gmail Android becoming the primary Android email client I expect I will be trying something else out soon.

If you have a major Gmail app or Android userbase, consider Nicole Merlin's
work from a few days ago on Tutsplus: Creating a Future-Proof Responsive
Email Without Media Queries
--Keith

*Moving at the speed of life, *
we are bound to collide with each other.
View My LinkedIn Profile http://www.linkedin.com/in/keithmiller
On Tue, Jun 16, 2015 at 10:18 AM, Neil Magee<EMAIL_ADDRESS>wrote:

I agree with NelsonScott's advice (a bit like the mobile first approach in
RWD) but I think trouba's reasoning is sound too.
The real world use of Zurb Ink with regards to myself is that I started a
new work project and needed a robust framework to build a responsive email
with. I am leaning on the many man hours that have been put into something
like Zurb Ink that right now I can not personally spend on rolling my own
framework. It's the same logic why I might use Zurb Foundation when
prototyping a webapp etc.
Zurb Ink does pretty much meet my needs and I have used it many times
since February when I first began working with it. But with Gmail Android
becoming the primary Android email client I expect I will be trying
something else out soon.
—
Reply to this email directly or view it on GitHub
https://github.com/zurb/ink/issues/122#issuecomment-112468116.

There is a general problem here which needs to be addressed. I have noticed some of the clients i work for, see the contentblocks that should only be visible for desktop also in the responsive mobile e-mail version. For example the contentblock for the header in which the client needs to upload a mobile image and a desktop image, are BOTH shown in the e-mail. This only happens on some android clients. honestly i have no idea how to fix it. It doesn't happen on other devices, just the android native mail client.
The resizing of the newsletter into your screen can simply be fixed by opening an e-mail, click on settings, (right top corner) and go to display settings to switch off "Auto Fit Content". This prevents the mailclient from opening and imimdiatly resizing to fit the entire mail in your screen.

For floating two columns on top of each other ink template it's using column splitting instead of table aligning. A issue that i found regarding this method is that display-block or float:left on "td" is not working for some android versions because the Doctype gets stripped, the solution is to use "th" instead of "td" and to make sure to override the font-weight and align for "th", cause by default it's bold and center.

For floating two columns on top of each other ink template it's using column splitting instead of table aligning. A issue that i found regarding this method is that display-block or float:left on "td" is not working for some android versions because the Doctype gets stripped, the solution is to use "th" instead of "td" and to make sure to override the font-weight and align for "th", cause by default it's bold and center.

For floating two columns on top of each other ink template it's using column splitting instead of table aligning. A issue that i found regarding this method is that display-block or float:left on "td" is not working for some android versions because the Doctype gets stripped. The solution is to use "th" instead of "td", but only for the "td's" inside the row with body content and the sidebar.
You also have to make sure to override the font-weight and align for "th", cause by default it's bold and center.

@Raziel721 i can confirm your solution works. Hero! Now my columns are properly stacking underneath eachother on Android.
This is what did it for me

Becomes:

And make sure you add new CSS for this . Just copy the styles from the corresponding TD's. There are a few CSS lines that need to be editted
td, th {
    word-break: break-word;
    -webkit-hyphens: auto;
    -moz-hyphens: auto;
    hyphens: auto;
    border-collapse: collapse !important;
}

table, tr, td, th {
    padding: 0;
    vertical-align: top;
    text-align: left;
}
td.wrapper,
th.wrapper {
    padding: 20px 20px 0px 0px;
    position: relative;
}

table.row td.last,
table.row th.last,
table.container td.last {
    padding-right: 0px;
}

I am glad that I could help you!
One suggestion:

you don't have to change any css if you first inline your template and
change after the td into th.

On 13 January 2016 at 16:42, Jordy<EMAIL_ADDRESS>wrote:

@Raziel721 https://github.com/Raziel721 i can confirm your solution
works. Hero! Now my columns are properly stacking underneath eachother on
Android.
This is what did it for me

Becomes:

And make sure you add new CSS for this . Just copy the styles from the
corresponding TD's. There are a few CSS lines that need to be editted
td, th {
word-break: break-word;
-webkit-hyphens: auto;
-moz-hyphens: auto;
hyphens: auto;
border-collapse: collapse !important;
}
table, tr, td, th {
padding: 0;
vertical-align: top;
text-align: left;
}
td.wrapper,
th.wrapper {
padding: 20px 20px 0px 0px;
position: relative;
}
table.row td.last,
table.row th.last,
table.container td.last {
padding-right: 0px;
}
—
Reply to this email directly or view it on GitHub
https://github.com/zurb/ink/issues/122#issuecomment-171335111.

@Raziel721 true dat! But i'm working with grunt-prerender, i don't like inlined templates as a source template, only use inlined styles for production ready templates.

Thanks for the examples and comments everyone! Since version 2.0 is in the works, we are looking into this one for workarounds. @Raziel721 solution is a great one off workaround, though we need to have a more concrete implementation in the framework. We'll update with any findings we make as well.
In the meantime we'd love to hear more ideas like this!

One approach we're implementing for 2.0 is making the column element configurable. See: https://github.com/zurb/inky/pull/4
This might help with the flexibility and letting people choose th's vs td's. We'll be looking into this solution further to see if we should default it to th's.
For those using th's have you noticed any inconsistencies in other email clients?

For those using th's have you noticed any inconsistencies in other email clients?

No, not yet! Tested this on a few templates i was working on. Nothing weird found so far.

I am glad to see that my solution was implemented in the new "Foundation for Emails 2" :)
Thank you tdhartwick!

Thanks @Raziel721! The th has been working out really well in v2!  Closing this issue down!

I've tried this and I still happening :(
Index.html:
index.zip
app.scss:
app.zip

@york-xtrem Follow over to #617 on this as it seems like an unrelated question.


Firefox 68: BigInt enabled by default

https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/68:

The new BigInt primitive is enabled by default (bug 1527902).

(Using Firefox 68.0b14 (64-Bit) shows https://tests.caniuse.com/?feat=bigint green as well.)

Thanks!


fix(app): :bug: fix repository url

:tada: This PR is included in version 0.1.1 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


docs: sudo is needed for apt to work

resolves #16

/cc @emsal1863 does this resolve the issue you are seeing?


$derivative is null in mainpage_categories.tpl when category_wells=always

Hi,
I got an error, when when I set category_wells to always and open a mainpage_category page.. The error message was something like "you cannot invoke get_url() on a null object".
I'm new to template coding, but I tried to find the issue. In template/mainpage_categories.tpl line 60 you use $derivative.
data-src="{$derivative->get_url()}"
Since $derivate gets not assigned, when category_wells=always, I assume you want to use $derivative_square, right?
data-src="{$derivative_square->get_url()}"
Thanks
Timo

Your're absolutely correct. Good catch. Thanks!


feature request - hide url in applications

First thank you for this component.
This is purely aesthetic.
Please consider an option to hide the url in applications, as depending on the screen, long urls will offset the column size/gaps.
Thank you

apologies, already possible in css

Hi Juan, would you mind sharing the CSS you used to hide the urls? I tried adding the following:
.AppCard_AppCardDetails__tbAhY span {
  visibility: hidden !important;
}

but it doesn't seem to get picked by the page when it reloads (accessing it via IP:PORT).

@BackedUpBooty Are you sure that CSS file is being loaded correctly?
I tried:
.AppCard_AppCardDetails__tbAhY span {
  visibility: hidden !important;
}

and also
.AppCard_AppCardDetails__tbAhY span {
  display: none !important;
}

and both are working fine on ip:port and flame.domain.tld versions.

To be honest I must have done something random, when I went back into the CSS form it hadn't saved the ID properly, so it's no wonder it wasn't loading up. It's working now!


Date is showing NaN in Datepicker

I am using datepicker of Material UI in my project. But facing one issue with it. I am getting a date value from API and set to state and to Dateicker and can also change it here.
In chrome or firefox its working fine but in Mac OS it's showing "NaN/NaN/NaN" and picker is now showing dates to select. Please find below screenshot.

Code:
<DatePicker
  name="startDate"
  autoOk={true}
  value={ (self.state.start) ? self.state.start : self.state.startDt }
  floatingLabelText="Start Date"
  locale="en-US"
  minDate={self.state.startDt}
  maxDate={expiration}
  onChange={self.handleChange.bind(this, 'start_date', 'date')}
/>

Seems like it's related to "value" option.

Tech
Version

Material-UI
0.19.0

React
15

browser
Safari (Mac)

etc

The date picker is a challenging component to implement. The complexity comes from different sources: date manipulation and correctness, internationalization, keyboard/touch/mouse interactions, customization capabilities. We haven't been porting it to the v1-beta branch yet, nor it's a priority. But we are documenting alternatives. Here are some components that are promising:

material-ui-pickers
material-ui-time-picker

I'm closing for #4787.

@spjoshis We have found that, like Olivier stated, using DatePicker can be challenging. At Call-Em-All we have been using it successfully in production for about 2 years. We continue to find date/time bugs, but these are generally us missing an edge case in our business logic or dealing with the fact that all browsers have a slightly different way of handling a date string.
It's hard to diagnose without seeing your values, but I imagine this issue has to do with the value (as you stated). Perhaps it is formed in a way that Safari doesn't like?

Yes, the issue is with the value and I will fix it after a couple of days as it's not in priority right now.