Github warning when using Issue reporter

Description
What steps will reproduce the problem?

I filed an issue using the Issue reporter. It asked me more my github credentials, which I filled in. Moments later I received the following email from github:

You recently used a password to access an endpoint through the GitHub API using Python-urllib/3.7. We will deprecate basic authentication using password to this endpoint soon:
https://api.github.com/repositories/30892477/issues
We recommend using a personal access token (PAT) with the appropriate scope to access this endpoint instead. Visit https://github.com/settings/tokens for more information.

I submitted this report using Issue reporter, this time generating and using a PAT, and this worked. But googling suggests spyder should register itself as an OAuth application? https://developer.github.com/changes/2019-11-05-deprecated-passwords-and-authorizations-api/
In any case, it is a bit confusing to be allowed to log using a password and then get emails warning you about them.
Versions

Spyder version: 4.0.0
Python version: 3.7.3
Qt version: 5.9.6
PyQt5 version: 5.9.2
Operating System: Windows 7

Dependencies
cloudpickle >=0.5.0          :  1.2.2 (OK)
pygments >=2.0               :  2.5.2 (OK)
qtconsole >=4.6.0            :  4.6.0 (OK)
nbconvert >=4.0              :  5.6.1 (OK)
sphinx >=0.6.6               :  2.2.2 (OK)
pylint >=0.25                :  2.4.4 (OK)
psutil >=0.3                 :  5.6.7 (OK)
qtawesome >=0.5.7            :  0.6.0 (OK)
qtpy >=1.5.0                 :  1.9.0 (OK)
pickleshare >=0.4            :  0.7.5 (OK)
zmq >=17                     :  18.1.0 (OK)
chardet >=2.0.0              :  3.0.4 (OK)
numpydoc >=0.6.0             :  0.9.1 (OK)
spyder_kernels >=1.8.1;<2.0.0:  1.8.1 (OK)
qdarkstyle >=2.7             :  2.7 (OK)
atomicwrites >=1.2.0         :  1.3.0 (OK)
diff_match_patch >=20181111  :  20181111 (OK)
intervaltree                 :  None (OK)
watchdog                     :  None (OK)
keyring                      :  None (OK)
pexpect >=4.4.0              :  4.7.0 (OK)
pympler                      :  None (OK)
sympy >=0.7.3                :  1.4 (OK)
cython >=0.21                :  0.29.14 (OK)
IPython >=4.0                :  7.10.1 (OK)
matplotlib >=2.0.0           :  3.1.1 (OK)
pandas >=0.13.1              :  0.25.3 (OK)
numpy >=1.7                  :  1.17.4 (OK)
scipy >=0.17.0               :  1.3.2 (OK)
pyls >=0.31.2;<0.32.0        :  0.31.2 (OK)
rtree >=0.8.3                :  0.8.3 (OK)

I submitted this report using Issue reporter, this time generating and using a PAT, and this worked.

It seems we need to disable password-based authentications and only request tokens. Thanks for letting us know about it.

But googling suggests spyder should register itself as an OAuth application?

That only works for web apps. Non-web apps need to require personal tokens:
https://developer.github.com/apps/building-oauth-apps/authorizing-oauth-apps/#non-web-application-flow

I decided to fix this for 4.0.1 because Github could remove password based authentications at any moment.


It is unclear to me how tsconfig.json is used in Visual Studio 2015

It is unclear to me how tsconfig.json is used in Visual Studio 2015.  And what happens when the TypeScript panel in the Project Properties conflicts?

Sorry for the confusion.. we are working on cleaning this up. An easy way to think of this, is a project file (.csprox, .jsproj, .vbproj or .njsproj) and a tsconfig.json are mutually exclusive. if you have a project file the tsconfig is ignored. if you want to use a tsconfig file, do not use a project.
In the future, i would see us adding an option in the project property pages to allow you to use tsconfig or not, and if so, the project property pages will all be grayed out..

tsconfig.json is only supported in Asp.net 5 and Cordova projects currently. Since neither has a Project Properties for TypeScript they won't conflict, and tsconfig.json will take precedence.
To enable Compiler on Save, you need to enable Compile on Save for files that are not part of a project, in the Tools/Options/Text Editor/TypeScript.
We plan to have more comprehensive support in 1.6.

Closing this as by design, using #4161 to track this.


Add compatibility tests for v5.0.x #2

Description

This PR replaces #2370
This is a re-work of the referenced PR. Instead of using a large json file per release branch, this method allows us to define smaller, more maintainable files per release branch / test suite pair.
Sample workflow: here
Update: One additional benefit, each job is limited to creating 256 tasks. A github workflow can have multiple jobs, i.e. transfer, client, incentivized etc. While we are not at that level yet (transfer test is creating 80), splitting up  like this leaves more room for growth without refactoring how the tests run in the future.
closes #2370

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

[x] Targeted PR against correct branch (see CONTRIBUTING.md)
[ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[ ] Code follows the module structure standards.
[ ] Wrote unit and integration tests
[ ] Updated relevant documentation (docs/) or specification (x/<module>/spec/)
[ ] Added relevant godoc comments.
[ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
[x] Re-reviewed Files changed in the Github PR explorer
[ ] Review Codecov Report in the comment section below once CI passes

@colin-axner & @charleenfei thank you for reviewing #2370 after some discussion with @crodriguezvega and looking some more into Colin's suggestion, I refactored the workflow to be (much) more maintainable. The workflows are largely the same, it's mostly just the smaller config file we need to manage.

@damiannolan

Will we also need to add blocks for interchain-accounts here?

Currently all the interchain accounts tests are running using the icad, so the state of the release branch in ibc-go should have no impact here right?

I'm not sure I understand fully here. Could you provide me with the verbose output

Right maybe I can add some clarification, the tests themselves exist under e2e/... but the matrix files for the workflow live separately (the new dir added in this PR) compatibility-test-matrices.
This additional field e.g. test-suite: "transfer" is literally just a convention I'm using to pass arguments to the reusable workflow so that we can run any test suite the same way by adhering to a directory structure.
compatibility-test-matrices/<release-<version>/<test-suite>.json

Currently all the interchain accounts tests are running using the icad, so the state of the release branch in ibc-go should have no impact here right?

I guess the question is if we want to be able to trigger icad compatibility tests from ibc-go as well (long term no, but maybe in the short term?)

@colin-axner

I guess the question is if we want to be able to trigger icad compatibility tests from ibc-go as well (long term no, but maybe in the short term?)

Right, we can already do this with the Manual E2E (Icad) test. But I think long term will be able to use simd and it can be added as a new file here.


set virtlogd_var_run_t for nova instances folder.

PR fixes below AVC where nova-compute run's under libvirtd_t process context
audit.log.1:type=AVC msg=audit(1489418975.073:186): avc:  denied  { append } for  pid=3312 comm="virtlogd" name="console.log" dev="dm-0" ino=24510486 scontext=system_u:system_r:virtlogd_t:s0-s0:c0.c1023 tcontext=system_u:object_r:nova_var_run_t:s0 tclass=file

retest

@paulczar can you please review this PR. Needed custom policy as well.
Unit test Covered for following Nova actions:
boot, stop, start. resume, suspend, snapshot, lock, unlock, Hard reboot, soft reboot, shelve and unshelve

retest

retest


++(full video!!)*  One Girl One Frog, a young and talented digital creator, recently became famous thanks to this interesting video.
 One Girl One Frog, a young and talented digital creator, recently became famous thanks to this interesting video.


The driver.deleteSession() command doesn't work and returns an error

I am trying to use the driver.deleteSession() command as mentioned in the appium-flutter-driver README file, but I am facing the problem that the test fails at the driver.deleteSession() step.
Example of a test file:
    it('Test', async function () {
        await signinPage.checkSigninPageIsDisplayed();
        // some other steps
        await driver.deleteSession();
    });

Error logs:
 ERROR webdriver: Request failed with status 404 due to invalid session id: A session is either terminated or not started
 ERROR @wdio/local-runner: Failed launching test session: invalid session id: A session is either terminated or not started

Stack
WebdriverIO + appium (2.0.0-beta.44) + appium-flutter-driver (1.7.2) + Android emulator.
Capabilities
config.capabilities = [
    {
        maxInstances: 1,
        platformName: 'Android',
        'appium:deviceName': 'emulator-5554',
        'appium:platformVersion': '12.0',
        'appium:automationName': 'Flutter',
        'appium:app': '/path.apk',
        'appium:noReset': false,
    },
];

Has anyone faced the same problem?

Could you share the appium log? I haven't seen the error in driver.quit in Ruby and Python appium libs I usually use. Appium log will help me to guess the cause

Below are the logs for these steps:
it('Test', async function () {
        console.log('sessionId', driver.sessionId);
        await driver.deleteSession();
    });

Console:
2022-10-18T10:45:52.199Z DEBUG @wdio/utils:initialiseServices: initialise custom service "RpService"
2022-10-18T10:45:52.200Z DEBUG @wdio/utils:initialiseServices: initialise service "appium" as NPM package
2022-10-18T10:45:52.213Z INFO @wdio/cli:launcher: Run onPrepare hook
2022-10-18T10:45:52.214Z DEBUG @wdio/appium-service: Will spawn Appium process: appium --base-path / --port 4723 --debug-log-spacing --session-override
2022-10-18T10:45:56.593Z DEBUG @wdio/appium-service: Appium started with ID: 3192
2022-10-18T10:45:56.593Z DEBUG @wdio/cli:utils: Finished to run "onPrepare" hook in 4379ms
2022-10-18T10:45:56.594Z INFO @wdio/cli:launcher: Run onWorkerStart hook
2022-10-18T10:45:56.594Z DEBUG @wdio/cli:utils: Finished to run "onWorkerStart" hook in 0ms
2022-10-18T10:45:56.594Z INFO @wdio/local-runner: Start worker 0-0 with arg: run,e2e-app/configs/android.qa-auto.conf.ts,--spec,e2e-app/specs/app.loginLocation.spec.ts
[0-0] For help, see: https://nodejs.org/en/docs/inspector
[0-0] 2022-10-18T10:45:56.854Z INFO @wdio/local-runner: Run worker command: run
[0-0] 2022-10-18T10:45:56.958Z DEBUG @wdio/config:utils: Found 'ts-node' package, auto-compiling TypeScript files
[0-0] 2022-10-18T10:45:57.091Z DEBUG @wdio/local-runner:utils: init remote session
[0-0] 2022-10-18T10:45:57.094Z DEBUG @wdio/utils:initialiseServices: initialise custom service "RpService"
[0-0] 2022-10-18T10:45:57.094Z DEBUG @wdio/utils:initialiseServices: initialise service "appium" as NPM package
[0-0] RUNNING in Android - /e2e-app/specs/app.loginLocation.spec.ts
[0-0] 2022-10-18T10:45:57.233Z DEBUG @wdio/local-runner:utils: init remote session
[0-0] 2022-10-18T10:45:57.234Z INFO webdriver: Initiate new session using the WebDriver protocol
[0-0] 2022-10-18T10:45:57.261Z INFO webdriver: [POST] http://localhost:4723/session
[0-0] 2022-10-18T10:45:57.261Z INFO webdriver: DATA {
[0-0]   capabilities: {
[0-0]     alwaysMatch: {
[0-0]       platformName: 'Android',
[0-0]       'appium:deviceName': 'emulator-5554',
[0-0]       'appium:platformVersion': '12.0',
[0-0]       'appium:automationName': 'Flutter',
[0-0]       'appium:app': '/path.apk',
[0-0]       'appium:noReset': false,
[0-0]       'appium:retryBackoffTime': 500,
[0-0]       'appium:maxRetryCount': 20
[0-0]     },
[0-0]     firstMatch: [ {} ]
[0-0]   },
[0-0]   desiredCapabilities: {
[0-0]     platformName: 'Android',
[0-0]     'appium:deviceName': 'emulator-5554',
[0-0]     'appium:platformVersion': '12.0',
[0-0]     'appium:automationName': 'Flutter',
[0-0]     'appium:app': '/path.apk',
[0-0]     'appium:noReset': false,
[0-0]     'appium:retryBackoffTime': 500,
[0-0]     'appium:maxRetryCount': 20
[0-0]   }
[0-0] }
[0-0] sessionId 57eb4a63-1817-4e69-b472-a5572d334515
[0-0] 2022-10-18T10:46:28.598Z INFO webdriver: COMMAND deleteSession()
[0-0] 2022-10-18T10:46:28.600Z INFO webdriver: [DELETE] http://localhost:4723/session/57eb4a63-1817-4e69-b472-a5572d334515
[0-0] 2022-10-18T10:46:28.785Z DEBUG @wdio/utils:shim: Finished to run "afterTest" hook in 0ms
[0-0] 2022-10-18T10:46:28.787Z INFO webdriver: COMMAND deleteSession()
[0-0] 2022-10-18T10:46:28.787Z INFO webdriver: [DELETE] http://localhost:4723/session/57eb4a63-1817-4e69-b472-a5572d334515
[0-0] 2022-10-18T10:46:28.809Z DEBUG webdriver: request failed due to response error: invalid session id
[0-0] 2022-10-18T10:46:28.810Z INFO webdriver: Retrying 1/2
[0-0] 2022-10-18T10:46:28.810Z INFO webdriver: [DELETE] http://localhost:4723/session/57eb4a63-1817-4e69-b472-a5572d334515
[0-0] 2022-10-18T10:46:28.810Z WARN webdriver: Request failed with status 404 due to A session is either terminated or not started
[0-0] 2022-10-18T10:46:28.824Z DEBUG webdriver: request failed due to response error: invalid session id
[0-0] 2022-10-18T10:46:28.825Z INFO webdriver: Retrying 2/2
[0-0] 2022-10-18T10:46:28.825Z INFO webdriver: [DELETE] http://localhost:4723/session/57eb4a63-1817-4e69-b472-a5572d334515
[0-0] 2022-10-18T10:46:28.824Z WARN webdriver: Request failed with status 404 due to A session is either terminated or not started
[0-0] 2022-10-18T10:46:28.839Z DEBUG webdriver: request failed due to response error: invalid session id
[0-0] 2022-10-18T10:46:28.839Z ERROR webdriver: Request failed with status 404 due to invalid session id: A session is either terminated or not started
[0-0] 2022-10-18T10:46:28.841Z ERROR @wdio/local-runner: Failed launching test session: invalid session id: A session is either terminated or not started
...
2022-10-18T10:46:28.858Z DEBUG @wdio/local-runner: Runner 0-0 finished with exit code 1
[0-0] FAILED in Android - /e2e-app/specs/app.loginLocation.spec.ts
2022-10-18T10:46:28.858Z INFO @wdio/cli:launcher: Run onWorkerEnd hook
2022-10-18T10:46:28.859Z DEBUG @wdio/cli:utils: Finished to run "onWorkerEnd" hook in 0ms
2022-10-18T10:46:28.859Z INFO @wdio/cli:launcher: Run onComplete hook
2022-10-18T10:46:28.859Z DEBUG @wdio/appium-service: Appium (pid: 3192) killed
2022-10-18T10:46:28.859Z DEBUG @wdio/cli:utils: Finished to run "onComplete" hook in 0ms

@KazuCocoa FYI

The first delete request [DELETE] http://localhost:4723/session/57eb4a63-1817-4e69-b472-a5572d334515 worked so Finished to run "afterTest" hook in 0ms was printed, but the next delete request [0-0] 2022-10-18T10:46:28.787Z INFO webdriver: [DELETE] http://localhost:4723/session/57eb4a63-1817-4e69-b472-a5572d334515 got the invalid session error (and retried a few times)?
I cannot say exact thing without Appium server log, but it seems like the client sent delete session requests 4 times in total. The first one probably succeeded, but the rest of them got 404 invalid session error because the first one closed the session properly. Is it correct?
[0-0] sessionId 57eb4a63-1817-4e69-b472-a5572d334515
[0-0] 2022-10-18T10:46:28.598Z INFO webdriver: COMMAND deleteSession()
[0-0] 2022-10-18T10:46:28.600Z INFO webdriver: [DELETE] http://localhost:4723/session/57eb4a63-1817-4e69-b472-a5572d334515
[0-0] 2022-10-18T10:46:28.785Z DEBUG @wdio/utils:shim: Finished to run "afterTest" hook in 0ms
[0-0] 2022-10-18T10:46:28.787Z INFO webdriver: COMMAND deleteSession()
[0-0] 2022-10-18T10:46:28.787Z INFO webdriver: [DELETE] http://localhost:4723/session/57eb4a63-1817-4e69-b472-a5572d334515
[0-0] 2022-10-18T10:46:28.809Z DEBUG webdriver: request failed due to response error: invalid session id
[0-0] 2022-10-18T10:46:28.810Z INFO webdriver: Retrying 1/2
[0-0] 2022-10-18T10:46:28.810Z INFO webdriver: [DELETE] http://localhost:4723/session/57eb4a63-1817-4e69-b472-a5572d334515
[0-0] 2022-10-18T10:46:28.810Z WARN webdriver: Request failed with status 404 due to A session is either terminated or not started
[0-0] 2022-10-18T10:46:28.824Z DEBUG webdriver: request failed due to response error: invalid session id
[0-0] 2022-10-18T10:46:28.825Z INFO webdriver: Retrying 2/2
[0-0] 2022-10-18T10:46:28.825Z INFO webdriver: [DELETE] http://localhost:4723/session/57eb4a63-1817-4e69-b472-a5572d334515
[0-0] 2022-10-18T10:46:28.824Z WARN webdriver: Request failed with status 404 due to A session is either terminated or not started
[0-0] 2022-10-18T10:46:28.839Z DEBUG webdriver: request failed due to response error: invalid session id
[0-0] 2022-10-18T10:46:28.839Z ERROR webdriver: Request failed with status 404 due to invalid session id: A session is either terminated or not started
[0-0] 2022-10-18T10:46:28.841Z ERROR @wdio/local-runner: Failed launching test session: invalid session id: A session is either terminated or not started
...

Still I need the Appium server's log to see responses by Appium to the client, but it seems like the client should send the delete request once, not 4 times. Thus kind of client behavior rather than server side (Appium/flutter driver)

Hi @DKasianova I am currently facing this issue, have you been able to fix it, and how?

Hi @SanusiWasiu, I started using the reloadSession() method in my tests, it works fine. Also, I see that the deleteSession() method started working differently after updating versions to appium: 2.0.0-beta.53 and appium-flutter-driver: 1.12.0, I no longer see the client sending the delete request 4 times. So I think I'll close this issue and if you have a similar problem try opening a new one with your steps and logs.


Generated structs should have the omitempty tag option

Would avoid situations like this described in https://github.com/andreykaipov/goobs/pull/5#discussion_r652210713

Every field now has omitempty by default except any boolean field, which all omit omitempty.
For example, in the case of SetSceneItemProperties, the Visible field can't have omitempty because making it invisible would involve setting it to false, at which point the JSON encoder will omit it from the sent request.
I imagine there's a few integer fields whose empty value (0) happens to be a valid value in a request, so in the future more fields may omit omitempty, but that's something to worry about later ... 😄


In watch list, support view as Text

Here is my use-case for it, this array of bytes is a text string:

show here is d-pad + PS2 face button notation

I think the idea is array of chars with no stop condition.
I'm fine with either naming choice.
Would Japanese Characters display properly? There are plenty of games with them.

Japanese characters? You got me here. I was really thinking of just ASCII characters and nothing else. Any hex editor out there that would show UTF-8 or things like that?

Just to clarify, isn't the current string watch type good enough?

I mean the value view, not the type

As for the supported character set, whatever the Memory Viewer currently does is fine.

Just to clarify, isn't the current string watch type good enough?

I just updated to 0.9 I think that's a new option? Looks like it does exactly what I'm asking for

I think string has been a long-standing watch type. That's why we thought what you wanted is a non-null-character-terminated array of chars, like hex editors would do (showing   for null characters, and . for non-ASCII characters, etc.).

Sorry for the confusion.


Needs LOTS more detail

Please explain why a WDFDEVICE and a UFXDEVICE is needed?
When I create a WDFDEVICE is it the FDO, or a filter? The docs (https://docs.microsoft.com/en-us/windows-hardware/drivers/usbcon/developing-windows-drivers-for-usb-function-controllers) indicate that Ufx010000.sys creates the FDO.
Please describe the rationale for having a UFXDEVICE and a WDFDEVICE, and what data would typically be in each object's context area
The Initialization section needs LOTS more detail! For example, where would a driver call UfxDeviceNotifyHardwareReady? From DeviceAdd, PrepareHardware, D0Entry, etc?
Will our driver get IOCTLs from applications, or just internal IOCTLs from the class library?
There really needs to be a SIMPLE minimal functioning sample for a software-only device that implements a few endpoints that works (unlike the current sample), to demonstrate how to write a UFX driver

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 4458225b-56bb-77f0-2378-97e8dd442ef9
Version Independent ID: a5ed7881-cace-9b0e-ff8c-b356e8969feb
Content: Write a function controller client driver - Windows drivers
Content Source: windows-driver-docs-pr/usbcon/function-client-driver.md
Product: windows-hardware
Technology: windows-devices
GitHub Login: @duncanmacmichael
Microsoft Alias: dumacmic

Hi @BrianCatlin,
I’ve created an internal work item for myself to investigate this with the USB team, and I’ll make a note here when I complete the changes. In the meantime, I’m closing the GitHub issue while it’s tracked in the bug. Thanks again for helping to improve the docs.


Save some CPU time by reducing number of fillRect calls/canvas updates

Assuming fillRect is expensive and updates are generally rare (you can only draw 8x8/16x16 sprite toggling bitplanes), I tried to fill only pixels that changed
(chrome profiler shows up to 10x performance improvement for all games I tested, heavy games don't feel sluggish anymore)
I hope @comrat should be able to test it on some tellies which are often slow.
These are results from kesha-was-niiinja game

I've just tested skyward and kesha games using LG SmartTV with this patch. Their performance is significant better.
I've tested on the same TV:
Video before patch: https://drive.google.com/open?id=0B8spWF4y456Idk5FYUdVODFPQm8
Video after: https://drive.google.com/open?id=1CshGeyTrT0V_ht2Svh6Q1DUCWhV10Jsn

oh dear, I did not think it was THAT bad before :D

Broken game:
https://johnearnest.github.io/Octo/index.html?gist=dd07f4c544fc95b6ad94
Please do not merge this pull request until I figure out what happened

it looks like it's a bug in this game: missing clear after hires:
fixed variant:
https://johnearnest.github.io/Octo/index.html?gist=f422446519f2b57b93e03541606b9ab4

Now I understand why you wanted performance improvements. Cool project :)

fixed in 4093d7ab50dd46faf8b4f8cd5f004450ca5f4ee0

039bf247768c4f52b484404f30a372330c37915a is fixing out of bound write, which expands framebuffer array and breaks optimization in both old and new code.


Configure dependabot for the various services / languages

automate security fixes for demo services not just infra

We have this setup now. Can we close this issue?


(docfix) minor README change to address latest updates

Hello! This is just a minor doc fix to address changes in compose logic introduced with https://github.com/Kong/docker-kong/pull/493

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

since this is about docker-compose, we should keep the instructions based on docker-compose, not on the makefile imo. I assume the makefile is mostly used for testing.
wdyt @hutchic ?

Hi @Tieske, thanks for having a look at this!
In my opinion, the advantage of using a makefile is to abstract certain operations for the users who will only know the specific make targets: next time something change in the docker-compose.yaml file (e.g. new flags, new db supported etc), nothing will change on the setup instructions.
Also, make kong-dbless clearly states what the end setup would look like, instead of an obscure docker-compose up -d , especially if different setups are supported, like in this case.
 :)

How to use this template
This Docker Compose template provisions a Kong container with a Postgres database, plus a nginx load-balancer. After running the template, the nginx-lb load-balancer will be the entrypoint to Kong.
To run this template execute:
$ docker-compose up

The description is not true. Because Kong run as dbless mode.
I have no option to use docker compose or 'make`, could you write down correct description.
If docker compose is preferred,
COMPOSE_PROFILES=database KONG_DATABASE=postgres docker-compose up -d

or, if make is preferred,
make kong-postgres

Superseded by #628.


merge product taxonomy updates to the config

Docs Build status updates of commit 08b86fe:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

officedocs-dev-excel-pia/docfx.json
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Slow InceptionV3 initialisation

Describe the bug
Model init for InceptionV3 model both from this repo and from torchvision.models take very long time. Usually ~180-200 seconds, while other models init in 2-3 sec.
Problem arose a couple of month ago and discussed here
To Reproduce
from torchvision.models import inception_v3
import photosynthesis_metrics as pm
import scipy
print(scipy.__version__)

model = inception_v3(pretrained=True, transform_input=True, progress=True)
pm_model = pm.feature_extractors.fid_inception.InceptionV3(
    resize_input=True,
    normalize_input=True,
    requires_grad=False,
    use_fid_inception=True,
)

This could should take around 6 minutes to complete (3 minutes per model).
Expected behaviour
Fast model initialisation, not longer than a couple of seconds.
Fix
Problem comes from scipy package with version 1.4.1 defined in requirements.txt.
Uninstalling newer version and installing 1.3.3 fixed the issue for me. The loading time is much faster now. Just had to do pip install --upgrade scipy==1.3.3
Proposed solution
Change version in requirements.txt
This will increase testing speed 10x (now all tests run in 10 minutes, because of 3 model inits, after fix they will run in 1 minute).

Closed in #45


Update the CLI documentation.

I've updated much of the CLI documentaiton, but there's still the server group that I need to cover. I'll do that as a separate PR.

Victor, please update the cli/index.rst. I'd drop the table because we'll have it all displayed in the TOC anyways. Need to add installation instructions (and copy the bullet list from https://www.edgedb.com/install).
You can also add this paragraph:

EdgeDB includes the all-encompassing edgedb command-line tool. It provides an idiomatic way to do just about everything: install EdgeDB, spin up a local instance, open a REPL, execute queries, manage auth roles, introspect a database schema, create migrations, and more. Install it with one shell command.

Update the PR to move install/uninstall instructions to the overview blurb. Updated the wording of the overview as well.


Erisc and Worker CBs not being accounted separately

Description
When running a test for a new feature, a dispatcher code path is reporting an ethernet core is running out of space for worker config. It is reporting several hundred bytes of CB usage on the ethernet cores even though CBs are not supported on ethernet cores (nor are they specified in the op's program).
Error Message:
../tt_metal/impl/dispatch/worker_config_buffer.cpp:64: size <= this->end_addrs_[idx] - this->base_addrs_[idx]

When dumping the variables in the assert we see:
Always | INFO     | size: 544, idx: 1, end_addr: 102112, base_addr: 101600

Further investigation into Program::finalize shows the following breakdown:
Always | INFO     | Offset after RT args: 240                 // Expected
Always | INFO     | Offset after sems: 240                     // Expected
Always | INFO     | Offset after CBs: 544                       // Wrong

Suspected Source Of Problem
Based on the above I looked into update_kernel_groups to understand where the CBs are coming from. The code here looks incorrect. It doesn't seem to distinguish between worker logical cores and ethernet logical cores. This is a problem because Ethernet and Worker logical core ranges can overlap. Therefore, it looks like worker CBs are being misattributed to Ethernet cores.
Impact
This issue is currently blocking forward progress on some CCL ops that are necessary for model work on Galaxy.
To repro:

checkout branch: snijjar/issue-12738-repro
Login to t3000 (Wormhole) machine
Buiid (I built with ./build_metal.sh -e -b Debug)
Run failing test: pytest tests/ttnn/unit_tests/operations/test_reduce_scatter_post_commit.py -k line

this should be fixed


bridge: add custom logger support

Codecov Report
Attention: 31 lines in your changes are missing coverage. Please review.

Comparison is base (a553654) 71.13% compared to head (4652066) 71.08%.

Files
Patch %
Lines

client/core/logger.go
50.00%
15 Missing :warning:

bridge/device/cloud/manager.go
40.00%
6 Missing :warning:

bridge/service/options.go
42.85%
4 Missing :warning:

bridge/device/cloud/options.go
0.00%
3 Missing :warning:

bridge/net/network.go
88.00%
2 Missing and 1 partial :warning:

Additional details and impacted files
@@                        Coverage Diff                        @@
##           jkralik/feature/bridge-device     #434      +/-   ##
=================================================================
- Coverage                          71.13%   71.08%   -0.06%
=================================================================
  Files                                121      122       +1
  Lines                               7013     7049      +36
=================================================================
+ Hits                                4989     5011      +22
- Misses                              1454     1468      +14
  Partials                             570      570

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Do not close dataplane if we update local-dst with local-dst on nsm request

Expected Behavior
We closing dataplane for case local-dst with local-dst in nsm
Current Behavior
We do not close dataplane for case local-dst with local-dst in nsm
Steps to Reproduce
Run TestNSEHealLocal
Context
More information about the problem https://github.com/ligato/vpp-agent/issues/1373
Entry point: nsm.go:287

Closing.


Create annotations on check runs in batches of 50

Fixes #10.

Pull Request Test Coverage Report for Build 34

13 of 13 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 32:
0.0%

Covered Lines:
61

Relevant Lines:
61

💛  - Coveralls


[release/1.2] Fix shim delete error code.

Cherrypick https://github.com/containerd/containerd/pull/3730 into release 1.2
Signed-off-by: Lantao Liu<EMAIL_ADDRESS>

Codecov Report

Merging #3732 into release/1.2 will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release/1.2    #3732   +/-   ##
============================================
  Coverage        44.19%   44.19%
============================================
  Files              100      100
  Lines            10847    10847
============================================
  Hits              4794     4794
  Misses            5313     5313
  Partials           740      740

Flag
Coverage Δ

#linux
47.87% <ø> (ø)
:arrow_up:

#windows
41% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 816dfe3...611766a. Read the comment docs.


Run ndc codemod to improve next.js compatibility

I'm submitting a...

[ ] bug
[ ] feature
[x] chore

What is the current behavior
I am using react-fincancial-charts in next.js, and the compiler raises warnings about the anonymous function exports from the react-financial-charts files, e.g.
<EMAIL_ADDRESS>Anonymous function declarations cause Fast Refresh to not preserve local component state.
Please add a name to your function, for example:

Before
export default function () { /* ... */ }

After
export default function Named() { /* ... */ }

A codemod is available to fix the most common cases: https://nextjs.link/codemod-ndc

What is the expected behavior
Named default exports would improve the compatibility of the library with next.js applications.
Please tell us about your environment

Version: 1.3.0
Compiler: next.js (webpack + tsc)

Other information
The codemod would solve the problem by assigning a generated name (based on the filename) to all default exports that were previously anonymous.

@rondonjon Hi! How did you integrate react-financial-charts with Next.js?
I was having this error after installing
JSX element type 'StockChart' does not have any construct or call signatures.ts(2604)

Webpack5 couldn't compile and was complaining about the module not using ES import.
@markmcdowell Would you please add some pointers?

@huydhoang, have you included the library in your webpack config so that it gets transpiled? https://stackoverflow.com/questions/54043498/how-to-transpile-node-modules-modules-with-babel-loader

Thanks @rondonjon that explains. I haven't touched webpack config.
Do you know which JS version react-financial-charts supports directly without transpiling?
I feel like bringing in babel would be far too complex for my use case so perhaps I must revert to more rusty tech.

Hi no it’s the other way around, you need Babel to support older versions of JavaScript. Next.js doesn’t support es modules out of the box

@markmcdowell Now that I see. Thank you for pointing out my ignorance.
Looking around the codebase and existing issue tickets, I still couldn't find a way to resolve import errors within create-react-app.
Will file an issue if needed.

Good news to folks who wanna enjoy TypeScript in React, I was able to import stuff using Aleph.js - a React framework inspired by Next in the Deno ecosystem. And since Deno compiles TypeScript directly without using Babel, no hassle in terms of JS versioning.
Importing can be done through esm.sh
https://esm.sh/react-financial-charts

did anyone get this working with next-js? Can kind of get it to work at least for developing by commenting out my chart, run dev and then uncomment and it all works getting me around the fast refresh issue, but of course this won't allow me to build it.
It spits out this error
Error: Must use import to load ES Module: /home/me/Projects/{projectName}/node_modules/react-financial-charts/lib/index.js
require() of ES modules is not supported.
require() of /home/me/Projects/{projectName}/node_modules/react-financial-charts/lib/index.js from /home/me/Projects/{projectName}/packages/web/.next/server/pages/index.js is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.
Instead rename /home/me/Projects/{projectName}/node_modules/react-financial-charts/lib/index.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from /home/me/Projects/{projectName}/node_modules/react-financial-charts/package.json.
This is with the following config
next.config.js =>
`const withTM = require('next-transpile-modules')([
'@react-financial-charts/core',
'@react-financial-charts/axes',
'@react-financial-charts/scales',
'@react-financial-charts/series',
'@react-financial-charts/utils',
'@react-financial-charts/annotations',
])
module.exports = withTM({
future: {
webpack5: true,
},
webpack: (config) => {
config.experiments = {
topLevelAwait: true,
}
return config
},
typescript: {
ignoreDevErrors: true,
ignoreBuildErrors: true,
},
trailingSlash: false,
})`
tsconfig.json =>
{   "compilerOptions": {     "jsx": "preserve",     "lib": ["dom", "es2018", "es2019.object", "esnext.asynciterable"],     "typeRoots": ["./node_modules/@types"],     "rootDir": "src",     "target": "es6",     "composite": false,     "allowJs": true,     "moduleResolution": "node",     "strict": true,     "allowSyntheticDefaultImports": true,     "esModuleInterop": true,     "forceConsistentCasingInFileNames": true,     "noEmit": true,     "noUnusedLocals": false,     "resolveJsonModule": true,     "removeComments": false,     "skipLibCheck": true,     "baseUrl": ".",     "module": "esnext",     "isolatedModules": true,     "experimentalDecorators": true   },   "exclude": ["./node_modules", ".cache", "dist"],   "include": ["./**/*.tsx", "./**/*.ts", "next-env.d.ts"] }


Generate and verify hashes for all required python packages

This change adds hash verification to all pip packages brought in as dependencies.  It does this by updating the pip-compile command with the --generate-hashes flag.  All requirements files are updated to include sha256 hashes, and they are verified using the --require-hashes argument to pip install. In creating this change, the requirements.txt files received hashes for all packages, but the package versions were not updated.  The build would fail without adding hashes at this time, which is why they are included.
For local development, this change should just work as it always has.  However, if you are building Lemur using external tools/configurations, this may impact your build.  Just running pip install -e . will no longer pull in requirements.txt.  To fix this, update your build script by adding pip install --require-hashes -r requirements.txt just after the previous command.
Hash-Checking Mode

Closing for now, since we couldn't see any significant benefits.


Add album name support (plus, one more toggle in the track label)

Hello there. I would like to request a feature that allows to put album name in the track label. Currently, I can't check the name of an album in UI at all, only its cover art. I would like to have something like Earmake — Parallels — Between Good and Evil in the panel.
Alternatively, having album name in the track information menu would be nice.

Alright I will add it.

That would be great top have album name visble.


Refactor reducer

Reference Issues/PRs
#955

removed forecasting mixins and replaced with tags.
moved fit in _Reducer. there was one check in this fit that was moved to all the other _fit methods
added fh as parameter to all the _fit methods and adjusted docstring as such

Note that locally I checked only the tests for reduce, and those all passed. But who knows if other tests will fail... :/

@fkiraly Please review this

Just a comment: Having a _fit method in the _Reducer class which implements the check_window_length call and then delegates to another _internal_fit(or whatever you want to call it) would be an alternative but seems a bit overcomplicated.

I had similar thoughts, but also think it would have been overcomplicated

tests passed overnight - tests have re-started due to a PR that only fixed a broken link, so force-merging


Implementation of the new API

This is a huge PR. I've tried to keep the commits self-contained. So I suggest that your review one commit after another instead of the full PR. I'm happy to change the individual commits as I think for so many changes and breaking APIs it's important to have a clean history.
It might even make sense to review the "users" of that new API first, to get a feeling how this API really feels like:

https://github.com/ipfs/js-ipfs-unixfs-importer/pull/20
https://github.com/ipfs/js-ipfs-unixfs-exporter/pull/15
https://github.com/ipfs/js-ipfs-mfs/pull/35
https://github.com/ipfs/js-ipfs/pull/1848

@alanshaw I think I addressed all your comments (btw: they were great, the code is much better now). I also added some information about the extended iterators that are returned by the API (see https://github.com/ipld/js-ipld/blob/f5fa4ceba7dc1f85ba771dce00b1679fc099d990/README.md#api).

@alanshaw thanks for the thorough review. I've pushed new commits, all comments should be either addressed by those commits or my comments.

My PR on typical to add async iterator support was merged an released!

Pushed a new commit that adds the *Many() functions to match the most recent https://github.com/ipld/js-ipld/pull/191. @alanshaw it would be great if you could have a look.


Fixes knife-block for chef 12

Using chef_config_dir instead of locate_config_file

Hi all,
I've just updated the travis.yml file so that it will test against ruby 2.x (the main issue that seemed to be causing it to fail previously).
It's now failing with a different error but it's been so long since I touched ruby that I've forgotten where to start. :(
The good news is that @solarce now has access to rubygems.org for this so once it's been fixed you should be able to get it merged and published.
Thanks again for all your interest,
Matt

Argh, somehow I wasn't watching the repo, I'm gonna do some work on getting builds passing on travis this weekend and getting issues/PRs fixed up

I modified the tests to run under chef 12 and chefdk 0.4.0 but this still didn't pass tests with the following error.
/opt/chefdk/embedded/lib/ruby/gems/2.1.0/gems/chef-12.0.3/lib/chef/workstation_config_loader.rb:46: warning: instance variable @chef_config_dir not initialized

  1) Failure:
TestGreenAndSecureModule#test_002_it_locates_a_knife_config [/Users/bitm/Code/knife-block/test/unit/knifeblock_test.rb:38]:
FAIL: knife.rb not found!.
Expected /.*\/.chef\/knife\.rb/ to match "/Users/bitm/knife.rb".

I'm not completely sure if the test or this needs fixing. I'm new to ruby. I will look into this more when I have time.

I pulled this and made local package with chef gem build knife-block.gemspec and chef gem install knife-block-0.1.1.gem and this worked with chefdk 0.4.0

I pulled this and installed it under chefdk 0.4.0 on OSX. It runs, but knife block list shows no configs, even though I have several that worked just fine under older chefdk versions. Knife block use is unable to switch to them either.

It looks like ::Chef::Knife.chef_config_dir returns the user's home directory. If you concatenate '/.chef' to the end, it appears to work.

I corrected the test to run properly, everything should be in place now.

+1 for this

+1 for this

@paulpeterson now that I've updated the Travis config to include a chefdk + 2.1 build, can you rebase your PR and update it? Your changes passed for me (except on 2.2, which is a known issue that's fixed in another PR i'll merge soon)

Reading through the current master code and Chef 12 code I think we should consider the following update of master instead:
diff --git a/lib/chef/knife/block.rb b/lib/chef/knife/block.rb
index 554d220..944a205 100644
--- a/lib/chef/knife/block.rb
+++ b/lib/chef/knife/block.rb
@@ -11,13 +11,17 @@
class Chef
class Knife
def get_config_file

 case

   when GreenAndSecure.current_chef_version >= ::Gem::Version.new('12.0.0')

     config[:config_file] ||= ::Chef::Knife.config_loader.config_location
 # locate_config_file is only compatible with Chef 11

 if GreenAndSecure.current_chef_version >= ::Gem::Version.new('11.8.0')

   config[:config_file] ||= ::Chef::Knife.locate_config_file

 elsif GreenAndSecure.current_chef_version >= ::Gem::Version.new('11.0.0')

   locate_config_file

 else

   GreenAndSecure.locate_config_file config

   when ((GreenAndSecure.current_chef_version < ::Gem::Version.new('12.0.0')) && \

         (GreenAndSecure.current_chef_version >= ::Gem::Version.new('11.8.0')))

     config[:config_file] ||= ::Chef::Knife.locate_config_file

   when GreenAndSecure.current_chef_version >= ::Gem::Version.new('11.0.0')

     locate_config_file

   else

     GreenAndSecure.locate_config_file config
 end

 # if we haven't created our knife.rb yet, set defaults to ~/.chef so we can create the config.

Reading through the master branch code and Chef 12 code it seems we should consider the following update to master instead.  The tests pass as is on 2.1 certainly.
diff --git a/lib/chef/knife/block.rb b/lib/chef/knife/block.rb
index 554d220..944a205 100644
--- a/lib/chef/knife/block.rb
+++ b/lib/chef/knife/block.rb
@@ -11,13 +11,17 @@
 class Chef
   class Knife
     def get_config_file
+      case
+        when GreenAndSecure.current_chef_version >= ::Gem::Version.new('12.0.0')
+          config[:config_file] ||= ::Chef::Knife.config_loader.config_location
       # locate_config_file is only compatible with Chef 11
-      if GreenAndSecure.current_chef_version >= ::Gem::Version.new('11.8.0')
-        config[:config_file] ||= ::Chef::Knife.locate_config_file
-      elsif GreenAndSecure.current_chef_version >= ::Gem::Version.new('11.0.0')
-        locate_config_file
-      else
-        GreenAndSecure.locate_config_file config
+        when ((GreenAndSecure.current_chef_version < ::Gem::Version.new('12.0.0')) && \
+              (GreenAndSecure.current_chef_version >= ::Gem::Version.new('11.8.0')))
+          config[:config_file] ||= ::Chef::Knife.locate_config_file
+        when GreenAndSecure.current_chef_version >= ::Gem::Version.new('11.0.0')
+          locate_config_file
+        else
+          GreenAndSecure.locate_config_file config
       end

       # if we haven't created our knife.rb yet, set defaults to ~/.chef so we can create the config.

+1 on @justin-kirk-active's suggestion, looks to be working in chefdk 0.4.0 with chef client 12.0.3 on OSX.

I grabbed your changed and rebased them on top of some CI improvements I made, so this got merged with https://github.com/knife-block/knife-block/pull/37.


[hrmaccevents] (v0.03) crashes when calling Puck.connect

Affected hardware version
Bangle 2
Your firmware version
2v19
The bug
When clicking on the "Start" button in the app home page in the browser, nothing happens. Opening the JS console gives me the following:
Uncaught TypeError: Puck.connect is not a function
    at connect (custom.html:253:8)

I can see that the issue only appears on the official "app store", because in the source code, updated 5 days ago, the issue should have been solved!
Also notice that the version on the "app store" is 0.03, which is the same as on github, even though the source code is definitely different.
Expected behavior
The watch should start streaming data to the web application.
Steps to reproduce
Just open the hrmaccevents web application and click on Start.
Installed apps
No response

This has been fixed already in the development app loader, and should go live next time I update the main website.
There were some decent size changes so I didn't want to just put it live straight away until it had been tested for a while


docs: added mathjax for rendering tex format as imgmath needs latex engine to run

Before submitting

[x] Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
[ ] Did you make sure to update the docs?
[ ] Did you write any new necessary tests?

What does this PR do?
Adding support to render latex math formulas, changing from imgmath to mathjax as imgmath requires latex engine to run.
related to https://github.com/Lightning-AI/pytorch-lightning/issues/19633
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

@Borda Just a quick question:
I'm trying to build docs from this repository, but tutorials seem to fail on the main branch, when I try from the pytorch-lightning repository where this is added as a submodule the changes seem to work there, does it mean that if we update the submodule? I can see that the submodule branch is publication https://github.com/Lightning-AI/pytorch-lightning/blob/fadd2fccdc49e20d64db37fe3654116b4f1b9e49/.gitmodules#L4 updating the submodule will make tutorials render properly regarding math formulas.
Does this mean that the PR has to be merged to the publication branch?

Just an update built docs from the publication branch and it seems that it is the one we have to update. With your approval we will now close this PR and look at this one #317 on publication branch

yes when you clone this repo recursively you shall get the right branch

https://github.com/Lightning-AI/pytorch-lightning/blob/fadd2fccdc49e20d64db37fe3654116b4f1b9e49/.gitmodules#L4
I did the same and got the

Then I think these changes have to be made on the publication branch as the git submodule is pointing to that branch from the PyTorch-lightning repo.


Almost Complete rewrite

This is essentially a complete rewrite of all aspects of the code to move the configuration of which buttons control what from being embedded in the logic to being in separate config files. Feel free to disregard, while I think I have preserved all aspects of the original functionality, I've not done an A/B on every possible control and mode combination. I have unit tested every control for each of the config files.

Thanks for this contribution. I just came back from a vacation and will look at this in the next days. But as this is basically a complete rewrite, I'm not sure I want to merge it into this repository. I will try it and see if I feel comfortable supporting your code and decide then. I will keep you posted.

I figured there was a good chance you wouldn’t want to merge it in but thought you would be interested either way. I hope the vacation was a good one. If you decide not to merge I’ll add to the copyright that this is a fork but other wise keep attribute as shown in the pull request.

On Sep 14, 2021, at 10:33 AM, peterdikant @.***> wrote:
Thanks for this contribution. I just came back from a vacation and will look at this in the next days. But as this is basically a complete rewrite, I'm not sure I want to merge it into this repository. I will try it and see if I feel comfortable supporting your code and decide then. I will keep you posted.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub https://github.com/peterdikant/xair-remote/pull/8#issuecomment-919210065, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATMRD7JJQ6E22JLJ55IGJRLUB5MJ3ANCNFSM5DPDRHDQ.
Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Impressive changes. This is really a full rewrite. Good work. I will not merge your changes because I don't feel comfortable being responsible for a project where most of the code is not mine. So please publish it under your own account and I will link to your project from the README file. So anyone who needs a fully configurable solution will be redirected to you.


Orbital Camera

[x] Find example of orbital camera in Three.js
[x] Implement
[ ] Define min-zoom / max-zoom

We may have to redo some of this after the Angular conversion, depends on the code after the conversion is complete, will check on Tuesday.

Done.


Does RMap is aware of cluster restart

I have spring app works and running with RMap create from RedissonClient.getMap cached.
Once something happens with few redis nodes  (we had a forced restart) that cached map does not work anymore.
What is the recommended approach in that case? Call redissonClient.getMap each time?  As i saw under the hood new RedissonMap is created so could be time and resource consuming. So please advice. Thank you.

Now i know much more. I've turned on debug logs and see that redisson keeps trying to reconnect(scaled down redis cluster to 0 and scaled up).  Unfortunately it keeps trying to reconnect to IP that is not active anymore. After reboot the IP has changed.. but looks that somehow it is cached and not able to connect to newly started redis nodes.  If keeps trying forever with no luck.
Is there any caching mechanism?
`2024-04-26 11:03:16.519 CEST Connection created [addr=redis://locking-redis-node-0.locking-redis-headless.default.svc.cluster.local:26379]
2024-04-26 11:03:16.618 CEST reconnecting RedisPubSubConnection@395557197 [redisClient=[addr=redis://<IP_ADDRESS>:6379], channel=[id: 0x3d2eea36, L:/<IP_ADDRESS>:52138 ! R:<IP_ADDRESS>/<IP_ADDRESS>:6379], currentCommand=null, usage=0] to <IP_ADDRESS>/<IP_ADDRESS>:6379
2024-04-26 11:03:16.618 CEST Connection created [addr=redis://<IP_ADDRESS>:6379]
2024-04-26 11:03:17.818 CEST connection released for command (INFO REPLICATION) and params [] from slot NodeSource [slot=0, addr=null, redisClient=null, redirect=null, entry=null] using connection RedisConnection@1350729690 [redisClient=[addr=redis://<IP_ADDRESS>:6379], channel=[id: 0xc72cb405, L:/<IP_ADDRESS>:52132 ! R:<IP_ADDRESS>/<IP_ADDRESS>:6379], currentCommand=null, usage=0]
2024-04-26 11:03:17.818 CEST attempt 3 for command (INFO REPLICATION) and params [] to NodeSource [slot=0, addr=null, redisClient=null, redirect=null, entry=null]
`

Which Redisson version?

redisson 3.26.1
Configuration we have:
"SPRING_DATA_REDIS_PASSWORD": "123",
  "SPRING_DATA_REDIS_SENTINEL_MASTER": "mymaster",
  "SPRING_DATA_REDIS_SENTINEL_NODES": "locking-redis-headless.default.svc.cluster.local:26379",

on redis 17.13.2 · bitnami/bitnami

Can you share Redisson config?
Can you set trace logging level for org.redisson package and share the output?

redisson configuration is injected via redisson-spring-boot-starter
spring:
data:
redis:
password: mypass
sentinel:
master: mymaster
nodes: locking-redis-headless.default.svc.cluster.local:26379

Explore-logs-2024-04-26 20_28_22.txt

I found one exception related with DNS netty and found the issue solved by netty team that is related with caching DNS
https://github.com/netty/netty/issues/11885 which is fixed in 4.1.109 while the latest 3.29.0 redisson uses 4.1.104 under the hood/.
one more exception i'm facing on daily basis...
ERROR 2024-04-28T02:10:10.190425043Z Can't execute SENTINEL commands on <IP_ADDRESS>/<IP_ADDRESS>:26379 java.util.concurrent.CompletionException: org.redisson.client.RedisTimeoutException: Command execution timeout for command: (SENTINEL GET-MASTER-ADDR-BY-NAME), params: [mymaster], Redis client: [addr=redis://xx:26379] at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(Unknown Source) at java.base/java.util.concurrent.CompletableFuture.completeThrowable(Unknown Source) at java.base/java.util.concurrent.CompletableFuture$UniCompose.tryFire(Unknown Source) at java.base/java.util.concurrent.CompletableFuture.postComplete(Unknown Source) at java.base/java.util.concurrent.CompletableFuture.completeExceptionally(Unknown Source) at org.redisson.client.RedisConnection.lambda$async$0(RedisConnection.java:254) at io.netty.util.HashedWheelTimer$HashedWheelTimeout.run(HashedWheelTimer.java:715) at io.netty.util.concurrent.ImmediateExecutor.execute(ImmediateExecutor.java:34) at io.netty.util.HashedWheelTimer$HashedWheelTimeout.expire(HashedWheelTimer.java:703) at io.netty.util.HashedWheelTimer$HashedWheelBucket.expireTimeouts(HashedWheelTimer.java:790) at io.netty.util.HashedWheelTimer$Worker.run(HashedWheelTimer.java:503) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.base/java.lang.Thread.run(Unknown Source) Caused by: org.redisson.client.RedisTimeoutException: Command execution timeout for command: (SENTINEL GET-MASTER-ADDR-BY-NAME), params: [mymaster], Redis client: [addr=redis://xx:26379] at org.redisson.client.RedisConnection.lambda$async$0(RedisConnection.java:253) ... 7 common frames omitted
and
org.redisson.client.RedisTimeoutException: Command execution timeout for command: (AUTH), params: (password masked), Redis client: [addr=redis://locking-redis-node-2.locking-redis-headless.default.svc.cluster.local:26379] java.util.concurrent.CompletionException: org.redisson.client.RedisTimeoutException: Command execution timeout for command: (AUTH), params: (password masked), Redis client: [addr=redis://locking-redis-node-2.locking-redis-headless.default.svc.cluster.local:26379] 	at java.base/java.util.concurrent.CompletableFuture.encodeRelay(Unknown Source) 	at java.base/java.util.concurrent.CompletableFuture.completeRelay(Unknown Source) 	at java.base/java.util.concurrent.CompletableFuture$UniRelay.tryFire(Unknown Source) 	at java.base/java.util.concurrent.CompletableFuture.postComplete(Unknown Source) 	at java.base/java.util.concurrent.CompletableFuture.completeExceptionally(Unknown Source) 	at org.redisson.client.RedisConnection.lambda$async$0(RedisConnection.java:254) 	at io.netty.util.HashedWheelTimer$HashedWheelTimeout.run(HashedWheelTimer.java:715) 	at io.netty.util.concurrent.ImmediateExecutor.execute(ImmediateExecutor.java:34) 	at io.netty.util.HashedWheelTimer$HashedWheelTimeout.expire(HashedWheelTimer.java:703) 	at io.netty.util.HashedWheelTimer$HashedWheelBucket.expireTimeouts(HashedWheelTimer.java:790) 	at io.netty.util.HashedWheelTimer$Worker.run(HashedWheelTimer.java:503) 	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) 	at java.base/java.lang.Thread.run(Unknown Source) Caused by: org.redisson.client.RedisTimeoutException: Command execution timeout for command: (AUTH), params: (password masked), Redis client: [addr=redis://locking-redis-node-2.locking-redis-headless.default.svc.cluster.local:26379] 	at org.redisson.client.RedisConnection.lambda$async$0(RedisConnection.java:253) 	... 7 common frames omitted

while the latest 3.29.0 redisson uses 4.1.104 under the hood

It uses 4.1.109 https://repo1.maven.org/maven2/org/redisson/redisson-parent/3.29.0/redisson-parent-3.29.0.pom
For timeouts you need to read this https://github.com/redisson/redisson/wiki/16.-FAQ#q-what-is-the-cause-of-redistimeoutexception

Hi @mrniko
Thank you for your advice. We went trough whole network but have not found any problem.
I went trough several tests and had a discovery right now and confirmed that for sure it is not our network problem.
I did a scheduled test in single thread checking each 5 minutes via InetAddress resolving all my hosts. Each time we were getting right IP , even after restarting all slaves i got the right IP address (at the same time redisson were not able to reconnect).
Based on that I came up with the idea that something has changed on redisson recently and i've tried downgrade to 3.26.0 - and buuum. It started working again as it should.
So basically on version 3.29.0 we have same issue on all our applications that is unable to reconnect trying constantly to make a connection. Isn't that existing connections on the pool are reused to "reconnect" them instead of creating new ones?
Below logs are visible after each time when i did slaves restart only on 3.26.0.. not on 3.29.0..
Now, after reconnect i may see in logs (on 3.26.0):
1 connections initialized for <IP_ADDRESS>/<IP_ADDRESS>:6379
master <IP_ADDRESS>/<IP_ADDRESS>:6379 used as slave
24 connections initialized for <IP_ADDRESS>/<IP_ADDRESS>:6379
sentinel: redis://<IP_ADDRESS>:26379 is down
sentinel: redis://<IP_ADDRESS>:26379 added
1 connections initialized for locking-redis-node-1.locking-redis-headless.default.svc.cluster.local/<IP_ADDRESS>:6379
slave: locking-redis-node-1.locking-redis-headless.default.svc.cluster.local/<IP_ADDRESS>:6379 added
24 connections initialized for locking-redis-node-1.locking-redis-headless.default.svc.cluster.local/<IP_ADDRESS>:6379

What i've spotted (on 3.26.0) that log "connections initialized for"  is printed in logs each time when we restart nodes. So reconnect

Fixed in https://github.com/redisson/redisson/commit/4bf4cb13e3c96cabcc63b4bdbaebbd1d45466189

Can you try 3.27.0 version?

But if i'm not mistaken we already had some tests with 3.27.0 version. Anyway, it's bean a while since i did it so let me bump it up and verify results.
Btw I saw one fix for similar issue  we have here -> https://github.com/redisson/redisson/issues/5857 made by you @mrniko. Isn't  already released with 3.32.0?

@lukasz-weareuncapped

Btw I saw one fix for similar issue we have here -> https://github.com/redisson/redisson/issues/5857 made by you @mrniko. Isn't already released with 3.32.0?

Yes


Ant way of converting the patch offline?

Since the website Is down, i would like to ask if there is a way to do the process of convertion offline?

https://github.com/enzienaudio/hvcc

I'm experiencing crashes while pressing play with play "on awake" turned on.
I'm using unity on MacBook pro-2017.
I've seen another issue #175 where the problem was a "loop" in the patch but I actually have no loop in mine.
So what could it be related with? It's a bug experienced only by osx users or also with windows?


Leaderboard 2.0: Missing results

Some pretty essential results seem to be missing from the new leaderboard.
Here's a list of things that we should probably fix before releasing the leaderboard:
MTEB(Multilingual)
I have only looked into models we promised to run in the review response, the problems might be more widespread

[ ] openai/text-embedding-3-large

[ ] SprintDuplicateQuestions

[ ] openai/text-embedding-3-small

[ ] OpusparcusPC
[ ] SprintDuplicateQuestions

[ ] gte-Qwen2-7B-instruct

[ ] Core17InstructionRetrieval
[ ] HagridRetrieval
[ ] MIRACLRetrievalHardNegatives
[ ] News21InstructionRetrieval
[ ] Robust04InstructionRetrieval
[ ] WebLINXCandidatesReranking

[x] BAAI/bge-large-en-v1.5
[ ] gritlm-8x7B

[ ] Core17InstructionRetrieval
[ ]  HagridRetrieval
[ ] MIRACLRetrievalHardNegatives
[ ] Robust04InstructionRetrieval
[ ] WebLINXCandidatesReranking

[ ] salesforce/SFR-Embeddings-2R

[ ] Robust04InstructionRetrieval
[ ] News21InstructionRetrieval
[ ] Core17InstructionRetrieval

[ ] snowflake/arctic-embed-m-v1.5:

missing almost all tasks: This is a problem with all snowflake models

[ ] WhereIsAI/UAE-Large-V1:

missing almost all tasks

[ ] stella_en_1.5B_v5:

[ ] Core17InstructionRetrieval
[ ] News21InstructionRetrieval
[ ] Robust04InstructionRetrieval

[ ] stella_en_400M_v5

[ ] Core17InstructionRetrieval
[ ] News21InstructionRetrieval
[ ] Robust04InstructionRetrieval

[ ] intfloat/e5-base-v2

[ ] Core17InstructionRetrieval
[ ] News21InstructionRetrieval
[ ] Robust04InstructionRetrieval

[ ] intfloat/e5-large-v2

[ ] Core17InstructionRetrieval

[ ] intfloat/e5-small-v2

[ ] Core17InstructionRetrieval
[ ] News21InstructionRetrieval
[ ] Robust04InstructionRetrieval

[x] jina/jina-embeddings-v3
[ ] mixedbread-ai/mxbai-embed-v1

[ ] BrazilianToxicTweetsClassification
[ ] CEDRClassification
[ ] Core17InstructionRetrieval
[ ] KorHateSpeechMLClassification
[ ] MalteseNewsClassification
[ ] MultiEURLEXMultilabelClassification
[ ] News21InstructionRetrieval
[ ] Robust04InstructionRetrieval

[ ] nomic-ai/nomic-embed-text-v1.5

[ ]  BUCC.v2
[ ] BibleNLPBitextMining
[ ] BornholmBitextMining
[ ] BrazilianToxicTweetsClassification
[ ] CEDRClassification
[ ] Core17InstructionRetrieval
[ ] DiaBlaBitextMining
[ ] FloresBitextMining
[ ] IN22GenBitextMining
[ ] IndicGenBenchFloresBitextMining
[ ] KorHateSpeechMLClassification
[ ] MalteseNewsClassification
[ ] MultiEURLEXMultilabelClassification
[ ] NTREXBitextMining
[ ] News21InstructionRetrieval
[ ] NollySentiBitextMining
[ ] NorwegianCourtsBitextMining
[ ] NusaTranslationBitextMining
[ ] NusaXBitextMining
[ ] Robust04InstructionRetrieval
[ ] Tatoeba

[ ] NV-embed-v2 missing metadata #1436

MTEB(eng, classic)
Problematic tasks:

[ ] CQADupstackProgrammersRetrieval (almost all models have nans)

Problematic models:

[ ] openai/text-embedding-3-large:

[ ] SprintDuplicateQuestions
[ ] SummEval

[ ] openai/text-embedding-3-small:

[ ] SprintDuplicateQuestions
[ ] SummEval

[ ] e5-mistral-7b-instruct:

[ ] STS22

[ ] multilingual-e5-large-instruct:
- [ ] ArxivClusteringP2P
- [ ] BiorxivClusteringP2P
- [ ] BiorxivClusteringS2S
- [ ] DBPedia
- [ ] HotpotQA
- [ ] MedrxivClusteringP2P
- [ ] MedrxivClusteringS2S
[ ] snowflake/arctic-embed-m-v1.5:

[ ] AmazonCounterfactualClassification
[ ] ArguAna
[ ] MassiveIntentClassification
[ ] NFCorpus
[ ] SCIDOCS
[ ] SICK-R
[ ] STS12
[ ] STS13
[ ] STS14
[ ] STS15
[ ] STS16
[ ] STS17
[ ] SciFact
[ ] SprintDuplicateQuestions
[ ] TRECCOVID
[ ] ToxicConversationsClassification

There are also some problematic tasks in MTEB(deu) and MTEB(fra), I will look into those too

MTEB(fra)
Quite a few individual results are missing for a lot of models, maybe something wrong with the scraping or data loading.
Problematic tasks:

[ ] MLSUMClusteringP2P almost all models missing

MTEB(deu)
Problematic tasks:

[ ] TenKGnadClusteringP2P **almost all models missing **

In both benchmarks we're missing some tasks from 7B models.

MTEB(eng, beta)
Problematic tasks:

[ ] HotpotQAHardNegatives majority of models missing
[ ] MedrxivClusteringS2S.v2 most notably: stella, gte, SFR, GritLM8x7b, bge, UAE
[ ] StackExchangeClusteringP2P.v2 almost all missing
[ ] SummEvalSummarization.v2 almost all missing
[ ] TwentyNewsgroupsClustering.v2 almost all missing

@Samoed @Muennighoff @KennethEnevoldsen I would really appreciate your help investigating and fixing these issues

we might also include this in the list: https://github.com/embeddings-benchmark/results/pull/65#pullrequestreview-2488334579

As a side note, we would like to run these models [list in issue] on the remaining tasks in the MTEB(Medical) benchmark. However, we initially held off due to API cost constraints. Do you have access to credits with these providers that we could use for this purpose? Alternatively, would it be possible for you to run them on your side?

(won't have too much time to look into this as I am at the neurips conference, but I will take a closer look once I get back)

Well, I have made a list of

Well, I have compiled a list of all task results that are missing for all benchmarks in the new leaderboard + all models that already show up in the leaderboard (have metadata and don't miss all results on a benchmark).
The list is very long, but luckily the most important models usually only miss one or two things. There also seem to be patterns, I'm wondering if it's got something to do with our versioning scheme for tasks.
I used the following script to get the missing results:
import json
from pathlib import Path

import pandas as pd
from tqdm import tqdm

import mteb
from mteb.leaderboard.table import scores_to_tables

benchmarks = mteb.get_benchmarks()

all_results = mteb.load_results()

results = {
    benchmark.name: benchmark.load_results(base_results=all_results)
    .join_revisions()
    .filter_models()
    for benchmark in tqdm(benchmarks, desc="Loading all benchmark results")
}

def to_pandas(gr_df) -> pd.DataFrame:
    cols = gr_df.value["headers"]
    data = gr_df.value["data"]
    return pd.DataFrame(data, columns=cols)

all_task_tables = {
    name: to_pandas(scores_to_tables(res.get_scores(format="long"))[1]).set_index(
        "Model"
    )
    for (name, res) in results.items()
}

missing_results = {}
for bench_name, table in all_task_tables.items():
    missing_results[bench_name] = {}
    for model_name, model_res in table.iterrows():
        nas = model_res.loc[model_res.isna()].index.to_list()
        if nas:
            missing_results[bench_name][model_name] = nas

And got this file:
missing_results.json
In the following format:
{
    "<benchmark_name>": {"<model_name>": ["task_name1", "task_name2", ...]}
}

We'll probably have to prioritize some models over others

(see https://github.com/embeddings-benchmark/results/pull/80)

Sorry for the delay, somehow missed the message. Running all from your original message (https://github.com/embeddings-benchmark/mteb/issues/1571#issuecomment-2545135511) now. Looks like it is ~30K which should be fine. Will open a PR on the results repo once done.

Opened a PR here: https://github.com/embeddings-benchmark/results/pull/83 - Still pushing some results
hope we're not breaking github 😅

I'm opening issues for all models/tasks that are failing and filtering them out in the meantime with the below addon to your script
missing_results = {k: {k2: v2 for k2, v2 in v.items() if not (any(x in k2 for x in ["bm25s", "LLM2Vec", "jasper", "bge-m3"]) or any(x in v2 for x in ["MIRACLReranking", "MIRACLRetrieval", "RuBQReranking", "STS22"]))} for k, v in missing_results.items()}
with open(file_path, "w") as json_file:
    json.dump(missing_results, json_file, indent=4)


Update changelog

wtf. I ran tests locally and everything was working...

    git mode old hash
      1) is able to clone correctly using git mode with old hash
      2) is able to clone subdir correctly using git mode with old hash
    git mode
      - is able to clone correctly using git mode

  28 passing (13s)
  1 pending
  2 failing

  1) degit
       git mode old hash
         is able to clone correctly using git mode with old hash:
     Error: Command failed: node /home/runner/work/tiged/tiged/src/bin.js --mode=git https://github.com/tiged/tiged-test.git#b09755bc4cca3d3b398fbe5e411daeae79869581 .tmp/test-repo
! Command failed: cd .tmp/test-repo; git init; git remote add origin git@github.com:tiged/tiged-test; git fetch --depth 1 origin b09755bc4cca3d3b398fbe5e411daeae79869581; git checkout FETCH_HEAD
hint: Using 'master' as the name for the initial branch. This default branch name
hint: is subject to change. To configure the initial branch name to use in all
hint: of your new repositories, which will suppress this warning, call:
hint:
hint: 	git config --global init.defaultBranch <name>
hint:
hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
hint: 'development'. The just-created branch can be renamed via this command:
hint:
hint: 	git branch -m <name>
Warning: Permanently added the ECDSA host key for IP address '<IP_ADDRESS>' to the list of known hosts.
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
error: pathspec 'FETCH_HEAD' did not match any file(s) known to git

      at ChildProcess.exithandler (child_process.js:383:12)
      at maybeClose (internal/child_process.js:1088:16)
      at Process.ChildProcess._handle.onexit (internal/child_process.js:296:5)

  2) degit
       git mode old hash
         is able to clone subdir correctly using git mode with old hash:
     Error: Command failed: node /home/runner/work/tiged/tiged/src/bin.js --mode=git https://github.com/tiged/tiged-test.git/subdir#b09755bc4cca3d3b398fbe5e411daeae79869581 .tmp/test-repo
! Command failed: cd .tmp/test-repo/.tiged; git init; git remote add origin git@github.com:tiged/tiged-test; git fetch --depth 1 origin b09755bc4cca3d3b398fbe5e411daeae79869581; git checkout FETCH_HEAD
hint: Using 'master' as the name for the initial branch. This default branch name
hint: is subject to change. To configure the initial branch name to use in all
hint: of your new repositories, which will suppress this warning, call:
hint:
hint: 	git config --global init.defaultBranch <name>
hint:
hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
hint: 'development'. The just-created branch can be renamed via this command:
hint:
hint: 	git branch -m <name>
<EMAIL_ADDRESS>Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
error: pathspec 'FETCH_HEAD' did not match any file(s) known to git

      at ChildProcess.exithandler (child_process.js:383:12)
      at maybeClose (internal/child_process.js:1088:16)
      at Process.ChildProcess._handle.onexit (internal/child_process.js:296:5)

npm ERR! Test failed.  See above for more details.
Error: Process completed with exit code 1.

My biggest concern is that I just published this already because I manually tested this, I ran automated tests locally.

Right so. It appears that using tiged with gitmode with https is broken. But ssh works.
I think it was the other way around previously.
I only tested ssh mode with private repo and specific branch. It worked beatifully.
I wonder can we make this work with https as well...

Probably gonna keep this version published and try to do a quick fix for https for the next version. Sorry for the inconvenience... Hopefully nobody uses git mode with https...

    ~/projects/51-https-git-mode    main !2  node bin.js --mode=git https://github.com/tiged/tiged-test.git\#b09755bc4cca3d3b398fbe5e411daeae79869581 .tmp/test-repo
this.repo: {"site":"github","user":"tiged","name":"tiged-test","ref":"b09755bc4cca3d3b398fbe5e411daeae79869581","url":"https://github.com/tiged/tiged-test","ssh":"git@github.com:tiged/tiged-test","mode":"tar"}
> cloned tiged/tiged-test#b09755bc4cca3d3b398fbe5e411daeae79869581 to .tmp/test-repo
    ~/projects/51-https-git-mode    main !2 

lol. based on this.repo how am I supposed to know if this is meant to be ssh or https mode...
Do I need to add an argument option for this?
Like degit --mode=git --connection-type=https https://github.com/tiged/tiged-test.git\#b09755bc4cca3d3b398fbe5e411daeae79869581 .tmp/test-repo
Seems completely unnecessary to do it this way?
Maybe change the way the parser works. When it parses the url/ssh string to this.repo.ssh this.repo.url, maybe I should add something like this.repo.connectionType = https, or ssh.
That way user does not need to add an argument. This seems favorable.
The only way this doesn't work is, if somebody uses it like degit --mode=git tiged/tiged.
There is no way to extrapolate does the user mean https or ssh. And what should we defautl to?

I can return src var in the parse function within the returned object.
   ~/projects/51-https-git-mode    main !2  node bin.js --mode=git https://github.com/tiged/tiged-test.git\#b09755bc4cca3d3b398fbe5e411daeae79869581 .tmp/test-repo
src: https://github.com/tiged/tiged-test.git#b09755bc4cca3d3b398fbe5e411daeae79869581
this.repo: {"site":"github","user":"tiged","name":"tiged-test","ref":"b09755bc4cca3d3b398fbe5e411daeae79869581","url":"https://github.com/tiged/tiged-test","ssh":"git@github.com:tiged/tiged-test","mode":"tar","src":"https://github.com/tiged/tiged-test.git#b09755bc4cca3d3b398fbe5e411daeae79869581"}
> cloned tiged/tiged-test#b09755bc4cca3d3b398fbe5e411daeae79869581 to .tmp/test-repo
    ~/projects/51-https-git-mode    main !2  vim src/index.js                                                                                 ✔  16.14.0 
    ~/projects/51-https-git-mode    main !2 

Maybe we can do something like this within cloneWithGit():
const gitPath = /https:\/\//.test(this.repo.src) ? this.repo.url : this.repo.ssh;

And then use gitPath instead of this.repo.ssh by default.
Nice and simple.

Alright I am quite happy with this research.
I will need to type this clean and test it etc. Will be publishing a new version soonish.
Also I will say that I think the reason that I did not catch this in the local tests is due to the ridiculous way that degit uses caching... I have an issue of it here: https://github.com/tiged/tiged/issues/36
Point is, that the test were running against cache? Maybe, I dunno. That is my current hypothesis anyway. If that is not the reason, then I have no clue why local tests operated differently compared to github actions tests.

Sorry for being slow with this tiny thing. I've now tested this fix locally with https and ssh in git mode. Seems to be working. Will publish soon. Got wife, kid, work and myself to look after. Not making excuses here, just hope y'all understand.

Fixed with this PR: https://github.com/tiged/tiged/pull/52


[DNM] include: posix: time: Make possible to include with CONFIG_ARCH_POSIX

While CONFIG_ARCH_POSIX in general isn't compatible with Zephyr POSIX
subsys (because CONFIG_ARCH_POSIX itself is implemented on top of
POSIX, so there're obvious conflicts), apply workaround to allow to
at least use clock_gettime() and clock_settime() functions.
This change is grounded in upcoming support for date manipulation
commands for Zephyr shell, which are implemented using functions
above. There's no guarantee that CONFIG_ARCH_POSIX and Zephyr POSIX
subsys will coexist for any other usecase. (But the change is
relatively clean and is definitely in the right direction of
prototyping ways of such a coexistance.)
Signed-off-by: Paul Sokolovsky<EMAIL_ADDRESS>

This is intended to be cherry-picked into https://github.com/zephyrproject-rtos/zephyr/pull/22533.

Merged into https://github.com/zephyrproject-rtos/zephyr/pull/22533, closing.


cmd/go: improve error message if remote repo does not support https

What version of Go are you using (go version)?
[k9 libconfig (master)] $ go version
go version devel +bf80e3b564 Sat Aug 18 18:23:06 2018 +0000 linux/amd64

What did you do?
With go1.11, run go build with modules and got unexpected "unknown revision" errors.
First, the go.mod file:
[k9 libops (master)] $ cat go.mod
module code.corp.indeed.com/gophers/libops

require (
	code.corp.indeed.com/gophers/3rdparty v0.0.1
	code.corp.indeed.com/gophers/libconfig v0.0.1
)

replace (
	code.corp.indeed.com/gophers/3rdparty => ../../gophers/3rdparty
	code.corp.indeed.com/gophers/libconfig => ../../gophers/libconfig
)

Now let's try to build it:
[k9 libops (master)] $ go build
go: finding code.corp.indeed.com/gophers/rlog v0.0.1
go: finding code.corp.indeed.com/gophers/libtest v0.0.1
go<EMAIL_ADDRESS>unknown revision v0.0.1
go<EMAIL_ADDRESS>unknown revision v0.0.1
go: error loading module requirements

After lots of digging and head scratching, downloaded Go, modified the source to print more verbose logging in the modfetch package, and found the root cause:
[k9 libops (master)] $ go build
go: finding code.corp.indeed.com/gophers/libtest v0.0.1
seth: stat: rev: v0.0.1
seth: gitrepo remote: https://code.corp.indeed.com/gophers/libtest.git
seth: gitrepo local: false
seth: gitrepo dir: /home/hoenig/Documents/go/pkg/mod/cache/vcs/26c2c72546174752cc7dd33aee0e9fd20922ec3bdd500d96cff072028e4d56c7
seth: gitrepo fetchLevel: 0
seth: gitrepo refs: map[]
seth: gitrepo localTags: map[]
seth: stat: didStatLocal after local hash check: false
go: finding code.corp.indeed.com/gophers/rlog v0.0.1
seth: stat: rev: v0.0.1
seth: gitrepo remote: https://code.corp.indeed.com/gophers/rlog.git
seth: gitrepo local: false
seth: gitrepo dir: /home/hoenig/Documents/go/pkg/mod/cache/vcs/8a62f5a595067cf184b8895a656492a5c7cd608500e537286869c3267fa57765
seth: gitrepo fetchLevel: 0
seth: gitrepo refs: map[]
seth: gitrepo localTags: map[]
seth: stat: didStatLocal after local hash check: false
seth: stat: loadLocalTags did not find local, r.localTags: map[]
seth: stat: now checking if name of tag or branch on remote server
seth: load-refs: entering
seth: stat: loadLocalTags did not find local, r.localTags: map[]
seth: stat: now checking if name of tag or branch on remote server
seth: load-refs: entering
seth: loadRefs: git ls-remote failed:  https://code.corp.indeed.com/gophers/rlog.git git ls-remote -q https://code.corp.indeed.com/gophers/rlog.git in /home/hoenig/Documents/go/pkg/mod/cache/vcs/8a62f5a595067cf184b8895a656492a5c7cd608500e537286869c3267fa57765: exit status 128:
	fatal: could not read Username for 'https://code.corp.indeed.com': terminal prompts disabled
seth: just did loadRefs
seth: gitrepo remote: https://code.corp.indeed.com/gophers/rlog.git
seth: gitrepo local: false
seth: gitrepo dir: /home/hoenig/Documents/go/pkg/mod/cache/vcs/8a62f5a595067cf184b8895a656492a5c7cd608500e537286869c3267fa57765
seth: gitrepo fetchLevel: 0
seth: gitrepo refs: map[]
seth: gitrepo localTags: map[]
seth: now entering big if-else tree, refs: map[]
seth: exiting stat without finding rev: v0.0.1
go<EMAIL_ADDRESS>unknown revision v0.0.1
seth: loadRefs: git ls-remote failed:  https://code.corp.indeed.com/gophers/libtest.git git ls-remote -q https://code.corp.indeed.com/gophers/libtest.git in /home/hoenig/Documents/go/pkg/mod/cache/vcs/26c2c72546174752cc7dd33aee0e9fd20922ec3bdd500d96cff072028e4d56c7: exit status 128:
	fatal: could not read Username for 'https://code.corp.indeed.com': terminal prompts disabled
seth: just did loadRefs
seth: gitrepo remote: https://code.corp.indeed.com/gophers/libtest.git
seth: gitrepo local: false
seth: gitrepo dir: /home/hoenig/Documents/go/pkg/mod/cache/vcs/26c2c72546174752cc7dd33aee0e9fd20922ec3bdd500d96cff072028e4d56c7
seth: gitrepo fetchLevel: 0
seth: gitrepo refs: map[]
seth: gitrepo localTags: map[]
seth: now entering big if-else tree, refs: map[]
seth: exiting stat without finding rev: v0.0.1
go<EMAIL_ADDRESS>unknown revision v0.0.1
go: error loading module requirements

Note that it is incorrect to assume the remote will support https. At least some enterprise internal git hosting infrastructures are locked down to support ssh only. This was a common complaint about the dep tool as well.
Also note this was impossible to diagnose without hacking on the Go source code. We probably shouldn't suppress that error message.

I think this was always the behavior - https://tip.golang.org/doc/faq#git_https.
Could you try the workaround suggested there and see if it works for you ?

The
[url<EMAIL_ADDRESS>	insteadOf = https://github.com/

workaround does work. The error message may want to point to that documentation.

/cc @bcmills @rsc

Duplicate of #26134

@rasky  @bcmills  @rsc  Can this be re-opened? While native support for non-https repos is one thing, this generic error message is totally useless and is showing up in additional contexts, hiding critical debugging information.)
For example here is a problem with Goland vs. the Go command (probably environment related, but other than "unknown revision", there's no useful information.

Reopening.

There are a bunch of interrelated issues with private repos; I'm planning to revisit that whole cluster for 1.13.

I add config in ~/.gitconfig
[url "ssh://gitlab@gitlab.domain.com:"]
	insteadOf = https://gitlab.domain.com/

but it not working. I try with go get -v gitlab.domain.com/xxx/xxx.git, i got errors:
Please make sure you have the correct access rights
and the repository exists.
# cd .; git ls-remote ssh://gitlab.domain.com/opgo/golib

i try at terminal git ls-remote<EMAIL_ADDRESS>it works.
it show that the failed reason is less “gitlab@”
how can i fix it?
i had try other config in ~/.gitconfig, but all failed
[url "gitlab@gitlab.domain.com:"]
	insteadOf = https://gitlab.domain.com/

[url "git@gitlab.domain.com:"]
	insteadOf = https://gitlab.domain.com/

@yanyandenuonuo, your configuration issue does not seem to be related to the topic of this issue (which is the quality of error messages produced by the go command).
See https://github.com/golang/go/wiki/Questions for more appropriate venues.

@shoenig, we improved a lot of error messages for Go 1.13. Could you try out go1.13beta1 and let us know if the situation has improved for your configuration?

Actually, what VCS path is the server returning in the <meta> tags for https://code.corp.indeed.com/gophers/rlog?go-get=1? If the VCS only supports ssh, then the server should be returning something like:
<meta name="go-import" content="code.corp.indeed.com/gophers/rlog git ssh://code.corp.indeed.com/gophers/rlog.git">

If your server is telling the go command to use https://, then I can't really fault the go command for trying https://, and I also can't really fault it for printing whatever error message git reports when attempting to read from that URL.
(If you want better error messages from the git binary itself, probably you should raise an issue with the git maintainers...)


[ConstraintSystem] Extend solver support for designated types for ope…

…rators.
Have the constraint solver consider multiple designated types for an
operator. We currently consider the overloads from each in turn,
stopping as soon as we have a solution. As a result, we can still end
up with exponential type checking in some cases if an operator has
more than a single designated type. This still allows us to reduce the
base of that exponent, though, which makes it possible to increase the
number of expressions we can type check successfully in practice.

@swift-ci Please smoke test


array_replace_recursive(): Argument #2 must be of type array, int given

  TypeError

  array_replace_recursive(): Argument #2 must be of type array, int given

  at vendor\laravel\framework\src\Illuminate\Translation\FileLoader.php:129
    125▕     {
    126▕         return collect($paths)
    127▕             ->reduce(function ($output, $path) use ($locale, $group) {
    128▕                 if ($this->files->exists($full = "{$path}/{$locale}/{$group}.php")) {
  ➜ 129▕                     $output = array_replace_recursive($output, $this->files->getRequire($full));
    130▕                 }
    131▕
    132▕                 return $output;
    133▕             }, []);

  1   vendor\laravel\framework\src\Illuminate\Translation\FileLoader.php:129

  2   vendor\laravel\framework\src\Illuminate\Collections\Traits\EnumeratesValues.php:791

When scannable locale does have a file but it's empty (not an array). If you are busy, I'll make pull request whenever I have time.

@kropcik Thank you for opening this issue. I will look into this and try to fix it as soon as possible.

@kropcik, could you check if the fix proposed in #4 works for you?


Make sure the resource created for the Public IP match the name repai…

Make sure the resource created for the Public IP match the name repair-_PublicIP

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az vm repair
General Guidelines

[x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required) yes
[x] Have you run python scripts/ci/test_index.py -q locally? yes

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Thank you for your contribution! We will review the pull request and get back to you soon.


Bug: New wait instruction doesn’t seem to work.

Describe the bug
¨w doesn’t seem to work in online interpreter.
Example program
3¨w

Try it
Expected Output
(takes 3 seconds to run and doesn’t output anything)

Other things

I made the PR ( #1799 ) for this so I’m sorry if I did something wrong.

For me it outputs 3:

Now I get an error when running the same code:
Traceback (most recent call last):
  File "/home/Vyxal/mysite/vyxal/main.py", line 330, in execute_vyxal
    exec(code, locals() | globals())
  File "<string>", line 3, in <module>
TypeError: isinstance() arg 2 must be a type or tuple of types

#1803 should take care of this. Also, the online interpreter doesn't have the element yet because it hasn't been pushed to the production branch yet. I'm closing for now since it probably works fine.


HTTPS System proxies are not interpreted correctly on Windows

@seanmonstar First of all, thank you for the great library and your work!
I noticed a bug in the Windows system HTTPS proxy handling, in particular:

After https://github.com/seanmonstar/reqwest/pull/1005 multiple proxies are detected correctly on Windows, but requests to HTTPS domains cause the client to hang, and then fail with The token supplied to the function is invalid, which is the same problem reported in https://github.com/seanmonstar/reqwest/issues/416
After a bit of digging, I found the root cause of the problem. In particular, when loading the proxy settings from the registry, Reqwest makes the assumption that an HTTPS proxy should go through the HTTPS protocol, which is not the case. In general, HTTPS requests are sent to the proxy using the HTTP protocol, and then the proxy will tunnel them as TCP packets.

When setting up a test proxy, (using Fiddler), the Windows registry entry will contain the value:
http=<IP_ADDRESS>:8888;https=<IP_ADDRESS>:8888

and Reqwest will interpret those as:
HTTP_PROXY=http://<IP_ADDRESS>:8888
HTTPS_PROXY=https://<IP_ADDRESS>:8888

Unfortunately, this is most likely incorrect, as the HTTPS proxy should use the http protocol as well:
HTTP_PROXY=http://<IP_ADDRESS>:8888
HTTPS_PROXY=http://<IP_ADDRESS>:8888

I consider it a bug and not expected behavior as most other http libraries (of other languages, such as Python) and webbrowsers are handling the proxy correctly, using the HTTP protocol.
How to reproduce

Download and start Fiddler
Fiddler will automatically setup a proxy at <IP_ADDRESS>:8888, including this entry in the Windows registry: http=<IP_ADDRESS>:8888;https=<IP_ADDRESS>:8888
The following code will hang and then fail with error: Error: reqwest::Error { kind: Request, url: Url { scheme: "https", host: Some(Domain("httpbin.org")), port: None, path: "/ip", query: None, fragment: None }, source: hyper::Error(Connect, Os { code: -2146893048, kind:  Other, message: "The token supplied to the function is invalid" }) }

use tokio::*;
use std::collections::HashMap;

#[tokio::main]
async fn main() -> Result<(), Box<dyn std::error::Error>> {
    let client = reqwest::Client::builder()
    //.proxy(reqwest::Proxy::https("http://<IP_ADDRESS>:8888")?)
    .build()?;
    let resp = client.get("https://httpbin.org/ip").send().await?
        .json::<HashMap<String, String>>()
        .await?;
    println!("{:#?}", resp);
    Ok(())
}

Forcing the HTTPS proxy to go though http by uncommenting the line will fix the error and behave as expected.

Thanks for the great write-up! If it's handling things differently than most other tools do, then we should fix it! Would you like to submit a PR doing so? Also, I'm curious, how does a user on Windows normally indicate that they should use HTTPS to talk directly to the proxy?

@seanmonstar Thank you! I'll open a PR in a few days, as soon as I get some time :)

Also, I'm curious, how does a user on Windows normally indicate that they should use HTTPS to talk directly to the proxy?

As far as I could tell (by studying other tools/libraries and reading articles), it's very unlikely for an HTTPS proxy to actually use HTTPS between the client and the proxy (for example, see: https://stackoverflow.com/questions/516323/https-connections-over-proxy-servers). Instead, HTTP proxies would handle HTTPS by converting it to a TCP/IP tunnel, which is completely blind about the HTTPS data being transmitted (as it's encrypted).
I experimented with Python, and by specifying HTTPS proxy + HTTPS protocol it works, but I'm reasonably sure that under the hoods it's communicating with the Proxy using the HTTP protocol.
Another example would be curl. For instance, using the same proxy configuration as the previous ticket, we get that:
# This hangs and then fail
https_proxy=https://<IP_ADDRESS>:8888 curl -I https://google.com

# This works correctly
https_proxy=http://<IP_ADDRESS>:8888 curl -I https://google.com

Because in some limited cases a user might still want to use HTTPS to communicate with the proxy, what about defaulting the protocol to HTTP if not explicitly specified?
For example, the following Registry entry:
http=<IP_ADDRESS>:8888;https=<IP_ADDRESS>:8888

would get interpreted as:
HTTP_PROXY=http://<IP_ADDRESS>:8888
HTTPS_PROXY=http://<IP_ADDRESS>:8888

But the user could specify the HTTPS protocol explicitly:
http=http://<IP_ADDRESS>:8888;https=https://<IP_ADDRESS>:8888

which could be translated to:
HTTP_PROXY=http://<IP_ADDRESS>:8888
HTTPS_PROXY=https://<IP_ADDRESS>:8888

This way, we provide a good default without limiting the user. What do you think?

But the user could specify the HTTPS protocol explicitly:
http=http://<IP_ADDRESS>:8888;https=https://<IP_ADDRESS>:8888

Yea, that makes sense. I found this Windows documentation that seems to suggest that, but it doesn't explicitly say what should be assumed if the scheme is missing... But sounds good to me!


Allow to use any directory as site root

This would be part of the Statiq config (Deployment)
Default would be src/main/site and data would be relative to it
This might change the way we scan for files, see Quinoa for example:
https://github.com/quarkiverse/quarkus-quinoa/blob/main/deployment/src/main/java/io/quarkiverse/quinoa/deployment/QuinoaProcessor.java#L358-L378
@melloware this one is for you I guess?

Yep you can assign this one to me.


add replicate.models.list() method for listing public models

Yep!

Oh god I just noticed all the unrelated changes here that resulted from my mysterious VSCode setup. 🙈
See https://github.com/replicate/replicate-javascript/issues/119

Cleaned up the littany of lintening and force-pushed a cleaner commit.


More crypters [Patch included]

Hi,
thanks for your great work, it's very usefull for me.
I did a little change to add support for more crypters:
https://github.com/webmeisterei/go-http-auth/commit/7616ea56faee4a7f203c195f22bee42c08774ce4
Do you want a pull request for that?
Thanks and Kind regards,
René

@abbot Thanks for your response.
I would love SHA256 Crypt and SHA512 Crypt, 256 is used by Check_MK htpasswd.


Add option to round edges in SugiyamaEdgeRenderer

This PR introduces the option to round the edges of the Sugiyama algorithm.

@nabil6391 Any time to take a look at this PR?

I have added a comment only in one place, other mostly LGTM. Thanks! @JulianBissekkou

I have added a comment only in one place, other mostly LGTM. Thanks! @JulianBissekkou

Did you forget to submit your review? I don't see the comment.

Fixed the feedback. 👍🏽

Thanks for merging. Let me know when you deployed a new version to pub :)


Training with the prototxt is slow

In case of directly using the prototxt, please change the depthwise convolution layers type from Convolution into DepthwiseConvolution. After changing the 1.5x prototxt, the training speed up from ~14seconds/iter to 1s/iter.

Thanks for the comment.

have you ever trained shufflenet with caffe? I have encored with a very strange problem when training. It will be very appreciate if you can get any comment or sugguestions.
My problem is this.
I trained shufflenet V2 0.5, with caffe windows, Cuda 10.1, Cudnn7.5，RTX2080.
I change the input size to 32*16 for my specific task. I also changed the prototxt files to make it work.
I do can train this net and get correct results like caffemodels and so on. My batch size is 16, My 8G gpu memory was used up to 7.3G.  I want to know what is the normal memory usage of a ordinary shuffenetv2 is, on any training platform. hope you can help, thanks

I haven't trained this model on Caffe. In Caffe, convolution with group is implemented by for loop with conventional convolution, which is a very expensive implementation.
In your case. I think you should replace group convolution with depthwise convolution.


vs code source control not showing checked out repos

Thanks for sharing this work!
I configured my workspace in ros2.repos and cloned them via the setup task. The only problem is that they don't appear in the vs code source control tab.
Do you know how I can add them? Is it a problem that they are technically inside another git repository?
Thank you in advance!

They are indeed other git repositories.
If you add them as a submodule they should show up correctly.