HADOOP-17527. ABFS: Fix boundary conditions in InputStream seek and skip

Modify AbfsInputStream seek method to throw EOF exception on seek to contentLength for a non-empty file

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
21m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 26s

trunk passed

+1 :green_heart:
compile
0m 39s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 34s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 29s

trunk passed

+1 :green_heart:
mvnsite
0m 38s

trunk passed

+1 :green_heart:
shadedclient
14m 19s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
0m 59s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 57s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 28s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
compile
0m 25s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
0m 25s

the patch passed

+1 :green_heart:
checkstyle
0m 17s

the patch passed

+1 :green_heart:
mvnsite
0m 28s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
12m 45s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
findbugs
1m  0s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 56s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

94m 22s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2698

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 362f3c83d25e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f9a073c6c18

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/1/testReport/

Max. process+thread count
538 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/1/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
15m  9s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
37m  6s

trunk passed

+1 :green_heart:
compile
0m 43s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 33s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 26s

trunk passed

+1 :green_heart:
mvnsite
0m 36s

trunk passed

+1 :green_heart:
shadedclient
18m  2s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 28s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
1m  5s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
1m  2s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s

the patch passed

+1 :green_heart:
compile
0m 36s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 36s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
checkstyle
0m 20s

the patch passed

+1 :green_heart:
mvnsite
0m 32s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
16m 55s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 31s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
findbugs
1m 10s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
2m  2s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 36s

The patch does not generate ASF License warnings.

100m 51s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2698

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 81315926c5d9 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f9a073c6c18

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/2/testReport/

Max. process+thread count
715 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/2/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 16s

trunk passed

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 30s

trunk passed

+1 :green_heart:
mvnsite
0m 40s

trunk passed

+1 :green_heart:
shadedclient
14m 26s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 34s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
1m  2s

Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 59s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
0m 26s

the patch passed

+1 :green_heart:
checkstyle
0m 18s

the patch passed

+1 :green_heart:
mvnsite
0m 28s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
12m 37s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
findbugs
0m 59s

the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 53s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

73m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2698

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 5931251a307d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 07a4220cd27

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/3/testReport/

Max. process+thread count
670 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/3/console

versions
git=2.25.1 maven=3.6.3 findbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
14m 15s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 12s

trunk passed

+1 :green_heart:
compile
0m 39s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 29s

trunk passed

+1 :green_heart:
mvnsite
0m 38s

trunk passed

+1 :green_heart:
shadedclient
14m 10s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
16m 13s

Both FindBugs and SpotBugs are enabled, using SpotBugs.

+1 :green_heart:
spotbugs
1m  0s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
compile
0m 24s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
0m 24s

the patch passed

+1 :green_heart:
checkstyle
0m 18s

the patch passed

+1 :green_heart:
mvnsite
0m 28s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
12m 50s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
spotbugs
0m 54s
/patch-spotbugs-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure cannot run computeBugHistory from spotbugs

_ Other Tests _

+1 :green_heart:
unit
1m 54s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

86m 34s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2698

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle

uname
Linux 6b0a70b6232b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 4cf35315838

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/4/testReport/

Max. process+thread count
693 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 28s

trunk passed

+1 :green_heart:
compile
0m 39s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 40s

trunk passed

+1 :green_heart:
shadedclient
14m  8s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 33s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
16m 12s

Both FindBugs and SpotBugs are enabled, using SpotBugs.

+1 :green_heart:
spotbugs
1m  2s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
compile
0m 25s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
0m 25s

the patch passed

-0 :warning:
checkstyle
0m 17s
/diff-checkstyle-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 28s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
12m 53s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
spotbugs
0m 52s
/patch-spotbugs-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure cannot run computeBugHistory from spotbugs

_ Other Tests _

+1 :green_heart:
unit
1m 52s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 34s

The patch does not generate ASF License warnings.

73m 47s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2698

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle

uname
Linux 30556e05addd 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0ed9e36282c

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/5/testReport/

Max. process+thread count
542 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 32s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 37s

trunk passed

+1 :green_heart:
compile
0m 38s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 29s

trunk passed

+1 :green_heart:
mvnsite
0m 40s

trunk passed

+1 :green_heart:
shadedclient
14m 19s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
16m 22s

Both FindBugs and SpotBugs are enabled, using SpotBugs.

+1 :green_heart:
spotbugs
1m  3s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 31s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 31s

the patch passed

+1 :green_heart:
compile
0m 27s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
0m 27s

the patch passed

-0 :warning:
checkstyle
0m 17s
/diff-checkstyle-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 30s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
12m 51s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
spotbugs
0m 54s
/patch-spotbugs-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure cannot run computeBugHistory from spotbugs

_ Other Tests _

+1 :green_heart:
unit
1m 55s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 33s

The patch does not generate ASF License warnings.

73m 19s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2698

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle

uname
Linux e97e19e9d440 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0ed9e36282c

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/6/testReport/

Max. process+thread count
538 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

TEST RESULTS
HNS Account Location: East US 2
NonHNS Account Location: East US 2, Central US
HNS-OAuth

[INFO] Tests run: 93, Failures: 0, Errors: 0, Skipped: 0
[ERROR] Failures:
[ERROR]   ITestAzureBlobFileSystemFlush.testStreamCapabilitiesWithFlushEnabled:327
[ERROR] Tests run: 502, Failures: 1, Errors: 0, Skipped: 68
[WARNING] Tests run: 257, Failures: 0, Errors: 0, Skipped: 48

HNS-SharedKey

[INFO] Tests run: 93, Failures: 0, Errors: 0, Skipped: 0
[ERROR] Failures:
[ERROR]   ITestAzureBlobFileSystemFlush.testStreamCapabilitiesWithFlushEnabled:327
[ERROR] Tests run: 495, Failures: 1, Errors: 0, Skipped: 24
[WARNING] Tests run: 257, Failures: 0, Errors: 0, Skipped: 40

NonHNS-SharedKey

[INFO] Tests run: 93, Failures: 0, Errors: 0, Skipped: 0
[ERROR] Failures:
[ERROR]   ITestAzureBlobFileSystemFlush.testStreamCapabilitiesWithFlushEnabled:327
[ERROR] Tests run: 502, Failures: 1, Errors: 0, Skipped: 249
[WARNING] Tests run: 257, Failures: 0, Errors: 0, Skipped: 40

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
22m  7s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
36m 57s

trunk passed

+1 :green_heart:
compile
0m 40s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 26s

trunk passed

+1 :green_heart:
mvnsite
0m 35s

trunk passed

+1 :green_heart:
shadedclient
17m  4s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 26s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 24s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
18m 53s

Both FindBugs and SpotBugs are enabled, using SpotBugs.

+1 :green_heart:
spotbugs
0m 58s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
compile
0m 23s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
0m 23s

the patch passed

-0 :warning:
checkstyle
0m 16s
/diff-checkstyle-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)

+1 :green_heart:
mvnsite
0m 26s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
15m 28s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 22s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
spotbugs
0m 53s
/patch-spotbugs-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure cannot run computeBugHistory from spotbugs

_ Other Tests _

+1 :green_heart:
unit
1m 55s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 29s

The patch does not generate ASF License warnings.

103m 52s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2698

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle

uname
Linux ff48c2b258b5 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 0ed9e36282c

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/7/testReport/

Max. process+thread count
574 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/7/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 31s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
32m 33s

trunk passed

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 33s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 38s

trunk passed

+1 :green_heart:
shadedclient
14m 12s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 32s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
16m 12s

Both FindBugs and SpotBugs are enabled, using SpotBugs.

+1 :green_heart:
spotbugs
1m  0s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s

the patch passed

+1 :green_heart:
compile
0m 29s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 29s

the patch passed

+1 :green_heart:
compile
0m 25s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
0m 25s

the patch passed

+1 :green_heart:
checkstyle
0m 17s

the patch passed

+1 :green_heart:
mvnsite
0m 27s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
12m 53s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 27s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
spotbugs
0m 54s
/patch-spotbugs-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure cannot run computeBugHistory from spotbugs

_ Other Tests _

+1 :green_heart:
unit
1m 52s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

72m 57s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2698

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle

uname
Linux 49d55604bd0a 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e391844e8e4

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/8/testReport/

Max. process+thread count
539 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/8/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
35m  4s

trunk passed

+1 :green_heart:
compile
0m 39s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 35s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 39s

trunk passed

+1 :green_heart:
shadedclient
14m 18s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 33s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
16m 24s

Both FindBugs and SpotBugs are enabled, using SpotBugs.

+1 :green_heart:
spotbugs
1m  0s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
0m 26s

the patch passed

+1 :green_heart:
checkstyle
0m 17s

the patch passed

+1 :green_heart:
mvnsite
0m 29s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 12s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 23s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
spotbugs
0m 53s
/patch-spotbugs-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure cannot run computeBugHistory from spotbugs

_ Other Tests _

+1 :green_heart:
unit
1m 50s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

76m  1s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2698

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle

uname
Linux d56ae709c1b4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e391844e8e4

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/9/testReport/

Max. process+thread count
719 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/9/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  5s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 46s

trunk passed

+1 :green_heart:
compile
0m 42s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 32s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 25s

trunk passed

+1 :green_heart:
mvnsite
0m 38s

trunk passed

+1 :green_heart:
shadedclient
14m 39s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 31s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
16m 36s

Both FindBugs and SpotBugs are enabled, using SpotBugs.

+1 :green_heart:
spotbugs
0m 57s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 29s

the patch passed

+1 :green_heart:
compile
0m 30s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 30s

the patch passed

+1 :green_heart:
compile
0m 26s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
0m 26s

the patch passed

+1 :green_heart:
checkstyle
0m 17s

the patch passed

+1 :green_heart:
mvnsite
0m 29s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 16s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 24s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
spotbugs
0m 52s
/patch-spotbugs-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure cannot run computeBugHistory from spotbugs

_ Other Tests _

+1 :green_heart:
unit
2m  0s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 30s

The patch does not generate ASF License warnings.

75m 32s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2698

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle

uname
Linux cda66f0853c0 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e391844e8e4

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/10/testReport/

Max. process+thread count
730 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/10/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 29s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:

0m  0s
test4tests
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
33m 20s

trunk passed

+1 :green_heart:
compile
0m 37s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
compile
0m 33s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
checkstyle
0m 28s

trunk passed

+1 :green_heart:
mvnsite
0m 35s

trunk passed

+1 :green_heart:
shadedclient
14m 21s

branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 30s

trunk passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 29s

trunk passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+0 :ok:
spotbugs
16m 17s

Both FindBugs and SpotBugs are enabled, using SpotBugs.

+1 :green_heart:
spotbugs
0m 59s

trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 30s

the patch passed

+1 :green_heart:
compile
0m 28s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javac
0m 28s

the patch passed

+1 :green_heart:
compile
0m 25s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

+1 :green_heart:
javac
0m 25s

the patch passed

+1 :green_heart:
checkstyle
0m 17s

the patch passed

+1 :green_heart:
mvnsite
0m 29s

the patch passed

+1 :green_heart:
whitespace
0m  0s

The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m  4s

patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s

the patch passed with JDK Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04

+1 :green_heart:
javadoc
0m 26s

the patch passed with JDK Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

-1 :x:
spotbugs
0m 53s
/patch-spotbugs-hadoop-tools_hadoop-azure.txt
hadoop-tools/hadoop-azure cannot run computeBugHistory from spotbugs

_ Other Tests _

+1 :green_heart:
unit
2m  0s

hadoop-azure in the patch passed.

+1 :green_heart:
asflicense
0m 32s

The patch does not generate ASF License warnings.

75m  9s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2698

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle

uname
Linux fa01df1f4ff9 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / e391844e8e4

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.10+9-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_282-8u282-b08-0ubuntu1~20.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/11/testReport/

Max. process+thread count
546 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-azure U: hadoop-tools/hadoop-azure

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2698/11/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.0.6

Powered by
Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

TEST RESULTS
HNS Account Location: East US 2
NonHNS Account Location: East US 2, Central US
HNS-OAuth

[INFO] Tests run: 93, Failures: 0, Errors: 0, Skipped: 0
[ERROR] Failures:
[ERROR]   ITestAzureBlobFileSystemFlush.testStreamCapabilitiesWithFlushEnabled:327
[ERROR] Tests run: 503, Failures: 1, Errors: 0, Skipped: 68
[WARNING] Tests run: 257, Failures: 0, Errors: 0, Skipped: 48

HNS-SharedKey

[INFO] Tests run: 93, Failures: 0, Errors: 0, Skipped: 0
[ERROR] Failures:
[ERROR]   ITestAzureBlobFileSystemFlush.testStreamCapabilitiesWithFlushEnabled:327
[ERROR] Tests run: 510, Failures: 1, Errors: 0, Skipped: 24
[WARNING] Tests run: 257, Failures: 0, Errors: 0, Skipped: 40

NonHNS-SharedKey

[INFO] Tests run: 93, Failures: 0, Errors: 0, Skipped: 0
[ERROR] Failures:
[ERROR]   ITestAzureBlobFileSystemFlush.testStreamCapabilitiesWithFlushEnabled:327
[ERROR] Tests run: 502, Failures: 1, Errors: 0, Skipped: 249
[WARNING] Tests run: 257, Failures: 0, Errors: 0, Skipped: 40

TEST RESULTS
HNS Account Location: East US 2
NonHNS Account Location: East US 2, Central US
HNS-OAuth

[INFO] Tests run: 93, Failures: 0, Errors: 0, Skipped: 0
[WARNING] Tests run: 503, Failures: 0, Errors: 0, Skipped: 68
[WARNING] Tests run: 257, Failures: 0, Errors: 0, Skipped: 48

HNS-SharedKey

[INFO] Tests run: 93, Failures: 0, Errors: 0, Skipped: 0
[WARNING] Tests run: 512, Failures: 0, Errors: 0, Skipped: 24
[WARNING] Tests run: 257, Failures: 0, Errors: 0, Skipped: 40

NonHNS-SharedKey

[INFO] Tests run: 93, Failures: 0, Errors: 0, Skipped: 0
[WARNING] Tests run: 503, Failures: 0, Errors: 0, Skipped: 249
[WARNING] Tests run: 257, Failures: 0, Errors: 0, Skipped: 40


Nitro ErrorHandler

Environment
Nuxt 3.2
Reproduction
https://stackblitz.com/edit/nuxt-starter-htdfyf?file=server%2Fapi%2F500.js,server%2Fapi%2F200.js,app.vue,server%2Fplugins%2Ferrors.js,package.json
Describe the bug
I want to be able to catch server error using nuxt 3. I've made a nitro plugin
// server/plugins/errors.js
export default defineNitroPlugin((nitroApp) => {
    nitroApp.hooks.hook('render:response', (response, { event }) => {
		console.log(`Status is: ${response.statusCode} - ${Object.keys(response).join(", ")}`)
    })
})

My issue is that it gets called only on non errors. Any way to be able to run this also on errors? What's the best way to set an error handler?
Additional context
No response
Logs
No response

There is currently no corresponding callHook.
use nitro option?
reference:
https://nitro.unjs.io/config#handlers
https://github.com/unjs/nitro/blob/main/examples/custom-error-handler/nitro.config.ts

In my use case, I would like to hook into the requests being sent, capturing the method and path, to identify what and where the most errors occur. While the error hook can catch all server errors, it does not provide information on whether these errors stem from a side effect or an API call.
I am able to hook into the request and create a 'two-part log message,' but the error hook is invoked before the request hook. Is there another way to achieve this?


Toolchain Profiling

Description
This PR adds profiling statements to the gt4py pipeline via the build_info dictionary. The following metrics are collected if build_info is passed to the stencil decorator:

Parsing time (frontend)
Loading time (loading cached modules)
Code generation time (definition IR -> generated code)
Build time (general purpose compiler, gcc or nvcc)
Module creation time (python module generation)

TODO: Add unit tests...
Requirements
Before submitting this PR, please make sure:

[ ] You have run the code checks, tests and documentation build successfully
[ ] All fixes and all new functionality are tested and documentation is up to date
[ ] You looked at the review checklist

bors try


Error after errors in tests are printed out

Hey, I am not really sure if this applies to karma-mocha-reporter, karma or gulp, but it only happens after the Failed Tests are printing (If all tests are passing I don't get the stacktrace printed out and it ends properly).  This is a screenshot of the error that I encountered.

To me it seems like a problem of gulp. I had something similar when the karma gulp task fails. Then gulp itself also fails and print an Exception. Can you please share your karma gulp task configuration. So I can compare it with my configuration.

Sure thing, this is the gulp task.  Did you need to see the karma config as well?
gulp.task('test', function (done) {
    new Karma({
        configFile: __dirname + '/../../karma.conf.js',
        singleRun: true
    }, done).start();
});

Here is my task. I use the newest karma v0.13.21 So the server is first instanciated and then started.
gulp.task('test', function(done) {
    var server = new karma.Server(localConfig, function (failCount) {
        done(failCount && new Error('Failed ' + failCount + ' tests.'));
    });
    server.start();
}

Hey @ShawnCholeva, do you still have the problem?

I was having this same problem just yesterday. I've read this is not the optimal solution but here is how I have fixed it for now:
gulp.task("unit-tests-all", function(done) { 	new Server({ 		configFile: __dirname + "/karma.conf.js", 		singleRun: true 	}, function() { done(); }).start(); });

Closing for now since this is a gulp problem. Thanks @afterbangx for your feedback.


Introduce a new Bucket Rendering System

https://github.com/buildaworldnet/IrrlichtBAW/issues/376#issuecomment-541106996
Needs #350 and Vulkan so we can benchmark.
Also need to look into this:

http://realtimecollisiondetection.net/blog/?p=86
Framegraph concept from GPU Pro

Backed up comments @Crisspl
 devshgraphicsprogramming on 24 Aug Author Collaborator

in the future: sort by pipeline pointer
@devshgraphicsprogramming
devshgraphicsprogramming 26 days ago Author Collaborator

@Crisspl could sort by pipeline shaders, then raster parameters, then descriptor set pointers
@devshgraphicsprogramming
devshgraphicsprogramming 12 days ago Author Collaborator

progress?
@Crisspl
Crisspl 7 days ago Contributor

sort what? whats going on? theres no pipeline ptr in there anyway. seriously WHAT
@devshgraphicsprogramming
devshgraphicsprogramming 6 days ago Author Collaborator

instead of sorting on the material associated with the first meshbuffer in the node, sort by graphics pipeline of the first meshbuffer (most significant are bound shaders [geometry>tessellation>fragment>vertex], then raster params, then anything else).
@devshgraphicsprogramming
devshgraphicsprogramming 3 days ago Author Collaborator

@Crisspl can you back these comments up somewhere, I'm scared I'll have to go over it again in the near future when you fix irr::scene

Bucket Rendering does not tightly integrate with FrameGraph
Basically our bucket needs to take the following:
A:

SubpassRenderpass UUID
Viewport ID
B:
Pipeline's Shaders
Pipeline's Raster Ops (SPrimitiveAssemblyParams and SRasterizationParams and SBlendParams)
C:
Depth quantized to a few bits
D:
Desriptor Set UUIDs (but not taking into account dynamic offsets)
SVertexInputParams
Descriptor Set dynamic offsets
push constants?? (sort to get a list of smallest change????)

Must provide a flexible user-overridable method to compute the sorting key, as we don't know if it should be ABCD (solid), ABDC (classical transparency),  ACBD (really weird and custom shaders+ROPs blended mixed with forward transparency.
Must be able to customize the key.
Would like to use radix-sort but its unknown yet if the key can be made sufficiently small.


When stopping pipeline while worker is init

When stopping pipeline while worker is init the worker get an error

don't have a good way to test this issue,
this issue was opened not by me, so it wasnt a bug.
for now i will close the issue but if i see it happening again will reopen


Azure Availability Set for VM Managed Disks

Rancher versions:
rancher/rancher: v2.0.8
Type/provider of hosts:
Azure
Steps to Reproduce:
Deploy Azure VM using Azure cloud provider
Size: Standard_D2s_V3
Storage Type: Premium LRS
Availability Set: massimo-avs
Fill out the following in the azure cloud provider config
aadClientId*
aadClientSecret*
subscriptionId*
tenantId*
Results:
Rancher deploys Azure VM which does not use managed disks, even though I specified Premium LRS as the storage type and my own availability set.
'massimo1' is not using Managed Disks. Migrate to Managed Disks to get more benefits.

The odd thing is that if you create the availability set in Azure Portal as managed before deploying, Rancher will change it to unmanaged on the deployment of the Azure VM.
Am I missing a configuration option that allows me to set the availability set to managed on the node template for Azure? If not then can we implement an option to select Unmanaged (classic) vs Managed (Aligned) availability set?
https://docs.microsoft.com/en-us/rest/api/compute/availabilitysets/createorupdate#request-body
https://docs.microsoft.com/en-us/azure/virtual-machines/windows/tutorial-availability-sets#create-an-availability-set

When this could be resolved?
I got one step further into the pit:

I've upgraded availability set and converted to managed disk (needed more iops),
now I can't add another node via rancher (rancher tries to to add vm with unmanaged disk to "managed" availability set which is not possible)
"managed" availability set can't be downgraded

Now I'm stuck...

We encounter the same issues @danielllek mentioned.
This is a blocker for our company to use Rancher because we have to use managed disks.
A solution or work-arround is very, very, very welcome...

@deniseschannon @erikwilson This is a major blocker for our company, since we can only go live with managed disks. Can this bug get priority on the backlog? Is there a work-around available?

@deniseschannon @erikwilson I'm also having this problem at my company. We had to convert the availability set to ManagedDisk, so that all workers could have its disks migrated to. This was done because Managed Disks created by StorageClasses couldn't be attached to workers.
Now we can't scale workers because of this availability set limitation.

@erikwilson can you test two things:

if it is a timing issue where the managed AS needs to exist for some time before it works in their API
if this works in the latest 2.1 release

I'm using Rancher v2.2.2 and this is not a timing issue here...

Same problem here and I can't find any option in rancher to change this

backend is in.

Just stumbled upon this issue.
Is there a rancher 2 release that contains this even at an alpha state?
Or a workaround to use the new backend?

@annerajb this depends on an update to docker-machine that is not included in a current rc. Once it is included, you should be able to do this by using the UI as the fields are generated dynamically. This should be available in 2.3. I can ask about changing the milestone.

The bug is reproduced in Rancher: v2.2.7
Deploy Azure VM using Azure cloud provider
Test 1: let Rancher generates all resources
Size: Standard_D2s_V3
Storage Type: Premium LRS
Availability Set: jiaqi-availablity-set1 (created by Rancher)
Result:

Rancher deploys Azure VM which does not use managed disks

Test 2: use my own availability set

create my own availability set and set it to use managed disk

use this availability set to provision a cluster

Size: Standard_D2s_V3
Storage Type: Premium LRS
Availability Set: jiaqi-managed-disk-a-set
Result:

Still, Rancher deploys Azure VM which does not use managed disks
Rancher modifies my availability set to not use managed disk

The bug fix is validated in Rancher: master-head bc3700f8
Test 1: let Rancher generates all resources
Size: Standard_D2s_V3
Storage Type: Premium LRS
Availability Set: jiaqi-from-rancher (created by Rancher)
Result:

Rancher deploys Azure VM which are using managed disks

Rancher creates the availability set that set the managed to yes which means it uses managed disks

Test 2: use my own availability set

create my own availability set and set it to use managed disk

use this availability set to provision a cluster

Size: Standard_D2s_V3
Storage Type: Premium LRS
Availability Set: jiaqi-managed-disk-a-set
Result:

Rancher deploys Azure VM which are using managed disks


Refreshing the swap page results in seeing the same token as the source/target

I selected LRC as the source token and BNT as the target token, then refreshed.
This is what I saw next -

While the URL seems to be the correct one -
https://app.bancor.network/eth/swap?from=0xBBbbCA6A901c926F240b89EacB641d8Aec7AEafD&to=0x1f573d6fb3f13d689ff844b4ce37794d79a7ff1c
I did it multiple times and it was consistent.

@pingustar Will the view layer still select based on params?

I have updated the routing for the swap and fixed a few edge cases.
Should work now. Closing this.


AudioWorklet audio glitches

Hi, thanks for this nice library. I've tried the AudioWorklet implementation and got a lot of audio glitches when I move the browser window etc. In the main thread it runs very smoothly. Did you encounter the same problem? I've tested it on Chrome/Windows.

Thanks for the report.
In AudioWorklet, though WebAssembly works on it, the render process is required to perform very quickly. According to the current Web Audio specification, only 128 frames (= one render quantum) can be rendered per one process. So if sample rate is 48,000 (Hz), one process can only spend around 2.67ms (1000*128/48000) without glitches.
Currently I think Web Worker is the best to run js-synthesizer, and AudioWorklet should just receive the generated buffer from Web Worker and render it. js-sequencer is using this method (around worker and worklet directories), so if necessary please refer it. (This may be complex, but may work more properly.)

Thanks for this great response. I am new to WebAssembly and AudioWorklets, so I have to learn a few things.
Ah nice, didn't saw this project. I once wrote a Midi sequencer with Flex and the Project Alchemy. I also used FluidSynth and did the MIDI parsing in ActionScript. Nice to see another person with the same idea 😃👍


ERROR: Sorry about that.

Checklist

[ *] I'm reporting a broken site support issue
[ *] I've verified that I'm running youtube-dl version 2019.08.13
[ *] I've checked that all provided URLs are alive and playable in a browser
[* ] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[* ] I've searched the bugtracker for similar bug reports including closed ones
[* ] I've read bugs section in FAQ

Verbose log
XX~/test# youtube-dl https://www.youtube.com/watch?v=s3O1Xro7oAI --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'https://www.youtube.com/watch?v=s3O1Xro7oAI', u'--verbose']
WARNING: Assuming --restrict-filenames since file system encoding cannot encode all characters. Set the LC_ALL environment variable to fix this.
[debug] Encodings: locale ANSI_X3.4-1968, fs ANSI_X3.4-1968, out ANSI_X3.4-1968, pref ANSI_X3.4-1968
[debug] youtube-dl version 2019.08.13
[debug] Python version 2.7.13 (CPython) - Linux-4.9.0-9-amd64-x86_64-with-debian-9.9
[debug] exe versions: ffmpeg 4.1.2, ffprobe 4.1.2, phantomjs 2.1.1
[debug] Proxy map: {}
[youtube] s3O1Xro7oAI: Downloading webpage
[youtube] s3O1Xro7oAI: Downloading video info webpage
ERROR: Sorry about that.
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 796, in extract_info
    ie_result = ie.extract(url)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 530, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/youtube.py", line 2108, in _real_extract
    raise ExtractorError(error_message, expected=True)
ExtractorError: Sorry about that.

Description
Hello, when I try to download a video with youtube-dl, I have this error since today.

WARNING: Assuming --restrict-filenames since file system encoding cannot encode all characters. Set the LC_ALL environment variable to fix this.

[debug] Encodings: locale ANSI_X3.4-1968, fs ANSI_X3.4-1968, out ANSI_X3.4-1968, pref ANSI_X3.4-1968

This looks.. wrong. Something or someone changed some system settings?

I am getting the same error.
You seem to suggest that that this is a geo-restricted  issue.
If that is the case, the --geo-bypass flag should work. But it doesnt.
youtube-dl --geo-bypass --verbose http://www.youtube.com/watch?v=bo_efYhYU2A
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--geo-bypass', '--verbose', 'http://www.youtube.com/watch?v=bo_efYhYU2A']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.08.13
[debug] Python version 3.7.3 (CPython) - Linux-5.0.0-15-generic-x86_64-with-Ubuntu-19.04-disco
[debug] exe versions: ffmpeg 4.1.3, ffprobe 4.1.3, phantomjs ., rtmpdump 2.4
[debug] Proxy map: {}
[youtube] bo_efYhYU2A: Downloading webpage
[youtube] bo_efYhYU2A: Downloading video info webpage
ERROR: Sorry about that.
Traceback (most recent call last):
  File "/usr/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 796, in extract_info
    ie_result = ie.extract(url)
  File "/usr/bin/youtube-dl/youtube_dl/extractor/common.py", line 530, in extract
    ie_result = self._real_extract(url)
  File "/usr/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 2108, in _real_extract
    raise ExtractorError(error_message, expected=True)
youtube_dl.utils.ExtractorError: Sorry about that.

I'm getting the same unhelpful error on some YouTube videos.

I was getting the same, however I fixed it by using the --force-ipv4 option.

I don't think this is Geo-Restriction, ytdl just doesn't seem to work on any videos uploaded to a "Official Artist" YouTube channel.

This didn't work for me.


CausalELM v0.5.1

@JuliaRegistrator register()

Registration pull request created: JuliaRegistries/General/98935
Tip: Release Notes
Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.
@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.
Tagging
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.5.1 -m "<description of version>" f36bcbe16ce8004f996a93b64dc32eb0aac85fdf
git push origin v0.5.1


case sensitivity

issue is explained in the #commented section, but i provided a bit of extra context for how i encountered it.
i made a fork trying to repurpose this for music notes rather than english, so far im running into an issue with two characters having one coordinate in the case of flats, ie Cb, Db, Eb, Gb, and Ab crash the program because of "b"
decided to tinker some more and try repurposing it for hex strings, ran into an issue, with capital letters,
the issue
went back to the original version (ive kept yours in its own folder completely unedited), tried the word Test
it threw an issue with the capital T
the input field needs to auto lowercase the text input before graphing it.
/the issue
#what terminal says: input was the word "Test"
Traceback (most recent call last):
File "C:\Users\User\Desktop\word-shapes-main\word_explorer.py", line 109, in update_display_mode
self.display_many_words([self.input_field.text().strip()])
File "C:\Users\User\Desktop\word-shapes-main\word_explorer.py", line 187, in display_many_words
polygon_shape = self.word_shape.get_polygon_shape(word)
File "C:\Users\User\Desktop\word-shapes-main\word_shape.py", line 20, in get_polygon_shape
return [self.letter_wheel.get_coordinates(letter, True) for letter in unique_letters]
File "C:\Users\User\Desktop\word-shapes-main\word_shape.py", line 20, in
return [self.letter_wheel.get_coordinates(letter, True) for letter in unique_letters]
File "C:\Users\User\Desktop\word-shapes-main\letter_wheel.py", line 22, in get_coordinates
return self.high_precision_letter_mapping[letter]
KeyError: 'T'
im working on some changes you might find interesting to expand this thing, and when ive got them up and running ill post them to a fork for you to check out

im deleting my fork, swapping the music notes idea to just be base12 0,1,2,3,4,5,6,7,8,9,A,B instead, and going to attempt to port to tkinter/ttk instead because qt has some quite restrictive policies on use.


⚠ Thumbnails API Endpoint has degraded performance

In 654ac80, Thumbnails API Endpoint (https://thumbnails.roblox.com/v1/assets?assetIds=82738847&format=Png&isCircular=false&size=30x30) experienced degraded performance:

HTTP code: 200
Response time: 4915 ms

Resolved: Thumbnails API Endpoint performance has improved in 50a8af2 after 12 minutes.


E1011 '123456789012' is not one of [ ... ] for mapping 'AWSAccountsMap'

CloudFormation Lint Version
1.12.1
What operating system are you using?
Ubuntu
Describe the bug
Validation fails when using !Ref AWS::AccountId as top level key with FindInMap unless<PHONE_NUMBER>12 is provided as a key in the referenced map:
E1011 '123456789012' is not one of ['222222222222', '333333333333'] for mapping 'AWSAccountsMap'
(You can also get E8005 errors for the same basic reason.)
Expected behavior
The top level key<PHONE_NUMBER>12 should not be required in the map in order for validation to pass.
Reproduction template
AWSTemplateFormatVersion: 2010-09-09
Mappings:
  AWSAccountsMap:
    "222222222222":
      SomeData: lorem
    "333333333333":
      SomeData: ipsum
Resources:
  Bucket:
    Type: AWS::S3::Bucket
    Properties:
      BucketName: !FindInMap [AWSAccountsMap, !Ref AWS::AccountId, SomeData]

Having a similar issue when a key of a map is required for region when it is not needed.

Fixed and released for any Refs to pseudo parameters.


Fix setImmediate call for IE and Edge

Calling setImmediate was throwing an error when invoking it directly.
It produced an "invalid calling object" error. Calling with a .call seems to fix the issue.

Hi @CensoredUser, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft and real humans are currently evaluating your PR.
TTYL, MSBOT;

Calling the method directly should not cause an issue.
You may have a bad shim.


Bug: pr template render undefined error

pull_request.head.repo is None in rendering nonebot/nonebot2#1

simple permission error, change to use user auth token by default and check if permission denied


Add the sourcesContent field to generated source maps

Hello! :wave:
When working with the source maps generated by the polymer-bundler, I realized that although they gave me accurate stack traces, clicking on those traces would bring up a blank source in DevTools. After a bit of research, I leanred that this was because the source maps generated by polymer-bundler lacked a sourcesContent field, which is what DevTools uses to actually render the original source.
I am new to the science behind source maps (and to TypeScript!), so please forgive me if I've made some naive mistakes here.
I also have not yet added tests for this change in functionality, because I couldn't quite figure out how. Again, pardon my lack of experience.
If this is a desired change, then I'd be happy to put some more work into writing tests that cover this change.
Thanks! 🎉

[x] CHANGELOG.md has been updated

Upon further investigation, the root of this issue might be that the path to certain relative sources is being resolved incorrectly. I think that when the path is resolved correctly, the file is automatically loaded from disk into sourcesContent.

Ah nope, this is indeed just a straight up bug. The sourcesContent is dropped from the sourcemap unless it is explicitly carried over each time, like this PR does.

I have added two tests for this. I'm unsure if the route I took is the way that you'd want these to be implemented, but they do seem to do the job (they fail on master, pass on this PR).
The problem described in this comment is still present though, and should be resolved before this PR is merged. I think I need input from a maintainer on how to go about doing that.

@Lange looking at this now

@usergenic I'm having some weird issues unrelated to either of my open pull requests. Is it okay if I DM you on the Polymer slack?

Oh boy, this definitely needs more testing before being merged. I just tried it out when my script was inlined instead of external and the resulting map is pretty wild and off by several lines:

I removed my previous tests and have replaced them with a check that the sourcesContent in every test is an exact match for the actual file on disk. This causes pretty much every test to fail, and reveals that there is more work to be done.

Got it!

This should be good to go, pending review.

sigh Naturally, I have spoken too soon. I've discovered one more case where it will still generate an invalid mapping. Working on it.

@Lange I'm going to merge this into the include-sources-content branch and continue working on this.  Let me know if you have other insights, not-yet-applied.  And thanks again for the patch and great details on this PR.

Hi @usergenic, that sounds good! I don't have any further insights to share at this time -- I've had to focus on other tasks. Thanks!


VSCode Find All References Not Working for Imported Functions

Type: Bug
Description
I am encountering an issue with the 'Find All References' feature in VSCode after updating to the latest version. When I export functions from a module and import them using import * as user from './user', the 'Find All References' feature does not find any references to the functions within the imported module.
Steps to Reproduce

Create a file named user.ts with the following content:
export function method1() {
    console.log('method1');
}

export function method2() {
    console.log('method2');
}

Create a file named api.ts with the following content:
import * as user from './user';

export const api = {
    user
};

Create a file named index.ts with the following content:
import { api } from './api';

api.user.method1();
api.user.method2();

Expected Behavior
The 'Find All References' feature should find all references to method1 and method2 in the user module when invoked on any of these functions.
Actual Behavior
The 'Find All References' feature does not find any references to method1 and method2 in the user module.
Workaround
The issue can be temporarily resolved by exporting an object containing the functions instead of exporting the functions directly. For example, in user.ts, export an object like export const user = { method1, method2 } and then import this object in api.ts and index.ts.

System Info

Item
Value

CPUs
AMD Ryzen 7 7840HS w/ Radeon 780M Graphics      (16 x 3793)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: enabled_ondirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
31.33GB (16.22GB free)

Process Argv
--folder-uri file:///c:/Users/lblbl/i/mosschat-desktop --crash-reporter-id 1e1b7228-e9fd-45d6-931e-c87556e1dd9c

Screen Reader
no

VM
0%

Item
Value

Remote
WSL: Ubuntu

OS
Linux x64 <IP_ADDRESS>-microsoft-standard-WSL2

CPUs
AMD Ryzen 7 7840HS w/ Radeon 780M Graphics (16 x 0)

Memory (System)
15.29GB (13.00GB free)

VM
0%

Extensions (25)

Extension
Author (truncated)
Version

codespaces
Git
1.16.23

remote-containers
ms-
0.369.0

remote-ssh
ms-
0.112.0

remote-ssh-edit
ms-
0.86.0

remote-wsl
ms-
0.88.0

vscode-remote-extensionpack
ms-
0.25.0

remote-explorer
ms-
0.4.3

remote-server
ms-
1.5.1

material-icon-theme
PKi
5.1.0

svg-preview
Sim
2.8.3

JavaScriptSnippets
xab
1.8.0

path-intellisense
chr
2.9.0

vscode-css-modules
cli
0.5.1

vscode-deno
den
3.37.1

prettier-vscode
esb
10.4.0

vscode-expo-tools
exp
1.5.0

copilot
Git
1.208.0

copilot-chat
Git
0.16.1

vscode-pull-request-github
Git
0.90.0

git-graph
mhu
1.30.0

vscode-docker
ms-
1.29.1

vscode-language-pack-zh-hans
MS-
1.90.2024061209

vscode-typescript-next
ms-
5.6.20240629

cssvar
pho
2.6.4

LiveServer
rit
5.7.9

A/B Experiments
vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscorecescf:30445987
vscod805cf:30301675
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
a9j8j154:30646983
962ge761:30959799
pythongtdpath:30769146
pythonnoceb:30805159
asynctok:30898717
pythonregdiag2:30936856
pythonmypyd1:30879173
2e7ec940:31000449
pythontbext0:30879054
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
jchc7451:31067544
dsvsc021:30996838
01bff139:31013167
pythoncenvpt:31062603
a69g1124:31058053
dvdeprecation:31068756
dwnewjupyter:31046869
impr_priority:31082723

I can't reproduce this; Find All References on method1() and method2() in index.ts jumps to the definition in user.ts. I checked in TypeScript 5.4, 5.5, and nightly. Can you try with extensions disabled, and if you're still seeing an issue, can you create a full reproduction I can check out from a GitHub repo?

Was able to reproduce this here https://github.com/requestly/requestly/pull/2361/commits/d20467434c7a7ed0107d118b98b456f3ab177ee9
Workaround seems to be working too


UVI Request

--- UVI JSON ---
{
  "vendor_name": "Linux",
  "product_name": "Kernel",
  "product_version": "versions from v5.7 to before v5.12.13",
  "vulnerability_type": "unspecified",
  "affected_component": "unspecified",
  "attack_vector": "unspecified",
  "impact": "unspecified",
  "credit": "",
  "references": [
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=65038428b2c6c5be79d3f78a6b79c0cdc3a58a41",
    "https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=a1f6740fa3938baa2a45c3dfc53402b78122a8a8"
  ],
  "extended_references": [
    {
      "type": "commit",
      "value": "65038428b2c6c5be79d3f78a6b79c0cdc3a58a41",
      "note": "introduced"
    },
    {
      "type": "commit",
      "value": "a1f6740fa3938baa2a45c3dfc53402b78122a8a8",
      "note": "fixed"
    }
  ],
  "reporter": "joshbressers",
  "reporter_id": 1692786,
  "notes": "",
  "description": "netfilter: nf_tables: initialize set before expression setup\n\nThis is an automated ID intended to aid in discovery of potential security vulnerabilities. The actual impact and attack plausibility have not yet been proven.\nThis ID is fixed in Linux Kernel version v5.12.13 by commit a1f6740fa3938baa2a45c3dfc53402b78122a8a8, it was introduced in version v5.7 by commit 65038428b2c6c5be79d3f78a6b79c0cdc3a58a41. For more details please see the references link."
}
--- UVI JSON ---

This issue has been assigned UVI-2021-1001057


Issue deploying AKS

When we try to deploy AKS using the deployment script, we get this error:
Deployment failed. Correlation ID: d2e47ad2-8acb-4085-bce4-ca29fdd4d256.
{
  "status": "Failed",
  "error": {
    "code": "ResourceDeploymentFailure",
    "message": "The resource operation completed with terminal provisioning state 'Failed'.",
    "details": [
      {
        "code": "DeploymentFailed",
        "message": "At least one resource deployment operation failed. Please list deployment operations for details. Please see https://aka.ms/arm-debug for usage details.",
        "details": [
          {
            "code": "BadRequest",
            "message": "{\r\n  \"error\": {\r\n    \"code\": \"RoleAssignmentUpdateNotPermitted\",\r\n    \"message\": \"Tenant ID, application ID, principal ID, and scope are not allowed to be updated.\"\r\n  }\r\n}"
          }
        ]
      }
    ]
  }
}

I have been trying different solutions, but nothing worked.
Maybe we need to split the template.json for aks and deploy everything one by one, instead of having a template with multiple things.

I've done some small tweaks to the script (was running into some issues) but not having this particular one. I'll be doing a PR shortly.

@sarvaje already fixed this.


[Question] How to customize

Great tool!
Is there a way to customize the files and folders that get created? Or are there instructions on how someone could clone this project, modify the logic, and create their own dotnet tool?

Thanks for the issue.
As of now, the command splits out all folders based on the standard mentioned in README. But in the next release tool will have the minimal options that can be invoked by dotnet-new-project -m. This will create only necessary files and folders like src, tests and others.

Cool. When you say "necessary files", what are the files you are specifying as "necessary"?


Is it possible to use OAuth access tokens to make API calls with this gem?

As the title says, is this possible?
Is there an equivalent to the code below using an OAuth access token?
# Setup authorization
KlaviyoAPI.configure do |config|
config.api_key['Klaviyo-API-Key'] = 'Klaviyo-API-Key your-api-key'
#config.max_retries = 5 # optional
#config.max_delay = 60 # optional
end

There is no official OAuth support for Ruby at the moment. However, you can still override your request header and pass in your access token for authentication. Doing this would look something like this:
require 'klaviyo-api-sdk'
begin
# Setup authorization
KlaviyoAPI.configure

result = KlaviyoAPI::Profiles.get_profiles({
    header_params: {
        'Authorization': 'Bearer YOUR_ACCESS_TOKEN',
      }
})
puts result
end

Awesome!  That should work for me.  Thanks so much.


Support "widths" for needtable

A "widths" option like in csv-table would be nice.

widths: integer [integer...]
A list of relative column widths. The default is equal-width columns (100%/#columns).

Optionally the following would be nice too.

width: length or percentage
Sets the width of the table to the specified length or percentage of the line width. If omitted, the renderer determines the width of the table based on its contents or the column widths.

In general it would be good to avoid too many layout options in a needtable as the needtable deals with data and less with presentation. It would however be nice to maintain a balance between the two as some configuration options might be helpful.
Maybe a style-table option can be added to set a css class for the whole table as well, similar to style-row. This is however really optional as of now.

I like the idea to have more options to somehow define the layout/style of a table.
As the needed table presentation can be highly based on the shown data, I  have no problems with some more options to control the final presentation.
I think the options widths and width can be provided quite easy, as in our backend all needtables get transformed to a default docutils table. So we use the same mechanism as csv-table.
The DataTables based tables may make some trouble, as their config is js-based. So DataTables may override some configs.
For your style-table proposal, I have another, more generic idea.
Most docutils directives provide a generic class attribute, which sets the related css class for this element.
Sphinx-Needs is internally already using it, but right now there is simply no option configured for the user to set this value as well.
I suggest to open a new issue, which asks for :class: support in ALL Sphinx-Needs directives.
The value is comma separated and the element get set additionally to the ones calculated by Sphinx-Needs.
Would such a feature be what you need? (If yes, I will create a new issue for this).
BTW: Currently there are no options to control the layout/configuration of a DataTable based table.
And DataTable has so many nice features / configuration options to use (amount of elements to show, Export types, Collapsed columns, moveable columns).
If you see any needs to improve this as well, let me know :)


How can we help?
I would like someone else to build the manifest.
Please read and ensure the following

[X] The installer meets the above requirements

Please provide the following information
Download Page Url: https://github.com/abbodi1406/vcredist
Publisher: abbodi1406
Package Name: vcredist-aio
Description: AIO Repack for latest Microsoft Visual C++ Redistributable Runtimes
Package Version: 0.73.0
Installer URL: https://github.com/abbodi1406/vcredist/releases/download/v0.73.0/VisualCppRedist_AIO_x86_x64.exe

@AsciiWolf - It seems this package is an All-In-One installer wizard for Microsoft Visual C++ Runtime Redistributable. As they are already presented in this repository, I think it's no need to submit this package ...
--> Installing the Manifest 0.77.0

Found vcredist [abbodi1406.vcredist] Version 0.77.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://github.com/abbodi1406/vcredist/releases/download/v0.77.0/VisualCppRedist_AIO_x86_x64.exe
  ██████████████████████████████  27.5 MB / 27.5 MB
Successfully verified installer hash
Starting package install...
Successfully installed

--> Refreshing environment variables

--> Comparing ARP Entries

DisplayName                                                    DisplayVersion Publisher             ProductCode                            Scope
-----------                                                    -------------- ---------             -----------                            -----
Microsoft Visual C++ 2013 x64 Additional Runtime - 12.0.40664  12.0.40664     Microsoft Corporation {010792BA-551A-3AC0-A7EF-0FAB4156C382} Machine
Microsoft Visual C++ 2022 X64 Minimum Runtime - 14.38.33130    14.38.33130    Microsoft Corporation {1CA7421F-A225-4A9C-B320-A36981A2B789} Machine
Microsoft Visual C++ 2010  x64 Redistributable - 10.0.40219    10.0.40219     Microsoft Corporation {1D8E6291-B0D5-35EC-8441-6616F567A0F7} Machine
Microsoft Visual C++ 2012 x64 Additional Runtime - 11.0.61135  11.0.61135     Microsoft Corporation {37B8F9C7-03FB-3253-8781-2517C99D7C00} Machine
Microsoft Visual C++ 2013 x64 Minimum Runtime - 12.0.40664     12.0.40664     Microsoft Corporation {53CF6934-A98D-3D84-9146-FC4EDF3D5641} Machine
Microsoft Visual C++ 2022 X64 Additional Runtime - 14.38.33130 14.38.33130    Microsoft Corporation {C31777DB-51C1-4B19-9F80-38EF5C1D7C89} Machine
Microsoft Visual Studio 2010 Tools for Office Runtime (x64)    10.0.60915     Microsoft Corporation {C931A1C6-A7BF-3737-874A-818881A37E1B} Machine
Microsoft Visual C++ 2012 x64 Minimum Runtime - 11.0.61135     11.0.61135     Microsoft Corporation {CF2BEA3C-26EA-32F8-AA9B-331F7E34BA97} Machine
Microsoft Visual C++ 2022 X86 Additional Runtime - 14.38.33130 14.38.33130    Microsoft Corporation {5CA9AE7B-2EFC-4F02-81CD-32ABE173C755} Machine
Microsoft Visual C++ 2013 x86 Minimum Runtime - 12.0.40664     12.0.40664     Microsoft Corporation {8122DAB1-ED4D-3676-BB0A-CA368196543E} Machine
Microsoft Visual C++ 2012 x86 Additional Runtime - 11.0.61135  11.0.61135     Microsoft Corporation {B175520C-86A2-35A7-8619-86DC379688B9} Machine
Microsoft Visual C++ 2012 x86 Minimum Runtime - 11.0.61135     11.0.61135     Microsoft Corporation {BD95A8CD-1D9F-35AD-981A-3E7925026EBB} Machine
Microsoft Visual Basic/C++ Runtime (x86)                       1.1.0          Microsoft Corporation {C5E3A69D-D391-45A6-A8FB-00B01E2B010D} Machine
Microsoft Visual C++ 2013 x86 Additional Runtime - 12.0.40664  12.0.40664     Microsoft Corporation {D401961D-3A20-3AC7-943B-6139D5BD490A} Machine
Microsoft Visual C++ 2022 X86 Minimum Runtime - 14.38.33130    14.38.33130    Microsoft Corporation {DF1B52DF-C88E-4DDF-956B-6E7A03327F46} Machine
Microsoft Visual C++ 2010  x86 Redistributable - 10.0.40219    10.0.40219     Microsoft Corporation {F0C3E5D1-1ADE-321E-8167-68EF0DE699A5} Machine

Also when testing in Windows Sandbox, the wizard may cause errors and block the installation process, which will make Azure Pipelines Validation-Unattended-Error.
Screenshots


Remigrating a change_enum_table can leave holes in the ids

If you redo a migration that adds values to an enum table, the IDs don't roundtrip. When the schema file is committed and someone else runs the migrations they'll end up with different ids, and a different schema file.
We should be able to avoid this by finding the max id, and setting the new ids explicitly.

Closing, as this gem is deprecated.


Singleton with setup vs Constructor

Moving our conversation @christopherfujino from the commit to an issue to track better.
The original comment on commit on the lib/src/analytics.dart file: https://github.com/eliasyishak/dash_analytics/commit/595be88c0f94423e26cbec2c7ffd15964ae19341#diff-8959a2a24fd89be63385a1feffed84beb3be8dab70ec527a4d3dcafc938607f6
Current setup
// Setup the singleton
Analytics.setup(...);

// Can call the singleton like this after
// within different classes, files, etc.
final Analytics analytics = Analytics();
final Analytics analytics2 = Analytics();

If we don't want to use a setup static method before calling for the singleton, we will need to change the design of the package so that the analytics singleton is initialized once and passed down to children where analytics events are passed.
With the current setup we can setup once at the entry point and easily import the package's Analytics class anywhere within the codebase so long as the setup has happened before.

It's not clear to me that this:
Analytics.setup(...);

void func1() => Analytics().sendEvent(...);
void func2() => Analytics().sendEvent(...);

is better than:
final Analytics globalAnalytics = Analytics(...);

void func1() => globalAnalytics.sendEvent(...);
void func2() => globalAnalytics.sendEvent(...);

And with the latter there isn't the risk of a runtime error after a code refactor (if you use it wrong, it would be statically detected).

This is more of what I was thinking in the context of sending events related to run times, but I believe this can be applied to events where we send hit counts (how many times we call a function), error reporting, etc.
void main() {

  // Calling this at the entry point will ensure that
  // calling for the singleton with the default constructor
  // will work
  Analytics.setup(...);

  final Child child = Child();
  child.run();
}

// This class doesn't actually need to make any analytics related
// calls so it doesn't need to read in or call for the singleton
class Child {
  Child();

  void run() {
    final GrandChild grandChild = grandChild();
    grandChild.runProcessWithAnalytics();
  }
}

// This is the class that we want to run send analytics from
class GrandChild {
  final Analytics analytics; // **REFACTOR**
  GrandChild() : analytics = Analytics(); // **REFACTOR**

  void runProcessWithAnalytics() {
    final DateTime start = DateTime.now();
    // Some code here to run

    // This could be how long `runProcessWithAnalytics` takes to run for example
    final int millisecondsRun = DateTime.now().difference(start).inMilliseconds
    analytics.sendEvent(millisecondsRun, ...);
  }
}

With this approach there would be less refactoring because I don't need to pass the analytics singleton class from the entry point where it was initialized down to the GrandChild class to send the event, it can just be called for when the GrandChild is being created with the default constructor.
In the context of flutter-tools we can initialize this class near the entry point and maybe send it to globals where it can be referenced, but I didn't want to assume other dash tooling had a globals-like configuration; I also thought we wanted to move away from adding more to globals.
If this is not desirable, then we can change to this approach below, I just wanted to illustrate what I was thinking when designing the approach for this package.
void main() {

  // We can delete the `setup` constructor and have all logic
  // handled within the default constructor for setup
  final Analytics globalAnalytics = Analytics(...);

  final Child child = Child(analytics=globalAnalytics); // **REFACTOR**
  child.run();
}

// This class doesn't actually need to make any analytics related
// calls so it doesn't need to read in the singleton
class Child {
  final Analytics analytics; // **REFACTOR**
  Child({required analytics}); // **REFACTOR**

  void run() {
    final GrandChild grandChild = grandChild(analytics=analytics); // **REFACTOR**
    grandChild.runProcessWithAnalytics();
  }
}

// This is the class that we want to run send analytics from
class GrandChild {
  final Analytics analytics; // **REFACTOR**
  GrandChild({required analytics}); // **REFACTOR**

  void runProcessWithAnalytics() {
    final DateTime start = DateTime.now();
    // Some code here to run

    // This could be how long `runProcessWithAnalytics` takes to run for example
    final int millisecondsRun = DateTime.now().difference(start).inMilliseconds
    analytics.sendEvent(millisecondsRun, ...);
  }
}

So in the above examples, the first had 2 refactor points, while the second had 6, which I would expect to be significantly more in actual production code with far more nested children classes.

Your second example above could be written:
final Analytics globalAnalytics = Analytics(...);

void main() {
  final Child child = Child();
  child.run();
}

class Child {
  Child();

  void run() {
    final GrandChild grandChild = grandChild();
    grandChild.runProcessWithAnalytics();
  }
}

class GrandChild {
  GrandChild();

  void runProcessWithAnalytics() {
    final DateTime start = DateTime.now();
    // Some code here to run

    globalAnalytics.sendEvent(millisecondsRun, ...);
  }
}

I'm not saying that we should do it this way (I would prefer explicit direct injection, which is what https://github.com/flutter/flutter/issues/47161 is all about), but I'm saying this would avoid an explicit call to Analytics.setup(), and referencing the global variable globalAnalytics is roughly equivalent to calling a factory constructor that really only returns a singleton. If that singleton requires explicit setup, why use a factory that makes the user think they're constructing their own local instance?

In the context of flutter-tools we can initialize this class near the entry point and maybe send it to globals where it can be referenced, but I didn't want to assume other dash tooling had a globals-like configuration;

The first approach above (the way commit https://github.com/eliasyishak/dash_analytics/commit/595be88c0f94423e26cbec2c7ffd15964ae19341 is currently written) is essentially grabbing a global value that tests can't override anyway, so they it would be roughly equivalent to just make it a global variable--no special setup needed.

I also thought we wanted to move away from adding more to globals.

We are never going to avoid having global values, what we are trying to avoid is using context.get() in favor of direct injection because it forces a developer writing tests to know about and provide dependencies in their tests, where they can explicitly provide hermetic versions. The problem we're trying to avoid is non-obvious calls to global values.

Hmm that's a great point, I do like having the class getting setup in the global scope so it would be very easy to reference it within different classes in different files. Let me refactor and open a new PR. I like your approach

Closing after approval on https://github.com/eliasyishak/dash_analytics/pull/3


Convert ids to bigints

It's extremely unlikely that we'll reach the limits of 32-bit integers but ensure that it's compatible with Rails defaults.

Ugh, wrong repo

Ugh, wrong repo


Update whu-thesis-doc.tex: Typo fixed

Typo fixed.
There is typo in the whu-thesis-doc.tex: 'secrete' should be corrected to 'secret'.

我看看是谁当年拼错的
哦，是我


[DOCS]

Proposal for:

Footer component page
Usage header content
Under the following content

The footer must be used at the bottom of every page. It is separate from the primary navigation but is relevant to the entire site.

Add bullet points to specify:

By default, the primary navigation menu links will be reflected to the footer
Additional sectional links can be added to the footer section


Fix incorrect comment about auth type

When I am trying to write a customized access controller, I found this comment does not make any sense, I guess it was copied from the storage part most probably.

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:
$ git clone -b "comment-fix" git@github.com:zhouhaibing089/distribution.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

[Current coverage][cc-pull] is 54.72%

Merging [#1773][cc-pull] into [master][cc-base-branch] will decrease coverage by 6.89%

3 files (not in diff) in ...istry/storage/driver were modified. more

Misses +807
Partials -92
Hits -715

1 files (not in diff) in registry were modified. more

Misses +6
Hits -6

@@             master      #1773   diff @@
==========================================
  Files           120        120
  Lines         10455      10455
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           6442       5721   -721
- Misses         3418       4231   +813
+ Partials        595        503    -92

[][cc-pull]

Powered by Codecov. Last updated by [feddf6c...fc9aa2f][cc-compare]
[cc-base-branch]: https://codecov.io/gh/docker/distribution/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/docker/distribution/compare/feddf6cd4e439577ab270d8e3ba63a5d7c5c0d55...fc9aa2f351c9f780b77ebada9d87f098d1ebd3ba
[cc-pull]: https://codecov.io/gh/docker/distribution/pull/1773?src=pr

LGTM

LGTM


Snap version takes a lot to cold start => use LZO compression

Expected Behavior
Insomnia (snap) should start without noticeable delay.
Actual Behavior
Insomnia (snap) takes 5/10 s to start.
Reproduction Steps

(Install Insomnia using snap)
Launch Insomnia for the first time (forever or in that session)
Insomnia will take some seconds to start.

Is there an existing issue for this?

[X] I have searched the issue tracker for this problem.

Additional Information
It could be built using LZO compression, which it's known to greatly reduce initial startup times: https://forum.snapcraft.io/t/how-to-switch-your-snap-to-use-lzo-compression/21714
Insomnia Version
2021.7.2
What operating system are you using?
Ubuntu
Operating System Version
21.10
Installation method
Snap
Last Known Working Insomnia version
2021.7.2

Hi @santiagofn, thank you for reporting this.
We'll try to evaluate using this compression as an option, and we've spinned up a proof of concept PR - https://github.com/Kong/insomnia/pull/4774
We'll update you if there's any changes or news regarding this.


Improve handling of tracks with no album or artist tags

This enhancement improves upon issue #1 - specifically to sort tracks without an album tag.
For tracks that lack both album and artist tags, they should be placed somewhere, rather than not be acted on.
Relevant lines in question: https://github.com/cj-wong/sorter-gpm-takeout/blob/ff6dd665177629633397c8e53809d595c7b2b498/sorter/sorter.py#L63-L70
This may also fix KeyErrors with the current try: except KeyError: block, but I am uncertain.
Things to do with this issue:

Check each tag for emptiness along with the try: block. (Not sure if eyed3 treats literal empty tags as missing.)
If a tag doesn't have an album or artist tag, move it to a separate directory. (Something like dest/no_tags, where dest is the destination directory root, will do.)

It turns out that KeyError may never be raised here. self.metadata['album'] will always be set, even if set to None. Currently, ValueError can be caught, though, if the tag is empty.


Add Pre-Commit Hook to run Coverage 100% Check and send lcov report to CodeClimate

As usual. 100% ;-)
see: https://github.com/docdis/learn-pre-commit

[![Build Status][travis-image]][travis-url]

done.


Improve doc dev

Coverage remained the same at 79.977% when pulling a67f9a3d632fa365af909bdfff640011da5e5cb7 on improve-doc-dev into b8b38d2f39cd30558d53916278d94724570b29a7 on development.


[bug][langchain] errors cause the trace tree to be not rooted on the correct span

Reproducible via ragas execution

This is actually related to threading #306 and requires further investigation


updates to config.py are not being recognized

@nickmhc on Discord
pasted Bossland hash key straight into the config.py so it's guaranteed accurate, but scan.py is not using it
Also changed map_start and map_end and those changes aren't being recognized

have you moved the config.py to the pokeminer dir?
or to do you have the BOUNDARIES set?

I've moved config.py into the pokeminer subdirectory. The only way to change the config on my 2011 15-inch MacBook Pro (http://www.everymac.com/systems/apple/macbook_pro/specs/macbook-pro-core-i7-2.4-15-late-2011-unibody-thunderbolt-specs.html) MacOS Sierra Version 10.12.2 (16C67) is to delete pokeminer altogether and re-clone it, then put the updated config.py into pokeminer/pokeminer

Did you install it as a package (with setup.py)? If so, that currently installs the config as well so maybe it is still finding the packaged config in site_packages? Though if you're launching it from the Monocle directory, I think the relative files should override the package.
If you didn't, I would just make sure that you're updating the config.py in REPODIR/monocle, not anywhere else, and not config.py.example.

I am having an issue where I moved the map_start & map_end points however the gridbox remains at the old location. Workers are scanning the new location. Here are my settings:
GRID = (4, 4)  # rows, columns
MAP_START = (38.9091,-76.9946)
MAP_END = (38.8301,-76.8525)
#STAY_WITHIN_MAP = True
BOOTSTRAP_RADIUS = 70
from shapely.geometry import Polygon
BOUNDARIES = Polygon(((38.94419015967061,-76.86275482177734), (38.87018642754998,-76.84696197509766), (38.82366088659335,-76.89159393310547), (38.80868067783546,-77.01484680175781), (38.85815687709717,-76.99974060058594), (38.87980860240197,-76.9588851928711), (38.915345894806585,-76.9266128540039), (38.93110486348425,-76.91768646240234), (38.94285503599089,-76.90635681152344)))


all: fix GetPriorityClass with default

Ⅰ. Describe what this PR does

Koordinator is using PriorityClass to make a lot of logical judgments, which need to consider compatible scenarios (default value)
Renamed GetPriorityClass and GetQoSClass at the same time to avoid misuse

/lgtm
/approve


cuda out of memory error

I am getting cuda out of memory error, while testing UNet_RLP_RPIM model you have given, when ruuning in collab. Can you suggest some methods to overcome it ? Also, what file directory we have to give to test the images(gt or rainy)?

Hi, could you provide more details about your testing setting in colab? Normally, it will occupy less than 12GB VRAM for UNet_RLP_RPIM to inference on 1080p images with batch_size = 1. You may reduce inference batch size to 1 to see if it works.
BTW, I am not sure what you mean by last, if I am right, the file directory you give is the root folder that contains both gt and rainy.


Typo Corrections in README.md

Description of changes
Correction in Overview section
"users's"
Incorrect: match a users's name
Corrected: match a user's name
Corrections in FAQ Section
"an built-in"
Incorrect: an built-in authorization policy framework...
Corrected: a built-in authorization policy framework...
"Elasitc"
Incorrect: Amazon Elasitc Kubernetes Service (EKS)
Corrected: Amazon Elastic Kubernetes Service (EKS)
"Enforcment"
Incorrect: that illustrates this is an enforcment
Corrected: that illustrates this is an enforcement

Actually, I noticed the wrong spellings of enforcement while I was taking a note. Then, asked gpt to find other mistakes, so that all typo mistakes in Readme are fixed in one PR.


Fixed links

Pull Request Test Coverage Report for Build 569

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.45%

Totals

Change from base Build 568:
0.0%

Covered Lines:
2116

Relevant Lines:
3233

💛  - Coveralls