Update fails on moved files, without clear error messages.

I ran a cruft update from current rev to a more recent tag. The update failed, modifying only .cruft.json. No .rej files are present and the error message does not, as far as I can tell, indicate which file the problem occurred with. The output is attached in a file (because its contents contains markdown that confuses the display of this issue.
Ideally:

The merge doesn't fail. This not addressable in general, and since this isn't an open source cookiecutter I can't share the specific steps to reproduce at the moment.
The error message about the diff / merge more clearly indicates which files have an issue.
If the merge fails, the merge failures are present.
If the merge fails, the output doesn't say 'Good work! Project's cruft has been updated and is as clean as possible!' in green.

Maybe some debugging functionality would help. It might be useful to:

Preserve the downloaded cookiecutter-recipe repos, old and new, on which which the diff is produced.
Be able to run locally on from those old/new repos to help understand what diff is causing merge to fail.
Have a verbose mode that would clearly print relevant directories, git commands etc.

I think the diff should be preserved as a file, optionally or automatically if the apply fails.
Once I manually modified the code to do that, it easy to isolate the problem, which was that git apply was failing on files that had moved between two commits. I assume there's not magic git command to solve that (and all other potential problems with an apply), so to ease troubleshooting, it would be nice if:

The diff was preserved in a file, at least optionally, and/or if an error is detected in applying it.
If the merge fails, cruft does not say 'Good work!' in green, but gives an error (red would be nice).
If the merge succeeds, but manual merges are necessary, not say 'Good work!' in green, but gives a warning (yellow would be nice).
There was verbose mode that reported in a bit more detail what cruft was doing (for example, printing the git commands).

These perhaps should be 4 separate issues.

I also ran into this issue. I used git mv to move/rename a file in the template.
When updating the project with the newest version of the template, the file is only removed in the old location, but not re-created in the new location. So, instead of being renamed, it is effectively deleted.


Semantics of storm.Update ?

Hi there,
The Update() method fails for me and I'm not sure if I'm missing some obvious semantics.
I have the following unit test method added to store_test.go
`
func TestUpdateSpecial(t *testing.T) {
db, cleanup := createDB(t)
defer cleanup()
type User struct {
	ID        int    `storm:"id,increment"`
	Email     string `storm:"unique"`
	Password  []byte
	IsAdmin   bool
	IsDeleted bool
}

err := db.Save(&User{
	ID:        0,
	Email<EMAIL_ADDRESS>	Password:  []byte{1, 2, 3, 4, 5},
	IsAdmin:   false,
	IsDeleted: true})
assert.NoError(t, err)

u2 := User{
	ID:        1,
	Email<EMAIL_ADDRESS>	Password:  []byte{6, 7, 8, 9},
	IsAdmin:   false,
	IsDeleted: false}

err = db.Update(&u2)
assert.NoError(t, err)

var u User
err = db.One("ID", 1, &u)
assert.NoError(t, err)
assert.Equal(t, u.IsDeleted, u2.IsDeleted) // fails here, u2 did not get saved in the db

}
`
what am I missing?
Thank you in advance.

Save can be used to store a new version of your object under the same ID. Save actually replaces the entire record with the new one.
u := User{
  Email<EMAIL_ADDRESS>  Password:  []byte{1, 2, 3, 4, 5},
  IsAdmin:   false,
  IsDeleted: true}

err := db.Save(&u)

u.Password = []byte{6, 7, 8, 9}
u.IsDeleted = false

err := db.Save(&u)

Update only updates fields with non-zero values. It should be used only to update some fields.
Example:
db.Update(&User{ID: 1, Password: []byte{6, 7, 8, 9}, Email<EMAIL_ADDRESS>
If you need to update zero values, you can use the UpdateField method.
db.UpdateField(&User{ID: 1}, "IsDeleted", false)

Cool. Thank you for the explanation.

Is this still true? "Save can be used to store a new version of your object under the same ID."
I get ErrAlreadyExists when I call Save for an existing id. And that calls for Upsert support that I don't yet see.

I get ErrAlreadyExists when I call Save for an existing id
Can you provide an example please ?

And that calls for Upsert support that I don't yet see.
Yes this would be interesting 👍

My mistake... in writing the test I see that the ErrAlreadyExists is caused by a unique index constraint.
So given the current Save semantics, no Upsert is necessary since Save is already that.


Support rpcserver & fix invoke_method

The PR is mainly for

Support RPCServer trait similar to the PR
Add the missing &self to the invoke_method
Fix the wrong validation function for validate_sink

LGTM other than this potential addition.


After compilation, only the library file has no header file

execute:
cmake -Bbuild -G "MinGW Makefiles" -DKOMPUTE_OPT_DISABLE_VULKAN_VERSION_CHECK=ON -DKOMPUTE_OPT_BUILD_AS_SHARED_LIB=OFF
cd build
mingw32-make.exe -j14
result:
There are library files, but no header files. Execute 'mingw32 make. exe install' prompt:
CMake Error at src/cmake_install.cmake:45 (file):
file INSTALL cannot find
"C:/Project/GCC/AI/pack/kompute/build/kompute/komputeConfigVersion.cmake":
File exists.
Call Stack (most recent call first):
cmake_install.cmake:52 (include)
mingw32-make: *** [Makefile:99: install] Error 1

@ZhangXiChang what are you building atm? Is it one of the examples or your own project? If you can provide more details this can be explored further - for completeness the headers are in the include folder

Having a similar issue on Ubuntu 22.04 with install to /usr/local/lib
during make install getting this
CMake Error at src/cmake_install.cmake:50 (file):   file INSTALL cannot find   "/home/user/Libraries/kompute/build/kompute/komputeConfigVersion.cmake":   No such file or directory. Call Stack (most recent call first):   cmake_install.cmake:57 (include)
just using basic options for building
cd kompute
mkdir build && cd build
cmake ..
make -j4
sudo make install

I have met same issue too on windows with MSVC and clang, and on archlinux with gcc and clang. There's some thing wrong with its cmake script, I will try to fix it.


en-GB-ify LICENCE

Since our style guide says "use British English", let's actually do so:

"licence" is spelled with a "C" when it's a noun, or when it is used as an adjective referring to an instance or type of licence;
"adaptor" (being a person or device) is spelled with an "-or" suffix;
add a note that the linked version on the creativecommons.org is in US English (and therefore differs from this version).

In this instance I'd say it's better to use established conventions and the verbatim license text as published by their respective sources.
The style guide is intended for editorial content that goes in the repo such as documentation and blog posts not for the licenses or say code where certain words may have defined meaning with one spelling but not the other (good luck replacing all css color attributes with colour)

Yeah fair point.
Perhaps the style guide could mention this?
I have no intention or desire to modify keywords in other languages (such as "color" in CSS or "Referer" in HTTP); I simply read them as "not English".
However I suggest that 9fcee67 be cherry-picked (and adjusted) as a intra-site links should be site-relative whenever possible.


Update item.tsx to detect if ion-item is clickable

Short description of what this resolves:
Currently, the ion-item component does not by default show the detail arrow if in ios mode and the onclick attribute is present. If the item is clickable and in ios mode, the arrow should appear on the right side of the ion-item.
Changes proposed in this pull request:
Correct the item.tsx file to look for the onclick attribute and show the arrow when clickable
Ionic Version:
4.1.1
Fixes: #
No bug created currently

Thanks for the PR! So the reason we didn't do this and instead added the button attribute is because users could add an event listener to listen to a click and we couldn't find a way to grab that event listener. While I see the purpose of adding this, I'm not sure that we want to make it only cover certain cases as it may be more confusing that you would only add the button attribute when you're using an event listener. See the following SO post: https://stackoverflow.com/questions/11455515/how-to-check-whether-dynamically-attached-event-listener-exists-or-not

@brandyscarney The documentation for ion-item is not correct then:
"If true, a detail arrow will appear on the item. Defaults to false unless the mode is ios and an href, onclick or button property is present."
Without this check, the details arrow doesn't show by default when in ios mode and an "onclick" is present.

@jayordway Correct. I believe that documentation was correct at one point until we realized it was confusing that it didn't work for event listeners. I'm all for ideas on how we can improve this. Maybe we just document that adding a click event listener won't automatically convert the item to a button but make the more common use case (click attributes) automatically use a button?
Thoughts @liamdebeasi ?

I agree with correcting the documentation, otherwise folks will be confused when using onclick and ios, while not seeing the detail arrow.

Yep, that sounds right. There isn't a clean way of detecting click events for vanilla JS as well as all frameworks. We should update the documentation to make this clearer.

Hi there,
I created a PR that updates the documentation to highlight the correct detail property usage: https://github.com/ionic-team/ionic/pull/17861
Feel free to comment on it with any feedback you may have.
Thanks!

Hi there,
The detail property usage changes have been merged (https://github.com/ionic-team/ionic/pull/17861), so I am going to close this.
Thank you for all of your work on this - we appreciate it!


CORS not enabled?

Did a change happen recently that disabled CORS? I was planning to use this data in a demo at a conference this week. The conference is unrelated to SpaceX, NASA or space in general... just a tech conference and thought it was a cool dataset.
But suddenly seeing errors related to CORS. The response headers look very different too... looking back through the commits I don't see anything that says CORS was disabled.

Nope, still enabled!
Here's the code.

Damn... you responded too quick (I was just about to delete the issue I submitted).
My bad... stoopid error on my part. Thanks for making this available!

@andrewconnell Glad it's resolved. Haven't touched the CORS support since it was enabled a few weeks ago. What fixed it?
I'd love to help & contribute to the project, but I don't know Ruby :-/ Will keep an eye out for ways I can help...

No worries! If you have any suggestions or ideas, I'm sure we can find something for you to help out with. 👍


Get function UserQueryDevices

When the list flag is True the get function returns only ids :

Should the id_device_type be included in the list ? (i.e. remove the id_device_type in the ignore fields in TeraDevice in line 56) since the id_device_subtype is present?

@arsp2701 , yes remove id_device_type from ignore_fields.


Load custom assembly to ASP .NET Core 2.0 project

From @troncomputers on August 30, 2017 7:7
From @troncomputers on August 29, 2017 9:26
Hi!
I'm trying to load custom assembly (nip24Library.dll). This is the C# API for finding companies by VAT Number in Poland.
FileNotFoundException: Could not load file or assembly 'nip24Library, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=a3a1b0bb1b99a109'. Can not find the specified file.

VS added for me this entry to .csproj file
  <ItemGroup>
    <Reference Include="nip24Library">
      <HintPath>C:\OptimoKasiarz\OptimoKasiarz\bin\Debug\netcoreapp2.0\nip24Library.dll</HintPath>
      <Private>true</Private>
    </Reference>
  </ItemGroup>

It looks like the web app doesn't know where this file is. How can I solve this problem?
Copied from original issue: aspnet/Home#2171
Copied from original issue: dotnet/corefx#23678

From @troncomputers on August 30, 2017 7:7
From @Tratcher on August 29, 2017 17:23
You should move this to https://github.com/dotnet/corefx.

From @karelz on August 30, 2017 17:28
Do you have a minimal repro?
Did you try to load the DLL into Console app? Does that work?

From @troncomputers on August 31, 2017 7:20
@karelz Works fine with workaround with Visual Studio
@tarekgh I don't know how. You can download it from here:
nip24Library
PS. "Pobierz" means "Download" ;)
As far as I know I'd use this workaround:
    public class ReferencesMetadataReferenceFeatureProvider : IApplicationFeatureProvider<MetadataReferenceFeature>
    {
        public void PopulateFeature(IEnumerable<ApplicationPart> parts, MetadataReferenceFeature feature)
        {
            var libraryPaths = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
            foreach (var assemblyPart in parts.OfType<AssemblyPart>())
            {
                var dependencyContext = DependencyContext.Load(assemblyPart.Assembly);
                if (dependencyContext != null)
                {
                    foreach (var library in dependencyContext.CompileLibraries)
                    {
                        if (string.Equals("reference", library.Type, StringComparison.OrdinalIgnoreCase))
                        {
                            foreach (var libraryAssembly in library.Assemblies)
                            {
                                libraryPaths.Add(Path.Combine(AppDomain.CurrentDomain.BaseDirectory, libraryAssembly));
                            }
                        }
                        else
                        {
                            foreach (var path in library.ResolveReferencePaths())
                            {
                                libraryPaths.Add(path);
                            }
                        }
                    }
                }
                else
                {
                    libraryPaths.Add(assemblyPart.Assembly.Location);
                }
            }

            foreach (var path in libraryPaths)
            {
                feature.MetadataReferences.Add(CreateMetadataReference(path));
            }
        }

        private static MetadataReference CreateMetadataReference(string path)
        {
            using (var stream = File.OpenRead(path))
            {
                var moduleMetadata = ModuleMetadata.CreateFromStream(stream, PEStreamOptions.PrefetchMetadata);
                var assemblyMetadata = AssemblyMetadata.Create(moduleMetadata);

                return assemblyMetadata.GetReference(filePath: path);
            }
        }
    }

and in Startup.cs
            services.AddMvc().ConfigureApplicationPartManager(manager =>
            {
                var oldMetadataRefernceFeatureProvider = manager.FeatureProviders.First(f => f is MetadataReferenceFeatureProvider);
                manager.FeatureProviders.Remove(oldMetadataRefernceFeatureProvider);
                manager.FeatureProviders.Add(new ReferencesMetadataReferenceFeatureProvider());
            });

It's working now when I launch app from Visual Studio, not working after publish and open from IIS server. On page where I'm using nip24 I'm getting HTTP ERROR 500
[EDIT] Fix C# syntax highlight by @karelz

@troncomputers How nip24Library.dll is built?
CC @weshaggard @ericstj

From @ericstj on August 31, 2017 17:33
@eerhardt it would seem that this direct file reference isn't making it into the deps file.
@troncomputers it'd be good if you can provide an isolated repro solution that demonstrates this.
Also, I hate to suggest to move again, but I think this belongs in dotnet/sdk repo, but we can wait until we confirm that.

From @karelz on August 31, 2017 16:0

Works fine with workaround with Visual Studio

@troncomputers what does it mean? Console app? Please provide more details on what works.
Note that if this is ASP.NET specific, this is not the right repo and we might need to reopen the one in ASP.NET repo. By creating small repro, you will help us identify which components is causing troubles.

I couldn't repro this issue with simple netcoreapp 2.0 console app. I have referenced nip24Library.dll exactly as mentioned above and the app load it just fine.
NetCoreConsoleApp.zip
We'll not be able to help here without providing a simple repro project

From @troncomputers on September 1, 2017 9:56
It is NOT a console app. It's ASP .NET Core web app. Just create a Web Application project with ver. ASP .NET Core 2.0 and add nip24library.dll to reference and try to build/run/compile.
InvalidOperationException: Cannot find compilation library location for package 'nip24Library'
Microsoft.Extensions.DependencyModel.CompilationLibrary.ResolveReferencePaths(ICompilationAssemblyResolver resolver, List<string> assemblies)
Microsoft.Extensions.DependencyModel.CompilationLibrary.ResolveReferencePaths()
Microsoft.AspNetCore.Mvc.ApplicationParts.AssemblyPart+<>c.<GetReferencePaths>b__8_0(CompilationLibrary library)
System.Linq.Enumerable+SelectManySingleSelectorIterator.MoveNext()
Microsoft.AspNetCore.Mvc.Razor.Compilation.MetadataReferenceFeatureProvider.PopulateFeature(IEnumerable<ApplicationPart> parts, MetadataReferenceFeature feature)
Microsoft.AspNetCore.Mvc.ApplicationParts.ApplicationPartManager.PopulateFeature<TFeature>(TFeature feature)
Microsoft.AspNetCore.Mvc.Razor.Internal.DefaultRazorReferenceManager.GetCompilationReferences()
System.Threading.LazyInitializer.EnsureInitializedCore<T>(ref T target, ref bool initialized, ref object syncLock, Func<T> valueFactory)
Microsoft.AspNetCore.Mvc.Razor.Internal.DefaultRazorReferenceManager.get_CompilationReferences()
Microsoft.AspNetCore.Mvc.Razor.Internal.LazyMetadataReferenceFeature.get_References()
Microsoft.CodeAnalysis.Razor.CompilationTagHelperFeature.GetDescriptors()
Microsoft.AspNetCore.Razor.Language.DefaultRazorTagHelperBinderPhase.ExecuteCore(RazorCodeDocument codeDocument)
Microsoft.AspNetCore.Razor.Language.RazorEnginePhaseBase.Execute(RazorCodeDocument codeDocument)
Microsoft.AspNetCore.Razor.Language.DefaultRazorEngine.Process(RazorCodeDocument document)
Microsoft.AspNetCore.Razor.Language.RazorTemplateEngine.GenerateCode(RazorCodeDocument codeDocument)
Microsoft.AspNetCore.Mvc.Razor.Internal.RazorViewCompiler.CompileAndEmit(string relativePath)
Microsoft.AspNetCore.Mvc.Razor.Internal.RazorViewCompiler.CreateCacheEntry(string normalizedPath)
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
System.Runtime.CompilerServices.TaskAwaiter.GetResult()
Microsoft.AspNetCore.Mvc.RazorPages.Internal.DefaultPageLoader.Load(PageActionDescriptor actionDescriptor)
Microsoft.AspNetCore.Mvc.RazorPages.Internal.PageActionInvokerProvider.OnProvidersExecuting(ActionInvokerProviderContext context)
Microsoft.AspNetCore.Mvc.Internal.ActionInvokerFactory.CreateInvoker(ActionContext actionContext)
Microsoft.AspNetCore.Mvc.Internal.MvcAttributeRouteHandler+<>c__DisplayClass12_0.<RouteAsync>b__0(HttpContext c)
Microsoft.AspNetCore.Builder.RouterMiddleware+<Invoke>d__4.MoveNext()
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware+<Invoke>d__7.MoveNext()

From @eerhardt on September 1, 2017 14:41
Yes, the error
InvalidOperationException: Cannot find compilation library location for package 'XXX'
where XXX is an assembly with a direct <Reference> in your .csproj is tracked by https://github.com/dotnet/core-setup/issues/2981.  The workaround provided by @pranavkm at https://github.com/pranavkm/fix-ref/commit/1b83ca58ce88f72d4e9ccdeab892afad77a5d295 should solve this issue until we can get a service release fix for it.
BTW - I don't think the fix will make it for 2.0.1, as we didn't have time.  Instead, I think it will make it for 2.0.2.

From @ericstj on September 1, 2017 14:12
I believe this is the same as https://github.com/dotnet/sdk/issues/1500, https://github.com/dotnet/core-setup/issues/2981.  It looks like it's already being tracked for a fix in 2.0.1.

From @troncomputers on September 2, 2017 22:23
Was Microsoft plannig to support only nuget packages for asp net core web pages or it is just a bug with new technology?

NuGet packages are certainly the best way to add references to other DLLs because they are better integrated with the build and publish process.
Having said that, the issues mentioned earlier are indeed bugs that we are planning to have fixes in upcoming patch releases.


Panic Button

When using really long bpms (I typically used 1 or less...), the "stop" button won't stop the sound until the clock has run out on the beat! MIDI people are used to a "panic button"  and something like that would be good here.
Other forms of setting the time like msecs:nnn or secs:nn would be nice too.

Ah good point, I can definitely add this.
For setting the time, do you mean setting the position of the playhead, setting the position of a note, or setting the duration of a note, or multiple of those / something else?

While I haven't added a panic button per se, I've made the stop button stop the audio rather than just the playhead in 1.2.0. I may reopen if the need for a panic button arises in future, but what I have here should negate the need according to tonejs.

Thanks!


Support for multiple keys

This PR introduce support for multiple keys. The config structure is a bit different now:
  keys:
  - key: <key1>
  - key: <key2>

Where each key line provides a single key (gpg or plain text)
Example:
gpg: false
datacenters:
- hosts:
  - name: vault1.test
    port: 8200
  - name: vault2.test
    port: 8200
  - name: vault3.test
    port: 8200
  keys:
  - key: oJLvra8jHVbrjgSvudT9L2N8H9hz5TQ3lCXfclCQDLqm
  - key: h4jg+tSLI2L9RctbrbFC/JJTwkMBStFjMkHv5qso2I9D
  - key: IQXWLnEkBmNIP1D35Xir9iwsDQKOCie5WHsPkTEuPX21
  - key: Pp9lCx93AkzgZu7Vs2svy5bm/BhKP8sdxxfHOKDMZi1Z
  - key: 15kWjOLypUDdaABE/nCvs9/UzzlUEs/SCTQrakLkthld
  name: dc

Tested scenarios:

unseal Vault cluster (GPG/plain text keys)
rekey Vault

This PR fix https://github.com/jaxxstorm/hookpick/issues/18

I'm a bit concerned about this.
Unless I'm reading it wrong, it seems that this model is making the assumption a single user holds multiple keys (whether they be GPG encrypted or in plaintext). This begs the question: How are you using vault in this model? Is it a single user with ALL the vault keys, or does each user get multiple keys and they have to provide several?

Hi @jaxxstorm
Thanks for your questions. Single user may or may not holds all keys. My PR add an option for multiple keys but it is not required to provide all keys.
Few scenarios I saw so far:

multiple users, everyone with a single key, you need 2+ to unseal,
multiple keys per person (but not all keys) - eg.: shared one and private one per team member. Single person can unseal Vault but keys are distributed in 2 different ways (eg.: 2 different GPG priv keys). You still need to provide more than just a single string but single person can unseal Vault.
every team member keeps all keys

Overall it's a matter what is your threat model, it might be important to provide all necessary tools to Ops person so he react on incident without another key holder.

Okay, that makes sense. I'll merge this and then release in a major version, as the config file format changes. Thanks for the contribution!


Watch the template and referenced files, and update output every time there's a changes

Like Sass has the following feature
sass --watch input.scss:output.css

I think this would be handy if there's support for Latex (#31).

Template watching sounds pretty useful, but I think it should be defaulted off. If the output files are malformed because the template was saved with an error (not even a jinja error necessarily), nasty things could happen. It depends on what the output files are for.


Make main the default branch

Can we make the default branch to main so it matches most of our other repos?
Any objections?

I tripped over this on Monday, very supportive of this proposal


Racer does not autocomplete functions with lifetime parameters

In the code sample below, placing the cursor at the marked point will suggest the field and method called catalog, but won't suggest validate as a method. Removing the lifetime parameter completely will cause the method to appear, and adding it back causes it to disappear from the suggestions again.
pub struct Anvil<C: Catalog> {
    catalog: C,
}

impl<C: Catalog> Anvil<C> {

    /// Creates a new validator with the specified metric and function catalog.
    pub fn new(catalog: C) -> Self {
        Anvil { catalog: catalog }
    }

    pub fn catalog(&self) -> &C {
        &self.catalog
    }

    pub fn validate<'i>(&self, expr: &'i Expression) -> AnvilResult<'i> {
        use ::ast::Expression::*;
        match *expr {
            Constant(_) => Ok(ExprReturnType::Constant),
            Interval(_) => Ok(ExprReturnType::Interval),
            Metric(ref m) => self.metric(m),
            Function(ref fc) => self.function(fc),
            Binary(ref op) => self.binary(op),
        }
    }

    pub fn example(&self) {
        &self. // AUTOCOMPLETE HERE
    }

I can not reproduce this fault on the latest commit on master

I just ran cargo install racer --force and I'm still seeing a repro of this.

@TedDriggs the latest racer hasn't been published to crates.io, yet. I'm not saying it's fixed, just that you and @andjo403 are running different versions.

@TedDriggs a new version was published, can you try this again?

This now works; thanks for the fix!


Update schema

@type to an enumerated object
consolidate dataset/computational tool descriptions when the property is shared
add in missing  property descriptions for nested objects like input.description
might be good to have emily and/or you do a quick skim of whether the descriptions make sense

Related to #135


Bump the PMD version used by the plugin to 5.5.4

Context
To benefit from the fix for https://github.com/pmd/pmd/issues/232.
Contributor Checklist

[x] Review Contribution Guidelines
[x] Sign Gradle CLA
[ ] Link to Design Spec for changes that affect more than 1 public API (that is, not in an internal package) or updates to > 20 files
[ ] Provide integration tests (under <subproject>/src/integTest) to verify changes from a user perspective
[ ] Provide unit tests (under <subproject>/src/test) to verify logic
[ ] Update User Guide, DSL Reference, and Javadoc for public-facing changes
[x] Ensure that tests pass locally: ./gradlew quickCheck <impacted-subproject>:check

Gradle Core Team Checklist

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation including proper use of @since and @Incubating annotations for all public APIs
[ ] Recognize contributor in release notes

Closing for now as the referred issue does not really seem to have been fixed in PMD 5.5.4.

Sorted it out, PMD 5.5.3 indeed does fix the original issue mentioned in https://github.com/pmd/pmd/issues/232.

Looks like there's already a newer version: 5.5.5. https://search.maven.org/#search|gav|1|g%3A"net.sourceforge.pmd" AND a%3A"pmd". Can you please update the pull request? You'll also need to add the new version to the TargetVersions in AbstractPmdPluginVersionIntegrationTest.

@bmuschko Done.

Thanks for touching up the pull request. It has been merged!

@sschuberth I had to revert the upgrade of the library version. It failed the test PmdPluginAuxclasspathIntegrationTest on Windows: https://builds.gradle.org/viewLog.html?buildId=2702555&buildTypeId=Gradle_Master_CommitPhase_WindowsCommit_WindowsCommitJava17_8WindowsCommitJava17&tab=buildResultsDiv
Unfortunately, I don't have time to look into the failed test at the moment. Please provide a new pull request with an appropriate fix if you are still interested in having the new library version in Gradle.

@bmuschko I see two failing tests, both say

java.io.IOException: Unable to delete file: C:\tcagent1\work\e94d7a966081366e\subprojects\code-quality\build\tmp\test files\PmdPluginAuxclasspathIntegrationTest\auxclasspath_not_co...g_project\bb54b\pmd-rule\build\libs\pmd-rule.jar

and

This test looks flaky:
Different test status of build configurations with the same VCS change

This test looks flaky: Different test status of build configurations with the same VCS change

This is just coming from TeamCity I believe.
If you look deeper down the stack trace you'll find this:

1 PMD rule violations were found. See the report at: file:///C:/tcagent1/work/e94d7a966081366e/subprojects/code-quality/build/tmp/test%20files/PmdPluginAuxclasspathIntegrationTest/auxclasspath_config...g_project/csh9o/rule-using/build/reports/pmd/main.html

I'll check this.

Is there a way to instruct the test to keep main.html around? Seem like it gets deleted automatically.

Anyway, looking at the failing tests it seems like they are expected to fail, so the problem likely is something else.

@sschuberth Ah, ok. Just had a look. It's expected to fail. What's happening here is that the new version of the PMD library holds on to a file handle which doesn't get released. In turn this causes test cleanup logic (which removes the test project files) to fail as it cannot remove one of the files. Given that the test currently passes I suspect an issue in the new PMD library version.

I bisected it, 5.5.3 succeeds, 5.5.4 fails. Digging further.


🐞 [Bug]: release workflow fails

What happened?
https://github.com/threefoldtech/tfgrid-sdk-go/actions/runs/10665448483/job/29558819317

darwin build fails

https://github.com/threefoldtech/tfgrid-sdk-go/actions/runs/10666967051/job/29563540649


Not able to override build_root in options yml

We have several binaries generated from the same source code - different applications compiled for different boards. We need to test of these gnerated binaries for which we are planning to use options.
Since the binaries are diferent we also want to store the build output files to separate folder and I am trying to override the build_root option in the options yml, but it didnt seem to work.
project.yml
:project:
  :use_exceptions: FALSE
  :use_test_preprocessor: TRUE
  :use_auxiliary_dependencies: TRUE
#  :use_preprocessor_directives: TRUE
  :options_paths:
    # put variation yaml files into this folder
    - project/options
#  :build_root: build1
  :test_file_prefix: test_
  :which_ceedling: gem
  :ceedling_version: 0.31.0
  :default_tasks:
    - test:all

and in the options app1_pcb1.yml
# Ceedling's auto tests for project.
:project:
  :build_root: build2

:paths:
  :test:
    - +:test/**
    - -:test/application/alarms/**
  :source:
    -  -:../../application/application/scim/**
...

I tried uncommenting the build_root: from project.yml and I also tried using the relative path in app1_pcb1.yml as in :build_root: ../../build2 to make sure the build folder is at the root of the tests/ceedling level but no success.
There also seems to be very sparse documentation related to these topics - the advanced section seems to be empty at the moment.
I appreciate if you could provide any input and point out mistakes if any in the way I am trying to setup different build output folders.
I know that I can use project:<yaml_file_without_ext> but this will result in lots of duplication - I have around 30 different binaries generated with several different software feature flags which are built from a single repo / source code base.
I am also aware of the ticket where you had mentioned that overridding the built_root should work from next release. Either I am doing somethign wrong or its still not fixed yet.
ceedling --trace options:app1_pcb1 gcov:all utils:gcov

Test 'test_act_core.c'

rake aborted!
Errno::ENOENT: No such file or directory @ rb_sysopen - ../../build2/temp/_test_act_core.c
C:/MyPrograms/Ruby26-x64/bin/ceedling:23:in `load'
C:/MyPrograms/Ruby26-x64/bin/ceedling:23:in `<main>'
Tasks: TOP => gcov:all
(See full trace by running task with --trace)
ERROR: Ceedling Failed
Traceback (most recent call last):
        4: from C:/MyPrograms/Ruby26-x64/lib/ruby/gems/2.6.0/gems/ceedling-0.31.1/plugins/gcov/lib/gcov.rb:135:in `block in <top (required)>'
        3: from C:/MyPrograms/Ruby26-x64/lib/ruby/gems/2.6.0/gems/ceedling-0.31.1/lib/ceedling/cacheinator.rb:7:in `cache_test_config'
        2: from C:/MyPrograms/Ruby26-x64/lib/ruby/gems/2.6.0/gems/ceedling-0.31.1/lib/ceedling/yaml_wrapper.rb:12:in `dump'
        1: from C:/MyPrograms/Ruby26-x64/lib/ruby/gems/2.6.0/gems/ceedling-0.31.1/lib/ceedling/yaml_wrapper.rb:12:in `open'
C:/MyPrograms/Ruby26-x64/lib/ruby/gems/2.6.0/gems/ceedling-0.31.1/lib/ceedling/yaml_wrapper.rb:12:in `initialize': No such file or directory @ rb_sysopen - ../../build2/test/cache/input.yml (Errno::ENOENT)

Installed version
ceedling version
Ceedling:: 0.31.1
Unity:: 2.5.4
CMock:: 2.5.4
CException:: 1.3.3

I'm also having this issue.

First, I apologize for the sparse documentation. That is something we definitely need to improve.
The build_root setting isn't a compiler option, it's a project setting change. Therefore it's not overwritten when changing the options menu. Instead, you want to merge in a complete different set of settings. You do this by calling ceedling with a different project yaml file. It will still load your original project.yml first, and then overwrite any parts that you replace in the new project yaml file.
For example:
ceedling project:app1_pcb1 gcov:all utils:gcov


Recommandation to augment $fetch in a module

Describe the feature
Hello 👋,
This is both a question and a potential feature request.
I'm currently developing a Nuxt module and was wondering if there's a way to extend $fetch. Specifically, my module needs to add a header to each request.
<script lang="ts" setup>
async function retrieveData() {
  await $fetch('/api/data', {
    method: 'POST',
  })
}
</script>

This request requires a custom token to be authorized by the server. While I could manually set the x-token header, this solution works well within the application but may cause conflicts with other modules.
For example, the nuxt-auth-utils module by @atinux clears the session by making a DELETE request. The end-user simply calls the clear function. Without a way to extend $fetch, I would need to rewrite this function in my codebase and modify it to include my custom header.
I found a workaround by creating a Nuxt plugin that wraps the fetch function, allowing me to tweak it as needed.
export default defineNuxtPlugin({
  name: 'x-token',
  setup() {
    if (import.meta.env.SSR) {
      return
    }

    const originalFetch = $fetch
    // eslint-disable-next-line no-global-assign
    $fetch = async (url, options) => {
      console.log('fetch', url, options)
      const token = document.cookie.match(/token=([^;]+)/)?.[1]

      const isSameOrigin = !url.startsWith('http') || url.startsWith(location.origin)

      if (token && isSameOrigin) {
        options = options ?? {}
        options.headers ??= {}
        options.headers['x-token'] = token
      }

      return originalFetch(url, options)
    }
  },
})

Additional information

[ ] Would you be willing to help implement this feature?
[ ] Could this feature be implemented as a module?

Final checks

[X] Read the contribution guide.
[X] Check existing discussions and issues.

Some notes here.
I think you can make a feature request directly to nuxt-auth-utils to allow application wide headers for useUserSession().fetch composable via config or plugin. (however a word from someone maintained popular axios + auth modules for nuxt 2: application wide mutations are not safe. it will be much much safer now since only such change would affect useUserSession() but i won't be surprised if any edge cases happen with that too)

This is a really annoying behavior because nuxt-auth-utils is just one example but all $fetch of all modules installed, passed or future, must use this token and I do not want to make a feature request to all modules (passed and future) to accept an option to set this.
This makes impossible to implement a proper CSRF protection that will works across the ecosystem.

i recently experience something similar trying to add an option for a custom $fetch plugin for determining if an error snack should be shown when a request fails:
import type { NitroFetchOptions as _NitroFetchOptions, NitroFetchRequest, AvailableRouterMethod } from 'nitropack'

declare module 'nitropack' {
  interface NitroFetchOptions<R extends NitroFetchRequest, M extends AvailableRouterMethod<R> = AvailableRouterMethod<R>> extends _NitroFetchOptions<R, M> {
    errorSnack?: string | boolean | { text: string, timeout: number }
  }
}

Instead of wrapping just the options, it's better for inference to wrap the entire $fetch function, as long as you are simply adding a header.


Navigation L M S

@kevinglover  please refer to zeplin for the numbers

incorrect rollover and active status for SML
align logo with the text, align search button with the text
move navigation to corners

M nav is exceeding the text
incorrect S nav behavior:

Navigation in L is 20 px = 1.25 em

I would recommend remove the animation of rollover because it does't create meaning. If we'd like to keep animation, the style that will make sense is letting the line appear from left to right like it's been underling.

Navigation in L is 20 px = 1.25 em

underline should not exceed the width of the text

in M, menus are displayed in incorrect sequence. it should be Library, reference, viz, outwork

nav in S has not been fixed. please refer Zeplin to see the expanded view in S

@xinyil
The nav S should be full width in develop now.

The rollover state is meant to give feedback that the link is clickable for usability. I added the animation for the hover in the feature/solr-range-facet branch. I also rearranged the navigation and set the corner nav font-size to 20px.

The underlining animation looks great! Is the line farther away from the text in M than in L?
nav in S has not been fixed. The menu expands at the top and you should be able to see the rest of the page beneath that.

@xinyil The underline in M and L are the same absolute distance away, but it might look different because the font size is larger in L than in M.
The small nav pulling down from the top will require some larger changes. Originally, I didn't understand that it was to pull down from the top based on the specs in zeplin. I must have missed the note.
Can we make the S menu a separate card?

We should move it closer for smaller type so it looks visually the same.
What do you mean by making it a separate card?

@xinyil I mean opening up a issue dedicated to the small menu, so we can keep it organized

text in S are M bold
refer to zeplin and use Menu.svg for S menu button (in github sitemedia folder)
the menu button will become close button when expanded
remove the shadow and backgound color in S

In Safari

menu icon in S is missing
the text in M has a strange weight change when the mouse moves out from one link.
text color has not been changed to black

Update after redeploying:

seems like the weight shift problem noted above is only a Safari issue
normal status of link text is still in grey

we might want to give M and S nav a white background to avoid such case

in S, the nav bar including menu, derrida logo/home button, and search icon should stay to the top.

bg is white now on <XL screens. the menu, search, etc. stay on top correctly for me in all browsers already; can't duplicate that last screenshot.

on S the whole nav bar should have fixed position at the top

fix the blue space on S

where is the close button now? current:

this gif is a capture of how it used to be:

Navigation on M seems broken, and you can scroll horizontally

I can't duplicate the horizontal scroll, but the menu close icon and blue line are still happening.

Currently mobile nav menu button is fixed but menu bar is not.

Tried to fix as many of these as I could and still keep the nav looking sane. The X icon thing is unfortunately way harder than it should be because the entire button/icon is being added via some javascript I can't control that MDL is doing based on a layout class on the body (...I think). The generated icon doesn't use a class either; it just looks like a unicode glyph to me...decided not to pursue because it was taking too much time to track down.

Drop-down mobile nav menu is still not showing when I am scrolled part of the way down the page.  It's white on the home page but not on secondary pages.

Colors and background look correct for the mobile nav. However, both the "X" and the text in the dropdown menu for what is being searched is invisible when on the homepage (but looks fine on other pages).
homepage:

elsewhere:

Looks good now.


Noexcept on operator=() is wrong

I think the noexcept on operator() here is wrong. There are several operations involved which all might fail.

Yes, should be
noexcept(noexcept(variant<Types...>(std::forward<T>(rhs))) &&
         std::is_move_assignable<std::tuple<Types...>::value)

The first part covers is_constructible<V, T&&> && is_destructible<V>.
It'd probably be best to dispatch on rvalue-ness of T, so that it doesn't have to make two moves if T is an rvalue, but that can be left to a later improvement.
While you're looking at it... the copy-assignment below makes an unnecessary second copy; and it is actually redundant -- the universal covers lvalue references as well.

This is funny, I hadn't realized what I suggested was already there. If there was not copy_assign and move_assign, but two overloads of assign, then the universal conversion assignment would look like this:
    template <typename T>
    VARIANT_INLINE variant<Types...>& operator=(T && rhs) noexcept
    {
        variant<Types...> temp(std::forward<T>(rhs)); // move if T is rvalue, copy otherwise
        assign(std::move(temp));
        return *this;
    }

I don't feel comfortable having such complex code (especially in areas with compiler problems like #86) without any tests. And it is really easy to get the implementation of the function and the noexcept() clause out of sync. How are we going to test this?

In that case, just remove both conversion-assignment operators, they're not needed -- actually the compiler will generate exactly the code in the first, and better than the second:
v = x; // conversion constructor from decltype(x) must be available
// the compiler will do
v = v(x); // i.e. construct a temporary variant and move-assign =(v&&)


Dice Roll Histogram

Goal here is to implement API endpoints that can be used to record dice rolls. The UI should display buttons or text field to record rolls on referee view. UI should have a histogram display on all game pages.

Sounds good, will take a look as soon as I have some time


Reference for Finan et al. 2017 missing?

Dear ChEMBL Team,
I am interested in knowing more about the protein half-life data for PROTAC. Could it be possible for you to link the citation Finan et al. 2017 to its respective DOI?
Thank You.

Ref - https://www.science.org/doi/10.1126/scitranslmed.aag1166#:~:text=An organized way to drug the genome,-Many drugs that&text=Finan et al.,design of new targeted therapeutics.
Closing the issue.


[Bug] Userguide adoc version has gotten messed up ?

Describe the bug
https://github.com/project-chip/certification-tool/tree/main/docs/Matter_TH_User_Guide
The .adoc version seems to be messed up now , has any PR broken this ?
Steps to reproduce the behavior
No response
Expected behavior
No response
Log files
No response
PICS file
No response
Screenshots
No response
Environment
No response
Additional Information
No response

Hmm , multiple.adoc files is confusing though, are we making many changes to the user guide though? If not would prefer the older format as most developers use that format

@raju-apple you mean confusing for users? They should use the pdf, we always update it when the doc changes.

PDF they’ll have to download, but what maintenance exactly is troubling that we wanted to break this up? If you click on table of contents it’s an empty page, having everything load is so much better instead

ok, then. we'll revert it. @hiltonlima

Fixed , thanks folks !


feat: Encode static error strings in the ABI (WIP)

This is still WIP

I'm going to investigate the bytecode size regressions

I'm going to investigate the bytecode size regressions

It could just be a wrong comparison, I'd be surprised if this changes anything.
You can execute
RUST_LOG=info ./bootstrap.sh 2>&1 | grep public_dispatch

in noir-contracts and compare

Yes, I think they aren't real. These are master numbers:

[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] AppSubscription::public_dispatch: bytecode is 5028 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] Auth::public_dispatch: bytecode is 10782 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] AuthRegistry::public_dispatch: bytecode is 8412 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] AuthWitTest::public_dispatch: bytecode is 1884 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] AvmInitializerTest::public_dispatch: bytecode is 3278 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] AvmTest::public_dispatch: bytecode is 60562 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] Benchmarking::public_dispatch: bytecode is 5721 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] Child::public_dispatch: bytecode is 5990 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] Claim::public_dispatch: bytecode is 4234 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] Crowdfunding::public_dispatch: bytecode is 6210 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] DocsExample::public_dispatch: bytecode is 5842 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] EasyPrivateVoting::public_dispatch: bytecode is 6033 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] FeeJuice::public_dispatch: bytecode is 6227 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] FPC::public_dispatch: bytecode is 9434 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] ImportTest::public_dispatch: bytecode is 1557 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] InclusionProofs::public_dispatch: bytecode is 4168 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] Lending::public_dispatch: bytecode is 28483 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] NFT::public_dispatch: bytecode is 26480 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] Parent::public_dispatch: bytecode is 8589 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] PriceFeed::public_dispatch: bytecode is 3992 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] PrivateFPC::public_dispatch: bytecode is 4120 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] Router::public_dispatch: bytecode is 2541 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] Spam::public_dispatch: bytecode is 3776 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] StaticChild::public_dispatch: bytecode is 3014 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] StaticParent::public_dispatch: bytecode is 7382 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] Test::public_dispatch: bytecode is 20216 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] TestLog::public_dispatch: bytecode is 3314 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] TokenBlacklist::public_dispatch: bytecode is 25372 bytes
[2024-10-31T09:35:58Z INFO  avm_transpiler::transpile_contract] TokenBridge::public_dispatch: bytecode is 23042 bytes

I think I know what's happening. This makes bigger any assert with static message due to codegening the constant. For example, the token contract has:
59 array checks
74 overflow checks
2 range checks
38 user asserts

It's ready for review now


[BUG]: Clean up kerala-configs repository

Describe the bug
The configs repo has unnecessary, extra persister configuration files. Those should be removed and only what's really needed is maintained. We should not go live in SDC with junk data. This will be a maintainability and documentation issue as well.

Duplicate of 1642. Closing this out.


Change Rust color for type names, and self keyword

As you can see on this screen (from my profile README) :

Type names Anto, Programmer and Language as well as self are all gray.
But I remember the type names were colored (maybe blue or violet, I don't remember exactly). And self was blue as well as & is.
From my memories, Language was gray, even if it's a type name.
I also saw a color changement on the attributes :

That's ok. But it should not remove the color on the type names.
Well, I would like to see back the pretty colors instead of this sad gray. Thanks for reading me
Regards.

Just saw #5973, is it the source of the problem ?

I believe so, as Rust's grammar file was changed. The old one was a public archive with some issues starting to pile up.

Yup, @TheWitheredStriker is spot on.
That said, we have an update in the pipeline to pull in the changes from https://github.com/tree-sitter/tree-sitter-rust/pull/150 so things might improve in the next few days.
If not, you'll need to report any problems to the upstream repo at https://github.com/tree-sitter/tree-sitter-rust.
Closing as this has nothing to do with Linguist.

Yes I see thanks.

Closing as this has nothing to do with Linguist.

Colors changed because Linguist use another syntax hilighter now, so...
Well, I will create another issue on the appropriated repository


Remove the guard to call import on Node.js 13 or later

By the release node, Node.js 12.16 supports ES Module
natively which Node.js v13 have already supported features.
It's a time to remove the guard.
Related Issue

https://github.com/karen-irc/option-t/issues/421

This was jump to conclusions.


show most retweeted by default in multiple viewer

@seanfarmar I had to rebase to resolve the conflict. Please review again.


Hiding Multiplier option doesn't work

The multiplier counter is still visible after turning the option to hide it on. I've reinstalled the mod and removed my config file, but it still doesn't work. I've manually checked the config file and it says HideMultiplier = True as expected (my config file).
My latest log shows a warning on line 375: Can't remove the Multiplier counter!

Hmmm, I'm pretty sure Beat Saber just renamed some stuff around and broke that. I'll look into it when the new Beat Saber update drops tomorrow and include the fix in Counters+ 1.5.8.

Seems like I was just executing that code before I should be.
This issue has been fixed in Counters+ 1.5.8.

Thanks!


Syntax check

I work for developer teams and talk them into using 3 tests.

syntax check (dumbest)
coding standard (dumb)
static analysis (not-so-dumb)

Please consider adding https://github.com/JakubOnderka/PHP-Parallel-Lint

We had this in earlier versions, but abandoned this in favour of PHPCS. Also, we use PHP native linter in the lintPHP.sh that is ran on the commit action if I'm not mistaken.
I will probably look into implementing PHPStan, as the results of that scan look really interesting :+1:

we use PHP native linter in the lintPHP.sh

That shell script is not something you are looking for, please reconsider the above PHP pkg.

I will probably look into implementing PHPStan, as the results of that scan look really interesting 👍


Support timeline: keeping track of "some" previous states

The core of the library should be able to keep track of "some" configurable previous states and allow linking them
for example for a giving state, you can tell if it is the current or not, and grab any previous or any next and make it current.
This should push the mental model of the library to another level,
the expected changes although may be start at the State type by introducing the linked behavior

This may be like this:
first you add the necessary configuration:
timeline: {
  enabled: boolean,
  keepState: (state: State) => boolean,
  statesToKeep: boolean, // count of states to keep in the timeline
}

low priority


EmailValidator with checkDNS=true throws ErrorException on bad domains

What steps will reproduce the problem?
validate<EMAIL_ADDRESS>using EmailValidator with checkDNS=true
error_reporting=E_ALL or alike is needed to convert warning to exception in \yii\base\ErrorHandler::handleError
What is the expected result?
validation returns false
What do you get instead?
PHP Warning – yii\base\ErrorException is thrown by $mxRecords = dns_get_record($domain . '.', DNS_MX) and $mxRecords = dns_get_record($domain . '.', DNS_A);;
That's due to dns_get_record return false and emits Warning on some domains
Additional info

Q
A

Yii version
2.0.27 (should be since 2.0.11, issue https://github.com/yiisoft/yii2/issues/12714)

PHP version
7.3.10

Operating system
Alpine

Suppose it should be fine to rewrite calls to dns_get_record this way:
try {
     $mxRecords = dns_get_record($domain . '.', DNS_MX);
} catch (\yii\base\ErrorException $exception) {
     return false;
}

https://mxtoolbox.com/SuperTool.aspx?action=mx%3Aya2.ru&run=toolpage#

Sorry, we couldn't find any name servers for 'ya2.ru'

I don't really understand why checkdnsrr() doesn't work.
https://github.com/yiisoft/yii2/blob/5efe0bda8f07fc8a16ddd2f86c585a26c7c18785/framework/validators/EmailValidator.php#L114-L126
I don't really understand what the purpose of the current implementation is to get DNS records. I suggests:
protected function isDNSValid($domain) {
  return checkdnsrr($domain . '.', 'MX') || checkdnsrr($domain . '.', 'A');
}

$ php -r 'var_dump(dns_get_record("ya2.ru" . ".", DNS_MX));'
PHP Warning:  dns_get_record(): A temporary server error occurred. in Command line code on line 1
bool(false)
$ php -r 'var_dump(@dns_get_record("ya2.ru" . ".", DNS_MX));'
bool(false)

what the purpose of the current implementation is to get DNS records

checkdnsrr always return true in Alpine. Yes, it's php bug and it isn't fixed yet (maybe it isn't reported also).

@batyrmastyr wrapping with try-catch + logging sounds OK. Do you want to prepare a pull request?

@samdark prepared pull request, but what do you meant under "logging"?

@samdark prepared pull request, but what do you meant under "logging"?

try {
...
} catch(... $e) {
  Yii::error('dns_get_record() fail with message: '.$e->getMessage(), __METHOD__);
// or Yii::warning(...)
}


feat(examples): tech debt dashboard

SUMMARY

Lots of plans to grow this into a bigger community engagement/backlog project, but for now, just calling it tech debt.
@betodealmeida is going to help figure out how to load this up as an example... some middleware/commands are required.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Required feature flags:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.55%. Comparing base (c657745) to head (29a6600).
Report is 503 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26818      +/-   ##
==========================================
+ Coverage   67.23%   69.55%   +2.32%
==========================================
  Files        1895     1895
  Lines       74209    74209
  Branches     8244     8244
==========================================
+ Hits        49891    51616    +1725
+ Misses      22246    20521    -1725
  Partials     2072     2072

Flag
Coverage Δ

hive
53.78% <ø> (?)

mysql
77.96% <ø> (ø)

postgres
78.06% <ø> (ø)

presto
53.73% <ø> (?)

python
83.01% <ø> (+4.81%)
:arrow_up:

sqlite
77.64% <ø> (ø)

unit
56.40% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@mistercrunch just got this codecov notification in my inbox... hopefully I'm mistaken, but it looks like adding the label might have somehow retriggered some CI tasks?

Closing in favor of https://github.com/apache/superset/pull/28155


Doesn't work on StackBlitz

Hey, @bcomnes.
I recently started switching my projects to npm-run-all2 and overall it's been a smooth switch.
That being said, I noticed that StackBlitz doesn't work with npm-run-all2. I suspect it has to do with one of the npm path changes in the recent versions.

Using npm-run-all: https://stackblitz.com/github/twbs/examples/tree/284cb72da8429c58e3a90b7789e09f65fe7accc7/color-modes?file=index.html
Using npm-run-all2: https://stackblitz.com/github/twbs/examples/tree/039aecfbaea8447d3d4bc946681c09e921c777a9/color-modes?file=index.html

$ npm-run-all --parallel watch server
ERROR: The "path" argument must be of type string. Received undefined

IIRC StackBlitz is using turbopack, but it'd be nice if npm-run-all2 could also work on StackBlitz.

Possible related to https://github.com/bcomnes/npm-run-all2/commit/61e84ea44dd5c54a6d8a4e1bc9598ed989dfee01 ?

Seems like an issue with stackbliz but open to fixes if it improves things there and doesn't make things worse here. Closing the issue until someones willing to submit a PR.


[Bug] [server] Dolphinscheduler failed to submit tasks properly when Mariadb started late

Search before asking

[X] I had searched in the issues and found no similar issues.

What happened
Dolphinscheduler does not submit tasks when mariadb starts later than ZooKeeper during Linux startup or restart.
What you expected to happen
I hope the task can be submitted normally.
How to reproduce
Make the Mariadb start two minutes later than the DolphinScheduler. The DolphinScheduler screen still shows the task, but the actual task is not submitted. Dolphinscheduler does not retry reading tasks in Mariadb.
Anything else

This happens only occasionally when the cluster is first started or restarted。
Dolphinscheduler does not have a retry mechanism when it fails to connect to Mariadb。
It is possible that this problem also exists in the latest version。

Version
1.3.9
Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @bigdatazhao can you check the 2.0.5 version of this issue?

Hi @bigdatazhao can you check the 2.0.5 version of this issue?

I have tested and verified that the latest version still has this problem.

I think maybe set the retry config in task definition can help you.


Changed service provider register method

Changed the way the FcmChannel is registered, because the previous method was in conflict with official Laravel Nexmo notification channel (laravel/nexmo-notification-channel). It was somehow preventing the initialization of nexmo channel, throwing exception "Driver [nexmo] not supported" when trying to use the nexmo channel. This fixed the problem and both channels now work.
Solution is based on this commit that is in itself based on this one.
Requires Laravel 5.7+

@benwilkins composer.json hasn't been updated with the mininum requirement for laravel and my application (laravel 5.6) stopped to work after this merge

@railken Please submit a PR with the updated composer and I'll merge it in.


vm: add compiled module to reuse

Codecov Report

Merging #8 into master will increase coverage by 0.2%.
The diff coverage is 76.66%.

@@            Coverage Diff            @@
##           master       #8     +/-   ##
=========================================
+ Coverage   49.49%   49.69%   +0.2%
=========================================
  Files          33       33
  Lines        3243     3258     +15
=========================================
+ Hits         1605     1619     +14
+ Misses       1383     1382      -1
- Partials      255      257      +2

Impacted Files
Coverage Δ

exec/vm.go
47.7% <76.66%> (+2.77%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc6628...5bb41e9. Read the comment docs.


Preserve HTML Comments

Have you had any requests for this feature? i.e. where you want to add comments to the bottom of a page viewable when viewing code source?

project is deprecated https://github.com/stereobooster/html_press/issues/21


Possible incompatibility with Refined Storage's Patterns and Ender Chest, and Quark's "Oak Chest" and "Oak Trapped Chest"

Title clarification:
What I meant by the title is that the Refined Storage Patterns might be incompatible with:

Ender Chest
Oak Chest (was originally "Chest" in Minecraft and is renamed by Quark [another Minecraft mod])
Oak Trapped Chest (was originally "Trapped Chest" in minecraft and is also renamed by Quark)

Issue description:
Patterns don't show textures of Oak Chest, Oak Trapped Chest, and Ender Chest.
What happens:
When sneaking with the Oak Chest/Oak Trapped Chest/Ender Chest pattern in inventory (or on the ground), it shows nothing.
What you expected to happen:
Instead of the pattern showing nothing, it must show the Oak Chest/Oak Trapped Chest/Ender Chest
Steps to reproduce:

Create a Pattern for Oak Chest (or any of the previously mentioned chests)
Sneak
See no texture

What I think happens (for the Oak Chest and Oak Trapped Chest):
The Pattern searches for the name of the item that is to show when sneaking. It can't find "Chest" and "Trapped Chest" (since it was renamed by Quark) so it doesn't show anything when sneaking.
Mods' Versions:

Minecraft: 1.12.2
Forge: <IP_ADDRESS>68
Refined Storage: 1.6.8
Quark: r1.5-129

Does this issue occur on a server?
I can't tell (because I don't play RF in a server)
Pictures:
A picture showing two patterns (Oak Chest pattern at the left, Wooden Planks at the right) at the middle of the inventory (not sneaking):

A picture of the two patterns when sneaking:

But you still can craft them?
Seems to be a #609 duplicate.

@CrossVas Yes, you can still craft the three chests I have mentioned.


Incorrect parse request

Request:
wacs.exe --target manual --host example.com,*.example.com --validation dnsscript --validationmode dns-01 --dnsscript D:\WEB\letsencrypt\win-acme\yandex\dns_acme-challenge2.bat --pemfilespath D:\WEB\letsencrypt\cert\ --emailaddress<EMAIL_ADDRESS>--accepttos --test
 [INFO] A simple Windows ACMEv2 client (WACS)
 [INFO] Software version <IP_ADDRESS>9 (RELEASE, UNPLUGGABLE)
 [INFO] IIS not detected
 [INFO] Running with administrator credentials
 [WARN] Scheduled task not configured yet
 [INFO] Please report issues at https://github.com/PKISharp/win-acme
 [INFO] Running in mode: Unattended, Test
 [INFO] Target generated using plugin Manual: example.com and 1 alternatives
 [INFO] Authorize identifier: example.com
 [INFO] Authorizing example.com using dns-01 validation (DnsScript)
 [INFO] Script D:\WEB\letsencrypt\win-acme\yandex\dns_acme-challenge2.bat starting with parameters create example.com _acme-challenge.example.com vh4XJzxqRpRHuCfDAceHLTJ5HvJQJ501zmXyfJztltU
 [INFO] Script finished
 [INFO] Answer should now be available at _acme-challenge.example.com
 [WARN] Preliminary validation failed: no TXT records found
 [INFO] Will retry in 30 seconds (retry 1/5)...
 [WARN] Preliminary validation failed: no TXT records found
 [INFO] Will retry in 30 seconds (retry 2/5)...
 [INFO] Preliminary validation succeeded: vh4XJzxqRpRHuCfDAceHLTJ5HvJQJ501zmXyfJztltU found in vh4XJzxqRpRHuCfDAceHLTJ5HvJQJ501zmXyfJztltU
 [EROR] {
  "type": "urn:ietf:params:acme:error:unauthorized",
  "detail": "Incorrect TXT record \"wKgy6APLSzKpnbEVN2pnuPAUd_umc4GrzbhsXeGrApM\" found at _acme-challenge.example.com",
  "status": 403
}
 [EROR] Authorization result: invalid
 [INFO] Script D:\WEB\letsencrypt\win-acme\yandex\dns_acme-challenge2.bat starting with parameters delete example.com _acme-challenge.example.com vh4XJzxqRpRHuCfDAceHLTJ5HvJQJ501zmXyfJztltU
 [EROR] Create certificate failed: Authorization failed

 [--test] Quit? (y*/n)  [INFO] Script finished

What's happening here is that the program sees the correct TXT record appear at the authorative name server and gives Let's Encrypt the go-ahead to start validation. But Let's Encrypt then sees an old value. This might be the result of the name server not being in sync with eachother yet.
As a work around I recommend adding a time out to your script to make sure it only completes after the servers are synchronized.
A more structural solution would be for the program to make sure that all name servers agree with eachother before proceeding.

It would be too simple:)
I already added a timeout in 290 seconds, but the dns servers [1-2] .yandex.net so slowly update everything that it is necessary to them minutes 30 precisely to be synchronized, but such big time cannot be exposed because the limit of execution of a script of 5 minutes, interrupts it then on a timeout.
D:\WEB\letsencrypt\win-acme>wacs.exe --target manual --commonname example.com --host example.com,*.example.com --validationmode dns-01 --validation dnsscript --dnsscript D:\WEB\letsencrypt\win-acme\yandex\dns_acme-challenge2.bat --store centralssl,pemfiles --pemfilespath D:\WEB\letsencrypt\cert --centralsslstore D:\WEB\letsencrypt\cert --pfxpassword 1qazZAQ! --installation script --script D:\WEB\letsencrypt\win-acme\restart_service.cmd --emailaddress<EMAIL_ADDRESS>--accepttos

 [INFO] A simple Windows ACMEv2 client (WACS)
 [INFO] Software version <IP_ADDRESS>9 (RELEASE, UNPLUGGABLE)
 [INFO] IIS not detected
 [INFO] Running with administrator credentials
 [WARN] Scheduled task not configured yet
 [INFO] Please report issues at https://github.com/PKISharp/win-acme
 [INFO] Running in mode: Unattended
 [INFO] Target generated using plugin Manual: example.com and 1 alternatives
 [INFO] Authorize identifier: example.com
 [INFO] Authorizing example.com using dns-01 validation (DnsScript)
 [INFO] Script D:\WEB\letsencrypt\win-acme\yandex\dns_acme-challenge2.bat starting with parameters create example.com _acme-challenge.example.com hKul_GxG-OwLO7-vWf80TCuoMHHpffUvhTlweFQ5Lq0
 [INFO] Script finished
 [INFO] Answer should now be available at _acme-challenge.example.com
 [WARN] Preliminary validation failed: no TXT records found
 [INFO] Will retry in 30 seconds (retry 1/5)...
 [INFO] Preliminary validation succeeded: hKul_GxG-OwLO7-vWf80TCuoMHHpffUvhTlweFQ5Lq0 found in hKul_GxG-OwLO7-vWf80TCuoMHHpffUvhTlweFQ5Lq0
 [INFO] Script D:\WEB\letsencrypt\win-acme\yandex\dns_acme-challenge2.bat starting with parameters delete example.com _acme-challenge.example.com hKul_GxG-OwLO7-vWf80TCuoMHHpffUvhTlweFQ5Lq0
 [EROR] Error authorizing PKISharp.WACS.DomainObjects.TargetPart
 [EROR] (AcmeProtocolException): JWS has an invalid anti-replay nonce: "0001nC-LXXpKzZPZrjmdIYBQTvxk2X4MoktowNlmOOEw8Jc"
 [EROR] Create certificate failed: Authorization failed

D:\WEB\letsencrypt\win-acme>

In that case I should make the script time-out user configurable, so that you can increase it. Also I think the pre-validation should be configurable (e.g. how many retries at which interval).
Lastly this "invalid anti-replay nonce" should normally not be fatal, I should investigate how that came to be.

Thanks!
I will look forward to solutions.

Hi TerAnYu, beta3 contains these enhancements.

@WouterTinus, thanks!
Everything earned without problems and from the first.
Issue can be closed.


add feature: support resolving pom.xml for maven

Solution: copy, using mvn dependency:copy-dependencies, all dependencies and transitive dependencies, and then resolve license from the jar files.
Known disadvantages:

depends on maven
replication of the jar files needs to read and write the disk

One question, this PR is only including dependency resolving, but not checking the dependencies license compatible, right?

All the dependencies licenses resolvers including Go, NPM don’t check license compatibility now, they just resolve the licenses for human’s reference. Checking license compatibility is out of the scope of this PR and will be discussed after the main resolvers (Java, NodeJS, Golang) can correctly resolve the licenses first.

So many changed files 😱

So many changed files / lines 😱

It may be caused by the CR/LF, now it is fixed.

added some patterns describing the possible locations of license, but does not work for some jar packages

should i crawl the original webpage or judge directly from the url to identify the license

We can consider this later, we don't need to do all in one PR (which is hard to review and cost too long to finish), we can deliver minimal yet complete features step by step, in this PR I think it's OK to only support the "standard" dependencies that have a LICENSE file in their .jar, so let's polish this part instead of keep adding new things in this PR

should i crawl the original webpage or judge directly from the url to identify the license

We can consider this later, we don't need to do all in one PR (which is hard to review and cost too long to finish), we can deliver minimal yet complete features step by step, in this PR I think it's OK to only support the "standard" dependencies that have a LICENSE file in their .jar, so let's polish this part instead of keep adding new things in this PR

ok~, i will do it

Just a reminder, I am not sure whether this could be fixed easily. Maven includes a plugin called shaded, which would not include the dependency jar, but package it inside another package during the install. You could try this case.

Just a reminder, I am not sure whether this could be fixed easily. Maven includes a plugin called shaded, which would not include the dependency jar, but package it inside another package during the install. You could try this case.

thanks for your help, and i am using install command attempting to resolve the incompatibility

Just a reminder, I am not sure whether this could be fixed easily. Maven includes a plugin called shaded, which would not include the dependency jar, but package it inside another package during the install. You could try this case.

thanks for your help, and i am using install command attempting to resolve the incompatibility

My point is, the module using this plugin, may escape from your dependency check. You should check the case.

Just a reminder, I am not sure whether this could be fixed easily. Maven includes a plugin called shaded, which would not include the dependency jar, but package it inside another package during the install. You could try this case.

thanks for your help, and i am using install command attempting to resolve the incompatibility

My point is, the module using this plugin, may escape from your dependency check. You should check the case.

sorry, I didn’t understand it very well. does this mean giving up on resolving these module? since the shaded package will be packaged during the install, can it be solved by installing first?

orry, I didn’t understand it very well. does this mean giving up on resolving these module? since the shaded package will be packaged during the install, can it be solved by installing first?

I don't know. This is only a reminder, I just recommend you to check.

orry, I didn’t understand it very well. does this mean giving up on resolving these module? since the shaded package will be packaged during the install, can it be solved by installing first?

I don't know. This is only a reminder, I just recommend you to check.

ok, I've got the information. i will attemp it later


How to do the load balancing of fabio itself?

Is it possible to support multiple instances of fabio?  how the route will be?

Please have a look at https://github.com/ebay/fabio/wiki/Deployment and let me know whether that answers your question.

@tonysongtl I'm going to close this one for now. Feel free to comment and I'll re-open if necessary or create another issue.


Why it is giving duplicate order Id for differnt timestamps

Need to see the code you're using.

Closing due to inactivity; please reopen if still an issue.


How create the query with pagination option

I want to create list of users with option for pagination.
For example - Get first 30 users.
How can I do this?
Thank you.

You can simply use LINQ's .Take and .Skip methods in your query definition. Paging parameters can be passed in via the args object. For example:
schema.AddListField("usersPaged",
    new { page = 0 },
    (db, args) => db.Users.Skip(args.page * 30).Take(30));

Yes, that is possible and is essentially the goal of this library. However, we don't convert directly to SQL. This library converts GraphQL to IQueryable which is what ORMs in .NET use as an abstraction for a query. If you're already using an ORM (like Entity Framework or NHibernate) then they will handle converting IQueryable to SQL.

OK, I see, please, can you give me a sample code, how can I do that above? :)
I think is it possible create GraphQL query which will be to translate the IQueryable with Take and Skip or is necessary create this operation manually?
And how can I define a list of available queries? I want to disallow send any queries to database from UI.
Thank you for clarification.

I would suggest reading through a few pages of the documentation (https://ckimes89.gitbooks.io/graphql-net/content/) and maybe also checking out some of the example projects (https://github.com/ckimes89/graphql-net/tree/master/examples/01-simple-query). Those go through setting up a schema with GraphQL.Net and Entity Framework and using it to pull data from a database. That should give you a good primer on working with this library.
If you want to restrict which GraphQL queries can be run, you will need to do that before passing the query to GraphQL.Net. There is no built-in support for this.

Thank you Chad for your suggestion. I'll read it.

Is it possible use this library with .NET Core? :)

Not currently - there is an open issue #34 that is tracking it. The delay has been waiting on F# support for .NET Core/Standard, which just released with VS2017, and also waiting on dependency libraries to update and support .NET Core (FParsec and FParsec-Pipes).

OK, thank you. :)

@ckimes89 I'd like to change the IQueryable depending on the graphql input query like https://github.com/ckimes89/graphql-net/issues/76#issuecomment-287357153.
You've said that is possible and is essentially the goal of this library but I don't see how, seeing that the graphql input query is not accessible when you add fields.
Sorry if you've already answered it with:

If you want to restrict which GraphQL queries can be run, you will need to do that before passing the query to GraphQL.Net

(but I'm not sure what you mean there)

@wc-matteo Check out the last few paragraphs of this page in the docs: https://ckimes89.gitbooks.io/graphql-net/content/docs/basics/build_a_schema.html

but I don't see how, seeing that the graphql input query is not accessible when you add fields.

The parameters passed to each field in the query are available to be used. Notice how in this setup line:
schema.AddField("user", new { id = 0 }, (db, args) => db.Users.Where(u => u.Id == args.id).FirstOrDefault());

We have new { id = 0 } and later we use args.id. The first part is defining what arguments can be passed to the field, and the second is using the passed in argument when executing the query. If you want to handle pagination (as in this original issue), then use the parameters as arguments to the .Skip() and .Take() LINQ methods.

Thanks for the answer @ckimes89.
I meant changing the db query based on the fields in the input query (e.g. in the comment I linked, you can save a join if the input query doesn't specify the friends property)

@wc-matteo Ah, I see. Yes, this works by default. We only join to other tables if it's necessary to produce results for the query.

Nice! Thank you @ckimes89.


Suggestion on the guideline

Your work helps me a lot!
However, I met some problems when using it to train my own model and here are some suggestions.
In "How to train Word2VisualVec on other datasets?" part:
Since ${feature_name} is changed and the dataset may have less than 5 sentences for each video, the model can't be trained use command "./do_all.sh ${train_set_name} ${val_set_name} ${test_set_name}".
I think it is better to change the guideline into:
train by
./do_gene_vocab.sh $trainCollection
w2vv_trainer.py $trainCollection $valCollection  $testCollection --overwrite $overwrite  --img_feature=${feature_name} --n_caption=${caption_num}
evaluate by
./do_test_${testCollection}.sh

Thanks for your suggestion. We have modified our script for training on other datasets.


Pull in changes from master into the tsne branch

This is a temp branch to show the results of rebasing the tsne branch onto master as of 6/13/19

Something seems to potentially be up with gitignore considering the existence of __pycache__ files.

Something seems to potentially be up with gitignore considering the existence of __pycache__ files.

Also think we need to add py/visdom/static/js/layout-bin-packer.js to the gitignore

@JackUrb Fixed. If this looks good to you, I can merge the changes into the tsne branch.

Pushed a squashed merge commit to the tsne branch: https://github.com/facebookresearch/visdom/pull/611/commits/4bf81c53bc53d5d7903d8ca52b8617349b8503f2
Closing this temp branch.


Document creating an admin user

I did this with SQLite:
$ sqlite3 db/development.sqlite3
sqlite> insert into roles (name) values ('admin');
sqlite> insert into roles_users (role_id, user_id) values (1,1);
sqlite> .quit

But it would be better to do it with Ruby, preferably with a rake task.

Rails console version is something like
User.last.roles << Role.create(name: "admin")

I needed to do this again with CAS, and the admin role already existed, so:
$ rails c
irb(main):001:0> User.last.roles << Role.first_or_create(name: "admin")
irb(main):002:0> quit


Refactor SDK

Refactors SDK to use new generators
Refactors UserAPI sdk
Moves code to use SDK types types WithResponse over parsing body (not everywhere but in most cases).

Generate SDK fails until public swagger changes too.


adding more default quotes for Say No More

title :p

Thanks! I'll try to get this pushed out this week.


[CherryPick][Enhancement] Optimize commit quorum wait time

What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

CherryPick from #12039
Problem Summary(Required) ：

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

run starrocks_fe_unittest

run starrocks_fe_unittest


Replace drizzle driver by MariaDB driver

Description
Driver has been changed in docker-compose.yml and Dockerfile in order to use MariaDB Driver
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!

[ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests

[ ] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

[ ] Create/update unit or integration tests for verifying the changes made.

[ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

[ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes

[ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

I'll do more testing


Collection of same type causes stack level too deep

With a blueprint that has an attribute that is a collection of the same type as the blueprint, we get a 'stack level too deep' error when defining the views.
Here's a failing spec for the issue: https://github.com/aliscott/praxis-blueprints/commit/6721caaff899d3fa02efc9e663be102aab8cc538
This is an example of the what we are using it for:
class MetricsResult < Praxis::Blueprint

  attributes do
    attribute :group, Attributor::Hash.of(key: String, value: String)
    attribute :metrics, Metrics
    attribute :breakdown_metrics_results, Attributor::Collection.of(MetricsResult),
      description: 'The nested metric results requested by the `group` parameter.',
      example: []
  end

  view :default do
    attribute :group
    attribute :metrics
    attribute :breakdown_metrics_results
  end
end

Note: the data will not contain a loop

After looking at it, the problem it is not only that the view defines an attribute of the same type (which is in the middle of its definition), but also when the view desired for the collection is the same view that you're in the middle of defining :)
So, double whammy because you're pointing to the :default view of the MetricsResult type, in the middle of defining the :default view of MetricsResult (which you're also in the middle of defining).
Anyway, I have PR 25 out to solve it all. :)
Thanks for reporting this interesting issue.


Links are not imported into ADO for cross projects

While migrating work items of 2 different projects into single project in ADO, their corresponding links are not imported into ADO.

Please find the cofig files and Json files.
cross projects.zip

@MuthumariPonnusamy Not yet sadly. Since this feature is out-of-scope for what we originally intended for the tool, I can't give an estimate on how long it will take until we fix it.
In the meantime, we always welcome the community to implement it :)
If we can help you with your migration, you are always welcome to make a business inquiry to Solidify AB, Sweden.

Closing as we will not be working on this


Bug in envelope_correlation()

Hi everyone,
I think there is a bug in the functionenvelope_correlation() in the case of orthogonalize=False. In the computation of the correlation, the mean is not being subtracted from label_data_orth.
By replacing line 110 in envelope.py with label_data_orth = data_mag_nomean this should be fixed.
Maybe you could have a quick look, @dengemann .

thanks. Can you provide a small code snippet that demonstrates the problem?
how would you test that the result is correct after the fix? this helps us
writing tests to make sure the code does not get broken in the future.
thanks again

It seems like I was wrong. Both versions, the original code and my proposed "solution", give the same results. I calculated the correlation matrix manually and compared the results to the results of both versions of envelope_correlation(). You can find the code below.
I thought there might have been a bug because when one calculates the covariance in the numerator of the pearson correlation coefficient one usually subtracts the mean from both data series, X and Y. However, it is actually only necessary to subtract the mean from one of the time series.
cov(X, Y) = <X - X_mean, Y - Y_mean> = <X, Y - Y_mean> - <X_mean, Y - Y_mean>
Since '<X_mean, Y> = N * mean(X) * mean(Y) = <X_mean, Y_mean>' we have in the end:
cov(X, Y) = <X, Y - Y_mean> = <X - X_mean, Y>
with X, Y, X_mean, and Y_mean being vectors of length N, mean(X) and mean(Y) being scalars, and <,> being the dot product.
The code:
from mne.connectivity import envelope_correlation
from mne.filter import next_fast_len
import numpy as np
from scipy.stats import pearsonr
from scipy.signal import hilbert

n_epochs = 1
n_channels = 5
n_times = 100
data = np.random.rand(n_epochs, n_channels, n_times)
n_fft = next_fast_len(n_times)

data_hil = hilbert(data, N=n_fft, axis=-1)[..., :n_times]

corr = np.ones((n_epochs, n_channels, n_channels))

for epo_idx in range(data_hil.shape[0]):
    for idx1 in range(data_hil.shape[1]):

        data_mag = np.abs(data_hil[epo_idx])

        for idx2 in range(idx1 + 1, data_hil.shape[1]):

            corr[epo_idx][idx1][idx2] = pearsonr(data_mag[idx1], data_mag[idx2])[0]
            corr[epo_idx][idx2][idx1] = corr[epo_idx][idx1][idx2]

ec = envelope_correlation(data_hil, combine=None, orthogonalize=False)

np.allclose(corr, ec)


Can Not Start VS Code with Co-Pilot "A second instance of code is already running as administrator"

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.69.0
OS Version: Windows_NT x64 10.0.19045

[Window Title]
Visual Studio Code
[Main Instruction]
Visual Studio Code
Version: 1.69.0
Commit: 92d25e35d9bf1a6b16f7d0758f25d48ace11e5b9
Date: 2022-07-07T05:28:36.503Z (11 mos ago)
Electron: 18.3.5
Chromium: 100.0.4896.160
Node.js: 16.13.2
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19045
Steps to Reproduce:

Run vs code instance (NO OTHHER INSTANCES ARE RUNNING).
VS starts and dialog bottom right says log in to co-pilot
I log into co-pilot on git hub
A dialog box pops up and says
"a second instacne of code is already running as administrator"

I can not use co-pilot with VStudio.
Also I have seen all these issues being closed by someone on here, and all of them say see the duplicate issue - THERE IS NO DUPLICATE ISSUE ON ANY  OF THE TICKETS I LOOKED AT - all duplciate links when you click on them take you to unrelated issues or just the front page of the incidents list.

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.79.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Underlying issue is same as https://github.com/microsoft/vscode/issues/184766, merging to it.
@TylerLeonhardt is there a workaround available today for this scenario  other than launching the application as non-administrator ?

No workarounds for this at this time.


Failing debugger evaluation test in #31251

Description:
https://github.com/ballerina-platform/ballerina-lang/pull/31251
Steps to reproduce:
Affected Versions:
OS, DB, other environment details and versions:
Related Issues (optional):

Suggested Labels (optional):

Suggested Assignees (optional):

Closing with #31251


Support adding new fields to serialized classes

If you serialize a class, add a new field, then recompile and deserialize it'll crash. Possibly something to do with how bon handles unknown fields. Need to see if this can be changed with a bon attribute or if the library needs changes.
For now, it should just ignore new fields and leave them as their default value. This way new fields can be added and old data can be loaded without issues.
Eventually we might want more complex handling for this so we can handle fields getting added/removed or having their names changed. Will depend on how often that happens.

[BonKeepUnlessSet] and [BonKeepMembersUnlessSet] can be used to handle this. I don't like that you have to manually mark them for this to work. It should just be the default behavior to ignore new fields. But's good enough for now.


add import test, clean up variables, add docs url

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

References:

#153
blocks https://github.com/conda-forge/python-lsp-ruff-feedstock/pull/16

would rather find and fix this issue once rather than pin and re-pin downstream in a bunch of places

tries some .gitignore hacks vs maturin

see https://github.com/conda-forge/conda-smithy/pull/1818
these will likely be blown away by a rerender

Changes:

add an import test
remove the name jinja variable
update docs links

@conda-forge-admin please rerender

@conda-forge-admin please rerender

@conda-forge-admin please rerender

@conda-forge-admin please rerender


Revert "Added support for CMS in the AMP readiness checker"

Reverts jeffjose/ampbench#1

If you reopen this and merge, I think we will be good for a new PR.

My sense is unless I hard-reset the branch, your commits with wrong email will always be part of the branch.

Obsolete


Proxy Client can't reach website as CA is unknown (too new ??? )

The CA and cert of the site seems valid as multiple clients can download it via multiple browsers (when not behind the proxy).
The URL that causes the error:  HPE
The following error was encountered while trying to retrieve the URL: https://gslb-downloads-hpe-com.ext.hpe.com/*

Failed to establish a secure connection to <IP_ADDRESS>

The system returned:

(92) Protocol error (TLS code: X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT_LOCALLY)
SSL Certficate error: certificate issuer (CA) not known: /C=US/O=DigiCert Inc/CN=DigiCert TLS RSA SHA256 2020 CA1

This proxy and the remote host failed to negotiate a mutually acceptable security settings for handling your request. It is possible that the remote host does not support secure connections, or the proxy is not satisfied with the host security credentials.

this HPE server does not provide the intermediate authority certificate
https://wiki.squid-cache.org/ConfigExamples/Intercept/SslBumpExplicit#Missing_intermediate_certificates

Stranglely, many browsers do not complain about that... I'm not sure if it's a bug then.

browsers and squid-4 and above are able to independently download the certificate of an intermediate CA thanks to the information in the server certificate.
what are the squid settings? https inspection enabled? "log sni info only" diabled? authentication required?

Enable SSL inspection - checked
Log SNI information only - unchecked
I can't thind the 'Authentication required' option, but as I'm using it as a transparent proxy most probably it's disabled.

got it. so squid blocks its own requests on sub-CA cert fetching
working solution afaik:
http://squid-web-proxy-cache.1019090.n4.nabble.com/Squid-won-t-download-intermediate-certificates-td4688931.html
you can try to add certsfetc.conf file to  /usr/local/etc/squid/pre-auth/  dir with:
`

#Allow fetch intermediate certs before required authentication
acl fetched_certificate transaction_initiator certificate-fetching
cache allow fetched_certificate
http_access allow fetched_certificate

`
should work imho

I can confirm that it worked

Funny thing is that I just tried to reach Squid wiki from above and I got error even after applying the fix:
The following error was encountered while trying to retrieve the URL: https://master.squid-cache.org/*

Failed to establish a secure connection to <IP_ADDRESS>

The system returned:

(92) Protocol error (TLS code: X509_V_ERR_UNABLE_TO_GET_ISSUER_CERT_LOCALLY)
SSL Certficate error: certificate issuer (CA) not known: /C=US/O=Let's Encrypt/CN=R3

This proxy and the remote host failed to negotiate a mutually acceptable security settings for handling your request. It is possible that the remote host does not support secure connections, or the proxy is not satisfied with the host security credentials.

Could it be the same issue and the fix not working at full extent ?

imho it seems even funnier:

master.squid-cache.org uses LE cert
master.squid-cache.org uses LE cert from R3 sub-CA
R3 LE certs do not contain (accessMethod = <IP_ADDRESS>.<IP_ADDRESS>.2) information (so the cert should be provided by the server)
master.squid-cache.org attaches  X3  intermediate authority certificate 🤣
https://www.sslshopper.com/ssl-checker.html#hostname=master.squid-cache.org

so your squid doesn't know where to get a intermediate authority certificate
you can try to add R3 cert to System: Trust: Authorities, restart squid and check again


Add custom mouse wheel scrolling speed.

Two new properties were added scrollingHorizontalMouseWheelMultiplier and scrollingVerticalMouseWheelMultiplier, which are proxied to finbars.
These values can be set as:

between 0 and 1 -> decrease speed;
1 -> original speed (default value);
above 1 -> increase speed;
negative values will invert the scrolling (could probably apply a modulo on this?...)

This should implement issue #290.
Thanks!

@hugoeanogueira @joneit And is this PR going stale?

@hugoeanogueira @joneit Are we ready to resume reviewing and resolving these prs?
as well as https://github.com/fin-hypergrid/core/pull/622
https://github.com/fin-hypergrid/core/pull/626

Closing. Worked into Hypergrid v2.1.11 (PR #722).


Enhance for devtest ESE clarity

We have customers provisioning devtest ESU licenses incorrectly, getting billed and requesting a refund because they didn't fully understand the documentation.  I made some edits to existing verbiage in this article in attempt to improve the clarity on how devtest licensing works.

#sign-off


New responsive and functional website

I saw you have a great collection of questions along with their solutions, thus i would like to propose a fully functional and responsive website with will give you the better view of your idea of problems along with their solutions!
Kindly assign me this issue under Hackotober fest 2022 @Riddhi9570

I need a person with a similar kind of work for my repo. Are you interested @Janhvi52 ?

I need a person with a similar kind of work for my repo. Are you interested @Janhvi52 ?

Yea @ayu8 I'm in, but lemme know the work first
I want to work for hackotober fest first, if any repo for that, it would be great
thanks!

Link to my repo: https://github.com/ayu8/DSA-4-All/

@Janhvi52 Sure! It's a good idea. Before assigning this to you, do you have any sample to show me how your work will look like?

@Janhvi52 If you don't have sample, just tell me, no issue.

@Janhvi52 If you don't have sample, just tell me, no issue.

Pardon me for taking this long to get back to you. As of now I'm not having any sample as such which exactly depicts my ideology @Riddhi9570

@Janhvi52 If you don't have sample, just tell me, no issue.

Pardon me for taking this long to get back to you. As of now I'm not having any sample as such which exactly depicts my ideology @Riddhi9570

@Riddhi9570
Anyway it would be great if you make a website for the same and then we will raise issues to improve the website from our end, thanks!

Pardon me for taking this long to get back to you. As of now I'm not having any sample as such which exactly depicts my ideology @Riddhi9570

No worries!

@Riddhi9570 Anyway it would be great if you make a website for the same and then we will raise issues to improve the website from our end, thanks!

Sure, go ahaed! I'm giving the responsibility for the website to you!


View size always zero?

Hi, trying to implement a custom graphical view. I'm using a graphical data type, defined in XML and in the extension types, I'm able to add the data type to profiles, but when the startView method of the DataTypeImpl is invoked, it seems that field viewSize of the ViewConfig always contain a pair of zero values.
The gridSize appears correct, based on the data type profile layout, but the viewSize does not reflect that. Could you double check if that works correctly? I could be doing something wrong.
Using version karoo-ext 1.1.2 and Karoo 1.527.2014

There's a fix for this mentioned in #16 that will be available in the next Karoo release (1.535.2029). This will be noted when 1.1.2 is taken out of pre-release.

Missed that one fix on the PR notes! Thank you 🙂


We use a paid g-Suite account. Google writes that you can use it to allow apps to access source documents. How is this supposed to work if the token changes constantly?

I use api library to connect to g-Suite and these are notify errors. I have downloaded file is successful. but when token is expired
https://prnt.sc/u8vgn0
Notice: Undefined index: expires_in in D:\www\php\api-g-drive\src\Google\Client.php on line 520
Fatal error: Uncaught GuzzleHttp\Exception\ClientException: Client error: POST https://oauth2.googleapis.com/token resulted in a 401 Unauthorized response: { "error": "unauthorized_client", "error_description": "Unauthorized" } in D:\www\php\api-g-drive\vendor\guzzlehttp\guzzle\src\Exception\RequestException.php:111 Stack trace: #0 D:\www\php\api-g-drive\vendor\guzzlehttp\guzzle\src\Middleware.php(66): GuzzleHttp\Exception\RequestException::create(Object(GuzzleHttp\Psr7\Request), Object(GuzzleHttp\Psr7\Response)) #1 D:\www\php\api-g-drive\vendor\guzzlehttp\promises\src\Promise.php(203): GuzzleHttp\Middleware::GuzzleHttp{closure}(Object(GuzzleHttp\Psr7\Response)) #2 D:\www\php\api-g-drive\vendor\guzzlehttp\promises\src\Promise.php(156): GuzzleHttp\Promise\Promise::callHandler(1, Object(GuzzleHttp\Psr7\Response), Array) #3 D:\www\php\api-g-drive\vendor\guzzlehttp\promises\src\TaskQueue.php(47): GuzzleHttp\Promise\Promise::GuzzleHttp\Promise{closure}() #4 D:\www\php\api-g-drive\vendor\guzzlehttp\promises\src\Promi in D:\www\php\api-g-drive\vendor\guzzlehttp\guzzle\src\Exception\RequestException.php on line 111
Thanks for the help

You could use a service account to authenticate, as described here. Alternatively, you can store the refresh token returned with your auth token and use that to gain a new access token when the old one expires.

Thanks John Pedrie,
I have followed the documentation but I still cannot get the file information from my g-Suite account.
https://prnt.sc/u9btmi
https://prnt.sc/u9bu1a
include_once DIR . '/vendor/autoload.php';
putenv('GOOGLE_APPLICATION_CREDENTIALS=evident-scion-287809-2a846660163d.json');
//$credentials_file = 'evident-scion-287809-2a846660163d.json';
$client = new Google_Client();
//$client->setAuthConfig($credentials_file);
$client->useApplicationDefaultCredentials();
$client->addScope(Google_Service_Drive::DRIVE);
$service = new Google_Service_Drive($client);
$files = $service->files->listFiles();
echo '';
print_r($files);
exit;

When using service accounts, you'll need to either share the file with the service account or, in the case of G-Suite, you can configure domain-wide delegation.

I have enabled it. but I still can not get files.
https://prnt.sc/uaxvyt