Scala meta can't match valid scala code under -Yinfer-argument-types

Tokenizing works, but parse[Source] doesn't, I also don't see a way to configure this in order to enable it.

Can you please include a minimal example to reproduce?

 echo 'object A {trait TestMe { def testMe(i: Int) }; object impl extends TestMe { def testMe(i) = ??? }}' > A.scala
scalac -Yinfer-argument-types A.scala

Compiles fine, now:
scala> val code = """object A {trait TestMe { def testMe(i: Int) }; object impl extends TestMe { def testMe(i) = ??? }}""".tokenize
code: scala.meta.tokenizers.Tokenized = object A {trait TestMe { def testMe(i: Int) }; object impl extends TestMe { def testMe(i) = ??? }}

scala> val code = """object A {trait TestMe { def testMe(i: Int) }; object impl extends TestMe { def testMe(i) = ??? }}""".parse[Source]
code: scala.meta.parsers.Parsed[scala.meta.Source] =
<input>:1: error: : expected but ) found
object A {trait TestMe { def testMe(i: Int) }; object impl extends TestMe { def testMe(i) = ??? }}

Looks like we need to add a new field to Dialect: https://github.com/scalameta/scalameta/blob/a9f6f83ecd706c0d1309f4f315a4d3d56df7f44e/scalameta/dialects/src/main/scala/scala/meta/dialects/package.scala#L16.
After we have this new field, it would be possible to do something like Scala211.copy(allowTypelessParams = true).apply(<snippet of code>).parse[...].

@rcano Would you be interested in contributing this new feature? It looks like parser changes are going to be just a couple lines of code around https://github.com/scalameta/scalameta/blob/2289145b9a7927082c5a498e6ae0f677d97bb08f/scalameta/parsers/shared/src/main/scala/scala/meta/internal/parsers/ScalametaParser.scala#L2590.

I'm not familiar at all with scalameta's codebase and that file you linked scared me good 😓

That file can indeed appear a bit scary at first sight 😅 What's happening there is that we are parsing the type of the parameter, the fix is probably a matter of changing the condition inside the if to return None instead of report syntax error when the token is not a colon and dialect.allowTypelessParams


chore: add chromium to docker for html-template

Description

add chromium to docker for html-template

Related issue(s)
Fixes https://github.com/asyncapi/html-template/issues/112

@jonaslagoni yeah, I know what you mean, but there is no other way really. At the end, html-template is an official template, so I do not see this as a big problem.

@jonaslagoni yeah, I know what you mean, but there is no other way really. At the end, html-template is an official template, so I do not see this as a big problem.

Can't we imagine this is something everyone could benefit from, adding a feature which controls the docker environment per template? I can understand if we just want to make this a temporary fix, however there should be an issue where this is raised IMO.

@jonaslagoni tbh I have no idea how else this could be solved, other than saying create your own image using generator image as a base. I also cannot really imagine any other template needing such a custom approach. Puppeteer is just unique here needing dedicated chromium instance for alpine. What I'm trying to say is that any followup issue will just be food for the stale bot 😄 as we do not have a use case for such extensibility. Maybe I add a comment that in case more customizations are needed for other templates, we should consider reworking the image?

What I'm trying to say is that any followup issue will just be food for the stale bot 😄 as we do not have a use case for such extensibility. Maybe I add a comment that in case more customizations are needed for other templates, we should consider reworking the image?

I mean, you just had the use case 😄 If 1 template requires custom dependencies, others will probably too, even if we can't think of a reason atm. I mean there are different methods to make it require dependencies, extending the generator docker image, make a framework for shell files, make files etc. But I agree atm this is too much, but I still think an issue would be valid. Ill accept the PR on the notion that this is temporary 😄

@jonaslagoni yo, can you approve again, I added a comment to dockerfile


Label suggestion

Dependancy

Many project use package manager that has a lot of dependencies and some to this can be stressful to update so if we know what is issue we can change it or improve it
Use For Dependency of package manager library or update ( which is ignored by git ) Thank you

There are currently 1,353 issues open on github with this label. This seems like a good candidate


backup: send task reponse concurrently

Signed-off-by: luancheng<EMAIL_ADDRESS>
What problem does this PR solve?
Issue Number: close https://github.com/pingcap/br/issues/394
Problem Summary:
concurrent send backup task responses back, this improve the performance of backup.
What is changed and how it works?
What's Changed:
remove for loop to send response, and put send logic into self.pool
Related changes

Need to cherry-pick to the release branch

Check List
Tests

Manual test (add detailed scripts or steps below)

use br(8ffad37d9e917a71c59c0501f2bdbc5b9bdd853e) to test this branch and v4.0.2 with same workload(multiple empty backup range).
v4.0.2:

this commit:

Release note

No release note

/run-integration-br-test

/run-integration-br-test

/merge


Opaque values: fix a bug in ResultPlanBuilder + support for-each loops

Small part of radar rdar://problem/30080769
Adds support for for-each statements, fixing a bug in ResultPlanBuilder: we used to do by-address initialization of local variables if the result is formally indirect, even if we are under opaque values mode. This PR handles that case.
The attached test-case also makes sure we don't do any unnecessary temporary allocations when producing for each statements under this new mode.

@swift-ci Please smoke test


Styles do not update in webpack watch mode

Just like in #665 , but on most recent webpack 5.65.0, all consecutive changes after first one are ignored.
Quick fiddling showed that apparently API has changed a bit, and now here must be fileWatcher.watcher.* instead of fileWatcher.*.

happy to take a PR that supports both the old and new here.

Sorry to jump in here but currently facing the same issue. Is the PR likely to merged?


Update request: osmosdr 0.2.3 → 0.2.4 and support latest gnuradio

Package name: osmosdr
Latest released version: 0.2.4

Current version on the unstable channel: 0.2.3
Current version on the stable/release channel: 0.2.3

[x] Checked the nixpkgs pull requests

Osmosdr is only packaged for gnuradio 3.8 but the latest version supports gnuradio 3.10 just fine.
Notify maintainers
@bjornfor

Note for maintainers: Please tag this issue in your PR.

@Tungsten842: Can you test https://github.com/NixOS/nixpkgs/issues/226296?


Use the mt entity

Before https://bids-specification.readthedocs.io/en/stable/99-appendices/09-entities.html#mt
was standardized, we'd encoded this information in the acq field. But
now we don't have to.
This was done with this script:
find . -name "*_acq-MT*.nii.gz" |
 while read fname; do
   git mv ${fname} ${fname/_acq-MT/_mt-};
 done

Fixes https://github.com/spine-generic/data-multi-subject/issues/103

Despite my "fixes" claim, this doesn't yet deal with the acq-T1w ambiguity (https://github.com/spine-generic/data-multi-subject/issues/103#issuecomment-969503450). Should we deal with that in this PR or in a follow up?

Drafted until it gets redone to account for that acq-T1w file: https://github.com/spine-generic/data-multi-subject/issues/103#issuecomment-969679915

Fixed in #135 instead.


EFCore.BulkExtensions SQLServer System.Collections.Generic.KeyNotFoundException: The given key 'lfd_nr' was not present in the dictionary.

Since updating to V7.03 I get the following error on BulkInsertAsync:
System.Collections.Generic.KeyNotFoundException: The given key 'lfd_nr' was not present in the dictionary.    at System.Collections.Generic.Dictionary2.get_Item(TKey key)
at EFCore.BulkExtensions.TableInfo.LoadData[T](DbContext context, Type type, IList1 entities, Boolean loadOnlyPKColumn)    at EFCore.BulkExtensions.TableInfo.CreateInstance[T](DbContext context, Type type, IList1 entities, OperationType operationType, BulkConfig bulkConfig)
at EFCore.BulkExtensions.DbContextBulkTransaction.ExecuteAsync[T](DbContext context, Type type, IList1 entities, OperationType operationType, BulkConfig bulkConfig, Action1 progress, CancellationToken cancellationToken)
at BulkInsert.Controllers.PackingController.Post() in C:\Temp\BulkInsertSample\BulkInsert\BulkInsert\Controllers\PackingController.cs:line 40
at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor.TaskResultExecutor.Execute(ActionContext actionContext, IActionResultTypeMapper mapper, ObjectMethodExecutor executor, Object controller, Object[] arguments)
at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.g__Awaited|12_0(ControllerActionInvoker invoker, ValueTask1 actionResultValueTask)    at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeNextActionFilterAsync>g__Awaited|10_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)    at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context)    at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)    at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeInnerFilterAsync>g__Awaited|13_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)    at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeFilterPipelineAsync>g__Awaited|20_0(ResourceInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)    at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Awaited|17_0(ResourceInvoker invoker, Task task, IDisposable scope)    at Microsoft.AspNetCore.Mvc.Infrastructure.ResourceInvoker.<InvokeAsync>g__Awaited|17_0(ResourceInvoker invoker, Task task, IDisposable scope)    at Microsoft.AspNetCore.Routing.EndpointMiddleware.<Invoke>g__AwaitRequestTask|6_0(Endpoint endpoint, Task requestTask, ILogger logger)    at Microsoft.AspNetCore.Authorization.AuthorizationMiddleware.Invoke(HttpContext context)    at Swashbuckle.AspNetCore.SwaggerUI.SwaggerUIMiddleware.Invoke(HttpContext httpContext)    at Swashbuckle.AspNetCore.Swagger.SwaggerMiddleware.Invoke(HttpContext httpContext, ISwaggerProvider swaggerProvider)    at Microsoft.AspNetCore.Authentication.AuthenticationMiddleware.Invoke(HttpContext context)    at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddlewareImpl.Invoke(HttpContext context)

Before updating using V6.6.5 it worked without problems:

I attached a working sample. Be sure to start it via docker compose, because the database is necessary!
Reproduction steps:

Start via docker-compose
Swagger UI opens
Run Post request via "Try it out" --> "Execute" Buttons
Get request is only for verification whether data got written into the table

It's possible to downgrade the Nuget Package in the sample to 6.6.5 then it works without the error. On 7.0.3 the error appears.
AspNetCore 7
EF Core 7.04
MS SQL Server
BulkInsertError.zip

I have copied this code into the new test in the source and it passed.
Check again with latest version 7.0.4 and is still having issue can you write a reproducible test analog to existing one in the source of the lib.

Yes 7.0.4 fixed this problem. Thank you for the quick solution!


Add proto validation for names

Summary
For stacklok entity names (profile, provider, etc) the pattern is [A-Za-z][-[:word:]]*, must start with a letter and may contain dashes, underscores and alphanumeric characters.
For display names the pattern is [[:space:][:punct:][:word:]]*, the characters used to form a sentence.
For external names (repo, artifact, etc) the pattern is [-./[:word:]]*, alphanumeric characters, dashes, underscores, plus dots and slashes.
Ref stacklok/minder-stories#94
Change Type
Mark the type of change your PR introduces:

[ ] Bug fix (resolves an issue without affecting existing features)
[x] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[ ] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>0
Details

0 of 0   changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage remained the same at 54.763%

Files with Coverage Reduction
New Missed Lines
%

internal/eea/eea.go
2
73.73%

Totals

Change from base Build<PHONE_NUMBER>8:
0.0%

Covered Lines:
15534

Relevant Lines:
28366

💛  - Coveralls


Tags prefix

This is an enhancement that adds a prefix value to the tags for (almost) all resources. I think it improves the readability, especially when there are more than 1 VPCs (with multiple subnets) in the AWS account.
The tags_prefix value is declared inside the vpc module.
F.x.
module "vpc" {
  source  = "aws-ia/vpc/aws"
  version = ">= 1.0.0"

  name = local.vpc.name
  tags_prefix              = local.vpc.name
  cidr_block               = "${local.vpc.cidr_prefix}.0.0/16"
  az_count                 = length(data.aws_availability_zones.available.names)
  vpc_enable_dns_hostnames = true
...

Thanks for opening this PR! I see the need your trying to fulfill. question, would the name_prefix from each subnet type definition be the same as the tags_prefix? We could potentially use that instead of a new argument, thoughts?

name_prefix

Thanks for opening this PR! I see the need your trying to fulfill. question, would either the name_prefix from each subnet type definition or the var.name be the same as the tags_prefix? We could potentially use that instead of a new argument, thoughts?

Thank you for your quick response!
Indeed, var.name could be used instead of a new arg, but AFAIC name_prefix can receive two different values, so that would be a possible mix up when we would like to use a single constant tag prefix for (all) resources :)

Alright, finally got a chance to look a little deeper again. So the way this works right now is that actually the name_prefix IS used if one is provided, defaulting to the subnet type name:
https://github.com/aws-ia/terraform-aws-vpc/blob/ca35ca9662e0ba87d2972c85980741fe3d58d19d/data.tf#L8
At face value, using var.name as the tag_prefix seems better than creating a new variable and I'd be very open to including that in this module if you want to push up the commit

happy to readdress this if its still an issue


Added scheduler.alpha.kubernetes.io/node-selector annotation

Fixes #34333
Hey @sftim I have added the required annotation to this page https://kubernetes.io/docs/reference/labels-annotations-taints/ .
Also I think annotations  in labels-annotations-taints page are not organized in any order that's why I wasn't able to decide a clear space where to add new one.
Should we rearrange the annotations in alphabetical order so that its easier to find and read them ?

Hey @chetak123,
It's been a while since the last update, would you like to address issues in the previous comments so that we can move forward?

@chetak123 if you can, it'll be handy to squash the commits in this PR.
/label tide/merge-method-squash

@kubernetes/sig-scheduling-pr-reviews does this change look right?

https://github.com/kubernetes/website/pull/34477/files#r1009441925 covers the important thing to fix here.

Approving this so the current behavior is documented
We can make changes accordingly associated with https://github.com/kubernetes/kubernetes/issues/113474
/approve


✨ [Feature request]: Add FOSS India as our Event Partner

Is your feature request related to a problem? Please describe.
Add FOSS India as our Event Partner. We are the community partner of FOSS India 3.0 happening in a few weeks.
Describe the solution you'd like.
Modify the section where we list down the event partners.
Describe alternatives you've considered.
None
Screenshot / Screenshare

Additional context
Talk to @atapas or @PriteshKiri for any additional context.
Record

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[ ] I want to work on this issue
[X] I am in Hacktoberfest

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hey, I would like to work on this issue could you assign me this one?

Hey, I would like to work on this issue could you assign me this one?

sure

hey @priyankarpal , if @AKASH-PRASAD7 doesnt reply, can u please assign it to me, Thank you.

Hello @priyankarpal , let me know if i can work on this

hey @priyankarpal is this still available?, I would like to work on it. Thanks

hey @priyankarpal is this still available?, I would like to work on it. Thanks

assigned to you


[Bug]: Spelling error

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
the spelling of copied is wrong here.
Expected behavior
it should be copied and not coppied
Add ScreenShots

On which device are you experiencing this bug?
No response
Record

[X] I have read the Contributing Guidelines
[X] I want to work on this issue

@subinoybiswas please assign me this issue


Migrate all APIs to retrofit

Summary:
This is a subtask to track network layer refactoring as part of #1092.

[x] getAuthCookie > PR raised
[x] login > PR raised
[x] getEditToken > PR raised
[ ] getWikidataCsrfToken > PR raised
[x] getCentralAuthToken > PR raised
[x] fileExistsWithName
[x] pageExists
[ ] findThumbnailByFilename
[x] getCategoryImages
[x] getSubCategoryList
[x] getParentCategoryList
[x] searchCategory
[x] uploadFile > PR raised
[x] edit > PR raised
[x] prependEdit > PR raised
[x] appendEdit > PR raised
[ ] wikidatCreateClaim > PR raised
[ ] addWikidataEditTag > PR raised
[ ] fetchMediaByFilename
[x] searchCategories
[x] allCategories
[x] getNotifications
[x] markNotificationAsRead > PR raised
[x] searchTitles
[ ] revisionsByFilename
[x] existingFile
[ ] logEvents
[ ] isUserBlockedFromCommons

Suggested test flows (by misaochan) for backend-overhaul branch:

[ ] Log in, upload a picture. Make sure the upload does not fail and that it is associated with the correct account (check this in Commons). Log out, then log in to a different account. Repeat the process. Log out, then log back in to the original account. Repeat the process for the last time.
[ ] Test with 2FA account if you have one
[ ] Try uploading a file that already exists or a title that already exists
[ ] Test notifications
[ ] Test Achievements
[ ] (After Vivek reports this is fixed): Test Wikidata edits from Nearby

Can I help with this or should I refrain from doing grant tasks?

You are most welcome to contribute. Our grant doesn't define the APIs specifically and given that we are supposed to overhaul the entire app, some help would be great. :)
You can pick any of the pending APIs. I have updated the comment to reflect which ones have a PR raised already. You can pick from the remaining ones.
It would be best to pick just 1 API at a time and raise a PR for it separately so that it can be merged quickly. Base your PR to backend-overhaul branch

That's nice to hear!

Katrina.TU chat
On Jul 4, 2019 11:40 AM, Ilgaz Er<EMAIL_ADDRESS>wrote:
That's nice to hear!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/commons-app/apps-android-commons/issues/3026?email_source=notifications&email_token=AJI7XQD3FL3MCQ7FO6BQ5X3P5YRW5A5CNFSM4HYXQMD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZH2KCA#issuecomment-508536072, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJI7XQFOEYXGIV77KN4M5BDP5YRW5ANCNFSM4HYXQMDQ.

I also completed searchCategory :)

Added suggested test flows - if anyone wants to help with testing, we would greatly appreciate that, as more eyes are better. :) I will start testing soon.

Does the backend-overhaul branch work for anyone else at the moment? After logging in I cannot even test any of the upload flows, because my main screen is completely empty (as in, there isn't even the upload FAB, lol).
I submitted logs to the forum, will check them and hopefully find the problem.

@misaochan Can you test on a clean install?

@maskaravivek This is a clean install.

Beta debug, API 26 emulator
-I was already logged in an uploaded an image successfully. But having no progressbar during upload seemed a little weird. I checked uploaded image page, everything seemed well to me.
Then I logged out and in, what I see is same with @misaochan :

Here are the logs I see on clicking home from navbar:
*.wiktionary.org *.wmflabs.org wikimediafoundation.org mediawiki.org *.mediawiki.org wss://tools.wmflabs.org; report-uri https://tools.wmflabs.org/csp-report/collect;
2019-07-11 00:47:39.803 9245-9962/fr.free.nrw.commons.beta V/OkHttp: 402
2019-07-11 00:47:39.804 9245-9962/fr.free.nrw.commons.beta V/OkHttp: <-- END HTTP (4-byte body)
2019-07-11 00:47:39.842 9245-10457/fr.free.nrw.commons.beta V/OkHttp: <-- 200 https://tools.wmflabs.org/urbanecmbot/commonsmisc/feedback.py?labs=commonswiki&user=Neslihan%20Test (597ms)
2019-07-11 00:47:39.842 9245-10457/fr.free.nrw.commons.beta V/OkHttp: server: nginx/1.13.6
2019-07-11 00:47:39.842 9245-10457/fr.free.nrw.commons.beta V/OkHttp: date: Wed, 10 Jul 2019 21:47:40 GMT
2019-07-11 00:47:39.842 9245-10457/fr.free.nrw.commons.beta V/OkHttp: content-length: 31
2019-07-11 00:47:39.842 9245-10457/fr.free.nrw.commons.beta V/OkHttp: access-control-allow-origin: *
2019-07-11 00:47:39.842 9245-10457/fr.free.nrw.commons.beta V/OkHttp: strict-transport-security: max-age=86400
2019-07-11 00:47:39.842 9245-10457/fr.free.nrw.commons.beta V/OkHttp: x-clacks-overhead: GNU Terry Pratchett
2019-07-11 00:47:39.842 9245-10457/fr.free.nrw.commons.beta V/OkHttp: content-security-policy-report-only: default-src 'self' 'unsafe-eval' 'unsafe-inline' blob: data: filesystem: mediastream: wikibooks.org *.wikibooks.org wikidata.org *.wikidata.org wikimedia.org *.wikimedia.org wikinews.org *.wikinews.org wikipedia.org *.wikipedia.org wikiquote.org *.wikiquote.org wikisource.org *.wikisource.org wikiversity.org *.wikiversity.org wikivoyage.org *.wikivoyage.org wiktionary.org *.wiktionary.org *.wmflabs.org wikimediafoundation.org mediawiki.org *.mediawiki.org wss://tools.wmflabs.org; report-uri https://tools.wmflabs.org/csp-report/collect;
2019-07-11 00:47:39.843 9245-10457/fr.free.nrw.commons.beta V/OkHttp: Content-type: application/json
2019-07-11 00:47:39.843 9245-10457/fr.free.nrw.commons.beta V/OkHttp: <-- END HTTP (31-byte body)
2019-07-11 00:47:39.844 9245-10457/fr.free.nrw.commons.beta D/OkHttpJsonApiClient: Response for achievements is Content-type: application/json
2019-07-11 00:47:39.844 9245-9283/fr.free.nrw.commons.beta D/EGL_emulation: eglMakeCurrent: 0xa27055a0: ver 2 0 (tinfo 0xa2703500)
2019-07-11 00:47:39.898 9245-10460/fr.free.nrw.commons.beta D/OkHttp: <-- 200 https://commons.wikimedia.beta.wmflabs.org/w/api.php?format=json&formatversion=2&errorformat=plaintext&action=query&meta=notifications&notformat=model&notlimit=max&notwikis=wikidatawiki%7Ccommonswiki%7Cenwiki&notfilter=%21read (656ms)
2019-07-11 00:47:39.898 9245-10460/fr.free.nrw.commons.beta D/OkHttp: date: Wed, 10 Jul 2019 21:47:40 GMT
2019-07-11 00:47:39.898 9245-10460/fr.free.nrw.commons.beta D/OkHttp: content-type: application/json; charset=utf-8
2019-07-11 00:47:39.898 9245-10460/fr.free.nrw.commons.beta D/OkHttp: server: deployment-mediawiki-09.deployment-prep.eqiad.wmflabs
2019-07-11 00:47:39.898 9245-10460/fr.free.nrw.commons.beta D/OkHttp: x-powered-by: HHVM/3.18.6-dev
2019-07-11 00:47:39.898 9245-10460/fr.free.nrw.commons.beta D/OkHttp: x-frame-options: DENY
2019-07-11 00:47:39.898 9245-10460/fr.free.nrw.commons.beta D/OkHttp: x-content-type-options: nosniff
2019-07-11 00:47:39.898 9245-10460/fr.free.nrw.commons.beta D/OkHttp: content-disposition: inline; filename=api-result.json
2019-07-11 00:47:39.899 9245-10460/fr.free.nrw.commons.beta D/OkHttp: cache-control: private, must-revalidate, max-age=0
2019-07-11 00:47:39.899 9245-10460/fr.free.nrw.commons.beta D/OkHttp: backend-timing: D=447017 t=1562795259908954
2019-07-11 00:47:39.899 9245-10460/fr.free.nrw.commons.beta D/OkHttp: vary: Accept-Encoding,X-Seven
2019-07-11 00:47:39.899 9245-10460/fr.free.nrw.commons.beta D/OkHttp: x-varnish: 223062829, 55652876
2019-07-11 00:47:39.899 9245-10460/fr.free.nrw.commons.beta D/OkHttp: via: 1.1 varnish (Varnish/5.1), 1.1 varnish (Varnish/5.1)
2019-07-11 00:47:39.899 9245-10460/fr.free.nrw.commons.beta D/OkHttp: accept-ranges: bytes
2019-07-11 00:47:39.899 9245-10460/fr.free.nrw.commons.beta D/OkHttp: age: 0
2019-07-11 00:47:39.899 9245-10460/fr.free.nrw.commons.beta D/OkHttp: x-cache: deployment-cache-text05 pass, deployment-cache-text05 pass
2019-07-11 00:47:39.899 9245-10460/fr.free.nrw.commons.beta D/OkHttp: x-cache-status: pass
2019-07-11 00:47:39.899 9245-10460/fr.free.nrw.commons.beta D/OkHttp: server-timing: cache;desc="pass"
2019-07-11 00:47:39.899 9245-10460/fr.free.nrw.commons.beta D/OkHttp: x-analytics: WMF-Last-Access=10-Jul-2019;WMF-Last-Access-Global=10-Jul-2019;https=1
2019-07-11 00:47:39.899 9245-10460/fr.free.nrw.commons.beta D/OkHttp: x-client-ip: <IP_ADDRESS>
2019-07-11 00:47:39.900 9245-10460/fr.free.nrw.commons.beta D/OkHttp: {"batchcomplete":true,"limits":{"notifications":50},"query":{"notifications":{"list":[{"wiki":"commonswiki","id":5919,"type":"edit-thank","category":"edit-thank","section":"message","timestamp":{"utciso8601":"2019-03-21T11:35:45Z","utcunix":"1553168145","unix":"1553168145","utcmw":"20190321113545","mw":"20190321113545","date":"21 March"},"title":{"full":"File:Deneme 2.jpg","namespace":"File","namespace-key":6,"text":"Deneme 2.jpg"},"agent":{"id":2265,"name":"Silky Priya 44"},"revid":106467,"targetpages":[],"*":{"header":"Silky Priya 44 thanked you for your creation of File:Deneme 2.jpg.","compactHeader":"Silky Priya 44 thanked you.","body":"Uploaded using [[COM:MOA|Commons Mobile App]]","icon":"thanks","links":{"primary":{"url":"https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=File:Deneme_2.jpg&oldid=prev&diff=106467&markasread=5919&markasreadwiki=commonswiki","label":"View edit"},"secondary":[{"url":"https://commons.wikimedia.beta.wmflabs.org/wiki/User:Silky_Priya_44","label":"Silky Priya 44","tooltip":"","description":"","icon":"userAvatar","prioritized":true},{"url":"https://commons.wikimedia.beta.wmflabs.org/wiki/File:Deneme_2.jpg","label":"Deneme 2.jpg","tooltip":"File:Deneme 2.jpg","description":null,"icon":"article","prioritized":true}]},"iconUrl":"/w/extensions/Thanks/userTalk-constructive-ltr.svg"}},{"wiki":"commonswiki","id":5956,"type":"edit-thank","category":"edit-thank","section":"message","timestamp":{"utciso8601":"2019-03-25T08:20:26Z","utcunix":"1553502026","unix":"1553502026","utcmw":"20190325082026","mw":"20190325082026","date":"25 March"},"title":{"full":"File:1 2.jpg","namespace":"File","namespace-key":6,"text":"1 2.jpg"},"agent":{"id":2218,"name":"Aanshika"},"revid":106442,"targetpages":[],"*":{"header":"Aanshika thanked you for your creation of File:1 2.jpg.","compactHeader":"Aanshika thanked you.","body":"Uploaded using [[COM:MOA|Commons Mobile App]]","icon":"thanks","links":{"primary":{"url":"https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=File:1_2.jpg&oldid=prev&diff=106442&markasread=5956&markasreadwiki=commonswiki","label":"View edit"},"secondary":[{"url":"https://commons.wikimedia.beta.wmflabs.org/wiki/User:Aanshika","label":"Aanshika","tooltip":"","description":"","icon":"userAvatar","prioritized":true},{"url":"https://commons.wikimedia.beta.wmflabs.org/wiki/File:1_2.jpg","label":"1 2.jpg","tooltip":"File:1 2.jpg","description":null,"icon":"article","prioritized":true}]},"iconUrl":"/w/extensions/Thanks/userTalk-constructive-ltr.svg"}},{"wiki":"commonswiki","id":5967,"type":"edit-thank","category":"edit-thank","section":"message","timestamp":{"utciso8601":"2019-03-25T08:41:07Z","utcunix":"1553503267","unix":"1553503267","utcmw":"20190325084107","mw":"20190325084107","date":"25 March"},"title":{"full":"File:Test2 3.jpg","namespace":"File","namespace-key":6,"text":"Test2 3.jpg"},"agent":{"id":2218,"name":"Aanshika"},"revid":106464,"targetpages":[],"*":{"header":"Aanshika thanked you for your creation of File:Test2 3.jpg.","compactHeader":"Aanshika thanked you.","body":"Uploaded using [[COM:MOA|Commons Mobile App]]","icon":"thanks","links":{"primary":{"url":"https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=File:Test2_3.jpg&oldid=prev&diff=106464&markasread=5967&markasreadwiki=commonswiki","label":"View edit"},"secondary":[{"url":"https://commons.wikimedia.beta.wmflabs.org/wiki/User:Aanshika","label":"Aanshika","tooltip":"","description":"","icon":"userAvatar","prioritized":true},{"url":"https://commons.wikimedia.beta.wmflabs.org/wiki/File:Test2_3.jpg","label":"Test2 3.jpg","tooltip":"File:Test2 3.jpg","description":null,"icon":"article","prioritized":true}]},"iconUrl":"/w/extensions/Thanks/userTalk-constructive-ltr.svg"}},{"wiki":"commonswiki","id":5974,"type":"edit-thank","category":"edit-thank","section":"message","timestamp":{"utciso8601":"2019-03-25T09:27:46Z","utcunix":"1553506066
2019-07-11 00:47:39.900 9245-10460/fr.free.nrw.commons.beta D/OkHttp: ,"unix":"1553506066","utcmw":"20190325092746","mw":"20190325092746","date":"25 March"},"title":{"full":"File:Tes.jpg","namespace":"File","namespace-key":6,"text":"Tes.jpg"},"agent":{"id":2218,"name":"Aanshika"},"revid":106441,"targetpages":[],"*":{"header":"Aanshika thanked you for your creation of File:Tes.jpg.","compactHeader":"Aanshika thanked you.","body":"Uploaded using [[COM:MOA|Commons Mobile App]]","icon":"thanks","links":{"primary":{"url":"https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=File:Tes.jpg&oldid=prev&diff=106441&markasread=5974&markasreadwiki=commonswiki","label":"View edit"},"secondary":[{"url":"https://commons.wikimedia.beta.wmflabs.org/wiki/User:Aanshika","label":"Aanshika","tooltip":"","description":"","icon":"userAvatar","prioritized":true},{"url":"https://commons.wikimedia.beta.wmflabs.org/wiki/File:Tes.jpg","label":"Tes.jpg","tooltip":"File:Tes.jpg","description":null,"icon":"article","prioritized":true}]},"iconUrl":"/w/extensions/Thanks/userTalk-constructive-ltr.svg"}},{"wiki":"commonswiki","id":6315,"type":"edit-thank","category":"edit-thank","section":"message","timestamp":{"utciso8601":"2019-04-25T12:48:42Z","utcunix":"1556196522","unix":"1556196522","utcmw":"20190425124842","mw":"20190425124842","date":"25 April"},"title":{"full":"File:Test 117.jpg","namespace":"File","namespace-key":6,"text":"Test 117.jpg"},"agent":{"id":2293,"name":"Nahid"},"revid":107410,"targetpages":[],"*":{"header":"Nahid thanked you for your creation of File:Test 117.jpg.","compactHeader":"Nahid thanked you.","body":"Uploaded using [[COM:MOA|Commons Mobile App]]","icon":"thanks","links":{"primary":{"url":"https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=File:Test_117.jpg&oldid=prev&diff=107410&markasread=6315&markasreadwiki=commonswiki","label":"View edit"},"secondary":[{"url":"https://commons.wikimedia.beta.wmflabs.org/wiki/User:Nahid","label":"Nahid","tooltip":"","description":"","icon":"userAvatar","prioritized":true},{"url":"https://commons.wikimedia.beta.wmflabs.org/wiki/File:Test_117.jpg","label":"Test 117.jpg","tooltip":"File:Test 117.jpg","description":null,"icon":"article","prioritized":true}]},"iconUrl":"/w/extensions/Thanks/userTalk-constructive-ltr.svg"}},{"wiki":"commonswiki","id":6320,"type":"edit-thank","category":"edit-thank","section":"message","timestamp":{"utciso8601":"2019-04-25T14:15:44Z","utcunix":"1556201744","unix":"1556201744","utcmw":"20190425141544","mw":"20190425141544","date":"25 April"},"title":{"full":"File:Test XMP on.jpg","namespace":"File","namespace-key":6,"text":"Test XMP on.jpg"},"agent":{"id":2293,"name":"Nahid"},"revid":108055,"targetpages":[],"*":{"header":"Nahid thanked you for your creation of File:Test XMP on.jpg.","compactHeader":"Nahid thanked you.","body":"Uploaded using [[COM:MOA|Commons Mobile App]]","icon":"thanks","links":{"primary":{"url":"https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=File:Test_XMP_on.jpg&oldid=prev&diff=108055&markasread=6320&markasreadwiki=commonswiki","label":"View edit"},"secondary":[{"url":"https://commons.wikimedia.beta.wmflabs.org/wiki/User:Nahid","label":"Nahid","tooltip":"","description":"","icon":"userAvatar","prioritized":true},{"url":"https://commons.wikimedia.beta.wmflabs.org/wiki/File:Test_XMP_on.jpg","label":"Test XMP on.jpg","tooltip":"File:Test XMP on.jpg","description":null,"icon":"article","prioritized":true}]},"iconUrl":"/w/extensions/Thanks/userTalk-constructive-ltr.svg"}},{"wiki":"commonswiki","id":6321,"type":"edit-thank","category":"edit-thank","section":"message","timestamp":{"utciso8601":"2019-04-25T14:19:18Z","utcunix":"1556201958","unix":"1556201958","utcmw":"20190425141918","mw":"20190425141918","date":"25 April"},"title":{"full":"File:Testing default exif values2.jpg","namespace":"File","namespace-key":6,"text":"Testing default exif values2.jpg"},"agent":{"id":2293,"name":"Nahid"},"revid":108050,"targetpage
2019-07-11 00:47:39.900 9245-10460/fr.free.nrw.commons.beta D/OkHttp: ":[],"*":{"header":"Nahid thanked you for your creation of File:Testing default exif values2.jpg.","compactHeader":"Nahid thanked you.","body":"Uploaded using [[COM:MOA|Commons Mobile App]]","icon":"thanks","links":{"primary":{"url":"https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=File:Testing_default_exif_values2.jpg&oldid=prev&diff=108050&markasread=6321&markasreadwiki=commonswiki","label":"View edit"},"secondary":[{"url":"https://commons.wikimedia.beta.wmflabs.org/wiki/User:Nahid","label":"Nahid","tooltip":"","description":"","icon":"userAvatar","prioritized":true},{"url":"https://commons.wikimedia.beta.wmflabs.org/wiki/File:Testing_default_exif_values2.jpg","label":"Testing default...","tooltip":"File:Testing default exif values2.jpg","description":null,"icon":"article","prioritized":true}]},"iconUrl":"/w/extensions/Thanks/userTalk-constructive-ltr.svg"}},{"wiki":"commonswiki","id":6797,"type":"login-fail-new","category":"login-fail","section":"alert","timestamp":{"utciso8601":"2019-06-10T09:22:06Z","utcunix":"1560158526","unix":"1560158526","utcmw":"20190610092206","mw":"20190610092206","date":"10 June"},"agent":{"id":1694,"name":"Neslihan Test"},"targetpages":[],"*":{"header":"There has been a failed attempt to log in to your account from a new device. Please make sure your account has a strong password.","compactHeader":"There has been a failed attempt to log in to your account from a new device. Please make sure your account has a strong password.","body":"","icon":"LoginNotify-user-avatar","links":{"primary":{"url":"https://mediawiki.org/wiki/Help:Login_notifications?markasread=6797&markasreadwiki=commonswiki","label":"Help"},"secondary":[{"url":"https://commons.wikimedia.beta.wmflabs.org/wiki/Special:ChangePassword","label":"Change password","description":"","icon":"lock","prioritized":true}]},"iconUrl":"/w/extensions/LoginNotify/UserAvatar.svg"}}],"continue":null}}}
2019-07-11 00:47:39.900 9245-10460/fr.free.nrw.commons.beta D/OkHttp: <-- END HTTP (10103-byte body)
2019-07-11 00:47:40.004 1436-6524/? W/audio_hw_generic: Not supplying enough data to HAL, expected position 7139808 , only wrote 7139520
2019-07-11 00:47:40.005 1436-6524/? W/audio_hw_generic: Not supplying enough data to HAL, expected position 7139530 , only wrote 7139520
2019-07-11 00:47:40.094 1436-6524/? W/audio_hw_generic: Not supplying enough data to HAL, expected position 7143819 , only wrote 7143120
2019-07-11 00:47:40.096 1436-6524/? W/audio_hw_generic: Not supplying enough data to HAL, expected position 7143220 , only wrote 7143120
2019-07-11 00:47:40.182 1436-6524/? W/audio_hw_generic: Not supplying enough data to HAL, expected position 7147256 , only wrote 7146720
2019-07-11 00:47:40.183 1436-6524/? W/audio_hw_generic: Not supplying enough data to HAL, expected position 7146726 , only wrote 7146720
2019-07-11 00:47:40.204 1436-6524/? W/audio_hw_generic: Not supplying enough data to HAL, expected position 7147759 , only wrote 7147440
2019-07-11 00:47:40.236 1436-6524/? W/audio_hw_generic: Not supplying enough data to HAL, expected position 7148964 , only wrote 7148160
2019-07-11 00:47:40.271 9245-9283/fr.free.nrw.commons.beta D/EGL_emulation: eglMakeCurrent: 0xa27055a0: ver 2 0 (tinfo 0xa2703500)
2019-07-11 00:47:40.286 1436-6524/? W/audio_hw_generic: Not supplying enough data to HAL, expected position 7150540 , only wrote 7150320
2019-07-11 00:47:40.299 9245-9245/fr.free.nrw.commons.beta D/MainActivity: Number of notifications is 8
2019-07-11 00:47:40.324 1436-6524/? W/audio_hw_generic: Not supplying enough data to HAL, expected position 7152146 , only wrote 7151760
2019-07-11 00:47:40.444 1436-6524/? W/audio_hw_generic: Not supplying enough data to HAL, expected position 7157538 , only wrote 7156800
2019-07-11 00:47:40.448 1436-6524/? W/audio_hw_generic: Not supplying enough data to HAL, expected position 7156993 , only wrote 7156800
2019-07-11 00:47:40.473 1436-6524/? W/audio_hw_generic: Not supplying enough data to HAL, expected position 7158007 , only wrote 7157520
2019-07-11 00:47:40.473 1436-6524/? W/audio_hw_generic: Not supplying enough data to HAL, expected position 7157525 , only wrote 7157520
2019-07-11 00:47:40.646 9245-9283/fr.free.nrw.commons.beta D/OpenGLRenderer: endAllActiveAnimators on 0x8b23a400 (NavigationMenuItemView) with handle 0x8e7d2c20
2019-07-11 00:47:41.355 1679-1697/system_process E/BatteryStatsService: modem info is invalid: ModemActivityInfo{ mTimestamp=0 mSleepTimeMs=0 mIdleTimeMs=0 mTxTimeMs[]=[0, 0, 0, 0, 0] mRxTimeMs=0 mEnergyUsed=0}
2019-07-11 00:47:41.932 2231-9231/com.google.android.gms.persistent W/ctxmgr: [AclManager]No 2 for (accnt=account#-517948760#, com.google.android.gms(10013):IndoorOutdoorProducer, vrsn=13280000, 0, 3pPkg = null ,  3pMdlId = null ,  pid = 2231). Was: 3 for 57, account#-517948760#
2019-07-11 00:47:42.258 1436-1637/? W/audio_hw_generic: Not supplying enough data to HAL, expected position 7327981 , only wrote 7243200
2019-07-11 00:47:45.687 9245-9271/fr.free.nrw.commons.beta I/zygote: Explicit concurrent copying GC freed 22305(1550KB) AllocSpace objects, 7(144KB) LOS objects, 49% free, 4MB/9MB, paused 143us total 19.445ms
2019-07-11 00:47:46.932 2231-9231/com.google.android.gms.persistent W/ctxmgr: [AclManager]No 2 for (accnt=account#-517948760#, com.google.android.gms(10013):IndoorOutdoorProducer, vrsn=13280000, 0, 3pPkg = null ,  3pMdlId = null ,  pid = 2231). Was: 3 for 57, account#-517948760#
2019-07-11 00:47:48.294 1450-1450/? I/boot-pipe: done populating /dev/random

Notifications activiy is correct but the notification bell number is wrong, it does not change even if after I read notificationsw (possibly not related with this PR).

Achievements worked fine on me:

BTW, I also realized that we cannot rely on users doing a fresh install - most users will just be updating their app automatically, not uninstalling and reinstalling. So we must make sure that our final solution works regardless of fresh install or not.

Tested with real device running Android 8.1 today.
Successes:

Contributions and the FAB etc loads now! 👍
Single upload from Gallery succeeded - https://commons.wikimedia.org/wiki/File:Mushroom_chicken_tea_broth.jpg. Category selection works as expected. Author, license, etc is correct.
Multiple uploads with Google Photos succeeded. This one seems to have the dates correct - https://commons.wikimedia.org/wiki/File:Newstead_house.jpg

Issues found with Contributions:

My "Contributions" tab says (0).

Issues found with single uploads (with Android stock gallery):

My description defaulted to Afrikaans even though "en" was the default desc language - https://commons.wikimedia.org/wiki/File:Mushroom_chicken_tea_broth.jpg
Dates appear to be using the upload date again instead of the date taken - the picture above was taken on 15 Jul

Issues found with multiple uploads (with Android stock gallery):

Unable to select more than 1 image in Android stock gallery. It works for Google Photos.

Issues found with multiple uploads (with Google Photos)

My description defaulted to Afrikaans even though "en" was the default desc language

For me, similar to @misaochan 's. Achievements is blank screen:

Contributions loads this time.
Uploads works.
Potential upload issue warnings displayed.
Nearest place notification permission is requested after selecting nearby tab and coming back to contributions tab, it didn't ask on start (possibly irrelevant)
Contributions is not zero for me, it says 100 in my case

Logs:
2019-07-16 16:12:05.565 7851-7851/fr.free.nrw.commons.beta E/DialogUtil: Could not show dialog.
    java.lang.IllegalStateException: The specified child already has a parent. You must call removeView() on the child's parent first.
        at android.view.ViewGroup.addViewInner(ViewGroup.java:4915)
        at android.view.ViewGroup.addView(ViewGroup.java:4746)
        at android.view.ViewGroup.addView(ViewGroup.java:4718)
        at com.android.internal.app.AlertController.setupCustomContent(AlertController.java:606)
        at com.android.internal.app.AlertController.setupView(AlertController.java:500)
        at com.android.internal.app.AlertController.installContent(AlertController.java:258)
        at android.app.AlertDialog.onCreate(AlertDialog.java:425)
        at android.app.Dialog.dispatchOnCreate(Dialog.java:403)
        at android.app.Dialog.show(Dialog.java:302)
        at fr.free.nrw.commons.utils.DialogUtil.showSafely(DialogUtil.java:33)
        at fr.free.nrw.commons.utils.DialogUtil.showAlertDialog(DialogUtil.java:140)
        at fr.free.nrw.commons.utils.DialogUtil.showAlertDialog(DialogUtil.java:96)
        at fr.free.nrw.commons.contributions.ContributionsFragment.showNearbyCardPermissionRationale(ContributionsFragment.java:508)
        at fr.free.nrw.commons.contributions.ContributionsFragment.checkPermissionsAndShowNearbyCardView(ContributionsFragment.java:489)
        at fr.free.nrw.commons.contributions.ContributionsFragment.onResume(ContributionsFragment.java:469)
        at androidx.fragment.app.Fragment.performResume(Fragment.java:2499)
        at androidx.fragment.app.FragmentManagerImpl.moveToState(FragmentManagerImpl.java:926)
        at androidx.fragment.app.FragmentManagerImpl.moveFragmentToExpectedState(FragmentManagerImpl.java:1229)
        at androidx.fragment.app.FragmentManagerImpl.moveToState(FragmentManagerImpl.java:1295)
        at androidx.fragment.app.FragmentManagerImpl.dispatchStateChange(FragmentManagerImpl.java:2605)
        at androidx.fragment.app.FragmentManagerImpl.dispatchResume(FragmentManagerImpl.java:2577)
        at androidx.fragment.app.FragmentController.dispatchResume(FragmentController.java:267)
        at androidx.fragment.app.FragmentActivity.onResumeFragments(FragmentActivity.java:463)
        at androidx.fragment.app.FragmentActivity.onPostResume(FragmentActivity.java:453)
        at androidx.appcompat.app.AppCompatActivity.onPostResume(AppCompatActivity.java:173)
        at android.app.Activity.performResume(Activity.java:7103)
        at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3620)
        at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3685)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1643)
        at android.os.Handler.dispatchMessage(Handler.java:105)
        at android.os.Looper.loop(Looper.java:164)
        at android.app.ActivityThread.main(ActivityThread.java:6541)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)
2019-07-16 16:12:05.567 7851-7851/fr.free.nrw.commons.beta E/ContributionsFragment: onFragmentResumed fr.free.nrw.commons.contributions.ContributionsListFragment
2019-07-16 16:12:06.551 7851-7851/fr.free.nrw.commons.beta E/QuizChecker: Fetching upload count failed
    java.lang.IllegalStateException: closed
        at okio.RealBufferedSource.rangeEquals(RealBufferedSource.java:407)
        at okio.RealBufferedSource.rangeEquals(RealBufferedSource.java:401)
        at okhttp3.internal.Util.bomAwareCharset(Util.java:471)
        at okhttp3.ResponseBody.string(ResponseBody.java:175)
        at fr.free.nrw.commons.mwapi.OkHttpJsonApiClient.lambda$getUploadCount$0(OkHttpJsonApiClient.java:102)
        at fr.free.nrw.commons.mwapi.-$$Lambda$OkHttpJsonApiClient$9ZpGX0U5Zngts_jcRCFls7FtEIM.call(Unknown Source:4)
        at io.reactivex.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:44)
        at io.reactivex.Single.subscribe(Single.java:3438)
        at io.reactivex.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
        at io.reactivex.Scheduler$DisposeTask.run(Scheduler.java:578)
        at io.reactivex.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:66)
        at io.reactivex.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:57)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:301)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
        at java.lang.Thread.run(Thread.java:764)

Can you also update the list?

These are both waiting for wikimedia-android-data-client PR's

logEvents -> wikimedia/wikimedia-android-data-client#22
isUserBlockedFromCommons -> wikimedia/wikimedia-android-data-client#23

Can you also update the list?

Which list do you mean?

These are both waiting for wikimedia-android-data-client PR's

Thanks for your help with all this @ilgazer ! :) Let me know if it hasn't been merged after a week or so and I'll try to ping the maintainer.

These are both waiting for wikimedia-android-data-client PR's

They no longer are! Their PR's are waiting for merge, but a completely unrelated test is failing for some reason.

I think @ilgazer 's PR can be merged, I have tried testing them locally and both seem to work fine on my machine. What do you say @maskaravivek  ?

@ashishkumar468 Yes, lets merge @ilgazer PRs.

Other than the contributions (upload count and possible display inconsistency), and notification progress issue and the achievements bug, is there anything else remaining in this PR ?

There is CategoryApi, a class that thtat uses JSON but should be migrated
to retrofit.
On Sat, 14 Sep 2019 at 22:20, Ashish Kumar<EMAIL_ADDRESS>wrote:

Other than the contributions (upload count and possible display
inconsistency), and notification progress issue and the achievements bug,
is there anything else remaining in this PR ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/commons-app/apps-android-commons/issues/3026?email_source=notifications&email_token=AB2EXI7YC2HR7PWKFNHYZQDQJU2ORA5CNFSM4HYXQMD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6XCKAI#issuecomment-531506433,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB2EXI5E5KMLVFYWTPCUC3DQJU2ORANCNFSM4HYXQMDQ
.

Thanks @ilgazer  :)

Other than the contributions (upload count and possible display inconsistency), and notification progress issue and the achievements bug, is there anything else remaining in this PR ?

Wikidata edits is still not sorted. We might need external help for it.

Other than the contributions (upload count and possible display inconsistency), and notification progress issue and the achievements bug, is there anything else remaining in this PR ?

Thanks for fixing the Achievements and wrong upload count in #3151  @ashishkumar468 . :) Based on
https://github.com/commons-app/apps-android-commons/issues/3026#issuecomment-511732535 , it seems like the remaining issues are:

Very interesting bug - as you can see, these image titles do not match the images. This happened after I logged out of misaochan and onto misaochan2. So the titles are the titles of misaochan2's uploads, but the images are the images of misaochan's uploads.
Furthermore, after logging back into misaochan, the images are mine and the titles are mine, but out of sync. So the first image has the title of the most recent image uploaded, but the image shown is actually the one that belongs to an upload that is 4 items down.
Issues found with single uploads (with Android stock gallery):
My description defaulted to Afrikaans even though "en" was the default desc language - https://commons.wikimedia.org/wiki/File:Mushroom_chicken_tea_broth.jpg
Dates appear to be using the upload date again instead of the date taken - the picture above was taken on 15 Jul
Issues found with multiple uploads (with Android stock gallery):
Unable to select more than 1 image in Android stock gallery. It works for Google Photos.
Issues found with multiple uploads (with Google Photos):
My description defaulted to Afrikaans even though "en" was the default desc language

Wrong dates: Dates appear to be using the upload date again instead of the date taken - the picture above was taken on 15 Jul

IMO we should rewrite FileProcessor and the weird code surrounding it. That will probably also resolve this bug. I've started working on it.

@misaochan  I am not able to reproduce this . "Issues found with multiple uploads (with Android stock gallery): Unable to select more than 1 image in Android stock gallery. It works for Google Photos.". Can you reverify this on the latest commit form this branch, a screenshot for the same would be better, could be a device-specific issue. Just to confirm that is is a bug added by this branch, can you see if the same works for you on master.

@misaochan About this " Dates appear to be using the upload date again instead of the date taken - the picture above was taken on 15 Jul", I am not able to reproduce this as well, I uploaded one of the images you had sent me (created date 20/05/2016), which seems to show up correctly the web app as well. Attaching the screenshot for the same

@ashishkumar468 I can't quite figure out the date bug. Upon testing the current version of backend-overhaul, I now get a completely unrelated date.
For instance, I uploaded https://commons.wikimedia.org/wiki/File:Jacaranda_in_bloom.jpg from Google Photos single upload. The template says the photo's date is 7 September, but I definitely took it on 7 October. The EXIF information on Google Photos corresponds to that.

Hi @misaochan , If this is the case, I am sure this must be there on master as well, if that comes out to be true, can we take that separately?

Sure, I'm OK with merging backend-overhaul to master with this bug present (might be easier than trying to fix everything before merging), but we still have to fix it before releasing v2.12 with it. :)

@misaochan I am not able to reproduce this . "Issues found with multiple uploads (with Android stock gallery): Unable to select more than 1 image in Android stock gallery. It works for Google Photos.". Can you reverify this on the latest commit form this branch, a screenshot for the same would be better, could be a device-specific issue.

Yes, the problem still occurs for me on the latest commit. I tested using a Samsung Galaxy s9 running Android 9.0.
This is the stock Android gallery after tapping the FAB "+"  button > Gallery. Long-pressing on any image does not initiate multiple selection.

This is the Google Photos gallery after tapping the FAB "+" button > Photos.

I recall encountering a similar problem when we were selecting an image picker library to implement #604 (see also #2286)

Hi @misaochan, Can you verify if this is happening to you on master as well ?

Oops, another bug... when I was testing #3166 I uploaded a file titled "Story Bridge". The app warned me that the file exists, as it should, but it did not add a numbered suffix as it usually does. Instead, it rewrote https://commons.wikimedia.org/wiki/File:Story_Bridge.jpg
(I will test master for the multiple uploads afterwards)

@misaochan So if it does not work for you on master as well, we should probably create a separate issue for that. I am sure this is something device-specific (weird though). Thanks for finding the other bug JO, I will look into that, so other than cross-wiki thing, only this is left on backend-ovberhaul, right ?

Yeah, if it works on your device, I think it's OK to address it separately. In order to be considered complete, the backend overhaul task needs 2FA logins to work in addition to the overwrite bug and cross-wiki calls. But it should be fine to merge the backend-overhaul branch to master after the overwrite bug is fixed, so that alpha testers can try it asap.

All the items in this task have now been completed. Closing this issue now. :)
Thank you, everyone, for your contributions. :)


Fix glob

It will soon be an error for a glob to return an empty set. This is
gated behind --incompatible_disallow_empty_glob currently.

Linux/Mac have dotnet, Windows has dotnet.exe

Oh, so the glob items not resolving, not the glob as a whole


Expose configuration to the pipeline

Have there been any plans to expose the entire configuration object to the pipeline services (perhaps as part of instruction)? This could enable a relatively straightforward path to implement something like resolves.
Here's a possible example:
$router.config([
  {path: '/', redirectTo: '/main'},
  {path: '/main', component: 'Main', resolve: {
    somePromise: function($q){return $q.when()}
  }}
]);

.factory('routing.resolveStep', function ($q) {
  return function resolve(instruction) {
    var resolves = [];
    instruction.router.traverseInstruction(instruction, function (instruction) {
      var configuration = instruction.config() //reuse setter without argument? Or just getConfig()
      console.log(configuration.resolve); // {somePromise: function(..){..}}
      //push all resolves into array
    });
    return $q.all(resolves);
  };
})

There are alternatives, of course (say having the configuration as a constant somewhere else, and then just passing that into $router.config), but it seems to me like this would enable a cleaner API (and port easier between 1.x and 2.x).
I'm sure there are other properties that would make sense to have attached to some specific route that could also be used with this.

After some investigation, there is currently a way to access this information, but it's very clunky:
instruction.router.registry.rules['/'].recognize(instruction.canonicalUrl)[0].handler

This returns a handler for a specific rule. Is there perhaps a more canonical way to do this?


GDPR: do not track if user did not opt in

Hi guys, quick question, not really about the plugin itself, but on a higher level. I was hoping to get your views on this.
In Europe we have to follow the GDPR regulation. This means that we have to get the formal and unambiguous opt-in of users to track them via tracking cookies. Though there still is a grey area, I would like to start working on a foolproof solution.
What I thought about doing was to put a banner at the bottom of the site with a question: "Do you agree to be tracked: yes or no". When the user clicks "yes" a cookie is set. I would then test for this cookie in my layout, and only if the cookie is present, I would include the Rainlab Google Analytics partial.
What are your views on this? Do you think this is a fitting solution? Thanks in advance.

What are your views on this? Do you think this is a fitting solution? Thanks in advance.

Yes it is. You can use existing plugins, this one has handy GA example:
https://github.com/OFFLINE-GmbH/oc-gdpr-plugin#gdprcookieallowedcode-minlevel--0

Hi Eoler, thank you so much for your answer. The provided link does look very fitting. Is it compatible with the Rainlab Google Analytics plugin?

Is it compatible with the Rainlab Google Analytics plugin?

Yes, just swap GA include comment with a component reference.

Perfect, thank you!


query regarding vocab_article_source.json

Dear sir, I was implementing your paper, but while implementing I got the error " vocab_article_source.json" not found. Could you please share the file vocab_article_source.json  as it is not generated during the implementation? @Nicozwy

Dear sir, I was implementing your paper, but while implementing I got the error " vocab_article_source.json" not found. Could you please share the file vocab_article_source.json as it is not generated during the implementation? @Nicozwy

Thank you for your attention. You can simply create a new file with the name " vocab_article_source.json" because it is not used in the codes.  Or you can modify the running file to run it.

Dear sir, I was implementing your paper, but while implementing I got the error " vocab_article_source.json" not found. Could you please share the file vocab_article_source.json as it is not generated during the implementation? @Nicozwy

Thank you for your attention. You can simply create a new file with the name " vocab_article_source.json" because it is not used in the codes. Or you can modify the running file to run it.

Hello, have you solved this problem?
I have followed the solution given by the author set "vocab_article_source=None" in "tran_xxx.py ", and I create a new file with the name "vocab_article_source.json", but when I run the program, it's empty when I parse the" vocab_article_source.json" file, Is there anything else that needs to be changed in the code?
Looking forward to your early reply, thank you very much! @Nicozwy @gauravkumar62024

Dear sir, I was implementing your paper, but while implementing I got the error " vocab_article_source.json" not found. Could you please share the file vocab_article_source.json as it is not generated during the implementation? @Nicozwy

Thank you for your attention. You can simply create a new file with the name " vocab_article_source.json" because it is not used in the codes. Or you can modify the running file to run it.

Hello, have you solved this problem? I have followed the solution given by the author set "vocab_article_source=None" in "tran_xxx.py ", and I create a new file with the name "vocab_article_source.json", but when I run the program, it's empty when I parse the" vocab_article_source.json" file, Is there anything else that needs to be changed in the code? Looking forward to your early reply, thank you very much! @Nicozwy @gauravkumar62024

Create a vocab_article_source.json file in the required path. To avoid the error of an empty file for everyone, write the following content that does not affect the program operation in the file. You can write randomly because this file will not be used.
{
"article_sources": [
{
"id": 1,
"name": "Placeholder Source 1",
"domain": "placeholder.com"
},
{
"id": 2,
"name": "Placeholder Source 2",
"domain": "example.com"
}
]
}


DASH: no dash output for audio/video only stream

env:  branch: develop
git  : commit 6bbd461ec960652c65deaaa9356d79fac691dd6d
how to reproduce:

objs/srs -c conf/dash.conf
send rtmp stream to 1935 using ffmpeg
cd objs/nginx/html, no mpd file exist.
cd objs/nginx/html/live/stream, only audio-init.mp4  video-init.mp4 found.

Because you are publish a only video or only audio media resource.
Try another stream with both audio and video track, then after 3 fragment period, around 30 seconds, the mpd file will appear.
But it's a bug, let dash support single audio or single video stream.

No plan for supporting audio or video only stream in DASH.


Skip adding FSService to the runtime if it is not defined.

Addresses https://github.com/edx/XBlock/issues/291
@nedbat looks okay?

Coverage increased (+0.02%) to 90.63% when pulling 598dedcdc601a07a6f466ce1a4452732b590e213 on will/skip-pyfs-service into b4d8e81d571bcabc64bab3362f0c9effa6ce757d on master.

:+1:


⚠ Bofrost.be has degraded performance

In 809cba1, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1051 ms

Resolved: Bofrost.be performance has improved in 7b33443 after 15 minutes.


Branch ped bugs

Fix PED bugs

Codecov Report

Merging #172 (69c07c0) into master (04b1bfb) will increase coverage by 0.01%.
The diff coverage is 42.85%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff              @@
##             master     #172      +/-   ##
============================================
+ Coverage     56.65%   56.66%   +0.01%
- Complexity      596      597       +1
============================================
  Files           112      112
  Lines          2351     2354       +3
  Branches        269      270       +1
============================================
+ Hits           1332     1334       +2
- Misses          960      962       +2
+ Partials         59       58       -1

Impacted Files
Coverage Δ

...eedu/address/logic/commands/AssignTaskCommand.java
100.00% <ø> (ø)

...a/seedu/address/logic/commands/CommentCommand.java
35.13% <ø> (ø)

.../seedu/address/logic/commands/EditTaskCommand.java
0.00% <0.00%> (ø)

...du/address/logic/parser/EditTaskCommandParser.java
0.00% <0.00%> (ø)

...java/seedu/address/logic/commands/MarkCommand.java
85.71% <100.00%> (ø)

...va/seedu/address/logic/commands/UnmarkCommand.java
93.33% <100.00%> (ø)

.../seedu/address/logic/parser/EditCommandParser.java
92.59% <100.00%> (+0.28%)
:arrow_up:

... and 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Implement error reporting for the new compiler (closes #305)

\cc @churkin @kirovboris @AndreyBelym
@VasilyStrelyaev please, check strings, comments, etc.
Here is how it looks like in CLI

Clean stacks (no babel, node or testcafe stuff, just test sources)
Proper formatting
Fancy call sites for our API (we will use same appearance in reports)

Our API error:

Babel/syntax error:

Runtime error:

@testcafe-build-bot \retest

\r-

FPR

lgtm

lgtm

lgtm

lgtm, @testcafe-build-bot \retest

@testcafe-build-bot \retest


Feature request - pore network construction for irregular granular packings

Most of your very interesting work and code development has focused on CT imagery and rock micro-pores.
Do you think you will/might/could develop code to construct and analyse irregular granular packings?
For example gravel and rock-filled trenches, railroad ballast etc.
In the back of my mind is a comment by Jeff Gostick @OpenPNM regarding the generation of pore networks without having to archive or manage large CT image databases.
The intention would be to analyse these irregular granular packing using DeePore, and then to model root growth in the network using DuMuX. At the moment I have yade-dem, but it would be good to have an alternative experimental approach to pore network construction for irregular granular packings without the computational overhead of CT scans.
The analysis with DeePore would start simple, then develop in complexity as small granular particles (e.g. biochar) are mixed into the aggregate material.
By irregular I mean the modelling work conducted by Suhr et al.2020 on ballast aggregates, which would also be applicable to trenches filled with aggregate. Aggregate models (.ply) available on Zenodo.
https://zenodo.org/record/3689592
van der Linden et al. 2018 developed an approach to pore network construction for spherical granular packings.
It is available on GitHub: https://github.com/joosthvanderlinden/SPNC
Thanks

Thanks. Dr. Suhr's work is both open source and seems useful in multiple ways.
Looking at it right now, DeePore has very helpful analytical output for mixed granular packings.
My thoughts so far:
What is needed is to randomly generate and compact granular pore networks. Yade-DEM has some useful python scripts and models for granular compaction.
Then to analyse the pore characteristics of the packing using DeePore. Some of these attributes will feed into subsequent models in the pipeline.
Followed by analyses based on the DuMuX models of Koch and Weishaupt based on pore network flows, but using these granular packings instead:
https://git.iws.uni-stuttgart.de/dumux-pub/weishaupt2020a
https://git.iws.uni-stuttgart.de/dumux-pub/Koch2021a
Both of which I have run and tested.
And finally to examine root growth and functional characteristics in these granular packings, which I have been looking at.
The difference here is compacted granular packings and not soil.
... something to that effect.
Initially finding possible software workflows within a laptop/desktop framework.
Following most of those software frameworks - python wherever possible, with connections to c++ backend when needed.
Does that make sense?


chore(actions): remove warnings related to gcp and docker steps

Motivation
Having warnings that are not helpful in our workflows summaries, makes warning that we should care about less relevant or harder to find.

Solution

Remove deprecated arguments
Deactivate Docker summary (not supported by Docker Build Cloud, yet)

Use a variable DOCKER_BUILD_SUMMARY  and set it to false, as this feature might be available in the future

Follow-up Work
I also tried solving this warning:

Unable to extend GITHUB_TOKEN expiration time due to: GITHUB_TOKEN has expired.

But it seems we won't be able to do it, based on this discussion:

https://github.com/orgs/community/discussions/50472

PR Author's Checklist

[X] The PR name will make sense to users.
[X] The PR provides a CHANGELOG summary.
[X] The solution is tested.
[X] The documentation is up to date.
[X] The PR has a priority label.

@Mergifyio refresh


[ maybe a bug ] Occasional exceptions occurred when reasoning with the mlx model yi-1.5-9b-chat

I am certain that the occasional issues occurred during the Inference of the mlx model, and without restarting the model, it was able to self-heal.
FYI, stack info:
2024-07-16 11:51:17,019 xinference.api.restful_api 58629 ERROR    Chat completion stream got an error: [address=<IP_ADDRESS>:54223, pid=58650] Parallel generation is not supported by ggml.
Traceback (most recent call last):
File "/Users/miniconda3/envs/xinf_cp310/lib/python3.10/site-packages/xinference/api/restful_api.py", line 1574, in stream_results
iterator = await model.chat(
File "/Users/miniconda3/envs/xinf_cp310/lib/python3.10/site-packages/xoscar/backends/context.py", line 227, in send
return self._process_result_message(result)
File "/Users/miniconda3/envs/xinf_cp310/lib/python3.10/site-packages/xoscar/backends/context.py", line 102, in _process_result_message
raise message.as_instanceof_cause()
File "/Users/miniconda3/envs/xinf_cp310/lib/python3.10/site-packages/xoscar/backends/pool.py", line 659, in send
result = await self._run_coro(message.message_id, coro)
File "/Users/miniconda3/envs/xinf_cp310/lib/python3.10/site-packages/xoscar/backends/pool.py", line 370, in _run_coro
return await coro
File "/Users/miniconda3/envs/xinf_cp310/lib/python3.10/site-packages/xoscar/api.py", line 384, in on_receive
return await super().on_receive(message)  # type: ignore
File "xoscar/core.pyx", line 558, in on_receive
raise ex
File "xoscar/core.pyx", line 520, in xoscar.core._BaseActor.on_receive
async with self._lock:
File "xoscar/core.pyx", line 521, in xoscar.core._BaseActor.on_receive
with debug_async_timeout('actor_lock_timeout',
File "xoscar/core.pyx", line 526, in xoscar.core._BaseActor.on_receive
result = await result
File "/Users/miniconda3/envs/xinf_cp310/lib/python3.10/site-packages/xinference/core/utils.py", line 45, in wrapped
ret = await func(*args, **kwargs)
File "/Users/miniconda3/envs/xinf_cp310/lib/python3.10/site-packages/xinference/core/model.py", line 90, in wrapped_func
ret = await fn(self, *args, **kwargs)
File "/Users/miniconda3/envs/xinf_cp310/lib/python3.10/site-packages/xoscar/api.py", line 462, in _wrapper
r = await func(self, *args, **kwargs)
File "/Users/miniconda3/envs/xinf_cp310/lib/python3.10/site-packages/xinference/core/model.py", line 505, in chat
response = await self._call_wrapper(
File "/Users/miniconda3/envs/xinf_cp310/lib/python3.10/site-packages/xinference/core/model.py", line 114, in _async_wrapper
return await fn(*args, **kwargs)
File "/Users/miniconda3/envs/xinf_cp310/lib/python3.10/site-packages/xinference/core/model.py", line 397, in _call_wrapper
raise Exception("Parallel generation is not supported by ggml.")
Exception: [address=<IP_ADDRESS>:54223, pid=58650] Parallel generation is not supported by ggml.

Please fill the complete information for the issue.
Why did you delete the place where you were required to fill in the information?
How do you start xinference? How do you launch the model and how do you do the inference?
We will not process this issue unless you open another one and fill in the full information.


Data loss:  Don't clear comment field if failed to post

Bug
I get Unable to create comment, please try again later. quite frequently.
The comment that I just entered, which could be paragraphs long or full with markdown formatting, should not be cleared in this event to avoid having to re-type everything again.
To Reproduce
I don't know how to reproduce the failure -- it just occurs quite frequently for me.  Looking at the log file, I see the same thing for both the success and failure case, so nothing useful to report from here.
Expected behavior
The data that I just filled in should remain in the field when failure occurs, so that I can try to post again after a few seconds with the same data.
System Configuration

App: 0.45.2
Daemon (lbrynet): 0.73.1
Platform: Linux (Linux-5.3.0-51-generic-x86_64-with-LinuxMint-19.3-tricia)

This only impacts the "Simple Editor".  The latest master includes the Advanced Editor, which seems to retain the data well.

Close as duplicate


Break up generated client files into multiple smaller files

I have prisma-client-js/index.d.ts that is about 5Megs and associated index.js that is 8Megs. Some IDEs encounter performance problems when dealing with files of that size.  For example, IntelliJ IDEA takes 6 seconds to open the index.d.ts file and uses up quite a bit of memory. Admittedly, an IDE's inability to handle a large file is the IDE's bug, not yours.  However, it would still enhance the developer experience if these files were broken up into multiple files. I was thinking a file per-model might make sense.

Hi,
Thanks for reporting this! It has already been reported before, so I am going to close this as a duplicate of https://github.com/prisma/prisma/issues/4807


Port some functions from make

This PR adds some useful functions found in make.
To be added

[ ] addprefix()
[ ] addsuffix()
[ ] basename()
[ ] call() - user-defined functions, when introduced, will benefit from this
[ ] shell() - let one write something similar to this:var := `ls -hl {{ join('/usr/','bin','python3') }} {{ addsuffix('.rs', 'lib main runner') }}`

asvar := shell("ls -hl $1 $2", join('/usr/', 'bin/', 'python3'), addsuffix('.rs', 'lib main runner'))

[ ] wildcard()

Why would this require user-defined functions? Even without that, seems like call() would be a helpful tool.

My bad. I phrased it wrongly; I guess the proper phrasing would be: "call() is much useful with user-defined functions". I'll rephrase the description.

Already achievable as
foo := `echo *.c`

The point of these functions is to be mixed and matched. So, while echo *.c and its variations covers those cases for wildcard(), more complex mixing between wildcard() and the others might not be so easily covered. For example, from make documentation
$(wildcard $(addsuffix suf,$(subst :, ,$(PATH)))) -> wildcard(addsuffix("suf", replace_all(":", {{ PATH }})))

addprefix := replace_regex('foo bar', '(^|\s+)(\S+)', '${1}src/${2}')
addsuffix := replace_regex('foo bar', '(^|\s+)(\S+)', '${1}${2}.c')
basename := replace_regex('src/foo.c src-1.0/bar hacks', '(\S+)\.[^/ ]*(\s+|$)', '${1}${2}')

It's certainly much readable to simply use addprefix(), addsuffix(), basename(), right?
Thanks for the feedback.

With shell() implemented, it could be done something like
shell('echo $@', addsuffix("/suf*", replace(env_var('PATH'), ":", ' ')))

I guess.
What do you think about using backslash for escaping? (Does just support raw strings?)

escaping what?
Shell escaping. I'm using $\d+ for argument substitution, and I'll naturally need to deal with escaping of $.

Also, is $\d+ preferred over ${\d+} ? (I prefer the former).

set shell := ['python3', '-c']

# argument 0 is the `-c` flag from above
foo := shell('''
  import sys
  print(sys.argv[1:])
''', 'argument 1', 'argument 2')

This...

python3 -c 'import sys
print(sys.argv[1:])
' 'argument 1' 'argument 2'

... and this expose something I haven't thought of. I'll probably go this route since it's similar to how ` ` works. That means shell() is a convenient frontend to ` `, no?

I think it would be best to leave that to the shell and just pass in the arguments as command-line arguments. In just the shell could be set to anything, even something that isn't nominally a "shell" e.g. a Python interpreter.

Yeah. I'll make the necessary changes and push that.

set shell := ['python3', '-c']

# argument 0 is the `-c` flag from above
foo := shell('''
  import sys
  print(sys.argv[1:])
''', 'argument 1', 'argument 2')

This...

python3 -c 'import sys
print(sys.argv[1:])
' 'argument 1' 'argument 2'

... and this expose something I haven't thought of. I'll probably go this route since it's similar to how ` ` works. That means shell() is a convenient frontend to ` `, no?

I think it would be best to leave that to the shell and just pass in the arguments as command-line arguments. In just the shell could be set to anything, even something that isn't nominally a "shell" e.g. a Python interpreter.

Yeah. I'll make the necessary changes and push that.

Alright.
I think we're in sync.
PS: I think string interpolation can be done via a function fe fmt() that uses Rust/Python's formatting scheme. Maybe I should open a discussion for this (or just chime in to #11)?

I like these, but this PR is pretty big with all of them together. Would you mind splitting them out into individual PRs?

I like these, but this PR is pretty big with all of them together. Would you mind splitting them out into individual PRs?

Alright. I'll break them apart. Stay tuned!

Alright. I'll break them apart. Stay tuned!

Thank you!


🐛 Duplicate Test IDs for DRep Links and Identity Reference Field Errors

Area
Proposal Pillar
Domain
preview.gov.tools
Which wallet were you using?
No response
Context
Test IDs for all fields should be unique to ensure accurate testing and identification. Currently, the test IDs for the error messages related to description, URL of links, and identity fields are duplicated (e.g., invalid-url-error and max-80-characters-error). This issue also includes the overlap where the description error message shares a test ID with one of the name error messages i.e max-80-characters-error. Therefore, distinct test IDs are required for each error message to avoid confusion and ensure proper testing.
Steps to reproduce

Connect to the wallet.
Navigate to the /register_dRep page.
Observe the test IDs for the error messages related to description andURL, of identity and links reference

Actual behavior
Test IDs for the error messages of description, and URL, of identity and links reference are duplicated, which may lead to confusion during testing.

Expected behavior
Each error message should have a unique test ID to ensure clear and accurate testing.

@jdyczka Here is the ticket for missing test-ids.

@spannercode Right now test ids for inputs are generated automatically based on the error message. So in theory this can also affect other places where there are different fields, but with the same error message. The same applies to the hint below the input.
Maybe it would make more sense to generate test ids based on the test id of the input field? If done globally that would ensure uniqueness, however, it might also require a bunch of changes on your side.
Let me know if you would prefer me to go with the global approach, or just handle the case of link and identity references.


Add a Makefile for ease of development

Closing this for now. #251 addresses the current need. We can reopen it when we want to make it fancier.


spelling fix in logging output of virt-handler/device…

What this PR does / why we need it:
Fixed small spelling error found in virt-handler device_controller logging output. Changed "pluings" to "plugins".
Special notes for your reviewer:
I closed out my last PR for this as I got the history of changes all messed up. This should be nice and clean, and easier to review/merge.  Thanks
Release note:

NONE

/lgtm

/approve
/retest

/retest

/ok-to-test


weights and biases initialization

I could not find where the CNN weights and biases are initialized. Could you direct me there? and  are the weights and biases in the fpndetector.py all initialized to 0 at the start or if there is a different initialization used?

We use PyTorch's default way of initialization for our layers. For Conv layers, I think it is implemented here.

Thanks


Icon borders

Not really an issue I guess, but is it possible to add borders around the icon to make it look more pleasing an inline with other QL icons? I've attached an image to illustrate what I mean. You can see that the .log file has borders to its text while the other two do not. This is because log files have native support, while the others do not.

Thanks for the suggestion. Would be a nice addition.


Utopia-949 Make sub header responsive

Description
This PR includes the following proposed change(s):

{List all the changes, if possible add the jira ticket #}

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Refactoring / Documentation
[ ] Version change

How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Development Dependency Working Agreement

[x] My code DOES NOT include the importing of new dependencies into the DPIA ecosystem
[ ] My code DOES include the importing of new dependencies into the DPIA ecosystem
If new dependencies are being introduced to the DPIA ecosystem:
[ ] The functionality of the dependency drastically reduces code complexity and makes my changes more easily maintainable and readible
[ ] The dependency being introduced does not contain multiple layers of nested dependencies introducing maintainability complexity to the DPIA ecosystem

Frontend Development Changes

[ ] N/A
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to project documentation or diagrams that reflect my changes
[ ] New and existing unit tests pass locally with my changes
[ ] My code follows Airbnb React Style Guidelines

API Development Changes

[x] N/A
[ ] I have performed a self-review of my own code
[ ] My code follows standards and practices outlined in the BC Government API Development Guidelines
[ ] New and existing unit tests pass locally with my changes
[ ] My changes includes Swagger documentation updates that reflect the changes I am introducing

Definition of Done

Can we change double borders for MPO?

the design shows submit PIA intake
you change to submit, does you communicate with Jordan for the change?

That is correct!


Wrong sort order if image

Unclear whats causing this could be an isolated issue:
Test archive:
https://github.com/workhorsy/uncompress.js/blob/master/example_rar_5.rar

Looks like sorting was disabled  for some reason :confounded:

I'll close this now,
Please leave a comment if the  issue is not resolved by the solution mentioned above.


Packager copys empty module

Please describe your issue:
When I am package my application with electron packager, the packager copys empty module to the packaged application.
This is how it looks inside the node_module in the packaged application (watchjs)
http://imgur.com/a/Rqwoe
This is how it looks like in my source node_modules and how it should look like:
http://imgur.com/a/5QqPS
I already tried to remove the node_modules and reinstall it. Both with npm itself and yarn.
http://imgur.com/a/Pdwu6
Obvious when watchjs empty is.

Console output when you run electron-packager with the environment variable DEBUG=electron-packager. Please include the stack trace if one exists.
No errors
What command line arguments are you passing? Alternatively, if you are using the API, what
parameters are you passing to the packager() function?
{
        dir: ".",
        all: true,
        "app-version": require('./package.json').version,
        asar: false, // It also happens when asar is true
        icon: "./Icon",
        ignore: [
            'src/', // node_modules is outside of the src directory, and I am minifying all files to build/ with gulp
            'bower.json',
            '.bowerrc',
            'yarn.lock',
            'builds/'
        ],
        arch: 'all',
        platform: 'all',
        platforms: 'all',
        "app-bundle-id": 'io.noim.dsbclient',
        out: './builds',
        prune: true, // I tried this, because I tought maybe this could fix it, but it doesen't.
        electronVersion: '1.4.13', // First I thought it was a electron problem
        derefSymlinks: true
    }

Please provide either a failing minimal testcase (with a link to the code) or detailed steps to
reproduce your problem. Using electron-quick-start
is a good starting point.
My dependencies:
"dependencies": {
    "auto-launch": "^5.0.1",
    "debug-menu": "^0.4.0",
    "dsbiserv": "^1.3.0", // requires watchjs
    "electron": "^1.4.15",
    "electron-ipc-socket": "^1.2.4",
    "electron-is-dev": "^0.1.2",
    "electron-json-storage": "^3.0.1",
    "electron-packager": "^8.5.1",
    "electron-rebuild": "^1.5.7",
    "validator": "^6.2.1",
    "watchjs": "^0.0.0" // I added it because i hoped this would fix it.
  },
  "devDependencies": {
    "babel-preset-es2015": "^6.22.0",
    "del": "^2.2.2",
    "gulp": "^3.9.1",
    "gulp-babel": "^6.1.2",
    "gulp-clean": "^0.3.2",
    "gulp-htmlmin": "^3.0.0",
    "gulp-inline": "^0.1.3",
    "gulp-minify-css": "^1.2.4",
    "gulp-sequence": "^0.4.6",
    "gulp-uglify": "^2.0.1"
  }

My project structure:
http://imgur.com/a/yQPma

@TheNoim Your problem is you are ignoring the src/ pattern.  This is matching that src folder in your node_modules directory.
You need a more explicity regexp / pattern that only matches at the start of the tested path.

@MarshallOfSound damit, you are right. What could i use to prevent this ?

Well I use this magic
https://github.com/MarshallOfSound/Google-Play-Music-Desktop-Player-UNOFFICIAL-/blob/master/gulpfile.babel.js#L56
But that's just me 😆 Basically you just need a stricter ignore pattern 👍


ShareGPT:chat format doesn't seem to work

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
ShareGPTPromptTokenizationStrategy is not being called at all when preparing datasets
Current behaviour
ShareGPTPromptTokenizationStrategy should be invoked when preparing datasets.
Steps to reproduce

prepare a sharegpt:chat dataset format
prepare dataset by using --prepare_ds_only
Debugging through the code, the ShareGPTPromptTokenizationStrategy is not being called at all

I did some modifications to the strategy just to test, and the modifications are not applied.
Possible solution

Here it seems "features" contains the "conversations" key. Which will drop the column "conversations". The ShareGPT dataset contains only "conversations" key, so everything is dropped.
I tested by changing this part to an empty array [], and the ShareGPT tokenizing strategy will be invoked again.
Which Operating Systems are you using?

[ ] Linux
[ ] macOS
[X] Windows

Python Version
0.2.1
axolotl branch-commit
d5dcf9c
Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of axolotl.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

Could you provide sample of your dataset?

Dataset looks like this:
[
    {
        "conversations": [
            {
                "from": "human",
                "value": "I'd like to have a office equipment upgrade on new year's eve, can you schedule that?"
            },
            {
                "from": "gpt",
                "value": "#[layla_schedule(\"office equipment upgrade\",\"on new year's eve\")]"
            }
        ]
    },
    {
        "conversations": [
            {
                "from": "human",
                "value": "Insert a software update into my schedule in a month"
            },
            {
                "from": "gpt",
                "value": "#[layla_schedule(\"software update\",\"in a month\")]"
            }
        ]
    },
    {
        "conversations": [
            {
                "from": "human",
                "value": "Let's put a crisis management meeting on december 25th, 2023, at 12:00 pm in my schedule"
            },
            {
                "from": "gpt",
                "value": "#[layla_schedule(\"crisis management meeting\",\"on december 25th, 2023, at 12:00 pm\")]"
            }
        ]
    },
    {
        "conversations": [
            {
                "from": "human",
                "value": "I'd like to be reminded to walk the dog in two weeks at 10:00 am"
            },
            {
                "from": "gpt",
                "value": "#[layla_schedule(\"walk the dog\",\"in two weeks at 10:00 am\")]"
            }
        ]
    },
    {
        "conversations": [
            {
                "from": "human",
                "value": "Help me schedule a dance class on october 31st, 2023, at 8:00 pm"
            },
            {
                "from": "gpt",
                "value": "#[layla_schedule(\"dance class\",\"on october 31st, 2023, at 8:00 pm\")]"
            }
        ]
    }
]

+800,000 rows

Here it seems "features" contains the "conversations" key. Which will drop the column "conversations". The ShareGPT dataset contains only "conversations" key, so everything is dropped.

The dataset is tokenized, then we remove the original data from tokenized set.
Regarding dataset, I have not used json based data for a while. Could you try as jsonl? It's just one row per conversations set.
{"conversations": [{"from": "...", "value": "..."}]}

The dataset is tokenized, then we remove the original data from tokenized set.

Is this an issue? My data is not tokenized, but it appears that axolotl thinks it's tokenized and removes the "conversation" key.
I'll try jsonl in a bit, thanks

Is this an issue? My data is not tokenized, but it appears that axolotl thinks it's tokenized and removes the "conversation" key.

Oh no. It was just an explanation for what's happening in that code block.

Hello, was this solved?

As a workaround, I hardcoded features = []. That got my data tokenised.
But the root issue still persists.

Hello, what file did you put the "features = []" into? Because we're having exactly the same issue on the latest code.

Hello, what file did you put the "features = []" into? Because we're having exactly the same issue on the latest code.

It's been quite a while, but as I recall simply removing "features" did solve the root cause (even though it got tokenized, the training failed).
I'm using JSONL, which doesn't seem to have this problem.


[ARO-11589] Dump keyvault certificate error

Which issue this PR addresses:

Part of ARO-11589
What this PR does / why we need it:

This PR makes the error from keyvault more structurized and easy to debug.
This will be useful to investigate the error from keyvault, and think about the error handling.
Sometimes even though the certificate operation is in progress, polling the certificate operation fails.
It fails when it gets error from internal certificate issuer service, in that case the keyvault API returns the certificate operation object, but its status is failed.
This may be a retryable error (e.g. 429 error), and we should handle this properly, but with the current log, we're not sure which fields should be used to identify if it is retryable or not.
This is the error:
step [Action pkg/cluster.(*manager).createCertificates] encountered error: certificateOperation failed: Request rejected: A request to create a certificate with OneCertV2-PublicCA failed unexpectedly.
OrderId: ?, HttpStatus: 429, Correlation ID: <redacted>. ErrorDetails: An attempt to create a certificate with OneCert failed with error Code 'TooManyRequests' and Message '[Status:FailedCanRetry] Rate limit for service 'KeyVault' and operation 'enroll' reached. The limit is '80' requests per minute per machine. Retry after 00:00:20'. For help with any issues, visit aka.ms/gethelponecert.
OneCertV2-PublicCA service is having load issues and actively throttling requests. Please retry later.: Pending certificate created. Certificate request is in progress. This may take some time based on the issuer provider. Please check again later.

Test plan for issue:

unit test
Is there any documentation that needs to be updated for this PR?

N/A
How do you know this will function as expected in production?

waiting for the cert error happens

/azp run ci


node exporter: only export metrics of interest

reduce the memory footage of Prometheus service

https://github.com/Microsoft/pai/pull/485


[Story] Monitor metrics and logs of the OC MariaDB instance

What projects is this story for?
OpenChallenges
As a user, I want
As a developer, I want to know CPU and memory usage of the MariaDB instance, so that I can detect whether compute resources limit the performance of the DB instance.
As a developer, I want to quickly access the logs of the MariaDB instance easily, so that I can troubleshoot issues faster.
As a developer, I want to know CPU and memory usage of the MariaDB instance, so that I can estimate how much resources I should pay for when deploying to a cloud provider.
Description
We are using the metric and log aggregator Prometheus and Grafana for visualization. The goal of this ticket is to explore and implement a solution that rely at least on Grafana to visualize the metric and log data generated by the OC MariaDB instance.
Acceptance criteria
No response
Tasks
No response
Anything else?
No response
Have you linked this story to a GitHub Project?

[X] I have linked this story to a GitHub Project and set its metadata.

I found this dashboard for Grafana: MySQL Exporter Quickstart and Dashboard

Deploying mysql-exporter
Instructions on how to deploy the exporter with Docker are available here.
Tips on how to configure Prometheus to scrape data from the exporter are available here.
Notes:

I deployed mysql-exporter and was able to access its metrics at the address http://localhost:9104/metrics.
Prometheus says that mysql-exporter is "up"
Grafana detect the job openchallenges-mysql-exporter but says that there are no data.

Data available on http://localhost:9104/metrics:
# HELP go_gc_cycles_automatic_gc_cycles_total Count of completed GC cycles generated by the Go runtime.
# TYPE go_gc_cycles_automatic_gc_cycles_total counter
go_gc_cycles_automatic_gc_cycles_total 8
# HELP go_gc_cycles_forced_gc_cycles_total Count of completed GC cycles forced by the application.
# TYPE go_gc_cycles_forced_gc_cycles_total counter
go_gc_cycles_forced_gc_cycles_total 0
# HELP go_gc_cycles_total_gc_cycles_total Count of all completed GC cycles.
# TYPE go_gc_cycles_total_gc_cycles_total counter
go_gc_cycles_total_gc_cycles_total 8
# HELP go_gc_duration_seconds A summary of the pause duration of garbage collection cycles.
# TYPE go_gc_duration_seconds summary
go_gc_duration_seconds{quantile="0"} 5.0141e-05
go_gc_duration_seconds{quantile="0.25"} 6.1323e-05
go_gc_duration_seconds{quantile="0.5"} 0.000101907
go_gc_duration_seconds{quantile="0.75"} 0.000196106
go_gc_duration_seconds{quantile="1"} 0.000217926
go_gc_duration_seconds_sum 0.000918992
go_gc_duration_seconds_count 8
...

Percona’s dashboards
Error in Grafana when importing one of the Percona’s dashboards.
Failed to upgrade legacy queries Datasource Metrics was not found

There is also this official Prometheus MySQL dashboard we could use. Is is relying on the variable mysql_global_status_uptime. Should this variable be exported by mysql-exporter? This is currently not the case.

The error returned by mysql-exporter:
ts=2023-04-01T02:00:44.371Z caller=exporter.go:136 level=error msg="Error opening connection to database" err="default addr for network 'openchallenges-mariadb:3306' unknown"

New error:
ts=2023-04-01T02:06:49.606Z caller=exporter.go:174 level=error msg="Error from scraper" scraper=slave_status err="Error 1227: Access denied; you need (at least one of) the SUPER, SLAVE MONITOR privilege(s) for this operation"


Feature request: DepCheck: Detect and 'fix' missing peer dependencies

I'm trying to fix hidden cyclic dependencies hidden by yarn v1 in one of our internal repo's by using midgard-yarn-strict.
Here I'm running into many peer dependencies not being properly declared in the react-native pacakges (both core, from microsoft and from community). With babel being a common missing ones.
I can point you to some files where other internal repo's already on midgard-yarn-strict that have extra dependency declarations.

@tido64 as FYI:

Hi @dannyvv, can you explain what you mean by "fix"? An example or two would help a lot.


Persist null instead of empty arrays

The name table has string arrays for authors. If authors are missing, these are either null or an empty array. Allow only one version (suggest to use NULL instead of empty arrays) so queries are consistent.

done: https://github.com/Sp2000/colplus-backend/commit/a05b29c792a3ca905ac727cf3c2d9d75f785fe3a

using empty array not instead of nulls


Haiku: Add in missing build-time types, fix module usage

Working through the few final remaining build issues for the Haiku target.

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see the contribution instructions for more information.

@bors: r+

:pushpin: Commit e8155ba has been approved by alexcrichton

:hourglass: Testing commit e8155ba with merge 68abfad...

:sunny: Test successful - status-appveyor, travis
Approved by: alexcrichton
Pushing 68abfade9faf63e57d5cc924141475edbe8e7899 to master...


Provide inline implement for standard algorithm

Ref #5017

Codecov Report

Merging #5195 into master will decrease coverage by 0.05%.
The diff coverage is 12.50%.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9db163...5bb6739. Read the comment docs.


Add support for easier renaming of connection string

In our project, I wanted to easily be able to switch between identity provider databases.
It was currently possible by generating a DbConnection, but that forces us to bind to one particular DB provider.
By allowing the Db Name or ConnectionString to be passed in, we allow a much simpler, and more resilient method by which to specify the connection string

I was originally going to do these 2 commits as separate pull requests, but it seems github decided to include both in this package.
Let me know if you have any issues with either of the 2, simple changes.

@leastprivilege any thoughts? seems reasonable to me.

no idea. why not.

ok, added. thanks.

Any chance we can get the nuget package updated too?
For now I'm going the long (Provider-bound) way in our project, as I don't want to tear out the existing nuget references.


Mark testReadFullAcidPartitionedBucketed as Flaky

Mark testReadFullAcidPartitionedBucketed as Flaky

Do we ever get back to these tests to actually identify root cause?

@sopel39, @wendigo is looking into this.

merge?

@sopel39, @wendigo is looking into this.

@findepi, @wendigo  what is the status?


enable carousel on homepage

🧐 Have you read the FAQ and viewed similar issues?

[X] I have read the FAQ
[X] I have checked older issues, open and closed
[X] I did a clean install of SpotX as described in the FAQ

Сountry of your account
France
What is your Spotify Plan?
Free
Do you have Spicetify installed?
No
ℹ Computer information
- Spotify: latest <IP_ADDRESS>8 x64
- Windows: 11 x64 24H2
- PowerShell: 7.4.1

📝 Description
if i remember correctly the official version has a > symbol to scroll through the various playlists in the same field, which i don't see in SpotX. example: in Made for you i only see Daily Mix 1-3-4-6. to see all the playlists i need to click on Show all. I seem to remember that in previous versions there was a > symbol to scroll through the playlists to the right, displaying them all
edit: confirmed. from official version have arrow to show from right side all playlist available (not on Made for you but from others playlist)
📸 Screenshots

The exp that enabled the carousel on the homepage was disabled due to slowdowns on the homepage. I just checked it in the new versions, and nothing has changed.
If you need this exp, you can enable it yourself using this, name of the exp: enableHomeCarousels

wonderful. thanks