Headless Chrome integration with TagUI

ISSUE - PhantomJS maintainer is stepping down. Unless a white knight appears to take over development and maintenance, PhantomJS project will over time become obsolete and not an ideal web automation endpoint due to differences in behavior compared to modern web browsers.
FIX -
Main maintainer of CasperJS (the tool that TagUI is base on) would like to try to maintain CasperJS with headless Chrome (https://github.com/casperjs/casperjs/issues/1825). That should be able to transition TagUI directly to headless Chrome, besides the current Firefox endpoint through SlimerJS.
In the meantime, I think it is worthwhile to dedicate a couple of weeks to try to integrate headless Chrome directly with TagUI. For JavaScript projects, this is typically done through chrome-remote-interface. An example is the Chromy project as pointed out by CasperJS user @tobiastom.
Headless Chrome integration is chosen for now instead of Selenium WebdriverIO integration because it is a more direct path (TagUI -> chrome-remote-interface -> headless Chrome, versus TagUI -> WebdriverIO -> Selenium -> headless Chrome and other browsers). Assumption is the shorter path leads to lesser chance of something breaking and result in a better integration for TagUI.

TagUI v1.8 should be able to be released in a couple of days and work on headless Chrome integration can start. v1.8 is the visual automation release where there is ability to handle interaction by visually looking for webpage objects or desktop objects (through Sikuli integration).
Other new features include improved outgoing API for advance API calls through different methods/headers/body, auto-upload option of run result and automation flow to hastebin.com, and improved step/code block handling using {} which allows powerful and convenient automation when combined with if/for/while/popup/frame.
UPDATED - Chrome extension element identification is also improved and [enter] keyword can be used to type enter keys. More details at readme and release notes.

Writing some POC (proof-of-concept) tests works great! In fact, from the POC, my sensing is there should be no big technical roadblock to integrate TagUI directly with Chrome / headless Chrome through the chrome debugging protocol. Without going through external dependencies such as the chrome remote interface node.js project and Chromy which is built on top of chrome remote interface.
There is no doubt chrome remote interface and Chromy makes it much easier to do the integration as a lot of work needed to be done to communicate with Chrome is already there. However, it introduces Node.js dependency into TagUI. And they have much more code built-in than what is needed for TagUI steps.
Thus I favor coding the integration directly into TagUI such as below example, without adding additional dependency through Node.js projects such as Chrome Remote Interface or Chromy. If done successfully, this should give the best performance for TagUI execution and let TagUI remain usable by users without Node.js environment, while having access to Chrome + headless Chrome. This approach should take more development effort but should be the preferred way to try unless some other technical roadblock appears.
below starts Chrome on macOS with debugging port on. for headless mode use additional switches --headless --disable-gpu (this disable gpu switch is temporary according to Chrome documentation)
open -a Google\ Chrome --args --remote-debugging-port=9222

test code embedded in TagUI automation flow to click on web element
var ws = new WebSocket("ws://localhost:9222/devtools/page/5965f284-1c86-47bb-b8c2-9576f97dec90");

ws.onopen = function() {
var message = {'id': 1, 'method': 'Runtime.evaluate', 'params': {expression: 'document.querySelector(\"#giticon\").click()'}};
ws.send(JSON.stringify(message));
casper.echo("Message is sent...");};

ws.onmessage = function (evt) {
var received_msg = evt.data; casper.echo("Message is received... " + received_msg);};

ws.onclose = function() {
casper.echo("Connection is closed...");};

The websocket connection will return error accordingly if the specified locator cannot be found. Running above in visible mode I am able to see the web element with id giticon being clicked. There will be more work to code it and maintain the integration code, but this really should be the path to try first.

Adding commit https://github.com/tebelorg/TagUI/commit/0bf4d12bbbe3a625ef2e78b6c81245427aa38c04 with below comment -

adding project - https://github.com/Textalk/websocket-php
to manage chrome web socket in a separate thread so that there can be concurrency versus single-threaded js and lack of await or promises in current casperjs/phantomjs framework.
using php also does not add new dependencies as current packaged releases already come with php for windows. and linux/macos already has php installed.

Now trying another approach to manage websocket communications concurrently from a separate php thread instead of the same single javascript thread as casperjs (lots of challenges which cannot be easily fixed even if willing to make large code changes to TagUI).
The idea is similar to how the TagUI Sikuli integration works. The separate thread should give the best performance and flexibility in the automation implementation.

Above new commit with working framework (run with chrome or headless option)

[x] working direct websocket integration with chrome (or headless chrome)
[x] concurrent communications using separate php thread
[x] supporting dynamic css and xpath selectors per usual
[x] done following CasperJS API - exists, getTitle, getCurrentURL, click (simplified)
[x] handling initial opening of url and subsequent new urls in automation flow

Other CasperJS API needed for TagUI steps / functionality

[ ] sendKeys - used by type / enter step
[ ] mouse.xxx - used by hover / mouse step
[ ] fetchText - used by read / fetch / show / print steps
[ ] capture - used by snap step
[ ] captureSelector - used by snap step
[ ] download - used by download / receive steps
[ ] evaluate - used by dom step and live mode
[ ] getHTML - used by save step

Other stuffs can think of before releasing v2.0

[ ] selectOptionByValue custom option selection function
[ ] live mode of TagUI steps and supported CasperJS API
[ ] autoload of chrome or headless chrome from option
[ ] autoload of php helper process to manage websocket
[ ] explore frame and popup step for websocket chrome
[ ] port-over main runner tagui to windows tagui.cmd
[ ] test chrome and headless chrome for all 3 OSes
[ ] consider adding transpose for datatables
[ ] update flowchart and readme

Various components for TagUI direct integration to Chrome + headless Chrome are done. Closing issue and releasing v2.0 packages probably in couple of days after implementing datatables auto-transpose.

@kensoh, I am using TagUI 2.3 and Chrome Version 60.  When I run an automation flow file (.txt) from the command line (Windows 10), TagUI generates a JS flowfile (.txt.js).  This file contains a lot of code blocks before it gets to the casper.start() command and the casperJS script that is specific to the automation flow.  From what I can understand in the readme, all methods of running TagUI (command line, schedule, URL) use a TagUI command.  My question pertains to repeated use of an automation flow and whether or not the casperJS script generated by TagUI (.txt.js) can be called/run independently as a CasperJS command or if the TagUI command must be used each time?
The situation is that I want to make small changes to the casperJS script generated by TagUI for the repetitive automation tests, and running the TagUI automation flow from the start appears to over-right these changes.

Hi @TMM21042 thanks for asking this question. In most cases, CasperJS code can be written directly in the TagUI flow file, as it is directly being ported over to the output CasperJS .js file. Most of the generated code the header part are supporting functions for TagUI (eg smart XPath/CSS locator), api etc, and the Chrome implementation which is executed only when chrome or headless option is used.
You can check out tagui_header.js to see if what you want to change is there, so that you can make a change there for your changes to be used each time it is run, as a generated file is created on the fly each time a flow is run, base on the options chosen. Otherwise, editing a generated CasperJS script works as well, but you'll have to run it with the appropriate switches for CasperJS.
I don't think all cases can be done that way. For example you may run with TagUI chrome or test option. The generated script is already in a format that have the appropriate CasperJS code structure to do that. It can't be easily changed to do something else such as run in firefox or non-test mode. Separate files can be generated though for editing, using different options.

Adding notes for this thread, in a sense, you can say TagUI is a CasperJS script generator, adding on with various functions / integrations to do things which is not in the CasperJS feature-set. Theoretically, it is possible to make changes to TagUI so that it can directly run a normal CasperJS script, but output to headless Chrome. But I think some users who explicitly wants to use headless Chrome have started exploring the Chrome-based tools directly. Also, TagUI only made Chrome implementation on a subset of CasperJS API for areas used by TagUI steps. To make all the CasperJS API available for Chrome is a nightmare. CasperJS/PhantomJs are really mature and expressive libraries for their job.
The past few months I'm actively supporting CasperJS issues and mailing list, but TagUI features are not something that can be implemented as pull requests into CasperJS. Technical incompatibility (basically the way PhantomJS works is not compatible with the way newer Chrome-based tools work) and features being too specific for very specific use cases which really shouldn't be part of CasperJS in the first place (for eg visual automation, uploading run results online etc). TagUI is more like a framework for the sole purpose of automating web processes easily. It tries to make the creation, deployment and maintenance easy. But in doing so, many specific design choices have to be made, which means they shouldn't be implemented to CasperJS to retain its neutral / flexible API.


Upgrade to 4.15 error

After last upgrade to version 4.15 i got this error
"Unable to find template "partial_pending_messages.phtml" (looked into: /var/www/vhosts/XXXXXXX/public_html/prodaja/bb-themes/boxbilling/html, /var/www/vhosts/XXXXXXXX/public_html/prodaja/bb-modules/Pending/html_client) in "layout_default.phtml" at line 228."
Can somebody help me with this?

issue is fixed in the latest BoxBilling release >4.15.1


[Go Live][Aug 09] (#6631)

Articles are updated with relevant links

Added the description with relevant doc links for app cycle.

Articles is updated

Edited and added relevant doc link in "See also" section. updated the metadata for better SEO results

Article is updated

Added relevant doc link

Articles is updated

Edited and updated the article as per review comments.

[Doc-Bug][ngrok fix] (#6627)

ngrok fix

updated ngrok images

Update include-saas-offer.md

[Doc Feature][Edit Teams app manifest for VS][2510690] (#6376)

Create VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

.

Update

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Updated

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Updated text and image

Update

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update

Updated

updated

Update VS-TeamsFx-preview-and-customize-app-manifest.md

.

updated

Update VS-TeamsFx-preview-and-customize-app-manifest.md

.

.

.

updated images

images updated

Update vs-hover-undefined.png

images updated

updated images

updated

.

.

image update

Updated

.

.

.

.

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Create vs-open-manifest1.png

updated images and text

.

.

images updated

updated

Update VS-TeamsFx-preview-and-customize-app-manifest.md

images edited

Update VS-TeamsFx-preview-and-customize-app-manifest.md

.

images updated

image updated

image updated

Update vs-update-manifest1.png

Zip app package image updated

Update VS-TeamsFx-preview-and-customize-app-manifest.md

image updated

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Update VS-TeamsFx-preview-and-customize-app-manifest.md

Co-authored-by: v-amprasad<EMAIL_ADDRESS>Co-authored-by: v-abirade<EMAIL_ADDRESS>Co-authored-by: v-amprasad<EMAIL_ADDRESS>

[Doc Feature][Provision cloud resources for TTK Visual Studio][2528157] (#6427)

Create provision VS.md

updated

updated

Update

Update provision VS.md

Update provision VS.md

Update provision VS.md

Update provision VS.md

update

updated

update

Update provision VS.md

.

Update provision VS.md

Update provision VS.md

Update provision VS.md

Update provision VS.md

Update provision VS.md

Update provision VS.md

updated images and text

text edit

Update provision VS.md

updated images

Update provision VS.md

Update provision VS.md

Image updated

Update provision VS.md

Update provision VS.md

Update provision VS.md

Update provision VS.md

Update provision VS.md

Update provision VS.md

Update provision VS.md

Update provision VS.md

Update provision VS.md

Images updated

Update provision VS.md

Update provision VS.md

Images and text updated

Update provision VS.md

image updated

Update teams-toolkit-vs-provision-select-subscription.png

Images updated

Update provision VS.md

Update provision VS.md

Update provision VS.md

Update provision VS.md

Update provision VS.md

Update teams-toolkit-vs-provision-select-subscription.png

.

Update Provision cloud resources using Visual Studio.md

Update Provision cloud resources using Visual Studio.md

Co-authored-by: v-amprasad<EMAIL_ADDRESS>Co-authored-by: v-abirade<EMAIL_ADDRESS>Co-authored-by: v-amprasad<EMAIL_ADDRESS>

[Doc Improvement][Update SBS Build your first app using C#] (#6598)

.

.

.

.

Update sbs-gs-csharp.yml

Update sbs-gs-csharp.yml

Update sbs-gs-csharp.yml

Update sbs-gs-csharp.yml

Update sbs-gs-csharp.yml

Update sbs-gs-csharp.yml

Update sbs-gs-csharp.yml

Update sbs-gs-csharp.yml

Update sbs-gs-csharp.yml

Update sbs-gs-csharp.yml

Update sbs-gs-csharp.yml

Update sbs-gs-csharp.yml

Update sbs-gs-csharp.yml

Update sbs-gs-csharp.yml

Update sbs-gs-csharp.yml

Update sbs-gs-csharp.yml

Update sbs-gs-csharp.yml

.

.

Update sbs-gs-csharp.yml

Update sbs-gs-csharp.yml

Update sbs-gs-csharp.yml

Update sbs-gs-csharp.yml

corrected version

.

Co-authored-by: Shalini Robinson<EMAIL_ADDRESS>

[Doc Feature][Deploy Teams app to the cloud VS][2528174] (#6513)

.

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

Images and text edited

Update deploy to the cloud for VS.md

image updated

Update deploy to the cloud for VS.md

Updated image

Update vs-deploy-cloud.png

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

image and text edited

updated text and images

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

images upated

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

Update deploy to the cloud for VS.md

.

Update Deploy Teams app to the cloud using Visual Studio.md

Update Deploy Teams app to the cloud using Visual Studio.md

Co-authored-by: v-amprasad<EMAIL_ADDRESS>Co-authored-by: v-abirade<EMAIL_ADDRESS>Co-authored-by: v-amprasad<EMAIL_ADDRESS>Co-authored-by: Ajith kumar<EMAIL_ADDRESS>Co-authored-by: Ashish Gupta<EMAIL_ADDRESS>Co-authored-by: Shalini Robinson<EMAIL_ADDRESS>Co-authored-by: v-habibaumme<EMAIL_ADDRESS>Co-authored-by: v-tanmayirs<EMAIL_ADDRESS>Co-authored-by: v-amprasad<EMAIL_ADDRESS>Co-authored-by: v-abirade<EMAIL_ADDRESS>Co-authored-by: v-amprasad<EMAIL_ADDRESS>Co-authored-by: v-ksar<EMAIL_ADDRESS>

Acrolinx Scorecards
We currently enforce a minimum score of 80.
Click the scorecard links for each article to review the Acrolinx feedback on grammar, spelling, punctuation, writing style, and terminology:

Article
Score
Issues
Scorecard
Processed

msteams-platform/concepts/deploy-and-publish/appsource/prepare/include-saas-offer.md
98
3
link
:white_check_mark:

msteams-platform/graph-api/proactive-bots-and-messages/graph-proactive-bots-and-messages.md
90
8
link
:white_check_mark:

msteams-platform/sbs-gs-csharp.yml
94
21
link
:white_check_mark:

msteams-platform/toolkit/Deploy Teams app to the cloud using Visual Studio.md
98
2
link
:white_check_mark:

msteams-platform/toolkit/Provision cloud resources using Visual Studio.md
97
30
link
:white_check_mark:

msteams-platform/toolkit/TeamsFx-preview-and-customize-app-manifest.md
91
9
link
:white_check_mark:

msteams-platform/toolkit/VS-TeamsFx-preview-and-customize-app-manifest.md
100
1
link
:white_check_mark:

More info about Acrolinx
Use the Acrolinx extension, or sidebar, in Visual Studio Code to check spelling, grammar, style, tone, clarity, and key terminology when you're creating or updating content. For more information, see Use the Visual Studio Code extension to run Acrolinx locally.

Docs Build status updates of commit 70902d8:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/sbs-gs-csharp.yml
:warning:Warning
View
Details

[msteams-platform/toolkit/Deploy Teams app to the cloud using Visual Studio.md](https://github.com/MicrosoftDocs/msteams-docs/blob/live/msteams-platform/toolkit/Deploy Teams app to the cloud using Visual Studio.md)
:warning:Warning
View
Details

[msteams-platform/toolkit/Provision cloud resources using Visual Studio.md](https://github.com/MicrosoftDocs/msteams-docs/blob/live/msteams-platform/toolkit/Provision cloud resources using Visual Studio.md)
:warning:Warning
View
Details

msteams-platform/toolkit/VS-TeamsFx-preview-and-customize-app-manifest.md
:warning:Warning
View
Details

msteams-platform/assets/images/deploy-teams-app-cloud-vs/vs-deploy-cloud.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/deploy-teams-app-cloud-vs/vs-deploy-confirmation.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/deploy-teams-app-cloud-vs/VS-deploy-popup.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/deploy-teams-app-cloud-vs/vs-deploy-preview-teams.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/deploy-teams-app-cloud-vs/vs-deploy-preview-teams1.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/deploy-teams-app-cloud-vs/vs-deploy-ZipApp-package.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/add-account.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/deploy-vs/VS-deploy-confirmation-dialog.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/deploy-vs/VS-deploy-popup.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/deploy-vs/VS-deploy-to-cloud.PNG
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/enter-project-name.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/enter-teams.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/final-output-vs.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/manage-extension.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/select-add.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/select-create-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/select-extension.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/select-m365-account.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/select-mstools.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/select-project.png
:white_check_mark:Succeeded
View

msteams-platform/assets/images/teams-toolkit-v2/select-tab.png
:white_check_mark:Succeeded
View

This comment lists only the first 25 files in the pull request.

msteams-platform/sbs-gs-csharp.yml

Line 189, Column 47: [Warning: bookmark-not-found] Cannot find bookmark '#build-your-first-app' in 'sbs-gs-csharp.yml'.
Line 203, Column 31: [Warning: bookmark-not-found] Cannot find bookmark '#configure-the-app-package-in-developer-portal' in 'sbs-gs-csharp.yml'.

[msteams-platform/toolkit/Deploy Teams app to the cloud using Visual Studio.md](https://github.com/MicrosoftDocs/msteams-docs/blob/live/msteams-platform/toolkit/Deploy Teams app to the cloud using Visual Studio.md)

Line 83, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'create-new-teams-app-for-Visual-Studio.md'.
Line 84, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'provision-cloud-resources-using-Visual-Studio.md'.
Line 86, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'debug-teams-app-visual-studio.md'.

[msteams-platform/toolkit/Provision cloud resources using Visual Studio.md](https://github.com/MicrosoftDocs/msteams-docs/blob/live/msteams-platform/toolkit/Provision cloud resources using Visual Studio.md)

Line 282, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'deploy-Teams-app-to-the-cloud-using-Visual-Studio.md'.
Line 284, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'debug-teams-app-visual-studio.md'.

msteams-platform/toolkit/VS-TeamsFx-preview-and-customize-app-manifest.md

Line 95, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'provision-cloud-resources-using-Visual-Studio.md'.
Line 96, Column 3: [Warning: file-not-found - See documentation] Invalid file link: 'deploy-Teams-app-to-the-cloud-using-Visual-Studio.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


This page can’t be displayed

hi i can run Bonobo on my pc but when i try to run it on server IIS tell me "This page can’t be displayed".
browser redirect to this page: http://localhost:1234/Home/Error?aspxerrorpath=/Home/Error
and got the "This page can’t be displayed" error.
try everything even change the windows and nothing changed.
i can host another mvc app as same version like Bonobo.

Is there anything in the logs? - you can try disable custom errors     <customErrors mode="On" defaultRedirect="Home/Error" /> - and maybe get a hint about what is going wrong?

As well as @larshg suggestions, start by running the browser on machine which is running IIS.

ooo shit i'am donig ...
change server windows just for custome error turn on.....
.netFramework 4.6 needed for fix
thank you!


[HCFRO-160] Build fix

There are also some cleanup commits and updates.
This version has some experimental build support for mono if we would ever need to build this from source on a linux box from a release.

Build log: https://ci.appveyor.com/project/StefanSchneider/windows-app-lifecycle

:+1:


Comment node missing in Visual Shaders

Tested versions

Reproducible in: 4.2.1.stable - Not reproducible in 4.1.1.stable

System information
Godot v4.2.1.stable - Windows 10.0.19044 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3080 (NVIDIA; <IP_ADDRESS>29) - AMD Ryzen 9 5950X 16-Core Processor (32 Threads)
Issue description
In Godot 4.2, the comment node in visual shaders is missing and cannot be added to graph, class VisualShaderNodeComment. Class still exists but is not usable
Below are images of version 4.1.1 and 4.2.1.

Steps to reproduce
Open Visual Shader graph and try adding node "Comment"
Minimal reproduction project (MRP)
N/A

See https://github.com/godotengine/godot/pull/79307

Understood, closing down


Inside the brain is not painted after slicing

Hi Federico,
In the version 2, inside the brain is not painted/filled with root color after slicing.
Is there anyway to fix this?
This one was made by the previous version.

This one was made by version 2.

Thanks!

Hey,
It looks fine for me:

with:

from brainrender import Scene
from brainrender import settings

settings.ROOT_ALPHA = .8

s = Scene()

s.root.color('red')

s.add_brain_region("SUB", 'CA1', 'CA3', alpha=.4)

s.slice('frontal')

s.render(camera='frontal')

Can you share the code you've used to generate the image (or a minimal example reproducing the problem) and let me know which version python, vedo, brainrender...
Thanks,
Fede

Hey,
It looks fine for me:

with:

from brainrender import Scene
from brainrender import settings

settings.ROOT_ALPHA = .8

s = Scene()

s.root.color('red')

s.add_brain_region("SUB", 'CA1', 'CA3', alpha=.4)

s.slice('frontal')

s.render(camera='frontal')

Can you share the code you've used to generate the image (or a minimal example reproducing the problem) and let me know which version python, vedo, brainrender...
Thanks,
Fede

Thanks for your quick response.
Actually, when I use your code, I can get the same image that you posted.
I think that the problem only happens when I render thin brain slices.
Version
Python: 3.7.6
Brainrender:  2.0.0
vedo: 2020.4.2
Jupyterlab: 1.2.6
This is my code
from brainrender import Scene
from brainrender import settings
from vedo import embedWindow
embedWindow(None)

settings.SHADER_STYLE = "plastic"
settings.ROOT_ALPHA = 0.5
settings.ROOT_COLOR = [0.8,0.8,0.8]
settings.BACKGROUND_COLOR = "white"
settings.SHOW_AXES = False
settings.WHOLE_SCREEN = False

# Create a brainrender scene
scene = Scene()
scene.add_brain_region("SUB", 'CA1', 'CA3', alpha=.4)

pos = {
     'pos': (43225, 8315, -5048),
     'viewup': (0, -1, 0),
     'clippingRange': (29250, 34639),
   }

plane1 = scene.atlas.get_plane([9400, 0, 0], norm=(1, 0, 0))
plane2 = scene.atlas.get_plane([9900, 0, 0], norm=(-1, 0, 0))

scene.slice(plane1)
scene.slice(plane2)
scene.render(camera = pos)

Thanks!

Thanks for your quick response.
Actually, when I use your code, I can get the same image that you posted.
I think that the problem only happens when I render thin brain slices.
Version
Python: 3.7.6
Brainrender:  2.0.0
vedo: 2020.4.2
Jupyterlab: 1.2.6
This is my code
from brainrender import Scene
from brainrender import settings
from vedo import embedWindow
embedWindow(None)

settings.SHADER_STYLE = "plastic"
settings.ROOT_ALPHA = 0.5
settings.ROOT_COLOR = [0.8,0.8,0.8]
settings.BACKGROUND_COLOR = "white"
settings.SHOW_AXES = False
settings.WHOLE_SCREEN = False

# Create a brainrender scene
scene = Scene()
scene.add_brain_region("SUB", 'CA1', 'CA3', alpha=.4)

pos = {
     'pos': (43225, 8315, -5048),
     'viewup': (0, -1, 0),
     'clippingRange': (29250, 34639),
   }

plane1 = scene.atlas.get_plane([9400, 0, 0], norm=(1, 0, 0))
plane2 = scene.atlas.get_plane([9900, 0, 0], norm=(-1, 0, 0))

scene.slice(plane1)
scene.slice(plane2)
scene.render(camera = pos)

Thanks!

Right if you're cutting twice, so that only a middle section of the brain is left, you want have anything to render at the back, that makes sense no?
If you try passing close_actors=True to one of the calls to slice, then it will try to close the meshes it has cut, is that more like what you'd expect?

Right if you're cutting twice, so that only a middle section of the brain is left, you want have anything to render at the back, that makes sense no?
If you try passing close_actors=True to one of the calls to slice, then it will try to close the meshes it has cut, is that more like what you'd expect?

Ah, OK. It works now. Thanks for your clear explanation!

Ah, OK. It works now. Thanks for your clear explanation!

No problem, have fun!

No problem, have fun!

Sorry, actually one more question.
After closing actor, I see some strange lines in the brain structure. Is there any way to solve this?

Sorry, actually one more question.
After closing actor, I see some strange lines in the brain structure. Is there any way to solve this?

Not  that I know of, this is internal to vedo and how it closes the mesh after cutting, sorry.

Not  that I know of, this is internal to vedo and how it closes the mesh after cutting, sorry.

ok, Thanks!

ok, Thanks!

@jt522 ..I've seen this before.. capping a mesh is not always perfect.. you may try to recompute normals with
mesh.clean().computeNormals() and/or mesh.phong(), but i'm not sure if it will help.
@FedeClaudi I just committed a few changes in vedo which might affect brainrender axes ..
check out https://github.com/marcomusy/vedo/blob/master/docs/changes.md
maybe it's a good idea if you check if it's all ok before uploading to pypi
One other small thing is that you may wish to import (and even change name to) vedo.embedWindow so you dont need to expose vedo to the brainrender user :) e.g.
from brainrender import embedWindow

@jt522 ..I've seen this before.. capping a mesh is not always perfect.. you may try to recompute normals with
mesh.clean().computeNormals() and/or mesh.phong(), but i'm not sure if it will help.
@FedeClaudi I just committed a few changes in vedo which might affect brainrender axes ..
check out https://github.com/marcomusy/vedo/blob/master/docs/changes.md
maybe it's a good idea if you check if it's all ok before uploading to pypi
One other small thing is that you may wish to import (and even change name to) vedo.embedWindow so you dont need to expose vedo to the brainrender user :) e.g.
from brainrender import embedWindow

Thanks for the heads up, will give it a go when I have time.

Thanks for the heads up, will give it a go when I have time.

Thanks for the heads up, will give it a go when I have time.

Thanks for the heads up, will give it a go when I have time.


Ability to add items into the Wagtail Settings sub-menu

A little feature I needed that others might find useful.
This adds an optional new parameter (so shouldn't break any existing code) to wagtailmodeladmin_register, to have your model added into the Wagtail Settings sub-menu rather than the main menu.  The register_settings_menu_item hook it relies on was new in Wagtail 0.7.
Technically this does also work with ModelAdminGroups, but the Wagtail Settings menu has a fixed width, so the expanded group menu isn't visible unless you scroll horizontally to find it.

Hi Matt,
Thanks again for contributing. I really like this idea! I can already think
of a couple of projects I'm working on that could make use of it.
May I suggest though, that we change the implementation slightly, to
control this behavior via an attribute on the ModelAdmin class instead?
That just seems like a more fitting place for this kind of customisation.
What do you think?

Hi Andy,
You're quite right, adding an attribute to ModelAdmin is a much better idea.  Or perhaps an attribute on WagtailRegisterable so that ModelAdminGroup can inherit it too (leaving the problem of the fixed width menu rendering to someone else!).
I'll re-visit this later today, but if you already have an idea what you'd like the attribute to be then let me know.

Hi Matt,
Yes, I think the WagtailRegisterable model would be the best place for
it... that way the method on that model can always reference it without any
issue. add_to_settings_menu would make a sensible attribute name, I
think, with False as a default value.
Cheers!

OK, changes made as discussed. I've tweaked the readme to mention the feature, but I won't be offended if you want to remove that or do it differently!

Spot on @fozcode! Thanks for that.


Dynamic search added in View Opportunity page (#238)

Description
Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.
Fixed #238
Type of change
Please check options that are relevant to your PR.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

Checklist:

[x] I have pulled the latest changes in the repository
[x] I have squashed my commits
[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

@Manvityagi  please add  gssoc and level tags.


Use Docker to Build Linux & Update Versions to v1.68.2

Description of Change
Getting the repo ready for any new things:

Switch to Docker to build Linux native binaries
Update to Ubuntu 16 since 14 is now ESM
Use Clang 4.0 since we can now
Merge the azure-templates-native-linux.yml template into the bootstrapper template to work like the rest of the platforms
Update the NuGet version to 1.68.2
Add logic to update the DevOps build label

Bugs Fixed
None.
API Changes
None.
Behavioral Changes
None.
PR Checklist

[x] Has tests (if omitted, state reason in description)
[x] Rebased on top of master at time of PR
[x] Changes adhere to coding standard
[x] Updated documentation

This is interesting. I hope I will have some time next month to try changing Linux builds to use a static libc implementation (musl). That will open up most distros for us and even let's us build for arm.


List buckets creation

Description
These changes adds the ability to pass a list of buckets to be created in a cos instance and an existing instance.
https://github.com/terraform-ibm-modules/terraform-ibm-cos/issues/239
https://github.ibm.com/GoldenEye/issues/issues/4026
Types of changes in this PR
No release required

[x] Examples or tests (addition or updates of examples or tests)
[ ] Documentation update
[ ] CI-related update (pipeline, etc.)
[ ] Other changes that don't affect Terraform code

Release required

[ ] Bug fix (patch release (x.x.X): Change that fixes an issue and is compatible with earlier versions)
[x] New feature (minor release (x.X.x): Change that adds functionality and is compatible with earlier versions)
[ ] Breaking change (major release (X.x.x): Change that is likely incompatible with previous versions)

Release notes content
These changes contribute as a BREAKING CHANGE primarily because of the variable bucket_name of type string is replaced with variable buckets_names (type list). The outputs are modified to reflect this change.

Checklist for reviewers

[x] If relevant, a test for the change is included or updated with this PR.
[x] If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

Merge by using "Squash and merge".

Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.
The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).

what is the impact on consumers who are currently consuming this module to create buckets? Have we tested to ensure that the upgrade will not destroy a bucket? I understand its a breaking change because module inputs and outputs are changing, but I think we still need to ensure someone’s COS bucket isnt going to get destroyed on upgrade

@ocofaigh When determining whether an upgrade would destroy any buckets, this is the output returned. The code will generate test-cos-bucket-1 and test-cos-bucket-2 if no buckets are specified, just as it does in the original code from the master branch (complete example). So, only the CBR rules will be deleted and recreated when we do the upgrade, as shown below.
`Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:

create

destroy

Terraform will perform the following actions:
module.cos_bucket1.module.bucket_cbr_rule[0].ibm_cbr_rule.cbr_rule will be destroyed
(because module.cos_bucket1.module.bucket_cbr_rule[0] is not in configuration)

resource "ibm_cbr_rule" "cbr_rule" {

created_at          = "2023-03-15T21:44:18.000Z" -> null
created_by_id       = "IBMid-550007TT57" -> null
crn                 = "crn:v1:bluemix:public:context-based-restrictions:global:a/ACCOUNT_ID::rule:e0c38fce921c33684de5e626be9a42af" -> null
....
}

module.cos_bucket1.module.bucket_cbr_rule["test-cos-bucket-1"].ibm_cbr_rule.cbr_rule will be created

resource "ibm_cbr_rule" "cbr_rule" {

created_at          = (known after apply)
created_by_id       = (known after apply)
crn                 = (known after apply)
description         = "sample rule for bucket 1"
enforcement_mode    = "report"
....
}

module.cos_bucket2.module.bucket_cbr_rule[0].ibm_cbr_rule.cbr_rule will be destroyed
(because module.cos_bucket2.module.bucket_cbr_rule[0] is not in configuration)

resource "ibm_cbr_rule" "cbr_rule" {

created_at          = "2023-03-15T21:44:18.000Z" -> null
created_by_id       = "IBMid-550007TT57" -> null
crn                 = "crn:v1:bluemix:public:context-based-restrictions:global:a/ACCOUNT_ID::rule:e0c38fce921c33684de5e626be9a3ddc" -> null
....
}

module.cos_bucket2.module.bucket_cbr_rule["test-cos-bucket-2"].ibm_cbr_rule.cbr_rule will be created

resource "ibm_cbr_rule" "cbr_rule" {

created_at          = (known after apply)
created_by_id       = (known after apply)
crn                 = (known after apply)
description         = "sample rule for bucket 2"
enforcement_mode    = "report"
....
}

Plan: 2 to add, 0 to change, 2 to destroy.
Changes to Outputs:

bucket_name1 = [

"test-cos-bucket-1",
] -> null

bucket_name2 = [

"test-cos-bucket-2",
] -> null

buckets      = {

test-cos-bucket-1 = {

bucket_crn           = "crn:v1:bluemix:public:cloud-object-storage:global:a/ACCOUNT_ID:9309ec9b-e103-46f5-84c5-344a682eafaa:bucket:test-cos-bucket-1"
bucket_id            = "crn:v1:bluemix:public:cloud-object-storage:global:a/ACCOUNT_ID:9309ec9b-e103-46f5-84c5-344a682eafaa:bucket:test-cos-bucket-1:meta:rl:us-south:public"
bucket_name          = "test-cos-bucket-1"
bucket_storage_class = "standard"
cos_instance_guid    = "9309ec9b-e103-46f5-84c5-344a682eafaa"
cos_instance_id      = "crn:v1:bluemix:public:cloud-object-storage:global:a/ACCOUNT_ID:9309ec9b-e103-46f5-84c5-344a682eafaa::"
key_protect_key_crn  = "crn:v1:bluemix:public:kms:us-south:a/ACCOUNT_ID:acd6591b-6693-4724-b3dc-8c2ce90003d7:key:a4d412af-2ab5-4ddc-ab48-df02c6fa028d"
resource_group_id    = "65460e85d7e3445f8abcb7ed2e23bb39"
s3_endpoint_private  = "s3.private.us-south.cloud-object-storage.appdomain.cloud"
s3_endpoint_public   = "s3.us-south.cloud-object-storage.appdomain.cloud"
}

test-cos-bucket-2 = {

bucket_crn           = "crn:v1:bluemix:public:cloud-object-storage:global:a/ACCOUNT_ID:9309ec9b-e103-46f5-84c5-344a682eafaa:bucket:test-cos-bucket-2"
bucket_id            = "crn:v1:bluemix:public:cloud-object-storage:global:a/ACCOUNT_ID:9309ec9b-e103-46f5-84c5-344a682eafaa:bucket:test-cos-bucket-2:meta:crl:us:public"
bucket_name          = "test-cos-bucket-2"
bucket_storage_class = "standard"
cos_instance_guid    = "9309ec9b-e103-46f5-84c5-344a682eafaa"
cos_instance_id      = "crn:v1:bluemix:public:cloud-object-storage:global:a/ACCOUNT_ID:9309ec9b-e103-46f5-84c5-344a682eafaa::"
key_protect_key_crn  = "crn:v1:bluemix:public:kms:us-south:a/ACCOUNT_ID:acd6591b-6693-4724-b3dc-8c2ce90003d7:key:a4d412af-2ab5-4ddc-ab48-df02c6fa028d"
resource_group_id    = "65460e85d7e3445f8abcb7ed2e23bb39"
s3_endpoint_private  = "s3.private.us.cloud-object-storage.appdomain.cloud"
s3_endpoint_public   = "s3.us.cloud-object-storage.appdomain.cloud"
}
}
`

@daniel-butler-irl Are you happy enough with this before merge?

@ocofaigh It might be better to pass a list of buckets ie full bucket configurations, rather than just names. If you have multiple bucket configurations (like I have for FSCloud) then this will not be of any use and we still have to use the old method of provisioning. Not sure what way we want to go here...

I think I agree - It's very likely someone will want to create multiple buckets with different configurations. So I think we should take same approach as we do for worker_pools in terraform-ibm-base-ocp-vpc
@mounika-nalla @shemau thoughts?

Also since this is a breaking change maybe we can rename existing_key_protect_instance_guid and key_protect_key_crn to something more generic maybe  existing_kms_instance_guid and kms_key_crn? I will be using these variables to pass in hyper protect details which works its just the names are a bit misleading

Could we keep 'bucket_name' in addition to adding 'bucket_names' in the interface, so that we do not end up with a breaking change. Either bucket_name or bucket_names should be set.

Are we leaving the existing bucket creation parts in? We should probably do a breaking change and replace it with the new submodule. @ocofaigh @vburckhardt

@shemau This repo had been migrated to the new pipeline, to trigger post a comment /run pipeline when you think it's ready for test

/run pipeline

/run pipeline

@shemau @daniel-butler-irl @mounika-nalla This PR is passing the pipeline. Can we get a final review done on it so it can be approved and merged?

/run pipeline

/run pipeline

/run pipeline

/run pipeline

/run pipeline

:tada: This PR is included in version 6.10.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Dragon Form spell effects don't actually do anything for NPCs

When applying or removing the spell effects for any of the Dragon Forms to NPC sheets, I noticed it doesn't automatically update the stats for NPCs.  It does appear to work on PCs, but does not add the breath weapon attack of the form to the Actions tab (minor annoyance).

Battle form effects not working with NPCs is a known limitation, but we can look at adding a dragon breath action.


Update 1password to 6.6.1

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

This one was already submitted over 19 hours ago.

There are at least 3 pull requests for 1password at the moment? (can tell that it's a popular application)

It could also be that they hit a road bump this week with some certificates issues: https://blog.agilebits.com/2017/02/19/1password-for-mac-6-5-5-manual-update-required/
Everything seized up and there have been a flurry of updates for versions of the software that were downloaded directly from their website (that includes homebrewers).

#30359.


support streaming responses

🚀 The feature
support streaming responses ,
Motivation, pitch
support streaming responses ,

This is a duplicate of #26


Consider making the overview a content page

tofino://overview
Because why not?

Makes sense for consistency -- I don't think there's much actual value in doing so yet unless we're changing it up a bit

Making it a more normal tab could fix #895

Seems like there'd be a fair amount of special casing needed to make it a normal tab - it can't be closed, the back button works differently, you can't navigate / change the URL.  I guess it's like a pinned and readonly tab.
But there's also special casing needed to fix things like #895 as-is, and maybe we'll want pinned tabs eventually anyway.

We're going to have top special case the tab close code regardless (because of #897). My gut says that we'll use less special casing if overview is what the app thinks of as the currently selected tab vs. having no selected tab (or a phantom tab as it is right now)

we'll use less special casing if overview is what the app thinks of as the currently selected tab vs. having no selected tab

I agree with that, based on the current design.  If we are fairly settled on the UI being a 'tab-like' thing then I'm all for it.
One risk to making it a tab is if the experimentation leads to a design in which is really doesn't look / act like a tab then the implementation might take on extra complexity (i.e. if it turns into a button on the nav bar).


Scalars can't be used as condition and inside a conditional

@gtscript.stencil(rebuild=True, backend="gtmc")
def copy_stencil(
    in_storage: gtscript.Field[float], out_storage: gtscript.Field[float], val: float
):
    with computation(FORWARD):
        with interval(...):
            if in_storage > val:
                out_storage = val

if a scalar condition is used both as part of the condition as well as a read inside the conditional, the BlockMaker seems to assert

This seems to be related to the deprecated legacy backends.


MWPW-137345: [For Stage] Implementation of GenFill Interactive Marquee

Implementation of GenFill Interactive Marquee
Resolves: MWPW-137345
Test URLs:
Before: https://main--cc--adobecom.hlx.page/drafts/drashti/MWPW-137345/genfill-container?martech=off
After: https://stage-genfill--cc--adobecom.hlx.page/drafts/drashti/MWPW-137345/genfill-container?martech=off
For testing different viewports:
https://stage-genfill--cc--adobecom.hlx.page/drafts/drashti/MWPW-137345/genfill-container3?martech=off
https://stage-genfill--cc--adobecom.hlx.page/drafts/drashti/MWPW-137345/genfill-container2?martech=off

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f6d219d) 68.96% compared to head (1d5b3b1) 68.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##            stage     #116   +/-   ##
=======================================
  Coverage   68.96%   68.96%
=======================================
  Files           2        2
  Lines         261      261
=======================================
  Hits          180      180
  Misses         81       81

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Git fork selecting custom git instance doesn't change

I used the install.bat with a successful installation and placed the wslgit.exe somewhere on my machine and added it to PATH.
However when I try to set a custom git instance in Fork it doesn't appear to change?

 Maybe the setup is sort of unclear to me?

Symlinks are 0 kB size, that is correct.
But since you have the resources folder I guess that you cloned this repository? Easiest is to just download the latest release zip from https://github.com/andy-5/wslgit/releases/latest and extract, and from there run the install.bat script :)

I have the same problem. I cannot select the bin/git.exe instance in Git Fork. Does anyone have a solution?

I also have the same problem, it used work fine and I had to to make a few updates (git inside WSL and wslgit due to https://github.com/andy-5/wslgit/issues/134) and now it no longer works.
I tried manually editing the GitInstancePath in Fork settings.json file and when starting Fork I get the following error:
System.InvalidOperationException: Process must exit before requested information can be determined.
   at System.Diagnostics.Process.EnsureState(State state)
   at System.Diagnostics.Process.get_ExitCode()
   at Fork.Git.Interaction.GitRequest.Execute(Boolean silent)

Upon looking at the logs, I think the -version does not work on the current git.exe in bin
⚠ 2023-02-15 12:18:03.704 Shell request 'C:\wslgit\bin\git.exe' with arguments 'version' failed: ''

I had this same thing happen and the problem was missing wslgit.exe under the cmd directory. No idea how zip extraction failed, as it works fine when retrying


Allow adding custom examples in the README

Nodejs-repo-tools issue #123 needs to land so that we can add custom examples in the README file.

nodejs-repo-tools is no longer the path forward here.  @crwilcox documented a templating feature in synthtool that we should instead :)

@DominicKramer , is the edit needed to include a sample? The previous tooling supported that. I am curious if you can provide details on what makes this case special?

@crwilcox I need to include additional documentation and samples to the readme.  Do you have an example of what the synthool.py script would need to be to have synthool generate a Readme similar to the default Readme but with additional samples included?  Thanks.

For posterity, this is blocked right now by https://github.com/googleapis/google-cloud-node/issues/2868.

I have PR #313 open that updates the README.  I think it would be good to have the README updated the way I have it (at least in the short term) so that users have access to additional documentation.  Then we can make a tracking bug to have the README use synthtool for the long term.  The updated README will also help guide the type of functionality I need in synthtool too, which I think is helpful.


Updates for deployment

Submitting code for creating lambda container for use as the backend API.

Will replace the backend container in ECS with Lambda
Optimized the Dockerfile with multi-stage

Submitting code for React updates to support user authentication using AWS Cognito

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.2%) to 72.549%

Files with Coverage Reduction
New Missed Lines
%

piro/reactions.py
1
89.18%

Totals

Change from base Build<PHONE_NUMBER>:
-0.2%

Covered Lines:
481

Relevant Lines:
663

💛  - Coveralls

@JosephMontoya-TRI I think I forgot to merge this from a while back. just double checking now, is it ok?

Yep!  Will merge shortly.


region is not valid

You have not provided an S3 region. You can do so using our config script.
Getting the above error

HI @senrysaRanjeet,
If you read the instructions on the wiki, you'll see that you need to set the S3 region via the CLI:
https://github.com/thaiphan/magento2-s3/wiki/Installation#step-1-configure-magento-to-use-your-s3-bucket
Regards,
Thai


Constant Loading When in Tabs

Version 2.2.0
Vue.js version 2.4.2
What is expected?
I have a news viewer component that has 2 tabs, one for latest articles and one for tweets.
Ideally I'd like to use the infinite-loading for both tabs, but when I tried scrolling was detected on both instances since the tab content exists on the same page, so I opted to just use it on the tweets tab since there is far more content.
What is actually happening?
When the tweets tab is not active the infinite scroll component just massively loads over and over. No loaded state is ever triggered. If I set the tweets tab to active on page load, I get proper loading initially, but once I change tabs ... massive loading again.
How to reproduce this problem?
My code looks like so:
<template>

					Source: {{ tweet.tweet_id }}
					Posted: {{ tweet.posted_at }}

		<infinite-loading @infinite="infiniteHandler"></infinite-loading>

</template>

I'm using Laravel 5.4 as my API which returns a LengthAwarePaginator so I have access to current_page, last_page etc.
I tried the infinite-wrapper approach which caused the component to either fail completely, or constantly load as always, no change basically.
Thanks

Okay, I will disable attempt load when this component is invisible in the next version, thanks!

Hi @19peaches , I have been released a new version v2.2.1, include this change, you can try it now.

Works perfectly now .... thanks so much.

It's looks like you broke scrolling.
I have <infinite-loading :on-infinite="onInfinite"                           direction="top"                           ref="infiniteLoading">           <sw-spinner slot="spinner"></sw-spinner>         </infinite-loading>.
In attemptLoad I see this line (this.$el.offsetWidth + this.$el.offsetHeight) > 0) which always false because this.$el refers me to infinite-loading-container which has 0 width and height and never emit infinite event.

@ymatuhin what is your situation that use the container which has 0 width and height as the scroll wrapper?

My container has positive width and height. this.$el refers not to my container, it refers to <infinite-loading :on-infinite="onInfinite" direction="top" ref="infiniteLoading"> <sw-spinner slot="spinner"></sw-spinner> </infinite-loading>

I see, recommend you use the force-use-infinite-wrapper feature, more details here

I tried, but it didn't help me. this.$el inside attemptLoad still refers me to class="infinite-loading-container".

Maybe instead $el should be this.scrollParent?

@ymatuhin oh, I thought we had been discussing this.scrollParent, sorry. this.$el should be related to the  class="infinite-loading-container", is there something cause this.$el has 0 width and height?


[WIP] feat(es-dev-server): add experimental hot module replacement

Fixes https://github.com/open-wc/open-wc/issues/787

is this only blocked on review?

as far as I can tell custom-elements-hmr-polyfill still needs some improvements before it's generally usable... especially a good "ReflowStrategy" as key...
currently, it's basically a quicker reload... but not what people would expect for HMR... state would need to stay intact - developers are "spoiled" with how nice HMR works in react... so I guess anything less will not fly 🙈
PS: definitely a good starting point but I think it needs more work before
PPS: imho it should be really close to what react does... e.g. do not register any real classes but proxy classes and if a reregister gets triggered then instead replace those proxy functions and trigger a connectedCallback/rerend - I think this will probably also need some smart way to only resend changed files (e.g. server needs a dependency graph to send all files possibly affected by a file change... )

It does implement a proxy class actually, it just re renders through inner html by default. If a custom element base class supports it you can trigger a re render on all instances, but I dont think thats the reponsibility of this library.

you should know which element got updated right? e.g. which tag?
so you should be able to do something like this right?
// beware mega psoido code :p
const toUpdateElements = deepQuerySelectorWhichPiercesShadowDom(tagToUpdate);
toUpdateElements.forEach(el => {
  // replace proxy function stuff
  el.disconnectedCallback();
  el.connectedCallback();
});

which should work for every web component be it LitElement or Stencil or ... right?

That doesnt re run work in the constructor, which is a problem for LitElement and can be a problem for author code.
Because of the proxy we can keep a reference to all connected elements so thats good

Closing this for now to avoid clutting the review lane, still working on it though.


Register davidbisky.is-not-a.dev

Added davidbisky.is-not-a.dev using the CLI.

I have read the CLA Document and I hereby sign the CLA


indexing projects that are not the root of the repository

Cedar is a great example of a project where the Lean project is in a subdirectory of the main git repository, but we really ought to have on Reservoir!

Right now, I do not see an feasible way to do this. There are two major problems:

GitHub code search already has a very low limit on search results (and thus using it already is not heavily scalable). Extending the search to any file in a repository would quickly shoot past the limits.
Repositories can easily have multiple lakefiles. Many of these "pacakges" are things we definitely do not want in Reservoir (e.g., examples). It is thus not clear how to perform such a search without picking up a lot of bad results.

User registration!


Default browser style

Hello, has issue in sizing of chart because browser has default margin

Proposal: Reset default browser style for body

Hey! We will remove that margin on the next update

The new version is available and contains the fix


Interview Tips

"What is the most unexpected good thing you've found as a result of working at $COMPANY?"
"What's a typical day/month/week look like?"
"Are there any employee run interest groups for things like mindfulness?"
"How laid-back is the culture?"
"Do postmortems have formal blame as a part of the process?"
"Does code get reviewed before it ships into production?"

Write a tech blog like this one. This allows you to skip a lot of the technical parts of technical interviews.


fix(mock): vi.mock with line breaks in arguments

Fix #501

If it's a fix, let's have fix: so it will be listed in the changelog.


[openssl] added support for platforms without libdl

Since some platforms lack a dl library, the vcpkg-cmake-wrapper.cmake script from the OpenSSL port should not indiscriminately add it to the link libraries list.
Tested on the following platforms with a project that uses LibSSH2:

Linux (WSL on Windows 10 1709)
FreeBSD (12.0-CURRENT r324496 amd64)

These changes have no effect on Windows builds.
P.S.: @ras0219-msft If you already have something better, just close this without commenting. :)

Thanks for making the PR, @qis!


Report current function name when invoke result length wrong

This makes for a more actionable error message.

Thanks @findepi and @jonahgao


Adding output metadata to a Jupyter Notebook (ipynb) file with vscode.NotebookEdit does not work

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: VSCode - insiders 1.89.0-insider
OS Version: Win11 23H2

Steps to Reproduce:

Run the sample code below

const notebookEdit = vscode.NotebookEdit.insertCells(cell.index, [
	{
		kind: vscode.NotebookCellKind.Code,
		value: "source",
		languageId: "languageId",
		outputs: [
			{
				items: [vscode.NotebookCellOutputItem.text("Hello", "text/plain")],
				metadata: {
					microsoft: "output metadata"
				}
			}
		]
	}
]);

const edit = new vscode.WorkspaceEdit();
edit.set(editor.notebook.uri, [notebookEdit]);
void vscode.workspace.applyEdit(edit);

Observed:
The new cell is created without the output metadata:
{
  "cell_type": "code",
  "execution_count": null,
  "metadata": {
	"vscode": {
	  "languageId": "languageId"
	}
  },
  "outputs": [
	{
	  "data": {
		"text/plain": [
		  "Hello"
		]
	  },
	  "metadata": {},
	  "output_type": "display_data"
	}
  ],
  "source": [
	"source"
  ]
}

Expected Result:
The output metadata is added.
metadata: {
	microsoft: "output metadata"
}

To save time please put together a full extension that shows this issue so we don't have to waste time trying to setup a repo

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


quill-cassandra: ops not working with UnassignedAction[] with Insert[]/Update[_]

Version: 0.5.1-SNAPSHOT
Module: quill-cassandra
Expected behavior
It should be possible to write this quotations:
quote(query[Person].insert.ifNotExists)

quote(query[Person].filter(_.id == 1).update.ifExists)

Actual behavior
ifExists/ifNotExists can't be used with unassigned actions.
@getquill/maintainers

I remember this being an issue in 0.3.* and 0.4.* (one of the reasons I didn't choose to use quill last time).
Now that I'm trying it again in 0.8.0 it seems to work, good to see.

I'm hitting this now with 0.8.0, and it doesn't work.
Do I have to add all the fields from the case class to the insert operation to make it work?

fixed by https://github.com/getquill/quill/pull/512


WIP: Rework of Sklearn Metrics

What does this PR do?
Fixes #1305  and is a rework of #1320 based on #1326
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃

Hello @justusschock! Thanks for opening this PR.

In the file pytorch_lightning/metrics/sklearn.py:

Line 59:111: E501 line too long (154 > 110 characters)
Line 100:1: E302 expected 2 blank lines, found 1
Line 141:1: W391 blank line at end of file

Do see the Hitchhiker's guide to code style

@williamFalcon why did you close the metrics PR? @justusschock?

@Borda any idea, why scipy building fails?

@justusschock there is also problem with installing the minimal requirements, mind check?
@awaelchli will check the docs, thx

I'm done fixing the docs errors but can't push, permission denied. Is it a setting on this branch?
Otherwise please merge this branch
https://github.com/awaelchli/pytorch-lightning/tree/new_sklearn_metric

Regarding the setup with minimal: This is strange, but It may be related to https://github.com/scipy/scipy/issues/12203
At first I thought it was because older torch had older numpy dependency, which might somehow be incompatible with current scipy build, but I checked and torch does not restrict it's numpy dependency...

@peterbell10 sorry for pinging you here, but I didn't want to spam in the other issue. Do you maybe have any idea, why we cannot install prebuilt wheels here?

I'm not sure but you could try running pip with verbose output and see if it tells you.

@justusschock is it still WIP or ready for review/merge? it looks good to me :rabbit:

@Borda this should be ready, but It is still marked as WIP, since sklearn/scipy install failed and I did not have the time to investigate this further so far...

@Borda this should be ready, but It is still marked as WIP, since sklearn/scipy install failed and I did not have the time to investigate this further so far...

ok, lest make is ready and I ll drop wip to be clear that with passing test we can merge it :rabbit:

@justusschock do we need imgmath_latex? can you point out where it is used?

@Borda I think I added it when I was requested for review on metrics because there was a formula and it did not look right. PyTorch also uses imgmath latex. Is it creating problems?

@Borda I think I added it when I was requested for review on metrics because there was a formula in the docs and it did not look right, so I fixed it. PyTorch also uses imgmath latex. Is it creating problems?

kind of, because of imgmath extension, I had to pull an image with latex instead of the general one


implement the type stubs for generated modules

note: vendors in https://github.com/simonpercivall/astunparse for support to implement type hints for python versions less than 3.9

I rebased this to the current develop branch, aiming to get this into 2.5 release directly.


Tcmalloc release large memory may block the memory allocation thread

Steps to reproduce the behavior (Required)
TcMalloc releases a large block of memory at one time, which will block all memory-applying threads. Need to modify the mechanism of releasing memory
Find a slightly more complicated SQL and use MysqlSlap to push it down to the CPU bottleneck
Expected behavior (Required)
Real behavior (Required)
StarRocks version (Required)
master

https://issues.apache.org/jira/browse/IMPALA-2800

https://github.com/gperftools/gperftools/issues/754#issuecomment-167447351

MallocExtension::instance()->SetNumericProperty("tcmalloc.aggressive_memory_decommit", 1);
This method will solve this problem, but it will reduce the performance of memory release

the implement of kudu
void GcTcmalloc() {
  TRACE_EVENT0("process", "GcTcmalloc");

  // Number of bytes in the 'NORMAL' free list (i.e reserved by tcmalloc but
  // not in use).
  int64_t bytes_overhead = GetTCMallocProperty("tcmalloc.pageheap_free_bytes");
  // Bytes allocated by the application.
  int64_t bytes_used = GetTCMallocCurrentAllocatedBytes();

  int64_t max_overhead = bytes_used * FLAGS_tcmalloc_max_free_bytes_percentage / 100.0;
  if (bytes_overhead > max_overhead) {
    int64_t extra = bytes_overhead - max_overhead;
    while (extra > 0) {
      // Release 1MB at a time, so that tcmalloc releases its page heap lock
      // allowing other threads to make progress. This still disrupts the current
      // thread, but is better than disrupting all.
      MallocExtension::instance()->ReleaseToSystem(1024 * 1024);
      extra -= 1024 * 1024;
    }
  }
}

How about replacing TCMalloc with Jemalloc @trueeyu

How about replacing TCMalloc with Jemalloc @trueeyu

Based on TcMalloc, this problem can be solved. I haven't studied JeMalloc, and I don't know what advantages it has.

Tcmalloc 2.8 release node:
Bug Fix: releasing memory back to kernel is now made with page heap lock dropped.


Fixed compile time issue on p1 wallet (#2066)

Fixes compile time issue due not type-casted variable.

See #2066.

Uh, I guess since this just fixes an .md file it's safe to merge without tests.


Close HDF5 files after loading.

Files were being kept open, resulting in problems when
loading many of them. See issue #204.

@liesbethvanherpe this should deal with #204.

Current coverage is 100.00%

Merging #205 into master will not affect coverage as of a4dfe72

@@            master    #205   diff @@
======================================
  Files           35      35
  Stmts         1416    1419     +3
  Branches         0       0
  Methods
======================================
+ Hit           1416    1419     +3
  Partial          0       0
  Missed           0       0

Review entire Coverage Diff as of a4dfe72

Powered by Codecov. Updated on successful CI builds.

This looks OK to me.

Fixes #204.


facts: avoid duplicated element in devices list

When using osd_auto_discovery, devices is built multiple times due
to multiple runs of ceph-facts role. It end up with duplicate
instances of a same device in the list.
Using unique filter when building the list fixes this issue.
Signed-off-by: Guillaume Abrioux<EMAIL_ADDRESS>

jenkins test centos-container-podman

jenkins test centos-container-podman

jenkins test centos-container-podman

jenkins test centos-container-podman

jenkins test centos-container-podman


37 add cli

Codecov Report
Attention: Patch coverage is 76.41921% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 82.62%. Comparing base (85f1dfb) to head (bb7b638).

Files
Patch %
Lines

src/iSparrow/repl.py
79.18%
32 Missing and 9 partials :warning:

src/iSparrow/sparrow_setup.py
57.89%
5 Missing and 3 partials :warning:

src/iSparrow/sparrow_watcher.py
54.54%
2 Missing and 3 partials :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   84.17%   82.62%   -1.56%
==========================================
  Files           8        9       +1
  Lines         632      846     +214
  Branches      102      149      +47
==========================================
+ Hits          532      699     +167
- Misses         71      107      +36
- Partials       29       40      +11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[ROCM] enable lu_op (#1433)

This prs the lu_op on rocm.

@bloops @gbaned Is there anything I should change in this PR?

@cheshire @gbaned can we get an update on this PR? Been open for 22 days.

@cheshire @gbaned can we get an update on the status of this PR?

@cheshire @gbaned Issues have been addressed.

@cheshire Can you please review this PR ? Thanks!

@cheshire @gbaned Is there anything we can do?

@cheshire Can you please review this PR ? Thanks!

@cheshire Any updates on this

@cheshire What should we do about the ci failures? There is no link for more details for the failures. Is it unrelated to this pr?


[api] Fix service_dialogs query to not ask for content when specific attributes are asked for.

When asking for individual service_dialogs, we always returned the content which is time consuming. This was even the case when specific attributes were being asked for, i.e. GET /api/service_dialogs/:id?attributes=id,label,description also returned the content.

@AparnaKarve @h-kataria there you go, let me know if this fixes the performance issue in the SSUI when showing results.
@gtanzillo @imtayadeway please review.  Thanks.

Hi,
This PR worked great.  This query:
function resolveServiceDialogs(CollectionsApi) {
        var options = {
          expand: 'resources',
          attributes: ['id', 'description'],
          sort_by: 'description',
          sort_options: 'ignore_case'};

        return CollectionsApi.query('service_dialogs', options);
      }

...now returns...
Service Dialogs = [
  {
    "href": "http://localhost:8001/api/service_dialogs/1000000000014",
    "id":<PHONE_NUMBER>014,
    "description": "AWScreate_vpc"
  },
  {
    "href": "http://localhost:8001/api/service_dialogs/1000000000002",
    "id":<PHONE_NUMBER>002,
    "description": "Clone to OpenStack"
  },

Thanks!

need to revisit.

@abellotti Looks great! :musical_note:

LGTM :+1:


Address outstanding comments on patterns

We merged #757 with several comments still open, in order to get the first draft to ECMA members.
This issue is basically a reminder that we should still go through them. Neal, feel free to just resolve any that have been addressed, or @ people for more details if they're insufficient. I'd expect that a single PR could address a bunch of the niggles that were left as comments.

@gafter: Are you able to look at these during August at all?

dressing this now.  I will close or comment on each open comment on that PR.


Add Create and Delete HanaInstance commands to CLI

Take auto-generated files from azure-sdk-for-python
Update release version
Write connectors to call PutHanaInstance/DeleteHanaInstance from the CLI commands

Add necessary CLI parameters for Create to work

Testing performed as advised here
Logs showing attempts to create a new HanaInstance or delete an existing HanaInstance are rejected as not supported: https://jarvis-west.dc.ad.msft.net/19E1592D (I purposely did not test in a white-listed subscription where I would actually delete/create something that would mess up our runner). Deleting a non-existent resource returned a 204 from ARM and never queried our RP.

I will not merge this PR until https://github.com/Azure/azure-hanaonazure-cli-extension/pull/22 is merged; it fixes a breaking change, and sets a lower version of the extension than this PR does.

@dwj300 Please review; waiting since you expressed a desire to review

I've successfully tested create and delete on these commits:
az hanainstance create --debug -n Test02 --ip-address <IP_ADDRESS> -l japaneast --os-computer-name Test02 --partner-node-id "/subscriptions/1ba60399-6ce1-4704-8155-5921d35e914e/resourceGroups/TYO-T520/providers/Microsoft.HanaOnAzure/hanaInstances/Test01" -g TYO-T520 --ssh-public-key "<a-key>"; echo $?
{
  "hanaInstanceId": "68e4e5df-52bd-4c4d-892f-af64f363cee2",
  "hardwareProfile": {
    "hanaInstanceSize": "S192",
    "hardwareType": "Cisco_UCS"
  },
  "hwRevision": "Rev 3",
  "id": "/subscriptions/1ba60399-6ce1-4704-8155-5921d35e914e/resourceGroups/TYO-T520/providers/Microsoft.HanaOnAzure/hanaInstances/Test02",
  "location": "japaneast",
  "name": "Test02",
  "networkProfile": {
    "circuitId": "NA",
    "networkInterfaces": [
      {
        "ipAddress": "<IP_ADDRESS>"
      }
    ]
  },
  "osProfile": {
    "computerName": "Test02",
    "osType": null,
    "sshPublicKey": "<a-key>",
    "version": null
  },
  "partnerNodeId": "/subscriptions/1ba60399-6ce1-4704-8155-5921d35e914e/resourceGroups/TYO-T520/providers/Microsoft.HanaOnAzure/hanaInstances/Test01",
  "powerState": "unknown",
  "provisioningState": "Succeeded",
  "proximityPlacementGroup": null,
  "resourceGroup": "TYO-T520",
  "storageProfile": {
    "nfsIpAddress": "<IP_ADDRESS>",
    "osDisks": null
  },
  "tags": {},
  "type": "Microsoft.HanaOnAzure/hanaInstances"
}

az hanainstance delete --debug -n Test02 -g TYO-T520

<rebased against master>

Lgtm


Vservice gw heterogenous ns

Description
Currently there is no support to watch multiple namespaces due to a limitation in the client-go library. The informers doesn't support a list of namespaces due to which you can either watch one or all namespaces. With the evolution of multi-tenancy, heterogeneous deployments for example: Virtual Service and Gateway deployed on different namespaces is a very common use case.
Because of the  above mentioned limitation, it's not possible to achieve the heterogeneous deployment scenario's. You can check this issue for one such failed scenario(https://github.com/kubernetes-sigs/external-dns/issues/2911).
With this PR, the GW sources are fetched by watching the gateway namespace instead of the virtualservice namespace.
Tested for both namespace and cluster scoped deployed on EKS with Route53.
To add more context to this PR, currently the gateway targets are fetched via the service metadata fetched as part of the informers watching the namespace where virtual services are deployed. This works well when both the virtual service and gateway resource are deployed in the same namespace but would fail if the gateway is deployed in another namespace. This PR fixes this problem by fetching the gateway targets directly from the gateway resource namespace.

Fixes #2911
Checklist

[ ] ~Unit tests updated~
[ ] ~End user documentation updated~

@azun  Could you please help merge this PR?


Missing custom icons

Package (line 8751) to twitter-retweet (line 11900) are missing custom icons

Ill get to it later


Series limit doesn't work in time-series chart

A clear and concise description of what the bug is.
How to reproduce the bug

Go to 'Explore'
Select Time-series bar chart or area chart (probably others fit as well)
Select Metrics (in my case for ClickHouse query it is uniq(user_id))
Select Group by some column with high cardinality.
Select Series limit (5 or 10).
Chart doesn't change comparing with not selected Series limit. The query also doesn't change.

Expected results
I expect to see only top 5 or 10 values of the dimension selected in Group by.
Actual results
I see all the values, but not limited to 5 or 10.
Screenshots

Environment

browser: Chromium Version 95.0.4638.54 (Official Build) snap (64-bit)
superset version: 1.3.1
python version: No access
node.js version: No access
any feature flags active: No access

Checklist
Make sure to follow these steps before submitting your issue - thank you!

[ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[x] I have reproduced the issue with at least the latest released version of superset.
[x] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context
Moreover, sort descending doesn't work properly as well.

Hello @volhahedranovich I am closing this issue as we haven't heard from you in a little while. Let me know if any additional assistance is required. Thank you!


Error when using # in database password

I use # in my database password, first time installing is ok, but fail to setup next time because gopkg.in/ini.v1 treat # as comments, then of cause password is wrong. Maybe give a notice when enter database password to install program or other better ways?

Actually you can edit it in the config file like:
PASSWORD= `my#password`

Updated gopkg.in/ini.v1 package to add quotes around value with it contains #.

:+1:

Closed as implemented. :octocat:


C++ Template argument can't be a pointer

C++ template arguments can't be pointers, as the compiler then fails with syntax error, so for example libcpp.cast.dynamic_cast is useless.

A workaround is to declare a typedef.

Duplicate of #534.


Vulnerability roundup 91: evolution-data-server-3.34.4: 1 advisory [7.5]

search, files

[ ] CVE-2020-16117 CVSSv3=7.5 (nixos-20.03)

Scanned versions: nixos-20.03: 977000f149b. May contain false positives.
Cc @hedning
Cc @lethalman
Cc @worldofpeace

See also: #93993

20.03 is frozen and EOL.
Closing.


feat: pass flags and environment variables to go build

A few enhancements:

Added OS interoperable way of passing environment variables to go build
Added ability to pass build flags to build executor
Updated executor schema to properly communicate the options and expected types
Expanded unit tests to validate new functionality
Updated executor options to properly communicate output and main are optional

This replaces the PR #65

@beeman this superseeds #65 and is more robust.

looks awesome, any chance this works with the nx spec for target specific env files?
i.e
.env.build and .env.serve

looks awesome, any chance this works with the nx spec for target specific env files?
i.e .env.build and .env.serve

It would be better to handle this as a separate issue that way if you wanted to tackle it you could 😄. If you don't have the time I am more than happy to work on it.

@beeman anyway we can get this reviewed?

@beeman this also superseeds #80

Thanks @phillipCouto - I finally found time to merge this and released it as version 2.8.0.

Awesome! Thank you ☺


A bit readme for scripts/ folder

I think there should be a readme for it, or at least some words about create_languages_db.py in CONTRIBUTING.md.
https://github.com/jacksonllee/iso639/blob/main/scripts/create_languages_db.py

Hello, thank you for the suggestion! I've just added a note about scripts/create_languages_db.py in README.md at efab0b18dfb7fd00a9a5b21c45f836170c068951. Closing this issue now.


Fully Dockerized test suite

This test suite should be platform independent to anywhere there's a Docker daemon.
Usage
./script/test executes the tests
Principles
Two containers are created: one is based on the latest Postgres alpine image; the other contains the source code to Rope with libpq preinstalled. The two containers are linked with a bridge network and the Postgres container is accessible as the postgres host, exposing its DB on the default Postgres port.
Other changes

added a script/generate script that runs Sourcery (if installed) and auto generates LinuxMain.swift
added a script/postgres script that runs an ephemeral Postgres instance and exposes it on localhost on 5432 – useful if you don't have Postgres.app, like me, and want to run Xcode unit tests
fixed Linux errors caused by idiosyncratic Foundation importing on Linux

Notes
@johanneserhardt please harden the connect method against an instance of Postgres that is just starting up, or implement some retry logic with a timeout. I'm currently sleeping the script as a workaround until Postgres is ready, but this is something that needs to be addressed pre-production readiness
@skreutzberger a Docker-compose file could replicate the shell script with less syntax and more magic; however, since we will (I hope) be using Kubernetes to orchestrate deployment I like that this script makes explicit exactly how containers interact with each other.
This script can be run anywhere there's a Docker daemon available.

@swizzlr great stuff, I just added some comments to make it more readable in terms of Sourcery. Also please change the scripts folder from script to scripts because it contains multiple scripts and also add the suffix .sh to all shell scripts (test -> test.sh, generate -> generate.sh) for better syntax highlighting in editors and a generally better understanding of what this file is about.

@skreutzberger merge at your leisure


Buffer raw

This resolves #66.
It introduces a queue in which we buffer the recorded events.  This allows the processing of the buffered events to happen later/downstream in a separate class.
Note: This does NOT yet eliminate the startup blocking that happens before connect, but is a step in that direction.  It also does not check to see if the entity guid is present before conversion.

This PR probably should have been broken down into smaller pieces. From a glance I don't see anything wrong with it though.


[Event Request] Table 37 Sales Line – Location Code - OnValidate()

Dear ALAppExtensions Team,
We would like to request the following event publisher in table 37 – Location Code - OnValidate(), ofcourse without the prefix DIN.
IF NOT "Drop Shipment" THEN BEGIN
  IF "Location Code" = '' THEN BEGIN
    IF InvtSetup.GET THEN
      "Outbound Whse. Handling Time" := InvtSetup."Outbound Whse. Handling Time";
  END ELSE
    IF Location.GET("Location Code") THEN
      "Outbound Whse. Handling Time" := Location."Outbound Whse. Handling Time";
END ELSE
  EVALUATE("Outbound Whse. Handling Time",'<0D>');
// DINNL <<
DINOnValidateLocationCodeOnAfterSetHandlingTime(Rec);
// DINNL >>
IF "Location Code" <> xRec."Location Code" THEN BEGIN

LOCAL [IntegrationEvent] DINOnValidateLocationCodeOnAfterSetHandlingTime(VAR SalesLine : Record "Sales Line")

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Recovery from missing embed files should be more graceful

Today we die in a heap.

Coded and tested.
Now issues a message, naming the missing file, and terminates.

Was fixed long ago and fix in shipped version. Closing.


elastalert AND condition in filters

My ElasticSearch Version : 6.4.0
ElastAlert : 0.1.33
I am trying to do an AND between range and term filter
filter:
- range:
    backend_status_code:
      from: 400
      to: 599
- term:
    loadbalancer: "app/appname-in/xxxxxxxxxxxxxxx"

But I am not getting any hits. If I remove the "term" filter it works. I tried the same on Kibana and I am getting hits
Is my syntax correct?

That seemed to do the trick!!! But now aggregations dont work. I want to sent an alert gruped by the elb status codes. But it stopped sending alerts. Below is my configuration
es_host: xxxxxxxxxxxxxxx
es_port: 9200
name:  Portfolio Error Response
type: frequency
index: elblogs-*
num_events: 1
timeframe:
  minutes: 60
attach_related: true
filter:
- range:
    backend_status_code:
      from: 400
      to: 599
- query_string:
     query: "loadbalancer: \"app/xxxxxxxxx/xxxxxxxxxxxxxx\""
aggregation:
  hours: 1

aggregation_key: 'backend_status_code'

summary_table_fields:
    - backend_status_code
    - request

include: ["@timestamp", "backend_status_code","request"]
slack_channel_override: "#xxxxxxxxxxxxxxxxx"
alert:

- "slack"
slack_webhook_url: "https://hooks.slack.com/services/XXXXXXXXXX/XXXXXXXXXXX/xxxxxxxxxxxxxxxxxxxxxx"

Please ignore the above comment. Had to wait for sometime and it started giving alerts


feat: improve the response time of (ebrains) features

This PR does two things to improve the loading time of feature extractor(s):

reuse feature extractor (currently, each call to atlas.get_features results the instantiation of a new feature extractor)
(for EbrainsRegionalFeature implements static method get_cache, which can be called ahead of time to further improve response time)

This should result in drastic improvement in:

calling get_feature, especially:

repeated calling get_feature on same modality
if modality is ebrainsfeatures
if modality is ebrainsfeatures, and get_cache is called prior to calling get_feature

I will paste some performance comparison in the comments

the test script is:
import time
import siibra as sb

def get_fp1_hoc1_left(atlas):
    atlas.select_region('hoc1 left')
    f1=atlas.get_features(sb.modalities.EbrainsRegionalDataset)
    atlas.select_region('fp1 left')
    f2=atlas.get_features(sb.modalities.EbrainsRegionalDataset)
    return [f1, f2]

def get_fp1_hoc1_right(atlas):
    atlas.select_region('hoc1 right')
    f1=atlas.get_features(sb.modalities.EbrainsRegionalDataset)
    atlas.select_region('fp1 right')
    f2=atlas.get_features(sb.modalities.EbrainsRegionalDataset)
    return [f1, f2]

def without_cache():
    atlas=sb.atlases.MULTILEVEL_HUMAN_ATLAS

    sb.retrieval.clear_cache()
    start_time = time.time()
    get_fp1_hoc1_left(atlas)
    print("--- without cache: %s seconds ---" % (time.time() - start_time))

    start_time=time.time()
    get_fp1_hoc1_right(atlas)
    print("--- without cache again: %s seconds ---" % (time.time() - start_time))

def with_cache():

    atlas=sb.atlases.MULTILEVEL_HUMAN_ATLAS
    sb.retrieval.clear_cache()
    start_time_0 = time.time()
    EbrainsRegionalFeatureCls=sb.features.classes[sb.modalities.EbrainsRegionalDataset]
    EbrainsRegionalFeatureCls.get_cache()

    start_time = time.time()
    get_fp1_hoc1_left(atlas)
    print("--- cache0: %s seconds ---" % (time.time() - start_time_0))
    print("--- cache1: %s seconds ---" % (time.time() - start_time))

    start_time=time.time()
    get_fp1_hoc1_right(atlas)
    print("--- with cache again: %s seconds ---" % (time.time() - start_time))

output is:
# current HEAD at 9404f126329e036cb9be7f740af7472ee6c2ac22
--- without cache: 34.37005639076233 seconds ---
--- without cache again: 22.192644596099854 seconds ---

# this PR
--- without cache: 26.56493639945984 seconds ---
--- without cache again: 0.018674135208129883 seconds ---

--- cache0: 23.2584171295166 seconds ---
--- cache1: 21.28674578666687 seconds ---
--- with cache again: 0.015386581420898438 seconds ---

Perf update:
--- cache0: 2.651280403137207 seconds ---
--- cache1: 0.11670804023742676 seconds ---

--- with cache again: 0.014444589614868164 seconds ---

list comprehension is truly a magical gift.

One more update:
# nb the preheat caches **ALL** available parcellations
# they can be preheated separately to reduce the preheat
--- preheat-1:<PHONE_NUMBER>503479 seconds ---
--- preheat0:<PHONE_NUMBER>184448 seconds ---
--- preheat1: 0.11191296577453613 seconds ---
--- with preheat again: 0.011079072952270508 seconds ---

some more update on the performance:
--- preheat-1:<PHONE_NUMBER>414795 seconds ---
--- preheat0:<PHONE_NUMBER>414917 seconds ---
--- preheat1: 0.12659120559692383 seconds ---
--- with preheat again: 0.01661086082458496 seconds ---

I am not sure if I fully understood the logic, will this affect the way that atlas objects are used to query data? Did you run/update the example notebook for fetching regional data?

I am not sure if I fully understood the logic, will this affect the way that atlas objects are used to query data? Did you run/update the example notebook for fetching regional data?

The change in principle is a drop-in replacement. As far as the examples in ipynb, none are directly affected.
The issue, at least at HEAD at develop, is that on each atlas.get_features call, a new extractor is instantiated. For EbrainsRegionalDataset, this means:

new network call to KG (can be cached)
A large number of atlas.selected_parcellation.decode_region calls (which is the slowest part by far)
instantiate a large number of EbrainsRegionalDataset

Maybe I can take a look at the issue again and come up with a more elegant solution.
There were a lot of misconception I had when I started working on this issue.

superceded by #64


Problem with a link

Tried to send this link to Lupin - https://editorial.rottentomatoes.com/article/new-on-netflix-in-march-2021/ and Lupin errored.
No error handlers are registered, logging exception.
Traceback (most recent call last):
File "/home/ec2-user/.local/lib/python3.7/site-packages/telegram/ext/dispatcher.py", line 442, in process_update
handler.handle_update(update, self, check, context)
File "/home/ec2-user/.local/lib/python3.7/site-packages/telegram/ext/handler.py", line 160, in handle_update
return self.callback(update, context)
File "main.py", line 37, in addEntry
updateJournal(update.message.text)
File "/home/ec2-user/Lupin/git.py", line 40, in updateJournal
entry = buildJournalEntry(entry, ignoreURL)
File "/home/ec2-user/Lupin/git.py", line 96, in buildJournalEntry
journalEntry = journalEntry.replace(journalEntryURL, '#' + config.BookmarkTag + ' [' + title + '](' + journalEntryURL + ')')
TypeError: can only concatenate str (not "Exception") to str

the guys decided to include "<<" in the title 🤣 messed up my regex

fixed with latest commit, requires BeautifulSoup4 to be installed


Minor changes to the internal implementation of TimedTelemetryEvent.

I will merge this into the v3 branch once it's completed!


Making Script Input URL?

Who could please help me scripting a url input that only needs the below components?

Web page
Creativework
Organization
Person

So I would like to have a script that I can use in my own website and fill in the results according to my own idea with font and color.
Who would like to help me with that?

There are other forums for working with schema.org. This site specifically is for validating data using schema.org, as well as other vocabularies.


Fix a broken markdown link in node.md

Not the biggest PR, but I like to help out where I can :)
It looked like the link for WebpackOptionsDefaulter was chopped in half to keep to a line length of 80, but markdown doesn't preserve links across new lines. I couldn't find a line length policy on the website or this repo, but since the line below it goes to 102 characters, I'm assuming you're willing to make an exception for links.  This brings line 77 up to 106 characters, but it's still safely below 120.

Thanks!


missing 2.0.0 tag

Same as https://github.com/dalek-cryptography/ed25519-dalek/issues/314

Didn't see this repo was marked as archived.


What’s the output of ph -DD config?

hello, I have an issue after installation
    What’s the output of `ph -DD config`?

Originally posted by @ebaauw in https://github.com/ebaauw/homebridge-hue/issues/1125#issuecomment-1339728886
My result is:
pi@raspberrypi:~ $ ph -DD config
ph: localhost: request 1: GET /config
ph: localhost: request 1: GET http://localhost/api/config
ph: localhost: request 1: GET /config
ph: warning: localhost: request 1: connect ECONNREFUSED <IP_ADDRESS>:80
ph: error: localhost: not a Hue bridge nor deCONZ gateway
<IP_ADDRESS>:80 is not the correct address ...
mine is <IP_ADDRESS>:8081
is it possible to change it ?
thanks
Jonas

after run:
sudo ph -H <IP_ADDRESS>:8081 discover
fix the issue
sorry/thanks :)


Revert sev crate update

Revert sev crate update
Since coco/attestation-service has pinned the crate to "1.1.0" we keep running into build problems in KBS projects. We can shelf the 1.2.0 adjustments for the time being, until the coco projects updates to a more recent version of the sev crate.
How to use
n/a
Testing done
Successfully built kbs with bundled attestion-service, dependency pointing to a fork that uses this branch.

As discussed, I would update other consumers in coco instead, and only do the openssl un-vendoring.
https://github.com/confidential-containers/guest-components/pull/179
https://github.com/confidential-containers/attestation-service/pull/116

I'll close this one and open #29


Tool tips on the progress indicator have bugs

Tool tips on progress indicator have a few issues.
What package(s) are you using?

[x ] carbon-components
[x ] carbon-components-react

Detailed description

When you hover over progress step the tooltip flashes continuously
The placement of the tooltip is right over the step making it impossible to see or click
When you wrap the progress indicator in a tool tip it swallows the onClick and onChange event and doesn't allow for the step to progress. Seen in both the carbon react storybook's interactive example and in our own storybook that uses the progress indicator.

It is related to the progress indicator component

Expected tooltip to flash once on hover and stay visible until i moved my mouse away
Expect to be able to progress the steps

Chrome
Current. This bug is visible in the carbon design system website and storybook
Steps to reproduce the issue

Go to the progress indicator tab in the Carbon design system website

Hover at the bottom of a progress step

See flashing

Go to the interactive example of the progress indicator and try to progress the steps.
Only the first one will register the onchange. The third one with the tooltip will not.

Additional information

Thanks @asudoh for the response.

Is there a way to pass the onClick to the tooltip element? currently if you try to render a carbon tooltip as the progress step it will stop bubbling and you will not be able to change step by clicking the label. Is this correct? Thanks for your time.

When I go to http://react.carbondesignsystem.com/?path=/story/progressindicator--interactive, select <div class="bx--tooltip__label bx--progress-label"> in DOM inspector, put $0.addEventListener('click', event => { console.log('Event:', event); }) in Console tab, and then click on the 3rd progress step item, I see an event sure is fired. That said, do you want to create a React component that wraps the interactive tooltip, and attach the event listener in DOM level at its cDM?

The tool tip fires an onClick but if I try to wrap the tooltip and attach an onClick to the wrapped element the tooltip element calls stopPropagation() on the event which will prevent my onClick from firing.
I was just trying to verify if there was a way that I was missing that would allow me to pass onClicks without attaching listeners on the DOM level.
Thanks again for the quick reply.


scripts/ext/stringdecomposer/longreads_decomposer.py is not found

Hello,
I'd like to try to run cen6 pipeline but it doesn't work because scripts/ext/stringdecomposer/longreads_decomposer.py is not included in ext folder in the current master HEAD(a1a314d). How should I handle this?
Thanks in advance.

Hello,
Thank you for your interest in centroFlye and reporting this error. String Decomposer was not included as a submodule - it is fixed now. I also slightly updated the readme and run_all_cen6.sh. Please let me know if there are any other issues.
Large updates of centroFlye are coming. Stay tuned!

Thank you for your quick response. I look forward to seeing the new update!


Adding EDI Support for Linguist

inital support for generic .edi files, with alias support for X12/EDIFACT standards

Description

EDI is a data format used by the supply chain and healthcare industries. Support for such files is not available on GitHub.
EDI messages are specified by standards bodies like X12.org or the U.N (EDIFACT)

Note, X12 was subject to a Ransomware attack by in March 2020. Their website is missing information they restore their systems.

EDI consists of text data, and the text is restricted to using specific ASCII characters. A basic character set is defined for all exchanges, and this set may be extended with additional characters by mutual agreement of the trading partners. I have included the basic set of specified characters in the including tmlanguage file in a separate repository

Informative References
General Outline of EDI Messages
Documentation on X12 Messsage parser

Checklist:

[x] I am adding a new language.

[x] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

https://github.com/search?q=extension%3Aedi+edi+NOT+nothack&type=Code
https://github.com/search?q=extension%3Aedi+edifact+NOT+nothack&type=Code
https://github.com/search?q=extension%3Aedi+x12+NOT+nothack&type=Code
https://github.com/search?q=extension%3Aedi+asc+NOT+nothack&type=Code

[x] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

Linguist EDI
X12 Parser via tastypackets/x12-parser

Sample license(s):
freight-trust/linguist-edi, MPL-2.0
tastypackets/x12, MIT

[x] I have included a syntax highlighting grammar: https://github-lightshow.herokuapp.com/

grammar file

Is this ready to undraft?


[Android package] Support Communication

Problem
<what's wrong or missing, please include any applicable:

expected behavior
actual behavior
steps to reproduce
system configuration
screenshots, images, logs, etc.

Proposed Solution
<suggested fix, suggested enhancement>

Not clear on this one. Are there more details?

SW BRB: This is working great, closing.

SW BRB: This is working great, closing.