[ENH] Add FA images

builds upon @effigies last commit on DWI https://github.com/bids-standard/bids-specification/commit/1d929e587775fa09489f95c94ffc0470b76020eb -- adding the FA (since scanners generate TRACE, ADC and FA)
I'm not expert in diffusion, but seems logical thing to do

If wanting to add support for scanner-generated DWI derivatives in this way, is it worth trying up-front to cover all such derivatives, rather than doing it incrementally? In addition to ADC, TRACE, and now here FA, I've also seen exponential ADC, coloured FA, and tensor.

I agree that since we support scanner derived images, this should be all and not a subpart of them.
@Lestropie what suffix do you propose: _expADC, _colFA, _tensor?

Had a quick look at what data I could find lying around:

The exponentiated ADC I've seen at the scanner console interface, but couldn't find any exemplar data to see SeriesDescriptionExtra.
The trace-weighted image gets the SeriesDescriptionExtra of "TRACEW" rather than "TRACE". Not that there needs to be a perfect correspondence between scanner sequence code and BIDS suffices.
Having that suffix not capitalised may have been preferable for #1725 in retrospect, given that it is not an acronym.
Concerned with a possible misinterpretation in #1725. Given the suffix "_TRACEW", I always assumed that these were trace-weighted images, ie. the spherical mean intensity of each unique b-value, not the trace of the tensor. In the only data I could find at hand the image data make little sense so I can't actually distinguish between the two visually. Either way I think stronger disambiguation is warranted.
The "TRACEW" series I have at hand are 4D with two volumes. Again, unclear what's actually being encoded here as I'm not convinced the data I have at hand make sense one way or the other.
Coloured FA comes out as "*_ColFA" from the scanner; "_colFA" would be fine I think.
The "_TENSOR" series I've downloaded I can't convert to image data. I've no idea how these are encoded.
I also see from more recent sequences a "_TENSOR_B0" series, presumably the estimated signal at b=0 from the tensor fit. This is ultimately a _T2w image, just the result of derivative calculations. Hard to know how to encode this trivially given the weird provenance.

RE the difficulty in description of "scanner-generated derivatives" in #1725, something just occurred to me that evaded my mind in #1723. DICOM ImageType makes a distinction between "original" and "derived". If the long term plan is to encapsulate within "BIDS raw" myriad images that are not the direct result of image data acquisition and reconstruction but downstream calculations from such, that's the reference terminology. Could maybe try to be diligent to use specifically "scanner-derived" to disambiguate from "BIDS derivatives"? This distinction will become more important once something like BEP016 progresses, given that scanner-derived and pipeline-derived images may encode the exact same parameter yet demand different naming conventions.

@Lestropie

I did not change _TRACE, just adding things here
As I understand it, there are no expFA, TENSOR images - correct? (never seen any)
added colFA is the description ok? also changed the table/MACRO as per @effigies
I do not feel qualified about capitalized letters or not, is there a rule for that? again since I just want to add and not change the previous commit, best to keep doing the same (and maybe after do a commit just about capitalization)
note that we do make a distinction for image type, under shema/rules/files/raw for dwi we now have ScannerDerivatives

I did not change _TRACE, just adding things here

Sorry, should have more explicitly sub-divided my comments. Fully realize that this particular observation is outside the scope of this PR. But nevertheless think it's sub-optimal in #1725; and if this PR is expanded in scope to be "resolution of #1725 to how we think all DWI scanner-derived images should be handled", then given how recently #1725 was merged and the fact it's not yet part of a tag, I'm advocating to change it. Further, if there's a mismatch between what is encoded in such images and the current spec description, that needs to be resolved urgently.

As I understand it, there are no expFA, TENSOR images - correct? (never seen any)

Exponentiated ADC I think I've only seen offered on the console interface on Siemens XA, not VE. The TENSOR DICOM series I've definitely seen, I just don't know what's encoded in it; neither dcm2niix nor MRtrix3 mrconvert knew what to do with it. I might try to collect a very short protocol on XA using the product sequence and export everything offered. Ideally bids-examples should have such a dataset; and creating that in conjunction with any relevant metadata encapsulates both FA and the already merged ADC & TRACE.

if happy with current changes, can you approve the merge?

I pushed a small fix for failing tests. Note I did not include my suggested fixes above.

Also committed your changes now. I think this is good to go?

Last Friday I collected some data from which I intend to generate some exemplar data over at https://github.com/bids-standard/bids-examples. Do you want to hold off until then?

+1 to @lestropie’s comment. If the scanners tend to call it “colFA” it’s
better to leave it like that than use “DECFA”
On Mon, Jun 24, 2024 at 1:19 PM Robert Smith @.***>
wrote:

@.**** commented on this pull request.
In src/schema/objects/suffixes.yaml
https://github.com/bids-standard/bids-specification/pull/1831#discussion_r1650313452
:

@@ -42,11 +42,23 @@ DIC:
display_name: Differential interference contrast microscopy
description: |
Differential interference contrast microscopy imaging data
+colFA:

value: colFA
display_name: Colored Fractional Anisotropy image
description: |
Diffusion images reflecting the directionality of the diffusion tensor color-coded in red for
left-right oriented fibers, in blue for superior-inferior oriented fibers and green for
anterior-posterior oriented fibers.

I don't think BEP016 ever uses "DECFA" specifically. The fact that the
nature of orientation encoding across volumes is directionally-encoded
colour, and that the quantitative parameter encoded in the image is FA, are
treated very deliberately as two separate dimensions. The distinction
between scanner-generated derivatives and pipeline-generated BIDS
Derivatives nevertheless means that there doesn't actually need to be
correspondence between the two. Indeed a colour FA image generated by a
pipeline will not use this suffix, even though the information encoded
is identical.
I maybe have a slight preference for "colFA" just because it's consistent
with data being emitted by many scanners that are intended to be encoded in
this way.
—
Reply to this email directly, view it on GitHub
https://github.com/bids-standard/bids-specification/pull/1831#discussion_r1650313452,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAA46NX7LJ6MYEDXNIFGT7LZI6M6JAVCNFSM6AAAAABIFE5ZMSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMZUGU4DQNRYGA
.
You are receiving this because your review was requested.Message ID:
@.***>

fa, colfa, trace and adc updated

Added a needs implementation flag to indicate that this needs a concomitant PR to the validator. Ideally the bids-examples, as well.

#1864 was intended to supersede this PR; sorry if that wasn't explicitly stated from within this PR.

#1864 Includes expADC missing from this PR
Some differences in capitalisation (see original post in #1864)
#1864 includes fix for #1862; not technically requisite, but as stated, I would personally prefer to resolve all issues with DWI scanner-generated derivatives
#1864 includes link to proposed addition to example data; I've not yet looked at the validator

Is #1864 ready for review? Seeing it in draft, I haven't even looked at it.
@CPernet If you are happy with #1864, can you close this PR?

sure, let's use the other one - thx @Lestropie


mem_trace updates

This pull request fixes a bug with -DLEGION_TRACE_ALLOCATION and prints RSS with allocation traces.
It also updates mem_trace to dump backtrace hashes on every allocation and uses binary files to speed up writing. There is a separate mem_trace_csv utility for parsing those binary files and converting them to csv.

Can you move this over to a gitlab merge request? The tools like fine. I don't like the dependence on sys/resource.h that's naked in runtime.h because that is not portable across OS-es. In general, we should try not to do anything in Legion that is OS-specific (that is Realm's purview). It's ok if you want to guard it with a compile-time macro that users can opt into at build time if they're willing to take on the responsibility for the non-portable include.

I guess that include of sys/resource.h should be guarded by #ifdef LEGION_TRACE_ALLOCATION.
Elliott also suggested including a makefile for mem_trace so I added one as well.
I moved the pull request to gitlab.


docs: add bunx create-qwik command

What is it?

[ ] Feature / enhancement
[ ] Bug
[X] Docs / tests

Description
I've tried bunx create-qwik and bun start, it works!
so, we should add bunx create-qwik command into docs.
Use cases and why

One use case

Another use case

Checklist:

[ ] My code follows the developer guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

Personally I'm of the opinion we actually only write out npm create. That's in the base install for nodejs. If you already installed and use yarn, you know it's different command and how it's different from npm already. If you use pnpm, you know it's a different command, etc. I think this list will only continue to grow and make things more confusing for new users, so if anything I think we reduce it to just npm.


IPW resulted in wrong value

I think calculation of IPW is wrong.
This is lalonde data example (from R)
import dowhy
from dowhy.do_why import CausalModel
from rpy2.robjects import r as R
%load_ext rpy2.ipython
#%R install.packages("Matching")
%R library(Matching)
%R data(lalonde)
%R -o lalonde

model=CausalModel(
        data = lalonde,
        treatment='treat',
        outcome='re78',
        common_causes='nodegr+black+hisp+age+educ+married'.split('+'))
identified_estimand = model.identify_effect()
estimate = model.estimate_effect(identified_estimand,
        method_name="backdoor.propensity_score_weighting")
#print(estimate)
print("Causal Estimate is " + str(estimate.value))

# wrong -> Causal Estimate is<PHONE_NUMBER>57321

df = model._data
ps = df['ps']
y = df['re78']
z = df['treat']

ey1 = z*y/ps / sum(z/ps)
ey0 = (1-z)*y/(1-ps) / sum((1-z)/(1-ps))
ate = ey1.sum()-ey0.sum()
print("Causal Estimate is " + str(ate))

# correct -> Causal Estimate is 1634.9868359746906

so please check propensity_score_weighting_estimator.py
# wrong
self._data['ips_weight'] = (
    self._data[self._treatment_name] / self._data['ps'] +
    (1 - self._data[self._treatment_name]) / (1 - self._data['ps'])
)
# correct
self._data['ips_weight'] = (
    self._data[self._treatment_name] / self._data['ps'] / sum(self._data[self._treatment_name] / self._data['ps']) +
    (1 - self._data[self._treatment_name]) / (1 - self._data['ps']) / sum((1 - self._data[self._treatment_name]) / (1 - self._data['ps']))
)```

Hello Yasuhiko, Thank you very much for finding this error.  We’ll take a look and integrate a fix.  Emre
From: MIZUGUCHI Yasuhiko<EMAIL_ADDRESS>Sent: Friday, August 24, 2018 9:10 AM
To: Microsoft/dowhy<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [Microsoft/dowhy] IPW resulted in wrong value (#8)
I think calculation of IPW is wrong.
This is lalonde data example (from R)
import dowhy
from dowhy.do_why import CausalModel
#%R install.packages("Matching")
%R library(Matching)
%R data(lalonde)
%R -o lalonde
model=CausalModel(
    data = lalonde,

    treatment='treat',

    outcome='re78',

    common_causes='nodegr+black+hisp+age+educ+married'.split('+'))

identified_estimand = model.identify_effect()
estimate = model.estimate_effect(identified_estimand,
    method_name="backdoor.propensity_score_weighting")

#print(estimate)
print("Causal Estimate is " + str(estimate.value))
wrong -> Causal Estimate is<PHONE_NUMBER>57321
df = model._data
ps = df['ps']
y = df['re78']
z = df['treat']
ey1 = z*y/ps / sum(z/ps)
ey0 = (1-z)*y/(1-ps) / sum((1-z)/(1-ps))
ate = ey1.sum()-ey0.sum()
print("Causal Estimate is " + str(ate))
correct -> Causal Estimate is 1634.9868359746906
so please check propensity_score_weighting_estimator.py
wrong
self._data['ips_weight'] = (
self._data[self._treatment_name] / self._data['ps'] +

(1 - self._data[self._treatment_name]) / (1 - self._data['ps'])

)
correct
self._data['ips_weight'] = (
self._data[self._treatment_name] / self._data['ps'] / sum(self._data[self._treatment_name] / self._data['ps']) +

(1 - self._data[self._treatment_name]) / (1 - self._data['ps']) / sum((1 - self._data[self._treatment_name]) / (1 - self._data['ps']))

)```
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2Fdowhy%2Fissues%2F8&data=02|01|emrek%40microsoft.com|aedbae9a433d406138c208d609dc1367|72f988bf86f141af91ab2d7cd011db47|1|0|636707238160150488&sdata=wRpXcou4%2Bzom34IDMvtv5dfnbOIdA9i41sKhUvxmmWA%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFtH0Otv6lcMX_hoNVrPyoXJc5LOoHt9ks5uUCVlgaJpZM4WLnfB&data=02|01|emrek%40microsoft.com|aedbae9a433d406138c208d609dc1367|72f988bf86f141af91ab2d7cd011db47|1|0|636707238160150488&sdata=JDy2MG9ZjCah%2B1CebQzZ0216fdXWPX1RoiSpn4a%2Bw6Q%3D&reserved=0.

Thanks @mizuy for raising this. I went in and added normalization for the weights.
Based on your example, I also added a small Lalonde Jupyter notebook example. Feel free to extend it.


Finishing status not change using RemoteStopTransaction

Hi guys, i have a problem with status "finishing". When initialize a Remote Start Transaction and the is status is finishing not change status.
PD: EV left the parking bay and and the connector is disconnected.

For version 1.6, added new state "finishing". This state appears when transaction is finished. This state may change with "start transaction"


Roll Engine from 3a73d073c8be to faeff0a89de7 (2 revisions)

https://github.com/flutter/engine/compare/3a73d073c8be...faeff0a89de7
2020-09-25<EMAIL_ADDRESS>Roll Dart SDK from eb8e6232da02 to 13b3f2d7b6ea (3 revisions) (flutter/engine#21407)
2020-09-25<EMAIL_ADDRESS>Roll Fuchsia Linux SDK from NeYDIjo58... to BFLXvCMVi... (flutter/engine#21403)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from NeYDIjo58uDZ to BFLXvCMViJNB
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Commit queue failed; closing this roll.


runtime: Open files as binary

This ensures the bytes written are not modified, i.e. \n being replaced by \r\n on Windows.
Since the current File API only supports reading and writing raw bytes it feels like a sensible default.

Fixed :^)


Post 99 Prestige?

Would be a cool option, for those of us that are going for goals beyond 99 :)
Also having the option to tweak the exp multiplier (from 2x to 3x for example) for post 99? This one is a secondary idea/request, the other one would be better if I had to choose between them.

https://github.com/runelite/plugin-hub/pull/4590 - should address the level goal. It should be configurable now up to level 126.

Sweet, thanks! Didn't expect such a quick response from you 😄
Now I'm that much more motivated to keep on the grind! 💪

Update: Added the xp factor, so now you can configure between 2 and 100.
The factor will reset your level at goal xp - (1 / xp factor). So if you have it set to 100, you'll need 1/100th of the xp for your goal to prestige and your xp will be multiplied by 100 thereafter.
Eventually this should probably be configured per skill group (combat, non-combat, hp, prayer) but that's a future thing if someone wants it.

Sweet! Wasn't expecting for you to do both of the suggestions 😄
Configured per skill would be really cool, other than that, the plugin feels very complete and amazing


Support Python 3.11

The current pybind version is not compatible with Python 3.11. We should update pybind to v2.10.1 or higher.

Solved in https://github.com/colmap/pycolmap/commit/80d3129c215079703667cf307c452d3f32adc5c2.


Laravel mix outputs the compiled assets in wrong directory

Laravel Mix Version: 6.0.43
Node Version: v16.15.0
NPM Version: 8.5.5
OS: Windows 10

Description:
webpack.mix.js file:
const mix = require('laravel-mix');

mix.sass('resources/sass/auth.scss', 'resources/css').options({
    processCssUrls: false
});

auth.scss file:
body {
    background-color: #fff;

    a, a:hover {
        color: green;
    }
}

The output of the auth.css file should be resources/css/auth.css. Instead it's public/resources/css/auth.css.
However, the mix-manifest.json file outputs the corect path:
{
    "/resources/css/auth.css": "/resources/css/auth.css"
}

Steps To Reproduce:
Check above.

Are you using this in a Laravel project?
Is the manifest file placed in the public folder?

In Mix, all asset output paths are relative to the public path
So, if you want to place something in resources/css but still want to put other things in the public folder then you'll need to use ../resources/css as your output path. If you don't care about placing things in the public folder then you can change the public path using mix.setPublicPath('./') and I believe that will work the way you want. Though this will place the manifest in the project root and not in public

Yes (freshly install Laravel 8)
Yes

In Mix, all asset output paths are relative to the public path

Not really. If I set the output directory to /resources/css, like this:
mix.sass('resources/sass/auth.scss', '/resources/css').options({
    processCssUrls: false
});

the files get written in ./public/resources/css.

That's what I mean. It's relative to the public path because /resources/css (regardless of slash or not) is treated as public/resources/css.

It’s not just relative to the public path – it does absolutely everything, including chopping up paths and ignoring them entirely, to keep the output within the public path. Even something like css/../../resources is treated like public/resources.
This is an issue that has been reported many times here, never with an answer. It seems there is just no way to get Mix to interact with anything outside the public folder in any way, at all, ever, under any circumstances, except as an input path.
 Of course the public folder should be the default output for processed assets; but saying that nothing processed can ever be placed anywhere but in the public folder under any circumstances is beyond opinionated, it’s plain wrong.

remove mix, install webpack is the only posible solution?

@akaDJon I use either gulp, webpack or simple CLI scripts in package.json file, all depending on the project.

@akaDJon I use either gulp, webpack or simple CLI scripts in package.json file, all depending on the project.

do you have any start kit for gulp? i am really want to use one but copying assets from node_modules to public folder...this has become my main issue, i can't find a proper gulp package which can do that.
if you developed any starter-kit kind, please share.
thanks


Installation problem

I have a problem when trying to install the newest version of obsmon. I get the following error:
./install
Error in isFALSE(args$versions_file) : could not find function "isFALSE"
Calls: source ... .sourceNeededFiles -> source -> withVisible -> eval -> eval
Execution halted

This is what I have on this machine:
R --version
R version 3.4.4 (2018-03-15) -- "Someone to Lean On"
Copyright (C) 2018 The R Foundation for Statistical Computing
Platform: x86_64-pc-linux-gnu (64-bit)
Thanks in advance

Hi Roger,
This one is easy: Obsmon requires R >= 4.0.5 (see the "Installing, executing and updating" section in the docs). This function didn't exist in earlier versions of R.
The solution is to update the version of the R interpreter that you are using.


[CI] Exclude End to End Tests

Our e2e testing relies on 3rd party services which is inappropriate. This PR removes them for now. We will come up with a way to run them manually or something.

If you want, you can run them only on main branch. But excluding them is not a good option IMO

We can specify to yaml files with:
on:
  push:
    branches: [ main ]
    ```
    and
    ```
    on:
  pull_request:]
    ```

I will try and figure out how to do that without duplicating the content of the file.

Forget it. I don't know how to do this.


papirus-icon-theme: 20200801 -> 20200901

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/releases.
meta.description for papirus-icon-theme is: "Papirus icon theme"
meta.homepage for papirus-icon-theme is: "https://github.com/PapirusDevelopmentTeam/papirus-icon-theme"
meta.changelog for papirus-icon-theme is: ""
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

The tests defined in passthru.tests, if any, passed

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

directory tree listing: https://gist.github.com/e401c8c27971de36a4426ebd40ba2494

du listing: https://gist.github.com/0cf80eea8a10168e4d7bbf6848f2184c

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
papirus-icon-theme
papirus-maia-icon-theme

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/cal6pgwnl8hnnshy3njnl0jyp2cr72g6-papirus-icon-theme-20200901 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A papirus-icon-theme https://github.com/r-ryantm/nixpkgs/archive/042d09241d3e55a7c376a33613cb9ae738c6a240.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/cal6pgwnl8hnnshy3njnl0jyp2cr72g6-papirus-icon-theme-20200901
ls -la /nix/store/cal6pgwnl8hnnshy3njnl0jyp2cr72g6-papirus-icon-theme-20200901/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review 1

2 packages built:

papirus-icon-theme
papirus-maia-icon-theme

Maintainer pings
cc @romildo for testing.

@ofborg eval


Player: mark a task complete

User Story
As a [player], I would like [mark a task complete] so that [I can contribute to my team].
Detailed Description
Completing tasks is essential to making game progress. Each Player receives a list randomized from the Admins gameplay list. The goal for Player is to complete all the tasks they were issued. When all players complete all their tasks and an Imposter is still alive, the game is declared won.
Marking a task complete updates individual player status, therefore updating the entire games progress status.
Acceptance Criteria A

[ ] Given [a task has been complete], then [a single task from the player tasklist is selected]
[ ] Given [a selected task], then [start a five-second countdown counter in frontend]
[ ] Given [a mistake was made], then [tap task to deselect task in tasklist].
[ ] Given [an unselected task], then [kill the five-second countdown counter].
[ ] Given [the five-second countdown timer gets to zero], then [submit changes to the backend]
[ ] Given [submitted change], then [update Player UI (remove completed, add new)].
[ ] Given [A submitted change], then [remove completed task from UI].
[ ] Given [A submitted change], then [add a new task to the UI].

Acceptance Criteria B

[ ] Given [a task has been complete], then [a single task from the player tasklist is selected]
[ ] Given [a selected task], then [a "Submit Task" button becomes active]
[ ] Given [a mistake was made], then [tap task to deselect task in tasklist].
[ ] Given [an unselected task], then [make "Submit Task" button inactive].
[ ] Given [an active "Submit Task" button], then [tap submit to push changes to the backend]
[ ] Given [a pushed change], then [update Player UI (remove completed, add new)].
[ ] Given [A submitted change], then [remove completed task from UI].
[ ] Given [A submitted change], then [add a new task to the UI].

If we use Acceptance Criteria A, then for completing a task, we can reuse the Voting mechanism. The difference will be the list that is shown and the text on the submit button.
If we use Acceptance Criteria B, then we code a timer that manages the submission of completed tasks.


Too many actors

Need to put a limit option on the number of actors. The first 800 lines of the xml file ia actors/characters.

If you just want the main actors, don't use the fullcredits flag.


Memory leak of text & app crash on encode('png')

Discovered memory leak while drawing text and segmentation error app crash when encoding
I created minimum reproducible example repository here https://github.com/MarosPistej/napi-rs-canvas-text-mem-leak

I'm wondering if paragraph needs to have reset() called at the end? I'm not a pro at C++, so I'm just trying to understand the cause of the leak, but looking at how paragraph is created it appears to use make_unique, which from my understanding is a kind of smarter/safer alternative to new. Although, reading this SO question, it is pointed out that something created via make_unique should subsequently called reset() to free the memory. However, I noticed in the code in my first link, there's no call to reset.

I tried adding delete paragraph; to the end of the function and tried building again. I didn't notice any difference in the memory with my tests, too much memory still being used and not released. In fact I believe I was also incorrect earlier about encode not also having some kind of leak, but it could possibly be my code.


Replace the term ¨Return key¨ to ¨Enter key¨ on the Linux/Windows installed.

A detailed description of the proposed feature
That line.

The motivation for the feature
Well, I will be honest, I´ve never used a macintosh, and tho, aren´t familiar with those different keys, and names.
How the feature would be relevant to at least 90% of Homebrew users
Oh... Well, I sadly doubt that they´re 90% of Homebrew users, but since it concern the separate installer for Linux in my case, It will surely be less confusing for more than 90% of those Linux/Windows users.
What alternatives to the feature have been considered
Searching what a ¨a return key¨ was.

I use a Windows PC (almost) daily. Return key and Enter key are often used interchangeably in documentation and your keyboard will almost certainly have both keys on them.


It may as well delete column comment since it dosen't exist the comment of images

In GitLab by @luotian-github on Dec 24, 2018, 19:01
It is not permitted to input image name or image tag once you upload file

In GitLab by @liyanq528 on Nov 8, 2019, 08:02
PR #1893

In GitLab by @yhua123 on Nov 8, 2019, 08:02
open new feature for add image comment.

In GitLab by @Robin-Mao on Nov 8, 2019, 08:02
Open new issue #1910

In GitLab by @sokril on Nov 8, 2019, 08:29
closed

In GitLab by @sokril on Nov 8, 2019, 08:29
assigned to @luotian-github

In GitLab by @liyanq528 on Nov 13, 2019, 11:35
mentioned in merge request !1172


React native Picker multilingual issue

Environment
Environment:
OS: Windows 10
Node: 8.11.3
Yarn: Not Found
npm: 5.6.0
Watchman: Not Found
Xcode: N/A
Android Studio: Version  <IP_ADDRESS> AI-173.4907809
Packages: (wanted => installed)
react: 16.3.1 => 16.3.1
react-native: ^0.55.4 => 0.55.4
Description
I have react picker drop down, its data source is constant object which is multlangual.
mean its labels property change if language changes on fly, but its index (value) wich is record it it remain same.
But i found react native picker loose its last state when we switch language,
it drop previously selected value and start again from default value if i change language from English to esponial.
It should not happen, because if Index is same,picker should not care about changing labels from english to spanish, i loose pickers value if switch language in middle of form.
Reproducible Demo
This is my dropdown data source which switch label if locale changed
		var COUNTRY_RENDER = []; 		this.state.countryDropdown.map(function (item, index) { 			COUNTRY_RENDER.push({ label: (locale == "en") ? item.name : item.name_es, value: item.id }); 		});

Hi @indrsidhu, could you try to make a snack with your component? I'm not able to see from your snippet what could be going wrong here.


Names in WebID profile diagram

In our texts we mostly make use of Preference File and the predicate is also with preferenceFile. The diagram contains Preference Document. This might be confusing.
Same for Type index File(Document).

In the meeting we decided we should call them all documents and have a note in the section on the pim:preferencesFile predicate that we call it a document rather than file for consistency with the OIDC spec which uses "WebID Profile Document".
By the way, the predicate is plural "pim:preferencesFile" not "pim':preferenceFile".


NEED HELP: Action Classification low performance

Problems: Use demo to test action classification on kinetics-700 validation set but get very poor result
Experiment:

Pretrained model: https://huggingface.co/OpenGVLab/InternVideo2-Stage2_1B-224p-f4/tree/main
text candidate：use the class name of k700 dataset annotation
dataset：kinetics-700 validation set.
code：demo.ipynb

example：
input：carving ice/nTnAoTQ41Nc_000011_000021.mp4
output：
text: coloring in ~ prob: 0.0085
text: acting in play ~ prob: 0.0053
text: smashing ~ prob: 0.0043
text: cracking knuckles ~ prob: 0.0041
text: tasting food ~ prob: 0.0040

Can you try the VideoCLIP model?

Can you try the VideoCLIP model?

Do you mean InternVideo2_CLIP in InternVideo2/multi_modality/scripts/evaluation/clip/zero_shot/1B/config_k400.py  ？

Can you try the VideoCLIP model?

Do you mean abandon  internvideo2 and turn to videoclip for action recognition？Your work seems very promising.

Yes. I'm not sure whether there is a bug in the demo. But I have tested the VideoCLIP on Kinetics and it runs normally.


supposedly fixed with Casper v1.3.1

Ported this SC-API commit[0] to Snapy which supposedly fixes the login
issues. I personally however am still getting the following error:
"Oh no! Your login temporarily failed, so please try again later. If
your login continues to fail, please visit
https://support.snapchat.com/a/failed-login :)"
Some people on the Casper Facebook thread[1] are saying they are still
experiencing this error as well, so I'm not sure if I made a mistake
porting the SC-API commit or if the fault is on Casper's side.
[0] https://github.com/mgp25/SC-API/commit/b6576561ca2ae40ac5b72ac33c5339de65815780
[1] https://www.facebook.com/casper4snapchat/posts/1614555802144008

Haha, better luck next time @Chiggins :laughing:
Let me know if you try running it.

Yup same here @Chiggins hahaha. Tried running it though and got the same error.

Just tried signing in with https://github.com/mgp25/SC-API and it worked, so something must be wrong with my code.

Got the attestation working, apparently the apk_digest key was wrong. However, it is still returning the login error.

nope i just hadn't installed it :laughing: . It's working now!

Hmm, I'm still getting  getting the same Attestation droidguard HTTP status code != 200 / Oh no! Your login temporarily failed, so please try again later. If your login continues to fail, please visit https://support.snapchat.com/a/failed-login :) error.

Yup just made a commit that fixed it like 2 mins ago, make sure you have the latest version installed.

Ah all good now, thanks for all your work with Snapy!

No problem :smile:, also just realized it seems to not work sometimes i have no idea why though.

https://github.com/mgp25/SC-API/commit/b6576561ca2ae40ac5b72ac33c5339de65815780

note: may take a few times to login successfully

Might be a good idea for Snapy to try logging in three times before returning an error.

Yeah i'll try implementing that.


Consider migration towards PAPI

As PAPI succeeds PJS libraries, consider migration towards PAPI.
This needs to be done carefully as many projects, that implement us currently also use PJS.

Hi there, papi is the way to go for future Dapps IMHO. I wouldn't build anything on polkadot-js/api today if I had to start a new app. I'd be interested in an xcm tool for papi if it was available. Thanks

Hello @Tbaut , we are happy to inform you, that we are migrating to PAPI this month. It is second task in Pipeline so expect this issue to be resolved soon 🙂!
With kind regards,
Team ParaSpell✨

@Tbaut , happy to inform you, that the full support for PAPI has just rolled out, we will update documentation today by EOD and package should be released within 2 days.
How will it work:
You install ParaSpell XCM SDK into your project
✨ You install package you wish to have (Either PJS or PAPI)
✅ XCM SDK automatically uses either PAPI or PJS (Whichever installed)
✅Functions are 1:1 so existing projects can switch just by reinstalling package from PJS to PAPI.
See commit: https://github.com/paraspell/xcm-tools/commit/b3a1e72f11d13b7f43f077bb2f68cb27903cc7cc

This is very very good, and also a very good timing.. because I need to do some XCM calls in Multix, that I'm almost done migrating to papi.. and this will allow me to test paraspell xcm tool!

@Tbaut , feel free to contact me through telegram via "Dudo50" and I can assemble group ParaSpell<>Multix, and we can help you with the implementation or in case any issue arises.
With kind regards,
Dudo


Catch 5813 and avoid crash

Pull Request Description
Avoid crashing when bug #5813 occurs.
Important Notes
I have profiled this, and found that validating the HTML takes 0.5% as much time as generating it.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:

[ ] ~The documentation has been updated, if necessary.~
[ ] ~Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.~
[x] All code follows the
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
All code has been tested:

[ ] ~Unit tests have been written where possible.~
[x] If GUI codebase was changed, the GUI was tested when built using ./run ide build.

CI seems blocked on #6583


Renamed project to matomo-java-tracker

Hi @tholu @bcsorba - I've thought i'd go ahead and just renamed the project to matomo-java-tracker - the old url automatically redirects: https://github.com/matomo-org/piwik-java-tracker
Let me know if there's any problem or question.
also @tholu could you reach out at<EMAIL_ADDRESS>or share your email address with us somehow? i wanted to share an info. Thanks

@mattab Just sent you an email, thanks for renaming, will clean up the references in README.


new URI for prod: https://api-0.core.keybaseapi.com

tested locally, should work

The new load balancer is up serving this URI, so we should be g2g here.


Add ability for ember-document-title to use ember-wormhole as a dependent addon

And adding examples that apply to elements in the <head> of the documents.
The x-favicon example is a nudge at what apps like TravisCI does, and the document-title example is a simplistic version ripped from that addon I develop.
:3

I think the insertBefore function should be moved into the example document-title component as it is not used anywhere else

@raycohen the idea here is to isolate the nastiness of wormhole logic into a single source. Otherwise, there isn't much reason for me to use this addon.

If wanted, I could extract out the tests that handle inserting things into <head> and remove the rest of the changes.

rad

@krisselden would love your feedback here, especially vis a vis the refactor to public API that we discussed.

I think this can be superseded by #7

I'll extract the tests

Excellent @tim-evans. We should be landing #7 by EOD tomorrow. Adding tests and docs for these use cases would be awesome.

@tim-evans We just merged the public api branch. Can you rebase?

@lukemelia I rebased, but there's now a failing test. Hmm...

@lukemelia I believe that these test failures are valid. The bound favicon value doesn't seem to update.

@tim-evans I just pulled your fork and verified that ember-wormhole is working for both the title and the favicon. I got the tests passing with the comments above.
When you have a moment, can you make the changes and rebase? Then we should be green and good to merge.
Thanks.

@chrislopresto What is it about those changes that address the test failures?

@lukemelia on it!

My fault... The test suite is passing for me approximately 50% of the time... therefore failing approximately 50% of the time. Haven't dug into what's going on.

@tim-evans @lukemelia I tracked down the issue. The x-favicon template contents violated some assumptions in wormhole's node range management logic (assumed presence of text node range endpoints).
The https://github.com/yapplabs/ember-wormhole/tree/range-safely branch has a safer range setup that supports the favicon component as written. It's green on travis: https://travis-ci.org/yapplabs/ember-wormhole/builds/62882000
@krisselden When you have a moment, could you chime in on whether we should take this approach?
https://github.com/yapplabs/ember-wormhole/compare/range-safely?expand=1

these tests should be checked again since PR https://github.com/yapplabs/ember-wormhole/pull/15

Rebased, and all looks ok!


Kubernetes dashboard is no-longer showing when running kubectl cluster-info

Hi all,
The kubernetes dashboard is no-longer showing when I run the kubectl cluster-info command and I am having trouble accessing it in other ways, perhaps something is wrong with the pod or recent charm changes.
Cheers,

Calvin

@CalvinHartwell You didn't provide any details about your setup. Can you paste your bundle or output of juju status or something?

Hi Tim,
Same bundle as per: https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/660. Either the broken one or none broken bundle in this thread.
Also: https://github.com/juju-solutions/bundle-canonical-kubernetes/issues/663 looks related.
Cheers

The dashboard no longer appears in cluster info because we stopped applying the "kubernetes.io/cluster-service=true" label to its service (https://github.com/juju-solutions/cdk-addons/commit/1ffe0d66a6c65a2ed561be6abfcf167eb7208670#diff-ff9fd45b5036390f6c3de1ad87b0cdacL80).
Normally kubernetes-dashboard does not appear in cluster-info but is available as described here: https://kubernetes.io/docs/tasks/access-application-cluster/web-ui-dashboard/#accessing-the-dashboard-ui
Unless this (kubernetes-dashboard not appearing in cluster-info) is really a problem, we would like to align with upstream and not label kubernetes-dashboard as a "kubernetes.io/cluster-service".

The dashboard no longer appears in cluster info because we stopped applying the "kubernetes.io/cluster-service=true" label to its service (juju-solutions/cdk-addons@1ffe0d6#diff-ff9fd45b5036390f6c3de1ad87b0cdacL80).
Normally kubernetes-dashboard does not appear in cluster-info but is available as described here: https://kubernetes.io/docs/tasks/access-application-cluster/web-ui-dashboard/#accessing-the-dashboard-ui
Unless this (kubernetes-dashboard not appearing in cluster-info) is really a problem, we would like to align with upstream and not label kubernetes-dashboard as a "kubernetes.io/cluster-service".

OK - good to know, this change must have been recently, but I used to see this when the dashboard was not working properly.


OWASP: Add third party script/link to SRI (Subresource integrity) - Low

URL: https://campd-stg.app.cloud.gov/
Risk: In case the third-party server is compromised, the content/behavior of the site will change
Causes: SRI (Subresource Integrity) not supported
Fix: Add to each third-party script/link element support to SRI(Subresource Integrity).

legacy issue, no longer valid.


Compilation errors

Godot version:
4.0.dev
OS/device including version:
intel 2600k arch linux
Issue description:
Can't compile with gcc 9.3.0.
[Initial build] Compiling ==> thirdparty/assimp/code/Common/ImporterRegistry.cpp
[Initial build] Compiling ==> thirdparty/assimp/code/Common/PostStepRegistry.cpp
modules/basis_universal/register_types.cpp: In function 'Vector<unsigned char> basis_universal_packer(const Ref<Image>&, Image::UsedChannels)':
modules/basis_universal/register_types.cpp:145:10: error: 'decompress_format' may be used uninitialized in this function [-Werror=maybe-uninitialized]
  145 |    *decf = decompress_format;
      |    ~~~~~~^~~~~~~~~~~~~~~~~~~
[Initial build] Compiling ==> thirdparty/assimp/code/Common/RemoveComments.cpp
cc1plus: all warnings being treated as errors
scons: *** [modules/basis_universal/register_types.linuxbsd.opt.tools.64.o] Error 1
scons: building terminated because of errors.

4.0.dev

Please give the exact commit hash.

The commit hash is: 047cdea7fa
The build command is:
scons platform=linuxbsd target=release_debug -j9.
I am using the godot-git aur.


Showcase Submission for challenges/154-tic-tac-toe-minimax

Thank you Onono Ivan for your contribution! A member of the Coding Train team will review it shortly.

TIC TAC TOE MINIMAX
Onono Ivan

Great work!


Added a code to accordion

https://user-images.githubusercontent.com/87171452/144737171-c0929e8a-f709-4919-a8c1-090e6561a974.mp4

@Palaksharma23 as I can see in the video there is only some random words are written, it would be better if u write some quotes or something meaningful.

Okay sure sir @NOiR-07

Done sir :)

@Palaksharma23 great 👍
From next time i would suggest you to use external CSS instead of inline or internal, as this is followed by most of the projects in this repository


[WFLY-4839] If the metadata-complete attribute is not specified, it m…

…ust examine the class files of the application for annotations, and scan for web fragments.
https://issues.jboss.org/browse/WFLY-4839
apply patch provided by Masafumi Miura

Linux with security manager Build 1711 is now running using a merge of 1c138974c5bbfae08d53762ebf06d6c520c23cd0

Linux Build 6813 is now running using a merge of 1c138974c5bbfae08d53762ebf06d6c520c23cd0

Windows Build 1888 is now running using a merge of 1c138974c5bbfae08d53762ebf06d6c520c23cd0

Linux with security manager Build 1711 outcome was SUCCESS using a merge of 1c138974c5bbfae08d53762ebf06d6c520c23cd0
Summary: Tests passed: 855, ignored: 322 Build time: 0:06:13

Windows Build 1888 outcome was SUCCESS using a merge of 1c138974c5bbfae08d53762ebf06d6c520c23cd0
Summary: Tests passed: 2875, ignored: 392 Build time: 0:48:21

Linux Build 6813 outcome was FAILURE using a merge of 1c138974c5bbfae08d53762ebf06d6c520c23cd0
Summary: Tests failed: 4 (4 new), passed: 2869, ignored: 392, muted: 2 Build time: 0:50:08
Build problems:
Failed tests detected
Failed tests
org.jboss.as.test.integration.ejb.remote.suspend.EjbRemoteSuspendTestCase.testSuspendedCallRejected: <no details avaliable>

org.jboss.as.test.integration.ws.wsse.signencrypt.EJBSignEncryptTestCase.encryptedAndSignedRequest: <no details avaliable>

org.jboss.as.test.integration.ws.wsse.signencrypt.SignEncryptMultipleClientsTestCase.encryptedAndSignedRequestFromJohn: <no details avaliable>

org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase(SYNC-tcp).testStatefulFailover: <no details avaliable>

Looks fine to me, and the argument on the JIRA for why the change must be made looks solid, but I added ee-review in case the folks who work more closely with the ee impl want to have a look.

Linux with security manager Build 1795 is now running using a merge of cba9473dbc6bc28a6e30b0c108ea1dd819fd36ef

Linux Build 6898 is now running using a merge of cba9473dbc6bc28a6e30b0c108ea1dd819fd36ef

Windows Build 1973 is now running using a merge of cba9473dbc6bc28a6e30b0c108ea1dd819fd36ef

Linux with security manager Build 1795 outcome was SUCCESS using a merge of cba9473dbc6bc28a6e30b0c108ea1dd819fd36ef
Summary: Tests passed: 864, ignored: 311 Build time: 0:05:49

Windows Build 1973 outcome was SUCCESS using a merge of cba9473dbc6bc28a6e30b0c108ea1dd819fd36ef
Summary: Tests passed: 2933, ignored: 367 Build time: 0:49:40

Linux Build 6898 outcome was FAILURE using a merge of cba9473dbc6bc28a6e30b0c108ea1dd819fd36ef
Summary: Tests failed: 98 (97 new), passed: 2756, ignored: 365, muted: 3 Build time: 0:58:03
Build problems:
Failed tests detected
Process exited with code 1
Failed tests
org.jboss.as.test.integration.messaging.mgmt.JMSTopicManagementTestCase.removeJMSTopicRemovesAllMessages: <no details avaliable>

org.jboss.as.test.integration.ejb.timerservice.database.DatabasePersistentIntervalTimerManagementTestCase.testResourceExistence: <no details avaliable>

org.jboss.as.test.integration.management.deploy.runtime.StatefulEJBRemoteHomeRuntimeNameTestCase.testStatefulLocalHome: <no details avaliable>

org.jboss.as.test.clustering.single.provider.ServiceProviderRegistrationTestCase: org.jboss.as.test.clustering.single.web.SimpleWebTestCase: <no details avaliable>

org.jboss.as.test.clustering.single.provider.ServiceProviderRegistrationTestCase: org.jboss.as.test.clustering.single.registry.RegistryTestCase: <no details avaliable>

org.jboss.as.test.clustering.single.provider.ServiceProviderRegistrationTestCase: org.jboss.as.test.clustering.single.dispatcher.CommandDispatcherTestCase: <no details avaliable>

org.jboss.as.test.clustering.single.provider.ServiceProviderRegistrationTestCase: org.jboss.as.test.clustering.single.singleton.SingletonServiceTestCase: <no details avaliable>

org.jboss.as.test.clustering.single.provider.ServiceProviderRegistrationTestCase: <no details avaliable>

org.jboss.as.test.clustering.messaging.ClusteredMessagingTestCase.testClusteredQueue: <no details avaliable>

org.jboss.as.test.clustering.messaging.ClusteredMessagingTestCase.testClusteredTopic: <no details avaliable>

org.jboss.as.test.clustering.xsite.XSiteSimpleTestCase.testPutToBackupNotRelayed: <no details avaliable>

##### there are 88 more failed tests, see build details

retest this please

Linux Build 6899 is now running using a merge of cba9473dbc6bc28a6e30b0c108ea1dd819fd36ef

Windows Build 1974 is now running using a merge of cba9473dbc6bc28a6e30b0c108ea1dd819fd36ef

Linux with security manager Build 1796 is now running using a merge of cba9473dbc6bc28a6e30b0c108ea1dd819fd36ef

Linux with security manager Build 1796 outcome was SUCCESS using a merge of cba9473dbc6bc28a6e30b0c108ea1dd819fd36ef
Summary: Tests passed: 864, ignored: 311 Build time: 0:05:47

Linux Build 6899 outcome was SUCCESS using a merge of cba9473dbc6bc28a6e30b0c108ea1dd819fd36ef
Summary: Tests passed: 2932, ignored: 367, muted: 1 Build time: 0:47:28

Windows Build 1974 outcome was SUCCESS using a merge of cba9473dbc6bc28a6e30b0c108ea1dd819fd36ef
Summary: Tests passed: 2933, ignored: 367 Build time: 0:48:17

Windows Build 2126 is now running using a merge of 74705fd9ab323e73397b858ce07b9e1d16aee8cb

Linux with security manager Build 1947 is now running using a merge of 74705fd9ab323e73397b858ce07b9e1d16aee8cb

Linux Build 7072 is now running using a merge of 74705fd9ab323e73397b858ce07b9e1d16aee8cb

Linux with security manager Build 1947 outcome was SUCCESS using a merge of 74705fd9ab323e73397b858ce07b9e1d16aee8cb
Summary: Tests passed: 877, ignored: 284 Build time: 0:06:21

Linux Build 7072 outcome was SUCCESS using a merge of 74705fd9ab323e73397b858ce07b9e1d16aee8cb
Summary: Tests passed: 2937, ignored: 354 Build time: 0:47:30

Windows Build 2126 outcome was SUCCESS using a merge of 74705fd9ab323e73397b858ce07b9e1d16aee8cb
Summary: Tests passed: 2935, ignored: 354, muted: 2 Build time: 0:48:08


CDPS-105: CSS updates

Oh you could do this via importing the design system margin numbers if they need to be responsive and change - but given that's a small number I dont think it matters too much


API to be closed down

Need to lock down API except for coderdojo.com and changex.org (changeX need to be able to access this particular API endpoint: http://zentest.coderdojo.com:8000/api/1.0/dojos)

Is it possible to get public api access to the endpoints which do not require authentication (endpoints handled with "actHandler", not "actHandlerNeedsUser" etc.)? Currently this is not possible due to CORS.
We are especially interested in the https://zen.coderdojo.com/api/2.0/events/search endpoint to automatically keep the list of the upcoming Dojos updated. This would make things a lot easier as we manage our Dojos registration solely through the Zen platform.
I don't see a security flaw coming up if access is only provided to the APIs requiring no authentication but I would like to hear your comments on that.
We have an implementation in progress at coderdojoka/coderdojoka.github.io#23. This may be also an starting point for other Dojos who like to implement similiar functionality.

True, removing any CORS limitation on non-authenticated API calls could make sense. I need some insight from @DanielBrierton to validate the idea.
In the meantime, send an email to webteam{at}coderdojo.com, we're testing stuff :)


mid reuse will cause the new track state ended in Chrome

Your environment.

Version: v3 master
Browser: Chrome 84 on Ubuntu

What did you do?

With kraken.fm (https://vec.io/posts/deploy-a-group-audio-conferencing-service), A and B in the room, if A leaves and joins again, there will be no audio wave for A on B's Chrome. If A leaves and C joins, there will also no audio wave for C on B's chrome.
However, A and C's audio could be heard by B, then I inspected the MediaStreamTrack, and found its state is 'ended'.
It may be that the mid reuse causes Chrome to treat the tracks ended?
What did you expect?
What happened?
Related code flow

A Chrome publish to pion
B Chrome publish to pion
Pion publish all streams to B
A leave
Pion RemoveTrack(oldA) and publish to B
B Chrome get onmute and onended event for the old A track
A join
Pion AddTrack(newA) and publish to B
B Chrome get ontrack but readyState: "ended"

We have discussed this previously @jeremija

Hey thanks for writing this up. I'm surprised I didn't run into this in Peer Calls, although I do most of my testing in Firefox. I'll see if I can reproduce.

I'm unable to reproduce this in Peer Calls and on Kraken.fm in latest Chrome. I assume you have a different version running on Kraken.fm?
I'm curious to see if you are able to reproduce your issue here https://peercalls.com
I've been trying to run your Kraken.fm project locally for the past hour, but I couldn't get it to work and I don't have any more time. Do you think you could create a short example that reproduces your issue?

The online kraken uses an old version of pion. To test this you may try to build kraken engine and the web in your local environment.

@cedricfung i wonder if this is related to https://github.com/pion/webrtc/pull/1414?
I wasn't able to reproduce. Could you check again?

@tarrencev The issue is still there. I just update the https://github.com/MixinNetwork/kraken.fm development guide.
To reproduce it

Get the kraken server code https://github.com/MixinNetwork/kraken, modify go.mod to use the official pion master instead of my fork.
Use the default config/engine.example.toml, and modify the engine.interface to your network interface name.
go build and start the engine ./kraken -c config/engine.toml
In both Firefox and Chrome, open a room http://localhost:8000/?room=pion-master
When both of them connected to each other, there should be visualizations in both browsers.
Refresh the page in Chrome, wait about 5 seconds, the visualization in Firefox is still there.
Refresh the page in Firefox, the visualization in Chrome stops.

I can confirm v3.1.0-beta.3 has resolved the issue.


Changed board generators

Pull Request Test Coverage Report for Build 26

91 of 99 (91.92%)  changed or added relevant lines in 11 files are covered.
29 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-7.4%) to 82.083%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

repository/IngSoft2-Model/BoardGenerator.class.st
0
8
0.0%

Files with Coverage Reduction
New Missed Lines
%

repository/IngSoft2-Model/Player.class.st
3
88.89%

repository/IngSoft2-Model/GameEnded.class.st
9
0.0%

repository/IngSoft2-Model/Game.class.st
17
75.31%

Totals

Change from base Build 18:
-7.4%

Covered Lines:
197

Relevant Lines:
240

💛  - Coveralls

Pull Request Test Coverage Report for Build 26

91 of 99 (91.92%)  changed or added relevant lines in 11 files are covered.
29 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-7.4%) to 82.083%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

repository/IngSoft2-Model/BoardGenerator.class.st
0
8
0.0%

Files with Coverage Reduction
New Missed Lines
%

repository/IngSoft2-Model/Player.class.st
3
88.89%

repository/IngSoft2-Model/GameEnded.class.st
9
0.0%

repository/IngSoft2-Model/Game.class.st
17
75.31%

Totals

Change from base Build 18:
-7.4%

Covered Lines:
197

Relevant Lines:
240

💛  - Coveralls


Feature Request: Notebook integration

Hi! Can we please add integration with jupyter or other notebooks? Thanks!

Could you write a bit more details, how do you see this integration?

+1
Possible features:

Organize queries in separate, navigable and named blocks.
Integrate formatted text (Markdown is a common syntax).
Provide an outline of the notebook.
Keep query results in the notebook: this is a nice-to-have, for several reasons: SQL result sets are larger than a typical Jupyter cell output, so it might be impractical to keep them, and there might also be security issues with leaking data to source code. I would either save the results to a separate file or just skip this.

A simpler and faster alternative could be to organize the queries in XML/JSON file:

They provide hierarchical, separate and named sections.
There are existing UI components - all that is needed is integration with dbeaver plugin.
They do not interfere with the SQL: XML could be better since CDATA section does not require character escaping.
However, this does not support formatted text.

I tried to implement it - the problem is that the XML recognize the structure but does not allow executing queries while the dbeaver plugin does not have an outline view.

I think it would be good functionality, similar to what exists in Azure Data Studio.

@serge-rider
I am currently using Markdown to simulate notebooks, similar to RStudio's approach.

Write queries in plain-text files.
Write comments/ texts in comment blocks.
When a preview of the results is needed, use the "Advanced copy -> copy as Markdown" and paste it in the SQL file.
Use pandoc to generate HTML from the Markdown (there is also an Eclipse plugin to do it on the fly).
Use Markdown headers to create an outline of the file.

The only part that is not working is the outline - it seems the dbeaver's SQL editor takes over the outline extension point (despite not presenting an outline), as I couldn't get the outline to work despite getting the Markdown preview to work. Perhaps that is something that can be incorporated? Markdown's marker for headers (#{1,4}) is rarely used in SQL syntax.
It seems that all of the requirements can be satisfied using existing technologies. It won't enable plots, but these are not really in the scope of SQL anyway.


20161013 161000 expand gcode support

This PR adds some more gcode functionality to the motor driver:

Power on/off the motors so they don't over-heat
Get the current state of the homing switches (this is added to robot as well)
Set the state of the Smoothieboard's 6 Mosfets (for example controlling the magbead module)

Coverage increased (+0.2%) to 93.638% when pulling 8d0e028742ee6861a56936d010e32a06ea9be440 on 20161013-161000-expand-gcode-support into bff2a926f2f8748efb975b0bc32056d942f8c9f7 on master.

Coverage increased (+0.2%) to 93.632% when pulling bd674fcf9f8324f723c2363f43f790600ab2d2ed on 20161013-161000-expand-gcode-support into bff2a926f2f8748efb975b0bc32056d942f8c9f7 on master.

Coverage increased (+0.2%) to 93.666% when pulling 574287d6271f07dedff191e3ed272b5f183f4175 on 20161013-161000-expand-gcode-support into bff2a926f2f8748efb975b0bc32056d942f8c9f7 on master.

Coverage increased (+0.5%) to 93.943% when pulling e48251ba788107e747eaef98246e5cce08e3cfb7 on 20161013-161000-expand-gcode-support into bff2a926f2f8748efb975b0bc32056d942f8c9f7 on master.


okta type hints

As a future todo, the okta module has at least one bug, and is overly nested. does anybody actually use it?

👍

We use it -- heavily


Add trunks to sonar-release step

This PR adds trunk/.* branches to sonar-release build, which means that all trunks will be persisted as separate projects on sonar.

Codecov Report

Merging #755 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #755   +/-   ##
========================================
  Coverage    42.52%   42.52%
========================================
  Files          309      309
  Lines        12789    12789
  Branches      7155     7155
========================================
  Hits          5438     5438
  Misses         709      709
  Partials      6642     6642

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c81dd57...182366d. Read the comment docs.


[Pornhub] pornhub.com/model links are broken

Please follow the guide below

You will be asked some questions and requested to provide some information, please read them carefully and answer honestly
Put an x into all the boxes [ ] relevant to your issue (like this: [x])
Use the Preview tab to see what your issue will actually look like

Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2018.12.17. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2018.12.17

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones
[x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[ ] Question
[ ] Other

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
[debug] System config: []
[debug] User config: []
[debug] Custom config: ['--no-mtime', '--no-playlist', '--playlist-reverse', '-i', '-w', '--sleep-interval', '5', '--max-sleep-interval', '7']
[debug] Command-line args: ['-v', '--config-location', 'D:\\test\\youtube-dl-ondemand.conf', '--ffmpeg-location', 'D:\\test\\ffmpeg.exe', '--download-archive', 'D:\\test\\~youtube-dl_history.txt', '-f', 'bestvideo+bestaudio/best', '--write-thumbnail', '--external-downloader', 'D:\\test\\aria2c.exe', '--external-downloader-args', '--file-allocation=none -x 4 -k 1M', '-o', 'D:\\test\\%(upload_date)s %(title)s_%(id)s.%(ext)s', 'https://www.pornhub.com/model/aften-opal/videos/upload']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2018.12.17
[debug] Python version 3.4.4 (CPython) - Windows-8.1-6.3.9600
[debug] exe versions: ffmpeg N-90960-gbcff983dc3, ffprobe N-90960-gbcff983dc3
[debug] Proxy map: {}
[PornHubUserVideos] aften-opal: Downloading page 1
[PornHubUserVideos] aften-opal: Downloading page 2
[PornHubUserVideos] aften-opal: Downloading page 3
[PornHubUserVideos] aften-opal: Downloading page 4
[PornHubUserVideos] aften-opal: Downloading page 5
[PornHubUserVideos] aften-opal: Downloading page 6
[PornHubUserVideos] aften-opal: Downloading page 7
[PornHubUserVideos] aften-opal: Downloading page 8
[PornHubUserVideos] aften-opal: Downloading page 9
[PornHubUserVideos] aften-opal: Downloading page 10
....
[PornHubUserVideos] aften-opal: Downloading page 90
[PornHubUserVideos] aften-opal: Downloading page 91
[PornHubUserVideos] aften-opal: Downloading page 92
[PornHubUserVideos] aften-opal: Downloading page 93
[PornHubUserVideos] aften-opal: Downloading page 94
[PornHubUserVideos] aften-opal: Downloading page 95
[PornHubUserVideos] aften-opal: Downloading page 96
[PornHubUserVideos] aften-opal: Downloading page 97
[PornHubUserVideos] aften-opal: Downloading page 98
[PornHubUserVideos] aften-opal: Downloading page 99

Description of your issue, suggested solution and other information
Passing a pornhub model link (https://www.pornhub.com/model/aften-opal/videos/upload) results in a neverending loop of trying to download pages to build the video list. The linked model only has 2 videos, so the list should never go past page 1.
This broke sometime between 12/17 and 12/18. I ran a script on 12/17 which completed fine and ran one on 12/18 that resulted in the loop for any pornhub.com/model link. I was updated to version 2018.12.17 before the script ran on 12/17 so I think something on the site has changed.

Hi, can you let me know what this is a duplicate of so I can follow that? I didn't see any issues opened in the last couple of days about this. There are some older issues but I didn't think they were relevant to this.


SNOW-850962: Add CBRT function to API

What is the current behavior?
In the current state, Snowpark does not have native support for the CBRT function that is currently available as a built-in function in Snowflake.
What is the desired behavior?
Use cbrt as a native function in the Snowpark API.
How would this improve snowflake-snowpark-python?
More closely maps existing SQL functionality to that of availability in Snowflake.
References, Other Background
I believe this is the last "Exponent and Root" function as part of the numeric functions needing to be mapped.

appreciate the PR! can you also help adding some test for it as well as the change log?


CI will not fail even if the package is not found in the publish or global test

Hello. Thank you for working on this.
I have tried this via the feature template and it failed to release.
https://github.com/rocker-org/devcontainer-features/actions/runs/3117820476/jobs/5056719497
Run devcontainers/action@v1
Publishing features...
Fetching the latest @devcontainer/cli...
/usr/local/bin/devcontainer features publish -r ghcr.io -n rocker-org/devcontainer-features ./src
[2 ms] @devcontainers/cli 0.15.0. Node.js v16.17.0. linux 5.15.0-1019-azure x64.
[2 ms] Packaging feature collection...
[6 ms] Processing feature: quarto...
[15 ms] Packaged 1 features!
[16 ms] Processing feature: quarto-cli...
[16 ms] Fetching published versions...
[779 ms] Publishing versions: 0,0.1,0.1.0,latest...
[1210 ms] /tmp/features-output/devcontainer-feature-quarto-cli.tgz does not exist.
[1211 ms] Failed to calculate tgz layer.
[1211 ms] Failed to generate manifest for quarto-cli
[1211 ms] (!) ERR: Failed to publish feature: ghcr.io/rocker-org/devcontainer-features/quarto-cli
Generating documentation for features...

Am I doing something wrong?
edit: It was caused by a typo in the directory name.
Also, if publish fails, CI itself should also fail. (I was confused because CI finished successfully but I couldn't find the package anywhere)

Global test seems also fail.
https://github.com/rocker-org/devcontainer-features/actions/runs/3119019489/jobs/5058708505

cc @samruddhikhandale @joshspicer

I think this is resolved (using the devcontainers/action to publish and not the action in this repo?) Please re-open if i'm misunderstanding.


Consider adding the stats of region data size

          Yep, it only contains the manifest size, can it include the data size too?

Originally posted by @killme2008 in https://github.com/GreptimeTeam/greptimedb/pull/4070#discussion_r1619737231

We can collect the file sizes from the SstVersion
https://github.com/GreptimeTeam/greptimedb/blob/05751084e7bbfc5e646df7f51bb7c3e5cbf16d58/src/mito2/src/sst/version.rs#L87-L102


Highlighted bits are masking out the code in examples

Within many of the code examples on this page, only bits and pieces of the code is actually visible on the page within any of the bright yellow highlight boxes. It's there when looking at the page source, but the CSS appears to be hiding it (for the most part).

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b5cce372-24e2-3489-cb19-c85d934e5d3b
Version Independent ID: 9d12b19f-a94e-4df4-357b-3f3b93696eb6
Content: Test controller logic in ASP.NET Core
Content Source: aspnetcore/mvc/controllers/testing.md
Product: aspnet-core
Technology: aspnetcore-mvc
GitHub Login: @ardalis
Microsoft Alias: riande

Closing as a duplicate of https://github.com/aspnet/AspNetCore.Docs/issues/13143. Engineering is testing a fix and hopes to deploy it soon.


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/opstest2/docs-archive-test-source.git

Docs Build status updates of commit f0e1bfb:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Update prop from optional profilemenutext

Description

Added a property to give the option to have the sign out text from profile menu with any text

References #
#1603
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update

How Has This Been Tested?

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

@ElishaSamPeterPrabhu Can you add two e2e tests

validate the sign-out can be changed (opens menu and checks text is changed)
validate menu opens and has default sign out text

Updated test cases


IPI on vSphere: vmtoolsd service is not started on bootstrap node

Describe the bug
On an IPI deployment on vSphere the systemd service vmtoolsd is not started on the bootstrap node.
My understanding is that the installer expect to be able to get the ip address of the node from the vcenter api and for this it needed that all the node run vmtoolsd.
Version
IPI
4.6.0-0.okd-2020-12-06-204258
How reproducible
100%
Log bundle
I'll add the log bundle as soon as possible

https://github.com/openshift/okd-machine-os/pull/36 would fix that

great thanks

i'll close this issue.

Lets keep it open for tracking (it need 4.6 cherrypick too)

Fixed in https://amd64.origin.releases.ci.openshift.org/releasestream/4.6.0-0.okd/release/4.6.0-0.okd-2020-12-08-104416 (a proper vsphere deployment still needs a few more fixes)


grpc master tests: python, dbg/opt, windows unrun in 3 months

Problem here with this test not running in a long time. Not sure why - C is running.

@vjpai, @nicolasnoble: does this test result (dbg, opt) indicate that this issue has been resolved?

Fixed.


Revert "Change grammar source for Svelte"

Reverts github/linguist#5963
This broke the syntax highlighting between <(script|style|template)> tags due to a really old limitation in the old prettylights highlighting engine which won't be fixed.
See https://github.com/github/linguist/discussions/6164 for more details.
This can be reverted back to the sveltejs/svelte-atom grammar once it has been updated to address this limitation or a production-ready tree-sitter grammar becomes available.
This PR will be merged early next week (w/c 28 Nov 2022) and a patch release made, unless the sveltejs/svelte-atom grammar is updated by then, in which case I'll pull the latest version of that grammar.
Fixes https://github.com/github/linguist/issues/6180

due to a really old limitation in the old prettylights highlighting engine

Could you elaborate on the specifics of said limitation? This is relevant because I still use Atom for writing, previewing and testing grammars, and I need to know of any discrepancies between it and GitHub/PrettyLights.

See https://github.com/github/linguist/discussions/6164#discussioncomment-4178987

The problem is it doesn't expand scope matches and instead treats the $1 in places like this literally:

Oh, that. I always assumed that was an intentional optimisation due to the rarity of meaningful scopes getting captured by a grammar. It's bitten me several times when abusing injections (most recently in language-mermaid).
(Sorry for the noise…)

Oh, that. I always assumed that was an intentional optimisation due to the rarity of meaningful scopes getting captured by a grammar.

It's certainly possible. I can't find any explanation of why this wasn't implemented other than a "Expand?" comment in the code and the author left GitHub a long time ago - I doubt they could remember why they wrote that over 8 years ago too 😁.


How do I change the version number

In the past, using https://github.com/googleapis/release-please, it was possible to customize the version number for the next release through the method mentioned in this link: https://github.com/googleapis/release-please?tab=readme-ov-file#how-do-i-change-the-version-number. Is there a way to do this currently? Or is this a feature to be added?

#how-do-i-change-the-version-number I have tried it, it can change the version number


Remove the launcher and set the locale/current directory in alacritty

This is #661 but off of a different branch in my fork, and with merge conflicts fixed. For some reason, it's working perfectly for me now.

LGTM; thanks!


SyntaxError: Cannot declare a let variable twice: 'n'.

Describe the bug
The package appears to be clashing with the global namespace…
To Reproduce
Checkout this minimal repository which is a vanilla NextJS app with the HWC package imported dynamically in a client component:
https://github.com/justynspooner/hedera-wallet-connect-test/tree/main
npm install
npm run build
npm run start

Check the console logs in the browser:

SyntaxError: Cannot declare a let variable twice: 'n'.

Expected behavior
Should be able to build a production release and have the resulting app not throw the error.
Additional context
I checked out the @hashgraph/hedera-wallet-connect repo and turned off the esbuild minification feature. I then built the package and imported that dependency directly into the project. This worked fine without any SyntaxErrors. As soon as I turn on minification, the problem occurs again.

Does anyone else have the library working with the latest NextJS 14?
Would love to see how to solve this as right now it doesn't seem to work out of the box.

Will keep the issue open for confirmation

hey @justynspooner thanks for providing the sample repo, it was really helpful to test while developing a fix. The newest version should fix this issue. please feel free to re-open the issue if something was missed. Thanks!