TagBot trigger issue

This issue is used to trigger TagBot; feel free to unsubscribe.
If you haven't already, you should update your TagBot.yml to include issue comment triggers.
Please see this post on Discourse for instructions and more details.
If you'd like for me to do this for you, comment TagBot fix on this issue.
I'll open a PR within a few hours, please be patient!

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/117693

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/117958

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/120565

Triggering TagBot for merged registry pull request: https://github.com/JuliaRegistries/General/pull/120914


Constance upload path

Describe the problem
I want to set upload path to constance images and files. How can I do it?
System configuration

Django version: 2.2
Python version: 3.6

@ghost Did you manage to find a solution?

I too would like to know if this is possible? I'm quite the django noob so I'm not sure how to approach this.

It doesn't appear to be possible at the moment, as the library is hardcoded to save the file in the root of the default storage:
https://github.com/jazzband/django-constance/blob/5de44eafb16ef2d0dceea88da295387ccb17230d/constance/admin.py#L141-L144
I'll see if I can manage to create a pull request to add this as a setting.


feat(mwc-button): support associated value

add missing value attribute as in https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#attr-value
Fixes #2766

Relates to #2759

Thanks for the PR!

Oh, and please rebase your PR to use the lit package for imports!

I purely git rebase master and it added all the commits and multiple files changes. Is it normal?

same change with cleaner commit history #2802. can close this 1


[WIP] Feature/substitution

Enables the substitution of abstract Node Templates with concrete ones inheriting from the abstract one, as well as the substitution by Service Templates.

[ ] Ensure that you followed http://eclipse.github.io/winery/dev/ToolChain#github---prepare-pull-request.
[ ] Branch name checked. That means, the branch name starts with thesis/, fix/, ...
[ ] Ensure that the commit message is a good commit message
[ ] Ensure to use auto format in all files
[ ] Ensure that you appear in NOTICE at Copyright Holders
[ ] Tests created for changes
[ ] Documentation updated (if needed)
[ ] Screenshots added (for UI changes)

Follow up eclipse/winery#356

it is merged...

Doesn't look like it was merged just closed  :octocat:

@nyuuyn the eclipse pull-request was merged. Because of the split between eclipse and OpenTOSCA's winery, pull-requests should be made against eclipse/winery. PullRequests against OpenTOSCA winery are intended as preliminary internal review targets. The changes they perform will then be merged through a separate PR against eclipse/winery, which will in turn get pulled into OpenTOSCA/winery through a simple merge.
Because eclipse pullrequests may only be a single commit, and they are based off a different commit (namely eclipse/winery@master), git (and by extension github) do not recognize they perform the same changes as the requests opened against OpenTOSCA/winery.

This issue was fixed by the linked PR eclipse/winery#356


Proposal and Code of Conduct

first draft of proposal
code of conduct formatted and changed file type

Merged, but in the future please limit to only one file change per pull request


[Autodiff] Derivative Registration for the Get and Set Accessors

This implements the support for@derivative derivative registration for the get and set accessors (https://bugs.swift.org/browse/TF-1193.). The class set accessor is not yet supported.
Done together with @dan-zheng

@swift-ci please smoke test

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - ab5bd6b627a5c27f80da99ff5c88cac03f46fbc3

Before this lands, can you be sure to re-base and clean up the git history by smooshing commits that don't stand on their own. Thanks!

@swift-ci please smoke test

@swift-ci please test

Build failed
Swift Test Linux Platform
Git Sha - ab5bd6b627a5c27f80da99ff5c88cac03f46fbc3

Build failed
Swift Test OS X Platform
Git Sha - ab5bd6b627a5c27f80da99ff5c88cac03f46fbc3

@swift-ci please smoke test

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - e7ddf70d5e1c8cb314b50a367bc1dbbd259b8e49

Build failed
Swift Test Linux Platform
Git Sha - e7ddf70d5e1c8cb314b50a367bc1dbbd259b8e49

@swift-ci please test os x platform

@swift-ci please smoke test os x platform

Nice!
@ematejska: would you like to preemptively squash commits? Or you could "Squash and merge" with a short commit description.

I'll do the Squash and merge.

When syntax definitions are changed, I believe apple/swift-syntax needs to be updated with newly generated syntax files. This is necessary to pass --swiftsyntax-verify-generated-files.
Here's an example PR. I think you can regenerate swift-syntax files locally with utils/build-script --infer --swiftsyntax.

I'll try to do this today.

Build failed
Swift Test OS X Platform
Git Sha - 16a9b17879b291dc9b201542fce417d2f7df90c6

Please test with:
https://github.com/apple/swift-syntax/pull/225
@swift-ci please test os x platform


Improve chart-api echarts bundle

Improve types import for echart
improve modular import for echart
reduce bundle size by ~30% (still 700kb!, ideas?)

vite v4.3.9 building for production...
✓ 641 modules transformed.
dist/index.html                   0.42 kB │ gzip:   0.29 kB
dist/assets/index-c0f34f63.css    0.19 kB │ gzip:   0.16 kB
dist/assets/index-17c20c83.js   722.96 kB │ gzip: 233.41 kB

(!) Some chunks are larger than 500 kBs after minification. Consider:
- Using dynamic import() to code-split the application
- Use build.rollupOptions.output.manualChunks to improve chunking: https://rollupjs.org/configuration-options/#output-manualchunks
- Adjust chunk size limit for this warning via build.chunkSizeWarningLimit.
✓ built in 5.55s

@weskamm @chrismayer @sdobbert please check.

Thanks for this @hblitza. As a first optimization this should be OK. In case we enable gzip on the web server there should be potential to save another amount, maybe we can land around 400kb with that. Still not optimal, but it goes totally in the right direction :+1:


problems about new trained model :20170216-091149

loading the models released at 20170216-091149 and 20170214-092102 , I have the error:
  File "F:\facenet_project\face_galaxy\src\facenet\src\facenet.py", line 391, in load_model
    saver = tf.train.import_meta_graph(os.path.join(model_dir_exp, meta_file))
  File "C:\Program Files\Anaconda3\lib\site-packages\tensorflow\python\training\saver.py", line 1526, in import_meta_graph
    **kwargs)
  File "C:\Program Files\Anaconda3\lib\site-packages\tensorflow\python\framework\meta_graph.py", line 502, in import_scoped_meta_graph
    producer_op_list=producer_op_list)
  File "C:\Program Files\Anaconda3\lib\site-packages\tensorflow\python\framework\importer.py", line 258, in import_graph_def
    op_def = op_dict[node.op]
KeyError: 'VariableV2'

Did I miss some bugs fixed? The other models released at 20170131 are  correct.

You may need to upgrade to the TensorFlow r1.0.

After upgrading , the bug fixed, thks~


Load local credential file

Add default credential property to SDWebImageDownloader for load local credential file.

Replaced by dcb7985


Add Model.readyPromise and Primitive.readyPromise

We should also deprecate Model.readyToRender, but I wanted to make sure @pjcozzi was okay with it first.  Having an event that only fires once are just the sort of problem promises are meant to solve.

Can we update the 3D model Sandcastle example to use this?  It will still be worthwhile even with the entity API.

We should also deprecate Model.readyToRender.

Agreed.  Given that I expect it is widely used, let's deprecate now and remove in 1.8 or 1.9.

Also, a nice short tech blog post (for JavaScript in general) may be when to use raw callbacks vs. events vs. promises.  Submit an issue to the cesium website repo if you think so.

Can we update the 3D model Sandcastle example to use this? It will still be worthwhile even with the entity API.

Sure, but the ported entity example doesn't need it since viewer.zoomTo will take care of it under the hood.

Also, a nice short tech blog post (for JavaScript in general) may be when to use raw callbacks vs. events vs. promises. Submit an issue to the cesium website repo if you think so.

Maybe, but there are already some excellent articles out there, thie one for example.  I think it would be better to just have a paragraph or two as part of a larger tutorial on the high-level architecture/idioms of Cesium.  I have a plan in my head for this, I'll write up an issue for it on the website.

Okay, this is ready. I ended up going down the :rabbit2: hole a bit and uncovered a few issues with how we handle worker exceptions as well as found out we have some untested paths in Primitive. This change ended up being bigger than expected because of that, but they are all good fixes for problems we didn't know we had.

Looks good.


Remote trigger to Temurin Compliance server should not occur when nightly testing is disabled

Expected behaviour: Weekly runs, which have testing disabled, should not initiate the TC trigger
Observed behaviour: Weekly jobs are running the TC trigger during lockdown
Any other comments: The logs currently don't show when the trigger is being executed in the logs - ideally we should add this in since it's currently happening silently which made this harder to look into
Sample log from the Windows weekly run which didn't run the AQA tests but the pipeline job did trigger TC:  - it launched https://ci.eclipse.org/temurin-compliance/job/AQA_Test_Pipeline/94
Ref: functionality introduced in https://github.com/adoptium/ci-jenkins-pipelines/commit/b5ffce4bdb5c6c2702e9639c3a559a65d418ffd7
FYI @smlambert as discussed recently
FYI @sophia-guo

This also suggests weekly-openjdk*-pipeline should be disabled if testing is disabled? My understanding is the weekly openjdk pipeline is mainly to run full set of defined tests( nightly + weekly) by running the openjdk build pipeline first. If testing is disabled should those pipelines be disabled? That means the openjdk build pipeline will not be triggered too. Currently those pipelines are triggered by timer and run the openjdk build pipeline.

Thanks @sxa @andrew-m-leonard for confirming that weekly openjdk pipelines are also regular openjdk builds for all different vendors. For non-temurin ones they are only running weekly so even if testing is disabled we'd still like to keep the pipeline running to build jdk.
In that case would it be helpful to disable weekly temurin build if testing is disabled?


Removed duplicate form in newsletter

Fixes:  #1564
Description
There are two forms in the subscribe to newsletter i have removed one of them so that the user will not confuse
Fixes:  #1564
Type of PR

[x ] Bug fix
[ ] Feature enhancement
[ ] Documentation update
[ ] Other (specify): _______________

Screenshots / videos (if applicable)
before

after

Checklist:

[ x] I have made this change from my own.
[ ] I have taken help from some online resources.
[x ] My code follows the style guidelines of this project.
[ x] I have performed a self-review of my own code.
[x ] I have commented my code, particularly in hard-to-understand areas.
[x ] I have made corresponding changes to the documentation.
[x ] My changes generate no new warnings.
[x ] I have tested the changes thoroughly before submitting this pull request.
[ x] I have provided relevant issue numbers and screenshots after making the changes.

please resolve the conflicts

please resolve the conflicts

Yes I have resolved the conflicts


mgmt, redis update default version to V6

Description
Fix https://github.com/Azure/azure-sdk-for-java/issues/31232
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:

[ ] The pull request does not introduce [breaking changes]
[ ] CHANGELOG is updated for new features, bug fixes or other significant changes.
[ ] I have read the contribution guidelines.

General Guidelines and Best Practices

[ ] Title of the pull request is clear and informative.
[ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[ ] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-resourcemanager-redis

/check-enforcer evaluate


sushy-emulator podman - restart_policy: on-failure

I sometimes see sushy-emulator failing - Exited (1). Inspecting logs it failed on binding to the listen address:
  + exec /usr/local/bin/sushy-emulator --debug --config /etc/sushy-emulator/config.conf
   * Serving Flask app 'sushy_tools.emulator.main'
   * Debug mode: on Cannot assign requested address

A podman restart solves the problem. Let's set restart_policy: on-failure to keep trying to re-start on failure.
As a pull request owner and reviewers, I checked that:

[x] Appropriate testing is done and actually running
[x] Appropriate documentation exists and/or is up-to-date:

[x] README in the role
[x] Content of the docs/source is reflecting the changes

I confirmed this solved my problem. I think the libvirt network configured with no DHCP and no DNS does not come up before a VM is attached to the network or something.
Jun 03 08:15:23 host24.beaker.tripleo.ral3.eng.rdu2.redhat.com NetworkManager[2388]: <info>  [1717416923.1924] device (ocpbm): bridge port vnet3 was attached
Jun 03 08:15:25 host24.beaker.tripleo.ral3.eng.rdu2.redhat.com kernel: ocpbm: port 1(vnet3) entered learning state
Jun 03 08:15:27 host24.beaker.tripleo.ral3.eng.rdu2.redhat.com kernel: ocpbm: port 1(vnet3) entered forwarding state
Jun 03 08:15:27 host24.beaker.tripleo.ral3.eng.rdu2.redhat.com kernel: ocpbm: topology change detected, propagating
Jun 03 08:15:27 host24.beaker.tripleo.ral3.eng.rdu2.redhat.com kernel: IPv6: ADDRCONF(NETDEV_CHANGE): ocpbm: link becomes ready
Jun 03 08:15:27 host24.beaker.tripleo.ral3.eng.rdu2.redhat.com NetworkManager[2388]: <info>  [1717416927.2472] device (ocpbm): carrier: link connected
``

CONFIG=/etc/sushy-emulator/config.conf
ARGS=
[[ -f /etc/sushy-emulator/config.conf ]]
ARGS=' --config /etc/sushy-emulator/config.conf'
[[ ! -f /etc/sushy-emulator/config.conf ]]
grep -q '^SUSHY_EMULATOR_LISTEN_IP =' /etc/sushy-emulator/config.conf
exec /usr/local/bin/sushy-emulator --debug --config /etc/sushy-emulator/config.conf

Serving Flask app 'sushy_tools.emulator.main'
Debug mode: on
Cannot assign requested address

CONFIG=/etc/sushy-emulator/config.conf
ARGS=
[[ -f /etc/sushy-emulator/config.conf ]]
ARGS=' --config /etc/sushy-emulator/config.conf'
[[ ! -f /etc/sushy-emulator/config.conf ]]
grep -q '^SUSHY_EMULATOR_LISTEN_IP =' /etc/sushy-emulator/config.conf
exec /usr/local/bin/sushy-emulator --debug --config /etc/sushy-emulator/config.conf

Serving Flask app 'sushy_tools.emulator.main'
Debug mode: on
Cannot assign requested address

CONFIG=/etc/sushy-emulator/config.conf
ARGS=
[[ -f /etc/sushy-emulator/config.conf ]]
ARGS=' --config /etc/sushy-emulator/config.conf'
[[ ! -f /etc/sushy-emulator/config.conf ]]
grep -q '^SUSHY_EMULATOR_LISTEN_IP =' /etc/sushy-emulator/config.conf
exec /usr/local/bin/sushy-emulator --debug --config /etc/sushy-emulator/config.conf

Serving Flask app 'sushy_tools.emulator.main'
Debug mode: on
Cannot assign requested address

CONFIG=/etc/sushy-emulator/config.conf
ARGS=
[[ -f /etc/sushy-emulator/config.conf ]]
ARGS=' --config /etc/sushy-emulator/config.conf'
[[ ! -f /etc/sushy-emulator/config.conf ]]
grep -q '^SUSHY_EMULATOR_LISTEN_IP =' /etc/sushy-emulator/config.conf
exec /usr/local/bin/sushy-emulator --debug --config /etc/sushy-emulator/config.conf

Serving Flask app 'sushy_tools.emulator.main'
Debug mode: on
WARNING: This is a development server. Do not use it in a production deployment. Use a production WSGI server instead.
Running on http://[fc00:1:1::1]:8000
Press CTRL+C to quit
Restarting with stat
Debugger is active!
Debugger PIN: 134-970-338

/approve


Put Options

Current dependencies on/for this PR:

main

PR #83

PR #84   👈

This comment was auto-generated by Graphite.


Corrfunc crashes the Python interpreter with malloc error

General information

Corrfunc version: 2.3.4
platform: Linux
installation method (pip/source/other?): pip or source

Issue description
Running Corrfunc from Python produces errors like:
*** Error in `python': break adjusted to free malloc space: 0x0000010000000000 ***
Fatal Python error: Aborted

and crashes the Python process.
Resolution
The underlying cause of this issue was found to be a GSL installation that was compiled with the Intel compilers, but the Python installation was built with GCC (this was at NERSC).  Switching to a GCC-compiled GSL and reinstalling Corrfunc resolved the issue.
No action needed from the Corrfunc side of things; just recording this for posterity.

Attaching a reproducer for completeness.  Unlikely to reproduce outside of NERSC, but you never know.

/* compile with (change paths for your system using python3-config):

 $ gcc -lgsl -I/global/common/cori_cle7/software/python/3.8-anaconda-2020.11/include/python3.8 -I/usr/common/software/python/3.8-anaconda-2020.11/lib/python3.8/site-packages/numpy/core/include -fPIC -shared hello.c -o hello.so

 on NERSC, with modules PrgEnv-intel/6.0.5, python/3.8-anaconda-2020.11, and gsl/2.5, get
 lgarriso@nid00165:~/abacus-analysis/AbacusSummit/hod$ python -c 'import hello'*** Error in `python': break adjusted to free malloc space: 0x0000010000000000 ***
 Fatal Python error: Aborted

 basic extension code borrowed from: https://gist.github.com/physacco/2e1b52415f3a964ad2a542a99bebed8f
*/

#define NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION

#include <Python.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <stdint.h>

/* Now, include the numpy header*/
#include "numpy/arrayobject.h"

//Docstrings for the methods
static char module_docstring[] = "hello\n";

// Module method definitions
static PyObject* hello_world(PyObject *self, PyObject *args) {
    printf("Hello, world!\n");
    Py_RETURN_NONE;
}

static PyObject* hello(PyObject *self, PyObject *args) {
    const char* name;
    if (!PyArg_ParseTuple(args, "s", &name)) {
        return NULL;
    }

    printf("Hello, %s!\n", name);
    Py_RETURN_NONE;
}

// Method definition object for this extension, these argumens mean:
// ml_name: The name of the method
// ml_meth: Function pointer to the method implementation
// ml_flags: Flags indicating special features of this method, such as
//          accepting arguments, accepting keyword arguments, being a
//          class method, or being a static method of a class.
// ml_doc:  Contents of this method's docstring
static PyMethodDef hello_methods[] = {
    {
        "hello_world", hello_world, METH_NOARGS,
        "Print 'hello world' from a method defined in a C extension."
    },
    {
        "hello", hello, METH_VARARGS,
        "Print 'hello xxx' from a method defined in a C extension."
    },
    {NULL, NULL, 0, NULL}
};

struct module_state {
    PyObject *error;
};

// Module definition
// The arguments of this structure tell Python what to call your extension,
// what it's methods are and where to look for it's method definitions
static struct PyModuleDef hello_definition = {
    PyModuleDef_HEAD_INIT,
    "hello",
    module_docstring,
    sizeof(struct module_state),
    hello_methods,
    //NULL,
    //_countpairs_traverse,
    //_countpairs_clear,
    //NULL
};

// Module initialization
// Python calls this function when importing your extension. It is important
// that this function is named PyInit_[[your_module_name]] exactly, and matches
// the name keyword argument in setup.py's setup() call.

PyObject *PyInit_hello(void) {
    //Py_Initialize();  // are we supposed to do this? doesn't seem to matter

    PyObject *module = PyModule_Create(&hello_definition);

    // comment out to avoid error
    import_array();

    return module;
}

Adding a setup.py to round out the reproducer - you can now compile the extension with python setup.py build_ext. Importing this extension did not crash on my local supercomputer...

setup.py

#!/usr/bin/env python3
# encoding: utf-8

from setuptools import setup, Extension

class get_numpy_include(object):

    def __str__(self):
        import numpy
        return numpy.get_include()

hello_module = Extension('hello', sources = ['hello.c'])

setup(name='hello',
      version='0.1.0',
      description='Hello world module written in C',
      include_dirs=[get_numpy_include()],
      ext_modules=[hello_module])

(Taken from the gist above, and this SO post)


Create copyright-designs-and-patents-act.mdx

Motivation
(Write your motivation here.)
Changes
Added file

This will be added to the Computer Science category, when it's live.


Windows Cross Compilation broken

This change https://github.com/microsoft/windows-rs/commit/198621c5588a1482eeec4077b113e80f304f2e28#diff-26e81435323b9d11b39a44aa6f5adf5b3d863e3b2b149d6c2777b925ca8694b9R53 seems to break cross-compilation from Linux. It seems the build script is run with the equivalent of cfg!(unix), not cfg!(windows).

Have you actually tried to build for Windows on Linux? I'm not sure that's ever worked. That would require libs for Windows that a Linux-based linker could use to resolve imports, not to mention a C++ compiler that can cross compile for Windows on Linux. Not saying that's not possible, but I'd be surprised if that worked before this change. Also, I would imagine this problem would eventually go away once DLL imports are implemented.

Anyway, I deal with the issue of the build script not necessarily using the target compiler by checking the CARGO_CFG_TARGET_ARCH environment variable when copying architecture-specific dependencies. We could in theory use the
CARGO_CFG_TARGET_OS environment variable in a similar way to identify the target OS if we end up supporting something like this, but I'm not sure that's going to be something we need to support.

Hmm what do you mean? We use a mingw cross compiler on Linux to build for Windows and that works fine (except for this crate). Using the winapi crate works but I thought I would give this one a try but if it is not supported for this crate then so be it :)

That works because the winapi crate generates its own lib files. The windows crate doesn't do that, but as we have folks working on DLL imports we will soon not need lib files at all.

I'll leave this open for now while noting that it is blocked on https://github.com/rust-lang/rust/issues/58713.

Cool, thanks! :)

Just wanted to continue my comments from issue #1073, I confirmed that in my particular case I was able to cross-compile a simple MessageBoxA testing project. (Compiled on Debian with mingw)
I symlinked like so:
ln -s /usr/x86_64-w64-mingw32/lib/libole32.a /usr/x86_64-w64-mingw32/lib/libOLE32.a
ln -s /usr/x86_64-w64-mingw32/lib/liboleaut32.a /usr/x86_64-w64-mingw32/lib/libOLEAUT32.a
ln -s /usr/x86_64-w64-mingw32/lib/libuser32.a /usr/x86_64-w64-mingw32/lib/libUSER32.a
ln -s /usr/x86_64-w64-mingw32/lib/libkernel32.a /usr/x86_64-w64-mingw32/lib/libKERNEL32.a
So with that working I started to look at how to work out how I could get windows-rs to work without symlinking the libraries.
I've tried  to modify a local copy of windows-rs by swapping the case in the linking macros with promising results but I'm still lacking one library (I think its USER32, I don't have access to my home computer right now). Can't really figure out where I can lower-case the library name.

Related to https://github.com/rust-lang/rust/issues/58713 and @ricobbe's work.

On my Windows SDK version 10.0.22000.0 installation it is cased as User32.Lib but again the Windows file system is not case-sensitive so I don't know that this is something you can rely on. If you want to experiment with this, you could try to lower-case the following:
https://github.com/microsoft/windows-rs/blob/21ed8f24780bf98653e738a3723c14150318a6fe/crates/gen/src/function.rs#L15

Thank you for your help! That line was indeed the one that I needed to change to get it to work:
let mut link = def.impl_map().expect("Function").scope().name().to_lowercase();
This meant that line 21 had to change to:
link = "onecoreuap".to_string();
Together with lower casing the link macros in bindings.rs cross-compilation works in my particular project!
I might have broken two legacy test cases in pwstr.rs however.

@abbec @ke1satsu I applied the lowercase change in #1128 - let me know if there is anything else preventing you from cross compiling.
Also feel free to suggest some sort of test that I can add to the build here to make sure cross-compilation keeps working - I don't have any experience with Linux otherwise I would add something.

Awesome! Thanks alot :)
As for tests in the build, I'm sorry to say I've never touched CI/CD so I'm unsure how one could go about checking that in the pipeline. If I figure something out I'll make sure to drop some suggestions here!

I can wire up x86_64-pc-windows-gnu for CI later tonight 👍

Thanks!

@ke1satsu What are you using to satisfy onecoreuap dependencies? It doesn't appear mingw ships this umbrella lib. I'm guessing you didn't try the crate tests and you're carefully using APIs that don't need this in your project.

@ke1satsu Hah, thanks for the quick follow up! I'll think some more about how we handle this.

It's true that most (all?) umbrella libraries are missing from mingw-w64. Nobody asked for it on the mailing list yet so I think they would accept patches adding it.


A Key is not working

Type: Bug
">" This Key on keyboard is not working when I write a Code on VScode. this only happens on VScode.
 It looks like you may be using an old version of VS Code, the latest stable release is 1.87.2. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

Please use the Start Extension Bisect command to investigate whether the problem is being caused by one of your extensions.

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Add dashboard post

@jamesob @moneyball @harding - would love your thoughts about this if you have time to review.

I think this is pretty much good to go (modulo any nits that Marcin wants to take). We should include a link to it in next week's newsletter and merge at the same time.

tACK
Fantastic write up! I learned a lot from it. Great work this summer.

Fantastic write up! I learned a lot from it. Great work this summer.

Agreed!

Thanks! And thanks for all the reviews.
Should I change the date on the post then?

Should I change the date on the post then?

Good idea. Newsletter goes out on Tuesday (Sept 4).

Merged in #63. Thanks Marcin!


Is there any way to use optional params?

Hi,
great work by the way. I'm using your work to rebuild an existing API that is in java now. At the moment they are using GET method url params like this: url?param=123?param2=321.
Is there any way to archive this with routing-controllers with express ?
I was able to do it with : url/param/param2 but thats would cost the refactoring of the app  too.
Thanks in advance!
Best Regards,
Welder Marcos

Forget about it.
Found my solution with the @Req and @Res. Here is an example if someone else face this problem:
@Get("/post")
findList (@Req() req: any, @Res() res: any) {
res.send(req.query.param);
}

wait you can use @QueryParam("paramName") paramName decorator:
@Get("/post")
findList (@QueryParam("sortBy") sortBy: string) {
   return [];
}

Closing this. Let me know if need anything else.

Was a silly mistake, your solution was the best at the end. Ty for the great support.


Windows:Visual studio 2019: missing exception info

Hello,
I'm working on a SEAL project in Windows and Linux environments.
On Linux I'm getting an exception with error info like: "what() scale out of bound" or different message for different errors, while the same code doesn't provide this piece of message (what()...) in Windows VS.
In Windows I only get something like:
Exception thrown at 0x00007FFCBBD9D759 in FHE_SFHT.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x00000XXXXXXXX.
Unhandled exception at 0x00007FFCBBD9D759 in FHE_SFHT.exe: Microsoft C++ exception: std::invalid_argument at memory location 0x00000XXXXXXX.

My question is: How can I get similar info or more detailed info about errors and exceptions in Windows?
Setup:
SEAL 3.6.3
Windows 10 - VS2019
Ubuntu20

Those are two different run-time errors caused by different reasons, if we designed everything correctly. Could you please run in debug mode in Visual Studio and same in Linux, then tell me where the errors are thrown? It would be helpful if you can share the stack frames. If different run-time errors were thrown on different systems, we need to fix it.

Unfortunately that's not possible in my current situation, since in Windows debug mode some SEAL functions are x18 slower than in release mode, I don't have enough resources to work in debug mode.

How about RelWithDebInfo mode?

OK, when building RelWithDebInfo, things seems to work better, I can see more error info:

I think with this 'solution', the issue could be closed.
(it only works while running through VS, when running in CMD there is no info presented)


Running tox on master branch throws errors

Getting the below errors on master branch while running tox
Wondering if others also get the same?
...
...
nx-rtd-theme==0.1.9,tabulate==0.7.5,testinfra==1.3.0,websocket-client==0.37.0
docs runtests: PYTHONHASHSEED='536444407'
docs runtests: commands[0] | python setup.py build_sphinx
ERROR:root:Error parsing
Traceback (most recent call last):
  File "/Users/sebin/dev/tmp/molecule/.tox/docs/lib/python2.7/site-packages/pbr/core.py", line 111, in pbr
    attrs = util.cfg_to_args(path, dist.script_args)
  File "/Users/sebin/dev/tmp/molecule/.tox/docs/lib/python2.7/site-packages/pbr/util.py", line 246, in cfg_to_args
    pbr.hooks.setup_hook(config)
  File "/Users/sebin/dev/tmp/molecule/.tox/docs/lib/python2.7/site-packages/pbr/hooks/__init__.py", line 25, in setup_hook
    metadata_config.run()
  File "/Users/sebin/dev/tmp/molecule/.tox/docs/lib/python2.7/site-packages/pbr/hooks/base.py", line 27, in run
    self.hook()
  File "/Users/sebin/dev/tmp/molecule/.tox/docs/lib/python2.7/site-packages/pbr/hooks/metadata.py", line 26, in hook
    self.config['name'], self.config.get('version', None))
  File "/Users/sebin/dev/tmp/molecule/.tox/docs/lib/python2.7/site-packages/pbr/packaging.py", line 725, in get_version
    raise Exception("Versioning for this project requires either an sdist"
Exception: Versioning for this project requires either an sdist tarball, or access to an upstream git repository. Are you sure that git is installed?
error in setup command: Error parsing /Users/sebin/dev/tmp/molecule/setup.cfg: Exception: Versioning for this project requires either an sdist tarball, or access to an upstream git repository. Are you sure that git is installed?
ERROR: InvocationError: '/Users/sebin/dev/tmp/molecule/.tox/docs/bin/python setup.py build_sphinx'
py27 create: /Users/sebin/dev/tmp/molecule/.tox/py27
py27 installdeps: -rrequirements.txt, -rtest-requirements.txt
py27 inst: /Users/sebin/dev/tmp/molecule/.tox/dist/molecule-1.5.1.zip
...

and
....
10,PyYAML==3.11,requests==2.10.0,sh==1.11,six==1.10.0,tabulate==0.7.5,testinfra==1.3.0,testrepository==0.0.20,testtools==2.2.0,tox==2.3.1,traceback2==1.4.0,unittest2==1.1.0,virtualenv==15.0.2,websocket-client==0.37.0,yapf==0.9.0
py27 runtests: PYTHONHASHSEED='536444407'
py27 runtests: commands[0] | python -m unittest discover --failfast
.....................E
======================================================================
ERROR: test_destroy (tests.test_dockerprovisioner.TestDockerProvisioner)
tests.test_dockerprovisioner.TestDockerProvisioner.test_destroy
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "/Users/sebin/dev/tmp/molecule/tests/test_dockerprovisioner.py", line 100, in test_destroy
    docker_provisioner = provisioners.DockerProvisioner(self._mock_molecule)
  File "/Users/sebin/dev/tmp/molecule/molecule/provisioners.py", line 413, in __init__
    self.status()
  File "/Users/sebin/dev/tmp/molecule/molecule/provisioners.py", line 580, in status
    created_containers = self._docker.containers(all=True)
  File "/Users/sebin/dev/tmp/molecule/.tox/py27/lib/python2.7/site-packages/docker/api/container.py", line 70, in containers
    res = self._result(self._get(u, params=params), True)
  File "/Users/sebin/dev/tmp/molecule/.tox/py27/lib/python2.7/site-packages/docker/utils/decorators.py", line 47, in inner
    return f(self, *args, **kwargs)
  File "/Users/sebin/dev/tmp/molecule/.tox/py27/lib/python2.7/site-packages/docker/client.py", line 120, in _get
    return self.get(url, **self._set_request_timeout(kwargs))
  File "/Users/sebin/dev/tmp/molecule/.tox/py27/lib/python2.7/site-packages/requests/sessions.py", line 487, in get
    return self.request('GET', url, **kwargs)
  File "/Users/sebin/dev/tmp/molecule/.tox/py27/lib/python2.7/site-packages/requests/sessions.py", line 475, in request
    resp = self.send(prep, **send_kwargs)
  File "/Users/sebin/dev/tmp/molecule/.tox/py27/lib/python2.7/site-packages/requests/sessions.py", line 585, in send
    r = adapter.send(request, **kwargs)
  File "/Users/sebin/dev/tmp/molecule/.tox/py27/lib/python2.7/site-packages/requests/adapters.py", line 453, in send
    raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', error(2, 'No such file or directory'))

----------------------------------------------------------------------
Ran 22 tests in 0.115s

Interesting - my fork is even with master at the moment and the travis build seems to be running fine. First error looks like its complaining that git isn't installed? And with the second one - are any of the other docker tests passing for you?

I am on OSX Capitan and I use docker-toolbox to setup docker
For the second issue, I did the following
without setting any docker parameters, execute the unittest manually.
pwd && python -m unittest discover --failfast
Result  is
/Users/sebin/dev/molecule
.....................E
======================================================================
ERROR: test_destroy (tests.test_dockerprovisioner.TestDockerProvisioner)
tests.test_dockerprovisioner.TestDockerProvisioner.test_destroy
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "/Users/sebin/dev/molecule/tests/test_dockerprovisioner.py", line 100, in test_destroy
    docker_provisioner = provisioners.DockerProvisioner(self._mock_molecule)
  File "/Users/sebin/dev/molecule/molecule/provisioners.py", line 413, in __init__
    self.status()
  File "/Users/sebin/dev/molecule/molecule/provisioners.py", line 580, in status
    created_containers = self._docker.containers(all=True)
  File "/usr/local/lib/python2.7/site-packages/docker_py-1.8.0-py2.7.egg/docker/api/container.py", line 70, in containers
    res = self._result(self._get(u, params=params), True)
  File "/usr/local/lib/python2.7/site-packages/docker_py-1.8.0-py2.7.egg/docker/utils/decorators.py", line 47, in inner
    return f(self, *args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/docker_py-1.8.0-py2.7.egg/docker/client.py", line 120, in _get
    return self.get(url, **self._set_request_timeout(kwargs))
  File "/usr/local/lib/python2.7/site-packages/requests-2.7.0-py2.7.egg/requests/sessions.py", line 477, in get
    return self.request('GET', url, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/requests-2.7.0-py2.7.egg/requests/sessions.py", line 465, in request
    resp = self.send(prep, **send_kwargs)
  File "/usr/local/lib/python2.7/site-packages/requests-2.7.0-py2.7.egg/requests/sessions.py", line 573, in send
    r = adapter.send(request, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/requests-2.7.0-py2.7.egg/requests/adapters.py", line 415, in send
    raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', error(2, 'No such file or directory'))

----------------------------------------------------------------------
Ran 22 tests in 0.109s

FAILED (errors=1)

now if I set docker parameters using eval $(docker-machine env docker) and rerun the unittest
pwd && python -m unittest discover --failfast
Result is:
pwd && python -m unittest discover --failfast
/Users/sebin/dev/molecule
..................... Creating container test1 with base image ubuntu:latest ...  Container created.

 Creating container test2 with base image ubuntu:latest ...  Container created.

 Stopping container test1 ...  Removed container test1.

 Stopping container test2 ...  Removed container test2.

... Creating container test1 with base image ubuntu:latest ...  Container created.

 Creating container test2 with base image ubuntu:latest ...  Container created.

...

test1                      : ok=2    changed=1    unreachable=0    failed=0
test2                      : ok=2    changed=1    unreachable=0    failed=0

. Starting container  ...
 Starting container  ...
. Starting container  ...
 Starting container  ...
 Stopping container test1 ...  Removed container test1.

 Stopping container test2 ...  Removed container test2.

.........................
----------------------------------------------------------------------
Ran 53 tests in 11.331s

OK

So, I think when tox runs the test docker environment variables are somehow ignored.

The docker environment variables aren't being ignored. From what you describe it looks like you just didn't have them set. The docker provisioner will only read from your current variables. It won't search your machines to set them. Also you should give the new docker beta a try - It's really awesome because you can use docker without having to set up a docker-machine.

@kireledan apologies if I sound confusing.
What I have tried to explain is that if I set docker parameters and run unittest manually(python -m unittest discover --failfast) it will work and the same doesn't work when I use tox.
So, I just made a change - https://github.com/sebinjohn/molecule/commit/03f52daf1bd1e6940940dc968472d35f44c45087 to thetox.ini
and now the tests work fine.
Also, I have signed up a while back for the docker for mac beta program. Still waiting for it. :)

Ahhh I see what you mean now. Makes sense - no worries!
It's open beta now actually as of yesterday.  https://www.docker.com/products/docker#/mac

@kireledan Thanks. I installed it.

@sebinjohn is this issue resolved?

Their PR has the change they made to fix the tox tests. I'd imagine this issue is safe to close.

@kireledan good call.  Closing.  @sebinjohn please re-open if still an issue.

👍


Add Worker::is_same_as

Add a shim for Arc::ptr_eq for lifo/fifo Worker in the form of Worker::is_same_as. Fixes #2.

As per the discussion in #2, closing in favor of #5.


EDGEPOD-321 - timer lib

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Worki

Please address the comments.

Working on adding the timer test functions. I shall update it asap.


[LATS example] Use recursive best candidate selection in the tree

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.

Example Code
The function expand(state: TreeState, config: RunnableConfig) code in the example at [0], only the directed children nodes of the root are considered the UCT values to extend.
[0] https://github.com/langchain-ai/langgraph/blob/main/examples/lats/lats.ipynb
Error Message and Stack Trace (if applicable)
In the extreme case, the error recursion limit reached of the graph/pregel could be triggered.
Description
First, thanks for building these awesome assets and the example code!
IIUC on the Language Agents Tree Search approach described in the blog [0], for each node in the tree, should not only consider the UCT values of its direct children, but also recursively consider the UCT values of all descendant nodes, in order to find the best candidate to extend (before the max search depth is reached) with the highest UCT value in the entire tree.
so I consider a fix is:
# best_candidate: Node = root.best_child if root.children else root    # should be replaced by the following
best_candidate: Node = root
while best_candidate.children:
    best_candidate = best_candidate.best_child

[0] https://blog.langchain.dev/reflection-agents/
If I understand anything wrong, pls let me know.
zhiyan
System Info
langchain==0.1.9
langchain-community==0.0.21
langchain-core==0.1.27
langchain-experimental==0.0.52
langchain-openai==0.0.8
langchainhub==0.1.14
langgraph==0.0.26
platform: mac
python: 3.11.7

Hi @hinthornw , could you pls confirm if I have understood you correctly? If so, I'd like to prepare a small PR to address that issue, thanks.

Ya that's a good observation - I'll land a fix


Feature request: easier access to all variables inside a scope

Right now, in order to access the variables inside a scope, AFAIK we have to do the following:
variables = tf.get_collection(tf.GraphKeys.VARIABLES, scope)

It would be far easier if we could just write
variables = scope.get_all_variables()

or maybe
variables = tf.get_scope_variables(scope)

Is it a reasonable request?

@josh11b can you comment or reassign?

Would love to work on this if @josh11b doesn't have bandwidth :)

I think it's not easy to introduce new APIs for TF 1.0 now. Any new API will have to go through a design review, and I don't feel like doing that. On the other hand, we could just add a property to the VariableScope object that would select all variables. That's a very small API change, I think. But I'll wait for Martin to comment more, he knows way more about the API process.

It's not a problem to add new features, we're a little more conservative in what we accept. This seems like a reasonable request to me, I'd go for the vars = scope.get_variables() option.

I think we should have scope.global_variables() (or just scope.variables() ?)  and scope.trainable_variables() to match the global tf functions.Guys (josh11b/firstprayer), will you send a PR?

This is done, correct? Closing.

Yes, done!


Add retrieve() without arguments to GraphQlClient to decode the full data

Hi Spring Team,
It is a request / question.
Can you provide an additional overloaded method .retrieve() in the GraphQlClient's RequestSpec if the users want to access the whole data response?
We do have some work around as shown here but it would be better to have it part of RequestSpec itself.
.retrieve("")
or
execute().map(...)

Thanks @rstoyanchev
Is it not normal to have multiple keys inside the data object? For ex: I ask for a book by id and along with some recommendations. (may be a bad example.) and I might want to map it to a BookWithRecommendationsDto. Others might not be interested in the recommendations and might be interested only in the book object.
{
    "data": {
        "book": {..},
        "recommendations": [
            { .. },
            { .. }
        ]
    }
}

It is not a blocker. Currently I could use .retrieve(""). But as you see it makes the code super ugly.
So adding a default retrieve() in the interface would be nice to have as we have in the WebClient.
If you have other plans to make it better, that would be great too. I can go with execute as well.

Thank you sir, I appreciate it.


Define a standard for labels.

🐛 Category
💽 Repository
🔢 Version
⛔ Not Applicable
🤔 What's happening?
Labels are inconsistent across repositories.
📝 What was your expectation?
Labels should be consistent across repositories.

What should the default set of labels be?
What should the color (hex code) for each label be?
Where should the standard be defined?


code of conduct & license updates

Updating (and hopefully missing circleci this time).
Signed-off-by: Bridget Kromhout<EMAIL_ADDRESS>

@lachie83 It appears that even a new PR still hits circleci?


refactor: make RSA and SHA functions more atomic

- What I did
- Made RSA encrypt/decrypt and sign/verify functions more atomic. Before, we would expect a base64 input or would output a base64 string. This would result to unnecessary base64 operations that the developer may not have needed. For example, 5 back-to-back RSA decrypts would have 5 base64 decodes (since you would have to base64 decode the input) but what if the original ciphertext was already in raw bytes? Then That would have resulted in 5 unnecessary base64 decodes which is precious compute power. On the developer side, this would simply result in more control as to what is base64 encoded/decoded. The developer cost isn't that much either, as it is just one more step before the encryption/decryption operation, if they deem it necessary.
- Removed unnecessary function arguments in SHA functions (such as hashlen, which should always output to 32 depending on the SHA algorithm). In this case, we leave it up to the developer to properly allocate 32 bytes in their output buffer (as specified in the function header documentation). Previously, we would simply receive the output buffer size and error check that the output (32) was less than or equal to their buffer size (e.g. 1024). But in this case, the developer should be reading the docs to see that the output is ALWAYS related to their hashing algorithm size (e.g. SHA 256 has output of 32 bytes). this is also specified in the function header documentation. Hence, we do not need to output the length of the hash in the function, for example. This pattern is seen elsewhere in places like RSA sign and verify.
- How I did it
New rsa.h:
/**
 * @brief Sign a message with an RSA private key
 *
 * @param privatekey the private key struct to use for signing, see atchops_rsakey_populate_privatekey
 * @param mdtype the hash type to use, see atchops_md_type, e.g. ATCHOPS_MD_SHA256
 * @param message the message to sign
 * @param messagelen the length of the message, most people use strlen() to find this length
 * @param signature the signature buffer to populate, must be pre-allocated. Signature size will correspond to the
 * specified hashing algorithm (e.g., this function expects `signature` to be a buffer of 32 bytes allocated, if using
 * ATCHOPS_MD_SHA256 (256 bits = 32 bytes)) .
 * @return int 0 on success
 */
int atchops_rsa_sign(const atchops_rsakey_privatekey privatekey, const mbedtls_md_type_t mdtype,
                     const unsigned char *message, const size_t messagelen, unsigned char *signature);

/**
 * @brief Verify a signature with an RSA public key
 *
 * @param publickey the public key to use for verification, see atchops_rsakey_populate_publickey
 * @param mdtype the hash type to use, see atchops_md_type, e.g. ATCHOPS_MD_SHA256
 * @param message the original message to hash, in bytes
 * @param messagelen the length of the original message, most people use strlen() to find this length
 * @param signature the signature to verify, expected to be the same length as the key size (e.g. 256 bytes for 2048 RSA modulus)
 * @return int 0 on success
 */
int atchops_rsa_verify(const atchops_rsakey_publickey publickey, const mbedtls_md_type_t mdtype, const unsigned char *message,
                       const size_t messagelen, unsigned char *signature);

/**
 * @brief Encrypt bytes with an RSA public key
 *
 * @param publickeystruct the public key struct to use for encryption, see atchops_rsakey_populate_publickey
 * @param plaintext the plaintext to encrypt, in bytes
 * @param plaintextlen the length of the plaintext, most people use strlen() to find this length
 * @param ciphertext the ciphertext buffer to populate
 * @param ciphertextsize the length of the ciphertext buffer
 * @param ciphertextlen the written length of the ciphertext buffer after encryption operation has completed, should be the same as the key size (e.g. 256 bytes for 2048 RSA modulus)
 * @return int 0 on success
 */
int atchops_rsa_encrypt(const atchops_rsakey_publickey publickey, const unsigned char *plaintext,
                        const size_t plaintextlen, unsigned char *ciphertext, const size_t ciphertextsize,
                        size_t *ciphertextlen);

/**
 * @brief Decrypt bytes with an RSA private key
 *
 * @param privatekey the private key struct to use for decryption, see atchops_rsakey_populate_privatekey
 * @param ciphertext the ciphertext to decrypt, in bytes
 * @param ciphertextlen the length of the ciphertext, should be the same as the key size (e.g. 256 bytes for 2048 RSA modulus)
 * @param plaintext the plaintext buffer to populate
 * @param plaintextsize the size of the plaintext buffer (allocated size)
 * @param plaintextlen the written length of the plaintext buffer after decryption operation has completed
 * @return int 0 on success
 */
int atchops_rsa_decrypt(const atchops_rsakey_privatekey privatekey, const unsigned char *ciphertext,
                        const size_t ciphertextlen, unsigned char *plaintext, const size_t plaintextsize,
                        size_t *plaintextlen);

new sha.h
/**
 * @brief SHA Hash an input buffer
 *
 * @param mdtype the type of hash to use (e.g. MBEDTLS_MD_SHA256)
 * @param input the input to hash (in raw bytes)
 * @param inputlen the length of the input buffer (most likely strlen(input))
 * @param output (out) the output buffer to write the hash to. The length of this buffer should correspond to the hash
 * type (e.g. 32 bytes for SHA256 (256 bits = 32 bytes))
 * @return int 0 on success
 */
int atchops_sha_hash(const mbedtls_md_type_t mdtype, const unsigned char *input, const size_t inputlen,
                     unsigned char *output);

- How to verify it

tests passing
ran crud tests and they still pass

- Description for the changelog
Closes #182

Requesting review @realvarx @XavierChanth
Finished merge to trunk and did manual tests on crud operations


[4.0] Added hasScopes method.

I'm adding hasScopes method to check if the current DataTable class has the given scopes.
In my case, I have to determine the columns based on scopes. For example, it the DataTable class has a scope then I need to display A, B and C, otherwise display only A and B.
/**
 * Get columns.
 *
 * @return array
 */
protected function getColumns(): array
{
    $columns = [
        'A',
        'B',
    ];

    if ($this->hasScopes([MyScope::class])) {
        $columns = array_merge(
            $columns,
            [
                'C'
            ]
        );
    }

    return $columns;
}

I'm also adding a second parameter to the hasScopes method, it's a boolean flag (false by default) to set whether to check all the values for true, or to return true if at least one class is matched.
$this->hasScopes([FirstScope::class, SecondScope::class], true)

If we pas the second parameter true, we will check all the given query scopes for true, it means the DataTable class should have FirstScope and SecondScope class.

Released on v4.2.0, thanks!


tests: mbox: Check k_mbox_get return

Coverity was complaining that this function was not being checked only
in a specific case.
Coverity CID: 183066
Signed-off-by: Flavio Ceolin<EMAIL_ADDRESS>

Codecov Report

Merging #14857 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #14857      +/-   ##
==========================================
+ Coverage   52.49%   52.52%   +0.02%
==========================================
  Files         309      309
  Lines       45060    45065       +5
  Branches    10431    10436       +5
==========================================
+ Hits        23656    23669      +13
+ Misses      16592    16583       -9
- Partials     4812     4813       +1

Impacted Files
Coverage Δ

drivers/clock_control/nrf_power_clock.c
50% <0%> (-2.11%)
:arrow_down:

boards/posix/nrf52_bsim/argparse.c
46.98% <0%> (+15.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22cf6d9...2a2f072. Read the comment docs.


Remove Control z-index warning

Addresses https://github.com/godotengine/godot/issues/69895
The warning message now mentions that it can be disabled: is completely gone.

I'm in favor of providing a way to disable this warning. After reading through #69895 it looks like that a dedicated project setting is justified in this case as many users have strong feelings about the presence of that warning :) Well aware that this isn't the best (permanent) solution, but I think it's the best we can currently do without major/breaking changes to the configuration warning system.

This feels like a band-aid. It would be better to have a way to silence any warning.

This feels pretty hacky to me. And since it needs to be configured in the project settings, users who know and don't care to keep being reminded about this will need to disable it manually in every single project they make that users Z index on Controls.
IMO, aside from a more involved system to make configuration warnings more flexible as suggested in https://github.com/godotengine/godot-proposals/issues/9416, this particular one may just need to go. A crystal clear warning in the documentation should be sufficient. We can try, and if we find that too many users are confused, we can add a warning back. But currently we only tried with a warning and thus with users confused by the warning, and not by what it teaches them.

A crystal clear warning in the documentation should be sufficient.

Where though? In z_index description, which is in CanvasItem?

A crystal clear warning in the documentation should be sufficient.

Where though? In z_index description, which is in CanvasItem?

Yeah I think so. And maybe a note in the Control description?

Thanks!


custom jwt configuration for npm token command

Is your feature request related to a problem?
utilise verdaccio JWT authentication in a environment that requires a longer expiresIn compared to regular users auth, for example a CI setup
Describe the solution you'd like
ability to set a different JWT configiguration in the config.yaml file for tokens that are generated manually utilising the https://github.com/verdaccio/verdaccio/pull/1427 npm command, as these tokens are revokable it seems less of a security issue to set a longer expiresIn value thus a potential good candidate in CI environment
For example by adding an optional identifier of npm:
security:
  api:
    jwt:
      sign:
        expiresIn: 14d
  npm:
    jwt:
      sign:
        expiresIn: 90d

It would be important though that the tokens are actually revoked when removed for security reasons Reviewing https://github.com/verdaccio/verdaccio/pull/1427 I can see the token reference being deleted from the local storage but would such a revoked token actually fail? As the expire claim is within the JWT token it seems to suggest the delete action from storage is not truly revoking the token and would need some sort of blacklist?

reference to feature request for the blacklist:
https://github.com/verdaccio/verdaccio/issues/1702

I think you are right @bartsidee , I'll double check when I have a bit more time. 💯


Request support for tree branch with vector objects

In giving UpRoot a try we noticed it does not currently support tree branches containing vector objects.  Many analysis make use of 4-vector information for many types particles in the event. Having access to a branch with stored TLorentzVector objects would be very useful. It would be awesome if such capability could be added as it would benefit the physics community at large.

Jim, would the purely pythonic class LorentzVector we have in https://github.com/scikit-hep/scikit-hep/blob/master/skhep/math/vectors.py be of use for you here? We have a pull request under work to change the internals of the class, for performance. Still, the API is basically there.

The immediate issue is that I need to use the ROOT streamers to read the data from bytes into a Python class. Then, after that, it could be useful to add Python methods for boosting, rotations, etc. Because of how ROOT has defined TLorentzVector, the data structure will have to be
class TVector3(TObject, TVector3Methods):
    def __init__(self, x, y, z):
        self.fX = x
        self.fY = y
        self.fZ = z

class TLorentzVector(TObject, TLorentzVectorMethods):
    def __init__(self, p, e):
        self.fP = p
        self.fE = e

where I'm free to define TVector3Methods and TLorentzVectorMethods however I like. I can define these methods-only mixin classes (no data!) as subclasses of whatever I like, and it should at least have some basic convenience methods.
I can define the built-in methods to not clash with Scikit-HEP's LorentzVector and make Scikit-HEP an optional dependency that enhances it with the dozens of methods you've defined. They should come at no cost in performance, since it's just a superclass pointer. Then when users install Scikit-HEP, their Lorentz vectors get super-powers.
I'll have to experiment to see what Python does when Scikit-HEP's LorentzVector tries to derive quantities from a private member (two leading underscores, which like C++'s private are not passed down to subclasses) and the data are in members named fP, fE. It would be easy to add a @property to translate fP to __vector3d and fE to __t, but I don't know how Python propagates that through subclasses.

Understood. Thanks for all the details. To be seen indeed, not in the first steps of development ...

Looking at it now, the Python trickery and dependence on whether the user has some library installed but not explicitly imported doesn't sound like a good idea.
Instead, I'm going to take the Scikit-HEP definitions as establishing a duck-typing convention and making the TVector3 and TLorentzVector from ROOT 100% compatible with the Scikit-HEP version. Then Python functions and user code that accepts one will accept the other, even if they don't derive from the same class.

By the way (for watchers of this issue), the deserialization is done: the master version on GitHub can read your TLorentzVectors, if you don't mind the fP, fE stuff. I'm adding the convenience functions now.

So we are now in a weird position of being able to read std::vector<UserClass> for any user class, but not any user classes as single objects per event. (I'm calling TLorentzVector a user class because what I really implemented was anything with a streamer.) If you have any examples of TLorentzVector (or other unsplit classes) that are not in std::vector, please raise another issue and I'll implement it!
The main part of this work turned out to be just
    def interpret(self, item):
        size, = item[6:10].view(JaggedObjects.indexdtype)
        source = uproot.source.source.Source(item)
        cursor = uproot.source.cursor.Cursor(10)
        out = [None] * size
        for i in range(size):
            out[i] = self._class.read(source, cursor, self._context, None)
        return out

and we just pick up the bytes-to-objects automatically in the auto-generated self._class. Almost nothing to do, and that's great! (ROOT streamers are nice.)
And then for convenience, I added the Sckit-HEP 3-vector and 4-vector methods.

@kpedro88

I don't have an example of single TLorentzVector branch on hand, but can probably make one easily. Will put it on my todo list.


Add timeout

cd repos/node_modules/broken-link-checker/
[josh@localhost broken-link-checker]$ grep -r 'timeout' .

No timeout option exists.
https://github.com/stevenvachon/broken-link-checker/issues/67

The timeout is defined by the operating system and is usually 2000ms. Setting Node's http timeout to anything longer than that will not override the OS setting. Setting to anything shorter might be insufficient.

I've implemented timeouts in nodeJS just fine. If there is some kind  an OS issue, you could use setTimeout() & clearTimeout() to workaround this.
What happens is BLC tries to do an HTTP request to some random IP not running a web server.  In your script you can implement a user-land timeout defaulted to 30 seconds, which can be customized. Simply use setTimeout to register a callback that removes your listener & resumes the queue. If the request completes before this callback fires, use clearTimeout. Behind the scenes the OS may still be trying to open a TCP connection, but there's no reason the BLC queue has to block. This is a huge performance problem. Instead of testing 100s of URLs a second I'm only getting a throughput of about 1 URL a second after averaging in all the blocking, and I have to check 100s of thousands of URLs.

If a request is not timing out, then this is an issue with bhttp.


Trigger submit on all forms in modal body

See #362

Ok in Chrome.
But in Firefox, the form is submitted and right after, a full page reload is triggered.

Forget the last comment about Firefox, this only occured in my particular setup ;-)

Done ;-)

Thanks @Moxide for working on this!


[WIP] Brian/import oracles

Pull Request Test Coverage Report for Build 7421

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 7411:
0.0%

Covered Lines:
1572

Relevant Lines:
1572

💛  - Coveralls


Add controlz to install-cni.

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure
Pull Request Attributes
Please check any characteristics that apply to this pull request.
[ ] Does not have any user-facing changes. This may include CLI changes, API changes, behavior changes, performance improvements, etc.

@bianpengyuan: The following test failed, say /retest to rerun all failed tests:

Test name
Commit
Details
Rerun command

release-notes_istio
e30ed47963392c028de0682a331afbd02f51cf57
link
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest


[SPARK-20889][SparkR] Grouped documentation for WINDOW column methods

What changes were proposed in this pull request?
Grouped documentation for column window methods.

Test build #78957 has started for PR 18481 at commit e7d19a3.

Ahh, forgot about the window functions. This is actually the last set...  @felixcheung @HyukjinKwon

Test build #78957 has finished for PR 18481 at commit e7d19a3.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78957/
Test FAILed.

jenkins, retest this please

Test build #78965 has started for PR 18481 at commit e7d19a3.

Test build #78965 has finished for PR 18481 at commit e7d19a3.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78965/
Test FAILed.

Merged build finished. Test FAILed.

Test build #78990 has started for PR 18481 at commit 311a444.

Test build #78990 has finished for PR 18481 at commit 311a444.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78990/
Test PASSed.

Test build #78998 has started for PR 18481 at commit 1ba5694.

Test build #78998 has finished for PR 18481 at commit 1ba5694.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78998/
Test PASSed.

Merged build finished. Test PASSed.

OK, docs are now updated as you suggested.

Test build #79079 has started for PR 18481 at commit 6d5adf0.

Test build #79079 has finished for PR 18481 at commit 6d5adf0.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79079/
Test FAILed.

jenkins, retest this please

Test build #79083 has started for PR 18481 at commit 6d5adf0.

Test build #79083 has finished for PR 18481 at commit 6d5adf0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79083/
Test PASSed.

Test build #79108 has started for PR 18481 at commit 53f2414.

Test build #79108 has finished for PR 18481 at commit 53f2414.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79108/
Test PASSed.

Merged build finished. Test PASSed.

merged to master


Export mod list

At very least export to a human readable list format that details:

Mod name
Mod version

Optionally, make list also machine readable, or have an option to produce a machine readable version that can then be imported (ie: imply the ability to import mod lists - track in separate issue).
A more advanced implementation may also include in the export forum links (if available) to support a hypothetical import function, which may notify a user on import if a mod in the list is not installed, and present the forum link for user's convenience.

Isn't this duplicating description.xml file from the save? Might as well reuse it. The program would then read that file in a save and suggest a new list of mods (missing / present). It will not provide the links to download them, though. One idea I've been toying around was to just "bite it" and manage a mod-database (id,download_link) and that way offer auto-update (or installation, based on description.xml.

Isn't this duplicating descriptor.xml file from the save? Might as well reuse it. The program would then read that file in a save and suggest a new list of mods (missing / present). It will not provide the links to download them, though.

Ah, yeah I had forgotten that saves embed what mods they have enabled, that's a good idea. It would raise the edge case of creating a mod list in the manager that has not been encoded into a save, and then not being able to export that. Tbh this isn't something terribly high on my priority list, but that could change depending on what people say.

One idea I've been toying around was to just "bite it" and manage a mod-database (id,download_link) and that way offer auto-update (or installation, based on descriptor.xml.

I've thought about this too. Something akin to NPM or other package/dependency managers. And I believe 0.95 now lets mods specify dependencies. A back-of-the-napkin idea I had for this was to create a GitHub repo with a specific schema, where each "entry" is a folder named by ID/containing a file with a mod ID, and a series of version files, ideally version files extended with direct links to mod archives. You could then build a tool on top of that to clone/contact the repo and parse it for mods and then install them. This also lets new mods be added through forks/merge requests. One issue is that it's a bit more complicated, and requires mod authors to know how to use Git and GitHub, to an extent.
The main issues faced by any centralised "mods directory" would, I believe, be two-fold:

Hosting/storage requirements. Who will host it? Maintain it? Pay for it?
Making it as pain free as possible for mod authors to contribute to

Both are non-existential when using Github (use web editing / PR submission, hosting is for free). The bigger issue is getting people on board that (not only files ready, but also modders buying into the idea), and maintaining it up to date. In my case "bite it" meant maintaining it by myself (initially, and mostly for mods I use personally), until people notice it, start using it, and build it up.
It might not even be a need of "modders knowing how to use Github" case. Like with wiki, sooner or later a team would form up that would keep such repo up to date. I never had a tool to do that, so the idea never took off.


omegat: <IP_ADDRESS> -> 4.3.0

Motivation for this change
Release of a fresh and stable version.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@GrahamcOfBorg build omegat

Built and tested locally :+1: