onDetachedFromWindow is called immediately after initializing the View - android only

Description
Sample code: https://github.com/hoyelo/rn-demo
This is a React Native library created using npx create-react-native-library@latest rn-sdk. Inside the library, there is only a simple View created with no other functionalities. However, onDetachedFromWindow is called during the creation of this View, which should not happen. After all, I have a lot of destruction logic placed in this method, and if this happens, it will cause many other problems. This issue has been noticed since the commit da5ed0d10b9813e650b342dcc63a0af4d4af9dea, which means it has been occurring since version 0.71.12.
React Native Version
0.72.3
Output of npx react-native info
System:
OS: macOS 13.1
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Memory: 124.12 MB / 16.00 GB
Shell:
version: 5.8.1
path: /bin/zsh
Binaries:
Node:
version: 20.4.0
path: ~/.nvm/versions/node/v20.4.0/bin/node
Yarn:
version: 1.22.19
path: ~/.yarn/bin/yarn
npm:
version: 9.7.2
path: ~/.nvm/versions/node/v20.4.0/bin/npm
Watchman:
version: 2<IP_ADDRESS>
path: /usr/local/bin/watchman
Managers:
CocoaPods:
version: 1.12.1
path: /Users/Victor/.rvm/gems/ruby-2.7.5/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 22.4
- iOS 16.4
- macOS 13.3
- tvOS 16.4
- watchOS 9.4
Android SDK:
API Levels:
- "26"
- "28"
- "29"
- "30"
- "31"
- "32"
- "33"
Build Tools:
- 19.1.0
- 20.0.0
- 21.1.2
- 22.0.1
- 23.0.1
- 23.0.2
- 23.0.3
- 24.0.0
- 24.0.1
- 24.0.2
- 24.0.3
- 25.0.0
- 25.0.1
- 25.0.2
- 25.0.3
- 26.0.0
- 26.0.1
- 26.0.2
- 26.0.3
- 27.0.0
- 27.0.1
- 27.0.2
- 27.0.3
- 28.0.0
- 28.0.1
- 28.0.2
- 28.0.3
- 29.0.0
- 29.0.1
- 29.0.2
- 29.0.3
- 30.0.0
- 30.0.1
- 30.0.2
- 30.0.3
- 31.0.0
- 32.0.0
System Images:
- android-23 | Google APIs Intel x86 Atom
- android-30 | Google APIs Intel x86 Atom
- android-31 | Google APIs Intel x86 Atom_64
Android NDK: Not Found
IDEs:
Android Studio: 2022.1 AI-221.6008.13.2211.9477386
Xcode:
version: 14.3.1/14E300c
path: /usr/bin/xcodebuild
Languages:
Java:
version: 11.0.14
path: /usr/bin/javac
Ruby:
version: 2.7.5
path: /Users/Victor/.rvm/rubies/ruby-2.7.5/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.72.3
wanted: 0.72.3
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false
Steps to reproduce

git clone git@github.com:hoyelo/rn-demo.git
run yarn
set breakpoints in both onAttachedToWindow and onDetachedFromWindow functions, and debug it on AndroidStudio

class WidgetView constructor(
context: Context,
) : View(context) {
init {
}
override fun onAttachedToWindow() {
super.onAttachedToWindow()
}
override fun onDetachedFromWindow() {
super.onDetachedFromWindow()
}
}
4. onDetachedFromWindow is called immediately after onAttachedToWindow
Snack, screenshot, or link to a repository
https://github.com/hoyelo/rn-demo

+1 to this issue


Make field names all-caps in us/dc/statewide.json

Fields other than geo-coordinates were not present in OA dataset for us/dc/statewide. It appears this issue was due to lowercasing of the field names. Made upper-case as per the field dictionary at http://maps2.dcgis.dc.gov/dcgis/rest/services/DCGIS_DATA/Location_WebMercator/MapServer/0
Fixes #1615

These look good!


custom user's table name

hi,
we didn't use default users table for users.
how to use custom table name for this?

Have you un-commented and updated the model in the config file?


Grant viewer only permissions to ci infrastructure.

It turns out we already had a group<EMAIL_ADDRESS>but
we weren't sync'ing its membership to GIT.

Grant the group logging and container viewer permission on project
kubeflow-ci and kubeflow-ci-deployment

Prune inactive members from ci-team and move others to ci-viewer.

Update update_iam_policy.sh to use the latest version of yq which
has some syntax changes.

Fix kubeflow/testing#478

This change is

/assign @kkasravi
/assign @jinchihe

/lgtm
Great thanks! @jlewi

/approve


Example Snippet Formatting

Describe the Issue
The current example snippet for JavaScript Algorithms and Data Structures -> Basic JavaScript -> Access Multi-Dimensional Arrays With Indexes has the expected output underneath the sample code. It would be clearer for campers if the expected output is moved into the example snippet.
Affected Page
https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/basic-javascript/access-multi-dimensional-arrays-with-indexes
Your code
Current Sample Snippet
const arr = [
  [1, 2, 3],
  [4, 5, 6],
  [7, 8, 9],
  [[10, 11, 12], 13, 14]
];

arr[3];
arr[3][0];
arr[3][0][1];

arr[3] is [[10, 11, 12], 13, 14], arr[3][0] is [10, 11, 12], and arr[3][0][1] is 11.
Expected behavior
It would be more concise to give the output in the Snippet.
Screenshots
No response
System

Device: [Laptop]
OS: [Windows 10]
Browser: [Chrome]
Version: []

Additional context
No response

I'd rather change it similarly to #46813. Keep the explanation below the code, and either remove arr[3](...) from it, or add concrete variables to refer to them in explanation.

@gikf that seems like a good explanation. Another way could be wrapping the array access in a console.log and comment the output beside it.

I think I agree @hanswang123456 - however, it looks like it used to be like that and they were remove here, on this PR, to streamline the translation process. It is more difficult to translate comments in code than plain text in the instructions and descriptions, so I presume that's why they were removed.
That alone might be enough reason to leave them how they are - but additionally, we want to focus our efforts on the new project based curriculum and not continue to make fixes to the soon to be legacy curriculum.
Again, I think I would prefer they be like this suggestion, but I think I would vote to leave them how they are for these reasons. I will leave this open for discussion.


Error while parsing certificate

Hi I notice that most of the time the body parameter in parse_certificate is unicode and not str, which cause an error.
i just added to the line 47:
if isinstance(body, str) or type(body) is unicode:
        body = body.encode('utf-8')

Im not sure if this is the best solution, because the first part of the condition is not necessary because x509.load_pem_x509_certificate can get a str but not unicode.
https://github.com/Netflix/lemur/blob/master/lemur/common/utils.py#L47

Are you using python 3? That latest versions (>0.4) of Lemur only use python3.


A mistake in onMeasure function.

There is a mistake in your code:
        if (childLeft + childWidth + paddingRight > myWidth) {
            childLeft = paddingLeft;
            childTop += mVerticalSpacing + lineHeight;
            lineHeight = childHeight;

Please change it to:
        if (childLeft + childWidth + paddingRight > myWidth) {
            childLeft = paddingLeft + childWidth;
            childTop += mVerticalSpacing + lineHeight;
            lineHeight = childHeight;

Sorry, have you ever run the code to see what happens if you changed the code like that ?

I agree with xyc112233
There is a mistake in the following code:
if (childLeft + childWidth + paddingRight > myWidth) {
childLeft = paddingLeft;
childTop += mVerticalSpacing + lineHeight;
lineHeight = childHeight;
} else {
childLeft += childWidth + mHorizontalSpacing;
}
change to : (This works well for me)
if (childLeft + childWidth + paddingRight > myWidth) {
childLeft = paddingLeft;
childTop += mVerticalSpacing + lineHeight;
lineHeight = childHeight;
}
childLeft += childWidth + mHorizontalSpacing;

When I use this library with scroll view it is not functioning correctly.Can I use this for  flow layout inside Scroll view?

@sleepfin I agree with you

@xyc112233 √

博主，老外说的代码问题，确实是，外层如果有ScrollView就会出现显示不全


Modernisations and prepare v0.13.1

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes issue #xyz

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Documentation has been added / updated (for bug fixes / features)
[x] HISTORY.rst has been updated (with summary of main changes)
[x] I have added my relevant user information to AUTHORS.md

What kind of change does this PR introduce?:

Prepares the next patch release
Places some lower boundary pins on existing dependencies
Sets the GitHub Actions to use version hashes

Does this PR introduce a breaking change?:
No.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>6
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 72.547%

Totals

Change from base Build<PHONE_NUMBER>6:
0.0%

Covered Lines:
1789

Relevant Lines:
2466

💛  - Coveralls


[Bug] Only update results of positions that were run

I frequently iterate through tests one by one - especially if I have multiple failing tests I will not rerun the entire file/suite but invoke neotest to run the nearest test.
In it's current implementation (with the Elixir plugin) all tests except one in a single file will be shown as skipped. I would like to keep the last known passing/failing state until I rerun the entire file.

I had in mind to solve this on the adapter side. The skips happen because when you run the nearest test, you are adding a filter to ExUnit and so ExUnit reports the other tests as skipped.
We can solve it by not reporting skipped tests if the type of position is "test".

@jfpedroza I might take a stab at it tomorrow on the adapter then. Would still be nice if neotest would be able to filter it out.

I see you changed it to a bug. Would it be possible to set it as an option?
I got the Elixir adapter to work with the test watcher I mentioned, and since it allows me to change the files to run interactively,
fixing this would make it not set the results for tests not initially run.

I might be misunderstanding, but shouldn't the test watcher only watch the tests that are chosen by the user? So if they select a specific file, then just that file is run?

Yes, but there is an interactive feature (apparently based on Jest's) that lets you change what is run, without restating the program.
You can run a file initially and then write p foo or a (and a few others) in stdin to run all tests that match foo or all tests, respectively.

Does this just work right now then? Or is more required for this kind of functionality to be properly supported?

Yes, it works. I can run a file, then change to run all tests and open a file I hadn't run before and see the status.

I'm not sure if we'll want to support this even if it does work right now because it would have some implications for https://github.com/nvim-neotest/neotest/issues/169. I'll have to see how viable it is when implementing

I see. Even without the interactive feature, it is quite useful, so it's not a big deal if test status doesn't work for positions not initially run.


pre-commit (shed) doesn't work on Windows for files with unicode in them

Quoteth @wolfmanstout:

Basically what I'm seeing is that on Windows shed skips formatting of dictation.py because of the unicode present in the file:  "skipping 'code/dictation.py' due to 'charmap' codec can't decode byte 0x9d in position 3481: character maps to <undefined>". There's nothing wrong with dictation.py -- it's legal to assume utf8 encoding in Python ... but the Windows default behavior for open() is to use the platform-default encoding instead of utf8. On windows that's "cp1252". This is apparently what shed, or one of its tools, relies on.

It's easy to repro without shed by simply opening the file and doing f.read() -- this only works if I include encoding="utf8" in the open() call, otherwise it gives the same charmap error. Like I said, I'm not sure what the best fix for this is. Ideally, there would be some flag to shed to specify the encoding in the pre-commit yaml config. Failing that, I suppose we could replace all the unicode chars in dictation.py with escapes such as \u201d instead of ”. It's fairly easy to get these using python: hex(ord("”")), which prints 0x201d. This hurts readability but it would make the file ASCII compatible.

Hope that's helpful.... sorry for the drive-by comment here but I figured better to speak up soon in case others bump into this! I noticed this when I was merging in the changes, because I saw that this file was still not black-formatted despite running pre-commit (I was following a process similar to pokey, and found this at the step where I run pre-commit on my own code).

Cool, I can reproduce it :)

Good news! This was fixed in the root project: https://github.com/Zac-HD/shed/commit/a757277a3ca282769fd7a60a8a844c4a87f68d00, v0.10.1.
Hopefully this will make it to our pre commit hooks soon.

This issue is resolved, woo-hoo! I see some minor differences between what shed produces locally vs. remotely. I also had to run pre-commit multiple times for shed to apply all its changes and it only said PASSED on the third run. I guess it's possible those are differences between shed 0.10.0 and 0.10.1. I'll follow up with you on that.

I think we can close this now with #882


In HA setup passive nodes going OOM

Description:
When run the system for some times passive node goes OOM
Suggested Labels:

Suggested Assignees:

Affected Product Version:
4.3.0
OS, DB, other environment details and versions:
Steps to reproduce:
Related Issues:

fixed in https://github.com/siddhi-io/siddhi/pull/1272 and https://github.com/wso2/carbon-analytics/pull/1676


Question: Help for writing query

I want to find records matching phone, code and date greater than a exact time.
I'm trying this but VSCode says it's wrong.
const validTime = Date.now() - 5 * 60 * 1000;
const record = await this.repo.findOne({
   $and: [{ code }, { phone }, { date: { $gte: validTime } }] });

How can I achieve this?

What error do you get? I guess you should put there Date instance, if date property is of type Date.
const record = await this.repo.findOne({
   $and: [{ code }, { phone }, { date: { $gte: new Date(validTime) } }] });

Also to and things, you do not have to use $and here, this should also work:
const record = await this.repo.findOne({ code, phone, date: { $gte: new Date(validTime) } });

I first used that but I got the same error that I'm getting right now:
Type '{ code: number; date: { $gte: number; }; phone: number; }' is not assignable to type 'string'.

I used Date type and it's working like a charm. Thank you so much!


getConnectionInfo & isConnected returns different values on different android devices

Environment
info
React Native Environment Info:
System:
OS: macOS 10.14.3
CPU: (4) x64 Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
Memory: 17.01 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 8.9.4 - /usr/local/bin/node
Yarn: 1.6.0 - /usr/local/bin/yarn
npm: 6.4.1 - /usr/local/bin/npm
Watchman: 4.4.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
Android SDK:
API Levels: 23, 25, 26, 27, 28
Build Tools: 23.0.1, 23.0.2, 23.0.3, 25.0.0, 25.0.2, 26.0.1, 26.0.2, 27.0.0, 27.0.3, 28.0.2, 28.0.3
System Images: android-23 | Intel x86 Atom_64, android-23 | Google APIs Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom
IDEs:
Android Studio: 3.0 AI-171.4408382
Xcode: 10.1/10B61 - /usr/bin/xcodebuild
npmPackages:
react: ^16.8.3 => 16.8.4
react-native: ^0.59.4 => 0.59.4
npmGlobalPackages:
create-react-native-app: 1.0.0
react-native-cli: 2.0.1
react-native-git-upgrade: 0.2.7
Platforms
Android on different brands
Versions

Android: OnePlus2 Android version 6.0, Redmi Note 4 Android version 7.0
react-native-netinfo: ^1.3.0
react-native: ^0.59.4
react: ^16.8.3

Description
I was trying to run the following codes:
NetInfo.isConnected.fetch().then(isConnected => {
   alert("Is connected", isConnected);
});

on OnePlus 2 and Xiaomi Redmi 4 while both devices are connected.
OnePlus2 return true and Redmi4 return false. With suggestion from @matt-oakes , I ran the following codes on both devices with and without internet connection.
NetInfo.getConnectionInfo().then(connectionInfo => {
  console.log("Connection type", connectionInfo.type);
  console.log("Connection effective type", connectionInfo.effectiveType);
});

Results are as following:
Redmi Note 4
Either when connected or not connected,
Connection type - unknown
Connection effective type - unknown
OnePlus2
When connected,
Connection type - wifi
Connection effective type - unknown
When not connected,
Connection type - none
Connection effective type - unknown
Reproducible Demo
I just created a simple project and run the codes on both devices.

Same happened with me on Redmi Note 4..Didn't check on other devices though.

Same for me on a Sony Tablet. The first connection type after subscribing to connectionChange is always 'unknown', even if wifi is on and connected. The only way to get a connection type 'wifi' is by turning wifi off and on after being subscribed.

@Aung-Myint-Thein Thanks for reposting this with a bit more information. It sounds like this is an issue with Android N+ devices which use the newer Android APIs. I'll check if it's happening with my Pixel and get back to you.

I've confirmed that is reproducible on Android 7.0 only (API level 24). The issue is a difference in behaviour with the callback on this and higher version. Higher versions will send the current information when you subscribe. 24 will only sent it when it changes for the first time after subscribing.
I should be able to have a fix for this soon.

It turns out the fix was pretty easy in the end. So far I've only tested on an emulator as I don't have access to the devices listed here.
@Aung-Myint-Thein @jsrsonu @turnrye Can you please follow the instructions in the description of #59 to install the module at that branch and report back over there if it fixes your issue?

It turns out the fix was pretty easy in the end. So far I've only tested on an emulator as I don't have access to the devices listed here.
@Aung-Myint-Thein @jsrsonu @turnrye Can you please follow the instructions in the description of #59 to install the module at that branch and report back over there if it fixes your issue?

It turns out the fix was pretty easy in the end. So far I've only tested on an emulator as I don't have access to the devices listed here.
@Aung-Myint-Thein @jsrsonu @turnrye Can you please follow the instructions in the description of #59 to install the module at that branch and report back over there if it fixes your issue?

It turns out the fix was pretty easy in the end. So far I've only tested on an emulator as I don't have access to the devices listed here.
@Aung-Myint-Thein @jsrsonu @turnrye Can you please follow the instructions in the description of #59 to install the module at that branch and report back over there if it fixes your issue?

I can still reproduce this issue on Android 8.0 (Honor 9) so I don't think its only related to 7.0

It is fixed. Tested on both devices and working fine. Thanks for fixing it.


WARNING: [07:12:13][Get-DbaBuildReferenceIndexOnline] Couldn't download updated index from https://sqlcollaborative.github.io/assets/d batools-buildref-index.json

We get this issue while trying to update CU14 .Any solutions .The server is behind firewall so cannot access the link.
PS C:\Users\prv-devi0p1> Get-DbaBuildReference -Build 13.0.5026 -CumulativeUpdate CU13 -Kb KB4549825 -MajorVersion "Microsoft SQL Server 2016" -ServicePack SP2 -SqlCredential Prv-devi0p1 -SqlInstance AZSU-D-DB-125 -Update
WARNING: [07:12:13][Get-DbaBuildReferenceIndexOnline] Couldn't download updated index from https://sqlcollaborative.github.io/assets/d
batools-buildref-index.json
WARNING: [07:12:13][Get-DbaBuildReferenceIndex] Index is stale, last update on: 2020-07-01T00:00:00, try the -Update parameter to fetc
h the most up to date index
WARNING: [07:12:13][Get-DbaBuildReference] Build, Kb, MajorVersion, SqlInstance are mutually exclusive. Please choose one or the other
. Quitting.

Is there a question or issue.
The warning is by design.

This is the issue we face while patching the sql servers with CU14

We cannot offer any fix in that situation. We ship the file with the module so the next release of the module will have the latest version of the file included. I believe we have already added that cu reference.
The only other option is to download the file manually and overwrite the file on your server.

The path of the local file can be found using this command:
Get-DbatoolsConfigValue -Name 'assets.sqlbuildreference'


Update hello-how-it-works-device-registration.md

Update hybrid join steps to remove confusion around requiring a user sign in

@RavennMSFT thanks for making the edit!

@denisebmsft , @Dansimp This PR can be merged as it has been approved by the document author, Matthew P. Thank you.


Earlgrey: prim_keccak.sv doesn't work in verilator

It gives error:
%Error: Failed to handle assignment

I created test: https://github.com/chipsalliance/UHDM-integration-tests/pull/379

It isn't used in opentitan now.


question about LinearRegressionOutput operator

I use the LinearRegressionOutput operator as the final layer of the net but it seems not work. A simple code like this:
import mxnet as mx

a = mx.nd.array([[1,0,0],[0,1,0]])

b = mx.nd.array([[1,0,0],[0,1,0]])

c = mx.nd.LinearRegressionOutput(data=a,label=b)

c
Out[5]: <NDArray 2x3 @cpu(0)>

c.asnumpy
Out[6]: <bound method NDArray.asnumpy of <NDArray 2x3 @cpu(0)>>

c.asnumpy()
Out[7]:
array([[ 1.,  0.,  0.],
       [ 0.,  1.,  0.]], dtype=float32)

It's strange and I'm confused.

c is the output of forward propagation, it's itself for LinearRegression
see RegressionOutputOp

LinearRegressionOutput
The forward pass is an identical mapping. Go checking the gradient value.

This issue is closed due to lack of activity in the last 90 days. Feel free to ping me to reopen if this is still an active issue. Thanks!


SSL support for Exposer

Exposer should use SSL - different civetweb build options needed
https://github.com/jupp0r/prometheus-cpp/issues/329
https://github.com/civetweb/civetweb/blob/master/docs/OpenSSL.md

not going to make this public any time soon, move out of milestone


Apparent logical error in GPU loss

In the cutoff index dependent conditional for updating loss, head_logprob appears to be used before it is ever defined.
https://github.com/kimiyoung/transformer-xl/blob/44781ed21dbaec88b280f74d9ae2877f52b492a5/tf/model.py#L297

it's defined at https://github.com/kimiyoung/transformer-xl/blob/44781ed21dbaec88b280f74d9ae2877f52b492a5/tf/model.py#L293


Unable to add tags to Span created by Lambda Wrapper

Expected Behavior
After using tracer.SpanFromContext() to get the span, the function span.SetTag() should set a tag on the span.
Actual Behavior
No tags are added, and none can be changed.
Steps to Reproduce the Problem

Wrap your lambda handler with ddlambda.WrapFunction
Get the span from the context in your handler with tracer.SpanFromContext()
Use span.SetTag() to set a custom tag
Check APM. The tag is not present on the span.

Specifications

Datadog Go Lambda package version: 1.8.0
Go version: 1.19.x

Stacktrace
N/A

Hey @ScidaJ,
Sorry for taking long to respond. I was not able to reproduce your problem. Could you share more details? Are you using the provided runtime go1x or are you using provided|provided.al2? What about the code?
I was successful when adding more tags to my spans.

On a child span.

Perhaps you forgot to send the context?
Let me know if you can provide more details!
Thanks

Unfortunately I have since been laid off and no longer have access to the project that this error applies to.

I'm really sorry to hear this @ScidaJ :( Some early career roles open in august. You can always apply at our careers page if you're interested in joining Datadog!

Closing issue – if anyone came into the same issue with reproduction steps, please feel free to re-open this ticket or create a new one.


Crashes when loading main menu

Describe your problem here.
So everytime I hit enter on the title screen and it fades to black the game crashes. This only happens every once in a while and works again after sometime( I'm using version 0.5.2h)
Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
Stuff in TitleState.hx such as logo tween and replaced gf

it has something to do with the "friday_night_play" achievement to fix it open MainMenuState.hx press Control+F and search friday_night_play and delete all mentions of it

it has something to do with the "friday_night_play" achievement to fix it open MainMenuState.hx press Control+F and search friday_night_play and delete all mentions of it

I don't think it is
because everytime I unlocked it my game doesnt go boom boom


Update Helm release shoot-networking-problemdetector to v0.22.0 (main)

This PR contains the following updates:

Package
Update
Change

shoot-networking-problemdetector
minor
0.21.0 -> 0.22.0

Release Notes

gardener-community/gardener-charts (shoot-networking-problemdetector)
v0.22.0
Compare Source
[gardener/network-problem-detector]
🏃 Others

[OPERATOR] Allow nodes without hostname by @MartinWeindel [gardener/network-problem-detector#66]
[OPERATOR] Bumps golang from 1.22.2 to 1.22.3. by @dependabot[bot] [gardener/network-problem-detector#65]

[gardener/gardener-extension-shoot-networking-problemdetector]
🏃 Others

[OPERATOR] This extension is now using the new way of providing monitoring configuration (ref GEP-19) in case a shoot cluster's Prometheus has been migrated to management via prometheus-operator. by @rfranzke [#142]
[OPERATOR] Bumps github.com/gardener/gardener from 1.94.0 to 1.95.0. by @dependabot[bot] [#144]

Docker Images

gardener-extension-shoot-networking-problemdetector: europe-docker.pkg.dev/gardener-project/releases/gardener/extensions/shoot-networking-problemdetector:v0.22.0

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠ Warning: custom changes will be lost.


Issue 1556 - Handle split files in partition splitting

Make sure you have checked all steps below.
Issue

[x] My PR addresses the following issues and references them in the PR title. For example, "Issue 1234 - My Sleeper
PR"

Resolves https://github.com/gchq/sleeper/issues/1556

Tests

[x] My PR adds the following tests OR does not need testing for this extremely good reason:

FindPartitionsToSplitTest

Documentation

[x] In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
separate issue for that below.
[x] If I have added, removed, or updated any external dependencies used in the project, I have updated the
NOTICES file to reflect this.

We can avoid merging this until we're ready to merge the parent issue:

https://github.com/gchq/sleeper/issues/1365

This should have been auto-closed when https://github.com/gchq/sleeper/pull/1588 was merged, as all this PR's commits were included in that merge. Closing.


Reintroduce opts prop for the SelectComponent

This pull request fixes #220 by reintroducing the opts props for the SelectComponent

@Malian thanks! ❤


Export of large database fails. Should be more robust.

Describe the bug
Prisma export fails as soon as the database fails to give a timely response once.
To Reproduce
Steps to reproduce the behavior:

Have a large database on Aurora MySQL (But I suspect this is not specific to this). Since the database is large and needs thousands of queries to export, chances are that one of these queries will time out, breaking the entire export.

Expected behavior
Prisma export should retry queries after waiting a little bit when they fail, instead of failing.
Screenshots
2019-05-08T18:08:13.211Z client Downloading from http://localhost:4466/sterblue/dev/export
2019-05-08T18:08:13.211Z client {"fileType":"nodes","cursor":{"table":11,"row":110328,"field":0,"array":0}}
Wed, 08 May 2019 18:09:08 GMT Exporter { out:
   { jsonElements:
      [ [Object],
        [Object],
        [Object],
    ...
        [Object],
        [Object],
        [Object],
        [Object],
        ... 5 more items ],
     size: 998098 },
  cursor: { table: 11, row: 110433, field: 0, array: 0 },
  isFull: true }
2019-05-08T18:09:08.267Z client Downloading from http://localhost:4466/sterblue/dev/export
2019-05-08T18:09:08.267Z client {"fileType":"nodes","cursor":{"table":11,"row":110433,"field":0,"array":0}}
Wed, 08 May 2019 18:10:08 GMT Exporter { errors:
   [ { message: '(conn=472844) Connection timed out',
       requestId: 'local:cjvfjef3f02vm0759hkyh4z14' } ] }
 !
Error: [object Object]
    at Exporter.<anonymous> (/home/ec2-user/.nvm/versions/node/v8.12.0/lib/node_modules/prisma/node_modules/prisma-cli-core/src/commands/export/Exporter.ts:121:15)
    at step (/home/ec2-user/.nvm/versions/node/v8.12.0/lib/node_modules/prisma/node_modules/prisma-cli-core/dist/commands/export/Exporter.js:32:23)
    at Object.next (/home/ec2-user/.nvm/versions/node/v8.12.0/lib/node_modules/prisma/node_modules/prisma-cli-core/dist/commands/export/Exporter.js:13:53)
    at fulfilled (/home/ec2-user/.nvm/versions/node/v8.12.0/lib/node_modules/prisma/node_modules/prisma-cli-core/dist/commands/export/Exporter.js:4:58)
    at <anonymous>
    at process._tickDomainCallback (internal/process/next_tick.js:229:7)
Exiting with code: 1

Versions (please complete the following information):

Connector:MySQL
Prisma Server: 1.23.4
prisma CLI: 1.23.4
OS: Ubuntu 16.04

Workaround is coding myself in nodejs an export script, but ideally prisma export should have the correct behaviour.


Autoscope fix

simple fix for autoscope

there is a way easier to do this

there is a way easier to do this

how does it get simpler than this

this
if (config->ragebot[weaponIndex].scopedOnly && activeWeapon->isSniperRifle() && !localPlayer->isScoped() && localPlayer->flags() & 1 ) {
if (config->ragebot[weaponIndex].autoScope)
        cmd->buttons |= UserCmd::IN_ATTACK2;
   return;
}

on here

Another method
if (cmd->buttons & UserCmd::IN_ATTACK && config->aimbot[weaponIndex].autoScope && activeWeapon->isSniperRifle()) {
    if (!localPlayer->isScoped()) {
        cmd->buttons &= ~UserCmd::IN_ATTACK;
        cmd->buttons |= UserCmd::IN_ZOOM;
    }
}

struct UserCmd {
    enum {
        ...

Then why you made autoscope if its not made to work?

bruh fix it or remove from gui then

It breaks "Auto shot" with low "Max angle delta" values.

what does max angle delta even do

@mkot2  maximum viewangles change per tick

@mkot2 maximum viewangles change per tick

oh for like aimstep?


Highlight Patreon Supporters on Website

Highlight our Patreon supporters on a new "Supporters" page https://techqueria.org/supporters
Name: "Supporters 💛 "
Description: "We want to recognize our Patreon supporters for their financial support."
Image: See attachment, make sure to make download to repo and make it a locally referenced image

Use their Twitter, not Patreon accounts for linking and make sure to include a high-res image
Each supporter should have their own card with an image, name and brief description
These are our current 3 supporters on Patreon:

Phillip Ventura: https://www.patreon.com/user/creators?u=14572309
Javier Lopez: https://www.patreon.com/cupto/creators
Xande Macedo: https://www.patreon.com/xande/creators

✅ By submitting this issue, I have verified the following

[x] Checked to see if the issue has already been discussed before 🤔
[x] Made sure enough details were provided if proposing a new feature 🔍

Hi @fvcproductions, I'm working on creating the "Supporters" page tonight.

Hey @fvcproductions, I put Phillip's LinkedIn for now, because I can't find his twitter account anywhere.


Be shell-type agnostic

All the things will work well on macOS with bash and probably also within linux systems with bash fired up, but we should make RubyStan agnostic of the choice of underlying shell commands, i.e. zsh is also widely in use and probably others, too.

Fortunately, I think this is not a problem 🎉


Remove forloop in CoreEventController::coreUpdate as activeRegion should propagate update calls.

Should the default GameRegion::update contain this forloop who people can call baseclass::update for?

unnecessary with #143


Added support for python 3.8 and dropped support for older Django versions

this PR updates

setup classifiers
Travis configurations
tox configurations
Drops support for Django versions less than 2.2

Relevant JIRA issue here.

@morenol changes made as suggested


Additional fix for vector access.

See https://github.com/apache/incubator-mxnet/commit/9634786f96388004f68c223d72e120ad425c2f12 for the original.
Description
Fixes an assertion thrown by operator[] of std::vector when MxNet is compiled with certain STL hardening flags, especially since GCC 8. This pull request is to fix a small block that was missed in the original PR.

Hi @aws-taylor , I could not retrigger the CI.
Could you please retrigger it (push an empty commit)? Thank you!

The PR has been merged. Thank you!


Issue on RN 0.48.3

We love your work, keep it up !

Could you provide a reproduction repo for debugging?

@dzhunglht does this occur after creating a brand new (untouched) module?


Update sbt-release to 1.0.10

Updates com.github.gseitz:sbt-release from 1.0.9 to 1.0.10.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention @scala-steward in the comments below.
Have a nice day!

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #36   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           6      6
  Lines          84     84
  Branches        6      6
=====================================
  Hits           84     84

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 578561e...9be5005. Read the comment docs.


Add dask dataframe to gridsearchcv

What does this PR implement?
Adds Dask DataFrame support to GridSearchCV.

i checked the errors. it seems to be timing out. do the parameters for the CI need to be changed ?

Trying to debug that in https://github.com/dask/dask-ml/pull/613.

CI may be fixed, if you merge master and re-push.

Thanks Tom!
On Wed, Feb 26, 2020 at 7:23 AM Tom Augspurger<EMAIL_ADDRESS>wrote:

CI may be fixed, if you merge master and re-push.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://urldefense.com/v3/__https://github.com/dask/dask-ml/pull/612?email_source=notifications&email_token=AAEY2GWXVYJ7BAG4KTO6D3LREZNMRA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENAAT5I*issuecomment-591399413__;Iw!!EFVe01R3CjU!NU9IzZuerK1K7efsWwna5sT3lDtLRvm-QrPZIWwqWwHy-v27x8INFz2JGH3lTATfi2U6jNY$,
or unsubscribe
https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AAEY2GXASKELMNTUWOJY2JDREZNMRANCNFSM4KXQ6SOQ__;!!EFVe01R3CjU!NU9IzZuerK1K7efsWwna5sT3lDtLRvm-QrPZIWwqWwHy-v27x8INFz2JGH3lTATffVHE0DY$
.

--
Mike McCarty | Director, Software Engineer | C4ML: Development Tools and
Accelerators
(M)<PHONE_NUMBER>  |<EMAIL_ADDRESS>
The information contained in this e-mail is confidential and/or proprietary to Capital One and/or its affiliates and may only be used solely in performance of work or services for Capital One. The information transmitted herewith is intended only for use by the individual or entity to which it is addressed. If the reader of this message is not the intended recipient, you are hereby notified that any review, retransmission, dissemination, distribution, copying or other use of, or taking of any action in reliance upon this information is strictly prohibited. If you have received this communication in error, please contact the sender and delete the material from your computer.

Green build. What do you think @TomAugspurger ?

Green build. What do you think @TomAugspurger ?

@TomAugspurger @mmccarty the gridsearchcv example you have merged uses sklearn gridsearchcv.
Does that distribute on dask ? or should you update to use dask-ml gridsearchcv ?

What example?
On Mon, Mar 9, 2020 at 10:18 AM Sandeep Srinivasa<EMAIL_ADDRESS>wrote:

@TomAugspurger https://github.com/TomAugspurger @mmccarty
https://github.com/mmccarty the gridsearchcv example you have merged
uses sklearn gridsearchcv.
Does that distribute on dask ? or should you update to use dask-ml
gridsearchcv ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-ml/pull/612?email_source=notifications&email_token=AAKAOIVR4ZAEDCDJMPFAH4LRGUCEFA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHU5AI#issuecomment-596594305,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKAOIWC2CVRR37OPB2WUGLRGUCEFANCNFSM4KXQ6SOQ
.

This is the example that was committed as part of the PR
https://github.com/mmccarty/dask-ml/blob/4b5b3ce5858250e4e285ab887ab690cc1ebedaa9/tests/model_selection/dask_searchcv/test_model_selection.py#L334-L351
On Mon, 9 Mar, 2020, 20:49 Tom Augspurger<EMAIL_ADDRESS>wrote:

What example?
On Mon, Mar 9, 2020 at 10:18 AM Sandeep Srinivasa <
<EMAIL_ADDRESS>wrote:

@TomAugspurger https://github.com/TomAugspurger @mmccarty
https://github.com/mmccarty the gridsearchcv example you have merged
uses sklearn gridsearchcv.
Does that distribute on dask ? or should you update to use dask-ml
gridsearchcv ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/dask/dask-ml/pull/612?email_source=notifications&email_token=AAKAOIVR4ZAEDCDJMPFAH4LRGUCEFA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHU5AI#issuecomment-596594305
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAKAOIWC2CVRR37OPB2WUGLRGUCEFANCNFSM4KXQ6SOQ
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-ml/pull/612?email_source=notifications&email_token=AAASYUYTUUIUHBS36OJH6CDRGUCJ7A5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHVDYQ#issuecomment-596595170,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAASYU2PJT7ZND2TQ3VVQBTRGUCJ7ANCNFSM4KXQ6SOQ
.

That's a test checking Dask-ML's result against scikit-learn's, unless I'm
missing something..
On Mon, Mar 9, 2020 at 10:39 AM Sandeep Srinivasa<EMAIL_ADDRESS>wrote:

This is the example that was committed as part of the PR
https://github.com/mmccarty/dask-ml/blob/4b5b3ce5858250e4e285ab887ab690cc1ebedaa9/tests/model_selection/dask_searchcv/test_model_selection.py#L334-L351
On Mon, 9 Mar, 2020, 20:49 Tom Augspurger<EMAIL_ADDRESS>wrote:

What example?
On Mon, Mar 9, 2020 at 10:18 AM Sandeep Srinivasa <
<EMAIL_ADDRESS>wrote:

@TomAugspurger https://github.com/TomAugspurger @mmccarty
https://github.com/mmccarty the gridsearchcv example you have merged
uses sklearn gridsearchcv.
Does that distribute on dask ? or should you update to use dask-ml
gridsearchcv ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<

https://github.com/dask/dask-ml/pull/612?email_source=notifications&email_token=AAKAOIVR4ZAEDCDJMPFAH4LRGUCEFA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHU5AI#issuecomment-596594305

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AAKAOIWC2CVRR37OPB2WUGLRGUCEFANCNFSM4KXQ6SOQ

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/dask/dask-ml/pull/612?email_source=notifications&email_token=AAASYUYTUUIUHBS36OJH6CDRGUCJ7A5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHVDYQ#issuecomment-596595170
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAASYU2PJT7ZND2TQ3VVQBTRGUCJ7ANCNFSM4KXQ6SOQ
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-ml/pull/612?email_source=notifications&email_token=AAKAOIXXZI52N4L5PJGDN3TRGUETLA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHX5JQ#issuecomment-596606630,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKAOIQ7X3TYONXTWIEC6HTRGUETLANCNFSM4KXQ6SOQ
.

Not denying that. I'm wondering if that distributes on Dask or whether the
more appropriate example would have been gridsearchcv on dask-ml.
Ultimately if gridsearchcv on sklearn does not distribute... then would the
example be relevant for actual use ?
On Mon, 9 Mar, 2020, 21:13 Tom Augspurger<EMAIL_ADDRESS>wrote:

That's a test checking Dask-ML's result against scikit-learn's, unless I'm
missing something..
On Mon, Mar 9, 2020 at 10:39 AM Sandeep Srinivasa <
<EMAIL_ADDRESS>wrote:

This is the example that was committed as part of the PR

https://github.com/mmccarty/dask-ml/blob/4b5b3ce5858250e4e285ab887ab690cc1ebedaa9/tests/model_selection/dask_searchcv/test_model_selection.py#L334-L351

On Mon, 9 Mar, 2020, 20:49 Tom Augspurger<EMAIL_ADDRESS>wrote:

What example?
On Mon, Mar 9, 2020 at 10:18 AM Sandeep Srinivasa <
<EMAIL_ADDRESS>wrote:

@TomAugspurger https://github.com/TomAugspurger @mmccarty
https://github.com/mmccarty the gridsearchcv example you have
merged
uses sklearn gridsearchcv.
Does that distribute on dask ? or should you update to use dask-ml
gridsearchcv ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<

https://github.com/dask/dask-ml/pull/612?email_source=notifications&email_token=AAKAOIVR4ZAEDCDJMPFAH4LRGUCEFA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHU5AI#issuecomment-596594305

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AAKAOIWC2CVRR37OPB2WUGLRGUCEFANCNFSM4KXQ6SOQ

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<

https://github.com/dask/dask-ml/pull/612?email_source=notifications&email_token=AAASYUYTUUIUHBS36OJH6CDRGUCJ7A5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHVDYQ#issuecomment-596595170

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AAASYU2PJT7ZND2TQ3VVQBTRGUCJ7ANCNFSM4KXQ6SOQ

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<
https://github.com/dask/dask-ml/pull/612?email_source=notifications&email_token=AAKAOIXXZI52N4L5PJGDN3TRGUETLA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHX5JQ#issuecomment-596606630
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAKAOIQ7X3TYONXTWIEC6HTRGUETLANCNFSM4KXQ6SOQ
.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-ml/pull/612?email_source=notifications&email_token=AAASYU752H3EGMEGK4OEU6DRGUFDLA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHYQEY#issuecomment-596609043,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAASYU6BR2GF2EVG32HHQR3RGUFDLANCNFSM4KXQ6SOQ
.

I'm not sure I follow, but I think the test looks OK.
On Mon, Mar 9, 2020 at 10:47 AM Sandeep Srinivasa<EMAIL_ADDRESS>wrote:

Not denying that. I'm wondering if that distributes on Dask or whether the
more appropriate example would have been gridsearchcv on dask-ml.
Ultimately if gridsearchcv on sklearn does not distribute... then would the
example be relevant for actual use ?
On Mon, 9 Mar, 2020, 21:13 Tom Augspurger<EMAIL_ADDRESS>wrote:

That's a test checking Dask-ML's result against scikit-learn's, unless
I'm
missing something..
On Mon, Mar 9, 2020 at 10:39 AM Sandeep Srinivasa <
<EMAIL_ADDRESS>wrote:

This is the example that was committed as part of the PR

https://github.com/mmccarty/dask-ml/blob/4b5b3ce5858250e4e285ab887ab690cc1ebedaa9/tests/model_selection/dask_searchcv/test_model_selection.py#L334-L351

On Mon, 9 Mar, 2020, 20:49 Tom Augspurger<EMAIL_ADDRESS>wrote:

What example?
On Mon, Mar 9, 2020 at 10:18 AM Sandeep Srinivasa <
<EMAIL_ADDRESS>wrote:

@TomAugspurger https://github.com/TomAugspurger @mmccarty
https://github.com/mmccarty the gridsearchcv example you have
merged
uses sklearn gridsearchcv.
Does that distribute on dask ? or should you update to use dask-ml
gridsearchcv ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<

https://github.com/dask/dask-ml/pull/612?email_source=notifications&email_token=AAKAOIVR4ZAEDCDJMPFAH4LRGUCEFA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHU5AI#issuecomment-596594305

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AAKAOIWC2CVRR37OPB2WUGLRGUCEFANCNFSM4KXQ6SOQ

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<

https://github.com/dask/dask-ml/pull/612?email_source=notifications&email_token=AAASYUYTUUIUHBS36OJH6CDRGUCJ7A5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHVDYQ#issuecomment-596595170

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AAASYU2PJT7ZND2TQ3VVQBTRGUCJ7ANCNFSM4KXQ6SOQ

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<

https://github.com/dask/dask-ml/pull/612?email_source=notifications&email_token=AAKAOIXXZI52N4L5PJGDN3TRGUETLA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHX5JQ#issuecomment-596606630

,
or unsubscribe
<

https://github.com/notifications/unsubscribe-auth/AAKAOIQ7X3TYONXTWIEC6HTRGUETLANCNFSM4KXQ6SOQ

.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
https://github.com/dask/dask-ml/pull/612?email_source=notifications&email_token=AAASYU752H3EGMEGK4OEU6DRGUFDLA5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHYQEY#issuecomment-596609043
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AAASYU6BR2GF2EVG32HHQR3RGUFDLANCNFSM4KXQ6SOQ
.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask-ml/pull/612?email_source=notifications&email_token=AAKAOIU6RSYRVHNQW7NHLMLRGUFQ3A5CNFSM4KXQ6SO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOHY7ZA#issuecomment-596611044,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAKAOIXNWB6FSTMXN72GIT3RGUFQ3ANCNFSM4KXQ6SOQ
.

I am getting this issue even when my inputs to the dask_ml.model_selection.GridSearchCV function is a dask dataframe
Code below:
import dask
import joblib
import numpy as np
import pandas as pd
import dask.dataframe as dd
from dask_ml.preprocessing import StandardScaler
from dask_ml.preprocessing import Categorizer, OrdinalEncoder
from dask.distributed import Client
data = pd.DataFrame({"x0":[1,1,2,2,2,2,2,1,1], "x1":[1,1,3,5,5,5,5,1,1],
"x2": [1.5,2.6,0,0,0,0,0,1.3,3.7], "x3":[1,1,1,1,2,1,2,1,1],	"x4" :["N","N","N","N","N","N","N","Y","N"],
"x5" :[151,239,236,193,193,193,193,163,229], "x6":[239,246,236,193,193,193,193,229,7],
"x7":[1,1,1,2,2,2,2,1,1],	"x8":[7,14,4.5,3.5,52,3.5,52,6.5,13.5],
"x9":[0.5,0.5,0.5,0.5,0,0.5,0,0.5,0.5], "x10":[0.5,0.5,0.5,0.5,0.5,0.5,0.5,0.5,0.5],
"x11":[1.65,1,0,0,0,0,0,1.25,3.7], "x12":[0,0,0,0,0,5.76,0,0,0],
"x13":[0.3,0.3,0.3,0.3,0.3,0.3,0.3,0.3,0.3],	"target":[9.95,16.3,5.8,7.55,55.55,13.31,55.55,9.05,18.5]})
data = dd.from_pandas(data,npartitions=1)
label_vars = ['x0', 'x1', 'x3', 'x4', 'x7', 'x9', 'x10', 'x13']
numeric_vars = ['x2', 'x5', 'x6', 'x8', 'x11', 'x12']
cat = Categorizer(columns=label_vars)
data= cat.fit_transform(data)
en = OrdinalEncoder(columns=label_vars)
data = en.fit_transform(data)
sc = StandardScaler()
data[numeric_vars] = sc.fit_transform(data[numeric_vars])
X=data.drop(["target"], axis = 1)
y=data["target"]
client = Client(processes=False)
with joblib.parallel_backend('dask'):
model1 = RandomForestRegressor()
params = {'max_depth': [3,4,5], 'n_estimators':[100,200,300,400,500], 'min_samples_split':
[2,3,4,5,6], 'min_samples_leaf': [1, 3]}
model = GridSearchCV(model1,params)
model.fit(X,y)
#----------------------Error----------------------------#
X-type:<class 'dask.dataframe.core.DataFrame'>, Y-type:<class 'dask.dataframe.core.Series'>
Traceback (most recent call last):
File ".\testing_dask_inprogress.py", line 290, in
model.fit(X,y)
File "C:\Users\SONY\miniconda3\lib\site-packages\dask_ml\model_selection_search.py", line 1233, in fit
cache_cv=self.cache_cv,
File "C:\Users\SONY\miniconda3\lib\site-packages\dask_ml\model_selection_search.py", line 203, in build_cv_graph
X_name, y_name, groups_name = to_keys(dsk, X, y, groups)
File "C:\Users\SONY\miniconda3\lib\site-packages\dask_ml\model_selection\utils.py", line 87, in to_keys
assert not is_dask_collection(x)
AssertionError


ERB template for SDF with varying friction parameters

This is a small PR, though the line diff looks huge because of an OBJ mesh file.
It builds on #160 for biofouling.
This adds a basic ERB template to generate SDF files with different friction parameters, based on a parameter currently called fouling_rating. The SDF file wraps around the distorted mesh models generated by #160.
Since I'm not familiar with the maths of friction and don't know what the parameters mean, I've only put in a small proof of concept on mu. I'm open to feedback after the release as to how exactly we want to vary those parameters, what they mean, etc.
The main file is the ERB template urdf/scripts/sdf_custom_properties/coke_template.erb, with README in the same directory detailing usage.
Most other files are reference files (with .ref in the file name so that they don't get overwritten by generated files) as examples of generated output.
This is just an initial proof of concept, to keep PRs bite size, with future iterations expected.
I might have another PR before the release if I get custom XML tags done.
To test
Follow the README at urdf/scripts/sdf_custom_properties/README.md.
You should see something like these in Gazebo for the 2 distorted coke cans:

A note on friction parameters
If people already have in mind (I don't) which exact friction parameters need to be varied, that would make it easy.
For those unfamiliar, including me, there are friction_demo.world and torsional_friction_demo.world.erb examples upstream in Gazebo 11.
<collision> tag is documented here http://sdformat.org/spec?ver=1.8&elem=collision
I think the main tags of interest are <friction> (which has sub-tags of <torsional>, <ode>, <bullet> ) and maybe <contact> (which has sub-tags of <ode>, <bullet>, and a few other parameters).
One thing to note is that the <ode> tag is read by more than just ODE, but other engines as well unless other if-statements in the code indicate otherwise. This part is not very well documented. We have a ticket upstream saying the friction parameters in SDF need to be better documented (linked at the bottom of the README).

Thank you!


Nuget Packages

We have compiled the source and are using it but not having Nuget references is quite a pain because the new project nuget packaging relies on package references for dependencies and not external assemblies.
It seems pretty straightforward for you to ship Nuget packages so please can we get packages for HealthChecks!

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e98bdd99-d89d-8720-9018-25f73dcfdbd8
Version Independent ID: c02edf4f-eb03-f02a-c72d-510cc17c8c9e
Content: Health monitoring
Content Source: docs/standard/microservices-architecture/implement-resilient-applications/monitor-app-health.md
Product: dotnet
GitHub Login: @CESARDELATORRE
Microsoft Alias: wiwagn

Same opinion as OliverRC, why not shipping this lib as NuGet(s) package(s)?
Any roadmap/date planned for this library to be available as a NuGet ?

As of Oct 2018, some of the content in this page is now out of date.
The Github repo linked at the beginning of the article is now deprecated, and the source has moved into the ASP.NET Diagnostics sub repo, and will be included in ASP.NET Core v2.2 when it releases by the end of 2018.
Please see this: https://github.com/aspnet/Diagnostics/tree/release/2.2/src
If you are insterested in Nuget packages and don't mind running pre-release software, you can get the pre-release version of the Nuget packages which have been renamed as Microsoft.AspNetCore.Diagnostics.HealthChecks, and is now found at https://www.nuget.org/packages/Microsoft.AspNetCore.Diagnostics.HealthChecks

@CESARDELATORRE @mvelosop can you please take a look at this issue for the microservices e-book?

Hi @mairaw, this page has been updated in the upcoming PR.
Also added the comment on the 2.2 release, but don't suggest trying the NuGet package because it depends on 2.2 and eShopOnContainers hasn't been tested on 2.2.


Fix glitch on term resize with some prompts

With some prompts which use end of line, quick repeated resizes cause a glitch.
This glitch occurs when resize is dispatched during hterm redraw.
We can't know when hterm finished to rerender after a resize. So we can't make these resizes sequentially.
The only solution I found is to debounce Term onResize calls.
These calls must be debounced per uid.
Before

After

@chabou Have you tried with _.throttle to keep the UI responsive to movements? Make it a little more fluid.

Yeah I tried but it doesn't work as well.
Because, it doesn't prevent to have resize event during hterm redraw. It reduce it, but the more we want a fluid resize, the more the race condition (and the glitch) occurs.
Technically, debounce doesn't prevent it totally but reduce time window at a minimum.
I'm not really satisfied with this solution (less fluid and ugly debounce), but I don't see another one. Keep this glitch is acceptable too 😄
Thank you for your feedback.

@chabou relevant for xterm?

Too early to know that but I hope it will not be relevant...


Zap crashes only when sending to blockstream

Using zap wallet on windows to interface with an lnd instance running on ubuntu. Sending payments are normally fine, but whenever I pay an invoice from blockstream zap just goes blank. The blue window is still there, but the program must be stop and re-started to get working again. This last time, I can't even get zap to load again. This has happened several times now (only with broadcasting a message from blockstream). Interesting thing is, everytime this has happened, the payment still seems to go through and it shows up on my transaction list after reloading the program. I'm going to reboot and see if I can even get the program to re-load again.

Alright, so I just rebooted and figured out why I couldn't get zap to reload at all (my lnd machine wasn't connected) BUT, the original problem still stands. After reloading zap, I sent another test payment to blockstream and again, the zap client hung and I had to close it out (which happened no problem). On re-load the transaction was shown as being sent in the history, so the payment is going through, it's likely some UI issue. No idea why it only does it for blockstream and nowhere else.

@th3geek what version of Zap are you using?

0.3.4-beta   ... And here's where I'm trying to send (only costs a few sats to test)  https://blockstream.com/satellite-queue/

@th3geek are you able to test this with the latest code in the master branch?

Please can you upgrade to Zap 0.4.0 and let us know if the issue persists. Thanks.

That fixed it. Thank you very much!


Describe why/how to prevent large data files in repository

In the section on version control, we will probably want to mention that it is bad practice to upload large data files. This can be easily be prevented by adding typical data files extensions to .gitignore when using git.

This would fit better in The Turing Way


shallow merge style object if present in both props and attrs

Fixes #1849

I tried to figure how to do this for RN as well but couldn't figure out how "style" is handled from attrs. It doesn't seem like we create a new StyleSheet using that injection vector, so does it even work?


Bundle CycloneDX schemas

The CycloneDX schema references two other schemas. These are fetched dynamically when the schema is first compiled in rego. This is not ideal because it requires accessing an external server. This commit takes those additional schemas and bundles[1] them making it possible to validate a CycloneDX SBOM completely offline.
[1] https://json-schema.org/understanding-json-schema/structuring#bundling
Fixes #1185

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (cacea1d) to head (0150c9d).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #1187   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files          120       120
  Lines         6254      6254
=========================================
  Hits          6254      6254

Files with missing lines
Coverage Δ

policy/release/sbom_cyclonedx_schema.rego
100.00% <ø> (ø)

... and 34 files with indirect coverage changes

Do we need to worry about this with spdx?

Do we need to worry about this with spdx?

No because there are no refs there.
We should probably have something to prevent this from happening again in the future. I was looking for a command to create the bundle automatically but couldn't find something ready to use. I just created the bundle by hand. I'll file an issue for that next week.
Probably low priority as schema changes are rare events, including adding support for new versions.

We should probably have something to prevent this from happening again in the future.

I think we should run tests without network, see #1188


Change libgit2.github.com to libgit2.github.io or libgit2.org

GitHub Pages will stop redirecting Pages sites from *.github.com after April 15, 2021: https://github.blog/changelog/2021-01-29-github-pages-will-stop-redirecting-pages-sites-from-github-com-after-april-15-2021/

Thanks @ouuan!  I've fixed our links to reference libgit2.org and updated the name of this repo.

There's one more link in the repository settings:


Create a new pull request by comparing changes across

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.697%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
2026

Relevant Lines:
2079

💛  - Coveralls


Fix git push error for protected CLA branch

The pull request is created from master636935388727027498 to master to fix git push error for protected CLA branch

@Taojunshen : Thanks for your contribution! The author, @, has been notified to review your proposed change.


batch/script didnt get made

Bug Report
no cmd/sh was created
System Information

Operating System Windows Server 2016
AMP version and build date AMP Release "TITAN" v20191003.2, built 03/10/2019 14:17
Which AMP release stream you're using Nightly

I confirm:

[x] that I have searched for an existing bug report for this issue.
[x] that I am using the latest available version of AMP.
[x] that my operating system is up-to-date.

Symptoms
should be creating new file when it turn on Monitoring.ProduceStartupScripts=True
Reproduction
after used instances started

have change yet
output from log
Console Listener setup OK
Performing version check against: https://api.kanersps.pw/em/version?version=6.2.2&uuid=b621bda2-a182-4ce9-7a65-8a1172da9b36
Started map fivem-map-skater
Started resource fivem-map-skater
Authenticating with Nucleus...
server thread hitch warning: timer interval of 6573 milliseconds
[EssentialMode] Current version: 6.2.2
[EssentialMode] Updater version: 6.2.2
[EssentialMode] Everything is nice and updated!
[vMenu] Checking for updates.
[vMenu] For info, check https://docs.vespura.com/vmenu
[vMenu] Your version of vMenu is up to date! Good job!
server thread hitch warning: timer interval of 666 milliseconds
fff
cccc ff   xx  xx     rr rr    eee
cc     ffff   xx       rrr  r ee   e
cc     ff     xx   ... rr     eeeee
ccccc ff   xx  xx ... rr      eeeee
Authenticated with cfx.re Nucleus:

This setting requires that Security.LogSensitiveProcArgs is enabled.

yes it is enabled as well but nothing happen

https://pastebin.com/b4YhbG7v

It'll create the scripts in the working directory of the instance, you won't see them in the file manager.

like this am not seeing them

You need to be a directory higher up...

oh this

look like it recreate by day, when i ran by double click  on the it run but stuck on


fix(Dropzone): Update react-dropzone version from 11.3.2 to 14.2.3.

Issue: #1146
What I did

Screenshots:

Checklist

[ ] changeset has been added
[ ] Pull request description is descriptive
[ ] I have made corresponding changes to the documentation
[ ] New and existing unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works

How to test

Closing in favor of #1362


aardvark: only use systemd-run when systemd is available

According to sd_booted(3) checking if /run/systemd/system exists is good
enough to see if systemd is booted.
While this check is not perfect it will at least allow us to use it
inside a container where systemd binaries are installed but the
container is run without systemd, see
https://github.com/containers/podman/issues/13533
Another option would be to use the systemd dbus API. I gave it a try but
couldn't figure out the exact format we have to send and also had
trouble connecting to the rootless session.
For now this should help to get aardvark working inside a container.

@mheon @baude @flouthoc PTAL

GH is down :|


Use CDN when fetching source files

Currently we are using raw.githubusercontent.com to fetch source files in browsers. However, some people (e.g. in Mainland China) may have problems accessing the resources. Using a CDN both solves the inconvenience and accelerates browsing.
I suggest using jsDelivr given it is widely used and works in Mainland China.
This PR:

Use jsDelivr when browsers fetch manual files
Use jsDelivr when browsers fetch registry files

If you think the change only benefits particular people, we can make it a switch.

Are there issues in mainland china regarding reaching GitHub? Because if this is the case it might be worth considering, but it would be great to introduce as little extra hops as possible. If this works we should keep it because it makes it very transparent to the user what is happening, and we are not introducing another party that you need to trust when using /x.

Are there issues in mainland china regarding reaching GitHub?

Part of GitHub is blocked (gist.github.com), *.githubusercontent.com is generally slow or inaccessible (because GitHub uses AWS which has poor support in Mainland China).

we are not introducing another party that you need to trust when using /x.

Loading scripts in Deno goes through CloudFlare and should not be worried about. This PR only changes how visitors using browsers fetch raw data from GitHub.

I'm hesitant for the same reasons that @lucacasonato is. Although github has its issues, it's a single source of truth.

How about making it an option/switch? It can be put on a separate page so there won't be visual noise for most people.
This problem is hard to hack (with User Script, etc.), and making a mirror/fork site for this sole purpose seems futile.

@kiddong Easy fix: instead of querying raw source url directly we can just query the deno.land/x url right? Then it will be queried via Cloudflare which has good presence in mainland china afaik

😅 I think you have mistaken my words. I'm stressing that this change only affect  browsers.

Loading scripts in Deno goes through CloudFlare and should not be worried about. This PR only changes how visitors using browsers fetch raw data (namely manual and registry files) from GitHub.

I understand. That’s why I am saying we should have the front end query the Cloudflare worker which queries the source rather than directly querying the source from the front end.
So this:
HTML deno.land/x/foo/bar.ts -> raw deno.land/x/foo/bar.ts -> raw.githubusercontent.com
instead of
HTML deno.land/x/foo/bar.ts -> raw.githubusercontent.com

This still falls into my statement, it just changes the CDN from jsDelivr (or whatever) to CloudFlare, which is fine.

@kidonng Thanks for this patch - but we're going to solve this another way - by mirroring github content in s3. This work is being done by @lucacasonato in https://github.com/denoland/deno_registry2


[BACKLOG-9099] Switch plugin from annotation to bean

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dpentaho.resolve.repo=http://nexus.pentaho.org/content/groups/approved -B -fn -DrunITs=true -f plugins/meta-inject-plugin/pom.xml clean install && mvn -Dpentaho.resolve.repo=http://nexus.pentaho.org/content/groups/approved -B -f plugins/meta-inject-plugin/pom.xml site

Cleanup Commands
mvn -B -f plugins/meta-inject-plugin/pom.xml build-helper:remove-project-artifact

Changed files
  plugins/meta-inject-plugin/src/main/java/org/pentaho/di/trans/steps/metainject/MetaInjectMeta.java
  plugins/meta-inject-plugin/src/main/resources/OSGI-INF/blueprint/pentaho-metainject-pdi-blueprint.xml

Still Broken Tests:
org.pentaho.di.repository.RepositoryImporterTest.testPatchTransSteps_with_meta_inject_step:
:red_circle: org.mockito.exceptions.verification.WantedButNotInvoked
org.mockito.exceptions.verification.WantedButNotInvoked:

Wanted but not invoked:
metaInjectMeta.setDirectoryPath("TEST_PATH");
-> at org.pentaho.di.repository.RepositoryImporterTest.testPatchTransSteps_with_meta_inject_step(RepositoryImporterTest.java:88)
Actually, there were zero interactions with this mock.

	at org.pentaho.di.repository.RepositoryImporterTest.testPatchTransSteps_with_meta_inject_step(RepositoryImporterTest.java:88)

org.pentaho.di.trans.steps.denormaliser.DenormaliserMetaInjectionIT.addedFieldsAvalibleOutsideInjectedTransformation:
:red_circle: java.lang.AssertionError
java.lang.AssertionError: expected:<0> but was:<1>
	at org.pentaho.di.trans.steps.denormaliser.DenormaliserMetaInjectionIT.runTransformation(DenormaliserMetaInjectionIT.java:65)
	at org.pentaho.di.trans.steps.denormaliser.DenormaliserMetaInjectionIT.addedFieldsAvalibleOutsideInjectedTransformation(DenormaliserMetaInjectionIT.java:56)

org.pentaho.di.trans.steps.normaliser.NormaliserMetaInjectionIT.injectValuesToNormaliserTransformation:
:red_circle: java.lang.AssertionError
java.lang.AssertionError
	at org.pentaho.di.trans.steps.normaliser.NormaliserMetaInjectionIT.injectValuesToNormaliserTransformation(NormaliserMetaInjectionIT.java:68)

org.pentaho.di.trans.steps.normaliser.NormaliserMetaInjectionIT.injectValuesToNormaliserTransformation_does_not_inject_fields:
:red_circle: java.lang.AssertionError
java.lang.AssertionError
	at org.pentaho.di.trans.steps.normaliser.NormaliserMetaInjectionIT.injectValuesToNormaliserTransformation_does_not_inject_fields(NormaliserMetaInjectionIT.java:79)

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/plugins/meta-inject-plugin/src/main/java/org/pentaho/di/trans/steps/metainject/MetaInjectMeta.java

:heavy_exclamation_mark: Unused import - org.pentaho.di.core.annotations.Step. at Line: 33 Column: 8

:heavy_exclamation_mark: 'switch' is not followed by whitespace. at Line: 490 Column: 11

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dpentaho.resolve.repo=http://nexus.pentaho.org/content/groups/approved -B -fn -DrunITs=true -f plugins/meta-inject-plugin/pom.xml clean install && mvn -Dpentaho.resolve.repo=http://nexus.pentaho.org/content/groups/approved -B -f plugins/meta-inject-plugin/pom.xml site

Cleanup Commands
mvn -B -f plugins/meta-inject-plugin/pom.xml build-helper:remove-project-artifact

Changed files
  plugins/meta-inject-plugin/src/main/java/org/pentaho/di/trans/steps/metainject/MetaInjectMeta.java
  plugins/meta-inject-plugin/src/main/resources/OSGI-INF/blueprint/pentaho-metainject-pdi-blueprint.xml
  plugins/meta-inject-plugin/src/test/java/org/pentaho/di/repository/RepositoryImporterTest.java

Newly Fixed Tests:
org.pentaho.di.repository.RepositoryImporterTest.testPatchTransSteps_with_meta_inject_step:
:red_circle: org.mockito.exceptions.verification.WantedButNotInvoked
org.mockito.exceptions.verification.WantedButNotInvoked:

Wanted but not invoked:
metaInjectMeta.setDirectoryPath("TEST_PATH");
-> at org.pentaho.di.repository.RepositoryImporterTest.testPatchTransSteps_with_meta_inject_step(RepositoryImporterTest.java:88)
Actually, there were zero interactions with this mock.

	at org.pentaho.di.repository.RepositoryImporterTest.testPatchTransSteps_with_meta_inject_step(RepositoryImporterTest.java:88)

Still Broken Tests:
org.pentaho.di.trans.steps.denormaliser.DenormaliserMetaInjectionIT.addedFieldsAvalibleOutsideInjectedTransformation:
:red_circle: java.lang.AssertionError
java.lang.AssertionError: expected:<0> but was:<1>
	at org.pentaho.di.trans.steps.denormaliser.DenormaliserMetaInjectionIT.runTransformation(DenormaliserMetaInjectionIT.java:65)
	at org.pentaho.di.trans.steps.denormaliser.DenormaliserMetaInjectionIT.addedFieldsAvalibleOutsideInjectedTransformation(DenormaliserMetaInjectionIT.java:56)

org.pentaho.di.trans.steps.normaliser.NormaliserMetaInjectionIT.injectValuesToNormaliserTransformation:
:red_circle: java.lang.AssertionError
java.lang.AssertionError
	at org.pentaho.di.trans.steps.normaliser.NormaliserMetaInjectionIT.injectValuesToNormaliserTransformation(NormaliserMetaInjectionIT.java:68)

org.pentaho.di.trans.steps.normaliser.NormaliserMetaInjectionIT.injectValuesToNormaliserTransformation_does_not_inject_fields:
:red_circle: java.lang.AssertionError
java.lang.AssertionError
	at org.pentaho.di.trans.steps.normaliser.NormaliserMetaInjectionIT.injectValuesToNormaliserTransformation_does_not_inject_fields(NormaliserMetaInjectionIT.java:79)

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.trans.steps.metainject.RepositoryImporterExtension

Branch Change:  + 13.64%
Complexity Change:  + 13.33%
Instruction Change:  + 33.09%
Line Change:  + 40.00%
Method Change:  + 50.00%

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/plugins/meta-inject-plugin/src/main/java/org/pentaho/di/trans/steps/metainject/MetaInjectMeta.java

:heavy_exclamation_mark: Unused import - org.pentaho.di.core.annotations.Step. at Line: 33 Column: 8

:heavy_exclamation_mark: 'switch' is not followed by whitespace. at Line: 490 Column: 11

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -Dpentaho.resolve.repo=http://nexus.pentaho.org/content/groups/approved -B -fn -DrunITs=true -f plugins/meta-inject-plugin/pom.xml clean install && mvn -Dpentaho.resolve.repo=http://nexus.pentaho.org/content/groups/approved -B -f plugins/meta-inject-plugin/pom.xml site

Cleanup Commands
mvn -B -f plugins/meta-inject-plugin/pom.xml build-helper:remove-project-artifact

Changed files
  plugins/meta-inject-plugin/src/it/java/org/pentaho/di/trans/steps/denormaliser/DenormaliserMetaInjectionIT.java
  plugins/meta-inject-plugin/src/it/java/org/pentaho/di/trans/steps/normaliser/NormaliserMetaInjectionIT.java
  plugins/meta-inject-plugin/src/main/java/org/pentaho/di/trans/steps/metainject/MetaInjectMeta.java
  plugins/meta-inject-plugin/src/main/resources/OSGI-INF/blueprint/pentaho-metainject-pdi-blueprint.xml
  plugins/meta-inject-plugin/src/test/java/org/pentaho/di/repository/RepositoryImporterTest.java

Newly Fixed Tests:
org.pentaho.di.repository.RepositoryImporterTest.testPatchTransSteps_with_meta_inject_step:
:red_circle: org.mockito.exceptions.verification.WantedButNotInvoked
org.mockito.exceptions.verification.WantedButNotInvoked:

Wanted but not invoked:
metaInjectMeta.setDirectoryPath("TEST_PATH");
-> at org.pentaho.di.repository.RepositoryImporterTest.testPatchTransSteps_with_meta_inject_step(RepositoryImporterTest.java:88)
Actually, there were zero interactions with this mock.

	at org.pentaho.di.repository.RepositoryImporterTest.testPatchTransSteps_with_meta_inject_step(RepositoryImporterTest.java:88)

org.pentaho.di.trans.steps.denormaliser.DenormaliserMetaInjectionIT.addedFieldsAvalibleOutsideInjectedTransformation:
:red_circle: java.lang.AssertionError
java.lang.AssertionError: expected:<0> but was:<1>
	at org.pentaho.di.trans.steps.denormaliser.DenormaliserMetaInjectionIT.runTransformation(DenormaliserMetaInjectionIT.java:65)
	at org.pentaho.di.trans.steps.denormaliser.DenormaliserMetaInjectionIT.addedFieldsAvalibleOutsideInjectedTransformation(DenormaliserMetaInjectionIT.java:56)

org.pentaho.di.trans.steps.normaliser.NormaliserMetaInjectionIT.injectValuesToNormaliserTransformation:
:red_circle: java.lang.AssertionError
java.lang.AssertionError
	at org.pentaho.di.trans.steps.normaliser.NormaliserMetaInjectionIT.injectValuesToNormaliserTransformation(NormaliserMetaInjectionIT.java:68)

org.pentaho.di.trans.steps.normaliser.NormaliserMetaInjectionIT.injectValuesToNormaliserTransformation_does_not_inject_fields:
:red_circle: java.lang.AssertionError
java.lang.AssertionError
	at org.pentaho.di.trans.steps.normaliser.NormaliserMetaInjectionIT.injectValuesToNormaliserTransformation_does_not_inject_fields(NormaliserMetaInjectionIT.java:79)

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.trans.steps.metainject.RepositoryImporterExtension

Branch Change:  + 13.64%
Complexity Change:  + 13.33%
Instruction Change:  + 33.09%
Line Change:  + 40.00%
Method Change:  + 50.00%

Integration test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.trans.steps.metainject.MetaInject

Branch Change:  + 53.04%
Complexity Change:  + 42.37%
Instruction Change:  + 62.86%
Line Change:  + 67.38%
Method Change:  + 84.00%

org.pentaho.di.trans.steps.metainject.MetaInject.new RowAdapter() {...}

Complexity Change:  + 100.00%
Instruction Change:  + 100.00%
Line Change:  + 100.00%
Method Change:  + 100.00%

org.pentaho.di.trans.steps.metainject.MetaInject.new TransStoppedListener() {...}

Complexity Change:  + 50.00%
Instruction Change:  + 69.23%
Line Change:  + 33.33%
Method Change:  + 50.00%

org.pentaho.di.trans.steps.metainject.MetaInjectData

Complexity Change:  + 100.00%
Instruction Change:  + 100.00%
Line Change:  + 100.00%
Method Change:  + 100.00%

org.pentaho.di.trans.steps.metainject.MetaInjectMeta

Branch Change:  + 6.67%
Complexity Change:  + 15.09%
Instruction Change:  + 17.23%
Line Change:  + 20.19%
Method Change:  + 25.00%

org.pentaho.di.trans.steps.metainject.MetaInjectMeta.new Object() {...}

Complexity Change:  + 100.00%
Instruction Change:  + 88.46%
Line Change:  + 100.00%
Method Change:  + 100.00%

org.pentaho.di.trans.steps.metainject.SourceStepField

Complexity Change:  + 27.27%
Instruction Change:  + 25.00%
Line Change:  + 35.29%
Method Change:  + 42.86%

org.pentaho.di.trans.steps.metainject.TargetStepAttribute

Branch Change:  + 50.00%
Complexity Change:  + 46.15%
Instruction Change:  + 75.71%
Line Change:  + 61.90%
Method Change:  + 66.67%

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/plugins/meta-inject-plugin/src/main/java/org/pentaho/di/trans/steps/metainject/MetaInjectMeta.java

:heavy_exclamation_mark: 'switch' is not followed by whitespace. at Line: 492 Column: 11

Build Completed
:white_check_mark: This pull request has passed all validations.
Build Commands
mvn -Dpentaho.resolve.repo=http://nexus.pentaho.org/content/groups/approved -B -fn -DrunITs=true -f plugins/meta-inject-plugin/pom.xml clean install && mvn -Dpentaho.resolve.repo=http://nexus.pentaho.org/content/groups/approved -B -f plugins/meta-inject-plugin/pom.xml site

Cleanup Commands
mvn -B -f plugins/meta-inject-plugin/pom.xml build-helper:remove-project-artifact

Changed files
  plugins/meta-inject-plugin/src/it/java/org/pentaho/di/trans/steps/denormaliser/DenormaliserMetaInjectionIT.java
  plugins/meta-inject-plugin/src/it/java/org/pentaho/di/trans/steps/normaliser/NormaliserMetaInjectionIT.java
  plugins/meta-inject-plugin/src/main/java/org/pentaho/di/trans/steps/metainject/MetaInjectMeta.java
  plugins/meta-inject-plugin/src/main/resources/OSGI-INF/blueprint/pentaho-metainject-pdi-blueprint.xml
  plugins/meta-inject-plugin/src/test/java/org/pentaho/di/repository/RepositoryImporterTest.java

Newly Fixed Tests:
org.pentaho.di.repository.RepositoryImporterTest.testPatchTransSteps_with_meta_inject_step:
:red_circle: org.mockito.exceptions.verification.WantedButNotInvoked
org.mockito.exceptions.verification.WantedButNotInvoked:

Wanted but not invoked:
metaInjectMeta.setDirectoryPath("TEST_PATH");
-> at org.pentaho.di.repository.RepositoryImporterTest.testPatchTransSteps_with_meta_inject_step(RepositoryImporterTest.java:88)
Actually, there were zero interactions with this mock.

	at org.pentaho.di.repository.RepositoryImporterTest.testPatchTransSteps_with_meta_inject_step(RepositoryImporterTest.java:88)

org.pentaho.di.trans.steps.denormaliser.DenormaliserMetaInjectionIT.addedFieldsAvalibleOutsideInjectedTransformation:
:red_circle: java.lang.AssertionError
java.lang.AssertionError: expected:<0> but was:<1>
	at org.pentaho.di.trans.steps.denormaliser.DenormaliserMetaInjectionIT.runTransformation(DenormaliserMetaInjectionIT.java:65)
	at org.pentaho.di.trans.steps.denormaliser.DenormaliserMetaInjectionIT.addedFieldsAvalibleOutsideInjectedTransformation(DenormaliserMetaInjectionIT.java:56)

org.pentaho.di.trans.steps.normaliser.NormaliserMetaInjectionIT.injectValuesToNormaliserTransformation:
:red_circle: java.lang.AssertionError
java.lang.AssertionError
	at org.pentaho.di.trans.steps.normaliser.NormaliserMetaInjectionIT.injectValuesToNormaliserTransformation(NormaliserMetaInjectionIT.java:68)

org.pentaho.di.trans.steps.normaliser.NormaliserMetaInjectionIT.injectValuesToNormaliserTransformation_does_not_inject_fields:
:red_circle: java.lang.AssertionError
java.lang.AssertionError
	at org.pentaho.di.trans.steps.normaliser.NormaliserMetaInjectionIT.injectValuesToNormaliserTransformation_does_not_inject_fields(NormaliserMetaInjectionIT.java:79)

Unit test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.trans.steps.metainject.RepositoryImporterExtension

Branch Change:  + 13.64%
Complexity Change:  + 13.33%
Instruction Change:  + 33.09%
Line Change:  + 40.00%
Method Change:  + 50.00%

Integration test coverage change
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.
org.pentaho.di.trans.steps.metainject.MetaInject

Branch Change:  + 53.04%
Complexity Change:  + 42.37%
Instruction Change:  + 62.86%
Line Change:  + 67.38%
Method Change:  + 84.00%

org.pentaho.di.trans.steps.metainject.MetaInject.new RowAdapter() {...}

Complexity Change:  + 100.00%
Instruction Change:  + 100.00%
Line Change:  + 100.00%
Method Change:  + 100.00%

org.pentaho.di.trans.steps.metainject.MetaInject.new TransStoppedListener() {...}

Complexity Change:  + 50.00%
Instruction Change:  + 69.23%
Line Change:  + 33.33%
Method Change:  + 50.00%

org.pentaho.di.trans.steps.metainject.MetaInjectData

Complexity Change:  + 100.00%
Instruction Change:  + 100.00%
Line Change:  + 100.00%
Method Change:  + 100.00%

org.pentaho.di.trans.steps.metainject.MetaInjectMeta

Branch Change:  + 6.67%
Complexity Change:  + 15.09%
Instruction Change:  + 17.23%
Line Change:  + 20.19%
Method Change:  + 25.00%

org.pentaho.di.trans.steps.metainject.MetaInjectMeta.new Object() {...}

Complexity Change:  + 100.00%
Instruction Change:  + 88.46%
Line Change:  + 100.00%
Method Change:  + 100.00%

org.pentaho.di.trans.steps.metainject.SourceStepField

Complexity Change:  + 27.27%
Instruction Change:  + 25.00%
Line Change:  + 35.29%
Method Change:  + 42.86%

org.pentaho.di.trans.steps.metainject.TargetStepAttribute

Branch Change:  + 50.00%
Complexity Change:  + 46.15%
Instruction Change:  + 75.71%
Line Change:  + 61.90%
Method Change:  + 66.67%

@mdamour1976


Use OCaml code to find the oldest commit

Before, we spawned a separate git log process after each solve. This has the advantage that it can do work independently of the OCaml GC, but it also has some disadvantages:

git has to read and decompress the repository for each solve, rather than caching it.
Spawning a process requires briefly pausing all domains, slowing down solving.
The spawned processes might run on a CPU that OCaml wants to use, delaying that domain and, in turn, disrupting the STW minor GC.

Just looking at the time to find the commit, I get:
Before After
0.035s 0.246s
0.186s 1.727s
0.039s 0.000s
0.038s 0.000s
0.038s 0.000s
0.037s 0.001s
0.039s 0.000s
0.040s 0.000s
0.040s 0.001s
...

That is, the OCaml code is a lot slower at loading the data from disk, but once cached it's massively faster.
For total times (running bench.sh, which does a warm-up first and so excludes loading from disk):
My machine:

jade-2 (with SCHED_RR):

Sample traces for 24 cores
Before:

with_pipe shows when the main domain spawns the git subprocess. Notice that minor GCs stop happening during this, indicating that all the other domains are stuck too. The other two gaps in the GCs are also caused by other fibers spawning subprocesses (not shown here to save space).
After:

Worker domains continue to perform minor GCs, indicating that work is continuing.


Add use cases 5-9 to developer guide

Codecov Report

Merging #65 (5f92063) into master (282eb3d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #65   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 282eb3d...5f92063. Read the comment docs.


404 on "RESET MY PASSWORD" Button

In the mb-user-password-us template, I was sent to a 404 page when I clicked the RESET MY PASSWORD button.
Here's the template:
https://us4.admin.mailchimp.com/templates/editor?id=56669

Same issue, nasty MailChimp trying to helpful with the addition of the root link to the MailCHimp server.

Fixed and updated to Mandrill.


Fix cloud controller manager role

What this PR does / why we need it:
Fix cloud-controller-manager role name and add configmaps resource permission
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

Please hold, i need to test again to make sure no resource permission is missing.

ok, this PR is ready for review

/test cloud-provider-openstack-acceptance-test-lb-octavia


Add weather notifications

Feature request: This feature should be developed after DOL-72 but  follow same principle and be delivered alongside eta for work notifications. This task can run at the same time as the DOL-72. We need to use open-meteo for weather information and users need to give a city for us to get their longitude and latitude, then return weather through Discord DM
Submitted by: mfcash
Server: mfDiscord

https://open-meteo.com/

https://www.tiktok.com/t/ZTN57bxyH/


Added Nano RP2040 Connect support

Have same compilation error: https://github.com/JAndrassy/ArduinoOTA/issues/123
W have two solutions:

RP2040 boards with Pico core. but how to config platformio.ini
Nano RP2040 Connect with mbed core with custom storage example and SFU library. solution:  https://github.com/JAndrassy/ArduinoOTA/blob/master/examples/Advanced/CustomStorageNanoConnect/CustomStorageNanoConnect.ino


Add new python interpreters to portability and basictests matrices

Adding Python3.5, Python3.6, and PyPy to test matrices.

@jtattermusch @nathanielmanistaatgoogle I think a good compromise would be that as of now, basic tests should run on Python3.4, Python3.6, and Python2.7. Portability should run on Python3.5. As soon as we have some more confidence on Python3.6, we can move Python3.4 to portability as well. Adding PyPy to basictests will become a separate PR.

Looks like @matt-kwong  will review, I'll remove myself. I agree with @thunderboltsid 's choice what should be tested. Please make sure tests are passing reliably before merging.

No significant performance differences

No significant performance differences

Performance differences noted:
Benchmark                                         cpu_time    real_time
----------------------------------------------  ----------  -----------
BM_MetadataFromInternedSlicesWithBackingStore       -14.00       -14.00
BM_MetadataFromNonInternedSlices                    -15.50       -15.50
BM_MetadataFromStaticMetadataStringsNotIndexed      -24.00       -24.00

Can someone with more docker experience than me and @matt-kwong help us with this ?

Sorry I've been a bit busy, but I hope the next time I'm able to work on this, we can get something mergable.

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.
After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

User @thunderboltsid isn't covered by a CLA. They will need to complete the form at https://identity.linuxfoundation.org/projects/cncf

Regards,
CLA GitHub bot

@thunderboltsid Do you still want to work on this PR? @jtattermusch can help you with docker questions. I'm closing this PR since it's really old. But please reopen it if you are ready to continue. Thanks!


Support for pututu instead of chasqui

Codecov Report

Merging #13 into develop will decrease coverage by 2.09%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop     #13     +/-   ##
=========================================
- Coverage       93%   90.9%   -2.1%
=========================================
  Files            4       4
  Lines          143     143
  Branches        50      50
=========================================
- Hits           133     130      -3
- Misses          10      13      +3

Impacted Files
Coverage Δ

src/Credentials.js
84.9% <ø> (-5.67%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ba4c96...0f83bee. Read the comment docs.


The value passed for NSPersistentStoreUbiquitousContentURLKey cannot be the same as the store URL

When initializing CoreDataiCloudStorage. You're clearly setting storeURL and ContentURL to the same value in cdiCloudInitializeStore.
Full log:
2016-04-12 16:12:17.213 testCoreData[92333:18177441] CoreData: error: -addPersistentStoreWithType:SQLite configuration:(null) URL:file:///Users/asdfgh1/Library/Developer/CoreSimulator/Devices/D838493D-0303-4CCC-ADDD-57334A2CD98B/data/Library/Mobile%20Documents/iCloud~com~xxx~yyy/Path/ options:{
    NSInferMappingModelAutomaticallyOption = 1;
    NSMigratePersistentStoresAutomaticallyOption = 1;
    NSPersistentStoreUbiquitousContentNameKey = MyDb;
    NSPersistentStoreUbiquitousContentURLKey = "file:///Users/asdfgh1/Library/Developer/CoreSimulator/Devices/D838493D-0303-4CCC-ADDD-57334A2CD98B/data/Library/Mobile%20Documents/iCloud~com~xxx~yyy/Path/";
    NSSQLitePragmasOption =     {
        WAL = "journal_mode";
    };
} ... returned error Error Domain=NSCocoaErrorDomain Code=134311 "The value passed for NSPersistentStoreUbiquitousContentURLKey cannot be the same as the store URL.

Related https://github.com/pepibumur/SugarRecord/issues/226


Code refactoring (Client-side && Server-side )

I just make it one PR, If you can merge it

Thank you @Rabaiahmed I will merge it by two days.

TypeError: "responseJson[0] is undefined"
    renderCountryData Country.js:25
index.js:1375
    e index.js:1375
    renderCountryData Country.js:30

The app can not fetches the data from mongoDB

You have created separate directories for each componenet in the server. Is it necessary? because unlike client there are no multiple files in each directory.

You have created separate directories for each component in the server. Is it necessary? because unlike the client there are no multiple files in each directory.

It's a code organization if the application will grow, any new developer needs to reference the necessary files to make his Changement

nodemon is simply used in the development of the app. But we can not implement nodemon  to start the post-build application, because there are no changes that can be done after we deployed. Heroku automatically builds each time when we push the code to its repository.
concurrently  is used to run more than one command at a time. Each time we deploy it to Heroku, it builds the client.
https://github.com/gayanvoice/nodejs-graphql/blob/a6bf28d96ecd8b9c471d16281797655c36ecc2f3/server.js#L148
This code gets the static build of the client app. So we don't need to create another server to run the React app.

You need to differentiate between the dev mode and prod mode, the folder build doesn't exists  only in the production env, so when I start the project there is no response when I put localhost:port_server, if you are convinced only about your opinion about your code organization that's another point,

nodemon is simply used in the development of the app. But we can not implement nodemon  to start the post-build application, because there are no changes that can be done after we deployed. Heroku automatically builds each time when we push the code to its repository.
concurrently  is used to run more than one command at a time. Each time we deploy it to Heroku, it builds the client.
https://github.com/gayanvoice/nodejs-graphql/blob/a6bf28d96ecd8b9c471d16281797655c36ecc2f3/server.js#L148
This code gets the static build of the client app. So we don't need to create another server to run the React app.

We need in the package JSON make a start command for dev env and prod mode, Why as a developer should start both projects client-side and server-side each one in a terminal, and I make Changement in teh server-side should always make restart for the app !

@Rebaiahmed Accidentally I deleted this branch #1-refactoring  I want to merge with into a new branch https://github.com/gayanvoice/nodejs-graphql/tree/code-refactor-1, but it seems both PR and the branch can not retrieve.


Perms

When i add a permission to a group like essentials.fly or essentials.* and i go to a different group or tab and then back to the permission i just added, it disappears. For example, i go to group owner, i add the permission essentials.fly, i go to group vip, i go back to group owner, the permission is gone and when i save and type the command in minecraft it says no changes we added.

You have to click the +-Button on the bottom right to actually add it.

oooooooooohhhhhhhhhh thank you


Use voluptuous for Proliphix

Description:
Migration of the configuration check to voluptuous.
Related issue (if applicable): fixes 127528299
Example entry for configuration.yaml (if applicable):
climate:
  platform: proliphix
  host: IP_ADDRESS
  username: YOUR_USERNAME
  password: YOUR_PASSWORD

@sdague, would be nice if you could take a look at the changes and run a quick test. Thanks.

🐬


moving container images from docker to ghcr registry

What would you like to be added?
I want to have a automated way of pushing the container images to ghcr registry. Right now the images are pushed to docker container image registry.
Why is this needed?
Storing container images to ghcr is the recommendation by TOC.

/assign @vineeth2328

@adityajoshi12 can you assign this to me?

@anj20 there is a PR #382, feel free to review it.


FileNotFoundError: ./ckpts/baseline_1000/EG_000.ckpt

$ python colorize.py
Target Epoch is 000
Traceback (most recent call last):
File "colorize.py", line 172, in
main(args)
File "colorize.py", line 58, in main
raise FileNotFoundError(path_eg)
FileNotFoundError: ./ckpts/baseline_1000/EG_000.ckpt

I don't know what you want.
Please carefully read the "README.MD".
If you want to colorize an arbitrary image.
Run the command below in bash.
./scripts/colorize.real.sh

Before trying to colorize, you should download the pretrained model, as described in README.MD

@TechHalloman hello, sorry, were you able to launch colorization?

sorry recently my system crashed... anable to this... thank you i will try.
https://www.youtube.com/channel/UCjW9D5sNP_vxI8DHa56Qqyw ... i like this channel


Sound is too big?

foo_midi <IP_ADDRESS> with foobar 2000 v2.1.5 (x64)
I'm using VSTi (Yamaha S-YXG50).
When I play favourite MIDI with foo_midi, the sound distorted.
So I configured Yamaha S-YXG50 to volume down (-3 db), the sound is genuine.
Are there any troubles in vsthost?
Or, doubly played?
I wish fixed.
thanks

vshost simply loads the VST, passes the MIDI commands to the VST for rendering and sends the generated samples to foobar2000 for playing: absolutely no processing.
But: if you're mixing 32-bit and 64-bit foobar and VST's there can be some clipping due to the conversion from 32-bit floats the 64-bit doubles.
Which architecture combination are you using?

No feedback from issuer.


Feature request: auto rounded corners in android

first of all thanks for the awesome utility :+1:
as per iOS guidelines they prefer if launcher icon is having flat background so it can be clipped easily by launcher and avoid black edge overlays
but at same time android provides flexibility and they don't do any kind of clipping plus most applications use rounded corners
if possible it will be great to have configurable rounded corners :smile:

📝 The material design iconography docs show "keyline shapes", which are essentially boundaries. So that can also be a configuration option.

I guess this issue can be closed as new google play icon specs.
https://android-developers.googleblog.com/2019/03/introducing-new-google-play-app-and.html

@harshzalavadiya Do we need a new issue?

Nope because in newer android versions icons are going to be clipped and rounded just like apple so having flat square isn't going to be issue anymore


[bug] Multiple errors when working with Angular 18 and @web3modal/wagmi

Link to minimal reproducible example
https://github.com/vanyasav/web3modal-wagmi-angular-example
Summary

Error when connect to metamask wallet:

TypeError: rest.transports[chainId2] is not a function
    at Object.transport (createConfig.js:103:57)
    at createClient (createClient.js:19:18)
    at Object.getClient2 [as getClient] (createConfig.js:97:16)
    at getBalance.js:46:25
    at Generator.next (<anonymous>)
    at chunk-WME3VOFU.js?v=0e1f1629:93:61
    at new ZoneAwarePromise (zone.js:2702:25)
    at __async (chunk-WME3VOFU.js?v=0e1f1629:77:10)
    at getBalance2 (getBalance.js:7:54)
    at _Web3Modal.<anonymous> (client.js:447:29)

Can not disconnect wallet using the modal
Wallet is disconnected after page reload

Screencast from 30-07-2024 14:24:08.webm
List of related npm package versions
"@wagmi/core": "2.13.1",
"@web3modal/wagmi": "5.0.9"

please update to latest version.
"@web3modal/wagmi": "5.0.11"

I've tried the latest versions but I still have to connect to metamask every time I refresh the page. I can not disconnect as well.
The other error is fixed.