MSID: 86827 Version: 1 DOI: 2<IP_ADDRESS>1872

"msas": "Developmental Biology"
"msid": "86827"
"preprintDoi": "10.1101/2<IP_ADDRESS>1872"
"Reviewed Preprint posted": "2023-06-20"
"Sent for peer review": "2023-03-09"
"Posted to bioRxiv": "2023-03-09" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>1872v1")
[PLACE PDF URL HERE WHEN AVAILABLE] See step 7
Step 1. Inform bioRxiv
Who can help: @QueenKraken, @nlisgo, @scottaubrey

[x] Manuscript is in data hub index (https://data-hub-api.elifesciences.org/enhanced-preprints/docmaps/v1/by-publisher/elife/get-by-manuscript-id?manuscript_id=86827)

Step 2. Create preview of manuscript
Who can help: @fred-atherden, @nlisgo, @scottaubrey

[ ] Manuscript is available for preview (https://prod--epp.elifesciences.org/preview/86827/v1)

[ ] Trigger import for staging: https://prod--epp.elifesciences.org/import
[ ] Sync data folder with s3://prod-elife-epp-data/data
[ ] Trigger import for staging: https://staging--epp.elifesciences.org/import
[ ] Sync data folder with s3://staging-elife-epp-data/data
[ ] Pull request created to enhanced-preprint-data
[ ] Post link to pull request below

Pull request: https://github.com/elifesciences/enhanced-preprints-data/pull/105
Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-manuscript
Step 3: Awaiting public reviews
Who can help: Editorial team

[x] Public reviews available on sciety (https://sciety.org/articles/activity/10.1101/2<IP_ADDRESS>1872)
[x] Manuscript and editor details at the top of this issue (Supplied by Editorial team)
[ ] Reviews returned by EPP - https://prod--epp.elifesciences.org/api/reviewed-preprints/86827/v1/reviews

Example
"msas": "Genetics and Genomics", "Neuroscience"
"msid": "84628"
"version": "1"
"preprintDoi": "10.1101/2<IP_ADDRESS>4241"
"articleType": "Reviewed Preprint"
"status": "Published from the original preprint after peer review and assessment by eLife."

"Reviewed Preprint posted": "2023-01-02"
"Sent for peer review": "2022-10-28"
"Posted to bioRxiv": "2022-11-21" (link: "Go to bioRxiv": "https://www.biorxiv.org/content/10.1101/2<IP_ADDRESS>4241v1")

Editors:
Reviewing Editor
Michael B Eisen
University of California, Berkeley, United States
Senior Editor
Michael B Eisen
University of California, Berkeley, United States

Step 4: Modify manuscripts.json (no PDF)

[ ] Reviewed preprint is published to EPP (https://elifesciences.org/reviewed-preprints/86827)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[ ] Request that a doi be registered

[ ] Post link to #enhanced-preprint comment below

Pull request: [PLACE LINK TO PULL REQUEST HERE]
#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]

Instructions to modify manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/publish-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/334/files
Once the pull request is merged in it should be available a few minutes later.

Request that a doi
Post the following in #enhanced-preprint:
@Fred can you register a doi for https://elifesciences.org/reviewed-preprints/86827

Step 5: Awaiting search reindex

[ ] Reviewed preprint is avaliable on journal homepage (https://elifesciences.org)

The search reindex is triggered once an hour. We need the reviewed preprint to be indexed as the search application serves the journal homepage.

Additional info
If needed, the jenkins pipeline to reindex search can be triggered sooner.
https://alfred.elifesciences.org/job/process/job/process-reindex-reviewed-preprints/

Step 6: Published! Request PDF generation

[ ] Post the link to the PDF url at the top of the issue

[ ] Post link to #enhanced-preprint comment below

#enhanced-preprint comment thread: [PLACE LINK TO COMMENT HERE]
Post the following to the #enhanced-preprint on slack:
@Ryan Dix-Peek please can you generate a PDF for https://elifesciences.org/reviewed-preprints/86827

Step 7: Introduce PDF to data folder and git repo

[ ] PDF is avaliable at https://github.com/elifesciences/enhanced-preprints-data/raw/master/data/86827/v1/86827-v1.pdf

Detailed instructions: https://github.com/elifesciences/enhanced-preprints-data#add-a-pdf
Step 8: Add PDF url to manuscripts.json

[ ] Reviewed preprint PDF is available for download (https://prod--epp.elifesciences.org/reviewed-preprints/86827)

[ ] Pull request created to enhanced-preprint-client
[ ] Pull request switched to "Ready for review"
[ ] Post link to pull request below

[PLACE LINK TO PULL REQUEST HERE]

Instructions to add PDF url to manuscripts.json

Visit: https://github.com/elifesciences/enhanced-preprints-client/actions/workflows/add-pdf-url-to-manuscript.yaml
Click: Run workflow
Complete the form and click "Run workflow"
A successful run should result in a new pull request at https://github.com/elifesciences/enhanced-preprints-client/pulls
Open the pull request and click the "Ready for review" button to trigger tests
Once the tests pass and you are happy with the changes the PR can be merged

Example pull request: https://github.com/elifesciences/enhanced-preprints-client/pull/397/files
Once the pull request is merged in it should be available a few minutes later.

Step 9: Done!

[ ] Kettle is on!

Corresponding author emails are not correct

Fix in https://github.com/elifesciences/enhanced-preprints-biorxiv-xslt/pull/48


data GetProjects = GetProjects deriving(Query) isn't allowed

The Query deriving shouldn't require an argument, or should it?

That's right, should work without argument. Does it expect one?
On Mon, Apr 30, 2018, 19:01 Paul Hachmang<EMAIL_ADDRESS>wrote:

The Query deriving shouldn't require an argument, or should it?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/prolic/fpp/issues/40, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYEvBOUtwGHky8s7gZO0eG_jObV02Hyks5ttu7xgaJpZM4TsbEW
.

PHP Fatal error:  Uncaught Fpp\InvalidDeriving: Invalid deriving on GetProjects, deriving Query expects at least one constructor argument in /Users/paulhachmang/Sites/soft3/src/vendor/prolic/fpp/src/InvalidDeriving.php:76 Stack trace:


Mixing Wallet Failing to Connect to Node

I have been communicating with Craig Raw on Telegram regarding this issue and he asked me to create this support ticket.
Here are the facts:
I've been running Sparrow 1.7.3 successfully on MacOS (Big Sur 11.7.10) for the past 10 months.
I connect to my own Bitcoin Core full node.
All of my sparrow wallets were connecting to my node however the mixing wallet suddenly stopped connecting.
I get an error message:  'Connection Failed: Server Error'.
There is no issue with my bitcoin node; it is up and running and connecting to my other sparrow wallets.
I have updated to Sparrow 1.8.1 but the issue with the mixing wallet failing to connect to the server persists.
I also checked the config file as Craig Raw suggested and it is set to:
“Uselegacycorewallet”: false
I have attached the log.
Looking forward to getting this issue resolved.
Thanks!
sparrow log.log
sparrow log.log

See https://bitcoin.stackexchange.com/questions/81447/rpc-giving-error-13 - it appears Bitcoin Core is trying to load a wallet, finding that a passphrase is required, and failing. Unfortunately it doesn't give the name of the wallet.
Sparrow uses one of two wallets in Bitcoin Core depending on whether you are legacy Core wallets, or the newer descriptor wallets. Neither use passphrase encryption. So either something else has added a passphrase to these wallets, or there is some other wallet that requires a passphrase before wallet functionality is enabled.
You can try closing Sparrow and Bitcoin Core and deleting the Core wallets from the Bitcoin Core data directory until things work again. Sparrow's wallets are called cormorant and sparrow. Sparrow will recreate these wallets if necessary, but rescanning will be required.
Alternatively, you can enable DEBUG logging by opening Terminal and running:
open /Applications/Sparrow.app --args -l DEBUG

This will do a lot more logging, but will provide more clues to the problem.

Some further information.
I do remember the passphrase for the encrypted bitcoin core wallet but I
don't remember the name that I gave it.
Looking at Bitcoin Core, this is what I see:
[image: Screen Shot 2023-12-03 at 10.32.00 AM.png]
There is only one wallet showing which is named 'Sparrow' and it is not
clickable.
This is 'Sparrow' wallet is the wallet I created originally to connect my
Bitcoin Core node to my Sparrow wallet(s).
So, I have no clue as to how to delete the Bitcoin Core wallet that I
created a few months ago that seems to be the cause of the current issue.
On Sun, Dec 3, 2023 at 10:22 AM Jeffrey Lee @.***> wrote:

Hi Craig,
This makes sense.
I remember creating a wallet via Bitcoin Core just before this issue
appeared.
There are no assets in that Bitcoin Core wallet.
The Bitcoin Core wallet is 'encrypted'.
Can you guide me through the steps I would need to take to delete this
Bitcoin Core wallet?
Thanks very much in advance
[image: Screen Shot 2023-12-03 at 10.18.14 AM.png]
[image: Screen Shot 2023-12-03 at 10.18.24 AM.png]
On Sun, Dec 3, 2023 at 12:08 AM craigraw @.***> wrote:

See https://bitcoin.stackexchange.com/questions/81447/rpc-giving-error-13

it appears Bitcoin Core is trying to load a wallet, finding that a
passphrase is required, and failing. Unfortunately it doesn't give the name
of the wallet.

Sparrow uses one of two wallets in Bitcoin Core depending on whether you
are legacy Core wallets, or the newer descriptor wallets. Neither use
passphrase encryption. So either something else has added a passphrase to
these wallets, or there is some other wallet that requires a passphrase
before wallet functionality is enabled.
You can try closing Sparrow and Bitcoin Core and deleting the Core
wallets from the Bitcoin Core data directory until things work again.
Sparrow's wallets are called cormorant and sparrow. Sparrow will
recreate these wallets if necessary, but rescanning will be required.
Alternatively, you can enable DEBUG logging by opening Terminal and
running:
open /Applications/Sparrow.app --args -l DEBUG
This will do a lot more logging, but will provide more clues to the
problem.
—
Reply to this email directly, view it on GitHub
https://github.com/sparrowwallet/sparrow/issues/1190#issuecomment-1837381929,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHJIIFRSXQUVNC4NDIDYJ7TYHQJNFAVCNFSM6AAAAABAEERYQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGM4DCOJSHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

[image: Screen Shot 2023-12-03 at 11.07.17 AM.png]
[image: Screen Shot 2023-12-03 at 11.07.17 AM.png]
[image: Screen Shot 2023-12-03 at 11.07.51 AM.png]
On Sun, Dec 3, 2023 at 10:40 AM Jeffrey Lee @.***> wrote:

I am correct in assuming that these 'receiving addresses' are associated
with the Bitcoin Core wallet that I created?
[image: Screen Shot 2023-12-03 at 10.38.48 AM.png]
[image: Screen Shot 2023-12-03 at 10.38.16 AM.png]
On Sun, Dec 3, 2023 at 10:37 AM Jeffrey Lee @.***> wrote:

Some further information.
I do remember the passphrase for the encrypted bitcoin core wallet but I
don't remember the name that I gave it.
Looking at Bitcoin Core, this is what I see:
[image: Screen Shot 2023-12-03 at 10.32.00 AM.png]
There is only one wallet showing which is named 'Sparrow' and it is not
clickable.
This is 'Sparrow' wallet is the wallet I created originally to connect my
Bitcoin Core node to my Sparrow wallet(s).
So, I have no clue as to how to delete the Bitcoin Core wallet that I
created a few months ago that seems to be the cause of the current issue.
On Sun, Dec 3, 2023 at 10:22 AM Jeffrey Lee @.***> wrote:

Hi Craig,
This makes sense.
I remember creating a wallet via Bitcoin Core just before this issue
appeared.
There are no assets in that Bitcoin Core wallet.
The Bitcoin Core wallet is 'encrypted'.
Can you guide me through the steps I would need to take to delete this
Bitcoin Core wallet?
Thanks very much in advance
[image: Screen Shot 2023-12-03 at 10.18.14 AM.png]
[image: Screen Shot 2023-12-03 at 10.18.24 AM.png]
On Sun, Dec 3, 2023 at 12:08 AM craigraw @.***>
wrote:

See
https://bitcoin.stackexchange.com/questions/81447/rpc-giving-error-13

it appears Bitcoin Core is trying to load a wallet, finding that a
passphrase is required, and failing. Unfortunately it doesn't give the name
of the wallet.

Sparrow uses one of two wallets in Bitcoin Core depending on whether
you are legacy Core wallets, or the newer descriptor wallets. Neither use
passphrase encryption. So either something else has added a passphrase to
these wallets, or there is some other wallet that requires a passphrase
before wallet functionality is enabled.
You can try closing Sparrow and Bitcoin Core and deleting the Core
wallets from the Bitcoin Core data directory until things work again.
Sparrow's wallets are called cormorant and sparrow. Sparrow will
recreate these wallets if necessary, but rescanning will be required.
Alternatively, you can enable DEBUG logging by opening Terminal and
running:
open /Applications/Sparrow.app --args -l DEBUG
This will do a lot more logging, but will provide more clues to the
problem.
—
Reply to this email directly, view it on GitHub
https://github.com/sparrowwallet/sparrow/issues/1190#issuecomment-1837381929,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHJIIFRSXQUVNC4NDIDYJ7TYHQJNFAVCNFSM6AAAAABAEERYQKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZXGM4DCOJSHE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Okay, I will do that now.  How long will it take to rescan the wallets?
On another note, I am going to download Bitcoin Core and Sparrow onto another MacOS device.  I am assuming that I can recover my Sparrow wallet(s) on that new device with the 12-word Sparrow seed that was originally created on the device that is encountering the issue?

Once I have the new MacOS device up and running, will I be able to connect to my Sparrow wallet(s) from both of these MacOS devices?

Which one do you like the best; Fulcrum or Electrs?
Do you have a guide that you can send me that will guide me through the setup?

Which one do you like the best; Fulcrum or Electrs?

Fulcrum. But unfortunately in neither case is it easy to run on macOS - both do not come with precompiled binaries for that platform. This is why many people use a dedicated Linux miniserver, for example those offered by Ronin Dojo or Start9. If you're up to it though, Ministry of Nodes has some great guides as part of the the Node Box series, for example https://www.youtube.com/watch?v=SpQRrbJt7cg&t=4s.
Let me know if your issue is resolved?

Hi Craig,Yes, the issue was resolved by deleting the Sparrow wallet folder.  Upon rebooting, the Sparrow wallet recreated itself and scanned all the wallets including the mixing wallet.Thanks so much for your help!JoffreyOn Dec 5, 2023, at 3:29 AM, craigraw @.***> wrote:
Which one do you like the best; Fulcrum or Electrs?
Fulcrum. But unfortunately in neither case is it easy to run on macOS - both do not come with precompiled binaries for that platform. This is why many people use a dedicated Linux miniserver, for example those offered by Ronin Dojo or Start9. If you're up to it though, Ministry of Nodes has some great guides as part of the the Node Box series, for example https://www.youtube.com/watch?v=SpQRrbJt7cg&t=4s.
Let me know if your issue is resolved?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Great, closing this off.


Newtonsoft.Json. Newtonsoft.Json prior to version 13.0.1 is vulnerable to improper handling of StackOverFlow exception (SOE)

Description
Newtonsoft.Json. Newtonsoft.Json prior to version 13.0.1 is vulnerable to improper handling of StackOverFlow exception (SOE)
Steps to reproduce
Applications that use Newtonsoft.Json might be exposed to DOS vulnerability
as called out by Aleph security
The underlying issue is that improper handling of exceptional conditions in Newtonsoft.Json prior to version 13.0.1 is vulnerable to due to improper handling of StackOverFlow exception (SOE) whenever nested expressions are being processed. Exploiting this vulnerability results in Denial Of Service (DoS), and it is exploitable when an attacker sends 5 requests that cause SOE in time frame of 5 minutes. (Refer to Aleph blog post.  This vulnerability affects Internet Information Services (IIS) Applications.

What steps can reproduce the defect?
Refer to Aleph blog post, It takes only one StackOverflowException to bring down an Application deployed on IIS

This has been addressed by https://github.com/JamesNK/Newtonsoft.Json/commit/7e77bbe1beccceac4fc7b174b53abfefac278b66
Expected behavior
No Stack Overflow.  Use of NewtonSoft.Json version 13.0.1 or later
Actual behavior
Earlier versions of NewtonSoft.Json version are currently in use

Hi @jhenderson2099! Thanks for reporting this issue. We did fix it in 17.4.0 which isn't yet released but we have pre-release version 17.4.0-preview-20221003-03 that you can use for now.


Updating mcc.py

The check_local_function was written on an assumption that all the attributes(ACDD, GDS2 and CF) parameters must be set. This is was due to lack of clarity in the API itself.
Here http://podaac-uat.jpl.nasa.gov/mcc/about_api it was mentioned that the parameters 'MUST' be set.
Here http://podaac-uat.jpl.nasa.gov/mcc/ beside the 'Checkers' it was mentioned 'select one or more'

Thanks @Omkar20895 do you some tests? Also, it woukd be good to start a branch @ OCW

I am writing the test cases for mcc.py file.

brilliant thanks any idea what is going on here?
http://podaacpy.readthedocs.io/en/latest/webservices.html

I think we need to edit it similar to the one in this link --> http://podaacpy.readthedocs.io/en/latest/mcc.html

ack there seems to have been a merge which screwed it up. Can you please recommit the original file? Thanks @Omkar20895 I appreciate that.

You want me to revert the merge and commit it again?

No need. Just a commit will suffice. I am not particularly bothered about the history right now. We just need 1) documentation, 2) code and 3) to progress to writing the actual data source.
podaacpy is the preliminary work that is being done. We have so much more to do. This is barely the beginning.

Please pardon me. I am unable to understand what you are trying to say about the recommit thing, can please be more elaborate?

Sorry.
There is no documentation at http://podaacpy.readthedocs.io/en/latest/webservices.html
There needs to be documentation at http://podaacpy.readthedocs.io/en/latest/webservices.html
Is it possible to fix that by committing the previous documentation which now seems to have been removed?

On it!

:) thank you very much.

Done!


Provide a template helm chart for installing the application supported by documentation on how to adapt it for projects

Is your feature request related to a problem? Please describe.
Our general approach is to provide a terraform template that provisions a Kubernetes cluster on various cloud infrastructure providers. The aim here is to avoid vendor lockin while being able to leverage the same technology stack to build applications.
My aim is to get terraform to do as much of the deployment as possible, including being able to push versions of the application to the cluster.
helm is respected package manager for Kubernetes and is used to deploy various other items in the cluster. The proposal here is to provide a helm chart that the application can ship to install versions of the app.
Describe the solution you'd like
Develop a helm chart that is able to deploy versions of the labs reference app. The chart will be published via Github pages. The aim of this chart is to act as a reference so as Anomaly projects spin off a new application via this template, we are able to provide the developers:

A template that does bulk of the work and requires minimum change
Documentation on how to expose the helm charts
Instructions on what to change for the chart to work for the new project

For private applications we deem there to be no security risk for the chart to be accessible publicly. The repository or images will be private and will require a key to access the images.

Our key aim here to achieve consistency across projects and provide better leverage of the technical knowledge being gathered.
Describe alternatives you've considered
NA
Additional context
We should revise how we are using helm and terraform, we should try and streamline this end of the process.

See https://github.com/anomaly/lab-python-mock-server/commit/a76f9d3aef972934e0d6aca510178bdcd3d9c654 for some initial work on this. Still pending:

How we provide the command for workers and the gunicorn based application

In particular we should also document the following:

How to authenticate the helm terraform provider to download private charts
Authenticating to download private container images when using helm
Changes required to the chart template to use kubernetes_config_map to make environment vars available
Changes required to the chart to use the kubernetes secrets to download the private containers imagePullSecrets directive

AWS specific:

Labels to share the same load balancer across multiple set of pods


[Question] nginx proxy oap server with http2 and ssl

Search before asking

[X] I had searched in the issues and found no similar issues.

Apache SkyWalking Component
Python Agent (apache/skywalking-python)
What happened
I use nginx to proxy skywalking oap server and try to connect in python agent. But somehow it comes with this exception, seems the agent consider it as a http1 server. Not sure if I set it wrong. It works fine when I not use ssl in nginx
nginx conf:
server {
        listen 8070 http2 ssl;
        ssl_certificate ssl.crt;
        ssl_certificate_key ssl.key;
        server_name localhost;
        access_log  D:/access.log;
        location / {
            grpc_pass grpc://skywalking-oap-server:11800;
            grpc_set_header Host $host;
            grpc_set_header X-Real-IP $remote_addr;
            grpc_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
        }

    }

python agent config:
config.init(agent_collector_backend_services='localhost:8070', agent_protocol='grpc', agent_name='test', agent_instance_name='grpc_test')
error:
grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
status = StatusCode.UNAVAILABLE
details = "failed to connect to all addresses; last error: INTERNAL: ipv4:<IP_ADDRESS>:8070: Trying to connect an http1.x server"
debug_error_string = "UNKNOWN:failed to connect to all addresses; last error: INTERNAL: ipv4:<IP_ADDRESS>:8070: Trying to connect an http1.x server {created_time:"2023-03-24T03:42:26.522036003+00:00", grpc_status:14}"
What you expected to happen
I expect it could connect to the oap server without error
How to reproduce
use the setting I post above
Anything else
No response
Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

As far as I can tell, the NGINX setup looks correct and Python agent merely uses gRPC client to connect to a grpc server without other modifications.
Please check few things:
0. ngx_http_v2_module is installed in your nginx deployment, its not a default thing.

make sure the ssl certs are valid, or simply remove them and test if things can be connected first.


PluginManagerInspectionRule reporting incorrectly

See https://www.drupal.org/project/commerce/issues/3118136#comment-13551571

Hi @mglaman ,
Any plan to correct this in near future. It's throwing error in our build log.
Thanks,
Rajeev

It wasn't high on my radar. I've been focusing on autoloading improvements here. If this fix needs to be expedited, I am available for consulting contracts, or I welcome contributions as well. I don't have an expected time and date of when I would work on this.


[ART-3823] add blocks and version for jirabug

Codecov Report

Merging #315 (7af03aa) into master (7c70d79) will increase coverage by 2.29%.
The diff coverage is 44.03%.

@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
+ Coverage   30.65%   32.95%   +2.29%
==========================================
  Files          55       58       +3
  Lines        5349     5531     +182
  Branches     1179     1190      +11
==========================================
+ Hits         1640     1823     +183
+ Misses       3608     3584      -24
- Partials      101      124      +23

Impacted Files
Coverage Δ

elliottlib/cli/__main__.py
0.00% <0.00%> (ø)

elliottlib/cli/attach_bugs_cli.py
0.00% <0.00%> (ø)

elliottlib/cli/create_placeholder_cli.py
0.00% <0.00%> (ø)

elliottlib/cli/create_textonly_cli.py
0.00% <0.00%> (ø)

elliottlib/cli/verify_attached_bugs_cli.py
0.00% <0.00%> (ø)

elliottlib/openshiftclient.py
0.00% <ø> (-14.64%)
:arrow_down:

elliottlib/tarball_sources.py
32.22% <ø> (ø)

elliottlib/util.py
39.13% <ø> (-1.70%)
:arrow_down:

elliottlib/errata.py
37.22% <22.50%> (+0.16%)
:arrow_up:

elliottlib/cli/attach_cve_flaws_cli.py
42.15% <28.57%> (+0.25%)
:arrow_up:

... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4de9fb...7af03aa. Read the comment docs.


PositiveLongAttributeModel and PositiveDoubleAttributeModel getInvalidValueCause method is sensitive to null value

https://github.com/eclipse-leshan/leshan/blob/2afadfcc35f8ab78d471eee8f95c6213607e8ad5/leshan-core/src/main/java/org/eclipse/leshan/core/link/lwm2m/attributes/PositiveLongAttributeModel.java#L34
I guess 'null' value is supposed to be a valid use case to 'unset' an attribute; with this is not possible anymore with these implementations.
Sample test that was valid in M13 and is not anymore (it throws a NullPointerException) :
   @Test
   void create_pmin_attribute_with_null_value() throws Exception {
       LwM2mAttribute<Long> pmin = LwM2mAttributes.create(LwM2mAttributes.MINIMUM_PERIOD, null);
       assertThat(pmin.getValue()).isNull();
   }

But may be there is another way to create such 'unset' attribute ?

Thx testing and reporting this. :pray:
I look at this a little and for now, I'm not sure if this is a bug :thinking:
The "right" way to create an attribute without value is : LwM2mAttributes.create(LwM2mAttributes.MINIMUM_PERIOD); but I'm not sure what should be the right behavior for :LwM2mAttributes.create(LwM2mAttributes.MINIMUM_PERIOD, null); (I mean should we forbid null or allow it like if LwM2mAttributes.create(LwM2mAttributeModel<T>) method was called ?
Do you face this only in this test OR also in other more concrete case ?

I looked at Leshan code and we never call LwM2mAttributes.create(model, value) with a null value.
We also have some test which check that parsing "Notification" without value are OK :
https://github.com/eclipse-leshan/leshan/blob/2afadfcc35f8ab78d471eee8f95c6213607e8ad5/leshan-core/src/test/java/org/eclipse/leshan/core/link/lwm2m/attributes/DefaultLwM2mAttributeParserTest.java#L34-L57
So I think this is more about clarifying current API behavior.
Knowing that only some Attribute can be created empty, (I think only attribute of class "notification") maybe better to be strict and adapt code in this way :

LwM2mAttributes.create(model) must be the only way to create attribute without value.
only "notification" attribute can used with LwM2mAttributes.create(model)
LwM2mAttributes.create(model, value) any call of this method with null should raise an exception.
javadoc should be adapted

Let me know if you have any opinion about it.
I think this can be done after the 2.0.0-M14 release because this is not a critical behavior issue.
Let me know your opinion about that. :pray:

It was in a test use case, where we wanted to unset a value.
But I missed the other method call (has we use it in a generic way - with null and non null parameter).
This alternative works fine for us; we just have to null check beforehand and then call the right method. So we can handle it for our M14 update.
But it may seem inconsistent with DoubleAttributeModel for instance, where LwM2mAttributes.create(LwM2mAttributes.LESSER_THAN, null) is working fine.
It is a breaking change in the behaviour, maybe add this in the release note ?

It would be a great solution 👍

I push a fix about it in master : d9a0688.
Some tests are disabled because they don't pass. It should be fixed post 2.0.0-M14 release.

So now the 2.0.0-M14 is released, we should decide the expected behavior for LwM2mAttributes.create(model, value)  API.
My first thought was to be strict and never accept null as value for LwM2mAttributes.create(model, value)
But reading https://github.com/eclipse-leshan/leshan/issues/1542#issuecomment-1822949200, I understand that this could maybe mode convenient to be able to call LwM2mAttributes.create(model, value) with null value when possible.
@cyril2maq could you confirm that you think that 2nd solution sounds better to you ?

Indeed, it would be more convenient for our use case.
Usually I go for strictness, but here, as value=null is semantically correct, and is equivalent to .create(model) I do think it seems cumbersome to be strict.
So, allowing value=null sounds better to me.

Ok so I will go in that way.

I tried to fix this more properly at #1551.
@cyril2maq, Let me know if you want to review/look at it before I integrate it in master.
(no problem if you didn't have time to do that)

Sorry, I will not be able to review it.
Nevertheless, I did pull this commit, and I confirm that our tests are 🟢 with this commit (tests which previously failed due to the null value).

@cyril2maq thx for testing :pray:.
I integrated #1551 in master will be available in next release 2.0.0-M15.
I close this issue.


[SILValue] Prefer const_cast<> to C-style cast.

Prevents a quite spammy warning with new versions of clang
(in the particular case, trunk as per today).

@swift-ci smoke test

LGTM


nightly.openhasp links don't work for ttgo-t7-v1.5_ili9341

Hi all:
https://nightly.openhasp.com/firmware/ttgo-t7-v1.5_ili9341_ota_v0.7.0-rc9_b7283c9.bin
https://nightly.openhasp.com/firmware/ttgo-t7-v1.5_ili9341_full_4MB_v0.7.0-rc9_b7283c9.bin
these links don't work, get 404 error

Thanks for reporting. There was a typo in the firmware file. This is now fixed for TTGO T7 v1.5.


Cluster not able to work: Cannot use this mongo host.

Thanks a lot for this, this is great.
I have it working on a solo MongoDB instance.
However I have three in a cluster and each say the same thing.
python /usr/local/bin/zabbix-mongodb.py
Cannot use this mongo host: must be one of ip1:27017,ip2:27017,ip3:27017
Any idea of what I need to change?

Have fixed the issue.
self.mongo_host = "interface IP"
localhost, <IP_ADDRESS> or hostname, fqdn did not work.
Putting the IP itself worked.


Saving project doesn't preserve map layer transparency (opacity)

This issue was imported from CodePlex
jirikadlec2 wrote 2012-01-26 at 03:21
Add a polygon layer to the map
change the color "opacity" (transparency) to 50%
save as a dspx project
re-open the project
the layer in the opened project is not transparent although the transparency should be 50%

Not reproduced.


Vox uniquities

About the PR

Voxes are now generally less affected by poison, rads, caustic, and genetic damage but are more vulnerable to slash and bloodloss
it's pretty okay, not having to worry about poison and rad bs is fun
Why / Balance

Technical details

Media

[ ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

ready for merge
i'll make another pr if I can think of something else to add later

I should deny this for your small unfunny jokes
Merged.

Never mind, Github refuses to let me merge for some reason.

it WAS drafted but it now open so I dunno why it wouldn't let you merge

merged


UIWebView deprecated by iOS

Hi 👋
UIWebView is now deprecated and app that use it can't be pushed anymore to the appstore. It looks like this module use it, it should be update with the new module WKWebView.
I'm not a native developer, is the update complicated ? Do you plan to do it ?
Thanks !

this PR solve this issue : https://github.com/wix/react-native-keyboard-tracking-view/pull/33


Bump Roon-Server to latest version and fix bug

Motivation for this change
Update to the newest Roon version and fix bug with ZLib.
The newest version of Roon won't work without zlib. It took me a while to figure this out and truth being told I'm not fully sure this is the best way of going about it.
I run this at home and it works fine, but I'd prefer adding the appropriate zlib into a PATH somehow, instead of making symbolic links.
Can Mono's DLL mapping be used somehow?
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

cc @Steell you might find this useful

Also: this can use ffmpeg instead of ffmpeg_3.

Also: RAATServer seems to not be able to find ALSA on NixOS. I suspect we may need to patchelf it.

Updated within #93715.


Upload MEG scripts

this includes:

preprocessing
source modelling
GED
connectivity
activation

@oscfer88 quick question does this PR include both yours and @yilingsp Ling's code?

no, I am still try to figure out how to put my code on this repository, If all my code already on an folder called ROI_MVPA, how should I do to uploading my code to the correct location?
Best
Ling
@.***
From: Praveen Sripad
Date: 2023-06-16 18:16
To: Cogitate-consortium/cogitate-msp1
CC: Ling Liu (PKU); Mention
Subject: Re: [Cogitate-consortium/cogitate-msp1] Upload MEG scripts (PR #14)
@oscfer88 quick question does this PR include both yours and @yilingsp Ling's code?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: @.***>

@nbonacchi changes were approved but I still see that Merging into main is blocked, what are we missing?

done!


Selecting colorField to be shown in entries list gives 400 bad request error

So I am trying to display the color the user select for a specific entry in the Entries list in the CP.
Steps to reproduce:

Create a colorField and add it to and Entry
Select the colorField to be displayed in the Entries list

Good to know that my colorField has its options defined in the colour-swatches.php config file.
Error message displayed in debug toolbar:

ah good spot @bzin - expect a bug fix later on today.


Why is the huaweicloud.sdk.obs NuGet package not officially published

Hello Huawei Cloud team,
I noticed that the huaweicloud.sdk.obs package is not available as an official NuGet package. Other Huawei Cloud SDK packages are published on NuGet, but this one seems to be missing.
This package is critical for developers using Huawei Cloud Object Storage Service (OBS) in .NET projects, and having it available through NuGet would greatly simplify dependency management and integration.
Could you please provide some insight into why this package has not been published? Are there any plans to release it officially on NuGet?
Thank you for your support and looking forward to your response.

安装sdk请参考此文档：https://support.huaweicloud.com/sdk-dotnet-devg-obs/obs_25_0105.html


[Bug]: API Access with Client Credentials - Basic Authentication doesn't work as expected

Preflight Checklist

[X] I could not find a solution in the documentation, the existing issues or discussions
[ ] I have joined the ZITADEL chat

Version
latest
Describe the problem caused by this bug
both https://github.com/zitadel/examples-api-access-and-token-introspection/tree/main/service-user-client-credentials and https://zitadel.com/blog/2023-03-23-api-access-and-introspection-04.png at https://zitadel.com/blog/api-access-and-introspection shows API Access with Client Credentials - Basic Authentication. I run the exampleop and followed this flow:

generated the access_token https://myexample.com/realms/csd/oauth/token and got it back {"access_token":"9u5_ajxFVCtmL8HIN2itc-DmjrIzRFpHu65O0LA-cqL_Nnk_zO6ktR98tCC0ZIXcskOPt9c-5tCxFpdP","token_type":"Bearer","expires_in":299}
manually validate the access_token, simulating a RS,

curl --location 'https://myexample.com/realms/csd/oauth/introspect' \
--header 'Authorization: Bearer 9u5_ajxFVCtmL8HIN2itc-DmjrIzRFpHu65O0LA-cqL_Nnk_zO6ktR98tCC0ZIXcskOPt9c-5tCxFpdP'

but got:
ErrorType=invalid_client Parent=client_id missing from request
To reproduce

generate a Bearer token with grant type of client credential
validate this Bearer token by calling the instrospect endpoint

Screenshots
No response
Expected behavior
The Bearer token should be successfully validated since this is how OAuth2/OIDC  directs
Additional Context
No response

As shown in the docs and example, the introspection is an protected endpoint and the client / API needs to authenticate itself in order to check the token (of the client / user).
In your curl you send the client / user token as a header. This needs to be sent as part of the request in the body:
https://zitadel.com/docs/apis/openidoauth/endpoints#introspection_endpoint


[RESTEASY-3097] Add a default exception mapper. Jakarta REST 3.1 sect…

…ion 4.4.
https://issues.redhat.com/browse/RESTEASY-3097
@marekkopecky I made some changes to some tests which made some assumptions about what is logged. These relied on log messages being logged because errors where thrown. However, this does not happen when an ExceptionMapper is used. In the DefaultExceptionMapper I do log the messages to debug which seems to be enough for the tests. But because of RESTEASY-2056 and RESTEASY-2106 I wanted to check if this was acceptable.
I did also remove some assumptions with logs about implementation specifics. The actual log text is implementation specific, but package names seemed odd to look for IMO.
We could log these at a level other than DEBUG. I was just concerned with it being too verbose, however maybe that's fine.

The PR looks good to me.


Does Lineseries and Candlestick  only work with 'yyyy-mm-dd'?

When making a chart that is under the daily timeframe, I am returned an error.  It appears that the only allowed date format is yyyy-mm-dd instead of yyyy-mm-dd-hh-mm-ss.  I need my chart to be able to read data with timeframes under the daily. I dont know why this would be the case.
repl

You can use UTCTimestamp instead of string. https://tradingview.github.io/lightweight-charts/docs/api#utctimestamp

If your chart displays an intraday interval you should use a UNIX Timestamp.
Note that JavaScript Date APIs like Date.now return a number of milliseconds but UTCTimestamp expects a number of seconds.

I am not able to import that module from lwc. I have converted to UTC and the lineseries plots out of order even though my array is sorted by date

I tried that example but get an error that UTCTimestamp is not exported by LWC.  Is it not simply taking millisecond time and dividing it by 1000?

right, so milliseconds / 1000 should give me the appropriate result correct?

Yes. Right. Just use milliseconds divided by 1000.

Ok good, thats what I did.  It works on daily and weekly (which is great), but when you go intra-day, I get 'Uncaught error value is null' but there is no null values in my data and its on the the same date format.

I can't help you without reproduction of the error. Make sure your data is consistent over time and and ordered chronologically


[Question] Usage in Modpacks

Greetings,
I'm currently working on a VulkanMod based performance Modpack and would like to include this particular mod as well. However, I haven't found any information about the usage in Modpacks in the description.
What am I allowed to do?

Feel free to include the mod in any modpack you like :)
Also, you usually can assume any mod can be included in modpacks, unless stated otherwise in the description.


multi channel stereo support for audio

Have you read the FAQ and checked for duplicate open issues?
yes
Is your feature request related to a problem? Please describe.

I am facing a problem where the stream contains 8 audio channels a multichannel stereo, the player most of the time plays without audio or occasionally returns error 3016 PIPELINE_ERROR_DECODE: Failed to send audio packet_6 duration=0 size=256 is_key_frame=1 encrypted=0
Describe the solution you'd like

it should play along with the audio with the min bandwidth
Describe alternatives you've considered

I have tested in shaka version 2.5.13 and stereo works fine but multichannel stereo either plays the video without audio or returns error (should've support a nice thing to have options to select audio)
Additional context

Audio 8 channel << playable without audio
https://cdn-mola-primary-01.akamaized.net/Content/DASH/VOD/18544/12476/6c5df5d3-e5f2-4ced-913c-87e8e70da2cc/66484355-ae63-ece2-716f-643a4e39e54d/manifest_L2.mpd?hdnts=st=1602150006~exp=1602153606~acl=/*~hmac=c3b6c911c227c63badc42c5d99889d2c31b1a1a922d4cbc7195fa2639c8cefa4
Audio 2 channel << playable with audio
https://cdn-mola-primary-01.akamaized.net/Content/DASH/VOD/8634/578/1a7bf651-db53-49f6-89f5-d205811bf3eb/66484355-ae63-ece2-716f-643a4e39e54d/manifest_L2.mpd?hdnts=st=1602150223~exp=1602153823~acl=/*~hmac=ebc5c6ab42a31cb202d3bbcfda37108bf7cbe2c3282607109183db2deffb3480
Error with multichannel stereo of audio 8 channel

General info of multichannel for audio 8 channel
General
Complete name              : C:\Users\user\AppData\Local\Temp\16020940814350\MOSHBDL0029-BUNDESLIGA HL 2021--FC Bayern München - Hertha Berlin IM.mxf
Format                  : MXF
Commercial name             : XDCAM HD422
Format version              : 1.2
Format profile              : OP-1a
Format settings             : Closed / Complete
File size                : 879 MiB
Duration                 : 2 min 3 s
Overall bit rate             : 60.0 Mb/s
Package name               : Source Package
Encoded date               : 2020-10-04 18:50:23.000
Writing application           : Adobe Systems Incorporated Premiere Pro <IP_ADDRESS>.1
Writing library             : Mac OS X <IP_ADDRESS>.1
Video
ID                    : 512
Format                  : MPEG Video
Commercial name             : XDCAM HD422
Format version              : Version 2
Format profile              : 4:2:2@High
Format settings             : CustomMatrix / BVOP
Format settings, BVOP          : Yes
Format settings, Matrix         : Custom
Format settings, GOP           : M=3, N=12
Format settings, picture structure    : Frame
Format settings, wrapping mode      : Frame
Codec ID                 : 0D01030102046001-0401020201040300
Duration                 : 2 min 3 s
Bit rate mode              : Constant
Bit rate                 : 50.0 Mb/s
Width                  : 1 920 pixels
Height                  : 1 080 pixels
Display aspect ratio           : 16:9
Frame rate                : 25.000 FPS
Standard                 : Component
Color space               : YUV
Chroma subsampling            : 4:2:2
Bit depth                : 8 bits
Scan type                : Interlaced
Scan order                : Top Field First
Compression mode             : Lossy
Bits/(Pixel*Frame)            : 0.965
Time code of first frame         : 00:00:00:00
Time code source             : Group of pictures header
Stream size               : 733 MiB (83%)
Color range               : Limited
Color primaries             : BT.709
Transfer characteristics         : BT.709
Audio #1
ID                    : 768
Format                  : PCM
Format settings             : Little
Format settings, wrapping mode      : Frame (AES)
Codec ID                 : 0D01030102060300
Duration                 : 2 min 3 s
Bit rate mode              : Constant
Bit rate                 : 1 152 kb/s
Channel(s)                : 1 channel
Sampling rate              : 48.0 kHz
Frame rate                : 25.000 FPS (1920 SPF)
Bit depth                : 24 bits
Stream size               : 16.9 MiB (2%)
Locked                  : Yes
Audio #2
ID                    : 1024
Format                  : PCM
Format settings             : Little
Format settings, wrapping mode      : Frame (AES)
Codec ID                 : 0D01030102060300
Duration                 : 2 min 3 s
Bit rate mode              : Constant
Bit rate                 : 1 152 kb/s
Channel(s)                : 1 channel
Sampling rate              : 48.0 kHz
Frame rate                : 25.000 FPS (1920 SPF)
Bit depth                : 24 bits
Stream size               : 16.9 MiB (2%)
Locked                  : Yes
Audio #3
ID                    : 1280
Format                  : PCM
Format settings             : Little
Format settings, wrapping mode      : Frame (AES)
Codec ID                 : 0D01030102060300
Duration                 : 2 min 3 s
Bit rate mode              : Constant
Bit rate                 : 1 152 kb/s
Channel(s)                : 1 channel
Sampling rate              : 48.0 kHz
Frame rate                : 25.000 FPS (1920 SPF)
Bit depth                : 24 bits
Stream size               : 16.9 MiB (2%)
Locked                  : Yes
Audio #4
ID                    : 1536
Format                  : PCM
Format settings             : Little
Format settings, wrapping mode      : Frame (AES)
Codec ID                 : 0D01030102060300
Duration                 : 2 min 3 s
Bit rate mode              : Constant
Bit rate                 : 1 152 kb/s
Channel(s)                : 1 channel
Sampling rate              : 48.0 kHz
Frame rate                : 25.000 FPS (1920 SPF)
Bit depth                : 24 bits
Stream size               : 16.9 MiB (2%)
Locked                  : Yes
Audio #5
ID                    : 1792
Format                  : PCM
Format settings             : Little
Format settings, wrapping mode      : Frame (AES)
Codec ID                 : 0D01030102060300
Duration                 : 2 min 3 s
Bit rate mode              : Constant
Bit rate                 : 1 152 kb/s
Channel(s)                : 1 channel
Sampling rate              : 48.0 kHz
Frame rate                : 25.000 FPS (1920 SPF)
Bit depth                : 24 bits
Stream size               : 16.9 MiB (2%)
Locked                  : Yes
Audio #6
ID                    : 2048
Format                  : PCM
Format settings             : Little
Format settings, wrapping mode      : Frame (AES)
Codec ID                 : 0D01030102060300
Duration                 : 2 min 3 s
Bit rate mode              : Constant
Bit rate                 : 1 152 kb/s
Channel(s)                : 1 channel
Sampling rate              : 48.0 kHz
Frame rate                : 25.000 FPS (1920 SPF)
Bit depth                : 24 bits
Stream size               : 16.9 MiB (2%)
Locked                  : Yes
Audio #7
ID                    : 2304
Format                  : PCM
Format settings             : Little
Format settings, wrapping mode      : Frame (AES)
Codec ID                 : 0D01030102060300
Duration                 : 2 min 3 s
Bit rate mode              : Constant
Bit rate                 : 1 152 kb/s
Channel(s)                : 1 channel
Sampling rate              : 48.0 kHz
Frame rate                : 25.000 FPS (1920 SPF)
Bit depth                : 24 bits
Stream size               : 16.9 MiB (2%)
Locked                  : Yes
Audio #8
ID                    : 2560
Format                  : PCM
Format settings             : Little
Format settings, wrapping mode      : Frame (AES)
Codec ID                 : 0D01030102060300
Duration                 : 2 min 3 s
Bit rate mode              : Constant
Bit rate                 : 1 152 kb/s
Channel(s)                : 1 channel
Sampling rate              : 48.0 kHz
Frame rate                : 25.000 FPS (1920 SPF)
Bit depth                : 24 bits
Stream size               : 16.9 MiB (2%)
Locked                  : Yes
Other #1
ID                    : 0-Material
Type                   : Time code
Format                  : MXF TC
Frame rate                : 25.000 FPS
Time code of first frame         : 00:00:00:00
Time code settings            : Material Package
Time code, striped            : Yes
Title                  : Timecode
Other #2
ID                    : 0-Source
Type                   : Time code
Format                  : MXF TC
Frame rate                : 25.000 FPS
Time code of first frame         : 00:00:00:00
Time code settings            : Source Package
Time code, striped            : Yes
Other #3
Type                   : Time code
Format                  : SMPTE TC
Muxing mode               : SDTI
Frame rate                : 25.000 FPS
Time code of first frame         : 00:00:00:00

it is somewhat related to https://github.com/google/shaka-player/issues/2866
I can play it fine in 3.0.x but fails on 2.5.x

So it works in v3.x, right?  What is the reason for not upgrading to v3?  I'm getting a 403 error from the manifest URL.  Could you provide a accessible URL?  You can send them privately to<EMAIL_ADDRESS>if you can't post publicly.
3016 is a decoder error from the browser.  This usually means the browser can't play the media.  Usually there is nothing we can do, but the fact that it works in v3 means there may be a fix.  But it can be hard to locate and would be much better for you to just update to v3.
Also the media info you posted doesn't make much sense.  If appears to use a MXF container, which probably isn't supported by the browser and there appear to be multiple audio streams.  Wrapping multiple audio streams within a single file isn't supported.  We officially support audio and video in different streams and mostly support multiplexed (audio+video) streams, but that is dependent on browser support.

@TheModMaker I have sent the .mpd files to the link and apparently what hinders us from upgrading from 2.5.x to 3.0.x is breaking changes. On 2.5.x I keep getting audio_decode_error and video plays without sounds. Version 3.0.x and I notice there are several changes on audio codec and such, I was hoping if shaka team could help(perhaps cherry-pick).

@JaenalLeeGenMao, do you still have this issue with the latest releases, v3.0.6 and v2.5.18?
Decode errors such as PIPELINE_ERROR_DECODE are likely to be out of our direct control, as decoding happens inside the browser.

@JaenalLeeGenMao, do you still have this issue with the latest releases, v3.0.6 and v2.5.18?
Decode errors such as PIPELINE_ERROR_DECODE are likely to be out of our direct control, as decoding happens inside the browser.


ProxySession cleanup: moving inline functions to .h

@shinrich request we move non-virtual, one-liner functions to the .h with "inline" keyword.

Ready for review. @maskit @shinrich

I don't want to use inline unless it has huge difference in performance. Can you show me how much this improve performance?
Having implementations in headers brings dependencies in some cases, and it makes writing unit tests hard. As you know, we have a file for ugly stubs because of complex chained dependencies.
It also causes link issues actually. I don't remember what the function was, but just removing inline somewhere in iocore caused duplicate symbol error or something like that. Usually inline is just a hint for compilers but we depend on it somehow.

move non-virtual, one-liner functions to the .h with "inline" keyword

This rule should be stated somewhere on docs if we did this. Of course with a consensus on the list.

I think for trivial methods (e.g. simple class member accessors), you definitely don't want to incur the function call overhead.  If the function body is not in the header, I think it is highly unlikely that the compiler will pull it in.  But maybe that is not the case,  could be the compiler is smart enough to figure that out.  I'll try to run an experiment on that.  If the compiler can still inline trivial methods, I am fine with the declaration/definition separation.
I agree with @maskit on the inline keyword.  I normally just keep the implementation in the class, but @SolidWallOfCode showed me that if you have the implementation in the header, separate from the class definition you do need the inline keyword, at least with our current generation of gcc compilers.  Otherwise, you get the duplicate symbol errors.

I read some recent documents and articles about inline, and my conclusion is "No cheap tricks and let it be as compilers like".  I may not get the best executable, but it wouldn't be terrible.
https://en.cppreference.com/w/cpp/language/inline
https://pabloariasal.github.io/2019/02/28/cpp-inlining/

@ywkaras was testing some of this yesterday. We were curious if g++ optimization would effectively inline code from one .cc to another .cc. If so then there is no reason to inline ever.
Overall I would tend to agree with @maskit, we should avoid optimizing code unless it has a measurable, statistically significant performance increase. And even then there are strong advantages to keeping code human-readable for future iterations and maintenance.

This indicates that inlining does not happen if the body of a function appears in a different .cc file:
(conanrunenv) [root@d761696b8abf http2]# fgrep is_body_done *.cc *.h
Http2ConnectionState.cc:    if (len == 0 && !stream->is_body_done()) {
Http2ConnectionState.cc:  if (!stream->is_body_done() && payload_length == 0) {
Http2ConnectionState.cc:  if (stream->is_body_done() && !_sm->is_read_avail_more_than(0)) {
Http2Stream.cc:Http2Stream::is_body_done() const
Http2Stream.h:  bool is_body_done() const;
(conanrunenv) [root@d761696b8abf http2]# make V=1 Http2ConnectionState.o
depbase=`echo Http2ConnectionState.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
c++ -DHAVE_CONFIG_H -I. -I../../include  -Dlinux -D_LARGEFILE64_SOURCE=1 -D_COMPILE64BIT_SOURCE=1 -D_REENTRANT -D__STDC_LIMIT_MACROS=1 -D__STDC_FORMAT_MACROS=1 -I/Users/wkaras/REPOS/TS/iocore/eventsystem -I/Users/wkaras/REPOS/TS/iocore/net -I/Users/wkaras/REPOS/TS/iocore/net/quic -I/Users/wkaras/REPOS/TS/iocore/aio -I/Users/wkaras/REPOS/TS/iocore/hostdb -I/Users/wkaras/REPOS/TS/iocore/cache -I/Users/wkaras/REPOS/TS/iocore/utils -I/Users/wkaras/REPOS/TS/iocore/dns -I/Users/wkaras/REPOS/TS/include -I/Users/wkaras/REPOS/TS/lib -I/Users/wkaras/REPOS/TS/mgmt -I/Users/wkaras/REPOS/TS/mgmt/utils -I/Users/wkaras/REPOS/TS/proxy -I/Users/wkaras/REPOS/TS/proxy/http -I/Users/wkaras/REPOS/TS/proxy/hdrs -I/Users/wkaras/REPOS/TS/proxy/shared -I/Users/wkaras/REPOS/TS/proxy/http/remap  -D_GNU_SOURCE -I/opt/oath/openssl/1.1.1/include -DOPENSSL_NO_SSL_INTERN -I/opt/oath/brotli/1.0/include -std=c++17 -g -pipe -Wall -Wextra -Wno-ignored-qualifiers -Wno-unused-parameter -Wno-format-truncation -Wno-cast-function-type -Wno-stringop-overflow -O3 -feliminate-unused-debug-symbols -fno-strict-aliasing -Werror -Wno-invalid-offsetof -Wno-noexcept-type -mcx16  -MT Http2ConnectionState.o -MD -MP -MF $depbase.Tpo -c -o Http2ConnectionState.o Http2ConnectionState.cc &&\
mv -f $depbase.Tpo $depbase.Po
(conanrunenv) [root@d761696b8abf http2]# objdump --syms --demangle Http2ConnectionState.o | fgrep is_body_done
0000000000000000         *UND*<PHONE_NUMBER>000000 Http2Stream::is_body_done() const
(conanrunenv) [root@d761696b8abf http2]#

From what I've heard, efforts to do inter-.cc-file inlining ( for example https://gcc.gnu.org/wiki/LinkTimeOptimization ) are still flakey.
For non-inlined small functions, gcc seems to do pretty well at optimizing out unnecessary stack operations as long as the optimization level is at least 2 (TS uses level 3):  https://godbolt.org/z/9Fx6CA

@maskit do have you blocking concerns with this change.
IMO, I don't care as long as the declaration and definition are separate. I would like the code organized so I can focus on macro optimizations. Inlining in the header file will not have worse performance, but it is unclear if it is faster. And I don't have time to do test performance metrics.

I can live with definitions in header files, but want explicit rules on the doc. Otherwise people would put definitions randomly in the future.
Also, it's not only about performance. Definitions bring dependencies. Remember libUglyLogStubs.

I agree with @maskit that this is a trade-off between performance and snow-balling dependencies.  In this particular case, I don't think the dependencies are an issue.
Where is the document on coding standards?  I can add something there.

Sorry for the late reply (I was away from hardware keyboards).
Here's the doc on coding standards.
https://cwiki.apache.org/confluence/display/TS/Coding+Style

Just for a note and I'm not sure at all, but Module that will be supported on C++20 might resolve some of this complication.
https://www.infoq.com/news/2019/07/cpp20-draft-finalized/

Module support will be orthogonal to namespaces and will enable the structuring of large codebases into logical parts without requiring the separation of header and source files.

Cherry-picked to v9.0.x branch.


The login button doesn't work on my website, but works localhost

The title says most of my issue... I managed to set it up to work on my localhost using xampp. However when I upload it and click the login button, I return to the same url with "?login" tacked at the end (of the url). I am not sure what the issue is, I changed setting to redirect to my domain name (and not local host), but I am without a clue.
Here's some of my host's info: http://i.imgur.com/kpJWCEZ.png
And here's a link to my site, with the issue: http://potders.com/awesome-stats/

I see someone else was having the same problem, but they closed their question and also wasn't sure what fixed it. This is the FULL php file that I am using for the login button.
http://pastebin.com/TdFeJuuS

You need to include steamauth at the beginning of your script before any text output.

Thanks BlackCetha, that seems to have fixed it! Such a simple mistake! Thanks so much!


PM-3133: Block executor

Added a BlockExecutor component to farm out the ExecuteBlocks effects from the ConsensusService. It has an internal work queue where batches are added. A successful execution is noted down in the ViewStateStorage. The actual execution is delegated to the ApplicationService. If there's an error, we try again next time there's a new batch.
If the ConsensusService and the SyncService skip ahead to a newer Commit Quroum Certificate, and the last executed block is no longer available, the BlockExecutor skips blocks too. Not much else it can do. These events are traced.

I feel we've discussed the main code sufficiently when discussing PM-3108/3110, and I'm happy with it 👍 , so I'm focusing my review on the tests

@rtkaczyk on the point of skipped executions I got into a dilemma about this scenario:

The block executor starts executing a batch A, B, C and D.
Things are going slow, currently executing B.
Meanwhile, the consensus gets out of sync and decides it needs to jump ahead.
The federation is on block F, we sync there by downloading the state of F.
Race condition happens: B is finished and set as the last executed block hash, then F is set as the last executed block hash, but only after the executor set B, so the executor carries on with the next block.
The executor executes C, tries to set the last hash to C but realises it's not B any more, so it skips D.

Executing C without realising that we are already in state F could be bad. My first thought was that this can be handled by the ApplicationService:

It can use a Semaphore to make sure it's not doing stateSync and executeBlock at the same time. However that doesn't solve the above issue alone.
It can maintain a lastExecutedBlockHashRef of its own and check in executeBlock that block.parentHash == lastExecutedBlockHash, and also set it in stateSync.

I thought this is too much lore to get right, so I moved the call to stateSync and the subsequent fastForwardStorage from SyncService to the BlockExecutor, and added a semaphore around the critical sections. This should make sure that we would not be executing C because first we execute A,B,C and D completely before syncing to E.
I know you said the BlockExecutor does too much, and now it does even more, but I reckon the overall semantics are easier to follow this way.
I also modified ApplicationService.syncState to return a flag to indicate whether it's okay to prune away old blocks, although this could be a constructor argument as well.

It was on my list to look for race conditions regarding lastExecutedBlockhash, but it seems you fixed it before I got a change. Cool 🎉


[Avalanche] Created 1inch connector

[x] Build 1inch connector
[x] deploy and comment address

Deployed on Avalanche:
name : 1INCH-V4
address : 0x63995c71e2f57d0aF786485E255A805603e54e76


Malware urls

https://blog.netlab.360.com/stealth_rotajakiro_backdoor_en/
A recently discovered piece of malware sends data to urls could they be added to the list plox
news.thaprior.net
blog.eduelects.com
cdn.mirror-codes.net
status.sublineover.net

Thanks @NO-ob these are added in commit 97766531
Closing.

Thankyou


Shared libraries miss an so version

cmake doesn't define an so version for the shared libs.
I will submit a pull-request shortly.

The lack of an SOVERSION was intentional since at the time there was no versioning of Legion.  Since that appears to have changed now then we can set the SOVERSION correctly instead of just arbitrarily.


synlig -h and synlig -f xxx should print list of available frontends

Thanks!    In my case I eventually switched to using a tcl script and using read_systemverilog from there, but this will make it more friendly for someone just trying to run a  small sample file through synlig.


🐛 [cloud_firestore] version solving failed upon importing the null safe package

Importing null safe clould_firestore: ^1.0.0-1.0.nullsafety.0  fails because it cant solve the versions of its dependencies.
Because cloud_firestore >=0.17.0-1.0.nullsafety.2 depends on cloud_firestore_platform_interface >=4.0.0-1.0.nullsafety.2 <4.0.0-2.0.nullsafety.0 which depends on firebase_core >=0.8.0-1.0.nullsafety.2 <0.8.0-2.0.nullsafety.0, cloud_firestore >=0.17.0-1.0.nullsafety.2 requires firebase_core >=0.8.0-1.0.nullsafety.2 <0.8.0-2.0.nullsafety.0.
So, because project_charlie depends on cloud_firestore ^1.0.0-1.0.nullsafety.0 which depends on firebase_core >=1.0.0-1.0.nullsafety.0 <1.0.0-2.0.nullsafety.0, version solving failed.
pub get failed (1; So, because project_charlie depends on cloud_firestore ^1.0.0-1.0.nullsafety.0 which depends on firebase_core >=1.0.0-1.0.nullsafety.0 <1.0.0-2.0.nullsafety.0, version solving failed.)

flutter doctor -v
[√] Flutter (Channel beta, 1.26.0-17.6.pre, on Microsoft Windows [Version 10.0.18363.1379], locale en-US)
    • Flutter version 1.26.0-17.6.pre at C:\src\flutter
    • Framework revision a29104a69b (7 days ago), 2021-02-16 09:26:56 -0800
    • Engine revision 21fa8bb99e
    • Dart version 2.12.0 (build 2.12.0-259.12.beta)

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.3)
    • Android SDK at C:\Users\Dev-01\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.3
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Android Studio (version 4.1.0)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] Connected device (2 available)
    • Chrome (web) • chrome • web-javascript • Google Chrome 88.0.4324.182
    • Edge (web)   • edge   • web-javascript • Microsoft Edge 88.0.705.68

• No issues found!

Hi @grinder15
There is already an issue to track version solving problems with cloud_firestore nullsafety https://github.com/FirebaseExtended/flutterfire/issues/4959.
Please comment this there and follow up on that issue.
Thank you


Enhancement: dependency:install add a filter based on releasedefinition

As (almost) all commands allow to filter on releasedefinition file, It will be helpfull to have this filter on dependency:install too
recreating from https://github.com/dxatscale/sfpowerscripts/issues/1445, as I thinks it's still pertinent

Issue solved on #108.
It will be available in the next release.
Thank you for your contribution @alanjaouen


Exercism Nitpickers POV - Remove skips?

I personally find the skips a bit annoying as they need to be removed over and over.
I understand the idea is not to overwhelm the user with errors... it seems like a nice idea but gets old after a while.
If I only want to work on one case, I can just solve the first failure and rerun!
A middle ground could be to have them on the first n exercises and not after that.
Thoughts?

They don't need to be removed at all.  See the README in the root.  Also linked here for convenience.

I'm speaking more from the POV of a consumer of the exercism CLI client.
I think its ultimately a distraction (moreso than multiple failing tests) to the primary focus of exercisms... learning to code/a new language/write super-clean code.

When the failures come in no particular order, how does that work to assist an orderly and progressive solution?  The tests will be ran in no particular order when you do comment them out.
This means that you need to know the testing tool so that you can specify which test to run, which feature you are working on... that is not a bad thing to know... for sure.

I didn't realize that minitest shuffles the order of your tests.
That certainly complicates things. Of course, we could also override this.

I would prefer not to use the method that is required to do such a thing, we want to get better than that. :sweat_smile: but I would be for educating folks on how to use minitest to only test the one thing that they need, or a category of things that they need.
In the short run, especially if they are just learning their tools, the editor they use; the testing framework, and the language, yes, it makes things a little bit, well, just, 'more'.
In the long run, you learn your tools and flourish, or you don't and continue to feel like things are getting in your way.  I prefer to give that feeling of freedom.
It starts somewhere, it may as well start with us.
I am happy to see some documentation improvements, I think @kytrinyx is looking forward to this as well.
I do need to update the documentation on that side for running pretty tests and showing test names.  Adding a section on how to run a single test or a subset of tests may be helpful there.  We will see.

I did write the hack for running tests in the order that they were defined a couple years ago: https://github.com/kytrinyx/minitest-homework
There is a way to get a consistent order in minitest (i_suck_and_my_tests_are_order_dependent!) but that runs them in alphabetical order, and I also don't want to tell people that they (or we) suck. The context here is different.
I would be all for figuring out how to help people figure out how to fix this for themselves (write hacks, create aliases, etc).

I'm kind of coming around to the idea that skips are the least evil way to deal with the test shuffling. I think explicitly stating this in the documentation would be a good thing. Right now, referencing skips, it just says: This is so that you don't have to deal with all the failures at once.

That's a great point. We should explain the thing about the order being shuffled, and that the skips help with that as well as the all at once thing... and maybe we could point to the "disable skips" script we have in this repo and suggest that they do something similar if they don't want to deal with skips.

The changes will end up at http://exercism.io/languages/ruby but should we also have this information downloaded in the README that is in the exercise folders @kytrinyx, when we fetch them?
This means changing ./SETUP.mdin root.

I was thinking... shouldn't the TESTS stuff just get included directly in the README? We should discuss this over in x-common first so all the track maintainers can weigh in, but I think it makes sense to put the "how to run the tests" instructions in all the exercises directly.

I was kind of thinking so as well.  Though the README in the exercise does defer to the website.

Yeah, we might not need the stuff in SETUP if we include the TESTS.md, but we could also have the SETUP stuff. I'll open up the question in x-common.

Alright.  I was surprised this was merged in.  I have one change regarding the short version -n, rather than --name since some folks may use the nyan-cat reporter.

LOL. I have never even seen the nyan-cat reporter. That sounds kind of awful :)
Sorry I didn't mean to merge too quickly. I should have said LGTM and let you or @Cohen-Carlisle merge after a second pair of eyes were on it.

I was thinking about recording my terminal and sending you the text-cast style thing to watch. It is just a 'for-giggles' type of thing but really does stay out of the way.
Playing with a "How to customize your Gemfile for personal niceties" thing in a shared project while staying out of the way of the actual requirements.  Things that may be OS based, but not necessary for the actual program/project.

Peek at the branch that is now recreated (I did not notice that you deleted it, so it is sitting there.)


Documentation update

Recently we have set Business Central on Premise with AccessControlService credential type.
Windows Client works as expected but Web Client fails to open. Web Client was running authentication "infinite loop".
With Microsoft we have identified problems around settings for Sign-on URL (App URL), App ID URI, Reply URL, and WS-federation login endpoint.
What made difference :
a.	settings should be in lower case
b.	we have added character "/" on the end of the application

in Azure portal for AAD, App IU URI (e.g. https://cronusinternationltd.onmicrosoft.com/financials/  instead https://CRONUSInternationLtd.onmicrosoft.com/Financials)
in Azure portal for AAD, home page URL (e.g. https://cronusinternationltd.onmicrosoft.com/bc130/ instead https://CRONUSInternationLtd.onmicrosoft.com/BC130)
in Azure portal for AAD, single entry for “return url” with SignIn (e.g. https://cronusinternationltd.onmicrosoft.com/bc130/SignIn) instead https://dynamicsnavwinclient/
in CustomSettings.config for the NST:
o	for AppIdUri : https://cronusinternationltd.onmicrosoft.com/bc130/
o	for WSFederationLoginEndpoint :
https://login.windows.net/CRONUSInternationLtd.onmicrosoft.com/wsfed?wa=wsignin1.0%26wtrealm=https://cronusinternationltd.onmicrosoft.com/financials/%26wreply=https://cronusinternationltd.onmicrosoft.com/bc130/SignIn
instead
https://login.windows.net/CRONUSInternationLtd.onmicrosoft.com/wsfed?wa=wsignin1.0%26wtrealm=https://CRONUSInternationLtd.onmicrosoft.com/Financials%26wreply=https://CRONUSInternationLtd.onmicrosoft.com/BC130/SignIn

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0ff0aa19-50aa-c461-cd97-4be8fbe4e393
Version Independent ID: f72d929a-7fea-246f-8b2e-4f3b14c5c92d
Content: User Authentication with Azure AD for Single Sign-on - Business Central
Content Source: dev-itpro/administration/authenticating-users-with-azure-active-directory.md
Service: dynamics365-business-central
GitHub Login: @jswymer
Microsoft Alias: solsen

Thanks for the feedback! The content has been fixed and the update will be published soon.


Get-SshAgent return always 0

System Details

posh-git version/path:  0.7.3 /  C:\Program Files\WindowsPowerShell\Modules\posh-git
PowerShell version: 5.1.17134 revision 48
Git version: version 2.17.0.windows.1
Operating system name and version: windows 10, version 1803

Issue Description
Since last update of windows (1803), Start-SshAgent seems not working.
My profile.ps1
Import-Module "posh-git"
Start-SshAgent -Quiet
$ChocolateyProfile = "$env:ChocolateyInstall\helpers\chocolateyProfile.psm1"
if (Test-Path($ChocolateyProfile)) {
  Import-Module "$ChocolateyProfile"
}

Import-Module "Oh-My-Posh"

Get-SshAgent return always 0 and Git keeps prompting me for password.

From PowerShell, what path does this command return Get-Command ssh-agent.exe?

CommandType     Name                                               Version    Source
-----------     ----                                               -------    ------
Application     ssh-agent.exe                                      <IP_ADDRESS>    C:\WINDOWS\System32\OpenSSH\ssh-agent.exe

What happens if you run ssh-agent without the posh-git Start-SshAgent? The wrapper is really old, meant for the msys agent that ships with Git, not newer OpenSSH.

When I run ssh-agent nothing appear.
Get-Service -Name 'ssh-agent' return
Status   Name               DisplayName
------   ----               -----------
Running  ssh-agent          OpenSSH Authentication Agent

That seems promising. The other thing Start-SshAgent does is ssh-add, which should add private key identities from ~/.ssh/.

ssh-add -L return my private key ssh-rsa AAAAB...G1Q== ~/.ssh/id_rsa

But Git is still prompting you for your password?
I honestly have no idea if Git and Win32-OpenSSH are expected to play nicely together, or how to fix. I'll drop a note over in Git for Windows Gitter to see if someone can help.

When I launch my powershell session, powershell prompts me my password for my private key.
Windows PowerShell
Copyright (C) Microsoft Corporation. Tous droits réservés.

Enter passphrase for ~/.ssh/id_rsa:
Identity added: ~/.ssh/id_rsa (~/.ssh/id_rsa)
Le chargement des profils personnels et système a duré 90504 ms.
 ⚡ > ~ >

Tx! it's working

It sounds like Start-SshAgent should check if $sshAgent path includes OpenSSH. If it does:

Confirm the service is running; if it's not, should we start it?

What if the service isn't registered?

Check if GIT_SSH aligns with OpenSSH usage; if it doesn't, warn with instructions.

It sounds like Start-SshAgent should check if $sshAgent path includes OpenSSH

Using Path might be a bit brittle since folks can grab the OpenSSH-portable package from here and install into a path of their choosing.  We could check this way -
Get-Command ssh.exe | % FileVersionInfo | ? ProductVersion -match OpenSSH

Yup, we can only start the service if it has been registered.  If they installed the ZIP from the GH repo, the ssh-agent service won't be registered unless they've run the install-sshd.ps1 script.  That said, if they run the following command once from an Admin console, they'll never have to worry about starting ssh-agent again:
Get-Service ssh-agent | Set-Service -StartupType Automatic -PassThru | Start-Service

I suppose we could provide a warning if we detect that the ssh.exe in the path is the OpenSSH version and the user doesn't have GIT_SSH env var set appropriately.  We would probably want a way to allow folks to disable the warning (another import arg?).
BTW it isn't a single env var.  At my company we use Git with both TFS 2015 and Bitbucket.  In order to get the cipher suite to work for both, I use this env var:
GIT_SSH_COMMAND = "C:\Program Files\OpenSSH\ssh.exe" -c aes128-cbc

And the quotes around the path are needed even if there are no spaces in that path.

Just stumbled upon this as I was looking for a solution to this very problem. After adding the GIT_SSH environment variable and rebooting, I am now only asked for the password once for each new PowerShell window, and not every time.

If you have done the following:

Started the OpenSSH ssh-agent service (from C:\windows\system32\openssh)
Set up the ssh-agent service to start "Automatically"
Configured GIT_SSH to point to the OpenSSH ssh.exe e.g. GIT_SSH = C:\WINDOWS\System32\OpenSSH\ssh.exe
And used ssh-add <private-key-file-path> e.g. ssh-add ~\.ssh\id_rsa to add your private key file

You should never be asked for your passphrase.  In practice, I have found that I am sometimes asked for a passphrase after a Windows 10 insider build update.  That is always because the ssh-agent service isn't running.  As soon as I start it, I'm no longer asked for a passphrase.

@rkeithhill Thank you! Lifesaver!

GIT_SSH = C:\WINDOWS\System32\OpenSSH\ssh.exe

If, for some reason, you need to use a 32-bit git.exe, please use GIT_SSH = C:\WINDOWS\SysNative\OpenSSH\ssh.exe instead.

@rkeithhill I tried following your advice in https://github.com/dahlbyk/posh-git/issues/575#issuecomment-391386119 and ran into a hang, as described in https://github.com/PowerShell/Win32-OpenSSH/issues/1377... I'm not sure if I'm following up in the right place and thought you might have a more expert opinion 🙏

It probably because there was a bug in posh-git version 0.7.3 (also in <IP_ADDRESS>). In Get-SshAgent function in GitUtils.ps1, the command $sshAgentProcess = Get-Process | Where-Object { ($_.Id -eq $agentPid) -and ($_.Name -eq 'ssh-agent') } would never correctly work because $agentPid = $Env:SSH_AGENT_PID is always different from the PID of the Windows process ssh-agent.exe. Besides, return 0 was wrongly placed at the outer block. Therefore, Get-SshAgent would always return 0. Another consequence was that the function Stop-SshAgent was also invalid for the same reason. For the command $proc = Get-Process -Id $agentPid -ErrorAction SilentlyContinue, Get-Process could not get the actual process ID and $proc was always equal to 0 so that Stop-Process would never be executed (and it was not stopping the actual PID).


KFLUXINFRA-786: Add resource pool for ppc64le in public prod

This PR adds PPC64LE nodes reducing their concurrecy. This is to handle the issue of pods not getting assigned to the nodes.

/lgtm

@bamachrn Thanks!


[backport] Fix GroupNormalization tests

Backport of #7684

[automatic post] Jenkins, test this please.

Jenkins CI test (for commit eef2b7a130982d648b5502ff6598f32f70b305d0, target branch v6) failed with status FAILURE.


Adapt player app for addition of houseround table

The database has a new houseround table that replaces the bid table. The code needs to reflect these changes. See https://github.com/averbraeck/housinggame-common/issues/4 for the design information.
The measure table points to this houseround table instead of to the house table. This has to be changed as well.

General method have been adapted. Specific screens are adapted at the respective issues for these screens.


Update numpy dependency version issue in setup.py

Update numpy dependency version issue

Thank you for your contribution！


Multi-Select overlaps main content div in demo

The multi-select component shifts the end of the screen and thus creates a white border (very problematic with long lists). A scrollbar like in select2 would be a good solution.

Operating system and version: MacOS 11.6.1
Browser and version: all Browsers

Any updates?

You use date-coreui-options-max-height


engine: add changelog for 20.10.12

Proposed changes

Unreleased project version (optional)

Related issues (optional)

@justincormack @chris-crone @usha-mandya PTAL if the wording looks good to you


using vgg16 pretrained for multiclass classification

Hi,
I am trying to modify the keras examples for a three-class classification using vgg16 pretrained model. This is my code:
`import numpy as np
from keras.preprocessing.image import ImageDataGenerator
from keras.models import Sequential
from keras.layers import Dropout, Flatten, Dense
from keras import applications
from keras.optimizers import SGD
from keras import backend as K
K.set_image_dim_ordering('tf')
img_width, img_height = 224, 224
top_model_weights_path = 'bottleneck_fc_model.h5'
train_data_dir = 'data6/train'
validation_data_dir = 'data6/validation'
nb_train_samples = 300
nb_validation_samples = 60
epochs = 50
batch_size = 10
def save_bottlebeck_features():
datagen = ImageDataGenerator(rescale=1. / 255)
model = applications.VGG16(include_top=False, weights='imagenet', input_shape=(224, 224, 3))
generator = datagen.flow_from_directory(
train_data_dir,
target_size=(img_width, img_height),
batch_size=batch_size,
class_mode='categorical',
shuffle=False)
bottleneck_features_train = model.predict_generator(
generator, nb_train_samples // batch_size)
np.save(open('bottleneck_features_train', 'wb'),bottleneck_features_train)
generator = datagen.flow_from_directory(
validation_data_dir,
target_size=(img_width, img_height),
batch_size=batch_size,
class_mode='categorical',
shuffle=False)
bottleneck_features_validation = model.predict_generator(
generator, nb_validation_samples // batch_size)
np.save(open('bottleneck_features_validation', 'wb'),bottleneck_features_validation)
def train_top_model():
train_data = np.load(open('bottleneck_features_train.npy', 'rb'))
train_labels = np.array([0] * (nb_train_samples // 3) + [1] * (nb_train_samples // 3 + [2] * (nb_train_samples // 3)))
validation_data = np.load(open('bottleneck_features_validation.npy', 'rb'))
validation_labels = np.array([0] * (nb_validation_samples // 3) + [1] * (nb_validation_samples // 3 + [2] * (nb_validation_samples // 3))
model = Sequential()
model.add(Flatten(input_shape=train_data.shape[1:]))
model.add(Dense(128, activation='relu'))
model.add(Dropout(0.5))
model.add(Dense(3, activation='sigmoid'))
sgd = SGD(lr=0.1, decay=1e-6, momentum=0.9, nesterov=False)
model.compile(optimizer=sgd,
loss='categorical_crossentropy', metrics=['accuracy'])
model.fit(train_data, train_labels,
epochs=epochs,
batch_size=batch_size,
validation_data=(validation_data, validation_labels))
model.save_weights(top_model_weights_path)
save_bottlebeck_features()
train_top_model()`
I have highlighted the changes in bold that I have made to the example script.
I'm getting an invalid syntax at the line: model = Sequential()
Kindly help me with the correction. Looking forward.
Please make sure that the boxes below are checked before you submit your issue. If your issue is an implementation question, please ask your question on StackOverflow or join the Keras Slack channel and ask there instead of filing a GitHub issue.
Thank you!

[x] Check that you are up-to-date with the master branch of Keras. You can update with:
pip install git+git://github.com/fchollet/keras.git --upgrade --no-deps

[x] If running on TensorFlow, check that you are up-to-date with the latest version. The installation instructions can be found here.

[x] If running on Theano, check that you are up-to-date with the master branch of Theano. You can update with:
pip install git+git://github.com/Theano/Theano.git --upgrade --no-deps

[x] Provide a link to a GitHub Gist of a Python script that can reproduce your issue (or just copy the script here if it is short).

I am trying to achieve the same thing for multi Classification.
Code:
img_width, img_height = 128, 128
top_model_weights_path = 'bottleneck_fc_model.h5'
train_data_dir = 'data/train'
validation_data_dir = 'data/validation'
nb_train_samples = 676
nb_validation_samples = 132
epochs = 50
batch_size = 16
def save_bottlebeck_features():
datagen = ImageDataGenerator(rescale=1. / 255)
# build the VGG16 network
model = applications.VGG16(include_top=False, weights='imagenet')

generator = datagen.flow_from_directory(
    train_data_dir,
    target_size=(img_width, img_height),
    batch_size=batch_size,
    class_mode=None,
    shuffle=False)
bottleneck_features_train = model.predict_generator(
    generator, nb_train_samples // batch_size)
np.save('bottleneck_features_train.npy',
        bottleneck_features_train)

generator = datagen.flow_from_directory(
    validation_data_dir,
    target_size=(img_width, img_height),
    batch_size=batch_size,
    class_mode=None,
    shuffle=False)
bottleneck_features_validation = model.predict_generator(
    generator, nb_validation_samples // batch_size)
np.save('bottleneck_features_validation.npy',
        bottleneck_features_validation)

def train_top_model():
train_data = np.load('bottleneck_features_train.npy')
#labels = np.ones((train_data.shape[0],), dtype='int64')
#train_data = np_utils.to_categorical(labels, 4)
print(train_data.shape[1:])
train_labels = np.array(
[0] * (nb_train_samples // 4) + [1] * (nb_train_samples // 4) + [2] * (nb_train_samples // 4) + [3] * (nb_train_samples // 4))
validation_data = np.load('bottleneck_features_validation.npy')
validation_labels = np.array(
    [0] * (nb_validation_samples // 4) + [1] * (nb_validation_samples // 4) + [2] * (nb_train_samples // 4) + [3] * (nb_train_samples // 4))

model = Sequential()
model.add(Flatten(input_shape=train_data.shape[1:]))
model.add(Dense(256, activation='relu'))
model.add(Dropout(0.5))
model.add(Dense(4, activation='softmax'))
model.summary()
model.compile(optimizer='rmsprop',
              loss='categorical_crossentropy', metrics=['accuracy'])

model.fit(train_data, train_labels,
          epochs=epochs,
          batch_size=batch_size,
          validation_data=(validation_data, validation_labels))
model.save_weights(top_model_weights_path)

save_bottlebeck_features()
train_top_model()
But I get this error when I execute the lines of code above:
Error when checking target: expected dense_2 to have shape (None, 4) but got array with shape (676, 1)

Your declaration in validation labels is wrong. Change it to nb_validation_samples instead of train_samples
Sent from my iPhone

On Jul 7, 2017, at 3:55 PM, tosicky<EMAIL_ADDRESS>wrote:
I am trying to achieve the same thing for multi Classification.
Code:
img_width, img_height = 128, 128
top_model_weights_path = 'bottleneck_fc_model.h5'
train_data_dir = 'data/train'
validation_data_dir = 'data/validation'
nb_train_samples = 676
nb_validation_samples = 132
epochs = 50
batch_size = 16
def save_bottlebeck_features():
datagen = ImageDataGenerator(rescale=1. / 255)
build the VGG16 network
model = applications.VGG16(include_top=False, weights='imagenet')
generator = datagen.flow_from_directory(
train_data_dir,
target_size=(img_width, img_height),
batch_size=batch_size,
class_mode=None,
shuffle=False)
bottleneck_features_train = model.predict_generator(
generator, nb_train_samples // batch_size)
np.save('bottleneck_features_train.npy',
bottleneck_features_train)
generator = datagen.flow_from_directory(
validation_data_dir,
target_size=(img_width, img_height),
batch_size=batch_size,
class_mode=None,
shuffle=False)
bottleneck_features_validation = model.predict_generator(
generator, nb_validation_samples // batch_size)
np.save('bottleneck_features_validation.npy',
bottleneck_features_validation)
def train_top_model():
train_data = np.load('bottleneck_features_train.npy')
#labels = np.ones((train_data.shape[0],), dtype='int64')
#train_data = np_utils.to_categorical(labels, 4)
print(train_data.shape[1:])
train_labels = np.array(
[0] * (nb_train_samples // 4) + [1] * (nb_train_samples // 4) + [2] * (nb_train_samples // 4) + [3] * (nb_train_samples // 4))
validation_data = np.load('bottleneck_features_validation.npy')
validation_labels = np.array(
[0] * (nb_validation_samples // 4) + [1] * (nb_validation_samples // 4) + [2] * (nb_train_samples // 4) + [3] * (nb_train_samples // 4))
model = Sequential()
model.add(Flatten(input_shape=train_data.shape[1:]))
model.add(Dense(256, activation='relu'))
model.add(Dropout(0.5))
model.add(Dense(4, activation='softmax'))
model.summary()
model.compile(optimizer='rmsprop',
loss='categorical_crossentropy', metrics=['accuracy'])
model.fit(train_data, train_labels,
epochs=epochs,
batch_size=batch_size,
validation_data=(validation_data, validation_labels))
model.save_weights(top_model_weights_path)
save_bottlebeck_features()
train_top_model()
But I get this error when I execute the lines of code above:
Error when checking target: expected dense_2 to have shape (None, 4) but got array with shape (676, 1)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Add instructions for downloading kpt using gsutil

So I'm not sure if we should make this change. While we still publish the binaries directly to GS, we prefer if users download the binaries from github instead. That makes it easier for us to keep track of the popularity of kpt.
If it is inconvenient for users to download the tar.gz version currently published in the github release, is there an option where we can publish the binaries directly on github?

I was following the instruction to download kpt from GCS bucket and thought using gsutil rather than clicking on the download link would be easier given that I want to use kpt in a remote machine. If we prefer users to download from GitHub, should we remove the link in the doc?
I'd assume there's a way to track downloads from GCS bucket.

I'm more in favor of adding these instructions and track the logs on the gcs bucket (https://cloud.google.com/storage/docs/access-logs#should-you-use). Users can already get kpt through gcloud or homebrew so it makes sense to give them the option to download through gsutil.

@frankfarzan shall we merge this?

PTAL

@frankfarzan still relevant?  Should we merge?

@frankfarzan still relevant?  Should we merge?

I would prefer if we made the binaries available through github instead of GCS. I have created an issue for this: https://github.com/GoogleContainerTools/kpt/issues/1349

I would prefer if we made the binaries available through github instead of GCS. I have created an issue for this: https://github.com/GoogleContainerTools/kpt/issues/1349

@mortent question about your comment.  Is your concern that if we explain how to do this with GCS that we will increase the number of clients we would need to migrate?  If so we should close this issue.  If we will have to continue supporting GCS and this is just helpful for people who are want to know how to do this right now - maybe we should add the help?

@janetkuo Is this stale? I'm the process of deleting branches in the kpt repo. In general, PR should be based on your personal fork. Let me know if it's safe to delete this branch.

Please feel free to delete the branch.


Release @google-cloud/connect-datastore v2.0.0

This pull request was generated using releasetool.

Release is at https://github.com/googleapis/nodejs-datastore-session/releases/tag/v2.0.0

@kinwa91 it looks like this never got published :/
https://www.npmjs.com/package/@google-cloud/connect-datastore


Minor changes

@svchandramohan : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Looks good; thanks for this update @svchandramohan.


[10.x] Fix Model::replicate() when using unique keys

Fixes https://github.com/laravel/framework/issues/48629

@axlon can you please add a thorough description and not just link to an issue? thanks


Workflow shadower activity implementation

What changed?

Add workflow shadower activity implementation
Created helper function for both local shadower and shadower activity

Why?
Workflow shadowing

How did you test it?
Unit test

Potential risks
N/A

Pull Request Test Coverage Report for Build 6d48b27d-fc3e-4212-9b75-43e8c427fd52

114 of 122 (93.44%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 75.375%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/workflow_shadower_activities.go
97
105
92.38%

Totals

Change from base Build e31056e7-efbb-4a6d-b5c1-50b284a80373:
0.2%

Covered Lines:
9939

Relevant Lines:
13186

💛  - Coveralls


Pin torch==2.2.2 in CI to avoid a UTF-8 error in Windows (temporary bug in Torch)

Summary
Pins torch==2.2.2 in CI to avoid a UTF-8 error in Windows. This change is temporary and should be reverted to the latest Torch version as soon as https://github.com/pytorch/pytorch/issues/124897 is closed.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 92.636%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1887

Relevant Lines:
2037

💛  - Coveralls


Added another pure python alternative

Hi,
we (abusix) have recently decided to open source our pure python implementation of the Aho-Corasick algorithm.
Its README also includes some performance comparisons and while your library is definitely the goto library, ahocorapy might also be useful for some people that need to stay clear of C-Extensions, are using pypy or need unicode support while using python2.7
Thanks for taking a look and it'd be nice to be included in your README, as it seems like a good place to find out a lot about Aho-Corasick implementations in python.

Hi Frederik, thank you for the MR. Of course I'll merged it, it's a valuable pointer for users. And great that your company has decided to open source such a great library.


Can this software be used to change smartthings 'smart home monitor' state?

SmartThings has this 'smart home monitor' function that lets users via their phone enable/disable an alarm like system, with 3 states of armed (away), armed (home), disarmed.
Is it possible to change that state depending on a change of profile within BI or conversely change the SmartThings home state by a change to the BI profile ?
Anything like this that is similar would also be great to know about as I would love to bring the integration of these two systems I have closer together so I can turn on and off and it do the same to the other system.

This allows you to have Blue Iris' profile match SmartThings' Mode.  So if your SHM changes to Away or to Home, then this app would make Blue Iris change to a profile matching Away or Home (or however you have them named, I have mine named the same in ST and in BI).


Decode CBORObject back to any arbitrary object

Hi Peter,
I am trying to use PeterO.CBOR package to encode/decode an arbitrary object to/from CBOR. My object has two values: one is an array of byte strings, the second one is just an integer.
Encoding the object to CBOR is working fine. But I have problem to decode the CBOR object back to my original object. I couldn’t find an API to support the decoding to the original object directly. So I came up with an alternative approach: use CBORObject.ToJSONString() to get a JSON string firstly, then use NewtonSoft.JsonConvert.DeserializeObject() to de-serialize the JSON string to the specified type.
CBORObject.ToJSONString() states that byte strings are converted to Base64 URL without whitespace or padding by default. A byte string will instead be converted to traditional base64 without whitespace or padding if it has tag 22, or base16 for tag 23. I am curious why you don’t include the padding by default, which makes the JSON string invalid length. I looked at the source code, there is no options to makeCBORObject.ToJSONString() to include the padding. Maybe I missed something here. Could you please let me know if there is a way I can include the padding in the JSON string produced by CBORObject.ToJSONString()? My second question is that how can I set the tag (22) to just one value inside my object during encoding using CBORObject.FromObjectAndTag(), which sets the tag to the entire object not just one element in the map, because I need to CBORObject.ToJSONString() to return traditional base64 instead of base64 URL.
Thank you!

You should post your issue in the peteroupc/CBOR repository, not here.

In any case, ""CBORObject.ToJSONString() states that byte strings are converted to Base64 URL without whitespace or padding by default because that is the suggested behavior according to section 4.1 of RFC 7049.

Thanks Peter for your explanation!


Fit to content (don't fill up the whole screen with gray)

okay.

oh sorry, this is old code here. setting the bounds for the lightbox has moved to style.css (in patchbay)

I think I pushed this to ssb and forgot to push to github.

am gonna close this because it should be fixed in css

Ahh, I see. Thanks. I'll fix it in css then :)

Can you update npm.js with 1.0.0?

sorry, fixed!
On Wed, Dec 28, 2016 at 8:36 PM, Anders Rune Jensen <
<EMAIL_ADDRESS>wrote:

Can you update npm.js with 1.0.0?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/dominictarr/hyperlightbox/pull/1#issuecomment-269536904,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAP1Luq4WAjKL3nQxMGAtRVCvt24FKKuks5rMshKgaJpZM4LVeFn
.


Why is the data type not stored in NpyArray?

When I load an npz file, the only thing available to me in NpyArray is word_size, which however is too ambiguous to determine the data type. The information is available in the header but not used, is there a reason for this?

Up ! This feature would be really appreciated.

Up


Generating hard negative captions in Flick30k dataset

A download link of hard negative captions is provided for the Flick30k dataset here.
But neither explanations nor scripts are found for generating those hard negatives.
Could you help reproduce the generation process?
@e-bug @elliottd

We have re-used the ones uploaded for ViLBERT-MT.
I believe this script generates them.
Let us know if they match!

thanks. Verified that they are exactly match.   closing it now


ExAllocatePoolZero: can not find symbol

when build avshws project, ExAllocatePoolZero is not a valid function.
why change ExAllocatePoolWithTag to ExAllocatePoolZero, and where is the definition of ExAllocatePoolZero??
@Chao0000

i have the save problem on vs2019

i solved this problem,
my env :
pc : windows7 sp1
tools: visual studio 2019,
sdk version : 10.0.18362.0
then i upgrate wdk version to 10.0.19041.0，restart Visual Studio 2019 and modify the "Windows SDK Version" to 10.0.19041.0，this problem is disappered.
that's to say : This problem is caused by the low SDK version(wdm.h didn't declare ExAllocatePoolZero function)