[Feature request] Use ceph-volume to manage OSDs

So, I'm converting my existing Ceph cluster to use Skyflake. One issue that is stopping me from using it to deploy OSDs with, however, is that I require full disk encryption for each OSD.
I deployed my OSDs via ceph-volume create, with the --dmcrypt flag. This sets up each OSD to be encrypted via LUKS. At boot, ceph-volume activate grabs the LUKS keys from a Ceph monitor, passes them to dm-crypt, and then proceeds as normal in activating the OSDs.
Existing OSDs can be easily converted to use ceph-volume; so is it possible to change the OSD management logic to use ceph-volume instead? I suspect it would greatly simplify the implementation.

IIRC I didn't want that because it forced an extra LVM layer, duplicating what I was doing myself already.
Caution: don't put production data into Ceph on NixOS before there are good and safe ways to upgrade that cluster to future Ceph versions.

ceph-volume has two modes; one which uses LVM, the other doesn't :)

Caution: don't put production data into Ceph on NixOS before there are good and safe ways to upgrade that cluster to future Ceph versions.

I've already done an upgrade cycle with it! From quincy to reef. It was relatively painless; just upgraded one monitor at a time, then the OSDs :)

Also, recall that there is a services.ceph.<daemon>.package option, thanks to @SuperSandro2000 :)


Adding footprint parameter to datasheet schema

A footprint is a a must have parameter for all physical designs and it is a datasheet level parameter. (ie would be in the PDF).  https://www.jedec.org/category/technology-focus-area/jc-10/registered-outlines-jep95

The parameter is currently embedded in the asic group which is too limited.

This should be able to serve the need of the 'asic' 'footprint' as well...

I think you are right, as long as we agree that the asic "site" is very different from anything one might see in package, board. To deconflict and to be consistent with lef/def, we should probable rename asic footprint to asic site.

That was discussed at today meeting


fix-link-tempalte-adr (#5024)

Pull request opened by the merge tool on behalf of #5024

Merged into branches iso4 in 6161fe1717797bb4e6126a1d20d07b783cf9484c


BME280I2C.h Header Location

File: nodeAtest.ino
Line: #include <BME280I2C.h>
Which library are you installed in ArduinoIDE to get this header?

I use the BME280 library by Tyler Glenn (https://github.com/finitespace/BME280) and FastLED v3.1.6 by Daniel Garcia (https://github.com/FastLED/FastLED).
Sketch -> Include Library -> Manage Libraries -> Search for "BME280" -> select "BME280 by Tyler Glenn"
I also will include a note in the sources.


How to remove the round corners

I am trying to render an ImGui dockspace, and using certain parts of your code in combination with glfw.
However, the resulting window has round corners, and hence, it might be introducing certain padding/space.

How do I remove the round corners? I need to test whether this is causing that gap.

It looks like you're on Windows 11. You can use DWM calls to turn off the rounded corners if needed. Something like this:
namespace {
   . . .

   auto set_square_corners(HWND handle) -> void {
        if (composition_enabled()) {
            DWM_WINDOW_CORNER_PREFERENCE no_corners{ DWMWCP_DONOTROUND };

            // Will return E_INVALIDARG on non-Windows 11 systems.
            ::DwmSetWindowAttribute(handle, DWMWA_WINDOW_CORNER_PREFERENCE, &no_corners, sizeof(no_corners));
        }
    }
}

Then in BorderlessWindow::BorderlessWindow(), call it with set_square_corners(handle.get());
You could obviously add code to switch the corners to round/square as desired.
See DWM_WINDOW_CORNER_PREFERENCE enumeration


All user properties sent except Apple Search Ads events

Step 0: Are you in the right place?

For issues or feature requests related to the code in this repository
file a Github issue.

If this is a feature request please use the Feature Request template.

For general technical questions, post a question on StackOverflow
with the firebase tag.
For general (non-iOS) Firebase discussion, use the firebase-talk
google group.
For backend issues, console issues, and other non-SDK help that does not fall under one
of the above categories, reach out to
Firebase Support.
Once you've read this section and determined that your issue is appropriate for
this repository, please delete this section.

[REQUIRED] Step 1: Describe your environment

Xcode version: 11.6
Firebase SDK version: 6.10.0
Firebase Component: Core (Auth, Core, Database, Firestore, Messaging, Storage, etc)
Component version: 6.10.0
Installation method: CocoaPods

[REQUIRED] Step 2: Describe the problem
I'm trying to track Apple Search Ads campaign name, keywords etc. by saving it as user property values in Firebase. I setup Firebase attribution events tracking as mentioned in documentation below: https://support.google.com/firebase/answer/6317518?hl=en I attached iAd framework to the Xcode project and created property names in Firebase->User Properties menu.
The problem is that Firebase shows the list of user property names but they don't contain any values. In Firebase DebugMode it says that it sent Apple Search Ads events well:

[Firebase/Analytics][I-ACS023087] User property set. Name, value: iad_conversion_type, Download
[Firebase/Analytics][I-ACS023087] User property set. Name, value: iad_attribution, true
[Firebase/Analytics][I-ACS023087] User property set. Name, value: iad_keyword, Keyword
[Firebase/Analytics][I-ACS023087] User property set. Name, value: iad_country_or_region, US
[Firebase/Analytics][I-ACS023087] User property set. Name, value: iad_org_name, OrgName
[Firebase/Analytics][I-ACS023087] User property set. Name, value: iad_keyword_matchtype, Broad
[Firebase/Analytics][I-ACS023087] User property set. Name, value: iad_adgroup_name, AdGroupName
[Firebase/Analytics][I-ACS023087] User property set. Name, value: iad_campaign_name, CampaignName
[Firebase/Analytics][I-ACS023087] User property set. Name, value: iad_creativeset_name, CreativeSetName
[Firebase/Analytics][I-ACS023087] User property set. Name, value: iad_lineitem_name, LineName

Additionally, even if user properties don't work Firebase should automatically track that data.
I'm running Apple Search Ads for the last 3 weeks and there are almost 1k downloads already.
P.S. Other user properties (I also tracking user settings) it displays well in Firebase.
Steps to reproduce:
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool
{
    FirebaseApp.configure()
    ApplicationDelegate.shared.application(application, didFinishLaunchingWithOptions: launchOptions)
    Utilities.recordAppleSearchAds()

    return true
}

...

static func recordAppleSearchAds()
{
    // for more details: https://developer.apple.com/documentation/iad/setting_up_apple_search_ads_attribution
    ADClient.shared().requestAttributionDetails { (dict, error) in

        do {

            if error == nil {

                for (_, attributionDetails) in dict! {

                    for (key, value) in attributionDetails as! [String : NSObject] {

                        // skip date and id values
                        if key.range(of: "-date") == nil && key.range(of: "-id") == nil {

                            let propertyNameUpdated = key.replacingOccurrences(of: "-", with: "_")
                            let propertyValue: String = value as! String
                            Analytics.setUserProperty(propertyValue, forName: propertyNameUpdated)
                            debugPrint("key: \(propertyNameUpdated), value \(value)")
                        }
                    }
                }
            }
        }
        catch {

            Analytics.logEvent("request_attribution_details_catch_crash", parameters: nil)
        }
    }
}

Closing for staleness. Please comment or open a new issue to reopen.


how to write backward function?

I want to learn how to write operator in Mxnet,but backward function stop me. I have readed and understood How the backpropagation algorithm works and Calculus on Computational Graphs: Backpropagation,but I still have no idea when I write backward function in Mxnet.I just don't know what to read and learn.Could anyone help and give  me material to learn?Any help is grateful.

Look into the the operators in src/operator


Use equality check to filter enums

Fixes https://github.com/SoftwareBrothers/admin-bro-sequelizejs/issues/19

Hi @bakkerthehacker, I picked up your PR and added some tests in: https://github.com/SoftwareBrothers/admin-bro-sequelizejs/pull/33
Sorry for "stealing" your work!

@bakkerthehacker - I've merged @puntonim PR because it had tests. But I see that his work was inspired by you, so thank you for that.


Prune based on age

https://github.com/docker/docker/pull/26108 is fantastic. However, it doesn't handle this use case: a CI server where I need to keep images around for a couple days for caching, but need to prune them after that. I would like to have a time parameter (in days or hours) to exclude image/container/etc pruning. An LRU system would be ideal, but more technically complicated. For context, I am handling this with the script below. It's a little gross, but gets the job done.
#!/bin/bash
function check_age(){
    while read cid
    do
        age=$(date -d $(docker inspect -f '{{.Created}}' $cid) +%s)
        if [ $age -lt $TOO_OLD ]; then
            echo "$cid"
        fi
    done
}

get_names(){
    while read cid
    do
        docker inspect -f '{{.RepoTags}}' $cid | tr -d '[]'
    done
}

echo "cleaning containers"
TOO_OLD=$(echo "$(date +%s)-60*60*6" | bc)
docker rm -v $(docker ps --filter status=exited -q 2>/dev/null)
docker rm -f $(docker ps -aq --no-trunc | check_age)

echo "cleaning images"
docker rmi $(docker images --no-trunc -q --filter "dangling=true")
TOO_OLD=$(echo "$(date +%s)-60*60*24*7" | bc)
docker rmi $(docker images -q --no-trunc | check_age | get_names)

exit 0

I think what you're talking about is a garbage collector for Docker.
See more here: https://github.com/docker/docker/issues/18601

Yes a full GC would completely cover this (and be great). However, a fully automatic GC is larger in scope that what I am describing here. My intention is a very narrow expansion of the prune command to allow a time parameter.

Added a PR #28535 so that it is possible to have --until for docker container prune and docker image prune.


Unable to build Flutter Build Task

I am facing an issue while executing the Flutter Build task.
This is an error "Bad CPU type in executable".
I need some assistance here.

Hi, I can't help without any information regarding the build configuration, virtual env, os, etc.


IPL Data Analysis

In this I will develop a model which will predict the winner of the IPL by analysing the data.
Will be using various libraries like numpy, matplotlib, seaborn library for this
And will use plotly library to make plot more effective
And predict which team will win from two team playing.

@Niketkumardheeryan , please assign this to me under LGM SOC.

@Niketkumardheeryan if possible can you tell the reason of closing issue?


Mobile app: Add light mode

Add light mode to the mobile app.

@Miloua91 Can you please assign this issue to me?

@HazemAbdo to make your work easier, you need to change these two major colors in app.tsx, and add the choice to change between dark and light mode in settings
const bgColor = "#252422";
const cardColor = "#403d39";

then use nativewind to change the rest of the colors like text and such. feel free to ask me any question


🔁 update time taken to have numeric precision

This PR also includes thresholds for DayJS times. No longer will we have to deal with 44 seconds = 1 minute!

Can you help refactor all that extends from src/classes/Commands/Commands.ts to src/lib/tools/time.ts ?


can we restream currently active conference to any rtmp destination

e.g

if there are 5 participants and this will do the server side recording and along with that at the same time can it do RTMP streaming using FFmpeg?
can it record multiple conferences at the same time?
how much resource is consumed by this app during one conference recording

Hi @gigabyteservice,
Thanks for reaching out..!!
Please find my answers inline.

if there are 5 participants and this will do the server side recording and along with that at the same time can it do RTMP streaming using FFmpeg?

No, currently this library doesn't support RTMP. But I wanted to add support for RTMP. But honestly not finding time to do it. But it is in top of my priority list.

can it record multiple conferences at the same time?

I presume you want to record multiple conferences running in different tabs ? if so, it does support only one tab at a time.
so Nope.  But there is a alternate way to do the same, You can open multiple instance of browser and run this library to capture multiple conference in a separate output.

how much resource is consumed by this app during one conference recording

This library is itself light weight doesn't add consume any additional memory. However Please keep in mind that running a chrome instance  + rendering the page you want to capture consume some amount of memory.


cherry-pick to 0.15.x: Always test for a fence with gl2.clientWaitSync(sync, 0, 0) (#1529)

This is a cherry pick of https://github.com/tensorflow/tfjs-core/pull/1529 into 0.15.x.
Fixes https://github.com/tensorflow/tfjs/issues/1145
The smallest repro is calling .data() 3 times without waiting:
tf.ENV.set('WEBGL_CPU_FORWARD', false)
tf.ENV.set('WEBGL_SIZE_UPLOAD_UNIFORM', 0);
tf.square(3).data();
tf.square(3).data();
tf.square(3).data();

There are 3 fences that are in parallel. And on the next tick the binary search tests only the middle fence and sees that it is done, and assumes the first fence is done too. But since we never explicitly tested fence[0].isDone(), Chrome gives a warning.
The warnings started showing up more often when Layers started doing parallel reads of the scalar loss values: https://github.com/tensorflow/tfjs-layers/pull/398
I changed the binary search to linear search so we also test all fences up to the one that is not done.

This change is

I signed it!


Add development envrionment set up guide

Describe the pull request
Added documentation how to set up a Twitch app and make sure YaTA can use those credentials to authenticate with Twitch.
Why
I was missing this information when I tried running YaTA for the first time.
How
I updated the README.md file based on notes I made when first encountering this issue
Screenshots
:TTours:

Thanks for the pull request, I just merged the Contribute & Setup section as it was mostly related stuff 👍


Compare two UMAPs interactively

I've begun working on a compare page that allows you to choose 2 umaps and visualize the difference, as well as transition between which one is shown

We want to see the biggest changes between UMAPs because that hints at the biggest changes between what embeddings encoded.
Right now this is using an absolute measure of how far points move, which is fast and straightforward to implement. It is actually informative when you are comparing aligned UMAPs, but perhaps a more ideal implementation would look for relative changes in distance. So if a point moves far but it doesn't move that far from its neighbors (because they all moved with it) then it shouldn't be highlighted.
I also want to improve the UI for inspecting the data while doing this comparison. It's nice that you can select a point and follow it as you flip between the umaps, but we should have a tooltip that shows the text on hover for quickly inspecting neighbors.  It would be nice to see a table of the data points that travelled the furthest sorted by distance. The table view to is also not very well made as tracked in #6

I've thought of another view I want for comparing two umaps:
2 side by side plots that are linked interactively.
I'd really like to be able to click on a point in one UMAP and then see the list of its 10 nearest neighbors below. Then I'd like to see the nearest neighbors of that same point in the 2nd UMAP (as well as some indication of where the original 10 nearest neighbors landed).
This would be a way to investigate shifts at a very fine-grained level but still giving some enhanced intuition of how concepts move.


Add hosted SE2 configuration

I have this already added locally :)

In v0.4 we only expose the localUriConfig and make it possible to pass custom urls.
For the reasons mentioned in #31 we would either need to expand the list of URLs with the Admin API URL (for hosted SE2) or consolidate the two into what currently is named adminUri in this interface, and refers to the URL of the control plane.
In the local version I have I simply added an extra key, apiUri.
Nevertheless it would also be useful to have the hosted config of the hosted Suborbital Extension Engine included in the SDK as one of the built-in defaults.


My RM3 Pro Plus was not found anymore by adapter

Hi,
Unfortunately i've found a problem with my RM3 Pro plus since a few days. The adapter don't find it anymore afte a few seconds. If i put it from power an repower the unit. Everything went well. After a short  time the adapter lost the connection. If i restart the adapter i got the following log

broadlink2.0
2018-12-18 21:49:25.213
warn
Device RM:RMPROPLUS not reachable

broadlink2.0
2018-12-18 21:48:23.150
info
1 were not found: RM:RMPROPLUS

broadlink2.0
2018-12-18 21:48:23.150
info
Adapter broadlink2.0 started and found 1 devices named 'SP:Dose-Herd'.

broadlink2.0
2018-12-18 21:48:23.134
warn
device RM:RMPROPLUS not found, please rescan later again or delete it!  It was: <IP_ADDRESS>,IPv4,80,128,10141,rm,RM:RMPROPLUS,RM3 Pro  Plus,9d:27:9b:b2:a8:c0

broadlink2.0
2018-12-18 21:48:17.811
info
Device SP:Dose-Herd dedected: <IP_ADDRESS>,IPv4,80,128,38010,sp3s,SP:Dose-Herd,SP3Spower,7a:94:c0:a8:b2:8b

broadlink2.0
2018-12-18 21:48:17.723
info
Discover UDP devices for 10sec on broadlink2.0

broadlink2.0
2018-12-18 21:48:14.914
info
starting. Version 1.9.0 in /opt/iobroker/node_modules/iobroker.broadlink2, node: v8.12.0

host.ioBroker-RasPi
2018-12-18 21:48:13.639
info
instance system.adapter.broadlink2.0 started with pid 18503

It is not usefull to unplug the unit every few minutes. It will be nice if this could be fixed.
Thanks a lot in advance.

That's a real problem, but I do not know how I could adress it!
The captures all devices which reply to a command, if it does not reply twice it raises the error.
How is the wireless connection ?  If it is not stable it's maybe disconnecting.
Did you also set in your router that the device should get the same IP all time, this helps as well on re-connections?
If the device disconnects itself from wireless network because of internal failure or whatever other reason I cannot do anything because the adapter just sends a request to it and if connected and working it usually answers!


Loading time

My rainmeter would take minutes to start up and was unresponsive until it was loaded. I quickly identified it was due to your Lauhdutin skin.
I have a huge steam library and this is likely the cause of the issue. All I want is to show my installed steam games (only 79) sorted by last played. Can't this be optimized?
I tried to remove my sharedconfig and localconfig files from steam, but that didn't have any affect. Perhaps it's better to get last played data from the steam web api?
Anyway, any tips on how to speed up this loading would be appreciated!

I also noticed my \documents\Rainmeter\Skins\Lauhdutin\@Resources\cache\steam folder is 1 GB, 14,719 items... It seems unnecessary to download all those, if I just wanna see my installed games.

Hello, to only add your installed games of steam instead all you have to uncheck "Parse Steam profile" on Settings -> Steam. But this would not remove your actual database. Check if without parsing your profile the skin loads faster, and if not I suggest you to remove your actual database<EMAIL_ADDRESS>and all backups if any) and then reloading skin, so it only will add installed games,

Thanks, that makes sense. I didn't know it would read backups if I removed games.json

That fixed the issue! Now it load in mere seconds!

Glad to read that ;)


plugin_register_add_api_and_def() doesn't seem to make the method available via ReaScript

I've tried running the example to register a ReaScript function from the tests + internal docs, but I'm unable to get this to appear:
Is it meant to only be usable from within the Rust code by getting a direct pointer to it, or is it supposed to show up in the ReaScript docs and IDE signatures that appear, like this?

use std::os::raw::{c_int, c_void};
use std::ptr::null_mut;
use std::error::Error;

use reaper_high::Reaper;
use reaper_low::{PluginContext, Swell};
use reaper_macros::reaper_extension_plugin;
use reaper_medium::ReaperSession;

use c_str_macro::c_str;

extern "C" fn hey_there() {
    Reaper::get().show_console_msg("Hey there!\n");
}

unsafe extern "C" fn hey_there_vararg(_arglist: *mut *mut c_void, _numparms: c_int) -> *mut c_void {
    hey_there();
    null_mut()
}

#[reaper_extension_plugin]
#[allow(clippy::unnecessary_wraps)]
fn plugin_main(context: PluginContext) -> Result<(), Box<dyn Error>> {
    let mut session = ReaperSession::load(context);

    session
        .reaper()
        .show_console_msg("Hello world from reaper-rs medium-level API!");

    Reaper::load(context).setup();
    let medium_reaper = Reaper::get().medium_reaper();

    // Low-level REAPER
    reaper_low::Reaper::make_available_globally(*medium_reaper.low());
    reaper_low::Reaper::make_available_globally(*medium_reaper.low());
    let low = reaper_low::Reaper::get();

    println!("reaper_low::Reaper {:?}", &low);
    unsafe {
        low.ShowConsoleMsg(c_str!("- Hello from low-level API\n").as_ptr());
    }

    // Low-level SWELL
    let swell = Swell::load(*medium_reaper.low().plugin_context());
    println!("reaper_low::Swell {:?}", &swell);
    Swell::make_available_globally(swell);
    let _ = Swell::get();

    // Medium-level REAPER
    reaper_medium::Reaper::make_available_globally(medium_reaper.clone());
    reaper_medium::Reaper::make_available_globally(medium_reaper.clone());

    medium_reaper.show_console_msg("- Hello from medium-level API\n");

    unsafe {
        session
            .plugin_register_add_api_and_def(
                "ReaperRs_HeyThere",
                hey_there as _,
                hey_there_vararg,
                "void",
                "",
                "",
                "Just says hey there.",
            ).map_err(|err| {
                session
                    .reaper()
                    .show_console_msg(format!("Got error registering function: {}", err));
                err
            })?;
    }

    Ok(())
}

Haha, out of all functions in the reaper-medium crate you picked exactly the one which is far from being polished and ready ;) I thought once I'm going to need it and then didn't, so I stopped working on it.
However, in your case the problem is another one: ReaperSession needs to stick around. It uses RAII pattern to automatically clean up everything (including your plugin_register registrations) when it goes out of scope. And in your code it does go out of scope as soon as your plugin_main function ends. You need some static to store it in.
The easiest way to do this is to (you didn't hear that from me, okay? ;)) to use the high-level API to bootstrap your plug-in. Just a minimum of it and after that only access reaper-medium.
#[reaper_extension_plugin(
    name = "reaper-rs test extension plug-in",
    support_email_address =<EMAIL_ADDRESS>)]
fn main() -> Result<(), Box<dyn Error>> {
    let reaper = Reaper::get();
    reaper.medium_session().plugin_register_add_api_and_def(...);
    reaper.medium_reaper().blablabla();
    Ok(())
}

test/test-extension-plugin is a working example.

 This can be freely cloned and is basically the equivalent of the raw C++ API just in a bit more idiomatic Rust. ReaperSession is an addition that releases you from the burden to find a place in memory for all of the things that you want to register (because REAPER itself won't keep these things for you). That's why it needs to stick around.

Bingo!
Thank you again!

If I could toss ONE last question out there, feel free to answer or not, but this mut* mut* c_void thing:
unsafe extern "C" fn imgui_rs_test_vararg(
    _arglist: *mut *mut c_void,
    _numparms: c_int,
) -> *mut c_void {

}

@cfillion was kind enough to divulge that the arglist stores actual values for certain numbers, memory addresses where the values can be found for other formats of numbers, and... basically memory addresses for everything else. Plus apparently another param with memory addresses it'd like results written to.
How do I go about translating an unknown "mutable-pointer-to-a-mutable-pointer-to-a c_void, that returns a mutable pointer to a c_void" into everyday Rust 😅?

Why not use https://github.com/imgui-rs/imgui-rs?

Ah, sorry. You already use that. Mmh, you would need to use structs that have the same layout as what's expected in the arg list. How these structs need to look exactly, I don't know. But basically the same way they would look in C?

It's a little bit complicated -- basically I am trying to see what the experience is like to integrate third-party widgets for cfillion's new "ReaImGui" library which is ImGui for Reaper + ReaScript bindings:
https://github.com/cfillion/reaimgui

Woo I, got it!!
It seemed the answer to turning *mut *mut c_void array of arguments into something usable lied in:
std::slice::from_raw_parts(_arglist, _numparms.try_into().unwrap())

I think I will make another issue though -- I was about to give up because of the args syntax.
It must be EXACTLY the C syntax, with commas and no spaces:

Tried many combinations and it never came out quite right. After reading reaper_functions.h and the generated docs + your implementation closer, I took a guess on this.
Will try to submit a PR (if I am capable of writing it) to surface a better interface/docs for this =)
Also, I now am curious what can be done if I try to somehow expose and access the direct/underlying ImGuiContext pointer from C++ DLL in Rust DLL. cfillion says it's a terrible idea.
With your help, this was possible -- how amazing! ❤ ❤

use std::{
    borrow::Cow,
    convert::TryInto,
    os::raw::{c_int, c_void},
};
use std::{ffi::CStr, ptr::null_mut};

use std::error::Error;

use reaper_high::Reaper;
use reaper_macros::reaper_extension_plugin;

extern "C" fn imgui_rs_test(ctx: *mut c_void, text: *mut c_void) {
    let ImGuiTextPtr = Reaper::get()
        .medium_reaper()
        .plugin_context()
        .get_func("ImGui_Text");
    assert!(!ImGuiTextPtr.is_null());

    let ImGuiText: Option<extern "C" fn(ctx: *mut c_void, text: *mut c_void)> =
        unsafe { std::mem::transmute(ImGuiTextPtr) };

    let ImGuiText = ImGuiText.ok_or("Couldn't restore function from ReaScript API name and pointer. Make sure it exists and has been loaded.");
    match ImGuiText {
        Ok(method) => method(ctx, text),
        _ => Reaper::get().medium_reaper().show_console_msg("No bueno"),
    }
}

unsafe extern "C" fn imgui_rs_test_vararg(
    _arglist: *mut *mut c_void,
    _numparms: c_int,
) -> *mut c_void {
    let args = std::slice::from_raw_parts(_arglist, _numparms.try_into().unwrap());
    imgui_rs_test(args[0], args[1]);
    null_mut()
}

#[reaper_extension_plugin(
    name = "reaper-rs test extension plug-in",
    support_email_address =<EMAIL_ADDRESS>)]
fn main() -> Result<(), Box<dyn Error>> {
    let reaper = Reaper::get();

    unsafe {
        reaper
            .medium_session()
            .plugin_register_add_api_and_def(
                "ImguiRS_Test",
                imgui_rs_test as _,
                imgui_rs_test_vararg,
                "bool",
                "ImGui_Context*,const char*",
                "ctx,input",
                "A test REAPER function for calling ImGui from ReaScript given an existing context",
            )
            .map_err(|err| {
                reaper.show_console_msg(format!("Got error registering function: {}", err));
                err
            })?;
    }

    Ok(())
}

@GavinRay97 Btw, if you want to use imgui-rs in your Rust VST that also uses reaper-rs, you can use this:
https://github.com/BillyDM/imgui-baseview (You could also combine that with implot-rs.)
Here is an example VST: https://github.com/DGriffin91/compressor-plugin
There are also round knobs for imgui: https://github.com/DGriffin91/imgui-rs-knobs

@Boscop Thank you! I will definitely use those for VST's =D
In this case, I was trying to do this:

Use ReaImGui (C++ ReaScript API wrapper over ImGui to expose ImGui directly to REAPER scripts, with some wrapper for windowing context) - https://forum.cockos.com/showthread.php?p=2419456#post2419456
ReaImGui "ctx" is a custom wrapper context over *ImGuiContext which contains the actual *ImGuiContext at a private property called ImGui_Context.m_imgui

https://github.com/cfillion/reaimgui/blob/b90ee9d4be8c0e8b1aa7e8fb957be0cdf5c0b394/src/context.hpp#L90
std::unique_ptr<ImGuiContext, void(*)(ImGuiContext*)> m_imgui;

If I can somehow get to this C++ m_imgui class property from Rust, then I can use imgui-rs because the type is the same as the type of ImGuiContext in the FFI bindings.

(Or any other programming language with ImGui, since you now have the underlying ImGui context pointer, it works with all functions)

Unfortunately I know basically NOTHING about either C++ or FFI or how this low level interop and binding/header stuff works so it turned out to be pretty difficult and not sure it's worth it =/


Edition: Implement as_str() fn

This is basically similar to the Deserialize implementation, but sometimes the stringification is useful outside of having to save it back to a TOML file :D

@LukeMathWalker any objections? :)

Nope!


Add in section about IMD - centroids

I thought part postcodes could be linked to IMD via the centroid LSOA but this may not be correct. Copied the blog information from the CDU blog and updated the link.


[WIP]Feature/synchronize peer

feature/synchronize peer

[ ] rpc_service

[x] to issue Transaction
[x] CheckHash
[x] getPeers
[ ] fetchStraemingTransactions

[x] integration ametsuchi

[x] cache_map

[x] main_step

[x] detail

[ ] test

[x] to issue Transaction ( another branch )
[x] checkHash
[x] getPeers
[ ] fetchStreamingTransactions
[x] cach_map
[ ] synchronize all test ( another feature branch )

TODO

Ametsuchi 's function getTransaction( index )

rpc_service getTx( ip, index ) : TransactionRespone;

add leader colum to config.json


Add a read trimming step to RnaSeq alignment.

This uses genome/docker-rnaseq#2 to add read-trimming to the workflow.

seems straightforward enough! +1

See #144 for details of full pipeline.


Allow endpoint to accept either API key or cookie authentication

Hello,
I am building a Poem web service and for the create_note endpoint, I want to provide two authentication options:

API key authentication via header (ApiKeyAuth).
Cookie-based authentication (CookieAuth).

Currently, the create_note endpoint appears to mandate both authentication methods simultaneously. However, my desired functionality is:

Authenticate the user if a valid cookie is provided.
If no valid cookie is detected, but a valid API key is available in the header, authenticate the user.
If both a valid cookie and a valid API key are missing, the authentication should fail.

Below is the related code snippet from my service:
use poem::{
    http::StatusCode,
    listener::TcpListener,
    session::{
        CookieConfig,
        RedisStorage,
        ServerSession,
        Session,
    },
    web::Data,
    EndpointExt,
    Error,
    Result,
    Route,
    Server,
};
use poem_openapi::{
    auth::ApiKey,
    payload::PlainText,
    OpenApi,
    OpenApiService,
    SecurityScheme,
};
use redis::{
    aio::ConnectionManager,
    Client,
};
use sqlx::SqlitePool;

/// API key authorization
#[derive(SecurityScheme)]
#[oai(ty = "api_key", key_in = "header", key_name = "X-API-Key")]
struct ApiKeyAuth(ApiKey);

/// Cookie authorization
#[derive(SecurityScheme)]
#[oai(ty = "api_key", key_in = "cookie", key_name = "session")]
struct CookieAuth(ApiKey);

struct SomeApiKeyService;

impl SomeApiKeyService {
    fn auth(key: String) -> Option<String> {
        if key == "123456" {
            Some("admin".to_string())
        } else {
            None
        }
    }
}

struct Api;

#[OpenApi]
impl Api {
    /// Auth
    #[oai(path = "/auth", method = "post")]
    async fn auth(
        &self,
        pool: Data<&SqlitePool>,
        session: &Session,
        PlainText(username): PlainText<String>,
    ) -> PlainText<String> {
        session.set("username", &username);
        PlainText(format!("authed as {}", &username))
    }

    async fn create_note(
        &self,
        pool: Data<&SqlitePool>,
        session: &Session,
        ApiKeyAuth(api_key_auth): ApiKeyAuth,
        CookieAuth(cookie_auth): CookieAuth,
        PlainText(note): PlainText<String>,
    ) -> Result<PlainText<String>> {
        let username = match session.get::<String>("username") {
            Some(username) => username,
            None => match SomeApiKeyService::auth(api_key_auth.key) {
                Some(username) => username,
                None => return Err(Error::from_status(StatusCode::UNAUTHORIZED)),
            },
        };
        Ok(PlainText(format!("note {note} created by {username}")))
    }
}

#[tokio::main]
async fn main() -> Result<(), Box<dyn std::error::Error>> {
    let pool = SqlitePool::connect("sqlite:notes.db").await?;

    let server_session = ServerSession::new(
        CookieConfig::default(),
        RedisStorage::new(ConnectionManager::new(Client::open("redis://localhost:6379")?).await?),
    );

    let api_service = OpenApiService::new(Api, "API", "0").server("http://localhost:8080");

    let swagger = api_service.swagger_ui();

    let app = Route::new()
        .nest("/", api_service)
        .nest("/swagger", swagger)
        .with(server_session)
        .data(pool);

    Server::new(TcpListener::bind("localhost:8080"))
        .run(app)
        .await?;

    Ok(())
}

I would appreciate any guidance on updating this endpoint to accept either one of the two authentication methods without necessitating both.
Thank you.

Not yet, but I'll add it in a few days.

@sunli829 Hey there, just wanted to gently check in on the status of the request I made two months ago. No rush at all, I truly appreciate the work you all do on this fantastic framework!

Should this issue be closed.
I think it is addressed by this documentation: Security Scheme - Multiple Authentication Methods

It definitely should be. Thank you!


109

This does not include the official anaconda distribution. That will be researched at a later time.


Check if it is possible to get rid of location permissions with targetSDK 31

@markoaamunkajo it should work like before for Android 6-11, but it's possible I did broke something. App needs a good full test.
There's no location permission request for Android 12 users.

Currently in internal/alpha version 1.6.7

QA passed, tested with OS6, OS9, OS10


HDDS-2650 Make createPipeline CLI message based.

What changes were proposed in this pull request?
#HDDS-2650 Make createPipeline CLI message based to fix after merge with master.
(Please fill in changes proposed in this fix)
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2650
(Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HDDS-XXXX. Fix a typo in YYY.)
Please replace this section with the link to the Apache JIRA)
How was this patch tested?
bash-4.2$ ozone scmcli pipeline list
Pipeline[ Id: 2aa5b959-8e9d-4c72-a6ef-ec30f00f1dca, Nodes: 53ab812b-6ec4-468b-861c-64d2a1445deb{ip: <IP_ADDRESS>, host: ozone_datanode_1.ozone_default, networkLocation: /default-rack, certSerialId: null}, Type:RATIS, Factor:ONE, State:ALLOCATED, leaderId:null, CreationTimestamp1576579695167]
bash-4.2$ ozone scmcli pipeline create
bash-4.2$ ozone scmcli pipeline list
Pipeline[ Id: 2aa5b959-8e9d-4c72-a6ef-ec30f00f1dca, Nodes: 53ab812b-6ec4-468b-861c-64d2a1445deb{ip: <IP_ADDRESS>, host: ozone_datanode_1.ozone_default, networkLocation: /default-rack, certSerialId: null}, Type:RATIS, Factor:ONE, State:OPEN, leaderId:53ab812b-6ec4-468b-861c-64d2a1445deb, CreationTimestamp1576579705686]
Pipeline[ Id: c34c276f-f187-4048-9e20-81188c24fe79, Nodes: 53ab812b-6ec4-468b-861c-64d2a1445deb{ip: <IP_ADDRESS>, host: ozone_datanode_1.ozone_default, networkLocation: /default-rack, certSerialId: null}, Type:STAND_ALONE, Factor:ONE, State:OPEN, leaderId:null, CreationTimestamp1576579705686]
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Can you revert the previous HDDS-2650 commit and merge these two PR into one?

Can you revert the previous HDDS-2650 commit and merge these two PR into one? Cannnot commit the same JR twice.

I have included the revert commit and the new commit in this PR and I've updated the JIRA as well.

testCloseContainerEventWithRati is fixed in https://github.com/apache/hadoop-ozone/pull/291/files

Can we refine the message when pipeline cannot be allocated for some reason?
bash-4.2$ ozone scmcli pipeline create -f THREE -t RATIS
Not enough healthy nodes to allocate pipeline. 3  datanodes required. Found 1
bash-4.2$ ozone scmcli pipeline create -f ONE -t RATIS
Cannot create pipeline of factor 1 using 0 nodes. Used 1 nodes. Healthy nodes 1

Can we refine the message when pipeline cannot be allocated for some reason?
bash-4.2$ ozone scmcli pipeline create -f THREE -t RATIS
Not enough healthy nodes to allocate pipeline. 3 datanodes required. Found 1
bash-4.2$ ozone scmcli pipeline create -f ONE -t RATIS
Cannot create pipeline of factor 1 using 0 nodes. Used 1 nodes. Healthy nodes 1

https://issues.apache.org/jira/browse/HDDS-2756 is tracking logging issues. Will address there.

1,  will commit to the branch.


There should be a feature to unpack orders in bulk

What is the motivation for adding/enhancing this feature?
There should be a feature to unpack orders in bulk like in the other Fulfillment app.
What are the acceptance criteria?
User should be able to unpack the orders in bulk from the settings page.

[ ] ...

Can you complete this feature request by yourself?

[ ] YES
[ ] NO

Additional information

@appurvajain  Closing this issue as no use case. Please confirm?


Missing health check endpoint

There is no easy way to check if API works fine. The best solution for that would be the new endpoint /haalthz which should return HTTP 200 OK for working API and, in my opinion, 503 Service Unavailable if something went down

quick input for specification as I was consulting question and disagree that we can say in one answer that api is working.
Method: GET /health
Response code: 200
Response body proposition (JSON):
{
  "api": {
    "status": "Green"
  },
  "elastic": {
    "status": "Yellow",
    "message": "2/3 instances available"
    },
  "magento": {
    "status": "Yellow",
    "message": "Requests took to much time (1523ms). Should respond <800ms"
  },
  "redis": {
    "status": "Red",
    "message": "Cannot connect to any instance"
  },
}

and also every extension should have a health method, which returns those kinds of data, which is merged into this object and returned with health endpoint.

@gibkigonzo I think that @ajsit is right and we need this within vue-storefront app


Change Fable to Fable.React

Hello,
I suspect you wanted to say Fable.React and not Fable as this library needs Fable in order to compile to JavaScript :)

That is indeed correct! Thank you for noticing and contributing 😊

That is indeed correct! Thank you for noticing and contributing 😊


Use REP balance instead of making call to universe, which can change

I'll prolly change when this happens:
https://github.com/AugurProject/augur-core/pull/644


Error: browserify-shim needs to be passed a proper browserify instance as the first argument.

Hi. My application loads jquery synchronously from a CDN before loading the app. Now I've added a component that does a require('jquery') and fails. Looking around i gather that i need to shim jQuery so I modified the browserify task like so:
gulp.task('browserify', function() {
    return gulp.src('./src/js/app.js').pipe(browserify({
            transform: ['browserify-shim']
        }))
        //Pass desired output filename to vinyl-source-stream
        //.pipe(source('app.js'))
        .pipe(ngAnnotate())
        //.pipe(streamify(uglify({ mangle: false })))
        // Start piping stream to tasks!
        .pipe(gulp.dest('./dist/js/')).pipe(connect.reload());
});

didn't get to the part where I actually configure the shim because this also fails saying that:
Error: browserify-shim needs to be passed a proper browserify instance as the first argument.

Can someone help fix this ?

Support questions should be asked on StackOverflow.  Also, gulp-browserify is blacklisted.


API-98 Updated to include user collection (partially), notification s…

…ettings, resend activation link
@stuisme @TerryMooreII @larastocks @ejcarr @aoffpo

Declining as these changes are addressed in API-189


Convert remaining modules to use Reader

Also avoid Copy/Eq requirement by using offsets.
Next step after this is to convert dwarfdump to use Reader. Probably need to add to_vec and to_string methods to the Reader trait to allow this.

Coverage decreased (-0.1%) to 93.531% when pulling 0db9a25bd1fc1d8a7db9425707952ecb84e62f76 on philipc:reader into 32acbcc0d3a62414af3466a2ac8c987821d10ee7 on gimli-rs:master.

I have a concern about the first commit

Ah, OK I see now that this was just a temporary thing until it became a &mut R in the next commit, which I guess I glazed over.
LGTM, r+ with the nitpicks on copy-paste
Thanks a third time! :)

Coverage decreased (-0.1%) to 93.531% when pulling 85371f8bd515958f89a5e04b382a9310d0f9d659 on philipc:reader into 32acbcc0d3a62414af3466a2ac8c987821d10ee7 on gimli-rs:master.


[Issue 13278][python client] Add python 3.10 generation for pulsar-client

https://github.com/apache/pulsar/issues/13278
Motivation

Support python 3.10 for pulsar client

Modifications

Add 3.10 cp310-cp310 to the build scripts
Use manylinux_x_y for 3.10 support (manylinux_2014 does not support python 3.10)

Verifying this change

[ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end deployment with large payloads (10MB)
Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API: (yes / no)
The schema: (yes / no / don't know)
The default values of configurations: (yes / no)
The wire protocol: (yes / no)
The rest endpoints: (yes / no)
The admin cli options: (yes / no)
Anything that affects deployment: (yes / no / don't know)

Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?

[ ] doc-required
(If you need help on updating docs, create a doc issue)

[ ] no-need-doc
(Please explain why)

[ ] doc
(If this PR contains doc changes)

@curtiscook Sorry I didn't see this PR. I have added support for Python 3.10 in #15004. The wheels are already available for linux and Mac on https://pypi.org/project/pulsar-client/2.9.1/#files

Not a problem! I don't work on building cpython so happy to close this in favor of yours!

@curtiscook
Python bindings for Apache Pulsar C++ client is available on Alpine Linux
# apk search pulsar-client
py3-pulsar-client-cpp-2.9.1-r0
pulsar-client-cpp-static-2.9.1-r0
pulsar-client-cpp-2.9.1-r0
pulsar-client-cpp-dev-2.9.1-r0

# apk info py3-pulsar-client-cpp
py3-pulsar-client-cpp-2.9.1-r0 description:
Python bindings for Apache Pulsar C++ client

py3-pulsar-client-cpp-2.9.1-r0 installed size:
4996 KiB

# apk info pulsar-client-cpp
pulsar-client-cpp-2.9.1-r0 description:
Apache Pulsar C++ client

pulsar-client-cpp-2.9.1-r0 installed size:
3168 KiB

# apk add py3-pulsar-client-cpp
(1/1) Installing py3-pulsar-client-cpp (2.9.1-r0)

# python3 --version
Python 3.10.3


CCEP (cortico-cortical evoked potential) mapping

CCEP mapping is a relatively novel in vivo brain mapping technique, utilizing low frequency stimulation, in patients undergoing invasive monitoring for refractory epilepsy (Matsumoto et al., 2004). CCEP mapping produces evoked effective connectivity data.

I suggest we add this to our Technique terminology. FYI @tgbugs & @MaaikevS

Just to clarify: You want to add it as an analysis technique, right? I looked at some papers that used this mapping and the experimental technique in most cases would be "electrocorticogram" (ECoG) and an electrical stimulation (of distinct areas). Then the causal relation between brain regions following the stimulation is evaluated, meaning did the stimulation in area A trigger an electrical response in area B of a certain strength, timing and type. "CCEPs in human cortex generally consist of an early sharp response (10–50 ms poststimulation) and a later slow-wave (50–250 ms).", according to Keller et al. (2014).
So, a definition for the technique could be something like:
"Cortico-cortical evoked potential (CCEP) mapping is an analysis technique used to identify the pattern of CCEPs (electrical response with specific strength, timing and shape) of multiple units within a nervous system following direct electrical stimulation of another unit."
Description could be:
"Cortico-cortical evoked potentials are distinct electrical responses in specific units of a nervous system following direct electrical stimulation of another unit in the same system. For example, CCEPs in human cortex generally consist of an early sharp response (10–50 ms poststimulation) and a later slow-wave (50–250 ms) [Keller et al. (2014)]. By mapping the response patterns, the effective connectivity (= causal interactions) between those units can be determined. The analysis of the network topology typically involves graph theory measures."


Pass -T Flag when Running Playback Tests From Source in CI

This PR adds passing of the -T, parallel build, flag when the From Source playback tests in CI. Passing this flag allows for better usage of VM resources for libraries that currently don't have parallel testing enabled.
Initially, it was prototyped to pass this in all test runs but it was found to slow down completion time when parallel testing was enabled (likely due to thread contention). As more libraries enable parallel testing this configuration should be monitored to ensure it is adding a net benefit for reducing testing time in CI.

/azp run java - resourcemanager


Slide the access token when it is used

I am using a very similar flow to the one that is described in this issue over at the IS3 repo, https://github.com/IdentityServer/IdentityServer3/issues/1363. In fact I am already using a lot of oidc-token-manager to obtain my tokens and stash them on the client. I have a token manager that lives in an angular directive that initiates the login over to IS3, from there the user logs in and sent back to a callback page where the tokens are checked and put into local storage.
However, much like the original poster in that issue describes. I would like to be able to extend the token when the user actually uses the token. So the flow would go something like this:

Users logs in, token is stored in local
Users hits an API with the token passed over to it. At this point the token expiration should be extended as they are clearly active. How should this be implemented via IS3 and my token manager?

You can't extend tokens like you can cookies. You need to go back to the token service and get a new token.

@brockallen right which I believe is what I am doing, perhaps closing this issue and discussing my idea over in this issue instead: https://github.com/IdentityModel/oidc-client/issues/9


5338 bug fix

Description (required)
Fixes #5338  (you should insert the actual issue number if one exists)
What changes did you make and why?
Fixed a potential ArrayIndexOutOfBoundsException in LanguagesAdapter. The bug was due to the method getIndexOfUserDefaultLocale possibly returning -1 when the user's default locale wasn't found in the language. codes list. The returned value is now properly checked and, if -1, defaults to DEFAULT_INDEX which is set to 0.
Tests performed (required)
Tested ProdDebug on Pixel 3 with API level 30. (replace with actual device and API details)
After multiple rounds of testing, in the case of Chinese and other languages, the program will not directly crash during the process of selecting and uploading images.

Before, the app would crash instantly before reaching this page.
Screenshots (for UI changes only)
N/A (since this is a bug fix and doesn't involve any UI changes)
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.
Remember, it's important to actually test the changes on a real device or emulator before submitting a pull request to ensure that the bug is genuinely fixed and no new issues are introduced.

Thanks a lot @1162706031 for fixing the bug!


Move from Travis CI to GitHub Actions

Issues to tackle:

[x] Change from Travis CI to GitHub Actions (#109).
[x] Re-enable linkcheck once GHA has an allowed_failure or similar (actions/toolkit#399).
[ ] Enable windows and macos checks.

#109 Makes the move, and a separate Action for linkchecks. Windows and MacOS builds are not enabled yet, should be done in the future.


qgit: 2.7 -> 2.8

Motivation for this change
New version supports HiDPI displays.
CC @peterhoeg
Things done
Tested locally on a 4K display. Labels are readable now after scaling.

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

Thanks @markuskowa. If you have an interest in this piece of software, feel free to open a PR adding you as a maintainer and ping me in it.


Asp.Net Core 2.1 with IdentityServer4 throw error "InvalidOperationException: idp claim is missing"

I follow Using ASP.NET Core Identity with Asp.Net Core 2.1 and IdentityServer4.AspNetIdentity.
Here is reproduceable project:
IdentityServerWithAspNetCoreIdentity
IdentityServerMVCClient
After launching both project, I could login the IdentityServerWithAspNetCoreIdentity after registering. But for IdentityServerMVCClient, I will got below error when I click About.

InvalidOperationException: idp claim is missing

This usually happens when you don't have the proper default authentication scheme set in your app to be the IdentityServer cookie.

How should I set proper default authentication scheme?

You can do it in the AddAuthentication(options=>{...})

I have configured services.AddAuthentication(options =>                     {                         options.DefaultScheme = "Cookies";                         options.DefaultChallengeScheme = "oidc";                     }) at client side, what should I configure at IdentityServer side?

@Edward-Zhou did you ever get this working? I'm still getting this routinely if the cookie is still valid.

@Edward-Zhou did you ever get this working? I'm still getting this routinely if the cookie is still valid.


float functionality added

Integers are converted to float. Now Decimal numbers can be used .

this issue has been resolved
thank you for your time!


[CARBONDATA-1417]Added cluster tests for IUD, batch sort and global sort features

1.IUD
2.batch sort
3.global sort

ok to test

retest this please

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3427/

SDV Build Failed with Spark 2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/302/

retest this please

SDV Build Failed with Spark 2.1, Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/333/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/539/

ok to test

Build Success with Spark 2.1.0, Please check CI http://<IP_ADDRESS>:8080/job/ApacheCarbonPRBuilder/3435/

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/576/

retest this please

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/663/

retest this please

SDV Build Fail , Please check CI http://<IP_ADDRESS>:8080/job/ApacheSDVTests/695/

LGTM


Migrate compile to null safety

Migrate compile.dart and tests to null safety.
Part of #71511

This one was tricky, would appreciate a thorough review...

Google testing failing because artifacts nullability hasn't rolled.


Feature Request: MultiStreamRecorder - removeStream

Would be nice if there was an additional helper method that allowed for the removal of a steam for the MultiStreamRecorder. First idea would be to potentially pass in the MediaStream object as ...removeStream(stream) then based on its id delete it from the arrayOfMediaStreams. Need to look at the source a little longer to see how this would effect the stream capture. If I have some free time in the future I can probably try to put a PR with the implementation if that would be of interest.

Hello, any updates on this?
I'm currently developing a video conference-like app that can record the videos of users (max of 4) with MultiStreamRecorder. And when a user leaves the room, his placement from the video will become blank and would be available for other user that will join the meeting. Since there is an existing "addStream" method, it would be nice if there would also be a "removeStream" method.

Hi @kim00kim, I actually ended up forking and making the modifications for removal. Could probably make a PR to try and get it into the main repo but haven't had the time. Here's my fork with the related logic if that's of interest: https://github.com/wootencl/MediaStreamRecorder


HEE-341: 'Opens in a new window' implementation for external links

uk.nhs.hee.web.content.rewriter.impl.MiniHubGuidanceLinkRewriter global content rewriter for RichText fields has been replaced by uk.nhs.hee.web.content.rewriter.impl.HEEContentRewriter which performs the following:

Rewrites external links to include target="_blank" attribute as well as suffixes link text with  (Opens in a new window)
Rewrites Mini-hub Guidance document links in case if they end up with pagenotfound by OOTB default content rewriter org.hippoecm.hst.content.rewriter.impl.SimpleContentRewriter. This was previously done by uk.nhs.hee.web.content.rewriter.impl.MiniHubGuidanceLinkRewriter content rewriter.

Opens in a new window feature and link validations have been added to the following components:

Action link
After form
Navigation card
Button card (Opens in a new window has been implemented as a visually hidden span element for now as decision is yet to be made re. the placement and will be dealt part of HEE-410)
Navigation map
Quick links

@smanivasag , do we need this PR ? Can we close it ?

@smanivasag , do we need this PR ? Can we close it ?

@sankar-shunmuga - Given the fact that all links should open on the same page (unless specified or in exceptional cases), I think we do not need this PR anymore as it seems to do the opposite.
But, I think it will be good to extract hee:link-validator implementation from the PR (which essentially validates if the CMS user has provided at least a Link document or URL) and look to review/release it as part of a separate ticket. Thoughts ? Thanks!

As per GDS and accessibility , most of the links are currently opening in the same tab. Hence this pull request is not required now. So I am closing it now


ANDROAPP-5674-mobile-ui-Image-detail

@andresmr @siddh1004 I was thinking maybe we can use Telephoto for adding zooming capabilities? It uses sub-sampling, so it should be safe with loading large images and also memory efficient as well.

@andresmr @siddh1004 I was thinking maybe we can use Telephoto for adding zooming capabilities? It uses sub-sampling, so it should be safe with loading large images and also memory efficient as well.

The functionalities that we need for our app, are very minimum and can be implemented using compose callbacks. I have not tested it with large images, if you want maybe we can test our implementation using large images.

Hi @siddh1004 , I think it is a good idea,but this telephoto is just for android, right?

Hi @siddh1004 , I think it is a good idea,but this telephoto is just for android, right?

It's for Android and Desktop (supports Compose Multiplatform)

@andresmr @siddh1004 I was thinking maybe we can use Telephoto for adding zooming capabilities? It uses sub-sampling, so it should be safe with loading large images and also memory efficient as well.

The functionalities that we need for our app, are very minimum and can be implemented using compose callbacks. I have not tested it with large images, if you want maybe we can test our implementation using large images.

Large images are relative to the device as well, so an image that worked fine on our devices might be too much to handle on a really budget device. So, I do think we can use telephoto for that.


Update documentation

Motivation and context

How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have added a description of my changes into CHANGELOG file
[x] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.

@azhavoro
Why have you closed it?

We discussed with Nikita and decided to keep opencv.github.io domain for documentation.


Investigate auth automation requirements for Xamarin.iOS

As it is, the Xamarin.iOS project cannot build on a Mac even with Xamarin Studio on the mac.


MetaWeather Issue

Hey Community,
The URL for the MetaWeather API do not work and needs to be fixed.

According to this site, metaweather goes down a lot, so I think the URL is correct, metaweather is just down

Hi @jevoneBarrett
Thanks for opening this issue
We have some problem with Public APIs, so we won't be able to discuss/implement this improvement right now.
Read this issue for more information, please: https://github.com/public-apis/public-apis/issues/3104


Fix aesthetic y-lims bugs

Fix bugs identified by users during roll out of v0.6

`ggplot(data.frame(x = c(21, 40), y = c(30.53830, 166.6323)), aes(x, y)) +
geom_point()
save_e61(filename = "test.svg")`


Surpport for large-scale virtual environment.

I note that in the 3-layer cluster-server-client architecture,  a server must be able to run at least one whole environment. Howerver, we may has little chance to meet this condition in some cases. For instance, if we stimulate the traffic systm of a large city, every single step in this env will take a long time to compute. Thus, it should be better to stimulate this env using several severs, and this may lead to sync problems between severs. Do you have any plan to add such a new feature?
What's more, it seems that neural-mmo lacks a mechanism to train agents online(i.e. update the action policy through the trajectory).
I am interested in finding/designing a framework for massive multiagent environment stimulating. I will appreciate it if you have any idea to share.
Thanks!

Hello @albertcity -- thanks for your interest!

With some tweaks, the current model should work fine up to probably a couple thousand agents. I've designed Neural MMO such that the Server layer really isn't doing much -- the amount of computation required to process agent actions is very small. That said, the long-term goal is to support massive virtual worlds. I've actually taken a step back from infra recently, just because it began to consume the project for months at a time. The current plan is to migrate to RLlib. I'm in active discussion with the devs, and we've already gotten several crucial features and bug fixes. They have a good plan for supporting increasingly large and complex environments, and ideally they'll have reasonable functionality for this by the time we really need to start scaling NMMO.

There's actually nothing preventing you from training online in NMMO. I haven't tried this myself yet because people don't really do this in RL. The closest thing to within-lifetime learning is just having a recurrent policy and performing adaptation within the hidden state, as per RL-squared and derivatives thereof. If you have better ideas, I'd be happy to chat and improve support.

You should join our Discord https://discord.gg/BkMmFUC (Slack alternative) if you're interested in getting involved with the project. We use it for all development discussion -- Github is mainly reserved for bugs and feature PRs


[feature] create cli

Feature request

What is the expected behavior?
Should we also create a create cli to help users quickly start using webpack templates for development?
What is motivation or use case for adding/changing the behavior?
When I want to quickly develop React using Webpack, I need to learn from and read React's CLI. If I use Vue, I need to use Vue CLI. Why doesn't Webpack create its own CLI to make it easier for users to start a new Webpack project?
How should this be implemented in your opinion?
Create a tool pnpm create webpack can be used
Are you willing to work on this yourself?
yes

And I see create-react-app  haved stopped maintaining updates, so when I create React, I prefer to use Vite's template to configure my project

It is already implemented, webpack-cli init, soon we will implement more templates

It is already implemented, webpack-cli init, soon we will implement more templates

Yes, I discovered him later, perhaps because he was not placed in the most prominent position on the official website: Quick Start, which made users want to use webpack quickly and encountered doubts.


Make AzureKeyVaultConfigurationProvider public

We had a few request from people wrapping the AzureKeyVaultConfigurationProvider and needing it to be public and others who wanted advanced transformation of secrets they've received (parse single JSON value into multiple configuration keys, etc.).
This PRs does both.
Fixes: https://github.com/Azure/azure-sdk-for-net/issues/19638
Fixes: https://github.com/Azure/azure-sdk-for-net/issues/15459

Thank you so much! We were blocked switching because of this!


Non-hostile to hostile infestation

Published Logs
When near any insectoids while drafted, no hostile action is taken.

The stack trace clearly calls out RimWorldChildren, not my mod. Please stop trolling.


On-Join Message to Player Removal or Editing

I would like to remove or change/edit the message that the plugin sends to every player when they join the server.   The message looks like something like this:
[Parkour] This server uses Parkour 5.1 (Version)

To remove it, open config.yml and find "Other.Display.JoinWelcomeMessage" and set this to false.
To edit it, open strings.yml and find "Event.Join" and set this to whatever value you want.
Both will require you to enter /pa reload after making your changes.

To remove it, open config.yml and find "Other.Display.JoinWelcomeMessage" and set this to false.
To edit it, open strings.yml and find "Event.Join" and set this to whatever value you want.
Both will require you to enter /pa reload after making your changes.

Thank you really much!


[SPARK-6269] Use a different implementation of java.lang.reflect.Array

This patch uses a different implementation of java.lang.reflect.Array. The code is copied and pasted from
https://bugs.openjdk.java.net/browse/JDK-8051447 with appropriate style changes for this project. The appropriate code is in the public domain, so we can use it since the proper Apache licensing is on it.
The idea is to use pure Java code in implementing the methods there, as opposed to relying on native C code which ends up being ill-performing. This improves the performance of estimating the size of arrays when we are checking for spilling in Spark.
Here's the benchmark discussion from the ticket:
I did two tests. The first, less convincing, take-with-a-block-of-salt test I did was do a simple groupByKey operation to collect objects in a 4.0 GB text file RDD into 30,000 buckets. I ran 1 Master and 4 Spark Worker JVMs on my mac, fetching the RDD from a text file simply stored on disk, and saving it out to another file located on local disk. The wall clock times I got back before and after the change were:
Before: 352.195s, 343.871s, 359.080s
After: 342.929583s, 329.456623s, 326.151481s
So, there is a bit of an improvement after the change. I also did some YourKit profiling of the executors to get an idea of how much time was spent in size estimation before and after the change. I roughly saw that size estimation took up less of the time after my change, but YourKit's profiling can be inconsistent and who knows if I was profiling the executors that had the same data between runs?
The more convincing test I did was to run the size-estimation logic itself in an isolated unit test. I ran the following code:
val bigArray = Array.fill(1000)(Array.fill(1000)(java.util.UUID.randomUUID().toString()))
test("String arrays only perf testing") {
  val startTime = System.currentTimeMillis()
  for (i <- 1 to 50000) {
    SizeEstimator.estimate(bigArray)
  }
  println("Runtime: " + (System.currentTimeMillis() - startTime) / 1000.0000)
}

I wanted to use a 2D array specifically because I wanted to measure the performance of repeatedly calling Array.getLength. I used UUID-Strings to ensure that the strings were randomized (so String object re-use doesn't happen), but that they would all be the same size. The results were as follows:
Before change: 209.275s, 190.107s, 185.424s
After change: 160.431s, 149.487s, 151.66s
.

Test build #28454 has started for   PR 4972 at commit 1fe09de.

This patch merges cleanly.

Test build #28454 has finished for   PR 4972 at commit 1fe09de.

This patch fails to build.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class ArrayReflect

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28454/
Test FAILed.

@mccheah thanks for submitting this. Is the only thing we use getLength?

I believe we use Array.get in the visitArray method in SizeEstimator, so there's that as well.

Test build #28455 has started for   PR 4972 at commit ca063fc.

This patch merges cleanly.

Test build #28455 has finished for   PR 4972 at commit ca063fc.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public class ArrayReflect

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28455/
Test PASSed.

The micro-benchmark definitely shows the alternative code is faster, although it only benchmarks the time taken in this one method. The question is how much of the overall time is consumed by a simple array length check. Your first test is more convincing, although the difference seems quite a bit larger than I'd expect. Wow, does it really get called so much / the native overhead is that big?

I noticed that a good chunk of the time spent in the size estimation method was in Array.getLength; @justinuang (who originally proposed this idea - got to give credit where it's due!) also observed this and originally tipped me off to it.

Test build #28489 has started for   PR 4972 at commit a557ab8.

This patch merges cleanly.

I changed the implementation to not use the code from the ticket, and instead created a wrapper around arrays, and a factory method that did the appropriate casting and building of the wrapper object.
I was mildly concerned about the performance of this implementation, as now I'm instantiating a new object as opposed to before when I was purely invoking static methods. I ran some more localized unit test benchmarks.
With the 1000 x 1000 2D String array tests I was doing before, the performance difference seems to be better, but I might as well attribute the difference to noise since the difference is so small:
Before this PR at all:  209.275 s, 190.107 s, 185.424 s
Before most recent commit: 160.431, 149.487, 151.66
After most recent commit: 151.812, 151.505, 142.953
I was mostly concerned about the overhead to create the object if the arrays were small, though, because now I'm spending more time on creating the wrapper itself. It turns out we're still doing better even on small arrays compared to before the PR however. I tested estimating the size of a 1000-String 1D array:
Before PR: 27.246, 32.124, 28.433
After commit: 20.036, 20.465, 21.38
Most importantly however we should be able to get around the licensing issues now. I also made the code only use the array get() and getLength() methods since we never set() on arrays anywhere.

If you write this in Scala, you can use value classes to avoid the allocation, while preserving the OOP features.

I wanted to avoid Scala because we're working with checking instanceOf Java array of primitive type, which is slightly scary to me. Do you know the behavior of converting Scala arrays and Java arrays of primitive types?

Scala arrays are just Java arrays. There is no craziness there.

Maybe I'm reading too much into this... but Scala arrays are always of the "boxed" type. Does that create issues if I create a Java array of an un-boxed type, i.e. primitive type, and try to check arr.isInstanceOf there? Or, does the fact that the array object itself already live in scala-land mean that it's always going to be array of boxed type?

Yea - Scala arrays are not always boxed. Array[Int] is the same as int[] in Java.

Test build #28489 has finished for   PR 4972 at commit a557ab8.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
public abstract class ReflectArrayGetter

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28489/
Test PASSed.

Test build #28497 has started for   PR 4972 at commit 93f4b05.

This patch merges cleanly.

I wrote it in scala, extending AnyVal and writing a sealed trait that extends Any to provide the extension point. However, I believe that using the trait incurs the allocation overhead, which is what we were trying to avoid in moving to Scala. From the scala docs
"A value class can only extend universal traits and cannot be extended itself. A universal trait is a trait that extends Any, only has defs as members, and does no initialization. Universal traits allow basic inheritance of methods for value classes, but they incur the overhead of allocation."
http://docs.scala-lang.org/overviews/core/value-classes.html
That being said, I also didn't see any significant performance degradation in moving to Scala. My most recent numbers:
Estimating the size of a 1000 x 1000 2D String array 50,000 times: 153.329 s, 153.1 s, 150.67 s
Estimating the size of a 1000 1D String array 1,000,000 times: 19.951 s, 20.75 s, 20.551 s
So we didn't lose any performance from moving from Java to Scala (compare with numbers I've reported above in this discussion), but we gained a ton of readability. It's odd to be using Java in this Scala-laden codebase anyways, so it seems good to keep our things bound to Scala.

Test build #28497 has finished for   PR 4972 at commit 93f4b05.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
sealed trait CastedArray extends Any

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28497/
Test PASSed.

I think maybe @rxin is suggesting a bit of code like what you see in ScalaRunTime.array_length, for example?
  def array_length(xs: AnyRef): Int = xs match {
    case x: Array[AnyRef]  => x.length
    case x: Array[Int]     => x.length
    case x: Array[Double]  => x.length
    case x: Array[Long]    => x.length
    case x: Array[Float]   => x.length
    case x: Array[Char]    => x.length
    case x: Array[Byte]    => x.length
    case x: Array[Short]   => x.length
    case x: Array[Boolean] => x.length
    case x: Array[Unit]    => x.length
    case null => throw new NullPointerException
  }

@rxin can you confirm? However I believe we wanted to only do the cast once and re-use the casted object on all future invocations of array.get(). That being said my convoluted if statement in CastedArray.castAndWrap can be cleaned up with similar Scala code to ScalaRuntime.array_length.

Test build #28521 has started for   PR 4972 at commit 5d53c4c.

This patch merges cleanly.

Test build #28521 has finished for   PR 4972 at commit 5d53c4c.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
sealed trait CastedArray extends Any

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28521/
Test FAILed.

Test build #28524 has started for   PR 4972 at commit cb67ce2.

This patch merges cleanly.

Test build #28524 has finished for   PR 4972 at commit cb67ce2.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
sealed trait CastedArray extends Any

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28524/
Test PASSed.

I haven't thought it through at close range but I had meant something like ...
def sizeOf(xs: AnyRef): Int = xs match {
    case x: Array[Int]     => x.length * 4
    case x: Array[Double]  => x.length * 8
    case x: Array[Long]    => x.length * 8
    ...
  }

... but if the point is merely to avoid native code, how about just using the 'equivalent' of the Arrays methods from Scala? they look like non-native code and do about the same thing as the original optimized version you pasted.
I think you're taking it a step further and trying to assess the component type just once, which is probably a further win but enough to matter and be worth the complexity?
Hm, I don't think @specialized can be used here, but I wish it could.

Hm, yeah I'm not too opinionated about saving the tiniest of fractions of seconds by avoiding calling instanceOf too many times - instanceOf is really really cheap compared to java.lang.reflect.Array as it is. If the majority opinion is that I made it too complex we can move to just using Scala's Arrays methods.
(I don't have that much time to work on this any more until after the weekend though.)

Latest just uses ScalaRunTime which also doesn't use the native java.lang.reflect.Array. The underlying implementation is basically identical to the first Java implementation that I wrote on here, except I need to do an extra "asInstanceOf[AnyRef]" to convert from Any (which is what ScalaRunTime.array_apply returns) to AnyRef (which is what we want in SizeEstimator).

Test build #28545 has started for   PR 4972 at commit db890ea.

This patch merges cleanly.

Test build #28545 has finished for   PR 4972 at commit db890ea.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28545/
Test PASSed.

Great, so, this still gets a pretty good speed-up? sounds like a win to me. I'll leave it for a day or so for other thoughts, but it's pretty clean.

I believe the pull request message and the commit message are out of date, because of the way this thread went.

Test build #28599 has started for   PR 4972 at commit 16ce534.

This patch merges cleanly.

Test build #28599 has finished for   PR 4972 at commit 16ce534.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28599/
Test PASSed.

@mccheah yeah are you able to go back and revise the PR title, JIRA title, and description? I can touch some of that up on merge but just boiling it down to a quick and up to date summary would help me.

Other than the two minor things I pointed out, and the need to update title/pr description, this change lgtm. Thanks!

Test build #28662 has started for   PR 4972 at commit 8527852.

This patch merges cleanly.

I just updated the PR description and title as well. Not sure if it's necessary to amend the commit messages?

Nah your commit messages don't matter since those get squashed. You updated the right things. LGTM. I'll merge after a pause for any more comments.

Test build #28662 has finished for   PR 4972 at commit 8527852.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28662/
Test PASSed.


[FLINK-5188] Create analog of RowCsvInputFormat in java and adjust all the imports of Row and RowTypeInfo

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

[ ] General

The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
The pull request addresses only one issue
Each commit in the PR has a meaningful commit message (including the JIRA id)

[ ] Documentation

Documentation has been added for new functionality
Old documentation affected by the pull request has been updated
JavaDoc for public methods has been added

[ ] Tests & Build

Functionality added by the pull request is covered by tests
mvn clean verify has been executed successfully locally or a Travis build has passed

Hi @fhueske okay, as you wish

Merging


Add Windows support

Here's a summary of the changes:

Added crate path-slash to convert Windows paths to Unix-style paths for display purposes. Otherwise the test snapshots fail because the test path is displayed differently on Windows (with \ rather than /).
Handle Windows-style newlines (\r\n) when interacting with the SMT solvers.
Add Powershell script to download solvers on Windows, and mention this in the README.

There was a merge commit I did using the GitHub interface, which didn't have the Signed-off-by line, so I force-pushed to remove it.

Oded and I discussed it and we don't think it's worth it for us to maintain Windows support, especially since WSL seems to work well for this use case.
That said, some of the changes in this PR are general improvements and should also make the code fairly compatible. If you remove the PowerShell scripts I'd be happy to merge everything else. If we (or you!) decide to implement cargo xtask, then I think adding (somewhat unofficial) Windows support would become easy.

Sure, I understand Windows is not a priority. That's okay. (I personally use WSL 2 myself.)
I don't have the bandwidth to look into cargo-xtask now, so I've removed the PowerShell scripts.

Thanks for updating the PR!


[Migration] added renameClass(_:to:).

Fixes #2491.

Still missing Swift tests.

Updating testRenamingClass to use dynamic schemas somehow broke the test and I don't know why. Let me know if you have an idea what could be causing this.

@tgoyne @bdash this is ready for review. A few points to note:

The Objective-C tests only pass when using runtime-generated classes. I tried moving to dynamic objects (adf1a6f6c2ca00bda69e81149a32384af4ccc19c) but that failed for reasons I couldn't figure out. I personally don't see how this would ever be an issue, but I may be missing something.
The Swift tests only run on Swift 2 in Debug mode because they rely on @testable. Funnily enough, dynamic objects work for the Swift tests.

CI failures are unrelated.

Bump @tgoyne @bdash

Bump @tgoyne @bdash

The fact that the schemas must match seems to make this method difficult to use in cases where you may add a property to a class in the future. When you add a property you'll be forced to replace your use of rename with an alternative in order to support migrating from pre-rename schema versions.

Rather than requiring that the properties match, it could rename the table and then update the target table to match the schema.

The dynamic object version of the test is failing because -[RLMObjectSchema initWithClassName:objectClass:properties:] doesn't set accessorClass. After fixing that it passes for me.

Thanks for the tip about accessorClass, @tgoyne.
As for updating the target table to match the schema after performing the renaming, would that mostly just be a matter of calling ObjectStore::create_tables() with the update_existing argument set to true immediately after the rename?

When will we get this update? I really need this functionality.

@magyarosibotond I'm still working on this functionality. I don't have a timeline on when I'll be able to complete this work.

Cool! Can't wait to be ready! Any alternative solution until then?

Cool! Can't wait to be ready! Any alternative solution until then?

You can copy over all the data from a previous class to a new class.

Thanks! Worked like a charm!

@jpsim Any updates here?

No

@jpsim any deadline on this one? When can we have such feature? Thanks in advance.

Closed, not merged 🙁 Seems that this won't be released.


fix typo in README

Thanks @ghiculescu!
Closing in favor of https://github.com/intercom/intercom-rails/pull/305

haha, that's this PR

🤦 Updated the other PR!


README updates

Made the following readme updates, in coordination with Kesh:

Updated Project Origin callout
Changed "I" to "we" or "team" in multiple references
clarified references to Adam's original project vs original clone with the same name
Moved Previous Communications under Communciations
Moved Publicity to a separate MD file

Thanks for going through this, this is way overdue.
I will remove PUBLICITY.md in a separate PR; we've outgrown it by now.


Can tvm be used on orin-qnx, it will report a lot of 'undefined xxx' when cross-build tvm for orin-qnx

Can tvm be used on orin-qnx? It will report a lot of 'undefined xxx' when I cross-build tvm for orin-qnx？

Please use https://discuss.tvm.apache.org/


#2 Upgrade to latest yatspec

Upgrade to latest version - fix breaking change in unit test

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Installing dependencies...
Switching to root user to install dependencies...
sh: line 1: apt-get: command not found
Failed to install browsers
Error: Installation process exited with code: 127
2023/10/30 19:55:08 could not run driver: exit status 1
exit status 1

ok nothing to do with this repo:
https://github.com/search?q=repo%3Amicrosoft%2Fplaywright++"your+OS+is+not+officially+supported+by+Playwright"&type=code


Add tooltips and "read more" links to the manage package deprecation form

Tracking this separately because this was not done in https://github.com/NuGet/NuGetGallery/pull/6912

No longer necessary because no confusing vulnerability terms.


Bump gleam-lang/setup-gleam from v1.0.0 to v1.0.1

It seems there are merge conflicts bit I can't see what they are on my phone. Can you check this please? Thanks

Resolved!

Thanks!


No "http_status" metrics

version: Kong Enterprise <IP_ADDRESS>
I installed the plugin like this
curl -X POST http://<admin-hostname>:8001/plugins/ \
    --data "name=prometheus"

I see metrics but not http_status
Do I need to do something else to enable it ????

to enable it ? do you need to do it per service ?


Support for React 16

I used it for my project, but recently I upgraded my project to React 16, and this package has the error: "TypeError: React.createClass is not a function". I think it is because React 16 remove the function of createClass. Can we upgrade this package like declaring React.Component so that it can support React 16? Thank you!

I simply change the way claiming React Class as
class DOMify extends React.Component {     render() {         return (
                 {transform(this.props.value)}
         )     } }
And it will works fine with React 16 (In my code, it is ^16.7.0), if you want, I can create the PR and merge it into your package to make this package works with latest React version.

I simply change the way claiming React Class as
class DOMify extends Component {
    render() {
        return (

                {transform(this.props.value)}

        )
    }
}
And it will works fine with React 16 (In my code, it is ^16.7.0), if you want, I can create the PR and merge it into your package to make this package works with latest React version.


After a cold boot, colours switch back and forth between white and the correct colour

The hue wheel goes through the colours but between each colour it transitions it to white. Any idea why/how to fix?
Thanks

Could be that some other program is also changing the LED colours at the same time.

Did you fix the issue?

Hey sorry for not replying earlier. If it happens it is due to my PC losing
power completely. I can just reinstall mystic, boot it, then uninstall it.
Thanks!
On Sat, 5 Sep 2020, 17:28 Pedro Fanha<EMAIL_ADDRESS>wrote:

Did you fix the issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ixjf/MSIRGB/issues/116#issuecomment-687632594, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AP4OKBWDYVDQIMCIMOYBZIDSEJRMPANCNFSM4NYWJ7JQ
.

Which motherboard do you have?

B450M Gaming Plus
On Sun, Sep 6, 2020 at 7:26 AM Pedro Fanha<EMAIL_ADDRESS>wrote:

Which motherboard do you have?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ixjf/MSIRGB/issues/116#issuecomment-687708988, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AP4OKBRLOQDUD7VOAT3JF4TSEMTQFANCNFSM4NYWJ7JQ
.

Okay, I'll look into this ASAP!

Thanks for the dedication!
On Sun, Sep 6, 2020 at 8:52 AM Pedro Fanha<EMAIL_ADDRESS>wrote:

Okay, I'll look into this ASAP!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ixjf/MSIRGB/issues/116#issuecomment-687719189, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AP4OKBTJAYKOTWPHFC5AXXDSEM5SNANCNFSM4NYWJ7JQ
.

Sorry, is this still happening? So I know whether I should investigate for a fault on my side.

It's all good, It just requires MSI Mystic Light to change to any profile
and then it works fine, with the RGB loop.
Thanks for your continued work on this project, it's made my system look
much better!
-surftor
On Mon, Aug 23, 2021 at 9:08 PM Pedro Fanha @.***>
wrote:

Sorry, is this still happening? So I know whether I should investigate for
a fault on my side.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ixjf/MSIRGB/issues/116#issuecomment-904084685, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AP4OKBVBOM7TKL4F65IVNFTT6KTFDANCNFSM4NYWJ7JQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

Huh, you shouldn't have to. I'll try to figure this out this week. Sorry for the VERY LONG delay, but with university, this is not at all one of my priorities :P


Integrate with iroh

Here is the example of how to use iroh: https://github.com/n0-computer/sendme
It is exactly the same use-case we are solving in Drop ⏤ sending a file by a public key. Iroh takes care of all NAT traversal and data transmission. We only need to prepare QR code with the data necessary to initialize the transfer. Probably, besides the public key also the file checksum should be encoded into the QR.

Is it open ?


Add a factory for reporting with PickledGraphite

Support for sending pickled graphite metrics was added to https://github.com/dropwizard/metrics/blob/3.2-development/metrics-graphite/src/main/java/com/codahale/metrics/graphite/PickledGraphite.java but a complementary factory implementation has not been added to Dropwizard.
(This is a reminder to myself to do this and submit a PR unless its done in the interim)

Closing as a duplicate of #1442


testing sequence caching

Once the test framework is up and running, there should be a test that the caching of sequences (SequenceCached.ts) never calls calculate() twice for the same index n.  The random integer sequence functionality (PR #53) relies on this guarantee, since we wish to guarantee that the randomly generated value is the same if the same term is called twice.  But its calculate() function is just a call to Random(), so without careful caching, this guarantee would not be met.

Depends on resolution of #25. (Does Github have formal dependencies among issues/PRs? Some repository packages do...)

This should be folded into #420. Adding milestone.

Completed in ui2 thanks to #420. Closing.


Add readme

Signed-off-by: Justin Kolberg<EMAIL_ADDRESS>Closes #2.

@amdprophet this looks great! I added a TOC for easier navigation (and at-a-glance list of endpoints). Merging!


No formatter option for space between colon and type in TypeScript

From @M-Pixel on October 20, 2016 5:42

VSCode Version: 1.6.1
OS Version: Win 10

Steps to Reproduce:

Write a TypeScript interface definition omitting space between colon and type (e.g. name:string)
Autoformat
Note that a space was inserted between ":" and "string"
Open user preferences in order to change this behavior
Note that among the many typescript.format.insertSpaceAfter* options, none address this area of syntax.

I prefer to omit this conventional space in order to differentiate {key: val} from {name:Type}. It would be nice to have the option to autoformat without having to forgo this convention.
Copied from original issue: Microsoft/vscode#14041

From @kcbleeker on October 20, 2016 9:48
Yes please

From @kcbleeker on October 20, 2016 18:20
That's a little frustrating in a VSCode versus IntelliJ battle.

From @roblourens on October 20, 2016 17:54
I think we only get the formatting options that the TS service exposes.

From @roblourens on October 20, 2016 18:22
tslint autofix might do this.

@M-Pixel thank you for opening this issue. We are looking at ways to improve this experience and will consider your specific use case. Are there are formatting options you would like to see?
Ping @jrieken as this might be relevant for your formatting work.

Please also consider my code formatting suggestions. https://github.com/Microsoft/TypeScript/issues/9124

@heroboy noted on my end. thank you.

@waderyan For reference on @roblourens idea about tslint autofix, it doesn't look like it can autofix this at this yet, and I feel that running a formatOnSave which "breaks" the formatting, and then trying to undo that with lint autofix is the wrong way to operate anyway.

Our team has adapted the convention of no space between the colon and type in TypeScript, but VSCode does not support this. This currently prevents me from utilizing auto-formatting in VSCode. Eagerly waiting for VSCode team to implement this format option. Thank you!

Any updates on this?

+1 - we also need that feature. tslint has the option but it doesn't work correctly when both format and tslint fix are applied on save.

Since the colon : already divides the variable name from its type annotation, I see no reason for the additional empty space separator, so I also would like this to be a user-preference. Shouldn't be too difficult to implement for somebody familiar with the code. Thank you.

It's been 4 years and still no option for this?

I don't see any harm in having more customisation options for formatting.
Especially since there's already a matching option insertSpaceBeforeTypeAnnotation, which arguably is a rarer use case.
Consider:
function foo(e: (a: number, b: string | { f: string, g: boolean }) => void, o?: boolean): { r: string, d: any} { ... }

and:
function foo(e:(a:number, b:string | { f:string, g:boolean }) => void, o?:boolean):{ r:string, d:any } { ... }

The space after colon can feel unnecessary and feel like forcing the lines to be longer than they need to be.
Also, I can read the types of each parameter/field much more easily without the space after colon, since they are more "grouped" together with the names.
Spaces after colons make them look like they're values, instead of types.

From discussion on the team:

After 4 years and only 18 upvotes, we haven't received enough feedback to really justify the work and extra editor flags here, nor do we believe it's a good stylistic choice for code.

My take on this is that flags add complexity. Features that we think are not useful aren't worth the complexity of a new flag.

I'd love to see this issue re-opened and a little more activity here from the community. This is essentially locking developers into a coding style that many don't like. I personally don't use the auto formatter, but I do use auto complete. When using auto complete to generate code, say when overriding an inherited function, VS Code spits out an unnecessary space. The linter complains about this (I do use linter rules :) ). It wastes seconds here and there cleaning it up. That time slowly accumulates and breaks flow enough for me to search for a solution and find this disappointing thread.


set cursor position via a bookmark with setHTML

getHTML can be called with:
editor.getHTML({withBookMark: 1})

and it will return a bookmark of the form:

ab<input id="squire-selection-start" type="hidden"><input id="squire-selection-end" type="hidden">cd

We need to do the opposite, something of the form:
setHTML(html, {withBookMark: 1})

and have it properly position the cursor.  For the diffing procedure we get back a list of edits that have been made to the starting content to transform it to the new content.  We can use those edits to calculate how the cursor should be moved when adding those edits to a block.

I think using the same bookmarking system makes sense and we might be able to get this merged back into squire.


502 Bad Gateway

https://shiny.marineenergy.app/report-v2/

Shiny log
Most recent:
Listening on http://<IP_ADDRESS>:44873
output$map_side - beg
output$map_side - end
Warning: The shape palette can deal with a maximum of 6 discrete values because
more than 6 becomes difficult to discriminate; you have 11. Consider
specifying shapes manually if you must have them.
output$map_side - beg
output$map_side - end
Warning: The shape palette can deal with a maximum of 6 discrete values because
more than 6 becomes difficult to discriminate; you have 11. Consider
specifying shapes manually if you must have them.
Warning: Error in sum: invalid 'type' (list) of argument
  99: %>%
  98: map_projects
  97: ::
htmlwidgets
shinyRenderWidget [/share/github/apps/report-v2/server.R#249]
  96: func
  83: renderFunc
  82: output$prj_map
   1: runApp

API appears up:
https://api.marineenergy.app

back to 502 Bad Gateway after adding Current/Ocean Current
Froze:

Then refresh & got 502 Bad Gateway


SPM support

Would be great to have SPM supported, is this something you'd want a PR for?

Hey, I actually already tried it, but this project relies heavily on UIKit, and I have yet to find a way (if at all possible at the moment) to make a SPM library that supports it. It doesn't seem possible at the moment but I might be overlooking something.

I think Xcode 11 will be able to build the package with a dependency on UIKit but the swift build command will not work (which is fine since this is an iOS library). But I might be wrong here.

Sure, thanks!

Closing this as it seems to work when adding the repo in Xcode 11. @theolampert


Rendering Problems on Samsung Devices

Hello,
i faced some problems while rendering a background svg and a 3d animation on Samsung devices with low processing power. Is there any known issue about addressing samsung devices?
Devices tested:

Samsung Galaxy A13, S9

Other devices that work:

Pixel 4a (low processing power) (Android 13), Pixel 6 (Android 13), Huawei P20 (Android 10), Samsung Galaxy S10  (Android 12)

My assumption is, that some of the slower Samsung devices are facing performance issues and discard UI frames, caused by long loading times. I already tried to reduce the jank utilizing SkSL warmup, but with no success.
I'm not quite sure how to resolve the problem due to the fact, that no errors are tracked by the flutter system.

maybe render svg has performance problem
try use image replace svg?

Not yet, but I will give it a try!
Thanks


Flake8 rule 'E901' reported an invalid point

Flake8 reported an invalid point for the rule E901, with the messge IndentationError: expected an indented block.

Debug information:
Atom version: 1.19.3
Flake8 version: 2.5.5 (pep8: 1.5.7, mccabe: 0.2.1, ProxyChecker: 0.0.1, hacking.core: 0.0.1, pyflakes: 0.8.1) CPython 3.6.2 on Windows

Please update your flake8 version (pip install -U flake8). This particular error should be fixed in flake8>=3.2.1.