Bug after upgrading to 0.12.21

After upgrading to this version I get:
Note: Using configuration file /home/runner/work/legaldesk/legaldesk/phpstan.neon.dist.
 -- ---------------------------------------------------------------------------
     Error
 -- ---------------------------------------------------------------------------
     Internal error: Internal error: An exception occurred in driver:
     SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo failed:
     Temporary failure in name resolution in file
     /home/runner/work/legaldesk/legaldesk/src/Command/DeleteArchivedCommand.p
     hp
     Run PHPStan with --debug option and post the stack trace to:
     https://github.com/phpstan/phpstan/issues/new
     Internal error: Internal error: An exception occurred in driver:
     SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo failed:
     Temporary failure in name resolution in file
     /home/runner/work/legaldesk/legaldesk/src/EventSubscriber/LetterSubscribe
     r.php
     Run PHPStan with --debug option and post the stack trace to:
     https://github.com/phpstan/phpstan/issues/new
     Internal error: Internal error: An exception occurred in driver:
     SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo failed:
     Temporary failure in name resolution in file
     /home/runner/work/legaldesk/legaldesk/src/Repository/UnclassifiedLetterRe
     pository.php
     Run PHPStan with --debug option and post the stack trace to:
     https://github.com/phpstan/phpstan/issues/new
     Internal error: Internal error: An exception occurred in driver:
     SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo failed:
     Temporary failure in name resolution in file
     /home/runner/work/legaldesk/legaldesk/src/Repository/RsvLetterRepository.
     php
     Run PHPStan with --debug option and post the stack trace to:
     https://github.com/phpstan/phpstan/issues/new
     Internal error: Internal error: An exception occurred in driver:
     SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo failed:
     Temporary failure in name resolution in file
     /home/runner/work/legaldesk/legaldesk/src/Repository/LetterRepository.php
     Run PHPStan with --debug option and post the stack trace to:
     https://github.com/phpstan/phpstan/issues/new
     Internal error: Internal error: An exception occurred in driver:
     SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo failed:
     Temporary failure in name resolution in file
     /home/runner/work/legaldesk/legaldesk/src/Repository/AutomotiveLetterRepo
     sitory.php
     Run PHPStan with --debug option and post the stack trace to:
     https://github.com/phpstan/phpstan/issues/new
     Internal error: Internal error: An exception occurred in driver:
     SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo failed:
     Temporary failure in name resolution in file
     /home/runner/work/legaldesk/legaldesk/src/Repository/BankingLetterReposit
     ory.php
     Run PHPStan with --debug option and post the stack trace to:
     https://github.com/phpstan/phpstan/issues/new
 -- ---------------------------------------------------------------------------

You need to run with —debug as the message says and you’ll see the stack
trace. This is coming from your app.
On Fri 23. 10. 2020 at 23:10, Oskar Stark<EMAIL_ADDRESS>wrote:

After upgrading to this version I get:
Note: Using configuration file /home/runner/work/legaldesk/legaldesk/phpstan.neon.dist.

 Error

 Internal error: Internal error: An exception occurred in driver:
 SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo failed:
 Temporary failure in name resolution in file
 /home/runner/work/legaldesk/legaldesk/src/Command/DeleteArchivedCommand.p
 hp
 Run PHPStan with --debug option and post the stack trace to:
 https://github.com/phpstan/phpstan/issues/new
 Internal error: Internal error: An exception occurred in driver:
 SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo failed:
 Temporary failure in name resolution in file
 /home/runner/work/legaldesk/legaldesk/src/EventSubscriber/LetterSubscribe
 r.php
 Run PHPStan with --debug option and post the stack trace to:
 https://github.com/phpstan/phpstan/issues/new
 Internal error: Internal error: An exception occurred in driver:
 SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo failed:
 Temporary failure in name resolution in file
 /home/runner/work/legaldesk/legaldesk/src/Repository/UnclassifiedLetterRe
 pository.php
 Run PHPStan with --debug option and post the stack trace to:
 https://github.com/phpstan/phpstan/issues/new
 Internal error: Internal error: An exception occurred in driver:
 SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo failed:
 Temporary failure in name resolution in file
 /home/runner/work/legaldesk/legaldesk/src/Repository/RsvLetterRepository.
 php
 Run PHPStan with --debug option and post the stack trace to:
 https://github.com/phpstan/phpstan/issues/new
 Internal error: Internal error: An exception occurred in driver:
 SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo failed:
 Temporary failure in name resolution in file
 /home/runner/work/legaldesk/legaldesk/src/Repository/LetterRepository.php
 Run PHPStan with --debug option and post the stack trace to:
 https://github.com/phpstan/phpstan/issues/new
 Internal error: Internal error: An exception occurred in driver:
 SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo failed:
 Temporary failure in name resolution in file
 /home/runner/work/legaldesk/legaldesk/src/Repository/AutomotiveLetterRepo
 sitory.php
 Run PHPStan with --debug option and post the stack trace to:
 https://github.com/phpstan/phpstan/issues/new
 Internal error: Internal error: An exception occurred in driver:
 SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo failed:
 Temporary failure in name resolution in file
 /home/runner/work/legaldesk/legaldesk/src/Repository/BankingLetterReposit
 ory.php
 Run PHPStan with --debug option and post the stack trace to:
 https://github.com/phpstan/phpstan/issues/new

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/phpstan/phpstan-doctrine/issues/156, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAZTOE7SG5TILF2OIDUOZLSMHWLJANCNFSM4S5BHXDA
.

--
Ondřej Mirtes

You need to run with —debug as the message says and you’ll see the stack
trace.

Thank you, I upgraded the PR header 👍

Interesting...
Maybe this is caused by a copy paste error 🤔
AutomotiveLetter and RsvLetter extend Letter:
/**
 * @ORM\Table(name="letters", indexes={@ORM\Index(name="letter_status", columns={"status"})})
 * @ORM\Entity
 * @ORM\InheritanceType("SINGLE_TABLE")
 * @ORM\DiscriminatorColumn(name="type", type="string")
 * @ORM\DiscriminatorMap({
 *     "automotive": "AutomotiveLetter",
 *     "rsv": "RsvLetter"
 * })
 */

LetterRepository:
<?php

declare(strict_types=1);

namespace App\Repository;

use App\Entity\Letter;
use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
use Doctrine\Persistence\ManagerRegistry;

/**
 * @method Letter|null find($id, $lockMode = null, $lockVersion = null)
 * @method Letter|null findOneBy(array $criteria, array $orderBy = null)
 * @method Letter[]    findAll()
 * @method Letter[]    findBy(array $criteria, array $orderBy = null, $limit = null, $offset = null)
 *
 * @phpstan-extends \Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository<\App\Entity\Letter>
 */
final class LetterRepository extends ServiceEntityRepository
{
    public function __construct(ManagerRegistry $registry)
    {
        parent::__construct($registry, Letter::class);
    }

    public function countLetters(\DateTime $from, \DateTime $until): int
    {
        $qb = $this->createQueryBuilder('l');
        $qb->select('count(l.id)');
        $qb->where(
            $qb->expr()->andX(
                $qb->expr()->lte('l.createdTimestamp', ':until'),
                $qb->expr()->gte('l.createdTimestamp', ':from'),
            )
        );

        $qb->setParameter('from', $from);
        $qb->setParameter('until', $until);

        return \intval($qb->getQuery()->getResult()[0][1] ?: 0);
    }

    public function countLetterStatus($status): int
    {
        $qb = $this->createQueryBuilder('l');
        $qb->select('count(l.id)');
        $qb->where(
            $qb->expr()->andX(
                $qb->expr()->eq('l.status', ':status'),
            )
        );

        $qb->setParameter('status', $status);

        return \intval($qb->getQuery()->getResult()[0][1] ?: 0);
    }
}

AutomotiveLetterRepository:
<?php

declare(strict_types=1);

namespace App\Repository;

use App\Entity\AutomotiveLetter;
use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
use Doctrine\Persistence\ManagerRegistry;

/**
 * @method AutomotiveLetter|null find($id, $lockMode = null, $lockVersion = null)
 * @method AutomotiveLetter|null findOneBy(array $criteria, array $orderBy = null)
 * @method AutomotiveLetter[]    findAll()
 * @method AutomotiveLetter[]    findBy(array $criteria, array $orderBy = null, $limit = null, $offset = null)
 *
 * @phpstan-extends \Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository<\App\Entity\AutomotiveLetter>
 */
final class AutomotiveLetterRepository extends ServiceEntityRepository
{
    public function __construct(ManagerRegistry $registry)
    {
        parent::__construct($registry, AutomotiveLetter::class);
    }

    public function countLetters(\DateTime $from, \DateTime $until)
    {
        $qb = $this->createQueryBuilder('l');
        $qb->select('count(l.id)');
        $qb->where(
            $qb->expr()->andX(
                $qb->expr()->lte('l.createdTimestamp', ':until'),
                $qb->expr()->gte('l.createdTimestamp', ':from'),
            )
        );

        $qb->setParameter('from', $from);
        $qb->setParameter('until', $until);

        return \intval($qb->getQuery()->getResult()[0][1] ?: 0);
    }

    public function countLetterStatus($status)
    {
        $qb = $this->createQueryBuilder('l');
        $qb->select('count(l.id)');
        $qb->where(
            $qb->expr()->andX(
                $qb->expr()->eq('l.status', ':status'),
            )
        );

        $qb->setParameter('status', $status);

        return \intval($qb->getQuery()->getResult()[0][1] ?: 0);
    }
}

RsvLetterRepository:
<?php

declare(strict_types=1);

namespace App\Repository;

use App\Entity\RsvLetter;
use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
use Doctrine\Persistence\ManagerRegistry;

/**
 * @method RsvLetter|null find($id, $lockMode = null, $lockVersion = null)
 * @method RsvLetter|null findOneBy(array $criteria, array $orderBy = null)
 * @method RsvLetter[]    findAll()
 * @method RsvLetter[]    findBy(array $criteria, array $orderBy = null, $limit = null, $offset = null)
 *
 * @phpstan-extends \Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository<\App\Entity\RsvLetter>
 */
final class RsvLetterRepository extends ServiceEntityRepository
{
    public function __construct(ManagerRegistry $registry)
    {
        parent::__construct($registry, RsvLetter::class);
    }

    public function countLetters(\DateTime $from, \DateTime $until): int
    {
        $qb = $this->createQueryBuilder('l');
        $qb->select('count(l.id)');
        $qb->where(
            $qb->expr()->andX(
                $qb->expr()->lte('l.createdTimestamp', ':until'),
                $qb->expr()->gte('l.createdTimestamp', ':from'),
            )
        );

        $qb->setParameter('from', $from);
        $qb->setParameter('until', $until);

        return \intval($qb->getQuery()->getResult()[0][1] ?: 0);
    }

    public function countLetterStatus($status): int
    {
        $qb = $this->createQueryBuilder('l');
        $qb->select('count(l.id)');
        $qb->where(
            $qb->expr()->andX(
                $qb->expr()->eq('l.status', ':status'),
            )
        );

        $qb->setParameter('status', $status);

        return \intval($qb->getQuery()->getResult()[0][1] ?: 0);
    }
}

Could be the problem, that the all use $qb = $this->createQueryBuilder('l'); instead of:

$qb = $this->createQueryBuilder('l'); <- Letter
$qb = $this->createQueryBuilder('al'); <- AutomotiveLetter
$qb = $this->createQueryBuilder('rl'); <- RsvLetter

Ich changed them accordingly to l, al, rl, but it doesn't change anything 🤔  plus it works in the version before 🤔
Anything else I can check?

Just ran into the same error, in a different project.
🤷♂

This looks like the same issue as https://github.com/phpstan/phpstan-doctrine/issues/144.

Fixed: https://github.com/phpstan/phpstan-doctrine/commit/a4966eee1fb42383e752e9c84bd5b7b07b01e57a
Tagged as phpstan-doctrine 0.12.22. Please test it :) Thanks!

Thank you, @ondrejmirtes - works for me!
👍

Thank you, works for me, too 👍


Archlinux build

All seems to run well on my Arch Linux system, except 66% tests passed.
See attached text file for summary extract ctest output.
ctest-summary.txt

Thank you so much for doing this! I'll take a look at the failing tests.

Should I rebase my branch so this pull request is up to date?

Sorry Rodney, I meant to check out those failing tests but haven't quite got around to getting myself a working Arch VM yet.
The PR only touches the documentation, which hasn't changed significantly if I recall correctly, so I wouldn't worry too much about rebasing for now.

Thanks Rodney! Sorry we left this languishing for so long... have been meaning to test this with an Arch VM but it never happened. Am now briefly revisiting the build process, and it makes sense to take your changes before anything happens that will cause merge conflicts with them.


Smaller (or adjustable) text size option for Stats GUI?

The text size for Stats GUI seems to be quite a bit larger than that used for EvoGUI. (Maybe you chose the text size to be consistent with the clock and FPS indicator which is shown nearby?) I find the new size to be a bit intrusive, and it certainly takes up more screen space. Would it be possible to add a toggle setting to Stats GUI so that we could use the original smaller EvoGUI text size if we prefer that? I don't usually have the debug clock or fps display on, so size consistency is not an issue for me, but screen real estate is.
Thanks for your time.

I have the same request. What was great about EvoGUI is how small it was.


How is the dataset PATTERNCOM divided into training and testing sets? Could you please clarify the splitting strategy used?

Hello @shijiangming1,
The PatternCom dataset is used for zero-shot composed image retrieval in the paper, i.e. is used only for testing. Our method is training-free on top of pretrained VLMs and we use the dataset only for testing.
However, the dataset can be easily used for training a new method, if this is your idea. I will asap come back with a proposed official way of splitting the dataset in training and test.
Thanks a lot 🙏🏽

Thank you for your reply. I am very much looking forward to the official way of splitting the dataset into training and test.

Hello @shijiangming1,
Have a look on this. Here you will find a proposed way of splitting the PatternCom dataset based on the examples. The idea is, for example, for the attribute shape and for the category swimming pools, to split using 80% of oval', rectangular`, etc. for training, the rest 10% and 10% for validation and testing. This is closely related to the way the CIRR dataset was split (in Computer Vision).
Moreover, if this split is not suitable for your specific application, please free to propose another way of splitting, inform us about it and we will also put it here on our GitHub repo. That is, maybe another split is more suitable for your needs. I have also included a python script in GDrive to split the CSVs, modify accordingly.
Hope this helped.  What worked for you?
Thanks a lot!


How to remove gaps between candles

First, amazing, very good job already !
Are there some options or solutions to remove gaps when we display daily candles ?

Thanks!
Yeah, I'm fully aware of this problem, but so far there is no simple solution. I need to rethink the grid calculation algo (where things can become complicated due to different time warps). As you can see, now the library uses a rather dumb method (t % INTERVAL === 0):
https://github.com/C451/trading-vue-js/blob/master/src/components/js/grid_maker.js#L160
I hope to fix this in the foreseeable future.

Basically, the same:  https://github.com/C451/trading-vue-js/issues/17#issuecomment-487184922

suggestion: use lable replace timestamp as x axis


CTA link in thank you email broken if you disable default tier

From a user:

The "Thank you for your donation" email includes a call to action with a link to https://opencollective.com/collective/donate, but this link does not work because we have disabled the custom tier. Can we change that link to only go directly to our main page instead?

I think a better solution might be to link to /contribute but the main page link is also fine.

The part where this appears is:

Help us raise more money!
Share this URL: https://opencollective.com/babel/donate

I personally have a preference for linking the profile page, I think it's the best one to share because it has all the context (description, updates, contributors, etc.) thus people arriving there should be more tempted to contribute.


error 13 in install.sh immediately closes wsl2 window

I've finally gotten everything setup successfully until esp-matter, and as soon as I type in ". ./install.sh", my wsl2 window is closed by an error that can't be seen by the naked eye unless you run the file with "sh install.sh", then you can see there's error 13, source cannot be found. At least that's the error I got after going back in and trying without all of the exports. This is extremely frustrating because it closes all of my virtual environments with it. Now I have to go back in and re-export.sh matter and esp-idf just to try something else, at which point it will undoubtedly close my window again. I've searched the .sh files for an exit command and I can't find one. Why is it closing my window on a small error like this? What can we do to prevent such anti-user behavior?

Install.sh script is supposed to be executed and not sourced. I see you have source it -> . ./install.sh.

@fkkjohn Please close the issue if this helps

Closing. Feel free to reopen in case of any issue


Add "scripts" field to package.json

This patch aims to fix #19267 by adding "scripts" field to package.json with watch, build and build-legacy commands/scripts

Duplicate of #8415; please note that as mentioned in e.g. https://github.com/mozilla/pdf.js/pull/8415#issuecomment-302249805 this would increase maintenance burden for a feature that's not really needed within the project itself.


Update tsconfig.json & alias.js with StyledComponents path.

Is your proposal related to a problem?

Currently to import styledComponents in other components we are using relative path imports which is annoying for common reusable styled components.
for example we are doing import { Badge } from "../../../styledComponents" in the other components by passing relative path to the styledComponents folder.

Describe the solution you'd like
import { Badge } from "StyledComponents"
Please change the styledComponents folder name to StyledComponents . Update tsconfig.js paths with StyledComponents
similar to:
"paths": {
      // previous code
      "StyledComponents": ["./app/javascript/src/StyledComponents"],
    }

Update alias.js with StyledComponents path similar to
module.exports = {
resolve: {
  alias: {
    // previous code
    StyledComponents: "src/StyledComponents",
  }
}
};

Update the StyledComponents import path across the app like import { Badge } from "StyledComponents" instead of relative path.

please assign me this issue, I would like to do this.

Please assign me this issue.

@ankitdas09 Assigned this task to you. Let me know if you need any help on this.

ERROR: ** [Honeybadger] Unable to send error report: API key is missing. id=d67a350e-d109-47b7-98b3-cf0730149c70 level=3 pid=67425
Getting this error when starting the app with foreman start -f Procfile.dev

@ankitdas09 It's fine. The issue was because of honeybadger connection.

@ankitdas09 Let me know if you've dropped this. I'd like to give a try.

@aaj013 yeah go ahead

Made the mistake of sending PR without assignment. Assign me if above PR can be considered.


DBZ-3577: Use executed gtid as incremental snapshot watermarks

The initial draft of using executed GTID set as low/high watermarks in the incremental snapshot in MySQL connector.

Thanks a lot, @kgalieva!
@jpechane, could you take a first look?

@kgalieva Hi, thanks a lot for the PR. I'd keep the last word to @gunnarmorling but I personally would prefer slightly different code architecture.
I'd like to see the MySqlIncrementalSnapshotChangeEventSource be renamed to ReadOnlyMySqlIncrementalSnapshotChangeEventSource. It will not inherit from SignalBasedIncrementalSnapshotChangeEventSource but there will be a common abstract parent class that will define the shared logic and SignalBasedIncrementalSnapshotChangeEventSource will contain the signal based logic and the new MySQL would contain the GTID based logic.

Hey @jpechane, @kgalieva, where do we stand with this one? Is there a way for testing this new implementation?

I'm going to test it on my side, I'll post an update as soon as it's done

Tested this PR

Thanks a lot, @kgalieva! Hey @jpechane, wanna take another look?

@kgalieva Thanks a lot, it is definitely exactly in the way I was looking for! I'll provide more detail review later. Just top of my head - please convert IncrementalSnapshotContext to interface too with two implementations - signal and mysqlreadonly.

Thanks, @jpechane! I updated this PR and created a follow-up change for the Kafka topic-based signals in case the connection is configured to read-only https://github.com/kgalieva/debezium/pull/1

@kgalieva I think we are almost there! Code is fine from my PoV. Please complete the following clenup tasks before the final merge

[ ] Please rename MySqlReadOnlyIncrementalSnapshotChangeEventSource to MySqlReadOnlyIncrementalSnapshotChangeEventSource to highlight it is mysql only
[ ]  Also please add a comprehensive JavaDoc to this class describing the process how it works.
For signal based approach we have DDD-3 but there is nothing like that fro GTID-based approach.
[ ] Please extend MySQL documentation with the new config option and also the Incremental Snapshot section
[ ] Please check the Vitess connector. Is it failing always or only when this chnge was introduced?
[ ] Create ReadOnlyIncrementalSnapshotIT from IncrementalSnapshotIT to make the new approach tested as the part of the CI. Note the test can be executed only if run against GTID-enabled database.

Thanks a lot for your effort!

@kgalieva It seems that io.debezium.connector.mysql.StreamingSourceIT#shouldFailOnSchemaInconsistency is failing. Could you please take a look at it?

@kgalieva Please check https://github.com/debezium/debezium/pull/2430/checks?check_run_id=3178285429
It seems to me that a single run of ReadOnlyIncrementalSnapshotIT takes 7! minutes so the build runtime is almost doubled. Do you know why is that?

Good catch @jpechane, thank you! The read-only tests were long-running when GTID mode is OFF because each of them was waiting 3 times for 15 seconds to poll the records
https://github.com/debezium/debezium/blob/10ab20a157b4b0ddedfd1306c385be7a64af7d81/debezium-embedded/src/test/java/io/debezium/embedded/AbstractConnectorTest.java#L405
I added a separate test for the expected failure when GTID_MODE is OFF and skipped the rest of the tests.

@kgalieva And it is merged, thanks a lot!


replaced wrong long dashes in powershell+typo

the original dash is unsupported by powershell and yielding errors when copy/pasted
also the second sample started with a minus, which is wrong as well

@fabsenet : Thanks for your contribution! The author, @yzheng-msft, has been notified to review your proposed change.


feat: Install test env

The test env can

do unit tests
do e2e tests which use fake web-ext apis

related issue: #28

Task to setup e2e test env is heavy so that I will create new issue for the task.


Investigate useProposalCountdown

This needs some more research first. @Da-Colon please update this comment when you learn more.

@adamgall any one liner you can give me on what 'useProposalCountdown' gives opportunity for?

Nope, but hopefully @Da-Colon can! I believe I opened this up at his request, or during a conversation with him, or something. I don't recall the context of why this issue was opened.

@adamgall any one liner you can give me on what 'useProposalCountdown' gives opportunity for?

@tomstuart123 Nope, but hopefully @Da-Colon can! I believe I opened this up at his request, or during a conversation with him, or something. I don't recall the context of why this issue was opened.

This is safe to close. It was more of a reminder to continue looking into useProposalCountdown hook to ensure that its dispatch was being used appropriately. I believe for now we have this working correctly and this issue can be closed


The swupdate_handler_v2 README create custom content handler link is dead/404

The README has a dead link for Create custom content handler.
https://github.com/Azure/iot-hub-device-update/tree/main/src/extensions/step_handlers/swupdate_handler_v2
See How To Implement A Custom Content Handler Extension for more information.
Not sure where the new link is but that one gives 404.  We did find this link though for Custom Content Handler EXTENSION. https://github.com/Azure/iot-hub-device-update/blob/main/docs/agent-reference/how-to-implement-custom-update-handler.md#how-to-implement-a-custom-content-handler-extension
But that page still has references to the v1 update handler vs v2..  should that page be updated too?
New:
Registering SWUpdate Handler extension
To enable SWUpdate on the device, the handler must be registered to support 'microsoft/swupdate:2'.
Note that this version of SWUpdate Handler is different from the previous version published as part of the 2022 Public Preview Refresh release. The new handler is not backward compatible with previous versions. Hence, we recommend using a new update-type ('microsoft/swupdate:2')
Current page shows 'microsoft/swupdate:1'
Device Update has previously supported four reference Device Update Agent binaries, each designed to work with only 1 Update Type:

- An agent that supports 'microsoft/swupdate:1' update type
- An agent that supports 'microsoft/apt:1' update type
- A simulator agent that supports 'microsoft/swupdate:1' update type
- A simulator agent that supports 'microsoft/apt:1' update type

Doc is updated.


Fix crash in zset store getkeys, fix zdiff/bzmpop range, add tests

These following cases will crash the server, the reason is that
the index of numkeys is wrong:
command getkeys zdiffstore dst 2 src1 src2
command getkeys zinterstore dst 2 src1 src2
command getkeys zunionstore dst 2 src1 src2

These following getkeys output is wrong:
> command getkeys zdiff 2 key1 key2
1) "key1"
2) "key2"
3) (nil)

> command getkeys bzmpop 0 2 key1 key2
1) "key1"

These are ok:
command getkeys zinter 2 key1 key2
command getkeys zunion 2 key1 key2
command getkeys sintercard 2 key1 key2
command getkeys zintercard 2 key1 key2
command getkeys zmpop 2 key1 key2
command getkeys lmpop 2 key1 key2
command getkeys blmpop 0 2 key1 key2

However, at present, there is still a problem with our zset store.
We do not support returning dst key, but let's do it later...
<IP_ADDRESS>:6379> command getkeys zinterstore dst 2 src1 src2
1) "dst"
2) "src1"
3) "src2"

<IP_ADDRESS>:6666> command getkeys zinterstore dst 2 src1 src2
1) "src1"
2) "src2"

I think we need to inform developers that in versions of kvrocks before 2.8, some commands may cause server crashes.
Can we add this to the release log and supported-commands desc?

@jihuayu Thanks for your warm reminder. Yes we should mention this in our next release note.


Set up Phenotype job pipeline (report page, list pages, pipeline updates)

Note: Marking as draft until #421 is merged.
--
Set up basic Phenotype report job pipeline: submission flow & backend report handling.
Highlights:

Fill out endpoint functions

Report lists (/my-results and /all-results)
Report page (only graph present for now is two-trait scatterplot)
Submission flow pages (choose one/two, trait selectors)
Submit endpoint (/submit)

Fetch report input/output data

Input is the trait file object(s). Maybe this should come from the SQL table?
Output is the trait values from the SQL table(!)

Generalize submission flow for one or two traits

If trait_2 is None, handles as a single-trait analysis job

Hi @vlagrassa  #421 has been merged. Cheers.


[DOCFIX] Update docs/cn/Running-Alluxio-On-Kubernetes.md

Update docs/cn/Running-Alluxio-On-Kubernetes.md

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/18541/
Test PASSed.


[v6.0.0] Expose the helpers module so it can be used for custom decoders in user project

https://github.com/thoth-org/Thoth.Json/commit/74a85519732719d13b68d034544c7a65aae91189
The [<Inject>] decorator (from this commit https://github.com/thoth-org/Thoth.Json/commit/94838b6e60b7b3c457b4f5ca7e44110ba1ce8ec3) is a Fable/front-end specific thing?

Hello @weslenng you are right, I totally forgot to keep Thoth.Json.Net in sync with Thoth.Json
Yes, the [<Inject>] attributes are specific to Fable only.


Update config-types.ts

Summary of Changes
This PR makes mailClientFeatures optional on AppCustomConfig. This was an oversight from a previous commit -- all options on the custom config should be optional.
Tests
N/A
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.

[x] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"

In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

[x] PR includes a summary of changes, including screenshots of any UI changes.
[x] PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
[x] In case of new functionality, my PR adds documentation that describes how to use it.

All the public python functions and the classes in the PR contain docstrings that explain what it does

[x] PR passes all tests documented in the developer guide

Codecov Report

Merging #314 into master will increase coverage by 4.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
+ Coverage    71.6%   76.49%   +4.89%
==========================================
  Files         143       26     -117
  Lines        3701     1187    -2514
  Branches      462      109     -353
==========================================
- Hits         2650      908    -1742
+ Misses       1018      250     -768
+ Partials       33       29       -4

Impacted Files
Coverage Δ

...ication/static/js/components/common/Tabs/index.tsx

...ndsen_application/static/js/ducks/search/api/v0.ts

...ion/static/js/components/PreferencesPage/index.tsx

...mponents/PreferencesPage/PreferenceGroup/index.tsx

...ication/static/js/components/common/Flag/index.tsx

...ts/common/ResourceListItem/TableListItem/index.tsx

...sen_application/static/js/ducks/allTags/reducer.ts

...tatic/js/components/common/ScrollTracker/index.tsx

...pplication/static/js/ducks/popularTables/api/v0.ts

...static/js/components/common/ResourceList/index.tsx

... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15d9c3c...ad0e230. Read the comment docs.

? means optional?

Yep. In TypeScript interface definitions variableName?: type is similar to having variable_name: Optional[type] in python/mypy.


Dashboards sent by email have wrong naming convention

Description
Dashboards sent by email have wrong naming convention
Steps to reproduce

Open any dashboard
Send it by email.
Check the screenshot name in the email.

Actual behavior
1c1cfbb2-a565-4bbd-bc1f-17ef6e0f449710358673697302489308.png
Expected behavior (if known)
Expected name: Project Weekly Regression dashboard - 06_19_2020.pn
Additional context
It is a regression issue. Around a month ago everything was ok.

Verified in ui: <IP_ADDRESS>-SNAPSHOT server: 1.8.0.RC1.


adjust minimum julia version dependency to 0.4.1

since CSV.jl depends on Julia 0.4.1
ref https://github.com/JuliaLang/METADATA.jl/pull/6338

You'll want to remove the upper bounds here if you update the package to work with newer versions of CSV.jl.


Min requirements

After purchasing on Apple App Store (support FTW), went to install on our family (2007) mac mini for housemate's kid, and it said the gfx support was missing and couldn't install it. Would be good if minimum requirements other than Java 7 were mentioned on any of the sites, or on the App Store itself. Would consider updating computer, but I'm not sure what the actual requirements are - is it that it needs to have more than onboard graphics? Tried to download separately to see if that would actually install anyway, but that failed too - wouldn't open.

I believe the requirement is OS X 10.6.8 or above and OpenGL 2 or above. I think the mac mini may only support OpenGL 1. To see the specific error message, try running the JAR version from the terminal. I'll adjust the description the next time I update the app store version.

Thank you.
And also...


support of skipping notebook tests (testing script)

Is your feature request related to a problem? Please describe.
would be great to have an option to skip some of the notebook tests in runner.sh

perhaps change the --file argument to be a regex match?


[FEATURE] a named function for broadcasting a value

The syntax we are using eve::wide<T>(v) can be confusing in certain scenarious.
Like
eve::wide<T> x(ptr);
eve::wide<T> x(*ptr);

mean different things.
I would like a function, that a person not familiar with eve can easily understand

auto x   = widen(4);
auto x8 = widen(4, lane<8>);

What about this name ? We WIDEN the scalar and get a wide

I think that is wqy too cute. We use the word splat already. Broadcast is also a good one

we use splat as a decorator. We can make the decorator splatted ? and reuse splat as a function ?

won't broadcast conflict with the shuffle or are we OK overlaoding broadcast for both ?

We can do either or I think? I don't know which is better.

People probably knows broadcast already

Broadcast it is then

a shuffle is actually called broadcast_lane
https://jfalcou.github.io/eve/group__core__named__shuffles_ga511d8b336d54331461e09e61373e37de.html#ga511d8b336d54331461e09e61373e37de

OK so we want to overlaod this one
https://jfalcou.github.io/eve/group__core__simd_gaa8fb67b18a0c3046d9281ed21953444d.html#gaa8fb67b18a0c3046d9281ed21953444d


CORS support for standalone running instance

Context:

A low prior change request: To add direct CORS support for built-in servers for standalone run

Use Case:

Local dev run with cargo run -p htsget-http-actix to use htsget-rs as backend in Pipeline development and/or Portal integration with IGV.js

Workaround:

Use Nginx/Haproxy to handle CORS then reverse proxy to htsget-rs servers

Need Changes:
I guess, this should be quick -- 2 parts in there:

actix_cors crate for actix-web for Ticket server
activate tower_http::cors feature in tower/axum for built-in storage streaming server

Closed via #119

Closed via #119.


Move scrollbar position to top when user types in room filter

This is nicer behaviour.

Works in all browsers?

Tested and works on Windows in IE 9, Firefox 9+10, Chrome 16 and Safari 5.


sql: rearchitecture ALTER TABLE RENAME, add support for renaming constraints

PR: https://github.com/cockroachdb/cockroach/pull/35091
From release notes:

CockroachDB now supports ALTER TABLE ... RENAME CONSTRAINT. Only indexes that are not depended on by views can be renamed. [#35091][#35091] {% comment %}doc{% endcomment %}
The RENAME COLUMN command can now be used alongside other table commands in a single ALTER TABLE statement. This makes it possible to, for example, atomically add a computed column based on an existing column, and rename the columns so that the computed column "replaces" the original column. [#35091][#35091] {% comment %}doc{% endcomment %}

@rmloveland, I can take this one.


[🐛] Error when using Username update feature

:bug: Bug report
Description

Issue was already reported and closed by the reporter in https://github.com/bkimminich/juice-shop/issues/1407
However I can consistently reproduce this
Is this a regression?

Yes, the previous version in which this bug was not present was: 10.0.0
It works on 10.0.0 and fails to work on 10.1.0 and upwards from what I can see.
I've restarted the docker image numerous times and retested to see if it was something on my end.
I've even run two simultaneously as a side by side comparison.
10.1.0 fails.
10.0.0 works.
Docker command:
Terminal 1:
docker run --rm -e "NODE_ENV=unsafe" -p 4000:3000 bkimminich/juice-shop:v10.1.0
Terminal 2:
docker run --rm -e "NODE_ENV=unsafe" -p 3000:3000 bkimminich/juice-shop:v10.0.0
TypeError: Cannot read property 'includes' of undefined
    at /juice-shop/routes/updateUserProfile.js:18:83
    at Object.exports.solveIf (/juice-shop/lib/utils.js:102:36)
    at /juice-shop/routes/updateUserProfile.js:18:15
    at tryCatcher (/juice-shop/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/juice-shop/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/juice-shop/node_modules/bluebird/js/release/promise.js:604:18)
    at Promise._settlePromise0 (/juice-shop/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/juice-shop/node_modules/bluebird/js/release/promise.js:729:18)
    at _drainQueueStep (/juice-shop/node_modules/bluebird/js/release/async.js:93:12)
    at _drainQueue (/juice-shop/node_modules/bluebird/js/release/async.js:86:9)
    at Async._drainQueues (/juice-shop/node_modules/bluebird/js/release/async.js:102:5)
    at Immediate.Async.drainQueues [as _onImmediate] (/juice-shop/node_modules/bluebird/js/release/async.js:15:14)
    at processImmediate (internal/timers.js:456:21)
:microscope: Minimal Reproduction

Authenticate with a valid user/password
Open the "User profile" page
Type a username and click on "Set username"
No error is displayed, but the username is not set

:fire: Exception or Error

TypeError: Cannot read property 'includes' of undefined
    at /juice-shop/routes/updateUserProfile.js:18:83
    at Object.exports.solveIf (/juice-shop/lib/utils.js:102:36)
    at /juice-shop/routes/updateUserProfile.js:18:15
    at tryCatcher (/juice-shop/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/juice-shop/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/juice-shop/node_modules/bluebird/js/release/promise.js:604:18)
    at Promise._settlePromise0 (/juice-shop/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/juice-shop/node_modules/bluebird/js/release/promise.js:729:18)
    at _drainQueueStep (/juice-shop/node_modules/bluebird/js/release/async.js:93:12)
    at _drainQueue (/juice-shop/node_modules/bluebird/js/release/async.js:86:9)
    at Async._drainQueues (/juice-shop/node_modules/bluebird/js/release/async.js:102:5)
    at Immediate.Async.drainQueues [as _onImmediate] (/juice-shop/node_modules/bluebird/js/release/async.js:15:14)
    at processImmediate (internal/timers.js:456:21)

:deciduous_tree: Your Environment
Docker

Additional Information

On http://demo.owasp-juice.shop/profile (v11.1.1) it works fine to save a username.

The error can only come from this check req.headers.origin.includes('://htmledit.squarefree.com'), and it means that in your case there is no origin header in the request. As this might happen during request tampering or from unknown other reasons, I'll add a null check in front of that.


I2C/BCS SLAVE peripheral return status (BSC control register) getting corrupted

I don't understand.  Is there a problem you are experiencing with the library?

Hi,
I was using the RPi BSC slave as an i2c slave and left it run for over a day and a half or so.
I am periodically disabling the peripheral by writing 0 to the I2C bit in the CR register. I’m doing this because i need the i2c slave to NACK a read request from my i2c master and I’m doing so using the control flags in my bsc_xfer_t instance.
After some period, the peripheral wasn’t ACK-ing the i2c master’s read request even when it was supposed to do so. The i2c bit in my bsc_xfer_t instance was effectively set.
Still in this situation, I mmaped the peripheral’s registers using some other code and noticed that the i2c bit there was cleared.
I’m very sorry to have posted this issue and to have bothered you with this. But I’ve changed this in my local fork and didn’t come across this issue any longer. Does this makes sense to you?
Best regards,
Frederic

On 19 Dec 2020, at 16:00, Guy McSwain<EMAIL_ADDRESS>wrote:

I don't understand. Is there a problem you are experiencing with the library?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

No I'm not bothered, I just needed more information so thanks for providing it.
I think I follow what your are doing with the peripheral but sharing a code snippet would be very helpful.
I'm scratching my head over how mapping to volatile resolves the issue.  If there was some kind of coherency issue due to the way the peripherals are mapped then many parts of the library would be falling over.

I think I found your code here?
https://github.com/smeerpate/SACI2cIotSlave/blob/main/SACRPiIotSlave.c

Maybe I'm missing it but I don't see where in your code all the flags are initialized.

Hi Guy,
It was my understanding that this was done in the getControlBits function in SACRPiIotSlave.c...

I think I found your code here?
https://github.com/smeerpate/SACI2cIotSlave/blob/main/SACRPiIotSlave.c
Correct.

Yes, but I only see a subset of the bits getting set.  Also, not sure if they are cleared when a 0 gets or'ed for that position.

To verify, this same code failed before you edited the single line in pigpio and is now working?

Hi Guy,
It seems so on my UsingGpioLib-branch.
I will verify that to be 100% sure and I will get back to you on this later this week.
Thanks for your help!
Frederic

Hi Guy,
I have checked this again, and as you suspected, the volatile statement doesn’t change a thing. I still don’t understand why I’m reading two different values in the control register.
My program here outputs this:

This is what I read back when I’m using another program just after I read back 0x305 from CR using mmap:

I finally moved over to using the serial port with termios instead because I ran out of time...
Best regards,
Frederic

Hi Frederic,
I'm going to write a test that will try to simulate the conditions in your environment.  To that end I have a few questions:

Which RPi model are you using?
Is the I2C master external and if so what is it?
OS and pigpio versions?

Thanks,
Guy

Hi Frederic,
I'm going to write a test that will try to simulate the conditions in your environment.  To that end I have a few questions:

Which RPi model are you using?
Is the I2C master external and if so what is it?
OS and pigpio versions?

Thanks,
Guy

Hi Guy,

cat /proc/device-tree/model:

Raspberry Pi 3 Model B Rev 1.2

External I2c master:

Arduino micro (P/N A000053)

3a. cat /etc/os-release:

PRETTY_NAME="Raspbian GNU/Linux 9 (stretch)"
NAME="Raspbian` GNU/Linux"
VERSION_ID="9"
VERSION="9 (stretch)"
ID=raspbian
ID_LIKE=debian

3b. pigpio version:

pigpio version 78

Does all above info makes sense?
I admire your commitment!
Best regards,
Frederic

Hi Guy,

cat /proc/device-tree/model:

Raspberry Pi 3 Model B Rev 1.2

External I2c master:

Arduino micro (P/N A000053)

3a. cat /etc/os-release:

PRETTY_NAME="Raspbian GNU/Linux 9 (stretch)"
NAME="Raspbian` GNU/Linux"
VERSION_ID="9"
VERSION="9 (stretch)"
ID=raspbian
ID_LIKE=debian

3b. pigpio version:

pigpio version 78

Does all above info makes sense?
I admire your commitment!
Best regards,
Frederic


Talkback focuses on the last focused element when the dialog/bottom sheet is reopened

Internal: b/150749148
Somehow the state of the a11y is preserved when the bottom sheet/dialog is closed. This is causing the screen reader to not read title and description the second time the same dialog is opened.
        showModalBottomSheet<dynamic>(
            context: context,
            builder: (context) => Column(children: [
              Text("test bottom sheet", style: TextStyle(fontSize: 40)),
              SizedBox(height: 32),
              FlatButton(
                onPressed: () => Navigator.of(context).pop(),
                child: const Text('Deny'),
              ),
              FlatButton(
                onPressed: () => Navigator.of(context).pop(),
                child: Text('Allow'),
              ),
            ])

Try focusing on "Deny" and double tap to press it. Open the dialog again and observe that the focus is still on "Deny". It should instead be reset so that the reader can read the title and dialog content again.

Verified the repro case. Investigating now and will update when I have more info.

Little more info. Here is the repro app I am using:
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData.from(colorScheme: ColorScheme.light()),
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {

  void _showModal() {
    showModalBottomSheet<void>(
      context: context,
      builder: (context) => Column(children: [
        Text("test bottom sheet", style: TextStyle(fontSize: 40)),
        SizedBox(height: 32),
        FlatButton(
          onPressed: () => Navigator.of(context).pop(),
          child: const Text('Deny'),
        ),
        FlatButton(
          onPressed: () => Navigator.of(context).pop(),
          child: Text('Allow'),
        ),
      ]),
    );
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: const Text('A11y Bottom Modal')),
      body: Center(
        child: FlatButton(
          child: const Text('Show Modal'),
          onPressed: _showModal,
        ),
      ),
    );
  }
}

When I run this on a Pixel 3, here are the semantic trees for the initial and second runs:
First instance:
I/flutter (15577): SemanticsNode#0
I/flutter (15577):  │ Rect.fromLTRB(0.0, 0.0, 1080.0, 2028.0)
I/flutter (15577):  │
I/flutter (15577):  └─SemanticsNode#1
I/flutter (15577):    │ Rect.fromLTRB(0.0, 0.0, 392.7, 737.5) scaled by 2.8x
I/flutter (15577):    │ textDirection: ltr
I/flutter (15577):    │
I/flutter (15577):    └─SemanticsNode#6
I/flutter (15577):      │ Rect.fromLTRB(0.0, 0.0, 392.7, 737.5)
I/flutter (15577):      │ flags: scopesRoute, namesRoute
I/flutter (15577):      │ label: "Dialog"
I/flutter (15577):      │ textDirection: ltr
I/flutter (15577):      │
I/flutter (15577):      ├─SemanticsNode#7
I/flutter (15577):      │   Rect.fromLTRB(38.9, 322.6, 353.9, 369.6)
I/flutter (15577):      │   label: "test bottom sheet"
I/flutter (15577):      │   textDirection: ltr
I/flutter (15577):      │
I/flutter (15577):      ├─SemanticsNode#8
I/flutter (15577):      │   Rect.fromLTRB(152.4, 401.6, 240.4, 449.6)
I/flutter (15577):      │   actions: tap
I/flutter (15577):      │   flags: isButton, hasEnabledState, isEnabled, isFocusable
I/flutter (15577):      │   label: "Deny"
I/flutter (15577):      │   textDirection: ltr
I/flutter (15577):      │
I/flutter (15577):      └─SemanticsNode#9
I/flutter (15577):          Rect.fromLTRB(152.4, 449.6, 240.4, 497.6)
I/flutter (15577):          actions: tap
I/flutter (15577):          flags: isButton, hasEnabledState, isEnabled, isFocusable
I/flutter (15577):          label: "Allow"
I/flutter (15577):          textDirection: ltr

Second instance:
I/flutter (15577): SemanticsNode#0
I/flutter (15577):  │ Rect.fromLTRB(0.0, 0.0, 1080.0, 2028.0)
I/flutter (15577):  │
I/flutter (15577):  └─SemanticsNode#1
I/flutter (15577):    │ Rect.fromLTRB(0.0, 0.0, 392.7, 737.5) scaled by 2.8x
I/flutter (15577):    │ textDirection: ltr
I/flutter (15577):    │
I/flutter (15577):    └─SemanticsNode#10
I/flutter (15577):      │ Rect.fromLTRB(0.0, 0.0, 392.7, 737.5)
I/flutter (15577):      │ flags: scopesRoute, namesRoute
I/flutter (15577):      │ label: "Dialog"
I/flutter (15577):      │ textDirection: ltr
I/flutter (15577):      │
I/flutter (15577):      ├─SemanticsNode#11
I/flutter (15577):      │   Rect.fromLTRB(38.9, 322.6, 353.9, 369.6)
I/flutter (15577):      │   label: "test bottom sheet"
I/flutter (15577):      │   textDirection: ltr
I/flutter (15577):      │
I/flutter (15577):      ├─SemanticsNode#12
I/flutter (15577):      │   Rect.fromLTRB(152.4, 401.6, 240.4, 449.6)
I/flutter (15577):      │   actions: tap
I/flutter (15577):      │   flags: isButton, hasEnabledState, isEnabled, isFocusable
I/flutter (15577):      │   label: "Deny"
I/flutter (15577):      │   textDirection: ltr
I/flutter (15577):      │
I/flutter (15577):      └─SemanticsNode#13
I/flutter (15577):          Rect.fromLTRB(152.4, 449.6, 240.4, 497.6)
I/flutter (15577):          actions: tap
I/flutter (15577):          flags: isButton, hasEnabledState, isEnabled, isFocusable
I/flutter (15577):          label: "Allow"
I/flutter (15577):          textDirection: ltr

Which are structurally identical with just different node ids for the dialog and its subtree. Not sure what would be causing the issue given these trees. Perhaps there is something in the engine or underlying platform API that is caching something and reusing it when it sees the new instance.

I spent more time looking at the a11y bridge in the engine, but I didn't see anything that looked like it would be causing this issue. Unfortunately, I was having problems building the engine, so I wasn't able to debug further. Handing this over to Chris to see if he can take this any further on the engine side.

b/150749148

any update here?

@cbracken are you currently working on this?

This seems similar to an issue that @gspencergoog looked at a while back, and myself a while before that.
I don't remember if we ever found a solution. There was a previous focus case that was caused by a timing issue - we sent the first semantics before the child widgets were visible and that caused the announcement to be blank. The fix there was the force the visibility to not hide semantics for that particular widget.
But in general, I don't think we have any idea what causes this.

FWIW in this specific case I cannot reproduce the issue on a Pixel 4

@gaaclarke can you see if you can repro? We should ask for details in b/150749148 if needed. Otherwise let's close this.

any update on repro / closing this issue?

@pcsosinski, slipped.  Let me wrap up what I'm working on and I'll take a peek this afternoon

I ran Daren's code with the latest version of Flutter on my Android device and was able to reproduce the issue.  The second time the dialog is presented it does not say "test bottom sheet", it talks about the "Deny" button.
To be honest this is the first time I'm using Talkbalk and much more looks broken than that.  Talkback often says the name of the app and the green rectangle around objects isn't rendering.
doctor:
aaclarke-macbookpro2:issue_55917 aaclarke$ flutter doctor -v
[✓] Flutter (Channel master, 1.20.0-1.0.pre.41, on Mac OS X 10.15.4 19E287, locale en-US)
    • Flutter version 1.20.0-1.0.pre.41 at /Users/aaclarke/dev/flutter
    • Framework revision d64884dedf (65 minutes ago), 2020-06-12 12:50:03 -0700
    • Engine revision 965fbbed17
    • Dart version 2.9.0 (build 2.9.0-14.0.dev 2b917f5b6a)

android version: 7.0
device: Asus Zenfone AR

conclusions
Someone is caching state that causes Talkback to avoid saying "test bottom sheet".  If you run through the reproduction steps except pressing the "Allow" instead of "Deny" button, when the sheet is brought back up, "Allow" is highlighted, not "Deny"
It is my belief that it is the operating system's accessibility library that is caching that state.  That would explain why some people could not reproduce the problem.  There doesn't seem to be any fix for Flutter. For evidence please see my debugging log.   It would be nice if someone with more Talkback experience could verify it.
debugging log
I did a bit of debugging and found that in the pathological case AccessibilityBridge.findFocus is returning android.view.accessibility.AccessibilityNodeInfo@79dc; boundsInParent: Rect(566, 1397 - 874, 1565); boundsInScreen: Rect(566, 1397 - 874, 1565); packageName: com.example.issue_55917; className: android.widget.Button; text: null; error: null; maxTextLength: -1; contentDescription: Deny; viewIdResName: ; checkable: false; checked: false; focusable: true; focused: false; selected: false; clickable: true; longClickable: false; contextClickable: false; enabled: true; password: false; scrollable: false; actions: [AccessibilityAction: ACTION_CLICK - null, AccessibilityAction: ACTION_CLEAR_ACCESSIBILITY_FOCUS - null]
That result actually comes from this line of code so there might be some dirty state in the accessibilityFocusedSemanticsNode instance variable.
That variable is only ever set to a value in the ACTION_ACCESSIBILITY_FOCUS action, but there are numerous places where it is cleared out.  That might point to a missed opportunity to clear it out.
I verified that ACTION_CLEAR_ACCESSIBILITY_FOCUS is getting issued when the sheet is dismissed.  When it is brought up again a ACTION_ACCESSIBILITY_FOCUS is issued, but the handler is finding the "Deny" button, not the sheet title like we expected.  That handler bases its result on flutterSemanticsTree.get(virtualViewId), so that seems to be the source of the incorrect data.
The first time I bring up the sheet, the virtualViewId passed into AccessibilityBridge.performAction for the focus action is 7 which corresponds to the sheet title according to flutterSemanticsTree.  The second time the sheet is focused virtualViewId is 12 which corresponds to the "Deny" button.  The virtualViewId comes directly from Android's accessibility API via AccessibilityNodeProvider.performAction, so it appears that the OS is caching the state in question.

That all sounds plausible. Do you have any insights how Android learns of the existence of a node with the ID 12? If I understand it correctly, the first time the sheet comes up, no node with that ID exists, so it can't exactly cache the node id. So, somehow it must learn about the new id when the sheet comes up again (otherwise it couldn't/wouldn't give us that ID in  AccessibilityBridge.performAction). Does TalkBack perform hit testing to figure out what new node is in the location that previously had the focus? Does it walk the entire hierarchy again until it finds a node with the same rect?
To investigate this further, here is where I would look:

When the sheet appears, we are presumably sending an TYPE_WINDOW_STATE_CHANGED event. Is there anything we can set on that event to indicate that this is something completely new and Android shouldn't use any cached information? (As an experiment: does the problem go away when the name of the route changes between invocations? The name is set here: https://github.com/flutter/engine/blob/f7d241fd8a889fadf8ab3f9d57918be3d986b4be/shell/platform/android/io/flutter/view/AccessibilityBridge.java#L1551)
Is there anything interesting in TalkBack's log when the screen is brought up the second time? With verbose logging turned on, TalkBack is usually pretty verbose in telling you what and why its doing what its doing. Any indication in there why it wants to focus on node 12?
Often it has also been helpful to compare the log Flutter produces when performing an action with what the log looks like when the same action is performed in a native app. In doing so, we often found that we were not sending events that TalkBack expected to function properly.

@goderbauer Here is the log when the sheet is brought back:
06-17 18:25:54.417 12190 12190 D Pipeline: execute()
feedback=Feedback{eventId=type:EVENT_TYPE_ACCESSIBILITY
subtype:TYPE_WINDOW_STATE_CHANGED time:3437226, sequence=[Part= focus=
action=FOCUS target=
android.support.v4.view.accessibility.AccessibilityNodeInfoCompat@79fe;
boundsInParent: Rect(566, 1565 - 874, 1733); boundsInScreen: Rect(566, 1565 -
874, 1733); packageName: com.example.issue_55917; className:
android.widget.Button; text: null; contentDescription: Allow; viewId: ;
checkable: false; checked: false; focusable: true; focused: false; selected:
false; clickable: true; longClickable: false; enabled: true; password: false;
scrollable: false; [ACTION_CLICK, ACTION_ACCESSIBILITY_FOCUS] focusActionInfo=
FocusActionInfo{ sourceAction=SCREEN_STATE_CHANGE
initialFocusType=RESTORED_LAST_FOCUS isForcedFeedbackAudioPlaybackActive
isForcedFeedbackMicrophoneActive }   ]}

The important part being RESTORED_LAST_FOCUS, so it is telling us that it is doing what I expected, it is caching the focus and restoring it.

Not only is it the operating system, and not Flutter, that is performing this behavior; it is explicitly doing this behavior.  It seems any attempt to make the operating system behave different wouldn't be in alignment with expectations of Talkback users.

If this is the wrong place to advocate for reopening this issue please tell me.
I also run into this issue in the context of an app I am developing. Based on the OS settings screen behaviour around dialogs (specifically the enable/disable talkback button in the settings screen and its alert dialog) keeping focus where it was last time is not desired behaviour. Finding some way to keep talkback and other screenreaders from caching the focus here would be a very good thing to have.

Is there a hack which will solve this issue, I am facing this issue in my app.


Add python types and checks with mypy

This PR adds typing and CI checks with mypy.
There is still places where cast is needed, that would be good to remove, but I'd keep this in another PR, maybe to tackle at the same time as #37.
closes #78

closing,  see #90


[Request] Make localStorage usage optional

Some site have guidelines that states that every cookie and localStorage item should be documented (due to GDPR compliancy etc), and in those cases it'd be nice if one could just opt out of localStorage use.

Option useLocalStorage is added.

Lightning fast! Thanks!


Fixed incorrect image relative linking.

P.S. You should probably add https://ddbullfrog.github.io/iCard-Resume to the url of the repo *)

Wow. Apparently it is related to #4 *)

Thanks for your fix.

@ddbullfrog Thank you for theme *)


Branch 6.x points to old version and misses commits between 6.4.5 and 6.8.0

Deployer version: N/A
Deployment OS: N/A

As noted in https://github.com/deployphp/deployer/issues/2345#issuecomment-767522584.

Eagerly waiting for that !

Eagerly waiting for that !

Done with reset branch 6.x to:
4e243a6 (HEAD -> 6.x, tag: v6.8.0, origin/6.x) Release v6.8.0


add document source for each group

add field docsource to support document contribution from community.
CI builder server will map the docsource to http path in this repo.

:shipit:


Fetching Next Page, Response Not JSON Results in: undefined method `fetch' for #String:0x007f98e1600028

Calling result.pages.next results in the following error when the response is not JSON:
/Users/skyes/.rvm/gems/ruby-2.3.0/gems/json_api_client-1.5.1/lib/json_api_client/parsers/parser.rb:61:in `handle_json_api': undefined method `fetch' for #<String:0x007f98e1600028> (NoMethodError)
	from /Users/skyes/.rvm/gems/ruby-2.3.0/gems/json_api_client-1.5.1/lib/json_api_client/parsers/parser.rb:11:in `block in parse'
	from /Users/skyes/.rvm/gems/ruby-2.3.0/gems/json_api_client-1.5.1/lib/json_api_client/parsers/parser.rb:8:in `tap'
	from /Users/skyes/.rvm/gems/ruby-2.3.0/gems/json_api_client-1.5.1/lib/json_api_client/parsers/parser.rb:8:in `parse'
	from /Users/skyes/.rvm/gems/ruby-2.3.0/gems/json_api_client-1.5.1/lib/json_api_client/query/requestor.rb:60:in `request'
	from /Users/skyes/.rvm/gems/ruby-2.3.0/gems/json_api_client-1.5.1/lib/json_api_client/query/requestor.rb:35:in `linked'
	from /Users/skyes/.rvm/gems/ruby-2.3.0/gems/json_api_client-1.5.1/lib/json_api_client/linking/top_level_links.rb:35:in `fetch_link'
	from /Users/skyes/.rvm/gems/ruby-2.3.0/gems/json_api_client-1.5.1/lib/json_api_client/paginating/paginator.rb:19:in `next'
	from json-api-client-test.rb:17:in `<main>'

Yes, sad that servers don't respect content types but nevertheless I would expect a different error from this instead of it treating the String has a Hash.

I'm seeing this same error and stacktrace (mostly) in version 1.5.2, though afaict I'm not calling next:
undefined method `fetch' for #<String:0x0000000b7cc828>

/gems/json_api_client-1.5.2/lib/json_api_client/parsers/parser.rb:59 in handle_json_api
/gems/json_api_client-1.5.2/lib/json_api_client/parsers/parser.rb:11 in block in parse
/gems/json_api_client-1.5.2/lib/json_api_client/parsers/parser.rb:8 in tap
/gems/json_api_client-1.5.2/lib/json_api_client/parsers/parser.rb:8 in parse
/gems/json_api_client-1.5.2/lib/json_api_client/query/requestor.rb:60 in request
/gems/json_api_client-1.5.2/lib/json_api_client/query/requestor.rb:27 in get
/gems/json_api_client-1.5.2/lib/json_api_client/query/builder.rb:100 in find
/gems/json_api_client-1.5.2/lib/json_api_client/query/builder.rb:88 in to_a
/gems/json_api_client-1.5.2/lib/json_api_client/query/builder.rb:104 in method_missing

Sorry, cannot remember.


save the RTT in non-0-RTT session tickets

Save the RTT in non-0RTT session tickets.
Fixes #3853 for go 1.21.

Thanks for all your work @tanghaowillow!


chore: Upgrade to DataFusion 44

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
DataFusion 44 is preparing for the next release. Let's start the upgrade process and document all changes we've needed to make to feed back to them as part of an upgrade guide.
Describe the solution you'd like
Keep a running branch with the upgrade differences and document in this issue what we've encountered as we go along. Ideally we will complete this evaluation before the datafusion release process ends so we can identify issues earlier.

The trait definition of ExecutionPlanProperties return type for output_ordering now is Option<&LexOrdering> instead of Option<&[PhysicalSortExpr]>. The recommendation is to use .into() to convert into the required output.
find_df_window_func has now been removed from the logical_expr crate. If users require this functionality they can perform equivalent searches by either creating a default session context, or calling all_default_aggregate_functions and all_default_window_functions, or by searching their existing session context using ctx.udaf, ctx.window_functions, ctx.aggregate_functions, and so on.
LogicalPlan::Prepare and LogicalPlan::Execute have been removed. We do not actively use these in datafusion-python and I didn't search further for figuring out migration strategy.
to_substrait_plan and from_substrait_plan no longer take a session context. Rather they expect a SubstraitPlanningState which is implemented by SessionState. One recommended migration is to call ctx.ctx.state() and use a borrow of the returned SessionState.
RuntimeConfig is now deprecated in favor of RuntimeEnvBuilder. The migration is fairly straightforward, except to create the RuntimeEnv you now call build().


[BUG] Max() can return wrong results when column consists of Nans

Describe the bug
Max() on a column with NaN values , with or without a grouping key which has NaNs generates wrong results on the GPU.
Steps/Code to reproduce bug
//GPU plugin on
val rdd = sc.parallelize(Seq(Float.NaN, 1.0, 2.0), 2)
val df = rdd.toDF("c0")
val res= df.agg(max("c0"))
res.collect
 res.explain

Output:
res1: Array[org.apache.spark.sql.Row] = Array([2.0])
== Physical Plan ==
*(2) GpuColumnarToRow false
+- GpuHashAggregate(keys=[], functions=[gpumax(c0#17)]), filters=List(None))
+- GpuCoalesceBatches TargetSize(2147483647)
+- GpuColumnarExchange gpusinglepartitioning(), true, [id=#75]
+- GpuHashAggregate(keys=[], functions=[partial_gpumax(c0#17)]), filters=List(None))
+- !GpuProject [value#14 AS c0#17]
+- GpuRowToColumnar TargetSize(2147483647)
+- *(1) SerializeFromObject [input[0, double, false] AS value#14]
+- Scan[obj#13]

//GPU Plugin off
 spark.conf.set("spark.rapids.sql.enabled", "false")
val res= df.agg(max("c0"))
scala> res.collect
 res.explain

Output:
res5: Array[org.apache.spark.sql.Row] = Array([NaN])

== Physical Plan ==
*(2) HashAggregate(keys=[], functions=[max(c0#17)])
+- Exchange SinglePartition, true, [id=#106]
+- *(1) HashAggregate(keys=[], functions=[partial_max(c0#17)])
+- *(1) Project [value#14 AS c0#17]
+- *(1) SerializeFromObject [input[0, double, false] AS value#14]
+- Scan[obj#13]

Expected behavior
CPU and GPU answers should match.
Additional context
https://github.com/rapidsai/cudf/issues/4753 is related on cudf side.

This has been fixed.


Create Math-Statistics package and add harmonic and geometric mean, and mode

Hi,
Would you be interested in having a few extra basic statistics measures added into Polymath?
Best,
Connor

Wondering whether this introduction of geometric and harmonic means should be an extension to the Collection class. Here I plead ignorance. Could an expert enlighten me.
My thinking is we introduce the idea of a Statistical Sample that is backed by a collection. Thoughts?

Wondering whether this introduction of geometric and harmonic means should be an extension to the Collection class. Here I plead ignorance. Could an expert enlighten me.
My thinking is we introduce the idea of a Statistical Sample that is backed by a collection. Thoughts?

I agree, it only makes sense if the collection contains a numeric type. When I was implementing these I took inspiration from the statistical methods already defined on collections that similarly only work if they contain numbers. I'm new to smalltalk so I don't know what's considered good style in this case.

I agree, it only makes sense if the collection contains a numeric type. When I was implementing these I took inspiration from the statistical methods already defined on collections that similarly only work if they contain numbers. I'm new to smalltalk so I don't know what's considered good style in this case.

@ctSkennerton hi there. Could you try to extract a Statistical Sample class as a refactor. I'd love to see its impact on the code

@hemalvarambhia Maybe I can sketch out what a StatisticalSample class would be to see if I understand correctly. I'm thinking there would have a number of class methods for the various operations that take a collection as an input parameter.
StatisticalSample class >>> harmonicMean: aCollection
StatisticalSample class >>> geometricMean: aCollection
StatisticalSample class >>> mode: aCollection

(This could then be further developed with other measures as needed)
What do you think?

@hemalvarambhia Maybe I can sketch out what a StatisticalSample class would be to see if I understand correctly. I'm thinking there would have a number of class methods for the various operations that take a collection as an input parameter.
StatisticalSample class >>> harmonicMean: aCollection
StatisticalSample class >>> geometricMean: aCollection
StatisticalSample class >>> mode: aCollection

(This could then be further developed with other measures as needed)
What do you think?

You've got the idea. My thinking is that the methods would be instance ones, with the collection being a state variable.

Ok, I've converted the code to use a new class PMStatisticalSample

Merge at your leisure

@hemalvarambhia I don't have permission to merge.

@ctSkennerton merged. Thank you for contributing. Looking forward to your next one. :)

@ctSkennerton love the documentation by the way. Very thorough!


Add pathfinder plugin

Pathfinder is similar to the built-in tile indicator plugin, but it computes and highlights the path the player's character will take to the hovered tile. It is mainly meant for Zalcano to help navigate the red symbols. For now it assumes there are no obstructions between the player and the tile, but this could be changed later.
I couldn't determine whether or not this breaks Jagex's third party client rules; to me it's in a bit of a grey zone. Sorry in advance if it is against the rules. I also couldn't find any plugins implementing this functionality already.

As I can see you added the license file but you should update the commit hash to point to the commit which has the license file included.


Fix "cross" configuration for release workflow

This is going to install the "libssl-dev" along wigh "openssl" in targets that don't have these packages by default.
It also fix a configuration to pass down the "RUSTLER_NIF_VERSION" env variable to containers building with cross.

Looks good to me, thanks @philss! @josevalim let me know if we should roll with this for the release or move downloading to elixir already :)

If it works, it works. Ship it! :)


[apptools] Add tests to test build without platforms for apptools

Failure analysis:
https://crosswalk-project.org/jira/browse/XWALK-6020
Impacted tests(approved): new 5, update 1, delete 0
Unit test platform: [Android]
Unit test result summary: pass 5, fail 1, block 0
BUG=https://crosswalk-project.org/jira/browse/XWALK-6773

LGTM


Update translation.json

Coverage remained the same at 55.105% when pulling ddf33b1661c7078e39ab317e76d39c43c6af25be on knagasaki:patch-3 into 492b3b4e1c0e336c44a584216c153157d39897ef on IIIF:release2.1.

Thanks @knagasaki !


add infra support rotation

Current dependencies on/for this PR:

main

PR #8077   👈

This comment was auto-generated by Graphite.


Fixed docker container build error.

@Stephane-D , I updated the install path for sjasm. The docker image build is passing now.

@iratahack, I have a more full-featured fix for that lowercase actor thing.  I was waiting for your fix to land first, but I'll go ahead and upload the PR.  You can incorporate the whole thing if you want.

See #323

@iratahack, I have a more full-featured fix for that lowercase actor thing. I was waiting for your fix to land first, but I'll go ahead and upload the PR. You can incorporate the whole thing if you want.

@joeyparrish , I'll back out my change for this and go with what you have.


Creating a text near the center of a shape should put it in the center

Fixes #264

60 pixels seems a bit too much. Can you go with something smaller. I think 30px would be better

Having alt active should override snap, in case the heuristic doesn't do the right thing

This is awesome btw, this is going to make creating shapes a lot easier!

Having alt active should override snap

@vjeux, sorry, I do not understand what does "Having alt active" mean 😔 Maybe some example would help

If you have the alt key pressed down when you click, it should put it at the exact position you clicked and ignore the heuristic to put it in the center of a nearby shape

Thanks! Thats make sense

Feel free to merge whenever you're done


make setup docker.sock error

I am trying to install caravel mini on Ubuntu 22, but I get the following error messages when running make setup
make[2]: Entering directory '/home/phil/zz/zeasal/caravel_user_mini/dependencies/openlane_src'
Makefile:23: warning: undefined variable 'DOCKER_SWAP'
Makefile:26: warning: undefined variable 'DOCKER_MEMORY'
Makefile:42: warning: undefined variable 'ROUTING_CORES'
Makefile:84: warning: undefined variable 'STD_CELL_LIBRARY'
permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Post "http://%2Fvar%2Frun%2Fdocker.sock/v1.24/images/create?fromImage=efabless%2Fopenlane&tag=2023.07.19-1": dial unix /var/run/docker.sock: connect: permission denied
make[2]: *** [Makefile:115: pull-openlane] Error 1
make[2]: Leaving directory '/home/phil/zz/zeasal/caravel_user_mini/dependencies/openlane_src'
make[1]: *** [Makefile:94: openlane] Error 2
make[1]: Leaving directory '/home/phil/zz/zeasal/caravel_user_mini/openlane'
make: *** [Makefile:215: openlane] Error 2

@philiprbrenan
after docker installation make that as rootless by following instruction from here and run make setup again to resolve above error.


Add aria-errormessage

Should aria-errormessage be added? https://www.w3.org/TR/2017/REC-wai-aria-1.1-20171214/#aria-errormessage

Hey @jth0024, yes. I'm working on to update this repo.
Thanks for your contribution!


Add /QOpenSys/pkgs/bin to .bashrc if needed

Changes
Resolves https://github.com/codefori/vscode-ibmi/issues/1691
This PR enhances the connection process and make it look for /QOpenSys/pkgs/bin in the PATH environment variable.
If it's not there, it will offer to either create ~/.bashrc file or modify it to append /QOpenSys/pkgs/bin to the PATH environment variable.
The creation/modification is delayed in the connection process, so it's only done once the connection is ready to do it.
The connection process will only check this once or if the user connects and reload the server settings, so we won't bother someone who would not like to modify its PATH.
Since .bashrc is only relevant for non-login shell, this shouldn't interfere with .profile or .bash_profile.
Checklist

[x] have tested my change
[x] for feature PRs: PR only includes one feature enhancement.

@sebjulliand Questions:

Is your code always run - or only run when the user shell is bash?
There is a test in the connection for bash as shell - is this code linked to that check? If not, maybe it should?

@sebjulliand Questions:
1. Is your code always run - or only run when the user shell is `bash`?

2. There is a test in the connection for `bash` as shell - is this code linked to that check? If not, maybe it should?

Good questions! The code runs whatever shell is used and do not run only if bash is the current shell. On the other hand, we expect the shell to be bash and offer to change it if it's not; that's why I didn't think about conditioning this action to bash only.
What do you think?

we expect the shell to be bash

Do we expect it? It's not a requirement (to my knowledge), although it could be argued that it should be... however, the users may use the extension against older or customer systems, where bash or OSS environment is not installed.
My thoughts are that we should keep the bash checking code together and not have code in different places changing user settings.
Additional comment about PATH: /QOpenSys/pkgs/bin should be before /usr/bin and /QOpenSys/usr/bin - but you don't check for that. Would it be easy to have this check too?

we expect the shell to be bash

Do we expect it? It's not a requirement (to my knowledge), although it could be argued that it should be... however, the users may use the extension against older or customer systems, where bash or OSS environment is not installed.
My thoughts are that we should keep the bash checking code together and not have code in different places changing user settings.

Fair enough! We'll only do this if the current shell is bash then.

Additional comment about PATH: /QOpenSys/pkgs/bin should be before /usr/bin and /QOpenSys/usr/bin - but you don't check for that. Would it be easy to have this check too?

I don't check it but since I always add /QOpenSys/pkgs/bin in first place in the path, that should not be necessary 😄

I don't check it but since I always add /QOpenSys/pkgs/bin in first place in the path, that should not be necessary

But your check will accept a PATH having /QOpenSys/pkgs/bin after the other ones - which is not correct (maybe a user mistake). 😉

I don't check it but since I always add /QOpenSys/pkgs/bin in first place in the path, that should not be necessary

But your check will accept a PATH having /QOpenSys/pkgs/bin after the other ones - which is not correct (maybe a user mistake). 😉
(Sorry for being such a P... in the A..! 😆 )

No, no, you're absolutely right 😅

@chrjorgensen I followed your advice and:

Only run this whole process is bash is the current shell
Check if /QOpenSys/pkgs/bin appears before anything else in PATH

Hopefully this will receive the "Jørgensen Seal of Approval" 😁


Find missing href attributes in rancherio/ui and replace them with href="#"

Tried to file this issue there but the repository doesn't seem to support them. A few weeks back I submitted a PR adding href="#" to a link, which is necessary for accessibility. I received instructions on how to switch my UI to the version from master, but those instructions referenced a link that also seems to be missing an href. In particular, I think the account icon referenced in the getting started docs, which leads to the APIs and Keys page, is missing an href. At least, I can't find it using my screen reader and assume this to be the case. I'd look into submitting a PR, but by definition I can't find any affected links myself, and it might be wise to start making this fix yourselves to avoid it in the future.
Thanks.

resolved in https://github.com/rancher/ui/pull/511

resolved in https://github.com/rancher/ui/pull/511

Version - master 3/8
Verified fixed


Fill in clearDisplay()

[x] Fill in clearDisplay()
[x] Edit demo file to be able to test function
[ ] Verify that function is able to work

(1 hour)

clearDisplay() has been filled in.
The demo file does not need to be updated to be able to test this function.
For now, I verified the functionality of the function using an example file, and then running the function through an interactive session. I did this because it is the first function I am filling in, so in order to test that it is actually clearing the display, I need the example file to put something on the display. I will verify again with the demo file later.
This is the outcome of the test:
I ran:
pi@raspberrypi23:~/Smart_Breadboard $ python3 ~/touchscreen/display_text_and_shapes.py
Which output:

Then I ran:
pi@raspberrypi23:~/Smart_Breadboard $ python3
Python 3.9.2 (default, Mar 12 2021, 04:06:34)
[GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from Smart_Breadboard import clearDisplay
>>> clearDisplay()

Which output:

The test was successful!

@Fatiha897 please review

clearDisplay() was updated from using the reset function to the disp.fill() function. Using the reset method lead to issues where the display would no longer output anything until the python interactive session was exited and rerun.
Below is a test to verify the functionality of the function:
I first ran this code to put an image on the screen
pi@raspberrypi23:~/Smart_Breadboard $ python3
Python 3.9.2 (default, Mar 12 2021, 04:06:34)
[GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import Smart_Breadboard as sbb
>>> disp = sbb.setupDisplay()
>>> image = sbb.createNewImage(disp)
>>> sbb.addPicture(image, "Resistor.jpg", 0, 0, 320)
>>> sbb.sendToDisplay(disp, image)

The output looked like this:

Then I ran the clear display function like so:
>>> sbb.clearDisplay(disp)
The output is shown here:


flutter: newer version available

scoop is installing version 1.5.4-hotfix.2 but version 1.12.13-hotfix.5 is available

Duplicate of #2526
Related lukesampson/scoop#3721


Using  >0.8.0 <=0.9.0 instead of  >0.7.0 <=0.9.0

Using  >0.8.0 <=0.9.0 instead of  >0.7.0 <=0.9.0 will have some benefits ,

Safemath by default from 0.8.0
Low-level inliner from 0.8.2, leads to cheaper runtime gas.
Also , It would be easier for testing .

Please assign this to me under GSSoC.
Thank You!

Upgrading to a higher Solidity version, such as >0.8.0 <=0.9.0, can provide various benefits, including improved code optimization, enhanced security features, and compatibility with the latest advancements in the Solidity language.
and some more feature like
Improved code optimization and Enhanced security features.
@Vikash-8090-Yadav  Assign this task to me .

@Vikash-8090-Yadav Can you assign this to me?

Please start working on the issue, make sure you test the code before making PR.


feat(frontend): revert unused prop formattedBalance

Motivation
Prop formattedBalance (introduced in PR #2150 ) of TokenUI is not used, since there is prop balance that is the most straightforward way of getting a token balance value. Plus, we slightly reduce computational time.

@peterpeterparker alas, it was never used... the plan was to provide it to the calculation of USD balance, and elsewhere too, but the prop balance is more than enough


KAFKA-3522: Add in-memory TimestampedKeyValueStore

Part of KIP-258.

Turns out, after rebasing there is nothing left on this PR. Closing it, because we don't need it any longer.


Update tests to NUnit 3

NUnit 2 is deprecated.
We should update the test framework to use NUnit 3, and parallelize as many as possible

Closing as wont do. This can be re-opened if we do.


Fix python motion planning tutorial

Description
There are issues with the headings in the tutorial Markdown, they were being given the same precedence as the tutorial title which this fixes.
Somehow the markdown file had inconsistencies with the tutorial scripts. This is likely due to a force push that overwrote changes, I also ensure that the Markdown file aligns with the scripts.
Closes https://github.com/ros-planning/moveit2_tutorials/issues/643

CI failures unrelated (see https://github.com/ros-planning/moveit2_tutorials/pull/638) -- if someone with the authority can go ahead and merge this, should be fine.

@sea-bass I fixed conflicts and performed a rebase, I think this pr is now ready for review/merge.

Thanks @adlarkin.


Editor Setup translated to Telugu

I'm working on translating the Editor Setup page to Telugu.
Thank you :)

Hello @g-savitha and @gsteja2307
Please review this pull request, as soon as possible.
Merging this pr will close #11


Limit displaying challenges?

After 10 challenges are present, the challenge page won't allow any competitor to click any available links to submit flags. Additionally,  several challenges are no longer being displayed all together. However, after deleting the 10th entry from the challenge table in the SQLite database everything goes back to normal.
Any idea on why this may be occurring?

Perhaps the challenge is embedding some broken HTML into the page?

Doesn't appear that way on my end.

Sorry I got sidetracked. Do you think you can provide me with a dump of the database or similar so I can debug?

The error occurred when  I created a new category for challenges, but did not immediately add a challenge to that category. It effectively "froze" any addition of new challenges. Removing this category from the sqlite database and then re-adding it with a challenge fixed this.


internal/fuzz: go test -fuzz= outputs failing input which contains wrong datatypes

What version of Go are you using (go version)?

$ go version
go version go1.19.6 darwin/arm64

Does this issue reproduce with the latest release?
Yes, go1.20.1 still reproduces this.

I want to use go fuzztest to help finding the potential bugs, actually I'm learning how it works.

package math_test

import (
	"errors"
	"testing"
)

func Fuzz_overflow_int32(f *testing.F) {
	f.Add(int32(0x7fffffff), int32(0))
	f.Add(int32(-1<<31), int32(0))
	f.Fuzz(func(t *testing.T, a, b int32) {
		if c, err := safeSignedAdd(a, b); err != nil {
			t.Errorf("%v + %v = %v, err: %v", a, b, c, err)
		}
	})
}

var errOverflow = errors.New("overflow")

func safeSignedAdd[T ~int | ~int32 | ~int64](a, b T) (T, error) {
	c := a + b
	if a > 0 && b > 0 && c <= 0 ||
		a < 0 && b < 0 && c >= 0 {
		return c, errOverflow
	}
	return c, nil
}

What did you expect to see?
I want to see the failing and want to check failing input from the log in testdata/......
It ouputs:
go test -count=1 -fuzz=Fuzz*
fuzz: elapsed: 0s, gathering baseline coverage: 0/2 completed
fuzz: elapsed: 0s, gathering baseline coverage: 2/2 completed, now fuzzing with 10 workers
fuzz: elapsed: 0s, execs: 5 (203/sec), new interesting: 0 (total: 2)
--- FAIL: Fuzz_overflow_int32 (0.03s)
    --- FAIL: Fuzz_overflow_int32 (0.00s)
        math_test.go:13:<PHONE_NUMBER> + 84 = -2147483567, err: overflow

    Failing input written to testdata/fuzz/Fuzz_overflow_int32/fc5bf10796c021a99a0336732723622d6438cc5b9e43a3619ffd8e1d5c525266
    To re-run:
    go test -run=Fuzz_overflow_int32/fc5bf10796c021a99a0336732723622d6438cc5b9e43a3619ffd8e1d5c525266
FAIL
exit status 1
FAIL    github.com/hitzhangjie/codemaster/math  0.465s

The data in the log is:
cat testdata/fuzz/Fuzz_overflow_int32/fc5bf10796c021a99a0336732723622d6438cc5b9e43a3619ffd8e1d5c525266
go test fuzz v1
int32(2147483645)
rune('T')

What did you see instead?
The data in the log, I want to see the right datatype and value:
cat testdata/fuzz/Fuzz_overflow_int32/fc5bf10796c021a99a0336732723622d6438cc5b9e43a3619ffd8e1d5c525266
go test fuzz v1
int32(2147483645)
int32(84)

In go, type rune = int32, so the code internal/fuzz/encoding.go:L70 cannot differeniate rune and int32.
If there's no better solutions to solve this.
Could we output more data to help? like: rune('T') /int32(84).

CC @golang/fuzzing.


add model2 gun only games

i think it alread worked.
i think it uses the mamegames.xml file for this one ? guns uses 2 files in fact cause one already existed for mame and arcade games.


remove references to postgres

There are multiple references to PostgreSQL throughout the playbooks. This PR is to simply remove code that's not required to declutter the code.

Can we remove files/directories that end up being near empty, for example jumphost/handlers/main.yml?


UnstructuredMarkdownLoader can not load a markdown file which contains emoji

Checked other resources

[X] I added a very descriptive title to this issue.
[X] I searched the LangChain documentation with the integrated search.
[X] I used the GitHub search to find a similar question and didn't find it.
[X] I am sure that this is a bug in LangChain rather than my code.
[X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package).

Example Code
from langchain_community.document_loaders import UnstructuredMarkdownLoader

loader = UnstructuredMarkdownLoader(
    file_path="./file.md",
)

docs = loader.load()
print(len(docs))

Here is the file.md
🎉

Error Message and Stack Trace (if applicable)
Traceback (most recent call last):
File "/Users/leslie/Documents/code/llm-ops/llm-ops-api/study/23-LangChain内置文档加载器使用/Markdown文档加载器.py", line 22, in
docs = loader.load()
File "/Users/leslie/Documents/code/llm-ops/llm-ops-api/venv/lib/python3.10/site-packages/langchain_core/document_loaders/base.py", line 31, in load
return list(self.lazy_load())
File "/Users/leslie/Documents/code/llm-ops/llm-ops-api/venv/lib/python3.10/site-packages/langchain_community/document_loaders/unstructured.py", line 107, in lazy_load
elements = self._get_elements()
File "/Users/leslie/Documents/code/llm-ops/llm-ops-api/venv/lib/python3.10/site-packages/langchain_community/document_loaders/markdown.py", line 86, in _get_elements
return partition_md(filename=self.file_path, **self.unstructured_kwargs)  # type: ignore[arg-type]
File "/Users/leslie/Documents/code/llm-ops/llm-ops-api/venv/lib/python3.10/site-packages/unstructured/partition/md.py", line 78, in partition_md
return partition_html(
File "/Users/leslie/Documents/code/llm-ops/llm-ops-api/venv/lib/python3.10/site-packages/unstructured/partition/common/metadata.py", line 162, in wrapper
elements = func(*args, **kwargs)
File "/Users/leslie/Documents/code/llm-ops/llm-ops-api/venv/lib/python3.10/site-packages/unstructured/chunking/dispatch.py", line 74, in wrapper
elements = func(*args, **kwargs)
File "/Users/leslie/Documents/code/llm-ops/llm-ops-api/venv/lib/python3.10/site-packages/unstructured/partition/html/partition.py", line 91, in partition_html
return list(_HtmlPartitioner.iter_elements(opts))
File "/Users/leslie/Documents/code/llm-ops/llm-ops-api/venv/lib/python3.10/site-packages/unstructured/partition/html/partition.py", line 197, in iter_elements
yield from cls(opts)._iter_elements()
File "/Users/leslie/Documents/code/llm-ops/llm-ops-api/venv/lib/python3.10/site-packages/unstructured/partition/html/partition.py", line 205, in _iter_elements
self._main.iter_elements()
File "/Users/leslie/Documents/code/llm-ops/llm-ops-api/venv/lib/python3.10/site-packages/unstructured/utils.py", line 154, in get
value = self._fget(obj)
File "/Users/leslie/Documents/code/llm-ops/llm-ops-api/venv/lib/python3.10/site-packages/unstructured/partition/html/partition.py", line 234, in _main
etree.strip_elements(
File "src/lxml/cleanup.pxi", line 100, in lxml.etree.strip_elements
File "src/lxml/apihelpers.pxi", line 41, in lxml.etree._documentOrRaise
TypeError: Invalid input object: NoneType
Description
I am trying to use the UnstructuredMarkdownLoader to load an markdown file.
I expect it can load successfully.
After many tests, I found that if the markdown file contains this symbol 🎉, it will cause the program to crash.
System Info
System Information

OS:  Darwin
OS Version:  Darwin Kernel Version 24.2.0: Fri Dec  6 19:02:12 PST 2024; root:xnu-11215.61.5~2/RELEASE_ARM64_T6031
Python Version:  3.10.11 (v3.10.11:7d4cc5aa85, Apr  4 2023, 19:05:19) [Clang 13.0.0 (clang-13<IP_ADDRESS>)]

Package Information

langchain_core: 0.3.25
langchain: 0.3.12
langchain_community: 0.3.12
langsmith: 0.1.147
langchain_cohere: 0.3.3
langchain_experimental: 0.3.3
langchain_huggingface: 0.1.2
langchain_openai: 0.2.11
langchain_pinecone: 0.2.0
langchain_text_splitters: 0.3.3
langchain_unstructured: 0.1.6
langchain_weaviate: 0.0.3
langgraph_sdk: 0.1.43

Optional packages not installed

langserve

Other Dependencies

aiohttp: 3.9.5
async-timeout: 4.0.3
cohere: 5.13.3
dataclasses-json: 0.6.7
httpx: 0.27.0
httpx-sse: 0.4.0
huggingface-hub: 0.26.3
jsonpatch: 1.33
langsmith-pyo3: Installed. No version info available.
numpy: 1.26.4
onnxruntime: 1.19.2
openai: 1.57.0
orjson: 3.10.12
packaging: 24.2
pandas: 2.2.3
pinecone-client: 5.0.1
pydantic: 2.9.2
pydantic-settings: 2.6.1
PyYAML: 6.0.2
requests: 2.32.3
requests-toolbelt: 1.0.0
sentence-transformers: 3.3.1
simsimd: 4.4.0
SQLAlchemy: 2.0.36
tabulate: 0.9.0
tenacity: 8.5.0
tiktoken: 0.8.0
tokenizers: 0.20.3
transformers: 4.46.3
typing-extensions: 4.12.2
unstructured-client: 0.28.1
unstructured[all-docs]: Installed. No version info available.
weaviate-client: 4.9.6

I am not so sure what you are doing. But it is working for me, can you please upgrade unstructured pacakge?


Updated gql docs

📝 Changed routes:

/docs/graphQL

(view full size)

Commit e40f0c1dd7708c642cd68eb8efb06324fed93ae9 (https://site-nixzcm5f4-lamatic.vercel.app).


main dependency on outdated archetype

Hi,
Most guides of Scala with maven targets archetype:
https://mvnrepository.com/artifact/org.scala-tools.archetypes/scala-archetype-simple/1.3
From the website in it, I'm redirected to your blog.
Please tell me what is your relation to that artefact and tell if it's possible to use the source from this repo in main maven Scala artefact.
Now whoever tries Scala from Maven may get a very bad impression that this ecosystem is badly maintained.
I tried to create Scala project from Intelij Idea default archetypes list.

Please tell me what is your relation to that artefact and tell if it's possible to use the source from this repo in main maven Scala artefact.

Started in 2008 (yes 12 yo), I contributed to the integration/bridge between scala & maven via scala-maven-plugin, this archetype, and the creation of scala-tools.org the first maven repository for scala artifacts (with packaging for scala-library, scala-compiler, ..., before pushing to maven central or jcenter was easy). And also some blog articles. Several years ago, the scala-tool.org server was shutdown, so I moved the maven plugin and archetype under my own domain net.alchim31 (also due to change in the maven policy from 2.x to 3.x).
Yes you can use this repo, fork it, contribute to it.

Now whoever tries Scala from Maven may get a very bad impression that this ecosystem is badly maintained.

I stopped using scala and my interest moved to other domain (rust) few years ago. So the maintenance is only done by other contributors (on their spare time, like me before). By example slandelle keep maintain the scala-maven-plugin (also because it is used by its company).
This feeling is also caused by links to old deprecated articles.
I guess, you're right, the maven/scala is badly maintained by very few people. And the active contributor from scala community mainly focus on SBT (or alternatives gradle, mill ??).

I tried to create Scala project from Intelij Idea default archetypes list.

TBH I didn't use this archetype a lot in the past (after few year), and at this time Eclipse was my main IDE (I also contributed to scala+eclipse).
I hope you have the response. Sorry for the bad experience, like I said contributions to the ecosystem are welcomes.

Now whoever tries Scala from Maven may get a very bad impression that this ecosystem is badly maintained.

Well, it's not an impression. It's the actual situation!
For several years, Scala support on maven has been relying on one single individual on whatever free time he can spare.
According to Jetbrain, in 2019, maven was the second most popular build tool for Scala. Still, I can't say we're swamped with contributions...

My bad. Only Intelij Idea has an outdated archetype. "Most guides of Scala with maven" is not true.
Issue created:
https://youtrack.jetbrains.com/issue/IDEA-255090


Align WalletRegistry parameter view functions with RandomBeacon approach

Depends on #2951; Keeping as a draft until #2951 is not merged.
Aligned WalletRegistry with RandomBeacon changes from #2951. Parameters are grouped together and exposed in view functions:

dkgParameters() - this one was already there
rewardParameters()
slashingParameters()
gasParameters()

This change allowed to reduce the size of WalletRegistry. Before/after:
|  WalletRegistry            ·     21.948  │
|  WalletRegistry            ·     21.903  │

@dimpar this is ready for review now!


[FIXED] [BUG]Lyrics do not scroll at the correct speed when Rate is adjusted

What you're using
Lyrics from LRC files do not scroll at the appropriate speed during game play when Rate is set to values other than 1.0x
Lyrics scroll slower than expected and lines fail to complete scrolling before advancing to the following line when rate is adjusted downward, whereas lyrics scroll too quickly and lines complete scrolling before corresponding audio when rate is adjusted upward.
Issue is present in all builds newer than Alpha 4.9.0 up to current version Alpha 4.9.10.  Issue has been tested on Windows builds on 2 separate machines.
Expected behavior
Lyrics will scroll at the same speed as the Rate that is set so that properly timed lyrics will remain in sync with audio at whatever Rate value is set.
VIDEO EXAMPLE OF BEHAVIOR:
https://youtu.be/KFAvApKxtVg

I checked it myself on my own theme and can confirm it to be the case.
It seemed almost like in #411 (mentioned in Speed Oddities) how the rate gets applied twice over. But this time, it happens to everythere (SampleRates don't seem to matter here this time, Tested with 48kHz & 44.1kHz songs, Couldn't find anything lower to check if their effects are worse or not)

A workaround fix will be added in a17 of 042, but will be fixed in the main release of Alpha V 042.
Thanks for reporting guys

fixed in 042


launching Kafka components using StatefulSet insted of Deployments

Hello,
My name is Ely, I am a customer success engineer at Statehub, we provide a global PersistentVolumes allowing stateful applications on Kubernetes to access their PVs across clusters (regions and clouds) to access
I’m currently creating a blog post about launching Kafka cluster using Koperator while leveraging our technology for a stateful Kafka cluster that will allow fast failover between one Kubernetes cluster to the other.
While testing your guide and launching a fully functional example Kafka cluster I noticed that all the components launched are using deployments and not StatefulSet, thus providing the PVC a name with a suffix that is auto-generated.
Is it possible to deploy the Kafka and Zookeeper pods using a statefulSet with PersistentVolumeClaims instead of a deployment?
Providing a global name that will be recognized across clusters will allow us to launch a new Kafka cluster using the data and volumes from the previous cluster. in order for that to happen, we need zookeeper and Kafka volumes to have a unique and global ID and not be generated.
I browsed through the repository but couldn’t find an example of a config that will use  STS instead of deployment.
I’d appreciate your opinion,
Thanks in advance,
Ely

Hi Ely,
Firstly, As opposed to other Kafka operators, Koperator runs the Kafka brokers as bare Kubernetes Pods instead of using Deployments or StatefulSets.
Secondly, the Koperator takes into account any volume related constraint that you provide through the KafkaCluster CR configuration. More concretely you can set the properties of the PVC generated for each broker in brokerConfig.storageConfigs.pvcSpec.
As an example please check simplekafkacluster.yaml with the default settings:
      storageConfigs:
        - mountPath: "/kafka-logs"
          pvcSpec:
            accessModes:
              - ReadWriteOnce
            resources:
              requests:
                storage: 10Gi

Hi @ElyRonen please look my answer here how can you manually create your own PV and PVC for the operator.
https://github.com/banzaicloud/koperator/issues/572#issuecomment-805668287