Rename file code fix doesn't work

Environment data
dotnet --info output:
.NET Command Line Tools (1.0.0-rc4-004706)

Product Information:
 Version:            1.0.0-rc4-004706
 Commit SHA-1 hash:  e38bc4950c

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  10.11
 OS Platform: Darwin
 RID:         osx.10.11-x64
 Base Path:   /usr/local/share/dotnet/sdk/1.0.0-rc4-004706

VS Code version:1.9.0
C# Extension version:1.7.0-beta4
Steps to reproduce
Have a file called Foo.cs and a class declaration inside called Bar. In the context menu choose Rename file to Bar.cs
Expected  behavior
The file is renamed
Actual behavior
Nothing happens. Omnisharp logs contains the below but no file is renamed.
       ************ Request ************
POST - /v2/getcodeactions
************ Headers ************
Content-Type - application/json
************  Body ************
{
  "Filename": "/Users/jonathan/Projects/twittermw/tests/Fred.cs",
  "Selection": {
    "Start": {
      "Line": 3,
      "Column": 18
    },
    "End": {
      "Line": 3,
      "Column": 21
    }
  }
}
[dbug]: OmniSharp.Middleware.LoggingMiddleware
        ************  Response ************
{"CodeActions":[{"Identifier":"Rename type to Fred","Name":"Rename type to Fred"},{"Identifier":"Rename file to fff.cs","Name":"Rename file to fff.cs"}]}
[dbug]: OmniSharp.Middleware.LoggingMiddleware
        ************ Request ************
POST - /v2/runcodeaction
************ Headers ************
Content-Type - application/json
************  Body ************
{
  "Filename": "/Users/jonathan/Projects/twittermw/tests/Fred.cs",
  "Selection": {
    "Start": {
      "Line": 3,
      "Column": 18
    },
    "End": {
      "Line": 3,
      "Column": 21
    }
  },
  "Identifier": "Rename file to fff.cs",
  "WantsTextChanges": true
}
[trce]: OmniSharp.Host.Loader.AssemblyLoader
        Assembly loaded: Microsoft.CodeAnalysis.Features, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35
[trce]: OmniSharp.Host.Loader.AssemblyLoader
        Assembly loaded: Microsoft.CodeAnalysis.CSharp.Features, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35
[info]: OmniSharp.Roslyn.CSharp.Services.Refactoring.V2.RunCodeActionService
        Applying code action: Rename file to fff.cs
[dbug]: OmniSharp.Middleware.LoggingMiddleware
        ************  Response ************
{"Changes":[]}

Thanks for the report @jchannon

I can imagine why this would fail. Essentially, the service in omnisharp-roslyn gathers up all of the text changes and sends them back to the editor host (in this case, C# for VS Code) to apply. However, in this case, there aren't any text changes, just a file rename. This is something we'll need to handle in omnisharp-roslyn.

This should be fixed as of https://github.com/OmniSharp/omnisharp-vscode/pull/1805

Unless we've added code to tell VS Code to apply a file rename, I wouldn't expect this to be fixed.

@rchande : Please check the repro. This is about the Rename File code fix, which still does not work.

@DustinCampbell You're right, this is a different bug. Thanks for noticing :)

The error message it gives me is
Unable to open 'INewName.cs': Unable to read file 'c:\Users\...\INewName.cs' (Error: Unable to resolve non-existing file 'c:\Users\...\INewName.cs').

The error message it gives me in a toaster is
Unable to open 'INewName.cs': Unable to read file 'c:\Users\...\INewName.cs'
(Error: Unable to resolve non-existing file 'c:\Users\...\INewName.cs').

It's a pretty weird error, since the INewName.cs indeed is supposed not to exist. It's the one that should be written.

I am having this exact same issue.

This is very strange. I decided I wanted to fix this issue, I started by reproducing with the current release version which I was able to do easily. Next I got the code running on my machine, however when I try to reproduce the bug it doesn't happen even if I do a prod build with the current release version v1.24.4 checked out. I'm not really sure how to properly debug the production version of the extension so idk what's going on.
I did see this error in the dev tools console.
rejected promise not handled within 1 second: "System.ArgumentException: 'A.cs' is not open.
   at Microsoft.CodeAnalysis.Workspace.CheckDocumentIsOpen(DocumentId documentId)
   at Microsoft.CodeAnalysis.Workspace.OnDocumentClosed(DocumentId documentId, TextLoader reloader, Boolean updateActiveContext)
   at OmniSharp.OmniSharpWorkspace.CloseDocument(DocumentId documentId) in D:\\a\\1\\s\\src\\OmniSharp.Roslyn\\OmniSharpWorkspace.cs:line 102
   at OmniSharp.Roslyn.CSharp.Services.Files.FileCloseService.Handle(FileCloseRequest request) in D:\\a\\1\\s\\src\\OmniSharp.Roslyn.CSharp\\Services\\Files\\FileCloseService.cs:line 23
   at OmniSharp.Endpoint.EndpointHandler`2.<AggregateResponsesFromLanguageHandlers>d__18.MoveNext() in D:\\a\\1\\s\\src\\OmniSharp.Host\\Endpoint\\EndpointHandler.cs:line 164
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at OmniSharp.Endpoint.EndpointHandler`2.<HandleRequestForLanguage>d__20.MoveNext() in D:\\a\\1\\s\\src\\OmniSharp.Host\\Endpoint\\EndpointHandler.cs:line 227
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at OmniSharp.Endpoint.EndpointHandler`2.<Process>d__16.MoveNext() in D:\\a\\1\\s\\src\\OmniSharp.Host\\Endpoint\\EndpointHandler.cs:line 131
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at OmniSharp.Stdio.Host.<HandleRequest>d__14.MoveNext() in D:\\a\\1\\s\\src\\OmniSharp.Stdio\\Host.cs:line 218"

this shows up a few seconds after vscode tries to open the file C.cs which is what the new file would have been called.

Unable to reproduce in the current release.


StreamSubscription.cancel should fire the onDone callback

Currently, if a StreamSubscription is cancelled, there's no way for the callbacks listening on that subscription to know that it's been cancelled. A listener that's been cancelled is indistinguishable from a stream that's just taking a long time to emit its next value. This makes it easy for programmers to accidentally insert deadlocks in their code were an unsubscription causes a listener to wait forever.
I think the best solution here is to make StreamSubscription.cancel send an onDone event, as though the stream itself had closed.
The same issues are also present when unsubscribeOnError is set to true.

I no longer need this behavior.

I created a package called StreamD that emits the onDone event even when streamSubscription.cancel() is called, it may be useful in some scenarios. The package is based on the default Dart Stream

I agree. The docs should be amended as such, to make it clear that onDone is not called
Replaces the done event handler of this subscription. This is not invoked when StreamSubscription cancel() is called.


[Microsoft Generator CSharp] Migrate Writers: CSProjWriter

The CSProjWriter class should be migrated and stripped of any branding.

close in favor of https://github.com/Azure/autorest.csharp/issues/4463


Trying to follow example

Description
I was following the steps in the README.md but when I try to sign I just get:
[midawson@midawson sigstore-js]$ ./bin/sigstore.js sign ./node-addon-api-4.3.0.tgz >signature
Error: No identity token provided
    at Signer.getIdentityToken (/home/midawson/sigstore/sigstore-js/dist/sign.js:59:15)
    at async Signer.sign (/home/midawson/sigstore/sigstore-js/dist/sign.js:21:31)
    at async sign (/home/midawson/sigstore/sigstore-js/dist/cli/index.js:48:23)
    at async cli (/home/midawson/sigstore/sigstore-js/dist/cli/index.js:27:13)
    at async Object.processArgv (/home/midawson/sigstore/sigstore-js/dist/cli/index.js:79:9)

I'm running on RHEL 8.  Is there some additional configurationt that I need to get the brower window to pop up ?
Version
built from main on  Aug 3 2022

We've got a PR open right now which should address the cross-platform browser opening issue. Look for this to land soon.
https://github.com/sigstore/sigstore-js/pull/16

@bdehamer thanks will keep a look out for that to land.


Update cluster-intro.html

NOTE: Please check the “Allow edits from maintainers” box below to allow
reviewers fix problems on your patch and speed up the review process.
Please delete this note before submitting the pull request.

This change is

@edikmkoyan Please sign the CLA when you get a chance. Thx

@edikmkoyan I think "Now!" is unnecessary. Do you believe the link requires emphasis?

For the sake of PR queue cleanliness, I'm going to close this PR since it's looking stale. Please reopen it if you deem it necessary.


Remove vendor directory from slo-monitor

What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Follow-up to https://github.com/kubernetes/perf-tests/pull/1482.
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
/cc @mm4tt @mborsz
Does this PR introduce a user-facing change?:

NONE

657k lines removed, nice!  👍
/lgtm
/approve

/test pull-perf-tests-verify-all

I forgot that the test is not blocking. @tosi3k, could you take a look into the failure? I'd like to make sure this PR doesn't break anything

I forgot that the test is not blocking. @tosi3k, could you take a look into the failure? I'd like to make sure this PR doesn't break anything

Looks like an error related to interruption by the PR merge, so nothing to worry about (PTAL at the last line):
# TODO(oxddr): allow tests to fail, until we get confidence in the new presubmit
verify/test.sh
Running tests with GO111MODULE=off...
ok  	k8s.io/perf-tests/compare/src	0.598s
?   	k8s.io/perf-tests/compare/src/main	[no test files]
?   	k8s.io/perf-tests/dns/jsonify	[no test files]
Running tests with GO111MODULE=on...
go: downloading github.com/dgryski/go-onlinestats v0.0.0-20170612111826-1c7d19468768
(...)
go: finding github.com/opencontainers/go-digest v1.0.0-rc1
{"component":"entrypoint","file":"prow/entrypoint/run.go:169","func":"k8s.io/test-infra/prow/entrypoint.Options.ExecuteProcess","level":"error","msg":"Entrypoint received interrupt: terminated","severity":"error","time":"2020-09-21T14:58:43Z"}

I ran make verify-all beforehand locally and it worked as well.


Add Thaumaturge Archetype

Resolves #64

This PR requires merging of https://github.com/foundryvtt/pf2e/pull/14678 into the core system


add view all prodcuts on product view page bottom

to give more interactions.

also show 6 products instead of 3


Legacy build fails on babel step

Describe the bug
The build with the legacy plugin active fails with an error from babel.
❯ npm run build

><EMAIL_ADDRESS>build
> tsc && vite build

vite v2.0.5 building for production...
✓ 21 modules transformed.
[legacy-post-process] [BABEL] unknown: .plugins[13][0] must be a string, object, function
error during build:
Error: [BABEL] unknown: .plugins[13][0] must be a string, object, function
    at assertPluginTarget (/Sites/vite-project/node_modules/@babel/standalone/babel.js:67416:12)
    at assertPluginItem (//Sites/vite-project/node_modules/@babel/standalone/babel.js:67390:6)
    at //Sites/vite-project/node_modules/@babel/standalone/babel.js:67373:15
    at Array.forEach (<anonymous>)
    at assertPluginList (/Sites/vite-project/node_modules/@babel/standalone/babel.js:67372:10)
    at /Sites/vite-project/node_modules/@babel/standalone/babel.js:67591:6
    at Array.forEach (<anonymous>)
    at validateNested (/Sites/vite-project/node_modules/@babel/standalone/babel.js:67567:22)
    at validate$3 (/Sites/vite-project/node_modules/@babel/standalone/babel.js:67558:11)
    at /Sites/vite-project/node_modules/@babel/standalone/babel.js:69754:15

Reproduction
Base config
import { defineConfig } from 'vite'
import legacy from '@vitejs/plugin-legacy'

export default defineConfig({
  plugins: [legacy({ targets: ['defaults', 'not IE 11'] })]
})

System Info

vite version: 2.0.5
Operating System: macOS Big Sur
Node version: 12.21.0
Package manager (npm/yarn/pnpm) and version: npm 7.6.0

I had the same problem.
my vite.config.ts file
import { defineConfig } from 'vite'
import vue from '@vitejs/plugin-vue'
import path from 'path'
import legacy from '@vitejs/plugin-legacy'
export default defineConfig({
plugins: [
vue(),
legacy({
targets: ['defaults', 'not IE 11']
})
],
resolve: {
alias: {
'@': path.resolve(__dirname, './src')
}
},
build: {
outDir: "./www",
}
})

I had the same problem.
my vite.config.ts file
import { defineConfig } from 'vite'
import vue from '@vitejs/plugin-vue'
import path from 'path'
import legacy from '@vitejs/plugin-legacy'

export default defineConfig({
  plugins: [
    vue(),
    legacy({
      targets: ['defaults', 'not IE 11']
    })
  ],

  resolve: {
    alias: {
      '@': path.resolve(__dirname, './src')
    }
  },

  build: {
    outDir: "./www",
  }
})

@mengelbrecht Where exactly are we supposed to pin @babel/standalone? Since it looks like plugin-legacy vendors it's own version of @babel/standalone at ^7.12.12.

+1 having the same issue. @mengelbrecht 's workaround helped for now https://github.com/vitejs/vite/issues/2442#issuecomment-794818195

+1 having the same issue.  @wgordon17  's workaround helped for now #2442(comment)

so.. I use pnpm, it seems to have no effect.

@vvni forn pnpm you should use a readPackage hook to change the version required by @vitejs/plugin-legacy
module.exports = {
  hooks: {
    readPackage: (pkg) => {
      if (pkg.name === "@vitejs/plugin-legacy") {
        pkg.dependencies['@babel/standalone'] = '7.13.9';
      }
      return pkg;
    }
  }
};

@vvni forn pnpm you should use a readPackage hook to change the version required by @vitejs/plugin-legacy
module.exports = {
  hooks: {
    readPackage: (pkg) => {
      if (pkg.name === "@vitejs/plugin-legacy") {
        pkg.dependencies['@babel/standalone'] = '7.13.9';
      }
      return pkg;
    }
  }
};

thanks!

Is any progress there?

Any progress?
I'm also facing the issue right now...

@zheeeng @ShookLyngs You may waiting for PR either https://github.com/babel/babel/pull/13017 or https://github.com/rollup/plugins/pull/838 .

<EMAIL_ADDRESS>has been published, RE-install vite-legacy can fix this issue.
yarn remove @vitejs/plugin-legacy && yarn add @vitejs/plugin-legacy --dev

@pedrodim could you confirm that this issue has been fixed after<EMAIL_ADDRESS>

Yes! Issue is fixed with<EMAIL_ADDRESS>It would be great if the plugin's package.json would be updated with the updated @babel/standalone version number, but not necessary as it picks already the correct version as it is thanks to semver

@pedrodim would you like to send a PR for that?


ci: change gh-pages deployment source from branch to action

in essence it removes the need for creating a branch for it. there's already a github workflow involved in documentation generation so why not use this new way and get rid of said man-in-the-middle branch!
https://github.blog/changelog/2022-07-27-github-pages-custom-github-actions-workflows-beta/

Implement as seen in above POC commit which is working:

note: seeing the weird "via issues" made me come to realize #148


Display uneven splitting in 'Expense' view

Fantastic project, thank you very much!
I have a (hopefully minor) feature request: it would be great if uneven shares/splits would be displayed in the expense-overview:
Reproduce:
Create an expense with uneven shares, for example:

No indication in the expense overview:

Correct. I did search existing issues, but used the wrong search terms apparently. Thank you.


Pin dask higher, skip dask v2024.11.0

Pull Request Checklist:

[ ] This PR addresses an already opened issue (for bug fixes / features)

This PR fixes #xyz

[ ] Tests for the changes have been added (for bug fixes / features)

[ ] (If applicable) Documentation has been added / updated (for bug fixes / features)

[x] CHANGELOG.rst has been updated (with summary of main changes)

[x] Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

Sets the lowest dask pin to the version that dropped Python 3.9 support.
Temporarily pins dask below version 2024.11.0 as this version has changed chunking behaviour.

Does this PR introduce a breaking change?
Not really. It should not affect relatively recent builds/installations.
Other information:
https://numpy.org/neps/nep-0029-deprecation_policy.html
https://docs.dask.org/en/stable/changelog.html#v2024-11-1

coverage: 89.398% (-0.02%) from 89.417%
when pulling e9c69dd26f24cd920a140803a18181898f623073 on pin-dask
into 4198e8bcc9d21dd6a89b5c93cf58972a69b87758 on main.


hg19.100kb.windows.bed

Hi,
I was following the 'paper_code/02_technical_tests.sh' instruction to calculate compartments size, and then I want to calculate each compartments strength, I just don't understand what the 'hg19.100kb.windows.bed' file looks like, is it the chromosome size file?
Best,
Pengfei

Hi @pengfei50,
Here is how the file format looks like, it's just bed with bins of your desired size:

chrom   start   end
chr1    0       100000
chr1    100000  200000
chr1    200000  300000
chr1    300000  400000
chr1    400000  500000

You can create this with bedtools makewindows -g [chromosome sizes file] -w [window] function.


formalize subsection vs subsection*?

We should decide if we want numbering or not on subsections. I kind of like having numbers, but the most important part is to be consistent.

I do like having numbering on subsections, as it makes it much easier to reference them from elsewhere (other sections, or other articles, etc.).

Happy with numbers! Will make sure there are numbers.

Done


AssertionError in metrics.py when searching

The following search causes an AssertionError.
$ grascii search -g n-dv
Output:
(Token('DV', 'DV'), set())
Traceback (most recent call last):
  File "bin/grascii", line 8, in <module>
    sys.exit(main())
  File "lib/python3.9/site-packages/grascii/__main__.py", line 37, in main
    args.func(args)
  File "lib/python3.9/site-packages/grascii/search.py", line 105, in cli_search
    results = search(**{k: v for k, v in vars(args).items() if v is not None})
  File "lib/python3.9/site-packages/grascii/search.py", line 97, in search
    return searcher.search(**kwargs)
  File "lib/python3.9/site-packages/grascii/searchers.py", line 154, in search
    return list(results)
  File "lib/python3.9/site-packages/grascii/searchers.py", line 54, in perform_search
    diff = min(diff, metric(interp, match))
  File "lib/python3.9/site-packages/grascii/metrics.py", line 204, in standard
    return match_distance(g1, g2)
  File "lib/python3.9/site-packages/grascii/metrics.py", line 180, in match_distance
    v1[0] = v0[0] + compute_ins_del_cost(g1[i])
  File "lib/python3.9/site-packages/grascii/metrics.py", line 118, in compute_ins_del_cost
    assert cost > 0
AssertionError

Oops, looks like grammar.STROKES is also missing TV.
grascii search -g df

  File "grascii/grascii/metrics.py", line 86, in compute_ins_del_cost
    assert cost > 0, stroke
AssertionError: AnnotatedStroke(stroke='TV', annotations=set())


update notifications to new styles

In preparation for an upcoming ticket, update notifications to new colors and simplify code, including pulling out a bunch of stuff that isn't (was never? unclear.) needed.
Tested as extensively as I could in-browser.

Grouping is still there, but only for multiples of the same message with the same id. This doesn't really happen often, since most id's are dynamic, but it's a capability we retain. I've addressed the other feedback, so I'm going to go ahead and merge.


New Readme

We should write a new readme to properly show off what P4ML can now do.

Hm, I think for now we go with a bare bones and just start adding tutorials that we can link from the readme.


Mansion generation issues in Lost Cities worlds

I know from #46 that it was necessary to re-implement Mansions, but there are a couple of ways in which Lost Cities mansions are different from vanilla mansions beyond just the /locate command:
First, they're generating in arbitrary biomes. In vanilla, Mansions only generate in the Roofed Forest biome, but they seem to have no such restriction here. This is resulting in some weird things (and I suspect they're generating more often than they should as a consequence).
Two, because the vanilla 'Mansion' feature isn't generating in the world, the Cartographer villager cannot sell maps for finding Mansions. This actually cuts out a key vanilla mechanic for progression.
I don't know if you can fix the second, but the first definitely should get some attention.
This is MC 1.12.2, forge 2501, Lost Cities 1.0.1, BiomesOPlenty-1.12.2-<IP_ADDRESS>8. Plus other mods.

Hm. Doing minimalist tests, and it might be a mod interaction issue for this and #53. Will report again soon.

Found the problem. Reproduced with JUST forge 2501 and LC 1.0.1.
Made only this change to the default profile:
    # List of biomes that are allowed in the world. Empty list is default all biomes. The factor controls how much that biome is favored over the others (higher means less favored!) [default: ]
    S:allowedBiomeFactors <
        plains=1
     >

Create a world with seed: -8211488617467187250
Load in the world, experience the wonderful sound of guardians in a plains biome right next to spawn.
There's a mansion not too far away with a monument under it:
!(Whoops.)[https://media.discordapp.net/attachments/360995219321126935/373743992657018880/2017-10-28_01.04.34.png?width=1063&height=552]
So it looks like simply adding anything to allowedBiomeFactors breaks the biome checks for monuments/mansions.
I don't know if this is also the case with cityBiomeFactors

For clarity: I completely stripped the Config directory first before making the above edit, and Lost Cities is the only thing in the mods folder. So I'm confident this is just a Lost Cities issue.


Ordering of keys matters in creation of task hash

I was running into a situation where the task could not be found due to the hash value computed by
TaskManager.gettask() being different than that calculated by new_task(). I am using Python 2.7 UCS4 and Django 1.6.
The problem lies in lines 87 and 99 -
task_params = json.dumps((args, kwargs))
kwargs is not an OrderedDict, so how the keys are eventually arranged in the json string is not guaranteed.
I set the line to
task_params = json.dumps((args, kwargs), sort_keys=True)
and now things work as expected.

Hi @drfraser,
this sounds like an easy fix for this problem. Would you mind to send a PR and i will release your changes in the next version.

as requested


Is there a convention/preference for which IS-04 device-type to advertise?

Is there a convention/preference for which IS-04 device-type to advertise?
Also, is there any consequence of having both device types in the same NMOS environment? i.e. should it be possible to route between them, etc?

Asked by Matt Dicken on AMWA Workshops Slack.

I haven't seen anyone do anything useful with Device type if I'm honest. I don't believe any Controller will bother looking at it.
Neither IS-04 nor https://specs.amwa.tv/nmos-parameter-registers/branches/main/device-types/ are very helpful.
And the new BCP-002-02 Device function tag is more flexible. https://specs.amwa.tv/bcp-002-02/releases/v1.0.0/docs/Overview.html#function

Architecture Review Group review: place on backlog

As pointed out by @garethsb BCP-002-02 Device function tag should used going forward.


Question: top-level interface and ES6 "export default AssignmentExpression"

I see that this works in compiler built from recent sources:
export default A;
interface A {}

According to the ES6 specification, after "export default" we only have three options:

class declaration
hoistable declaration (i.e., function or generator declaration)
AssignmentExpression

If we treat "A" from my example as an AssignmentExpression, then it should work exactly the same way as AssignmentExpression in any other place, e.g. "var x = A".
For "var x = A" we reasonably have  'Cannot find name A'.
But in my example above, 'A' is resolved.
It means, that after 'export default' we have something different from an ordinary AssignmentExpression.
Are there some special rules for what can appear after export default in the statement?
Does it have a special meaning in case of "export default Identifier"?
Thanks!

Note: there are some additional changes to how export default and export = work that is not in master now. see #2460 for more details.
In the current implementation export default Identifier indicates exporting all meanings of the Identifier (value, type and namespace), that is the same behavior in export = Identifier.
At compile time the compiler will elide exports that do not have a value, and in the given example, interface A, the export default statement, and any imports to the default binding in other modules will not be written to your .js output.

Thanks a lot, now it's clear for me, and I see that #2460 is merged into master, so I'll see and try the new changes. You may close this question, thanks.


Naïve Cookie assumption

Describe the bug
Code assumes the CSRF token is the first cookie returned by the server, this breaks if there's any sort of LB or caching in front of Demisto
To Reproduce
Steps to reproduce the behavior:

Proxy Demisto through anything that sets a cookie
See error

Expected behavior
Script can log in successfully
Error
HTTP response body: {"id":"forbidden","status":403,"title":"Forbidden","detail":"Issue with CSRF code","error":"http: named cookie not present","encrypted":false,"multires":null}

@BGarber42 not sure I fully follow here
is this a bug ? a question?
any customer encountered it ?
which LB/cache you used which broke in this case ?
we have multiple customers using proxy/LB in front of their Demisto server

To expand, if you use an AWS ALB, it sets it's own cookies for sessions. The code will just look at the first Set-Cookie header and try to use string manipulation to extract out the value rather than use builtins

Hey @BGarber42, I'm taking care of the issue.
Anyway, I suggest you to move to API-Key authentication instead of basic auth.

I'll be happy to hear about it!
On which endpoints and the error message.


Add Pashmak programming language

Description

Checklist:

[ ] I am associating a language with a new file extension.

[ ] The new extension is used in hundreds of repositories on GitHub.com

Search results for each extension:

https://github.com/search?utf8=✓&type=Code&ref=searchresults&q=extension%3AFOOBAR+KEYWORDS+NOT+nothack

[ ] I have included a real-world usage sample for all extensions added in this PR:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[x] I am adding a new language.

[ ] The extension of the new language is used in hundreds of repositories on GitHub.com.

Search results for each extension:

https://github.com/search?utf8=✓&type=Code&ref=searchresults&q=extension%3AFOOBAR+KEYWORDS+NOT+nothack

[x] I have included a real-world usage sample for all extensions added in this PR:

[x] I have included a syntax highlighting grammar: https://github-lightshow.herokuapp.com/
[ ] I have updated the heuristics to distinguish my language from others using the same extension.

[ ] I am fixing a misclassified language

[ ] I have included a new sample for the misclassified language:

Sample source(s):

[URL to each sample source, if applicable]

Sample license(s):

[ ] I have included a change to the heuristics to distinguish my language from others using the same extension.

[ ] I am changing the source of a syntax highlighting grammar

Old: https://github-lightshow.herokuapp.com/
New: https://github-lightshow.herokuapp.com/

[ ] I am updating a grammar submodule

[ ] I am adding new or changing current functionality

[ ] I have added or updated the tests for the new or changed functionality.

[ ] I am changing the color associated with a language

[ ] I have obtained agreement from the wider language community on this color change.

[URL to public discussion]
[Optional: URL to official branding guidelines for the language]

The Pashmak official organization is here: https://github.com/pashmaklang

What is workflow problem?

well. I fixed all of problems. but only this error is available and i don't know how to fix it:

license needs review: MIT

https://github.com/github/linguist/issues/5107#issuecomment-774781832

As mentioned at https://github.com/github/linguist/issues/5107#issuecomment-742699195 we require a minimum usage level of at least 200 unique user/repo combinations for each extension.
You are a very very long way from meeting this:

.pashm:

Total files found: 77
Unique public user/repos: 7
Unique owners: 4

.pashmt:

Total files found: 206
Unique public user/repos: 1
Unique owners: 1
As you are so far from reaching the minimum level, I don't anticipate this to change in the near future so I'm going to close this PR.
Please feel free to re-open when usage has reached sufficient popularity.

Ok. I'll re-open this PR when minimum requirements was available.


Custom domain pointing to latest tag in repo

I currently have a custom domain set up to point to my master branch.  I would also like to have a consistent staging environment URL, but having a long-lived staging branch would introduce unnecessary overhead to our development process.  The way I have done this in non-Amplify projects is to have the production environment be a deployment of the latest tag in the repo.  This would then leave me free to make the master branch a pre-production staging environment with a consistent URL.
I would like an option to set my custom domain to point to a build of the latest tag in the repo.  Would this be possible?

@woodsae thanks for the feature request. Some questions:

Do you want to have a flow where you can create a branch deployment from a specific tag? (e.g. release)
Can you tell us what tags you use specifically in your workflow?

Hi @swaminator, thank you for the response.
When I want to deploy to production I would make a tag in the format v1.0.0, so any tag starting with v means a production tag.  I would like my custom domain, app.trabr.com, to point to a deployment of the latest tag.  So when I make a new tag starting with v, a deployment would happen and that code would now be serving production.
Does that make sense?

Hi @swaminator , do you have any thoughts around my previous comment?

I'm looking for something similar. We have our dev environment connected to the master branch and our prod environment connected to the prod branch. Maintaining the prod branch is not clean. All we want to do is "promote" the master branch to production. In our non-Amplify apps, we are able to simply publish a GitHub release, which triggers a GitHub Action to deploy to prod. Being able to connect an Amplify env to a tag or a release, or the latest tag as @woodsae seems like an improvement over maintaining separate branches for different environments.

@swaminator Is there any movement on this?
Just to be clear, this is what I want to accomplish:

Dev branches use the PR Preview functionality and each have a unique URL
Staging points to the master branch and has a consistent custom domain URL
Production points to the latest tag/release in Github and has a consistent custom domain URL

This would be hugely beneficial if we can accomplish this, because we have a native iOS app that exposes some web functionality in a wrapper and if the staging URL is constantly changing because of PR previews it means we have to keep updating the build just to test functionality.  And it would be too much extra effort to always maintain a staging branch.

I'm looking for the same thing. I was able to use the "Incoming webhooks" feature to get amplify to only builds the app when a "release" event is triggered in GitHub, but it's still building the latest version of the branch, making reverting to a previous release/branch in GitHub pointless. It would be great if Amplify could be configured to just track the latest tag/release.

I could really do with this too. I need to be able to select a new tag once it has been built to just point the domain over to the new code. This would also then allow for rollback if a new tag introduces an issue to a production environment.
I understand I could do this with branches. But tags exist in GH and other repo management solutions for the express purpose of being able to target specific versions.

Would really appreciate to be able to use Git tags as well. Many deployment tools use the release artifact as the source of truth for deployments and rollbacks, and relying only on a branch for me seems a bit error prone. Rolling back with amplify currently isn’t easy as well. Reverting the code in the master branch doesn’t seem to be a good option .
Any ideas when this could be tackled?

Releasing and deploying on new git tags is very common, so this seems to make a lot of sense to have.
One workaround that seems pretty straightforward to me is having your CD (jenkins/github actions, etc) force push to the deployment branch any time a relevant tag is created (not master, more like "release-amplify" or something) . Rolling back to a different tag should be possible in a similar fashion. Proper branch rules in github could make sure that this branch isn't updated in any other way.
Does that cover this use case?

+1 for the request(s) for being able to connect Amplify to a specific tag/release for deploys and rollbacks.  There hasn't been much feedback/response on this from AWS yet @swaminator , any idea of when/if this request might see some action?

@swaminator Bumping this thread... any updates?

@swaminator I think this is a must have feature. AWS CodeBuild support this feature, why Amplify can't?

Any updates on this feature?

@swaminator Any updates? 🙏

Also looking for this feature coming over from github actions.

@swaminator this feature is also something that our team is looking for

+1

+1 Been desiring this feature for awhile.
Any updates?

+1 same here! would really love to see this feature! is there any progress on that?

my +1 for this

+1 need this feature

+1 Much needed feature
For those looking for a workaround, I was able to deploy the Amplify webhook through Github actions.

@swaminator any updates? much anticipated feature.

Still awaiting GitHub tagged version support.
Any updates on when this will or will not be supported?

+1 same need

+1

+1

+1

+1

Any updates on this feature?

+1

Is there any update on this feature? My team also need it.

+1 It's a very needed feature

+1

+1

We sort of solved this by creating a GitHub action that manages a merge from our main branch into each environment branch that Amplify currently requires. While it does not achieve exactly what the original request was here it allows us to run trunk-based development. It does the following:

Action is triggered when tagging a deployment on main
Creates a temporary branch from whichever environment branch Amplify is connected to, such as "stage"
Merges main into this temporary branch and prefers the changes in main to avoid any merge conflicts
Opens a PR and merges with relevant commit messages
Deletes the temporary branch used in the action

True tag-based deployments would still be a great addition to the Amplify platform, but this is working well enough for us. Where we still have environment branches, but they are locked down from usual git actions, and only the GitHub action controls what goes in/out.

4 years later, no response on so important feature

4 years later, no response on so critical feature request

+1

+1

We sort of solved this

Would it be possible to provide an concrete example of how you solved that?
We're having the same problem currently, and I could not figure yet out a way to make that workflow automatic.

Any updates from AWS on this?


Support anchor links and not just anchor for the html formatter

(Original issue 316 created by s0undt3ch on 2007-12-30T17:55:22+00:00)
Here's a patch that adds support for anchor links generation besides the generated anchors.
Example:
{{{
#!text/html

  2 from
datetime import
datetime

  3 import
math

  4
}}}
Space added for clarity. This is for inline, but also works for tabled outputs.

(Original issue was assigned to gbrandl)
(Original issue 316 last updated on 2009-02-10T17:44:55+00:00)
(Issue automaticaly closed due to status in Bitbucket: resolved)

(Original comment by gbrandl on 2009-02-10T13:11:05+00:00)
This is now in trunk with [682d87aff762].

(Original comment by thatch on 2008-07-26T15:22:37+00:00)
Retargeting for next release.


⚠ SceneTime has degraded performance

In 7784094, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 2812 ms

Resolved: SceneTime performance has improved in 1cd3111.


"add new vechicle" appears to fail, but actually succeeds

When I click "submit" on the "add new vehicle" dialog, the dialog box does not close.  There is a javascript error in the console:
TypeError: Cannot read property 'data' of undefined
at scripts.min.0f37340467.js:19
I'm using Chrome 46.

Oops, duplicate of #136


Identifiers validation failed for dataset Uso y monitoreo de los recursos naturales en el Corredor Biológico Mesoamericano (áreas focales Xpujil-Zoh Laguna y Carrillo Puerto) (Acahuales)

Identifier validation failed for the dataset Uso y monitoreo de los recursos naturales en el Corredor Biológico Mesoamericano (áreas focales Xpujil-Zoh Laguna y Carrillo Puerto) (Acahuales):

Crawler attempt: 271
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 168
Cause: GBIF IDs hit maximum allowed - 50%, duplicates - 100%, total records count 168, absent records count 168
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3072633/step

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Uso y monitoreo de los recursos naturales en el Corredor Biológico Mesoamericano (áreas focales Xpujil-Zoh Laguna y Carrillo Puerto) (Acahuales) : https://doi.org/10.15468/rdksfh.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset Uso y monitoreo de los recursos naturales en el Corredor Biológico Mesoamericano (áreas focales Xpujil-Zoh Laguna y Carrillo Puerto) (Acahuales):

Crawler attempt: 272
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 168
Cause: GBIF IDs hit maximum allowed - 50%, duplicates - 100%, total records count 168, absent records count 168
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3072767/step

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Uso y monitoreo de los recursos naturales en el Corredor Biológico Mesoamericano (áreas focales Xpujil-Zoh Laguna y Carrillo Puerto) (Acahuales) : https://doi.org/10.15468/rdksfh.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.

Identifier validation still  failing for the dataset Uso y monitoreo de los recursos naturales en el Corredor Biológico Mesoamericano (áreas focales Xpujil-Zoh Laguna y Carrillo Puerto) (Acahuales):

Crawler attempt: 275
Publishing organization: Comisión nacional para el conocimiento y uso de la biodiversidad
Publishing country: MEXICO
Installation: IPTCONABIO
Number of occurrences indexed for this dataset at the time of the issue: 168
Cause: GBIF IDs hit maximum allowed - 50%, duplicates - 100%, total records count 168, absent records count 168
Pipelines execution steps: http://api.gbif.org/v1/pipelines/history/execution/3093564/step

Publisher email
Hello,
I am contacting you from the GBIF Secretariat about a dataset published by the Uso y monitoreo de los recursos naturales en el Corredor Biológico Mesoamericano (áreas focales Xpujil-Zoh Laguna y Carrillo Puerto) (Acahuales) : https://doi.org/10.15468/rdksfh.
We noticed that the occurrenceIDs were changed. We have temporarily paused the ingestions of this dataset.
As you might already know, when an occurrence record has a new occurrenceID for a given dataset, our system considers it to be a new occurrence.
This means that it will be given a new gbifid and a new occurrence URL (like this one: https://www.gbif.org/occurrence/1252968762) and the old gbifid and URL will be deprecated.
In this case, this means that the occurrence URLs would be deprecated when ingesting the newest versions of these datasets.
We would like to check with you if those changes were intentional. Do you know if this is the case?
Please let us know, thanks! We are happy to resume the dataset ingestion.
Note that some users rely on those occurrence URLs and gbifids (like https://bionomia.net for example). In an attempt to improve
the stability of the occurrence URLs and gbifids, we have implemented a warning system to detect these type of changes in datasets (see this news item).
If the data publisher can provide us with a list of old and new occurrenceIDs per record, we can avoid the identifier and URL changes. Could that be an option?
Please let us know if you have any question. Thanks!
All the best,

You can skip/fix identifier validation using the registry UI.


Combined thread and async pool, with single returned collection?

Common use case, I have a collection of URLs, which all need to be downloaded. The results should be stored in a collection of same size as input.
Simple, right? - Okay, let's get a little fancier with requirements. This time, pub fn download is in another crate, and the const URLS: &'static [&'static str] is passed through to the download function.
Here, I may use some heuristic, like given a collection of 10000000 URLs, chunk them into 10% buckets, and iterate over the collection of buckets using par_iter. Now, each bucket—containing 10% of total URLs—is handed over to mio which processes them asynchronously.
I know the size of the initial collection. I can guarantee the invariant that no two threads or async tasks will ever read or write the same element in the collection. Seeing as I have my own invariant, I guess I need unsafe? 🚧
Finally, at the end of the function, once all the async tasks have finished—which also means the threads have concluded—it can return a constant sized + constant capacity + constant length collection, containing all the results of the URL requests.
Here is my current version, which just uses mio (no rayon), and containing the collection of URLs in the same crate (not passed into the function through an argument):
#![feature(const_slice_len)]

#[macro_use]
extern crate failure;

use mio::{Events, Poll};
use mio_httpc::{CallBuilder, Httpc, HttpcCfg, SimpleCall};

use failure::Error;

const URLS: &'static [&'static str] = &["http://detectportal.firefox.com/success.txt"];

fn do_call(htp: &mut Httpc, poll: &Poll, mut call: SimpleCall) -> Result<String, Error> {
    let mut buf: Option<String> = None;
    let to = ::std::time::Duration::from_millis(100);
    let mut events = Events::with_capacity(8);
    'outer: loop {
        poll.poll(&mut events, Some(to)).unwrap();
        for cref in htp.timeout().into_iter() {
            if call.is_ref(cref) {
                return Err(format_err!("Request timed out"));
            }
        }

        for ev in events.iter() {
            let cref = htp.event(&ev);

            if call.is_call(&cref) && call.perform(htp, &poll).expect("Call failed") {
                let (resp, body) = call.finish().expect("No response");
                println!("done req = {}", resp.status);
                for h in resp.headers() {
                    println!("Header = {}", h);
                }
                match String::from_utf8(body.clone()) {
                    Ok(s) => buf = Some(s),
                    Err(_) => {
                        return Err(format_err!("Non utf8 body sized: {}", body.len()));
                    }
                }
                break 'outer;
            }
        }
    }
    match buf {
        Some(s) => Ok(s),
        None => Err(format_err!("Empty response")),
    }
}

pub fn download<T>() -> Result<[String; URLS.len()], Error> {
    let poll = Poll::new().unwrap();

    let cfg = match HttpcCfg::certs_from_path(".") {
        Ok(cfg) => cfg,
        Err(_) => Default::default(),
    };
    let mut htp = Httpc::new(10, Some(cfg));

    let mut a = [String::from(""); URLS.len()];

    for i in 0..URLS.len() {
        println!("Get {}", URLS[i]);
        let call = CallBuilder::get()
            .url(URLS[i])
            .expect("Invalid url")
            .timeout_ms(10000)
            // .insecure_do_not_verify_domain()
            .simple_call(&mut htp, &poll)
            .expect("Call start failed");
        match do_call(&mut htp, &poll, call) {
            Ok(response_string) => a[i] = response_string,
            Err(e) => return Err(format_err!("{}", e)),
        }

        println!("Open connections = {}", htp.open_connections());
    }
    Ok(a)
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn it_works() {
        match download::<String>() {
            Ok(responses) => {
                for resp in &responses {
                    assert_eq!(resp, "success\n");
                }
            }
            Err(e) => panic!(e),
        }
    }
}

Is rayon the right tool for implementing what I'm envisioning, is there a better tool, or is my use-case so custom that I need to write this all by hand?
Thanks for your suggestions 🤕

Okay, thanks for your insights.


lua 使用发起http 请求时报错

http.lua:803: bad request
stack traceback:
之前 lua_code_cache  off 时一直正常
现在开启 lua_code_cache on 后就报错

problem has been solved. After opening the cache, you need to close the connection manually


Server: Use a bundled .jar file to get the java executable path

As far as I could tell the Mac(?) version of the check already depended on a proper java installation, so assuming java can be found in PATH should be sane.
With that assumption the check might seem a bit redundant, but it can be used in the future if / when custom java executables are supported to quickly get the default one.

The java_home.jar is really simple, only containing the following code, which has been shrunk and obfuscated using ProGuard:
public static void main(String[] args) {
  System.out.print(System.getProperty("java.home"));
}

I feel like adding the source files for that into this project is a bit redundant, that's why I only left a note about it in the commit message. But if you feel like it's absolutely necessary, I'll add them.
How would you feel about having javaPath and javaHome? I'll add that once I get your confirmation about the .jar source

@nickrnet Could you take another look at this? It's rather hard to test things without the java check working :D
I'll add the source files if you feel like the commit message isn't enough, but I think another form of documentation would be better. Maybe add something to /docs about it?
I could also write something to get it from the output of java -version, but that's more prone to bugs and harder to maintain.

My biggest concern here was having executable binary packages without the source. I know there are already some things like this installed by npm, but don't want to run into trouble from people that run this with packages we are blind to.
I know the commercial Minecraft package has a JRE bundled (i.e. their Launcher), so I'm investigating options there as well.
Can you walk me through the testing that has been done on this change? Yes, a java.md file in doc with this explanation (and maybe a checksum of the jar) would probably be sufficient for now to get moving.

Finally found a pure js solution!
The check now grabs the home directory from -XshowSettings:properties, which is a 'Non-standard' option. According to the documentation, "Non-standard options are general purpose options that are specific to the Java HotSpot Virtual Machine, so they are not guaranteed to be supported by all JVM implementations, and are subject to change."
According to the documentation, it's still in versions 8, 9 and 10, and according to tests, it's still in (OpenJDK) 11
Those should be all the versions we care about

Sweet, this works on OS X too. Nice!


When I change the data prop, the table is not being re-rendered

My table uses an array of objects for the data parameter. When that data gets updated I have to manually sort the table to see the newly entered data.

https://github.com/react-bootstrap-table/react-bootstrap-table2/issues/210

Fixed on<EMAIL_ADDRESS>check release note, thank!


[BUG] Error arrises for uninstalled browsers

Describe the bug
If the user has never installed a particular browser on his OS, then despite not having the browser, the package still tries to find the history file for that browser. A Example would be, if the user is using Linux as his OS and has not installed opera till date, then on running it raises the error,
INFO: Safari browser is not supported
INFO: Edge browser is not supported
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/royston/Documents/browser-history/browser_history/__init__.py", line 20, in get_history
    browser_output_object = browser_object.fetch()
  File "/home/royston/Documents/browser-history/browser_history/generic.py", line 173, in fetch
    copied_history_path = shutil.copy2(history_path.absolute(), tmpdirname)
  File "/usr/lib/python3.6/shutil.py", line 263, in copy2
    copyfile(src, dst, follow_symlinks=follow_symlinks)
  File "/usr/lib/python3.6/shutil.py", line 120, in copyfile
    with open(src, 'rb') as fsrc:
FileNotFoundError: [Errno 2] No such file or directory: '/home/royston/.config/opera/History'

To Reproduce
To reproduce with opera browser, uninstall opera and remove all its corresponding files
Linux : remove .config/opera
Windows : remove AppData/Roaming/Opera Software/Opera Stable
and run the following code:
from browser_history import get_history
output = get_history()

Expected behavior
Should state , the browser is not installed
Desktop (please complete the following information):

OS: [Linux]
browser-history Version [master]
Python version: [e.g. 3.8.3]

Additional context
This error can occur with any browser as long as its never been installed but is comaptible for that OS

The fix involves adding another except statement near this for FileNotFoundError and logging a appropriate message inside it.

Is anyone handling this one or should I go ahead?

The fix involves adding another except statement near this for FileNotFoundError and logging a appropriate message inside it.

I have realized there is more to the fix than just this. Your suggested only works when fetching all browsers but when i do something like browser-history -b opera in the CLI it still throws that error.
There are two options:

Catch the error in get_history as well as in cli.py
Catch the error inside generic.Browser.fetch, log the absence of the browser and return an empty list

@ObaraEmmanuel you are right, I didn't think of that.
I like the 2nd option as it saves repetitive code and that behaviour of the function is expected. (This should be documented in the docstring though)

On further digging, I have realized the best place to catch the error is actually in the generic.Browser.profiles method. Every other method seems to be starting from here and even when we come to implement functionality for cookies and bookmarks they will most likely begin with determining profiles.


[IMPROVE]: Contact page has bugs

Firstly, the font color of message box needs to be changed.
Secondly, a message needs to be displayed that details have been saved on updating.

I want to work on this issue. Please assign it to me and label it under GSSoC @codervivek5

I want to work on this issue. Please assign it to me and label it under GSSoC @codervivek5


deepcopy messes with my complex slot

Rasa Core version:
master from github:  0.9.0a6
Python version:
3.6.5
Operating system (windows, osx, ...):
Mac OS 10.13.4
Issue:
Tracker deepcopy messes with my complex slot
In my domain I have a slot that contains a complex object and I set it up as unfeaturized. Every now and then, the tracker insists on doing a deepcopy of all its slots, and when tries to do a deepcopy of this object, it fails eventually because __len__() gives an error. To get around this, instead of storing the object itself in the slot, I use pickle.dumps(obj) to convert it to a string, and store that in the slot. Obviously it would be good to avoid the back-and-forth pickling, so I'm wondering if there is some way I can prevent the tracker from doing a deepcopy of certain slots.

This is because sometimes we need to clone the tracker to do some operations without modifying the original copy. Do you know why a deepcopy doesn't work for your object?

The object is from another (open source) package, and during deepcopy, it eventually needs the __len__() of the object and it fails because __len__() is not defined.
You say that the tracker "sometimes" needs to be cloned. Is that behavior necessary or somehow modifiable? If not, I think cpickle.dumps/loads is fine for my purposes.


Updated Default Arguments

Updated default cli arguments so that the validator does not attempt to validate recursively all of the files in the current directory. Additionally updated csproj to enable users to pack and install as a tool and made modifications to documentation that reflect changes.

@microsoft-github-policy-service agree company="Microsoft"


gem install failed because of dependency error

I try to do gem install fluent-plugin-splunk-hec-1.2.1.gem (I download the gem directly from github).
I try to install on my server in the company I work in, the server is offline mode,
and I try to do the same on my windows computer (with internet) and I get the same error.
the ERROR:
ERROR:  While executing gem ... (Gem::DependencyError)
Unable to resolve dependencies: fluent-plugin-splunk-hec requires fluent-plugin-kubernetes_metadata_filter (~> 2.4.2), fluentd (>= 1.4), multi_json (~> 1.13), net-http-persistent (~> 3.1), openid_connect (~> 1.1.8), prometheus-client (< 0.10.0), activesupport (~> 5.2), http_parser.rb (= 0.5.3)

@TamirTevet Can you please clarify if you are getting the same error for all the 3 steps you mentioned? Can you please provide command and its output for all if they are diff?
Also, what version of Ruby are you running?

I get the same error all time.
I work with ruby 2.0.0p648 (I try to work with this version on my computer because I want that the version will be similar to the version in the server but I work with the latest version of ruby and get error that this too new version)

Hey @TamirTevet , are you still facing the issue ? Please let us know.

Hey, @TamirTevet You can directly install gem using: gem install -f fluent-plugin-splunk-hec -v 1.2.1 in your environment.
Currently, a stable version of fluent-plugin-splunk-hec is 1.2.9.

@TamirTevet Closing the issue. If you are still facing the issue, feel free to reopen this or create a new one.


sigil: 1.9.20 -> 1.9.30

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/Sigil-Ebook/Sigil/releases.
meta.description for sigil is: Free, open source, multi-platform ebook (ePub) editor
meta.homepage for sigil is: https://github.com/Sigil-Ebook/Sigil/
Updates performed

Version update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 1.9.30 with grep in /nix/store/mzqwbvcr0mdxhd4wavmdwva40vsm538w-sigil-1.9.30
found 1.9.30 in filename of file in /nix/store/mzqwbvcr0mdxhd4wavmdwva40vsm538w-sigil-1.9.30

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
sigil

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/mzqwbvcr0mdxhd4wavmdwva40vsm538w-sigil-1.9.30 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A sigil https://github.com/r-ryantm/nixpkgs/archive/8cddbf831867299e25aa664d9d78365d9f97d577.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/mzqwbvcr0mdxhd4wavmdwva40vsm538w-sigil-1.9.30
ls -la /nix/store/mzqwbvcr0mdxhd4wavmdwva40vsm538w-sigil-1.9.30/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.


nginx error    connect() to unix:/tmp/nginx-rtmp.25 failed (11: Resource temporarily unavailable)

Hello everyone:
Anybody know what to do with that？？？？？、
Error Message:
[error] 22287#0: connect() to unix:/tmp/nginx-rtmp.25 failed (11: Resource temporarily unavailable)
[error] 22287#0: *16126 auto_push: connect failed: slot=25 pid=22306 name='liverid15570177696394', client: <IP_ADDRESS>, server: <IP_ADDRESS>:1935
[error] 22287#0: *16126 auto_push: connect failed: slot=32 pid=22313 name='liverid15570177696394', client: <IP_ADDRESS>, server: <IP_ADDRESS>:1935

The value of macro NGX_LISTEN_BACKLOG used in ngx_rtmp_auto_push_module.c is 511, which is the number of accepted but not yet handled connections in a queue. 511 may be inadequate for numerous concurrent connections.

fixed this bug in another repo, hope can help others
https://github.com/winshining/nginx-http-flv-module/commit/c99270fee1844f922c3472f45252ad1f792e80dd


Allow subclassing/extending Bluebird promises

Related to https://github.com/petkaantonov/bluebird/issues/325
Please consider allowing devs to subclass/extend Bluebird promises.
Current error:
TypeError: the promise constructor cannot be invoked directly

    See http://goo.gl/MqrFmX

Example use case (in TypeScript):
import * as Promise from 'bluebird';

export class PromiseWhile<T> extends Promise<T> {
	private valueWrap: () => T;
	private result: Promise<T>;

	constructor(callback: () => PromiseLike<T>, value: T);
	constructor(callback: () => PromiseLike<T>, value: () => T);
	constructor(private callback: () => PromiseLike<T>, value: any) {
		super((resolve, reject) => {
			setTimeout(() => {
				if (this.result) {
					resolve(this.result);
				}
				this.resolve = resolve;
				this.reject = reject;
			});
		});
		if (typeof value === 'function') {
			this.valueWrap = value;
		}
		else {
			this.valueWrap = () => value;
		}
		setTimeout(() => {
			this.runCallback();
		});
	}

	// in case resolve gets called before promise is set up
	private resolve(value?: T | PromiseLike<T>) {
		if (this.result === undefined) {
			this.result = Promise.resolve(value);
		}
	}

	// in case reject gets called before promise is set up
	private reject(value?: any) {
		if (this.result === undefined) {
			this.result = Promise.reject(value);
		}
	}

	private runCallback() {
		Promise.resolve(this.callback()).then((rVal) => {
			if (rVal == this.valueWrap()) {
				setTimeout(() => {
					this.runCallback();
				});
			}
			else {
				this.resolve(rVal);
			}
		}).catch((error) => {
			this.reject(error);
		});
	}
}

Example usage:
// doNextAsyncThing returns a Promise
// which resolves to true when there's more to do and false there isn't
// or rejects on error
new PromiseWhile(() => {
	return doNextAsyncThing();
}, true).then(() => {
	console.log('done doing async things');
}).catch((err) => {
	console.log('failed during async loop');
	console.trace(err);
});

Also, the example code works find if I remove  || self.constructor !== Promise from https://github.com/petkaantonov/bluebird/blob/master/src/promise.js#L62

This functionality sounds much like something that should be implemented as a function that returns an ordinary promise, not by subclassing Promise.

I agree. It's probably a bad example. However, I think subclassing/extending bluebird promises should be allowed. We're all devs here...

You should use scoped prototypes instead of subclassing to add functionality

But why does your library explicitly block subclassing and extending? That seems really silly. Let the developers be in control. I don't see any valid reason to do this.

I just ran into this issue trying to use child-process-promise in combination with Bluebird. Now I admit I do use global.Promise = require('bluebird') at the start of program, which might be considered bad practice, but then again, Bluebird should be a drop-in replacement for ES6 Promises, whereas this issue causes it not to be.

This basically prevents Bluebird to be used as a generic polyfill for ES6 Promises.

Yes, it really does. It seems like some really arbitrary rule created and enforced by the bluebird developers. There's really no good reason for it. Let developers be developers.

Bluebird is over 3 years old at this point and was created in a different era of JavaScript. For whatever reason, @petkaantonov is either unable or unwilling to continue pushing this library forward. This is certainly acceptable and understandable; people's lives and priorities change and he holds no blame or responsibility in my opinion.
Bluebird was once extremely innovative and far ahead of its time, but I fear this is no longer the case. JavaScript engines and the JavaScript ecosystem have evolved. There are many issues with Bluebird's interoperability with modern build tools, practices and paradigms (webpack, ES6+, tree-shaking, etc.) that I don't see ever being fixed within Bluebird due to either ideological reasons ("You should use scoped prototypes instead of subclassing to add functionality") or just plain apathy.
Other than small bug fixes, I think it is safe at this point to consider Bluebird "finished".

@tyscorp thanks for the comment.
bluebird is still faster than native promises, the v8 team uses it in benchmarks as promises are optimized - it's no secret that the eventual aim is to put ourselves out of business.
Both me and Petka are Node.js core and want to see native promises faster - there are discussions with engine developers (you can watch those at the Node and nodejs/promises repo) and things should get faster.
Bluebird is still incredibly stable and fast - it's de-facto the only choice for older browsers and older Node in my opinion. The utility methods are still very nice (native promises just got .finally).
Now that's out of the way, let's move to subclassing.

The subclassing issue: I believe there is absolutely no reason to subclass promises. This is not "ideological" as much as it is using promises for a wide variety of problems in a wide variety of settings.
I've discussed it with the people who specified the subclassing of promises in ECMAScript and they had the same idea. It sounded like a very interesting idea at first but I think everyone agrees that complicating the spec for it wasn't really worth it.
Subclassed promises are also significantly slower than native promises last time I checked in engines since they're so uncommon and there is little motivation to use them.
The main reason is that no matter what you do - an async function will still return the base class, coroutines will still return the base class and so will every language construct or API using promises.
Bluebird "won", promises have won, promises are more popular than callbacks and not in the fridge anymore. The future is async/await, async iteration and clean asynchronous flows.
I still use bluebird when I care about server performance, bluebird is still very compelling for other libraries to use - and Node.js apps. We've basically been adding or pitching bluebird features for native promises for the past few years and things that bluebird did like asynchronous stack traces, finally, unhandled rejection tracking and more have become standardized and adopted.
I'm not sure bluebird is 'finished', but I agree it's more in maintenance mode than in "adding features" mode.
ES6+ is still not optimized in some scenarios as well (although it's been getting much better since TF), tree shaking isn't needed since bluebird has its own partial build system which you can use instead and then require it with webpack. (If we're fair, tree-shaking in webpack doesn't work well yet anyway). One thing it's not is "apathy" :)

This is literally the only line preventing extending Bluebird promises. If I remove this check, I'm able to extend and use Bluebird promises as expected.
https://github.com/petkaantonov/bluebird/blob/053d02ef3538708f3679705588d8319ca56c6b88/src/promise.js#L62


fix: wrong info shown if creating group with desc order emails

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/22118
PROPOSAL: https://github.com/Expensify/App/issues/22118#issuecomment-1618633402
Tests

Open app and click FAB to create group
Search email<EMAIL_ADDRESS>and select it
Search another email<EMAIL_ADDRESS>and select it
Click create group button to create group
In the group chat, click welcome message email<EMAIL_ADDRESS>Verify that it opens the profile page of<EMAIL_ADDRESS>Click welcome message email<EMAIL_ADDRESS>Verify that it open the profile page of<EMAIL_ADDRESS>

[X] Verify that no errors appear in the JS console

Offline tests

Same as tests
QA Steps

Same as tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://github.com/Expensify/App/assets/117511920/f119442d-80fb-4fc0-ae52-de29c836ee69

Mobile Web - Chrome

https://github.com/Expensify/App/assets/117511920/0213a117-f1b6-4cf2-99ed-8018cb713ce0

Mobile Web - Safari

https://github.com/Expensify/App/assets/117511920/2e988221-8ce6-4643-b86f-3b33dfe385db

Desktop

https://github.com/Expensify/App/assets/117511920/7660f7dc-2e07-4abc-baa6-4d15d5e7fa29

iOS

https://github.com/Expensify/App/assets/117511920/ca4b65d6-9339-4b18-8adf-146a7e3fe138

Android

https://github.com/Expensify/App/assets/117511920/870717b4-d8dd-462f-b2a3-b720b09ec069

Friendly bump @Santhosh-Sellavel

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop
https://github.com/Expensify/App/assets/85645967/49e1d0fe-6836-40c0-9493-00a70f4565d5

Mobile Web - Chrome & Mobile Web - Safari
https://github.com/Expensify/App/assets/85645967/b52b48f2-1ba0-477b-83fd-58ef65dd4495

iOS & Android
https://github.com/Expensify/App/assets/85645967/fa30e038-b0de-498e-af8d-966998d716f5

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.42-0 🚀

platform
result

🤖 android 🤖
cancelled 🔪

🖥 desktop 🖥
cancelled 🔪

🍎 iOS 🍎
cancelled 🔪

🕸 web 🕸
cancelled 🔪

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Fix/pubkey

Fixed generation of the extension ID from the manifest file
Fixed the pubkey command
Some improvements for crx3/commands/*

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

65 of 77 (84.42%)  changed or added relevant lines in 4 files are covered.
20 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-1.2%) to 73.672%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

id.go
30
32
93.75%

pubkey.go
3
5
60.0%

extension.go
28
36
77.78%

Files with Coverage Reduction
New Missed Lines
%

pack.go
20
55.67%

Totals

Change from base Build<PHONE_NUMBER>:
-1.2%

Covered Lines:
652

Relevant Lines:
885

💛  - Coveralls


UserAgentMiddleware Working in Django 1.10

Fix #13

It would be great to see this merged and released.
In the mean time, you can write your own middleware that does the same thing:
from django.utils.functional import SimpleLazyObject
from django_user_agents.utils import get_user_agent

def user_agent_middleware(get_response):
    def middleware(request):
        request.user_agent = SimpleLazyObject(lambda: get_user_agent(request))

        return get_response(request)

    return middleware

I have it installed from pip.
Now how do I make the necessary changes for the middleware to work?
I am not able to locate the django_user_agents/middleware.py

@digi0ps if you are using Django 1.10 just create your own Middlaware Class and references in MIDDLEWARE settings instead of django_user_agents.middleware.UserAgentMiddleware
Custom middleware:
from django.utils.deprecation import MiddlewareMixin
from django_user_agents.middleware import UserAgentMiddleware

class CustomUserAgentMiddleware(MiddlewareMixin, UserAgentMiddleware):
    pass

settings.py
MIDDLEWARE = [
    # other middlewares...
    'path.to.your.own.file.CustomUserAgentMiddleware',
]

@dannyboscan Thanks a lot, it worked. 👍

Sorry for the delayed response. Does this PR still fixes problems on Django 1.10 and 1.11 or do we need to consider anoher approach? I can make a PyPI release sometime this week if we have a reliable fix for newer versions of Django.

Still work in Django 1.11


Ubuntu 14.04 installation

I'm trying to install mutate from ppa in Ubuntu 14.04 but I'm getting an error for missing libboost-regex1.55-dev. I've tried to install libboost-all-dev as I read somewhere but still the same error.

hi @ziggy42 i installed though the PPA,, and got all what is need. After that i compiled without any problem. Maybe not the answer you where looking for , but hope that helps

I had the same error, I've just added the exact package which was missing libboost-regex1.55-dev and later on it asked for another one, and than it worked - until I got an error that g++ is missing, so I suggest you to also install the build-essentials if you don't have them yet, to make sure, the package can compile


Improve the Mission Statement

A mission statement should be short and sweet and describe the primary goal or reason for the Foundation's existence. We can elaborate in a vision statement.
Discussion
Comments for this are here: https://github.com/dotnet-foundation/website/pull/158

Updated issue comming.


Tap and move slider

I want to move the slider by tapping on the slider not just sliding by the marker. I can't find any prop or default settings to do it. Please can you help asap.

@ptomasroos, Any plan on implementing this feature?!!! Tapping is a much more accepted UX than select'n move; and so every range slider should have.

can you wrap your slider and handle onPress to move to next value?

good to hear there is progress on this issue. @ptomasroos did you already succeed to clean up the state to enable tapping?

any progress on this issue?


[ldd-img] segment_count check

Got this validation error:
      ERROR  [error.label.schematron]   line 1427, 34: IMG:error:icer_comprs_segment_check: img:ICER_Parameters/img:segment_count must match the number of img:Image_Compression_Segment classes.

That's fine... except in this case there are NO ICS classes, because we have no additional information.  Before, we had an ICS with nothing but the segment number, which seemed silly.  So please update this check to say the number of ICS classes must match segment_count OR be 0.
(if you can't do that, then just remove the check).

I update the rule, hopefully this works:
<rule_test>(count(img:Image_Compression_Segment) = img:segment_count) or (count(img:Image_Compression_Segment) = 0)</rule_test>


Add in license parsing to PomParser

I've had an idea I've been playing around with lately about using Coursier for license reporting. I noticed they Ivy parsing seemed to be there, but not the Pom. This adds in license parsing to the PomParser.
One thing to note is that currently in Info licenses are modeled as (String, Option[String]) since in Ivy there is just a name and url. In Maven it seems that there can also be a distribution and comments. Do you think those should be added in right away and licenses changed in Info to a case class like:
case class License(
  name: String,
  url: Option[String],
  distribution: Option[String], // this would be maven only
  comments: Option[String] // this would be maven only
)

Let me know your thoughts!

Do you think those should be added in right away and licenses changed in Info to a case class like:

These can definitely be added. (This would be a @data class License rather than a case class License.)
I think the only tricky point would be maintaining binary compatibility for Info.licenses. It should be possible to

remove licenses
add a new licenseDetails say (or any other name), and
add

a compatibility constructor,
an apply method, still accepting licenses as Seq[(String, Option[String])], and
a def licenses: Seq[(String, Option[String])] = licenseDetails.map(…).

By adding licenseDetails in last position, the compatibility constructor and apply method shouldn't conflict with the generated ones.

I can take care of adding the compatibility stuff at the end, if you'd like.

I can take care of adding the compatibility stuff at the end, if you'd like.

I'll take a stab

~remove licenses~
~add a new licenseDetails say (or any other name), and~
add
a compatibility constructor,
~an apply method, still accepting licenses as Seq[(String, Option[String])], and~
~a def licenses: Seq[(String, Option[String])] = licenseDetails.map(…).~

So I think the only think I may be missing is compatibility constructor, but I'm a bit unsure what you mean by this. Could you elaborate? Thanks

@ckipp01 The CI points at the missing methods / constructors: it wants a withLicenses method accepting licenses with the former type (this method was generated from the licenses field by data-class), and a constructor (a def this(…)) with the same signature as the former one.

Alright, thanks for the pointers. I haven't worked with Mima before, so it was cool to dive into that some. Everything looks happy now.

Merging, thanks @ckipp01!


HTTP 500 response for request with invalid chunked body

Welcome!

[X] Yes, I've searched similar issues on GitHub and didn't find any.
[X] Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you do?

Bring up Traefik and the whoami service as described in the Getting Started guide.

Run the following:
$ nc -C localhost 80
POST / HTTP/1.1
Host: whoami.docker.localhost
Transfer-Encoding: chunked

X

Since this is an invalid chunked encoding, I would expect to see a 400 response.

What did you see instead?
The response is as follows:
HTTP/1.1 500 Internal Server Error
Date: Sun, 15 Sep 2024 23:44:23 GMT
Content-Length: 21
Connection: close

Internal Server Error

What version of Traefik are you using?

Docker 27.1.1 on Ubuntu 22.04.
If applicable, please paste the log output in DEBUG level
This seems relevant:
2024-09-15T23:53:54Z DBG github.com/traefik/traefik/v3/pkg/server/service/proxy.go:100 > 500 Internal Server Error error="invalid byte in chunk length"

Hey @SpecLad,
Thanks for the report, we will work on the issue to reproduce and fix.
We'll keep you updated when we move forward on it.

I've also seen this behaviour in our production logs. It's an unexported error that can arise in the httputil.ReverseProxy implementation and in fact I applied a little workaround (sorry, still on v2.11.X branch) here:
https://github.com/traefik/traefik/blob/8eadfbb9906ddf06d150f1d2f77f278514ed8fff/pkg/server/service/proxy.go#L87-L92
case err.Error() == "invalid byte in chunk length": // XXX: net/http/internal/chunkedReader unexported error
        statusCode = http.StatusBadRequest

The standard library error source is actually from here:
https://github.com/golang/go/blob/592da0ba474b94b6eceee62b5613f1c9c1ed9c89/src/net/http/internal/chunked.go#L265-L287
and there are a few errors that look like they could arise. I've only added a case for this specific one since that's all I've observed but I expect a sufficiently persistent vulnerability scanner / fuzzer would eventually trigger the other cases too.


Colorize brush 1px

create a brush whit 1px

That is not possible on a game boy color, palettes are per 8x8 tile only.


fix: handle numeric array elements in .orderBy()

Fixes #5525.

Coverage: 92.837% (+0.0007%) from 92.836% when pulling 5e0baf245337e42c1ce72c5ebeba67ac94ea50a9 on LukeNotable:fix-numeric-order-by into 704d12e9ba2271ac7b368c7aa7113ff72c88d3d8 on knex:master.

@LukeNotable seems master CI is broken, I will try to fix it quickly before merge that


Disabled Nullability tests

https://github.com/aspnet/AspNetCore/pull/11818 disables the following tests due to ingesting the new Roslyn compiler, which changes some nullability metadata:
CanUseNonNullableReferenceType_WithController_OmitData_ValidationErrors
BindProperty_WithNonNullableReferenceType_NoData_ValidationError
BindProperty_WithNonNullableReferenceType_NoData_ValidationError_CustomMessage
BindParameter_WithNonNullableReferenceType_NoData_ValidationError
CreateValidationMetadata_InfersRequiredAttribute_NoNonNullableProperty
IsNonNullable_FindsNonNullableProperty
IsNonNullable_FindsNonNullableParameter
We should look into what's needed to re-enable these.
CC @dougbu @rynowak

Fixed by: https://github.com/aspnet/AspNetCore/pull/12202


Cannot find module 'jspdf' or its corresponding type declarations

I'm using VueJS with Typescript. I've just installed v2.3.1 and imported it using
import { jsPDF } from "jspdf";

export default Vue.extend({
   methods: {
       async print(): Promise<void> {
          const doc = new jsPDF(); // this line throws a compile error "Can't resolve 'jspdf'"
      },
   }
})

But this has produced the following errors
Cannot find module 'jspdf' or its corresponding type declarations.
frontend       |     246 | import { mapGetters } from "vuex";
frontend       |     247 | import Vue from "vue";
frontend       |   > 248 | import { jsPDF } from "jspdf";

I didn't think I needed to but I tried anyway installing the @types/jspdf package but that hasn't resolved the issue.
Again didn't think I would need to but I thought I'd try it anyway, I created a index.d.ts file, and import in my tsconfig.json, nothing has worked. I've since removed those.
This dependency was not found:
frontend       |
frontend       | * jspdf in ./node_modules/cache-loader/dist/cjs.js??ref--14-0!./node_modules/babel-loader/lib!./node_modules/ts-loader??ref--14-2!./node_modules/cache-loader/dist/cjs.js??ref--0-0!./node_modules/vue-loader/lib??vue-loader-options!./src/views/htmlToPDF.vue?vue&type=script&lang=ts&
frontend       | No type errors found
frontend       | Version: typescript 4.2.3

The package appears to be installed, I can ctrl+left click on the package name and read the package's index.d.ts file.
Any suggestions?
Thank you

That's odd. Usually, all you need to do is npm install jspdf and import { jsPDF } from 'jspdf' to load jspdf. Installing @types/jspdf is not necessary (and they are outdated, btw).
Could you share a complete repro, please?

That's odd. Usually, all you need to do is npm install jspdf and import { jsPDF } from 'jspdf' to load jspdf. Installing @types/jspdf is not necessary (and they are outdated, btw).
Could you share a complete repro, please?

Hi, thank you for replying, unfortunately I am not permitted to share our repo. Do you know of any code playgrounds I could try and replicate the issue for you on?


correct block channels behaviour in auto mode by default in YDB

There is a couple of problems left from our side:

[ ] Print correct column names in the query plan.
[ ] Fix tests expecting the "Collect" stage name in the query plan.

Should mention to not forget that the query plan with wide channels differs from narrow one - at least the "Filter" node is missing.


Quantum addition using ApplyAnd

Describe the solution you'd like
A ripple-carry adder using the ApplyAnd or ApplyLowDepthAnd operations as described in Fig. 1 in Halving the cost of quantum addition.
Describe alternatives you've considered
Updating RippleCarryAdderD to use ApplyAnd.

Hey is this issue about replacing the CCNOT gates with ApplyAnd in RippleCarryAdderD or implementing the circuit given in Fig. 1 which does not compute the Carry out bit?

I suppose that RippleCarryAdderD could be updated. However, it's not just replacing existing CCNOT since the current implementation used two CCNOT for each Carry, where only one is necessary. It also should support a Carry bit, unlike the figure in the paper.


Update cats-retry-cats-effect, ... to 0.3.2

Updates

com.github.cb372:cats-retry-cats-effect
com.github.cb372:cats-retry-core

from 0.3.0 to 0.3.2.
Release Notes/Changelog
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.cb372" } ]

labels: semver-patch

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   93.22%   93.22%
=======================================
  Files           1        1
  Lines          59       59
=======================================
  Hits           55       55
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8227f50...4115951. Read the comment docs.


⚠ Game Join API Endpoint has degraded performance

In 8970d5e, Game Join API Endpoint (http://gamejoin.roblox.com/) experienced degraded performance:

HTTP code: 503
Response time: 1190 ms

Resolved: Game Join API Endpoint performance has improved in 3eaa432 after 25 minutes.


workspace module padding issue

this popped up after pulling the latest changes
the last workspace icon gets cut when the show workspace icons is enabled

Could you restart AGS and see if it persists? I'm trying to replicate it on my machine but having no success.
May I know what Font, Font-Size and Resolution you're on?
Additionally, could you run git show and provide the commit hash?

restarted ags with pkill ags and then ags and it persists
In nwg look I have Cantarell Regular with size 10 and in the ags bar configuration it is 1.0rem
My resolution is 1366x768 on a 15'' laptop
output of git show :
commit a8d3bd286ab5cd88147549d88056a77b156de2e1 (HEAD -> master, origin/master, origin /HEAD)

Perfect, just replicated it. Will get a fix soon.


IMPALA Example

Would it too hard to add a working example of the cool IMPALA Trainer?
Also, how do you hook IMPALA to custom Envs and Actors?
Thanks in advance!

Meanwhile you can find IMPALA here: https://github.com/deepmind/scalable_agent

at this point dopamine does not include an implementation of impala. see deepmind's open source implementation linked above.