Identifier documentation needs to be updated.

In the Identifier textbox, type a URL using the following pattern: https://weekdone.com/a//metadata
in addition the metadata file from weekdone can be retrieved with using the same URL

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2045fd47-0d78-4050-b41d-8e39f3d75252
Version Independent ID: 833cff6a-5de0-8511-dc8f-d8f2b8abcfd3
Content: Tutorial: Azure Active Directory integration with Weekdone
Content Source: articles/active-directory/active-directory-saas-weekdone-tutorial.md
Service: active-directory
GitHub Login: @jeevansd
Microsoft Alias: jeedes

@chetansriv and @v-nagta can you please make this change?
thanks.

@lyyeh This url https://weekdone.com/a//metadata is not accessible, are you sure that metadata can be downloaded from this URL? Are we missing any bit in this URL, I mean this seems to be a static URL not a pattern? Please confirm.
cc: @jeevansd @v-nagta

It should be
https://weekdone.com/a//metadata
Where tenant is the variable.

Lee Yeh

From: Chetan<EMAIL_ADDRESS>Sent: Thursday, May 17, 2018 9:55:58 AM
To: MicrosoftDocs/azure-docs
Cc: lyyeh; Mention
Subject: Re: [MicrosoftDocs/azure-docs] Identifier documentation needs to be updated. (#8711)
@lyyehhttps://github.com/lyyeh This url https://weekdone.com/a//metadata is not accessible, are you sure that metadata can be downloaded from this URL? Are we missing any bit in this URL, I mean this seems to be a static URL not a pattern? Please confirm.
cc: @jeevansdhttps://github.com/jeevansd @v-nagtahttps://github.com/v-nagta
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/MicrosoftDocs/azure-docs/issues/8711#issuecomment-389936283, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ARuIVzWfgwyumfqsSdjcHlaE1QJRaAR7ks5tzauegaJpZM4UBpFa.

@lyyeh This is fixed, can you please confirm.
#please-close

@lyyeh We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.


Troubleshooting guide refers to OTPHelper

As far as I can remember, the new guide doesn't use OTPHelper at all. I believe this should be referring to Hourglass9/Decrypt9WIP, rather than OTPHelper

fixed


refactor merging of non-unique inputs

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.71%. Comparing base (c189302) to head (89bd51c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   90.62%   90.71%   +0.08%
==========================================
  Files          19       19
  Lines        2764     2767       +3
==========================================
+ Hits         2505     2510       +5
+ Misses        259      257       -2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Don't capture keyDown if sliderValue isn't set

This is a change which allows for greater keyboard accessibility. Currently, e.preventDefault() is always called, regardless of whether we used an arrow key, or whether there is an  onChange handler. This stops us from using Tab to move focus to another control outside this component (it's effectively trapped until we blur using a pointer input).
I've tried my best to fit your code style (exit early).

👍


Allow using Pydantic v2

The latest version of FastAPI (v0.100.0) supports Pydantic v2.

https://docs.pydantic.dev/2.0/

I'd like to use redis-om-python with Pydantic v2 while keeping the compatibility.
This PR does:

Allow using Pydantic v2 (pydantic = ">=1.10.2,<2.1.0")
Add _compat.py file to import proper Pydantic classes, etc.

Do from pydantic import ... if Pydantic is v1
Do from pydantic.v1 import ... if Pydantic is v2 (Note: Pydantic v2 contains v1 in v1 module)

It allows using Pydantic v2 along with redis-om-python.

There are lint & dependency audit errors.
I'm sure the lint error is out of the scope of this PR.
/home/runner/.local/bin/poetry run mypy ./tests/ aredis_om redis_om --ignore-missing-imports --exclude _compat\.py$
redis_om/model/cli/migrate.py:6: error: Argument 1 has incompatible type "Callable[[Any], Any]"; expected <nothing>
aredis_om/model/cli/migrate.py:6: error: Argument 1 has incompatible type "Callable[[Any], Any]"; expected <nothing>

I'm not sure about the audit error. Could you help me to fix the issue, please? (If this PR looks good)

Codecov Report
Patch coverage: 68.42% and project coverage change: -0.33 :warning:

Comparison is base (70f6401) 78.94% compared to head (099ca96) 78.61%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
- Coverage   78.94%   78.61%   -0.33%
==========================================
  Files          14       15       +1
  Lines        1178     1188      +10
==========================================
+ Hits          930      934       +4
- Misses        248      254       +6

Flag
Coverage Δ

unit
78.61% <68.42%> (-0.33%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

aredis_om/_compat.py
60.00% <60.00%> (ø)

aredis_om/model/encoders.py
50.70% <100.00%> (-0.69%)
:arrow_down:

aredis_om/model/model.py
87.03% <100.00%> (-0.06%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@ninoseki I've merged master in accordingly.

Thanks and please let me know if I need additional works on this PR.

given the opt in nature - and the pydantic changes.. it seems very clean.


Add dense_rank and percent_rank Presto window functions

https://github.com/facebookincubator/velox/issues/685


UCIS: coverpointBin requires "key" attribute

Hi,
according to the UCIS 1.0 standard, section 9.8.6 on page 211, the coverpointBin element lists the key attribute as required, but fc4sc does not produce it.
(Note that their "complete" XML schema in section 9.14 has an error in that both the name and key attributes are missing there, but the part that they show in 9.8.6 has them.)
(Pinging @MarkTakaWilliams since he appears to have done XML validation work too.)

I apologize for piling on your comment without helping.  I've noticed this repo does not have a discussion section configured.
With that said, regarding the xml coverage report output, is there a forum someplace or mailing list to discuss parsing the xml?

Ahh, I got a response via this forum. https://forums.accellera.org/forum/38-systemc-verification-uvm-systemc-scv/


CLI: pac package show & pac package deploy fails when pac auth not initialised

Hi,
I received the following error when running pac package show -p package.dll
PS C:\pac\> pac package show -p package.dll
Sorry, the app encountered a non recoverable error and will need to terminate. The exception details have been captured and will be forwarded to the development team, if telemetry has been enabled. Exception Id: 2e55cfa8-59a0-487d-9af5-46cd6b425add, Exception Type: System.NullReferenceException
The diagnostic logs can be found at: C:\Users\<name>\AppData\Local\Microsoft\PowerAppsCLI\Microsoft.PowerApps.CLI.1.25.5\tools\logs\pac-log.txt

An error also occurs when using pac package deploy -p package.dll
PS C:\pac\> pac package deploy --package package.dll
Microsoft PowerPlatform CLI
Version: 1.25.5+g24fc1f8
Online documentation: https://aka.ms/PowerPlatformCLI
Feedback, Suggestions, Issues: https://github.com/microsoft/powerplatform-build-tools/discussions

Error: Object reference not set to an instance of an object.

Usage: pac package deploy [--logFile] [--logConsole] --package [--settings] [--verbose]

  --logFile                   Log file path (alias: -lf)
  --logConsole                Output log to console (alias: -c)
  --package                   Path to a package dll or zip file with a package. (alias: -p)
  --settings                  Runtime Package Settings that are passed to the package that is being deployed. The format of the string must be `key=value|key=value`. (alias: -s)
  --verbose                   Emit verbose logs to the log outputs. (alias: -vdbg)

This error is present on version 1.23.3 onwards, is not present on 1.22.4
It also looks like that when pac auth create --url <environment> is used prior, the error does not appear and the functionality works as expected, however, in versions 1.22.4 and prior, this correctly alerted the user to connect to an environment:
PS C:\pac> pac package show -p package.dll
Microsoft PowerPlatform CLI
Version: 1.22.4+gfad5a46

Error: No profiles were found of kind DATAVERSE, UNIVERSAL on this computer. Please run 'pac auth create --kind DATAVERSE' to create one.

Usage: pac package show --package [--logFile] [--verbose]

  --package                   path to a package dll or zip file with a package (alias: -p)
  --logFile                   Log file path (alias: -lf)
  --verbose                   Emit Verbose logs to the log outputs (alias: -vdbg)

Stacktrace from pac-log.txt
2023-08-03 09:19:36.8268 | INF | bolt.Session :: Product Version: 1.25.5+g24fc1f8; File Version: 1.25.5
2023-08-03 09:19:36.8693 | INF | bolt.Session :: Start new session. (sessionId: d7d38e48-a62d-4618-b227-45158c095dfe; operationId: 026abff42b4401130c71f643150de9a9; userId: c1bc9c34-fb8b-4989-88d6-06cff08819a5)
2023-08-03 09:19:37.2661 | INF | bolt.cli.CommandProcessor :: StartExecutingVerb (Verbs: ["package","show"])
2023-08-03 09:19:37.2841 | INF | bolt.cli.Verb :: Executing 'show' verb
2023-08-03 09:19:37.3495 | INF | bolt.module.package.PackageDeployment :: Initializing package deployment
2023-08-03 09:19:37.3554 | INF | bolt.module.package.PackageDeployment :: Initializing logging
2023-08-03 09:19:37.3883 | INF | bolt.module.package.PackageDeployment :: Setup authentication
2023-08-03 09:19:37.3883 | INF | bolt.authentication.profiles.FileBasedAuthProfilesManager :: ReadSettings(): No settings file found, creating a default one
2023-08-03 09:19:37.3883 | INF | bolt.authentication.profiles.FileBasedAuthProfilesManager :: GetCurrent(): For Kind 'DATAVERSE'.
2023-08-03 09:19:37.3883 | INF | bolt.authentication.profiles.FileBasedAuthProfilesManager :: GetCurrent(): For Kind 'UNIVERSAL'.
2023-08-03 09:19:37.4153 | INF | bolt.cli.CommandProcessor :: EndExecutingVerb (Success: False, Execution Time(ms): 139)
2023-08-03 09:19:37.4512 | FTL | bolt.Session :: Object reference not set to an instance of an object.|EXCEPTION: System.NullReferenceException: Object reference not set to an instance of an object.
   at bolt.module.package.PackageDeployment.Run()
   at bolt.module.package.verbs.ShowVerb.Execute(IContext context, Command command)
   at bolt.cli.LegacyVerbExecuteFn.<>c__DisplayClass3_0.<.ctor>b__0(IContext context, Command command, CancellationToken cancellationToken)
   at bolt.cli.LegacyVerbExecutor.ExecuteAsync(IContext context, Command command, CancellationToken cancellationToken)
   at bolt.cli.Verb.<>c__DisplayClass11_0.<<RunVerbExecutorAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at bolt.cli.Verb.<RunVerbExecutorAsync>d__11.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at bolt.cli.Verb.<ExecuteWithOutputAsync>d__9.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at bolt.cli.Verb.Execute(IProcessCommandContext context, Command command, Queue`1 nextCommands)
   at bolt.cli.CommandProcessor.ProcessCommands(Queue`1 commands, IVerbFactory factory)
   at bolt.cli.CommandProcessor.LaunchCommand(IReadOnlyList`1 args, UserHelpText userHelpText, Boolean isNonInteractiveModeEnabled)
   at bolt.Session.Run(ProgramArguments args)
2023-08-03 09:19:37.4512 | ERR | bolt.Session ::    at bolt.module.package.PackageDeployment.Run()
   at bolt.module.package.verbs.ShowVerb.Execute(IContext context, Command command)
   at bolt.cli.LegacyVerbExecuteFn.<>c__DisplayClass3_0.<.ctor>b__0(IContext context, Command command, CancellationToken cancellationToken)
   at bolt.cli.LegacyVerbExecutor.ExecuteAsync(IContext context, Command command, CancellationToken cancellationToken)
   at bolt.cli.Verb.<>c__DisplayClass11_0.<<RunVerbExecutorAsync>b__0>d.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at bolt.cli.Verb.<RunVerbExecutorAsync>d__11.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at bolt.cli.Verb.<ExecuteWithOutputAsync>d__9.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at bolt.cli.Verb.Execute(IProcessCommandContext context, Command command, Queue`1 nextCommands)
   at bolt.cli.CommandProcessor.ProcessCommands(Queue`1 commands, IVerbFactory factory)
   at bolt.cli.CommandProcessor.LaunchCommand(IReadOnlyList`1 args, UserHelpText userHelpText, Boolean isNonInteractiveModeEnabled)
   at bolt.Session.Run(ProgramArguments args)
2023-08-03 09:19:37.4671 | INF | Microsoft.PowerPlatform.Tooling.BatchedTelemetry :: BatchedTelemetryChannel.FlushBufferToDisk Saving 9 items to transmission file.
2023-08-03 09:19:37.6208 | INF | Microsoft.PowerPlatform.Tooling.BatchedTelemetry :: BatchedTelemetryChannel.StartUploadProcess Started uploader with process id: 10956
2023-08-03 09:19:37.6208 | INF | bolt.Session :: End session. (ResponseCode: 500)

@TDX-RB
Thanks for your feedback, but issues for this repo need to be about feedback on the documentation.
We can't provide technical support. Please contact support to report issues you experience.
While @snizar007 may be interested to hear of this error, there is nothing we can do in the documentation to fix this.


Force year format when user enter different digits on year (YY > YYYY)

If the specified format is yyyy but user enters an year using other digits, this is converted to 2XXX to respect the yyyy format.
f.e. 1 > 2001, 15 > 2015
Issues: #1457 #1446

Tests should be updated too to respect the specified date format
Invalid formats are force-parsed into a valid date on tab:
equal(this.input.val(), '2056-September-30');

Many people would expect 90's years to be converted to the 20th century, maybe even the 80's...
Where to draw a line ?
To be honest, I am totally against this.
Everyone agrees that setYear allowing to change year 0-99 to 1900-1999 was a mistake, MSDN and MDN discourage it usage, Chrome already removed this behavior.
This could be an option maybe, but definitely not a default behavior.


tests: Fix NonCoherentMemoryMapping test

New validation checks caused failures in this older LVT on the Pixel-C under Android.  Updated to use better Vulkan.
@cnorthrop, can you see if this fixes the Pixel issues?

PixelC still gets the original error.
I also getting the following on a number of platforms:
[ RUN      ] VkPositiveLayerTest.NonCoherentMemoryMapping
Unexpected: vkFlushMappedMemoryRanges: Flush/Invalidate size or offset (4092, 4089) exceed the Memory Object's upper-bound (20). For more information refer to Vulkan Spec Section '10.2.1. Host Access to Device Memory Objects' which states 'If size is not equal to VK_WHOLE_SIZE, offset and size must specify a range contained within the currently mapped range of memory' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#VkMappedMemoryRange)
/home/buildbot/LVL-buildbot/LVL-ubuntu-slave/dev_ubuntu_android/build/build-android/jni/../..//tests/layer_validation_tests.cpp:16718: Failure
Value of: err
Actual: -1000011001
Expected: VK_SUCCESS
Which is: 0
UNKNOWN_RESULT
ObjectTracker(ERROR): object: 0x2 type: 8 location: 347 msgCode: 3: OBJ ERROR : For device 0xef8c1640, Device Memory object 0x2 has not been destroyed.
MEM(ERROR): object: 0x2 type: 8 location: 4518 msgCode: 7: Mem Object 0x2 has not been freed. You should clean up this memory by calling vkFreeMemory(0x2) prior to vkDestroyDevice().
[  FAILED  ] VkPositiveLayerTest.NonCoherentMemoryMapping (29 ms)

@cnorthrop, can you give this set a shot?  It worked on our android system here but the local farm is wonky today.

Everything but PixelC is cleared up now.  Still seeing the original failure though:
[ RUN      ] VkPositiveLayerTest.NonCoherentMemoryMapping
Unexpected: vkFlushMappedMemoryRanges: Offset in pMemRanges[0] is 0xd, which is not a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize (0x40). For more information refer to Vulkan Spec Section '10.2.1. Host Access to Device Memory Objects' which states 'offset must be a multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#VkMappedMemoryRange)
Unexpected: vkFlushMappedMemoryRanges: Flush/Invalidate offset (13) is less than Memory Object's offset (320). For more information refer to Vulkan Spec Section '10.2.1. Host Access to Device Memory Objects' which states 'If size is equal to VK_WHOLE_SIZE, offset must be within the currently mapped range of memory' (https://www.khronos.org/registry/vulkan/specs/1.0-extensions/xhtml/vkspec.html#VkMappedMemoryRange)
/home/buildbot/LVL-buildbot/LVL-ubuntu-slave/dev_ubuntu_android/build/build-android/jni/../..//tests/layer_validation_tests.cpp:16702: Failure
Value of: err
Actual: -1000011001
Expected: VK_SUCCESS
Which is: 0
UNKNOWN_RESULT
ObjectTracker(ERROR): object: 0x2 type: 8 location: 347 msgCode: 3: OBJ ERROR : For device 0x7c247ad000, Device Memory object 0x2 has not been destroyed.
MEM(ERROR): object: 0x2 type: 8 location: 4518 msgCode: 7: Mem Object 0x2 has not been freed. You should clean up this memory by calling vkFreeMemory(0x2) prior to vkDestroyDevice().
[  FAILED  ] VkPositiveLayerTest.NonCoherentMemoryMapping (819 ms)

@cnorthrop, I feel good about this one -- totally missed the 13.  Also updated size to a multiple of atom_size as Chris Suggested.

That worked - thanks Mark!

Pushed to Master.


Integration Testing, Round 2

This PR supersedes #15 and #17 and contains the work of #17, with the additions of thousands of test files removed.
This PR will remain a draft until we can bring the new repo of test data online.

This is now ready for review, but we should get #22 and #29 merged in first (for bug fixes and other improvements).
This currently does not use a cache, but it is using the sparse checkout option. Each instance only pulls the testing files required for each individual test. So far that seems to be fast enough, with tests only taking 2 minutes to succeed.


Adding support for repo versions

Dev-1249 in Jira for more info.

review completed, please address the items.


Show alert if social integration is missing configuration

When a social native integration requires extra steps and any of those are missing, we should show an alert to the user/dev. (Also el log could be helpful).

[ ] Facebook
[ ] Twitter
[ ] Google+

This should be done inside native integration libs


Update schedule of community meeting

What this PR does / why we need it:
schedule of community meeting changed

/lgtm

Hi @msohn
We just realized that we have 2 contributing.md files, so your changes are transferred (with https://github.com/gardener/documentation/pull/277) into the file that will stay. The current one will be deleted to avoid further confusions.


fixes race condition in memory cache

closes  89 thanks @PaulWoitaschek for finding and submitting a clear concise test case.

OK finally found the root cause. Internally we use a lazy Persister.  The current impl of the NoOpPersister was not lazy. Wrapped all calls to disk to be lazy. For safeguard wrapped that calls to memcache as well.


Restrict the number of threads in C++ sync server

This implements the proposal here:
https://github.com/grpc/proposal/blob/master/L30-Ability-to-restrict-max-threads-in-C%2B%2BSyncServer.md

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,976,261      Total (>)      1,976,225

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,771,116      Total (>)     10,770,429

 No significant differences in binary sizes

[microbenchmarks] Performance differences noted:
Benchmark                              cpu_time    real_time
-------------------------------------  ----------  -----------
BM_ErrorGetStatusCode<SimpleError>     +5%         +5%
BM_HasClearGrpcStatus<ErrorCancelled>  -5%         -5%

****************************************************************

libgrpc.so

     VM SIZE                                                               FILE SIZE
 ++++++++++++++ GROWING                                                 ++++++++++++++
  +0.1%    +608 [None]                                                  +1.73Ki  +0.0%
  +5.2%    +368 src/core/lib/iomgr/resource_quota.cc                       +368  +5.2%
      [NEW]    +126 grpc_resource_user_free_threads                            +126  [NEW]
      [NEW]     +75 grpc_resource_user_alloc_threads                            +75  [NEW]
      +133%     +61 grpc_resource_quota_unref_internal                          +61  +133%
      [NEW]     +38 grpc_resource_quota_set_max_threads                         +38  [NEW]
       +13%     +32 grpc_resource_quota_create                                  +32   +13%
      +3.3%     +16 grpc_resource_user_create                                   +16  +3.3%
      +3.2%      +9 [Unmapped]                                                   +9  +3.2%
      +7.7%      +8 grpc_resource_user_finish_reclamation                        +8  +7.7%
      +9.1%      +3 rq_step_sched(grpc_resource_quota*) [clone .part.7]          +3  +9.1%

  +0.1%    +976 TOTAL                                                   +2.09Ki  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE                                                FILE SIZE
 ++++++++++++++ GROWING                                  ++++++++++++++
  +0.4%   +1012 [None]                                   +7.99Ki  +0.2%
  +9.7%    +240 src/cpp/thread_manager/thread_manager.cc    +240  +9.7%
      [NEW]    +292 grpc::ThreadManager::ThreadManager          +292  [NEW]
       +53%     +75 grpc::ThreadManager::Initialize              +75   +53%
       +15%     +62 grpc::ThreadManager::MainWorkLoop            +62   +15%
      +4.0%      +8 grpc::ThreadManager::MarkAsCompleted          +8  +4.0%
      +3.8%      +4 [Unmapped]                                    +4  +3.8%
  +0.4%    +128 src/cpp/server/server_cc.cc                 +128  +0.4%
      [NEW] +1.65Ki grpc::Server::Server                     +1.65Ki  [NEW]
  +5.4%     +32 src/cpp/common/resource_quota_cc.cc          +32  +5.4%
      [NEW]     +18 grpc::ResourceQuota::SetMaxThreads           +18  [NEW]
       +56%     +14 [Unmapped]                                   +14   +56%

  +0.4% +1.38Ki TOTAL                                    +8.38Ki  +0.2%

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,976,621      Total (>)      1,976,222

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,771,106      Total (>)     10,770,432

 No significant differences in binary sizes

[microbenchmarks] Performance differences noted:
Benchmark                                   cpu_time    real_time
------------------------------------------  ----------  -----------
BM_HasClearGrpcStatus<ErrorWithGrpcStatus>  -10%        -10%
BM_HasClearGrpcStatus<ErrorWithHttpError>   -4%         -4%

****************************************************************

libgrpc.so

     VM SIZE                                                               FILE SIZE
 ++++++++++++++ GROWING                                                 ++++++++++++++
  +0.1%    +576 [None]                                                  +1.73Ki  +0.0%
  +5.2%    +368 src/core/lib/iomgr/resource_quota.cc                       +368  +5.2%
      [NEW]    +126 grpc_resource_user_free_threads                            +126  [NEW]
      [NEW]     +75 grpc_resource_user_alloc_threads                            +75  [NEW]
      +133%     +61 grpc_resource_quota_unref_internal                          +61  +133%
      [NEW]     +38 grpc_resource_quota_set_max_threads                         +38  [NEW]
       +13%     +32 grpc_resource_quota_create                                  +32   +13%
      +3.3%     +16 grpc_resource_user_create                                   +16  +3.3%
      +3.2%      +9 [Unmapped]                                                   +9  +3.2%
      +7.7%      +8 grpc_resource_user_finish_reclamation                        +8  +7.7%
      +9.1%      +3 rq_step_sched(grpc_resource_quota*) [clone .part.7]          +3  +9.1%

  +0.1%    +944 TOTAL                                                   +2.09Ki  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE                                                         FILE SIZE
 ++++++++++++++ GROWING                                           ++++++++++++++
  +0.5% +1.17Ki [None]                                            +12.0Ki  +0.2%
   +23%    +576 src/cpp/thread_manager/thread_manager.cc             +576   +23%
      [NEW]    +302 grpc::ThreadManager::ThreadManager                   +302  [NEW]
      +104%    +209 grpc::ThreadManager::~ThreadManager                  +209  +104%
      [NEW]     +86 grpc::ThreadManager::GetMaxActiveThreadsSoFar         +86  [NEW]
       +17%     +70 grpc::ThreadManager::MainWorkLoop                     +70   +17%
       +48%     +68 grpc::ThreadManager::Initialize                       +68   +48%
       +24%     +25 [Unmapped]                                            +25   +24%
      +8.5%     +17 grpc::ThreadManager::MarkAsCompleted                  +17  +8.5%
  +0.4%    +128 src/cpp/server/server_cc.cc                          +128  +0.4%
      [NEW] +1.65Ki grpc::Server::Server                              +1.65Ki  [NEW]
  +5.4%     +32 src/cpp/common/resource_quota_cc.cc                   +32  +5.4%
      [NEW]     +18 grpc::ResourceQuota::SetMaxThreads                    +18  [NEW]
       +56%     +14 [Unmapped]                                            +14   +56%

  +0.5% +1.89Ki TOTAL                                             +12.7Ki  +0.2%

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,976,779      Total (>)      1,976,380

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,771,115      Total (>)     10,770,423

 No significant differences in binary sizes

[microbenchmarks] Performance differences noted:
Benchmark                                                                                cpu_time    real_time
----------------------------------------------------------------------------------------  ----------  -----------
BM_HasClearGrpcStatus<ErrorWithGrpcStatus>                                                -19%        -19%
BM_StreamingPingPong<InProcess, NoOpMutator, NoOpMutator>/262144/2                        +7%         +7%
BM_StreamingPingPong<MinInProcess, NoOpMutator, NoOpMutator>/32768/2                      +5%         +5%
BM_StreamingPingPongWithCoalescingApi<MinInProcess, NoOpMutator, NoOpMutator>/262144/1/0  +5%         +5%
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/0/2097152                           +4%         +4%
BM_UnaryPingPong<MinInProcess, NoOpMutator, NoOpMutator>/0/262144                         +4%         +4%

Please link the correct proposal in the description :)

****************************************************************

libgrpc.so

     VM SIZE                                                               FILE SIZE
 ++++++++++++++ GROWING                                                 ++++++++++++++
  +0.1%    +608 [None]                                                  +1.69Ki  +0.0%
  +5.2%    +368 src/core/lib/iomgr/resource_quota.cc                       +368  +5.2%
      [NEW]    +126 grpc_resource_user_free_threads                            +126  [NEW]
      [NEW]     +75 grpc_resource_user_alloc_threads                            +75  [NEW]
      +133%     +61 grpc_resource_quota_unref_internal                          +61  +133%
      [NEW]     +38 grpc_resource_quota_set_max_threads                         +38  [NEW]
       +13%     +32 grpc_resource_quota_create                                  +32   +13%
      +3.3%     +16 grpc_resource_user_create                                   +16  +3.3%
      +3.2%      +9 [Unmapped]                                                   +9  +3.2%
      +7.7%      +8 grpc_resource_user_finish_reclamation                        +8  +7.7%
      +9.1%      +3 rq_step_sched(grpc_resource_quota*) [clone .part.7]          +3  +9.1%

  +0.1%    +976 TOTAL                                                   +2.05Ki  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE                                                         FILE SIZE
 ++++++++++++++ GROWING                                           ++++++++++++++
  +0.5% +1.17Ki [None]                                            +12.0Ki  +0.2%
   +23%    +576 src/cpp/thread_manager/thread_manager.cc             +576   +23%
      [NEW]    +302 grpc::ThreadManager::ThreadManager                   +302  [NEW]
      +104%    +209 grpc::ThreadManager::~ThreadManager                  +209  +104%
      [NEW]     +86 grpc::ThreadManager::GetMaxActiveThreadsSoFar         +86  [NEW]
       +17%     +70 grpc::ThreadManager::MainWorkLoop                     +70   +17%
       +48%     +68 grpc::ThreadManager::Initialize                       +68   +48%
       +24%     +25 [Unmapped]                                            +25   +24%
      +8.5%     +17 grpc::ThreadManager::MarkAsCompleted                  +17  +8.5%
  +0.4%    +128 src/cpp/server/server_cc.cc                          +128  +0.4%
      [NEW] +1.65Ki grpc::Server::Server                              +1.65Ki  [NEW]
  +5.4%     +32 src/cpp/common/resource_quota_cc.cc                   +32  +5.4%
      [NEW]     +18 grpc::ResourceQuota::SetMaxThreads                    +18  [NEW]
       +56%     +14 [Unmapped]                                            +14   +56%

  +0.5% +1.89Ki TOTAL                                             +12.7Ki  +0.2%

****************************************************************

libgrpc.so

     VM SIZE                                                               FILE SIZE
 ++++++++++++++ GROWING                                                 ++++++++++++++
  +0.1%    +608 [None]                                                  +1.69Ki  +0.0%
  +5.2%    +368 src/core/lib/iomgr/resource_quota.cc                       +368  +5.2%
      [NEW]    +126 grpc_resource_user_free_threads                            +126  [NEW]
      [NEW]     +75 grpc_resource_user_alloc_threads                            +75  [NEW]
      +133%     +61 grpc_resource_quota_unref_internal                          +61  +133%
      [NEW]     +38 grpc_resource_quota_set_max_threads                         +38  [NEW]
       +13%     +32 grpc_resource_quota_create                                  +32   +13%
      +3.3%     +16 grpc_resource_user_create                                   +16  +3.3%
      +3.2%      +9 [Unmapped]                                                   +9  +3.2%
      +7.7%      +8 grpc_resource_user_finish_reclamation                        +8  +7.7%
      +9.1%      +3 rq_step_sched(grpc_resource_quota*) [clone .part.7]          +3  +9.1%

  +0.1%    +976 TOTAL                                                   +2.05Ki  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE                                                         FILE SIZE
 ++++++++++++++ GROWING                                           ++++++++++++++
  +0.5% +1.17Ki [None]                                            +12.0Ki  +0.2%
   +23%    +576 src/cpp/thread_manager/thread_manager.cc             +576   +23%
      [NEW]    +302 grpc::ThreadManager::ThreadManager                   +302  [NEW]
      +104%    +209 grpc::ThreadManager::~ThreadManager                  +209  +104%
      [NEW]     +86 grpc::ThreadManager::GetMaxActiveThreadsSoFar         +86  [NEW]
       +17%     +70 grpc::ThreadManager::MainWorkLoop                     +70   +17%
       +48%     +68 grpc::ThreadManager::Initialize                       +68   +48%
       +24%     +25 [Unmapped]                                            +25   +24%
      +8.5%     +17 grpc::ThreadManager::MarkAsCompleted                  +17  +8.5%
  +0.4%    +128 src/cpp/server/server_cc.cc                          +128  +0.4%
      [NEW] +1.65Ki grpc::Server::Server                              +1.65Ki  [NEW]
  +5.4%     +32 src/cpp/common/resource_quota_cc.cc                   +32  +5.4%
      [NEW]     +18 grpc::ResourceQuota::SetMaxThreads                    +18  [NEW]
       +56%     +14 [Unmapped]                                            +14   +56%

  +0.5% +1.89Ki TOTAL                                             +12.7Ki  +0.2%

[trickle] No significant performance differences

[trickle] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE                                                               FILE SIZE
 ++++++++++++++ GROWING                                                 ++++++++++++++
  +0.1%    +608 [None]                                                  +1.69Ki  +0.0%
  +5.2%    +368 src/core/lib/iomgr/resource_quota.cc                       +368  +5.2%
      [NEW]    +126 grpc_resource_user_free_threads                            +126  [NEW]
      [NEW]     +75 grpc_resource_user_alloc_threads                            +75  [NEW]
      +133%     +61 grpc_resource_quota_unref_internal                          +61  +133%
      [NEW]     +38 grpc_resource_quota_set_max_threads                         +38  [NEW]
       +13%     +32 grpc_resource_quota_create                                  +32   +13%
      +3.3%     +16 grpc_resource_user_create                                   +16  +3.3%
      +3.2%      +9 [Unmapped]                                                   +9  +3.2%
      +7.7%      +8 grpc_resource_user_finish_reclamation                        +8  +7.7%
      +9.1%      +3 rq_step_sched(grpc_resource_quota*) [clone .part.7]          +3  +9.1%

  +0.1%    +976 TOTAL                                                   +2.05Ki  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE                                                         FILE SIZE
 ++++++++++++++ GROWING                                           ++++++++++++++
  +0.5% +1.17Ki [None]                                            +12.0Ki  +0.2%
   +23%    +576 src/cpp/thread_manager/thread_manager.cc             +576   +23%
      [NEW]    +302 grpc::ThreadManager::ThreadManager                   +302  [NEW]
      +104%    +209 grpc::ThreadManager::~ThreadManager                  +209  +104%
      [NEW]     +86 grpc::ThreadManager::GetMaxActiveThreadsSoFar         +86  [NEW]
       +17%     +70 grpc::ThreadManager::MainWorkLoop                     +70   +17%
       +48%     +68 grpc::ThreadManager::Initialize                       +68   +48%
       +24%     +25 [Unmapped]                                            +25   +24%
      +8.5%     +17 grpc::ThreadManager::MarkAsCompleted                  +17  +8.5%
  +0.4%    +128 src/cpp/server/server_cc.cc                          +128  +0.4%
      [NEW] +1.65Ki grpc::Server::Server                              +1.65Ki  [NEW]
  +5.4%     +32 src/cpp/common/resource_quota_cc.cc                   +32  +5.4%
      [NEW]     +18 grpc::ResourceQuota::SetMaxThreads                    +18  [NEW]
       +56%     +14 [Unmapped]                                            +14   +56%

  +0.5% +1.89Ki TOTAL                                             +12.7Ki  +0.2%

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,976,755      Total (>)      1,976,356

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,771,107      Total (>)     10,770,410

 No significant differences in binary sizes

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,976,755      Total (>)      1,976,356

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,771,107      Total (>)     10,770,402

 No significant differences in binary sizes

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,976,755      Total (>)      1,976,356

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,771,105      Total (>)     10,770,412

 No significant differences in binary sizes

[microbenchmarks] Performance differences noted:
Benchmark                                   cpu_time    real_time
------------------------------------------  ----------  -----------
BM_HasClearGrpcStatus<ErrorWithGrpcStatus>  -14%        -14%

[microbenchmarks] No significant performance differences

[microbenchmarks] Performance differences noted:
Benchmark                                      cpu_time    real_time
---------------------------------------------  ----------  -----------
BM_HasClearGrpcStatus<ErrorWithGrpcStatus>     -15%        -15%
BM_PumpStreamClientToServer<InProcess>/262144  -5%         -5%

@hcaseyal : Thanks for the review. I addresses all your comments. Please take another look

****************************************************************

libgrpc.so

     VM SIZE                                                               FILE SIZE
 ++++++++++++++ GROWING                                                 ++++++++++++++
  +0.1%    +672 [None]                                                  +2.41Ki  +0.0%
  +7.5%    +528 src/core/lib/iomgr/resource_quota.cc                       +528  +7.5%
      [NEW]    +174 grpc_resource_user_free_threads                            +174  [NEW]
      [NEW]    +131 grpc_resource_user_allocate_threads                        +131  [NEW]
      [NEW]     +91 grpc_resource_quota_set_max_threads                         +91  [NEW]
      +133%     +61 grpc_resource_quota_unref_internal                          +61  +133%
       +13%     +32 grpc_resource_quota_create                                  +32   +13%
      +3.3%     +16 grpc_resource_user_create                                   +16  +3.3%
      +4.2%     +12 [Unmapped]                                                  +12  +4.2%
      +7.7%      +8 grpc_resource_user_finish_reclamation                        +8  +7.7%
      +9.1%      +3 rq_step_sched(grpc_resource_quota*) [clone .part.7]          +3  +9.1%

  +0.1% +1.17Ki TOTAL                                                   +2.92Ki  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE                                                         FILE SIZE
 ++++++++++++++ GROWING                                           ++++++++++++++
  +0.5% +1.17Ki [None]                                            +7.96Ki  +0.2%
   +23%    +576 src/cpp/thread_manager/thread_manager.cc             +576   +23%
      [NEW]    +302 grpc::ThreadManager::ThreadManager                   +302  [NEW]
      +104%    +209 grpc::ThreadManager::~ThreadManager                  +209  +104%
      [NEW]     +86 grpc::ThreadManager::GetMaxActiveThreadsSoFar         +86  [NEW]
       +17%     +70 grpc::ThreadManager::MainWorkLoop                     +70   +17%
       +48%     +68 grpc::ThreadManager::Initialize                       +68   +48%
       +24%     +25 [Unmapped]                                            +25   +24%
      +8.5%     +17 grpc::ThreadManager::MarkAsCompleted                  +17  +8.5%
  +0.4%    +128 src/cpp/server/server_cc.cc                          +128  +0.4%
      [NEW] +1.65Ki grpc::Server::Server                              +1.65Ki  [NEW]
  +5.4%     +32 src/cpp/common/resource_quota_cc.cc                   +32  +5.4%
      [NEW]     +18 grpc::ResourceQuota::SetMaxThreads                    +18  [NEW]
       +56%     +14 [Unmapped]                                            +14   +56%

  +0.5% +1.89Ki TOTAL                                             +8.68Ki  +0.2%

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,977,073      Total (>)      1,976,606

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,776,436      Total (>)     10,775,731

 No significant differences in binary sizes

[microbenchmarks] Performance differences noted:
Benchmark                         cpu_time    real_time
--------------------------------  ----------  -----------
BM_HasClearGrpcStatus<ErrorNone>  -5%         -5%
BM_MetadataRefUnrefStatic         -20%        -20%

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,977,121      Total (>)      1,976,654

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,776,437      Total (>)     10,775,731

 No significant differences in binary sizes

[microbenchmarks] Performance differences noted:
Benchmark                           cpu_time    real_time
----------------------------------  ----------  -----------
BM_ErrorGetStatusCode<SimpleError>  +4%         +4%
BM_MetadataRefUnrefExternal         +20%        +20%
BM_MetadataRefUnrefStatic           +5%         +5%

****************************************************************

libgrpc.so

     VM SIZE                                                               FILE SIZE
 ++++++++++++++ GROWING                                                 ++++++++++++++
  +0.1%    +672 [None]                                                  +2.41Ki  +0.0%
  +7.5%    +528 src/core/lib/iomgr/resource_quota.cc                       +528  +7.5%
      [NEW]    +174 grpc_resource_user_free_threads                            +174  [NEW]
      [NEW]    +131 grpc_resource_user_allocate_threads                        +131  [NEW]
      [NEW]     +91 grpc_resource_quota_set_max_threads                         +91  [NEW]
      +133%     +61 grpc_resource_quota_unref_internal                          +61  +133%
       +13%     +32 grpc_resource_quota_create                                  +32   +13%
      +3.3%     +16 grpc_resource_user_create                                   +16  +3.3%
      +4.2%     +12 [Unmapped]                                                  +12  +4.2%
      +7.7%      +8 grpc_resource_user_finish_reclamation                        +8  +7.7%
      +9.1%      +3 rq_step_sched(grpc_resource_quota*) [clone .part.7]          +3  +9.1%

  +0.1% +1.17Ki TOTAL                                                   +2.92Ki  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE                                                         FILE SIZE
 ++++++++++++++ GROWING                                           ++++++++++++++
  +0.5% +1.15Ki [None]                                            +7.79Ki  +0.2%
   +23%    +560 src/cpp/thread_manager/thread_manager.cc             +560   +23%
      [NEW]    +302 grpc::ThreadManager::ThreadManager                   +302  [NEW]
      +104%    +209 grpc::ThreadManager::~ThreadManager                  +209  +104%
      [NEW]     +86 grpc::ThreadManager::GetMaxActiveThreadsSoFar         +86  [NEW]
       +48%     +68 grpc::ThreadManager::Initialize                       +68   +48%
       +16%     +65 grpc::ThreadManager::MainWorkLoop                     +65   +16%
      +8.5%     +17 grpc::ThreadManager::MarkAsCompleted                  +17  +8.5%
       +13%     +14 [Unmapped]                                            +14   +13%
  +0.4%    +128 src/cpp/server/server_cc.cc                          +128  +0.4%
      [NEW] +1.65Ki grpc::Server::Server                              +1.65Ki  [NEW]
  +5.4%     +32 src/cpp/common/resource_quota_cc.cc                   +32  +5.4%
      [NEW]     +18 grpc::ResourceQuota::SetMaxThreads                    +18  [NEW]
       +56%     +14 [Unmapped]                                            +14   +56%

  +0.5% +1.86Ki TOTAL                                             +8.49Ki  +0.2%

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,977,121      Total (>)      1,976,654

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,776,445      Total (>)     10,775,731

 No significant differences in binary sizes

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,977,121      Total (>)      1,976,654

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,776,445      Total (>)     10,775,731

 No significant differences in binary sizes

[microbenchmarks] Performance differences noted:
Benchmark                                   cpu_time    real_time
------------------------------------------  ----------  -----------
BM_HasClearGrpcStatus<ErrorWithGrpcStatus>  -12%        -12%
BM_MetadataRefUnrefStatic                   -5%         -5%

****************************************************************

libgrpc.so

     VM SIZE                                                               FILE SIZE
 ++++++++++++++ GROWING                                                 ++++++++++++++
  +0.1%    +672 [None]                                                  +2.40Ki  +0.0%
  +7.5%    +528 src/core/lib/iomgr/resource_quota.cc                       +528  +7.5%
      [NEW]    +174 grpc_resource_user_free_threads                            +174  [NEW]
      [NEW]    +131 grpc_resource_user_allocate_threads                        +131  [NEW]
      [NEW]     +91 grpc_resource_quota_set_max_threads                         +91  [NEW]
      +133%     +61 grpc_resource_quota_unref_internal                          +61  +133%
       +13%     +32 grpc_resource_quota_create                                  +32   +13%
      +3.3%     +16 grpc_resource_user_create                                   +16  +3.3%
      +4.2%     +12 [Unmapped]                                                  +12  +4.2%
      +7.7%      +8 grpc_resource_user_finish_reclamation                        +8  +7.7%
      +9.1%      +3 rq_step_sched(grpc_resource_quota*) [clone .part.7]          +3  +9.1%

  +0.1% +1.17Ki TOTAL                                                   +2.91Ki  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE                                                         FILE SIZE
 ++++++++++++++ GROWING                                           ++++++++++++++
  +0.5% +1.15Ki [None]                                            +7.79Ki  +0.2%
   +23%    +560 src/cpp/thread_manager/thread_manager.cc             +560   +23%
      [NEW]    +302 grpc::ThreadManager::ThreadManager                   +302  [NEW]
      +104%    +209 grpc::ThreadManager::~ThreadManager                  +209  +104%
      [NEW]     +86 grpc::ThreadManager::GetMaxActiveThreadsSoFar         +86  [NEW]
       +48%     +68 grpc::ThreadManager::Initialize                       +68   +48%
       +16%     +65 grpc::ThreadManager::MainWorkLoop                     +65   +16%
      +8.5%     +17 grpc::ThreadManager::MarkAsCompleted                  +17  +8.5%
       +13%     +14 [Unmapped]                                            +14   +13%
  +0.4%    +128 src/cpp/server/server_cc.cc                          +128  +0.4%
      [NEW] +1.65Ki grpc::Server::Server                              +1.65Ki  [NEW]
  +5.4%     +32 src/cpp/common/resource_quota_cc.cc                   +32  +5.4%
      [NEW]     +18 grpc::ResourceQuota::SetMaxThreads                    +18  [NEW]
       +56%     +14 [Unmapped]                                            +14   +56%

  +0.5% +1.86Ki TOTAL                                             +8.49Ki  +0.2%

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,977,121      Total (>)      1,976,654

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,776,440      Total (>)     10,775,738

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,977,121      Total (>)      1,976,654

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,776,440      Total (>)     10,775,735

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences

****************************************************************

libgrpc.so

     VM SIZE                                                               FILE SIZE
 ++++++++++++++ GROWING                                                 ++++++++++++++
  +0.1%    +640 [None]                                                  +2.40Ki  +0.0%
  +7.5%    +528 src/core/lib/iomgr/resource_quota.cc                       +528  +7.5%
      [NEW]    +174 grpc_resource_user_free_threads                            +174  [NEW]
      [NEW]    +131 grpc_resource_user_allocate_threads                        +131  [NEW]
      [NEW]     +91 grpc_resource_quota_set_max_threads                         +91  [NEW]
      +133%     +61 grpc_resource_quota_unref_internal                          +61  +133%
       +13%     +32 grpc_resource_quota_create                                  +32   +13%
      +3.3%     +16 grpc_resource_user_create                                   +16  +3.3%
      +4.2%     +12 [Unmapped]                                                  +12  +4.2%
      +7.7%      +8 grpc_resource_user_finish_reclamation                        +8  +7.7%
      +9.1%      +3 rq_step_sched(grpc_resource_quota*) [clone .part.7]          +3  +9.1%

  +0.1% +1.14Ki TOTAL                                                   +2.91Ki  +0.0%

****************************************************************

libgrpc++.so

     VM SIZE                                                         FILE SIZE
 ++++++++++++++ GROWING                                           ++++++++++++++
  +0.5% +1.15Ki [None]                                            +7.79Ki  +0.2%
   +23%    +560 src/cpp/thread_manager/thread_manager.cc             +560   +23%
      [NEW]    +302 grpc::ThreadManager::ThreadManager                   +302  [NEW]
      +104%    +209 grpc::ThreadManager::~ThreadManager                  +209  +104%
      [NEW]     +86 grpc::ThreadManager::GetMaxActiveThreadsSoFar         +86  [NEW]
       +48%     +68 grpc::ThreadManager::Initialize                       +68   +48%
       +16%     +65 grpc::ThreadManager::MainWorkLoop                     +65   +16%
      +8.5%     +17 grpc::ThreadManager::MarkAsCompleted                  +17  +8.5%
       +13%     +14 [Unmapped]                                            +14   +13%
  +0.4%    +128 src/cpp/server/server_cc.cc                          +128  +0.4%
      [NEW] +1.65Ki grpc::Server::Server                              +1.65Ki  [NEW]
  +5.4%     +32 src/cpp/common/resource_quota_cc.cc                   +32  +5.4%
      [NEW]     +18 grpc::ResourceQuota::SetMaxThreads                    +18  [NEW]
       +56%     +14 [Unmapped]                                            +14   +56%

  +0.5% +1.86Ki TOTAL                                             +8.49Ki  +0.2%

[trickle] No significant performance differences

Objective-C binary sizes
*****************STATIC******************
  New size                      Old size
 1,976,402      Total (>)      1,975,935

 No significant differences in binary sizes

***************FRAMEWORKS****************
  New size                      Old size
10,775,382      Total (>)     10,774,681

 No significant differences in binary sizes

[microbenchmarks] No significant performance differences


Fix build-CI + add badges to readme.md

add badges to readme.md to easy see the results of build-CI (e.g. for updates / PR testing)
fix broken build CI,

platforms tested (AVR, SAM, SAMD, ESP2866) these compile all examples.
ESP32 gave problems (need to investigate)

LINT test OK
JSON test OK
unit tests can not be enabled

build-CI environment cannot find "util/crc16.h" (need to investigate)

I'll squash the PR first ...


respect XDG Base Directory Specification on Linux and document handling on Windows/OSX

The 'XDG Base Directory Specification' should be respected on GNU/Linux systems, as crc should not assume that it is ok to use $HOME/.crc
Handling of XDG ENV vars on other operating systems should be documented. At least most of the ENV should be respected on OSX.

@goern we did think of it and since minishift/minikube also use $HOME/.<project> we went through this route instead of XDG Base Directory Specification so a user coming from these project should know where to look for files, in future, we should consider this.

In my opinion, once we have our initial releases, this will be much harder to change, so this really should be done early.

Is there consideration to use XDG base directory, or maybe using some other named env variable that would allow to set where .crc folder should be?


How can I configure it to proxy another dns and use DNS-over-TLS only?

Yes, I want to make it a proxy that can run on the localhost and use DNS-over-TLS only for outbound DNS lookup requests, after get the correct record, return the result to the system.
How should I configure it to do that?

Use Stubby: https://dnsprivacy.org/wiki/display/DP/DNS+Privacy+Daemon+-+Stubby
I think you will be disappointed though, as I don't think that there is a way to configure it to work with Tenta and TLS


Translating names to English for validation using external APIs

NOTE: Posting here to document a potential idea.

In changeset 48269805, there was one feature that was modified:

The name of the marketplace was modified from English to Chinese

I gave Google Translate API a try to translate the new name 亚庇中央巴刹, back to English. The result was Kota Kinabalu. These two words match with the English name in the previous version of the feature, Pasar Kota Kinabalu Central.
'use strict';

const Translate = require('@google-cloud/translate');
const projectId = 'Insert project ID';
const translateClient = Translate({
    projectId: projectId
});

translateClient.translate('센트럴마켓', 'en')
.then((results) => {
    const translation = results[0];

    console.log(`Text: ${text}`);
    console.log(`Translation: ${translation}`);
})
.catch((err) => {
    console.error('ERROR:', err);
});

I don't think that should fit into Gabbar but into other systems.

Yes @lukasmartinelli, an external system makes more sense. No next actions here. Closing.


chore: bump valtio to v1.11.2

Summary
Bump valtio version to 1.11.2 to match appkit web sdk

@ignaciosantise should we add renovatebot to this repo so these PRs are automated?


⚠ DesiTorrents has degraded performance

In 73ed7f1, DesiTorrents ($DST) experienced degraded performance:

HTTP code: 200
Response time: 1931 ms

Resolved: DesiTorrents performance has improved in 9333886.


Module: Add badgeText prop

Figma designs
This PR adds an optional badgeText prop to Module (and related Module components) to display a badge after the title text.

Test Plan
Check out the new "Static – Badge" and "Expandable - Icon and Badge " sections in the docs.

LGTM!


Move all files to root and updated name

On this way sysadmins can directly clone the repo into there plugins folder. This also makes the folder path a bit less redundant (da-letsencrupt/da_letsencrypt).
Do you agree with this move?

I agree, good improvement!


JIRA Update 8.14.0

JIRA Update 8.14.0

@pavanp21 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

#sign-off


stake integration tests

How is this different to e2e tests?

I think this was based on the old idea that we were going to have integration tests with everything mocked and live e2e tests. I dont think we need this one anymore.

closing per discussion w goats. Project Management for this is in Notion


Im looking for a little help on this, and was hoping you could help.

Brians-iMac:ScaffoldersGuide Brian$ carthage update --platform iOS
*** Fetching SQLite.swift
*** Checking out SQLite.swift at "da2d43422a72ae0e91356fccfde1959d43b97385"
*** xcodebuild output can be found in /var/folders/y0/z1pws7ts5cs7ggfhpw57pg7c0000gn/T/carthage-xcodebuild.cYAD5Z.log
*** Building scheme "SQLite iOS" in SQLite.xcodeproj
*** Building scheme "SQLiteCipher iOS" in SQLite.xcodeproj
** BUILD FAILED **
The following build commands failed:
CompileC /Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Intermediates/sqlcipher.build/Release-iphoneos/sqlcipher.build/Objects-normal/armv7/sqlite3.o sqlite3.c normal armv7 c com.apple.compilers.llvm.clang.1_0.compiler
CompileC /Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Intermediates/sqlcipher.build/Release-iphoneos/sqlcipher.build/Objects-normal/arm64/sqlite3.o sqlite3.c normal arm64 c com.apple.compilers.llvm.clang.1_0.compiler
(2 failures)
configure: error: in `/Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher':
configure: error: C compiler cannot create executables
clang: error: no such file or directory: '/Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c'
clang: error: no input files
clang: error: no such file or directory: '/Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c'
clang: error: no input files
A shell task failed with exit code 65:
** BUILD FAILED **
The following build commands failed:
CompileC /Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Intermediates/sqlcipher.build/Release-iphoneos/sqlcipher.build/Objects-normal/armv7/sqlite3.o sqlite3.c normal armv7 c com.apple.compilers.llvm.clang.1_0.compiler
CompileC /Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Intermediates/sqlcipher.build/Release-iphoneos/sqlcipher.build/Objects-normal/arm64/sqlite3.o sqlite3.c normal arm64 c com.apple.compilers.llvm.clang.1_0.compiler
(2 failures)
#################################################################################
/var/folders/y0/z1pws7ts5cs7ggfhpw57pg7c0000gn/T/carthage-xcodebuild.cYAD5Z.log
#################################################################################
Build settings from command line:
BITCODE_GENERATION_MODE = bitcode
CODE_SIGN_IDENTITY =
CODE_SIGNING_REQUIRED = NO
ONLY_ACTIVE_ARCH = NO
SDKROOT = iphoneos9.0
=== BUILD TARGET SQLite iOS OF PROJECT SQLite WITH CONFIGURATION Release ===
Check dependencies
Write auxiliary files
write-file /Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Intermediates/SQLite.build/all-product-headers.yaml
ProcessInfoPlistFile /Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Products/Release-iphoneos/SQLite.framework/Info.plist Supporting\ Files/SQLite/Info.plist
cd /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift
export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/Users/Brian/.rvm/gems/ruby-2.2.1/bin:/Users/Brian/.rvm/gems/ruby-2.2.1@global/bin:/Users/Brian/.rvm/rubies/ruby-2.2.1/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Users/Brian/.rvm/bin"
builtin-infoPlistUtility /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Supporting\ Files/SQLite/Info.plist -expandbuildsettings -format binary -platform iphoneos -o /Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Products/Release-iphoneos/SQLite.framework/Info.plist
CompileSwiftSources normal arm64 com.apple.xcode.tools.swift.compiler
cd /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift
export PATH="/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr/bin:/Applications/Xcode.app/Contents/Developer/usr/bin:/Users/Brian/.rvm/gems/ruby-2.2.1/bin:/Users/Brian/.rvm/gems/ruby-2.2.1@global/bin:/Users/Brian/.rvm/rubies/ruby-2.2.1/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Users/Brian/.rvm/bin"
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc -incremental -module-name SQLite -O -sdk /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS9.0.sdk -target arm64-apple-ios8.0 -g -module-cache-path /Users/Brian/Library/Developer/Xcode/DerivedData/ModuleCache -Xfrontend -serialize-debugging-options -application-extension -embed-bitcode -I /Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Products/Release-iphoneos -F /Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Products/Release-iphoneos -c -j2 /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Source/Core/Connection.swift /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Source/Core/Statement.swift /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Source/Core/Value.swift /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Source/Core/Blob.swift /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Source/Typed/Expression.swift /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Source/Typed/Query.swift /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Source/Typed/Schema.swift /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Source/Typed/Collation.swift /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Source/Typed/Operators.swift /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Source/Typed/AggregateFunctions.swift /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Source/Typed/CoreFunctions.swift /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Source/Typed/CustomFunctions.swift /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Source/Typed/Setter.swift /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Source/Extensions/FTS4.swift /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Source/Extensions/R*Tree.swift /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Source/Foundation.swift /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Source/Helpers.swift -output-file-map /Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Intermediates/SQLite.build/Release-iphoneos/SQLite\ iOS.build/Objects-normal/arm64/SQLite\ iOS-OutputFileMap.json -parseable-output -serialize-diagnostics -emit-dependencies -emit-module -emit-module-path /Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Intermediates/SQLite.build/Release-iphoneos/SQLite\ iOS.build/Objects-normal/arm64/SQLite.swiftmodule -Xcc -I/Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Intermediates/SQLite.build/Release-iphoneos/SQLite\ iOS.build/swift-overrides.hmap -Xcc -iquote -Xcc /Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Intermediates/SQLite.build/Release-iphoneos/SQLite\ iOS.build/SQLite-generated-files.hmap -Xcc -I/Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Intermediates/SQLite.build/Release-iphoneos/SQLite\ iOS.build/SQLite-own-target-headers.hmap -Xcc -I/Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Intermediates/SQLite.build/Release-iphoneos/SQLite\ iOS.build/SQLite-all-non-framework-target-headers.hmap -Xcc -ivfsoverlay -Xcc /Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Intermediates/SQLite.build/all-product-headers.yaml -Xcc -iquote -Xcc /Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Intermediates/SQLite.build/Release-iphoneos/SQLite\ iOS.build/SQLite-project-headers.hmap -Xcc -I/Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Products/Release-iphoneos/include -Xcc -I/Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Intermediates/SQLite.build/Release-iphoneos/SQLite\ iOS.build/DerivedSources/arm64 -Xcc -I/Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Intermediates/SQLite.build/Release-iphoneos/SQLite\ iOS.build/DerivedSources -emit-objc-header -emit-objc-header-path /Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Intermediates/SQLite.build/Release-iphoneos/SQLite\ iOS.build/Objects-normal/arm64/SQLite-Swift.h -import-underlying-module -Xcc -ivfsoverlay -Xcc /Users/Brian/Library/Developer/Xcode/DerivedData/SQLite-fmqbcdxermetnmdgajhzahorxofx/Build/Intermediates/SQLite.build/Release-iphoneos/SQLite\ iOS.build/unextended-module-overlay.yaml -Xcc -working-directory/Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift
CompileSwift normal arm64 /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift/Source/Core/Connection.swift
cd /Users/Brian/Desktop/ScaffoldersGuide/ScaffoldersGuide/Carthage/Checkouts/SQLite.swift

This has been the error last few times I have run the program, Im hoping this is in the right location and someone will be able to help.
THankyou

Having the same issue here. Have you figured out a way to bypass this yet?

See also #208

Merging comment from #208 to here prior to closing @208:

FYI, this is still a problem using the current master (2b8c8d28415cc6460f518d18348f9c462b4617bb) . The Carthage console errors are as follows. The errors above are in the Carthage build logs.
configure: error: in `/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher':
configure: error: C compiler cannot create executables

There are 46 warnings, mostly repeats of these:
SQLite.swift/Vendor/sqlcipher/sqlite3.c:28978:6: warning: "gethostuuid() is disabled." [-W#warnings]
SQLite.swift/Vendor/sqlcipher/sqlite3.c:9057:26: warning: unused variable 'sqlite3one' [-Wunused-const-variable]
SQLite.swift/Vendor/sqlcipher/sqlite3.c:30362:14: warning: implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Wshorten-64-to-32]
SQLite.swift/Vendor/sqlcipher/sqlite3.c:76542:21: warning: implicit conversion loses integer precision: 'i64' (aka 'long long') to 'int' [-Wshorten-64-to-32]

Here is the full output:
$ carthage update
*** Cloning SQLite.swift
*** Checking out SQLite.swift at "2b8c8d28415cc6460f518d18348f9c462b4617bb"
*** xcodebuild output can be found in /var/folders/fn/m4qv73410870r7xf2fpppwmm0000gn/T/carthage-xcodebuild.Fkotf5.log
*** Building scheme "SQLite Mac" in SQLite.xcodeproj
*** Building scheme "SQLiteCipher Mac" in SQLite.xcodeproj
*** Building scheme "SQLiteCipher iOS" in SQLite.xcodeproj
*** Building scheme "SQLite iOS" in SQLite.xcodeproj
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:9057:26: warning: unused variable 'sqlite3one' [-Wunused-const-variable]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:9057:26: warning: unused variable 'sqlite3one' [-Wunused-const-variable]
ld: warning: object file (/Users/asdfasdf/Library/Developer/Xcode/DerivedData/SQLite-dryqnsnrorqaeihiqxntpsvtlyic/Build/Products/Release/libsqlcipher.a(sqlite3.o)) was built for newer OSX version (10.11) than being linked (10.9)
configure: error: in `/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher':
configure: error: C compiler cannot create executables
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:28978:6: warning: "gethostuuid() is disabled." [-W#warnings]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:9057:26: warning: unused variable 'sqlite3one' [-Wunused-const-variable]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:28978:6: warning: "gethostuuid() is disabled." [-W#warnings]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:9057:26: warning: unused variable 'sqlite3one' [-Wunused-const-variable]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:28978:6: warning: "gethostuuid() is disabled." [-W#warnings]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:30362:14: warning: implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:32081:42: warning: implicit conversion loses integer precision: 'unsigned long long' to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:32244:11: warning: implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:32356:10: warning: implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:33556:33: warning: implicit conversion loses integer precision: 'long long' to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:35226:17: warning: implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:35537:11: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:35545:11: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:35838:19: warning: implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:36001:37: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:36216:53: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:76542:21: warning: implicit conversion loses integer precision: 'i64' (aka 'long long') to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:81870:44: warning: implicit conversion loses integer precision: 'long long' to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:105825:26: warning: implicit conversion loses integer precision: 'u64' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:105827:36: warning: implicit conversion loses integer precision: 'unsigned long long' to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:105873:26: warning: implicit conversion loses integer precision: 'u64' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:105875:36: warning: implicit conversion loses integer precision: 'unsigned long long' to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:28978:6: warning: "gethostuuid() is disabled." [-W#warnings]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:9057:26: warning: unused variable 'sqlite3one' [-Wunused-const-variable]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:28978:6: warning: "gethostuuid() is disabled." [-W#warnings]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:30362:14: warning: implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:32081:42: warning: implicit conversion loses integer precision: 'unsigned long long' to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:32244:11: warning: implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:32356:10: warning: implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:33556:33: warning: implicit conversion loses integer precision: 'long long' to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:35226:17: warning: implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:35537:11: warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:35545:11: warning: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:35838:19: warning: implicit conversion loses integer precision: 'ssize_t' (aka 'long') to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:36001:37: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:36216:53: warning: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:76542:21: warning: implicit conversion loses integer precision: 'i64' (aka 'long long') to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:81870:44: warning: implicit conversion loses integer precision: 'long long' to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:105825:26: warning: implicit conversion loses integer precision: 'u64' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:105827:36: warning: implicit conversion loses integer precision: 'unsigned long long' to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:105873:26: warning: implicit conversion loses integer precision: 'u64' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:105875:36: warning: implicit conversion loses integer precision: 'unsigned long long' to 'int' [-Wshorten-64-to-32]
/Users/asdfasdf/eg/temp/sqlitetest/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c:9057:26: warning: unused variable 'sqlite3one' [-Wunused-const-variable]

I am also experiencing this issue when running carthage bootstrap --platform ios --no-use-binaries
** BUILD FAILED **

The following build commands failed:
	CompileC /Users/emilytoop/Library/Developer/Xcode/DerivedData/SQLite-abjdlqjvubxjtlboiztqxwarkqup/Build/Intermediates/sqlcipher.build/Release-iphoneos/sqlcipher.build/Objects-normal/armv7s/sqlite3.o sqlite3.c normal armv7s c com.apple.compilers.llvm.clang.1_0.compiler
	CompileC /Users/emilytoop/Library/Developer/Xcode/DerivedData/SQLite-abjdlqjvubxjtlboiztqxwarkqup/Build/Intermediates/sqlcipher.build/Release-iphoneos/sqlcipher.build/Objects-normal/arm64/sqlite3.o sqlite3.c normal arm64 c com.apple.compilers.llvm.clang.1_0.compiler
	CompileC /Users/emilytoop/Library/Developer/Xcode/DerivedData/SQLite-abjdlqjvubxjtlboiztqxwarkqup/Build/Intermediates/sqlcipher.build/Release-iphoneos/sqlcipher.build/Objects-normal/armv7/sqlite3.o sqlite3.c normal armv7 c com.apple.compilers.llvm.clang.1_0.compiler
(3 failures)
configure: error: in `/Users/emilytoop/Development/firefox-ios/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher':
configure: error: C compiler cannot create executables
clang: error: no such file or directory: '/Users/emilytoop/Development/firefox-ios/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c'
clang: error: no input files
clang: error: no such file or directory: '/Users/emilytoop/Development/firefox-ios/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c'
clang: error: no input files
clang: error: no such file or directory: '/Users/emilytoop/Development/firefox-ios/Carthage/Checkouts/SQLite.swift/Vendor/sqlcipher/sqlite3.c'
clang: error: no input files```

@fluffyemily Hm, the "SQLite iOS" scheme went away a bit ago. Are you locked to an old commit, branch, or fork?

@stephencelis we've not upgraded since the swift 2.0 stuff got merged so yeah, old commit.

@stephencelis I've just checked out the latest and there is still a SQLite iOS scheme there that I can see.

@fluffyemily My bad. I was the one on a branch! :flushed:

awesome, thanks @stephencelis

Sorry, I haven't had time to go back to this. I will close it and revisit it again later when I'm able to spend more time on if. Thank you for the replies.


pybamm[bpx] migrate to pydantic v2

Description
the optional dependency 'bpx' 0.4.0 still use pydantic v1, it blocks others which depends on pydantic v2 to use pybamm.
I pulls a request for bpx project, and pybamm parameter_values create_from_bpx should be updated as well.
Motivation
i'm waiting https://github.com/FaradayInstitution/BPX/pull/51 review.  if approved and merged, create_from_bpx should be updated, accept both bpx <= 0.4.0 and new.
Possible Implementation
check bpx version, determine if need pydantic v2
Additional context
No response

I will take a look at updating the version of BPX we use

I am going to close this ticket for now. Since Pydantic v2 is not available in BPX yet and there is no new version of BPX, there is nothing that can be done. A new ticket can be opened after BPX gets updated


[BUG] ACF-based vehicles randomly breaking and then crashing the server

Short Description
Bug that i've noticed recently where my server will randomly crash because of player's ACF vehicles despite there being nothing wrong with the vehicles.
Branch and Version
Workshop version server and client side.
Console Error Logs (Optional)
EDSHOT: !noclip
Crazy origin, angles, velocity, angular velocity on entity [271][gmod_wire_expression2]
        Origin:           [-nan, -nan, nan]
        Angles:           [-nan, nan, 180.000000]
        Velocity:         [-nan, -nan, nan]
        Angular Velocity: [-nan, -nan, nan]
Defusing!
Removing!
Crazy origin, angles, velocity, angular velocity on entity [306][prop_physics]
        Origin:           [-nan, -nan, nan]
        Angles:           [-nan, nan, 180.000000]
        Velocity:         [-nan, -nan, nan]
        Angular Velocity: [-nan, -nan, nan]
Defusing!
Removing!
*** ERROR *** Excessive sizelevel (41) for element
[sizelevel message repeats]
*** ERROR *** Excessive sizelevel (168) for element
IVP Failed at ../ivp_utility/ivu_vhash.cxx 157
IVP Failed at ../ivp_utility/ivu_vhash.cxx 157

IVP Failed at ../ivp_utility/ivu_vhash.cxx 157

cat: hlds.1568736.pid: No such file or directory
email debug.log to<EMAIL_ADDRESS>Mon Sep 30 01:59:26 UTC 2024: Server restart in 10 seconds

How to Reproduce (Optional)
With other people's vehicles, i'm not sure. It's pretty random.
With this one tank I have all I have to do is use it for a bit and then it randomly breaks. Other times I can just flip it upside down and wiggle it around until it breaks (listen for the gearbox click in the video) and falls through the world.
Screenshots (Optional)
https://github.com/user-attachments/assets/67baff1e-cb40-47c8-a7e6-5d0495bf3fcb
Additional Information (Optional)
Tested this on three other servers with ACF and they crash as well.
I also noticed that when props are being deleted from falling through the world that normally it should be a non 'nan' value and the last prop to be deleted before completely breaking is the prop used in the upper part of the tank that has all the Wiremod components.

Seems to be a generic crazyphysics crash, are you sure that its not the E2 on the tank that's doing this? I don't think that ACF-3 does much in terms of velocity except for recoil and explosions.

Could you provide the dupe that's having issues? I haven't seen this problem happen anywhere else.

hawk_tuah_tank.txt


Use React Hooks for connect

This PR builds on the previous React-Redux version 6 preview work from #898, #995, aand #1000 .  As with the previous couple PRs, the major changes are:

Switching from legacy context to createContext()
Switching from withRef to forwardRef
Removing the ability to pass a Redux store as a prop to a connected component

Our existing v6 PRs both passed our unit test suite, but the internal implementations were ugly.  Using createContext required that we split the wrapper component into two pieces: an outer wrapper to render the context consumer, and an inner wrapper to receive the store state, process it, and render the real wrapped component.
With the announcement of React Hooks, there's now another way to access the store state from context: via the useContext() hook.
I've taken my existing branch from #995, and rewritten the wrapper component to be a function component that uses hooks.  The implementation is dramatically simpler.  v5, #995, and #1000 all have around 140 lines of complicated class-based component logic.  In this PR, the wrapper component is simply:
    function createChildSelector(store) {
      return selectorFactory(store.dispatch, selectorFactoryOptions)
    }

    function ConnectFunction(props) {
      const {context, forwardRef, ...wrapperProps} = props
      const contextToRead = context || defaultContext

      const {store, storeState} = useContext(contextToRead)
      const childPropsSelector = useMemo(() =>  createChildSelector(store), [store])

      const childProps = childPropsSelector(storeState, wrapperProps)

      const renderedChild = useMemo(() => {
        return <WrappedComponent {...childProps} ref={forwardRef} />
      }, [childProps, forwardRef])

      return renderedChild
    }

I ran a test build through our benchmark suite just to see how it compares.  While this build was still slower than v5, particularly in the stockticker artificial stress test, it's slightly faster than either of the existing v6 PRs.
I think this PR completely supersedes both #995 and #1000 , and is our best candidate approach for React-Redux v6.
It does rely on an alpha build of React (currently 16.7.0-alpha.0 ), and so we would have to leave it as an alpha in turn until the Hooks API is finalized and React 16.7 has gone final.
I'd like to publish this as a new alpha tag on NPM, and get people to start playing with it so that we can find out how it performs in real applications.

@cellog : I did actually have the opportunity to talk to most of the React team today (Andrew, Sebastian, Dan, and Sophie).  They were nice enough to listen to my questions and respond.  I'm not going to say I entirely got answers for everything, but we did talk.
Unfortunately, the day has also been a blur, and I don't remember most of the details at this point.  Sorry :(  Maybe @gaearon , @sophiebits, or @acdlite can pop in and remind me what the rough plans are there.
There's really two related issues around performance here: how fast React can traverse the tree and find consumers (per https://github.com/facebook/react/issues/13739 ), and then React potentially skipping running updates for consumers based on observedBits (see #1018 for notional ideas).
I think we ought to focus on just getting v6 ready as-is for now, and let the observedBits stuff kinda sit in the background for later.
I'll also note that I'm not entirely sure just how useful the stockticker benchmark actually is, on the grounds that A) it's a completely flat component tree, and B) the speed of the updates.  It's certainly an objective number we can look at, I just don't know how meaningful the results are.

This change looks super impressive!!!
This diff is incredible
https://github.com/reduxjs/react-redux/pull/1065/files#diff-4a561361865a8e6d0758088bf7cded8d

Hey, @timdorr : we need to figure out our branching strategy for v5 / v6.  Thoughts?

Based on discussion behind closed doors in the super-secret invite-only gatekeeper zone, i.e. Twitter DMs, we're going to close this one out and work on the hooks-based approach instead. I'll nuke the branch, but it will stick around in this PR if we want to pull from it.

Gasp!

Still sad that the v6 approach didn't work out how we thought, because the code in this branch was beautiful.
My v7 alpha branch?  Yeah, that's... uh... "functional".  That's a good word.  It functions.
It ain't pretty, though.


✗ Android license status unknown.       Try re-installing or updating your Android SDK Manager.       See https://developer.android.com/studio/#downloads or visit https://flutter.dev/setup/#android-setup for detailed instructions.

I am running on JDK11.0.5 on Ubuntu. I had checked this solution but didn't worked in my case.
When I tried to run the app on my emulator, it states :

Error running Gradle:
ProcessException: Process "/home/chinkysight/Desktop/flutter_app/android/gradlew" exited abnormally:

Configure project :app
Checking the license for package Android SDK Build-Tools 28.0.3 in /home/chinkysight/Android/Sdk/licenses
Warning: License for package Android SDK Build-Tools 28.0.3 not accepted.
Checking the license for package Android SDK Platform 28 in /home/chinkysight/Android/Sdk/licenses
Warning: License for package Android SDK Platform 28 not accepted.

FAILURE: Build failed with an exception.

Where:
Build file '/home/chinkysight/Desktop/flutter_app/android/build.gradle' line: 26

What went wrong:
A problem occurred evaluating root project 'android'.

A problem occurred configuring project ':app'.
Failed to install the following Android SDK packages as some licences have not been accepted.
build-tools;28.0.3 Android SDK Build-Tools 28.0.3
platforms;android-28 Android SDK Platform 28
To build this project, accept the SDK license agreements and install the missing components using the Android Studio SDK Manager.
Alternatively, to transfer the license agreements from one workstation to another, see http://d.android.com/r/studio-ui/export-licenses.html

 Using Android SDK: /home/chinkysight/Android/Sdk

Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 8s
Command: /home/chinkysight/Desktop/flutter_app/android/gradlew app:properties
Finished with error: Please review your Gradle project setup in the android/ folder.

I solved it thankfully to this stack post:  I need to downgrade my jdk to 8


Mcpe 0.15.0 update

When Block Launcher Is Gonna Update ????
Update it fast It no needs 2 months to update it

Were working on that, sorry for the wait!

Plz, close this report cause, were spending pore time dealing with reports than porting BL!
Thx!

I can offer that if you have updated Minecraft to 0.15, that is why.  BlockLauncher does not support 0.15 yet.  Please close this so we do not have to sort this later.  The issue is being worked on.
Check twitter and you'll see that he is having issues with OpenGL and closing the app as well as a few more things.  What should have been a week has gotten much longer.  Please close this issue so the author does not have to sort this out later.


vLLM Pascal architecture fix no longer works

Hello, what a great project! Unfortunately, vLLM fix for Pascal arch no longer works on the main branch.
vLLM changed the way it checks for compute capability, but I was unable to find how it's done in the current version
Would you be able to refactor the Pascal patch to make TinyLLM work with recent version of vLLM? Would much oblige!

Thanks @elabz !   You are right. I need to update it.
We have a PR to vLLM to add pascal support to the main project: https://github.com/vllm-project/vllm/pull/4409 - here is the fix: https://github.com/vllm-project/vllm/pull/4409/files


EventPipeEventSource constructor blocks until the first event is read

Moving https://github.com/dotnet/diagnostics/issues/1060 to here because this repo is a better place to keep track of this issue:
From @davmason:
If you follow the sample code on how to use EventPipeEventSource but replace the provider with a provider that doesn't produce any events, it will block forever in the constructor to EventPipeEventSource.
    var providers = new List<EventPipeProvider>()
    {
        new EventPipeProvider("Microsoft-Windows-DotNETRuntime",
            EventLevel.Informational, (long)ClrTraceEventParser.Keywords.GC)
    };

    var client = new DiagnosticsClient(processId);
    using (var session = client.StartEventPipeSession(providers, false))
    {
        var source = new EventPipeEventSource(session.EventStream);

        source.Clr.All += (TraceEvent obj) => {
            Console.WriteLine(obj.EventName);
        }
        try
        {
            source.Process();
        }
        // NOTE: This exception does not currently exist. It is something that needs to be added to TraceEvent.
        catch (EventStreamException e)
        {
            Console.WriteLine("Error encountered while processing events");
            Console.WriteLine(e.ToString());
        }
    }

It will block on this line: https://github.com/microsoft/perfview/blob/cb1943b8ded584e136e140746e5771ca63668c5a/src/TraceEvent/EventPipe/EventPipeEventSource.cs#L68
This seems like a pitfall, and it's not clear what is happening. I've used that code pattern lots before and it's never failed, then all of a sudden it hangs my app and I have to do a lot of digging to understand why. I imagine customers will run in to it as well.

This is very problematic when we try to hook the very first events coming from a process.
As the constructor is blocked, the events cannot be subscribed and therefore there is a high chance to lose the first events.

@sywhang, are you planning to fix this?  If I understand correctly, this sounds like an issue that is specific to live sessions.

@sywhang, are you planning to fix this?  If I understand correctly, this sounds like an issue that is specific to live sessions.

Sure. I can take a look at this some time this week.

Sure. I can take a look at this some time this week.

Thanks much @sywhang.

Thanks much @sywhang.

It looks like @sywhang  is no longer at Microsoft, @brianrob can someone else take a look at this?

@josalem can you take a look at this now that @sywhang is no longer at Microsoft?  Thinking about this one a bit, I think that it's reasonable to block when waiting for the next event after Process is called, but we shouldn't be blocking in the constructor.  This would be consistent with how ETW real-time sessions work.

Can do. This is a recurring issue and is unexpected behavior I would argue. I think care may need to be taken on "fixing" this, however, as this has been the behavior for a long while and changing it without an opt-in has the potential to break existing tools if they update their TraceEvent version.

Thanks John.  To be honest, I'm not concerned about putting this behind a flag unless it has other more far reaching implications.  If you're concerned, one thing you could consider is submitting it to the feature/perfview-3.0 branch.  I'm batching up some larger changes that I'm going to release with a 3.0 version, and so this could be part of that.

+1 to not requiring a flag. It is technically a behavior change, but it's hard to imagine anyone relying on it.
I have helped multiple people figure out why their code was seemingly deadlocked, it is hard/impossible for someone unfamiliar with the internal of TraceEvent to figure out what is happening.


chore(template): updating PR template to mention Security practices.

Description of changes:
Adding new item to the PR checklist mentioning Security practices
Check points: (check or cross out if not relevant)

[ ] Added new tests to cover change, if needed
[ ] Build succeeds with all target using Swift Package Manager
[ ] All unit tests pass
[ ] All integration tests pass
[ ] Documentation update for the change if required
[ ] PR title conforms to conventional commit style
[ ] If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Codecov Report

Merging #1699 (e22f7c3) into main (6304cbc) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1699      +/-   ##
==========================================
- Coverage   59.09%   59.07%   -0.02%
==========================================
  Files         716      716
  Lines       21856    21856
==========================================
- Hits        12915    12912       -3
- Misses       8941     8944       +3

Flag
Coverage Δ

API_plugin_unit_test
62.51% <ø> (ø)

AWSPluginsCore
71.30% <ø> (-0.08%)
:arrow_down:

Amplify
46.88% <ø> (ø)

Analytics_plugin_unit_test
71.76% <ø> (ø)

Auth_plugin_unit_test
78.74% <ø> (ø)

DataStore_plugin_unit_test
75.53% <ø> (-0.04%)
:arrow_down:

Geo_plugin_unit_test
52.12% <ø> (ø)

Predictions_plugin_unit_test
26.81% <ø> (ø)

Storage_plugin_unit_test
58.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...e/AWSPluginsCore/Auth/AWSAuthServiceBehavior.swift
75.00% <0.00%> (-12.50%)
:arrow_down:

...oreCategoryPlugin/Sync/Support/Model+Compare.swift
69.79% <0.00%> (-2.09%)
:arrow_down:

...tionSync/AWSIncomingEventReconciliationQueue.swift
57.62% <0.00%> (-1.70%)
:arrow_down:

...CategoryPlugin/Operation/AWSGraphQLOperation.swift
52.32% <0.00%> (ø)

...eCategoryPlugin/Sync/RemoteSyncEngine+Action.swift
23.52% <0.00%> (+5.88%)
:arrow_up:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more