Service Fabric-based backplanes

Please consider following use cases when designing pluggable backplane API:

Stateful service-hosted hub with state backed by local Reliable Collections
External generic stateful service designed to act as backplane (backed by Reliable Collections) + integration code
optionally some actor based integration...

@DamianEdwards FYI.  Backlogging this.

We'll look at this after we do service bus and redis. We're very interested in doing this as it fits with the SF's stateful services.

I would like to elaborate on the first point:
It would be really nice to be able to span a hub across multiple replicas of the same single stateful service partition (between primary and multiple secondary replicas). In that case you can allow clients to connect to secondary replicas strongly improving scalability. It should be possible to use reliable collections API in that case.

Hubs themselves are stateless, so I'm assuming you mean usually scale out pluggability (in the new world it's a HubLifetimeManager see redis https://github.com/aspnet/SignalR/blob/ccf6cd415e7e79896ba6b47045ecc5a5f1474460/src/Microsoft.AspNetCore.SignalR.Redis/RedisHubLifetimeManager.cs). If not, can you elaborate on what you mean? The new model requires stickiness so you can't have connections bounce around between nodes and keep their connection state (if that's what you mean).

@davidfowl Yes, I mean the scale out pluggability.
Thanks for mentioning the stickiness requirement.
This stickiness requirement may or may not be difficult in terms of typical Service Fabric implementations:

For websockets it should be trivial and out of the box.
For other protocols it can be really challenging because it will put some strong requirements on the reverse proxy implementation. So basically there will be a requirement for stickiness here.

The architecture for that case is a follows
Client ->  ->  -> Service Fabric Stateless Service (MyReverseProxy) (one of stateless instances) -> Service Fabric Stateful Service replica (MyService) (primary or one of secondaries)

Hubs in replicas can use reliable collections for scale out (those collections are accessible for all the replicas and even have notifications)
Now we need to make sure MyReverseProxy guarantees stickiness.

So there will be some requirements for service resolution logic in MyReverseProxy that as long specific replica is accessible all messages will be routed to the specific replica, that also means that stateless service will require to maintain some kind SHARED resolution cache (or use some kind of cookies).
My basic design plan for similar case was to limit protocols to web-sockets only. This establishes a quite-sticky channel from client to single replica (hub instance) with lifetime bounded by: web sockets connection stability, MyReverseProxy instance lifetime, MyService replica lifetime. What would be definitely good enough.
However when we can add some support in MyReverseProxy for cookies. For example we can store service resolution result in cookies (in a secure way). In that case we would be able to achieve even better lifetime because it would be bound to MyService replica lifetime only - what is an optimal lifetime - because it is exactly the same as hub lifetime.

@davidfowl @mkosieradzki do you envision a Service Fabric back plan using the stateless reliable actor model for hubs/group/users/connections & events?

It has been a while. Is this still on the backlog somewhere? Any news?

We have no plans on doing this. I'll close the issue.

Ok. is due to too many complex factors in play using Service Fabric or is it a lack of time decision? Are there any docs on how to write a backplane?  Just wondering if it makes sense to try create it myself somehow.

A little of both, to be honest :). There aren't docs about writing backplanes, but all you need to do is provide an implementation of HubLifetimeManager<T> and put it in the DI container. So you'd create ServiceFabricHubLifetimeManager<T> which inherits from HubLifetimeManager<T> and implement the methods. You can use the existing RedisHubLifetimeManager as a reference. We're also working on building a test suite for backplane implementations.

To be clear, at this time we're not looking to add more built-in backplanes, so I don't think we're prepared to take this as a PR to this repo. But it's certainly something that can live as a community-maintained extension package!
If you decide to start a project up, please feel free to reach out to us for help (feel free to tag me in GitHub issues/PRs on your repo to take a look at things). I can't guarantee we'll always be able to respond immediately but we'll do our best to help out!

Ok, thanks for the heads up and the great info!

@Expecho Did you ever end up with a solution to this?

@jseekamp  No, sorry. The project I was working on was cancelled so I did not need it anymore.


error with test_net.py

Hello, I get this error when I try to run file test_net.py. Can you show me how to fix it? Thank you.
Traceback (most recent call last):
File "test_net.py", line 95, in
main()
File "test_net.py", line 89, in main
output_folder=output_folder,
File "/HIT/hit/engine/inference.py", line 182, in inference
predictions = compute_on_dataset(model, data_loader, device, logger, mem_active)
File "/HIT/hit/engine/inference.py", line 139, in compute_on_dataset
results_dict = compute_on_dataset_2stage(model, data_loader, device, logger)
File "/HIT/hit/engine/inference.py", line 116, in compute_on_dataset_2stage
output = model(None, None, None, None, extras=extras, part_forward=1)
File /miniconda3/envs/hit/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
return forward_call(*input, **kwargs)
File "/HIT/hit/modeling/detector/action_detector.py", line 20, in forward
result, detector_losses, loss_weight, detector_metrics = self.roi_heads(slow_features, fast_features, boxes, objects, keypoints, extras, part_forward)
File "/miniconda3/envs/hit/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
return forward_call(*input, **kwargs)
File "/HIT/hit/modeling/roi_heads/roi_heads_3d.py", line 13, in forward
result, loss_action, loss_weight, accuracy_action = self.action(slow_features, fast_features, boxes, objects, keypoints, extras, part_forward)
File "/miniconda3/envs/hit/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
return forward_call(*input, **kwargs)
File "/HIT/hit/modeling/roi_heads/action_head/action_head.py", line 44, in forward
x, x_pooled, x_objects, x_keypoints, x_pose = self.feature_extractor(slow_features, fast_features, proposals, objects, keypoints, extras, part_forward)
File "/miniconda3/envs/hit/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
return forward_call(*input, **kwargs)
File "/HIT/hit/modeling/roi_heads/action_head/roi_action_feature_extractor.py", line 145, in forward
ia_feature, res_person, res_object, res_keypoint = self.hit_structure(person_pooled, proposals, object_pooled, objects, hands_pooled, keypoints, memory_person, None, None, phase="rgb")
File "/miniconda3/envs/hit/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
return forward_call(*input, **kwargs)
File "/HIT/hit/modeling/roi_heads/action_head/hit_structure.py", line 213, in forward
mem_feature, phase)
File "/HIT/hit/modeling/roi_heads/action_head/hit_structure.py", line 230, in _reduce_dim
query = self.person_dim_reduce(person)
File "/miniconda3/envs/hit/lib/python3.7/site-packages/torch/nn/modules/module.py", line 1102, in _call_impl
return forward_call(*input, **kwargs)
File "/miniconda3/envs/hit/lib/python3.7/site-packages/torch/nn/modules/conv.py", line 590, in forward
return self._conv_forward(input, self.weight, self.bias)
File "/miniconda3/envs/hit/lib/python3.7/site-packages/torch/nn/modules/conv.py", line 586, in _conv_forward
input, weight, bias, self.stride, self.padding, self.dilation, self.groups
TypeError: conv3d() received an invalid combination of arguments - got (Tensor, Parameter, Parameter, tuple, tuple, tuple, int), but expected one of:

(Tensor input, Tensor weight, Tensor bias, tuple of ints stride, tuple of ints padding, tuple of ints dilation, int groups)
didn't match because some of the arguments have invalid types: (Tensor, Parameter, Parameter, tuple, tuple, tuple, int)
(Tensor input, Tensor weight, Tensor bias, tuple of ints stride, str padding, tuple of ints dilation, int groups)
didn't match because some of the arguments have invalid types: (Tensor, Parameter, Parameter, tuple, tuple, tuple, int)                                                       k_2.key.weight            loaded from roi_heads.action.featu

Fixed in last commit


fix: smoothAlertDialog - uniformization of AlertDialog into SmoothAlertDialog

...and related fixes
Impacted files:

nutrition_page_loaded.dart: 3 more dialogs now as SmoothAlertDialog
product_list_user_dialog_helper.dart: 4 more dialogs now as SmoothAlertDialog
smooth_category_picker_example.dart: 1 more dialog now as SmoothAlertDialog
user_preferences_dev_mode.dart: 3 more dialogs now as SmoothAlertDialog
user_preferences_food.dart: 1 more dialog now as SmoothAlertDialog

What

I encountered bugs when trying to add a product to a list (from the product page) - for some reason the fix by @bhattabhi013 in #1690 does not work anymore.
And then I saw that more generally some pages were still using AlertDialog instead of SmoothAlertDialog.
That's why I switched those AlertDialogs into SmoothAlertDialogs, for code consistency.
As a side effect it apparently solved my bug, but still, the product list dialog does not look well (if you have too many product lists, you go too far, if you use SmoothAlertDialog.advanced you have a full screen even with no product lists)

Thank you for your quick review @M123-dev!
I'll try to fix #1690 #1656 in another PR.


"Unpack requires a buffer of 4 bytes" exception when returning bit(1) column

When returning a bit(1) column in a query, the following exception is thrown:
Request query/subset failed.
Message: Unhandled exception while handling request method query/subset: "unpack requires a buffer of 4 bytes"
Code: -32603

Casting as SIGNED or UNSIGNED is a workaround, but it's inconvenient to have to do this for specific columns rather than selecting *.

@jonahflor
You can try this vsix on windows and confirm if the issue is fixed for you.
https://github.com/microsoft/azuredatastudio-mysql/releases/download/v0.2.3-alpha.1/azuredatastudio-mysql-0.2.3-alpha.1.vsix

The changes will be available in the next release 0.2.3 of
https://github.com/microsoft/azuredatastudio-mysql


Initial Duchy Code

Initial Duchy Code. Which will deploy Duchy VM..

This change is

Closing this PR.


Make automod use message to directly contact each player

Of course this is not tested in real life, yet 🙈

Builds for me on a fresh repository clone, and the tests pass. I'm not familiar with squad automod at all, we don't use it for our server.
The only thoughts I have on this are would it be a bad idea to turn the default_config.yml strings into placeholders that we could then str.format() to make them internally consistent?
For instance users can change warning_interval_seconds to something besides 60, but warning_message: "Warning! Your squad does not have an officer. Players of squads without an officer will be punished, then kicked.\nNext check will happen automatically in 60s." always says 60 and requires users to be aware of and able to change that to be consistent.
We wouldn't be accepting arbitrary input from the internet/random so I don't think it's an inherently terrible idea, but it would provide more opportunity to confuse users.

Builds for me on a fresh repository clone, and the tests pass. I'm not familiar with squad automod at all, we don't use it for our server.

Do they? At least one test failed for me, but it fails on a clean repo as well 🙈 (I also had to change one test, as it was failing on a clean repo as well) :) But good to know. (It was the config test, however, as I did not change anything there, I "dismissed" that for now).

Sorry I meant the tests for squad automod passed for me, I also got failing ones from a different test file.

Looks good. We should way for the update before merging though I guess. Or we make a beta branch and I add a docker build on top


Errors with channel put limits

I'm experiencing some problems when listening to message event. Here's an excerpt of the problem:
Assert failed: No more than 1024 pending puts are allowed on a single channel. Consider using a windowed buffer.
(< (.size puts) impl/MAX-QUEUE-SIZE)
        at clojure.core.async.impl.channels.ManyToManyChannel.put_BANG_(channels.clj:152)
        at clojure.core.async.impl.ioc_macros$put_BANG_.invokeStatic(ioc_macros.clj:992)
        at clojure.core.async.impl.ioc_macros$put_BANG_.invoke(ioc_macros.clj:991)
        at slack_rtm.core$ws_connect$fn__12465$fn__12481$state_machine__9446__auto____12488$fn__12490.invoke(core.clj:38)
        at slack_rtm.core$ws_connect$fn__12465$fn__12481$state_machine__9446__auto____12488.invoke(core.clj:38)
        at clojure.core.async.impl.ioc_macros$run_state_machine.invokeStatic(ioc_macros.clj:973)
        at clojure.core.async.impl.ioc_macros$run_state_machine.invoke(ioc_macros.clj:972)
        at clojure.core.async.impl.ioc_macros$run_state_machine_wrapped.invokeStatic(ioc_macros.clj:977)
        at clojure.core.async.impl.ioc_macros$run_state_machine_wrapped.invoke(ioc_macros.clj:975)
        at slack_rtm.core$ws_connect$fn__12465$fn__12481.invoke(core.clj:38)

Apparently this error doesn't affect new messages listening so I don't get what's the real impact of it. Seems to be related with clojure.core.async channels.

Is this easy to reproduce? Would it be possible for you to share an excerpt of the code you are working with?

@casidiablo To reproduce I've just let the application up for some minutes and that error started to show up.
Here's the code:
(require '[slack-rtm.core :as rtm])
(require '[clj-slack.groups :as groups])

(def rtm-conn (rtm/rtm-connect *TOKEN*))

(def events-publication (:events-publication rtm-conn))

(rtm/sub-to-event events-publication :pong)
(def dispatcher (:dispatcher rtm-conn))
(rtm/send-event dispatcher {:type \"ping\"}) ;; To avoid constant disconnects

(defn message-receiver [e]
  (when (and (= channel-name (get e :channel))
             (not (get e :subtype false))
             (not (get e :edited false))
             (not (get e :thread_ts false)))
    (doto queue (.put (new sisc.data.ImmutableString (get e :text))))))
(rtm/sub-to-event events-publication :message message-receiver)

Just to update: this problem was being caused because I was creating a listener for each channel (I need to separate each message from a channel and put in their respective queue), so I solved this issue by changing a little bit my logic and putting a single listener accessing all the queues and channels.
Closing it.


Using a vector of strings as input for Universal Sentence Encoder model

Amazing library! Thank you very much for creating it.
I am trying to use cppflow with the Universal Sentence Encoder model. Unfortunately, I am not sure how to pass a vector of strings to the model. This is the code I use:
#include <iostream>

#include "cppflow/cppflow.h"

int main() {
    std::string input_string = "This is a test";
    auto inputs = cppflow::tensor(input_string);

    // Load the model
    cppflow::model model("path/to/encoder");

    // Run
    auto output = model({{"serving_default_inputs", inputs}}, {{"StatefulPartitionedCall_1"}});

    // Show the predicted class
    std::cout << output << std::endl;
}

This fails with
terminate called after throwing an instance of 'std::runtime_error'
  what():  {{function_node __inference_pruned_2009}} {{function_node __inference_pruned_2009}} input must be a vector, g
ot shape: []
         [[{{node text_preprocessor/tokenize/StringSplit/StringSplit}}]]
         [[StatefulPartitionedCall_1/StatefulPartitionedCall/StatefulPartitionedCall/StatefulPartitionedCall]]

How do I pass a vector of strings to this model?

Hi @JohnMrziglod
You are feeding the model with a tensor with shape=[], that is, a scalar. But the model requires a vector 'shape=[-1]'. You can convert the scalar into a vector with the cppflow::reshape method. Note the difference between both:
std::cout << cppflow::tensor(std::string("hello")) << std::endl;
// (tensor: shape=[], data="hello")
std::cout << cppflow::reshape(cppflow::tensor(std::string("hello")), {-1}) << std::endl;
// (tensor: shape=[1], data=["hello"])

If you need a vector with multiple strings, you can use cppflow::concat:
auto s1 = cppflow::tensor(std::string("hello"));
auto s2 = cppflow::tensor(std::string("hello"));
auto s3 = cppflow::tensor(std::string("hello"));

std::cout << cppflow::concat(0, {s1, s2, s3});
// (tensor: shape=[3], data=["hello" "hello" "hello"])

Hope it helps!

Amazing, thank you!


[Bug]: Using backspace in in search removes spaces in random places

Is there an existing issue for this?

[X] I have searched the existing issues

Is there a StackOverflow question about this issue?

[X] I have searched StackOverflow

What happened?
When trying to erase text in the search bar it removes spaces in random places.
https://github.com/android/nowinandroid/assets/41597036/fd204f34-ff01-4dad-b42d-1b9a6ff95d2a
I am using android 11 with AOSP keyboard.
Relevant logcat output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

This seems like an issue with the softkeyboard of your emulator.
I've tested it on 2 devices and was not able to reproduce the issue.
There is no custom parsing on the text input (SearchTextField).
Also, it seems like your keyboard tries to auto-correct the content (which might explain your issue) as you can see the underlined words.

I can reproduce this on all AOSP builds while using the AOSP stock keyboard.
I have disabled text correction and it still does it. It does not seem to happen in other apps, only in this app.
https://github.com/android/nowinandroid/assets/41597036/13b8b0e2-245d-41a5-ae9b-060a81844fe9
This was on a android 12 default image

I can confirm that this is an issue with the software keyboard. The issue probably happens because of the spellchecker. Here is a related issue from Google support: Underline appears under text being typed. So, @VerdommeMan could you please try turning off the spellchecker from the Settings and see if it works?

Thanks for noting this, I created an upstream issue here, https://issuetracker.google.com/issues/294102838. I don't think this is due to anything we're doing in Now in Android since I could reproduce with a very basic text field in the AndroidX demo project.


Build libraries for iOS

Before you open an issue, please make sure you have tried the following steps:

Make sure your environment is the same with (https://mace.readthedocs.io/en/latest/installation/env_requirement.html).
Have you ever read the document for your usage?
Check if your issue appears in HOW-TO-DEBUG or FAQ.
The form below must be filled.

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 16.04
NDK version(e.g., 15c): 18b
GCC version(if compiling for host, e.g., 5.4.0): 5.4.0
MACE version (Use the command: git describe --long --tags): 0.13.0
Python version(2.7): 3.6
Bazel version (e.g., 0.13.0): 0.16.0
CMake version: 3.16.0

Model deploy file (*.yml)
# The name of library
library_name: FD
target_abis: [arm64-v8a]
model_graph_format: code
model_data_format: code
models:
  RF: # model tag, which will be used in model loading and must be specific.
    platform: caffe
    # path to your tensorflow model's pb file. Support local path, http:// and https://
    model_file_path: /models/model.prototxt
    weight_file_path: /models/model.caffemodel
    # sha256_checksum of your model's pb file.
    # use this command to get the sha256_checksum --> sha256sum path/to/your/pb/file
    model_sha256_checksum: 98f9b69a085e7d8f40704ac6b2fedae0fda876fff4658509dde3d74d883a9684
    weight_sha256_checksum: a9f5d4dfe944315511c6070e8556790409ae0f0bd9005c5db66b4fdd5c38b716
    subgraphs:
      - input_tensors:
          - data
        input_shapes:
          - 1,3,112,112
        input_data_formats:
          - NCHW
        output_tensors:
          - fc1
        output_shapes:
          - 1,1,1,512
    obfuscate: 0
    runtime: gpu
    winograd: 4

Describe the problem
Is it possible to cross-compile a libmace and models to shared library for iOS? I read that it's theoretically possible using bazel (example in travis CI file), but what about when using CMake? And how can I reproduce the build process locally on my machine?
To Reproduce
Steps to reproduce the problem:
1. cd /path/to/mace
2. python tools/converter.py convert --config_file=/path/to/your/model_deployment_file

Error information / logs
Please include the full log and/or traceback here.
Additional context

@gasgallo I have tried to compile mace on the Ubuntu OS but found that there were many problems to be solved, so I gave up. It is recommended to compile directly on Mac OS.

@lu229 ok, thanks. What about using CMake?

@lu229 ok, thanks. What about using CMake?

CMake is the same as the Bazel, because they are all depend on the cross-compile tool chain.

@lu229 Yes, but how do I build MACE with CMake on Mac OS? Do you guys provide a script like for android or a toolchain file?

@gasgallo  Sorry, we did not provided it, you can use bazel?  whose command is in this file.

Ok, thanks. I will try bazel first.

@lu229 would the MACE team be interested in supporting iOS build with CMake? I can help with it.

@lu229 would the MACE team be interested in supporting iOS build with CMake? I can help with it.

Sorry for the late reply.
@gasgallo yes, of course, but at present, we don't have the manpower to complete this task. If you are interested in making a contribution, we certainly welcome it!


[BUG] publishBlob doesn't work with reading secret from environment variable

SynapseML version
0.10.2
System information

Language version (e.g. python 3.8, scala 2.12):
Spark Version (e.g. 3.2.3):
Spark Platform (e.g. Synapse, Databricks):

Describe the problem

Before executing command "publishBlob", set storage secret to environment variable
~ export STORAGE-KEY=
export: not valid in this context: STORAGE-KEY

the problem is that hyphen is not allowed in environment variable name.
all env names are defined in https://github.com/microsoft/SynapseML/blob/master/project/Secrets.scala
it's better to switch them to use underscore in name.
for example:
val StorageKeyEnvVarName: String = "STORAGE-KEY"
==>
val StorageKeyEnvVarName: String = "STORAGE_KEY"
Code to reproduce issue
N/A
Other info / logs
No response
What component(s) does this bug affect?

[ ] area/cognitive: Cognitive project
[ ] area/core: Core project
[ ] area/deep-learning: DeepLearning project
[ ] area/lightgbm: Lightgbm project
[ ] area/opencv: Opencv project
[ ] area/vw: VW project
[ ] area/website: Website
[ ] area/build: Project build system
[ ] area/notebooks: Samples under notebooks folder
[ ] area/docker: Docker usage
[ ] area/models: models related issue

What language(s) does this bug affect?

[ ] language/scala: Scala source code
[ ] language/python: Pyspark APIs
[ ] language/r: R APIs
[ ] language/csharp: .NET APIs
[ ] language/new: Proposals for new client languages

What integration(s) does this bug affect?

[ ] integrations/synapse: Azure Synapse integrations
[ ] integrations/azureml: Azure ML integrations
[ ] integrations/databricks: Databricks integrations

Hi @dylanw-oss.  When you set environment variables from the names listed in Secrets.com, just convert hyphens to underscores. In your particular case, publishBlob is run as a side effect of running "azp run".  That is, leave a comment in a PR that reads "azp run". This will force a build in our internal Azure Devops pipeline, and as a part of that build, publishBlob will be run.

closing this as we really design publishing to work through the pipeline, and not through local Linux environments.

I need local publish to get private build for integration test.
I did it by using command "az login" and "sbt publishBlob" previously.
But for some reason (recent code changes?), this doesn't work anymore.

For others that run into this issue the fix was to run az account -s OUR_SUBSCRIPTION_ID prior to running the build


feat: use crud client lib

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

38 of 52 (73.08%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.8%) to 83.766%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

helpers/headers_to_proxy.go
0
14
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.8%

Covered Lines:
1677

Relevant Lines:
2002

💛  - Coveralls


Kotlin Mutliplatform build with reused daemon fails with "Cannot query the value of task ':compileKotlinWindows' property 'kotlinNativeBundleBuildService' because it has no value available."

 (I reduced the problem to the bare minimum i could still reproduce it.)
Before (gradle 8.10) this used to build fine.
Now (gradle 8.10.1) this is a weird, partially random build bug. It seems to be related to 3 things:

this is a Kotlin Multiplatform Project (which do quite some gradle magic under the hood)
as one of the Kotlin multiplatform targets it builds a native executable (kotlin can compile to native e.g. mingw (windows), linux, mac, ios binaries.) I tested both mac (M1) and windows (mingw) - any of them or both will do.
It seems to be, that the bug only happens, if a gradle daemon is reused.
3.1. build with a fresh gradle => builds fine (gradle clean build)
3.2. directly afterwards again run "gradle clean build", this will reuse the gradle daemon, which was started in the first build .
This second build fails with a strange exception (before narrrowing it down to this minimal example, the error seemed to randomly jump between different messages, here it seems to be quite stable):

Task :compileKotlinWindows FAILED

FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':compileKotlinWindows'.

Error while evaluating property 'kotlinNativeProvider$kotlin_gradle_plugin_common.kotlinNativeBundleVersion$kotlin_gradle_plugin_common' of task ':compileKotlinWindows'.
Cannot query the value of task ':compileKotlinWindows' property 'kotlinNativeBundleBuildService' because it has no value available.

Expected Behavior
should stable build as before, no matter, if a daemon is reused or not
Context (optional)
build my projects on the command line (windows: git bash, mac: zsh)
Self-contained Reproducer Project
Foo.zip
Gradle version
8.10.1
Gradle version that used to work
8.10
Build scan URL (optional)
No response
Your Environment (optional)
Mac (M1) and Windows (git bash)

This issue needs a decision from the team responsible for that area. They have been informed. Response time may vary.

Relates to:

#30472

@6hundreds Could you make sure #30488 also fixes this issue?

@6hundreds Could you make sure https://github.com/gradle/gradle/pull/30488 also fixes this issue?

Actually there are two problems, that must be solved. We are working on solution that will be fix both of them, and it seems like it will be not a #30488

Hello @GST1DR and @alyssa-nash ,
Could you try version 8.10.2-milestone-1 and report the results?
./gradlew wrapper --gradle-version 8.10.2-milestone-1

Hello dear gradle maintainers,
i did some tests on all my gradle projects and the 8.10.2-milestone-1 seems to solve the problem. However, since the problem (from my user perspective) seemed to have some random component (did not occur always and if it occurred, the error differed), I am not 100% sure, that everything is ok (but quite sure).
What I did: build several real-world-projects with:

Gradle 8.10
Gradle 8.10.1
Gradle 8.10.2-milestone-1

Each time I did 2 subsequent builds to simulate what I considered the cause of the problem.
Outcome:

Some projects build ok/ok/ok, i.e. they were not affected by the problem in the first place, but the new milestone did not introduce new obvious problems
Other projects build ok/error/ok, i.e. they were affected and the milestone seemed to solve the problem. (and not introduce new obvious ones)
Thanks!

Mit freundlichen Grüßen / Best regards
Dr. Steffen Guhlemann
Manufacturing Engineering (DrP/MFE)
Robert Bosch Semiconductor Manufacturing Dresden GmbH | Robert-Bosch-Ring 1 | 01109 Dresden | GERMANY
Tel. +49 351 8547-3530 | Mobil +49<PHONE_NUMBER>4 |<EMAIL_ADDRESS>Sitz: Dresden, Registergericht: Amtsgericht Dresden, HRB37117
Geschäftsführung: Dr. Dirk Drescher, Dr. Patrick Leinenbach

Von: Louis Jacomet @.>
Gesendet: Freitag, 20. September 2024 09:37
An: gradle/gradle @.>
Cc: Guhlemann Steffen (DrP/MFE2) @.>; Mention @.>
Betreff: Re: [gradle/gradle] Kotlin Mutliplatform build with reused daemon fails with "Cannot query the value of task ':compileKotlinWindows' property 'kotlinNativeBundleBuildService' because it has no value available." (Issue #30477)
Hello @GST1DRhttps://github.com/GST1DR and @alyssa-nashhttps://github.com/alyssa-nash ,
Could you try version 8.10.2-milestone-1 and report the results?
./gradlew wrapper --gradle-version 8.10.2-milestone-1
—
Reply to this email directly, view it on GitHubhttps://github.com/gradle/gradle/issues/30477#issuecomment-2363030789, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BILMLD5RDSKBXZK4RNCIWIDZXPGBFAVCNFSM6AAAAABN67L53SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRTGAZTANZYHE.
You are receiving this because you were mentioned.Message ID: @.***>

8.10.2-milestone-1 solved the problem for us


Disable creation of IAM Policy if no iam policy statements

Found a bug? Maybe our Slack Community can help.

Describe the Bug
You may want an IRSA for best practices without an IAM policy to further reduce blast radius so you can have a pod not use the eks node worker role by default.
If you enable an iam role without supplying policy statements, you receive this bug
╷
│ Error: creating IAM Policy
|
| MalformedPolicyDocument: Syntax errors in policy.
│
│   with module.datadog_agent.module.eks_iam_role.aws_iam_policy.service_account[0],
│   on .terraform/modules/datadog_agent.eks_iam_role/main.tf line 85, in resource "aws_iam_policy" "service_account":
│   85: resource "aws_iam_policy" "service_account" {

Expected Behavior
Enable the IAM role without creating an iam policy resource
Additional Context

Similar https://github.com/cloudposse/terraform-aws-helm-release/issues/37

Closing as wontfix because the point of this module is to create a policy. If you don't want one created, set enabled=false. If you want a policy that does not allow anything, you can pass in
{
    effect = "Deny",
    action = "*",
    resource = "*"
}


Add options for custom typeface and make recyclerview a provided dependency

Two parts:

Added options for setting custom typefaces for the snackbar text and action label, with an update to the sample app for this.
Make RecyclerView a provided dependency.

To elaborate on the second part a bit (from the commit message):

If a developer doesn't use it, then this becomes an unnecessary extra dependency that exists for the sole purpose of attaching to and dismissing when a recyclerview scrolls. By marking it provided (and moving some code around), we can make sure this there for the developers that need it without unnecessarily burdening other developers with it as a transitive dependency.

I did the same thing for @afollestad's Material-Dialogs library as well a few weeks back. A library should be as lean as possible, and using provided allows for that flexibility. The only downside here is that you lose the compile-time type checking on the attachToRecyclerView method and instead have to have it at runtime.

Here's a screenshot of the custom font setting in action

thanks!

Happy to help :)


update README

https://jumpshare.com/s/trrjYNoBpDL9YXJIETKb to see how it looks

https://jumpshare.com/s/trrjYNoBpDL9YXJIETKb to see how it looks

Link is dead?

https://jumpshare.com/s/trrjYNoBpDL9YXJIETKb to see how it looks

Link is dead?

Try this one - links are available for 24h only
https://jmp.sh/s/65Kcg0xgznRAByPxfy0p


PTNFLY-1335 Login page.

LGTM

LGTM

@dlabrecq , rebased and applied the changes you instructed me to do. Tested and it looks very good here.


Update ProviderProps in index.d.ts

Description
ProviderProps did not match what Provider was actually expecting. This PR updates the definition of ProviderProps to remove mountNode and add rehydrate.

Thanks for the PR :)


[BACKLOG-27714] Add named connections

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/connections/ConnectionDetails.java
  core/src/main/java/org/pentaho/di/connections/ConnectionManager.java
  core/src/main/java/org/pentaho/di/connections/ConnectionProvider.java
  core/src/main/java/org/pentaho/di/connections/LookupFilter.java
  core/src/main/java/org/pentaho/di/connections/vfs/VFSConnectionDetails.java
  core/src/main/java/org/pentaho/di/connections/vfs/VFSConnectionProvider.java
  core/src/main/java/org/pentaho/di/connections/vfs/VFSHelper.java
  core/src/main/java/org/pentaho/di/connections/vfs/VFSLookupFilter.java
  core/src/main/java/org/pentaho/di/connections/vfs/VFSRoot.java
  core/src/main/java/org/pentaho/di/connections/vfs/builder/VFSConnectionConfigurationBuilder.java
  core/src/main/java/org/pentaho/di/connections/vfs/providers/other/OtherConnectionDetails.java
  core/src/main/java/org/pentaho/di/connections/vfs/providers/other/OtherConnectionDetailsProvider.java
  core/src/test/java/org/pentaho/di/connections/ConnectionManagerTest.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
:new: org.pentaho.di.connections.ConnectionManager

Branch Coverage: 60.7% :exclamation:
Complexity Coverage: 71.8% :exclamation:

:new: org.pentaho.di.connections.ConnectionManager.Type

Complexity Coverage: 20% :exclamation:
Instruction Coverage: 39.1% :exclamation:
Line Coverage: 40% :exclamation:
Method Coverage: 20% :exclamation:

:new: org.pentaho.di.connections.vfs.builder.VFSConnectionConfigurationBuilder

Coverage: 0% :exclamation:

:new: org.pentaho.di.connections.vfs.providers.other.OtherConnectionDetails

Coverage: 0% :exclamation:

:new: org.pentaho.di.connections.vfs.providers.other.OtherConnectionDetailsProvider

Coverage: 0% :exclamation:

:new: org.pentaho.di.connections.vfs.VFSHelper

Coverage: 0% :exclamation:

:new: org.pentaho.di.connections.vfs.VFSLookupFilter

Branch Coverage: 50% :exclamation:
Complexity Coverage: 60% :exclamation:

:new: org.pentaho.di.connections.vfs.VFSRoot

Coverage: 0% :exclamation:

org.pentaho.di.job.entries.getpop.MailConnectionMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.5% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:

org.pentaho.di.job.entries.sql.JobEntrySQL

Instruction Change: -3.4% :small_red_triangle_down:
Line Change: -3.8% :small_red_triangle_down:

org.pentaho.di.trans.steps.dimensionlookup.DimensionLookupMeta

Method Change: -1% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -1% :small_red_triangle_down:
Complexity Change: -1.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta

Branch Change: -3.3% :small_red_triangle_down:
Complexity Change: -3.8% :small_red_triangle_down:
Instruction Change: -0.3% :small_red_triangle_down:
Line Change: -0.9% :small_red_triangle_down:

org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.salesforceinsert.SalesforceInsertMeta

Instruction Change: -0.1% :small_red_triangle_down:

Note: The list of offending coverage changes extends beyond the presented results and was truncated to prevent reaching the comment size limit.

License header violations

:heavy_exclamation_mark: Couldn't find acceptable copyright on core/src/main/java/org/pentaho/di/connections/vfs/VFSRoot.java

:heavy_exclamation_mark: Couldn't find acceptable license on core/src/main/java/org/pentaho/di/connections/vfs/VFSRoot.java

Checkstyle violations
The code submitted is not complying with one or more of our guidelines. To perform these checks locally, please use this tool.
/home/buildguy/project/core/src/main/java/org/pentaho/di/connections/ConnectionManager.java

:heavy_exclamation_mark: Unused import - com.google.common.annotations.VisibleForTesting. at Line: 25 Column: 8

/home/buildguy/project/core/src/main/java/org/pentaho/di/connections/vfs/providers/other/OtherConnectionDetailsProvider.java

:heavy_exclamation_mark: Unused import - org.pentaho.di.connections.ConnectionDetails. at Line: 29 Column: 8

Build Completed
:fire: This pull request has some issues. It would be preferable to fix them in order for it to be just perfect. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -f 'pom.xml' -pl 'core' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install

Cleanup Commands
mvn -B -f 'pom.xml' -pl 'core' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  core/src/main/java/org/pentaho/di/connections/ConnectionDetails.java
  core/src/main/java/org/pentaho/di/connections/ConnectionManager.java
  core/src/main/java/org/pentaho/di/connections/ConnectionProvider.java
  core/src/main/java/org/pentaho/di/connections/LookupFilter.java
  core/src/main/java/org/pentaho/di/connections/vfs/VFSConnectionDetails.java
  core/src/main/java/org/pentaho/di/connections/vfs/VFSConnectionProvider.java
  core/src/main/java/org/pentaho/di/connections/vfs/VFSHelper.java
  core/src/main/java/org/pentaho/di/connections/vfs/VFSLookupFilter.java
  core/src/main/java/org/pentaho/di/connections/vfs/VFSRoot.java
  core/src/main/java/org/pentaho/di/connections/vfs/builder/VFSConnectionConfigurationBuilder.java
  core/src/main/java/org/pentaho/di/connections/vfs/providers/other/OtherConnectionDetails.java
  core/src/main/java/org/pentaho/di/connections/vfs/providers/other/OtherConnectionDetailsProvider.java
  core/src/test/java/org/pentaho/di/connections/ConnectionManagerTest.java

Unit Test Coverage
These statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to Jacoco's documentation.

:warning: Coverage Changes (click to expand)
:new: org.pentaho.di.connections.ConnectionManager

Branch Coverage: 60.7% :exclamation:
Complexity Coverage: 71.8% :exclamation:

:new: org.pentaho.di.connections.ConnectionManager.Type

Complexity Coverage: 20% :exclamation:
Instruction Coverage: 39.1% :exclamation:
Line Coverage: 40% :exclamation:
Method Coverage: 20% :exclamation:

:new: org.pentaho.di.connections.vfs.builder.VFSConnectionConfigurationBuilder

Coverage: 0% :exclamation:

:new: org.pentaho.di.connections.vfs.providers.other.OtherConnectionDetails

Coverage: 0% :exclamation:

:new: org.pentaho.di.connections.vfs.providers.other.OtherConnectionDetailsProvider

Coverage: 0% :exclamation:

:new: org.pentaho.di.connections.vfs.VFSHelper

Coverage: 0% :exclamation:

:new: org.pentaho.di.connections.vfs.VFSLookupFilter

Branch Coverage: 50% :exclamation:
Complexity Coverage: 60% :exclamation:

:new: org.pentaho.di.connections.vfs.VFSRoot

Coverage: 0% :exclamation:

org.pentaho.di.job.entries.ftpsget.JobEntryFTPSGet

Branch Change: -0.6% :small_red_triangle_down:
Complexity Change: -0.5% :small_red_triangle_down:
Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.constant.ConstantMeta

Instruction Change: -0.1% :small_red_triangle_down:

org.pentaho.di.trans.steps.excelwriter.ExcelWriterStepMeta

Branch Change: -1.3% :small_red_triangle_down:
Complexity Change: -0.7% :small_red_triangle_down:

org.pentaho.di.trans.steps.groupby.GroupByMeta

Branch Change: -2% :small_red_triangle_down:
Complexity Change: -2.1% :small_red_triangle_down:
Instruction Change: -0.2% :small_red_triangle_down:
Line Change: -0.3% :small_red_triangle_down:

org.pentaho.di.trans.steps.tableoutput.TableOutputMeta

Branch Change: -0.9% :small_red_triangle_down:
Complexity Change: -0.8% :small_red_triangle_down:

@ddiroma


Craft v3 compatibility

This is an initial port of Anchors plugin to componers/v3 syntax.
Things I still need to do:

[ ] Make namespace pixelandtonic
[x] Update authors in composer.json
[ ] Make release version 2.0.0
[ ] Update craft dependency
[x] Update readme

Hi guys! Sorry to bother you on this (and I know you're busy) - just wanted to put this back on your radar 😄

@mikestreety it's still on the radar.  We've got a new person working with us and they're ramping up. One of the first things they do will be converting our C2 plugins to C3 and will have them review this.

Great - thanks @takobell. Sorry to hassle. Will keep an eye out 😄


Flutter Build Failed

Hi, I'm interested in your plugin and tried to use it. I'm working with VSCode in Windows 10 Home, target is an Android S21.
I created a new APP in flutter, the counter app, and I did not add any line that calls your package, just added all the configuration steps indicated in your readme file, just to set up and check that every thing goes.
I had to change this: classpath "com.chaquo.python:gradle:latest-version"
into this: classpath 'com.chaquo.python:gradle:12.0.0'
because it was not capable to resolve it.
When I run Start debugging I get an error, can you please help?
I paste here the debug console output ----->
Launching lib\main.dart on SM G991B in debug mode...
lib\main.dart:1
e: C:\Portable\flutter.pub-cache\hosted\pub.dartlang.org\chaquopy-0.0.16\android\src\main\kotlin\com\chaquopy\chaquopy\ChaquopyPlugin.kt: (51, 36): Type mismatch: inferred type is String? but String was expected
e: C:\Portable\flutter.pub-cache\hosted\pub.dartlang.org\chaquopy-0.0.16\android\src\main\kotlin\com\chaquopy\chaquopy\ChaquopyPlugin.kt: (51, 41): Type mismatch: inferred type is String? but String was expected
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':chaquopy:compileDebugKotlin'.

Compilation error. See log for more details

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 1m 8s
Exception: Gradle task assembleDebug failed with exit code 1
Exited (sigterm)

I've had the same problem, as a workaround fixed it by changing
-val code: String = call.arguments()
+val code: String = call.arguments() ?: ""

in ChaquopyPlugin.kt

Thank you very much, that solved the build problem!

@davidyuk Thanks for your solution, I have pushed a new update and mentioned your contribution.


text-decoration underline is misplaced

Bug reports:
http://jsfiddle.net/8rjbyqgj/
As you can see in jsfiddle, links that have a text-decoration: underline rule renders with a line above it
Specifications:

html2canvas version tested with: 1.0.0-alpha-8
Browser & version: chrome 63 & IE 11
Operating system: Windows 7

I recently started using the last version of HTML2Canvas which should include the fix described above, however I kept getting a misplaced underline when I used text-decoration: underline just like it's mentioned at the beginning of this thread, I managed to fix the issue by modifying Math.round(text.bounds.top + text.bounds.height - baseline) to Math.round(text.bounds.top + text.bounds.height) in CanvasRenderer.js file


Removal of old tutorials

The v0.15 documentation contains references to many old tutorials, for example from v0.7. Which the upcoming v0.16 documentation, should we consider removing these old tutorials or properly integrating them with v0.16?
Should these old tutorials be removed or properly adopted in v0.16.
Links to previous versions in current docs

[ ] Istio examples

[ ] Hybrid (A/B + SLOs) testing
[ ] SLO validation
[ ] SLO validation (single version)
[ ] Progressive traffic shifting
[ ] Fixed % split

[ ] kserve examples

[ ] A/B Testing and Progressive Traffic Shift
[ ] Hybrid (A/B + SLOs) testing
[ ] Progressive traffic shifting
[ ] Fixed-%-split
[ ] Session affinity

[ ] seldon examples

[ ] Hybrid (A/B + SLOs) testing
[ ] Progressive traffic shifting

[ ] linkerd a/b
[ ] Docs for Iter8 v0.8
[ ] Docs for Iter8 v0.7

Link to external blog

[ ] knative http and grpc

@sriumcp any thoughts on this?

I am in the opinion of removing this old tutorials. A lot of them seem to be incompatible (for example, requiring assess). In the very least, they need to be rewritten and tested for v0.16

Links to previous versions in current docs

[ ] Istio examples

[ ] Hybrid (A/B + SLOs) testing
[ ] SLO validation
[ ] SLO validation (single version)
[ ] Progressive traffic shifting
[ ] Fixed % split

[ ] kserve examples

[ ] A/B Testing and Progressive Traffic Shift
[ ] Hybrid (A/B + SLOs) testing
[ ] Progressive traffic shifting
[ ] Fixed-%-split
[ ] Session affinity

[ ] seldon examples (leave as is for now)

[ ] Hybrid (A/B + SLOs) testing
[ ] Progressive traffic shifting

[ ] linkerd a/b (remove)
[ ] Docs for Iter8 v0.8 (remove)
[ ] Docs for Iter8 v0.7 (remove)
[ ] Litmus examples (remove chaos tutorial from the tutorials but keep link to v0.15 tutorial in integrations)

done in v0.16


Digital Locker - 2 issues in sol file

There are two issues with the current digitallocker.sol file which caused the contact not to be accepted in workbench:

Spelling issue - currently this is how the line looks like in the contract: ContractUpdated("UploadDocments");  the word Documents is misspelt - it should be corrected to ContractUpdated("UploadDocuments");
Incorrect contract name - currently this is how the line looks like in the contract: ContractUpdated("AvailableToShare") - it should be corrected to ContractUpdated("ReleaseLockerAccess");

I made the 2 changes in my local copy and was able to execute the application...

@rizzeeb Thank you for reporting this issue, you are correct. I've fixed the files.
Starting workbench 1.6.0 (should be released in January) you do not need to explicitly call ContractUpdated anymore


tools -> create gist

gist doesn't have an easy to use interface. It's not possible to create gists by url as issues.
So to work with gist, should be necessary to register a git app, and work with github api.
To many work for a simple enhancement. It's being cancelled, if necessary, I can reopen later


Improve Developer Experience with Arc

I'm migrating a project from Google Cloud Functions to AWS with Arc. So far I'm quite happy with the results and arc makes it fairly easy to deploy to Lambda, thanks for that!
One thing I quite liked in GCF was structure of functions:
index.js
- functions/
- functions/eventsList.js
- functions/eventsGet.js
- functions/eventsNew.js
...

index.js looks like
const cors = require('./lib/middlewares/cors')
const handleErrors = require('./lib/middlewares/handleErrors')
const getId = require('./lib/getId')

exports.models = handleErrors(
  cors((request, response) => {
    switch (request.method) {
      case 'GET': {
        if (getId(request.path)) {
          return require('./functions/eventsGet')(request, response)
        }
        return require('./functions/eventsList')(request, response)
      }
      case 'POST': {
        return require('./functions/eventsNew')(request, response)
      }
    }
  })
)

This allows to group functions by "business case"/unit and it's easy to navigate to each file with shortcuts. Libraries and helpers can be included in several individual functions while they're available to the whole unit. They don't need to be copied into each function folder and refresh instantly (unlike shared code in arc).
I feel like this could greatly improve the developer experience to bundle the code and have more control over the entrypoint, rather than having so many individual folders with an index.js.

I'm closing this out for now because I can't think of a clean way to get this sort of experience without falling into either having 1 big function for everything (and using routing logic), adding new configuration which has bad tradeoffs for ppl that like moving stuff around, or building a compile chain (something we're not opposed to…but not ready for just yet).
Please feel free to reopen or add new ideas! Def want to improve our perceived dev experience.


Update performance-guidelines-best-practices-storage.md

This PR will be replaced by an internal PR.


Increase PHPStan level and reset baseline

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 81.107%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1949

Relevant Lines:
2403

💛  - Coveralls


Ps4 Issue

Please make sure your issue complies with these guidelines:

[ ] Server Software must be the official PMMP w/o vanilla patching plugins (i.e. TeaSpoon)

[ ] Issue must have not been reported previously

[ ] Make sure you are on the latest version of PMMP & PiggyAuctions

[ ] Have a detailed title (i.e "Auctioned items remain in inventory")

Issue Description

Expected result: What were you expecting to happen? Do /ah and gui suppose to show up
Actual result: What actually happened? Nothing showed up

Steps to Reproduce the Issue

... Use ps4
... Run /ah

OS and Versions

PocketMine-MP: Latest
PiggyAuctions: Latest
PHP:
Server OS:

Extra Information
This issue seems to be happening to ps4 players only

Please give the name of the PiggyAuctions version. Latest is not sufficient.

Dev 33, and sorry here is the video https://youtu.be/yZo37n2b4eE

Did you restart the server, or did you use /reload?

This issue could not be reproduced, at least on an Xbox One X.
Most likely, you used /reload to install the plugin which caused the virion InvMenu to stop working.

nope i dont use /reload but okay

This issue should be fixed on PiggyAuctions v1.0.8


🗺  Create Diagram of the AWS QuickSight Implementation

The purpose of this ticket is to ensure that an architectural diagram of the QuickSight implementation is created and recorded in the appropriate location - ADR if necessary.

Duplicate of #3314


fix download consistency

fixes https://github.com/owncloud/ocis/issues/10526

[ ] refactor code to reuse sections
[ ] changelog

How would changing the signature of Download() differ from using the ConsistentDownloader interface? ConsistentDownload() already returns both: the metadata (so we can omit the stat, which is used to return the content length header ... and we should return the checksum IIRC) as well as a callback to get a ReadCloser. Why a callback? Because for s3 getting the reader might be expensive and unnecessary for a HEAD operation.
🤔
Posixps could already open the file but then how do we close it if it is never read?

Hm. No, we return early when the etag didn't change, without calling getContent, no?  Download already handles the if-match header case. If we also teach it the if-none-match case we wouldn't have to open the reader for the cases where it won't be needed.

Yeah, I'd really like to be efficient in that case and not even open the file then.

urgh the ceph fs build fails ... we should have used an additional interface ...


New comments panel: date of last reply is wrong

In the comments overview, the date of the last reply is wrong. It looks like it took the date of the first comment:

(cc @hermannloose, @alexr00)

I have a fix for this, I'll send a PR.


Ghost icons for defaultNamed persistent workspaces Hyprland

If you have a workspace with persistnent: true and some defaultName, you'll get a ghost icon with a workspace id.
Issue wasn't present in previous version of waybar.
Steps to reproduce:

Add to your hyprland config persistent workspace with default name:
workspace = 1,	defaultName:terminal, persistent:true
Observe: 2 workspace icons for the same workspace, one with the name and one with id.

I've managed to workaround the issue, but it's far from ideal.
Removed defaultName from persistent workspaces config and using these settings for waybar:
  "hyprland/workspaces": {
    "format": "{icon}",
    "format-icons": {
      "1": "Web",
      "2": "Editor",
      "3": "Terminal",
      "4": "Debugging",
      "5": "Communication"
    }
  },

Okay i figured it out.
with this setup waybar also creates icons for workspaces "name:n"
where n is id of persistent workspace with default name
easiest workaround  is to simply switch to those workspaces with:
hyprctl dispatch workspace name:1
then once you leave the workspace, waybar receives destroyworkspace event and removes duplicate icon


Create PrivacyInfo.xcprivacy file

Describe the feature you want to improve

Update the empty file PrivacyInfo.xcprivacy file with the correct information, for this project (be sure to just update the file and not create a new one)
This project uses Firebase (Firestore, Auth, and in the future Storage)

This website will be helpful to generate the file, but you need to choose what goes into the file
https://www.privacymanifest.dev/

Hi Mikaela, Can you assign this issue to me? Thank you!

You got it!


Updating react-router and react-router-redux to newest?

I know the migration is pretty complicated so I wonder if this is planned at all for this boilerplate?

I would like but redux-connect is not yet ready for this (https://github.com/makeomatic/redux-connect/issues/107#issuecomment-286562322), first it is necessary that all the modules are compatible with react-router@4.


Added some important methods to  pull_request in Github and created Gitlab

this is for the issue #223

Hey @shivvamm, any update?

Yes I'm working on it just bit busy
On Thu, 8 Jun, 2023, 12:31 am Nikhil Raj, @.***> wrote:

Hey @shivvamm https://github.com/shivvamm, any update?
—
Reply to this email directly, view it on GitHub
https://github.com/Clueless-Community/scrape-up/pull/224#issuecomment-1581355886,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN3ZKDUKLFHI4TQ2LMEG7S3XKDFYDANCNFSM6AAAAAAYRWH3I4
.
You are receiving this because you were mentioned.Message ID:
@.***>

No issue @shivvamm, take your time.


Added codes for hackerrank pep coding problems with problem links and comments

… comments in cpp
Hey there!, Thanks for submitting a PR to this repo :smiley:
Please complete the following checklist for your PR to be approved. Mark the items by adding an x.
Example:  - [ ] Mark me as completed
To mark: - [x] Mark me as completed

[x] My Pull Request adheres to the Contribution guidelines.
[x] I have added problem.md and solution files in the appropriate folder.
[x] In problem.md I have provided a correct link to the problem.
(In case you are not adding a problem, you can freely mark this as complete)
[x] The solution I have given is my own and not plagiarized in any form.
[x] My solution passes all the testcases within the given constraints.
[x] I have properly indented and documented my solution using comments.
[x] I agree that all the above marked are true to the best of my knowledge and my PR can be closed if found otherwise.

If any of the above is unmarked, please make the necessary changes and then mark them so that you're PR can be approved and merged.
(Only completed checklist PRs will be reviewed)
Added codes in cpp for:
1.Trapping RainWater
2.EquilbriumPoint in array

The problem links don't seem to work.
Could you please recheck.

Please check the codes now.
Actually pep coding requires a candidate to log in or sign up first and then access the problems, so maybe the link could not be opened directly.


[Feature Request] Allow attach multible connection possibility to one Printer

Most Printer allow to connect them on multiple ways.
This is the list which appear If I open "Avahi Zeroconf Browser"

All these printers in the List are the same device

[ ] If you attach a new Printer, auto attach all connection possibility to this new Printer and try to set up a working connection on all of them.
[ ] May allow to manually to attach a connection to a Printer (e.g USB which is currently not connected while setup the printer)
[ ] concatenate all information and features of these connections into one printer.
[ ] on every printing CUPS use the best available path to connect a printer for a printing job.
[ ] If needed CUPS collect status Information from different connection and try to find non or wrong working connection.

This really wouldn't help improve printing. First, because each protocol has different capabilities and might need a different driver, and second because all of those protocols you see are not printing protocols.
There is already a mechanism for choosing the preferred (standard) printing protocol for a printer that is supported by CUPS and can be configured via most printer web consoles. The Google Cloud Print protocols are not supported (and GCP has been discontinue by Google anyways), and the scanner protocols likewise have their own mechanism for picking the preferred protocol.

@Mannshoch It doesn't work that way.
WRT protocols, while it is not uncommon for a printer to support multiple network protocols (IPP, IPPS, LPD, raw socket, etc.), what is uncommon is for those to represent different network connections or paths. Having a different URI depending on whether you are at work or home, or whether you are connected to a VPN, or any number of other possibilities is just not something that CUPS is designed for. The closest we've come is to support an alternate domain name for DNS-SD service instance names (for the dnssd backend/URI scheme) so that CUPS can resolve the correct hostname and IP address depending on which subnet you are on in an organization. There is some work being done in the Printer Working Group to investigate possible solutions for what we are calling "IPP Direct", where a printer can advertise its local and remote/cloud/whatever endpoints. This would allow for the kinds of things you want, but at this point we are just tossing ideas around and haven't even gotten to the white paper stage of a proposal. There are serious security and usability issues that need to be figured out before we'll have something that can be specified and implemented...
Different drivers can have vastly different capabilities. Some may be specific to your printer, others might be generic for the class of device or supported file formats. The fact that you have multiple instances of the same driver probably means that there is a problem with the packaging of the driver or an issue specific to your system - your Linux distributor may be able to help with that...


Schema for sets with cards

For /sets/mtgjson and /sets/cs, determine whether separate instantiations of SetsWtihCardsSchema are needed to eliminate duplicated fields.
IE /sets/mtgjson should not return mtgjson_code in the cards data.
/sets/cs should not return edition in the cards data.

Solved with SetsWithCardsSchema.


Create trust bundle based on Debian bookworm

We currently provide cert-manager-package-debian which contains the trust store from Debian bullseye. That trust store hasn't been updated for a while - since it hasn't needed to be - but it won't be updated to add new CA certificates or to prune CA certificates which have expired.
Since there's a new stable version of Debian - Debian bookworm - we could provide a new trust bundle which uses the ca-certificates package from that new version. That would be more "up to date" for users who want that.
We can create a new bundle for bookworm and update to use it by default in trust-manager. This would involve copying the "debian" bundle here into a new folder ("debian-bookworm") and then updating the new bundle to use bookworm rather than bullseye.
There's some GCB CI/CD for our trust bundles, which is manually configured in the cert-manager GCP org, but I can set that up. The GCB file here would need to be copied and the new version would need to be updated to bookworm.
ℹ This would be a great issue for an open source community member to tackle!

Hello,
I can pick it up, but I would like to know - is there any terms for this issue?

I can pick it up, but I would like to know - is there any terms for this issue?

Sorry, I didn't see this until now!
Could you explain what you mean by "terms" there?

I can pick it up, but I would like to know - is there any terms for this issue?

Sorry, I didn't see this until now!
Could you explain what you mean by "terms" there?

I meant "deadlines".

Ah, no deadlines! We can be flexible, no rush 😁

Could you please assign it to me?

/assign @arsenalzp

Hello,
I'm back and ready to work.
Could you be so kind to explain me why we need to copy old trust package stuff (in debian folder) instead just change base image directive to use the latest Debian docker package?

Could you be so kind to explain me why we need to copy old trust package stuff (in debian folder) instead just change base image directive to use the latest Debian docker package?

Sure, I'll try to explain my thinking!
Basically, the list of CAs trusted by each version of Debian will vary. Bookworm trusts new certs that bullseye doesn't.
I'd prefer for people to be able to make the choice of what they trust by themselves. It's OK for us to change the default in trust-manager (and there has to be a default), but I'd like to give people who already use the bullseye images to continue using those.
Plus if people are going to keep on using bullseye then we need a build pipeline for updating it in the future!
Does that make sense?

Yes, sure it is clear for me.
But the issue is that Debian trusted bundle sets up during the building/deployment process by using Init containers features.
Any suggestion/wishes how to allow end users to define bundle version?
P.S.
We should change help charts as well, there is 'hard-coded' version
# -- Tag for the default package image
  tag: "20210119.0"

Basically, the list of CAs trusted by each version of Debian will vary. Bookworm trusts new certs that bullseye doesn't.

@SgtCoDFish could you please explain why any user would prefer to trust an outdated trust bundle?

I guess it is for some reason such as the certificate chain of trust which is based on old CA. Some applications/certificates were not updated to use new CA, something like that.

I guess it is for some reason such as the certificate chain of trust which is based on old CA. Some applications/certificates were not updated to use new CA, something like that.

But the Debian trust roots are based on publicly trusted roots? And I don't think any root certs will be removed before they expire or are revoked. As a user, I would prefer to use an updated public trust bundle.

I guess it is for some reason such as the certificate chain of trust which is based on old CA. Some applications/certificates were not updated to use new CA, something like that.

But the Debian trust roots are based on publicly trusted roots? And I don't think any root certs will be removed before they expire or are revoked. As a user, I would prefer to use an updated public trust bundle.

You are right but some CAs might be revoked so it would lead to issue wit the new CA bundle. I guess that's why @SgtCoDFish arose this issue.
Of course we should indulge users to use outdated CA bundles, however we shouldn't break users applications as well.
Anyway, decision is fully up to you, colleagues! :-)

could you please explain why any user would prefer to trust an outdated trust bundle?

I think that they'd probably not use the term "outdated" - Debian bullseye will be supported for years still.
It's kinda as simple as: if you use the new version, you're potentially trusting more stuff. I just like that people can have the choice, you know?

Hello,
What is the final decision regarding this issue?

I am not sure if there is a "final decision". 😉 But I will try to summarize my view on this, taking the comments from @SgtCoDFish into account.
Should which defaultCAs trust bundle to use be configurable on the Bundle API level? That will require changes to the API as it is now just a boolean true/false. IMO this is a complexity we don't want/need.
IMO the defaultCAs trust bundle should be configurable when provisioning trust-manager. I also think the easiest solution is to just allow the user to choose image for the init-container to select between the bullseye and bookworm trust bundle. And that we should have CI providing updated tags for both images.

The best and sophisticated solution is to allow user to leverage trusted bundle image with help chart parameters.
However, @SgtCoDFish  has hist own point of view on this issue :-)

I absolutely agree people should be able to configure this in Helm parameters - which they can today, right?
https://github.com/cert-manager/trust-manager/blob/ad150e553b943a507949d183a3e71e869a2c5d83/deploy/charts/trust-manager/values.yaml#L33

I also think the easiest solution is to just allow the user to choose image for the init-container to select between the bullseye and bookworm trust bundle. And that we should have CI providing updated tags for both images.

This is the way! We can update the default to bookworm, but leave the bullseye image for older versions of trust-manager and for anyone who chooses that.

I realised it.
So the task is just create new docker image by using the latest debian base image, push it to the registry, label it as latest, change Helm chart to use the latest image. Am I right?
Sorry for so many questions, thanks all of you for your patience!

I don't think we should use latest tags, as they are not reproducible.

I don't think we should use latest tags, as they are not reproducible.

I agree, they don't reflect exact version of image, which is Debian release in our case.
In your code I see a number I guess it reflects some date. Can I use something like that to   define distinct Debian release for docker image with CA bundle?

In your code I see a number I guess it reflects some date

This is the version number of the package - Debian uses dates for ca-certificates.
$ docker run -it --rm docker.io/library/debian:bookworm-slim bash
$ root@91a2868ce75f:/# apt update && apt install ca-certificates
...
$ apt show ca-certificates
...
Version: 20230311
...

We also add a number on the end so that we can release new versions of the same package (e.g. if we rebuild the go binary).
So I guess for bookworm our first version should look like 20230311.0

/priority backlog

/remove-lifecycle stale
@arsenalzp Are you still interested in looking into this issue?

What was exact decision regarding this problem?

I don't think we took any final decision! Mostly there just isn't much demand for this - the current bundle isn't massively different to a more "modern" one. I'd still like to provide a more modern one (and move to that) but it's just not the biggest deal!
I'd probably rather have this be a different image, rather than just a new tag - just to avoid any risk of confusion. But I don't think this will get worked on any time soon so that doesn't really matter much!

FYI: Since Go 1.23, it has been changed so that an error occurs when trying to parse a certificate with a negative serial number.
https://github.com/golang/go/commit/db13584baedce4909915cb4631555f6dbd7b8c38
The ca-certificates of bullseye contains a CA certificate of CN=EC-ACC, which has a negative serial number.
$ while openssl x509 -noout -text 2>/dev/null; do :; done < bundle.pem| grep 'Serial Number' -A 3 | grep 'Negative' -A 2 -B 1
        Serial Number:
             (Negative)11:d4:c2:14:2b:de:21:eb:57:9d:53:fb:0c:22:3b:ff
        Signature Algorithm: sha1WithRSAEncryption
        Issuer: C=ES, O=Agencia Catalana de Certificacio (NIF Q-0801176-I), OU=Serveis Publics de Certificacio, OU=Vegeu https://www.catcert.net/verarrel (c)03, OU=Jerarquia Entitats de Certificacio Catalanes, CN=EC-ACC

This certificate seems to viloate RFC 5280.
https://datatracker.ietf.org/doc/html/rfc5280#section-<IP_ADDRESS>

The serial number MUST be a positive integer assigned by the CA to
each certificate.  It MUST be unique for each certificate issued by a
given CA (i.e., the issuer name and serial number identify a unique
certificate).  CAs MUST force the serialNumber to be a non-negative
integer.

（However, the RFC also notes the following）

Note: Non-conforming CAs may issue certificates with serial numbers
that are negative or zero.  Certificate users SHOULD be prepared to
gracefully handle such certificates.

This may cause an error when an application built with Go 1.23 or later tries to read the defaultCAs distributed by trust-manager. This actually occurred in my environment and crashed the application.
This can currently be avoided by setting the environment variable GODEBUG=x509negativeserial=1, but this may be removed in future versions.
https://pkg.go.dev/crypto/x509#ParseCertificate

Before Go 1.23, ParseCertificate accepted certificates with negative serial numbers. This behavior can be restored by including "x509negativeserial=1" in the GODEBUG environment variable.

EC-ACC seems to have been removed in bookworm (ca-certificates 20230311).
http://metadata.ftp-master.debian.org/changelogs/main/c/ca-certificates/unstable_changelog
https://packages.debian.org/bookworm/ca-certificates


update doc

Coverage remained the same at 100.0% when pulling 3c124cf6c9d4899739b34554bb3aacebc82c578b on develop into 693e23ee9b0539a08579909777ddb7f427d10b4d on master.

Coverage remained the same at 100.0% when pulling 8f30cba808c50d12d2a8915c5876af508156f954 on develop into 693e23ee9b0539a08579909777ddb7f427d10b4d on master.


Add midikraken

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jamesmunns (or someone else) soon.
Please see the contribution instructions for more information.

Ach, this still uses Travis for CI.

Wow looks awesome!
Make sure to add it to the newsletter as well :)

Thanks for your suggestion! How do I do this, the newsletter entries end at 2021-05-07-newsletter-29.md? Shall I create a new file with the current date, or with a date of now + N days (for which value of N?)

That latest entry is still marked draft, so a PR to edit that one is fine, we'll update the date when it gets published (hopefully in the next week or two...).

What is wrong with the CI? Did I make a mistake or is the CI just broken?

Should be fixed now!
bors retry

And, it's live http://showcase.rust-embedded.org/

Yayy, so cool! Thank you :)


Building a PoN with PureCN hard-requires GATK 3

Version info

bcbio version (bcbio_nextgen.py --version): 1.2.8
OS name and version (lsb_release -ds): Debian 10

To Reproduce
The code explicitly wants GATK 3:
https://github.com/bcbio/bcbio-nextgen/blob/5cfc02b5974d19908702fa21e6d2f7a50455b44c/bcbio/variation/vcfutils.py#L336
However there is no check for it, and if the command isn't found, the error condition is not triggered and the pipeline errors because it can't find the assembled PoN file.
Expected behavior
GATK 3 should not be required.

Hi @lbeltrame !
We install gatk3 by default via conda:
https://github.com/chapmanb/cloudbiolinux/blob/master/contrib/flavor/ngs_pipeline_minimal/packages-conda.yaml#L281
and it is present usually in bcbio/tools/bin/gatk3. It does not need to be manually downloaded and registered as before.
So we may safely assume gatk3 is onboard. We tried combining variants with gatk4 - it was more complicated at the time, so we chose gatk3.
Sergey


README Docs Links Broken on Windows

Which version of kubefirst are you using?
v2.2.17
Which cloud provider?
AWS, Google Cloud, k3d (local)
Which DNS?
None specific
Which installation type?
None specific
Which distributed Git provider?
GitHub
What is the issue?
Using the link the in the README to navigate to the docs page broken using my windows device but work well on mac.
See the error screenshot below.

Code of Conduct

[X] I agree to follow this project's Code of Conduct

I cannot replicate this issue on Windows with Microsoft Edge. In any cases, you're right, this shouldn't point to the index.html file anyway.


add support for custom extensions in helpers functions

I'd like to use the pyasdf testing infrastructure with custom extensions, specifically to test roundtripping.
I've looked into adding  the extensions keyword to the assert_roundtrip_tree function (calls to AsdfFile() and AsdfFile.open) but this doesn't seem to be sufficient as the type_index is not updated with the custom types.
Would it be easy to add this functionality?

Definitely a good thing to add.  I would have expected passing the extensions to AsdfFile and AsdfFile.open to be sufficient though.  Let me look into why it's not working...

I set up #164 -- more or less like you suggested -- and wrote a test that appears to work.  Does that work for you?  If not, let me know what you're doing -- the extension stuff is newish so I wouldn't be surprised if there's a sharp corner.

Oh, and by the way -- just to confirm we aren't duplicating effort:  I'm working on wrapping gwcs.WCS and gwcs.CoordinateFrame etc.  Are you doing this for something else?

No, I am not wrapping those. I am writing the types for the selector models.
The way I set it up for now is the schemas are still in asdf-standard and the types are in gwcs.
I'll post a PR shortly and tests this PR.
I also have several models which will live in assign_wcs and so will need to have their types and schemas there as well.
So I'm wondering if the types for gwcs.WCS and gwcs.CoordinateFrame should also be in gwcs. In which case pyasdf will not have a dependence on gwcs.

That's a good question.  I think we want the schemas in asdf-standard -- WCS is one of the main drivers for ASDF, so it would be selling ASDF short to not have them defined there.  As to where to put the reader/writer code I'm having trouble coming up with a really strong argument either way.  As of this yesterday, pyasdf can use libraries as a "soft dependency" -- i.e. it doesn't have to depend on gwcs unless someone loads a file with wcs info in it.  But I guess I fall down on them living in gwcs -- with gwcs being still under development, it might be easier to have all of the ASDF interface code there as well as they may need to be updated together.

Agreed that schemas should be in asdf-standard. I have no strong opinion about the readers/writers, especially now that gwcs is not a hard dependence. And gwcs will probably end up in astropy. So let's keep things as they are until we have a solid reason to change them. I still have to complete the process and see how the WCS object is to be written to a file (asdf or fits).

Closed by #164


NPM publish trigger on published draft releases.

Expected this trigger to run on a draft release that has been published
on:
  release:
    types: [created]

DId not occur.

Confirm I had to manually trigger NPM publish action as well.


Fix @ mentions. Remove name from tiptap Mention.extend LAND-1448

Reported issue:
@ mentions look normal in the chat input but don't make it into the message content after send.
~ mentions work fine.
Steps to reproduce:

Go to any chat channel.
Make an @ mention in the chat input (with some other text, as a user normally would)
Send the message
Notice that the mention isn't there in the message in the chat scroller.

Fix:
The name was added apparently to remove a warning. "Duplicate extension names found: ['mention']. This can lead to issues."
But the extend method's documentation says the name can't be changed
https://tiptap.dev/docs/editor/guide/custom-extensions#extend-existing-extensions
If we add a name: property, the @ mentions stop working
Needs more research but opting to make it work over a warning for now
See: https://github.com/ueberdosis/tiptap/discussions/1768#discussioncomment-7952132
Fixes LAND-1448

I have a proposed fix at #3160 that shoud give us the expected behavior without the warning


OverrideMaterialManager doesn't respect the original material's clippingPlanes

Description of the bug
Render passes ignore clipping planes, which results in visual artifacts for effects like SSAO
To Reproduce
Sandbox example: https://codesandbox.io/s/jolly-keller-f9ji3p
Expected behavior
I'd expect clipping planes from original materials to be copied to overriding materials (which probably means, a new one should be created for all the relevant objects; I realize this is quite bad for performance, but not sure if there is another approach that would work in general...)
Screenshots

Duplicate of #319.
Please check if there are similar issues before opening new ones.


Pushes on my idle screen should be removed when I read the messages on another screen

This is an issue of the pusher server.


fix(sbb-header-action): fix styling after orientation change on iOS

Codecov Report

Merging #1664 (8f39277) into master (ab917b0) will decrease coverage by 3.47%.
The diff coverage is 51.69%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff             @@
##           master    #1664      +/-   ##
==========================================
- Coverage   54.85%   51.38%   -3.47%
==========================================
  Files          49      133      +84
  Lines        1659     4713    +3054
  Branches      406     1231     +825
==========================================
+ Hits          910     2422    +1512
- Misses        671     2118    +1447
- Partials       78      173      +95

Impacted Files
Coverage Δ

...ts/sbb-accordion-item/sbb-accordion-item.events.ts
100.00% <ø> (ø)

...mponents/sbb-accordion-item/sbb-accordion-item.tsx
0.00% <0.00%> (-37.21%)
:arrow_down:

...onents/sbb-autocomplete/sbb-autocomplete.events.ts
100.00% <ø> (ø)

src/components/sbb-checkbox/sbb-checkbox.events.ts
0.00% <ø> (ø)

src/components/sbb-icon/sbb-icon-validate.ts
45.16% <ø> (ø)

src/components/sbb-icon/sbb-icon.tsx
92.30% <ø> (ø)

src/components/sbb-image/sbb-image.helper.tsx
0.00% <ø> (-64.52%)
:arrow_down:

src/components/sbb-image/sbb-image.tsx
0.00% <ø> (-62.97%)
:arrow_down:

...mponents/sbb-journey-header/sbb-journey-header.tsx
88.23% <ø> (+1.27%)
:arrow_up:

...onents/sbb-journey-summary/sbb-journey-summary.tsx
80.55% <ø> (ø)

... and 142 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


nag.select().save() RuntimeError

Hi,
I use Nag.select() and I try to save it. I get this :

RuntimeError: min(): Expected reduction dim to be specified for input.numel() == 0. Specify the reduction dim with the 'dim' argument.

Code :

hierarchy = nag.select(3, 0)
hierarchy.save( path_to_save_file + '.h5')

Value of hierarchy :

NAG(num_levels=4, num_points=[2690, 131, 49, 1], device=cuda:0)

Terminal output :

Any ideas ?

solution : hierarchy[0:3].save

solution : hierarchy[0:number_of_level]

Hi @hpc100 have you solved this issue ?
Maybe a tensor shape error arises because you are indexing only a single element from the $P_3$ level. Can you try, for the sake of debugging:
nag.select(3, [0, 1, 2]).save( path_to_save_file + '.h5')

and
nag.select(3, [0]).save( path_to_save_file + '.h5')

You need to further investigate which partition level and which data attributes cause errors. Suggestions:
add here
print(f'partition {i_level}')

and add here
print(f'key {k}: {val.shape}')

Thank's for your response. Print results :
partition 0
key edge_index: torch.Size([2, 35555])
key super_index: torch.Size([6533])
key x: torch.Size([6533, 5])
key edge_attr: torch.Size([35555])
key elevation: torch.Size([6533, 1])
key label: torch.Size([6533])
key linearity: torch.Size([6533, 1])
key node_size: torch.Size([6533])
key planarity: torch.Size([6533, 1])
key scattering: torch.Size([6533, 1])
key verticality: torch.Size([6533, 1])
partition 1
key edge_index: torch.Size([2, 3022])
key super_index: torch.Size([313])
key x: torch.Size([313, 5])
key edge_attr: torch.Size([3022, 7])
key log_length: torch.Size([313, 1])
key log_size: torch.Size([313, 1])
key log_surface: torch.Size([313, 1])
key log_volume: torch.Size([313, 1])
key node_size: torch.Size([313])
key normal: torch.Size([313, 3])
partition 2
key edge_index: torch.Size([2, 790])
key super_index: torch.Size([113])
key x: torch.Size([113, 5])
key edge_attr: torch.Size([790, 7])
key log_length: torch.Size([113, 1])
key log_size: torch.Size([113, 1])
key log_surface: torch.Size([113, 1])
key log_volume: torch.Size([113, 1])
key node_size: torch.Size([113])
key normal: torch.Size([113, 3])
partition 3
key edge_index: torch.Size([2, 0])
it just seems like there aren't enough points. nag.select(3, [0,1,2,3]).save('try.h5') works !
Thank's

The error comes from the fact that your indexing operation only keeps a single element of $P_3$. As a result, the corresponding superpoint graph is empty (i.e. nag[3].edge_index is of shape (2, 0)).
I just pushed a commit addressing this issue. Can you please update your code and try again ?

I updated the code. And I managed to save and reload the nag without problems. Thank's

Awesome ! I will close this issue then, thanks for the feedback


Include the name of the unfound tool in the error.

We have started to see errors in one of our third party tools that is raising this specific error (error: error: invalid tool type in 'tools' map). However, there is no information to go on regarding what tool was unfound and since the issue is not consistent we are having a tough time tracking down what the issue might be. This change simply includes the tool name that could not be found which will hopefully help us narrow down the issue.

@swift-ci please smoke test

Did the Windows really fail because it has no space?
C:\Users\swift-ci\jenkins\workspace\swift-llbuild-PR-windows\llvm-project\clang\include\clang/AST/DeclarationName.h(879): fatal error C1088: Cannot flush compiler intermediate file: 'T:\tmp\_CL_48f0fbeaex': No space left on device

https://ci-external.swift.org/job/swift-llbuild-PR-windows/103/console

It's probably just a transient failure
@swift-ci please test Windows platform


Update error message to better explain ->

Closes #4647
This PR improves the error message for unexpected -> in certain contexts by showing both correct areas to use it.

I added the function type signature to the error message as well since it also uses ->. Missed that initially.
Sidenote, the increment function is used a lot to show errors. In most cases it is defined as \n -> n + 1 but in one place it is \x -> x + 1. I think thats most definitely not in the scope of this PR to change but worth pointing out.


Typo on web page for Power BI REST APIs

🛑 IMPORTANT: You can get your feedback addressed faster if you use the comment section for the article in which you encountered a problem.
There is no comment section on the page where this defect exists.
Link to article:
https://docs.microsoft.com/en-us/rest/api/power-bi/
Problem:
This word is misspelled:

administation

It should be

administration

@hugotoledo Thanks for your feedback. I submitted a PR to correct. It should be merged very soon.

@hellosnow Do you have permission to merge the PR? https://github.com/MicrosoftDocs/powerbi-rest-api-docs-pr/pull/13 .

@Powerhelmsman I merged the PR, and this issue could be closed.


Update ZH_CN.md

translate some new content, and change document link.

We should try to internationalize the guide/reference in this repo rather than linking out to another website, but it's fine for now.

We should try to internationalize the guide/reference in this repo rather than linking out to another website, but it's fine for now.

you mean add i18n for the doc site ?


Import csv with multiple tables

Hi, I want to write to DataframeClient
I have a .csv file with many tables which have the same structure for example:
market, branch a
day1, day2, value
1/1/2018,1/2/2018,1
1/3/2018,1/4/2018,5
[...] #more rows with the same structure as above.
market, branch b
day1, day2, value
1/1/2018,1/2/2018,2
1/3/2018,1/4/2018,5
[...] #more rows with the same structure as above.
I have used pd.read_csv() to read the file then also have separated those tables into subtables in pandas for parsing to influxdb. Here is one table in the csv file that I've got so far:
market: branch a
0                        1                       2
1     day1                  day2                value
2     1/1/2018           1/2/2018          1
3     1/3/2018           1/4/2018          5
My question is : do we have a way to read such .csv with multiple tables by DataframeClient? Since I read those subtables like the one I have above, I got error:

TypeError: Must be DataFrame with DatetimeIndex or PeriodIndex.

Once you read a csv into a dataframe, you can simply write that dataframe via DataFrameClient. I don't believe we want to support reading from csv natively from within the client.


add firefox and edge to selenium

this is awesome! would be great if your selenium helper could also support firefox and edge

I don't know how to do it myself. If you have an example, I can add it to the kora library. Closing for now.


Rerun per-sequencing-run QC summary on cumulative non-helix datasets to populate non-helix cumulative folders

Note: must be exact mirror process/structure to #32

Replaced by #65


Start writing some frontend tests

Probably using https://nextjs.org/docs/testing#jest-and-react-testing-library

I don't know if it's in the interest of the project, but it would be cool to add a lib like cypress to test the entire user flow, https://nextjs.org/docs/pages/building-your-application/optimizing/testing#jest-and-react-testing-library

@razzeee  What are the main components of the frontend that should be tested more?

Btw, I would probably look at playwright and not cypress, but it's been a while.
I'm actually not too sure, I can't think of anything specific, that keeps breaking, but tests usually help you anyway. I would guess, that the logged in part would have the most value, but it's probably also the hardest to do.

So the login tests managed to be in the ProviderLink component that redirects to the provider's login route, right?

The playwright seems to be cool after you can make a pr to add him

@razzeee maded one pr with some tests to login, i try remove duplicate code and organize tests but i not have much experience with jest if you can review