polarity dimension problem

@yangheng95 Hi, Yangheng! Your package really helps and now i could generate aspect as well as their sentiment using my own data(i would be more than glad to share my data after finishing my project)!
Just one curiosity regarding this repository:
currently i could only generate sentiment in 3-scale dimension: positive, neutral, negative. But I actually need to generate 5-scale dimentions: 1-very negative      2-negative     3-neutral     4-positive      5-very positive
It is possible for me to do that?
Thanks in advance for your kind reply^^

The package allows you to use more than three labels, please find the description in the Tips. You can just label your sentence using very negative, negative, neutral,  positive, very positive. You dont need to assign the number for labels, PyABSA will do it for you

That is, what labels you use in your dataset, what labels will be output in inference. The index assignment of labels is handled automaticly.

That is, what labels you use in your dataset, what labels will be output in inference. The index assignment of labels is handled automaticly.

Got it! Thanks a lot for your detailed explanation. One more question: I am now using the new function DPT (develped by @lpfy ) to label my sentences, and it has only 3 dimensions. If i want to change my sentiment to 5-sacle,  I won't  be able to use DPT and have to manualy label my sentences, right?

That is, what labels you use in your dataset, what labels will be output in inference. The index assignment of labels is handled automaticly.

Got it! Thanks a lot for your detailed explanation. One more question: I am now using the new function DPT (develped by @lpfy ) to label my sentences, and it has only 3 dimensions. If i want to change my sentiment to 5-sacle, I won't be able to use DPT and have to manualy label my sentences, right?

I can add options to DPT in next version. the only concern is from language point of view, probably negative and very negative are not so different. Probably I will add 5-scale as Positive, Somewhat Positive, Neutral,  Somewhat Negative, Negative.

That is, what labels you use in your dataset, what labels will be output in inference. The index assignment of labels is handled automaticly.

Got it! Thanks a lot for your detailed explanation. One more question: I am now using the new function DPT (develped by @lpfy ) to label my sentences, and it has only 3 dimensions. If i want to change my sentiment to 5-sacle, I won't be able to use DPT and have to manualy label my sentences, right?

I can add options to DPT in next version. the only concern is from language point of view, probably negative and very negative are not so different. Probably I will add 5-scale as Positive, Somewhat Positive, Neutral, Somewhat Negative, Negative.

I will be very thankful if you could kindly add 5-scale! The problem for me is that, I'm working on a restaurant review project.
When people give comments, they tend to use "satisfying" "extremely good" "just okay" "taste bad" "awful, hell" to express their feelings. So in personal my project may need at least 5-scale.
Also, thanks so much for your excellent work! I benefit from your DPT a lot!

That is, what labels you use in your dataset, what labels will be output in inference. The index assignment of labels is handled automaticly.

Got it! Thanks a lot for your detailed explanation. One more question: I am now using the new function DPT (develped by @lpfy ) to label my sentences, and it has only 3 dimensions. If i want to change my sentiment to 5-sacle, I won't be able to use DPT and have to manualy label my sentences, right?

I can add options to DPT in next version. the only concern is from language point of view, probably negative and very negative are not so different. Probably I will add 5-scale as Positive, Somewhat Positive, Neutral, Somewhat Negative, Negative.

I will be very thankful if you could kindly add 5-scale! The problem for me is that, I'm working on a restaurant review project. When people give comments, they tend to use "satisfying" "extremely good" "just okay" "taste bad" "awful, hell" to express their feelings. So in personal my project may need at least 5-scale.
Also, thanks so much for your excellent work! I benefit from your DPT a lot!

No worries, I now understand the requirement, so I will make the scale more flexible, will add multi-choice at beginning step to allow user defining scales, 3, 5, 7. hopefully can be finished over weekend

That is, what labels you use in your dataset, what labels will be output in inference. The index assignment of labels is handled automaticly.

Got it! Thanks a lot for your detailed explanation. One more question: I am now using the new function DPT (develped by @lpfy ) to label my sentences, and it has only 3 dimensions. If i want to change my sentiment to 5-sacle, I won't be able to use DPT and have to manualy label my sentences, right?

I can add options to DPT in next version. the only concern is from language point of view, probably negative and very negative are not so different. Probably I will add 5-scale as Positive, Somewhat Positive, Neutral, Somewhat Negative, Negative.

I will be very thankful if you could kindly add 5-scale! The problem for me is that, I'm working on a restaurant review project. When people give comments, they tend to use "satisfying" "extremely good" "just okay" "taste bad" "awful, hell" to express their feelings. So in personal my project may need at least 5-scale.
Also, thanks so much for your excellent work! I benefit from your DPT a lot!

No worries, I now understand the requirement, so I will make the scale more flexible, will add multi-choice at beginning step to allow user defining scales, 3, 5, 7. hopefully can be finished over weekend

Just wonder Is it possible to add label customizing feature before  using DPT?

That is, what labels you use in your dataset, what labels will be output in inference. The index assignment of labels is handled automaticly.

Got it! Thanks a lot for your detailed explanation. One more question: I am now using the new function DPT (develped by @lpfy ) to label my sentences, and it has only 3 dimensions. If i want to change my sentiment to 5-sacle, I won't be able to use DPT and have to manualy label my sentences, right?

I can add options to DPT in next version. the only concern is from language point of view, probably negative and very negative are not so different. Probably I will add 5-scale as Positive, Somewhat Positive, Neutral, Somewhat Negative, Negative.

I will be very thankful if you could kindly add 5-scale! The problem for me is that, I'm working on a restaurant review project. When people give comments, they tend to use "satisfying" "extremely good" "just okay" "taste bad" "awful, hell" to express their feelings. So in personal my project may need at least 5-scale.
Also, thanks so much for your excellent work! I benefit from your DPT a lot!

No worries, I now understand the requirement, so I will make the scale more flexible, will add multi-choice at beginning step to allow user defining scales, 3, 5, 7. hopefully can be finished over weekend

Just wonder Is it possible to add label customizing feature before using DPT?

Yep, it is doable. I can add a wizard form for setting up labels before load data. Asking people whether using pre-defined labels or customized labels. need more time to code, but my plan is add pre-defined 3,5,7 labels first, then enable "customized labels" functionality next

That is a huge job, thanks very much


OpenCL matrix multiplication optimizations

Summary
Optimized matrix multiplication, especially for the case where one matrix dimension is small.
Mostly I changed code patterns like:
for(...){
  if(foo)
    bar()
  else
    baz()
}

into
if(foo)
  for(...)
    bar()
else
  for(...)
    baz()

I also changed splitting criterion. The problem is now split depending on the number of work groups launched and comput units on the device, so as to have at least a few work groups per compute unit.
Tests
No changes to tests. OpenCL multiplication is already well tested.
Side Effects
Nothing major. Kernel code for multiplication is significantly longer (by ~100 lines of code). This is close to copy-paste of existing code. I don't have any idea how to deduplicate it without writing most of it in macros, which would be harder to read.
Checklist

[x] Math issue #1292

[x] Copyright holder: Tadej Ciglarič, University of Ljubljana
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[x] the basic tests are passing

unit tests pass (to run, use: ./runTests.py test/unit)
header checks pass, (make test-headers)
docs build, (make doxygen)
code passes the built in C++ standards checks (make cpplint)

[x] the code is written in idiomatic C++ and changes are documented in the doxygen

[x] the new changes are tested

Here are comparisons of speed of new and existing code for multiplication a matrix of size NxM with one of size MxK:

M
N
K
shapes
speedup

1
15000
15000
ENTIRE * ENTIRE
0.59*

15000
1
15000
ENTIRE * ENTIRE
1.63

15000
15000
1
ENTIRE * ENTIRE
0.88*

15000
15000
1
LOWER * ENTIRE
0.98*

2
15000
15000
ENTIRE * ENTIRE
4.16

15000
2
15000
ENTIRE * ENTIRE
1.60

15000
15000
2
ENTIRE * ENTIRE
4.97

15000
15000
2
LOWER * ENTIRE
4.17

32
15000
15000
ENTIRE * ENTIRE
1.05

15000
32
15000
ENTIRE * ENTIRE
1.00

15000
15000
32
ENTIRE * ENTIRE
1.05

32
15000
15000
LOWER * ENTIRE
5.01

15000
32
15000
LOWER * ENTIRE
0.90

15000
15000
32
LOWER * ENTIRE
1.09

2000
2000
2000
ENTIRE * ENTIRE
1.03

32
32
15000
LOWER * ENTIRE
0.89

These are comparisons of the new general kernel with specialized kernels for cases row vector x matrix and matrix x vector. Since specialized kernels are faster than new general kernel I am not removing them.

In summary: new kernel is up to 5 times faster than existing one and at worst 10% slower.

@SteveBronder I already went through these changes a week ago and I think they are great, but would still like another set of eyes here. So please review these when you have the chance.
I think this almost-duplicating is better than any sort of weird trickery that would be harder to read.  I am thinking we should add a paragraph on them here. I can do that if you agree that its necessary.

That mat mul code is starting to look a little smelly, could we break up the methods inside to call functions for the particular methods?

I looked into into breaking it up with functions. However a function here would have a large number of parameters. That also does not look very good.

I'll take a read over these

I'll mess around with this today. Looking at the code I think there are a few places we could write functions to make the code readable. OpenCL inlines the functions anyway so their shouldn't be any performance loss from breaking multiply up into smaller functions

Weird that test/unit/math/prim/mat/fun/get_base1_lhs_test.cpp is failing

That is really wierd. All tests already passed on the same code. It seems they were restarted as I checked all checkboxes in the checklist.

Yes, changes to the top comment trigger another set of tests. Not sure if that is by design though.

@SteveBronder did you find any way to make the code prettier for this PR?

Give me till Sunday if I still haven't then I'll be fine without prettying it up

@SteveBronder Any progress here?

Nah sorry I'll cash out my opinion here. I don't like how it looks but skin in the game and all that

@SteveBronder can you give a bit more info on what you dont like. Just that its basically duplicating a lot of code? I know you are pretty busy, I just dont want this to look like we want to push suff through that should not go through.
Are fine we the general idea of the PR, recognize that its faster but feel that the duplication in the kernel is a bit much?

It's mostly the deepness of the if statements, but we also need those for doing the optimizations. I think my actual wuff with this is that we are in C98 world which we can't really do much about

I'm fine with the idea of the PR

Ok, thank you for the clarification. Yeah, living in the C98 world is a pain :/ I will go through it again, since its been some time since I last looked at this, to see if I have any more comments. I feel that we cant avoid the branching and have optimizations at the same, that is just the way it goes in OpenCL kernels. But will take a look at the other aspects. Is that cool beans with you?

Works for me!

@SteveBronder Not sure where to post this, but since we were talking about C98 being a pain for kernels, this might interest you: https://www.youtube.com/watch?v=8pJS3n4MITM
Its a talk on SYCL, not sure if you are familiar with it. Its a single source GPU programming solution kind of like our Stan Math system here, if you ignore the fact that the kernel is actually a string, which honestly you can with the way we set it up. They do support writing kernels as lambdas in C++. Thought the downside of their approach is that its not as performant as straight up OpenCL and you need specific compiler to compile it. We are getting close to writing kernels in C++ with Tadej's generator though :)


[Fix #10136] Update Lint/AssignmentInCondition to not consider assignments within blocks in conditions

Assignments within a block are not relevant to this cop because they don't affect the same scope.
Fixes #10136.

Before submitting the PR make sure the following are checked:

[x] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
[x] Wrote good commit messages.
[x] Commit message starts with [Fix #issue-number] (if the related issue exists).
[x] Feature branch is up-to-date with master (if not - rebase it).
[x] Squashed related commits together.
[x] Added tests.
[x] Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
[x] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Thanks!


Blanket Implementation of Parse for TryFrom<DeriveInput, Error = syn::Error>

It might be nice to be able to do something like this:
#[proc_macro_derive(SomeThing)
pub fn derive_something(input: TokenStream) -> TokenStream {
    parse_macro_input!(input as Something)
        .into_token_stream()
        .into()
}

struct Something {
    // ...
}

impl TryFrom<DeriveInput> for Something {
    type Error = syn::Error;

    fn try_from(input: DeriveInput) -> Result<Self, Self::Error> {
        todo!()
    }
}

The downside is that this might be considered a breaking change; users may already have implemented it like this for their specific types and a blanket implementation would conflict with it.

I would prefer not to make this change.
Replacing this:
impl Parse for Thing {
    fn parse(input: ParseStream) -> Result<Self> {
        let input: DeriveInput = input.parse()?;
        ...
    }
}

with this:
impl TryFrom<DeriveInput> for Something {
    type Error = syn::Error;

    fn try_from(input: DeriveInput) -> Result<Self, Self::Error> {
        ...
    }
}

is not a convincing improvement.


cannot redirect to page

Hi,
I tried to run your code by use command
scrapy crawl fb -a email="facebook_email" -a password="facebook_password" -a page="KompasCOM" -o DUMPFILE.csv
i also tried changing the page parameter to
-a page="/KompasCOM"
but it give an error
INFO: Parse function called on https://mbasic.facebook.com/KompasCOM
ERROR: Spider error processing <GET https://mbasic.facebook.com/KompasCOM> (referer: https://mbasic.facebook.com/home.php?_rdr)
Traceback (most recent call last):
File "C:\ProgramData\Anaconda3\lib\site-packages\scrapy\utils\defer.py", line 102, in iter_errback
yield next(it)
File "C:\ProgramData\Anaconda3\lib\site-packages\scrapy\spidermiddlewares\offsite.py", line 30, in process_spider_output
for x in result:
File "C:\ProgramData\Anaconda3\lib\site-packages\scrapy\spidermiddlewares\referer.py", line 339, in
return (_set_referer(r) for r in result or ())
File "C:\ProgramData\Anaconda3\lib\site-packages\scrapy\spidermiddlewares\urllength.py", line 37, in
return (r for r in result or () if _filter(r))
File "C:\ProgramData\Anaconda3\lib\site-packages\scrapy\spidermiddlewares\depth.py", line 58, in
return (r for r in result or () if _filter(r))
File "D:\KERJA\Neviim\fbcrawl-master\fbcrawl\spiders\fbcrawl.py", line 87, in parse_page
temp_post = response.urljoin(post[0])
IndexError: list index out of range
How do i solve this??
EDIT
I tried the work around you mentions by log in via web browser, but it still give me the same error. Also i got no email about unknown device login like you mentions before.
is there any work around i can try?
Thanks

I think it regards to #1 #2 issues

@aldwinharjanto OK I found some time to debug. The crawler is not working because your fb interface language is not set to "italian", so it cannot find the correct xpath (the selector that breaks is post.xpath(".//a[contains(text(),'Notizia completa')]/@href at line 86)
It's written in the README that is the only language supported at the moment, I suggest to change language since even if you fix this precise selector to fit your language, it will still break on other selector. If you want to port the code to your language I encourage you too, at the moment I don't have much time available for this.

@rugantio thanks man, i'll try to adjust your code. thanks for the help


fixed action issue in course review

Fixed the issue with the action button malfunctioning in the course proposal page
Issue Ticket Number: 1244
Issue

[ ] The reviewProposal.html could not access the variables and functions in the JS file because the JS was a module
[ ] Functions and variables were locally scoped to the module
[ ] The JavaScript file included a few lines of code that manually set some functions to the window object to make them globally accessible

Changes

[ ] I defined an allExports object to localize all the functions for easier addition/removal
[ ] A for loop is used to attach all functions on the window object

We fixed the issue in the course review proposal, which needed to be fixed on approved/unapproved.

We moved this issue to a new pull request


What will happen go DCC w/o a valid signature in version 2.7?

Your Question
It seems like version 2.7 will prevent users from adding certificates without a  valid signature to the app.
If a user has already imported certificates w/o a valid signature, will they be removed or will they just stay in the app?

The certificate will shown as invalid without QR-Code like expired certificates.

@thomasaugsten
Thanks for the quick answer.
Closing as answered.


mingw: mcfgthreads is broken

Describe the bug
x86_64-pc-mingw32-gcc: error: unrecognized command line option '-municode'
make: *** [Makefile:1485: .pch.h.gch] Error 1
builder for '/nix/store/2kvqfp9dcvlmm2fnvwr813mp02adsz9d-mcfgthreads-git-x86_64-pc-mingw32.drv' failed with exit code 2

To Reproduce
$ nix-shell -p '(import <nixpkgs> { crossSystem = { config = "x86_64-pc-mingw"; libc = "msvcrt"; }; }).hello'

Reproduced on both 19.09 and master as of writing.
Metadata

system: "x86_64-linux"
host os: Linux 4.19.114, NixOS, 19.09.2370.e10c65cdb35 (Loris)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.3
channels(root): "nixos-19.09.2370.e10c65cdb35"
channels(user): ""
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Changing to x86_64-w64-mingw32 works:
nix-shell -p '(import <nixpkgs> { crossSystem = { config = "x86_64-w64-mingw32"; libc = "msvcrt"; }; }).hello'

nixpkgs now correctly errors on x86_64-pc-mingw, so closing this.


update for Struts 2.5.13, Github #1124

This is necessary for critical security patching of CVE-2017-9805.

Obsolete.


Is it possible to display that the records represent contigs and not scaffolds in the output figures?

Hello there!
Is it possible to change output figures to show "Contig" instead of "Scaffold" when the assembly being viewed is a contig assembly? I was able to change it the source code of assembly-stats, and I thought I did on a previous version of blobtools but now I forgot. Alternatively, if you could show me in the source where I could change it, that would be fantastic.
Happy new year!
Best wishes,
Sheina

Nevermind, I devised a workaround.
Thanks!


Configure Azure Pipelines

This configuration builds the application and produces builds for both Debug and Release configurations.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: paddy3267 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Version in OHIF Viewer website? https://viewer.ohif.org/

Just curious. What version (or github branch) are you guys using for the "actual" website demo ("viewer.ohif.org").
I found that some UI and some structures are different from the latest version. In addition, are you guys planning on updating the exported website?

Try viewer-dev.ohif.org instead of viewer.ohif.org
Our viewer.ohif.org is deployed from release branch while viewer-dev.ohif.org is our master  branch
Read more about branch explanations here https://docs.ohif.org/development/getting-started#developing


Build fails

Even with my pull request modification to fix the spacing on the Dockerfile:35, the file does not exists and build fails.

@paul42 I'm not entirely sure how your system is setup, but it looks like running the following will get you building.
docker@boot2docker:~/docker-graphite-statsd sudo docker build -t hopsoft/graphite-statsd ~/docker-graphite-statsd

Note: You don't need to build the image yourself unless you plan on changing the image; otherwise, you can simply start the container.
sudo docker run -d \
  --name graphite \
  -p 80:80 \
  -p 2003:2003 \
  -p 8125:8125/udp \
  hopsoft/graphite-statsd


Implement Grape::Entity::Options#dig with freezing rubocop version #277 + #278

For https://github.com/ruby-grape/grape-entity/pull/278#issuecomment-340939720
#277 + #278

Coverage increased (+0.02%) to 92.74% when pulling 125dea4c090157f796102bff480b36095a5cac81 on kachick:options-dig.with_rubocop_patch into 6a384cd573580ccb7fbf79af5886a037b2358e0b on ruby-grape:master.

Coverage increased (+0.02%) to 92.74% when pulling 125dea4c090157f796102bff480b36095a5cac81 on kachick:options-dig.with_rubocop_patch into 6a384cd573580ccb7fbf79af5886a037b2358e0b on ruby-grape:master.

Coverage increased (+0.02%) to 92.74% when pulling 125dea4c090157f796102bff480b36095a5cac81 on kachick:options-dig.with_rubocop_patch into 6a384cd573580ccb7fbf79af5886a037b2358e0b on ruby-grape:master.

Coverage increased (+0.02%) to 92.74% when pulling 125dea4c090157f796102bff480b36095a5cac81 on kachick:options-dig.with_rubocop_patch into 6a384cd573580ccb7fbf79af5886a037b2358e0b on ruby-grape:master.


[BUG] - When click select all in table, it returns 'ALL' instead of keys

NextUI Version
2.0.28
Describe the bug
Im using the table component, and when i select one row at a time, i get the actual row key, but if i select all using the checkbox at the top, then ill get all, this is bad, because, if im using pagination, and there are 2 items, then it will select all items in the state, i know i can separate the state to have 1 for all my keys, and other per pagination, but this is double work, is there a way to always return keys on select all?
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
Select all in a table
returns "all"
Expected behavior
return array of keys
Screenshots or Videos
No response
Operating System Version
windows
Browser
Chrome

+1, having a issue when i need to send the table data to a external api and all i can send is that 'all' string, only works if i select all of them one by one, also can't remove the select all box, making user error very likely.

I had that issue and a dumb workaround when I was creating a file browser, I used NextUI's Table as a list view for files and I wanted all views to use the same state variable so I did this:
useEffect(() => {
    if(selectedRows === 'all') {
        let allRows;
        allFiles.forEach(file => allRows.push(file.fileID,toString()));
        setSelectedRows(new Set(allRows));
    }
}, [selectedRows])

NOTE: I did add a toString() since NextUI's selectedKeys only reads from strings.
I know this isn't a solution but maybe you could implement this until there's a fix.

I had that issue and a dumb workaround when I was creating a file browser, I used NextUI's Table as a list view for files and I wanted all views to use the same state variable so I did this:
useEffect(() => {
    if(selectedRows === 'all') {
        let allRows;
        allFiles.forEach(file => allRows.push(file.fileID,toString()));
        setSelectedRows(new Set(allRows));
    }
}, [selectedRows])

NOTE: I did add a toString() since NextUI's selectedKeys only reads from strings. I know this isn't a solution but maybe you could implement this until there's a fix.

yeah this is the normal aproach, the problem is when you have pagination or async loading, in this case you need more logic

Is there any progress or update related to this?

I had that issue and a dumb workaround when I was creating a file browser, I used NextUI's Table as a list view for files and I wanted all views to use the same state variable so I did this:
useEffect(() => {
    if(selectedRows === 'all') {
        let allRows;
        allFiles.forEach(file => allRows.push(file.fileID,toString()));
        setSelectedRows(new Set(allRows));
    }
}, [selectedRows])

NOTE: I did add a toString() since NextUI's selectedKeys only reads from strings. I know this isn't a solution but maybe you could implement this until there's a fix.

yeah this is the normal aproach, the problem is when you have pagination or async loading, in this case you need more logic

This wouldn't filter the disabled ones. How to exclude the disabled rows?

My implimentation for this:
        onSelectionChange={(keys) => {
          if (typeof keys === "string" && keys === "all") {
            setSelectedKeys(
              new Set(paginatedCompanies.map((company) => company.orgNumber))
            );
          } else {
            setSelectedKeys(new Set(keys));
          }
        }}

checking if selected rows = "all"

Any updates on this?
I've tried both suggested solutions and it does update the selection states of the individual products, but then I'm still encountering some issues:

The checkboxes from each row in the table aren't getting updated when selecting all, which makes it seem like you haven't got anything selected, even though the state has all id's in them.
You can then reselect them which would result in them being added again in the state and a total selection that's a higher number then the total items you have in the table.
When you have a selected a row and then press the toggle select all, it will update the state to select all, while it should deselect them all if you have something selected

For the deselecting all when all rows are already selected I've tweaked the code a bit, but it's still really buggy:
OnSelectionChange={(keys) => {
    if (keys === "all" || keys.size === filteredItems.length) {
        // Toggle selection: if all currently filtered items are selected, deselect all
        if (selectedKeys.size === filteredItems.length) {
            setSelectedKeys(new Set());
        } else {
            // Select all filtered items
            setSelectedKeys(new Set(filteredItems.map(item => item.id)));
        }
    } else {
        // Handle individual selection changes
        setSelectedKeys(new Set(keys));
    }
    console.log("Selected Keys: ", keys);
}}

Hello from Venezuela
This is my solution to get item ID's from the selected items
The object selectedKeys contains the information
`useEffect(() => {
	if (Array(selectedKeys) && (selectedKeys as any) !== 'all') {
		selectedKeys.forEach((e) => {
			console.log(e) // Get selected IDs from the table
		})
	}

	if ((selectedKeys as any) === 'all') {
		console.log(filteredItems) // Get all filtered items from the table
	}
}, [selectedKeys, filteredItems])`

Now you can write a function for handle those selected keys
async function handleDelete(){
         const response = await DeleteItems(selectedKeys)
}

or
async function handleDelete(){
         const items = []
         if (Array(selectedKeys) && (selectedKeys as any) !== 'all') {
            selectedKeys.forEach((e) => {
		console.log(e) // Get selected IDs from the table
                items.push(e)
	    })
         }
         const response = await DeleteItems(items)
}

Hi @lldiegon,
@jenslys solution worked for me, you need to make sure that the map() is returning the correct keys other wise it will confuse the component, I did experience the same issues that you mention, all solve by getting the correct keys.
Hope that helps.

Hi @nardove & @miguelxmarquez
I appreciate you guys taking the time to share your solutions. I will give it another try and report back!


x/talks/present: slide UI should work across browsers and devices

The slide software for the present tool was written for Chrome. It has not been tested
and has issues on other browsers and on touch devices.

It would be wonderful if someone with the right knowledge could make it work more
broadly.

To install the present too, run
  go get code.google.com/p/go.talks/present

closing this vague bug


Crash when trying to use mega_full model

Hello,
I am experiencing a crash when I try to run the mega_full model on my machine. the other 2 models run with no issue, but when I try to launch with mega_full, the terminal I am running in just crashes after a minute or so. No error, no output.
Running on Ubuntu, with a RTX 3060 12gb

the problem was caused by running out of system memory


Add built artifacts to kit

When the react-app starts, if there is a JSON file missing, it throws an error but does not automatically reload if the file is created. We need to start with each JSON already present. This commit adds the built artifacts.
The alternative is to add an instruction to the user to compile (truffle or zos) before running npm run start on the client folder.

To be honest I don't like it because we are setting trap for ourselves in the future when we change/add contracts.
We should either add zos compile instruction or even better let loader to compile contracts if they are not preset and then reload.


boards: sheilds: Add RaspberryPi Pico to UNO FlexyPin Adapter

Add "RaspberryPi Pico to UNO FlexyPin Adapter".
It is a converter-PCB to Arduino UNO form-factor
from Raspberry Pi Pico that is released in Open Source Hardware.
https://www.solder.party/docs/flexypin/adapters/#raspberry-pi-pico-to-uno-flexypin-adapter

@kartben
Could you take a look, please?


Announce/Feedback: MySQL will become shut down by default on Ubuntu images on 03/05/2020

Hi!
We are going to make MySQL service shut down by default on Ubuntu images on 03/05/2020.
If you have any concerns or questions please let use know through this issue.
Thanks!

Generally speaking, please create something like a news feed for these kind of breaking and/or major changes to images
It is unrealistic that people can watch all issues for important changes 😄

Hi @Croydon !
unfortunately GitHub doesn't allow to pin more then 3 issues, so we were waiting for ability to remove the announcement about Xcode so we could pin this one instead.
Thanks!

Hey @Croydon, please make sure you subscribe to the GitHub changelog which is where we usually post news about changes like this. This post should go out today sometime. https://github.blog/changelog/

I suppose, there will be appropriate documentation explaining how to start it, when needed?
Would it be expected to run MySQL as a separate job-service? If that is the case why do you need to provide MySQL server in the hosted Ubuntu images?
Meanwhile, for those still using Azure Pipelines, as same Ubuntu images are being used, it would be nice to expand the documentation on how to do same.

So for GitHub Actions, here is the change to make in order to make this work. https://github.blog/changelog/2020-02-21-github-actions-breaking-change-ubuntu-virtual-environments-will-no-longer-start-the-mysql-service-automatically/
The same should work for azure pipelines, you just need to run the shell command
sudo /etc/init.d/mysql start

I'm interested to understand why this is needed. Would that mean faster GitHub Actions runs for those who do not use MySQL in their workflow? Thanks!

Hello, @hkdobrev
Request - Ability to shutdown/disable system services on an image

PR for swithcing off MySQL was merged https://github.com/actions/virtual-environments/pull/498
Changes will become alive with the next image rollout.

Just curious. What was the reasoning behind this? Does this reduce CPU usage or make the runner faster? Or were you getting too many issues about not being able to use port 3306?

Hello, @martinsbalodis
Request - Ability to shutdown/disable system services on an image

Closing it since Ubuntu Image with this update is availble for all customers now.


bugfix

Codecov Report

Merging #29 (f3b62db) into main (4f9f585) will increase coverage by 76.53%.
The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@            Coverage Diff            @@
##           main      #29       +/-   ##
=========================================
+ Coverage      0   76.53%   +76.53%
=========================================
  Files         0        8        +8
  Lines         0      652      +652
=========================================
+ Hits          0      499      +499
- Misses        0      103      +103
- Partials      0       50       +50

Files
Coverage Δ

scheduler.go
75.70% <100.00%> (ø)

... and 7 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Data race when attempting to close main window from another goroutine

Describe the bug
When attempting to close the main window using system.TheApp.Quit() from another goroutine (say a signal handler) causes a data race condition even when surrounded by AsyncLock() / AsyncUnlock()
How to reproduce
Call system.TheApp.Quit() from another goroutine.
Example code
sigCh := make(chan os.Signal, 1)
signal.Notify(sigCh, syscall.SIGHUP, syscall.SIGINT, syscall.SIGTERM, syscall.SIGQUIT)

b := c.NewBody("Test")

go func() {
   <-sigCh
   // Caught user interrupt, shutting down.

   b.AsyncLock()
   system.TheApp.Quit() // <--- causes a data race
   b.AsyncUnlock()
}()

c.NewButton(b).SetText("Hello, World!")
b.RunMainWindow()

Relevant output
==================
WARNING: DATA RACE
Write at 0x00c00038a2e8 by goroutine 34:
  ??()
      -:0 +0x10593a214
  sync/atomic.CompareAndSwapInt32()
      <autogenerated>:1 +0x18
  cogentcore.org/core/core.(*renderContext).lock()
      /Users/test/go/pkg/mod/cogentcore.org/core@v0.3.5/core/renderwindow.go:588 +0xd0
  cogentcore.org/core/core.(*WidgetBase).AsyncLock()
      /Users/test/go/pkg/mod/cogentcore.org/core@v0.3.5/core/render.go:35 +0xcc
  main.main.func1()
      /Users/test/Dev/test/test.go:29 +0xb8

Previous write at 0x00c00038a2e8 by main goroutine:
  cogentcore.org/core/core.newRenderContext()
      /Users/test/go/pkg/mod/cogentcore.org/core@v0.3.5/core/renderwindow.go:570 +0x34
  cogentcore.org/core/core.(*Stage).newRenderWindow()
      /Users/test/go/pkg/mod/cogentcore.org/core@v0.3.5/core/mainstage.go:380 +0x458
  cogentcore.org/core/core.(*Stage).runWindow()
      /Users/test/go/pkg/mod/cogentcore.org/core@v0.3.5/core/mainstage.go:255 +0x7ec
  cogentcore.org/core/core.(*Stage).run()
      /Users/test/go/pkg/mod/cogentcore.org/core@v0.3.5/core/stage.go:293 +0xb4
  cogentcore.org/core/core.(*Stage).Run()
      /Users/test/go/pkg/mod/cogentcore.org/core@v0.3.5/core/stage.go:272 +0xc8
  cogentcore.org/core/core.(*Body).RunWindow()
      /Users/test/go/pkg/mod/cogentcore.org/core@v0.3.5/core/mainstage.go:71 +0x98
  cogentcore.org/core/core.(*Body).RunMainWindow()
      /Users/test/go/pkg/mod/cogentcore.org/core@v0.3.5/core/mainstage.go:45 +0x58
  main.main()
      /Users/test/Dev/test/test.go:53 +0x644

Goroutine 34 (running) created at:
  main.main()
      /Users/test/Dev/test/test.go:25 +0x1c4
==================

Platform
macOS

Thank you for reporting this. I am somewhat busy right now, but I will still be able to fix this soon (ideally within a few days, but definitely within a couple of weeks).

It appears that the cause of the race condition is the theoretical possibility that you could get one of those signals as the app is starting up, at which point AsyncLock is not possible. Therefore, you can get rid of the race condition by putting your goroutine in OnShow:
	b.OnShow(func(e events.Event) {
		go func() {
			<-sigCh
			// Caught user interrupt, shutting down.

			b.AsyncLock()
			core.TheApp.Quit()
			b.AsyncUnlock()
		}()
	})

Please let me know if this fixes the issue.

Unfortunately, using the above code causes core.TheApp.Quit() to hang in renderwindow.go, func newRenderWindow(), at line 120 whilst attempting to acquire rc.lock()

I fixed the underlying issue in #1309, so this should work now without any race conditions or hanging. You actually do not need to (and cannot) do AsyncLock here, since Quit already has the appropriate mutex protections. As such, this is the appropriate code for the relevant section:
	b.OnShow(func(e events.Event) {
		go func() {
			<-sigCh
			// Caught user interrupt, shutting down.

			core.TheApp.Quit()
		}()
	})

Please let me know if that works for you.

Yes this works perfectly. Thank you.


Binary release (DEB) missing for Rolling/Noble

The binary deb release for Ubuntu Noble (24.04) based Rolling is not available in the repo.
It might be related to the ign->gz rename, perhaps it flew under the radar.
Package for the old Jammy-based Rolling is available, though with a slightly older version (1.2.1 vs current 1.3.0): https://packages.ros.org/ros2/ubuntu/pool/main/r/ros-rolling-gz-ros2-control/
Ref similar issue for Humble, however in this case the package is declared for rolling in rosdistro.
I'm not sure where the problem is, as the release repo has the referenced tag.

If this is not the correct place for this report, please point me in the right direction; I'm opening here partially for discoverability.

I see it's failing on git clone with command:
23:34:48 Invoking 'git clone --branch debian/ros-rolling-gz-ros2-control_1.3.0-1_noble --depth 1 --no-single-branch https://github.com/ros2-gbp/ign_ros2_control-release.git /tmp/sourcedeb/source'

No idea how did it land on the branch name, as it should be debian/rolling/gz_ros2_control...

It seems that the main difference between Jazzy (which builds correctly) and Rolling is the existence of debian/jazzy/noble/gz_ros2_control branch in this repo, which is the source of the commit that is Jenkins builds for Jazzy/Noble.
Meanwhile, Rolling has files generated for Jammy (branch debian/rolling/jammy/gz_ros2_control).
It seems that the person managing the generation of the branches is @ahcorde - would you be able to generate one for Rolling/Noble and re-trigger the buildfarm?

It seems that we have the same issue with the latest release @ahcorde?
https://build.ros2.org/job/Rsrc_uN__gz_ros2_control__ubuntu_noble__source/105/console
15:29:07 subprocess.CalledProcessError: Command '['git', 'clone', '--branch', 'debian/ros-rolling-gz-ros2-control_1.3.1-1_noble', '--depth', '1', '--no-single-branch', 'https://github.com/ros2-gbp/ign_ros2_control-release.git', '/tmp/sourcedeb/source']' returned non-zero exit status 128.

The latest release seems to have fixed it, available on testing branch only
https://build.ros2.org/job/Rbin_uN64__gz_ros2_control__ubuntu_noble_amd64__binary/
Waiting for the next rolling sync to get into main branch.

This week's sync fixed it
$ apt show ros-rolling-gz-ros2-control
Package: ros-rolling-gz-ros2-control
Version: 2.0.0-3noble.20240816.131627


Add deterministic id block signature mode

With this change, igvm files can be created deterministically (when using the same signing key).

@microsoft-github-policy-service agree


Client supports server snapshot

This is based on #334, and is waiting on the server handlers for snapshot keys being done for tests for Publish.

Taking a look at the serverManagesSnapshot stuff. I think this is going to need to be determined more dynamically. I figured there would be a command that creates a change object to rotate the snapshot key to one generated on the server (essentially pushes snapshot responsibility to the server), then on publish we just wouldn't push a snapshot if we didn't have the key, and let the server tell us whether that represents a valid update.

@endpohage:  Good point, thanks!  I moved that to the Initialize function instead.  Publish just tries to do its best to sign a snapshot, and then let's the server accept or not.

@endophage @diogomonica Probably ready for another look?

LGTM

LGTM!


impl(generator): map any type to any proto

https://github.com/googleapis/google-cloud-cpp/issues/13892

This change is

Keep in mind, assuming JSON "type": "any" means google.protobuf.Any may not yield a successful pair of inputs to google::protobuf::util::JsonStringToMessage. While this change will allow work to progress on getting the generator to process the BigQuery Discovery Document without errors, this change may ultimately need to be reverted once we can substitute handwritten proto definitions for specific schema types.

Reviewable status: 0 of 2 files reviewed, all discussions resolved

Ack


Adding tests

This PR adds first tests for configs, making directories and transferring data (on local filesystem). This also includes a PR (merged from adding_rclone into adding_tests) for depreciating pyftpsync and replacing with rclone.
Currently, SSH and remote transfer over a connection is not tested.
The main repo (not tests) is now typed and working with mypy setup on the pre-commit. GitHub actions also seems to be working well now

FYI I've removed myself as a reviewer for this PR, but @JoeZiminski @niksirbi let me know if you'd like me to take a look at anything.

Also, when running mypy -p datashuttle on my machine, the following errors appear:
datashuttle/utils_mod/utils.py:124: error: Incompatible default for argument "password" (default has type "None", argument has type "str")  [assignment]
datashuttle/utils_mod/utils.py:124: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
datashuttle/utils_mod/utils.py:124: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
datashuttle/utils_mod/utils.py:125: error: Incompatible default for argument "private_key_path" (default has type "None", argument has type "str")  [assignment]
datashuttle/utils_mod/utils.py:125: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
datashuttle/utils_mod/utils.py:125: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
datashuttle/datashuttle.py:127: error: Incompatible default for argument "ses_names" (default has type "None", argument has type "Union[str, List[Any]]")  [assignment]
datashuttle/datashuttle.py:127: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
datashuttle/datashuttle.py:127: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
datashuttle/datashuttle.py:302: error: Incompatible default for argument "remote_path_local" (default has type "None", argument has type "str")  [assignment]
datashuttle/datashuttle.py:302: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
datashuttle/datashuttle.py:302: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
datashuttle/datashuttle.py:303: error: Incompatible default for argument "remote_path_ssh" (default has type "None", argument has type "str")  [assignment]
datashuttle/datashuttle.py:303: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
datashuttle/datashuttle.py:303: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
datashuttle/datashuttle.py:304: error: Incompatible default for argument "remote_host_id" (default has type "None", argument has type "str")  [assignment]
datashuttle/datashuttle.py:304: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
datashuttle/datashuttle.py:304: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
datashuttle/datashuttle.py:305: error: Incompatible default for argument "remote_host_username" (default has type "None", argument has type "str")  [assignment]
datashuttle/datashuttle.py:305: note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
datashuttle/datashuttle.py:305: note: Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase

I think these have to do with the fact that you do not include None as a possible type in the Union, and then you declare None to be the default value.

Thanks a lot Niko, very good point about datashuttle.py I will make an issue to do this. I'll merge for now and adress these on a newer PR as I think some of that code has gone.


Fix Mac Catalyst test dependency failures

A CMake refactoring in apple/swift#34859 caused failures in Mac Catalyst configurations which are not tested in open source. This PR corrects these issues.
Fixes rdar://71897958.

@swift-ci please test


Fix GEP template - status link was wrong

Status definitions were pointing to the wrong file

/ok-to-test


Feature Request - Async validation for ShowInputBox

Scenario:
The Azure App Service Extension uses ShowInputBox to prompt user for the name of the new web app to be created. Then it checks the name availability by trying to resolve the DNS name of the web app. This operation can take up to a few seconds depending on network speed.
Currently the ShowInputBox doesn't seem to support async validation function, which means we can only validate after ShowInputBox function is done and re-prompt if the DNS value turns out not available.
The optimum experience: ShowInputBox supports async validation, when the validation function is running, the input box shows a progress indicator and won't allow the value be accepted (pressing Enter won't close the box), ESC should still cancel the input regardless.

Understood. Technically it is already async but we wanted to enforce prompt and speedy validation because the user experience depends on this...

@jrieken is this something you expect to support, and if so in Sept or later?  thx.

We can support it, tho very unlikely in September


Use song reactions for !np actions

The one I would find more interesting is for !np repeat, but maybe !np clear, !np source and !np updatetitle would be good too.
Edit: another one for !pause too

the problem is that every reaction takes time to add, and when its 3+ it gets really slow.
Maybe they could all be added as toggle-able options

Oh, yes, I didn't thought about the rate limiting. What do you mean with
toggle-able?


Implement tag based release

Go best practice for publishing Go Modules (libraries) is to tag each semantic version. I plan to start a project using cedar-go soon and it would be nice to have tagged releases.
Reference: https://go.dev/blog/publishing-go-modules

Thanks @caiorcferreira!  I agree, we'll try and do that by the next release.

I'd propose using a v0 prefixed version until we've reached parity (or near parity) with the Rust implementation.
Less valuable but if its useful, we can mirror rust within v0 like: rust is at v4.1.2, go is at v0.4.*.

We've started making tagged releases, enjoy!
https://github.com/cedar-policy/cedar-go/releases


RAT profile - misleading button when capturing date of birth

Avoid duplicates

[X] Bug is not mentioned in the FAQ
[X] Bug is specific for iOS only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[X] Bug is not already reported in another issue

Technical details

Device name: iPhone 13 mini
iOS version: 15.5
App version: 2.22

Describe the bug
Entering the date of birth into the rapid test profile, there is a Button "Save" which saves the whole profile, although it looks like it saves the date of birth input only. This is misleading and confusing for the user.
Here's a screenshot:

Steps to reproduce the issue

Open the CWA
Click on "Manage Your Tests"
Click on "Rapid Test Profiles"
Click on "Create rapid test profile"
Click on the "Date of Birth" field
See that the misleading button moves up

Expected behaviour
Clear button description ("Save profile") or hide the button during date of birth input.
Possible Fix
Either change the button description or hide the button.

Internal Tracking ID: EXPOSUREAPP-7290

As the CWA project went into ramp-down mode & this is only a minor issue, I don't expect it to be addressed anymore. I'm therefore closing this issue.


[Event Request] Codeunit::370 "Bank Acc. Reconciliation Post" - Function Post - OnAfterFilterBankAccRecLines

Could You please, add the following event to the codeunit 370 "Bank Acc. Reconciliation Post" to manage the filters applied to record Bank Acc. Reconciliation line?
Object: codeunit 370 "Bank Acc. Reconciliation Post"
Function Post(BankAccRecon: Record "Bank Acc. Reconciliation")
Publisher Event: OnAfterFilterBankAccRecLines
Reason: To implement custom business logic and manage to place additional filters in Bank Acc. Reconciliation Lines table
Where is the event placed (see image attached)?:

below the line :
BankAccReconLine.FilterBankRecLines(BankAccRecon);
place the call to the event:
OnAfterFilterBankAccRecLines(BankAccReconLine,BankAccRecon);
Event Code:
[IntegrationEvent(false, false)]
local procedure OnAfterFilterBankAccRecLines(var BankAccReconLines: Record "Bank Acc. Reconciliation Line"; BankAccRecon: Record "Bank Acc. Reconciliation")
begin
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Menu doesn't show up

Steps to reproduce:

Compile in debug
Run csgo.exe with -insecure argument
Use Xenos64 native injection with this configuration

Voila! Menu captures all inputs but fails to render.

Are you using third-party in-game overlays?

Are you using third-party in-game overlays?

I am using vanilla CS:GO. Compiling in release did nothing, as well as using manual map injection with the release build.

I am using vanilla CS:GO. Compiling in release did nothing, as well as using manual map injection with the release build.

i have the same problem.
i start cs:go with -insecure and i see the menu
but i start cs:go normaly without -insecure i dont see the menu.
i dont know why mhh

i have the same problem.
i start cs:go with -insecure and i see the menu
but i start cs:go normaly without -insecure i dont see the menu.
i dont know why mhh

i have the same problem.
i start cs:go with -insecure and i see the menu
but i start cs:go normal without -insecure i dont see the menu.
i dont know why mhh

Use manualmap injection

i have the same problem.
i start cs:go with -insecure and i see the menu
but i start cs:go normal without -insecure i dont see the menu.
i dont know why mhh

Use manualmap injection

I have found out something, Daniel's VAC Bypasser causes menu to fail to render. I haven't yet found out how to fix it though.


Step 8: Inaccurate Description

The description of step 8 states:

...updates to a restaurant document can only change the ratings, not the name or any other immutable data.

However, the update rule only makes sure the user is authenticated and the restaurant name is unchanged - any other change to the restaurant object would be possible.
  match /databases/{database}/documents {
        // Restaurants:
        //   - Authenticated user can read
        //   - Authenticated user can create/update (for demo)
        //   - Validate updates
        //   - Deletes are not allowed
    match /restaurants/{restaurantId} {
      allow read, create: if request.auth != null;
      allow update: if request.auth != null
                    && request.resource.data.name == resource.data.name
      allow delete: if false;
    `

@ronykrell you're right that's a mistake, thanks for reporting this!

mRegistration is null so startListening() cannot attach listener

I made a change to make the rules much better and added a generic example to the snippets-rules repo:
https://github.com/firebase/snippets-rules/pull/9
Thanks @ronykrell


Fix message if cause is not instance of expected type

Check List:

Fixes #883
Unit tests : NO (I didn't find tests on exception messages =( )
Javadoc with a code example (API only) : NA

Thanks, I will add a test for that before integrating it.

Pull request merged. Thanks! 👍
I also added a test: https://github.com/joel-costigliola/assertj-core/commit/af048fe50d3f6094e72634f48b5f8261027b6f76


MJ Variations Update

Current Regex:
private static final String CONTENT_REGEX = "\\*\\*(.*?)\\*\\* - Variations by <@\\d+> \\((.*?)\\)";
Doesn't support new variation's titles

Another possible option is "Subtle"


Download only what is required in _dowload_osm_bbox

There's a lot of information provided when downloading by bbox that is not used to build the networkx graph.
Perhaps a query using overpy + filtering can make this work faster and more efficiently.

👍
Pull requests welcome for this.


Merge changes and add Xcode 6.4 DVTPlugInCompatibilityUUID

Fixes #8, closes #18, closes #19, closes #20, closes #21, closes #23.

👍

👏👍

@Hs-Yeah Please add commit https://github.com/ClementPadovani/ACCodeSnippetRepositoryPlugin/commit/9f2fc7290f4c51239f45e5901b939c77f0bcbda4 that fixes https://github.com/acoomans/ACCodeSnippetRepositoryPlugin/issues/25

@ClementPadovani Merged in my branch, thanks you.


Add spam Example

Description
Fixes issue #371
Adds the Spam learning notebook like example from the PySyft repository.
Type of change

[x] New feature (non-breaking change which adds functionality)
Had to change the batch size to a bigger number such that the training will finish more quickly (it still took some time)

How Has This Been Tested?

First run the notebook for distributing the dataset
Then run the training notebook

Checklist:

[x] I did follow the contribution guidelines

Hello @gmuraru,
Could you run black . to fix code style issues?
Awesome work! I really appreciate it.

Done :)


[blog] Add post about how MUI uses Toolpad

Preview: https://deploy-preview-40172--material-ui.netlify.app/blog/toolpad-use-cases/

Rebased on HEAD and fixed the build.

I see Danilo mentioned about the failing tests on some of his PRs. I am assuming this PR falls in the same bucket.
Bringing this to your notice @Janpot. Thanks.

We just missed uptading the publishing date, though, it's set to Sunday, March 3th. 😬 Not a big deal, we can adjust it later!

We just missed uptading the publishing date, though, it's set to Sunday, March 3th. 😬 Not a big deal, we can adjust it later!

It's 4th March, today. Are we checking the same date? 😅

Huh, weird, I see Sunday 😅 Maybe it's timezone-related somehow?


Raise error if dataframe is empty

Description
closes: https://github.com/astronomer/astro-sdk/issues/810
What is the current behavior?
In case of an empty dataframe the data frame operator throws an SQL syntax error.
What is the new behavior?
If the database does not support the creation of a table without a column then raise an error
Does this introduce a breaking change?
No
Checklist

[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

In my opinion, we should not be creating tables as part of load_pandas_dataframe_to_table if an empty dataframe is passed as to me it sounds like a side effect.
If the user really wants to create a table by passing an empty dataframe, we could add a separate method for that. But load_pandas_dataframe_to_table would mean load a dataframe and if that is empty in my opinion, we should alert instead of silently just creating the table.

In my opinion, we should not be creating tables as part of load_pandas_dataframe_to_table if an empty dataframe is passed, as to me, it sounds like a side effect. If the user really wants to create a table by passing an empty dataframe, we could add a separate method for that. But load_pandas_dataframe_to_table would mean load a dataframe and if that is empty, in my opinion, we should alert instead of silently just creating the table.

+1 on this. I feel we should not do multiple things as part of same method.


DocsArchive-<IP_ADDRESS>Auto archive content

Auto archive content from https://github.com/huangmin-ms/docs-archive-test-source.git

Docs Build status updates of commit 0c537a3:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-UserAccountBuildPermissionInsufficientError] Owner v-alji no longer has Read permission of the repository https://github.com/huangmin-ms/docs-archive-test-target. It might be due to recent GitHub changes on SSO. Please ask the owner v-alji to logon to Docs Portal https://ops.microsoft.com once again. If it is not the case, please ask anyone of Admin permission of the repo to assign a new owner via Docs Portal https://ops.microsoft.com

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 0c537a3:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error-UserAccountBuildPermissionInsufficientError] Owner v-alji no longer has Read permission of the repository https://github.com/huangmin-ms/docs-archive-test-target. It might be due to recent GitHub changes on SSO. Please ask the owner v-alji to logon to Docs Portal https://ops.microsoft.com once again. If it is not the case, please ask anyone of Admin permission of the repo to assign a new owner via Docs Portal https://ops.microsoft.com

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Eliminate platform requirement

@mluisbrown I realized #8 was still open and was hoping to close it out.
A quick test and I can't get the array literal to compile when targeting iOS 11, which seems to indicate that the latest Xcode release has fixed the bug you were experiencing?

Hey @stephencelis it's fine, I'm going to drop support for iOS 12 and below on the RAS fork so it's no longer a problem.

@mluisbrown Going to merge this anyway since I think it's better to not have the platform requirement at the package level. Hopefully it solves things for others!


Is there a YOLOX P2 model?

Is there an option or implementation of a YOLOX model with an extra scale output for small objects as also available in the original YoloV5: https://github.com/ultralytics/yolov5/blob/master/models/hub/yolov5-p2.yaml

I'm sorry that the plan of yolox-p2 is delaying.

That is too bad. YOLO5 P2 architecture is pretty powerful, 2-3% boost with still decent inferencing time.

@FateScript
any update on this?

@tharindu326  I'm sorry that our team don't have enough time and energy of doing this nowadays.
Maintaining  open source  repo is just a part-time job(not paid) for our team. If updated, we will release a new version of YOLOX.
Thanks for your patcience.


redeploy + some fixes

Time spent on this PR: 0.3 day
Pull request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behavior?
Staging can't run correctly currently.
Resolves #NA
What is the new behavior?

Upgrades Kakarot on staging
Adds a type of network "staging" which allows upgrades but also uses the "EVM" fixture.

This change is

can add the enum, that makes more sense.
I missed the Counter and MockPragmaOracle actually, but I don't think these were failing, I don't think the MockPragmaOracle is being tested yet in the staging. Might have to move also the Counter and MockPragmaOracle to be deployed/upgraded on staging.
What did fail was that setting the Network to "devnet" caused it to redeploy all the time instead of upgrading which isn't what we were looking for.


Beta -> Master

Fixes [issue-number]
Creator

[ ] Build relevant tests if any apply
[ ] Ensure there are no new warnings
[ ] Upload an animated GIF showcasing the solution (if it applies)
[ ] Set a relevant reviewer

Reviewer

[ ] Run test and make sure all tests pass
[ ] Review function and form on iOS
[ ] Review function and form on Android
[ ] Review function and form on Web
[ ] Review new test logic

@IsaacHardy this is old android fixed stuff, can we merge this into master?


I am getting red angled brackets and I dont know why

I am getting red angled brackets in these lines of HTML5 Code and I dont know why, I narrowed it down to one line of code producing the rest of the red brackets, but I cant see whatis wrong with the line of code. Here is the code I believe to be wrong somehow:
 Used when aligning the text, in comparision to the image. Left or right. The image element must be placed between the opening and closing tags of the paragraph element When Aligning where the first line of text should occur, top, middle or bottom values can be used.
 The src attribute is used to identify the location of the image.
If the image is located in the same folder then, only the file name is needed, like the  links a ../ is used to go up a directory,

		where as the 'directory name'/ is used to go deeper in to the directories. A File name still needs to be identified.

		There are many attributes that come a long with the img element

 alt

 A description used and displayed when the image is not visable

 title

 Used for addition info - Usually displayed when you hover over the image

 height and width

 Used when changing the size of the image, can used only height and a percentage to adjust the size using percent

 align

 Used when aligning the text, in comparision to the image. Left or right. The image element must be placed between the opening and closing tags of the paragraph element
When Aligning where the first line of text should occur, top, middle or bottom values can be used.

figure

 figure is used to notify the browser that the caption and image is associated. Surrounding the 'img' and 'figcaption' element.

 figcaption

 Used to add a caption to images

Any help is appriciated

GitHub issues aren't really the place for questions like this, but the friendly folks over at the freeCodeCamp forum are pretty helpful and will respond way faster than you'll get by asking here! Just this once, though, I'll offer some help so you can close this issue.
I plopped your code into Brackets to figure out the problem.
 Remember that elements should always be like this:

Link Text

Your code does this:

You also have two "close paragraph" tags at the end.
This is an easy mistake to make when you're starting out, and the way to avoid making it is to use indentation whenever you nest elements inside each other.
That's all! Good luck!

Thanks for answering @RebekahAimee!
For what it is worth, I am okay with these kinds of support questions on GitHub too as sometimes it is not immediately obvious what the issue is. For example if Brackets would have better shown where the wrong nesting is, there wouldn't be issues like this 👍
Closing as answered, thanks again @RebekahAimee!


UserAgent appears to make a localhost:80 http request when given a file:/// URL

Mojolicious version: 7.01
Perl version: 5.14.2
Operating system: Debian 7.10

Steps to reproduce the behavior
mojo get file:///foo/bar.txt
(or $ua->get(...))

Actual behavior
mojo performed a GET request for http://localhost/foo/bar.txt

From my POV 'silently doing the wrong thing' is a bug, not a missing feature - though, OTOH, I guess you could see it as more a usability failure.
 The problem is when/where could/should the error come from; especially assuming we don't want to make $ua->get('file://...') die in-place on nonblocking requests.
There is also the broader question, should we limit all unexpected schemes or just file? Assuming we want to limit all unknown schemes the obvious place to throw the exception is here: https://github.com/kraih/mojo/blob/70c177dc48fa65bc6498c7a0c39b4458903fe991/lib/Mojo/UserAgent.pm#L98 . The problem is that to this point all exceptions (see _error) assume there is a connection id in the hash of data. This one does not yet have the id so the infrastructure for reporting errors would have to change (or maybe I'm just not seeing it).

I had considered another thought which would be to build a Mojo::Asset::File for the file in question. However I do worry that there is code in the wild that wouldn't be guarding against that and suddenly they might get local files leaking into the world. There would likely need to be some kind of guard established that would protect that and so now this would need to be a whole new designed feature. I don't see that happening. I just mention here to note that I have thought about it.

Also keep in mind if you wanted to build a Mojo::Asset::File you would need to map the file: URL to the filesystem a la URI::file (for example the url file:///C:/foo/bar which on win32 would map to C:\foo\bar and on unix to ./C:%5Cfoo%5Cbar). So it's probably not worth going down that path.

For the error, I would think it should ideally throw an exception immediately (croak to the caller of the method). It's an invalid parameter error not a connection error.

Do we have an implementation yet?

After posting a patch on IRC and talking a bit about it, i'm afraid i have to vote :-1: on this. Because there is simply too much data the user provides for us to validate everything, and this would set a dangerous precedent. https://gist.github.com/anonymous/6cb0ed7ad64c91c05facd6f49a41df53

👎 from me as well.

I appreciate that you can't validate everything, but that's not the same as "not making a completely different sort of request".

If I tell Mojo to do something, and it instead does something completely different, that's rather confusing.
I'm not sure how "don't silently do something completely different to what the user asked for" is a dangerous precedent?

How is mojo get file:///foo/bar.txt you not telling mojo to do something wrong?

My point here is the difference between it attempting to do what I asked, right or wrong, and doing something completely different.
So far, the rest of mojo has been free of such nasal daemonesque moments.

Basically, I was figuring that whichever bit of code decides whether it's making an http or https request should already be poking the URL scheme somehow, so at that point you're already extracting and testing it, at which point adding a third case for 'throw error' should be relatively easy and you're already paying for checking the proto there anyway.

Looking in Transactor.pm, there's plenty of prior art for validating this. For example, from 'sub redirect' -
return undef if ($proto ne 'http' && $proto ne 'https') || !$location->host;

Could something this basic suffice?
https://gist.github.com/lindleyw/19052f7a91103ad353f38f2f5deb44b6

There's no $tx at that point, so where do you catch the error?

@lindleyw Have you actually tested that approach? Because it doesn't seem viable at all to me.

@shadowcat-mst None of the proposed patches match those criteria.

It's a trifle inefficient in the case where it's erroring, but given the point is to point out a bug I'm not sure I mind, and the following seems to work:
diff --git a/lib/Mojo/UserAgent.pm b/lib/Mojo/UserAgent.pm
index ebe9537..adc01a8 100644
--- a/lib/Mojo/UserAgent.pm
+++ b/lib/Mojo/UserAgent.pm
@@ -293,6 +293,14 @@ sub _start {

   # Application server
   my $url = $tx->req->url;
+  my $proto = $url->protocol;
+
+  if ($proto && $proto ne 'http' && $proto ne 'https') {
+    $tx->res->error(qq/Unsupported protocol "$proto"/);
+    $self->ioloop->next_tick(sub { $cb->($self, $tx) });
+    return;
+  }
+
   unless ($url->is_abs) {
     my $base
       = $loop == $self->ioloop ? $self->server->url : $self->server->nb_url;
diff --git a/t/mojo/user_agent.t b/t/mojo/user_agent.t
index de5e604..2697be7 100644
--- a/t/mojo/user_agent.t
+++ b/t/mojo/user_agent.t
@@ -592,4 +592,11 @@ Mojo::IOLoop->delay(
 )->wait;
 is scalar @$result, 2, 'two active connections';

+# Unsupported protocol
+like
+  $ua->get('file:///etc/passwd')->res->error,
+  qr/Unsupported protocol "file"/,
+  'right error';
+
+
 done_testing();

@shadowcat-mst How would you explain the inconsistency in URL validation between the request URL ($tx->req->url) and the proxy URL ($tx->req->proxy)?

Currently, if you give it a ridiculous proxy -
sherlock$ perl -Mojo -MData::Dumper -E 'my $ua = app->ua; $ua->proxy->http("file://home/matthewt/tmp/foo"); say Dumper $ua->get("http://google.com/")->res->error'
$VAR1 = {
          'message' => 'Can\'t connect: Name or service not known'
};

you get an error rather than it silently making an http request to localhost.
So from my POV, I'm making things less inconsistent. We could even make the error the same, although I think the error I stole from your original patch is better.

@shadowcat-mst Your test case is a little misleading though.
perl -Mojo -MData::Dumper -E 'my $ua = app->ua; $ua->proxy->http("file://mojolicious.org/matthewt/tmp/foo"); say Dumper $ua->get("http://google.com/")->res->error'
$VAR1 = undef;

Here a request is actually performed.

@kraih Really? I did an strace and couldn't find a connect().

@shadowcat-mst YA RLY!
$ MOJO_USERAGENT_DEBUG=1 perl -Mojo -MData::Dumper -E 'my $ua = app->ua; $ua->proxy->http("file://mojolicious.org/matthewt/tmp/foo"); say Dumper $ua->get("http://google.com/")->res->error'
-- Blocking request (http://google.com/)
-- Connect c338ca711bfc9cee65ed3b43de8f1b25 (file://mojolicious.org:80)
-- Client >>> Server (http://google.com/)
GET http://google.com/ HTTP/1.1\x0d
Accept-Encoding: gzip\x0d
User-Agent: Mojolicious (Perl)\x0d
Host: google.com\x0d
Content-Length: 0\x0d
\x0d

-- Client >>> Server (http://google.com/)

-- Client <<< Server (http://google.com/)
HTTP/1.1 200 OK\x0d
Server: nginx\x0d
Date: Fri, 19 Aug 2016 20:37:30 GMT\x0d
Content-Type: text/html;charset=UTF-8\x0d
Transfer-Encoding: chunked\x0d
Connection: keep-alive\x0d
Content-Encoding: gzip\x0d
\x0d
4d\x0d
\x1f\x8b\x08\x00\x00\x00\x00\x00\x00\x03\x0b??,V\x00???\x12\x85\x92\x8cT\x85????Ң?T\x85??R??T\x85\x9c???̼t\x85??"=\x05???T\x85?\x9c??t=...\x00h?\x02?;\x00\x00\x00\x0d
0\x0d
\x0d

$VAR1 = undef;

Your original test case bailed out during DNS lookup, but if you get past that a request can be performed.

@kraih Nuts. Good catch. Ok, going to have to have a think about this.

Honestly, what worries me most is the security implications, such as users suddenly expecting all input values to be validated if one is.
$ua->get('file://mojolicio.us/foo' => {'Content-Type' => "text/plain\nAuthorization: foo"});

Right, the distinction that I'm trying to draw is that I'm fine with "users are responsible for validating data, and if you pass wrong data it will still do exactly what you told it" - but in this case, if I pass wrong data it does something that, to my mind, isn't even within shouting distance of what I told it to do.
Your header example seems entirely expected. I'd also not feel upset if a file:// URL revealed files on disk because again that's what I passed. But the current behaviour is, to me, more in the category of "oh, and if you put a newline in a header, mojo silently switches from GET to POST" - honestly, I think I'd've preferred nasal daemons to "makes a request to localhost:80 for a file:// URL" ;)
So I guess before we spend more time thinking about the code, I guess the question is - does that distinction make sense as a thing that exists (and if not, why not), and if so what do you think about "doing the wrong thing you asked for is not our fault, but nasal daemons are a bug" precedent that I'd like to set here.

Kinda seems like this thing isn't really worth the hassle. 👎

For the record, I think that saying that the UserAgent can't handle any protocols except "http(s)?" is different that expecting full validation. As @kraih mentioned, Mojo::Pg checks for postgresql:// but doesn't validate queries.

Looks like the majority agrees that we should just leave everything the way it is.


download-binaries name changes

I am upgrading a library package that uses ort (with default features). After updating to 2.0.0-rc.0 and running the library, I ran into this issue:
'libonnxruntime.so.1.17.0: cannot open shared object file: No such file or directory'
I checked the folder with our library binary, and there is a libonnxruntime.so file. However, older versions of ort were downloading/building an additional binary (e.g., libonnxruntime.so.1.14.1) which appears to be a renamed copy of the libonnxruntime.so file.
In 2.0.0-rc, renaming the libonnxruntime.so to libonnxruntime.1.17.0 appears to fix the issue. It seems to me like to 2.0.0-rc.0 no longer does this renaming with default-features - is this expected, or am I doing something wrong?

I am also running with a few execution providers, relevant snippet of my Cargo.toml below:
[dependencies]
rustler = "0.29.0"
ort = { version = "2.0.0-rc.0" }
ndarray = "0.15.6"
half = "2.2.1"
tracing-subscriber = { version = "0.3", features = [ "env-filter", "fmt" ] }
num-traits = "0.2.15"

[features]
# ONNXRuntime Execution providers
directml = ["ort/directml"]
coreml = ["ort/coreml"]
cuda = ["ort/cuda"]
tensorrt = ["ort/tensorrt"]

I am using Rustler (Elixir - Rust bridge package) to build my lib, and I'm not sure how it's downloading anything, since I don't see the .so's when building it myself. I'm still investigating.
It may help to download binarie - is it possible to download libonnxruntime.so.1.17.0 using any features? Modifying my cargo to ort = { version = "2.0.0-rc.0", features = ["download-binaries"]} doesn't appear to download any in the target/(debug/release) directories

It may help to download binaries - is it possible to download libonnxruntime.so.1.17.0 using any features? Modifying my cargo to ort = { version = "2.0.0-rc.0", features = ["download-binaries"]} doesn't appear to download any in the target/(debug/release) directories

I am using Rustler (Elixir - Rust bridge package) to build my lib, and I'm not sure how it's downloading anything, since I don't see the .so's when building it myself. I'm still investigating.

ort will download static libraries without any EP features enabled, so there won't be anything in the target folder.
The only time dynamic binaries are downloaded is when cuda or tensorrt is enabled, and on Linux these binaries are originally versioned like libonnxruntime.so.1.17.0. The packaging code renames the versioned library to libonnxruntime.so in the final archive hence the error. A simple symlink should fix it.

Sounds great, thanks for your help!


What is flags mean in the Upscale API？

the code that reproduces this issue or a replay of the bug
client.Upscale({
content: prompt,
index: index as 1 | 2 | 3 | 4,
msgId,
hash: msgHash,
loading: (uri: string) => {
},
})
Describe the bug
Describe the bug
i'm using version was @3.0.8,when i trying to upscale image by use Upscale API, the console.log tell me parameter can't not match the API params! I lookup the source, but i have not idea what flags the api need
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
error log
Property 'flags' is missing in type '{ content: string; index: 1 | 2 | 3 | 4; msgId: string; hash: string; loading: (uri: string) => void; }' but required in type '{ index: 1 | 2 | 3 | 4; msgId: string; hash: string; content?: string; flags: number; loading?: LoadingHandler; }'.

https://github.com/erictik/midjourney-client/blob/main/example/upscale-ws.ts

Thanks, I just found that the document has an example of the opposite of the update


Update MD file on new branch 2017-11-09_03-26-34

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/content1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[Task] Harvester v1.2.0-rc3 release

Harvester v1.2.0-rc3 Release Tracking List:
View all the v1.2.0-rc3 required issues via the zenhub link.
⚠ P0:

https://github.com/harvester/harvester/issues/3747 - owner @guangbochen @bk201
https://github.com/harvester/harvester/issues/2679 - owner @ibrokethecloud @WuJun2016

https://github.com/harvester/harvester/pull/4041 - PR review @guangbochen @bk201
https://github.com/harvester/experimental-addons/pull/1  - PR review @guangbochen @bk201

https://github.com/harvester/harvester/issues/2198 - owner @ibrokethecloud

https://github.com/harvester/harvester-installer/pull/457 - PR review @Vicente-Cheng @futuretea @bk201 @guangbochen

https://github.com/harvester/harvester/issues/2318 - owner @ibrokethecloud

https://github.com/harvester/seeder/pull/9,  - PR review @guangbochen @starbops  @futuretea @bk201
https://github.com/harvester/charts/pull/139 - PR review @guangbochen @bk201

https://github.com/harvester/harvester/issues/4049 - owner @chrisho

https://github.com/harvester/harvester/pull/4054 - PR review @guangbochen @WebberHuang1118 @w13915984028 @futuretea

https://github.com/harvester/harvester/issues/4087 - owner @w13915984028 @DaiYuzeng

https://github.com/harvester/harvester-installer/pull/512 - PR review @guangbochen @bk201 @starbops

https://github.com/harvester/harvester/issues/4095 - owner @Vicente-Cheng

ℹ  P1:

https://github.com/harvester/harvester/issues/3928 - owner @masteryyh
https://github.com/harvester/harvester/issues/3218, https://github.com/harvester/harvester/issues/3412 - owner @Vicente-Cheng

https://github.com/harvester/node-disk-manager/pull/55 - PR review @ibrokethecloud @chrisho @guangbochen @bk201

https://github.com/harvester/harvester/issues/2670 - owner @bk201
https://github.com/harvester/security/issues/27 - owner @guangbochen
https://github.com/harvester/harvester/issues/2894 - owner @connorkuehl, patch the timeout via the webhook
https://github.com/harvester/harvester/issues/3644 - owner @w13915984028

https://github.com/harvester/harvester/pull/3998 - PR review @guangbochen @bk201

https://github.com/harvester/harvester/issues/1947 - owner @WebberHuang1118

https://github.com/harvester/harvester/pull/4043 - PR review @bk201 @Vicente-Cheng

https://github.com/harvester/harvester/issues/2983 - owner @masteryyh

https://github.com/harvester/harvester/pull/4111 - PR review

https://github.com/harvester/harvester/issues/4109 - owner @w13915984028
https://github.com/harvester/harvester/issues/3524

https://github.com/harvester/pcidevices/pull/55 - PR review @guangbochen @bk201 @WebberHuang1118

https://github.com/harvester/harvester/issues/3595

https://github.com/harvester/harvester/pull/3915 @w13915984028 @futuretea @guangbochen @bk201

https://github.com/harvester/harvester/issues/3587

https://github.com/harvester/os2/pull/62 - PR review @bk201 @masteryyh

https://github.com/harvester/harvester/issues/3867 - owner @WebberHuang1118
https://github.com/harvester/harvester/issues/4108 - owner @ibrokethecloud

https://github.com/harvester/harvester/pull/4110 - PR review @guangbochen @bk201 @w13915984028

https://github.com/harvester/harvester/issues/4071 - owner @w13915984028

https://github.com/harvester/harvester/pull/4117 - PR review @guangbochen @bk201 @ibrokethecloud

HEPs

https://github.com/harvester/harvester/pull/3673 - pending on review & final polish @bk201 @guangbochen
https://github.com/harvester/harvester/pull/2378 - @ibrokethecloud address the review comment
https://github.com/harvester/harvester/pull/3666 - @futuretea to polish the HEP
https://github.com/harvester/harvester/pull/3230 - @ibrokethecloud  double check if we need this?

[BUG] Upgrade stuck in upgrading first node: Job was active longer than specified deadline #2894 - owner @connorkuehl, patch the timeout via the webhook

@guangbochen @bk201 @markhillgit I found an issue when testing the job mutator for this. The system-upgrade-controller will detect that the job has a different timeout and it will patch it back to the default timeout. If I update the job mutator to patch update requests for the timeout, the system-upgrade-controller will spin trying to patch it.
I asked in Rancher Users about this[1] and they indicated they'd accept a patch for customizing a Plan's job timeout with the Plan CR.
I've submitted a patch upstream[2], but I do not know if it will be accepted and included in a release fast enough for Harvester to use it in rc3.
[1] https://rancher-users.slack.com/archives/C3ASABBD1/p1686951043646069
[2] https://github.com/rancher/system-upgrade-controller/pull/244

cc @connorkuehl   An possible alternative solution is:
In upgrade_manifests.sh, patch system-upgrade-controller related configmap, set a new value (this value can be fetched from version object annoations to adjust dynamically, like following minFreeDiskSpaceGB), and then kill  system-upgrade-controller PODs, the replaced new PODs will use the new configmap value.
apiVersion: harvesterhci.io/v1beta1
kind: Version
metadata:
  annotations:
    harvesterhci.io/minFreeDiskSpaceGB: "20"
  name: v1.2.0
  namespace: harvester-system
...

@connorkuehl your concern is correct; we could only include the upstream SUC changes in the future embedded Rancher version upgrade.
In the current stage, I believe Jian's suggestion would work, but instead of patching the configmap, it is preferred to patch the system-upgrade-controller managedChart.  cc @bk201

close as the https://github.com/harvester/harvester/releases/tag/v1.2.0-rc3 is out, will continue track release via https://github.com/harvester/harvester/issues/4215.


Drop HCO for now

Today HCO lacks regular updates and correct versions numbers, due to this I'm proposing to
drop HCO for now until these two points get addressed.
Signed-off-by: Fabian Deutsch<EMAIL_ADDRESS>Thanks submitting your Operator. Please check below list before you create your Pull Request.

Flat operator directory structure is obsolete from 23-rd of October 2019, only nested directory structure will be accepted.

New Submissions

[ ] Has you operator nested directory structure?
[ ] Have you selected the Project Community Operator Submissions in your PR on the right-hand menu bar?
[ ] Are you familiar with our contribution guidelines?
[ ] Have you packaged and deployed your Operator for Operator Framework?

[ ] Have you tested your Operator in all supported installation modes?
[ ] Is your submission signed?

Updates to existing Operators

[ ] Is your new CSV pointing to the previous version with the replaces property?
[ ] Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
[ ] Have you tested an update to your Operator when deployed via OLM?
[ ] Is your submission signed?

Your submission should not

[ ] Modify more than one operator
[ ] Modify an Operator you don't own
[ ] Rename an operator - please remove and add with a different name instead
[ ] Submit operators to both upstream-community-operators and community-operators at once
[ ] Modify any files outside the above mentioned folders
[ ] Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

[ ] Description about the managed Application and where to find more information
[ ] Features and capabilities of your Operator and how to use it
[ ] Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

[ ] Human readable name and 1-liner description about your Operator
[ ] Valid category name1
[ ] One of the pre-defined capability levels2
[ ] Links to the maintainer, source code and documentation
[ ] Example templates for all Custom Resource Definitions intended to be used
[ ] A quadratic logo

Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file a PR against this repo and explain your need
2 For more information see here

/cc @tiraboschi @rthallisey  @dankenigsberg

Please merge.

This is disappointing, but the best thing we should do right now.
/lgtm

Thanks


ply vids in loop

how to play vedio in loop and also is ther any speasil config for iptv url "ts" becaus the player is very slow and laguing !!!
also when a play vedio  only song i played!!!
this is a link if someone want to test : http://iptv.ndasat.com:88/live/550290029873347/550290029873347/1708.ts
thx

hi tnx for replay
the problem is when  i play vedio only the song is played without video image!!!
a nother problem i face now .. see the image below

What's wrong?

this player is good but infortunaly not for iptv streaming
black screan ,wating too long to play streamed tv , error c ant not play this video ...
thx

you can change to ijkplayer in one line code.

can you plz show me how??


OS Error 1

I installed netscanner with cargo and there were no errors, I'm using a raspberry pi (ARM) running debian 12  and upon trying to run netscanner I'm faced with
❯ netscanner netscanner failed with Error: Unable to create datalink channel: Operation not permitted (os error 1)

Did you tried to run it with sudo?

Hi,
As @K0ntact mention - did you try run it with sudo please ? That should help. If not - please let me know.
Btw. I have to try it run on RPi with debian also, just for curiosity :)
Thanks

@K0ntact @Chleba Yes it worked when running with sudo, i too ran this on a raspberry pi and by default i wasn't able to run this with sudo and was faced with no not found error, however setting an alias to the location of the file ~/.cargo/netscanner I was able to run it fine. Thank you for the solution @K0ntact

it would be great if the error suggested running with sudo instead, so that others don't have to dig through the repo for the answer

@minhtrancccp Good idea - I will try to implement some info into a panic message.


update channeldata separately or not at all

Could update all repodata and then update channeldata or not bother with channeldata

Thanks for the review!


[BUG] Wrong model index mapping

ML model index is using wrong mapping. Duplicate fields like content and model_content, and we are using content in code, but the type should be binary. This doesn't impact current REST APIs like search/get/delete model. But we should remove the duplicate fields and correct the data type.
{
  ".plugins-ml-model" : {
    "mappings" : {
      "properties" : {
        "algorithm" : {
          "type" : "keyword"
        },
        "content" : {
          "type" : "text",
          "fields" : {
            "keyword" : {
              "type" : "keyword",
              "ignore_above" : 256
            }
          }
        },
        "model_content" : {
          "type" : "binary"
        },
        "model_name" : {
          "type" : "keyword"
        },
        "model_version" : {
          "type" : "keyword"
        },
        "name" : {
          "type" : "text",
          "fields" : {
            "keyword" : {
              "type" : "keyword",
              "ignore_above" : 256
            }
          }
        },
        "task_id" : {
          "type" : "keyword"
        },
        "version" : {
          "type" : "long"
        }
      }
    }
  }
}

Will add schema version and correct index mapping in 2.0 GA.

Fixed in https://github.com/opensearch-project/ml-commons/pull/384