[BUG] Error after switch to release 0.2.0

Is there an existing issue for this?

[X] I have searched the existing issues

What version of Terraform are you using?
0.2.0-beta2
What type of issue are you facing
bug report
Describe the bug
Invoking the apply command on an existing subaccount created with the 0.1.0-beta1 version
I got the following error log
Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the plugin6.(*GRPCProvider).ReadResource call. The plugin logs may contain more details.
╵
╷
│ Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the plugin6.(*GRPCProvider).ReadResource call. The plugin logs may contain more details.
╵
╷
│ Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the plugin6.(*GRPCProvider).ReadResource call. The plugin logs may contain more details.
╵
╷
│ Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the plugin6.(*GRPCProvider).ReadResource call. The plugin logs may contain more details.
╵
╷
│ Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the plugin6.(*GRPCProvider).ReadResource call. The plugin logs may contain more details.
╵
╷
│ Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the plugin6.(*GRPCProvider).ReadResource call. The plugin logs may contain more details.
╵
╷
│ Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the plugin6.(*GRPCProvider).ReadResource call. The plugin logs may contain more details.
╵
╷
│ Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the plugin6.(*GRPCProvider).ReadResource call. The plugin logs may contain more details.
╵
╷
│ Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the plugin6.(*GRPCProvider).ReadResource call. The plugin logs may contain more details.
╵
╷
│ Error: Plugin did not respond
│
│ The plugin encountered an error, and failed to respond to the plugin6.(*GRPCProvider).ReadResource call. The plugin logs may contain more details.
╵

Stack trace from the terraform-provider-btp_v0.2.0-beta2 plugin:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xb07641]

goroutine 371 [running]:
github.com/SAP/terraform-provider-btp/internal/provider.(*subaccountEntitlementResource).Read(0xc0003f60d8, {0xe09d10, 0xc000495080}, {{{{0xe0e2d0, 0xc000545ce0}, {0xbd36a0, 0xc000545c20}}, {0xe10940, 0xc000177040}}, 0xc0003f60e8, ...}, ...)
        github.com/SAP/terraform-provider-btp/internal/provider/resource_subaccount_entitlement.go:154 +0x421
github.com/hashicorp/terraform-plugin-framework/internal/fwserver.(*Server).ReadResource(0xc0000c14a0, {0xe09d10, 0xc000495080}, 0xc000495140, 0xc00044b648)
        github.com/hashicorp/terraform-plugin-framework@v1.3.3/internal/fwserver/server_readresource.go:101 +0x677
github.com/hashicorp/terraform-plugin-framework/internal/proto6server.(*Server).ReadResource(0xc0000c14a0, {0xe09d10?, 0xc000494000?}, 0xc0008638c0)
        github.com/hashicorp/terraform-plugin-framework@v1.3.3/internal/proto6server/server_readresource.go:55 +0x41a
github.com/hashicorp/terraform-plugin-go/tfprotov6/tf6server.(*server).ReadResource(0xc0001b26e0, {0xe09d10?, 0xc0003fa720?}, 0xc00015b7a0)
        github.com/hashicorp/terraform-plugin-go@v0.18.0/tfprotov6/tf6server/server.go:749 +0x4b1
github.com/hashicorp/terraform-plugin-go/tfprotov6/internal/tfplugin6._Provider_ReadResource_Handler({0xc96b00?, 0xc0001b26e0}, {0xe09d10, 0xc0003fa720}, 0xc000126690, 0x0)
        github.com/hashicorp/terraform-plugin-go@v0.18.0/tfprotov6/internal/tfplugin6/tfplugin6_grpc.pb.go:386 +0x170
google.golang.org/grpc.(*Server).processUnaryRPC(0xc0001ae1e0, {0xe0ec78, 0xc0001bfd40}, 0xc0005b25a0, 0xc000314180, 0x12c7e90, 0x0)
        google.golang.org/grpc@v1.56.1/server.go:1337 +0xdf3
google.golang.org/grpc.(*Server).handleStream(0xc0001ae1e0, {0xe0ec78, 0xc0001bfd40}, 0xc0005b25a0, 0x0)
        google.golang.org/grpc@v1.56.1/server.go:1714 +0xa36
google.golang.org/grpc.(*Server).serveStreams.func1.1()
        google.golang.org/grpc@v1.56.1/server.go:959 +0x98
created by google.golang.org/grpc.(*Server).serveStreams.func1
        google.golang.org/grpc@v1.56.1/server.go:957 +0x18c

Error: The terraform-provider-btp_v0.2.0-beta2 plugin crashed!

This is always indicative of a bug within the plugin. It would be immensely
helpful if you could report the crash with the plugin's maintainers so that it
can be fixed. The output above should help diagnose the issue.

Expected Behavior
No response
Steps To Reproduce
No response
Add screenshots to help explain your problem
No response
Additional context
No response

@MatanElitzur Can you please add information on how to reproduce the error scenario:

What was your original setup with provider version 0.1.0?
What were the changes you made before the apply with version 0.2.0?

At best attach the Terraform configuration files you used (remove any sensitive information)

As @lechnerc77  already said, without knowing the exact environment it's pretty hard to reproduce. This is what I've just tried in live, with the latest provider version:
resource "btp_subaccount" "trial" {
  name      = "My Subaccount"
  subdomain = "my-trial-subdomain"
  region    = "us10"
}

resource "btp_subaccount_entitlement" "alert" {
  subaccount_id = btp_subaccount.trial.id
  service_name  = "alert-notification"
  plan_name     = "standard"
}

But it works.

provider.tf
terraform {
required_providers {
btp = {
source  = "SAP/btp"
#version = "0.1.0-beta1"
version = "0.2.0-beta2"
}
}
}
Configure the BTP Provider
provider "btp" {
https://registry.terraform.io/providers/SAP/btp/latest/docs
If you want to run in canary, you have to additionally specify the cli api url of canary 'cli_server_url',
it’s basically the same configuration you would expect for the btp cli
cli_server_url = "https://cpcli.cf.sap.hana.ondemand.com"
globalaccount = var.global_account
username = var.username
password = var.password
}
#######################################################################################
variables.tf
variable "emergency_admins" {
type        = list(string)
description = "Defines the colleagues who are added to each subaccount as emergency administrators."
default =<EMAIL_ADDRESS><EMAIL_ADDRESS>}

Entitlements

variable "entitlements" {
description = "List of entitlements for a BTP subaccount"
type = list(object({
group = string
type  = string
name = string
plan = string
amount = number
}))
default = [
{
group = "Object Store"
type  = "service"
name = "objectstore"
plan = "s3-standard"
amount = null # When you have a 1 shared units
},
{
group = "Application Logging Service"
type  = "service"
name = "application-logs"
plan = "standard"
amount = 3
},
{
group = "Cloud Foundry Runtime"
type  = "service"
name = "APPLICATION_RUNTIME"
plan = "MEMORY"
amount = 100 #To do change back to 300; 300 is the default
},
{
group = "auditlog"
type  = "service"
name = "auditlog"
plan = "standard"
amount = 10
},
{
group = "Cloud Management Service"
type  = "service"
name = "cis"
plan = "system-basic"
amount = null # When you have a 1 shared units
},
{
group = "Connectivity Service"
type  = "service"
name = "connectivity"
plan = "lite"
amount = null # When you have a 1 shared units
},
{
group = "SAP Content Agent Service"
type  = "service"
name = "content-agent"
plan = "application"
amount = null # When you have a 1 shared units
},
{
group = "SAP Content Agent Service"
type  = "service"
name = "content-agent"
plan = "standard"
amount = 1
},
{
group = "Credential Store"
type  = "service"
name = "credstore"
plan = "medium"
amount = 10
},
{
group = "Destination Service"
type  = "service"
name = "destination"
plan = "lite"
amount = null # When you have a 1 shared units
},
{
group = "Feature Flags"
type  = "service"
name = "feature-flags-dashboard"
plan = "dashboard"
amount = null # When you have a 1 shared units
},
{
group = "Feature Flags"
type  = "service"
name = "feature-flags"
plan = "standard"
amount = null # When you have a 1 shared units
},
{
group = "Feature Flags"
type  = "service"
name = "feature-flags"
plan = "lite"
amount = null # When you have a 1 shared units
},
{
group = "File System"
type  = "service"
name = "fs-storage"
plan = "custom"
amount = 10
},
{
group = "HTML5 Application Repository Service"
type  = "service"
name = "html5-apps-repo"
plan = "app-host"
amount = null # When you have a 1 shared units
},
{
group = "HTML5 Application Repository Service"
type  = "service"
name = "html5-apps-repo"
plan = "app-runtime"
amount = null # When you have a 1 shared units
},
{
group = "Cloud Identity Services"
type  = "service"
name = "identity"
plan = "application"
amount = 1
},
{
group = "Job Scheduling Service"
type  = "service"
name = "jobscheduler"
plan = "lite"
amount = 8
},
{
group = "Job Scheduling Service"
type  = "service"
name = "jobscheduler"
plan = "standard"
amount = 4
},
{
group = "SAP Malware Scanning Service"
type  = "service"
name = "malware-scanner"
plan = "clamav"
amount = null # When you have a 1 shared units
},
{
group = "Message Queuing"
type  = "service"
name = "message-queuing"
plan = "standard"
amount = 3
},
{
group = "Mobile Services"
type  = "service"
name = "mobile-services"
plan = "standard"
amount = 3
},
{
group = "Cloud Portal Service"
type  = "service"
name = "portal"
plan = "standard"
amount = 3
},
{
group = "PostgreSQL, hyperscaler option"
type  = "service"
name = "postgresql-db"
plan = "development"
amount = 3
},
{
group = "Redis, hyperscaler option"
type  = "service"
name = "redis-cache"
plan = "development"
amount = 3
},
{
group = "SaaS Provisioning Service"
type  = "service"
name = "saas-registry"
plan = "application"
amount = null # When you have a 1 shared units
},
{
group = "Service Manager"
type  = "service"
name = "service-manager"
plan = "service-operator-access"
amount = null # When you have a 1 shared units
},
{
group = "Service Manager"
type  = "service"
name = "service-manager"
plan = "ssubaccount-audit"
amount = null # When you have a 1 shared units
},
{
group = "Service Manager"
type  = "service"
name = "service-manager"
plan = "subaccount-admin"
amount = null # When you have a 1 shared units
},
{
group = "Service Manager"
type  = "service"
name = "service-manager"
plan = "container"
amount = 1
},
{
group = "Service Manager APIs"
type  = "service"
name = "service-manager-api"
plan = "subaccount-developer"
amount = null # When you have a 1 shared units
},
{
group = "Subscription Manager"
type  = "service"
name = "subscription-manager"
plan = "provider"
amount = null # When you have a 1 shared units
},
{
group = "UI Theme Designer"
type  = "service"
name = "theming"
plan = "standard"
amount = null # When you have a 1 shared units
},
{
group = "UI5 Flexibility Design and Configuration"
type  = "service"
name = "ui5-flexibility-design-and-configuration"
plan = "design-and-configuration"
amount = 3
},
{
group = "UI5 flexibility for key users"
type  = "service"
name = "ui5-flexibility-keyuser"
plan = "keyuser"
amount = 9
},
{
group = "UI5 Flexibility Personalization Service"
type  = "service"
name = "ui5-flexibility-personalization"
plan = "personalization"
amount = 5
},
{
group = "Workflow"
type  = "service"
name = "workflow"
plan = "standard"
amount = null # When you have a 1 shared units
},
{
group = "XFS Runtime"
type  = "service"
name = "xfs-runtime"
plan = "default"
amount = 3
},
# { We get xsuaa from the platform we don't need to config it
#   group = "Authorization and Trust Management Service"
#   type  = "service"
#   name = "xsuaa"
#   plan = "application"
#   amount = null # When you have a 1 shared units
# },
# { We get xsuaa from the platform we don't need to config it
#   group = "Authorization and Trust Management Service"
#   type  = "service"
#   name = "xsuaa"
#   plan = "broker"
#   amount = 1
# },
{
group = "Authorization and Trust Management Service"
type  = "service"
name = "xsuaa"
plan = "space"
amount = 1
},
{
group = "Authorization and Trust Management Service"
type  = "service"
name = "xsuaa"
plan = "apiaccess"
amount = null # When you have a 1 shared units
},
#### Need to check where it's come from
{
group = "Cloud Integration Automation Service"
type  = "service"
name = "cias"
plan = "standard"
amount = null # When you have a 1 shared units
},
{
group = "Cloud Integration Automation Service"
type  = "service"
name = "cias"
plan = "oauth2"
amount = null # When you have a 1 shared units
},
{
group = "Print Service"
type  = "service"
name = "print"
plan = "receiver"
amount = null # When you have a 1 shared units
},
{
group = "Master Data Integration"
type  = "service"
name = "one-mds"
plan = "sap-integration"
amount = 1
},
{
group = "Custom Domain Service"
type  = "service"
name = "INFRA"
plan = "custom_domains"
amount = 1
},
{
group = "SAP Build Work Zone, advanced edition"
type  = "service"
name = "build-workzone-advanced"
plan = "standard"
amount = null # When you have a 1 shared units
},
{
group = "SAP Build Work Zone, advanced edition"
type  = "service"
name = "SAPWorkZone"
plan = "standard"
amount = null # When you have a 1 shared units
},
{
group = "SAP Build Work Zone, standard edition"
type  = "service"
name = "SAPLaunchpad"
plan = "free"
amount = 1
},
{
group = "SAP Build Work Zone, standard edition"
type  = "service"
name = "SAPLaunchpad"
plan = "standard"
amount = 200
},
{
group = "Cloud Portal Service"
type  = "service"
name = "PortalApplication"
plan = "standard"
amount = 60
},
]
}

Possible values for entering the business unit

variable "unit" {
type        = string
description = "Defines to which organisation the sub account shall belong to."
default     = "Research"
validation {
condition = contains(concat(["Research", "Test", "Sales", "Purchase", "Production"]), var.unit)
error_message = "Please select a valid org name for the project account."
}
}

Sub account name of BTP sub account

variable "sub_account_name" {
type        = string
description = "The name of the subaccount."
default     = "Test sub domain"
}

Subdomain of BTP sub account

variable "sub_account_domain" {
type        = string
description = "The subdomain of the subaccount."
default     = "test-sub-domain"
}

Region of BTP sub account

variable "region" {
type        = string
description = "The region where the sub account shall be created in."
default     = "eu12"
}

Global account of BTP sub account

variable "global_account" {
type        = string
description = "The global account where the sub account shall be owned."
default     = "portal-devops-ci"
}

Username of BTP sub account

variable "username" {
type        = string
description = "The username for the login."
default     =<EMAIL_ADDRESS>}

Password of BTP sub account

variable "password" {
type        = string
description = "The password for the login username."
default     = <*********>
}
#########################################################################################
main.tf
locals {
#project_subaccount_name   = "${var.unit_shortname}${var.stage}"
#project_subaccount_domain = lower(replace("${local.project_subaccount_name}", "", "-"))
project_subaccount_cf_org = replace(join("", ["${var.unit}", "${var.sub_account_domain}"]), " ", "")
}
#Returns information about the logged-in user.
data "btp_whoami" "me" {}
# create a subaccount in eu12
resource "btp_subaccount" "test-sub-domain-resource" {
name      = "Test sub domain"
subdomain = "test-sub-domain"
region    = "eu12"
}
create a subaccount
resource "btp_subaccount" "project" {
name      = var.sub_account_name
subdomain = var.sub_account_domain
region    = var.region
}

Assignment of emergency admins to the sub account as sub account administrators

resource "btp_subaccount_role_collection_assignment" "subaccount_users" {
for_each = toset("${var.emergency_admins}")
subaccount_id        = btp_subaccount.project.id
role_collection_name = "Subaccount Administrator"
user_name     = each.value
}
resource "btp_subaccount_trust_configuration" "fully_customized" {
subaccount_id     = btp_subaccount.project.id
identity_provider = var.custom_idp
}

Creation of Cloud Foundry environment

module "cloudfoundry_environment" {
source = "github.com/SAP-samples/btp-terraform-samples/released/modules/envinstance-cloudfoundry/"
subaccount_id         = btp_subaccount.project.id
instance_name         = local.project_subaccount_cf_org
cloudfoundry_org_name = local.project_subaccount_cf_org
}

Add entitlements

resource "btp_subaccount_entitlement" "entitlements" {
for_each   = {
for index, entitlement in var.entitlements:
index => entitlement
}
subaccount_id = btp_subaccount.project.id
service_name  = each.value.name
plan_name     = each.value.plan
amount        = each.value.amount #Matan added
}

Ok, from your script I can see you're using canary. But even there I'm unfortunate not able to reproduce this issue, I can just guess. It could have sth to do with the way how you iterate over the entitlements to be setup. You don't want to use the index as resource identifier here, since its way to unstable. Everytime you add a new entitlement to the list, it potentially impacts all the other entitlements. Instead either go with individual btp_subaccount_entitlement resources, or use the service_name and plan_name as combined key like this:
resource "btp_subaccount_entitlement" "entitlements" {
  for_each   = {
    for index, entitlement in var.entitlements:
    "${entitlement.name}:${entitlement.plan}" => entitlement
  }

  subaccount_id = btp_subaccount.trial.id
  service_name  = each.value.name
  plan_name     = each.value.plan
  amount        = each.value.amount #Matan added
}


BUG: Extra email input area in home page footer

Is there an existing issue for this?

[X] I have searched the existing issues

What happened?
There's an extra input area for entering email address in home page's footer.
Attaching screenshot for reference:

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Hey @anuragverma108  Please assign me this issue

I have done the change and review my code


Cannot access Composer / PHP installed in Windows from WSL - Ubuntu

Microsoft Windows [Version 10.0.17134.706]
I was trying to access composer installed on Windows 10 using WSL - Ubuntu.

Should be showing,
C:\Users\Jojero>composer --version
Composer version 1.8.5 2019-04-09 17:46:47

Strace result:
jojero@xmarkdspai-pc:/mnt/c/Programs/xampp/php$ strace -o"composer --version".strace -f "composer --version"
strace: Can't stat 'composer --version': No such file or directory

Please help, thanks!

You've got composer in your Windows %PATH%. Do:
$ export PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
$ composer

If composer isn't installed in your WSL distribution, install it.

Can't I use the composer installed in Windows 10 from Ubuntu command lines?

Can't I use the composer installed in Windows 10 from Ubuntu command lines?

That might be possible, to the extent doing so makes sense. Shorter answer would be 'no', given that you got an error when you tried.
Once you've typed composer at the Ubuntu /bin/bash commandline prompt, WSL has handed over execution to the Windows composer app. That ran. But Windows composer isn't happy (apparently) because it can't find Windows php. WSL has no idea why Windows composer can't find Windows php. WSL doesn't even know Windows composer is looking for Windows php.
Someone in a Composer forum might be able to tell you how to coerce Windows Composer into finding Windows PHP in the scenario. Might be as simple as setting up a Windows system (global) path or environment variable. It might not be as simple.
But that is probably not the route you want. Absent knowing what you are trying to achieve inside Linux Ubuntu, you probably want a Windows implementation of bash, to go with your Windows version of Composer and your Windows version of PHP.

I found a solution, I added an alias for composer then it points like this php.exe [composer file bin location]. It works but the problem is the PATH in Windows 10 blocking the composer alias so I change the reg key of wsl flags to 5. And now it won't import all of the PATH on windows then I create a .bash_paths imported in my .bashrc which I can add paths one by one the way I want it to be. The problem is I don't know how to use the export [...].

Hi! I manage to make it work now! Thank you so much also about the export through command line, I got run problem where I can't use cat, vim, ls.
jojero@xmarkdspai-pc:~$ php.exe --version
PHP 7.3.4 (cli) (built: Apr  2 2019 21:56:52) ( ZTS MSVC15 (Visual C++ 2017) x64 )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.3.4, Copyright (c) 1998-2018 Zend Technologies
jojero@xmarkdspai-pc:~$ composer --version
Composer version 1.8.5 2019-04-09 17:46:47

Glad you got it working and appreciate the follow up. Makes a good search target. You can tell WSL to not import Windows paths with appendWindowsPath=false in wsl.conf on Win10 1809 aka 17763 or better (I think it was 1809). You might want to add back some Windows paths judiciously to your .bash_paths so you don't lose stuff like the path to cmd.exe. But only if you want.

Yes I added some paths too I was so happy I don't have to use docker / vagrant or even move to Linux. Now I can even change php.exe to php just by using alias. But I will make it just like that I just need composer by now.
I added the following paths in .bash_paths,
export PATH="$PATH:/mnt/c/Windows"
export PATH="$PATH:/mnt/c/Windows/System32"
export PATH="$PATH:/mnt/c/Windows/System32/wbem"
export PATH="$PATH:/mnt/c/Programs/Microsoft VS Code/bin"
VS Code has it's on cli.js for that so I can use code inside the WSL anytime I want.

Hi! @therealkenc, I found out about WSL2, will I able to run it on Windows 10 Home?

@joshuadabejero - yes

Even I have no Hyper v? It will work?

@therealkenc I'm planing to create a GUI Application which create an extension for .bash_paths and .bash_aliases inside windows so the  change for the path is in easiest way.

inside windows so the change for the path is in easiest way

You could, but it wouldn't be an approach I'd recommend personally, absent an explanation for the root cause of the "php: not found". It isn't clear (to me, atm) why pruning your path works around the problem; just that it does. It is institutionalization of a work around. But to be clear I could be easily be convinced otherwise given an explanation for why php isn't being found by Windows composer (an "ah, I see" moment), and absent a better solution than diddling the paths manually (easily or otherwise). But since I don't have this particular itch to scratch I haven't looked into why you got the original error.
Not to imply discouragement. If folks find your GUI useful, even better.
Since I'm here....

Even I have no Hyper v?

Yes. You actually already have most of the Windows virtualization infrastructure on your Windows Home right now. You just don't have a MSFT branded UX (Windows Hyper-V Manager) to do anything visible with it on Home Edition.


logging setup

How to setup logging for the service and all its dependancies?

If you use nameko run on the command line you can specify dictConfig style logging in your configuration file.
See http://nameko.readthedocs.io/en/stable/cli.html?highlight=logging#running-a-service

This issue was moved to https://discourse.nameko.io/t/logging-setup/290


Add shader registry

This PR adds the initial foundation for a runtime shader registry. The registry is implemented side-by-side with the existing mbgl::Programs object in gfx::RenderStaticData and exposed to layer renderers in the same way via PaintParameters. Additionally, the ability to re-write shader source has been introduced via a new method in ProgramParameters. A new map observer event has been added to notify users after shader initialization to permit mutation of the registry.
In following PRs:

Built-in programs will be installed in the registry via the new stub method Programs::registerWith
Shader source for each program will be lifted out of the compressed, code generated blob
With the implementation of drawables & builders, outright replacement of programs in the registry will then become practical

These changes were tested using the desktop GLFW platform application under MSVC.

Could you add a few tests?

I've added a few tests and revised the base shader & registry to function without requiring RTTI. Vertex and fragment source are the only directly un-tested feature however there is coverage in some of the existing tests. Currently that functionality is private to the core, I'll have some more changes for it in following PRs.


Update osu nuget packages

Note that lazer taiko scores' PP values will differ from what's expected by the deployed version of osu-performance due to https://github.com/ppy/osu/pull/20558, but this isn't a huge deal for now I think?
I'm just doing this to remove the rounding that breaks compilation.

This one might be broken. Seems like taiko ruleset failed to deploy last time: https://ci.appveyor.com/project/peppy/osu-ehtfo/build/job/jfh18sekt29kqor7


Will mol cell

Also please push to development in the future. Then we can mass push multiple commits into master in an update every sprint or month.


Implemented logic for createInventory

Description
Add support for other create inventory.
Checklist
The following items should be checked before the pull request can be merged.

[X] Code follows existing style.
[X] Unit tests added (if applicable).

Thank for your feedback @ens-gijs. I have worked on the points you have mentioned.


Add rough outline of implementaion walkthrough (Mark/Unmark Tasks)

Mark / Unmark feature

Codecov Report

Merging #131 (1447de9) into master (cb3c4a3) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #131   +/-   ##
=========================================
  Coverage     71.02%   71.02%
  Complexity      603      603
=========================================
  Files           101      101
  Lines          2043     2043
  Branches        234      234
=========================================
  Hits           1451     1451
  Misses          511      511
  Partials         81       81

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[Reference TOC] fixed Azure service names

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

This PR is for reference TOC updates to enforce Azure service organization regardless of how a reference is used inside a service:

combined two separate Azure Bot nodes
combined three separate AKS nodes
combined two separate Azure Stack nodes
combined two separate Azure Arc nodes
combined two separate Azure Data Explorer nodes and removed (Kusto) suffix as ADE isn't just about Kusto

@yonzhan , this PR is ready for engineering review.

Reference TOC

@yonzhan , This is just a friendly note that the related PR in Azure/azure-cli has been merged while this one remains open.


da.sum with axis bug

Here's a reproducible example.
I create a dask array with shape (45,), but for some reason when I call compute() on that array, I end up with a scalar.

My bad, I forgot to introduce a new axis into the output of the mapper function. Changing to:
def numpy_pairwise_distance(x, metric, **kwargs):
    # N.B., need to introduce a new axis to allow for mapping blocks.
    return spd.pdist(x.T, metric=metric, **kwargs)[None, :]

...fixes this.


Fix image path conflicts between different consumers

When $path is always set it breaks image urls in consumers expecting
image-url to work, eg, rails.
Refactor the $path detection logic to work with all our use cases

Fractal (gets $default-image-path
Rails apps (uses image-url)
Node apps (continue setting their own $path before importing govuk-frontend
SCSS into their own main stylesheet - or using default compiled CSS file
and using the same static asset structure as the default path)
Static apps (continue using compiled CSS, assuming the asset structure matches)

Cleanup:

Move image logic out of govuk-frontend.scss, as the main entry point
to our SCSS simpler is better.
Put all the "which image method to use" logic in one place, the mixin, and
treat everything else as configuration, i think thats more readable.
Move the default image path into a variable and into settings, feels better.

What does it do?
Fixes the default styling of the Rails app, so that images linked from govuk-frontend.scss follow the rails asset path conventions. Without breaking image paths in our other apps.

Bug fix (non-breaking change which fixes an issue)

This works for me, however, expecting consuming Node apps to use the same static asset structure as the default path is a little restrictive (and will result in the simplest "getting started" path - using the default compiled stylesheet - to have broken paths to images).
These static assets can be served from the node_modules directory, so I've added this as a workaround for the time being:
app.use('/images/template', express.static(path.join(__dirname, '/node_modules/govuk_frontend_alpha/assets/images/template/')))

Also worth mentioning that this was also true before this PR (when $path was defined at the top of _govuk-frontend.css) and doesn't in any way hold this up.
Revert
View details

Yep - thats what i was describing, somewhat badly :)


Controller has problematic functionality with managing suspended instances

Bug Report
System Information

Operating System (Including distribution name and version number) Ubuntu 20.04.5 LTS
AMP version and build date (Always use the version number, 'latest' is not valid!) <IP_ADDRESS>
Which AMP release stream you're using (Mainline, Nightly or FastTrack) Mainline

I confirm:

[x] that I have searched for an existing bug report for this issue.
[x] that I am using the latest available version of AMP.
[x] that my operating system is up-to-date.

Symptoms

What are you trying to do? Manage suspended instance from controller
What are you expecting to happen? Either A) show instance is suspended, but allow admin to manage it (client cannot)
What is actually happening? ('Nothing' is not an acceptable answer!) Instance shows as Running with a grey background - does not say suspended. This is reflected in WHMCS where it just says Running.

Reproduction

Suspend an instance
Look at it in the controller
Attempt to manage it

What I'm doing for this is adding a special "Manage suspended instances" permission.

This has been implemented in CI. Suspended instances can be accessed by admins with the Manage Suspended Instances permission, but not by regular users.


Make footnotes referenceable

Fixes #1543
Implementation
To make sure references to footnotes point to the footnote entry instead of the footnote itself, I added a destination method to Refable that lets you overwrite the destination of the reference.
I also applied the same "attaches itself to the preceding word" treatment to footnote labels, but I'm not sure to what extent footnote labels should behave in the same way as regular footnotes.
Known issues
There are two issues that I am aware of as of right now.

Clicking on the number before the footnote entry always leads back to the place where the footnote is declared, instead of where the user comes from.

Since references to footnotes are not footnotes themselves, show rules for footnotes will not apply to footnote labels:
#show footnote: set text(red)
A real footnote #footnote[Hi]<fn> \
And a reference to a footnote @fn

becomes

The first one is basically impossible to fix.
I don't know if the second one is a real issue.

Nice job, thanks!

2. Since references to footnotes are not footnotes themselves, `show` rules for footnotes will not apply to footnote labels

Perhaps the best way to fix this could be, instead of simply overriding the ref's destination, to implement an automatic conversion of refs to footnote elements when footnote labels are specified, similarly to how refs are converted to cites for bibliography?

The problem with this approach is that creating a new footnote also creates a corresponding entry:

I don't think there is a way to create a footnote element without it having an associated entry.

I don't think there is a way to create a footnote element without it having an associated entry.

There is no way currently, but there should certainly be a way to do it through this PR, maybe through some property or field. @laurmaedje thoughts?

I agree with @PgBiel that this should somehow create a footnote to which show rules can apply. The footnote could just have a field with the label/location, instructing it to be a re-footnote.

Done! The body of a footnote can now either be actual content, just like before, or the label of another footnote.

Awesome job, thanks!

Marking the pull request as a draft until I fix all that

I think labels will be presented as value arguments for footnote in the documentation, but this features does not actually work. This should not be merged until the issue is fixed.

So footnote now also accepts a label as its body, which is equivalent to referencing a footnote directly:
#footnote[This is a footnote] <fn> \
A reference to it: @fn \
Another reference to it: #footnote(<fn>)

Thank you!


INVALID_APP_CREDENTIAL:App validation failed

I cloned the firebase quickstart project, but get this error:
com.google.firebase.quickstart.auth W/PhoneAuthActivity: onVerificationFailed
com.google.firebase.FirebaseException: An internal error has occurred. [ INVALID_APP_CREDENTIAL:App validation failed ]
Firebase console: Authentication - Sign-in Method - Phone - enabled
and I downloaded the generated google-services.json file, and copied it to the app/ directory

@amicwall this almost always occurs when your SHA1 is not set properly in the Firebase console.  Please double-check.

yes that was the problem


Eliminate server restarts during tests if not needed to speedup the test runs

Speeds up the test runs by eliminating the server restarts during the each test case.

Test FAILed.

verify

Test FAILed.

Test PASSed.

Test FAILed.

Test FAILed.

Test PASSed.


Kube config filter by token

adds --filter-by-token option to kube config command
renames --filter-prompts option in aws login to --filter-by-token for consistency

Tested stim kube config with every permutation of providing 1, 2 or 3 of --cf, --saf and --filter-by-token.

fixes an edge case in vault.Filter

Vault's CapabilitiesSelf returns a "path" called capabilities when
it receives only a single path in its request.  Presumably this is for
backward compatibility.  It also returns the path with its capabilities,
as it would when it returns a list of paths with their capabilities,
which is what consumers of vault.Filter expect.
So we just throw away the capabilities "path".  Otherwise users would
see a dummy capabilities role along with the single expected role on
aws login with --filter-by-token when the aws account only has a
single role defined, or if their service account filter via --saf
narrowed the set of possible roles down to 1.

I believe 26d3c76 addresses all of your stated concerns.


jenkins in docker container

what is the benefits of running jenkins in docker container?

There are many reasons i can think of, but in my case we are building several jenkins environments.
eg. one for our Java devs, one (maybe even two) for Python devs.
Using Docker we can pull the jenkins official image, and then make changes for our 'base' jenkins.
Then we can allow users to pull down a copy of that base image with plugins installed and configurations made depending on the requirement (Java, Python, Other).
All of this can be done by just creating derived dockerfiles for each environment. So the image that users will build is only a few steps ontop of the existing 'in-house base image', which in turn pulls from the official jenkins image.

I really like the concept of readily duplicated personal continuous integration machines as described by @snayler0.
I use Jenkins in a docker container to speed the setup and teardown of different Jenkins configurations for testing of Jenkins plugins.  The Jenkins git client plugin and the Jenkins git plugin need to run well on many different platforms and many different git versions.  A docker container makes it much easier to assemble and disassemble different Linux platforms (CentOS 5, 6, 7, Debian 6, 7, 8, Ubuntu 12.04, 14.04, 15.04) with their matching git versions.


[HBO] HBO extractor broken after site redesign

[x] I've verified and I assure that I'm running youtube-dl 2017.10.29
[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[x] Bug report (encountered problems with youtube-dl)
[x] Site support request (request for adding support for a new site)

Description of your issue, suggested solution and other information
HBO has completely redesigned their website and updated URL's etc, which had the unfortunate side effect of breaking the existing youtube-dl hbo extractor. From what I can gather they have switched from using video ID's to video paths instead. The same information as before is still accessible, just at different URL's.
Here is the video page: https://www.hbo.com/video/curb-your-enthusiasm/seasons/season-09/episodes/5-thank-you-for-your-service/videos/s9-ep-5-preview
And here is the XML file (found via View Page Source): https://www.hbo.com/services/hbo/video.xml/vpath=/content/hbodata/en/series/curb-your-enthusiasm/seasons/season-09/episodes/5-thank-you-for-your-service/videos/s9-ep-5-preview.xml
Another example:
Video Page: https://www.hbo.com/video/game-of-thrones/seasons/season-07/episodes/6-beyond-the-wall/videos/s7-ep-6-beyond-the-wall-preview
XML file: https://www.hbo.com/services/hbo/video.xml/vpath=/content/hbodata/en/series/game-of-thrones/seasons/season-07/episodes/6-beyond-the-wall/videos/s7-ep-6-beyond-the-wall-preview.xml
(Note: many of their videos now open in "popup" / lightbox type windows now, but to get these video page URL's you can simply click on "Copy Link" or "Email" in the top right of their video player.)

Essentially to get the XML file you replace the "https://www.hbo.com/video/" portion of the URL with "https://www.hbo.com/services/hbo/video.xml/vpath=/content/hbodata/en/series/" , keep the rest of the URL the same, and then add ".xml" to the end of that.
There might be a better way to do this.
And since this is somewhat related, thought it was worth mentioning #13709 which was a request for adding subtitles support (subtitles are in these same XML files).

Your proposal works only with content from the series section. If you consider content from the movie or specials section the metadata request goes to:

Specials: https://www.hbo.com/services/hbo/video.xml/vpath=/content/hbodata/en/specials/
Movies: https://www.hbo.com/services/hbo/video.xml/vpath=/content/hbodata/en/movies/

Movies example:

Movie URL: https://www.hbo.com/video/movies/split/videos/trailer
Meta URL: https://www.hbo.com/services/hbo/video.xml/vpath=/content/hbodata/en/movies/split/videos/trailer.xml

Specials example:

Special URL: https://www.hbo.com/video/specials/night-of-too-many-stars/videos/trailer
Meta URL: https://www.hbo.com/services/hbo/video.xml/vpath=/content/hbodata/en/specials/night-of-too-many-stars/videos/trailer.xml


Profile.balance always return zero

Profile.balance always return zero

You can use to get it:
var balances = await _client.WsClient.GetBalancesAsync(requestId, null);


Add conditional get middleware

Coverage remained the same at 100.0% when pulling dbc737d23467076b0dc18c4fb6488fc8069bf4cc on add-conditional-get into 8e661e8c3f670abc50e914d6c22023466419f796 on master.

Coverage remained the same at 100.0% when pulling e38fd6b03e310ee9b430fece78d0e92d4008b5cc on add-conditional-get into 8e661e8c3f670abc50e914d6c22023466419f796 on master.


What if there are arbitrary items in POST Data?(question)

What if there are arbitrary items in POST Data?
In Python there is no “undefined” in javascript. So, if I want to manipulate the existence of a property, I have no choice but to pass a dict to POST.
But I want to use dataclass so that I can write programs with no documentation and only intellisense.
Is there a special variable or other solution that would prevent me from including that property in the data I post?
Translated with DeepL.com (free version)
@dataclass
class PostBody():
    required_property: str
    optional_property: str = UNDEFINED

class MyClient(RequestsClient):
    def __init__(): ...

    @post("/api/path")
    def post_api_path(self, body: PostBody) -> ResponceDataclass:
        pass

client = MyClient()
res = client.post_api_path(PostBody("foooo"))
# Posted Body: {"required_property": "foooo"}

One of the options is using TypedDict, it is like dict, but IDE will recognize supported keys.
But probably you are looking for skipping keys with default values during serialization.
Here is such an option: https://adaptix.readthedocs.io/en/latest/loading-and-dumping/extended-usage.html#omit-default
To apply that you need to override _init_request_body_factory in your Client class. It whould be something like:
class MyClient(RequestsClient):
    ...

    def _init_request_body_factory(self) -> Retort:
        return Retort(
            recipe=[
                name_mapping(PostBody, omit_default=True),
            ],
        )


Refactor Code to use Boost instead of CXX

Refactored code to use Boost Test instead to fix compilation issues for timer test.

What's the relationship between these changes and #2478? @hoytak
Any reason not just to change the definition of the macro, instead of the call sites?

What's the relationship between these changes and #2478? @hoytak
Any reason not just to change the definition of the macro, instead of the call sites?

Genius. Yeah.


After cloning and building the project

Describe the bug
I went to the repo and clone it in Visual Studio 2019, and after building i found the following error;
Severity	Code	Description	Project	File	Line	Suppression State
Error	NETSDK1004	Assets file 'C:\Repos\Training\BlazorHero - Clean Architecture Template\BlazorHero.CleanArchitecture\Server\obj\project.assets.json' not found. Run a NuGet package restore to generate this file.	BlazorHero.CleanArchitecture.Server	C:\Program Files\dotnet\sdk\5.0.201\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets	241
To Reproduce
Steps to reproduce the behavior:

Go to repo
Clone the repo on Visual Studio 2019
See error

Expected behavior
The solution build without issues
Screenshots

Desktop (please complete the following information):

OS: Windows 10
Visual Studio 2019 Community Edition
Version 16.9.2

Additional context
I tried to do a dotnet restore in the project and found the following error:
dotnet restore
Determining projects to restore...
C:\Program Files\dotnet\sdk\5.0.201\NuGet.targets(131,5): error : Found invalid data while decoding. [C:\Repos\Training\BlazorHero - Clean Architecture Template\BlazorHero.CleanArchitecture\Server\BlazorHero.CleanArchitecture.Server.csproj]

try opening a PowerShell session an run
dotnet --info

It may shed some light on what you have running for .net


Implement required code checks

Added required code checks. They are set in the configuration and run only when the regular code checks run (they don't run in exam mode).
If one or more required checks fail, the grade is overridden to 0.
They can be configured as follows:
@Override
public CheckScript requiredCheckScript() {
    return new CheckScript(List.of(
            new SingleCheck("Trip Repository should be mocked", new MockClass("TripRepository"))
    ));
}

Closes #121

Should there be code checks that deduct from the final grade, or is it sufficient to simply fail the execution if any of the checks marked as required fail? (If they pass, they are not considered in the calculation of the final grade.)
Also, should required code checks run in exam mode to let students know their code will receive a 0 if they don't fix it? If so, should it only tell them something like "3/5 required checks passed, stopping execution" in exam mode, or should it tell them exactly what is wrong (e.g. "you do not have any property-based tests" or "you have used example-based tests in your code, please remove them")? I guess this depends on what exactly they will be used for. Perhaps there could be a toggle for that in the RunConfiguration.
@mauricioaniche What do you think?

@mauricioaniche This PR is a simplified version of the original idea of code checks that subtract from the final grade. It adds required code checks which must all pass in order for the exercise to be graded at all; if any of them fails, the final grade is 0.
Would it be useful to implement an option to subtract from the final grade instead of simply overriding the grade to 0, or does the current implementation cover all cases where this may be used in grading?

I’d say just the one to zero out the full grade is enough!
On Mon, 10 Oct 2022 at 21:15, Martin Mladenov @.***>
wrote:

@mauricioaniche https://github.com/mauricioaniche This PR is a
simplified version of the original idea of code checks that subtract from
the final grade. It adds required code checks which must all pass in order
for the exercise to be graded at all; if any of them fails, the final grade
is 0.
Would it be useful to implement an option to subtract from the final grade
instead of simply overriding the grade to 0, or does the current
implementation cover all cases where this may be used in grading?
—
Reply to this email directly, view it on GitHub
https://github.com/cse1110/andy/pull/131#issuecomment-1273713376, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAYTTAJYEMNT2WZHMBW2ELWCRTLTANCNFSM6AAAAAAQPMAXF4
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Maurício Aniche
Tech Academy Lead at Adyen
Assistant Professor in Software Engineering at TU Delft
Author of Effective Software Testing: A Developer's Guide
https://www.effective-software-testing.com
https://www.mauricioaniche.com

@mauricioaniche

I’d say just the one to zero out the full grade is enough!

OK, I'll do that.
Should required code checks also run in exam mode? Perhaps this might be a useful way to tell students e.g. "Don't use example-based tests in the PBT exercise on the exam"? Or maybe it should be configurable?

No need to run in exam mode. Students should know what to do based on the
description only! No need for hints!
On Mon, 10 Oct 2022 at 21:41, Martin Mladenov @.***>
wrote:

@mauricioaniche https://github.com/mauricioaniche
I’d say just the one to zero out the full grade is enough!
OK, I'll do that.
Should required code checks also run in exam mode? Perhaps this might be a
useful way to tell students e.g. "Don't use example-based tests in the PBT
exercise on the exam"? Or maybe it should be configurable?
—
Reply to this email directly, view it on GitHub
https://github.com/cse1110/andy/pull/131#issuecomment-1273735683, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAYTTFSRSO7OUPQWOOPJRDWCRWPBANCNFSM6AAAAAAQPMAXF4
.
You are receiving this because you were mentioned.Message ID:
@.***>

--
Maurício Aniche
Tech Academy Lead at Adyen
Assistant Professor in Software Engineering at TU Delft
Author of Effective Software Testing: A Developer's Guide
https://www.effective-software-testing.com
https://www.mauricioaniche.com


Unable to register SecretStore without supplying a password

I'm having trouble figuring out how to register the SecretStore without a password from the beginning. AKA, you never have to provide a password at all. I can't tell if I'm doing something wrong, misunderstanding how it works, or if this is a bug?
Here's what I'm trying:
Install the modules:
Install-Module Microsoft.PowerShell.SecretManagement, Microsoft.PowerShell.SecretStore

Register a new SecretVault using the SecretStore module as the default:
Register-SecretVault -Name SecretStore -ModuleName Microsoft.PowerShell.SecretStore -DefaultVault

Now here is where I run into issues...

Performing the operation "Changes local store configuration" on target "SecretStore module local store".
[Y] Yes  [A] Yes to All  [N] No  [L] No to All  [S] Suspend  [?] Help (default is "Y"): Y
Vault Microsoft.PowerShell.SecretStore requires a password.
Enter password:
****
A password is no longer required for the local store configuration.
To complete the change please provide the current password.
Enter password:
****
PS C:\>

I can't tell if I'm doing something wrong? It doesn't make sense for it to ask me for a password if I say it doesn't need one, and then ask me to provide the same password to remove it.
If it's not a bug, then the only thing I can think of is that it's still using the password behind the scenes for the encryption/decryption process, and the setting Authentication is more about usage of the vault, but the password itself is still used for encryption/decryption.

I also tried passing in default registration parameters to Register-SecretVault like this:
-VaultParameters @{Authentication='None'; Interaction='None'}

And it still required a password, in fact, it didn't even apply the settings after registration, it seems to ignore them completely:
PS C:\> Register-SecretVault -ModuleName Microsoft.PowerShell.SecretStore -Name SecretStore `
            -VaultParameters @{Authentication='None'; Interaction='None'} -DefaultVault
PS C:\> Set-Secret -Name Testing -Secret 'Testing123'
Creating a new SecretStore vault. A password is required by the current store configuration.
  SecretStore needs a configuration when loaded and it will default to the interactive password required configuration by default.
You can avoid this by running Set-SecretStoreConfiguration first thing after installing the module (before you register SecretStore as an extension vault).
Alternatively, you can also use the Reset-SecretStore to force set the configuration.  This causes any secret data to be deleted, but since you haven't yet added any secret data, it should be Ok to use.
PS C:\> Register-SecretVault -ModuleName Microsoft.PowerShell.SecretStore -Name SecretStore `
            -VaultParameters @{Authentication='None'; Interaction='None'} -DefaultVault

PS C:\> Reset-SecretStore -Authentication None -Interaction None -Force
WARNING: !!This operation completely removes all SecretStore module secrets and resets configuration settings to new values!!

PS C:\> Set-Secret -Name Testing -Secret 'Testing123'

PS C:\> Get-SecretInfo

Name    Type   VaultName
----    ----   ---------
Testing String SecretStore

PS C:\> Get-Secret -Name Testing -AsPlainText
Testing123

@PaulHigin, thanks! that appears to work for me.
I would think that when the vault is initially configured it would splat the parameters from -VaultParameters and use those as the new defaults. It seems odd that in your example, the "Authentication" and "Interaction" parameters are specified twice.

Whoops, I just copied/pasted.  There is no need to pass Authentication/Interaction as vault parameters, as SecretStore does not currently handle them.

@PaulHigin Ah! Okay, that completely clears that up then. Thanks! I guess since this isn't a bug, and it's intentional (though I'd admit a bit of an odd workflow) I'll close with comment. Thanks!


move from Travis to GitHub actions

because Travis 😢
I wanted to come in and do a few upgrades but I didn't want to do anything without tests running on PRs 🙈

You won't see the Github Actions run here because I'm not a contributor, but you can see the results over here https://github.com/mansona/ember-cli-showdown/pull/1
floating dependencies and canary are failing but that shouldn't stop you from merging 👍  unfortunately GitHub actions doesn't support "allowed failures" yet 😞


docs: fix typo (2x "the")

Nit-pick 🤓🔎: remove one the :innocent:.

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Snapshot stored with reference name:
refs/pull/14304/merge
Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14304/merge/index.html
To test a playground add it to the URL, for example:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14304/merge/index.html#WGZLGJ#4600
Links to test babylon tools with this snapshot:
https://playground.babylonjs.com/?snapshot=refs/pull/14304/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14304/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14304/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14304/merge
To test the snapshot in the playground with a playground ID add it after the snapshot query string:
https://playground.babylonjs.com/?snapshot=refs/pull/14304/merge#BCU1XR#0


Unable to close maximized mondrian example

Clicking on the + button to maximize the diagram makes it full screen, but there is no intuitive way to exit from this image. The only option being closing the image.

We replaced these with examples that are not maximizable.


Add feature to override language through configurations

Since the language property on TINYMCE_DEFAULT_CONFIG was never being used and was always being overwritten by Django's LANGUAGE_CODE, I've also updated get_language_config() to take into consideration TINYMCE_DEFAULT_CONFIG.language with a higher priority than LANGUAGE_CODE.
This way, if an user is not satisfied with the automatic language selection from Django's Settings, he can always update the language property on TINYMCE_DEFAULT_CONFIG to change language configurations, which was not possible before.
Tests and Docs updated accordingly.

Here would be my version of the patch: #297. I would be interested to know your opinion on it!

Superseeded by #297 (I missed @claudep message, if you have any comment feel free to give them and we can still take them into account.)


Push autobuilds to a nuget feed?

Is there a feed for the auto-builds?  I know there used to be something in myGet, however it looks like that is starting to get stale (hasn't be updated in the last 10 builds I think)

If by 'auto-builds' you're referring to our CI build of master, yes, I push to this feed periodically:
https://www.myget.org/F/aarnott/api/v3/index.json
The last one package pushed is fairly current, I think.

The last version on that link is .48 and the CI build is .58.

Ah, but if you look at all the changes between 48 and 58, they're all build infrastructural or having to do with the MSI. It's not about additional functionality to the NuGet packages at all.

Ok, that's good enough for me :)  It just looked like things were out of sync since I have seen a lot of changes around VS 15.


Adding PPID in tracepoint based gadgets

Current situation
ppid field missing in some the tracers.
Impact
Ideal future situation
Include the ppid in the event data.
Implementation options
Slack discussion with guidance
Additional information
[ Please Add any information that does not fit into any of the above sections here ]

keep

We'll track this on #1567


add stepper component

We are adding the <Stepper> component.

⚠ We are not following the exact design for that, for now.

Hey mario I have two questions :

Is it possible to set the steps text under the icon like in design ?
Right now on storybook it's static but I see that you have written functions, will the step progression be implemented next ?

My bad to no mention in the description:

Is it possible to set the steps text under the icon like in design ?
No, this will be a second version because it demands more time to finish. I have a previous version already done. But in future we update that.

Right now on storybook it's static but I see that you have written functions, will the step progression be implemented next
Sure!


Additional arpeggiator modes

I just played a show where I relied heavily on the arpeggiator and I found myself really wishing for an Up Down mode that went:
1 3 5 | 1 3 5 | 1 3 5 | 1 3 5 | 5 3 1 | 5 3 1 | 5 3 1 | 5 3 1
oct1   | oct2 | oct3  | oct4 | oct4  | oct3 | oct2 | oct 1
and, conversely, a Down Up mode that went:
5 3 1 | 5 3 1 | 5 3 1 | 5 3 1 | 1 3 5 | 1 3 5 | 1 3 5 | 1 3 5
oct4  | oct3 |  oct2 | oct1  |  oct1  | oct2 | oct3  | oct4
(sorry for the lousy ascii artwork!)

Changed Octaves parameter to allow for Off, Up 1-5, Up Down 1-5, Down 1-5 and Down Up 1-5. When moving down octaves, the note order is reversed. This basically allows to do what you suggested and a bit more. Note however that the sequence is always started at octave 0. So your second example would start at octave 0 and move down to octave -3. But this is more natural as you expect the sequence to start from where you play on the keyboard.
Will be part of the 0.1.30 release.

Just wanted to let you know that I had a ton of fun playing with the new arp modes tonight! They sound incredible!!!


Add min token out for Balancer Pool <> CL Pool Migrations

Closes: https://github.com/osmosis-labs/osmosis/issues/4539
What is the purpose of the change
The current migration logic between Balancer Pool and CL Pool had issues with trying to migrate small gamm shares, since the migration logic was consisted of 1) exit pool 2) use the coins resulted from (1) to create position, while exit pool using dust shares would leave the user to leave pool without any coins. In this case the method would attempt to join pool with 0 coins, resulting the method to error.
This PR tries to solve this problem by adding min token out field in the msg field for the migration message and the method itself.
With the min token out, each position in existing Balancer Pool are given freedom to exit pool with the amount they are intending to have.
Brief Changelog

Add min token out for Balancer Pool <> CL Pool Migrations

Testing and Verifying
Add test cases.
Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
How is the feature or change documented? (not applicable   /   specification (x/<module>/spec/)  /  Osmosis docs repo   /   not documented)

Converted to draft since CI is failing

Fixed tests :)

What about the migration of locked shares in superfluid? I imagine the potential to have this issue is also capable there as well right?

As discussed in call, planning to address the other side of migration logic once https://github.com/osmosis-labs/osmosis/pull/4885 has been merged.
Created an issue https://github.com/osmosis-labs/osmosis/issues/4959 to track this


KAFKA-4266: ReassignPartitionsClusterTest - Ensure ZK publication completed before start

Increase the reliability of the one temporal comparison in ReassignPartitionsClusterTest by imposing a delay after ZK is updated. This should be more reliable than just increasing the amount of data.
This relates to a previous PR: https://github.com/apache/kafka/pull/1982

We too are experiencing fragility in ReassignPartitionsClusterTest and this PR seems to address the fragile test. Are there any plans of merging this PR?

@silpamittapalli, have you verified that this fixes the issues you are seeing?

Yes, it addresses the fragile test @ijuma

happy to rebase if @ijuma has time to review?

@benstopford, yes, I can review it tomorrow.

@ijuma rebased dude

@ijuma changes made as requested.

@ijuma  Removed the redundant class. Thanks for the review.

Thanks, LGTM. I did a few minor tweaks before merging.


License

Why is the license file missing from the repo?
I am sorry if this is a lame question.

Apache-2.0 license added


An error occurred while loading the PDF

HI,
I need some help, all of the pages using the plugin got an error viewing the PDF.
Please see screen shots and link below:

[pdfjs-viewer url="https%3A%2F%2Fwww.philippineconsulatela.org%2Fwp-content%2Fuploads%2F2021%2F08%2FADVISORY-Deadline-of-Overseas-Voter-Registration-Corrected-Date.pdf" viewer_width=100% viewer_height=800px fullscreen=true download=false print=false]
Thank you.

The PDF should not be encoded in the editor. How did you generate that URL?
It should be https://www.philippineconsulatela.org/wp-content/uploads/2021/08/ADVISORY-Deadline-of-Overseas-Voter-Registration-Corrected-Date.pdf assuming your website starts with https://www

The PDF should not be encoded in the editor. How did you generate that URL?
It should be https://www.philippineconsulatela.org/wp-content/uploads/2021/08/ADVISORY-Deadline-of-Overseas-Voter-Registration-Corrected-Date.pdf assuming your website starts with https://www

It was embedded using your pdfj plugin.
Thanks for the quick reply.

Are you using the classic editor or the Gutenberg block? I'm trying to figure to how to re-create the issue.

Are you using the classic editor or the Gutenberg block? I'm trying to figure to how to re-create the issue.

Below is the editor that im currently using right now, before I dont have a problem with the PDJF Viewer.

Some encoding was done for security reasons. I'll do some digging to see if I can't figure out why you're seeing that.
Are you running the latest version? 2.1.2

Some encoding was done for security reasons. I'll do some digging to see if I can't figure out why you're seeing that.
Are you running the latest version? 2.1.2

Yes, i have the latest version.

I think it's a caching issue. Can you try clearing your cache?

I think it's a caching issue. Can you try clearing your cache?

Cache cleared, same issue.

I'll try to push a fix to break the cache incase that's the issue. Or maybe just pushing new files will magically make it work.

I'll try to push a fix to break the cache incase that's the issue. Or maybe just pushing new files will magically make it work.

Thanks, looking forward for that magic.

New version is up. Hopefully it works better.

New version is up. Hopefully it works better.

Updated the plugin, error still there.
thanks for looking this up.

There's nothing that's encoding the URL in my code. Could one of your other editor plugins be causing an issue? Have you made any other updates/additions recently?

I tried to disable the PDF embedder plugin. The cause is from multiple pdf plugins that I installed.

So everything is working now?

Still the same, even i uninstalled all the plugin related to PDF embedder or viewer.

Ok, I'll push out an update to decode that URL. Not sure what's going on.

I released a new version of the plugin, give it a shot.


Support for Xamarin.iOS

I wanted to try TMDbLib with Xamarin.iOS (or Xamarin in general).
When I install the NuGet package, I get the following error:
Could not install package 'System.Net.Http 4.0.0'. You are trying to install this package into a project that targets 'Xamarin.iOS,Version=v1.0', but the package does not contain any assembly references or content files that are compatible with that framework. For more information, contact the package author.
Is this something you would like to consider?

Most certainly. Have you tried adding a target to the TMDbLib project.json file?

Correction - it is not directly possible yet.
https://github.com/dotnet/cli/issues/589
Until it becomes possible to have it built as part of the dotnet  suite, it's probably too much effort from my end.. Sadly. A workaround is:

Include the TMDbLib code and create a project that targets any intended platform.
Copy out the netstandard1.0 dll from the Nuget package, and reference it directly.

Hi Mike , what is your opinion about using https://github.com/restsharp/RestSharp instate of JSON.NET and  System.Net.Http,
and RestSharp support multiple platform

Not good since that was what we had... had to remove it exactly for compatibility reasons. Should be easy enough to build against a xamarin scope since we can push this as a plc assembly already.
In new terms we should be able to build against the .net standard platform


Loot sometimes wrongly indicated in containers and corpses

Hey guys,
Playing on spt 3.7:
Sometimes Loot is indicated to be in containers, but not actually there. Had this happen with Salewa that were supposedly inside medical bags, as well as ammo and similar in corpses.
Today I caught it with thermite not actually being present in a cache as well as ammo / items i looted myself still being shown as inside a corpse.
screen-capture.webm
screen-capture (2).webm
I already tried unselecting and reselecting "track wishlist", as well as disabling and re-enabling the loot function, that didn't help.

Yeah that is definitely something broken there. I'll try to take a look and see if maybe there was some change in 3.7 that moved how loot was presented to the trainer.

Please write a correct, working example of searching for loot on the example of a gold chain. I can't figure it out

Ok I had a look at the issue.

To optimize thing we have this:
https://github.com/sailro/EscapeFromTarkov-Trainer/blob/master/Features/LootItems.cs#L94
So if nothing is tracked we do nothing (so we do not even show corpses)
As soon as you track something, we'll show corpses (we'll display Corpse). But this is not the same thing as when we find the tracked loot in a corpse (we'll display XXX in Corpse).
So I'll remove this ShowCorpses options in the loot feature, I move it to the Lootable Container feature where we can display stashes, airdrops, etc. With checkboxes select what we want to display: Corpses, Airdrops, ....


ClaimPreview: use new MenuList instead of context-menu (works for both Desktop and Web)

Issue

Second attempt at #5500: Allow right click + report feature on tiles
Related: PR #5531

Notes
Although the link can already be easily copied on web, the menu item is still retained for consistency between the platforms.

awesome

Amend
Separator:

Handle runtime warning that MenuList::onSelect cannot be null or undefined (added empty handler)
Also added disabled to prevent the separator from being "clickable"

I just removed the MenuButton surrounding the hr


Update for haskell-lsp-<IP_ADDRESS>

haskell-lsp-<IP_ADDRESS> is not released just yet

The ghcide Github project is becoming archived and merged into https://github.com/haskell/haskell-language-server
This PR will need to be reopened in the HLS repo. To do that, create a new branch from HLS HEAD in your HLS repo and do:
git remote add ghcide https://github.com/georgefst/ghcide.git
git fetch ghcide
git merge ghcide disable-warnings

Thanks!


Syntax error with fat arrow

Sorry to bother you again, but after all you just wrote an article inviting people to try out a whole new universe of tools they didn't know before (webpack, npm, react, es6) ;)
I'm trying to use react-google-maps in my project and they explain to define the map click action like this _handle_map_click = (event) => {. But then webpack complains and says Unexpected token pointing to the = sign.
I thought maybe this fat arrow stuff is still experimental and tried adding stage: 0 to the webpack config, but it still doesn't work:
module: {
  loaders: [
    {
      test: /\.jsx?$/,
      exclude: /node_modules/,
      loader: 'babel-loader',
      query: {
        stage: 0
      }
    },
    ...

Any idea ?

Actually even using the = sign inside the class definition breaks:
class Map extends React.Component {
  state = {...}
}

raises Unexpected token as well.

Mmmh ok it turns out I just needed to stop npm start and re-run again. I thought I had done it but I somehow may have mixed two steps together :)
Anyway don't you think it would be a good idea to add the stage: 0 option by default in the gem ?

I don't recommend using Stage 0 in any production app. I've added a PR that creates a .babelrc file with the following contents:
{
  "stage": 1
}

If you want to use Stage 0, you can change it here.
Best regards, Szymon Szeliga

Good advice. Also I didn't know about the existence of .babelrc. Thank you !


Update manifest: Microsoft.LogParser version 2.2.10

Details

Add Scope parameter of this package

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
Resolve #161664

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

/azp run

Okay ... ❤
But is there any other ways to solve https://github.com/microsoft/winget-pkgs/issues/161664#issue-2392330389?

[!NOTE]
Close with reason: https://github.com/microsoft/winget-pkgs/pull/161747#pullrequestreview-2163510064


more tests will pass

Fixed a few more tests. Still needs some additional work on the rest of the tests, mostly the token characters.

Would it make sense to move most of these tests onto a branch of work in progress, so that main compiles?  I think people might be scared away from helping if main is in a broken state.


Formatting not right for “The Distributed System ToolKit: Patterns for Composite Containers”

This is a Bug Report

Problem:
The Markdown for The Distributed System ToolKit: Patterns for Composite Containers (content/en/blog/_posts/2015-06-00-The-Distributed-System-Toolkit-Patterns.md) is not rendering correctly. There's an unordered list that, at first glance, just stops.
Proposed Solution:
Fix the Markdown
Page to Update:
https://kubernetes.io/blog/2015/06/the-distributed-system-toolkit-patterns/
Additional Information:
Usually we avoid fixing old blog articles because there's more valuable work to be done. However, I would make an exception because the Pod concept documentation directly links to this particular article.
/language en
/area blog
/kind cleanup
/help

/assign

@sftim I see other posts (about 15 posts) have the same rendering issues. Can I fix them at the same time? As you said, they are old blog articles but this rendering issue can be easily fixed, just deleting several newline characters.

That's fine @shuuji3 - great idea.

/kind bug

/remove-kind cleanup

@sftim OK, I'll clean them up. 🧹


Laravel 5.4 support

Laravel does not support $app->share functionality used in src/Frozennode/Administrator/AdministratorServiceProvider.php
Here are some details on the issue - https://laracasts.com/discuss/channels/laravel/undefined-method-illuminatefoundationapplicationshare-when-upgrading-to-laravel-54

I managed to convert all those methods, in the frozennode service provider file, to use the singleton method, but then came across more problems and gave up. I would be willing to collaborate with anyone to get this package up and working with 5.4 though, as it is hard to match for speed and customisation ability..

I cloned and made some fix in my repo

I use Laravel 5.1 LTS. It works.

I had the same problem.. How to solve it.

@exodusanto did it work?

@naneri yes, i'm support also 5.5


Fixed panic on debug print of invalid timezones

Closes #903

Tested, and change looks good to me :partying_face:
It's a bit of a shame to lose the "Invalid Offset format (must be [-]00:00) or chrono-tz feature not active" message, but not panicing is a huge improvement, and keeping this message doesn't seem worth the significant change required I think!


Fix 4.0.2

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

a few issues:

will not work on osx-arm64 :/ workaround is to create the environment with intel binaries: CONDA_SUBDIR=osx-64 mamba create -n mobie -c conda-forge mobie-cmd

currently mobie hcs errors out (some java problem) - but tests still complete 😬 this seems to be a problem on the jgo side...


Crop image button

Is your feature request related to a problem? Please describe.
I want crop my image
Describe the solution you'd like
I want crop image button
Describe alternatives you've considered
A crop image button
Additional context
Im very happy if we have crop image button✨

Hi @luanon404 - can you add some more detail about the setting you'd like to be able to crop images in? FWIW, in many situations Label Studio isn't able to modify the underlying image data that it's displaying.

Hi @luanon404 - can you add some more detail about the setting you'd like to be able to crop images in? FWIW, in many situations Label Studio isn't able to modify the underlying image data that it's displaying.

the image added to big with my current model, i want crop it smaller but it cant, what only way i can do is export it and cut it manually, the crop area not touch the label area, so i think we should have the crop button for that.

imagine label 10000 images then you cant crop the image, must relabel again


Container apps cannot mount Azurefile storage unless AES-128-GCM is used in security protocol settings: Undocumented requirement

This issue is a: (mark with an x)

[ ] bug report -> please search issues before submitting
[x] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Issue description
When mounting azure file storage into a container app there is a undocumented requirement that AES-128-GCM be enabled in  the in the protocol settings of the Azure file share
Steps to reproduce

Following instructions https://learn.microsoft.com/en-us/azure/container-apps/storage-mounts-azure-files?tabs=bash
in the share security setting uncheck "AES-128-GCM"
Deploy application

Expected behavior [What you expected to happen.]
Behaviour requirement should be documented
Actual behavior [What actually happened.]
Applications fail to startup. no error message in logs apart from crashing message.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Ex. Did this issue occur in the CLI or the Portal?

Thanks for sharing! We'll investigate this error message.

@ivanthelad , Thanks for reporting this issue. Currently, we only support SMB 3.1.1. And according to the SMB on Linux https://learn.microsoft.com/en-us/azure/storage/files/storage-how-to-use-files-linux?tabs=Ubuntu%2Csmb311, It should have AES-128-GCM encryption enabled. We may link this document into our documentation.

These are the defaults now across the board for both CLI and Portal. Hopefully this resolves this issue. Please reopen if not.


Fix pip sdist install

With the current implementation of setup.py the source distribution cannot work because requirements.txt isn't included. This is reproducible with the following command pip install cel-python --no-binary :all:.

FileNotFoundError: [Errno 2] No such file or directory: 'requirements.txt'

Thanks for the pull request!  If you don't mind could you sign the Linux Foundation/CNCF CLA referenced in the other comment.

Thanks for the pull request! If you don't mind could you sign the Linux Foundation/CNCF CLA referenced in the other comment.

Thanks for the reminder. Fixed.


Introduce Tabs model

Description

Add Tabs model
Hide Container title if embedded inside Tabs
Style tabs accordingly
Refactor validator for reuse (checking for min length)
Update features demo for pydantic and yaml

Docs + Tests will be done in a separate PR
Screenshot

Notice

[x] I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
I have not referenced individuals, products or companies in any commits, directly or indirectly.
I have not added data or restricted code in any commits, directly or indirectly.

Add example with non-charts

Yes, I noticed that as well, but I couldn't figure out where this comes from. I've added an example here: https://github.com/mckinsey/vizro/pull/280/commits/c6066b5eff1b7e145c50f4678bf265de72275bc2
Seems like the jumping doesn't appear with other components such as the Table and the Card.

@antonymilne - I suspect it to be the plotly charts. I found this issue on dash: https://github.com/plotly/dash-core-components/issues/922, which still seems to be open. Our situation is similar to the example, but we do not set a fixed height for the figure beforehand; instead, our layouts set it dynamically. For instance, in our example page for the single tabs, the plotly charts initially have a height < 450px because the layout is set to fix the page without scrolling, and the charts dynamically update their width/height to fit their parent container.
What I assume happening is then when switching to a different tab, the plotly charts' height/width get reset to their original sizes (as explained in the issue). This leads to this short blinking effect and a scroll bar appearing for a second on the right, as with their actual size, they overflow their parent container. However, the scrolling bar disappears very quickly after they update their height/width again, but this blinking effect remains on the initial load.
I've double-checked with a pure dash app and you can also see this blinking/resizing happening there. I am not 100% sure why this behaves like it behaves 😄 but be worth double-checking with @AnnMarieW 👍

Hi @huong-li-nguyen Yes, this is an open issue at Plotly and it's not an easy fix.  The best workaround for now is to set the height.  Maybe a clientside callback would be faster and help to reduce the flicker.

Hi @huong-li-nguyen Yes, this is an open issue at Plotly and it's not an easy fix. The best workaround for now is to set the height. Maybe a clientside callback would be faster and help to reduce the flicker.

Thanks @AnnMarieW for the quick reply! 🚀 That's very good to know! Yes, I've seen your answer on the thread, and setting a fixed height also works for us (in our case it's dynamically enforced by the size of the parent container). The blinking just happens when you switch the first time, afterwards it all works well!

Hi @huong-li-nguyen Yes, this is an open issue at Plotly and it's not an easy fix. The best workaround for now is to set the height. Maybe a clientside callback would be faster and help to reduce the flicker.

Thanks @AnnMarieW for the quick reply! 🚀 That's very good to know! Yes, I've seen your answer on the thread, and setting a fixed height also works for us (in our case it's dynamically enforced by the size of the parent container). The blinking just happens when you switch the first time, afterwards it all works well!

Cool, thank you very much for all this @huong-li-nguyen and @AnnMarieW! If it's not an easy one to fix then no worries, it definitely shouldn't block this feature being released. And we can put it on the backlog to look at again later.


Datum hash was assigned to the wrong field when deserializing pre-alonzo tx

Codecov Report

Merging #233 (d40804b) into main (40f00fb) will not change coverage.
The diff coverage is 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   85.45%   85.45%
=======================================
  Files          26       26
  Lines        2957     2957
  Branches      709      709
=======================================
  Hits         2527     2527
  Misses        318      318
  Partials      112      112

Impacted Files
Coverage Δ

pycardano/transaction.py
94.09% <100.00%> (ø)


Module 'requests.packages' has no 'urllib3' member

I am getting this issue in HubRestApi.py. I installed all the requirements but I am still getting this error.

First, what is it you're trying to do? Do you just want to use the blackduck library in PyPi to use the Black Duck REST API? Or do you want to do some work on the library itself?
The above error appears to be something wrong in your python environment. Can you confirm or share the following?
python --version
pip --version
The code in this repository only supports python3.
I highly recommend use of virtualenv (or some equivalent) to totally isolate the python env, and ensure a clean setup of same.

First, what is it you're trying to do? Do you just want to use the blackduck library in PyPi to use the Black Duck REST API? Or do you want to do some work on the library itself?
The above error appears to be something wrong in your python environment. Can you confirm or share the following?
python --version
pip --version
The code in this repository only supports python3.
I highly recommend use of virtualenv (or some equivalent) to totally isolate the python env, and ensure a clean setup of same.


Add support for XML file_type

use Python's builtin xml library to process XML data from FRED
new test for base client
make _util package private
make _fred_client module private

Codecov Report

Merging #18 (41d484f) into main (a62d144) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           18        18
  Lines          445       457   +12
=========================================
+ Hits           445       457   +12

Impacted Files
Coverage Δ

src/fred/_util/decorators.py
100.00% <ø> (ø)

src/fred/api/_fred_client.py
100.00% <100.00%> (ø)

src/fred/api/categories.py
100.00% <100.00%> (ø)

src/fred/api/releases.py
100.00% <100.00%> (ø)

src/fred/api/series.py
100.00% <100.00%> (ø)

src/fred/api/sources.py
100.00% <100.00%> (ø)

src/fred/api/tags.py
100.00% <100.00%> (ø)

tests/test_base_client.py
100.00% <100.00%> (ø)

tests/test_decorators.py
100.00% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


agent/exec: TestControllerFlowIntegration: replace deprecated NewClient

- What I did
- How I did it
- How to test it
- Description for the changelog

Thx!


Alertmanager does not tolerate taints or offer a method to do so

What kind of request is this (question/bug/enhancement/feature request):
bug
Steps to reproduce (least amount of steps as possible):

Add taint to all workers
Add a notifier to cluster alerts

Result:
Alertmanager deployment is stuck in "Scheduling" as it does not tolerate the taints on the workers. There is no way to add tolerations to Alermanager even in the Helm Catalog.
Other details that may be helpful:
Similar to https://github.com/rancher/rancher/issues/27253 but specific to alertmanager
The following appear to interfere with the deployment of alertmanager on a clsuter where all the nodes have a taint:
https://github.com/rancher/system-charts/blob/dev-v2.4/charts/rancher-monitoring/v0.1.4/templates/_helpers.tpl#L134
When added to:
https://github.com/rancher/system-charts/blob/dev-v2.4/charts/rancher-monitoring/v0.1.4/charts/alertmanager/templates/alertmanager.yaml#L78
Environment information

Rancher version: 2.4.11

gz#14202

@Tejeev I'm not sure if I follow the bug here.
If you pass in alertmanager.tolerations[i].<key|operator|value|effect>, it should be able to tolerate the taint on the workers since the default toleration only prevents that specific taint from impacting Alertmanager's ability to be deployed onto the node, not all taints.

Hi @aiyengar2,
Apologies, but where and how do we pass this?  Could you provide an example where alertmanager is deployed to tolerate 2 or 3 taints?


continual learning for Repairnator

FYI, @javierron works on continuous learning for Repairnator, where the Travis data and Githb commits are used as data points for training Sequencer.

[x] continuous training
[x] continuous prediction
[x] log parsing for prediction
[x] debug the last problems

Next tasks after closing this one.

context size #1033
bigger diffs #1034
create an artificial 6 line context for prediction #1096
exception lines #1099
ensemble prediction https://github.com/eclipse/repairnator/issues/1100

After #971,

Store the scanned commit diffs that contain single-line-changes.
Filter out repeated data or data that may be irrelevant e.g. comment lines.

@monperrus After re-reading the SequenceR paper, I believe storing only the .diff files that contain single line changes will not be enough. Shouldn't we store the whole class to create the abstract buggy context?

You're right, SequenceR today requires the full file.
However, we can adapt Sequencer to be trained only with 3-lines unified diff.
It's a trade-off:

full files: more call to the Github API
3-lines unified default diff: one single call

It would be great to see how better is the training with the full context.

Related work on vocabulary adaptation: On-the-Fly Adaptation of Source Code Models using Meta-Learning
https://arxiv.org/pdf/2003.11768.pdf

Per our discussion, we can do greedy optimization on any benchmark metric, incl. D4J/BEARS compilation rate and D4J/BEARS plausible rate.

OpenNMT ensemble translation does not currently work.
Issue: https://github.com/OpenNMT/OpenNMT-py/issues/1252

Continual learning research:
https://github.com/prprbr/awesome-lifelong-continual-learning

OK, then moved task to top-level issue https://github.com/eclipse/repairnator/issues/1100
What about ticking now the last todo and closing this issue?

What about ticking now the last todo and closing this issue?

The RepairnatorZero loop is running now, I think we can close this issue.

Then hurray we close this one :champagne: thanks for the hard work.

For the record, if Sequencer has more than one patch, we only create a single PR, with the patch with highest likelihood from OpenNMT

For the record, the problem we face is called "catastrophic forgetting"

Early attempts to mitigate catastrophic forgetting typically consisted of memory systems that store previous data and that regularly replay old samples interleaved with samples drawn from the newdata  (Robins  1993,  1995),  and  these  methods  are  still  used  today  (Gepperth  &  Karaoguz  2015, Rebuffi et al. 2016).
page 8

Continual Lifelong Learning with Neural Networks:A Review
https://arxiv.org/pdf/1802.07569.pdf
Advanced techniques:

EWC from Overcoming catastrophic forgetting in neural networks https://arxiv.org/pdf/1612.00796.pdf
Progress & compress: A scalable framework for continual learning. InICML, 2018 https://arxiv.org/pdf/1805.06370
CLEAR: Experience Replay for Continual Learning 2019 http://papers.nips.cc/paper/8327-experience-replay-for-continual-learning.pdf

FYI:
Learning to Prompt for Continual Learning (L2P)  by  Google Research
https://github.com/google-research/l2p


New feature: Per-county version of FailCount (call it CountyFailCount)

Like the normal FailCount, we should have the overall count of failures, plus subfeatures for each failure type.
This should just run as per-county feature, like our other per-county features, so we get features like: cty0_FailCount, cty1_FailCount, ..., cty0_FailCount-TooManyBlooms, etc.

Resolved in #195


use pypi class for python recipes (resolves #566)

I quickly tested this pull request with this build configuration:
Build Configuration:
BB_VERSION           = "1.35.0"
BUILD_SYS            = "x86_64-linux"
NATIVELSBSTRING      = "ubuntu-16.04"
TARGET_SYS           = "i586-oe-linux"
MACHINE              = "qemux86"
DISTRO               = "nodistro"
DISTRO_VERSION       = "nodistro.0"
TUNE_FEATURES        = "m32 i586"
TARGET_FPU           = ""
meta                 = "master:ced4ac760926ce43a937dad2be3b873b1beec6aa"
meta-oe
meta-multimedia
meta-python          = "master:e08670d4362b57373557fbe6b31cbffffa465acc"
meta-ros             = "use-pypi-class:58a843f99f4b63f76148bc714db553f7ee5e062c"

Hmm... I don't understand why this build is failing.

Hm.. I guess I know what's wrong with CI - meta-openembedded get's added after meta-ros. But I'll fix this tomorrow. gtg now.

I've fixed the order which layers get added in and re-triggered the build.

Looks good to me. Merging...


Intellisense not working

Everything works fine, except that I get nothing listed in Intellisense after typing something along the lines of :
// :   and then pressing Ctrl+space
I've installed Remoji, to no effect. Ideas?

Actually, if I highlight the : before pressing Ctrl+space, it does in-fact pull up the list... Is this normal?

Hi @dcolclazier!
If you're using ReSharper along with Remoji, it would be a Remoji bug instead, as they have their own completion for ReSharper. /cc @hmemcpy

Awesome - thanks for the quick response.


Where to discuss each proposal/experiment?

First, apologies for my drive-by comment yesterday. I wasn't at computer and hadn't even cloned the code...should have been more deliberate!
Probably not best to discuss points on each proposal via a PR conversation. If we put here in issue, do we prefix each subject or use labels to map to each experiment?

I have seen this across the project several times. We lack a place to discuss proposals and somehow having "discussions" use issues seems off.


Change np.ndarray types to list type to fix model serialization to fix OpenAPISpec and SwaggerUI

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix

What is the current behavior? (You can also link to an open issue here)
In Marqo 2.x, OpenAPI spec generation is not functional. Attempting to access /openapi.json or /docs results in errors, making it impossible to retrieve the API specifications and documentation. This issue is documented in Issue #778.

What is the new behavior (if this is a feature change)?
This PR restores OpenAPI spec generation and resolves the issues with the /openapi.json and /docs endpoints. The root cause was identified in src/marqo/tensor_search/models/add_docs_objects.py, where the documents field included a union type that couldn't be serialized due to the presence of np.ndarray.

By replacing np.ndarray with the standard Python list type in the union, the serialization issue is resolved, allowing OpenAPI specs and Swagger UI to function as expected.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No, this PR does not introduce any breaking changes. Existing functionalities remain unaffected, and users do not need to make any changes to their applications.

Have unit tests been run against this PR? (Has there also been any additional testing?)
No, unit tests haven't been executed. I locally confirmed that the OpenAPI specification and Swagger UI are now accessible and operational.

Related Python client changes (link commit/PR here)
No related changes in the Python client.

Related documentation changes (link commit/PR here)
No changes needed as the fix restores a functionality already documented.

Other information:
The issue was addressed by considering three potential solutions:

Implementing a custom OpenAPI function in FastAPI to exclude np.ndarray fields from the schema.
Creating a custom JSON encoder for models containing np.ndarray.
Replacing np.ndarray with a standard Python list type.

The third option was chosen for its simplicity and effectiveness.

Please check if the PR fulfills these requirements

[ ] The commit message follows our guidelines
[ ] Tests for the changes have been added (for bug fixes/features)
[ ] Docs have been added / updated (for bug fixes / features)

Hello @gabauer, your contribution is much appreciated. I've added a comment, confirming the type of the documents parameter should just be Sequence[dict[str, Any]]. Could you please make the change and we can proceed with this PR? Cheers.

Hi @papa99do, sorry for the long delay, changed the types and added simple endpoint test.

Thanks @gabauer , the change looks good to me. I'll approve and trigger the build.

Running into a github permission issue. Will close and reopen to see if I can approve to trigger the action run.

Hello @gabauer . There seems to be a github issue blocking me from running GH workflows for this PR. The permission to access the action secrets store cannot be granted. I'll need your help to close this PR and raise a new PR from your branch. You can just copy the description over. And I'll approve it and grant permission to run all the checks. Sorry for the inconvenience. Thanks a lot.

Hi @papa99do, no problem, did it: https://github.com/marqo-ai/marqo/pull/986


How to run Ollama using AMD RX 6600 XT on Windows 11?

What is the issue?
The responses by all the LLM's are slow as the CPU is prioritised. I wish to make use of my RX 6600 XT GPU but apparently the workaround is only on Linux. Furthermore, ROCm runtime is available for RX 6600 XT but not HIP SDK which is apparently what is needed for my GPU to run LLMs. However, the documentation for Ollama says that my GPU is supported. How do I make use of it then, since it's not utilising it at all?
OS
Windows
GPU
AMD
CPU
Intel
Ollama version
0.1.32

make sure make your rocm support first .  download somewhere in github , eg, here replace the file in hip sdk.
Then git clone ollama , edit the file in  ollama\llm\generate\gen_windows.ps1 ,add your gpu number there . then follow the development guide ,step1,2 , then search gfx1102 , add your gpu where ever gfx1102 show  .  build again or simple follow the readme file in app folder to build an ollama install then you are make your ollama running on gpu

llm\generate\gen_windows.ps1 ,add your gpu num

Thank you very much for your method, I successfully added gfx1031, my 6700xt graphics card can run llama3 perfectly

make sure make your rocm support first . download somewhere in github , eg, here replace the file in hip sdk. Then git clone ollama , edit the file in  ollama\llm\generate\gen_windows.ps1 ,add your gpu number there . then follow the development guide ,step1,2 , then search gfx1102 , add your gpu where ever gfx1102 show . build again or simple follow the readme file in app folder to build an ollama install then you are make your ollama running on gpu

Thank you very much for your method, I successfully added gfx1031, my 6700xt graphics card can run llama3 perfectly

Video please @Sohnny0


I can't load the db_resnet50_rotation model from the main branch

Bug description
When I try to install python-doctr from Pypi or from the main branch of the repo, I can't use the db_resnet50_rotation model.
I have the error : WARNING:root:Invalid model URL, using default initialization.
Or I also have the error that it is impossible to use this model with this architecture.
To use this model I need to checkout to commit id : e645ead
And install the package from this commit.
How can I use this model without having to checkout to this specific commit ?
Code snippet to reproduce the bug
import os
from doctr.io import DocumentFile
from doctr.models import ocr_predictor

list_file= os.listdir('img_tmp')

model = ocr_predictor(
    det_arch="db_resnet50_rotation",
    reco_arch="parseq",
    pretrained=True,
    det_bs=8,
    reco_bs=1024,
    assume_straight_pages=False,
    straighten_pages=True,
    detect_orientation=True,
)

for i in list_file:
    image_file=DocumentFile.from_images(tmp/{i}')
    result = model(image_file)
    json_res = result.export()
    print(json_res["pages"][0]["orientation"]["value"])

Error traceback
WARNING:root:Invalid model URL, using default initialization.

Environment
doctr.version = 0.8.0a0
Deep Learning backend

print(f"is_tf_available: {is_tf_available()}")
is_tf_available: False
print(f"is_torch_available: {is_torch_available()}")
is_torch_available: True

Hi @fsimonAramis 👋,
This model is replaced by db_resnet50 which works now also on rotated documents :)