add enable_recording request for audiobridge plugin?

Hi would it be possible to add the enable_recording request for the audiobridge plugin?
Or would you accept a pull request with it?

I've just pushed the commit https://github.com/meetecho/janode/commit/2b4a0f966d8de39916c6497f9ff8410605fd9631, please check that everything works as expected.

Hi @atoppi  thanks for that!
looks pretty good so far.  Did you omit 'record_dir' on purpose?  It would be good to have if we could have it in there.

Did you omit 'record_dir' on purpose? It would be good to have if we could have it in there.

Yes I have omitted it for consistency with other APIs like create, where I only provide the recording filename as an absolute path.
I don't like the current approach in some Janus plugins where you can set a path, a filename or a mix of them. I find it a bit confusing.
Anyway I'm open to discuss it.

I might be doing something wrong, but it doesn't seem like you can set an absolute path as the 'filename'
I send
janodeManagerHandle.enableRecording({
  room: <room>,
  secret: <secret>,
  record: true,
  filename: '/full/path/to/my.wav'
})

and get the response:
{ record: true, room: <room> }
but, I can't find the recording anywhere.  Is there a default recording directory config setting I might be missing?

It worked for me.
Check Janus logs, maybe it's a matter of permissions.

Janus will not create the folder if it's part of the path, only if the folder is provided separately. If that folder doesn't exist that's probably why the recording isn't created (even though I think you'll get an support error message in the logs).

IMHO rec_dir should be part of the API because of that.

In that case I'd rather omit the recording_dir on the janode API and split the user supplied full path in file + dir when requesting the action to Janus.

fwiw, the problem I was having was an error on my side.  It works

Ended up adding recording folder parameter to the api (commit 272e5424f9ffd53fb135fb0110835ff0afdbafa2)
I've noticed that we already used a rec_dir param in the videoroom plugin, so I added it to audiobridge too.
Closing now.


Write tests for exporter sanitization functions

Addressed in  PR #82  .

@janetriley so can we close this issue?

Yes, it was (merged to development)[https://github.com/DistrictDataLabs/baleen/pull/82]


"--output" grabs onto the next argument or line in a config file, as its desired output value

Checklist

[X] I'm reporting a bug unrelated to a specific site
[X] I've verified that I'm running yt-dlp version 2022.07.18 (update instructions) or later (specify commit)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X] I've searched the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Provide a description that is worded well enough to be understood
When "--output" or "-o" is used and nothing follows it, instead of generating an error like one would expect to do it instead uses what follows, usually the next argument, as its desired value.
This also applies to config files where "--output" or "-o" take the following line in the file.
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
yt-dlp -vU --output --write-description  https://www.youtube.com/watch?v=kkwiQmGWK4c
[debug] Command-line config: ['-vU', '--output', '--write-description', 'https://www.youtube.com/watch?v=kkwiQmGWK4c']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version 2022.07.18 [135f05e] (win32_exe)
[debug] Python 3.8.10 (CPython 64bit) - Windows-10-10.0.19044-SP0
[debug] Checking exe version: ffmpeg -bsfs
[debug] Checking exe version: avconv -bsfs
[debug] Checking exe version: ffprobe -bsfs
[debug] Checking exe version: avprobe -bsfs
[debug] exe versions: none
[debug] Optional libraries: Cryptodome-3.15.0, brotli-1.0.9, certifi-2022.06.15, mutagen-1.45.1, sqlite3-2.6.0, websockets-10.3
[debug] Proxy map: {}
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: 2022.07.18, Current version: 2022.07.18
yt-dlp is up to date (2022.07.18)
[debug] [youtube] Extracting URL: https://www.youtube.com/watch?v=kkwiQmGWK4c
[youtube] kkwiQmGWK4c: Downloading webpage
[youtube] kkwiQmGWK4c: Downloading android player API JSON
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, codec:vp9.2, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), acodec, lang, proto, filesize, fs_approx, tbr, vbr, abr, asr, vext, aext, hasaud, id
[debug] Default format spec: best/bestvideo+bestaudio
[info] kkwiQmGWK4c: Downloading 1 format(s): 22
[debug] Invoking http downloader on "https://rr1---sn-aigl6nzs.googlevideo.com/videoplayback?expire=1659683033&ei=eWzsYt2ACPL-1wb26r64Cw&ip=<IP_ADDRESS>&id=o-AJb0eJIL0TkshoDymG-IHeULiveXyrCwWByVHOMH_h5y&itag=22&source=youtube&requiressl=yes&mh=qo&mm=31%2C29&mn=sn-aigl6nzs%2Csn-aigzrne7&ms=au%2Crdu&mv=m&mvi=1&pl=24&initcwndbps=431250&vprv=1&mime=video%2Fmp4&cnr=14&ratebypass=yes&dur=38.939&lmt=1577675264659456&mt=1659660775&fvip=1&fexp=24001373%2C24007246&c=ANDROID&rbqsm=fr&txp=5535432&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cvprv%2Cmime%2Ccnr%2Cratebypass%2Cdur%2Clmt&sig=AOq0QJ8wRAIgbpZkSlKjOh1LxV9s6c82c16wM1YZ3LGeGPY4nU9gQyYCIGuizTCCz6MviUCvPRf6S7vOycYbL-1oBzs7lmoDQ8qT&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AG3C_xAwRgIhAP1303nmJshrKC0XULgISXu7FVKXK3Y37Cl3IRU5QHv_AiEAifAalwETK97ocy2suP6lCHKnmE8tG6tiYKeNzNbD9Og%3D"
[debug] File locking is not supported. Proceeding without locking
[download] Destination: --write-description
[download] 100% of 3.10MiB in 00:02

It is because --write-description follows -o. I've never heard of any command line tools that detects the "missing" mandatory value.

How would the program know that you don't want to name your file "--write-description"?


Replace legacy build pipeline with Typescript SDP build pipeline

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: yunair sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Docs Build status updates of commit c858e2a:
:warning: Validation status: warnings

File
Status
Preview URL
Details

<EMAIL_ADDRESS>:warning:Warning

Details

<EMAIL_ADDRESS>:warning:Warning

Details

<EMAIL_ADDRESS>:warning:Warning

Details

<EMAIL_ADDRESS>:warning:Warning

Details

<EMAIL_ADDRESS>:warning:Warning

Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

<EMAIL_ADDRESS>:white_check_mark:Succeeded

signalrjs/docs-ref-autogen/toc.yml
:white_check_mark:Succeeded

<EMAIL_ADDRESS>
[Warning-UidNotFound] 1 invalid cross reference(s) "<xref:AbortError>".

<EMAIL_ADDRESS>
[Warning-UidNotFound] 1 invalid cross reference(s) "<xref:HubConnection>".

<EMAIL_ADDRESS>
[Warning-UidNotFound] 1 invalid cross reference(s) "<xref:HubConnection>".

<EMAIL_ADDRESS>
[Warning-DuplicateUids]<EMAIL_ADDRESS>has already been defined in docs-ref-autogen/%40aspnet/signalr/_NodeHttpClient.yml.
[Warning-DuplicateUids]<EMAIL_ADDRESS>has already been defined in docs-ref-autogen/%40aspnet/signalr/_NodeHttpClient.yml.
[Warning-DuplicateUids]<EMAIL_ADDRESS>has already been defined in docs-ref-autogen/%40aspnet/signalr/_NodeHttpClient.yml.
[Warning-DuplicateUids]<EMAIL_ADDRESS>has already been defined in docs-ref-autogen/%40aspnet/signalr/_NodeHttpClient.yml.
[Warning-DuplicateUids]<EMAIL_ADDRESS>has already been defined in docs-ref-autogen/%40aspnet/signalr/_NodeHttpClient.yml.
[Warning-DuplicateUids]<EMAIL_ADDRESS>has already been defined in docs-ref-autogen/%40aspnet/signalr/_NodeHttpClient.yml.
[Warning-DuplicateUids]<EMAIL_ADDRESS>has already been defined in docs-ref-autogen/%40aspnet/signalr/_NodeHttpClient.yml.
[Warning-DuplicateUids]<EMAIL_ADDRESS>has already been defined in docs-ref-autogen/%40aspnet/signalr/_NodeHttpClient.yml.
[Warning-DuplicateUids]<EMAIL_ADDRESS>has already been defined in docs-ref-autogen/%40aspnet/signalr/_NodeHttpClient.yml.
[Warning-DuplicateUids]<EMAIL_ADDRESS>has already been defined in docs-ref-autogen/%40aspnet/signalr/_NodeHttpClient.yml.

<EMAIL_ADDRESS>
[Warning-UidNotFound] 1 invalid cross reference(s) "<xref:HubConnection>".

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


Reverted #782 as a workaround for #902 .

@kazuki43zoo ,
Could you please review this?
Thanks!

Sorry, this might not be right. I'll retry this weekend.


Fix black screen issue + thumbnail error

Fixed #111.

The fix is not going to work because you can't used a git repo as a dep in the library. You'll have to add it manually.


Follow JavaScript conventions

Your checklist for this issue
🚨 Please review the guidelines for contributing to this repository.

[ ] Link to any upstream changes that might be required (for example Jenkins Core pull request)

Feature Request
Follow javascript conventions.
Please see
https://google.github.io/styleguide/jsguide.html#formatting-block-indentation
https://github.com/airbnb/javascript#whitespace
https://www.w3schools.com/js/js_conventions.asp
Not sure why json and ts files are using tabs when all Javascript convention says 2 space indents.
You can use prettier for auto formatting (comes as a vscode extension even)

@casz I expected  prettier extension to do the work for me, am I missing something :/

You have to configure prettier and install the npm package.

fixed in #24


Re-enable in-memory graph update test

Fix was to re-add the code that was removed and change it to clear data from the in-memory database directly rather than going through EnsureDeleted.

:shipit:

Merged


Not able to deploy bookshop sample with multi-tenancy to SAP BTP

Hello Team,
When i am following the steps to create the bookshop sample application with multi-tenancy enabled, everything works perfect in my local. However, when i am try to deploy it to my BTP global account, i got the below error messages.
Error messages from bookshop-mtx application

Error messages from bookshop-srv application

Would you please help to figure out is there any step is missing from my side, or this is still not support by @sap/cds-mtxs?
Best Regards,
Hank.

Hi @Hank1986,
from your second error, I created a fix in our samples repository as needed since June.
Do you use the latest @sap/cds-dk package?
We found, that the command cds add hana --for production is missing in the multitenancy guide. Could you pls give that a try and see if that fixes your error?
All the best,
René

Hello Rene,
Actually, I setup my sample project with node18 and latest cds, cds-dk and npm. Please refer below screenshot for more details.

Best Regards,
Hank.

Hi @Hank1986,
from your second error, I created a fix in our samples repository as needed since June.
Do you use the latest @sap/cds-dk package? We found, that the command cds add hana --for production is missing in the multitenancy guide. Could you pls give that a try and see if that fixes your error?
All the best, René

Hello Rene,
After updated the script from 'cds run' to 'cds-serve' the application bookshop-srv started successful. However, the application bookshop-mtx still ran into the same error.
Logs from application bookshop-srv.

Logs from application bookshop-mtx

Best Regards,
Hank.

Hi @Hank1986 ,
did you execute cds add hana --for production in your project?

Hi @renejeglinsky ，
Yes, the 'cds add hana --for production' was executed in my project. And below is the package.json file in my project.

Best Regards,
Hank.

Hi Hank,
Did you use our bookshop from our cap samples?
If so, the deployment of it is always challenging, due to the monorepo setup. In that case, please start with a fresh bookshop as described in the guide.
All the best,
René

Hi Hank,
Did you use our bookshop from our cap samples? If so, the deployment of it is always challenging, due to the monorepo setup. In that case, please start with a fresh bookshop as described in the guide.
All the best, René

Hi @renejeglinsky,
Yes, i use the bookshop from cap samples by following the steps which mentioned in document. Deploy as Multitenant SaaS Application https://cap.cloud.sap/docs/guides/deployment/as-saas#add-multitenancy.
The same error even i retried serval times from scratch.
Best Regards,
Hank.

Hi @Hank1986 ,
I went through the steps today and encountered no issue. The only difference I could spot, is that your sidecar uses jwt-auth and mine jwt. I was using a trial account which is also different from your setup. Though I'm not really sure what causes your issue.

Hi @Hank1986 ,
In the meantime, did you succeed in running your app?

Hi @Hank1986 ,
In the meantime, did you succeed in running your app?

Hi @renejeglinsky ,
Unfortunately, it's still not working to me. Not sure what's wrong here.
Best Regards,
Hank.

Hi Hank,
would you want to give it another try with recent versions? Or should we close this issue? Probably it makes more sense to ask this question on the community and provide a link to your repo to be able to reproduce it.

I guess we won't find a solution here. I'm sorry. Therefore I'm closing this issue.


Add graph feature to show a star chart/graph of a repository

We can use probably a --graph option to display a graph of the star/fork/watcher or just the stars of one or more repositories, choosing a specific repository or display a graph for all repos fetched from search() is undecided. Play around and experiment with what you should do, if we are going to display a graph for every repo fetched, we should make the graph option one of the --layout choices.
Don't forget to update the help and usage both in __main__.py and also in the readme.

Hey, I would like to work on this, I am a newcomer to open source, any pointers on how to start on this?

You can setup your development environment using the tutorial in the contributing file, if it’s working properly you are good to go. This feature request is mainly about displaying a graph (or ASCII graph) in the terminal as described in the description above, you can try doing it locally on your computer, and push it and open a pull request. If you are stuck, feel free to ask

Thanks for the help!

@hedythedev I may have to scrape and form the data for stars collected over a period of time myself, and doing that may take a longer time for repos with a very high number of stars, and can cause the program to slow down, should we look at only displaying graphs for repos with just enough stars so that the data scraping does not slow the whole thing down?
You can see the same problem here, https://starchart.cc/torvalds/linux, because this repo has a whole lot stars, the graph does not load.

Oh, I see. We could initially try getting all the star data, then after a timeout, it can display a message saying the star data is too much, and prompt the user to input a time range which to fetch the star info, if it's still after timeout, we can default it to probably one month. Is that better?

And if you know how to, we could also cache the data (maybe when starcli is running something else concurrently) so we don't have to scrape it again and again

Oh, I see. We could initially try getting all the star data, then after a timeout, it can display a message saying the star data is too much, and prompt the user to input a time range which to fetch the star info, if it's still after timeout, we can default it to probably one month. Is that better?

Yes, could be done.

And if you know how to, we could also cache the data (maybe when starcli is running something else concurrently) so we don't have to scrape it again and again

I'll have a go at this.

Take your time 😄

@hedythedev should we start off with making the graph listings as a new option? We can choose, say the 3 top repos, and show the graphs for them.

Sure, we could probably start by creating a function that takes in a string of the repo name (user/repo), fetch the stats, then if possible, display the graph. If the above is achieved, then we can do the command line option so that, maybe, the user can call it like starcli --graph ‘psf/black’ (Or some other repo), and a graph is displayed. We might deal with displaying a graph for the repos fetched from search() later

If shivam212 isn't working on this anymore, I'd like to take this on.

No he isn’t, I will assign you @arcanearronax, thanks for you interest

Sorry about the delay with this. I've been busy with work stuff and home life. I have put together what I would consider an MVP, but I do want to make some other changes to improve it. Would you want me to submit a pull request or start a new branch to make it available for further work?

Sure @arcanearronax sorry don't worry the delay

Hi! My friend and I come up with some ideas to better improve this graph feature, but have not decided which detailed features to add here. Could we work on this?

@hedyhli
I have added two graph features enabling star or fork graph.
Currently, we can choose to show the star/fork graph of a single repo or show the star/fork of multiple repos we got from the search() in one graph.
The content is shown in the draft pull request.
Please have a look at it and give some suggestions so that we can improve it :)
Thx!

Hello there! Was this issue solved? Is it still open for contribution?

Hello! Can I help you with solving this issue?


[Gally]: master <- dev

Automatically created by Git-Ally

:tada: This PR is included in version 6.3.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Spring Boot 1.3.X

Does spring-cloud-starter-parent support Spring Boot 1.3.X? The developer tools would greatly increase my productivity at the moment. Currently I'm using 1.0.1.RELEASE.

Brixton.M1 supports spring boot 1.3.x


feat: better portals assets display

Description
⚠ ready but blocked by @reallybeard confirmation re: naming
What this PR does:

removes the protocol icon from portals icons - we're not concerned about it, though we now know it exists if we want to add it somewhere at some point
removes zapper uni-v2 fetching - now duplicate logic from Portals
makes the naming of Portals assets consistent

What this PR does not add:

fancy new <AssetIcon /> design to handle multiple icons more gracefully
ellipsis on long asset names

Pull Request Type

[ ] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[x] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

tackles https://github.com/shapeshift/web/issues/7452

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types or contract interactions might be affected by this PR?

Low
Testing

Have a go through a few UniswapV2 (including ETH/FOX), Balancer, Pangolin and Trader Joe assets and ensure we use a consistent naming
Ensure for all said assets, there is no protocol icon as a first icon, but only underlying asset icons

Engineering

☝🏽

Operations

☝🏽

Screenshots (if applicable)
https://jam.dev/c/9c48d976-7c65-4ee2-b1d3-80697533b215

For another PR, it could be worth updating relatedAssetKey: null to undefined so it can be omitted from the generated assets and save some space.
Also, we should generate the color map and regen assets as part of this PR (wondering if we should just add the generateColorMap to the generateAssetData so it happens every time and we don't always default to #FFFFFF). We could even fetch all of the assets and pass through so we don't double fetch as a perf improvement

@kaladinlight moving to draft as I spotted a few more weird ones here re: icons


disallow non-reference late value

This one sneaks by:
class C() {
    late value s => "";
}

Thanks, fixed.


[BUGFIX] Fix lazy computation of equilibrium map

I really like the added ability to run the NonequilibriumSwitchingFEP class locally but found a bug when I was running the code. After debugging I determined that the lazy map call to feptasks.run_equilibrium where self._equilibrium_results is passed as an argument and returned was disrupting the next lazy map call to feptasks.run_protocol which again uses self._equilibrium_results as one of its arguments. When the maps are evaluated in the self._gather step, the first equilibrium map successfully returns its endpoint_perturbations, however the nonequilibrium_results was returning an empty list, likely due to it not recognizing that it depends on the equilibrium_results and must wait for them. By wrapping a list around the first equilibrium map call, this forces the computation of the new self._equilibrium_results before the next nonequilibrium map is called, thus fixing the problem for the local implementation. I am now testing to see how this affects dask.

Awesome! Thanks! Taking a look now.

Looks like the error is because of the openeye license on travis. Mind if I just incorporate this fix into my open PR?

I've incorporated this into the other PR. Thanks a lot for your help!


Fix RFC1123 Race Conditions

Under full concurrent load, RFC1123 can crash due to two race conditions:
gmtime race:
https://pastebin.com/ktyTWQEM
cachedTimeComponents race:

Thanks @MrMage and @grundoon for the support!

Hey @andreigherghe, you just merged a pull request, have a coin!
You now have 1 coins.


[envuidgid] set envs HOME & USER

Basically, envuidgid should setup the env to not break apps running as another user similar but lighter than sudo.  At a minimum, setting HOME and USER from struct passwd fields from getpwname().  Not doing this most likely inherits the environment from root, which is likely bad news.
HN discussion

This is resolved by a new setuser program in the next version.


Xcode 6.2 and GitDiff Plugin issue

I've already submitted an issue on GitDiff's GitHub (https://github.com/johnno1962/GitDiff/issues/31), but I'll ask here again, because maybe it's an issue with Alcatraz.
I'm getting this alert for GitDiff Plugin on Xcode 6.2:

Could not load colors interface. This is a problem when using Alcatraz since Xcode6. If problems persist, please download and build from the sources on GitHub.

And Xcode is crashing frequently when installed with GitDiff. So... is there any way to make it work again? Everything was fine with Xcode 6.1.1.

Hi this more of an Xcode problem since 6.0 than Alcatraz. For some reason when you build a rebuild a project in the background using an NSTask the nib files are not copied into the plugin bundle as it seems to think they are already there. The only solution is to build lmanually from source as suggested.

@johnno1962 After I git clone the project, then what's next?  Apology for my novice question.  I'm not sure after Product > Build, am I supposed to copy the bundle to somewhere.  More details in README.md would be very appreciated.

@johnno1962 Never mind it.  Simply building the project seems to install the plugin for me.


Restart Debugger should automatically re-compile and re-publish the new .APP extension

Actually seems that Restart (Ctrl+Shift+F5) VSCode debugger action don't do nothing usefull because when you continue debugging after have been changing you code, the code behaves like the old one and not the new one...

The expected behaviour of this action should be automatic re-compile & re-publish & update the debugger sesion in the same Browser Page that you were before...
Versions:
AL Language: 2.0.48254
Business Central: ES Dynamics NAV 13.0 (24630) OnPremise


'hourReformatted' may be used uninitialized in this function [-Wmaybe-uninitialized]

We resumed Standard Time yesterday, but the RTC is not updating, it's one hour ahead.
Also, my 4 digit 7 segment display is still in 24 hour mode. I believe the two following error messages go to that:
'hourReformatted' may be used uninitialized in this function [-Wmaybe-uninitialized]
'isPM' may be used uninitialized in this function [-Wmaybe-uninitialized]
My code follows:
#include <Arduino.h>
#include <Wire.h>
#include "RTClib.h"
#include <TM1637Display.h>
// Define the connections pins:
#define CLK 21
#define DIO 22
// Create rtc and display object:
RTC_DS3231 rtc;
#define SDA 14
#define SCL 13
TM1637Display display = TM1637Display(CLK, DIO);
const uint8_t blank[] = {0x00, 0x00, 0x00,0x00};
void setup() {
// Begin serial communication at a baud rate of 9600:
Serial.begin(9600);
// Wait for console opening:
delay(3000);
Wire.begin(SDA,SCL);
// Check if RTC is connected correctly:
if (! rtc.begin()) {
Serial.println("Couldn't find RTC");
while (1);
}
// Check if the RTC lost power and if so, set the time:
if (rtc.lostPower()) {
Serial.println("RTC lost power, lets set the time!");
// The following line sets the RTC to the date & time this sketch was compiled:
//rtc.adjust(DateTime(F(DATE), F(TIME)));
// This line sets the RTC with an explicit date & time, for example to set
// January 21, 2014 at 3am you would call:
rtc.adjust(DateTime(2020, 11, 01, 17, 27, 30));
}
display.setBrightness(0);  // Set the display brightness
display.setSegments(blank);//clear display
}
void loop() {
DateTime now = rtc.now(); // Get current date and time
int displaytime = (now.hour() * 100) + now.minute(); // Create time format to display
Serial.println(displaytime); // Print displaytime to the Serial Monitor:
display.showNumberDecEx(displaytime,(0x80 >> 1), true); //Display the current time in 24 hour format with leading zeros enabled and a center colon:
delay(1000);
display.showNumberDec(displaytime, true);
delay(1000);
display.showNumberDec(displaytime, true); //Display the current time in 24 hour format with leading zeros enabled and a center colon:
}

We resumed Standard Time yesterday

I resumed Standard Time eight days ago.

the RTC is not updating

Of course it is not. The dates for switching DST on and off are locale dependent, and sometimes change randomly due to unpredictable political decisions. For example, on this year alone:

Palestine ends DST earlier than predicted, on 2020-10-24.
Fiji starts DST later than usual, on 2020-12-20.
Morocco springs forward on 2020-05-31, not 2020-05-24.

Daylight Saving Time is a complex issue, and RTClib does not support it. See for example:

issue #144: Leap year and daylight saving time
pull request #36: Add European Daylight Saving Time / Summertime

my 4 digit 7 segment display is still in 24 hour mode

The code you show does not attempt to display the time in 12 hour mode, so this is normal behavior.

'hourReformatted' may be used uninitialized in this function [-Wmaybe-uninitialized]
'isPM' may be used uninitialized in this function [-Wmaybe-uninitialized]

Duplicate of issue #191: Fix compiler warnings. The warnings are harmless, and unrelated to the “24 hour mode”.

Thank you. I thought the RTC (DS3231) device did more than I thought. I thought it actually connected to a NTP via radio or something.


fftw: 3.3.4 -> 05-06-2016

Motivation for this change
There has not been a release since 2014, but at least one important bug
has been fixed:
https://github.com/FFTW/fftw3/issues/16
The submitter of the bug, @x-42, has advised me to upgrade our distro,
as the fftw devs are very conservative so this is not bleeding edge code.
Things done

[x] Tested using sandboxing
I tested with the pkg x42-plugins.
Built on platform(s)

[x] NixOS
[ ] OS X
[ ] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[x] Fits CONTRIBUTING.md.

IMHO, fftw should make a release then.
I think it's bad when distros have to package unreleased upstream versions to work around bugs in the latest releases... There should to be one policy per project: package latest release or package latest tip of VCS because the project doesn't make releases (ideally update on each commit, because a commit "is a release"). Mixing the two is bad.

@magnetophon opened an issue with a request for a release, https://github.com/FFTW/fftw3/issues/64.
Due to the importance of FFTW I don't think we should update it to an unreleased version. We could maybe have a fftw-git?

@bjornfor I agree an upstream release would be the best solution, but:
@FRidh I asked @x42 on irc whether only audio pkgs would benefit, or if I should use this system wide.
He said to use it system-wide.

I meant system wide on your system :)

Let's try to make upstream make a decision on https://github.com/FFTW/fftw3/issues/64 then :-)

@x42 I did mention wanting to fix it upstream in NixOS.
Must have gotten lost in the noise... :)

I believe the version should be 2016-06-05, by the way.

@magnetophon  right, since various software is affected, it's indeed a good goal to have others benefit from this.  Still, as robust as fftw generally is, updating a complete distro to some random git  without wider testing still does not strike me as a good idea. Then again NixOS doesn't work like this, does it?
We do include https://github.com/FFTW/fftw3/commit/119aa4c4a89 with Ardour-4.7 bundles and that's holding up fine in the last 6 months since release (tested with nightlies since late Nov'15).
Anyway an upstream release would be great!

A release is on it's way!

Good news. @magnetophon could you update the PR to use the RC?
https://github.com/FFTW/fftw3/releases/tag/fftw-3.3.5-rc1
While we won't merge that, it does make it easier to test this RC and the required change to the eventual release should be minimum.

@FRidh There you go.
NOTE: not tested yet, as I'm in the middle of building for another issue.

Builds and runs fine on "16.09pre87524.2ef1c6b (Flounder)"

A release was made.

@vcunat should this go via staging?

travis says error: committing transaction: database or disk is full!?!?

Staged, as nox-review shows that lots of packages will be rebuilt.

3.3.5 also builds and runs fine on 16.09.git.67752f6 (Flounder)

OMG, I had staged the older version with more -RC version and more complex expression, and that's in master now. Now I fixed that up in staging.


Add additional page in wizard with textbox input to modify the computer hostname

If the customer has a lot of (identical) machines, all computers use the default name 'SCM-PC'. This enhancement would need to change that name.
The idea here is to simplify all the clicks to get to these parameters =

Added the extra dialog page with textbox input in INNO SETUP. The textbox is automatically filled with the current hostname of the computer.

:9 Remaining thing to do: create a link between the user input and pass thru that input as an argument to run the .ps1 command or inject the name as a parameter.

Found useful information=
https://www.jorgebernhardt.com/how-to-rename-computer-with-powershell/
The script is only going to be functional if the new machine is not tampered with by IT or somebody already added the PC in a domain = ONLY for a local computer

Insert code to prevent wrong user input. Field to modify the computername in the wizard must be verified.
Useful info here=
https://stackoverflow.com/questions/34684128/inno-setup-create-user-input-query-page-with-input-length-and-format-limit-and


[WIP] Updating prmove for collections

Update template text
Copy over routing.yml, add section for collection repo mappings
Add logic to prmove.py to resolve files in original PR to collection/repo
in routing.yml.

Have you see https://github.com/ansible/prmove/tree/collections


Question: is it possible to use your module as a websocket client?

Hello.
I've tried to search for examples of such usage but without any luck.
Thank you!

No client support for now


Bugfix ecobee: inverted high and low temps

Description:
It seems like the temperatures are inverted in ecobee.
Related issue (if applicable): fixes #
#3315

I get this error on startup:
16-09-12 09:13:12 ERROR (MainThread) [homeassistant.loader] Circular dependency detected: ecobee -> ecobee

:dolphin:


Add DelayedLauncher.app v2.2

Is it preferred that I squash these into a single commit?

Is it preferred that I squash these into a single commit?

Yes.
However, seeing as url doesn’t point to a specific version, this cask should use version :latest and sha256 :no_check. See an example.

Thank you for the contribution. It needed some fixes, so they were made in 28ceba6b6337e1e101ab85065d737b43e861c7c4. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.

Thank you for the corrections, I'll make sure to use that approach for version-less URLs in the future.


Compiling ASP.NET web app with AssemblyInfo.cs in a shared project ends with a warning

I upgraded my local .NET Core SDK from version 2.1.201 to 2.1.300. After upgrade, the build process started reporting a warning for one of our web projects:
CA1016: Assemblies should be marked with AssemblyVersionAttribute

The setup of our solution is not entirely straight-forward in regards to AssemblyInfo.cs files. We have a shared project containing an AssemblyInfo.cs with the common properties and then each project, including the failing one, has its own.
Common file:
using System;
using System.Reflection;
using System.Resources;
using System.Runtime.InteropServices;

[assembly: AssemblyVersion("<IP_ADDRESS>")]
[assembly: AssemblyFileVersion("<IP_ADDRESS>")]
[assembly: AssemblyDescription("")]
[assembly: AssemblyCompany("ERNI")]
[assembly: AssemblyCopyright("...")]
[assembly: AssemblyTrademark("")]
[assembly: NeutralResourcesLanguage("en")]
[assembly: CLSCompliant(false)]
[assembly: ComVisible(false)]

Specific file for the failing project:
using System.Reflection;

[assembly: AssemblyTitle("name")]
[assembly: AssemblyProduct("name")]

All projects have GenerateAssemblyInfo set to false. This setup worked correctly before updating to .NET Core SDK 2.1.300. After I upgraded, the build started reporting the warning above. We usually have TreatWarningsAsErrors set to true, so the build broke on the warning.
I managed to trace the problem down to the presence of Razor views in the failing project - if I remove them, the project builds correctly. This leads me to an assumption that the new build-time compilation of views is the culprit here. Is the compiler, per chance, generating a separate assembly for the views? It looks like the compiler will not include the AssemblyInfo from the shared project in this new assembly and it will fail the analyzers in Microsoft.CodeAnalysis.FxCopAnalyzers.
I'm attaching a minimal repro solution that demonstrates the issue:
ViewCompilationIssue.zip
This code will fail to build due to the TreatWarningsAsErrors. If you exclude the Views folder from the project, it compiles.
We can work around the issue by either rewriting our assembly infos or changing the analyzer rules but this seems like a regression to me so I wanted to report it.

cc @pranavkm @rynowak looks like https://github.com/aspnet/Razor/pull/2272/files didn't catch that '$(GenerateAssemblyVersionAttribute)' == 'true' will still evaluate to false because the SDK targets only define those individual properties when GenerateAssemblyInfo is set to true (see SDK targets) thus causing a warning about missing AssemblyVersionAttribute to be generated which fails the build on TreatWarningsAsErrors==true.
@mareklinka as a workaround, you can extend your csproj file to set both
  <PropertyGroup>
    <GenerateAssemblyInfo>false</GenerateAssemblyInfo>
    <GenerateAssemblyVersionAttribute>true</GenerateAssemblyVersionAttribute>
  </PropertyGroup>

The GenerateAssemblyVersionAttribute doesn't matter to the .NET Sdk's assembly info generation since it is turned off but Razor tooling still uses it. In this case it will generate a 1.0.0 assembly version (default).

Is the compiler, per chance, generating a separate assembly for the views?

Yes. The Sdk does pick up the side-effects of GenerateAssemblyInfo correctly. But you see the build warning \ error since it's no longer adding a version to the assembly. If you were to add the shared AssemblyInfo to the list of files added to Razor compilation, things build:
 <!-- SharedProject1.projitems -->
 <ItemGroup>
    <Compile Include="$(MSBuildThisFileDirectory)AssemblyInfo.cs" />
    <RazorCompile Include="$(MSBuildThisFileDirectory)AssemblyInfo.cs" />
  </ItemGroup>

I added the RazorCompile property on our shared project and now we can compile without issues. Thanks!
Just out of curiosity, is this the expected behavior or will this change in a future version?

Just out of curiosity, is this the expected behavior or will this change in a future version?

I'd think this is expected behavior - with RazorCompileOnBuild or RazorPublishOnBuild enabled, you're effectively getting two binaries per project - one for the app and one for Razor views. They compile different sets of files but we want to share meaningful properties, like versions, between the two assemblies. Our thought was that turning off assembly info for the main one should also disable it for the compiled view, you're more than likely doing something not standard.
If there's a better approach we could take to addressing this, we'd be happy to consider it. Feel free to file an issue in https://github.com/aspnet/Razor/issues with suggestions.

Fair enough. Thanks for the clarification, if we can think of something, we'll file it.

It can't be expected behaviour to upgrade from .Net Core 2 to 2.1 and get this compilation error!


Migrate to Poetry: Add pyproject.toml and remove requirements.txt and…

WHAT DOES THIS PR DO?

[x] This PR migrates the project's dependency management and package configuration to Poetry by adding a pyproject.toml file.
[x] It removes the existing requirements.txt and setup.py files, as they are no longer needed with Poetry.

WHY IS THIS CHANGE NEEDED?

Using Poetry simplifies dependency management and provides a unified configuration file (pyproject.toml) for various tools and configurations.
Poetry offers better dependency resolution and a more modern approach to managing Python projects compared to traditional methods using requirements.txt and setup.py.

KEY CHANGES

Added pyproject.toml:

Includes project metadata (name, version, description, authors, license, and keywords).
Specifies dependencies and development dependencies.
Configures tools like black, flake8, mypy, isort, and pytest.

Removed requirements.txt:

All dependencies are now managed in pyproject.toml.

Removed setup.py:

Project configuration and dependencies are now defined in pyproject.toml.

TESTING

Ensure that all dependencies are correctly installed by running poetry install.
Verify that the project builds and runs as expected.
Run the test suite using poetry run pytest to ensure all tests pass.

ADDITIONAL NOTES

Reviewers should check the new dependency management setup and ensure all configurations are correctly migrated.
Verify that the project’s CI/CD pipeline (if any) integrates well with Poetry.

Summary by CodeRabbit

Chores

Updated project dependencies to include essential Python packages and development tools.
Improved configuration settings for code quality and testing tools.

New Features

Transitioned to using Poetry for dependency management, streamlining setup instructions and enhancing the development workflow.
Enhanced clarity and efficiency of the build process by consolidating installation commands.

Just to add, now that this is done, you can proceed to additional changes, like upgrading the airflow and python version currently used. Last time I tried this was one of the issues, along with the db setup (init containers) step I shared on slack

Btw your PR's name seems quite long 🙃
did you generate it with AI? 😅
Maybe just give the high level then the rest can go in the description


[e2e]: go tag main config-ldflags-assets slsa3

Repo: https://github.com/slsa-framework/example-package/tree/v13.0.919
Run: https://github.com/slsa-framework/example-package/actions/runs/12326042627
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v13.0.919
Date: Sat Dec 14 02:30:33 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/v13.0.920
Run: https://github.com/slsa-framework/example-package/actions/runs/12335076316
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v13.0.920
Date: Sun Dec 15 02:34:14 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/v13.0.921
Run: https://github.com/slsa-framework/example-package/actions/runs/12344762514
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v13.0.921
Date: Mon Dec 16 02:33:00 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/v13.0.922
Run: https://github.com/slsa-framework/example-package/actions/runs/12365154831
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v13.0.922
Date: Tue Dec 17 02:31:51 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/v13.0.923
Run: https://github.com/slsa-framework/example-package/actions/runs/12385160739
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v13.0.923
Date: Wed Dec 18 02:30:31 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/v13.0.924
Run: https://github.com/slsa-framework/example-package/actions/runs/12405055150
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v13.0.924
Date: Thu Dec 19 02:30:18 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/v13.0.925
Run: https://github.com/slsa-framework/example-package/actions/runs/12424351150
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v13.0.925
Date: Fri Dec 20 02:27:47 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/v13.0.926
Run: https://github.com/slsa-framework/example-package/actions/runs/12441325595
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v13.0.926
Date: Sat Dec 21 02:25:42 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/v13.0.927
Run: https://github.com/slsa-framework/example-package/actions/runs/12450449165
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v13.0.927
Date: Sun Dec 22 02:29:51 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/v13.0.928
Run: https://github.com/slsa-framework/example-package/actions/runs/12460069471
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v13.0.928
Date: Mon Dec 23 02:27:57 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/v13.0.929
Run: https://github.com/slsa-framework/example-package/actions/runs/12475877363
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.tag.main.config-ldflags-assets.slsa3.yml
Trigger: push
Branch: v13.0.929
Date: Tue Dec 24 02:28:42 UTC 2024
Tests are passing now. Closing this issue.


update bats

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 54.64%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
40507

Relevant Lines:
74135

💛  - Coveralls


Document that link unfurling is not yet supported on mobile

Document that link unfurling is not yet supported on mobile

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 59bbff2e-4b80-f980-2ade-7c7a7950801e
Version Independent ID: e837e1fd-ec0c-2d6f-b0db-b76cb2d268a4
Content: Link unfurling - Teams
Content Source: msteams-platform/messaging-extensions/how-to/link-unfurling.md
Product: msteams
GitHub Login: @clearab
Microsoft Alias: anclear

It isn't?!

Updated the docs.


MeshForwarder: Remove unused UpdateFramePending() method.

Codecov Report

Merging #1503 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1503      +/-   ##
==========================================
- Coverage   69.76%   69.45%   -0.32%
==========================================
  Files         147      146       -1
  Lines       19876    19866      -10
  Branches     2423     2423
==========================================
- Hits        13867    13797      -70
- Misses       5105     5161      +56
- Partials      904      908       +4

Impacted Files
Coverage Δ

src/core/thread/mesh_forwarder.cpp
75.05% <ø> (+0.3%)
:arrow_up:

src/core/thread/mesh_forwarder.hpp
0% <ø> (ø)
:arrow_up:

examples/platforms/posix/misc.c
0% <0%> (-66.67%)
:arrow_down:

examples/platforms/posix/random.c
85% <0%> (-15%)
:arrow_down:

src/core/thread/lowpan.hpp
86.84% <0%> (-13.16%)
:arrow_down:

src/core/net/ip6.cpp
56.44% <0%> (-10.71%)
:arrow_down:

src/core/net/icmp6.cpp
78.88% <0%> (-4.45%)
:arrow_down:

src/core/net/netif.cpp
59.37% <0%> (-3.65%)
:arrow_down:

examples/platforms/posix/uart-posix.c
59.55% <0%> (-3.38%)
:arrow_down:

src/core/common/message.cpp
94.19% <0%> (-1.66%)
:arrow_down:

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d78974...4676031. Read the comment docs.


Label for shipping information and billing information does not break words

This issue is seen on the "Review" step.
On the demo store, it says "Shipping information" and "Billing information".
It looks like the space in the label allows for an automatic break.
But in other languages, there might not be a space.
"Shipping information" translates to "Leveringsinformation" in danish,
No space in the label, so the UI breaks on small screens.
Trying to force a break with  is ignored as well.
In some way, the words should be able to break.
Nice UI with a short label

Broken UI with a long label

I'm enabling word break and wrap the layout of UmbracoCommerceCheckoutOrderInfo.cshtml into one column for mobile screen. Even so, bear in mind that we didn't not test the package on mobile view thoroughly, so, there maybe other places suffer from the same issue.

Fixed on 10.0.3, 12.0.2 and 13.1.1.


Make it possible to re-order things without using drag & drop

Describe the problem to be solved
:wave:
Drag & drop is currently used to order a few things in the app:

columns of a table
pages in the left sidebar
other things I didn't notice?

This is great but it I didn't find any alternative way of ordering those elements. That means a few things:

if I can't use a mouse at all and rely exclusively on the keyboard to interact with Grist, I can't order things,
if I can't use a mouse precisely enough, or if it's difficult for me to have the mouse button pressed while doing the whole drag action, I can't order things.

WCAG source: https://www.w3.org/WAI/WCAG22/Understanding/dragging-movements
Describe the solution you would like
We can think about multiple different solutions to let people re-order things without drag & drop:

in the left sidebar, have the "drag" icon of a page focusable with keyboard. We could then activate it with Enter key and enter a "re-order mode", where pressing the up and down keys would move the item
in an item menu (were we can rename a page or a column), we could add items to move the item up/down or left/right.

Having the action available through the item menu would certainly be the simplest to implement, while covering all usecases: both users who rely exclusively on keyboard, and mouse users who have too much trouble performing drag&drop movements.

You definitely are the GOAT (Gristman of all time). Thanks for the input.
I actually used some of those but forgot them. And you made me discover things.
Thanks!

Link to figma mocks : https://www.figma.com/design/wcpetFt6aOKzTszcvPPWLQ/[05%2F24]-Grist-Design?node-id=2477-140249&t=qX4iHFYd8uzsW8kZ-1

I like the fact that the drag icons are always-visible in the suggested mockup! I personally felt it wasn't that obvious we could re-order them in this part of the UI.
Specifically about keyboard, one idea would be to be able to focus a drag icon, being able to activate it with Enter, and then press arrows keys to re-order things.

I added #1297 for the UI part so I moved this ticket to Ready to Dev


No sound with 480P and 720p videos playlist

Please follow the guide below
Make sure you are using the latest version: run youtube-dl --version and ensure your version is 2017.10.07. If it's not, read this FAQ entry and update. Issues with outdated version will be rejected.

[x] I've verified and I assure that I'm running youtube-dl 2017.10.07

Before submitting an issue make sure you have:

[x] At least skimmed through the README, most notably the FAQ and BUGS sections
[x] Searched the bugtracker for similar issues including closed ones

What is the purpose of your issue?

[ ] Bug report (encountered problems with youtube-dl)
[ ] Site support request (request for adding support for a new site)
[ ] Feature request (request for a new functionality)
[x] Question
[ ] Other

The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your issue

If the purpose of this issue is a bug report, site support request or you are not completely sure provide the full verbose output as follows:
Add the -v flag to your command line you run youtube-dl with (youtube-dl -v <your command line>), copy the whole output and insert it here. It should look similar to one below (replace it with your log inserted between triple ```):
PS D:\> .\youtube-dl.exe -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v']
[debug] Encodings: locale cp936, fs mbcs, out cp936, pref cp936
[debug] youtube-dl version 2017.10.07
[debug] Python version 3.4.4 - Windows-10-10.0.15063
[debug] exe versions: ffmpeg N-81045-g450cf40, ffprobe N-81045-g450cf40
[debug] Proxy map: {'http': 'http://<IP_ADDRESS>:1080', 'https': 'https://<IP_ADDRESS>:1080', 'ftp': 'ftp://<IP_ADDRESS>:1080'}
Usage: youtube-dl.exe [OPTIONS] URL [URL...]

youtube-dl.exe: error: You must provide at least one URL.
Type youtube-dl --help to see a list of all options.
<end of log>

If the purpose of this issue is a site support request please provide all kinds of example URLs support for which should be included (replace following example URLs by yours):

Playlist: https://www.youtube.com/playlist?list=PL66JwVEGlfHxsyopNzMOTQIew0UQJdhj4

Note that youtube-dl does not support sites dedicated to copyright infringement. In order for site support request to be accepted all provided example URLs should not violate any copyrights.

Description of your issue suggested solution and other information
Below command can download videos successfully. If download 360p, all videos have sound.
But 480p and 720p have no sound.
I use potplayer  64-bit, version 1.7.3795 on Windows 10
.\youtube-dl.exe  -f "best[height=480]"  -i -o "%(playlist_index)s-%(title)s.%(ext)s"  https://www.youtube.com/playlist?list=PL66JwVEGlfHxsyopNzMOTQIew0UQJdhj4

.\youtube-dl.exe  -f "best[height=720]"  -i -o "%(playlist_index)s-%(title)s.%(ext)s"  https://www.youtube.com/playlist?list=PL66JwVEGlfHxsyopNzMOTQIew0UQJdhj4

Explanation of your issue in arbitrary form goes here. Please make sure the description is worded well enough to be understood. Provide as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.

Carefully read new issue template and provide all requested information.

@dstfw What do you need info ?


URL type API documentation shows option to add content.

URL type documentation does not have content. Hence showing an option to add content for such documentation is not needed.

Add an API and add documentation with type "URL".

In the confirmation dialog box getting the button "Add content"

If someone clicks on "Add Content", we are getting an empty screen

Fixed with https://github.com/wso2/carbon-apimgt/pull/7897 in 3.1.0

@CrowleyRajapakse FYI


✨ Docker container for KubeStellar

Summary
Provide:

Dockerfile to create a KubeStellar container image
Makefile to automate the processes of creating the image, running the container, cleaning up
README.md detailing the steps and options

I'm currently hosting the following images... that will hopefully move to the KubeStellar registry:

quay.io/stellari/kubestellar:v0.3.0
quay.io/stellari/kubestellar:v0.3.1 (==latest)

Related issue(s)
https://kubernetes.slack.com/archives/C058SUSL5AA/p1688543882794829
https://kubernetes.slack.com/archives/C058SUSL5AA/p1688657230224689
Fixes #

/retest

@francostellari check to make sure boilerplate is correct - pull-kubestellar-verify is complaining - https://github.com/kubestellar/kubestellar/blob/main/hack/boilerplate/boilerplate.Dockerfile.txt

/retest-required

@xrstf what is DCO sign-off?

kubestellar/kubestellar images are now available on quay

I will delete my personal images

I pushed a new commit to clear the 2 Security Hotpots from SonarCloud

@clubanderson
For the DCO check, IIRC, you either need to be pat of the kubestellar org or have all commits in the PR be signed-off (git commit -s). Alternatively you can disable the dco plugin https://github.com/kcp-dev/infra/blob/main/prow/plugins.yaml entirely.

Yeah. That's what I thought. Franco is part of the contributors team. He has triage on kubestellar/kubestellar. This is the same as most of our contributors. Scratching my head on this one. I'll take a closer look tomorrow.

None of the targets in the Makefile benefit from being targets in a Makefile.  The main function of make --- conditionally invoking targets based on file presence --- is not engaged anywhere in that Makefile.  IMHO it would be better if those were shell scripts rather than a targets in a Makefile.  Shell scripts are less dependent on the flavor of make installed on the user's system, can more easily be invoked (both be found and be coded to work correctly) from whatever working directory the user desires (thus giving some more flexibility to the user), and have less obscure syntax & semantics.

This brings in Issue #788 , since the syncers will not be able to open a connection to the kcp server's IP address.

If we really intend to keep this then the information in the READE should be moved into the regular documentation.

None of the targets in the Makefile benefit from being targets in a Makefile. The main function of make --- conditionally invoking targets based on file presence --- is not engaged anywhere in that Makefile. IMHO it would be better if those were shell scripts, or subcommands of one shell script, rather than a targets in a Makefile. Shell scripts are not dependent on the flavor of make installed on the user's system, can more easily be invoked (both be found and be coded to work correctly) from whatever working directory the user desires (thus giving some more flexibility to the user), and have less obscure syntax & semantics.

It's a fair comment, I started using the make/Makefile instead of a bash script for convenience of handling arguments without much coding. I will switch to bash at a later time.

The way that the Makefile handles arguments is to take no arguments and look in environment variables instead.  You could immediately switch to doing the same thing in a bash script.

This stuff adopts the point of view of something outside of the kubestellar repo.  That is surprising, since it is actually inside the kubestellar repo.  Wouldn't it be more natural to adopt the stance of something that is part of the repo?  For example, that would mean that there is no fetching of the repo involved here, the repo has already been fetched by the time the stuff here is being used (to build, at least).

at some point we can consider splitting this into it's own repo, for now we are a small team and are not staffed to take on the added responsibilities that come with splitting out.

Please do not merge main into development branches.  That violates our discipline for how we use branches.

As @clubanderson said elsewhere, I think that for now we can keep the external stuff in a subdirectory rather than a distinct repo.

I think that the container image building is something that is logically internal to this repo; it should be covered by the main Makefile and instructions for contributors.
If @francostellari wants to give users a Makefile to replace the bootstrap script then that is a design direction that he can explore, but I think it is a different Makefile than the one that contributors use to build KubeStellar.

@francostellari is there anything you need to address here from @MikeSpreitzer's comments?

@clubanderson I think I handled @MikeSpreitzer comments older than 2 days ago.
I'm unclear what I need to do for https://github.com/kubestellar/kubestellar/pull/764#issuecomment-1649175220
Regarding https://github.com/kubestellar/kubestellar/pull/764#issuecomment-1649179465 I would say that

I agree that in the long term the making of the container should be automated in the release process and the documentation moved to the docs but I would rather get this moving and work on improving it before fully advertising it since we do not a full circle with cluster deployment working
the make file can provide an alternative to use kubestellar locally in the container in the short term if one does not want to install it but I think this is not a long term proposition, we will move to the cluster.

Please do not merge main into development branches. That violates our discipline for how we use branches.

@MikeSpreitzer can you explain what you are seeing on this comment?  I see a fork from a collaborator being PR'ed against main.  The branch is name "docker". - what am I missing here?

@francostellari I had a deeper dive on the comments.  I see 4 items you can address now and leave the others for later.  I gave direct guidance on the items to offer you a path to adjust your files.  I think once you knock out these 4, your work here is done.  Let me know what you think.

@clubanderson , regarding https://github.com/kubestellar/kubestellar/pull/764#issuecomment-1652729106 :
It is a branch, not a fork, that a PR requests to be merged.
The complaint about this branch is due to the last commit in the picture here.

That merge from main into this development branch ruins linearizability.

@francostellari : adding a new target to the main Makefile for building this container image does not require anyone to use that target until we are ready to promote that.  If the image building were in the main Makefile rather than your external-stance one, then it would be easy and natural for the image building to use what the contributor already has and does not require your external-stance Makefile to also have some internal-stance target(s).

@francostellari : I am not sure I understand your comment

the make file can provide an alternative to use kubestellar locally in the container in the short term if one does not want to install it but I think this is not a long term proposition, we will move to the cluster.

Yes, I understand the expectation that KubeStellar will require deployment into a Kubernetes cluster.  My question is, are we going straight there or are we going to support users using just a container?  I thought the intent here is to support users using just a container.
If the intent is to support users using just a container then we will have to document how a user does that.  What they download/fetch, what commands they issue, stuff like that.  I am not saying that documentation has to be in this PR.  But I am saying that this PR implies either creating that documentation or moving straight on to requiring a hosting Kube cluster.

@MikeSpreitzer are you referring to the 7/19 commit "Merge branch 'kubestellar:main' into docker"?
If so, I don't know what it means since I believe I only edited the files to implement the changes.
I also don't know how to undo or solve the issue.

@clubanderson , regarding #764 (comment) : It is a branch, not a fork, that a PR requests to be merged.
@francostellari: The complaint about this branch is due to the last commit in the picture here.  That merge from main into this development branch ruins linearizability.

@MikeSpreitzer I think I was able to remove the last commit of 7/19, I think it should solve your concern as I understand it. Please confirm. Thank you.

/lgtm


Fix broken Dockerfile to use official node image instead

As I was working on #538, I ran the server in Docker. But the default Dockerfile was broken. I updated to use the official Node image with ONBUILD hooks instead. Also added some information about it in the docs (the two commands I were using together to build and run).
I did try Node 4.0.0, but it looks like some other dependencies are still broken on 4.0.0 (namely https://github.com/socketio/socket.io/issues/2228).

Thanks for contributing!
Could you detail how libcairo gets installed? Do the badges get the correct width computation?

libcairo2 gets installed in the node upstream image, buildpack-deps:jessie (based on Debian Jessie). The specific versions are:
ii  libcairo-gobject2:amd64              1.14.0-2.1              amd64                   Cairo 2D vector graphics library (GObject library)
ii  libcairo-script-interpreter2:amd64   1.14.0-2.1              amd64                   Cairo 2D vector graphics library (script interpreter)
ii  libcairo2:amd64                      1.14.0-2.1              amd64                   Cairo 2D vector graphics library
ii  libcairo2-dev                        1.14.0-2.1              amd64                   Development files for the Cairo 2D graphics library

If widths were off by a pixel or two then I didn't notice, is there an easy way for me to check?

Thanks!


MySQL adapter ignores UseTempDb flag

What exactly is the rationale behind this?

I would prefer not having to give CREATE permissions unless absolutely necessary.

Seems like a bug, will remove that line.

Thanks @borisdj .
#1446 addresses this. There was an issue where merge tables would remain in the database because the wrong flag was passed in. That's been fixed as well


Moving saving metadata method to cache only if it's not there

Q
A

Is bugfix?
yes

New feature?
no

Breaks BC?
no

Tests pass?
yes

Fixed issues
#14434

Yes, issue produce this leaks.. http://joxi.ru/gmvz5Gdcxx795m

$this->_tableMetadata[$name] is not "the cache", its another instance of caching inside of the class but it does not indicate the state of the schema cache.

loadTableMetadataFromCache() will load metadata from cache if it's possible. If it's not, local loadTable…() will fetch data from db and saveTableMetadataToCache() will save them to cache if it's possible.
Looks good to me. @nikosid thank you for spotting this!

Merged. Thanks!


Bugs in powa_qualstats_aggregate_constvalues_current, suggested rewrite

Just to not forget, I spotted several bugs in $title
Several columns have the same name:

https://github.com/powa-team/powa-archivist/blob/0fb11f3f441a8a9c0dd3f1b64b0c25e804638875/powa--4.1.3.sql#L3896
https://github.com/powa-team/powa-archivist/blob/0fb11f3f441a8a9c0dd3f1b64b0c25e804638875/powa--4.1.3.sql#L3909
https://github.com/powa-team/powa-archivist/blob/0fb11f3f441a8a9c0dd3f1b64b0c25e804638875/powa--4.1.3.sql#L3922

The order by should be ASC

https://github.com/powa-team/powa-archivist/blob/0fb11f3f441a8a9c0dd3f1b64b0c25e804638875/powa--4.1.3.sql#L3891

I try to rewrite this query with window function, I'll address all this issues.

Agreed, nice catch!

Ok, so I think I am close the final rewrite:
SELECT
    -- Ordered aggregate for each kind of stats (most executed, most filetered, least filtered...)
    srvid, qualid, queryid, dbid, userid,
    tstzrange(min(min_constvalues_ts) , max(max_constvalues_ts) ,'[]') ,
    array_agg((constvalues, sum_occurences, sum_execution_count, sum_nbfiltered, avg_mean_err_estimate_ratio, avg_mean_err_estimate_num)::qual_values ORDER BY occurences_rank ASC) FILTER (WHERE occurences_rank <=20)  mu,
    array_agg((constvalues, sum_occurences, sum_execution_count, sum_nbfiltered, avg_mean_err_estimate_ratio, avg_mean_err_estimate_num)::qual_values ORDER BY filtered_rank ASC) FILTER (WHERE filtered_rank <=20)  mf,
    array_agg((constvalues, sum_occurences, sum_execution_count, sum_nbfiltered, avg_mean_err_estimate_ratio, avg_mean_err_estimate_num)::qual_values ORDER BY filtered_rank DESC) FILTER (WHERE filtered_rank >= nb_lines - 20)  lf, -- Keep last 20 lines from the same window function
    array_agg((constvalues, sum_occurences, sum_execution_count, sum_nbfiltered, avg_mean_err_estimate_ratio, avg_mean_err_estimate_num)::qual_values ORDER BY execution_rank ASC) FILTER (WHERE execution_rank <=20)  me,
    array_agg((constvalues, sum_occurences, sum_execution_count, sum_nbfiltered, avg_mean_err_estimate_ratio, avg_mean_err_estimate_num)::qual_values ORDER BY err_estimate_ratio_rank ASC) FILTER (WHERE err_estimate_ratio_rank <=20)  mer,
    array_agg((constvalues, sum_occurences, sum_execution_count, sum_nbfiltered, avg_mean_err_estimate_ratio, avg_mean_err_estimate_num)::qual_values ORDER BY err_estimate_num_rank ASC) FILTER (WHERE err_estimate_num_rank <=20)  men
FROM (
    -- Establish rank for different stats (occurences, execution...) for each distinct constvalue
    SELECT srvid, qualid, queryid, dbid, userid,
        min(mints) OVER (PARTITION BY constvalues) min_constvalues_ts, max(maxts) OVER (PARTITION BY constvalues) max_constvalues_ts,
        constvalues, sum_occurences, sum_execution_count, sum_nbfiltered, avg_mean_err_estimate_ratio, avg_mean_err_estimate_num,
        row_number() OVER (PARTITION BY constvalues ORDER BY sum_occurences DESC) occurences_rank,
        row_number() OVER (PARTITION BY constvalues ORDER BY CASE WHEN sum_execution_count = 0 THEN 0 ELSE sum_nbfiltered / sum_execution_count::numeric END DESC) filtered_rank,
        row_number() OVER (PARTITION BY constvalues ORDER BY sum_execution_count DESC) execution_rank,
        row_number() OVER (PARTITION BY constvalues ORDER BY avg_mean_err_estimate_ratio DESC) err_estimate_ratio_rank,
        row_number() OVER (PARTITION BY constvalues ORDER BY avg_mean_err_estimate_num DESC) err_estimate_num_rank,
        sum(1) OVER (PARTITION BY constvalues) nb_lines

    FROM (
        -- We group by constvalues and perform some aggregate to have stats on distinct constvalues
        SELECT srvid, qualid, queryid, dbid, userid,constvalues,
            min(ts) mints, max(ts) maxts ,
            sum(occurences) as sum_occurences,
            sum(nbfiltered) as sum_nbfiltered,
            sum(execution_count) as sum_execution_count,
            avg(mean_err_estimate_ratio) as avg_mean_err_estimate_ratio,
            avg(mean_err_estimate_num) as avg_mean_err_estimate_num
        FROM powa_qualstats_constvalues_history_current
        WHERE srvid = 7
        GROUP BY srvid, qualid, queryid, dbid, userid,constvalues
        ) distinct_constvalues
    ) ranked_constvalues
GROUP BY srvid, qualid, queryid, dbid, userid
;

It need more tests and review, but this query is much more fast than previous one from 20 minutes (maybe more) to 3 seconds


[Bug]:  Inappropriate Error message is displayed to user

Is there an existing issue for this?

[X] I have searched the existing issues

Description
When the user runs an API and it is observed that the user is displayed an error that is not understandable
Attaching the API : https://api.jikan.moe/v3/search/anime?q=naruto
Observation:  the API does not run on postman as well
Steps To Reproduce

Navigate to API
Add the API
and observe the error

Expectation: defining error messages

Actual response of the API

Public Sample App
No response
Environment
Production
Issue video log
No response
Version
cloud

postman returns error: {     "status": 410,     "type": "BadResponseException",     "message": "v3 has been discontinued. For more information visit https://bit.ly/jikan-v3-deprecation",     "upgrade": "Please upgrade to v4: https://docs.api.jikan.moe/" }
How come we are not propagating this response message along with the status code?


Resolving gets slower over time

Hi all!
So I regularly hit this, after an hour or so (probably less) of running dnsproxy:
> ping google.com
PING google.com(sin10s01-in-x0e.1e100.net (2404:6800:4003:80c::200e)) 56 data bytes
64 bytes from sin10s01-in-x0e.1e100.net (2404:6800:4003:80c::200e): icmp_seq=1 ttl=50 time=381 ms
64 bytes from sin10s01-in-x0e.1e100.net (2404:6800:4003:80c::200e): icmp_seq=2 ttl=50 time=561 ms
64 bytes from sin10s01-in-x0e.1e100.net (2404:6800:4003:80c::200e): icmp_seq=3 ttl=50 time=543 ms
64 bytes from sin10s01-in-x0e.1e100.net (2404:6800:4003:80c::200e): icmp_seq=4 ttl=50 time=530 ms
64 bytes from sin10s01-in-x0e.1e100.net (2404:6800:4003:80c::200e): icmp_seq=5 ttl=50 time=510 ms

> sudo systemctl restart dnscrypt-proxy

> ping google.com
PING google.com(iad30s07-in-x0e.1e100.net (2607:f8b0:4004:804::200e)) 56 data bytes
64 bytes from iad30s07-in-x0e.1e100.net (2607:f8b0:4004:804::200e): icmp_seq=1 ttl=54 time=82.2 ms
64 bytes from iad30s07-in-x0e.1e100.net (2607:f8b0:4004:804::200e): icmp_seq=2 ttl=54 time=85.2 ms
64 bytes from iad30s07-in-x0e.1e100.net (2607:f8b0:4004:804::200e): icmp_seq=3 ttl=54 time=85.3 ms
64 bytes from iad30s07-in-x0e.1e100.net (2607:f8b0:4004:804::200e): icmp_seq=4 ttl=54 time=84.5 ms
64 bytes from iad30s07-in-x0e.1e100.net (2607:f8b0:4004:804::200e): icmp_seq=5 ttl=54 time=86.6 ms

This isn't a one off, it's systematic. I just let it run long enough and I'll run into it. I don't know if it really affects my browsing that much, but it feels like pages with lots of random links (reddit) take forever to load.
I tried both lb_strategy = 'fastest' and p2, same result.
If I didn't screw up my config, I'm supposed to be using only opennic servers:
server_names = []
listen_addresses = ['<IP_ADDRESS>:53', '[::1]:53']
max_clients = 250
ipv4_servers = true
ipv6_servers = true
dnscrypt_servers = true
doh_servers = false
require_dnssec = false #
require_nolog = true
require_nofilter = true
disabled_server_names = [ 'cloudflare' ]
force_tcp = false
timeout = 1000
keepalive = 30
refused_code_in_responses = false
lb_strategy = 'fastest'
cert_refresh_delay = 240
fallback_resolver = '<IP_ADDRESS>:53'
ignore_system_dns = false
netprobe_timeout = 60
log_files_max_size = 10
log_files_max_age = 7
log_files_max_backups = 1
block_ipv6 = false
cache = true
cache_size = 512
cache_min_ttl = 600
cache_max_ttl = 86400
cache_neg_min_ttl = 60
cache_neg_max_ttl = 600
[query_log]
  format = 'tsv'
[nx_log]
  format = 'tsv'
[blacklist]
[ip_blacklist]
[whitelist]
[schedules]
[sources]
  [sources.'opennic']
  urls = ['https://raw.githubusercontent.com/DNSCrypt/dnscrypt-resolvers/master/v2/opennic.md', 'https://download.dnscrypt.info/resolvers-list/v2/opennic.md']
  minisign_key = 'RWQf6LRCGA9i53mlYecO4IzT51TGPpvWucNSCh1CBM0QTaLn73Y7GFO3'
  cache_file = 'opennic.md'
[static]

I'm guessing this is absolutely undebuggable, and there's nothing exciting happening in the logs. I could change log_level and give you a dump at some point, what level would you need?
Anything else I can do?

what's the output of

systemctl status dnscrypt-proxy

both before systemctl restart and after it gets slow.

dnscrypt-proxy only handles DNS queries.
ping doesn't measure DNS resolution, it's a completely distinct protocol.

May 24 12:04:54 yggdrasill dnscrypt-proxy[29840]: [2019-05-24 12:04:54] [NOTICE] [opennic-ethservices2] OK (DNSCrypt) - rtt: 18ms
May 24 12:04:54 yggdrasill dnscrypt-proxy[29840]: [2019-05-24 12:04:54] [NOTICE] [opennic-luggs] OK (DNSCrypt) - rtt: 87ms
May 24 12:04:54 yggdrasill dnscrypt-proxy[29840]: [2019-05-24 12:04:54] [NOTICE] [opennic-luggs-ipv6] OK (DNSCrypt) - rtt: 86ms
May 24 12:04:54 yggdrasill dnscrypt-proxy[29840]: [2019-05-24 12:04:54] [NOTICE] [opennic-luggs2] OK (DNSCrypt) - rtt: 88ms
May 24 12:04:54 yggdrasill dnscrypt-proxy[29840]: [2019-05-24 12:04:54] [NOTICE] [opennic-luggs2-ipv6] OK (DNSCrypt) - rtt: 84ms
May 24 12:04:55 yggdrasill dnscrypt-proxy[29840]: [2019-05-24 12:04:55] [NOTICE] [publicarray-au] OK (DNSCrypt) - rtt: 553ms
May 24 12:04:57 yggdrasill dnscrypt-proxy[29840]: [2019-05-24 12:04:57] [NOTICE] [publicarray-au2] TIMEOUT
May 24 12:04:57 yggdrasill dnscrypt-proxy[29840]: [2019-05-24 12:04:57] [NOTICE] [opennic-R4SAS] TIMEOUT
May 24 12:04:57 yggdrasill dnscrypt-proxy[29840]: [2019-05-24 12:04:57] [NOTICE] Server with the lowest initial latency: opennic-ethservices2 (rtt: 18ms)
May 24 12:04:57 yggdrasill dnscrypt-proxy[29840]: [2019-05-24 12:04:57] [NOTICE] dnscrypt-proxy is ready - live servers: 6

while ping is slow:
64 bytes from sin11s03-in-x0e.1e100.net (2404:6800:4003:806::200e): icmp_seq=1 ttl=50 time=483 ms
64 bytes from sin11s03-in-x0e.1e100.net (2404:6800:4003:806::200e): icmp_seq=3 ttl=50 time=318 ms
64 bytes from sin11s03-in-x0e.1e100.net (2404:6800:4003:806::200e): icmp_seq=4 ttl=50 time=883 ms
64 bytes from sin11s03-in-x0e.1e100.net (2404:6800:4003:806::200e): icmp_seq=5 ttl=50 time=420 ms

Right after restart:
May 24 15:59:41 yggdrasill dnscrypt-proxy[14529]: [2019-05-24 15:59:41] [NOTICE] [opennic-ethservices2] OK (DNSCrypt) - rtt: 17ms
May 24 15:59:41 yggdrasill dnscrypt-proxy[14529]: [2019-05-24 15:59:41] [NOTICE] [opennic-luggs] OK (DNSCrypt) - rtt: 104ms
May 24 15:59:41 yggdrasill dnscrypt-proxy[14529]: [2019-05-24 15:59:41] [NOTICE] [opennic-luggs-ipv6] OK (DNSCrypt) - rtt: 117ms
May 24 15:59:41 yggdrasill dnscrypt-proxy[14529]: [2019-05-24 15:59:41] [NOTICE] [opennic-luggs2] OK (DNSCrypt) - rtt: 89ms
May 24 15:59:43 yggdrasill dnscrypt-proxy[14529]: [2019-05-24 15:59:43] [NOTICE] [opennic-luggs2-ipv6] TIMEOUT
May 24 15:59:44 yggdrasill dnscrypt-proxy[14529]: [2019-05-24 15:59:44] [NOTICE] [publicarray-au] OK (DNSCrypt) - rtt: 482ms
May 24 15:59:46 yggdrasill dnscrypt-proxy[14529]: [2019-05-24 15:59:46] [NOTICE] [publicarray-au2] TIMEOUT
May 24 15:59:48 yggdrasill dnscrypt-proxy[14529]: [2019-05-24 15:59:48] [NOTICE] [opennic-R4SAS] TIMEOUT
May 24 15:59:48 yggdrasill dnscrypt-proxy[14529]: [2019-05-24 15:59:48] [NOTICE] Server with the lowest initial latency: opennic-ethservices2 (rtt: 17ms)
May 24 15:59:48 yggdrasill dnscrypt-proxy[14529]: [2019-05-24 15:59:48] [NOTICE] dnscrypt-proxy is ready - live servers: 6

with this as ping:
64 bytes from iad30s07-in-x0e.1e100.net (2607:f8b0:4004:804::200e): icmp_seq=1 ttl=55 time=81.1 ms
64 bytes from iad30s07-in-x0e.1e100.net (2607:f8b0:4004:804::200e): icmp_seq=2 ttl=55 time=85.3 ms
64 bytes from iad30s07-in-x0e.1e100.net (2607:f8b0:4004:804::200e): icmp_seq=3 ttl=55 time=88.1 ms
64 bytes from iad30s07-in-x0e.1e100.net (2607:f8b0:4004:804::200e): icmp_seq=4 ttl=55 time=102 ms
64 bytes from iad30s07-in-x0e.1e100.net (2607:f8b0:4004:804::200e): icmp_seq=5 ttl=55 time=83.6 ms
64 bytes from iad30s07-in-x0e.1e100.net (2607:f8b0:4004:804::200e): icmp_seq=6 ttl=55 time=105 ms

doesn't measure DNS resolution, it's a completely distinct protocol
I hadn't realised that, the answer would be cached anyway, right? So what's happening here?

Do traceroute instead ping to see more detailed.

Maybe on a quiet Sunday evening the internet tubes are less in demand and that might explain the shift in delay values:
 traceroute google.com
traceroute to google.com (<IP_ADDRESS>), 30 hops max, 60 byte packets
 1  <IP_ADDRESS> (<IP_ADDRESS>)  1.163 ms  1.136 ms  1.263 ms
 2  lns-bzn-55-82-255-183-254.adsl.proxad.net (<IP_ADDRESS>)  4.758 ms  5.497 ms  5.483 ms
 3  <IP_ADDRESS> (<IP_ADDRESS>)  3.069 ms  3.140 ms  3.278 ms
 4  vic92-49m-1-v900.intf.nro.proxad.net (<IP_ADDRESS>)  3.417 ms  3.718 ms  3.837 ms
 5  bzn-9k-4-v820.intf.nro.proxad.net (<IP_ADDRESS>)  5.193 ms  5.143 ms  5.099 ms
 6  p11-crs16-1-be1000.intf.routers.proxad.net (<IP_ADDRESS>)  5.058 ms  5.069 ms  9.542 ms
 7  <IP_ADDRESS> (<IP_ADDRESS>)  4.905 ms  4.813 ms  4.765 ms
 8  <IP_ADDRESS> (<IP_ADDRESS>)  4.674 ms  4.611 ms  4.547 ms
 9  <IP_ADDRESS> (<IP_ADDRESS>)  4.462 ms <IP_ADDRESS> (<IP_ADDRESS>)  5.592 ms  4.850 ms
10  <IP_ADDRESS> (<IP_ADDRESS>)  5.526 ms  5.488 ms  7.882 ms
11  <IP_ADDRESS> (<IP_ADDRESS>)  80.603 ms <IP_ADDRESS> (<IP_ADDRESS>)  81.181 ms <IP_ADDRESS> (<IP_ADDRESS>)  81.003 ms
12  <IP_ADDRESS> (<IP_ADDRESS>)  82.592 ms  80.287 ms <IP_ADDRESS> (<IP_ADDRESS>)  84.108 ms
13  <IP_ADDRESS> (<IP_ADDRESS>)  80.151 ms <IP_ADDRESS> (<IP_ADDRESS>)  79.290 ms <IP_ADDRESS> (<IP_ADDRESS>)  80.067 ms
14  <IP_ADDRESS> (<IP_ADDRESS>)  78.715 ms  79.171 ms <IP_ADDRESS> (<IP_ADDRESS>)  395.339 ms
15  lga25s62-in-f14.1e100.net (<IP_ADDRESS>)  395.268 ms  395.223 ms  395.183 ms

 ping google.com
PING google.com(lga25s62-in-x0e.1e100.net (2607:f8b0:4006:81a::200e)) 56 data bytes
64 bytes from lga25s62-in-x0e.1e100.net (2607:f8b0:4006:81a::200e): icmp_seq=1 ttl=54 time=79.3 ms
64 bytes from lga25s62-in-x0e.1e100.net (2607:f8b0:4006:81a::200e): icmp_seq=2 ttl=54 time=87.8 ms
64 bytes from lga25s62-in-x0e.1e100.net (2607:f8b0:4006:81a::200e): icmp_seq=3 ttl=54 time=79.2 ms
64 bytes from lga25s62-in-x0e.1e100.net (2607:f8b0:4006:81a::200e): icmp_seq=4 ttl=54 time=82.3 ms
^C
--- google.com ping statistics ---
4 packets transmitted, 4 received, 0% packet loss, time 3000ms
rtt min/avg/max/mdev = 79.195/82.141/87.751/3.478 ms

 traceroute google.com
traceroute to google.com (<IP_ADDRESS>), 30 hops max, 60 byte packets
 1  <IP_ADDRESS> (<IP_ADDRESS>)  1.225 ms  1.256 ms  1.291 ms
 2  lns-bzn-55-82-255-183-254.adsl.proxad.net (<IP_ADDRESS>)  6.089 ms  7.163 ms  7.148 ms
 3  <IP_ADDRESS> (<IP_ADDRESS>)  3.819 ms  5.124 ms  5.149 ms
 4  vic92-49m-1-v900.intf.nro.proxad.net (<IP_ADDRESS>)  5.200 ms  5.387 ms  6.010 ms
 5  bzn-9k-4-v820.intf.nro.proxad.net (<IP_ADDRESS>)  6.788 ms  6.751 ms  6.709 ms
 6  p11-crs16-1-be1000.intf.routers.proxad.net (<IP_ADDRESS>)  6.644 ms  5.045 ms  4.878 ms
 7  <IP_ADDRESS> (<IP_ADDRESS>)  4.814 ms  3.840 ms  5.068 ms
 8  <IP_ADDRESS> (<IP_ADDRESS>)  5.008 ms  4.972 ms  4.844 ms
 9  <IP_ADDRESS> (<IP_ADDRESS>)  4.316 ms <IP_ADDRESS> (<IP_ADDRESS>)  3.820 ms <IP_ADDRESS> (<IP_ADDRESS>)  3.085 ms
10  <IP_ADDRESS> (<IP_ADDRESS>)  4.086 ms  4.066 ms <IP_ADDRESS> (<IP_ADDRESS>)  7.705 ms
11  <IP_ADDRESS> (<IP_ADDRESS>)  78.849 ms <IP_ADDRESS> (<IP_ADDRESS>)  80.266 ms <IP_ADDRESS> (<IP_ADDRESS>)  80.237 ms
12  <IP_ADDRESS> (<IP_ADDRESS>)  80.681 ms <IP_ADDRESS> (<IP_ADDRESS>)  80.151 ms <IP_ADDRESS> (<IP_ADDRESS>)  80.604 ms
13  <IP_ADDRESS> (<IP_ADDRESS>)  80.736 ms  80.633 ms  80.596 ms
14  <IP_ADDRESS> (<IP_ADDRESS>)  79.870 ms <IP_ADDRESS> (<IP_ADDRESS>)  80.454 ms  80.840 ms
15  lga25s62-in-f14.1e100.net (<IP_ADDRESS>)  81.954 ms  81.913 ms  81.848 ms

 sudo sc restart dnscrypt-proxy
Password:

 ping google.com
PING google.com(fra15s24-in-x0e.1e100.net (2a00:1450:4001:820::200e)) 56 data bytes
64 bytes from fra15s24-in-x0e.1e100.net (2a00:1450:4001:820::200e): icmp_seq=1 ttl=54 time=14.6 ms
64 bytes from fra15s24-in-x0e.1e100.net (2a00:1450:4001:820::200e): icmp_seq=3 ttl=54 time=18.5 ms
64 bytes from fra15s24-in-x0e.1e100.net (2a00:1450:4001:820::200e): icmp_seq=4 ttl=54 time=15.2 ms
64 bytes from fra15s24-in-x0e.1e100.net (2a00:1450:4001:820::200e): icmp_seq=5 ttl=54 time=13.4 ms
64 bytes from fra15s24-in-x0e.1e100.net (2a00:1450:4001:820::200e): icmp_seq=6 ttl=54 time=16.7 ms
64 bytes from fra15s24-in-x0e.1e100.net (2a00:1450:4001:820::200e): icmp_seq=7 ttl=54 time=17.9 ms
^C
--- google.com ping statistics ---
7 packets transmitted, 6 received, 14.2857% packet loss, time 6054ms
rtt min/avg/max/mdev = 13.416/16.069/18.519/1.822 ms

 traceroute google.com
traceroute to google.com (<IP_ADDRESS>), 30 hops max, 60 byte packets
 1  <IP_ADDRESS> (<IP_ADDRESS>)  4.948 ms  5.317 ms  5.419 ms
 2  lns-bzn-55-82-255-183-254.adsl.proxad.net (<IP_ADDRESS>)  9.775 ms  9.761 ms  9.739 ms
 3  <IP_ADDRESS> (<IP_ADDRESS>)  6.078 ms  6.280 ms  6.676 ms
 4  vic92-49m-1-v900.intf.nro.proxad.net (<IP_ADDRESS>)  6.437 ms  6.822 ms  7.177 ms
 5  bzn-9k-4-v820.intf.nro.proxad.net (<IP_ADDRESS>)  8.292 ms  9.580 ms  9.565 ms
 6  * * p11-crs16-1-be1000.intf.routers.proxad.net (<IP_ADDRESS>)  7.183 ms
 7  <IP_ADDRESS> (<IP_ADDRESS>)  3.774 ms  7.031 ms  7.009 ms
 8  <IP_ADDRESS> (<IP_ADDRESS>)  6.983 ms  6.950 ms  6.918 ms
 9  <IP_ADDRESS> (<IP_ADDRESS>)  10.066 ms <IP_ADDRESS> (<IP_ADDRESS>)  10.045 ms <IP_ADDRESS> (<IP_ADDRESS>)  28.560 ms
10  <IP_ADDRESS> (<IP_ADDRESS>)  12.984 ms <IP_ADDRESS> (<IP_ADDRESS>)  12.991 ms <IP_ADDRESS> (<IP_ADDRESS>)  12.959 ms
11  <IP_ADDRESS> (<IP_ADDRESS>)  16.371 ms <IP_ADDRESS> (<IP_ADDRESS>)  31.485 ms <IP_ADDRESS> (<IP_ADDRESS>)  13.792 ms
12  <IP_ADDRESS> (<IP_ADDRESS>)  20.022 ms <IP_ADDRESS> (<IP_ADDRESS>)  21.703 ms  22.810 ms
13  <IP_ADDRESS> (<IP_ADDRESS>)  22.799 ms <IP_ADDRESS> (<IP_ADDRESS>)  26.861 ms  26.844 ms
14  <IP_ADDRESS> (<IP_ADDRESS>)  25.713 ms <IP_ADDRESS> (<IP_ADDRESS>)  21.306 ms <IP_ADDRESS> (<IP_ADDRESS>)  21.223 ms
15  zrh11s02-in-f14.1e100.net (<IP_ADDRESS>)  21.101 ms  19.953 ms  20.964 ms

Instead of using six servers from Opennic stick to opennic-ethservices2 which has the lowest latency for your region. I had the same issue as yours, but mine was random, yours is progressive.

I'll try that, I'll be back with updates in a bit.
I'd still like to understand how this affects ping RTT.

uBlock-user was right, selecting a single server gives me consistent ping RTTs.
So two things about this :
1/  lb_strategy = 'fastest' is broken
2/ why does this affect ping RTT?

The estimator tries to rank resolvers by latency, across all configured resolvers. The same resolver may quickly return records for google.com but be very slow with other queries.
fastest just picks the first resolver of the sorted list. It's simple but usually not a very good choice, which is why this is not the default strategy. It was renamed to first to avoid confusion.
Google returns different addresses according to the resolver IP address, so your 'ping' packets may be hitting a different datacenter.

If you want speed and consistent performance, go with CloudFlare or Google.

If you want speed and consistent performance, go with CloudFlare or Google.
I'm not trying to annoying, I'm using this because I like it.
fastest & p2 consistently end up not going with the fastest here, couldn't this point to something being buggy somewhere?

Whether the filter will slow down?

Try 2.0.25, it prints the latency of individual queries. There's also an option to disable the estimator.


Bluetooth won't come up on a M.2 Wifi/BT card

Firstly, great work on this project! Very nicely done and documented.
We tried connecting a Wifi6 and also a Wifi5 Intel M.2. cards to J1 Key-E on the board. While the Wifi came up fine after installing their drivers. We are not able to get the Bluetooth working.
I did see that the SDIO pins are not connected (only major difference compare to the Jetson Orin Nano dev kit). But I'm not sure if Bluetooth uses the SDIO.
If you happen to have any idea on this?

Could it be something related to this USB connection:
If R20 and R52 needs to be populated?

We tried connecting R20 and R52, from my previous post. The Bluetooth LED (D52), started glowing, and M.2 card started showing up under lsusb . However, it won't activate or turn on(even after drivers were installed). hcitool dev cannot find any local bluetooth hardware connected. Any idea on this?

@pkatarzynski , thank you for getting back. This is the Wifi+BT card we are using.
@pgielda , please see the lsusb and lspci outputs below. I think the wifi came up fine on the PCIE, while the bluetooth came up on the USB (after we connected R20 and R52). However, the bluetooth doesn't come up (even after installing it's drivers). Wifi works fine.

Please verify if the Bluetooth interface is not soft-blocked.
You can use  rfkill list for that.
You can unblock the device with rfkill unblock all
After that the Bluetooth device should become visible after calling  hcitool dev
We have checked this approach with Waveshare AW-CB375NF WiFi/BT M.2 card Jetson Orin Baseboard in Rev.1.1.6 and the reference BSP image mentioned in the Getting Started section of the documentation.

Hello, Working with mizrex and the device seems to not be blocked but is also not showing


Fix react-native-vanilla tests so they actually test storybook

Our test only tests if the example react-native starts and renders, not our Storybook installation.
We have to have the web UI of react-native storybook running in order to run tests. It's hard to do with jest.
   ● Console

    console.error node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2053
      The above error occurred in one of your React components:
          in Unknown (created by StorybookUIHMRRoot)
          in StorybookUIHMRRoot

      Consider adding an error boundary to your tree to customize error handling behavior.
      You can learn more about error boundaries at https://fb.me/react-error-boundaries.

  ● renders correctly

    TypeError: _global.WebSocket is not a constructor

      at WebsocketTransport._connect (node_modules/@storybook/channel-websocket/dist/index.js:87:22)
      at new WebsocketTransport (node_modules/@storybook/channel-websocket/dist/index.js:43:10)
      at createChannel (node_modules/@storybook/channel-websocket/dist/index.js:110:19)
      at node_modules/@storybook/react-native/dist/preview/index.js:143:52
      at mountIndeterminateComponent (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:4356:15)
      at beginWork (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:4557:16)
      at performUnitOfWork (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6529:16)
      at workLoop (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:6638:28)
      at Object.invokeGuardedCallback$1 (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2159:10)
      at invokeGuardedCallback (node_modules/react-test-renderer/cjs/react-test-renderer.development.js:2106:29)

Error: Accessing nonexistent addons channel, see https://storybook.js.org/basics/faq/#why-is-there-no-addons-channel
    at AddonStore.getChannel (/Users/danielduan/Workspace/storybook/examples/react-native-vanilla/node_modules/@storybook/addons/dist/index.js:39:15)
    at setOptions (/Users/danielduan/Workspace/storybook/examples/react-native-vanilla/node_modules/@storybook/addon-options/dist/preview/index.js:37:34)
    at Timeout._onTimeout (/Users/danielduan/Workspace/storybook/examples/react-native-vanilla/storybook/storybook.js:16:29)
    at ontimeout (timers.js:471:11)
    at tryOnTimeout (timers.js:306:5)
    at Timer.listOnTimeout (timers.js:266:5)

@danielduan -- are you sure this isn't just because Jest doesn't provide a WebSocket implementation? @storybook/react-native uses @storybook/channel-websocket, which of course tries to setup a websocket, but perhaps we could mock it out?

I'm not a react-native jest expert by any means and I haven't looked into this in detail yet. This issue is to raise the problem that there's a problem with our test.