Steady memory creep

Memory creep over a week
Description
It looks like there is still a memory creep issue present in the latest version of edge. Over a week, we can observe memory steadily increasing.
Your environment

OS and version Ubuntu 20
version of the Polygon Edge 0.4.1
branch that causes this issue develop

Steps to reproduce

Tell us how to reproduce this issue
Create a new chain, run a node on an EC2 box on AWS for example. Observe memory increasing steadily over a week.
Where the issue is, if you know
Which commands triggered the issue, if any

Expected behaviour
Memory should not be increasing
Actual behaviour
Memory steadily increases over a 7 day period
Logs

Additional data:
validator-prof-files.zip

Hey @mrwillis,
Thank you for opening up the issue 🙏
We've set up detailed memory monitoring to figure out where the creep is coming from.
Letting you know as soon as we have more info

Hey @mrwillis,
Just an update regarding this, we've spun up a cluster and let it run for a couple of days while monitoring memory usage.

Looks like we have some memory leaks within helper methods, we're still looking into it, just letting you know we've confirmed it 🙏

Looks like we are seeing even larger memory leaks with #668

@SwaroopH,
Can you please post the prof files you are seeing?
What version of Edge are you running on?

prof

Is there a flag to generate it?

Hey @zivkovicmilos , the issue appears to still exist for us as well for version v0.5.0 develop @ fb219b
I've used pprof on a validator node targeted by an instance of blockscout on our testnet to obtain a before (taken the morning of Aug 19) which can be compared to an after (taken just now).
You can see around 20% creep since Friday:

Could it be that you only added the pprof lib within jsonrpc.go instead of main.go? Therefore you may have missed any memory creep resulting from another service outside of the jsonrpc layer...
Attached both pprof files and svg outputs here:
Archive.zip

Hey @dankostiuk,
I've finally managed to locate the source of the problem - we are keeping a reference to an object that is a linked list, that never releases memory when new blocks come in. This is something that is present for a long, long time in Edge (Polygon SDK days 🙂 ), you would see the same memory leak if you started an old Edge cluster (pre IBFT 2.0) and left the monitor command running.
We are currently working on completely refactoring this event subscription trash into a working module.
I will keep you posted here on the progress, and apologize on behalf of the dev team that some legacy code like this is still around and causing problems 🙏

Hi @mrwillis
We wish to let you know that this memory issue is resolved with our latest Polygon Edge 0.5.1 release.
If there will be any further problems, then feel free to re-open this request.


Fix margins and box width in SUI

Summary of the Pull Request
Fixed some of the margin alignments and increased the standard box width.

Has the header alignment in this narrow view also being fixed?

Probably not. @carlos-zamora this is why we usually don’t want to retemplate controls ;)


Game Engine

BipoBlender is supposed to use the Blender GE to calculate the transitiono fo a molecule from one conformation to another.
However, as soon as the 'Run In GE' button is hit, Blender crashes

there's an import error, in 2.73,
Blender Game Engine Started
Python module can't be imported - object 'Empty', controller 'Python Script':
ImportError: No module named 'BioBlender2'
Blender Game Engine Finished

in 2.73 using the branch (2.73_Comp_Explore) To my surprise the Game engine does run, but doesn't record anything (no cache) probably because of the failed import. I'll investigate.

The recorded animation will be stored as keyframes (one KF for every atom, at each frame), starting 500 frames after the last imported model.
Pls. pay attention that animation makes sense only with at least two different conformations of a protein. If you use file '01_CaM 3 conformations.pdb', and changed nothing in the import, you will have a KF at frame 1 (conformation= model 1), a KF at frame 100 (conf 2), and another one at frame 200. After recording the GE simulation, all frames between 500 and 800 will be keyframed.

i'll add some update prints so it shows when a keyframe is added, else it is impossible to tell if it's actually performing useful work

OK i see, those keyframes are inserted upon .pdb import if there are several conformations present in the file.

please forgive what must look like complete ignorance :)

You are kidding? you are giving a very great help, and of course no one is born learnt (italian saying , meaning that one cannot know what has not been tought to her).
It's good that you know programming, and I know biology: only by collaborating we are going to make something new! :)
Now my turn of ignorance: How do I test the new branch?

got pyMOL to generate a surface!! - jumps up and down

@MonZop I will start a fresh thread explaining how to test branches:
https://github.com/MonZop/BioBlender/issues/9

When I install Blender 273 it opens and crashes immediately (not BioBlender, the regular Blender). I tried twice (new download, new installation), with the same result...

What I do is have a folder on my C:\ drive called blender_trunk, and I drag builder bot builds into it, and have a link on my taskbar pointing at the blender.exe of that folder.

The dropdown optoins comes from this line
split.prop(bpy.context.scene.objects[str(m)].game, "physics_type")

the options are generic to the physics type, from what I can tell:
http://www.blender.org/api/blender_python_api_2_73_5/bpy.types.GameObjectSettings.html?highlight=physics_type#bpy.types.GameObjectSettings.physics_type
(produces the same list)
Perhaps it would be simpler to remove the options and set Rigid Body if the game engine is invoked.

This however does not seem to be the reason for the GE to fail to do anything, it is an import issue as mentioned here: https://github.com/MonZop/BioBlender/issues/2#issuecomment-72259622

Yes, if joints are not built, then the recording of GE is not done, as it is meaningless (in biological sense)
As you say, Perhaps it would be simpler to remove the options and set Rigid Body if the game engine is invoked., I agree

could you add a few simple molecules for the purpose of testing the GE , bones / joints ?

OK, let me prepare a file with a very small protein in 4 conformations

Done: you'll find it in the Test Molecules folder. It is a small artificial protein made of only 20 aminoacids, for a total of 158 atoms (excluding Hydrogens).
The file contains 4 MODELS (conformations), but I noticed that BB2 only imports 3 of them. I also tried to import other proteins that have many conformations, but BB2 imports all models except the last one.

OK, when something does 3 of 4 ... of 6 of 7, it's usually an 'off by one' bug, (also known as OBO). will look into that.

This is a perfect example of when to start a fresh Thread, we find a problem, we make a thread. Then the thread can be closed when it gets resolved, or considered not immediately important.

Back to the Game Engine:
In the master_main_first_fixes version of BB, bones are created (they are listed in the Outliner), but the GE is completely still.
In the Blender console it says:
Blender Game Engine Started Python module can't be imported - object 'Empty', controller 'Python Script': ImportError: No module named 'BioBlender2' Blender Game Engine Finished

There's recent fixes to the BGE, today this: https://developer.blender.org/rBbf157ce9277ba1011a6e317c7629bab0dd8c36a5 it may relate to the problem.
@mikepan can probably make more sense of the BGE stuff (either the Master, or the experiments branch)

I renamed BioBlender2.py to BioBlender.py and edited the EmptySet.blend to link to BioBlender.recorder, and now the ImportError seems to go away.. Even if this isn't the solution, the naming seems to have caused a problem.

it seems to be doing some thing..

I also just tried, but I get an error:
Blender Game Engine Started Python module can't be imported - object 'Empty', controller 'Python Script': ImportError: No module named 'BioBlender2'
and no recording of motion

But I am using an old portable, it might be not very updated. I'll check again when I gat back to the office in Pisa (thursday afernoon)

I am using a latest Buildbot version, as it includes Game Engine fixes (which might be good to have anyway)
I've pushed the change to the experimental branch.
further in the right place: https://github.com/MonZop/BioBlender/issues/9#issuecomment-74645953
this will get easier, not harder :)

I have tested with several combinations, but nothing seems to worrk for me:

any clue?

I think this happens if the Addon folder is not called BioBlender, which might be the case if you are using the zip. You're might be called BioBlender-master , or one of the branches. Ideally the addon wouldn't care about the name of the folder inside which it lives.

So if you are trying the version i'm experimenting with that folder would be called:
BioBlender-master_mff_experiments , but rename it to BioBlender
the content of this version should be:

If any other BioBlender addons are enabled / ticked other than this one  untick them, save settings / Ctrl+U to store this preference. Restart Blender. When you navigate to the addons panel again, you can see where it's loading the addon from by viewing the dropdown:

Now i said:

Ideally the addon wouldn't care about the name of the folder inside which it lives.

Most likely it can be made to be entirely agnostic about folder names, but that's a different problem (one I would like to solve soon)

Oh, finally, I managed! :-)


Hide "Deactivated users" from collapsed settings sidebar

Non-administrator users are by default shown a reduced version of the organization setting sidebar, which hides the less relevant panels until "Show more" is clicked.
We should hide "Deactivated users" from that initial collapsed view, as it's rarely relevant for non-administrators.

Hi @alya, How do you suggest I go about this? I would like to contribute if you'd assign this to me.

@zulipbot claim

I am still actively working on this issue.

@zulipbot claim

@zulipbot claim

@zulipbot claim


Add toggle to enable edge directionality

Closes #145
Prior to this PR, edges were being counted in both directions. This is fine when that information is not directional (like a relationship in the les mis dataset), but when the edges encode a specific directional relationship we want to see that. This PR addresses that issue.
I added a toggle for edge directionality and updated the code to only count in one direction if directional edges is on. This code required a bit of duplicated logic for watching the directional prop and updating the matrix. Once we have a better strategy for handling updates to props (enter, exit, merge, etc.) we can refactor this so that we don't need to tear the matrix down and rebuild it.

Force pushed to fix a formatting issue from prettier


Refactoring AD Tests

Currently, there are many situation in which we run an entire sampler in order to test AD, such as many cases in https://github.com/TuringLang/Turing.jl/blob/master/test/mcmc/abstractmcmc.jl .
This is quite compute intensive. @yebai pointed out that perhaps we should just check that the gradient runs and is correct, rather than thousants of mcmc chains.

Thinking about this and #2338 a little, it's not very easy to dive into the internals of sample() to check that the gradient is correct, but what I'm thinking we could do is:

seed (with StableRNGs) and sample for something like 10 iterations per AD backend and check that the results are numerically similar
once we've established that all AD backends give the same result, we choose one and run the full 1000 samples to check that the result is correct

I don't know how much this will really speed it up, but it could be worth a shot. Thoughts ... let me use the magic ping @TuringLang/maintainers?

I agree with the general sentiment here. In my view we should

only test long-run sampling (i.e. to test the correctness of a sampler) once, using whichever AD we prefer.
publish an iterable collection of test cases that Turing.jl declares that it wants to be able to differentiate. This would form a single source of truth for "things Turing.jl would like to be able to differentiate" (which can be updated over time as we find problem cases / find new cases that we care about). This way, AD packages have clear guidance as to the things that Turing.jl wants to be able to differentiate, and can just hook in them in their integration tests. For example, @mhauru recently added a collection of test cases for Bijectors here in Mooncake -- the key point here is that there's a single vector of test cases (see the test_cases variable) which Mooncake.jl can just iterate through.

It might be that we want to run these test cases in Turing.jl for each backend that we claim supports Turing.jl, in addition to running the tests in Mooncake.jl, but that's something that we could run later on.
Either way, I really think we should decouple "is this sampler correct?" from "does this AD work correctly?".

I'll start playing around with this in a new package, we can decide whether to put it in DPPL proper at a later point in time.

Agreed. We should think about the precise format though. For the sake of both running the tests in downstream AD packages, and for running them in the Turing.jl integration tests, might it make sense to produce things which can be consumed by DifferentiationInterface's testing functionality? See https://juliadiff.org/DifferentiationInterface.jl/DifferentiationInterfaceTest/dev/ for context.

Ooh. I like that. But I don't think LogDensityProblemsAD uses DI for all its backends just yet, right? In which case, I think we'd still need to test logdensity_and_gradient? (Please correct if wrong.) What we can do is to try to future proof it (if we assume that eventually Turing will be using DI for everything, e.g. if we define our own logdensitymodel interface) by making sure we don't stray too far from the DITest interface.

Hmmm maybe you're right? That being said, LogDensityProblemsAD does now support arbitrary ADTypes, meaning that you can use ADTypes to make any backend supported by DifferentiationInterface work for you. e.g.
using ADTypes, Mooncake, Turing
NUTS(; adtype=ADTypes.AutoMooncake(; config=nothing))

so maybe it's fine?

Mostly notes for myself because Julia really lends itself to creating a real maze of function calls, but if anyone's curious.
Mooncake goes via DI so that's all fine.
However, passing an adtype of e.g. AutoForwardDiff still uses the custom implementation, instead of going via DifferentiationInterface:
Running ADgradient(AutoForwardDiff(), ldf) where ldf isa DynamicPPL.LogDensityFunction

hits this https://github.com/TuringLang/DynamicPPL.jl/blob/f5890a11ef4002026e8edeb355b6e8a50c68d115/ext/DynamicPPLForwardDiffExt.jl#L16-L36, which calls ADgradient(:ForwardDiff, ...)
which will then call https://github.com/tpapp/LogDensityProblemsAD.jl/blob/e3401f21b5a065df0d5de38b37fad0e6650618f3/ext/LogDensityProblemsADForwardDiffExt.jl#L96-L118.

It's possible to force the use of DI for AutoForwardDiff by:

modifying the DPPL code above to call ADgradient(AutoForwardDiff(, ...), ...)
that alone would still fail though, because LogDensityProblemsAD special-cases ForwardDiff, so even if you pass it AutoForwardDiff it won't use DI due to this function https://github.com/tpapp/LogDensityProblemsAD.jl/blob/e3401f21b5a065df0d5de38b37fad0e6650618f3/ext/LogDensityProblemsADADTypesExt.jl#L43-L50

See discussion in https://github.com/tpapp/LogDensityProblemsAD.jl/pull/29.
but tldr we can't really shortcircuit LogDensityProblemsAD.


How can I render each string with different colors?

Markwon version: {4.2.0}

I have an article and it's mardown , the mardown string was splited to a list of text ,  and each string need to render with different colors by custom rule.

how can i do ?
thinks

Hello @littlezan !
Unfortunately I won't be able to help you with provided insufficient details. Can you please specify sample input and expected output at least?

input:
val stringList = listOf("**red color"," blue color**"," black color")
render output:

like this , a string of sentence ,and each word of the sentence was marked different score, and I need render the word with different color by it's score.

And there from the color information come from, for example, how do you know if "**red color" should be red?

if not render markdown, it almost like this, here some pseudocode :
data class SentenceModel(
    val wordScoreList: List<WordScoreModel>
) {
    data class WordScoreModel(
        val word: String,
        val score: Int
    )
}

fun getSentenceSpan() {
        val sentenceModel = SentenceModel(listOf(
            SentenceModel.WordScoreModel("**Markwon ", 10),
            SentenceModel.WordScoreModel("is **", 60),
            SentenceModel.WordScoreModel("fantastic", 100)
        ))

        val sentenceString = sentenceModel.wordScoreList.joinToString { it.word }
        val spannableStringBuilder = SpannableStringBuilder(sentenceString)
        sentenceModel.wordScoreList.forEach {
            val colorSpanRed = when (it.score) {
                in 0 until 60 -> ForegroundColorSpan(Color.RED)
                in 60 until 80 -> ForegroundColorSpan(Color.BLUE)
                else -> ForegroundColorSpan(Color.BLUE)
            }
            spannableStringBuilder.setSpan(colorSpanRed,0,10, Spannable.SPAN_INCLUSIVE_INCLUSIVE)
        }
    }

If you calculate score on raw markdown (text includes markdown syntax) then you can use some HTML tags, which will allow to apply specific logic across markdown blocks. For example:
class ScoreTagHandler: SimpleTagHandler() {

    override fun getSpans(configuration: MarkwonConfiguration, renderProps: RenderProps, tag: HtmlTag): Any? {

        // no value is provided, do nothing or indicate an error
        val score = tag.attributes()["value"] ?: return null

        val value = try {
            Integer.parseInt(score)
        } catch(e: NumberFormatException) {
            // the same as for `score` property
            return null
        }

        val color = when {
            (value < 60) -> Color.RED
            (value < 80) -> Color.BLUE
            else -> Color.BLACK
        }

        return ForegroundColorSpan(color)
    }

    override fun supportedTags(): MutableCollection<String> {
        return Collections.singleton("score")
    }
}

And then use it like this:
val list = listOf<Pair<String,Int>>(
        Pair("**Markdown ", 10),
        Pair("is**", 60),
        Pair("fantastic", 100)
)

val md = list
        .map { "<score value=\"${it.second}\">${it.first}</score>" }
        .joinToString(separator = " ")

// `md` at this point is `<score value="10">**Markdown</score> <score value="60">is**</score> <score value="100">fantastic</score>`

val markdown = Markwon.builder(this)
        .usePlugin(HtmlPlugin.create {
            // you can exclude default tag handling (so, only <score> tag will be processed)
            it.excludeDefaults(true)
            it.addHandler(ScoreTagHandler())
        })
        .build()

markdown.setMarkdown(textView, md)

Please note that this will require io.noties.markwon:html dependency. Does this answer your question?

Yes, it's awesome, that's what I want. thinks very much

Great, you are welcome 🙌


Updated title in git-tips.md file

Corrected spelling in title from "GIT tics" to "GIT tips"
Summary
Updated the title of git-tips.md
Changes
Corrected spelling in title from "GIT tics" to "GIT tips"
Task list

[ ] For workflow changes, I have verified the Actions workflows function as expected.
[ ] For content changes, I have reviewed the style guide.

First ever contribution, I read the community guidelines and followed the contribution process (e.g., fork and clone, test, push).  Can you let me know if I've submitted my update/contribution correctly?

Thanks for catching this typo and submitting this fix! You did everything absolutely correctly. Thanks for taking the time to read through our guides and follow the process. Congrats on your first OS PR! 🎉 💖


Ability to set ruby version in config.yml

@subhojit777 - You can do this if you build Ruby from source instead of installing from system packages—see relevant variables to set in your own config.yml here: https://github.com/geerlingguy/ansible-role-ruby#role-variables


Parser fails when quoted string includes dquotes and comma

Hi,
First of all, thanks for the lib, it helps a lot :)
I may have some cases where the parser fails :
//Inside dquotes are not escaped, but it works
>> emailAddresses.parseAddressList({
    input     : '"Blah blah "Some quoted string" foo bar"<EMAIL_ADDRESS>    rfc6532   : true,
    partial   : true,
    simple    : false,
    strict    : false,
    rejectTLD : true,
    startAt   : 'address-list'
});
>> OK

//Inside dquotes are not escaped, but it fails only because of the comma
>> emailAddresses.parseAddressList({
    input     : '"Blah blah "One, comma" foo bar"<EMAIL_ADDRESS>    rfc6532   : true,
    partial   : true,
    simple    : false,
    strict    : false,
    rejectTLD : true,
    startAt   : 'address-list'
});
>> null

//Inside dquotes are escaped, but it still fails because of the comma
>> emailAddresses.parseAddressList({
    input     : '"Blah blah \"One, comma\" foo bar"<EMAIL_ADDRESS>    rfc6532   : true,
    partial   : true,
    simple    : false,
    strict    : false,
    rejectTLD : true,
    startAt   : 'address-list'
});
>> null

If I got the RFC5322 right :

The display-name is a phrase
A phrase can be a 1*word.
A word can be a quoted-string
A quoted-string is like "qcontent"
A qcontent can be qtext or a quoted-pair
A quoted-pair can be \VCHAR (VCHAR includes the comma and the double quote chars)
A qtext is the set of ASCII chars %d33 and %d35-91 and %d93-126. In other words, the printable US-ASCII characters not including \ or the quote character

So, for those display names :

"Display, name" is ok. It's a simple qtext
"Display "middle" name" is not ok. Dquotes are not allowed in qtext and should be a quoted-pair, as \". However the parser accepts it.
"Display \"middle\" name" is ok. Dquotes are quoted characters, as described in the section 3.2.1 of the RFC5322
"Display \"one, comma\" name" is ok. The comma is accepted as part of the qtext, and the dquotes are escaped. However the parser fails

I can also be wrong because that RFC is awful to read and understand :D In this case, I'd be glad to hear your explanations :)
Thank you for your time !

Part of the answer is that I was too tired to see I forgot to escape the backslash in my third test. So if I do
>> emailAddresses.parseAddressList({
    input     : '"Blah blah \\"One, comma\\" foo bar"<EMAIL_ADDRESS>    rfc6532   : true,
    partial   : true,
    simple    : false,
    strict    : false,
    rejectTLD : true,
    startAt   : 'address-list'
});
>> OK

It's OK.
Still, I don't know why it works without escaping the dquotes at all :/


production servers

Description: the set up of the 2 new servers (from Princeton)
Requirements:

installation of ubuntu (18.x or 20.x)
docker
accessible via the internet
science DMZ required?

Goals:

to transfer server components (rabbit MQ and salt-stack) from staging (tt) to a Phase 1 deployment

Servers are ok. SW replication is in progress. We can close this one.


Fix for 1449: mute data sources versions, since we still getting mismatches

Customer scenario
Error dialog complaining about mismatched data sources versions in the tree
Bugs this fixes:
https://github.com/dotnet/roslyn-project-system/issues/1449
Workarounds, if any
Risk
No one listens for Dependnecies tree updates and we can send null for data sources version for RTM.
Performance impact
none

@srivatsn

@dotnet/project-system

Approved to merge via 379182


Add Managed Associations with Core Data Services

Tutorial URL: https://developers.sap.com/tutorials/cp-apm-foundation-01.html
Please specify the step you are referring to
Step 7: Build your db module and explore build
With the current downloaded tutorial-enhance-the-product-catalog.zip, got the following error:
Build command failed : hdi-build operation failed: No suitable major-minor version found for requested version \'3.3.0\'. Latest available version: 3.11.0
After I updated "@sap/hdi-deploy" to "3.11.0" in /tutorial-enhance-the-product-catalog/db/package.json, the Build failed with the following warnings and errors:
(Same warning repeated several times)
Warning: com.sap.hana.di.tabledata: No "include_filter" is specified; it's strongly recommended to define an "include_filter" to also allow other table imports into the table; if no other table imports are intended, please specify at least an empty "include_filter":[] in the  "import_settings" section [8251576]
at "src/gen/cloud-samples-foundation/_csv/Data.hdbtabledata" (3:196)
———
9:51:55 AM (HDB)      Precompiling "$cds.merge/CLOUDS_PRODUCTS_PRODUCTS" (merged)... ok  (0s 26ms)
Precompiling "$cds.merge/CLOUDS_PRODUCTS_STOCKAVAILABILITIES" (merged)... ok  (0s 25ms)
Merging... ok  (0s 207ms)
Error: "tabledata.source://AreaUnits.csv": the object cannot be provided more than once [8212002]
"src/_csv/AreaUnits.csv": the file would provide it
"src/gen/cloud-samples-foundation/_csv/AreaUnits.csv": the file would provide it
Error: "tabledata.source://BaseUnits.csv": the object cannot be provided more than once [8212002]
"src/_csv/BaseUnits.csv": the file would provide it
"src/gen/cloud-samples-foundation/_csv/BaseUnits.csv": the file would provide it
———
9:51:55 AM (HDB)     Error: "tabledata.source://Countries.csv": the object cannot be provided more than once [8212002]
"src/_csv/Countries.csv": the file would provide it
"src/gen/cloud-samples-foundation/_csv/Countries.csv": the file would provide it
Error: "tabledata.source://Currencies.csv": the object cannot be provided more than once [8212002]
"src/_csv/Currencies.csv": the file would provide it
"src/gen/cloud-samples-foundation/_csv/Currencies.csv": the file would provide it
Error: "tabledata.source://Languages.csv": the object cannot be provided more than once [8212002]
"src/_csv/Languages.csv": the file would provide it
"src/gen/cloud-samples-foundation/_csv/Languages.csv": the file would provide it
Error: "tabledata.source://LengthUnits.csv": the object cannot be provided more than once [8212002]
"src/_csv/LengthUnits.csv": the file would provide it
———
9:51:55 AM (HDB)      "src/gen/cloud-samples-foundation/_csv/LengthUnits.csv": the file would provide it
Error: "tabledata.source://VolumeUnits.csv": the object cannot be provided more than once [8212002]
"src/_csv/VolumeUnits.csv": the file would provide it
"src/gen/cloud-samples-foundation/_csv/VolumeUnits.csv": the file would provide it
Error: "tabledata.source://WeightUnits.csv": the object cannot be provided more than once [8212002]
"src/_csv/WeightUnits.csv": the file would provide it
"src/gen/cloud-samples-foundation/_csv/WeightUnits.csv": the file would provide it
Error: Could not compose a consistent make graph [8212012]
Error: Calculating dependencies... failed [8212108]
Make failed (11 errors, 22 warnings): tried to deploy 51 files, undeploy 0 files, redeploy 0 dependent files

Hi @janhuachu ,
please perform a cds build before the db build.

Open the context menu on the model.cds file and select "Build > Build CDS"
After the build has been successfull, please do the build on the db module as described in the tutorial.

Hint: You might want to enable build upon save, as described in Step 4.
Regards,
René

Thanks for your info.
I did have the build upon save preference set.
After I did the "Build > Build CDS" on model.cds succeeded, I tried to do the step 7 again.
This time, I got the following error message:
4:32:39 PM (Executor) The "task for hdb build" process started.
4:32:39 PM (Executor) Started the "task for hdb build" provision.
4:32:49 PM (Provision) Service provisioning for module: "/db"
4:32:49 PM (Provision) Service instance 'tutorial-enhance-the-product-catalaRnrQGQJLOx7mpX/' for resource 'tutorial-enhance-the-product-catalaRnrQGQJLOx7mpX/' already exists, no operation will be performed.
4:32:49 PM (Provision) Service instance 'tutorial-enhance-the-product-catalGT1wBpH99g6hrTpj' for resource 'tutorial-enhance-the-product-catalGT1wBpH99g6hrTpj' already exists, no operation will be performed.
4:32:51 PM (Executor) Starting process: "cd /projects/tutorial-enhance-the-product-catalog/db; export DEVX_MTA_RESOLVED_PLACEHOLDERS="{"services":[{"platformName":"tutorial-enhance-the-product-catalaRnrQGQJLOx7mpX/","resourceName":"product-catalog-logging","resourceProperties":{},"resourceType":"org.cloudfoundry.managed-service","serviceKeyName":"SharedDevKey","serviceTarget":{"endpoint":"https://api.cf.us10.hana.ondemand.com","org":"I825141trial_trial","space":"dev"}},{"platformName":"tutorial-enhance-the-product-catalGT1wBpH99g6hrTpj","resourceName":"product-catalog-hdi-container","resourceProperties":{},"resourceType":"com.sap.xs.hdi-container","serviceKeyName":"SharedDevKey","serviceTarget":{"endpoint":"https://api.cf.us10.hana.ondemand.com","org":"I825141trial_trial","space":"dev"}}]}"; export CF_HOME=/projects/.webide/cf/2743ff1a6cd6bcc8310f3960948b4603; export DEVX_MTA_HDI_BUILD_OPTIONS="{"IsSelectiveBuild":false,"SelectedFiles":[],"IsSimulateBuild":false,"AdditionalOptions":{"migrationtable-development-mode":true}}"; export PROJECT_PATH=/projects/tutorial-enhance-the-product-catalog/db; mkdir -p $CF_HOME/.cf/plugins/ && cp -u $CF_PLUGIN_PATH/config.json $CF_HOME/.cf/plugins/config.json 2>/dev/null || :;hdi-space-builder build"
4:32:52 PM (HDB) Executing Build command:
4:32:52 PM (HDB)  HDI BUILDER VERSION:1.1.8-20191023151637
4:32:52 PM (HDB) temp folder created at: /tmp/hdispacebuilder427706782
4:32:52 PM (HDB) Starting pre-hdiBuild operations...
4:32:54 PM (HDB) Build command failed : failed to prepare payload on pre build stage: service hdispacedeploy4dd0350d-21eb-4c29-be90-c3ceafbeb787 is not valid: failed install hdispacedeploy4dd0350d-21eb-4c29-be90-c3ceafbeb787 application: Failed to execute install command: Failed to execute install command: failed to set delete service : Row not found
4:32:55 PM (HDB) Build of /tutorial-enhance-the-product-catalog/db failed due to The "task for hdb build" process finished with code 1.

Hi @janhuachu ,
I've tested it now also in your region (us10). And it works for me. Could you please check if your account has enough resources? Or would you be willing to create a new subaccount in a new region (Frankfurt preferably) and try it there with the same sources? Here is a nice blog, explaining How to change the region in your Cloud Foundry trial.
You could share your sources. I know it should only differ by two lines but maybe it gives a hint.
-René

Thanks for your response. I was working using Chrome on a MacBook. There were some problems using the Chrome this morning. So, I switched to use Safari and everything is fine now.
Thanks for your support.


Can not load mapbox-gl after yarn install

I installed node packages and then started it, but project has error in run on the chrome browser:

Chrome Desktop Windows - Version 116.0.5845.141 (Official Build) (64-bit)
Response in the browser (React error):
Cannot read properties of undefined (reading '0') TypeError: Cannot read properties of undefined (reading '0')   at Object.Go [as transformMat4$1] (http://localhost:3000/static/js/vendors-node_modules_mapbox-gl_dist_mapbox-gl_js.chunk.js:6525:22)   at Ho.pointRayIntersection (http://localhost:3000/static/js/vendors-node_modules_mapbox-gl_dist_mapbox-gl_js.chunk.js:25374:11)   at Nd.pointCoordinate (http://localhost:3000/static/js/vendors-node_modules_mapbox-gl_dist_mapbox-gl_js.chunk.js:11473:46)   at Ho.pointCoordinate (http://localhost:3000/static/js/vendors-node_modules_mapbox-gl_dist_mapbox-gl_js.chunk.js:25402:32)   at Ho.pointCoordinate3D (http://localhost:3000/static/js/vendors-node_modules_mapbox-gl_dist_mapbox-gl_js.chunk.js:25405:42)   at Ho.pointLocation3D (http://localhost:3000/static/js/vendors-node_modules_mapbox-gl_dist_mapbox-gl_js.chunk.js:25360:45)   at Map.unproject (http://localhost:3000/static/js/vendors-node_modules_mapbox-gl_dist_mapbox-gl_js.chunk.js:28486:35)   at new ar (http://localhost:3000/static/js/vendors-node_modules_mapbox-gl_dist_mapbox-gl_js.chunk.js:26002:17)   at hr.mouseover (http://localhost:3000/static/js/vendors-node_modules_mapbox-gl_dist_mapbox-gl_js.chunk.js:26071:24)   at Xr.handleEvent (http://localhost:3000/static/js/vendors-node_modules_mapbox-gl_dist_mapbox-gl_js.chunk.js:27078:93)

Thanks for your support ✌

Do you solve the problem? I encouter it, too. @MostafaRDE

@ZinuoCai
No I don't.

Hi everyone,
Apologies for the problems in the project. Can you book a call with me at
https://calendly.com/afilabs.
Afian
On Fri, Aug 9, 2024 at 2:54 AM Mostafa Effati @.***>
wrote:

@ZinuoCai https://github.com/ZinuoCai
No I don't.
—
Reply to this email directly, view it on GitHub
https://github.com/afilabs/h3js_hexagons_taxi_demand_time_slider/issues/1#issuecomment-2277582940,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABECB22JPANKJPJQR2SFU6TZQSGUBAVCNFSM6AAAAABJXHE4GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZXGU4DEOJUGA
.
You are receiving this because you are subscribed to this thread.Message
ID: <afilabs/h3js_hexagons_taxi_demand_time_slider/issues/1/2277582940@
github.com>


[Event Request] Table 37 - OnBeforeAutoReserve

The Publisher in the Function AutoReserve has following signature:
OnBeforeAutoReserve(SalesLine : Record "Sales Line";VAR IsHandled : Boolean)
but should be
OnBeforeAutoReserve(var SalesLine : Record "Sales Line";VAR IsHandled : Boolean)
in order that the Sales Line can be updated

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


PyQt, different library pathes linux/windows

Hi again,
After I opened #101 , I realized I was doing something wrong to solve two different issues (and maybe more). My wrong solution was going to lead to a lot of troubles, but I was corrected.
However, I now have plenty of issues to fix.
So, here comes my setup.py:
if sys.platform in ['win32', 'cygwin', 'win64']:
    base = "Win32GUI"

    # Copy the sqlite driver
    my_data_files.append(('sqldrivers', ['C:\Python34\Lib\site-packages\PyQt4\plugins\sqldrivers\qsqlite4.dll']))

    FREEZER = 'cx_Freeze'
    FREEZER_OPTIONS = dict()

elif sys.platform == 'darwin':
    pass
else:
    my_data_files.append(('sqldrivers', ['/usr/lib/qt4/plugins/sqldrivers/libqsqlite.so']))
    FREEZER = 'cx_Freeze'
    FREEZER_OPTIONS = dict()

Classic, I want to use PyQt and its sqlite, so I copy the driver in the appropriate directory.
When the program is bundled with esky, I have this folder on Linux and windows:
my_program/
    exe_esky
    one_lib
    libpython3.4
    my_program/
        sqldrivers/
            sqlite.lib
        exe_exe
        esky_files/

When I run my program (by launching exe_esky.......), it goes well on Linux, but not on Windows: I get the error 'driver not found' when I try to access my sqlite database. I assume the path for the driver is not set properly

When I start exe_esky on Linux, and print QtGui.QApplication.libraryPaths():

['~/my_program/my_progam']

Same thing on Windows:

['~/my_program']

For some reason, Windows is not looking at the right place for the sql drivers.
However, adding this line in exe_esky solved the issue on Windows:
QtGui.QApplication.addLibraryPath(path_of_the_sql_drivers)

By telling the exe where to look for, the program finds the drivers.
Do you know why I get these two different behaviours ?

@JPFrancoia Is there an actual issue here?
As per your other post,The wiki is available for anyone to edit so feel free to add something ins there if you fell information is missing.
Esky shells out to different freezers, you need to make sure that the freezing is working correctly, then you can move on to blaming esky.
Quick google search... https://www.google.de/search?q=freezing+pyqt+sqlite&ie=utf-8&oe=utf-8&gws_rd=cr&ei=2CBXVrG1JIOFPu2pspgC,
first result has your answer...

Yes I think there is an issue here, but I'm not sure if Esky is to blame, you're right. I just think it is strange to modify the core code of the program to make the bundle work.
About the google search, the problem is not that it's not working, it is just that the path for the library is not set properly after bundling.
But a fix exist, so just in case one day someone has the same problem, we can reopen the issue.

as far as i can understand it messing around with the cx freeze settings was enough to get it working on windows
Thanks Anil, it worked just fine! Just complementing for those who face the
same problem in the future, I had to copy the C:\Python26\Lib\site-packages
PyQt4\plugins\sqldrivers dir to my frozen app target-dir. The only file
needed in my case was qsqlite4.dll (which refers to QSqlite), but it has to
be in a folder named ''sqldrivers'' into the target-dir for the app to work.

there are many edge cases with the freezers that require manual intervention, pyinstaller is preconfigured to correctly pull in those sorts of things, unfortunately we haven't go around to supporting them yet :(, it would be nice to have things work out of the box

Hum, not sure we understood each other. I didn't mess around with the cx_freeze settings.I modified the file exe_esky, my program.
The directory sqldrivers is at the right place. Running directly exe_exe, as I was doing i #101 , worrks. I have no problem with the sqldriver.
However, exe_esky tries to find the driver in the top level folder, at ['~/my_program']. I get this behaviour on windows only.
It seems the top level exe doesn't hand over to the second level exe, or some sort of stuff like that.

Can you confirm that your application works fine when frozen without esky (on both platforms )

I do confirm.
With this setup.py:
#!/usr/bin/python
# coding: utf-8

import sys, os
from cx_Freeze import setup, Executable

my_data_files = []

my_data_files += ['.{}images{}'.format(os.path.sep, os.path.sep)]
my_data_files += ['.{}journals{}'.format(os.path.sep, os.path.sep)]
my_data_files += ['.{}config{}'.format(os.path.sep, os.path.sep)]
my_data_files += ['.{}config{}fields{}'.format(os.path.sep, os.path.sep, os.path.sep)]

base = None
if sys.platform in ['win32', 'cygwin', 'win64']:
    base = "Win32GUI"
    my_data_files.append(('C:\Python34\Lib\site-packages\PyQt4\plugins\sqldrivers\qsqlite4.dll', 'sqldrivers\qsqlite4.dll'))
elif sys.platform == 'darwin':
    pass
else:
    my_data_files.append(('/usr/lib/qt4/plugins/sqldrivers/libqsqlite.so', 'sqldrivers/libqsqlite.so'))

excludes = [
            'test_hosts',
            'test_worker',
            'misc',
           ]

includes = [
            'sip',
            'PyQt4.QtCore',
            'PyQt4.QtGui',
            'PyQt4.QtNetwork',
            'PyQt4.QtSql',
            'scipy.special.specfun',
            'scipy.integrate.vode',
            'scipy.integrate.lsoda',
            'scipy.sparse.csgraph._validation',
            'sklearn.utils.sparsetools._graph_validation',
            'scipy.special._ufuncs_cxx',
           ]

options = {
           "includes": includes,
           "excludes": excludes,
           "include_files": my_data_files,
           }

exe = Executable("gui.py", base=base)

setup(
    name="monprogramme",
    version="1.00",
    description="monprogramme",
    options={"build_exe": options},
    executables=[exe]
    )

And using
python setup.py build

The frozen apps work great on Windows and Linux.
With this setup.py:
#!/usr/bin/python
# coding: utf-8

import sys
import os
from esky.bdist_esky import Executable
from setuptools import setup

def get_all_files_in_dir(directory):

    """Get all the files in a directory, and
    return a list bdist formatted"""

    list_files = []

    for file in os.listdir(directory):
        f1 = directory + file
        if os.path.isfile(f1):  # skip directories
            f2 = (directory, [f1])
            list_files.append(f2)

    return list_files

my_data_files = []

# Add the data in images, journals, and config
my_data_files += get_all_files_in_dir('.{}images{}'.format(os.path.sep, os.path.sep))
my_data_files += get_all_files_in_dir('.{}journals{}'.format(os.path.sep, os.path.sep))
my_data_files += get_all_files_in_dir('.{}config{}'.format(os.path.sep, os.path.sep))
my_data_files += get_all_files_in_dir('.{}config{}fields{}'.format(os.path.sep, os.path.sep, os.path.sep))

base = None
if sys.platform in ['win32', 'cygwin', 'win64']:
    base = "Win32GUI"
    # Copy the sqlite driver
    my_data_files.append(('sqldrivers', ['C:\Python34\Lib\site-packages\PyQt4\plugins\sqldrivers\qsqlite4.dll']))

    FREEZER = 'cx_Freeze'
    FREEZER_OPTIONS = dict()

elif sys.platform == 'darwin':
    pass
else:
    my_data_files.append(('sqldrivers', ['/usr/lib/qt4/plugins/sqldrivers/libqsqlite.so']))
    FREEZER = 'cx_Freeze'
    FREEZER_OPTIONS = dict()

excludes = [
            # Personal modules
            'test_hosts',
            'test_worker',
            'misc',
           ]

includes = [
            'sip',
            'PyQt4.QtCore',
            'PyQt4.QtGui',
            'PyQt4.QtNetwork',
            'PyQt4.QtSql',
            'scipy.special.specfun',
            'scipy.integrate.vode',
            'scipy.integrate.lsoda',
            'scipy.sparse.csgraph._validation',
            'sklearn.utils.sparsetools._graph_validation',
            'scipy.special._ufuncs_cxx',
           ]

build_exe_options = {
                     'bdist_esky': {
                                    'freezer_module': FREEZER,
                                    'freezer_options': FREEZER_OPTIONS,
                                    'includes': includes,
                                    'excludes': excludes,
                                   },
                     }

exe_esky = Executable("gui.py", gui_only=True)

setup(name="Test",
      version='1',
      data_files=my_data_files,
      options=build_exe_options,
      scripts=[exe_esky],
      )

The code works great on Linux, but I have no access to the sql driver on Windows.


[SUBMARINE-185] Add how to contribution docs

What is this PR for?
This document is intended to help more people and know-how to participate in the development of submarine projects.
The documentation includes:

Contribution Guide
Github Workflow
Code Review Guide

What type of PR is it?
Improvement
Todos

[ ] - Need add become-a-committer.md
[ ] - Need add contributors.md

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-185

How should this be tested?

CI Pass

Screenshots (if appropriate)
Questions:

Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? Yes

Thanks for @liuxunorg 's patch and @jojochuang 's review. I'll commit this if no more discussion.


[BUG] Selecting color palette with incompatible levels/name

KeyError raised if dropdown menu selects incompatible combinations of palette name and levels

Opportunity to redesign the double-dropdown UI to something more intuitive.


RNDC does not work for bind+dhcpd setups on NixOS 22.05

Describe the bug
Up to NixOS 21.11, it was possible to have DHCPD update records on Bind through RNDC.
services.dhcpd4 = {
  enable = true;
  interfaces = [ "eth0" ];
  extraConfig = ''
    include "/etc/bind/rndc.key";
    .
    .
    # DNS zones to update
    zone 10.168.192.in-addr.arpa. {
      primary <IP_ADDRESS>;
      key "rndc-key";
    }

This was broken by https://github.com/NixOS/nixpkgs/commit/59e51f359bb8819343fa1159af1ccddf70c7f87d
Previously, dhcpd started as root and dropped privileges after reading configs. The rndc key file generated by bind defaults to 600 with named:root as owner and group. Now that dhcpd starts as an unprivileged dynamic user, it can't read the rndc key.
Steps To Reproduce
Steps to reproduce the behavior:

add include "/etc/bind/rndc.key"; to services.bind.extraConfig
enable bind and dhcpd4

Expected behavior
dhcpd4 starts
Logs
dhcpd4[3625306]: Internet Systems Consortium DHCP Server 4.4.3
dhcpd[3625306]: Internet Systems Consortium DHCP Server 4.4.3
dhcpd[3625306]: Copyright 2004-2022 Internet Systems Consortium.
dhcpd[3625306]: All rights reserved.
dhcpd[3625306]: For info, please visit https://www.isc.org/software/dhcp/
dhcpd4[3625306]: Copyright 2004-2022 Internet Systems Consortium.
dhcpd4[3625306]: All rights reserved.
dhcpd4[3625306]: For info, please visit https://www.isc.org/software/dhcp/
dhcpd4[3625306]: Can't open /etc/bind/rndc.key: Permission denied
dhcpd[3625306]: Can't open /etc/bind/rndc.key: Permission denied
dhcpd[3625306]: If you think you have received this message due to a bug rather
dhcpd[3625306]: than a configuration issue please read the section on submitting
dhcpd[3625306]: bugs on either our web page at www.isc.org or in the README file
dhcpd[3625306]: before submitting a bug.  These pages explain the proper
dhcpd[3625306]: process and the information we find helpful for debugging.
dhcpd[3625306]: exiting.
dhcpd4[3625306]:
dhcpd4[3625306]: If you think you have received this message due to a bug rather
dhcpd4[3625306]: than a configuration issue please read the section on submitting
dhcpd4[3625306]: bugs on either our web page at www.isc.org or in the README file
dhcpd4[3625306]: before submitting a bug.  These pages explain the proper
dhcpd4[3625306]: process and the information we find helpful for debugging.
dhcpd4[3625306]:
dhcpd4[3625306]: exiting.
systemd[1]: dhcpd4.service: Control process exited, code=exited, status=1/FAILURE
systemd[1]: dhcpd4.service: Failed with result 'exit-code'.
systemd[1]: Failed to start DHCPv4 server.

Additional context
I see two ways to fix the issue:

revert the revert commit that un-reverted the previous revert commit that reverted the commit that introduced the issue.
change the bind prestart script at https://github.com/NixOS/nixpkgs/blob/49a2bcc6e2065909c701f862f9a1a62b3082b40a/nixos/modules/services/networking/bind.nix#L255 to set the permission of /etc/bind/rndc.key to be world-readable.

1 is of course the preferred option, as 2 will allow any unprivileged user to read the rndc key and update records on bind.
Notify maintainers
@vcunat  @rnhmjoj @globin
Metadata
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.10.81, NixOS, 22.05 (Quokka)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.8.1`
 - nixpkgs: `/nix/store/4fq7hg1gi3fv8gwla444m87b8vbydkiv-lqd54dk5jrqqs4sdfp9qz9xa7a0lli3n-nixpkgs-src`

Previously, dhcpd started as root and dropped privileges after reading configs.

Yes, this was documented in the release notes.

The rndc key file generated by bind defaults to 600 with named:root as owner and group. Now that dhcpd starts as an unprivileged dynamic user, it can't read the rndc key.

The best solution would be to just change the user/group of this file.
If for some reason you can't do that, I would do, in order of preference,

Add an ACL rule to give the dhcp user read access;
Add the CAP_DAC_READ_SEARCH capability to bypass the file read check
Run dhcpcd as root (you can still do this by changing systemv.services.dhcpd6)

Makes sense. But it would be nice to fix at the module level. I'm not too familiar with all of systemd's unit options, but BindReadOnlyPaths or readOnlyPaths seem like they might work.

Makes sense. But it would be nice to fix at the module level.

Do you mean the bind module? If this is a standard setup, yes, we may add an option to configure named and setting that file permissions.
If you mean reverting dhcpd to running as root, no. This is working an intended: I've enabled the systemd hardening options for dhcpd as part of the trend of reducing the amount of services running with elevated privileges.

If you mean reverting dhcpd to running as root

Oh no, I wasn't talking about reverting to DHCP as root. I went over the PR and related discussions, the decision to harden services makes sense.

Do you mean the bind module?

Not exactly... Changing the permissions of the file in the bind module is less preferred because

I'm only familiar with dhcpd, but things other than dhcpd might want to use the rndc key to update records.
the dhcpd user will not exist if only bind is enabled

I was suggesting adding bindReadOnlyPaths/readOnlyPaths to the dhcpd module. Does that sound good?

I was suggesting adding bindReadOnlyPaths/readOnlyPaths to the dhcpd module

Sorry, I'm still not sure what you're proposing. Do you mean adding a covenience option like services.dhcpd6.readOnlyPaths that maps to systemd.services.dhcpd6.bindReadOnlyPaths or something like
// optionalAttrs (config.services.bind.enable)
  {
    services.systemd.dhcpd6.bindReadOnlyPaths = [ "/etc/bind/rndc.key" ];
  }

to the dhcpd module?
At any rate, it's probably easier to review a PR than discussing this here.

services.systemd.dhcpd6.bindReadOnlyPaths = [ "/etc/bind/rndc.key" ];

Yes. I was hoping this would be enough, but it looks like BindReadOnlyPaths preserves the file permissions of the source file.
https://github.com/NixOS/nixpkgs/pull/176274
All this does is expose rndc.key as a read-only bind mount with the same file permissions as before. the bind user will not have access to it.

Closing this as I'm switching to kea for DHCP. Anyone else having this issue can get around it by setting permissionsstartonly to true for DHCPD, and copying the bind key to /var/lib/dhcpd in execstartpre. This is a crude imitation of the old behavior with more steps, but it gets the job done. I still don't get the point of running dhcpd as an unprivileged user when it already drops privileges and runs as the user specified by the -user flag after reading configs and binding sockets as root.


Implement dynamic customer greeting (including Lionel Richie)

Closes #2.

I have enabled Travis, you can add configuration now. ;)


remove all resources for egress network connectivity

Currently Covidshield has no requirements for egress connectivity and therefore egress access should be removed.

remove covidshield_egress_anywhere security group
remove NAT Gateways and corresponding routes
switch VPC endpoints to use private subnets where fargate tasks are
add explicit egress SG rules from tasks to VPC endpoints and RDS instance

I'll let @maxneuvians take approval on this as I'm beyond tired at this point, but just wanted to say a big thanks, this shuts down several concerns I had.

This should be ready for review. We'll have to do some manual intervention due to dependencies that TF can't currently deal with and converting the inline SG rules to explicit rules.


Lighting support in the batch renderer

Motivation and Context
Things left to do:

[x] Base implementation in the batch renderer
[x] Distinguish between flat-shaded and shaded materials and render them appropriately
[x] Make it possible to draw shaded and flat meshes in a single draw call (currently the batch count is 2 instead of 1 in the test and it binds some additional texture, huh?) it's fine, the second draw call is for the third untextured sphere
[x] Tests for the base implementation
[x] Tests for clearLights()
[x] Properly implement the point vs directional light distinction
[ ] Check code coverage (blocked by AttributeError: module 'torch._C' has no attribute '_cuda_setDevice')
[x] Enable and test per-scene light culling (i.e., the shader using not always the maximum light count, but the exact count each scene uses)

Note that this PR won't include per-draw light culling

[x] Hook up with the gfx-replay pipeline
[x] Adapt #1969 to include normals and properly mark flat-shaded vs PBR materials

How Has This Been Tested
Look at those pretty pictures! :red_circle: :yellow_circle:

Good progress so far!

This PR is now ready for a review. What's left is implementing the distinction between point vs directional lights, and updating the compositor scripts in #1947 to include normals and mark only the acually baked materials as flat.
A horrible screenshot for your viewing pleasure -- the overlapping objects are an issue with the input data, and the extremely contrasted lighting as well. I'll dive into this and try to create some more visually pleasing setup.

#1947 is now updated with lighting-aware composite creation and this PR is thus considered finished from my side. Output with the new composites for reference (above was using the loose glTF files) -- the main difference is that the Replica room model is now correctly using a flat-shaded material and thus isn't affected by lighting, making it look weird.


Fix confusing SliderJoint3D brief description

This closes https://github.com/godotengine/godot/issues/25631.

Thanks!

Cherry-picked for 3.2.4.


Add documentation for reporting a bug

Add a explanation for a good bug report to contributing.md

Hey


Add EffectfulExprSyntax syntax trait

Introduces the EffectfulExprSyntax protocol, designed to provide a common interface for effectful expressions such as try and await.
Resolves #2549

If you do land this change, I'd like to get it cherry-picked to 600 so we can adopt it in swift-testing sooner.

If you do land this change, I'd like to get it cherry-picked to 600 so we can adopt it in swift-testing sooner.

I don't see any problems with that on my end.
Do you have an issue in swift-testing regarding adaptation?

swift-testing should generally be able to adopt swift-syntax-600 features once the release is tagged; swift-syntax-610, speculatively, would be quite a ways off.

Oh, I meant an issue about adopting EffectfulExprSyntax syntax trait, so I could look at it. 😅

I did find the time to actually think about it now and wasn’t able to come up with a concise definition that differentiates TryExprSyntax and AwaitExprSyntax from any other syntax nodes, which is usually a very good indicator that we’re not on the right track.
At first I thought that try and await are keywords/modifiers/whatever you want to call them that don’t actually change semantic meaning but just indicate something to anyone reading the code. But TryExprSyntax also represents try! and try?, which do change how the expression behaves. With those in mind, I don’t think there’s anything fundamental that’s separating eg. try? from eg. optional chaining or force-unwrapping and thus it doesn’t make sense to add a syntax trait for them.


Add memory leak profiler

Rationale
Managed memory leaks can happen in dotnet (undisposed resources, unregistered event handlers, evergrowing caches, ...). Some tools can be used to spot leaks, but in large applications, they can easily be drowned in irrelevant data.
One that I like a lot is dotMemory, it does a great job at highlighting memory leaks, however, it is not always possible to find everything or be accurate when doing diffs on dumps. Such an approach also has some downsides: the tool is paid, not open source, not entirely cross-platform, dumps are heavy (clunky to work with), the process gets slowed down, attaching to the process to measure allocation event requires the application to be stopped and restarted along with the profiler, and more...
How to find managed memory leaks using the CLR APIs
A managed memory leak can be identified when, for a given object, its number of persisting instances or persisting bytes increases over time.
In practice, a persisting instance would be an instance that had been allocated during the profiling session (it wasn't there when the profiler started) and remains present on the heap despite several garbage collections on the heap on which it resides. The persisting bytes are simply the number of bytes retained by these instances.
There are two places where we can look for managed memory leaks:

Gen 2 as a leaky object will stay and get promoted up to gen 2 (no need to look into gen 0 or 1)
Gen 3 or LOH as there could be large objects as well (usually arrays)

Proposed method

Start profiling SurvivingReferences
On the first full garbage collection, store all surviving references (their ids) in a set. Let's call this set A.
On the next full garbage collection

Make a copy of A, let's call it B
Remove each surviving reference from B

If remove fails, it means it's a new object, add it to A and set an "allocated while profiling" flag on it, and store its current size (retained bytes)
Every reference that remains in B is a reference that has been garbage collected, so you can remove it from A

Keep doing the previous step for several garbage collections
On the second to last full garbage collection, start profiling ObjectReference also. This will help understand what is the retention path for that leak.
On the last GC

Cleanup object reference graph (just in case)
Remove every non-flagged entry from A. We have our set of persisting references.
When garbage collection ends, for each flagged entry in A, pull the whole retention path and aggregate count by name + the total increase in retained bytes

Caveats

Compacting GC may move objects. For this reason, we need to use MovedReferences to update our tracklist of references.

Todo

[x] Fix issue in the dotnet runtime with object allocated callback on the (net 6.0) #63806.
EDIT: It turns out this callback is too expensive so we may want to use less expensive ones here. Surviving references should fulfill our needs.
[ ] Well, implement it
[ ] Trigger non comparing GCs itself ? In case the program doesn't.

Turns out we don't care if it is a compacting GC or not, we need to keep tracking of moving references anyway with MovedReferences callback

gc roots profiler will partially fulfill this need (greatly ease the finding of memory leaks). For this reason, moving this ticket for a future milestone instead


API Upgrade to PHPUnit 7.0 beta, bump minimum PHP to 7.1

This is the start of #7653 which will update the PHPUnit version to 7.0 (currently in beta).
As part of this change, we:

Bump the minimum PHP version to 7.1 (as PHP 7.0 and lower are now out of active support)
Start implementing some PHP 7 return type hints, mostly where we've extended PHPUnit which now implements these in its own classes

Yep, sure thing. It's nice to see the builds going green at least! Will update the docs tonight.

Big stack of linting errors failed the build. Should we merge up from 4 to fix this, or just run phpcbf over it in master?

@robbieaverill I'm merging up the linting fixes to master.

Rebased. :)


[Theme] Change tessen event SplitTextButton to SignupButton for event name consitency

Relates to this comment:
https://github.com/newrelic/instant-observability-website/pull/14/files#r796168455
Acceptance Criteria

[ ] Confirm if we can kill the split test that is currently running on the OSS and Docs site
[ ] Confirm if we have enough data to use start now vs free account as it seems to be performing better
[ ] change code for SpitTextButton to SignupButton
[ ]  update the global header with the new component name.

A/B test results

Moving back to the backlog as there are doubts this data is accurate given we haven't implemented this yet.
https://github.com/newrelic/gatsby-theme-newrelic/issues/616


Update request: crow-translate 2.11.1 → 3.0.0

Package name:crow-translate
Latest released version:3.0.0

Current version on the unstable channel:2.11.1
Current version on the stable/release channel:2.11.1

[x] Checked the nixpkgs pull requests

Notify maintainers
@sikmir

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

The project has migrated under the KDE umbrella, and development will continue at https://invent.kde.org/office/crow-translate.


Snad support

Support for the Snad mod by TheRoBrit (https://www.curseforge.com/minecraft/mc-mods/snad)

According to the mod's CurseForge page:

This mod adds a block known as "Snad" which unlike it's counterpart "Sand" WILL increase the growth rate for sugarcane, cacti and any other plantable crop.

Snad (and its Red Snad counterpart) should add twice the boost as "regular" sand/red sand; I'm unsure if I've configured this properly. Additionally, this is my first time working with pull requests; apologies for the mess.


Add linting

Discuss which rules we want (code)
Commit messages
Do we want Husky etc?

Commit linting is currently non-ideal as we cannot check for a signed-off by field.
Issue raised here: https://github.com/conventional-changelog/commitlint/issues/1809


Early Stop

Description
I got below error when follow Marco's instruction: All models have the parameter early_stop_patience_steps. By default it's -1, meaning it will not early stop. If you set it to 3, then training stop if the validation loss doesn't improve three times in a row.
ERROR - An error occurred: Early stopping conditioned on metric ptl/val_loss which is not available. Pass in or modify your EarlyStopping callback to use any of the following: train_loss, train_loss_step, train_loss_epoch.
Link
No response

This is because, by default, early stopping requires a validation set. You can create a validation set by specifying the val_size parameter in the fit method, or by specifying both val_size and test_size when using cross_validation.
Same as in this issue.

@marcopeix Hi Marco, thx for the reply. It turns out I need to setup "val_check_steps" as well along with the "early_stop_patience_steps".


Unable to connect on same host

Hi, and first thanks a lot for your docker gitlab images. I run them since 14 month without to have to complain :)
I've got a problem to run ci-multi-runner on the same host. I've got this output
gitlab-ci-multi-runner 1.1.3 (a470667)
WARNING: image is not supported by selected executor and shell
Using Shell executor...
Running on 0e608eb62373...
Cloning repository...
Cloning into '/home/gitlab_ci_multi_runner/data/builds/f7eeb9e6/0/metal3d/test-ci'...
fatal: unable to access<EMAIL_ADDRESS>Failed to connect to git.develipsum.com port 443: Connection refused

ERROR: Build failed: exit status 1

Actually git.develipsum.com is served by a reverse proxy. I can access it outside and on my host. But not inside the "runner" container.
This is my docker-compose that runs:
GitlabCIMultiRunner:
  image: sameersbn/gitlab-ci-multi-runner:1.1.3-1
  volumes:
    - ./data:/home/gitlab_ci_multi_runner/data
    - /var/run/docker.sock:/var/run/docker.sock
  environment:
    - CI_SERVER_URL=http://gitlab/ci
    - RUNNER_TOKEN=XXXXXXXXXXXXXXXXx
    - RUNNER_DESCRIPTION=Docker CI runner
    - RUNNER_EXECUTOR=docker
  restart: always
  external_links:
    - gitlab

"gitlab" link is my gitlab 8.6.7 (your image) and the runner is correctly registered.
CONTAINER ID        IMAGE                                      COMMAND                  CREATED             STATUS              PORTS                                                NAMES
0e608eb62373        sameersbn/gitlab-ci-multi-runner:1.1.3-1   "/sbin/entrypoint.sh"    10 minutes ago      Up 10 minutes                                                            gitlabrunner_GitlabCIMultiRunner_1
5396398c5a12        sameersbn/gitlab:8.6.7                     "/sbin/entrypoint.sh "   14 minutes ago      Up 14 minutes       <IP_ADDRESS>:22->22/tcp, 443/tcp, <IP_ADDRESS>:10880->80/tcp   gitlab

Note that:
docker exec -it gitlabrunner_GitlabCIMultiRunner_1 bash
root@0e608eb62373:/home/gitlab_ci_multi_runner# ping git.develipsum.com
PING gitlab (<IP_ADDRESS>) 56(84) bytes of data.
64 bytes from gitlab (<IP_ADDRESS>): icmp_seq=1 ttl=64 time=0.214 ms
64 bytes from gitlab (<IP_ADDRESS>): icmp_seq=2 ttl=64 time=0.171 ms

As you can see, actually, runner takes the private network address and not the public one. It resolves the name to "gitlab" that is my container name. So I imagine that the runner tries to connect to <IP_ADDRESS>:443 that is not served by nginx reverse proxy (wich uses validated certificate)
The connection is refused.

OK ! Seeing #4 issue I understand that the data volume was not erased and the whole modification I made was not refreshed.
The solution is way simple. I needed to add a extra_host. This is what I set:
go-runner:
  image: sameersbn/gitlab-ci-multi-runner:1.1.3-1
  volumes:
    - ./data:/home/gitlab_ci_multi_runner/data
    - /var/run/docker.sock:/var/run/docker.sock
  environment:
    - CI_SERVER_URL=https://git.develipsum.com/ci
    - RUNNER_TOKEN=XXXXXXXXXX
    - RUNNER_DESCRIPTION=Golang CI runner
    - RUNNER_EXECUTOR=docker
    - DOCKER_IMAGE=metal3d/go:1.6
  restart: always
  extra_hosts:
    - "git.develipsum.com:<IP_ADDRESS>"

That way: git.develipsum.com is resolved by /etc/hosts correspondance
But... now... the runner cannot access my gitlab instance saying:
couldn't execute POST against https://git.develipsum.com/ci/api/v1/runners/register.json: Post https://git.develipsum.com/ci/api/v1/runners/register.json: dial tcp <IP_ADDRESS>:443: getsockopt: no route to host

Note that if I add again "external_link" to "gitlab", my extra_host is not used because (inside the runner container) "/etc/hosts" has got 2 entries:
- <IP_ADDRESS> git.develipsum.com
- <IP_ADDRESS> gitlab git.develipsum.com
And so, the local one is used by default, so git.develipsum.com is resolved to <IP_ADDRESS> that is not ok.
To be precise: the problem is that the runner takes the "public" repository url that cannot be resovled inside the docker network.

I just find the problem and I open another issue closing this one

@metal3d Did you find a valuable solution for this issue?

Hi, yes. Sorry to not explaine this sooner.
Ok my problem is that "git.develipsum.com" is served by an external container (nginx), and local docker network cannot hit my nginx by using "git.develipsum.com" so I did a "trick". See the "links" section and CI_SERVER_URL also:
go-runner:
  image: sameersbn/gitlab-ci-multi-runner:1.1.3-1
  volumes:
    - ./data:/home/gitlab_ci_multi_runner/data
    - /var/run/docker.sock:/var/run/docker.sock
  environment:
    - CI_SERVER_URL=http://gitlab/ci
    - RUNNER_TOKEN=XXXXXXXXXX
    - RUNNER_DESCRIPTION=Golang CI runner
    - RUNNER_EXECUTOR=docker
    - DOCKER_IMAGE=metal3d/go:1.6
  restart: always
  links:
    - nginx_nginx_1:git.develipsum.com

That way, "git.develipsum.com" is resolved using "internal docker ip" and it nginx.
CI_RUNNER are using "gitlab" container name to contact. But runners jobs want to hit "git.develipsum.com" to "git pull" the project. So !
After runner is up, I changed toml file to add links the same way:
links = ["nginx_nginx_1:git.develipsum.com"]

That way docker runner jons can resolve "git.develipsum.com" hitting "nginx" with the docker local ip and not the public one.

That means that runner dockerfile should probably allows to create "links" that are inserted inside the toml file without the need to change it manually...
@sameersbn ? you're ok with the idea ? Maybe I can provide a PR (if I find the time)

@metal3d There's no more words but thank you to express how much I appreciate your idea.  My case is about to host a gitlab server in my local docker and then I tried to run a docker gitlab runner locally, but always failed by telling "dial tcp <IP_ADDRESS>:80: getsockopt: connection refused". I knew it might relate to the network settings but don't know how to fix it as myself is a newbie in docker. I'd been working on that issue for almost 3 days until I found this. Now with your help I got it works just as expected. (Again thank you @metal3d !!!)
This's my docker-compse.yml which's simply based on this one, the last section is for starting up a docker runner.
services:
  redis: ...
  postgresql:...
  gitlab:
    contianer_name:'mg-gitlab'
    restart: always
    image: sameersbn/gitlab:9.1.0-1
    depends_on:
    - redis
    - postgresql
    ports:
    - "80:80"
    - "22:22"
    ....
  node-runner:
    container_name: 'mg-gitlab-runner-node'
    image: sameersbn/gitlab-ci-multi-runner
    volumes:
      - /somewhere on my mac/data:/home/gitlab_ci_multi_runner/data
      - /var/run/docker.sock:/var/run/docker.sock
    environment:
      - CI_SERVER_URL=http://gitlab/ci
      - RUNNER_TOKEN=MyToken
      - RUNNER_DESCRIPTION=NODE CI RUNNER
      - RUNNER_EXECUTOR=docker
      - DOCKER_IMAGE=node/7-slim
    restart: always
    links:
      - gitlab:gitlab.local.com


Update munit, munit-scalacheck to 0.7.29

Updates

org.scalameta:munit
org.scalameta:munit-scalacheck

from 0.7.28 to 0.7.29.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta" } ]

labels: test-library-update, semver-patch

Codecov Report

Merging #1817 (94ed07d) into master (4ab3ce2) will decrease coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1817      +/-   ##
==========================================
- Coverage   86.02%   85.89%   -0.13%
==========================================
  Files          73       69       -4
  Lines        2526     2482      -44
  Branches      144      135       -9
==========================================
- Hits         2173     2132      -41
+ Misses        353      350       -3

Impacted Files
Coverage Δ

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
87.13% <0.00%> (-0.59%)
:arrow_down:

...c/main/scala-2.13+/io/circe/FactoryInstances.scala

...rc/main/scala-2.13+/io/circe/LiteralDecoders.scala

...rc/main/scala-2.13+/io/circe/LiteralEncoders.scala

...main/scala-2.13+/io/circe/CollectionDecoders.scala

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ab3ce2...94ed07d. Read the comment docs.


Foundation.tabs - scroll_to_content: false doesn't work in Safari and Chrome

When using Foundation.tabs, clicking on a new tab resets the scrollTop position in Safari and Chrome when scroll_to_content is set to false.
This is a result of this line: https://github.com/zurb/foundation/blob/v5.2.2/js/foundation/foundation.tab.js#L114
var cur_ypos = $('body,html').scrollTop();
where foundation stores the scrollTop position of the body and html elements.
This always returns 0 in Chrome and Safari, so I suggest that it be changed to
var cur_ypos = $(document).scrollTop();
which will return the correct value in all browsers and fix this behavior.

Oops, old version of Foundation


Deprecate openssl 0.9.x support

It's no longer supported by the OpenSSL folks so we should look to drop support for that API at some point.
Does anyone have opinions on when?

It appears we might not want to deprecate this as it appears to be what libressl is supporting. At least, the libressl available in alpine.


crr_title_2

updated support.md

cmt2

cmt3

c4

started build successfully, pls wait for build status update

program_comment

program_comment_2

program_comment_22

new_program_comment_22i

Started jenkins build: http://dcs-jenkins.vlab.nimblestorage.com:8080/job/csi-driver_master_Dry1/42/

Started jenkins build: http://dcs-jenkins.vlab.nimblestorage.com:8080/job/csi-driver_master_Dry1/44/


Page update

:warning: Validation status: warnings

File
Status
Preview URL
Details

Web-Apps-Server-loc/deploy-office-web-apps-server.md
:warning:Warning

Details

Web-Apps-Server-loc/deploy-office-web-apps-server.md

[Warning] Invalid YamlHeader, ignored
Line 54: [Warning] Invalid file link:(~/httpstechnet.microsoft.comko-krlibraryjj219627(v=office.15)).
Line 78: [Warning] Invalid file link:(~/httpgo.microsoft.comfwlinkplinkid=252370).
Line 80: [Warning] Invalid file link:(~/httpsgo.microsoft.comfwlinkplinkid=256560).
Line 82: [Warning] Invalid file link:(~/httpsgo.microsoft.comfwlinkplinkid=244693).
Line 84: [Warning] Invalid file link:(~/httpsgo.microsoft.comfwlinkplinkid=293629).
Line 108: [Warning] Invalid file link:(~/httpsgo.microsoft.comfwlinkplinkid=510096).
Line 120: [Warning] Invalid file link:(~/httpsgo.microsoft.comfwlinkplinkid=256561).
Line 136: [Warning] Invalid file link:(~/httpsgo.microsoft.comfwlinkplinkid=510097).
Line 144: [Warning] Invalid file link:(~/httpsgo.microsoft.comfwlinkplinkid=280271).
Line 159: [Warning] Invalid file link:(~/httpsgo.microsoft.comfwlinkplinkid=263945).
Line 299: [Warning] Invalid file link:(~/httpsgo.microsoft.comfwlinkplinkid=256902).
Line 362: [Warning] Invalid file link:(~/httpsgo.microsoft.comfwlinkplinkid=256902).
Line 390: [Warning] Invalid file link:(~/httpsgo.microsoft.comfwlinkplinkid=256902).

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Closing PR without merging as changes made are incorrect


community package examples page

its to acknowledge the work react community has done and can help new commers to get to popular react packages

i will add more of packages


How to avoid getting permission denied (blocked)?

Hi folks,
I have developing a simple tool that sends out messages to any user who mentions me in their story. I was simply accessing ig.feed.directInbox() and its items().
For login I simply generate a device and use the ig.account.login(). I store the serialized state to later use it on my requests.
Starting yesterday the login works, but unfortunately retrieving the directInbox's items gets "Error 403  Forbidden - Permission denied".
If I open the app on my phone, the DMs do not show up and I get the following message "We're sorry, but something went wrong. Please try again later."
I believe my account may have been flagged, but couldn't find any information about this out there.
Does anyone know what can I do to solve and avoid this in the future?
This is the request GET /api/v1/direct_v2/inbox/?visual_message_return_type=unseen&thread_message_limit=10&persistentBadging=true&limit=20 - 403 Forbidden; Permission Denied

Have same problem


Updating Kubernetes-Anywhere getting started guide for vSphere

Updating K8S-Anywhere Getting Started Guide for vSphere based on the Menu Option changes made in the PR: https://github.com/kubernetes/kubernetes-anywhere/pull/437
Issue: https://github.com/vmware/kubernetes/issues/249
Summary of changes:

In the instruction for running deployment container mounted local /tmp directory so that kubeconfig.json file can be copied to the local machine easily.
Updated Menu Options and briefly describe each menu
Added OVA for vSphere 5.5
In cnastorage/kubernetes-anywhere image made vsphere as default provider.

New Image is uploaded at cnastorage/kubernetes-anywhere:08252017
Once this PR is approved, I will tag cnastorage/kubernetes-anywhere:08252017 to cnastorage/kubernetes-anywhere:latest
Please review: @rohitjogvmw, @BaluDontu, @tusharnt, @luomiao @msterin

@kerneltime @abrarshivani @shashidharatd Can you please help merge this PR? This PR updates the documentation based on the PR - https://github.com/kubernetes/kubernetes-anywhere/pull/437
Changes in the PR: https://github.com/kubernetes/kubernetes-anywhere/pull/437 is already reviewed and approved by @shashidharatd


Kapacitor union node doesn't work as expected

Bug report
System info: [Include InfluxDB version, operating system name, and other relevant details]
Ubuntu 16.04
InfluxDB 1.5.1
Kapacitor OSS 1.4.1 (git: HEAD b05bb0f6be089d6a1a391867ad4020344ce42a53)
Steps to reproduce:
Documentation says that union just passes points through
In my case I want to use union node to merge logic of writing data in database. I have points that are valid before union but union doesn't process them for some reason. When I remove union - points are writed in db as expected.
Simple script:

var values = stream
    |from()
        .measurement('measurement')

var o1 = values|where(lambda: "e1_a" > 0.01)
var o2 = values|where(lambda: "e1_a" < -0.01)

o1|union(o2)
    |influxDBOut()
        .database('kapacitor')
        .measurement('test_union')
        .buffer(0)

stream can be anything - doesn't matter in this case.
I just get points and filter them based on some logic and the points go in separate nodes and then I try to merge them again (collect resulted points) to write in database.
What I see is that when one of the parents of union node is empty - points doesn't flow through.

stream0 [avg_exec_time_ns="0s" errors="0" working_cardinality="0" ];
stream0 -> from1 [processed="289"];
from1 [avg_exec_time_ns="1.79µs" errors="0" working_cardinality="0" ];
from1 -> where3 [processed="289"];
from1 -> where2 [processed="289"];
where3 [avg_exec_time_ns="99.75µs" errors="138" working_cardinality="1" ];
where3 -> union5 [processed="0"];
where2 [avg_exec_time_ns="278.35µs" errors="138" working_cardinality="1" ];
where2 -> union5 [processed="151"];
union5 [avg_exec_time_ns="2.834µs" errors="0" working_cardinality="0" ];
union5 -> influxdb_out6 [processed="0"];
influxdb_out6 [avg_exec_time_ns="0s" errors="0" points_written="0" working_cardinality="0" write_errors="0" ];

Points are collected in node. It looks like a cache because when I stop script - all points go to database. It is very strange because documentation doesn't say anything about a cache and futhermore I don't see any reason for union to cache points.

This belongs in the kapacitor issue tracker.


[docs] In the Ethers example, the snipet has an error when calling "useAppKitProvider"

Summary
useAppKitProvider() asks for a chain name space. And it is being called without params in the example.
The Implementation section has a mistake.
The "ethersAdapter" is never instantiated to be fed into "createAppKit()" call.
Link to the related docs page
https://docs.reown.com/appkit/vue/core/installation#smart-contract-interaction

yes, they have done spellings error
import { Ethers5Adapter } from '@reown/appkit-adapters-ethers'
here it should be
import { EthersAdapter } from '@reown/appkit-adapter-ethers'

@prabhatkashyap902 I think what @ultraKelevra is referring to is this

Whereas the documentation show this without any parameters.

PR -> https://github.com/reown-com/reown-docs/pull/97


App Protection Policy doesn't list Yammer app for Android

I reached out to the Android Yammer Team and code was added in July 2020 so this should be updated.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bd934939-4dbb-3a92-f996-56b9557f49ac
Version Independent ID: 3cda6b81-26e8-c9ac-e768-d912636a461b
Content: Grant controls in Conditional Access policy - Azure Active Directory - Microsoft Entra
Content Source: articles/active-directory/conditional-access/concept-conditional-access-grant.md
Service: active-directory
Sub-service: conditional-access
GitHub Login: @MicrosoftGuyJFlo
Microsoft Alias: joflore

@lukevander
Thanks for your feedback! We will investigate and update as appropriate.
Since this channel is for driving improvements towards MS Docs, could you provide the URL of the specific documentation that your feedback is applicable to? That way, we are able to make sure your feedback is addressed by the right team

The URL in question is https://learn.microsoft.com/en-us/azure/active-directory/conditional-access/concept-conditional-access-grant?source=docs#require-app-protection-policy @SaibabaBalapur-MSFT

@lukevander
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly.
@MicrosoftGuyJFlo
Can you please check and add your comments on this doc update request as applicable.

It is there. Was added probably around the same time you made the issue. https://github.com/MicrosoftDocs/azure-docs/commit/b2f97f208513012d7f8fb26c5461c77e2c8406b7
#please-close


Daftar Besut Kode Universitas

Daftar Besut Kode Universitas Tomi Firman Cahyadi

Incomplete.
Checklist:
:heavy_check_mark: Registration form
:heavy_check_mark: Project Euler Baby Steps
:x: GitHub Pages with Project Euler username
:x: 50 :star: GitHub repository contribution
:heavy_check_mark: bahasa Indonesia Wikipedia userpage mentioning Besut Kode Universitas
:heavy_check_mark: bahasa Indonesia Wikipedia content edit
:heavy_check_mark: StackOverflow account with at least one badge
:x: Besut Kode markdown Pull Request

You haven't created your GitHub Pages.
You haven't submitted a PR to the 50 :star: repo.
Your markdown edit: the first column should point to your GitHub Pages (i.e.: TomiFirman), and the last column should look like this: cSploit/android.
Also, note that this PR now has a merge conflict as I just merged another PR.

Please submit a new pull request once more, after re-reading http://wikimedia-id.github.io/besutkode/university-modules-id.html and completing the tasks.
If you need help, ask on the Telegram chat group "Besut Kode Universitas".


Cleanup switch

The document states the obvious: that the Cleanup switch "attempts to force a clean-up of the root target in Active Directory Domain Services".  But one is still left wondering what this cleanup entails, that the delete of the target does not already accomplish.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c85cdb14-7ddb-bb14-fa9e-b19e563cd80e
Version Independent ID: c6b90405-cd80-c45c-4812-dbc6100f6bfb
Content: Remove-DfsnRootTarget (dfsn)
Content Source: docset/windows/dfsn/remove-dfsnroottarget.md
Product: w10
GitHub Login: @coreyp-at-msft
Microsoft Alias: coreyp

Hi @swatt6400
Thanks for reaching out!
-Cleanup parameter attempts to force a clean-up of the root target in Active Directory Domain Services (AD DS). We can add this parameter when you have a situation where the cmdlet would otherwise fail, but can be convinced to complete the action.
Hope this information is helpful. Kindly confirm. Thank you.

Ah yes, that does clarify a bit more, thanks for giving it some
attention to improve for everyone!  :)
________________________________________________________
    Sandra Watt, B.Sc., MCITP Enterprise Administrator, MCTS .NET
    WPF
    Bermuda Information Technology Systems (BITS) Ltd.
<EMAIL_ADDRESS>/<EMAIL_ADDRESS><PHONE_NUMBER>

On 4/25/2019 9:20 AM, sowjanya365
  wrote:

  Hi @swatt6400
  Thanks for reaching out!
  -Cleanup parameter attempts to force a clean-up of the root
    target in Active Directory Domain Services (AD DS). We can add
    this parameter when you have a situation where the cmdlet would
    otherwise fail, but can be convinced to complete the action.
  Hope this information is helpful. Kindly confirm. Thank you.
  —
    You are receiving this because you were mentioned.
    Reply to this email directly, view
      it on GitHub, or mute
      the thread.
  {"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/MicrosoftDocs/windows-powershell-docs","title":"MicrosoftDocs/windows-powershell-docs","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/MicrosoftDocs/windows-powershell-docs"}},"updates":{"snippets":[{"icon":"PERSON","message":"@sowjanya365 in #375: Hi @swatt6400 \r\n\r\nThanks for reaching out!\r\n\r\n-Cleanup parameter attempts to force a clean-up of the root target in Active Directory Domain Services (AD DS). We can add this parameter when you have a situation where the cmdlet would otherwise fail, but can be convinced to complete the action.\r\n\r\nHope this information is helpful. Kindly confirm. Thank you."}],"action":{"name":"View Issue","url":"https://github.com/MicrosoftDocs/windows-powershell-docs/issues/375#issuecomment-486649206"}}}
  [

{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/MicrosoftDocs/windows-powershell-docs/issues/375#issuecomment-486649206",
"url": "https://github.com/MicrosoftDocs/windows-powershell-docs/issues/375#issuecomment-486649206",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]

Hello @swatt6400,
We are closing this issue since your support question seems to be answered. Feel free to re-open this issue if you still experience problems.
Thanks.

@officedocsbot close


[fix][broker] Fix thread-safety issue with currentLedgerEntries and currentLedgerSize fields

Motivation

currentLedgerEntries and currentLedgerSize fields are currently mutated and read from multiple threads which is a problem.

one solution is to make the fields volatile

Modifications

make fields volatile

Documentation

[ ] doc-required
(Your PR needs to update docs and you will update later)

[x] doc-not-needed
(Please explain why)

[ ] doc
(Your PR contains doc changes)

[ ] doc-complete
(Docs have been already added)

Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->

I noticed this while working on #17252

Codecov Report

Merging #17868 (fdff41a) into master (22866bd) will decrease coverage by 16.89%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             master   #17868       +/-   ##
=============================================
- Coverage     45.92%   29.02%   -16.90%
+ Complexity    10104     5576     -4528
=============================================
  Files           680      626       -54
  Lines         66758    59236     -7522
  Branches       7147     6154      -993
=============================================
- Hits          30660    17196    -13464
- Misses        32680    39575     +6895
+ Partials       3418     2465      -953

Flag
Coverage Δ

unittests
29.02% <ø> (-16.90%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.


Can a Tabbar item open a Modal window?

Hello,
I would like to ask if it's possible to open a modal window, when clicking on a tabbar item.

Yes, but you'd have to set a state somewhere for open or close modal.  Have you attempted this yet?  If so and you're having issues, please post some code :)

<Scene key="tab3"
                                    title=""
                                    navigationBarStyle={CommonStyles.navBarStyle}
                                    titleStyle={CommonStyles.navTitleStyle}
                                    leftButtonIconStyle={CommonStyles.menuBarBtnIconStyle}
                                    tabStyle={styles.bottomTabStyle}
                                    drawerImage={this.state.drawerImage}
                                    icon={TabIcon}
                                    iconName={(Platform.OS==='android'?'md':Platform.OS)+'-add-circle'}
                                    onSelect={this.onSelectTab.bind(this)}/>

onSelectTab(el) {
        if (!Actions[el.props.name]) {
        throw new Error(
            `No action is defined for name=${el.props.name} ` +
            `actions: ${JSON.stringify(Object.keys(Actions))}`);
        }
        if(el.props.name!='tab3')
        {
            Actions[el.props.name]();
            this.props.dispatch(ChangeMainSelectedTab(el.props.name));
            this.props.dispatch(ChangeMainToolModalVisible(false));
        }
        else
        {
            this.props.dispatch(ChangeMainToolModalVisible(true));
        }
    }

you can overwrite onSelect of tabbar

Alright, so drawer seems SUPER broken right now.
Simply by commenting out the "drawer" container around my code I was able to launch the vertical scene with no other modification.

@perrosnk Can you confirm this answered your question?


[Find My Mouse] Automatically activate when mouse has been inactive for a while

Description of the new feature / enhancement
When the mouse has been inactive for a configurable amount of time find-my-mouse is automatically activated when the mouse becomes active again.
Scenario when this would be used?

When a keyboard is out of reach
More convinient than pressing a shortcut

Supporting information
An analog feature that probably could be added in the same breath: Automatically deactivate find-my-mouse after the mouse becomes active and a certain time has passed. This would allow the following workflow:

Mouse not used for certain amount of time
User doesn't know where they left the mouse and starts using it
Find-my-mouse becomes active
User finds mouse
Shortly after: find-my-mouse becomes inactive automatically

i don't think we'll implement this feature from a PowerToys stance.  We'll add Shake to activate in 0.56 and that would solve the scenario above.

from a PowerToys stance
Can you elaborate a bit what you mean by this?

I think my suggestion is superior to a shake-activation in several ways (works better regardless of speed of input device, user doesn't have to shake, seemlessly activates and deactivates by itself, no delay of activation). Of course I'm only one person, but I never found shake-to-find-mouse on mac useful since I expect to find my mouse by moving it. If I don't find it right away I have to vigorously shake the mouse to activate enlargement (on a mac) which already helps me find the mouse without the enlargement.