Update Screenshots in README

The front-end design has evolved but the README still shows the old, boring design. Update the screenshots in README to show the updated design.

@Kalwing Why not add your screenshots here?

i want to work on this

@GingerDragon7 Sure. Just do it!

I will try this one

fix it, add new README

@airqz Looks good! Make a pull request so that I can merge it.


Figured out what segmentation technique is reproducible across platforms; improve test sensitivity.

Some segmentation methods are not reproducible across OSs, leading to non-reproducible pipelines across OSs.  This PR was initiated by https://github.com/neuropoly/spinalcordtoolbox/issues/2769.
The purpose of this PR is to:

[x] Check if sct_get_centerline -method optic is reproducible across OSs

[x] if it is, make the test more sensitive by asserting a Dice of 1.0. Fixes https://github.com/neuropoly/spinalcordtoolbox/issues/2773.

[x] Check if sct_deepseg_sc is reproducible across OSs

[x] if it is, make the test more sensitive.

[x] Fixes minor issue in usage of sct_get_centerline. Fixes https://github.com/neuropoly/spinalcordtoolbox/issues/2772
[x] Check if sct_deepseg is reproducible across OSs

[x] if it is, make the test more sensitive.

When removing test_sct_deepseg_lesion from the testing suite, test_sct_deepseg_sc runs fine.

The culprit is test_sct_deepseg_lesion:test_segment()

Strangely, when running test_sct_deepseg_lesion, I am getting this pytest fail on the next test: test_sct_deepseg_sc.
Details
When removing test_sct_deepseg_lesion from the testing suite, test_sct_deepseg_sc runs fine.

Are you having the same fail with test_sct_deepseg_sc with 3d kernels? (test_sct_deepseg_lesion and test_sct_deepseg_sc-3D are using the same architecture)

Are you getting the same fail with test_sct_deepseg_sc with 3d kernels? (test_sct_deepseg_lesion and test_sct_deepseg_sc-3D are using the same architecture)

nope, if i skip the kernel=2d test, the kernel=3d test passes. I hope you have a clue @charleygros 😊

do you think data/deepseg_sc_models/t2_sc.h5 could somehow be corrupted? (i.e. we are not using the proper version)

do you think data/deepseg_sc_models/t2_sc.h5 could somehow be corrupted? (i.e. we are not using the proper version)

The SC 2D model? What makes you think this is the case? I am scared I am missing something.
This test was running fine when runnning by itself on my local machine. So it might be a corrupted file that... not sure yet.

The SC 2D model? What makes you think this is the case? I am scared I am missing something.

because the link to the model bundle has been updated a few hours ago. However, since #2733 passed on Travis, this is likely not the issue (but i remain skeptical)

test_sct_deepseg_lesion:test_segment() is working fine when ran by itself with the OSF model.

test_sct_deepseg_lesion:test_segment() is working fine when ran by itself with the OSF model.

yes, this test never had a problem. The problem is test_sct_deepseg_sc that comes after test_sct_deepseg_lesion:test_segment. More particularly, test_sct_deepseg_sc:test_deep_segmentation_spinalcord() with kernel=2d

The SC 2D model? What makes you think this is the case? I am scared I am missing something.

because the link to the model bundle has been updated a few hours ago. However, since #2733 passed on Travis, this is likely not the issue (but i remain skeptical)

That's possible: I am on your branch but I haven't downloaded the data from GH, still have the OSF ones --> I can't reproduce this error from there.

And I dont think it comes from the testing data since test_lesion generates its own dummy data.
I would be suspicious of these lines maybe: since the tensor organisation differs between test_lesion and test_sc

And I dont think it comes from the testing data since test_lesion generates its own dummy data.
I would be suspicious of these lines maybe: since the tensor organisation differs between test_lesion and test_sc

ah! sh... you're probably right. I'm sorry, i removed those because i thought they were no more used (since i was calling a parent function). Let me try-- but i think you found the culprit!

The reported fail pointed tensor issue... so I would be even more suspicious of these lines.

it works 🎉 !!! thank you so much @charleygros !! you saved my evening 😊


Feedback for: engine/getstarted-voting-app/create-swarm.md

File: engine/getstarted-voting-app/create-swarm.md
There seems to be a bug regarding the deployment. If you enter all commands and eventually
docker@manager:~$ docker stack deploy --compose-file docker-stack.yml vote
it will eventually output
Error response from daemon: rpc error: code = 4 desc = context deadline exceeded
This seems to be a configuration error. The log doesn't seem to be too helpful either:
docker@manager:~$ cat log.log
NEW boot2docker managed disk image (/dev/sda): formatting it for use
All commands have been entered as suggested (including the docker-stack.yml) so the bug should be replicable easily.
It should be said that during creation of both machines, it said
Originally I assumed this issue to be related to #1193 but it doesn't seem so.

@ManoMarks @mstanleyjones @friism @johndmulhausen  can you guys take a look at this? I've not gotten this error when I walked through this. Can someone re-produce it?

Ran through this exactly, I can't replicate this issue. Can you give us more info? Are you running this on Mac? Linux?
On possibility is you're running into resource constraints on the host, I suppose. Do you have a lot of machines running?
Also could be related to Error response from daemon: rpc error: code = 4 desc = context deadline exceeded

I just tried to replicate it again today and it worked. Must have been something environment related. For future reference, I ran this on Linux with no other machines running. Thanks a lot!

@AdHominem thanks, glad it worked for now! 😺

@AdHominem I have the same issue as you, with a fresh 1.13 install :(
I tried to reinstall docker, prune system... but nothing work, I have always:
example-voting-app (master) docker stack deploy --compose-file docker-stack.yml vote
Creating network vote_backend
Creating network vote_frontend
Creating network vote_default
Creating service vote_vote

here is the docker info
Containers: 0
 Running: 0
 Paused: 0
 Stopped: 0
Images: 0
Server Version: 1.13.1
Storage Driver: overlay2
 Backing Filesystem: extfs
 Supports d_type: true
 Native Overlay Diff: true
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: bridge host ipvlan macvlan null overlay
Swarm: active
 NodeID: ch9ui0mvg97rcmhv6gvc0td99
 Is Manager: true
 ClusterID: l1qo1y737o1837azuyhnz0m23
 Managers: 1
 Nodes: 1
 Orchestration:
  Task History Retention Limit: 5
 Raft:
  Snapshot Interval: 10000
  Number of Old Snapshots to Retain: 0
  Heartbeat Tick: 1
  Election Tick: 3
 Dispatcher:
  Heartbeat Period: 5 seconds
 CA Configuration:
  Expiry Duration: 3 months
 Node Address: <IP_ADDRESS>
 Manager Addresses:
  <IP_ADDRESS>:2377
Runtimes: runc
Default Runtime: runc
Init Binary: docker-init
containerd version: aa8187dbd3b7ad67d8e5e3a15115d3eef43a7ed1
runc version: 9df8b306d01f59d3a8029be411de015b7304dd8f
init version: 949e6fa
Security Options:
 seccomp
  Profile: default
Kernel Version: 4.9.8-moby
Operating System: Alpine Linux v3.5
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 1.952 GiB
Name: moby
ID: DCF3:USNC:K2NZ:SRI5:F3J5:KVE7:7A4T:YICD:M5QM:AC2E:GWHU:KH43
Docker Root Dir: /var/lib/docker
Debug Mode (client): false
Debug Mode (server): true
 File Descriptors: 32
 Goroutines: 130
 System Time: 2017-02-11T08:36:00.847915872Z
 EventsListeners: 1
No Proxy: *.local, 169.254/16
Registry: https://index.docker.io/v1/
Experimental: true
Insecure Registries:
 <IP_ADDRESS>/8
Live Restore Enabled: false

Please help :(

@friism can you all have another look? @ManoMarks  and I could not reproduce this issue, and @AdHominem also reported that everything worked fine on re-install.

This is a swarm-problem that should be reported on docker/docker.

Bug solved in
Version 1.13.1 (15353)
Channel: Stable

@thaJeztah closing this issue (along with the related issue  in docker/docker/#30988  ) since it's not reproducible and the folks who originally reported it have since resolved it in their environments.

docker@manager1:~$ docker stack deploy -c vote.yml vote
Updating service vote_visualizer (id: kbj751lbx3gmq0uiqphm2wz54)
Updating service vote_redis (id: tbcw0jkx6e15ie7ndawts9391)
Error response from daemon: rpc error: code = 4 desc = context deadline exceeded
docker@manager1:~$ docker info
Containers: 3
Running: 3
Paused: 0
Stopped: 0
Images: 3
Server Version: 1.13.1


chore(shared-data): Update the waste chute dimensions for the new lowered lid

Overview
Closes RSS-394.
Test Plan

[ ] Drop some tips with an 8-channel pipette. It should be 10 mm below the new, shorter lid.

The new lid doesn't physically exist at the time of writing, so you'll have to use your 🌈imagination🌈. The lid would be roughly flush with the top of the lid-less waste chute.

Changelog
Shorten the waste chute's enclosing bounding boxes. They now enclose just the lid-less part, since the new lid won't extend any higher than that. (I don't think, anyway. But see the note in the review requests.)
Lower the 1- and 8-channel drop offsets to be 10 mm below the new lid instead of 10 mm below the old lid.
Review requests
This is pending one clarification from HW on the "max envelope of chute" numbers.
Risk assessment
Low.

If I'm reading the edge code correctly, I think this is blocked behind us having a height field in cutout fixtures, separate from the heights of addressable areas. The pipette needs to clear the rim of the waste chute and descend into it to meet the addressable area.


Consider moving off PyYAML to ruamel.yaml

PyYAML's current wheels do not appear to work for some Windows users. Specifically, they cause some Cookiecutter installations to fail. Also, there hasn't been a release endorsing use of Python 3.5. The PyYAML site hasn't seen an update in a long time.
On the other hand, https://pypi.python.org/pypi/ruamel.yaml is a fork/derivative of Kirill Simonov’s PyYAML. It appears to be working. We'll check on local Windows test machines to determine if it is a suitable replacement.

Resolved via #558 :+1:

Installation on Win 7 fails for Cookiecutter 1.2.1 :worried:

It tries to install ruamel.yaml>=0.10.12. :confused:
See https://ci.appveyor.com/project/hackebrot/pytest-cookies/build/1.0.9/job/0m3dw868u1a7s79w
Breaks on local Win 7 box too.
Is it because the wheel is universal and somehow doesn't get that it is installed on win?

This snippet was supposed to prevent PyYAML being installed on Windows machines installing it in a Python 2.7 environment: https://github.com/audreyr/cookiecutter/blob/master/setup.py#L38-L44
Clearly, it's working for some, but not all. Hand. Bang. Desk.

I think I understand now: Because Cookiecutter is installed as a Wheel in modern pip, I think it's already been compiled. So while it works great off source, it fails in formal releases. :cry:

@audreyr @pydanny can you please explain why win7 requires special treatment? :bow:
I set up Cookiecutter v1.2.1 on another win box with x64 python and it worked just fine.
@ionelmc pointed out the according wheel is broken. I updated a issue in the ruamel.yaml tracker.

@pydanny use extras_require instead: https://wheel.readthedocs.org/en/latest/index.html?highlight=marker#defining-conditional-dependencies

@ionelmc Thanks! We'll use that going forward
However, what we're facing is:

For better or worse, PyYAML is effectively unmaintained. It breaks on Windows using Python 3.5.
raumel.yaml works on on Windows using Python 3.5, but can apparently break on Windows using Python 2.7 and we've gotten a couple reports of issues on Mac OSX using Python 2.7.

What we're working on is making YAML optional, and using JSON as the fallback for ~/.cookiecutterrc.

under Ubuntu 15.10, using pyvenv created a virtual environment, then activate it, and pip install cookiecutter.
when run cookiecutter https://github.com/pydanny/cookiecutter-django.git command, get error message:
1>.  "Import Error: No module named 'click'" from cli.py line 15.
after pip install click
2>. run the previous command, no click error but get another:
"Import Error: No module named 'ruamel'" from config.py line 20.
3>. tried to pip install ruamel or yaml,
No distributions at all found for ruamel / yaml.
Sure it worked fine ten days ago under Ubuntu 14.04 environment with virtualenv where I used it created a project.

Can I close this?

I think so @pydanny


Adding loginMsgAck to the ansibile playbook results in the following error

Adding loginMsgAck to the ansibile playbook results in the following error:
fatal: [localhost -> localhost]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (oneview_alert_facts) module: loginMsgAck Supported parameters include: api_version, auth_login_domain, config, hostname, image_streamer_hostname, params, password, username"}
Sample:
oneview_alert_facts:
username: "{{ synergy_userName }}"
password: "{{ synergy_password }}"
loginMsgAck: "true"
auth_login_domain: ""
hostname: "sample"
api_version: 1000
Whilst we can use a config file to make this work, its not that conducive when working with vaults since the config param only seems to accept file input.

Ref https://github.com/HewlettPackard/oneview-ansible/issues/360

LoginMsgAck flag is handled inside latest python SDK. User don't need to provide that attribute in playbook. Providing the "LoginMsgAck" attribute in playbook leads to the above mentioned error.
Simply remove that attrib and run your playbook and this will resolve this issue. So closing this issue for now.
Please feel free to reopen if you are still facing any issues.
I have mentioned the related python issue for reference.
https://github.com/HewlettPackard/oneview-python/issues/58


[PYTHON] Support string parameter instead of list for eval_algo_data when passing raw shader as string

Currently it's only possible to pass a shader string as a list of characters, given this is qutie inefficientin python, best would be to extend the function to be able to just accept a string.

Closed via #105


Review of reference content

Updated content around references when:

Getting confirmation of submitting an application
Editing an application
Making a request for adding a new referee:

Overdue
Declined
Cancelled

Making a request for adding a new referees. Examples:

Overdue/Declined
Declined/Cancelled
Cancelled/Overdue

Showing contextual guidance alongside a references status:

Looks awesome thanks @paulrobertlloyd !


Code snippets

Create a tool that have a collection of snippets

@Bashamega can you give me more details on it. So that i can start working on it??

@Bashamega can you give me more details on it. So that i can start working on it??

Sure.
It will be similar to https://freefrontend.com/

Shall i do for HTML and CSS for now. Later we can start adding React components?

Shall i do for HTML and CSS for now. Later we can start adding React components?

sure

Hello @Smnthjm08 :)
Did you start working on this issue. If not when will you start working on it.

will try to complete it before this sunday


Fix spurious failure of the check/all script

Avoid passing an empty string argument to check/format-incremental
when invoked from check/all

Improve validation of the git-revision argument in check scripts by
allowing git tags that resolve to a commit

Fix invalid use of ? in egrep pattern

Make check/mypy pass in the dev.env.txt virtual environment

@95-martin-orion - can you PTAL?


To catch C/C++ signed/unsigned overflow

Great Improvement has been made for UTBot 167, more robust and stable. but I am expecting UTBOT to catch C/C++ signed/unsigned overflow directly.
int absolute(int a)
{
	if (a < 0){
		return -a;
	}
	else {
		return a;
	}
}

typedef unsigned int     uint32_t;
uint32_t change_val()
{
    uint32_t val=255*1024*1024;
    uint32_t new_val;
    new_val = (((uint32_t)(val))*1024*1024);
	return new_val;
}

There are overflow in above 2 functions, but UTbot didn't report issue.  Can UTBot report issue (or at least warn users) if there is overflow issues?

@sava-cska, please investigate test generation then the option is on.


HTTPCLIENT-1968

https://issues.apache.org/jira/browse/HTTPCLIENT-1968
Make the normalization optional (default == true) based on RequestConfig setting. All the legacy spots just keep "default" behaviour, while the current bits are obeying the new param in request config.

Not a complete solution: IF relative redirects happens (and are allowed), java.net.URI#resolve(java.net.URI) is being used that WILL normalize, despite the setting in RequestConfig

@cstamas One can get actual RequestConfig settings from the execution HttpContext at any point of request execution.

@ok2c Sure, but that would mean that we need to reimplement java.net.URI#resolve(java.net.URI) in body of org.apache.http.client.utils.URIUtils#resolve(java.net.URI, java.net.URI) method, something I see out of the scope of this PR.
IMO, for now this PR is ok, and allows people to step over and upgrade their client.

@cstamas Could you please squash all commits into a single one? I will go over the changes one more time and will merge the PR.

@ok2c Done

@ok2c Seems Travis build failed but it is still OK for me (and was OK Travis last two builds before squash), is there some concurrency problem in UTs?
[INFO] --- maven-bundle-plugin:3.5.1:install (default-install) @ httpclient-osgi ---
[INFO] Installing org/apache/httpcomponents/httpclient-osgi/4.5.8-SNAPSHOT/httpclient-osgi-4.5.8-SNAPSHOT.jar
[INFO] Writing OBR metadata
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache HttpComponents Client 4.5.8-SNAPSHOT:
[INFO]
[INFO] Apache HttpComponents Client ....................... SUCCESS [  2.315 s]
[INFO] Apache HttpClient .................................. SUCCESS [ 31.340 s]
[INFO] Apache HttpClient Mime ............................. SUCCESS [  2.958 s]
[INFO] Apache HttpClient Fluent API ....................... SUCCESS [  3.021 s]
[INFO] Apache HttpClient Cache ............................ SUCCESS [ 12.242 s]
[INFO] Apache HttpClient Windows features ................. SUCCESS [  2.831 s]
[INFO] Apache HttpClient OSGi bundle ...................... SUCCESS [  4.976 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:00 min
[INFO] Finished at: 2019-02-14T13:55:32+01:00
[INFO] ------------------------------------------------------------------------
cstamas@Urnebes ~/Worx/apache-httpcomponents/httpcomponents-client  (HTTPCLIENT-1968)$

@cstamas One of TestFutureRequestExecutionService tests appears to fail intermittently due to a race condition. It is certainly unrelated to your changes.

@cstamas Awesome. Could you please rebase off 4.5.x HEAD and squash intermediate commits? I'll merge the PR as soon as it is done. I also have fixed the flaky test case in 4.5.x.

@ok2c done

@cstamas Feel free to review PR #137 if you feel like.

@cstamas It turned out this change-set had broken backward compatibility with 4.4. Fixed with c7985395635cbc7bd630abb4204534536cbdf8ce.

Ouch! Yes, i forgot to provide subst/old signature method for this.. Tx


Adding original code to image metadata

Right now, converting the default example to png gets you this:

If you run it through https://www.get-metadata.com/
You get this:

It would be cool to be able to add the original code snippet to the metadata, maybe on the content attribute.
How would we add the original code to the image metadata so that we could do something like.
var carbon-image = document.getElementById("carbon-image");
            EXIF.getData(carbon-image, function () {
                var allMetaData = EXIF.getAllTags(this);
                var allMetaDataSpan = document.getElementById("allMetaDataSpan");
                allMetaDataSpan.innerHTML = JSON.stringify(allMetaData, null, "\t");
            });

Using the example code from exif-js
It might look something like this. Note the metadata showing under some of the images:

Thank you.

@idkjs if you are familiar with this sort of thing, we would love to accept a PR. I am completely foreign to image metadata, especially editing it in the browser.

@mfix22 i tried messing with it before i posted the comment. The code text comes back on state.code in pages/index.js
https://github.com/dawnlabs/carbon/blob/7b9c31101e2abf743bc1fe68038cf1f4157e3e15/pages/index.js#L41-L48
If you comment out   delete s.code you are not longer deleting the code info and so you get it back:

After that I can't find it, mostly because I cant seem to log anything to console anywhere in the program after index(tell me how, and i will get at it). But if I could, I would try to append the code info to some property. The photographer key below seem to provide for that, but i guess we aren't using that.
https://github.com/dawnlabs/carbon/blob/7b9c31101e2abf743bc1fe68038cf1f4157e3e15/components/Editor.js#L185-L194
Setting this up makes it a lot more useful for using this in blogs. In fact, unsplash is already integrated into medium.com so maybe not to far away.
Thoughts?

Accessing the code text is super doable. I am just wondering if you know how to encode anything as metadata into a PNG being saved using JavaScript (:
Also I'm a little confused about your log comment. console.log should log to the DevTools if you are using Chrome or FireFox.

Cool project. A while back I wrote a utility in golang to embed tEXt chunks in png images. Have a look at the relevant bits here: https://github.com/sabhiram/png-embed/blob/master/embed.go

I don't believe it is possible to write the metadata into the PNG in the browse, which is our primary method for generation.
Closing this as wont-fix, but if someone is aware of an alternative, I will reopen 🙂


Mandd/ga/distributions

Pull Request Description
What issue does this change request address?
This PR contains the changes on the Phisics code interface that are part of the GA PR #1253.
What are the significant changes in functionality due to this change request?
This adds a unit test for randomUtils.randomChoice

For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.

[x] 1. Review all computer code.
[x] 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
[x] 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
[ ] 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
[x] 5. If significant functionality is added, there must  be tests added to check this. Tests should cover all possible options.  Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in  XML block, the node <internalParallel> to True.
[x] 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change.  The requirements and the requirements test shall be in sync.
[x] 7. The merge request must reference an issue.  If the issue is closed, the issue close checklist shall be done.
[x] 8. If an analytic test is changed/added is the the analytic documentation updated/added?
[x] 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

Job Test mac on 6274809 : invalidated by @mandd

Board is green. Merging


Implement AI PR review

Created reviewdog static checks, not adding much value to it, look for AI checks


Ensure cookies aren't sent if credentials: omit

If the default value of withCredentials is true, as opposed to false, the library will send the cookies even if credentials: omit is specified. This affects React Native where the default value is true since cross-origin concerns don't apply.

Yes, we very much need this for React Native's fetch because the XMLHttpRequest.sendRequest default value of withCredentials is true to match the native platforms' default behavior.
Thank you @satya164!

Makes sense; thanks!

Just ran into this issue in React Native. Could you please publish a new version of this package with this fix?
Thanks.


Update avrohugger-core to 1.0.0-RC21

Updates com.julianpeeters:avrohugger-core from 1.0.0-RC19 to 1.0.0-RC21.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.julianpeeters", artifactId = "avrohugger-core" } ]

labels: semver-pre-release

@BenFradet yep, it looks the types have changed. I'm planning to fix this at some time this week

superseded by #716


Add default hint for hardware wallet errors

Signing fails if another process has an open connection with a Ledger for example. Async-hwi needs to have a more detailed error api in order to handle graciously errors, but for now we provide a hint to what to check for the user
close #381

Async-hwi should infer more error case in its API. https://github.com/wizardsardine/async-hwi/issues/74
in order for the gui to have specific message per error.

This is good enough for now.


fixed amount is applied on product for customer group price instead of apply in %

Bug report
Title
fixed amount is applied on the product for customer group price instead of applying in %
Issue Description
fixed amount is applied on product for customer group price instead of apply in %
Preconditions
1. framework Version- master

Steps to reproduce
1. step1- edit product and add customer group price (discount/fixed) any
2. step2- login with the same customer group account
3. step3- check the discounted amount for that product in product page

Expected result

if customer price is in terms of discount then it should calculate % basis of product price

if customer price is in terms of fixed-rate then it should less same amount from product price

Actual result

Hi, @jitendra-webkul
In case of fixed type price it's still not resolved, please check
https://prnt.sc/svplrr
https://prnt.sc/svplrr

Not an issue
Thanks


remove org. notifications: dialog view is not removed from DOM

when closing "remove org. notifications" dialog we should destroy the view, as we do in asset picker
https://github.com/CartoDB/cartodb/blob/master/lib/assets/core/javascripts/cartodb/organization/icon_picker/icons/organization_icons_view.js#L249
dialogs are not being removed after close, and new views keep adding to the DOM

Hey, we have been working in this modal, why not add it here https://github.com/CartoDB/cartodb/issues/11957?

👍 for me, I didn't want to bloat the issue with more stuff now it passed CR already

tacked https://github.com/CartoDB/cartodb/pull/11961

Nice!

Closed because it is already done.


Typo fix.

Description:
Typo fix.
Related issue (if exists):

Coverage remained the same at 97.734% when pulling a009a5b7c4a8e8f236d6047db94d1a6328382d27 on KwintenP:timeout-comment-typo-fix into 80a5ea7050320b37cb723407cb3fdde2ab2cd6eb on ReactiveX:master.

Will fix with proper commit message according guidelines


Create ROLib.netkan

... And now I've remembered that I'm supposed to hit the button to accept the change!

Looks good, thanks for the submission.


⚠ GazelleGames has degraded performance

In 8fe9395, GazelleGames ($GGN) experienced degraded performance:

HTTP code: 200
Response time: 3412 ms

Resolved: GazelleGames performance has improved in 107dfaf.


bug(Table): Sticky column loses the bottom border

Reproduction

Components: https://material.angular.io/components/table/examples

Steps to reproduce:

Go to the material examples website and go to the example Table with sticky columns

Expected Behavior
What behavior were you expecting to see?
Display the bottom border in the sticky column in Chrome as it does in Firefox.

Actual Behavior
What behavior did you actually see?
The bottom borders disappear

Environment

Angular: 11
CDK/Material: 11.1.1
Browser(s): Chrome 88.0.4324.150
Operating System (e.g. Windows, macOS, Ubuntu): Windows

Did you have to do anything in order for the border to disappear? It seems to be working for me on Chrome 88.

No, it's the default. I have tried Microsoft Edge 88 and the same thing happens to me.

If I change the color of the border, you can see that it is thinner.

I couldn't reproduce it on a different machine either. My suspicion is that this could be some weird artifact due to a particular OS/driver/browser combination.

Yesterday I was testing on another computer, it has a resolution of 1080p, and it looks fine. I think the problem comes from the combination of screen resolution and browser.
The screen that gives me problems has a resolution of 3840x2160 and a text increase of 150% (This is what Windows recommends).

That makes sense, we've had similar reports about other components. The problem is that when the border is that thin, the browser has to approximate it when accounting for zoom. At some point it may approximate it closer to 0px than to 1px. I'm not sure whether we can do much about it without making the border thicker.

So, it's a bug in the Chrome approximation, or in general Chromium because it also happens in Edge, since it doesn't happen in Firefox.

@crisbeto Can we close this issue if this is due to browser behavior & outside of our control?

Yes, I don't think that we can do much about it.


Missing FA5 network-wired

The Font-Awesome v5 network-wired icon is missing.

Missing ethernet too.

Latest version includes the latest icons:
sample-puml-with-network-wired

Thanks much.


Fix broken oss-fuzz build

Fixes build by using go 1.18 and using compile_native_go_fuzzer for the Go 1.18 fuzzer.
Signed-off-by: AdamKorcz<EMAIL_ADDRESS>

Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=46357#c9

Is this a temporary fix or will this script need to be updated to match golang updates?

This a temporary fix until OSS-Fuzz switches to Go 1.18 and adds end-to-end support for the native fuzzing engine: https://github.com/google/oss-fuzz/issues/7600


Added several tx tests

Hi @jgarzik ,
This pull request copies tx tests from bitcoin-core 0.12 and makes some fixes so all tests pass. This means that all tx tests (tx_valid.json & tx_invalid.json) from bitcoin-core 0.12 (pre-SegWit) are now passing.
In the near future I may look into adding SegWit functionality to the libbitc library and when finished will update the picocoin library also. But before tackling SegWit I will be adding the sighash.json tests from bitcoin-core.
libbitc  now uses an embedded cJSON library instead of the libjansson dependency of picocoin. This means that after cherry-picking a commit from  libbitc a small bit more work needs to be done to any JSON dependent code to make it suitable for picocoin. This will again be the case if I merge sighash.json tests with picocoin; but it shouldn't be too much work, we'll see.

Coverage increased (+0.7%) to 78.311% when pulling 423c3f5ed32953398c428219ce4eb420741d4dd2 on libbitc:picocoin into f1551ce063fda1d8e66cbbedfddd86f33e0064d5 on jgarzik:master.


A potential solution to the issue : "Invalid RNPermission X. Should be one of: ()"

I'm not respecting the template, but I wanted to make a suggestion  for the issue : #434
Invalid RNPermission X. Should be one of: ()

In my case I’m using use_frameworks! and by adding only Permission-LocationAlways, I was still having the issue, but then I added RNPermissions too and then it worked
Here is the end of my Podfile :
  $static_framework = [
    'RNVectorIcons', 'RNFBAnalytics', 'RNFBApp', 'RNPermissions', 'Permission-LocationAlways'
  ]

  pre_install do |installer|
    installer.pod_targets.each do |pod|
      if $static_framework.include?(pod.name)
        def pod.build_type;
          Pod::BuildType.static_library
        end
      end
    end
  end

  use_native_modules!
end

Maybe try it with other permissions and update the README if it's working.

I was actually having this issue, but as it is in README.md, under ios, I had to put in Podfile
permissions_path = '../node_modules/react-native-permissions/ios'

pod 'Permission-LocationAlways', :path => "#{permissions_path}/LocationAlways.podspec"
pod 'Permission-LocationWhenInUse', :path => "#{permissions_path}/LocationWhenInUse.podspec"

and it worked

@Daavidaviid This is totally identical to what's in already in the README, no? https://github.com/react-native-community/react-native-permissions#workaround-for-use_frameworks-issues (RNPermissions didn't need be statically linked)

I was actually having this issue, but as it is in README.md, under ios, I had to put in Podfile
permissions_path = '../node_modules/react-native-permissions/ios'

pod 'Permission-LocationAlways', :path => "#{permissions_path}/LocationAlways.podspec"
pod 'Permission-LocationWhenInUse', :path => "#{permissions_path}/LocationWhenInUse.podspec"

and it worked

@LMestre14 The latest version has a more explicit error for this 🙂

@LMestre14 The latest version has a more explicit error for this 🙂

Sorry I wasn't very explicit. I added RNPermissions to static frameworks in Podfile.
And I just tested again and I can confirm that with version 2.0.9 on my machine, the iOS build fails if I don't add RNPermissions and only add Permission-LocationAlways to static frameworks.

@Daavidaviid what's your react-native version?

0.62

I'm using 0.61.5
In my Podfile I don't have $static_framework as you have on yours, because supposedly native components like react-native-permissions should only be installed (yarn or npm) and right after run command pod install in the projects ios folder.
I don't understand why you need $static_framework in the first place

@LMestre14 Because he uses use_frameworks! and currently Cocoapods don't provide a proper way to define a Podspec as a static library.

@Daavidaviid I just tried without RNPermissions linked as static framework and can confirm it's not needed (only needed for the permission handlers). It might be related to something else (Xcode cache stale data? Try to remove RNPermissions for $static_framework), nuke the Xcode DerivedData folder,  your Pods folder and reinstall / rebuild everything.

Ok, I just cleaned the build in Xcode everytime. I’ll try with DerivedData folder later. Also, LocationAlways is the only permission I use, don’t know if it could be linked.

I upgraded to 2.1.0 today and now I get the error screen as in https://github.com/react-native-community/react-native-permissions/issues/441#issuecomment-612861024, even that it was working on 2.0.10. I don't use use_frameworks

@radko93 Please provide more informations (OS?, RN version? permission handlers linked? Xcode DerivedData / Gradle cache cleaned?)

React Native 0.62.2
iOS simulator 13.4
I cleaned all the folders and simulator.
my Podfile:

platform :ios, '11.0'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

def add_flipper_pods!(versions = {})
  versions['Flipper'] ||= '~> 0.33.1'
  versions['DoubleConversion'] ||= '1.1.7'
  versions['Flipper-Folly'] ||= '~> 2.1'
  versions['Flipper-Glog'] ||= '0.3.6'
  versions['Flipper-PeerTalk'] ||= '~> 0.0.4'
  versions['Flipper-RSocket'] ||= '~> 1.0'
  pod 'FlipperKit', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitLayoutPlugin', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/SKIOSNetworkPlugin', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitUserDefaultsPlugin', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitReactPlugin', versions['Flipper'], :configuration => 'Debug'
  # List all transitive dependencies for FlipperKit pods
  # to avoid them being linked in Release builds
  pod 'Flipper', versions['Flipper'], :configuration => 'Debug'
  pod 'Flipper-DoubleConversion', versions['DoubleConversion'], :configuration => 'Debug'
  pod 'Flipper-Folly', versions['Flipper-Folly'], :configuration => 'Debug'
  pod 'Flipper-Glog', versions['Flipper-Glog'], :configuration => 'Debug'
  pod 'Flipper-PeerTalk', versions['Flipper-PeerTalk'], :configuration => 'Debug'
  pod 'Flipper-RSocket', versions['Flipper-RSocket'], :configuration => 'Debug'
  pod 'FlipperKit/Core', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/CppBridge', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FBCxxFollyDynamicConvert', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FBDefines', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FKPortForwarding', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitHighlightOverlay', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitLayoutTextSearchable', versions['Flipper'], :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitNetworkPlugin', versions['Flipper'], :configuration => 'Debug'
end
# Post Install processing for Flipper
def flipper_post_install(installer)
  installer.pods_project.targets.each do |target|
    if target.name == 'YogaKit'
      target.build_configurations.each do |config|
        config.build_settings['SWIFT_VERSION'] = '4.1'
      end
    end
  end
  file_name = Dir.glob("*.xcodeproj")[0]
  app_project = Xcodeproj::Project.open(file_name)
  app_project.native_targets.each do |target|
    target.build_configurations.each do |config|
      cflags = config.build_settings['OTHER_CFLAGS'] || '$(inherited) '
      unless cflags.include? '-DFB_SONARKIT_ENABLED=1'
        puts 'Adding -DFB_SONARKIT_ENABLED=1 in OTHER_CFLAGS...'
        cflags << '-DFB_SONARKIT_ENABLED=1'
      end
      config.build_settings['OTHER_CFLAGS'] = cflags
    end
    app_project.save
  end
  installer.pods_project.save
end

# Pods for Blossom
pod 'FBLazyVector', :path => "../node_modules/react-native/Libraries/FBLazyVector"
pod 'FBReactNativeSpec', :path => "../node_modules/react-native/Libraries/FBReactNativeSpec"
pod 'RCTRequired', :path => "../node_modules/react-native/Libraries/RCTRequired"
pod 'RCTTypeSafety', :path => "../node_modules/react-native/Libraries/TypeSafety"
pod 'React', :path => '../node_modules/react-native/'
pod 'React-Core', :path => '../node_modules/react-native/'
pod 'React-CoreModules', :path => '../node_modules/react-native/React/CoreModules'
pod 'React-Core/DevSupport', :path => '../node_modules/react-native/'
pod 'React-RCTActionSheet', :path => '../node_modules/react-native/Libraries/ActionSheetIOS'
pod 'React-RCTAnimation', :path => '../node_modules/react-native/Libraries/NativeAnimation'
pod 'React-RCTBlob', :path => '../node_modules/react-native/Libraries/Blob'
pod 'React-RCTImage', :path => '../node_modules/react-native/Libraries/Image'
pod 'React-RCTLinking', :path => '../node_modules/react-native/Libraries/LinkingIOS'
pod 'React-RCTNetwork', :path => '../node_modules/react-native/Libraries/Network'
pod 'React-RCTSettings', :path => '../node_modules/react-native/Libraries/Settings'
pod 'React-RCTText', :path => '../node_modules/react-native/Libraries/Text'
pod 'React-RCTVibration', :path => '../node_modules/react-native/Libraries/Vibration'
pod 'React-Core/RCTWebSocket', :path => '../node_modules/react-native/'

pod 'React-cxxreact', :path => '../node_modules/react-native/ReactCommon/cxxreact'
pod 'React-jsi', :path => '../node_modules/react-native/ReactCommon/jsi'
pod 'React-jsiexecutor', :path => '../node_modules/react-native/ReactCommon/jsiexecutor'
pod 'React-jsinspector', :path => '../node_modules/react-native/ReactCommon/jsinspector'
pod 'ReactCommon/callinvoker', :path => "../node_modules/react-native/ReactCommon"
pod 'ReactCommon/turbomodule/core', :path => "../node_modules/react-native/ReactCommon"
pod 'Yoga', :path => '../node_modules/react-native/ReactCommon/yoga', :modular_headers => true

pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec'
pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'

 # Permissions
 permissions_path = '../node_modules/react-native-permissions/ios'

 pod 'Permission-Notifications', :path => "#{permissions_path}/Notifications.podspec"

 post_install do |installer|
  flipper_post_install(installer)
  end

target "App" do
  use_native_modules!
  add_flipper_pods!

end
target "App2" do
  use_native_modules!
  add_flipper_pods!
end

@radko93 Thanks, it helped a lot! I see what this is: you only use the notification permission handler which is a bit different from the others (for the specific functions checkNotifications / requestNotifications) and the header file check is missing in the new startup check (it's here, and I copied this list). I will add it and publish a new release.

@zoontek great will check it out once released.

@radko93 It has been published. Sorry for the inconvenience.

@zoontek You saved my life, thanks, now everything works as expected.

Erratum: Just tried it with a fresh new project, RNPermissions need effectively to be linked as a static library too. I added it to the README.


import_from_git to a unique location

import_from_git to a unique location to avoid path collisions when cloning the same url from several fastlane instances at the same time.  #608
The failing unit tests are inherited from the original branch, and are not related to this PR.

Awesome :+1:  Thanks !

Thanks, done :+1:


[WIP] - Update new defaults

More details in http://docs/document/d/1LMsDRy0zMKQrPUDJ4chlPtqul9bwXs90QH6N8xqZ78I?tab=t.0#heading=h.qx5xjbm73vyx

@qz267 is there any reason for changing defaults instead of sending values and override it in module call?

@qz267 is there any reason for changing defaults instead of sending values and override it in module call?

Sorry for the confusion, I was trying to surface some of my WIP changes, to ask for early feedbacks, PR title updated.
b/362377949 is the original request, I don't have strong preference about update in variables or override them in the module call, any suggestions are welcomed, thanks!

@qz267 I think it will be better to take alternate route instead of changing defaults in the module as this change will require all the existing user of the module to adjust code for new defaults.
@bharathkkb can u plz review?

I got @q2w suggested using alt_defaults instead https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/blob/master/cli/bpmetadata/proto/bpmetadata_ui.proto#L149, WDYT?

/gcbrun


Always restrict fuzzySizeThreshold

Not sure why we would want to have different rules for search vs daemon here. @ShanaryS was there a reason behind this? Otherwise I'll just make them consistent with this PR.

If users are using cross-seed inject, we don't need to restrict fuzzy to 0.1 since there is no snatching happening. This would be if a user manually downloads a torrent (such as for ensemble matching) or is using cross-seed inject as a standalone tool.

I think your change here is good if we can have the ‘cross-seed inject` command ignore it. So the use case still exists but prevents search/rss/announce/webhook from ever having it.

Gonna close this for now then.


Add Privacy Manifest

Apple says "Starting May 1, 2024: You'll need to include approved reasons for the listed APIs used by your app's code to upload a new or updated app to App Store Connect."
Please add privacy policy otherwise we couldn't use this library.

@Zandor300 is this something you can provide? I guess without it for most people it means looking for an alternative to DeviceKit :)

Fixed by https://github.com/devicekit/DeviceKit/pull/397 released just now in version 5.2.3
Just in time before Apple starts enforcing the change :)

thanks!


use logback for apollo-demo

What's the purpose of this PR
use logback for apollo-demo
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Read the Contributing Guide before making this pull request.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit tests to verify the code.
[ ] Run mvn clean test to make sure this pull request doesn't break anything.
[ ] Update the CHANGES log.

Codecov Report

Merging #4163 (cbe49cc) into master (5e17275) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4163      +/-   ##
============================================
+ Coverage     52.52%   52.56%   +0.03%
- Complexity     2610     2613       +3
============================================
  Files           484      484
  Lines         15190    15190
  Branches       1572     1572
============================================
+ Hits           7979     7984       +5
+ Misses         6658     6648      -10
- Partials        553      558       +5

Impacted Files
Coverage Δ

...ework/apollo/internals/RemoteConfigRepository.java
85.27% <0.00%> (-3.07%)
:arrow_down:

...work/apollo/biz/message/ReleaseMessageScanner.java
82.89% <0.00%> (-2.64%)
:arrow_down:

.../apollo/internals/RemoteConfigLongPollService.java
77.71% <0.00%> (-0.61%)
:arrow_down:

...mework/apollo/openapi/service/ConsumerService.java
55.08% <0.00%> (+1.69%)
:arrow_up:

...nfigservice/service/AccessKeyServiceWithCache.java
84.69% <0.00%> (+2.04%)
:arrow_up:

...framework/apollo/openapi/entity/ConsumerAudit.java
48.48% <0.00%> (+6.06%)
:arrow_up:

...work/apollo/biz/message/DatabaseMessageSender.java
64.58% <0.00%> (+14.58%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e17275...cbe49cc. Read the comment docs.


require-ing in irbrc shows warning "can't alias ls from irb_ls"

When one requires this gem in the irbrc file, you get a warning on irb startup, from ruby 2.7 onwards (tested in 2.7.1 and 3.0.0):
% irb -f -r'looksee'
irb: warn: can't alias ls from irb_ls.
irb(main):001:0>

If you require the gem after irb has finished loading, there is no issue.
% irb -f
irb(main):001:0> require 'looksee'
=> true
irb(main):002:0>

Main difference seems to be the result of show_source 'ls' (in REPL). For the startup (and command line) case it shows Looksee, otherwise irb/extend-command.rb.
Warning goes away if one adds Looksee.rename :_ls to irbrc ... but considering this happens for a straightforward installation, it seems like that should not be necessary.  Would be great if require-ing looksee in irbrc and during REPL would behave the same way.
Probably relevant:

https://github.com/ruby/irb/pull/203
https://github.com/ruby/irb/commit/19b6c2060405583f9ac64db1d87f3bedfbe053f5#diff-707785dd86b785fc2279e00b12e4f4c316926e6e633de2bdd374d39b91f28ec5

I can reproduce this issue too on ruby 3.1.2, and Looksee.rename :_ls hacks works for me.


Fix of Gradio Upload/Mic thing. Force Dark mode theme + always same URL.

Fixed Upload/Mic thing

+...
Idk do Applio need this cool small-tiny feature? Force Dark mode theme + always (even on reload or url change) same url <IP_ADDRESS>:6969/#🍏(localhost:6969/#🍏).
I can adjust code if just one of two features is needed.
Demonstration (video was done before fixing Upload/Mic thing and demonstrating only "Force Dark mode theme + always same URL" feature):
https://github.com/IAHispano/Applio/assets/15386194/8469a9e2-614a-4ad0-8ff0-78995b054509

I think that mixing javascript with python is not the best idea, so I think we will go more for the solution we did in applio v2

@blaise-tk

I think we will go more for the solution we did in applio v2

What was that solution? (I'm new to Applio, sorry)

I think that mixing javascript with python is not the best idea

Is it really "mixing"? It's more about implementing JavaScript to the header (<head>) of Gradio blocks (gr.Blocks). Here and here some more info about it. Please correct me if I am wrong.

We finally fixed the "Upload/Mic thing" without using any javascript, there was an unnecesary gr.Row.


Added proper DISABLE_ACCESS_LOG.

Hello,
I've added proper disabling of the accesslog. As far as I know this won't hurt the functionality of django-axes. (If I'm wrong, please correct me).
Also added DISABLE_SUCCESS_ACCESS_LOG which used to be DISABLE_ACCESS_LOG.
I have changed this because the setting name was not doing what you would expect it to do.
By changing the code this way, the "standard" behaviour is back to what it used to be.

I will fix these tests and do another pull.

Coverage increased (+0.5%) to 85.263% when pulling 831b930610a08995fd5ddccd033dd523c96a3056 on wearespindle:master into d07a5e09fbf71601f4fa044a63d5c6a1bef85e67 on jazzband:master.

Made a new pull request.
https://github.com/jazzband/django-axes/pull/200

Coverage increased (+0.5%) to 85.263% when pulling b49e685603064b75b01d32c435938ebf4185c3dc on wearespindle:master into d07a5e09fbf71601f4fa044a63d5c6a1bef85e67 on jazzband:master.


[Bug] Qbittorrent aborts instead of error when it receives invalid hash.

Expected behaviour:
Qbitorrent plugin is recieving a torrent with no Hash. It should skip the torrent and continue to the next instead of completely aborting and not saving anything
Actual behaviour:
2022-01-14 15:15:31 WARNING  qbittorrent   seriess         File with hash e49864aa67fc86748cb030d94 already in qbittorrent
2022-01-14 15:15:31 ERROR    qbittorrent   seriess         Error getting torrent info, invalid hash None
2022-01-14 15:15:31 CRITICAL plugin        seriess         Error when trying to send request to qBittorrent: Failed to add file to qBittorrent
2022-01-14 15:15:31 WARNING  task          seriess         Aborting task (plugin: qbittorrent)
As soon as it gets
Steps to reproduce:

Step 1: ... Have Qbitorrent a process a torrent with hash "None" through RSS.

Log:
2022-01-14 15:15:31 WARNING  qbittorrent   seriess         File with hash e49864aa67fc86748cb030d942ab already in qbittorrent
2022-01-14 15:15:31 ERROR    qbittorrent   seriess         Error getting torrent info, invalid hash None
2022-01-14 15:15:31 CRITICAL plugin        seriess         Error when trying to send request to qBittorrent: Failed to add file to qBittorrent
2022-01-14 15:15:31 WARNING  task          seriess         Aborting task (plugin: qbittorrent)
paste log output here
`

Looks like the self.check_torrent_exists returns a true/false but it's never taken into account by the function add_entries.
https://github.com/Flexget/Flexget/blob/develop/flexget/plugins/clients/qbittorrent.py#L279
Just continues regardless of check_torrent_exists status.

Can you run again  with debug logging and post here?


fix datetime input tests

This PR fixes some invalid tests

Detailed output

There were 3 failures:

1) TheCodingMachine\GraphQLite\Integration\EndToEndTest::testEndToEndInputTypeDate
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
Array &0 (
   'saveBirthDate' => Array &1 (
       'name' => 'Bill'
-        'birthDate' => '1942-12-24T00:00:00+00:00'
+        'birthDate' => '1942-12-24T00:00:00+01:00'
   )
)

/home/esprit/git/graphqlite/tests/Integration/EndToEndTest.php:514

2) TheCodingMachine\GraphQLite\Integration\EndToEndTest::testEndToEndInputTypeDateAsParam
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
Array &0 (
   'saveBirthDate' => Array &1 (
       'name' => 'Bill'
-        'birthDate' => '1942-12-24T00:00:00+00:00'
+        'birthDate' => '1942-12-24T00:00:00+01:00'
   )
)

/home/esprit/git/graphqlite/tests/Integration/EndToEndTest.php:547

3) TheCodingMachine\GraphQLite\Integration\EndToEndTest::testEndToEndInputType
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
Array &0 (
   'saveContact' => Array &1 (
       'name' => 'foo'
-        'birthDate' => '1942-12-24T00:00:00+00:00'
+        'birthDate' => '1942-12-24T00:00:00+01:00'
       'relations' => Array &2 (
           0 => Array &3 (
               'name' => 'bar'

/home/esprit/git/graphqlite/tests/Integration/EndToEndTest.php:593

It can be reproduced by changing default timezone in php

Indeed!
Thanks a lot for the fix :+1:


U+012F ( į ) - add glyph

added by @dok42
merged in https://github.com/source-foundry/alt-hack/commit/caa1b5eb0e32c073bb51f8ccbb4439e80afbcc2d


dft: fix reporting config problem

there was an error generated when running report_dft_config
[ERROR GUI-0070] can't read "args": no such variable

Please fix this missing DCO (you can click the details link for more info).


Implemented lobby invites + updates to README

Completed the README for a few functions and events, updated some external links to proto explanations (these are gonna be hell to maintain though...).
I also implemetned the inviteLobby function and inviteCreated event. I think they've been lost somewhere along the way when a pull got closed before merging.

Wow, good work!


Add files via upload

:)

@Isywsy,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot


JXL-viewer Appears as Option to Open .apk and .pdf

On an Android 9 (stock OS) device, I downloaded an .apk and when I tapped on it to install it and both JXL-viewer and the session installer came up as options.
This sounds unintended.

I can't reproduce. Can you tell me what ROM are you running on which device please ?

Already said which ROM. Device is Moto G7 Supra (Power rebrand).
I'll try to reproduce it, since I tapped "Always Use" for the session installer on the second time the dialogue came up.
The file explorer I used was Amaze.

So, I couldn't quickly find a way to clear the default from the "Package installer" (I guess I got the "session installer" terminology from somewhere else), so I tried uninstalling and reinstalling the JXL viewer, but it still would default to the package installer, even in Amaze.
However, if I tap the three dots next to the .apk file in Amaze and select "Open with" and then, when it shows the "Open As" menu, select "Other," it displays Jpeg XL Viewer as a secondary option.

And just confirned on my second device that this app comes up as an option for apk files.
I downloaded ImgurViewer from Github using Bromite and tapped on the notification once it finished, then Package installer, Jpeg XL Viewer, App Manager, and OpenDocumentReader came up as options on that device.
Doubly confirmed when opening Amaze, selecting the file, and then selecting the "Install" option.
This second device is a Galaxy Note 3 (T-Mobile version) running a currently outdated version of Lineage (14.1) which translates to Android version 7.1.2.

Can reproduce on EMUI 8.0.0. Thanks for the report !

No problem! Glad it was reproducable for you. It's not a big deal nor does it break anything, but it was odd and a little funny seeing it listed like that. Glad I could help. :)

Oh, lmao. It seems your app's versatility knows no bounds. XD Haha!

The attribute pathSuffix was introduced in API Level 31.
From https://developer.android.com/guide/topics/manifest/data-element

Android Studio ... where are my warnings ?

@OkyDooky can you try with this apk and tell me if the problem still exist ?
Thanks in advance.
apk

Downloaded. Just to confirm, this is the new JXL-Viewer app and you want me to see if the "tap on apk and get the viewer as an option" still exists, correct?

Yes, this is a version built from latest commit in main and that should fix the issue. It should not show when you try to open pdf or zip files.

I tried on my old device and it seems to confirm the issue. I would like a confirmation on your own if you have the time.

The new apk seems to have resolved the issue (at least with those formats). I'll reopen this if any new ones appear. Glad it got resolved!

Heh. You'll be "pleased" to know that on my other device, which hasn't used the test build you provided here, it's also appeared as an option for opening my phone dialer. XD


feat(CX-2325): Make Scrolling from StickyTabPage Header Possible

This PR resolves CX-2325
Description

This PR wraps the Static Fixed Header Content and Sticky Tab Content in StickyTabPage with a gesture handler that allows users the ability to scroll from the header. Previously users will need to locate the Flatlist beneath the StickyTabPage in order to scroll. This can be problematic when we have a large header and so the Flatlist may be hidden away from view.

https://user-images.githubusercontent.com/18648835/202710671-86b15d7d-dbf7-4a6f-8953-87263ea88049.mov
PR Checklist

[x] I tested my changes on iOS / Android.
[x] I added screenshots or videos to illustrate my changes.
[x] I added Tests and Stories for my changes.
[ ] I added an app state migration.
[x] I hid my changes behind a feature flag.
[ ] I have prefixed changes that need to be tested during a release QA with [NEEDS EXTERNAL QA] on the changelog.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Changelog updates
Changelog updates

Cross-platform user-facing changes

Make Scrolling from StickyTabPage Header Possible - kizito

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

Feel free to merge once you solve the merge conflict

#squashongreen

would you mind if you rebase to main 👀


Added cimode to supported languages

PT-1016 Added cimode to supported languages, so it could be used for debugging and as a helper tool when a translation office or some translator works with translations.

Added a feature flag to show CIMODE in a language selector:

The feature is off in production server and on in staging server.

Same feature in Palvelutarjotin admin https://github.com/City-of-Helsinki/palvelutarjotin-admin/pull/177


React.js component testing in ASP.NET Core project in Visual Studio 2017

Sorry if this is the wrong location. Having trouble unit testing React.Js components in ASP.NET Core project in Visual Studio 2017. Is this possible? If so can I get a reference to read, having trouble finding material. Thanks

Take a look at the integration tests in this project, that should give you a good starting point 👍
Cheers

Closing as this question has been answered, please open a new issue or comment if you'd like some more help.


📝 Remove references to a .rst README generated by poetry new

Updated the tutorial doc on packaging Typer CLI tools to reflect current Poetry behaviour.
Currently, the default extension for the README generated by poetry new is .md (not .rst) since this PR.

Great, thank you @jonasmmiguel! :nerd_face:
Thanks @JacobKochems for the review with a comment explaining what you checked, that's super helpful! :cake:
Thanks for the review @kinuax. :coffee:
And thanks @svlandeg for the help as always! :sunglasses: :tada:


Time function error

sample:
$ curl http://localhost:8080/v1.0/Observations?$filter=time(phenomenonTime) eq 0

response:
{
   "error": {
      "status": "Internal Server Error",
      "code": 500,
      "message": [
         "Error executing query pq: column \"time\" does not exist"
      ]
   }
}

from spec: "The time function returns the time part of the DateTimeOffset parameter value, evaluated in the time zone of the DateTimeOffset parameter value."

better query:
$ curl http://localhost:8080/v1.0/Observations?$filter=time(phenomenonTime) eq time('14:31:24.733Z')

but same error (with or without Z)

Looking into it atm, time is not fetched as function by godata due to a change I made earlier.

Fixed, godata update needed.

getting an other  error after update:
{
   "error": {
      "status": "Internal Server Error",
      "code": 500,
      "message": [
         "Error executing query pq: operator does not exist: time without time zone = integer"
      ]
   }
}```

db has 2 observations:

"phenomenonTime": "2017-07-04T14:31:53.094Z",

"phenomenonTime": "2017-07-04T14:31:24.733Z",

what request?

ah the first, wrong one...
works now :-)


Apache/KA-50 Hostile Unit Icons

set "HIDDEN ON MFD" flag for enemy (and most friendly) units so have them not show up on the apache TSD/KA-50 ABRIS

The mechanism we use through dcs-grpc currently doesn't give us a way to set this. It's possible to get it added, but we have to wait for an update from them
https://github.com/DCS-gRPC/rust-server/blob/0.6.0/lua/DCS-gRPC/methods/coalitions.lua#L55-L87


Scan query throws and error when using smile encoding for response

Smile encoding throws an error, using the demo set-up and demo data:
Example cURL command:
$ curl -X POST 'http://localhost:8082/druid/v2/?pretty' \
    -H 'Content-Type:application/json' \
    -H 'Accept:application/x-jackson-smile' \
    -d @query.json

:)
errorPUnknown exceptionerrorMessageMissing type id when trying to resolve subtype of [simple type, class org.apache.druid.query.Query]: missing type id property 'queryType'
 at [Source: (org.eclipse.jetty.server.HttpInputOverHTTP); line: -1, column: 0]errorClassxcom.fasterxml.jackson.databind.exc.InvalidTypeIdExceptionhost!⏎

Affected Version
0.20.0
Description
Please include as much detailed information about the problem as possible.

Cluster size - local docker-compose example set-up
Configurations in use - defaults
Steps to reproduce the problem - Run the cURL command above, use the following query:

{
  "queryType": "scan",
  "dataSource": "wikipedia",
  "resultFormat": "list",
  "columns":[],
  "intervals": [
   "2013-01-01/2019-01-02"
  ],
  "batchSize":20480,
  "limit":3
 }

It's due to the implementation takes 'Accept' parameter which indicates smile encoding to decode the HTTP body which is actually a JSON.
https://github.com/apache/druid/blob/16acd6686a337fc9a12e9aeda443fca973bdc625/server/src/main/java/org/apache/druid/server/QueryResource.java#L192
https://github.com/apache/druid/blob/16acd6686a337fc9a12e9aeda443fca973bdc625/server/src/main/java/org/apache/druid/server/QueryResource.java#L196
The input reader should alway decode the body according to 'Content-Type' header, while the output writer should encode the response by 'Accept' header. This problem might be introduced by #4033
I'm wondering why you want to use smile ?

@FrankChen021 Yes that's what I was expecting. From reading the docs and looking through the code, I expected to be able to send a query in JSON (Content-Type: application/json), then get the data back in smile format, but setting Accept: application/x-jackson-smile, as per the docs.
In terms of why we wanted to use Smile: because the docs say it's possible to use it, and there's apparently performance/efficiency benefits for using it over JSON. We're going to be requesting large amounts of data back from Druid. Given the only way to do this (as there's no encoded connection to Druid, similar to say Postgres), is via the HTTP API, we wanted to see how much of a benefit Smile would be over JSON. Hope that makes sense. Advice is very much welcome!

Druid also supports JDBC and GZIP over HTTP . I think both of these two ways help reduce network traffic load as you want.

@FrankChen021 thanks for that! We looked into JDBC, we're using Go, but thought we could use Java/Scala for the JDBC connector, but it looks as though the JDBC driver is also utilising HTTP under the hood, see: https://github.com/apache/calcite/blob/master/druid/src/main/java/org/apache/calcite/adapter/druid/DruidConnectionImpl.java#L100
GZIP could work though!

I didn't dive into JDBC deeply, but according to the code, you are right.


SNYK - Security Issue

We currently use SNYK to test for node vulnerabilities and it has alerted us to a high security issue in metalsmith-markdown as it uses marked as its markdown parser
https://app.snyk.io/vuln/npm:marked:20150520
There is a pull request in which will solve this issue by moving to kramed...
https://github.com/segmentio/metalsmith-markdown/pull/18

Do you think we can get this fixed @ianstormtaylor ?

https://app.snyk.io/vuln/npm:marked:20150520 doesn't resolve correctly.
Seems moving to Kramed is a good idea though.
Ianstormtaylor is no longer at Segment afaik.

Fixed


[2.5] Backport: Split rancher.yaml into multiple doc

Due to the limitation https://github.com/rancher/rke2/issues/527 we can
not use multi-doc yaml for airgap installation

https://github.com/rancher/rancher/issues/30012


"explorer.fileNesting.operateAsGroup" weird setting and weirder semantics

Testing #145640
imho all operations on the parent resource should affect the child resource. Same as with folders.
Why do we make this configurable? Do users actually not expect this and want to change this? Why is the default false?
If we really decide that a setting for this is needed then operateAsGroup is misleading because it is not actually a group. All operations on the child are not done on the parent.

The main problem I saw was how do we make it possible to only copy the single file when you copy a parent. One idea I considered was making the nest operate as a group when it's collapsed, but individual files when it's expanded? That way you would:

collapse the nest and copy it as one item always,
expand the nest and select the subset of entries you want to copy
expand the nest and select just the parent, then only operate on the parent.

what would you think of that flow?

Enabled the operateAsGroup setting by default though

Setting is removed sorry. New intended behavior is that it operates as group when collapsed.


Configurable MaxLockCycles

When a file is locked the flock library will retry a given amount of times (with a increasing sleep time inbetween each round)
Until now the max amount of such rounds was hardcoded to 10. Now it is configurable, falling back to a default of 25

@kobergj codacy is not happy with the Changelog markdown

It is. I fixed the issue already, it's just still shown in red because the pipeline is red.


Got a very strange error with latest rethinkdbdash and Node 5.5

/app/releases/20161013155215/node_modules/rethinkdbdash/lib/term.js:3016
 throw new Error.ReqlDriverError('`'+method+'` takes '+num+' argument'+((num>1)?'s':'')+', '+args.length+' provided', term._query);
 ^
ReqlDriverError: `toJSON` takes 0 argument, 1 provided after:
 r.ISO8601("2016-10-13T17:17:59-03:00")
 at Term._arity (/app/releases/20161013155215/node_modules/rethinkdbdash/lib/term.js:3016:11)
at Term.toJsonString (/app/releases/20161013155215/node_modules/rethinkdbdash/lib/term.js:2767:10)
at Object.stringify (native)
at Object.stringify (/app/releases/20161013155215/node_modules/core-js/modules/es6.symbol.js:128:21)
 at stringify (/app/releases/20161013155215/node_modules/json-stringify-safe/stringify.js:5:15)
at Client.send (/app/releases/20161013155215/node_modules/raven/lib/client.js:122:17)
 at Client.process (/app/releases/20161013155215/node_modules/raven/lib/client.js:114:25)
at /app/releases/20161013155215/node_modules/raven/lib/client.js:165:23
 at /app/releases/20161013155215/node_modules/raven/lib/parsers.js:52:5
 at /app/releases/20161013155215/node_modules/raven/lib/utils.js:169:30
 at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:404:3)

@thelinuxlich I've seen this error before when accidentally attempting to serialize a ReQL query to JSON. Certain implementations call the toJSON method when it is defined as a way to override default serialization.
See the MDN docs on this.

But then it wouldn't be a rethinkdbdash error, right?

It would be because you cannot serialize a ReQL term in JSON.

@neumino I seem to be running into similar issue as @thelinuxlich
This is what i had been trying to achieve. And, I am using thinky.r for this.
I am trying to generate change feed for new documents in the Table, and end up with the same ReqlDriverError error. I did try with both run() and execute().
r.table('table').changes({includeTypes: true})
.filter(r.row('type').eq('add'))('new_val').execute()
.then(function(feed) {
feed.each(function(err, change) {
if (err) {
console.log(err.toString());
console.log(err.stack);
}
else {
console.log(change);
}
});
I did manage to get what i am after with the rethinkdb javascript driver using the code below. Yeah, without this error
r.table('table').changes({includeTypes: true})
.filter(r.row('type').eq('add'))('new_val').execute()
.then(function(feed) {
feed.each(function(err, change) {
if (err) {
console.log(err.toString());
console.log(err.stack);
}
else {
console.log(change);
}
});
})
Do you think, this could be some issue with rethinkdbdash?


Missing Template Map Generator

I am missing the template map generator after the installation of the new Skeleton Application which is ready for ZF3. I do not want to require https://github.com/zendframework/zendframework because that has all the dependencies listed.

Does https://github.com/Ocramius/OcraCachedViewResolver work in this context? I think it's a better alternative than generating template maps manually...

Note: didn't upgrade the module to 3.x component, so I do not know if it works

It cannot be installed:
$ composer require ocramius/ocra-cached-view-resolver
You are running composer with xdebug enabled. This has a major impact on runtime performance. See https://getcomposer.org/xdebug
Using version ^3.0 for ocramius/ocra-cached-view-resolver
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - ocramius/ocra-cached-view-resolver 3.1.x-dev requires zendframework/zend-mvc ~2.3 -> satisfiable by zendframework/zend-mvc[2.3.0, 2.3.1, 2.3.2, 2.3.3, 2.3.4, 2.3.5, 2.3.6, 2.3.7, 2.3.8, 2.3.9, 2.4.0, 2.4.0rc1, 2.4.0rc2, 2.4.0rc3, 2.4.0rc4, 2.4.0rc5, 2.4.0rc6, 2.4.0rc7, 2.4.1, 2.4.10, 2.4.2, 2.4.3, 2.4.4, 2.4.5, 2.4.6, 2.4.7, 2.4.8, 2.4.9, 2.5.0, 2.5.1, 2.5.2, 2.5.3, 2.6.0, 2.6.1, 2.6.2, 2.6.3, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.7.4, 2.7.5, 2.7.6, 2.7.7, 2.7.8] but these conflict with your requirements or minimum-stability.
    - ocramius/ocra-cached-view-resolver 3.0.3 requires zendframework/zend-mvc ~2.3 -> satisfiable by zendframework/zend-mvc[2.3.0, 2.3.1, 2.3.2, 2.3.3, 2.3.4, 2.3.5, 2.3.6, 2.3.7, 2.3.8, 2.3.9, 2.4.0, 2.4.0rc1, 2.4.0rc2, 2.4.0rc3, 2.4.0rc4, 2.4.0rc5, 2.4.0rc6, 2.4.0rc7, 2.4.1, 2.4.10, 2.4.2, 2.4.3, 2.4.4, 2.4.5, 2.4.6, 2.4.7, 2.4.8, 2.4.9, 2.5.0, 2.5.1, 2.5.2, 2.5.3, 2.6.0, 2.6.1, 2.6.2, 2.6.3, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.7.4, 2.7.5, 2.7.6, 2.7.7, 2.7.8] but these conflict with your requirements or minimum-stability.
    - ocramius/ocra-cached-view-resolver 3.0.2 requires zendframework/zend-mvc ~2.3 -> satisfiable by zendframework/zend-mvc[2.3.0, 2.3.1, 2.3.2, 2.3.3, 2.3.4, 2.3.5, 2.3.6, 2.3.7, 2.3.8, 2.3.9, 2.4.0, 2.4.0rc1, 2.4.0rc2, 2.4.0rc3, 2.4.0rc4, 2.4.0rc5, 2.4.0rc6, 2.4.0rc7, 2.4.1, 2.4.10, 2.4.2, 2.4.3, 2.4.4, 2.4.5, 2.4.6, 2.4.7, 2.4.8, 2.4.9, 2.5.0, 2.5.1, 2.5.2, 2.5.3, 2.6.0, 2.6.1, 2.6.2, 2.6.3, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.7.4, 2.7.5, 2.7.6, 2.7.7, 2.7.8] but these conflict with your requirements or minimum-stability.
    - ocramius/ocra-cached-view-resolver 3.0.1 requires zendframework/zend-mvc ~2.3 -> satisfiable by zendframework/zend-mvc[2.3.0, 2.3.1, 2.3.2, 2.3.3, 2.3.4, 2.3.5, 2.3.6, 2.3.7, 2.3.8, 2.3.9, 2.4.0, 2.4.0rc1, 2.4.0rc2, 2.4.0rc3, 2.4.0rc4, 2.4.0rc5, 2.4.0rc6, 2.4.0rc7, 2.4.1, 2.4.10, 2.4.2, 2.4.3, 2.4.4, 2.4.5, 2.4.6, 2.4.7, 2.4.8, 2.4.9, 2.5.0, 2.5.1, 2.5.2, 2.5.3, 2.6.0, 2.6.1, 2.6.2, 2.6.3, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.7.4, 2.7.5, 2.7.6, 2.7.7, 2.7.8] but these conflict with your requirements or minimum-stability.
    - ocramius/ocra-cached-view-resolver 3.0.0 requires zendframework/zend-mvc ~2.3 -> satisfiable by zendframework/zend-mvc[2.3.0, 2.3.1, 2.3.2, 2.3.3, 2.3.4, 2.3.5, 2.3.6, 2.3.7, 2.3.8, 2.3.9, 2.4.0, 2.4.0rc1, 2.4.0rc2, 2.4.0rc3, 2.4.0rc4, 2.4.0rc5, 2.4.0rc6, 2.4.0rc7, 2.4.1, 2.4.10, 2.4.2, 2.4.3, 2.4.4, 2.4.5, 2.4.6, 2.4.7, 2.4.8, 2.4.9, 2.5.0, 2.5.1, 2.5.2, 2.5.3, 2.6.0, 2.6.1, 2.6.2, 2.6.3, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.7.4, 2.7.5, 2.7.6, 2.7.7, 2.7.8] but these conflict with your requirements or minimum-stability.
    - Installation request for ocramius/ocra-cached-view-resolver ^3.0 -> satisfiable by ocramius/ocra-cached-view-resolver[3.0.0, 3.0.1, 3.0.2, 3.0.3, 3.1.x-dev].

Installation failed, reverting ./composer.json to its original content.

Hey Ralf, I just released 4.0.0 - should now be installable. Let me know if
it works :-)
https://twitter.com/Ocramius/status/739197601510232064
https://github.com/Ocramius/OcraCachedViewResolver/releases/tag/4.0.0
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/
On 4 June 2016 at 21:30, Ralf Eggert<EMAIL_ADDRESS>wrote:

It cannot be installed:
$ composer require ocramius/ocra-cached-view-resolver
You are running composer with xdebug enabled. This has a major impact on runtime performance. See https://getcomposer.org/xdebug
Using version ^3.0 for ocramius/ocra-cached-view-resolver
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.
Problem 1
- ocramius/ocra-cached-view-resolver 3.1.x-dev requires zendframework/zend-mvc ~2.3 -> satisfiable by zendframework/zend-mvc[2.3.0, 2.3.1, 2.3.2, 2.3.3, 2.3.4, 2.3.5, 2.3.6, 2.3.7, 2.3.8, 2.3.9, 2.4.0, 2.4.0rc1, 2.4.0rc2, 2.4.0rc3, 2.4.0rc4, 2.4.0rc5, 2.4.0rc6, 2.4.0rc7, 2.4.1, 2.4.10, 2.4.2, 2.4.3, 2.4.4, 2.4.5, 2.4.6, 2.4.7, 2.4.8, 2.4.9, 2.5.0, 2.5.1, 2.5.2, 2.5.3, 2.6.0, 2.6.1, 2.6.2, 2.6.3, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.7.4, 2.7.5, 2.7.6, 2.7.7, 2.7.8] but these conflict with your requirements or minimum-stability.
- ocramius/ocra-cached-view-resolver 3.0.3 requires zendframework/zend-mvc ~2.3 -> satisfiable by zendframework/zend-mvc[2.3.0, 2.3.1, 2.3.2, 2.3.3, 2.3.4, 2.3.5, 2.3.6, 2.3.7, 2.3.8, 2.3.9, 2.4.0, 2.4.0rc1, 2.4.0rc2, 2.4.0rc3, 2.4.0rc4, 2.4.0rc5, 2.4.0rc6, 2.4.0rc7, 2.4.1, 2.4.10, 2.4.2, 2.4.3, 2.4.4, 2.4.5, 2.4.6, 2.4.7, 2.4.8, 2.4.9, 2.5.0, 2.5.1, 2.5.2, 2.5.3, 2.6.0, 2.6.1, 2.6.2, 2.6.3, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.7.4, 2.7.5, 2.7.6, 2.7.7, 2.7.8] but these conflict with your requirements or minimum-stability.
- ocramius/ocra-cached-view-resolver 3.0.2 requires zendframework/zend-mvc ~2.3 -> satisfiable by zendframework/zend-mvc[2.3.0, 2.3.1, 2.3.2, 2.3.3, 2.3.4, 2.3.5, 2.3.6, 2.3.7, 2.3.8, 2.3.9, 2.4.0, 2.4.0rc1, 2.4.0rc2, 2.4.0rc3, 2.4.0rc4, 2.4.0rc5, 2.4.0rc6, 2.4.0rc7, 2.4.1, 2.4.10, 2.4.2, 2.4.3, 2.4.4, 2.4.5, 2.4.6, 2.4.7, 2.4.8, 2.4.9, 2.5.0, 2.5.1, 2.5.2, 2.5.3, 2.6.0, 2.6.1, 2.6.2, 2.6.3, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.7.4, 2.7.5, 2.7.6, 2.7.7, 2.7.8] but these conflict with your requirements or minimum-stability.
- ocramius/ocra-cached-view-resolver 3.0.1 requires zendframework/zend-mvc ~2.3 -> satisfiable by zendframework/zend-mvc[2.3.0, 2.3.1, 2.3.2, 2.3.3, 2.3.4, 2.3.5, 2.3.6, 2.3.7, 2.3.8, 2.3.9, 2.4.0, 2.4.0rc1, 2.4.0rc2, 2.4.0rc3, 2.4.0rc4, 2.4.0rc5, 2.4.0rc6, 2.4.0rc7, 2.4.1, 2.4.10, 2.4.2, 2.4.3, 2.4.4, 2.4.5, 2.4.6, 2.4.7, 2.4.8, 2.4.9, 2.5.0, 2.5.1, 2.5.2, 2.5.3, 2.6.0, 2.6.1, 2.6.2, 2.6.3, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.7.4, 2.7.5, 2.7.6, 2.7.7, 2.7.8] but these conflict with your requirements or minimum-stability.
- ocramius/ocra-cached-view-resolver 3.0.0 requires zendframework/zend-mvc ~2.3 -> satisfiable by zendframework/zend-mvc[2.3.0, 2.3.1, 2.3.2, 2.3.3, 2.3.4, 2.3.5, 2.3.6, 2.3.7, 2.3.8, 2.3.9, 2.4.0, 2.4.0rc1, 2.4.0rc2, 2.4.0rc3, 2.4.0rc4, 2.4.0rc5, 2.4.0rc6, 2.4.0rc7, 2.4.1, 2.4.10, 2.4.2, 2.4.3, 2.4.4, 2.4.5, 2.4.6, 2.4.7, 2.4.8, 2.4.9, 2.5.0, 2.5.1, 2.5.2, 2.5.3, 2.6.0, 2.6.1, 2.6.2, 2.6.3, 2.7.0, 2.7.1, 2.7.2, 2.7.3, 2.7.4, 2.7.5, 2.7.6, 2.7.7, 2.7.8] but these conflict with your requirements or minimum-stability.
- Installation request for ocramius/ocra-cached-view-resolver ^3.0 -> satisfiable by ocramius/ocra-cached-view-resolver[3.0.0, 3.0.1, 3.0.2, 3.0.3, 3.1.x-dev].
Installation failed, reverting ./composer.json to its original content.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/zendframework/ZendSkeletonApplication/issues/334#issuecomment-223773730,
or mute the thread
https://github.com/notifications/unsubscribe/AAJakLxwwMLCYYhOoPpYDGZnCUrU1CXgks5qIdJqgaJpZM4IuIq8
.

Thanks for the quick release. Unfortunately, your release needs PHP 7, and I am currently at PHP 5.6.
$ composer require ocramius/ocra-cached-view-resolver "4"
You are running composer with xdebug enabled. This has a major impact on runtime performance. See https://getcomposer.org/xdebug
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Installation request for ocramius/ocra-cached-view-resolver 4 -> satisfiable by ocramius/ocra-cached-view-resolver[4.0.0].
    - ocramius/ocra-cached-view-resolver 4.0.0 requires php ~7.0 -> your PHP version (5.6.22) does not satisfy that requirement.

Installation failed, reverting ./composer.json to its original content.

@RalfEggert I'd be okay with pulling the template_map_resolver script into the skeleton application as well, if you want to send a pull request.

@weierophinney
Done.

@weierophinney
This can be closed, if https://github.com/zendframework/zend-view/pull/65 will be accepted.

Fixed by https://github.com/zendframework/zend-view/pull/67


Lower case letters for Canadian postcodes in payment modal leads to an issue

Describe the bug
Lower case letters for Canadian postcodes in payment modal leads to an issue
Found the same issue was here https://github.com/stripe/stripe-android/issues/2302
The same behaviour we have in this module now
Expected behavior
We should capitalize Canadian postal codes.
Postal code shouldn't be invalid just because it's in lower case.

@arekkubaczkowski @thorsten-stripe any updates here? Will it be fixed in future?

@michelleb-stripe can you take a look on this?

any progress here? @arekkubaczkowski @thorsten-stripe


How do I know if beforeEach is before which task?

I have gone through the docs and issues here but I can't find related information. Basically I wanna do something like this:
beforeEach(function() {
  if (this.testId === 1) {
    console.log('before test 1');
  }
  if (this.testId === 2) {
    console.log('before test 2');
  }
  if (this.testId <= 3) {
    console.log('before test 1, 2 and 3');
  }
  console.log('before every test');
});

Is it possible? Or am i using the wrong approach? Thanks.

I believe it's possible if you don't mind mucking around with the private api, but could it be avoided? If logic in a beforeEach should only run for some subject of the specs, then it sounds like it could benefit from some additional nested suites to appropriately group them?

	beforeEach(function () { 		log.debug('***************** %s', this.currentTest.title); 	});


Introduce an easier way to add arguments for job run in Jupyter UI

What is the feature request? What problem does it solve?
Currently, when the users want to run a job with arguments in Jupyter UI, they need to enter them in JSON format.
We need to introduce an easier way for them to enter those arguments.
Suggested solution
Introduce two input elements(one for key , one for value) and a button to add them as key value pair. After the button is clicked the pair should be saved in some kind of storage.  When the users want to run a job, the kay value pairs from that storage should be saved as JSON and sent to the server.
The pairs that have been added should be visible to the users, introducing a "ul" would work good. Every list item of the ul should have a delete button so the users can remove unwanted pairs whenever they want.

Triaged. Will keep it.
We will run usability testing of the Jupyter Integration MVP and there is a high chance to have this feature requested.


designed and fixed UI changes

What is this PR about?

Redesigned the SWE site by adding components
Removed one of the zoom controls (i.e previous version generated 2 zoom controls)
Adjust the map bounds when the page is loaded.

Before:

Removed this zoom control on the top left:

Final Result :

I’ve reviewed the code, and everything looks great to me! The enhancements are well-thought-out, and I appreciate how SWE.js is used minimally, focusing mainly on setting usaBounds, while most of the tasks are handled with HTML and CSS. That’s a nice approach. As per the professor’s instructions, we’ll make sure to use Gitmojis in future PRs as well. Great job overall!


Github Action for Google Cloud Deployment does not finish.

According to Google Cloud Console the App Engine version gets created successfully

had to generate a new GCP secret.


Confirm to context_sensitive_executable_path type

context_sensitive_executable_path should return
(True, None) if it cannot find an executable
(True, <path>) if it has an executable path
(False, None) if it wants the default behavior of the standard linter

If we return (False, '') we basically just do a which(cmd[0]) again.
If we return (False, ), the returned '' is actually ignored.

Note that nothing really changed here recently. It was just poorly, confusing implemented and worked.


Add NamedDomainObjectCollection.named(String, Action) convenience

Similar to #814
Currently, you must do something like:
tasks.named("foo").configure {
}

This is fixed in #814


Core bindings on each node (betzy)

Can we extract momentary state per core in a binary form (bitvector) - high vs low usage at the moment.  top/htop can do this so we should be able too.  it's ok to look when we sample and not worry about history...  For intuition, think about the htop graph and how the activity is distributed.
The rationale is that users get the core bindings completely wrong sometimes and we'd like to analyze patterns and generate alerts.

Sonalyze can now process these data, and print them (in human-readable format only, csv etc are coming).


Verify chatglm3 6b

I proceed as mentioned in the task https://github.com/openvinotoolkit/openvino.genai/issues/259 with the following changes.
1) Extended the nightly_model in the file openvino.genai/tests/python_tests/ov_genai_test_utils.py
nightly_models = [
        "TinyLlama/TinyLlama-1.1B-Chat-v1.0",
        "facebook/opt-125m",
        "microsoft/phi-1_5",
        "microsoft/phi-2",
        "THUDM/chatglm2-6b",
        "THUDM/chatglm3-6b", # no beam_search
        "Qwen/Qwen2-0.5B-Instruct",
        "Qwen/Qwen-7B-Chat",
        "Qwen/Qwen1.5-7B-Chat",
        "argilla/notus-7b-v1",
        "HuggingFaceH4/zephyr-7b-beta",
        "ikala/redpajama-3b-chat",
        "mistralai/Mistral-7B-v0.1",

2) Added model to
openvino.genai/.github/workflows/causal_lm_cpp.yml
Line 62 in 8470250
run: |
cpp-greedy_causal_lm-Chatglm3-6b and cpp-prompt_lookup_decoding_lm-ubuntu-Chatglm3-6b
3) Extended the supported_model_list and added note

[!Note]
The beam_search_causal_lm is not supported in the ChatGLM3-6B model.

@Wovchena  can you please guide me that what possibly gone wrong for cpp-greedy_causal_lm-Chatglm3-6b  and  cpp-prompt_lookup_decoding_lm-ubuntu although both greedy_causal_lm and prompt_lookup_decoding_lm works for chatglm3-6b in my local machine

@Wovchena

@Wovchena
Why every test is failing during build app process?

I guess we broke it :) This is not your fault.

The issue is resolved. You need to align the sub-module version on your branch with the master branch version.

@Wovchena
I use the following command but doesn't seems like it is working:
git pull --rebase origin verify-chatglm-6b
git add resolved-file
git rebase --continue
git push origin verify-chatglm-6b --force

can you suggest me anything which I may have done wrong or missed.
Additionally my forked repo is up to date with openvinotoolkit:master
please help me in this matter!

You can checkout thirparty/openvino_tokenizers from master and push to you branch to align the tokenizers with master:
git checkout master thirdparty/openvino_tokenizers/
git add thirdparty/openvino_tokenizers/
git commit -m tokenizers
git push

Apparently that was wrong master. Try git checkout a0268cd5c5fe71ccbc4dc773b502075867c859fe thirdparty/openvino_tokenizers instead of git checkout master thirdparty/openvino_tokenizers/

@Wovchena
why prompt_lookup and greedy is are generating different output for chatglm3?here
- name: run and compare
        run: |
          source ./ov/setupvars.sh

          echo 'Code:```python
          def add(a, b):
              return a + b
          ```
          Question: Can you please add 2 and 3
          A:' > ./prompt.txt

          ./build/samples/cpp/prompt_lookup_decoding_lm/prompt_lookup_decoding_lm ./chatglm3-6b/ "$(<prompt.txt)" > predictions_prompt_lookup.txt
          ./build/samples/cpp/greedy_causal_lm/greedy_causal_lm ./chatglm3-6b/ "$(<prompt.txt)" > predictions_greedy.txt
          diff predictions_prompt_lookup.txt predictions_greedy.txt
          python -c "
          with open('predictions_greedy.txt', 'r') as f:
              predicted_greedy = f.readline()
          with open('predictions_prompt_lookup.txt', 'r') as f:
              predicted_prompt_lookup = f.readline()
          print(predicted_greedy)
          print(predicted_prompt_lookup)
          "
          echo "Prompt lookup" passed

because as per the error raised I think it is due to the different output generated by greedy and prompt lookup.
But it is probably generating same results for Qwen model since it is passing the tests.

I don't know. That is the point of this task to test if chatglm is fine. Apparently it's not. You can print the results to see them

@Wovchena
As I can see  cpp-greedy_causal_lm-Chatglm3-6b is failing because the output generated by python sample and c++ sample are different and whereas cpp-prompt_lookup_decoding_lm-ubuntu is failing because prompt lookup and greedy generated text are different.
In both the cases I am using diff command to compare the generated text which may be causing assertion error , so will I only need to remove comparison part or remove whole  cpp-greedy_causal_lm-Chatglm3-6b  and cpp-prompt_lookup_decoding_lm-ubuntu` .
Also don't know why

Linux (Ubuntu 20.04, Python 3.9) / OpenVINO genai extension (cmake + wheel) (pull_request) Failing after 27m
Windows (VS 2019, Python 3.11) / OpenVINO genai extension (cmake + wheel) (pull_request)
macOS (12, Python 3.9) / OpenVINO genai extension (cmake + wheel) (pull_request)
the above tests are failing?
I also proceed as you mentioned earlier

git checkout a0268cd5c5fe71ccbc4dc773b502075867c859fe thirdparty/openvino_tokenizers
git add thirdparty/openvino_tokenizers/
git commit --amend
git push

You need to find out why C++ and Python greedy produce different outputs and fix it. Other model runs are aligned, that means the problem is not about the samples themselves.
This PR diff shows that you've modified thirdparty/openvino_tokenizers. Eliminate that diff. master's version of openvino_tokenizers should be kept. May be this is the reason for Linux (Ubuntu 20.04, Python 3.9) / OpenVINO genai extension (cmake + wheel) (pull_request) failure.

@Wovchena
Why I am getting build error and error for whisper_speech_recognition in Windows (VS 2019, Python 3.11)?
Did I miss anything?

Something got broken in one of dependencies. All new PRs fail the same way. This is not your fault.

@Wovchena
I think there in no need for any further edit? this latest commit has resolved all the required checks.
Correct me if I am wrong

@Wovchena
I think that my latest commit satisfy all the required conditions given in the issue. Since it has passed all the github workflow.
Please correct me if I'm wrong 😅


NEW: pass aft account request "custom_fields" metadata to customization pipeline

Background:

In the customization pipeline, I could use pre and post API helper to perform action such as populating the tfvars.
Account request can contain additional metadata stored in custom_fields, this information propagate through the step function but is not available inside the CodeBuild environment

Expected outcome:
I want to access these metadata, probably in format of environment variables when running the API helpers.
one way to achieve this is by adding this metadata as part of the CodeBuild environment variables and keep it up to date as I modify the account request.

I achieve this by accessing $VENDED_ACCOUNT env var in a customizations pre api helper script then do a Dynamodb lookup into the account_request_metadata Dynamodb table. This gives me all of the data from the account request, including custom_fields. The script then dumps that to a JSON file and I have a locals.tf that reads that file into a local. Seems a little like going around the world, but it works.

I agree that this approach and it was one of the first come to my mind. That said, it requires user to build this custom script. I was hoping for alternative mechanism that could deliver this custom_fields to the execution environment automatically.

We're actually actively working on an implementation to get custom fields into vended accounts in a more consumable way from within the vended account itself to avoid some of this account/dynamo navigation required as it exists today.

https://github.com/aws-ia/terraform-aws-control_tower_account_factory/releases/tag/1.1.0
This should allow for custom fields to be consumed in a simpler way within the vended account. Going to close out this issue for the time being, but feel free to reopen it if this doesn't quite accomplish what you were looking for, thanks!


[SPARK-33202][CORE] Fix BlockManagerDecommissioner to return the correct migration status

What changes were proposed in this pull request?
This PR changes < into > in the following to fix data loss during storage migrations.
// If we found any new shuffles to migrate or otherwise have not migrated everything.
- newShufflesToMigrate.nonEmpty || migratingShuffles.size < numMigratedShuffles.get()
+ newShufflesToMigrate.nonEmpty || migratingShuffles.size > numMigratedShuffles.get()

Why are the changes needed?
refreshOffloadingShuffleBlocks should return true when the migration is still on-going.
Since migratingShuffles is defined like the following, migratingShuffles.size > numMigratedShuffles.get() means the migration is not finished.
// Shuffles which are either in queue for migrations or migrated
protected[storage] val migratingShuffles = mutable.HashSet[ShuffleBlockInfo]()

Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CI with the updated test cases.

Test build #130071 has started for PR 30116 at commit 421c10c.

cc @holdenk

cc @HyukjinKwon since you are interested in this area, too.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34680/

Thanks for cc'ing me.

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34680/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34680/
Test PASSed.

Test build #130071 has finished for PR 30116 at commit 421c10c.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130071/
Test FAILed.

retest this please

Test build #130077 has started for PR 30116 at commit 421c10c.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34686/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34686/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34686/
Test PASSed.

Test build #130077 has finished for PR 30116 at commit 421c10c.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130077/
Test FAILed.

Test build #130098 has started for PR 30116 at commit fadcf55.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34707/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34707/

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34707/
Test PASSed.

cc: @Ngone51

Test build #130102 has started for PR 30116 at commit fa10f3a.

LGTM pending integration testing.

Test build #130098 has finished for PR 30116 at commit fadcf55.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130098/
Test PASSed.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34711/

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34711/

Merged build finished. Test PASSed.

Test build #130102 has finished for PR 30116 at commit fa10f3a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130102/
Test PASSed.

Since this is a bug fix, if no one has any concerns I'll merge this tonight.

Thank you for review and approval, @holdenk . I'll merge this with your LGTM. :)
This is an obvious fix > and <.

Nice, +1. Seems like properly merged to master.

Good catch! late LGTM.


PLUTO-683 - TCK: Contesting tests that invoke a ResourceURL that

was written to the response with BaseURL.write(Writer writer, boolean escapeXML) when passing escapeXML=true

Merged, thank you. :octocat: Sent from GH.


Update tapir-iron, tapir-json-circe, ... to 1.11.4

About this PR
📦 Updates

com.softwaremill.sttp.tapir:tapir-iron
com.softwaremill.sttp.tapir:tapir-json-circe
com.softwaremill.sttp.tapir:tapir-openapi-docs
com.softwaremill.sttp.tapir:tapir-redoc-bundle

from 1.11.1 to 1.11.4
📜 GitHub Release Notes - Version Diff
Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

⚙ Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.softwaremill.sttp.tapir" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.softwaremill.sttp.tapir" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1

Superseded by #74.


Change URL path

Is it possible to change the URL?
For example, currently it is:
www.mywebsite.com/posts/category/sub-category/my-post
Is it possible to drop the categories and make it simply:
www.mywebsite.com/posts/my-post
?
Failing that, can I set up redirects? It would be a lot more complicated but it's better than nothing.
Thanks!

I have the same issue with you dude. The URL is a bit long and complex. :-(

Oh, that was simpler than I thought. It's a Hugo thing, not a theme thing.
To config.yaml, add:
[permalinks]
  posts = ':section/:slugorfilename'

More detail: https://gohugo.io/content-management/urls/#permalinks
I suggest adding it to the template.

thx that makes more sense. I will try that.

OK, looks like it doesn't work. It seemed to... But now it doesn't. Did you have any luck with it?

Sorry, still not yet, and I have no idea :-(

I think I was on the right path before. The solution looks to be:
permalinks:
  page:
    posts: ':slugorfilename'

(note the addition of posts that I forgot last time)
I've gone straight for slugorfilename, i.e. www.website.com/this-is-a-post
Does this work for you?

: ( It still doesn't seem to work for me. Baddddd....

Anyway, I plan to put it aside temporarily. It took me so much time. 👎