docs: updated about pages of issuance and schemas

:tada: This PR is included in version 1.6.0 :tada:
The release is available on:

Visual Studio Marketplace
GitHub release

Your semantic-release bot :package::rocket:


fix all clippy errors and update versions

What this PR does / why we need it:
closes #383
This fixes all current clippy lint errors and adds ci checks for clippy.
Special notes for your reviewer:
#383 mentions "adding a clippy.toml file" for addressing function has too many arguments but i elected not to add that in interest of #[allow(clippy::too_many_arguments)] instead. This makes those functions with too many args the exception rather than a rule. If these need to be refactored into some kind of struct later than it may be worth logging an issue specifically for that.
If applicable:

[ ] this PR has an associated PR with documentation in akri-docs
[ ] this PR contains unit tests
[x] added code adheres to standard Rust formatting (cargo fmt)
[x] code builds properly (cargo build)
[x] code is free of common mistakes (cargo clippy)
[x] all Akri tests succeed (cargo test)
[x] inline documentation builds (cargo doc)
[x] version has been updated appropriately (./version.sh)
[ ] all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

@Ragnyll, thanks for picking this up! You're approach of using #[allow(clippy::too_many_arguments)] flags instead of a clippy.toml file is super sound -- it also makes it clear exactly which functions need to be updated in the future. I'll take a look at your comments tomorrow but this is looking great.

Huzzah! It's merged. Thanks @kate-goldenring . I'm taking a look around clippy to see if it's worth logging an issue for needless collect thing. There's a ton for that lint already that may fit, but I'll see.
Thanks again!


Document how solar activity and cycles are implemented in TUDAT

It seems that currently this source is used :
https://celestrak.org/SpaceData/sw19571001.txt
with some documentation here :
https://celestrak.org/SpaceData/SpaceWx-format.php
It would be nice to add this to the documentation

Docstrings added in this commit:
https://github.com/tudat-team/tudat-multidoc/commit/a058455890f9ade09ce5fa8b71687c1569ef488d


Move getUrl and getModified

Must be moved after call to defaultsDeep or else options.urlProperty and options.modifiedProperty will be undefined unless specified in the plugin options.

Good catch!


Story tree analysis

Description of Problem:
Stories might be inconsistent with one another. E.g. when story 1 is A > B > C, and story 2 is A > B > X, and C and X are bot actions, then rasa core would now know what to learn. Presently, it is hard to identify such history branches in large story files.
Overview of the Solution:
I wrote the story_tree.py script that solves this problem: https://github.com/RasaHQ/research/blob/master/report_multiWOZ/multiwoz/scripts/story_tree.py (private repo). This issue is about integrating it into rasa, so it can be called to check for inconsistencies with rasa test core, and perhaps also be called for statistics / deleting duplicate stories / exploring the story tree.
Examples (if relevant):
These stories are inconsistent:
## Story 1
* greet
  - utter_greet
* mood_unhappy
  - utter_cheer_up
  - utter_did_that_help
* affirm
  - utter_happy

## Story 2
* greet
  - utter_greet
* mood_unhappy
  - utter_cheer_up
* affirm
  - utter_happy

## Story 3
* greet
  - utter_greet
* mood_happy
  - utter_happy

Blockers (if relevant):

Definition of Done:

[ ] UX is decided (how would users call this function?)
[ ] Original story-tree functionality can be leveraged with Rasa
[ ] Tests are added
[ ] Feature is documented
[ ] Blog post is published (?)

Created a Colab notebook, testing out the solution: https://colab.research.google.com/drive/1We1EcSp_uA31OooC78sReryhMCkOjEKM


Update versions of SI, Nemo, MTK, etc

This PR

updates package versions to the latest ones and fixes issues caused by breaking changes in SI, Nemo, and MTK
Moves Test and TestSetExtensions to test dependencies

I suppose this PR closes #81, #84, #85, #86, #87, #88, #89.


[Hotfix] Correct caption & alt text

@raiym
Before:
case 'caption':
    $this->caption = $arr[$prop];
    break;
case 'accessibility_caption':
    $this->caption = $value;
    break;

After:
case 'caption':
    $this->caption = $arr[$prop];
    break;
case 'accessibility_caption':
    $this->altText = $value;
    break;

@raiym We should merge this PR ASAP because it is a serious bug!

Bump.

@congkv thank you for contribution

@raiym This is an important update. Can you set new version tag for this update?


FIX: #2399 field.setups bug

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.43%. Comparing base (571674d) to head (529d727).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4476   +/-   ##
=======================================
  Coverage   81.43%   81.43%
=======================================
  Files         110      110
  Lines       53481    53482    +1
=======================================
+ Hits        43550    43552    +2
+ Misses       9931     9930    -1


update hessian-lite to 2.6.5

What is the purpose of the change
XXXXX
Brief changelog
XXXXX
Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[ ] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[ ] Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[ ] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #3538 into 2.6.x will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##              2.6.x    #3538      +/-   ##
============================================
- Coverage     47.22%   47.17%   -0.06%
+ Complexity     4302     4301       -1
============================================
  Files           554      554
  Lines         24448    24448
  Branches       4328     4328
============================================
- Hits          11546    11533      -13
- Misses        11104    11117      +13
  Partials       1798     1798

Impacted Files
Coverage Δ
Complexity Δ

...aba/dubbo/remoting/transport/mina/MinaChannel.java
42.25% <0%> (-11.27%)
15% <0%> (-1%)

...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java
83.33% <0%> (-5.56%)
6% <0%> (-1%)

...a/dubbo/remoting/transport/netty/NettyChannel.java
61.25% <0%> (-5%)
20% <0%> (-1%)

.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java
87.85% <0%> (-1.87%)
15% <0%> (ø)

...ba/dubbo/registry/multicast/MulticastRegistry.java
47.28% <0%> (-1.68%)
29% <0%> (ø)

...bo/remoting/transport/netty/NettyCodecAdapter.java
54.68% <0%> (+1.56%)
3% <0%> (ø)
:arrow_down:

...ba/dubbo/remoting/transport/netty/NettyServer.java
71.42% <0%> (+3.57%)
9% <0%> (+1%)
:arrow_up:

.../remoting/transport/netty4/NettyServerHandler.java
83.33% <0%> (+11.11%)
7% <0%> (+1%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update badea86...795822d. Read the comment docs.

release info for hessian-lite 3.2.5
https://github.com/dubbo/hessian-lite/releases/tag/v3.2.5


Support dependency lock files to save the results of package resolution

This is feature request to support lock files to save and re-use the results of a package resolution.
Having to resolve packages each time pex is executed is time consuming and difficult, especially if you end up in workflows that call pex a lot (like in pants). And this is kinda unfortunate, because the results of resolutions can be fairly easily saved, which could in turn save users a lot of time.
What are lockfiles?
Lockfiles save important data about the exact dependency packages needed to reproduce an environment deterministically. This is more than just a pinned version. This is an exact match, with checksums and source information. Many, many packaging solutions use these (cargo, npm, pipfile, poetry, gradle, gem) to gain true determinism in builds.
It's easy to see why pex has never done this because it could be argued that the pex format is itself a kind of lockfile, and you can re-use its resolutions as with --requirements-pex. Pants seems to use pex like this, but this is kind of inefficient, and results in fairly coarse-grained caching effects.
If instead we saved the resolution as a json/toml/yaml lockfile of some kind, caching could be based purely on questions like "does what i have in my cache for this name match the checksum in the lockfile."
What about constraints files?
These are not lockfiles, and were never intended to be. The only difference between them and requirements files is that they don't force the installation of what's inside them, but only constrain the versions of packages if they are installed.
In contrast, a lockfile demands that its exact set of sources get installed, and doesn't allow for any deviation or decision making beyond that. That the pants documenation calls constraints.txt a lockfile is a bit misleading, especially in light of how pex will attempt to perfom resolutions with it. A lockfile is the result of a resolution, not an input to one.
What should lockfiles contain?
At the base, there should be metadata about the platform and implementation it was generated on, and then a list of packages with their checksums and urls they were downloaded from.
How would we use this?
I could see a workflow like this...
pex --generate-lockfile pex.lock -r requirements.txt --no-output-file  # Generate the lockfile and exit
pex -L pex.lock -r requirements.txt -O  # same thing with short options

pex --from-lockfile pex.lock --output-file app.pex  # create the pex using the exact dependencies as specified in the lock file
pex -l pex.lock -o app.pex  # same thing with short options

I'm well aware that this is a big feature request, and I'm willing to help make it happen, but I would need some guidance on where to start.

I guess this is being implemented by  the work under the #1400 umbrella..

@jsirois can this be closed?

Yeah. This is now implemented even though there are missing bits I'd personally like to see; namely, support for lock file updates (pex3 lock update -p just_this_dep -p and_this_one).


Passing variadic arguments in place of options or configs

Hey guys, I wanted to explain a situation here and wanted to get some input with a proposed deviation from the general API/JS spec. This way we are going to make the library more golang like while actually solving a tiny but really annoying problem. I would greatly appreciate your input on the proposal.
Problem
Since the WebRTC spec was written for JS with has first class object, which are basically just maps like structures. A lot of the functions were defined with an "options" like optional parameter. In js this is totally fine because we can declare defaults for function arguments and so if only a part of the object is being set we can just access the default. Unfortunately in golang defaults are not a possibility. In addition this leads to an ugly interface where we sort of HAVE to pass something in place of the options argument. Here are a few examples:
_, err = pc.CreateDataChannel("data", RTCDataChannelInit{})
	assert.Nil(t, err)

_, err := New(RTCConfiguration{})
	assert.Nil(t, err)

We could semi solve this problem by setting those arguments to a pointer passing but this still will require our users to pass a nil in the argument.  For example this is really problematic with RTCDataChannelInit.Ordered which needs to default to the opposite of the zero value (true). This means if I am calling:
_, err = pc.CreateDataChannel("data", RTCDataChannelInit{})
	assert.Nil(t, err)

How can one know if RTCDataChannelInit.Ordered was set to its golang zero value (false) or actually just not set at all? The proposed solutions from above make the code start looking super ugly as we try to add random checks and conversions. Blah... Golang is great at some stuff and is annoying as hell for others.
Solution
Although this solution is not 100% according with the spec,  it does at least will resemble the use of the specs but will be purely a golang solution.
The idea we could be declare those objects as varidic options functions and pass arguments with WithXYZ() functions. Thus for example the CreateDataChannel definition could look something like:
func (pc *RTCPeerConnection) CreateDataChannel(label string, options ... func(opt ... func() error) error) (*RTCDataChannel, error) {...}

So that when the users are using the functions all of the below use cases would be valid:
_, err = pc.CreateDataChannel("data")

_, err = pc.CreateDataChannel("data", WithRTCDataChannelInit())

_, err = pc.CreateDataChannel("data", WithRTCDataChannelInit(
	WithOrdered(),
	WithMaxPacketLifeTime(),
))

The one problem I see with this is there is not compile time checking which sucks but I guess we cannot win EVERY battle.

One proposal came from @backkem is to get rid of wrapper options function like WithRTCDataChannelInit and just pass the arguments in the outer function so that the use case will look more like:
_, err = pc.CreateDataChannel("data",
	WithOrdered(),
	WithMaxPacketLifeTime(),
)

Another solution (and my favorite) is the one you did with the SDP code, use pointers to show default values.
That is a pain because you can't do &true but you could do something like &webrtc.NullBool{true} which means things can be a one liner.
I think we need to do something that involves passing a struct, otherwise the API is going to look foreign if you compare a JS WebRTC tutorial to pion-WebRTC (and it would be nice if we don't have to rewrite everything because of divergence)

@Sean-Der Hahaha... It is almost like we go back and forth between wanting to be like JS API and not. I started implementing the other approach already but I am happy to change it. Keep in mind that the divergence we are talking about is only going to be related to the argument intake of the different functions that have options/configs allowed. Generally speaking I want to stay as close to the JS API as possible but in this case golang really sucks and therefore I am arguing that it is okay. At the end of the day worst case the only public part that changes are the arguments and as long as I will document it really well, it will be fine. On the positive side, specifically for you @Sean-Der , the API will finally get a unique golang style that is unique to golang and not to the JS API. And as long as we stick to it, this will be a signature mark.
Anyway, all in all I am not opposed to it because it seems like the least of all evils but I am sure I am not thinking through some challenges that WILL come up from this design. So... I am going to leave this decision to you. Ultimately it needs to be aligned with your goals because at some point when the library is mature enough I am going to transition out to my own stuff and you will be the one running around promoting it and teaching people how to use it. Fair?! :stuck_out_tongue_winking_eye:
Q. This means we are going to have these webrtc.NilBool{} types for every primitive. a. are you happy with that? b. If so, can we agree to have it as a separate package so we could use them in all the other pkgs as well. Like the sdp.

I have been messing around with this for quiet a while and no matter how I do it, if we make it using nil the way I did in sdp it will require the user to either use wrapper functions which is ugly or write extra code code the way I did with sdp which is hard because not all users will know that trick. Either way I am kinda leaning more and more towards my proposal as I mess around with this.

https://stackoverflow.com/questions/30716354/how-do-i-do-a-literal-int64-in-go
Found this and wanted to put it here for reference. Gosh I find like golang is missing some seriously basic functionality.

@Sean-Der @kc5nra after a short convo with some of the people in the golang community I am going to do what @Sean-Der wanted. I am going to implement our own special structs that default nil based primitives.

For record keeping, this is what I am going to re-implement and imitate. Credits go to whoever implemented this library. https://golang.org/pkg/database/sql/#NullInt64


Permit tuning chunk-size when constructing a GitOid from a reader

Right now, the internal implementation of GitOid construction from a reader always reads in chunks sized to 4,096 bytes, which is the default page size on Linux for x86-64. If a user is on Linux for x86-64 and hasn't changed the default page size, then this is fine! But we really ought to be more flexible to permit tuning how reading is done to permit different chunking in case that becomes a performance problem for some users.

I think this would either mean:

Use a vec instead of an array as the buffer, to permit dynamic sizing.
Use a build script (perhaps configurable with an environment variable, or even attempting to do some host-info-snooping) to heuristically determine the best size for the read buffer.

We now just delegate to BufReader under the hood, and that's probably better than anything we'd write.


Add node labels to kubelet

Fixes #46.
Dependant on https://github.com/UKHomeOffice/keto/pull/80

Building on master branch of keto (which has PR#80 merged in) and referencing the latest quay build for the labels branch (153e2c23af8b5eb7094d158cfcd298672ca8e40a).
The master nodes fail to retrieve cert files, causing the keto-k8 service to fail:
Jul 05 15:37:16 ip-172-30-1-250.eu-west-1.compute.internal systemd[1]: Starting Keto K8 Service...
Jul 05 15:37:16 ip-172-30-1-250.eu-west-1.compute.internal cp[996]: /usr/bin/cp: cannot stat '/data/ca/etcd/ca.crt': No such file or directory
Jul 05 15:37:16 ip-172-30-1-250.eu-west-1.compute.internal systemd[1]: keto-k8.service: Control process exited, code=exited status=1
Jul 05 15:37:16 ip-172-30-1-250.eu-west-1.compute.internal systemd[1]: Failed to start Keto K8 Service.
Jul 05 15:37:16 ip-172-30-1-250.eu-west-1.compute.internal systemd[1]: keto-k8.service: Unit entered failed state.
Jul 05 15:37:16 ip-172-30-1-250.eu-west-1.compute.internal systemd[1]: keto-k8.service: Failed with result 'exit-code'.
Jul 05 15:37:37 ip-172-30-1-250.eu-west-1.compute.internal systemd[1]: keto-k8.service: Service hold-off time over, scheduling restart.
Jul 05 15:37:37 ip-172-30-1-250.eu-west-1.compute.internal systemd[1]: Stopped Keto K8 Service.

This is in a continuous loop, no success.

As discussed @KashifSaadat it's the etcd-member service with kmm save-assets command that's failing due to no e2e :).
I've created new issue: #49


Use Viewbox for SVG Layer Zooming

Hello!
The Problem
I'm putting together a map with quite a few complex geojson objects and am noticing some significant lag when zooming the map specifically due to the time spent in the _projectLatlngs function. I'm not so familiar with the Leaflet codebase but here's what I'm noticing when zooming:

_projectLatlngs runs on each svg object and bins each point to the map grid resulting in a "stepped" look if you were to zoom the svg element in a bit.
The points are updated the SVG path.

Both of these operations seem fairly slow in the complex case, though I assume they're being done to save memory on SVG paths with unnecessary detail.
Possible Fixes
I think there are a few good options for speeding this up, though:

Use the svg viewbox attribute for zooming. It looks like the view box stays at a fixed size at the moment.
Provide an option to never update / reproject / simplify the polyline element after the initial instantiation unless explicitly called to avoid unnecessary time spent when zooming.
Provide option to asynchronously simplify the polyline after zoom / update.

The first two changes would seem sufficient to me. It's unclear to me how complex the changes would be, though, especially changing zoom to use the viewbox field. I'd also be happy to hear that I'm missing something entirely that already handles this issue! I've already taken a look at the smoothFactor and noClip options.
Thanks!
Garrett

+1 on this. Seeing similar.

I ran into this issue too, where I loaded a complex SVG and zooming in had a "stepped" look.
But after lots of trial and error I realized I was using imageOverlay rather than svgOverlay. When switching to `svgOverlay, it all resolved!
This fix seems to be implemented now, as the docs even suggest viewBox is being used for zoom here. https://leafletjs.com/reference.html#svgoverlay-l-svgoverlay
Correct me if I'm wrong, though.


Wrong regex on check password

Describe the bug
When creating a user and the temporary password is set by Cognito, the verification for password on Laravel (both attempt login or reset password) generate an error, but the password is correctly valid.
To Reproduce
Steps to reproduce the behavior:
I register a user with inviteUser, so Cognito assign a temporary password. The password for the user pool is set with the default settings (1 lowercase, 1 uppercase, 1 number 1 special char, 8 chars length).

The regex of special chars that use AWS has many characters compared with the regex on AwsCognitoUserPool ((?=.*[!@#$%^&*])).
When i try to login with a temporary password (for ex. 3,Wtbz8h, this is a valid temporary password generated by Cognito) i recieve an error of password validation, because the regex implemented on package is too more restrictive.
Expected behavior
The regex for password validation must be follow the same characters of Cognito special chars.
Additional context
I create the action for login and reset password with api routes. Creation of user via cli command.

@gioppy Thank you for highlighting this. We will have this reviewed and resolved.

refer http://awspasswordregex.s3-website-eu-west-1.amazonaws.com/

Released in version 1.2.2


Added cert_reporting_tool plugin based off example/client_context_dump

cert_reporting_tool plugin can be used to examine and log information on loaded certificates. It is based off example/client_context_dump and at this point only takes command to log information on client certificates. Future improvements can be done on this plugin to include server certificates and other interaction/monitoring.

[approve ci clang-analyzer]

[approve ci clang-analyzer]

[approve ci autest]


add PHP_SELF to $_SERVER

#34 To make WordPress work you need $_SERVER["PHP_SELF"] to be the filepath of the php file currently executing.

Can we also double-check that this works as expected when server-side "redirections" occurs? https://stackoverflow.com/a/326331/1352334


Request: support for riscv64-unknown-linux-musl

Checklist

[X] I've looked through the issues and pull requests for similar request
[X] This feature could be solved with a custom docker image (optional)

Describe your request
Simply support for riscv64-unknown-linux-musl when cross compiling
I tried to make my own docker image by modifying the aarch64 musl image, but i could not get it right
Describe why this would be a good inclusion for cross
some systems use systems like alpine use musl and alpine is used as the basis for many lightweight/embeded llinux and riscv is a small architecture so it (appears to be) easy to emulate
support for riscv64 musl would be very nice for cross compiling (it is also a rust target)

Rust 1.82 Promote riscv64gc-unknown-linux-musl to tier 2. Any progress on this issue?

It doens't seem to work though:
curl -sSf https://sh.rustup.rs | sh -s -- --profile minimal -y

curl: (22) The requested URL returned error: 404
rustup: installer for platform 'riscv64gc-unknown-linux-musl' not found, this may be unsupported

@karalabe that's related to host tools, we only need target to work, so not an issue


Activation before Operation Start Time

When an operation is injected using the endpoint PUT http://host.docker.internal:9090/v1/flights/%7Bid%7D and the state in the payload is Activated, the start time of the volumes should be the current or past date/time. Note: This applies for both the following injections:
Modifying to update the operation to the "Activated" state
Modifying any other operation details while remaining in the "Activated" state
The logic here is that if an operation is in the "Activated" state, then the volumes are notionally being utilized by the operator. This is impossible if the volumes' earliest start time is still in the future.
From a automation testing standpoint, where speed of the automation test is key, we see it to be adequate to do one of the following:
Originally set operation start times to be very near in the future (~5 seconds from when the operation is Accepted), or
Simultaneously update the start time of the operation when transitioning to the Activated state
This way we don't have to incorporate large delays in automation test runs waiting for activation times to approach.

This sounds like #217; could you confirm which commit/codebase version you're using?  All our volumes now should start before activation time.
Per bug template for "Test scenario bug", it would be great to have one of the artifacts produced by the test so we can see exactly what the problem is.

Thanks @BenjaminPelletier , I do have an older version. I will update and run the tests again.


Write ctime or mtime on output file based on upload_date of Youtube

Is possible to do that?
Actually last modification date is set according to Last-Modified HTTP header.
https://github.com/rg3/youtube-dl/issues/9386#issuecomment-216880262

Not possible.


Console text wrapping should break on words

Currently, the default wrapping for Console.Print() does not break on words, which makes wrapped text aesthetically displeasing. Is there a method or way to do this, especially with processed strings, that doesn't require a lot of manual finagling?

You can create an Cursor object with new Cursor(Console), this does have Print command that wraps more nicely. Sry for not properly formatting but I'm on mobile and quite busy atm. Good luck!


Update msrest dependency

Related #430

@tonybaloney Any idea when this version will be available in pypi?

Is there a particular reason why this hasn't been published to PyPI yet?
This issue is really causing a lot of friction in the Azure ecosystem 😕


Upgrade select2 lib to 4.0

Hi,
Select2 has released a 4.0.0-rc.1. FYI I created a fork which uses this release. Are we waiting for a full release, or can it be upgraded now?
Thanks,
Abhishek

i'll publish an upgrade when the new release is offically out

+1

:+1:

I would also like this, I think there at a stable release any chance we can get an update?

Select2 4.0 is out -> https://github.com/select2/select2/releases/tag/4.0.0

Now Select2 4.0  is out!!!!!!!!!!!

I'll try to prepare the package on the fork separately. Stay tuned.

Any news? Thanks for your work on this guys.

Any news on this?

v4.0 published - let me know if you find any issues - thanks!


The additional_files parameter of distribution should be able to accept directories and bazel targets, not just files

The additional_files parameter of distribution should be able to accept a directory. For example, given the following directory structure:
runner/conf
runner/conf/web_content
runner/conf/web_content/web_content_schema.gql
runner/conf/societal_model
runner/conf/societal_model/societal_model.gql

We should be able to include them in the distribution without having to specify each file one by one:
distribution(
    name = "distribution",
    ...
    additional_files = {
        "//runner:conf": 'conf',
    },
)

Closing it as it's not relevant anymore because there's no immediate requirement to accept directories and bazel targets in the additional_files field of distribution (FYI, the rule itself has also been restructured into multiple rules such as assemble_*).


Improve layer management

Currently we maintain a hard-coded list of layers in Mapbox.ts: https://github.com/graphhopper/graphhopper-maps/blob/d8603138930fca949adb1c94264e6479162852fb/src/map/Mapbox.ts#L17-L20
This seems to work for now, but when we start adding more layers this is probably not ideal and it might be better to keep Mapbox.ts independent from the layers we like to add to the map. With some kind of external layer management maybe we also do not need the current workaround of re-creating the map instance when we change the background layer (mapStyle) here:
https://github.com/graphhopper/graphhopper-maps/blob/d8603138930fca949adb1c94264e6479162852fb/src/map/Map.tsx#L22-L35
Maybe we can take a look at popular react/mapbox wrappers to borrow some ideas for this and/or even use one of those wrappers, like:

https://github.com/visgl/react-map-gl
https://github.com/alex3165/react-mapbox-gl

It's probably a good idea to review this issue when we start working on #24

With #87 it is now easier to add more layers and currently I don't think there is anything more to be done.


How does the server receive messages from the client

MQTTnet ： V4.2.1
History:Server instance listening UseApplicationMessageReceivedHandler，How to implement the new version。

See https://github.com/dotnet/MQTTnet/blob/master/Samples/Server/Server_Intercepting_Samples.cs

I assume that this question is answered.


Microsoft Authentication on Start Fails

Issue Type: Bug
With each new session, I get signed out (not signed in) for the Sync Settings and Live Share features, I can successfully sign in if I click on the profile icon and sign in for my Microsoft account for both Live Share and Settings Sync, but I have to do that every time I close VSCode and open it again. GitHub account can log in on start with no issue. This problem persisted a few updates now and is getting really annoying.
On opening VSCode I get the following error in the Microsoft Authenticator output winow:
[Error  - 10:37:32.781] Getting token failed: Error: Unable to transform input.
I'm also getting these errors while I'm logging in:
[Info  - 10:55:22.926] Exchanging login code for token
[Info  - 10:55:23.254] Exchanging login code for token success
[Error  - 10:55:23.255] Unexpected token � in JSON at position 0
[Info  - 10:55:23.255] Failed to fetch token claims from access_token. Attempting to parse id_token instead
[Info  - 10:55:23.256] Login successful
VS Code version: Code 1.54.1 (f30a9b73e8ffc278e71575118b6bf568f04587c8, 2021-03-04T22:38:31.419Z)
OS version: Windows_NT x64 10.0.19042

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz (8 x 4200)

GPU Status
2d_canvas: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: enabledopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: enabled_onvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
15.96GB (9.82GB free)

Process Argv
--crash-reporter-id 7c42bbe9-f41a-4350-ac27-9bdd8387e1f8

Screen Reader
no

VM
0%

Extensions (7)

Extension
Author (truncated)
Version

naysayer88
dav
1.1.3

gitlens
eam
11.3.0

vscode-pull-request-github
Git
0.24.0

theme-monokai-pro-vscode
mon
1.1.18

csharp
ms-
1.23.9

vsliveshare
ms-
1.0.3912

rust
rus
0.7.8

(1 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspyt653:30253241
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244cf:30256637
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30259475
dockersubset:30265998
pythontb:30265425
vspre833:30267464

The issue seems to be fixed here on latest update.


added main() and also added example explanation.

Added main() and explanation of code with the help of example.
Visual representation of how array is checked to get required answer.

Thank you 😀


MWPW-142577 - Root pages only load media from content root

Update all media paths to load from content root only for root pages

Resolves: MWPW-142577
Test URLs:

Before: https://main--cc--adobecom.hlx.live/creativecloud/3d-ar?martech=off
After: https://dotmedia--cc--aishwaryamathuria.hlx.live/creativecloud/3d-ar?martech=off

Codecov Report
Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 86.78%. Comparing base (2ae8755) to head (1aafcaa).

Files
Patch %
Lines

creativecloud/scripts/utils.js
0.00%
3 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #236      +/-   ##
==========================================
- Coverage   87.06%   86.78%   -0.28%
==========================================
  Files           9        9
  Lines         943      946       +3
==========================================
  Hits          821      821
- Misses        122      125       +3

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Integrate Sonatype Nexus With OpenShift OAuth

As a CI/CD administrator, it would be very nice if Nexus were to use OpenShift authentication instead of it's own authentication. Using OpenShift OAuth Proxy as a sidecar, it should be possible to integrate with the Nexus "Remote User Token" feature for authentication.

This would be cool @InfoSec812! We did some work on my current client to change the default nexus password using the post hook in ci/cd and a custom script but its not great as it replaces the admin password on the first run after configuring repos etc..... then on a replay of the inventory it fails to replace as the password has already changed!! It doesn't sync with openshift but we store teh secret there anyway.

@springdo you should checkout encrypting the string with ansible vault and replacing it in your local repo with that custom script after it updates the password (or just put the custom password you want into an encrypted string in a file). Check out my example for secrets with applier here

We had some additional discussions around just using the service account token which is associated with the Jenkins service account. Since that is a long-lived token it would be sufficient for Jenkins to interact with Nexus.


[Bug Report]: Cooking Sequence Error

The Long Dark Version
v2.24
Mod Version
v1.1.1
Other Mods Installed

AlcoholMod v2.0.3
AlternativeActionUtilities v1.1.0
AmbientLights v2.8.1
Better-Water-Management v5.2.0
BetterBases v1.1.0
Bountiful Foraging v1.1.2
Camping Tools v2.2.0
Candlelight v1.4.0
CanneryManufacturingDLC v1.5.0
CarryWeightMod v1.0.1
CozyBlankets v1.4.1
CozyCushions v1.6.0
CraftingRevisions v2.2.2
DeveloperConsole v1.5.1
DisableBreathEffect v1.4
DIY by Santana v2.2
ExamineActionsAPI v1.0.4
ExportJournal v1.0.0
ExtraGraphicsSettings v1.1.001
ExtremeTempDrop v1.0.1
Faster Harvesting v1.0.0
Fire Pack DLC v2.7.0
FoodPackByTKG v5.1
FoodsByCalorieWaltz v1.0.6
FuelManager v1.2.7
FullSwing v1.0.0
GearDecayModifier v2.2
GearSpawner v2.3.2
Modders' Gear Toolbox v1.0.0
HouseLights v2.5.2
ImprovedLoadingScreens v1.1.3
IncreaseSaveSlotLimit v1.2
IndoorCampfires v2.1.0
Indoors Greenery v3.1.0
InfiniteFiresDLC v1.3.0
ItemPicker v1.0.0
KeroseneLampTweaks v2.3.0
KeyboardUtilities v2.0.0
LocalizationUtilities v2.0.0
LonelyOrca v4.0.0
MapManager v1.1.3
ModComponent v6.2.1
ModData v1.5.1
ModSettings v2.0.0
Moment v1.0.0
MotionTracker v1.1.0
Muscle v1.0.2
PlacingAnywhere v2.6.0
QoL v1.6.1
Radial Menu Utilities v1.1.1
RandomMainMenu v2.2.0
SkipIntroRedux v3.1.1
SonicMode v2.1.0
StretchArmstrong v2.0.0
TimberwolvesAnywhere v2.0.0
TinyTweaks-BuryHumanCorpses v1.0.2
TinyTweaks-FixDroppedOrientation v1.0.2
TinyTweaks-RespawnablePlants v1.0.2
WorkingClocks v1.2.0

Describe the Issue
The issue seems to break something within the cooking sequence.
I haven't gotten this issue before; I'm opening this from behalf of someone else's report from the The Long Dark Modding Discord.
Steps to Reproduce
I haven't gotten this issue before; I'm opening this from behalf of someone else's report from the The Long Dark Modding Discord.
Log Output
Latest.log
Screenshots
No response

Closed this issue as it is being caused by the same issue as #7.


[release/v7.4] Add a way to use only NuGet feed sources

Backport #24528
This pull request includes updates to the build.psm1 file to add a new source option and various configuration files to update package source URLs. Additionally, there are improvements to the tools/findMissingNotices.ps1 script to handle missing registrations and version conversion.
Updates to build.psm1:

Added NuGetOnly to the ValidateSet for the $Source parameter in the Switch-PSNugetConfig function.
Updated the Switch-PSNugetConfig function to handle the new NuGetOnly source option.

Configuration updates:

Updated the package source URL in nuget.config to use the new PowerShell URL.
Updated the package source URL in src/Modules/nuget.config to use the new PowerShell URL.
Updated the package source URL in test/tools/Modules/nuget.config to use the new PowerShell URL.

Improvements to tools/findMissingNotices.ps1:

Added a check to ensure that the registration table does not already contain the component name before adding it.
Added a new ConvertTo-SemVer function to handle version conversion and edge cases.

Failures in container tests are because https://github.com/PowerShell/PowerShell/pull/24543 is not backported yet.

Windows CI failure is new, but seems unrelated.  Rerunning.


feat(esl-tabs): ESLTabs migrated to ESLEventListeners

BREAKING-CHANGE: listeners extended from ESLTabs should now use @listen annotation to work correctly

:tada: This PR is included in version 4.0.0-beta.19 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 4.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


about run_duration

the document should detail about what if run_duration is more than 24 hrs or 100 hrs?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f1188cb1-de0a-ce57-5baf-40ae903b41ef
Version Independent ID: 86dc9874-a01d-e26f-d13b-3785ffd5c497
Content: dbo.sysjobhistory (Transact-SQL) - SQL Server
Content Source: docs/relational-databases/system-tables/dbo-sysjobhistory-transact-sql.md
Product: sql
Technology: system-objects
GitHub Login: @stevestein
Microsoft Alias: sstein

Hello @jeffrey-yao! Thank you for providing your feedback on our documentation. I'm adding my colleague, Steve to help clarify.

@jeffrey-yao - Thanks for the feedback!
I'll have to investigate this. Are you seeing incorrect values for long-running jobs?

Hi @stevestein , I tested it a job running more than 24 hrs, but less than 100 hrs, the value is still correct. But given the current format, i.e. HHMMSS, if a job is running longer than 100 hrs (i.e. 4+ days), what the value can be? truncated? I will do a test and update it here.

Via -
select run_duration
, STUFF(STUFF(STUFF(RIGHT(REPLICATE('0',8) + CAST(run_duration as VARCHAR(8)), 8), 3, 0, ':'), 6, 0, ':'), 9, 0 , ':') as RunDuration
from msdb.dbo.sysjobhistory
order by run_duration desc
We have:
run_duration
3674505	03:67:45:05
3674505	03:67:45:05
3632855	03:63:28:55
3632854	03:63:28:54
3630357	03:63:03:57

Sorry for extra post - can't find an 'edit' option:
In post above - paying attention to the results at the bottom - it does not make sense that something would run more than 24 hours without overflowing into the next day - how do we have 3 days and 64 hour run times if this is really DD:HH:MM:SS format?
It would seem that just providing a single simple base unit - total seconds run time - for example would be more effective to consume and use.

Taking a look at the issue.

Sorry for the delay, the article's example shows how to display run duration as days, hours, minutes, seconds, all of which are supported.


Add android:exported="true"  to com.marianhello.bgloc.sync.AuthenticatorService to match android 12

need to match requirement for SDK31
Your Environment

Plugin version:
Platform: iOS or Android
OS version:
Device manufacturer and model:

Running in Simulator:
Cordova version (cordova -v):
Cordova platform version (cordova platform ls):
Plugin configuration options:
Link to your project:

Context

Expected Behavior

Actual Behavior

Possible Fix

Steps to Reproduce

Context

Debug logs

in the file cordova-plugin-background-geolocation/plugin.xml
Amend <service android:name="com.marianhello.bgloc.sync.AuthenticatorService"
add: android:exported="true"


Leaderboard scheduling support plus reward fetching

Since rewards support is not fully fleshed out yet, creation and deletion of it has been pushed for now.

Blocked until @Salam4nder reaches a conclusion on if we convert the endpoints to support using leaderboard key or if I need to convert the SDK to use leaderboard id.

Unblocked, the endpoints now support leaderboard key as well


[CWS] move code handling windows raw events out of the select

What does this PR do?
The select is starting to get a bit big and messy causing some potential issues with shared variables across those cases. This PR cleans up this code by moving the cases into handleXXX functions.
Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Microsoft SQL Server Support?

Hello team, we are looking into new deployment options for Snowflake and also Microsoft SQL Server
Is there a possible way to configure schemachange in order to target deployments towards SQL Server? :-)

Hello @hnipen
Thank you for reaching out. Unfortunately, schemachange was built to work with snowflake only.
We do not have plans for supporting any databases other than Snowflake at this time.


Vulnerability roundup 71: qemu-4.0.0: 2 advisories

search, files

[ ] CVE-2019-12928 (nixos-unstable)
[ ] CVE-2019-12929 (nixos-unstable)

Scanned versions: nixos-unstable: 73392e79aa6. May contain false positives.

Both are still being disputed.

CVE-2019-12928: Disputed, “QEMU's -qmp interface is meant to be used by trusted users.”
CVE-2019-12929: Disputed, “QEMU's -qmp interface is meant to be used by trusted users.”

Let's move on and concentrate on actionable items.


Issue #9

https://github.com/BurkusCat/r6-operator-counters/issues/9

Looks great! Thank you for the contribution 👍


net/http: http.MaxBytesReader has a bug

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?
go version go1.6 windows/amd64

What operating system and processor architecture are you using (go env)?
set GOARCH=amd64
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=d:\gopath
set GORACE=
set GOROOT=d:\go
set GOTOOLDIR=d:\go\pkg\tool\windows_amd64
set GO15VENDOREXPERIMENT=1
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0
set CXX=g++
set CGO_ENABLED=1

What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.

http://play.golang.org/p/bfo9_XiI49

What did you expect to see?

----------------------------------------
99 <nil>
0 EOF
0 EOF
0 EOF
----------------------------------------
100 <nil>
0 EOF
0 EOF
0 EOF
----------------------------------------
100 <nil>
0 http: request body too large
0 http: request body too large
0 http: request body too large

What did you see instead?

----------------------------------------
99 <nil>
0 EOF
0 EOF
0 EOF
----------------------------------------
100 <nil>
0 EOF
0 http: request body too large
0 http: request body too large
----------------------------------------
100 <nil>
0 http: request body too large
0 EOF
0 http: request body too large

here is my code to fix it.
type maxBytesReader struct {
	w         ResponseWriter
	r         io.ReadCloser // underlying reader
	n         int64         // max bytes remaining
	stopped   bool
	sawEOF    bool
	overLimit bool
}

func (l *maxBytesReader) Read(p []byte) (n int, err error) {
	toRead := l.n
	if l.n <= 0 {
		if l.overLimit {
			return l.tooLarge()
		}
		if l.sawEOF {
			return 0, io.EOF
		}
		// The underlying io.Reader may not return (0, io.EOF)
		// at EOF if the requested size is 0, so read 1 byte
		// instead. The io.Reader docs are a bit ambiguous
		// about the return value of Read when 0 bytes are
		// requested, and {bytes,strings}.Reader gets it wrong
		// too (it returns (0, nil) even at EOF).
		toRead = 1
	}
	if int64(len(p)) > toRead {
		p = p[:toRead]
	}
	n, err = l.r.Read(p)
	if err == io.EOF {
		l.sawEOF = true
	}
	if l.n <= 0 {
		// If we had zero bytes to read remaining (but hadn't seen EOF)
		// and we get a byte here, that means we went over our limit.
		if n > 0 {
			l.overLimit = true
			return l.tooLarge()
		}
		return 0, err
	}
	l.n -= int64(n)
	return
}

updated, see above

Can you briefly describe the bug? It's not immediately obvious from the description. Is it confusion about whether the boundary value n is inclusive or exclusive?
We don't take patches in the bug tracker. To submit a fix, see https://golang.org/doc/contribute.html. Although I suspect we'd just want to update documentation if this is a boundary issue.

@bradfitz
I'm sorry my English is not good.
it is not a patch or CL, it is just a issue.
how to fix it, I am not care.
for a io.Reader, I think the result is not correct
----------------------------------------
99 <nil>
0 EOF
0 EOF
0 EOF
----------------------------------------
100 <nil>
0 EOF
0 http: request body too large
0 http: request body too large
----------------------------------------
100 <nil>
0 http: request body too large
0 EOF
0 http: request body too large

@bradfitz , see
https://github.com/golang/go/issues/10884
Either the docs should be amended to say "returns a non-EOF error for a Read up to or beyond the limit", or the behaviour should be changed. IMO, the more useful functionality is the documented behaviour, but the implementation would be a little more complex.

What say you @bradfitz?

I suggest update documentation

If I understand this bug correctly, it's that @chanxuehong expects error values returned by Read to be the same on subsequent Read calls after a non-nil error was returned by Read. Generally Go doesn't make that promise on its io.Reader types, but we could here.
I sent https://go-review.googlesource.com/23009


Fix Inconsistent URL Format in Documentation

Fixes #11007
Description:
In this pull request, I address issue #11007, which relates to the inconsistent usage of URLs in the Wagtail documentation.
Changes Made:
I've standardized the URL format used throughout the documentation to consistently use "http://localhost:8000/" instead of "http://<IP_ADDRESS>:8000/". This change improves the clarity and user experience for individuals setting up a local development environment while following the documentation.
Please check the following:

[x] Do the tests still pass?[^1]
[x] Does the code comply with the style guide?

[x] Run make lint from the Wagtail root.

[ ] For Python changes: Have you added tests to cover the new/fixed behaviour?
[ ] For front-end changes: Did you test on all of Wagtail’s supported environments?[^2]

[ ] Please list the exact browser and operating system versions you tested:
[ ] Please list which assistive technologies [^3] you tested:

[x] For new features: Has the documentation been updated accordingly?

Thanks for giving this a go @codewithmide. As far as I can see there was only one inconsistency where we use localhost instead of <IP_ADDRESS>. I’d prefer we change that one spot rather than everything else, unless we have a good reason?
I believe we chose <IP_ADDRESS> because that’s what the runserver command we use displays in its output.

Yeah that's true, I have made the change now. Thank you for the correction.


[Feature Request] Hide Captured Windows from taskbar

This allows less clutter if possible. Everything is already tidy with this program. Seems redundant to show in the Taskbar, especially when opening multiple windows.

I think this is already the case, isn't it? Or maybe it is only on experimental preview. (link to install experimental preview version is in read me) I wasn't sure.

Note that this only applies to non UWP window. See #2

I'll keep the issue open for now in case you have any questions.

No, I downloaded via MS Store. If u have no plans to update the beta, I'll switch to dev version.
But how would one switchback to beta from dev?

Anyways this is resolved, I think. Therefore,
I will close all the issues that are resolved in the code. I unfortunately don't have an ETA on when the store release will be here.


Support custom client_max_body_size

client_max_body_size is fairly low by default in nginx. This comes up frequently enough that I made it an env var. Usage example: CLIENT_MAX_BODY_SIZE=20M

Thanks, looks good! I'll add something to the README.md too


Add error handling to getting video resolution

Added error handling to getVideoResolution method because it does not handle exceptions.
MediaMetadataRetriever.setDatasource may cause IllegalArgumentException or any other exceptions.

Thanks great pull request !!!!!


Fixing destination arg

@mrcoles Please merge?

Sure, thx for the heads up @adjohnson916 😆

I added a couple more updates and launched on npm as v0.0.5: https://github.com/mrcoles/bookmarklet/compare/d405f9ddbe962f9a32fb36acc1f0928df2bc53a0...0.0.5

@mrcoles thanks!


Try imageCompression() catches a ProgressEvent instead of an error

Here our sentry error report:
https://apurata.sentry.io/share/issue/a6c8327fb98f45f79da12a264276aec2/
At least it'd be nice to understand why is happening this in order to handle it properly.

It just catches whatever error your browser throws. Look at error.target.error if you can and have a look at what the actual error is. In my case, we had a webview problem where the file was just discarded immediately. See screenshot for example.


paging is failing

I was querying AWS API against workspaces.
we currently have 35 instances.
but running status with aws-shell only returns the 1st 25 (24?)
running the same query against aws cli tool, we get the same number as web console.
aws workspaces describe-workspaces --output text | grep WORKSPACES | wc -l
      35

aws> workspaces describe-workspaces --output text | grep WORKSPACES | wc -l
      25

this is fixed with
--next-token (string)


travis: use YAML block format for a better visualization.

Let me send pull-request about .travis.yml.
I think that the YAML block format makes us see .travis.yml like a real shell script.
Reference: https://en.wikipedia.org/wiki/YAML#Basic_components
How do you think?

Great idea.  Merged as cb13779d7a21e444cf37715c681b6b014d01223d, thanks!


[Upbit] add support for market orders and candlestick

add support for market order (api doc en, kr)
add support for candlestick (api doc en, kr)

@bigscoop
Are there any more changes needed? If not, could you merge? Thanks!


status line not rendering correctly on ubuntu 19.04

My status bar at the bottom did not render.  Install on Dell XPS 15 (model 9570).
Not sure what happen.  It was fine on my other Dell which is a lattitude also on ubuntu 19.04.
Please advise.

Hello @kyp0717
I suggest you compare your configurations.
Check your .bashrc or equivalent. Make sure TERM has proper value outside of tmux, e.g. xterm-256color.


Add Advancement Tab to Event Page for Team Advancement

Show Teams Advancing to the Next Event on the Advancement Tab, as well as link to that event

See #367.


[Bug] Release v1.9.1 seems broken

After updating from v1.9.0 to v1.9.1 of this plugin, all accessories showed up as "Unsupported" in my Home.app on iOS 16.
Reverting back to v1.9.0 got back all my accessories.
Need to figure out what got broken in order to release future versions of the plugin.

Strange that I did not notice this issue while running it on my Mac during development. 🤔

In the logs I spotted this:
[10/1/2022, 1:34:40 AM] [zigbee2mqtt] Restoring accessory: light_hobbyroom (0x00178801033bbc80)
[10/1/2022, 1:34:40 AM] [zigbee2mqtt] Exception occurred when creating services for lights/hobby/pendant: TypeError: Cannot read properties of undefined (reading 'additionalConfig')
[10/1/2022, 1:34:40 AM] [zigbee2mqtt] Restoring accessory: light_office (0x0017880100d9b08f)
[10/1/2022, 1:34:40 AM] [zigbee2mqtt] Exception occurred when creating services for lights/office/pendant: TypeError: Cannot read properties of undefined (reading 'additionalConfig')
[10/1/2022, 1:34:40 AM] [zigbee2mqtt] Restoring accessory: light_guestbedroom (0x00178801026f884a)
[10/1/2022, 1:34:40 AM] [zigbee2mqtt] Exception occurred when creating services for lights/guestbedroom/pendant: TypeError: Cannot read properties of undefined (reading 'additionalConfig')
[10/1/2022, 1:34:41 AM] [zigbee2mqtt] Restoring accessory: light_officedesk_right (0x0017880106117ff9)
[10/1/2022, 1:34:41 AM] [zigbee2mqtt] Exception occurred when creating services for lights/office/desk_right: TypeError: Cannot read properties of undefined (reading 'additionalConfig')
[10/1/2022, 1:34:41 AM] [zigbee2mqtt] Restoring accessory: light_officedesk_left (0x0017880106117b15)
[10/1/2022, 1:34:41 AM] [zigbee2mqtt] Exception occurred when creating services for lights/office/desk_left: TypeError: Cannot read properties of undefined (reading 'additionalConfig')
[10/1/2022, 1:34:41 AM] [zigbee2mqtt] Restoring accessory: light_livingroom_sinnerlig (0x0017880100fca647)
[10/1/2022, 1:34:41 AM] [zigbee2mqtt] Exception occurred when creating services for lights/livingroom/sinnerlig: TypeError: Cannot read properties of undefined (reading 'additionalConfig')
[10/1/2022, 1:34:41 AM] [zigbee2mqtt] Restoring accessory: light_kitchen (0x0017880100d9b1cb)
[10/1/2022, 1:34:41 AM] [zigbee2mqtt] Exception occurred when creating services for lights/kitchen/pendant: TypeError: Cannot read properties of undefined (reading 'additionalConfig')
[10/1/2022, 1:34:41 AM] [zigbee2mqtt] Restoring accessory: light_frontdoor (0x00178801026f88da)
[10/1/2022, 1:34:41 AM] [zigbee2mqtt] Exception occurred when creating services for lights/outside/frontdoor: TypeError: Cannot read properties of undefined (reading 'additionalConfig')

In several locations, I passed accessory.isPropertyExcluded as a "callback", but I forgot to bind it to accessory, causing the actual call to fail.
This did apparently also happen on my development machine, but somehow I did not notice this.


Vertico improvements: theming, bugfixes, new bindings, adaptations to upstream changes

This PR contains:

bumps for :completion vertico and :ui doom
teco's recent theming improvements for marginalia and orderless
better keys for consult-crm
a fix for <leader> c j since it used cmd! instead of cmd!!
binding the new consult-line-multi to <leader s B> (the prefix argument makes it search all buffers, without it it just searches buffers of the current project)
usage of the recently introduced new embark indicator format
add marginalia annotations to functions that don't have them
a bugfix for consult-recent-file
cc: @tecosaur @elken @minad

I'm converting this back to draft because there are some cool upstream embark changes that would be a shame to wait until the next bump to get, but require a bit of manual work on my part to fix the which key intergration. Should be ready soonish.

@hlissner also note 9d2131b, the lazy loading of recentf-mode introduced in 97048e2 had the side effect having consult previews on when using SPC f r, due to the fact that consult-customize works on named commands. This fixes that using advice, hopefully that's fine.

Is it possible to ad the icons to projectile-find-file?
Thanks!

@numkem yeah I'll add this to all-the-icons-completions and bump it, good catch

Looks good to me. Great work! And thanks again!


New version scaffold

AddLiquidity:

Add balancerVersion field to PoolStateInput (API will need to implement this)

Examples currently fail because API doesn't provide this yet

Each pool type will have addLiquidityV2 and addLiquidityV3 where relevant encoding/query is implemented

SOR:

Assuming maths and path selection stays the same.
Added balancerVersion parameter to SorConfig
Data providers/enrichers can map from V3 API/onchain format to existing data interfaces:

e.g. subgraphPoolProviderV2/V3 and onChainPoolDataEnricherV2/V3
SmartOrderRouter class checks balancerVersion in config and instantiates correct providers

Output:

SwapV2/V3 map to relevant output interface for tx and query
check balancerVersion
getSwaps & sorGetSwapsWithPools return SwapV2 | SwapV3

TODO:

Update Composable (Gyro are covered by weighted)
Remove Liquidity
Nested joins/exits
Added various TODOs as place holders for future updates, uses TODO V3 flags

Close as duplicate from #180


After adding the IOS SDK to the project (IOS 15), it is not possible to build. Multiple errors exist.

Thanks for your response @AnanthaKrish !
The Xcode version is 13.4, and the deployment target is IOS 15.5. I've used the Swift Package Manager to import the SDK.

@ahmedmogahed Fixed the issue. Please pull the latest main branch to your app.


HA suppport for eventing control plane

Fixes #19
Proposed Changes

HA control plane for eventing

Release Note

High availability support for Knative Eventing control plane

Note that there would be a controller war for config-leader-election configMap if eventing and serving CRs are created in the same namespace.
Not sure if we support that case or not. If we want to support that case, I can do some ugly workaround to make the controllers get along.

Prow job says "Please run ./hack/update-codegen.sh" but nothing happens when I run it.
I will check @markusthoemmes PRs that were doing something around those scripts in ./hack later

@aliok
The HA configuration only work for deployments with HPA associated, or without leader election.
If the deployment goes with leader election, HA config does not work.

@houshengbo I am having trouble figuring it out what deployments support HA. I see #73 would help but I don't want this PR to wait until then.

Is this blocked on the WIP Eventing PR?

/close
This is included in https://github.com/knative/operator/pull/134
Thanks for the heads up @Cynocracy


Styling issue nested accordions

Describe the bug
Styling issue nested accordions
How to reproduce
https://stackblitz.com/edit/clarity-light-theme-v2-srh29y
Expected behavior
child accordions should not have the selected style by 'default'
Versions
App

Angular: 8
Node: 10.15.3
Clarity: 2.0.1

Device:

Type: Desktop PC
OS: Windows 10
Browser chrome
Version 75

Workaround:
.clr-accordion-panel-open .clr-accordion-header {
  background: inherit;
}
.clr-accordion-panel-open > .clr-accordion-header {
  background: #d9e4ea;
}
.clr-accordion-panel-open .clr-accordion-angle {
  visibility: visible;
  -webkit-transform: inherit;
  transform: inherit;
}
.clr-accordion-panel-open > .clr-accordion-header > .clr-accordion-header-button > .clr-accordion-status > .clr-accordion-angle {
  visibility: visible;
  -webkit-transform: rotate(90deg);
  transform: rotate(90deg);
}

I think we first have to ask the question if nested accordions is a recommendation.

I do not know if they will be recommendable, but the user will request and develop the pleasure.

To help us understand this request, what is the use case that you wish to have nested accordions?

For example, when we create a vertical menu, with multiple levels of options...
menu1
|--> menu1.1
|--->menu1.1.1
|--->menu1.2

I wouldn't recommend the Accordion as a navigational element.
We offer several components that are intended to be used for building navigation. Included in the navigational components is the Vertical Nav component.

We're using it for auto generated nested forms:

hippee-lee
Clarity navigation solutions are not suitable for multiple menu levels.
That is why we try to use accordion.
Anyway, I appreciate you answering me.
Best regards.

This is not a pattern we are looking to support. If you need to nest accordions and remove the spacing for child accordions, then you could do so in your application's CSS using either a negative margin or translateX


Remove microsoftSqlServer preview flag

Collect issues related to microsoftSqlServer and see if we can remove the preview feature flag.
Introduced in 2.11.0.
Related Issue: https://github.com/prisma/prisma/issues/4039

Open bugs:

https://github.com/prisma/prisma/issues/4535
https://github.com/prisma/migrate/issues/667

I think the following issues should be addressed before we can stabilize SQL Server:

Validation of invalid cascade paths on SQL Server
Implementation of Cascade Settings in PSL - related to the above
Implementation of Constraint Names in PSL

https://github.com/async-email/async-native-tls/issues/24

Migrations team is making progress on blocker issues this cycle — progress is tracked in individual issues, but we are getting closer.

Also related when we remove the preview flag: https://github.com/prisma/docs/issues/1957

Engines side done in https://github.com/prisma/prisma-engines/pull/2183


Refine Fig. 6: Data specification diagram.

Current version:

Update 12/12/23:
@bherr2 suggests we simply use cleaned ER diagram.

An ER Diagram was created and committed to the repo here: https://github.com/x-atlas-consortia/hra-pop/blob/main/er-diagram.mmd (svg version also committed).

@bherr2
Thanks! Keeping this open until the figure is final.

Also available as SVG: https://github.com/x-atlas-consortia/hra-pop/blob/main/er-diagram.svg


Update download_utils.py

write to empty_organism_queries.tsv iteratively rather than after run

Need to space out read/write operation


always on top bug

Microsoft PowerToys version
0.64.0
Installation method
Microsoft Store
Running as admin
Yes
Area(s) with issue?
Always on Top
Steps to reproduce
always on top in  windows 11 21h2 sometime cant run smoothly
✔ Expected Behavior
No response
❌ Actual Behavior
i press the keyboard ctrl windows and t
but these time it can run successfully after my windows update
Other Software
No response

@skgcm666 could you please provide a screen recording of the reproduction?
/info

/needinfo


Uncaught TypeError: Cannot read property 'getState' of undefined

Thanks for the great tool. It works great in one of my projects. In another one I get:
Uncaught TypeError: Cannot read property 'getState' of undefined
at traverseSixteen (hook.js:260)
at traverseSixteen (hook.js:289)
at checkReactDOM (hook.js:148)
at getInitialState (hook.js:24)
at setInitialState (hook.js:36)
at hook.js:49

I'm not OP but I'm having this same issue with a project which does NOT use Redux.

@misstiffanylin Actually both projects used Redux.


Update sphinx and the related packages

Description of the issue
Problem: The current requirements pin sphinx to version 3.2.* which is too old for recent releases of its alabaster theme package - see the CI error here
Solution: Update sphinx and any dependent packages to their recent versions.  Sphinx is currently at version 7.2.6, https://pypi.org/project/Sphinx/#history.
Cirq version
1.4.0.dev at d33b1a71ac9721e762a2fa1b9e9871edfe187a3c.

I can take this on

Sure, Thank you!

@smburdick - this seems a bit urgent, as the current state results in CI failures, for example, #6413.
Are you available to do a PR in a next few days?
No worries if you have other commitments.  I can take over on this one and there will be a plenty of other issues to help us with in the future.  :-)

cc @tanujkhattar

Taking a look. If I make no progress today, I will hand it back to you @pavoljuhas


⚠ Media Fetcher has degraded performance

In 1b4b6bb, Media Fetcher ($SITES_URL_DOWNLOADS) experienced degraded performance:

HTTP code: 525
Response time: 2557 ms

Resolved: Media Fetcher performance has improved in 3443bb6 after 24 minutes.


Use guestinfo instead of cloud-init for passing in VM specific informations

WIP

This issue was moved to kubernetes/kops#2726


postgres dump commands

directory dump seems to be way to complicated for a db of this size, replaced with plain pg_dump and direct restore.
for the user pg_dumpall usage is better practice

wrong repo


Extra data

Need a way to read/write extra data in an IPlaylist without having to know what Type of IPlaylist it is.

[TryGet/Set]CustomData v1.2.0


Adding a particle filter for QSRs to the prob_rep library

Looking at the example of my work, I need a way to online classify interactions between humans and the robot and would also like to predict the next most likely state to choose the correct robot behaviour. This PR adds a particle filter that works on arbitrary QSRs to do exactly that. The particle filter needs a markov model of an interaction, a noise model for the observations, and a state look-up table with all possible states. There can be multiple different markov models and observation models which are all handled at the same time. The particle filter will classify the most likely model and also track the current state of the underlying markov model.
As an input, you can use the hmm, i.e. the emission matrix as the noise model and the transition matrix as the markov model. If there is not enough data to train the emissions properly, you can also create a noise model manually as done in qtc_model_creation.py. Essentially, both matrices have to have the same dimensions NxN where for the markov model M_{j,i} describes the probability of state j to transition to state i and the Observation model for the noise O_{j,i} represents the probability with which state i can be observed when state j has been predicted.
The particle filter, like the hmm, follows the same usage approach:

Create an instance of the correct Request class
Call the ros_client

So all the complexity of the underlying service call is completely hidden from the user. A simple bit of python code:
p = ROSClient().call_service(
  PfRepRequestUpdate(
    uuid="lksajd89ewkmdeaifd", # PF identifier
    observation="-,-,+,+" # Current observation
  )
)

calls the correct service based on the request class and generates the output for you.
For a more detailed example, have a look at the two example clients.
Other changes:

The whole infrastructure of how the services are created and how the correct function is called when a service is called has changed to make it easier to develop and integrate new representations.
services now have different namespace for the different representations, e.g. ~/hmm/create
The hmm now has a generic hmm which accepts a look-up table for the states and a pre-training emission and transition matrix.
The hmm now allows pseudo transitions
Added scripts to create particle filter models from an existing hmm
Added example files for the creation of a particle filter

The particle filter has been tested in simulation. The generic hmm still needs a bit of testing but maybe @pet1330 can do that.
TODO: Documentation needs update or is entirely missing for some functions.

I am happy for it to be merged since the rostests have passed. But, at the moment I am really busy to give it a dedicated spin. If you want someone to give it an extensive test then if anyone can volunteer or maybe someone from Lincoln can do it as it will be easier to reach you for whatever reason needed during the test.

I'll be using this soon, so I'll give it a proper test just after Christmas :smile:

I didn't have time to implement tests for this before I left for holiday; Will do when I'm back. I am confident that @pet1330 will find the possible errors in there ;) Thanks!

@pet1330 did you test this? Can it be merged?

Not yet, it's on my todo list...

Added some very simple tests for the particle filter just checking that it works but not if the actual results make sense.

We found a couple of issues with it today, but these are now  all resolved with the above commits and can now be merged :)

Since the service definition of the qsr_pro_rep lib has changed with this PR, the next release version should be 0.3 @yianni


Questions about reproducing results in the manuscript

Hi, thanks for your great work. I wonder how to reproduce the figure results you showed in Fig. 2A. How to access the region labels? Thanks a lot!

Hi, thanks for your interest! The notebook used for plotting is here. All intermediate results from the paper can be downloaded from here (e.g. see here for embedding-related stuff).

Hi, maybe the last question. You claimed that the embeddings are computed based on reference genome, but you had 8 different reference genome for different speices. Therefore, I wonder if I can access the information of the reference genome you used. Thanks a lot!

We use the Arabidopsis reference genome, specifically:
FASTA_URL: "https://ftp.ncbi.nlm.nih.gov/genomes/all/GCF/000/001/735/GCF_000001735.4_TAIR10.1/GCF_000001735.4_TAIR10.1_genomic.fna.gz"


[build] Add Travis CI Android Build

I haven't written Android apps before, so would be nice if someone would volunteer for this. I can assist. :)
We use CMake for building on CI. I am not sure if our CMake setup supports Android, so that might need some work too.
Resources: https://github.com/raysan5/raylib/wiki/Compile-for-Android

Current raylib src Makefile can easily build raylib for Android just passing PLATFORM_ANDROID, but Android NDK toolchain must be available.
Main issue with Android building comes when trying to generate the APK, just setup my own pipeline based in a plain Makefile. If PLATFORM_ANDROID #ifdefinifion is removed from examples, then I could setup Android APK building for examples... it would be amazing.

move emscripten logic inside raylib

This should be possible, if there is a way to explicitly yield control back to the emscripten "runtime", e.g. an emscripten_yield_till_next_frame. If there is, we could call it in EndDrawing instead of waiting till frame time elapses. Do you know any (preferably, graphic) programs that don't use emscripten_set_main_loop, which one could study?

@gen2brain you're right! just saw it some days ago, but it seems interpreted code is way more slow, it needs to be tested...

@a3f Android NDK r17 has just been released, I'm preparing an standalone toolchain to use with raylib, I'm using Windows 32bit version, could it be used on Travis CI? Or does it require a Linux-based standalone toolchain?

Updated Android build pipeline (Makefile) for ARM64 (now it's default) and API level 21 (minimum required for ARM64). Also using Clang and standalone toolchain. Changes implemented in commit https://github.com/raysan5/raylib/commit/fb4265f64659a50a5a86f9f283e7468b7998c60f
When trying to compile shared library, I got the following error:
C:/android_toolchain_arm64_api21/bin/aarch64-linux-android-clang -shared -o ../release/libs/android/arm64-v8a/libraylib.2.0.0.so core.o rlgl.o shapes.o textures.o text.o models.o utils.o audio.o stb_vorbis.o mini_al.o -Wl,-soname,libraylib..so -Wl,--exclude-libs,libatomic.a -Wl,--build-id -Wl,--no-undefined -Wl,-z,noexecstack -Wl,-z,relro -Wl,-z,now -Wl,--warn-shared-textrel -Wl,--fatal-warnings -u ANativeActivity_onCreate -L. -Lsrc -L../release/libs/android/arm64-v8a -llog -landroid -lEGL -lGLESv2 -lOpenSLES -latomic -lc -lm
core.o: In function `android_main':
core.c:(.text.android_main+0x4c): undefined reference to `main'
clang60.exe: error: linker command failed with exit code 1 (use -v to see invocation)

Updated Android standalone toolchain for ARM64 and API21 with CLang using Android NDK r17 attached to release 2.0.0-rc1 (I know, not the best place, just a quick solution to share it).

undefined reference to main' Adding LDFLAGS=-Wl,--unresolved-symbols=ignore-in-shared-libs` should solve this

I will look into adding an Android build configuration.

Solved with LDFLAGS += -Wl,-undefined,dynamic_lookup, testing 64bit arm building (it becomes mandatory for Android apps on 2019).

LDFLAGS += -Wl,-undefined,dynamic_lookup

Removing -Wl,--no-undefined would suffice as well.

Travis CI seems to start 4 jobs in parallel, but AppVeyor runs them serially, thus when given the choice, testing in Travis CI seems the better choice, so I added a new Android AArch64 target there.

Hi @a3f! Thanks for your work on this issue!
I'm testing it on Android device and despite building correctly, the APK doesn't seem to work on my phone, it shows an arquitecture missmatch issue (I'll post it later). I verified my Android phone CPU and it's an arm64-v8a. I keep working on it.


thumbnail service troubles with new ocis-accounts

Steps

Check out https://github.com/owncloud/ocis/pull/409
Open ocis-web
Upload some pictures
Check the browser console for errors

Expected result
Thumbnail get rendered
Actual result
Errors in browser console, see ocis log.
Logs
ocis log:
2020-08-06T08:55:31+02:00 WRN Failed to execute error="{\"id\":\"com.owncloud.api.thumbnails\",\"code\":500,\"detail\":\"could not get image from source: could not get the image \\\"portrait_1.jpg\\\". Request returned with statuscode 404 \",\"status\":\"Internal Server Error\"}" duration=45.02504 method=Thumbnails.GetThumbnail service=thumbnails

this is an old issue that was transferred from the archived ocis-thumbnails repo a few weeks ago.
@micbar or? Is this still "a thing"?
Please close if no longer relevant.

This is no longer relevant


UI Components Library

Problem:
Currently our HTML and CSS consist of the followings:

A custom bootstrap 3 minified stylesheet injected in the head.
React-boostrap component library.
Custom styles to re-write the bootstrap styles due to changes in design style guide.

As a result, we would need to remove a lot of the unused styles, overwrites, and find a better way to manage our components.
Solution:
We should create our own component library that uses Storybook (isolate the components and document them) and tailwindCSS (style each component) and make sure they meet the web accessibility requirements.

I would roughly break the project down into smaller tasks, and the list can be adjusted as we go:

[x] Setup Storybook - https://github.com/freeCodeCamp/freeCodeCamp/pull/41920
[ ] Setup Tailwind CSS

[x] Basic Tailwind config - https://github.com/freeCodeCamp/freeCodeCamp/pull/42153
[x] Add color tokens to tailwind config (split to issue https://github.com/freeCodeCamp/freeCodeCamp/issues/42186 for further discussion) - https://github.com/freeCodeCamp/freeCodeCamp/pull/42388
[ ] Support dark mode #43616

[x] Setup React Testing Library and its ESLint plugins - https://github.com/freeCodeCamp/freeCodeCamp/pull/42221
[x] Setup TypeScript - #43541
[x] Setup Prettier & other ESLint rules - https://github.com/freeCodeCamp/freeCodeCamp/pull/42818
[ ] Setup css linter for custom CSS - related https://github.com/freeCodeCamp/freeCodeCamp/issues/16445
[ ] Package build and publication setup

[x] Setup Bundler (rollup/webpack/parcel) - https://github.com/freeCodeCamp/freeCodeCamp/pull/42549
[ ] Setup Publication (not for now)

[ ] Write a guide for component development - @huyenltnguyen
[ ] Build the following components

[ ] Alert
[ ] Button - @huyenltnguyen
[ ] Col
[ ] ControlLabel
[ ] DropdownButton (maybe consider using Headless UI's Menu)
[ ] Form
[ ] FormControl
[ ] FormGroup
[ ] Grid
[ ] HelpBlock
[ ] Image
[ ] Media
[ ] MenuItem
[ ] Modal (maybe consider using Headless UI's Dialog)
[ ] Panel
[ ] Row
[ ] Tab
[ ] TabPane
[ ] Tabs
[ ] Table
[ ] ToggleButton (maybe consider using Headless UI's Switch)
[ ] ToggleButtonGroup

[ ] Remove the ToggleButton in /components/helpers and replace it with the one above (? - I'm not sure, I haven't looked at the code closely, but I guess maybe there is a reason to split them)
[ ] Use npm-link to link the ui folder with /client
[ ] Replace react-bootstrap components with our own, one component at a time
[ ] Audit and clean up any unused CSS code
[ ] Remove @freecodecamp/react-bootstrap as a dependency
[ ] Remove the bootstrap stylesheet injection
[ ] Remove all CSS from Learn

Lists were borrowed from @huyenltnguyen's comment below.

TailwindCSS: https://tailwindcss.com/docs/guides/create-react-app
StoryBook: https://storybook.js.org/docs/react/get-started/introduction

Should this issue be consolidated back into https://github.com/freeCodeCamp/freeCodeCamp/issues/16445

For that we would use stylelint which would enforce a common css style. I would keep both issues separate, but link them since they are related.

Can you please share some screenshots and elaborate more on this issue .I'm a newbie trying to contribute for the first time. Can you please help me??

Can you please share some screenshots and elaborate more on this issue .I'm a newbie trying to contribute for the first time. Can you please help me??

Hey @prohackerzzz,
This isn't really an issue it's rather an improvement of the codebase. You can check out the links I posted to familiarize yourself with the documentation. You may be able to contribute to this later.

@prohackerzzz, I think once we have replaced a couple of the components, it would be easer to contribute as a first timer then.

It seems like there is a catch with working on the components one by one.
If we replace only one component, we would need to keep the injected bootstrap to keep the other components styled.
That would result in writing additional bootstrap rewrites for the new component.

@ahmadabdolsaheb I guess we could just build a set of new components first, then we could do incremental migrations when we deem they are ready.
Do we plan to use the components on other platforms too (code radio, news,...) or they will be /learn components only?

Hi, I am also a newbie who would love to help on this issue.  @huyenltnguyen I think that's a good idea to do it incrementally.

@ahmadabdolsaheb I guess we could just build a set of new components first, then we could do incremental migrations when we deem they are ready.

@huyenltnguyen, I think here is the plan moving forward if we are planning to do incremental migration.

The base styles should not be set in tailwindCSS since they include normalizers that also exits in bootstrap. ( we could add base after removing bootstrap completely)
Inject tailwindCSS after other stylesheets in head it rewrites other styles.( We should check the performance implications of adding tailwind while other styles are still injected)
Keep customizations to the minimum ( stick to defaults as much as possible which will help with maintenance down the line )
For every react-bootstrap component used, we should create a tailwindCSS styled storybook component.
Easier to migrate and commonly used components take precedence in migration over harder to migrate and less commonly used ones.
After couple of components are migrated and we gained more experience, we can revisit the battle plan and see if we could use scripts to speed up the migration.

This is a great read: https://dev.to/nejremeslnici/migrating-tachyons-to-tailwind-css-part-i-ich
Please let me what you think.

Do we plan to use the components on other platforms too (code radio, news,...) or they will be /learn components only?
You are asking for the storybook structure?

Eventually we can reuse components across platforms; however, it is best to think about this component library built for learn at the moment to limit the scope of the migration.
Coderadio has very specific UI needs and not sure how modularity would improve it. Going headless with news is in the works but the use of client technologies are not finalized yet.
Ideally learn and news will have similar ui elements (walls of text, grid system, etc) and both could pull from storybook in the future.

I have worked with Storybooks before. I have used tailwind with Storybooks and Svelte, but I'm sure it can be changed into tailwind and React easily.

@ahmadabdolsaheb Thanks a lot! That sounds like a great plan. Now that it is up to us to be responsible for the components' HTML, what I would add as a criteria to our components is that they should be accessible and meet web accessibility requirements (https://www.w3.org/WAI/standards-guidelines/wcag/).
Here is the list of components that we are pulling from @freecodecamp/react-bootstrap:

Alert
Button
Col
ControlLabel
DropdownButton
Form
FormControl
FormGroup
Grid
HelpBlock
Image
ListGroup
ListGroupItem
Media
MenuItem
Modal
Panel
Row
Tab
TabPane
Tabs
Table
ToggleButton
ToggleButtonGroup

I would roughly break the project down into smaller tasks, and the list can be adjusted as we go:

[ ] Setup Storybook and Tailwind CSS
[ ] Build the following components one by one

[ ] Alert
[ ] Button
[ ] Col
[ ] ControlLabel
[ ] DropdownButton
[ ] Form
[ ] FormControl
[ ] FormGroup
[ ] Grid
[ ] HelpBlock
[ ] Image
[ ] Media
[ ] MenuItem
[ ] Modal
[ ] Panel
[ ] Row
[ ] Tab
[ ] TabPane
[ ] Tabs
[ ] Table
[ ] ToggleButton
[ ] ToggleButtonGroup

[ ] Remove the ToggleButton in /components/helpers and replace it with the one above (? - I'm not sure, I haven't looked at the code closely, so I guess maybe there is a reason to split them)
[ ] Replace react-bootstrap components with our own, one component at a time
[ ] Audit and clean up any unused CSS code
[ ] Remove @freecodecamp/react-bootstrap as a dependency
[ ] Remove the bootstrap stylesheet injection

For the component to-do list, I noted them down in alphabetical order, but I'm sure you have a different order in mind with the components' priority, so please help me to adjust it. If the list misses anything please help add them in as well.

Inject tailwindCSS after other stylesheets in head it rewrites other styles.( We should check the performance implications of adding tailwind while other styles are still injected )

Tailwind injection are typically very fast on production because as we know it, it will shake the tree and only inject what we need. While from my OWN experience and others, injecting tailwind into dev, will take longer because it doesn't treeshake on dev.

Tailwind injection are typically very fast on production because as we know it, it will shake the tree and only inject what we need. While from my OWN experience and others, injecting tailwind into dev, will take longer because it doesn't treeshake on dev.

You are correct. TailwindCSS uses PurgeCSS to get rid of unused CSS.

One question I have is does FCC uses Bootstrap or TailwindCSS, because AFAIK it uses bootstrap right?
If so, why are we using tailwindcss on storybook?

We are currently using bootsttrap; however, it comes with design decisions that we had to overwrite over time.

@mrugesh, would you like to have the component library completely isolated as an npm package?

Thanks for asking, I have tried and articulated the intent here: https://github.com/freeCodeCamp/freeCodeCamp/pull/41920#pullrequestreview-644913778, a TL;DR version is yes to isolation and a probable no to a npm package (just for now atleast)

Since we are moving forward with Typescript, it might be beneficial to scaffold the entire storybook setup using a TS package developer CLI such as TSDX, that has Rollup, Jest, tsconfig, TSLint, storybook, etc out of the box. We would just need to add TailwindCSS config and RTL on the top. Thoughts?

I'm not sure about TSDX.
Firstly, it uses TSLint which was deprecated back in 2019 - TSLint's maintainers recommend people use typescript-eslint now.  Also, if we wanted to move on from it, is there an easy way to bail out?

As a general rule, we want to avoid tools that are opinionated.

I see, just to clarify we want the followings:

We want an isolated testable TS module with its independent bundler.
We would like the component library module to be the single source for the styles for learn.

Yes, we would probably prefer a bundler like webpack that we already have experience with but not necessarily married to.

One of the component library documentation patterns include adding the styleguide as the storybook first page.
This might be a good strategy for us to adopt where we could add our styleguide to our storybook, build and deploy it at https://design-style-guide.freecodecamp.org/ and have it be the single source of truth for design.

@ahmadabdolsaheb Do you see https://design-style-guide.freecodecamp.org/ as a simple Storybook page, or will it be a documentation page like Material UI or Tailwind?
I personally prefer documentation page as it is more structured and we can have more content about our design system rather than just component-specific. But I'm obviously painting a far future here.
Could we for now deploy and host Storybook at https://design-style-guide.freecodecamp.org/storybook?

Actually, melding all of these resources under the https://contribute.freecodecamp.org might be a good idea. It should be possible for us to host this something along these lines:
https://contribute.freecodecamp.org --> Contributing Home/Landing Page
https://contribute.freecodecamp.org/translate --> Translations
https://contribute.freecodecamp.org/design --> UI Design Style Guide (redirecting the current guide here)
https://contribute.freecodecamp.org/design/storybook --> The storybook.
etc., you see the idea.
If you both agree, I will set up some configs (on our existing servers) to make this happen.

That works for me. Although we will need to add some extra publish and deploy config to Storybook (I didn't include it in the initial setup).
I can take a look at it, but I'm in the middle of other setup work right now, so it would be great if anyone here can help us with this 🙂
The doc mentions Chromatic as a publishing service. While it is a nice tool that helps automate a lot of workflows, I don't think we really need it, and we can look at storybook-deployer instead (this is also mentioned in the doc).

@huyenltnguyen, since storybook is partly a documentation tool, we could take advantage of that and host our the design style guide inside the storybook and have the whole thing live in https://contribute.freecodecamp.org/design. That way we could add more documentation and turn it into a design system. That being said, I do not have a strong preference either way.
ex.
https://developers.grafana.com/ui/latest/
http://storybook.anyvision.co/
ref.
https://storybook.js.org/tutorials/design-systems-for-developers/

I like Ahmad's idea as it keeps all design related documentation in one link. Also that will help out the new contributors as they don't have to search in two different places.

How is the progress on this?

It is going well, one of the tasks that can be done in parallel is setting up TS for the component library if you are interested.

@samarmohan, t is going well. One of the tasks that can be done in parallel is setting up TS for the component library if you are interested.

Have you heard of bit.dev? it's free for opensource, and you can store your actual components library there, with versioning and everything. You can keep everything in one place, and it works great with storybook too

Have you heard of bit.dev? it's free for opensource, and you can store your actual components library there, with versioning and everything. You can keep everything in one place, and it works great with storybook too
You just import the components into your project, as if they were from any other UI library, so it's like you have your own design system in the cloud that you can pull your components from.
https://www.machineservant.com/blog/2020-11-05-bit-dev-storybook/

Thanks for the suggestion. I think bit.dev would be ideal for larger component libraries. We have a limited number of pre-designed components that need to be migrated from bootstrap.

Hey @huyenltnguyen I have been trying to reach you, could you check your DM on chat or your email (including spam) when you get a chance. Thanks.

Hey @raisedadead, Can I take the Modal component?

Thanks for reaching out @ashiskumar-1999, I recommend you join our contributors chat and get in touch with @huyenltnguyen who is leading the effort. For the most part you should be good though.

Hey @huyenltnguyen, Mind if I can ask for the link of the channel for contributors chat?
Also, what's your thought on taking myself the responsibilities of the Modal component?

Go ahead and give this a quick read: https://contribute.freecodecamp.org - this should get you started

Thanks@raisedadead !😊

Hi @ashiskumar-1999, thanks for giving us a hand!
We have mostly completed the component library setup. I plan to start first with the Button component and try to document the development process to help onboard other contributors. My schedule has been a bit crazy lately, but I think I would have time for that in September.
The Modal component might be a bit complicated with the rendering in a React Portal, as well as the accessibility aspect (elements in the background should be aria-hidden so that screen reader users know what to focus).
I haven't done enough research on this to propose an approach, but our ultimate goal is to reduce the dependence on third-party libraries, so we would either build our components from scratch, or find a light-weight library for complex components (Modal is one of them).
I would recommend going through the existing modals in our codebase first and find the patterns / use cases, so that we know what props the Modal component should support.

Hey @huyenltnguyen ,
Cool. I am going through it. If you may Can I take responsibility to do it?
If my Modal will match your requirement then you can merge it with your codebase or else you can simply close it.

You can also recommend sone component so that I can start the development.

Hey @huyenltnguyen, I have gone through the codebases of other component libraries. They all use the React portal. I can do it.

I want to work on image and toggle button component, Its urgent to contribute for me. Please reply asap.

@mansijain980, thank you for your interest.  If you are in a hurry, I highly recommend adding the color tokens to the config (https://github.com/freeCodeCamp/freeCodeCamp/issues/42186) which is one of the setup steps needed before we could start working on the developing the components.
Additionally, the image component seems straight forward and does not require the theme support which is not implemented yet. Feel free to proceed with creating the image element. Please make sure to review a11y best practices for the image element and document the process of component creation in your pr.
@mansijain980, thank you for your research. Let me do a little bit of research and get back to you on the ways we could move forward on developing tailwind overlay components.

@ashiskumar-1999, I was wondering if you could share the links to the component libraries you looked into for the modal component?
Also did you have a change to look into tailwindUI overlays for samples of modal implementation using tailwind? https://tailwindui.com/#product-application-ui

@ahmadabdolsaheb, I looked into the Carbon design system (https://www.carbondesignsystem.com/components/modal/usage/), Chakra-UI (https://chakra-ui.com/docs/overlay/modal) as a reference. About the TailwindUI overlays part, yes, I have gone through the code samples on the website.

@ahmadabdolsaheb @huyenltnguyen
I'm a SSE but new to open source, let me know if I can contribute in any way.

Yes @ahmadabdolsaheb  that would be great 🎉. Please share a bit more details to help me get started easily.

We have a component library at https://github.com/freeCodeCamp/freeCodeCamp/tree/main/tools/ui-components
that uses storybook for managing and documenting UI components. It uses tailwind to style those components and rollup to bundle them.
A good starting point would be reading the TS related Storybook docs: https://storybook.js.org/docs/react/configure/typescript

Thanks @ahmadabdolsaheb
Let me go through the docs and get back to you on this, most probably with a draft PR.

@ahmadabdolsaheb Here's the link to the PR, looking forward to your valuable feedback.

@ahmadabdolsaheb I enjoyed working on TS configuration for UI components library. I'm up for any other ticket.

Hey friends 👋
First of all, I'm sorry for being absent for a very long time and blocking the work. Covid hit and left me with mental bumps and bruises. I will need some time to get the balance back, but will try to be more responsive here as well as in the chat.
As @ahmadabdolsaheb mentioned, we will need to gather the specs for each component before implementing them. The requirements will be slightly different depending on the complexity of the components, but I think the following questions need to be answered overall:

How the component is being used in FCC apps? For example, does modal always have a header? - Knowing all the use cases allow us have a better idea on what props the component needs to support.
How is the component being themed? - We will need to revisit our color swatch, so having this information will be helpful in defining the color standard.
What is the HTML element the component renders under the hood? - This is so that we can apply the same implementation, or identify any incorrect element usage and address it in the new component. We should also pay attention to other HTML attributes (required, disabled, aria-describedby,...)
What HTML attributes get added/removed when the component changes its state? For example, what attributes get added to the input when it is marked required, or is disabled? - This is extended from the question above, but the attributes are not always present unless the component is in a specific state.

I think I have more to add, but I will need to sit down to have a more comprehensive guide (this is part of the documentation task that I keep failing to commit). I know this is quite overwhelming, especially the accessibility part, but I believe this is a right thing to do. Having a11y in mind now will enables us to have better implementation approaches in the beginning, rather than trying to shift the implementation later as a11y being an after-thought. We don't need to get it right the first time, but just try to take into consideration. Btw, even Material UI can't claim that their components are 100% accessible (see this PR).
Also, I was thinking about opening an issue for each component, so that we can keep the discussion in one place, but it's up to you guys 🙂.
Feel free to send PRs out if you think they are ready, and perhaps /cc me in there for visibility. I will try, but I don't think I can review them in a timely fashion, and I know it is Hacktoberfest, so I don't want to ruin it for you. I'll trust the core maintainers with the decision to merge the changes. I would rather see some movements in the component library rather than leaving it stale.
Looking forwards to your contributions. Stay safe, stay healthy, and happy coding!

There are a lot of component libraries out there for us to use as references, I'm linking some that I find helpful for me when I need to look for component guidelines and a11y best practices:

https://www.carbondesignsystem.com/
https://mui.com/getting-started/usage/
https://spectrum.adobe.com/

One interesting thing I recently found is that there are a lot of governments that have their own design system page, and they are open source ❤ (and tax money well spent!):

https://designsystem.digital.gov/
https://design-system.service.gov.uk/
https://designsystem.gov.au/
https://design.gccollab.ca/

Hey everyone! 👋
I've been working a bit on alert component, and I've just opened a draft PR (#43835). I would really appreciate your feedback!

I have experience building UI component libraries and would like to contribute. Are there any mocks for these components?

I would like to contribute.

Hi everyone,
I am interested in taking part in this effort, I've made a Draft PR for the image component. Any feedback would be greatly appreciated


Make the quotes random without modifying the dom

Lets avoid DOM operations :dancer:
-- and solves https://github.com/src-d/landing/issues/25
It can be achieved assigning higher flex-order to random flex-items

Is this more complex way worth not doing 2 simple DOM operations? If you guys think so then lgtm
On Wed, 14 Jun 2017 at 21:30, David <notifications<EMAIL_ADDRESS>wrote:
@dpordomingohttps://github.com/dpordomingo requested your review on: src-d/landing#26https://github.com/src-d/landing/pull/26 Make the quotes random without modifying the dom.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/src-d/landing/pull/26#event-1123919565, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABQFF8kr1dk4kfH7rY0FGzf7iLIn2pduks5sEDTVgaJpZM4N6VmG.

ping @dpordomingo

I don't like DOM operations when they're not really needed (and can be easily avoided); on the other side, working with flex order is not that tricky...
Anyway, you'd say how to proceed

I think we can close this, since the modification of only adding the first 2 DOM nodes has already been merged.


unsafe password handling

actual plaintext passwords being sent in user management, really unsafe thing to do. Standard way is to salt the passwords and the compare the hashes, not plain text passwords

We can add this feature to the user management module. Open to contributions for this one.

The hashing will be performed on the back end right? Or should the front end send hashed passwords to space cloud directly?

This might be solved by #78

https://stackoverflow.com/questions/3391242/should-i-hash-the-password-before-sending-it-to-the-server-side

@Jayesh333 no, as soon as we take a password from client, we convert it into a key, then hash the key, and preferably transfer it using encrypted connection.

Just hash the password in the client library. Let the server store it as is

Just hash the password in the client library. Let the server store it as is

NEVER DO THIS. The hash effectively becomes the password, and anyone who manages to access the users table will be able to use the hash to log in. With server-side hashing the hacker still needs to know the original password to log in.
Always handle hashing + salting (and really, any security-critical business logic) server side, where you have complete control over the process.

Makes sense. There is no easy way out on this one.

@YourTechBud I think this issue can be closed. It has been solved in #182

Will close it once v0.8.0 is merged in master. Not sure how it should work though! It is fixed, but it isn't live yet

Okay. But now it seems that there is still something to do. I would add a tag "v0.8.0" to this issue and close it.

Done