[Feature request] Hololens anchor sharing

Hi guys,
I'm using 3Dtoolkit version from multi-peer branch to share data between multiple clients. To ensure common view for several hololens users I need to propagate spatial anchors. As I checked there is a stale branch named hololens-sharing with an initial commit from 2 months ago and it looks like it provides some of that functionality.
Are you still working on that issue? Is it already finished on that branch? Sharing of holograms seems like a basic feature for multiple users and would be very useful for our purposes.

Thanks for reaching out @machur - totally agree that anchor sharing is a valuable feature. At this point we don't have built in support for something like that, though it's possible to send arbitrary data using our built in data channels (examples: native client send message, native server process message).
If you have development bandwidth for building something like that out and contributing it back it would be awesome! Unfortunately our core team doesn't have time to build it out ourselves at this point.

I'm going to reshape this issue to a feature request issue so that we can continue the conversation and gauge interest from other folks as well. 🚀

@machur Regarding the hololens-sharing branch, it's not working yet since synchronizing spatial anchor is more complex than I anticipated. The size of the spatial anchor is around 15 - 20MB so we need to split it into several small chunks and send them via data channel (similar to file transfer example). Our top priority now is merging the multi-peer branch to master so I'm not sure when I'll be able to continue the work on that branch.

Can I take this up and merge https://hg.mozilla.org/mozreview/gecko/rev/2eea818fa77951110dd4d792fc620e70f9a064ba#index_header to webrtc to enable it to send arbitrary size message? I should be able to take this up in a week.


Any workaround for changing SNMP Indexes ?

Hello,
We're using Network Weathermap with Observium, we started to monitor some Linux server interfaces, but after server reboot the if indexes of the server changes. And after that i need to set new value of that particular interface.
So. my question would be is there any workaround from Network weathermap perspective ?
Thanks

Does Observium rename its rrd files at that point?
What are you using as a TARGET string in Weathermap?

yes, observium creates new rrd file for that port. For example it was port-14.rrd. After linux reboots it gets port-16.rrd.  And port ID also changes.

You may need to check the index that you are using within Observium.  For example, you may find that ifAlias gives you a changing index but ifName keeps things consistent.

I don't know about Observium but LibreNMS which is Observium open source fork allow to choose this as Port Association Mode on device addition with options ifIndex,ifName,ifDescr or ifAlias.


Add vendor folder logrus to stack skip by default.

Whoops I just realised you attempt to remove the vendor path. Unfortunately doesn't work for some builds. For instance my vendor path is "vendor/..." and not "/vendor/...."


Fix editor callbacks adding registrations every time they're called

Fixes #185

Interesting issue.
There's a problem with using ifdef in this part of the code. It won't support DLL builds.
I don't really know how to workaround this while still retaining your improvements.
Any ideas @jacobdufault?
I recon there's a similar situation (with UNITY_EDITOR ifdef block) in tk.HorizontalGroup.

Ah, this is an interesting problem. fiLateBindings exists because it is not possible to have ifdefs for UNITY_EDITOR inside of non-editor DLLs, as they will get compiled out of DLL based builds.
What about having fiLateBindings register a single EditorApplication.update callback; that callback will just iterate through a list of callbacks that fiLateBindings stores.

I did something similar for my EditorBindings.
It registers itself and iterates over a list to run the callbacks.
I use a class CallbackWithContext that stores a "context" object for the callback. I use this to remove any callbacks that have null contexts.
Note that, in order for this solution to be available to non-editor scritpts, it is not placed in the editor assembly. This is the reason for the #if usage.
Below is the minimal implementation.
#if UNITY_EDITOR

namespace LostAlloy.Modules {
    using System;
    using System.Collections.Generic;
    using UnityEditor;
    using UnityEngine;

    /// <summary>
    ///     Use this class to safely add editor bindings.
    /// </summary>
    [InitializeOnLoad]
    public class LAEditorBindings {
        [SerializeField]
        private static readonly List<CallbackWithContext> _CallbacksWithContext;

        static LAEditorBindings() {
            _CallbacksWithContext = new List<CallbackWithContext>();

            EditorApplication.update -= Update;
            EditorApplication.update += Update;
            Debug.Log("LAEditorBindings initialized.");
        }

        public static void RemUpdateFunc(object context, Action callback) {
            if (context == null) {
                return;
            }

            var c = new CallbackWithContext(context, callback);
            _CallbacksWithContext.RemoveAll(o => Equals(o, c));
        }

        /// <summary>
        ///     No need to check if already added.
        /// </summary>
        /// <param name="context"></param>
        /// <param name="callback"></param>
        public static void AddUpdateFunc(object context, Action callback, bool executeInPlaymode = false) {
            if (context == null) {
                return;
            }

            var c = new CallbackWithContext(context, callback, executeInPlaymode);
            if (_CallbacksWithContext.Contains(c)) {
                return;
            }

            _CallbacksWithContext.Add(c);
        }

        private static void Update() {
            var total = _CallbacksWithContext.Count;

            //loop backwards since we're removing elements from the list
            for (var i = total - 1; i >= 0; i--) {
                var c = _CallbacksWithContext[i];
                if (c.Context != null) {
                    if (!Application.isPlaying || c.ExecuteInPlayMode) {
                        c.Callback();
                    }
                } else {
                    //can't even touch the Context object here, as it will make unity spew errors all over when it was destroyed
                    Debug.Log("LAEditorBindings: removing a null entry from the editor updates callback");
                    _CallbacksWithContext.RemoveAt(i);
                }
            }
        }

        [Serializable]
        private class CallbackWithContext {

            public CallbackWithContext(object context, Action callback, bool executeInPlaymode = false) {
                Context = context;
                Callback = callback;
                ExecuteInPlayMode = executeInPlaymode;
            }

            public object Context { get; }

            public Action Callback { get; }

            public bool ExecuteInPlayMode { get; }

            public override bool Equals(object o) {
                var other = o as CallbackWithContext;
                if (other == null) {
                    return false;
                }

                return (other.Context == Context) && (other.Callback == Callback);
            }

            public override int GetHashCode() {
                //prime number to reduce diagonal collisions
                return Context.GetHashCode() * 7 + Callback.GetHashCode();
            }

            public override string ToString() {
                return GetHashCode().ToString();
            }
        }

    }
}

#endif

I've merged #194 which should address this issue. Thanks for the patches!


Support circles with physical size scaling for spot-based data

User story
for Visium we can make the spots more scalable and the data preparation easier (compared to using mask images) by using a scatterplot layer and provide ways to configure the spots to match the correct physical size
Preferred solution
the tricky part is deciding how to best allow configuration via coordination space and how to implement automatic initialization- perhaps solve along with #830
Possible alternatives

Fixed by https://github.com/vitessce/vitessce/pull/1581


Replacing non-standard "T[0]" -> "T*"

T[0] and T* may be different style,  In assembly code:
char s[0]    ==>  lea   0x04(%rax),   %rdx
char *s       ==>  mov 0x04(%rax),   %rdx


Webpack configuration fixed

Changed webpack version to 2.1.0-beta.22
Changed configuration keys as per the new rules

merged in a later PR #30 , closing


The Impact of MLP Depth

Hello, thanks for your wonderful work. I think it very valuable that good results can be achieved using only a small denoising decoder. I noticed that the training depth provided in the code is 3, and the article also mentions 3, but the checkpoint used for testing employs a deeper MLP. I'm curious about the impact of depth on the training performance of the model. What effects does increasing the MLP depth have on the model's performance during training?

Thanks for your interest! Increasing MLP depth has a very similar effect as increasing MLP width (both increase the number of parameters in the MLP). We use the default setting for all ablations, and use a larger MLP just for comparison with the state-of-the-art. After depth=3 and width=1024, the gain from a larger MLP becomes quite marginal (0.1 or 0.2 FID).

Thanks for your reply


Model accuracy for using SHAP and advice on using folds.

Thanks for the great tool Scott!
Several questions:

How accurate should a model be for me to be confident about using SHAP to explain it? (Especially as I will likely be looking at the effects of the more central features which will likely be more trustworthy in any case.) Is there a particular accuracy metric (accuracy, precision, auc_roc) that should be maximized for best use with SHAP?

I often use multiple folds in my model for cross validation. (I read #337 ) How much difference should there be between SHAP values for features in various folds to make me concerned about validity? (I'm using ~1500 samples with ~150 features right now - but really I'm asking in general.)

In general, do you recommend examining SHAP values across folds of cross validation? (I ask because I notice you don't do this in your notebook examples.)

Great questions!

There is no single number that will tell you if you should trust a model (or hence an explanation of it). But my best advice is to do some kind of sensitivity analysis to see if your model is stable. For example bootstrap resample your training dataset and then retrain and reexplain your models to see what kind of variability you get.
Well, the more difference you see (at a global level) the more you have an unstable model. That model might get stable when you combine all the folds, or it might not. Looking at cross validation variability is really just an alternative to the bootstrapping approach I describe above (and is valid as well, though it may tend to over-estimate the variability of the model).

I do have a suggestion in this post: https://medium.com/@lucasramos_34338/visualizing-variable-importance-using-shap-and-cross-validation-bd5075e9063a


Update UG Screenshots

Fixes #231
Fixes #236

Hmm it's not showing on the UG @jonasgwt

Hmm it's not showing on the UG @jonasgwt

can try open in incognito I think it takes a while

Hmm it's not showing on the UG @jonasgwt

can try open in incognito I think it takes a while

Yup it shows 👍


[BUG] OpenTelemetry exporter is not reporting the Application Version

Library name and version
Azure.Monitor.OpenTelemetry.Exporter 1.0.0-beta.3
Describe the bug
The OpenTelemetry property service.version is not being displayed as "Application Version" (nor by a custom service.version property) in Application Insights while other OpenTelemetry exporters (Console and Jaeger, for example) do report service.version.
Expected behavior
Application Insights should report the service.version property as "Application Version" (or as a custom property).
Actual behavior
"Application Version" is always <empty> in the transaction search filter and "Application Version" doesn't show up when looking at a request's details.
Reproduction Steps
Configure a .NET web application with OpenTelemetry (we're using version 1.1.0). When setting up the ResourceBuilder, ensure that AddService is called with a serviceVersion.
serviceCollection.AddOpenTelemetryTracing(builder =>
{
    builder.SetResourceBuilder(
        ResourceBuilder
            .CreateDefault()
            .AddService("application name here", serviceVersion: "<IP_ADDRESS>")
    );
}

Also ensure that OpenTelemetry.Instrumentation.AspNetCore is configured to capture traces for web requests.
Issue a web request to the application and find it in Application Insights. The "Application Version" property is always <empty> in the transaction search filter and "Application Version" doesn't show up when looking at a request's details.
Environment
The project using the library is a .NET 6 project.
❯ dotnet --info
.NET SDK (reflecting any global.json):
 Version:   6.0.102
 Commit:    02d5242ed7

Runtime Environment:
 OS Name:     Windows
 OS Version:  10.0.19041
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\6.0.102\

Host (useful for support):
  Version: 6.0.2
  Commit:  839cdfb0ec

@baseballbrad3 I am redirecting this to services team to investigate and provide a fix as required.

This is on our backlog. Need to discuss with all languages.


Fixed bug in latest Webkit versions

Now it works on them.
Related with https://github.com/luster-io/prevent-overscroll/issues/4#issuecomment-390108910
See the topic in Webkit issues:
https://bugs.webkit.org/show_bug.cgi?id=182521

Hey, thanks so much!  I haven't looked at this repo in a while, sorry for the delay.  I'll merge and deploy this.

@xcoderzach no idea.


Request for maintainer

I don't use Windows anymore, and use NixOS. If anyone would like to maintain this project, please feel free to leave a comment on this issue. I can provide some help on where to look for Windows APIs, ideas on what to implement that I never got to, and code review in general.

Nevermind, found a better alternative that people might like. I'll just send people there :) https://github.com/obolenski/komorebit


Header too tall in iphone x ?

I seen you same issue but no solution for tall header in iphone x.
Without safearea my application looks weired so i need to add safearea.
can anyone give me workaround to reduce height of header ?

My Header is also to tall in iPhone X using SafeArea:

exactly i am getting same issue

Today i update latest version to ("native-base": "^2.13.12"). it has same issue.

Hi @ansarikhurshid786 , we have fixed this issue in master branch.
same issue as #3095


Contra func

it works but idk what it is LOL

On a quick bench, binrep BLen written like store's Size and getting generics via this generic contra function performs worse by ~25-50%. Much worse on small cases -- unsurprising, lots more wrapping -- not as bad on a slightly larger case. Regardless, this code seems fine.


Frontend draft

Sketch a draft of how a user friendly frontend can look like.
It should be possible to select different modules, module parameters, profile parameters.

In a timeline the effect of changes should get immediately visible. Especially the effect of crisis.

Most important is an analysis view, where the user can compare two scenarios, i.e. different investment strategies and expenses.

won't do


[Event Request] Table 901 Assembly Line OnAfterUnitCost

[IntegrationEvent(false, false)]
local procedure OnAfterUnitCost(var AssemblyLine: Record "Assembly Line"; var UnitCost: Decimal)
begin
end;
procedure GetUnitCost(): Decimal
var
    UnitCost: Decimal;
begin
    GetItemResource;

    case Type of
        Type::Item:
            if GetSKU then
                UnitCost := StockkeepingUnit."Unit Cost" * "Qty. per Unit of Measure"
            else
                UnitCost := Item."Unit Cost" * "Qty. per Unit of Measure";
        Type::Resource:
            UnitCost := Resource."Unit Cost" * "Qty. per Unit of Measure";
    end;

    OnAfterUnitCost(Rec,UnitCost);    //New Event

    exit(RoundUnitAmount(UnitCost));
end;

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


Deploying on AWS Lambda

Hey there! I was wondering if anyone has had success using puppeteer within a serverless environment like AWS Lambda or Google Cloud Functions. I was curious of a few things:

How would downloading Headless Chrome work in a serverless environment?
How long does it roughly take to download and start navigating to a page?

Thanks!

Puppeteer requires Node version 7.10 or greater

... so you can't currently use it on Lambda, which supports Node 6.10.

To run headless Chrome on AWS Lambda this project might be a better match https://github.com/adieuadieu/serverless-chrome/tree/develop/packages/lambda. Uses Node v6 and has builds that does fit on the Lambda file size limits.

Should be possible. You just need to transpile the code to Node 6.10 before deploying to Lambda/Cloud Functions. We're also going to switch Chromeless to use Puppeteer which we hope will ease the Serverless-thing for the community.

@adieuadieu

We're also likely going to switch Chromeless to use Puppeteer which we hope will ease the Serverless-thing for the community.

This seems like the right move. Good to know. And the fonts do not seem to be an issue in Puppeteer from my ad-hoc testing so far. More on that when I'm able to dig in more.

Great guys, thanks for the feedback! Will close this for now until AWS Lambda becomes more awesome.

puppeteer now supports node 6

I'm curious how chrome's dependencies would be handled on Lambda, e.g. X11, fontconfig, etc?

anybody success in deploying to Lambda would like to share?

@deathemperor try this https://github.com/sambaiz/puppeteer-lambda-starter-kit

thanks @bluepeter, after asking the question I was able to find and deploy that repo for my use. It was quite hard at first because I've never deployed any Lambda app before.

Have you taken a look at chomeless? It's purpose built for running on AWS lambda, however it comes at the cost of a different API. The main contributor there has also written a fair deal on the subject. I also have a service that solves the problem of running Chrome in a production environment here.

I tried chromeless but it has an issue when trying to get html content described here https://github.com/graphcool/chromeless/issues/276. Right now I'm OK with puppeteer on Lambda.

@joelgriffith chromeless on Lambda wasn't equitable for us.  it wasn't respecting the --proxy-server flags passed to it and that was a no go.

@deathemperor do you have any hints (or sharable code) on how to get puppeteer running on Lambda?  I'm struggling with the puppeteer-lambda-starter-kit.

sure thing. What issue do you have? I'll try to help as much as I could.

Hi @deathemperor, I'm having similar issue with @jborden13
My requirement is to run chrome in AWS (I knew there is Docker and Heroku option, but I want to know if it possible with AWS) and connect it with puppeteer.connect(). Am I correct way if use the puppeteer-lambda-starter-kit?
Thanks!

Yes puppeteer-lambda-starter-kit is the way to go with. I'm scraping data with it on a daily basis now. It's kind of confusing to get started with at first if you don't know Lambda, and/or puppeteer.
I've forked the repo and make ready-to-deploy changes here https://github.com/deathemperor/puppeteer-lambda-starter-kit if you're interested.

Cool! Thanks @deathemperor

@deathemperor your starter-kit is great stuff - thank you!  Question for you, have you ever run into the tmp directory filling up and throwing an error like:

Error: ENOSPC: no space left on device, mkdtemp '/tmp/puppeteer_dev_profile-XXXXXX'

I've tried clearing the tmp dir out like crazy, but it keeps coming back.

@jborden13 no I have not sorry.

@deathemperor
I'm curious about this. Now that AWS Lambda have doubled the potential memory available to functions, 3008 MB at last count, what's the time taken for Puppeteer to initialize? Speed is important for what I'm trying to achieve.

@tomgallagher the issue isn't memory, it's disk space. The error Error: ENOSPC: no space left on device, mkdtemp '/tmp/puppeteer_dev_profile-XXXXXX' occurs over time because user profile data is not released by the Chrome process. If you have light usage you may not see this error. You can also get rid of the error by forcing Lambda to provision new containers by deploying a new version of your function, even if there are technically no updates to the code. It's a hack, but that works.

Another alternative to Lambda, which is what we are doing at the moment, is to use AWS Batch on Spot instances. These can be very cost effective and don't have the limits that Lambda has.

We have found ways around Lambda space limits... at least we think so. Set all caches to zero, clear cache after use. We did this initially not for disk space issues, but because we didn't want a "polluted" Chrome instance when browsing a new site (i.e., interference w/ a prior user's cookies/cache/etc).

@toddwprice
on Lambda, the memory allocated is also a proxy for computing power, I believe. So more computing power = faster initialization of Puppeteer.

@tomgallagher true, true. I was referring to the out of disk space issue though not the startup time.
@bluepeter do you a reference to the api for managing the caching behavior, or an example? Either would be most appreciated.

ihave used this https://github.com/deathemperor/puppeteer-lambda-starter-kit, but doesn't seems to work on lambda. it freezes at page creation, any ideas how to solve this problem?

@kenorbi I've built this tool which I believe is simpler to use then the other solutions. Give it shot! I've gotten it to work with Lambda.

@sean-hill I'm new to lambda and tried to find a way to package your tool and run code but still fail...
You provide and "usage" example but where you plug that code on your tool structure ?
You have any sample ZIP file that I can see content that can be uploaded to Amazon Lambda and run ?
Thanks !

@pperron — Have a look at this guide by @nadeesha. It walks through how to run puppeteer on Lambda.

@adieuadieu Thanks for the link but still it would help a lot to have a ZIP example of a puppeteer lambdas function, that way we just need to open the ZIP package and see how the thing is done and fine tune it to our need. With your link, I still remain witht the question on how I build that ZIP file so it run on Amazon Lambdas.
Thanks !

Hi all,
Has anyone managed to make puppeteer and chronium work recently?
I have try:
https://github.com/sambaiz/puppeteer-lambda-starter-kit
and
https://github.com/deathemperor/puppeteer-lambda-starter-kit
My final code is:
https://github.com/sambaiz/puppeteer-lambda-starter-kit
Replace index.js:
https://github.com/sambaiz/puppeteer-lambda-starter-kit/blob/master/src/index.js
By:
https://github.com/deathemperor/puppeteer-lambda-starter-kit/blob/master/src/index.js
Also, i'm on windows 7 so to build the package I remove/change a lot of stuff on the package.json for scripts sections.
I have create package with and without babel and lint. Also, I have try with different version of puppeteer and chronium.
I always get this error on aws:
{
"errorMessage": "Failed to launch chrome! spawn /tmp/headless_shell ENOENT\n\n\nTROUBLESHOOTING: https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md\n",
"errorType": "Error",
"stackTrace": [
"",
"",
"TROUBLESHOOTING: https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md",
"",
"onClose (/var/task/node_modules/puppeteer/lib/Launcher.js:299:14)",
"ChildProcess.helper.addEventListener.error (/var/task/node_modules/puppeteer/lib/Launcher.js:290:64)",
"emitOne (events.js:116:13)",
"ChildProcess.emit (events.js:211:7)",
"Process.ChildProcess._handle.onexit (internal/child_process.js:196:12)",
"onErrorNT (internal/child_process.js:372:16)",
"_combinedTickCallback (internal/process/next_tick.js:138:11)",
"process._tickDomainCallback (internal/process/next_tick.js:218:9)"
]
}
Config AWS:
I use "Upload a file from Amazon S3" option because it always finish by time out with the UI and same thing for CLI command.
Runtime: Node.js 8.10
Handler: index.handler
Executable role: lambda_basic_execution. I have also try with a custom role who have full access on lambda and S3 just in case.
TimeOut: 30 sec
Memory: 3008 mb.
If someone can guide me a little bit
thanks

The puppeteer-lambda-starter-kit project use a chrome binary specific for AWS lambda. The puppeteer version should match the chrome version.
@FrankTheCat, maybe the puppeteer version has been updated in your project. The package.lock does not lock the version(https://github.com/sambaiz/puppeteer-lambda-starter-kit/blob/master/package.json#L14).
Try to change to "puppeteer": "1.1.1"

@cirdes
"The puppeteer-lambda-starter-kit project use a chrome binary specific for AWS lambda. The puppeteer version should match the chrome version."
Yep, I have also try one time with: https://github.com/adieuadieu/serverless-chrome/releases
Version: stable-headless-chromium-68.0.3440.106-amazonlinux-2017-03.zip
I make the tar.gz with 7-Zip and tutorial found on stackoverflow and replace the content of headless_shell.tar.gz with the right filename.
Tutorial( not exacly the one I found but ):
https://www.techwalla.com/articles/how-to-create-a-tgz-file-in-windows
"@FrankTheCat, maybe the puppeteer version has been updated in your project. The package.lock does not lock the version(https://github.com/sambaiz/puppeteer-lambda-starter-kit/blob/master/package.json#L14).
Try to change to "puppeteer": "1.1.1"
"
Thanks for the hint but unfortunately same error.
I have try with original index.js and the deathemperor index.js.
If someone want try with my package with puppeteer version 1.1.1:
https://www.dropbox.com/s/diqi8gtvv40ez8i/sambaiz-original-puppeteer-1.1.1.zip?dl=0
https://www.dropbox.com/s/pyurmg3peiw7hya/sambaiz-original-puppeteer-1.1.1-with-index-change.zip?dl=0
Thanks

Thanks to all for your great works :)
I finally managed to deploy the sambaiz package. It use the lasted stable version of chronium( HeadlessChrome/68.0.3440.106 ) and last version of puppeteer ( 1.7.0 ).
https://www.dropbox.com/s/p4t7zod2nf97cwn/sambaiz-puppeteer.zip?dl=0
If you want to build your own package and you are on windows you can:

Download: https://github.com/sambaiz/puppeteer-lambda-starter-kit
Change package.json by mine:

{
  "name": "puppeteer-lambda-starter-kit",
  "version": "1.1.2",
  "description": "Starter Kit for running Headless-Chrome by Puppeteer on AWS Lambda",
  "scripts": {
    "package": "npm run package-prepare",
    "package-prepare": "npm run babel && copy package.json dist && cd dist && npm config set puppeteer_skip_chromium_download true -g && npm install --production",
    "babel": "mkdir dist && \"./node_modules/.bin/babel\" src --out-dir dist",
    "local": "npm run babel && copy node_modules dist && node dist/starter-kit/local.js",
    "package-nochrome": "npm run package-prepare && cd dist && zip -rq ../package.zip ."
  },
  "dependencies": {
    "babel": "^6.23.0",
    "puppeteer": "^1.1.1",
    "tar": "^4.0.1"
  },
  "devDependencies": {
    "aws-sdk": "^2.111.0",
    "babel-cli": "^6.26.0",
    "babel-preset-env": "^1.6.0"
  }
}

Change the version of node in .babelrc to 8.10
npm install babel ( if it's not already install )
npm run package
Copy chrome/headless_shell-67.0.3361.0.tar.gz to dist
Rename dist/headless_shell-67.0.3361.0.tar.gz to headless_shell.tar.gz

Done !

@FrankTheCat
Hello
I try to run your project on aws lambda.
but when I use page.type function in my script it occured error.
"errorMessage":"Protocol error (Input.insertText): 'Input.insertText' wasn't found","errorType":"Error","stackTrace":["Promise (/var/task/node_modules/puppeteer/lib/Connection.js:202:56)","new Promise ()","CDPSession.send (/var/task/node_modules/puppeteer/lib/Connection.js:201:12)","Keyboard.sendCharacter (/var/task/node_modules/puppeteer/lib/Input.js:151:24)","Keyboard.type (/var/task/node_modules/puppeteer/lib/Input.js:166:20)","ElementHandle.type (/var/task/node_modules/puppeteer/lib/ElementHandle.js:173:31)","","process._tickDomainCallback (internal/process/next_tick.js:228:7)"]}
Have you had kind of this error ?
If you have, It could be a lot help.
Thx.

@yunho2141
I don't use page.type on my project. What version of Chromium you use ?
Also after I finally managed to deploy the sambaiz package I found the project have new branch( Puppeteer 1.7.0 ): https://github.com/sambaiz/puppeteer-lambda-starter-kit/tree/puppeteer1.7.0 .
If you use the last version of puppeteer and not the last version of Chromium maybe use the chromium version on puppeteer1,7,0 branch.

@FrankTheCat
Do you only change headless_shell file on puppeteer 1.7.0 branch?
when I run 'npm run package' it over 50MB..
so I'm trying to scale down...
Could you give me help?

@yunho2141
I didn't use the 1.7.0 branch. I only figure out this branch is available after I finally managed to deploy the master branch. Also I manually gzip the last stable version on https://github.com/adieuadieu/serverless-chrome/releases
On the branch 1.7.0 it use probably lastest dev version.
So "Do you only change headless_shell file on puppeteer 1.7.0 branch?":
Once you have make the package ( zip of the content of dist ) it's will be smaller than 50mb. My package are like 43mb, If it's higher maybe you have not exclude babel from dist folder when you create the dist folder or you have 2 time the chromium gzip.
"when I run 'npm run package' it over 50MB.."
Do you use the package.json from the branch or mine ? Which OS you use ?

Hey guys I am using Puppeteer Lambda. Which is good to use chrome in Lambda.
You need to run

CUSTOM_CHROME=true npm install puppeteer-lambda
then set environment :
CUSTOM_CHROME: true
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: true
access key, secret access key

const browser = await puppeteerLambda.getBrowser({ headless: true, slowMo: 100,  args: ['--no-sandbox', '--disable-setuid-sandbox', '--single-process', '--start-fullscreen', '--window-size=1413,749']});

very good helpful package
everything works good...til I have a problem with:
await page.goto(url);
I got stuck with timed out error .. it wont connect to url

I'm facing the same issue. got "Navigation Timeout Exceeded: 30000ms exceeded"

@kenorbi I've built this tool which I believe is simpler to use then the other solutions. Give it shot! I've gotten it to work with Lambda.

@kenorbi Could you explain how to use your cleanup function in an actual puppeteer script? Thanks!

@kenorbi do you have docs on how the deployment should be done?

@aigars-jekabsons
Sharing this here in case it's of use to anyone: https://github.com/alixaxel/chrome-aws-lambda
Currently working on compatibility with the new Node 10 Lambda runtime.

h

I'm facing the same issue. Anyone has already the solution?

Hey guys I am using Puppeteer Lambda. Which is good to use chrome in Lambda.
You need to run

CUSTOM_CHROME=true npm install puppeteer-lambda
then set environment :
CUSTOM_CHROME: true
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: true
access key, secret access key

const browser = await puppeteerLambda.getBrowser({ headless: true, slowMo: 100,  args: ['--no-sandbox', '--disable-setuid-sandbox', '--single-process', '--start-fullscreen', '--window-size=1413,749']});

very good helpful package
everything works good...til I have a problem with:
await page.goto(url);
I got stuck with timed out error .. it wont connect to url

I'm facing the same issue. got "Navigation Timeout Exceeded: 30000ms exceeded"

I'm facing the same issue. Anyone has already the solution?

@alixaxel Experiencing the same issue with chrome-aws-lambda.
node 8

@kjr247 Which issue exactly? This thread is long and not specifically related to my project.
Perhaps it would be better if you open an issue on https://github.com/alixaxel/chrome-aws-lambda.


Drop support for Python 3.6, test against pip==22.0.x

Fixes #123, #124, #125.

Pip has dropped support for 3.6 in 22.0: https://pip.pypa.io/en/stable/news/#v22-0

Awesome! Good riddance, and that's an excuse to plow ahead on pip-audit as well 🙂


Support Timepoint, Duration

What
Resolves #724

Implement {Timepoint, Duration} <-> u64 conversions
A drive-by clean up for get_current_call_stack to return Address
Clean up some trailing whitespaces in env.json

Why
[TODO: Why this change is being made. Include any context required to understand the why.]
Known limitations
[TODO or N/A]

What's the win out of having these two disjoint types when they're just u64 values?
I think I missed the conversation when we added them.

What's the win out of having these two disjoint types when they're just u64 values?
I think I missed the conversation when we added them.

They are special case u64 subtypes that can have different semantics and operations. They can represent for example ledger timestamp and can specify its own display format (instead of a plain u64).  Similar to how String, Symbol are related to Bytes.
For now we just support them by converting them to and from u64, which is the bare minimum so that the guest can implement the semantics in ways they want. We might enrich them post V1.


publish OpenSearch RestHighLevelClient

Is your feature request related to a problem? Please describe.
there is currently no official OpenSearch java client - the docs even explicitly say that you have to use the Elasticsearch 7.10.2 client. that in turn is an old client version and will cease to receive support (& security updates) at some point (2022-05-11 at the latest, according to the published elastic EOL dates).
newer versions of the elasticsearch library may or may not work with OpenSearch (they seem to have started to introduce version/license checks in newer versions) and newer versions have been re-licensed to the Elastic License 2.0.
Describe the solution you'd like
OpenSearch already contains the RestHighLevelClient code.
please publish it as a library to maven central & co., just as was/is done by elastic for the elasticsearch version of the library.
Describe alternatives you've considered
using the elasticsearch library is only a short-term solution, mid-term it's not an option due to lack of security updates & co. and long-term it won't be an option because the OpenSearch and elasticsearch APIs will have diverged.
elastic will also start moving to a new API at some point in the future: elastic/elasticsearch-java. but this is not yet available and, while it'll be under the Apache 2.0 license again, it will probably also have the license/version checks in place. since it is not yet published there are no existing consumers of it. providing an OpenSearch version of RestHighLevelClient allows existing consumers to switch over to OpenSearch by simply replacing the package they're importing (at least when migrating from the ES 7.10.2 version to the OpenSearch 1.x version).
Additional context

OpenSearch docs for RestHighLevelClient
RestHighLevelClient in OpenSearch code base
this is also required for a proper support in spring-data-elasticsearch: spring-projects/spring-data-elasticsearch#1880
forum discussions:

Elastic Java clients are no longer open source
OpenSearch Client Java & Python APIs
Support for High Level Rest Client

PS: i've now raised this in the OpenSearch repo since this is where the client code exists, but maybe this needs to be moved to opensearch-build because it's about the publishing aspect? feel free to move it if that'd be a better place for it.

Seems we have at least some snapshots: https://aws.oss.sonatype.org/content/repositories/snapshots/org/opensearch/client/opensearch-rest-high-level-client/1.0.0-SNAPSHOT/

Thanks for opening up the issue. As @frotsch said, the team is working on it.
Have you tried building the clients from the source? Until Maven is ready.
@mch2 / @peterzhuamazon are snapshot maven repositories ready for consumption ?

thanks for looking into this!
no, i haven't tried building it from source. for now we're just using spring-data-elasticsearch:4.1 which is using an Apache 2.0 licensed ES dependency. building it manually doesn't make much sense for us since we're using it through another dependency and don't want to have our own internal fork of spring-data-elasticsearch.

@mch2  is OpenSearch RestHighLevelClient  already available in Maven and how do we use it?


validate output of feats.py with the one for ShowFeats.py using a 3D conformer

then create a regression test with the validated output

ok for caffeine


Improve from Binary/Json/Partial performance by roughly 30%

As mentioned in https://github.com/timostamm/protobuf-ts/issues/306#issuecomment-1711935782 there is a non-trivial performance hit for using Object.defineProperty(). Searching around you can find plenty of other mentions of this.
Originally my plan was to create a MessageInstance class property on the base MessageType class and then call const message = new this.MessageInstance() inside the create() method. Unfortunately jasmine seems consider two object to NOT be deeply equal to each other when one was created via new this.MessageInstance() vs. an object literal with the exact same structure. However, if instead we utilize Object.create() and pass in our prototype as the first argument (which should effectively be the same thing) then jasmine will consider the two objects deeply equal 🤷.
This change adds an optional messagePrototype property to the IMessageType interface (I'm hoping this isn't considered a backwards incompatible change). This messagePrototype is created inside the MessageType constructor and is stamped with the non-enumerable MESSAGE_TYPE symbol pointing back to this. Performing the stamping here means that we only are penalized for the Object.defineProperty() once per message "class" instead of once per message "instance".
I believe this change should be backwards compatible. Any old generated code should continue to work with the new runtime version, but newly generated code (only when optimized for speed) will not work with old runtime versions (optimized for size code will continue to work since it would go through reflectCreate() instead of generated code).
The below benchmarks were run with nodejs v20.6.1 (latest as of time of writing). According to these protobuf-ts (speed, bigint) will now read binary messages ~20% faster than protobufjs.
 It's a fairly small change with a big speed improvement. Thank you for your time! 🙏

Released in v2.9.2.

Hi,
Is there a way to generate the code in the old way? I mean to generate the objects (create/ function) using:
Object.defineProperty({}, MESSAGE_TYPE, {value: type});
?
Our code base relies on plain objects. Due to the changes, the outcoming objects from the generated code are no longer plain.
We would love to still keep up to date with the updates but right now we are forced to use the old version of the library (2.9.1).

@jcready, we're using the prototype to avoid Object.defineProperty's perf penalty, while still keeping the property non-enumerable - correct?
@Berd74, I assume the object isn't considered to be plain because of its prototype? You could write a function that strips a message (and all messages it contains in properties) of its prototype. Can you give this a try?

@Berd74, I assume the object isn't considered to be plain because of its prototype? You could write a function that strips a message (and all messages it contains in properties) of its prototype. Can you give this a try?

This is our solution right now. After receiving objects from protobuf-ts (in our project: after using services like fetch requests, packets from webSocket, or packets from WebRTC data channels) we use a function that deeply checks if the object prototype has symbol MESSAGE_TYPE. If the object meets the condition we convert it back to the objects from version v2.9.1.
before transform:

after transform:

The solution is not perfect but it works. We hope in the future we will be able to get rid of this transformation.
@jcready I looked at the issue mentioned in #618 and I can confirm that we are having the same problem. We also use mobx.

I don't believe the issue is related to having this other non-enumerable property on the prototype, just that things like constructor or toString() don't appear as "own properties" of the first prototype in the object's prototype chain or don't match Object.

You're right. Thanks for digging up the details.
I'm afraid that anything but a plain object (only own properties, no cyclic references, only JSON serializable types) will cause an issue in one framework or the other. At the same time, Protobuf messages ideally have the schema information attached to the object, so all necessary information for serialization and reflection is in one place. It can be a bit frustrating that it‘s extremely rare to see a framework provide hooks so that behavior can be adjusted to the domain models.
https://github.com/timostamm/protobuf-ts/pull/618 isn't going to solve this issue completely, but it does look like an improvement.

https://github.com/timostamm/protobuf-ts/pull/618 was released in v2.9.4. @Berd74, this should work for you as well.


Getting driver: bad connection or cached plan must not change result type (SQLSTATE 0A000) or failed to look up field with name: some_field

GORM Playground Link
https://github.com/go-gorm/playground/pull/96
Description
I'm getting funny bugs in Gorm v2 when trying to apply some migrations in a fresh database, I've copied all the related files from my project.
with my full code base I get driver: bad connection, with this minimal example I  get cached plan must not change result type (SQLSTATE 0A000) and if I uncomment the code in  pkg/model/v43/migration/v1/migration.go I get failed to look up field with name: otros_cargos
this behavior may be related to the following reports:

https://github.com/go-gorm/gorm/issues/2547
https://github.com/go-gorm/gorm/issues/1578 (not even the same database product, but anyway)

I'm seeing also bugs on my CI (at Gitlab) that I thought were fixed:
2020/08/30 07:48:05 /builds/kuecr/fero/backend/monolith/pkg/model/v42/migration/v11/migration.go:7
[0.208ms] [rows:0] select * from "t_grupo"
2020/08/30 07:48:05 /builds/kuecr/fero/backend/monolith/pkg/model/v42/migration/v11/migration.go:7 pq: syntax error at or near "NOT"
[0.671ms] [rows:0] ALTER TABLE "t_grupo" ALTER COLUMN "correo_electronico" TYPE varchar(60) NOT NULL

https://github.com/shackra/playground/blob/2db869382c475b45ae849cf96cfb39f00510cfd1/pkg/model/v42/migration/v11/models.go#L72 is the exact same code as mine in my project but this issue is not triggered in your gorm playground :man_shrugging:

Hello，could you try to initalize the postgres db with PreferSimpleProtocol，check if the issue will be fixed？
refer https://github.com/go-gorm/postgres
Thank you

Hello，could you try to initalize the postgres db with PreferSimpleProtocol，check if the issue will be fixed？
refer https://github.com/go-gorm/postgres
Thank you

Hi!
I did that in this commit https://github.com/go-gorm/playground/pull/96/commits/48b69f5981bf62e3ff543197e71d86529c4810d2 which allows the real bug to show itself: failed to look up field with name:

my playground fork is fully debugged but I can still reproduce a bug in my project's source code running in golang:1.14-alpine :(
monolith_1   | 2020-08-30T10:23:59.663010247Z 2020/08/30 04:23:59 /app/monolith/pkg/model/migrator/migrator.go:32
monolith_1   | 2020-08-30T10:23:59.663012227Z [0.096ms] [rows:0] SELECT * FROM "t_migration" WHERE id = '14-prepara la base de datos para comprobantes electrónicos 4.3'
monolith_1   | 2020-08-30T10:23:59.663633055Z
monolith_1   | 2020-08-30T10:23:59.663637215Z 2020/08/30 04:23:59 /go/pkg/mod/gorm.io/driver/postgres@v1.0.0/migrator.go:108
monolith_1   | 2020-08-30T10:23:59.663641985Z [0.473ms] [rows:0] SELECT count(*) FROM information_schema.tables WHERE table_schema =  CURRENT_SCHEMA() AND table_name = 't_otros_cargos' AND table_type = 'BASE TABLE'
monolith_1   | 2020-08-30T10:23:59.692439848Z
monolith_1   | 2020-08-30T10:23:59.692446537Z 2020/08/30 04:23:59 /app/monolith/pkg/model/v43/migration/v1/migration.go:12
monolith_1   | 2020-08-30T10:23:59.692449077Z [28.686ms] [rows:0] CREATE TABLE "t_otros_cargos" ("id" bigserial,"created_at" timestamptz,"updated_at" timestamptz,"deleted_at" timestamptz,"tipo_documento" bigint,"detalle" text,"porcentaje" text,"monto_cargo" text,"documento_id" bigint,PRIMARY KEY ("id"))
monolith_1   | 2020-08-30T10:23:59.697431029Z
monolith_1   | 2020-08-30T10:23:59.697439089Z 2020/08/30 04:23:59 /go/pkg/mod/gorm.io/driver/postgres@v1.0.0/migrator.go:79
monolith_1   | 2020-08-30T10:23:59.697441399Z [4.960ms] [rows:0] CREATE INDEX "idx_t_otros_cargos_deleted_at" ON "t_otros_cargos" ("deleted_at")
monolith_1   | 2020-08-30T10:23:59.698039067Z
monolith_1   | 2020-08-30T10:23:59.698044647Z 2020/08/30 04:23:59 /go/pkg/mod/gorm.io/driver/postgres@v1.0.0/migrator.go:108
monolith_1   | 2020-08-30T10:23:59.698046897Z [0.528ms] [rows:0] SELECT count(*) FROM information_schema.tables WHERE table_schema =  CURRENT_SCHEMA() AND table_name = 't_documento' AND table_type = 'BASE TABLE'
monolith_1   | 2020-08-30T10:23:59.701196835Z
monolith_1   | 2020-08-30T10:23:59.701200705Z 2020/08/30 04:23:59 /app/monolith/pkg/model/v43/migration/v1/migration.go:15
monolith_1   | 2020-08-30T10:23:59.701202755Z [3.108ms] [rows:0] select * from "t_documento"
monolith_1   | 2020-08-30T10:23:59.701248025Z
monolith_1   | 2020-08-30T10:23:59.701251375Z 2020/08/30 04:23:59 /app/monolith/pkg/model/v43/migration/v1/migration.go:15 driver: bad connection
monolith_1   | 2020-08-30T10:23:59.701253415Z [0.003ms] [rows:0] ALTER TABLE "t_documento" ADD "resumen_total_serv_exonerado" text

my playground fork is fully debugged but I can still reproduce a bug in my project's source code running in golang:1.14-alpine :(

Maybe you are not using the latest postgres driver?

Seems tests pass right now, the driver: bad connection doesn't seems GORM issue, try to upgrade the postgres driver to check if this issue will be fixed.

my playground fork is fully debugged but I can still reproduce a bug in my project's source code running in golang:1.14-alpine :(

Maybe you are not using the latest postgres driver?

is that provided by the host operating system which in turn is a implicit dependency for any Go driver package for postgres?
How do I figure which version is the playground running?

playground using postgres:latest https://github.com/go-gorm/playground/blob/master/.github/workflows/tests.yml#L85
GORM tests using https://github.com/go-gorm/gorm/blob/master/.github/workflows/tests.yml#L110

for Debian buster (used as base for postgres:12.4, posgres:12, and postgres:latest) odbc-postgresql is version 1:11.00.0000-1, while in Alpine 3.12 (use for golang:1.14-alpine) is version 09.06.0410-r1 (built on 2018-11-07), thus is correct to say that this is the culprit?

so it only fail on v09.06.0410-r1?

so it only fail on v09.06.0410-r1?

so far, it does, yes


sgx-sdk, sgx-psw: 2.14 -> 2.15.1

Motivation for this change
Also add some of the new samples as tests. Disable parallel builds for
the samples as they don't seem to support it (fail randomly).
~Still a draft. Waiting for #148593.~
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[ ] Fits CONTRIBUTING.md.

Rebased, as https://github.com/NixOS/nixpkgs/pull/148593 is merged. I didn't test the AESM service on an SGX machine yet.

I didn't test the AESM service on an SGX machine yet.

Works fine!

@veehaitch The AESM daemon runs fine. sgx-detect is happy after manually linking /dev/sgx_enclave to /dev/sgx/enclave. Weird. Not sure why the device node changed, but this is unrelated to the SGX userspace code.
Good to merge from my end.


Issue templates for the repo using new github issue forms

Resolves #18
This PR adds issue templates using new interactive github issue forms feature for following tasks:

bug reporting
documentation issues
feature suggestions

Better ease of use for issue reporting with interactive form.

Hey @avats-dev, we have few more changes required. For example you can ask for the library version, php version and code of conduct on all the templates. We have a first approved PR please take that as reference
https://github.com/utopia-php/framework/pull/28

@lohanidamodar I have updated the PR with suitable changes as requested in suggestions. Please review it and LMK if something is missing. Happy to contribute! 🎉


Delete a cluster if it encounters error when starting

Delete a cluster if it is not started due to port conflicts or any other unforseen error
Signed-off-by: Rishabh Gupta<EMAIL_ADDRESS>

Fixes issue #31


check all errors in tests

Closes: #5060
Brief Changelog
This PR resolves ineffectual assignments to error in tests ONLY.
it is made by make lint and then fixing ineffectual assignment
to err
Testing and Verifying
This change requires a review because two flows surfaced errors where I did not
expect them.
Documentation and Release Note

Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
How is the feature or change documented? (not applicable   /   specification (x/<module>/spec/)  /  Osmosis docs repo   /   not documented)

@niccoloraspa I'd like to call your attention to this one, I think it may have exposed a bug:  in the expected to pass section, we've got an error with an error in it

you are correct, and thank you very much!


Added Two Convenience Functions to Return Version Data

Added two convenience functions to return the item and collection versions.  Also added tests, server responses and docs.
You might want to view the docs to make sure I got the formatting right.
Yes, my spelling in the branch name and commit message is atrocious.

Ohh and in the future should I make pull requests to dev or master.  Wasn't really sure what dev was being used for.

Coverage increased (+0.9%) to 41.875% when pulling 8241fac6514d10790cdaad5e6237160d291fa4a6 on TruePath:add_verion_functions into 5797cfba9c50ac3c6f1dcd49a4841ce2bdd831c5 on urschrei:master.

Coverage increased (+0.9%) to 41.875% when pulling 8241fac6514d10790cdaad5e6237160d291fa4a6 on TruePath:add_verion_functions into 5797cfba9c50ac3c6f1dcd49a4841ce2bdd831c5 on urschrei:master.

Coverage increased (+0.9%) to 41.875% when pulling 8241fac6514d10790cdaad5e6237160d291fa4a6 on TruePath:add_verion_functions into 5797cfba9c50ac3c6f1dcd49a4841ce2bdd831c5 on urschrei:master.

Made one other minor (non-functional) change.  Since the deleted API doesn't respect the limit param it is best not to send it by default.

Coverage increased (+0.8%) to 41.745% when pulling 1927ef4b8f8e4a5db8201e02ec8c3eaa319318a3 on TruePath:add_verion_functions into 5797cfba9c50ac3c6f1dcd49a4841ce2bdd831c5 on urschrei:master.

PRs should be made against dev (as per CONTRIBUTING.md), but it doesn't matter, since they're currently equal anyway. I'll build the docs and make sure they're rendering OK…

Coverage increased (+0.8%) to 41.745% when pulling 5c03e0922132f0e41b32f156c465c16d5f7aadb9 on TruePath:add_verion_functions into 5797cfba9c50ac3c6f1dcd49a4841ce2bdd831c5 on urschrei:master.


No MediaQuery widget ancestor found

Stack trace:
======== Exception caught by widgets library =======================================================
The following assertion was thrown building SafeArea(avoid left padding, avoid top padding, avoid right padding, avoid bottom padding, dirty):
No MediaQuery widget ancestor found.

SafeArea widgets require a MediaQuery widget ancestor.
The specific widget that could not find a MediaQuery ancestor was: SafeArea
  avoid left padding
  avoid top padding
  avoid right padding
  avoid bottom padding
  dirty
The ownership chain for the affected widget is: "SafeArea ← StatusBarManager ← MyApp ← [root]"

No MediaQuery ancestor could be found starting from the context that was passed to MediaQuery.of(). This can happen because you have not added a WidgetsApp, CupertinoApp, or MaterialApp widget (those widgets introduce a MediaQuery), or it can happen if the context you use comes from a widget above those widgets.

The relevant error-causing widget was:
  SafeArea file:///Users/groov/development/flutter/.pub-cache/hosted/pub.dartlang.org/statusbarmanager-0.0.1/lib/statusbarmanager.dart:44:44
When the exception was thrown, this was the stack:
#0      debugCheckHasMediaQuery.<anonymous closure> (package:flutter/src/widgets/debug.dart:219:7)
#1      debugCheckHasMediaQuery (package:flutter/src/widgets/debug.dart:234:4)
#2      SafeArea.build (package:flutter/src/widgets/safe_area.dart:97:12)
#3      StatelessElement.build (package:flutter/src/widgets/framework.dart:4648:28)
#4      ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4574:15)
...
====================================================================================================

======== Exception caught by widgets library =======================================================
The following assertion was thrown building SafeArea(avoid left padding, avoid top padding, avoid right padding, avoid bottom padding, dirty):
No MediaQuery widget ancestor found.

SafeArea widgets require a MediaQuery widget ancestor.
The specific widget that could not find a MediaQuery ancestor was: SafeArea
  avoid left padding
  avoid top padding
  avoid right padding
  avoid bottom padding
  dirty
The ownership chain for the affected widget is: "SafeArea ← StatusBarManager ← MyApp ← [root]"

No MediaQuery ancestor could be found starting from the context that was passed to MediaQuery.of(). This can happen because you have not added a WidgetsApp, CupertinoApp, or MaterialApp widget (those widgets introduce a MediaQuery), or it can happen if the context you use comes from a widget above those widgets.

The relevant error-causing widget was:
  StatusBarManager file:///Volumes/Ext_Storage/Development/flutter_projects/experiments/statusbar_manager/lib/main.dart:14:12
When the exception was thrown, this was the stack:
#0      debugCheckHasMediaQuery.<anonymous closure> (package:flutter/src/widgets/debug.dart:219:7)
#1      debugCheckHasMediaQuery (package:flutter/src/widgets/debug.dart:234:4)
#2      SafeArea.build (package:flutter/src/widgets/safe_area.dart:97:12)
#3      StatelessElement.build (package:flutter/src/widgets/framework.dart:4648:28)
#4      ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4574:15)
...
====================================================================================================

Reproducible example:
import 'package:flutter/material.dart';
import 'package:statusbarmanager/statusbarmanager.dart';

void main() {
  runApp(
    MyApp(),
  );
}

class MyApp extends StatelessWidget {
  // This widget is the root of your application.
  @override
  Widget build(BuildContext context) {
    return StatusBarManager(
      translucent: false,
      child: MaterialApp(
        title: 'Flutter Demo',
        theme: ThemeData(
          // This is the theme of your application.
          //
          // Try running your application with "flutter run". You'll see the
          // application has a blue toolbar. Then, without quitting the app, try
          // changing the primarySwatch below to Colors.green and then invoke
          // "hot reload" (press "r" in the console where you ran "flutter run",
          // or simply save your changes to "hot reload" in a Flutter IDE).
          // Notice that the counter didn't reset back to zero; the application
          // is not restarted.
          primarySwatch: Colors.blue,
        ),
        home: MyHomePage(title: 'Flutter Demo Home Page'),
      ),
    );
  }
}

class MyHomePage extends StatefulWidget {
  MyHomePage({Key? key, required this.title}) : super(key: key);

  // This widget is the home page of your application. It is stateful, meaning
  // that it has a State object (defined below) that contains fields that affect
  // how it looks.

  // This class is the configuration for the state. It holds the values (in this
  // case the title) provided by the parent (in this case the App widget) and
  // used by the build method of the State. Fields in a Widget subclass are
  // always marked "final".

  final String title;

  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {
      // This call to setState tells the Flutter framework that something has
      // changed in this State, which causes it to rerun the build method below
      // so that the display can reflect the updated values. If we changed
      // _counter without calling setState(), then the build method would not be
      // called again, and so nothing would appear to happen.
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    // This method is rerun every time setState is called, for instance as done
    // by the _incrementCounter method above.
    //
    // The Flutter framework has been optimized to make rerunning build methods
    // fast, so that you can just rebuild anything that needs updating rather
    // than having to individually change instances of widgets.
    return Scaffold(
      appBar: AppBar(
        // Here we take the value from the MyHomePage object that was created by
        // the App.build method, and use it to set our appbar title.
        title: Text(widget.title),
      ),
      body: Center(
        // Center is a layout widget. It takes a single child and positions it
        // in the middle of the parent.
        child: Column(
          // Column is also a layout widget. It takes a list of children and
          // arranges them vertically. By default, it sizes itself to fit its
          // children horizontally, and tries to be as tall as its parent.
          //
          // Invoke "debug painting" (press "p" in the console, choose the
          // "Toggle Debug Paint" action from the Flutter Inspector in Android
          // Studio, or the "Toggle Debug Paint" command in Visual Studio Code)
          // to see the wireframe for each widget.
          //
          // Column has various properties to control how it sizes itself and
          // how it positions its children. Here we use mainAxisAlignment to
          // center the children vertically; the main axis here is the vertical
          // axis because Columns are vertical (the cross axis would be
          // horizontal).
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            Text(
              'You have pushed the button this many times:',
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.headline4,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton(
        onPressed: _incrementCounter,
        tooltip: 'Increment',
        child: Icon(Icons.add),
      ), // This trailing comma makes auto-formatting nicer for build methods.
    );
  }
}

same issue


Document exceptions

MS SDKs typically document which exceptions are thrown.
This is crucial information. We cannot properly handle our error paths without knowing what is going wrong (and catching an Exception tells us nothing).
Many EF Core methods lack complete documentation, because they do not mention exceptions thrown. MSDN was good at this, but the new docs site seems incomplete.
These are the worst culprits:
DbContext.SaveChanges
DbContext.SaveChangesAsync

We cannot rely on the source, because that can change at any time. You need to officially document this.
It's not hard, PLEASE consider this a priority.
(In the meantime, please at least let us know about those two methods.)

Note to self - look for custom exception types that we have defined


KYLIN-2960, modify the default LDAP admin group config.

Can one of the admins verify this patch?

merged


Possible need for a new release that doesn't depend on certain changed rubocop internals

https://github.com/bbatsov/rubocop/pull/3863 and some other recent refactors might break some of our integration

This breaks https://github.com/backus/rubocop-rspec/blob/f8e832d1935167619f405d37b02530d792b9be5f/lib/rubocop/cop/rspec/named_subject.rb#L63

#281 closes this issue, right?

Ah correct thanks @mikegee


Review

Still writing things down, this post will be edited/extended!
This is gonna be a long post, not sure about the right format.
Thanks for taking the time to put together an proposal! SF is essential, although like most OGC standards, falls into the rabbit hole of prescriptive standards on top of a descriptive one. The latter is way more developer friendly and is what were doing here now. Therefore I would like to extend and dare I say improve the SF in this package, much like PostGIS has done, for usability. A nice implementation is also over at R.
Functions
I would like to add at least all the functions defined on the abstract geometry type, per SF, although we can play with the names.

dimension() : Integer
coordinateDimension() : Integer
spatialDimension() : Integer
geometry Type() : String
SRID() : Integer
envelope() : Geometry
asText() : String
asBinary () : Binary
isEmpty () : Boolean
isSimple() : Boolean
is3D() : Boolean
isMeasured() : Boolean
boundary () : Geometry

Not all of them need to be implemented, but fixing the spatial reference and an easy implementation for the bounding box seem essential to me. Speaking of functions that could use some actual algorithm, where will those be? The whole suite of DE-9IM functions? Pure Julia, or GEOS? Can you choose a backing engine (like a CPU/GPU switch?). Do we provide an area function (defined in SF for Polygons) or length. Where do these implementations belong?
Types

As seen above, there are a lot more types than we now have defined. There are also intermediate types (Curve) or subtypes (Triangle). On top of this, the ISO SQL MM standard extends this, partly implemented and extended by PostGIS.
IO
Parsing WKT/WKB could be in another package that also implements this Interface? Same goes for GeoJSON and many other formats. We probably don't need a function for this.

Thanks for sharing your thought. Took me a while to get to this..
Functions
Regarding the list of functions you give, I think we should look carefully to see where it makes sense to follow SF, and where not. Some of them are already in there (dimension, coordinateDimension, spatialDimension, geometryType).
asText and asBinary are in there as wellknowntext and wellknownbinary, but I'm not 100% sure if they should stay to be honest. It would mean having to implement 'blessed' WKT/WKB types in this package. It seems preferable to have them as a concrete implementation that implement the interface.
isMeasured: I never come across m coordinates. Are they used much, and should we support them? Not having that would make is3D unneeded as well, since we can just check the number of dimensions.
isEmpty is covered by ngeom(g) == 0, though we could decide to add a Base.isempty fallback like that in this package.
For SRID, I'm not sure I want to include that at this point, for fear of not finishing the interface. Shall we put it on hold and think this through properly later, also how it would relate to GeoFormatTypes.jl?
isSimple, boundary and envelope are in a sense already spatial operations, and I'm not sure we should go there, because we'd be asking each library that conforms to the interface to implement it. I agree envelope (bounding box) may be appealing to have though, and we could make it optional and have a fallback here.

Speaking of functions that could use some actual algorithm, where will those be? The whole suite of DE-9IM functions? Pure Julia, or GEOS? Can you choose a backing engine (like a CPU/GPU switch?). Do we provide an area function (defined in SF for Polygons) or length. Where do these implementations belong?

I would consider these spatial operations, that don't make sense to implement seperately for each set of geometries. The interface will support converting geometries easily to LibGEOS.jl or GeometryBasics.jl, where DE-9IM implementations could reside.
Types
Good point, there are a lot more types in SF than we have right now. We have the GeoJSON subset. In my experience these are the most common and I have the most experience with them. We can always add more types to the interface, that will be easier than removing types. Also some may become covered by the issue you linked, https://github.com/JuliaGeometry/GeometryBasics.jl/issues/15. Or are there some of those that you consider important to add now?
IO

Parsing WKT/WKB could be in another package that also implements this Interface? Same goes for GeoJSON and many other formats. We probably don't need a function for this.

Ah yes, then it seems we agree. I think we should remove wellknowntext(geom) and wellknownbinary(geom) from the interface.

Some quick thoughts.
This spec doesn't have to implemented fully by other packages. Fallback options here would also include "not implemented" or even "ignored from spec".
In this way we can still include isMeasured. Its not often used, but a useful concept related to tables. Like a PointCloud, which is a feature, with geometry MultiPoint. Apart from the Z dimension, it can have a time dimension, which would be the M here. Ofcourse, there can be many Ms, so the only thing we need is a labeling system (like columnnames).
isEmpty is easy to implement and part of the spec, so lets include it.
SRID is essential for this spec in my opinion, could just be <:CoordinateReferenceSystemFormat from https://github.com/JuliaGeo/GeoFormatTypes.jl.
I understand your hesitation about functions and agree with them. However, can we just list these methods here and ask them to be implemented? In the "not implemented" error, we can even point them to say, LibGEOS. Same goes for WKT & WKB, and I agree they shouldn't be implemented here.
With regard to types, these are the simplest existing things to put into the spec. It's an ISO standard. So let's put them all in, including the the SQL-MM Part 3 ones (http://postgis.net/docs/using_postgis_dbmanagement.html#SQL_MM_Part3). With regards to GeometryBasics, I'd very much like them to implement this spec on top of their meshes. In that way I can easily convert, say a TIN or PolyhedralSurface to simple Polygons that will work in LibGEOS or GeoJSON.
Lastly, I really like to add a type for a boundingbox. I've done multiple for different packages now and they can't work together. PostGIS has done a similar thing: https://postgis.net/docs/Box2D.html. I can come up with a proposal?

I think it is better to start small, and expand from there, rather than trying to nail everything at once.
Regarding optional functions, I think in other interfaces such as Tables.jl some functions may be optional, but only in the sense that an interface fallback exists, that may be slower.
We could go for a pragmatic SRID, but may regret it later. If we add it now, it would need a good proposal.
Maybe you need to explain M to me sometime. Currently there is no way to label dimensions, but N dimensional points are supported. I guess in practice most will assume the first 2/3 to mean x, y(, z). So I'm also hesitant to throw it in there without a good proposal, showing how we can solve this in a general way.
You are right that we can easily add more geometry types. But they need to come together with the essential methods just like the other types, and at this point I'm not sure what they should be. I feel more confident setting this up for types that have 3 or more implementations. Writing the interface for types we don't have any of, may be a bit challenging and getting ahead of things at this point.
Would be great if you can come up with a proposal for adding a bounding box. I guess the simplest would be two points, one at the minimum of each dimension, and one at the maximum of each dimension?

Closed by #5


Training Problems

when i train by my own data , i meet this problem, i don't know how can i solve this problem,the problem as fellows:
/dataset.py", line 97, in getitem
buf.write(imgbuf)
TypeError: a bytes-like object is required, not 'NoneType'

i have fix this problem

i have fix this problem


Feature suggestion: implicitly convert stderr to a String

Hello,
In MergeError::ExternalToolError, stderr contain the error logs of the external tool. However, currently it's a Vec<u8>. For cases when there is an error it would be much more helpful for debugging to directly return the error as a string, using String::from_utf8.
Does this sound interesting to you? I can create a PR unless you want to work on it.
Thanks!

Hello, thanks for the suggestion, I think that's a good ergonomics improvement
I whipped up a branch quickly, let me know if that matches what you expected. I'm using from_utf8_lossy to avoid the failable case, but in practice this is for display, I don't think anyone will reasonably want to parse non-utf8 data from stdout/stderr
It's an API break, so requires a 2.0, but that's fine.

Thanks for the effort, I just reviewed your PR.


portfolio project pull request

it's build with html and css using the css the project focus on how to use flex

i will add every optional in the next project

i will add every optional in the next project

@kirube1992 Alright

merge


MODOAIPMH-142 Add new tenant, user and password to properties file

PURPOSE
For integration tests we need new tenant, user and password insert into ephemeral.properties file
LINKS
https://issues.folio.org/browse/MODOAIPMH-142

Have you discussed with the devops guys?  The hosted reference envs already get provisioned with a diku institutional user (not to be confused with diku_admin).  This user only has the permissions required for the edge APIs to call to their related modules.  I believe this is setup by the folio-ansible scripts.  You might be able to use that instead of creating another user.

This is needed for new integration tests using karate.
They create new tenant/user, run tests then delete that tenant. But for that we need a new record for the new tenant in ephemeral properties.
In the first iteration, these tests are to be run against local vagrant box with the Folio platform.


Allow 'zdns -h' to work even without a lookup module

This is a mild hack. What it does is it adds flag parsing on the failure
path when no valid module is found. The flag parsing will find the "-h"
and print the default usage, terminating the program before hitting
the log.Fatal(). If no -h is supplied it falls through the flag parse
and hits the log.Fatal() as it did previously.

Thank you for your contribution!


Offset for all 'root' methods

Right now the only way to get to the batch with N offset in /accounts, /blocks, /messages and /transactions is to first load the N previous entities and get the last last_tx_lt, seq_no, created_lt and created_lt respectively, which heavilty restricts pagination and browsing overall
Would be good to add an offset field into all of those methods

We've decided not to implement this feature because a user-provided offset can be potentially very heavy for some Postgres queries.


spec: typeparams: method calls do not implicitly dereference pointer-to-TypeParams

This test program exercises whether implicit dereference of pointer-to-type-parameter is allowed in a method call: https://go2goplay.golang.org/p/0C-j_EutS4c
go/types and cmd/compile/internal/types2 both accept it, but then go2go, cmd/compile -G=3, and cmd/compile unified all produce a "calling method M with receiver p (type **MyMer) requires explicit dereference" error during code generation.
A similar issue affects instantiating type parameters with interface types: https://go2goplay.golang.org/p/-vWtl3FTslw. (Here go2go and unified both report "p.M undefined (type *Mer is pointer to interface, not interface)"; -G=3 hits an assertion failure.)
What's the expected behavior here? Should go/types reject these cases as invalid, or do the compilers need to insert the implicit dereference? I don't see anything mentioned about this in the proposal.
My intuition is these are invalid, and go/types should reject them. Type parameter types act like interface types, and we don't allow implicit dereference of pointer-to-interface-type values in method calls.
/cc @griesemer @ianlancetaylor @findleyr @bcmills

I would agree with this assessment.

For this example, note that since you can instantiate T with Mer itself, it is possible for T to be an interface type in this case: https://go2goplay.golang.org/p/KprMnRIinWV
I think an implicit dereference of *T should be allowed if T is constrained to only concrete types (no pointer or interface types), and an implicit dereference of T itself should be allowed if T is constrained to only pointer types (no value or interface types). But those cases are probably rare enough that it's not a huge deal if we spuriously reject them too.

I'm similarly okay with allowing implicit dereference of pointer-to-TypeParam as long as the TypeParam is constrained to disallow instantiation as an interface type; but similarly skeptical that it's important enough to prioritize for Go 1.18.
This seems like something worth revisiting if/when we extend generics to better support pointer-receiver parameters: https://go.googlesource.com/proposal/+/refs/heads/master/design/43651-type-parameters.md#no-way-to-require-pointer-methods

Since the underlying types of type parameters are their constraint interfaces, the rules here fall out from what we already have (at least for now): pointers to interfaces don't have any methods. It seems that there's no need to explicitly document this is in the spec. Closing.


Document the default location where cargo install emitting build artifacts

Resolves #9137
Document the default location where cargo install emitting build artifacts.

r? @Eh2406
(rust-highfive has picked a reviewer for you, use r? to override)

@ehuss does it look like the code generation is done correctly?

Thanks!
@bors r+

:pushpin: Commit a70629235267abdb65eefa56ed1d1ea205224fb2 has been approved by ehuss

:hourglass: Testing commit a70629235267abdb65eefa56ed1d1ea205224fb2 with merge 51a437d32da826bfed4fee453afedadde993899e...

:sunny: Test successful - checks-actions
Approved by: ehuss
Pushing 51a437d32da826bfed4fee453afedadde993899e to master...


Feedback wanted: contributing to the complier

As discussed with @aljazerzen:
How could we better enable folks to make their first few PRs to the compiler?
PRQL has had many successes over the past year — there's much we can be happy and be grateful for. But something we've done a bad job at is enabling folks to contribute to the compiler.
We're not doing well / the trend is negative
For context, over the past six months the pattern of project's contributions have diverged:

Overall, code contributions to PRQL have increased a lot and the number of contributors has broadened  🙌. But the broadening is focused on the parts around the compiler — such as bindings, docs, integrations such as prql-vscode
The concentration of code contributions to the compiler has narrowed — I have done less, and @aljazerzen has done much much more.

My mental mode of contributions is there's a funnel — folks see a project, think it's good, maybe try using it, maybe try contributing to docs, maybe try adding some code. Then as they contribute more, they build the context to make increasingly more significant contributions. But if we can't enable them to start contributing to the compiler, they can't build the context to contribute more there. So our biggest challenge is to enable making the 1st / 2nd / 3rd compiler PR.
This matters
The current state is bad for the project for a few reasons:

Code progress — the project doesn't make the progress it needs to. We've got a lot to do — Our Roadmap — and even before the big feature development, we still have some bugs / bad error messages / etc.
Context building — beyond losing the code of those who can't contribute, we're losing their ideas. There's a dramatic difference in the speed — and to some extent the quality — of discussion between those who have the deep context of the language and those who don't. We still welcome ideas from all, and there are other ways to build that context, but having written the actual code is likely primary.
Bus factor — It puts stress on the existing contributor. While I hope we're each taking joy from the project, it's less joyful if lots of folks are waiting for a bug fix and you're the only person who can fix something.
Ratcheting — There's a self-reinforcing effect. When one person writes all the code, the code becomes fit to their style, the incentives to make the code engageable are less strong — e.g. comments explaining the code, modularity, explicit interfaces. Multiple contributors brings inherent robustness.
Diversity — It reduces the diversity of the team, and the project — which has externalities beyond just the project
Sharing — We're not sharing the joy of open-source (at least for me, if other projects were less accessible, I wouldn't have started contributing to them eight years ago, and I'd have missed out on the tremendous opportunities that this world has brought me)

Examples
I'm going to list a couple of examples of issues where folks were interested in contributing, but didn't get to submit a PR for these (though they did for other things). It's important these are perceived as examples of the core team failing to make the codebase sufficiently accessible, not as the fault of the potential contributors! Hopefully the context of this issue makes that clear.

https://github.com/PRQL/prql/issues/1355
https://github.com/PRQL/prql/issues/1284

(My guess is that there's an order of magnitude more of these where folks didn't comment on an issue they found, or didn't find an issue, despite having an interest in contributing)
And it's worth flagging some successes, so hopefully we can get feedback on what was difficult / could have been better.

@MarinPostma, with https://github.com/PRQL/prql/pull/1094
@BlurrechDev, with https://github.com/PRQL/prql/pull/1444
@bcho, with https://github.com/PRQL/prql/pull/1638
@Shuozeli, with https://github.com/PRQL/prql/pull/946
@eitsupi, with a recent great run, e.g. https://github.com/PRQL/prql/pull/1750

Questions
Some questions we'd love feedback on

If you tried to make a contribution — even for ten minutes — and didn't manage. What was difficult? What could we have done to make that easier? What projects have you successfully contributed to which we could learn from? Do you recognize something they did which was effective?
If you did make a contribution — similar questions to how we could improve. Is there something that made it more difficult to make more contributions?
If you know of a project that has done this well — what's the project and what could we learn from them?

What we've done / what we could do
Some things we've done so far:

Added a Good First Issue with tasks that would make good issues to learn the compiler. We've tried to make the explanations fairly complete
Attempted to make onboarding easy, with scripts and docs on setting the repo up locally
Offered to help with any Rust questions on Discord

Some things we could do:

Offer "office-hours" where we go through an issue live with someone who's looking to start contributing?
Stream / record some of our own contributions?
Work on breaking up the compiler into more modular pieces?

We've had some good progress on this with PL & RQ, though still many of our tests are still end-to-end, it can be difficult to know where to start. Even an issue such as https://github.com/PRQL/prql/issues/1355 requires changes throughout the codebase

Deliberately leave some easier issues? (I know I often want to take a break from work for 30 minutes and get something done, often that means grabbing an easy issue. But then the ones remaining are the gnarlier ones)
Find areas where there are "repeatable" PRs?

I was chatting with @charliermarsh about how Ruff been so successful in enabling contributions. One advantage Ruff has is that add a new lint to Ruff is a similar contribution to the lints that have already been added. So folks can look at an existing PR, think about the differences, and then add their own. Maybe we could do something similar with https://github.com/PRQL/prql/issues/1420?

Others?

I realize this issue is now very long, and getting engagement might have been optimized by just posting "PRQL is easy to contribute to" and seeing people point out why it's wrong (Cunningham's Law). Hopefully the issue at least highlights how much we care about this dimension.
If you can build on the questions above, it's fine to have a short or curt response! Greatly appreciate your feedback, thank you.

I went from playing with the code on the binding side.

Create R bindings (Of course, this is because the JS and Python bindings were so simple that I felt it would be easy to create R bindings)
Investigate how to realize the functionality I want in the R binding (convert from string to enum)
Think it would be better to implement it on the compiler side, so try to add the functionality on the compiler side.

My thought is that it is easier to get around to fixing the parts of each language binding and CLI that users can execute immediately.
So why not create issues for each language bindings and label it as a Good First issue?
For example, something like #1838 to add a function that was in prql-js but not in prql-python.

Find areas where there are "repeatable" PRs?

In this repository, adding functionality to the bindings for each language would be equivalent to this.
Once we become familiar with the repository, it will be easier for us to contribute to the compiler too.

@max-sixty - Is this a good agenda item for the Dev Call tomorrow? Thanks.

@max-sixty - Is this a good agenda item for the Dev Call tomorrow? Thanks.

Yes, though tbc, I'm hoping to understand the empirical experiences of those who have arrived new to the project & attempted to contribute to the compiler. So I'm keen to hear from folks who have done that — ideally before we jump to potential solutions. I'll add the label.

Sorry, it seems that I had accidentally unpinned this issue by mistake.......

Building on the broader thoughts in https://github.com/PRQL/prql/issues/1420#issuecomment-1481777909 here:

OK cool — that said, I still think that a different unmerged branch introduces a bunch more context. Maybe I try and get that merged with an initial example after I'm done on some of the current priority issues?
I'm not trying to criticize at all — clearly this work is much much better than doing nothing — I'm more trying to work through why efforts such as this or the precursor to https://github.com/PRQL/prql/pull/2251 weren't successful — open to other ideas ofc.
And I guess I'm open to "it's not worth our time to create these issues, easier to do it ourselves". My view might be overly biased by how I got involved with Open-Source eight years ago, and seeing a few people start-but-then-pause in this repo. And wanting us to compound our time and contributions...

FYI this is the sort of issue-to-PR pipeline that is awesome — someone spots an issue, one of us gives a couple hints — and they generously submit a PR which gets merged immediately: https://github.com/PRQL/prql/pull/4598
I realize not all our issues are that simpler, and we're doing lots of work on the resolver which is harder. But this was a win!


describe() fixes

Fixes https://github.com/Kotlin/dataframe/issues/352 and part of https://github.com/Kotlin/dataframe/issues/558
I'll first fix some of the most annoying bugs which can be found with describe(), more changes or fixes will come later.
Fixed:

created col.isInterComparable() instead of col.isComparable() to avoid confusion
cumsum:

added Short, Byte, BigInteger, Nothing support
(Short/Byte are supposed to become Int, similar to sum(), but they are temporarily converted back to Short/Byte so that the DataColumn.cumSum function returns the right type)
added extra tests

mean:

added BigInteger support
added TODOs for BigDecimal and BigInteger, they're supposed to result in BigDecimal, not Double

median:

added Float, Short, BigInteger support
Number support is still missing as it's not Comparable, will be handled later
added TODOs for conversion, will happen later

min/max:

removed unused internal code
Number support is still missing as it's not Comparable, will be handled later

std:

added BigInteger, Number support
added test for Byte
BigDecimal and BigInteger are supposed to result in BigDecimal, not Double, will be handled later

sum:

added Float, Short, Byte, BigInteger, Number, Nothing support
added some tests
conversions will be handled later

describe:

fixed @DataSchema type being String instead of KType
some cleaning up in the implementation
min, median, and max now also show up for Number columns with different types :) Numbers will be converted to double or BigDecimal first so they can be compared.

Could you please add a test for #352? Maybe even if something else covers it, good to have one that is closer to use case

Could you please add a test for #352? Maybe even if something else covers it, good to have one that is closer to use case

Very good comment. After I added a test I noticed this PR didn't actually fully fix https://github.com/Kotlin/dataframe/issues/352. It just fixed the error message. The actual issue needs to be solved separately. I will reorganize things a bit


Problem az login with service principal

This is autogenerated. Please review and update as needed.
Describe the bug
Command Name
az login
Errors:
Paste here the error message you have received. Make sure to remove all sensitive information,
such as user name, password, credential, subscription ID, etc.

To Reproduce:
Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

Put any pre-requisite steps here...
az login --service-principal -u {} -p {} --tenant {}

Expected Behavior
Environment Summary
Linux-5.19.0-38-generic-x86_64-with-glibc2.35, Ubuntu 22.04.2 LTS
Python 3.10.10
Installer: DEB

azure-cli 2.46.0

Extensions:
ssh 1.1.2

Dependencies:
msal 1.20.0
azure-mgmt-resource 21.1.0b1

Additional Context

Thank you for opening this issue, we will look into it.

Please paste here the error message you have received. Make sure to remove all sensitive information,
such as user name, password, credential, subscription ID, etc.

I run:
az login --service-principal -u  -p --tenant
here the error output:
The command failed with an unexpected error. Here is the traceback:
allow_broker=True is only supported in PublicClientApplication
Traceback (most recent call last):
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/cli.py", line 233, in invoke
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 663, in execute
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 726, in _run_jobs_serially
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 697, in _run_job
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py", line 333, in call
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py", line 121, in handler
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/profile/custom.py", line 139, in login
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/_profile.py", line 159, in login
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/auth/identity.py", line 182, in login_with_service_principal
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/auth/msal_authentication.py", line 132, in init
File "D:\a_work\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\msal/application.py", line 555, in init
ValueError: allow_broker=True is only supported in PublicClientApplication
To check existing issues, please visit: https://github.com/Azure/azure-cli/issues
To open a new issue, please run az feedback

Closing this issue as no error message is provided.

@slaffka-vlasov, we will address the allow_broker=True is only supported in PublicClientApplication error in https://github.com/Azure/azure-cli/issues/26052.


Project crashes with no errors upon tweening

Godot version:
3.2.3 stable
OS/device including version:
MacOS 11.0.1 Big Sur, GLES3
Issue description:
I created a tween inside of a script, added it to the scene tree, and tweened a non-existing node. Instead of leaving an error message, the game crashes without a trace in the debugger.
Steps to reproduce:
Create an empty scene, add a root node and add a script to this node, in the script create a new tween and add it to the scene tree. Then you only need to make the tween interpolate a property of a non-existent node and run the project, no need to even call the start() method on the tween. The project immediately crashes when interpolating the property.
Minimal reproduction project:
Bug.zip

Looks like Tween is missing null checks in interpolate_* methods.

Looks like Tween is missing null checks in interpolate_* methods.


While using plugin for ios not work as expected.

I use this plugin for download pdf file.
When i try to execute flow on android device at the same time saveDialog window appear and able to download specified file.
Simmilar way while i'm trying to do on ios device that time no any window appear on screen, whenever I logout from application then it comes window and able to download.
Anyone can look into it and anything related to same issue face and provide solution it would help.
Thanks in advace.
Sample code
let blob = new Blob([this.fileData], { type: "application/pdf" });
cordova.plugins.saveDialog.saveFile(blob, fileName).then(uri => {
	console.info("The file has been successfully saved to", uri);
}).catch(reason => {
      console.warn(reason);
});

====================================================
Above code is same for android as well as ios.
fileData is blob data and is valid , working for android

Do I understand correctly that the Save dialog doesn’t show until you log out from your application?
Yes, when i logout from application then save dialog shows. I'll check more on logs and try to  remove other cordova plugins and update you on same.

Closing this issue now. Feel free to reopen if you get some details revealing the root of the evil, or if you are able to provide steps to reproduce the issue on a a bare minimal Cordova project.


Contrast themes / WHCM support improvements

Issues reported by @albinazs as part of WCAG 2.2 accessibility audit – still to be confirmed.
Working on this
Those issues are unconfirmed – please only pick these up unless you’re comfortable with forced-colors mode / WHCM, and able to understand which area of Wagtail is mentioned. The first step will be to confirm the issues via comments here, then devise a fix.
Issues
Tooltips

[ ] Broken design for data-w-tooltip human readable date (no border, solid square instead of an arrow): w-human-readable-date
[ ] Broken design for tooltips for sidebar-slim menu items (no border, solid square instead of an arrow)
[ ] Absent border for the Actions tooltip
[ ] Absent border for the Status tooltip
[ ] Absent border for the Actions, Status, Preview, Comments, History and Live tooltips on the editor's header
[ ] Absent border for the Actions tooltip on the Image:

<button type="button" class="w-dropdown__toggle w-dropdown__toggle--icon" data-w-dropdown-target="toggle" aria-label="Actions" aria-describedby="id_image-title" aria-expanded="false">

Menus and menu items

[ ] No circle around Wagtail brand logo: sidebar-wagtail-branding__icon-wrapper
[ ] Button and links styled as buttons have different appearance on the main menu as well as menu footer which is confusing
[ ] No visible state change on hover for menu and menu footer items
[ ] Low contrast for submenu header icons: suitcase
[ ] No visible right border for the submenu header & drawer, that separates visually menu from the page content
[ ] Unnecessary 3px solid right and left borders on all the menu items
[ ] No visual indication of the chosen parent menu item when submenu is opened (except Highlight color on the extra left & right borders that seems to work only for some of the items like Pages and Bread categories)

Code:
w-page-explorer

Side panels

[ ] No visible state change on hover for the minimap items including Expand-right icon. Same goes for the most of every form-side panel's items: w-minimap__list
[ ] Unnecessary 3px solid left border on the minimap items: w-minimap__list
[ ] Broken design for the form resize grip for all form panels (square on the right instead of 2 thin central lines)

Light theme only

[ ] invisible Admin arrow icon in both open and closed states

Dark theme only

[ ] 'Warning' icon has very low contrast
[ ] disappearing 'plus' sign on the comment icon on hover
[ ] very low contrast for the Close button on the 'Change privacy' and 'Set schedule' dialogs on the History panel

Other

[ ] No visible hover effect for almost all the items on the dashboard
[ ] Absent border around the language label: w-status w-status--label
[ ] Inconsistent focus appearance for the Actions dropdown items on the footer - thick ButtonText outline instead of the Highlight like for the rest of the components on the page
[ ] No visible state change on hover for the date picker's days and light & left months navigation arrows
[ ] Inconsistent focus appearance for the Draftail containers (ButtonText border instead of a Highlight one like on Text inputs
[ ] Inconsistent appearance of the plus buttons on hover: Highlight border for the combobox and Green background for adding a block respectively: c-sf-add-button
[ ] Weird hover appearance for the combobox option items (background change):
...

I have gone through the code and I can confirm that these issues exist. I would like to give this a shot.

Go for it @nandini584  - feel free to start with a small scale PR that fixes a few things.

I have raised a small-scale PR, but I am confused about the changes to make, 1. For the main menu and main footer, are they designed separately I couldn't find the main footer. 2. No visible state changes on hover, what do you mean by this, the opacity does change on hovering the menu items.

@nandini584

No visible state changes on hover, what do you mean by this, the opacity does change on hovering the menu items.

Are you sure you're testing with the forced-colors mode? The opacity does change without the forced-colors mode, but it does not change when forced-colors is active, which is an issue.
Please note that as mentioned in the "Working on this" description of this issue, the listed issues are applicable to forced-colors mode/Windows High Contrast Mode. If you're not familiar with what it is, it is suggested that you look into that feature before working on this issue.

Sure, I will look into this. Thanks.


Cycle action: make prevent UI refresh optional

Some actions require a UI refresh to update REAPER's internal state.
Fixes #1395

:white_check_mark: Build sws 326-master completed (commit https://github.com/reaper-oss/sws/commit/12a346a269 by @cfillion)

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Ubuntu1804, ARCH=aarch64

build/sws-<IP_ADDRESS>-Linux-aarch64-cyclaction-optional-pur-12a346a2.tar.xz

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Visual Studio 2019, ARCH=x86

build/BuildUtils/SWS_Template.ReaperLangPack
build/BuildUtils/whatsnew.html
build/reaper_sws-x86.pdb
build/sws-<IP_ADDRESS>-Windows-x86-cyclaction-optional-pur-12a346a2.exe

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Ubuntu1804, ARCH=armv7l

build/sws-<IP_ADDRESS>-Linux-armv7l-cyclaction-optional-pur-12a346a2.tar.xz

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Ubuntu1804, ARCH=i686

build/sws-<IP_ADDRESS>-Linux-i686-cyclaction-optional-pur-12a346a2.tar.xz

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Ubuntu1804, ARCH=x86_64

build/sws-<IP_ADDRESS>-Linux-x86_64-cyclaction-optional-pur-12a346a2.tar.xz

Environment: APPVEYOR_BUILD_WORKER_IMAGE=Visual Studio 2019, ARCH=x64

build/BuildUtils/SWS_Template.ReaperLangPack
build/BuildUtils/whatsnew.html
build/reaper_sws-x64.pdb
build/sws-<IP_ADDRESS>-Windows-x64-cyclaction-optional-pur-12a346a2.exe


Right-click in inventory opens card

To reproduce:

place the mouse over a character.
open the inventory with the hotkey
right-clicking (to examine an item's description, e.g.) opens the card for the previous character, regardless of where the mouse is currently located

PS. <3 alphabetical order

Thanks for submitting it!
This one would be tricky to figure out

Some more info on the topic
If we are going to filter out the input from other screens we are to find the CScreen struct from CChitin -> pActiveEngine
Thanks @Eeks for the advice:
If you haven't found this yet, that would be https://eeex-docs.readthedocs.io/en/latest/EE%20Game%20Structures%20%28x64%29/CC/index.html#cchitin -> pActiveEngine
which is one of the CScreen* structs: https://eeex-docs.readthedocs.io/en/latest/EE%20Game%20Structures%20%28x64%29/CS/index.html

The problem is that I currently don't have a static pointer to CChitin. Once its found it would be an easy fix