BugFix: Prevent insertion of link of collapsed selection

fix: #5305

Shouldn't on clicking insert link button, it should be showing the edit view where user directly inserts the link and saves?Rather than having to clink on edit button to insert the link.

Yes - the way it currently works is the most annoying thing in the entire playground app to me. You are welcome to change it in a different PR.

PR is ready for review

Leaving to @acywatson on how to proceed with this one.

Leaving to @acywatson on how to proceed with this one.

Looks like we have a failing test to fix. Make sure it's not causing a regression.

@acywatson a bit late but have fixed the UT 😅

This introduces an issue where if try to remove an existing link when my collapsed selection is in inside the link, it blocks the toggling off of the link.

@ivailop7 thanks for pointing out, will fix it

@ivailop7 Have fixed the delete link issue.

Closing this PR due to staleness! If there are new updates, please reopen the PR.


[kibana] Confusion with ELASTICSEARCH_USERNAME env var

Chart version: 7.13.0
Helm Version: 3.6.0
Describe the bug:
Context: use kibana / elasticsearch with security enabled.
As per documentation, https://www.elastic.co/guide/en/kibana/7.13/using-kibana-with-security.html, we must configure kibana like this:
elasticsearch.username: "kibana_system"

Via Docker, it's possible to configure this via an environnement variable (in this case ELASTICSEARCH_USERNAME).
But the Helm chart is also using ELASTICSEARCH_USERNAME env var to do the readinessProbe curl auth!
https://github.com/elastic/helm-charts/blob/master/kibana/templates/deployment.yaml#L120
Since kibana_system user cannot be used to login on Kibana, this will fail and the pod will never become ready.
values.yaml
  elasticsearchHosts: http://hot-es-client:9200
  extraEnvs:
  - name: ELASTICSEARCH_USERNAME
    valueFrom:
      secretKeyRef:
        key: username
        name: hot-elastic-user-kibana-system
  - name: ELASTICSEARCH_PASSWORD
    valueFrom:
      secretKeyRef:
        key: password
        name: hot-elastic-user-kibana-system

Steps to reproduce:

Enable / setup elasticsearch security
Configure kibana_system user (set password)
Add env to values.Yaml

Expected behavior:
Kibana should run and become ready.
solutions
Change https://github.com/elastic/helm-charts/blob/master/kibana/templates/deployment.yaml#L120 to use a different env. What about KIBANA_USERNAME ?

still valid

IMHO, the readiness probe could simply not use credentials at all. A simple GET without credentials would redirect to the login page with a 200 OK status, which is probably sufficient to mark Kibana as ready.

hello, any news about this one?
this make kibana broken when security is enabled :/

With Elastic Stack 8+ the default health check endpoint should be /api/status because a kibana_system_user must be used to connect to Elasticsearch and those users cannot login in Kibana.


Two small fixes

Include csharp into smoketest.
include cloudtasks.json into the package.

This is gated on merging #203, which just requires approval.

Codecov Report

Merging #204 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   69.75%   69.75%
=======================================
  Files          48       48
  Lines        1984     1984
  Branches      233      233
=======================================
  Hits         1384     1384
  Misses        567      567
  Partials       33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ed0e90...f535c46. Read the comment docs.

Superceded by #208.


Event QR code generator: replace newlines by whitespace

Where to find the issue

https://www.coronawarn.app/en/eventregistration/#multi
https://www.coronawarn.app/de/eventregistration/#multi
Describe the issue

newlines in the CSV file will lead to a corrupted QR code
Suggested change

If the loaded CSV-file contains newlines (in description etc) these should be replaced by a simple whitespace.

Internal Tracking ID: EXPOSUREAPP-12078

fixed


Adding the wrong IP Adress

It looks like it recognizes my server, but because of some DNS magic on my end, it's adding the wrong IP address, which doesn’t actually point to my server. A config file to specify the correct server IP would be great. Nice project overall—I can see it working really well in a 'normal' setup!

Can I ask what you are using for your "DNS magic"?

I’m using DynDNS and some IP tunneling, but it’s showing an IP that I don’t recognize at all. It’s not part of my network, my domain, or my hosting provider.


Robot code now restarts after deploying, updated to newest plugin URL

I apologize for the weird changes to spacing, I have IntelliJ configured to automatically reformat code for projects that I'm opening for the first time.

This is already done in the 'clean' branch, and an updated .jar will be available once I get maven on my server ^^


Bootstrap 4 Offline Docs as (HTML) Files

Is there any way to download (BS4 Docs) as HTML files ?? so there is no need to open localhost, many people are looking for it.

many people are looking for it.

citation needed

Download the gh-pages branch and run a local server somehow, like Python: python -m SimpleHTTPServer 8000.

Or if you use a browser which supports service workers, you can visit https://getbootstrap.com/ and navigate offline.

Thanks @XhmikosR - i downloaded the ph-pagrs + using live-server branch as Mdo said .. it works fine :)


Are there any plans to support material design animations?

Like FAB-to-dialog transitions or circular reveal?

I think that the transition your are referring to most likely fall under the #4117 issue.


CMOS-270 Add disk write queue checker

Adds a checker for the amount of time that the oldest item has been in the disk write queue.

Is there nothing the user can do to prevent this without contacting support?

Maybe review our sizing guide and improve the hardware in their cluster? What do you think?


List of PRs that are ready for review

If it's helpful, I've made a list of PRs that I think are pretty trivial and ready:

#767
#766
#765
#755 (My PR, would close #752 and #750, and create pretty much #765 - maybe merge that one first)
#749
#747 (could also drop the venv<20 workaround)

These might require a bit more review, but I think they are good:

#756 This looks ready to me, and is something I've really wanted for a long time!
#762 (My PR)
#770 (My PR)

And some that I didn't review as closely, but would be good to get in and are pretty close if not ready:

#753
#687 (Tox 4 has been out for quite a while now!)
#707
#730

I'd also like a followup to #762 before a hypothetical release. :)
CI's currently broken, working on fixing it upstream in conda-forge. Fix is out.

Thanks for putting this together @henryiii . I struck an entry that I merged just now. I am not currently planning a release, but this does seem a nice list to review before.

I'm currently working on a followup PR (#781), and will do one more followup (fallback envs), then will close this issue!

With all this new functionality landed, is there a plan for a release?


RefreshIndicator not working with ReorderableListView when the list isn't long enough

I tried to wrap my re-orderable list view with RefreshIndicator it's working but, when list don't have minimum data for scroll RefreshIndicator didn't refresh my re-orderable list.
I checked the flutter Doc. and found:
In simple listview If the Scrollable might not have enough content to overscroll, we can set physics property to AlwaysScrollableScrollPhysics:
is there any way to done something like that in re-orderable list.
Future<dynamic> refreshList() async {
    await Future.delayed(const Duration(seconds: 1));
    testBloc.testList(
      prefsObject.getString('testId'),
    );
  }

return RefreshIndicator(
      key: refreshKey,
      color: pinkColor,
      onRefresh: () async {
        await refreshList();
      },
      child: ReorderableListView(
        header: null,
        onReorder: _onReorder,
        children: child,
        scrollDirection: Axis.vertical,
      ),
    );

Hi @parth22
could you please provide your updated  flutter doctor -v?
Thank you

Output of  flutter doctor -v
[✓] Flutter (Channel stable, v1.9.1+hotfix.6, on Mac OS X 10.13.6 17G65, locale
en-IN)
• Flutter version 1.9.1+hotfix.6 at /Volumes/Data/flutterSDK/flutter_hotFix2
• Framework revision 68587a0916 (9 weeks ago), 2019-09-13 19:46:58 -0700
• Engine revision b863200c37
• Dart version 2.5.0
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.1)
• Android SDK at /Volumes/Data/AndroidSDK/sdk
• Android NDK location not configured (optional; useful for native profiling
support)
• Platform android-29, build-tools 29.0.1
• Java binary at: /Applications/Android
Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build
1.8.0_202-release-1483-b49-5587405)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 10.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 10.1, Build version 10B61
• CocoaPods version 1.8.4
[✓] Android Studio (version 3.5)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 40.2.2
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build
1.8.0_202-release-1483-b49-5587405)
[✓] VS Code (version 1.40.0)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.6.0
[✓] Connected device (1 available)
• iPhone X • 86A60205-090F-4BE5-8963-6590C33AA6BB • ios • iOS 12.1
(simulator)
• No issues found!

Same here!

Add padding for ReorderableListView in your code. Final code result must be:
`Future refreshList() async {
await Future.delayed(const Duration(seconds: 1));
testBloc.testList(
prefsObject.getString('testId'),
);
}
return RefreshIndicator(
key: refreshKey,
color: pinkColor,
onRefresh: () async {
await refreshList();
},
child: ReorderableListView(
header: null,
onReorder: _onReorder,
children: child,
padding: const EdgeInsets.symmetric(vertical: 30.0),
scrollDirection: Axis.vertical,
),
);`
This code work for me!

RefreshIndicator only works when list has long content, if you set it to 5 in the code sample below, it won't work

Code Sample
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Material App',
      theme: ThemeData.dark(),
      home: Home(),
    );
  }
}

class Home extends StatefulWidget {
  @override
  _HomeState createState() => _HomeState();
}

class _HomeState extends State<Home> {
  final List<String> _list = List.generate(50, (i) => "${i}");

  final GlobalKey<RefreshIndicatorState> _refreshIndicatorKey =
      new GlobalKey<RefreshIndicatorState>();

  Future<dynamic> refreshList() async {
    await Future.delayed(const Duration(seconds: 1));
    print('test');
    // testBloc.testList(
    //   prefsObject.getString('testId'),
    // );
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text('Material App Bar'),
      ),
      body: RefreshIndicator(
        key: _refreshIndicatorKey,
        color: Colors.pink,
        onRefresh: () async {
          await refreshList();
        },
        child: ReorderableListView(
          // padding: const EdgeInsets.symmetric(vertical: 30.0),
          children: _list
              .map((String string) => ListTile(
                  key: Key(_list[_list.indexOf(string)]), title: Text(string)))
              .toList(),
          onReorder: (oldIndex, newIndex) {
            String old = _list[oldIndex];
            if (oldIndex > newIndex) {
              for (int i = oldIndex; i > newIndex; i--) {
                _list[i] = _list[i - 1];
              }
              _list[newIndex] = old;
            } else {
              for (int i = oldIndex; i < newIndex - 1; i++) {
                _list[i] = _list[i + 1];
              }
              _list[newIndex - 1] = old;
            }
            setState(() {});
          },
        ),
      ),
      floatingActionButton: FloatingActionButton(
        child: Icon(Icons.add),
        onPressed: () {},
      ),
    );
  }
}

flutter doctor -v
[✓] Flutter (Channel dev, 1.20.0-2.0.pre, on Mac OS X 10.15.5 19F101, locale
    en-GB)
    • Flutter version 1.20.0-2.0.pre at /Users/tahatesser/Code/flutter_dev
    • Framework revision 15a28159bc (9 days ago), 2020-06-23 04:52:58 -0700
    • Engine revision 91a63d6a44
    • Dart version 2.9.0 (build 2.9.0-19.0.dev 7e72c9ae7e)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /Users/tahatesser/Code/sdk
    • Platform android-30, build-tools 30.0.0
    • ANDROID_HOME = /Users/tahatesser/Code/sdk
    • Java binary at: /Applications/Android
      Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 11.5, Build version 11E608c
    • CocoaPods version 1.9.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 47.1.2
    • Dart plugin version 193.7361
    • Java version OpenJDK Runtime Environment (build
      1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.46.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.12.1

[✓] Connected device (5 available)
    • SM M305F      • 32003c30dc19668f          • android-arm64  • Android 10
      (API 29)
    • Taha’s iPhone • 00008020-001059882212002E • ios            • iOS 13.5.1
    • macOS desktop • macos                     • darwin-x64     • Mac OS X
      10.15.5 19F101
    • Web Server    • web-server                • web-javascript • Flutter Tools
    • Chrome        • chrome                    • web-javascript • Google Chrome
      83.0.4103.116

• No issues found!

Making a copy of the ReorderableListView and adding the physics property seems to work fine, so I pushed it as a package: https://pub.dev/packages/refreshable_reorderable_list
You can use it like this:
refreshable_reorderable_list: ^0.0.1

import 'package:refreshable_reorderable_list/refreshable_reorderable_list.dart';

RefreshableReorderableListView(
  physics: AlwaysScrollableScrollPhysics(),
  onReorder: (oldIndex, newIndex) {
    //...
  },
  children: //...
),

@dave Wouldn't that be something you should rather try to get pulled in the actual widget and not create your own?
Is there any solution that does not require third party widgets or editing the flutter widgets code?

I'm pretty new at Flutter development so I was basically just randomly tweaking stuff so I have no idea if this method has side effects 😉

I cannot reproduce this on latest master

Code sample
import 'package:flutter/material.dart';

void main() {
  runApp(const App());
}

class App extends StatelessWidget {
  const App({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'App',
      home: Scaffold(
        body: RefreshIndicator(
          onRefresh: () => Future.delayed(const Duration(seconds: 1)),
          child: ReorderableListView(
            header: null,
            onReorder: (_, __) {},
            children: [
              ListTile(key: ValueKey('1'), title: Text('1')),
              ListTile(key: ValueKey('2'), title: Text('2')),
              ListTile(key: ValueKey('3'), title: Text('3')),
            ],
            scrollDirection: Axis.vertical,
          ),
        ),
      ),
    );
  }
}

flutter doctor -v
[√] Flutter (Channel refresh, 2.6.0-12.0.pre.1015, on Microsoft Windows [Version 10.0.19041.1348], locale ru-RU)
    • Flutter version 2.6.0-12.0.pre.1015 at C:\dev\src\flutter
    • Upstream repository git@github.com:nt4f04und/flutter.git
    • FLUTTER_GIT_URL = git@github.com:nt4f04und/flutter.git
    • Framework revision 13fa98cf4e (4 hours ago), 2021-12-14 01:27:02 +0300
    • Engine revision f16c96c31f
    • Dart version 2.16.0 (build 2.16.0-85.0.dev)
    • DevTools version 2.9.1

[!] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\danya\AppData\Local\Android\sdk
    X cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    X Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/windows#android-setup for more details.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[√] Visual Studio - develop for Windows (Visual Studio Community 2019 16.7.7)
    • Visual Studio at C:\Program Files (x86)\Microsoft Visual Studio\2019\Community
    • Visual Studio Community 2019 version 16.7.30621.155
    • Windows 10 SDK version 10.0.19041.0

[√] Android Studio (version 4.1)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)

[√] IntelliJ IDEA Community Edition (version 2020.3)
    • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2020.3.3
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart

[√] VS Code (version 1.63.0)
    • VS Code at C:\Users\danya\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.29.0

[√] Connected device (4 available)
    • sdk gphone x86 (mobile) • emulator-5554 • android-x86    • Android 11 (API 30) (emulator)
    • Windows (desktop)       • windows       • windows-x64    • Microsoft Windows [Version 10.0.19041.1348]
    • Chrome (web)            • chrome        • web-javascript • Google Chrome 96.0.4664.93
    • Edge (web)              • edge          • web-javascript • Microsoft Edge 96.0.1054.53

! Doctor found issues in 1 category.

Closing per the last comment, please follow up there. Thanks!


add program #4476 in javascript

Why:
Closes #4476
What's being changed:
Create function findSecondSmallestNumberInAnArray that accepts an input array of integers and returns the second smallest element.

requesting review of pull request. Thanks!


Fix transitive inclusion of native libs in C# nugets

Fixes https://github.com/grpc/grpc/issues/11279
Also moves some dotnet pack argument to .csproj files (cleanup).

Artifact build: https://grpc-testing.appspot.com/view/Artifacts/job/gRPC_build_artifacts_legacy1_3_x/3449/

Failures:
https://github.com/grpc/grpc/pull/10100


added AI solution provider

I added the option to register the OpenAI solution provider if users add 'openai_key' to the 'config/packages/ignition.yaml' file.

It seems these changes break the tests. Could you look at that?

Thanks!


Merging test coverage with other reports generated by coverageProvider v8 result in wrong coverage

Describe the bug
I setup coverage as described in the docs. https://storybook.js.org/addons/@storybook/test-runner#setting-up-code-coverage:~:text=published Storybook instead.-,Setting up code coverage,-The test runner
I added the coverage addon, run yarn test-storybook --coverage. Now I want to merge it with my other jest coverage.
So I setup the described coverage-report script as described in the docs: https://storybook.js.org/addons/@storybook/test-runner#setting-up-code-coverage:~:text=3 - Merging code coverage with coverage from other tools
My scripts look like this:
    "test:jest": "jest",
    "coverage": "yarn run coverage:storybook && yarn run coverage:unit && yarn run coverage:report",
    "coverage:unit": "yarn run test -- --watchAll=false --coverage",
    "coverage:storybook": "test-storybook --config-dir build/storybook --coverage",
    "coverage:report": "cp coverage/storybook/coverage-storybook.json coverage/coverage-storybook.json && nyc report --reporter=text -t coverage --report-dir coverage/merged",

When I run test-storybook and jest separately, everything looks good.
Wenn both are merged the results look wrong.
Here is an example of my Navigation Component.
Result from the unit test:
 src/Navigation                |   47.22 |    23.53 |       0 |   59.65 |
  Navigation.tsx               |      50 |        0 |       0 |   58.33 | 16-20
  NavigationFooterLink.tsx     |     100 |      100 |     100 |     100 |
  NavigationHeaderLink.tsx     |   22.22 |    33.33 |       0 |   33.33 | 11-19
  NavigationItem.tsx           |   63.64 |        0 |       0 |   77.78 | 12-13
  NavigationItemRoot.ts        |   28.57 |       50 |       0 |      40 | 10-14
  NavigationRoot.ts            |   21.05 |     12.5 |       0 |   30.77 | 15-40
  index.ts                     |     100 |      100 |       0 |     100 |

Result from test-storybook:
src/Navigation                |   85.71 |    66.67 |      75 |   85.71 |
  Navigation.tsx               |     100 |      100 |     100 |     100 |
  NavigationFooterLink.tsx     |     100 |      100 |     100 |     100 |
  NavigationHeaderLink.tsx     |      25 |        0 |       0 |      25 | 11-19
  NavigationItem.tsx           |     100 |      100 |     100 |     100 |
  NavigationItemRoot.ts        |     100 |       50 |     100 |     100 | 14
  NavigationRoot.ts            |     100 |    78.57 |     100 |     100 | 19,25,40
  index.ts                     |     100 |      100 |     100 |     100 |

Result after merge:
src/Navigation                |   48.61 |    61.76 |   64.29 |    61.4 |
  Navigation.tsx               |      50 |       50 |     100 |   58.33 | 16-20
  NavigationFooterLink.tsx     |     100 |      100 |     100 |     100 |
  NavigationHeaderLink.tsx     |   22.22 |    33.33 |       0 |   33.33 | 11-19
  NavigationItem.tsx           |   63.64 |      100 |     100 |   77.78 | 12-13
  NavigationItemRoot.ts        |   28.57 |       50 |     100 |      40 | 10-14
  NavigationRoot.ts            |   26.32 |    68.75 |     100 |   38.46 | 18-40
  index.ts                     |     100 |      100 |       0 |     100 |

Why is the result after merge lower than the result after test-storybook? Navigation.tsx (line 2) has a test coverage of 100% in test-storybook so no other tests are required from unit test. So I would expect 100% coverage after merge. But the coverage after merge is 50% like in the unit test.

The Content of the mentioned `Navigation.tsx` looks like this (click to show code)
import React from 'react'
import { Size } from '../design-system/Styleguide'
import NavigationRoot from './NavigationRoot'

type Props = {
  orientation?: 'horizontal' | 'vertical'
  spacing?: Size | false
  size?: Size | false
  children: React.ReactNode
}

const defaultSpacing = Size.Medium
const defaultSize = Size.Medium

const Navigation = ({
  spacing = defaultSpacing,
  size = defaultSize,
  orientation,
  children,
}: Props) => (
  <NavigationRoot
    gridSpacing={spacing}
    gridSize={size}
    orientation={orientation}
  >
    {children}
  </NavigationRoot>
)

export default Navigation

Environment

OS: macOS 12.2.1
Node.js version: 16.13.2
YARN version: 1.22.18
Browser (if applicable): Chrome
Browser version (if applicable):  https://www.whatsmybrowser.org/b/T2EFP
Device (if applicable): MacBook 14" 2021 M1

I ran into a similar problem. There's not enough information here to tell if it's the same, but do you see a different number of line counts between the two coverage reports?
I found that my problem was when I used coverageProvider: 'v8' as recommended in the next.js docs import and export lines were counted as coverable pieces of code (which makes sense if you think about how v8 and modules work). Storybook's test runner is using babel for the coverageProvider, and so the import/export lines do not count.
So the coverage report by storybook was reporting 100% covered and my jest tests were reporting 0%, and when merged I got about 50% because the storybook coverage report didn't "count" the import/export lines.
The fix I did was to change Next.js to use coverageProvider: 'babel' and then the reports lined up and merged as expected.

@VickyKoblinski thank you for this information. I actually don't know anything about how coverage works, so I will check this coverage provider setting.
I'm not using nextjs but "pure" jest, but I will check what I can do here.

@VickyKoblinski what do you mean with "but do you see a different number of line counts between the two coverage reports"
Where can I see this?

@VickyKoblinski it looks like you are right about the reason for my problem. The Jest unit tests has a line coverage of 4/13 while storybook test-runner has 5/5
So jest recognizes 13 lines while test runner only recognizes 5.
The same happens to branches (jest 16, test runner 14) and statements  (jest 19, test-runner 5).
That means I have to configure it somehow so that both recognize the same number of total lines to cover, either 13 or 5.

So I tried to investigate my problem further. Looks like @VickyKoblinski is right with her assumption, the storybook test-runner and jest count the total numbers of lines (that need must be covered) differently
Unfortunately the coverageProvider: 'babel' setting did not work out for me. I was already using the default babel provider.
But even with this default provider, storybook test-runner counts less lines than jest.
For example import lines (screenshot lines 1-3) and lines that include object destructuring (e.g. screenshot lines 14, 18, 21) within function props of tagged template literals, are not counted as lines that need to be covered.
When enabling the mentioned v8 `coverageProvider?, jest also counts empty lines.
Here are screenshots of my results.:
Storybook Test runner:

Jest:

How can I configure storybook test runner to use the same settings as default jest? Why does it behave differently?

Hey @derweili thanks for explaining all of that and giving so much context. Would you mind setting up a small repro so I can work on top of? I'll need to figure some stuff out and that would be pretty helpful!

@yannbf thank you for your help
Yes I was able to setup a project. unfortunately its not that small. Its a fork of my real project.
https://github.com/derweili/storybook-test-runner-coverage-demo
You need to install dependencies yarn. The project runs with node^16.13
You can start storybook with yarn start
While storybook runs, you can then run yarn coverage
This starts the mentioned unit and test-runner tests. The coverage reports are then saved to ./coverage/...
It also creates a merged report
After generating the coverage reports you can open following files to see the reports from the screenshots above:
./coverage/unit/lcov-report/src/Navigation/NavigationRoot.ts.html # The Unit test result
./coverage/storybook/lcov-report/src/Navigation/NavigationRoot.ts.html # The test-runner test result

Again thank you for your help

The root cause it can't merge is that the formats of the original coverage data are different.

1, stroybook: Istanbul coverage data instrumented with @storybook/addon-coverage
2, Jest + coverageProvider: 'babel':  Istanbul coverage data instrumented with babel-plugin-istanbul
3, Jest + coverageProvider: 'v8': Istanbul coverage data converted with v8-to-istanbul from V8 coverage data

Options

Merging 1 with 2: It might succeed, but problems may still exist, because different tools babel and vite have been used, and different versions of istanbul-lib-instrument

"dependencies": {
    "@storybook/addon-coverage": "^1.0.1",
    "@storybook/test-runner": "^0.17.0"
  }

+--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| | `--<EMAIL_ADDRESS>| +--<EMAIL_ADDRESS>| `--<EMAIL_ADDRESS>|   `--<EMAIL_ADDRESS>`--<EMAIL_ADDRESS>  +--<EMAIL_ADDRESS>  | `--<EMAIL_ADDRESS>  |   `--<EMAIL_ADDRESS>  +--<EMAIL_ADDRESS>  | `--<EMAIL_ADDRESS>  |   `--<EMAIL_ADDRESS>  |     `--<EMAIL_ADDRESS>  `--<EMAIL_ADDRESS>    `--<EMAIL_ADDRESS>      `--<EMAIL_ADDRESS>        `--<EMAIL_ADDRESS>deduped

Merging 1 with 3: In most cases, it won't succeed, because we cannot perfectly convert v8 to Istanbul format, see issue

Possible solution: try using the native v8 coverage data source

storybook: try generating V8 coverage reports, see example
jest: coverageProvider: 'v8' + jest-monocart-coverage also generating v8 coverage reports
merging v8 coverage reports: see introduction


[RFE] Display container Statistic

The SOSREPORT includes the crictl stats output, which should be used to display the resource usage at the container level.
This should be displayed when providing the menu options, but also displayed as a separate option to display the statistic of the containers.

Included in version 1.0.0

Closing the RFE


Data Provider only feature

Allows the user to pass an argument that allows to only process controllers via withDataProvider excluding access to controllers indiscriminately.
symfony console dump-static-site --wdp-only

Hi, thanks for PR.
What is the use case for this?

Friendly ping

Closing for lack of feedback. We're narrowing issues to keep focus on active and engaging contributor to keep project growing. :+1:
Thank you for understanding.
Feel free to re-open and make CI pass, if this is still releveant

Hey Tomas, sorry I was out of town just getting back, the use case is the following:
The export fails when you got controllers with authorization, it will not export because you are not passing an user credentials, so what I did is to integrate a flag to avoid the exporter looking into all the controllers but only the ones WithDataProvider which are the ones defining the correct functions to public addresses in the platform.

Now I am going back to the source code because when adding a Site Prefix the exporter will double export the prefix of the platform for example:
Currently doing:
Site prefix: mydomain.com/my-site-prefix/
Exports:
to path: output/my-site-prefix/my-site-prefix/
So it's duplicating the my-site-prefix for the output of the controllers everything else is exported correctly (since it is a cp from public)
Regards,

Thanks for reaching out :+1:

The export fails when you got controllers with authorization, it will not export because you are not passing an user credentials, so what I did is to integrate a flag to avoid the exporter looking into all the controllers but only the ones WithDataProvider which are the ones defining the correct functions to public addresses in the platform.

I'm not sure this need and extension. It can be handled in custom data provider.

Yes I know, I add the custom data provider and execute the command and it fails because I will scan all controllers regardless. But okay for my use case I am using my own repository for the project I added it to, if not I'll rewrite the whole thing, I'm new to symfony and getting used to it I think I'm learning pretty fast.

Adding more on this, I am not sure if the error I am getting is due my custom data providers living inside a sub directory in my controllers folder, could this be the issue? Because despite having these the dump-static-site command will look all of the controllers throwing the error of not injected dependencies (auth, or others).
Could that be the issue?

Adding more on this, I am not sure if the error I am getting is due my custom data providers living inside a sub directory in my controllers folder, could this be the issue?

Not sure. If you move them to directory above, would it help?


Bizarre Surface Slice With Cube

Description
Hello, I was getting some weird results for some tests I'm doing with CDCPD and I've found that I'm getting a strange SDF surface with pytorch_volumetric. The surface seems to jut out of the expected surface.
The mesh is a cube mesh with center at (0, 0, 0), moved to (3.51, 0, 0) with the pytorch_volumetric visualization frame. The cube mesh has side length of 0.2.
This shows the strange jut of surface.

And a zoomed view.

Am I doing something wrong that may cause this?
 Are you using the latest master or a previous release? I don't think the latest release has this fix yet.

Thanks for the quick reply. I see. I'm using the pip-installed version so I believe I'm behind master. Is it easy/quick to do another release or should I just pull master and do a local install?


POINT light does NOT work in android

Describe the bug
POINT light does NOT work in android 13
To Reproduce
Steps to reproduce the behavior:

apply path below

Index: android/samples/sample-lit-cube/src/main/java/com/google/android/filament/litcube/MainActivity.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/android/samples/sample-lit-cube/src/main/java/com/google/android/filament/litcube/MainActivity.kt b/android/samples/sample-lit-cube/src/main/java/com/google/android/filament/litcube/MainActivity.kt
--- a/android/samples/sample-lit-cube/src/main/java/com/google/android/filament/litcube/MainActivity.kt	(revision 35c91827af1208f07aa0052c5ec9977fa0830059)
+++ b/android/samples/sample-lit-cube/src/main/java/com/google/android/filament/litcube/MainActivity.kt	(date<PHONE_NUMBER>207)
@@ -161,12 +161,13 @@

         // Create a color from a temperature (5,500K)
         val (r, g, b) = Colors.cct(5_500.0f)
-        LightManager.Builder(LightManager.Type.DIRECTIONAL)
+        LightManager.Builder(LightManager.Type.POINT)
                 .color(r, g, b)
                 // Intensity of the sun in lux on a clear day
                 .intensity(110_000.0f)
                 // The direction is normalized on our behalf
-                .direction(0.0f, -0.5f, -1.0f)
+                //.direction(0.0f, 0f, -1.0f)
+                .position(0f, 0f, 6f)
                 .castShadows(true)
                 .build(engine, light)

@@ -179,7 +180,7 @@
         camera.setExposure(16.0f, 1.0f / 125.0f, 100.0f)

         // Move the camera back to see the object
-        camera.lookAt(0.0, 3.0, 4.0, 0.0, 0.0, 0.0, 0.0, 1.0, 0.0)
+        camera.lookAt(0.0, 0.0, 4.0, 0.0, 0.0, 0.0, 0.0, 1.0, 0.0)

         startAnimation()
     }

build & run on Android, the cube is black, no point effect to see
Expected behavior
to see POINT light effect
Screenshots
If applicable, add screenshots to help explain your problem.
Logs
If applicable, copy logs from your console here. Please do not
use screenshots of logs, copy them as text.
Smartphone (please complete the following information):

Device: vivo PD2282
OS: Android 13

Additional context
DIRECTIONAL light is work.

You need to give your light a radius as well.

I have the same problem too.
How to set the radius?


Added override to allow init from code

Without overriding the init(frame:) we only get the ability to create
the rounded button from a storyboard or nib. UIButton has 2 designated
initilaizers If we only override one of them (init with coder, that will
be the only one that is available) if we over ride them both, we also
inherit the convenience initializer for the superclass as well allowing
us to make rounded buttons from storyboard/nib or from code with
init(frame:) or init(type:)

@stellasu168 @yhu98 You guys want to take a look at this?

Sorry for the delay John! The update looks great. Thank you!


Version Packages

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
<EMAIL_ADDRESS>Patch Changes

#844 19c27dc Thanks @OCA99! - y-partykit provider can generate IDs even if 'crypto' is not defined

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[TW#18311] Bluetooth transmission problem

use a2dp_source example，When you turn off the bluetooth headset, esp32 reports the error and restarts the program.

@blueMoodBHD please help review the issue.

@wangweidaai Because I did not reproduce the problem, can you provide the relevant log? Thanks

Closing as can't reproduce. Please reopen if the issue persists and you can supply more details. Thanks.


Descriptive Analysis

Finished editing jupyter notebook for newest changes in desctiptive analysis. Check newest html for reference.


How can I hide the title bar？

Oh，Sorry, I made a mistake. The "title bar" here corresponds to "header", and I used the subCommand in GUI.
header {
display:none;
}

Oh，Sorry, I made a mistake. The "title bar" here corresponds to "header", and I used the subCommand in GUI.
header {
display:none;
}


Include query string in the URL

The purpose is to easily share filtered results of the geojson.  For example, http://mysite/#table/{query}

PR's welcome!


Auto-upgrade to <IP_ADDRESS>

Base PullRequest
default branch (https://github.com/http4k/http4k-connect/tree/master)
Command results

Details:

add path
/home/runner/work/_actions/technote-space/create-pr-action/v2/node_modules/npm-check-updates/build/src/bin

./upgrade_http4k.sh <IP_ADDRESS>

Changed files

Changed file:

gradle.properties

:octocat: Repo | :memo: Issues | :department_store: Marketplace

Codecov Report

Merging #165 (33962fd) into master (0414a05) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #165   +/-   ##
=========================================
  Coverage     65.54%   65.54%
  Complexity      812      812
=========================================
  Files           416      416
  Lines          4826     4826
  Branches        438      438
=========================================
  Hits           3163     3163
  Misses         1413     1413
  Partials        250      250

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

Command results

Details:

add path
/home/runner/work/_actions/technote-space/create-pr-action/v2/node_modules/npm-check-updates/build/src/bin

./upgrade_http4k.sh <IP_ADDRESS>

Changed files

Changed file:

gradle.properties

:octocat: Repo | :memo: Issues | :department_store: Marketplace


Should the open ai api key be given to run it??

requests.exceptions.ConnectionError: HTTPSConnectionPool(host='openaipublic.blob.core.windows.net', port=443): Max retries exceeded with url: /encodings/cl100k_base.tiktoken (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x306642d50>: Failed to establish a new connection: [Errno 2] Lookup timed out'))
can the backend for devika be run without api keys??

Nope, actually you need it. If you don't want to, then try Ollama and run llama2, it would not require.
But bing search API key is a must as it seemed to me.

but the backend it not running even after giving the bing api also its shows the same error as before

Did you select llama2 model?

my whole python backend is only not running its showing the open ai error

frontend is working

yes

ill send

pip install urllib3==1.25.11
Run this

The error traceback you've provided indicates several issues related to DNS resolution and connection problems, ultimately leading to a failure to establish a connection to openaipublic.blob.core.windows.net. Here's a breakdown of the issues:
DNS Resolution Error:
The first error seems to originate from a DNS resolution issue. It indicates that the DNS resolution lifetime expired after a certain period, likely due to malformed text input from the server. This error arises from the greendns.py module.
It seems to be caused by malformed text input from the DNS server.
Connection Timeout Error:
The second part of the traceback indicates a connection timeout error while trying to establish a connection to openaipublic.blob.core.windows.net. This error originates from the urllib3 and requests modules.
The specific error message indicates that the lookup timed out.
Max Retries Exceeded:
The third part of the traceback shows that max retries were exceeded while attempting to establish a connection to openaipublic.blob.core.windows.net.
These errors suggest there might be network issues, DNS configuration problems, or possibly issues with the server hosting openaipublic.blob.core.windows.net. To resolve these issues, you may consider the following steps:
Check your network connectivity and ensure that DNS resolution is functioning correctly.
Verify the DNS configuration and ensure that it's correctly resolving domain names.
Check if there are any firewall or security settings blocking the connection.
Ensure that the server openaipublic.blob.core.windows.net is reachable and operational.
If the issue persists, you may need to contact the administrator of the DNS server or the owner of the openaipublic.blob.core.windows.net server for further assistance.
this is the error

https://stackoverflow.com/questions/39064126/failed-to-establish-a-new-connection

is it solved or not? if solved then close the issue


Tag cloud Chart

What problem does this feature solve?
Tag chart

What does the proposed API look like?
NA

Hi, @pradeepvish1213 Here is an extension for word cloud echarts-wordcloud, does it work for you?

@plainheart I used that it's working. But I don't want to add another library. That's why I asked to, thank you for your reply.
I hope in the future to include this chart.

It's an extension for echarts. I don't think it will be an issue. Will close this issue


Headers and columns misaligned in CSV output

We just got this from a consumer of our raw output data:
"We noticed yesterday that it seemed like there was an issue with the data feed; it looks like some of the columns are off. it looks like a new column of data was inserted to the left of "Lat", but it doesn't seem to have a column header, so the rows of csv data all have an additional right-most column that doesn't have a header and the Lat, Long, RDI, Row columns don't seem to have the correct data lining up to them. "
My guess is that there's a quick fix for this one.

@4kbt just merged a fix for this: https://github.com/findthemasks/findthemasks/pull/853
Can you reach out to them and let them know?

Will do!
On Tue, May 5, 2020 at 5:52 PM Nathanael Burt<EMAIL_ADDRESS>wrote:

Closed #849 https://github.com/findthemasks/findthemasks/issues/849.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/findthemasks/findthemasks/issues/849#event-3306525215,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA6L2GFYVW6MEX6J7H4Q3FDRQCYEXANCNFSM4MZW5CXA
.


v2.1.0

Version 2.1.0-rc.1 is now on qa.polyfill.io and npm registry.
Significant changes:

Support for Firefox for Android as a distinct browser to Firefox

Full changes: https://github.com/Financial-Times/polyfill-service/issues?utf8=✓&q=milestone%3A2.1
Release to CDN scheduled for on or after 20 Oct 2015.

Released


Use IBM-Provider-vendored pub/sub mechanism

Summary
This is being removed from Qiskit 1.0, and the IBM Provider is (until deprecated) taking over brokering the IBM-Runtime-internal events.

Details and comments
See Qiskit/qiskit-ibm-provider#799 for the base, though this PR should apply cleanly even before that one, because of the backwards-compatibilty check.

Since qiskit-ibm-provider is being deprecated soon we'll have to copy the pub sub code into this repo as well

The way the pub/sub scheme is brokered by a singleton, as long as qiskit-ibm-runtime depends on qiskit-ibm-provider, it should pull the code from that package to ensure that the data streams are both using the same singleton.  The backwards-compatibility imports I stuck in here means that this will fallback to using Terra's broker if it's still in existence, for the same reason.
Once this package is deprecated, removed and qiskit-ibm-runtime no longer depends on it, (or more specifically, as long as it's not supposed to interoperate with anything that qiskit-ibm-runtime is doing, include parallel job submission), then yeah, I guess this file can just be shipped over wholesale.
I think that the only place that this is actually used (as a subscriber) is in the Jupyter monitor.  With all available configurations of packages right now, that can detect jobs submitted via either qiskit-ibm-runtime or qiskit-ibm-provider, but if we didn't have the backwards compatibility shims here, or qiskit-ibm-runtime immediately vendored the pub/sub code without the same sort of eager fall-back mechanism I added here, a running Jupyter monitor would only detect new jobs submitted from this package, rather than Runtime.  I strongly suspect that's not a blocker for anybody, but it's more the principle of stability and backwards compatibility of Qiskit!

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 43.398%

Totals

Change from base Build<PHONE_NUMBER>:
0.03%

Covered Lines:
2337

Relevant Lines:
5385

💛  - Coveralls


feat: add cube icon

Closes #
📝 Description
Add cube icon
Screenshots

Merge checklist

[ ] Added/updated tests
[x] Added changeset

@branclar should I adjust the width/height on the SVG before icon generation? For example, for cube, pulled from the Figma it's width="19" height="20" and I'm unsure if this should remain untouched here, scaling it up in usages e.g. large for animation spinner

cc @andrea-p44

@branclar I can't get cube to appear in local Storybook or the preview on this PR. Am I missing a step after component generation?

No need, I strip that out in the generate script


Supervision (Monitoring) tab revision

This is what the current version looks like:

First, I think the tab and the path should be renamed to monitoring, i.e.
https://app.test.frankencoin.com/monitoring
instead of
https://app.test.frankencoin.com/supervision
Then, I would suggest to focus on the essentials as follows:

In contrast to the borrow page, it is relevant to know how big the position is, so I would provide a concrete amount in the "collateral" tab. Next important metrics are:

Collateralization. This is (market price)/(liquidation price) and should always be above 100%.
Expiration: this is a countdown to the expiration of the position. I would only show the most significant unit. So if it is 13 days, 6 hours and 3 minutes until expiration, I would only show "13 days". And once it is less than one day, I would show "6 hours", etc.
Challenges: this is usually 0% and tells the user what fraction of the position has already been challenged. This can be above 100%. For example, if the position has 1 BTC collateral and there are two challenges, one challenging 0.3 BTC and one challenging 0.8 BTC, this number is 110%.
In the end, there is a button that leads to the challenge page, which can currently be found under path https://app.test.frankencoin.com/supervision/0x98725eE62833096C1c9bE26001F3cDA9a6241EF3/challenge . However, we might want to revise that path to https://app.test.frankencoin.com/challenge/0x98725eE62833096C1c9bE26001F3cDA9a6241EF3 or https://app.test.frankencoin.com/monitoring/0x98725eE62833096C1c9bE26001F3cDA9a6241EF3, whichever you prefer.

It should be possible to order the columns by their title:

Collateral: decreasing order (biggest first by market value)
Collateralization: increasing order (lowest first)
Expiration: increasing order (soonest first)
Challenges: decreasing order (highest first)

By default, the table should be sorted by collateralization.

When showing the table of narrow screens, the column "challenges" can be dropped. And when it gets even more narrow, we can choose a layour similar to what was described here: https://github.com/Frankencoin-ZCHF/frankencoin-dapp/issues/82

Also, the horizontal slider should be dropped.
Filtering: all open positions should be shown, including those that have 0 minted ZCHF. What matters is that they have collateral in them.

Note: this revision does not offer any way to veto a newly proposed position. I think that feature should be moved to the governance page. It is also not very important for now.

Just noticed: the "Propose New Position Type" should be dropped here. It is only relevant in the Borrow context.

Also, the horizontal slider should be dropped.
Filtering: all open positions should be shown, including those that have 0 minted ZCHF. What matters is that they have collateral in them.

[x] hor. slider dropped
[x] ??? all open positions incl. those that have 0 minted zchf, have always been shown. Need feedback otherwise.

see example:

@luziusmeisser What do you prefer?

[ ] text-red-700
[ ] text-red-500
[ ] text-red-300

I think text-red-500 is good for now. As soon as we have the new style guide, we will have to adjust this to an official color from the palette.

moved to #87


Update enums.py

Fixed SetMonitorBase typo, which was causing NotImplementedError

There's some weird error with the CI tests when import the six package.. @OrangeTux can we re-run the build? I checked if I could and I cant...


Add Get-LAPSPasswords

Add Get-LAPSPasswords.ps1 from https://github.com/kfosaaen/Get-LAPSPasswords and the laps command for dumping them.

Thanks for the PR, I've reviewed the update and you've almost nailed it but one thing. On the ImplantHandler.py I dont think there is any real need to add anything here as you've added it to the autoloads and as long as the task that is sent to the implant is 'Get-LAPSPasswords' then it will just auto execute. If you're happy with my comment, either update the PR or I can do this retrospectively. Thanks

Yeah no worries, thanks for the quick response!
That's done and pushed.


Improve Alias Generation

Description
Improve the alias generation handling

Add custom handler for jackson
Add empty prefix function

closes #38

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@67583ca). Click here to learn what that means.
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #39   +/-   ##
=======================================
  Coverage        ?   78.89%
  Complexity      ?       69
=======================================
  Files           ?        7
  Lines           ?      308
  Branches        ?       52
=======================================
  Hits            ?      243
  Misses          ?       39
  Partials        ?       26

Files Changed
Coverage Δ

...catalogs/VersionCatalogGeneratorPluginExtension.kt
73.13% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Fix barber shop template height in Firefox

Added height properties to barber shop template to prevent the pace bar from taking the entire height of the page in Firefox.

Another solution is to change position: fixed; to position: absolute; in this two classes.


[WIP] [Operator] Bilinear upsamping

@piiswrong @winstywang Init is not implemented and not test yet, seems don't need concat

what do you mean dont need concat? does this handle multiple input without duplicating memory?

After init the bilinear weight with
weight = np.zeros(np.prod(shape))
f = shape[3] / 2.
c = (2 * f - 1 - f % 2) / (2. * f)
for i in range(np.prod(shape)):
    x = i % shape[3]
    y = (i / shape[3]) % shape[2]
    weight[i] = (1 - abs(x / f - c)) * (1 - abs(y / f - c));

the result is:
original image:

nearest result:

bilinear result:

@piiswrong I have finished bilinear upsampling. For hypercolumn or concat, I am not very clear about these and feel free to refactor for your purpose.

I think it's easy to do for nearest neighbor. I'll do it after you merge this.

What happened to travis lint? Did the rule set change?

https://travis-ci.org/dmlc/mxnet/jobs/93842415 ,seems are errors with numpy and some more strict rules.

Right


[otbn, sw] Simplify OTBN drivers.

Follow-up from https://github.com/lowRISC/opentitan/pull/16119

[x] Remove sw/device/lib/runtime/otbn.c and replicate its functionality in a new file sw/device/lib/testing/otbn_testutils.c

This will make the OTBN test setup much more similar to other hardware blocks, which all have a DIF and a testutils file
Most of the functions can be rewritten to use CHECK directly instead of propagating errors, which will reduce boilerplate and help debugging by putting the CHECK-fail closer to the actual error

[x]  Refactor the silicon_creator driver  to use one file and drop the OTBN context object, matching the cryptolib driver refactor in https://github.com/lowRISC/opentitan/pull/16119
[x] Port SCA code (sw/device/sca/ecc_serial.c and sw/device/sca/ecc384_serial.c) to use the cryptolib OTBN driver instead of the runtime driver

This will make the SCA setup more similar to the cryptolib code it's trying to analyze, and allow us to fully migrate the runtime driver to test-only

Additional Context
Currently, we have 3 OTBN drivers:

Runtime/DIF driver (sw/device/lib/dif/dif_otbn.c and sw/device/lib/runtime/otbn.c)

Used for testing and the SCA code (sw/device/sca)

ROM/ROM_EXT driver (sw/device/silicon_creator/lib/drivers/otbn.c and sw/device/silicon_creator/lib/otbn_util.c)

Used for silicon creator code
Must be separate for ROM-freezing purposes
Two files because it was originally based on the DIF driver; this isn't actually necessary now

Cryptolib driver  (sw/device/lib/crypto/drivers/otbn.c)

Used for the cryptolib

CC: @alphan @bilgiday @cfrantz

This work is done now that #16910 has been merged.


Query the historical status of an aggregate

As we know, each event is stored with sequence_number  and time_stamp。
Is there any way to do this through identifier and (time_stamp or sequence_number) query the historical status of an aggregate?

There is none, and in most scenarios it isn't intended either @unhappydepig, which I will explain in a couple.
Firstly, we aim to use the GitHub issue tracker for feature/enhancement requests, bugs and dependency upgrades only. This here is a usage question, which should be targeted towards either StackOverflow with the axon tag or to our forum. If you could ask any different questions you might have in the future on either of those options, that would be very helpful.
Now back to your question, as closing this without a helpful response wouldn't be overly helpful of course.
The Aggregate in most scenarios resembles a part of the Command Model when doing CQRS. Thus, it is intended to perform operations, not to retrieve information from. Furthermore, the Repository is there to serve the purpose of returning the Command Model. As pointed out, this model is not intended to retrieve information, like the aggregate's state, from. Retrieving information is what the Query Model is for, which we typically assume to be entirely segregated from the Aggregate's you build through Axon Framework. As such, there are no operations on the Repository interface present which allow you to essentially use it as a Query Model.
So, is what you are asking wrong? Not necessarily, but it depends on whether you want to do CQRS in your application. If you do, you should build a different Query Model containing the information some part of your API should return. If you do not want to use CQRS, then by all means return the aggregateRoot object from the Aggregate returned by the Repository.
Trusting this clarifies things for your @unhappydepig, hope to see you on StackOverflow or AxonIQ's Discuss forum in the future!


Clay test

This version of TileDB (ArrayDS) adds the capability of JPEG 2000 compression for images. To support this new compression requires pre-installation of the ODA OpenJPEG library. To build and install this library, use the following steps:
git clone https://github.com/OmicsDataAutomation/openjpeg.git
pushd openjpeg
mkdir build ; cd build
cmake ..
make; sudo make install
popd
The include files will be installed in /usr/local/include/openjpeg-2.3; the library files will be installed in
/usr/local/lib. Ensure that these paths are added to the appropriate environment variables. (TileDB only needs to have /usr/local/include in the INCLUDE_PATH during the build process.)
To add the JPEG 2000 compression within TileDB, add the -DENABLE_JPEG2K=True to the cmake command:
cmake -DENABLE_JPEG2K=True ..
No other special set up steps are needed to build, install, and use TileDB with JPEG 2000 compression support.

(Note: This request supercedes the original PR (#33). I think it still contains the spacing changes and parameter reordering that I did, which is ultimately superflous to the building and execution of the code.)

Just curious, why does this PR have commits from all the way in Jan 2018? Wondering if its possible to rebase or something to only see the changes you've added...might make the review a bit easier...

I started making additions back then, but didn't have a full package ready to pull. Was ping-ponging back and forth between OpenJPEG and TileDB. Once the former was settled, I've completed a first pass on the latter.

Closing current PR. Will resubmit with modified version of JPEG integration.


Improve c-ares & curl build process

This commit improves the c-ares and curl build process to use cmake instead. This is a much better choice for docker container. We do not require the features GNU Make provides. CMake should also be more stable for testing pull requests on GitHub.
It also upgrades the c-ares and curl version to receive the latest bug fixes and performance changes. There's been a huge leap forward since the older changes. Put simple, curl 8 is faster. https://daniel.haxx.se/blog/2023/04/28/curl-8-is-faster/

AMD64 job completed in 5m instead of 7m. This is from the build log showing the new version of curl is working properly.
#102 8.742 curl 8.5.0 (Linux) libcurl/8.5.0 OpenSSL/3.1.4 zlib/1.2.13 brotli/1.0.9 zstd/1.5.5 c-ares/1.24.0
#102 8.742 Release-Date: 2023-12-06
#102 8.742 Protocols: dict file ftp ftps gopher gophers http https imap imaps mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
#102 8.742 Features: alt-svc AsynchDNS brotli HSTS HTTPS-proxy IPv6 Largefile libz NTLM SSL threadsafe TLS-SRP UnixSockets zstd

We will get results from ARM when it completes in 35m instead of 55m. 👍

This is from ARMv6. All the ARM containers have the same results. It completed in 42m down from 56m.
#102 38.54 curl 8.5.0 (Linux) libcurl/8.5.0 OpenSSL/3.1.4 zlib/1.2.13 brotli/1.0.9 zstd/1.5.5 c-ares/1.24.0
#102 38.54 Release-Date: 2023-12-06
#102 38.54 Protocols: dict file ftp ftps gopher gophers http https imap imaps mqtt pop3 pop3s rtsp smb smbs smtp smtps telnet tftp
#102 38.54 Features: alt-svc AsynchDNS brotli HSTS HTTPS-proxy IPv6 Largefile libz NTLM SSL threadsafe TLS-SRP UnixSockets zstd


Changing the mode of a unix domain socket

Mojolicious version: 7.29
Perl version: 5.20
Operating system: FreeBSD 10.3-STABLE

In using this new http+unix domain socket listening scheme, I don't see any way to change the mode (a la chmod) of the socket. Is this an oversight or deliberate?

@davehayes is there any reason you can't just change the socket mode with chmod? A unix socket is a file.

You can, but you can't do this easily in an automated fashion without having to write a Mojolicious::Command for the express purpose of doing just a chmod. The socket is created deep inside Mojo::Server::Daemon and there's no hook for changing the mode. I've had to do something like this. It's clearly not perfect but it works around the issue.
The use case I have here is a separate uid for each mojo app. In this case, you want the gid of the socket to match the nginx webserver's gid. You then want the permission of the domain socket to be rw-.
The default (and secure) umask is 022. In my case, I did not want to change the umask such that all other files my app may decide to write will have group write permissions turned on. I suspect some others will feel the same way.

There should be no need to fight with the listen locations when you have access to the Mojo::Server::Daemon instance.
my $daemon = Mojo::Server::Daemon->new(listen => ['http+unix://%2Ftmp%2Fmyapp.sock']);
chmod 0644, $daemon->start->ioloop->acceptor($daemon->acceptors->[0])->handle;
...
$daemon->run;

I had no earthly clue I could get at the handle in that way. I did not understand that "acceptor" is a listener that can accept() connections. So that's a much better solution than mine (which admittedly was not hard).
I assume that if, for some odd reason, I want to listen on multiple domain sockets, I'd do something like this?
for (@{ $daemon->acceptors }) {
   chmod 0660, $daemon->ioloop->acceptor($_)->handle;
}

I'm closing this issue because I now see two ways to change the socket mode without asking for mojolicious to change. I will comment that it might be nice for something more convenient and less opaque than the above ideas, but that's entirely up to you guys.

For those googling this, $daemon->ioloop->acceptor($daemon->acceptors->[0])->handle is an IO::Socket::UNIX glob which will not chmod. You'll need to do something like this:
chmod 0644, $daemon->ioloop->acceptor($daemon->acceptors->[0])->handle->hostpath;

Note that this assumes that the handle is an IO::Socket::UNIX.


HADOOP-15961. S3A committers: make sure there's regular progress() calls.

Contributed by lqjacklee

This is @lqjack's patch merged to trunk; tweaked slightly.
testing in progress; if all is well I'll do the final review and merge

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m 24s
trunk passed

+1 :green_heart:
compile
0m 35s
trunk passed

+1 :green_heart:
checkstyle
0m 27s
trunk passed

+1 :green_heart:
mvnsite
0m 39s
trunk passed

+1 :green_heart:
shadedclient
14m 55s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 28s
trunk passed

+0 :ok:
spotbugs
0m 59s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 56s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 33s
the patch passed

+1 :green_heart:
compile
0m 27s
the patch passed

+1 :green_heart:
javac
0m 27s
the patch passed

-0 :warning:
checkstyle
0m 19s
hadoop-tools/hadoop-aws: The patch generated 10 new + 7 unchanged - 1 fixed = 17 total (was 8)

+1 :green_heart:
mvnsite
0m 31s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 52s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 26s
the patch passed

+1 :green_heart:
findbugs
1m  0s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 23s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

58m 29s

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1848/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1848

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux 277201cade0e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 810783d

Default Java
1.8.0_242

checkstyle
https://builds.apache.org/job/hadoop-multibranch/job/PR-1848/1/artifact/out/diff-checkstyle-hadoop-tools_hadoop-aws.txt

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1848/1/testReport/

Max. process+thread count
456 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1848/1/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

failure
[ERROR] Tests run: 26, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 100.901 s <<< FAILURE! - in org.apache.hadoop.fs.s3a.auth.ITestAssumeRole
[ERROR] testRestrictedCommitActions(org.apache.hadoop.fs.s3a.auth.ITestAssumeRole)  Time elapsed: 2.808 s  <<< FAILURE!
java.lang.AssertionError: progress counter not expected. expected:<1> but was:<0>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:645)
	at org.apache.hadoop.fs.s3a.auth.ProgressCounter.assertCount(ProgressCounter.java:40)
	at org.apache.hadoop.fs.s3a.auth.ITestAssumeRole.testRestrictedCommitActions(ITestAssumeRole.java:584)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.lang.Thread.run(Thread.java:748)

checkstyle; new ProgressCounter needs reformatting

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
25m 43s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  1s
The patch appears to include 3 new or modified test files.

_ trunk Compile Tests _

+1 :green_heart:
mvninstall
19m 24s
trunk passed

+1 :green_heart:
compile
0m 36s
trunk passed

+1 :green_heart:
checkstyle
0m 27s
trunk passed

+1 :green_heart:
mvnsite
0m 38s
trunk passed

+1 :green_heart:
shadedclient
15m  9s
branch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 29s
trunk passed

+0 :ok:
spotbugs
0m 57s
Used deprecated FindBugs config; considering switching to SpotBugs.

+1 :green_heart:
findbugs
0m 56s
trunk passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
0m 32s
the patch passed

+1 :green_heart:
compile
0m 28s
the patch passed

+1 :green_heart:
javac
0m 28s
the patch passed

+1 :green_heart:
checkstyle
0m 18s
hadoop-tools/hadoop-aws: The patch generated 0 new + 7 unchanged - 1 fixed = 7 total (was 8)

+1 :green_heart:
mvnsite
0m 31s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedclient
13m 32s
patch has no errors when building and testing our client artifacts.

+1 :green_heart:
javadoc
0m 25s
the patch passed

+1 :green_heart:
findbugs
1m  1s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
1m 23s
hadoop-aws in the patch passed.

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

83m 33s

Subsystem
Report/Notes

Docker
Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1848/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/1848

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle

uname
Linux aad093542709 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
personality/hadoop.sh

git revision
trunk / 439d935

Default Java
1.8.0_242

Test Results
https://builds.apache.org/job/hadoop-multibranch/job/PR-1848/2/testReport/

Max. process+thread count
420 (vs. ulimit of 5500)

modules
C: hadoop-tools/hadoop-aws U: hadoop-tools/hadoop-aws

Console output
https://builds.apache.org/job/hadoop-multibranch/job/PR-1848/2/console

versions
git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

I'm happy with the patch, yetus is happy.
+1


Should use symbols instead of integer modes

https://github.com/Arafatk/magick-rubyplot/blob/4969fd3e34c14652de452e7d1d33268581667593/lib/rubyplot/artist/bar/data_conversion.rb#L20
I'm concerned that you're missing out on some of the really convenient features of Ruby.
From looking at your code:

I can't tell what @mode contains.
I can't tell what 1, 2, and 3 do. (You've commented these with "Case one," "Case two," and "Case three." Why even have comments that don't tell people any new information?)
Instead, maybe have the various choices for @mode be :minimum_value, :negative, :both. I don't know enough about your code, so I'm just guessing here.
** These symbols evaluate in the same amount of time as integer comparisons, so there's no reason not to use them. There are many reasons to use them, too.

How does @mode get set here? I don't see that it has a constructor, so how are you handling cases where no one has set it?
How are you handling cases where someone wants to plot a line along with a bar plot? Might it make more sense to have a general conversion class that works for all data types?

Hi John,
Thanks that certainly seems like a good idea.
As for the documentation, I think that was already okay because I put the reasoning behind the cases right above the definition https://github.com/Arafatk/magick-rubyplot/blob/master/lib/rubyplot/artist/bar/data_conversion.rb#L6
I still clarified it again in recent commit just in case. Also, the user will never use this function it's used internally by bar graph to decide where the graphs will go and set cases based on that.
If you want to know about the mode just look from
https://github.com/Arafatk/magick-rubyplot/blob/master/lib/rubyplot/artist/bar/bar.rb#L46
to line 65.
Now let me take this a bit further but I would just like your opinion.
The thing is that right now this class is quite frankly redundant and has literally one method but I will also use sidebars and perhaps move the normalization/math functions in this(No concrete plans for now just a hunch).
Would it be a good idea for all the methods in this class were to be protected methods and the bar class itself was a subclass of this class and this class was a subclass of the artist?

I think that's the kind of question you should be asking.
I'd suggest that after you write specs, you sit down and think some about how to organize your remaining coding. One thing we do in industry is open issues on features we're trying to add — even when we're still early in the process. Those issues give us a chance to sit down and say, "Okay, what's actually involved in creating this feature?" It lets us zoom in on a problem for which we have only an overarching design but no specific feature designs.
I'd like to see you start doing that. Maybe the first time you can do it is with the specs. It also makes it easier for people to evaluate your code and say, "Oh, yeah, I see why he made this decision."
Does this make sense?


MinkContext steps do not support non-default sessions

Moving issue here from https://github.com/Behat/Mink/issues/270

Closing because the MinkContext steps should not be used when using Behat the right way (i.e. having scenarios talking the language of your business, not the language of HTML), so making steps more complex to support this is not worth it IMO.


Correctly link against libtinfo

When ncurses is built with --with-termlib=tinfo option then there are two libraries - libtinfo (which contains terminal related functions) and libncurses (rest). We should correctly link against libtinfo in such case.

Merged. Thank you!

Merged. Thank you!


A06: As Admin, I would like to add / update / delete useful resources and links.

Description
Admin CRUD operations feature in the resources page:

Only authenticated admin can add/edit/delete resources. Defensive design is in place redirecting other users to the home page with the corresponding messages, when attempted to enter URL manually.
Add/edit/delete buttons are visible only to admin.
All admin actions(add/edit/delete) are followed by the corresponding messages.
Clicking Add Resource button opens the Add Resource page, where admin can fill out the Name, URL and Description fields and the new resource will be visible in the Resources table.
Clicking a Delete button opens a modal, asking an admin to confirm the deletion, resource will be permanently removed from the database.
Clicking Edit button redirects a user to the Edit Resource page with prepopulated fields.

Pull request type

[ ] #M01 (Miscellaneous User Story #01)
[ ] #P02 (Participant User Story #02)
[ ] #S03 (Staff User Story #03)
[X] #A06 (Admin User Story) - A06: As Admin, I would like to add / update / delete useful resources and links.
[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Related Issue
#25
#34
Testing

Manual tests were implemented to test the feature functionality, everything is working as expected. Admin CRUD operations were tested from the superuser's account. Attempts to use admin's functionality from other accounts and by non-authenticated users were made to test defensive design.
Responsiveness testing was implemented using Google Chrome's developer tools, everything looks as expected across all the different screen sizes.
Browser compatibility was checked on Chrome, Edge and FireFox browsers.

Screenshots

Does this introduce a breaking change

[ ] Yes
[X] No

@stefdworschak I've done those few changes, you can have a look now


Procedure to insert linebreak

Document authors frequently use line-breaks to format content.
An example of this is in table headers, where the authors wish the line break to occur in a specific place.
The DITA solution to this is the <?linebreak?> processing instruction.  The DITA-OT html transform converts this PI into <br/>.
I'm used to doing this in Text mode in OxygenXML, but we need an easy way to do this in Author mode. I then need to document it in the FieldMan user guide.
It would be useful if we could register this snippet in OxygenXML, for easy insertion.  One day we may choose to wrap that as a plugin, but for now the manual steps to do it would be fine.

I was not able to push a branch, but I can describe it here.
You can navigate to the Preferences > Code Templates and create a new code template, like in the following screenshot:

In my case, I also added a shortcut (Shift+Return).
After applying this (we can save this as a Project Option), the editor can now insert the  PI by pressing Shift_Return, or, by pressing Ctrl+Space:

When start typing "line...", the code snippet is also shown.
I think by documenting to use the shortcut helps a lot.

This is great, thanks.


{cdn} cdn endpoint update Regen by method patch to fix issue 28733

fix https://github.com/Azure/azure-cli/issues/28733

cdn


custom json font issue ?

hi ! i'd love to use your shader, sadly i'm running into an issue where:

(without the drop shadow of course)
but as soon as i'm moving the shader file in my ressourcepack it goes

do note that i am very very new to all of this so it might be that i made something completely wrong
i'm using a custom json font in the text
thank you in advance ! :)

🤔 It shouldn't be able to do that, you get these boxes if the text can't load the font and this pack only adds a shader and doesn't mess with actual fonts at all

How does your folder structure look?
How does the other resource pack achieve the bevel and gradient effect?
Did you need to replace any files when placing NoShadows files into the other pack?

Also, communication will probably be quicker on discord, since I check it more often, feel free to message request or add puckisilver on there

sure ! i added you on discord, i'll send you more detail of how i put this together once you accepted it :)
thanks again !


Add links to the post

/cc @ai

Quote description doesn't work well because it is low contrast and was not written according the user questions.
However, the definitely should have the link to the article.


test: no cache preload in goroutine

[] Do only one thing
[] Non breaking API changes
[] Tested

What did this pull request do?

User Case Description

@jinzhu 看一下这个case，没有缓存relations的情况下goroutine中使用preload会报错


Standardize order of imports

          For the order of imports we can standardize what goes first with isort in CI and sticking to a convention.

Originally posted by @nkakouros in https://github.com/mal-lang/mal-toolbox/pull/53#discussion_r1637095298

This one surprises me a little bit because I tried to follow the PEP-8 standard. How many instances are there where this is not the case?

This was a comment I made to a commit where @mrkickling manually moved import statements around, and I suggested we automate this with isort for less cognitive load.


Support CORS headers in runtime API level

Purpose

Support CORS headers  in runtime API level

Codecov Report
Patch coverage has no change and project coverage change: -0.51 :warning:

Comparison is base (30a7a77) 32.59% compared to head (0e9c35e) 32.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1239      +/-   ##
==========================================
- Coverage   32.59%   32.09%   -0.51%
==========================================
  Files         115       73      -42
  Lines       14632     7263    -7369
  Branches     2980     4124    +1144
==========================================
- Hits         4770     2331    -2439
+ Misses       9737     4932    -4805
+ Partials      125        0     -125

Flag
Coverage Δ

adapter
?

admin-domain-service
?

backoffice-domain-service
?

devportal-domain-service
?

idp-domain-service
?

runtime-domain-service
32.09% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 188 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

does the API create response has CORS in the payload? you might need to add CORS to internal runtime api cr

does the API create response has CORS in the payload? you might need to add CORS to internal runtime api cr

Added the runtime API CR and related improvements. Now payload contains corsConfiguration.


Session/Cookie Issue

Hi! Love the template, it's been an amazing help. I have my Redis server running in dev, and added one in production with Heroku Redis. But for some reason, my production setup isn't setting cookies and when I log in, it redirects me to the home page and the user isn't authenticated.
I ran into the same issue when I was using Docker in development and switched to a local pg database. Any ideas on things to check?
@timcreative @dragosct10

Hi! @timcreative
For whatever reason, the production session is trying to use the url from the localhost. Any insight into fixing this?
Heroku Logs:
2019-11-09T17:22:06.239759+00:00 heroku[web.1]: Starting process with command npm start
2019-11-09T17:22:08.844732+00:00 app[web.1]:
2019-11-09T17:22:08.844757+00:00 app[web.1]: ><EMAIL_ADDRESS>start /app
2019-11-09T17:22:08.844760+00:00 app[web.1]: > node ./bin/www
2019-11-09T17:22:08.844761+00:00 app[web.1]:
2019-11-09T17:22:09.818497+00:00 app[web.1]: Redis error:  Error: Redis connection to <IP_ADDRESS>:6379 failed - connect ECONNREFUSED <IP_ADDRESS>:6379
2019-11-09T17:22:09.818542+00:00 app[web.1]:     at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1128:14) {
2019-11-09T17:22:09.818545+00:00 app[web.1]:   errno: 'ECONNREFUSED',
2019-11-09T17:22:09.818547+00:00 app[web.1]:   code: 'ECONNREFUSED',
2019-11-09T17:22:09.818549+00:00 app[web.1]:   syscall: 'connect',
2019-11-09T17:22:09.818551+00:00 app[web.1]:   address: '<IP_ADDRESS>',
2019-11-09T17:22:09.818553+00:00 app[web.1]:   port: 6379
2019-11-09T17:22:09.818555+00:00 app[web.1]: }


trybuild coverage miss

I see that trybuild should generate a coverage hit, but I'm having trouble getting them to hit in this MR.
(The repo (for now) uses tarpaulin, but I might move to this crate)
Expect
I expected the following  to have a hit: https://github.com/sharksforarms/deku/pull/352/files#diff-ccee6a304f8d0cb296ba83159aecd8534be0715ac4c0a3d0f1efb57e216ef490L191-L197. This should have been hit from the trybuild test @ tests/test_compile/cases/ctx_validation.stderr
$ TRYBUILD=overwrite cargo +nightly llvm-cov --workspace --doctests --release --html --ignore-filename-regex attributes

Thanks for the report!
This appears to be due to a change in the target directory in trybuild 1.0.76 (https://github.com/dtolnay/trybuild/pull/219).
I can confirm that pinning the trybuild to 1.0.75 or older and running cargo clean and then cargo-llvm-cov solves the problem.
As for the change in trybuild 1.0.76, I thought I had addressed it in https://github.com/taiki-e/cargo-llvm-cov/pull/238, but that patch didn't seem to work correctly.

This is because I had missed the fact that the directory where the test workspace was generated had also been updated.
https://github.com/dtolnay/trybuild/pull/219/files#diff-1d06da761111802c793c6e5ca704bfa0d6336d0becf87fddff02d81548a838abL150
This will be fixed in #301.

Fixed in 0.5.26.

Thanks!


syslog parsing failure when session line is one int vs two ints split by dash

For context on the system this is running on top of:

Postgres version is 11.5
Red Hat Enterprise Linux release 8.0 (Ootpa)
Postgres was compiled from source vs pulled from repos, though flags used in compilation only change directories and include additional extensions (e.g. --with-perl), nothing that I'd expect impacts logging in any way.
Logging is to rsyslog, reproduced using the default output template (Template="RSYSLOG_TraditionalFileFormat")
Relevant postgres config details:

log_destination = 'syslog'
log_duration = 'on'
log_statement = 'all'
syslog_facility = 'local1'
syslog_sequence_numbers = 'off'
syslog_split_messages = 'on'
log_line_prefix = 'S:%c N:%l T:%x V:%v E:%e %qC:%h/%u@%d/%a - %i: '

An example of from my logs:
Aug  8 03:35:01 pgdb01t postgres[8705]: [1] S:6109a690.2201 N:6228565 T:0 V:4/3114293 E:00000 C:<IP_ADDRESS>/pmm@postgres/[unknown] - idle: LOG:  statement: SELECT version();
Aug  8 03:35:01 pgdb01t postgres[8705]: [1] S:6109a690.2201 N:6228566 T:0 V:4/0 E:00000 C:<IP_ADDRESS>/pmm@postgres/[unknown] - SELECT: LOG:  duration: 0.189 ms
Aug  8 03:35:01 pgdb01t postgres[8705]: [1] S:6109a690.2201 N:6228567 T:0 V:4/3114294 E:00000 C:<IP_ADDRESS>/pmm@postgres/[unknown] - idle: LOG:  statement: SELECT name, setting, COALESCE(unit, ''), short_desc, vartype FROM pg_settings WHERE vartype IN ('bool', 'integer', 'real');
Aug  8 03:35:01 pgdb01t postgres[8705]: [1] S:6109a690.2201 N:6228568 T:0 V:4/0 E:00000 C:<IP_ADDRESS>/pmm@postgres/[unknown] - SELECT: LOG:  duration: 1.305 ms
Aug  8 03:35:01 pgdb01t postgres[8705]: [1] S:6109a690.2201 N:6228569 T:0 V:4/3114295 E:00000 C:<IP_ADDRESS>/pmm@postgres/[unknown] - idle: LOG:  statement: SELECT * FROM pg_stat_database_conflicts;
Aug  8 03:35:01 pgdb01t postgres[8705]: [1] S:6109a690.2201 N:6228570 T:0 V:4/0 E:00000 C:<IP_ADDRESS>/pmm@postgres/[unknown] - SELECT: LOG:  duration: 10.427 ms
Aug  8 03:35:01 pgdb01t postgres[8705]: [1] S:6109a690.2201 N:6228571 T:0 V:4/3114296 E:00000 C:<IP_ADDRESS>/pmm@postgres/[unknown] - idle: LOG:  statement: SELECT pg_database.datname,tmp.mode,COALESCE(count,0) as count

The relevant portion (at the end of postgres[8705]: [1] ) is causing all syslog lines to fail parsing, even where syslog (or syslog2) is specified explicitly via command-line flags.

I'll attach a pull request to fix, it's a pretty simple tweak to the regex(es) for syslog / syslog2. So far as I can tell in testing this doesn't break any existing parsing/processing, though obviously with another optional (uncaptured) group there's always the potential for an impact on parsing performance, even though I haven't seen any perceptible change in performance with the change when parsing log files I've modified specifically to match the currently expected syslog format.


Link to the old sysinternals forum is gone, suggesting link to tag search in Docs Q&A

Link to the old sysinternals forum is gone, suggesting link to tag search in Docs Q&A.

Docs Build status updates of commit 73a156d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

sysinternals/downloads/bginfo.md
:warning:Warning
View
Details

sysinternals/downloads/bginfo.md

Line 45, Column 1: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/answers/topics/windows-sysinternals-bginfo.html' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit c562d71:
:warning: Validation status: warnings

File
Status
Preview URL
Details

sysinternals/downloads/bginfo.md
:warning:Warning
View
Details

sysinternals/downloads/bginfo.md

Line 45, Column 1: [Warning-hard-coded-locale] Link 'https://docs.microsoft.com/en-us/answers/topics/windows-sysinternals-bginfo.html' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 1786907:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

sysinternals/downloads/bginfo.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


Add AUTHORS file

An authors file is needed to list and thank people who have contributed to the project.

Hi, could you quote and link docs on the AUTHORS file standard?  I'm interested in what advantages the split-out AUTHORS file has over the current authors=[...] field in setup.py or extracting authors from the git log.

More googling yielded https://opensource.google/docs/releasing/authors/, which outlines how an AUTHORS file (1) delineates who has copyrights to the open-source project and (2) creates a central place to acknowledge contributors' work.  Seems worth a look to me. Then again, git log --format=format:'%aN <%aE>' | awk '!x[$0]++' or whatever powers Github's repo insights also can shows who committed, and possibly when and how much.

AUTHORS file may be a platform-independent (git/github) alternative to acknowledge contributors' work. It is also a common, good practice in open source projects.
It looks like no SPDX repository has an AUTHORS file, so, if you are interested in, you could follow the style of the license-expression library's one, (which is maintained by tools-python's maintainer, who, by the way, suggested adding this file).

Anything remaining in this issue, which I can do?

@xavierfigueroav is this resolved or should i complete this?

@meretp Is this issue still open? It has the label of 'tech debt'.


Add additional executors, in addition to gevent (current)

Abstract excector model similar to python graphql-python/graphql-core -- allowing different executors -- like threads, asyncio, etc.

Currently working on -- see pull request #19

Awesome work so far. I am going to take what you have done and see if I can get it working with sanic which uses asyncio with uvloop.

Thanks. I haven't had much time to play w/ this the last couple weeks.  I just pushed a new commit that has an almost working version of asyncio.  About 6 transport server tests still don't pass.   I might have to change the executor model around to get those to pass...haven't had a chance to dive into it.  Also, in the asyncio transport server tests...I do use Sanic for the integration server.  Code looks like this below
def create_app(sub_mgr, schema, options, executor, sub_server):
    app = Sanic(__name__)

    app.add_route(GraphQLView.as_view(schema=schema, graphiql=True),
                  '/graphql')

    @app.route('/publish', methods=['POST'])
    async def sub_mgr_publish(request):
        await sub_mgr.publish(*request.json)
        return await response.json(request.json)

    async def websocket(websocket, path):
        if path == '/socket':
            subscription_server = sub_server(sub_mgr, websocket,
                                             executor, **options)
            await subscription_server.handle()

    ws_server = websockets.serve(websocket, 'localhost', TEST_PORT,
                                 subprotocols=[GRAPHQL_SUBSCRIPTIONS])

    app.add_task(ws_server)

    return app

def app_worker(app, port):
    app.run(host="<IP_ADDRESS>", port=port)

Now you shouldn't have to use the app.add_task method for the websocket server...I only did this because Sanic did not originally support websocket subprotocols.  I opened a an issue an couple weeks ago and they fixed it...not sure if it got pushed to master yet or not...you'll have to check. This would allow you to utilize the regular Sanic websocket decorator in lieu of the app.add_task method.  It's a little cleaner than what I did above.

Also, if you haven't yet...you might want to read the comments on this current pull request #19.  Looks like graphene will soon include support for subscriptions as an observable versus using the pubsub implementation I've done here.  I still think there will need to be some code written around integrating w/ the various python concurrency frameworks...not sure if that will be done w/ extensions or included organically in graphene.  I believe the observable will only take care of resolving the subscription...not the specific concurrency model or the subscription protocol implementation.  We'll have to wait to see when graphene 2.0 is released.

Awesome thanks. I put together something using the @app.websocket decorator, but was having trouble getting the subscriptions to completely work. Seeing your code now, I think I might be able to piece the two together and will report back if I come up with anything.
I did see the PR #19. And, I am definitely going to keep my eye on this area.

Definitely...happy to help and would love to hear any feedback.  Ideally, when I get some time, I'd still like to make the asyncio piece fully work.  If you have any insight...I'm happy to hear it.  Even with graphene eventually providing an observable based implementation...there still might be some interest in having a pubsub based alternative.
In case it's not obvious from the above code...websockets is imported globally in the module.  I modified the code above to include that detail.

I just checked and it appears websocket subprotocol support is included in the master branch of Sanic now. See here.  The tests give an example of how to use it with the websocket decorator.


Opcode Cache is 100% - How do I increase this correctly?

https://traffic.mg:22222/cache/opcache/opgui.php?page=overview
shows 100% usage:
total memory: 64.000MB
used memory: 44.552MB
free memory: 19.448MB
wasted memory: 0.000 bytes (0%)
number of cached files: 339
number of hits: 3
number of misses: 339
blacklist misses: 0
number of cached keys: 370
max cached keys: 3,907

has this file`since move /etc/php5/fpm/conf.d/05-opcache.ini does not exist in my installation so I ran ee stack install --admin and didn't help
I need to increase opcache amount as it is full

managed to nano /etc/php5/fpm/conf.d/05-opcache.ini
added
opcache.memory_consumption=512
opcache.max_accelerated_files=50000

reload stack services and it increase my opcache - that's good - but
Still can't clean opcode cache via ee clean --all
A clear step by step would be amazing