test dataset

In the actual situation, you don't know the distribution of future data.
So maybe you should split the data before the data preprocessing.

AND

You set the peakmin as sell, but should be the peakmax. The same question in setting buy point.
def setSell(idx, peaksmax, peaksmin):  for i in peaksmax:      if i[0] == idx:          return 0.0  for i in peaksmin:      if i[0] == idx:          return 1.0  return 0.0

In the part of the prediction, you insert normalize_data price but not the test set price. So you just used the prediction of test data to buy/sell the beginning of train data.
if prediction[:, 0] == max(prediction[0]):      if trade_type is None and capital > 0:          buy_invest.append((i, normalize_data["bid"].loc[i]))          trade.append((i, normalize_data["bid"].loc[i]))          trade_type = True          type_price = "buy"

Hello qxdfd,
thanks for your time and your comments. You're totally right about these two mistakes, I have pushed a fix just now. About your first advice, we indeed do not know the distribution and in a real case we must split before normalization. We don't do it in our case since we have the full dataset, and it is more effective. Our technique can't work on real markets with this data preprocessing.


Release pact410

Needs to rerun the tests to gen docs for the version update. pact-version is tied to module autogen and so is the docs.

Are we still using this? I think the new natives have to be added manually to our new docs site?


Add eslint 4 to peer dependencies

This updates the peer dependencies to accept either eslint version 3 or 4, to remove warning on install.
eslint-plugin-react does this as shown here:
https://github.com/yannickcr/eslint-plugin-react/blob/master/package.json#L38

Coverage remained the same at 71.91% when pulling cdf4daad70f3b5323a8441efc715e95dce4626fe on jrzimmerman:master into e78570f9cf0b516d4086badd2b616bcd160c2f2d on Intellicode:master.

Thanks!


Add a toggle to collapse/expand the ceval, analyse__moves and analyse__fork divs, so that explorer comes on top

Implemented as the Just Explorer theme in v2.0.21, which will hide the divs if the explorer is open, but show them if it's not


Crash on combat

UOEvolution
Win10 - Intel E5690, 48gb ram, nvidia 1060 3gb
Every time I enter combat I get the following... I have also reinstalled everything and it happens fresh.
######################## [START LOG] ########################
ClassicUO [STANDARD_BUILD] - <IP_ADDRESS> - 04/29/2022 23:55:26
OS: Win32NT x64
Thread: CUO_MAIN_THREAD
Shard: play.uoevolution.com
ClientVersion: <IP_ADDRESS>
Exception:
System.OverflowException: Array dimensions exceeded supported range.
at ClassicUO.IO.Resources.AnimationsLoader.ReadMULAnimationFrames(Int32 fileIndex, AnimationDirection& dir)
at ClassicUO.IO.Resources.AnimationsLoader.GetAnimationFrames(UInt16 id, Byte action, Byte dir, UInt16& hue, Boolean& useUOP, Boolean isEquip, Boolean isCorpse, Boolean forceUOP)
at ClassicUO.Game.GameObjects.Mobile.DrawInternal(UltimaBatcher2D batcher, Mobile owner, Item entity, Int32 x, Int32 y, Vector3 hueVec, Boolean mirror, Byte frameIndex, Boolean hasShadow, UInt16 id, Byte animGroup, Byte dir, Boolean isHuman, Boolean isEquip, Boolean isMount, Boolean forceUOP, Single depth, SByte mountOffset, UInt16 overridedHue, Boolean charIsSitting)
at ClassicUO.Game.GameObjects.Mobile.Draw(UltimaBatcher2D batcher, Int32 posX, Int32 posY, Single depth)
at ClassicUO.Game.Scenes.GameScene.DrawRenderList(UltimaBatcher2D batcher, GameObject obj, Int32 count)
at ClassicUO.Game.Scenes.GameScene.DrawWorld(UltimaBatcher2D batcher, Matrix& matrix, Boolean use_render_target)
at ClassicUO.Game.Scenes.GameScene.Draw(UltimaBatcher2D batcher)
at ClassicUO.GameController.Draw(GameTime gameTime)
at Microsoft.Xna.Framework.Game.Tick()
at Microsoft.Xna.Framework.Game.RunLoop()
at Microsoft.Xna.Framework.Game.Run()
at ClassicUO.Client.Run()
at ClassicUO.Bootstrap.Main(String[] args)
######################## [END LOG] ########################

note for dev:
i think the prblem is here: https://github.com/ClassicUO/ClassicUO/blob/dev/src/IO/Resources/AnimationsLoader.cs#L1511
some invalid animations read invalid data and try to create an huge array

I can replicate the issue locally.
It happens when encountering the big dragon.
For reference:

download uoevolution client
query the frame: id = 12, action = 20, dir = all directions
The result will point to a bad address, so when reading the frameCount it will return an huge number.

fixed.
Some entries in bodyconv.def contains bad address. CUO now nullify these addresses

Thanks! This client is awesome!


Error in condition on detecting compute / image job clash?

https://github.com/google/graphicsfuzz/blob/f2d56185ac0205d1dcf41248db1cb724bcabea88/common/src/main/java/com/graphicsfuzz/common/util/ShaderJobFileOperations.java#L571
This test is valid if a ".comp" or a ".vert" file is present, shouldn't it be a and ?
Also, why not test the presence of a ".frag" file?

Closing as too low priority for fixing.


Updated Readme

Material design expansion panel link was broken, So it was replaced by a new working link. Also need to change the one at the repo's description.

thx


[CLI] @angular-devkit/build-angular:application with dev-server should start ssr server

Which @angular/* package(s) are the source of the bug?
compiler-cli
Is this a regression?
Yes
Description
When starting dev-server with a ssr project, the builder should :

start ssr server (currently it only generate bundle)
restart ssr server whenever chunk are re-built (when file changed)

It worked very well with @angular-devkit/build-angular:ssr-dev-server and @angular-devkit/build-angular:browser in default angular 17 configuration
Please provide a link to a minimal reproduction of the bug
No response
Please provide the exception or error you saw
Just run
- ng new ssr-dev-server --ssr
- cd ssr-dev-server
- ng serve

The message Node Express server listening on http://localhost:4000 doesn't appear -> the ssr server is not started
Please provide the environment you discovered this bug in (run ng version)
Angular: 18.0.1
Node: 20

Anything else?
No response

Duplicate of https://github.com/angular/angular-cli/issues/27144


Refine batch mode code path

Why are the changes needed?

rename Metadata to SessionMetadata
wrap CloseBatchResponse for closeBatchSession
remove killApp in closeBatchSession, so every request will kill the app by default
correct when to update metadata
cleanupMetadataByAge should check state and only cleanup terminated metadata
correct the batch session state, we should never get a closed state

How was this patch tested?

[x] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

Codecov Report

Merging #2800 (777f00c) into master (9ed652e) will increase coverage by 0.02%.
The diff coverage is 75.67%.

:exclamation: Current head 777f00c differs from pull request most recent head facad17. Consider uploading reports for the commit facad17 to get more accurate results

@@             Coverage Diff              @@
##             master    #2800      +/-   ##
============================================
+ Coverage     62.85%   62.88%   +0.02%
  Complexity      202      202
============================================
  Files           480      480
  Lines         21339    21373      +34
  Branches       2833     2838       +5
============================================
+ Hits          13413    13440      +27
- Misses         6651     6658       +7
  Partials       1275     1275

Impacted Files
Coverage Δ

...in/java/org/apache/kyuubi/client/BatchRestApi.java
100.00% <ø> (ø)

...kyuubi/server/statestore/api/SessionMetadata.scala
95.23% <0.00%> (ø)

...g/apache/kyuubi/session/KyuubiSessionManager.scala
85.36% <ø> (-1.22%)
:arrow_down:

...e/kyuubi/server/statestore/SessionStateStore.scala
91.54% <62.50%> (-3.84%)
:arrow_down:

.../apache/kyuubi/server/api/v1/BatchesResource.scala
87.87% <66.66%> (+0.92%)
:arrow_up:

...e/kyuubi/client/api/v1/dto/CloseBatchResponse.java
72.22% <72.22%> (ø)

...g/apache/kyuubi/operation/BatchJobSubmission.scala
84.95% <77.14%> (-2.28%)
:arrow_down:

...a/org/apache/kyuubi/operation/OperationState.scala
44.44% <100.00%> (+1.58%)
:arrow_up:

...kyuubi/server/statestore/jdbc/JDBCStateStore.scala
89.01% <100.00%> (+1.27%)
:arrow_up:

...apache/kyuubi/session/KyuubiBatchSessionImpl.scala
95.55% <100.00%> (ø)

... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ed652e...facad17. Read the comment docs.

thanks, merging to master

thank you all !


Fix skipping of PrimitiveGroups in ST_ReadOSM

Currently ST_ReadOSM is only reading the first 'PrimitiveGroup' per 'PrimitiveBlock'.
When the parsing loop seeks to the granularity/offset fields, it advances the block_reader position beyond any unprocessed groups, causing them to be missed.
By making a copy of block_reader, we can grab the granularity/offsets without messing up the real one.
This also makes sure we only have to read the values once per block.
Fixes #349.

Hi! Thanks for digging in to this and fixing it, really appreciated! LGTM.

Thanks for the fix! Do you know when this fix would be released? Is there a preview version I can test with?

Never mind! available in the nightly build
https://github.com/duckdb/duckdb_spatial/issues/349#issuecomment-2335011589


Fix truncated focus on checkbox for accessiblity

This PR fixes #15773
The truncated checkbox in SQL Migration extensions' Assessment Dialog table can be fully focused using keyboard tabs.
Override default checkbox margins (PR#15014)
Ensured changes don't modify the checkbox/check all used in other parts of code. This component is currently used by Modify Columns in the Import extension  (PR#10751)
Before:

After:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 42.736%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
26166

Relevant Lines:
55605

💛  - Coveralls


NPM test fixes + Azure Pipelines

 Fixing npm tests and reporting for clean signal on azure pipelines
What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:
Release note:

NONE

/lgtm

/azp run

/azp run

/azp run


[Adaptive] getProperty prebuilt function or dynamic index does not work

@boydc2014 @luhan2017
Our Todo bot sample uses this approach and this does not work in master.
The goal is that we need this -
user.lists = {
    "todo": [
        "one",
        "two"
    ],
    "shopping": [],
    "generic": []
}

The following C# code does not work -
var rootDialog = new AdaptiveDialog(nameof(AdaptiveDialog))
{
    Generator = new TemplateEngineLanguageGenerator(),
    Triggers = new List<OnCondition>()
    {
        new OnConversationUpdateActivity()
        {
            Actions = WelcomeUserAction()
        },
        new OnIntent() {
            Intent = "GetUserProfile",
            Actions = new List<Dialog>() {
                new InitProperty() {
                    Property = "user.lists",
                    Type = "object"
                },
                new SetProperty() {
                    Property = "$listName",
                    Value = "'todo'"
                },
                new InitProperty() {
                    // Alternatively getProperty(user.lists, $listName) does not work either
                    Property = "user.lists[$listName]",
                    Type = "array"
                },
                new EditArray() {
                    // Alternatively getProperty(user.lists, $listName) does not work either
                    ItemsProperty = "user.lists[$listName]",
                    Value = "'one'",
                    ChangeType = EditArray.ArrayChangeType.Push
                },
                new SendActivity() {
                    Activity = new ActivityTemplate("I have '{join(user.lists[$listName], ', ')}'")
                }
            }
        }
    }
};

Expected:
    I have 'one'

Actual:
      Exception caught : Error occurs when evaluating expression $join(user.lists[$listName], ', '): user.lists[$listName] evaluates to  which is not a list.

Currently dynamic property is not support in "InitProperty" and "SetProperty". Maybe we can open an issue to discuss it?

Currently dynamic property is not support in "InitProperty" and "SetProperty". Maybe we can open a DCR to discuss it?

@Danieladu is this treated as an expression in SDK?

This seems like a regression since the sample probably was this way. The LUIS Todo bot sample.. What am I missing?

This seems like a regression since the sample probably was this way. The LUIS Todo bot sample.. What am I missing?

Yes, the property is reverted from expression to string, by this commit. https://github.com/microsoft/botbuilder-dotnet/commit/fc900079
I think we should bring it back, I will prepare a PR on this. @vishwacsena, you can double check with Tom is there a specific reason for the Property to be a string instead of expression.

Yes please prep a PR. @tomlm can you provide context into the change?

@vishwacsena , let's make it all consistent. currently all the following properties are string, Let's make it all expressions. I will prepare a pr on this.

InitProperty->Property
SetProperty->Property
DeleteProperty->Property
Foreach->itemsProperty
ForeachPage->itemsProperty, pageSize

I vaguely remember Tom falling about Property being a memory path and not an expression but that gets in the way of dynamic properties like in this case. @tomlm - thoughts on how we should address this? You ok with moving these back to expression?

#2773

I verified the scenario of todoluis bot which is provided by Vishwac at the beginning of the dialog. it is still not working. @vishwacsena you can help double check on this.
@tomlm, if the sample is wrong, please let us know the correct way to use that.
Based on my investigations, I think the problem might be

in ObjectPath, bot the SetPathValue and GetPathValue and RemovePathValue should handle the "bracketPath", should we add a shared ResolvePath function?
bracketPath can only resolve path within the current object scope, when I use dialog.name[user.name], it is still not working correctly.

@cwhitten , this is an advanced usage for the SetProperty, I think we can remove the 4.6 tag in composer, because I think it is not a blocking for Ignite, agree on this?

#2818 PR is out

I verified in Tom's branch, it is working now.


Wall-clock profiling in containers

In https://github.com/jvm-profiling-tools/async-profiler#profiling-java-in-a-container a work-around for the limitations in containers is described: enabling itimer profiling mode.
My question is whether there's something similar for wall-clock profiling. Or should wall-clock profiling already work within containers?

Limitations apply only to the events collected through Linux perf counters API:
https://github.com/jvm-profiling-tools/async-profiler/blob/2557363892b7f83dec4c652ca1b19e50e21877e4/src/perfEvents_linux.cpp#L234-L252
-e wall and other profiling modes should work in a container with no additional requirements.


Unknown or Invalid instance during login with custom cloud

az feedback auto-generates most of the information requested below, as of CLI version 2.0.62

Describe the bug
Azure-adal (on which azure-cli depends, and uses for auth) defines a static list of authority servers here. It then uses this list here to limit the authority servers used for discovery. Why is this a problem? If I register a custom cloud using az cloud register ... with a custom authority server, az login fails with the error
Instance Discovery request returned http error: 400 and server response: {
  "error": "invalid_instance",
  "error_description": "AADSTS50049: Unknown or invalid instance.\r\nTrace ID: d4f1f445-d340-4f65-a0ec-f7e384560000\r\nCorrelation ID: 1e59253d-4595-4082-9daf-6e85c3b73313\r\nTimestamp: 2019-09-23 21:37:56Z",
  "error_codes": [
    50049
  ],
  "timestamp": "2019-09-23 21:37:56Z",
  "trace_id": "d4f1f445-d340-4f65-a0ec-f7e384560000",
  "correlation_id": "1e59253d-4595-4082-9daf-6e85c3b73313",
  "error_uri": "https://login.windows.net/error?code=50049"
}

This occurs after the oauth flow has been completed and the access tokens returned, and seems to be related to account (capability?) discovery
I've opened a similar issue against AzureAD/azure-activedirectory-library-for-python, here and was told that python-adal supports custom authority servers, and I should try opening one here.
To Reproduce
Register a custom cloud using
az cloud register \
    -n customCloud \
    --endpoint-resource-manager "https://example.com" \
    --suffix-storage-endpoint "blob.example.com" \
    --endpoint-active-directory "https://example.com"

Attempt to login
az login

Expected behavior
login to complete successfully
Environment summary
Linux-5.2.13-arch1-1-ARCH-x86_64-with-arch
Python 3.7.4
Shell: fish

azure-cli 2.0.70 *

Extensions:
storage-preview 0.2.8

Additional context
Add any other context about the problem here.

AuthenticationContext is created at https://github.com/Azure/azure-cli/blob/1beb6352ece2d06187bbccd66f1638f45b0340f7/src/azure-cli-core/azure/cli/core/_profile.py#L97
What is URL for --endpoint-active-directory you have registered? It will be examined at https://github.com/Azure/azure-cli/blob/1beb6352ece2d06187bbccd66f1638f45b0340f7/src/azure-cli-core/azure/cli/core/_profile.py#L84 to decide the value of is_adfs.

AuthenticationContext is created at https://github.com/Azure/azure-cli/blob/1beb6352ece2d06187bbccd66f1638f45b0340f7/src/azure-cli-core/azure/cli/core/_profile.py#L97
What is the URL for --endpoint-active-directory you have registered? It will be examined at https://github.com/Azure/azure-cli/blob/1beb6352ece2d06187bbccd66f1638f45b0340f7/src/azure-cli-core/azure/cli/core/_profile.py#L84 to decide the value of is_adfs.

something in the format of https://manage.blob.local

@jiasli Any update on this?

Yes. Currently the URL needs to end with /adfs to disable verification. Is there any factor that is preventing using this URL?

Works perfectly, Thanks!


Question: opt-out of refetch when variables change

Hi,
I'm using useLazyQuery that I manually (re-)trigger when a user presses a button. I have the problem that the query is also re-triggered automatically whenever one of the reactive query variables change.
Is there any way to prevent this?
Thanks in advance

I have the same question i cant seem to find anything in the Apollo client docs about this.
using non reactive variables disables this though, but that's not ideal having to copy reactive vars into a regular ts variable every time.
it also has the side effect of bypassing the cache and hitting the server every time no matter the fecthPolicy


<EMAIL_ADDRESS>navcontroller.push page not working

Short description of the problem:
If you push a detailpagina on a tabspage, the detailpage overlaps the tabs, which isn't meant to. You can set the css of the ion-tabbar to an z-index of 1000, then the tabs will stay, but if you then click on another tab, the content of the detailpage stays visible instead of the content of the chosen tab.
What behavior are you expecting?
Correct behaviour of the tabs
Steps to reproduce:

ionic start testtab --v2
add a button which pushes the detailpage on a tab
ionic serve

goToDetail() {
	  this.nav.push(Detailpage);
	}

Which Ionic Version? 2.x
Plunker that shows an example of your issue
http://plnkr.co/edit/IYhrIxIx7I17zi9V3H2y?p=preview
Run ionic info from terminal/cmd prompt: (paste output below)
Your system information:
Cordova CLI: 5.4.1
Gulp version:  CLI version 3.9.0
Gulp local:   Local version 3.9.1
Ionic Framework Version: 2.0.0-beta.10
Ionic CLI Version: 2.0.0-beta.31
Ionic App Lib Version: 2.0.0-beta.17
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Mac OS X El Capitan
Node Version: v5.3.0
Xcode version: Xcode 7.3.1 Build version 7D1014

This is the desired behavior for md mode. To change this you can set tabSubPages to false. Note: this property has been renamed for beta 11 to tabsHideOnSubPages (see https://github.com/driftyco/ionic/issues/7143).
Please see the config docs for more information on setting these properties: http://ionicframework.com/docs/v2/api/config/Config/
There is also a table further down with descriptions of each property.


chore: smtp slack template and vulnerability fix

PR summary
PR includes changes for slack template, SMTP configuration and also vulnerability fixes
Fixes: https://github.ibm.com/Notification-Hub/planning/issues/13028
https://github.ibm.com/Notification-Hub/planning/issues/13037
https://github.ibm.com/Notification-Hub/planning/issues/13639
PR Checklist
Please make sure that your PR fulfills the following requirements:

[x] The commit message follows the Angular Commit Message Guidelines.
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] New tests
[x] Build/CI related changes
[ ] Documentation content changes
[ ] Other (please describe)

What is the current behavior?
support for slack template and direct SMTP configuration for email does not exist
What is the new behavior?
support for slack template and direct SMTP configuration for email
Does this PR introduce a breaking change?

[x] Yes
[ ] No

TemplateConfig is changed to TemplateConfigOneOfEmailTemplateConfig for email and TemplateConfigOneOfSlackTemplateConfig for slack.
Other information

:tada: This PR is included in version 0.5.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


[Question] Web app with separated html, css and js files instead of single-page app?

I like tinode and the web app client, but I think it would be easier to extend and maintain if the code would be separated in html / template, css and js files instead of a single-page app?
If other people interested in such a web app and maybe could help with testing and comits I could take a look into tinode.js, do some tests and start it. I don't know if I have the time and experience to finish it, but I would give it a try.

CSS is already separated into a file. As for separating js from html, Generally React expects components to have js and html in one file: https://reactjs.org/docs/introducing-jsx.html
On the other hand I agree that a single file is inconvenient. I've split it into components in i18n branch: https://github.com/tinode/webapp/tree/i18n/src
I would certainly support efforts to simplify or otherwise improve the app.

If I start to build it, I wouldn't use react because I don't know it...
I would try to build it as simple as possible with some small js libs and html.
If each html snippet is only in one place it should be easier to understand and work with.

React is not bad. It's quite convenient for building large js apps and it's well supported. I also did not know it before I started with this project.


default num_classes value for one_hot

If num_classes is set to -1, the number of classes will be inferred as one greater than the largest class value in the input tensor.

Merged, actually the easiest $50! email<EMAIL_ADDRESS>with a PayPal or USDC (on ethereum) to claim


Add support for replicate_source_db variable

Describe the Feature
Currently, this module cannot be used to create a read replica, as the replicate_source_db variable is not exposed. cloudposse/terraform-aws-rds-replica seems to be the alternative, but hasn't received any updates in over two years.
Use Case
Using this same module both for creating a RDS primary database, and its read replicas.
Describe Ideal Solution
Add the replicate_source_db variable in this module, and consider if there are variables that only must be provided to the aws_db_instance resource when this option is used.
Alternatives Considered
cloudposse/terraform-aws-rds-replica seems to be the alternative module provided by CloudPosse, but hasn't received any updates in over two years.

@adamantike have you been able to use the other module to create a read replica ?
If we add replicate_source_db variable to this module (and other inputs when this is used), would that not render the other module obsolete ?

@nitrocode, I think it will! However, that module hasn't been updated in more than two years, so it makes sense to either update it with all the same feature this module currently provides (plus, support for newer Terraform versions), or centralize both functionalities here.
As stated in [aws_db_instance docs][https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/db_instance]:

NOTE: Removing the replicate_source_db attribute from an existing RDS Replicate database managed by Terraform will promote the database to a fully standalone database.

So, promoting replicas would be simpler just by using the same module, and not requiring Terraform state reimporting.


Add abntex2.cls

Hi! Could you please add the abntex2 package?
https://www.ctan.org/pkg/abntex2
biblatex-abnt would also be useful
https://ctan.org/pkg/biblatex-abnt

@piraka9011 thanks for the reference; added the package. I'll wait for the docker to build and re-launch the deployment.

Also, this is included in the latest https://texlive2020.latexonline.cc deployment.


Fix for lazy constructor for TransferManager for extension method

Also fix for samples for the pause API rename

API change check
API changes are not detected in this pull request.


More Robust Quoted Strings

Hey Steve,
I wanted to share this work with you, in case you found it useful. Please ignore/reject it if you don't find that it fits with Penlight's goals.
This pull request includes stringx.quote_string and changes to pretty.write. quote_string wraps a string such that reloading that string from a chunk of Lua code produces identical results:
mystr = "\n[[\n My tricky ]======] string.\n]]"
mystr2 = load("return " .. stringx.quote_string(mystr))()
assert(mystr == mystr2)

It provides the same facilities as ("%q"):format(str), plus:

Uses long quotes when it finds a pattern that matches the long-quote pattern (begin or end, balance doesn't matter) or when it finds a \n.
Adds an extra \n at the beginning, if found.
When Long quotes are used, it always uses a number of = signs that is one greater than any long-quotes that are embedded into the string.

The second, and highly related, changes were to pretty.write:

Uses stringx.quote_string instead of internal, literal methods.
Adds a space in front and in back of string, when long strings are used for key values:

my_table = {
    [ [[
My crazy key
]] ] = "foo"
}

Because of the first change, now embedded long-strings can round-trip through the pretty printer. Nested long-strings would not compile in Lua.

Finally, a small patch was added for pretty.number:

Added check for Lua 5.3. Locally patched tostring so that it returns 123 instead of 123.0. Without this patch, pretty.number was broken.

I also added tests and local function documentation, although this should be re-read and verified before accepting.

Thanks, Andrew - I like robust at the moment!

Locally patched tostring so that it returns 123 instead of 123.0

It even returns 123 when formatting 123.456, neat.

On Mon, Jul 18, 2016 at 12:24 PM, Peter Melnichenko <
<EMAIL_ADDRESS>wrote:

It even returns 123 when formatting 123.456, neat.

This is definitely more aggressive rounding than we need ;)


Feature request: Display deck modification after editing a deck

It would be great if, after having made some modifications to a deck online in the "My decks" section, we saw a list of all modifications done. This would help to after redo those modification to a physic deck.
Exemple:
Changes so far:
+1 Faust
+1 Amped Up
-1 Eater
-1 Wanton Destruction
This automatically while doing modifications to the deck or after hitting save. With green and red color for +s and -s respectively.

Isn't that for the "History" tab is for?

This is my bad. I didn't see. How to close this thing..?


Fix GdUnit4MonoAPI.cs IsTestSuite cannot run TestSuite

hi @ZerxZ,
looks like you fixed already https://github.com/MikeSchulze/gdUnit4/issues/350 ;)
let me check

You are right, it created a new bug issue to cover this bug,

continue on https://github.com/MikeSchulze/gdUnit4Mono/pull/41


Update parse_tree_builder.py

List function is not required, and rule check in callback dict should be after loop

Hello! Thanks for the PR. You're right about moving the rule check up in the loop. But I prefer that you avoid changing lines only for cosmetic reasons, especially when it's very subjective, like removing blank lines that separate code blocks.

Revert changing lines changes.

@erezsh Thanks. Understood the reason behind calling list(). I'm closing this PR.

@jmishra01 You can re-open with just the rule-check. I'll be happy to merge that in.


How and where do I put blacklisted tags?

Very noob question but I genuinely do not know where to input blacklisted tags. I saw a blacklist.txt in the options folder and tried putting my blacklisted tags there but it didn't seem to work. I saw a screenshot from 2018 of a blacklist popup window, but that's from a really old and outdated version of Grabber so that's useless.

Hello 👋
You can directly put your blacklisted tags directly in the settings, in the "Blacklist" part.


[Feature]: Add support of the iterator protocol (es6) for v-for directive

Hi
I has modified "Quick example" with using the Iterator protocol.
Will be great if it will work in 1.0 version for es6 environments.
Useful links:
https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Iteration_protocols
http://www.2ality.com/2015/02/es6-iteration.html

Does this suggestion break the Vue concept that $data should be JSON.stringify-able?

I'd like to see a convincing use case for supporting this because this involves non-trivial addition to the observation mechanism.

because this involves non-trivial addition to the observation mechanism.

Maybe this helps
var array1 = [{a:1},{b:2}];
var set = new Set(array1);

if (Symbol.iterator in set) {
    var array2 = Array.from(set);
    console.log('array2=', array2); // [{a:1},{b:2}]
}

console.log('array1 === array2', array1 === array2); // false

http://jsfiddle.net/ywzdank1/

I'd like to see a convincing use case for supporting this

iterable is new general thing for js
I think Angular2 will be support it.

@nervgh these are not use cases. Angular 2 supporting it is cool, but what is a scenario that requires your UI state to be a Set or a Map?

Closing because:

I don't think there are cases where it's necessary to use Set or Map to represent UI state;
They are JSON serializable;
The benefits doesn't justify the amount of work needed to properly support them, especially when they are not available in every browser.

@yyx990803 Here is a valid use case that supports the need for a set.
var app = new Vue({
    el: '#app-contact',
    data: {
      name: null,
      email: null,
      phone: null,
      company: null,
      touched: new Set()
    },
    computed: {
      isValid: function () {
        return {
          disabled: (this.name === null || this.email === null || this.phone === null || this.company === null)
        }
      }
    },
    methods: {
      focused: function (key) {
        this.touched.add(key);
      },
      valid: function (key) {
        if (!this.touched.has(key)) {
          return null;
        }
        return (this[key] !== null && this[key] !== "");
      }
    }
  });

I don't want the fields to initially be displayed as invalid on the UI, I add a class to show an input as a valid or invalid element.  The element is only marked as valid or invalid once it is brought into focus, and marked as touched.  I don't want to have a potentially massive array containing all the times an input has been brought into focus, so the Set would be ideal.

@kyle-mccarthy Why not this?
const keys = [
  'name',
  'email',
  'phone',
  'company'
]
const data = keys.reduce(
  (obj, key) => {...obj, [key]: {val: null, touched: false}},
  {}
)
const app = new Vue({
  el: '#app-contact',
  data: data,
  computed: {
    isValid () {
      return {
        disabled: keys.map(key => this[key])
          .some(field => field.value === null)
      }
    }
  },
  methods: {
    focused (key) {
      this[key].touched=true
    },
    valid (key) {
      const field=this[key]
      if (field.touched) {return null}
      return field.val !== null && field.val !== ''
    }
  }
})

+1 for implementing this. I have a tree data structure with an iterator, converting to arrays would result in large, unnecessary overhead.

What's the state of this issue now?

Maps/Sets are useful stuctures. It's urgent to support them in Vue, otherwise it'll be inefficient to use them in Vue apps.

very weird issue. If you support Objects then it's only consequent to also support Maps and Sets for exactly the same reason.

any progress?

I have a custom collection class, that has an iterator, and I can not loop over it with v-for

@yyx990803 Iterator protocol isn't just for Set, etc. I want to use flatbuffers for data (which is, of course serializable, as you mentioned that), over which I can use a custom iterator. The point is vue need not be opinionated about in what data structures data is stored, as we have the iterator protocol.

This is already supported in 2.6.


Mafia's machine gun animation glitchy

its machine gun is really, really, powerful!
https://youtu.be/i1WGK7vL8jo

asset issue D:

assset issue basically


Port improvements from dotty/12174

https://github.com/lampepfl/dotty/pull/12174

@nicolasstucki Any news on this one? 🙂

Someone should try to update the community build version of propquill in the dotty project submodules.


[Task] Collect data from response headers.

Question
When I want to get  token from Huawei Cloud by post, the token will in the headers of the response, so how to get it from response headers and use it for subsequent monitoring?

I would like to help


deploy gce instances with ssh public key, when specified.

when ssh public key is specified, deploy gce instance with ssh-key metadata. ssh key is important to access gce instance, use private key to establish ssh connection.

Lint report for commit 3994bb1403d17f5fe63b715abc72d71df8583a59:
mgmtsystem/google.py:

:bangbang: Line 347:21: E126 continuation line over-indented for hanging indent
:bangbang: Line 349:17: E121 continuation line under-indented for hanging indent

Please, rectify these issues :smirk: .
No commit flaws detected.
CFME QE Bot

Lint report for commit a6207b7e8d63efe0504f59e04ad4c0779cf5f5fd:
Lint OK! :cake: :punch: :cookie: .
No commit flaws detected.

CFME QE Bot

Approved, but I was going to include it and the previous one in the same release.....so I'll merge it, but I won't release a new version till then.


Obligations

Added EN/FR requirements
Created Obligations component to display requirements based on level
TODO:

Fix format
Fix bold terms
Fix multiline entries

Source of data is: http://www.tbs-sct.gc.ca/pol/doc-eng.aspx?id=32592#appC
Fixes #33

@e-wu I've used the same method you used for the Results.vue page but I didn't include in .
MIght help with the formatting, what do you think?
@CalvinRodo I think this is ready to merge for now but additional work will be needed to prettify.

OK, so moved the content in a <details> element. It's much cleaner.
Still haven't fixed the format  issue and I haven't removed the html tags <strong> in the json.
Good to merge for v.0.4 though and deploy on gh-pages

Thanks!
Le sam. 13 avr. 2019 20 h 51, Calvin Rodo<EMAIL_ADDRESS>a
écrit :

Merged #44 https://github.com/canada-ca/aia-eia-js/pull/44 into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/canada-ca/aia-eia-js/pull/44#event-2274488969, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABnJ5TP_uipoqWbXjkJXjVUS-DkRUKaBks5vgnt5gaJpZM4ct2RZ
.


unable to invoke functions - getting function not found...

Describe the bug
I'm running an express server with netlify functions, using serverless-HTTP to wrap the express app into a format netlify wants, however, every time I try to run /api/test i get 'function not found...'
Configuration

[build]
  # Directory to change to before starting a build.
  # This is where we will look for package.json/.nvmrc/etc.
  # If not set, defaults to the root directory.
  #   base = "project/"

  # Directory that contains the deploy-ready HTML files and assets generated by
  # the build. This is relative to the base directory if one has been set, or the
  # root directory if a base has not been set. This sample publishes the
  # directory located at the absolute path "root/project/build-output"
  publish = "public/"
  functions = "netlify/functions/"
  command = "npm run build"

  # Log Default build command.
  # command = "echo 'default context'"

# note: each of these fields are OPTIONAL
[dev]
  command = "npm run develop" # Command to start your dev server
  targetPort = 8000 # The port for your application server, framework or site generator
  port = 3000 # The port that the netlify dev will be accessible on
  publish = "public" # The path to your static content folder
  # jwtSecret = "secret" # The secret used to verify tokens for JWT based redirects
  # jwtRolePath = "app_metadata.authorization.roles" # Object path we should look for role values for JWT based redirects
  autoLaunch = true # a Boolean value that determines if Netlify Dev launches the local server address in your browser
  # to start an https server instead of an http one, configure a certificate and key files
  # [dev.https]
  #   certFile = "cert.pem" # path to the certificate file
  #   keyFile = "key.pem" # path to the private key file
`

npx envinfo --system --binaries --npmPackages netlify-cli --npmGlobalPackages netlify-cli

Expected behavior
when I call localhost:3000/api/test the function should run
CLI Output
If applicable, add the CLI output to help explain your problem.
Additional context
netlify/functions/functions.js has the following

const https = require('https');
const path = require('path');
const fs = require('fs');
const serverless = require('serverless-http');
const app = require('./src/server');

app.listen(3000, () => console.log('HTTP server listening: http://localhost:3000!'));

// HTTPS server
const httpsServer = https.createServer({
  key: fs.readFileSync(path.join(process.cwd(), 'netlify/functions/src/', 'server.key')),
  cert: fs.readFileSync(path.join(process.cwd(), 'netlify/functions/src/', 'server.cert')),
}, app);
httpsServer.listen(443, () => console.log('HTTPS server listening: https://localhost:443'));

exports.handler = serverless(app/* {debug: true} */);
``

in netlify/functions/src/server.js
`
const express = require('express');
const path = require('path');
const axios = require('axios');

const app = express();
const bodyParser = require('body-parser');
const text = require('textbelt');
const http = require('http');
const fs = require('fs');
const socketIo = require('socket.io');

// read and apply variables that are sensitive based on the context .env
const dotenv = require('dotenv').config({
  path: `${process.cwd()}/.${process.env}.env`,
});

const cors = require('cors');
const contentSecurityPolicy = require('helmet-csp');
const helmet = require('helmet');
const session = require('express-session');
const rateLimit = require('express-rate-limit');

// basic ddos protection
const limiter = rateLimit({
  windowMs: 60 * 60 * 1000, // 60 minutes
  max: process.env.NODE_ENV === 'production' ? 40 : 10000, // limit each IP to 40 requests per windowMs (per hour)
});

/* app.use(
  session({
    secret: 'ajgardencare#$#^#@#$2342',
    saveUninitialized: false, // consult documentation
    name: 'sessionId',
  }),
);
*/
/* app.use(
  session({
    name: "session",
    keys: ["key1", "key2"],
    cookie: {
      secure: true,
      httpOnly: true,
      domain: "example.com",
      path: "foo/bar",
      expires: new Date(Date.now() + 60 * 60 * 1000), // 1 hour,
    },
  })
); */

/**
 *  app.use(
    session({
      name: COOKIE_NAME,
      store: new RedisStore({
        client: redisClient,
        disableTouch: true,
      }),
      cookie: {
        maxAge: 1000 * 81600 * 365,
        httpOnly: true,
        sameSite: "lax",
        secure: false, // TODO change to true when prod
      },
      secret: "HARDCODED-SECRET", // TODO
      resave: false,
      saveUninitialized: false,
    })
  )
 */

app.use(helmet());
const corsOptions = {
  // origin: 'http://localhost:8000',
  origin: '*',
  credentials: false,
  methods: 'GET,POST',
  optionsSuccessStatus: 200, // some legacy browsers (IE11, various SmartTVs) choke on 204
};
app.use(limiter); //  apply to all requests
const httpServer = http.createServer(app);
const io = socketIo(httpServer);
io.on('connection', (socket) => {
  console.log('A client connected', socket.id);
});

process.on('unhandledRejection', (err) => {
  console.error('unhandled promise rejection detected');
  console.error(err);
  process.exit(1);
});

app.use(bodyParser.urlencoded({ extended: false }));
app.use(bodyParser.json());
app.use('/.netlify/functions/server', router); // take netlify functions path and point to router

app.use('/api/test', (req, res) => {
  const {
    body, headers, readable, rawTrailers, socket, secure, subdomains, statusMessage, complete, fresh, ip, method, originalUrl, params, protocol, query,
  } = req;
  res.write(JSON.stringify({
    message: 'you sent this information',
    body,
    headers,
    complete,
    fresh,
    ip,
    method,
    originalUrl,
    params,
    protocol,
    query,
    rawTrailers,
    readable,
    secure,
    // socket,
    subdomains,
    statusMessage,
  }, null, 2));
});

exports.app = app;
`

Screenshots
I'm really uncertain what's not working, is something wrong with serverless-http?

Hi @AidenFaulconer! I tried reproducing this locally, and found a couple of things:

the shared instructions expect routes under the /api baseurl, but Netlify defaults to /.netlify/functions as the baseurl
You can change this by adding the following rewrite to your netlify.toml:

[[redirects]]
  from = "/api/*"
  to = "/.netlify/functions"
  status = 200

functions.js, while using the serverless-http package to adapt the express server, also tries app.listen to startup a full internal HTTP server. This will not work with Netlify Functions, and crashes in local development. Try removing those lines, as Netlify will deal with the HTTP serving aspect of Functions for you.

After doing that, the app will still crash because the router variable is missing in src/server.js, but that should be a good starting point for you.

Hi @AidenFaulconer, I hope the comment pointed you in the right direction. I'll close the issue for now, feel free to comment here if the problem persists, and we'll reopen it.


Unable to deploy Python

Details of the scenario you tried and the problem that is occurring
I am trying to distribute Python using the same pattern as I have successfully distributed other applications - but it is not working. I have tried running remediation tasks which complete successfully however when I run a
Get-GuestConfigurationPackageComplianceStatus against the package it continues to show as not compliant
Start-GuestConfigurationPackageRemediation when run locally will execute the install without issue
My configuration is below
As above, I can compile, create the package and policy without issue. It works when run locally
Verbose logs showing the problem
n/a
Suggested solution to the issue
The DSC configuration that is used to reproduce the issue (if applicable)

Configuration Install
{
    Import-DscResource -ModuleName Microsoft.WinGet.DSC

    node localhost
    {
        WinGetPackage Python.Python.3.10
        {
            Id = 'Python.Python.3.10'
            source = 'winget'
            InstallMode = 'silent'
        }

    }
}

$appName = "Python3"
$version = "v1"
Install -OutputPath .\CompiledMOF\${appName}_${version}

The operating system the target node is running

Microsoft Windows [Version 10.0.22631.4037]
Version and build of PowerShell the target node is running

Name                           Value

PSVersion                      7.4.4
PSEdition                      Core
GitCommitId                    7.4.4
OS                             Microsoft Windows 10.0.22631
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0
Version of the module that was used

Name               Version Path

GuestConfiguration 4.5.0   C:\Program Files\WindowsPowerShell\Modules\GuestConfiguration\4.5.0\GuestConfiguration.psd1

Updated post as incorrectly used the template and did not show detail - sorry!


Is there any plan for supporting v5?

I hope this plugin support v5 because I'm using this plugin a lot!
Is there any plan to support v5?

https://github.com/pixijs/pixi.js/pull/5706 - that's part of pixi-heaven, now it goes to v5. I will publish pixi-heaven for v5 as soon as this thing gets released.
What parts of heaven do you use, dark-light tint and masks?

I use only dark-light tint. And I wander if there's any performance pitfall using both vanilla PIXI.Sprite and heaven.Sprite.

I didnt measure it, but theoretically it should be almost the same.

Ok thanks for instant reply ivan!

Btw, dark-light tint and ColorMatrixFilter are look wrong without sRGB<->linear conversion. I want to add it in a month or two :)

@rkdrnf done.  two-tint works, masks are not.

so this heaven plugin can be basically import in babel and typescript environment in v5.1?

@jjhesk
all typescript pixijs plugins have the same problem with ES6 imports: they require global PIXI:
import * as PIXI from "pixi.js";
global.PIXI = PIXI;
require("pixi-heaven "); //or import it

We dont have a way to build TS plugin that works both with vanilla JS and ES6 modules :(


Make rayon optional

This allows compilation on systems that do not currently support rayon or its dependencies, such as Redox

Thanks for the pr, it looks good to me.
The travis nightly failure is rust-lang/rust#37786.
I'm gonna push a change allowing nightly to fail on CI.

After you add FEATURES="rayon" to the FEATURES matrix in .travis.yml it is ready for merging.

@kaksmet It should be done now

@jackpot51 sorry for not being clear enough. I want travis to test both with and without the rayon feature. For that to happen there should be both an empty FEATURES and one containing "rayon".
This is what I would like the relevant piece of travis.yml to look like:
env:
  - FEATURES=""
  - FEATURES="rayon"

Looks good, thanks!

Thanks for merging!


overloaded %x% operator

Loading the package in a fresh environment currently yields:
> library(gpe)

Attaching package: ‘gpe’

The following object is masked from ‘package:base’:

    %x%

which is ugly.
This is because the Kronecker operator %x% is overwritten in gpe and reverts to the base version if the object is not a gpe kernel object. gpe also uses the function kron() for it's kernel kronecker operator, rather than the generic kronecker()
There must be a better way of overloading kronecker() than this!
Since %x% is defined as:
function (X, Y) kronecker(X, Y)

overloading kronecker() should be sufficient.

Hmmm...
There is an S4 generic methods::kronecker.
There is a non-S4 function base::kronecker which calls methods::kronecker if X and Y are S4 objects. If not, it calls .kronecker (also in base) which is not S4....
%x% is base, so calls base::kronecker which calls .kronecker. So we can't  just overload the S4 generic methods::kronecker, we need to deal with %x% too.
It would be great to overload the S3 %x% for our kernel class (to call methods::kronecker, or just skip straight to the real code), but it seems that %?% operators can't be overloaded.
Gnnnh.

It looks like it is not possible to provide a working implementation of the %x% operator, without the startup message. However kron can be replaced with kronecker , as implemented in c0e9ce3. Closing the rest of this issue now as it seems to be a limitation in R as currently implemented

Adding a method for the S4 generic kronecker ruined the docs, because this: http://stackoverflow.com/questions/18604549/documenting-and-exporting-an-s4-generic-method-that-already-exists-in-base
So it's archived in the kronecker_bullshit branch and I reverted back to using the separate kron.
That was a fun afternoon.


A problem with Tardis BYBIT data.

So i am trying to wok with data from Tardis. So far, all the binance-futures data from Tardis was correct and worked nicely. But now i am working with Bybit and got stuck. First i tought something is wrong with my strategy but more in depth research actually showed that it has something to do with the data itself. Maybe it is converted not correctly, or maybe it contained mistakes from the start at Tardis.
So here is what i get with simple setup:
@njit
def test(hbt):
    tmp = np.empty((100_000_000, 3), np.float64)
    i = 0
    while hbt.elapse(60_000_000):
        hbt.clear_last_trades()
        tmp[i] = [hbt.current_timestamp, hbt.best_bid, hbt.best_ask]
        i += 1
        if i > 100:
            break
    return tmp[:i]

Output:
Load data/bybit/BCHUSDT/_2023-07-02.npz
bybit-BCHUSDT_Depth-5_Start-20230702-End-20230819
291.125 291.125
291.125 291.125
291.125 291.125
291.125 291.125
291.125 291.125
291.125 291.125
291.125 291.125
291.125 291.125
291.125 291.125
291.125 291.125

When i switch to binance-futures, it spits out actual prices:
Load data/binance-futures/BCHUSDT/_2023-07-02.npz
binance-futures-BCHUSDT_Depth-5_Start-20230702-End-20230819

282.83500000000004<PHONE_NUMBER>0000004
282.725 282.725
282.115 282.115
282.165 282.175
281.705 281.705
280.83500000000004 280.845
281.605 281.635
282.235 282.195
281.365<PHONE_NUMBER>0000003
281.625 281.575

I tried examining npz file. It does contain information and each row is different, so no repeating values like those above.
I got the same output from this simple function both with and without specifying snapshot file.
For the sake of saving time, i also ran checks that we discussed in previous issue, with following results:
Rows where timestamp in column 2 is not bigger than timestamp in column 1:
740
Rows where timestamp in column 1 is not higher than in previous row:
0
Rows where timestamp in column 2 is not higher than in previous row:
0
Rows with zero timestamp:
0

I am confident that i am using correct tick and lot sizes for BCH at BYBIT (0.05, 0.01). Some other coins works nicely. For example, LPTUSD, ADAUSDT, ARBUSDT and others.
Here is a link to converted files: https://drive.google.com/drive/folders/141LdAXZwvY2mXjXuZmQrALL7Zaj1LUCe?usp=sharing
Hopefully, this issue can be resolved. Can't imagine doing the research without this tool.

Thanks, its working!

thank you for the report.


Optimize block sort

What problem does this PR solve?
Issue Number: ref #5294
What is changed and how it works?

optimize when number of sort key is 2 and type of sort key is one of

UInt64
Int64
StringBinPadding
StringBinNoPadding
StringWithCollatorGeneric

we can optimize the case that number of sort key is 3 later if necessary (there will be a lot of template instantiations)

Benchmark
ENV

tpch-100
1 tiflash
limit cpu up to 2000%
original commit: 6d0cbc8cc78b4048fb88e0845d6c9c2881e01515

SQL
EXPLAIN analyze SELECT ROW_NUMBER() OVER w1 FROM PART window w1 AS (PARTITION BY P_MFGR order by P_SIZE);

sort key: STR(utf8 collator),UINT64

Time(s)
Original
Optimized

Improvement

8.16
7.18

8.22
6.94

8.29
7.35

8.34
7.04

8.24
7.37

AVG(Original) / AVG(Optimized) - 1.0

AVG
8.25
7.176

Optimized : Original
14.97%

SQL
EXPLAIN analyze SELECT ROW_NUMBER() OVER w1 FROM PART window w1 AS (PARTITION BY P_MFGR ORDER BY p_name);

sort key: STR(utf8 collator),STR(utf8 collator)

Time(s)
Original
Optimized

Improvement

18.3
16.34

18.27
16.62

18.7
16.57

18.57
16.52

18.55
16.63

AVG(Original) / AVG(Optimized) - 1.0

AVG
18.478
16.536

Optimized : Original
11.74%

SQL
EXPLAIN analyze SELECT ROW_NUMBER() OVER w1 FROM PART window w1 AS (PARTITION BY p_name ORDER BY p_partkey);

sort key: INT64,STR(utf8 collator)
costs of block sort are about 30%

Time(s)
Original
Optimized

Improvement

9.71
9.28

9.62
9.41

9.76
9.25

9.73
9.26

9.67
9.28

AVG(Original) / AVG(Optimized) - 1.0

AVG
9.698
9.296

Optimized : Original
4.32%

Check List
Tests

[ ] Unit test
[ ] Integration test
[ ] Manual test (add detailed scripts or steps below)
[ ] No code

Side effects

[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Breaking backward compatibility

Documentation

[ ] Affects user behaviors
[ ] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Changes MySQL compatibility

Release note

None

/run-all-tests

/run-unit-test

/run-all-tests

/run-all-tests

/run-all-tests

/run-integration-test

It seems that the optimization is all from move branches out of loops and make branches static?
from the offline discussion, we can materialize the collator look-up column, to decrease the collator look-up times from O(nlogn) to O(n)

It may also be an optional way if the overhead about materialization is small.

consider add a FastPathPermutationSort<1>, which is commoner than 2 columns

We already have such optimization :  https://github.com/pingcap/tiflash/blob/3674439a1f1aeb09c70ad67f70cf5c2e961bd01a/dbms/src/Interpreters/sortBlock.cpp#L123-L141

/hold

/merge

/rebuild

/run-all-tests

/rebuild

/merge

/run-integration-test

/unhold


Slide 29 (App Store + Per tenant extensions – Number range and names ): too rough description

The description on slide 29 is too compact.
Seems to me  very relevant slide with actually a lot of info, but needs more elaboration as it throws (surely to me) a number of questions.
It states:

If you complete renaming and renumbering in C/AL, we will move full tables automatically to extensions if the ID and the Name Matches

Question 1: looking at the example the names of TAB50000 and TAB55000000 do not exactly match. DIfference is "NKC - ", including 3 letter prefix. Does the platform disregard this prefix part (including "- ") and sees that the main part of the table names match?
Question 2: is the ID matching refering to the field IDs?

follow app source process to get a 3-letter prefix and a range

Question 3: Prefix only? How about suffix?
Or I am I totally on the wrong track and is the matching something different?

Question 1 - on previous slides it is explained that this move should be done in C/AL. Platform will not do it. C/AL will rename on force sync, that is the recommendation. Renumbering is tricky.
Question 2 -  Fields should be only if you have table extensions. Otherwise it is table IDs. I assume this should be known to the partners.
Question 3 - Updated.
Please let me know if I should update anything else (reactivate the issue)


Spans created for outgoing REST calls don't seem to set parent properly

Environment Details

Helidon Version: 1.2.2-SNAPSHOT
Helidon SE or Helidon MP: MP
JDK version: 11
OS: Mac
Docker version (if applicable): N/A

Problem Description
In code invoked from my REST resource method, if I create a span, set it as active, and then issue an outgoing REST call, I would expect the span created for the outgoing REST call to be a child of the active span.  However, the span created for the outgoing REST call is instead the child of the span with operation name "GET:io.helidon.examples.GreetResource.getRemoteMessage" (a framework-created span for my REST resource method).
Steps to reproduce
I've done a sample application based on the autogenerated helidon-quickstart-mp (It's in the test-tracing branch of my helidon-quickstart-mp repository)
The major changes against helidon-quickstart-mp are (diff here):

Use helidon-microprofile-tracing and helidon-tracing-jaeger with constantly on sampling
Add the endpoint /greet/remoteGreeting?url=<remote URL>, which performs a GET request against the remote URL and then returns { "message": "<message property from the GET request's JSON response>" }
Add invocation of http://localhost:<port>/greet/remoteGreeting?url=http://localhost:<port>/greet to MainTest
Create spans within GreetingProvider's service methods surrounding the body of the methods, including the new method getRemoteMessage

I did something similar to the following to test the tracing:

Check out revision f9c89ce5 of helidon's master branch
Run mvn install to install helidon artifacts of version 1.2.2-SNAPSHOT
Start jaeger-all-in-one
Check out revision bd2cbfa of my helidon-quickstart-mp's test-tracing branch
Run mvn test
Look for the trace for the /greet/remoteGreeting invocation in http://localhost:16686 (the trace with service name helidon-quickstart-mp and 21 total spans)
Change helidon/tracing/jersey-client as described under Potential Solution
Run mvn install under helidon/tracing/jersey-client
Run mvn test under helidon-quickstart-mp again
Look for the trace for the /greet/remoteGreeting invocation again

The above steps should lead to the following two traces:

Trace from step 5 (The innermost GET is the child of GET:io.helidon.examples.GreetResource.getRemoteMessage):
Trace from step 10 (The innermost GET is the child of getRemoteMessage):

Note the following relevant spans in the above screenshots:

GET:io.helidon.examples.GreetResource.getRemoteMessage, the framework-created span for GreetingResource.getRemoteMessage
getRemoteMessage, the span for GreetingProvider.getRemoteMessage
GET (Specifically, the innermost of the two spans with operation name "GET"; the one at the top level is from MainTest), the framework-created span for the outgoing GET request
getMessage, the span for GreetingProvider.getMessage

 Potential Solution
Assuming that the current behavior is undesired, and the behavior in the above second screenshot is desired, one potential solution is to change ClientTracingFilter in helidon-tracing-jersey-client such that the spans it creates use the currently active span as the parent if there is one, or don't specify a parent if there's an active span (which should have the same behavior, since the default span parent is the active span), as I've done in this commit to the active-span-parent branch of my helidon fork.
Notes on the Potential Solution

I don't know whether this change would break anything else in helidon
I don't know if there are any cases in which there is an active span but ClientTracingFilter.filter should still use the result from ClientTracingFilter.findParentSpan as the parent of the new span
I don't know if there's any other spans created in the helidon source code that would have similar issues

We can look into the active span, though we cannot fully depend on it, as Jersey client may be used from Helidon SE, where we run in (possibly) more than one thread, so we cannot use startActive.
I will investigate possible options.

In MP, active span is now used as a parent of other spans (outbound calls, other methods annotated as @Traced).
This should resolve the problem described in this issue.


setup Kanban project

[ ] Created an empty repository for your group project.

[ ] Divided cards equally between group members

[ ] Assigned projects either to:

Group

Stephen

Pacific

See Kanban Projects here
There are 2 students working on this repository.

Hi @stephenkati, @rugwizangoga, please kindly edit your issue comment and add a link to your Kanban Project. I helped you get the link. Please kindly see it below:
https://github.com/stephenkati/space-traveller-s-hub/projects/1

Thanks for the comment, I have added projects link

Hi @stephenkati, @rugwizangoga, please kindly edit your issue comment and add a link to your Kanban Project. I helped you get the link. Please kindly see it below:
https://github.com/stephenkati/space-traveller-s-hub/projects/1

Thanks for the comment, I have added projects link

Thanks, please also add information about the number of people in your group.

Hi @stephenkati, @rugwizangoga, please kindly edit your issue comment and add a link to your Kanban Project. I helped you get the link. Please kindly see it below:
https://github.com/stephenkati/space-traveller-s-hub/projects/1

Thanks for the comment, I have added projects link

Thanks, please also add information about the number of people in your group.

Thanks for the request, its done

Hi Team,
Your project is complete! Great job for nailing it right on the first attempt 🥇. There is nothing else to say other than... it's time to merge it 🍾🚢 :shipit: . Congratulations!  🎉💯🌟

Optional suggestions

Nothing to mention.

Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have 1 more limited review per this project. If you think that the code review was not fair, you can request a second opinion using this form.


Change filesystem permission to minimal

The app, by default, only needs to access the folder ~/ProgramasRFB. If the user wants to give more permission, information can be given in README.md

Note the program create .rd in home directory

Yes, I made a test creating a new user and the program seems to create at least these folders. Idk if it creates another afterwards:
~/.rfb
~/.irpf
~/.java
~/ProgramasRFB
And even with home access permission, a file inside ~/ProgramasRFB logs some errors.
Maybe it's better to have home access, at least for now


Only run specific tests during wasm-pack test

This builds on rustwasm/wasm-bindgen#1465 by ensuring that wasm-pack test --node will now only test node.js tests

In a sense this is actually a bugfix to update to what the CLI flags actually mean (when you pass --node only running Node tests), so I think the documentation largely already made sense but I tweaked a bit to make sure this is explicitly mentioned.


Angular6

Hi,
Would it be possible to create a new version with upgraded dependencies now that angular6 has been released?
Maybe keep 1.0.2 for Angular5 and have 1.6.0 for Angular6 (Or something that indicate the dependency or angular 6)

npm install @netbasal/content-loader@next


Avoid double-quantizing when calling cuda()

Currently calling cuda() twice quantizes the quantized data, breaking the module. However it's necessary to call it a 2nd time after using the meta device, in order to place buffers on the device.

Thanks for your contribution, @jph00!


Add a setting to display battery information

Thanks for sharing this launcher, it's my preferred choice for Android TV boxes.
This year O Apalpador  was kind enough to get me a Retroid Pocket 2; the thing is something like a portable console, without a touchscreen, and running Android, so I installed this launcher on it to make it easier to use with the d-pad.
It's working like a charm, but I'm missing some battery information in the home screen, so I made this little patch:

This is disabled by default, so this doesn't show 0% ? on devices without a battery
I use whatever BatteryManager thinks is the right icon for the current battery status. I find that icon pretty ugly in every device I tested this on, so in the future I may add a custom drawable to use as battery status icon.
No idea if the translations are right, I just used google translate here.
Tested on said Retroid thing and in an Android TV emulator at 720p.

Hope you find this patch useful. Happy holidays!

Coverage remained the same at 0.0% when pulling b50a0cb8c5710d66548773c0e3420db092cdbbcb on isalgueiro:battery-info into 8cf33abdf8f09a4fa219f2ad754e216a64c3ad0b on alescdb:master.

LGTM.
Thanks for the PR ! :-)


[spec bug] DynamoDB BillingMode/PointInTimeRecoverySpecification in some regions

DynamoDB BillingMode/PointInTimeRecoverySpecification are only available in the regions in the region dropdown on these pages:
https://aws.amazon.com/dynamodb/pricing/on-demand/
https://aws.amazon.com/dynamodb/pricing/provisioned/
AWSTemplateFormatVersion: "2010-09-09"
Resources:
  dynamoDBTable:
    Type: AWS::DynamoDB::Table
    Properties:
      AttributeDefinitions:
        - AttributeName: "Album"
          AttributeType: "S"
        - AttributeName: "Artist"
          AttributeType: "S"
      KeySchema:
        - AttributeName: "Album"
          KeyType: "HASH"
        - AttributeName: "Artist"
          KeyType: "RANGE"
      BillingMode: PAY_PER_REQUEST
      PointInTimeRecoverySpecification:
        PointInTimeRecoveryEnabled: true

One or more parameter values were invalid: Unsupported input parameter BillingMode (Service: AmazonDynamoDBv2; Status Code: 400; Error Code: ValidationException; Request ID:)
Continuous Backups has not been enabled for DynamoDB table yet

only verified in ap-northeast-3, but might affect more regions like us-gov-east-1

While we patch Resource Specification regional availability automatically from SSM at the resource type level and manually, I don't think we can commit to maintaining manual regional availability patches down to the property type level with ~1500 and growing property types and ~30 and growing AWS regions


Robit: Object based import with centralized settings.

[x] convert Robit to a object import
[x] Central function and robit settings for UTC Offset.
[ ] This does not account for daylight savings in areas! Do we need a timezone module?

Not addressing the timezone / daylight savings right now!


lines in one graphic event

like this fiddle https://jsfiddle.net/Fboy/pf6cx592/2/
I use one graphic to draw more lines,I want add event for every lines.How do I change it?

I cant interpret what do you want. Please provide more information.

I want when mouse hover line,to change lines color,or width and more for each line

Sorry, pixi does not have that feature.
easy way: each line is its own graphics. Its slow.
hard way: use Mesh instead, override containsPoint that way it modifies the mesh. Add colors in shader
hard way #2: take Graphics element, copy all the code, or just override parts that matter: containsPoint, lines rebuild algorithm. Its possible, but its very hard way.

I have tried the simple method, it is really slow, I will try the second method. thanks a lot


Add unit tests and lint

I'd like to run this tests and lint on CI environment. (Circle CI and AppVeyor)

LGTM 👍


Pin test dependencies

Description

In this PR I add constraints files for napari test dependencies and workflow to perform every week update of dependencies.
The motivation for this PR is to avoid regular failures not related to PR context but caused by some dependency release.
Also, this PR will provide dependency versions on which napari works during release time.
This PR is inspired by workflow from PartSeg that example output could be found here https://github.com/4DNucleome/PartSeg/pull/932 (but here is not listening all updated dependencies)
This PR will require adding GHA_TOKEN to repository secrets with the following permissions:

References

Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change
[ ] example: I check if my changes works with both PySide and PyQt backends
as there are small differences between the two Qt bindings.

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

I like this! I recently learnt about the Dependency submissions API, which might be related to this in terms of purpose. Having the constraints already there should make it super easy to integrate!

@Czaki can you elaborate on what kind of token I need to create? Is this a personal access token or something else? Detailed instructions appreciated. 😊

@Czaki can you elaborate on what kind of token I need to create? Is this a personal access token or something else? Detailed instructions appreciated. blush

Go to napari Settings > Third-party Access > Personal access tokens > Settings

Then allow Fine-grained personal access tokens but keep "Require administrator approval"

Go to personal Settings > Developer Settings > Personal access tokens > Fine-grained tokens

Generate new Token
Set resource owner to napari. Set long lime of expiration. Use  "Only select repositories"
Here is an example of the configuration for PartSeg, as the napari repository do not allow currently for these tokens:

Then in repository permissions, set Pull request permissions to Read and Write:

Click "generate token".
Such toke could also solve the problem of not starting CI on updating vendor dependency PR.

Ok and then the value of the token I put into a new repository secret as GHA_TOKEN, yes? I just did that. Hopefully I didn't mess up any steps... 😬 🤞

So to test this, we need to merge and trigger this workflow manually.

Could you mention in Zulip #reviews that this is ready? We should wait 24h to make sure ~everyone is on board, as it's a significant change to our workflow.

I have added such a message.

Copying from zulip:
can you summarize how this can have a "big impact to our workflow"?

The test depenecies will be pinned base on constrains files, but every week
(with option to manual trigger) there will be PR with update of all test
dependencies constrains.
So it should reduce number of extinguishing fires, but increase maintenance.
So it will be nice to more dev understand what happens there if there happen
need to update configuration.

Seems reasonable; I guess we can always revert if it turns out to be too much burden.

Am I getting this right:
The workflow will open a PR with bumped dependencies, if there are any.
In that PR, tests with these new ones will run, right?
So if they pass, we can basically merge safely.
If tests fail, we know we need to keep the pin and/or solve the issue.

Yes. The whole setup token step is to allow running tests for automatically opened PR.

@Czaki out of curiosity, why are the pip install and examples tests using 3.9 instead of 3.10?

@Czaki is tools/constraints/version_blacklist.txt missing?

@Czaki is tools/constraints/version_blacklist.txt missing?

Was renamed to version_denylist. I do not regenerate files to simpler check if its working good after merge.

@Czaki out of curiosity, why are the pip install and examples tests using 3.9 instead of 3.10?

At some moment there was the decision to not use the latest supported, but one before. When we enable python 3.11 test then we should switch it to python 3.10

Awesome, thank you @Czaki !

@Carreau This PR may conflict with parts of your work. What did you think about it?

Love this - going to merge because we have two approving reviews but we can always revert if @Carreau has issues


Check rebuild older ruby for jammy

blocked by

https://github.com/rbenv/ruby-build/pull/1974
https://bugs.ruby-lang.org/issues/18658

Seems to be no longer required, so skipping


Broken Example Site and GitHub links in "main" menu

The main menu links can only be relative to BaseURL (mentioned in the box under: https://gohugo.io/content-management/menus/#add-non-content-entries-to-a-menu)

Not sure if its will work but maybe an opportunity to show how redirects work?

Whoah, excellent spot. Though the existing config.toml works fine locally, but it breaks when it's served from Netlify. Also that box seems to indicate that if you provide an absolute URL (which I do) it should override the baseURL, but it isn't overriding it. Kubeflow has main menu links done the same way that work fine. Let me investigate....

Fixed in https://github.com/LisaFC/docsysite/commit/278446d2fa065339c33fff79cdaed4df0c90453d
(changing baseURL from "" to "/" fixed it. I'll make the same change in Goldydocs.)


Title

OPS Build status updates of commit f389d74:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/databricks-monitoring/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

OPS Build status updates of commit f258b5e:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/databricks-monitoring/index.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


refactor(checkout): CHECKOUT-6891 Update incomplete order wording on order confirmation page

What?
Update incomplete order wording on order confirmation page when experiment is on
Why?
To provide more accurate and helpful information to customers when the order is incomplete.
Testing / Proof

[x] unit test
[x] manual test

How can this change be undone in case of failure?
Revert or Turn off experiment CHECKOUT-6891.update_incomplete_order_wording_on_order_confirmation_page
@bigcommerce/team-checkout

@bc-mackxu Should we also change the wording Thank you <shopper>! ?
Maybe worth checking that with @bc-charlesho

@snaderiBC There is one more PR to bump the version in BCApp 😞


NoStaticImport recipe updates getClass calls

@Cimballi https://github.com/openrewrite/rewrite/pull/3165/commits/41219b0d7147d4a81adc8514d3bedc0fd693f724 ought to resolve the issue, and will be merged as soon as the tests failures on the main branch are resolved.


Bubble sort

solve the issue using java.
provide
codes/algos

Is this issue steel open? I would like to work on it during the Hacktoberfest. Could you add lable for it.

no code is added.


Make isDigit branchless

It results in smaller code which is always good

@thewilsonator can you put an auto-merge-squash?

On which compiler? https://d.godbolt.org/z/fMfjjYcaM code is actually slightly longer on ldc.
https://d.godbolt.org/z/TeGq5Y1x6 The way that they don't get inlined is probably a more pressing issue

@maxhaton i fixed the code. try it again.

@maxhaton i fixed the code. try it again.

https://d.godbolt.org/z/noh54odGo for reference. Was smaller code in reference to the source or binary?

@maxhaton it's smaller for unoptimized builds and dmd.

I haven't look at the generated code, but in general we shouldn't be pandering for DMD at the expense of LDC an GDC. I understand this is useful for unoptimised build.

I could also put a micro-optimisation pass into dmd to transform (v <= C1 && v >= C2) into ((v - C1) > (C1 - C2))

There is no expense.
ldc and gdc to the rewrite I made manually automatically.
they generate the same code with and without this patch.

I could also put a micro-optimisation pass into dmd to transform (v <= C1 && v >= C2) into ((v - C1) > (C1 - C2))

I guess you could, but it's probably just more spaghetti in the backend in exchange for a speedup that most people interested wouldn't even notice because optimized dmd builds are borderline considered harmful next to LLVM and GNU

I can't rebase it I think because I don't know where the branch lives
On Tue, Apr 13, 2021, 10:21 AM Razvan Nitu @.***> wrote:

@RazvanN7 commented on this pull request.
This probably needs a rebase to fix the buildkite failure.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dlang/phobos/pull/7959#pullrequestreview-634365592,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAVWSCBEFE7IFHDFLZRR353TIQEILANCNFSM422EMUBA
.

it lives https://github.com/dlang/phobos/tree/UplinkCoder-patch-1

See #7800 for a similar PR that was refuted.

This is going to be incompatible with using some third-party overflow checking tools. Is that a problem?

Seeing the critique in the previous PR.
I have to agree that this is unreadable code.

Seeing the critique in the previous PR.
I have to agree that this is unreadable code.

The readability can be fixed with a comment. Also, musl libc implements it that way.

It is also interesting to see how a PR move forward depending on the people :eyes:


New Rule: Use Type Checking instead of Type Casting

Expected Behavior of the rule
The explicit type cast can be removed to optimise the check.
The compliant case checks for the type only, while the noncompliant case first checks if the instance is of that type and then returns null or casts explicitly to that type.
The rule should not flag cases, where the result of the cast operator, e.g. the casted type variable, is used in subsequent code.
Compliant
val objList: List<Any> = emptyList()
objList.any { it is String }

Noncompliant
val objList: List<Any> = emptyList()
objList.any { it as? String != null }

They might be more complicated cases, where this rule could be helpful.
Context
The performance rule set should include this new rule.
The idea was initiated in #7858.

This could go too to style. The compliant code is easier to read.

This could go too to style. The compliant code is easier to read.

I don't think so. The noncompliant code compiles to more byte code than necessary, because not only a type is performed but also a cast. If such a cast happens in a long list, this impacts run time and memory consumption.


HW 14

This has too many commits to merge/review. You need to be breaking your work into smaller bits.


fontforge: CVE-2020-5395, CVE-2020-5496

Motivation for this change
Close https://github.com/NixOS/nixpkgs/issues/88291.
Things done
See the commit message for reasoning.
This needs to be backported to nixos-20.03.

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

Fixed the https URL.
We use fetchurl, as we are building from the release tarball, not from source. I'm not satisfied with the situation but it's non-trivial to fix, as the release tarball contains more than just the sources. I'm working on a PR that fixes the issue and upgrades to 20200314.

Ah, that makes sense. I was wondering why you didn't just update :smiley:

ofborg failed to fetch the patch

That's weird, the URL is still valid. Let's retry it.
@GrahamcOfBorg build fontforge

/nix/store/01d4cg8iwh6y0gb7zc0vz84q3spc927y-CVE-2020-5395+CVE-2020-5496.patch.drv definetely builds locally for me. @grahamc do you have an idea?
@Fridh note that the check fontforge on {x86_64-linux,aarch64-linux} resulted in a success.

I've merged #89583.


Add ability to set gas price or fees in ZetaClient broadcasts

We currently don't set any gas price or fees in ZetaClient when broadcasting ZetaChain messages:
https://github.com/zeta-chain/node/blob/develop/zetaclient/broadcast.go
This might become problematic if the gas price is lower than the other txs in the mempool and node prioritize higher gas price.
We should have the ability to set a custom gas price for message broadcast that would depend on the network.

Closing, ZetaClient now uses the base fee with a multiplier for the gas price. In the future we're consider a specific prioritization for system messages.


items disappearing from storage warehouse

so i had a storage warehouse with the parts of my deconstructed base but now as i try to rebuild the items are disappearing from the warehouse. I watched the items trickle down into something that doesn't exist.

Warehouses don't have any "control" logic, and are just huge "chests" so to speak, there's nothing in warehousing that can make items disappear.
What other mods are you running?

Storage warehouses connect to the logistics network, so it's possible that logistic or construction robots are taking items from the warehouse as you work on rebuilding.

Will reopen issue if it turns out to be a bug in Warehousing, but it probably isn't. @nacjm feel free to continue troubleshooting here.


Add settings dialog

Settings for:
Room:

color palette

Global:

unsent stroke transparency

needs the ability to invite people via board UI instead of another client


Problem launching motion control activities

Hi. I encounter some issues in launch of the motion control activities. I take some shots of example.

@biancofla Ok, I did forget something important! I have written a script file setup.sh, you need to use  git pull command to get lastest repository and following Installation steps to fix the problems you mentioned.


[BUG]: Error after embedding document ""Could not respond to message"

How are you running AnythingLLM?
AnythingLLM desktop app
What happened?
Everytime I upload and embed a document I get the error ""Could not respond to message. An error occurred while streaming response. network error"".
Doesn´t matter which model I use. Happens even with fresh installation. After error occurs the application is frozen. After restart same error occurs.
I use Windows Server 2022 with NVIDIA Quadro K6000
Are there known steps to reproduce?
Install AnythingLLM. Upload and embed document (PDF). Type any message.

If this is happening with every LLM model you are using to try and chat, it sounds like this is probably an issue with Windows Server firewall blocking the connection to whatever model you are using. You will need to investigate and see if your firewall settings are blocking you.

Thanx @shatfield4 but firewall is disabled. Without embedding documents all models work fine.

That response would typically indicate that the embedder failed to embed the content. With the default embedder can you send a chat on a brand new workspace with no documents? That should have no embedder call required.
Next, I would open C:\Users\user\AppData\Roaming\anythingllm-desktop\storage and see if there is a folder with files in it named storage\models\Xenova\ and there should be a subfolder for all-miniLM-l6 or something to the effect.

Thanks @timothycarambat!

With the default embedder can you send a chat on a brand new workspace with no documents? That should have no embedder call required.
If I set the default embedder and make a brand new chat with no documents, there is no error message.

Next, I would open C:\Users\user\AppData\Roaming\anythingllm-desktop\storage and see if there is a folder with files in it named storage\models\Xenova\ and there should be a subfolder for all-miniLM-l6 or something to the effect.
This folder exists. But I don´t understand what it indicates or what do do with it. Should I delete it? It has not created along with the brand new workspace though.

Thanks again for your support and your efforts on AnythingLLM!

lets try deleting the Xenova folder and then try to re-embed a file on a fresh and empty workspace. Be sure to close and re-open app after deleting that folder. Please test a smaller text file just to limit variables in debugging. The embedder downloads on the first use so it does not bloat the app if unused. Its only 25MB so it should not take long, however if it still fails then there is a possibility the MSFT C++ Distributable might not be installed on your system - which is possible, but really unlikely but it has happened before.
https://learn.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?view=msvc-170#latest-microsoft-visual-c-redistributable-version

lets try deleting the Xenova folder and then try to re-embed a file on a fresh and empty workspace. Be sure to close and re-open app after deleting that folder. Please test a smaller text file just to limit variables in debugging.

Did that. Same error.

however if it still fails then there is a possibility the MSFT C++ Distributable might not be installed on your system - which is possible, but really unlikely but it has happened before.

I had MS Visual C++ installed, reinstalled vc_redist.x64.exe though but error still occurs after deleting the "Xenova" and re-embedding in a fresh and empty workspace.

Hey, i got the exact same error as LLMuser.

Because this is not a bug and is a client-side specific issue. If the issue was a bug 100% of users would be impacted and that is not the case - so now it is a support ticket in Github and we prematurely close them as it crowds the repo.

Hey, i got the exact same error as LLMuser.
I don't get why the ticket have been closed since the error is still there
meto~~

Maybe my windows system computer installed too many environment variables led to this problem, how to troubleshoot become a very egg pain  problem

Closed because it cannot be replicated. If anyone is willing to get any good logs you can do so: https://docs.useanything.com/debug

Hi, I'm experiencing the same problem on an ASUS Vivobook with Snapdragon(R) X Elite - X1E78100 - Qualcomm(R) Oryon(TM) CPU, 3417 Mhz, 12 Core(s), 32GB RAM. Windows 11.

@ojoaustral That is a brand-new machine so should not be an issue with AVX2 support on that CPU. The LLM has no impact on the upload/embedding section. I am assuming you have both the default vectorDB and Embedder model selected in ANythingLLM?

Hey, thanks!
I have LanceDB as the Vector DB, and AnythingLLM embedder.  I don't see an
AnythingLMM vector database option.
C
On Fri, Aug 16, 2024 at 2:29 PM Timothy Carambat @.***>
wrote:

@ojoaustral https://github.com/ojoaustral That is a brand-new machine
so should not be an issue with AVX2 support on that CPU. The LLM has no
impact on the upload/embedding section. I am assuming you have both the
default vectorDB and Embedder model selected in ANythingLLM?
—
Reply to this email directly, view it on GitHub
https://github.com/Mintplex-Labs/anything-llm/issues/1586#issuecomment-2293968213,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKLXMVRNXD3OSQSXIVLZHIDZRZAJHAVCNFSM6AAAAABISY4TZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJTHE3DQMRRGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

I have the same error. MacOS 14.6 (23G80) Sonoma. Llama 3.1 70B.

Hi Tim,
Yes,  I have the default vectorDB (LanceDB) and Embedder (AnythingLLM). The
same problem also happens when I try scraping a webpage. I checked the
Windows firewall and AnythingLLM.exe is enabled. Do you have any idea what
is going on? What can I try now?
Best,
C
On Fri, Aug 16, 2024 at 2:29 PM Timothy Carambat @.***>
wrote:

@ojoaustral https://github.com/ojoaustral That is a brand-new machine
so should not be an issue with AVX2 support on that CPU. The LLM has no
impact on the upload/embedding section. I am assuming you have both the
default vectorDB and Embedder model selected in ANythingLLM?
—
Reply to this email directly, view it on GitHub
https://github.com/Mintplex-Labs/anything-llm/issues/1586#issuecomment-2293968213,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKLXMVRNXD3OSQSXIVLZHIDZRZAJHAVCNFSM6AAAAABISY4TZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJTHE3DQMRRGM
.
You are receiving this because you were mentioned.Message ID:
@.***>

Nothing useful from https://docs.useanything.com/debug?

windows 10 64 bit log.txt
Using desktop app. I did everything this page suggested. I have run the program in cmd and got this log. when using a file in workspace.
it shows :
Could not respond to message.
An error occurred while streaming response. network error
in web browser.
it force closes the program in cli,so the client no longer works. That is why nothing works after we try to use a file for the embedder.

lets try deleting the Xenova folder and then try to re-embed a file on a fresh and empty workspace. Be sure to close and re-open app after deleting that folder. Please test a smaller text file just to limit variables in debugging. The embedder downloads on the first use so it does not bloat the app if unused. Its only 25MB so it should not take long, however if it still fails then there is a possibility the MSFT C++ Distributable might not be installed on your system - which is possible, but really unlikely but it has happened before.
https://learn.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?view=msvc-170#latest-microsoft-visual-c-redistributable-version
I also have done this .

Next, I would open C:\Users\user\AppData\Roaming\anythingllm-desktop\storage and see if there is a folder with files in it named storage\models\Xenova\ and there should be a subfolder for all-miniLM-l6 or something to the effect.

and deleted this as well.
Something is force closing the program when an embedding is used.
my cpu is avx inter 3930k, 1080 ti (11 gb vram) ,latest nvidia driver.
windows 10 , 22h2 build 19045.3758.

For me the Error went away as I started Anything LLM with administrative rights.

For me the Error went away as I started Anything LLM with administrative rights.

Unfortunately it didn't help. However I have installed chromadb ,and hosted chroma server locally. then when I choose chroma inside anything llm and put the localhost ip address it worked. At least this way I can use RAG.

@timothycarambat Is there a way for windows client when chroma database is selected it shall install chromadb internally and start its server internally and locally ,so we don't have to depend on external installation of chroma and start it outside anything llm or can you pack chromadb for the installation. Why ,cos it seems to work on even with avx supported gpus. This can end all the problems for old machines . Please :)

@FlowDownTheRiver I wish it was that simple. IIRC Chroma was going to explore embedded Chroma, but the AVX2 CPU support is really kind of helpful because AVX2 support has been around for over ten years! No doubt whatever we get up to in the future will benefit from running a somewhat modern machine.
For now, it will have to be external, its not as easy as installing chroma automatically and that's a lot of complexity to support machine that are frankly a bit out of scope for us

@timothycarambat Thank you for your time and explaining. This is a great project regardless. I can work with external server since it is at least working for my needs. Thanks for this amazing project to you,to the team and to contributers as well.

I have the same error
Could not respond to message.
An error occurred while streaming response. network error

https://docs.anythingllm.com/fetch-failed-on-upload