Upgrade eslint-plugin-prettier to support prettier v3

Overview
Prettier 3.0.0 has been released. In our app, the only significant change was needing to upgrade to<EMAIL_ADDRESS>(which comes via @shopify/eslint-plugin)

StackOverflow reference

Consuming repo

See backlink below

Checklist

[x] Please delete the labels section before submitting your issue
[x] I have described this issue in a way that is actionable (if possible)

Very grateful y'all have these repos open. This issue helped unblock something important for us. :) Cheers!

Closed by https://github.com/Shopify/web-configs/pull/397


hubble/relay: fix warning about missing config file

Before this patch, hubble-relay would complain when its config file was missing. This patch make it so the error message is only shown at the debug level.
Before this patch:
% ./hubble-relay version
level=warning msg="Failed to read config from file '/etc/hubble-relay/config.yaml'" error="open /etc/hubble-relay/config.yaml: no such file or directory" subsys=hubble-relay
Hubble-relay: 1.8.90 b13dcfb3f 2020-08-21T15:53:46+05:30 go version go1.15 linux/amd64

After this patch:
% ./hubble-relay version
Hubble-relay: 1.8.90 6c4963ab6 2020-09-07T19:07:01+02:00 go version go1.15 linux/amd64

and
% ./hubble-relay version --debug
level=debug msg="os.Hostname() returned" nodeName=shelob subsys=node
level=debug msg="Failed to read config from file '/etc/hubble-relay/config.yaml'" error="open /etc/hubble-relay/config.yaml: no such file or directory" subsys=hubble-relay
Hubble-relay: 1.8.90 6c4963ab6 2020-09-07T19:07:01+02:00 go version go1.15 linux/amd64
% RELAY_DEBUG=true ./hubble-relay version
level=debug msg="Failed to read config from file '/etc/hubble-relay/config.yaml'" error="open /etc/hubble-relay/config.yaml: no such file or directory" subsys=hubble-relay
Hubble-relay: 1.8.90 6c4963ab6 2020-09-07T19:07:01+02:00 go version go1.15 linux/amd64

Fixes #13104

Updated: One strange thing with this patch was that setting the debug flag from the config file would not affect the logging level (because we check this before ReadInConfig()). I don't see a better way than checking for viper.GetBool("debug") a second time and setting the log level accordingly.

Thanks! The ReadInConfig should be done similarly to what is done for Cilium / Cilium operator, i.e., mount each config map option as files inside the pod. #12900 (review)

Since #12900 we are actually reading in the configmap as a file:
https://github.com/cilium/cilium/blob/6f7fb6cd349d18bf86300c923dda49d2f263c8d5/install/kubernetes/cilium/charts/hubble-relay/templates/deployment.yaml#L59-L61
Is there anything else you had in mind?

test-me-please


[TURBO] UX Turbo does not re-render form on error

I'm adding an error to the form using $form->addError(new FormError('message')) but is not shown,
Yesterday everything was working, but today I changed the code a bit and the form stopped displaying errors. I tried to return everything to the state before the change but it didn't help. First of all, I noticed that even after adding an error with the addError(), the server returns the code 200 instead of 422 (yesterday it returned 422). As far as I understand, for UX Turbo to re-render the form, it needs to get code 422. I tried returning the response with code 422 manually ($this->render('template', [$data], new Response(null, 422)), but the error was still not shown.
// Controller

#[Route('/', name: 'app_index')]
public function index(Request $request): Response
{
    $authForm = $this->createForm(AuthType::class);

    $authForm->handleRequest($request);

    $disclaimer = $this->renderView('index/disclaimer.html.twig');
    if ($authForm->isSubmitted() && $authForm->isValid()) {

        // removed logic for testing
        $authForm->addError(new FormError('ERR'));

        if (TurboBundle::STREAM_FORMAT == $request->getPreferredFormat()) {
            $request->setRequestFormat(TurboBundle::STREAM_FORMAT);
            return $this->render('index/main_block_contents.stream.html.twig', [ 'contents' => $disclaimer]);
        }
    }

    return $this->render('index/base.html.twig', [
        'authForm' => $authForm,
        'contents' => $disclaimer
    ]);
}

Form has no errors
Symfony 6.4.*
@hotwired/turbo 7.3.0

The render method can only set the HTTP 422 if you pass the form in the render() arguments.
You should try
if (TurboBundle::STREAM_FORMAT == $request->getPreferredFormat()) {
    $request->setRequestFormat(TurboBundle::STREAM_FORMAT);
     return $this->render('index/main_block_contents.stream.html.twig', [ 'contents' => $disclaimer, 'form' => $authForm]);
}

@smnandre tried it, now it returns 422, but does not re-render the form with the error. According to Symfony Docs:

This changes the response status code to 422 on validation error, which tells Turbo Drive that the form submit failed and it should re-render with the errors.

Hey @sherwomeister could you create a small reproducer ? I’ll look at it after christmas

@smnandre, srry, by reproducer you mean just paste Controller's code here or create a repo with full project ? I don’t often ask questions on Github so I don’t know how it’s done.

Yes sorry i should have be more precise: a minimal repo that anyone can install and use to check the issue with minimal time.
There is some documentation about how to create a reproducer on the symfony website if you want: https://symfony.com/doc/current/contributing/code/reproducer.html
By doing so, you gave your issue a lot more chance to be looked upon.
I made one quick recently (well, i did not reproduce the bug there, but that would be the format if the page did not redirect correctly): https://github.com/smnandre/repro-live-redirection/
For your problem i guess creating a minimal reproducer would start with
symfony new --webapp repro-turb-form

And iterate from there with the minimal amount of code to create the bug
(as Turbo should be installed and configured with the webapp standard install)

Reproducer

Reproducer

Ok i get now where the trouble is. As you add the error manually inside the condition
 if ($authForm->isSubmitted() && $authForm->isValid()) {

            $content = "Replaced!";
            $authForm->addError(new FormError('ERR'));

            if (TurboBundle::STREAM_FORMAT == $request->getPreferredFormat()) {
                $request->setRequestFormat(TurboBundle::STREAM_FORMAT);
                return $this->render('index/index.stream.html.twig',
                    [
                        'content' => $content,
                        'form' => $authForm
                    ]);
            }

        }

You always render "index.stream.html" there... and there is no mention of the form in it.
Try adding the error before this condition, and you'll see it works (re-renders the form with the added error).

But how to show an error after form submission? For example, after failed login?

What is the point of adding error before the condition? Isn't the whole point to add an error after form submission?

and you'll see it works (re-renders the form with the added error).

I think it just shows the error that was already renderd

If i understand correctly, what you want is : "if there is an error, render the form again"
What your code is doing is "if the form is submitted, add an error but do not render the form"
If you want to render the form again you must no render your result stream, so you can add a second condition
if ($authForm->isSubmitted() && $authForm->isValid()) {

            $content = "Replaced!";
            $authForm->addError(new FormError('ERR'));

-            if (TurboBundle::STREAM_FORMAT == $request->getPreferredFormat()) {
+            if ($authForm->isValid() && TurboBundle::STREAM_FORMAT == $request->getPreferredFormat()) {
                $request->setRequestFormat(TurboBundle::STREAM_FORMAT);
                return $this->render('index/index.stream.html.twig',
                    [
                        'content' => $content,
                        'form' => $authForm
                    ]);
            }

        }

In your case as you add the error unconditionnaly, that's not easy to see the differences..
You may try adding the formError only when a condition is met

If i understand correctly, what you want is : "if there is an error, render the form again"
What your code is doing is "if the form is submitted, add an error but do not render the form"
If you want to render the form again you must no render your result stream, so you can add a second condition
if ($authForm->isSubmitted() && $authForm->isValid()) {

            $content = "Replaced!";
            $authForm->addError(new FormError('ERR'));

-            if (TurboBundle::STREAM_FORMAT == $request->getPreferredFormat()) {
+            if ($authForm->isValid() && TurboBundle::STREAM_FORMAT == $request->getPreferredFormat()) {
                $request->setRequestFormat(TurboBundle::STREAM_FORMAT);
                return $this->render('index/index.stream.html.twig',
                    [
                        'content' => $content,
                        'form' => $authForm
                    ]);
            }

        }

I think your example just avoids using Turbo on form error, it just reloads the page. Documentation clearly states that Turbo will re-render form with errors, if 422 code is returned.
Symfony Docs:

Turbo Drive also converts form submissions to AJAX calls. To get it to work, you do need to adjust your code to return a 422 status code on a validation error (instead of a 200).

Symfony Docs

This changes the response status code to 422 on validation error, which tells Turbo Drive that the form submit failed and it should re-render with the errors.

Turbo Drive documentation

This allows form validation errors to be rendered by having the server respond with 422 Unprocessable Entity

In your case as you add the error unconditionnaly, that's not easy to see the differences..
You may try adding the formError only when a condition is met

Originally, I was adding an error when a condition was met, and it was not rendered

I don't understand what is not working as you expect, i'm sorry.
With your reproducer, Symfony returns a 422 as stated in the numerous pages of the documentation you provided..
https://github.com/symfony/ux/assets/1359581/64fabadd-16c5-4720-9c5e-b90ca09f85bf

Sorry, maybe I'm asking stupid questions or I don't fully understand how it works, but that's the behavior I am expecting:

User submits the form
The form is processed
If there is an error in form processing, add error to the form
render() function sees the error and returns HTTP 422
Turbo drive sees 422 response and re-renders form with errors without reloading the page

I'm trying to explain.
As you add your error in the bloc starting with if ($authForm->isSubmitted() and don't test after.... you always return a TurboStream containing only the content.
You wrote what you're expecting, but what you're doing in your code is a bit different:

User submits the form
The form is processed
3A. If there is NO error -> add an error ->  ALWAYS send a stream / replace the frame with content

How would the errors be injected in your code ? How could it know wich template you uses, wich CSS classes, etc ? If you do not render the form, the form is not rendered.
The examples you saw all works in the following way

User submits the form
The form is processed
3A. If there is NO error -> send a stream / replace the frame with new content
3B. If there is an error -> render again (that's where the Turbo magic will do its work) with the form and the initial template

Got it, thank you for your time


discriminators performance

Hello,
Im using this kind of mapper :
this.mapper = JdbcMapperFactory
                        .newInstance()
                        .addKeys("id")
                        .discriminator(A.class,
                                "type",
                                ResultSet::getString,
                                builder-> builder.discriminatorCase("TYPEA1", A1.class)
                                builder-> builder.discriminatorCase("TYPEA2", A2.class)
                                builder-> builder.discriminatorCase("TYPEA3", A3.class)
                                builder-> builder.discriminatorCase("TYPEA4", A4.class)
                                .......
                        )
                        .discriminator(B.class,
                                "b_type",
                                ResultSet::getString,
                                builder-> builder.discriminatorCase("TYPEB1", B1.class)
                                builder-> builder.discriminatorCase("TYPEB2", B2.class)
                                builder-> builder.discriminatorCase("TYPEB3", B3.class)
                                builder-> builder.discriminatorCase("TYPEB4", B4.class)
                                ........
                        )
                .newMapper(A.class);

I have a resultset which contains 100K row with 7 columns.
Here is the code mapping rs to list :
		String query = "....";
		L.info("execute : {}", query);
		long start = System.currentTimeMillis();
		List objects = new ArrayList();
		try (PreparedStatement ps = this.datasource.getConnection().prepareStatement(query);
				ResultSet rs = ps.executeQuery()) {
			L.info("execute in {} ms", System.currentTimeMillis() - start);
			start = System.currentTimeMillis();
			objects = mapper.stream(rs).collect(Collectors.toList());
			L.info("mapped in {} ms", System.currentTimeMillis() - start);
		} catch (SQLException e) {
			L.error("impossible to map the result set", e);
		}

my timings are :
execute in 288 ms
mapped in 5103 ms
How can I help you troubleshoot this ?

Well yes, ideally we would need to compare the time that would take without the mapping not just the execute query. Also I would need some profiling information using a sampler visualvm has one that should work just fine there.

Also to be sure that it’s the mapping that is slow we prob need the time to the first object. It’s possible the executequery does not wait for the query to be finished before returning but that rs.next does

quick question? how many case do you have on this? currently the case finding is not that optimised, the cost of growing number of case would be linear but that could have an impact there.

Yes
Will have a look

quick question? how many case do you have on this? currently the case finding is not that optimised, the cost of growing number of case would be linear but that could have an impact there.

42 cases for A, and 20 for B

with a first quick test i have the same timings. I will try to do more test today and let you know.
Thanks for your time.

Would be nice to get some sampling profiling info to find where it spends its time

I'm new to visualvm.
If you have any thought, I continue investigating...

What I find weird, is that I do not have same timings with different sql query.
Example 1
SELECT
	a.id as id,
	a.type as type,
	b.type as b_type,
	c.id as b_c_id
FROM a
LEFT JOIN b on all_measures.target_id=target.id
LEFT JOIN b_d on b.id=b_d.d_id
LEFT JOIN b_c on b.id=b_c.b_id
LEFT JOIN c on b_c.c_id=c.id

gives me results :
execute in 528 ms
mapped in 5919 ms
Example 2
SELECT
	b.type as target_type,
	a.type as type,
	a.id as id
FROM a
LEFT JOIN b on a.b_id=b.id
LEFT JOIN b_d on b.id=b_d.d_id
LEFT JOIN b_c on b.id=b_c.c_id

execute in 491 ms
mapped in 949 ms

Thanks!! that will help.
which version of postgres driver are you using?
I'll check the source code, I'm using getObject to detect null and deal with aggregation, but I should be able to replace it with the proper call as we should have the type with the metadata.
I might also add the possibility of providing a getter for the key if all fail.

    <dependency>
        <groupId>org.postgresql</groupId>
        <artifactId>postgresql</artifactId>
        <version>42.2.5</version>
    </dependency>

getObject looks fine, I wonder if there is some safepoint biais in there. will try to create a benchmark using postgres.

discriminators seems to perform good, the problem occurs when I add the b_c_id column to the query which may make the mapper instantiate a new C object (which is not part of the discriminator mechanism) if the Child B class has a c attribute.
Please tell me if this is not clear.

so the time is spent checking the key for breaks and null. I have a feeling that for each type the key is added which would increase the number of checks being made. validating that now.

yep looks like it, I should be able to fix that.
Benchmark                                             Mode  Cnt      Score     Error  Units
DiscriminatorBenchmark.testNoDiscriminator            avgt    5     48.025 ±   5.033  ms/op
DiscriminatorBenchmark.testWithDiscriminator          avgt    5     93.178 ±   4.201  ms/op
DiscriminatorBenchmark.testWithDiscriminatorWithKeys  avgt    5  10041.184 ± 841.473  ms/op

and that will be with last fix
Benchmark                                             Mode  Cnt    Score   Error  Units
DiscriminatorBenchmark.testNoDiscriminator            avgt    5   40.451 ± 0.391  ms/op
DiscriminatorBenchmark.testWithDiscriminator          avgt    5   82.501 ± 1.028  ms/op
DiscriminatorBenchmark.testWithDiscriminatorWithKeys  avgt    5  129.344 ± 1.659  ms/op

there was a combinatorial effect the break detector, meaning with b_c_id it would have more than 800 detectors slowing everything down. the codes now will merge does if they have the same key. giving a constant 3. I change the keypredicates to also merge better.
just pushed 6.0.7 to maven central. hopefully that should be it.

As a quick first test, i still have the problem, the timings are the same.
 Maybe I should try to do it using pure jdbc, I'm using dbcp datasource wich may cause something...
I will perform others tests, and let you know.
Once again, thanks for your time.

just to confirm it's the same problem could you try without specifying the keys?

what do you means ? which keys ?

Without the addKeys call on the mapper

Good point !
with
.addKeys("id", "target_id", "target_host_id")

execute in 505 ms
mapped in 930 ms

and with
without addKeys
execute in 449 ms
mapped in 644 ms

I thought I only need to use addKeys for column mapping to *2many relationships. Should I put every relationship column in the addKeys ?

the keys are use for null checking and x-to-many mapping yes, but in 6.0.7 it does some optimisation of the sub context only when keys are set - it matters only for mapper with discriminators -, I just need to find a way to do it better soon to come in 6.0.8.
when the keys are not set it does not do null check or break detection so no perf impact there.
if you don't need the null check - ie id b_c_id is null then c is null - the you don't need the keys. but Ideally, it should not matter.

I thought I quickly fixed in 6.0.8 but no... so avoid that one ...

6.0.9 now available in maven central should address the no keys, keys or partial keys perf issue.

thanks a lot for your support !


Add @oleg-nenashev to the developer list of Filesystem SCM plugin

Request: https://groups.google.com/forum/#!topic/jenkinsci-dev/0wVGYwaoGZA
CC @kutzi and @samngms just in case they see the notification. I am ready to wait for another week just in case

Given the inactivity of the plugin and former maintainers, this request is granted per our usual policy on abandoned plugins.


The website can't be opened.

The website can't be opened. https://obfuscator.io

+1

+1 goes down multiple times per day

Looks like I need to run it through pm2

pm2 or forever

Closed. Will look on forever when i'll have a time


Reset of a form does not reset picker to initial value

Environment

Tech
Version

material-ui-pickers
2.2.4

material-ui
3.9.3

React
16.8.6

Browser
Chrome 73

Peer library
<EMAIL_ADDRESS><EMAIL_ADDRESS>

Steps to reproduce

use Formik-Example from https://material-ui-pickers.dev/guides/form-integration and add a form-reset-button - e.g.: https://codesandbox.io/embed/l9zr45yx9m
change the initial date
click reset-button

Expected behavior
the date should be reset to the initial date e.g. 03/04/2019
Actual behavior
it visibly clears the date, although internally the value is reset to the initial date
Live example
https://codesandbox.io/embed/l9zr45yx9m

Shipped in v3


Cassandra 17531 Refactor python code from bin to pylib

This change splits main() and the majority of the cqlsh.py code into a new file, cqlshmain.py in the pylib directory.  What remains in cqlsh.py is mostly the zip loader and a few startup sanity checks.
Note, the first commit renames bin/cqlsh.py to pylib/cqlshlib/cqlshmain.py to preserves the git history across the rename.
The second commit create a new bin/cqlsh.py file as a startup script, and refactors the cqlshmain.py file so it's callable (as suggested by Jeff Widman)

@smiklosovic can you take a look at this? It'd be helpful to separate out the "entrypoint" from the "library logic", so that others can leverage the library logic more cleanly.


what config and where to add to start monitoring services from otel agent.

We are trying to add the windows services config in yaml file for otel agent. But looks like I am not adding correct config code to yaml file. Please suggest the same.
I added as below, but not getting metrics data.
receivers:
signalfx:
smartagent/memory:
type: telegraf/memory
smartagent/win_services:
type: telegraf/win_services
serviceNames:

Spooler

Hello @RPooja08 😃
Have you taken a look at our Smart Agent --> Splunk Otel Collector Agent migration guide?
You will need to make sure you are adding each respective receiver to your service pipeline definitions - an example

Yes, I did but I am not getting any data to SFX with this.

That log message implies your receivers are defined under a receiver_creator and not just receivers`-  can you double check this? A full config would be better to look at than the snippet.

Yes, I am able to do the things, but how we can populate the custom metrics. I have tried the same way but looks like there issue.
I am getting the below error in application logs:
Problem running SQL query or converting datapoints
Stack Trace:

@RPooja08 Can you post your full config with your sensitive information redacted please?

Hi, @mstumpfx Thank you so much for your guidance, I am able to do the correct configurations.


Deleting an account

Just had a user request to delete his entire account. This should be supported.

moved to roadmap


The file 'Normal.cur' is needed

It says when trying to install the .inf file:

I downloaded each cursor separately from each .cur file, has worked instead


What about supports for auto checking for different C++ standards?

some package in vcpkg repo doesn't support C++ 17 well, it can block the job.
What about let auto checking on github check for different C/C++ standards.

Hmm... How can we do that?
@BillyONeal Do you have any suggestions?

Hmm... How can we do that?
@BillyONeal Do you have any suggestions?

I don't have any such suggestions. Generally speaking well-behaved ports don't care about the consuming project's standard mode being greater than that the port uses.

I don't have any such suggestions. Generally speaking well-behaved ports don't care about the consuming project's standard mode being greater than that the port uses.

I don't have any such suggestions. Generally speaking well-behaved ports don't care about the consuming project's standard mode being greater than that the port uses.

I don't have any such suggestions. Generally speaking well-behaved ports don't care about the consuming project's standard mode being greater than that the port uses.

@BillyONeal

I don't have any such suggestions. Generally speaking well-behaved ports don't care about the consuming project's standard mode being greater than that the port uses.

When building poppler in C++17, I have found 2 ports that are not C++17 compatible:

https://github.com/libjpeg-turbo/libjpeg-turbo (fixed)
https://github.com/boostorg/exception (blocking my project now)

I know it's time consuming to check for different C/C++ standards, but in the future, when newer C++ standard become a default compiler option, some port will not work by default. Is it a problem?

@BillyONeal

I don't have any such suggestions. Generally speaking well-behaved ports don't care about the consuming project's standard mode being greater than that the port uses.

When building poppler in C++17, I have found 2 ports that are not C++17 compatible:

https://github.com/libjpeg-turbo/libjpeg-turbo (fixed)
https://github.com/boostorg/exception (blocking my project now)

I know it's time consuming to check for different C/C++ standards, but in the future, when newer C++ standard become a default compiler option, some port will not work by default. Is it a problem?

@playgithub Yep, but before that, upstream should already support cxx17.

@playgithub Yep, but before that, upstream should already support cxx17.


@JSONField Annotation cannot be applied to Annotation

I found that the com.fasterxml.jackson.annotation.JsonIgnore can be applied to an Annotation, which makes the composition of annotations possible.
It would be useful while defining custom annotations, for example, compositing both fastjson's @JSONField and jackson's @JsonIgnore
I wonder if fastjson could add this feature in the near feature.

that's a good idea to add jsonignore feature

3 years have passed, still not added

突然发现@JsonIgnore注解起作用了，我的属性序列化时被忽略了，导致出现bug了，唉~~~~~~~


Move frequency to SPI config

This will move stm32-spi frequency settings from function parameters to config, see #1682.
Tested on NUCLEO-F303K8, not tested for #[cfg(any(spi_v3, spi_v4, spi_v5))] variant.

why was this closed?

accidentally

looks good! Can you change the examples so that they all show how to set the frequency? It's a very basic thing that everyone using SPI will need, so it's nice that the examples show how to do it.

Good point


new(libsinsp/test): add basic tests for networking and container events

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:
These new tests exercise simple cases of ipv4/ipv6 connections (which we all know can have many weird corner cases), including some highlighted here: https://github.com/falcosecurity/libs/issues/260 , plus container metadata parsing through container events.
More importantly, I think, convenience functions to deal with sockaddr have been added, so that people that need to add more tests don't need to figure out the scap format for connections.
This brings libsinsp coverage from ~19% to  ~23%~ ~24%
Which issue(s) this PR fixes:

Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: LucaGuerra
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [LucaGuerra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/milestone 0.10.0
But this can be moved to 0.9.0 as it adds tests, IMHO.

Will be reopening this now, with 50% more refactoring and rebasing


Add CAP 21: Crucibelle

For whenever the playtest is planned!

Merge this when the playtest happens.


Pset add blinder role

Before there was no option to calculate blind pset outputs.
After the method BlindOutputs is added, it is possible to blind outputs of PSET.
It closes #45  .
As per comment here this will close #74
Please @altafan can you review this?

It would be nice if the blinder could expect an argument with a rng function so that it uses the generateRandomNumber only as a fallback.

Can you elaborate more on this?

I am trying to blind same PSET tx as in this test case, so there is one input and 3 outputs.
My test is failing in this line cause vbl=4 != gbl=3.
vbl = input + output values = 1 input + 3 output
gbl = generatorBlindings = inputVbfs + outpuVbfs = 1 input + 2output
I was debugging mentioned JS test case and I see that method blindGeneratorBlindSum receives input with same count of vbl and gbl and it TC is passing

@altafan do you think that it can be issue with validation in line ?

My guess is that you are including the value of the fee output within values while it should not.

@altafan, test case is passing now and I can see confirmed blinded transaction in the explorer.
can you double-check if anything should be updated?

Awesome!
LGTM, but I would add another test cases that uses confidential input instead of non confidential ones. Basically we need to do the same test, but instead of funding a bech32 address with the faucet, we fund a blech32 one.
This means that at the very beginning of the test we create a random private blinding key that we will use to then unblind the faucet output that we'll use as input of our test transaction. The public key derived, instead, is used to create the confidential blech32 address.

Awesome! @sekulicd
LGTM, but I would add another test cases that uses confidential input instead of non confidential ones. Basically we need to do the same test, but instead of funding a bech32 address with the faucet, we fund a blech32 one.
This means that at the very beginning of the test we create a random private blinding key that we will use to then unblind the faucet output that we'll use as input of our test transaction. The public key derived, instead, is used to create the confidential blech32 address.

Considering that this is the way to create blech32 address:
        privkey, err := btcec.NewPrivateKey(btcec.S256())
	if err != nil {
		t.Fatal(err)
	}
	pubkey := privkey.PubKey()

	publicKeyHashCompressed := btcutil.Hash160(pubkey.SerializeCompressed())
	fmt.Println(hex.EncodeToString(publicKeyHashCompressed))

	program := append(pubkey.SerializeCompressed(), publicKeyHashCompressed...)
	fmt.Println(hex.EncodeToString(program))

	blech32Addr := &address.Blech32{
		Prefix:  "el",
		Version: 0,
		Data:    program,
	}

How should I create scriptpubkey and signature, as we dont have option to create blech32 payment which would hold these two values like in case of p2wpkh for eg.:
changeScript := p2wpkh.Script
legacyScript := append(append([]byte{0x76, 0xa9, 0x14}, p2wpkh.Hash...), []byte{0x88, 0xac}...)

Awesome! @sekulicd
LGTM, but I would add another test cases that uses confidential input instead of non confidential ones. Basically we need to do the same test, but instead of funding a bech32 address with the faucet, we fund a blech32 one.
This means that at the very beginning of the test we create a random private blinding key that we will use to then unblind the faucet output that we'll use as input of our test transaction. The public key derived, instead, is used to create the confidential blech32 address.

Considering that this is the way to create blech32 address:
        privkey, err := btcec.NewPrivateKey(btcec.S256())
	if err != nil {
		t.Fatal(err)
	}
	pubkey := privkey.PubKey()

	publicKeyHashCompressed := btcutil.Hash160(pubkey.SerializeCompressed())

	program := append(pubkey.SerializeCompressed(), publicKeyHashCompressed...)

	blech32Addr := &address.Blech32{
		Prefix:  "el",
		Version: 0,
		Data:    program,
	}

How should I create scriptpubkey and signature, as we dont have option to create blech32 payment which would hold these two values like in case of p2wpkh for eg.:
changeScript := p2wpkh.Script
legacyScript := append(append([]byte{0x76, 0xa9, 0x14}, p2wpkh.Hash...), []byte{0x88, 0xac}...)

UPDATE:
@altafan, for the changeScript and legacyScript i took bellow values:
blech32ScriptPubKey := append([]byte{0x00, 0x14}, publicKeyHashCompressed...)
legacyScript := append(append([]byte{0x76, 0xa9, 0x14}, publicKeyHashCompressed...), []byte{0x88, 0xac}...)

Please advise if this is correct.
Assuming that this is correct I am trying to add WitnessUtxo:
updater.AddInWitnessUtxo
but considering that Utxo is now confidential, as we funded blech32 address, I need to add Surejction and Range proof.
Since Utxo doesnt contain Surjection and Range proof, idea is to fetch full transaction.
In order to do this I took txId from utxo and invoked:
/tx/{txId}/hex
I receive full transaction in raw bytes which I am able to decode using elements-cli, now the problem is that the method, I assumed, should be used to decode raw tx:
transaxction.NewTxFromBuffer
is throwing error and I am not able to fetch previous transaction from which I am planning to take Surjection and Range proof that are needed when unblinding inputs.
Please advise if I missed something.

I was not intending to modify the running integration test by using a confidential input, but rather to create a new one.
Said that, the confidential address format, blech32 this case, is just a way so that I, receiver of a transaction, can pass my blinding pubkey to the sender in order to him being able to blind my outputs with a key that I'm aware of.
For a confidential output, thus, the output script does not change at all compared to the unconfidential one, so you should not be worried it.
The WitnessUtxo field of a partial input is of type transaction.TxOutput that already contains the field for range and surjection proofs.
If you fetch a utxo that does not have proofs it may mean that it's not a confidential utxo at all?
In general the NonWitnessUtxo is used when managing utxos locked by p2pkh script, just to let you know.


Compiler errors are really ugly

At some point in the last few months we ended up making compiler errors much more ugly:
$ flutter create dummy_compiler_error
...
$ cd dummy_compiler_error
$ sed -i '$d' lib/main.dart
$ flutter run
Launching lib/main.dart on Lenovo TB 8504F in debug mode...
Running Gradle task 'assembleDebug'...

Compiler message:

lib/main.dart:52:50: Error: Can't find '}' to match '{'.

class _MyHomePageState extends State<MyHomePage> {

                                                 ^

Compiler message:

lib/main.dart:52:50: Error: Can't find '}' to match '{'.

class _MyHomePageState extends State<MyHomePage> {

                                                 ^

Target kernel_snapshot failed: Exception: Errors during snapshot creation: null

build failed.

FAILURE: Build failed with an exception.

* Where:

Script '/home/ianh/dev/flutter/packages/flutter_tools/gradle/flutter.gradle' line: 896

* What went wrong:

Execution failed for task ':app:compileFlutterBuildDebug'.

> Process 'command '/home/ianh/dev/flutter/bin/flutter'' finished with non-zero exit value 1

* Try:

Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 7s
Running Gradle task 'assembleDebug'...                              8.4s
Exception: Gradle task assembleDebug failed with exit code 1

The very first error message happens very quickly. We should abort there. Instead we seem to try to compile again, and then try to do something else in gradle, not sure what.
cc @jonahwilliams

So what I think is happening here is that the tool initializes the frontend_server for the hot reload cycle concurrent with whatever native build step is running (Gradle/Xcode). This speeds up the initialization of flutter run a decent amount, about 5 - 10 seconds depending on how "dirty" the build is. Something I didn't think about when doing this was errors! Now we're getting them twice whenever there is a problem with Dart code.
One possible solution would be to buffer/delay the stderr from the frontend server initialization. If the Gradle/Xcode build fails, it is likely redundant and can be skipped. If the native build step passes, then it can be shown - this could happen if the tool is running with --use-application-binary and skipped the native build step.
After the native build is complete, the errors from the frontend_server would need to be shown as normal.

Makes sense.
Ideally we'd also do something about the verbosity of the gradle output. My ideal output from the case above would be:
$ flutter create dummy_compiler_error
...
$ cd dummy_compiler_error
$ sed -i '$d' lib/main.dart
$ flutter run
Launching lib/main.dart on Lenovo TB 8504F in debug mode...
lib/main.dart:52:50: Error: Can't find '}' to match '{'.
class _MyHomePageState extends State<MyHomePage> {
                                                 ^
$

We definitely need to fix the footer telling users to run with --stacktrace, since that doesn't exist for Flutter. The problem with parsing Gradle output in general is that it is basically unstructured text, and I'd rather show ugly output then accidentally hide real output.

Removed the double errors and the extra newlines and compiler message: text.

Nice.
For the Gradle stuff, is there some way we can detect that Gradle is including one of our own messages, and if we know that's happening, we filter out everything else? For example, set some sort of environment variable when we're running gradle, and have the compiler output text with private-use Unicode characters when that variable is set, and filter them out in the output, etc?

We could probably tell by looking at the task names, which we should know already since we ask gradle to list them out.


Small fix

👷 Deploy Preview for balkantransport processing.
🔨 Explore the source changes: 522a09ae81ce6f7201634318c2edd6b0b3480dd8
🔍 Inspect the deploy log: https://app.netlify.com/sites/balkantransport/deploys/61abfb8e8820850007c2d483


Remove unused syntax tags from ast_src.rs

These have to be reviewed manually. There are several which are no longer used.

This was fixed in #96


ScalarPotential Help Documentation out of date

Describe the bug
Inaccurate description of ScalarPotential in the documentation. Now, ScalarPotential can be initialized without gradient and can be done only with a function. ScalarPotential then numerically calculates the gradient (check #84). However, the help says it requires two functions

Thanks for this feedback, @Craftyleosteel; I'll update the documentation.

I've now updated the documentation and the correct specification for ScalarPotential is fixed by #232 and will be available in 0.5.7


Profile Image - Add Nightwatch Tests

Issue Description
The profile image component needs nightwatch tests written to functionally verify the component behaves as expected. The current tests only visit the test URLs.
Issue Type

[ ] New Feature
[ ] Enhancement
[ ] Bug
[x] Other

This has been released in<EMAIL_ADDRESS>


Manually call drawAsync?

The chartOrig watch isn't firing when I receive new data for the chart.
                    $scope.$watch('chartOrig', function () {

Is there a way to manually call drawAsync?

Hey @turian  could you please show me how you fixed this ?


fix: use native uuid generator when possible

This PR updates uuidv4 to use native secure uuid generator when possible. This method works on server side js runtimes as well as browsers. IT falls back to the default behavior when secure uuid generator is not available.

thanks @twlite !


Misc improvements

-Removed vendor prefixes, since autoprefixer should deal with that instead.
-Added css class to not get blinded by white images in dark themed website:D
-Visual borders to separate tiers better (It would also make sense to center align the tier-letters in case of multiple rows of characters, but i couldnt figure out how to do it. Either way looks fine i guess)

-Visual borders to separate tiers better (It would also make sense to center align the tier-letters in case of multiple rows of characters, but i couldnt figure out how to do it. Either way looks fine i guess)

I honestly think it's better this way, centering everything is not always good, in this case I prefer it that way because the position is consistent accross all tiers instead of having one that is center aligned but not consistent wit the others (because of several rows of costumes or not)


feat: add accept_application route and usecase

Codecov Report

Merging #135 (4d37173) into main (21dee51) will decrease coverage by 1.63%.
The diff coverage is 32.63%.

@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
- Coverage   58.99%   57.36%   -1.64%
==========================================
  Files          63       65       +2
  Lines        1790     1841      +51
==========================================
  Hits         1056     1056
- Misses        734      785      +51

Impacted Files
Coverage Δ

src/application/contribution/accept_application.rs
0.00% <0.00%> (ø)

src/application/contribution/apply.rs
0.00% <0.00%> (-100.00%)
:arrow_down:

src/infrastructure/database/models/applications.rs
0.00% <0.00%> (ø)

...nfrastructure/database/repositories/application.rs
0.00% <0.00%> (ø)

src/infrastructure/database/schema.rs
0.00% <ø> (ø)

src/main.rs
0.00% <0.00%> (ø)

src/routes/contributions/apply/mod.rs
90.00% <ø> (ø)

src/routes/mod.rs
0.00% <ø> (ø)

src/domain/entities/application.rs
12.50% <33.33%> (-37.50%)
:arrow_down:

...rc/routes/contributions/applications_list/tests.rs
89.28% <75.00%> (-2.72%)
:arrow_down:

... and 7 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


simplify reverseText function in click me example

will this work for any string? (even crazy multi-byte unicode?)

oh no idea, I only tested it for 'Click me !' and 'Hello World'
otherwise, maybe: new String.fromCharCodes(text.codeUnits.reversed);

/cc @Sfshaza

Hey, Kasper!
Thanks so much for this!
I actually have a CL ready to go (but not sent out yet) that removes this example from the repo because it is no longer used on dartlang. In fact, it removes several examples that we are either not using on dartlang, or that we are now maintaining in DartPad.

This example has been removed. Thanks for your feedback!


STIX 2.1 JSON "Round Trip" in and out of stix.owl (TAC Ontology)

We have successfully identified the method to convert STIX 2.1 JSON documents into the STIX Ontology (stix.owl). However, we need to convert TAC knowledge graphs into STIX 2.1 JSON. This will be a lossy conversion because we can represent more in the STIX Ontology.

This Issue is related to Issue #46 is about ingesting only.

I'm going to close out this issue and replace it with two smaller scoped issues. The first to address ingestion of STIX 2.1 JSON, and the second to address the conversion back to JSON from TAC-O


use --time-cond when caching the formula api json

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[ ] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

This is to fix #13583 by using --time-cond "<date>" instead of --header "If-Modified-Since: <date>" when refreshing the cached Formula API. This prevents older versions of curl (such as the Apple-supplied curl in macOS Big Sur) from writing a zero-byte .json file. My change will also skip the mtime comparison and overwrite the cache file if the cache file is empty, in order to automatically fix this issue on affected systems.

Great work @steveh7812!


when the point of label out of viewPortHandler.contentRect, we should not draw the label

when the point of label out of viewPortHandler.contentRect, we should not draw the label
1.for bar chart, if the label point is out of contentRect vertically, ignore it and continue
2.for horizontal bar chart, if the label point is out of contentRect horizontally, ignore it and continue

Add a horizontal bar chart example to show th reason. there is a -100 label drawn out bound of y axis range.

Hold on, today I met a bug introduced by my commit, the pt.y is actually less than contentRect.origin.y, and it should be drawn.
Wondering why. Still pending investigation.


Rework the event system of sc-network

This PR introduces NotificationService which gives protocols direct access to the ConnectionHandler and allows them to bypass NetworkWorker when communicating with remote peers. When a protocol is initialized, a handle pair is created and the other half of the handle is given to the protocol which allows it to send and receive notifications and peer events from network. The other half is given to Notifications which it uses to communicate with the protocol directly.
PR also introduces the concept of configurable handshakes. This allows us to do two things:

allow protocols to start using custom handshakes
allow protocols to decide whether they want to accept or reject the inbound substream

Previously Peerset was entirely in control of choosing which peers to accept/reject which caused problems with /block-announces/1. The slot allocation is part of  ProtocolController which may be incorporated into NotificationService in the future but whether the peer is accepted or rejected is now done by both the protocol and by Peerset.
polkadot companion: https://github.com/paritytech/polkadot/pull/7582
cumulus companion: https://github.com/paritytech/cumulus/pull/2983
Fixes #13554, fixes #6403, fixes #13838, fixes #5685

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2879754

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate-macos
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2894244

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2901915

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2903436

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2903837

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2943021

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2949755

Introduced a MessageSink abstraction which should make the NotificationService easier to use. After #1262 is merged and the NetworkBridgeRx issues are resolved, this is ready for review.

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-each-crate-macos
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2992289

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3247354

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3248100

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3326887

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3332415

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3341255

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3351121


DSND-2503: Stop FormatDate.format() being called twice and failing on the 2nd pass

Describe the changes

Added a check to see if the source text is already correctly formatted
Updated the integration tests to include an example where double transformation could occur
Added a guard to stop bulk integration tests being run in normal builds
Updated the readme to add details of the environment variable, RUN_BULK_TEST used to guard the bulk tests
Updated POM to use Spring Boot 3.2.4

Related Jira tickets
DSND-2503
Developer check list
General

[x] Is the PR as small as it can be?
[x] Has the Jira ticket been updated with any relevant comments?
[x] Is the README up to date?
[x] Has the POM been updated for the latest versions of dependencies?
[x] Has the code been double-checked against main?
[x] Does the code adhere standards in this repository, including SonarQube checks?

Testing

[x] Do the code changes have unit and integration tests with code coverage > 80%?
[ ] Has the code been tested locally and/or passed the API Karate tests on Tilt?
[ ] Have mandatory manual test cases been run?
[ ] Are extra Karate tests required?
[ ] Are all the test data resources up to date?

Release preparation
Where possible, add links to the respective Jira tickets when an item is checked

[ ] Have these changes been included in a release ticket?
[ ] Are changes required to the docker-chs-development deployment or test data?
[ ] Are any changes required to the environment added to chs-configs?

Notes to the tester
Add any testing hints or instructions here.

CI: No security warnings found

CI: No security warnings found


Discount not applied in evaluate_policy?

Maybe I am missing something here but I feel the line to calculate return:
https://github.com/keiohta/tf2rl/blob/82d9eecda78e22021efa0821bf02429ac7827f4d/tf2rl/experiments/trainer.py#L207
should be updated to include the discount factor
            for j in range(total_steps):
                action = self._policy.get_action(obs, test=True)
                next_obs, reward, done, _ = self._test_env.step(action)
                avg_test_steps += 1
                if self._save_test_path:
                    replay_buffer.add(obs=obs, act=action,
                                      next_obs=next_obs, rew=reward, done=done)

                if self._save_test_movie:
                    element = self._test_env.render(mode='rgb_array')
                    frames.append(element)
                elif self._show_test_progress:
                    self._test_env.render()
                episode_return += reward * np.power(self._policy.discount, j)

@naji-s
As far as I know, the episode_return is used only for logging not for training, so that it doesn't matter.
In my opinion, when we compare experiments, it is better to use non-discounted total reward because discount factor is a tunable hyper parameter.

@ymd-h well the model is trained based on that discount factor, so not including that discount factor does not lead to fair comparisons between two different models. And here is an example of one of the algorithms implemented in tf2rl that actually reports discounted results:
https://arxiv.org/pdf/1509.06461.pdf

I agree with @ymd-h that the evaluation score does not include the discount factor.
I think the reason why the DDQN paper reports the discounted return is to evaluate the overestimation phenomenon: since the Q-network produces the estimated discounted cumulative rewards, the "true" return should be computed with the discount factor.
I don't think other paper reports discounted return.

@keiohta, well why would the average return even plateau if there is no discount factor, virtually in all of these papers. Isn't it the case that most of these models without a discount factor won't even have converging return functions?

@naji-s I'm a bit confusing. Are you talking about training return or evaluation return?
I and @ymd-h talk about how to evaluate the policy, and I'm saying it's common to evaluate it as the average total reward over several episodes. The way tf2rl evaluates the policy follows other libraries and papers, that also use average total rewards as an evaluation metric.

@keiohta, I am also new to the literature. So I might be completely missunderstanding things. But I give more concrete examples. For example in the paper "Decoupling Representation Learning from Reinforcement Learning" there are the following plots:

All these plots have the return converging to a value as the time-steps increase. I do think to be able to guarantee this a discount factor is necessary otherwise the value would not converge. For example the top left 2nd one (cartpole: swingup) has the value of convergence to 800 as the number of steps increases. Am I wrong? Don't you need discount for the return to converge for certain?

Hi @naji-s ,

I do think to be able to guarantee this a discount factor is necessary otherwise the value would not converge.

Yes, we need the discount factor for training an RL agent. However, the evaluation is done without the discount factor. The training and evaluation is different.

Hi @keiohta,
Thank you so much for the clarification. Just a final question. Then these plots above are training results? Cause they do converge.

@naji-s
Although the paper (maybe) doesn't describe the definition, I think the plots show non-discounted rewards by using models trained with discounted rewards.
As long as discount factor (gamma) is fixed (and n-step is fixed), you can use the discounted reward for model comparison, but it is not universal metric.
In order to improve model performance, we try to tune discount factor, so that the metric itself should be independent of discount factor.


pty.js

With pty.js, the value of this library is undefined.

@stevenvachon I'm not at all familiar with pty.js. Given that it's just a library, not a standard, this seems like something you'd need to dig into yourself. A quick search yielded the following:  https://github.com/chjj/pty.js/commit/07a7efc3f3c8938c171af3297e179334fc0bf150. Perhaps this is related to a solution.
closing since this doesn't seem related to window-size. if it is, please provide more information about specifically what is causing the bug along with a stack trace and information necessary for anyone else to reproduce the bug.

https://github.com/enquirer/readline-utils/issues/4


Unannotated View Available By Default

Although implemented, the unannotated view could not be accessed as BPBrowser initialize did not call CodeHolder initialize. That is because Browser overwrites initialize, thus not setting ContentsSymbolQuints of BPBrowser. One might argue calling CodeHolder >> addContentsSymbolQuint: afterEntry:  would be more suitable, but as the unannotated view should indeed be part of the BPBrowser's default selections, manually setting the variable was my preferred choice.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 65.804%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1195

Relevant Lines:
1816

💛  - Coveralls


NavigationLink's cell view not working inside grid

Image and text rendered in the grid view
   Grid(viewModel.items){ item in                                         NavigationLink(destination: BookDetail(displayData: item)){                                             SearchBookCell(displayData: item)                                             }                                        }                                       .gridStyle(                                         ModularGridStyle(columns: 2, rows: .fixed(200))                                            ).animation(.easeInOut)

@nobanhasan2 do you have a NavigationView one level above grid?
var body: some View {
    NavigationView {
        Grid(...)
    }
}

@nobanhasan2 I just added a working example with #79.
Closing this for now.

please see this screenshot
https://drive.google.com/open?id=1WqTVLlI4AMMxioBADtkNLrH4K-At6-lY

@nobanhasan2 ok. I'm not sure what is now working for you there. Can you clarify.

Here is the full code. I don't know why its overlay on my image and also in text.
`    var body: some View {
ZStack {
Color(0xedeef0)
.edgesIgnoringSafeArea(.all)
NavigationView{
VStack {
SearchBookBar(text: $viewModel.searchText)
//                List(viewModel.items) { item in
//
//                NavigationLink(destination: BookDetail(displayData: item)) {
//                    SearchBookCell(displayData: item)
//
//                }
//            }
//            .navigationBarTitle(Text("MeenaClick Search"))
Grid(viewModel.items){ item in
NavigationLink(destination: BookDetail(displayData: item)){
SearchBookCell(displayData: item)
}
}
.gridStyle(
ModularGridStyle(columns: 2, rows: .fixed(200))
).animation(.easeInOut)
                          }
        }

           }`

@nobanhasan2 you mean where is the blue square should be an image rendered?

@nobanhasan2 my guess is you are missing this line.
https://github.com/spacenation/swiftui-grid/blob/978cc2eae7ced4a4d3cf9b6728503edc62a2969f/GridDemo iOS/StaggeredGrid/StaggeredGridView.swift#L14

@ay42 Yes.. i can solve the image render with that line but there Text is also rendered . Text has no function like renderingMode . How can i solve this?

@nobanhasan2 for text color change .accentColor(...), .foregroundColor(...) ? Is that what you are trying to do just a color change?

i didn't do any color change. Everything was fine without NavigationLink

@nobanhasan2 navigation link makes it a button and it's rendered with system accent color

Ohhh now i see. Thank you so much bro for your help ^_^

@nobanhasan2 np


Trouble after pipenv install (11.6.3)

I have trouble after $ pipenv install (11.6.3):
/pipenv/vendor/requests/packages/urllib3/connectionpool.py", line 595, in urlopen
    chunked=chunked)
  File "/Users/vikkyshostak/.local/share/virtualenvs/django_visatorus-fiOUaYzG/lib/python3.6/site-packages/pipenv/../pipenv/vendor/requests/packages/urllib3/connectionpool.py", line 355, in _make_request
    self._raise_timeout(err=e, url=url, timeout_value=conn.timeout)
  File "/Users/vikkyshostak/.local/share/virtualenvs/django_visatorus-fiOUaYzG/lib/python3.6/site-packages/pipenv/../pipenv/vendor/requests/packages/urllib3/connectionpool.py", line 315, in _raise_timeout
    raise ReadTimeoutError(self, url, "Read timed out. (read timeout=%s)" % timeout_value)
requests.packages.urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host='pypi.org', port=443): Read timed out. (read timeout=10)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/vikkyshostak/.local/share/virtualenvs/django_visatorus-fiOUaYzG/lib/python3.6/site-packages/pipenv/resolver.py", line 66, in <module>
    main()
  File "/Users/vikkyshostak/.local/share/virtualenvs/django_visatorus-fiOUaYzG/lib/python3.6/site-packages/pipenv/resolver.py", line 54, in main
    results = resolve(packages, pre=do_pre, sources=project.sources, verbose=is_verbose, clear=do_clear)
  File "/Users/vikkyshostak/.local/share/virtualenvs/django_visatorus-fiOUaYzG/lib/python3.6/site-packages/pipenv/resolver.py", line 52, in resolve
    return pipenv.utils.resolve_deps(packages, which, project=project, pre=pre, sources=sources, clear=clear, verbose=verbose)
  File "/Users/vikkyshostak/.local/share/virtualenvs/django_visatorus-fiOUaYzG/lib/python3.6/site-packages/pipenv/../pipenv/utils.py", line 429, in resolve_deps
    r = requests.get('https://pypi.org/pypi/{0}/json'.format(name), timeout=10)
  File "/Users/vikkyshostak/.local/share/virtualenvs/django_visatorus-fiOUaYzG/lib/python3.6/site-packages/pipenv/../pipenv/vendor/requests/sessions.py", line 488, in get
    return self.request('GET', url, **kwargs)
  File "/Users/vikkyshostak/.local/share/virtualenvs/django_visatorus-fiOUaYzG/lib/python3.6/site-packages/pipenv/../pipenv/vendor/requests/sessions.py", line 475, in request
    resp = self.send(prep, **send_kwargs)
  File "/Users/vikkyshostak/.local/share/virtualenvs/django_visatorus-fiOUaYzG/lib/python3.6/site-packages/pipenv/../pipenv/vendor/requests/sessions.py", line 596, in send
    r = adapter.send(request, **kwargs)
  File "/Users/vikkyshostak/.local/share/virtualenvs/django_visatorus-fiOUaYzG/lib/python3.6/site-packages/pipenv/../pipenv/vendor/requests/adapters.py", line 499, in send
    raise ReadTimeout(e, request=request)
requests.exceptions.ReadTimeout: HTTPSConnectionPool(host='pypi.org', port=443): Read timed out. (read timeout=10)

How to solve this?

looks like a problem with your internet connection (or pypi). Can't do anything about that!


Introduce storage lookup benchmarks

Since future performance improvements are likely to be increasingly intricate, it's a good idea to introduce some benchmarks in order to ensure that they are beneficial.
For now, they were used just to double-check the positive impact of https://github.com/AleoHQ/snarkOS/pull/1546 and https://github.com/AleoHQ/snarkOS/pull/1548.
Future PRs will likely introduce some insertion and deletion benchmarks as well.

Rebased.


have an ENV variable for recipient_delimiter

Would like to be able to set multiple recipient_delimiter @once with having to manually change conf files…
actually I tried but don't really get why it failed ( chg done in postfix/main.cf + dovecot/conf.d/90-plugin.cf…even tried 90-sieve.cf ). probably need to change something in master.cf too…

Hey @solariane. Thanks for opening an issue which would make docker-mailserver better. Sadly, with your description, we cannot help you, as we have no logs, no configuration files, and no used template.
CONTRIBUTING.md clearly states one must use the issue template. This is done so we can manage this issue tracker. Please follow this guide by either changing this issue or creating a new one.
In case you chose the pormer, please re-open this issue, I will take care of the labels.


update wallet grpc credentials setup.

This updates the wallet gprc credentials setup to incoming v1.6.0 requirements.
S/O to @jrick  for the heads up.

This is reusing the server's cert/key to also act as a client authentication cert? I suppose this works, but it's strange to me.


Re-implement & test #139

Fixes #139, #140
This compileBlade function is mostly based off of what Laravel uses in their own test suite.
I went with this, as rendering a view with conditions for both test-cases became too messy (and blade view caching kicks in as well, giving inconsistent test results):

Closed in favour of #186


OTG with BOP causes a crash.

OTG Plugin or Mod
[Please specify if it's about Forge Mod or Spigot server Plugin placing "x" into []]

[X] OTG Mod for Forge
[ ] OTG Plugin for Spigot

OTG Version
[Please specify the full OTG version that you are running by placing "x" into []]

[ ] 1.12.2_v8_r1
[ ] 1.12.2_v7_DEV_r26
[ ] 1.12.2-v6
[ ] 1.12.2-v5
[ ] 1.11.2-v8
[ ] 1.11.2-v9
[ ] 1.10.2-v21
[X] Other - specify here
Latest Dev release within #otg-dev-releases on Discord.

Forge or Spigot Versions
crash-2020-04-30_22.50.49-server.txt
What other plugins are you running?
Listed within the crash report.
Description
Entering any world causes a crash.
[What did you expect to happen? - Explain what you expected to happen after performing the previously described steps]
Entering fine.

I just tested OTG, Biome Bundle and BoP and started a world with no issues.

You had this same issue, lol.

Have not been able to reproduce this issue with only OTG/BB/Bop. I see many other mods listed in the logs, please try to remove mods to see which exact combination is causing the issue, thanks!


chore: adjust labels

:tada: This PR is included in version 1.0.1 :tada:
The release is available on:

GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


[feature] Verify pre-releases

In v2.1.0 tags need to be semantic versions of the form vX.Y.Z without metadata.
This means that the verifier can't verify artifacts for pre-releases. We should allow users to verify artifacts on pre-releases somehow. Perhaps via an option if we don't allow it by default.

Actually it seems like you mean builder RC's?

Yeah, sorry. I thought originally this affected artifacts, but it is actually just the builder version check. I still think we should have an option for this, but it's not quite as big an issue.
https://github.com/slsa-framework/slsa-verifier/blob/v2.1.0/verifiers/internal/gha/builder.go#L144-L150


[WIP] Extended Validation of New Nomad Worker Nodes

This change introduces extended validation of new worker nodes after a scale-out operation has been initiated.
Previously, Replicator would verify the ASG successfully launched a new EC2 instance but would not verify the node successfully completed bootstrapping and joined the Nomad worker pool.
The new node validation mechanism for scale-out operations will be

Initiate scale-out operation and verify the autoscaling group operation completes successfully. This method has a ticker that will keep attempting to verify until a timeout threshold is reached.
Identify the most recently launched worker node instance
Verify the new node has completed bootstrapping and successfully joined the worker pool. This method has a ticker that will keep attempting to verify until a timeout threshold is reached.
If the node fails to join the worker pool, we will increment the node failure count (a new internal struct field).
If we haven't reached the retry threshold, we'll terminate the most recent instance and attempt to launch another node.
If we have reached the retry threshold, the most recent instance will be left in place for evaluation and troubleshooting. Cluster scaling will be disabled and no further cluster scaling attempts will be permitted. In future changes, we will add the ability to send notifications which will be triggered here.

This is a WIP pull request; need to run full tests on a development cluster before merging.
Closes #47

Ok, I've completed testing and evaluation against an actual cluster and confirmed desired behavior.
While testing, I've identified some corner cases and changes in behavior that we'll implement in separate issues:

When we've hit the retry threshold and disable cluster scaling, rather than just leave the failed instance in the ASG for debugging purposes, we'll detach the instance from the autoscaling group and decrement the ASG desired count. This will ensure we can smoothly resume scaling operations when the daemon is restarted while allowing operations personnel to keep the "dirty" instance around as long as they'd like for debugging purposes. This is tracked as #69.

The ScaleOutCluster() method in client/aws should only attempt to increment the ASG desired count if the number of nodes in the worker pool matches the desired count. This is tracked as #70.


feat: add a contributors page #32

feat: add a contributors page #32
it contains repo insights and all dev details with their img name commits .
issue no. #32
Closes: #32
Accept this PR under hacktoberfest and gssoc-ext.
I really hope to get a level 3  label, as it took alot of time and code.
@kvcops i hope i meet your expectations. thank you

@kvcops  i hope you would like the changes and take decisions for best of both sides. thank you

Why did you go out of the way and created an html page in a repo which uses python and flask
The Contributors page should be a part of the flask module and written in accordance to that.
This way of adding a contributors page is very incorrect and I believe would spoil the structure of the repo.
I need this to be done in accordance to how Flask handles web pages otherwise this PR and Issue will be closed

@Wahid7852 are you discord?


Kafka url config is not honored

Describe the bug
Configuring kafka with a custom url (not localhost:9092):
const kafka = new Kafka({
	clientId: 'my-id',
	brokers: [KAFKA_URL]
})

const admin = kafka.admin()

When I run await admin.connect() it works fine (and I verified that if I give a wrong url it fails here).
However when I run await admin.fetchTopicMetadata(undefined as any) I get this error:
{"level":"ERROR","timestamp":"2020-06-17T04:10:33.960Z","logger":"kafkajs","message":"[Connection] Connection error: connect ECONNREFUSED <IP_ADDRESS>:9092","broker":"<IP_ADDRESS>:9092","clientId":"krowser","stack":"Error: connect ECONNREFUSED <IP_ADDRESS>:9092\n    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1128:14)"}

You can see in the error message that the url is <IP_ADDRESS>:9092 and not the one I configured.
To Reproduce
You can reproduce with my application here: https://github.com/tzachshabtay/krowser
Steps:

clone the repo
run npm i
run npm run build:backend
run npm run build:frontend
In test/docker-compose-single-broker.yml  change the exposed port to 9093 instead of 9092. I.e change this line:
https://github.com/tzachshabtay/krowser/blob/0de0d03c722b8e8906583edd82af56c74af47446/test/docker-compose-single-broker.yml#L23 to be - "9093:9092"
run npm run kafka-up to start kafka with the 9093 port (and also schema-registry and zookeeper), wait a few minutes for kafka to boot
run export KAFKA_URL=localhost:9093 (this tells my application to configure kafkajs with this url)
run npm start to start the application. This should work (and this calls admin.connect)
In the browser go to localhost:9999 (this calls fetchTopicMetadata). Then observe the logs on the server to see the errors.

Expected behavior
Calling admin.fetchTopicMetadata should use the same kafka url config that I assigned it (and the same url used by admin.connect)
Observed behavior
Calling admin.fetchTopicMetadata ignored my url config and used <IP_ADDRESS>:9092.
Environment:

OS: Mac OS Moave 10.14.4
KafkaJS version: 1.13.0-beta.4
Kafka version: 5.2.1
NodeJS version: 12.13.0

This is not a bug in KafkaJS, but rather a misconfiguration of your Kafka broker. See https://github.com/tzachshabtay/krowser/blob/0de0d03c722b8e8906583edd82af56c74af47446/test/docker-compose-single-broker.yml#L25
KAFKA_ADVERTISED_LISTENERS is defining what address and port your Kafka broker is "advertising itself" as listening on. Meaning, if you ask your broker: "Hey, what's the address to the current controller broker?" it will respond with the advertised listener address & port. In your case, that's LISTENER_DOCKER_EXTERNAL, which is ${DOCKER_HOST_IP:-<IP_ADDRESS>}:9092. So what's happening is that on initial connect, we connect to whatever address you gave us in the brokers array, which is correctly pointing to the exposed port of your docker container, but then that broker will return another address, which is the LISTENER_DOCKER_EXTERNAL address, which is incorrectly configured to use port 9092.
If you just change the LISTENER_DOCKER_EXTERNAL address to use port 9093, it should work just fine.

@Nevon if I change LISTENER_DOCKER_EXTERNAL to be ${DOCKER_HOST_IP:-<IP_ADDRESS>}:9093, then I get an error on admin.connect:
{"level":"ERROR","timestamp":"2020-06-17T16:18:27.153Z","logger":"kafkajs","message":"[BrokerPool] Failed to connect to seed broker, trying another broker from the list: Closed connection","retryCount":0,"retryTime":308}

Sorry, I must have misread the configuration in my haste. Regardless, this is simply a misconfiguration of Kafka itself. As I explained, the address that you specify in the brokers array is just used for the initial connection. Once the initial connection as been established, the broker will give us whatever the address is for the other brokers in the cluster, by using the KAFKA_ADVERTISED_LISTENERS configuration.
Your initial connection works because you are correctly pointing to your container on the correct port. However, when you call fetchTopicMetadata we ask the broker who is the current controller, and it gives us back an address which does not point to the correct container. From what you are saying, it is telling you to connect to <IP_ADDRESS>:9092, which as you can see in your config is the default you have set in case the environment variable DOCKER_HOST_IP is unset.
Robin Moffat from Confluent explains this in this article: https://rmoff.net/2018/08/02/kafka-listeners-explained/ I recommend that you read through it.


Adds a new icon set named Fontisto (http://fontisto.com)

Recently I found a good icon-set named Fontisto
This PR adds it to the react-native-vector-icons icon sets

@rfbezerra this is a great PR but you're also doing many other things. Could you please extract the version bumping to a separate PR (that can fix and have a positive impact over existing issues: #993, #972 )

Oh, my bad.
I didn't realize this version bump.
I'll fix and push again.

You have included old commits somehow, they have incorrect hashes and will mess with existing commits. Could you fix them as well? 🙂

I don't know what happened before, but I think this is ok now.
Can you check now?

Indeed, this font is really nice! The code looks fine and there is a build script as well 👍 Only thing is, could you add it to the directory and IconExplorer project as well? 🙂

@rfbezerra since I don't have push access to your fork, I've cloned it and did the work. Here's the diff that you can apply:
https://drive.google.com/file/d/1TNkKa3jtMxm5puSfE_hwoZTXTMb23KVC/view?usp=sharing
git apply {document}.md
Please do let me know if you need any help with this. Thanks!

I updated sources.
Did you know why every time I run yarn to install dependencies, all integrity fields from yarn.lock is deleted. I'm using node v10.6.0 with yarn v1.9.4.

@rfbezerra I don't know about the yarn.lock. :(
You forgot to add Fontisto to Examples/IconExplorer plist.
My workflow on doing is npm link (root directory) -> npm link react-native-vector-icons (Examples/IconExplorer) -> react-native link.

Only thing left  that I can find is that the font is not added to the IconExplorer ios project, I'd do it myself but I am currently not near a computer 🙂 Maybe linking the app should be enough but don't take my word for it.

I test only in Android, my bad.
I added through react-native link
Seem to be good now

🥳🥳 LGTM
@hampustagerud could you please take another look before merging it?
Thanks

Thank you both 🙂

🤗 🍾 🎉


Please move vm-kernel-precomp-obfuscate-linux-release-x64-try to the main console.

Obfuscation is important for several Flutter customers.

Done


absent lower incisors - synonyms

absent lower incisors MP:0004791
NEW SYN: missing lower incisors
NEW SYN: absent mandibular incisors
NEW SYN: missing mandibular incisors
NEW SYN: agenesis of lower incisors
NEW SYN: agenesis of mandibular incisors
NEW SYN: aplasia of lower incisors
NEW SYN: aplasia of mandibular incisors
NEW SYN: mandibular incisor aplasia
NEW SYN: mandibular incisor agenesis
Anna

Synonyms have been added.


[Data Mapper] Transformation functions with union return types are not supporting query expressions within function body

Description:
$Subject

When having union return type, the output data types and intermediate clauses are not visible

When it returns a single type, the things are appearing as expected

Steps to reproduce:
Sample code:
type Person record {
    string id;
    string firstName;
    string lastName;
    int age;
    string country;
};

type Student record {
    string id;
    string fullName;
    string age;
    record {
        string title;
        int credits;
    }[] courses;
    int totalCredits;
    string visaType;
};

function transform(Person[] people) returns Student[]|error => from var item in people
    select {}

Affected Versions:
Ballerina 2201.3.2
Plugin v3.3.9

This is causing due to: https://github.com/ballerina-platform/ballerina-lang/issues/39642
Should be resolved after fixing the above.
Also we should add support for union return type within function definition level query expressions too (https://github.com/wso2-enterprise/ballerina-plugin-vscode/blob/dev/workspaces/data-mapper/src/components/Diagram/visitors/NodeInitVisitor.ts#L178)


Cypress tests

Created tests dir

@AndrewLebowski please move tests locations from src/tests/automated.. to simply /cypress
like recommended here
https://docs.cypress.io/guides/core-concepts/writing-and-organizing-tests.html#Support-file

@AndrewLebowski lets see how we can integrate this with travis CI

@AndrewLebowski
ok that's a good start, but its not that straight forward.
since we need to run cypress on the build result. so we first need to build the code then we can run the unit tests+cypress, BUT cypress needs to run on the new code, currently you run it on goodqa which is always running the staging branch not the current branch which is being tested.
So what we need to do is as follows:
1.


respect ID: link format in .org files

Hi there, thanks for making such a great plugin!
As discussed on the obsidian forum, I'd love to see this plugin format and obey the "ID:" link format in org-mode.
discussion in orgmode manual here
and two screenshots (link display toggled on and off in emacs)

It is a great feature I agree.
Linking to an ID inside the file in one thing, but linking to an ID in another file is more complicated.
It implies to parse all the files in the vault, the plugin currently only parse one file at a time.
My understanding is that emacs can only resolve ID links if you have the buffer of the target file open. Is that how you use it?

No emacs (orgmode) will resolve an ID link anywhere in org-directory (and subdirectories if configured appropriately), whether or not it’s in a file that’s currently in a buffer.
I believe org-roam further enhances this by keeping a table of links and backlinks in a sqlite database, and updating the table every time a new link is created.
I agree; I don’t see any way to do it without some kind of either pre-processing or on-demand search. I imagine that’s how obsidian’s linking to nodes works as well?
in the short run, at least formatting the links, even if resolving doesn’t work, would be valuable. Especially with the auto org-generated uuid link style, my notes are pretty unreadable.

Implemented in 2.3.0
I went with an on-demand search.
When clicking on an :ID: link, the plugin will open all the .org files of the vault, parse them and look for a matching id.
It works fine for a few files but it's possible it might take a long time with a large vault of org files, I didn't test it.
Obsidian has a caching mechanism to not have to read the files from disk every time so that's already a good optimization.

This works great, thanks!


add new colors to freeplay

this PR fixes the color thing at Monster, Winter Horrorland and Thorns by the characters' icon colors (like #386)
screenshots:

No.


[structure][agent class] Move Overlapping Methods to a Shared Base Class

BaseSingleActionAgent and BaseMultiActionAgent are pretty much the same. In the original PR where MultiActionAgent was introduced, @hwchase17 shared the worry that MultiActionAgent is so under-explored that it would potentially be really different from the SingleActionAgent. It could still be true when the autonomous agent grows.
Given the above, this PR still keeps the strict distinguishing between these two classes and at the same time reduce the duplicate logics as much as possible. It’s still very convenient to change any of the methods and make them as different as we want.

Test:

as the logic is so deep and core, all existing integration test should be able to cover it.
I’ll add additional integration tests in following PRs when we start ramping up on concrete business inheritance. :)
Tested additionally by calling an agent directly with 2 provided tools and then confirm all functionality the same

def test_agent_chain_chat_bot():
	from langchain.agents import load_tools
	from langchain.agents import initialize_agent
	from langchain.agents import AgentType
	from langchain.chat_models import ChatOpenAI
	from langchain.llms import OpenAI
	from langchain.utilities.duckduckgo_search import DuckDuckGoSearchAPIWrapper

	chat = ChatOpenAI(temperature=0)
	llm = OpenAI(temperature=0)
	tools = load_tools(["ddg-search", "llm-math"], llm=llm)

	agent = initialize_agent(tools, chat, agent=AgentType.CHAT_ZERO_SHOT_REACT_DESCRIPTION, verbose=True)
	agent.run("Who is Olivia Wilde's boyfriend? What is his current age raised to the 0.23 power?")
test_agent_chain_chat_bot()

@vowelparrot , please take a look when you have time. Thank you so much. :)

Will sync with @hwchase17 on this one and review tomorrow

Will sync with @hwchase17 on this one and review tomorrow

Thank you so much. Really appreciate it. :) (let me quickly rebase now to make it easier for you.)

@vowelparrot please lmk what is your discussion result with Harrison. Thank you so much!

some feedback we've gotten from users is theres a lot of inheritance already and it can make it tricky to understand whats going on. although this may save code, i think this contributes to that problem. therefor, i dont think we want to do this at the  moment


codegen performance improvements

Temporarily disables StructuredLogger
Replaces EitherT in Target with a bespoke implementation

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

[x] I acknowledge that all my contributions will be made under the project's license.

Going to move forward with this approach, as the logger improvements are not more important than core performance.


Can´t create private endpoint between Azure and Elasticsearch Service (ESS) with terraform

General Summary
Hi
We are trying to use Elastic Cloud in Azure with Private Endpoint. I´m using this article as an example: azurerm_private_endpoint | Resources | hashicorp/azurerm | Terraform Registry (Private Link Service Alias session)
We already do this manually with success, and now we are automating with Terraform (as a code).
First Part, creating only the Elastic Cluster is ok, but the problem starts when we try to automate the endpoint private part of configuration.
Readiness Checklist

[x] I am running the latest version
[x] I checked the documentation and found no answer
[x] I checked to make sure that this issue has not already been filed
[x] I am reporting the issue to the correct repository (for multi-repository projects)

Expected Behavior
My goal is create a private link for communication between my Vnet in Azure and Vnet of Elastic Cloud service (Saas).
The cluster terraform configuration WITHOUT private links works ok, only the part of private endpoint creation thats I´m having probems.
I´ve tryed with
1) manual option:
`# This resource is establish endpoint between Azure Vnet and Elastic Cloud Vnet by peering
resource "azurerm_private_endpoint" "azure_endpoint_elasticloud" {
name                = "credit-elastic-private-endpoint-${local.location}"
location            = local.location
resource_group_name = local.old_rg_name
subnet_id           = data.azurerm_subnet.aks_subnet_private_link.id
private_service_connection {
name                              = "credit-elastic-privateserviceconnection-${local.location}"
private_connection_resource_alias = local.resource_alias_ec_eastus2
is_manual_connection              = true
request_message                   = "PeeringWithAzure"
}
}
`
2)  and automatic:
`# This resource is establish endpoint between Azure Vnet and Elastic Cloud Vnet by peering
resource "azurerm_private_endpoint" "azure_endpoint_elasticloud" {
name                = "credit-elastic-private-endpoint-${local.location}"
location            = local.location
resource_group_name = local.old_rg_name
subnet_id           = data.azurerm_subnet.aks_subnet_private_link.id
private_service_connection {
name                              = "credit-elastic-privateserviceconnection-${local.location}"
private_connection_resource_alias = local.resource_alias_ec_eastus2
is_manual_connection              = false
}
}`
Current Behavior
I´m receiving this errors when I try
1) Manual
Error: api error: 1 error occurred:
* traffic_filter.azure_private_link_connection_not_found: Can't find Azure Private Link Connection [credit-elastic-private-endpoint-eastus2.[]] in region [azure-eastus2]. Make sure the details are correct and try again later. Please contact support if you think this is an error. with ec_deployment_traffic_filter.azure, on elastic-cloud.tf line 48, in resource "ec_deployment_traffic_filter" "azure": 48: resource "ec_deployment_traffic_filter" "azure" {
2) Automatic
Error: creating Private Endpoint "credit-elastic-private-endpoint-eastus2" (Resource Group "Networking-EC2-STG"): network.PrivateEndpointsClient#CreateOrUpdate: Failure sending request: StatusCode=400 -- Original Error: Code="LinkedInvalidPropertyId" Message="Property id 'eastus2-prod-002-privatelink-service.64359fdd-7893-4215-9929-ece3287e1371.eastus2.azure.privatelinkservice' at path 'properties.privateLinkServiceConnections[0].properties.privateLinkServiceId' is invalid. Expect fully qualified resource Id that start with '/subscriptions/{subscriptionId}' or '/providers/{resourceProviderNamespace}/'."
with azurerm_private_endpoint.azure_endpoint_elasticloud,
on elastic-cloud.tf line 10, in resource "azurerm_private_endpoint" "azure_endpoint_elasticloud":
10: resource "azurerm_private_endpoint" "azure_endpoint_elasticloud" {
PS: I´m using  “eastus-prod-010-privatelink-service.b5765cd8-1fc8-45e9-91fc-a9b208369f9a.eastus.azure.privatelinkservice” in private_connection_resource_alias property
References:
Secure your deployments on Elastic Cloud with Azure Private Link | Elastic Blog
Azure Private Link traffic filters | Elasticsearch Service Documentation | Elastic
Terraform definition
source  = "elastic/ec"
version = "0.4.1"
terraform version: latest:^1.1
Steps to Reproduce
My code terraform:
data "azurerm_subnet" "aks_subnet_private_link" {
name                 =  local.subnet_aks_name
virtual_network_name =  local.vnet_name
#resource_group_name  =  local.rg_name
resource_group_name  = local.old_rg_name
}
resource "azurerm_private_endpoint" "azure_endpoint_elasticloud" {
name                = "credit-elastic-private-endpoint-${local.location}"
location            = local.location
resource_group_name = local.old_rg_name
subnet_id           = data.azurerm_subnet.aks_subnet_private_link.id
private_service_connection {
name                              = "credit-elastic-privateserviceconnection-${local.location}"
private_connection_resource_alias = local.resource_alias_ec_eastus2
is_manual_connection              = true
request_message                   = "PeeringWithAzure"
}
}
resource "ec_deployment" "ec-cluster" {
name                    = "${local.ec_cluster_name}-${local.location}-${local.environment}"
version                 = local.ec_version
deployment_template_id  = local.deployment_template_id
region                  = local.ec_region
traffic_filter = [
ec_deployment_traffic_filter.azure.id
]
elasticsearch {
autoscale = local.autoscale
}
kibana {}
}
resource "ec_deployment_traffic_filter" "azure" {
name   = "traffic_filter_elastic_${local.environment}"
region = local.ec_region
type   = local.filter_type
rule {
azure_endpoint_name = azurerm_private_endpoint.azure_endpoint_elasticloud.name
azure_endpoint_guid = "[]"
}
}
Context
I´m using Azure, and trying to use Elasticsearch Service (ESS) (via Makretplace) and try to communicate by peering between 2 Vnets. The deploy of Elastic cloud service is in Azure too.
Possible Solution
I don´t know, that why I´m here :-)
My Environment

Version used: "0.4.1"
Running against Elastic Cloud SaaS

Duplicates https://github.com/elastic/terraform-provider-ec/issues/504


Use NIO's Files API to replace FileInputStream/FileOutputStream in some paths

What changes were proposed in this pull request?
Use NIO's Files API to replace FileInputStream/FileOutputStream in some paths.

Why are the changes needed?
Follow this PR of spark: https://github.com/apache/spark/pull/20144 and https://github.com/apache/spark/pull/18684
Refer to reason of this change:

Java's FileInputStream and FileOutputStream overrides finalize(), even this file input/output stream is closed correctly and promptly, it will still leave some memory footprints which will only get cleaned in Full GC. This will introduce two side effects:
Lots of memory footprints regarding to Finalizer will be kept in memory and this will increase the memory overhead. In our use case of external shuffle service, a busy shuffle service will have bunch of this object and potentially lead to OOM.
The Finalizer will only be called in Full GC, and this will increase the overhead of Full GC and lead to long GC pause.
https://bugs.openjdk.java.net/browse/JDK-8080225
https://www.cloudbees.com/blog/fileinputstream-fileoutputstream-considered-harmful
So to fix this potential issue, here propose to use NIO's Files#newInput/OutputStream instead in some critical paths like shuffle.

Does this PR introduce any user-facing change?
No

How was this patch tested?
No need.

Codecov Report

Merging #65 (e82169b) into master (bdffcaa) will increase coverage by 1.21%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #65      +/-   ##
============================================
+ Coverage     55.15%   56.36%   +1.21%
- Complexity     1112     1171      +59
============================================
  Files           149      149
  Lines          7969     7969
  Branches        761      761
============================================
+ Hits           4395     4492      +97
+ Misses         3332     3233      -99
- Partials        242      244       +2

Impacted Files
Coverage Δ

...e/uniffle/storage/handler/impl/HdfsFileWriter.java
55.22% <ø> (ø)

.../java/org/apache/uniffle/common/util/RssUtils.java
65.71% <100.00%> (+0.24%)
:arrow_up:

...org/apache/uniffle/server/LocalStorageChecker.java
69.56% <100.00%> (ø)

.../uniffle/storage/handler/impl/LocalFileWriter.java
90.00% <100.00%> (ø)

...ache/uniffle/storage/util/ShuffleStorageUtils.java
61.00% <100.00%> (ø)

...org/apache/uniffle/server/ShuffleFlushManager.java
76.70% <0.00%> (-1.71%)
:arrow_down:

.../apache/uniffle/coordinator/ClientConfManager.java
91.54% <0.00%> (-1.41%)
:arrow_down:

...he/uniffle/client/impl/ShuffleWriteClientImpl.java
26.05% <0.00%> (+0.09%)
:arrow_up:

.../java/org/apache/uniffle/common/BufferSegment.java
100.00% <0.00%> (+3.84%)
:arrow_up:

.../org/apache/uniffle/common/ShuffleIndexResult.java
100.00% <0.00%> (+14.28%)
:arrow_up:

... and 7 more

Could you add some performance results? IShould we only modify the critical code?

Could you add some performance results? Should we only modify the critical code?

Actually i dont make performance test. Just found this optimization while I was browsing spark codebase. Maybe we should ping @jerryshao(the author of spark-21745)

…me paths

Modify the title and description.

@zuston From https://github.com/apache/spark/pull/20119, there has performance issue with NIO's Files API.
I think read data from shuffle server can be improved with solution as zero-copy?

@zuston From apache/spark#20119, there has performance issue with NIO's Files API.

The performance issue is caused by the default InputStream.skip implementation. So i dont replace it in the uniffle LocalFileReader class.

I think read data from shuffle server can be improved with solution as zero-copy?

After browsing spark related codebase, i think maybe using NIO api of filechannel will improve the performance. But just guess, i have no practice on this and need more test.

Any progress? Do i need to do what before merging @jerqi

Any progress? Do i need to do what before merging @jerqi

I think we need some performance tests to prove the pr effectiveness.

I think we could directly follow the Spark change. Besides, the performance test looks hard. @jerqi

I think we could directly follow the Spark change. Besides, the performance test looks hard. @jerqi

I prefer not merging this pr without test. Maybe we can solve this problem util we encounter the similar, at that time, we have the situation to prove the effectiveness of pr.


Geopy 177 alpha

GEOPY-177 - python version not used in github actions
Tester for 177

For testing GEOPY-177


Backport Bitcoin PR#13544: depends: Update Qt download url

This is backport of Bitcoin PR bitcoin/bitcoin#13544.
The original PR description is empty.
Qt download URL has changed, the old one doesn't work anymore.
This change fixes depends build that was broken because of that.

@OlegGirko Thanks! Verified the new Qt URL is valid and the old is not.


Installation error

Hi... I am trying to install this plugin in Intel XDk. I was not able to install it. Have you seen any issue with installation in XDK before
Thanks,
Mallik

The plugin is no more in usage.
Try another one
-----Original Message-----
From: "mallik-nimmagadda"<EMAIL_ADDRESS>Sent: 30-08-2015 03:20 PM
To: "arcoirislabs/mqtt-cordova"<EMAIL_ADDRESS>Subject: [mqtt-cordova] Installation error (#3)
Hi... I am trying to install this plugin in Intel XDk. I was not able to install it. Have you seen any issue with installation in XDK
Thanks,
Mallik
—
Reply to this email directly or view it on GitHub.

Hi,
We are pleased to announce the new and better version of the plugin. We have updated the plugin entirely to work with latest standards of Apache Cordova.
Feel free to ping us for any issues.
Cheers.


EFR32 lock example pairing/connection  is broken on current master

Problem
The current master has the following 2 issues wrt to EFR32 Lock app example -

QR code string is wrong and does not match corresponding to the PIN and discriminator .

Expected Data should be
setup-payload parse-qr CH:H34UKNY00VN2V0E4
Version: 0
VendorID: 9050
ProductID: 21323
RequiresCustomFlow: 0
RendezvousInformation: 2 [BLE]
Discriminator: 3840
SetUpPINCode: 73141520

But when I scan the QR code using a QR code scanner I get the string as CH:W0GU245600C0NF0ET00 because of which the PIN and discriminator have wrong values.

Attempting to pair/control using Python controller fails to establish BLE connection and hence the EFR32 device is not recognized as a CHIP accessory.Here is the log -

test@test:~$ sudo chip-device-ctrl
CHIP:IN: TransportMgr initialized
CHIP:IN: local node id is 112233
CHIP:DL: CHIP task running
Chip Device Controller Shell
chip-device-ctrl > ble-scan
2021-05-05 11:54:10,380 ChipBLEMgr   INFO     use default adapter
2021-05-05 11:54:10,515 ChipBLEMgr   INFO     scanning started
2021-05-05 11:54:20,630 ChipBLEMgr   INFO     scanning stopped
chip-device-ctrl > set-pairing-thread-credential 16 0x00da b3335216512091581d4ddc4b88eb9f53
Thread credential set
chip-device-ctrl > connect -ble 3840 73141520 4536
Device is assigned with nodeid = 4536
CHIP:DL: TRACE: Bluez mainloop starting Thread
CHIP:DL: TRACE: Bus acquired for name C-22c6
CHIP:DL: PlatformBlueZInit init success
CHIP:BLE: BLE scanning through known devices.
CHIP:BLE: Device C8:28:32:E2:15:76 does not look like a CHIP device.
CHIP:BLE: Device 63:98:C7:1F:9B:2A does not look like a CHIP device.
CHIP:BLE: BLE initiating scan.
CHIP:BLE: Device 63:98:C7:1F:9B:2A does not look like a CHIP device.
CHIP:BLE: Device 44:0D:BF:1A:4E:72 does not look like a CHIP device.
CHIP:BLE: Device C8:28:32:E2:15:76 does not look like a CHIP device.
CHIP:BLE: BleConnectionDelegate::CancelConnection is not implemented.
Failed to establish secure session to device: 4050
Device temporary node id (**this does not match spec**): 4536
chip-device-ctrl >

Proposed Solution

QR code string on the latest master should be fixed to generate expected PIN and discriminator value.
Python controller should be able to connect/pair EFR32 lock end device.

Hi Saurab @saurabhst, I am starting to look into this. QRcode does have an isue on current master, but I am successful with the chip-device-ctrl. Did you update your commit for the controller and rebuilt it becasue it seems old.
set-pairing-thread-credential is not available anymore and should have returned a error. The version of your controller might be the issue for the ble-connect
chip-device-ctrl > set-pairing-thread-credential 16 0x00da b3335216512091581d4ddc4b88eb9f53
Pairing Thread Credential is nolonger available, use NetworkCommissioning cluster instead.

Hey Saurab so I tried the master code. I think your issue is just compatibility issues using older commits for the Android Chip-tool and python controller.
I use current master (commit 674d1822662b71ee455821cf53355ea8fb1c62af) rebuild the EFR32 Light app, the Android Chip-tool and Python controller.

chip-device-ctrl > setup-payload parse-qr CH:Y3.1345600C0NF0ET00
Version: 0
VendorID: 9050
ProductID: 21324
RequiresCustomFlow: 0
RendezvousInformation: 2 [BLE]
Discriminator: 3840
SetUpPINCode: 73141520

chip-device-ctrl > connect -ble 3840 73141520 4538
Device is assigned with nodeid = 4538
CHIP:BLE: BLE removing known devices.
CHIP:BLE: BLE initiating scan.
CHIP:BLE: New device scanned: 67:48:F8:96:5E:C3
CHIP:BLE: Device discriminator match. Attempting to connect.
CHIP:BLE: Scan complete notification without an active scan.
CHIP:BLE: subscribe complete, ep = 0xffff951c70e0
CHIP:BLE: peripheral chose BTP version 3; central expected between 2 and 3
CHIP:BLE: using BTP fragment sizes rx 20 / tx 128.
CHIP:BLE: local and remote recv window size = 3
Secure Session to Device Established
Device temporary node id (**this does not match spec**): 4538
chip-device-ctrl >

Please rebuild the tools you use and let me know if this is still an issue for you