Admin url redirects to admin login page

Even though login url is specified,  /admin/, if user is not logged in, redirects to admin login page but not the custom login page. This is a security issue as the admin login page does not support 2FA.

Update at c2e099f502ae1e7d7e2228d096ff43ec3df5dcc4 but the next parameter seems to have unwanted characters.
http://<IP_ADDRESS>:8000/login/?next=/admin/login/%3Fnext%3D/admin/

Django 1.11.3 fixed this issue


Keystone's token validation endpoint used by PEP Proxy

I just installed PEP Proxy and I am trying to validate an access token through it.
PEP Proxy is running on my VM (<IP_ADDRESS>) on port 2000, as I configured it that way.
After I authenticate manually with Keystone, I take the subject token it returns and with it I make a GET request on:

http://<IP_ADDRESS>:2000

putting in as a header with name "X-Auth-Token", as described on the project's home page.
On the Keystone's console, where I can see all requests coming into Keystone, I see one to:

v3/access-token/{acce-token}

which comes from PEP Proxy's attempt to validate my token.
The result PEP Proxy returns is:

User token not authorized

even though the token is indeed valid.
On Keystone's API specs, the /v3/auth/tokens is the endpoint specified to handle token validation instead of the one that PEP Proxy seems to be using, for which I didn't manage to find documentation somewhere.
Can you please give me some help with it?
Forgive me if I am missing some detail which might be the problem.

Hi,
I think your problem is a wrong configuration. Try setting the token_engine option to Keystone if you want to validate against Keystone directly and not throught the IdM portal. https://github.com/ging/fi-ware-pep-proxy/blob/dd516bc12b87228ec56a29ce942328642dbd5758/config.js.template#L41
As you can see here, the validation indeed goes to /v3/auth/tokens. https://github.com/ging/fi-ware-pep-proxy/blob/8f9b09bcff6e3dd00376eeb15eb07fbd094f890a/lib/idm.js#L47
Hope this fixes your issue.
Cheers

That's great.
Thanks for the prompt reply.


Gas prices

refund / eliminating the gas price

@MParlikar can you elaborate on what you are trying to say? thank you!


Update Jeffwan’s company name and add more details for WG-training

Forget to change my company name. I recently leave AWS and join Bytedance.
Add more important fixes and features in WG-training

/cc @jbottum @karkumar

/lgtm

@jbottum Who can approve this PR?

@jbottum
Can you manually merge it?

@Jeffwan I merged this


Telecon November 19th, 12:30 pm PST / 3:30 pm EST

Hi there,
Oscar Esteban is inviting you to a scheduled Zoom meeting.
Topic: dMRIPrep
Time: Nov 19, 2019 12:30 PM Pacific Time (US and Canada)
Join from PC, Mac, Linux, iOS or Android: https://stanford.zoom.us/j/300076945
Or iPhone one-tap (US Toll): +18333021536,,300076945# or +16507249799,,300076945#
Or Telephone:
Dial: +1<PHONE_NUMBER> (US, Canada, Caribbean Toll) or +1<PHONE_NUMBER> (US, Canada, Caribbean Toll Free)
Meeting ID: 300 076 945
International numbers available: https://stanford.zoom.us/u/acdjTpQDNo

Meeting ID: 300 076 945
SIP<EMAIL_ADDRESS>

Sorry guys, I think I won't be able to make it today, I will join the next meeting

Sorry I will be away as well. But I have more time on my hands today and tomorrow to get my PR finished.

This one is pretty tight for me too, and given the low feedback I've received (regarding the meeting) I'm guessing it's looking the same for everyone. It also happens that I've been pushing in other fronts that will unlock @josephmje in his PRs.
Why don't we skip this one and keep working via github & mattermost until the next one?
cc @arokem, @dPys, @mattcieslak, @jelleveraart

Sounds good to me

Sounds good. I will spend that time trying to catch up on the pending PRs.


support yCbCr

new is only support rgb, can you support yCbCr?

Sorry for not being active on this repo @kingslay — I haven't touched it in a while, but if you would like to submit a PR that would be of huge help.

@kingslay did you ever figure out how to support yCbCr here? I am getting a red tinted view.

@kingslay did you ever figure out how to support yCbCr here? I am getting a red tinted view.

我自己搞了一个项目https://github.com/kingslay/KSPlayer 。 在我的项目里面有实现了yCbCr

@kingslay I am unable to find the camera on this app..?

是的，我的这个项目只是支持了播放这块的逻辑。录制这块没有实现


[JS] Support REE

Describe the enhancement requested
As far as I can tell, REE isn’t currently supported in arrow-js. Is this already in the works?
We may be interested in helping by contribute it, especially if it would be acceptable to only support reading it from IPC file/stream (that’s our and I would expect most people’s use case).
Component(s)
JavaScript

CC @domoritz @trxcllnt

We are not working on it yet and would love a contribution. Even if we just support it for reading and not writing that's okay. I think for JS the reading use case is vastly more popular.


[Question]where can I download Full documents?

It's useful for developers that cannot access the internet.

You can download both source code and javadocs for each Maven module. Usually your IDE will help with downloading javaddocs automatically but you can always download the .jar from Maven Central


Feat/iv 32 app UI register page register

UI register page without formik.

:tada: This PR is included in version 1.2.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


feat(state): New state system

What this PR does 📖

This is the PR for a new state system utilising a local subscription method.
For now it implements this system for the message struct in chats.
Goal is to have a system that allows one to update only a selected set of components without updating the whole state.
Something to note is that since this only implements it for messages the actual impact will probably not be noticed much since in a lot of places components still subscribe to the generic State in uplink. We will likely only notice it if the whole State uses this system.
TODO:
[x] Local Subscription system
- [ ] Wrap needed uplink state fields in LocalSubscription
~~- [ ] Change methods in state so they properly subscribe to their correct local subs ~~

this looks almost the same as the implementation of UseSharedState - calling cx.scope_id() and adding that to a list of consumers. How is the new state system different?

this looks almost the same as the implementation of UseSharedState - calling cx.scope_id() and adding that to a list of consumers. How is the new state system different?

The thing with use_stared_state is that it does not support sub components.
If you use use_stared_state you will subscribe to the whole State and any changes in State will cause a rerender for the subscribed component regardless of what was updated.
We can circumvent it by simply splitting State into multiple independent structs and register each of them with use_stared_state but that is hard to manage.
With this we can still mostly keep our current structure.
At the end we would have instead of
State {
  chat: Chats,
  some_other_field: String
}

State {
  chat: LocalSubscription<Chats>,
  some_other_field: String
}

and accessing the local subscription will automatically listen to changes in chat only. If now some_other_field is updated it will not cause a rerender for the component listening to chat

I think this would be good to give a try and see how we like this, it's a nice middle ground between subscribing to specific "nodes" in the state tree, but that sounds a bit difficult and perhaps super verbose, if we like this we can start working on moving more things over to improve performance.

for now waiting for dioxus pr. seems to be more reasonable than merging this and then going back to this again later

Changing to draft until #1081 is complete

https://github.com/Satellite-im/Uplink/pull/1081 was merged 🎉

can you try reproducing it again with the new crash log changes so it says more?

@phillsatellite your error looks like it's related to extensions. if you delete your extensions and recompile them and re-add them, does that error still happen?

I think you are right @sdwoodbury I deleted my emoji file from my extensions, recompiled and app opened fine and I could click on any chat without a crash. Although I need to test more because when I re-add the emoji extension I can still go to all the chats without the app closing but emoji's never appear for me

i actually had this bug rn with no emoji button too but that was on dev branch so its not related to this. restarting the app fixed it though before i that i updated the extension to a new built one. so maybe it was just because of and outdated extension

@phillsatellite your error looks like it's related to extensions. if you delete your extensions and recompile them and re-add them, does that error still happen?

I think you are right @sdwoodbury I deleted my emoji file from my extensions, recompiled and app opened fine and I could click on any chat without a crash. Although I need to test more because when I re-add the emoji extension I can still go to all the chats without the app closing but emoji's never appear for me

i actually had this bug rn with no emoji button too but that was on dev branch so its not related to this. restarting the app fixed it though before i that i updated the extension to a new built one. so maybe it was just because of and outdated extension

When testing on Windows, I did with both DEV and your branch:

cargo update
cargo clean
cargo build --release -F production_mode (to create the .exe).
Then copied the extensions files. (emoji_selector files with different extensions from target/release)

Finally, I saw that the emoji button is displayed on dev:

Not displayed in your branch:

Probably, I am missing any step above?

@phillsatellite your error looks like it's related to extensions. if you delete your extensions and recompile them and re-add them, does that error still happen?

I think you are right @sdwoodbury I deleted my emoji file from my extensions, recompiled and app opened fine and I could click on any chat without a crash. Although I need to test more because when I re-add the emoji extension I can still go to all the chats without the app closing but emoji's never appear for me

i actually had this bug rn with no emoji button too but that was on dev branch so its not related to this. restarting the app fixed it though before i that i updated the extension to a new built one. so maybe it was just because of and outdated extension

When testing on Windows, I did with both DEV and your branch:

cargo update
cargo clean
cargo build --release -F production_mode (to create the .exe).
Then copied the extensions files. (emoji_selector files with different extensions from target/release)

Finally, I saw that the emoji button is displayed on dev:

Not displayed in your branch:

Probably, I am missing any step above?

after some tests i found out that that is caused by an dioxus update. the update also affects the main branch so its not the signals branch causing this.

on Linux I can't build the project. I get this error

and found that in the Dioxus branch, the tray feature is indeed absent from dioxus-desktop.

Pending #1229

This looks cool but I'm not sure how much it will help at the moment.
If a message is updated, the messages still need to be grouped and I believe that would still cause a re-render. Fortunately the chats page has been refactored to not store so many messages in memory.
I wonder if this could help in other parts of the codebase. For example - if a friend comes online, it might be nice to not re-render stuff that doesn't include that friend. Still, for stuff like that I have a theory that it may be easier to have a top level element that pulls everything it needs from State and passes it to a child Element via props. That way if State is updated, in theory the child elements may have the same props and if props don't change, the element doesn't get re-rendered. (this is easier said than done because State gets used everywhere).

unless we do it across the whole app (and not just messages) the gain atm isn't really big.
but e.g. editing messages should only update that one message component and not the whole chat

Closing this for now and we will revisit after the next release of Dioxus.


Menu2 for globalstats

resolves #1736
wait this was actually really easy??

probably because 90% of the code is the same as padle_scroll but renamed but still

i kinda like it better with two newlines between the monster title and rest of the description

I like 2 newlines also
you can use \n\n as your separator, or another option would be to rename the heading to PADle #2 and then give the stats a heading that says Stats to space it out a bit


Make default configurations for data loading similar to torch

Proposition: The defaults for operations should resemble pytorch defaults
Reason: If PyTorch is the primary backend for mosaic, the defaults should be plumbed through, unless there is a key reason why they shouldn't be. If this is the case, we should be clear about these reasons in a section in the documentation (something like Misc Diffs between DataPanel and PyTorch Data Ops)

[x] Change default num_workers to be 0

Needs further discussion:

[x] Change default batch_size to be 1
[x] Add comments for WILDS configs

Codecov Report

Merging #33 (4857b5d) into dev (2fe6e39) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev      #33      +/-   ##
==========================================
- Coverage   63.04%   62.95%   -0.10%
==========================================
  Files          40       40
  Lines        2138     2138
  Branches      369      369
==========================================
- Hits         1348     1346       -2
- Misses        705      706       +1
- Partials       85       86       +1

Flag
Coverage Δ

unittests
62.95% <ø> (-0.10%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mosaic/columns/abstract.py
79.08% <ø> (ø)

mosaic/columns/list_column.py
64.28% <ø> (ø)

mosaic/contrib/wilds/config.py
0.00% <ø> (ø)

mosaic/datapanel.py
74.13% <ø> (ø)

mosaic/mixins/mapping.py
70.49% <ø> (-3.28%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fe6e39...4857b5d. Read the comment docs.


Delete records in test topics (GSI-556)

Replace the delete_topics() function from the kafka test fixture with a clear_topics() function that deletes all records from the specified topics (or all if unspecified).
A consumer may be passed in for cases where pausing the consumer's polling is especially necessary during the delete process, but this shouldn't usually be needed.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 90.504%

Totals

Change from base Build<PHONE_NUMBER>:
0.1%

Covered Lines:
1401

Relevant Lines:
1548

💛  - Coveralls


Change /react RSC path to /__rsc

We copied this behavior from the official RSC demo. But it's definitely going to clash with real applications, and we should use a more namespaced path like /__rsc.
This would be a good opportunity to define this path in a constants file and reference it everywhere.

@jplhomer Can I work on this?

@Aslemammad go for it!

Sure!


Improve responsiveness of Contact Us page

Description
Added new CSS elements to tackle the responsiveness of the Contact Us page. Additionally, corrected spelling mistakes in the navbar (Contact Us was displayed as Content Us).
Fixes: #279
Use [x] to represent a checked (ticked) box.✅
Use [ ] to represent an unchecked box.❌
Type of Change

[ ❌] Profile Added
[❌ ] Project Added
[✅ ] Bug fix
[ ❌] New feature
[ ❌] Documentation update
[❌ ] Other (please specify):

How to Test

Go to the Contact Us page
By using web dev tools change the screen size
Check for responsiveness at different screen sizes

Checklist

[✅ ] I have performed a self-review of my code.
[ ✅] I have commented my code, particularly in hard-to-understand areas.
[ ✅] I have made corresponding changes to the documentation (if applicable).
[ ✅] My changes generate no new warnings.
[✅ ] I have added tests to cover my changes (if applicable).
[ ✅] All new and existing tests pass.

make it responsive

@Gyanthakur I will look into this

@Gyanthakur do I need to close this pull request and make a new pull request after the changes

make it responsive


Use ffmpex to generate thumbnails for videos

https://github.com/talklittle/ffmpex appears to be very easy to use.

Just invoking ffmpeg directly as it was very difficult to figure out how to use FFmpex. And using thumbnex did not help as it did not maintain the aspect ratio, and there were no options to do so.


Update demo installation script to Python 3.9

I'll be updating our demo installation scripts to Python 3.9 now that we're dropping 3.8 support. Given that the tasks 0.7.4 release requires Python 3.9, we can't install them in the demos environments anymore otherwise.
Will update here if any issues come up with it :)

Everything seems to be working fine with Python 3.9 :)


sourceSets.create() uses deperecated/superfluous API

Issue type
Deprecation
Problem description
When using Gradle 8.7 with the Kotlin version it ships with (outdated 1.9.22), the sourceSets.create or sourceSets.creating functions call uses the deprecated setCanBeResolved api, resulting in a deprecation warning:
The resolvable usage is already allowed on configuration ':testARuntimeClasspath. This behavior has been deprecated. This behavior is scheduled to be removed in Gradle 9.0. Remove the call to setCanBeResolved(true), it has no effect.

Here is a GitHub Actions reproduction for context: https://github.com/pauliesnug/gradle-plugin-publish-issue-1/actions/runs/9149209703/job/25152603811#step:4:250
Context (optional)
No response

This is, unfortunately, a known issue that needs to be fixed through collaboration between Gradle and JetBrains. Until it gets resolved, you will see the deprecation warning.
Related YouTrack issue:

https://youtrack.jetbrains.com/issue/KT-66542


support data alignment workflow

support data alignment workflow
add the data workflow template for fast-fold data preprocess

test result

start time  08/17/22  17:21:55
end time 08/17/22 17:35:31

ERROR

speed

[ ]


Migrate Synchronizations.id from TEXT to UUID

Closes #4997
Seems to not have any required dependency and no specific test double so initially only the migration is needed

@juanignaciosl CR please

:+1: When I did this with visualizations I checked every uuid had the right format with select id from visualizations where id not similar to '[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}';, just in case you haven't checked it yet.

Thanks! I checked manually in local, and I'm going to deploy to staging in a few minutes to see there, will try the query there to be sure :dancer:


chore: update configs

:tada: This PR is included in version 6.15.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Can't run primary container and link it with others, unexpected EOF

Hello!
I'am using  windows 7, boot2docker 1.7.0, vagrant 1.7.2
docker run hello-world

Command is working properly
My Vagrantfile
PROJECT_NAME = "myproject"
PROJECT_USER = "vagrant"
PROJECT_DIR = "/home/#{PROJECT_USER}/#{PROJECT_NAME}"
PROJECT_VENV = "/home/#{PROJECT_USER}/.virtualenvs/#{PROJECT_NAME}"

Vagrant.configure(2) do |config|

  # Share folders from host to guest
  config.vm.synced_folder ".", "#{PROJECT_DIR}"

  # Provision
  config.vm.provision :shell, run: "always",
    :inline => "#{PROJECT_VENV}/bin/python #{PROJECT_DIR}/manage.py cleanup_offers_files offers",
    :inline => "#{PROJECT_VENV}/bin/gunicorn -c #{PROJECT_DIR}/vagrant-data/gunicorn.py wsgi"

  # Postgres
  config.vm.define 'postgres' do |postgres|
    postgres.vm.provider 'docker' do |docker|
      docker.image = "postgres:9.4"
      docker.name = "#{PROJECT_NAME}_postgres"
      docker.ports = ["5433:5432"]
    end
  end

  # Redis
  config.vm.define "redis" do |redis|

    redis.vm.provider "docker" do |docker|
      docker.image = "redis"
      docker.name = "#{PROJECT_NAME}_redis"
      docker.ports = ["6380:6379"]
    end
  end

  # Project
  config.vm.define "#{PROJECT_NAME}", primary: true do |project|

    project.ssh.port = 22
    project.ssh.username = "#{PROJECT_USER}"
    project.ssh.password = "123"

    project.vm.provider "docker" do |docker|
      docker.build_dir = "."
      docker.name = "#{PROJECT_NAME}"
      docker.build_args = ["--tag=#{PROJECT_NAME}"]
      docker.remains_running = false
      docker.has_ssh = true
      docker.ports = ["8000:8000"]

      docker.link("#{PROJECT_NAME}_redis:redis")
      docker.link("#{PROJECT_NAME}_postgres:postgres")
    end
  end
end

i'm run commands in this order
vagrant up redis
...
vagrant up postgres
...
vagrant status
postgres                  running (docker)
redis                     running (docker)
myproject                 not created (docker)
...
vagrant up myproject

Then i get error
A Docker command executed by Vagrant didn't complete successfully!
The command run along with the output from the command is shown
below.

Command: "docker" "build" "--tag=myproject" "/mnt/docker_build_3e689d65f93
ff0d2e6b09568619ba4e3"

Sending build context to Docker daemon 10.36 MB524.4 kB
Sending build context to Docker daemon
2015/06/21 13:17:47 Error: unexpected EOF

Stdout:

If i run vagrant up only got
myproject: F:/myproject => /var/lib/docker/docker_1434940393_98361
myproject: F:/myproject => /mnt/docker_build_3e689d65f93ff0d2e6b0956861
9ba4e3
The following SSH command responded with a non-zero exit status.
Vagrant assumes that this means the command failed!
mkdir -p /mnt/docker_build_3e689d65f93ff0d2e6b09568619ba4e3
Stdout from the command:
Stderr from the command:

mkdir: can't create directory '/mnt/docker_build_3e689d65f93ff0d2e6b09568619ba4e
3': No such device or address

Please help resolve this problem. Thanks!

Vagrant debug info
Stdout:
 INFO interface: Machine: error-exit [
"VagrantPlugins::DockerProvider::Errors::ExecuteError",
"A Docker command executed by Vagrant didn't complete successfully!\nThe command run along with the output from the command is shown\nbelow.\n\nCo
mmand: \"docker\" \"build\" \"--tag=itcase/myproject\" \"/mnt/docker_build_3e689d
65f93ff0d2e6b09568619ba4e3\"\n\nStderr: Sending build context to Docker daemon 5
24.4 kB\rSending build context to Docker daemon 1.079 MB\rSending build context
to Docker daemon 1.632 MB\rSending build context to Docker daemon  2.17 MB\rSend
ing build context to Docker daemon 2.705 MB\rSending build context to Docker dae
mon 3.262 MB\rSending build context to Docker daemon  3.82 MB\rSending build con
text to Docker daemon 4.377 MB\rSending build context to Docker daemon 4.934 MB\
rSending build context to Docker daemon 5.491 MB\rSending build context to Docke
r daemon 6.048 MB\rSending build context to Docker daemon 6.605 MB\rSending buil
d context to Docker daemon 7.162 MB\rSending build context to Docker daemon 7.71
9 MB\rSending build context to Docker daemon 8.276 MB\rSending build context to
Docker daemon 8.801 MB\rSending build context to Docker daemon 9.336 MB\rSending
 build context to Docker daemon 9.884 MB\rSending build context to Docker daemon
 10.35 MB\r\r\nSending build context to Docker daemon \r\n2015/06/22 12:46:29 Er
ror: unexpected EOF\n\nStdout: "]

Issue on https://github.com/mitchellh/vagrant/issues/5854


Could FSharpSymbols have a method like Roslyn's ToDisplayParts

If we have a ToDisplayParts method (or similar) it would make for closer interaction between F#'s symbols and Roslyns.
References:
ISymbol
SymbolDisplayPart

Yes, I suppose it could :)

closing old question.


fix: use command stdin for password, and do not log password

Cause: The code was constructing the realm join command to be passed
via the shell module, including piping the password into the command,
and was showing the command, including the password, when using
check mode.
Consequence: The clear text password was available in the logs when
using check mode.
Fix: Use command with stdin for the password instead of shell.  The
password is not part of the command.  command with stdin is more
secure than using shell.
Result: The password is not logged.  The role is more secure.
Signed-off-by: Rich Megginson<EMAIL_ADDRESS>

[citest]

[citest]

@richm is there a Jira for this?

@richm is there a Jira for this?

A bz, yes


How to attach a consumer to specific partition of a topic with group-id?

Describe the bug

Suppose I have a topic say testTopic and it has three partitions say [0,1,2]. I have slightly different usecase where I would be having multiple consumer with different consumer-Id's listening on specific partition of a topic(say partition  0).  Elaborating - I want three consumers namely c1 (group-id firstGroup), c2 (group-id secondGroup) and  c3(group-id thirdGroup) handling events only from partition 0  of testTopic.

Question -

I have tried to read doc, it has partitionAssigners but I can't understand how to use it? Is it place which can solve my usecase? or this is not supported in this library?

Any feedback on this?


[Host] Publishing to a request/response queue (no replyto header)

Publishing an event to a request/response queue results in an exception being thrown because no ReplyTo header has been set.
MessageBusBase.cs
if (!requestHeaders.TryGetHeader(ReqRespMessageHeaders.ReplyTo, out object replyTo))
{
    throw new MessageBusException($"The header {ReqRespMessageHeaders.ReplyTo} was missing on the message");
}

It could be useful to instead perform a no-op when the header is missing to allow for a single handler to be used by both IRequestResponseBus.Send and IPublishBus.Publish (where the response can be ignored).

Makes sense to change!

Closed by #272


Remove PipelineResources usage in the examples

Changes
PipelineResources are deprecated for a long time and will be removed
very soon.
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs included if any changes are user facing
[ ] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[x] Meets the Tekton contributor standards (including
functionality, content, code)
[x] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
Removing the PipelineResources usage in the examples as they are
deprecated and will be soon removed

Depends on https://github.com/tektoncd/chains/pull/733 as well.

Created https://github.com/tektoncd/chains/issues/734 to track the rest of the removal.

/remove-approve
(i suspect prow doesn't know about the github actions workflows, which is probably why the last PR was able to submit even with the workflow failing).

Yeah, I think this could be fixed by having the github action as required (because I think even if it doesn't "own" those, it should respect their status)..

hum.. the e2e tests are failing.. 😓

Updating the json (in testdata) wasn't the easiest task 🙃 I wonder if it would make sense to use golden file instead maybe ? 🙃

Updating the json (in testdata) wasn't the easiest task upside_down_face I wonder if it would make sense to use golden file instead maybe ?

I'm not familiar with the golden file. Is that something that comes from plumbing?

I'm not familiar with the golden file. Is that something that comes from plumbing?

@lcarva it's a general term for a static expected output file - https://ieftimov.com/posts/testing-in-go-golden-files/
So instead of having the templated json we would just have several <testcase>.golden.json/<testcase>.out.json files instead.

I'm neutral here - I think part of the reason why we do things this way is to insert runtime values like timestamps, but if we have a way to stabilize these with golden files that seems fine!

I'm neutral here - I think part of the reason why we do things this way is to insert runtime values like timestamps, but if we have a way to stabilize these with golden files that seems fine!

Yeah that was my guess as well. Honestly I am neutral as well, I just thought of this when editing them 🙃


breaking: Better Scene Events

This is the final form I have been working towards over the land few PRs. Untangling things to make this functional in as small of a PR as I could manage. There are two TODO that represent fixes that are possible during/after this PR.
Depends on #304 and #305
This particular PR starts at: breaking: uniform scene change events and FinishSceneLoad use events (41e469e). The other commits are the dependencies listed above.
All of the before/after events for client/server provide the scene and operation type so the user can decide how they want to respond to the actions happening. An AdditiveLoad is not a full scene change but the user may still want to do something about it like load new UI elements.
I am not thrilled with how FinishSceneLoad still looks. Will think about better ways to do that part.
All tests pass locally. I did some manual testing with Tanks and SceneChange example. From what I can tell everything functions as intended. But I will do another round of testing later to make sure sleepy brain isnt forgetting something.

good work!


Adden new Maven plugin to readme.

Maybe something like developed at [DC/OS labs](https://github.com/dcos-labs) ?

Thanks @joerg84 !
    .  o ..
     o . o o.o
          ...oo
            __[]__          Shippin'
         __|_o_o_o\__         it!
         \""""""""""/
          \. ..  . /
     ^^^^^^^^^^^^^^^^^^^^


InputLiteral rendering driven by Resource and Entity State

The InputLiteral component uses a combination of React component state and props to drive the rendering of a Property Template type literal in a Resource Template. Instead of passing down the property template in a prop and then setting the state in componentDidMount based on both the propertyTemplate and the formData.items, all props should be set in the Redux reducer calls in the mapStateToProps based on the InputLiteral's reduxPath with the reduxPath using the stored Resource Templates in the entities object in the Redux state for such things as repeatable and mandatory.
Blocks #673

completing this ticket depends on #698.


Hardware keyboard: codegen

Description
This PR rewrites tools/gen_keycodes, the script that generates key mappings across the framework and the engine.
Some major changes include:
Split physical keys and logical keys. This is the major reason why this PR needs to be a rewrite. Previously the list of physical keys and logical keys are identical, both generated from Chromium's dom_code_data.inc. With this PR, the logical keys are now collected from dom_key_data.inc instead. To accomplish this, KeyData and KeyEntry are split into physical and logical versions, and the values of all logical keys (which were calculated from USB HID code) are redefined.
Implemented engine mappings. The code used to generate engine mappings for various platforms has been added. The result of these code has been submitted in various engine PRs including https://github.com/flutter/engine/pull/23466 (Web), https://github.com/flutter/engine/pull/23465 (Windows), https://github.com/flutter/engine/pull/23469 (macOS) and https://github.com/flutter/engine/pull/23467 (Linux GTK). This PR publishes their generation logic.
Engineering enhances. This PR converts the entire script into null-safety; converts KeyEntry and KeyData into immutable classes; enables assertions and applies assertions across the script; document all input files in data/README.md.
Other notable changes include:
Removed most file-specifying options. Most options to specify input files are removed. I don't find them useful at all, and they greatly increases the difficulty of maintenance, especially with a lot more input files after this PR.
Modified logical value masks. A few masks are added, such as "leftModifier" "rightModifier" "keyPad". The "synonym" bit is changed.
Fixed RawKeyboard logic. How RawKeyboard.logicalKey is derived on iOS and macOS is fixed to query the mapping table first.
Related Issues

Umbrella: flutter/flutter#44918

Tests
I added the following tests:
This PR doesn't needs tests.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] I signed the CLA.
[ ] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
[ ] I updated/added relevant documentation (doc comments with ///).
[ ] All existing and new tests are passing.
[ ] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[ ] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[ ] No, no existing tests failed, so this is not a breaking change.
[ ] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

@gspencergoog My apology for submitting this giant PR altogether. I can't find a way to split it.

@gspencergoog I think I've taken care of all comments. Can you take another look?

@gspencergoog I should have addressed all issues (hopefully)


Rename and add deprecation warnings to for section names

This adds some renaming in the docs and checks for old configuration values since we are standardizing our naming of the primary/secondary sidebars.

@choldgraf Would you have time to update this soon (to fix the tests and merge conflicts)? It would be nice to get this in 0.11.

hmmm - this is going to be a kind-of nasty rebase. I think it'll be easiest to just start it over from scratch to be honest. I am not sure if I have time to this so I'd recommend not blocking this on a release

superceeded by #988


Save and restore $env:PSModulePath until we find why it's being clobbered on PS Core

Fixes #175 .
Changes proposed in this pull request:

Save and restore $env:PSModulePath around the critical block

How to test this code:
pwsh
Add-WindowsPSModulePath
Import-Module PoshRSJob
Import-Module PoshRSJob
(I don't think it's possible to reproduce this on AppVeyor)
Has been tested on (remove any that don't apply):

Powershell 3 and above
Windows 7 and above

Thanks @codykonior ! That is a weird issue.


Fix GroundPrimitive documentation

For #3214

Thanks, merged.

Oh true... both are out. Have we checked if the extension is supported for iOS and Safari?


Black screen when turning on a display connected via DisplayPort

Describe the bug
Turning display off and on again result in black screen if X server is active.
To Reproduce
Steps to reproduce the behavior:

Be sure X server is running and active
Turn off the display
Turn the display on

Note the display works as expected if you switch to a VT before turning on the display.
Expected behavior
Turning on the display should not result in black screen.
Additional context
OpenGL renderer string: Radeon RX 580 Series (POLARIS10, DRM 3.40.0, 5.10.5, LLVM 11.0.0)

The amdgpu driver is used.
Metadata
Nixpkgs used:
    "nixpkgs_2": {
      "locked": {
        "lastModified":<PHONE_NUMBER>,
        "narHash": "sha256-hCsGe2nDz+SX4uO+lj0qPVcSGZdt52R9Yk5MOYs4djw=",
        "owner": "NixOS",
        "repo": "nixpkgs",
        "rev": "257cbbcd3ab7bd96f5d24d50adc807de7c82e06d",
        "type": "github"
      },
      "original": {
        "owner": "NixOS",
        "ref": "nixos-unstable",
        "repo": "nixpkgs",
        "type": "github"
      }
    },

I can confirm this. With the same gpu, this happened to me as well with a recent nixpkgs update.
Thanks for the workaround btw.

I can confirm this. With the same gpu, this happened to me as well with a recent nixpkgs update.
Thanks for the workaround btw.

I can also reproduce, same GPU. I'm not sure how recent it is - I only just got my DP display and assumed it was something to do with the protocol! I can't reproduce this with VGA, DVI, HDMI etc.

I can also reproduce, same GPU. I'm not sure how recent it is - I only just got my DP display and assumed it was something to do with the protocol! I can't reproduce this with VGA, DVI, HDMI etc.

For me, the problem has disappeared after a recent nixpkgs update and a restart. Unfortunately I cannot tell what the fix was.

For me, the problem has disappeared after a recent nixpkgs update and a restart. Unfortunately I cannot tell what the fix was.

Likewise, I can no longer reproduce this.

Likewise, I can no longer reproduce this.

(maybe not strictly the same issue) but just in case someone is having similar experience for the first time, in my case the fix was just simply to delete .config/monitors.xml* and reboot.


Trezor - Error trying to execute a tx

Safe and env: https://pr1771--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x9913B9180C20C6b0F21B6480c84422F6ebc4B808/transactions
Steps:
Create a new tx, one of the owners being a trezor account
Give the safe some funds
Create a "Send funds" tx.
Sign with all the owners, but do not execute
Connect with the trezor account
Try to execute the tx
The issue only happens when there are 2 or more owners and all the signatures were collected, so the "Execute" button is shown since I was able to create and send funds when the trezor was the only owner of the safe.
In the following snapshot I tried to execute a tx which already has all the signatures needed.
Error in the notification:
"Confirmation transaction failed - execution reverted: Invalid owner provided
0x08c379a000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000016496e76616c6964206f776e65722070726f766964656400000000000000000000"

Tried using the trezor account imported in the MM extension for chrome.
It fails that way as well, and MM shows an error in the modal to sign the tx:

Tried using the trezor account imported in the MM extension for chrome.
It fails that way as well, and MM shows an error in the modal to sign the tx:

Update: Rejecting a tx is possible. It doesn't cause this issue to show up

Update: Rejecting a tx is possible. It doesn't cause this issue to show up

This issue was solved while solving Trezor estimation issues in #1788
It was related with gas estimation changes and could potentially affect other wallets too

This issue was solved while solving Trezor estimation issues in #1788
It was related with gas estimation changes and could potentially affect other wallets too

It works well now
Tested here: https://pr1771--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0xfcBFa810e2578bB38d8874392a2237Db3b326389/transactions

It works well now
Tested here: https://pr1771--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0xfcBFa810e2578bB38d8874392a2237Db3b326389/transactions


Scale() should have an origin property

Rotate() now supports an origin property, allowing rotations around an arbitrary origin. Scale does not, only supporting scaling around the lower left of the canvas. This means that to achieve control over scaling a widget, you need to wrap Scale in two Translate commands. It would be nice if Scale also had an origin property to avoid this.

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/6387623-scale-should-have-an-origin-property?utm_campaign=plugin&utm_content=tracker%2F42681&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F42681&utm_medium=issues&utm_source=github).

Working on this one now.

Really working on it now.

Stuck.I am adding origin property to scale exactly like it was done in rotate, it still does not work.
This( https://gist.github.com/rastogiachyut/afc7dd9d0526ac3c894f ) code does not work, this is my Scale class in context_instruction.pyx file( https://gist.github.com/rastogiachyut/1c82e1c9d23b3c11ef11 ) ,Why? Ive hit a dead end.

Here's my try at fixing this:
https://gist.github.com/hey-sancho/b131a6d02d9f15838beb
Tried to do the same way as in Rotate - everything uses compute() function, which translates and scales the object. Rewritten set_scale() to work via compute(), but i guess it could become deprecated as the Rotate.set.
@rastogiachyut, I don't know what result did you get, but my version makes your code look like this:

@hey-sancho
Sorry for the late reply.
I submited a PR for this a while but it did not get pulled.
here -> https://github.com/kivy/kivy/pull/3070
your fix looks right too.

I don't know if your code works in all cases, mine does.
But yours looks better cause it makes a new function compute.
Well make a PR and let the devs decide.

made a clean new pull request https://github.com/kivy/kivy/pull/3134
please pull if satisfactory.


DEV-466

SonarQube analysis reported 2 issues

 1 major
 1 minor

Watch the comments in this conversation to review them.

Coverage decreased (-0.3%) to 82.869% when pulling 22cbbfa79a26d6be7adb1d00c120c9d9b355a634 on DEV-466 into 74cc2ba02c7ea3a56a7c26ce6d08a55e09a91028 on master.

SonarQube analysis reported 1 issue

 1 minor

Watch the comments in this conversation to review them.

Coverage decreased (-0.3%) to 82.869% when pulling 2d1404bcf63f6e2963ce22f7f9c5629d4db294b8 on DEV-466 into 74cc2ba02c7ea3a56a7c26ce6d08a55e09a91028 on master.


Reverse String Using Recursion

🚀 Feature
Input an string to obtain the reversal string using recursion and it's length in C language.
Have you read the Contributing Guidelines on Pull Requests?
YES
Pitch
Enter a string : STRING
Your string is : STRING
The reversed string is : GNIRTS
The length of the string is : 6

/assign


Forward tablet driver output to custom logging target

One step towards better tablet notifications for osu!, see https://github.com/ppy/osu/issues/20324.
This stops them from being posted as notifications with raw messages (notice entry.Target == null). Instead, it allows the game to treat them differently by checking against entry.LoggerName == ITabletHandler.LOGGER_NAME when subscribed to logger events.
Also improves console log output in general:
[runtime] 2022-09-16 12:39:24 [verbose]: Starting legacy IPC provider...
[runtime] 2022-09-16 12:39:25 [verbose]: Attempting to use custom storage location /Users/salman/osu-lazer-development/
[runtime] 2022-09-16 12:39:25 [verbose]: Storage successfully changed to /Users/salman/osu-lazer-development/.
[tablet] 2022-09-16 12:39:25 [verbose]: Detect: Searching for tablets...
[tablet] 2022-09-16 12:39:25 [debug]: Detect: Searching for tablet '10moon 1060N'
[tablet] 2022-09-16 12:39:25 [debug]: Detect: Searching for tablet 'Acepen AP 1060'
[tablet] 2022-09-16 12:39:25 [debug]: Detect: Searching for tablet 'Artisul A1201'
[tablet] 2022-09-16 12:39:25 [debug]: Detect: Searching for tablet 'Artisul AP604'
...
Console output is being limited. Please check tablet.log for full logs.
[tablet] 2022-09-16 12:39:25 [verbose]: Detect: No tablets were detected.
[runtime] 2022-09-16 12:39:26 [verbose]: SDL error log [debug]: Window data not set
[runtime] 2022-09-16 12:39:26 [verbose]: SDL error log [debug]: Window data not set
[runtime] 2022-09-16 12:39:26 [verbose]: GL Initialized
[runtime] 2022-09-16 12:39:26 [verbose]: GL Version:                 2.1 Metal - 76.3
[runtime] 2022-09-16 12:39:26 [verbose]: GL Renderer:                Apple M1 Pro
[runtime] 2022-09-16 12:39:26 [verbose]: GL Shader Language version: 1.20
[runtime] 2022-09-16 12:39:26 [verbose]: GL Vendor:                  Apple

Not 100% sure about the addition of a new log file though, alternatives would be:

keep all tablet logs as "verbose" regardless of the level (similar to SDL) and prefix them to identify on logger event callback (+ some regex osu!-side to decode level and message from entry.Message, very ugly)
keep all tablet logs as "verbose" but add an event from ITabletHandler to listen to tablet logs (requires cloning classes because of net6.0-netstandard2.1 dual targetting shit)
add a whole other special path in Logger for notifications that "shouldn't be shown to user but remain logged in file and in console"

Need further thoughts on this, one upside about separate file may be allowing to easily attach tablet logs when directing users to report their issues over at OpenTabletDriver's repo (which is a good idea but may need an agreement with the folks there beforehand, so I'm not doing it just yet).

Rather than "tablet", how about making it "input" and using it for other cases of input related logging?

Seems workable, with a prefix on tablet logs to differentiate between them and other input.

Needs conflict resolution now.


Overloaded WebClient's methods to accept query parameters

Motivation:
WebClient's HTTP-specific methods currently only accept a path parameter. As a result, users have to manually concatenate any query parameters to the path.
Modifications:

Overload the get() method to accept both a path as well as a QueryParams params object.
If the QueryParams object is either null or empty, do not concatenate to the path. If not empty, concatenate the original path, a ? and the output of  params.toQueryString().

Result:

Users can now access the API without manually concatenating query parameters to the path
Closes #3915.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Could you also add the same variants to AbstractHttpRequestBuilder?

Please forget about this comment because we have queryParam setters. 😄

Thanks! Left some minor nits. 😄

Please bear with me if there are any more. 😄
Also, quite a few changes have gone in since the last build. Could you please approve a build run? I'd like to verify that we're good coverage-wise.

Thanks and Congratulations on your first PR, @nvidyala! 🎉 🎉 🎉


add multiple file in one zip?

how to add multiple file in one zip?

Currently the unit does not support compression files to zip functionality it's only for ZIP file decompressing, We will add the file compression feature in the next release based on external plugins built in rust for better performance

great, please add both single file to zip and most important multiple files to zip.
if possible then add aes encryption and decryption For zip file.

@kingrupam you can use nzip


Revert SceneQueryType rewrite

Overview
Rewriting this overwritten auto-property with another auto-property seems to have introduced a serialization issue. This reverts that change.
Changes

Fixes: #7642

/azp run


RFE: Always return 'payload.Result' as an array.

Currently
if Tasks = DetectSingleFace then Payload.Result returns an object
but if Tasks = DetectAllFaces then Payload.Result returns an array
Always returning the result as an array would make it easier for following nodes to deal with the results
(I just spent an hour trying to figure out why my debug displaying payload.Result[0].match._label was coming up with unknown when Tasks = DetectSingleFace)

I am going to stick to the format produced by the face-api because it a dependency if somthing changes in it it may break code I make to change the behaviour you seek.
However you bring up a good point. That should be in the documentation.
I never thought about adding that to the documentation as I created a way to handle it in the advance flow example. with my function node.
//global vars
var the_rects;

//was detectAllFaces or detectSingleFace used
//check to see if payload.Result is an array (detectAllFaces)
var Result = msg.payload.Result;
if ( Array.isArray(Result) ) {
    // get just the rect values and place in array
    the_rects = Result.map(x => {
        //check for label from FaceRecognition
        var match_label;
        if ( x.match ) {
            match_label = x.match._label;
        }
        else {
            match_label = "";
        }
        var result = {
            type: "rect",
            x: x.detection._box._x,
            y: x.detection._box._y,
            w: x.detection._box._width,
            h: x.detection._box._height,
            label: match_label
        }
        return result;
    });
    msg.annotations = the_rects;
}
//else detectSingleFace was used
else {
    //check for label from FaceRecognition
        var match_label;
        if ( Result.match ) {
            match_label = Result.match._label;
        }
        else {
            match_label = "";
        }
    the_rects = [{
        type: "rect",
        x: Result.detection._box._x,
        y: Result.detection._box._y,
        w: Result.detection._box._width,
        h: Result.detection._box._height,
        label: match_label.match._label
    }]
    msg.annotations = the_rects;
}

msg.payload = msg.payload.OriginalBufferedImg;

return msg;

Added to documentation. Pushed to github,  Will push update to npm / node-red  when I have more corrections.

You can also use a switch node.


Option to change the order domains are displayed

Hello! Thank you for your awesome work, this is exactly what i was looking for.
As I intend to use this with multiple domains, it would be nice to change in what order domains are displayed. Currently they are displayed in alphabetical order, so an option to reverse that order or sort by most Views would be helpful.

It's currently not planned to add a custom sorting for domains. It always adds a lot of complexity to the code.
I might take a look at it in the future when there's a higher interested in the feature!

Okay I understand.
I just went through the code structure of Ackee because I was curious how Ackee works. I noticed that it uses React for the Frontend and Micro as the http server? I'm just getting started with React and have previously only worked with Node JS and a static frontend so the structure seems wierd to me. I always read that when you use React you build it and then just use the static files and a sperate app for the backend. But here it seems that everything is in one app. The routes, the backend logic and the react frontend.
Could you maybe explain the structure of Ackee? Thanks!

Sure :)

The front-end and back-end of Ackee are in one repository. This makes it easy to share code between both because everything is JavaScript anyway.
Most of the front-end code is located in src/ui. All those files are uncompiled. There's no compiled file in the repository.
When you visit /index.js or /index.css Ackee will run the compiler and return the final files for the page. This happens here: https://github.com/electerious/Ackee/blob/master/src/routes/ui.js
Ackee will build and cache the front-end JS and CSS when you start the server. In the development mode however (When you start the server with yarn dev) the files won't be cached and it will compile everything each time you request /index.js or /index.css. This makes development easier.
Some functions (src/utils) are used both on the back-end and front-end.

I hope that helps. Let me know if you have more questions :)

Thanks! Now I understand it a bit better. But still way to advanced for me. Guess I need to learn more about basic react and stuff :D


When pasting the hackmd, URLs don't become HTML links

This is about putting the session notes into the posts.

Is this still and issue? And if yes, can you point me to an example where something is badly rendered?

Ah, now I understand - it's the <link> vs. link issue?

I have searched a bit and did not find a way to fix this automatically.


dump() performance degradation in v2

(This should maybe go into #202?)
Testing a switch from v1.1 -> v2.0 I found fairly significant performance degradation in dump() with a large set of doubles.  Here's a sample implementation:
json data;
std::vector< double > vec(5e5);
srand(1);
for( int i = 0; i< 5e5; i++ ){ vec[i] = rand();}
data = vec;
std::string str = data.dump();

compiled with vs2015 on windows.  Using v1.1 the dump call takes ~550ms.  With 2.0 it takes ~25000ms (50x).  I haven't tested on any other platforms (although I can do that if it's helpful).
Granted this is an edge case, but it's a pretty dramatic change.

The only difference in the dump() function seems to be the handling of locales:
1.1.0:
case value_t::number_float:
{
    // If the number is an integer then output as a fixed with with
    // precision 1 to output "0.0", "1.0" etc as expected for some
    // round trip tests otherwise  15 digits of precision allows
    // round-trip IEEE 754 string->double->string; to be safe, we
    // read this value from
    // std::numeric_limits<number_float_t>::digits10
    if (std::fmod(m_value.number_float, 1) == 0)
    {
        o << std::fixed << std::setprecision(1);
    }
    else
    {
        // std::defaultfloat not supported in gcc version < 5
        o.unsetf(std::ios_base::floatfield);
        o << std::setprecision(std::numeric_limits<double>::digits10);
    }
    o << m_value.number_float;
    return;
}

2.0.0:
case value_t::number_float:
{
    if (m_value.number_float == 0)
    {
        // special case for zero to get "0.0"/"-0.0"
        o << (std::signbit(m_value.number_float) ? "-0.0" : "0.0");
    }
    else
    {
        // Otherwise 6, 15 or 16 digits of precision allows
        // round-trip IEEE 754 string->float->string,
        // string->double->string or string->long
        // double->string; to be safe, we read this value from
        // std::numeric_limits<number_float_t>::digits10
        std::stringstream ss;
        ss.imbue(std::locale(std::locale(), new DecimalSeparator));  // fix locale problems
        ss << std::setprecision(std::numeric_limits<double>::digits10)
           << m_value.number_float;
        o << ss.str();
    }
    return;
}

Since there's a memory allocation and deallocation around every number_float conversion, that could explain it.
Should the imbue instead just be done once on the stringstream at the top level dump call, and then just do o << m_value.number_float; as before?

Definitely!

@duncanwerner Could you please check again with branch https://github.com/nlohmann/json/tree/feature/issue272? There, I moved the locale handling outside the core of the dump function so that the locale is only adjusted once per call.

@nlohmann Looks like operator<< should save the locale returned by imbue and restore it after the dump call.

Looks great.  In perf testing, roughly
      1.1    2.0      branch
mean  564.4  24298.0  584.5

also works in my "real" application, but harder to benchmark.  Thanks!

@gregmarr Totally forgot about that. I fixed it and added a unit test.
@duncanwerner Thanks for checking!

Thanks a lot. I shall make a release soon.

We're not quite back at the performance of V1.0.0 yet.
One more minor change:
420659f@nlohmannaddressing #272
nlohmann authored on Jun 28
2234	        // fix locale problems
2235	        ss.imbue(std::locale(std::locale(), new DecimalSeparator));
9dbb440@nlohmannimproved performance for dump()
nlohmann authored on Jun 3, 2015
2236	```

@nlohmann PTAL

Thanks a lot, we'll give this a shot.


Mention sequence from serial type docs

This change is taken from
https://github.com/cockroachdb/docs/pull/3172
by dchenk.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/44e212b01b8b50bdfe42385ec360036fc2c62592/

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/258c4dce94b5b259157661ded9480e172c846fbe/


Prevent the logger from throwing a DisallowedHost error

This PR includes 2 changes, one in each commit:

Switch from syslog.severity to level so that DD automatically pics up the log level
I found that my app was trying to log a DisallowedHost error when the logger would raise another one. This change prevents the logger from throwing a DisallowedHost error.

@lnagel I'm not sure what the contribution policy is for this repo but based on the history it seems like you might be the person with the keys. If not, would you mind helping me find the right person to see about getting this merged?

The contribution policy is that contributions are welcome.

The switch away from syslog.severity seems unusual for me. What problem are you trying to solve? We are following the guidelines set here: https://docs.datadoghq.com/logs/log_configuration/attributes_naming_convention/#syslog-and-log-shippers

The DisallowedHost issue I can understand, this should be merged. However you can work around temporarly by restricting the allowed hostnames in your proxy config (e.g. in nginx)

@lnagel thank you!

 It took me a while to respond to your feedback because I had to learn a bit more about datadog to understand what was going on. Long story short, I'm using Heroku and at some point an integration added a logging pipeline with a number of very helpful steps, but it also includes a "status remapper that uses level, not syslog.severity. Now that I better understand how this all works I've fixed this in our account and removed that commit.
Since we're using Heroku we have a pretty limited DNS surface area so it's pretty safe, but there are a few ways to trigger it and I happened to hit them while testing.

I think this is ready for a re-review

Released in v0.5.2


Exception Thrown when trying to use NLP Simple CoreNLP

1.6.0 Simple reference here: http://stanfordnlp.github.io/CoreNLP/simple.html#simple-corenlp

Exception java.lang.NoClassDefFoundError "com.google.protobuf.GeneratedMessage$ExtendableMessage"

Exception Thrown at: Document doc = new Document(inText)
using edu.stanford.nlp.simple;
public List<string> SentenceDetect(string inText)
{
    Document doc = new Document(inText);
    var sents = doc.sentences();
    var l = ((Sentence)sents.get(0)).lemmas();
    return new List<string>(sentenceParser.SentenceDetect(inText));
}

I've the same issue.

I've just solved this issue via adding the following dependency to pom.xml
<!-- https://mvnrepository.com/artifact/com.google.protobuf/protobuf-java -->
<dependency>
    <groupId>com.google.protobuf</groupId>
    <artifactId>protobuf-java</artifactId>
    <version>3.0.2</version>
</dependency>

Wow... CoreNLP uses pom.xml to load dependencies ... Very strange!
Are you sure that you use .NET version of CoreNLP ?)
In which directory you created pom.xml file? (I do not ship it with NuGet package)

FYI- supposedly will be fixed in CoreNLP 3.7.0
https://github.com/stanfordnlp/CoreNLP/issues/171#issuecomment-254599194

@sartan you may verify it https://www.nuget.org/packages/Stanford.NLP.CoreNLP/3.7.0-beta

I have tried the StanfordCoreNLP 3.7.0 but I am still facing this problem. I have tried adding protobuf-java-3.0.2.jar to the classpath but still there is an error when trying to load coreNLP server.
Also tried 3.6.0 with the protobuf-java-3.0.2.jar in the classpath, I was facing the same problem there as well.
Is this fixed in the latest jar available for download. Or should I compile from the latest sources?
Any suggestions?

This repo is for Stanford.NLP.NET and version 3.7.0 is not available of NuGet yet.

.NET samples for Simple CoreNLP published here
https://sergey-tihon.github.io/Stanford.NLP.NET/samples/CoreNLP.Simple.html


Updated docs for pullback.

Beefing up the docs for pullback.

I updated the doc style match what is in the repo, so gonna merge.


Allow renaming Cognito user pool attribute names

Allow renaming Cognito user pool attribute names before putting into a principal

Thanks very much. Appreciate your effort and patience with me :)


Vercel deployment failing with warning "@solana/wallet-adapter-wallets > @solana/wallet-adapter-torus ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>

warning "@solana/wallet-adapter-wallets > @solana/wallet-adapter-torus ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "@solana/wallet-adapter-wallets > @solana/wallet-adapter-torus ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "@solana/wallet-adapter-wallets > @solana/wallet-adapter-torus > @toruslabs/openlogin ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "@solana/wallet-adapter-wallets > @solana/wallet-adapter-torus > @toruslabs/openlogin ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning "@solana/wallet-adapter-wallets > @solana/wallet-adapter-torus > @toruslabs/openlogin ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>warning " ><EMAIL_ADDRESS>has unmet peer dependency "react-is@>= 16.8.0".

Also happens to me, and the connect button doesn’t appear

I was missing the environment variables, added them directly on the hosting site. The .env file is ignored by the .gitignore file.


Enhancement Request - Date Indication in Messaging Section #1314

Issue Id: #1314
Screenshots:

Glad to work with Dummygram :)
@narayan954 Pls review my PR. Let me know for further corrections and changes.

Hi @Swetha-Baskaran this looks really great, will be reviewing asap, meanwhile can you please fix those minor issues mentioned by solarcloud analysis?
Thanks

I've fixed that minor issue, can you please enable "Allow edits by maintainers" so I can update :)

I've fixed that minor issue, can you please enable "Allow edits by maintainers" so I can update :)

Also, now we are automatically scrolled to the top of the windows, instead of being scrolled to the bottom. I'm looking into it, can you assist please?

I've fixed that minor issue, can you please enable "Allow edits by maintainers" so I can update :)

done

I've fixed that minor issue, can you please enable "Allow edits by maintainers" so I can update :)

Also, now we are automatically scrolled to the top of the windows, instead of being scrolled to the bottom. I'm looking into it, can you assist please?

sure I'll try raise other pr for that issue

I've fixed that minor issue, can you please enable "Allow edits by maintainers" so I can update :)

Also, now we are automatically scrolled to the top of the windows, instead of being scrolled to the bottom. I'm looking into it, can you assist please?

sure I'll try raise other pr for that issue

It's related to how we handle scrollTop function. It's conflicting while loading more messages. We can solve this later. I'm merging this now :)

Thanks for your contribution! This looks really good, I couldn't even think of this :)


Exec/auth provider command path inconsistent with go/js

The command path in exec type authentication methods are currently handled by k8s client by just throwing whatever is in the command field into Kernel backtick method. This makes things like cat /tmp/foo.txt or echo foo or kubectl -n kube-system get secret xyz | jq .. work.
It may be handy, as you can for example just have something like aws-cli installed in PATH, but it's not correct as documented in KUBECONFIG docs or as done by the go and JS k8s client libraries.
Any relative file references are supposed to be searched for under the directory of the kubeconfig file that defined the reference.
client-go uses filepath.isAbs(), the javascript lib uses path.isAbsolute(). k8s-client should probably use the Pathname#relative? to build the final path.
This applies to all other filepaths in kubeconfig also. For example when merging kubeconfigs, the origin of each entry must be tracked so the reference can be resolved later.

Actually it does not resolve exec command paths the same way:
https://github.com/kubernetes/client-go/blob/611184f7c43ae2d520727f01d49620c7ed33412d/tools/clientcmd/loader.go#L579
But the issue is still relevant for the relative certificate paths etc. The load location must be tracked.


Publish 09/30/21, 3:30 PM

Docs Build status updates of commit 2d7dd27:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2022-ps/iscsitarget/Export-IscsiTargetServerConfiguration.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/iscsitarget/Import-IscsiTargetServerConfiguration.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/netqos/Get-NetQosPolicy.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/netqos/New-NetQosPolicy.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/netqos/Remove-NetQosPolicy.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/netqos/Set-NetQosPolicy.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 06fed5f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docset/winserver2022-ps/iscsitarget/Export-IscsiTargetServerConfiguration.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/iscsitarget/Import-IscsiTargetServerConfiguration.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/netqos/Get-NetQosPolicy.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/netqos/New-NetQosPolicy.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/netqos/Remove-NetQosPolicy.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/netqos/Set-NetQosPolicy.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/networkswitchmanager/Disable-NetworkSwitchEthernetPort.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/networkswitchmanager/Disable-NetworkSwitchFeature.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/networkswitchmanager/Disable-NetworkSwitchVlan.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/networkswitchmanager/Enable-NetworkSwitchEthernetPort.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/networkswitchmanager/Enable-NetworkSwitchFeature.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/networkswitchmanager/Enable-NetworkSwitchVlan.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/networkswitchmanager/Get-NetworkSwitchEthernetPort.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/networkswitchmanager/Get-NetworkSwitchFeature.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/networkswitchmanager/Get-NetworkSwitchGlobalData.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/networkswitchmanager/Get-NetworkSwitchVlan.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/networkswitchmanager/New-NetworkSwitchVlan.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/networkswitchmanager/Remove-NetworkSwitchEthernetPortIPAddress.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/networkswitchmanager/Remove-NetworkSwitchVlan.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/networkswitchmanager/Restore-NetworkSwitchConfiguration.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/networkswitchmanager/Save-NetworkSwitchConfiguration.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/networkswitchmanager/Set-NetworkSwitchEthernetPortIPAddress.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/networkswitchmanager/Set-NetworkSwitchPortMode.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/networkswitchmanager/Set-NetworkSwitchPortProperty.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

docset/winserver2022-ps/networkswitchmanager/Set-NetworkSwitchVlanProperty.md
:white_check_mark:Succeeded
View (WindowsServer2022-ps)

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


RFC: Cartesian product function

Checklist

Please ensure the following tasks are completed before submitting a feature request.

[x] Read and understood the Code of Conduct.
[x] Searched for existing issues and pull requests.
[x] The issue name begins with RFC:.

Description

Description of the feature request.

The Cartesian product (cross-product) is essentially an operation which returns a product set from multiple supplied sets.
https://en.wikipedia.org/wiki/Cartesian_product
Related Issues

Does this feature request have any related issues?

Not that I can see.
Questions

Any questions for reviewers?

No.
Other

Any other information relevant to this feature request? This may include screenshots, references, sample output, and/or implementation notes.

No.

This function has been added, along with other Cartesian product variations.


feat: pupil expiring banners

Job Story
When I navigate to a lesson or lesson listing which is due to be expired
I want to see the new lesson takedown banner
So that users can plan appropriately.
Implementation details
The banner appears in response to the action “display_expiring_banner”
The current expiring banner appears here:
https://www.thenational.academy/pupils/programmes/maths-secondary-year-10-core-l/units/trigonometry-1-0125/lessons/applying-trigonometry-6mup2c/overview
Design docs:
https://www.figma.com/design/dGO9erL0b0kpYxmv6Jku4f/Lessons-takedown-banners?node-id=2011-7642&m=dev
How to test

Go to https://deploy-preview-3047--oak-web-application.netlify.thenational.academy/pupils/programmes/maths-secondary-year-10-core-l/units/trigonometry-1-0125/lessons/applying-trigonometry-6mup2c/overview
you should see the expiring banner
click the button. It should take you to the programme options page

Further testing:
Unfortunately we do not currently have any other expired legacy content for testing in production.
Acceptance criteria

[x]  banner matches design
[x]  link goes to appropriate place
[x]  pupil lesson page
[x]  pupil lesson canonical page
[x]  pupil lesson listing
[x]  pa11y and percy

@kimon-satan functionally works fine, just looking at the design - should it be 'This lesson...' rather than 'These lessons..' on the lesson overview page? Then 'These' for the lesson listing page

:tada: This PR is included in version 1.645.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Scrolling is slower on Wayland

With Alacritty on Wayland, mouse scrolling is much slower than on xorg.
How to replicate:

Run a Wayland window manager
Open a regular Alacritty terminal (Wayland)
Open another terminal with the xorg version of Alacritty: env WAYLAND_DISPLAY= alacritty
Put them side by side and cat any big file in both
Scroll up and down in each of them and see that the version running native on Wayland is MUCH slower.

I'm using Arch Linux and have confirmed the bug on both Sway 1.0 and Gnome. Both running Wayland.

Can you replicate this with the vtebench benchmarks?
Printing file content can be extremely inconsistent because of file caching, so that might cause some variations.

I don't know how to replicate it with vtebench. I tried running the example in that repo and the results are similar on both xorg and wayland. This example:
vtebench -w $(tput cols) -h $(tput lines) alt-screen-random-write \
    > /tmp/100mb.vte

time cat /tmp/100mb.vte

I think it's just the mouse scrolling that is slower. It's the same for any content, so running your package manager or anything and then scrolling up is slower on wayland. Using cat on a big file is just to fill the buffer.

I was not aware you're talking about mouse scrolling. Mouse scrolling in XWayland and Wayland is handled differently, since one relies on X, while the other relies on Wayland. So a difference in scrolling speed is definitely possible.
If you want to achieve the same scrolling speed on both systems, you'd probably have to resolve that in the Wayland or X.Org configuration.
If the goal is to just increase/decrease the scrolling speed, you can make use of the scrolling.multiplier setting.

I'm experiencing the same issue. If I disable scrolling the problem is gone.
See below.
Which operating system does the issue occur on?
Linux
If on linux, are you using X11 or Wayland?
Wayland, sway 1.0
How to reproduce:
while True; do echo A; done

run the above inside alacritty until you fill the history scrolling limit.
After the above, resizing, maximizing is much slower than in a fresh session (or a session with history=0). The lag is noticeable with a relatively fast machine.
Under normal circumstances, resizing the screen from half-screen to full screen from keyboard keys is very fast (only requires 25% of my CPU when swapping fullscreen/half screen as fast as I can). If scrolling is active and the buffer is full, this goes to 100% and resizing/fullscreen is much slower ( I have to wait maybe two seconds until the text is redrawn).

I cannot reproduce this using Sway 1.1.1 and Alacritty 0.3.3


PR Title for PR-1235

This is a pull request for PR-1235.

Generating PR code suggestions
Work in progress ...

Generating PR code suggestions
Work in progress ...

Preparing review...

PR Reviewer Guide 🔍

⏱ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🏅 Score: 85
🧪 No relevant tests
🔒 No security concerns identified
🔀 Multiple PR themes

Sub-PR theme: Simplify PRConfig Initialization

Relevant files:

pr_agent/agent/pr_agent.py

Sub-PR theme: Update Configuration Loading Logic

Relevant files:

pr_agent/config_loader.py

⚡ Key issues to review
Code SmellThe PRConfig class initialization does not use the ai_handler parameter. Consider removing it to avoid unnecessary complexity.

Generation Model with RAG True
qwen2.5-1.5b-ins-bf16

Preparing review...

PR Reviewer Guide 🔍

⏱ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🏅 Score: 95
🧪 No relevant tests
🔒 No security concerns identified
🔀 No multiple PR themes

⚡ Key issues to review
Code CleanupThe PR removes two unnecessary imports. This improves the readability and maintainability of the code.

Generation Model with RAG False
qwen2.5-1.5b-ins-bf16

Generating PR code suggestions
Work in progress ...


Add type definitions

As mentioned in the title, there should be an index.d.ts file, and it's path should be included in the types property inside package.json.

Hello @MSE99 , feel free to send a PR for that. Thank you!

Hey, how's it going with this? I see an open PR but not merged


Send stacktrace with events, not just exceptions

I noticed that if I set a stacktrace on an event, it is not sent to Sentry.  This patch should resolve the issue.

I pushed a commit to the master branch to solve the broken CI, can you please rebase and try again if it works?

We've found (on an old version of the SDK - ^1.10) that for fatal errors/OOMs, sentry only gets the error but not the stack trace. Does this PR fix that? (Has it already been fixed since ^1.10?)

This is on a completely different version (3.0), the issue is completely unrelated.


[Maintenance] Remove wrong return types

These ids were integers for years already
https://github.com/Sylius/InvoicingPlugin/blob/93a4fa83b89b0a10ce6fde34807e0a9074524892/src/Resources/config/doctrine/InvoiceShopBillingData.orm.xml#L10-L12
https://github.com/Sylius/InvoicingPlugin/blob/93a4fa83b89b0a10ce6fde34807e0a9074524892/src/Resources/config/doctrine/LineItem.orm.xml#L5-L7
https://github.com/Sylius/InvoicingPlugin/blob/93a4fa83b89b0a10ce6fde34807e0a9074524892/src/Resources/config/doctrine/TaxItem.orm.xml#L5-L7

Thanks, Łukasz! :1st_place_medal:


Add RapidMiner Studio v6.3.0

RapidMiner is a software platform that provides several techniques for machine learning, data mining, business analytics etc.

Walled build. Please submit it to caskroom/unofficial instead.

@vitorgalvao Done! Thanks!


⚠ DesiTorrents has degraded performance

In 6e760a8, DesiTorrents ($DST) experienced degraded performance:

HTTP code: 200
Response time: 1477 ms

Resolved: DesiTorrents performance has improved in 6fb718c.


Dropdown Settings for Component Examples Searchable but Not Selectable via Keyboard

Describe the bug
The Dropdown settings for component examples are searchable, but the search results cannot be selected using the keyboard.
Experienced Behavior

The search result is found and displayed.
The search result is not selectable using the keyboard.

Expected Behavior

The search result should be findable.
The search result should be selectable using the keyboard. (e.g. pressing Enter or Tab)

Steps to Reproduce

Navigate to a component example page with Dropdown settings.
Click into a search setting.
Search for any entry using the keyboard.

Screenshots/Videos

Operating System
Windows, MacOS
What browsers are you seeing the problem on?
Chrome, Safari, Edge
Browser version
No response
What device are you using?
Desktop, Mobile
Additional context
No response

Funny, I have the exact opposite issue. I can select, but not filter :smile:

fixed


HACKING.md would be nice

I suppose to add a new file HACKING.md with notes how to setup a dev environment, that also specifies how to compile, lint, package and debug the debug extension; starting from "only vscode installed". Minor notes alone and links would be enough.
As the README.md is the main part of the "user view" I'd not add the information there, but in a new file.
@brownts As you had the most recent experience: Would you mind doing that?

@GitMensch a little unrelated to this issue, but I have added a github actions action: you can now tag releases to make them release on vscode marketplace, openvsx and on the releases tab.
Make sure you bump the version of the package in package.json before releasing!

Sure, I could take a pass at this.
I did notice that the Travis CI was no longer working for running the unit tests.  I was wondering if maybe that was something that would now be setup to run on Github Actions as well.  That along with a linting would be good to run against pull requests or even the main branch.
I'd be curious if there are any plans to expand the testing.  I know it is time consuming and error prone to attempt to adhoc test many different permutations of launch/attach/gdb/lldb, etc., let alone different versions of these toolchains.  I'd love if there were something more automated for this, but haven't really looked to see what might exist for this.  Maybe you have some ideas here.

you can spawn and control vscode instances from unittests if you want to simulate a full vscode UI.
But debug extensions implement the debug adapter protocol, so you could just simulate a debug app running this extension and validate which commands are sent/received. There are probably already libraries and applications for this out there on the internet.

I did notice that the Travis CI was no longer working for running the unit tests. I was wondering if maybe that was something that would now be setup to run on Github Actions as well. That along with a linting would be good to run against pull requests or even the main branch.

Actually it would already be nice to have an action that would only do the linting part, adding tests would of course be much better - but the first may be much easier to add now and would at least make sure that the code compiles and passes linting.
@brownts to make that usable current linting issues should be fixed, that may be something you could help with.

I have added a github actions action: you can now tag releases to make them release on vscode marketplace, openvsx and on the releases tab

@WebFreak001 Thanks, will likely do relative soon (also after updating the ChangeLog), possibly next week, and will update that and package.json for "unreleased" afterwards.
As this extension currently doesn't follow semver rules (as far as I see each update normally increments the second number and we does not start at 1.0.0): Are you fine with one of

".0" being dev versions and published releases starting from ".1"?
-0dev0 pre-release identifier (which would also allow incrementing that last part, either with each commit or from time to time)?

or should we just leave at ".0" if no patched version, the tag matches the actual release the previous versions in git have the same number but aren't actually identical?

we do follow semver, a version starting with major version 0 means breaking changes may be introduced with the minor version
Bump the minor version every time, no matter if there are breaking changes until we reach 1.0.0
In 1.0.0 we declare full stability and no longer break stuff with updates

Sounds good. So what about a pre-release identifier for "not released" versions?

yeah you can suffix them with whatever you want, I usually go with -beta.1, etc.
But the marketplaces don't support that, they will just publish the extension to them anyway - so I don't think there is much value in doing it for extensions.

The file should also contain a note about using fixed and older versions of vscode and dap for backward compatibility (for now, I'd say "roughly a year", which is what #315 updates, too).

I started working on this today.  I decided to start from a scratch VSCode/Ubuntu install.  At least that is what I'm currently using, so figured that would be best to start with.  Anyway, I noticed that when I tried to perform an npm install in the freshly cloned repository that I was getting a compilation error.  Looking at this a bit more, it seemed that because the package-lock.json was out-of-date with the package.json (i.e., ssh2 had recently been upgraded to 1.6.0 in package.json in ac16c92b7c401e396fd856f7aa7b0fd52f5a4ed6, but not in package-lock.json), that npm installed version 1.7.0 and for some reason this causes a compilation failure on my system.
...

><EMAIL_ADDRESS>install /config/git/junk/code-debug/node_modules/ssh2
> node install.js

make: Entering directory '/config/git/junk/code-debug/node_modules/ssh2/lib/protocol/crypto/build'
  CXX(target) Release/obj.target/sshcrypto/src/binding.o
../src/binding.cc: In member function 'void ChaChaPolyCipher::clear()':
../src/binding.cc:83:7: error: 'EVP_CIPHER_CTX_cleanup' was not declared in this scope; did you mean 'EVP_CIPHER_CTX_set_num'?
   83 |       EVP_CIPHER_CTX_cleanup(ctx_pktlen_);
      |       ^~~~~~~~~~~~~~~~~~~~~~
      |       EVP_CIPHER_CTX_set_num

...

I started over and forced ssh2 to 1.6.0 (to also force updating of the package-lock.json file with<EMAIL_ADDRESS>instead of<EMAIL_ADDRESS>and this worked around the problem:
npm install<EMAIL_ADDRESS>
I'm not exactly sure what the correct way is to update the lock file, but I know that the current discrepancy between the package.json and package-lock.json seems to force this update to a never version (i.e., 1.7.0) which then fails to build...at least for me.
Also, when I indirectly update package-lock.json via npm install, it appears to downgrade the lockfileVersion from 2 down to 1.  After some investigation, it appears that npm v7 is when this version changed.  With just the basic sudo apt install npm on Ubuntu 20.04, it installs 6.14.16.  Is there a minimum version of these tools that we should be targeting?
I noticed that the build action targets Node.js 14.x, which is in alignment with the Ubuntu 20.04 standard installation version of Node.js.  It just seems that when the package-lock.json was last generated, that it may have been generated with a 7.x version of npm rather than a 6.x version.

As I have no clue about npm or node.js in general (just typescripting a bit...) I've normally did npm update and found the old node.js 12 (or npm 6.14) not working with vscode last month so I've updated to node 16.14 / npm 8.5.2 and now compile, package and other things seem to work (all but debugging, not sure if that worked before).
I think that an older format of package-lock should work with newer npm, too, but not necessarily the other way around - Please PR a working package-lock.json and I'll merge it.
For the ssh2 error - please create an issue at https://github.com/mscdex/ssh2/issues/to get that fixed, so we can use newer versions also on older systems.

Note... not necessary to create an issue, it is already there at https://github.com/mscdex/ssh2/issues/1147, and is also already solved by https://github.com/mscdex/ssh2/commit/5af3bc6dd2011fb14da22a0316d8dca0ea12fd1b - the only thing missing is an updated npm release...

Thanks for doing the legwork in investigating the issue with the ssh2 package.  I've not used npm, node.js or even typescript before a few months ago, so all of this is a bit new to me as well.  I'm stumbling my way through it though.  :stuck_out_tongue_winking_eye:
I created #333 to synchronize the two files.
I believe we can run npm clean-install and it will error out if the two are not in sync.  That might be a good job to have setup to check potential PRs and commits to make sure the two files stay synchronized going forward.

For now that seems like a good thing to mention in HACKING.md, for later this can be added to a check workflow which is run in PRs and in each commit.

I setup a Windows development environment today to test out Windows functionality of this extension.  I ran into an issue and wanted to know if anyone else running under Windows has run into the same problem.  When I tried to launch the extension under the debugger (it first tries to compile, due to the preLaunchTask in launch.json).  However, this was having trouble running npm on my Windows system.
> Executing task: C:\Program Files\nodejs\npm run compile --loglevel silent <

The terminal process failed to launch: A native exception occurred during launch (Cannot create process, error code: 193).

After some investigation, I discovered this was due to the fact that there are two different scripts (one for POSIX systems ...npm, and one for Windows...npm.cmd):
c:\>where npm
C:\Program Files\nodejs\npm
C:\Program Files\nodejs\npm.cmd

c:\>

I also discovered that the default setting in the current task.json is to run the npm command as a process rather than through the shell.  If I change the task type to shell, then everything works fine (the npm.cmd is properly resolved by the shell).
Thus, it appears the following should be added to tasks.json so this works on both POSIX and Windows systems.
"type": "shell"

I can create a pull request for this, but was curious if anyone else had run into this as well.

Yes, please create a PR, I've stumbled on this before and adjusted the process to be npm.cmd - the shell solution looks much better.

As I had that running today and wanted to document the "debugging this extension" issue I've started HACKING.md, also gathering all information I found "somewhere".
This new file definitely needs some love, please feel free to improve it.

I've made some significant updates to this file in https://github.com/WebFreak001/code-debug/commit/cdb99750df7b919108fe50ba1d9d25882ef61c76 which I believe now satisfies the original intent of this issue.  I'm going to close this issue out as having been addressed.

That's marvelous! Thank you very much, this helps a lot!


test_models: tests are not set up to test cars with multiple pandas in different safety modes

TestCarModelBase only sets up a single panda safety mode to run unit tests against (the last one in the list). In the Tesla port however, there are two pandas that are running different safety configs (a valid use case of a multipanda setup).
While replaying the test route, this makes the tests fail erroneously, since it cannot send a lateral control message on the longitudinal panda (see CI failure in https://github.com/commaai/openpilot/pull/29947).
We never noticed this in the past, since the previous test route from Tesla was only set up with a single panda (lat only).

We don't really plan on shipping any multi-panda setups (red panda aux is a bit different), so let's close unless you plan on implementing this.

There's two ways around this:

I can fix up the tests to properly support this. Would probably look quite a bit less clean since you'll likely have to loop over all pandas in all the spots where you do any safety code calls
I can just get a single panda reference route like for Tesla AP2 without long control

Lmk what you prefer

Let’s do the second option. Any chance the Raven EPS is different and will support blending?

Let’s do the second option.

Ok will switch to a single panda route.

Any chance the Raven EPS is different and will support blending?

No, seems like their logic is pretty much identical to my old car (except for the two redundant units now)