838 move datasetmetahistory into datasethistory

Checklist before merging

[x] I added an appropriate entry to CHANGELOG.md

close #827
close #838
close #826

Something more: can we now fully remove history from the ApplyWorkflowRead model?
Higher-level: I am not a fan of adding custom attributes to the Read models that do not correspond to a db-table column. If special information are needed, we can always use class properties or methods, or we can create an additional Pydantic model that inherits e.g. from ApplyWorkflowRead and which is used in a specific endpoint. The Read models should be used in all the CRUD endpoints, and they should be as close as possible the the db contents.

With 4bee986, I'm adding input validation to dummy tasks that we use for tests.
This is to be closer to the way fractal-tasks-core work, but also to catch errors like the one fixed with 4c9c911, which currently went undetected and only appeared as part of a fractal-client CI (https://github.com/fractal-analytics-platform/fractal-client/actions/runs/6496628972/job/17643989673), in this form:
        'log': (
            'TASK ERROR:Task id: 1 (dummy), e.workflow_task_order=0\n'
            'TRACEBACK:\n'
            'Traceback (most recent call last):\n'
            '  File "/tmp/pytest-of-runner/pytest-0/test_workflow_apply0/FRACTAL_TASKS_DIR/.fractal/fractal_tasks_core'
            '_alpha0.0.1a0/venv/lib/python3.11/site-packages/fractal_tasks_core_alpha/tasks/dummy.py", line 149, in <m'
            'odule>\n'
            '    metadata_update = dummy(**pars)\n'
            '                      ^^^^^^^^^^^^^\n'
            "TypeError: dummy() got an unexpected keyword argument 'history'\n"
        ),

With ee88dba, I tried to use _DatasetHistoryItem in the runner, but I found some issues because I would need actual WorkflowTaskRead objects in there (with all their primary/foreign keys), and in the tests we use Mock objects. For the moment I reverted the commit.

With ee88dba, I tried to use _DatasetHistoryItem in the runner, but I found some issues because I would need actual WorkflowTaskRead objects in there (with all their primary/foreign keys), and in the tests we use Mock objects. For the moment I reverted the commit.

I'm still trying to evaluate whether we are using _DatasetHistoryItem correctly.

We have it in the init file of the local/slurm runners, but it's only a type hint.
We have it in the dataset schemas, but it's not very useful for DatasetCreate and DatasetUpdate.
It is indeed relevant for the DatasetRead model, but this is a very small scope.

I think we should use it a bit more, and especially when constructing the history.

I'm still trying to evaluate whether we are using _DatasetHistoryItem correctly.

After discussing with @mfranzon, we opted for removing this class from the runner, where it was currently only used as a slightly wrong type hint. See https://github.com/fractal-analytics-platform/fractal-server/pull/898/commits/3135fec78acd256b9381b4efa3a16f209563d661

@mfranzon should we really include DatasetUpdate.history? I cannot see an obvious use case.
We can also decide to include it, to have a more consistent API, and then add a check somewhere (either in a model validator or within the PATCH endpoint) so that it is not actually allowed.

We agreed that consistency is important, and we'll keep that attribute. We'll raise a 422 from the endpoint if a user tries to modify it.

The last thing I want to check is the behavior for when we start from a dataset with a non-empty history (e.g. because we are continuing a workflow execution). Maybe this is already part of a test, or I will add one.
Other than that, I think this is ready!


Techdebt/this locations

There is a minor tech debt added,
helper is-concat.  I dont know why, but the helpers have to be prepended with is- on this version of ember.  When we go to 1.13 this will be removed.

long term i think we'll need to translate [this level] for each level, but this is awesome. Looks great except for the Col stuff in es-mex, and "este entidad" should be "esta entidad"


installs files into my project, not as library

Very useful addition to the rspec tool suite, thanks!
I'm still learning the subtleties of bundler, but when I added:
gem 'json_spec'
to my Gemfile and run bundle, it created a new subdir in my project: json_spec/ruby/1.9.1/ with bin, cache, gems, bundler, doc and specifications subdirs
Usually this is all quietly installed in the library somewhere.
Is this a config issue for json_spec or user error on my part?
thx! michael

Somehow I created a local bundle pointing into my local dir. Removing .bundle/* and its associated misconfiguration fixed this.


Better support for sidecar containers in batch jobs

Sidecar containers do not play well with k8s jobs. The job will keep running so long as the sidecar proxy is running. This is a general problem not specific to Istio (see https://github.com/kubernetes/kubernetes/issues/25908). The typical workaround includes explicit terminate signaling between app and sidecar container such that the sidecar can exit when the app does.

cc @Rigdon

Martin going in vacation.
Targeting to 1.0 - since it seems to just not work for batch jobs as expected.

Quick fix: Add a '/quitquitquit' handler to proxy-agent. Users can manually add a curl or http request to localhost to stop sidecar when the job is done ( or we can add it automatically - but P0 is to have a workaround, we can improve it in 1.1 )

Hello guys. I had the same issue on my k8s cronjob. It seems /quitquitquit handler in pilot-agent is not implemented yet. So I made a PR.
I looked through both envoy and pilot-agent and could notice Agent waits until the next 'config update', if the last epoch terminates normally. I think in case of 'config update' Istio users do not explicitly terminate epochs, since it supports hot-reloading. So the main purpose of the normal termination of the last epoch would be closer to the pilot-agent termination.
With this assumption, the PR does gracefule shutdown of the pilot-agent on the last normal epoch termination. I think it can reduce the chance of being zombie agent in not only /quitquitquit but also other normal envoy terminations.
I hope the PR saves you guys’ time for this issue.

So, here's a working PoC: https://github.com/istio/istio/pull/9307
It uses kubernetes API to watch for pod changes, and finishes pilot-agent when all the pod containers finish.
Caveats:

The job must use a service account with permission to get,list,watch pods in the namespace
Automatic sidecar injection (via MutatingAdmissionWebhook) does not add the the volume mount for the service account (containing mountPath: /var/run/secrets/kubernetes.io/serviceaccount) preventing an in-cluster k8s client to work on the istio-proxy container. It works fine with manual injection though. https://github.com/kubernetes/kubernetes/issues/69733

Comments? Ideas?

There was a strong opposition to linking client-go into sidecar agent due to the size of the library.
I wonder if there is a mechanism to achieve the effect without contacting the api server -- maybe using termination commands on containers.

@GregHanson - many thanks for the tip. Alas the command listed always caused the pod to exit abnormally for me:
    State:          Terminated
      Reason:       Error
      Exit Code:    143

I found changing the pkill signal fixed the issue properly. Note I'm using this in helm test and need the correct exit value from the main container. Here's a simple example:
Before:
Command:
     sh
     -c
     sleep 20;/usr/bin/curl http://dl-cdn.alpinelinux.org --fail; exit_code=$?; echo code is $exit_code; pkill -f /usr/local/bin/pilot-agent; exit $exit_code;
   State:          Terminated
     Reason:       Error
     Exit Code:    143

After:
    Command:
      sh
      -c
      sleep 20;/usr/bin/curl http://dl-cdn.alpinelinux.org --fail; exit_code=$?; echo code is $exit_code; pkill -INT /usr/local/bin/pilot-agent; exit $exit_code;
    State:          Terminated
      Reason:       Completed
      Exit Code:    0

@costinm the quitquitquit doesn't work, see: https://github.com/istio/istio/issues/11659

@TristanPeers worked enough for me as a workaround.
I see in his, he has a sleep in there -- I was noticing things erroring out unless I put in a sleep.  It sounds like some logic is missing in the init_container to properly initialize before letting the main container run wild.

Another work around would be an istioctl quit-terminated-jobs hack to look for jobs and do kubectl exec <pod> -c istio-proxy -- curl -X POST localhost:15000/quitquitquit on them.  That would at least make it easy to script this process.
Could Galley or another component could include a controller to watch for Job pods going into containerStatuses[*].state.terminated.reason=completed and POST a quit message to the sidecar?  Or pollute Pilot's gRPC stream with some kind of poison pill that causes Envoy to suicide?

@cmeyertons Kubernetes won't let the Envoy sidecar pod start until the init container has completed.  Kubernetes starts the job and the sidecar together.  The app won't have networking until Envoy initializes.  We are tracking possible solutions under https://github.com/istio/istio/issues/11130
I add some code to my deployment descriptor to cause it to sleep before Envoy is ready.  (Replace startup.sh below with the original command)
command: ["/bin/bash", "-c"]
args: ["until curl --head localhost:15000 ; do echo Waiting for Sidecar; sleep 3 ; done ; echo Sidecar available; ./startup.sh"]

It seems sidecar container support in k8s is under development here (https://github.com/kubernetes/enhancements/issues/753). I hope it would be merged into the next k8s release and resolve this issue.

Hey, we here at Monzo have open sourced our solution to this sequencing problem:
https://github.com/monzo/envoy-preflight
The idea is, it's a wrapper around your main application, which ensures it starts after envoy is live, and shuts down envoy when its done. You'll still need to prevent sigterms from reaching envoy.
We use this for batch jobs to ensure that all containers actually exit when the work is done.

See https://istio.io/help/ops/setup/injection/

Quick fix: Add a '/quitquitquit' handler to proxy-agent. Users can manually add a curl or http request to localhost to stop sidecar when the job is done

In 1.3 we added a /quitquitquit endpoint to pilot-agent

This looks like a useful example for the general case (for example I have some k8s jobs which will fail to complete once istio sidesar is deployed) https://medium.com/@cotton_ori/how-to-terminate-a-side-car-container-in-kubernetes-job-2468f435ca99

In 1.3 we added a new /quitquitquit endpoint to pilot agent which should resolve this. Its not perfect since it requires some manual action, but I think a longer term solution would depend on https://github.com/kubernetes/kubernetes/issues/65502 or https://github.com/istio/istio/issues/11366 or similar. If there is anything else we can do to improve these in the short term I would be happy to take a look at

The referenced commit here seems to provide a good liveness probe for cronjobs, but not regular jobs or simply on-demand pods run by kubectl run.

I agree that a real fix likes in #k8s, but the perception is that by enabling istio (auto injection), an existing application is broken where it uses jobs. Without that being addressed having the issue closed seems uncomfortable - whilst I recognize it's hard to fix. This is the case even though this isn't istio specific, but a k8s sidecar issue.
At a minimum I would suggest adding some caveat into the docs (especially wrt sidecar injection), and possibly linking the k8s issue (and push that). Ideally outlining any mitigation strategies.
Apologies I've not got around to working through approaches on my project yet.

Here's what I ended up doing as a workaround. Only works with istio >= 1.3. Modify your entrypoint to make a call to the proxy container asking it to shut itself down:
containers:
   command: ["/bin/bash", "-c", "/path/to/your/main/entrypoint && curl -X POST http://localhost:15020/quitquitquit"]

The K8s fix seems not yet prioritized (https://github.com/kubernetes/enhancements/issues/753), so I am reopening this bug to see if we can find more workarounds in the short term.
A Job foo's Pods would have labels job-name: foo.  They also often have restartPolicy: Never.  Can we make the sidecar injection require explicit opt-in for these kinds of Pods?  Then the job doesn't need to explicitly call /quitquitquit.

For Istio 1.6 and kubernetes I changed entrypoint to following:
        command: ["/bin/sh", "-c"]
        args: [
          'until $(curl --output /dev/null --silent --head --fail http://localhost:15021/healthz/ready); do echo . ; sleep 5; done; my_command'
        ]

@pbn4 Doesn't Istio need /quitquitquit?

- command:
  - /bin/sh
  - -c
  - |
    until curl -fsI http://localhost:15021/healthz/ready; do echo \"Waiting for Sidecar...\"; sleep 3; done;
    echo \"Sidecar available. Running the command...\";
    <YOUR_COMMAND>;
    x=$(echo $?); curl -fsI -X POST http://localhost:15020/quitquitquit && exit $x

- command:
  - /bin/sh
  - -c
  - |
    until curl -fsI http://localhost:15021/healthz/ready; do echo \"Waiting for Sidecar...\"; sleep 3; done;
    echo \"Sidecar available. Running the command...\";
    <YOUR_COMMAND>;
    x=$(echo $?); curl -fsI -X POST http://localhost:15020/quitquitquit && exit $x

I'm for a long time using the /quitquiquit technic to end properly my job... but that's true I added a durty "sleep" in the past to wait for the sidecards to be ready (didn't want to add shell loops on all my deployments... moreover when you use Helm charts managing the command is not always possible).
Trying to catch up what's new I found this:
https://github.com/istio/istio/issues/33911#issuecomment-877010732
Do you use now this technic @diseku @pbn4 instead of the loop over /ready?
Thank you,

The provided workaround is not good enough if no shell available in your docker images (consider Distroless images for example). What are other possible options here?
I think this ticket should be reopened, since this is not resolved for all of the cases.

Let's have a little more patience and watch the upcoming sidecar containers solve this problem properly.
https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/753-sidecar-containers
https://github.com/kubernetes/kubernetes/pull/116429

I agree with @imikushin; sidecar contains are coming in 1.29.
In the interim we've written a custom controller that watches Pods, waits for them to be in a terminating state and then kills the sidecars.  It's less than ideal but this is a core kubernetes problem (hence the kep).
Here's the source code for our handler (effectively something that responds to a watch on kubernetes pods): https://gist.github.com/Stono/05d3137c166890bb5587b3f0cc59dc80.  You obviously won't be able to use it verbatim but the logic might help you.

Thanks @Stono for the example - definitively will be valuable not just for me 👍🏻
This is not about patience (the issue is from 2018, so I think we're crossed that check). My point is more like making awareness that the problem is not closed, yet ticket status was confusing. I understand there are limitations coming from k8s, and long term fix only possible with the kubernetes upgrades.

+1, I encounter this problem too.

@ofey404 Istio has supported sidecar container feature, you need to upgrade to  k8s 1.18+, and istio 1.19+

see the blog: https://istio.io/latest/blog/2023/native-sidecars/

you need to upgrade to k8s 1.18+

You probably meant 1.28+, not 1.18.

updated


Gateway Assessment Data Update - PT & FT

As a ministry user I want to ensure the assessment data that is appearing is the data we expect to see. This is important because we want to ensure our NOA displays the correct information.
Acceptance Criteria

[ ] On the NOA make sure we are using the calculated camunda outputs in Assessment Data and not direct info from offerings or other. (Award amounts are ok to come from the DB)

PT

[ ] Replace the books and supplies from offeringProgramRelatedCosts to calculatedDataProgramRelatedCosts
[ ] Update tuitionCost: offeringActualTuitionCosts to calculatedDataActualTuitionCosts

FT

[ ] Update otherAllowableCost: calculatedDataChildCareCost with otherAllowableCost: calculatedDataTotalChildSpousalSupport + calculatedDataTotalSecondResidence
[ ] Update childcareCost: calculatedDataChildCareCost with childcareCost: calculatedDataTotalChildCareCost
[ ] Update totalProvincialContribution: calculatedDataTotalProvincialFSC + calculatedDataTotalSpouseContribution + calculatedDataTotalParentalContribution with totalProvincialContribution: calculatedDataTotalProvincialContribution
[ ] Update totalFederalContribution:  calculatedDataTotalFederalFSC + calculatedDataTotalSpouseContribution + calculatedDataTotalParentalContribution with totalFederalContribution:  calculatedDataTotalFederalContribution

Additional Context
The assessmentData table has not been reviewed in a long  time and we need to validate that the sources are all correct.
Technical

[ ] Adjust E2E tests.

Added an AC based on discussion with @andrewsignori-aot about Tuition in PT.

Demo
Student: Basic BCeID andrew_signori_20
Part-time application:<PHONE_NUMBER>

Offering


I cant start music bot

i cant start musicbot???
[INFO] launcher: Starting sanity checks
[INFO] launcher: Checking for Python 3.5+
[INFO] launcher: Checking console encoding
[INFO] launcher: Setting console encoding to UTF-8
[INFO] launcher: Ensuring we're in the right environment
[INFO] launcher: Adding local bins/ folder to path
[INFO] launcher: Required checks passed.
[INFO] launcher: Optional checks passed.
[INFO] launcher: Moving old musicbot log
[ERROR] launcher: Error starting bot
Traceback (most recent call last):
File "run.py", line 347, in main
from musicbot import MusicBot
File "C:\Users\Usuario\Desktop\Nueva carpeta (2)\MusicBot\musicbot_init_.py", line 6, in
from discord.ext.commands.bot import get_variable
ModuleNotFoundError: No module named 'discord'
[INFO] launcher: Attempting to install dependencies...
Collecting discord.py[voice]~=0.16.0 (from -r requirements.txt (line 1))
Using cached https://files.pythonhosted.org/packages/97/3c/2a97b47fd8839f8863241857bbd6a3998d1de1662b788c8d9322e5a40901/discord.py-0.16.12.tar.gz
Collecting pip (from -r requirements.txt (line 2))
Using cached https://files.pythonhosted.org/packages/5f/25/e52d3f31441505a5f3af41213346e5b6c221c9e086a166f3703d2ddaf940/pip-18.0-py2.py3-none-any.whl
Collecting youtube_dl (from -r requirements.txt (line 3))
Using cached https://files.pythonhosted.org/packages/c2/3b/17a27fecceb768ebec9e0d650fb764d47a5810b6840ea77177f128e2f0a8/youtube_dl-2018.8.4-py2.py3-none-any.whl
Collecting colorlog (from -r requirements.txt (line 4))
Using cached https://files.pythonhosted.org/packages/69/eb/58ae10d3c46a0195ffdd0e3943d255d0d5029d71e5457785ecd665bcf0f3/colorlog-3.1.4-py2.py3-none-any.whl
Requirement already up-to-date: cffi in c:\users\usuario\appdata\local\programs\python\python37-32\lib\site-packages (from -r requirements.txt (line 5)) (1.11.5)
Requirement not upgraded as not directly required: aiohttp<1.1.0,>=1.0.0 in c:\users\usuario\appdata\local\programs\python\python37-32\lib\site-packages (from discord.py[voice]~=0.16.0->-r requirements.txt (line 1)) (1.0.5)
Requirement not upgraded as not directly required: websockets<4.0,>=3.1 in c:\users\usuario\appdata\local\programs\python\python37-32\lib\site-packages (from discord.py[voice]~=0.16.0->-r requirements.txt (line 1)) (3.4)
Collecting PyNaCl==1.0.1 (from discord.py[voice]~=0.16.0->-r requirements.txt (line 1))
Using cached https://files.pythonhosted.org/packages/dd/99/bc86d40c88c1e1c6c9338d5afa91e3126d1ae28ad1bdfac79ab5b01803df/PyNaCl-1.0.1.tar.gz
Collecting colorama; sys_platform == "win32" (from colorlog->-r requirements.txt (line 4))
Using cached https://files.pythonhosted.org/packages/db/c8/7dcf9dbcb22429512708fe3a547f8b6101c0d02137acbd892505aee57adf/colorama-0.3.9-py2.py3-none-any.whl
Requirement not upgraded as not directly required: pycparser in c:\users\usuario\appdata\local\programs\python\python37-32\lib\site-packages (from cffi->-r requirements.txt (line 5)) (2.18)
Requirement not upgraded as not directly required: chardet in c:\users\usuario\appdata\local\programs\python\python37-32\lib\site-packages (from aiohttp<1.1.0,>=1.0.0->discord.py[voice]~=0.16.0->-r requirements.txt (line 1)) (3.0.4)
Requirement not upgraded as not directly required: multidict>=2.0 in c:\users\usuario\appdata\local\programs\python\python37-32\lib\site-packages (from aiohttp<1.1.0,>=1.0.0->discord.py[voice]~=0.16.0->-r requirements.txt (line 1)) (4.3.1)
Requirement not upgraded as not directly required: async_timeout in c:\users\usuario\appdata\local\programs\python\python37-32\lib\site-packages (from aiohttp<1.1.0,>=1.0.0->discord.py[voice]~=0.16.0->-r requirements.txt (line 1)) (3.0.0)
Requirement not upgraded as not directly required: six in c:\users\usuario\appdata\local\programs\python\python37-32\lib\site-packages (from PyNaCl==1.0.1->discord.py[voice]~=0.16.0->-r requirements.txt (line 1)) (1.11.0)
Installing collected packages: PyNaCl, discord.py, pip, youtube-dl, colorama, colorlog
Running setup.py install for PyNaCl ... error
Complete output from command C:\Users\Usuario\AppData\Local\Programs\Python\Python37-32\python.exe -u -c "import setuptools, tokenize;file='C:\Users\Usuario\AppData\Local\Temp\pip-install-q0ntce99\PyNaCl\setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record C:\Users\Usuario\AppData\Local\Temp\pip-record-s3of1e2v\install-record.txt --single-version-externally-managed --compile:
running install
running build
running build_py
creating build
creating build\lib.win32-3.7
creating build\lib.win32-3.7\nacl
copying src\nacl\encoding.py -> build\lib.win32-3.7\nacl
copying src\nacl\exceptions.py -> build\lib.win32-3.7\nacl
copying src\nacl\hash.py -> build\lib.win32-3.7\nacl
copying src\nacl\public.py -> build\lib.win32-3.7\nacl
copying src\nacl\secret.py -> build\lib.win32-3.7\nacl
copying src\nacl\signing.py -> build\lib.win32-3.7\nacl
copying src\nacl\utils.py -> build\lib.win32-3.7\nacl
copying src\nacl_init.py -> build\lib.win32-3.7\nacl
creating build\lib.win32-3.7\nacl\bindings
copying src\nacl\bindings\crypto_box.py -> build\lib.win32-3.7\nacl\bindings
copying src\nacl\bindings\crypto_hash.py -> build\lib.win32-3.7\nacl\bindings
copying src\nacl\bindings\crypto_scalarmult.py -> build\lib.win32-3.7\nacl\bindings
copying src\nacl\bindings\crypto_secretbox.py -> build\lib.win32-3.7\nacl\bindings
copying src\nacl\bindings\crypto_sign.py -> build\lib.win32-3.7\nacl\bindings
copying src\nacl\bindings\randombytes.py -> build\lib.win32-3.7\nacl\bindings
copying src\nacl\bindings\sodium_core.py -> build\lib.win32-3.7\nacl\bindings
copying src\nacl\bindings_init_.py -> build\lib.win32-3.7\nacl\bindings
running build_clib
error: [WinError 193] %1 no es una aplicación Win32 válida
----------------------------------------

Command "C:\Users\Usuario\AppData\Local\Programs\Python\Python37-32\python.exe -u -c "import setuptools, tokenize;file='C:\Users\Usuario\AppData\Local\Temp\pip-install-q0ntce99\PyNaCl\setup.py';f=getattr(tokenize, 'open', open)(file);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, file, 'exec'))" install --record C:\Users\Usuario\AppData\Local\Temp\pip-record-s3of1e2v\install-record.txt --single-version-externally-managed --compile" failed with error code 1 in C:\Users\Usuario\AppData\Local\Temp\pip-install-q0ntce99\PyNaCl
You are using pip version 10.0.1, however version 18.0 is available.
You should consider upgrading via the 'python -m pip install --upgrade pip' command.
[CRITICAL] launcher: You may need to run as admin to install dependencies.
[INFO] launcher: All done.

Please uninstall python 3.7 and install python 3.5.4


NO-JIRA Adding javadoc as part of github actions

I know this will fail.. next step will be to send fixes


Feature 2178: IEX Data Downloader

Implementation of the IEX Data Downloader and its integration into ToolBox.
Description
Partially based on @mblouin02 PR #2224, that creates history provider from IEXDataQueueHandler. This provider is used in IEXDataDownloader to get Minute and Daily resolutions (with limitations) from IEX.
Related Issue
#2178
Motivation and Context

Requires Documentation Change

How Has This Been Tested?
Run provided tests
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Non-functional change (xml comments/documentation/etc)

Checklist:

[x] My code follows the code style of this project.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] My branch follows the naming convention bug-<issue#>-<description or feature-<issue#>-<description>

Hi @wildart ! Looks good. Please update the --h documentation at https://github.com/QuantConnect/Lean/blob/master/Configuration/ToolboxArgumentParser.cs#L18 and the readme at https://github.com/QuantConnect/Lean/blob/master/ToolBox/README.md


unable to use example for GCE as is

The echoserver service is not getting an IP assigned to it. Not sure what is causing the issue.

Yeah, I'm facing the same problem :( Additionally, the created LoadBalancer indicates unhealthy nodes. :/

The IP is gonna get assigned to the ingress object for the GCE example or to the nginx service for the other.
To debug further this needs information++

@simonswine I can do this again. Let me know which logs will be helpful to debug this.


Fix when partition key is not supplied

Fix when partition key is not supplied, default to empty string.

@ziyi-curiousthing it doesn't seem to change obviously. When partition_key is what value, an exception will occur

@SimFG This is to fix the case where user doesn't supply partition_key, so it is passed in as None and Milvus doesn't like it because the field type is string. I am not quite sure how to set the field to be optional so that it can take None (or save without this property). Any suggestions?

@ziyi-curiousthing maybe when the partition key is None, you can set it's value to default, like:
partition_key = kwargs.get("partition_key", "default")

And for the better way, you should have a param when  initing the milvus, which is whether enable the partition key function.

And for the better way, you should have a param when initing the milvus, which is whether enable the partition key function.

Thank you @SimFG for your feedback. Should be addressed now.


HoloLensCamera.prefab Gaze Controls: Joystick Axis Controllers' Input Axis not setup

Joystick Gaze Controllers on the HoloLensCamera.prefab have not had their Input Axis' set up in the Input Settings.

Just ran into this problem.  Is there a work around?  I prefer to use a gamepad when testing in the editor.

No workaround but to set them up. haha.  I had been working on this a bit, but didn't get a chance to finish.
https://github.com/StephenHodgson/HoloToolkit-Unity/tree/HTK-JoystickInput

You're amazing.  I out of my depth on this and don't have a lot of time.  Hence dumb questions following: How did it work in the old HTK versions?  Both AxisController.cs and Project Settings>Input look identical.   Looked at that branch and see JoystickControl.cs and JoystickController.cs ... is the latter just for XBO S bluetooth controller?  I'm just using a crappy USB XB Afterglow controller.  Should I try that branch, or wait for Your Awesomeness :) to finish and just keep using old HTK for now.  (Or I could just get used to the keyboard inputs.  :)

I don't remember the last time I updated it.  So YMMV.  I was using the XBO S bluetooth controller.

Cool, I'll play with it if I find the time.

I hate to drag this issue back up again after so long, so my apologizes in advance.  I'm not super proficient with how the Unity input was supposed to work and so with versions 5.6 and previous I always just took it for-granted that when working in the editor my RIGHT Thumb Stick 4th and 5th axis was able to control the look rotation of the HoloLens camera.  However now that I understand these kinds of inputs are supposed to be setup in the Unity Properties>Input, when I look there don't see the 4th and 5th axis mapped to anything!!??  So how was/is this working?  I've been search through all the HTK scripts and can't find any reference to the 4th and 5th axis.  I've even tried breaking it by deleting the AxisController.cs, ManualGazeControl.cs, ManualHandControl.cs, and EditorHandsInput.cs and my app still runs perfectly fine in the editor and I can rotate using the right thumb stick!  I'm so confused!

The Xbox support can be enabled in the HoloToolkit/Configure/Apply Project Settings window

When enabled it'll automatically download and update your input manager asset with the correct mappings

Oh Splendid!  I just tested this in 2017.1.1 using an Example Scene and it worked!  Sweet!  Thank you so much!  I can't imagine testing my app without use of the controller.   I'm super happy right now!
BTW - Any idea how to suppress this error in the console?
"RenderTexture.GenerateMips failed: render texture does not have mip maps (set useMipMap to true)."
I know this is a Unity bug...but it makes the console useless.

It'll close once I merge the PR.  Please review it.


Metrics comparison table - difficult to find the scenario for 'deletion' from the table

Kind of request
Changing existing functionality
Enhancement Description
Right now if you add a bunch of scenarios in the 'compare - table' tab, and you want to delete one, you can't just select the column and click delete. You have to find the scenario again in the scenario select window. Would be better if you could just select it in the comparison window and click delete.
Task list

Figure out how hard it is to select a column in the table and then click delete
Implement if not too difficult

Use case
No response
Additional Context
No response

This one waits for a PR in Guitares. Review needed from Maarten


Strange bug with TouchableHighlight and InteractionManager.runAfterInteractions

I'm experiencing a strange bug when navigating to a route in my FluidNavigator. If I use a TouchableHighlight then runAfterInteractions will trigger immediately on the new screen when I press the button. But if I use a TouchableOpacity it works as expected and runAfterInteractions is called on the new screen when the transition is complete.
This does not happen if I use a regular StackNavigator from react-navigation.
I have tested on both iOS and Android and it seems to happen on both platforms.
Any idea what could be causing this?

Facing the same issue. Any updates?


Add the sample code from samples/run_sample.sh to samples/README.md

Add sample code for kubectl and helm from https://github.com/tungbq/devops-toolkit/blob/267b3336b3949722a411c12478784f5382c46a8f/samples/run_sample.sh#L36
to  https://github.com/tungbq/devops-toolkit/blob/main/samples/README.md#kubectl (replace the TODO)

Hi Tung, Xin Chao
I am looking to gain experience as a devOps engineer. Can I help you with your project?
Best,
Chris

Hi Tung, Xin Chao I am looking to gain experience as a devOps engineer. Can I help you with your project?
Best, Chris

Hi Chris @Chrisgr1 , Xin Chao ❤
Yes, surely, welcome to this project. Feel free to find a ticket that you interest and work on it. Thanks.
This could be the first start one, I've just assigned it to you

Thanks Tung!

Hi @adiltamboli12 thanks for your PR #130. It's really nice, I appreciate your contribution in this repository.
Just would like to close it as @Chrisgr1 has already been assigned the ticket before your PR.
So, I would prefer using the PR from @Chrisgr1 (#132) instead of #130. I hope you could understand this situation. Thanks!
Again, thanks for your contribution! If you want to contribute more on this repo, you could find other good first issue to work on. Thanks!

its very nice to hear from you. I am new here that why i did this and thanks for guiding me i want to contribute and i try to do contribution as much as a i can. thank @tungbq


Vulcanize browser-specific Polymer elements with generic elements. Combine app-missing.html and index.html

To better solve https://github.com/uProxy/uproxy/issues/899, this pull request combines browser-specific and generic Polymer elements so that we can switch add the app-missing element directly into index.html.
Quick explanation of some of the code that might look weird:

I added the 'Rule.typescriptSrcLenientNeverFast' rule so that generic_ui compiles each time the task is scheduled. Without the 'fast = never' option, if you try to build Chrome right after FF, it won't recompile polymer, even if browser specific elements have changed
the order or tasks for Chrome / FF now includes removing the symlinked polymer/ folder (in case if has elements from the other browser), copying in all generic_ui/polymer, copying in browser polymer, compiling generic_ui, then vulcanizing

the other alternatives were making two compile-src folders, or creating two polymer (e.g. polymer_chrome and polymer_firefox) folders within our current compile-src; I felt that these ended up doing more work than necessary

I changed 'grunt build' and 'grunt test' to be registered without the task manager. The task manager would also stop generic_ui from recompiling between Chrome/FF builds, but at a higher level than grunt-ts did.
From digging through Chrome bugs, I think because of some recent changes to icon display logic, my retina screen would show the 128x128 icon (the 'online' one) over the 19x19 correct default icon, unless I also added a 38x38 icon. Also the .gif browserAction icons didn't work (for me at least), which is why I have the .png listed as 19x19 and 38x38. (Chrome's specification that they won't scale up icons is based on what size you declare icons to be and not what size the icons actually are.) Relevant Chrome bug here: https://code.google.com/p/chromium/issues/detail?id=404572
In root.ts I realize it seems really odd to have to create a div, set its innerHTML to a new element, and then call the div's first child node to access the new element. Polymer was raising an error and this was a (working) solution suggested online. I haven't yet figured out it works though.

ran grunt test

:+1:


Merge upstream at 26886d6d95fbf290df1526cc2a51355da611f8be

Upstream at https://github.com/prometheus/prometheus/tree/26886d6d95fbf290df1526cc2a51355da611f8be

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.9 out of 15 committers have signed the CLA.:white_check_mark: jhesketh:white_check_mark: fionaliao:white_check_mark: beorn7:white_check_mark: bboreham:white_check_mark: zenador:white_check_mark: duricanikolic:white_check_mark: krajorama:white_check_mark: roidelapluie:white_check_mark: alexgreenbank:x: jan--f:x: juliusv:x: aniketnk:x: bwplotka:x: SuperQ:x: NeerajGartia21You have signed the CLA already but the status is still pending? Let us recheck it.


Upgrade aws-java-sdk-s3 from 1.10.26 to 1.10.77

@llibra
Can you review this PR?
Related.
https://github.com/embulk/embulk-output-jdbc/pull/166
https://github.com/embulk/embulk-input-s3/pull/56
Best regards.

Merged. Thank you!

Thank you!.


Error executing start-db-service.sh Update 4 (Quick Start)

I'm doing the Quick Start, but I can't finish Update 4.
I'm getting two errors when I execute start-db-service.sh :
The first error I solved:
-bash: ./start-db-service.sh: /bin/bash^M: bad interpreter: No such file or directory
The first error occurs because I'm on Windows. I solved this problem with this command:
sed -i -e 's/\r$//' start-db-service.sh
Maybe it's good to be in the documentation.
The second error, I didn't solve:
After executing the script start-db-service.sh I'm getting " Status is NotReady Iter [N/60]", then the error "[ERROR] Unable to start the Pod"
Enviroment
Windows 10
WebLogic version: <IP_ADDRESS>
Oracle Database: <IP_ADDRESS>-slim
I have pushed from the master.
Git commit ID: 59b297b30de8cc773ee5c4175df8b86370e13dd6
Date: Tue Jul 20 11:09:03 2021

I discovered.
The problem is, I don't have enough memory.
I fixed it by changing the configuration file "oracle.db.yaml" memory properties.


stop using bootstrap in the dev example

We can keep the bootstrap based app/style somewhere but now that we have theming, we need to test our default.css without using bootstrap.
To see if we need some more default styling, like active refinement and spacing around inputs/checkboxes (cc @redox)

:100: on that one

I think we could have a dev/ and examples/ (using the releases not the build)

I think we can close this one; it's mostly done with our new website. I'll remove the gh-pages branch for now as well.


firefox_shim: make ontrack shim configurable

If you include adapter-latest.js (v6.3.0) in a web page, old versions of Firefox (in my case 43.0.1) will throw the following:

TypeError: can't redefine non-configurable property "ontrack"

This issue is similar to #832 (fixed by #833). Except that this one occurs even if you include the adapter only once.

I signed it!

that is a terribly old version which is far beyond anything we support (FF ESR which is 52) but this seems consistent with more recent changes in the chrome shim.
Will merge on CI passes, thank you!

Unfortunately, I did not have the opportunity to test it using newer versions. However, my goal was to tell you about the issue and I thought that it did not matter which version I use for testing.
Thank you for your time! I'm very glad that you approved my patch.

This will go into version 6.3.1 -- as soon as I've merged some other pending PRs.


serialport_native.node: wrong ELF class: ELFCLASS32

Hi,
I installed the serialport module via npm on an Ubuntu 11.04 64bit machine:
$ uname -a
Linux x-machine 2.6.38-11-generic #48-Ubuntu SMP Fri Jul 29 19:02:55 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux
$ node --version
v0.5.4
$ npm --version
1.0.26
but when trying to use the module it throws an error "wrong ELF class: ELFCLASS32"
Error: /home/.../node/node_modules/serialport/serialport_native.node: wrong ELF class: ELFCLASS32
Is there a workaround to compile as ELFCLASS64 (I presume) or does the serial port module not work on 64bit?
Thanks

is this still an issue? I do not have this configuration and cannot verify.


Support for multiple signatures

Hey,
So I was looking at how to support multiple signatures.
If the document is already signed, then the ecdsa-sd-2023 signature gets added to the document in an array of proof as expected.
However I see 2 issues:

when both signatures are present on the original document, the first one will verify, but the ecdsa-sd-2023 will not because the document has not been derived, hence most likely creating a false negative in terms of validity
if derived, the first signature gets dropped, so while the ecdsa-sd-2023 verifies, we have lost the knowledge of the first/previous signer.

I tried adding proof as a mandatory field and sign, but it gets dropped (https://github.com/digitalbazaar/jsonld-signatures/blob/main/lib/ProofSet.js#L57), at the moment of truth the proof property is not part of the signable document, hence it throws an error:

JSON pointer "/proof" does not match document.

I tried commenting out the delete instruction and was able to sign with I suppose the proof property as part of the ecdsa-sd signature value:
"proof": [
    {
      "type": "MerkleProof2019",
      "created": "2023-03-30T15:08:26.139158",
      "proofValue": "z4zvrPUULnHmaio2Q46Qert56PPkSCiQV6gSTM9uNxCUmxCkyXPgQ9faMYifYyQZcy6PrhpF9B6KiQTAybcsiwJZjskww5kNkthChkwqofzcRHgXHTxGtC8A377c3LLBLuBtHaSnSKjntwFafC47mXFsoKYnXNAc2ysTR9cbDtcmmZNugrq5pcZiTGVC2kYqW7iF7JAqrzitGk3TNfQbV77TJLoQkCfJGsUvWPBesiWyUMSdecDbKzXH2VEHvGxHNsd1NXGoBFdgGr6Tk4sDPRgTewNFZfLnxcvc5VZNiGZTHKza5EnrQxikhS1kvHXN8W7Ldvcr4eHTkj5R544UtLMzPjJyMWtHnbKP64GiWBj3AbBoauZ6JxHnS4xCU3uH6QbNjr3i3jTokJSy3nx",
      "proofPurpose": "assertionMethod",
      "verificationMethod": "https://www.blockcerts.org/samples/3.0/issuer-blockcerts.json#key-1"
    },
    {
      "type": "DataIntegrityProof",
      "created": "2024-01-22T16:52:54Z",
      "verificationMethod": "did:key:zDnaebnVAPUfmM31cqEiju2GZo5MQFwhhuPiFXsiBPjzpvPvB#zDnaebnVAPUfmM31cqEiju2GZo5MQFwhhuPiFXsiBPjzpvPvB",
      "cryptosuite": "ecdsa-sd-2023",
      "proofPurpose": "assertionMethod",
      "proofValue": "u2V0AhVhAnnhRiiIJ7uL0ODKnZ0JYYV3ISW1yXjjbmYtoSET0TtzGvpkLQhBuOIuGFvJgeqt7epbn6YbPyVNw3Nw63NBb2FgjgCQDXG1mPbhsD-3aiBplVhYLso_IGEwjdU61teJ190i3-yxYIENtQLKlTV8B6DR89fmdosrbYOXToJJB0q02s-nE8B-ejVhAZh2S1pEGgwRJFcP4ADigKeMZxYDEaQ1wxJCA_K3bOode_O7DsnpTNUza_Liv2-qCxx6QWBKPAMEg4qm6HMBFglhABPuYkkJ4ABHsbnBItFVTtmHvjTRZ8JAauCbjVwDxeFhnp9bAO6f_hWETAwt7EAOobu3kPVpDtFHirU5P5w2TK1hAbONS4VkGiwaXqtJKocG87I-xCy6Kp9Tbh4aLfTWcOGKwWMq8z0Wk7n0Fz4Z5qF0gWR9jzYzXY579Y_Qo254Z4FhAykBTwYwD--rMXWyqVOhHGNQyoITCsM_vGqLTLD6RMtfHTi5zev1M_lxp9EkW3aunje2MSz9PM6pz3j_o4IH5blhAztuxMR2v1Y12_DtyIWojj307xmEr_bIDp7iqkb0c5ixgLXx2DQ8uV2E6G0nZH_aCc07GfEqSVRHWiGRDtSFvC1hATBmJqhpLDrNrfoGlIiwNzFAvAg0zjcVYNE5bn6tuBmp4wt3FJcITAl136I3LqcZJi68tIPFY0DXgyybwzapdwlhA5foP7b3f09NG2LwT4b2_KLLOlGKTr_TkJeANpk4TWQrRdLK2piEv_LPvmuFydDI6v6UFJw8bH2xR9Q2OvQnze1hAUUkVtYqP3im16yXTkSsgYnYsKp75vAmbWmYnchw1nZPHcCAJxEs-g2nO9S2iNXckR8yB6j751ZuGqBnRr90-PVhAVWdJyFEnA8ElQh7RNhBQy5sTufN_8Rm7dEIyf5W251cEj6ENrBZXp7r9uSHr-O1gjv6kaXYasD7HsVbtiAWZNFhAM9JR3iUCdhuCi77VcDGOCAgzHjUzW90-Q3yPzWzkquPaUgoa_P9ShEBeoW84z1WAAmc37KaI2W2JYJi1D0pU41hAXjZTU8R7dn2Smx3S2YMUaxR8og7pTRUGapHUYnV-11wonXB50uiIrQGvbUgMsgqmB4agxysRreMxf00bPgTrMVhAdXo6FwA0q0hc5v_-PtDT_c37PbbyNX2zUs2tu1QBcCPZp9ReSAzcYvQ_SK0RA2-RiBl3TNQLNmZRimB0gV2oWlhAwS3BzsZpoRULFxrNgcTNtqMka9T6XMgMd7y4JGrMIsqrFhbE5W83dNEXMKhcS9qTz9Hlxp3sZMeBWTe966LbJYNnL2lzc3Vlcm0vaXNzdWFuY2VEYXRlZi9wcm9vZg"
    }
  ]

At this point I tried to derive but again the same issue occurs (https://github.com/digitalbazaar/jsonld-signatures/blob/main/lib/ProofSet.js#L117). Commenting this out leads to another issue ( "labelMap" must be a Map of strings to strings.) which I didn't debug further.
Because anyway even if derivation worked, and the initial proof remained in the derived document, since it is now a subset of the initial document, the first signature wouldn't pass as the document has been "tempered with" in its computation.
So it looks an unsolvable problem. Was there any sort of talks on the subject, any context you could fill me with to get  a broader understanding of what could be done alternatively?

@lemoustachiste,
We're not aware of a use case where a derived VC that carries additional proofs is necessary.
Currently, the supported use cases involve having multiple proofs on a single VC that is stored in a digital wallet. This proof set is free to include N-many "traditional digital signature proofs" and M-many "base proofs" for selective disclosure / unlinkable-style VCs.
Then, at presentation time, a verifier indicates which cryptosuites they accept and the digital wallet (potentially with input from the user) selects one of the accepted cryptosuites and provides the VC using a proof that matches it. This will involve performing proof derivation at the time (if the mutually acceptable cryptosuite supports selective-disclosure).
There's no reason to presume that a selectively disclosed reveal document (VC with a derived proof using a particular cryptosuite) would continue to be compatible with any other proofs based on other cryptosuites. This isn't part of the design requirements for such cryptosuites -- and I imagine it would be quite challenging to make it so. For example, certainly a traditional digital signature proof would fail when any information in a VC is omitted during selective disclosure. Similar problems may occur with how selective disclosure is performed between different SD-style cryptosuites, depending on what they do. Current designs for any SD-style cryptosuite thankfully do not need to consider every other possible cryptosuite's approaches (including unknown prospective ones).
In short, there's no expectation that a derived proof would work in a proof set, nor is there any use case that I'm aware of where it would be needed. The derivation occurs once negotiation has already been performed to select a mutually acceptable cryptosuite to provide the security for a presented VC. Does this make sense -- and do you have some other use cases in mind?
If you are thinking of presentation of VCs "for the purpose of transfer" (i.e., simply moving VCs from one digital wallet to another), a digital wallet can get the consent of a user that the current request is for this purpose and include the VC(s) as they are (with their base proofs intact, performing no derivation). The recipient would also be aware of this. This is a special case of presentment, but it involves no derivation.


PDL recipe

To clarify my last comment, you need to add the notebook to both files- the yaml says "fire this test if any of these files are changed", then later in the testing it loads the txt file and tests every file listed in there.
@deanwampler specifying the files is problematic, because sometimes (in the case of ollama or the java ones) you add the path to a different yaml / text file. But changing the PR template is trivial, i can certainly add more information.

Thanks. This is pure Python, so I'll add the notebook to both files in my PR to @vazirim's PR branch.

Hi @deanwampler, thanks for all your suggestions. I incorporated your branch in this one.

I have a theory for while the CI is failing. It's not this PR's notebook. I'm going to merge this PR shortly and do a separate PR for the final steps required.


[CI TESTING][DO NOT MERGE] Testing HUDI-3948 with metadata table reading enabled by default

Tips

Thank you very much for contributing to Apache Hudi.
Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)

Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)

Added integration tests for end-to-end.
Added HoodieClientWriteTest to verify the change.
Manually verified the change by running a job locally.

Committer checklist

[ ] Has a corresponding JIRA in PR title & commit

[ ] Commit message is descriptive of the change

[ ] CI is green

[ ] Necessary doc changes done or have another open PR

[ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot run azure

This is for CI testing only.  Closing it now.


x/website: tables are awkwardly formatted

What is the URL of the page with the issue?
https://go.dev/ref/mod#environment-variables
What is your user agent?
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/<IP_ADDRESS> Safari/537.36
Screenshot

What did you do?
Visit https://go.dev/ref/mod#environment-variables
What did you see happen?
The table of environment variables has no cell borders and the content is vertically centered. This makes it needlessly difficult to understand which variable corresponds to which description, and where one description ends and the next begins.
What did you expect to see?
If the table is going to have no borders, then I think the content should be top-aligned.
I'd expect that other tables in the Go documentation probably have this issue as well.

I agree this table will look better and more readable if it's top-aligned.
CSS adjustment for this table is welcome.

Hi, I would like to work on this issue and want to know if you assign issues here.
I have found the file ref/mod.md in which changes need to be made.
I wanted to know how you are applying css to the table ?
The table is having a class ModTable

Not sure where to throw it, but the following worked well for that page, imo. I didn't see .ModTable   defined anywhere in styles.css, so there shouldn't be any conflicts.
.ModTable th, .ModTable td {
    vertical-align: baseline;
    text-align: left;
    padding: 1rem;
}


Add an attach command to nuxi CLI to install modules

Describe the feature

This issue proposes the addition of a new command, nuxi attach, to the CLI, allowing users to install Nuxt modules and update the nuxt.config.ts file accordingly.
Currently, there is no straightforward way to install Nuxt modules and automatically update the nuxt.config.ts file with the installed modules. This often requires manual installation and editing of the configuration file.
This would make a fantastic addition to the nuxi CLI! 😄 Both Qwik and Astro have already implemented similar features within their CLIs, which have been highly beneficial to their users.
Proposed Changes

Implement the nuxi attach command in the CLI.

Usage
nuxi attach <module>

The nuxi attach command will take the name of the desired Nuxt module as an argument and install the equivalent package.

Example
# Tailwind
nuxi attach tailwind # Will install @nuxtjs/tailwindcss

# Pinia
nuxi attach pinia # Will install @pinia/nuxt

# Apollo
nuxi attach apollo # Will install @nuxtjs/apollo

It will run the appropriate npm|pnpm|yarn add command to install the package as a dev dependency.
The command will then update the nuxt.config.ts file by adding the installed module to the modules array.
If the modules key is not present in the defineNuxtConfig(), it will be added with the installed module as the first entry.

Expected benefits

Simplifies the process of installing Nuxt modules by providing a dedicated command.
Automates the update of the nuxt.config.ts file, reducing manual editing and potential errors.
Improves developer productivity and enhances the overall user experience.

Tasks

[x] Implement the nuxi attach command in the CLI.
[x] Update the nuxt.config.ts file with the installed modules.
[x] Test the functionality of the nuxi attach command with different Nuxt modules.

Additional information

[X] Would you be willing to help implement this feature?
[ ] Could this feature be implemented as a module?

Final checks

[X] Read the contribution guide.
[X] Check existing discussions and issues.

This is absolutely on the roadmap. We're currently building a new nuxi so we won't move forward with this here until it's made open-source. Will DM you though 😉.


Sample bot-sso-adaptivecard still using botframeworkadapter which is deprecated

Code here: https://github.com/OfficeDev/Microsoft-Teams-Samples/blob/3a3049715a3710006304769b76bca00577bc102b/samples/bot-sso-adaptivecard/nodejs/index.js#L24

@KennethBWSong - Thank you for reporting this, we will check this and get the sample updated if necessary. Thank you.

https://github.com/OfficeDev/Microsoft-Teams-Samples/pull/1042/files has been raised for this issue.

Any updates?

PR has raised for this: https://github.com/OfficeDev/Microsoft-Teams-Samples/pull/1042/files. Changes will reflect once the PR is merged.

@Meghana-MSFT Seems the PR is merged, and I got following error when debug with Teams Toolkit:

Do you have idea on what's the reason?

@Meghana-MSFT Also, in this sample to get SSO token:

type of the card is "application/vnd.microsoft.card.loginRequest" which is different from here. Would you please help to confirm which is the correct way?

We will check this and get back to you.

@Meghana-MSFT Seems the PR is merged, and I got following error when debug with Teams Toolkit:   Do you have idea on what's the reason?

This is a known issue, bug has been raised for this already - https://github.com/MicrosoftDocs/msteams-docs/issues/8584

@Meghana-MSFT Any updates on this?

Hello @KennethBWSong - Sorry for delay in response.
We are actively checking the updates on this issue and let you know if any.

Any update on this? The samples are really hard to follow in general, let alone when they contain wrong code.


Translating webpages

Environment
Flutter version:
Plugin version:
Android version:
iOS version:
Xcode version:
Device information:
Description
Is it possible to translate webpages in webview. If yes please guide me, I don't have any idea about implementation..
What you'd like to happen:
Alternatives you've considered:
Images:

Actually, InAppWebView on IOS seems use phone system language. Not very cool when translate app because webview stuck in english for example...

@EArminjon The plugin is not doing any translation. If on iOS "stuck" in english, this depends on how the native WebView works, that is WKWebView on iOS.
Also, if the system language is in english, well, I think that is the correct behavior using the english for that WebView. It will be very strange if this don't happen.
If you need translate something, you need to do in other ways and implement it by yourself. Translating webpages is not a feature of WebViews.
Probably you can do this using the Google Translation API https://translate.google.com/intl/en/about/forbusiness/


added checkstyle in project

added the checkstlye.xml
fixed the check style issues, there is no violation


Please remove user from CDCorg

Please remove the following user from the CDCgov org:
Chris - magikid

Please remove the following user from the CDCgov org: Chris - magikid

The user magikid doesn't have access to any cdcgov or cdcent repositories.

Ok, he was in the ticket from yesterday so I wanted to make sure. He's not going to be working for the CDC.

Got it. Marking ticket as completed.


A question with AutobahnClientTest .

Describe what you would like to know or do
The result of autobahnClient was not expected.
Run the org.java_websocket.example.AutobahnClientTest and the org.java_websocket.example.AutobahnServerTest .
Enter the command in the client side:
r 1 5
we can get the message:

//////////////////////Exec: case=1&agent=tootallnate/websocket

But from Type 'r <first casenumber> <last casenumber>' to run a testcase. Example: r 1 295, i think there will be some more cases to run, but it didn't.
For example, if we enter the command r 1  5, the expect result maybe:

//////////////////////Exec: case=1&agent=tootallnate/websocket
//////////////////////Exec: case=2&agent=tootallnate/websocket
//////////////////////Exec: case=3&agent=tootallnate/websocket
//////////////////////Exec: case=4&agent=tootallnate/websocket
//////////////////////Exec: case=5&agent=tootallnate/websocket

On the another hand, if we type ex, the program will exit.
But after the first command is entered, it doesn't work with any following commands or the first task keeps a long time and is not finished anymore.

Please clarify your issue

Works for me with the current master.

@dota17  if this issue is solved for you, please close it

@dota17 if this issue is solved for you, please close it

Excuse me, how's the repair going?
I can't see any changes with pr or commit.

Nothing is broken? No steps to repeat were provided which showed unexpected behaviour....

Is your Autobahntestsuite running???

Is your Autobahntestsuite running???
Right port and configuration??

Is this https://github.com/TooTallNate/Java-WebSocket/wiki/Testing-using-the-Autobahn-Test-Suite ?
I'm sorry that I can't open the site of http://autobahn.ws/ .

https://github.com/crossbario/autobahn-testsuite should be the link

https://github.com/crossbario/autobahn-testsuite should be the link

I had installed the autobahn-testsuite and run the server in the ubuntu as follow:

And I had a new question with that how can I run the AutobahnClient in the ubuntu?

Please check Google on how do compile java files and run them on Linux

@dota17 The error in your last screenshot happens because the class name is actually org.java_websocket.example.Autobahn. To run it, go to the target directory and run
java -cp 'test-classes:classes' org.java_websocket.example.AutobahnClientTest

@PhilipRoman
It works. Thank you very much.
I would run and test to check whether the problems which I commented above are existed.

It's OK now. I closed this.


Invalid MD5 hashes in make-json command

As reported in https://core.trac.wordpress.org/ticket/45488.
Have to check that we take the path into account when creating the MD5 hashes of the file names.

@swissspidy It currently looks like this issue will be handled on the core side?
I'm asking because I'm wrapping up a release and wondering whether there's something re. this issue that needs to be in this release.

I finally got to test this with a custom plugin and Traduttore. The Traduttore plugin creates JSON files just like WordPress.org and it's being used successfully to translate some Gutenberg bloccks.
The plugin creates JSON files with identical MD5 hashes in the file names as wp i18n make-json.
Closing this issue for now.


Allow the file explorer to open any file into the editor as text

From<EMAIL_ADDRESS>on 2012-04-05T10:15:30Z
I frequently use spyder to view various text files (e.g. csv, jsonlines, html etc) that I'm doing some processing on using Python. (Of course I also use spyder to write and run the Python code too)
Currently, to open a file as text in the editor you need to go view the File > Open dialog.
It would be great to also be able to do this via the File explorer in spyder (e.g. maybe via a right click > open in editor menu).  The current technique (File > Open dialog) is slightly tedious by comparison.
Using the file explorer to open a file in the editor is possible in Matlab, and seems quite an intuitive interface to me.
As an aside, as this is my first post on the spyder project pages, I would like to say that I love this project - it makes my life a lot easier. I use spyder for all my python coding (i.e. about 50% of my day, every day) and most of my debugging in my job.  It's the best IDE (in my opinion) that I've found for python, after a lot of searching. Thanks to everyone who has contributed for all your hard work - it's much appreciated!
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=987

From ccordoba12 on 2015-01-08T11:03:39Z
This was fixed in revision 4129ece7a108
Status: Fixed

From ccordoba12 on 2015-01-02T18:12:09Z
Some changes were introduced in 2.3.2 to make this happen and the work will be completed in 2.3.3
Labels: Cat-Editor MS-v2.3.3


UART DMA re-implementation

Description
This is a rehash of PR #440 as implemented by @Miceuz
Changes to master have caused github to force-closed the PR. The branch as been rebased and this is the new PR for the same content.
This is in need for further review. I have attempted to address original reviewer's comments, but would appreciate some additional eyes on this. Please read original PR and expand all hidden, resolved and obsolete comments.
Note about testing locally: the relevant code is not enabled on the controller itself. It is "ifdefed" out conditionally on BARE_STM32. In addition to running controller.sh --test, you should also run pio run -e stm32-uart which will at least compile all the code, but will fail to link because some globals are not yet defined in hal_stm32.cpp. These final pieces will be in place by the end of this PR chain, which we are in fact merging into master piecemeal.
Updates #159
Part of PR chain:

#1135
#1136  <-- we are here
#1137
#1138
#1142

General checklist:

[x] I have performed a self-review, including - looked through the Files changed tab, browsed repository in my branch
[x] I have made corresponding changes to the documentation - to reflect changes in code, electrical or mechanical design
[x] All new documentation or graphics follow the documentation style guide
[x] All new content is linked, easily discoverable, does not require too many clicks
[x] I have reviewed any other relevant parts of our contributor wiki to ensure that this PR conforms to the standards
[x] I have given the PR a descriptive name (prefixed with WIP if it is not yet ready for review)
[x] I have tagged relevant reviewers

Code checklist:

[x] All new code follows our code style
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have described tests I used to verify my changes, instructions for reproducing them and any relevant configuration details.
[x] I ran the unit test suite and verified that all tests pass - new and old, locally and on CI
[x] I performed a clean build and verified that there were no warnings
[x] I ran our static analysis tools and verified there were no warnings
[x] Any dependent changes have been merged and published in downstream modules

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

The rx_timeout feature was deemed unnecessary, so related code for encoding duration into a 24-bit integer was removed. Since it will get lost in the squash-merging, here is the code that may someday prove useful if it turns out we need the time-out feature.
in uart_dma.h:
  typedef struct {
    uint32_t ignored : 8;
    uint32_t bits : 24;
  } uint24_t;

in uart_dma.cpp:
// Converts Duration to the number of baudrate bits as that is used for rx
// timeout. Max timeout supported by STM32 UART is 24 bit
UartDma::uint24_t UartDma::DurationToBits(Duration d) {
  return {0,
          static_cast<uint32_t>(d.milliseconds() *
          static_cast<float>(baud_) / 1000.0) & 0x00FFFFFF};
}


KOGITO-1220: Business Modeler Hub Preview

CI won't pass since there's a need to install wine to build the Electron app for Windows.

@tiagobento Ping me when I am able to test :)

@tiagobento Is there a way to import file for file system in the HUB? I wasn't able to find it.

Hi Dominik! Thanks for your quick review.

As requested, I'll add instructions on how to build and package the Desktop and Hub modules (they work the same).

Having a script inside the Zip will have the same problem as the Hub's executable. You have to give permission to run it before you do. Did you try opening it from the UI after changing the executable's permissions? I'll talk to others about the possibility of adding a README file to the distributions Zip.

Ths Business Modeler Hub Preview is not intended to work as a "catch all" application. Its purpose is to bundle and help users access our tools. If you want to open a file, you should launch VSCode or Business Modeler Preview Desktop.

Hi @tiagobento

Good, that helps alot.

Sure, I am not saying we have to have script, it seems as an overkill. I tried to add exectuable rights but I still wasn't able to run it without command line. (clicking from UI shows error about missing application for Shared library files and I didn't try to look for it as I am trying basic fucntions of the hub.

Cool, I just wasn't sure.

I found one bigger issues:

Create new process OR dmn file
Model something (star -> end)
Save and input name without .bpmn suffix or .dmn suffix
Use Recent to open it
There will be error about unsupported file.
WORKAROUND:
When saving, add corresponding file suffix - .bpmn or .dmn

I am unable to test the Import via URL for BPMN properly because of - https://issues.redhat.com/browse/KOGITO-513 Every file I try to open shows the error.

@paulovmr See Dominik's issues above, please.
@domhanak These issues are related to the Desktop App and should be addressed in a separate PR.

@tiagobento @paulovmr Okay, do you want me to report it or do we already have such jira?

@domhanak I think we don't have one yet.

@domhanak Changes are pushed, please re-review it 😝.
Also, could you please create a JIRA with the error you're getting when clicking the executable on the Linux file explorer UI? We'll track that and see what may be causing it. Thanks!

Ok so an update: this blocks me - https://issues.redhat.com/browse/KOGITO-1615 from verification of some scenarios.
Yes, I will add it to the jira (the issues with UI openning of HUB)

The changes look good to me. Thanks @tiagobento that is exactly what I wanted. :)
Not sure about the builds, they seem to fail.

@domhanak Yeah, GitHub Actions is having a problem with downloading the npm dependencies on macOS. A timeout is occurring for some reason.

@domhanak Thank you! I've created this JIRA [1] to track the error when trying to open the application from Linux file explorer UI.
[1] https://issues.redhat.com/browse/KOGITO-1220


Fix connection flush

See the full conversation here: https://github.com/libp2p/rust-libp2p/issues/2461
The bump to Yamux 0.10 in libp2p broke the wasm-ext transport (used for WebSocket transport in WebAssembly). It turns out that the wasm-ext implementation makes it more prone to yield a Pending on a poll_next (see this). When used in conjunction with Noise, a frame may get buffered and only written to the underlying I/O stream when flushing it (see this)
In https://github.com/libp2p/rust-yamux/pull/112, flushing is no longer awaited, but instead, is called at each iteration of the next loop in Connection (see this). Unfortunately, when using wasm-ext with Noise, frames may never get written until the next iteration is triggered by another event (incoming frame or stream/control events).
As discussed in libp2p's issue, a fix is to make sure that flushing the I/O stream gets progressed in the main loop. I also think that flush_nowait is not required anymore since flushing is now actively done in the loop.

@mxinden Updated. I don't know if you had something else in mind, but it does the trick.


Add HTML input support

For HTML processing as in https://github.com/programmieraffe/oerhoernchen20 (with sources configured as in https://github.com/programmieraffe/oerhoernchen20/blob/master/scrapy/projects.json), we need an HtmlReader, to be used between HttpOpener and XmlDecoder (parsing HTML to XML, e.g. with https://jsoup.org/) in a workflow to create JSON index data for https://github.com/orgs/hbz/projects/4.

Implemented new HtmlDecoder described above, the basic approach seems to work, deployed to http://test.lobid.org/fix:
Data: (Full, unmodified) source of https://www.hoou.de/materials/tutorial-lernen-lernen
Flux: decode-html|fix|encode-json(prettyPrinting="true")
Fix:
map(html.head.title.value,title)
map(html.body.div.div.div.div.div.div.div.p.value, description)

Output:
{
  "title" : "Tutorial: Lernen lernen - HOOU",
  "description" : "Das Bewusstsein und die Kenntnis ..."
 For these, I think we should continue with support for full Flux workflows in the UI (https://github.com/metafacture/metafacture-fix/issues/6) and conditionals in Fix (https://github.com/metafacture/metafacture-fix/issues/10). @acka47, you might still want to play around with this a little already (use map(_else) as Fix to see the full field structure).

https://github.com/metafacture/metafacture-fix/issues/6 is closed and https://github.com/metafacture/metafacture-core/pull/313 is merged, closing.


feat: fixed for the issue (#373)

1. Description

1.1. Checklist

[ ] The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
[ ] I have read the Contributor Guide and followed the process outlined for submitting PRs.
[ ] I have updated/added tests for ALL new/updated/fixed functionality.
[ ] I have updated/added relevant documentation in docs and added dartdoc comments with ///.
[ ] I have updated/added relevant examples in examples.

1.2. Breaking Change

[ ] Yes, this is a breaking change.
[ ] No, this is not a breaking change.

1.3. Related Issues

Codecov Report

Merging #374 (608723e) into main (bbdaf12) will increase coverage by 13.36%.
The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@             Coverage Diff             @@
##             main     #374       +/-   ##
===========================================
+ Coverage   70.55%   83.92%   +13.36%
===========================================
  Files         136        6      -130
  Lines        1233      112     -1121
===========================================
- Hits          870       94      -776
+ Misses        363       18      -345

see 130 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


chore: fix docs path

What ❔
fix docs path
Why ❔

Checklist

[x] PR title corresponds to the body of PR (we generate changelog entries from PRs).
[x] Tests for the changes have been added / updated.
[x] Documentation comments have been added / updated.
[x] Code has been formatted via zk fmt and zk lint.
[x] Spellcheck has been run via cargo spellcheck --cfg=./spellcheck/era.cfg --code 1.

please, resolve merge conflicts


disabled autoplay but it's start after first slide

Hi,
Is it intended, even if I have autoPlay set to false, that carousel run through all slides after I manually change slide once?
My carousel code:
<Carousel
  width={width}
  height={200}
  loop={false}
  mode="parallax"
  autoPlay={false}
  modeConfig={{
    parallaxScrollingScale: 0.96,
    parallaxScrollingOffset: 18,
  }}
  onProgressChange={(_: any, absoluteProgress: number) =>
    (progressValue.value = absoluteProgress)
  }
  data={JSON.parse(JSON.stringify(profileAbilities))}
  renderItem={({item}: {item: ProfilePlayerAbility}) => (
    <Block key={item.category}>
      <ProfileAbilityCategory {...{item}} />
    </Block>
  )}
/>

Ok let me a look

Same here. It doesn't happen when I downgrade to 2.1.2

Just found out that the automatic sliding will stop when you touch the currently snapped item.

Just found out that the automatic sliding will stop when you touch the currently snapped item.

Yes, that's our current default logic

Ahh sorry for stating the obvious 😅 Today's my first time using this library and so far I am really enjoying how simple it is to animate. Thank you for your work!

Thank you for using it 😄

Hi,
Is it intended, even if I have autoPlay set to false, that carousel run through all slides after I manually change slide once? My carousel code:
<Carousel
  width={width}
  height={200}
  loop={false}
  mode="parallax"
  autoPlay={false}
  modeConfig={{
    parallaxScrollingScale: 0.96,
    parallaxScrollingOffset: 18,
  }}
  onProgressChange={(_: any, absoluteProgress: number) =>
    (progressValue.value = absoluteProgress)
  }
  data={JSON.parse(JSON.stringify(profileAbilities))}
  renderItem={({item}: {item: ProfilePlayerAbility}) => (
    <Block key={item.category}>
      <ProfileAbilityCategory {...{item}} />
    </Block>
  )}
/>

it may be a bug, I will fix it tomorrow at the latest


Implementing range download

Other changes:

Documenting --download-latest behavior.
Works without --update-db.

XKCD_DICT did not need to be global.
Making it local also made the need to retrieve
from the .json file in each command more obvious.

Also added a check for if a comic number is valid.

Making utility fxn for downloading a single comic.
This will be done multiple times in the range,
so it's convenient to just have a method for it.

Hey @lethargilistic . I noticed that some places have been missed in the README file for documenting the usage of the new range download method. Can you make a PR fixing those?

Noticed that and did that this morning. x3 PR coming in a little bit.


Allow Dragging of Fieldsets Between Nesting Barriers

Suppose I have an Archetype configured so each fieldset is a "widget" (e.g., rich text, image, etc.). Some of those widgets are containers (i.e., they can contain widgets). An example would be a "2 Column" widget that has two properties, each of the same data type as the Archetype widgets (i.e., a nested Archetype).
Would be super useful if those nested widgets could be dragged from inside the grid to outside the grid (i.e., to be siblings of the grid widget), or if the sibling widgets of the grid could be dragged inside of the grid. I often find myself wanting to do this, as sometimes I want to change a layout (e.g., to add or remove columns).
Even better, it would be great if fieldsets that are part of different Archetype data types but that are identical otherwise (e.g., same properties with the same data types) were considered compatible. That way, if I have a "Widgets" data type (i.e., plural) and a "Widget" data type (i.e., singular), I could do this nested dragging the same way as an actual Archetype that has fieldsets with properties that are of the same type.
Let me know if this isn't clear and I can add some screenshots.

Whoa, killer idea! In a different project I used ui-sortable to drag between two containers. This one is likely to only be implemented via a PR since I don't have a direct need for this feature.

There would be a need to have something define what is 'compatible' between two or more fieldsets to avoid allowing the dragging of a fieldset into a non-compatible fieldset (i.e. has no config to support it).
This would probably be opt-in functionality.
It might all 'just work' if we allow the drag/drop of ui-sortable to 'dock' to another fieldset wrapper.

I'll see if I can get this done today. If not, I'll have to leave it to somebody else or tackle it another time. I'll let you know.

This is mostly done, but I'll have to resume another day. Just need to modify it so it will check the target list's config to ensure the fieldset being dropped matches the list of configured fieldsets. You can see the progress here (currently two commits): https://github.com/Nicholas-Westby/Archetype/commits/feature/355-nested-dragging
Here's what it looks like:

One thing I may also want to consider is allowing multiple fieldsets to be open at once so I can drag between sibling fieldsets (e.g., the "grid" and "wrapper" in the above example).

Pull request submitted: https://github.com/imulus/Archetype/pull/356
Some notes:

I decided not to worry about dragging between sibling nested fieldsets for now (e.g., between "Grid" and "Wrapper" in the above image). For my use cases, the ancestor usually is a common place that fieldsets can be dropped
The drop will only occur if the fieldset can be removed from the source Archetype and can be added to the target Archetype.
The drop will only occur if the fieldset is being dropped onto an Archetype that has a configured fieldset that matches the dragged fieldset (matches by the alias/guid of the properties).
As a nice bonus feature, you can now drag between Archetypes on entirely different properties (e.g., between "Main Content" and "Bottom Content" in the above image).
I had to ensure the drag icon is always shown, even when there is only one fieldset (made sense when dragging was restricted to one list, but makes less sense now).

Any chance this will make it in the upcoming version of Archetype? :-)

I'm going to leave comments on the PR itself...

@Nicholas-Westby I belive this issue resolved?

Correct. I'll close.

👍


Title: To add split array problem

Initiative (Required)
Hacktoberfest 2024 🎃
Is your proposal related to a problem? Please describe.
To add code and participate
Add any other context or screenshots about the proposal request here.
No response

@NimraAslamkhan please assign this to me


Silence compinit if ZSH_DISABLE_COMPFIX=true

Potential fix for https://github.com/zplug/zplug/issues/428.
oh-my-zsh uses the same variable to enable a fix for the same problem. By adding ZSH_DISABLE_COMPFIX=true at the top of your .zshrc, you can disable compinit/compaudit warnings (this is desirable if you have multi-user permissions on your zsh and brew directories for example).

Related: zplug#396


refactor(parser): Improve error message when parsing models and envelopes

Issue number: #3580
Summary
Changes
This pull request enhances the error messaging in response to an AttributeError when parsing Models and Envelopes. The improved error message now provides more explicit details, making it easier to identify and address the root cause of the issue.
Before
[ERROR] InvalidEnvelopeError: Envelope must implement BaseEnvelope, envelope=<class 'aws_lambda_powertools.utilities.parser.envelopes.kinesis.KinesisDataStreamEnvelope'>
[ERROR] InvalidEnvelopeError: Envelope must implement BaseEnvelope, envelope=<class 'aws_lambda_powertools.utilities.parser.envelopes.kinesis.KinesisDataStreamEnvelope'>
Traceback (most recent call last):
  File "/var/task/aws_lambda_powertools/middleware_factory/factory.py", line 135, in wrapper
    response = middleware()
  File "/var/task/aws_lambda_powertools/utilities/parser/parser.py", line 98, in event_parser
    parsed_event = parse(event=event, model=model, envelope=envelope)
  File "/var/task/aws_lambda_powertools/utilities/parser/parser.py", line 175, in parse
    raise InvalidEnvelopeError(f"Envelope must implement BaseEnvelope, envelope={envelope}")

After
[ERROR] InvalidEnvelopeError: Error: 'list' object has no attribute 'test'. Please ensure that both the Input model and Envelope inherit from BaseModel,
And your payload adheres to the specified Input model structure.
Envelope=<class 'aws_lambda_powertools.utilities.parser.envelopes.kinesis.KinesisDataStreamEnvelope'>
Model=<class 'app.SuggestionPayload'>
[ERROR] InvalidEnvelopeError: Error: 'list' object has no attribute 'test'. Please ensure that both the Input model and Envelope inherit from BaseModel,
And your payload adheres to the specified Input model structure.
Envelope=<class 'aws_lambda_powertools.utilities.parser.envelopes.kinesis.KinesisDataStreamEnvelope'>
Model=<class 'app.SuggestionPayload'>
Traceback (most recent call last):
  File "/var/task/aws_lambda_powertools/middleware_factory/factory.py", line 135, in wrapper
    response = middleware()
  File "/var/task/aws_lambda_powertools/utilities/parser/parser.py", line 98, in event_parser
    parsed_event = parse(event=event, model=model, envelope=envelope)
  File "/var/task/aws_lambda_powertools/utilities/parser/parser.py", line 175, in parse

User experience

Please share what the user experience looks like before and after this change

Checklist
If your change doesn't seem to apply, please leave them unchecked.

[x] Meet tenets criteria
[x] I have performed a self-review of this change
[x] Changes have been tested
[ ] Changes are documented
[x] PR title follows conventional commit semantics

Is this a breaking change?
RFC issue number:
Checklist:

[ ] Migration process documented
[ ] Implement warnings (if it can live side by side)

Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (9214cb2) 95.78% compared to head (aa24b48) 95.74%.
Report is 2 commits behind head on develop.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3587      +/-   ##
===========================================
- Coverage    95.78%   95.74%   -0.05%
===========================================
  Files          210      210
  Lines         9683     9683
  Branches      1774      813     -961
===========================================
- Hits          9275     9271       -4
- Misses         294      296       +2
- Partials       114      116       +2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


fix: Number type input should honour required property when value is an empty string

Description
In Number type Input, when value is empty, it gets converted to 0. As a result isValid check passes. as part of this commit we made sure that the empty string is handled properly in the isValid check.
Fixes #11438
Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce.
Please also list any relevant details for your test configuration.

Test A
Test B

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/number-type-input-required

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
55.74 (0)
37.08 (0.02)
35.8 (0)
56.1 (0)

:green_circle:
app/client/src/widgets/InputWidgetV2/widget/derived.js
78.72 (0)
77.36 (2.89)
100 (0)
78.72 (0)

/ok-to-test sha=81e3735

/ok-to-test sha=81e3735

/ok-to-test sha=81e3735

/ok-to-test sha=81e3735

/ok-to-test sha=81e3735

/ok-to-test sha=2fc036e

/ok-to-test sha=cbb4867

/ok-to-test sha=cbb4867


Document our enabling of sand duplication

I feel like we should note somewhere that unsupported settings might vanish at any time

I feel like we should note somewhere that unsupported settings might vanish at any time

Sure, not sure if this is the place though. Might require modifying the Config.tsx to allow a "note" on non-leaf nodes


Quality filter does not work with format filter (thumbor)

The following ignores the quality filter when converting to jpg
{domain_name}/filters:format(jpeg)/filters:quality(50)/{key}
Looking at the source code https://github.com/awslabs/serverless-image-handler/blob/master/source/image-handler/thumbor-mapping.js#L173, the quality param is added based on file extension.
My expectation is that it would be added to this.edits.jpeg when format is specified.

@SNagappan Thanks for your feedback.
May I know what the original file format is? As far as I can test, it seems like if the original file format is PNG, than the quality does not work. I'll dig into this issue more.

@beomseoklee It didn't work with png and it also didn't work with jpeg (with no file extension). I haven't tested with other formats but in my use case I need to convert a variety of different formats to jpeg.

@SNagappan, we have updated our solution, the issue has been fixed. If you still see the issue with the latest version (v6.0.0), please feel free to reopen the issue.
You can refer to the recent changes here.


check clean.sh file is exists and add rm /usr/bin/kube* when delete c…

Describe what this PR does / why we need it
strengthen sealer delete process:

skip execute clean.sh if it not exists
merge rm /usr/bin/kubeadm and rm /usr/bin/kubelet to rm /usr/bin/kube* in the RemoteCleanMasterOrNode.  This will also  delete /usr/bin/kubectl .

Does this pull request fix one issue?
Fixes #1050 Fixes #1072

Describe how you did it
Describe how to verify it
sealer delete --all
Special notes for reviews

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zhuguangming seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@bxy4543


Fix: add the font family icomoon on icon story

Closes
Issue-181

Bugfix

Description
The component iconfont doesn't show the icon in laddle.

Cause
The laddle force the font of the base.css and doesn't allow to use the font of the component iconfont

Solution
Force the icomoon font on the style in div tag

Visual evidences :framed_picture:

![evidencia](https://github.com/hatcoders/octopost/assets/90076846/74784d49-c2a4-44f4-8f69-ebe8ccb90dc2)

Checklist

[x] Issue linked
[x] Build working correctly
[ ] Tests created

Additional info

N/A

Ah boa, forcando inlinement funciona? valeu a dica


write test of Go software

@avelino please assign me this issue. I want to start working on it immediately.

@avelino please assign me this issue. I want to start working on it immediately.

@deepbeatz waiting for your contribution


Some bad hyperlinks in the spec

For instance, in Section 2.2 Mapping Graphs and the RML Vocabulary, there are a bunch of links to the spec and not a specific source. Specific nodes cannot be found in the spec either (e.g., Logical Source).

@dachafra I can have a look if things are published, it is hard to keep track of all the branches going around.

ok, let's then add the label pending here until the next version will be ready

I fixed a bunch in my last pull request, but there are still many links that should be definition references. Still WIP

This will be done after all updates and contributions are merged into the spec


[bug?] cannot get live query features from feature_id

present as of a000337353aa06d6a5dffe75b11d87792ccf1926
This might be a design pattern for all live queries, but it is nonetheless an issue with implementing it on api/explorer
user story:

on explorer, user navigate to hoc1 left, saw BigBrainIntensityProfile instance
user clicks feature, a new panel opens, showing user the detail of the instance

this panel, ideally, should only take feature id as an input, and should not need other context to get the live query instance.
api currently leverages the .get_instances()  method and exact string matches with each of the feature id. This fails for live queries, since it will always return empty list.
possible remedy
for live queries, we encode how to retrieve the context in id, e.g.
{
  "id": "livequery/BigBrainIntensityProfile/p/minds/core/parcellationatlas_v1.0.0_94c1125b-b87e-45e4-901c-00daee7f2579-290/r/hoc1left/{feature_id}"
}

whilst this is verbose, we can implement class method on LayerwiseBigBrainIntensityQuery, which can correct repopulate the context necessary to retrieve the instance

Should be implemented on the level of Feature, where get_instances is implemented.


Exposes Brave.clock

This exposes Brave.clock so that it can be used to record timestamps
out-of-band.

as requested by @devinsba


Code OSS build tslint rules extension (and add tslint-eslint-rules and unified rules file)

I would like to extend the tslint.json rules file for building VCS
the goal would be to cover all of the formatting required
by hygiene and the TS formatter.
I killed a lot of time chasing formatting issues before realizing
Format would silently fix the errors(newbie mistake)
it would still be nice to see the errors in real time
Several  additions to the configuration file would pick up a few more things

I could not get all rules from tslint
we could add tslint-eslint-rules package and pick up most missing rules
while keeping one file of rules
using two extensions and two configuration files seems inefficient
I do see a new eslintrc file not sure where it's used
I tested the above package and have almost all the currently
missing rules doing real-time lint

I will do a PR if interested
Christopher
https://www.npmjs.com/package/tslint-eslint-rules
{
"extends": [
"tslint-eslint-rules"
],
"rules": {
"no-unused-expression": true,
"no-duplicate-variable": true,
"no-unused-variable": true,
"curly": true,
"class-name": true,
"semicolon": [
"always"
],
"triple-equals": true,
"whitespace": [
true,
"check-operator",
"check-separator",
"check-module",
"check-branch"
],
"no-debugger": true,
"object-curly-spacing": [
"error", "always"
],
"no-extra-semi": "warn",
"no-unexternalized-strings": [
true,
{
"signatures": [
"localize",
"nls.localize"
],
"keyIndex": 0,
"messageIndex": 1
}
],
"layering": [
true,
{
"common": [],
"node": [
"common"
],
"browser": [
"common"
],
"electron-main": [
"common",
"node"
],
"electron-browser": [
"common",
"browser",
"node"
]
}
],
"import-patterns": [
true,
{
"target": "/{node,electron-browser,electron-main,extensions}/",
"restrictions": "/*"
},
{
"target": "{/.test.ts,/test/}",
"restrictions": "{/vs/,assert,sinon}"
},
{
"target": "/{common,browser,workbench}/",
"restrictions": "/vs/**"
}
],
"duplicate-imports": true,
"allow-async": [
true,
[
"node",
"electron-main",
"electron-browser",
"extensions"
]
]
}
}

@cleidigh thanks for you analysis.
Since any rule change affects the entire team our approach is to get consensus from the entire team before we make a rule change.

I killed a lot of time chasing formatting issues before realizing
Format would silently fix the errors(newbie mistake)
it would still be nice to see the errors in real time

Showing formatting errors as you type results in a nervous coding experience, for this reason we have decided to not enable linting rules for formatting errors. In particular some team members have formatOnSave enabled and for them these warnings would be annoying. So our position was to not try to standardize on all this, but to only require that on commit the format has to be consistent.
From your comment above it is not immediately obvious what other changes besides whitespace are you suggesting?

@egamma
Thanks for commenting (sorry for my slow response)
I think your comment about over linting makes total sense.
as I said above before I realized the format command would save many headaches
it was problematic that hygiene/the formater would fail without any line number indications
I guess the main question I have (perhaps a stupid question) will the formatter
always fix its requirements for VSC coding requirements?
it would still be nice to know the formatting errors to know how to code correctly in the first place
there are several rules that are opaque since they are not in lint and the formatter
does not flag them specifically. Anyway to get that?
Thanks

@cleidigh

I guess the main question I have (perhaps a stupid question) will the formatter
always fix its requirements for VSC coding requirements?

Fair question, yes this is our goal.

it would still be nice to know the formatting errors to know how to code correctly in the first place

Does running tsfmt manually cover this?
node_modules\.bin\tsfmt --verbose --verify src\vs\base\browser\browser.ts

@egamma
Unfortunately tried that already by adding --verbose to the hygiene script...
Turns out that tsfmt is verbose everywhere but it needs to be ;-(
I dropped the space after the Brace in an import statement  import {Events } ...
A { rule required by TS format but not picked up by tslint as an example.
here's the TS format output - a super helpful " x file is not formatted"

What do you think about using the combined tslint-eslint-rules if both are used?
I realize this is a minor issue but it would allow all of the rules to show up in VSC
with just tslint but gaining any rules required from eslint.

I ran into a similar problem - I hadn't inserted a space between if and the following parenthesis and tsfmt wasn't being helpful at all.
Unfortunately, tsfmt doesn't seem to respect the 'replace' flag, so I overwrote the file whenever it detected an error, like so:
// in build/gulpfile.hygiene.ts
const formatting = es.map(function (file, cb) {
	tsfmt.processString(file.path, file.contents.toString('utf8'), {
		verify: true,
		tsfmt: true,
		// replace: true, <-- this doesn't work
	}).then(result => {
		if (result.error) {
			console.error(result.message);
			errorCount++;
			// write out fixed file contents
			fs.writeFileSync(`${file.path}.new`, result.dest, 'utf8');
		}
		cb(null, file);
	});
});

The hygiene file can be run from the command line via npm run precommit.

@egamma
Closing this for the November cleanup.
New rules basically cover this...

@cleidigh thanks for the issue grooming support!