Avoid unchecked arithmetic overflow / underflow

The following arithmetic operations may result in unchecked overflow, resulting in different behavior in debug vs release compilation mode. For each of these, the desired resolution is likely (a) the overflow should wrap around, and this should be made explicit and made to happen in both debug and release mode, or (b) overflow is deemed to be impossible for all inputs, and should result in a panic with an informative error message. However, other resolutions are possible and these must be considered on a case by case basis.

In machine/src/core.rs:
a. In the implementation of Add:add for Word<u8>, on line 57
b. In the implementation of Sub::sub for Word<u8>, on line 67
In alu_u32/src/add/mod.rs:
a. In the implementation of Add32Chip::op_to_row:
i. The addition on line 108
ii. The first addition on line 109
iii. The second addition on line 109
iv. The first addition on line 113
v. The second addition on line 113
b. In the implementation of Instruction<M>::execute for Add32Instruction:
i. The addition on line 141 (computing read_addr_1)
ii. The addition on line 142 (computing write_addr_1)
iii. The addition on line 149 (computing read_addr_2)
iv. The addition on line 153 (computing a)
In cpu/src/lib.rs:
a. In Instruction<M>::execute for ReadAdviceInstruction:
i. The two additions on line 410
ii. The multiplication on line 410
b. In Instruction<M>::execute for WriteAdviceInstruction:
i. The first and second additions on line 436 (i.e., fp + mem_addr)
ii. The third addition on line 436 (i.e., (fp + mem_addr) + mem_buf_len)
c. In Instruction<M>::execute for Load32Instruction:
i. The addition on line 470 (computing read_addr_1)
ii. The addition on line 472 (computing write_addr)
d. In Instruction<M>::execute for Store32Instruction:
i. The addition on line 491 (computing read_addr)
ii. The addition on line 492 (computing write_addr)
e. In Instruction<M>::execute for JalInstruction:
i. The addition on line 512 (computing write_addr)
ii. The addition on line 513 (computing next_pc)
ii. The addition on line 518
f. In Instruction<M>::execute for JalvInstruction:
i. The addition on line 536 (computing write_addr)
ii. The addition on line 537 (computing next_pc)
iii. The addition on line 540 (computing read_addr)
iv. The addition on line 543 (computing read_addr)
v. The additive assignment on line 545
g. In Instruction<M>::execute for BeqInstruction:
i. The addition on line 562 (computing read_addr_1)
ii. The addition on line 570 (computing read_addr_2)
iii. The addition on line 576
h. In Instruction<M>::execute for BneInstruction:
i. The addition on line 594 (computing read_addr_1)
ii. The addition on line 602 (computing read_addr_2)
iii. The addition on line 608
i. In Instruction<M>::execute for Imm32Instruction:
i. The addition on line 624 (computing write_addr)
j. Every instance of state.cpu_mut().pc += 1;
k. In impl CpuChip:
i. On line 655 and 660, self.pc += 1;
ii. On line 668, self.clock += 1;
In alu_u32/src/bitwise/mod.rs:
a. In Instruction<M>::execute for Xor32Instruction:
i. The addition on line 145 (computing read_addr_1)
ii. The addition on line 146 (computing write_addr)
iii. The addition on line 153 (computing read_addr_2)
b. In Instruction<M>::execute for And32Instruction:
i. The addition on line 181 (computing read_addr_1)
ii. The addition on line 182 (computing write_addr)
iii. The addition on line 190 (computing read_addr_2)
c. In Instruction<M>::execute for Or32Instruction:
i. The addition on line 217 (computing read_addr_1)
ii. The addition on line 218 (computing write_addr)
iii. The addition on line 225 (computing read_addr_2)
In alu_u32/src/div/mod.rs, in Instruction<M>::execute for Div32Instruction:
a. The addition on line 77 (computing read_addr_1)
b. The addition on line 78 (computing write_addr)
c. The addition on line 85 (computing read_addr_2)
In alu_u32/src/lt/mod.rs, in Instruction<M>::execute for Lt32Instruction:
a. The addition on line 128 (computing read_addr_1)
b. The addition on line 129 (computing write_addr)
c. The addition on line 136 (computing read_addr_2)
In alu_u32/src/mul/mod.rs, in Instruction::execute for Mul32Instruction:
a. The addition on line 123 (computing read_addr_1)
b. The addition on line 124 (computing write_addr)
c. The addition on line 131 (computing read_addr_2)
d. The multiplication on line 135 (computing a)
In alu_u32/src/shift/mod.rs:
a. In Instruction<M>::execute for Shl32Instruction:
i. The addition on line 172 (computing read_addr_1)
ii. The addition on line 172 (computing write_addr)
iii. The addition on line 180 (computing read_addr_2)
b. In Instruction<M>::execute for Shr32Instruction:
i. The addition on line 216 (computing read_addr_1)
ii. The addition on line 217 (computing write_addr)
iii. The addition on line 224 (computing read_addr_2)
In alu_u32/src/sub/mod.rs, in Instruction<M>::execute for Sub32Instruction:
a. The addition on line 137 (computing read_addr_1)
b. The addition on line 138 (computing write_addr)
c. The addition on line 145 (computing read_addr_2)
d. The subtraction on line 149 (computing a)
In native_field/src/lib.rs:
a. In Instruction<M>::execute for AddInstruction:
i. The addition on line 157 (computing read_addr_1)
ii. The addition on line 158 (computing write_addr)
iii. The addition on line 165 (computing read_addr_2)
b. In Instruction<M>::execute for SubInstruction:
i. The addition on line 197 (computing read_addr_1)
ii. The addition on line 198 (computing write_addr)
iii. The addition on line 205 (computing read_addr_2)
c. In Instruction<M>::execute for MulInstruction:
i. The addition on line 237 (computing read_addr_1)
ii. The addition on line 238 (computing write_addr)
iii. The addition on line 245 (computing read_addr_2)
In output/src/lib.rs:
a. In Chip<M>::generate_trace for OutputChip:
i. The subtraction on line 66 (computing cols.diff)
b. In Instruction<M>::execute for WriteInstruction:
i. The addition on line 149 (computing read_addr_1)

@morganthomas let me know if this is this approach works.
Also I'd like to take this issue


Metrics prefix fix

Only default GRAPHITE_PREFIX to 'test' if the env is undefined.
Production uses an empty string as the prefix and shouldn't default to 'test'.
(Hopefully this PR won't show commits back to May...)

Looks good


New modifer to make member only visisble to a specific class and/or package

(This is rather difficult to search for so apologies in advance for duplicates.)
TS lacks Java-like inner classes or package-scoped visibility which makes it cumbersome to encapsulate parent-children object relationship where the child needs to manipulate parent's internal datastructure. This is not only common in many complicated object graphs but also in OO designs where an object wants to issue a limited "handle"-like object that only implements a specific subset of features.
Currently the use cases above can only be implemented by exposing the internal datasturectures to the "child" or handing out loads of lambdas. This adds more tight coupling.
An good example is the API to remove of an Element in the DOM. Currently one have to call parent.removeChild(child) which is not only clumsy but also makes it difficult for the child to impose additional logic on the removal. Ideally, we'd want to have a remove() method on the child (like in jQuery) and make the Node.removeChild() method only visible to Node implementors.
Proposed solution:
Create a pseudo- or built-in decorator that accepts a list of types. Members decorated with this can only be accessed by types listed. Alternatively, can extend the private keyword to accept an argument list like private (to A, B) name:type...

May be just a keyword internal just like c#. In typescript, internal can be simply assume as "in the same or child directory".
For example:
(root)
    /tablepanel
        /Body.ts
        /Header.ts
        /index.ts
    /button
        /Button.ts

If a class Body is defined in Body.ts:
internal class Body {

}

Header.ts and index.ts under the tablepanel directory can visit the Body class very well.
But in Button.ts under the button directory, the visit is forbidden and will raise an error.
Just a naive idea, need a disscussion here.

There are already plenty of options for encapsulation (namespaces, modules, class expressions, private, protected, explicit closures, symbols, weakmaps, etc...) and not enough compelling use cases where you'd absolutely need something more complex than what's already available.


Update requirements.txt to add onnxruntime-gpu

Describe your changes
Added onnxruntime-gpu to requirements.txt since it was not included before and caused an error
Checklist before requesting a review

[ ] Add unit tests for this change.
[ ] Make sure all tests can pass.
[ ] Update documents if necessary.
[ ] Lint and apply fixes to your code by running lintrunner -a
[ ] Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
[ ] Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

The linter enforce the packages are ordered with alphabetical. Please insert the onnxruntime-gpu after onnxruntime-externsions

datasets
neural-compressor>=2.4.1
onnxruntime-extensions
onnxruntime-gpu
# optimum 1.17.0 for fp16 inference
optimum>=1.17.0

I'm okay with this change for now, but ideally onnxruntime is the dependency of Olive rather this example. User should install onnxruntime or run --setup to install it. The script of this example doesn't have that step.

/azp run


Add support for last observed value

Why
Fixes #119

The problem is, for example, you could be viewing the last hour of data, but the last point in SiteWise was ingested 1.5 hours ago and a line chart would show there is essentially no data. Depending on the sampling rate, this could be an incorrect assumption, as maybe the sampling rate is every 5 hours and the data point from 1.5 hours ago is still a valid measurement.

What
Adds fallback when the original query returns an empty result.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: toddtreece:x: ryantxuYou have signed the CLA already but the status is still pending? Let us recheck it.

This looks like it is working for "Get interpolated property values" -- but not regular property values.  If that is expected, we should just hide it in the UI.
The other weird part is that the we are showing timestamps when nothing is found... this causes odd zoom suggestions!

@ryantxu i think this is ready for another look

Looks like the value is fetched by has an error:

I pulled, and now fixed!


pg_catalog - SELECT on pg_proc returns only a subset for a user with only DQL on

CrateDB version:
4.5.1
Environment description:
local / tarball

Problem description:
For users with limited privileges (e.g. only on a specific schema and pg_catalog), CrateDB only returns a subset of all records for pg_proc. Only granting DQL on all schemas allows access to all records. This leads to a problem with PowerBI, as one of the intial queries fails (see https://community.crate.io/t/powerbi-desktop-npgsql-error/722/4 )

no privileges
-- with user crate
CONNECT OK
cr> CREATE USER testuser WITH (password='testuser');
CREATE OK, 1 row affected  (0.161 sec)

user with non privileges:
-- with user testuser
cr> SELECT * FROM pg_proc;
SchemaUnknownException[Schema 'pg_catalog' unknown]

DQL on pg_catalog
-- with user crate
cr> GRANT DQL on SCHEMA pg_catalog TO testuser;
GRANT OK, 1 row affected  (0.088 sec)

user with non privileges:
-- with user testuser
cr> SELECT COUNT(*) FROM pg_proc;
+----------+
| count(*) |
+----------+
|       24 |
+----------+
SELECT 1 row in set (0.001 sec)

DQL on all schemas
-- with user crate
cr> GRANT DQL TO testuser;
GRANT OK, 1 row affected  (0.088 sec)

user with DQL privileges on all schemas
-- with user testuser
cr> SELECT COUNT(*) FROM pg_proc;
+----------+
| count(*) |
+----------+
|      544 |
+----------+
SELECT 1 row in set (0.001 sec)

Steps to reproduce:

This might be fixed with https://github.com/crate/crate/commit/760b4054d6e406f1f0668f294693d123b9ba1835 @jeeminso

Just tried it with the nightly 4.6 docker image, and the SELECT on pg_proc returns the full table, so basically this can be closed, unless we plan to backport it to 4.5.x

This might be fixed with 760b405 @jeeminso

Yes, just to confirm, it is fixed by the change mentioned.


Multiple SSH Prompts

Type: Bug
When first opening VS Code, not having authenticated to SSH yet;
A workspace with multiple [git repo] folders generates a prompt to unlock the SSH key (to sync the git repos). Even if I type the password correctly, I will be prompted again for each subsequent folder for the same key.
Further, if I mistyped the password, I won't know until after the last folder. Then I will be prompted to unlock a fallback key once for every folder.
Sometimes the process may go a second round, requiring additional attempts or escapes if I am sure one of the entries was correct.
Upon VSCode initial start, each repo sync should be initiated one at a time, so the password entered for the first repo will unlock the key for the rest. This reduces prompts for mistyped passwords, secondary keys, etc.
VS Code version: Code 1.70.2 (e4503b30fc78200f846c62cf8091b76ff5547662, 2022-08-16T05:36:25.715Z)
OS version: Linux x64 5.15.0-46-generic
Modes:

@Blfrg, apologies for not getting back to you on this issue until now.  Are you able to reproduce the same behaviour if you start VS Code using code --disable-extensions as I would like to rule out any extension trying to do a sync when a repository is discovered. Also, I was wondering whether you have considered adding the SSH to ssh-agent so that you do not have to enter the passphrase for every git operation that connects to the remote?

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Add nuget package for core files

Would be nice to have a nuget package for just the core dlls.

I agree, could use that right now. I have a Core project where the Controllers are situated and need a reference for the type DocTypeGridEditorSurfaceController.

So did this happen? Or...?

No, with the coming release of the Block Editor, my expectation is that DTGE will be obsolete, and I don't want to invest the time in adding this then :)
Happy to merge a PR :)

Just curious what the reason was for closing this :-) Because I didn't see any comment I didn't know why it was closed.
You mention the coming release of the Block Editor, do you have a source which states the release will be soon? Because AFAIK they didn't start building yet:
From: https://github.com/umbraco/rfcs/pull/12#issuecomment-527046806
"we'll let you know once we start POC work and implementation."
And then nothing is mentioned about this POC ;-)

Coming up in 8.7:  https://umbraco.com/blog/product-update-may-29th-2020/
My guess would be that the grid is not part of the first iteration, but the
block editor should enable you to do your own "block editor", and then also
a grid like editor. Which I might do :)
Den fre. 5. jun. 2020 kl. 09.31 skrev Stefan Kip<EMAIL_ADDRESS>
Just curious what the reason was for closing this :-) Because I didn't see
any comment I didn't know why it was closed.
You mention the coming release of the Block Editor, do you have a source
which states the release will be soon? Because AFAIK they didn't start
building yet:
From: umbraco/rfcs#12 (comment)
https://github.com/umbraco/rfcs/pull/12#issuecomment-527046806
"we'll let you know once we start POC work and implementation."
And then nothing is mentioned about this POC ;-)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/skttl/umbraco-doc-type-grid-editor/issues/135#issuecomment-639309721,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA4NZA5EYK6CQC4LHMVCBQDRVCNLNANCNFSM4GXVUZWA
.

Check, didn't notice the blog post yet, thanks :-)


Data aggregation for multiple logins

Combine data from all endpoints.
Ensure the display is accurate.
Make sure we have one design that works in both apps. Coordinate with @drdavec and @svalluripalli
Sequence of cards:
#214
#217
#215
#240

why is the repo empty ? :0

why is the repo empty ? :0

Not sure what you mean? It's not empty, were you looking to contribute? I'm sure one of us can guide you.

@Dave Carlson
for data aggregation we have a note to complete in this order:
aggregate the data within the app
process each provider data set using CQL and then display the aggregated CQL results
I'm wondering why we cannot/should not complete in this order:
Process data with CQL from 1st provider
Process data with CQL from 2nd provider
Aggregate data
Display
Also, FYI, update in dev allows selection of one or more providers. At this time I have disabled more than one until aggregation is implemented
Are we intending to support the aggregation of two different patients? For example, in testing, all of our providers have different patients. In the real world, if they are 2 different people, what should we do?
3 options for data aggregation and a couple of alternatives:
1: Create arrays of all of our major data items (fhirData, patientSummary, etc.) so we will have something like [fhirData1, fhirData2, fhireData3] and then update all display code (and edit code) to work with this new system
2: Update the actual interfaces have an array value for each property and have one huge version of each major data item. So, fhirData won't be an array, but, it will have a bunch of properties that are all arrays or arrays of arrays. Won't require as much display code change, but will require a lot of logic changes due to the interfaces changing.
3: Convert and display on the fly in an adhoc manner (don't really like this idea from a maintenance perspective and would need a new combined interface)
X: Any combination of prior but editing CQL instead of data after CQL is run
I think item 1 or maybe item X combined with the style of 1 are the only feasible options from a maintainability and from a perspective of breaking the least amount of (important) stuff/less regression needed. All are complex (require widespread changes). However, feel free to chime in, hence why I'm throwing this out there.
X2: There is also the option of (or in addition) to turn fhirData, etc, into classes vs interfaces and adding methods for dynamic manipulation. I'm not so sure how relevant this is though, when having separate instances in an array. It depends on the complexity of the data. For instance, is it enough to simply have one set of data follow another in the display, or does it get more complex than that? If so, may need to consider a class along with option 2 or some other complex setup (e.g. instead of arrays for all properties we have more complex objects within them). We could also only have that type of situation where needed and update the interface as such.

Dan is working on aggregating summary data (not FHIR data) into 2D array. Then work on displaying one in a summary. Others can be delegated using the summary dan does as a model.
Work on in parallel: The view for aggregated raw FHIR data can be displayed (the data that does not need to go through CQL). "FHIR data collection"- write display code to display it.


Uncaught TypeError: SUNEDITOR.create is not a function

To make it easier for us to help you, please include as much useful information as possible.
Version
Write the version of the Editor you are currently using.
"suneditor": "^2.41.3",
"next": "11.0.1",
"react": "17.0.2",
Additional context
Add any other context about the problem here.
import React, { useRef, useEffect } from 'react';
import dynamic from 'next/dynamic';
import 'suneditor/dist/css/suneditor.min.css'; // Import Sun Editor's CSS File
const SUNEDITOR = dynamic(import('suneditor'), { ssr: false });
const plugins = dynamic(import('suneditor/src/plugins'), { ssr: false });

const MyComponent = (props) => {
  const editorRef = useRef(null);
  const inputRef = useRef(null);

  useEffect(() => {
    editorRef.current = SUNEDITOR.create(inputRef.current, {
      plugins: plugins,
    });
  }, []);
  return (
    <div>
      <textarea
        ref={inputRef}
        defaultValue="yahoo"
        style={{ display: 'none' }}
      ></textarea>
    </div>
  );
};
export default MyComponent;

Ok I get it now. You just have to import them inside the useEffect hook like this
useEffect(() => {
   const SUNEDITOR = require('suneditor').default;
  const plugins = require('suneditor/src/plugins').default;
  // use them here
},[])

@ilbrigz Thank you.
Please do not delete this issue.
I'll put together some helpful issues and put them together.

Am getting this error
"core._resourcesStateChange is not a function"
"version": "2.42.0",
"suneditor-react": {
"version": "3.4.0",


fails to build Android with React Native 0.72.0

Hi, I created a new vanilla project with react native 0.71.11 and added "@hmscore/react-native-hms-map"
Everything worked well.
However, after upgrading to React Native 0.72.0, the build fails on android and throw the following error
FAILURE: Build failed with an exception.

What went wrong:
A problem occurred configuring project ':app'.

Failed to notify project evaluation listener.
Could not create task ':app:transformClassesWithAPMSPluginForDebug'.
Cannot use @TaskAction annotation on method IncrementalTransformTask.transform() because interface org.gradle.api.tasks.incremental.IncrementalTaskInputs is not a valid parameter to an action method.
com.android.tools.build:gradle is no set in the build.gradle file

I also followed the given example from react-native-hms-map repo, still having this issues.
I suppose this isn't library bug but rather an issue with the new build system in general ?
here my full source code https://github.com/dhanazam/huaweiRN
thanks

Facing the same on this side, but that's using any of the HMS packages.
0.72.0 introduces the following change that triggers this
classpath("com.android.tools.build:gradle")

Hi, this is affecting us too. I cannot see any reasonable workaround as the AGCP plugin doesn't seem to be open source. We are probably gonna stop providing new updates for AppGallery users.

Has anyone found a solution to this?

I manage to build successfully with rn 0.72.5.
package.json
"@hmscore/react-native-hms-push": "^6.10.0-300",
In root/gradle, I use this version
classpath("com.android.tools.build:gradle:7.4.1")
classpath("com.huawei.agconnect:agcp:<IP_ADDRESS>1")

I tried with ads and location and its not working. It's critical for us to find solution for that or we will have to stop updating app inside huawei store.
We use this 2 packages, already updated to the newest version:
        "@hmscore/react-native-hms-ads": "^13.4.65-300",
        "@hmscore/react-native-hms-location": "^6.11.0-301",

I've tried add version to classpath("com.android.tools.build:gradle:7.4.1")
I've also tried with different agconnect versions but with no success:
classpath "com.huawei.agconnect:agcp:<IP_ADDRESS>1"
(tried <IP_ADDRESS>0, <IP_ADDRESS>0, with <IP_ADDRESS>0 it go further with diff errors, but i guess its super old)

Finally after checking out this location integration example - which would nevertheless be nice to update based on the new app from create-app...  I found mix that is building with success on our project:

I've updated push plugin from: <IP_ADDRESS>0 to <IP_ADDRESS>0 iside android/app/build.gradle:
implementation "com.huawei.hms:push:<IP_ADDRESS>0"

In android/build.gradle I set gradle version and used <IP_ADDRESS>1 for agconnect:

buildscript {
    ext {
        buildToolsVersion = "33.0.0"
        kotlinVersion = '1.6.21'
        minSdkVersion = 23
        compileSdkVersion = 33
        targetSdkVersion = 33
        excludeAppGlideModule = true
        ndkVersion = "23.1.7779620"
    }
    repositories {
        google()
        jcenter()
        mavenCentral()
        maven { url 'https://developer.huawei.com/repo/' }
    }
    dependencies {
        classpath("com.android.tools.build:gradle:7.4.1")
        classpath("com.facebook.react:react-native-gradle-plugin")
        classpath 'com.google.gms:google-services:4.3.15'
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion"
        classpath "com.huawei.agconnect:agcp:<IP_ADDRESS>1"
    }
}

allprojects {
    repositories {
        maven { url 'https://developer.huawei.com/repo/' }
    }
}

In android/gradle/wrapper/gradle-wrapper.properties I changed version from:
distributionUrl=https\://services.gradle.org/distributions/gradle-8.0.1-all.zip
to
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-bin.zip

package.json:
"@hmscore/react-native-hms-ads": "^13.4.65-300",
"@hmscore/react-native-hms-location": "^6.12.0-300",
"react-native": "0.72.6",

Finally after checking out this location integration example - which would nevertheless be nice to update based on the new app from create-app... I found mix that is building with success on our project:

I've updated push plugin from: <IP_ADDRESS>0 to <IP_ADDRESS>0 iside android/app/build.gradle:
implementation "com.huawei.hms:push:<IP_ADDRESS>0"
In android/build.gradle I set gradle version and used <IP_ADDRESS>1 for agconnect:

buildscript {
    ext {
        buildToolsVersion = "33.0.0"
        kotlinVersion = '1.6.21'
        minSdkVersion = 23
        compileSdkVersion = 33
        targetSdkVersion = 33
        excludeAppGlideModule = true
        ndkVersion = "23.1.7779620"
    }
    repositories {
        google()
        jcenter()
        mavenCentral()
        maven { url 'https://developer.huawei.com/repo/' }
    }
    dependencies {
        classpath("com.android.tools.build:gradle:7.4.1")
        classpath("com.facebook.react:react-native-gradle-plugin")
        classpath 'com.google.gms:google-services:4.3.15'
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion"
        classpath "com.huawei.agconnect:agcp:<IP_ADDRESS>1"
    }
}

allprojects {
    repositories {
        maven { url 'https://developer.huawei.com/repo/' }
    }
}

In android/gradle/wrapper/gradle-wrapper.properties I changed version from:
distributionUrl=https\://services.gradle.org/distributions/gradle-8.0.1-all.zip
to
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-bin.zip

package.json: "@hmscore/react-native-hms-ads": "^13.4.65-300", "@hmscore/react-native-hms-location": "^6.12.0-300", "react-native": "0.72.6",

Thanks for your response. Could you please tell me, what JDK version are you using?

@bserrano27
jdk 11, recommended for rn 0.72.6 in docs

i have the  same issue :(


Masque Preset issue

Addon Version
v0.19
World of Warcraft Version
Retail
Describe the bug
i've been testing masque presets and chose Hex AmtoftEU Rotated.
but the quest items have not been masked properly. you can see 2 masks at once.
Steps to reproduce
testing different masque presets

pic
https://ibb.co/8j3d7bg


fix: representation and service user functions query errors

Describe your changes
Ticket: https://pins-ds.atlassian.net/browse/ASB-2184
PR addresses service-user and representation functions triggering at the same time and causing schema query errors. It uses SQL merge query which is atomic and bypasses the problems that were occurring in transactions.
Type of change 🧩

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[ ] Other (please explain in the description section above)

Checklist before requesting a review

[x] I have performed a self-review of my own code
[x] I have double checked this work does not include any hardcoded secrets or passwords
[x] I have made corresponding changes to the documentation
[x] I have provided details on how I have tested my code
[x] I have referenced the ticket number above
[x] I have provided a description of the ticket
[x] I have included unit tests to cover any testable code changes

:tada: This PR is included in version 1.7.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.17.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:

:tada: This PR is included in version 2.22.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Reduced infrastructure management

Aspect
Description

Challenges
If most services are phased over to a cloud Infrastructure or Platform as a service solution, it removes local needs for hardware management. However contractual arrangements and exit strategies from providers become much more important to avoid vendor lock-in. Cost may become more dynamic and part of running budget rather than single capital investment items in IT.

Mitigating strategies and controls
ICES cloud strategy

legacy entry

Likelihood: There is a high likelihood that ICES will see more use of cloud infrastructure in the future
Impact: Having the right competence available for managing cloud infrastrukture


Build tools in alpine images

I have been leaving the build tools (gcc, g++, make, etc.) out of the alpine images to reduce the overall image size, however I find that most of the issues I have that trace back to the image itself have to do with missing build tools and on many projects I end up using the debian based image anyway.
As it has also caused problems for others (#9, #17, #18) I may add those tools back in to the image in the near future and I'm not sure how much it will add to the image (50 - 100MB or so I would guess). Please let me know if anyone has any concerns with that.
@arnested @NewOldMax @VeeeneX

I think it will be almost the same as debian image, although give it a try.

It looks like it adds ~45MB increasing the compressed image size to 116MB.

Done, merged https://github.com/mkenney/docker-npm/pull/53 and https://github.com/mkenney/docker-npm/pull/54


[Bug]Destroying the spark engine does not release the submitted temp files

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the bug
If spark.yarn.submit.waitAppCompletion = false is not configured but kyuubi.session.engine.startup.waitCompletion=false is configured, kyuubi will destroy spark submit in the running state, resulting in temporary files that cannot be released

Affects Version(s)
master/1.7.1
Kyuubi Server Log Output
No response
Kyuubi Engine Log Output
No response
Kyuubi Server Configurations
No response
Kyuubi Engine Configurations
No response
Additional context
No response
Are you willing to submit PR?

[X] Yes. I would be willing to submit a PR with guidance from the Kyuubi community to fix.
[ ] No. I cannot submit a PR at this time.

https://github.com/apache/kyuubi/pull/5066
After testing, I found that there is no shutdown hook that triggers spark submit, but I think it is also a better destroy implementation


LeCroyOscilloscope: WaveSurfer 3000 doesn't like COMBINE_CHANNELS 1

Gives errors in log

Seems there is no manual interleaving option. It's selected based on enabled channels similar to Pico.


Install Size

how much free space is required for the installation? it take considerable amount of time to install

It takes long because I am downloading and building both OpenCV and FFMPEG from source. I am not sure if there is a more elegant way of getting the necessary header files without installing the full libraries.
About the size requirement I can not give you a specific value as I currently have no build of the project. The resulting Docker image should be a few GB, mostly due to the large size of the base image (Ubuntu 18.04). Since I am using multistage builds, the size is already reduced.

Thank you for your response
On Fri, Nov 12, 2021, 4:46 PM Lukas Bommes @.***> wrote:

It takes long because I am downloading and building both OpenCV and FFMPEG
from source. I am not sure if there is a more elegant way of getting the
necessary header files without installing the full libraries.
About the size requirement I can not give you a specific value as I
currently have no build of the project. The resulting Docker image should
be a few GB, mostly due to the large size of the base image (Ubuntu 18.04).
Since I am using multistage builds, the size is already reduced.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/LukasBommes/mv-extractor/issues/5#issuecomment-967171796,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ASEHV6HQRP3RXCSDOE7AMHTULUSEDANCNFSM5H443QNQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


added myself

Thanks for opportunity. Will this count for the hacktoberfest 2020? I am not able to see update on my hactoberfest profile.


fix possible division by zero

Well, the branch title is not pertinent :

fix : possible division by zero in the ribbon uvs computation
simplify extrusion cap computation

I just tried dividing by zero, and it totally failed. 😉


Add vue-icons

General

✏ Mark the necessary items without changing the structure of the PR template.

[x] Pull request template structure not broken

Type

ℹ  What types of changes does your code introduce?

👉 Put an x in the boxes that apply

[ ] Fix
[x] Feature

Checklist

ℹ  Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉  Put an x in the boxes that apply.

[x] Title as described
[x] Make sure you put things in the right category!
[x] Always add your items to the end of a list

Open Source

[x] Link description does not contain a link to an author / third-party resource
[x] The documentation (README) contains a description of the project, illustration of the project with a demo or screenshots and a CONTRIBUTING section
[x] The documentation is in English.
[x] The project is active and maintained.
[x] The project accepts contributions.
[x] Not a commercial product

Apps/Websites

[ ] The website is available without errors or ssl certificate problems, and load in a reasonable amount of time.
[ ] The website is using vuejs intensively. It should detect vue with vue-devtools.

If you cannot detect vue with vue-devtools due to work at non public pages (e.g. for enterprise website), you can send Pull Request with screenshot that detected it.

[ ] The website is original and not too simple. For that reason, blogs and simple landing pages are rejected.
[ ] A commercial product using Vue, provided that guests could reasonably check out how Vue was used (i.e. A headless CMS which uses Vue for the Admin/editor Area and offers a free tier).

Not to detract from your work, but this is solved in this awesome package: https://github.com/antfu/unplugin-icons (which uses iconfify, supporting more than 100.000 icons that way).
As for why I never suggested that package, I follow awesome-vite too, and didnt know awesome-vue didnt have this on the list.


Add RecommendedTitle

What does this PR do and why?
Add a RecommendedTitle component for create flow bubbles
Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist

[ ] I have evaluated the Approval Guidelines for this PR.
[ ] I have tested this PR in all supported browsers.
[ ] I have tested this PR in dark mode and light mode (if applicable).

Current dependencies on/for this PR:

main

PR #1970

PR #1971

PR #1972

PR #1973

PR #1974

PR #1979

PR #1985

PR #2004


Return Clair Vuln DB timestamp and status in system info api

It will inform user about the readiness and last_update of
The details format of the response is TBD
This is a new good-to-have requirement, but I'll try to fit into sprint 12.

fixed in #2726


Save Button was not properly visible fixed UI issue

Updated Text Field to OutlinedText Field
added card to list
updated one gradle deprecation

Look and fill improvements

Updated UI

Set CLA For my account still showing missing CLA Please help


New version: Ryujinx.Ryujinx version 1.1.1338

Created by 🥟 Dumplings in workflow run #2395.
Logs
Updated: 1.1.1337 → 1.1.1338
Cannot validate argument on parameter 'ChatID'. The argument is null, empty, or consists of only white-space characters. Provide an argument that contains non white-space characters, and then try the command again.
Submitting WinGet manifests
Cannot validate argument on parameter 'ChatID'. The argument is null, empty, or consists of only white-space characters. Provide an argument that contains non white-space characters, and then try the command again.

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\Ryujinx.exe returned exit code: -532462766

Automated error analysis suggests -532462766 may mean EXCEPTION_COMPLUS (Unhandled Exception)
(Automated response - build 886.)


Feature: Manual allocation management via indexer-cli

Add a new indexer-cli command module for direct management of allocations.
Some example commands to explain the use case:

graph indexer allocations reallocate <allocation_id> <allocation_id> ....
graph indexer allocations reallocate <deployment_id> <deployment_id> ....
graph indexer allocations close <allocation_id> <allocation_id> ....
graph indexer allocations close <deployment_id> <deployment_id> ....

Resolved by #403


Number of PRs

Here we should also display the total number of PRs based on the filters..

/assign

@jalaym825 Can I work on it ?

Total nummber of PR.. based on filter.. we can put in before filter option..  like if we select bug in filter then its show that how many prs that have bug merged ?

ya, I got you. but you can annotate on ss and tell me the exact place where can we show the number of filter based prs?
in filter menu?

in filter itself.. like Bug (4) etc..

ok, do it!

fixed in #140


Anerdw: Watch aarogyapathcare.in

Anerdw requests the watch of the watch_keyword aarogyapathcare\.in. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

aarogyapathcare\.in has been seen in 1 true positive, 0 false positives, and 0 NAAs.


first test on BleskOS

I tested BleskOS on my real computer. results: usb mouse was found and listed in Connected Hardware, and can be used to draw something by Graphic Editor; usb keyboard was not found and not listed in Connected Hardware.  The real computer is a Asus server, built nearly 10 years ago, with 2 CPU packages, 4 cores in each package.

Thank you for testing BleskOS on real computer!
First thing that comes to my mind is that you maybe have computer that have some UHCI/OHCI ports and some xHCI ports. I encountered such computer too. BleskOS currently do not have driver for xHCI, so it is not able to recognize USB keyboard in such port. So as first thing, I would try to insert USB keyboard to all ports. BleskOS should recognize keyboard up to one second.
Anyway, we need to get more info about hardware that is in System log. Also if communicating with USB keyboard failed somehow, we will see report of what happened here. In update 2 you can open system log by mouse(Main window>System board>click on [L] Open system log, you can close system log by clicking again). You can scroll down by mouse wheel. So please post some photos what BleskOS prints here.

sudo dd if=bleskos_2023_update_2.img of=/dev/sdb, burn the img into a usbdisk, boot the server computer with the usbdisk. there are 1 usb keybord, 1 ps/2 keyboard, 2 usb mouse. both the usb mouse and the usb keyboard work in legacy mode. after boot, usb keyboard lost its function while the usb mouse works. so i had to use the ps/2 keyboard to strike "L" to show the logs.

Thank you for your time for posting log. It looks like there is not enough time for setting address. At afternoon when I will went home, I will increase this time and add more logging. Hopefully it will help.

You can try update 3. I improve UHCI driver, so we will see if that helps. If not, please post what will be logged in System log. BTW You can open System log without keyboard, just with mouse and you can also scroll down by mouse wheel.

So this shows that problem occurs during reading full USB descriptor. Please can you try this image? It skips reading USB descriptor on UHCI and goes right on setting address. If it will not work, please post what System log says.
bleskos_2023_update_4_not_reading_uhci_descriptor.img.zip

Great! now both keyboard and mouse works well. Plug & Play works well too. BTW are they interrupt driven or polling driven? I mean do host controller send interrupts to system CPU when it receives keyboard and mouse input?

I am glad to hear that. I think I founded bug. In fact, it was happening to my USB keyboard also, but it did not result into block of it. Problem was that reading USB descriptor from low-speed device takes 5 packets, but I was waiting only to 3 packets to be transferred. So your keyboard did not send whole descriptor and BleskOS was already requesting setting of address, what caused this error. Solution was just to change that one incorrect number in code to wait for all 5 packets to be transferred. It should be working in update 5. Can you please test it to confirm if it solved this issue?

hello!
Usb keyboard and mouse in BleskOS update6 works very well on my Asus Server.

Nice. Then I am closing this issue.


Attribute vector creation procedure

Hi,
I am using your attributes file, but I am curious about how the attributes vectors are created because I need to create them for another dataset. I see there are two keys in the .mat file "original_att" and "att" with different statistics for the arrays. Is there some normalization that is performed on binary attribute vectors? If you have the .mat file creation script can you please share it
Thanks in advance !

Hi,
That question has been answered already earlier here in issue https://github.com/edgarschnfld/CADA-VAE-PyTorch/issues/14. Sorry for the late answer.

Hi,
That question has been answered already earlier here in issue https://github.com/edgarschnfld/CADA-VAE-PyTorch/issues/14. Sorry for the late answer.


Instance_augmentation on different image domains.

Hi, great work!
The core idea in the paper is to use large-scale pre-trained generative models to regenerate the object in an image. However, in other image domains such as x-ray security images, there is no large-scale data to train a large generative model. So, how can i borrow the idea presented in your paper to implement instance augmentation on the data-insufficient image domains like x-ray?
Looking forward to your answers!

@pILLOW-1 not sure if this would work for very specific cases like x-ray images (where the diversity in images is very specific and limited). Imho if this does have to work, potentially one would first have to train a Text2Image generative model to be able to have such augmentations.
Additionally, with medical image datasets one has to be very careful, since different artifacts introduced during training might actually corrupt the data. Thus, I would be wary before using this in sensitive settings such as medical data.
@KupynOrest could have more insights here :)
Best,
Sid


Make pretty picture

Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Runs locally on Windows
[ ] Runs locally on Linux
[ ] Runs locally on OS X

Details
Made a module to make somewhat pretty pictures of RaftLib graphs, outputs
a dot format, for use with GraphViz on Linux. Gonna make a pull request but
not merge just yet given I wanna make sure it runs on Windows, it uses an
environment parameter to dump the graph so want to make sure that it
does the right thing when using MS.

Please list test cases created to ensure your feature or addition
works.
Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have checked my code and corrected any misspellings

Ok, this is odd. Runs locally on almost all versions of linux and OS X I can find and containers with fresh libraries. Will try again tomorrow, if not, I might see if you could look at it too @f-tischler?

Yup, all test cases exit with zero locally, or EXIT_SUCCESS...printed tail of an strace, but...still wanna figure out what is going on with the test cases.
munmap(0x7f0f7cd69000, 8392704)         = 0
futex(0x7f0f7e56b9d0, FUTEX_WAIT, 370126, NULL) = 0
munmap(0x7f0f777ff000, 8392704)         = 0
futex(0x7f0f7cd689d0, FUTEX_WAIT, 370128, NULL) = 0
munmap(0x7f0f76ffe000, 8392704)         = 0
exit_group(0)                           = ?
+++ exited with 0 +++


WebsocketNotConnectedException on SendPing

WebSocket pings without connections and causes to crash: WebsocketNotConnectedException
Expected Behavior
Application using the websocket client is not supposed to crash while running on Android.
Current Behavior
We have found in some Android phones the following error:
Fatal Exception: org.java_websocket.exceptions.WebsocketNotConnectedException
at org.java_websocket.WebSocketImpl.send(WebSocketImpl.java:608)
at org.java_websocket.WebSocketImpl.sendFrame(WebSocketImpl.java:634)
at org.java_websocket.WebSocketImpl.sendPing(WebSocketImpl.java:641)
at org.java_websocket.AbstractWebSocket$1.run(AbstractWebSocket.java:153)
at java.util.Timer$TimerImpl.run(Timer.java:284)
Steps to Reproduce (for bugs)
Unfortunately I was still unable to reproduce the bug locally. As soon as I will, I will update the issue.
Context
We implement the websocket client in an Android App.
Your Environment

Version used: 1.3.8
Operating System and version: Android 6-8

Hello @leokho,
thank you for your bug report.
I think the best is to just catch this exception. Could be just a bad timing thing....
Does this happen a lot?
Best regards,
marci4

Hi @marci4 ,
Yes, it does happen quite a bit, around 10% of our users experience this bug. We are still trying to see if we find a way to replicate this on our side.
The stack trace that I've posted, is the full one.

Hello @leokho,
that is actually a lot. I am sorry for the inconvenience!!
On what interval have you set the connection lost detection?
Have you run into the same issue described in #699 ?
Could you describe how you are using the library in your app?
Maybe this helps at least get to the source of the problem.
Best regards,
marci4

Hello @marci4,
Yes, we think our issue is the same as #699.
Could you please create a new version tag with the updates you did for this issue in master for us to test?
thank you,
Joana

Hello @JoanaDFerreira,
that would only be #708.
Best regards,
marci4

android10
Version used: 1.5.3
When I used version 1.5.3, the WebsocketNotConnectedException problem still occurred. Wasn't this problem solved in version 1.3.9? Why does it still occur?


Version 3.0.12

Landed in https://github.com/metarhia/impress/commit/fdd1dcab96a4c134bcdc48d1f01b074bed388e4b


Documentation in LearnOSM

It will be great to have a introductory documentation about how to use the app in LearnOSM.org.

I agree, but that's not for me to write.


Mouse clicks NOT highlighted

macOS version: 10.13.6
Kap version: 3.0.0 & 3.0.1
Steps to reproduce
Install Kap on 10.13, open Preferences or capture a clip.
Current behaviour
Mouse click highlighting (highlightClicks) does not work - clicks are not displayed in the video.
'Show cursor' option is not even displayed in Preferences (cmd+,). However, it is present on macOS 10.15.2, so this bug seems to be OS-specific.
Expected behaviour
Option to show cursor should be present in Preferences. Mouse clicks should be visible in captured videos.
Workaround
Upgrade macOS to 10.15
(Tried configuring 'highlightClicks' option manually in ~/Library/Preferences/com.wulkano.kap.plist, but it didn't work.)

Clicks are not highlighted for me in 10.15.6.
I checked all the privacy settings and Kap is enabled there.
Highlight clicks checkbox is enabled. I also tried switching it off and on again.

Same here.
macOS version: 10.15.7 Catalina
Kap version: 3.3.2
Highlight clicks checkbox is enabled, but it doesn't work.

+1
macOS: 11.3.1 Big Sur
Kap: 3.4.0

This does not work with Kap 3.6.0 on MacOS Monterey 12.6.
System Preferences > Security & Privacy > Privacy > Accessibility > Kap is checked
On Kap, General Preferences Show cursor and HIghlight clicks enabled.


Unable to deploy v1.6.4 and v1.7.0-beta.0 using Kubernetes-Anywhere v0.1.0

Tried deploying Kubernetes Cluster using v1.6.4 and v1.7.0-beta.0 release and observed nodes status remains pending.
Used Kubernetes-Anywhere for the deployment.
Logs
root@master [ ~ ]# journalctl -u kubelet.service -f
.
.

Jun 07 21:53:12 master systemd[1]: kubelet.service: Failed with result 'exit-code'.
Jun 07 21:53:22 master systemd[1]: kubelet.service: Service hold-off time over, scheduling restart.
Jun 07 21:53:22 master systemd[1]: Stopped Kubernetes Kubelet Server.
Jun 07 21:53:22 master systemd[1]: Starting Kubernetes Kubelet Server...

make[1]: Leaving directory '/opt/kubernetes-anywhere'
KUBECONFIG="$(pwd)/phase1/$(jq -r '.phase1.cloud_provider' .config.json)/.tmp/kubeconfig.json" ./util/validate
Validation: Expected 5 healthy nodes; found 0. (280s elapsed)
Validation: Expected 5 healthy nodes; found 0. (290s elapsed)
.
.
Validation: Expected 5 healthy nodes; found 0. (580s elapsed)
.
Validation: Expected 5 healthy nodes; found 0. (730s elapsed)

cc: @tusharnt @BaluDontu
This is P0 and We need to investigate, the deployment issue.
CI jobs picks up latest bits from the release 1.6 and there we never observed deployment issue.

Ignition Image - docker.io/cnastorage/k8s-ignition:v1 uses kubelet flag "--config", which is no longer available on v1.6.4 and v1.7.0-beta.0. We need to use  new flag "--pod-manifest-path".
Reference: https://kubernetes.io/docs/admin/kubelet/

[ ] Create a new Ignition image with above flag and save this image with version v2 at
docker.io/cnastorage/k8s-ignition:v1
[ ] Test kubernetes cluster deployment for  v1.6.4 and v1.7.0-beta.0 using new ignition image.

updated documentation: https://github.com/kubernetes/kubernetes-anywhere/pull/407


Bash 4.x

https://github.com/mhulse/dotfizzles/wiki/Upgrade-bash-on-OS-X
Put those instructions in README

So, I installed your dotfizzles on another Mac, and though I didn't get the unexpected EOF error, globbing wasn't working, even after I installed and upgraded bash via homebrew and restarted. The last few steps in these instructions were the missing pieces, at least for me:

Check if you can enable glob support, run this command.
shopt -s globstar

If nothing happens you're good to glob. If you get an error that looks something like this, proceed to the next section.
bash: shopt: globstar: invalid shell option name

Updating bash
Check to see what version of bash you're running
bash --version

Install bash:
brew update && brew install bash

Append the /etc/shells file with the new shell path:
sudo bash -c 'echo /usr/local/bin/bash >> /etc/shells'

Then change to the new shell:
chsh -s /usr/local/bin/bash

Now you have to quit the terminal and open it back up again. If you check the version it should show something updated.
bash --version

To enable glob support run the following.
shopt -s globstar

Ahhhh, good catch! Looks like it was the sudo bash -c ... and chsh stuff?
I'll be sure to clarify the docs. I have several issues relating to README docs/instructions, so I'll be sure to clarify this when I do an update (hopefully this weekend).
Thanks for the feedback and report. It can be hard to account for some of the new install stuff when I've been using this for a while (it's easy to miss the fresh install stuff).
👍

Adding all doc issues to the README label.

Added note about upgrading to bash4 in wiki:
https://github.com/mhulse/dotfizzles/wiki/Optional-dependencies
Closing.


Disable page scrolling in slickgrid

This should fix this in schema compare as well assuming they are using the default options.
fixes #5332

I'll merge now so this can be in tomorrow's insider build.


Replace code in tree.py with python-newick

Let's offload this code to a 3rd party library: https://github.com/glottobank/python-newick/

@xrotwang - you implemented both of these? is python-newick a drop in replacement?

No, that was @Bibiko. I only did a bit of cleanup, and added tests.

This is not as straightforward as we may think. Pruning in python-newick is a lot less advanced than in ete3, see these test cases for examples: https://github.com/D-PLACE/dplace/blob/master/dplace_app/tests/test_tree.py#L19-L70

Ok, closing.


[labs/ssr]: fails with expressions inside of

          <slot></slot>

      This could be because you're attempting to render an expression in an invalid location. See
      https://lit.dev/docs/templates/expressions/#invalid-locations for more information about invalid expression
      locations.

      at throwErrorForPartIndexMismatch (file:///project/workspace/node_modules/@lit-labs/ssr/lib/render-value.js:610:11)
      at renderTemplateResult (file:///project/workspace/node_modules/@lit-labs/ssr/lib/render-value.js:597:9)
      at renderTemplateResult.next (<anonymous>)
      at renderValue (file:///project/workspace/node_modules/@lit-labs/ssr/lib/render-value.js:409:16)
      at renderValue.next (<anonymous>)
      at LitElementRenderer.renderShadow (file:///project/workspace/node_modules/@lit-labs/ssr/lib/lit-element-renderer.js:69:16)
      at renderShadow.next (<anonymous>)
      at renderTemplateResult (file:///project/workspace/node_modules/@lit-labs/ssr/lib/render-value.js:583:21)
      at renderTemplateResult.next (<anonymous>)
      at renderValue (file:///project/workspace/node_modules/@lit-labs/ssr/lib/render-value.js:409:16)

  xxx GET / 500 23ms -

  Error:
      Unexpected final partIndex: 1 !== 2 while processing the following template:

        ${...}

          <slot></slot>

      This could be because you're attempting to render an expression in an invalid location. See
      https://lit.dev/docs/templates/expressions/#invalid-locations for more information about invalid expression
      locations.

      at throwErrorForPartIndexMismatch (file:///project/workspace/node_modules/@lit-labs/ssr/lib/render-value.js:610:11)
      at renderTemplateResult (file:///project/workspace/node_modules/@lit-labs/ssr/lib/render-value.js:597:9)
      at renderTemplateResult.next (<anonymous>)
      at renderValue (file:///project/workspace/node_modules/@lit-labs/ssr/lib/render-value.js:409:16)
      at renderValue.next (<anonymous>)
      at LitElementRenderer.renderShadow (file:///project/workspace/node_modules/@lit-labs/ssr/lib/lit-element-renderer.js:69:16)
      at renderShadow.next (<anonymous>)
      at renderTemplateResult (file:///project/workspace/node_modules/@lit-labs/ssr/lib/render-value.js:583:21)
      at renderTemplateResult.next (<anonymous>)
      at renderValue (file:///project/workspace/node_modules/@lit-labs/ssr/lib/render-value.js:409:16)

  <-- GET /

  Error:
      Unexpected final partIndex: 1 !== 2 while processing the following template:

        ${...}

          <slot></slot>

      This could be because you're attempting to render an expression in an invalid location. See
      https://lit.dev/docs/templates/expressions/#invalid-locations for more information about invalid expression
      locations.

      at throwErrorForPartIndexMismatch (file:///project/workspace/node_modules/@lit-labs/ssr/lib/render-value.js:610:11)
      at renderTemplateResult (file:///project/workspace/node_modules/@lit-labs/ssr/lib/render-value.js:597:9)
      at renderTemplateResult.next (<anonymous>)
      at renderValue (file:///project/workspace/node_modules/@lit-labs/ssr/lib/render-value.js:409:16)
      at renderValue.next (<anonymous>)
      at LitElementRenderer.renderShadow (file:///project/workspace/node_modules/@lit-labs/ssr/lib/lit-element-renderer.js:69:16)
      at renderShadow.next (<anonymous>)
      at renderTemplateResult (file:///project/workspace/node_modules/@lit-labs/ssr/lib/render-value.js:583:21)
      at renderTemplateResult.next (<anonymous>)
      at renderValue (file:///project/workspace/node_modules/@lit-labs/ssr/lib/render-value.js:409:16)

  xxx GET / 500 4ms -

  Error:
      Unexpected final partIndex: 1 !== 2 while processing the following template:

        ${...}

          <slot></slot>

      This could be because you're attempting to render an expression in an invalid location. See
      https://lit.dev/docs/templates/expressions/#invalid-locations for more information about invalid expression
      locations.

      at throwErrorForPartIndexMismatch (file:///project/workspace/node_modules/@lit-labs/ssr/lib/render-value.js:610:11)
      at renderTemplateResult (file:///project/workspace/node_modules/@lit-labs/ssr/lib/render-value.js:597:9)
      at renderTemplateResult.next (<anonymous>)
      at renderValue (file:///project/workspace/node_modules/@lit-labs/ssr/lib/render-value.js:409:16)
      at renderValue.next (<anonymous>)
      at LitElementRenderer.renderShadow (file:///project/workspace/node_modules/@lit-labs/ssr/lib/lit-element-renderer.js:69:16)
      at renderShadow.next (<anonymous>)
      at renderTemplateResult (file:///project/workspace/node_modules/@lit-labs/ssr/lib/render-value.js:583:21)
      at renderTemplateResult.next (<anonymous>)
      at renderValue (file:///project/workspace/node_modules/@lit-labs/ssr/lib/render-value.js:409:16)

Reproduction
https://codesandbox.io/p/devbox/goofy-shirley-jgslml?file=%2Fcomponents%2Fcustom-block.js%3A34%2C8
Workaround
The only workaround I have found is to use unsafeHTML directive.
staticHTML also does not solve the issue either.
Is this a regression?
No or unsure. This never worked, or I haven't tried before.
Affected versions
Failing in 3.2.2 of Lit SSR
Browser/OS/Node environment
Browser: N/A
Node: v20.12.1
Lit SSR: 3.2.2
Lit: 3.1.4
Additional notes
Yes. This is an intentionally silly example. The real use case is for dynamic media queries based on attributes like this:
render () {
  return html`

  `
}

I know about the performance regressions, but this is for what is essentially a "singleton" element.

I have a fix for this

I have a fix for this.

Or not. Raw text element handling in SSR is tricky. I can easily make a better error message that recommends unsafeHTML().

I think we can support raw text elements with this strategy:

Don't emit  markers inside raw text elements
Add a way to describe child parts in  by text offset, maybe like  where 5,10;21,31 says that there's a child part from chars 5-10 and 21-31. This requires that textContent isn't modified by the browser (to confirm).

Any progress on this? I have the same issue with a script tag.
what I want to inject for example:
 const content = `console.log('Hello from script tag');`

And I am getting the same error.

Any progress on this? I have the same issue with a script tag.
what I want to inject for example:
const content = console.log('Hello from script tag');

And I am getting the same error.

The way I'm solving this for now is wrapping the


⚠ Bofrost.lu has degraded performance

In 00128c8, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1917 ms

Resolved: Bofrost.lu performance has improved in f836352 after 23 minutes.


docs: add autocomplete guidelines for users that use VScode as their primary IDE

Hi @argyleink,
Kindly review.

Awesome! Thank you for the feedback.
I'll start working on them.

Hi @argyleink, I made the changes you requested. Kindly take a look

rad, thanks for kicking this all off and doing the research!

Hi @argyleink,
Would it be nice if the autocomplete docs also contains the process of setting it up for other IDEs like atom, Sublime etc.
I can start making my research if you permit me.

sounds great! helping folks get it setup in Atom and Sublime would def be nice 🙂
thanks for offering more help!

sounds great! helping folks get it setup in Atom and Sublime would def be nice 🙂 thanks for offering more help!

Anytime! 😎

I've started my research about autocomplete in atom, and I've found a use-case already.
Hopefully,  I'll send a PR by the end of the week.


split yaw gyro LPF from x and y axes

This implements the feature requested in #307.  It's really a small change but I think will help the "touchiness" of yawrate response we've been seeing the mocap room.  It appears that @korken89 has observed the same response in his testing.

Thanks!


README.md: document the "named exercise" mode

By named exercise mode I mean the following steps:

name
description

1_test
Run 001_hello.zig without checking output

1_install
Copy 001_hello.zig to zig-cache/bin

1
Check 001_hello.zig only

These steps/command are not documented in the README.md file.
Documentation for Step n has been added recently as workaround for making ziglings work again, but in my next commit to the perillo:improve-build branch, I will restored the README.md file to the previous state.

These steps/command are not documented in the README.md file.

But you can see it when you run zig build -h, what the standard is.

And it is already documented in the Advanced section, that I originally missed.


chore: update demo project

Having a different repo for the docs was a dead end. Webpack will get crazy when trying to import stuff from a different project.
I updated what we got using a simplified version of my starter. No lint, no test. Will add those when the time is right, but we need something to show like for yesterday.
As soon as I merge this, I will make 2-3 demos so @icfantv can play with the CSS

That really stinks.  So we have to have everything under core?  What happens when we break out components?  Is that going to cause the same issue?

We will cross that bridge when that happens.
Perhaps when we push this repo to npm, we can install it into the demo project and work with it, but as today, I don't find a clean way.

@Foxandxss just lemme know when you're ready and I'll get started

After discussion, this LGTM

I'm ok with this.


Multi-operational Apply

One peer reviewer for the TACAS 2022 submission on Adiar suggested to alter the Apply such that one can compute f O g for multiple binary operators O at the same time, e.g. f /\ g and f \/ g.
This should be possible as follows:

Run the Apply.

Disable pruning based on the operator. Or even better: prune only if all operators would prune the subtree.
For every pair of leaf values output both of them in an arc src -> (t1, t2) that includes both sink values.

For every operator O run the Reduce.

Whenever a sink-arc is pulled from a file, the operator is applied to it.
Maybe these can even be run in "parallel" and be aware of the shared structure? This could potentially decrease the amount of stuff in each's respective priority queue by sharing nodes.

The main question to ask (the reviewer did too), is what use-case do we have for this?


Implement Test Coverage Measurement

Idea Description
While test coverage might not directly reflect the quality of tests, it's essential to ensure that tests exist at least to a minimal degree. We want to implement a method to measure test coverage within our project, possibly using tools like kotlinx-kover. The goal is to find an effective way to gauge our test coverage and help guide future testing efforts.
Reference images and links

I tried to output coverage report using jacoco plugin, but I could not find method for this project.
Project's build.gradle.kts
allprojects {
    apply(plugin = "jacoco")
}

tasks.register("jacocoReport", JacocoReport::class.java) {
    reports {
        xml.required.set(true)
        html.required.set(true)
    }
    val mySourceDirectories = subprojects.map { project ->
        "${project.projectDir}/src/main/java"
    }
    val myClassDirectories = subprojects.map { project ->
        "${project.buildDir}/tmp/kotlin-classes/debug"
    }
    val execFileTree = fileTree(rootDir) {
        include("**/testDebugUnitTest.exec")
    }
    sourceDirectories.setFrom(mySourceDirectories)
    classDirectories.setFrom(myClassDirectories)
    executionData.setFrom(execFileTree)
}

./gradlew recordRoborazziDebug
./gradlew jacocoReport

I've just added kover support to the project and it works by ./gradlew koverHtmlReportRelease, but not work for the app module, you can checkout here


Modify the README

[x] the levels of headings
[x] Table of Contents

This change is

Thanks @ttanimichi !


ToneDen.player.global.nowPlaying() only returns false

no matter if it is playing or not, it only returns false.
More info on this video (without audio, but it was playing):
https://cloudup.com/cmywsF5qqHK

Note: I'm closing every issue on this repo with this message.
I apologize for not being in contact earlier. We recently received notice from SoundCloud that they're shutting down their external streaming API for business reasons that I won't speculate about.
Every user of a custom SoundCloud player, ours included, will need to switch to their embedded player in order to stream songs from SoundCloud.
It's disappointing that we have to be the ones to break this news to developers, and I'm sorry for the inconvenience it's caused the users of our player. I'll leave this repo up and add this message to the top of the README so that others become aware of the situation.


Adding missing field to search results

Added the field incomplete_results. It is docummented on https://developer.github.com/v3/search/#timeouts-and-incomplete-results

LGTM.
Thanks!


Update Merlin Systems inference example and Merlin PoC example to be worked in TF-TR container

Currently, in order to make the inference example notebooks in the Merlin repo and Merlin Systems repo work we need to install Tensorflow in the inf container, However this is not the expected practice. In will install the inference container size more.
In order to avoid TF get installed in the inference container:

[ ] we need to fix the ModuleNotFoundError: No module named 'pyarrow._s3fs' issue when we run feast init feature_repo
[ ]  be sure we dont have any other issues, and then execute notebooks in the tensorflow-training container and export the models,
[ ]  mount the saved models to inference container together with the ensemble object, load back in the ensemble object and  serve saved models in the tensorflow-inference with run_ensemble_on_tritonserver() and get the response.

Seems like a good idea! A few comments:

@mikemckiernan is working on updating the examples to use a shared Docker volume (called merlin-examples or something like that), which should make sharing files between multiple containers easier. See https://github.com/NVIDIA-Merlin/Merlin/issues/209
I'm not sure if the training container needs S3 support, and including it in the build process for Arrow may increase the training container size unnecessarily. To work around that, I'd create the feature repo from the inference container if possible. See https://github.com/NVIDIA-Merlin/Merlin/pull/95 and https://github.com/NVIDIA-Merlin/Merlin/pull/98
run_ensemble_on_tritonserver() is actually a test utility that we've been abusing somewhat. @jperez999 has done some work for the Systems example notebook to create separate methods to start Triton and to send requests, which we should use in this notebook too. See https://github.com/NVIDIA-Merlin/Merlin/issues/210

@karlhigley thanks for the comments. We can talk offline about the design of splitting notebooks and steps into two nbs (one will be run in the tf-tr the other one will be run in tf-inf container) but my concerns are:

PredictTensorflow() requires TF. So  the operators in creating Ensemble graph should be run in TF-training, other wise we had to install TF in the TF-inf container (meaning going back to the original issue).
In case of create the feature repo from the inference container . This is what we are currently doing. But when we switch to two container design,  not sure how we will do the notebook split if feast is initialized in the inference container, but the operators will be defined in the training container, etc etc.. yeap, let's talk the details offline :)

Yeah, that makes sense. Let's try adding S3 support and see what that does to the training container size.

It looks like we can do it and still sneak in under the 15GB cap:

REPOSITORY
TAG
IMAGE ID
CREATED
SIZE

nvcr.io/nvidia/merlin/merlin-tensorflow-training
arrow-s3
4bc70b8f0130
11 seconds ago
14.6GB

nvcr.io/nvidia/merlin/merlin-tensorflow-training
22.04
8a9d8ddb1aa1
10 days ago
14.3GB

I'll open a PR and we can get some second (or third?) opinions.


feat: make default I/O buffer size configurable via env var

Codecov Report
Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.93%. Comparing base (87d1dd9) to head (c1925f8).
Report is 4 commits behind head on main.

Files with missing lines
Patch %
Lines

rust/lance/src/dataset/scanner.rs
50.00%
1 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2826      +/-   ##
==========================================
- Coverage   78.45%   77.93%   -0.53%
==========================================
  Files         229      229
  Lines       69604    70106     +502
  Branches    69604    70106     +502
==========================================
+ Hits        54611    54638      +27
- Misses      11917    12382     +465
- Partials     3076     3086      +10

Flag
Coverage Δ

unittests
77.93% <83.33%> (-0.53%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bug Fix - Chat screen: wrong attachment is opened

https://github.com/vector-im/vector-ios/issues/387
Do not force the refresh of the current attachment index on attachments update. The current index value is correct.

SGTM


Remove error thrown when running slate build

Fixes #45 and fixes Shopify/slate-cli#118.
Not sure if this is the best approach but wanted your thoughts. This removes the throw new Error() output when there isn't a config.yml in the theme root folder and when slate build is ran.
I brought the error logic to the invalidate:id task, which is called for slate watch and slate deploy. This ensures the config has been created, otherwise the process will exit before it "links" the local theme folder to the store.
Output when running either sync command:

The slate build command will build without any errors now.
@cshold

🎩
😍
Works great!


Provide a customizable 404 & 500 page that an extension can redirected to.

We currently have a 404 page but that is only used when a user attempts to access an angular route that doesn't exists.
This 404/500 page should allow custom help/information text and a custom link that will redirect the user to a specific location.
We should keep this simple and allow the extension to decide when to redirect.

Revisit when needed


Graph color and scale has changed since release of v0.12

Describe the bug
Since the release of v0.12, I'm experiencing problems in the way graph of plots appear:

The color of grid which used to be kinda greyish-blue with white grid lines, is now plane white with grey grid lines.
The x-axis scale has also increased making graphs look horizontally stretched.

To Reproduce
By just plotting the basic line chart using pyplot API with default configurations, it can be observed on the 2 versions:

bqplot v0.11.8

bqplot v0.12.0
Plot for exact same code

Also, in v0.12.0, some of the grid lines go unexpectedly missing for line charts like this:

Environment

Operating System and Version: Ubuntu 16.04
I am using a conda environment - in which everything is same just upgraded bqplot from v0.11.8 to v0.12.0

Additional context
I am not aware if this has been explicitly changed in this new version on bqplot (v0.12.0) since I couldn't find any changelog.

Exact same issue here. Both on ubuntu 18.04 and on a Binder instance of the notebook.
In addition:

the axes scale don't match the data range anymore (both in H and V direction).
Unusual behavior of the data extending out of the figure
This modification breaks the layout when using HBoxes and VBoxes. Example:

v0.11.9

v0.12

Temporary workaround: fix the bqplot version in the requirements.txt or environment.yml file:
bqplot=0.11.2

Some information is given in this commit: https://github.com/bloomberg/bqplot/commit/28231a88796123d62327a1bf8891b98444ef8527
It may be obvious, but it is unclear to me how to update my Python code in order to restore the previous behavior.

Thanks for filling this issue!
Concerning the colors, it is due to bqplot supporting JupyterLab CSS variables (allowing support for JupyterLab themes).
If you want to set the width to a lower value you can play with the plot.layout.width parameter.
For example:

plot.layout.width = '50%', this will take 50% of the available space
plot.layout.width = '500px', this will take 500 pixels

The lines issue looks like an ugly bug... I will look into it. Thanks again

More on the layout attribute here: https://ipywidgets.readthedocs.io/en/stable/examples/Widget Styling.html

The lines issue looks like an ugly bug...

I cannot reproduce this issue 100% of the times, there seems to be a race condition somewhere.
But I found something that might be the origin of the issue for the lines not being long enough. The figure size is still hardcoded somewhere in the code: https://github.com/bloomberg/bqplot/blob/master/js/src/Figure.ts#L72
cc. @SylvainCorlay

I opened a PR that will fix it #964. You can try my fix on binder: https://mybinder.org/v2/gh/martinRenou/bqplot/test_binder

Thanks for the effort (and thanks to all the team for this terrific library).
Here is another example of the weird axis/data behavior (taken from your binder. The file is examples/Advanced Plotting/Axis Properties.ipynb)

Again something I can't seem to reproduce locally... I also see it on binder though

So, after a quick debug session with @maartenbreddels, we found that the Axes and grid sizes are not properly linked to the figure size...
This should be fixed in #964. The binder seems to work now: https://mybinder.org/v2/gh/martinRenou/bqplot/test_binder


Better way to transfer data from memory to tensor in C++ API

This is more of a general feature request for a better way to load data into a tensor in the C++ API, but I'll take our specific case as a reference.
We currently train a model in Python, freeze it, and load it in a C++ production pipeline. This works fine, but it seems the only way of loading data into a tensor is by looping through every single element in the data and copying it to a tensor. In our case, we're dealing with a 1920x1080 ~30 fps video input signal (each frame coming as an OpenCV matrix) making it infeasible to do if we want to process a video within a reasonable amount of time.
It seems there is a way of creating a tensor from a pointer in the C API (see http://stackoverflow.com/questions/39379747/import-opencv-mat-into-c-tensorflow-without-copying), which we will test next, but it would be nice to also have this functionality in the C++ API.
For reference, it takes approximately 900 ms to copy from an 1920x1080x3 OpenCV matrix to a tensor while it takes 315 ms to do session.run (which I assume includes transferring between CPU and GPU memory).
An issue related to this is that we will probably already have the data on the GPU from some earlier preprocessing, so we would also be very interested in not having to transfer between CPU and GPU unnecessarily.
So I guess it boils down to:

Are there any plans for making it easier to load data already in memory to a tensor?
How can we contribute?

Perhaps I'm misunderstanding, but could you use std::copy_n on Tensor::flat? For example, see FillValues in tensor_testutil.h.

Yes, the idea is to avoid copying at all, since we're dealing with approximately 360 mb/s that are already in CPU memory. Avoiding a 1:1 copy (memcpy or otherwise) would be ideal.
I've been looking into creating a custom allocator for tens or creation, to point to existing data instead - would this be possible? Or are we blind to the obvious solution here?

BTW, memcpy does around like 5GB/sec on a single core, so 360 MB/s seems on the low side

Preliminary tests with memcpy confirms that it does indeed run much faster; however, having a way of pointing to data instead of copying would still be very nice – especially if we could point to data already on the GPU in some way.

There's a discussion of sharing GPU memory in https://github.com/tensorflow/tensorflow/issues/2210#event-706768999 and it seems hard.
For sharing main memory, possibly related issue to get rid of copy here . I suspect that Allocator interface would need to be modified to allow keeping pointers to memory that it doesn't own

however, having a way of pointing to data instead of copying would still be very nice – especially if we could point to data already on the GPU in some way.

As @yaroslavvb notes here: https://github.com/tensorflow/tensorflow/issues/2919#issuecomment-226660045 there's also a memcpy  for copying numpy array contents into python Session.run(). I'm mentioning this because I think there are similar issues across languages.
A similar python solution may involve creating a Tensor that wraps the numpy array but does not own the data.
Another possible solution involves explicitly allowing the user to pass array data by move or reference (C++ style). Move would assign ownership for the data to tensorflow, while by ref would leave ownership to the calling python/C++ code.
with tf.Session() as S:
  S.run([ops], feed_dict={x: ...}, move_feed_dict={y:...}, ref_feed_dict={z: ...}

It would be nice for this to be consistent across languages.

CC @mrry, @hawkinsp  as FYI.
I can sort of see how that would work on CPU only, but with GPU devices, and also XLA I can see that we would need to think carefully. A shallow tensor sounds like a great idea!

Thoughts:
I'm not sure that Eigen has the same concept of a numpy strided indexing for a Tensor, but similar concepts are expressed in TensorStriding and TensorPadding. It would be useful to map the numpy stride concept onto a Tensor, to avoid copies.
Otherwise, a call to np.ascontiguousarray will copy a non-contiguous array into a contiguous array, otherwise it will return a view of the original (contiguous) array.

maybe the most straightforward way is modifying the source code of class Buffer, then rebuild tensorflow. I didn't find the private API to cast TF_Tensor* to tensorflow::Tensor that @mrry mentioned in this stackoverflow post, create a TensorBuffer using C api then pass it to the constructor of the class tensorflow::Tensor?

@yaroslavvb Thanks for the reference you pointed to! Really helpful to what I am looking for.
But to this issue per se, I guess parsing in a multi-node context is not exactly what the owner of this issue referred to.
So currently there is no way to construct a tensor by moving an existing pointer? How about construct a tensor with empty underlying storage and take that storage for your own use, and give it back to TF?
Allocator is such a monolithic runtime so I guess it has to take control over the details of memory allocation, for example, alignment, similar to what malloc/free does. As it is simply not a good idea to glibc free a chunk of memory returned by another memory allocation library, say jemalloc.

cc @michaelisard
@byronyi I'm not away of any way of doing that.
Having TensorFlow allocate the memory buffer and provide the pointer seems safer because TensorFlow could make sure memory is aligned.
This would be useful because one could initialize numpy array based on pre-allocated memory as described here and this would reduce memory transfers. (ie PyTorch reuses memory between Tensor and numpy array objects)

@byronyi there is a class TF_ManagedBuffer derived from TensorBuffer, the data_ field is public, you can directly construct a TF_ManagedBuffer, then use TensorCApi::MakeTensor to construct a Tensor. TF_ManagedBuffer need a deallocator function pointer for destruction use. There are also two functions allocate_tensor and deallocate_buffer which can give you a memory buffer from tensorflow's cpu allocator.

@suiyuan2009 That piece of information is very helpful. Thank you!

TensorCApi::MakeTensor doesn't seem visible from client code today. However, you can probably avoid copying pre-allocated buffers to tensors with a customized Alocator.
class FakeAllocator {
 public:
  FakeAllocator(void* buffer): buffer_(buffer) {}
  void* AllocateRaw(size_t alignment, size_t num_bytes) override { return buffer_; }
  void DeallocateRaw(void*) override {}

 private:
  void* buffer_ = nullptr;
};

I notice that TF_ManagedBuffer is only visible within c_api.cc file, using a FakeAllocator to construct a TensorBuffer is a good approach.

Caveat: AllocateRaw should check the alignment; otherwise, internal TensorFlow code may crash if the allocated memory is misaligned.

@wujingyue Do you know how one should check for the alignment in Eigen::Tensor?

@bnurbekov https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/framework/allocator.h#L70
Eigen::Tensor has a larger alignment (maybe 512), but it doesn't matter as long as TF allocator is happy with the alignment of your buffer.

@ppries  Have you found a better way or a workaround for this ? If so, I can close this issue.

@harshini-gadige
we are using memcpy for now, but might look into alternative ways of doing this – at some point we will have a need for pointing at data already on the gpu, but other problems are prioritized for now.

Ok. Closing this issue for now. Feel free to reopen if there any new suggestions.

Hi @ppries , I have the same needs that pointing to data already on the gpu, do you have a solution?

Hi @ppries , I have the same needs that pointing to data already on the gpu, do you have a solution?

I have the same needs as well. Is there any solution? Thanks!

Hi all, I solved this problem in my team, I am sorry that I can not post my code here now, but I can provide some information that may help you guys.
As T4 GPU only have about 15G device memory, in my team, each model is about 500M, we can only load 12-15 models per GPU for serving . To solve this, we want to make model hold in host memory , only when requests come, the model copy from host to deivce for serving.
To get there, I change the constant op which holds GPU memory in graph_def to a custom op (MutableOp) to replace ConstantOp before loading the model .  And I create a global singleton object to get gpu address for each memory tensor before session run . MutableOp get tensor device address from this global singleton object in construct function .

@duduscript I think everybody here would love to see the code for the "set tensor data address" pseudo line. please post a snippet of code.

@duduscript I think everybody here would love to see the code for the "set tensor data address" pseudo line. please post a snippet of code.

Hi @dirktheeng , I make this custom op(MutableOp) a friend of Tensor, so I just set tensor data membet in MutableOp::Compute

@duduscript Thanks much.  I will give this a try.

By looking at the code here in TF repo: https://github.com/tensorflow/tensorflow/blob/72d8f7ba27c1593e17a5fdc03dbe171bca23a88b/tensorflow/compiler/jit/xla_launch_util.h#L190
Looks like I could also implement a subclass of TensorBuffer, which only holds the piece of memory you want to pass to TF.


Supports HLSJS > 0.6.x-x

I tested with 0.6.2-6 and saw some errors.

https://github.com/dailymotion/hls.js/releases/tag/v0.6.2-6
fix interfragment audio glitches and potential audio/video out of sync issue
We have this issue, have any ETA to solve this errors? Can you give more info about those errors?
Regards

@paunadeu I made a black box test and Clappr didn't play any video at all.

Can you upload for analyze it?
Regards,
Pau

@paunadeu you can do it too:

git clone https://github.com/clappr/clappr.git
cd clappr
vim package.json -> "hls.js": "^0.6.2-6"
npm install
npm start

Works fine on:
https://tv.fibracat.cat/cdn/clappr2/dist/
But when I use in other page don't work. I see that use .min version on this page, change to non-minified version and works properly.
Can you check if works without minified version?
Regards,
Pau

Works with minified version and 0.6.2-6 now. I did nothing.
Regards

I tried again and it shows some errors for hls:
Uncaught ReferenceError: _typeof2 is not defined
clappr.js:2801 [error][hlsjs: trying to recover from error, evt hlsError, data [object Object] ]

What video are you playing? What is URI?
Regards,
Pau
2016-09-13 19:57 GMT+02:00 Leandro Moreira<EMAIL_ADDRESS>
I tried again and it shows some errors for hls:
Uncaught ReferenceError: _typeof2 is not defined
clappr.js:2801 [error][hlsjs: trying to recover from error, evt hlsError, data [object Object] ]
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/clappr/clappr/issues/1143#issuecomment-246767353, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGzxNxX2eAs7p8FlUXREx0zFOQlI3IuQks5qpuP3gaJpZM4J5DQg
.

@paunadeu http://www.streambox.fr/playlists/x36xhzz/x36xhzz.m3u8

The same URL has problems for me too.
Can u try with http://vevoplaylist-live.hls.adaptive.level3.net/vevo/ch1/appleman.m3u8
Regards,
Pau

@paunadeu the point is the same url works when we use hls.js alone http://dailymotion.github.io/hls.js/demo/ . It seems that all the headers are working fine too:
> GET /playlists/x36xhzz/x36xhzz.m3u8 HTTP/1.1
> Host: www.streambox.fr
> User-Agent: curl/7.43.0
> Accept: */*
>
< HTTP/1.1 200 OK
< Date: Wed, 14 Sep 2016 12:18:07 GMT
< Server: Apache/2.4.10 (Debian)
< Last-Modified: Thu, 17 Sep 2015 10:52:47 GMT
< ETag: "5d7-51fef372e9dc0"
< Accept-Ranges: bytes
< Content-Length: 1495
< Access-Control-Allow-Origin: *
< Access-Control-Allow-Headers: Origin, X-Requested-With, Content-Type, Accept, Range
< Content-Type: application/x-mpegURL

> GET /playlists/x36xhzz/url_0/193039199_mp4_h264_aac_hd_7.m3u8 HTTP/1.1
> Host: www.streambox.fr
> User-Agent: curl/7.43.0
> Accept: */*
>
< HTTP/1.1 200 OK
< Date: Wed, 14 Sep 2016 12:19:42 GMT
< Server: Apache/2.4.10 (Debian)
< Last-Modified: Thu, 17 Sep 2015 08:13:17 GMT
< ETag: "e16-51fecfcc40140"
< Accept-Ranges: bytes
< Content-Length: 3606
< Access-Control-Allow-Origin: *
< Access-Control-Allow-Headers: Origin, X-Requested-With, Content-Type, Accept, Range
< Content-Type: application/x-mpegURL
<

> GET /playlists/x36xhzz/url_0/url_525/193039199_mp4_h264_aac_hd_7.ts HTTP/1.1
> Host: www.streambox.fr
> User-Agent: curl/7.43.0
> Accept: */*
>
< HTTP/1.1 200 OK
< Date: Wed, 14 Sep 2016 12:20:28 GMT
< Server: Apache/2.4.10 (Debian)
< Last-Modified: Thu, 17 Sep 2015 08:13:28 GMT
< ETag: "9a43c-51fecfd6bda00"
< Accept-Ranges: bytes
< Content-Length: 631868
< Access-Control-Allow-Origin: *
< Access-Control-Allow-Headers: Origin, X-Requested-With, Content-Type, Accept, Range
< Content-Type: video/MP2T
<

For hls 0.6 you need to comment out the webworkify and other special hlsjs stuff in the webpack config file and it should work.

On 14 Sep 2016, at 13:21, Leandro Moreira<EMAIL_ADDRESS>wrote:
@paunadeu the point is the same url works when we use hls.js alone http://dailymotion.github.io/hls.js/demo/ .
Reply to this email directly, view it on GitHub, or mute the thread.

Oh and in the webpack config we should be excluding Babel for /node_modules/ as everything in node_modules should be es5. I think this is what's causing the console error you posted before

On 14 Sep 2016, at 13:21, Leandro Moreira<EMAIL_ADDRESS>wrote:
@paunadeu the point is the same url works when we use hls.js alone http://dailymotion.github.io/hls.js/demo/ .
Reply to this email directly, view it on GitHub, or mute the thread.

@tjenkinson thanks hero :) I saw it now https://github.com/dailymotion/hls.js/issues/187

Though I'm gonna leave this open until we move to newer version of hls.js.

And we're also not firing bufferfull for mp4.
Clappr.Log.setLevel(0);
var playerElement = document.getElementById("player-wrapper");

var player = new Clappr.Player({
  source: 'http://clappr.io/highline.mp4',
  baseUrl: '/latest',
  poster: 'http://clappr.io/poster.png',
  mute: true,
  height: 360,
  width: 640
});

player.attachTo(playerElement);

some of the changes in the hls.js 0.6.x  are not backward compatible.
Is it planned to bump the major semver when integrating with the new hls.js?

@mrbar42 we're planning a major bump soon, thanks for the heads up.


Fixes issue with #168 in Free/Busy Generator

The same issue that caused NoInstancesException exceptions thrown elsewhere also existed in the FreeBusy Generator.

@mporcheron Thank you for this PR :-). Is it possible to add tests?

I've added one test; not sure more is needed?

@mporcheron Was this test red before your patch? That's the goal: red before, green after. Also, you can name the test case bug208 for instance.

Yes.

Looks good to me. Sorry for the delay.

:+1:

@mporcheron Nice work: https://www.porcheron.uk/2015/02/12/a-php-based-freebusy-calendar/ ;-).