EKS Secrets Encryption cannot be enabled after cluster creation

What happened?
I had an existing EKS Cluster (with KMS encryption disabled). The Cluster CR was updated to enable encryption by adding a encryptionConfig stanza. e.g.:
apiVersion: eks.aws.crossplane.io/v1beta1
kind: Cluster
...
spec:
  forProvider:
    encryptionConfig:
    - provider:
        keyArn: arn:aws:kms:us-west-2:11111111111111111:key/aaaaaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee
      resources:
      - secrets

After the modification these event warnings started appearing:
  Warning  CannotUpdateExternalResource  3m4s (x55 over 58m)  managed/cluster.eks.aws.crossplane.io  cannot update EKS cluster configuration: InvalidParameterException: Cluster is already at the desired configuration with endpointPrivateAccess: true , endpointPublicAccess: true, and Public Endpoint Restrictions: [<IP_ADDRESS>/0]
And the cluster was Available but not Synced state:
status:
...
  conditions:
  - lastTransitionTime: "2021-12-18T05:09:31Z"
    message: 'update failed: cannot update EKS cluster configuration: InvalidParameterException:
      Cluster is already at the desired configuration with endpointPrivateAccess:
      true , endpointPublicAccess: true, and Public Endpoint Restrictions: [<IP_ADDRESS>/0]'
    reason: ReconcileError
    status: "False"
    type: Synced
  - lastTransitionTime: "2021-12-18T05:09:30Z"
    reason: Available
    status: "True"
    type: Ready

Note that if I create the cluster from scratch with encryptionConfig set, KMS Secret Encryption will be enabled properly. The problem is similar to https://github.com/crossplane/provider-aws/issues/1014 in that updates to an existing EKS cluster do not work, but will work upon creation.
How can we reproduce it?

Create an EKS Cluster without encryptionConfig
Add encryptionConfig and point to KMS Key ARN

What environment did it happen in?
Crossplane version: 1.5.1
aws-provider: 0.22

As in https://github.com/crossplane/provider-aws/issues/1014#issuecomment-997171472, the workaround is to enable encryption manually to match the desired state.

we need to implement
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/eks#Client.AssociateEncryptionConfig currently we have not "update" call for Secrets Encryption

@haarchri is there any plan when this bug will be fixed?


Add implementation of Onsets & Frames for Piano Transcription.

#129 is a first step. Need to correct minor discrepancies and add support for raw audio (vs mel spec).


deprecate(addon-table): *tuiRow deprecation (use *ngFor + tuiTableSort-pipe)

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] The commit message follows Conventional Commits
[ ] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Refactoring
[ ] Code style update
[ ] Build or CI related changes
[X] Documentation content changes

What is the current behavior?
NG0303: Can't bind to 'tuiCellOf' since it isn't a known property of 'td'
(used in the 'AppComponent' component template).
1. If 'td' is an Angular component and it has the 'tuiCellOf' input, then verify that it is a part of an @NgModule where this component is declared.
2. To allow any property add 'NO_ERRORS_SCHEMA' to the<EMAIL_ADDRESS>of this component.

What is the new behavior?
No error
Does this PR introduce a breaking change?

[ ] Yes
[X] No

@splincode @vladimirpotekhin could you review again, please ?


Guard against undefined

Fixes error when actions don't have a payload. Especially with ngrx-store it lead to a first action {type: "@ngrx/store/init"} with a deepfreeze of undefined which ended in an error TypeError: Cannot convert undefined or null to object

@omelhoro yeah, https://github.com/codewareio/ngrx-store-freeze/pull/2 introduced this bug
thx for fast fix, published new version on npm


Add example of running non prefect job to docs

Expectation / Proposal
Traceback / Example

[ ] I would like to help contribute a pull request to resolve this!

Closing due to lack of details


[[CRITICAL]] Bazzite Deck Goes to Black Screen on Boot

As per title, steam deck is booting to black screen. This is a continuation of a prior issue. The proposed solution was to run
rpm-ostree upgrade
I did so at the time however at this time it is again not booting in spite of no other actions taken on my part.

According to @EyeCantCU this is fixed in the latest build, so if you upgrade to :latest it ought to be fine.
If you're still having issues, what worked for me (prior to the build fix) was:

press CTRL-ALT-F2 to bring up a terminal
enter steamos-session-select plasma
You may need to do a CTRL-ALT-F1 to get back to the initial session.
Hit "Return to Game Mode".

This prevented it from happening on subsequent restarts for me. Let us know what worked!

I am having this issue (blank black screen) if logging into a Wayland session on Nvidia (the latest updates added the newest Nvidia driver). X11 appears to be fine however.

According to @EyeCantCU this is fixed in the latest build, so if you upgrade to :latest it ought to be fine.
If you're still having issues, what worked for me (prior to the build fix) was:

press CTRL-ALT-F2 to bring up a terminal
enter steamos-session-select plasma
You may need to do a CTRL-ALT-F1 to get back to the initial session.
Hit "Return to Game Mode".

This prevented it from happening on subsequent restarts for me. Let us know what worked! (If either does!)

I tried since it just happened again (it hadn't happened at all in the intervening month), and got hit with a login screen which didn't respond to the credentials I remember setting up

This also occurs if you run Bazzite in a VMware virtual machine if you don't enable GPU acceleration. Thought I'd share even if the issue is closed.

I'm aware that this is in development for OLED models, but I'm wondering how to get around this.

HDR now works for me but 3D acceleration doesn't. Stardew Valley runs at 30 fps (down from 60+ fps) and no proton games launch. They all complain about missing DirectX drivers. If I switch to GNOME, everything works fine. This is exactly what happened right before HDR stopped working.


#hi

Hello, I'm very interested in your plan, I don't know a lot of things, can you teach me how to operate I see your social work library, it's OK There is a fee Thank you Remember to reply to me Leave me a contact information

Hello, there are no paid plans. If there is a tutorial, there should be a link in the readme. If there is not, there should be no tutorial. You can ask me specific questions. If I can help you, I will do my best.


Update tree-sitter version

This updates the tree-sitter version in this repo from 0.22.4 to 0.22.6. This also adds a meson.build file to the repo so other people can generate a compile_commands.json file

NVM, I think I overlooked a lot of stuff when making this PR.


official README

See Commit Here: https://github.com/ucsb-cs48-w20/fmSynthesizer/commit/5e625466bf236f7fdf6936ef5ed5baba56d63b08


[Bug?] translations get warnings about adding/removing {}

Sometimes translations add or remove a {}, as they need / don't want a newline.
This is currently a warning.
I am unsure if we should allow this behaviour or not, but mostly mentioning that as it is different from eints.
@frosch123 what do you think?

Yes, this is new in nile.
Translators are supposed to not change the general formatting of strings, like colours, fonts, special icons, ...
I included "new line" into this rule.
I have some stashed/unfinished validations, which check whether each command (like {NUM}) is printed with the same colour in the translation as in the base language. The same check would also validate that the same info is on the same line.
Time will tell, whether there are valid reasons for translations to differ.

Okiedokie. Maybe we should write down these changes, as to inform translators of that during eints -> nile transition. Just so they understand why now all of a sudden it is an issue :)
On the positive side, it does show one string in both Dutch and German that is wrong. As in, they only translated the first line, never the second :)


Filament + Vuforia

I am trying to use Filament together with Vuforia on Android but I'm experiencing some issues.
As far as I understand Vuforia is using a GLSurfaceView to render its stuff into a GL texture.
I would like to take that texture and use it with Filament to draw it as the background of the Surface and then add some models on top of it based on the anchors that I'm getting back from Vuforia.
It looks like Filament needs to run on the main thread when rendering so I wonder if there's a way to share the GL context or if there's any differe way to handle this use-case.
My current implementation is just using one GLSurfaceView and on its GLThread there's Vuforia rendering the texture. Then I have a Choreographer that is attached to that surface and I'm trying to render from there but it's crashing badly.

The way to do this properly on Android is to use a SurfaceTexture and have Vuforia (or any other producer) render into the SurfaceTexture's Surface. If Vuforia forces you to go through a GLSurfaceView (and it shouldn't), you're out of luck.
Filament does not need to run on the main thread. You can use any thread you want as long as it's always the same thread (and Filament is heavily multi-threaded internally, rendering actually happens on a separate thread).

If you check the Android sample coming from Vuforia, they are using the GLSurfaceView https://gist.github.com/tanis2000/8a8079839ae38627abf2811d767e4207#file-vuforiaactivity-kt-L34 and under the hood the C++ controller is creating a GL render texture and passing around it's id so that their GL renderer can reference that texture https://gist.github.com/tanis2000/02ae3b63f122aa12e8041cf12731a628#file-appcontroller-cpp-L338
Or at least that's what I'm guessing as the library sources are closed source.
I believe that your proposed flow would be like:

create a new GL texture from within Filament's GL context
create a new SurfaceTexture from the texture id that I get back from Filament
create a new Surface from the SurfaceTexture
feed the Surface to Vuforia

but maybe it's even easier to just do this from within the C++ part as Vuforia is mainly a C++ library and all of the heavy lifting is already done there. What I'm not sure about is how Vuforia renders the camera feed to that texture...

You don't need to create the SurfaceTexture from within Filament's GL context. And actually our APIs don't let you do this, because Filament doesn't assume it's using OpenGL. The SurfaceTexture can be created outside of Filament.
Alternatively, can Vuforia just give you the camera stream? That's how ARCore works and we simply pass the camera stream's SurfaceTexture to Filament for rendering.

I'm not an expert with Vuforia, I've just started having a look at it so I'm diving through the scarse documentation that I could find around the net.
According to the lifecycle page https://library.vuforia.com/content/vuforia-library/en/reference/cpp/index.html#Lifecycle there is a CameraDevice class that is bound to the hardware camera https://library.vuforia.com/content/vuforia-library/en/reference/cpp/classVuforia_1_1CameraDevice.html but I can't see any method to get the stream out of that thing. Indeed that would have been handy.

@tanis2000, do we need to keep this issue open?  Is there a Filament feature that would help you with this integration?

@prideout I guess you can close this. Integrating Vuforia with Filament is painful and it looks like the best chance is to actually read the NV21 image from its internal array of images and perform the conversion in a shader (Filament's material?) and then apply it to a plane but it's a stretch.
Unfortunately Vuforia's documentation is lacking.


[Documentation] Fix typos and broken links

Purpose
Fix and improve the documentation.
Changes
Fixes of several typos and broken links. Additionally, the styling in some files were improved to match the rest of the documentation.
Tests
This does not apply to the changes in this PR.
Feature Plan
There are not any remaining steps left.
Checklist
General

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have added or updated the appropriate tests
[x] I have updated related documentation

Bots

[ ] I have validated that new and updated responses use appropriate Speak and InputHint properties to ensure a high-quality speech-first experience
[ ] I have replicated language model changes across the English, French, Italian, German, Spanish, and Chinese .lu files and validated that deployment is successful

Deployment Scripts

[ ] I have replicated my changes in the Virtual Assistant Template and Sample projects
[ ] I have replicated my changes in the Skill Template and Sample projects

Also, could you check the documents that have some reference to Botskills? As some have some misleading information, i.e. in the tutorial on adding a Skill to the VA the command described is using the parameter --cs but this is a TypeScript tutorial, it should be using --ts instead.


Add rama-pang's project portfolio page

Codecov Report
Base: 72.15% // Head: 72.15% // No change to project coverage :thumbsup:

Coverage data is based on head (6d413e5) compared to base (0eacbb1).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #76   +/-   ##
=========================================
  Coverage     72.15%   72.15%
  Complexity      399      399
=========================================
  Files            70       70
  Lines          1232     1232
  Branches        125      125
=========================================
  Hits            889      889
  Misses          311      311
  Partials         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[3.3] I want to use cookies with response_calls

hello.
I would like to make it possible to use cookies by setting as follows
apidoc.php
            'apply' => [
                'headers' => [
                ],

                'response_calls' => [
                    'methods' => ['GET'],

.........

                    'cookies' => [
                        'key' => 'value',
                        'aaa' => 'bbb',
                    ],
                ],
            ],

hello.
I created a pull request on this subject. Please approve it when there is no problem.
https://github.com/mpociot/laravel-apidoc-generator/pull/470

Closed in #471


Zip code

Hi there
Most of the coutries shows error because of zip code but 100% sure that this zip code is correct
Any idea please

Hi,
If you can show some examples of the coutry code and how you passing it and also what is the response you are getting would be helpful.
Anyway, there are alot of bugs in their endpoint that i faced and haven't solved yet, So here is a quick solution, you can either dont pass it (if its not required then it will be alright) or you can pass this string "00000", anyway this is not recommended but if you are on dev or test environment this will help you.
Thanks

Thanks for the quick reply
Please check the links below for full request details
https://paste.ofcode.org/sEwZFiGQpGPj3whG5zMyHN
https://paste.ofcode.org/ju4cJ8rv5BE2iCuzDGMhr7

You're right, it's confusing, but anyway, this error is actually from Aramex's side maybe they don't have this city on their end, or maybe they didn't match the zip code with the city.
Anyway here's an advice, you can call the fetchCities method and make sure that this city is supported or not, and ignore the Zipcode in validateAddress method.
I wish I could help you, but there is nothing I can do because this error is not from my end, anyway I will keep this issue open for the community hoping someone could find out the actual reason behind their issue.

Hello,
I am already gettting cities list based on country using fetchCities method also the zipcode is required in validateAddress method , I attached the response without zip code. it's displaying error message "Address - Invalid Zipcode" , so it's look like zip code is required in validateAddress method.
Sample Code :
$validateAddress = Aramex::validateAddress([
'line1' => 'Av. Gaspar de Villarroel E3-83, Quito 170513, Ecuador',
'country_code' => 'EC',
'city' => 'Quito',
]);
dd($validateAddress);

Yes, it is required, but sometimes when you don't pass the zipcode, they accept the request especially for the countries which has areas that don't have a zip code. like UAE for example, this country doesn't have a zip code, so you either pass 00000 as a zip code or you can pass zip code as an empty string (not 100% percent sure), but anyway in all cases, those errors are sent by their end as a response for the APIs calls from the SDK.
I hope this helps you.

Does it work in the localhost ?
when I use rate calculator, I am getting as below
SoapFault SOAP-ERROR: Parsing WSDL: Couldn't load from '<?xml version="1.0" encoding="utf-8"?><wsdl:definitions name="Service_1_0" targetNamespace="http://ws.aramex.net/ShippingAPI/v1/" xmlns:wsdl="http://schemas.xmlsoap.org/wsdl/" xmlns:wsam="http://www.w3.org/2007/05/addressing/metadata" xmlns:wsx="http://schemas.xmlsoap.org/ws/2004/09/mex" xmlns:wsap="http://schemas.xmlsoap.org/ws/2004/08/addressing/policy" xmlns:msc="http://schemas.microsoft.com/ws/2005/12/wsdl/contract" xmlns:wsp="http://schemas.xmlsoap.org/ws/2004/09/policy" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:soap="http://schemas.xmlsoap.org/wsdl/soap/" xmlns:wsu="http://docs.oasis-open.org/wss/2004/01/oasis-200401-wss-wssecurity-utility-1.0.xsd" xmlns:soap12="http://schemas.xmlsoap.org/wsdl/soap12/" xmlns:soapenc="http://schemas.xmlsoap.org/soap/encoding/" xmlns:tns="http://ws.aramex.net/ShippingAPI/v1/" xmlns:wsa10="http://www.w3.org/2005/08/addressing" xmlns:wsaw="http://www.w3.org/2006/05/addressing/wsdl" xmlns:wsa="http://schemas.xmlsoap.or


[GraphX] Add scalatest maven plugin to enable automated testing

Somewhere in the build process rehaul the automated execution of GraphX tests stopped working. This PR adds a maven plugin to run Scala unit tests.

Refer to this link for build results (access rights to CI server needed):
http://jenkins.tribler.org//job/Graphalytics_pull_request_tester/28/
Test PASSed.


changed brakes.txt to embrakes.txt in config.txt

Description
Changed brakes.txt to embrakes.txt in config.txt to match file name

Codecov Report

Merging #87 (e90283d) into master (14967ed) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   30.51%   30.64%   +0.12%
==========================================
  Files          71       72       +1
  Lines        3729     3766      +37
==========================================
+ Hits         1138     1154      +16
- Misses       2591     2612      +21

Impacted Files
Coverage Δ

src/utils/timer.hpp
0.00% <0.00%> (ø)

src/propulsion/rpm_regulator.cpp
0.00% <0.00%> (ø)

src/utils/timer.cpp
33.33% <0.00%> (+4.76%)
:arrow_up:

src/utils/logger.cpp
51.28% <0.00%> (+7.73%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14967ed...e90283d. Read the comment docs.


Support storing bytes

Hi, thank you for this package.
When trying to store byte-string:
dbm.store(b"key2", b"binary vale", mdbm.MDBM_INSERT)
I get following error:
mdbm.Error: Error - There was a missing parameter: key and value from  here.
It would be good if byte-strings were supported too.

Hi @dvzubarev
I will take this issue. (too late)

Hi @dvzubarev
Support the Byte Key and Value on Now.
Let me know if you find any issues.
Plz feel free~

Hi @dvzubarev
I was add byte storing feature
Could you plz check up laster version?
if you have any issue, plz feel free raise issue

Hi, Thank you for working on this!
I used my fork as workaround for some time in my project. I will switch to the latest version, when start working on this project again. But it may take some time. Thank you again.

Hi, @dvzubarev
it's my pleasure.
If you have any questions or concerns, don’t hesitate to let me know.
Thanks & Best regards.


Clarify a line in asm code

41-32 is 9, and that's the bit for SSSE3, so add a comment clarifying that that's what we're testing.
Don't need to believe me. crypto/sha/asm/sha1-x86_64.pl:263 performs the same check, and has a comment.

I figured the title might come off as rude, it's purely intended as a joke

41 is reference to doc/man3/OPENSSL_ia32cap.pod. And 32 is instruction encoding artefact, as you can't encode 1<<41 with 'test' instruction. Yes, it's used inconsistently, but it's only a reflection of the fact that things were not written on same day. In addition there is certain inertia originating in desire to keep deviations between branches to minimum. I mean if we apply this which branches do we apply it to? Well, in this case it's simpler, because affected module is present only in two branches, but question also is if other projects would have to pick it up? In other words aesthetic modifications are not directly prioritized... As for lack of comment, following branch is obviously explanatory. I'm not saying that comment would be meaningless, but it is subject to same inertia thing...
Even though it's not strictly "minus-one" I'm kind of reluctant to apply this. Maybe we can cut a deal of following nature. Examine the code, see if there are other places where you would appreciate a comment from me, I'll add comment and throw in this additional one. In general problem with comments is that I fail to recognize which comment would be most helpful, as things appear to obvious to me...

I was interested in making things consistent.
No problem either way, next time I'll poke around I'll look for places where such changes are more significant.

I was interested in making things consistent.

I totally understand and do appreciate this. At the same time it kind of asks for direction :-) I.e. would it be more appropriate to replace 41-32 with 9 here or 9 with 41-32 elsewhere? Provided that 41 is reference to local documentation...

Ping

Based on @dot-asm 's reluctance to do it.


RDK-43929 New Resoultion update from playerinfo and Displaysetting

New Resoultion update from playerinfo and Displaysetting 600p, 768p, 3840x1080

Closing older PRs. Pls bring it to latest sprint/main branches if required.


Runnable throwing faulty error

As reported by @schmittberger
This update does resolve the issue

Hi, if I am not mistaken, the electron architecure does not allow access outside the sandox within the renderer process. You have to use the ipc messaging to call a function in the main process.


Include Summary statistics

Averages by year, level, interviewer etc. have ways to mark if a person did a question. Get rid of bonuses.

Closing due to duplication in #7.


Run the db seed command after a successful db migration

I tested this in the ephemeral env and it appears to work.


pylxd version conflicts

I installed old version the pylxd which is 2.2.10 and verified it on my system. Now when I run any function It throw errors that this is not available in pylxd.
doing:
import pylxd
import json

cert=('/home/myuser/xxxxxyyyyzzzz.crt', '/home/myuser/xxxxxyyyyzzzz.key')

try:
    client = pylxd.Client(endpoint='https://lxd-host.com:8443', cert=cert, verify=False)
    instance = client.instances.get('testirtaza1')
    addresses = instance.state().network['eth0']['addresses']
    addresses[0]
except pylxd.exceptions.ClientConnectionFailed as e:
    print(f"Connection to LXD failed: {e}")
except pylxd.exceptions.LXDAPIException as e:
    print(f"Error calling LXD API: {e}")

Error:
Traceback (most recent call last):
File "/home/xxxxxyyyyzzzz/python/test.py", line 8, in
instance = client.instances.get('testirtaza1')
AttributeError: 'Client' object has no attribute 'instances'

2.2.10 is too old to know about instances, it only knows about containers: https://github.com/lxc/pylxd/tree/2.2.10/pylxd/models

@simondeziel Like will this issue be fix if I update the pylxd?

AttributeError: 'Client' object has no attribute 'instances' should indeed be resolved with a newer version.


Again this forge issue

So well, you did already had many posts about this issue. But I WANT THIS TO GET FIXES, PLEAAASE.
What I mean? When an 1.8 Forge Client connects to my 1.7/1.8 protocol hack server, all 1.7 clients get kicked...
Why? Cause forge send Packets which the server/1.7client can't handle.. Disabling forge support in config does not help either.. Isn't it possible to stop forge packets from sending to players when forge support is turned off? Thats all it would take to stopp it..
Why I know? Some Hack clients have an option to hide forge, that means it stops sending forge packets to the server.. And all of a sudden.. it works.
If possible, please please do fix this, it would not only help me..

This is not a waterfall issue, nor is their anything we can do about the client sending invalid data for the version of mc you're running when using hacks to allow them to connect.

Then I would like to know, why this is not happening on the default BungeeCord 1.7/1.8 version.
Cause I dont see a problem there.

Since the 1.7/1.8 versions of bungee, there have been several hundred commits to the project, I couldn't say why it would work there and not here
But, ultimately, protocol hacks are unsupported, we have no interest in trying to diagnose and deal with issues, especially when they're not being triggered on our software, both individual versions work
If somebody wants to spend the time to investigate the issue or submit a PR, we'll be more than happy to look over it, but this isn't something we're willing to invest our time in


[SPARK-41140][SQL] Rename the error class _LEGACY_ERROR_TEMP_2440 to INVALID_WHERE_CONDITION

What changes were proposed in this pull request?
In the PR, I propose to assign the proper name INVALID_WHERE_CONDITION  to the legacy error class _LEGACY_ERROR_TEMP_2440 , and modify test suite to use checkError() which checks the error class name, context and etc. Also this PR improves the error message.
Why are the changes needed?
Proper name improves user experience w/ Spark SQL.
Does this PR introduce any user-facing change?
Yes, the PR changes an user-facing error message.
How was this patch tested?
By running the modified tests:
$ build/sbt "test:testOnly *AnalysisErrorSuite"
$ PYSPARK_PYTHON=python3 build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite"

@srielau @cloud-fan @LuciferYang @panbingkun @itholic Please, review this PR.

Merging to master. Thank you, @LuciferYang @cloud-fan @srielau @itholic for review.


Corrections to spelling and punctuation

Fixes
Checklist

[x] I have made a material change to the repo (functionality, testing, spelling, grammar)
[x] I have read the [Contribution Guide] and my PR follows them.
[x] I updated my branch with the master branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation about the functionality in the appropriate .md file
[ ] I have added inline documentation to the code I modified

Short description of what this PR does:

Corrections to spelling, capitalisation and punctuation for the sake of clarity and style consistency.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

Hm, I tried git pull and git pull --rebase but it's saying I'm up to date with master and can't seem to get at these merge conflicts. Is it something I have access to?


feat(prisma): upgrade to v5.15.0

Hi,
Would it be possible to bump the version to v5.15.0 as there is the benefit of the below preview feature that will help organise folders.
generator client {
  provider        = "prisma-client-js"
  previewFeatures = ["prismaSchemaFolder"]
}

Prisma recently released v5.17.0 to address some performance issues.
It'd be nice to get that version in the PY client as well.

v0.14.0 has been released which bumps the prisma version to v5.17.0!


fix(clippy): resolve various clippy warnings

Motivation
Clippy has some new warnings on nightly, and we also have some warnings in CI on non-linux platforms.
Depends-On: #4483
Solution
Potential performance/locking changes:

move cached root dereference earlier, so the lock isn't held for the entire match statement

Trivial changes:

fix unused import warning on non-linux platforms
derive Eq where we already derive PartialEq

We should run all the tests to check for any breaking changes.
Review
This PR is a low priority.
Reviewer Checklist

[ ] Tests for Expected Behaviour
[ ] Tests for Errors

time="2022-05-24T11:42:06Z" level=error msg="error waiting for container: unexpected EOF" errors, retrying...
https://github.com/ZcashFoundation/zebra/runs/6570363128?check_suite_focus=true
https://github.com/ZcashFoundation/zebra/runs/6570363511?check_suite_focus=true

time="2022-05-24T11:42:06Z" level=error msg="error waiting for container: unexpected EOF" errors, retrying...
https://github.com/ZcashFoundation/zebra/runs/6570363128?check_suite_focus=true https://github.com/ZcashFoundation/zebra/runs/6570363511?check_suite_focus=true

@gustavovalverde are we accidentally deleting the wrong machines again?
This looks similar to #3991.

@teor2345 that was a manual deletion from GCP, not related to the pipeline. This PR had over 8 VMS running at the same time.
This issue was fixed with https://github.com/ZcashFoundation/zebra/commit/9335f68409f5616606e0dde7dc05205999cd7d0b

@mergifyio update

@Mergifyio update


Ligatures

https://github.com/tonsky/FiraCode https://github.com/i-tu/Hasklig
text-rendering:optimizeLegibility
/* Fira Code */
.CodeMirror{text-rendering: optimizeLegibility;font-family:'Fira Code'!important;}

Also https://github.com/polo2ro/firacode-in-brackets/blob/master/main.js

Someday

Had a show around the office. Definitely can't be the default. E.g. some text :

Might give the wrong impression. Of course these things can be worked around but I prefer the styling of the default monospace = (single equals) and e.g. return as well (rounded and merges nicely with the rest of our UI):


Record from browser

Is your feature request related to a problem? Please describe.
Modern browsers support sharing screen and camera. This can be used to record a lecture as well. We should support this to overcome the hurdle of installing and learning software like obs
Additional context
@CommanderStorm in case someone asks: this is a wip.

For other people: I am talking about a feature like https://opencast.org/features/ has


additional configuration required to run 'make build'

make build gave me an error that phar.readonly is "On" in php.ini.
After looking into my php.ini (/etc/php5/cli/php.ini) i noticed
;phar.readonly = On
As you can see its commented, so On seems to be the default behavior as well.
Setting it to Off and uncommenting it solved the issue for me.

thanks, i added this to the docs
https://github.com/sensiolabs-de/deptrac/commit/23230a1908ed6dfef91bd64392eed4bce380622b


timeout expired waiting for volumes to attach or mount

What happened:
Mounting manually on the host works fine.
Creating the example pod results in:

Unable to mount volumes for pod "nginx-flex-smb_production-floor(4c94b5c5-f415-11e9-af76-d485646b06e2)": timeout expired waiting for volumes to attach or mount for pod "production-floor"/"nginx-flex-smb". list of unmounted volumes=[test]. list of unattached volumes=[test default-token-gn6d7]

docker logs kubelet:

E1021 17:12:03.469239    2697 desired_state_of_world_populator.go:311] Failed to add volume "flexvol-mount" (specName: "pv-smb-flexvol") for pod "54a7abf0-f40e-11e9-aa6c-984be1008bfe" to desiredStateOfWorld. err=failed to get Plugin from volumeSpec for volume "pv-smb-fl
exvol" err=no volume plugin matched

Environment:

Kubernetes version (use kubectl version): Server Version: version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.6", GitCommit:"96fac5cd13a5dc064f7d9f4f23030a6aeface6cc", GitTreeState:"clean", BuildDate:"2019-08-19T11:05:16Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}

OS (e.g. from /etc/os-release): Ubuntu 18.04

Kernel (e.g. uname -a): 5.0.0-31

Install tools: Rancher

it said: no volume plugin matched
have you installed smb plugin by:
https://github.com/Azure/kubernetes-volume-drivers/tree/master/flexvolume/smb#option1-automatically-install-by-k8s-daemonset
Note: You may replace /etc/kubernetes/volumeplugins with /usr/libexec/kubernetes/kubelet-plugins/volume/exec/(by default) in install-smb-flexvol-ubuntu.sh if it's not a Kubernetes cluster created by AKS or aks-engine

Thanks for your reply, replacing the directory for volumeplugins did the trick.


Error in test_interpolate_obscollection

See https://github.com/ArtesiaWater/hydropandas/actions/runs/8646922293/job/23707269646

fixed with https://github.com/ArtesiaWater/hydropandas/commit/368e61555ffd4e40062fc35463fbd706bcefff06


fix(shared): pouchdb auth - add skip_setup flag

Fixes #2256
Changes proposed in this pull request:

Add skip_setup flag to PouchDB instances creation

Newly added dependencies with Bundlephobia links:
NONE

Hi @blestab , When using a fresh browser, I still see the popup:

@blestab and @morrme can confirm I also get the issue.

Thank you both, i'll try see what else i could be missing

@blestab still getting the issue with Chrome & Incognito

Still getting it too, new browser/private tab

Thanks @jackcmeyer @morrme, I think now i need to understand how the vercel/staging/live environments are built i.e. whether the nginx/couchdb config info is actually being used at all to build these environments.

@morrme @jackcmeyer
@tehKapa helped me update the couchDB config based on the ini changes in this PR. May you test for me if the popup is still coming up for you,  I want to determine if we maybe need to force a rebuild of the vercel deployment.

NO popup for me! 🎊


dpdk-ans is slower than regular Linux epoll with 100Gbit\s

I've been converting iperf3 to use DPDK instead of the Linux networking stack.
However when running it normally it can get ~40Gbit/s en when using the dpdk-ans version it can only achieve ~4Gbit/s.
The source code which uses regular epoll can be found here: https://github.com/JelteF/iperf/tree/epoll
And the code for the ANS version here: https://github.com/JelteF/iperf/tree/ans
Do you have any suggestions on how to improve the performance?

We could also discuss this on Slack if you could send me an invite. My email is in my profile.

TCP performance or UDP performance?
please share your test steps.
please share ANS startup logs.

TCP or UDP?
It's about TCP performance, I haven't gotten UDP working yet.
Test steps
There is a client and a server machine (these can also be the same machine if two interfaces are connected to eachother). Most of the steps are the same for both machines if they are different I will explain.

Install DPDK and ANS and start ANS and set the $RTE_ variables
Install and compile the repo:

git clone https://github.com/JelteF/iperf
cd iperf/src
git checkout ans
make

On the server machine start the server like this:

sudo build/iperf3 -s --bind <ip-of-the-interface>

On the client machine start the client like this:

sudo build/iperf3 -c <ip-of-the-server>

It will end in a crash, but that is not important, you will see the speed anyway.

Do the same test with regular epoll

Turn off ANS
Install and compile the repo

git clone https://github.com/JelteF/iperf iperf-epoll
cd iperf-epoll
git checkout epoll
./configure
make

Run the client and the server again

src/iperf3 -s --bind <ip-of-the-interface>
src/iperf3 -c <ip-of-the-server>

ANS startup logs
Only port one (<IP_ADDRESS>) is actually connected. On the
root@ps1 /home/jelte/dpdk-ans ans/build/ans -c 0x3 -n3  -- -p=0x1 --config="(0,0,0),(1,0,1)"
EAL: Detected lcore 0 as core 0 on socket 0
EAL: Detected lcore 1 as core 1 on socket 0
EAL: Detected lcore 2 as core 2 on socket 0
EAL: Detected lcore 3 as core 3 on socket 0
EAL: Detected lcore 4 as core 0 on socket 0
EAL: Detected lcore 5 as core 1 on socket 0
EAL: Detected lcore 6 as core 2 on socket 0
EAL: Detected lcore 7 as core 3 on socket 0
EAL: Support maximum 128 logical core(s) by configuration.
EAL: Detected 8 lcore(s)
EAL: Setting up physically contiguous memory...

PMD: librte_pmd_mlx5: 0xdebdc0: TX queues number update: 0 -> 2
PMD: librte_pmd_mlx5: 0xdebdc0: RX queues number update: 0 -> 1
	 MAC Address:E4:1D:2D:C0:88:AA
	 Deault-- tx pthresh:0, tx hthresh:0, tx wthresh:0, txq_flags:0x0
	 lcore id:0, tx queue id:0, socket id:0
	 Conf-- tx pthresh:36, tx hthresh:0, tx wthresh:0, txq_flags:0xfffff1ff
	 Deault-- tx pthresh:0, tx hthresh:0, tx wthresh:0, txq_flags:0x0
	 lcore id:1, tx queue id:1, socket id:0
	 Conf-- tx pthresh:36, tx hthresh:0, tx wthresh:0, txq_flags:0xfffff1ff

	 port 1:
	 port name librte_pmd_mlx5:
	 max_rx_queues 65535: max_tx_queues:65535
	 rx_offload_capa 14: tx_offload_capa:15
	 Creating queues: rx queue number=1 tx queue number=2...
PMD: librte_pmd_mlx5: 0xdefe08: TX queues number update: 0 -> 2
PMD: librte_pmd_mlx5: 0xdefe08: RX queues number update: 0 -> 1
	 MAC Address:E4:1D:2D:C0:88:AB
	 Deault-- tx pthresh:0, tx hthresh:0, tx wthresh:0, txq_flags:0x0
	 lcore id:0, tx queue id:0, socket id:0
	 Conf-- tx pthresh:36, tx hthresh:0, tx wthresh:0, txq_flags:0xfffff1ff
	 Deault-- tx pthresh:0, tx hthresh:0, tx wthresh:0, txq_flags:0x0
	 lcore id:1, tx queue id:1, socket id:0
	 Conf-- tx pthresh:36, tx hthresh:0, tx wthresh:0, txq_flags:0xfffff1ff

Allocated mbuf pool on socket 0, mbuf number: 16384

Initializing rx queues on lcore 0 ...
Default-- rx pthresh:0, rx hthresh:0, rx wthresh:0
port id:0, rx queue id: 0, socket id:0
Conf-- rx pthresh:8, rx hthresh:8, rx wthresh:4

Initializing rx queues on lcore 1 ...
Default-- rx pthresh:0, rx hthresh:0, rx wthresh:0
port id:1, rx queue id: 0, socket id:0
Conf-- rx pthresh:8, rx hthresh:8, rx wthresh:4
core mask: 3, sockets number:1, lcore number:2
start to init ans
USER8: LCORE[0] lcore mask 0x3
USER8: LCORE[0] lcore id 0 is enable
USER8: LCORE[0] lcore id 1 is enable
USER8: LCORE[0] lcore number 2
USER1: rte_ip_frag_table_create: allocated of 25165952 bytes at socket 0
USER8: LCORE[0] UDP layer init successfully, Use memory:4194304 bytes
USER8: LCORE[0] TCP hash table init successfully, tcp pcb size 448 total size 29360128
USER8: LCORE[0] TCP hash table init successfully, tcp pcb size 448 total size 29360128
USER8: LCORE[0] so shm memory 16777216 bytes, so number 131072,  sock shm size 128 bytes
USER8: LCORE[0] Sock init successfully, allocated of 41943040 bytes
add eth0 device
USER8: LCORE[0] Interface eth0 if_capabilities: 0xf
add IP 1020202 on device eth0
add eth1 device
USER8: LCORE[0] Interface eth1 if_capabilities: 0xf
add IP 1020203 on device eth1
Show interface

eth0	HWaddr e4:1d:2d:c0:88:aa
		inet addr:<IP_ADDRESS>
		inet addr:<IP_ADDRESS>

eth1	HWaddr e4:1d:2d:c0:88:ab
		inet addr:<IP_ADDRESS>
		inet addr:<IP_ADDRESS>
add static route

Destination		Gateway		Netmask			Flags		Iface
<IP_ADDRESS>		*		<IP_ADDRESS>		U C 		0
<IP_ADDRESS>		*		<IP_ADDRESS>		U H L 		0
<IP_ADDRESS>		*		<IP_ADDRESS>		U C 		1
<IP_ADDRESS>		<IP_ADDRESS>		<IP_ADDRESS>		U G 		0

USER8: LCORE[-1] ANS mgmt thread startup
Checking link status done
Port 0 Link Up - speed 100000 Mbps - full-duplex
Port 1 Link Up - speed 0 Mbps - full-duplex
USER8: main loop on lcore 1
USER8:  -- lcoreid=1 portid=1 rxqueueid=0
nb ports 2 hz:<PHONE_NUMBER>
USER8: main loop on lcore 0
USER8:  -- lcoreid=0 portid=0 rxqueueid=0
nb ports 2 hz:<PHONE_NUMBER>

Startup logs of iperf ans:
jelte@ps1 ~/iperf/src sudo build/iperf3 -s --bind <IP_ADDRESS>
EAL: Detected lcore 0 as core 0 on socket 0
EAL: Detected lcore 1 as core 1 on socket 0
EAL: Detected lcore 2 as core 2 on socket 0
EAL: Detected lcore 3 as core 3 on socket 0
EAL: Detected lcore 4 as core 0 on socket 0
EAL: Detected lcore 5 as core 1 on socket 0
EAL: Detected lcore 6 as core 2 on socket 0
EAL: Detected lcore 7 as core 3 on socket 0
EAL: Support maximum 128 logical core(s) by configuration.
EAL: Detected 8 lcore(s)
EAL: Setting up physically contiguous memory...
EAL: Analysing 1024 files
EAL: Mapped segment 0 of size 0x7f000000
EAL: Mapped segment 1 of size 0x400000
EAL: Mapped segment 2 of size 0x400000
EAL: Mapped segment 3 of size 0x200000
EAL: Mapped segment 4 of size 0x200000
EAL: Mapped segment 5 of size 0x200000
EAL: Mapped segment 6 of size 0x200000
EAL: memzone_reserve_aligned_thread_unsafe(): memzone <RG_MP_log_history> already exists
RING: Cannot reserve memory
EAL: TSC frequency is ~3700000 KHz
EAL: Master lcore 0 is ready (tid=f7fed8a0;cpuset=[0])
USER8: LCORE[-1] anssock any lcore id 0xffffffff
USER8: LCORE[2] anssock app id: 5380
USER8: LCORE[2] anssock app name: iperf3
USER8: LCORE[2] anssock app bind lcoreId: 0
USER8: LCORE[2] anssock app bind queueId: 0
USER8: LCORE[2] anssock app lcoreId: 2
-----------------------------------------------------------
Server listening on 5201
-----------------------------------------------------------

Please do below action to improve dpdk performance. These tips have been updated to the readme.
in order to improve ANS performance, you shall isolate ANS'lcore from kernel by isolcpus and isolcate interrupt from ANS's lcore by update /proc/irq/default_smp_affinity file.
Don't run ANS on lcore0, it will effect ANS performance.

Why the second NIC speed is 0. but maybe it wouldn't effect the iperf testing.
Port 1 Link Up - speed 0 Mbps - full-duplex

One tcp connection traffic  are  only handled in one lcore. but in linux kernel many lcore handle it.
ANS still didn't support TSO, linux kernel support it, maybe these are the major reason.

please share the iperf output here. thanks.

To not run ANS on lcore0 I should use an even number for -c option right?
Do I need to set the opposite of my -c option in /proc/irq/default_smp_affinity? So for instance -c 0xe and then

The second NIC does not have a cable connected to it, so it is not used by iperf.

3/4. I will try to disable TSO in linux and share my results.

I sent a invite to you in slack.com.

Thanks, I accepted it and sent a question there already.

I have machines with 8 lcores. I have set isolcpus=0,1,2,3 as boot parameter. Also I changed /proc/irq/default_smp_affinity to f0.
I now get a reliable throughput with both regular Linux and ANS throughput. I ran tests with all offloading disabled an with everything enabled.
USER8: LCORE[0] anssock app lcoreId: 0
Connecting to host <IP_ADDRESS>, port 5201
[ 17] local :: port 2496 connected to :: port 20756
[ ID] Interval           Transfer     Bandwidth       Retr  Cwnd
[ 17]   0.00-1.00   sec   580 MBytes  4.87 Gbits/sec<PHONE_NUMBER>   0.00 Bytes
[ 17]   1.00-2.00   sec   581 MBytes  4.87 Gbits/sec    0   0.00 Bytes
[ 17]   2.00-3.00   sec   581 MBytes  4.87 Gbits/sec    0   0.00 Bytes
[ 17]   3.00-4.00   sec   580 MBytes  4.87 Gbits/sec    0   0.00 Bytes
[ 17]   4.00-5.00   sec   580 MBytes  4.86 Gbits/sec    0   0.00 Bytes
[ 17]   5.00-6.00   sec   581 MBytes  4.87 Gbits/sec    0   0.00 Bytes
[ 17]   6.00-7.00   sec   580 MBytes  4.87 Gbits/sec    0   0.00 Bytes
[ 17]   7.00-8.00   sec   580 MBytes  4.87 Gbits/sec    0   0.00 Bytes
[ 17]   8.00-9.00   sec   581 MBytes  4.87 Gbits/sec    0   0.00 Bytes

Tests with offloading on
Linux:
jelte@ps2 ~/iperf-epoll src/iperf3 -c <IP_ADDRESS> -A 2,2 -t 10
Connecting to host <IP_ADDRESS>, port 5201
[  5] local <IP_ADDRESS> port 38140 connected to <IP_ADDRESS> port 5201
[ ID] Interval           Transfer     Bandwidth       Retr  Cwnd
[  5]   0.00-1.00   sec  3.21 GBytes  27.6 Gbits/sec   60    822 KBytes
[  5]   1.00-2.00   sec  3.21 GBytes  27.5 Gbits/sec   13    932 KBytes
[  5]   2.00-3.00   sec  3.21 GBytes  27.6 Gbits/sec   16   1.00 MBytes
[  5]   3.00-4.00   sec  3.21 GBytes  27.6 Gbits/sec   13   1.09 MBytes
[  5]   4.00-5.00   sec  3.21 GBytes  27.5 Gbits/sec   16   1.16 MBytes
[  5]   5.00-6.00   sec  3.21 GBytes  27.5 Gbits/sec   21   1.25 MBytes
[  5]   6.00-7.00   sec  3.21 GBytes  27.5 Gbits/sec   15   1.32 MBytes
[  5]   7.00-8.00   sec  3.21 GBytes  27.5 Gbits/sec   30    748 KBytes
[  5]   8.00-9.00   sec  3.21 GBytes  27.5 Gbits/sec   18    846 KBytes

ANS:
jelte@ps2 ~/iperf/src sudo build/iperf3 -c <IP_ADDRESS>  -A 2,2
EAL: Detected lcore 0 as core 0 on socket 0
EAL: Detected lcore 1 as core 1 on socket 0
.........
USER8: LCORE[0] anssock app lcoreId: 0
Connecting to host <IP_ADDRESS>, port 5201
[  8] local :: port 960 connected to :: port 20756
[ ID] Interval           Transfer     Bandwidth       Retr  Cwnd
[  8]   0.00-1.00   sec   580 MBytes  4.87 Gbits/sec<PHONE_NUMBER>   0.00 Bytes
[  8]   1.00-2.00   sec   580 MBytes  4.86 Gbits/sec    0   0.00 Bytes
[  8]   2.00-3.00   sec   579 MBytes  4.86 Gbits/sec    0   0.00 Bytes
[  8]   3.00-4.00   sec   579 MBytes  4.86 Gbits/sec    0   0.00 Bytes
[  8]   4.00-5.00   sec   580 MBytes  4.86 Gbits/sec    0   0.00 Bytes
[  8]   5.00-6.00   sec   579 MBytes  4.86 Gbits/sec    0   0.00 Bytes
[  8]   6.00-7.00   sec   579 MBytes  4.85 Gbits/sec    0   0.00 Bytes
[  8]   7.00-8.00   sec   579 MBytes  4.86 Gbits/sec    0   0.00 Bytes
[  8]   8.00-9.00   sec   579 MBytes  4.86 Gbits/sec    0   0.00 Bytes

Results
As you can see in both tests ANS has about the same throughput and in both cases it is lower than for Linux. Although when offloading is enabled this difference is a lot larger.

When jumbo frames are enabled (MTU=9000) the normal Linux kernel has even more performance and it gets around ~43Gbit/s:
jelte@ps2 ~/iperf-epoll src/iperf3 -c <IP_ADDRESS> -A 2,2
Connecting to host <IP_ADDRESS>, port 5201
[  5] local <IP_ADDRESS> port 38218 connected to <IP_ADDRESS> port 5201
[ ID] Interval           Transfer     Bandwidth       Retr  Cwnd
[  5]   0.00-1.00   sec  5.10 GBytes  43.8 Gbits/sec    0   1.15 MBytes
[  5]   1.00-2.00   sec  5.07 GBytes  43.5 Gbits/sec    0   1.21 MBytes
[  5]   2.00-3.00   sec  5.06 GBytes  43.5 Gbits/sec    0   1.22 MBytes
[  5]   3.00-4.00   sec  5.06 GBytes  43.5 Gbits/sec    7   1.12 MBytes
[  5]   4.00-5.00   sec  5.06 GBytes  43.5 Gbits/sec    0   1.13 MBytes
[  5]   5.00-6.00   sec  5.07 GBytes  43.6 Gbits/sec    0   1.14 MBytes
[  5]   6.00-7.00   sec  5.08 GBytes  43.6 Gbits/sec    0   1.14 MBytes
[  5]   7.00-8.00   sec  5.08 GBytes  43.6 Gbits/sec    0   1.15 MBytes
[  5]   8.00-9.00   sec  5.08 GBytes  43.6 Gbits/sec    0   1.17 MBytes

Thanks for your detail testing.
For both ANS and linux iperf testing, How many tcp connections are established ?
Yes, we shall improve ANS tcp stack performance.

It opens two connections. One for command communication and one for the
speedtest. So only a single one is heavily used.
On 17 Jun 2016 02:55, "bluestar"<EMAIL_ADDRESS>wrote:

Thanks for your detail testing.
For both ANS and linux iperf testing, How many tcp connections are
established ?
Yes, we shall improve ANS tcp stack performance.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/opendp/dpdk-ans/issues/16#issuecomment-226654880, or mute
the thread
https://github.com/notifications/unsubscribe/ABG8JoOwQuD9zhVHguc35yGlSWfyHOHMks5qMfB3gaJpZM4I2mLU
.

if TCP Window Scale Option is enable in linux kernel? if enable, the windows is large, the speed will faster.

Yes it was enabled. Does ANS not support that?
Also does ANS support any offloading to the NIC?
If so which of the following does it support (You can click the ones that it supports):

[ ] rxvlan
[ ] txvlan
[ ]  gso
[ ]  tso
[ ] rx
[ ] tx
[ ] sg
[ ] rxhash
[ ] gro
[ ] rx-vlan-filter
[ ] lro

ANS still don't support window scale, and any TSO now,
will support them in future.

When I open 4 connections it will lower them to 6Gbit/per connection still totalling to 24.5.  Is it still the method described in this comment?https://github.com/opendp/dpdk-ans/issues/9#issuecomment-204878450
Because that is causing some issues for me.

it seems ANS with one lcore could only handle about 24G tcp data.
Yes, you  can enable jumboframe in that comment, but you shall set the interface MTU too in the ans_main.c.
By the way, what is the mean of Retr  Cwnd  in your test output?

In ans_main.c it should look like this right:
int mtu = 9000;
ans_intf_set_mtu((caddr_t)ifname, &mtu);

And for the output, the Cwnd column is congestion window size and Retr column is number of retransmits. The method of gathering this data does not seem to work for  ANS though.

Yes, you can set the mtu like that. by the way.
cwnd is tcp congestion window size? According to your test result, linux cwnd size(434 KBytes) is very large. so linux is faster. You may disable TCP window scale and retry to test.

When setting the MTU with this command:
ans/build/ans -c 0x2 -n8  -- -p=0x1 --config="(0,0,1))"  --enable-jumbo --max-pkt-len 9000

And with the code in my previous comment.
I get a Bus error like this:
nb ports 1 hz:<PHONE_NUMBER>
USER8: LCORE[1] link mbuf failed

Program received signal SIGBUS, Bus error.
0x00000000004481f0 in rte_pktmbuf_free ()
Missing separate debuginfos, use: debuginfo-install libibverbs-1.1.8mlnx1-OFED.<IP_ADDRESS>.9.33100.x86_64 libmlx4-1.0.6mlnx1-OFED.<IP_ADDRESS>.7.33100.x86_64 libmlx5-1.0.2mlnx1-OFED.<IP_ADDRESS>.9.33100.x86_64
(gdb) bt
#0  0x00000000004481f0 in rte_pktmbuf_free ()
#1  0x000000000044a68e in ans_conn_clear ()
#2  0x000000000044a7ce in ans_close_tcp ()
#3  0x0000000000445e07 in ans_close ()
#4  0x0000000000447546 in ans_sock_clear ()
#5  0x000000000044bc70 in ans_so_coremsg_handle ()
#6  0x000000000044bf2c in ans_so_msg_handle_burst ()
#7  0x0000000000431a7e in ans_main_loop ()
#8  0x00000000004cbcd3 in rte_eal_mp_remote_launch ()
#9  0x00000000004316c5 in main ()

With all the offloading off and MTU size of 1500 and TCP window scaling off I get this Linux performance:
jelte@ps1 ~/iperf-epoll src/iperf3 -c <IP_ADDRESS> -A 2,2
Connecting to host <IP_ADDRESS>, port 5201
[  5] local <IP_ADDRESS> port 35962 connected to <IP_ADDRESS> port 5201
[ ID] Interval           Transfer     Bandwidth       Retr  Cwnd
[  5]   0.00-1.00   sec   713 MBytes  5.98 Gbits/sec    0   70.7 KBytes
[  5]   1.00-2.00   sec   714 MBytes  5.99 Gbits/sec    0   70.7 KBytes
[  5]   2.00-3.00   sec   713 MBytes  5.98 Gbits/sec    0   70.7 KBytes
[  5]   3.00-4.00   sec   717 MBytes  6.02 Gbits/sec    0   70.7 KBytes
[  5]   4.00-5.00   sec   714 MBytes  5.99 Gbits/sec    0   70.7 KBytes
[  5]   5.00-6.00   sec   714 MBytes  5.99 Gbits/sec    0   70.7 KBytes
[  5]   6.00-7.00   sec   722 MBytes  6.06 Gbits/sec    0   70.7 KBytes
[  5]   7.00-8.00   sec   722 MBytes  6.06 Gbits/sec    0   70.7 KBytes
[  5]   8.00-9.00   sec   719 MBytes  6.03 Gbits/sec    0   70.7 KBytes

But when using multiple connections I still get around 8Gbit/s like before with a single one.

ok, i will test the jumbo frame case.
it seems the tcp speed also depend on the cwnd.

Ok thank you. Maybe it will be much faster then.

Have you had time to test the jumbo frame case?

No,  haven't ENV  to test it.

Ok too bad. Do you have any idea why it could be that the per stream speed increases when multiple streams are used?

You may change below macro in ans_main.h. check if increases the speed of one stream. If yes, maybe this is the root cause.
#define MAX_TX_BURST       32         /* set tx burst as 1 for lower packet latency */

Oh man, thanks for this. Changing the values there really changes the single stream performance a lot.

However, I now do get lower performance for multiple streams.
What do all the values there do?

Shall tcpdump the packets to analysis the instability behaviour, maybe the packets are lost.

If ANS print any logs?
For example "link mbuf failed " log

ANS does not print any logs.
How do I tcpdump ANS?

ANS's error or info logs can be saw on the screens and syslog.
you can tcpdump  the packets on your iperf client side(linux PC).

For instability behaviour, it is related to tcp timestamp feature, now has fixed it, it also fixed EPOLLOUT issue which has been reported by you before.
Please try it again.


added support for disconnected installation

added support for disconnected installation
migrated to new operator hub prod repo
Signed-off-by: raffaelespazzoli<EMAIL_ADDRESS>

LGTM


Error starting stream, see logs for details (Stream never started), unregistered webhooks + plus lot of other bugs

First of all, I do not understadn this note, since the only integration I can find, is the one from within HACS? It doens seems like I can find a "New integration"?

Please make sure this bug is NOT about the Reolink HACS integration, only for the new Reolink HA integration.

Describe the bug
Error starting stream: (Continues to come whenever HA and Reolink is online)
Logger: homeassistant.components.stream
Source: components/stream/__init__.py:305
Integration: Stream (documentation, issues)
First occurred: January 23, 2022, 4:42:20 PM (28 occurrences)
Last logged: 7:58:47 AM

Error from stream worker: Error opening stream rtmp://<IP_ADDRESS>:1935/bcs/channel0_main.bcs?channel=0&stream=0&user=HomeAssistant&password=SECRET_PASSWORD

Unregistered webhook, which continues to come as long as HA and Reolink is online:
Logger: homeassistant.components.webhook
Source: components/webhook/__init__.py:92
Integration: Webhook (documentation, issues)
First occurred: January 23, 2022, 3:15:48 PM (51 occurrences)Logger: homeassistant.components.webhook
Source: components/webhook/__init__.py:92
Integration: Webhook (documentation, issues)
First occurred: January 23, 2022, 3:15:48 PM (51 occurrences)
Last logged: January 23, 2022, 3:21:10 PM

Received message for unregistered webhook a6f1e7936197ea2f585d028c76b4f428f20f99458d132f7a739997b73e5b9245 from <IP_ADDRESS>
Received message for unregistered webhook 9da99c62923af6d284a67d0f520dd3992f00585eefbd643ea29edad71b0a339a from <IP_ADDRESS>
Received message for unregistered webhook fa4d8122eab80128d62622c2c2e82def44ea538536cae0c374639c48c133ab5a from <IP_ADDRESS>
Received message for unregistered webhook 3504280db06fd1450e5cb20a58054592c16ce22e082737a941799f65ac822710 from <IP_ADDRESS>
Received message for unregistered webhook b726d41667d232e02db09e7e7f85615b150a4f7ef7f8bebe4af7f86657ff63cf from <IP_ADDRESS>
Last logged: January 23, 2022, 3:21:10 PM

Timeout fetching reolink.motion_states data - recurring all time as long as HA and reolink is online:
Logger: custom_components.reolink_dev
Source: helpers/update_coordinator.py:193
Integration: Reolink IP camera (documentation, issues)
First occurred: January 23, 2022, 3:17:11 PM (623 occurrences)
Last logged: 8:02:41 AM

Timeout fetching reolink.Garden Rear.motion_states data
Timeout fetching reolink.Yard - Front.motion_states data
Timeout fetching reolink.Driveway - West.motion_states data
Timeout fetching reolink.Driveway - East.motion_states data
Timeout fetching reolink.Yard - Rear.motion_states data

Environment:
Please provide useful information about your environment, like:

Home Assistant OS 7.1
Home Assistant  Core-2021.12.10
Reolink camera models:

4x RLC-410 (<IP_ADDRESS>     .31     .33     .34) (four different IPs)
1x RLC-1220A (<IP_ADDRESS>)
1x RLC-823A (<IP_ADDRESS>)

Camera firmware number

RLC410: v<IP_ADDRESS>_20103100
RLC1220A: v<IP_ADDRESS>4_21121705
RLC823A: v<IP_ADDRESS>4_22011511_v<IP_ADDRESS>

Additional context
I can add a lot of logs from my full log text, but since I think this MAYBE is multiple individual errors, I would like to hear what you need from me. Or if I should split this up to multiple issues.

Hi!
This is a lot of bugs :p yet I do run exactly same hardware and software versions and have it work perfectly. Can you please provide logs with extra verbosity?  (https://github.com/fwestenberg/reolink_dev/blob/master/TSHOOT.md)
Remember to disable logging afterward or it will quickly fill up your log file :)

Hi!
This is a lot of bugs :p yet I do run exactly same hardware and software versions and have it work perfectly. Can you please provide logs with extra verbosity? (https://github.com/fwestenberg/reolink_dev/blob/master/TSHOOT.md)
Remember to disable logging afterward or it will quickly fill up your log file :)

Hi, and thanks for quick response!
Strange thing that you have same hardware, same firmware and no problems..
My actions:

I added the debug logger config
deleted my logfile (to get rid of all old errors)
restarted home assistant
navigated to a site in lovelace, showing the feeds (To make sure the feeds started)

logger:
  default: warning
  logs:
    custom_components.reolink_dev: debug
    custom_components.reolink_dev.base.data: warning
    reolink: debug

Full log
Link to full log file: (Please note I have a few not Reolink related errors/warning that I am also trying to deal with - but not somthing I think should affect Reolink)
During this log file, I can infact see the camara feed from all camaras, except RLC-1220A, which throws the "Error starting stream, see logs for details (Stream never started)" Error.
I am NOT getting any motion events from that camara, neither regular or AI motion allerts.
All the other camaras do report motion event - however HA still register "Inknown webhooks" from their IP, as well as im still getting "Timeout fetching reolink.Garden Rear.motion_states data" errors on all of them.
Sorry for the terribly long log file.... I hope you kan use the "Search and find"-function ;-)
https://gist.github.com/Martinnygaard/058444cbeb7609fc4d6e0a1e0c9a3388

New issue - Failed to set up camera
Sometimes I get this error (But not after each restart)
One camera (The RLC-823 at IP <IP_ADDRESS>) failed to set up, and the integration is marked as failed

Logs specific for this: (Or check the full log at line 4388)
https://gist.github.com/Martinnygaard/d9a19c4c65156827c6ac972abbf48969
This error originated from a custom integration.

Logger: homeassistant.config_entries
Source: custom_components/reolink_dev/base.py:216
Integration: Reolink IP camera (documentation, issues)
First occurred: 1:16:20 PM (1 occurrences)
Last logged: 1:16:20 PM

Error setting up entry Security Camera Garden Rear for reolink_dev
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 313, in async_setup
    result = await component.async_setup_entry(hass, self)  # type: ignore
  File "/config/custom_components/reolink_dev/__init__.py", line 75, in async_setup_entry
    if not await base.connect_api():
  File "/config/custom_components/reolink_dev/base.py", line 216, in connect_api
    if not await self._api.get_settings():
  File "/usr/local/lib/python3.9/site-packages/reolink/camera_api.py", line 485, in get_settings
    response = await self.send(body)
  File "/usr/local/lib/python3.9/site-packages/reolink/camera_api.py", line 1627, in send
    raise CredentialsInvalidError()
reolink.exceptions.CredentialsInvalidError

New issue - Failed to set up camera
Sometimes I get this error (But not after each restart)
One camera (The RLC-823 at IP <IP_ADDRESS>) failed to set up, and the integration is marked as failed

Hi, This is happening sometimes to me as well, a reboot of the camera usually fixes the issue. Reolink software has so many issues :/ I feel sometime that I should drop the 'session token' schema and repeat login+password at every call instead

You should remove your log file from gist : some error message from HA seem to expose your passwords

Unregistered webhook, which continues to come as long as HA and Reolink is online:

They should stop after half an hour : Reolink does not support Webhook de-registration and will continue to hammer your webhooks for 15-30 minutes and HA webhooks URLs are changing after each restart

You should remove your log file from gist : some error message from HA seem to expose your passwords

I did a quick search for my password - and changed it to something that can't be used ;)
But thanks for reminder.

Unregistered webhook, which continues to come as long as HA and Reolink is online:

They should stop after half an hour : Reolink does not support Webhook de-registration and will continue to hammer your webhooks for 15-30 minutes and HA webhooks URLs are changing after each restart

So I should expect these errors at every restart of HA?

Unregistered webhook, which continues to come as long as HA and Reolink is online:

They should stop after half an hour : Reolink does not support Webhook de-registration and will continue to hammer your webhooks for 15-30 minutes and HA webhooks URLs are changing after each restart

So I should expect these errors at every restart of HA?

yes

Any ideas about the RLC-1220 with "Error starting stream, see logs for details (Stream never started)" Error and no motion events?

Any ideas about the RLC-1220 with "Error starting stream, see logs for details (Stream never started)" Error and no motion events?

you should try to open it a in RTSP/RTMP software but beware that Reolink has issues with RTMP/RSTP because they use a  bad combination of unsupported HD definitions and codecs making it incompatible with many software (Google will tell you a lot more), including HA. You should try sub streams (ext ... sub) settings to lower pixel count and also try several combinations of RTMP/RTSP (you may have to restart HA after settings changed)

+1 on that motion event error. Getting Motion states could not be queried from API.

On the general bug hunt, I seem to get a lot of these:
2022-02-10 13:40:33 ERROR (MainThread) [aiohttp.server] Error handling request
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/aiohttp/web_protocol.py", line 435, in _handle_request
    resp = await request_handler(request)
  File "/usr/local/lib/python3.9/site-packages/aiohttp/web_app.py", line 504, in _handle
    resp = await handler(request)
  File "/usr/local/lib/python3.9/site-packages/aiohttp/web_middlewares.py", line 117, in impl
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 60, in security_filter_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 98, in forwarded_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 28, in request_context_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 219, in auth_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 137, in handle
    result = await result
  File "/usr/src/homeassistant/homeassistant/components/camera/__init__.py", line 748, in get
    return await self.handle(request, camera)
  File "/usr/src/homeassistant/homeassistant/components/camera/__init__.py", line 766, in handle
    image = await _async_get_image(
  File "/usr/src/homeassistant/homeassistant/components/camera/__init__.py", line 169, in _async_get_image
    image_bytes = await camera.async_camera_image(
  File "/usr/src/homeassistant/homeassistant/components/proxy/camera.py", line 252, in async_camera_image
    image = await async_get_image(self.hass, self._proxied_camera)
  File "/usr/src/homeassistant/homeassistant/components/camera/__init__.py", line 208, in async_get_image
    return await _async_get_image(camera, timeout, width, height)
  File "/usr/src/homeassistant/homeassistant/components/camera/__init__.py", line 169, in _async_get_image
    image_bytes = await camera.async_camera_image(
  File "/config/custom_components/reolink_dev/camera.py", line 197, in async_camera_image
    return await self._base.api.get_snapshot()
  File "/usr/local/lib/python3.9/site-packages/reolink/camera_api.py", line 625, in get_snapshot
    return await self.get_still_image()
  File "/usr/local/lib/python3.9/site-packages/reolink/camera_api.py", line 617, in get_still_image
    response = await self.send(None, param, expected_content_type='image/jpeg')
  File "/usr/local/lib/python3.9/site-packages/reolink/camera_api.py", line 1669, in send
    raise ApiError(
reolink.exceptions.ApiError: API returned HTTP status ERROR code 502/Bad Gateway

Then later, it'll end up with:
2022-02-10 13:41:47 ERROR (MainThread) [aiohttp.server] Error handling request
Traceback (most recent call last):
  File "/usr/local/lib/python3.9/site-packages/aiohttp/web_protocol.py", line 435, in _handle_request
    resp = await request_handler(request)
  File "/usr/local/lib/python3.9/site-packages/aiohttp/web_app.py", line 504, in _handle
    resp = await handler(request)
  File "/usr/local/lib/python3.9/site-packages/aiohttp/web_middlewares.py", line 117, in impl
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/security_filter.py", line 60, in security_filter_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/forwarded.py", line 98, in forwarded_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/request_context.py", line 28, in request_context_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/auth.py", line 219, in auth_middleware
    return await handler(request)
  File "/usr/src/homeassistant/homeassistant/components/http/view.py", line 137, in handle
    result = await result
  File "/usr/src/homeassistant/homeassistant/components/camera/__init__.py", line 748, in get
    return await self.handle(request, camera)
  File "/usr/src/homeassistant/homeassistant/components/camera/__init__.py", line 766, in handle
    image = await _async_get_image(
  File "/usr/src/homeassistant/homeassistant/components/camera/__init__.py", line 169, in _async_get_image
    image_bytes = await camera.async_camera_image(
  File "/usr/src/homeassistant/homeassistant/components/proxy/camera.py", line 252, in async_camera_image
    image = await async_get_image(self.hass, self._proxied_camera)
  File "/usr/src/homeassistant/homeassistant/components/camera/__init__.py", line 208, in async_get_image
    return await _async_get_image(camera, timeout, width, height)
  File "/usr/src/homeassistant/homeassistant/components/camera/__init__.py", line 169, in _async_get_image
    image_bytes = await camera.async_camera_image(
  File "/config/custom_components/reolink_dev/camera.py", line 197, in async_camera_image
    return await self._base.api.get_snapshot()
  File "/usr/local/lib/python3.9/site-packages/reolink/camera_api.py", line 625, in get_snapshot
    return await self.get_still_image()
  File "/usr/local/lib/python3.9/site-packages/reolink/camera_api.py", line 617, in get_still_image
    response = await self.send(None, param, expected_content_type='image/jpeg')
  File "/usr/local/lib/python3.9/site-packages/reolink/camera_api.py", line 1677, in send
    raise CredentialsInvalidError()
reolink.exceptions.CredentialsInvalidError

Is this related?


Build Optimizer ES2015 fixes

These fixes should allow projects using "target": "es2015", in tsconfig.json to create a working build when using Build Optimizer.
For a new project, using a production build, the main bundle size is:

ES5: with build optimizer 367 kB, without build optimizer 604 kB (-39%)
ES2015: with build optimizer 359 kB, without build optimizer 495 kB (-27%)

For Angular.io, using a production build, the main bundle size is:

ES5: with build optimizer 479 kB, without build optimizer 732 kB (-34%)
ES2015: with build optimizer 435 kB, without build optimizer 626 kB (-30%)

The improvements are less dramatic but still there.

AIO doesn't show console errors but doesn't seem to load content properly with these fixes. Investigating.

The problem in AIO seems to be dropped RxJs code: https://github.com/ReactiveX/rxjs/issues/3756
I am not sure why this is not a problem with Build Optimizer when using the ES5 version of RxJs.

The issue with AIO was clarified on ReactiveX/rxjs#3756 and is now addressed in this PR.


Numerous errors logged when running “python test_replays/test_all.py”

I just forked from https://github.com/ggtracker/sc2reader (the upstream branch) on Windows 10 (Python 3.6.8) and ran test_all.py
The error message is as follows：
morestuff
morestuff
....Unable to change type of None [0] to 686 [frame 2135]; unit type not found in build 38215
test_replays/<IP_ADDRESS>215/fourth.SC2Replay
Release String: <IP_ADDRESS>215
        Player 1 - Owl (Terran)
        Player 2 - dremax (Zerg)
12948   Owl     Missing ability 3B20 from Build
Owl<PHONE_NUMBER>359851
.Fetching remote resource: http://EU.depot.battle.net:1119/5984441b6318a28781f01f3efb54c7614af7eb286ae1c068d0f06e471fb40370.s2ma
.DOING 1
Unable to change type of None [240001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [280001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [480001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [4C0001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [500001] to CollapsiblePurifierTowerDiagonal [frame 0]; unit type not found in build base
Unable to change type of None [780001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [7C0001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [B40001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [B80001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [DC0001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [E00001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [11C0001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [1200001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [1440001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [1480001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [1580001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [15C0001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2440001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2480001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [24C0001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2500001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2540001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2580001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [25C0001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2600001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2640001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2680001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [26C0001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2700001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2740001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2780001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [27C0001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2800001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2840001] to CollapsiblePurifierTowerDiagonal [frame 0]; unit type not found in build base
DOING 2
test_replays/3.1.0/2.SC2Replay
Release String: <IP_ADDRESS>576
        Player 1 - OneScotch (Terran)
        Player 2 - TubbyJeff (Zerg)
18538   OneScotch       Missing ability 47E0 from Build
18976   OneScotch       Missing ability 4800 from Build
DOING 3
DOING 4
.Unknown attribute id: 5005
Unknown attribute id: 5005
Unknown attribute id: 3016
Unknown attribute id: 3016
Unknown attribute id: 5002
Unknown attribute id: 5002
Unknown attribute id: 5004
Unknown attribute id: 5004
Unknown attribute id: 5003
Unknown attribute id: 5003
Unknown attribute id: 5001
Unknown attribute id: 5001
Unknown attribute id: 3017
Unknown attribute id: 3017
Unknown attribute id: 5000
Unknown attribute id: 5000
.Unknown attribute id: 5005
.......
Unable to change type of None [2440001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2480001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [24C0001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2500001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2540001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2580001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [25C0001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2600001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2640001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2680001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [26C0001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2700001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2740001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2780001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [27C0001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2800001] to ShakurasVespeneGeyser [frame 0]; unit type not found in build base
Unable to change type of None [2840001] to CollapsiblePurifierTowerDiagonal [frame 0]; unit type not found in build base
Unable to change type of Pylon [5840001] to PylonOvercharged [frame 10843]; unit type not found in build base
.......
test_replays/3.4.0/issueYY.SC2Replay
Release String: <IP_ADDRESS>401
        Player 1 - bacon (Protoss)
        Player 2 - FlyingCake (Terran)
14      bacon   Missing ability 1540 from Build
23      FlyingCake      Missing ability 12C0 from Build
184     FlyingCake      Missing ability 12C0 from Build
392     FlyingCake      Missing ability F81 from Build
417     bacon   Missing ability 14A1 from Build
489     bacon   Missing ability 1540 from Build
508     FlyingCake      Missing ability 12C0 from Build
860     bacon   Missing ability 14A3 from Build
888     FlyingCake      Missing ability F83 from Build
914     bacon   Missing ability 1540 from Build
932     FlyingCake      Missing ability F83 from Build
951     FlyingCake      Missing ability 12C0 from Build
1102    bacon   Missing ability 14A2 from Build
1132    FlyingCake      Missing ability 12C0 from Build
1227    bacon   Missing ability 1540 from Build
........
Bad pid (4) for event <class 'sc2reader.events.tracker.PlayerStatsEvent'> at 11.20 [10880].
Bad pid (4) for event <class 'sc2reader.events.tracker.PlayerStatsEvent'> at 11.30 [11040].
Bad pid (4) for event <class 'sc2reader.events.tracker.PlayerStatsEvent'> at 11.40 [11200].
Bad pid (4) for event <class 'sc2reader.events.tracker.PlayerStatsEvent'> at 11.50 [11360].
Bad pid (4) for event <class 'sc2reader.events.tracker.PlayerStatsEvent'> at 12.00 [11520].
Bad pid (4) for event <class 'sc2reader.events.tracker.PlayerStatsEvent'> at 12.10 [11680].
Bad pid (4) for event <class 'sc2reader.events.tracker.PlayerStatsEvent'> at 12.20 [11840].
Bad pid (4) for event <class 'sc2reader.events.tracker.PlayerStatsEvent'> at 12.30 [12000].
Bad pid (4) for event <class 'sc2reader.events.tracker.PlayerStatsEvent'> at 12.37 [12114].
x.............
======================================================================
ERROR: test_lotv_creepTracker (__main__.TestReplays)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test_replays/test_all.py", line 437, in test_lotv_creepTracker
    replay =factory.load_replay(replayfilename,engine=pluginEngine,load_map= True)
  File "D:\Anaconda3\envs\StarCraft\lib\site-packages\sc2reader-1.3.1-py3.6.egg\sc2reader\factories\sc2factory.py", line 85, in load_replay
    return self.load(Replay, source, options, **new_options)
  File "D:\Anaconda3\envs\StarCraft\lib\site-packages\sc2reader-1.3.1-py3.6.egg\sc2reader\factories\sc2factory.py", line 137, in load
    return self._load(cls, resource, filename=filename, options=options)
  File "D:\Anaconda3\envs\StarCraft\lib\site-packages\sc2reader-1.3.1-py3.6.egg\sc2reader\factories\sc2factory.py", line 146, in _load
    obj = cls(resource, filename=filename, factory=self, **options)
  File "D:\Anaconda3\envs\StarCraft\lib\site-packages\sc2reader-1.3.1-py3.6.egg\sc2reader\resources.py", line 288, in __init__
    self.load_map()
  File "D:\Anaconda3\envs\StarCraft\lib\site-packages\sc2reader-1.3.1-py3.6.egg\sc2reader\resources.py", line 405, in load_map
    self.map = self.factory.load_map(self.map_file, **self.opt)
  File "D:\Anaconda3\envs\StarCraft\lib\site-packages\sc2reader-1.3.1-py3.6.egg\sc2reader\factories\sc2factory.py", line 101, in load_map
    return self.load(Map, source, options, **new_options)
  File "D:\Anaconda3\envs\StarCraft\lib\site-packages\sc2reader-1.3.1-py3.6.egg\sc2reader\factories\sc2factory.py", line 136, in load
    resource, filename = self._load_resource(source, options=options)
  File "D:\Anaconda3\envs\StarCraft\lib\site-packages\sc2reader-1.3.1-py3.6.egg\sc2reader\factories\sc2factory.py", line 195, in _load_resource
    contents = self.load_remote_resource_contents(resource, **options)
  File "D:\Anaconda3\envs\StarCraft\lib\site-packages\sc2reader-1.3.1-py3.6.egg\sc2reader\factories\sc2factory.py", line 179, in load_remote_resource_contents
    return urlopen(resource).read()
  File "D:\Anaconda3\envs\StarCraft\lib\urllib\request.py", line 223, in urlopen
    return opener.open(url, data, timeout)
  File "D:\Anaconda3\envs\StarCraft\lib\urllib\request.py", line 532, in open
    response = meth(req, response)
  File "D:\Anaconda3\envs\StarCraft\lib\urllib\request.py", line 642, in http_response
    'http', request, response, code, msg, hdrs)
  File "D:\Anaconda3\envs\StarCraft\lib\urllib\request.py", line 570, in error
    return self._call_chain(*args)
  File "D:\Anaconda3\envs\StarCraft\lib\urllib\request.py", line 504, in _call_chain
    result = func(*args)
  File "D:\Anaconda3\envs\StarCraft\lib\urllib\request.py", line 650, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 400: Bad Request
----------------------------------------------------------------------
Ran 67 tests in 294.889s

FAILED (errors=2, expected failures=3)

@dsjoerg @cclauss @StoicLoofah @Unclevinny  please help me,How did you solve the problem?

interesting. i ran some of the tests myself and ran into the same issue. it looks like @cclauss in #79 triggered another build with more errors. If I was going to guess, I think the tests are trying to retrieve content from Blizzard who have purged the data because it is years old.
I think the library is working fine: the right fix is probably to update the tests to use more recent replays/data or to remove the tests.
want to take a shot at either of those?

interesting. i ran some of the tests myself and ran into the same issue. it looks like @cclauss in #79 triggered another build with more errors. If I was going to guess, I think the tests are trying to retrieve content from Blizzard who have purged the data because it is years old.
I think the library is working fine: the right fix is probably to update the tests to use more recent replays/data or to remove the tests.
want to take a shot at either of those?

I am not very familiar with this. Can you have any specific solutions?

I think the solution would be to rewrite the failing tests using newer replays, but I haven't tested that. Is that what you were looking for?

I am looking into this now


[Release] Verify 6.0.0 RC0 [WIP]

The C++ verification fails with a valid cmake issue:
CMake Error in src/arrow/flight/CMakeLists.txt:
  Imported target "gRPC::grpc++" includes non-existent path

    "/tmp/arrow-6.0.0.v1qFD/apache-arrow-6.0.0/cpp/build/absl_ep-install/include"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

CMake Error in src/arrow/flight/CMakeLists.txt:
  Imported target "gRPC::grpc++" includes non-existent path

    "/tmp/arrow-6.0.0.v1qFD/apache-arrow-6.0.0/cpp/build/absl_ep-install/include"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

Addressing it then cutting a new RC.


[Pulsar Catalog] PulsarCatalog should not do any autofill for non-pulsar tables.

Should the catalog host only Pulsar tables ? This is a big question, because it looks like so.


allow only exact word to search in genie

I need to filter wishes with exact match word  typed in genie

Look into genie.overrideMatchingAlgorithm. That's what you're wanting to do :-)


add filter_by_time

Adding an initial skeleton of filter_by_time()
Hi @mdancho84, adding a v1 of filter by time. See notes below and let me know what you think.

Inupts: Current user inputs include data, date_column, start_date, end_date and engine

Date Parsing: For the start_date and end_date inputs, I used the length of the input to determine whether it is a date, date/month, year, etc. I'm not sure if this is the best method determine how to parse and filter the dates. See screenshot below -

Groups:  I'm not sure if I implemented the grouping functionality properly as the index looks weird with groups.  I was also wondering if a function like this requires groups. Technically, any filtering by date, will automatically filter each group.

Engine: Currently only Pandas. However I used the same format for the other functions (creating a _filter_by_time_pandas()), to make it easy to add the Polars engine later.

Nice work. With the holidays it might be next week for a full review. But really happy about this!

Awesome I just finished up reviewing filter_by_time. It's been successfully integrated. I changed just a couple of things:

Parse end date - this is a weird one. In timetk, I implement end date parsing where the expectation is "2014" should convert to "2014-12-31", which is the last date in 2014. This is now supported.
start/end date defaults "start" and "end". This just converts to the min/max dates.
Time zones - Datetimes in pandas can have timezones. The function now handles timezones like UTC more gracefully.


Card game

🎮 Game Request
It's Card Game made using PYTHON Game.
Point down the features
Game points
Select program in which you are contributing
GSSoC23
Code of Conduct

[X] I follow CONTRIBUTING GUIDELINE of this project.

/assign

Hey @shraddha761 !
Thank you for raising an issue 💗
You can self assign the issue by commenting /assign in comment 😀
Make sure you follow CODE OF CONDUCT and CONTRIBUTING GUIDELINES 🚀
Don’t Forget to ⭐ our GameZone🎮
Make sure you join our Discord🕹

Hey @shraddha761! 🙂
It seems like you are not following proper guidelines !! 👀
Read documentation properly !!🙏
If you have any queries reach out to us on Discord🕹 .


Panic with two connections

This does not happen with --connections 1:
ddshow --stream-encoding rkyv --differential --connections 2
[2s] Waiting for 2 connections on <IP_ADDRESS>:51317: connected to 2 trace sources
[0s] Waiting for 2 connections on <IP_ADDRESS>:51318: connected to 2 trace sources
Press enter to finish collecting trace data (this will crash the source computation if it's currently running and cause data to not be fully processed)...
[1/2, 0s] ⠂ Replaying timely events: 0 events, 0/s
[2/2, 0s] ⠂ Replaying differential events: 0 events, 0/s
thread 'timely:work-0' panicked at 'Attempted to delay Capability { time: 7.387769ms, internal: ... } to 479.523µs, which is not `less_equal` the capability's time.', /home/lryzhyk/.cargo/registry/src/github.com[1/2, 0s]   Finished replaying timely events: 428 events, 9486/s
[2/2, 0s]   Finished replaying differential events: 754 events, 12416/s

Processing data...Error: failed to join timely worker threads: Any

This is how I run DDlog in another shell:
./tutorial_ddlog/target/release/tutorial_cli -w 2 --profile-timely  --profile-differential  < tutorial.dat

I fixed this today, it should work on master now


Suggestion: Use dependency-plugin to ensure dependency convergence

Hi!
we have made good experience with using the Maven dependency plugin to ensure converging dependency versions and avoid conflicts in our projects.
What is your take on this? I think consumers would greatly benefit from this.
I could offer to create a PR to showcase this a bit.
Kind regards
Sander

hi, we've cleaned up our pom.xml's and converged all depdendencies in the dependency management section of our parent pom


Allow to bypass the indexer-app archive limits on docker scan

Allow to bypass the indexer-app archive limits on docker scan

I have read the CLA Document and I hereby sign the CLA
recheck

recheck

Thanks for your contribution! @hightoxicity

@sverdlov93 Thanks for your review and merge !


Refactor spacer class so that it is only defined once.

Not necessary since the spacer class's styling is defined in one single place - custom.css.


Std. deviation of slope is calculated incorrectly for clearsky.detect_clearsky

Describe the bug
This line
raw = np.diff(data)

does not calculate the slope since it is not divided by the time interval.
Expected behavior
raw = np.diff(data) / sample_interval

Versions:

pvlib.__version__: 0.8.1

Additional context
All current tests use 1-minute intervals, so the tests are not incorrect.

from looking at the title only... is this a duplicate of #1070?

No. #1070 can be closed with some comments in the code to explain the deviation from the reference.


Set table to 9 ball color

During 9 ball the table is set to the target ball in 9 ball

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Codel1417 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Change WindmillStateReader to not batch OrderedListFetches for the same family and tag.

Fix issue with MultimapState delayed fetches due to batching.
fixes #28370

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

R: @reuvenlax

Run Java PreCommit

R: @y1chi

Taking a look.
On Tue, Oct 31, 2023 at 6:37 AM scwhittle @.***> wrote:

R: @y1chi https://github.com/y1chi
—
Reply to this email directly, view it on GitHub
https://github.com/apache/beam/pull/28371#issuecomment-1787235930, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AFAYJVNBF6B6F55AV4BEKSDYCD5INAVCNFSM6AAAAAA4QHW52GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBXGIZTKOJTGA
.
You are receiving this because you were mentioned.Message ID:
@.***>

Run Java PreCommit

previous failure was unrelated flink test timeout

LGTM


Run make validate in paralell

Closes #271

Will improve validate step in GitHub Actions (pr validation / check) with around 1 minute.


Properties of Reindexing

Prove the following are stable under reindexing a displayed category:

[x] local terminal objects
[ ] local cartesian products
[x] cartesian lifts (can port from 1lab)

All of these are defined as LocalRightAdjointᴰ so maybe there's a slick proof that covers all of them

Cartesian Lifts implemented in https://github.com/maxsnew/cubical-categorical-logic/pull/73

stability of reindexing vertical terminal objects (up-to-date terminology for local terminal objects) implemented by #83 and moved to present location by #95

stability of reindexing vertical cartesian products implemented by #94

Once #94 is merged, we can close this


composing endpoints doesn't work

Describe the bug
Combining endpoints isn't working as expected
To Reproduce
object Endpoints extends App {
  def h1 = GET / "a" / *[Int] / "b" / *[Boolean] to { a =>
    Response.text(a.params.toString)
  }

  def h2 = GET / "b" / *[Int] / "b" / *[Boolean] to { a =>
    Response.text(a.params.toString)
  }
  // Run it like any simple app
  override def run(args: List[String]): URIO[zio.ZEnv, ExitCode] =
    Server.start(8091, h2 ++ h1).exitCode
}

GET /a/2/b/true // The requested URI "/a/2/b/true" was not found on this server
GET /b/2/b/true // (2,true)

Expected behavior
GET /a/2/b/true // (2, true)
GET /b/2/b/true // (2, true)

I was poking around to learn more about how zio-http works and believe I have a root cause.
The actual routes you use are irrelevant, if the first one doesn't match it gets returned.
If a route doesn't match we end up here and return a NOT_FOUND. But this means the partial function in Collect is defined, and so we end up returning HExit.Success(NOT_FOUND) and the FoldM shortcircuits and doesn't try the default.
Not sure about the cleanest way to fix this. A NOT_FOUND response should only be returned only after trying all the routes, but since they are encoded inside nested FoldMs it's difficult to know when they've all been tried.
Side note: the default in a FoldM does actually get run every time, even if a route is matched. this should be a thuink


When taking the template, the action start directly but fails

As identified by @rlanzafame
See here: https://github.com/TeachBooks/test/actions/runs/8844316408/job/24285981641
I think it's because github pages wasn't activated. In the second attempt I activated it and then it worked: https://github.com/TeachBooks/test/actions/runs/8844316408

Can we enable it from the action itself? https://docs.github.com/en/pages/getting-started-with-github-pages/using-custom-workflows-with-github-pages#configuring-the-configure-pages-action

I have tried it, it did not work out. I think we should move on and simply state in our docs that the first automatic pipeline will always fail, since Pages have to be enabled. I assume it's OK to close ?


fix syntax highlighting

This is the bare minimum change needed to fix syntax highlighting. I assume that something changed in a recent version of VSCode that caused shiki-themes to break with the error:
TypeError: Cannot read properties of undefined (reading 'concat')
	at Object.loadTheme (/home/bryan/code/github.com/vscode-docs-view/node_modules/shiki-themes/dist/loadTheme.js:53:55)
	at CodeHighlighter.getShikiTheme (/home/bryan/code/github.com/vscode-docs-view/dist/extension.js:93:60)

With this fix, syntax highlighting works again:

@mattbierner There are many other improvements that can be made to this extension, but I tried to keep this PR to a minimum. Are you interested in help maintaining this project? I find it useful; imo a feature that VSCode should have natively.

Thanks! Looks like a good start. I'll merge this and then take a look at fixing the extra margin that now seems to get rendered:

Thanks!
(For cross-reference: Fixes #48)


Add script to manually export all vulnerabilities

For https://github.com/cisagov/crossfeed/issues/1162.

 Closing ticket.


[Bugfix] Use .NET core 3.1 like in the moduls exercise

In the module at https://docs.microsoft.com/en-us/learn/modules/run-quality-tests-build-pipeline/4-add-unit-tests the pipeline uses .NET core 3.1.100. Upgrading .NET core also requires upgrade of the installer task in the pipeline.

I made the same change while doing the learning course, because the pipeline failed without it, was just thinking of opening a pull request :)

In the next exercise I run into problems with code coverage - I had to downgrade to 3.1.100. See discussion at https://github.com/dotnet/core/issues/4725#issuecomment-632372340

I'm so sorry for the oversight here. I do appreciate the PR and the context. I'm fixing this in another branch along with a few other updates. But again, I so appreciate the help!