[SDP-1105] add demo-wallet to docker-compose

What

Added a new Dockerfile for running the demo-wallet client locally.
Fix Quickstart links
Fix main.sh script to only provision missing tenants

Why
https://stellarorg.atlassian.net/browse/SDP-1105
Known limitations
[TODO or N/A]
Checklist
PR Structure

[ ] This PR has a reasonably narrow scope (if not, break it down into smaller PRs).
[ ] This PR title and description are clear enough for anyone to review it.
[ ] This PR does not mix refactoring changes with feature changes (split into two PRs otherwise).

Thoroughness

[ ] This PR adds tests for the new functionality or fixes.
[ ] This PR contains the link to the Jira ticket it addresses.

Configs and Secrets

[ ] No new CONFIG variables are required -OR- the new required ones were added to the helmchart's values.yaml file.
[ ] No new CONFIG variables are required -OR- the new required ones were added to the deployments (pr-preview, dev, demo, prd).
[ ] No new SECRETS variables are required -OR- the new required ones were mentioned in the helmchart's values.yaml file.
[ ] No new SECRETS variables are required -OR- the new required ones were added to the deployments (pr-preview secrets, dev secrets, demo secrets, prd secrets).

Release

[ ] This is not a breaking change.
[ ] This is ready for production.. If your PR is not ready for production, please consider opening additional complementary PRs using this one as the base. Only merge this into develop or main after it's ready for production!

Deployment

[ ] Does the deployment work after merging?

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr242.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr242.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr242.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr242.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr242.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr242.previews.kube001.services.stellar-ops.com

stellar-disbursement-platform-backend-preview is available here:SDP:      https://sdp-backend-pr242.previews.kube001.services.stellar-ops.com/healthAP:       https://sdp-ap-pr242.previews.kube001.services.stellar-ops.com/healthFrontend: https://sdp-backend-dashboard-pr242.previews.kube001.services.stellar-ops.com


endpoint: Remove unnecessary endpoint lock on restore

The endpoint structure has just been restored from state and is not exposed in
any way yet so it is impossible to encounter a parallel writer or reader.

This change is

test-me-please

test-me-please

test-me-please

test-me-please

test-me-please

Rebased

test-me-please

I'm with @aanm on this one. Even if we never end up in the situation where we have parallel access when restoring, the lock is not under contention and locking is nearly 0-time. If we don't lock it we're making an example of bad usage of the endpoint locks.
Was your thinking that we would forget to add the unlock on an error exit path? If so, then solving that is a little more complex because of ep.SkipStateClean().

@raybejjani @aanm I don't understand the logic. Are we starting to lock all variables on the stack going forward? The lock is being held through the IP allocation logic which may be blocking in the future. It will trigger warnings for long lock durations behind held.
Leaving locking code like this in is very confusing, why do we lock if it is not necessary? When I read code like this, I have to assume that the locking is required for something. Either the lock is completely hidden from the user and buried in accessor functions or it must be absolutely clear why a lock is being taken. The endpoint is on the stack, there is no chance anyone can use it in parallel.

ok. I think you feel more strongly than me about this so let's merge this.

@aanm are you OK with @tgraf 's justification?

@raybejjani @aanm No. I think we should discuss this and the consistently do one pattern. This will be a cornerstone of quality and if we don't all have the same assumptions that will cause a lot of subtle bugs down the road. What are you proposing in terms of how to do the locking. We always lock a structure even if the structure is still on the stack?

We always lock a structure even if the structure is still on the stack?

Yes, the lock serves to protect against concurrent access. If the lock exists we should make use of it. If the lock is not necessary then why is it there? All of the functions called that are wrapped by that lock clearly states:
// must be called with endpoint.Mutex held

or has the "Locked" suffix.
I don't like to make assumptions today because they will be wrong tomorrow, and I don't want to remember that there is a special place in the code where we don't use locks, it's one more thing that we can't forget when we will have to fix a bug in this section or add a new functionality in this section.

I don't like to make assumptions today because they will be wrong tomorrow, and I don't want to remember that there is a special place in the code where we don't use locks, it's one more thing that we can't forget when we will have to fix a bug in this section or add a new functionality in this section.

OK. I don't feel that strongly about this change so I'm fine to drop it. I think we all agree that we should avoid requiring knowledge about whether certain locks must be held or not so we should strive for that instead and limit locks to data accesses only.


[VS Code] Kotlin support

Please consider adding support for Kotlin.
This would be an especially great quality-of-life improvement when working in projects that are mixed between Java and Kotlin.
Product and Version: VSCode 1.34.0
OS Version: macOS
IntelliCode Extension Version: 1.1.6
Target Platform or Language: Kotlin

Reopening due to erroneous bot closure. Apologies for any confusion


fix(Button): Remove padding from button with custom icon

Fixed #345

:tada: This PR is included in version 0.10.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


How long is LowLatency suitable for?

I assume it's implementation-dependent, but there must be a reliable rule of thumb.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1fcebd46-8a64-9531-f6e1-3a330b61bb0f
Version Independent ID: 7538a252-8fa8-4615-92df-f1c6d7d6a3e4
Content: Latency Modes
Content Source: docs/standard/garbage-collection/latency.md
Product: dotnet
Technology: dotnet-standard
GitHub Login: @BillWagner
Microsoft Alias: dotnetcontent

@Maoni0 Is there a rule of thumb for how long the low latency mode is suitable for?


iphone14promax

Can it be compatible with the rush purchase of the new iPhone 14 series this year？

need to modify product.json by yourself.

you could get production serial numbers of iPhone 14 from apple.com, then update the product.json


Modal

Work in progress. Please feel free to give feedback, but do not merge.
This is an implementation of the materialize dialog, build on top of ember-modal-dialog. The magic behind this is ember-wormhole which lets us render views into arbitrary DOM elements.
In the case of this dialog, it means that the dialog can be a direct decendant of the  element, getting us around some annoying stacking context issues.
{{#if modalIsOpen}}
  {{#materialize-modal close='closeModal'}}

Hello Modal

Oh hai there!

      Agree
      Cancel

  {{/materialize-modal}}
{{/if}}

Ready for review/merge


Test PR with coverage comment and codecov

Description
Please explain the changes you made here.
Checklist

[ ] Code compiles correctly
[ ] Created tests which fail without the change (if applicable)
[ ] All lint and unit tests passing
[ ] Extended the README / documentation, if necessary

Additional Comments
Anything else you'd like to add.

Confirmed that code coverage is uploaded to https://app.codecov.io/github/rbarman/itscalledsoccer/tree/another-one !

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Roll Flutter Engine from bacc5e1e73b7 to e2254cd0167c (1 revision)

https://github.com/flutter/engine/compare/bacc5e1e73b7...e2254cd0167c
2024-11-01<EMAIL_ADDRESS>Roll Dart SDK from 32bebf22c765 to 09c8281e66cc (1 revision) (flutter/engine#56298)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Aggregate commonly-used middleware into a single, configurable module

Some middleware modules are used on every backend project because they provide key functionality to the HTTP layer, namely:

koa-compress
koa-bodyparser
kcors
koa-conditional-get & koa-etag
koa-helmet
koa-static
koa-router
Authorization header parser (JWT, mostly)
Error handler (catches errors thrown in middleware, logs them and sends a 5xx response back)
Generic logger to log all incoming requests/responses

I think we could wrap most (if not all) of these modules into a single module so that consumers do not need to install and configure all of these manually.
Implementation requirements:

Sensible defaults must be provided for all middleware
Consumers must be able to disable or even replace any of them if they so choose, without affecting the other modules. Preferrably, the ordering of modules, especially when mixing these "built-in" middleware with user-defined middleware should be somehow configurable.
Everything must be fully configurable
Only what is generally considered a "standard" or "best practice" for REST APIs should be included (ie. do not enable clickjacking protection - we do not serve HTML so we do not need to enable this kind of protection)

+1 sounds awesome


List view for search screen

Is your feature request related to a problem? Please describe.
Grid view can sometimes be confusing to look at
Describe the solution you'd like
List view for the search screen that can be togglable in the settings
Describe alternatives you've considered
Toggle could also not be in the settings? But I think it's something not pressed often.
Additional context

Duplicate of #36


Error with Vertex AI Gemini Batch Prediction:  400: Service agents are being provisioned. Endpoint Not Deployed Properly.

File Name
gemini/batch-prediction/intro_batch_prediction.ipynb
What happened?
I'm using the Gemini Batch Prediction API with the Vertex AI Python SDK in a project. When attempting to run batch predictions, I'm encountering an issue (see "Relevant log output").  I am working in the region us-central1
I've already tried a few solutions, such as adjusting permissions, but nothing seems to resolve the issue. Some users suggested the issue is related to models not being deployed properly to the endpoints and I have yet to see any endpoints when checking via the console. There are zero endpoints deployed, but should I attempt to deploy the model to the endpoint? It's flash-002, not a custom model.
Relevant log output
[Bug]: {'status': 'Bad Request: {"error": {"code": 400, "message": "Service agents are being provisioned (https://cloud.google.com/vertex-ai/docs/general/access-control#service-agents). Service agents are needed to read the Cloud Storage file provided. So please try again in a few minutes.", "status": "FAILED_PRECONDITION"}}', 'processed_time': '2024-10-21T17:13:09.85+00:00', 'request': {'contents': [{'parts': [{'file_data': None, 'text': 'You are an expert at text extraction from legal documents.  You have been provided with a UCC-1 lien filing and I want you to locate and extract specific information in this document that relates to the collateral / capital / equipment.  We want to ignore highly generic or non-specific language, and find specific equipment items which list a brand or model or similar.  You should follow these steps:\n1. Identify Relevant Sections: \n   - Locate sections in the document which refer to the collateral description\n2. Identify if this section has specific information, such as:\n   - Brands (e.g., Caterpillar, Dell, Haas)\n   - Model numbers (e.g., D6N, PE-R740-XXXX, VF-2SS)\n   - Equipment categories (e.g., bulldozer, server, CNC machine)\n   - Serial numbers (e.g., XYZ12345)\n   - Quantity (e.g., 3, Two, Five)\n   - Year of manufacture (if provided)\n   - Any other unique identifiers\n3. If the section does not contain any specific information, simply return the text "[generic]"\n4. If there is one or more specific item found, then:\n   - Describe each piece of equipment using the exact same or very similar words in the original document\n   - Format each item on a new line, preceded by a dash (-).\n   - Examples:\n     - 2023 Caterpillar D6N bulldozer, Serial #XYZ12345\n     - 3 Dell PowerEdge R740 servers, Model #PE-R740-XXXX\n     - 1 Haas VF-2SS CNC vertical machining center\nOnly return items found in the document, and do not include the examples provided in the instructions above.\nIn your answer, do not comment or add any additional information – only respond with information on equipment found in the document, or else [generic].\n'}, {'file_data': {'file_uri': 'gs://ae-ai-bucket/ucc/florida/images/1999/1999_01/1999_01_0

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Th issue is being looked at. Thanks.

A fix is expected to roll out in early November.

@TongmengXie: please check if this issue is still happening to you. Thanks.

I still got the same error just now. Or do I need to pull "gemini/batch-prediction/intro_batch_prediction.ipynb" before running it? I saw this notebook was committed 4 days ago.

@TongmengXie yes, please pull the latest code and try again. If you still have the error, please open a ticket in https://issuetracker.google.com/issues and post the ticket number here. If possible, in the ticket, please include your project ID and the details of your batch prediction job and the input data and output response. Thanks.

Updating a comment here, running the command referenced in this SO article fixed this for me:
https://stackoverflow.com/questions/66240700/how-to-create-a-ai-platform-custom-code-service-agent-service-xxxxgcp-sa-aipla
gcloud ai custom-jobs create --display-name test1 --region central --worker-pool-spec=replica-count=1,machine-type=n1-highmem-2,container-image-uri=[gcr.io/google-appengine/python](http://gcr.io/google-appengine/python)

@jblythe Thank you for the follow-up.
It's expected that this issue has been fixed so no workaround should be needed. If you or anyone else is still experiencing this issue with batch prediction. Please reopen this issue. Thank you!


[Snyk] Security upgrade node from 16.14.2-alpine to 16.16.0-alpine

This PR was automatically created by Snyk using the credentials of a real user.Keeping your Docker base image up-to-date means you’ll benefit from security fixes in the latest version of your chosen image.
Changes included in this PR

local.Dockerfile

We recommend upgrading to node:16.16.0-alpine, as this image has only 0 known vulnerabilities. To do this, merge this pull request, then verify your application still works as expected.
Some of the most important vulnerabilities in your base image include:

Severity
Priority Score / 1000
Issue
Exploit Maturity

514
HTTP Request Smuggling SNYK-UPSTREAM-NODE-2946427
No Known Exploit

514
HTTP Request Smuggling SNYK-UPSTREAM-NODE-2946428
No Known Exploit

514
HTTP Request Smuggling SNYK-UPSTREAM-NODE-2946723
No Known Exploit

514
DLL Hijacking SNYK-UPSTREAM-NODE-2946727
No Known Exploit

514
Information Exposure SNYK-UPSTREAM-NODE-2946729
No Known Exploit

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Upgrade covered by this PR - https://github.com/alphagov/di-ipv-cri-fraud-front/pull/309
Closing ticket


Sort By displays no options in mobile version

Hi @llaske
In the mobile version, we can see that there are no option being displayed for sort by, even though if we click anyone of them, it sorts the order
Same ways in desktop version also, we see the arrow only if we hover above the top activity on the left side

That's right.


fix: import borked user

Jira link (if applicable)
N/A
Change description
Import borked sendgrid user.
Checklist

[x] commit messages are meaningful and follow good commit message guidelines
[ ] README and other documentation has been updated / added (if needed)
[ ] tests have been updated / new tests has been added (if needed)
[ ] Does this PR introduce a breaking change

Plan Result (nonprod)
:warning: Resource Deletion will happen :warning:
This plan contains resource delete operation. Please check the plan result very carefully!
Plan: 4 to add, 0 to change, 4 to destroy.

Replace

module.pcol.sendgrid_domain_authentication.domain-authenticate["hmcts.net"]
module.pcol-dns.azurerm_dns_cname_record.record1["hmcts.net"]
module.pcol-dns.azurerm_dns_cname_record.record2["hmcts.net"]
module.pcol-dns.azurerm_dns_cname_record.record3["hmcts.net"]

Change Result (Click me)

  # module.pcol.sendgrid_domain_authentication.domain-authenticate["hmcts.net"] must be replaced
-/+ resource "sendgrid_domain_authentication" "domain-authenticate" {
      + custom_dkim_selector = "pnl" # forces replacement
      - custom_spf           = false -> null
      ~ dns                  = [
          - {
              - data  = "pnl.domainkey.u33702686.wl187.sendgrid.net"
              - host  = "pnl._domainkey.hmcts.net"
              - type  = "cname"
              - valid = false
            },
          - {
              - data  = "pnl2.domainkey.u33702686.wl187.sendgrid.net"
              - host  = "pnl2._domainkey.hmcts.net"
              - type  = "cname"
              - valid = false
            },
          - {
              - data  = "u33702686.wl187.sendgrid.net"
              - host  = "em7731.hmcts.net"
              - type  = "cname"
              - valid = false
            },
        ] -> (known after apply)
      ~ id                   = "21552500" -> (known after apply)
      ~ ips                  = [] -> (known after apply)
      ~ subdomain            = "em7731" -> (known after apply)
      ~ username             = "hmcts-pcol-nonprod" -> (known after apply)
      ~ valid                = false -> (known after apply)
        # (3 unchanged attributes hidden)
    }

  # module.pcol-dns.azurerm_dns_cname_record.record1["hmcts.net"] must be replaced
-/+ resource "azurerm_dns_cname_record" "record1" {
      ~ fqdn                = "pnl._domainkey.hmcts.net." -> (known after apply)
      ~ id                  = "/subscriptions/ed302caf-ec27-4c64-a05e-85731c3ce90e/resourceGroups/reformmgmtrg/providers/Microsoft.Network/dnsZones/hmcts.net/CNAME/pnl._domainkey" -> (known after apply)
      ~ name                = "pnl._domainkey" # forces replacement -> (known after apply) # forces replacement
      ~ record              = "pnl.domainkey.u33702686.wl187.sendgrid.net" -> (known after apply)
      - tags                = {} -> null
        # (4 unchanged attributes hidden)
    }

  # module.pcol-dns.azurerm_dns_cname_record.record2["hmcts.net"] must be replaced
-/+ resource "azurerm_dns_cname_record" "record2" {
      ~ fqdn                = "pnl2._domainkey.hmcts.net." -> (known after apply)
      ~ id                  = "/subscriptions/ed302caf-ec27-4c64-a05e-85731c3ce90e/resourceGroups/reformmgmtrg/providers/Microsoft.Network/dnsZones/hmcts.net/CNAME/pnl2._domainkey" -> (known after apply)
      ~ name                = "pnl2._domainkey" # forces replacement -> (known after apply) # forces replacement
      ~ record              = "pnl2.domainkey.u33702686.wl187.sendgrid.net" -> (known after apply)
      - tags                = {} -> null
        # (4 unchanged attributes hidden)
    }

  # module.pcol-dns.azurerm_dns_cname_record.record3["hmcts.net"] must be replaced
-/+ resource "azurerm_dns_cname_record" "record3" {
      ~ fqdn                = "em7731.hmcts.net." -> (known after apply)
      ~ id                  = "/subscriptions/ed302caf-ec27-4c64-a05e-85731c3ce90e/resourceGroups/reformmgmtrg/providers/Microsoft.Network/dnsZones/hmcts.net/CNAME/em7731" -> (known after apply)
      ~ name                = "em7731" # forces replacement -> (known after apply) # forces replacement
      ~ record              = "u33702686.wl187.sendgrid.net" -> (known after apply)
      - tags                = {} -> null
        # (4 unchanged attributes hidden)
    }

Plan: 4 to add, 0 to change, 4 to destroy.

Plan Result (prod)
:warning: Resource Deletion will happen :warning:
This plan contains resource delete operation. Please check the plan result very carefully!
Plan: 1 to import, 10 to add, 1 to change, 4 to destroy.

Create

module.darts-dets.azurerm_key_vault_secret.subuser-api-key
module.darts-dets.sendgrid_api_key.subuser
module.darts-dets.sendgrid_domain_authentication.domain-authenticate["mail-darts-dets-prod.platform.hmcts.net"]
module.darts-dets-dns.azurerm_dns_cname_record.record1["mail-darts-dets-prod.platform.hmcts.net"]
module.darts-dets-dns.azurerm_dns_cname_record.record2["mail-darts-dets-prod.platform.hmcts.net"]
module.darts-dets-dns.azurerm_dns_cname_record.record3["mail-darts-dets-prod.platform.hmcts.net"]

Update

module.darts-dets.sendgrid_subuser.user

Replace

module.pcol.sendgrid_domain_authentication.domain-authenticate["hmcts.net"]
module.pcol-dns.azurerm_dns_cname_record.record1["hmcts.net"]
module.pcol-dns.azurerm_dns_cname_record.record2["hmcts.net"]
module.pcol-dns.azurerm_dns_cname_record.record3["hmcts.net"]

Import

module.darts-dets.sendgrid_subuser.user

Change Result (Click me)

  # module.darts-dets.azurerm_key_vault_secret.subuser-api-key will be created
  + resource "azurerm_key_vault_secret" "subuser-api-key" {
      + id                      = (known after apply)
      + key_vault_id            = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/SendGrid-prod/providers/Microsoft.KeyVault/vaults/sendgridprod"
      + name                    = "hmcts-darts-dets-api-key"
      + resource_id             = (known after apply)
      + resource_versionless_id = (known after apply)
      + value                   = (sensitive value)
      + version                 = (known after apply)
      + versionless_id          = (known after apply)
    }

  # module.darts-dets.sendgrid_api_key.subuser will be created
  + resource "sendgrid_api_key" "subuser" {
      + api_key = (sensitive value)
      + id      = (known after apply)
      + name    = "darts-dets-application"
      + scopes  = [
          + "2fa_required",
          + "mail.send",
          + "sender_verification_eligible",
          + "whitelabel.create",
          + "whitelabel.delete",
          + "whitelabel.read",
          + "whitelabel.update",
        ]
    }

  # module.darts-dets.sendgrid_domain_authentication.domain-authenticate["mail-darts-dets-prod.platform.hmcts.net"] will be created
  + resource "sendgrid_domain_authentication" "domain-authenticate" {
      + automatic_security = true
      + dns                = (known after apply)
      + domain             = "mail-darts-dets-prod.platform.hmcts.net"
      + id                 = (known after apply)
      + ips                = (known after apply)
      + is_default         = true
      + subdomain          = (known after apply)
      + username           = (known after apply)
      + valid              = (known after apply)
    }

  # module.darts-dets.sendgrid_subuser.user will be updated in-place
  # (imported from "hmcts-darts-dets-prod")
  ~ resource "sendgrid_subuser" "user" {
        disabled = false
        email    =<EMAIL_ADDRESS>        id       = "hmcts-darts-dets-prod"
      + ips      = [
          + "<IP_ADDRESS>",
        ]
      + password = (sensitive value)
        user_id  = 44409032
      + username = "hmcts-darts-dets-prod"
    }

  # module.darts-dets-dns.azurerm_dns_cname_record.record1["mail-darts-dets-prod.platform.hmcts.net"] will be created
  + resource "azurerm_dns_cname_record" "record1" {
      + fqdn                = (known after apply)
      + id                  = (known after apply)
      + name                = (known after apply)
      + record              = (known after apply)
      + resource_group_name = "reformmgmtrg"
      + ttl                 = 300
      + zone_name           = "platform.hmcts.net"
    }

  # module.darts-dets-dns.azurerm_dns_cname_record.record2["mail-darts-dets-prod.platform.hmcts.net"] will be created
  + resource "azurerm_dns_cname_record" "record2" {
      + fqdn                = (known after apply)
      + id                  = (known after apply)
      + name                = (known after apply)
      + record              = (known after apply)
      + resource_group_name = "reformmgmtrg"
      + ttl                 = 300
      + zone_name           = "platform.hmcts.net"
    }

  # module.darts-dets-dns.azurerm_dns_cname_record.record3["mail-darts-dets-prod.platform.hmcts.net"] will be created
  + resource "azurerm_dns_cname_record" "record3" {
      + fqdn                = (known after apply)
      + id                  = (known after apply)
      + name                = (known after apply)
      + record              = (known after apply)
      + resource_group_name = "reformmgmtrg"
      + ttl                 = 300
      + zone_name           = "platform.hmcts.net"
    }

  # module.pcol.sendgrid_domain_authentication.domain-authenticate["hmcts.net"] must be replaced
-/+ resource "sendgrid_domain_authentication" "domain-authenticate" {
      + custom_dkim_selector = "prd" # forces replacement
      - custom_spf           = false -> null
      ~ dns                  = [
          - {
              - data  = "prd.domainkey.u33702743.wl244.sendgrid.net"
              - host  = "prd._domainkey.hmcts.net"
              - type  = "cname"
              - valid = false
            },
          - {
              - data  = "prd2.domainkey.u33702743.wl244.sendgrid.net"
              - host  = "prd2._domainkey.hmcts.net"
              - type  = "cname"
              - valid = false
            },
          - {
              - data  = "u33702743.wl244.sendgrid.net"
              - host  = "em5195.hmcts.net"
              - type  = "cname"
              - valid = false
            },
        ] -> (known after apply)
      ~ id                   = "21552595" -> (known after apply)
      ~ ips                  = [] -> (known after apply)
      ~ subdomain            = "em5195" -> (known after apply)
      ~ username             = "hmcts-pcol-prod" -> (known after apply)
      ~ valid                = false -> (known after apply)
        # (3 unchanged attributes hidden)
    }

  # module.pcol-dns.azurerm_dns_cname_record.record1["hmcts.net"] must be replaced
-/+ resource "azurerm_dns_cname_record" "record1" {
      ~ fqdn                = "prd._domainkey.hmcts.net." -> (known after apply)
      ~ id                  = "/subscriptions/ed302caf-ec27-4c64-a05e-85731c3ce90e/resourceGroups/reformmgmtrg/providers/Microsoft.Network/dnsZones/hmcts.net/CNAME/prd._domainkey" -> (known after apply)
      ~ name                = "prd._domainkey" # forces replacement -> (known after apply) # forces replacement
      ~ record              = "prd.domainkey.u33702743.wl244.sendgrid.net" -> (known after apply)
      - tags                = {} -> null
        # (4 unchanged attributes hidden)
    }

  # module.pcol-dns.azurerm_dns_cname_record.record2["hmcts.net"] must be replaced
-/+ resource "azurerm_dns_cname_record" "record2" {
      ~ fqdn                = "prd2._domainkey.hmcts.net." -> (known after apply)
      ~ id                  = "/subscriptions/ed302caf-ec27-4c64-a05e-85731c3ce90e/resourceGroups/reformmgmtrg/providers/Microsoft.Network/dnsZones/hmcts.net/CNAME/prd2._domainkey" -> (known after apply)
      ~ name                = "prd2._domainkey" # forces replacement -> (known after apply) # forces replacement
      ~ record              = "prd2.domainkey.u33702743.wl244.sendgrid.net" -> (known after apply)
      - tags                = {} -> null
        # (4 unchanged attributes hidden)
    }

  # module.pcol-dns.azurerm_dns_cname_record.record3["hmcts.net"] must be replaced
-/+ resource "azurerm_dns_cname_record" "record3" {
      ~ fqdn                = "em5195.hmcts.net." -> (known after apply)
      ~ id                  = "/subscriptions/ed302caf-ec27-4c64-a05e-85731c3ce90e/resourceGroups/reformmgmtrg/providers/Microsoft.Network/dnsZones/hmcts.net/CNAME/em5195" -> (known after apply)
      ~ name                = "em5195" # forces replacement -> (known after apply) # forces replacement
      ~ record              = "u33702743.wl244.sendgrid.net" -> (known after apply)
      - tags                = {} -> null
        # (4 unchanged attributes hidden)
    }

Plan: 1 to import, 10 to add, 1 to change, 4 to destroy.


step() slowness

I encountered a case where the step() method leads to incredibly slow code:
#![feature(step_by)]
extern crate time;
use time::PreciseTime;
extern crate itertools;
use itertools::Itertools;

fn calc2(n: usize) -> Vec<usize> {
    let mut t = vec![0; n] ;
    for i in 2..n {
        if t[i] == 0 {
            t[i] = i - 1;
            for j in (2*i..n).step_by(i) {
                if t[j] == 0 {
                    t[j] = j;
                }
                t[j] = t[j] * (i - 1) / i;
            }
        }
    }
    t
}

fn calc1(n: usize) -> Vec<usize> {
    let mut t = vec![0; n] ;
    for i in 2..n {
        if t[i] == 0 {
            t[i] = i - 1;
            for j in (2*i..n).step(i) {
                if t[j] == 0 {
                    t[j] = j;
                }
                t[j] = t[j] * (i - 1) / i;
            }
        }
    }
    t
}

fn main() {
    let nb = 100_001;
    let start = PreciseTime::now();
    let s = calc2(nb).into_iter().fold(0, |a, c| a + c);
    println!("sum (step_by): {} {:?}", s, start.to(PreciseTime::now()));

    let start = PreciseTime::now();
    let s = calc1(nb).into_iter().fold(0, |a, c| a + c);
    println!("sum (step): {} {:?}", s, start.to(PreciseTime::now()));
}

Replacing step() with the unstable step_by() gives a 100 fold improvement in execution time, as can be observed on the playground here.

It's not really surprising, .step() is written for general iterators and uses .fuse() among other things (whose performance impediment is well known).

Thanks for the explanation. I see now that step_by() is only implemented for ranges.
Should the performance implications be mentioned in the documentation, as a few iterators, such as interleave(), make use of Fuse internally?

It's not just fuse, it's a lot of stuff that needs to be covered. Every adaptor could have its own performance story explained.
Step could possibly be improved with specialization (also fuse-related specialization).

One prerequisite for making the best step iterator for slices (like Stride/StrideMut) is to have arith_offset as a stable function. Then specialization to let us do interesting specializations in itertools itself.

std has Iterator::step_by now. We can deprecate step() when it's stable.

Step has been deprecated in itertools 0.8


The app requires user to be logged in to XP. It should be open to Everyone

Maybe it's not such a good idea.


🐞[Bug]:  Nav bar elements in news page throw an error when clicked

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
Nav bar elements in the news page throw an error when clicked. The elements are not connected via proper link
Expected behavior
The navbar elements should redirect to their proper webpages
Add ScreenShots

What browsers are you seeing the problem on?
No response
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

Please assign this issue to me @varshith257 @Anishkagupta04

Can you please assign this issue to me @varshith257 @Anishkagupta04


delete unused component  in Props Examples

this pr only remove component import in both examples.

Can you also convert LotsOfGreetings to the arrow function?

Can you also convert LotsOfGreetings to the arrow function?

thanks i change your suggestion!!


In the location manager in the settings, fetch up to 40 locations (was 10)

Also, sort them by name.
Fixes UIORG-101.

yarn run v1.6.0
$ eslint *.js settings
/home/jenkins/workspace/folio-org/ui-organization/PR-107/project/settings/Plugins.js
4:1  error  'stripes-config' should be listed in the project's dependencies. Run 'npm i -S stripes-config' to add it  import/no-extraneous-dependencies
✖ 1 problem (1 error, 0 warnings)
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

All UI Regression Tests PASSED. Details at:  https://jenkins-aws.indexdata.com/job/folio-org/job/ui-organization/job/PR-107/1/UI_20Regression_20Test_20Report/


Can't load module 'libsqlite3'

OS: win10
nvim version : nightly build
let g:sqlite_clib_path = 'C:/Neovim/bin/sqlite3.dll

local sqlite = require"sqlite"

sqlite.db:create("todos", {
    id = {"int", "primary", "key"},
    title = "text",
    name = { type = "string", reference = "sometbl.id" },
    ensure = true -- create table if it doesn't already exists (THIS IS DEFUAULT)
})

Thanks for reporting. It should work now.


RTK fussion is broken, only works with heading=0

Fixed in https://github.com/ctu-mrs/mrs_uav_odometry/commit/a3c70c6cf3ffda37e18a0ceb7087d7590ad7cbf4


Revert "Update fork to zephyr master"

Reverts daor-oti/zephyr#1

Reverted due to need of rebase, perhaps, instead of merge.


Feature/issue 61 clean up recommended tasks selector

@bensinjin a PR with some more Ramda cleanup in the same spirit as the one a couple of days ago. Not a rush to get this in...


Handle long validation message at mobile page width

Hi, it would be nice that filepond could show long validation message at mobile page width.
For example in the CodePen below, if uploaded file is above 1MB - validation message doesnt fit to pond widht and filename is pushed out of pond too.
https://codepen.io/vova-tkachenko/pen/QZBobm
Probably such long messages should have 'max-width' set to width of pond fall down to the next line.

It shouldn't overlap/overflow like that, I'll see if I can fix that first and then introduce a different item layout option that has more room for text.

Support for this would be awesome. I have users uploading multiple files, so on desktop am using
    @media (min-width: 50em) {
        .filepond--item {
            width: calc(33.33% - .5em);
        }
    }

When an error is returned, it isn't constrained (silly length error message used for emphasis):

Note the 'Upload' and 'Retry' button to the right of the error message are hidden as I have my own upload button which I need users to click.
[Aside: I did this via CSS as setting styleButtonProcessItemPosition to null or false didn't remove them. Is that the best way?]

Yes, this is not good. I'll try to give this some more priority.

I had a play with the CSS but didn't solve it, sorry. My frontend skills are very rusty...

@rikschennink Sorry for hassling, but any chance you can look at this?

facing a similar issue where the whole area to drag and upload a file (grey container) appears throughout the width of the page. adding a CSS file didn't work. saw a similar issue in vue.js where it was corrected but I guess not in react. is somebody else facing any such issue?

@pbowyer no problem, I'm simply too busy.
This cuts of the text, so at least it doesn't exit the bounding box.
.filepond--file-status {
    overflow: hidden;
    max-width: 50%;
}

For a definitive fix the element should scale in height to make room for the error message, which introduces all kinds of other issues.

hi @rikschennink
appreciate your work done regards this control
right now on mobile device an error message looks like this:

quick question - is there any further investigations/work on this issue?

Hi @rikschennink
Appreciate your work done regards this component!
Quick question - is there any investigation/work on this issue?
Thanks!

@nikolaidenis I'm working on v5 in which I want to address all these kinds of core problems.

How do you think, when will you finish working on version 5?
pon., 6 mar 2023 o 08:39 Rik @.***> napisał(a):

@nikolaidenis https://github.com/nikolaidenis I'm working on v5 in
which I want to address all these kinds of core problems.
—
Reply to this email directly, view it on GitHub
https://github.com/pqina/filepond/issues/150#issuecomment-1455613120,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AN4DNFFPLIKY3QF2WWNNCIDW2WICRANCNFSM4F6N7OPQ
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

--
Pozdrawiam
Marcin Kaźmierczak

Honestly no idea. Hope before summer.

The issue is still relevant, latest filepond version (as of 2023-11-05) is 4.30.4


[Feature Request] Add an option to set your own descriptor resolver

Feature description:

Similar to WithExtensionTypeResolver, it would be helpful to allow adding your own WithDescriptorResolver option.
Problem it solves or use case:

It will allow using dynamic schema registries outside of global protoregistry.Files
Proposed implementation or solution:

Something like:
func WithDescriptors(resolver ...protodesc.Resolver) ValidatorOption {
  return func(cfg *config) {
    cfg.descResolver = resolver
  }
}

@rauanmayemir, the only way a descriptor resolver might be used is for CEL expressions that operate on google.protobuf.Any messages. Is that the issue you are encountering? If not, please describe the issue you are encountering with dynamic schemas, in case you're running into something else (like a bug).

@jhump No, that wasn't my issue. Apparently, I didn't even have to add my regular message descriptors because the input message already has a ProtoReflect() with all the information, is that correct?

That's correct. A descriptor resolver is generally unnecessary since the message being validated knows its own descriptor (and all fields therein know their message types, too).
The only time you would run into trouble is when using google.protobuf.Any messages, where the contained message payload is a dynamic message (i.e. not known to the program via protoregistry.GlobalFiles). In this case, there are some operations in CEL expressions that will try to unpack the Any message, which would fail in this case. This is the only case where you would benefit from an option like this, to provide additional dynamic message types that can be unpacked to the CEL interpreter.


Open a WebSockets after Uploading a file

Description
Attempting to open a WebSocket immediately after uploading a file using an XMLHttpRequest() cause a connection failure.
To Reproduce
Steps to reproduce the behavior:

Create a WebPage that allow uploading as well as to create a websocket.
upload a file using XMLHttpRequest()
as soon as upload have been completed then create a WebSocket()
See error connection fail.

Expected behavior
The connection will be completed sucessfully.
Additional context
Webserver have one single listener on port 8080 and different endpoints "/upload_endpoint" used for uploading files, "/output" used for the websockets and "/" that is the default.

A full project to reproduce this issue is:   https://github.com/D-A-M-O-F/gaia-web.git  using TAG v0.3.0 .

The problem is caused by AWS ALB's connection reuse strategy. It tries to use the same http connection to the upstream. The websocket connection request is sent after your upload request, so it is not the first request, and the server will refuse it.
To bypass this behavior of ALB, you can use a dedicated port for websocket requests in your web application.

Hi @hwc0919 , thanks for taking the time to read and answer, anyway the problem is NOT AWS NLB.
Accordingly, with my investigations before to open the issue, this problem occurs even without NLB, you can try a minikube evenvironment and you still have the issue, as well as directly using the webserver and still have the issue, in fact this kind of problem seems generated by client side, but on client side it is not a "bug" it documented as feature from basically all browsers, one more confirmation can be using a different client than a browser such as PostMan and in such case you will see everything working since postman create a new connection each time.
If you read the description for the issue I didn't mention AWS NLB since this component, as far as I saw in all my tests, is working fine.
The comment I added at the end of the day, was intended to help someone facing the problem with the solution I have been implemented. I still have only port 80 exposed from the NLB and using traffic management rules to multiplex requests internally to 8080 ( defaul ), 8888 ( /output ).  This solution is transparent for the client side and I do not have to expose other ports.
The project is in a public repository ( https://github.com/D-A-M-O-F/gaia-web.git ), so:

You can download tag v0.3.0 of the project and try in a local environment facing the issue.
With tag v0.4.0 I just add a new port listener on webserver side to implement the multiplex as described in my comment. I didn't post all HELM CHAT since it is out of topic, if someone is facing the same issue and need help can drop me a message and I will be happy to help.


Added plugin rebar3_edoc_extensions

As discussed with @dumbbell, was created plugin rebar3_edoc_extensions with same logic for generation of documentation. For generate documentation before publish to hex.pm need to use:
rebar3 edoc_extensions

This command will generate documentation with the same style what is used before.

Pull Request Test Coverage Report for Build 146

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+3.6%) to 82.37%

Totals

Change from base Build 143:
3.6%

Covered Lines:
1168

Relevant Lines:
1418

💛  - Coveralls

I submitted a pull request to update the rebar3_edoc_extensions plugin to override the edoc command. It will also fetch PrismJS and GitHub Actions files automatically.
See vkatsuba/rebar3_edoc_extensions#14.
Based on that, it should be simpler to use and integrate this plugin into Khepri.

@dumbbell updated with latest release of rebar3_edoc_extensions


Allow option to disable basic auth header in generic oauth

Basic authentication still enabled by default
Adds configuration parameter to remove Authorization header
User can send client_id and client_secret via extra_params configuration parameter

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9ba6c30). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   81.05%
=========================================
  Files             ?       16
  Lines             ?      966
  Branches          ?        0
=========================================
  Hits              ?      783
  Misses            ?      183
  Partials          ?        0

Impacted Files
Coverage Δ

oauthenticator/generic.py
93.54% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ba6c30...56d9144. Read the comment docs.


add frame_system::DefaultConfig to individual pallet DefaultConfigs

step in https://github.com/paritytech/substrate/issues/14234. It solves the issue explained in the next section, and it makes pallet-proxy and pallet-multisig use derive_impl for frame-system and pallet-balances.
Overview
This changes the DeriveImpl experimental line of work as follows. Before this PR, the generated trait always looked like this:
trait DefaultConfig {
  Item1;
  Item2;
  ...
}

After this PR, if the trait Config is itself bound by frame_system::Config, then it generates the following:
trait DefaultConfig: frame_system::DefaultConfig {
  Item1;
  Item2;
  ...
}

This requires you to implement for frame_system::DefaultConfig eg. TestDefaultConfig, but luckily this can in itself be done by derive_impl. For example, in pallet-example-default-config, we have:
pub struct TestDefaultConfig;

#[derive_impl(frame_system::config_preludes::TestDefaultConfig as frame_system::DefaultConfig)]
impl frame_system::DefaultConfig for TestDefaultConfig {}

#[frame_support::register_default_impl(TestDefaultConfig)]
impl DefaultConfig for TestDefaultConfig {
	...
}

This allows types that are reliant on frame_system::Config to also possibly have defaults, as long as they are present in frame_system::DefaultConfig.
Something like type Foo: Get<<Self as frame_system::Config>::RuntimeCall> still can (and for the foreseeable future will) not have a default, as it is not present in frame_system::DefaultConfig.
Next Steps / Questions
Currently, the code for impl DefaultConfig for SomeStruct is pure Rust. So, we don't have any way to inject impl frame_system::DefaultConfig for TestDefaultConfig {} into it. For now, I am happy to keep it as is, but possibly prior to stabilization, we can have something like #[pallet::default_config_impl] struct TestDefaultConfig and this should:

auto-inject register_default_impl
possibly auto-inject impl frame_system::DefaultConfig for _

Moreover, the current implementation indeed relies on the name frame_system::DefaultConfig, which is fine for now.

Not sure why you not try out what I had outlined here: https://github.com/paritytech/substrate/pull/13454#issuecomment-1495855632
This should also give you access to the types from frame-system.

Not sure why you not try out what I had outlined here: #13454 (comment)
This should also give you access to the types from frame-system.

I had actually overlooked it, thanks for the follow-up. I will look into it and revise.

@bkchr the only issue I see with your approach is what I have highlighted here: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=34052108e3149aedb7f80e367eac85c7

@bkchr the only issue I see with your approach is what I have highlighted here: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=34052108e3149aedb7f80e367eac85c7

@kianenigma the link doesn't work.

Solution2: We know all other Self types, so whatever is not in Self must have come from  <Self as frame_system::Config>::AccountId and must be replaced with T::AccountId.

If I understand this correctly, it sounds like the correct solution. Basically you are saying, if we see that Self::Whatever the Whatever is declared in the trait itself, then we don't need to replace Self with T?

@bkchr I was looking into your suggestion, specially around:
trait DefaultSomethingConfig<T: SomethingConfig> {
    type DoSomething: DoSomething<T::AccountId>;
    type Whatever;
}

However, we would need the generic to be bound by DefaultSystemConfig to use the correct types, something like:
trait DefaultSystemConfig {
    type AccountId = u64;
}

trait DefaultSomethingConfig<T: DefaultSystemConfig> {
    type DoSomething: DoSomething<T::AccountId>;
    type Whatever;
}

Thus, we would need a separate expansion for DefaultSystemConfig and other default configs would assume this to be present. I am not completely convinced that it would be a good solution, but let me know your thoughts.
CC: @kianenigma @sam0x17

Question is, how often do we see this? But this is the proper solution using Rust.

IMO, this would actually happen for all types that are referenced in the super trait and the current trait. The reason being that the type in the actual config would be different than DefaultConfig. However, we are specifying the generic bound as the config, causing the conflict.

IMO, this would actually happen for all types that are referenced in the super trait and the current trait.

That was not my question. My question was on how many types we have where this is required. For sure for stuff like Balance this will probably happen quite often, but it also doesn't look that ugly/is that special.

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3180898

IMO, this would actually happen for all types that are referenced in the super trait and the current trait.

That was not my question. My question was on how many types we have where this is required. For sure for stuff like Balance this will probably happen quite often, but it also doesn't look that ugly/is that special.

I can think of AccountId, AssetId and AssetBalance. Probably a few others as well?

Yeah for sure, but what would be the other way to solve this?

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/3180985

How about something like this? https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=15464bac0dd043c8ab8a4ce3650523b0

Then we still require that the type implements DefaultSystemConfig and DefaultSomethingConfig and basically that is what this PR here is about.

bot fmt

@bkchr @kianenigma @sam0x17 This is ready for review.

@bkchr @kianenigma @sam0x17 This is ready for review.

Another point this pr is missing is when a pallet has not only the system pallet as supertrait, but also another pallet. So, we should be generic over the supertraits.

With the way this PR is working, there seems to be no path to have defaults for things like RuntimeEvent. Is this correct, or do you have a plan around those?

With the way this PR is working, there seems to be no path to have defaults for things like RuntimeEvent. Is this correct, or do you have a plan around those?

I was hoping to pick up this suggestion from @sam0x17 as a follow-up - https://github.com/paritytech/substrate/pull/14437#discussion_r1251861668

With the way this PR is working, there seems to be no path to have defaults for things like RuntimeEvent. Is this correct, or do you have a plan around those?

I was hoping to pick up this suggestion from @sam0x17 as a follow-up - #14437 (comment)

I don't think that this will work all the way though, even with pallet::no_bound. With this macro, we will be able to add items to systemDefaultConfig without any bounds, such as:
// frame-system
trait DefaultConfig {
    type Block: Bound1 + Bound2 + ...
    type RuntimeEvent; // no bound, because we marked it as such.
}

But then what? still, somewhere, in frame/system/src/lib.rs we need to provide an
// still in frame-system
impl frame_system::DefaultConfig for PoorTypeThatCannotStillProvideADefaultForRuntimeEvent {
    type RuntimeEvent = ???
}

Which as I joked in the name, still cannot provide a sensible default for RuntimeEvent, even if it has no bounds.
The only solution to fix this, as far as I can see, is to make something be generic over <X: frame_system::Config> (or as a super-trait, as opposed to frame_system::DefaultConfig)

The only solution to fix this, as far as I can see, is to make something be generic over <X: frame_system::Config> (or as a super-trait, as opposed to frame_system::DefaultConfig)

Thanks, I do see your point but I am not completely sure if this approach would work as well. Even if DefaultConfig is defined as follows:
trait DefaultConfig<T: frame_system::Config> {
   type RuntimeEvent;
}

this would still require someone to specify RuntimeEvent at the impl site?
My idea with #[verbatim] was to allow defaults that are replaced with the same names at the impl site, assuming that such a type exists in scope. So, you would have
trait DefaultConfig {
    type RuntimeEvent; // no bound, because we marked it as such.
}

struct TestDefaultConfig;
impl DefaultConfig for TestDefaultConfig {
   #[verbatim] // add an attribute here to hint derive_impl
   type RuntimeEvent = ();
}

and later derive_impl replaces it as
impl frame_system::Config for Runtime {
   type RuntimeEvent = RuntimeEvent;
}

Note that verbatim and no_bound are entirely separate macros here. The later is actually used when providing the default implementation. I am just worried that we are making too many assumptions here, but that might be acceptable?
This verbatim attribute while implementing the DefaultConfig might actually be extended to provide other types that are assumed to be present at the impl site. For example,
struct TestDefaultConfig;
impl DefaultConfig for TestDefaultConfig {
   #[verbatim(TestBlock)]
   type Block = ();
}

becomes
impl frame_system::Config for Runtime {
   type Block = TestBlock;
}

and assumes that TestBlock exists.
I still need to see this in actual code to make sure that it works, but just wanted to put it down here.

I am actually writing the docs right now for supertrait but I think it might handle these scenarios (will have to double check). It handles generics perfectly and you can make use of Self:: types etc. i.e. https://github.com/sam0x17/supertrait/blob/main/tests/tests.rs#L231-L279

I still need to see this in actual code to make sure that it works, but just wanted to put it down here to see if this makes sense at all.

https://github.com/paritytech/substrate/pull/14682 describes the POC for this idea. @kianenigma @bkchr @sam0x17 Would love to get some feedback on it.

I think this should migrate over painlessly to supertrait, which I'm planning to release on crates.io tonight and should handle some of these edge cases, especially around generics, more gracefully

I'm not yet clear on what issue we exactly solve with supertrait? I would appreciate it if you write down the issues that we have now, and how we intend to solve them in a new issue, if they still persist.

bot merge


Visible Custom Shapes not updating when doing custom extents

Godot version:
39bdffa57c667f575520b59e84199d0e46a4f1c0
OS/device including version:
Linux
Issue description:
Debugging Visible Custom Shapes not showing correctly when doing custom extents from code.
I tested the same with 2D counterparts, and it works.
Steps to reproduce:
Add a KinematicBody with a CollisionShape, trought code change extents and Enable Visible Custom Shapes
Minimal reproduction project:
collision_bug.zip

Duplicate of #17300


added more detail to allocators

Added more information to the mimalloc section in alternative allocators and added a reference to the cesium-allocator crate for dedicated heap allocation.

Thanks for the PR. I won't take it because (a) the mimalloc description reads too much like an advertisement, and (b) I don't know what cesium-allocator is, and its minimal docs don't help much.
But it is reasonable for the mimalloc instructions in the perf-book to have the same details as the jemalloc instructions, so I committed https://github.com/nnethercote/perf-book/commit/d33766ad73014c323f2a45c485e8ae2f03a747d0.

Works for me, thanks!


Get Govdirectory onto Mastodon!

Description
We could have it repost things from the Twitter account(or the opposite way around?!).
We would need to select an instance.

We would need to select an instance.

I would be happy with mastodon.social och mastodon.online as these are stable and controlled by an NGO but maybe there is a stable one matching Govdirectory well?

One that I come to think of is fosstodon.org

wikis.world is now the obvious one in my opinion!

Done! https://wikis.world/@govdirectory


Extended search.php

It should be possible to get a extended search form, where you can search for author, date and topic

Added with 98c604c5aafde3c939fe4b94b46e957b9c776a70


+w command is broken

🐛 Bug Report
Ever since the last update, searching stuff using wiki command brings up an unexpected error message, as seen here https://i.imgur.com/XOIMGF5.png

Should be fixed now.


ChainWatch dapp

Summary
A user-facing application to monitor the state of the network and the on-chain assets.
Details
Monitor staked assets and validators.
Trigger notifications in case the validator has stopped responding.
Display the information about the state of the assets (delegating/undelegating with ETAs)
Ability to stake (?)
UI/UX
A website with Signer integration.

@RitaMAllenCA this should be moved to the L2 board

Issue moved to casper-network/Governance #423 via Zenhub


feature/buffer for rtx cache

EvictingBuffer for better RtxCache performance

Worth nothing this implementation can "loose packets" before the buffer eventually grows.
i.e. this test fails
    #[test]
    fn push_and_get_dade() {
        let mut buf = EvictingBuffer::new(2, Duration::from_secs(10));
        let now = Instant::now();

        buf.push(3, now, 'A');
        buf.push(5, now, 'B');

        assert_eq!(buf.get(3), Some(&'A'));
        assert_eq!(buf.get(5), Some(&'B'));
    }

This is especially true if the user sets a small size counting on the fact that it auto grows.
I think in case of video the initial size should be something that fits a keyframe (you want to start with a keyframe, and to avoid additional keyframe requests due to lack of retransmission)

I think the doc around RtcConfig.set_send_buffer_* could not mention this is a min size and the buffer auto-grows

I'm expecting the initial buffer size to be big enough to hold the NACK amount required. I.e. if we want 2 seconds of NACK, a good initial buffer size should be able to hold the initial keyframe + more packets up to 2 seconds.
The buffer does grow, but I don't think it's good to rely on that only instead of making a good initial guess.

Shouldn't the rtt or the ack time decide the rough size of the buffer. Then with a cap of 3 seconds I think they had it in libwebrtc?


RN: Crash on Android when trying to loginWithFacebook

This works perfectly on iOS but I get a crash on Android.
I use Expo and the bundled Expo Facebook Login feature. I can properly get the status and token but when calling await loginWithFacebook({ accessToken: token }, apollo);, here is what I get:
undefined is not a function (evaluating 'Object.setPrototypeOf(_this, ApolloError.prototype)')
ApolloError
    bundle.umd.js:145:22
error

error
    zen-observable.js:198:24
error
    bundle.umd.js:19:8
error
    zen-observable.js:198:24
error
    zen-observable.js:198:24
<unknown>

tryCallOne
    core.js:37:14
<unknown>
    core.js:123:25
<unknown>
    JSTimers.js:301:23
_callTimer
    JSTimers.js:154:6
_callImmediatesPass
    JSTimers.js:202:17
callImmediates
    JSTimers.js:470:11
__callImmediates
    MessageQueue.js:329:4
<unknown>
    MessageQueue.js:147:6
__guardSafe
    MessageQueue.js:316:6
flushedQueue
    MessageQueue.js:146:17
callFunctionReturnFlushedQueue
    MessageQueue.js:121:11

Here are my dependencies:
"dependencies": {
    "@expo/vector-icons": "^6.2.2",
    "apollo-boost": "^0.1.3",
    "expo": "^25.0.0",
    "graphql": "^0.13.2",
    "graphql-tag": "^2.8.0",
    "lodash": "^4.17.5",
    "meteor-apollo-accounts": "^2.0.3",
    "moment": "^2.21.0",
    "prop-types": "^15.6.0",
    "react": "^16.2.0",
    "react-apollo": "^2.1.0",
    "react-native": "https://github.com/expo/react-native//archive/sdk-25.0.0.tar.gz",
    "react-native-animatable": "^1.2.4",
    "react-native-easy-grid": "^0.1.17",
    "react-native-google-places-autocomplete": "^1.3.6",
    "react-native-iphone-x-helper": "^1.0.2",
    "react-native-maps-directions": "^1.6.0",
    "react-native-modal-datetime-picker": "^4.13.0",
    "react-native-router-flux": "^4.0.0-beta.28",
    "react-native-segmented-control-tab": "^3.2.2",
    "react-native-status-bar-height": "^2.0.0",
    "react-native-vector-icons": "^4.5.0",
    "react-redux": "^5.0.7",
    "redux": "^3.7.2",
    "redux-form": "^7.3.0"
},

After some investigations, it's related to<EMAIL_ADDRESS>Downgrading to 2.2.7 solved the issue.
See: https://github.com/apollographql/apollo-client/issues/3236


Little Deviants™ [PCSA00010]

App summary

App name: Little Deviants™
App serial: PCSA00010
App version: 1.00

Vita3K summary

Version: v0.1.8
Build number: 3193
Commit hash: https://github.com/vita3k/vita3k/commit/9837745e
CPU backend: Dynarmic
GPU backend: Vulkan

Test environment summary

Tested by: Gerold55
OS: Windows 11
CPU: Intel Core i5 9300H
GPU: NVIDIA Geforce GTX 1650
RAM: 8 GB

Issues

Shadows aren't rendering properly and when loading up the game and you get to the sony entertainment screen it gives an error.
Screenshots

Log
Recommended labels

Ingame -

In latest build, no error dialog shows up after SCE logo, and shadows are rendering fine.
vita3k.log
Please change the tag to Playable.


bundler/inline warning: method redefined; discarding old root

bundler/inline works by redefining Bundler.root and then putting it back again... but ruby -w isn't a fan of that technique.
We get a warning when it installs its new version:
/home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/site_ruby/2.4.0/bundler/inline.rb:42: warning: method redefined; discarding old root
/home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/site_ruby/2.4.0/bundler.rb:216: warning: previous definition of root was here

and another when it returns the original:
/home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/site_ruby/2.4.0/bundler/inline.rb:73: warning: method redefined; discarding old root
/home/travis/.rvm/rubies/ruby-2.4.1/lib/ruby/site_ruby/2.4.0/bundler/inline.rb:42: warning: previous definition of root was here

This isn't a PR, mostly because I'm not sure which of the various not-great alternatives you'd prefer in order to make it happy. The ones I know of are:

remove the method before redefining it -- which can be racy for other threads, though I guess inline isn't exactly thread-friendly to begin with
alias the method before redefining it -- this is what we're moving to in Rails, but it feels pretty unclear for a future reader
avoid redefining the method at all -- feels like a lot of work for no real gain, to fix a papercut of a warning

remove the method before redefining it -- which can be racy for other threads, though I guess inline isn't exactly thread-friendly to begin with

This would be my choice. Anything around bundler/inline, bundler/setup etc isn't close to thread-safe at the moment, so racing isn't a concern for me there


Bug fix entry on scene do not merge and  applied hook for better foundryvtt integration

This should be fix the error i see on the discord channel, sorry about that.

it should be the fix for https://github.com/kandashi/sidebar-context/issues/4


TGL-H: sample_decode on H265 is not working

Failed to decode the following format in TGL-H. Here are the media stacks used
Libva: 8c6126e67c446f4c7808cb51b609077e4b9bd8fe
MSDK: 948f7b71fec2703a9345105d0308d95b92577daf
Media Driver: 1c8e076cad591702a0faa1fae1f429e517d33811
gmmlib: intel-gmmlib-20.2.4
Sample Output:
root@intel-corei7-64:/mount# cd H265_Videos/
root@intel-corei7-64:/mount/H265_Videos# /usr/lib64/mfx/samples/sample_decode h265 -vaapi -hw -i Puppies_3840x2160_20mbps_30fps_High_at_L5.0.mkv -r -rgb4 -f 30
libva info: VA-API version 1.10.0
libva info: User environment variable requested driver 'iHD'
libva info: Trying to open /usr/lib64/dri/iHD_drv_video.so
libva info: Found init function __vaDriverInit_1_10
libva info: va_openDriver() returns 0
[ERROR], sts=MFX_ERR_MORE_DATA(-10), InitMfxParams, m_FileReader->ReadNextFrame failed at /home/root/MediaSDK/samples/sample_decode/src/pipeline_decode.cpp:774
[ERROR], sts=MFX_ERR_MORE_DATA(-10), Init, InitMfxParams failed at /home/root/MediaSDK/samples/sample_decode/src/pipeline_decode.cpp:538
[ERROR], sts=MFX_ERR_MORE_DATA(-10), main, Pipeline.Init failed at /home/root/MediaSDK/samples/sample_decode/src/sample_decode.cpp:773

close the issue due to wrong video file used since sample decode accepted bitstream file


Fix #1126 - add check for default controller in Route.findControllerConstructor

Default controller specified with Router.configure should be used when a route does not define one.

:+1:

So Router.options are not set as the default values for each individual route's options?

This fix is specific for the controller option not working when using Router.configure. (Refer to #1126)
Other options in Router.configure should be working. (It should be another issue if you observe otherwise.)

@tmeasday Is there any specific reason that this PR is not going through? This bug is biting people, let's do something about it? :)

Hi @seeekr - I think perhaps @cmather is the person to ask?

Thanks Tom! I just pinged the first project owner I saw :)
@cmather If I can help make a release happen I'll be happy to volunteer my time for that. I had a look through all other PRs and most of them are valuable docs improvements and would be easy enough to merge. Also it seems like the open issues could use some love, too. I'd be available to help with that as well and do the work of compiling a list of (potential) issues and seeing what I can do about them.

I'm going through them this morning. Thanks for offering to help. Any help with moderating open issues would be helpful.


A behave test scenario making use of attributes is needed

Description

In order to increase the Behave test coverage, a scenario making use of attributes is required
Describe How to Reproduce

Run behave tests.

@binhn can you assign me this issue?

Closed by #2128


unspentonly output not updated

Hello,
While an unconfirmed transaction http://api.qbit.ninja/transactions/43eaab5060bd2ba614b1839f1e47662be267d0135a81ed3bd6535e0a605484f3 has spent an output (40feb5d2615af9261070989c4ef5bdadfe40598042b53da8f24953a3d1ac87e6 index 1) this is listed as unspent (http://api.qbit.ninja/balances/38CPJmQaWVsVka6bzEgafgZqSuJQazEjML?unspentonly=true)
transaction.txt
unspent.txt

interesting, looking at it.

I don't see it in http://api.qbit.ninja/balances/38CPJmQaWVsVka6bzEgafgZqSuJQazEjML?unspentonly=true

What could have happened is the following: If the transaction take time to be confirmed then the unspentOnly "forgot" the spending. This is done for preventing stuck coins to never be redeemed.
Can it be the case ?

Yes, it seems it could happen, if the described behavior is present in the code. The current transaction has OP_RETURN output (it is open assets) and it seems some miners do not mine transactions with such output well.
But could this forget time be configured somehow? Since in short time when nodes has not forgotten the transaction, this could create possible double spend.

mmh actually the expiration time is 30 minutes, this seems wrong I thought I've put much more.
I can increase the time to 6 hours. Making it configurable is possible, but in my mind a big enough expiration should be just enough.

Thanks. If you don't mind, would you please point me to the source code line?

In main net, open assets transactions take more than a day to get confirmation.

https://github.com/MetacoSA/QBitNinja/commit/919a17a7cb517971fcfebe1f1f1c7fe59c234db2
I'll update the servers today.
More than a day for a confirmation ? can you point me out on such transaction ? it should not take so long.

All those transactions has got confirmation now. I will notify you when I encountered such a transaction.

I updated the servers. Open Asset transactions should not take a day to get a confirmation, we need to find out why.

For example check this: https://www.blocktrail.com/BTC/tx/da8988400f2460d068f9d34a53441b42edcdd223aa62dc25451c4e54a44e0164?txoutIdx=1 it has been confirmed after more than 17 hours.
The reason behind this may 2 things, a- the OP_RETURN output itself (some do not like this type of transaction for example https://blockchain.info/pushtx does not broadcast OP_RETURN transactions as far as I remember, so fewer miner may mine the transaction: https://bitcointalk.org/index.php?topic=391491.10;wap2). b- The OP_RETURN bitcoin value is 0 , this could be considered as dust.

no, I think the reason is that 600 satoshi is considered dust for some nodes. (at one point the dust amount was bump for preventing spam attack)
You should try to use more than 600 satoshi. I'm using 2500 satoshi by default with NBitcoin now.
OP_RETURN with 0 as value is not considered dust for bitcoin core.

I think coinprism.com still uses 600 satoshi as Bearer coin for colored coins.

@bijakatlykkex you seem to use NBitcoin and qbitninja, why do you use coinprism API for sending your transactions ?

Coinprism seems to be from original Open Assets developer and is used as a reference, and becoming independent of it, will be in gradual steps.
Thank you for supporting Open Assets in NBitcoin.


problem in the 17 question of html challenge

in the 17 question of html challenge i do this code but Run Tests deosn't work

CatPhotoApp

Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.

Kitty ipsum dolor

can you help me please to continue the other test.

Github issues are not for challenge help. Please visit the Help Chat for assistance.


'default.realm.lock': open() failed: Operation not permitted

How frequently does the bug occur?
Sometimes
Description
We have tracked in our Crashlytics that some users (approximately 300 users) failed to create Realm file with this error 'default.realm.lock': open() failed: Operation not permitted
We have tried to fix this according to this solution, we have set protection at none to the folder that contain default.realm and default.realm.lock before opening realm
Stacktrace & log output
Unable to open a realm at path '<path_to_Documents>/default.realm.lock': open() failed: Operation not permitted Path: <path_to_Documents>/default.realm.lock Exception backtrace: 0 Realm 0x000000010760b3e4 _ZN5realm4util4File13open_internalERKNSt3__112basic_stringIcNS2_11char_traitsIcEENS2_9allocatorIcEEEENS1_10AccessModeENS1_10CreateModeEiPb + 712 1 Realm 0x00000001074bf620 _ZN5realm2DB4openERKNSt3__112basic_stringIcNS1_11char_traitsIcEENS1_9allocatorIcEEEEbNS_9DBOptionsE + 988 2 Realm 0x00000001074c2968 _ZN5realm2DB4openERNS_11ReplicationERKNSt3__112basic_stringIcNS3_11char_traitsIcEENS3_9allocatorIcEEEENS_9DBOptionsE + 124 3 Realm 0x00000001074c7134 _ZN5realm2DB6createE

Can you reproduce the bug?
Not yet
Reproduction Steps
This crash is found on the Firebase console, we can't reproduce it. According to the Firebase, it happens more than 300 times and affects more than 200 users. we tried many solutions like this but we still have this issue:
https://github.com/realm/realm-swift/issues/7874#issuecomment-1177339671
Version
Realm 10.28.2 and earlier
What SDK flavour are you using?
Local Database only
Are you using encryption?
No, not using encryption
Platform OS and version(s)
iOS15
Build environment
Xcode version: XCode 13.4
Dependency manager and version: cocoapods 1.11.3

Thanks for your reply.  It's this we tried to set those protections to default Documents.
So we will create a custom sub-directory and check if this solve this issue in release version.
If we will do this we should move all realm files to this sub-directory, you know if there is other file/directory related to realm to move ?
default.realm.lock
default.realm
default.realm.management

Yes should be those three. Keep in mind that some of these files might get created and deleted by realm system processes, so you can't just apply the protections to the file. Do it to the whole sub-directory. Like mentioned in the earlier link, I think the sub-directory has to be created by you, and not the Documents/.

yes thank you
we will make feedback here after release of this fix

@MarouMhz just checking in to see if you have any feedback after implementing the above suggestions?

We always have crashes reported on Crashlytics even by moving the realm files to Library/Application Support/Realm/
...../Library/Application Support/Realm/default.realm.lock': open() failed: Operation not permitted

@MarouMhz this is not a valid iOS directory. Can you show us where you are setting the Realm path and tell us why you need to be setting it to a custom path?

@MarouMhz do you have any follow up on our last question?


Set-GcsObject -PredefinedAcl PublicRead removes project permissions

The docs for "publicRead" say that the project owner gets OWNER access, and allUsers get READER access. However, what actually happens is that all users get read access and all of the project permissions are completely dropped. For example, if I do the following:
PS gs:\csells-psfun1\images\> ls | %{ Set-GcsObject $_ -PredefinedAcl PublicRead }
and then write this program:
var client = StorageClient.Create();
var images = client
  .ListObjects("csells-psfun1", "images/", new ListObjectsOptions { Projection = Projection.Full })
  .Where(i => i.Acl.Any(acl => acl.Entity == "allUsers"))
  .ToArray();
ViewBag.Url = images[(new Random()).Next(0, images.Length)].MediaLink;

then it works great when running from my local laptop, but it doesn't work at all well when running from a deployed ASP.NET app (the program crashes until that object is removed from the bucket).
I would expect setting publicRead would mimic the "Public link" checkbox in the GCS Browser.

Hi @csells, from the documentation here, it seems setting publicRead actually removes project permissions so I think the cmdlet is doing what it is supposed to do. We can add more documentation or a warning message to the user when using this setting?

We added documentation that all other project permissions are dropped in the doc http://googlecloudplatform.github.io/google-cloud-powershell/#/google-cloud-storage/GcsObject/Set-GcsObject


Rfp/security marketplace

Project Abstract

Please replace these instructions with a brief description of your project summarising key points (1-2 paragraphs).
If your application is a follow-up to a previous grant, please mention which one in the first line of the abstract and include a link to previous pull requests if applicable.

Grant level

[ ] Level 1:  Up to $10,000, 2 approvals
[ ] Level 2:  Up to $30,000, 3 approvals
[ ] Level 3:  Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

[x] The application template has been copied and aptly renamed (project_name.md).
[ ] I have read the application guidelines.
[ ] Payment details have been provided (bank details via email or BTC, Ethereum (USDC/DAI) or Polkadot/Kusama (USDT) address in the application).
[ ] The software delivered for this grant will be released under an open-source license specified in the application.
[ ] The initial PR contains only one commit (squash and force-push if needed).
[ ] The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
[ ] I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks @ParthChaudhary31 you mentioned that this would help save on development costs, does this mean there should be an adjustment in price as well? Or are these only contract deployment costs that aren't covered as part of the grant?

The latter actually, The cost-cutting would be on the front of :
#1) Deployment costs (Contract optimization by merging functionality into a single contract would require deploying fewer contracts).
#2) The Arbiters will not need to spend from their own pockets while voting. (Minimising gas fees Charges).

@semuelle ,
I understand your motives for keeping the Arbiter voting on-chain, The change is a suggestion that we believe would smoothen the onboarding process and encourage arbiters, however, we're perfectly fine with keeping it on-chain as well. If you can verify with the remaining team and give a final verdict on the changes, We'll be able to plan accordingly and start with the development.

@semuelle
Sure, I've re-added the Arbiter's voting contract to milestone 1, We'll start working on it now and aim to finish this soon.

recheck

recheck

recheck


Complete pycodestyle for qiskit/tools

Summary
Have the cmake make style target include qiskit/tools, fixing the
remaining issues in the process (all of them related to escaped \s).
Fix a small visual issue with the skipping message on two tests.
Details and comments

@ajavadia can you check that the Latex output of the circuit drawer remains as expected? The changes mostly escape the \ in some strings related to that functionality.

@ajavadia can you check that the Latex output of the circuit drawer remains as expected? The changes mostly escape the \ in some strings related to that functionality.

@diego-plan9 Yes all works fine.

Thanks for checking @ajavadia !


CAMEL-11363: Use ArrayDeque instead of Stack

https://issues.apache.org/jira/browse/CAMEL-11363
Thanks!

Thanks for the PR it has been merged. Do you mind closing this?

Thanks @davsclaus


AWS CodeDeploy service fails

Please see the thread here:
https://forums.aws.amazon.com/thread.jspa?messageID=597193
and the suggested commit here:
https://github.com/github/github-services/pull/1014
apologies if this is duplicated...

I believe https://github.com/github/github-services/pull/1014 fixed this!


Deployment flag not working as intended

The flag added in v7.1.0 (useDeployment) does not seem to work as intended. I get the following error when using it.
ERROR Deployment.apps "<app-name>" is invalid: spec.template.metadata.labels: Invalid value: map[string]string{"app":"thinktank", "chart":"ibm-cem", "component":"thinktank", "deploymentconfig":"<app-name>", "heritage":"Tiller", "origin":"helm-cem", "project":"<app-name>", "provider":"nodeshift", "release":"rachit", "version":"1.0.0"}: `selector` does not match template `labels`
ERROR Status code 422

How are you using it?   Are you using a already defined deployment yaml?  if so,  would you be able to share some of it?

I am using it through the useDeployment flag. I do have an already-defined deployment yml. What fields are you looking for?

that error is saying that there is something wrong(an invalid value) with the labels in "spec.template.metadata.labels"
It looks like the app name is called "" which could be an issue.
This error is actually happening on Openshift when trying to apply the deployment

Here's what I have in spec.template.metadata.
      labels:
        app: ibm-cem
        chart: ibm-cem
        component: thinktank
        heritage: Tiller
        origin: helm-cem
        release: rachit

Pushing the changes in manually does not really produce an error.

So nodeshift will add some labels by default, like provider, where the value is nodeshift, and also "project" where the value is the name of the application from the package.json.   What is that value for your project?

It's just thinktank.

In the error string from above i see this in there "project":"<app-name>",     that is one of the lables that nodeshift will add, but the value is taken from the name field of the package.json or it can be overriden with a cli flag(i think),  there is nothing in nodeshifts code that will output that "" value

It has thinktank in there.

in your project directory,  there should be a tmp/nodeshift/resource directory with an openshift.yaml and openshift.json file,  could you post either one of those,  or if there is sensitive info there,  you could also just send it to me directly

Hi I can deploy with "useDeployment" flag with no issues. :+1:
https://github.com/helio-frota/nodeshift-playground/tree/master/use-deployment-flag
https://github.com/helio-frota/nodeshift-playground/blob/master/use-deployment-flag/package.json#L7
Not sure if I'm missing something.

I think we can close this.  I talked offline about this, it looks like there might have been some configuration issues.  We can reopen if needed


Update htmlunit to 2.50.0

Updates net.sourceforge.htmlunit:htmlunit from 2.46.0 to 2.50.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "net.sourceforge.htmlunit", artifactId = "htmlunit" } ]

labels: library-update, semver-minor

Superseded by #148.


Add french localization

Hi,
I did this small PR to add french localization to your plugin.
And thanks for your work.
Best regards

Thanks. This has been released as part of version 1.1.1


feat(pagination): items per page when pages unknown, pageInputDisabled prop, i18n

enable "items per page" when pagesUnknown is true
add new prop pageInputDisabled
externalize some i18n strings
fix some console exceptions

Thanks @asudoh - right.  Reverted the version.

:+1: could you port these changes to v3 as well?


Adding TPC-H (SF1) Tests on MapR-DB JSON dataset

To enable these tests, use the category "functional_maprdb".
For ex: bin/run_tests -s Advanced/tpch -g functional_maprdb -t 300 -n 20 -d
You can also exclude these tests using the dependency "maprdb"
For ex: bin/run_tests -s Advanced -g functional_maprdb -t 300 -n 20 -d -x maprdb
These tests exercise the mapr format plugin within the mfs storage plugin. They can only be run on a MapR cluster (v5.1 and above).

Hey Krystal, Can you please review? Will share test results offline.

LGTM +1

Thanks Krystal!


NMDC schema ecosystem/consumers diagram

Add a mermaid diagram to the readme

I think we should remove this because better content is available from other contributors now.

I could add my circularized, colorized version of @sujaypatil96 bipartite material/process graph. Or @sujaypatil96 and I could work on it some more.
@eecavanna do you want to suggest adding and diagrams to the nmdc-schema README.md?

see also

#440
#420

We can also generate ER diagrams at the schema level. Perhaps I could generate an ER diagram for the NMDC schema, and show folks what it would look like.


Need details around tenant level permissions

Kindly provide more details around the following delegated permissions, available on Azure portal Power BI API:

Read and write all content in tenant
View all content in tenant

Dear @rhlgupta1383 ,
Can you provide a little more detail so that we can help you.  Is there one or more URLs or a specific topic?  Thank you.

I was referring the link below:
https://docs.microsoft.com/en-us/power-bi/developer/power-bi-permissions
In Azure portal, use the below navigation steps:
App Registrations->(Your app)->Settings->Required Permissions->Power BI Service (Add if not already added)
There are two permissions which requires admin consent and does not have documentation around it. The permissions are as follows:

Read and write all content in tenant
View all content in tenant

Attaching screenshot for reference.

@mihart - Kindly let me know in case any additional information is required from my end to help provide further assistance on the issue

Thanks for your explanation, @rhlgupta1383. Now we’ve forwarded your feedback to the writer, who should respond to this thread shortly. Thanks!

Thank you for your feedback! We will investigate and review if we need to change/add the information suggested.

@rhlgupta1383 We are working on updating this page.

@rhlgupta1383 This page will be updated by the end of the week.  Thank you for your feedback!
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.

@markingmyname - Thanks for the update. Wanted to report a small miss in the spelling though


Fixes #4996 and #4998

Opening this to start a discussion about the fix for #4998 in particular.
What this is currently doing will clearly give the right answer if the non-kekulized bonds are not involved in distinguishing between ligands. If the bonds do need to be involved in setting chirality, it's not at all clear what the right answer should be.
We could pick bond order 1 (here) or bond order 0 (used for dative bonds).
It's worth discussing this.

I know there is a solution that you dislike, but for fragments it is sometimes useful to have the bond type and bond order separately defined, otherwise I can't see any real solution to this besides the assumptions you are making.

I think this makes sense: I don't think there is a canonical answer for what priorities for dummy atoms or aromatic bonds should be, so making a decision and choosing this as a reference system makes sense to me, as long as we are consistent with it (and even better if the choice we make is also consistent with other tools).
In other words, given that there is no canonical answer to this, I'm satisfied as long as we don't get errors/exceptions in these cases and the answers we give for each case can be tracked back to one consistent reference.

and even better if the choice we make is also consistent with other tools

Regarding this comment, I have tried this patch, and  the SMILES from #4996 in Marvin JS demo, and it seems we get opposite answers:
In [1]: from rdkit import Chem
   ...: m3 = Chem.MolFromSmiles('C1CC[C@](*)2CCCC[C@H]2C1')
   ...: Chem.FindMolChiralCenters(m3,useLegacyImplementation=False,force=True)
Out[1]: [(3, 's'), (9, 's')]

I know there is a solution that you dislike, but for fragments it is sometimes useful to have the bond type and bond order separately defined, otherwise I can't see any real solution to this besides the assumptions you are making.

I’m actually not opposed to separating bond order and aromatic/non-aromatic (which is why the RDKit supports doing this), but that unfortunately doesn’t help if the input to the CIP algorithm is something which has aromatic bonds and can’t be kekulized

and even better if the choice we make is also consistent with other tools

Regarding this comment, I have tried this patch, and the SMILES from #4996 in Marvin JS demo, and it seems we get opposite answers:
In [1]: from rdkit import Chem
   ...: m3 = Chem.MolFromSmiles('C1CC[C@](*)2CCCC[C@H]2C1')
   ...: Chem.FindMolChiralCenters(m3,useLegacyImplementation=False,force=True)
Out[1]: [(3, 's'), (9, 's')]

With the small amount of playing that I did in Marvin Sketch it looked like it treats the dummy as high priority. I tried replacing the dummy with an H (because it’s clear what the priority for that should be) and then assumed that the CIP label shouldn’t change if H is replaced with a dummy (which is atomic number 0 in my mind).
@ricrogz does that make sense to you?

@ricrogz does that make sense to you?

Yes, that's what I think it's going on. My thought was whether it makes sense to try to reduce the "this other tool gives me the opposite answer" factor.

@greglandrum A means anything but hydrogen?  While I expect a * "dummy" atom is more like R which is any atom including hydrogen.

@greglandrum A means anything but hydrogen? While I expect a * "dummy" atom is more like R which is any atom including hydrogen.

@bp-kelley : that rendering is what marvin does when you put a "*" in a SMILES. The PR is for anything with atomic number zero.

I was just commenting on what Marvin may be doing with the CIP rules to be consistent with the drawn A.

Here is chemdraw with C,H,R and A

FWIW: BioVia Draw doesn't do CIP calculations for molecules with dummy atoms, so we can't compare that one.
So it looks like Marvin and ChemDraw are making dummy atoms really high priority. That doesn't really make sense to me, but since there's no right answer to this, I'm fine to go with that if the consensus is that it's better than having them be low priority.

I think it probably right for "R" and wrong for single atom substitutions so they are hedging their bets.

I think it probably right for "R" and wrong for single atom substitutions so they are hedging their bets.

Yeah, but we can't forget that they have a bunch of context in the sketcher (in the form of "R" or "A" or whatever labels) but our CIP calculation code is just getting an atom with atomic number zero, so we need a simple scheme.

Right, I would pick the high priority as if something big was hanging off there.

I think I'd also go with the higher priority, even if only to have some consensus with Marvin and ChemDraw. But I've realized that we are already bound to whatever assignStereochemistry() does (it wouldn't make sense to have contradicting priorities/labels between assignStereochemistry() and assignCIPLabels():
In [12]: from rdkit import Chem
   ...: m = Chem.MolFromSmiles('*[C@](F)(Cl)Br')
   ...: Chem.FindMolChiralCenters(m,useLegacyImplementation=True,force=True)
Out[12]: [(1, 'S')]

Which in Marvin JS looks like:

So it looks like we should stay with lower priority for dummy atoms.

@ricrogz : maintaining backwards consistency in this situation where there's not an actual right answer is a good argument


docs: update docker instructions

Description
As the title.
Issue linked
Close #3579
Checklist

[x] I have visited and read Develop PyMAPDL.
[x] I have tested my changes locally
[x] I have added necessary documentation or updated existing documentation.
[x] I have followed the PyMAPDL coding style guidelines.
[x] I have added appropriate unit tests that also ensure the minimal coverage criteria.
[x] I have reviewed my changes before submitting this pull request.
[x] I have linked the issue or issues that are solved to the PR if any.
[x] I have assigned this PR to myself.
[x] I have marked this PR as draft if it is not ready to be reviewed yet.
[x] I have made sure that the title of my PR follows Commit naming conventions (e.g. feat: adding new MAPDL command)

Please @moe-ad can you have a look and see if this PR mitigates your issues?

@pyansys-ci-bot LGTM.

Because @moe-ad is going to test again with WSL and the new docs, let's merge this and we can always edit accordingly.


Allow to specify oauth2RedirectUrl for SwaggerUIBundle

Easy change, allows to make actual use of oauth2 via flasgger :D

Any thoughts on this @billyrrr ? This would come in handy


Add expectation value of a pauli string as a function

Can we add a function that returns a single value when computing the expectation value of some observable Z1Z2? Right now it returns [ , ] as an array.
Can we also add a function that returns the expectation value by measuring the output state only once? For this, we can just utilize measure(q_device, n_shots = 1) and post-process the outcome? This feature is available in very common in libraries like penny lane, and we should adopt this for our users.
def exp_val(q_device, n_shots = 1):

Hi Dikshant,
Thank you for the enhancement suggestion. It's a great idea and very necessary to support the feature. I will add it.

Hi Hanrui, could you please refer to the other issue that I opened that has more details?


Does demos.scatter-eos.com still work?

Does demos.scatter-eos.com still work? Tells me 'requires EOS Account' although I have imported a working one.
Using in dev mode, chrome, mac os high sierra.
npm install, copied the .env, npm start. Imported the privkey of my working account. Should work, right?

It does not in fact. It was only for testing for the 6 months before the mainnet launched since there was no consistent public endpoint during that period.


Failed to run first cell of notebook: scipy was not installed by default

I had to manually pip install scipy after running through the local setup in order for the first cell in the test notebook to execute.
I thought that it should have automatically installed with scikit-learn, but it did not seem to, for some reason.

Scikit-learn doesn't install Scipy, check here: http://scikit-learn.org/stable/install.html
Anyway, the local setup now includes running pip install -r requirements.txt which installs scipy correctly.


Cannot do import of b64DecodeUnicode and WebHttpUrlEncodingCodec

What am I doing wrong?
import { b64DecodeUnicode } from 'angular-oauth2-oidc/base64-helper';
import { WebHttpUrlEncodingCodec } from 'angular-oauth2-oidc/encoder';

Result:
Module not found: Error: Can't resolve 'angular-oauth2-oidc/base64-helper'
Module not found: Error: Can't resolve 'angular-oauth2-oidc/encoder'

Tried using import * as ... - result is the same.

Don't think they're part of the public api of this module so don't think you could use 'm like that. (If you would, you'd import them straight from angular-oauth2-oidc.)

Probably you are right. The reason I tried to use them is angular-oauth2-oidc package in used by the 3rd party framework that is used in our project. And now we need custom grant type support. And I only can see pull requests from Patrick Westerhoff covering this functionality: https://github.com/manfredsteyer/angular-oauth2-oidc/pull/344

Cheers, thx for getting back to us.
And yeah, you can clone and even run a changed version yourself, the code's available under the MIT license. 👍


error on npm start

I'm submitting a ...
[X] bug report
[ ] feature request
[ ] question about the decisions made in the repository

Do you want to request a feature or report a bug?
Bug on NPM START

What is the current behavior?
Always stuck on 46% building modules 307/314 modules 7 active ...in/node_modules/ngx-uploader/index.js

What is the expected behavior?

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Angular version: 2.4.4
Browser: Chrome
Debian 8.6
Nodejs > 6.9.5
Npm > 4.1.2

Always stuck on 46% building modules 307/314 modules 7 active ...in/node_modules/ngx-uploader/index.js,
see image attach

i have same problem

i have also same problem for latest git code.

if you need to work you can workaround.... opne app/theme/initial.scss and comment all 3 lines here then write npm start in console now it works and when is everything ready uncomment all 3 lines and save... you have working server ... I know it is bad solution but if you really need to work maybe it will help someone until they fix code

@jezamba thanks for bug report. This was fixed in https://github.com/akveo/ng2-admin/commit/08de1f65c9be410fd59fd20c1d4162b0f1d79087.


[Table] Group Column Headers

What package is this for?

[X] React
[ ] Angular

Summary
Support table header grouping labels
Design spec:
https://pages.github.ibm.com/ai-applications/design/components/datatable/groupedcolumns

Need to ensure that text ellipsis occurs on strings that do not fit, and provide either a Carbon or browser tooltip to display the full label
We will need to disable column resize and column pickers when grouping is enabled

Relates to https://jsw.ibm.com/browse/GRAPHITE-40207

Examples of use:
https://ibm.invisionapp.com/share/C9O1DLYABNS#/screens/320092867
https://ibm.invisionapp.com/d/main#/console/15378790/320044391/preview

@JordanWSmith15 I can't access
https://ibm.invisionapp.com/d/main#/console/15378790/320044391/preview
and
https://jsw.ibm.com/browse/GRAPHITE-40207

I've seen grouped column headers be used in data tables, but I don't know if I've seen it within column customization capabilities (the table might be defined for the user as-is).
We might need to lean on the teams using the grouped column headers to understand what use cases they have, and what columns would need to be reordered if that's needed. I can't imagine use cases of moving child columns outside of their parent columns for example, because the parent column provides the context of the child column, but that's an assumption.
At most, I can imagine reordering full groups (parent column with all children below it) or maybe reordering the child columns inside of the parent, but not mixing and matching columns.

@bjornalm updated link to https://ibm.invisionapp.com/share/C9O1DLYABNS, and added you to graphite project


Please describe what needs to be done to add another model / controller

This is  an interesting project! It would be very interesting to read about what needs to be done to add another model / controller, just to understand what is needed on top of the typical yii workflow. It would be great if you cound write down just a few sentences - or make a series of very clean commits so everybody can understand how to add more entities. Thank you very much!

I just added some information here 985f1a05433b36ee02b47d27d11b2076b24917a3.
Since this is a demo project which is a clone of another demo project you should follow the instructions here:
The official Inertia website:

https://inertiajs.com

The official Vue.js adapter:

https://github.com/inertiajs/inertia-vue

The Yii2 Inertia adapter:

https://github.com/tbreuss/yii2-inertia


[Backport] Support priorityClassName in the chart

https://github.com/rancher/backup-restore-operator/issues/114

Can be tested in chart rancher-backup 1.2.0-rc2

On 2.5-head commit id: defd81cd

Rancher backup charts version: v1.2.0-rc3

affinity: {}
global:
  cattle:
    systemDefaultRegistry: ''
  kubectl:
    repository: rancher/kubectl
    tag: v1.20.2
image:
  repository: rancher/backup-restore-operator
  tag: v1.2.0-rc3
nodeSelector: {}
persistence:
  enabled: false
  size: 2Gi
  storageClass: '-'
  volumeName: ''
priorityClassName: ''

While deploying rancher backups give the priorityClassName: high-priority.
Backup restore pod Fails to deploy with error: Pods "rancher-backup-64f8866b44-" is forbidden: no PriorityClass with name high-priority was found
Created a priority class using this doc
The pod come sup Active.