bug: the definition of timeout of passive unhealthy, ApisixUpsteam CRD resources and API definitions are inconsistent

Issue description
Two questions.
The first question is bug,  CRD resources and API object are different from timeount unit definitions.
In CRD resources, passive healthy check timeout is set to string. In api, passive healthy check timeout is set to time.Duration. However In CRD resources, active healthy check timeout is set to number and in api is set to time.Duration.
This leads to unable to declare  unhealthy timeout.
https://github.com/apache/apisix-ingress-controller/blob/2d12c3fdd1369e9e263342d0def6473de5c0664f/samples/deploy/crd/v1beta1/ApisixUpstream.yaml#L341-L342
https://github.com/apache/apisix-ingress-controller/blob/2d12c3fdd1369e9e263342d0def6473de5c0664f/pkg/kube/apisix/apis/config/v1/types.go#L218-L222
The second question is suggestion.After testing, the timeout unit of the active health check is nanosecond instead of the second or milliseconds used frequently.This is still a little inconvenient for normal use.
Few people think that the unit is nanosecond, or you can mark it in the document.
If I want to define timeout for 5s, I need to do this.It is so big：

apiVersion: apisix.apache.org/v1
kind: ApisixUpstream
metadata:
  name: httpbin
spec:
  healthCheck:
    active:
      type: http
      httpPath: /status/200
      timeout:<PHONE_NUMBER>
      healthy:
        httpCodes: [200]
        interval: 1s
      unhealthy:
        httpFailures: 20
        interval: 1s

Environment
apisix-ingress-controller version:
Version: 0.6.0
Git SHA: no-git-module
Go Version: go1.13.8
Building OS/Arch: linux/amd64
Running OS/Arch: linux/amd64
Kubernetes cluster version:
Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.4", GitCommit:"d360454c9bcd1634cf4cc52d1867af5491dc9c5f", GitTreeState:"clean", BuildDate:"2020-11-12T01:09:16Z", GoVersion:"go1.15.4", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"20", GitVersion:"v1.20.2", GitCommit:"faecb196815e248d3ecfb03c680a4507229c2a56", GitTreeState:"clean", BuildDate:"2021-01-13T13:20:00Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
Minimal test code / Steps to reproduce the issue
About the first question：

If I am defined as int, it will report an error

apiVersion: apisix.apache.org/v1
kind: ApisixUpstream
metadata:
  name: httpbin
spec:
  healthCheck:
    active:
      type: http
      httpPath: /status/200
      timeout:<PHONE_NUMBER>
      healthy:
        httpCodes: [200]
        interval: 1s
      unhealthy:
        httpFailures: 20
        interval: 1s
    passive:
      type: http
      healthy:
        httpCodes: [200]
        successes: 20
      unhealthy:
        httpCodes: [502]
        httpFailures: 20
        tcpFailures: 20
        timeout: 5

the error logs :
The ApisixUpstream "httpbin" is invalid: spec.healthCheck.passive.unhealthy.timeout: Invalid value: "integer": spec.healthCheck.passive.unhealthy.timeout in body must be of type string: "integer"
2.If I am defined as string, it can't take effect

apiVersion: apisix.apache.org/v1
kind: ApisixUpstream
metadata:
  name: httpbin
spec:
  healthCheck:
    active:
      type: http
      httpPath: /status/200
      timeout:<PHONE_NUMBER>
      healthy:
        httpCodes: [200]
        interval: 1s
      unhealthy:
        httpFailures: 20
        interval: 1s
    passive:
      type: http
      healthy:
        httpCodes: [200]
        successes: 20
      unhealthy:
        httpCodes: [502]
        httpFailures: 20
        tcpFailures: 20
        timeout: '15'

What's the actual result? (including assertion message & call stack if applicable)
What's the expected result?
Unified time unit definition, and inform the default unit

In CRD resources, passive healthy check timeout is set to string. In api, passive healthy check timeout is set to time.Duration. However In CRD resources, active healthy check timeout is set to number and in api is set to time.Duration.
This leads to unable to declare unhealthy timeout.

PR's welcome to fix this.

@arabot777 For the second one, we may create an our own time duration format which implements the json.Unmarshaler interface, so that we can pass some string values like 5s, 10h to it.
See pkg/types/timeduration.go for details.

we can add check to admission.

i will submit pr. What do I need to pay attention to

i will submit pr. What do I need to pay attention to

Do you mean the admission server? We have another friend who is devoting to this. Maybe you can wait for a while and see whether the PR can solve your problems.

Understood. We hope the problem can be solved quickly and want to support plugins client-control

It should be timeouts in passive.unhealthy, not timeout, which means the number of timeouts in proxied traffic to consider a target unhealthy.
The logic is wrong in https://github.com/apache/apisix-ingress-controller/blob/master/pkg/kube/translation/apisix_upstream.go#L298
And we should modify the ApisixUpstream CRD.

#687 has been merged. Should we close this one? @gxthrj

Yes, close this issue, feel free to reopen.


Provide a way of using Response header functions from HttpStatus and HttpError

Response has a series of utility methods for setting complex headers, like Set-Cookie or Link.
It would be nice to have a similar ability also in the HttpStatus and in the HttpError.
While ideally the interface could be duplicated/shared in a common superclass, I think that most of the benefits could be achieved by making the _wsgi_headers and _asgi_headers public and setting the headers of the HttpStatus/HttpError to that value.
https://github.com/falconry/falcon/blob/113eea113844058816ed745d8dc9cb197e75cb95/falcon/response.py#L1049
https://github.com/falconry/falcon/blob/113eea113844058816ed745d8dc9cb197e75cb95/falcon/asgi/response.py#L390

Should this issue be labeled as Good First Issue?
We are doing research about how to help newcomers onboarding in an open source project and how to accelerate the issue resolving process.
We have developed a tool to automatically label the Good First Issue (GFI), i.e., the issue which is good for newcomers.
We first extract 72 features from different dimensions of issue reports, such as readability, semantic meaning, associated code snippets, etc, and experimentally investigate to what extent these features correlate with GFI. Results turn out that a large portion of these features do have a medium to large correlation with GFI.
We then build a machine learning model based on these features to predict GFI. The experiments on a dataset of 12k issues from Github show that 0.90 AUC can be achieved.
Our tool shows that this issue has a very large possibility to be a GFI.
Could you please tell us whether it should be labeled as a GFI?
And if you have any comments or suggestions with this tool, could you please tell us?
Thank you so much.

Hi @G-Sheridan !
And thanks for sharing. Sounds like a cool AI/DL project to tinker with!
That being said, I'm afraid this issue falls into the remaining gap towards 1.00 AUC, and towards artificial general intelligence.
Despite a really well written description by @CaselIT, it feels like an open ended issue requiring a principal architectural decision on how we want to organize the core parts of the framework.
Maybe when these decisions are made and documented, it could be a relatively easy issue, but I still think we could find more fitting stuff to onboard newcomers. We actually do happen to have 12 issues labeled as such :slightly_smiling_face:


Sometimes fail to recover from the context lost (go-inovation)

Run go-inovation built by gomobile bind
Run go-inovation built by gomobile build
Switch them several times

This happened on NuAns Neo Reloaded.
It's flaky and probably more other (memory-consuming) applications make it easier to reproduce?

git-bisect says b474946619a0a39c227d07664603458db0ffd9de is the cause...

I think extending is not the root cause, extending make it more often though.
Changing the max shared texture size to 4096 causes this issue.
--- a/internal/shareable/shareable.go
+++ b/internal/shareable/shareable.go
@@ -179,7 +179,7 @@ func (s *Image) IsInvalidated() (bool, error) {
 }

 func NewImage(width, height int) *Image {
-       const maxSize = 2048
+       const maxSize = 4096

        backendsM.Lock()
        defer backendsM.Unlock()

It looks like 4096-size textures are problematic on Android. I found that glReadPixels doesn't return a correct result with 4096-size textures.
Also I found https://forum.unity.com/threads/black-textures-on-some-devices-android-versions.195328/#post-1389830

We are also experiencing this problem. We've had it before, but found out there were still some texture atlases set at 4096, we set those to 2048 and that solved the problem.

Hmm, this happened even with non-4096 pixel textures?

Now I guess this is a concurrent issue: restorable.Image is not protected while they can be called from multiple goroutines. Actually, go-inovation creates NewImage on a goroutine.
I did a lot of printf-debugging and from the observation, the things happening are:

An shared texture is updated and made stale
Resolve the stale state at the end of the frame
A new another image is created. This uses the shared texture, but the shared texture says it's stale, although the stale was resolved at 2. Then, the newly-created image has gone from (*restorable.Image).basePixels.
Yet another image is created with the same shared texture. In this time, the shared texture is not stale and updated correctly.

Fixed!


Add testing to react/dashboard

Codecov Report

Merging #44 into master will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   96.51%   96.73%   +0.22%
==========================================
  Files          18       19       +1
  Lines         430      460      +30
  Branches       18       18
==========================================
+ Hits          415      445      +30
  Misses         15       15

Impacted Files
Coverage Δ

src/test/resources/json-samples/system.js
100.00% <100.00%> (ø)

src/main/scala/stats/StatsCollector.scala
100.00% <0.00%> (ø)

src/main/scala/checker/CommandRunner.scala
100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 641818c...5c803c5. Read the comment docs.


Dev - provisioningInfo is set to null

Within the current dev branch I'm getting problems when provisioningInfo is set to null in SiteToTemplateConversion. Should the if block go around the objectHandler.Add section?
if (provisioningInfo != null)
121                 {
122                   .....
136                 }
137
....
140                 if (provisioningInfo.HandlersToProcess.HasFlag(Handlers.RegionalSettings)) objectHandlers.Add(new ObjectRegionalSettings());
141                 if (provisioningInfo.HandlersToProcess.HasFlag(Handlers.SupportedUILanguages)) objectHandlers.Add(new ObjectSupportedUILanguages());
142

Hi Pieter,
Thanks for your contribution! This has been fixed in February release. I will close the issue.


Swap command line arguments to follow FUSE standard

As mentioned in #12
The order of the command line interface arguments should be swapped to follow the FUSE standard way.

The errors from the integration tests are a bit hard to understand. But I am guessing that this breaking change (without changing tests),  breaks the tests. :sunglasses:

Seems the error is in the build configuration, as it tries to use docker. Docker does not exist in the path on the server, maybe not even installed.


Hid a column and can't show it anymore

Hi,
I hid one of the column in the board view and I can't get it to be shown anymore, isn't there a missing button or something like that?
Version 1.0.24 with php7 and firefox 44…

I tried with Chromium, and I get it: there is a button to show it, but it doesn't appear in firefox...

Just click on the column title.

Of course I tried clicking everywhere, but there is clearly something wrong with the UI in FF, I will make a screenshot on Monday. Also it is generally much slower in FF than in Chromium...

Well, no, I'm crazy, sorry :)


cargo vendor without dev-dependencies?

Is there a way to create a vendored sources without dev-dependencies?

It looks like cargo vendor correctly ignores dev-dependencies for a crate's first-level dependencies, but any sub-dependencies get their dev ones pulled in.
An example using the chrono crate, which pulls in time, which has dev-dependencies winapi, winapi-i686-pc-windows-gnu, and winapi-x86_64-pc-windows-gnu:
$ cargo vendor
   Vendoring autocfg v1.0.0 (/home/proxmox/.cargo/registry/src/github.com-1ecc6299db9ec823/autocfg-1.0.0) to vendor/autocfg
   Vendoring chrono v0.4.10 (/home/proxmox/.cargo/registry/src/github.com-1ecc6299db9ec823/chrono-0.4.10) to vendor/chrono
   Vendoring libc v0.2.67 (/home/proxmox/.cargo/registry/src/github.com-1ecc6299db9ec823/libc-0.2.67) to vendor/libc
   Vendoring num-integer v0.1.42 (/home/proxmox/.cargo/registry/src/github.com-1ecc6299db9ec823/num-integer-0.1.42) to vendor/num-integer
   Vendoring num-traits v0.2.11 (/home/proxmox/.cargo/registry/src/github.com-1ecc6299db9ec823/num-traits-0.2.11) to vendor/num-traits
   Vendoring redox_syscall v0.1.56 (/home/proxmox/.cargo/registry/src/github.com-1ecc6299db9ec823/redox_syscall-0.1.56) to vendor/redox_syscall
   Vendoring time v0.1.42 (/home/proxmox/.cargo/registry/src/github.com-1ecc6299db9ec823/time-0.1.42) to vendor/time
   Vendoring winapi v0.3.8 (/home/proxmox/.cargo/registry/src/github.com-1ecc6299db9ec823/winapi-0.3.8) to vendor/winapi
   Vendoring winapi-i686-pc-windows-gnu v0.4.0 (/home/proxmox/.cargo/registry/src/github.com-1ecc6299db9ec823/winapi-i686-pc-windows-gnu-0.4.0) to vendor/winapi-i686-pc-windows-gnu
   Vendoring winapi-x86_64-pc-windows-gnu v0.4.0 (/home/proxmox/.cargo/registry/src/github.com-1ecc6299db9ec823/winapi-x86_64-pc-windows-gnu-0.4.0) to vendor/winapi-x86_64-pc-windows-gnu
To use vendored sources, add this to your .cargo/config for this project:

[source.crates-io]
replace-with = "vendored-sources"

[source.vendored-sources]
directory = "vendor"

However, if we perform a cargo check without vendor set, then those winapi crates are not pulled in:
$ cargo check
    Updating crates.io index
   Compiling autocfg v1.0.0
   Compiling libc v0.2.67
   Compiling test-things v0.1.0 (/home/proxmox/Projects/test-things)
   Compiling num-traits v0.2.11
   Compiling num-integer v0.1.42
    Checking time v0.1.42
    Checking chrono v0.4.10

    Finished dev [unoptimized + debuginfo] target(s) in 5.16s
$ ls target/debug/deps/
autocfg-fa69ae4854af9d10.d        libautocfg-fa69ae4854af9d10.rmeta  liblibc-641bd962ed50a1c5.rmeta         libtest_things-c8241d727281be73.rmeta  num_integer-e2da41134dcd3031.d  test_things-f348b1360dc4a36a.d
chrono-04891ab65662f7bc.d         libc-641bd962ed50a1c5.d            libnum_integer-e2da41134dcd3031.rmeta  libtest_things-f348b1360dc4a36a.rmeta  num_traits-771bd41382020f10.d   time-97f7d8ef4071ccac.d
libautocfg-fa69ae4854af9d10.rlib  libchrono-04891ab65662f7bc.rmeta   libnum_traits-771bd41382020f10.rmeta   libtime-97f7d8ef4071ccac.rmeta         test_things-c8241d727281be73.d

It sounds great to save bandwidth by not vendoring any dev-dependencies. However, it will be frustrating when someone tries to run cargo test and fails, since the de facto way to use vendor sources is to replace the whole crates.io source.

It looks like cargo vendor correctly ignores dev-dependencies for a crate's first-level dependencies, but any sub-dependencies get their dev ones pulled in.

I believe this is not true. IIRC, Cargo would vendor

all direct dependencies listed in Cargo.toml, including build and dev dependencies, and
transitive dependencies that are required to build themselves (e.g. normal and build dependencies).

As a result, dev-dependencies of your dependencies would not be downloaded. The only downloaded dev-dependencies are what you list in Cargo.toml of your package.

I can confirm dev dependencies get vendored
cargo init
cargo add --dev rand
cargo vendor
ls vendor

This is also affecting dependency vendoring on Fuchsia via rules_rust.

To cover different use cases we can add a generic approach similar to the cargo tree option edges.
We can call this new option --dep-kinds (As proposed for cargo metadata in https://github.com/rust-lang/cargo/issues/10718) using the same proposed values:

all (default for backwards compatibility)
normal
build
dev
no-normal
no-build
no-dev

For those seeking a solution to this problem until the issue is resolved, consider using cargo-vendor-filterer.
You can exclude development crates by utilizing the --keep-dep-kinds=no-dev flag.
Please be aware that this solution is not perfect, as it initially vendors all folders and subsequently removes the development crates' code. An optimal solution will be implemented upon the completion of this feature. 😉


button to import holidays from one channel to another

Done in channel creation, not that necessary in edition, so closing this.


Automated release process fails to upload some artifacts

There's only setuptools-21.2.0-py2.py3-none-any.whl on https://pypi.python.org/pypi/setuptools but no setuptools-21.2.0.tar.gz. The latter is necessary for building the unofficial package pypy-setuptools for Arch Linux. Could you upload it?

The tarballs are meant to be uploaded by the Python 3.5 build. As you can see in that log, the deploy condition was run, but it failed to upload with an internal server error.
I've seen this message before. The Internal Server Errors are intermittent, and when they occur, the file is still uploaded. However, as you've noticed, only the wheel got uploaded and the error caused the process to fail to upload the other dists (tar and zip). I suspect this issue is also causing problems with the bootstrap script which will attempt to get the zip archive.

The failure is probably due to PyPI 262.

How about re-uploading files on receiving HTTP 500? Given it's a rare case.

I've re-uploaded by the sdists by checking out the v21.2.0 code and running setup.py clean_egg_info sdist upload to work around this specific incident.

How about re-uploading files on receiving HTTP 500? Given it's a rare case.

As I'm using Travis CI integration, I'm largely dependent on their implementation. There's no hook to retry. Also, retry is awkward, as the request that errors actually succeeds and it's only the subsequent requests that fail.
I'm not sure it's a rare case either. In my experience, it happens at least 1% of the time, and probably more like 10% of the time.

probably more like 10% of the time.

Sounds bad. Seems the only way is waiting for PyPI 262. Anyway thanks for manaul uploading.

Can you please deactive the partial release on pypi.and set the latest working version as active and enable again if the zip an rar get released? I'm sure this missing files will get many People into trouble tomorow.

Can you please deactive the partial release on pypi.and set the latest working version as active and enable again if the zip an rar get released?

The files were previously uploaded.

Sorry I didn't see that. My bad,I was reading the other issue and answered to late. Many thanks!

That didn't fix it - Travis uses Twine to upload, which doesn't honor setup.cfg for the upload repository.

The old pypi.python.org still shows 22.0.2: https://pypi.python.org/pypi/setuptools. Seems it's not synchronized with pypi.io?

https://pypi.python.org/pypi/setuptools/json indicates the latest version is 22.0.4, so pip users are not affected :)
And now I can download the package directly from https://pypi.io/packages/source/s/setuptools/setuptools-22.0.4.tar.gz. Many thanks!


TISAX Compliance for Dotcom and GHEC

Summary
With ISO 27001 as a foundation, GitHub is able to register as a participant in the Trusted Information Security Assessment Exchange (TISAX).
Intended Outcome
GitHub will achieve TISAX Assessment Level 2 for the assessment objectives and resulting TISAX labels of "Handling of information with high protection needs" and "Data protection". The outcome of this work is that GitHub Enterprise Cloud customers will be able to use GitHub to develop software while meeting TISAX compliance obligations.
How will it work?
GitHub GRC has already begun the registration process by registering as a TISAX Participant and we have defined an assessment scope. Next up, GRC is working with to identify a TISAX audit provider and will then undergo a TISAX assessment. The results of GitHub's assessment will then be made available to TISAX partners. Once certified, GitHub will add TISAX to customer facing documentation portals.

🚢 This has shipped: https://github.blog/changelog/2024-10-01-announcing-tisax-for-github/


Recipe Compile Error - undefined local variable or method `use_inline_resources' (/resources/s3_file.rb:22)

I tried to run this cookbook's server profile via kitchen on openstack, and was met with the following response:
       Recipe Compile Error in /tmp/kitchen/cache/cookbooks/dynatrace-appmon/resources/s3_file.rb
       ================================================================================

       NameError
       ---------
       undefined local variable or method `use_inline_resources' for #<Class:0x0000000004d011b0>

       Cookbook Trace:
       ---------------
         /tmp/kitchen/cache/cookbooks/dynatrace-appmon/resources/s3_file.rb:22:in `class_from_file'

       Relevant File Content:
       ----------------------
       /tmp/kitchen/cache/cookbooks/dynatrace-appmon/resources/s3_file.rb:

        15:  property :region, String
        16:  property :access_key_id, String
        17:  property :secret_access_key, String
        18:  property :owner, String
        19:  property :group, String
        20:  property :mode, String
        21:
        22>> use_inline_resources
        23:
        24:  action :create do
        25:    require 'aws-sdk'
        26:
        27:    # Detecting if we want to upload or download from S3
        28:    upload_to_s3 = false
        29:    if source.start_with?('s3://')
        30:      s3_url = source.dup
        31:    elsif target.start_with?('s3://')

       System Info:
       ------------
       chef_version=12.22.5
       platform=redhat
       platform_version=7.5
       ruby=ruby 2.3.6p384 (2017-12-14 revision 61254) [x86_64-linux]
       program_name=chef-client worker: ppid=2141;start=22:02:05;
       executable=/opt/chef/bin/chef-client

I tried with Chef client 12, 13, and 14.  13 and 14 gave other errors that I was able to work around.  the resource names cannot be set to type string with a default of nil.  A type mismatch error is returned, as the default type must match the defined type for the property.
Also, the kitchen files that you provide reference recipe[dynatrace::server] but the cookbook name (in the metadata.rb) is dynatrace-appmon, so the runlist in the .kitchen.yml does not seem to be valid.

@PiotrMejer @metmajer  - It looks like the two of you were active contributors on this cookbook.  Can you advise if I am doing something wrong?

This issue can be solved by replacing the line use_inline_resources with
use_inline_resources if defined?(use_inline_resources)

Let me know if you can get the recipe to run, as I'm struggling to do so myself right now


Release DDQ 5.0.0

[x] adjust README.md
[x] adjust documentation in wiki
[x] remove SNAPSHOT from version
[x] tag
[x] build Python package (sudo python setup.py install)
[x] build Scala package (sbt package)
[x] create GitHub release (attach Scala package)
[x] create Spark Packages release (sbt spDist)
[x] upload new ScalaDoc to release (sbt doc)
[x] upload python package (python setup.py sdist upload -r pypitest, python setup.py sdist upload -r pypi)
[x] bump version

Any update on when this new build will be released?

Hi! I am not actively working on the project at the moment so there are no plans to release a new version at the moment. Is there any specific feature you are looking forward to?

@FRosner the only thing that's a blocker to me using this is #152, however, it looks like that's been fixed in master but not in 4.1.1.

I see. In this case we could release 4.1.2 with only that fix. Would that help? If so, I can do that tomorrow.

That would totally help!

Hi! I don't have time today as something else took longer than expected. I will put a reminder for Monday, though. Sorry!

I released 5.0.0 but I am having some issues with Travis. Nevertheless the package has been published. Can you check if it works for you?

I released 5.0.0 but I am having some issues with Travis. Nevertheless the package has been published. Can you check if it works for you @jordanyaker?

@FRosner sorry for the delay - I've been dealing with migration problems for the last two weeks.  I finally got back to this task and was able to check on this.
I installed 5.0.0 Python library without any issues.  I couldn't find the 5.0.0 JAR so, I installed 4.1.1.  Unfortunately, it looks like this is a problem due to the following error:
  File "/local_disk0/spark-047d81fc-c47d-4e05-a823-339d733333aa/userFiles-2d767fef-09dc-4e1a-807b-d9e62df71d41/addedFile2119423679649655466drunken_data_quality_4_1_1_s_2_11-c7bb5.jar/pyddq/core.py", line 439
    print baos.get_output()
             ^

Scratch what I said earlier.  I downloaded the 5.0.0 JAR from the Github releases for the project and uploaded it to my cluster.  It worked without issues.  Thanks!

Glad it worked! I'll see when I can find the time to fix the travis build.


code

Hi awesome work！
It has been six months now, waiting for code.

Thank you for your attention. The code for DragonDiffusion is expected to be open-sourced within one week. But if the rebuttal for CVPR2024 is busy, there may be a slight delay.

Thanks for your reply.
Looking forward to it~


Error ocurred during the rendered execution ReferenceError: React is not defined

After create the cra-universal application and install all the node modules , I ran I this two commands

npm start
npx cra-universal start

End up with this error

Error ocurred during the rendered execution ReferenceError: React is not defined

I haven't modified any of the code. All the code are boiler template for create-react-app.

It seems like new versions of CRA doesn't use the import React from 'react' by default, you have to write that line on your App.js and the problem will be solved


chore(format): :wrench: Modified scripts to support the new swift format in Xcode 16 toolchain

Description

The problem
Xcode 16 and above include swift-format in the toolchain. You can run swift-format from anywhere on the system using swift format (notice the space instead of dash). Because of this, it is not necessary to install swift-format using Homebrew or other custom alternatives. The difference is that to invoke the command you have to use swift format instead of swift-format.
With the current setup, if you try to run the scripts without a custom swift-format installation, you would get an error saying that swift-format isn't installed, which is not true if you have Xcode 16.
The solution
We want to take advantage of the new toolchain for Xcode 16 containing swift-format, so I have made the next changes:

The script now checks the Xcode version and use the right command based on that, not requiring a custom installation if devs are using Xcode 16
If you are not using Xcode 16 and the dev doesn't have swift-format installed, it will print a clear error message asking to install it or to use Xcode 16

Enhancements
The package file was invoking two different shell scripts for formatting all the files and for formatting only the changes. In the case of format-changes, it was invoking scripts/format-changes.sh. In the other case the script was declared in the package.json itself. This isn't ideal since it is using different approaches for both cases and we have to maintain two different scripts in different places.
I have unified those two scripts in a single scripts/format.sh file, so it is cleaner and we have only one script to maintain—especially now that we have to check the Xcode version in both cases.
The new format.sh script can format every file in the project, or can modify only the changes if it receives the --changes flag.
Bonus
I have fixed the file ExerciseListView.swift that wasn't well formatted.
Related Issue

Closes #51
How Has This Been Tested?

To test this I have modified the indentation of several files, add them to the git stage and then:

[x] Run the script manually only for the changes
[x] Run the script manually for the entire project
[x] Made a test commit to check that it format the files changed correctly

Additionally, I have tested with the next environments:

[x] Setting Xcode 16 using xcode-select -s -> Scripts worked correctly using swift format
[x] Setting Xcode 15.4 without a custom swift-format installation -> Showed the error asking to install or use Xcode 16
[x] Setting Xcode 15.4 using xcode-select -s -> Scripts worked correctly using swift-format

Screenshots (if appropriate):
N/A
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Developer tooling (fix or improve developer tooling)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Glad it helped! 💪


Include GetBounds command in GraphHopperApplication?

The GetBounds command is currently not included in GraphHopperApplication (and otherwise also seems to be unused). Shall we include or delete it?

Yes, let us remove it.

Yes, let us remove it.


Fix adapter lift request publisher QoS to transient local

Bug fix
Fixed bug
Since https://github.com/open-rmf/rmf_ros2/pull/310, the qos for adapter_lift_requests and lift_requests was changed to transient local, rather than volatile.
According to the ROS 2 documentation, Volatile publisher and Transient Local subscriber just doesn't work, and indeed it didn't.
Fix applied
This PR changes the publisher to use the same QoS as the subscriber (and make the build warning free)

I tried some end to end tests with my branch and they turned out to be a bit flakey, but I think it's a separate issue, will move out of draft


Stop :grpc++ from depending on protobuf

I am fine with this change in principle, but I think there are some details to work out.
It looks like this is causing some distribtest failures for both Linux and Windows.
Also, I think there are some additional distribtests that don't run on every PR, and we should verify that this passes all of them before we merge.  @jtattermusch can advise as to which tests to run.
We should also do a cherry-pick import and run TGP on this.  I have no idea what it might break, but I could imagine that it might be a lot.

I feel like some part of the history here was related to TF; can you also make sure that OSS TF can still update its gRPC pinpoint without getting broken? (This is actually a different signal than TGP.)

@yang-g  please provide PR description and also mention the motivation for doing this. This is quite a change from the build perspective, so it really deserves a detailed description.


How to use models like NPTS

I am trying to use built in NPTS estimator. But i could not figure out how to make predictions with model. Can someone please provide a skeleton example on how to train and predict.
Thank you.

NPTS can be directly used by calling its predictor:
from gluonts.model.npts import NPTSPredictor
from gluonts.dataset.common import ListDataset

predictor = NPTSPredictor(prediction_length=10, freq="D")

data = ListDataset([{"start": "2020", "target": [1, 2, 3, 4, 5, 6]}], freq="D")

predictions = list(predictor.predict(data))

Thank you.


checkDistributionFunctions fails with empty dimension for argument of user-provided distribution and no 'r' function

A bit hard to believe this hasn't come up before, but if a user provides only the user-defined 'd' function and omits the dimension for an argument (thereby defaulting to scalar), checkDistributionFunctions chokes.  I guess I didn't catch this because I tend to use double(0) instead of double().
The issue is that the function expects rargInfo[[1]][[2]] to be valid.
Browse[2]> rargInfo[[1]]
integer()
Browse[2]> rargInfo[[1]][[1]]
integer
Browse[2]> rargInfo[[1]][[2]]
Error in rargInfo[[1]][[2]] : subscript out of bounds

This duplicates #991 , which is already fixed.


Open Legend.html AND Open Legend.css AND Readme.md

Changes / Comments
1.9.8c on 2019 April 12th

Folder Rename

Changing folder name in Roll20 github from "Open Legend Basic by Great Moustache" to "Open Legend"
When I was a young pup in the game, didn't realize should have named folders better

Image Updates 2

Updated all remaining links in preperation for Folder rename

Folder Rename
As per conversation on last merge with @clevett : https://github.com/Roll20/roll20-character-sheets/pull/4912#issuecomment-481719057
renamed links to images to be referencing "Open Legend" folder instead of the presently "Open Legend Basic by Great Moustache"

I've made a note to myself as well to check over this sheet this evening after merging to ensure its working.
Thanks,
Cassie


config.json is named appsettings.json

The json file containing the app settings and connection strings is named appsettings.json (not config.json).

Hi @jwidmer, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

:shipit:

Thanks for the PR! Merged in e897b0c282fbbb0b615a5c400a649bb624f983c2


Question about plugins

Hello and congratulations for this great contribution that I was waiting for something like this for a long time, but I need if you could clarify a question about this template... In the .Net Framework there was something called managed extensibility framework (MFE). When switching to .Net Core, this didn't exist... My question is, does your template do the same function as MEF? Thank you very much for your work.

Thank you!
No, this is just a template that can be used as a starting point for your .NET MAUI plugin development. This is basically just a File > New Project from Visual Studio with some changes with how I like to setup my plugins hoping that it will help others.


Secure elastalert2-server

Hello,
I have installed elastalert2 and elastalert2-server (without docker).

As you can see I can access via url to get for example the list of rules

==> It work fin

Problem:
I want to secure this communication i want to use https://xx.xx.xx.xx:3030. How can I do it ? and How can I add certificat

Why would you like to add https if server is available without any authentication?

I don't understand your question
But in the final this is what i have

I want to secure the red connection

I don't understand your question

https is only encryption (prevent from man in middle attack).
your elastalert2-server http://xx.xx.xx.xx:3030 is available without any authentication so someone could access it directly without necessary to caputre trafic.

Rather you should make something like this:

in internal network you don't need to secure connection between praceo and elastalert2-server.


Packaging: why is half of the runtime code in -dev package?

Environment

OS Version: Ubuntu 18.04
Source or binary build? Both

Description

Expected behavior: libignition-common3 should contain everything that's needed to use e.g. ign launch.
Actual behavior: Half of the needed files are in libignition3-dev package.

Steps to reproduce
$ dpkg -L libignition-launch3
/.
/usr
/usr/lib
/usr/lib/x86_64-linux-gnu
/usr/lib/x86_64-linux-gnu/ign-launch-3
/usr/lib/x86_64-linux-gnu/ign-launch-3/plugins
/usr/lib/x86_64-linux-gnu/ign-launch-3/plugins/libignition-launch-gazebo-factory.so
/usr/lib/x86_64-linux-gnu/ign-launch-3/plugins/libignition-launch-gazebo.so
/usr/lib/x86_64-linux-gnu/ign-launch-3/plugins/libignition-launch-gazebogui.so
/usr/lib/x86_64-linux-gnu/ign-launch-3/plugins/libignition-launch-joystick.so
/usr/lib/x86_64-linux-gnu/ign-launch-3/plugins/libignition-launch-joytotwist.so
/usr/lib/x86_64-linux-gnu/ign-launch-3/plugins/libignition-launch-websocket-server.so
/usr/lib/x86_64-linux-gnu/libignition-launch3.so.3.1.1
/usr/share
/usr/share/doc
/usr/share/doc/libignition-launch3
/usr/share/doc/libignition-launch3/changelog.Debian.gz
/usr/share/doc/libignition-launch3/copyright
/usr/lib/x86_64-linux-gnu/libignition-launch3.so.3
peci1@cras-17:/media/data/subt_ws
$ dpkg -L libignition-launch3-dev
/.
/usr
/usr/include
/usr/include/ignition
/usr/include/ignition/launch3
/usr/include/ignition/launch3/ignition
/usr/include/ignition/launch3/ignition/launch
/usr/include/ignition/launch3/ignition/launch/Export.hh
/usr/include/ignition/launch3/ignition/launch/Plugin.hh
/usr/include/ignition/launch3/ignition/launch/config.hh
/usr/include/ignition/launch3/ignition/launch/detail
/usr/include/ignition/launch3/ignition/launch/detail/Export.hh
/usr/include/ignition/launch3/ignition/launch.hh
/usr/lib
/usr/lib/ruby
/usr/lib/ruby/ignition
/usr/lib/ruby/ignition/cmdlaunch3.rb
/usr/lib/x86_64-linux-gnu
/usr/lib/x86_64-linux-gnu/cmake
/usr/lib/x86_64-linux-gnu/cmake/ignition-launch3
/usr/lib/x86_64-linux-gnu/cmake/ignition-launch3/ignition-launch3-config-version.cmake
/usr/lib/x86_64-linux-gnu/cmake/ignition-launch3/ignition-launch3-config.cmake
/usr/lib/x86_64-linux-gnu/cmake/ignition-launch3/ignition-launch3-targets-relwithdebinfo.cmake
/usr/lib/x86_64-linux-gnu/cmake/ignition-launch3/ignition-launch3-targets.cmake
/usr/lib/x86_64-linux-gnu/cmake/ignition-launch3-all
/usr/lib/x86_64-linux-gnu/cmake/ignition-launch3-all/ignition-launch3-all-config-version.cmake
/usr/lib/x86_64-linux-gnu/cmake/ignition-launch3-all/ignition-launch3-all-config.cmake
/usr/lib/x86_64-linux-gnu/cmake/ignition-launch3-all/ignition-launch3-all-targets.cmake
/usr/lib/x86_64-linux-gnu/pkgconfig
/usr/lib/x86_64-linux-gnu/pkgconfig/ignition-launch3.pc
/usr/share
/usr/share/doc
/usr/share/doc/libignition-launch3-dev
/usr/share/doc/libignition-launch3-dev/changelog.Debian.gz
/usr/share/doc/libignition-launch3-dev/copyright
/usr/share/ignition
/usr/share/ignition/ignition-launch3
/usr/share/ignition/ignition-launch3/configs
/usr/share/ignition/ignition-launch3/configs/factory.ign
/usr/share/ignition/ignition-launch3/configs/gazebo.ign
/usr/share/ignition/ignition-launch3/configs/gazebo_plugins.ign
/usr/share/ignition/ignition-launch3/configs/multi_factory.ign
/usr/share/ignition/ignition-launch3/configs/plugins.ign
/usr/share/ignition/ignition-launch3/configs/websocket.ign
/usr/share/ignition/ignition-launch3/ignition-launch3.tag.xml
/usr/share/ignition/launch3.yaml
/usr/lib/x86_64-linux-gnu/libignition-launch3.so

Shouldn't the whole /usr/share and /usr/lib/ruby be part of the runtime package?

Shouldn't the whole /usr/share and /usr/lib/ruby be part of the runtime package?

I think that the discussion is not about runtime vs development packages since library packages typically in Debian are categorized like that, library packages, and not runtime packages.
Probably the point is how we understand the contents of the files under /usr/share and /usr/lib/ruby. Are they files designed to "develop" with the library? Are they consider as configuration files absolutely necessary to run the library and the library has no way of working without them? Are they configuration files somehow optional providing extra features? Depending on the answer we might need to relocate the files.

@j-rivero , is this something reasonable to fix in a stable release, or should we do it from Edifice?

i would prefer not to change the files shipped in packages unless the change solve an important bug and we consider the previous distribution broken for some scenarios. I'm open to change it in Edifice depending on the answer of the previous questions.
P.S: In our Open Robotics repositories we try to follow Debian packaging guidelines although we made some exceptions and the level of strictness is sensibly lower.

Are they files designed to "develop" with the library?

Without /usr/share/ignition/launch3.yaml and /usr/lib/ruby/cmdlaunch3.rb you can't use ign launch. I would say that is a pretty essential part of the library, and to just some development goodies.
The files in /usr/share/ignition/ignition-launch3/configs/* are example launch files. I'm not sure if usage examples should be a part of the runtime or the development package, but I would incline towards runtime.
Here's the rationale for me creating this bug report. As the local development process is still a bit cumbersome with ignition libraries, I prefer to install local development versions into /usr overwriting the binary package files. Once I'm done with development and want to switch back to the binary distribution, I just apt install --reinstall the relevant packages. So I was a bit surprised that reinstalling libignition-launch3 did not return cmdlaunch3.rb to the original state (and I knew I was only editing that file, so no other libraries were needed to be reinstalled - or at least I thought so).


2.1 - problems with on-shape icons when creating annotations

Environment: Windows 7 with latest chrome - Mirador 2.1 demo site - I hit ctrl+F5 to refresh everything but did not manually clear browser cache first.
Problem: click on rotation ignored when creating annotations despite cursor changing to hand on hover
Reproduce:
Create a few square annotations
Select one of the squares you already created
Hover over the rotation icon or the delete icon
Click to rotate or delete
Observe a new shape being created instead rather than rotation mode being activated
Observe that you are creating a shape despite the pointer icon being the active tool

There was no such bug before the new candidate release.
@rsinghal Do you know which change may have caused it?

Yes, I see this happening as well on Chrome on Mac.  Not sure which commit broke this.


compilation error- getting stuck

I git cloned the package Tiny Differentiable Simulator. Inside the package created a build directory.  Inside build as I execute 'make -j', my ubuntu freezes. I am using Ubuntu 20.04, gcc 11(supports cpp 17).  Am I doing something wrong?

This usually happens when your compiler eats up too much memory and the computer begins to use swap memory. Try lowering the core count for make (for example, make -j1 or make -j2)

Hi Philsik,
Thanks for the suggestion. I will give it a try and let you know how it
goes.
Best Regards,
Rupali
On Fri, Oct 8, 2021, 17:52 Philsik Chang @.***> wrote:

This usually happens when your compiler eats up too much memory and the
computer begins to use swap memory. Try lowering the core count for make
(for example, make -j1 or make -j2)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google-research/tiny-differentiable-simulator/issues/168#issuecomment-938599196,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AV7C3V72NDXNQ64CWDLQEPTUF3O7DANCNFSM5FTHPRFQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


[MB-5436] CAT III: SA4006 Fix unused instances

Description
Fix unused instances in the codebase
Setup
make server_test
Code Review Verification Steps

[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Messages

:book:
:link: MB-5436

  Generated by :no_entry_sign: dangerJS against 9839917a1e5ae0d425596d58d936b2b2380d5061


Benchmarks: add benchmarks for AVX2

When issue #17 is finished, add performance benchmarks for that backend.

Added on latest commit.


Add top-level project dropdown

Overview
This PR adds a dropdown to the nav-bar (in between 'Home' and 'Projects') that displays the currently active project (a concept we are introducing here) and options associated with that project. The dropdown also provides a quick way for a user to switch projects while not leaving the editor/browser.
The browse page now takes a route parameter, projectid, that will help handle this change. The current route structure is now /browse/:projectid/:sceneid?
To further facilitate this change, the selectedScenesModal modal has been modified reflect the single active project concept. After selecting scenes and clicking the button at the bottom of the scenes list, the user is presented with the list of scenes, and from there, they can add those scenes to the currently active project in a single click.
In addition, this PR also:

does a bit of reorganization on the browse.controller (see notes)
adds back the 'selectProjectModal' that was previously removed
makes /home the default landing page

Checklist
~- [ ] Styleguide updated, if necessary~
~- [ ] Swagger specification updated, if necessary~
~- [ ] Symlinks from new migrations present or corrected for any new migrations~
Demo

Notes
The browse page was creating a queryParams variable that contained all items from $state.params. This params list provided by angular also includes any parameters defined within the route. Because of this, route params were being persisted in the session storage and would overwrite parameters defined in the URL. For the case of the browse page, this was projectid and sceneid.
This PR separates the two concepts into routeParams and queryParams to prevent any conflation of the two sets of parameters. routeParams are never cached in session storage.
More Notes
This PR doesn't address any other changes to the browse page, so there is no way to know what scenes are already in the current project when adding scenes.
Testing Instructions

Log out and log in: ensure you are taken to the Home page
Click View Projects and go to the list of your projects and then select a project
Click the 'Editor' button, you should be taken to the browse page

Ensure that the project dropdown in the navbar shows the project you just selected
Ensure that that the project's UUID is in the route
Reload: ensure the project is still displayed

Click on a scene to view it's details, ensure the route is updated to reflect the selected scene
Reload: ensure that the scene details are still visible
Close the scene details pane, check that the route no longer has the scene id in it
Reload: ensure that the scene details are not visible
Select some scenes and click the button at the bottom
Check that the buttons on the bottom are now 'Cancel' and 'Add to '
Check in a few ways that the scenes you have selected/unselected from the modal are successfully added to the project.
In the project dropdown, verify that the 'Add Scenes' option is disabled (if you're on the /browse page
Select 'Switch Project' and select a different project
Ensure that the route and dropdown title have changed to reflect the new current project
Try this a few more times with some scene selection/addition combinations to see that everything is working
Using the project dropdown, click 'Edit' and make sure that takes you to the editor
Check that 'Edit' is now disabled (since you're in the editor)
Check that 'Add Scenes` is now enabled and will take you back to the scene browser
Return to the editor and check that switching projects works as expected
If you have any more energy, do some other things

Connects #1260

After hitting next here - this should go to the browse page for that project so you can add scenes, currently it just goes back to home

Button I was talking about

Changed the button text to 'View {{projectname}}' and fixed the redirect. Any attempt to go to browse without a project id set in the route will now redirect to the home page


Gutter compat

Add methods to Droplet to mimic Ace editor gutter decoration functionality. Changes from existing behavior:

Droplet now has setBreakpoint, clearBreakpoint, clearBreakpoints, getBreakpoints, and setAnnotations, with behavior identical to Ace. Droplet will set all of these for itself when called and will also set them in its corresponding Ace editor.
Droplet's guttermousemove now also fires when Ace's fires
Droplet annotation texts can be read with a title-text
Droplet line numbers are now on top and can recieve mouseover events directly
Droplet annotation glyphs are centered vertically on lines

Looks good - outside of the minor issues I commented on.

Responding to earlier comments:

Ace editor supports only types info, error, and warning, so I've covered those now.
I've now changed the css to 2px center and added a paddingBottom, instead of computing the backgroundPosition on-the-fly.

LGTM!


[MRESOLVER-156] Manage Google Guava dependency independent

Fixes https://issues.apache.org/jira/browse/MRESOLVER-156
The runtime dependencies for Guava are explained in the last section of the  README "Important Warnings" #3

Is this consistent with Maven Core?

Is this consistent with Maven Core?

Going through now in tandem with Maven PR.


Disallow embedded whitespace in EntityUID RFC

rendered

IMHO, the issue that this RFC attempts to address derives from the assumption that users are not aware of this particular piece of Cedar syntax. In other words, a well-informed user should avoid to use namespace strings directly. Instead, they should use a normalized form such as Cedar ASTs or printed ASTs.

The RFC has been updated to align with the feedback received so far. What was originally the "Alternative Approach" is now the recommended approach.

Does AuthorizationQuery call EntityTypeName::from_str ?

I'm happy now. I think we should make this change.

@0xjjoyy

Does AuthorizationQuery call EntityTypeName::from_str ?

There is no AuthorizationQuery in Cedar.  Do you mean Request?  If so, constructing the EntityUids to pass to Request::new() will require going through EntityTypeName::from_str, either directly or indirectly, so it would be covered by this change.  More generally, it's internally an invariant of Cedar that any value of type EntityUid has effectively already been validated and normalized, with whitespace removed.  This was already true and will remain so.  The proposal in this RFC is just that EntityTypeName::from_str will not perform normalization, instead it will expect an already-normalized string and fail otherwise.

Crossed wires, sorry.  I was referring to the main Cedar repo, which is implemented in Rust (github.com/cedar-policy/cedar).  The Java bindings depend on the Rust library in that repo.  We should align the terminology better between Java and Rust -- please feel free to open an issue on the Java bindings to update the terminology

The final comment period (FCP) for this RFC is starting now, with intent to accept this RFC.  Due to the potential security concerns of this RFC, we would like to shorten its FCP, and have the FCP end Friday 2023-06-23 at noon PT / 3pm ET / 7pm UTC.  If no new unresolved major objections are voiced by then, this RFC will be merged.
For more on the RFC process, see https://github.com/cedar-policy/rfcs.


[PLAYGROUND PROJECT] Project #94

######################################################################
Please fill out the template below and then delete everything within the #'s here, it is purely informational for help filing this ticket.
For example, this is what it would look like Project 145, Beatboxes by Zeblocks:

Project Title: "Beatboxes"
Project Size: 841
Project ID: 145
Artist Channel ID:<PHONE_NUMBER>35136020
Project Keyword: "beatbox"

Note: you can find the channel ID for a given channel by right-clicking it in Discord and selecting "Copy ID".
Also note that Playground projects need a project keyword so that ArtBot knows that the user is intending to trigger the bot for a given Playground project vs. the artist's first Curated project, which is the default.
######################################################################

Project Title: "Portal"
Project Size: 10
Project ID: 94
Artist Channel ID:<PHONE_NUMBER>51559997
Project Keyword: "portal"

@ryley-o sending this one your way :) thanks for filing Jeff!


Will class definition be supported in the future of nopython mode?

Feature request

Closing this issue due to lack of information. If more information becomes available please add it and reopen the issue. Thanks.

Also, https://numba.readthedocs.io/en/stable/user/jitclass.html is an experimental feature for compiling classes.


Handle suggestions on focus

This enables minLength: 0 usage and also re-displays suggestions
on blur/re-focus.

Great. Many thanks I will merge this one.
Next time, please try to also write the test. Otherwise it is more work for me and it will take longer to release the fix.

Available in v3.2.0

Great, thanks. Yes it was on the TODO.. it's just a rather long one. :)


Design FAQ Page

I made a change to the curve design at the bottom of my faq page for easier implementation when developing.

Designed the FAQ page which consists of responses to frequently asked questions.

Assisted in User Research.


how can i use ioloop in next_tunple

excuse me, i am a newbie in python.
my spout read data from nsq, i use pynsq module as nsq client, but nsq.Reader use tornado.ioloop , this need a message_handler, how can i use it in spout.next_tunple.
from streamparse import Spout
from config import *
import nsq
import Queue
import threading
class NgxLogSpout(Spout):
outputs = ['line']
def initialize(self, stormconf, context):
self.reader = nsq.Reader(
lookupd_http_addresses = lookupd_http_addresses,
topic = topic,
channel = channel,
message_handler=None,
)
    self.queue = Queue.Queue(50)
    t = threading.Thread(target=nsq.run)
    t.start()

def _message_handler(self,msg):
    self.queue.put(msg.body)
    return True

def next_tuple(self):
    try:
        line = self.queue.get(timeout=1)
        self.emit([line])
    except:
        return

use nsq2kafka solve


Update subscription user api "subscription/users/update"

You should implement subscription methods, like update subscription, change plans.

Implemented in https://github.com/avaly/paddle-sdk/commit/310f54d932b3d4f6715c9ee668cdc6c43523ce4b


[-] BO : Bootstrap problem fixed

The lack of a div with this tag causes this module panel to overlap the other panels, which do have it.

Hi, Thank you for your PR.
Best regards.


Support contract signature in the interface

What is this feature about? (1 sentence)
This allows users to sign on and off chain messages with their Safe.
Why is it needed? What is the value? For whom do we build it?

The Safe contracts support contract signature via EIP1271.
We get regularly questions about the support of signing messages.
While still not many dapps support contracts signatures, it would still help adoption of the Safe supports it.

High-level overview of the feature
Lots of things tbd here
"Manual" message signing

Users can select between on and off chain signing.

On chain would trigger a tx to signMessage
Off chain would be done via our backend.

User retrieve signature after it has been signed.

Message signing from Safe apps

Safe apps SDK allow that Safe apps can trigger signing requests

Signing messages is now supported. ✅

This was about signing transactions for the Safe with smart contract wallets, not signing messages with the safe.
To test this you can try to sign the safe transaction with Argent wallet. Currently, it will fallback to an on-chain approval but the wallet is capable of signing it off-chain

lol I misread everything 🤦 nvm


Demo: Redirect write calls to leader

Bunch of changes to the demo:

Added *.log to the gitignore to ignore the results from test-cluster.sh.
Added Arc<reqwest::Client> that will be used and reused on the redirect and RPC.
Added the function redirect_to_leader_if_required that verifies if the current node is the leader, if not, finds it and redirects the data to the leader.

@MikaelCall informed that it's responsability of the client redirect the write to the leader, but is that all true? Please have a look of this PR where I implement the redirect that includes the verification of the node state.

Checklist

[X] Updated guide with pertinent info (may not always apply).
[X] Squash down commits to one or two logical commits which clearly describe the work you've done. If you don't, then Dodd will :).

@MikaelCall informed that it's responsability of the client redirect the write to the leader, but is that all true? Please have a look of this PR where I implement the redirect that includes the verification of the node state.

@ppamorim
IMHO, it would be better to let the client handle the ForwardToLeader error.
A non-leader still chance that it can not find a working leader before the timeout. In which case it has to return the error back to the client. Thus the client still has to deal with such errors.

@drmingdrmer It's totally understandable why it should be restored to the client. Knowing that, I would like to explain to you that in our application we don't want to expose this part of the cluster to the client facing API. Mainly because we expect that client will not know that the cluster exists at the first place. I will do the changes you required by the way.

@drmingdrmer It's totally understandable why it should be restored to the client. Knowing that, I would like to explain to you that in our application we don't want to expose this part of the cluster to the client facing API. Mainly because we expect that client will not know that the cluster exists at the first place. I will do the changes you required by the way.

IMHO, it is up to the application:
When the node the client contacts return an error "I do not know who is the leader", is it acceptable for a client to stop working, even when the client still has the chance to try to reach another node?
Server-side forwarding is much easier to use if the application does not try to maximize availability.


c8d/pull: Add options for stargz/nydus snapshotters

Requires:

#41
#40

Add the RemoteOpt's needed for Pull to work with the stargz and nydus snapshotters.

- What I did
- How I did it
- How to verify it
- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Rebased


feat(auth): Add bulk get/delete methods

This PR allows callers to retrieve a list of users by unique identifier (uid, email, phone, federated provider uid) as well as to delete a list of users.
RELEASE NOTE: Added getUsers() and deleteUsers() APIs for retrieving and deleting user accounts in bulk.

Granted coverage is still adequate but the testing format does not align with the existing pattern used here. Personally I prefer sticking with the current pattern.
The pattern has been to test the RPC logic in auth-api-request.spec.ts
Then test the adequate auth-api-request calls are made in auth.spec.ts.

Granted coverage is still adequate but the testing format does not align with the existing pattern used here. Personally I prefer sticking with the current pattern.
The pattern has been to test the RPC logic in auth-api-request.spec.ts
Then test the adequate auth-api-request calls are made in auth.spec.ts.

Mostly done. I've moved some tests over entirely (where possible), kept some tests in auth.spec.ts (when those tests test behaviour entirely confined to auth.ts) and split some between the two (as auth.ts modifies the results from auth-api-request.ts, most notably adding a notFound parameter to the results as well as parsing everything in to a UserRecord.)

LG, thanks!
There's an instance of "deleteUsers()" in line is 680 of auth.d.ts that should be backticked, but we can get that later if it's a PITA.

Not a problem; fixed.


Code Loop

Need a feature to add a repeat of codes instead of closing the program and executing it again.
Functions to ask user choice to exit would be suggested.

Code loop checked. Code added.

Testing: Works.


Fixed test execution and added yarn.lock so it stays that way

Fixed the build and test execution.
It was actually surprisingly complicated to come up with a set of dependency versions that work. For example, newer versions of rollup seem to contain a bug that was incorrectly tree-shaking away code that causes tests (and the corresponding real functionality) to fail.
As such I've added a lock file so that no-one else has to go through the painful dependency versioning trial and error I just went through!

I should probably note that grunt-template-jasmine-requirejs is no longer maintained (last update over 3 years ago), so I've switched to a fork that is maintained.


Sunbeam is not visible in Firefox

Sunbeam animation is not visible in FF 68.0.1 despite it works in Chrome.

fixed in commit 05eb872


Unexpected Placement of Shiny Pokémon Textures

Describe the bug
Some Pokémon images are displaying inaccurately, showing shiny versions instead of their original forms.

it also appears on Admurai

Spotted another one "Donarion"

Kranoviz

Jiutesto

Ferroseed

Zwollock

Flauschling

Admurai
Donarion
Kranoviz
Jiutesto
Ferroseed
Zwollock
Flauschling

Current Compromize:
Changeable to 'original' png images.


Burpsuite does not show anything when i send request into autorepeater

Hi nccgroup,
I've tried your extension but it looks like the function does not work. i wonder if there is any requirement?
Thanks

Hey there,
The readme doesn't really reflect and I'll be sure to update it to include some more broad instructions but AutoRepeater won't resend or display requests sent to it unless there's a defined replacement set that alters the request sent to it. This is to prevent AutoRepeater from repeating requests which won't be changed.
Does setting a replacement for your request fix it or is there another issue with how a certain type of replacement is implemented?

@m00r3 I also found the same issue. I added a condition with match and replace for headers and then sent a particular request to AutoRepeater, but the request is not shown in the pane. I also tested a variety of other rules with and without regex - string, in scope, etc, but doesn't seem to make a difference. However, there are no errors in the Extender tab.

@rsmith31415 Can you please try using a header replacement rule from the proxy match and replace settings? To do header replacements without a regular expression you need to enter the entire header value into the find location.

@m00r3 Hopefully, this is what you mean: I added a new rule to change a header value in "Proxy" -> "Options" -> "Match and Replace", and added a "Request header" rule to change the header "Upgrade-Insecure-Requests" from "Upgrade-Insecure-Requests: 1" to "Upgrade-Insecure-Requests: 2" and that works correctly. When I try to create a similar rule in AutoRepeater, I don't see the new request in the "AutoRepeater" tab.

@rsmith31415 I think I've sorted out the cause. It looks like there's a bug with the "Send To AutoRepeater" functionality. Resending the following request from Repeater
GET / HTTP/1.1
Host: www.google.com
User-Agent: curl/7.51.0
Accept: */*
Upgrade-Insecure-Requests: 1
Connection: close
with an AutoRepeater replacement configured with
Type: Request Header
Match: Upgrade-Insecure-Requests: 1
Replace: Upgrade-Insecure-Requests: 2
Which: Replace First
Regex Match: Not selected
and an AutoRepeater Condition set to
Boolean Operator:
Match Type: Sent From Tool
Match Relationship: Burp
Match Condition:
I was able to get AutoRepeater to correctly perform the replacement. Can you please try the above case to make sure that the only bug is within the "Send To AutoRepeater" functionality and not some other feature?

@m00r3 Yes, that works correctly.
By the way, I found that if you use the scanner and the request is matched by a condition, you will also see that request in the AutoRepeater pane. I'm pretty sure that's not an intended behavior.

@rsmith31415 So I've tracked down the source of the bug that causes "Send To AutoRepeater" not to work. I'll start working towards getting it fixed right away.
As for AutoRepeater picking up requests generated by scanner, that is intended functionality but it shouldn't be enabled by default. In the update that fixed "Send To AutoRepeater" that will also be fixed.

@rsmith31415 Can you give it another go with the updated AutoRepeater.jar. Hopefully both of the above issues should be fixed now.

perfect and thanks. I'll close this issue and look into the other one.


How to make pairings persistent?

I'm using Linux.Bluetooth in a C# program running on a Raspberry Pi 4 (bullseye).  I can scan for devices, pair to them, and everything works great...until I reboot; after a reboot, none of my paired devices remain.
If I use bluetoothctl (and scan and pair), the pairings are retained after a reboot.
Is there something I need to do to make pairings persist (i.e. to get restored after a reboot)?
TIA,
--mkj

Closing, this is not an issue. Please post questions in the discussion board


Fix SVG scaling in Cubic Bezier.

Use clientWidth / clientHeigh instead of getBoundingClientRect in the Cubic Bezier view to support scaling the control with CSS transforms.
Related to Issue #584 and PR #586  in the main Tweakpane repository.

Merged, thank you for your contribution!


GDScript: Adjust STATIC_CALLED_ON_INSTANCE warning to not force native type

Defaulting to the native type is less than useful, as:

There are very few native types that are extensible and have static methods.
Defaulting to the native type does not account for a method being script-defined.

While the "real fix" would be to carefully track the source of the method, the get_function_signature method is already complicated enough.
This will at least ensure the resulting code should always be valid.
This PR was written after seeing the following warning:
*  W 0:00:00:0542   The function "get_absolute_z_index()" is a static function but was called from an instance. Instead, it should be directly called from the type: "Node2D.get_absolute_z_index()".

Where get_absolute_z_index() was a static function declared in a script (and thus did not exist in Node2D, and thus the given code did not work)

Bugsquad edit: Fixes #74397.

Note that for non-global classes the warning will suggest invalid code.

Note that for non-global classes the warning will suggest invalid code.

Example, please? I'm not sure what constitutes a "non-global class" in this case.

Example, please? I'm not sure what constitutes a "non-global class" in this case.

Note that this would be wrong on the current master also, it would show EditorScript.static_func() which isn't a valid way to call it.
We can either accept this as small improvement or work on a proper fix that finds the origin of method.
PS: I wonder if we should even emit this warning with a direct call for a function in the same class. If it does not have class_name it is quite cumbersome to avoid this warning.

I've amended my commit on the basis of that other languages don't warn for these kinds of self-calls to static functions.
There are more examples and counter-examples one could add involving self and var x := self and so forth.

Thanks!


ActionSheet Style

Hello,
I was wondering if there is an option to customize the style of the actionsheet?
I was searching into the code and found that you can't customize it in the theme or by props.
Someone figured a way to do this witouth modify the sourcecode on nativebase actionsheet?
Will apreciate it alot.
Thanks

@anjapadu sharing the material design guidelines for bottom sheets https://material.io/design/components/sheets-bottom.html#
Can you specify what you would like us to add to NativeBase actionsheets (android)

hello any news on this feature ?  open for PR ?

I also need dark background color for actionsheet at least on android, and light text color for action items. Please someone share if there is any other solution for it also. I am using it in an expo app.

Still impossible to change the color of actionSheetContainer

Me too, I need to change the text color for the NativeBase ActionSheet.

howcome this did not get merged in?

Actionsheet not working with Dark theme on Android:

Any updates on this? It's been 3 years...

For anyone who needs a solution until this gets merged:
https://github.com/beefe/react-native-actionsheet

They have fixed it, but forgot to update typings for Typescript and does not mention it in their docs.
https://github.com/GeekyAnts/NativeBase/commit/75a604f78e95d50c076f02a62ea58023ca088391
You can pass a style object into the configuration.
ActionSheet.show({         style: {           backgroundColor: 'red',         },         options: []   };


Working Tree window empty when opening first time

VSCode Version: 1.16.1
OS Version: Windows 7

Steps to Reproduce:
This applies to projects under git source control

Commit all changes.
Change some file
Go to 'Source Control' from 'Activity bar'. In 'Changes' section the edited file should be listd.
Double click the file name.

Effect: new tab opens but the content is empty.
If I do the same thing after a while the compare view opens without problem.

Can you share a screenshot?

It looks like this:

If you open the Developer Tools (F1, Developer Tools) do you see any errors there?

No.

@alexandrudima @bpasero Anything you guys know that might be helpful here?

Maybe run with "break on error"? I wonder if we hit an exception but do not show it.

@joaomoreno This looks as if the diff editor gets null models or the models get disposed after being attached.
@gozzoo Do you have any problem when right clicking on a file in the explorer and selecting "Compare" and then right clicking on another file an selecting "Compare with ....". This will also bring up the diff editor, but with comparing two files on disk. Does this work consistently?

It happens when I try to open the compare view the first time. If I close it and try again latter it works.
I noticed on the empty screen, that right of the scrollbar there is a vertical bar with color bands (visible on the screenshot), which represent the changes. I noticed that when I manage to open the same compare view again the color pattern on the right is not the same as the one on the empty screen.
alexandrudima - I tried to compare 2 files, everything was fine.

I just noticed that this happens more often on slow hardware. I have a very old laptop (~10yo) and it happens amost always when I first try to open compare view. On my desktop, which is also old, but much faster than the latpop it happened only once.
Could this be some kind of race condition?

@gozzoo Is this still an issue for you?

The problem has disappeared since the last release, thaks.


Disable the consistent-return rule

The consistent-return rule is intended to catch errors when a function returns an unexpected type of data like undefined. However, I find myself often disabling the rule for callback functions that use guard clauses. This indicates that enabling the rule goes against the philosophy "equip developers with powerful semantics". Therefore, the rule will be disabled.

/* eslint consistent-return: off */

How do you disable the rule?

/* eslint consistent-return: off */


docker.service: main process exited, code = exited, status = 125/n/aFailed to start Docker application container engine

I am using Debian 8. i use docker-machine to install docker on remote server. it shows on local machine
" Error creating machine: Error running provisioning: ssh command error:
command : sudo systemctl -f start docker
err     : exit status 1
output  : Job for docker.service failed. See 'systemctl status docker.service' and 'journalctl -xn' for details.
"
Then I login the remote server, and check the journalctl -xn
it shows:
"docker.service: main process exited, code = exited, status = 125/n/aFailed to start Docker application container engine"
docker -v
Docker version 17.06.0-ce, build 02c1d87
docker-machine -v
docker-machine version 0.12.0, build 45c69ad
Anyone who can help me? Thanks a lot

Yea I need help too please


Enable signing using InternalKey and update version for beta package …

…to 2.0.0-beta1

I don't understand why we wouldn't use publicrelease property to build interim builds. Other than that - it is good to go


Verify that ROM_EXT can boot an owner stage test program in various locations.

The test program should be launched via the OTTF.
The test program should print out the boot_log data.
The test program should be tested in the A slot, the B slot and the virtual slot.

Completed by #20081

Completed by https://github.com/lowRISC/opentitan/pull/20122


Allow declare type when there is an exports entry.

As discussed with @samwgoldman declare type should be available when there is an exports entry in a declared module.
I didn't allow this before because of the TODO comment, but it seems there is no collision possible.
Fix #880.

I don't know why it's failing :o

On my debian the test integration is failing randomly, maybe because of tests runned in parallel ? (tests have passed on travis since yesterday)


Feature: Unit Swap and/or Detection

Hi,
I’m based in the US and therefore used to imperial units (terrible, I know). kWh/100 miles primarily but any others that may be in there.
I’d be interested in attempting implementation if it’s not already available or in the works.

Im not planing on implementing "freedom units" myself 😜
If you want to you can give it a try. In general you would just need to use a factor on the values when generating the Strings. Im currently working on a bigger rework of the internal data structure, but these functions should not be affected too much.
Short example for the speed string:
    private fun getCurrentSpeedString(): String {
        when (unitSystem) {
            UnitSystem.Imperial -> return "${(DataHolder.currentSpeedSmooth * 2.236).toInt()} mph"
        }
        return "${(DataHolder.currentSpeedSmooth * 3.6).toInt()} km/h"
    }

The display distance unit can also be read from the VHAL: https://developer.android.com/reference/android/car/VehiclePropertyIds#DISTANCE_DISPLAY_UNITS

I'm a dirty American as well and would like to see this implemented. I was wondering if there was a way to link the displayed units to what the System Units setting is.

will have a look, we might noot change how we collect and store the data but as @Ixam97 suggested we can use the label functions and the system settings to convert the values. Also the plot need to be adjusted.
will wait for the reworked data manager to implement it

With this miles and km can be toggled manually. I'll have a look at switching it depending on the system setting.


WIP: Simulation ros

This change is

From https://github.com/EricssonResearch/scott-eu/blob/simulation-ros/simulation-ros/doc/architecture.md#2-architecture how does VREP send ROS messages to the robots if they  don't share a common master?

Indeed that's a good question.
I think we need to rethink this. In the way things are showed on the diagram, it's impossible to communicate between among different ROS nodes within different robots.
Is that the case, that on simulation we just have one rosmaster running on V-REP machine's? And the scenario with one rosmaster for each robot it's with real robots?
What do you think guys? @albertohata @KRaizer @rssouza

I imported this PR to Reviewable https://reviewable.io/reviews/EricssonResearch/scott-eu/73#- becase Github is not handling half a thousand files well.

Review status: 0 of 434 files reviewed at latest revision, all discussions resolved, some commit checks failed.

a discussion (no related file):
I think you should use this gitignore https://github.com/github/gitignore/blob/master/ROS.gitignore

simulation-ros/devel/.built_by, line 1 at r1 (raw file):

catkin_make

is it an autogerated file?

simulation-ros/devel/.catkin, line 1 at r1 (raw file):

/home/eznasam/project/scott-eu/simulation-ros/src

not sure this file shall be here

simulation-ros/devel/.rosinstall, line 2 at r1 (raw file):

- setup-file:
    local-name: /home/eznasam/project/scott-eu/simulation-ros/devel/setup.sh

same, not sure you should commit this folder

Comments from Reviewable

@jramadeu
As I recall, we discussed this issue during our last meeting here. The conclusion was that we had to update the diagram to make it clear the difference between the two options: 1) everything working in simulation, 2) real robots + simulation
We had two ideas at the time: a) creating one separate diagram for each case, b) leave both cases in a single diagram, but with different colors.

cc @rafiainam

Yes, when I was writing my previous message I also remembered our discussion. So, we can say that:

In simulation:
Only one rosmaster being executed on the vrep machine's. No rosmater inside simulated robot (btw, the vrep is the robot =p)

In real robots:
Each robot has his own master.

In my opinion, and we have discussed this, I think the best option it's to put in red all boxes that are used only in simulation, in blue the ones used only with real robot.

Review status: 0 of 434 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

a discussion (no related file):
Previously, berezovskyi (Andrew Berezovskyi) wrote…
I think you should use this gitignore https://github.com/github/gitignore/blob/master/ROS.gitignore

I agree. Didn't realize all the trash on the repo.

simulation-ros/devel/.built_by, line 1 at r1 (raw file):
Previously, berezovskyi (Andrew Berezovskyi) wrote…
is it an autogerated file?

Yes... We should use that gitignore that you suggested.

Comments from Reviewable

Thanks @jramadeu. How does a CB twin  interface a simulated conveyor belt in VREP?
–Andrew.
(sent from my phone)

On 6 Mar 2018, at 18:41, jramadeu<EMAIL_ADDRESS>wrote:
Yes, when I was writing my previous message I also remembered our discussion. So, we can say that:
In simulation:
Only one rosmaster being executed on the vrep machine's. No rosmater inside simulated robot (btw, the vrep is the robot =p)
In real robots:
Each robot has his own master.
In my opinion, and we have discussed this, I think the best option it's to put in red all boxes that are used only in simulation, in blue the ones used only with real robot.
Review status: 0 of 434 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.
a discussion (no related file):
Previously, berezovskyi (Andrew Berezovskyi) wrote…
I agree. Didn't realize all the trash on the repo.
simulation-ros/devel/.built_by, line 1 at r1 (raw file):
Previously, berezovskyi (Andrew Berezovskyi) wrote…
Yes... We should use that gitignore that you suggested.
Comments from Reviewable
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Sorry about about know what is a CB twin.
But if we want to interface a conveyor belt in VREP, I see two ways of doing it:

Direct access to the conveyor belt via V-REP Remote API (JAVA, C++, Python...)

Create a ROS Node in a similar way to the robots

Review status: 0 of 434 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

Comments from Reviewable

Sorry... Last message was poorly written. Translating that to English: "I don´t know what is a CB twin"

Review status: 0 of 434 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

Comments from Reviewable

Sorry, it’s a conveyor belt twin.
–Andrew.
(sent from my phone)

On 6 Mar 2018, at 23:56, jramadeu<EMAIL_ADDRESS>wrote:
Sorry... Last message was poorly written. Translating that to English: "I don´t know what is a CB twin"
Review status: 0 of 434 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.
Comments from Reviewable
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Review status: 0 of 438 files reviewed at latest revision, 12 unresolved discussions.

a discussion (no related file):
Previously, jramadeu wrote…
I agree. Didn't realize all the trash on the repo.

please run git ls-files --ignored --exclude-standard | xargs git rm --cached and push the change to remove the newly ignored files

simulation-ros/doc/architecture.md, line 26 at r3 (raw file):

![alt text](http://url/to/img.png)

not a real URL I think :)

simulation-ros/src/turtlebot2i/turtlebot2i_warehouse/CMakeLists.txt, line 1 at r3 (raw file):

cmake_minimum_required(VERSION 2.4.6)

do you think we can add this to the Travis build config?

simulation-ros/src/turtlebot2i/turtlebot2i_warehouse/Makefile, line 1 at r3 (raw file):

include $(shell rospack find mk)/cmake.mk

hmm, installing rospack in Travis/etc is a start

simulation-ros/src/turtlebot2i/turtlebot2i_warehouse/manifest.xml, line 7 at r3 (raw file):

  </description>
  <author>Alberto</author>

Alberto Hata?

simulation-ros/src/turtlebot2i/turtlebot2i_warehouse/manifest.xml, line 8 at r3 (raw file):

  </description>
  <author>Alberto</author>
  <license>BSD</license>

I think the repo license is Apache 2.  Or we don't care?

simulation-ros/src/turtlebot2i/turtlebot2i_warehouse/manifest.xml, line 10 at r3 (raw file):

http://ros.org/wiki/turtlebot2i_warehouse
does not exist yet

simulation-ros/src/turtlebot2i/turtlebot2i_warehouse/scene.yaml, line 1 at r3 (raw file):

- node:

where did this file come from?

simulation-ros/src/vrep_ros_interface/external/v_repStubsGen/external/pycpp/README.md, line 57 at r3 (raw file):

#py for i, item in enumerate(items):
#py if item == items[-1]:
    `item` = `factorial(i+1)`

Whoa that's very cool stuff!!! But why are we using it here?

Comments from Reviewable

please run git ls-files --ignored --exclude-standard | xargs git rm --cached and push the change to remove the newly ignored files

Why did you close it @albertohata?

Thanks @berezovskyi for your comments! My replies are below.

a discussion (no related file):
Previously, jramadeu wrote…
please run git ls-files --ignored --exclude-standard | xargs git rm --cached and push the change to remove the newly ignored files

I've added .gitignore file.

simulation-ros/doc/architecture.md, line 26 at r3 (raw file):
![alt text](http://url/to/img.png)

not a real URL I think :)

Thanks for noticing that. I have fixed that before, but for some reason it got wrong again..

simulation-ros/src/turtlebot2i/turtlebot2i_warehouse/CMakeLists.txt, line 1 at r3 (raw file):
cmake_minimum_required(VERSION 2.4.6)

do you think we can add this to the Travis build config?
Never used Travis build, but this may be considered.

simulation-ros/src/turtlebot2i/turtlebot2i_warehouse/Makefile, line 1 at r3 (raw file):
include $(shell rospack find mk)/cmake.mk

hmm, installing rospack in Travis/etc is a start
simulation-ros/src/turtlebot2i/turtlebot2i_warehouse/manifest.xml, line 7 at r3 (raw file):
  </description>
  <author>Alberto</author>

Alberto Hata?
I'll include this also.

simulation-ros/src/turtlebot2i/turtlebot2i_warehouse/manifest.xml, line 8 at r3 (raw file):
  </description>
  <author>Alberto</author>
  <license>BSD</license>

I think the repo license is Apache 2. Or we don't care?
This information came from the file that I copied. I will update it.

simulation-ros/src/turtlebot2i/turtlebot2i_warehouse/manifest.xml, line 10 at r3 (raw file):
http://ros.org/wiki/turtlebot2i_warehouse
does not exist yet

This was automatically generated by ROS. I will remove that.

simulation-ros/src/turtlebot2i/turtlebot2i_warehouse/scene.yaml, line 1 at r3 (raw file):
- node:

where did this file come from?
This file I will use to store the topological map of the warehouse scenario.

simulation-ros/src/vrep_ros_interface/external/v_repStubsGen/external/pycpp/README.md, line 57 at r3 (raw file):
#py for i, item in enumerate(items):
#py if item == items[-1]:
    `item` = `factorial(i+1)`

Whoa that's very cool stuff!!! But why are we using it here?
Indeed very amazing! This file actually belongs to v_repStubsGen which is required by V-REP ROS Interface.

Why did you close it @albertohata?

I think it was closed automatically by github :/
Sorry, it was not my intention...

@berezovskyi Regards to the architecture, I updated the figure and the description. However, it is still not complete. Any comments are welcome.

@berezovskyi, I still not able to merge pull request. It seems that a review is still required...

Reviewed 162 of 440 files at r1, 1 of 2 files at r2, 23 of 48 files at r3, 2 of 186 files at r4, 1 of 2 files at r5, 38 of 107 files at r6, 12 of 13 files at r7.
Review status: all files reviewed at latest revision, 12 unresolved discussions, some commit checks failed.

a discussion (no related file):
Previously, berezovskyi (Andrew Berezovskyi) wrote…
please run git ls-files --ignored --exclude-standard | xargs git rm --cached and push the change to remove the newly ignored files

Thanks!

simulation-ros/src/phantomx_pincher_arm/phantomx_pincher_arm_description/package.xml, line 3 at r6 (raw file):

phantomx_pincher_arm_description

can use git submodules instead of vendoring the whole folder?
https://github.com/Interbotix/phantomx_pincher_arm

simulation-ros/src/phantomx_pincher_arm/phantomx_pincher_arm_description/package.xml, line 16 at r6 (raw file):

TODO

we need a real license here

simulation-ros/src/turtlebot2i/README.md, line 3 at r6 (raw file):

turtlebot2i

same, can we do a git submodule here?
https://github.com/Interbotix/turtlebot2i

simulation-ros/src/vrep_ros_interface/CMakeLists.txt, line 1 at r6 (raw file):

cmake_minimum_required(VERSION 2.8.3)

again, same thing: let's use submodules!

simulation-ros/src/vrep_ros_interface/package.xml, line 2 at r6 (raw file):

vrep_ros_interface

simulation-ros/devel/.built_by, line 1 at r1 (raw file):
Previously, jramadeu wrote…
Yes... We should use that gitignore that you suggested.

Done.

simulation-ros/devel/.catkin, line 1 at r1 (raw file):
Previously, berezovskyi (Andrew Berezovskyi) wrote…
not sure this file shall be here

Done.

simulation-ros/devel/.rosinstall, line 2 at r1 (raw file):
Previously, berezovskyi (Andrew Berezovskyi) wrote…
same, not sure you should commit this folder

Done.

Comments from Reviewable

@albertohata that's the point, someone needs to review it :)
And about licenses: you must NEVER change the license that was put there by someone else. BSD licenses are fully OK. The ROS package either needs to be updated from the original repo to include the BSD license, or you should switch all packages (where possible) to use submodules.
once we resolve the license questions, I will +1 this. we can check how the code works later when we integrate with my branch.

Review status: all files reviewed at latest revision, 17 unresolved discussions, some commit checks failed.

simulation-ros/src/phantomx_pincher_arm/phantomx_pincher_arm_description/package.xml, line 3 at r6 (raw file):
Previously, berezovskyi (Andrew Berezovskyi) wrote…

phantomx_pincher_arm_description

can use git submodules instead of vendoring the whole folder?
https://github.com/Interbotix/phantomx_pincher_arm

Hm... I think we can't use submodule because this's a modified version of the original repo hosted on github. We have an internal repository with the modifications and we keep that here using subtree. Is it a better practice to switch to submodule?

simulation-ros/src/phantomx_pincher_arm/phantomx_pincher_arm_description/package.xml, line 16 at r6 (raw file):
Previously, berezovskyi (Andrew Berezovskyi) wrote…

TODO

we need a real license here

ACK

simulation-ros/src/vrep_ros_interface/external/v_repStubsGen/external/pycpp/README.md, line 57 at r3 (raw file):
Previously, berezovskyi (Andrew Berezovskyi) wrote…
Whoa that's very cool stuff!!! But why are we using it here?

This is used by the vrep_ros_interface.
If I'm not mistake this is used by the vrep_ros_interface to generate an interface between C++ and Lua Functions. This's a wild guess.

Comments from Reviewable

simulation-ros/src/phantomx_pincher_arm/phantomx_pincher_arm_description/package.xml, line 3 at r6 (raw file):
Previously, berezovskyi (Andrew Berezovskyi) wrote…
    phantomx_pincher_arm_description

can use git submodules instead of vendoring the whole folder?

https://github.com/Interbotix/phantomx_pincher_arm

Hm... I think we can't use submodule because this's a modified version of the original repo hosted on github. We have an internal repository with the modifications and we keep that here using subtree. Is it a better practice to switch to submodule?

simulation-ros/src/turtlebot2i/README.md, line 3 at r6 (raw file):
turtlebot2i

same, can we do a git submodule here?
https://github.com/Interbotix/turtlebot2i

Same in the case of the phantomx_pincher_arm, we are using our own turtlebot2i package. We are not using the code from Interbotix repository (until now).

simulation-ros/src/vrep_ros_interface/CMakeLists.txt, line 1 at r6 (raw file):
cmake_minimum_required(VERSION 2.8.3)

again, same thing: let's use submodules!

In this case, the vrep_ros_interface has slight changes from the original source, such as support for other turtlebot2i messages.

@berezovskyi have you any idea how to fix the following problem?

continuous-integration/travis-ci/push — The Travis CI build failed

@albertohata did you look at the build output (via the Details link)? I will take a look now

Okay, a had a quick look. Seems like it's due to #62

Re: "custom" packages – how custom is custom? Did you base your code on theirs (ie forked it)? Does it make sense to actually fork each of the repos and make changes on a branch there and:
track those branches from submodules
submit your changes back to the original repos

The "custom" is in the sense that some of the packages are derived from packages of other repositories. An example is the turtlebot2i_description package which uses the turtlebot2i 3D models of the manufacturer repository. As just some of the files are reused don't know if forking the whole repo is necessary. What do you think?  (An exception is the vrep_ros_interface package which maybe makes sense forking it.)

won't merge; see #110


How to set an alpha or remove this gray bar that appears under the header?

I see in some of the screenshots on the repository that there is a transparent bar under the header, but when I add the calendar in my project there is always this gray bar that is not transparent. So I would like to know how to set an alpha on it, so I could actually put it to 0, if there is a way of removing it, even better.
See the screenshot with the bar:

And with alpha as showed in the repository page:

Just found that, this view is the All day events view. Closed

Any solutions to this

showsAllDayEvents should set to false


problem with lstm_seq2seq with word embeddings

Hi all,
Thanks in advance for your help. I'm trying to implement a seq2seq using keras and following the instructions given in the ten minutes tutorial(https://blog.keras.io/a-ten-minute-introduction-to-sequence-to-sequence-learning-in-keras.html). In my case I need to used word embeddings, son I followed the isntructions given in the FAQ section. This is my resulting model:

# Define an input sequence and process it.
encoder_inputs = Input(shape=(None,))
enc = encoder_embeddings(encoder_inputs)
enc, state_h, state_c = LSTM(vector_dim, return_state=True)(enc)
# We discard `encoder_outputs` and only keep the states.
encoder_states = [state_h, state_c]

# Set up the decoder, using `encoder_states` as initial state.
decoder_inputs = Input(shape=(None,))
dec = decoder_embeddings(decoder_inputs)
decoder_outputs = LSTM(vector_dim, return_sequences=True)(dec, initial_state=encoder_states)
decoder_dense = Dense(decoder_embeddings.input_dim, activation='softmax', name='output')
decoder_outputs = decoder_dense(decoder_outputs)

# Define the model that will turn
# `encoder_input_data` & `decoder_input_data` into `decoder_target_data`
model = Model([encoder_inputs, decoder_inputs], decoder_outputs)

encoder and decoder_embeddings layer is passed as parameter and consists of a trained embedding layer of dim = 128.
Inputs are of this shape:
encoder_input_data = np.zeros(
    (len(abstracts), max_encoder_words),
    dtype='float32')
decoder_input_data = np.zeros(
    (len(titles), max_decoder_words),
    dtype='float32')
decoder_target_data = np.zeros(
    (len(titles), max_decoder_words, len(dictionary)),
    dtype='float32')

Where input_data are sequences of word indexes and target_data is one hot encoding of the words.
The things is that at training time, Keras is telling me that the output passed to fit does not match the expected shape:
expected output to have shape (None, 1, 10000) but got array with shape (1024, 17, 10000)
My vocabulary is made of 100000 words, with a batch size of 1024 and the max decoder words is 17.
I've been checking at run time my implementation and the example in keras, and the difference comes in the output of the Dense layer. In the example, the output  has a shape of (?,?,93) while in my implementation the output has the second dimension fixed to 1 (?, 1, 10000). I don't know why, after applying the dense to the LSTM output it is guessing this dimension of 1. The shape of the inputs, in my case after applying the embedding layer, are similar: (?,?,93) in the original example, (?,?,128) in my case.
Anyone idea of what is happening?

having a similar problem. Did you get to solve it?
Thanks


Add wezterm-detection with FocusIn hook

Hi @alexherbo2,
I think I see now. It certainly makes sense to add a feature like that, it has a slightly niche use case. I tested this on my PC with WezTerm and Xfce Terminal. It looks like the integration for the commands turns on when I create a session in Xfce Terminal and connect with WezTerm, but it doesn't look like it turns off when I focus back on Xfce Terminal or if I start with WezTerm and connect with Xfce Terminal.
Is this intentional behaviour or is it a bug? If it's a bug, you might want to do something like adding a FocusIn hook that disables integration if a Kakoune session on anything except WezTerm is focused. If it's intentional, I'm not sure how much sense it makes to only have it go one way.


feat(library/theories/group_theory): Group and finite group theories

subgroup.lean : general subgroup theories, quotient group using quot
finsubg.lean : finite subgroups (finset and fintype), Lagrange theorem,
finite cosets and lcoset_type, normalizer for finite groups, coset product
and quotient group based on lcoset_type, semidirect product
hom.lean : homomorphism and isomorphism, kernel, first isomorphism theorem
perm.lean : permutation group
cyclic.lean : cyclic subgroup, finite generator, order of generator, sequence and rotation
action.lean : fixed point, action, stabilizer, orbit stabilizer theorem, orbit partition,
Cayley theorem, action on lcoset, cardinality of permutation group
pgroup.lean : subgroup with order of prime power, Cauchy theorem, first Sylow theorem

This is really great! I am looking forward to studying the files more carefully when I am back in Pittsburgh.

Yes, this is great indeed :-)
Thanks a lot!


Updated for 0.60.x

Thanks for the info, really handy. I've updated for react-native 0.60.x

In 2023, your method will also be outdated. I suggest using https://github.com/junedomingo/react-native-rename, which worked well for me.
basically , remember to backup first, then
npx react-native-rename@latest "new_name"


dnn v 9.04

Has this been tested in v 9.04?
I've just tested on v9.04.04 and it failed to install. I got the standard error when installing:

"An unknown error has occured. Please check your installation zip file and try again.
Common issues with bad installation files..."

I tried increasing the file limit in web.config (maxRequestLength) - to see if that made a difference, but it still failed to install.

I have it running in 9.9.1 currently, haven't tested 9.4.4 for a while, but it should work there too, I definitely had it running there for a while


Makes push-drivers use gcloud-init script

Description
The soon to be deleted setup-gcp-env script from circleci is now replaced by the gcloud-init script in .openshift-ci. This script is now more flexible to different credentials as required by the caller.

These changes have been tested and are successful in the associated openshift/release rehearsal https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/32632/rehearse-32632-pull-ci-stackrox-collector-giles-fix-push-drivers-creds-namespace-push-drivers/1574790753014517760


Update dev vs base dependencies

Description

Resolves #76
I removed llvm because it installs a bunch of stuff we don't need when we install our required llvm/clang stuff individually anyways. I moved libboost-all-dev cause that's the only one with any runtime static libraries we'll need to link to. The other stuff is all devtool stuff. Even protobuf just generates .h files at compile time.

Verification

Oops wrong branch


Cool utility question

Hey I would like to know if there is anyway that this tool could have a “Disconnect” button type thing.
I know it sounds kinda sketchy but I keep getting this AFK farmer and it would be much easier to press a quick button instead of going around the menus to disconnect from the session.
I used the DS3 tool which was super handful with the invasion keybind, but I know in ER it’s not possible due to this shit anticheat (shit because of the problem that comes with it)

Hi!
Despite the presence of EAC, It would still be possible to implement a form of "Leave Session" hotkey. However, it would work differently from the one available in my Dark Souls 3 program, as EAC prevents accessing the game process.
That being said, I am not planning to implement this at all for the two following reasons:

The forceful disconnect would have to work by blocking the connection to the player directly. This may cause issues for both parties, such as sometimes having to wait for the game's 30 second connection timeout or even triggering the multiplayer disconnect penalty, which prevents you from playing online for 12 hours of in-game (character) time.

I'ce received many reports of people abusing this feature in DS3 as it was essentially a faster alt f4 that didn't require you to restart your game.

For your specific situation, note that the player block system that existed in DS3 is still present in Elden Ring. If you click on the name of a player in the "Session Info" tab, their profile page will open in the Steam overlay. From there, you can simply block them and this will prevent you from ever seeing them in-game again. However, note that it may take up to 5 minutes for the game to sync your Steam blocklist.