Allow maxAge 0 and make defaultMaxAge a variable to create a non-persistent cookie

Related to the following PR.
https://github.com/boj/redistore/pull/55
Here is the outline of changes.

Allow maxAge 0 when saving a redis store.
Make defaultMaxAge a variable and allow to change this value from outside.

Why allow MaxAge to be 0?
When setting cookie, by not setting a MaxAge, we can make a one-time cookie and user loses authentication state after closing the browser. And then, user will open website again, the login state would not be persisted and we can prompt to login again.
But if redis TTL is set to zero, server loses the authentication information while user is staying in the browser, and the user's login status will be disappeared
I think it's not uncommon to use redis with some TTL and to set the session's  MaxAge to 0, which is required for my product indeed.
There is already a defaultMaxAge property, but now maxAge is not allowed to be 0, so defaultMaxAge has no chance to be used.
But this approach is flexible, allowing maxAge to be 0, we can set different expiration for session and redis.
Once I'd like to give arguments to Save function, but this is an implementation of Interface, so we can't change function structure.
So I accomplish this by changing defaultMaxAge from outside. With this approach we can realize this use case without breaking the implementation of interface.

Any updates?


One test case throw a StackOverFlowException but all cases are passed

Description

IMPORTANT: if the defect is reproduced only in a workflow from within the Visual Studio IDE then do not report the issue here - instead, please report it using Visual Studio's "Send Feedback" option that can be accessed from the Help menu OR using this link https://developercommunity.visualstudio.com.
For a defect specific to the MSTest V2 test framework, describe the issue you've observed.

One of my test cases failed because a StackOverFlowException. But the result shows it is passed.

And run the cases in local environment:

The red test is failed.
Steps to reproduce
Run a test case that will stack overflow.
Expected behavior
The test case will failed.
Actual behavior
The test case is passed, but vstest failed. So I can't know which test case failed when there are a lot of cases.
Environment

Please share additional details about the test environment.
Operating system, Build version of vstest.console, Package version of MSTest
framework and adapter

nuget package: 1.3.2

@KayMKM : We are unable to reproduce this at our end. Plain vanilla tests clearly shows test didn't pass.

Is there anything we are missing?

@KayMKM : We are unable to reproduce this at our end. Plain vanilla tests clearly shows test didn't pass.

Is there anything we are missing?

Here is  a simple project to repro this bug.
Here is our solution.

This is Class1

This is the test

To repeoduce the bug, you need to comment line 11 in Class1 first, to make the test pass for once.
Like this.

Then uncomment the line, and run test

You can see this.
The code is below
Class1.cs
using System;
using System.Collections.Generic;
namespace TestLibrary
{
public class Class1
{
public void InfXor(int now)
{
List list = new List(100000);
InfXor(now^1);
}
}
}
UnitTest1.cs
using Microsoft.VisualStudio.TestTools.UnitTesting;
using TestLibrary;
namespace UnitTestProject1
{
[TestClass]
public class UnitTest1
{
[TestMethod]
public void TestMethod1()
{
Class1 class1 = new Class1();
class1.InfXor(1);
}
}
}

@KayMKM
Tests throwing stack overflow exception causes testhost(process executing tests) to crash and thus entire run errors out.
In the image shared by you, tests are showing green because of its last result state. Once you start tests execution, last test result state is updated only when tests are ran successfully. As in your case, stackoverflow causes test run to error out, you are still seeing the previous test result state.
What you are asking for is to not show the old test result state in case of test run error. This UI(called Test explorer UI) is controlled by visual studio IDE team. For improvements/suggestions in test explorer UI, you can raise an issue via Visual Studio's "Send Feedback" option that can be accessed from the Help menu OR using this link https://developercommunity.visualstudio.com
If you want to know which test caused the stackoverflow exception, then you can use blame feature of test platform via running tests in command line. Please check following link for more details.

@KayMKM
Tests throwing stack overflow exception causes testhost(process executing tests) to crash and thus entire run errors out.
In the image shared by you, tests are showing green because of its last result state. Once you start tests execution, last test result state is updated only when tests are ran successfully. As in your case, stackoverflow causes test run to error out, you are still seeing the previous test result state.
What you are asking for is to not show the old test result state in case of test run error. This UI(called Test explorer UI) is controlled by visual studio IDE team. For improvements/suggestions in test explorer UI, you can raise an issue via Visual Studio's "Send Feedback" option that can be accessed from the Help menu OR using this link https://developercommunity.visualstudio.com
If you want to know which test caused the stackoverflow exception, then you can use blame feature of test platform via running tests in command line. Please check following link for more details.

OK. We just raise an issue to Visual Studio IDE team. Thank you for your reply.


angelez/more specific on bib detector dependencies

Confirmed tt verify with -g works with this new setup and config -- going to see if this fixes cuda error on deploy (this is also what i did in extract-stuff-from-pdfs setup.py): https://stackoverflow.com/a/66728637
error:

It's working! 🎉


[Feature Request] App version in UI

Add the app version to the UI under settings.

Available as of 1.0.6


search tweets in viewed profile

Describe the problem
searching for tweets from a specific user is too difficult (impossible?).
Describe the solution
add a search button to the upper right corner in the profile view. this search finds only tweets from the currently viewed user.

This would be incredibly useful if it's possible to add it.

I'll look into this

No, for the average user they will not understand all of the search filters


Ambiguous error messages returned to user when experiencing API connection issues.

It appears the that the python library is returning an ambiguous error message
about decoding the response body, when the actual cause is being unable to
connect to Seven Bridges. Intermittently we are seeing the following error
message:
  File "/Users/mbarton/.venv/lib/python3.7/site-packages/sevenbridges/models/file.py", line 149, in query
    limit=limit, fields='_all', **query_params
  File "/Users/mbarton/.venv/lib/python3.7/site-packages/sevenbridges/meta/resource.py", line 130, in _query
    response = api.get(url=url, params=kwargs)
  File "/Users/mbarton/.venv/lib/python3.7/site-packages/sevenbridges/http/client.py", line 239, in get
    append_base=append_base, stream=stream
  File "/Users/mbarton/.venv/lib/python3.7/site-packages/sevenbridges/decorators.py", line 138, in wrapper
    raise SbgError(message=six.text_type(e))
sevenbridges.errors.SbgError: Expecting value: line 1 column 1 (char 0)

However if you run the code that raises this error in a python debugger the
root cause appears to be something along the lines of trying to decode the
following response body from SBG:
b'\r\n<title>504 Gateway Time-out</title>\r\n\r\n
504 Gateway
Time-out
\r\n
nginx\r\n\r\n\r\n'

This is from the URL: https://api.sbgenomics.com/v2/files?fields=_all&project=...
I think think there are two causes here:

The SBG python library is trying to decode a response body when there is a
non 2XX return code from the API.

The upstream NGINX is API returning HTML pages when experiencing internal
erors.

We looked into this issue and have the suspicion that it might be caused by a request URL that is too long when too many query parameters are provided.
Is this error somehow reproducible for you or is it completely stochastic? Also, can you please provide information what the exact API call was that triggered this error and if it is always the same one?


core: Use Runner enum type instead of string for Job model

What this PR does / why we need it:
This is refactoring aiming to remove a burden on the programmer to get something right.
#575 sought to clear up inconsistencies between uses of Runner#name() (the standard final method of java.lang.Enum that returns the value's enum constant name) and the riskily-named Runner#getName() defined in Feast for human-readable Beam Runner names.
The latter is used as runner name users can set in config (now as Runner#toString since #575). The former is used for values of the runner column of the jobs table in SQL (as it should be). But it relied on careful coding to use the right one when constructing Job instances. This is error prone, as #578 demonstrates.
There is a more robust way: use the enum instead of stringly-typed programming. It's one of the reasons we have enums ☺
This also renames the internal identifier in the Runner definition to humanName, to distinguish it further from Enum#name().
Which issue(s) this PR fixes:
No issue. Relates to #575, #578, brought up in https://github.com/gojek/feast/pull/650#discussion_r415132957
Does this PR introduce a user-facing change?:
NONE

/assign @woop

/test test-end-to-end-batch

/lgtm

/approve


Fix typo in NuGet-4.8-RTM

Fix typo in 'Authentication'

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/release-notes/NuGet-4.8-RTM.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


There seems to be some kind of segfault bug in the SSL library?

The most recent call is in SSL's write, so it's probably a library bug, but it looks like it happened after an error in once, which means we might be able to implement a workaround.
I'm not ruling out this being the fault of my application code, but the location of the the error makes me think that's not it.

Current thread 0x00007f03d1c41f00 (most recent call first):
  File "/usr/lib/python3.5/ssl.py", line 586 in write
  File "/usr/lib/python3.5/ssl.py", line 861 in send
  File "/usr/lib/python3.5/ssl.py", line 891 in sendall
  File "/home/danny/Projects/KaithemAutomation/kaithem/src/thirdparty/ws4py/websocket.py", line
269 in _write
  File "/home/danny/Projects/KaithemAutomation/kaithem/src/thirdparty/ws4py/websocket.py", line
287 in send
  File "/home/danny/Projects/KaithemAutomation/kaithem/src/widgets.py", line 76 in f
  File "/home/danny/Projects/KaithemAutomation/kaithem/src/widgets.py", line 266 in send
  File "Event_l___init__", line 117 in pushTracks
  File "Event_l___init__", line 9 in _event_action
  File "/home/danny/Projects/KaithemAutomation/kaithem/src/newevt.py", line 557 in _do_action
  File "/home/danny/Projects/KaithemAutomation/kaithem/src/newevt.py", line 422 in _on_trigger
  File "/home/dannyERROR:2017Jun26 21:35:27 PDT ws4py Failed to receive data
  Traceback (most recent call last):   File "/home/danny/Projects/Kait
  hemAutomation/kaithem/src/thirdparty/ws4py/websocket.py", line 331,
  in once     x = self.sock.recv(4096)   File
  "/usr/lib/python3.5/ssl.py", line 914, in recv     return
  self.read(buflen)   File "/usr/lib/python3.5/ssl.py", line 791, in
  read     return self._sslobj.read(len, buffer)   File
  "/usr/lib/python3.5/ssl.py", line 577, in read     v =
  self._sslobj.read(len) ssl.SSLError: [SSL: SSLV3_ALERT_BAD_RECORD_MAC] sslv3 alert bad record mac (_ssl.c:1977)/Pro
jects/KaithemAutomation/kaithem/src/newevt.py", line 940 in _check
  File "/home/danny/Projects/KaithemAutomation/kaithem/src/newevt.py", line 514 in check
  File "/home/danny/Projects/KaithemAutomation/kaithem/src/newevt.py", line 858 in f
  File "/usr/lib/python3.5/threading.py", line 862 in run
  File "kaithem/kaithem.py", line 159 in run_with_except_hook
  File "/usr/lib/python3.5/threading.py", line 914 in _bootstrap_inner
  File "/usr/lib/python3.5/threading.py", line 882 in _bootstrap

Update: looks like it doesn't always follow an error in once()
Current thread 0x00007f83a80e8f00 (most recent call first):
  File "/usr/lib/python3.5/ssl.py", line 586 in write
  File "/usr/lib/python3.5/ssl.py", line 861 in send
  File "/usr/lib/python3.5/ssl.py", line 891 in sendall
  File "/home/danny/Projects/KaithemAutomation/kaithem/src/thirdparty/ws4py/websocket.py", line
269 in _write
  File "/home/danny/Projects/KaithemAutomation/kaithem/src/thirdparty/ws4py/websocket.py", line
287 in send
  File "/home/danny/Projects/KaithemAutomation/kaithem/src/widgets.py", line 76 in f
  File "/home/danny/Projects/KaithemAutomation/kaithem/src/widgets.py", line 266 in send
  File "Event_l___init__", line 117 in pushTracks
  File "Event_l___init__", line 9 in _event_action
  File "/home/danny/Projects/KaithemAutomation/kaithem/src/newevt.py", line 557 in _do_action
  File "/home/danny/Projects/KaithemAutomation/kaithem/src/newevt.py", line 422 in _on_trigger
  File "/home/danny/Projects/KaithemAutomation/kaithem/src/newevt.py", line 940 in _check
  File "/home/danny/Projects/KaithemAutomation/kaithem/src/newevt.py", line 514 in check
  File "/home/danny/Projects/KaithemAutomation/kaithem/src/newevt.py", line 858 in f
  File "/usr/lib/python3.5/threading.py", line 862 in run
  File "kaithem/kaithem.py", line 159 in run_with_except_hook
  File "/usr/lib/python3.5/threading.py", line 914 in _bootstrap_inner
  File "/usr/lib/python3.5/threading.py", line 882 in _bootstrap


[Settings > Color Picker] strange effect Toggle Switches when moving items

Microsoft PowerToys version
0.37
Running as admin

[ ] Yes

Area(s) with issue?
ColorPicker, Settings
Steps to reproduce
Open the Settings -> Color Picker,
Click the Up and Down arrows on the right side of the items in the list.
✔ Expected Behavior
Smooth re-positioning.
❌ Actual Behavior
Items get new position, but there's a short effect on on of the Toggle Switches from a different item.
https://user-images.githubusercontent.com/65828559/116932330-65d28500-ac62-11eb-8d85-8c6fb91517f2.mp4
Other Software
No response

@niels9001
I saw the same behavior yesterday on the first three and last three items. Though it is a xaml bug. Is it?

Though it is a xaml bug. Is it?

I've seen that argument used before - also by you, but usually it's a result of shady coding. Really.
Example: https://github.com/microsoft/PowerToys/issues/10598#issuecomment-813620263

Though it is a xaml bug. Is it?

I've seen that argument used before - also by you, but usually it's a result of shady coding. Really.
Example: https://github.com/microsoft/PowerToys/issues/10598#issuecomment-813620263

@Jay-o-Way
In the referenced issue it's a default behavior of the control. But gere it can be a bug.
I don't say by general thatvevery quirky behavior is a xaml bug. But here my intention was that it isn't on every item. 🤔

@Jay-o-Way Let's keep feedback constructive!
Most of the visual glitches are related to XAML Islands - either due to a bug, or a non-optimized way of coding around a bug or limitation. WinUI 3 support for unpackaged apps will hopefully get rid of most of these bugs, and will make the implementation easier.
That said - in this case, it seems that the list gets reloaded everytime the order gets changed. As a result, the default ToggleSwitch animation kicks in and I think that's what we see here. Once we  move to WinUI 3, we can (hopefully) go back to the previous solution (drag to re-order) solving all of the issues in one go. As it's a minor visual glitch (not resulting in a crash or blocking a setting), I'd wait for WinUI 3 to resolve it and not spend time on it now to get it fixed.

Let's keep feedback constructive!

I just wanted to say it's easy and unfair to say "must be XAML" when it might as well be a result of unnecessary or "creative" code.

it seems that the list gets reloaded everytime the order gets changed. As a result, the default ToggleSwitch animation kicks in and I think that's what we see here.

Then why does it only apply to one other item and not all of them?

Let's keep feedback constructive!

I just wanted to say it's easy and unfair to say "must be XAML" when it might as well be a result of unnecessary or "creative" code.

I only want to mention that I wrote "Is it?". This means I asked if my idea can be correct. - So, I don't say in general it must be a xaml bug.

it seems that the list gets reloaded everytime the order gets changed. As a result, the default ToggleSwitch animation kicks in and I think that's what we see here.

Then why does it only apply to one other item and not all of them?

Strange things happen sometimes.
And we can think the other way too: Why should we create different code for updating some of the listview items?

I'm thinking it's because the whole list is re-built every single time.
        private void UpdateColorFormats()
        {
            _colorPickerSettings.Properties.VisibleColorFormats.Clear();
            foreach (var colorFormat in ColorFormats)
            {
                _colorPickerSettings.Properties.VisibleColorFormats.Add(colorFormat.Name, colorFormat.IsShown);
            }
        }

Can't we just move items, by giving them a new index?

@jay-o-way I looked at this a bit more, and I think this is expected behavior. This is what happens if I'm correct: if the status of the item that gets moved is different than the new index, the ToggleSwitch animations shows. (You can see that this doesn't happen if you e.g. turn all formats on and start moving items around.). That means that the item template doesn't get re-rendered, just new data that gets bind to it. If the status is now different, the ToggleSwitch.IsOn property gets updated - and its animation will be shown. Only way to fix it is to remove the animation from the ToggleSwitch visual style.
Therefore.. you could conclude that it's expected behavior. I agree it's not perfect, but also not a huge issue. Once we move to WinUI3 we can hopefully go back to using the drag-to-reorder functionality that doesn't have this visual "glitch". IMO we can mark this issue as "Won't fix" and close it. But let me know what you think.

The different status of Toggle Switches inside of list items should not affect each other, if the entire list item is moved and no more actions are performed in the background. Again: it also affects list items that are not related to the actually moved items by index number. In a rare occation I even spotted a tiny animation (maybe a millisecond or so) on (the text of) one or two list items - which tells me something is acting on (or regenerating) the entire list every single time.
I did some more looking and in some occasions it seems that (at least on my Surface Pro 4) it envolves either exactly one or two pairs of switches that are both "on" and "off" - for every permutation. It is too specific for me to be a general result of controls. I'm still diggin tho. Right now I'm suspecting functions like OnPropertyChanged, UpdateColorFormats or ScheduleSavingOfSettings getting frequently called and "interacting", but I'm still guessing on that.
Maybe @SeraphimaZ might have an idea? She worked on this before?

Now that we're going for WinUI3, will the drag-to-reorder property be enabled again?

if you want to give it a shot, sure.  We're heads down on new stuff right now / fixing bugs

Duplicate of #19080


updated link, content, and added annotation

updated link and text
added annotation

@DaisyShi19 could you review my version and if it looks good, could you approve merge?

Is the acknowledgement you want from the main branch? didn't realize it's modified.

could you approve Merge pull request?  I want you to start approving Merging. :)

could you approve Merge pull request? I want you to start approving Merging. :)

Yes, how do I approve?

in RED, you should see merge pull request. just check merge without wiating for requirements


Request feature, How about supporting movie sites?

I'm so thankful to the developer for making this open source and free, Back then, i really want to make a program that does the same . I'm amaze how you do it in anime websites (Sweet, Thank you so much for making my life easy). After a couple of research and studying of how this work. I got an idea how does m3u8 works, but due to lack of resources, I am still lacking in knowledge of how to extract data from movie websites like fmovies, 123movies, etc. That's why i would like you guys to make another script that does the same. I can't find a similar repo that does the same in movies. So, I hope you consider.

Hi there! Actually I have a m3u8 downloading script which I have coded back then (I didn't put it in a repo though). I might upload the code in a separate repository for that


Add a generic volume mounting system.

This is a simple generic volume mounting system.
The real target is to also allow mounting ssget matrices from a filesystem,
but it can be used for other purposes as well. It relies on environment
variables for configuration:

VOL_NUM, the number of volumes which are configured
VOL_1_SRC, the source of the first volume (on the cluster)
VOL_1_DST, the destination of the first volume (in the container).

See README for details.
This was already tested on HoreKa and produces the correct output, see:
https://gitlab.com/ginkgo-project/ginkgo-public-ci/-/jobs/1857845766

VOLUMES configuration:
--mount /hkfs/work/workspace/scratch/scc-fineci-0001-continuous-integration/ccache:/ccache
--mount /hkfs/work/workspace/scratch/scc-fineci-0001-continuous-integration/ssget:/ssget

That should be possible all the same. The variables taken by the script are of the form CUSTOM_ENV_...., AFAIK this is automatically populated by the environment variables specified either in the runner configuration or in the job's variables, the output is the same. What I'm not sure about is if the runner configuration's variables can be overwritten by the job's.


Remove Comments

Is there any way to not generate the comments?
/// Assets for imagesAbout
/// assets/images/about.png

update v0.1.6
  flutter_assets:
    assets_path: assets/
    output_path: lib/constants/
    filename: assets.dart
    field_prefix: resource
    ignore_comment: true

Thank you for your great work.
ignore_comments not ignore_comment
please update the readme.md file.


Cannot logout within the same app session

In my app, when user logout the app, I need to clear out the previously authorized Pinterest session.
I found this method on PDKClient class:
/**
 *  Removes the saved oauth token for the currently authorized user.
 */
+ (void)clearAuthorizedUser;

However this method doesn't set the authorized property of the [PDKClient sharedInstance] to FALSE, thus [[PDKClient sharedInstance] authorized] still returns TRUE.

+1.. Any Solution?

+1.. Any Solution?


how can i use the brave-spancollector-scribe api right to send span to the zipkin

hey, i want to use brave-spancollector-scribe send span to the zipkin server , but the zipkin web ui not display the trace,it's my code wrong?please give some demo .
very very thanks > <.......

final ScribeSpanCollector scribeSpanCollector = new ScribeSpanCollector(HOST, PORT);

Annotation sr = Annotation.create(System.currentTimeMillis(), Constants.SERVER_RECV, null);
sleep(1);
Annotation cs = Annotation.create(System.currentTimeMillis(), Constants.CLIENT_SEND, null);
sleep(1);
Annotation cr = Annotation.create(System.currentTimeMillis(), Constants.CLIENT_RECV, null);
sleep(1);
Annotation ss = Annotation.create(System.currentTimeMillis(), Constants.SERVER_SEND,
        Endpoint.create("testService", ((10 << 24) | (2 << 16) | (129 << 8) | 232), 8000));

Span span = new Span()
        .setTrace_id(111)
        .setParent_id(null)
        .setId(10)
        .setName(SPAN_NAME)
        .setAnnotations(Lists.newArrayList(sr,cs,cr,ss));

scribeSpanCollector.collect(span);

sleep(10);

@whx4J8 At first sight the code looks correct. Can you try to call scribeSpanCollector.close()? This should flush remaining spans and also do some logging on how many spans were submitted.

oh very thanks,I also find some demo in brave. thank you very much


Update InputDecorator et al

Updates the appearance of InputDecorator which updates the appearance of most TextFields.

InputDecorator "container"
In the descriptions of the new input decorator's features that follow the term 'container' is often used to refer to the areas highlighted in the screenshots below:

New Features
This version of InputDecorator is largely API compatible with the current one. Some new visual elements have been added and the internal layout has changed a bit.

The prefixIcon and suffixIcon appear at the leading or trailing edge of the input. Unlike the icon, they appear within the decorator's container.
In the screenshot below the suffixIcon appears on the right (because the prevailing text direction is LTR):

This screenshot shows an input decorator with icon and contentPadding that eliminates the default horizontal 12dps padding with the decorator's container.

The container part of the decorator can be filled with filled: true and the color can be specified with fillColor: color.

What was called the "divider" is now a configurable border. Specifying borderType: InputBorderType.outline draw's an outline around the decorator's container, borderType: InputBorderType.underline underlines the input as before, and borderType: InputBorderType.none doesn't draw anything (same as hideDivider: true in the previous version).

When the decorator is outlined, the floating label animates into a gap in the border.
The screenshots below show the decorator's label when the text field lacks the focus, and the floating label when it gains the focus.

When the errorText first appears it "shakes" left and right to get the user's attention.

The default padding of the decorator's content can be overridden with contentPadding: edgeInsets. For example to generate a layout that's similar to the current Input decorator: contentPadding: const EdgeInsets.only(bottom: 8.0, top: 16.0).

Incompatible Changes

The hideDivider property has been replaced by boderType: InputBorderType.none.
The layout of the InputDecorator's elements has changed. The "inline" elements, like the input child, the labelText and hintText, are now padded 12 dps on the left and right. The vertical padding is also different: previously there was 16dps above the floating label, and 8dps below the inline elements, now its 12dps above and below.
The labelText's location is a little different. It's vertically centered within the input decorator's container when isFocus is true or isEmpty is false. When the labelText is "floating"
it appears within a gap within the InputBorderType.outline or just a little lower than before for InputBorderType.underline.

My main feedback is that instead of an enum for the borderType, I would just define an abstract subclass of ShapeBorder (similar to what you have), and then have people provide instances of subclasses of that subclass as the borderType (call it just shape, probably, to match what @amirh is doing). That way you get two benefits: one, your shape border class gets split into two simpler ones since now each one only has to deal with one border style, and two, people get to build their own crazy border styles if they want to.

Those outline animations are beautiful!


Rename use of --format in ruff rule to --output-format

As with #7354, we should probably rename ruff rule --format ... to ruff rule --output-format ... for clarity.
The old option should be deprecated then removed later.

I got bitten by this when upgrading ruff as well.

Yes... This broke my Github Action that uses ruff. I guessed something like this could be the reason, but it wasn't obvious to me from the ruff documentation that --format is now --output-format


SLSA v1.0 verification support for npm packages built by the "Trusted Builder"

Verification support for the "Trusted Builder" as defined in RFC-0049

To get the ball rolling, here's are possible options to our CLI arguments:
Option 1
slsa-verifier verify-npm <tarball> [--package-name <package-name>]

Will we ever need to support npm "things" that are not tarballs?
Option 2
slsa-verifier verify-package <tarball>  --ecosystem npm [--package-name <package-name>]

The ecosystem may mirror the ones OSV uses.
Option 3
slsa-verifier verify-npm-package <tarball>  [--package-name <package-name>]

/cc @mihaimaruseac @ianlewis @asraa @joshuagl

I'm leaning towards option 2 as that simplifies the help interface, fewer commands that just redirect to the proper implementation.

I'm leaning towards option 2 as that simplifies the help interface, fewer commands that just redirect to the proper implementation.

That is unless we need to have ecosystem specific options in the future for some reason but I can potentially foresee some verification options that we'll want for some ecosystems but not others.

+1 on what @ianlewis said. I'm also worried about such options. I'm leaning towards option 3 to have namespaces. Option 1 seems OK-ish, but I'm worried that in the future we will end up adding a verify-npm-installation that could iterate over all the deps in the manifest.
I think we should be explicit with command names rather than trying to be generic.

I played a bit with the provenance generated by the runner for npm in https://github.com/laurentsimon/provenance-npm-test/blob/main/download-verify.sh
Looks like we'd have at 2 options:

# 1. Both attestation (publish and slsa attestations in a single file, probably the common case)
slsa-verifier verify-npm-package "$tarball_url" \
    --attestations-path "$attestations_url" \
    --source-uri github.com/repo/name \
    --package-name "$package_name"

# 2. Attestation in a separate file
slsa-verifier verify-npm-package "$tarball_url" \
    --provenance-path "$provenance_attestation_file" \
    --publish-attestation-path "$publish_attestation_file" \
    --source-uri github.com/repo/name \
    --package-name "$package_name"

# 3. From URL - this requires more thinking because the provenance may be private and require login to access, ie it may need to shell out to npm CLI
slsa-verifier download-npm-package "$package_name" \
    --source-uri github.com/repo/name \
    --tarball-path "$tarball_file" # NOTE: we could let users pipe the result wherever they want instead of having the tarball-path option

Starting with command 1 would make sense, I think. Thoughts?

--attestations-path "$attestations_url"

Is this a url that we'll download from? Or maybe a path to a directory of attestations (sigstore bundles)? If it's a directory then I assume we'll check all for matching subjects?
Can you provide what you expect the full set of commands to be? i.e. how will folks download the tarball and attestations? Do they need to parse the attestation urls out of the API and download them manually? Can we maybe do a lot of this work for them?

sorry, the attestations_url  was from a script and should have been a attestations_path. I sent this https://github.com/slsa-framework/slsa-verifier/pull/495. Support for:

--package-version
--package-name
--attestation-path : contains the path to a file containing both attestations npm view @laurentsimon/provenance-npm-test --json | jq -r '.dist.attestations.url'

Ok, so we need them to do something like
$ curl -o provenance.json $(npm view @laurentsimon/provenance-npm-test --json | jq -r '.dist.attestations.url')
$ slsa-verifier verify-npm-package laurentsimon-provenance-npm-test.tgz \
      --attestation-path provenance.json \
      --source-uri github.com/laurentsimon/provenance-npm-test \
      --package-name @laurentsimon/provenance-npm-test
      # version tag? etc

That's what I proposed, but up for discussion. Note that there are 2 attestations returned by npm view (the publish and the provenance attestation)

Right. I'd like to make it easier on users and have the verifier download the package tgz and attestations itself and output them somewhere if they verify but maybe it's simpler if users download it themselves.
Currently you can download a package tarball with npm pack but I guess there isn't a way to download the provenance and output it to a file without curl + npm view --json? Maybe we can request a feature like that to make it easier for users to verify with slsa-verifier?
Something like:
$ npm pack --with-attestations<EMAIL_ADDRESS>...
laurentsimon-provenance-npm-test-1.0.0.tgz
laurentsimon-provenance-npm-test-1.0.0.attestations.json

Users may want to explicitly verify the package name so I added it. I'm not sure what you mean by "taken" from the package.json. I know it's in the manifest, but we won't unpack the tarball ourselves. Or do you mean that if users care they can unpack the tarball and see for themselves?
NOTE: to prevent downgrade attacks, I also added a --package-version option.

Yeah, I was wondering why we wouldn't just unpack it and look at the manifest. Why would the option that the user supplies ever be different from that value? Is unpacking it problematic?
I kind of feel like the value we should really be checking is the expected git ref/tag. Maybe rewording the option would make that clearer?
So I think we can check two things:

The --source-version flag should verify the git tag/ref that was used (this could be different from the package version).
The version in the package manifest matches the package version in the provenance subject

Yeah, I was wondering why we wouldn't just unpack it and look at the manifest. Why would the option that the user supplies ever be different from that value? Is unpacking it problematic?

Thinking about it again, the tarball is untrusted and the subject should be treated the same way. I do think we should check the manifest contains the right package name though since that's the name under which the package actually gets installed. You don't want the tarball to overwrite an already installed package for example.

Good call. I think I took the view that the publish attestation guarantees that already (the registry verifies it at provenance / package upload).

Good call. I think I took the view that the publish attestation guarantees that already (the registry verifies it at provenance / package upload).

Yeah, I suppose it's a question for the verifier whether we trust the publish attestation though I'm not totally sure of the guarantees it provides. My understanding was that it attests to when and by whom the package was published, but I'm not sure what else it might guarantee. Not sure if there is any info anywhere.
Maybe we can create an issue in the private beta repo?

From its content, the publish attestation only attests to the package name and version:
{
  "_type": "https://in-toto.io/Statement/v0.1",
  "subject": [
    {
      "name"<EMAIL_ADDRESS>      "digest": {
        "sha512": "29d19f26233f4441328412b34fd73ed104ecfef62f14097890cccf7455b521b65c5acff851849faa85c85395aa22d401436f01f3afb61b19c780e906c88c7f20"
      }
    }
  ],
  "predicateType": "https://github.com/npm/attestation/tree/main/specs/publish/v0.1",
  "predicate": {
    "name": "@laurentsimon/provenance-npm-test",
    "version": "1.0.0",
    "registry": "https://registry.npmjs.org"
  }
}

If we verify this publish attestation, we implicitly what it attests to. I fully agreed that the verification it does needs to be documented.

My understanding was that it attests to when and by whom the package was published, but I'm not sure what else it might guarantee.

Right, I think the implicit assumption is "verified that the registry attests to the publication of the package" -- just in case, let's say, the registry store was compromised. I don't think there's any other implicit assumption. +1 on posting whether it implicitly verifies the build attestation.

--attestations-path

I would assume the benefit of having this be an ecosystem specific command is so that we fetch the attestation already, knowing the ecosystem stores it? Otherwise, could we not achieve the same benefit (for the trusted builders) by some shell scripting and the existing verify-artifact cmd?

initial implementation in #495


[feature request] Support passing through arguments

When I define a command like so:
ipfs = "${pkgs.kubo}/bin/ipfs";

command_menu = command-utils.commands.${system} {
  ipfs-daemon = cmd "Start the IPFS (kubo) daemon"
    "${ipfs} --repo-dir ./.ipfs --offline daemon";
};

It would be nice if I could run ipfs-daemon --help and get help text (or set flags, etc.).

👀


Tables don't render on iOS mobile app

Submit feature requests to http://www.mattermost.org/feature-requests/. File non-security related bugs here in the following format:
Summary
Tables in chat messages seem to be rendered as ASCII in the iOS app.
Environment Information

Device Name: iPhone SE 2020
OS Version: iOS 13.5.1
Mattermost App Version: 13.33.1 (Build 311)
Mattermost Server Version: 5.24.0 (Build 5.24.2) Enterprise trial

Steps to reproduce

create a slash command that posts a table according to the example at https://docs.mattermost.com/developer/slash-commands.html
Observe behavior in webapp and desktop app (correct)
Observe behavior in iOS app (renders as plain text)

Expected behavior
I used the weather example from the mattermost slash command introduction https://docs.mattermost.com/developer/slash-commands.html to write my own slash command. The table which is emitted by the command is rendered just fine in the desktop and webapp, but it renders as ASCII in the iOS version of the app.
I would expect the table to be consistently rendered as rich text across all apps.
Observed behavior
Renders as plain text, see screenshots.

Possible fixes
If you can, link to the line of code that might be responsible for the problem.

According to feedback by a colleague, the table is plain ASCII in the current version of the Playstore Android app as well.

Sorry, that shouldn't have been closed.

@absynth47215 is working for me, maybe check your table formatting

When I copy&paste the unformatted table into a chat message, it renders fine. However when my mattermost integration posts it, it doesn't render on iOS/Android.
I will check for extra whitespace or something - maybe the desktop app has a more forgiving parser than the mobile app.

@enahum The table rows had extra whitespace at the beginning. The desktop parser seems to tolerate this but the mobile client does not.
I'll close this here but in my opinion, it's at least worth taking a look at in the long run. Thanks!

Yes, indeed the parser for the desktop/web is different than the one used in the mobile app.
@hmhealey do you know why is more forgiving the one used in the webapp?

The webapp is using a much older Markdown parser from before Markdown was properly standardized as CommonMark, so it had to be looser with the rules because of that. That said, we usually reference GitHub's version of CommonMark, and they seem to support whitespace before tables, so the mobile app may still be incorrect here.
Like
  | asdf | foo|
  | -- | -- |
  | aa| bb|

renders as

asdf
foo

aa
bb

so I'd expect the mobile app to also be able to render that.
@absynth47215 Are you able to provide the plain text for one of the tables that wasn't working in the mobile app?


Add config to disable file system logging

The current Logger logs to disk with no option to disable it. This makes it unable to run in serverless environments like AWS lambda, which do not provide a filesystem out of the box, but transport logs by network mechanisms.

Hi @MichaelHindley! Sorry for the delay on this one - this is a good call out, we'll add it to the backlog.

@MichaelHindley I ran into this tonight ... I was attempting to run as a lambda and could not mkdir 'logs' because it's read-only.  I am using the lookup table feature.
Here's a trick that worked for me.  It's not the best solution (sinon is meant for unit testing afterall) ... but if you need something now it might help.
import { Logger, LookupTableInput } from '@cloud-carbon-footprint/common'
import sinon from 'sinon'

const getAwsEstimates = async (awsInput: LookupTableInput[]) => {
    sinon.stub(Logger.prototype, 'error').returns()
    sinon.stub(Logger.prototype, 'warn').returns()
    sinon.stub(Logger.prototype, 'info').returns()
    sinon.stub(Logger.prototype, 'debug').returns()
    // now call cloud-carbon-footprint classes
    return new App().getAwsEstimatesFromInputData(awsInput)
}

Hi all,
We've discussed and came up with a possible solution:
If you change the LOGGING_MODE to GCP, then that will log into the console and not a file.
Hope this helps!


[BUG]client [NewClient] Error: CRYPTO_ERROR (0x178): tls: no application protoco

Summary (概要)
When I run this example, I want to do y3 encoding.There are some problems with the operation.It worked fine when I coded the example in JSON.

https://github.com/yomorun/yomo-source-example/blob/main/main.go

Steps To Reproduce (复现的步骤)
I think there might be some error in the execution of this statement.But i don't know how to fix it.Can you give me some advices.thanks a lot.

cli, err := client.NewSource("yomo-source").Connect(host, port)

Additional Details & Logs (附加的信息和日志)

github.com/yomorun/yomo v1.2.520 // indirect
Yomo version (版本)  YoMo CLI version: v0.1.3
Yomo error logs (错误日志) client [NewClient] Error: CRYPTO_ERROR (0x178): tls: no application protoco
Yomo configuration (配置)
Operating system (操作系统) windows

Hi @buliangc ,
Thanks for your feedback.
The example yomo-source-example was based on the old YoMo version v1.2.520, which is incompatible with the YoMo CLI v0.1.3.
We just upgraded the yomo-source-example, you can check out the new codes and try again.
About Y3 encoding, we are using it in the core of YoMo (f.e. frame).
But for yomo-source and yomo-streaming-function, we recommend using JSON instead of Y3 in YoMo v1.5.

@xiaojian-hong Thank you for helping me with my confusion!
There's one more question I'd like to ask.When i run this example-noise .
I run Docker-compose directly from the tutorial.

But something went wrong.I cheak the docker-compose log.I find noise-emitter noise-source noise-zippercan work.But noise-flow and noise-sink got something wrong. noise-flow didn't work at first .So i changed the noise-flow startup command in Docker-compose because the original command is no longer available in the new version.But there will still be mistakes.

I guess the version is not compatible, so there is a problem. I'm really sorry to trouble you ,Can you check this example,Thanks a lot!
Additional Details & Logs (附加的信息和日志)

Yomo version (版本)  YoMo CLI version: v0.1.3
Yomo error logs (错误日志)
Yomo configuration (配置)
Operating system (操作系统) Ubuntu16.04 docker

@buliangc we just fixed the docker images, you could try the following steps to re-run the example.

Go to the local directory which docker-compose.yaml locates in.
Stop and remove the running services.

sudo docker-compose stop
sudo docker-compose rm -f

Update the docker-compose.yaml in your local.
Re-create the services.

sudo docker-compose up -d

feel free to let me know if you have any troubles when using YoMo. :)

@xiaojian-hong Thank you very much!!! I've tried it and it worked!

I hope you can update all the codes of this case, so that I can further learn YoMo.Thanks a lot. :)

@xiaojian-hong Thank you very much!!! I've tried it and it worked!
I hope you can update all the codes of this case, so that I can further learn YoMo.Thanks a lot. :)

@buliangc great!
Okay, we will plan to update the codes of our examples to the latest version.


Ensure timestamps are not blank strings

Fixes #292.
@rentzso here is the fix you requested - the date-time format does not allow blank strings so in-code checks are unnecessary. This is also not a breaking change to any of our frontend logic.

This and #301 have conflicting database upgrades. Whichever merges second will need a rebase.

LGTM pending a quick question.
Presumably this will be easy to land soon; go ahead & claim v9, I will take v10 :laughing:

@nagem
as from @ryansanford comment https://github.com/flywheel-io/flywheel/pull/195#issuecomment-219788965, we should include a cleanup script for the DB in bin/database.py:
db.acquisitions.update_many({'timestamp':''}, {'$unset': {'timestamp': ''}})
db.sessions.update_many({'timestamp':''}, {'$unset': {'timestamp': ''}})

Retested, merging in 15 mins.


[Codacy Cleanup]: GITHUB ISSUE-Possible SCM diff in code (diff) 2

Codacy detected an issue:
Message: Possible SCM diff in code (diff)
Currently on:

Commit:  a2bee64889e665bb16194c817ebef0a34f0aae02
File:    metrics/mk_community_partnership_report.py
LineNum: 51

For the convenience of the Seagate development team, this issue has been mirrored in a private Seagate Jira Server: https://jts.seagate.com/browse/CORTX-32544. Note that community members will not be able to access that Jira server but that is not a problem since all activity in that Jira mirror will be copied into this GitHub issue.

Mukul Malhotra commented in Jira Server:

Raised PR#1591 to fix the code

Mukul Malhotra commented in Jira Server:

.

Mukul Malhotra commented in Jira Server:

.


Hotfix: mirrored docker.prod to docker.dev

It was not possible to log in with the current dev build, this fixes that problem.
We can probably trim down on some of the labels and variables, as I simply copied things over, not knowing what things do.

It works without the fix.

So, for posterity, here is the actual fix:
Go to your dev-tools in the browser and disable caching for localhost, and do a hard reload of the page.


Training Regression Algorithm with different Number of Features resolves in broken Model

Describe the bug
This bug is similar to #292, but the other way around and only for regression algorithms and not for classification. If I train the same training object with a different number of features and assign the model to a new prediction object, the prediction will throw an exception. Using resetCompute() does not prevent the exception. My guess is that the model is not reset properly and assumes the numbers of features of the initial training.
I could observe the same problem for the following regression algorithms (but I did not check others):

Gradient Boosted Trees
Decision Forest
Decision Tree
Linear Regression

To Reproduce
#include <daal.h>

int main() {
    /* creating arrays for shallow data access */
    float vData[6] = { 0, 0, 0, 1, 1, 0 };
    float vLabels[6] = { 0, 1, 1, 0, 1 };

    using namespace daal::data_management;
    using namespace daal::algorithms::decision_forest::regression;

    /* Create an algorithm object to train the decision forest classification model */

    /* Build the model for every feature  set */
    for (size_t i = 1; i < 4; i++) {
        training::Batch<> vTrainingBatch;

        std::cout << "### " << i << " Features ###" << std::endl;

        NumericTablePtr vTrainData(HomogenNumericTable<>::create(vData, i, 6 / i));
        NumericTablePtr vTrainGroundTruth(HomogenNumericTable<>::create(vLabels, 1, 6 / i));
        vTrainingBatch.input.set(training::data, vTrainData);
        vTrainingBatch.input.set(training::dependentVariable, vTrainGroundTruth);

        std::cout << "Training is valid: " << vTrainingBatch.checkComputeParams() << std::endl;
        vTrainingBatch.compute();

        prediction::Batch<> vPredictorBatch;
        /* Pass a testing data set and the trained model to the algorithm */
        vPredictorBatch.input.set(prediction::model, vTrainingBatch.getResult()->get(training::model));
        vPredictorBatch.input.set(prediction::data, vTrainData);

        std::cout << "Prediction is valid: " << vPredictorBatch.checkComputeParams() << std::endl;

        vPredictorBatch.compute();
    }

    /* Build the model once and train with different feature sets*/
    std::cout << "#### Reuse the same object ####" << std::endl;
    training::Batch<> vTrainingBatch;
    for (size_t i = 1; i < 4; i++) {

        std::cout << "### " << i << " Features ###" << std::endl;

        NumericTablePtr vTrainData(HomogenNumericTable<>::create(vData, i, 6 / i));
        NumericTablePtr vTrainGroundTruth(HomogenNumericTable<>::create(vLabels, 1, 6 / i));
        vTrainingBatch.input.set(training::data, vTrainData);
        vTrainingBatch.input.set(training::dependentVariable, vTrainGroundTruth);
        // resetCompute has no effect. The model is still broken.
        vTrainingBatch.resetCompute();

        std::cout << "Training is valid: " << vTrainingBatch.checkComputeParams() << std::endl;
        vTrainingBatch.compute();

        prediction::Batch<> vPredictorBatch;
        /* Pass a testing data set and the trained model to the algorithm */
        vPredictorBatch.input.set(prediction::model, vTrainingBatch.getResult()->get(training::model));
        vPredictorBatch.input.set(prediction::data, vTrainData);

        std::cout << "Prediction is valid: " << vPredictorBatch.checkComputeParams() << std::endl;

        vPredictorBatch.compute();
    }
}

Expected behavior
I would expect both loops to run successful.
Output/Screenshots
### 1 Features ###
Training is valid: 1
Prediction is valid: 1
### 2 Features ###
Training is valid: 1
Prediction is valid: 1
### 3 Features ###
Training is valid: 1
Prediction is valid: 1
#### Reuse the same object ####
### 1 Features ###
Training is valid: 1
Prediction is valid: 1
### 2 Features ###
Training is valid: 1
Prediction is valid: 0
terminate called after throwing an instance of 'daal::services::interface1::Exception'
  what():  Number of columns in numeric table is incorrect
Details:
Argument name: data

Environment:

OS: [Ubuntu 18.04]
Compiler: [GCC7.4]
Version: [2019 Update 5]

Hello, @Mightrider
Thanks for reporting the issue.
I already started to deal with this.

Hello @PivovarA,
thank you for your quick responses and I am glad to help!

Hello @Mightrider
Indeed, using resetCompute in this case leads to a similar result.
In your case, you need to use resetResult instead of resetCompute: resetResult will reallocate result, which will override the number of features. In this case, all regression algorithms will work correctly.

Hello @Mightrider
Did the method that I provided above help?
Do you have any further questions on this issue?

Hello @PivovarA, I only had DAAL 2019 available and I think back then resetCompute was not available, at least for the regression methods I tried it with. Anyway after switching to DAAL 2020 it works as expected!
Thank you very much for your support!
You can close the issue if you want.


Unwanted logout when closing the app

Steps to reproduce
User is logged out and asked to log in again, after closing and opening the app. Circles-android f-droid versions v1.0.33 and v1.0.34. Swiping the app out of the recent apps list is enough to trigger it.
Expected behaviour: should still be logged in after closing and re-owning the app.
Additional info
None
Application version
1.0.34
App Store name
F-Droid
Phone model
OnePlus 6
Operating system version
Murena e-os 2.3-t based on Android 13
Homeserver
my own, running Synapse
Contact info
@julian:foad.me.uk

same, 1.0.34, FP4 running LOS21 with microg installed manually (nimicrog) and matrix.org home server
Just to confirm the issue is more common and not just an unique case

Same Here (Android 13, ZTE)


Fixed get_css_position filter breaking when there is no image

@stefanfoulis is the image was removed from filer but there is still a plugin that references it which template uses this filter. Any value would make sense as long as it is not AttributeError


[DSIP-64] Add more workflow Integration test cases in master.

Search before asking

[X] I had searched in the DSIP and found no similar DSIP.

Motivation
After https://github.com/apache/dolphinscheduler/issues/16423, we can easily add integration case for master.
Some cases are already added at #16423, but the workflow might have many structure, and some task might influence the workflow runtime graph, so we need to add more cases.

Switch task case
Sub workflow task case
Condition task case
More failover case
More workflow operation case
Master event bus benchmark

Design Detail
No response
Compatibility, Deprecation, and Migration Plan
No response
Test Plan
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@ruanwenjun I am interest to work on this issue.

@ruanwenjun I am interest to work on this issue.

Great, you can submit a PR to try, and you can find some example code under master/test


March Support: Auto Test, log evaluation and opening issues - Palmetto

                                    Palmetto CT

Date
Build
CU
CT-PASS
CT-FAIL
New Defects Logged

1st Mar
v1.99.1-65-g07df806
OK
170
8
openbmc/openbmc#1052,

Current Blocking OpenBMC Issues

No.
Github#
Reason/Heading
Current Status

1

https://github.com/openbmc/openbmc-test-automation/issues/377 - It is already there. So closing it.


Implement API and data job for last 30 days of PyPI installs

Relates to: https://github.com/chanzuckerberg/napari-hub/issues/709
Happy path - Valid plugin name:
https://6vwmwypt38.execute-api.us-west-2.amazonaws.com/dev-recent-stats/activity/affinder/recent_stats
Invalid plugin name:
https://6vwmwypt38.execute-api.us-west-2.amazonaws.com/dev-recent-stats/activity/test/recent_stats
Relates to:
https://github.com/chanzuckerberg/napari-hub/issues/720
Happy path - Valid plugin name:
https://6vwmwypt38.execute-api.us-west-2.amazonaws.com/dev-recent-stats/metrics/affinder
Invalid plugin name:
https://6vwmwypt38.execute-api.us-west-2.amazonaws.com/dev-recent-stats/metrics/test

Closing this in favour of: https://github.com/chanzuckerberg/napari-hub/pull/741


Fixes #120. Allows another user to run gcm_setup

My testing so far shows that this should allow one user to run gcm_setup in another user's install/bin directory.
That said, I've only really tested with gcm_setup but I've edited the other chem setups as well. Thus, it might be nice for @GEOS-ESM/chemistry-gatekeepers and @GEOS-ESM/geoschemchem-team to take a look and make sure I didn't screw up the GMI, SC, and GEOSChem scripts. I tried to be careful.
Also, this does get rid of the odd HISTORY.rc.hold mechanism. @lltakacs isn't sure anyone is actually using it. If it's needed I think I can see how to bring it back. (The ultimate test is to remove the capability and see if anyone complains. My guess? No one will.)

Added a blocker label until some tests can be done by stakeholders

Thanks to @mmanyin for finding a rather dumb bug on my part. Hopefully the chem scripts now, you know, make a HISTORY.rc

OK, the extra chem setup scripts work fine,  zero diff.


Long log lines are not handled correctly

Couldn't fine an existing issue, so I'll start this one
Currently when a container logs a line that is longer than ~4KB, it is being split into multiple log entries in the container log. The information about this split in then dropped, AFAIU because current log format is not extensible. Therefore a 8KB line will be indistinguishable from two 4KB lines, which will break people who depend on the long lines longer than 4KB.
There should be at least enough information in the logs to reconstruct the original log stream, even if the lines are long. It seems like this is impossible to do without changing the log format though.
/cc @piosz @fgrzadkowski @Random-Liu @yujuhong

There should be at least enough information in the logs to reconstruct the original log stream, even if the lines are long. It seems like this is impossible to do without changing the log format though.

Yeah. If we change the log format to something like docker json log, or add some other prefix to indicate partial lines, will fluentd be able to handle it?

Yeah. If we change the log format to something like docker json log, or add some other prefix to indicate partial lines, will fluentd be able to handle it?

Yes, it will be possible. There's no such plugin yet, but at least it will be possible to write one

json is pretty bad at this.
Even with tons of optimizations, the json logger in Docker is requires 3 allocations per log entry, and on top of that just the slow encoding/decoding speed of json in general.
Might I suggest something like https://github.com/moby/moby/tree/master/api/types/plugins/logdriver as an alternative?

Problem is, json format is highly extensible and widely understood by logging agents like fluentd or logstash, it works there out of the box and this is an important advantage
Thanks for referring to the pb log driver though, that's interesting!

We've switched to the new CRI log format this release. https://github.com/kubernetes-incubator/cri-containerd/pull/421
Future work will be based on our decision about the logging format.


Create prototype layout with all features

[x] Create a prototype of the application to be created with all the features and their placements/aesthetics.
[x] Get the rest of the group's feedback and opinions on the prototype.
[x] Make changes according to feedback and create a final version.

Done, the layout is found on github.


RHPIB backend plugins do not work on a Backstage version lower than 1.14.0

Describe the bug
RHPIB backend plugins do not work on a Backstage version <1.14.0
To Reproduce
Install the RHPIB backend plugins on a vanilla Backstage instance version <1.14.0.
Expected behavior
RHPIB backend plugins should be supported on a Backstage instance version >=1.11.0
Additional context
Somewhere down the execution pipeline this line in the @backstage/backend-common package returns undefined.

ocm-backend: @backstage/backend-common used in run.ts
keycloak-backend: @backstage/backend-common used only in testing
argo-cd-backend: @backstage/backend-common used in run.ts

TypeError: Cannot read properties of undefined (reading 'redacter')

Workaround
The RHPIB backend plugins generally work when you pin all @backstage/backend-common transitive dependencies to 0.18.5.
Related Links
Discord

Apparently this change 1732a18a7a
redactor

GitHub

https://github.com/backstage/backstage/issues/16554
https://github.com/backstage/backstage/issues/18403

The recommended solution for this issue is to either upgrade backstage or pin the transitive dependencies.


✨ New StrictlyPositiveInt.Companion.create* factory functions

📝 Description

Discussed in #335.

We would like to add create* experimental factory functions to the StrictlyPositiveInt type for all platforms with the following signature:
fun StrictlyPositiveInt.Companion.create(number: Number): StrictlyPositiveInt
fun StrictlyPositiveInt.Companion.createOrNull(number: Number): StrictlyPositiveInt?

The StrictlyPositiveInt type being incompatible with Java due to its declaration as inline value class, these functions shouldn't be available yet for Java users.
✅ Checklist

[x] Add the create function, test its behaviour with Kotlin, update the public API binaries.
[x] Add the createOrNull function, test its behaviour with Kotlin, update the public API binaries.
[x] Update the unreleased changelog.
[x] Close this issue as completed and update tracking ones if present.

We should wait for the issue #371 to be resolved before implementing this one.

We reopen this issue for improving the documentation of these new functions be indicating that these may involve rounding or truncation.


Segment Tree in JAVA added

Fixes #{ISSUE_NUMBER}
By submitting this pull request I confirm I've read and complied with the below declarations.

[ ] I have read the Contribution guidelines and I am confident that my PR reflects them.
[ ] I have followed the coding guidelines for this project.
[ ] My code follows the skeleton code structure.
[ ] This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
[ ] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.

Hi! Thanks for showing interest in contributing to this repository.
Please make sure that you have ticked the points mentioned in PR description correctly.
Thanks again!

Please check why can't I merge ?

@vish21: You can't merge the code to this repo. You need to update this pull requests so that it is good enough and the maintainers will merge this.


Update to @asciidoctor/reveal.js 5.x

Can you update dependencies to work with last version of @asciidoctor/reveal.js 5.x released last year?
Thanks.

Hi @migueltercero, currently im waiting for "asciidoctor-vscode" extension to fix an error because my extension fails loading if asciidoctor-vscode is active besides it. As soon as i know how to handle it, i will continue developing my extension.
For further references see: https://github.com/asciidoctor/asciidoctor-vscode/issues/856


Exercise 22.1 out-degree looks wrong

out-degree should be

O(e)

that is total number of nodes in e or simply the the of e (edges list)

You are right.
I will update my solution.
Thanks


How to install this addon ?

Hello ,
Please I want to install a cookie consent that have the ability to GeoLocate and only show the cookies bar to people in the countries that have a cookie law , and also support  different types of compliance to show specific message for every specific country according to it's cookies law
And I found your amazing addon : https://github.com/insites/cookieconsent
But I don't know how to install it with these features ?? ( I downloaded https://github.com/insites/cookieconsent/archive/master.zip and uploaded it into my cpanel and extract it , but i don't know what's the next step ?? )
Please help me .. And thanks very very much on advance .

See https://cookieconsent.insites.com/download/ how to configure and use the add-on.

Yes i tried it , but the cookie consent appear to all countries ! , and I want cookie consent have the ability to GeoLocate and only show the cookies bar to people in the countries that have a cookie law , and also support different types of compliance to show specific message for every specific country according to it's cookies law , but I don't know how to add these features in the code !
Please help me , and Thanks very much for your reply .

To enable the location feature, you set {location: true} in the configuration. I.E.
cookieconsent.init({
  // ... your options
  location: true
})

However this feature uses free location services by default, which may have a limit or expire. You can configure the location service to your your own, but this is an advanced feature. Documentation can be found here


Ensure that PartialEvaluator_extractWidths is able to handle indirect objects in all kinds of "width" data (issue 7855)

Fixes #7855.

/botio-linux preview

/botio test

/botio makeref

Nice work!


Crash found in Developer Console, xyz.luan.audioplayers.player.MediaPlayerPlayer.setRate

Checklist

[X] I read the troubleshooting guide before raising this issue
[X] I made sure that the issue I am raising doesn't already exist

Current bug behaviour
Exception java.lang.IllegalStateException:
at android.media.MediaPlayer.getPlaybackParams
at xyz.luan.audioplayers.player.MediaPlayerPlayer.setRate (MediaPlayerPlayer.java)
at xyz.luan.audioplayers.player.MediaPlayerPlayer.start (MediaPlayerPlayer.java)
at xyz.luan.audioplayers.player.WrappedPlayer.onPrepared (WrappedPlayer.java)
at xyz.luan.audioplayers.player.MediaPlayerPlayer.createMediaPlayer$lambda-5$lambda-0 (MediaPlayerPlayer.java)
at android.media.MediaPlayer$EventHandler.handleMessage (MediaPlayer.java:3455)
at android.os.Handler.dispatchMessage (Handler.java:106)
at android.os.Looper.loopOnce (Looper.java:211)
at android.os.Looper.loop (Looper.java:300)
at android.app.ActivityThread.main (ActivityThread.java:8410)
at java.lang.reflect.Method.invoke
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:559)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:954)
Expected behaviour
No crash occurred
Steps to reproduce

Execute flutter run --release on the code sample
...
...

Code sample

Code sample
var playerBg = AudioPlayer(playerId: 'playerBg');
var playerBtn = AudioPlayer(playerId: 'playerBtn');
await playerBg.setPlayerMode(PlayerMode.mediaPlayer);
await playerBtn.setPlayerMode(PlayerMode.mediaPlayer);
await playerBg.setReleaseMode(ReleaseMode.loop);
playerBg.play(AssetSource('/audio/bg.m4a');
await playerBtn.play(AssetSource('/audio/btn.m4a');

Affected platforms
Android
Platform details
Android 13 (API 33) Redmi wind (Redmi 10C)
AudioPlayers Version
main, 5.2.1
Build mode
release
Audio Files/URLs/Sources
No response
Screenshots
No response
Logs
No response
Related issues / more information
No response
Working on PR
no way

Also seeing this, in our case after the app resumed.

Seeing the same in the case of resuming / backgrounding Apps

same here

same here


Remove EJS Templates

Remove the views folder as we won't be needing those. Can test the backend with Postman

DONE


Oracle QA: Returning Fields on Mutation

Confirm that Oracle support for RETURNING after CREATE & UPDATE works correctly for REST, GraphQL & gRPC.

Disable returning on SML for now. Cannot seem to build correct query with knex.js. Will make another attempt to add feature later.
LN: feature disable
https://github.com/sudowing/service-engine/pull/66/files#diff-39b2554fd18da165b59a6351b1aafff3714e2a80c1435f2de9706355b4d32351R903


Relocating a virtual machine to a different node makes it unreachable

What happened:
I have a virtual machine that has been running quite normal for a few months and last week I had to relocate the machine to a different kubernetes node to do some hardware maintenance. With the help of virtctl, I was able to stop and start it on different node, but unexpectedly the VM became completely unreachable even it had an IP assigned. Then I immediately force it back to start on the original node where it was. Problem had gone.
What you expected to happen:
Expected the virtual machine to relocated to a different machine and reachable.
How to reproduce it (as minimally and precisely as possible):
Additional context:
Currently, I'm trying to find out if there's any difference between kubernetes nodes, though still cannot find any difference.
Environment:

KubeVirt version (use virtctl version): 0.58
Kubernetes version (use kubectl version): v1.25.4+k3s1
VM or VMI specifications: bridge interface,
Cloud provider or hardware configuration: N/A
OS (e.g. from /etc/os-release): Oracle Linux Server 9.1
Kernel (e.g. uname -a): 5.15.0-<IP_ADDRESS>.el9uek.x86
Install tools: N/A
Others: N/A

@stu-gott Please help with troubleshooting, we reviewed in the weekly community meeting!

found that the virtual machine gets an ip address from DHCP server properly. However, default route is not being created for some reason.
@stu-gott for now I've created default route manually on the virtual machine. Do you have any idea on this issue?


Track in telemetry response time for snapshot fetch requests #3072

Adding changes to get response time telemetry. With the change, we will get this telemetry data
fluid:telemetry:OdspDriver TreesLatest_end {"loaderId":"2a7c466c-690d-4e4a-8696-ed6a40738133","clientType":"noninteractive/summarizer","loaderVersion":"0.27.0","containerId":"f12168bc-a65d-4aef-a564-692f02aeb1e6","odc":false,"trees":1,"blobs":48,"ops":0,"headers":true,"sprequestguid":"2ec0789f-00ef-0000-cee7-9be0b7c83a52","isOptionsCall":true,"clientDuration":-1,"redirecttime":0,"dnsLookuptime":0,"responsenetworkTime":52233.56500000227,"tcphandshakeTime":0,"secureconnectiontime":0,"fetchstarttorespendtime":273.0300000112038,"reqstarttorespendtime":0,"starttorespend":273.0300000112038,"contentsize":27723,"bodysize":27723,"duration":98417,"category":"performance","docId":"sfaLcwa0QfIHpZ3ZvqRHgle8GmfelGaiq5jAK9ksHpw%3D","containerAttachState":"Attached"} tick=150377

@jatgarg @ram-ramasubramanian can you pl. review?

I've addressed all the comments and pushed the latest changes. Pl. review the latest changes.


Add GaussianSampler

The PR contains a simple GaussianSampler. This adopts an approach similar to the one implemented by lattigo.
There's no integration with any other part of the codebase. Opened it as a draft PR to ask you a review on the current implementation and further guidance on how to better integrate it into the rest of the codebase.

Added notes https://hackmd.io/@gaussian/SyxAZZukhp
Implemented safe rng

Since we don't add anything on top of rand_distr should we move this directly inside DefaultU64SeededRandomGenerator here ? What do you think?

Since we don't add anything on top of rand_distr should we move this directly inside DefaultU64SeededRandomGenerator here ? What do you think?

Yes I think so. Just wanted to check your reply to the previous comments before moving it.

commit fixes random_fill in RandomGaussianDist. We hardcode mean to 0 and std_dev to 3.2.


bosh deploy with remote releases could give better feedback about progress

It is hard to know how much longer it will take for a deployment to finish
When using bosh to deploy CF Deployment, many of the releases deployed are remote and are automatically downloaded from bosh.io.  When downloading releases, the feedback looks something like:
Task 84
17:49:30 | Downloading remote release: Downloading remote release (00:03:01)
17:49:42 | Verifying remote release: Verifying remote release (00:02:47)
17:49:42 | Extracting release: Extracting release (00:02:48)
17:49:43 | Verifying manifest: Verifying manifest (00:02:47)
17:49:43 | Resolving package dependencies: Resolving package dependencies (00:02:47)
17:49:43 | Creating new packages: apparmor/c8e25d84146677878c699ddc5cdd893030acb26f (00:00:00)
17:49:43 | Creating new packages: busybox/fc652425c32d0dad62f45bca18e1899671e2e570 (00:00:00)
17:49:43 | Creating new packages: golang_1.7.1/91909d54d203acc915a4392b52c37716e15b5aff (00:00:01)
17:49:44 | Creating new packages: guardian/c4acb6073abb4e17165253935c923dfbdfbfb188 (00:00:00)
17:49:44 | Creating new packages: iptables/24e83997945f8817627223c6cee78ca9064f42d5 (00:00:00)
17:49:44 | Creating new packages: libseccomp/7a54b27a61b42980935e863d7060dc5a076b44d0 (00:00:00)
17:49:44 | Creating new packages: runc/68f36fbe363fefa5ec8d44b48ee30a56ac6e1e0e (00:00:00)
17:49:44 | Creating new packages: shadow/7a5e46357a33cafc8400a8e3e2e1f6d3a1159cb6 (00:00:00)
17:49:44 | Creating new packages: tar/f2ea61c537d8eb8cb2d691ce51e8516b28fa5bb7 (00:00:00)
17:49:44 | Creating new jobs: garden/66437b9bb9f6d851fa3e5b895c75452a41bfb9e3 (00:00:00)
17:49:44 | Release has been created: garden-runc/1.1.1 (00:00:00)

Started  Thu Jan 19 17:46:41 UTC 2017
Finished Thu Jan 19 17:49:44 UTC 2017
Duration 00:03:03

This feedback could be improved:

If it showed a progress bar for the release download, that would give users a sense of how much longer it will take for the individual task to complete.
If the overall progress was also displayed somehow (e.g. Task 84 of 120, 50 minutes remaining...) it would make it clearer how much longer it will take for the entire deployment to finish.

cc: @robdimsdale

If it showed a progress bar for the release download, that would give users a sense of how much longer it will take for the individual task to complete.

i could see that being done. we kinda have that in the director, but it's not exposed all the way to the cli.

If the overall progress was also displayed somehow (e.g. Task 84 of 120, 50 minutes remaining...) it would make it clearer how much longer it will take for the entire deployment to finish.

this one is tough. not sure how we would estimate this time.

Is there any progress on this?
It would be great to have some feedback, i.e., what is the current download speed. This helps to investigate if it is still working, bosh hang up, or ran into some proxy issues and the download is timing out.

@amuessig, at this point, no work or planning has been done on this. If you're interested in looking around the director code to work on a resolution, please feel free to propose a solution for discussion before submitting the pull request.

Closing this due to inactivity. This is unlikely to be a priority in our immediate future. If you have further questions, please feel free to create a new issue.


Result Upload Api

Has anyone been able to upload results via the API?  I must be doing something wrong. I always get {"file":["The submitted data was not a file. Check the encoding type on the form."]}
Here is the code.
#! /usr/bin/python
import requests
import json
url = 'https://defectdojo.herokuapp.com/api/v2/import-scan/'
headers = {#'content-type': 'application/json',
'Authorization': 'Token 548afd6fab3bea9794a41b31da0e9404f733e222'}
body = {'scan_date': '2019-07-04',
'scan_type': 'Dependency Check Scan',
'file': '/Users/tchase/Downloads/dependency-check/bin/dependency-check-report.json',
'engagement': '14',
'lead': '1'
}
r = requests.post(url, headers=headers, verify=True, data=body) # set verify to False if ssl

Hey @outdoorguy007 I assume you're using APIv2. Based on this unit test, it looks like you have to input an actual file instead of the path to it.

Yeah, so I tried that and now it gives me a 503...
import requests
import json
url = 'https://defectdojo.herokuapp.com/api/v2/import-scan/'
headers = {
'Content-type': 'multipart/form-data',
'Authorization': 'Token 548afd6fab3bea9794a41b31da0e9404f733e222'}
files = {'file': open('/Users/tchase/Downloads/dependency-check/bin/dependency-check-report.json','rb')}
body = {'scan_date': '2019-07-04',
'scan_type': 'Dependency Check Scan',
'engagement': '18',
'lead': '1'
}
r = requests.post(url, headers=headers, files=files, verify=True, data=body) # set verify to


Update repo links to new repo owner

Updating various links since the repo was transferred to a new owner. The GH ones would have redirected, but some of the links in the docs didn't so I've tried to catch them all for good measure.

LGTM, thanks again @davidwilby!
@all-contributors please add @davidwilby for doc


New rsyslog 3.0.0 upstream cookbook not compatible with chef 11+

By not locking the rsyslog cookbook version in metadata.rb, Berkshelf will upgrade to the latest rsyslog 3.0.0 cookbook (released on 11/10/15) which now depends upon the compat_resources cookbook.  The compat_resources cookbook only works with Chef 12+.
Need to either lock your metadata.rb version and/or bump the version number here so that you have versions compatible with chef 11+ and chef 12+, or decide to label as only compatible with chef 12+.

I've release 2.4.1 to use rsyslog 2.0.  The next release of this cookbook will move to Chef 12 only though as the LWRP will be converted a custom resource.


how to use wagmi/vue with useSetActiveWallet ?

we have inly react import useSetActiveWallet how to use in @wagmi/vue ?
  const setActiveWallet = useSetActiveWallet()

also @wagmi/vue not support useWalletClient (https://github.com/wevm/wagmi/discussions/4005)
could you create a working playground/demo for vue ?
(Otherwise I don't see how we can migrate by the end of June and have to part ways. )

Hi @reslear - Can you give more info on what you are trying to do and what features of thirdweb SDK you want to use?

I'm trying to replicate https://github.com/thirdweb-example/wagmi-thirdweb only in vue.

you should be able to just use the viem adapter, like:
const account = viemAdapter.walletClient.fromViem({ walletClient });

and keep the account around using your state manager of choice. With that account you can use the rest of the SDK to send transactions.


test(STONEINTG-609): e2e automation for reporting integration test status

Description
This PR adds a new test file within the integration-service test suite, that automates the status reporting of integration tests within the CheckRuns.
Issue ticket number and link
STONEINTG-609
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?
Ran the test locally in a fresh cluster by running the command: ./bin/e2e-appstudio --ginkgo.label-filter="status-reporting" ginkgo -vv
Checklist:

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
[x] I have updated labels (if needed)

The latest CI job failed for some unrelated reasons.
But that CI job was successfully able to run our test (introduced by this PR) because it did create a PR and reported the integration test's statuses there successfully.

dheerajodha, I saw that the job failed with
  [FAILED] Timed out after 120.000s.
  secrets target-secret-test is not created in all environments
  Expected
      <bool>: false
  to be true
  In [It] at: /tmp/tmp.5SX8jxsEgG/tests/remote-secret/environments.go:462 @ 11/09/23 12:32:37.772

The fix was addressed here. IMHO it is better to merge with the main branch

The fix was addressed https://github.com/redhat-appstudio/e2e-tests/pull/864. IMHO it is better to merge with the main branch

Thanks @rsoaresd for looking into this, I've now rebased my branch to latest main.

/retest

/retest

/test redhat-appstudio-e2e

The previous job failed on an unrelated error, I've attempted to fix it with my latest commit :crossed_fingers:

Status Reporting works as expected in the new repository: https://github.com/redhat-appstudio-qe/hacbs-test-project-integration/pull/2/checks

/lgtm


.github: switch kind images back to kind

Kind has released stable versions for k8s 1.29 so we can use this image instead of the cilium kindest.

/test


[Idea] Mouse and Keyboard Emulation over SCSI

I am thinking to implement mouse and keyboard control over SCSI. The reason is that I've heard that ADB peripherals are as hard to find, and sometimes as expensive, as the vintage Macs themselves. This would meet the need of someone who bought a Mac but didn't have an ADB mouse and keyboard and saves them the extra expense of buying a separate USB to ADB adapter.
The way this would work is that they would plug in a USB keyboard and mouse to the Raspberry Pi and then boot a custom boot image. This boot image would have a small system extension preinstalled that would read mouse and keyboard information via SCSI and use it to control the Mac.
The extension would more or less be what I already do with MiniVNC, only streamlined. Right now I can already boot a Mac without an ADB mouse and keyboard using a specially prepared boot image, but it's a bit of a Rube Goldberg situation since it uses TCP and you need a full PC running a VNC client to control the Mac.
On the Linux side of things, I found a blog with Python code that shows how to grab raw mouse coordinates and keyboard events from Linux, even if an X server is not running.  I have already verified that it works on the RaSCSI and spits out raw data from a directly attached keyboard and mouse.
The only bit I don't know how to do is how to implement a custom SCSI device in RaSCSI. Any pointers on this would be appreciated.

@marciot Regarding implementing custom devices there is some information on https://github.com/akuker/RASCSI/wiki/rules-for-adding-new-device-types.

@uweseimet: I was thinking about polling. Since I've already gotten this working via the DaynaPort drivers, using MacTCP and my MiniVNC client, I already know it is usable, albeit a tad on the sluggish side. My hope is that by getting rid of the overhead of the DaynaPort drivers, MacTCP, and the VNC protocols, I might have something that is fairly useable. Although this is the sort of thing I won't know for sure until I try it out.
One effect I see with MiniVNC is that if I move the mouse slowly, it tracks alright. But if I move it fast, the Mac cannot keep up and takes a while to catch up. The mouse motion is smooth, because each mouse position is transmitted as a TCP/IP packet and is queued, but the cursor path on the screen lags the actual mouse movements on the client by a lot. By using polling, I'm hoping the effect can be minimized.

@uweseimet: I am trying to use your print device as a template for my keyboard and mouse driver, but that code does not provide an example of how to read data from the RaSCSI. Basically, instead of:
SCSIPrinter::SCSIPrinter() : PrimaryDevice("SCLP"), ScsiPrinterCommands() {
	dispatcher.AddCommand(eCmdWrite6, "Print", &SCSIPrinter::Print);
}

void SCSIPrinter::Print(SCSIDEV *controller)
{
	if (!CheckReservation(controller)) {
		return;
	}

	uint32_t length = ctrl->cmd[2];
	length <<= 8;
	length |= ctrl->cmd[3];
	length <<= 8;
	length |= ctrl->cmd[4];

	LOGTRACE("Receiving %d bytes to be printed", length);

	// TODO This device suffers from the statically allocated buffer size,
	// see https://github.com/akuker/RASCSI/issues/669
	if (length > (uint32_t)ctrl->bufsize) {
		LOGERROR("Transfer buffer overflow");

		controller->Error(sense_key::ILLEGAL_REQUEST, asc::INVALID_FIELD_IN_CDB);
		return;
	}

	ctrl->length = length;
	controller->SetByteTransfer(true);

	controller->DataOut();
}

bool SCSIPrinter::WriteBytes(BYTE *buf, uint32_t length)
{
	if (fd == -1) {
		strcpy(filename, TMP_FILE_PATTERN);
		fd = mkstemp(filename);
		if (fd == -1) {
			LOGERROR("Can't create printer output file: %s", strerror(errno));
			return false;
		}

		LOGTRACE("Created printer output file '%s'", filename);
	}

	LOGTRACE("Appending %d byte(s) to printer output file", length);

	write(fd, buf, length);

	return true;
}

I need something that turns things around and provides data via a eCmdRead6. Here is my first attempt:
ScsiKvm::ScsiKvm() : PrimaryDevice("SCKM")
{
	dispatcher.AddCommand(eCmdRead6,    "ReadEvents",  &ScsiKvm::ReadEvents);
}

int ScsiKvm::ReadEvents(const DWORD *cdb, BYTE *buf)
{
	if (!CheckReservation(controller)) {
		return;
	}

	uint32_t length = ctrl->cmd[2];
	length <<= 8;
	length |= ctrl->cmd[3];
	length <<= 8;
	length |= ctrl->cmd[4];

	LOGTRACE("Sending %d bytes of events", length);

	// TODO This device suffers from the statically allocated buffer size,
	// see https://github.com/akuker/RASCSI/issues/669
	if (length > (uint32_t)ctrl->bufsize) {
		LOGERROR("Transfer buffer overflow");

		controller->Error(sense_key::ILLEGAL_REQUEST, asc::INVALID_FIELD_IN_CDB);
		return;
	}

	ctrl->length = length;
	controller->SetByteTransfer(true);

	controller->DataIn();
}

// This function does not actually exist.
bool ScsiKvm::ReadBytes(BYTE *buf, uint32_t length)
{
	return true;
}

It looks like it isn't as simple as this, because there is no "ReadBytes" command in the base class "PrimaryDevice" to override. Any hints on how to proceed?

@marciot I recommend studying other parts of the RaSCSI code for how data can be read. Note that most likely some refactoring is required in order to have a clean solution for reading data where the amount of bytes read is not a multiple of a sector. A lot of the current code can only deal with sectors, not with data of any length. Also see https://github.com/akuker/RASCSI/issues/479, which is related becasue READ/WRITE LONG also deals with transferring an arbitrary number of bytes.

@uweseimet: Okay, it looks like I may have gotten more than I bargained for!

@marciot - You may be interested in another side project I've been (very slowly) working on.... https://github.com/akuker/adbuino

@akuker: I’m sure there is a market for this, but my thought was to have the RaSCSI itself act as a keyboard/mouse interface so you didn’t need to buy two pieces of hardware.
Anyhow, making a custom SCSI device seems to be beyond my abilities at this point, but it occurred to me that I could just as well write a headless VNC client that would run on Raspberry Pi and connect to MiniVNC running via the existing DaynaPort driver. I think that would accomplish what I want without cluttering RaSCSI with yet another custom SCSI device.
If this worked well, I would think there could simply be a button on the RaSCSI web interface that would start the headless VNC client to allow a connected mouse and keyboard to control the Mac.

Based on the discussion, I'm closing this as WontFix. HID support is beyond the scope of RaSCSI.


[libid3tag] Add version 0.16.3

Add's Tenacity's libid3tag (originally by @Be-ing) port with some modifications, including a hashable source, correct usage text, and using vcpkg_install_copyright().
This is similar #15991, but this port is smaller, does not feature any patches, and uses 0.16.3.
Note: the usage text may be wrong, which is why this is a draft PR at the moment. Once I can confirm the usage text is correct, I'll mark this as ready.

[x] Changes comply with the maintainer guide
[x] The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
[x] Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
[x] The versioning scheme in vcpkg.json matches what upstream says.
[x] The license declaration in vcpkg.json matches what upstream says.
[x] The installed as the "copyright" file matches what upstream says.
[x] The source code of the component installed comes from an authoritative source.
[ ] The generated "usage text" is accurate. See adding-usage for context.
[x] The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
[x] Only one version is in the new port's versions file.
[x] Only one version is added to each modified port's versions file.

Note that the source tarball used is Codeberg's auto-generated source tarball. I've updated the hash after it changed, presumably from the DDoS attack.
I also have reason to believe that these source tarballs are stable and that the hash change, like with what happened in #36362, was an unusual event. However, if it's preferred, we can provide our own source tarballs instead like with libmad.

@generic-pers0n You should change the state of this PR from Draft to ReadyForReview. Otherwise it does not appear on the teams review list.

@generic-pers0n You should change the state of this PR from Draft to ReadyForReview. Otherwise it does not appear on the teams review list.

I have marked this PR ready for review as I feel that it is ready to be reviewed again.

Usage test passed with x64-windows  triplet.


Unclear error message

This error message "The input has duplicated 'about_file'.
Duplication is not supported." lead me to look for duplicate column header label Instead of looking of looking for duplicate value in the 'about_file' column.   Perhaps error should be "The input has duplicated values in 'about_file' field."

This is the error message when you have duplicated column name: "The input has duplicated 'about_file'.
Duplication is not supported."  Note it is the same as when you duplicated values

Would be nice  when duplicate error detected to print the value of the duplicate.


Deaths by district are always 0

This feels like a very bleak GitHub issue to post, but when selecting a regional healthcare district, the 'Deaths' number is always 0. I wish it were true.

Ah, you're right, this is a regression. Apparently the new data endpoint doesn't use same healthcare areas for the deaths data, thanks for reporting.

Actually the endpoint doesn't return any healthcare district for the deaths, only the hospitals. So we should do some kind of mapping from TAYS, HYS, TYKS etc to health care districts to fix this.


Add dashboard statistics API (lower priority)

Related component: api
Description
An api that returns various statistics:

new help requests count
done help requests count
help requests w/ status בטיפול
help requests w/ status התקבלה
amount of help requests submitted in the past 24 hours, per hour
amount of help requests opened & help requests addressed in the past 10 days, per day
for each חמל, count of:

unaddressed help requests
help requests pased to volunteer
help requests done
new help requests  TODO: In what timeframe?
new volunteers TODO: In what timeframe?
total volunteers

This is in a lower priority.
@yGoldi please fill in the TODOs

new help requests TODO: In what timeframe? same date (00:00 to 23:59)
new volunteers TODO: In what timeframe?d same date (00:00 to 23:59)


Order Agnostic Binary Search

Is your feature request related to a problem? Please describe.
Order-Agnostic Binary Search is a modified version of Binary Search Algorithm. Here in this modified binary search comes with one more condition checking.
The intuition behind this algorithm is what if the order of the sorted array is not given. So here check that the value of the first element is greater or smaller than the last element.

This can be done in C, C++, Java, JS and Python.
Can I be assigned this in Java and C?

Please assign me this issue in C++.

This can be done in C, C++, Java, JS and Python.
Can I be assigned this in Java and C?

Please implement in all four languages

Assigned!
@VishalS-HK : C, C++, Java, Python

I would like to do it in Java and C only

I would like to do it in Java and C only

ok

Please assign this issue to me in Python

Please assign this issue to me in Python   @Kumar-laxmi

@Kumar-laxmi please assign this to me in C++.

@VishalS-HK  I have unassigned this issue due to inactivity

Assigned!
@VaibhavArora314 : C++
@Dharnish38 : Python

@Kumar-laxmi assign this to me in java.

@Dharnish38 What is your status on this issue?

@Kumar-laxmi Sorry to say like this, I have finished working on this issue but I am not able to create a new pull request for this, because there is a PR already opened by me which is #505 after getting it merged only I can able to create another pull request if I try to create a pull request now this issue will be attach to that PR #505 on top of that it will be double burden for mentors and you again to visualize the changes for that only I am not creating a pull request for this issue. If it's ok for you then I can create a PR no problem on that.

@Kumar-laxmi I have opened the pull request for this issue #537.

@Kumar-laxmi I have opened the pull request. Kindly take a look.Thanks


Import Standard Cost Code, Standard Category as Cost Center

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (master@956b860). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #66   +/-   ##
=========================================
  Coverage          ?   78.01%
=========================================
  Files             ?       50
  Lines             ?     2051
  Branches          ?        0
=========================================
  Hits              ?     1600
  Misses            ?      451
  Partials          ?        0

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Updated the readme file

Changes made :
Added metrices table
Added program section
Enhances overall appearance
Please merge it @UppuluriKalyani

@Aman-G-upta can you add contributors section?

Sure @UppuluriKalyani


[QUERY] Azure cli is throwing error when I use it to list the vms/disks

Library name and version
az cli version 2.38.0
Query/Question
When I try to list vms or disks using the azure cli command it is throwing me the below error. These commands worked fine until yesterday and today we started observing these errors.  Your help to resolve this issue is greatly appreciated.
az vm list -o table
(ProviderError) Resource provider 'Microsoft.Compute' failed to return collection response for type 'virtualMachines'.
Code: ProviderError
Message: Resource provider 'Microsoft.Compute' failed to return collection response for type 'virtualMachines'.
az disk list -o table
(ProviderError) Resource provider 'Microsoft.Compute' failed to return collection response for type 'disks'.
Code: ProviderError
Message: Resource provider 'Microsoft.Compute' failed to return collection response for type 'disks'.
Environment
We are using the az cli on a RHEL 7  server

This issue has been transferred to the Azure CLI repository as  #27397.


(Partially) fix Constants of Motion and Frequencies for e=1 orbits

This contains some old fixes to the KerrGeodesics package, which need to be reviewed and merged into the main branch.

@ofl23 Do you have code to check the e=1 AngularMomentum, RadalRoots, and Frequencies code that Maarten has added?

@nielsw2 I have codes that can calculate AngularMomentum and RadialRoots for e>1. I will check if they are also valid for the  boundary case.


Playlist Not Synced Or Usable

Bug were playlist are not populated/fetched on  Music

You sure you are not using the testflight version of retro. You need to manualy create and then populate the playlists when using retrofi and apple music. but you should be able to add all the songs at once.