Buckets have a lot of issues, BucketComponent should probably die

Description

handheld buckets have a volume of 500u which seems.. like.. a lot?
bucketcomponent snowflakes a lot of stuff that SolutionContainerComponent should handle, and it snowflakes a lot of interactions with mops specifically. i feel like you should be able to dip a mop in something that isn't a bucket, right? like i should be able to dip a mop in my open can of soda if i please. imo this functionality should go on SolutionContainerComponent and only apply if certain caps are right
handheld buckets and mop buckets don't have visualizers for their contents like beakers do (mop buckets i think change their sprite, but they have water hardcoded i think)
you can't add fluid to mop buckets, only steal from it with a mop. let me put 500u of blood in my mop bucket goddamnit. also if you wet a bloody mop in a mop bucket it should transfer some of the blood to the bucket like viscera cleanup detail but thats bikeshed

also it just feels bad because '[noun]Component' is usually a sign that its not good

I agree but with that being said multiple people prefer the mop destroying solutions (for whatever reason) compared to just transferring them which is what it originally did.
I assume the 500u was a copypaste

handheld buckets - definitely agree, and I want to nerf. I'm thinking 150-200 units based on the mop bucket's 500u.
BucketComponent could die and have any special interactions moved to MopComponent with some checks.

The mop should be able to take liquid from any container, I agree, even if that's "I spill the soda on my mop."
IMO, transferring liquid from mop to any container should be possible, but nerfed unless there's a wringer on it (e.g. you use your hands to squeeze liquid out - it takes twice as long and you can only squeeze half the liquid out of the mop, reducing its capacity until properly wrung)
Stuff like "is the mop interacting with something with a wringer" could be handled within MopComponent
I'll add this to my list but probably won't get to it for a little while yet. Would like to hear your thoughts as well @mirrorcult!

Visualizers: Ooh yes interesting, I want to take a closer look at how that color/visualizer piece works. That'd be really cool
Did somebody order uhhhhhhhhhhhhhh bucket full of blood?

The mop should be able to take liquid from any container

How do you define container? SolutionContainerManager isn't usable for obvious reasons so is it something like drainable?

good point - I hadn't thought that far ahead yet. Still getting my head around all these systems to be honest - another reason I won't tackle this one right away 😁

In SS13, small beakers hold 20u, large beakers 100u, buckets 100u, and mop buckets 500u.

handheld buckets have a volume of 500u

I addressed this just now in [#6273]. And now that I know my way around visualizers I think I can tackle the rest of this issue as well

Worth noting handheld buckets cannot be placed in pockets and take up literally 100 space in your bag.
Honestly, I don't get the bucket hate. They seem completely reasonable at 500 considering the above. You can carry 20 large beakers in your bag as well as fit them in dispensers and such. At 100 volume a bucket is useless compared to a large beaker which can fit anywhere. Arguably a 500 unit bucket is still worse than 5 large beakers, but it had a good use in mixing chemicals time efficiently.
Maybe if they could fit in your belt slot they would have a niche use? Or maybe what I am missing is that you cannot interact with non-buckets with the mop, but that seems a little strange to me if so. Presumably you could be mopping into a beaker? Or maybe large beakers just need a nerf, but I personally like them.
Did buckets have any other use in SS13?

Someone can assign me to this issue if they like. I now intend to fully solve it, by adding a MoppingSystem to make all of mopping ECS-compliant. However for simplicity I think I'll wait for #6273 to get reviewed first in case there's changes needed. I can work on other areas in the meantime though 🙂

The mop should be able to take liquid from any container

How do you define container? SolutionContainerManager isn't usable for obvious reasons so is it something like drainable?

I understand what you mean now - learned a lot in three weeks! 😁
Yes, DrainableSolutionComponent is the way I would go. After checking all the entities with this component, the only one that doesn't make sense is in shotgun.yml, where ammo is a "solution." Although the meme potential of "you fill your mop with hot lead" is pretty tempting, I think that needs fixing 😂
And because I now know more about datafields work, I absolutely agree that bucketComponent needs to die. I plan to do it by adding a bool: hasWringer datafield to RefillableSolutionComponent that defaults to false, and make this true on proper mop buckets. As part of this issue, mop buckets need to just be given Refillable and Drainable instead of BucketComponent.
hasWringer would currently be true for just the one mop bucket prototype, but I may wish to add others later (e.g. a 2-compartment mop bucket, or nerfed small portable bucket with wringer). If hasWringer is true, the transfer would take place with a shorter doAfter delay, and with different popup text (e.g. "You use the wringer to quickly wring out the mop into the bucket" versus "You use your hands to wring the mop into the soda can").
Any thoughts on my approach? I think I want to tackle this after I'm finished my current WIP PR.

As far as I knkow, shotguns only use DrainableSolutionComponents in their tranquilizer dart shells, to allow you to add and remove drugs. I suppose you could squeeze a tranquilizer dart out into a mop. Drawing out of a mop into a dart is a little sketchier, but if you can do it with a syringe I suppose it makes sense to stay consistent.

As far as I know, shotguns only use DrainableSolution components in their tranquilizer dart shells

Ah, you're correct. I was skim-reading that code the first time.

Drawing out of a mop into a dart is a little sketchier, but if you can do it with a syringe I suppose it makes sense to stay consistent.

This gives me another idea. Maybe MopComponent should include a field for minimumRefillableSolutionVolume (say, 20 units). Then in the MoppingSystem, a check to make mops unable to deposit into impractically small containers.

And because I now know more about datafields work, I absolutely agree that bucketComponent needs to die. I plan to do it by adding a bool: hasWringer datafield to RefillableSolutionComponent that defaults to false, and make this true on proper mop buckets. As part of this issue, mop buckets need to just be given Refillable and Drainable instead of BucketComponent.
Any thoughts on my approach? I think I want to tackle this after I'm finished my current WIP PR.

If only mops will use the hasWringer bool, then it'd probably be better to use a tag in TagComponent and check it with the MopSystem, since not every Refillable needs wringer data. Or depending on needs make a WringerComponent.

That's true! In retrospect that IS way cleaner than adding "bool hasWringer = false" to every Refillable in the game 😂
I know how to do this now too, since learning about how Tags work these past few days 😁

this is p much done with #6718 as far as im concerned


Downloading the project definition with content doesn't always work on Windows

What is the current behavior?
On Windows, the zip containing the project definition with file content obtained from the project settings in the Console for a project that contains either

a permission query
a resolver

does not include the actual function/query files, but references them in the graphcool.yml file, when downloading the zip on Windows. Maybe this is triggered by a special function/permission file name as well (spaces?).
What is the expected behavior?
The zip should contain those files.

Windows needs the explicit {createFolders: true} option when calling zip.file() here: https://github.com/graphcool/console/blob/24e637a96b73347aaa1e607c453e8631c0ec3d96/src/views/Settings/General/ProjectInfo.tsx#L349.
Otherwise, JSZip will default to creating a 'virtual folder', which is not supported on Windows


UserManager.UpdateSecurityStampAsync throws Optimistic concurrency when there is no concurrent access to the application.

Describe the bug
My ASP.Net Core 3.0 web application with Identity and EntityFrameworkCore cals UserManager.UpdateSecurityStampAsync when user successfully logs in. This function throws optimistic concurrency exception but there is no concurrent access to the system at all. This happens in Development environment when I am debugging the single-instance application.
To Reproduce
Steps to reproduce the behavior:

Using this version of ASP.NET Core '...' 3.0
Run this code '....'

        public async Task<UpdateUserResponse> UpdateSecurityStamp(string id)
        {
            try
            {
                AppUser user = await _userManager.FindByIdAsync(id);
                if (user != null)
                {
                    IdentityResult result = await _userManager.UpdateSecurityStampAsync(user);
                    return new UpdateUserResponse(user.Id, result.Succeeded, result.Succeeded ? null : result.Errors.Select(e => new Error(e.Code, e.Description)).ToList());
                }
                else
                {
                    _logger.LogCritical($"Trying to update an invalid user {id}!");
                    return new UpdateUserResponse(null, false, new List<Error>() { new Error(HttpStatusCode.BadRequest.ToString(), $"Trying to update an invalid user {id}!") });
                }
            }
            catch (Exception e)
            {
                _logger.LogCritical($"{nameof(UpdateSecurityStamp)} Exception {e.Message}!");
                return new UpdateUserResponse(null, false, new List<Error>() { new Error(HttpStatusCode.InternalServerError.ToString(), $"Failed to update user last activity! {e.Message}") });
            }
        }

With these arguments '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
Include the output of dotnet --info
$ dn --info
.NET Core SDK (reflecting any global.json):
 Version:   3.0.100
 Commit:    04339c3a26

Runtime Environment:
 OS Name:     ubuntu
 OS Version:  19.04
 OS Platform: Linux
 RID:         ubuntu.19.04-x64
 Base Path:   /usr/share/dotnet-3.0.100/sdk/3.0.100/

Host (useful for support):
  Version: 3.0.0
  Commit:  7d57652f33

.NET Core SDKs installed:
  3.0.100 [/usr/share/dotnet-3.0.100/sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.App 3.0.0 [/usr/share/dotnet-3.0.100/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 3.0.0 [/usr/share/dotnet-3.0.100/shared/Microsoft.NETCore.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download

Please include your full app as its likely there is something going on where the user is being updated concurrently

If this is still an issue, feel free to reopen this once you have a repro for us to look at


Review Ticket Week #4

TedTalk Notes
Collegeboard Collaboration Notes
Video Link

I believe that Jishnu gets a 2.7 because he had completed all of the assignments for this week. His video shows him making his on computer server and the changes that occur instantly. His TedTalk notes are also very detailed including a gratitude list.

2.5
You did a ok job at explaining your steps and showing your knowledge of what you did however there was no sound.

2.7, you completed all the assignments, something you could consider for next time is sound or more creativity in your changes. good job!

2.7. You seem to have completed the assignments, but I didn't see much of a voice to explain what you did or not much captions to elaborate

Tooo much time typing.  Need to work on optimizing time in video.  Only half of key elements.  2.5

Would be easier to understand with sound and it looks like you are missing the permanent push and sync. 2.6

2.5, I think you showed that it worked, but I think you could have added some more text to show and explain each part.

No voiceover which but showed that both his fastpages and webpage were being hosted locally.

2.6, sound would be helpful but everythign still appeared to have worked

You did all of the parts to the assignment, but like Luka's video I think you should add some audio to explain what you were doing. 2.6

I think Jishnu deserves a 2.6, as even though he showed both of this local servers running properly and included the necessary components, it would have been nice if he added some audio.

I think you deserve a 2.9, you did a great job explaining the process well!


EngEd Community Contribution Issue - Automate topic issue & pull request closures

This is a feature (or enhancement) proposal related to EngEd improvements.
As an EngEd CM id like to automate topic issue/pull request closures.
A general (& manual) practice is that we regularly ask the team to go through OLDER topic issues (topic suggestions that have been approved - but we have yet to see a Pull request linked to it) and close them.
Describe the task(s) you'd like to see done
Close STALE Issues & Pull Requests:
We currently sift through and close all STALE (PR with more info) issues or PRs manually.
We do the same thing for Pull requests with no edits, comments, or activity for 10 days.
No response (close):
Sometimes we have follow up questions on a PR or Topic suggestion (issues) - and there may not be a response for a while - in this case we close the PR/Issue manually.
It would save the team some time if we could auto closes issues when there hasn't been a response from the author (i.e. question label after 10 days) or there has been no activity.
Describe any alternatives (or notes) we've considered to explore
A few links to bots found by the team are above.
Additional context
Lets look for bots that do exactly this.
Note: We cannot utilize github actions and more specifically GitHub Secrets because the GitHub secrets will not work on Pull Requests from forked repos. For this reason, this will likely need to be built via a custom ProBot app. Open to other suggestions, but actions/secrets will not work.
If you would like to build this with a different approach than ProBot, please share the alternate approach with @hectorkambow or @hborrelli1 for approval before coding.

@WanjaMIKE
Wanted to follow up and see if this feature was still in progress or if you need any help with the implementation.
We are getting ready to release like 3-5 new ones with the entire EngEd community this week - would like you to be able to join that as well.


for ytsync, detect when lbrycrd is not running and error appropriately

Acceptance Criteria

Definition of Done

[ ]  Tested against acceptance criteria
[ ] Tested against the assumptions of the user story
[ ] The project builds without errors
[ ] Unit tests are written and passing
[ ] Tests on devices/browsers listed in the issue have passed
[ ] QA performed & issues resolved
[ ] Refactoring completed
[ ] Any configuration or build changes documented
[ ] Documentation updated
[ ] Peer Code Review performed

Issue moved to lbryio/ytsync #10 via ZenHub


update bcgov fontawesome component

Update the fontawesome story in storybook to list all of its props, and document it's use cases and value. Use the fontawesome to check for any bugs that may exist

[x] Storybook documentation
[x] Bugs check

Updated svg issues when updating header already


sugg: watch off

The watch feature is very useful, but sometimes, we want to stop it from menu

could you add watch off in the menu
TO BE

Sure! I've added an unwatch command, but also just in case you were curious, you can do this entirely in your own config!
require("overseer").setup({
  actions = {
    unwatch = {
      desc = "Remove the file watcher",
      condition = function(task)
        return task:has_component("restart_on_save")
      end,
      run = function(task)
        task:remove_component("restart_on_save")
      end,
    },
  },
})

Check the actions guide for more

That's great


Recording rule discarding samples for histograms

What did you do?
I'm testing switching from classic to native histograms, and my use case includes calculating rates and histogram quantiles over histograms using recording rules.
What did you expect to see?
Rates and histogram quantiles should be calculated as for classic histograms, with no errors or gaps in metrics.
What did you see instead? Under which circumstances?
I noticed that a recording rule that calculates a rate over a histogram metric now has occasional gaps in the resulting series, with corresponding log messages like 0.180000 observations found in buckets, but the Count field is 0.180000.

A complete log line:
ts=2023-08-16T22:57:24.182Z caller=manager.go:735 level=warn component="rule manager" file=/etc/prometheus/rules/aggregation.rules.yml group=rules/aggregation.rules name=sqlprober_dedicated_latency_ns:rate1m index=60 msg="Rule evaluation result discarded" err="0.180000 observations found in buckets, but the Count field is 0.180000: histogram's observation count should be at least the number of observations found in the buckets" sample="{__name__=\"sqlprober_dedicated_latency_ns:rate1m\"} => {count:0.18, sum:154043.88,<PHONE_NUMBER>105466,679917.4164288685]:0.02,<PHONE_NUMBER>288685,741455.2001894652]:0.02,<PHONE_NUMBER>894652,808562.6292314784]:0.04,<PHONE_NUMBER>314784,881743.7995210788]:0.06, (1.048576e+06,1.1434802362872052e+06]:0.04} @[1692226643986]"

I wonder if this is some kind of floating point comparison bug, because 0.180000 >= 0.180000.
Note that if I run the same query used in the recording rule in the prometheus web interface, the result has no gaps, so this appears to be specific to recording rules.
System information
Linux 5.4.238-148.347.amzn2.x86_64 x86_64
Prometheus version
prometheus, version 2.46.0 (branch: HEAD, revision: cbb69e51423565ec40f46e74f4ff2dbb3b7fb4f0)
  build user:       root@42454fc0f41e
  build date:       20230725-12:31:24
  go version:       go1.20.6
  platform:         linux/amd64
  tags:             netgo,builtinassets,stringlabels

Prometheus configuration file
No response
Alertmanager version
No response
Alertmanager configuration file
No response
Logs
No response

Thanks for reporting. This seems to be a precision issue during the validation.


fix(balancer) added round-robin to algorithms enum

Summary

"round-robin" is now an available balancing algorithm, with the same behavior that was found in algorithm="consistent" and hash_on="none" combination before.
Added migrations to set new algorithm field values, according to existent hash_on values.
Added shorthands to the schema to keep backward compatibility in admin API and declarative config, avoiding inconsistent settings.

Also, FYI spec/02-integration/05-proxy/10-balancer/02-least-connections_spec.lua failed on Travis (see https://api.travis-ci.org/v3/job/563698245/log.txt )

Nice!


local vault don't support md default link

It only support ![[]] when I use my local vault.
But when I change to markdown default ![](), the image will not show correctly for local vault.

+1, much needed. I hope to also support custom layouts for local image files.

I'm sorry I missed this bug. I've merged a fix and will release an update shortly


Chess tutorial

use dojo-chess project a full tutorial project in dojo book

[X] [Building Onchain Chess Game

[X] [0. Setup]
[X] [1. Initiate]
[X] [2. Move]
[X] [3. Check legal]
[X] [4. Test Chess]

Can review the tutorial? cc @ponderingdemocritus


Game crashes upon startup

I genuinely have no idea what mod or mods are causing this. But, here, Here's the latest and debug logs. (I'm using Back in Classic 0.5.3 release)
P.S, Do you have a discord? This would be a bit easier to do  that way.
latest.log
debug.log

I do have discord, I didn't get the notification. Sorry!

Sorry for being absolutely absent.

I'll give you my discord so you can add yourself.
Phwee🧣#7974
Or you can find me as a moderator in CA.
(p.s, it works in 0.5.5)

Ok good, I will mark this as fixed then. Sorry about the delay!


Make the role of "leap seconds" more obvious in DateTime and Instant

There was a question on Facebook where the poster was surprised that for a range of given date times the DateTime.Instant.Int varied from the perl DateTime->epoch by an increasing amount.
Having looked at the documentation pages for both DateTime and Instant there doesn't appear to be anywhere where it is made explicit that leap seconds are in play at all, apart from the discussion of "Future Leap Seconds" in the Instant page.
It would probably be useful to have some introductory text in both DateTime and Instant that describes the role of the "leap seconds" and possibly also in the methods such as .posix which return the number of seconds describe why, due to the leap seconds, they will differ from .Instance.Int.
Haven't got any particular suggestions as to what the words should be.

Good idea.


Custom duration when option: html

When i set 'html' parameter, then duration sets to  --:--
var player =  plyr.setup(playerSelector, {                                 html: controls, })[0];
How i can set duration when i use custom controlls  ?

The controls don't effect the duration - the duration comes from the media itself. If you want to display duration, set duration to true in the config.

You can specify a custom duration if you need to over ride the one coming from the media file now if you need to using the duration option:
https://github.com/Selz/plyr/blob/master/readme.md#options


fix(api): graceful degradation for HTTP 204

If the Lacework API returns a 204, we get an EOF error when attempting to JSON decode.  This causes the UI to present an error even though the request was successful.
ALLY-479

This is nice! Could you add a quick test? Then we will be ready to merge. 🙌🏽 🎉

Absolutely.


App Store Images

For app store we'll need 5 of 1920 * 1080 images

1 http://cl.ly/image/1p2t0Y3h2a0w
2 http://cl.ly/image/1r0J2k3p4743
3 http://cl.ly/image/0F1b3F2Z2e2i
4 http://cl.ly/image/2x3P3X3D0W07
5 http://cl.ly/image/2X2i3d0E1H04

@katarinabatina Small typo on the fourth image!

thank's @owendodd haven't uploaded the edits yet will do in a moment

@owendodd @orta updated links up above

@katarinabatina :ok_hand:

These are shipped to iTunes


#383 KazooTimeoutError should inherit kazooException

leaving kazoo.protocol.connection.RWServerAvailable where it is since it's more a logical event handler than a KazooException.

I got the travis tests working on my fork https://travis-ci.org/Idem/kazoo/builds/151559078 but I had to restart some of the jobs (some timeout happened from time to time).
Can anyone with the proper wrights restart the failing jobs?

@bbangert Can you review this and trigger new travis build plz?

I don't understand why all the imports are being rewritten into this new style.
I do agree with the fundamental of this PR though, which is that the TimeoutError should inherit from KazooException so that someone catching Kazoo related exceptions can catch them all properly.
This changes seems problematic since it could break a lot of external code assuming it will get a TimeoutError. Perhaps the KazooTimeoutError should inherit from the original TimeoutError as well so that it's still caught by existing code.

Thanks for your feedback @bbangert

[ ] I'll put the previous import style back (Sorry for that. Habits from other projects).
[ ] KazooTimeoutError will now inherit from TimeoutError to preserve compatibility. That makes sense.
[ ] I'll move TimeoutError to kazoo.exceptions with others exceptions and still import in kazoo.handler.eventlet (avoiding cross import, and ensuring compatibility for scripts importing kazoo.handler.eventlet.TimeoutError).

I can also drop the 2 last points and leave the TimeoutError as it is in kazoo.handler.eventlet, if you prefer since it's outside of the scope of the issue.

Tests are passing on my forked branch (https://travis-ci.org/Idem/kazoo/builds/157704525)

Explicitly linking this to #383 :-).

Weird, why isn't this tested by travis?

Looks good, though for some reason the tests aren't running on it. Can you squash the commits and re-open the PR?

Done.
See https://github.com/python-zk/kazoo/pull/447


Sunstone Zendesk login does not work with special characters

Description
When trying to log in with the Zendesk account is giving errors if passwords have special characters.
To Reproduce
Go to the official support tab
Try to log in with a password with special characters.
Expected behavior
Can log in with the support account.
Details

Affected Component: Sunstone
Version: 5.12, 6.0, master

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

@tinova PRs to be applied:

Code
Docs 6.0
Docs 5.12


disable topic selected for hosted

Description
ui portion of following issue, disallows topic selected for hosted workflows since hosted workflows have no source control to pull topics from
Issue
https://github.com/dockstore/dockstore/issues/4591
Please make sure that you've checked the following before submitting your pull request. Thanks!

[x] Check that your code compiles by running npm run build
[x] If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
[x] Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
[x] If displaying markdown, use the markdown-wrapper component, which does extra sanitization
[x] Do not use cookies, although this may change in the future
[x] Run npm audit and ensure you are not introducing new vulnerabilities
[x] Do due diligence on new 3rd party libraries, checking for CVEs
[x] Don't allow user-uploaded images to be served from the Dockstore domain

UI counterpart of https://github.com/dockstore/dockstore/pull/5071


fix s6-overlays for proper CPU arch selection

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.Ruslan Ponomarenko seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

@xriser do you have to sign the CLA? Or why can't this be merged?


Request for draw canvas and add to stage as bitmap or sprite (for frames)

If redraw canvas on every "Draw" event is unnecessary, I need a way to draw and transform shapes dynamically into a canvas layer and flatten into a bitmap or sprite for frames that can be added to stage.
Currently, as far as my knowledge in creating component with canvasLayer with 100+ variations e.g. abstract arts animations.
Crafty.c("drawPlank", {
	init:function(){
        this.addComponent("2D,Canvas");
        this.bind("Draw", this.sdraw);  //Does it need to keep rendering with expensive call?
        this.ready=true
    },
    sdraw: function(e) {
    	var ctx=Crafty.canvasLayer.context;
    	var tan360=Math.tan( 0.2 );  //different angles/variations
        ctx.setTransform(1, tan360, 0,1,0,0);
        ctx.lineWidth = 8;
        ctx.beginPath();
        ctx.moveTo(e.pos._x, e.pos._y+20);
        ctx.lineTo(e.pos._x+50, e.pos._y+20);
    	ctx.stroke();
     }
});

Lokstar's answer might be interesting for Crafty.
http://stackoverflow.com/questions/23468218/draw-10-000-objects-on-canvas-javascript

I'm definitely interested in the idea of a way to render a component to a canvas, and then just use that as a texture.  I don't think it's conceptually very difficult, but it might require some refactoring under the hood.
I'm currently working on making the way we render to graphics layers a bit more flexible, this is a use case I'll try to keep in mind.

Great, creating awesome engine from the conceptual idea in your avatar + Google doodle style. Why don't you start drawing an owl to Egypt to Roman to China that will fly in span of 3,000 years?
or illusion animation using Layers.
Use pixel animation or distortion or even skew motion
http://www.effectgames.com/demos/canvascycle/
Lines
http://www.mta.me/
I think this song will give you much inspiration:
https://soundcloud.com/roni1990roni/e-s-posthumus-nara
Crafty.js need to expand into a bigger engine since you have the advantage that other game engines have forgotten or are too complicated to maintain, Phaser is an example.


External Community Call - 25th September 2024

Sign up: https://msit.events.teams.microsoft.com/event/2298b205-d7ef-4ad4-8e68-10915ba34291@72f988bf-86f1-41af-91ab-2d7cd011db47
Please leave comments below on topics you'd like covered

Hey @cjtous1,
thanks for the topics/questions we will discuss these on the call.
For the AMBA and EPAC integration guidance enhancements please raise an issue on the EPAC repo 👍


streams load balance

streams can add multiple hosts,as load balance
（translated from google）

Think the discussion is here and you might be able to find your answer too - https://github.com/NginxProxyManager/nginx-proxy-manager/issues/2917


Fix JHU's fips-population source file

use geocode utility source file and remove old static source file
update tests
update validation notebook to verify prop signals in NYC

It could've gone either way, but I switched the base to deploy-jhu because this PR primarily concerns the JHU indicator. Once we merge it, we'll propagate the changes to main.

That notebook isn't really supposed to be tracked. It was meant to be a template, but I kept working in the template and committed changes. I've reverted it back to its template version and renamed it accordingly.


[Bug] Builder with Quarry Card/Filter Fluid Interaction

RFTools: rftools-1.10-5.56.
McJty: mcjtylib-1.10-2.2.0
When using the builder as a quarry with a white-list filter, the builder still quarries fluids. If using a standard quarry card this means they get replaced with dirt instead of the expected behavior, being ignored.

Yes, I have also noticed this. Will fix for next version

Fixed next release


Feature/exempt recent images

Fixes #12
This adds a new optional parameter to keep a minimum number of images from the repository.
I also renamed the allow_tagged to respect golang camel casing.

Rebased and merged in:

https://github.com/sethvargo/gcr-cleaner/commit/ad980c7df7ffcca2d224d7ae86c4d8de1e661803
https://github.com/sethvargo/gcr-cleaner/commit/116767e180fa82621bb6bbce8e9f657734c79756
https://github.com/sethvargo/gcr-cleaner/commit/245479dfbf0d513b0112fd7698353d7c210d5423

Thanks!


Drag perf

Now noticeably slower than App Store version.

Maybe it is possible to not update offscreen views?

LazyVStack might help.

The grid lines in the Smith chart don't change unless display mode changes. Maybe they are being re-rendered?

Reverted the change to use LazyVStack because it was causing odd rendering issues where lazy parts would be faulted in, causing screen scrolling jumps.


Fix unintended SpinBox mouse capture

Initializes SpinBox drag variables to prevent the mouse from being captured if pressed outside the SpinBox and dragged inside.
Fixes #43608

Thanks!

Thanks!

Cherry-picked for 3.2.4.

Cherry-picked for 3.2.4.


Alignment issues in CLI(ncurses?) programs

Which operating system does the issue occur on?
GNU/Linux (Gentoo)
If on linux, are you using X11 or Wayland?
 Screenshots would describe this best, i guess:
https://ibb.co/x6gf8pr (upper right: htop without tmux, bottom right: htop with tmux)
https://ibb.co/6gxmyh2 (alsamixer, in shambles)
The config does not seem to matter(as it happens in default configuration)
debug output: http://dpaste.com/1F7RSWK
glxinfo: http://dpaste.com/0NK5XDV
rust: 1.35.0

@bananarne What's your alacritty version? ( alacritty --version ) and your $TERM variable ( echo $TERM ) when running alacritty without config?
I wasn't able to reproduce this on the latest master with default configuration ( tested xterm-256color and alacritty terminfos ), by running alacritty and just openning alsamixer/htop.

The problem occurred in: 0.3.2, 0.3.3_rc1 both compiled with rust 1.35
my TERM env-variable is xterm-256color aswell.
i don't know what terminfo excatly is, but i compiled alacritty with it.

Try setting your TERM to alacritty please. Also make sure no Alacritty config is present by running alacritty --config-file /dev/null.

Yeah, sorry, i was actually sure i checked the config being "clean".
I modified the tab size from 8 to 2 and this results in this behaviour.
Sorry.


[Bug]: Training hifigan on ljspeech results in FileNotFoundError for train.json

Describe the bug
When I start the hifigan training on ljspeech I get the error FileNotFoundError: [Errno 2] No such file or directory: './results/hifi_gan/1234/save/train.json'
I looked for the train.json and could not find it. I guess it should be created by the ljspeech_prepare.py script but it is not.
Expected behaviour
I expect the train.json to be created automatically when I start the training.
To Reproduce
No response
Versions
No response
Relevant log output
No response
Additional context
No response

Okay seems as if the training may not be started distributedly. Running on a single GPU does not result in the error.

Hi @padmalcom there is no reason why it could not be started with DDP.

Hi @TParcollet, thanks for taking a look. A single GPU training runs fine with this command:
python train.py hparams/train.yaml --data_folder=/home/user1/training
... while a distributed training fails with the mentioned exception. The command is:
python -m torch.distributed.launch --nproc_per_node=7 train.py hparams/train.yaml --distributed_launch --data_folder=/home/user1/training --distributed_backend='nccl'
Is there an issue with the arguments? I did not find any information on how hifi_gan is trained using DDP so I assumed it is similar to the tacotron2 training.

It is most likely a run_on_main missing somewhere. It may also crash if the whole data preparation is longer than 15 minutes due to some very slow NFS for instance. Indeed 15min, I believe, is the default maximum DDP waiting time for non-main process. Hence, if the main process is data_processing for longer than 15min, the others will continue and fail because the train has not been created yet.

The training (including the preprocessing) stops right after I submit the command so it is not a timeout. When I do the preprocessing with only one GPU and no usage of DDP, the data is processed find and if I interrupt and restart with DDP, the error is somewhat different:
=========WARNING=========: Please add sb.ddp_init_group() into your exp.pyTo use DDP backend, start your script with...
So ddp might not be initialized correctly... But that is only a guess.

@TParcollet a side note: we do not have a dedicated DDP testing - I can have a look into automating this AFTER the refactoring PRs are through. (That follow-up PR could be e.g. on reducing recipe testing time & DDP.)
The LJSpeech train recipe lacks the DDP init line - compare
https://github.com/speechbrain/speechbrain/blob/ff4366ac26a813e6f32b2f0ffd24d5d9c8a62aa7/recipes/CommonVoice/ASR/transformer/train.py#L379

Adding the mentioned line seems to do the trick. Thanks @anautsch. The json file(s) are created now, even with ddp.

FYI I created a short PR for this issue: https://github.com/speechbrain/speechbrain/pull/1781


tests: Add much beefed up alternative path for test framework

Depends: https://github.com/ostreedev/ostree-rs-ext/pull/248

tests: Add much beefed up alternative path for test framework
The main thing I want to get away from is hardcoded tarball fixtures.
I do want the commit digests we write to be reproducible, and
I also want the unit tests to work on a non-SELinux system.
This patch adds an alternative flow to the text fixture via new_v1()
that uses the native ostree APIs to write and generate commits.  We
mock up the SELinux labeling (and support labeling disabled).
I plan to drop the old path and hardcoded tar fixtures once this lands.

OK, this is isn't done, but let's merge it as a checkpoint - the new framework is opt-in behind new_v1() and only used in one test.  Porting all the tests I think should be done as a separate pass.


package com.imagepicker does not exist import com.imagepicker.ImagePickerPackage

i am working on "react-native": "0.55.4". i was implementing image picker but when i run it i got this error:
Task :app:compileDebugJavaWithJavac FAILED
D:\React Native App\xxx\android\app\src\main\java\com\xxx\MainApplication.java:10: error: package com.imagepicker does
not exist
import com.imagepicker.ImagePickerPackage;
^
1 error
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':app:compileDebugJavaWithJavac'.

Compilation failed; see the compiler error output for details.

Can anyone help?

I have the same problem in the same RN version.

getting this error after having upgraded from 2.X.X to 3.X.X ...
Running -rm -rf node_modules, ./gradlew clean, yarn install, ... nothing worked. Any ideas why ?

@MayoudP did you find a solution?

Hello Guyz

I am facing the same issue.

hello guy's i recently faced the same issue , i tried to uninstall the package and remove all add file in build.gradle and all , after that i checked my MainApplication.java and   --> import com.imagepicker.ImagePickerPackage; disable this then ./gradlew clean and yes it's working now .


The cursor position is lost

Issue Type: Bug
The current cursor position is lost in the tap when I switch from one tap to other tap.
This problem cause me to scrolldown every time I switch and is very
problematic when I have a long file.
SQL Operations Studio version: sqlops 0.31.4 (e026ab85a72c190cc4ccc834503aa9fe36dd6407, 2018-07-18T02:14:21.826Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i5-7600 CPU @ 3.50GHz (4 x 3504)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
7.87GB (2.13GB free)

Process Argv
C:\Program Files\SQL Operations Studio\sqlops.exe

Screen Reader
no

VM
0%

Extensions (1)

Extension
Author (truncated)
Version

profiler
Mic
0.1.2

@MrAlex6204 this issue should be fixed in the latest insiders build available at https://github.com/Microsoft/sqlopsstudio/releases/tag/<IP_ADDRESS>.  This will be in the next stable build later in August.  Please reactive if the issue persists on these builds.  Thanks!

Congrats this tool is awesome, I hope the graphs section can be more flexible in the future, is very useful.
SQuirreL is a DataBase client that has some useful things, I hope can be used as reference.
Regards


Remove iso8601 dependency

I've been going through the tuf dependency chain with an eye on integrating tuf with pip: The issue with pip is that it's a package manager so needs to vendor everything it needs -- so being conservative with dependencies is a good idea. The good news is that tuf does not have many direct or indirect dependencies that would be a problem (good work!).
The one that possibly sticks out is "iso8601". The module is currently used in two places:

repository_tool: Metadata.expiration property getter uses it to return a datetime object
updater.py: Updater::_ensure_not_expired()

I'm mostly interested in that last one. it's used to compare the expiration stamp to current time and to format the error message:
    expires_datetime = iso8601.parse_date(expires)
    expires_timestamp = tuf.formats.datetime_to_unix_timestamp(expires_datetime)

    if expires_timestamp < current_time:
      message = 'Metadata '+repr(metadata_rolename)+' expired on ' + \
        expires_datetime.ctime() + ' (UTC).'
      logger.error(message)

      raise tuf.exceptions.ExpiredMetadataError(message)

I'm not familiar with date handling in python so my question is: Is this dependency valid or could this code be replaced with something that did not depend on iso8601?

The spec says

Metadata date-time data follows the ISO 8601 standard. The expected format of the combined date and time string is "YYYY-MM-DDTHH:MM:SSZ". Time is always in UTC, and the "Z" time zone designator is attached to indicate a zero UTC offset.

My naive understanding is that because of the zero offset requirement this might be easy to parse with standard library functions.

That said, now that I've looked at iso8601 module itself... It's tiny, literally 215 lines of code. So vendoring it might not be a problem.

#1060 makes use of dateutil. A quick browse of their docs made me think we could probably replace iso8601 with functionality in dateutil.

The spec says

Metadata date-time data follows the ISO 8601 standard. The expected format of the combined date and time string is "YYYY-MM-DDTHH:MM:SSZ". Time is always in UTC, and the "Z" time zone designator is attached to indicate a zero UTC offset.

My naive understanding is that because of the zero offset requirement this might be easy to parse with standard library functions.

oh, that would be even better!

#1060 makes use of dateutil. A quick browse of their docs made me think we could probably replace iso8601 with functionality in dateutil.

For the pip use case dateutil would be worse than iso8601 as it's much larger -- but I guess #1060 wouldn't necessarily mean updater changes?

#1060 makes use of dateutil. A quick browse of their docs made me think we could probably replace iso8601 with functionality in dateutil.

For the pip use case dateutil would be worse than iso8601 as it's much larger -- but I guess #1060 wouldn't necessarily mean updater changes?

In the short term, no. However, my current thought process is that the work in #1060 could become a low-level abstraction around TUF metadata that we build client/updater and repository APIs on top of. Therefore I'd like to make/keep those APIs as minimal (with as minimal dependencies) as possible so that they can be comfortably vendored into pip.
Note to self (or whoever picks up this issue): look at the use of dateutil in tuf/api and figure out if we can achieve the same with the standard library. Specifically in tuf/api/metadata we're currently using dateutil.relativedelta to cleanly specify a number of days/months/years by which to bump metadata expiration.

Oh and for reference: securesystemslib does use dateutil but AFAICS only in one place in gpg code

💯 Thanks for looking into this.

The dateutil usage in securesystemslib does not appear to be necessary, so I created a PR to remove it secure-systems-lab/securesystemslib#268

Our new metadata model (#1112) avoids using iso8601, which we'll build upon for both the client and repository code during the course of our refactor

@joshuagl suggests to create a helper for the iso8601 replacing call
datetime.strptime(exires, "%Y-%m-%dT%H:%M:%SZ").replace(tzinfo=None)

I've just reviewed the iso8601 test suite and have come to the conclusion that using it is in fact not compliant with the (spirit of the) spec: current implementation allows for timestamps that I would not expect to work after reading the spec, such as "2006-10-20T15:34:56.123+02:30".
The spec currently says:

Metadata date-time data follows the ISO 8601 standard. The expected format of the combined date and time string is "YYYY-MM-DDTHH:MM:SSZ". Time is always in UTC, and the "Z" time zone designator is attached to indicate a zero UTC offset. An example date-time string is "1985-10-21T01:21:00Z".

I think the paragraph is fairly clear but first sentence could be better: we want to support only this very specific format of the ISO8601 not the whole iso8601 spec.
As for the implementation, I think the helper idea is good. I don't think the replace() call in the example is needed: the strptime format used does not allow for a timezone at all.

Adding one more thing: the Securesystemslib schema for "iso8601 datetime" is very strict: datetime can definitely parse that.
I think the review is over... but since there's good discussion here I'm not closing: I'll just rename this to "Remove iso8601 dependency"

I think the paragraph is fairly clear but first sentence could be better: we want to support only this very specific format of the ISO8601 not the whole iso8601 spec.

Great observation. Please send a PR to the spec 🙂


Set default name and save_dir for WandbLogger

Proposed refactor
Change the default name to "lightning_logs" and the default save_dir to "wandb".
https://github.com/PyTorchLightning/pytorch-lightning/blob/60fe1520fd8ac8fa9006237f31045465200c9803/pytorch_lightning/loggers/wandb.py#L252-L253
Motivation
Currently the name and save_dir properties on the WandbLogger default to None.  This causes several issues in the directory structure as shown in the image below:

The main logging directory is named None which is an odd name for a directory to store logs
Wandb already automatically creates a directory called wandb which contains metadata. It is weird to have two separate logging directories for Wandb - let's instead default to storing everything in one. Plus, the doc literally says the save_dir is wandb by default, which is not true at the moment:
https://github.com/PyTorchLightning/pytorch-lightning/blob/60fe1520fd8ac8fa9006237f31045465200c9803/pytorch_lightning/loggers/wandb.py#L221
The profiler output is unable to save to a path since the logger's save_dir is None, and we get the error The PyTorchProfiler failed to export trace as dirpath is None
A fourth issue, but one that is not addressed by this proposed change, is that the subdirectory is named "version_None" which is also an odd name for a directory. This is because version defaults to None for WandbLogger.

How the directory structure will look after this change:

cc @awaelchli @morganmcg1 @AyushExel @borisdayma @scottire @manangoel99

Wandb already automatically creates a directory called wandb which contains metadata. It is weird to have two separate logging directories for Wandb - let's instead default to storing everything in one. Plus, the doc literally says the save_dir is wandb by default, which is not true at the moment:
https://github.com/PyTorchLightning/pytorch-lightning/blob/60fe1520fd8ac8fa9006237f31045465200c9803/pytorch_lightning/loggers/wandb.py#L221

It's typically a bad idea to put files within the wandb folder as it is used to upload logs and files internally.
You could have a risk of having wandb process trying to log them (even if model checkpoints are already logged separately through artifacts).
wandb folder is mainly used for offline use (and later sync), for uploading files/media/objects and for debugging.

@borisdayma thanks for the info! good to know. so we will not put it in the wandb folder then. But I still think we should give it a default name other than None

I tried recreating this issue with the latest versions of wandb and pytorch-lightning and it got fixed. I think we can close this.


Recipe/Item visibility

JEI does not show the items at all. And the item recipes are not in the vanilla recipe book. Also not available in the creative menu. I legitimately thought I didn't have the mod installed until I tried to install it again. Funny enough the config is still there and I can get the items through console commands. But I can only get the items through manually placing the crafting items in the right slots by referencing the images on the modpage, and using console commands. Game version 1.20.1

I did a bunch of looking around across like 50 different reddit forums and quora posts and all that fun stuff. And found it was a forge problem that pretty much everyone can have, and is a hit or miss thing. But the fixes are pretty easy.
Fix 1: https://www.reddit.com/r/CreateMod/comments/1dggv32/comment/l8sxg4p/?context=3&share_id=xb8u08kjwtPnYObbS4k_A&utm_content=1&utm_medium=ios_app&utm_name=ioscss&utm_source=share&utm_term=1
Fix 2: https://github.com/Creators-of-Create/Create/issues/6222#issuecomment-2142451391
I personally used both, and fix 1 is more flexible for new mods and acts as just a secondary failsafe. But I definitely recommend getting both as it doesn't hurt anything if you do. Only benefits. Hope this helps anyone else!

Should i do anything with this?


Importing aws:lambda:/function:Function resource inputs failed to validate

What happened?
When I try to import an aws:lambda/function:Function resource I receive warnings that one of 'filename, image_uri or s3_bucket' values must be set for 'S3Bucket, imageUri or code'. The resource does import succesfully and gives me the output code for it but execution fails with the following errors:
error: aws:lambda/function:Function resource '<my_lambda_function>' has a problem: Invalid combination of arguments. "s3_bucket": one of `filename,image_uri,s3_bucket` must be specified. Examine values at '<my_lambda_function>.s3Bucket'.
error: aws:lambda/function:Function resource '<my_lambda_function>' has a problem: Invalid combination of arguments. "image_uri": one of `filename,image_uri,s3_bucket` must be specified. Examine values at '<my_lambda_function>.imageUri'.
error: aws:lambda/function:Function resource '<my_lambda_function>' has a problem: Invalid combination of arguments. "filename": one of `filename,image_uri,s3_bucket` must be specified. Examine values at '<my_lambda_function>.code'.

Example
This is the output when I import the Lambda Function resource:
pulumi import aws:lambda/function:Function <my_lambda_function> <my_lambda_function>
Previewing import (<stack_name>):
     Type                    Name                                                              Plan       Info
     pulumi:pulumi:Stack     aws-<stack_name>
 =   └─ aws:lambda:Function  <my_lambda_function>  import     4 warnings

Diagnostics:
  aws:lambda:Function (<my_lambda_function>):
    warning: One or more imported inputs failed to validate. This is almost certainly a bug in the `aws` provider. The import will still proceed, but you will need to edit the generated code after copying it into your program.
    warning: aws:lambda/function:Function resource '<my_lambda_function>' has a problem: Invalid combination of arguments. "image_uri": one of `filename,image_uri,s3_bucket` must be specified. Examine values at '<my_lambda_function>.imageUri'.
    warning: aws:lambda/function:Function resource '<my_lambda_function>' has a problem: Invalid combination of arguments. "filename": one of `filename,image_uri,s3_bucket` must be specified. Examine values at '<my_lambda_function>.code'.
    warning: aws:lambda/function:Function resource '<my_lambda_function>' has a problem: Invalid combination of arguments. "s3_bucket": one of `filename,image_uri,s3_bucket` must be specified. Examine values at '<my_lambda_function>.s3Bucket'.

Resources:
    = 1 to import
    695 unchanged

Do you want to perform this import? yes
Importing (<stack_name>):
     Type                    Name                                                              Status               Info
     pulumi:pulumi:Stack     aws-<stack_name>
 =   └─ aws:lambda:Function  <my_lambda_function>  imported (0.03s)     4 warnings

Diagnostics:
  aws:lambda:Function (<my_lambda_function>):
    warning: One or more imported inputs failed to validate. This is almost certainly a bug in the `aws` provider. The import will still proceed, but you will need to edit the generated code after copying it into your program.
    warning: aws:lambda/function:Function resource '<my_lambda_function>' has a problem: Invalid combination of arguments. "image_uri": one of `filename,image_uri,s3_bucket` must be specified. Examine values at '<my_lambda_function>.imageUri'.
    warning: aws:lambda/function:Function resource '<my_lambda_function>' has a problem: Invalid combination of arguments. "s3_bucket": one of `filename,image_uri,s3_bucket` must be specified. Examine values at '<my_lambda_function>.s3Bucket'.
    warning: aws:lambda/function:Function resource '<my_lambda_function>' has a problem: Invalid combination of arguments. "filename": one of `filename,image_uri,s3_bucket` must be specified. Examine values at '<my_lambda_function>.code'.

Resources:
    = 1 imported
    695 unchanged

Duration: 5s

And this is the output when I try to execute the code using a 'pulumi preview':
Previewing update (<stack_name>):
     Type                    Name                                                              Plan     Info
     pulumi:pulumi:Stack     aws-<stack_name>
     └─ aws:lambda:Function  <my_function>           3 errors

Diagnostics:
  aws:lambda:Function (<my_function>):
    error: aws:lambda/function:Function resource '<my_function>' has a problem: Invalid combination of arguments. "s3_bucket": one of `filename,image_uri,s3_bucket` must be specified. Examine values at '<my_function>.s3Bucket'.
    error: aws:lambda/function:Function resource '<my_function>' has a problem: Invalid combination of arguments. "image_uri": one of `filename,image_uri,s3_bucket` must be specified. Examine values at '<my_function>.imageUri'.
    error: aws:lambda/function:Function resource '<my_function>' has a problem: Invalid combination of arguments. "filename": one of `filename,image_uri,s3_bucket` must be specified. Examine values at '<my_function>.code'.

Output of pulumi about
Backend
Name           <backend_name>
URL            <backend_url>
User           <user_name>
Organizations
Token type     personal

Dependencies:
NAME        VERSION
boto3       1.28.53
fabric      3.2.2
pip         22.3.1
psutil      5.9.5
pulumi-aws  6.4.0
requests    2.31.0
setuptools  65.5.1
wheel       0.38.4

Pulumi locates its logs in /tmp by default

Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@sandervb2 Thank you for reporting this issue and sorry for the trouble.
I suppose there is a problem somewhere in our Read implementation - either because we renamed the original property "filename" to "code", or because its type is Archive.
To unblock yourself, you probably need to specify the code property of your Function in the snippet that Pulumi generated.

Actually, it looks like we are already tracking the same issue in https://github.com/pulumi/pulumi-aws/issues/2392. I'll close this new issue as duplicate, let's track it in there.


Allow building C binding out of the box

If I missed something, my apologies, please point me in the right direction.
I would like to wrap this library in Perl. For that I need the C binding built as a dynamic library. This seems not to be supported out of the box.
I added a simple Makefile for my own purposes, and have no problem in creating a pull request for it. But since the project uses cmake, perhaps you would rather do this differently?
Thanks!

The default out-of-box dynamic library should export both the C and C++ bindings and install headers for both. The C headers are in a subdirectory called c, so if you've installed graphqlparser's headers in /usr/local/include/graphqlparser and have that in your include path, you'd import them like #include <graphqlparser/c/GraphQLParser.h>

You are absolutely right. Thanks for pointing me in the right direction!


CPS: crash in compilation of constructor super initializers---no selector

tools/test.py -mrelease --host-checked --cps-ir -cdart2js -rd8 pkg/js_ast/test/printer_callback_test
This test crashes because it hits a superclass constructor call in an initializer list and the superclass constructor has a null selector.
@asgerf @karlklose

https://codereview.chromium.org/1200823002/


Add __meta_kubernetes_service_port_number in kubernetes_sd_config

When using the pod role type, we have __meta_kubernetes_pod_container_port_name and __meta_kubernetes_pod_container_port_number, but in service role there is only __meta_kubernetes_service_port_name and no __meta_kubernetes_service_port_number. If the port name is not set or it's difficult to remember the port name, port number will be very convenient. Could I open a PR to add __meta_kubernetes_service_port_number？

Thanks, @brancz , I will open a PR in a couple of days.
Should I add __meta_kubernetes_endpoint_port_number together?
I notice that in endpointslice role, it has __meta_kubernetes_endpointslice_port label, maybe we should use a unified label name, _port or port_number, which one is better?

Thanks, @brancz , I'm working on it.

#11002 is merged.


swift-collections-benchmark often fails on M1

In attempting to replicate the graphs from the announcement blog, I've found swift-collections-benchmark to be unreliable on an M1 Mac mini. I've only been able to run a single cycle so far, as any attempt at more than 1 always fails.
Information

Package version: main
Platform version: macOS 11.2.3
Swift version: Xcode 12.5b3, Apple Swift version 5.4 (swiftlang-1<IP_ADDRESS> clang-1<IP_ADDRESS>)

Checklist

[x] If possible, I've reproduced the issue using the main branch of this package.
[x] I've searched for existing GitHub issues.

Collecting data:
  1.2.../../Utils/run-benchmarks.sh: line 11: 40819 Trace/BPT trap: 5       swift run --package-path "$srcroot" $flags swift-collections-benchmark "$@"

Expected behavior
Successful benchmark run, as I did on my Intel iMac.
Actual behavior
1.2.../../Utils/run-benchmarks.sh: line 11: 40819 Trace/BPT trap: 5       swift run --package-path "$srcroot" $flags swift-collections-benchmark "$@"

Same result with Xcode 12.4.

Ah, I thought I fixed this already -- this usually means that the clock is reporting that a benchmark task has finished in 0 seconds. I may have forgot to land the workaround.
Meanwhile, a quick fix is to set a minimum size -- even something low like 4 elements may nudge it beyond the critical time.


Remove Unneeded ESLint Line Flag

Sigh, seems to be failing because of npm install issues.

Thanks!


fix setup.py such that it won't crash if missing numpy/cython when using pip

Right now, if doing pip install pykrige it'll fail if you don't have Cython or numpy installed before running the pip command.

@MasterOdin Thanks for contributing!
I have mixed filling about this. I agree that PyKrige should install even if Cython is not installed, that part is ok.
However, IMO it's not such a good idea to try to install numpy/scipy automatically with pip when running setup.py, and it's better instead to specify them as hard dependencies for the user to install manually. See for instance the installation instructions for sckit-learn.

We don’t recommend installing scipy or numpy using pip on linux, as this will involve a lengthy build-process with many dependencies. Without careful configuration, building numpy yourself can lead to an installation that is much slower than it should be. If you are using Linux, consider using your package manager to install scikit-learn. It is usually the easiest way, but might not provide the newest version. If you haven’t already installed numpy and scipy and can’t install them via your operation system, it is recommended to use a third party distribution.
as this could also lead to obscure BLAS/LAPACK errors (as the one currently in Travis-CI output). On Windows/Mac users should use a scientific python distribution (e.g. anaconda) anyway for performance and mixing pip with conda install is not the best idea either.

So I think that keeping a import numpy in setup.py may not be such a bad idea. At least the resulting error is straightforward and makes it user's responsibility to properly install numpy/scipy dependencies, depending on his OS & python environment.
@bsmurphy What do you think?

I wasn't aware of that about numpy and scipy. I guess in that case, should add a hard check at the top of the setup for both of these that throws an ImportError with "Missing Numpy. Please install this for your OS before installing PyKrige. Instructions can be found at http://scipy.org/install.html" instead of just the default ImportError python would throw when it failed to load numpy.

Sorry for the delayed response... I agree with @rth on this one, I think forcing an install of the dependencies through the setup script isn't the best thing to do. Installing numpy, scipy, and matplotlib through pip can unleash all sorts of trouble (especially for matplotlib). I like the idea of throwing a custom error with directions to the user to install these dependencies separately much better.

I also do like the changes to continue installation without having Cython installed. I think that's a really good idea.

I've modified this to then have a check for the three requirements to be "hard" requirements so that it'll print out an error message and then die if missing any of them, pointing to the install page for the SciPy stack. I'm not sure why Travis is failing as conda should have all three of these packages installed already?

Not sure what's happening with travis-ci: I'm not able to login anymore and the public build page shows "The repository at bsmurphy/PyKrige was not found."  Maybe they have some service issues, let's ignore that for the moment. I manually checked that the installation works fine on Linux (and appevyor build is still ok for Windows). Looks good to me: let's merge it.

It looks like, for some reason, the check for the hard dependencies itself is failing -- in the Travis CI output, the little message that @MasterOdin has appear when import(*) fails is in fact appearing, even though the three base dependencies are installed in the virtual environment...
Since @rth has confirmed that it works on Linux I'm going to go ahead and merge. We can deal with any other problems from there...
Thanks @MasterOdin! Very useful contribution.

@rth, can you see the Travis CI output from the tests on the master branch? Looks like setup.py is failing in both Python 3 and Python 2 for some weird reason that I can't easily figure out...


Transitioning Google URL Shortener to Firebase Dynamic Links

https://developers.googleblog.com/2018/03/transitioning-google-url-shortener.html

I want to take this up. please let me know.

@obscure76 Sure, go ahead!

Firebase dynamic links are not exactly a URL shortening service.
https://firebase.google.com/docs/dynamic-links/
From the documentation, "With Dynamic Links, your users get the best available experience for the platform they open your link on.".
May be we should move to bit.ly ?

Hi !
I have started to work on this. Are you already done @obscure76 ?
Also what did we decide on Firebase V/S bit.ly ?

I did not complete it. I was waiting for @swapagarwal . I feel we should go with bit.ly. what do you think?

I also feel given our use case bit.ly is more suitable (Not sure about how complicated it is to integrate with it's API's though).


Dockerfile

@artyom

Thank you! Just did it a bit differently with never version: https://github.com/Doist/s3logger/commit/56f80e719f91b4b25c45cd9adec801bdcf8182ac


please bump pypi version

Hey,
this project is great and will save me a lot of work - thank you for all the effort!
But currently https://pypi.org/project/bind9-parser/ lists version  0.9.8, released: Nov 23, 2019 as latest -- and this version cannot parse my nzf files created by bind. Could you bump the version?
I noticed in order to pip install from git I needed this change to the pyproject.toml:
 [build-system]
-requires = ["pyparsing >=2.4.5"]
+requires = ["pyparsing >=2.4.5", "setuptools>=40.8.0"]
+build-backend = "setuptools.build_meta:__legacy__"

I am closing this as 'WontFix' due to PyPi.
But am creating another issue to deal removal from PyPi.


Update Usage Information

Request for updating the "usage: proploader" information:
from this:
usage: proploader

to this:
usage: proploader [options] [<file>]

and from this:
         [ -e ]             program eeprom

to this:
         [ -e ]             program eeprom (and halt, unless combined with -r)

and from this:
         [ -r ]             run program after downloading

to this:
         [ -r ]             run program after downloading (useful with -e)

Done.


How to make it work in the browser

I am trying to bring it in an HTML file as CDN to work in the browser and get the attachements out of an uploaded .eml file.
But there are require statements in the the Eml Parser code that prevent it to work from the browser
I tried a few bundlers, but they still contain the require statements
Do you have any suggestions on how to do it ?

@xiaoran-MENG  this uses nodejs streams so it won't work in browser, you are free to look at the code and copy the implementation for eml and msg after loading the file in browser however u like.


Really slow since update a couple of days ago

A couple of days ago I updated the plugin and now my NerdTree is barely usable. I used the vim profiler and this function uses lots of time:
    8  39.638394  39.621555  NERDTreeGitStatusRefresh()

How can I help to debug this?

Wired. I did nothing before yesterday. Do you work under a directory with lots of files?
Please show me the output of  git status -s --ignored

Hm...could also be since yesterday? Not sure. The git command shows a nice output that I don't want to disclose here because I am working on a rather large private codebase for a company right now. The time command says this:
git status -s --ignored  0.32s user 1.40s system 26% cpu 6.408 total

This is part of the output without paths:

This seems to be result of showing tons of ignored files. You can checkout the previous version temporary. I will add a configurable var to turn on/off this feature later.

Awesome. Thank you!

Can confirm that I'm experiencing this as well. I think in my case because I have an ignored node_modules folder (which is huge).

I just added a switch var g:NERDTreeShowIgnoredStatus(0 default).
See more details in 76cd21b1259d2242edce3d62247d0b7b5c77e33e

Awesome. Thanks!

Any details on how we can update the performance of using IgnoredStatus? I'd really like to have something like that in nerdtree, would make it much more obvious if a file is ignored or not (which is currently not visible at all).
I suspect that the performance penalty in my case was due to the node_modules folder, which it probably tried to parse completely (instead of stopping at the top-level folder, which is already ignored). Could this be solved by optimising the parsing/setting of an ignored status?
@poberherr, @runoshun

This doesn't seem to work for me. Indeed the use of --ignored leads to the git status call taking over 10 seconds to complete, it's a dealbreaker for sure in this particular repo I have here.
What's concerning is that this blockage leads to extreme sluggishness in the other buffers in vim, but it is not true blockage, as it still responds to my movement commands within one second.
So, something is wonky here.
I did confirm that the performance penalty is lifted when I remove nerdtree-git-plugin from vim, so it is SOMETHING in this repository that causes massive slowdown when in a large repository tree. For the time being I'm looking into alternatives to NERDtree.

It slowed down neovim for me, too, so I've just removed this plugin, fixes my problem. Too bad.

Installed it this week. vim has become very slow during editing. Did profiling and found this:
FUNCTIONS SORTED ON TOTAL TIME
count  total (s)   self (s)  function
 1700  85.322661  42.386813  159()
   21  31.089606   0.001941  <SNR>49_CursorHoldUpdate()
 3005  29.198246   0.047503  37()
 3005  27.180360   1.148078  3()
99243  26.001736   1.072590  31()
205374  25.802976  10.675909  39()
204660  14.423497   7.101849  44()
 1301  12.402823   0.019071  127()
207665   6.067426   4.679387  33()
 2961   3.693131   3.495866  130()
415333   2.749236             nerdtree#runningWindows()
 3005   1.970383   0.145710  262()
   21   1.940812   0.000404  NERDTreeRender()
   21   1.940408   0.000186  nerdtree#renderView()
   21   1.940222   0.000399  230()
   21   1.939823   0.006460  251()
 3005   1.733434   0.114326  NERDTreeGitStatusRefreshListener()
 3005   1.604585   0.387397  NERDTreeGetGitStatusPrefix()
   21   1.364450   0.000459  129()
   24   1.304699   0.009981  <SNR>139_AutoUpdate()

Without this plugin and doing same operations:
FUNCTIONS SORTED ON TOTAL TIME
count  total (s)   self (s)  function
   57   7.075442   0.029403  <SNR>138_AutoUpdate()
    5   5.359748   0.002134  <SNR>61_UpdateErrors()
    5   5.344581   0.003847  <SNR>61_CacheErrors()
    6   5.303772   0.003203  syntastic#util#system()
    5   5.016568   0.000211  280()
    5   5.015975   0.001244  279()
    5   5.012961   0.000706  SyntaxCheckers_javascript_eslint_GetLocList()

Look like we are invoking some methods on the order of 200K when editing just 2 lines of a file.

noticed this as well.  My issue seems to occur when the autocmd CursorHold event / s:CursorHoldUpdate fires.  Any pauses in the cursor that hit updatetime block the UI which can be pretty bad depending on the directory size -- could just boil down to how slow NERDTree is at refreshing on large directories -- will have to dig into it more later


MF-415 - Merge mProxy support

Signed-off-by: Nikola Marcetic<EMAIL_ADDRESS>What does this do?
It adds mproxy support which was experimentally on separate branch #1017.
Which issue(s) does this PR fix/relate to?
Resolves #415
List any changes that modify/break current functionality
NA
Have you included tests for your changes?
No. It will be added in separate PR.
Did you document any new/modified functionality?
No. It will be added in separate PR.
Notes
NA

Codecov Report

Merging #1045 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1045      +/-   ##
==========================================
- Coverage      79%   78.97%   -0.04%
==========================================
  Files          95       95
  Lines        6622     6622
==========================================
- Hits         5232     5230       -2
- Misses       1078     1080       +2
  Partials      312      312

Impacted Files
Coverage Δ

things/service.go
88.97% <0%> (-1.48%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b5d512...c14f532. Read the comment docs.