Add nodeName field to PodPolicy

kubeadm is current affected by https://github.com/kubernetes/kubernetes/issues/45717 which prevents any pod from being scheduled on a node without any CNI solution (kubeadm allows users to install SDN after init). The workaround is to use DaemonSets for the control panel, since it bypasses the scheduler.
In order to bypass the scheduler for normal pods, we need to set the nodeName for the pods in the etcd-clusters. When https://github.com/kubernetes/kubernetes/pull/42406 is fixed, kubeadm can remove this constraint, but I think it's an okay compromise for the time being.

I didn't catch the problem. So what are you trying to achieve?

kubeadm does not deploy flannel or weave, meaning that the node is marked as NotReady, so no pods can be scheduled to them. In order for kube-etcd-0000 to be deployed by the operator, it needs a nodeName to exist in the PodSpec.

Proposed solution is to add a field to the spec and then ensure it exists in the PodSpec for the pod here. I can submit a PR tomorrow

kubeadm does not deploy flannel or weave, meaning that the node is marked as NotReady

Why is the node marked "NotReady"?

It's a known bug: https://github.com/kubernetes/kubernetes/issues/45717.
If a CNI network isn't set up, kubelet marks all nodes as NotReady. kubeadm doesn't deploy flannel during the init phase - it lets the user pick a network provider afterwards. This is a deliberate design choice to be vendor agnostic.
For v1.8 we're working on adding more granular taints that will solve this problem. But for now, setting spec.nodeName on the Pod will bypass the scheduler.

/cc @luxas

This would be super handy @hongchaodeng @xiang90 and is currently a blocker for adding support for self-hosted etcd in kubeadm.
As @jamiehannaford said -- no Pod besides those created by a DaemonSet can be scheduled when there is no CNI network, due to that the scheduler filters out all NotReady nodes and the node goes NotReady when CNI is uninitialized.

@jamiehannaford @luxas
To be honest, I do not feel comfortable to bypass the scheduler for just the initial placement. We do have plan to let the operator to assign pods to nodes for good reasons, and what you describe is one of them. But I do not have time to write the full story at the moment.
Adding a random feature to the etcd operator to fix a short term blocker is really not the way to go forward.

@xiang90 Thanks, this is actually the answer I wanted to hear -- just wanted to test if you'd agree or not with that statement :)
I'm very fine with letting k8s fix the issue

That's fair enough. I'll close this and focus efforts on the upstream solution.


Add $PATH and quarkc module checks to quark installer

Fix for Issue #134

Hm. I can't quite remember if quarkc correctly imported in the case I saw, or if the lingering directory would just prevent a later-correctly-installed quarkc from importing when it should.
Given that I'm not certain that a more heroic check (i.e. walking sys.path looking for anything named quarkc) is actually necessary, and that I am certain that it would be slow as well as annoying to code, I'm giving this a thumbs-up. We can add more checks if we find that they're needed.


LuckPerms breaks XenoPanel [Sponge]

Hi,
I am setting up a modded server using sponge and luckperms, however when luckperms is installed the panel breaks.
I realize this makes absolutely no sense and am contacting xenopanel as well, but if you have any suggestions let me know.
I am using spongeforge build 2312 and luckperms 3.1.45

Need to see an error message to be able to help. This doesn't look like an issue which could be caused by a plugin.


Add siege weapon actor type

Vehicle actors need a vehicle type of “Object” as an enhancement.
Further, if there are no values for dimensions, the UI that shows the dimensions should be removed.

Siege weapons should probably be handled by a new actor type, not the vehicle type, because they don't have passengers, crew, cargo, speed, or initiative.

I agree. For now, I built them as vehicles, which seems to work fine for now. When you have a chance to release the new actor type, it is simple enough for me to change these over.

Winged Dragon Vehicle has a reaction.  Per KP, it is possible that future vehicles may have similar generic text to restrict the use of a bonus action.
fvtt-Actor-winged-dragon-WMYZewAervWnyDkL.json


Remove GWS.CHAT.5.1

🗣 Description
Remove Chat.5.1 as Chat apps are now also controlled by the marketplace settings (see CommonControls.11.1).
💭 Motivation and context
Fixes #222
Google Update

🧪 Testing

✅ Pre-approval checklist

[ ] This PR has an informative and human-readable title.
[ ] Changes are limited to a single goal - eschew scope creep!
[ ] If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
[ ] The relevant issues PR resolves are linked preferably via closing keywords.
[ ] All relevant type-of-change labels have been added.
[ ] I have read and agree to the CONTRIBUTING.md document.
[ ] These code changes follow cisagov code standards.
[ ] All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
[ ] Tests have been added and/or modified to cover the changes in this PR.
[ ] All new and existing tests pass.

✅ Pre-merge Checklist

[ ] This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
[ ] Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

[ ] Delete the branch to clean up.
[ ] Close issues resolved by this PR if the closing keywords did not activate.

@adhilto This PR is still waiting to be reviewed.

Going back to the original discussion of this policy. Chat 5.1 is currently contradictory to our current stance with Common Controls 11.1. If Common Controls 11.1 allowlisting is not enforced, then turning this setting on allows any user to install any chat app. Which is insecure.
It seems that we should either delete this baseline and enforce Common Controls as a SHALL but leave the decision to enable this setting up to organizations/agencies
OR
We should rewrite this policy to make it organizational unit specific. example:
The ability to install Chat apps SHALL be disabled for the top-level organizational unit

_Note:_ The ability to install Chat apps MAY be enabled on a per OU basis.

This is to prevent the default of allowing anyone to install Chat apps if App allowlisting is not enforce but allow flexibility for specific organizational units to install chat applications.

I agree with David on this one. I'll also add that per the research you documented here:

"If the new feature is turned on, but the app IS NOT allowlisted, then only admins are allowed to install the app for the org." Acceptable from a security standpoint.
"If the feature is turned on and the app IS allowlisted, then both admins and users can install." Acceptable from a security standpoint.
"If the new feature is off, then the app cannot be installed." Also acceptable from a security standpoint.

Therefore, my vote would be that we delete CHAT.5.1 entirely.

@adhilto @buidav I can tell neither of you have actually research this setting at all. Turning this setting on does not override Common Controls 11.1. In the contrary, turning this off does not allow users to install any chat app. Turning this feature one allows users to install allowlisted chat apps.
In the future, please make sure to understand the setting before commenting.

My vote would be to make this policy a SHOULD because if there is no need for users to have chat apps, then it should be disabled to protect the org.

@adhilto, Also I realized that the PR changes did not reflect what my recommendation was, so went in ad commited the updated policy statement.

@adhilto, Also I realized that the PR changes did not reflect what my recommendation was, so went in ad commited the updated policy statement.

Thanks for pointing that out, that completely changes the discussion.

@adhilto @buidav Turning this setting on does not override Common Controls 11.1.

David did not claim that it does. His point was that if Common Controls 11.1 was not implemented and this setting were on, users could install any Chat app. I haven't tested this myself but it certainly seems like that would be the case. Regardless, since you updated it from "SHOULD be enabled" to "SHOULD be disabled," this point is no longer important.

Not allowing any user to install any app could be a hinderance to the user.

Hindrance, yes. Security risk? No. Though it is a reason for why we wouldn't want to require this setting be disabled, which is now the current recommendation.
Weighing both sides of the issue, the reason for including 5.1 "SHOULD be disabled" is as follows:

Defense in depth. Yes, COMMON.CONTROLS.11.1 would prevent non-approved apps from being installed (per your research here ), but to David's point, what if COMMON.CONTROLS.11.1 is not implemented? Disabling the setting in question for CHAT.5.1 would ensure that even in that case, unapproved Chat apps could not be installed.

Reason for enabling "Allow users to install Chat apps":

The usability cost in setting that to OFF is quite high, because as you indicated here, this would completely prevent all Chat apps from being installed, even if the app is allow listed.

Weighing both those two points, I'm inclined to think that this is a setting that we need don't need to take a stance on. Since the security benefit is so minimal and the usability cost so high, each agency should be permitted to weigh the tradeoffs themselves and make their own decision. In other words, I'm still in favor of cutting this control.
That said, as the interactions between these two settings isn't immediately obvious, it could be useful to document and explain this somewhere, so that agencies are able to make an informed decision. We should not mandate that this setting be ON or OFF though.

We will go ahead an remove CHAT.5.1v0.2 and make COMMONCONTROLS.11.1v0.2 a SHALL.

Policy Group 5 has been removed. @adhilto Ready for review again.

Policy Group 5 has been removed. @adhilto Ready for review again.

Just need to update the table of contents. Other than that looks good.

@buidav I just implemented the Rego changes, ready for your review.

@adhilto @buidav I have updated the Table of Content.

@adhilto @buidav Any finals thoughts on this or are we good to merge? I think all changes requested were handled.


Fix 1231 nullable

Information

Type
Breaking change

Feature/Fix
No

:tada: This PR is included in version 6.25.0 :tada:
The release is available on:

v6.25.0
GitHub release

Your semantic-release bot :package::rocket:


bugfix: 修复重复收集相同的自动触发任务的问题 (fixed #1)

Codecov Report

:exclamation: No coverage uploaded for pull request base (V2.1.344rc@0d17c92). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             V2.1.344rc      #87   +/-   ##
=============================================
  Coverage              ?   58.91%
=============================================
  Files                 ?      394
  Lines                 ?    25918
  Branches              ?        0
=============================================
  Hits                  ?    15269
  Misses                ?    10649
  Partials              ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d17c92...226f100. Read the comment docs.


Update schema version

since we added some categories lately
also release a new tag

Ah, you're right. We've forgotten that multiple times.


datacube-explorer not finding all the datasets

I have a datacube with sentinel-2 cloud masks covering the Alps region for some years. There are around 19000 datasets in the datacube. However, datacube-explorer shows only part of them. I've already tried to update the explorer db, see the following output where it finds only 4228 datasets. See also the output from datacube python where it correctly finds all the data (and I can also load it).
What should I try/change?
~/datacube-explorer$ cubedash-gen --init --all
/home/user/anaconda3/envs/odc/lib/python3.6/site-packages/flask_caching/__init__.py:192: UserWarning: Flask-Caching: CACHE_TYPE is set to null, caching is effectively disabled.
  "Flask-Caching: CACHE_TYPE is set to null, "
Initialising schema
Updating 5 products for LocalConfig<loaded_from=['/home/user/.datacube.conf'], environment='datacube', config={'db_hostname': 'localhost', 'db_database': 'datacube', 'db_username': 'user', 'db_password': '***', 'index_driver': 'default', 'db_connection_timeout': '60'}>
Generating product summaries...
s2cloudless_alps done: (4228 datasets)
done. 1/1 generated, 0 failures
Refreshing statistics...done

dc = datacube.Datacube(app = "Sentinel", config =<EMAIL_ADDRESS>query = {}
query['product'] = 's2cloudless_alps'
print(len(dc.find_datasets(**query)))
>>> 19767

Thanks to @AurelioVivas on opendatacube Slack channel suggesting the following command, which solved the problem:
cubedash-gen --force-refresh <product-name>


problems with ansible

on clear ubuntu apt-get install php5 works fine, but on your version sources.list i got this:
...#apt install php5
Reading package lists... Done
Building dependency tree
Reading state information... Done
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 php5 : Depends: libapache2-mod-php5 (>= 5.6.13+dfsg-1+deb.sury.org~trusty+3~) but it is not going to be installed or
                 libapache2-mod-php5filter (>= 5.6.13+dfsg-1+deb.sury.org~trusty+3~) but it is not going to be installed or
                 php5-cgi (>= 5.6.13+dfsg-1+deb.sury.org~trusty+3~) but it is not going to be installed or
                 php5-fpm (>= 5.6.13+dfsg-1+deb.sury.org~trusty+3~) but 5.5.9+dfsg-1ubuntu4.11 is to be installed
        Depends: php5-common (>= 5.6.13+dfsg-1+deb.sury.org~trusty+3~) but 5.5.9+dfsg-1ubuntu4.11 is to be installed
E: Unable to correct problems, you have held broken packages.

if i try rewrite sources i get this:
W: Failed to fetch http://fr.archive.ubuntu.com/ubuntu/dists/trusty/main/binary-armhf/Packages  404  Not Found [IP: <IP_ADDRESS> 80]

W: Failed to fetch http://fr.archive.ubuntu.com/ubuntu/dists/trusty/universe/binary-armhf/Packages  404  Not Found [IP: <IP_ADDRESS> 80]

W: Failed to fetch http://fr.archive.ubuntu.com/ubuntu/dists/trusty-security/main/binary-armhf/Packages  404  Not Found [IP: <IP_ADDRESS> 80]

W: Failed to fetch http://fr.archive.ubuntu.com/ubuntu/dists/trusty-security/universe/binary-armhf/Packages  404  Not Found [IP: <IP_ADDRESS> 80]

W: Failed to fetch http://fr.archive.ubuntu.com/ubuntu/dists/trusty-updates/main/binary-armhf/Packages  404  Not Found [IP: <IP_ADDRESS> 80]

W: Failed to fetch http://fr.archive.ubuntu.com/ubuntu/dists/trusty-updates/universe/binary-armhf/Packages  404  Not Found [IP: <IP_ADDRESS> 80]

Hi @alameya,
I tried and it works fine
apt-get update && apt-get install php5

Hi @alameya, do you still need help for this point ?

it was because scalaway use ARM package lists, but i tried php5.6 x86_64 Q.Q

Okay ! :)


No highlight around ascii charactered string

Testing #143553
I'm not seeing any highlights around the suggested character's string (https://github.com/microsoft/vscode/issues/143553#issuecomment-1048734093):

This is by design (but the design is not really fixed).
The weird looking characters (λ and ℕ) indicate already visually that something funny is going on. Contextual highlighting only highlights characters when it would not be obvious that something unexpected is going on.


TSLint preserves symlinks when searching for custom rules

Bug Report

TSLint version: 5.9.1
TypeScript version: 2.4.2
Running TSLint via: Node.js API

Related issues:
https://github.com/pnpm/pnpm/issues/1487
https://github.com/SharePoint/sp-dev-docs/issues/2934
TypeScript code being linted
You can find a repro here: https://github.com/nickpape-msft/pnpm-install-issue
Just run pnpm install and then gulp.

Note: this issue occurs primarily when using different package managers that set up their node_modules differently (i.e. using symlinks). You can see https://github.com/pnpm/pnpm/issues/1487 for more details.

Basically, our project's tslint.json references @microsoft/sp-tslint-rules, which in turn references tslint-microsoft-contrib for custom rules. However, it seems tslint is preserving symlinks when trying to resolve that module (even though the default Node.js behavior is to resolve symlinks).
// code snippet
// n/a

with tslint.json configuration:
{
  "$schema": "http://json.schemastore.org/tslint",

  "rulesDirectory": [
    "tslint-microsoft-contrib",
    "./lib/rules"
  ]
}

Actual behavior
TsLint throws an error because it cannot find the rules for tslint-microsoft-contrib.
Expected behavior
We are able to resolve the tslint-microsoft-contrib rules.

This issue is fixed in https://github.com/palantir/tslint/pull/4295

Closing the issue as the PR has been merged in; #4340 tracks a new release to make this available.


virtual/initializingworkspace: rename sub-VWs

Rename sub-virtual-workspaces to tell what they do (e.g. serve wildcard workspaces), not how they do it (filtered, delegated). Much easier to read without reading the deep logic of their implementation.

/retest

/lgtm

/retest

/retest

Rebased

Merged through https://github.com/kcp-dev/kcp/pull/1316.


Externalize constraints

When using the library in order to build up a JSON schema AST using constraints (e.g. to be emitted as JSON), one needs access to internal packages.

Also, before externalizing, one should replace schemaTypeAsString with an appropriate boolean for each schema type for including the type keyword. Currently, one could provide invalid values for the type keyword since it expects a string.

Another related issue: booleanWriter does delegate directly to anyConstraintWriter as it should be and hence always includes the type in the serialization.


Flood log messages : is not a valid ACParameter

Hello
The integration is working very well with homeassitant, but the logs are flooded by these lines :
Error processing parameter: 'iu_af_dir_hrz' is not a valid ACParameter
Error processing parameter: 'iu_af_swg_hrz' is not a valid ACParameter
Error processing parameter: 'iu_hmn_det_auto_save' is not a valid ACParameter
Error processing parameter: 'iu_min_heat' is not a valid ACParameter
Error processing parameter: 'iu_err_code' is not a valid ACParameter
Error processing parameter: 'iu_demand' is not a valid ACParameter
Error processing parameter: 'iu_fltr_sign_reset' is not a valid ACParameter
Error processing parameter: 'iu_model' is not a valid ACParameter

It's never ending, it's resulting in overload log file.
I got these too :
2024-02-08 10:00:16.745 WARNING (MainThread) [homeassistant.components.climate] Entity None (<class 'custom_components.fujitsu_airstage.climate.AirstageAC'>) does not set ClimateEntityFeature.TURN_OFF but implements the turn_off method. Please create a bug report at https://github.com/danielkaldheim/ha_airstage/issues
2024-02-08 10:00:16.745 WARNING (MainThread) [homeassistant.components.climate] Entity None (<class 'custom_components.fujitsu_airstage.climate.AirstageAC'>) does not set ClimateEntityFeature.TURN_ON but implements the turn_on method. Please create a bug report at https://github.com/danielkaldheim/ha_airstage/issues
2024-02-08 10:00:16.745 WARNING (MainThread) [homeassistant.components.climate] Entity None (<class 'custom_components.fujitsu_airstage.climate.AirstageAC'>) implements HVACMode(s): off, cool, heat, fan_only, dry, auto and therefore implicitly supports the turn_on/turn_off methods without setting the proper ClimateEntityFeature. Please create a bug report at https://github.com/danielkaldheim/ha_airstage/issues

Duplicate of https://github.com/danielkaldheim/ha_airstage/issues/24


doc is not accurate

to have linear transition cssEase needs to be set (which is not in the api doc), in doc we have "easing" with default value "linear", but have no idea how it is used

true


Update scripts and dependencies

Fixes #327, #328, #331 where the prepare script was generating development files

@farzadso , the error on the distributed files on npm is caused by the stub flag on the nuxt-module-build command which is on the prepare script.
i've also bumped versions or fixed versions for the dev dependencies and realigned the scripts with the current nuxt module starter pack.

Any chance this can get merged in? 👀

@jphilung Thanks for the contribution but the dev script doesn't work anymore.

Also this project uses yarn and not npm as the package manager, so please take this into account when adding scripts.
the lockfile needs to be updated too.

These changes were made in another commit.


Bold, Underline, Strike out not working

Jodit Version:  4.2.6
Browser: Chrome/FF
OS: Windows/Linux
I am using jodit Pro licence version but in browser editor it not showing proper bold, underline or strike out either in preview or in editor.

The point here is not in the editor, but in the styles that you connected to the site.
Most likely some kind of reset.css
Look in your code
strong {
font-weight: normal;
}


FancyZones not working on restart until function toggled.

ℹ Computer information

PowerToys version: v0.21.1
PowerToy Utility: FancyZones
Running PowerToys as Admin: yes/no
Windows build number: [run "18363.1082"]

❌ Actual result
FancyZones not functioning on PC restart until toggling fancyzones in-app. Occurs in and out of admin mode. Run on start-up enabled. Thanks.

@Bfreak
can you verify if this problem is still present in 0.29.0? Thanks.

This appears fixed. Thanks for your efforts!
On Tue, Dec 29, 2020 at 9:25 PM Enrico Giordani<EMAIL_ADDRESS>wrote:

@Bfreak https://github.com/Bfreak
can you verify if this problem is still present in 0.29.0? Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/microsoft/PowerToys/issues/6575#issuecomment-752247307,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKK5X3R4KLPHIWKANZEO72TSXJCOLANCNFSM4RH4TVQQ
.

--
James Allen - Founder and Director
Trackhat.org


fix Implicit memory aliasing in for loop

fix Implicit memory aliasing in for loop

/ok-to-test

@estesp Looks good to merge?

Regarding unit tests, it might be better to have golangci-lint rules instead

@kzys Is this something there should an issue opened to track?

@estesp Yes. Cutting #6584 for tracking.


Increase maximum total testing time limit to 30 minutes

About the PR
Media

[x] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Fixed by https://github.com/space-wizards/space-station-14/pull/14466, https://github.com/space-wizards/space-station-14/pull/14581 and https://github.com/space-wizards/space-station-14/pull/14577


Preserve multiline for line ending with \

Hey. I have the next yaml.
What is the best way to preserve multiline for the regex value?
I cannot use > scan_folded_as_literal  because there will be spaces between elements.
apiVersion: operator.victoriametrics.com/v1beta1
kind: VMNodeScrape
metadata:
  name: kubelet
spec:
  metricRelabelConfigs:
    - action: labeldrop
      regex: (uid)
    - action: labeldrop
      regex: (id|name)
    - action: keep
      regex: "go_goroutines|\
        kubelet_cgroup_manager_duration_seconds_bucket|\
        kubelet_cgroup_manager_duration_seconds_count|\
        kubelet_node_config_error|\
        kubelet_node_name|\
        node_quantile:kubelet_pleg_relist_duration_seconds:histogram_quantile|\
        kubelet_pleg_relist_duration_seconds_bucket|\
        kubelet_pleg_relist_duration_seconds_count|\
        kubelet_pleg_relist_interval_seconds_bucket|\
        kubelet_certificate_manager_client_ttl_seconds|\
        kubelet_certificate_manager_client_expiration_renew_errors|\
        kubelet_certificate_manager_server_ttl_seconds|\
        kubelet_pod_start_duration_seconds_bucket|\
        kubelet_pod_start_duration_seconds_count|\
        kubelet_pod_worker_duration_seconds_bucket|\
        kubelet_pod_worker_duration_seconds_count|\
        kubelet_server_expiration_renew_errors|\
        kubelet_running_containers|\
        kubelet_running_container_count|\
        kubelet_running_pods|\
        kubelet_running_pod_count|\
        kubelet_runtime_operations_errors_total|\
        kubelet_runtime_operations_total|\
        kubelet_volume_stats_available_bytes|\
        kubelet_volume_stats_capacity_bytes|\
        kubelet_volume_stats_inodes|\
        kubelet_volume_stats_inodes_used|\
        process_cpu_seconds_total|\
        rest_client_request_duration_seconds_bucket|\
        rest_client_requests_total|\
        storage_operation_duration_seconds_count|\
        storage_operation_errors_total|\
        kubernetes_build_info|\
        volume_manager_total_volumes|\
        process_resident_memory_bytes"

Hi @ezh thanks for opening an issue.
Do you have retain_line_breaks set with this example? See the docs to see how to set that.

$ cat $HOME/.config/yamlfmt/.yamlfmt
formatter:
  type: basic
  retain_line_breaks: true
  scan_folded_as_literal: true

@braydonk You can reproduce it quickly. Copynpaste the above YAML to test.yml and run
yamlfmt -conf ~/.config/yamlfmt/.yamlfmt test.yml with retain_line_breaks.

yamlfmt -version
0.10.0


Load macros with context, move path logic into macro

Make page available on the image macro
Remove the need to reuse the same path manipulation logic in every post
Simplify syntax in posts

Doh! Is context an Eleventy variable, or a special Nunjucks one. Don’t think I’ve come across it before.

with context is a nunjucks thing:
https://github.com/mozilla/nunjucks/pull/1209/files


NLog 4.5 support (.NET Standard 2 and structured logging)

Any time-frame for NLog 4.5 wrapper in Common.Logging?
I can use the existing 4.4.12 and change it up a bit, and it works, but an official support would be nice.
Edit: Also, the NLog wrapper WriteInternal method that calls _logger.Log<> doesn't support structured logging functionality with NLog 4.5 beta7, because it fails in string.Format part of code in StringFormatFormattedMessage (AbstractLogger.cs).

Hi There, I would also be interested in support for NLog 4.5, is this planned at all?
@Troncek could you please share the code changes you have made?

I'm also interested in 4.5 support


DuckDuckGO-android throwing error when compiling or building

I am using Android Studio 3.4.2
Build command failed.
Error while executing process /Users/O/Library/Android/sdk/cmake/3.6.4111459/bin/cmake with arguments {-H/Volumes/disk0s2/Android/PrivacyBrowser/app -B/Volumes/disk0s2/Android/PrivacyBrowser/app/.externalNativeBuild/cmake/debug/x86 -DANDROID_ABI=x86 -DANDROID_PLATFORM=android-21 -DCMAKE_LIBRARY_OUTPUT_DIRECTORY=/Volumes/disk0s2/Android/PrivacyBrowser/app/build/intermediates/cmake/debug/obj/x86 -DCMAKE_BUILD_TYPE=Debug -DANDROID_NDK=/Users/O/Library/Android/sdk/ndk-bundle -DCMAKE_TOOLCHAIN_FILE=/Users/O/Library/Android/sdk/ndk-bundle/build/cmake/android.toolchain.cmake -DCMAKE_MAKE_PROGRAM=/Users/O/Library/Android/sdk/cmake/3.6.4111459/bin/ninja -GAndroid Gradle - Ninja}
-- Check for working C compiler: /Users/O/Library/Android/sdk/ndk-bundle/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang
-- Check for working C compiler: /Users/O/Library/Android/sdk/ndk-bundle/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /Users/O/Library/Android/sdk/ndk-bundle/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang++
-- Check for working CXX compiler: /Users/O/Library/Android/sdk/ndk-bundle/toolchains/llvm/prebuilt/darwin-x86_64/bin/clang++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /Volumes/disk0s2/Android/PrivacyBrowser/app/.externalNativeBuild/cmake/debug/x86

CMake Error at CMakeLists.txt:29 (add_library):
  Cannot find source file:

    src/main/cpp/third-party/bloom_cpp/src/BloomFilter.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
  .hxx .in .txx

CMake Error: CMake can not determine linker language for target: https-bloom-lib

That looks like you didn't do a recursive clone for the project. Can you give that a try, as detailed here https://github.com/duckduckgo/Android#building-the-project, and let me know if that fixes it for you?

thanks alot that's worked. <3


Fix a crash when repository uses custom flake8 format

Hi,
First of all, thank you for this useful gem! I tried using it today on a project at work but encountered a crash similar to this:
Traceback (most recent call last):
        21: from /home/gedas/.rbenv/versions/2.5.0/bin/pronto:23:in `<main>'
        20: from /home/gedas/.rbenv/versions/2.5.0/bin/pronto:23:in `load'
        19: from /home/gedas/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/pronto-0.9.5/bin/pronto:6:in `<top (required)>'
        18: from /home/gedas/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/thor-0.19.4/lib/thor/base.rb:444:in `start'
        17: from /home/gedas/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/thor-0.19.4/lib/thor.rb:369:in `dispatch'
        16: from /home/gedas/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/thor-0.19.4/lib/thor/invocation.rb:126:in `invoke_command'
        15: from /home/gedas/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/thor-0.19.4/lib/thor/command.rb:27:in `run'
        14: from /home/gedas/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/pronto-0.9.5/lib/pronto/cli.rb:60:in `run'
        13: from /home/gedas/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/pronto-0.9.5/lib/pronto/cli.rb:60:in `chdir'
        12: from /home/gedas/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/pronto-0.9.5/lib/pronto/cli.rb:61:in `block in run'
        11: from /home/gedas/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/pronto-0.9.5/lib/pronto.rb:64:in `run'
        10: from /home/gedas/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/pronto-0.9.5/lib/pronto/runners.rb:13:in `run'
         9: from /home/gedas/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/pronto-0.9.5/lib/pronto/runners.rb:13:in `each'
         8: from /home/gedas/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/pronto-0.9.5/lib/pronto/runners.rb:20:in `block in run'
         7: from /home/gedas/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/pronto-flake8-0.1.0/lib/pronto/flake8.rb:56:in `run'
         6: from /home/gedas/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/pronto-flake8-0.1.0/lib/pronto/flake8.rb:63:in `run_flake8'
         5: from /home/gedas/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/pronto-flake8-0.1.0/lib/pronto/flake8.rb:63:in `chdir'
         4: from /home/gedas/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/pronto-flake8-0.1.0/lib/pronto/flake8.rb:67:in `block in run_flake8'
         3: from /home/gedas/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/pronto-flake8-0.1.0/lib/pronto/flake8.rb:81:in `parse_output'
         2: from /home/gedas/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/pronto-flake8-0.1.0/lib/pronto/flake8.rb:81:in `map'
         1: from /home/gedas/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/pronto-flake8-0.1.0/lib/pronto/flake8.rb:81:in `block in parse_output'
/home/gedas/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/pronto-flake8-0.1.0/lib/pronto/flake8.rb:86:in `parse_output_line': undefined method `strip' for nil:NilClass (NoMethodError)

The problem was that our project is using a custom flake8 configuration which includes format = pylint option which does not print out the column in the error message. For reference: https://github.com/PyCQA/flake8/blob/9631dac52aa6ed8a3de9d0983c3c7b0267ae7d6d/src/flake8/formatting/default.py#L56
In other words, splits in parse_output_line ends up being an array of 3 elements instead of 4, thus message is nil and we get a NoMethodError.
Here I provide a solution of overriding any custom flake8 format with the default using --format=default
I have also added require 'tmpdir' to spec/support/repository_helper.rb because I was getting the following error:
Failures:

  1) Pronto::Flake8#run patches are nil returns an empty array
     Failure/Error: @tmp_git_dir = Dir.mktmpdir

     NoMethodError:
       undefined method `mktmpdir' for Dir:Class
       Did you mean?  mkdir
     # ./spec/support/repository_helper.rb:7:in `create_repository'
     # ./spec/pronto/flake8_spec.rb:71:in `block (3 levels) in <module:Pronto>'

I have also updated the Python version used by Travis, because it kept failing with the following error:
$ pyenv global 3.5.3
pyenv: version `3.5.3' not installed

I have checked the available versions in this build: https://travis-ci.org/scoremedia/pronto-flake8/builds/438773783 (pyenv versions step)

@RAbraham did you have a chance to look through this PR?

@gediminasz Thanks for using the gem! I wasn't notified of this until yesterday. I'm a bit busy this week and next week, I'm leaving the company so I myself have to negotiate how I'll access this repo. I'll keep you posted.

@gediminasz Thank you for your contribution, especially the unit test.

@gediminasz I've pushed a 0.2.0 version out. Let me know how it goes.

@RAbraham Much appreciated! I've upgraded just now and it seems to work fine.


More/custom search engines

Hey team, great job on the update and the new tab page.
The only thing which is bothering me is the choice of search engines.
As you can see here, even Duckduckgo is not recommended, since it is based in the US, only partially open source (when they stated otherwise) and is officially collaborating with Yahoo.
There are better search engines for privacy like Qwant or instances of SearX like this one.
The best thing would probably be to give the user a setting/field where he can input a url to the search engine of his choice.

Hi @BunnyTheLifeguard thanks for the suggestion. In the latest release r11, the Dissenter new tab experience has been made optional and if off by default. This can be re-enabled from within the options/preferences page.
Also, Qwant has been added to the list of new tab search engines. This can be set from within the new tab page, within the search bar, click the caret all the way on the right to select a new default search engine.


Retry lnd engine validation

Description
A few sentences describing the overall goals of the pull request's commits.
Related PRs
List related PRs if applicable
Todos

[ ] Tests
[ ] Documentation
[ ] Link to Trello

 Wait for LND to be ready before trying to start sparkswapd


Unclear "Configure your node's chain spec"

Is there an existing issue?

[X] I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

[X] This is not a support question.

Content request
Where is a full example of this?
Example link 1
Node template 'chain_spec.rs'
does not show pallet_something: PalletSomethingConfig {}, which is explained in the guide
Example link 2
Example pallet GenesisConfig
is an invalid link
please advise. thanks
Are you willing to help with this request?
Maybe (please elaborate above)

Hi @AuroraLantean, thanks for submitting an issue. Can you provide a little more context on where these issues are? Which guide are you referring to?
Is the problem in the chain specification itself or in documentation about the chain spec or both?
Thanks!

Go ahead and reopen if you can provide more context & details :)


Sort on Multiple Columns

Is it possible to use Stupid Table to sort on multiple columns? Both on load and by clicking shift while clicking on the .
Thank you,
Robert

+1 for this feature

Any updates on this? I can't find a plugin that allow multi column sorting.

Bum +1 this is a must have for table sorting .

+1 for this feature

+1 for this

2 years and no updates? This is the best table sorting plugin available, and it's just missing this one feature. Every other similar plugin tries to be an entire table sorting suite - this is the only non-bloated one.

Hey Keith,
Thanks for the kind words regarding the plugin. As of late, what usually happens is that once or twice a year I try to knock out a few PRs and Issues for this plugin. I unfortunately cannot guarantee a time when this feature will be implemented.
I have considered handing the plugin over to the community but I'm afraid of bloat ruining the vision I had for the stupid table in the first place. So unfortunately progress on the plugin is slow because I'm too nervous about handing over the reins but also do not have the time to keep up with the issues/PRs.

Is the plugin set up to handle easy extending? If it's not, then maybe that could be a development priority, and the community could write extensions for the core plugin, which would remain the same. Lord knows I've written some crazy extra JavaScript on top of your existing plugin, it would be great to be able to formalize some of that into an extension and release it.

That's a good idea Christian. There had been talk of something similar before but I hadn't followed through. I think making that a priority makes the most sense.

👍 on this feature.

Good news folks. #187 makes this achievable in the near future. I've been resuming development on this project lately.

Good news everyone. Multicolumn sort has been added via #188. Sorry it took 3 years, but better late than never I suppose!


implements device_state_attributes. Please report it to the custom component author.

Logger: homeassistant.helpers.entity
Source: helpers/entity.py:549
First occurred: 19:33:14 (30 occurrences)
Last logged: 19:33:15
Entity sensor.weatherbit_forecast_day_3 (<class 'custom_components.weatherbit.sensor.WeatherbitSensor'>) implements device_state_attributes. Please report it to the custom component author.
Entity sensor.weatherbit_forecast_day_4 (<class 'custom_components.weatherbit.sensor.WeatherbitSensor'>) implements device_state_attributes. Please report it to the custom component author.
Entity sensor.weatherbit_forecast_day_5 (<class 'custom_components.weatherbit.sensor.WeatherbitSensor'>) implements device_state_attributes. Please report it to the custom component author.
Entity sensor.weatherbit_forecast_day_6 (<class 'custom_components.weatherbit.sensor.WeatherbitSensor'>) implements device_state_attributes. Please report it to the custom component author.
Entity sensor.weatherbit_forecast_day_7 (<class 'custom_components.weatherbit.sensor.WeatherbitSensor'>) implements device_state_attributes. Please report it to the custom component author.

Thank you for reporting this. I am aware of this, and I have a brand new version with many changes in the works, that are also fixing this.

V1.0.0 released, fixing this issue.


There is no query with name "MicrosoftDefaultComputerGroup"

From page
From Query explorer in the right-hand pane, expand Saved Queries\Updates and select the saved search query MicrosoftDefaultComputerGroup to edit it.

There is no query with name MicrosoftDefaultComputerGroup

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 9a94d637-558c-b26e-a1de-c4381aa6783c
Version Independent ID: d8c47851-0ac5-3932-e1e1-e224285e7476
Content: Remove VMs from Azure Automation Update Management
Content Source: articles/automation/update-management/remove-vms.md
Service: automation
GitHub Login: @MGoedtel
Microsoft Alias: magoedte

Thanks for the feedback and bringing this to our notice . At this time we are reviewing the feedback and will update the document as appropriate .

@artisticcheese - Thanks for raising this issue. I've confirmed the steps are incorrect and need to be updated, and I'm going to address it now.  In the meantime to access the computer group, in your LA workspace, select Advanced Settings from the left-hand pane and then select Computer Groups\Saved Groups and you should see the Updates:MicrosoftDefaultComputerGroup in the list.
Hope that helps.

@artisticcheese - Thanks for raising this issue. I've confirmed the steps are incorrect and need to be updated, and I'm going to address it now.  In the meantime to access the computer group, in your LA workspace, select Advanced Settings from the left-hand pane and then select Computer Groups\Saved Groups and you should see the Updates:MicrosoftDefaultComputerGroup in the list.
Hope that helps.

in your LA workspace, select Advanced Settings from the left-hand pane and then select Computer Groups\Saved Groups and you should see the Updates:MicrosoftDefaultComputerGroup in the list.
Hope that helps.

Can I get this issue reopened please as unless I'm missing something, I don't see what's mentioned above in my portal:

I'm having a really hard time finding out how to remove a VM from Update Management
Thanks


Gradle 'material-sheet-fab' project refresh failed

Error:No service of type Factory available in ProjectScopeServices.

I don't think this is caused by an issue with the library.


Laravel 9.0 Support

Please can you add Laravel 9.0 support?  Thanks..

Added support for Laravel 9.0.


Extracting macOS 11 cache file leads to "duplicate file" prompts

I'm trying to extract all 1842 items of a "dyld_shared_cache_arm64e" file, taken from a DTK with macOS 11 beta 3. Using the released app v0.1.1
When selecting them all, and choosing "Export Selected", I get many prompts about duplicate files.
Also, all files end up being 2 GB in size, which is clearly incorrect.
I get the impression that the duplicates are symlinks, and that the extractor doesn't handle these well. It should probably simply ignore them.

Thanks for the suggestions, I'll take a look at it.
About the incorrect file size, I'm aware of the issue.
I'm currently extracting a lot more than just the file's portion in order to keep the offsets intact in the LINKEDIT segment, which is shared across all files in the cache.
A perfect implementation would remap these, but I haven't found the time to do it properly yet.

I see – extracting all ~1800 files, each at 2 GB in size, is not practical for now, then.
My problem is that I was looking for a particular error msg that I'm seeing when running an app, and I wanted to find out which framework it came from, and then look at it further with Hopper. My file search revealed that the string only appears in this large dyld_shared_cache_arm64e file. That won't tell me which framework it's in, though. So, for my need, I cannot just pick one framework, because I don't know which I need. That's why I wanted to be able to extract all frameworks so that I can then do a file search in each of them to find the one I'm seeking.
I wonder if it's possible to add a string search function that'll be able to list the frameworks in which it occurs.
I've tried to run the project myself, but I get errors about missing header files and I find no docs on where to get them and where to put them. Is that something easy to solve, maybe with brew?

About the missing headers, the project uses submodules, so you need to git submodule update --init --recursive first, if you didn't clone recursively.
Now for your issue, this is unfortunately somehow difficult.
If I remember correctly, when the shared cache is built, while the text (code) sections are preserved, other sections such as data or strings are merged into a single one, shared across all images.
This is because the whole cache file is mapped into memory as a whole, for convenience.
Makes it easy for the OS to load it, but unfortunately harder to read.
Looking for a specific string would require disassembling all frameworks to find references to the string's offset - not really convenient.

other sections such as data or strings are merged into a single one, shared across all images.
Wow. I guess I'll give up on pursuing that particular problem then, for now. Thanks for explaining.


PushNotificationIOS: register device and show local notification

[x] Review the documentation: https://facebook.github.io/react-native
[x] Search for existing issues: https://github.com/facebook/react-native/issues
[x] Use the latest React Native release: https://github.com/facebook/react-native/releases

Environment
  React Native Environment Info:
    System:
      OS: macOS 10.14.2
      CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
      Memory: 129.04 MB / 16.00 GB
      Shell: 5.3 - /bin/zsh
    Binaries:
      Node: 8.12.0 - /usr/local/bin/node
      Yarn: 1.12.3 - /usr/local/bin/yarn
      npm: 6.4.1 - /usr/local/bin/npm
      Watchman: 4.9.0 - /usr/local/bin/watchman
    SDKs:
      iOS SDK:
        Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
      Android SDK:
        API Levels: 23, 25, 26, 27, 28
        Build Tools: 23.0.1, 23.0.2, 25.0.0, 25.0.2, 25.0.3, 26.0.1, 26.0.2, 26.0.3, 27.0.3, 28.0.2, 28.0.3
        System Images: android-25 | Google APIs Intel x86 Atom, android-26 | Google APIs Intel x86 Atom_64, android-26 | Google Play Intel x86Atom, android-27 | Google APIs Intel x86 Atom
    IDEs:
      Android Studio: 3.2 AI-181.55<IP_ADDRESS>56338
      Xcode: 10.1/10B61 - /usr/bin/xcodebuild
    npmPackages:
      react: 16.6.3 => 16.6.3
      react-native: 0.57.8 => 0.57.8
    npmGlobalPackages:
      react-native-cli: 2.0.1
      react-native-git-upgrade: 0.2.7

Description
Take a look on example app, in src/index.js file I've registered two listeners, one to listen to device register before request permissions and another one to listen when notification is received.
But for some reason don't work, any listener is called neither any notification is shown either.
I follow and I reviewed the documentation many many times and I don't have an idea why doesn't work
Important: I'm using simulator, is that a problem?
Reproducible Demo
I did a simple app just to study and to ask help, here:
https://github.com/rodrigowpl/rn-notifications-play

I have the same error. I don't have any Push Notifications in my iPhone...

This issue has been moved to react-native-community/react-native-push-notification-ios#4.


Testflight / Beta Access

I suggest to create a Testflight (iOS) or Beta Access Pre-Release of new Light Wallet Versions, so that more users could test new features.
Access should only be for users, which confirms they know and accept the risks
Best Practice: Use the Beta only on testnet and on a second mobile phone.

Hi @Mark76DefiChain we have this since the release of Light Wallet. You can join this group for more info https://t.me/DefiProductReview

Hi, maybe we misunderstood each other. I was speaking about testing pre-release versions. Testflight Version of the wallet is 2.0.0, current Release is 2.4.3... Will the next light wallet version be available for pre-release testing? (2.5?)


Feature/add slangs json

Closes #
What new changes did you make? Tick all applicable boxes

[* ] Added new abbreviation
[ ] Fixed something in the source code
[ ] Added a new feature
[ ] Fixed the docs (README.md, CONTRIBTUING.md, etc)

Describe the new changes you added.
Add 8 new slang entries starting with 'Z' to slangs JSON file

Share a screenshot of new changes

Add 8 new slang entries starting with 'Z' to slangs JSON file


Support for pydantic version 2

Hi,
I'm managing a python environment having multiple users and use-cases. One group of users request the ramanchada2 which we then make available.
It seems ramanchada2 requires pydantic v1. This causes issues for us, since we have other packages relying on pydantic v2.
Do you have plans for upgrading ramanchada2 to pydantic v2?
Best regards
Mathias

we need pydantic2 update ourselves, but are with limited resources at the moment,  good chance this will change next month

Good to hear! We will be looking forward to that

Resolved by #136


When KV cache block reuse is set, model has to be built with paged context FMHA support

ERROR: Failed to create instance: unexpected error when creating modelInstanceState: [TensorRT-LLM][ERROR] Assertion failed: When KV cache block reuse is set, model has to be built with paged context FMHA support (/home/jenkins/agent/workspace/LLM/main/L0_PostMerge/llm/cpp/tensorrt_llm/batch_manager/trtGptModelInflightBatching.cpp:140)
i have used --enable_context_fmha --dtype float16 --remove_input_padding --use_gpt_attention_plugin float16 --use_inflight_batching --paged_kv_cache
while compiling the model and it gives error when i set enable_kv_cache_reuse to True

The error message explains the reason clearly. If you want to reuse cache, you need to set use_paged_context_fmha as true
(https://github.com/NVIDIA/TensorRT-LLM/blob/main/examples/gpt/build.py#L352C11-L357). This feature is only supported in gpt now. If you want to enable it in other models, you might need to modify the codes.

can i use it in Llama models also?

@MrD005  It is not added in LLaMA building scripts.

Did you solve the problem?


AzCopy fail to enumerate blobs under directories in a premium storage account

Which version of the AzCopy was used?
10.7.0 (someone found that this regressed from 10.5.0)
Which platform are you using? Mac
What command did you run?
copy
What problem was encountered?
During enumeration for the source, AzCopy list a directory and stops without enumerating blobs in it.
How can we reproduce the problem in the simplest way?
Go to a premium storage account's blob container, find a directory and copy it to somewhere else as source.
Have you found a mitigation/solution?
Copy exact blobs instead of their directory.
Extra context
This doesn't reproduce for non-premium storage accounts.

Hi @JasonYeMSFT I could not repro this,
I copied a dir recursively from a premium storage account to local FS and it worked successfully. Please let me know if im missing something.
I will close this issue in the meantime, feel free to reopen if your issue still persists.


Implement cpobj opcode for wasm

Implements the ILToWebAssembly.ImportCpObj method using an LLVM load and
store.
Fix #4548

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: yaram sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

On further though, an LLVM load & copy might be a better solution than the explicit call to memcpy. Looking for input on the matter.

It appears that LLVM optimises a load & store to memcpy in appropriate situations. (http://llvm.org/doxygen/MemCpyOptimizer_8cpp_source.html line 629)
I'm now rewriting it as a load & store.

Rewrite is done, updating pull request.

it looks like https://github.com/dotnet/coreclr/blob/32f0f9721afb584b4a14d69135bea7ddc129f755/tests/src/JIT/IL_Conformance/Old/objectmodel/cpobj.il would be a good test for this instruction. I think we should have enough implemented to do the entire test.  @morganbr might have an idea of how to enable this test in automation. If you want to try it as a one off you could try referencing this test project in HelloWasm and then just call _cpobj.main() from Program.cs

it looks like https://github.com/dotnet/coreclr/blob/32f0f9721afb584b4a14d69135bea7ddc129f755/tests/src/JIT/IL_Conformance/Old/objectmodel/cpobj.il would be a good test for this instruction. I think we should have enough implemented to do the entire test.

That test has a non trivial interaction with System.Console. It will definitely need tweaks.

oops, looks like I should try things before I recommend them. that traps pretty early on just trying to get the out stream.

I'm working on adding a test for cpobj to HelloWasm.

@yaram, this generally looks good. I'll happily approve it once that test is ready. It doesn't need to print anything if that's inconvenient; it can just return 100 if it worked and any non-zero value if it didn't work.

I've finished the test. Sorry it took so long, I ran into so many problems while writing it.

Thanks for the contribution, @yaram! Interested in picking up another opcode or something else?


Apply DB transactions to the Block storage processing

If an error occurs while storing blocks and transactions or enrollments, that do not match the ledger actual data may exist.
For example, if only block data exists.
In this case, rollback must be done and must be rollback in the tables.
Related #51

This requires #71. Rebase operation is required after the merge.

Ready for review.

Thank you.
I applied @MichaelKim20's  suggestion.


Flag image is not showing on iPad on iOS 16

Describe the bug
Flag image is not showing on iPad on iOS 16 or above
To Reproduce
Expected behavior
Should show the flag of the selected country
Screenshots

Smartphone (please complete the following information):

Device: [iPad]
OS: [iOS16]

FlagPhoneNumber (please complete the following information):

Version [0.8.0]

Additional context

The same is also happening on iPhone devices as well.

I have the same issue on 16.2

I have replaced my project with the new library:
https://github.com/marmelroy/PhoneNumberKit

Thanks, I will try it.


Create sourcemap in instrumented files

If invoked with nyc instrument it wasn's possible to attach the sourcemap. This created problems for me in the coverage reports created.

@schutm I'm not sure what the best solution is here such that you and @vanduynslagerp don't consistently break each-other's use-cases.
Is there a heuristic approach we could use so that both your applications of shouldInstrument work? I think we should make an effort to add a test for both so that we don't keep flip-flopping on this feature.

Agreed we shouldn't break each other changes, and test-cases should be there. However since this is in the CLI I didn't think it would break the previous changes.
For now seems I had a dangling comma; which I'll fix

Changes Unknown when pulling be893c5a25d211c402901fff37e937f0b51efd34 on schutm:master into ** on istanbuljs:master**.

@schutm I think this accidentally reverts https://github.com/istanbuljs/nyc/pull/667/files which would break @vanduynslagerp's use-case.

Changes Unknown when pulling 6f83f56a0131ccb1ef4241618238f87ba49ea56c on schutm:master into ** on istanbuljs:master**.

@bcoe I removed the accidentally included index.js, which reverted #667. In addition I tidied the commits up to a single one.

@schutm this looks great 👍 sorry that this took so long to land.

@schutm try this out, and let me know if it does the trick:
npm i nyc@next --save-dev


[T4A5][T13-B2] KhooDesmond

@KhooDesmond   Some comments added. Please close the PR after reading comments


Invoice creation via bulk edit

Description:
When generating invoice documents via the bulk edit, the invoice address is sometimes not output in the document.
We have now found out that this only happens if there are orders with different languages in a batch. In addition, the address format for one of the languages does not have to be set in the invoice country.
The problem is that the variable order.addresses.get(order.billingAddressId).country.translated.addressFormat is null.
If you change this line as follows, everything works without any problems.
'languageIdChain' => [$languageId],

[public] Automated response: This issue is linked to the internal issue https://shopware.atlassian.net/browse/NEXT-34142.
[created from NEXT-34142, comment 485934]

Not true, even if you change the code line 'languageIdChain' => [$languageId], the issue still persists. Shopware Support recognized this but could not give an estimate to when it will be fixed. Since we run Shopware 6 together with Pickware ERP Pro for our daily business this really negatively affects our business. It is though not the only thing not working in Shopware 6 which is critical to other businesses as well I guess. So please go on and have this fixed asap.

[public]

FixVersion Change: <IP_ADDRESS>, <IP_ADDRESS>

This issue will be / was solved in Shopware version <IP_ADDRESS>, <IP_ADDRESS>.
[created from NEXT-34142, comment 510421]


ModuleNotFoundError: No module named 'tensorflow'

Problem
I have problem running tensorflow, I am quite new in using tensorflow and Python, hence pardon me if this is stupid question to ask. The problem is when I tried running tensorflow in windows command prompt, it worked just fine but then it give me ModuleNotFoundError when I tried running it through .py file. Is there something wrong? Please help me, thank you
System information

Tensorflow version 1.1 (installed using instruction given in Here in conda environment named tensorflow-gpu
OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Windows 10
TensorFlow installed from (source or binary): pre-built binary
CUDA/cuDNN version: 8.0/5.1

Source code / logs

(tensorflow-gpu) C:\Users\USER\Anaconda3\envs>python
Python 3.5.3 |Continuum Analytics, Inc.| (default, Feb 22 2017, 21:28:42) [MSC v.1900 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import tensorflow as tf
>>> hello = tf.constant('Hello, TensorFlow!')
>>> sess = tf.Session()
2017-04-27 12:01:30.461948: W c:\tf_jenkins\home\workspace\release-win\device\gpu\os\windows\tensorflow\core\platform\cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE instructions, but these are available on your machine and could speed up CPU computations.
2017-04-27 12:01:30.462096: W c:\tf_jenkins\home\workspace\release-win\device\gpu\os\windows\tensorflow\core\platform\cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE2 instructions, but these are available on your machine and could speed up CPU computations.
2017-04-27 12:01:30.462199: W c:\tf_jenkins\home\workspace\release-win\device\gpu\os\windows\tensorflow\core\platform\cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE3 instructions, but these are available on your machine and could speed up CPU computations.
2017-04-27 12:01:30.462298: W c:\tf_jenkins\home\workspace\release-win\device\gpu\os\windows\tensorflow\core\platform\cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.1 instructions, but these are available on your machine and could speed up CPU computations.
2017-04-27 12:01:30.462375: W c:\tf_jenkins\home\workspace\release-win\device\gpu\os\windows\tensorflow\core\platform\cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.2 instructions, but these are available on your machine and could speed up CPU computations.
2017-04-27 12:01:30.462448: W c:\tf_jenkins\home\workspace\release-win\device\gpu\os\windows\tensorflow\core\platform\cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX instructions, but these are available on your machine and could speed up CPU computations.
2017-04-27 12:01:31.657721: I c:\tf_jenkins\home\workspace\release-win\device\gpu\os\windows\tensorflow\core\common_runtime\gpu\gpu_device.cc:887] Found device 0 with properties:
name: GeForce GT 740M
major: 3 minor: 5 memoryClockRate (GHz) 1.0325
pciBusID 0000:07:00.0
Total memory: 2.00GiB
Free memory: 1.67GiB
2017-04-27 12:01:31.657920: I c:\tf_jenkins\home\workspace\release-win\device\gpu\os\windows\tensorflow\core\common_runtime\gpu\gpu_device.cc:908] DMA: 0
2017-04-27 12:01:31.659743: I c:\tf_jenkins\home\workspace\release-win\device\gpu\os\windows\tensorflow\core\common_runtime\gpu\gpu_device.cc:918] 0:   Y
2017-04-27 12:01:31.660988: I c:\tf_jenkins\home\workspace\release-win\device\gpu\os\windows\tensorflow\core\common_runtime\gpu\gpu_device.cc:977] Creating TensorFlow device (/gpu:0) -> (device: 0, name: GeForce GT 740M, pci bus id: 0000:07:00.0)
>>> print(sess.run(hello))
b'Hello, TensorFlow!'
>>> ^Z

(tensorflow-gpu) C:\Users\USER\Anaconda3\envs>hello_tf.py
Traceback (most recent call last):
  File "C:\Users\USER\Anaconda3\envs\hello_tf.py", line 1, in <module>
    import tensorflow as tf
ModuleNotFoundError: No module named 'tensorflow'

Here is my hello_tf.py:
import tensorflow as tf

hello = tf.constant('Hello, TensorFlow!')
sess = tf.Session()
print(sess.run(hello))

maybe the default .py is associated w/ a different version of python. Just do
C:\Users\USER\Anaconda3\envs>python hello_tf.py

and see if that works.

Thanks @aselle ! That solved the problem. How is that even possible? What caused the problem? I am in the conda environment, hence it should be using the python version of the current env right?

That solved the problem. Thanks


feat: Adding EXPLORER env to override the explorer URL in brownie networks

Tested and works for me on my server


MGMT-16779 Update ib-orchestration-vm to use the ib-cli tool for generating the installation ISO

PR Review for #71
Overall Assessment
Positive review with a few concerns and recommendations
Strengths
Thorough code review process
Comprehensive changes to ib-orchestration-vm
Concerns
No description provided
Modifications to ib-cli tool may require additional testing
Recommendations
Include a description of changes in the Pull Request
Perform additional testing for ib-cli tool modifications
Code Quality Score: 8/10

PR Review for #71
Overall Assessment
Positive review with constructive feedback
Strengths
Thorough code review process
Comprehensive coverage of changes
Concerns
Additional testing for potential bugs and security vulnerabilities
Consideration of performance optimizations
Recommendations
Perform thorough testing for potential bugs and security vulnerabilities
Evaluate performance optimizations
Code Quality Score: 9/10


[WIP]: Bye bye ethers.js

This PR contains following changes(as of time of opening):

Wipe out ethers.js
Replace signer/provider/signerOrProvider with walletClient/publicClient/walletOrPublicClient whenever appropriate
Use appropriate methods from viem in place of ethers utils

Closes #1364
Closes #1365
Note - this is "base" PR, from which I'll chain 2-3 more PRs to tackle following issues:

[ ] Replace SafeServiceClient - it relies on ethers provider. We either need to build custom implementation, or ideally - use their SDK
[ ] Workaround voting for Snapshot proposals - snapshot.js also relies on ethers signer.
[ ] Fix Lido staking - their SDK also relies on ethers and typechain-types, but it should be quite trivial to replace with getContract from viem cause their SDK also exports plain ABI

@mudrila there are a handful of non-trivial merge conflicts in here now. When you get a chance after your current Reskin PR, can you please get these conflicts resolved? I'll be happy to go through them with you as a second pair of eyes.

@mudrila I'm going to close this PR. The work here is being addressed in a series of other, smaller, PRs.


CSS compatibility issue with Beginner Box journals due to !important use

Without the dorako UI CSS, it would look like:

With my new tech I might be able to apply the dalvyn styling only for non-premium-module journals. Otherwise, disabling the CRB styled journals under misc settings should fix this in the interim.

I worked around it at the moment via a custom world.css override of the h1234 color and :hover background.
I don't want to disable your CRB journal styling as I love the styling for my own journals in the same world.
On 23 Feb 2023, 11:36 +0100, Dorako @.***>, wrote:

With my new tech I might be able to apply the dalvyn styling only for non-premium-module journals. Otherwise, disabling the CRB styled journals under misc settings should fix this in the interim.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

Oh I know what's wrong - I was pretty sure I had already made dalvyn styling not be injected into premium modules, but now I realize that Beginner's Box is not on my list.
From your pictures above it the class appears to be pf2e-bb, can you confirm?

Correct!
On 23 Feb 2023, 17:54 +0100, Dorako @.***>, wrote:

Oh I know what's wrong - I was pretty sure I had already made dalvyn styling not be injected into premium modules, but now I realize that Beginner's Box is not on my list.
From your pictures above it the class appears to be pf2e-bb, can you confirm?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

I just released v1.12.6 which should resolve this issue

I'll assume this is fixed, feel free to re-open if it isn't.


Agree beta release standard

Currently, we are using a custom format ${upcomingVersion}--beta.${currentBetaIteration}; for beta releases.
The thing is that yarn and npm have the following commands for generating a prerelease version which I think it's more convenient:
yarn version --premajor  # This will create the tag 4.0.0-0 if we are in version 3.x
yarn version --prerelease # This will create another iteration of the release 4.0.0-1

yarn docs | npm docs
I think the benefits are clear. As we are following a convention and we avoid typos like this one

Closing as everyone seems happy.


Add more properties to the common model classes

Coverage remained the same at 100.0% when pulling f22e2829affcc9289e114082b501cf5df5f76ff6 on model-coverage into 087fb67198e313a9ec134fcdaba25194d0d42fd6 on master.


chore: Add API usage stats to telemetry

Add a telemetry event to periodically report how many requests were made to each RPC. Also reports the count of gRPC user agents to get an idea about SDK usage.

Codecov Report

Merging #924 (6ec4aa1) into main (83afe12) will increase coverage by 0.20%.
The diff coverage is 49.38%.

@@            Coverage Diff             @@
##             main     #924      +/-   ##
==========================================
+ Coverage   54.37%   54.57%   +0.20%
==========================================
  Files         104      106       +2
  Lines       11254    11411     +157
==========================================
+ Hits         6119     6228     +109
- Misses       4618     4662      +44
- Partials      517      521       +4

Impacted Files
Coverage Δ

internal/telemetry/conf.go
22.22% <28.57%> (+22.22%)
:arrow_up:

internal/telemetry/server_launch.go
39.62% <39.62%> (ø)

internal/telemetry/telemetry.go
40.00% <43.28%> (-3.38%)
:arrow_down:

internal/server/server.go
54.76% <60.00%> (+0.21%)
:arrow_up:

internal/telemetry/middleware.go
75.67% <75.67%> (ø)

internal/server/tests.go
94.24% <0.00%> (-0.91%)
:arrow_down:

internal/audit/local/badgerdb.go
63.17% <0.00%> (-0.64%)
:arrow_down:

internal/engine/planner.go
79.85% <0.00%> (+0.99%)
:arrow_up:

internal/engine/engine.go
73.69% <0.00%> (+1.77%)
:arrow_up:

... and 2 more


installing problem

Hi All,
I was trying to install freebayes, and this is what I got:
jing@jing-VirtualBox:~/Downloads/freebayes$ make
wget -q http://hypervolu.me/freebayes/build/v1.1.0-3-g961e5f3-dirty &
cd src && make
make[1]: Entering directory '/home/jing/Downloads/freebayes/src'
DETECTED_VERSION = v1.1.0-3-g961e5f3-dirty
CURRENT_VERSION  = v1.1.0-3-g961e5f3-dirty
make[1]: Leaving directory '/home/jing/Downloads/freebayes/src'
jing@jing-VirtualBox:~/Downloads/freebayes$ freebayes
freebayes: command not found
Hope someone can help me out. Will really appreciate it!
Thanks,
Jing

You need to put freebayes in your path for the bare command to work this
way.
On Thu, Apr 20, 2017, 10:28 PM jingjin0322<EMAIL_ADDRESS>wrote:

Hi All,
I was trying to install freebayes, and this is what I got:
jing@jing-VirtualBox:/Downloads/freebayes$ make
wget -q http://hypervolu.me/freebayes/build/v1.1.0-3-g961e5f3-dirty &
cd src && make
make[1]: Entering directory '/home/jing/Downloads/freebayes/src'
DETECTED_VERSION = v1.1.0-3-g961e5f3-dirty
CURRENT_VERSION = v1.1.0-3-g961e5f3-dirty
make[1]: Leaving directory '/home/jing/Downloads/freebayes/src'
jing@jing-VirtualBox:/Downloads/freebayes$ freebayes
freebayes: command not found
Hope someone can help me out. Will really appreciate it!
Thanks,
Jing
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/ekg/freebayes/issues/381, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAI4EYQMqpIdiDt31rVRCPckcfbMkCF6ks5rx8ALgaJpZM4NDiTY
.


CLI: Add .singleline and .multiline to the dot command list

Hi,
I just tested the CLI's .singleline and .multiline modes as we're implementing something similar in the Kùzu CLI, and it seems that neither of these dot commands have been documented (at least in the 1.0.0 version).
https://duckdb.org/docs/api/cli/dot_commands
Would be nice to see docs on this, explaining to users that .multiline is a useful mode to handle long queries that are hard to manage in a single line (esp. useful when accessing/editing a query via the query history in the shell, as single line mode mashes it all up into one line).

Thanks @prrao87, this is a great point! I added the commands in the table.


support for SOAP Binding

The library supports SOAP Binding?? I'm trying to maken and AuthnRequest with Packed Credentials over SOAP
regards

SOAP binding Is not covered.
You have to alternatives:

Use another PHP SAML library like simplesamlphp that supports it
Extend that library for your own use, (we don't want to support/maintain SOAP Binding

Ok, thanks for the info!
regards

We try to follow the SAML2int Profile and it specifies:
The <saml2p:AuthnRequest> message issued by a Service Provider MUST be communicated to
the Identity Provider using the HTTP-REDIRECT binding.


Missing a setup.py

It looks useful but it would be even better if we could easily install it from github.

Done.

Very good, I've tested it, it works.


[bug] Line length checking is not accurate

This is a sub-issue from #82 (see examples there). In https://github.com/astrale-sharp/typstfmt/commit/a9e6249019111783380be88390e86af3441076ab line length can exceed the configured line limit. Specifically, if the text (content block) is used, then it can be chopped into smaller lines which won't alter the output.

Ex. 1
#very-long-long-long-long-long-function-name[Lorem ipsum dolor sit amet, consectetur adipiscing
  elit, sed do eiusmod tempor incididunt ut labore
  et dolore magnam aliquam quaerat voluptatem. Ut
  enim aeque doleamus animo, cum corpore dolemus,
  fieri.]

Ex. 2
\ Term : Some interesting words

Ex 1 can be solved with your smart proposition which i'm feeling more on board with now even tho it make me feel uneasy still.
It also involves a hack: the parent tries to understand the child had to broke by scanning the child length and comparing it to max length minus 7 (it's used elsewhere too, see the todos in the code)
The alternative to the hack would be to have more context, maybe context could contain a hashmap of span -> info and info could hold a needed to break flag

Example 2 happens because \ Term : is not part of the markup, so the checking of the length only concerns it's sibling, it could be solved by checking if the parent is a term item and adding the length of the left siblings the the first line of size comparison
I'm going to take care of this in a few days but in the meanwhile if someone wants to do it, say so and I'll let you, I welcome PRs!
When i start working on this I'll say so

If ex. 2 is indeed a Typst term, then the slash must be forward, not backward.

Edited, thank you :)

One reason I'm hesitant to take the provided solution is this:
f(arg)[too long][short][too long again][ long but can be broken cause spaced ]
What should be done then, everything in parenthesis except the last one? I mean probably cause it's prettier that way but I feel bad modifying that much code of the users

The question is hard, because:

Typst has a unique syntax for required parameters: you can put them before/after parameters with default values
Typst has an option to omit () if the required parameter is content and just use [] without ()
LaTeX (typesetting language) doesn't have formatters, except https://github.com/cmhughes/latexindent.pl (which is basically a Perl wrapper with regex rules).
everyone has a unique taste in formatting

But regardless, as I said, the KISS principle is good as it can improve readability. There is already a nice example https://github.com/typst/typst/issues/311#issuecomment-1666575619:

show heading: it =>  {
    it
    par()[#text(size:0.5em)[#h(0.0em)]]
}

Specifically, par()[#text(size:0.5em)[#h(0.0em)]] can be greatly simplified to par(text(size:0.5em, h(0.0em))).
I already mentioned (somewhere) that I want text to be as packed as possible, like any Markdown file should be. Another example is (AGPL) license file: https://www.gnu.org/licenses/agpl-3.0.txt.
So, f(arg)[too long][short][too long again][ long but can be broken cause spaced ] IMO should be formatted as:
f(arg)[too long][short][too long again][ long but
  can be broken cause spaced ]

(limit is 50 columns)
...is what I would say, if I didn't think for a while. To eliminate multistep formatting that in nested cases can slow down the formatting time (maybe not), A more general rule should be applied. Like a rule priority. Something like this:

if there is a whitespace(s) after [ + the line exceeds the limit + the [ does not exceed the limit, then put change (all) whitespace(s) with a (single) newline after the [
if in the previous rule the newline was added + there is a whitespace(s) before the ] which is a pair to the [ from the previous rule, then change (all) whitespace(s) with a (single) newline before ]

Hmm... I don't know how it could be implemented, but there is still 2 steps in my rules. Ok, I'll finish the idea. After first 2 rules we will get:
f(arg)[too long][short][too long again][
  long but can be broken cause spaced
]

Of course somewhere between the rules we have to add 1 indent, because 1st line ends with [ and 3rd line starts with the paired ].

And now we only need to chop the content (2nd line) if it exceeds the limit.

But it doesn't exceed, so we finished formatting.

Here are similar examples (limit: 50, indent: 2):
#f(arg)[too long][short][too long again][ long but can be broken cause spaced]

#f(arg)[too long][short][too long again][ long abc long abc long long long long long long long long long abc long long long long long long long long long]

// According to my rules:

#f(arg)[too long][short][too long again][
  long but can be broken cause spaced]

#f(arg)[too long][short][too long again][
  long abc long abc long long long long long long
  long long long abc long long long long long long
  long long long]

// But this kinda looks better, especially if the content is very long:

#f(arg)[too long][short][too long again][ long but
  can be broken cause spaced]

#f(arg)[too long][short][too long again][ long abc
  long abc long long long long long long long long
  long abc long long long long long long long long
  long]

So maybe change rules to this:

if there is whitespace(s) after [  and before  ] + the [ does not exceed the limit, then put the content which is inside the [] on a separate line.
if there is whitespace(s) only after [ , then break line at the most right whitespace.

I think the rules are more of a flowchart written linear (in one line), so maybe it's easier to follow a flowchart (with nested if statements and things like that).

Here are all 4 variants:
Whitespace after [ and before ]
[  &  ]:
#f(arg)[too long][short][too long again][ long but can be broken cause spaced ]

#f(arg)[too long][short][too long again][ long abc long abc long long long long long long long long long abc long long long long long long long long long ]

#f(arg)[too long][short][too long again][
  long but can be broken cause spaced
]

#f(arg)[too long][short][too long again][
  long abc long abc long long long long long long
  long long long abc long long long long long long
  long long long
]

Whitespace only after [
[  & ]:
#f(arg)[too long][short][too long again][ long but can be broken cause spaced]

#f(arg)[too long][short][too long again][ long abc long abc long long long long long long long long long abc long long long long long long long long long]

#f(arg)[too long][short][too long again][ long but
  can be broken cause spaced]

#f(arg)[too long][short][too long again][ long abc
  long abc long long long long long long long long
  long abc long long long long long long long long
  long]

Whitespace only before ]
[ &  ]
#f(arg)[too long][short][too long again][long but can be broken cause spaced ]

#f(arg)[too long][short][too long again][long abc long abc long long long long long long long long long abc long long long long long long long long long ]

#f(arg)[too long][short][too long again][long but
  can be broken cause spaced ]

#f(arg)[too long][short][too long again][long abc
  long abc long long long long long long long long
  long abc long long long long long long long long
  long ]

No whitespaces
[ & ]:
#f(arg)[too long][short][too long again][long but can be broken cause spaced]

#f(arg)[too long][short][too long again][long abc long abc long long long long long long long long long abc long long long long long long long long long]

#f(arg)[too long][short][too long again][long but
  can be broken cause spaced]

#f(arg)[too long][short][too long again][long abc
  long abc long long long long long long long long
  long abc long long long long long long long long
  long]

Here are all 4 variants if 2nd to last argument exceeds the limit:
Whitespace after [ and before ]
[  &  ]:
#f(arg)[too long][short][ long but can be broken cause spaced ][too long again]

#f(arg)[too long][short][ long abc long abc long long long long long long long long long abc long long long long long long long long long ][too long again]

#f(arg)[too long][short][
  long but can be broken cause spaced
][too long again]

#f(arg)[too long][short][
  long abc long abc long long long long long long
  long long long abc long long long long long long
  long long long
][too long again]

Whitespace only after [
[  & ]:
#f(arg)[too long][short][ long but can be broken cause spaced][too long again]

#f(arg)[too long][short][ long abc long abc long long long long long long long long long abc long long long long long long long long long][too long again]

#f(arg)[too long][short][ long but can be broken
  cause spaced][too long again]

#f(arg)[too long][short][ long abc long abc long
  long long long long long long long long abc long
  long long long long long long long long][too
  long again]

Whitespace only before ]
[ &  ]
#f(arg)[too long][short][long but can be broken cause spaced ][too long again]

#f(arg)[too long][short][long abc long abc long long long long long long long long long abc long long long long long long long long long ][too long again]

#f(arg)[too long][short][long but can be broken
  cause spaced ][too long again]

#f(arg)[too long][short][long abc long abc long
  long long long long long long long long abc long
  long long long long long long long long ][too
  long again]

No whitespaces
[ & ]:
#f(arg)[too long][short][long but can be broken cause spaced][too long again]

#f(arg)[too long][short][long abc long abc long long long long long long long long long abc long long long long long long long long long][too long again]

#f(arg)[too long][short][long but can be broken
  cause spaced][too long again]

#f(arg)[too long][short][long abc long abc long
  long long long long long long long long abc long
  long long long long long long long long][too
  long again]

One thing that could be a problem is something like this:
#f(arg)[too long][short][long abc long abc long
  long long long long long long long long abc long
  long long long long long long long long][too
  long again]

Maybe an easier approach is to only format things until the ]:
#f(arg)[too long][short][long abc long abc long
  long long long long long long long long abc long
  long long long long long long long long][too long again]

This way we can reapply rules to the last still exceeding the limit line. I
think all the rules will work very nicely the second time too.
But this again makes formatting in multiple steps. But since Rust's binaries are
superfast, it may not be a problem. What do you think, @astrale-sharp?

So, I don't think perf would be an issue, what I'm unsure about
is that we would then be reimplementing something very similar to how content block format themselves, but the parent would take care of it. It's an exception and isn't pretty but I guess we don't have a choice here

in lorem ipsum #loooooooooooooooong_var, long_var might go above the length and yet the line will be broken after it, not before


Concern about ID Naming Convention

To differentiate words in an identifier, capitalize the first letter of each word in the identifier, generally in naming properties in c# the naming convention is pascal, but i notice in some examples like the movie class the ID property written capital letters. Is that break the Name convention which recommended by Microsoft documents https://docs.microsoft.com/en-us/ef/ef6/modeling/code-first/conventions/built-in

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 39b6d0f3-9bc7-d091-0d45-9fc1e2e7aac8
Version Independent ID: 20e7eb53-215b-09ab-205d-d20177221278
Content: Add validation to an ASP.NET Core Razor Page
Content Source: aspnetcore/tutorials/razor-pages/validation.md
Product: aspnet-core
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

No because ID is an abbreviate.

Is that break the Name convention which recommended by Microsoft documents docs.microsoft.com/en-us/ef/ef6/modeling/code-first/conventions/built-in

It uses ID as in DepartmentID, CourseID


Separate setting definitions from config values

Overview
In this PR we separate setting definitions (i.e. the objects you create when you call setting :my_setting) from config, which now maintains its values in a separate hash, and stores only a reference to the setting definitions.
This allows settings objects to be shared across all config classes, which, along with some other changes here, reduces memory usage considerably.
According benchmarks/memory_profile.rb for 10,000 subclasses, this branch now allocates only 9.5 MB, down from 21.9 MB on the main branch.
User-facing changes
Unless you're an advanced dry-configurable user here, and reaching deeply into our Setting objects, the user-facing changes here are minimal! Ordinary usages of dry-configurable will continue to work as before.
The one real behavioural change is that for instance-level configurable, new settings defined make themselves available even on previously initialized objects. This is in fact an incidental change to the rest of this PR and I could choose to wind that back, too, if we wanted.
Implementation details

Setting moves to being a strict definition only. It no longer plays double duty as a realisation of an associated value within a config object. Specifically, it no longer has an input or value. Because of this, it no longer needs to be finalized or return a pristine copy or other such config-related responsibilities.
Setting::Nested and Setting#nested have been removed. These no longer seemed necessary, and we now just provide a simple array of children: when initialising the setting.
In turn Settings can lose config-related responsibilities such as #finalize! and #pristine.
I renamed the internal Settings collection from elements to settings since it feels nicer.
At the same time, this internal collection is no longer a Concurrent::Map, instead just a regular hash. This netted us some decent memory savings. I am keen to hear feedback about this. Why did it need to be a concurrent map in the first place? Are we worried e.g. about settings being defined in concurrent threads? What material downside would there be from this being a hash? And how does this compare with how we do things in e.g. Dry::Core::ClassAttributes, where there's no specific thread safety measures. Is calling setting here really all that different to defines from ClassAttributes?
Config is now initialized with a settings instance, which it uses to determine which values it should be storing. These values are kept internally in a simple name=>value hash.
When configurable classes are inherited, we create a dup of the _settings collection to the subclass. This dups its internal settings array only, so we don't copy all of the settings themselves, thereby preserving memory.
Likewise, we create a copy of the config into the subclass using a new Config#dup_for_settings method, passing the new subclass settings collection to ensure the config object sees any new settings defined in the subclass. When we #dup_for_settings, we also dup any cloneable values that the config holds (i.e. values likely to be mutated and therefore ideally not shared), but we do not dup any of the other simple values, since they are safer to be shared.

Next steps
In the shortest term, I'm going to let @solnic merge #136 when he is ready, and then I'll make sure I update this PR to work with those changes. I expect it should only need minimal adjustment, mostly just moving of code.
I also expect to follow this up in the next week with another proposal for further reducing dry-configurable memory usage, but this PR is already a good step in a positive direction, and I think it also helpfully clarifies the code at the same time.

As of https://github.com/dry-rb/dry-configurable/commit/cb0a4919342d829482143c6832fec79648e41eec, here's the memory benchmarks:
For 100 subclasses:
        configurable   679.348k memsize (    77.844k retained)
                         5.044k objects (   443.000  retained)
                        50.000  strings (    50.000  retained)
configurable (nested)
                       229.568k memsize (     0.000  retained)
                         2.287k objects (     0.000  retained)
                        10.000  strings (     0.000  retained)

Comparison:
ordinary inheritance:      17776 allocated
configurable (nested):     229568 allocated - 12.91x more
        configurable:     679348 allocated - 38.22x more

vs main branch:
Comparison:
ordinary inheritance:      17776 allocated
configurable (nested):     530312 allocated - 29.83x more
        configurable:     742794 allocated - 41.79x more

For 10,000 subclasses:
        configurable    15.648M memsize (    77.844k retained)
                       143.644k objects (   443.000  retained)
                        50.000  strings (    50.000  retained)
configurable (nested)
                        22.168M memsize (     0.000  retained)
                       220.087k objects (     0.000  retained)
                        10.000  strings (     0.000  retained)

Comparison:
ordinary inheritance:    1760176 allocated
        configurable:   15648148 allocated - 8.89x more
configurable (nested):   22167968 allocated - 12.59x more

vs main branch:
Comparison:
ordinary inheritance:    1760176 allocated
        configurable:   21889194 allocated - 12.44x more
configurable (nested):   52247912 allocated - 29.68x more

So for 10,000 subclasses, this is a reasonable improvement:

For top-level settings only, 8.89x our baseline vs 12.44x in the main branch
For nested settings, 12.59x our baseline vs 29.68x in the main branch(!)

A clearer comparison. For 10,000 subclasses with this branch:
Total allocated: 15647852 bytes (143651 objects)
Total retained:  7761316 bytes (50471 objects)

allocated memory by gem
-----------------------------------
   6280622  concurrent-ruby-1.1.10
   4801968  other
   4097136  dry-configurable/lib
    460501  zeitwerk-2.6.0
      7625  dry-core-8f5ca0ff8a19

And on the main branch:
Total allocated: 21888898 bytes (243654 objects)
Total retained:  16482777 bytes (180478 objects)

allocated memory by gem
-----------------------------------
   9000550  concurrent-ruby-1.1.10
   7618614  dry-configurable/lib
   4801968  other
    460141  zeitwerk-2.6.0
      7625  dry-core-8f5ca0ff8a19

That's 15MB allocated now, vs 21.8MB before, a 31.2% reduction.

Memory impact of this PR on the Hanami r10k benchmark:

Versus with the current release of dry-configurable:

14 days ago on this branch:
Total allocated: 15647852 bytes (143651 objects)
Total retained:  7761316 bytes (50471 objects)

Now:
Total allocated: 9511254 bytes (61150 objects)
Total retained:  7702930 bytes (50148 objects)

So this is 15.65MB allocated now down to 9.5MB (vs 21.89MB on the main branch).
One of the bigger gains here came from me switching to an ordinary Hash instead of a Concurrent::Map for Settings#settings. Are we particularly concerned about thread safety for adding to the setting definitions? I don't see how this is any different e.g. from Dry::Core::ClassAttributes, which just writes directly to class-level ivars when defining attributes.

 Reduce memory usage of Hanami::Action instances

custom config support was merged to main but I'm not sure how it's going to work here given that crucial construction logic was moved to the default Config class?

custom config support was merged to main but I'm not sure how it's going to work here given that crucial construction logic was moved to the default Config class?

I've rebased over the main branch now (and tidied my commit history) and everything is working fine! (👋🏼 @solnic)
If you'd like to review it, the Config construction logic is in these places:

ClassMethods#__config_build__ (same as your recent PR)
Setting#to_value (changed for this PR, this used to be in the now-removed Setting::Nested class)

Overall, this PR is ready for review and merge once we're all good with it.

Thanks @solnic! I'll incorporate all of your suggestions :)
And just to make sure, are you and @flash-gordon both fine with the replacement of the Concurrent::Map with an ordinary Hash for containing the setting definitions (inside Settings)?

And just to make sure, are you and @flash-gordon both fine with the replacement of the Concurrent::Map with an ordinary Hash for containing the setting definitions (inside Settings)?

@timriley yes this is fine. If thread-safety is an issue here, some external mechanism should be incorporated to ensure the safety. Doing so at each library level turned out to be a bad idea, as we've learned 🙂

And just to make sure, are you and @flash-gordon both fine with the replacement of the Concurrent::Map with an ordinary Hash for containing the setting definitions (inside Settings)?

I don't think this can lead to problems, practically speaking. Your reasoning is the same as mine, why would you have an environment where you define settings concurrently? AFAIK, require is thread-safe. There are possible other use cases but I agree with @solnic that they should be synchronized externally.

Thank you all! Merging this one now.

TBH no idea how this supposed to be used after reading the specs.

@ojab What in particular are you looking to find out?
That the specs didn't change much indicates that overall usage remains the same, especially  if you're just using setting and config.
The biggest difference is that _settings now returns an array of Dry::Configurable::Setting objects that contain the details of the setting definition only; the details about the configured values of the settings are kept in Dry::Configurable::Config now, separated from the Setting instances.

Thanks, I was trying to understand if there should be any user-visible changes, now I see that it's the internal change.


Typhoeus has a new version -- upping the dependencies for capybara-typhoeus.

Upped the version of Typhoeus required to 0.3.2. Bumping gem version to 0.2.3.

I just pushed the new version with updated Typhoeus dependency. Thanks.


VK_ERROR_OUT_OF_HOST_MEMORY on radeon HD7770

Running vulkaninfo on my fully-updated archlinux machine results in the above-mentioned error. This error also appeared running on ubuntu, though I assumed I had done something wrong in the install process. The card has 1 GB of VRAM and the system has 8GB of RAM. According to this forum post a similar issue exited in the closed-source opencl driver, which could be fixed by setting GPU_FORCE_64BIT_PTR=1

It's definitely enabled on my machine. I spent a really long time getting that set up properly. I had to add amdgpu.si_support=1 to the kernel parameters to get it to work. The radeon driver is blacklisted and dmesg only mentions amdgpu.

Good! Do you mind to debug why VK_ERROR_OUT_OF_HOST_MEMORY is reported? In the meanwhile, I'll download and build a custom kernel to reproduce this issue on Ubuntu.

It's almost midnight here, and I have work in the morning, so it'll have to wait.

It's ok, thank you very much!

The cause of this is https://github.com/GPUOpen-Drivers/AMDVLK/issues/17. I have the same card and initially got this VK_ERROR_OUT_OF_HOST_MEMORY.

I got as deep into debugging the issue as my knowledge of gdb would allow. The error occurs in fpCreateInstance. exploring it in gdb results in:
The value of 'fpCreateInstance' is of type 'PFN_vkCreateInstance' which is a typedef of type 'VkResult (*)(const VkInstanceCreateInfo *, const VkAllocationCallbacks *, VkInstance *)' 'fpCreateInstance' is a pointer to a value of type 'VkResult (const VkInstanceCreateInfo *, const VkAllocationCallbacks *, VkInstance *)'
Here's a backtrace of the line that calls fpCreateInstance:
#0  0x00007ffff7634aca in loader_create_instance_chain (     pCreateInfo=0x7fffffffe210, pAllocator=0x0, inst=0x5555557bc970,      created_instance=0x7fffffffe200)     at /home/andrew/opt/Vulkan-LoaderAndValidationLayers/loader/loader.c:4668 #1  0x00007ffff763aa94 in vkCreateInstance (pCreateInfo=0x7fffffffe300,      pAllocator=0x0, pInstance=0x7fffffffe430)     at /home/andrew/opt/Vulkan-LoaderAndValidationLayers/loader/trampoline.c:396 #2  0x0000555555557758 in AppCreateInstance (inst=0x7fffffffe430)     at /home/andrew/opt/Vulkan-LoaderAndValidationLayers/demos/vulkaninfo.c:766 #3  0x00005555555605e1 in main (argc=3, argv=0x7fffffffe748)     at /home/andrew/opt/Vulkan-LoaderAndValidationLayers/demos/vulkaninfo.c:2687
With my limited knowledge of GDB, I can't get it to step inside fpCreateInstance. I would guess that's where it moves into the actual driver code, but I don't really know. I do know that it returns VK_ERROR_OUT_OF_HOST_MEMORY, which is what results in the error seen. faking success of the function (by setting res to VK_SUCCESS in gdb) results in a VK_ERROR_INITIALIZATION_FAILED.

I did a debug build of AMDVLK, the error output from vulkaninfo is as follows:
Vulkan API Version: 1.0.69
WARNING: [loader] Code 0 : loader_icd_scan: ICD JSON /usr/share/vulkan/icd.d/amd_icd64.json does not have an 'api_version' field.
AMD-PAL: Error: Unconditional Assert | Reason: Unknown (/home/andrew/opt/amdvlk-git/src/pal/src/core/hw/gfxip/gfx6/gfx6Device.cpp:2550:DetermineIpLevel)
AMD-PAL: Info: Vulkan error: VK_ERROR_OUT_OF_HOST_MEMORY(-1), from Pal error: Pal::Result::ErrorOutOfMemory(-4) (/home/andrew/opt/amdvlk-git/src/xgl/icd/api/vk_conv.cpp:1006:PalToVkError)
/home/andrew/opt/Vulkan-LoaderAndValidationLayers/demos/vulkaninfo.c:771: failed with VK_ERROR_OUT_OF_HOST_MEMORY

Hi @boomboompsh, thanks for your debugging. Looks like this issue is same as #17 just as @difron mentioned. I'm trying to find a newer firmware. Will get back to you if any lucky.

Could you please try following steps to get the firmwares?

Download https://www2.ati.com/drivers/linux/ubuntu/amdgpu-pro-17.40-514569.tar.xz
xz -d amdgpu-pro-17.40-514569.tar.xz && tar xvf amdgpu-pro-17.40-514569.tar
cd amdgpu-pro-17.40-514569
dpkg -x amdgpu-pro-dkms_17.40-514569_all.deb dkms
verde firmwares locates under dkms/usr/src/amdgpu-17.40-514569/firmware/radeon

Thank you,  @JacobHeAMD! This fixed my problem. Now firmware exposes feature level 29, and no more VK_ERROR_OUT_OF_HOST_MEMORY occurs.
Note: I think you need to regenerate initrd after copying firmware to your system folder.

Thank you! This fixed the problem. Closing the issue, although installing firmware from the amdgpu-pro packages should not be necessary in future. But you know that, and are probably getting it fixed as I'm typing this.

This fixed the same issue on my 280X, it'd be nice if that upstreamed.
It makes me wonder what other difference there might be.


Calling old mfxInit cause unhandled c++ exception on some platform

Let me list a few cases：
case1：
libmfxhw32.dll version <IP_ADDRESS>
driver version <IP_ADDRESS>74
cpu:  Intel(R) Core(TM) i3-9100 CPU @ 3.60GHz
model:  ASUSTeK COMPUTER INC.-SKU
case2：
libmfxhw32.dll version <IP_ADDRESS>6
libmfx32-gen.dll version <IP_ADDRESS>
driver version <IP_ADDRESS>55
cpu:  x86 12th Gen Intel(R) Core(TM) i5-1240P
model:  LENOVO-LENOVO_MT_82RT
crash stack:

Closing for now, please re-open if you have new information.


Add custom results name field

A minor PR to add a custom name for clustering results that I separated from the timelapse branch where I implemented this. Closes https://github.com/BiAPoL/napari-clusters-plotter/issues/68. @Cryaaa, I appreciate if you can take a look and it works fine for you also. After this is merged I would make a release if you agree.

Codecov Report

Merging #73 (e21e763) into main (36bfe55) will decrease coverage by 0.36%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   73.74%   73.38%   -0.37%
==========================================
  Files          14       14
  Lines        1215     1236      +21
==========================================
+ Hits          896      907      +11
- Misses        319      329      +10

Impacted Files
Coverage Δ

napari_clusters_plotter/_clustering.py
73.62% <42.30%> (-1.78%)
:arrow_down:

napari_clusters_plotter/_tests/test_clustering.py
98.94% <100.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@lazigu
sorry it seems like I commented on the wrong pull request! I tested this branch though and it works fine for me.

@Cryaaa, my fault, I messed up a bit with branches, something was weird with tests :D
So what do you think, should I make a release after merging this or are you working on something that should be merged before?

@lazigu,
from my side I would say I'm done! the stuff I am working on is either still going to take some time or should be merged with the timelapse support release!


GetCloudletManifest re-creates the password for configure-node.sh script every time you run it

Since it re-creates the password every time, if there is already a node trying to download the ansible tarball, it fails to authenticate. We should keep the password and not re-generate it every time.

CreateCloudletNodeReq in cloudletnode_api.go re-creates the new password, since we create a hash, which we cannot just revert. It looks like we should store basic auth hash somewhere(maybe in vault) in order to be able to generate the manifest consistently.