Some questions related to superscript and SimpleExtPlugin addExtension

Markwon version: 4.6.2

Please specify expected/actual behavior
Reddit uses one ^ to show superscript (e.g. ^foobar) while Markwon only supports . So, I use regex to manually add another ^ and add

.usePlugin(SimpleExtPlugin.create(plugin ->
                                plugin.addExtension(1, '^', (configuration, props) -> {
                                    return new SuperscriptSpan();
                                })
                        )
                )

when initializing Markwon to show superscript. As a result, ^something^ is now parsed as superscript with no issue. But ^something ^, ^ something ^ or ^ something^ (you can see there is a space before the second ^ or after the first ^) is displayed as-is. It should be treated as superscript. Also, something^?^ is not working, only something ^?^ (you can see there is a space before the first ^) works.
Another problem is that SuperscriptSpan does not make the superscript smaller. How can I make it use a smaller font?

Please specify conditions/steps to reproduce (layout, code, markdown used, etc)
Initialize Markwon as the following:

Markwon.builder(this)
.usePlugin(SimpleExtPlugin.create(plugin ->
                                plugin.addExtension(1, '^', (configuration, props) -> {
                                    return new SuperscriptSpan();
                                })
                        )
                )
.build();

Should I use SimpleExtPlugin to add an ^ extension? Currently, Reddit's superscript only requires one ^ while addExtension requires opening and closing characters. Do you have a better method to show Reddit's superscript without using regex? Thank you in advance.

Hello @Docile-Alligator ,
SimpleExtPlugin is a the best tool here as, as you have noticed, it processes whitespace in the commonmark way. I suggest preprocessing your markdown first by inserting HTML  tag. This way superscript will appear exactly where you put it. There is no other steps except from using HtmlPlugin when building Markwon instance.
Customization of the SuperscriptSpan is not supported. By default HtmlPlugin.SCRIPT_DEF_TEXT_SIZE_RATIO (0.75F) is used to calculate superscript size (original text size * ratio is the formula). If you wish to change that you can create own span (it is pretty trivial). I've added a sample to show how to do it

Thank you so much for your help!!!!


shared_audits: remove module_function

Removes the need for include Kernel

Thanks again @Bo98!

Should probably add a RuboCop to prevent module_function usage.


Feat/migrate to angular 11

Hi, I've made this PR to upgrade the minimum angular version to 11. Updated also the README adding a table in wich could be useful to list the ngx-restangular versions compatible to their respect angular version.


fix(octez): allow float in octez rollup node

Context

Description

Manually testing the PR

@zcabter I added a fixup commit, would you be able to review?
The commit enables better support for floats in the rollup debugger and fixes a possible issue with nan canonicalisation for wasmer


Wrong dependency in cert_write.c

cert_write.c has been changed to use SHA256 but it is still checking against the POLARSSL_SHA1_C define.

Thanks for noticing! I'll fix that.

Fixed. However, the SHA1 check is still relevant, for the key identifier extensions, but they are optional.


Object of type 'WSGIRequest' is not JSON serializable

my code:

@background(schedule=60)
def g_trends(request):
	get_trends()
	return HttpResponse('hello')

when i run code in django and i get to my url for that function i get this error:
Object of type 'WSGIRequest' is not JSON serializable
how can i fix it?

do not send request as task argument.
that object type does not JSON serializable, it can not be stored in database as argument


not opened dropdown in Bootstrap 4.0.0

Sorry, my english is bad, but i can write report.
I use bootstrap 4.0.0 and selectpicker.
And my selectpicker not opened because you use style of Bootstrap 3.3.6
.open>.dropdown-menu {
    display: block;
}

Bootstrap 4.0.0 have't this style.
I hope I made that clear.

Bootstrap 4 support has been added as a part of v1.13.0-beta, available here: https://github.com/snapappointments/bootstrap-select/releases/tag/v1.13.0-beta. Please post any issues in that repo from now on.

Bootstrap 4 support has officially been added in v1.13.0!


SVHN dataset for torchvision

In reference to https://github.com/pytorch/vision/issues/59
cc: @mjpieters

@uridah do you have a notebook that checks for sanity of this code, like the notebook that loads some CIFAR10 images and displays them:
https://github.com/pytorch/vision/blob/master/test/sanity_checks.ipynb

@soumith I don't but I can create one.

I don't know if PyTorch follows PEP8 as a styleguide? If so, you way want to run flake8 on your code and fix the issues that finds; I see a few whitespace issues in it. :-) If not, I'll leave it to the project owners to set the requirements.

thanks @mjpieters . We have a LINT check as part of the contbuild, and it is failing:
https://travis-ci.org/pytorch/vision/builds/209884377
Locally doing:
pip install flake8
flake8 .
``
will show exact LINT errors you need to fix @uridah

@uridah I made some small inline comments (very minor and are only style changes). The PR looks good, thanks!

@fmassa Your comments very very useful and really helped concise the code
@soumith I added a new notebook named sanity_checks1.ipynb which is basically same as the sanity_checks.ipynb notebook, but in addition, is also calling SVHN datasets for transformations https://github.com/uridah/vision/blob/master/test/sanity_checks1.ipynb
Also, ran the code through flake8
@mjpieters

Hi @uridah
I made some more comments. The code is looking very nice!

Thanks @fmassa. Updated according to your suggestions

About the check_sanity1.pynb file, maybe you could integrate your changes into the check_sanity.pynb file? What do you think?

I will, if you guys think it's good enough.

@uridah another thing, it would be great if you could add an entry in the doc in README.md, like the one in Cifar10 for example. Maybe an example in the doc would be enough?
cc @soumith

here is the pull request for the change in documentation: https://github.com/pytorch/vision/pull/104
@fmassa

Hi @uridah
So, looking at the notebook that you added, I have the impression that the numbers are rotated. Maybe the x and y axis in the dataset are inverted, and you need to transpose them?
Also, could you please fix the indentation in the line I commented?
Once those are fixed, I think there is no need for the notebook (but @soumith knows better), so could you please remove it?
After that, the PR is good to be merged!

@fmassa as it turns out I needed it to transpose along 3,2,0,1 axis instead of 3,2,1,0. I have fixed that and updated the indentation and sanity_checks1.ipynb. Please have a look and let me know if anything else needs to be changed.
Also, I created a separate request to update the documentation but now I have merged it with this one.

Thanks Uridah, as you saw the last 4 commits, I made some minor changes to your PR. But it looked great. Merged into master now!!!

Hello,
It seems that the labels returned are in the range 1-10  (the data set assigns class 10 to the digit 0 and class d for all other digits, d [ http://ufldl.stanford.edu/housenumbers/ see section overview ]).
Given that some of the loss functions (CELoss, NLLLoss) expect the class labels to be in the range [0, C-1], shouldn't that be reflected here as well?
Another thing is that the the returned labels are of type ByteTensor and of size batchSize x 1. Again, CELoss, etc, expect it to be a 1d LongTensor.
I can make a PR if the current behaviour is inconsistent and should be made similar to the other data sets, for example as in CIFAR10

@vabh if you could make a PR to reflect this, that'd be great. Thanks.

@soumith I made one here: #194


chore(deps): update dependency google-protobuf to v3.18.1

This PR contains the following updates:

Package
Type
Update
Change

google-protobuf
dependencies
minor
3.17.3 -> 3.18.1

Release Notes

protocolbuffers/protobuf
v3.18.1
Compare Source
Python

Update setup.py to reflect that we now require at least Python 3.5 (#8989)
Performance fix for DynamicMessage: force GetRaw() to be inlined (#9023)

Ruby

Update ruby_generator.cc to allow proto2 imports in proto3 (#9003)

v3.18.0
Compare Source
C++

Fix warnings raised by clang 11 (#8664)
Make StringPiece constructible from std::string_view (#8707)
Add missing capability attributes for LLVM 12 (#8714)
Stop using std::iterator (deprecated in C++17). (#8741)
Move field_access_listener from libprotobuf-lite to libprotobuf (#8775)
Fix #7047 Safely handle setlocale (#8735)
Remove deprecated version of SetTotalBytesLimit() (#8794)
Support arena allocation of google::protobuf::AnyMetadata (#8758)
Fix undefined symbol error around SharedCtor() (#8827)
Fix default value of enum(int) in json_util with proto2 (#8835)
Better Smaller ByteSizeLong
Introduce event filters for inject_field_listener_events
Reduce memory usage of DescriptorPool
For lazy fields copy serialized form when allowed.
Re-introduce the InlinedStringField class
v2 access listener
Reduce padding in the proto's ExtensionRegistry map.
GetExtension performance optimizations
Make tracker a static variable rather than call static functions
Support extensions in field access listener
Annotate MergeFrom for field access listener
Fix incomplete types for field access listener
Add map_entry/new_map_entry to SpecificField in MessageDifferencer. They
record the map items which are different in MessageDifferencer's reporter.
Reduce binary size due to fieldless proto messages
TextFormat: ParseInfoTree supports getting field end location in addition to
start.
Fix repeated enum extension size in field listener
Enable Any Text Expansion for Descriptors::DebugString()
Switch from int{8,16,32,64} to int{8,16,32,64}_t

Java

Fix errorprone conflict (#8723)
Removing deprecated TimeUtil class. (#8749)
Optimized FieldDescriptor.valueOf() to avoid array copying.
Removing deprecated TimeUtil class.
Add Durations.parseUnchecked(String) and Timestamps.parseUnchecked(String)
FieldMaskUtil: Add convenience method to mask the fields out of a given proto.

JavaScript

Optimize binary parsing of repeated float64
Fix for optimization when reading doubles from binary wire format
Replace toArray implementation with toJSON.

PHP

Migrate PHP & Ruby to ABSL wyhash (#8854)
Added support for PHP 8.1 (currently in RC1) to the C extension (#8964)
Fixed PHP SEGV when constructing messages from a destructor. (#8969)

Ruby

Move DSL implementation from C to pure Ruby (#8850)
Fixed a memory bug with RepeatedField#+. (#8970)

Python

Drops support for 2.7 and 3.5.

Other

[csharp] ByteString.CreateCodedInput should use ArraySegment offset and count (#8740)
[ObjC] Add support for using the proto package to prefix symbols. (#8760)
field_presence.md: fix Go example (#8788)

Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.

[ ] If you want to rebase/retry this PR, check this box.

This PR has been generated by Renovate Bot.

Renovate Ignore Notification
As this PR has been closed unmerged, Renovate will now ignore this update (3.18.1). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.
If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.


General cleanup of the generics.

Generally added generics to classes within the storm.trident.spout package. This generally removes some of the casts that were in place, and simplifies the code slightly.
A typical example of what was done is
ITridentSpout _spout;

was converted to:
ITridentSpout<Object> _spout;

Issue raised on Jira: https://issues.apache.org/jira/browse/STORM-991

+1


Upgrade ribbon to 2.1.3

https://github.com/Netflix/ribbon/releases/tag/v2.1.3

Includes
https://github.com/Netflix/ribbon/releases/tag/v2.1.1
and
https://github.com/Netflix/ribbon/releases/tag/v2.1.2


fixes elm/core#1137

Fix bug that causes infinite loop

Hello @rupertlssmith, I was not sure if we can merge from an MR to the stack with the github web interface and just thought I'd give it a try.
I guess "Rebase and merge" should work as desired on https://github.com/elm-janitor/manifesto/blob/master/git-help.md#to-add-the-pull-request-to-the-stack

I always just do it from the command line.


Username nd paas

Too username and password please

Username: hacker
Password: wasii

Great, thanks!
On Sat, 9 Jul, 2022, 6:40 am Waseem Akram, @.***> wrote:

Closed #25 https://github.com/evildevill/Devil/issues/25 as completed.
—
Reply to this email directly, view it on GitHub
https://github.com/evildevill/Devil/issues/25#event-6963249362, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AYG5RDBY6TDUPPMAEDFXPPDVTDGPDANCNFSM52TPQ3HA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Introducing multi-zone support for yamaha_musiccast devices

Description:
This release introduces multi-zone support for linked devices in media_player.yamaha_musiccast component.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#3676
Example entry for configuration.yaml (if applicable):
media_player:
  - platform: yamaha_musiccast
    host: 192.168.xxx.xx
    port: 5005

Checklist:
If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[x] New files were added to .coveragerc.

If the code does not interact with devices:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] Tests have been added to verify that the new code works.

Breaking change:
The name attribute was removed in favour of getting the name directly from the device. Devices will follow the naming scheme deviceName_zone from now on. Please update your configuration/automations accordingly.

the component recognizes the two zones of my RX-V581 that i configured. awesome! the older yamaha  component based on the rxv library failed to do that.

Thank you, @sdague! 👍


AC has an unfamiliar gateway ID: 0xff - please open an issue and detail your system

Logger: airtouch2.protocol.at2.conversions
Source: runner.py:190
First occurred: 2:27:50 PM (37 occurrences)
Last logged: 3:52:52 PM
Home Assistant OS: 12.3
Home Assistant Core: 2024.6.1

Please detail your air conditioning system - I want to know what you have because 0xFF is some kind of ID and I don't what it means, e.g. Daikin, Panasonic, Samsung etc... Do you have a gateway board between your aircon and the airtouch? What brand is your aircon?


Breached password blacklist

Are there any plans to make it possible to call a custom Azure function to validate passwords?
The NIST guidelines also mention disallowing passwords exposed in previous breaches. Being able to check against the HIBP list would be very useful.
https://www.troyhunt.com/ive-just-launched-pwned-passwords-version-2/

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0e480dc0-3da0-0a1b-6f0a-fd492275058a
Version Independent ID: 660a25b3-c345-badd-0637-960f09abd6b1
Content: Password complexity - Azure AD B2C
Content Source: articles/active-directory-b2c/active-directory-b2c-reference-password-complexity.md
Service: active-directory-b2c
GitHub Login: @davidmu1
Microsoft Alias: davidmu

@FredMurphy Thanks for the feedback! Please post this as a feedback @ https://feedback.azure.com/forums/169401-azure-active-directory This will allow the community to upvote and for the product team to include into their plans. We also have the "Give Product Feedback" button in our documents now to take you directly to the appropriate feedback page.


Fix failing unit tests due to type error in catch block

Having a couple issues attempting to use this module. (Thanks for sharing!)
After cloning the module and running yarn install && yarn test the tests fail due to 2 type errors in catch blocks within the test.
This has no influence on the module's end-user functionality but merely in the tests.
$ jest --env=node --colors --coverage test
 FAIL  tests/base.spec.ts
  ● Test suite failed to run

    tests/base.spec.ts:33:14 - error TS2571: Object is of type 'unknown'.

    33       expect(e.message).toContain("Version");
                    ~
    tests/base.spec.ts:39:14 - error TS2571: Object is of type 'unknown'.

    39       expect(e.message).toContain("Variant");
                    ~
Test Suites: 1 failed, 1 total

The issue can be resolved by negating the need to specify a type for e in the catch blocks by simplifying the syntax in the test—as done in this PR.

Didn't see your PR but merged now. Thanks!


Add Spans

This is more of a WIP. I'm hoping that @dtolnay can give me feedback on the approach.
This is built on top of #91, so it has that commit included.
Fixes #41

I think this is a great approach! Amazing work.
One minor thing is I would prefer to see less .0 and .1. I think this is the culprit:
::synom::IResult::Done(rest, (val, span))

How would you feel about a struct with node and span to match rustc?
I am traveling for job interviews and have been stressed / overbooked, should be back to normal productivity by Wednesday.

I added a Spanned generic type earlier, and just had an idea for how to reduce the breaking-changeness of this chance, to potentially allow us to land it sooner / more easily.
The idea would be to have the span module have 2 implementations. The current one would be used when the span feature is enabled, and a dummy implementation would be used when it isn't:
pub type Spanned<T> = T;

macro_rules! spanned {
    ($i:expr, $submac:ident!( $($args:tt)* )) => {
        $submac!($i, $($args)*)
    }
}

Instead of adding a span field to different type definitions, we pass around Spanned<Ty> Spanned<Ident> etc. which will act exactly the same as the base type in the current implementation, but will have spans attached to them when the span feature is enabled.
This way we can add support for spans when people want them, without breaking code for consumers who are currently using syn with custom derive, where spans aren't super useful right now.
What do you think about that idea @dtolnay?

The thing with cfgs is they are required to be purely additive. If I have code in my crate that looks like:
let e = Expr { node: kind, attrs: vec![] };

and I add a dependency on a crate that uses syn with spans enabled, Cargo will build my crate with spans enabled and it won't work.

This is happening for real, using the compiler's spans! #142


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_a5p30o6f6j/clone/recipe/meta.yaml:24: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_a5p30o6f6j/clone/recipe/meta.yaml:24: host_section_needs_exact_pinnings: Packages in host must have exact version pinnings, except python build tools.
ERROR: /tmp/abs_a5p30o6f6j/clone/recipe/meta.yaml:45: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_a5p30o6f6j/clone/recipe/meta.yaml:45: missing_documentation: The recipe is missing a doc_url or doc_source_url
WARNING: /tmp/abs_a5p30o6f6j/clone/recipe/meta.yaml:45: missing_description: The recipe is missing a description
ERROR: /tmp/abs_a5p30o6f6j/clone/recipe/meta.yaml:45: missing_dev_url: The recipe is missing a dev_url
Errors were found


Always call sizeCOlumnsToFit on window resize

How can I achieve this currently when suppressing horizontal scroll bar?

Never mind, found that I could call the api.sizeColumnsToFit() on the onGridSizeChanged event.

because you can add the listener, no need for grid to provide this.


Project is running at http://localhost:1212/
webpack output is served from http://localhost:1212/dist
Content not from webpack is served from /Users/lusty/Desktop/Test/Electron/electron-react-boilerplate/dist
404s will fallback to /index.html

<EMAIL_ADDRESS>start-main-dev /Users/lusty/Desktop/Test/Electron/electron-react-boilerplate
cross-env HOT=1 NODE_ENV=development electron -r babel-register ./app/main.dev

Failed to fetch extension, trying 4 more times
Failed to fetch extension, trying 4 more times

Looks like related to: https://github.com/MarshallOfSound/electron-devtools-installer/issues/73
if import
import installExtension, { REACT_DEVELOPER_TOOLS, REDUX_DEVTOOLS } from 'electron-devtools-installer';
and change installExtensions function to:
const installExtensions = async () => {
  installExtension(REACT_DEVELOPER_TOOLS.id);
  installExtension(REDUX_DEVTOOLS.id);
};

in app/main.dev.js to:
It seems to work and install both extensions


Added worker capacity to Prometheus metrics

Added a capacity metric to ocluster-worker to allow us to centrally report on how busy a worker is.
Thus in Grafana, we could graph on
ocluster_worker_running_jobs{job="workername"}/ocluster_worker_capacity{job="workername"}

As this value is fixed it only needs to be set once but for readability, I have kept it together with the other metrics which are set once per job.  Happy to move it if there is a preferred/better place.

As this value is fixed it only needs to be set once but for readability, I have kept it together with the other metrics which are set once per job. Happy to move it if there is a preferred/better place.

This also has the problem that the capacity will be reported as zero until the first job starts. It would be better to move this to the run function, setting the capacity as soon as it is known.

Thanks @talex5.  Do the workers know the name of the pool they are connected to?  Using Grafana, there doesn't seem to be an easy way to select workers by pool?  It would be great if there was a metric which reflected, say linux-x86_64.

Do the workers know the name of the pool they are connected to?

No, but the scheduler does, and it knows the capacity too. You could report the metric there instead. There are two places that would need changing: when a worker connects and when it disconnects:
https://github.com/ocurrent/ocluster/blob/6f5f7c321261ba3cb4ca440b643cc7cc068fee06/scheduler/pool.ml#L485-L486
https://github.com/ocurrent/ocluster/blob/6f5f7c321261ba3cb4ca440b643cc7cc068fee06/scheduler/pool.ml#L592-L593

We could use PR #195 instead.


Issue update the input value when using useState hook

I am having issues update the input value when using useState hook.

dom-testing-library version:^5.2.3
react version:^16.7.0-alpha.2
node version:v10.14.1
npm (or yarn) version:1.12.3

Relevant code or config:

const LoginForm = () => {
    const [form, setValues] = useState({
        username: '',
        password: '',
    });

    const updateField = (e: React.FormEvent<HTMLInputElement>): void => {
        setValues({
            ...form,
            [e.currentTarget.name]: e.currentTarget.value,
        });
    };

    return (
        <>
            <form onSubmit={performLogin}>
                <label htmlFor="username">
                    Username
                </label>
                <input
                    type="text"
                    value={form.username}
                    onChange={updateField}
                />

                <label htmlFor="password">
                    Password
                </label>
                <input
                    type="password"
                    value={form.password}
                    onChange={updateField}
                />
                <button type="submit">Login</button>
            </form>
        </>
    );
}

What you did:
I am trying to update the username and password but to no avail. My code looks like the following:
import React from 'react';
import { render, getByLabelText, getByText } from 'react-testing-library';

it('renders the Login Form and allows a user to login', async () => {
    const usernameInput = getByLabelText(/username/i);
    const passwordInput = getByLabelText(/password/i);
    usernameInput.value = 'Mary';
    passwordInput.value = '****';
    getByText(/Mary/i);
});

What happened:

Reproduction:
Here is a code sandbox - https://codesandbox.io/s/7j7o12qv96

You should update them like this:
fireEvent.change(inputField, { target: { value: 'new value' } })

instead of
inputField.value = 'new value'

Have you tried that? I recall that the latter is no longer supported, but now reviewing the README I see that there are still examples in it using this way. If you confirm the first way of doing it in the examples above works, then maybe the README needs to be updated.

That works
fireEvent.change(inputField, { target: { value: 'new value' } })

Also, I'm not sure getByText would find an input element with that text being its value. getByText is meant to find elements that have that textContent. That could be an issue here as well.

Tbh, I am testing a mock api call so I wanted to check the values were being sent to the mocked api call. I just put the getByText there for this question.


[fix][test] Fix ExtensibleLoadManager flaky integration test

Motivation
We can’t use the admin client in the integration test because the test is running locally(outside the container). It can’t resolve the hostname. So when the admin receives the redirect response, the admin request will fail because the hostname cannot be resolved.
Example fail logs:
2023-12-22T20:53:45,390 - WARN  - [AsyncHttpClient-31-2:BaseResource$1@135] - [http://localhost:53650/admin/v2/persistent/my-tenant/my-namespace/testSplitBundleAdminApi] Failed to perform http put request: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted. Failed reason: Connection refused: pulsar-broker-1/<IP_ADDRESS>:8080

Modifications

Use docker cmd execute admin commend
Increase the timeout for some tests because the cmd execute is slow.

Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

Matching PR in forked repository
PR in forked repository: https://github.com/Demogorgon314/pulsar/pull/17

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8beac8b) 73.42% compared to head (95fb35c) 73.43%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##             master   #21799   +/-   ##
=========================================
  Coverage     73.42%   73.43%
- Complexity    32795    32806   +11
=========================================
  Files          1897     1898    +1
  Lines        140656   140668   +12
  Branches      15491    15492    +1
=========================================
+ Hits         103282   103300   +18
+ Misses        29297    29287   -10
- Partials       8077     8081    +4

Flag
Coverage Δ

inttests
24.20% <ø> (-0.05%)
:arrow_down:

systests
24.74% <ø> (-0.10%)
:arrow_down:

unittests
72.74% <ø> (+0.03%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 68 files with indirect coverage changes

@Demogorgon314 would it work if admin client accesses the proxy instead of the brokers?
similar as
https://github.com/apache/pulsar/blob/82237d3684fe506bcb6426b3b23f413422e6e4fb/tests/integration/src/test/java/org/apache/pulsar/tests/integration/proxy/TestProxy.java#L107-L110

@lhotari I have updated, PTAL again.


Support for AWS IoT

Type: Feature
Is your feature request related to a problem? Please describe.
Currently messaging only supports SQS and SNS, it would be great to have support for AWS IoT messaging as well.
Describe the solution you'd like
I would like spring cloud to subscribe and publish to AWS IoT topics that would be configured via annotations.
Support for @SendTo for a potential response topic would also be nice.
As would automatic extraction of path parameters.
Describe alternatives you've considered
Spring integration has MQTT support which might work either as an alternative or as a basis for support in spring-cloud-aws
Additional context
https://aws.amazon.com/iot-core/
https://docs.spring.io/spring-integration/reference/html/mqtt.html
If you think this is a worthwhile feature I'm willing to contribute.

@cyterdan @maciejwalkowiak Would be glad to contribute.

We will come back to this topic after 3.0 is released. There is no point in adding more integrations based on AWS SDK v1.
If you would find this integration useful, upvote this issue.


Keep using an old version of https://github.com/openshift/origin/pull/9181

I don’t know how to checkout a specific untagged commit ( 9ff4bf43548c758b6767b639b335681285fece48 ) from the original repo, so I have forked the project and fetched that commit from a cached Docker image.
We should instead update the containers/image client for the new API ASAP, and then the github.com/mtrmac/origin repo should be removed.

seems fine to me - but can I run it on my laptop with my gopath? (I assume no)

seems fine to me - but can I run it on my laptop with my gopath? (I assume no)

Why not? All this does is change the repo which is pulled from github, when building the container.

Why not? All this does is change the repo which is pulled from github, when building the container. It has no effect on your non-docker environment.

alright, I missed that, thanks for clarifying

feel free to merge then

Actually this breakage couldn’t have been caused by the openshift/origin#9181 API change because mtrmac/image:openshift-native-signatures is not yet merged; this must have been a signature-independent change. Looking into it now…


Comment form

renders comment form on click
no comment backend setup, for now the submit button writes to the console.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

40 of 93 (43.01%)  changed or added relevant lines in 10 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-4.2%) to 48.864%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

client/src/pages/LocationPage/ReviewSection/Review.tsx
5
8
62.5%

src/routes/users.ts
2
6
33.33%

client/src/pages/LocationPage/ReviewSection/index.tsx
6
16
37.5%

client/src/pages/WriteReviewPage/index.tsx
9
24
37.5%

src/routes/reviews.ts
8
29
27.59%

Files with Coverage Reduction
New Missed Lines
%

client/src/pages/LocationPage/LeftColumnDetails.tsx
1
90.91%

Totals

Change from base Build<PHONE_NUMBER>:
-4.2%

Covered Lines:
284

Relevant Lines:
487

💛  - Coveralls


FileList collapses when fields are edited

The tree should stay in it's current state when a change is made. Right now, when a change is made it collapses and has to be reopened each time something changes

@storrisi is this something you can track down?

Might be related to https://github.com/clearlydefined/website/issues/270#issue-354895564?

This is much more likely related to #343 , i will check out to see if react-table has now some updates to fix this problem.

This looks like to be a very complicated bug to solve.
If we remove the auto-collapse, react-table adds some undefined folders out of nowhere, that we are not able to remove from the outside.
I've searched from similar bugs but it looks like this should be solved with the version 7, which is currently in an alpha stage.

I've made some tests trying to fully control the table, instead of give the control to react-table itself, in order to keep the filelist open while updating, using the expanded prop and the onExpandedChange method from the official documentation.
But at that point the weird thing is that the pivotBy prop creates a fixed structure that apparently is not possible to mutate.
For example, given a folder structure like:
[
{'name': 'LICENSE.md', folder_0: '/'},
{'name': 'test.js', folder_0: '/'},
{'name': 'script.js', folder_0: 'tools'},
{'name': 'README.md', folder_0: 'lib', folder_1:'test'},
]

it considers that all the elements should have always the maximum value of folders (2, in this case).
Given that, it creates as many undefined folders in order to have all the files nested in the same way.
Real example:

As per discord discussion, we will try to find an alternative solution to react-table.

We've found a good solution in ant-design table.
Since we are already using ant-design for some elements in the UI, using the built-in Table component looks worthwhile.
It has also some useful behaviors out of the box that meets perfectly our needs.
I'm currently working on switching from react-table to ant-design and i will provide a PR soon.


sway: gsettings executed from sway/config fails

If one tries to use the Sway wiki's suggested fix for GTK3 app graphical configuration, they will find themselves failing in NixOS. I think I've tracked down why.
Background:

GTK3 doesn't respect ~/.config/gtk-3.0/settings.ini, for certain settings, under Wayland.
Sway recommends a script that calls gsettings set with values from settings.init to ensure the values in the dconf backend reflect the same values in the text file:

https://github.com/swaywm/sway/wiki/GTK-3-settings-on-Wayland

Executing the script manually, from a terminal under Sway, works as expected. When run from a command in ~/.config/sway/config as exec_always, it fails. I think this is because XDG_DATA_DIRS does not include the schema directories when Sway runs the command.
This is XDG_DATA_DIRS from a terminal under Sway:
/nix/store/7kdr875bhq5sgnh7x7xkkbbdq0a3qixv-termite-15/share:/nix/store/9v6jxyn1v2ncj4dnw317ibivzp8lkvzv-gtk+3-3.24.10/share/gsettings-schemas/gtk+3-3.24.10:/nix/store/7066ihqk8zlcd77ccb50m445v6dsxkz7-gsettings-desktop-schemas-3.32.0/share/gsettings-schemas/gsettings-desktop-schemas-3.32.0:/nix/store/9v6jxyn1v2ncj4dnw317ibivzp8lkvzv-gtk+3-3.24.10/share/gsettings-schemas/gtk+3-3.24.10:/nix/store/7066ihqk8zlcd77ccb50m445v6dsxkz7-gsettings-desktop-schemas-3.32.0/share/gsettings-schemas/gsettings-desktop-schemas-3.32.0:/home/cole/.nix-profile/share:/etc/profiles/per-user/cole/share:/nix/var/nix/profiles/default/share:/run/current-system/sw/share

But this is it when Sway executes it:
/home/cole/.nix-profile/share:/etc/profiles/per-user/cole/share:/nix/var/nix/profiles/default/share:/run/current-system/sw/share

Additionally, if I try to do this from inside the script, it prints "no schemas installed" when run by sway:
echo "$(GSETTINGS_BACKEND=dconf gsettings get org.gnome.desktop.interface cursor-theme 2>&1)" >> ~/log

Upstream issue: https://github.com/swaywm/sway/issues/4323 (sorta, the issue describe by OP seems somewhat different)
cc: @gnidorah @primeos

I think this is because XDG_DATA_DIRS does not include the schema directories when Sway runs the command.

Seems reasonable.
$XDG_DATA_DIRS differs in the terminal because termite uses wrapGAppsHook which adds a wrapper that looks like this:
#! /nix/store/xfghy8ixrhz3kyy6p724iv3cxji088dx-bash-4.4-p23/bin/bash -e
export GIO_EXTRA_MODULES='/nix/store/1i2824pmaclhcbddbk7r2yc7ni645x22-dconf-0.32.0-lib/lib/gio/modules'${GIO_EXTRA_MODULES:+':'}$GIO_EXTRA_MODULES
export GIO_EXTRA_MODULES='/nix/store/1i2824pmaclhcbddbk7r2yc7ni645x22-dconf-0.32.0-lib/lib/gio/modules'${GIO_EXTRA_MODULES:+':'}$GIO_EXTRA_MODULES
export GDK_PIXBUF_MODULE_FILE='/nix/store/9asda59pz0hg8bznxa64nx7n45v1szdz-librsvg-2.44.14/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache'
export XDG_DATA_DIRS='/nix/store/inlknqkinymvskvigpj345mfyfdvichx-gtk+3-3.24.10/share/gsettings-schemas/gtk+3-3.24.10:/nix/store/r3g9yn2cw6239szfq65q2cxw4cg35a81-gsettings-desktop-schemas-3.32.0/share/gsettings-schemas/gsettings-desktop-schemas-3.32.0:/nix/store/inlknqkinymvskvigpj345mfyfdvichx-gtk+3-3.24.10/share/gsettings-schemas/gtk+3-3.24.10:/nix/store/r3g9yn2cw6239szfq65q2cxw4cg35a81-gsettings-desktop-schemas-3.32.0/share/gsettings-schemas/gsettings-desktop-schemas-3.32.0'${XDG_DATA_DIRS:+':'}$XDG_DATA_DIRS
export XDG_DATA_DIRS='/nix/store/cp5g9b8rdq48zkqjlbnc47g3kq7l54bz-termite-15/share'${XDG_DATA_DIRS:+':'}$XDG_DATA_DIRS
exec -a "$0" "/nix/store/cp5g9b8rdq48zkqjlbnc47g3kq7l54bz-termite-15/bin/.termite-wrapped"  "${extraFlagsArray[@]}" "$@"

If you use another terminal emulator you should see the unmodified $XDG_DATA_DIRS like Sway sees it.
We could fix this problem by doing something similar for Sway. However, I'm a bit concerned about the closure size as this affects all users, even if they're not using GTK3 applications. But since most users should have the dependencies already installed and Nix isn't very minimalistic anyway we can probably get away with it. But it might still be best to make this configurable and use conservative defaults. It might be best to split Sway into sway and sway-unwrapped (but I am open for other ideas, I didn't spend much though on it yet).

I made the missing gsettings schemas available from sway by computing the path like this:
schema = pkgs.gsettings-desktop-schemas;
datadir = "${schema}/share/gsettings-schemas/${schema.name}";

And then exporting it to sway's environment by adding the following to sway's extraSessionCommands:
XDG_DATA_DIRS=${datadir}:$XDG_DATA_DIRS

Now the org.gnome.desktop.interface schema can be accessed from sway.

cc @jtojnar
This has my :eyes: because it seems like a simple issue.
Ref https://nixos.org/nixpkgs/manual/#sec-language-gnome, to anyone who hasn't read the newly added docs.

The diagnosis is correct.
We solve the issue in GNOME Photos test by wrapping GSettings tool:
https://github.com/NixOS/nixpkgs/blob/master/nixos/tests/installed-tests/gnome-photos.nix#L11-L25
The proper solution is https://github.com/NixOS/nixpkgs/pull/71079 using
https://github.com/NixOS/nixpkgs/blob/master/nixos/tests/installed-tests/gnome-photos.nix#L11-L25

@colemickens Is your issue fixed by #75247 ?

same here, i don't understand how to test the fix ? any light please ?

For me, this issue is still open. Here is my sway configuration:
sway = {
  enable = true;
  extraPackages = with pkgs; [ some_packages ];
  wrapperFeatures.gtk = true;
  extraSessionCommands = "export MOZ_ENABLE_WAYLAND=1";
};

Is it a config issue on my side?

There might be a regression with the GTK wrapper for sway, @primeos what do you think of this ?

There might be a regression with the GTK wrapper for sway, @primeos what do you think of this?

Don't know. I'm not using the GTK wrapper so far, but from this issue it looks like the GTK wrapper never fixed this problem.
From this thread it looks like we could e.g. solve this issue by adding gsettings-desktop-schemas to the build inputs of Sway's wrapper.nix (if withGtkWrapper = true). But I'm not sure what the best/preferred way to solve this is. Might e.g. be worth it to have a quick look at the X11 and GNOME modules and/or cc the team (or maybe the links from https://github.com/NixOS/nixpkgs/issues/67704#issuecomment-563344512 are already clear enough, I didn't have a closer look). A PR would be nice :) Thanks and good luck ;)

After some digging, it seems that wrapGAppsHook is not applying a "full" context (as opposed to termite for instance) to sway.
generated wrapper for Sway:
export GIO_EXTRA_MODULES='/nix/store/4fq6w7ksq1dba80sxpdgzrxpd46kdjgq-dconf-0.36.0-lib/lib/gio/modules'${GIO_EXTRA_MODULES:+':'}$GIO_EXTRA_MODULES

generate wrapper for Termite:
export GIO_EXTRA_MODULES='/nix/store/4fq6w7ksq1dba80sxpdgzrxpd46kdjgq-dconf-0.36.0-lib/lib/gio/modules'${GIO_EXTRA_MODULES:+':'}$GIO_EXTRA_MODULES
export GIO_EXTRA_MODULES='/nix/store/4fq6w7ksq1dba80sxpdgzrxpd46kdjgq-dconf-0.36.0-lib/lib/gio/modules'${GIO_EXTRA_MODULES:+':'}$GIO_EXTRA_MODULES
export GDK_PIXBUF_MODULE_FILE='/nix/store/d0r5r3zcjipx1qxqxmf1mqzwbay04vq3-librsvg-2.48.2/lib/gdk-pixbuf-2.0/2.10.0/loaders.cache'
export XDG_DATA_DIRS='/nix/store/6yrlycwcnxlgg6bkhq4jvwmahyrj00id-gtk+3-3.24.17/share/gsettings-schemas/gtk+3-3.24.17:/nix/store/78x2nyfhhili5ijd6l74z3flj63p92s0-gsettings-desktop-schemas-3.36.0/share/gsettings-schemas/gsettings-desktop-schemas-3.36.0'${XDG_DATA_DIRS:+':'}$XDG_DATA_DIRS
export XDG_DATA_DIRS='/nix/store/7m99r1fx36zndgxrilg6kppg8k0d6pjb-termite-15/share'${XDG_DATA_DIRS:+':'}$XDG_DATA_DIRS

Adding gsettings-desktop-schemas to buildInputs has not effect.
I'm still trying to figure out what's the difference between termite and sway's wrapper.

I could not manage to make wrapGAppsHook add the missing prefixes to the wrapper. If I add the prefixes manually (like the example from the documentation linked by worldofpeace) it works, but I cannot manage to make wrapGAppsHook add them automatically.
If somebody that has more knowledge than me on this subject can help, that would be great :).

This issue has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/some-lose-ends-for-sway-on-nixos-which-we-should-fix/17728/3


Update bech32 dependency to a version where tests succeed without needing bech32 to already be installed

Previously cabal test all failed for me due to bech32 not being installed.
See https://github.com/input-output-hk/bech32/pull/22

Example failure:
  test/AppSpec.hs:57:14:
  1) App, bech32 command-line, any bech32 string can be decoded to hex
       uncaught exception: IOException of type NoSuchThing
       bech32: readCreateProcess: runInteractiveProcess: exec: does not exist (No such file or directory)
       (after 1 test and 12 shrinks)
         MinString "aaaaaaaaa"

bors r+


Don't allow start node with master role after crash

Don't allow start node with master role after crash as cluster might be already recovered with new leader/master

Can be solved on k8s level, RestartPolicy: Never


Fix cargo:version_number - has only one :

See openssl code -- it uses a single colon. Also inlined arg into format to make it a bit more consice.
let openssl_version = openssl_version.unwrap();
println!("cargo:version_number={:x}", openssl_version);
if openssl_version >= 0x4_00_00_00_0 {
...

@bors r+
Thanks!

:pushpin: Commit f64f11d518e15bcb6167d31aaaaf561f09dc36be has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit f64f11d518e15bcb6167d31aaaaf561f09dc36be with merge 8725e78484d62c4dd0ef22bb64fb22e4af2f4a1c...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 8725e78484d62c4dd0ef22bb64fb22e4af2f4a1c to master...


write OCIRepository origin revision to event metadata

I have been experimenting with flux 2.4.0, and was surprised to find out that git commit status updates are not supported when using OCIRepository manifest sources, despite the examples in the docs https://fluxcd.io/flux/cmd/flux_push_artifact/#synopsis (permalink) suggesting to annotate the artifact with the source revision, for example, the first example shows using --revision:
flux push artifact oci://ghcr.io/org/config/app:$(git rev-parse --short HEAD) \
	--path="./path/to/local/manifests" \
	--source="$(git config --get remote.origin.url)" \
	--revision="$(git branch --show-current)@sha1:$(git rev-parse HEAD)"

What's the point of annotating these artifacts if the source revision is not used by the notification controller?

What I'd like to see is when reconciling a kustomization from an OCIRepository source, calls to KustomizationReconciler.event(...) that have the source available (some calls won't have a source, such as when access is denied) include the org.opencontainers.image.revision annotation that's included in the source manifest's annotations. One obvious example of where I'd like to see this is on the event successfully reconciled event:
https://github.com/fluxcd/kustomize-controller/blob/29080cbd8cd593ec7c756bc25630f6c11ddcbd2a/internal/controller/kustomization_controller.go#L198-L201

Since the kustomizev1.GroupVersion.Group + "/" + eventv1.MetaCommitStatusKey (ie kustomize.toolkit.fluxcd.io/revision) already contains the OCI tag and digest, it's probably best to add a new key to the event metadata, like the existing "org.opencontainers.image.revision" and "org.opencontainers.image.source" that are (read: should be) already present on the oci manifest's annotations

What's the point of annotating these artifacts if the source revision is not used by the notification controller?

They are meant for flux trace command, so you can trace back an in-cluster resource to it's Git origin.

Ah okay, either way I think my request still stands? I took a look at the code, what do you think about passing KustomizationReconciler.event(...) a Context and letting it attempt to see if the source is OCI since it already has the Kustomization, then append the metadata from it to the event? I could make a PR for that, then look at updating the notification controller to try and consume a different annotation first, if it exists?

I could also try to add the logic to lookup annotations on the OCI source directly to the notification controller, using the event's InvolvedObject to check if the associated source is OCI and if it has a revision annotation to parse. I'm betting that's the better option is to put the correct revision information in the event rather than having an event consumer do extra work to look up additional information.


Upgrade lexer to Automa.jl v1.0

Description
The lexer lexer.jl was generated with Julia v.16 (or lower) and Automa.jl v0.7 (or something around that version).
We should update to Automa.jl v1 and add a workflow to check if lexer.jl is up to date.
Related issues
To update the lexer for #123 we should update Automa.jl.

@JKRT I'm struggling to update to Automa.jl v1.0. A new requirement is, that the regex language needs to be without any ambiguities, see https://biojulia.dev/Automa.jl/stable/tokenizer/#Token-disambiguation.
So for example how to tell if fal will be Boolean false or class name falsomethingSomething.


Provide a .deb package for Debian based distros

Hi,
will it be possible to provide a .deb package for an easy permanent installation on Debian based distros?
Additionally, having a .deb package would make it possible to add linutil to deb-get:
https://github.com/wimpysworld/deb-get
Checklist

[X] I checked for duplicate issues.
[X] I checked already existing discussions.
[X] This feature is not included in the roadmap.

i have sent a request on the rust mailing list

Since linutil has scripts that modifies kernel arguments, adds removes drivers the probability of deb-get accepting linutil is low. See their contributing guide lines for info.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1086618


Project builds successfully, editor crashes on startup - "Access violation - code c0000005 (first/second chance not available)"

Hey, I've been playing with this plugin for a bit, and using standard packed vertex buffers seems to be fine, but trying to call the function CreateMeshSectionDualBuffer is giving me problems.
The full log is below:
Access violation - code c0000005 (first/second chance not available) UE4Editor_TerrainGen!URuntimeMeshComponent::CreateOrResetSection<FRuntimeMeshSection<FRuntimeMeshVertexNoPosition> >() [c:\program files (x86)\epic games\4.14\engine\plugins\marketplace\runtimemeshcomponent\source\runtimemeshcomponent\public\runtimemeshcomponent.h:86] UE4Editor_TerrainGen!URuntimeMeshComponent::CreateMeshSectionDualBuffer<FRuntimeMeshVertexNoPosition>() [c:\program files (x86)\epic games\4.14\engine\plugins\marketplace\runtimemeshcomponent\source\runtimemeshcomponent\public\runtimemeshcomponent.h:235] UE4Editor_TerrainGen!ALandActor::Generate() [c:\users\aslatas\documents\unreal projects\terraingen\source\terraingen\landactor.cpp:52] UE4Editor_TerrainGen!ALandActor::ALandActor() [c:\users\aslatas\documents\unreal projects\terraingen\source\terraingen\landactor.cpp:13] UE4Editor_CoreUObject UE4Editor_CoreUObject UE4Editor_CoreUObject UE4Editor_CoreUObject UE4Editor_Core UE4Editor_Core UE4Editor_Projects UE4Editor_Projects UE4Editor UE4Editor UE4Editor UE4Editor UE4Editor UE4Editor kernel32 ntdll
I apologize if this is something trivial, I'm a bit of a novice - I suppose it finds issue with line 86 of RuntimeMeshComponent.h but I've no real idea how to proceed.
I essentially recreated one of the examples to produce the inputs, but calling that particular function crashes the editor.
Here are the .h and .cpp files for the class:
LandActor_header.txt
LandActor.txt
I should note that moving the function call into BeginPlay allows the editor to start even with my actor loaded in the level, but trying to play in editor crashes as one might expect.
Rebooting UE4, VS, the PC, and refreshing/regenerating project files haven't helped, I think it's likely I've made some simple mistake with the arguments.
Thanks for the help.

Revisiting this today, the problem is a bit different than I thought. The dual buffer isn't the problem, as the regular CreateMeshSection function is giving me the same problem. I tried manually adding 4 vertices and the two triangles associated with them, which didn't help - I'm wondering if I've borked something with the installation. I had initially installed the plugin manually (with a few minor problems) before realizing I could install from the marketplace.
I'll reinstall the engine and plugin to see.

The crash persists after re-installing the engine and plugin, as well as starting a fresh project.
The RMC example project runs fine for me -  the only difference I can see is that while the example creates a base runtime mesh actor from which the animated mesh inherits, I was keeping the creation logic in the base actor class. This holds true in custom projects. I suppose I'll use the method that works!
That said, the engine crash and error message were cryptic enough that I'm unsure if I encountered a bug or it the error was in the chair the whole time.

The crash persists after re-installing the engine and plugin, as well as starting a fresh project.
The RMC example project runs fine for me -  the only difference I can see is that while the example creates a base runtime mesh actor from which the animated mesh inherits, I was keeping the creation logic in the base actor class. This holds true in custom projects. I suppose I'll use the method that works!
That said, the engine crash and error message were cryptic enough that I'm unsure if I encountered a bug or it the error was in the chair the whole time.


Am I the only one here thinks the sort and filter function is not working?

The sorting only sorts by data index, and filter function often make all the data rows disapper, and it is not only happening in my code but also happening in the docs/index.html. Can someone comfirm this please?

1, select area
2, click filter

Enter 50 a and a few b like so"

then select the first colum and set the filter like so:

then click OK and it's all gone

And sorting is only sorting by the row index

And are you sure this is going to work?

If the exceptRowTotalHeight is bigger than the canvas' height, not a single row is ever gonna show.

And all the
t && t.text ? t.text : "";
needs to be changed to
t && t.text != null ? t.text : "";
otherwise all 0s bind by code will be shown as empty string.

use filter without freeze

I'm not using freeze.

this is a problem about filter

@myliang Have you recently considered solving sort bug?

@myliang Any update fix for this?

@myliang Any update fix for this?

Having the same issue. Has anyone been able to fix it on their own?


Correct the paragraph and contents of middleware.md

The method and its description do not match.
To be good structure, the contents of the paragraph should be in order to match the order of the items listed at the beginning of the paragraph. I think this is a good rule to read paragraphs predictably.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@wplong11  Thanks for fixing this, big improvement.


Bug: insert_image hangs forever with a specific image

Current behavior
rust_xlsxwriter hangs forever when this image is inserted.

Expected behavior
The process should finish (at least with an error).
Sample code to reproduce
#!/usr/bin/env rust-script

//! cargo
//! [dependencies]
//! rust_xlsxwriter = { version = "0.79.3" }
//! ```
fn main() -> Result<(), rust_xlsxwriter::XlsxError> {
    let mut workbook = rust_xlsxwriter::Workbook::new();
    let worksheet = workbook.add_worksheet();
    let image = rust_xlsxwriter::Image::new("convert.png")?;
    worksheet.insert_image(0, 0, &image)?;

    workbook.save("test.xlsx")?;

    Ok(())
}

Environment
- `rust_xlsxwriter` version: rust_xlsxwriter = { version = "0.79.3" }
- Cargo.toml dependency line for `rust_xlsxwriter`: rust_xlsxwriter = { version = "0.79.3" }
- rustc version: rustc 1.77.0 (aedd173a2 2024-03-17)

Any other information
No response

Thanks for the report. I'll look into it

Thank you so much for fixing it so quickly!
confirmed that
#!/usr/bin/env rust-script

//! ```cargo
//! [dependencies]
//! rust_xlsxwriter = { git = "https://github.com/jmcnamara/rust_xlsxwriter" }
//! ```
fn main() -> Result<(), rust_xlsxwriter::XlsxError> {
    let mut workbook = rust_xlsxwriter::Workbook::new();
    let worksheet = workbook.add_worksheet();
    let image = rust_xlsxwriter::Image::new("convert.png")?;

    worksheet.insert_image(0, 0, &image)?;

    workbook.save("test.xlsx")?;

    Ok(())
}

is working.

The fix is now upstream in rust_xlsxwriter v0.79.4. Thanks for the report.


markAsTouched vs markAsUntouched

Hi @joanpablo
We have two methods in the model file
markAsTouched - https://github.com/joanpablo/reactive_forms/blob/master/lib/src/models/models.dart#L329
markAsUntouched - https://github.com/joanpablo/reactive_forms/blob/master/lib/src/models/models.dart#L363
Could you clarify why they have this difference?
https://github.com/joanpablo/reactive_forms/blob/master/lib/src/models/models.dart#L366
Why markAsUntouched crawls through the controls while markAsTouched does not do this?

The same relates to markAsDirty and markAsPristine.
They have the same naming structure but act different.

Hi @vasilich6107,
That's a good question.
We need to find the answer in the Angular Reactive Forms project.


Question 1 default name for function parameter confusing

The default parameter here is called "word", which is confusing because the function expects a sentence.
Repro steps:

Open app.html on a browser (chrome used in above screenshot)

I wouldn't necessarily say that it's a sentence, but it seems valid to change the starter code parameter to s, str, or something similar. Would you mind submitting a PR to fix it?

Fixed by #106.


Crash on time > now() - 15m AND time < now() - 5m

Added "AND..." to my query and influxdb completely crashed.

Any chance you have the log output? Even better, would you be able to add a failing test here:  https://github.com/influxdb/influxdb/blob/master/cmd/influxd/server_integration_test.go#L396 in a PR?

Log https://gist.github.com/wildchild/2031bfe961763753935a
Query: select sum(xxx) / 600 from yyy where time > now() - 1h and time < now() - 5m group by time(10m) fill(none)

Same crash with panic: runtime error: invalid memory address or nil pointer dereference for query select sum(zzz) from hhh where xxx = 'Z' and time > now() - 30m.

This should be fixed by PR #2288.


fix: warnAboutDeprecatedCJSRequire.js lost

Close https://github.com/dvajs/dva/issues/2065

Coverage remained the same at 87.282% when pulling 3a967a721f119a11f38686990d6600e6df4f9180 on fix/pkg-file-lost into ac494c7c566834f0a565aeeb41e80b5f238509cf on master.


How can I find names of GTypes -- I need the name for typeFromName() to get the GType

It seems that there is no complete list of GType names available, and some names are really hard to guess. We can use this C program which prints the names when we give the well known GTYPE C macro. Insert the desired GTYPE macro as G_TYPE_STRING, and compile and run the program.
// gcc -o t t.c `pkg-config --libs --cflags gtk+-3.0`
#include <gtk/gtk.h>
#include <stdio.h>
int main(int argc, char *argv[]) {

  printf("%s\n", g_type_name(G_TYPE_STRING));
  printf("%s\n", g_type_name(G_TYPE_SOURCE));

  return 0;
}

Reference: https://mail.gnome.org/archives/gtk-list/2017-September/msg00137.html

Starting with gintro v0.6.0 we have the get_type() functions available as well as we can use (g)typeFromeName(). The funny fact of the g_type_from_name() is, that it do not register the GTypes, so it does generally not work for GtkSourceView types before  the corresponding get_type() function is called.
So we try to provide all needed get_type() functions, which is not that easy at all. g_float_get_type() for example is not provided by GTK, maybe because gfloat is a basic type and C programmers use macros generally like G_TYPE_FLOAT. So we defined our get_type ourself, for gfloat by referring g_type_from_name("gfloat"). So generally all needed get_type() functions should be available now. typeFromName() can be used for most types, but may return 0 as long as corresponding get_type() has not been used. This behaviour is a bit strange indeed, it has been confirmed by one of the GTK maintainers for the GTK lib. listview.nim contains example use for typeFromName() as well as g_string_get_type().
This issue was about some strange GTK type names which can be hard to guess. Here is an extended C program which prints the type names of basic GTK types:

```// gcc -o t t.c `pkg-config --libs --cflags gtk+-3.0`
#include <gtk/gtk.h>
#include <stdio.h>
int main(int argc, char *argv[]) {

// basic types
printf("%s: %s\n", "G_TYPE_INVALID", g_type_name(G_TYPE_INVALID));
printf("%s: %s\n", "G_TYPE_NONE", g_type_name(G_TYPE_NONE));
printf("%s: %s\n", "G_TYPE_NONE", g_type_name(G_TYPE_NONE));
printf("%s: %s\n", "G_TYPE_INTERFACE", g_type_name(G_TYPE_INTERFACE));
printf("%s: %s\n", "G_TYPE_CHAR", g_type_name(G_TYPE_CHAR));
printf("%s: %s\n", "G_TYPE_UCHAR", g_type_name(G_TYPE_UCHAR));
printf("%s: %s\n", "G_TYPE_BOOLEAN", g_type_name(G_TYPE_BOOLEAN));
printf("%s: %s\n", "G_TYPE_INT", g_type_name(G_TYPE_INT));
printf("%s: %s\n", "G_TYPE_UINT", g_type_name(G_TYPE_UINT));
printf("%s: %s\n", "G_TYPE_LONG", g_type_name(G_TYPE_LONG));
printf("%s: %s\n", "G_TYPE_ULONG", g_type_name(G_TYPE_ULONG));
printf("%s: %s\n", "G_TYPE_INT64", g_type_name(G_TYPE_INT64));
printf("%s: %s\n", "G_TYPE_UINT64", g_type_name(G_TYPE_UINT64));
printf("%s: %s\n", "G_TYPE_ENUM", g_type_name(G_TYPE_ENUM));
printf("%s: %s\n", "G_TYPE_FLAGS", g_type_name(G_TYPE_FLAGS));
printf("%s: %s\n", "G_TYPE_FLOAT", g_type_name(G_TYPE_FLOAT));
printf("%s: %s\n", "G_TYPE_DOUBLE", g_type_name(G_TYPE_DOUBLE));
printf("%s: %s\n", "G_TYPE_STRING", g_type_name(G_TYPE_STRING));
printf("%s: %s\n", "G_TYPE_POINTER", g_type_name(G_TYPE_POINTER));
printf("%s: %s\n", "G_TYPE_BOXED", g_type_name(G_TYPE_BOXED));
printf("%s: %s\n", "G_TYPE_PARAM", g_type_name(G_TYPE_PARAM));
printf("%s: %s\n", "G_TYPE_OBJECT", g_type_name(G_TYPE_OBJECT));
printf("%s: %s\n", "G_TYPE_GTYPE", g_type_name(G_TYPE_GTYPE));
printf("%s: %s\n", "G_TYPE_VARIANT", g_type_name(G_TYPE_VARIANT));
printf("%s: %s\n", "G_TYPE_CHECKSUM", g_type_name(G_TYPE_CHECKSUM));
printf("%s: %s (%ld)\n", "G_TYPE_CHECKSUM", g_type_name(G_TYPE_CHECKSUM), g_type_from_name(g_type_name(G_TYPE_CHECKSUM)));

// other types
printf("%s: %s\n", "G_TYPE_SOURCE", g_type_name(G_TYPE_SOURCE));

return 0;
}

Output is

G_TYPE_INVALID: (null)
G_TYPE_NONE: void
G_TYPE_NONE: void
G_TYPE_INTERFACE: GInterface
G_TYPE_CHAR: gchar
G_TYPE_UCHAR: guchar
G_TYPE_BOOLEAN: gboolean
G_TYPE_INT: gint
G_TYPE_UINT: guint
G_TYPE_LONG: glong
G_TYPE_ULONG: gulong
G_TYPE_INT64: gint64
G_TYPE_UINT64: guint64
G_TYPE_ENUM: GEnum
G_TYPE_FLAGS: GFlags
G_TYPE_FLOAT: gfloat
G_TYPE_DOUBLE: gdouble
G_TYPE_STRING: gchararray
G_TYPE_POINTER: gpointer
G_TYPE_BOXED: GBoxed
G_TYPE_PARAM: GParam
G_TYPE_OBJECT: GObject
G_TYPE_GTYPE: GType
G_TYPE_VARIANT: GVariant
G_TYPE_CHECKSUM: GChecksum<PHONE_NUMBER>4224)
G_TYPE_SOURCE: GSource


Environment variable changes are reverted and gradle.startParameter is used to read system properties in init scripts

This PR:

Reverts the change for configuring init scripts via environment variables
(re)Migrates init scripts to use gradle.startParameter to read system properties

I suggest reviewing only the last 2 commits as the first 2 only revert the previous changes.
Relevant diff: https://github.com/gradle/gradle-enterprise-build-validation-scripts/pull/682/files/64f48ec26c9fb43c51d62d281a9c3a99554342e1..632519d8c0cf14190fe3ac6608b72ac50fd791d4

is there a good reason why the same problem won't manifest for other init-script consumers?

I expect this is a universal issue. In earlier versions of Gradle, what I discovered is that any modification to environment variables (changes, additions, etc.) are not reflected throughout the life of the Daemon process. It will be more common that you have Daemon reuse locally than in CI.
The other consideration is locally these environment variables are only included when invoking the scripts. In CI, the environment variables are always present in CI for every build invocation, though modifications are possible, it will be very infrequent.
I think this essentially makes it a non-issue for CI plugins. I believe this is the relevant Gradle issue: https://github.com/gradle/gradle/issues/10483

I'd request changes to apply these to the reference init-script. Namely, I think we can avoid the duplicate definition of getInputParam(name) by changing the signature to getInputParam(gradle, name).

I can follow up with a PR. 👍


Make whole featured piece home section clickable

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[x] I have updated the CHANGELOG
[x] I have requested at least 1 reviewer for this PR
[ ] I have made corresponding changes to the documentation

From my point of view, it would be better (and more friendly for users with touch devices) - instead of clicking whole piece - emphasise the CTA button (which is quite subtle right now)


add spinner to columnStatus with onChange

Hi, I would like to ask, if there is any possibility to add datagrid-spinner to columnStatus with onChange. Thanks

@jarda256 Maybe you can add a extra JS extension to your code. Something like here.
A won't add that at the moment. I think the spinner should be triggered after these not-data-related action like pagination, resetting filter, etc


Remove minify from project

It's unexpected. remove it. people can use a further minification loader to do this.

Thought about it but won't be backwards compatible.
Maybe for 3.0 but we will wait until webpack 2.0 is released.


I have a better idea for movement on desktop.

Instead of just wasd+space+c,
You click and hold with one finger to move, double-tap (no clicks) and hold one finger to move around
you can swipe with your two fingers on a trackpad to zoom in (swiping up) and out (swiping down)

I eagerly await a response from you, @violetfrost.

since mouse movement will be in v4...


For 150: updated list of implemented metrics

For !50:

updated the list of implemented metrics

This pull request #433 is assigned to @vatavuk/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job

@Vatavuk @paulodamaso I didn't see you took care of this, but I got the task assigned earlier and tackled it, see #435. I believe it's more complete that this one.

@paulodamaso ping

@sereshqua/z please review this job completed by @vatavuk/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

Pull request #433 was not merged, no payment for ARC, see §28

@Vatavuk please make sure you will find at least 3 issues during next CT
@paulodamaso please make sure all issues found by code reviewers would be fixed by you if you were pull-request author again
I've seen that this is no longer actual, but policy is policy

@sereshqua Will do, thanks

@sereshqua ok

@0crat quality acceptable


Only try deleting existing widget views

1. Why is this change necessary?
Validation
2. What does this change do, exactly?
Fix deletion of non existent widget view resulting in error
3. Describe each step to reproduce the issue or behaviour.
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/SW-25224
Please use this issue to track the state of your pull request.

Thanks for your Contribution! :blue_heart:


Table pushed to the left when embedding

When using a table outside of the notebook environment (e.g. in a React app), the form element is positioned too far too the left.

It looks like it is getting it from this style:
https://github.com/observablehq/inputs/blob/c868be98847171987a2a0929674b534e76e3ede1/src/style.css#L186

I don’t think we can fix this without breaking the styles on Observable. I’d suggest adding padding to the parent container when used in React, or overriding the styles.

ok.


'once' method is missing

Hi,
I've noticed your module is missing the 'once' method from the original socket.io
Any chance you'll be adding it anytime soon? Can I make the change and create a pull request?

yeah of course your pull request will be highly appreciated.

Thanks, but I'm trying to push my commit to a separate branch, but it seems like I'm not permitted

I don't know what is the problem

Alright, so I've managed to create a pull request. Turns out it was my bad.

thanks, it's your pull request has been merged. sorry for being late.


use annotated tagging to create a commitobject with the tag

Also using ' '  is safer for command line and that way tags that hold env variables or anything won't be executed by the command line

Why did you close the pull request?

travis didn't build :(

Failures:

  1) Fastlane Fastlane::FastFile Add Git Tag Integration generates a tag based on existing context
     Failure/Error: expect(result).to eq("git tag \"builds/test/1337\"")

       expected: "git tag \"builds/test/1337\""
            got: "git tag -am 'builds/test/1337 (fastlane)' builds/test/1337"

       (compared using ==)
     # ./spec/actions_specs/add_git_tag_spec.rb:17:in `block (4 levels) in <top (required)>'

  2) Fastlane Fastlane::FastFile Add Git Tag Integration allows you to specify grouping and build number
     Failure/Error: expect(result).to eq("git tag \"#{grouping}/test/#{specified_build_number}\"")

       expected: "git tag \"grouping/test/42\""
            got: "git tag -am 'grouping/test/42 (fastlane)' grouping/test/42"

       (compared using ==)
     # ./spec/actions_specs/add_git_tag_spec.rb:31:in `block (4 levels) in <top (required)>'

  3) Fastlane Fastlane::FastFile Add Git Tag Integration allows you to specify a prefix
     Failure/Error: expect(result).to eq("git tag \"builds/test/#{prefix}#{build_number}\"")

       expected: "git tag \"builds/test/16309-1337\""
            got: "git tag -am 'builds/test/16309-1337 (fastlane)' builds/test/16309-1337"

       (compared using ==)
     # ./spec/actions_specs/add_git_tag_spec.rb:43:in `block (4 levels) in <top (required)>'

  4) Fastlane Fastlane::FastFile Add Git Tag Integration allows you to specify your own tag
     Failure/Error: expect(result).to eq("git tag \"#{tag}\"")

       expected: "git tag \"2.0.0\""
            got: "git tag -am '2.0.0 (fastlane)' 2.0.0"

       (compared using ==)
     # ./spec/actions_specs/add_git_tag_spec.rb:55:in `block (4 levels) in <top (required)>'

  5) Fastlane Fastlane::FastFile Add Git Tag Integration specified tag overrides generate tag
     Failure/Error: expect(result).to eq("git tag \"#{tag}\"")

       expected: "git tag \"2.0.0\""
            got: "git tag -am '2.0.0 (fastlane)' 2.0.0"

       (compared using ==)
     # ./spec/actions_specs/add_git_tag_spec.rb:70:in `block (4 levels) in <top (required)>'

Finished in 2.11 seconds (files took 0.86535 seconds to load)
426 examples, 5 failures

Failed examples:

rspec ./spec/actions_specs/add_git_tag_spec.rb:12 # Fastlane Fastlane::FastFile Add Git Tag Integration generates a tag based on existing context
rspec ./spec/actions_specs/add_git_tag_spec.rb:20 # Fastlane Fastlane::FastFile Add Git Tag Integration allows you to specify grouping and build number
rspec ./spec/actions_specs/add_git_tag_spec.rb:34 # Fastlane Fastlane::FastFile Add Git Tag Integration allows you to specify a prefix
rspec ./spec/actions_specs/add_git_tag_spec.rb:46 # Fastlane Fastlane::FastFile Add Git Tag Integration allows you to specify your own tag
rspec ./spec/actions_specs/add_git_tag_spec.rb:58 # Fastlane Fastlane::FastFile Add Git Tag Integration specified tag overrides generate tag

It's just that the tests didn't pass, you can run the tests locally using rspec :+1:


HTML DOM anchors of Markdown headers are not rendered properly

Describe the bug

site/page.html#id1 brings the page site/
clicking on the toc works but copying its link copies site/#subtitle instead of site/page.html#subtitle

Thank you for this. So to clarify the problem is that when a link's address is copied it does not copy the actual page that that link directs to, right?

yeah, it doesn't copy the link to "an anchor" on the page. and also, it seems the site/page.html#id doesn't seem to be implemented which is very important for any website especially the kinds we build out of obsidian projects. when you type site/page.html/#id you get "kinda redirected" to site/.
so there are two issues here. the copying problem is easier to solve I think, but you might, if I am right (not exactly sure), need to rethink the whole design to actually make the copied link work.

I think I should be able to fix both of these pretty easily. I think the problem is due to the way I am overriding the normal loading process to allow new pages to be loaded without reloading the page. Thank you for reporting this bug :)

This should be fixed in 1.8.0. Let me know if it still does not work as expected and reopen the issue. If you find any new issues please submit a new issue :)
Thanks!


Tells me to uninstall. I did still no work :(

I'm using 1.0.7 and I'm in UK so yh my country is supported

I have same issue

Same here

Plus I get a cloudflare prompt the whole time. Only way to get through that is to click on the terms and accept the cookies for some reason.

same

Plus I get a cloudflare prompt the whole time. Only way to get through that is to click on the terms and accept the cookies for some reason.

Yep it's done that to me as well now

#109


Manage nat networking as well

It would be quite handy if weave would be the only service that managed containers network topology (so that containers could be started with --net none.
For this, weave needs to have NAT support for specific containers that are allowed to access "external network".

So if I understand this correctly it's not a good ideea to run weave / docker with --net="none".
Instead, in order to achieve app isolation we have to set --icc=false.
Is that correct ?
Asking because i'm only getting this when running with --net="none"
sudo weave run <IP_ADDRESS>/24 --net="none" --link mysql:db -v /var/www:/var/www:rw -v /var/run -p 80:80 -d --name lempp nginx
time="2015-01-22T22:23:47Z" level="fatal" msg="Error response from daemon: Cannot start container 7b1592655949f512cc4983ed0162f01d1a80645ac71a51d5682aa08b503720c9:  (exit status 2)"

Hi Alex,
There's no intrinsic reason why this wouldn't work, and what you are seeing is an internal error from the Docker daemon.  If I Google for similar messages I find people for whom the error went away when they restarted Docker - can you try that?
Separately, I don't think you should expect --net=none and --link to work on the same container.  But I don't think that's causing this error.

Hi Bryan,
Thanks for you swift reply. Indeed I think it's best to open a new one indeed. Looks like this isn't the only issue on my install.
Alex


CRUD urls on web

When making a request on mobile, our API is being hit with GET /users/123. However on web, it's instead OPTIONS /http://localhost:46843/users/123. For some reason the url the app is being served from gets injected into the request url.
It may be important to know that we have overridden the baseDirFn parameter of the configureRepositoryLocalStorage() method to return an empty string since path_provider isn't supported on web. This is the error we get when we don't override: Error: MissingPluginException(No implementation found for method getApplicationDocumentsDirectory on channel plugins.flutter.io/path_provider)
Is this the best way to get around the error?
We've also tested the todos app on web (again overriding baseDirFn), but we get the same result.

It could be a CORS related issue. I had the same problem when I moved to Flutter Web, you have to add an handler on your CRUD API to respond with an appropriate Access-Control-Allow-Origin to every OPTIONS request. It migth be Access-Control-Allow-Origin: * in non-productive environment.

No it's not CORS (I am working on the project with @christianmds) the problem is that the url that flutter_data is calling is injecting the domain that the web project is running on. For example the local API is running on localhost:3000 but flutter_data is calling http://localhost:3000/http://localhost:46843/users/123. In this example the web app is running on localhost:46843. CORS is not coming up as an issue... infact the call is happenign no problem and is 404ing... because there is no route that starts with /http://localhost:46843/.... And again to be clear this is not an issue when running on mobile.

Interesting... that definitely looks like a bug. Last time I tested on web was months ago and that didn't seem to be an issue with the Todos app, but it's very possible that stopped working.
Unfortunately I won't have time to look at this for at least 2 weeks. If you manage to find out, I'll happily review a PR.

@frank06 thanks for the response... I think we narrowed it down to the path_helper.canonicalize that happens in the / operator in the extensions file.
Uri operator /(String path) {
    if (path == null) return this;
    return replace(path: path_helper.canonicalize('/${this.path}/$path'));
  }

Seems that path.canonicalize is doing some stuff in the absolute method that inserts current into the string which according to the comments "On the browser, [style] defaults to [Style.url] and [current] defaults to the current URL.".
Not sure what the solution is here though since the addition of the host is happening within path library (and we do not have much experience digging around in there)... is canonicalize needed if the environement is web?

After a bit of experimenting, it looks like using normalize over canonicalize removes http://localhost:46843/ from the request url: return replace(path: path_helper.normalize('/${this.path}/$path'));
Our experience is pretty limited in this area, so we don't know the differences between canonicalize and normalize, or if this would end up breaking other things.


Virtualize just the worktree, not the git database (for local-only usage)

Are there any plans to make it possible to virtualize just the worktree, while using the physically present git databases? (i.e. without involving any remote server at all?)
This would be extremely useful since git databases are inherently compressed/deduplicated, and it's helpful able to browse them like normal folders without checking out many large files into a physical worktree.

No, this is not planned. VFS for Git's primary use case is for monorepos that are far too large to have entirely locally, so this would be contrary to the project's goals of enabling those repositories.

I believe this question has been answered, so I'm closing this issue.


[HACKTOBERFEST 2024] - CSS Colors Quiz

[!IMPORTANT]
This issue is part of our 2024 Hacktoberfest initiative. If you are interested in working on this issue, refer to our top-level tasks to see if this issue is claimed, or to claim it if it is not.

This issue is to create the CSS Colors quiz.
The file you should be working on is found in /curriculum/challenges/english/25-front-end-development/quiz-css-colors.
All quiz questions need to relate to one of these topics:

Topics

[!CAUTION]
Questions which do not fall under these topics will be rejected.

You are welcome to include code blocks in your questions, but please keep them short (four lines or less).
Please do NOT open a pull request until you have completed all questions. Your quiz should have exactly 20 questions.

Thank you for your interest in contributing. This issue will be opened for contribution when Hacktoberfest starts on October 1st.

[!CAUTION]
Pull requests which are created before October 1st will not be eligible for Hacktoberfest. We appreciate enthusiasm, but encourage you to hold off on contributing to this issue until the event has begun.

If you wish to be notified when this issue is opened for contribution, subscribe to notifications:

This issue is now open
If you would like to work on this issue, please leave a comment so we can assign it to you.
Be sure to read our contributing guidelines.

Hey @naomi-lgbt can you assign this issue to me ?

This issue has been assigned a contributor. To prevent extraneous notifications, the issue is now locked. If you have any questions, please reach out to me in our Discord community.


Update common.py

Statistics does not have Count.

I don't think ee.Reducer.count() can be applied to ee.Image. As I mentioned earlier, counting the number of pixels in Earth Engine is not recommended. The better way is to calculate area and then divide it by pixel size.


RU Discrepancy between Java Lib and Azure Portal for same query on Cosmos DB

Hey guys
So I am trying to gather some RU data to figure out how to proceed with some implementation I'm working on.
This is the query I am running:
SELECT TOP 1 * from c where c.field1= "id" OR c.field2 = "id"
Field 1 is the primary key, and field 2 is indexed in the collection.
When I run this query from the Java lib enabling cross-partition queries, and accessing the RU in responseHeaders["x-ms-request-charge"] (response.requestCharge always shows 0.0 which might be another issue entirely) I see an average of 165-171 RUs per query
When I run this same exact query on the Azure Portal, I'm seeing an average of 2.9-3.5 RUs

What is the reason for this discrepancy? Is there a difference in how RU is calculated between the two methods above? Caching? Implementation error? Bug with the Java lib?
Thank you - hopefully somebody can help me get to the bottom of this.

@mbhaskar - can you please take a look? Both the empty request charge and discrepancy in value. Ask @southpolesteve if you notice any funny business in the portal.

Thanks @christopheranderson looking forward to an answer

@mbhaskar  - can you please take a look? Both the empty request charge and discrepancy in value. Ask @southpolesteve  if you notice any funny business in the portal.


GSSoC: Adding light/dark mode feature

Currently the website is lacking the toggle mode feature .i can add the light/dark mode feature
Please assign me under GSSOC'24

Prerequisites: #24 before claiming any issue.

Followed the page everywhere except for facebook as i don't have an account for that.

@Swarnendu0123 assign this issue to me under GSSOC'24

@Swarnendu0123  can you assign me .
I had done this before  .
(https://github.com/oxiton-foundation/click-metrics/assets/111778403/06033059-a6da-4de3-8a2a-0cb5cac018c1)

@TomLucasakaTGeek assigned to you. Sorry @naisargi17, it already claimed by @TomLucasakaTGeek.

Thank you @Swarnendu0123

@Swarnendu0123 should I add a react component that toggles the theme or should I use tailwind property for dark mode, I am more comfortable with the former though

I would like to work on this issue , please assign this to me.
@Swarnendu0123

I would love to work on it.. kindly assign this to me

I would love to work on it.. kindly assign this to me

The same issue already exists!


Plans for a v1.0.0 release?

Hi! I think this library looks wonderful, and I'm very interested in using it in my company. Do you have plans to release a stable v1.0.0? I'm guessing many "production" use-cases would require that. It would certainly make it easier for me to integrate au.

Thank you very much for the highly detailed write-up! I imagine this info will be useful for many others also. It sounds like stability/reliability/testedness of the library is very good already.
I'll close this as resolved.


add missing editor encodings supported in the terminal and by iconv-lite

follow-up to 0d53acc, partially fixing #71591
Used the iconv-lite supported encoding list and the terminal settings windowsTerminalEncodings https://github.com/microsoft/vscode/blob/9b2e9634aa7cca984acd9d408bb4342cb1613aca/src/vs/base/node/terminalEncoding.ts#L12-L26 to add encodings that vscode already supports in the terminal but not in the file encodings.
Note that there are more supported single-byte encodings in iconv-lite that could be added to both the terminal list and the file encodings.
Verification: verify you can pick the encoding and save files with that encoding.

@bpasero any reason to keep this PR pending?

I have not heard an overwhelming ask by the community to have this, so I feel hesitant of just adding more encodings.


Add workflow source and snapshotId [SATURN-1621]

This adds the source and snapshot ID to the bard reporting. I noticed that we also report here: https://github.com/DataBiosphere/terra-ui/blob/dev/src/pages/workspaces/workspace/workflows/FailureRerunner.js#L64 so I talked to Adrian. If this is an automated retry, we don't need all that info, because it isn't a user triggering it. If it is a manual process, we do. It looked automated to me, but I would love experienced eyes to confirm.

I'm pretty sure rerunFailures is for the user gesture on the Job History tab that is offered when some jobs in a submission have failed. Seems to me like we should probably capture the same events in both places.
A little bit of history... when event capturing was originally going to be done my a 3rd-party contractor, there was a detailed spec created for all of the events to be captured: https://docs.google.com/spreadsheets/d/1wNmVyYbWbggRegJw4_n0HBfY6j2Qsz8pJTdcmeisvJ4/edit#gid=1641519238
Specifically, look at the "Implementation Spec" tab. The relevant rows in that spreadsheet are 184 ("Workflow Run Started") and 242 ("Relaunch Job"). The properties in both cases are the same so, while workflow source and snapshot are not in this spec, it looks to me like the intent is to capture the same data in both cases.

Got it, thank you @breilly2. Will update

I changed our rerunner to submit its own event, so that we can track those separately (especially since they have considerably different information now)
I also added namespace and name to the rerun event, although I wasn't sure if I should submit them as one field or as two.
Per slack discussion, it is currently very difficult to get information on the source and snapshot for reruns, because they are stored in the configuration, and not the submission. On the list page, we only get submission information. Fixing this to submit that information on retry would probably be rawls changes. That aside, from a product perspective, it is perfectly alright to treat reruns separately, because there are no edits made, so we could consider it as part of the same run as before.


Front Cam Video Recorder

Hello,
I have a small problem I don't know if anyone else is experiencing this, but when I try to record a video using front camera the frame of the result/output video size differs from the frame given, also the completion of the stopRecording function doesn't get called which is the even bigger problem
[self.camera stopRecording:^(LLSimpleCamera *camera, NSURL *outputFileUrl, NSError *error) {
NSLog(@"here");
}];
Anyone has any idea what's wrong here?
Thank you

Yeah this is happening for me too.

Same issue :-(

I have also same problem.. when i start recording video using front camera it will change the size of preview in AVExportsession. Please fixed it asap.
Thank you


Contributors should not be able to create or assign owner role

Users should not be able to upgrade their access. For example, if I'm a contributor, I should not be able to upgrade myself to Owner.

Viewers / Approvers cannot view permission tab, so this is the only hierarchy in question:

Owner
Contributor

We need to ensure that contributors cannot create or assign owner role.
Originally posted by @eastandwestwind in https://github.com/ethyca/fides/issues/2824#issuecomment-1473930096

moving to done


[Documentation] README.md matrix fixes for ffuf

Hi!
Thanks for releasing feroxbuster, it looks really fresh and has an intuitive approach to the job at hand ❤
I had a look over at the README.md and have a few additions regarding ffuf functionalities to the comparison matrix. Some of them are a bit vague, so feel free to disagree and I'll change the PR accordingly. I'm trying to explain them here in the description.

multiple target scan (via stdin or multiple -u)

As ffuf supports multiple wordlists, it's possible to use a wordlist for a list of hostnames. This list can also be supplied from STDIN (see the last entry in this list)

can accept urls via STDIN as part of a pipeline

Same as the above

can accept wordlists via STDIN

Ffuf can read wordlists (for hostnames, urls, headers whatever) from STDIN when using - as the wordlist path. This also supports optionally custom keywords (for example: -w -:HOSTNAME)

Your take on the column ease to use is absolutely on spot though 😆.

Good morning,
First off, thank you!  Second, your work with ffuf is awesome, and I'm a big fan.
I'm not shocked that I missed how those things can be accomplished using ffuf.  I mostly used the -h output and personal experience to fill out the matrix (obviously skipping over a lot of things that all three are capable of, i.e. not listing every single option/arg).
I appreciate you taking the time to check the tool!  If you have any additional feedback, I'm all ears.
Have a great day!
merged


Change package source repository

PopGen.jl is back into BioJulia, and we would like future releases to occur on that repo instead of my fork.

Are all registered already available in the BioJulia repository?  As far as I can see, https://github.com/pdimens/PopGen.jl is 85 commits ahead of BioJulia

@giordano I haven't merged all the branches yet, but that's the next to follow. There are a few repo things I'd like to do but don't have the right permissions to do so (like removing master and making dev the default branch). All the future releases will occur off of BioJulia. I'm not sure how to migrate previous released back up to the source repo though.

But if we merge this before you move everything, versions will become uninstallable for the users

That makes sense. I tried googling how merge releases back to the base repo and am coming up empty. Maybe I'm not phrasing the question correctly. Would you happen to know how I could move the tagged releases from my fork to the original one in BioJulia?

That would definitely be easier, but BioJulia has the original PopGen.jl, wouldn't it need to be deleted from that account? If that happens, my understanding is that Github will [somehow] choose one of the forks to be the origin, and transferring my fork back to BioJulia may inadvertently lead to the main package repo being incorrectly pinged as a fork.

That would definitely be easier, but BioJulia has the original PopGen.jl, wouldn't it need to be deleted from that account?

Yes

and transferring my fork back to BioJulia may inadvertently lead to the main package repo being incorrectly pinged as a fork.

Is that bad?  At the moment your repository is anyway identified as fork of something else when it's the upstream.  You can contact GitHub support to fix it.  You can for example ask to make your repository the upstream and BioJulia a fork, delete BioJulia's fork, move your repository there

Thanks for the guidance on this. pdimens/PopGen.jl is now the upstream and has been transferred to BioJulia/PopGen.jl. IIRC, all releases can safely be registered and tagged in BioJulia/PopGen.jl


Passing the --enable-msi-auth-for-monitoring flag will revert the enable_msi_auth_for_monitoring value back to False

Describe the bug
When passing the --enable-msi-auth-for-monitoring for az aks enable-addons, it will now revert the enable_msi_auth_for_monitoring value back to false (the default value was set to true). However this behaviour works with aks-preview extension. The reason of this issue is because aks-preview added the argument_context context for 'aks enable-addons'. Could you take a look and help investigate?
Related command
az aks enable-addons -a monitoring -g <> -n <> --enable-msi-auth-for-monitoring;
az aks enable-addons -a monitoring --enable-msi-auth-for-monitoring -g  -n  --data-collection-settings dataCollectionSettings.json;
Errors
--data-collection-settings can not be used without MSI auth. (this is cause by the enable_msi_auth_for_monitoring  set back to false)
Issue script & Debug output
N/A
Expected behavior
The cluster was created with MSI mode when using az aks enable-addons -a monitoring -g <> -n <> --enable-msi-auth-for-monitoring;
The cost command works fine.
Environment Summary
azure-cli                       2.50.0
core                              2.50.0
telemetry                      1.0.8
Additional context
This issue is due to the difference here in AKS-PREVIEW:

Thank you for opening this issue, we will look into it.

@wanlonghenry Thanks for reaching out to us and reporting this issue. We are looking into this issue and we will provide an update.

Fixing by #26844


Add a few details to build on debian buster to README

just add a few things I had work out to get things compiling

Nah. This is not needed or specific to debian. Just clone with --recursive. I updated the instruction on the wiki.

I've updated the README, hope it makes more sense now :)


Show succinct and encouraging achievement notifications in the Skills Display

Show succinct and encouraging notifications in the Skills Display when a user achieves

a level,
a badge or
completes a skill.

Some implementation ideas include using a message center like icon OR toast-like notifications.
Add ability for project admins to disable this feature.

was implemented via #1131


CFFL

CFFL

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_25md30go6a/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_25md30go6a/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
ERROR: /tmp/abs_25md30go6a/clone/recipe/meta.yaml:42: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_25md30go6a/clone/recipe/meta.yaml:42: missing_documentation: The recipe is missing a doc_url or doc_source_url
ERROR: /tmp/abs_25md30go6a/clone/recipe/meta.yaml:42: missing_dev_url: The recipe is missing a dev_url
WARNING: /tmp/abs_25md30go6a/clone/recipe/meta.yaml:42: missing_description: The recipe is missing a description
Errors were found

Linter check found the following problems:
The following problems have been found:
ERROR: /tmp/abs_60l5fikavo/clone/recipe/meta.yaml:14: pip_install_args: pip install should be run with --no-deps.
ERROR: /tmp/abs_60l5fikavo/clone/recipe/meta.yaml:21: missing_wheel: For pypi packages, wheel should be present in the host section
WARNING: /tmp/abs_60l5fikavo/clone/recipe/meta.yaml:42: missing_description: The recipe is missing a description
ERROR: /tmp/abs_60l5fikavo/clone/recipe/meta.yaml:42: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_60l5fikavo/clone/recipe/meta.yaml:42: missing_documentation: The recipe is missing a doc_url or doc_source_url
ERROR: /tmp/abs_60l5fikavo/clone/recipe/meta.yaml:42: missing_dev_url: The recipe is missing a dev_url
Errors were found


mleap demo notebooks need to updated to work with 0.8.1

mleap demo notebooks need to updated to work with 0.8.1. Right now they work fine with 0.5 but have not been updated to reflect the changes in the underlying mleap API.

combust/mleap-demo#12 was merged, closing


Fix 42325

Summary
Fixes the bracing issue as outlined in the original ticket.
Fixes #42325

Internal previews

📄 File
🔗 Preview link

docs/standard/serialization/system-text-json/use-utf8jsonreader.md
docs/standard/serialization/system-text-json/use-utf8jsonreader

thanks @BillWagner, have a good one


fix: usernameless demos

Link to the demos were broken.

Codecov Report

Merging #324 (210a740) into master (0dd29c7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #324   +/-   ##
=======================================
  Coverage   77.45%   77.45%
=======================================
  Files          87       87
  Lines        2400     2400
  Branches      402      402
=======================================
  Hits         1859     1859
  Misses        441      441
  Partials      100      100

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

up @ iamcarbon

@aseigler Does this affect your branch?

@aseigler Does this affect your branch?

No impact I don't believe.