Long value incorrectly decoded on Scala.js

The following test case fails on Scala.js:
import cats.data.Xor
import io.circe.generic.auto._
import io.circe.parser._
import io.circe.syntax._

val num =<PHONE_NUMBER>62369796L
val json = num.asJson.noSpaces
assert(decode[Long](json) == Xor.Right(num))

Thanks @tindzk—I'll take a closer look at this, but at a glance I think this is what you're seeing:

Also note that because scala.scalajs.js.JSON parses JSON numbers into a floating point representation, decoding a JSON number into a BigDecimal on Scala.js may lose precision.

Could you try decode[JsonNumber] and then toLong as a workaround?

Thanks! I tried the following code:
import io.circe._
import io.circe.parser._

println(767946224062369796L)
println(decode[Long]("767946224062369796"))
println(decode[JsonNumber]("767946224062369796"))
println(decode[JsonNumber]("767946224062369796").map(_.toLong))

Here is the JVM output:
767946224062369796
Right(767946224062369796)
Right(767946224062369796)
Right(Some(767946224062369796))

Unfortunately, it behaves differently on Scala.js:
767946224062369796
Right(767946224062369792)
Right(767946224062369800)
Right(Some(767946224062369792))

The problem is that circe uses JSON.parse parsing and decoding in Scala.js. When circe gets to convert to its AST the damage is already done.
> JSON.parse("767946224062369796")
767946224062369800
> JSON.parse("767946224062369796").toFixed()
"767946224062369792"
> JSON.parse("767946224062369796").toPrecision()
"767946224062369800"

I will make a PR to document the current behaviour.
The only way to fix this would be to include a "custom" JSON parser for Scala.js and let users choose between performance or correctness.

@jonas @tindzk I've just been thinking about this in conjunction with #476.
The idea would be that the fallback string decoder for numeric types would use circe's own number parser. That way Scala.js users would get the default JavaScript JSON parsing for ordinary JSON numbers, but if they wanted more precision they could represent their numbers as strings.
To me this seems less invasive than entirely changing the way JSON numbers are handled natively in JavaScript. The inconsistency isn't ideal, but I think that's part of the price we have to pay to work on a platform without nice numbers. (Not that the JVM is that much better. :smile:).

Yes, that is a good point. So some kind of Configuration.withStringlyTypedNumerics?

@jonas This would actually be the default, for both the JVM and Scala.js. It fixes the inconsistencies noted in #476, while also allowing Scala.js users to get more precision by representing their numbers as strings.

OK, will there be an option to turn it off when interoperability is needed?

@jonas When would that be necessary? Just to clarify, the decoding of { "n":<PHONE_NUMBER>62369796 } as a Long would remain the same (i.e. wrong) on Scala.js—you'd only get the improved behavior with { "n": "767946224062369796" }.

I'm not sure whether having custom behaviour in the decoding process is a good idea. I am concerned it will impact interoperability with other JSON libraries. Wouldn't it be better not to create invalid JSON in the first place? I suppose the standard imposes restrictions on the precision of numbers. So, asJson could fail if a number cannot be possibly represented in JSON.

@tindzk The issue is that the JSON standard doesn't put any restrictions on precisions—a JSON number can be as precise as you can fit in a string in memory (or more, I guess). The restrictions come from JavaScript, which in many cases isn't involved as a platform at all when working with JSON.
The behavior proposed in #476 doesn't customize JavaScript's JSON parser on Scala.js—it's entirely about decoding, and in my experience it's in line with other libraries in this respect. Representing numbers as strings when you need a lot of precision isn't uncommon—Jackson does it, other JavaScript stuff does it, etc. In circe I've done my best to make this unnecessary, and to make interoperability with libraries that do choose that route as easy as possible, and I think this is just an extension of that effort for Scala.js.

I see. Thanks for the clarifications. As @jonas suggests, an option for disabling this behaviour would still be desirable. I imagine the case where a developer wants to parse JavaScript-generated JSON and parse it in Circe. The decoding process should fail if Circe sees a string instead of a number.

@tindzk Would you mind opening a separate issue for that? Since the beginning, circe (like Argonaut) has silently fallen back to attempting to parse JSON strings as numbers during decoding for numeric types—#485 just makes this a little more robust (and more consistent on the JVM side).
You could do the extra validation you propose right now with prepare on the decoder, but if there's enough demand for built-in support (as an option, not the default) I'd be happy to add it.

Thanks for fixing the bug! I created an issue as requested.

For anyone running into this issue, as of v0.14.2 you can use the cross-platform circe-jawn parser on both JVM and JS (instead of circe-parser). The circe-jawn parser does not exhibit the problem reported in this issue, and generally will have the same semantics on both the JVM and JS.
I hope this might because the default parser in the future, see:

https://github.com/circe/circe/issues/1941


[cmake] Fix SWIFT_ANALYZE_CODE_COVERAGE

Pass the necessary linker flags as well as the compile flags to generate coverage.

@swift-ci please smoke test

I assume swift-syntax needs the same treatment?

Yeah looks like it

Does it make sense to have a code coverage CI CD pipeline for the whole Swift repository, allowing to write better tests?
Also, I've found these files to throw errors while merging.
swift-macosx-arm64/stdlib/public/core/default.profraw
swift-macosx-arm64/stdlib/private/RuntimeUnittest/default.profraw
swift-macosx-arm64/stdlib/private/StdlibUnittestFoundationExtras/default.profraw


add:usr: Allow to open the story's epic, iteration and/or project.

Unlike stories, those entities require the workspaceName to be
set in the URL. I therfore added workspaceName as a parameter in
the configuration.
While there I also added xdg-open on non-macOS platform. It will
most likely still be broken on Windows. /shrug
I used --oe for flags since commander will interpret somethign
like -Oe -O and -e.
Closes #74

Thanks for this!

Released in https://github.com/andjosh/clubhouse-cli/releases/tag/v2.1.0


Change response codes to confrom to OSB API spec

Fixes #211
In order to see clearly the picture of what responses there are now and which there should be, I created tables, which can be seen below. Those current responses, which needed to be (and has been) changed are marked with bold in tables.
For some cases the specification does not explisitly state what response codes there should be (marked as unspecified in table). Fixing the issue, I tried to conform to the current desing decisions. So, for those unspecified response codes I've left current 422, that's why I've made ServiceInstanceBindingDoesNotExistException to be mapped to 422 by default (see /last_operation in table 3).
Table 1. Endpoint: service_instances/<not_existing_instance_id>

Request
Response By SPEC
Current Response
Exception

GET
404
422
ServiceInstanceDoesNotExistException

PATCH
unspecified
422
ServiceInstanceDoesNotExistException

DELETE
410
422
ServiceInstanceDoesNotExistException

GET /last_operation
unspecified
422
ServiceInstanceDoesNotExistException

Table 2. Endpoint: service_instances/<not_existing_instance_id>/service_bindings/<some_binding_id>

Request
Response By SPEC
Current Response
Exception

PUT
unspecified
422
ServiceInstanceDoesNotExistException

GET
unspecified
422
ServiceInstanceDoesNotExistException

DELETE
unspecified
422
ServiceInstanceDoesNotExistException

GET /last_operation
unspecified
422
ServiceInstanceDoesNotExistException

Table 3. Endpoint: service_instances/<some_existing_instance_id>/service_bindings/<not_existing_binding_id>

Request
Response By SPEC
Current Response
Exception

GET
404
500
ServiceInstanceBindingDoesNotExistException (it's not mapped)

DELETE
410
410
ServiceInstanceBindingDoesNotExistException

GET /last_operation
unspecified
500
always UnsupportedOperationException (see  #213 )

@ilyavy thanks for the PR and the detailed explanation!


Update Enchanter.java

Added Comment

I’m not sure but the thing causing the crash with newer versions of EIO than 5.1.53 might be somewhere in here


[mini.pick] picker not closing after an error caused when opening the file

Contributing guidelines

[X] I have read CONTRIBUTING.md
[X] I have read CODE_OF_CONDUCT.md
[X] I have updated 'mini.nvim' to latest version

Module(s)
mini.pick
Description
I was testing events called in form of VeryLazy or such thing that made mason won't load when I open a file that contains extension to be fowarded into the linter daemon (in this case eslint_d was installed with mason, but nvim-lint can't open the binary because mason registry path wasn't loaded yet because the plugin wasn't loaded yet) so I accidentally opened mini.pick and the error happens.
after dismissing the error (by pressing ENTER) the picker won't close or be dismissed, although we can spawn another picker and do such things without any bugs, its just the last picker won't close.
but we can close it by closing the buffer and it won't happen again.
some pics:

in this case, mini.pick overlays the error message causing the error unreadable (but the window focus will be directed to the error window) so that when you press ENTER it will go into the error window instead of mini.pick.

after the error above, the picker still exist and won't close until you close the buffer.

you can still spawn mini.pick but it will overlap the last picker (normal usage, there are no bugs)
idk this might be a very edge case or so, just pointing out, I really want to take a look in the code but haven't yet figured it out (I'm new to mini environments but already moved several of my plugins to mini (like 7 plugins) so it won't grow a hefty size in my memory I can just use mini if its already available here.
env:

macos sonoma
alacritty + tmux

Neovim version
0.10.2
Steps to reproduce

nvim -nu minimal.lua
put mason in lazy load state (while an lsp or linter is already installed)
open mini.pick
open file that relates the linter with (e.g: ts files with eslint_d)

Expected behavior
if there are errors we could just destroy the picker, i think...
Actual behavior
defined above in the description (with images).
here are the video observation:
https://github.com/user-attachments/assets/2578a502-cd1e-4d70-b8cb-a87df3229aea

Thanks for the issue!
I can partially reproduce this with MiniPick.ui_select({'1'}, {}, function() error("Ooops!") end): picker window is indeed overlaying the error message but it goes away after pressing <CR>. So this is more about how picker react to the error when executing function from the mapping. I'll take a look.

hi thanks for replying, is there something I can help to fix this? (maybe I'll try to read some of the stuff in mini.pick repo first)

Thanks for the suggestion!
I think I already have it fixed. Would you mind installing 'mini.nvim' from backlog branch and see if it fixes your particular case?

yes its working! thank you very much @echasnovski (although this is a very edge cases, you still respond T__T)

yes its working! thank you very much @echasnovski (although this is a very edge cases, you still respond T__T)

Great! And it is not that edge case as proper error handling is a good idea anyways (and I kind of surprised 'mini.pick' didn't handle it earlier).
I can't merge the fix today, so hopefully tomorrow.

This should now be resolved on latest main. Thanks for the early feedback!


修复doccano.py和labelstudio2doccano.py中打标工具导出数据不匹配的问题

PR types

PR changes

Description

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.wstealth3 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Try random iptables command to fix jwt test

Workaround https://github.com/istio/istio/issues/35384

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2dbf7aca824b0a6f0a0526f6a6c775859822e99f
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@howardjohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

release-notes_istio
2dbf7aca824b0a6f0a0526f6a6c775859822e99f
link
true
/test release-notes_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/cherry-pick release-1.11

/cherry-pick release-1.10

@jwendell: new pull request created: #35399

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ericvn: new pull request created: #35400

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Virtual Functions in C++

Description
A virtual function is a member function that is declared within a base class & is re-defined by a derived class. They are mainly used to achieve Runtime Polymorphism. Functions are declared with a virtual keyword in the base class so that Late Binding can be done. Virtual functions cannot be Static.
For Example,
class A
{
public:
virtual void f1( )
{
// Some piece of code
}
};
class B: public A
{
public:
void f1( )       // Method Overriding
{
// Some piece of code
}
void f2( )
{
// Some piece of code
}
};
void main( )
{
A*p, obj1;    // Pointer is of A class
B obj2;        // Object 2 belongs to B class
p=& obj2;   // Pointer points to object 2 which is of class B & due to virtual keyword Late Binding will occur ( due to late
binding, compiler take the address of pointer at runtime i.e address of object 2 (of class B)  will be considered
instead of pointer object of class A .
p->f1( );      // Function belong to class B will run due to Late binding
Domain
CPP
Type of Contribution
Addition
Code of Conduct

[X] I follow Contributing Guidelines & Code of conduct of LearnCPP.

/assign


Specialist briefs can be open for 1 or 2 weeks.

For this  story on Pivotal.
This PR adds a new flag to the find_briefs route. This is invoked by the buyer frontend when getting a list of briefs for the catalogue.
The human flag is passed to the API to make it return a list of briefs sorted in a human readable way. PR on the API can be found here

👍


Windows missing WebP support

WebP support

Fade animation code should be here: https://github.com/molinch/FFImageLoading/blob/master/source/FFImageLoading.Windows/TaskParameterExtensions.cs#L43
WebP support - We need some C# decoder. If someone have an info about it - let me know.

This seems to have Windows WebP Support: https://github.com/chenrensong/ImageLib.UWP

We accept Pull Requests if anyone is interested to implement it :+1:

@daniel-luberda should we care? TBH Windows Phone is a dead market, so I don't think focusing on new features for it is really the best

You're right about Windows Phone, but UWP apps also work on desktop / metro PCs which is quite popular.

https://github.com/luberda-molinet/FFImageLoading/issues/858

All I need is a code / nuget / lib which will decode Stream to bitmap / raw pixels / WriteableBitmap. Anyone?


Implement quick and dirty simd intrinsics for sgr

https://beta.arewecompressedyet.com/?job=master-52074d09a3563fe7c2ea0730c13ec919052b847c&job=sgr_simd_0%402019-08-02T00%3A11%3A25.533Z
~10% speedup.

Coverage increased (+7.2%) to 88.901% when pulling 0e384753c59e88dfdb64c2df00fc4ba6efacb777 on KyleSiefring:sgr_dumb_simd1_review into 285101de66b7b6f6c371d06a21fe1c2b5994e1b3 on xiph:master.


[Scheduler App] [Bug] Prevent adding same Domain twice in a single meeting

The Scheduler App should not allow the same domain to be added twice to a single meeting.
Add a validation to prevent this behavior for SDK Review and any other meeting type where Domains are asked.

This has been changed on the table in the dataverse, now there's a new key that only allows 1 instance of any domain per event.
Still, changes are needed in the UI to let the user know that the error is actually expected.


Add TMC6200 Driver

Added a driver for the TMC6200 in SPI Mode. Followed the same structure used in the DRV driver.
This was only tested on STM32 but should work on any hardware.

I love it, thank you so much!

We merge new changes to the dev branch, so I have changed the base of this PR to be simplefoc:dev
Since your changes are additive only, it still applies cleanly.

There is a small problem when compiling for AVR (Arduino UNO)
/home/runner/Arduino/libraries/Arduino-FOC-drivers/src/drivers/tmc6200/TMC6200_Registers.hpp:3:10: fatal error: cstdint: No such file or directory
[347](https://github.com/simplefoc/Arduino-FOC-drivers/actions/runs/5409668668/jobs/9830138817?pr=23#step:3:349)
 #include <cstdint>

Looks like this header doesn't exist on that platform. I'll merge it and fix it afterwards.

Thanks,
just noticed that as well, seems like cstdint isn't included on AVR for some reason

I've merged it, I'll fix the UNO compile problem before the next release.
Thank you so much!
What a great contribution, including documentation and nice clean code.
I know there are others using the TMC6200, so I'm sure this will help some people!


Use proper World capitalization in the main example

In the README.md, at least this assertion
https://github.com/markhildreth/test-context/blame/main/README.md#L57
fails, so seems easier to capitalize every other "world" occurrence to ensure all examples are correct.

@SomeoneToIgnore Good catch, thanks for the PR!


Bonfire - Title Case a Sentence

As it is at the present moment, the starting code format for Title Case a Sentence misses a semi-colon at the end of the last line as shown in the picture.

I would've fixed the issue myself but I think this comes from the challenge seed in the db.

Resolved in PR #57


Fix "take every value" in python

Fixes #257
Mixed feelings about this solution.  There is no way to exclude two types, for example.
The alternative would be to explicitly list the types that we want to allow user to use "value" field with.  There are about 7

I'm unsure. I think this could be a reoccurring problem in different languages. One solution could be that we do an ancestral crawl and just pick the highest match. Maybe should have dialogue about this before doing anything?

I'm unsure. I think this could be a reoccurring problem in different languages. One solution could be that we do an ancestral crawl and just pick the highest match. Maybe should have dialogue about this before doing anything?

not sure i follow; yes let's discuss


operator can not read the hostPath mount model

Hello, I deployment the ovms chart use the command:
helm install ovms-pipeline ovms --set models_settings.config_configmap_name=ovms-pipeline,models_settings.single_model_mode=false,models_repository.models_host_path=/opt/,models_settings.model_path=/opt/

And I follow the demo steps :https://github.com/openvinotoolkit/operator/blob/main/helm-charts/ovms/README.md#demo---deployment-of-the-model-server-with-a-vehicle-analysis-pipeline
The pod can running:
kubectl get pods | grep ovms
ovms-pipeline-b845894db-6qzwc    1/1     Running   0          11m

But it report the errors that it can not find the hostPath model:
[2023-12-22 08:15:54.859][127][modelmanager][error][modelmanager.cpp:1340] Directory does not exist: /opt/vehicle-detection-0202/
[2023-12-22 08:15:55.860][127][modelmanager][error][modelmanager.cpp:1340] Directory does not exist: /opt/vehicle-attributes-recognition-barrier-0042/

I add the config:
models_repository:
  runAsUser: 5000
  runAsGroup: 5000

But it can not work as expect.
I can login the pod to see the model files has mounted into pods:
ovms@ovms-pipeline-b845894db-6qzwc:/models$ ls
cni  containerd  img_arrays_for_acc.txt  vehicle-attributes-recognition-barrier-0042  vehicle-detection-0202
whoami
ovms

Can anyone can help with this issue?Thanks a lot.

In the config.json file added to the configmap, there should be updated the path to the model. Probably the sed command was not executed. The models are mounted in /models folder but the config.json is expecting them in /opt.


Call stale callback

When leadership changes, some pending command may never get called. We should handle this to make client failed more quickly and avoid timeout in tests.

implemented via #500


Loading and saving simulation environments

Add a feature that allows the user to load a full simulation from yaml files and save their current simulation to yaml files.

Single environments can now be saved and loaded to and from yaml files.


External code review

The code base could benefit from another set of eyes. We could ask @rwblair to look at the code base at  some point.

That'd be awesome. Would you mind, @rwblair? Let's talk about this today at the meeting.

I think this is ready for a review, @rwblair

I don't think it makes much sense having this open as an issue for one year now... should we close and reopen if we have someone to do this? - @chrisfilo


Add support for configuring dedicated gateway node

Signed-off-by: Aswin Suryanarayanan<EMAIL_ADDRESS>

/cc vthapar /cc sridhargaddam

/cc KevinFCormier

/recheck

/lgtm

I dont see an option to squash the commit and merge this PR. @aswinsuryan the PR looks good. Can you squash the commits, so that we can merge it?

/cc vthapar sridhargaddam

@aswinsuryan I think you need to use @ in front of the user id to actually tag people

/cc KevinFCormier

Same here

/approve


Forcibly fetching current branch fails

When ensuring the current branch, forcibly fetching the current branch fails:
$ git 'fetch' --force origin main:main
fatal: Refusing to fetch into current branch refs/heads/main of non-bare repository

Example skill execution: https://go.atomist.com/T29E48P34/log/4b78a8ff-0d4e-4715-aaf4-7607564ccffd/b2CSRQTJ53kEjDVAVITrZ?OnNraWxsLWZpbHRlcjo6S0hzNmJtRnRaU0FpYTJWbGNDMWhMV05vWVc1blpXeHZaeTF6YTJsc2JDSXNJRHB1WVcxbGMzQmhZMlVnSW1GMGIyMXBjM1FpZlNrPQ=

The --update-head-ok option may be what is needed.
https://stackoverflow.com/a/19205680/5464956


Trim modules

PR description
Trims down the project to only include the following modules, and others that these depend on:
tuweni-bytes
tuweni-config
tuweni-concurrent
tuweni-crypto
tuweni-devp2p
tuweni-io
tuweni-net
tuweni-rlp
tuweni-toml
tuweni-units
tuweni-ssz

Fixed Issue(s)

fixes #15

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: macfarla:x: lu-pintoYou have signed the CLA already but the status is still pending? Let us recheck it.

one thing though - I believe we invested in tuweni-ssz to make it robust enough for a besu ssz implementation.  We might want to keep that

one thing though - I believe we invested in tuweni-ssz to make it robust enough for a besu ssz implementation. We might want to keep that

Not sure I understand, I didn't remove ssz. So you want to keep or remove? Teku seems to be using it

Not sure I understand, I didn't remove ssz. So you want to keep or remove? Teku seems to be using it

My bad - I read tuweni-ssz as removed, not kept. 👍


Add output option to adapter-vercel

This PR adds the ability to set a build output directory when using adapter-vercel.
The Vercel deployment app doesn't have a default build directory set for SvelteKit: it has one for "Svelte" and "Sapper", but it's not .vercel_build_output as it's set on this adapter, so I didn't see a reason not to allow setting a different one 😃
I noticed that this option existed on adapter-node and it's even officially documented, so I just copied the approach for this adapter and left the previous default as is.

.vercel_build_output isn't documented, but it's something Vercel added recently specifically to support use cases like ours (@antony knows more details). Is there a reason you would want to change it? At the moment it Just Works — the building happens on Vercel's servers and there's no additional config necessary

It's actually briefly documented here - if we swap away from .vercel_build_output we'd also need to adjust the adapter output and I believe we'd also lose the automatic serverless function detection.

So what you are saying is that, during this step of the deployment, if left empty, the build output directory will be .vercel_build_output?
I thought that, for non-automatically detected frameworks, you still had to specify the build directory, because I thought Vercel would use public if it exists, and . as fallback (it's what I understood from their docs and the placeholder on step field itself).
Anyway, if everything already works with the defaults, I guess there is no reason to use a different directory, so this option is not really needed.

I'm not certain but I think it might be less 'everything already works with the defaults' and more 'everything will break if you don't use the defaults', since .vercel_build_output has special meaning. Even if it is configurable I'd argue there's no real value in being able to do so, so I'll close this — thank you

Yeah, I just had misunderstood the Vercel default. Agreed 🙂

Yeah, I just had misunderstood the Vercel default. Agreed 🙂


fix rtx where

Fixes #22

Codecov Report
Base: 82.69% // Head: 82.86% // Increases project coverage by +0.16% :tada:

Coverage data is based on head (d6586e2) compared to base (40b994c).
Patch coverage: 97.22% of modified lines in pull request are covered.

:exclamation: Current head d6586e2 differs from pull request most recent head 1fb8a38. Consider uploading reports for the commit 1fb8a38 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   82.69%   82.86%   +0.16%
==========================================
  Files          67       67
  Lines        2028     2048      +20
==========================================
+ Hits         1677     1697      +20
  Misses        351      351

Impacted Files
Coverage Δ

src/cli/current.rs
100.00% <ø> (ø)

src/cli/env.rs
100.00% <ø> (ø)

src/config/config_file/tool_versions.rs
93.65% <ø> (ø)

src/runtimes.rs
68.87% <ø> (-1.00%)
:arrow_down:

src/cli/uninstall.rs
88.00% <90.90%> (+6.75%)
:arrow_up:

src/cli/ls.rs
98.11% <100.00%> (+0.11%)
:arrow_up:

src/cli/where.rs
93.33% <100.00%> (+3.33%)
:arrow_up:

src/config/toolset.rs
94.62% <100.00%> (+0.50%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


[NFC] Link out to Swift.org for release branch PR form and process

In an effort to centralize the release branch PR form and nomination process, remove the recently added release branch PR template and provide links to the relevant section on Swift.org in the default PR template and CONTRIBUTING.md.
This move was agreed upon by the Contributor Experience Workgroup.
Concurrent PRs:

https://github.com/apple/swift-org-website/pull/688
https://github.com/apple/swift/pull/74117
https://github.com/apple/swift-docc/pull/940

Guess I now also need to update sourcekit-lsp again, where I just added the templates 😆 https://github.com/apple/sourcekit-lsp/commit/b844dd3235e1d3d8ac917304e2cbd62ec302883f

How is this issue template related, though? 😅

How is this issue template related, though? 😅

Ah, I see, you meant this commit.

I will amend the doc to point to the website once https://github.com/swiftlang/swift-org-website/pull/688 is merged.

@swift-ci Please test

@swift-ci please test Windows


handle error case newBlockAttemptCallback better when simulation itself fails

we should just store the latest handleUnexpectedError and have a way for user to clear it


Css color input error

🍰 Pullrequest
css color change
Issues

fixes #604

This issue should be pushed to the next deployment. @ogerly @Mogge


Datepicker dependencies docs

Documentation Feedback
When using MatMomentDateModule, it's not obvious how to get it working from the docs. Even googling gets you to slightly droll posts like https://github.com/angular/components/issues/12887
Affected documentation page:
If you go here:
https://material.angular.io/components/datepicker/overview#choosing-a-date-implementation-and-date-format-settings
It says to install moment.
If you go to Moment, it says to do:
npm i moment
You still get an error from import { MatMomentDateModule }
You must also do:
npm i @angular/material-moment-adapter
While Angular could probably say "that's Moment's issue" and Moment could say "No, that's Material's issue" I think it would be best to mention on the doc page here:
https://material.angular.io/components/datepicker/overview#choosing-a-date-implementation-and-date-format-settings
To say:
To install
npm i moment
npm i @angular/material-moment-adapter
In your module:
import { MatMomentDateModule, MomentDateAdapter } from "@angular/material-moment-adapter";
While https://github.com/angular/components/issues/12887  is certainly dead accurate, it shouldn't be necessary to google all over the place due to documentation terseness.
My guess: Most large development projects already have a package.json and an app.module.ts that's just loaded with all kinds of junk, so "it' just works". I was doing a coding challenge and going step by step and ran into this.
There are three other similar bugs, all of them locked, and none with a resolution.
(I do find in general, while the documentation is very beautiful, the "TS" tabs frequently don't show the proper module imports).
Seriously - big thumbs up to the look and feel of the docs, and the amazing completeness in most areas. Let's get it the rest of the way!

I find this a very good point.
What is not so clear for me is that in one angular project I work, I use mat-datepicker with @angular/material-moment-adapter and I also in code do: import { Moment } from 'moment'; without having it installed through package.json how can this be?
Question for docs, do we really need to install moment?

@x1c0 It might be that another dependency in your project brings in moment. The material-moment-adapter package just has a peer dependency on moment, so moment will never be brought in automatically by the @angular/material-moment-adapter package itself.
I agree though that the documentation about installing moment etc. could be more clear.


address type load exceptions

Type load exceptions have been an annoyance for a while now. Would love it if I could handle these by providing solution-specific paths.

I did this in the WinForms project here


Wrong number of threads in server examples

Beast version 107
I've chosen beast/example/advanced/server/advanced_server.cpp as the starting block for my project as I need to serve HTTP and websocket connections. I have noticed that the number of threads is being taken from argv[3] whereas I believe it should be argv[4].
I have looked at a couple of the other examples and noticed the same error.
While I'm here hope I could ask a quick question...  I am adding SSL support (I need an SSL-only server so I felt the server-flex example wasn't quite the right fit for me) so I was comparing with the http_server_async-ssl example. I noticed that it uses common/write_msg.hpp whereas advanced_server doesn't. Should it be? Is there any significance in that? Also the comments in write_msg describe how it uses async_write_some but I don't see it. I'm new to Asio and Beast so I might have misunderstood, but I don't see a composed operation, just a single call to boost::beast::http::async_write - apologies if I have misunderstood what's going on there!
Thanks,
Dave.

Looks like you found some bugs in the examples :) These will be fixed in version 108, which I will submit as a pull request shortly.
The purpose of async_write_msg is to manage the lifetime of the outgoing HTTP response. It has to be valid for the duration of the async operation. But where would we store it? We can't make it a data member of the class because the outgoing response can have different types. For example response<file_body> and response<string_body>. So async_write_msg allocates storage to hold the response. boost::http::async_write is a composed operation which uses async_write_some under the hood. So the documentation for async_write_msg is accurate.
The reason that advanced-server doesn't need async_write_msg is because it already has its own mechanism for storing type-erased response messages: the queue object which implements the pipelining.
I will look at the other servers and see if maybe I can get rid of async_write_msg.

I'd like your input on the changes: https://github.com/boostorg/beast/pull/747

Apologies, I've been away from the office. I'll catch up with the latest updates today!


add missing field

Resolves #25
I'm intending to set up something like blue green deployment (or just a test/staging environment) before we merge and deploy the latest changes just to be sure that we always have a working API and working demo.


Construct and pass in elementMap as per updated spec.

As per https://wicg.github.io/animation-worklet/ we now require a slot and pass in the elements as an element map from slot to arrays of elements.

BTW, can we switch to gh-pages so these examples are self hosted?


Fix (v-c-tooltip, v-c-popover): tooltip / popover not hided on unmount of component

In https://github.com/coreui/coreui-vue/blob/18d8ec4bfdf407ec22089dc9a08c7a46c1c6c111/packages/coreui-vue/src/directives/v-c-tooltip.ts#L95 the binding is passed in as first argument, but according to vue's documentation the first argument is the el: HtmlElement, and the second argument is the binding.
Setting a breakpoint this can be seen:

Especially when going up on frame in the stack-trace:

https://github.com/coreui/coreui-vue/pull/183 also did this, but for tooltip only and it got closed without being merged. So the bug is still there (version 4.2.0, but all branches I check also).

Please don't close.


Add "Releases" section to litmus documentation to hold info about releases

Provided reasonably detailed notes on changes made during a release. Expected to replace https://github.com/litmuschaos/litmus/blob/master/RELEASES.md

There is a link instead to the release notes from the docs GH pages site !


Uncaught TypeError: Cannot read property 'functors' of undefined

[Enter steps to reproduce below:]

debugging hapi.js on next to register hapi-redis plugin.

Atom Version: 1.1.0
System: Mac OS X 10.11.1
Thrown From: node-debugger package, v1.1.9
Stack Trace
Uncaught TypeError: Cannot read property 'functors' of undefined
At /Users/jorgecuesta/.atom/packages/node-debugger/node_modules/mercury/node_modules/main-loop/node_modules/raf/index.js:74

TypeError: Cannot read property 'functors' of undefined
  at TreeView.render (/Users/jorgecuesta/.atom/packages/node-debugger/lib/Components/TreeView.coffee:61:15)
  at Array.map (native)
  at Object.TreeView.defaultRender [as render] (/Users/jorgecuesta/.atom/packages/node-debugger/lib/Components/TreeView.coffee:70:51)
  at Function.TreeView.render (/Users/jorgecuesta/.atom/packages/node-debugger/lib/Components/TreeView.coffee:61:25)
  at Function.LocalsPane.render (/Users/jorgecuesta/.atom/packages/node-debugger/lib/Components/CallStackPane.coffee:152:14)
  at RightSidePane (/Users/jorgecuesta/.atom/packages/node-debugger/lib/Components/App.coffee:72:20)
  at App.render (/Users/jorgecuesta/.atom/packages/node-debugger/lib/Components/App.coffee:146:9)
  at redraw (/Users/jorgecuesta/.atom/packages/node-debugger/node_modules/mercury/node_modules/main-loop/index.js:65:23)
  at /Users/jorgecuesta/.atom/packages/node-debugger/node_modules/mercury/node_modules/main-loop/node_modules/raf/index.js:72:10

Commands
     -3:22.1.0 core:paste (atom-text-editor.editor.is-focused)
  5x -3:03.3.0 core:move-right (atom-text-editor.editor.is-focused.autocomplete-active)
  2x -3:01.6.0 core:backspace (atom-text-editor.editor.is-focused)
     -3:00.8.0 core:save (atom-text-editor.editor.is-focused)
     -2:52.6.0 node-debugger:stop (div.panel-body.padded.native-key-bindings)
     -2:51.2.0 node-debugger:start-resume (atom-text-editor.editor.is-focused)
     -2:33.4.0 editor:newline (atom-text-editor.editor.is-focused)
     -2:24.8.0 core:save (atom-text-editor.editor.is-focused.autocomplete-active)
     -2:24.2.0 editor:move-to-end-of-screen-line (atom-text-editor.editor.is-focused)
     -2:23.3.0 core:save (atom-text-editor.editor.is-focused)
     -2:20.2.0 node-debugger:stop (div.panel-body.padded.native-key-bindings)
     -2:19.1.0 node-debugger:start-resume (atom-text-editor.editor.is-focused)
  3x -1:49.9.0 core:backspace (atom-text-editor.editor.is-focused)
     -1:48.2.0 core:save (atom-text-editor.editor.is-focused)
     -1:43.4.0 node-debugger:stop (div.panel-body.padded.native-key-bindings)
     -1:42.5.0 node-debugger:start-resume (atom-text-editor.editor.is-focused)

Config
{
  "core": {
    "themes": [
      "atom-material-ui",
      "atom-material-syntax"
    ]
  },
  "node-debugger": {
    "nodePath": "/usr/local/bin/node"
  }
}

Installed Packages
# User
aligner-scss, v1.1.0
atom-material-syntax, v0.2.4
atom-material-ui, v0.6.3
autocomplete-python, v0.9.4
color-picker, v2.0.13
csslint, v1.1.4
git-projects, v1.15.0
jsformat, v0.9.0
jslint, v1.4.0
linter, v1.10.0
node-debugger, v1.1.9
node-on-fire, v0.1.0
node-resolver, v1.0.1
nodejs-snippets, v1.0.3
react, v0.12.10
webbox-color, v0.5.9

# Dev
No dev packages

@jorgecuesta
I looked at hapi.js (https://github.com/hapijs/hapi) and the hapi redis plugin (https://github.com/sandfox/node-hapi-redis) but I am not sure how to reproduce the problem.
I can see from the callstack that for some reason the stackframe fails to load in the locals view. I could fix the symptoms by adding a null check but I do not understand the circumstances when this happens.

Kiddkai it happen when try to stop on debugger statement placed inside of  function pass as callback to server.register invoked to add a plugin. hapi-redis to be more precise.
-----Mensaje original-----
De: "Daniel Brännström"<EMAIL_ADDRESS>Enviado el: 31/10/2015 04:04 p.m.
Para: "kiddkai/atom-node-debugger"<EMAIL_ADDRESS>CC: "Jorge S. Cuesta"<EMAIL_ADDRESS>Asunto: Re: [atom-node-debugger] Uncaught TypeError: Cannot read property'functors' of undefined (#94)
@jorgecuesta
I looked at hapi.js (https://github.com/hapijs/hapi) and the hapi redis plugin (https://github.com/sandfox/node-hapi-redis) but I am not sure how to reproduce the problem.
I can see from the callstack that for some reason the stackframe fails to load in the locals view. I could fix the symptoms by adding a null check but I do not understand the circumstances when this happens.
—
Reply to this email directly or view it on GitHub.

Fixed in the latest version hopefully. Please report again if it does not help.


Avoid unique temp table names

In some cases, it's beneficial not to create unique table names in TempDb (i.e use #MyTableTemp instead of '#MyTableTempad1e4btb'). When you use bulk operations in a repetitive way on same data structures then you are doing 'same' queries/operations but you are forcing DB engine to create new execution plans over and over again because the name of the temp table changes with every query/operation.

I have merged your pullRequest and made some changes, UniqueTableNameTempDb is now directly in BulkConfig.
Another class for one property was redundant.

Thank you. When can I expect these changes to be released?

Its already released

Already released..


Add --all flag to podman kill

Signed-off-by: Daniel J Walsh<EMAIL_ADDRESS>

I think kill --all should mean "kill all processes in the container" instead, unless we have another good name for that flag?

I think kill --all should mean "kill all processes in the container" instead, unless we have another good name for that flag?

isnt that called stop?  --all does have the precedent of being used elsewheres soley for "all containers"

Stop doesn't hit anything except container init, same as kill. All
processes will hit other processes including exec sessions.
On Sep 29, 2018 12:03, "Brent Baude"<EMAIL_ADDRESS>wrote:
I think kill --all should mean "kill all processes in the container"
instead, unless we have another good name for that flag?
isnt that called stop? --all does have the precedent of being used
elsewheres soley for "all containers"
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/containers/libpod/pull/1568#issuecomment-425655839,
or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHYHCBldo2if6RGtacHqpsx7OO1WRHKCks5uf5ncgaJpZM4XAjfp
.

I dissagree.    That is what I was trying to do when I  noticed it was not working.  I was giving demos of podman with an updated version of @umohnani8 talk, and I wanted to kill all of the containers that were running without waiting for the stop signal to happen.

bot, retest this please

Just two minor things:

I think that "Kill all running containers" is more comprehensible for users than "Signal all running containers". Technically, a kill signal is being sent but I am not sure tha all users are familiar with signal handling and might be confused.

I would like to add a test for this flag to avoid potential future regressions.

I still want an all processes flag, but you're right that it would be confusing to repurpose --all when it means other things elsewhere. Would like to see a test like @vrothberg said though.

LGTM

/lgtm

/approve


How can I get the data and send it to the server?

Where is the sound output, not the generated text coming from Google, I want to send it to the remote server and allow other users to play it.

You should start your own record, stop on call back and send file to server

You should start your own record, stop on call back and send file to server

That does not work actually, because afaik only one resource can access the microphone at the same time.


Normalization Should Not Expand Macros

When using the /api/v1/expr/normalize endpoint, macros will be expanded, which can double the length of the original expression. This also makes it harder to track normalization changes to expressions.
When using the normalize endpoint, the macros should be kept, so that the minimum amount of change is introduced to the expression.

Normalization will not expand most operator macros. The one that was causing problems here is :des-epic-signal which is quite involved and would be difficult to support cleanly without expansion. Also that macro only exists for backwards compatibility with some legacy epic use-cases that have long since been deprecated. After discussing with @copperlight it was decided it isn't work the effort.


Local Setup - Release BRanch issue

Logs:
6:49PM INF local.go:379 > sleeping after git commit with Minio backend update for Terraform
6:49PM INF local.go:417 > sending mgmt cluster install completed metric
6:49PM ERR local.go:390 > error="POST https://api.github.com/repos/<Suppressed>/gitops/pulls: 422 Validation Failed [{Resource:PullRequest Field:base Code:invalid Message:}]"
6:49PM INF local.go:392 > waiting "atlantis plan" to start...
6:49PM INF local.go:426 > Kubefirst installation finished successfully
6:49PM INF helpers.go:596 > Kubefirst installation finished successfully
LOG: 2022/12/02 18:49:36.789657 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...
LOG: 2022/12/02 18:49:46.981850 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...
LOG: 2022/12/02 18:49:57.179877 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...
LOG: 2022/12/02 18:50:07.367065 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...
LOG: 2022/12/02 18:50:17.615046 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...
LOG: 2022/12/02 18:50:27.810714 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...
LOG: 2022/12/02 18:50:38.009640 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...
LOG: 2022/12/02 18:50:48.222358 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...
LOG: 2022/12/02 18:50:58.438700 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...
LOG: 2022/12/02 18:51:08.634836 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...
LOG: 2022/12/02 18:51:18.829636 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...
LOG: 2022/12/02 18:51:29.017500 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...
LOG: 2022/12/02 18:51:39.207170 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...
LOG: 2022/12/02 18:51:49.403406 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...
LOG: 2022/12/02 18:51:59.590015 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...
LOG: 2022/12/02 18:52:09.772686 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...
LOG: 2022/12/02 18:52:19.958921 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...
LOG: 2022/12/02 18:52:30.173418 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...
LOG: 2022/12/02 18:52:40.363256 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...
LOG: 2022/12/02 18:52:50.549951 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...
LOG: 2022/12/02 18:53:00.764934 /app/internal/githubWrapper/github.go:238: waiting "atlantis plan" finish to proceed...

Output:
- Deploying metaphor applications
Send Telemetry                ... 50.0% [##############..............] [1 in 4m36.933197s]
Send Telemetry                ... done! [2 in 4m41.893s]
- Kubefirst installation finished successfully

It seems to be stuck waiting, atlantis to do its thing.

With #822 we have main always, that should address atlantis issues.


Error in parsing SUB r/m64, imm32

For example: There is instruction in IDA "sub  rsp, 0F8h" with opcode "48 81 EC F8 00 00 00", but after export to Binnavi it converts to "sub qword rsp, 0h"
example of idb file, source and binary attached:
sub_bug.zip
This instruction is in function "test" with address 004004FA

Confirmed, see attached text dump file sub_bug.txt, line 195:
004004FA sub rsp, b4 0

Fixed in 626e803. The code in ida/metapc.cc's HandleImmediate() relied on undefined behavior when undoing IDA's sign extension.


[PF-1341] When setting metadata to the notebook, still append the default metadata unless specified to be override

the default metadata are workspace id and server id. Unless specifically override by user input, we should still append those when some arbitray metadata is appended.

@deflaux FYI
Currently when metadata field is specified during notebook creation, we override the default metadata fields that include workspace id and terra server id. I changed it to append to the default metadata field and override when the user specified.


[Program]: Write a Swift program to print numbers from 1 to n

Description
Write a Swift program to print numbers from 1 to n
Input  : 5
Output : 1 2 3 4 5

How to contribute

Save the solution in program/program/print-numbers-from-1-to-n/PrintNumbersFrom1ToN.swift file

Hi @harshraj8843 I would like to work on this.


Conformance tests failing with Apache Pulsar 2.9.x

As demonstrated by https://github.com/dapr/components-contrib/pull/1576, conformance tests for Apache Pulsar are failing when using >=2.9. For now, we pinned the version of Pulsar to 2.8.2.
Will need to investigate the reason why

I honestly do not know. I just helped @berndverst debugging this and we identified the cause to be 2.9.
More debugging is needed to figure out the root cause.


Contributions improvement

Added .gitignore
Added readme.md
Added contribution.md

@jsparmani add the entry point command in COTRIBUTIONS.md

@jsparmani add the entry point command in COTRIBUTIONS.md

@shubhank-saxena okay!


[URLFollow] add start time and duration to Twitch when live

Maybe Followers and Views, too, or only when offline.

This issue was moved to DesertBot/DesertBot#4


Setup Nightly builds

First i need to finish #42

1 man project and i duplicate my own issues. Jeeez


MULTIARCH-3668: Update make file to use latest golang

Updated golang version used for running tests
Updated podman command to remove :Z as its not supported

/label jira/valid-bug


Enable autoFocus option to accept an element to focus on pane creation

Identify the Bug
fixes #18511

Description of the Change
Use panel.autoFocus as the element for focusTrap.initialFocus if it is not a boolean value.

Possible Drawbacks
None. It is backwards compaitible.

Verification Process
added a test

Release Notes
The autoFocus option for panels can now be an element that will receive initial focus.

@UziTech: Thanks for contributing!
Since @daviwil already gave the 👍 , I've just resolved the conflicts and I'll merge this once the CI tests pass 🎉


@angular-devkit/build-angular depends on vulnerable version of vite

Command
other
Is this a regression?

[ ] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
No response
Description
Running npm audit on an Angular 16 project with version 16.2.11 of @angular-devkit/build-angular reports a security vulnerability with vite.
vite  4.0.0 - 4.5.1
Severity: high
Vite dev server option server.fs.deny can be bypassed when hosted on case-insensitive filesystem - https://github.com/advisories/GHSA-c24v-8rfc-w8vw
fix available via npm audit fix --force
Will install<EMAIL_ADDRESS>which is a breaking change
node_modules/@angular-devkit/build-angular/node_modules/vite
@angular-devkit/build-angular  16.0.0-next.0 - 17.0.10
Depends on vulnerable versions of vite
node_modules/@angular-devkit/build-angular
An update is needed to use the patched version of vite - 4.5.2. The recent revision of @angular-devkit-build-angular (https://github.com/angular/angular-cli/commit/e0e011fc47f2383f9be0b432066c1438ddab7103) only moved this up to 4.5.1 which is still affected (see link below).
https://github.com/advisories/GHSA-c24v-8rfc-w8vw
Minimal Reproduction

Create an angular v16 project with version 16.2.11 of @angular-devkit/build-angular.
Run npm audit.

Exception or Error
No response
Your Environment
Angular CLI: 16.2.11
Node: 18.18.2
Package Manager: npm 9.8.1
OS: win32 x64

Angular: 16.2.12
... animations, common, compiler, compiler-cli, core, forms
... language-service, localize, platform-browser
... platform-browser-dynamic, platform-server, router
... service-worker

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.1602.11
@angular-devkit/build-angular      16.2.11
@angular-devkit/core               16.2.11
@angular-devkit/schematics         16.2.11
@angular/cdk                       16.2.13
@angular/cli                       16.2.11
@angular/flex-layout               15.0.0-beta.42
@angular/material                  16.2.13
@angular/material-moment-adapter   16.2.13
@schematics/angular                16.2.11
rxjs                               7.8.1
typescript                         4.9.5
zone.js                            0.13.3

Anything else relevant?
No response

Closed via https://github.com/angular/angular-cli/pull/26919

@alan-agius4 many thanks for the speedy response. Do you have an idea when the fix will be released?


Use bootstrap-sass & ember-cli-sass instead of bootstrap

In situations where you prefer to use another strategy for importing Bootstrap CSS... I

I am not sure I understand what you are suggesting?
You can prevent importing the bootstrap CSS (see http://kaliber5.github.io/ember-bootstrap/getting-started/#opting-out-of-bootstrap-css) and follow whatever other strategy you want...


Reduce in-memory footprint to 96bit

Internally the type is defined as pair uint64. Making hi as uint32 reduces the size.

It does not improve memory consumption due to struct padding. Existing structure is optimal.


Add TextColor property to BaseButton and make MathInputButton's color customizable

The main goal of this commit is to make keyboard colors customizable (per keyboard key) to fit an app's color theme(s). For example, a dark keyboard background with light button texts.
CSharpMath.Forms:

Refactor BaseButton's constructor.
Add TextColor property to BaseButton and a bindable TextColorProperty.
Remove the predefined Red color from MathInputButton.InputToLaTeX(input) for "Backspace" and "Clear".

CSharpMath.Forms.Example (MathKeyboard.xaml):

Use the TextColorProperty in the Style of "Backspace" and "Clear", setting it to Red.

Codecov Report

Merging #164 into master will decrease coverage by 0.13%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
- Coverage   86.71%   86.57%   -0.14%
==========================================
  Files         157      157
  Lines       11200    11218      +18
==========================================
  Hits         9712     9712
- Misses       1488     1506      +18

Impacted Files
Coverage Δ

CSharpMath.Forms/Buttons.cs
0.00% <0.00%> (ø)

CSharpMath.Forms/MathInputButton.cs
0.00% <0.00%> (ø)

CSharpMath/Display/Displays/RadicalDisplay.cs
90.56% <0.00%> (-3.78%)
:arrow_down:

CSharpMath/Atom/MathList.cs
88.50% <0.00%> (+2.29%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b209b...cd3c5c7. Read the comment docs.

Not a fan of use-once functions. @FoggyFinder?

Also would be nice if some new tests related to this change are added to CSharpMath.Xaml.Tests.

Not a fan of use-once functions. @FoggyFinder?

Yep, as well

OK, I will restore that and make some unit tests.
Op wo 16 sep. 2020 09:15 schreef FoggyFinder<EMAIL_ADDRESS>
Not a fan of use-once functions. @FoggyFinder
https://github.com/FoggyFinder?
Yep, as well
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/verybadcat/CSharpMath/pull/164#issuecomment-693221353,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHVGU6X5NYQCY6PN6RKGSM3SGBQZ7ANCNFSM4RN5WWJA
.

Oops, I didn't read "CSharpMath.Xaml.Tests".
While trying to find out where to write the unit tests, I was in doubt about the "Xaml" meaning. I thought that test project was meant for tests more related to the xml. I have created a test project "CSharpMath.Forms.Tests" in the "Xamarin.Forms" folder. Shall I move the tests and delete the newly created test project?

I really appreciate the feedback you are providing. This is the first pull request I've ever done, and I am surprised about the quick responses and thorough reviews, providing kind and helpful suggestions to make the code compact and clean. You also care about the code quality even more than I'd expected - commenting about a white line for example and using => bla; instead of => { bla;} - and I like that.

Maybe I should only have committed "Add MathInputButton_Command unit test and do the suggested cleaning 99417ce".
I thought "let's use the Keyboard getter to increase test coverage", but the intention of the test is more clear without it. I will revert the last two commits.

Try having tests that invoke https://docs.microsoft.com/en-us/dotnet/api/xamarin.forms.streamimagesource.stream?view=xamarin-forms#Xamarin_Forms_StreamImageSource_Stream of the Source property.

Hmm. The new tests fail in the github checks (not locally)...:

The type initializer for 'SkiaSharp.SKImageInfo' threw an exception.

CSharpMath.Rendering.Tests test the SkiaSharp front end yet all images are drawn successfully. Weird.

Version mismatch? SkiaSharp is at 2.80.1 while SkiaSharp.Views.Forms is at 1.68.0.

When I update the package, another error shows up, which is also mentioned in https://github.com/mono/SkiaSharp/issues/1225.
A comment in that issue:

It might be because the SkiaSharp.Views.Forms project does not actually have a netstandard implementation that can run in tests.

I've found a solution for using 2.80.2. I've downloaded the NuGetPackage, extracted it (zip file) and added the dll to the test project:
skiasharp.views.forms.2.80.2.nupkg\ref\netstandard2.0\SkiaSharp.Views.Forms.dll
I'll do some more checks and then I'll push.

Just clarifying: I've had two versions of the repository (with SkiaSharp.Views.Forms 1.68.0 and 2.80.2) that run the tests of CSharpMath.Forms.Tests successfully locally but fail in the GitHub checks.
I now continue my quest :)

OK, that didn't help.
Github Test  Error Message:
System.AggregateException : One or more errors occurred. (The type initializer for 'SkiaSharp.SKImageInfo' threw an exception.)
---- System.TypeInitializationException : The type initializer for 'SkiaSharp.SKImageInfo' threw an exception.
-------- System.DllNotFoundException : Unable to load shared library 'libSkiaSharp' or one of its dependencies. In order to help diagnose loading problems, consider setting the LD_DEBUG environment variable: liblibSkiaSharp: cannot open shared object file: No such file or directory

Solving this NuGet/dll problem seems out of reach for me. I will revert my latest attempts. Options:

We could remove or comment out the unit tests added in "Add MathButton unit tests that check that the image color is correcty set in the StreamImageSource (4223835)" and wait for the mono/SkiaSharp update to solve the bug (assuming that is the case).
I don't know on what device Github Tests run? I found a posting about configuring the machine on which the tests are run (I can't help any further with that...)
https://github.com/mono/SkiaSharp/issues/834#issuecomment-631479750
Someone may be able to solve it another way...

I don't know on what device Github Tests run?

The workflow runs on Linux (Ubuntu).

I'll follow up tomorrow, I think https://github.com/mono/SkiaSharp/releases/tag/v2.80.0#additional should be the solution.

I'm busy these few days, will come back to this a few more days later.

I will push another commit that will allow/stimulate customizing the keyboard keys even more.
from

to (for example)

One of the squares is filled because it indicates where the cursor will be after pressing the button.

The main reason for not liking an empty square is that when I make the keyboard smaller vertically, the displayed borders of some empty sqaures are not of equal size. That may because of my computer screen, but still a reason to like to override the default:

Shall I remove the changes of the square in the Example project?
Or: make the empty square gray and leave the black square, via something like (using lumosity in case of TextColor changes):
  public class MyMathInputButton : MathInputButton {
    protected override string GetButtonDisplayLaTeX(MathKeyboardInput key) =>
      base.GetButtonDisplayLaTeX(key).Replace(@"\square", LatexHelper.SetColor("■", TextColor.WithLuminosity(0.7)));
    }
  }

If the button display is changed, the keyboard output should be changed too. @charlesroddie @FoggyFinder Is this change acceptable?

I would say that if the button display is customizable, the keyboard output need not change.
The keyboard output could become customizable too (that would be great actually), but I think those two need not be always the same.

Imagine that someone would like to display \times on a button, but \cdot as output.
Imagine that someone wants to make a calculator with x^y as the button-LaTeX...

If the button display is changed, the keyboard output should be changed too. @charlesroddie @FoggyFinder Is this change acceptable?

I think it would be better to move these changes into separate PR (or create an issue to discuss first).
But I personally don't like how new buttons look.

Personally I am okay with the fire button but don't like the idea of what you see not being what you get.

Just to clarify:
The point of discussion is whether MathInputButton.GetButtonDisplayLaTeX should be virtual or not.
In a discussion about that, the following comments...

"But I personally don't like how new buttons look."
"don't like the idea of what you see not being what you get."
...seem irrelevant because everyone can get what they want. The defaults stay the same.

A concern that is more important in my opinion:
Does this change have any negative technical implications for the development of this repository? For example: does it impose restrictions for classes beyond the MathInputButton class? (Does it violate the open–closed principle or does it make future changes harder because GetButtonDisplayLaTeX is not private anymore?)
I must say however, that this comment
"If the button display is changed, the keyboard output should be changed too."
is another example of feedback that I really appreciate. I'm just someone opening a pull request, and a proposal is taken [more serious than expected] / [beyond the intended scope].

For making the placeholder customizable in the output, I have created pull request https://github.com/verybadcat/CSharpMath/pull/167.

My proposal/plan for this PR after #167 has been merged/accepted:

I'll sync/update this branch.
I'll restore the placeholder appearances on the keyboard keys to what they were before.
I'll add a button at the right of the Textbox "Enter keystrokes..." that says something like "Change appearance". Maybe only a single word is better, to keep more space for the textbox.
The effect of clicking this new button that has the following effect the first time: the placeholder appearance changes on the keyboard buttons and in the output as well. (For example, using a LightGray full square instead of the currently used empty square with black border.)
Clicking multiple times changes the appearance of keyboard keys again, for instance also changing the TextColor of all keys to brown, or changing the Clear button to a rubbish bin, and eventually (after a maximum of 5 clicks) the original appearance is visible again. This way, the defaults stay the same, but all added functionality is also available in the Example project.

I wanted to sync my fork in such a way that this pull request would not show the commit from #167, but alas. I chose "rebase", maybe "merge" would have done the trick. However, I also commited ddb5e4e and that is part of this pull request.

I'll try to solve Linux failures when I can allocate time...

I understand. Sometimes it's juggling priorities. I will stay tuned.

I would like to move on to other PRs but I also intend to avoid merge conflicts, so I'll wait with opening new PRs until this PR has been merged.
Proposal (I'll just do it and it can always be reverted):

I remove the following two tests that have the Linux failures (DefaultButtonImageTextColorIsBlack, ButtonTextColorPropertyChangesImageColor).
I will open a PR that re-adds the tests after this PR has been merged.

[Fact(Skip="reason")] ?

Codecov Report

Merging #164 into master will increase coverage by 0.60%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   87.32%   87.92%   +0.60%
==========================================
  Files         156      159       +3
  Lines       11314    11512     +198
==========================================
+ Hits         9880    10122     +242
+ Misses       1434     1390      -44

Impacted Files
Coverage Δ

CSharpMath.Forms/Buttons.cs
62.50% <57.14%> (+62.50%)
:arrow_up:

CSharpMath.Forms/MathInputButton.cs
96.42% <98.03%> (+96.42%)
:arrow_up:

CSharpMath.Forms.Tests/ButtonTests.cs
100.00% <100.00%> (ø)

CSharpMath.Forms/LatexHelper.cs
100.00% <100.00%> (ø)

CSharpMath.Forms/StringHelper.cs
100.00% <100.00%> (ø)

CSharpMath.Rendering/BackEnd/GlyphFinder.cs
100.00% <0.00%> (+4.76%)
:arrow_up:

CSharpMath/Atom/Boundary.cs
90.00% <0.00%> (+10.00%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 476beb0...7ee69ff. Read the comment docs.

TextColor on buttons isn't reverted to Black after theme changed back to the first one.

This has never happened while I tested, but there is definitely something strange going on: if I deploy/run the UWP project several times and each time do the "Change appearance" test through all themes, for some deploys 1 or 2 buttons do not revert to Black when coming back to the first theme, and in other cases it just works. Testing now, I had the "+" button that stayed brown, in another deploy I had the "5" and "\leq" buttons that stayed brown...
Something to admit: I have not tested this for Android, because that has a compilation error:

Can not resolve reference: Validation, referenced by Xunit.SkippableFact. Please add a NuGet package or assembly reference for Validation, or remove the reference to Xunit.SkippableFact.	CSharpMath.Forms.Example.Android

I don't know why "xunit"-related stuff (I thought they are for unit test only) can be found in Android's obj/project.assets.json and at the NuGet packages while they are not referenced in Android's csproj:

My latest commit does not fix the issue FoggyFinder described.
Still investigating (at some moments I have time).

Ow, the unit tests think differently about removing the NullableColorBindablePropertyHelper. I will revert.

Xamarin.Forms.Xaml.XamlParseException : Position 1:97. Cannot assign property "PlaceholderActiveColor": Property does not exist, or is not assignable, or mismatching type between value and property

@FoggyFinder I can't reproduce the bug anymore (of MathInputButtons not changing back to black when coming back to the first theme). I have tested this now, about 10 times, and 15 hours ago, about 20 times. Does it still occur for you?
If it does, the only thing I can think of to change, is listening to the following warning:

by defining interface IButtonDraw { void ButtonDraw(); } and using it on BaseButton's TextColor property:
    public Color TextColor { get => (Color)GetValue(TextColorProperty); set => SetValue(TextColorProperty, value); }
    public static readonly BindableProperty TextColorProperty = BindableProperty.Create(nameof(TextColor), typeof(Color), typeof(BaseButton<TView, TPainter, TContent>), Color.Black,
      propertyChanged: (b, o, n) => ((IButtonDraw)b).ButtonDraw());

(Casting b to BaseButton<TView, TPainter, TContent> would not work, because MathInputButton's override of the ButtonDraw method would not be executed.)

Does it still occur for you?

Yep, still the same

Core Tests results:

Total tests: 937
Passed: 933
Skipped: 4

The test fail errors are not related to this PR.
Test Core fail reason:

Error: Codecov failed with the following error: The process '/bin/bash' failed with exit code 2

Test iOS fail reason:

2020-11-01 08:20:56.474 CSharpMath.Ios.Tests[2654:25586] 	[FAIL] CSharpMath.Ios.Tests.Tests.MathDisplay(file: "ItalicAlignment", latex: "\colorbox{yellow}P\\\begin{array}{r}\colorbox"...) : Assert.InRange() Failure\r\nRange:  (-1655.8 - 6525.8)\r\nActual: 6688
2020-11-01 08:20:56.474 CSharpMath.Ios.Tests[2654:25586] 		  at CSharpMath.Ios.Tests.Tests.Test (System.String directory, System.Action`1[T] init, System.String file, System.String latex) [0x0020a] in /Users/runner/work/CSharpMath/CSharpMath/CSharpMath.Ios.Tests/Tests.cs:54

2020-11-01 08:20:55.897 CSharpMath.Ios.Tests[2654:25586] 	[FAIL] CSharpMath.Ios.Tests.Tests.MathInline(file: "ItalicAlignment", latex: "\colorbox{yellow}P\\\begin{array}{r}\colorbox"...) : Assert.InRange() Failure\r\nRange:  (-1655.8 - 6525.8)\r\nActual: 6688
2020-11-01 08:20:55.897 CSharpMath.Ios.Tests[2654:25586] 		  at CSharpMath.Ios.Tests.Tests.Test (System.String directory, System.Action`1[T] init, System.String file, System.String latex) [0x0020a] in /Users/runner/work/CSharpMath/CSharpMath/CSharpMath.Ios.Tests/Tests.cs:54

@FoggyFinder I suspect that it is solved now via commit 486ac0f and I hope that calling ButtonDraw during each theme change in the example project is acceptable. Officially it is only needed to go from theme 1 to theme 2.

@FoggyFinder @SymboLinker I'll test this PR tomorrow

@FoggyFinder @SymboLinker I'll test this PR tomorrow

@Happypig375 It's more than half a year later now. Could you please share why this PR has not been tested / has not gotten any response? I would like to know that, so that I can do better next time (in other public repositories).

It's just me focusing on other projects than this. I'll just merge this.

@FoggyFinder Just missing your approval

It's more than half a year later now. Could you please share why this PR has not been tested / has not gotten any response? I would like to know that, so that I can do better next time (in other public repositories).

I'm doing some testing. I totally newbie with Regex so getting help with those who know at least something (pretty much to my opinion). Expect feedback / commit with fix proposal or. at least. tests that are failing within 1-2 days.

@FoggyFinder

Why do you need RegEx? Is it because of the use of Regex.Matches(latex, LaTeXSettings.PlaceholderActiveNucleus).Count > 1 in the MathInputButton? That is acutally a bug, I realize now! (The intention of that piece of code was to count the number of placeholders. I actually should not have used the Regex class there, because my intention was only to count the number of occurrences of a normal string. That's dangerous however, because LaTeX uses characters that may result in actual meaningful regular expressions. It was lazy to use that method instead of writing a simple "substring counting method" - I believe there are no such methods ready available.)
Whenever I "think" I need to use regular expressions, I remind myself of a joke about Regex: "Some people, when confronted with a problem, think "I know, I'll use regular expressions." Now they have two problems." (I try to avoid using Regex. Often, there are better/cleaner ways to solve problems without Regex.)
If I do use it, I mostly Google a "C# Regex cheat sheet" (for example: mikesdotnetting). There are multiple versions of Regex. Some languages outside of .NET may have a slightly different syntax.
Regex.Replace and Regex.Matches are examples of .NET methods that you can use to transform those Regex strings into doing something.

Exactly. I thought "Aha. Now I realize why it behaves like this. And then - I can write simple Regex to fix it quickly. Well it ended with debug why a regex doesn't work properly in some case and then another regex and so on until the point when I totally no idea what the regex pattern means itself".
Indeed I prefer not to use Regex and not only I'm very bad with them. But...you've been waiting for so long...my intention was to fix it ASAP,  merge in and then, probably, rewrite without Regex.

The issue with display (like I saw brown color despite the theme is black) is the fact that DrawButton calls repeatedly in short period of time:
        button.TextColor = color;
        button.PlaceholderRestingColor = placeholderRestingColor;
        button.PlaceholderActiveColor = placeholderActiveColor;
        button.ButtonDraw(/* If the LaTeXSettings change but the button's appearance properties don't, there's no event that causes the execution of this method. */);

So when we store "original" latex in a variable
    var originalLatexString = painter.LaTeX;

it might be previously mutated LaTeX that actually contains color etc attributes.

I'm not a big fan of lock either but it was much easier than applying odd regex to prevent latex corruption.
Well, returning to black theme still shows light-red border in frac, ... but no visual glitch

Nice, using a lock in synchronous code is new for me. Thanks!

Codecov Report

Merging #164 (edfed19) into master (892eaec) will increase coverage by 0.33%.
The diff coverage is 83.20%.

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   87.34%   87.67%   +0.33%
==========================================
  Files         156      161       +5
  Lines       11329    11568     +239
==========================================
+ Hits         9895    10142     +247
+ Misses       1434     1426       -8

Impacted Files
Coverage Δ

CSharpMath.Forms.Tests/ButtonTestsHelper.cs
0.00% <0.00%> (ø)

CSharpMath.Forms/Buttons.cs
61.11% <53.57%> (+61.11%)
:arrow_up:

CSharpMath.Forms.Tests/ButtonTests.cs
88.37% <88.37%> (ø)

CSharpMath.Forms/MathInputButton.cs
96.07% <97.82%> (+96.07%)
:arrow_up:

CSharpMath.Forms/LatexHelper.cs
100.00% <100.00%> (ø)

...pMath.Forms/NullableColorBindablePropertyHelper.cs
100.00% <100.00%> (ø)

CSharpMath.Forms/StringHelper.cs
100.00% <100.00%> (ø)

CSharpMath.Rendering/Text/TextLaTeXParser.cs
87.76% <0.00%> (-0.51%)
:arrow_down:

CSharpMath.Editor/MathKeyboard.cs
88.81% <0.00%> (-0.22%)
:arrow_down:

... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 892eaec...edfed19. Read the comment docs.

Thanks @Happypig375 and @FoggyFinder!


Evaluation script

Script to gather execution results for:

oneliners
unix50
analytics-mts
poets
max-temp
web-index
dependency_untangling

using several configurations

After we fix https://github.com/binpash/pash/issues/443, we could merge the PR

That is great! If I understand correctly it runs all benchmarks with all configurations once. However, if I recall correctly, in our evaluation we run all configurations of all benchmarks 3 times. Is it possible to extend this script to do that?

That is great! If I understand correctly it runs all benchmarks with all configurations once. However, if I recall correctly, in our evaluation we run all configurations of all benchmarks 3 times. Is it possible to extend this script to do that?

I will work on that!
TODO: find a way to merge the results in order to produce the final plots. Should I add the scripts for the plot generation here?

Great :) @mgree do you think we could automate using the R scripts or should we just have a more ad-hoc infrastructure (e.g., Python pyplot) for CI and artifact (and only use the R scripts for the final plots once).

I'd say we might as well use the R plots, just so it's always the right thing. There's an example of how to do it in CI for ffs. Let me know if I can help!

@dkarnikis Please add README.md on how to run the full artifact and get the results (see link from previous artifacts).
@tammam1998 Please run this infrastructure to confirm we can get the results from the paper.
@angelhof We need to decide how to call the "legacy" configuration, and how to run/incorporate the POSIX or Smoosh evaluation.

@angelhof We need to decide how to call the "legacy" configuration, and how to run/incorporate the POSIX or Smoosh evaluation.

Regarding the legacy configurations in the artifact, I think we should use the names in the paper and define them in a README here.
Regarding the POSIX evaluation, I think it is totally fine to not give access to it, or, at most, give them an ssh key to run the tests on our machine and check the git commit hash to ensure that it is correct.

But the name we're using is only for blinding purposes—we will eventually use a different name at the end, so why not use that final name in these scripts?:-)

But the name we're using is only for blinding purposes—we will eventually use a different name at the end, so why not use that final name in these scripts?:-) ( ...so I'm asking for your opinion on what that name should be:-) )

@dkarnikis let's call the legacy setup pash-aot (with proper capitalization, depending on where it's used.) Thanks, then we can merge, and @tammam1998  can test asynchronously.

I think @tammam1998 has tested and we can merge.


Generator not working

report a bug
What is the current behavior? cards are not lining up on the pages correctly

New mantained fork #159

I'm having the same issue; when I generate the preview the cards get laid our correctly for two rows, then a column down the middle goes off the page. I've replicated the issue from the .json file on two computers.

can you be more specific? I can't replicate the bug.


[OSPK8-644] Ignore unassigned hostrefs in VerifyBaremetalStatusHostRefs

If an error occurs during the baremetalset reconile loop the status can contain incomplete hostrefs with just the initial state ("unassigned"). The hostref validation in the next reconcile then fails as it expects a BMH with the literal name "unassigned".
This patch updates VerifyBaremetalStatusHostRefs to skip any hostref that are still in this initial state.

/cherry-pick v1.3.x


Preprocess custom *.las data

Hi, I have the following data

LiDAR files (*.las)
equirectangular images of camera along with heading values
Car location data

How can I preprocess my data into trainable format like KITTI or some other data. I looked everywhere but could not find any help.

I'm not quite familiar with the .las format of LiDAR files, and didn't find the tool which can convert las to bin directly. However, las2pcd and pcd2bin tools can be found in github. Maybe it can be a solution for your case.
About generating label and calib file, you can refer to previous related issues for solution. (https://github.com/open-mmlab/mmdetection3d/issues/429)

Please refer to this tutorial for the way of converting pcd file to bin.

I'd like to preprocess the las data.
Which library is the most appropriate one?


Vector

Call Vetor instead of Vector to avoid mistakes with the C++ vector class.
Basic fields

x-axis, y-axis, z-axis

Basic methods

[ ] operator +
[ ] operator -
[ ] operator *
[ ] operator /
[ ] scalar
[ ] cross
[ ] angle
[ ] normalize
[ ] module
[ ] rotate X
[ ] rotate Y
[ ] rotate Z

Vou tocar essa task


[AIRFLOW-XXXX] Dont wait longer between scheduler polls than necessary

Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
Will update these fields in due time.  @aoen @bolkedebruin
JIRA

[ ] My PR addresses the following Airflow JIRA issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-XXX

Description

[ ] Here are some details about my PR, including screenshots of any UI changes:

Tests

[ ] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

[ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

Subject is separated from body by a blank line
Subject is limited to 50 characters
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"

Codecov Report

Merging #2453 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2453      +/-   ##
==========================================
+ Coverage    69.4%   69.44%   +0.04%
==========================================
  Files         146      146
  Lines       11289    11292       +3
==========================================
+ Hits         7835     7842       +7
+ Misses       3454     3450       -4

Impacted Files
Coverage Δ

airflow/jobs.py
76.78% <100%> (+0.45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 751e936...6c11d3f. Read the comment docs.


Add alert logging + LogNode for easier debugging

Fixes #358

@nathanielc maybe adding some lambda expression to the log can be helpful or threshold for filtering noise.
but how can you debug AlertNode if it dosen't exposes point?

@yosiat If you want to log less add a WhereNode or a SampleNode  in front of the LogNode.

but how can you debug AlertNode if it dosen't exposes point?

Ah yes, it should also log the alert data....


[src & egs] Prepare lightning upgrade to 0.9.0

optimizer_step change
Fix trainer args
Fix verbose is boolean

@popcornell, does this solve #213 by change?

@popcornell, does this solve #213 by chance?

I need to wait for a free GPU to test it

Nope still not solved.
I am getting this rather un-helpful error:
File "train.py", line 140, in <module>
    main(arg_dic)
  File "train.py", line 104, in main
    trainer.fit(system)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py", line 992, in fit
    results = self.spawn_ddp_children(model)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/pytorch_lightning/trainer/distrib_data_parallel.py", line 462, in spawn_ddp_children
    results = self.ddp_train(local_rank, q=None, model=model, is_master=True)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/pytorch_lightning/trainer/distrib_data_parallel.py", line 560, in ddp_train
    results = self.run_pretrain_routine(model)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/pytorch_lightning/trainer/trainer.py", line 1196, in run_pretrain_routine
    False)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/pytorch_lightning/trainer/evaluation_loop.py", line 291, in _evaluate
    output = self.evaluation_forward(model, batch, batch_idx, dataloader_idx, test_mode)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/pytorch_lightning/trainer/evaluation_loop.py", line 444, in evaluation_forward
    output = model(*args)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/torch/nn/modules/module.py", line 722, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/pytorch_lightning/overrides/data_parallel.py", line 96, in forward
    output = self.module.validation_step(*inputs[0], **kwargs[0])
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/asteroid-0.3.0-py3.6.egg/asteroid/engine/system.py", line 136, in validation_step
    loss = self.common_step(batch, batch_nb, train=False)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/asteroid-0.3.0-py3.6.egg/asteroid/engine/system.py", line 91, in common_step
    est_targets = self(inputs)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/torch/nn/modules/module.py", line 722, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/asteroid-0.3.0-py3.6.egg/asteroid/engine/system.py", line 64, in forward
    return self.model(*args, **kwargs)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/torch/nn/modules/module.py", line 722, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/asteroid-0.3.0-py3.6.egg/asteroid/models/base_models.py", line 49, in forward
    est_masks = self.masker(tf_rep)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/torch/nn/modules/module.py", line 722, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/asteroid-0.3.0-py3.6.egg/asteroid/masknn/recurrent.py", line 352, in forward
    output = self.net(output)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/torch/nn/modules/module.py", line 722, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/torch/nn/modules/container.py", line 117, in forward
    input = module(input)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/torch/nn/modules/module.py", line 722, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/asteroid-0.3.0-py3.6.egg/asteroid/masknn/recurrent.py", line 212, in forward
    x = self.intra_RNN(x)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/torch/nn/modules/module.py", line 722, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/asteroid-0.3.0-py3.6.egg/asteroid/masknn/recurrent.py", line 50, in forward
    rnn_output, _ = self.rnn(output)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/torch/nn/modules/module.py", line 722, in _call_impl
    result = self.forward(*input, **kwargs)
  File "/home/scornell/anaconda3/envs/plup/lib/python3.6/site-packages/torch/nn/modules/rnn.py", line 577, in forward
    self.dropout, self.training, self.bidirectional, self.batch_first)
RuntimeError: cuDNN error: CUDNN_STATUS_BAD_PARAM

Interestingly this does not anymore depend on the overriding of optimizer.step(). It may be a totally unrelated issue.

FP16 LSTM is broken in PyTorch 1.6, see https://github.com/pytorch/pytorch/issues/36428
I tried FP16 with PyTorch nightly, which doesn't error, but training did not converge in my experiments with DPRNN and DCUNet (not part of Asteroid)

I ran the tests locally and the ConvTasNet recipe (from stage 3) with the following versions :

[x] 0.8.1
[x] 0.8.3
[x] 0.8.4
[x] 0.8.5
[x] 0.9.0

We're merging this tomorrow unless any of you has something against it @popcornell @jonashaag @faroit @michelolzam ?


Unexpected Error: SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC

Describe the bug
Unexpected Error dialog pops up when syncing with GUI running
To Reproduce
Seems to happen while syncing
Expected behaviour
Sync to completion without errors
System:

Maestral version: 1.5.0
Python version: 3.9.7
OS: Manjaro, kernel 5.14.10-1
Desktop environment: Plasma  5.22.5, Framework 5.86.0, Qt 5.15.2
PyQt version (for Linux GUI): 5.15.4

Additional context
Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/urllib3/response.py", line 441, in _error_catcher
    yield
  File "/usr/lib/python3.9/site-packages/urllib3/response.py", line 522, in read
    data = self._fp.read(amt) if not fp_closed else b""
  File "/usr/lib/python3.9/http/client.py", line 462, in read
    n = self.readinto(b)
  File "/usr/lib/python3.9/http/client.py", line 506, in readinto
    n = self.fp.readinto(b)
  File "/usr/lib/python3.9/socket.py", line 704, in readinto
    return self._sock.recv_into(b)
  File "/usr/lib/python3.9/ssl.py", line 1241, in recv_into
    return self.read(nbytes, buffer)
  File "/usr/lib/python3.9/ssl.py", line 1099, in read
    return self._sslobj.read(len, buffer)
ssl.SSLError: [SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (_ssl.c:2633)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/laydros/.local/lib/python3.9/site-packages/maestral/manager.py", line 791, in _handle_sync_thread_errors
    yield
  File "/home/laydros/.local/lib/python3.9/site-packages/maestral/manager.py", line 769, in startup_worker
    self.sync.download_sync_cycle(client)
  File "/home/laydros/.local/lib/python3.9/site-packages/maestral/sync.py", line 2836, in download_sync_cycle
    downloaded = self.apply_remote_changes(changes)
  File "/home/laydros/.local/lib/python3.9/site-packages/maestral/sync.py", line 3004, in apply_remote_changes
    for n, r in enumerate(res):
  File "/usr/lib/python3.9/concurrent/futures/_base.py", line 608, in result_iterator
    yield fs.pop().result()
  File "/usr/lib/python3.9/concurrent/futures/_base.py", line 438, in result
    return self.__get_result()
  File "/usr/lib/python3.9/concurrent/futures/_base.py", line 390, in __get_result
    raise self._exception
  File "/usr/lib/python3.9/concurrent/futures/thread.py", line 52, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/laydros/.local/lib/python3.9/site-packages/maestral/sync.py", line 3328, in _create_local_entry
    res = self._on_remote_file(event, client)
  File "/home/laydros/.local/lib/python3.9/site-packages/maestral/sync.py", line 3387, in _on_remote_file
    md = client.download(f"rev:{event.rev}", tmp_fname, sync_event=event)
  File "/home/laydros/.local/lib/python3.9/site-packages/maestral/client.py", line 623, in download
    for c in http_resp.iter_content(chunksize):
  File "/usr/lib/python3.9/site-packages/requests/models.py", line 758, in generate
    for chunk in self.raw.stream(chunk_size, decode_content=True):
  File "/usr/lib/python3.9/site-packages/urllib3/response.py", line 579, in stream
    data = self.read(amt=amt, decode_content=decode_content)
  File "/usr/lib/python3.9/site-packages/urllib3/response.py", line 544, in read
    raise IncompleteRead(self._fp_bytes_read, self.length_remaining)
  File "/usr/lib/python3.9/contextlib.py", line 137, in __exit__
    self.gen.throw(typ, value, traceback)
  File "/usr/lib/python3.9/site-packages/urllib3/response.py", line 452, in _error_catcher
    raise SSLError(e)
urllib3.exceptions.SSLError: [SSL: DECRYPTION_FAILED_OR_BAD_RECORD_MAC] decryption failed or bad record mac (_ssl.c:2633)

Thanks for the report! This is a strange one. How reproducible is the error? I.e., does it reoccur after restarting Maestral? And do any other programs report similar issues when downloading larger files (wget, web browser, etc)?

I stopped and restarted Maestral and it happened again after a few minutes. Since it looked like a few more files completed in the meantime, I stopped and started again. Then everything finished. So that's good news for me, but bad news for tracing the bug.
This was on a Manjaro system, I'm also planning to set up maestral on a Debian computer soon, I'll report back if I get anything similar.
No other programs reported similar errors.


Load fallback icon for custom class when no icon available

Follow up to #60535
In the Create Dialog, the fallback Object icon was not used when neither the custom class nor its base built-in class has icon.
This is common for custom Resource scripts.
For cherry-picking: {get,has}_theme_icon() → {get,has}_icon()

Cherry-picked for 3.5.


"listunspent" is showing already spent output

Background
"listunspent" command is showing already spent output:

$ lncli listunspent
{
... ,
{
"address_type": 0,
"address": "bc1qqdfaj7c6ccwmm8v4vtch828wn2vmf0p9c99ps0",
"amount_sat": 57783,
"pk_script": "00140353d97b1ac61dbd9d9562f173a8ee9a99b4bc25",
"outpoint": "93c6c2ce92acc3687cbd3ad32ba995c3788132851cf1cd6f7e6a0053d0021840:0",
"confirmations": 57182
}
]
}

Sometimes the LND is relying on this output and transactions can't be broadcasted. How to force rescan of UTXO set or remove this output?
Your environment
LND 0.7.0
Ubuntu Server 18.04
bitcoind 0.18.0
Steps to reproduce
I suppose that the trouble arose a year ago when LND crashed while opening a new channel.
Expected behaviour
UTXO set must include only unspent transaction.
Actual behaviour
UTXO set incluses already spent transactions

Sometimes the LND is relying on this output and transactions can't be broadcasted. How to force rescan of UTXO set or remove this output?

https://github.com/lightningnetwork/lnd/blob/master/docs/recovery.md#forced-in-place-rescan


add landscape scroll on click

Closes #4132

I've got something working here, I would like some advices on the choices made, maybe opinions on my Bus/Listener design.
Also, I fought against unit tests because I don't have access to the data landscapeContainer so I didn't figure out how to cover this part in tests:
const grabbing = (mouseEvent: MouseEvent): void => {         if (!isMoving.value) {           return;         }         if (!landscapeContainer.value) {           return;         }         landscapeContainer.value.scroll(           currentScrollX.value + (startX.value - mouseEvent.clientX),           currentScrollY.value + (startY.value - mouseEvent.clientY)         );       };
in src/main/webapp/app/module/primary/landscape/Landscape.component.ts
Maybe @Gnuk or @nonomoho you could bring some help ?


Add support in iOS alerts

Need a means to detect whether an alert is displayed, and if so - need to be able to verify the content (title, message, buttons).

Dupe of https://github.com/wix/detox/issues/9


New Clock: Space Resist

Add space clock watch face for banglejs2, which is inspired by a casio watch.

Looks great - thank you!


include-all-sources option runs code / slows down coverage

Setting the include-all-sources option in .istanbul.yml makes istanbul require source files, which then run outside of any global setup that might be done in test runs.  It also means that any require statements are also followed, leading to slower coverage times.
I was able to fix this locally by setting a flag process.env.istanbul_missing_files = true; in the missing file logic in istanbul-api, and checking for it in istanbul-lib-hook.  This made our coverage twice as fast (several minutes saved).
istanbul-api/run-cover.js
process.env.istanbul_missing_files = true;
if(missingFiles.length > 0) {
  missingFiles.forEach(function(file) {
    require(file);
    if (!cov[file]) {
      cov[file] = instrumenter.lastFileCoverage().data;
    }
  }
}
// { more missing file logic... }
process.env.istanbul_missing_files = undefined;

istanbul-lib-hook/hook.js
Module._extensions[ext] = function (module, filename) {
  var _compile = module._compile;
  module._compile = function (code, filename) {
    var ret = fn(code, filename);
    if (postLoadHook) {
      postLoadHook(filename);
    }
    if (!process.env.istanbul_missing_files) { // only return the compiled source if we aren't looking at missing files.
      return _compile.call(module, ret.code, filename);
    }
  };
  originalLoaders[ext](module, filename);
};

I'm certain that this isn't the right way to do this, but it's a start...

So I guess what you are trying to do is to only instrument the code and stuff the blank coverage into the coverage object and not require the file?
This is a good idea and I will find a better way to implement this. Thanks for the input!


Changes to make number of executors and wait time configurable

This pull request covers the changes to make number of executors and wait time configurable, so that per environment user can override these values.

I think we shouldn't add properties in conf/application.conf since this file will be packaged into the jar file. Furthermore, the jar of dr-elephant is in the first place of the classpath, which means user settings will be ignore by this conf inside the jar.
Instead, I recommend to add these properties in a config, e.g. GeneralConf.xml, inside app-conf.

I agree with @stiga-huang. @chetnachaudhari, can you add these properties to elephant.conf under app-conf directory.

I think this is superseded by #75 and can probably be closed.
@akshayrai


electrs fix missing local IP in CONNECT view

the local ip was not displayed correctly in ELECTRS->CONNECT menu

Missing TOR Address is fixed here
https://github.com/rootzoll/raspiblitz/pull/3388

coede change looks good - any reason to base thsi PR on "1.8" instead on dev?

code change looks good - any reason to base thsi PR on "1.8" instead on dev?

thought its very small fix without risk to get any functionality broke, so i did it in v1.8. Better use dev, even for small fixes?

thats fair - non breaking changes can be on active release branch. but if overlooked might be forgotten to be cherry picked into dev branch and so not getting into future versions. Always best to use dev branch for PRs and than note that its also a candidate to be also included in active release branch.