Only one action is shown.

This documentation should explain that, while the Actions attribute (the outer one) is an array, the UCI will only display the first action specified in the array.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 237cc665-0041-6374-bd81-56dcad94926f
Version Independent ID: cfddf72f-0ee5-df62-3c29-3e8af4e6b26c
Content: addNotification (Client API reference) in model-driven apps - Power Apps
Content Source: powerapps-docs/developer/model-driven-apps/clientapi/reference/controls/addNotification.md
Service: powerapps
GitHub Login: @KumarVivek
Microsoft Alias: kvivek

@devlinl Thanks for contacting us. We have created a internal work item for the respective dev team to investigate if it should show all the actions. Will update the docs if any when the issue is resolved. Closing the issue.  If you need further help, please reopen the issue or open a new issue.


Double html encoding of Organization Full Name

Gogs version (or commit ref): 491407ddf89fb4182c5401c47d2af38f0a30adca
Git version: 2.1.4
Operating system: Debian 3.16.7-ckt25-2+deb8u3 (2016-07-02) x86_64 GNU/Linux
Database (use [x]):

[x] PostgreSQL
[ ] MySQL
[ ] SQLite

Can you reproduce the bug at https://try.gogs.io:

[x] Yes (provide example URL)
[ ] No
[ ] Not relevant

Log gist:

Description
Double html encoding of Organization Full Name, see https://try.gogs.io/specialchars
Using Organization Full Name: We like 'quotes'
Expecting: We like 'quotes' in HTML
Getting: We like &#39;quotes&#39;

It seems correct here, maybe the issue is in your browser?

I mean I would expect We like 'quotes' as display value (so a We like 'quotes' HTML source) but I get We like 'quotes' as display value (and We like &#39;quotes&#39; as HTML source).

Oh I see, I guess I misunderstood. I think you're right.

Duplicated to https://github.com/gogits/gogs/issues/1937.


Cannot figure out how to disable the clipPath added by dotlottie

Hello there!
I'm working with some animations for a client currently, and we need to disable / remove the clipPath that dotlottie is adding in to the rendered SVG.
For example - in this particular code, the clipPath with the id __lottie_element_123 is what I would like to disable / remove:
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 1078 811" width="1078" height="811" style="width: 100%; height: 100%; transform: translate3d(0px, 0px, 0px); content-visibility: visible;" preserveAspectRatio="xMidYMid meet">
<defs>
  <clipPath id="__lottie_element_123">
    <rect width="1078" height="811" x="0" y="0"></rect>
  </clipPath>
</defs>
<g> [...] </g>
</svg>

However, I can't for the life of me find nor figure out where or how to accomplish this.
Can someone more familiar with the project please guide me to the documentation or share with me the instructions needed to accomplish this please?
Many thanks!

Hi @richardlampitt, may I know which player you're using? The dotlottie-web player doesn't have an SVG renderer 😕

We're using a file named 'dotlottie-player.js', which begins with these lines:
(function (global, factory) {
  typeof exports === 'object' && typeof module !== 'undefined' ? factory(exports) :
  typeof define === 'function' && define.amd ? define(['exports'], factory) :
  (global = typeof globalThis !== 'undefined' ? globalThis : global || self, factory(global.DotLottiePlayer = {}));
})(this, (function (exports) { 'use strict';
  var Ll=Object.defineProperty;var hu=Object.getOwnPropertyDescriptor;var cr=(t,e)=>()=>(t&&(e=t(t=0)),e);

and has these comments regarding bundled license info at the end of the file:
/*! Bundled license information:

  is-buffer/index.js:
    (*!
     * Determine if an object is a Buffer
     *
     * @author   Feross Aboukhadijeh <https://feross.org>
     * @license  MIT
     *)
  */
  /*! Bundled license information:

  xstate/es/_virtual/_tslib.js:
    (*! *****************************************************************************
    Copyright (c) Microsoft Corporation.

    Permission to use, copy, modify, and/or distribute this software for any
    purpose with or without fee is hereby granted.

     IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY SPECIAL, DIRECT,
    INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING FROM
    LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT, NEGLIGENCE OR
    OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION WITH THE USE OR
    PERFORMANCE OF THIS SOFTWARE.
    ***************************************************************************** *)
  */
  /*! Bundled license information:

  howler/dist/howler.js:
    (*!
     *  howler.js v2.2.3
     *  howlerjs.com
     *
     *  (c) 2013-2020, James Simpson of GoldFire Studios
     *  goldfirestudios.com
     *
     *  MIT License
     *)
    (*!
     *  Spatial Plugin - Adds support for stereo and 3D audio where Web Audio is supported.
     *
     *  howler.js v2.2.3
     *  howlerjs.com
     *
     *  (c) 2013-2020, James Simpson of GoldFire Studios
     *  goldfirestudios.com
     *
     *  MIT License
     *)
  */
  /*! Bundled license information:

  lottie-web/build/player/lottie_worker.js:
    (*!
     Transformation Matrix v2.0
     (c) Epistemex 2014-2015
     www.epistemex.com
     By Ken Fyrstenberg
     Contributions by leeoniya.
     License: MIT, header required.
     *)
  */
  /*! Bundled license information:

  lottie-web/build/player/lottie_light.js:
    (*!
     Transformation Matrix v2.0
     (c) Epistemex 2014-2015
     www.epistemex.com
     By Ken Fyrstenberg
     Contributions by leeoniya.
     License: MIT, header required.
     *)
  */
  /*! Bundled license information:

  lottie-web/build/player/lottie_svg.js:
    (*!
     Transformation Matrix v2.0
     (c) Epistemex 2014-2015
     www.epistemex.com
     By Ken Fyrstenberg
     Contributions by leeoniya.
     License: MIT, header required.
     *)
  */
  /*! Bundled license information:

  lottie-web/build/player/lottie_light_canvas.js:
    (*!
     Transformation Matrix v2.0
     (c) Epistemex 2014-2015
     www.epistemex.com
     By Ken Fyrstenberg
     Contributions by leeoniya.
     License: MIT, header required.
     *)
  */
  /*! Bundled license information:

  lottie-web/build/player/lottie_canvas.js:
    (*!
     Transformation Matrix v2.0
     (c) Epistemex 2014-2015
     www.epistemex.com
     By Ken Fyrstenberg
     Contributions by leeoniya.
     License: MIT, header required.
     *)
  */
  /*! Bundled license information:

  lottie-web/build/player/lottie_light_html.js:
    (*!
     Transformation Matrix v2.0
     (c) Epistemex 2014-2015
     www.epistemex.com
     By Ken Fyrstenberg
     Contributions by leeoniya.
     License: MIT, header required.
     *)
  */
  /*! Bundled license information:

  lottie-web/build/player/lottie_html.js:
    (*!
     Transformation Matrix v2.0
     (c) Epistemex 2014-2015
     www.epistemex.com
     By Ken Fyrstenberg
     Contributions by leeoniya.
     License: MIT, header required.
     *)
  */
  /*! Bundled license information:

  @lit/reactive-element/css-tag.js:
    (**
     * @license
     * Copyright 2019 Google LLC
     * SPDX-License-Identifier: BSD-3-Clause
     *)

  @lit/reactive-element/reactive-element.js:
    (**
     * @license
     * Copyright 2017 Google LLC
     * SPDX-License-Identifier: BSD-3-Clause
     *)

  lit-html/lit-html.js:
    (**
     * @license
     * Copyright 2017 Google LLC
     * SPDX-License-Identifier: BSD-3-Clause
     *)

  lit-element/lit-element.js:
    (**
     * @license
     * Copyright 2017 Google LLC
     * SPDX-License-Identifier: BSD-3-Clause
     *)

  lit-html/is-server.js:
    (**
     * @license
     * Copyright 2022 Google LLC
     * SPDX-License-Identifier: BSD-3-Clause
     *)

  @lit/reactive-element/decorators/custom-element.js:
    (**
     * @license
     * Copyright 2017 Google LLC
     * SPDX-License-Identifier: BSD-3-Clause
     *)

  @lit/reactive-element/decorators/property.js:
    (**
     * @license
     * Copyright 2017 Google LLC
     * SPDX-License-Identifier: BSD-3-Clause
     *)

  @lit/reactive-element/decorators/state.js:
    (**
     * @license
     * Copyright 2017 Google LLC
     * SPDX-License-Identifier: BSD-3-Clause
     *)

  @lit/reactive-element/decorators/base.js:
    (**
     * @license
     * Copyright 2017 Google LLC
     * SPDX-License-Identifier: BSD-3-Clause
     *)

  @lit/reactive-element/decorators/event-options.js:
    (**
     * @license
     * Copyright 2017 Google LLC
     * SPDX-License-Identifier: BSD-3-Clause
     *)

  @lit/reactive-element/decorators/query.js:
    (**
     * @license
     * Copyright 2017 Google LLC
     * SPDX-License-Identifier: BSD-3-Clause
     *)

  @lit/reactive-element/decorators/query-all.js:
    (**
     * @license
     * Copyright 2017 Google LLC
     * SPDX-License-Identifier: BSD-3-Clause
     *)

  @lit/reactive-element/decorators/query-async.js:
    (**
     * @license
     * Copyright 2017 Google LLC
     * SPDX-License-Identifier: BSD-3-Clause
     *)

  @lit/reactive-element/decorators/query-assigned-elements.js:
    (**
     * @license
     * Copyright 2021 Google LLC
     * SPDX-License-Identifier: BSD-3-Clause
     *)

  @lit/reactive-element/decorators/query-assigned-nodes.js:
    (**
     * @license
     * Copyright 2017 Google LLC
     * SPDX-License-Identifier: BSD-3-Clause
     *)
  */

Thanks @richardlampitt,
I think you're using the deprecated dotlottie player which uses lottie-web as an SVG renderer.
It's not related to this project.
Have you tried to select and remove that node using javascript ?
something like
const undesiredElement = querySelector("__lottie_element_123");
if(undesiredElement) {
    undesiredElement.remove();
}


Cant install  hashicorp/random or hashicorp/null no such file or directory

Cant install  hashicorp/random or hashicorp/null
Expected Behavior
Should install v3.5.1 fine
Actual Behavior
❯ TF_HELPER_LOG=debug m1-terraform-provider-helper activate
Already activated

❯ TF_HELPER_LOG=debug m1-terraform-provider-helper install hashicorp/random  -v v3.5.1
Getting provider data from terraform registry
INFO[0000] Provider data: {https://github.com/hashicorp/terraform-provider-random terraform-provider-random}
Getting source code...
INFO[0000] Resetting /Users/s126070/.m1-terraform-provider-helper/terraform-provider-random and pulling latest changes
INFO[0003] Bash execution output: Your branch is up to date with 'origin/main'.
Already up to date.
INFO[0003] Checking out v3.5.1
Compiling...
INFO[0003] Using build command: make build
INFO[0005] Bash execution output: go build -v ./...
INFO[0005] Bash execution output: Terraform v1.5.1
on darwin_arm64
+ provider registry.terraform.io/hashicorp/google v4.70.0
+ provider registry.terraform.io/hashicorp/google-beta v4.70.0
+ provider registry.terraform.io/hashicorp/time v0.9.1
INFO[0005] Installed Terraform version: 1.5.1
INFO[0005] No custom build path found
INFO[0005] Move from /Users/s126070/go/bin/terraform-provider-random to /Users/s126070/.terraform.d/plugins/registry.terraform.io/hashicorp/random/3.5.1/darwin_arm64/terraform-provider-random_3.5.1_x5
2023/06/27 11:18:25 rename /Users/s126070/go/bin/terraform-provider-random /Users/s126070/.terraform.d/plugins/registry.terraform.io/hashicorp/random/3.5.1/darwin_arm64/terraform-provider-random_3.5.1_x5: no such file or directory

❯ TF_HELPER_LOG=debug m1-terraform-provider-helper install hashicorp/null  -v v3.2.1
Getting provider data from terraform registry
INFO[0000] Provider data: {https://github.com/hashicorp/terraform-provider-null terraform-provider-null}
Getting source code...
INFO[0000] Resetting /Users/s126070/.m1-terraform-provider-helper/terraform-provider-null and pulling latest changes
INFO[0004] Bash execution output: Your branch is up to date with 'origin/main'.
Updating af9b0ed..673806b
Fast-forward
 .copywrite.hcl                     |  11 +-
 .github/CONTRIBUTING.md            |   9 +-
 .github/dependabot.yml             |   4 +
 .github/workflows/compliance.yml   |   3 +-
 .github/workflows/issue-opened.yml |   3 +-
 .github/workflows/pull-request.yml |   2 +-
 .github/workflows/release.yml      |   6 +-
 .github/workflows/test.yml         |  10 +-
 .golangci.yml                      |   6 +-
 GNUmakefile                        |   3 +-
 go.mod                             |  55 +--
 go.sum                             | 225 +++-------
 main.go                            |  10 -
 tools/go.mod                       |  93 ++++
 tools/go.sum                       | 864 +++++++++++++++++++++++++++++++++++++
 tools/tools.go                     |  14 +-
 16 files changed, 1084 insertions(+), 234 deletions(-)
 create mode 100644 tools/go.mod
 create mode 100644 tools/go.sum
INFO[0004] Checking out v3.2.1
Compiling...
INFO[0004] Using build command: make build
INFO[0007] Bash execution output: go build -v ./...
INFO[0007] Bash execution output: Terraform v1.5.1
on darwin_arm64
+ provider registry.terraform.io/hashicorp/google v4.70.0
+ provider registry.terraform.io/hashicorp/google-beta v4.70.0
+ provider registry.terraform.io/hashicorp/time v0.9.1
INFO[0007] Installed Terraform version: 1.5.1
INFO[0007] No custom build path found
INFO[0007] Move from /Users/s126070/go/bin/terraform-provider-null to /Users/s126070/.terraform.d/plugins/registry.terraform.io/hashicorp/null/3.2.1/darwin_arm64/terraform-provider-null_3.2.1_x5
2023/06/27 11:24:48 rename /Users/s126070/go/bin/terraform-provider-null /Users/s126070/.terraform.d/plugins/registry.terraform.io/hashicorp/null/3.2.1/darwin_arm64/terraform-provider-null_3.2.1_x5: no such file or directory

Your Environment

OS: 13.3.1 (22E261)
m1-terraform-provider-helper version: 0.8.2

Hmm looks like it was some weirdness with installing go via brew.
if i manually go into /Users/s126070/.m1-terraform-provider-helper/terraform-provider-random and run go build
then it correctly builds the binary into /Users/s126070/go/bin/terraform-provider-random
For some reason when run through the make file it doesn't work even though export GOPATH=$HOME/go

You do not need to this for the provider version v3.5.1 as it's compiled for arm already. See release config: https://github.com/hashicorp/terraform-provider-random/blob/v3.5.1/.goreleaser.yml#L25

Hmm thanks I guess i was also having some lock file issues that prevented it working initially. but deleting the .terraform and starting from scratch seemed to do the trick thanks


Reconnect on restart

By moving the connection to Carbon into the go function we achieve two
goals:

connection exceptions get caught
the restart function retries to connect to Carbon

See also: https://github.com/ocharles/ekg-carbon/issues/3#issuecomment-119217541

I think we'd do better if we bracket loop with a call to connect and disconnect (the disconnect is missing).
I think it would be try (bracket connect disconnect (\c -> loop c...)) (hand waving)

@ocharles you're right. It also became more readable using bracket, thanks for the suggestion.

Perfect!

If you can confirm this all works as expected, I'll push to Hackage

Yes, I manually tested in a service and everything seems to work as expected.


.of not documented in Scalar

Found a possible  documentation bug. Here's the discussion on #perl6
http://colabti.org/irclogger/irclogger_log/perl6?date=2017-08-31#l739
In short, .VAR returns the Scalar object according to https://docs.perl6.org/language/mop#index-entry-syntax_VAR-VAR
...but .of isn't documented there. Instead you find it in the Variable class. There seems to be no inheritance going on here, so something is probably wrong here. :-)
https://docs.perl6.org/type/Variable#trait_of

Resolved in b7ef4cb953.


change HTTP integration API

removed json_body, raw_body and form_body params
replaced by single body param which will be autoparsed to the relevant type (type match and/or headers)
added tests
disallow passing args, except url. All other params should be passed as kwargs
remove form() from response body

use data instead of body
add json

https://requests.readthedocs.io/en/latest/api/#requests.post


[CI:BUILD] Packit/rpm: fix aardvark-dns handling

Bodhi tasks are disabled in Packit config to allow manual submission of a single bodhi update containing netavark and aardvark-dns X.Y builds.
The netavark rpm will now depend on the minimum aardvark-dns X.Y build available to also account for patch releases. Ref: https://github.com/containers/netavark/issues/907#issuecomment-1914504620
Resolves: #907

i'll try to check if this is handled correctly in copr as well before we merge.

The rpm generated in the packit builds listed in CI can be installed with the current aardvark-dns rpm in rhcontainerbot/podman-next. So, AFAICT this should work.
This can also be partly verified with: $ rpmspec -q --qf '%{Requires}\n' rpm/netavark.spec. You'll need to update Version to 1.10.1 before you run that command.

@mheon @Luap99 PTAL

LGTM
/hold cancel

@Luap99 for whatever reason the lgtm label from your comment didn't get applied.

manually adding lgtm label


Schematic and PCB-Design v1.2

Fix following issues from v1.1

[x] increase pad size from L2
[x] add Jumper for BMS reset
[x] renew Annotaion
[x] State LED connect to 3V3 (not to 5V)
[ ] update BOM
[ ] create gerber

[ ] Pins 34 and 35 can ONLY be used as INPUT. Currently used as LED OUTPUT which is not allowed. Please check datasheet

Changes/Ideas to be implemented:

LEDs A, B and C cannot be controlled from the ESP and are only used to display the status of the corresponding LEDs on the Zumo robot as these are covered by the shield
Remove "Main Switch" Signal as turning the Zumo off through software can also be achieved through the reset pin. (Or using the main power switch on the shield)
Verify the Auto-flash circuit, as pulling GPIO0 to GND continously fails.


An HTTPS request is being sent through an HTTPS proxy

2024-11-13 02:55:26 | ⚠ WARNING | realdebrid.generate_download_link - Real-Debrid blacklisted server's IP. Switching to proxy http://warp-proxy.cf-warp-proxy.svc.cluster.local:1080 for 9c36d41bcaf294af8db8b77b728dd1f2befeaba3|3
/root/.cache/pypoetry/virtualenvs/comet-9TtSrW0h-py3.11/lib/python3.11/site-packages/aiohttp/connector.py:942: RuntimeWarning: An HTTPS request is being sent through an HTTPS proxy. This support for TLS in TLS is known to be disabled in the stdlib asyncio (Python <3.11). This is why you'll probably see an error in the log below.

It is possible to enable it via monkeypatching. For more details, see:
* https://bugs.python.org/issue37179
* https://github.com/python/cpython/pull/28073

You can temporarily patch this as follows:
* https://docs.aiohttp.org/en/stable/client_advanced.html#proxy-support
* https://github.com/aio-libs/aiohttp/discussions/6044

  _, proto = await self._create_proxy_connection(req, traces, timeout)
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

from inside pod socks seems to be working all fine. SOmething to do with proxy implementaion
/app # curl --socks5-hostname warp-proxy.cf-warp-proxy.svc.cluster.local:1080 https://cloudflare.com/cdn-cgi/trace
fl=466f76
h=cloudflare.com
ip=2a09:bac5:6440:1246::1d2:4c
ts=1731466824.572
visit_scheme=https
uag=curl/8.11.0
colo=SJC
sliver=none
http=http/2
loc=US
tls=TLSv1.3
sni=plaintext
warp=on
gateway=off
rbi=off
kex=X25519

you can ignore this error safely


--helpxml fixed

This option produced errors due to:

Default value for fio_io_depths being a list instead of a IntegerList
Default value for some other lists being None instead of []
Also, IntegerList lacked a proper str representation. It was added.

This solves #766

Hi @jldiaz , thanks for your pull request. Can you explain exactly what goes wrong to cause the error, and how changing default arguments to None and an explicit IntegerList fixes it?

Hello noahl.
All those problems are related to the way gflags module deals with default values for the flags and the way it stringifies them to generate the xml.
When using --helpxml option, gflags.WriteInfoInXMLFormat() is called for each flag, to generate a documentation which includes the string help, the current value, and the default value. For the current value is uses str(self.value), (self is the flag being processed), but for the default value it uses self.serializer.Serialize() if provided.
In addition, the default value is parsed to produce a python object which is stored as the current flag.value, but not as flag.default, which is stored unparsed,
This causes two problems in the case of the flags defined via DEFINE_integerlist(), as in fio_benchmark.py):
flag_util.DEFINE_integerlist('fio_io_depths', [1],
                             'IO queue depths to run on. Can specify a single '
                             'number, like --fio_io_depths=1, a range, like '
                             '--fio_io_depths=1-4, or a list, like '
                             '--fio_io_depths=1-4,6-8',
                             on_nonincreasing=flag_util.IntegerListParser.WARN)

The default value [1] specified in this case, is parsed and stored as a IntegerList object as the current flag.value, but stored unparsed as a python list as the flag.default. This causes two problems:

First, the IntegerList class does not provide a __str__() method, so when documenting the current value, it would appear as <perfkitbenchmarker.flag_util.IntegerList object at 0x7f8f1d88e650> instead of [1], for example. This can be easily solved by providing a __str__() method which calls IntegerListSerializer() to do the stringification. I did this in the pull request.

Second, the IntegerListSerializer expects its argument of type IntegerList, but when it is called with the default value as argument, it receives a plain python list instead, causing an exception when trying to access to its .groups attribute. This is solved by specifying as default value a IntegerList object, instead of a list.

A similar but slightly different problem happens for flags defined via DEFINE_list() (which expects a list of strings as value) when None is specified as default value. In this case None is stored both as the current .value of the flag, and as the .default value.
For the current .value, the presence of None instead of a list poses no problems (at least for the xml help), because it uses str(flag.value) to produce the documentation, and this will produce the string "None". But when serializing the .default value it causes a exception, because the serializer expects a list as argument (even if empty), and tries to iterate over it (see here). When the argument is None the exception TypeError: 'NoneType' object is not iterable is raised.
Again, this is solved by specifying as default value an object of the kind expected by the serializer, i.e. an empty list in this case instead of None.

LGTM. Merging.


proposal/question: improving diagnostics/handling of a cached invalid username

hi! first, thanks for this tool – it's much more pleasant to use than navigating through the dev portal to find the latest Xcode update. after having used xcodes several times in the past, i recently encountered an issue that was a bit difficult to diagnose. the setup:

i had previously installed Xcode via xcodes with Apple ID $email_1
i changed my Apple ID to $email_2
i attempted to install a new version of Xcode via xcodes

on step 3, i repeatedly received authentication errors, re-prompting me for my password (which was unchanged), but was not provided any way to re-enter my username (which was now incorrect). after a bit of digging through this repo, i discovered that the 'default' username gets cached in a configuration file for use in subsequent invocations. once i realized this, it was easy enough to fix, but it did take me a while to figure out what was going on.
so, i was wondering if we could add either some improved feedback, perhaps indicating how to override the cached value (it seemed like env variable, or editing the config file would both work), or introduce behavior that will re-prompt for the username in addition to the password based on some criteria.
admittedly, this is likely a very narrow edge-case, since i don't think Apple IDs change that often. still, i'd be willing to try and implement an improvement for this particular snag i hit, time permitting. so, my question is what approach should i pursue to improve this?

There's this in the README:

If you need to use a different Apple ID than the one that's remembered, set the XCODES_USERNAME environment variable.

Hi @jamieQ - thanks for the words.
A recent PR #136 that has been merged to main adds a signout command that will handle the situation you're into. It will remove all the caches it has as well as any keychain items.
This has not been released yet unfortunately. I'll try to get to that soon.

thanks for the prompt response! looks like the proposed addition in #136 would have made my experience easier. thanks!

@MattKiazyk Where are those caches located? I was investigating how the credentials could be distributed across CI machines and only saw the keychain item.

Hi @shepting - any cache that Xcodes would save would be in ~/Library/Application Support/com.robotsandpencils.xcodes
There may be some caching done by the the Mac that we can't control.

0.19.0 was released yesterday, and the signout command should help in this situation to clear things out.


ci: Fix Minitest

Minitest 5.19 removes the automatic compatability layer that allowed users to use MiniTest camel case module name.
https://github.com/minitest/minitest/compare/v5.18.1...v5.19.0
Rather than continuing to support antiquated code lets bring ourselves up to date with a rename that happened almost 10 years ago.

@scbjans although I appreciate a review, I require one from @open-telemetry/ruby-contrib-approvers
Have you reconsidered my offer to work towards approver? 😃

@arielvalentin I know you need another official approval.
My approval was my way of saying I tested and verified this PR (to fix CI for the open PR on the container resource detector).


Wix 4 Support?

Does this project have or plan to support Wix 4 (released at the beginning of April)?

Ah they made some big changes. Candle.exe no longer exists - everything is now in one .exe .
have you tried out yet if it works ? I don’t have a windows machine unfortunately to try


Added container.dart for Container class

Hey @AdityaKeshan , thanks for this PR! could you please provide some screenshots of your work?

Surely,
I have attached the screenshots in the email also.


unify read and readRelation

still some failing tests. i'm off to get lunch--will investigate when i get back.

@bobholt can you sanity check the remaining failing tests on this PR? I've just force pushed a re-work of what I started with yesterday. You can now do the following (and more):
GET /books/1/stores
GET /authors/1/books
GET /authors/1/books.chapters
GET /authors/1/books?filter[id]=10,11
GET /books/1/stores.books

readRelation has been removed from the controller, and the requirement for specifying one in read for single objects has been lifted.

Actually, pretty sure I know what is up. Additional commits incoming in a bit


[fix] Authorize setter of 'approved' label

Changes

close #226
This commit prevents an author of a pull request to approve his/her own
pull request.
FYI) If a bot account makes pull requests, race can happen for
'approved' label. (label -> unlabel -> label -> ...)
Submitter Checklist

[x] Docs included if needed
[ ] Tests included if needed
[x] Follows the good commit messages standard

/test


[devtools] fix #7331 by updating snippets guide

What's changed, or what was fixed?

updates snippets guide

Fixes: #7331
Target Live Date: 2019-03-25

[x] This has been reviewed and approved by @kaycebasques
[x] I have run npm test locally and all tests pass.
[x] I have added the appropriate type-something label.
[x] I've staged the site and manually verified that my content displays correctly.

CC: @petele

Whoops!
There were 13 warnings that will prevent this PR from being merged. Please take a look, and either fix, or provide a justification for why they can't be fixed.
WARNINGS
src/content/en/tools/chrome-devtools/javascript/snippets.md#L25 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/chrome-devtools/javascript/snippets.md#L45 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/chrome-devtools/javascript/snippets.md#L58 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/chrome-devtools/javascript/snippets.md#L71 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/chrome-devtools/javascript/snippets.md#L91 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/chrome-devtools/javascript/snippets.md#L107 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/chrome-devtools/javascript/snippets.md#L123 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/chrome-devtools/javascript/snippets.md#L139 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/chrome-devtools/javascript/snippets.md#L151 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/chrome-devtools/javascript/snippets.md#L175 - Common typo found: 'javascript' Should it be 'JavaScript'?
src/content/en/tools/chrome-devtools/javascript/snippets.md#L17 - Line must be at most 100 characters
src/content/en/tools/chrome-devtools/javascript/snippets.md#L79 - Line must be at most 100 characters
src/content/en/tools/chrome-devtools/javascript/snippets.md#L172 - Line must be at most 100 characters

Note: #7446 was a continuation of this PR.

:tada: This has been pushed live to https://developers.google.com/web/


SVG images fail to copy

When looking at an SVG image using the toolkit, the overlay comes up and displays the image fine.  However, when attempting to copy the image to the clipboard, I consistently get the message 'Fail to copy the image' and nothing is copied to the clipboard.

I've encountered the same issue.


test: Add integration tests for node

Integration tests against prism mock server for generated node code.
Jira

These tests keep failing and I have an idea why, but I'm not sure how to fix it.
On my local machine, if I run the node-test service in docker-compose, the integration tests fail with a "Nock: no match for request" message. When I look at the prism server, none of the requests came through.
HOWEVER, if I stop and re-run the prism server, then run the node tests again, everything works fine (prism server gets hit).
Could this be an issue with prism not being ready in time...?

@mattcole19 Yes, entirely possible. Workarounds in the past:

77da272 (#269)
https://github.com/sendgrid/sendgrid-oai/blob/c3aaa432b769faa47285166aca17c7ed2ea71787/prism/docker-compose.yml#L8

Still unable to get these integration tests passing via github actions. They work locally, but only when I restart the prism server and re-run the node tests. Adding a "sleep 60" didn't resolve the issue :/
I'm really not sure how to proceed here...

@mattcole19 Tests fail for me locally. Are you running make test-docker?

@mattcole19 Tests fail for me locally. Are you running make test-docker?

Yes. They fail for me initially too, but when I restart the prism server and re-run the node service (typically via Docker desktop), they pass. Not sure why this "fixes" the issue

I'm seeing nock issues. Looks like it's not being cleaned. Recommend sticking this at the top of all the files that use nock:
afterAll(() => {
  nock.cleanAll();
});


Usage Guide

I've written up a detailed guide on how to set this up with Terraform, which might be useful:

daniel-rhoades/acs-engine-terraform;
danielrhoades.com detailed article.

I still want to enhance it a bit, but it's still complete right now.
Feel free to reference it if you think it's useful.

Thanks Daniel for the link to your detailed guide.  This is really cool.  Your github account is quite discoverable by customers, so we will close this for now.  If you wanted this referenced, this may be a good candidate to reference under https://github.com/Azure/acs-demos.


tsd query angular2 returns zero results

Running
tsd install angular2 es6-promise rx rx-lite
installs es6-promise rs and rx-lite but not angular2
running:
tsd install angular2  or  tsd query angular2 --save --action install --resolve
returns zero results.
can you help?

Angular 2 typings are provided as part of the NPM module, why do you need to install them with TSD?

There are currently no angular2.d.ts in node_modules / angular2 / typings

Thanks. I did not know that at the time I sent you the message. But did my
leg work and I learn it. Thanks for taking your time.
On Feb 13, 2016 3:38 PM, "rodrigo"<EMAIL_ADDRESS>wrote:

There are currently no angular2.d.ts in node_modules / angular2 / typings
—
Reply to this email directly or view it on GitHub
https://github.com/DefinitelyTyped/tsd/issues/273#issuecomment-183750998
.

+1

@siulm have you resolved this somehow?

David hi.  Yes.
Blake said: Angular 2 typings are provided as part of the NPM module.
He was right.  I found it on line and Blake was nice to confirm it.
Once you install Angular2 with npm, The problem goes away.  All the tsd is
part of the node modules
I hope this helps
Luis
On Feb 24, 2016 3:38 PM, "Dawid Krajewski"<EMAIL_ADDRESS>wrote:

@siulm https://github.com/siulm have you resolved this somehow?
—
Reply to this email directly or view it on GitHub
https://github.com/DefinitelyTyped/tsd/issues/273#issuecomment-188446024
.

Yes,
Still i face the same problem like:
src/app/app.ts(1,36): error TS2307: Cannot find module 'angular2/angular2'.
5:47:02 PM - Compilation complete. Watching for file changes.
How to solve this, anyone please help me..

Try this in your bootstrap file:
///<reference path="../node_modules/angular2/typings/browser.d.ts"/>
I think it was in a recent update that they changed something with the typings

If I am not mistaken, it should be angular2/core instead of
angular2/angular2.
Hope that helps.
On Mar 21, 2016 8:17 AM, "RajenRanjith"<EMAIL_ADDRESS>wrote:

Yes,
Still i face the same problem like:
src/app/app.ts(1,36): error TS2307: Cannot find module 'angular2/angular2'.
5:47:02 PM - Compilation complete. Watching for file changes.
How to solve this, anyone please help me..
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/DefinitelyTyped/tsd/issues/273#issuecomment-199247487

tsd query angular2/core also returns zero results...

Have done a 'npm install angular2'
That should install all requirements for angular 2.  Typings will be part
of it
On Mar 25, 2016 6:10 PM, "Vinothbabu"<EMAIL_ADDRESS>wrote:

tsd query angular2/core also returns zero results...
—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
https://github.com/DefinitelyTyped/tsd/issues/273#issuecomment-201543193

I don't find angular2.d.ts as part of package via NPM.
Is exists any solution for this issue?
Thanks.

I installed tsd via npm, yet angular2 is still not found. Does anyone know how to solve this issue?
Thank you!

See https://github.com/DefinitelyTyped/tsd/issues/273#issuecomment-181607758


Directory with many files (400+) is excluded from search if not explicitly included

VSCode Version:

code --version
1.30.2
61122f88f0bf01e2ac16bdb9e1bc4571755f5bd8
x64

rg --version
ripgrep 0.10.0
-SIMD -AVX (compiled)
+SIMD +AVX (runtime)

OS Version:
Arch Linux

Steps to Reproduce:

Have a folder with a ton of files in it (in my case, a migrations/ dir with 400 or so)
Hit cmd+shift+f and search for strings that should be within that folder, they don't show up, but if you change to only search within that directory it works A OK

Does this issue occur when all extensions are disabled?: Yes
edit: apologies for all the edits, github is super jumpy on filing a new issue if you fat finger enter

Can you try downloading the Insiders' build and tell me whether it happens there? https://code.visualstudio.com/insiders

code-insiders --version
1.31.0-insider
f125fdfa20b217dea34001eac9866322418226ce
x64

Just tried again with insiders, from the same project searching for the same thing

Could it be that there's some hidden cap on results from within a folder?

Are you sure that the folder isn't excluded by some setting or gitignore pattern? See some troubleshooting tips here: https://github.com/Microsoft/vscode/wiki/Search-Issues#missing-search-results


Delete: martinchrzan.ColorPicker version <IP_ADDRESS>

[ ] Have you signed the Contributor License Agreement?
[ ] Have you checked that there aren't other open pull requests for the same manifest update/change?
[ ] Have you validated your manifest locally with winget validate --manifest <path>?
[ ] Have you tested your manifest locally with winget install --manifest <path>?
[ ] Does your manifest conform to the 1.0 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

First I have to delete, then add separately.

@msftbot wake up now!


[SUGGESTION] Add cases in inventory changer?

It would honestly be pretty cool if it would be possible to add cases to your inventory and open them in lobby/in game. other people wouldnt be able to see it but its client sided. :)

+rep

I would really like that.
+1

search for # in inventorychanger.cpp and add #CSGO_Type_WeaponCase and #CSGO_Tool_WeaponCase_KeyTag to the other ones

search for # in inventorychanger.cpp and add #CSGO_Type_WeaponCase and #CSGO_Tool_WeaponCase_KeyTag to the other ones

Is it working? Have you tested it?

yes. you would still need to add the function for the opening tho. atleast you can click on open and the animation plays

You can now open cases (86e1c5ccf6606e26d88fc7d5c4ce4faeb144603b).


handle redirect correctly

A redirect is only valid in case of http -> https. When called with https,
a service should respond with 401. (Except publicly accessible applications)

:+1:

Codecov Report

Merging #498 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master     #498   +/-   ##
=========================================
  Coverage     53.68%   53.68%
  Complexity      486      486
=========================================
  Files           132      132
  Lines          2982     2982
  Branches        203      203
=========================================
  Hits           1601     1601
  Misses         1302     1302
  Partials         79       79

Impacted Files
Coverage Δ
Complexity Δ

...do/stups/fullstop/jobs/common/HttpGetRootCall.java
0% <0%> (ø)
0 <0> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8baa96...54495d7. Read the comment docs.

👍


3.8.0 - Remove/Change Build method for Modules/Launcher

I hate cake and does not always work
Examples:

Having to build twice,
Cake rebuilds the project after it already builds,
Make it usable across all IDE builds and cli

change build process
will look at this later

Originally written by CWX

What if we use just a regular dotnet publish tool?
Storing the publish profile as profile file might be kinda wonky to support tho
For example, Rider stores publish profile as .xml file like this:

For VS it's a .pubxml file:

For VSCode I guess the tasks system should be used
Anyway, that means to make it usable across different IDEs that way, we'll need to have (at least) 3 different files with publish configuration, which is big meh IMO
Other solution might be to have a raw dotnet publish call with all arguments as a post-build event in Release build configuration
Also can be made as a .bat file, dunno, feels meh too
To make a fully identical release build as it is currently via cake, but via dotnet publish:
dotnet publish -c Release -o ../Build/ -r win10-x64 -p:PublishSingleFile=true -p:IncludeNativeLibrariesForSelfExtract=true --self-contained false

Attachments

image.png (20 KiB)
image.png (16 KiB)

Originally written by Saber

the above didnt work for me, had some issues a few days ago whilst trying it
i have made a batch script version that works: https://dev.sp-tarkov.com/SPT-AKI/Modules/commit/ec4d3de4891338f7c263b74e5a021cbd4292e697
i will say this is my first attempt at making a build script so any suggestions/improvements are welcome

Originally written by CWX

build scripts merged, closing ticket

Originally written by CWX


FR: Node indicator that informs user a node has custom/additional documentation

For consideration:
A few requests to add a "nodepad" indicator to nodes when e a node has additional documentation added - so that the user/viewer can see at a glance it exists.
Additionally, this indicator would be clickable and bring the Information sidebar panel to the front.
At a stretch, the indicator would, upon hover, show the user part or all of the rendered text for quick view.
See one of the more prominent threads here: https://discourse.nodered.org/t/special-indication-on-nodes-with-description/78646

@GogoVega has kindly requested to pick this up

Don't forget to ignore the ignores from nrlint 😉
For example, in this flow, all nodes have content in the Description tab, but that content is not documentation.
[{"id":"60f73b31a5feedbc","type":"tab","label":"Flow 2","disabled":false,"info":"","env":[]},{"id":"929fa70fb4f81894","type":"inject","z":"60f73b31a5feedbc","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"","payloadType":"date","x":360,"y":310,"wires":[["1c784665e0972feb"]],"info":"// nrlint no-overlapping-nodes:off\n"},{"id":"1c784665e0972feb","type":"change","z":"60f73b31a5feedbc","name":"","rules":[{"t":"set","p":"payload","pt":"msg","to":"","tot":"str"}],"action":"","property":"","from":"","to":"","reg":false,"x":550,"y":310,"wires":[["a2596d9f6f1b3954"]],"info":"// nrlint no-loops:off\n"},{"id":"a2596d9f6f1b3954","type":"switch","z":"60f73b31a5feedbc","name":"","property":"payload","propertyType":"msg","rules":[{"t":"eq","v":"","vt":"str"},{"t":"eq","v":"","vt":"str"}],"checkall":"true","repair":false,"outputs":2,"x":730,"y":310,"wires":[["3a1f5def043fa0f1"],["1c784665e0972feb"]],"info":"// nrlint no-loops:off\n"},{"id":"3a1f5def043fa0f1","type":"debug","z":"60f73b31a5feedbc","name":"debug 1","active":true,"tosidebar":true,"console":false,"tostatus":false,"complete":"false","statusVal":"","statusType":"auto","x":902,"y":302,"wires":[],"info":"// nrlint align-to-grid:off\n"},{"id":"e784264bb76bb4a8","type":"inject","z":"60f73b31a5feedbc","name":"","props":[{"p":"payload"},{"p":"topic","vt":"str"}],"repeat":"","crontab":"","once":false,"onceDelay":0.1,"topic":"","payload":"","payloadType":"date","x":350,"y":330,"wires":[[]],"info":"// nrlint no-overlapping-nodes:off\n"}]

@GogoVega just a quick heads up. The first V4 beta is not far off. Was wondering if you have a branch or PR to attach to this issue?

Not really, Nick doesn't like the idea of the badge, it seems to me that we still don't have a concrete idea for this issue.

Wouldn't we add a tooltip (mouseover) to each nodes? The tooltip would contain the first sentence as for the palette.
We can modify the tooltip so that it opens the sidebar when clicked (to see more).

Something like:
https://github.com/node-red/node-red/assets/92022724/1aeaf7f2-1d08-4fb1-b52d-14997dcaa6b1
Todo list:

put it down (bottom)
format the text (markdown)
make it more beautiful

@knolleary do you like the idea?


Teams notifier enhancements

Some enhancements for our TeamsNotifier processor:

Show app icon from repository (requires env var "ICON_BASE_URL" to be set
Include supported_architecture in output
Enhance the displayed name attributes

Confirmed working icons and supported architectures. Code changes look fine to me.


Project 1 (Agile & Scrum)

In this overview project, my aim is to know how to work around github. I will add milestones, labels and statuses as per instructions. A readme file will provide a full summary of the project except a new table project that will be created under projects. In the table project, I will list all tasks to be done for the semester, starting from classes to be attended to work that should be covered under the PoE. All these tasks will have time in hours of how I'll be working on them per day.


Can't import with node

While package works fine with SvelteKit/Vite, it can't be imported as an ESM package with node.
If I understand correctly, there are three changes to make this work:

Add "type": "module" to package.json, so that it's seen as an ESM package.
Add "exports": "./dist/index.js" to package.json, to set what is being exported.
Use .js extension in internal imports within the package.

My use case for this is handling a WebSocket connection outside the SvelteKit middleware using adapter-node.

Hey! Thanks for reporting this. I will try to get it resolved later today.

This should be fixed in 1.3.2, if you're still running into problems let me know.

Works great. Thank you for the super fast response!
During a svelte-kit build there is a warning that I don't think was there before:

[vite-plugin-svelte] The following packages did not export their package.json file so we could not check the "svelte" field. If
you had difficulties importing svelte components from a package, then please contact the author and ask them to export the package.json file.

 The warning should be gone in 1.3.3


fix: support nested arrays

Description of changes:
Change rendering logic so that nested arrays are supported. Add E2E test
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #746 (0ff1741) into main (45a2e81) will decrease coverage by 0.03%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##             main     #746      +/-   ##
==========================================
- Coverage   91.41%   91.38%   -0.04%
==========================================
  Files         102      102
  Lines        4044     4053       +9
  Branches     1129     1131       +2
==========================================
+ Hits         3697     3704       +7
- Misses        325      326       +1
- Partials       22       23       +1

Impacted Files
Coverage Δ

...codegen-ui-react/lib/forms/form-renderer-helper.ts
98.22% <ø> (ø)

.../codegen-ui-react/lib/forms/react-form-renderer.ts
81.09% <ø> (ø)

...-ui-react/lib/utils/forms/array-field-component.ts
91.66% <33.33%> (-8.34%)
:arrow_down:

packages/codegen-ui-react/lib/forms/form-state.ts
98.38% <100.00%> (+0.08%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a2e81...0ff1741. Read the comment docs.


Bump minimum PHP version to 7.2

Only 0.2% installations are using PHP 7.1
https://packagist.org/packages/friendsofphp/php-cs-fixer/php-stats#3.2

Are there data providers and unnecessary skipping to clean up in the tests?

potentially, there are.
yet, that cleanup is not providing the biggest value to justify prioritizing effort for it

Maybe we can remove Symfony 4.x components dependencies?

when I checked initially there was somemething still blocking, but maybe it's no longer the case. I was also thinking about lower PHPUnit. Let's check after this one is merged


Upgrade to version 3.2

Are there instructions for upgrading from older versions to version 3.2?

Hi @SemBurendo,
Thanks for reaching out to us.
For upgrade instructions please refer to "Upgrade" section in the " Wiki' of the Git Hub repo.
Thanks.

duh, thanks


error Command failed with signal "SIGSEGV".

error Command failed with signal "SIGSEGV".
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

I'm also getting this issue

Any idea what might be causing this? I'm also getting this issue.

Could you provide some steps to reproduce?

any update on this??

I also had this issue. I tried debugging it a bit.
For me it breaks at the first getPage I try, on this line:
https://github.com/next-page-tester/next-page-tester/blob/4cea3f87801632f9f21644c2cad7efb15605cafe/src/nextConfig.ts#L37
The value of nextRoot is correct.
I have an extremely basic next.config.js
module.exports = {   basePath: '/pagine',   reactStrictMode: true,   poweredByHeader: false,   serverRuntimeConfig: {},   publicRuntimeConfig: {}, };
Next version: 12.0.7
next-page-tester: 0.31.0
running on IOS
Hope this helps!

Closing since there's no repro and there's no way to ensure whether still relevant.


didTouchCosmos called Twice

Its working in Emulator, but in device if not selected precisely inside star, didTouch is getting called twice and sets the max rating possible.

Closing, Was hiding that subview that was causing an extra trigger.


go-1.23 and satisfy linter warnings

Also remove home grown crypto
TODO:
@vknabel sometimes TestMultiIssuerCache_retryFailing is failing ? Please have a look during my vacation

The error was a race condition within the tests if a couple of additional milliseconds passed. As a barrier I subtracted some milliseconds from the awaited time period.


Export Retimed Subs

I'm not sure if this is something that browsers are capable of doing, or if it is outside the scope of this project, but being able to export or replace subs that are retimed when you watch them would be a nice feature since then they would be permanently fixed rather than temporarily fixed. Seeing as how most japanese subs have notoriously bad timings, if as someone works their way through watching a show timed on animebook they could just easily fix the subs these could easily be re-uploaded to kitsunekko drastically reducing this problem.
if I'm going to be watching a mountain of untimed anime, I might as well fix it and re-upload while i'm at it. that said i don't care nearly enough to download an external tool and do it manually for each episode I watch. that said if there was just an export button that would make it easy enough to justify doing it.

Probably possible, but animebook isn't suited for this. It only offsets by a static amount, so if timing is more messed up than that e.g. you need a  3 second offset before the OP, and a 13 second offset after, then exporting isn't useful anyway. Plus, since the site supports .srt, .ass, and .vtt, I'd need to support all 3 as a potential export format depending on which one you uploaded, which just sounds complicated. Especially when it comes to .ass files, which animebook drastically simplifies when displaying. For example, an .ass file might have crazy colored fonts and karaoke, which you can't see in animebook (you just see text), so it's not exactly a good environment for editing the subtitles in the first place. You don't want to be editing something you can't see. Also, animebook would only be able to edit 1 episode at a time, which sounds awkward to me, since you're usually interested in fixing an entire series.
I say to leave this job to the tools designed for it e.g. Aegisub or Alass. The static offset is really just to mimic a similar feature in mpv.

so if timing is more messed up than that e.g. you need a 3 second offset before the OP, and a 13 second offset after, then exporting isn't useful anyway.

This is true, but many subs aren't broken in this way. Many just need a one off offset to fix it entirely.

Also, animebook would only be able to edit 1 episode at a time, which sounds awkward to me, since you're usually interested in fixing an entire series.

I mean I would suggest that's exactly why it's such a good fit. If I go through and watch a full episode of a show then  I know for sure that the subtitles are correct. Obviously this isn't good for an automated push it in and spit it out option, but in my experience with stuff like alass, those tools aren't very good anyways. You say 1 at a time like this is something I would be going out of my way to do. I'm going to be watching the series anyways.
I'll give you one such example where this would be a huge boon. I'm planning on going through and watching one piece once I'm done with my current show as part of my immersion. Now I've jumped around to a couple of episodes hundreds of episodes apart and they all need like a substantial offset (on the order of like 75-95 seconds but it varies) due to stuff like the toei lead-in on horriblesubs. It is like such a bad offset that I could see someone actually thinking the subs were downright wrong or broken. That said the offset doesn't ever appear to change as the episode goes on, so a single offset restructuring fixes it entirely. Running it through alass breaks it completely. I'm not particularly interested in downloading an external tool to manually fix every single episode, but the way I see it if it was built into the player and i'm going to be watching hundreds of episodes of one piece anyways, it would be really useful to the greater community if I could just offset on each individual episode as I'm watching the series and spit out fixed subtitles to upload to kitsunekko that it would be a good thing.
To be clear this is your project and I'm super grateful that it exists at all, so don't consider this any sort of a demand. I just think that it could be a simple, low friction way for people to increase the overall quality of subs available. Either way if you don't think this is a fit for the project (or you don't want to do it) you can feel free to close the issue.

Yeah, I'm still not convinced. I could maybe see it saving you some time if you're interested in fixing something like One Piece, but that show's still the simple case, where the offset works for it (for many shows it does not). And if an offset does work, it's not really a big deal to open the file in Aegisub and hit Timing > Shift Times... if you must fix it. If you don't need to fix it, then I wouldn't worry about it. Fixing One Piece is a huge undertaking anyway, so you're still going to need dedication to regularly download a file every episode you watch (not to mention to watch every episode; there's a lot of filler).
I'm also not sure I would even trust a subtitles file spit out by animebook. The tool invites you to retime the subs in realtime as you watch a show e.g. offset by 10 seconds pre-OP, then by 5 seconds after the OP, and I could see myself exporting at the end without realizing the offset doesn't work. You don't really have an overall picture of what's happening like you do in Aegisub. And the "Offset Subtitles" button isn't super accurate in the first place, in part due to browser limitations, since it'll give you offsets like 4.86, 5.08, inviting you to ignore that there's probably a perfect offset of 5 seconds exact if you don't realize it. From my standpoint, the feature's limitations really overshadow the small time savings you might get from it.


update ekf

This PR includes the fix of https://github.com/PX4/Firmware/issues/8102 and it uses the ground clearance parameter if the vehicle is on ground and out of range.

The code changes look OK, but the following mavros regression test failed:
http://sitl01.dronetest.io/job/PX4 Firmware POSIX SITL PRs/7196/testReport/__main__/MavrosMissionTest/test_mission/

There seem to be some issues with CI. Now sitl worked but travis didn't even though I didn't change anything... And semaphoreci is broken for a while it seems.

The semaphoreci failure is real. px4fmu-v2_default is out of flash again.

@davids5 can we remove mpu9250 from px4fmu-v2_default?

@priseborough @dagar I've rebased this PR and now all checks have passed.

Good to go?

Can we bump the ecl reference to 61e0c04 so that it includes the position timeout bugfix?

Two test flights:
https://logs.px4.io/plot_app?log=0ec0d863-a41e-4594-8966-34b6f6465dcb
https://logs.px4.io/plot_app?log=7b9d66a9-8ed6-4f7b-abea-8361010d4f0a (with range aid)
Was working nicely! I also switch from flow to GPS + flow and back.
The only thing is that it is saying ekf2 and frsky_telemetry are low on stack (see log).

Awesome!

I've started on protection against flying the flow sensor outside of its speed and minimum focus distance here: https://github.com/PX4/ecl/tree/ekfPosCtrlLimits-wip and here: https://github.com/priseborough/Firmware/tree/ekfPosCtrlLimits-wip
I will submit a PR for these changes tomorrow. i did some testing today, but it was too windy to make a useful assessment. It works in SITL, but the controller changes need to be flown manually to get a better assessment as to whether the method of respecting the minimum height and max speed  is acceptable from a UX point of view.


Revert "Allow Money.zero to specify a currency for strictness"

Reverts Shopify/money#156
It was not really documented, if you go searching for it you might've found https://github.com/Shopify/money/pull/105#issuecomment-329260394 and there's definitely been some discussion on Slack that's now archived, so I guess that's my fault for not writing it up.
But I've understood Money.zero's intention was to return a polymorphic zero, i.e. always a null currency, even with the end goal of removing the implicit default currency (see https://github.com/Shopify/money/pull/154).
We stumbled across this concept in the RubyMoney repo where this paper (paragraph 3.7) was referenced. It's useful as an initial value for sum if you don't care about the currency when the amount is zero, which IIRC fitted a couple of cases we saw in core at the time.
Besides that, Money.new(0, 'USD') was always an option. I'm not sure what value Money.zero('USD') brings to achieve the same thing?

Motivation on my end was that we don't want polymorphic zero's in several places throughout Order, Checkout, and Transaction's, as we want to force all currencies to match the respective object's currency. We don't need this change in Money, since we're porting things to MoneyBag, but figured it'd be nice to maintain consistency between the two objects. Manually creating a currencied, but 0-value money bag is much more cumbersome that Money, hence the need to augment the API:
MoneyBag.new(
  shop_money: Money.new(0, 'CAD'),
  presentment_money: Money.new(0, 'CAD')
)
# vs
MoneyBag.zero('CAD')

All said though, I can see us eventually dropping this particular pattern once everything has been converted to MoneyBag's... (or at the very least, augmenting further in a way that will certainly not be compatible with Money's API)

/cc @cpauderis @grcooper @sjswoboda @zacharyreynochiasson RE what do we want out of a MoneyBag.zero

I don't mind either way. The original idea for Money.zero was that it represents the absence of money, hence why it did not have a currency. That being said if there is a need for an alias to Money.new(0, 'USD'), got no strong feeling against it. The default behaviour of Money.zero stays intact.


How is effcientnet backbone faster than resnet backbone?

Hello,
I am trying to find the 2x improvement model.
As reported here : https://github.com/zetyquickly/DensePoseFnL/blob/master/doc/OUR_MODEL_ZOO.md, looks like Resnet-50 backbone has the best FPS 13.16.
Does it mean that changing the backbone to Mobilenet or Efficientnet does not improve inference latency of the densepose model?

This family of the models is fastest https://github.com/zetyquickly/DensePoseFnL/blob/master/configs/s0_bv2_bifpn_f64_s3x.yaml
You can measure speed without training. If you want to reproduce results of the paper you need to train it on DensePose COCO first.

Thank you @zetyquickly. I will compare the inference speed.

Hello @zetyquickly
I am using s0_bv2_bifpn_f64_s3x.yaml for kickstarting the training on COCO dataset.
But when I start the training, it directly jump on the evaluation step.
[03/17 03:44:00 d2.data.common]: Serialized dataset takes 444.87 MiB
[03/17 03:44:00 d2.data.build]: Using training sampler TrainingSampler
[03/17 03:44:02 fvcore.common.checkpoint]: No checkpoint found. Initializing model from scratch
[03/17 03:44:02 d2.engine.train_loop]: Starting training from iteration 0
[03/17 03:44:04 fvcore.common.checkpoint]: Saving checkpoint to ./output/model_final.pth
[03/17 03:44:05 d2.data.datasets.coco]: Loaded 1508 images in COCO format from datasets/coco/annotations/densepose_minival2014.json
[03/17 03:44:05 d2.data.build]: Distribution of instances among all 1 categories:

category
#instances

person
5581

[03/17 03:44:05 d2.data.common]: Serializing 1508 elements to byte tensors and concatenating them all ...

[03/17 03:44:05 d2.data.common]: Serialized dataset takes 21.13 MiB

[03/17 03:44:07 d2.evaluation.evaluator]: Start inference on 1508 images

[03/17 03:44:59 d2.evaluation.evaluator]: Inference done 11/1508. 0.0421 s / img. ETA=1:50:37

[03/17 03:45:08 d2.evaluation.evaluator]: Inference done 13/1508. 0.0427 s / img. ETA=1:49:55

[03/17 03:45:14 d2.evaluation.evaluator]: Inference done 14/1508. 0.0428 s / img. ETA=1:54:23

Is there a bug in s0_bv2_bifpn_f64_s3x.yaml config?
I tried using other configs e.g. https://github.com/zetyquickly/DensePoseFnL/blob/master/configs/densepose_rcnn_mobilenetv3_rw_FPN_s1x.yaml and training worked fine. I doubt that something is different for s0_bv2_bifpn_f64_s3x.yaml which is causing this issue.

I took a look at the s0_bv2_bifpn_f64_s3x.yaml.
MAX_ITER is set to 10. Looks like a typo to me.
BASE: "s0_bv2_bifpn.yaml"
MODEL:
FPN:
OUT_CHANNELS: 64
ROI_BOX_HEAD:
CONV_DIM: 64
ROI_SHARED_BLOCK:
ASPP_DIM: 64
CONV_HEAD_DIM: 64
SOLVER:
MAX_ITER: 10
STEPS: (330000, 370000)
TEST:
EVAL_PERIOD: 390000

Changing MAX_ITER to 390000 fixed the issue.

@abhaydoke09 Yes, this option tells when to end training, and detectron2 by default starts evaluation after whole training that took only 10 batches

@zetyquickly Can you please let us know how you measured the FPS of s0_bv2_bifpn_f64_s3x.yaml and densepose_rcnn_R_50_FPN_s1x.yaml models? In your paper, s0_bv2_bifpn_f64_s3x.yaml achieves 23.55 FPS as compared to densepose_rcnn_R_50_FPN_s1x.yaml model's 13.16 FPS.
I am looking for a way to accurately measure and compare FPS of these 2 models. When I ran the evaluation on COCO dataset on Tesla V100 GPU, densepose_rcnn_R_50_FPN_s1x.yaml inference time was better than the s0_bv2_bifpn_f64_s3x.yaml.
Can you please let me know how you exactly computed/measured FPS of these models?
Thank you in advance.

The results are obtained on 1080ti. FPS measured by dividing 1 on pure compute time that outputs detectron2 evaluator.

Can you please add the script which does this evaluation?

I believe there might be ambiguities in exact results, but you should obtain close results on your machine with 1080Ti if you follow all hints listed in the paper, and there's no need to modify anything except configs.
You need to:

use s0_bv2_bifpn_f64_s3x.yaml
set shortest edge on test to 512px
run it on DensePose COCO minival and obtain pure compute time

Also refer to the part 4.4 of our paper and run evaluation using the following command (with additional flags):
python train_net.py --config-file configs/s0_bv2_bifpn_f64_s3x.yaml --eval-only MODEL.WEIGHTS model.pth
MODEL.RPN.POST_NMS_TOPK_TEST 100 MODEL.ROI_HEADS.NMS_THRESH_TEST 0.3

@abhaydoke09 Were you able to train configs/s0_bv2_bifpn_f64_s3x.yaml model from scratch? Could you let me know the loss values you got for this?

Hi @nihal1294

I am training on a single GPU (V100) with batch size = 4 and base LR = 0.0025 and the model does not seem to be learning at all.

Regarding this I'd say that you've chosen correct LR relative to batch size. It might be the problem in the data, have you downloaded COCO + DensePose COCO and created symlinks to it? It might be a problem with your train script call, how to do you start training? And it is also likely that 3 hours is not enough for the model to and I propose to find an environment where there are 4 GPUs or increase LR as an experiment

@zetyquickly thanks for the response.
I was trying to train with --qat enabled. When I tried quantization aware training, the model was not learning at all even after 24 hours. So I am currently training without --qat flag and the model is learning, but even after 400k iterations, the model has not learned well. I am using DensePose COCO dataset itself. This is the network I am trying to train configs/s0_bv2_bifpn_f64_s3x.yaml
I am currently training with 2 batch size and LR = 0.0025 and the total_loss value has dropped to 1.8 - 2.0. I am hoping that with more iterations, the model will learn better.
I will not be able to get 4 GPUs for training to test with.

@zetyquickly thanks for the response.
I was trying to train with --qat enabled. When I tried quantization aware training, the model was not learning at all even after 24 hours. So I am currently training without --qat flag and the model is learning, but even after 400k iterations, the model has not learned well. I am using DensePose COCO dataset itself. This is the network I am trying to train configs/s0_bv2_bifpn_f64_s3x.yaml
I am currently training with 2 batch size and LR = 0.0025 and the total_loss value has dropped to 1.8 - 2.0. I am hoping that with more iterations, the model will learn better.
I will not be able to get 4 GPUs for training to test with.

Oh, I see. We perform QAT only to fine tune the trained network. So, I recommend firstly to train non-quantized version of s0_bv2_bifpn_f64_s3x

@zetyquickly thanks for the response.
I was trying to train with --qat enabled. When I tried quantization aware training, the model was not learning at all even after 24 hours. So I am currently training without --qat flag and the model is learning, but even after 400k iterations, the model has not learned well. I am using DensePose COCO dataset itself. This is the network I am trying to train configs/s0_bv2_bifpn_f64_s3x.yaml
I am currently training with 2 batch size and LR = 0.0025 and the total_loss value has dropped to 1.8 - 2.0. I am hoping that with more iterations, the model will learn better.
I will not be able to get 4 GPUs for training to test with.

Oh, I see. We perform QAT only to fine tune the trained network. So, I recommend firstly to train non-quantized version of s0_bv2_bifpn_f64_s3x

Oh ok, then I will do that. Also, could let me know how long it takes normally for the model to learn well with batch_size = 16 and LR = 0.01?
Because, in my case it should take more time than usual because of much lower batch_size and LR.

@zetyquickly thanks for the response.
I was trying to train with --qat enabled. When I tried quantization aware training, the model was not learning at all even after 24 hours. So I am currently training without --qat flag and the model is learning, but even after 400k iterations, the model has not learned well. I am using DensePose COCO dataset itself. This is the network I am trying to train configs/s0_bv2_bifpn_f64_s3x.yaml
I am currently training with 2 batch size and LR = 0.0025 and the total_loss value has dropped to 1.8 - 2.0. I am hoping that with more iterations, the model will learn better.
I will not be able to get 4 GPUs for training to test with.

Oh, I see. We perform QAT only to fine tune the trained network. So, I recommend firstly to train non-quantized version of s0_bv2_bifpn_f64_s3x

Oh ok, then I will do that. Also, could you let me know how long it takes normally for the model to learn well with batch_size = 16 and LR = 0.01?
Because, in my case it should take more time than usual because of much lower batch_size and LR.

I don't remember exactly but on 4-8 GPUs it took less than 8 hours


TileMap Editor is not working correctly

Hi, In Godot v3.2.3, TileMap editor is not working correctly. I can't draw collision shapes. It was working in previous versions.

@rohanrhu Please upload a minimal reproduction project to make this easier to troubleshoot.
Also, can you record a video of the editor when trying to draw collision shapes?

I'll close this issue as no minimal reproduction project was provided in time. This issue can be reopened if someone uploads a minimal reproduction project.

I'll close this issue as no minimal reproduction project was provided in time. This issue can be reopened if someone uploads a minimal reproduction project.


The new consumer can't consume msg from new partition when dynamic extend parition

Describe the bug
The new consumer can't consume msg from new partition when dynamic extend parition
To Reproduce
1.  The pulsar cluster has three brokers;
2.  Created partitioned topic whith three partition;
3.  Run three consumers;
4.  At this time, can see that each consumer consumes a parition;
5.  Use 'pulsar-admin update-partitioned-topic' to dynamic extend partitions to four；
6.  I can see that three consumer consumes four paritions;
7.  Add a new consumer，but the new consumer can't consume msg from new
partition;
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: Centos 7
Additional context
Pulasr 2.5.0
bookkeeper 4.10.0

What is the subscription type are you using?

What is the subscription type are you using?

@sijie failover subscribe

@codelipenghui @jiazhai Can any of you help with this issue?

@DavidLiuXh I try to reproduce the problem follow the steps that you provided, but I can't reproduce it. I have added a unit test #6699 for consumer distribution when partitions update. Please help check if it is consistent with what you described. Thanks.

I also checked this problem before
@ DavidLiuXh's description is not accurate. This should be:
1 Create a Topic with 3 Partitions, and create 3 Consumers
2 Update the number of Partitions to 4
3 Add a new consumer
4 We expect that each consumer consumes one Partition, the reality is that 3 consumers consume 4 Partitions. Occasional discovery
the reason:
In failover mode, the sorting of consumers is based on the name, and the sorting result of the name is not fixed, it should be sorted by consumer id instead.
@codelipenghui

@315157973 Oh, thanks. I will try to fix in #6699

@315157973 Are you using the same consumer name? If you don't provide consumer name, the consumer name is generated by broker, so the case you described shouldn't happen.

@sijie  The automatically generated names are numbers + letters, and the ones generated later may be ranked first. You can reproduce it with a unit test

Suppose there are 3 consumers, and their automatically generated names are: b1, b2, b4.
The consumer lists of the 3 nodes are：
node1： b1、b2、b4
node2： b1、b2、b4
node3： b1、b2、b4
org.apache.pulsar.broker.service.AbstractDispatcherSingleActiveConsumer#pickAndScheduleActiveConsumer
According to line 122
index = partitionIndex % consumersSize;
0 % 3 = 0
1 % 3 = 1
2 % 3 = 2
Partition0 is consumed by b1
Partition1 is consumed by b2
Partition2 is consumed by b4
When increased to 4 nodes, 4 consumers。The fourth consumer's name is b3
The consumer lists of the 4 nodes are：
node1： b1、b2、b3、b4
node2： b1、b2、b3、b4
node3： b1、b2、b3、b4
node4： b3
The consumption relationship becomes as follows：
0 % 4 = 0
1 % 4 = 1
2 % 4 = 2
3 % 1 = 0
Partition0 is consumed by b1
Partition1 is consumed by b2
Partition2 is consumed by b3
Partition3 is consumed by b3
b4 is out of work
Only after the client knows the Partition changes, b4 can enter the work。

So, after the client knows new partition added, b4 eventually takes over the new partition, right?  Are you using java client?

Both are right

Closed as stale. Please create a new issue if it's still relevant to the maintained versions.


Observe component: object resolution

The Observe component on the Observation page needs to be able to resolve celestial bodies, returning data about them. This will work via a text field and button to initiate an API call which interacts with astroquery's simbad sub-package.

Closed by d4da509e15a70062f43ecbbe93d6521b152b7ecd


Move to fedot 0.7.3 and golem 0.3.3

Temporarily fixes problems caused by #71
Going to test all examples with the new version and update requirements if they will be working
Pre-requirement: #68

Complete by #82


[Enhancement]: Add Spectrum Dex

Description

Can we add Spectrum support on dexter
App: https://app.spectrum.fi/cardano_mainnet/

Covered in #63


Fix #22 - Increase recovery codes entropy

Change code generation :

use a larger set of characters, yet still simple to read/enter :
numbers and lower case characters from latin alphabet
(for a total of 36 possible characters)
increase code length, from 10 to 16
continue to split code in groups, separated with dashes

Update unittest accordingly.
Update documentation with details on generated code format
like "mwh1-7mx0-3ly9-9whn"

Looks good, thanks!


Add a section for App Pool Recycle to IIS Documentation

I was surprised to learn that Overlapped Recycle is not implemented for .NET Core applications hosted in IIS. I think it's worth adding that somewhere in this documentation and having a recommendation or fix from Microsoft.
https://github.com/dotnet/aspnetcore/issues/10117

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ec484002-18c1-6a0d-00de-820d56f038d3
Version Independent ID: 7903ce53-2cbb-f083-7479-c8abc30211a0
Content: Host ASP.NET Core on Windows with IIS
Content Source: aspnetcore/host-and-deploy/iis/index.md
Product: aspnet-core
Technology: aspnetcore-hostdeploy
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

The request was to better document the recycle issue, which is a separate issue then deployments. Microsoft should call out that overlapped recycles are not supported and possibly to disable recycles when asp.net core apps are hosted in IIS.


Getting error when start

Mac OS X 10.11.6
node v6.10.3
npm 3.10.10
$ npm start

><EMAIL_ADDRESS>prestart /Users/juggle/webwork/my-proj
> npm run build

><EMAIL_ADDRESS>build /Users/juggle/webwork/my-proj
> tsc -p src/

../../node_modules/@types/lodash/index.d.ts(12847,29): error TS2304: Cannot find name 'object'.
../../node_modules/@types/lodash/index.d.ts(19587,15): error TS2428: All declarations of 'WeakMap' must have identical type parameters.
../../node_modules/@types/lodash/index.d.ts(19587,33): error TS2304: Cannot find name 'object'.

npm ERR! Darwin 15.6.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "run" "build"
npm ERR! node v6.10.3
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>build: `tsc -p src/`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script 'tsc -p src/'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular-quickstart package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     tsc -p src/
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular-quickstart
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular-quickstart
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/juggle/webwork/my-proj/npm-debug.log

npm ERR! Darwin 15.6.0
npm ERR! argv "/usr/local/bin/node" "/usr/local/bin/npm" "start"
npm ERR! node v6.10.3
npm ERR! npm  v3.10.10
npm ERR! code ELIFECYCLE
npm ERR<EMAIL_ADDRESS>prestart: `npm run build`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>prestart script 'npm run build'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular-quickstart package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run build
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular-quickstart
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular-quickstart
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/juggle/webwork/my-proj/npm-debug.log

npm-debug.log
0 info it worked if it ends with ok
1 verbose cli [ '/usr/local/bin/node', '/usr/local/bin/npm', 'start' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
7 verbose lifecycle<EMAIL_ADDRESS>PATH: /usr/local/lib/node_modules/npm/bin/node-gyp-bin:/Users/juggle/webwork/my-proj/node_modules/.bin:/Users/juggle/.cargo/bin:/usr/local/sbin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Users/juggle/Library/Android/sdk:/opt/X11/bin:/usr/local/go/bin:/Users/juggle/Library/Android/sdk/tools:/usr/local/Cellar/yarn/0.16.1/bin
8 verbose lifecycle<EMAIL_ADDRESS>CWD: /Users/juggle/webwork/my-proj
9 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c', 'npm run build' ]
10 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
11 info lifecycle<EMAIL_ADDRESS>Failed to exec prestart script
12 verbose stack Error<EMAIL_ADDRESS>prestart: `npm run build`
12 verbose stack Exit status 1
12 verbose stack     at EventEmitter.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/lifecycle.js:255:16)
12 verbose stack     at emitTwo (events.js:106:13)
12 verbose stack     at EventEmitter.emit (events.js:191:7)
12 verbose stack     at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/spawn.js:40:14)
12 verbose stack     at emitTwo (events.js:106:13)
12 verbose stack     at ChildProcess.emit (events.js:191:7)
12 verbose stack     at maybeClose (internal/child_process.js:886:16)
12 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
13 verbose pkgid<EMAIL_ADDRESS>14 verbose cwd /Users/juggle/webwork/my-proj
15 error Darwin 15.6.0
16 error argv "/usr/local/bin/node" "/usr/local/bin/npm" "start"
17 error node v6.10.3
18 error npm  v3.10.10
19 error code ELIFECYCLE
20 error<EMAIL_ADDRESS>prestart: `npm run build`
20 error Exit status 1
21 error Failed at the<EMAIL_ADDRESS>prestart script 'npm run build'.
21 error Make sure you have the latest version of node.js and npm installed.
21 error If you do, this is most likely a problem with the angular-quickstart package,
21 error not with npm itself.
21 error Tell the author that this fails on your system:
21 error     npm run build
21 error You can get information on how to open an issue for this project with:
21 error     npm bugs angular-quickstart
21 error Or if that isn't available, you can get their info via:
21 error     npm owner ls angular-quickstart
21 error There is likely additional logging output above.
22 verbose exit [ 1, true ]

I am getting the same/similar error with an updated version of npm. It appears that tsc is deprecated? I updated my npm with npm install npm@latest -g
MacOSX: 10.11.6
node: 6.10.3
npm: 4.5.0
$ node -v
v6.10.3
$ npm -v
4.5.0
$ npm install
$ npm start

><EMAIL_ADDRESS>prestart ~/Samples/quickstart/quickstart
> npm run build

><EMAIL_ADDRESS>build ~/Samples/quickstart/quickstart
> tsc -p src/

sh: tsc: command not found
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR<EMAIL_ADDRESS>build: `tsc -p src/`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build script 'tsc -p src/'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular-quickstart package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     tsc -p src/
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular-quickstart
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular-quickstart
npm ERR! There is likely additional logging output above.

npm ERR!  Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>prestart script 'npm run build'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the angular-quickstart package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     npm run build
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs angular-quickstart
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls angular-quickstart
npm ERR! There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     ~/.npm/_logs/2017-05-05T19_12_28_040Z-debug.log

Debug log
0 info it worked if it ends with ok
1 verbose cli [ '/usr/local/bin/node', '/usr/local/bin/npm', 'start' ]
2 info using<EMAIL_ADDRESS>3 info using<EMAIL_ADDRESS>4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info lifecycle<EMAIL_ADDRESS><EMAIL_ADDRESS>6 verbose lifecycle<EMAIL_ADDRESS>unsafe-perm in lifecycle true
7 verbose lifecycle<EMAIL_ADDRESS>PATH: /usr/local/lib/node_modules/npm/bin/node-gyp-bin:/Users/me/Samples/quickstart/quickstart/node_modules/.bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin
8 verbose lifecycle<EMAIL_ADDRESS>CWD: /Users/me/Samples/quickstart/quickstart
9 silly lifecycle<EMAIL_ADDRESS>Args: [ '-c', 'npm run build' ]
10 silly lifecycle<EMAIL_ADDRESS>Returned: code: 1  signal: null
11 info lifecycle<EMAIL_ADDRESS>Failed to exec prestart script
12 verbose stack Error<EMAIL_ADDRESS>prestart: `npm run build`
12 verbose stack Exit status 1
12 verbose stack     at EventEmitter.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/lifecycle.js:279:16)
12 verbose stack     at emitTwo (events.js:106:13)
12 verbose stack     at EventEmitter.emit (events.js:191:7)
12 verbose stack     at ChildProcess.<anonymous> (/usr/local/lib/node_modules/npm/lib/utils/spawn.js:40:14)
12 verbose stack     at emitTwo (events.js:106:13)
12 verbose stack     at ChildProcess.emit (events.js:191:7)
12 verbose stack     at maybeClose (internal/child_process.js:886:16)
12 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:226:5)
13 verbose pkgid<EMAIL_ADDRESS>14 verbose cwd /Users/me/Samples/quickstart/quickstart
15 verbose Darwin 15.6.0
16 verbose argv "/usr/local/bin/node" "/usr/local/bin/npm" "start"
17 verbose node v6.10.3
18 verbose npm  v4.5.0
19 error code ELIFECYCLE
20 error errno 1
21 error<EMAIL_ADDRESS>prestart: `npm run build`
21 error Exit status 1
22 error Failed at the<EMAIL_ADDRESS>prestart script 'npm run build'.
22 error Make sure you have the latest version of node.js and npm installed.
22 error If you do, this is most likely a problem with the angular-quickstart package,
22 error not with npm itself.
22 error Tell the author that this fails on your system:
22 error     npm run build
22 error You can get information on how to open an issue for this project with:
22 error     npm bugs angular-quickstart
22 error Or if that isn't available, you can get their info via:
22 error     npm owner ls angular-quickstart
22 error There is likely additional logging output above.
23 verbose exit [ 1, true ]

I ran this which got me past the tsc error, and onto the next...
npm install typescript -g

This repository is now deprecated. The Angular Quickstart project was a nice starting point for creating Angular applications. Now we recommend using the Angular CLI to create new Angular projects.
Starting from 1 November 2017, all the Angular documentation, at angular.io, is based on the Angular CLI.
Let's get started


[Feature Request] More granular app state

I imagine the following api for the same granularity and modularity of actix-web app state, but statically checked.
This can leverage the current BorrowReq trait.
#[derive(XitcaState)]
struct MyState {
    #[state]
    my_str: String,
    #[state]
    config: PayloadExtractionConfig,
}

impl MyState {
    async fn construct() -> Self {
        todo!()
    }
}

fn main() {
    App::with_async_state(MyState::construct)
        .at("/", get(handler_service(handler)));
}

async fn handler(
    _: Bytes, // Extractor that depends on PayloadExtractConfig
    _: StateRef<'_, String>, // granular state extractor
    _: StateReq<'_, MyState>, // should be possible for backward-compatibility
) {
}

Good idea. What about codegen for FromRequest trait instead?
BorrowReq is a trait I would like to keep at http layer and internal. A generic request type without extra trait is still a goal for now for xitca_http::util::service module.

This is how I imagine the implementation:
impl AsRef<String> for MyState {}
impl AsRef<PayloadConfig> for MyState {}

impl<'r, 'a, S, S2> FromRequest<'a, WebRequest<'r, S>> for StateRef<'a, S2>
where
  S: AsRef<S2>,
{}

It shouldn't touch xitca_http. Indeed it can be implemented with no change to xitca-web either, but I think it's important to standardize a trait for such use case. AsRef looks suitable but it doesn't have the impl impl<T> AsRef<T> for T.

In fact this works. There is a catch though. At least one of the handler have to infer the State type by extract it.
This is problem introduced by the recent change of BuildService trait and I believe the App is failing to infer the State type to the handlers.
// New StateRef implementation.
impl<'a, 'r, S, T> FromRequest<'a, WebRequest<'r, S>> for StateRef<'a, T>
where
    T: 'static,
    S: 'static + Borrow<T>,
{
    type Type<'b> = StateRef<'b, T>;
    type Error = Infallible;
    type Future = impl Future<Output = Result<Self, Self::Error>> where WebRequest<'r, S>: 'a;

    #[inline]
    fn from_request(req: &'a WebRequest<'r, S>) -> Self::Future {
        async move { Ok(StateRef(req.state().borrow())) }
    }
}

// typed state and codegen for borrow fields.
#[derive(Clone, Debug)]
struct State {
    field1: String,
    field2: u32,
}

impl Borrow<String> for State {
    fn borrow(&self) -> &String {
        &self.field1
    }
}

impl Borrow<u32> for State {
    fn borrow(&self) -> &u32 {
        &self.field2
    }
}

// pass state to app.
App::with_current_thread_state(State {
    field1: String::from("state"),
    field2: 996,
})

// extract fields work fine.
    async fn handler(
        StateRef(state): StateRef<'_, String>,
        StateRef(state2): StateRef<'_, u32>,
        req: &WebRequest<'_, State>,
    ) -> String {
        assert_eq!("state", state);
        assert_eq!(&996, state2);
        assert_eq!(state, req.state().field1.as_str());
        state.to_string()
    }

This is how I imagine the implementation:
// desugaring of codegen :
impl AsRef<String> for MyState {}
impl AsRef<PayloadConfig> for MyState {}

impl<'r, 'a, S, S2> FromRequest<'a, WebRequest<'r, S>> for StateRef<'a, S2>
where
  S: AsRef<S2>,
{}

It shouldn't touch xitca_http. Indeed it can be implemented with no change to xitca-web either, but I think it's important to standardize a trait for such use case. AsRef looks suitable but it doesn't have the impl impl<T> AsRef<T> for T.

I don't understand these std borrow traits. AsRef is basically the same as Borrow from what I see. and judging by the StateRef naming it could be better to use AsRef.

I think Borrow is suitable too. AFAIK Borrow just have more restriction regarding the impl of Hash to make it suitable HashTable keys.

Implemented with #208
This issue should remain open as it's still half way for this feature with two questions left:

Where should the macro live? Currently I put it under xitca-http-codegen.
Better handling inside macro. Support tuple/enum/union, generic types, etc.


Error: Trying to get unknown walkthrough: GitHub.copilot#copilotWelcome

Steps:

entirely fresh install
install Copilot
notice how the welcome part opens
quit
start again
notice the error

The consequence of this is that any editor state is lost, including opened editors.
 ERR Error restoring editor grid widget: Error: Trying to get unknown walkthrough: GitHub.copilot#copilotWelcome (with state: {"serializedGrid":{"root":{"type":"branch","data":[{"type":"leaf","data":{"id":0,"editors":[{"id":"workbench.editors.gettingStartedInput","value":"{\"selectedCategory\":\"GitHub.copilot#copilotWelcome\",\"selectedStep\":\"GitHub.copilot#copilotWelcome#copilot.signin\"}"}],"mru":[0]},"size":355},{"type":"leaf","data":{"id":1,"editors":[{"id":"workbench.editors.untitledEditorInput","value":"{\"resourceJSON\":{\"$mid\":1,\"fsPath\":\"Untitled-1\",\"external\":\"untitled:Untitled-1\",\"path\":\"Untitled-1\",\"scheme\":\"untitled\"},\"encoding\":\"utf8\"}"}],"mru":[0]},"size":356}],"size":720},"orientation":0,"width":720,"height":711},"activeGroup":0,"mostRecentActiveGroups":[0,1]}): Error: Error restoring editor grid widget: Error: Trying to get unknown walkthrough: GitHub.copilot#copilotWelcome (with state: {"serializedGrid":{"root":{"type":"branch","data":[{"type":"leaf","data":{"id":0,"editors":[{"id":"workbench.editors.gettingStartedInput","value":"{\"selectedCategory\":\"GitHub.copilot#copilotWelcome\",\"selectedStep\":\"GitHub.copilot#copilotWelcome#copilot.signin\"}"}],"mru":[0]},"size":355},{"type":"leaf","data":{"id":1,"editors":[{"id":"workbench.editors.untitledEditorInput","value":"{\"resourceJSON\":{\"$mid\":1,\"fsPath\":\"Untitled-1\",\"external\":\"untitled:Untitled-1\",\"path\":\"Untitled-1\",\"scheme\":\"untitled\"},\"encoding\":\"utf8\"}"}],"mru":[0]},"size":356}],"size":720},"orientation":0,"width":720,"height":711},"activeGroup":0,"mostRecentActiveGroups":[0,1]})
    at MainEditorPart.doCreateGridControlWithPreviousState (

\closedWith d80bb0d951f5027ebd2602b3169d602ba733d1de


Get Admin/institute pages working

Perhaps the Institute query is causing the problem? I can't see any spelling errors


Use direct line from web page

Hi
I got Direct Line  with secret key setup on my bot, add a new html page and use javascript to send requests, request token get generated fine, conversationId is also returned, post a message with the conversationId got http 204 which also looks good, but when i try to get the messages it always return a empty list, e.g. messages: [], any idea?
I am using V3, however i am not too sure if i need to use Microsoft.Bot.Connector.DirectLine nuget for my case, i am currently referencing it but not actually using it.
thanks

Hi @mayuanyang, sorry to hear you're having trouble. You're following the correct approach for posting messages to the DirectLine channel and then getting them. You are not required to use the Nuget package; you can call from either service code or Javascript (or any other code) and as long as you adhere to the HTTP Direct Line protocol, everything should work.
If you can send me a bot ID or conversation ID, I can take a look at the metadata to see whether messages were posted.

hi, @dandriscoll,  I have made a directline api library for node.js.
https://www.npmjs.com/package/directline-api
But it is not friendly to use. It is a bit complicated, the POST API get nothing, and should write another method to retrieve and parse the messages in GET API. Is there any plan to enhance it? Such as just return the reply in POST API?

Hi @dandriscoll
The app Id is 1b3e574b-8aab-437c-a7d9-5f8b52469c02
I am using AngularJS 1.5 as the client, here are my client side code
`getRequestToken() {
    return this.$http.get('https://directline.botframework.com/api/tokens');
}

startConversation() {
    return this.$http.post('https://directline.botframework.com/api/conversations', '');

}

postMessage() {

    return this.$http({
        method: 'POST',
        url: 'https://directline.botframework.com/api/conversations/'+ this.conversationId + '/messages',

        data: { message: {
            "id": "string",
            "conversationId": this.conversationId,
            "created": "2016-07-17T11:02:01.374Z",
            "from": "test",
            "text": "get account for<PHONE_NUMBER>8",
            "channelData": {},
            "images": [],
            "attachments": [],
            "eTag": ""
        } }
    });
}

getMessages() {
    this.$http.get('https://directline.botframework.com/api/conversations/' + this.conversationId + '/messages')
        .success(data => {
            console.log(data);
        });

}

and here is the server side code  public async Task Post([FromBody]Activity message)
{
try
{
            var serviceUri = new Uri(message.ServiceUrl);
            var connector = new ConnectorClient(serviceUri);

            if (message.Type.ToUpper() == "MESSAGE")
            {
                var msg = message.CreateReply("Message received");
                await connector.Conversations.SendToConversationAsync(msg);

                var luis = await _engine.ProcessMessage(message);

                if (luis.intents[0].intent == "GetAccountInfo")
                {
                    if (luis.entities.Length > 0)
                    {

                        var account = _accRepository.SingleOrDefault(x => x.AccountId == luis.entities[0].entity);
                        msg.Attachments = new List<Attachment>();
                        msg.Attachments.Add(new Attachment("application/json", "", account));
                        await connector.Conversations.SendToConversationAsync(msg);

                    }
                    else
                    {
                        await connector.Conversations.SendToConversationAsync(msg);
                    }

                }
                if (luis.intents[0].intent == "GetPayments")
                {
                    if (luis.entities.Length > 0)
                    {

                        //var stateClient = message.GetStateClient();
                        //var userData = await stateClient.BotState.GetUserDataAsync(message.ChannelId, message.From.Id);
                        //userData.SetProperty("Data", account);
                        //await stateClient.BotState.SetUserDataAsync(message.ChannelId, message.From.Id, userData);
                        var payments = _txRepository.Where(x => x.AccountId == luis.entities[0].entity).ToList();
                        msg =
                            message.CreateReply(
                                $"The intent is {luis.intents[0].intent} and entity is {luis.entities[0].entity}");
                        msg.Attachments = new List<Attachment>();
                        msg.Attachments.Add(new Attachment("application/json", "", payments));

                        await connector.Conversations.SendToConversationAsync(msg);
                    }
                    else
                    {
                        msg = message.CreateReply("Transaction not found");
                        await connector.Conversations.SendToConversationAsync(msg);
                    }
                }
                if (luis.intents[0].intent == "AddPayment")
                {
                    await connector.Conversations.SendToConversationAsync(message.CreateReply($"The intent is {luis.intents[0].intent} and entity is {luis.entities[0].entity}"));
                }

            }
            else
            {
                await connector.Conversations.SendToConversationAsync(HandleSystemMessage(message));
            }

        }
        catch (Exception ex)
        {
            _logger.Error(ex, "An error has occured");
            //throw;

        }
    }

`

The message contract from the document is a bit confused, i manage to get it working by just sending the "text" property in the post data


kdeconnect: 1.3.1 -> 1.3.3

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/kdeconnect/versions.
meta.description for kdeconnect is: '"KDE Connect provides several features to integrate your phone and your computer"'.

Checks done (click to expand)

built on NixOS
/nix/store/h54sxhl1cqvy5b3nq73jscpiljyiisjv-kdeconnect-1.3.3/bin/kdeconnect-cli passed the binary check.
Warning: no invocation of /nix/store/h54sxhl1cqvy5b3nq73jscpiljyiisjv-kdeconnect-1.3.3/bin/kdeconnect-indicator had a zero exit code or showed the expected version
Warning: no invocation of /nix/store/h54sxhl1cqvy5b3nq73jscpiljyiisjv-kdeconnect-1.3.3/bin/kdeconnect-handler had a zero exit code or showed the expected version
1 of 3 passed binary check by having a zero exit code.
1 of 3 passed binary check by having the new version present in output.
found 1.3.3 with grep in /nix/store/h54sxhl1cqvy5b3nq73jscpiljyiisjv-kdeconnect-1.3.3
directory tree listing: https://gist.github.com/518c40857ffb3d3862940554d8755fff
du listing: https://gist.github.com/2277b3ed8eb10b0ec45b457b141dc577

Outpath report (click to expand)

Outpath difference report
1 total rebuild paths
1 package rebuilds
1 x86_64-linux rebuilds
0 i686-linux rebuilds
0 x86_64-darwin rebuilds
0 aarch64-linux rebuilds
First ten rebuilds by attrpath
kdeconnect

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/h54sxhl1cqvy5b3nq73jscpiljyiisjv-kdeconnect-1.3.3 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
Or, build yourself:
nix-build -A kdeconnect https://github.com/r-ryantm/nixpkgs/archive/efbc6f4648d4452d206a4c4205d30600f0cc35c1.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/h54sxhl1cqvy5b3nq73jscpiljyiisjv-kdeconnect-1.3.3
ls -la /nix/store/h54sxhl1cqvy5b3nq73jscpiljyiisjv-kdeconnect-1.3.3/bin

cc @fridh for testing.

No attempt on x86_64-darwin (full log)
The following builds were skipped because they don't evaluate on x86_64-darwin: kdeconnect
Partial log (click to expand)

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Success on aarch64-linux (full log)
Attempted: kdeconnect
Partial log (click to expand)
/nix/store/g0cc5nsbkwiyw3cdfvc1dk2nxqqnjahv-kdeconnect-1.3.3

Success on x86_64-linux (full log)
Attempted: kdeconnect
Partial log (click to expand)
/nix/store/0w545cgi9lbrywhxl661a84aba5jkzvr-kdeconnect-1.3.3