🐛 Generator hangs when used to generate a sample from limited range

I'm trying to use the Generator class to generate an int value from a specified range. But it seems that if the range is limited and I ask the class to generate the value many times it will hang at some point.
Code sample
var fixture = new Fixture();
var generator = new Generator<int>(fixture);
for (var i = 0; i < 1000; i++) {
  var sample = generator.First(x => x >= 0 && x <= 3); // This will hang at some point
}

Expected Behavior
I would expect that the above code should generate a valid sample 1000 times, even if it repeats the outcome.
Is this a bug or intended way of working? Does it track the generated samples and not return it anymore?

@pogosama the generator is working as intended and it is generating random values.
The problem in your example is you are setting a condition that is very unlikely to ever occur, since the numbers generated are in the range of hundreds and  you are expecting a value between 0 and 3.
The intended use of the Generator<T> was to create sequences of data from a builder that's already customized according to the requirements.
var generator = new Generator<int>(fixure);
var sequence1 = generator.Take(10).ToList();
var sequence2 = generator.Take(17).ToList();

If you want to constrain the Generator you should either customize the Fixture or implement your own generator/specimen builder.
class MyConstrainedNumberGenerator : IEnumerable<int>
{
    private readonly ISpecimenBuilder builder;
    private RangedNumberRequest request;

    public MyConstrainedNumberGenerator(int min, int max, ISpecimenBuilder builder)
    {
        this.builder = builder;
        this.request = new RangedNumberRequest(typeof(int), min, max);
    }

    public IEnumerator<int> GetEnumerator()
    {
        var context = new SpecimenContext(this.builder);
        while(true)
        {
            yield return (int)context.Resolve(request);
        }
    }

    IEnumerator IEnumerable.GetEnumerator() => GetEnumerator();
}

[Fact]
public void Foo()
{
    var fixture = new Fixture();
    var generator = new MyConstrainedNumberGenerator(0, 3, fixture);
    for (var i = 0; i < 1000; i++)
    {
        var sample = generator.First(x => x >= 0 && x <= 3); // This will hang at some point
    }
}

ok, thanks for the explanation!


ActivePopupWindow reference update

Hi,
just a small improvement idea.
The line of code below should be within PopupWindow Show(), not within Control implementing PopupWindow.
https://github.com/modern-forms/Modern.Forms/blob/504a7bf6c7747a2ec7709c657b226a59e75b8187/src/Modern.Forms/ComboBox.cs#L83
(PopupWindow) What we have now:
https://github.com/modern-forms/Modern.Forms/blob/504a7bf6c7747a2ec7709c657b226a59e75b8187/src/Modern.Forms/PopupWindow.cs#L41-L56
(PopupWindow) We should change into:

Reason:
Not possible to (properly) use PopupWindow as a standalone control (ApplicApplication.ActivePopupWindow is internal).
PopupWindow should be responsible to change ActivePopupWindow reference, not the control implementing it.

I run into specific problem with popup windows.
Let me study this in more detail, then I reopen this issue.


Atrac fix attempt

See #898 and #908
Not sure if it is the correct way to handle it or even if this change is correct but it just an attempt ;)

Is fine.
Any idea about the difference between the 2 UUID (per format)?

Any idea about the difference between the 2 UUID (per format)?

Argh, actually my mistake, there is only one UUID, the older one is an UUID with inverted bytes, a mistake on my side and I fixed it some time ago (and I missed that the UUID is somewhere else, so the bug)

Yes, the value has changed in MediaInfo somewhere after 7.99

It is why i wasn't sure what way was correct to fix it.


Gnome 43 support

Hello! Thank you for that great and useful tool! Any plans to support Gnome 43?

updated


Advanced coloring pt 1.1

Allow color picker to initialize properly when given a 0-opacity "color"
Move the color picker tooltip to the right when it's on the left of the screen
run the linter

LGTM!


Feat: Adding Contributors page

Describe the feature
I can add the option to navigate contributor page.
I will show the github profile of all the contributors worked for the project.
I will ensure to make the page UI similar to the theme and also responsive for all screens.
It will directly fetch the data from the repository.
It will show,
Transparency: It shows transparency in the project's development and highlights the collaborative effort behind it.
Engagement: It helps build a community by encouraging more people to contribute and get involved.
Networking: It provides an opportunity for users to connect with contributors, potentially leading to more collaboration and support.
Add ScreenShots
N/A
Record

[X] I agree to follow this project's Code of Conduct
[X] I have starred the repository
[X] I'm a gssoc-24-extd contributor
[X] I want to work on this issue

duplicate


Fix #9476: Support native TLS on Mac OS X

This currently only works on 64bit. I created this PR anyway to get some code review for the changes.
For 32bit, there are three options, see discussions as well [1] [2]:

Drop it completely
Continue using emulate TLS
Implement a working native TLS. I'm suspecting there just some issue with how the instructions are generate for accessing a TLS variable that causes a segmentation fault. Otherwise both 32 and 64bit uses the same implementation

Runtime part: https://github.com/D-Programming-Language/druntime/pull/1461.
[1]<EMAIL_ADDRESS>[2]<EMAIL_ADDRESS>

Why are the FreeBSD and Windows tests looking for lexer.h and parser.h?

Out of date make rules

Ah, but they don't cause the build to fail.

Added back emulate TLS for 32bit.

ping @WalterBright @yebblies @klickverbot @smolt

Seems like the AA test case still fails on the auto tester – wasn't that the one you asked me about on the LDC mailing list?

Yes. I'll have a look.

Also be aware of ldc-developers/ldc#1252, just in case.

Ok, thanks.

@klickverbot I'm pretty sure it's because the druntime PR is not merged. All tests pass for me locally when including the necessary changes for druntime. If I use druntime master I get the same error as the auto tester gets.

@jacob-carlborg I'll take a look this weekend, my week got full already.

@smolt thanks, no rush :smiley:

I fetched both dmd and druntime native_tls branches and all is fine here for 64-bit with OS X 10.10.5 and Xcode 7.2.  Passes druntime, phobos, and dmd test suite.
The assembly looks correct for OS X thread local access, although I suppose since tests passed, all I did was verify that it is truly using OS X thread local support.
As @klickverbot brought up issue ldc-developers/ldc#1252, I checked into it with this program.
// file tls_faild.d
import core.stdc.stdio;

byte tb = 42;   // __thread_data
real zb16 = void; // __thread_bss 16-byte aligned

void main()
{
    printf("zb16 %p\n", &zb16);
    // zb16 addr is only 8-byte aligned, should be 16-byte
}

dmd tls_faild.d -c
$ otool -l tls_faild.o | sed -n '/__thread/,/align/ p'
  sectname __thread_data
   segname __DATA
      addr 0x00000000000000f0
      size 0x0000000000000001
    offset 1168
     align 2^3 (8)
(snip)
  sectname __thread_bss
   segname __DATA
      addr 0x0000000000000130
      size 0x0000000000000010
    offset 1232
     align 2^4 (16)
$ dmd tls_faild.d
$ ./tls_faild
zb16 0x7ffce9d00088

See how real zb16 in __thread_bss should be 16-byte aligned?  But printf of address is only 8-byte aligned.  A work around is making __thread_data always 16-byte aligned.  I see here you make it 8-byte aligned: https://github.com/D-Programming-Language/dmd/pull/5346/files#diff-5a9efaa0acd4f1f9e19b7c6b3f667170R1921.  Making it 16-byte aligned (change 3 to 4) works as long as there is at least one var in __thread_data section.  LDC's workaround was a var with 16-byte alignment in druntime, but it doesn't work verbatim.  It seems LDC honors align() for non-structs, but dmd doesn't?

See how real zb16 in __thread_bss should be 16-byte aligned? But printf of address is only 8-byte aligned. A work around is making __thread_data always 16-byte aligned.

@smolt not sure I understand. Should I change the alignment of __thread_data to get the correct alignment for __thread_bss?
I looks like Clang is using the alignment of the largest variable in the section, for both  __thread_data and __thread_bss. I'm not sure what's correct.

Without the OS X linker bug, doing what clang is doing is best (align section to maximum member alignment).  I was being general, saying a workaround for the linker alignment bug is to make sure __thread_data has 16-byte alignment.   You have choices of how to implement it in dmd because you are working in the backend too.
For LDC, it was easiest to declare a thread-local variable with 16-byte alignment:
https://github.com/ldc-developers/druntime/blob/ldc/src/rt/sections_ldc.d#L410
although when I tried align like that in dmd, it didn't seem to have an effect.
Whatever the workaround, I have a radar bug filed with Apple, and will update ldc-developers/ldc#1252 when I get feedback so the workaround can be lifted someday.

Without the OS X linker bug, doing what clang is doing is best (align section to maximum member alignment). I was being general, saying a workaround for the linker alignment bug is to make sure __thread_data has 16-byte alignment. You have choices of how to implement it in dmd because you are working in the backend too.

Now I'm confused. Should __thread_data, __thread_bss or both have 16-byte alignment?

Sorry for confusion.  Section __thread_data needs to be forced to 16-byte alignment (this is the workaround).  Section __thread_bss alignment only needs to be its max aligned variable.

@smolt fixed. Also rebased.

@WalterBright ping. @andralex this is a prerequisite for dynamic libraries on OS X which, IIRC, you've been asking for.

@jacob-carlborg looks good.  BTW, I located half of the alignment bug in dyld source code.  The following allocation of thread local block (buffer) in tlv_allocate_and_initialize_for_key() assumes that start is 16-byte aligned in image. When it isn't, data is shifted.
https://www.opensource.apple.com/source/dyld/dyld-360.18/src/threadLocalVariables.c
	// allocate buffer and fill with template
	void* buffer = malloc(size);
	memcpy(buffer, start, size);

I haven't heard back from Apple yet on bug I filed.  I assume they will fix it in ld64

ping @WalterBright  @9rnsr @yebblies

can we get an ETA for review/merge on this?

@MartinNowak ping

@WalterBright @yebblies @9rnsr ping

@andralex ping. I would like to add that this is a perquisite for dynamic libraries that you've been asking for.

Where you have an assert(0); in the c++ code you also need a return NULL or something to avoid spurious warnings.
Apart from that it looks good (from my limited understanding of this part of the compiler), but I think it really needs @WalterBright's review before merging.  Let's  say if Walter hasn't had a chance to review in the next week I'll merge and see what happens.

Where you have an assert(0); in the c++ code you also need a return NULL or something to avoid spurious warnings.

I'll update the code.

Let's say if Walter hasn't had a chance to review in the next week I'll merge and see what happens.

Ok, fair enough. @yebblies have you looked at the runtime part as well? https://github.com/D-Programming-Language/druntime/pull/1461

Updated.

@yebblies one week later, I see no indication of any form of new review.

Ok then.  We can always revert if anything goes wrong.

And there we go, reverted.

Do you have any reference to what failed? Is it this: https://auto-tester.puremagic.com/show-run.ghtml?projectid=1&runid=102572&dataid=709075 ?

@yebblies (see previous post, explicitly pinging to be sure)

Yeah


[ISSUE-707] volume release label

Purpose
Resolves #707
Port changes with setting volume release label from release-1.0 branch to master
PR checklist

[ ] Add link to the issue
[ ] Choose Project
[ ] Choose PR label
[ ] New unit tests added
[ ] Modified code has meaningful comments
[ ] All TODOs are linked with the issues
[ ] All comments are resolved

Testing
CI in progress

/ci


lib/fetch-{libc++,newlib}: exit on error

This helps diagnose issues when one or more of the tools that the script requires are not installed.
In my case, I was working on a system that did not have unzip installed. This error message was hidden in between a lot of other log messages, and the error was masked by a generic "can't find this header" message.
This also removes the let bindings. The bash let commands returns exit code 1 when assigning the value 0 to a variable, which is ... 100% what you want, just great behavior, and definitely did not cost me another 10 minutes to debug.

Seems like we were relying on failures being silently ignored in CI:
2024-11-14T20:33:32.5126662Z 293100K .......... .......... ...                             100%  195M=8.0s
2024-11-14T20:33:32.5127237Z
2024-11-14T20:33:32.5128455Z 2024-11-14 20:33:32 (35.9 MB/s) - ‘libtock-newlib-<IP_ADDRESS>11231.zip’ saved [300158324/300158324]
2024-11-14T20:33:32.5129275Z
2024-11-14T20:33:33.2008185Z libtock-newlib-<IP_ADDRESS>11231.zip: OK
2024-11-14T20:33:33.2016379Z Unpacking libtock-newlib-<IP_ADDRESS>11231.zip...
2024-11-14T20:33:33.7019460Z libtock-newlib-<IP_ADDRESS>11231.zip: OK
2024-11-14T20:33:33.7028612Z Unpacking libtock-newlib-<IP_ADDRESS>11231.zip...
2024-11-14T20:33:33.7049070Z replace libtock-newlib-<IP_ADDRESS>11231/arm/arm-none-eabi/include/argz.h? [y]es, [n]o, [A]ll, [N]one, [r]ename:  NULL
2024-11-14T20:33:33.7050216Z (EOF or read error, treating as "[N]one" ...)
2024-11-14T20:33:33.7196157Z replace libtock-newlib-<IP_ADDRESS>11231/arm/arm-none-eabi/lib/thumb/v7ve+simd/softfp/redboot.specs? [y]es, [n]o, [A]ll, [N]one, [r]ename:  NULL
2024-11-14T20:33:33.7197691Z (EOF or read error, treating as "[N]one" ...)
2024-11-14T20:33:37.7497198Z make[1]: *** [../Precompiled.mk:61: ../lib/libtock-newlib-<IP_ADDRESS>11231/arm/arm-none-eabi/lib/thumb/v6-m/nofp/libc.a] Error 1
2024-11-14T20:33:37.7498747Z make[1]: Leaving directory '/home/runner/work/libtock-c/libtock-c/lvgl'
2024-11-14T20:33:37.7502329Z make: *** [../../AppMakefile.mk:97: ../../lvgl/build/cortex-m0/lvgl.a] Error 2

I'll push a commit that changes the invocation of unzip to select the (currently inferred) default of not overwriting existing files.

Oof. Or... it's not an error for another day. Looks like the CI error is competing unzip's trampling each other, likely because the first unzip was only partially complete when the second one first checked if it needed to do anything :/


Feature: Add embed button to dev card page to copy/paste markdown

Suggested solution
On the dev card page, we have share buttons for X and LinkedIn. This would add an "embed" button you could click to copy/paste some markdown to put into your GitHub profile.

Discussed with @nickytonline and he mentioned that there may be issues with the image being refreshed if embedded with GitHub markdown. We're adding the copy/paste button to the DevCard, but may be a larger effort to have an image that refreshes periodically.


Add a quick start section to docs

Codecov Report

Merging #8 (764db70) into main (57cfd43) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage   76.74%   76.74%
=======================================
  Files          52       52
  Lines        1853     1853
=======================================
  Hits         1422     1422
  Misses        359      359
  Partials       72       72

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57cfd43...764db70. Read the comment docs.


[PE-D][Tester D] Schedule multiple clients with same date time

What Happened:
After entering schedule 1 d/2024-07-08 07:30 followed by schedule 2 d/2024-07-08 07:30,
I realised that I can schedule multiple clients with same date time:

Suggestion:
It would be better to prevent scheduling multiple clients with the same date and time.

Labels: severity.Medium type.FeatureFlaw
original: ziyi22/ped#2

Duplicate with #130


Alternative to modal window

[!IMPORTANT]
Read issue #1 first

I attach some videos to give a graphic idea of what I want to try to do.
It doesn't have to be exactly the same, but something close.
The vertical displacement with the click is optional.
https://github.com/user-attachments/assets/f58ae956-2370-40d4-b23f-af717e000707
https://github.com/user-attachments/assets/d47292a0-dd70-4c1e-8a3b-3ef2d666d59c

Assign me this issue.

PR sent already. Please check.

As stated in issue #1

Each issue noted with hacktoberfest must be completed within a week and you can only do one per week, this is to give more participants a chance. ...

It's okay that you were not able to complete it, I appreciate your effort and interest.


How to query a historical snapshot?

Hi, sorry if this question outside the issues scope but I will appreciate your help as I could not find answers elesewhere. I used this project to run the Google safe browsing DB and make queries locally using Ubunutu. My terminal shows me lines of updates such as:

 safebrowsing: 2019/06/28 12:01:09 database.go:111: no database file specified
safebrowsing: 2019/06/28 12:01:10 database.go:243: Server requested next update in 30m24.304s
safebrowsing: 2019/06/28 12:01:11 database.go:389: database is now healthy
safebrowsing: 2019/06/28 12:01:11 safebrowser.go:557: Next update in 30m24.304s
Starting server at localhost:8080

I assume that the DB automatically receive updates. Plz correct me if I'm wrong and if I need to do anything to keep it up to date.
The second issue, if I use this project, can I get a snapshot of older specific date? e.g. the DB two months ago? Plz let me know if there is anyway to query the DB on old date.

Yes, it will automatically get updates, approximately every 30 minutes.
For historical snapshots, you could modify the code to save each update to a different file, then analyze them later. An important note is that the 'db' only contains hash prefixes (not full url hashes), so you might see a match on the prefix, but verification involves sending that prefix to the server, to get the full hash (and finally matching your local full hash with the one retrieved from the server).
The responses from the server are only for things that are 'current' in the blacklist (If you query an old hash prefix that is no longer blacklisted, you will not get the full hash back). This drastically limits the use of keeping old DBs around, as you can't be sure if there was an actual match, or just a hash-prefix collision.
The server also does not provide for querying for older dbs. It does keep some amount of older state in order to efficiently update clients by supplying just the minimum additions/deletions to get the client to the latest DB version, but that is all.


Error in proposal generation.

When I use mask2former_learn_prompt_bs16_10k.yaml to get proposal classification, i got an error "RuntimeError: The size of tensor a (211) must match the size of tensor b (197) at non-singleton dimension 1". I checked the size is (224, 244), but the position embedding is (197, n_dim). Is the predefined size wrong?

Logically, there will be no problem of predefined size errors. You can provide the specific code location where the error is reported to facilitate locating the problem.


Comments not respected in package.json

Package ecosystem
npm
Package manager version
yarn 1.22.10
Language version
N/A
Manifest location and content prior to update
/frontend/package.json:
{
  "name": "lilium",
  "scripts": {
    "dev": "nuxt",
    "build": "nuxt build",
    "generate": "nuxt generate --spa",
    "start": "nuxt start",
    "lint": "eslint --ext .ts,.js,.vue --fix ."
  },
  "dependencies": {
    "//": "TODO: figure out why these can't be dev deps.",
    "@nuxt/typescript-build": "^2.1.0",
    "@nuxtjs/tailwindcss": "^4.2.0",
    "nuxt": "^2.15.7"
  },
  "devDependencies": {
    "@nuxt/types": "^2.15.7",
    "@nuxtjs/eslint-config-typescript": "^6.0.1",
    "eslint": "^7.30.0"
  }
}

dependabot.yml content
version: 2
updates:
  - package-ecosystem: "npm"
    directory: "/frontend"
    schedule:
      interval: "daily"

Updated dependency
not very applicable
What you expected to see, versus what you actually saw
in the logs, I see:
updater | INFO <job_168806843> Checking if //  needs updating
  proxy | 2021/07/04 04:02:31 [026] GET https://registry.npmjs.org:443/%2F%2F
  proxy | 2021/07/04 04:02:35 [026] 404 https://registry.npmjs.org:443/%2F%2F
updater | INFO <job_168806843> Latest version is
updater | I, [2021-07-04T04:02:35.200020 #7]  INFO -- sentry: ** [Raven] Sending event 4c3905af167a44ee80770592d8404fa4 to Sentry
  proxy | 2021/07/04 04:02:35 [028] POST https://sentry.io:443/api/1451818/store/
  proxy | 2021/07/04 04:02:35 [028] 200 https://sentry.io:443/api/1451818/store/
updater | ERROR <job_168806843> Error processing // (Gem::Requirement::BadRequirementError)
updater | ERROR <job_168806843> Illformed requirement ["TODO: figure"]

basically, dependabot is checking the version of a json comment.
Native package manager behavior
as far as I can tell, yarn simply ignores the json comment
🕹 Bonus points: Smallest manifest that reproduces the issue
I think the error makes it pretty clear what reproduces this issue :^)

It doesn't look like this is a comment so much as a dependency named // being used as a "comment" because package.json doesn't support comments, is that right? I assume when you run yarn, it will try to fetch // and ignore it when it cant find it.
In general, I don't think we're going to change the behavior of special casing package names to not check for them (e.g., we won't change dependabot to ignore all future packages named "//"); it feels like the right answer here is to track those comments elsewhere (e.g. in an issue) or get the npm/yarn teams to support jsonc in package.json so it can be an actual comment, not a package named //.

I have been pointed to https://github.com/npm/feedback/discussions/56, which would allow for comments in package.json, where they discuss // as a workaround. I admit that I find it icky, but given that actual comments aren't coming for a while, I don't have other solutions beyond tracking it elsewhere (or doing something like a comments object).
I would need to think about how Dependabot should handle cases like this, since ideally we'd just hand it off to npm or yarn and they would handle this appropriately (likely just ignoring it if they know they can't update it), but since we do the file parsing ourselves, that's why we're running into this.

It might be that yarn tries fetching it and ignores it, I'm not sure (ctrl+f "//" in yarn install's --verbose mode didn't find anything). This isn't too important of a feature for me (as I can put the comment in another file) though, so I'd be fine even if this isn't fixed, just bringing this to your attention.

@A5rocks you're right, looks like yarn v1 ignores dependencies with key // but npm raises a EINVALIDPACKAGENAME error. I don't think it makes sense to fix this in dependabot as it's only supported in yarn v1.


chore(rspack): update federation runtime

Summary

Updating Module Federation runtime tools

Checklist

[ ] Tests updated (or not required).
[ ] Documentation updated (or not required).

@ScriptedAlchemy Hi, our docs about ModuleFederationPlugin  is outdata. can you help us to improve the doc. https://www.rspack.dev/plugins/webpack/module-federation-plugin

Updated in https://github.com/web-infra-dev/rspack/pull/7025


update material to alpha.9

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature branch update

What is the current behavior? (You can also link to an open issue here)
material branch has fallen behind master and is out of date with current material alpha version

What is the new behavior (if this is a feature change)?
update material branch to include latest changes to master and to material alpha.9

Other information:

please merge this :)

I don't think this should be merge. There is some much files that changes outside of the described scope. The update needs to be done, but I guess that this need only the really necessary files to be updated.

@michaeljota the changes not related to material are to bring the branch up to date with the master branch. with that said, this pr is probably out of date by now as there have been more changes made to the master branch

That's what I mean. You probably should fork, and create a branch, make changes in that branch, and push the changes. If you want to pull changes from here, you should upstream it. However, you should always rebase your code on top of the pulls you have to make.


[HealthInsights] Update OncoPhenotype documentation and sample code

Contributing to the Azure SDK
Updating documentation links as they currently point to review.learn links that are inaccessible to external customers. Also updating sample code with removed patient info
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.

API change check
API changes are not detected in this pull request.

@psanapathi
After changing samples, please run .\eng\scripts\Update-Snippets.ps1
this will update the snippets in the samples\readme.md files.

@asaflevi-ms I updated the samples manually as the script wasn't fully working for me


Add .gitattributes file.

More info: https://git-scm.com/docs/gitattributes

OK. I removed all (all but *.sh) EOL specifications from both .editorconfig and .gitattributes. I know that Git can (and usually does) automatically convert EOL formats when checking out files, so I don't want to have these files causing problems for developers by changing EOL styles post checkout.
I do still have the odd EOL conflict when I develop locally because I checkout to Windows (CRLF), but then open WSL and operate on the same directory, but with an environment that is native LF. If I see a way to improve this then I will follow-up with another PR.

Thanks!

I do still have the odd EOL conflict when I develop locally because I checkout to Windows (CRLF), but then open WSL and operate on the same directory, but with an environment that is native LF. If I see a way to improve this then I will follow-up with another PR.

Ah, it's really an odd situation. But as you mentioned, I also think that git it usually smart enough to handle the line endings.


Ensure catch breath doesn't result in negative anima

Simple fix for #8

Sorry i had the fix ready but forgot to deploy it, PR is redundant now


Allow for return type signature in @qjit methods

Context: Methods with return type signatures are not compiled.
Description of the Change: At the moment, ignore the return type signature as it is computed by JAX.
Benefits: More valid python code is able to be compiled.
Possible Drawbacks: It would be nice to incorporate return type signature to the warning message if the detected return type is not the same as the one specified by the user. But we can leave this to the next PR.
Related GitHub Issues: Fixes #750

Possible Drawbacks: It would be nice to incorporate return type signature to the warning message if the detected return type is not the same as the one specified by the user.
But rather, leave this to a user running static type analysis tools like mypy

@josh146 alright! I haven't incorporated the warning nor any checking in this PR. This PR only makes it so that if a function is annotated with a return type signature, the function can still be compiled. Without this PR, we have an error when the function has a return type signature.


Update package.json

Purpose

...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type
What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check
Verify that the following are valid

...

Other Information

Hi, I was wondering what version of node are you running when you are building. Prior to release I was trying to investigate this problem and I found that running on a more recent version of node (12.13.0) seemed to work better than having alot of memory. This could be related to better garbage collection strategies in later versions of node @magnoeasy

v10.16.3
On Mon, Nov 16, 2020 at 12:20 PM Alex Kwan<EMAIL_ADDRESS>wrote:

Hi, I was wondering what version of node are you running when you are
building. Prior to release I was trying to investigate this problem and I
found that running on a more recent version of node (12.13.0) seemed to
work better than having alot of memory. This could be related to better
garbage collection strategies in later versions of node @magnoeasy
https://github.com/magnoeasy
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Azure-Samples/communication-services-web-calling-hero/pull/5#issuecomment-728205235,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARVFCLDAQECRBS22ZDLPBTSQFNONANCNFSM4TVGZ4IA
.

Hi @magnoeasy I was wondering if you can upgrade your version of node? In the readme it looks like we are supporting node 12 and later

For sure, I didn't realize at first that was a problem with the node
version.
On Tue, Nov 17, 2020 at 1:56 PM Alex Kwan<EMAIL_ADDRESS>wrote:

Hi @magnoeasy https://github.com/magnoeasy I was wondering if you can
upgrade your version of node? In the readme it looks like we are supporting
node 12 and later
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Azure-Samples/communication-services-web-calling-hero/pull/5#issuecomment-729132549,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARVFCJ67RI6UURCWXOKLL3SQLBMNANCNFSM4TVGZ4IA
.

Yeah its just an improvement on the garbage collection rather than any critical new features. Please reply back if it work or it didn't work. I would love to be able to help you further if we are still running into issues or be able to close this if your good to go!

I updated to Node version 15 and solved the problem.
On Tue, Nov 17, 2020 at 2:57 PM Alex Kwan<EMAIL_ADDRESS>wrote:

Yeah its just an improvement on the garbage collection rather than any
critical new features. Please reply back if it work or it didn't work. I
would love to be able to help you further if we are still running into
issues or be able to close this if your good to go!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Azure-Samples/communication-services-web-calling-hero/pull/5#issuecomment-729167026,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AARVFCOZTUI2IBDWA5ANWWDSQLIULANCNFSM4TVGZ4IA
.

Just in case anyone is reading this. We are closing this because the answer is updating the version of node to match what is stated in the readme as opposed to allocating additional memory for the node process!


Fast path for varint read.

clickhouse-benchmark <<< 'select count() from s where not ignore(s);'
before this patch:

QPS: 0.732, RPS:<PHONE_NUMBER>.608, MiB/s: 22378.560, result RPS: 0.732, result MiB/s: 0.000.
0.000%  1.310 sec.
10.000% 1.321 sec.
20.000% 1.327 sec.
30.000% 1.337 sec.
40.000% 1.343 sec.
50.000% 1.359 sec.
60.000% 1.366 sec.
70.000% 1.381 sec.
80.000% 1.400 sec.
90.000% 1.434 sec.
95.000% 1.448 sec.
99.000% 1.489 sec.
99.900% 1.499 sec.
99.990% 1.500 sec.

after this patch:
QPS: 0.787, RPS:<PHONE_NUMBER>.064, MiB/s: 24076.084, result RPS: 0.787, result MiB/s: 0.000.
0.000%  1.228 sec.
10.000% 1.232 sec.
20.000% 1.235 sec.
30.000% 1.241 sec.
40.000% 1.246 sec.
50.000% 1.256 sec.
60.000% 1.265 sec.
70.000% 1.278 sec.
80.000% 1.296 sec.
90.000% 1.321 sec.
95.000% 1.354 sec.
99.000% 1.421 sec.
99.900% 1.453 sec.
99.990% 1.456 sec.

I also tried an SSE2 implementation and it's much slower (50%)
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Great, thank you!


Freezes when creating a new file while sidebar closed

Issue Type: Bug

Have sidebar closed
Create a new file with the shortcut, CTRL+N
It opens the sidebar, but empty
It freezes and then, after a few seconds, comes up with the option to reload the window

I can't reproduce it on WSL2, which runs off my SSD.
In the past, I've noticed it takes a while for a file to save to my HDD, likely due to Windows turning it off after a period of inactivity. However, I've never had VS Code crash before.

I guess you have a custom shortcut to create a new file, since Ctrl + N by default would just open an untitle file and that does not open the sidebar.
Can you reproduce with all extensions disabled?
Can you attach a gif showing this issue?

I guess you have a custom shortcut to create a new file, since Ctrl + N by default would just open an untitle file and that does not open the sidebar.

Yeah. I also just tested creating a new file from the Command Palette, and encountered the same issue.

Can you reproduce with all extensions disabled?

Yep. Had it freeze. Disabled all the extensions in another VS Code instance so that when I reopened, it'd have none enabled. Tried to create a new file again, and it still froze.

Can you attach a gif showing this issue?

Here is it freezing a second time, before I reopened it with all extensions disabled.

This time round, I'd just turned my PC on like 5-10 mins before. I don't think that has too much weight though as my PC had been on 3-4 hours before the initial report.
It may have to do with the fact that I open several projects in quick succession. However, they are all under 10 files.

Thanks for more details. I can repro something similar, but not 100% the same.

Have sidebar closed, reload
F1 > new file
Explorer is grayed out, there is no New File input

I can try to fix this and hopefully that will fix your issue as well -> thus assigning to November

Good catch. unforutnetly I was only able to resolve it using a timeout which is a bit ugly.
The problem is that the explorer gets shown and it is not yet fully resovled.
Alternative solution would be for me to add events that the explorer emits once it is ready. Will add that if this issue shows up in more places

No worries! Thanks for taking a look at it.
Will keep an eye out, and see if I can narrow the issue down.

It should be fixed now. At least it is on my machine. But the fix is not that pretty.


Add Migration (Open API, GraphQL)

Overview
Added API for migrating entire GraphQL, Open API
Summary of Work

Support for migrating Open API 2.0, 3.0
Support for GraphQL migration
Added GraphQL permission check API

How Has This Been Tested? OK
List of Test Cases (if necessary)

StableHttpSpecClientTest
APISpecMigrationControllerTest
FlatBasePathToMenuTest
TreeBasePathToMenuTest

Notes
Write down any precautions or peculiarities

Test 깨진거 수정해두었습니다.


refactor: pure functions

What?
I would like to shoot for all functions to become pure functions to aid with the testing effort.
Why?
Pure functions have controllable inputs and no external dependencies (apart from modules) this means:

They're easier to reason about.
They're easier to combine.
They're easier to test.
They're easier to debug.
They're easier to parallelize.
They're documentable

Specifically why?
The global state should be passed into a function, decoupling it and allowing testable function calls
what does it look like
Using an object based pattern for varadic args
// Case 1: varadic shorthand
const {host, realm, password} = fromSomeSource;
authenticate({ host, realm, user, password });

// Case 2: setup a profile of stuff
const credentials = {username: 'foo', password: 'bar'};
// called
authenticate({ host, realm, ...credentials });

// Case 3: A test
test("set state to a bad realm", () => {
    const result = () => authenticate({ realm: 234, ...args});
    expect(result).toThrow();
})

Why use an object and de-structuring everywhere?

argument order does not matter nor does the way they are passed
arguments are clearly labeled
Global state can be completely removed in favor of passing objects around
you can combine how they are passed
names of things stay consistent because the names of arguments are pre-determined upstream

This has been implemented across all files and functions of frodo-lib.


Not working on iPad

Though this is installable on Obsidian Mobile, but isn’t working on iPad. The text remains as in. Can anyone confirm that it does work on iOS?

Should be fixed with the new Update


add join nested

This adds functionality for easily passing in bulk inserts.
Signed-off-by: Tobias Gurtzick<EMAIL_ADDRESS>

ping @blakeembrey

ping @blakeembrey

Hi, I was on vacation. Taking a look now, isn't this effectively just this?
export function joinNested(values: Array<RawValue[]>) {
  return join(values.map(x => join(x));
}

Any reason for the additional complexity? We can even add the extra separator argument and just pass that through to the join function.

i just used your own methods and the rest is error handling

using your suggestion works, but would return wrong error messages, the main reason to do it this way is to have it distinct.

More explanation, my implementation reports a detailed error:
Expected joinNested([][5]) instead param at index 7 had a length of 4

So the user directly knows here what is wrong, if just calling join here, it would return a completely misleading error.

bug bug @blakeembrey

again some follow up, we're using our hard fork already so take your time deciding, just making sure it doesn't go under the radar completely.

buggedy bug @blakeembrey

Sorry for the delay, I've been effectively AWOL. I might rename it and will add to the README before the next release.

No worries, we maintain our module, so we were not waiting, :)
Hope you're doing well.


[Feature]: Add support for creating datasources by importing connection strings

Is there an existing issue for this?

[X] I have searched the existing issues

Summary
Currently Appsmith only supports connection strings for creating MongoDB datasources. This feature request is for a new Connection String Importer to be added at the top level in the Create Datasource list, rather than add a string importer input to each separate datasource form.
This would be similar to the curl importer, and would be an intermediate form, before landing on the actual datasource form. It should be able to test the string to ensure it is valid for the given protocol, and if valid, create a new draft datasource of the correct type, with all values filled in.
Why should this be worked on?

Saves users time in configuring datasources
Avoids errors in creating configuration (mixing up database_name/user_name, typos, etc)
Most databases provide connection strings
Increases activation and user's success rate of creating datasources

cc @rlnorthcutt @sumitsum

I could contribute a regex to go with each protocol if it helps. I could use named groups so each form input is matched and labeled in the output.

Hi @GreenFlux thanks for offering the help. If possible, can you please create a document with various regex and share the link here ?

@sumitsum , will do. I can have this for you early next week.


Check if a WhileMatchFilter is used.

Adapt WhileMatchFilter
Add integration tests for WhileMatchFilter
Check if WhileMatchFilter is used before using scan adapter

LGTM.  Please merge #426 first.


Turbine sort rh

I'm updating the finalize() methods to use a more succinct form of sorting (numpy almost always has you covered!).
I also fixed a few typos that found their way into the mix.

Thanks @RHammond2!


Can Ollama run more than one instance on Ubuntu

Since Ubuntu is multi-user operation system.
But I found if sb (not necessarily sudo user) is using Ollama, the other users cannot use it. How to deal with it?

OLLAMA_HOST=<IP_ADDRESS>:<some-different-port> ollama run
Ollama can run without sudo permissions of course.

If two requests happen at the same time, ollama will block until the first request is finished. We'll look at handling concurrent requests in a future version.
Going to close this as a duplicate of #358


ScriptExecution Allow doesn't work on Custom HTML page

Hello, we are trying to add JavaScript support for custom B2C HTML pages and the script execution setup doesn't work.
We get an error stating that the "RelyingParty" element has invalid child element "Endpoints" when we add the  element with  element w/ value of Allow.
When I comment out the ScriptExecution as shown, it works just fine:
 <RelyingParty>
      <DefaultUserJourney ReferenceId="CustomSignUpSignIn" />
      <!-- <UserJourneyBehaviors>
        <ScriptExecution>Allow</ScriptExecution>
      </UserJourneyBehaviors> -->
      <TechnicalProfile Id="PolicyProfile">
        <DisplayName>PolicyProfile</DisplayName>
        <Protocol Name="OpenIdConnect" />
        <OutputClaims>
          <OutputClaim ClaimTypeReferenceId="displayName" />
          <OutputClaim ClaimTypeReferenceId="givenName" />
          <OutputClaim ClaimTypeReferenceId="surname" />
          <OutputClaim ClaimTypeReferenceId="email" />
          <OutputClaim ClaimTypeReferenceId="objectId" PartnerClaimType="sub" />
          <OutputClaim ClaimTypeReferenceId="tenantId" AlwaysUseDefaultValue="true" DefaultValue="{Policy:TenantObjectId}" />
        </OutputClaims>
        <SubjectNamingInfo ClaimType="sub" />
      </TechnicalProfile>
      <Endpoints>
        <Endpoint Id="Token" UserJourneyReferenceId="RedeemRefreshToken" />
        <Endpoint Id="UserInfo" UserJourneyReferenceId="UserInfoJourney" />
      </Endpoints>
    </RelyingParty>

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 1e3ce49f-746e-9326-9846-32d569558b65
Version Independent ID: 4978d164-555d-b3cc-2989-5246b0f44313
Content: RelyingParty - Azure Active Directory B2C
Content Source: articles/active-directory-b2c/relyingparty.md
Service: active-directory
Sub-service: b2c
GitHub Login: @kengaderdus
Microsoft Alias: kengaderdus

@hypertrends
Thanks for your feedback! We will investigate and update as appropriate.

@hypertrends
Thank you for bringing this to our attention.
I've delegated this to content author @kengaderdus, who will review it and offer their insightful opinions.

@hypertrends
Thanks for your feedback and patience. The elements in RelyingParty and those in UserJourneyBehaviors elements must be presented in the order they appear in the RelyingParty reference. We'll update the docs to improve clarity #please-close


Implement OpenGL Images for read/write access to COpenGLTextures

Only a slot in a IDescriptorSet object needed, no special objects need be created.

https://repository.genmymodel.com/devshgraphicsprogramming/VulkanPipelineLayout
https://repository.genmymodel.com/devshgraphicsprogramming/VulkanRenderpassIndependentPipelines
https://repository.genmymodel.com/devshgraphicsprogramming/VulkanComputeAndRenderPassIndependentPipelines
This solves the issue in theory.

Obsolete, IDescriptorSet implementation takes care of this


Add gui warnings when violating rules for the gui system

This is ongoing, and mainly a DX issue.  Things like:

Using a sprite for an element that is not part of an atlas
Using a sprite on one element that is part of a different atlas as a sprite used on another element
Using a mesh with unreadable data
Using a mesh without important data like normals / uvs
Using a tightly packed sprite with a mesh that does not have atlas uvs

Many/All of these issues are going to be impossible to have an AutoFix button to fix them, or it will take an unreasonable amount of effort to get it working.

This has been started.  It's basically an ongoing thing while this part of the ui is in development.


Carousel shows all items at the same time

Expected behavior
I expect to see each carousel item(picture) one at a time, not all of them at once, side to side.
I apply the attribute data-carousel-item="active" to the first image. Maybe I'm doing something wrong?
Project information:

Tailwind: 3.0.0
Flowbite: 1.4.7
Flowbite React: 0.1.2
Type: Vite

Nevermind, got it working. Just forgot step 7 when installing flowbite


Add type annotations

The current code doesn't have type annotations. It would be an improvement if they were added.

Please feel free to submit a PR!


[Improvement] Rename the package name "aux" to another as it is a reserved name on

What would you like to be improved?
When I try to clone this git repository on Windows 10 platform, each time I got such an error:
$ git clone https://github.com/shaofengshi/gravitino
Cloning into 'gravitino'...
remote: Enumerating objects: 15411, done.
remote: Counting objects: 100% (1359/1359), done.
remote: Compressing objects: 100% (473/473), done.
remote: Total 15411 (delta 869), reused 1075 (delta 778), pack-reused 14052
Receiving objects: 100% (15411/15411), 6.96 MiB | 3.40 MiB/s, done.
Resolving deltas: 100% (6129/6129), done.
fatal: cannot create directory at 'core/src/main/java/com/datastrato/gravitino/aux': Invalid argument
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'
After doing some search, I found that it is the name "aux" be conflicted with Windows: " It looks like the problem is that 'aux' is a reserved path name on windows, and so the bc/aux directory cannot be cloned to windows".  See here: https://github.com/swcarpentry/DEPRECATED-bc/issues/463
It also can be found in MS websit, "Do not use the following reserved names for the name of a file: CON, PRN, AUX, ...": https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file
How should we improve?
Rename the package "core/src/main/java/com/datastrato/gravitino/aux" to another name which won't cause the confliction, like "misc".

Hi @shaofengshi thanks for your contribution and for raising this issue. Currently, we don't support Gravitino on Windows just on macOS and various flavors of Linux, however, we may do so in the future so we'll look into getting this changed.

@FANNG1 can you please investigate on this to see how to fix this.

This has already been worked on in another PR

@shaofengshi , thank you for reporting this, I have proposed #1374  to rename aux to auxiliary, I doesn't have windows environment, could you help to verify when you are free?
@justinmclean  #1359  seems not same problems. I try to fix in #1374 .

@shaofengshi , thank you for reporting this, I have proposed #1374 to rename aux to auxiliary, I doesn't have windows environment, could you help to verify when you are free?
@justinmclean #1359 seems not same problems. I try to fix in #1374 .

Thank you for the quick action. I will verify it soon, will update you on finish.

I merged the PR on a temp branch, and then download the source code as a ZIP on Windows, then it can be unzipped successfully (Before that, this is impossible). So I think this change is good, which is friendly for Windows users to browse the code. Thank you! @FANNG1

Verified, I can clone the latest code, no error any more.

Great. Thanks to @shaofengshi for reporting the issue and verifying the fix! :)


auto install doesn't always work

Most of the time I'm working on multiple packages in the same time and the work flow goes like this:

libA: I need func libB.XX()
switch to libB and add XX
switch back to libA, try to auto complete and either I get completion without the new func or get "libB is not a valid type".
switch to libB and run go install ./... manually.
libA's libB completion works now.

I'm using VSCode, however the issue is mainly with gocode, I got the same result with neovim.

I take it you're using nsf/gocode's "autobuild" feature?  If so, it's not surprising it doesn't work with mdempsky/gocode: I removed all of the config options. :)
Other tools like vet, gotype, and oracle/guru rely on up-to-date package objects, so I think it's appropriate for gocode to do this too.  I suggest that a separate tool should be responsible for ensuring that all of a package's dependencies are up-to-date.  Then that single tool can optionally be used by editors before invoking not just gocode, but those other tools too.

FYI if you use emacs with flycheck you can set flycheck-go-build-install-deps to t to automatically install package dependencies on save.

I use vscode-go.
IMHO the auto install feature should be there, or at least optional being off by default, but I understand it is your package.

@kostya-sh I think that's close but not exactly what @OneOfOne wants (not to mention for the wrong editor ;)). In their use case, after saving a change to libB, it sounds like flycheck-go-build-install-deps would only install libB's dependencies. But for gocode to give up-to-date suggestions, libB itself needs to be reinstalled too.
@OneOfOne I'm definitely sympathetic to the desire for the functionality to work. Just like I said, I don't think it's appropriate for gocode to need to provide it. It would be redundant and bad engineering practice for every Go analysis tool to need to reimplement this functionality.
I suggest you file a feature request with vscode-go (and feel free to CC me and/or reference this issue) to support auto-installation of dependencies.

On May 21, 2016 8:27 AM, "Matthew Dempsky"<EMAIL_ADDRESS>wrote:

@kostya-sh I think that's close but not exactly what @OneOfOne wants (not
to mention for the wrong editor ;)). In their use case, after saving a
change to libB, it sounds like flycheck-go-build-install-deps would only
install libB's dependencies. But for gocode to give up-to-date suggestions,
libB itself needs to be reinstalled too.

Yes, not exactly the same, autocomplete will pick up changes in the
dependent packages only after a save. I mentioned this only to show that
there are ways for editors to provide auto install functionality.

@mdempsky just out of interest, how do you solve this problem of keeping package objects up-to-date?

@myitcv Currently I just run "go install" manually as necessary.

@mdempsky 👍  does the job!
I'm probably going to hack together something that recursively watches a certain pattern (*.go by default) and triggers a go install for the containing package unless that package is main each time a change is detected - finding myself hitting this a lot given my current setup.


Negative keyframe times in animation

Bear in mind, that I'm relatively new to this space, so I may be mistaken and things are working as expected.
That said, I made an animation via Mixamo and exported as FBX. I imported the FBX to Blender just to do the export. Playback seems to work OK (via Don McCurdy's A-Frame-Extras, but the first part of the animation seems truncated. I've been nerding out a bit and looking into the file format, and the data I log into the browser console indicates negative playback times in the track. And indeed, even the accessor indicates a negative min value, with the max value matching the reported duration of the animation when parsed by GLTF2Loader in Three.js.
    {
        "bufferView" : 134,
        "componentType" : 5126,
        "count" : 96,
        "max" : [
            2.2
        ],
        "min" : [
            -0.9666666666666667
        ],
        "type" : "SCALAR"
    },

Again, my understanding of things could be mistaken, but given whats happening with the first part of the animation not being seen coupled with these unexpected (to me) negative values, I think this might be an export bug

Can you please provide the file?

Sure, I just made a repo to share easy. https://github.com/bengfarrell/mixamo-blender-gltf-example
Included is the gltf + bin file, but also the original FBX from Mixamo that was then imported to Blender.

During my subway ride, one important thing came in my mind: With glTF 2.0, negative keyframes are not allowed.
I think the current exporter is not checking this and the frames are just exported.
I will have a look at it.

Okay, there is an option, where keyframes are moved to 0.
So, what i will do is, that if a negative keyframe exists, this does happen automatically.

Hmm, negative keyframes are not possible in blender, so this cant be the problem. I will check the file.

Great, thanks for looking! Hopefully I'm just wrong and I didn't find a real issue on your end, but I am looking forward to some good adoption on glTF and I'd feel bad if I didn't report

I tried it out in several engines. The bevahiour in Blender is the same as in the engines. Let me have a look at the original file.

Hmm, i do not see any negatove keyframes.

There is always the possibility of a bug, and to get things mature, investigations are required.
But what i will add is a clamp, that negative frames are not possible at all.

Okay, added it here:
https://github.com/KhronosGroup/glTF-Blender-Exporter/commit/4fdcdc0359e099912be27a47f407c1021d25ccb9

Thanks much, I totally understand that blender doesn't support negative keyframe times. It looks like I need to look elsewhere in my pipeline to figure this out and get the animation fully playing

Negative keyframes are supported in Blender, if they are explicitly enabled.
But glTF 2.0 does not support negative keyframes.

Gotcha - I definitely don't have them enabled. And in fact, my animation starts on frame 0 when loading the animation/model into Blender from importing the FBX as indicated in my timeline. Playback in Blender is even fine, in that it doesn't cut the first part off.

It's just that when the file is exported via the Blender exporter, I'm getting negative times. I know that UX3D-nopper said he didn't see any negative keyframes, but using GLTF2Loader and viewing the time values, they are definitely there. It's entirely possible that GLTF2Loader is erroneous, but the associated sampler input values when using the index to look up the accessor have min values that are negative - and that is taken directly from the human readable JSON glTF file.
So, I'm confused. I totally understand that I'm new to this space, so I will defer to this repo's owner that this isn't a bug with the glTF-Blender-Exporter, but I'm at a loss as to what is wrong here.

Just not to confuse u: McNopper is my private account :-)
With the current master branch, all negative keyframes are explcitly removed.
Also, you can drag and drop the the golfer.bin and golfer.gltf file into the glTF validator:
http://github.khronos.org/glTF-Validator/
[
    {
        "uri": "golfer.gltf",
        "mimeType": "model/gltf+json",
        "resources": [
            {
                "id": "#/buffers/0",
                "mimeType": "application/octet-stream"
            }
        ],
        "info": {
            "version": "2.0",
            "generator": "Khronos Blender glTF 2.0 exporter",
            "externalResources": {
                "buffers": {
                    "#/buffers/0": "golfer.bin"
                }
            },
            "hasAnimations": true,
            "hasMaterials": true,
            "hasMorphTargets": false,
            "hasSkins": true,
            "hasTextures": false,
            "hasDefaultScene": true,
            "primitivesCount": 26,
            "maxAttributesUsed": 4
        }
    }
]

The glTF 2.0 file is fine, as negative keyframes would have been reported. If you think, there are still negative keyframes, please raise first an issue with the validator, as we depend on the correct validation.

Hehe, was wondering why there were so many noppers :)
Ok, I'll look into the validator, thank you!

Also, you can drag and drop the the golfer.bin and golfer.gltf file into the glTF validator:

Small correction: for now, you need to drag-n-drop GLB file to validate binary data. Folder support is coming.

Hopefully I'm not beating a dead horse, and actually helping, but I did export as glb to test in the validator (also checked into https://github.com/bengfarrell/mixamo-blender-gltf-example). The validator reports that there are negative times:
"errors": {
"ACCESSOR_ANIMATION_INPUT_NEGATIVE": [
{
"type": "ACCESSOR_ANIMATION_INPUT_NEGATIVE",
"path": "#/accessors/132",
"message": "Animation input accessor element at index 0 is negative: -0.9666666388511658."
},
I haven't pulled the latest from the repo, but if you remove all negative keyframes in the export as you just indicated, then I would assume that I'd still be missing keyframes. Prior to the change, they just wouldn't play in Three.js, after this change, I would assume that the data is just lost from the file correct?
 Again, I know you closed this, and don't want to press the issue if not welcome, but I did want to provide relevant info.
Thanks

Hmm, I think it could happen, if your animation has a keyframe ar 0 but the animation starts at 1,
I will fix this,

If input assets and blender support negative keyframes then is the thinking that the exporter shifts the negative keyframes to 0 and shift the others correspondingly to make a valid glTF file?

There is an option im the exporter, that all frames are shifter to 0. If disabled they are kept like they are.
Also, this should finally fix it:
https://github.com/KhronosGroup/glTF-Blender-Exporter/commit/2236977e9cc4821b6fcb7741d9016c60ee503ade

If the final of the keyframe - with or without shifting is negative - it is now correctly eliminated.

Fantastic, thank you! I just downloaded the zip of the repo and updated my files. The glb file now validates, and in Don McCurdy's viewer plays all the way through. I'm so glad this works now. As I understand it, Blender is pretty much the ONLY way to convert to glTF 2.0 right now, so that's why I pushed so hard on this. Again thanks, crossing my fingers this is the only issue I'll encounter!

No problem, and it was good that you pushed this. I was just wrong, as I debugged at the wrong position.
Sooner or later another issue will probably pop up. Provide an example and we will fix it.


More descriptive error message when validating secrets with any of the fallback webhooks fails

Summary
Previously we would have returned a nil error but also a nil payload on
exhausting all previous secrets in a loop which would later error out when it
couldn't be parsed. That means that this bug has no security implications (we
would just get a 500 instead of a 400), but let's fix it nonetheless.
Change Type
Mark the type of change your PR introduces:

[x] Bug fix (resolves an issue without affecting existing features)
[ ] Feature (adds new functionality without breaking changes)
[ ] Breaking change (may impact existing functionalities or require documentation updates)
[ ] Documentation (updates or additions to documentation)
[ ] Refactoring or test improvements (no bug fixes or new functionality)

Testing
manually + a unit test
Review Checklist:

[x] Reviewed my own code for quality and clarity.
[ ] Added comments to complex or tricky code sections.
[ ] Updated any affected documentation.
[x] Included tests that validate the fix or feature.
[ ] Checked that related changes are merged.

coverage: 50.169% (+0.03%) from 50.144%
when pulling 6a8a876fa17345da64af7ccfa2aa9e4cf3a3255d on fallback_webhook_secret_fix
into e6ec6518439766c9cb133a6a7aef787b833bae11 on main.


[5.9][CodeCompletion] Fix a crash when completing an argument to a function taking a parameter pack

Explanation: We previously asserted that for a call the function type had the same number of parameters as the declaration. But that’s not true for parameter packs anymore because the parameter pack will be exploded in the function type to account for passing multiple arguments to the pack.
To fix this, use ConcreteDeclRef instead of a ValueDecl, which has a substitution map and is able to account for the exploded parameter packs when accessed using getParameterAt.
Scope: Code completion of arguments
Risk: 2/5
Testing: Added regression test
Issue: rdar://100066716
Reviewer: @xedin and @rintaro on https://github.com/apple/swift/pull/65720

@swift-ci Please test

@swift-ci Please test macOS

@swift-ci Please test

@swift-ci Please test Linux


Level-5 GPIO interrup and level 5 timer interrupt does not work in IDF v5.0 (IDFGH-9148)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

IDF version.
idf v5 release
Operating System used.
Windows
How did you build your project?
VS Code IDE
If you are using Windows, please specify command line type.
PowerShell
Development Kit.
Customized PCB with ESP32-S3 N8R2
Power Supply used.
External 3.3V
What is the expected behavior?
I have a project which uses high-level (level 5) GPIO interrupt and high-level timer interrupt. Previously it works very well with ESP-IDF V4.4. This week I updated the IDF to V5.0 release, after compiling and flashing, neither GPIO interrupt nor timer interrupt works anymore. I generated a simple project to test. It works in IDFv4.4 but doesn't in IDF v5.0.
level 5 GPIO interrupt id: 31. level 5 timer interrupt id 16, using CCOMPARE_2.  "xt_highint5" in Assembly. "Main.cpp" in C++.
Expected:
level-5 GPIO interrupt handler is called and returned nomally
level-5 Timer interrupt handler is called and returned nomally
What is the actual behavior?
The registering of GPIO or timer interrupts succeeds. But once GPIO or timer interrupt triggers, both of the two CPU cores are stuck somewhere, no matter which core the interrupt is registered in.
There is code in the level-5 intr handler to clear the GPIO interrupt flag and set the ccompare_2, but somehow it may not work with idf v5.
Steps to reproduce.
The zip file of the code is attached:  --> main.zip  <--
The code of the testing project is attached. It includes "main.cpp" and "Sampling_Int.S".

Create a project with the code of main.cpp and Sampling_Int.S
Update the CMakeLists, code is attached below.
compile with idf V4.4 and flash to esp32-s3.  Manually toggle the defined GPIO "PPS_PIN", it will output the interrupt counter to monitor.
compile with idf v5.0 and flash to esp32-s3. Once interrupt triggers, it will be stuck and rebooted by the watch dog.
code is attached below:

main.cpp
`#include <stdio.h>
#include "freertos/FreeRTOS.h"
#include "freertos/task.h"
#include "xtensa/core-macros.h"
#include "driver/gpio.h"
#include "soc/soc.h"
#include "soc/periph_defs.h"
#include "esp_log.h"
//#include "esp_rom_gpio.h"
#include "rom/ets_sys.h"
#define PPS_PIN 8
uint32_t AlarmValue = 240000000;
uint32_t IntCounter[2];
void RegisterInt(void *you_need_this)
{
gpio_set_intr_type((gpio_num_t)PPS_PIN, GPIO_INTR_POSEDGE);
gpio_intr_enable((gpio_num_t)PPS_PIN);
gpio_config_t cfg;
cfg.intr_type=GPIO_INTR_POSEDGE;
cfg.pin_bit_mask=(1ULL<<PPS_PIN);
cfg.mode=GPIO_MODE_INPUT;
cfg.pull_up_en=GPIO_PULLUP_DISABLE;
cfg.pull_down_en=GPIO_PULLDOWN_DISABLE;
ESP_ERROR_CHECK(gpio_config(&cfg));
WSR(CCOMPARE_2, 2400000);
ESP_LOGE("Intr", "Try to enable Timer intr.");
xt_ints_on(1 << 16);
ESP_LOGE("Intr", "Try to enable PPS intr.");
xt_ints_on(1 << 31);
ESP_LOGE("Intr", "Try to register PPS intr.");
intr_matrix_set(0, ETS_GPIO_INTR_SOURCE, 31);
ESP_LOGE("Intr", "Register Intr done.");
vTaskDelete(NULL);
}
void Output(void *you_need_this)
{
int iii=0;
while(1)
{
printf("\n[%d]Interrupt Counter =%lu",++iii,IntCounter[0]);
vTaskDelay(500/portTICK_PERIOD_MS);
}
}
extern "C"
void app_main(void)
{
xTaskCreatePinnedToCore(Output,"Out",4096,NULL,0,NULL,0);
vTaskDelay(3000/portTICK_PERIOD_MS);
xTaskCreatePinnedToCore(RegisterInt,"allocEXTGPIOINT",4096,NULL,0,NULL,0);
while(1)
vTaskDelay(1000/portTICK_PERIOD_MS);
}`
Sampling_Int.S:
`#include <xtensa/coreasm.h>
#include <xtensa/corebits.h>
#include <xtensa/config/system.h>
#include "soc/gpio_reg.h"
#define PPS_PIN 8
#define PPS_INT_Sta_REG     GPIO_STATUS_REG
#define PPS_INT_W1TC_REG    GPIO_STATUS_W1TC_REG
#define PPS_Mask            (1<<PPS_PIN)
.section .iram1,"ax"

_l5_intr_stack:
.space      64
//Interrupt Handler
.section .iram1,"ax"
.global     xt_highint5
.type       xt_highint5,@function
.align      4
xt_highint5:
/////////////////////////////////////////////////////////////////////////////////////////////////////
//save register values. It takes around 15 cpu cycles to save the register valeus.
movi    a0,     _l5_intr_stack
s32i    a5,     a0,     0
s32i    a6,     a0,     4
s32i    a7,     a0,     8
s32i    a4,     a0,     44
s32i    a3,     a0,     48
s32i    a2,     a0,     52
s32i    a1,     a0,     56
rsr     a1,     SAR
s32i    a1,     a0,     60
//////////////////Interrupt handling start////////////////////////////////
YourCodeHere:
//----------------------------
//increase ccompare_2 by 60M
movi    a5,     AlarmValue
l32i    a7,     a5,     0
movi    a6,     60000000
add     a7,     a7,     a6
wsr     a7,     CCOMPARE_2
s32i    a7,     a5, 0
//---------------------------
//reset intr flag (no matter if it is gpio interrupt)
movi    a3,            GPIO_STATUS_W1TC_REG        //get REG to clear the interrupt status
movi    a4,            PPS_Mask                //load Pin mask
s32i    a4,            a3,            0       //write the mask to Int clear REG
memw
//increase IntCounter[0] by 1
movi    a3,    IntCounter
l32i    a4,    a3,    0
addi    a4,    a4,    1
s32i    a4,    a3,    0
SAVE_EXIT:
movi    a0,     _l5_intr_stack
l32i    a5,     a0,     60
wsr     a5,     SAR             //restore shift register
l32i    a5,     a0,     0
l32i    a6,     a0,     4
l32i    a7,     a0,     8
l32i    a4,     a0,     44
l32i    a3,     a0,     48
l32i    a2,     a0,     52
l32i    a1,     a0,     56
//---------------------------------------------------------------
//return
EXIT:
rsr     a0, EXCSAVE_5                   /* restore a0 */
rfi     5
.global ld_include_highint_hdl_my
ld_include_highint_hdl_my:`
CMakeLists.txt
idf_component_register(SRCS  "main.cpp"  "Sampling_Int.S"                     INCLUDE_DIRS ".") target_link_libraries(${COMPONENT_TARGET} "-u ld_include_highint_hdl_my")
Debug Logs.
No response
More Information.
No response

compile with idf v5.0 and flash to esp32-s3. Once interrupt triggers, it will be stuck and rebooted by the watch dog

Does placing your _l5_intr_stack into DRAM solve the stuck issue?
    .section .dram1,"a"
_l5_intr_stack:
    .space      64

Thank you so much! Yes, changing .iram1 to .dram1 slove the problem. So should we not save any data in iram1, even 64byte?

@wyu900

So should we not save any data in iram1, even 64byte?

Not necessarily, data can be placed in IRAM1 (although the CPU can only access it in a 4-byte aligned manner as it's going through the instruction bus). With .section .iram1, could you try adding a .align 4 in and see if that also solves the issue?

@wyu900 Closing this issue as it doesn't seem to be a bug. Please feel free to reopen otherwise.


--form-control-vertical-gap is used but not documented

Does it come from another module?

Added them here for now:
https://github.com/vcl/default-theme#shared-variables


How to define a :asc or :desc sort order when sorting

const { find } = useStrapi<ServiceWithRelations>();

const { data } = await find('services', {
  populate: {
    icon: true,
  },
  sort: ['title:asc'],
});

the resulting query then is:
services?populate[icon]=true&sort[0]=title%3Aasc
and this does not work!
how can I get it to be as required
services?populate[icon]=true&sort[0]=title:asc ?

Which version are u using? the following code seems to be working for me:
find('blog-pages', { populate: ['header_image'], sort: ['publishedAt:desc'] })

Hello @SvenWesterlaken
Sorry for the late reply! I just upgraded to the latest version, 1.10.0 but the syntax above still does not work for me. The parser seems to not be able to resolv the : , so it produces the %3A instead. What can I do? I really need to sort some stuff in my app.

%3A is the URL encoded version :, perhaps searching around with that term and your strapi version should get you further.


[Bug]: Predefined environment variables not passed to Nixpacks

Description
I pushed a PR to test predefined environment variables to a preview deployment on my Sveltekit app. The environment variables are being passed to Nixpacks as literal strings rather than being replaced with the predefined values.
I followed the instructions here: https://coolify.io/docs/knowledge-base/environment-variables
Minimal Reproduction (if possible, example repository)
Example variables:
TEST_URL=$COOLIFY_URL
PUBLIC_TEST_URL=$COOLIFY_URL

Build variable is checked. Is Literal? is not checked.

Exception or Error
The resulting Final Nixpacks plan looks like this:
Final Nixpacks plan: {
"providers": [],
"buildImage": "ghcr.io\/railwayapp\/nixpacks:ubuntu-1716249803",
"variables": {
"SOURCE_COMMIT": "8887ff2d43fa705c29557d55a2320a50b95f36eb",
...HIDDEN_REAL_VARIABLES...
"PUBLIC_TEST_URL": "$COOLIFY_URL",
"TEST_URL": "$COOLIFY_URL",
"CI": "true",
"NIXPACKS_METADATA": "node",
"NODE_ENV": "production",
"NPM_CONFIG_PRODUCTION": "false"
},

And the resulting environment variables look like this with console.table:
#14 13.85 Coolify check: process.env
#14 13.85
#14 13.85 ┌─────────────────┬────────────────┐
#14 13.85 │ (index) │ Values │
#14 13.85 ├─────────────────┼────────────────┤
#14 13.85 │ PUBLIC_TEST_URL │ '$COOLIFY_URL' │
#14 13.85 │ TEST_URL │ '$COOLIFY_URL' │
#14 13.85 └─────────────────┴────────────────┘

Version
v4.0.0-beta.297

i thought i was going crazy

Also facing this issue. The environment variable is getting set correctly in the container but $coolify_url is what gets passed if its marked as a build variable.

Probably related to https://github.com/coollabsio/coolify/issues/2316

Still have the issue in v4.0.0-beta.335

I think that this is fixed (I'm on v4.0.0-beta.373)

I am still having this issue on 4.0.0-beta.373
Example environment variable (build variable checked, literal not checked):
PUBLIC_TEST_URL=$COOLIFY_URL

Logged output during build:
#14 14.79 │ PUBLIC_TEST_URL       │ '$COOLIFY_URL'

Is there any workaround for this at the moment?
This is annoying for PR deployments lol


AssertionError [ERR_ASSERTION]: object glob found no files

The issue I'm facing is that this assertion seems to happen immediately on compiler execution before I have a chance to generate the files that it's asserting.  The files in question are css files with content hashes so they're dynamically created during webpack compilation.
https://github.com/jharris4/html-webpack-tags-plugin/blob/7e2f1b3dfd9dbb62294f6fc1a00c4f5ce4741dc4/index.js#L150
Is it tenable to alter that assertion so that it only happens when the glob is first needed or can be configured to be optional?
"html-webpack-plugin": "3.2.0",
"html-webpack-tags-plugin": "2.0.13",
"webpack": "4.33.0",
"webpack-cli": "3.3.5"

Interesting... I had designed the glob feature to allow the inclusion of static assets that exist before webpack even starts running.
I think I understand your use though, so there might be a middle ground that can be found fairly easily, where the check for the glob assets existence gets deferred a little.

Usually html-webpack-plugin itself takes care of adding js/css files that are generated by webpack itself, so I'm a little surprised that you've found a case where that is not happening.
Any chance you can share a more complete webpack config so I can dig a little deeper?

@jayryemure I'm still waiting for more details about your webpack config to see if I can dig into this further.
If I don't hear back soon I'll assume I can close the issue. Thanks!

Closing for lack of activity


[FEATURE] AI Services: Option to dynamically select system message de…

…pending on the user message #956

Context

https://github.com/langchain4j/langchain4j/issues/956
Change
There are two annotations, @RegisterSystemSpecs and @SystemSpec, which facilitate dynamic selection of system messages to accompany user inputs when interfacing with a Large Language Model (LLM). This dynamic selection process involves an initial query to the AI model to determine the most relevant system specification. Should no relevant system be found, a default SystemSpec is utilized, ensuring that a response is always generated.
This approach mirrors the methodology used in Langchain, which also involves querying the LLM to select the most appropriate system message. The prompt used for this operation is consistent with the one employed by Langchain.
Using a vector search with a TextClassifier for this feature do not seems to fit to this use case because vector search always returns a result, which may not always align with the relevance required for effective system message selection. In contrast, a direct query to the AI allows for a determination of whether a suitable SystemSpec exists for the given user message.
Several tests have been conducted to ensure robustness
When the @SystemMessage annotation or a System Message Provider is used in conjunction with @RegisterSystemSpecs or a System Spec Provider, the latter are overridden and ignored
Checklist
Before submitting this PR, please check the following points:

[x] I have added unit and integration tests for my change
[x] All unit and integration tests in the module I have added/changed are green
[x] All unit and integration tests in the core and main modules are green
[X] I have added/updated the documentation
[ ] I have added an example in the examples repo (only for "big" features)
[ ] I have added my new module in the BOM (only when a new module is added)

Checklist for adding new embedding store integration

[ ] I have added a {NameOfIntegration}EmbeddingStoreIT that extends from either EmbeddingStoreIT or EmbeddingStoreWithFilteringIT

Hi @KaisNeffati, thank you so much!
Unfortunately this is not what was meant. I did a poor job with issue description, this is completely my fault, sorry.
Currently we already have a systemMessageProvider which can be configured on the AI Service.
But it accepts only a memory id. One can dynamically select system message based on the user, but not based on the message (topic/etc).
I was thinking about changing the input of the systemMessageProvider to an object that will contain both memory id and a user message, probably with the previous messages as well.
When this is possible, than any algorithm can be implemented on top of systemMessageProvider. One could use LLM (your solution) or embedding model, or keyword, or something else.
WDYT?

No worries, my friend ! I just reviewed the langchain python source code for this feature and rewrote it.
I see it doesn't exhibit the desired behavior. So closing this PR for now 😙


Redux setup

Since the last code review, the following was done in this project:

Add Redux Toolkit (npm install react-redux @reduxjs/toolkit) ✅
Create a directory that will contain all your Redux logic (/src/redux) ✅
Configure a Redux store (/src/redux/store.js) ✅
Define a slice of state for books that:

Includes an array of books (initial state: empty array) ✅
Includes a reducer that adds a book ✅
Includes a reducer that removes a book ✅

Define a slice of state for categories that:

Includes an array of categories (initial state: empty array) ✅
Includes a reducer that checks the status and always returns "Under construction" (the initial state should check to that string) ✅

Since the last code review, the following was done in the project:

import the categories reducer to store


same code run on different versions of tf cost large different gpu memory consumption.

HI,
In my two system(P40, CUDA9, CUDNN7), tf1.8 and tf1.12 are installed respectively, and the same piece of code runs in tf1.12 almost double the allocated gpu memory as in tf1.8.
I wrote the following code to simplify the comparison. At this time in tf1.8, 1241MiB gpu memory is allocated and in tf1.12, 737MiB gpu memory is allocated. How could I optimize the gpu memory allocation in tf? Any suggestion would be appreciated.
import tensorflow as tf
config = tf.ConfigProto()
config.gpu_options.allow_growth = True
config.allow_soft_placement = True
a=tf.get_variable('a',(100,100))
b=tf.get_variable('b',(10000,10000))
sess=tf.Session(config=config)
sess.run(tf.global_variables_initializer())

@Jar7 Please try to use most recent TF versions (TF.1.15 or TF2.0) as there were several improvements in the performance. Please check the guides and tutorials provided in the TF website as for gpu, distributed_training and tf.data for best performance using machine learning pipeline. Thanks!

This is not Build/Installation or Bug/Performance issue. Please post this kind of support questions at Stackoverflow. There is a big community to support and learn from your questions. GitHub is mainly for addressing bugs in installation and performance. Thanks!

@Jar7 Please try to use most recent TF versions (TF.1.15 or TF2.0) as there were several improvements in the performance. Please check the guides and tutorials provided in the TF website as for gpu, distributed_training and tf.data for best performance using machine learning pipeline. Thanks!

Hi, could you please specify the reason for different gpu memory allocation for the provided code on different version of tensorflow? I have read the tutorials about gpu, and cannot find the answer. It is straightforward that some gpu memory is unnecessary allocated. Is it a bug?

@Jar7 May be there was an over allocation in TF1.8, which is a very old version. The allocation with TF1.12 seems to be correct as I checked with TF1.15 which is also taking similar allocation. I would suggest to use TF1.15 as there were lots of performance improvements. Thanks!


Build is currently broken

As per https://github.com/AzerothWarsLR/WarcraftLegacies/actions/runs/3801570708/jobs/6466173420 the code base doesn't compile. Needs to be fixed as a priority.

Woah 0.0
Anything I can do; or shouldn't do?

@HerrDave I don't think so.
The main problem occurred because Constants were regenerated incorrectly. Constants need to be regenerated whenever any object is created, renamed, or deleted, or when any region is created, moved, renamed, or deleted. Regenerating Constants breaks all code references to the object.
In https://github.com/AzerothWarsLR/WarcraftLegacies/actions/runs/3801570708/jobs/6466173420 Sebas regenerated Constants and fixed most of the resulting broken references, but he didn't fix them all. Whenever we regenerate Constants we should always make sure the map actually runs before committing the changes, because otherwise the problem just falls to the next person trying to test.
So this one is probably on Sebas to fix. In your case, it's probably not worth learning the level of C# needed to deal with it, and you should just rely on Sebas or I to regenerate Constants.

Sorry, just noticed I unassigned the wrong person.


remove dev-only flag from save_enable

Unsure if this is the proper fix for this but it seems as if the client tries to set this to 0 while in a server and cannot due to it being dev-only.
We previously had it without the dev-only flag and I don't believe there should be any negative effects due to this.
Should fix R2Northstar/Northstar#359

i was planning on pring this anyway but will probably be merging this since you've made a pr for it


propose to enable netlify for previewing the docs in PR

Deploy-preview feature enables building docs in PR, which make it easier for reviewing

idk what this is. can you explain? why is this needed?

it allows previewing the edited docs(for each pr), making reviewing easier


numeric fields exported as text by default since v4 to excel

Hello,
not sure whether this is a bug / feature.
In v3 exporting numeric fields (floats, decimal fields) used to give numeric fields in excel when exporting.
in version 4 by default numeric fields are displayed as text.
in case i add a field definition to the resource class the issue dissappears:
class SensorResource(resources.ModelResource):
    float_factor = Field(attribute='float_factor', widget=NumberWidget())
    class Meta:
        model = Meter

Is that behavior intentional ?

Thanks for raising.

Is that behavior intentional ?

Yes, in v3 the widget render() method returned a mixture of strings and native types for various widgets.  This caused issues depending on the file type, so we standardised on returning strings.  I guess the ideal would be to export either strings or native types depending on the file format. i.e. csv would require strings, xlsx would require native types.  This would be an enhancement for a future release.
There is the option to export to export the native type, documented here.
I will update the release notes to clarify the change in behaviour.

thx a bunch for pointing to the documentation. i can confirm that works. however some notes.:

fields that are part of a foreign key widget do not get string coercion by default.
duration field gets string coercion applied by default.
when i use the duration field in a foreign field i cannot enforce string coercion.
example with 'sensor_last' being a foreign field:

class MeterResource(resources.ModelResource):
    correction_factor = Field(attribute='correction_factor',
                              widget=NumberWidget(coerce_to_string=False))
    last_measurement = Field(attribute='last_measurement',
                             widget=DurationWidget())

    class Meta:
        model = Meter

class MeterAdmin(ImportExportModelAdmin):
    resource_classes = [MeterResource]

class MeasurementResource(resources.ModelResource):
    time = Field(attribute='time',
                 widget=DateTimeWidget())
    # enforced string coercion works:
    sensor_cf = Field(attribute='sensor',
                      widget=ForeignKeyWidget(Meter,
                                              field='correction_factor',
                                              coerce_to_string=True)
                      )
    # enforced string coercion does not work:

    sensor_last = Field(attribute='sensor',
                        widget=ForeignKeyWidget(Meter,
                                                field='last_measurement',
                                                coerce_to_string=True)
                        )
    value = Field(attribute='value', widget=DecimalWidget())

    class Meta:
        model = Measurement

Well, as (also) documented: string coercion can be enforced using dehydrate.
    def dehydrate_sensor_last(self, measurement):
        try:
            last_measurement = measurement.sensor.last_measurement
            if last_measurement:
                return str(last_measurement)
        except ObjectDoesNotExist:
            return

so. in case excel cannot handle the natively dehydrate / custom method needs to be applied ? this is also the case for datetime objects as far as I can see.

Thanks for looking into this.  It looks like we might have some gaps which need address.

Note that some of the issues regarding export of native types have been addressed in #1939

fields that are part of a foreign key widget do not get string coercion by default.

There's no easy way around this at present, the best way to format the output is to create a ForeignKeyWidget subclass.  i have updated the documentation to clarify this.

duration field gets string coercion applied by default.

This was addressed in #1939.


Add custom constraint evaluation to UI

since the move to breadcrumbheaders, we've lost the ability to run the custom constraints evaluation, which we need.  This should be added back to the UI somewhere.

Currently the model editor visualizer allows you to run when selecting an object using the available context menu

Not currently using breadcrumb header so no longer needed.


Can I have multiple login pages in one app. Like my app has various features and I want a separate login page for each feature

my question to you is your app conected with firebase or not ?
if it is it will be easy to control this with firebase rules


Fix race condition involving session processor

/azp run net - servicebus - tests

API change check
API changes are not detected in this pull request.

/azp run net - servicebus - tests


[WIP] add poker

Implementing Ruby

Thanks for the PR @jjseymour ! Currently there is also this one open regarding this exercise, you could talk to @fabienalbi if you have suggestions or a different approach to the solution.  :)

The PR @bernardoamc linked (#310) has been merged so this exercise is now implemented in ruby. @jjseymour, if you have any thoughts on the newly merged poker exercise feel free to open an issue or a new PR addressing it! Thanks!


should this be heterochromatin?

the normal term is now:

obsoleted FYPO:0004575,
suggested
"increased subtelomeric heterochromatin RNA level" (FYPO:0005917)

I need to find the correct obsoletion procedure and fix this warning
WARN	missing_obsolete_label	DEPRECATED increased subtelomere-derived RNA level	rdfs:label	DEPRECATED increas


Cannot change keyboard layout

I am trying to change from US ansi keyboard layout to UK iso keyboard layout but it doesn't seem to switch at all. I have double checked this in my gnome instance and just tty with no DE, keyboard is set correctly in system but not for hyprland.
Steps to reproduce:
load up a fresh copy of hyprland, copy example config to local config folder and set kb_layout to uk
input {
    kb_layout=uk
    follow_mouse=1

    touchpad {
        natural_scroll=false
        tap-to-click=false
        middle_button_emulation=false
    }
}

Expected Outcome:
the keyboard layout should change to uk iso, the \ key on a us keyboard should output a # if layout changed correctly
Actual Outcome:
keyboard remains as us layout, does not register change

I struggled with this - problem is you need the right string for uk layout. It's gb rather than uk

thats why reading the xkb docs is useful.


gvim menu inconsistencies

Steps to reproduce
open up gvim (lang doesn't matter)
click on edit button from ui pane(second button)
watch last 2 fields
after some seconds they will change
Expected behaviour
consistency
Version of Vim
source
Environment
arch
Logs and stack traces
No response

This behavior is intentional to reduce the startup time.
If you don't want this behavior, add let do_no_lazyload_menus = 1 in your vimrc.
See :help menu.vim for details.
@chrisbra
I think we should add tags about this variable:
--- a/runtime/doc/gui.txt
+++ b/runtime/doc/gui.txt
@@ -503,7 +503,7 @@ The first item in the Syntax menu can be
 in the menu (which can take a bit of time to load).  If you want to have all
 filetypes already present at startup, add: >
 	:let do_syntax_sel_menu = 1
-
+<					*menu-lazyload* *do_no_lazyload_menus*
 The following menuitems show all available color schemes, keymaps and compiler
 settings:
 	Edit > Color Scheme ~

@k-takata it didn't work


Release on PyPi

This client is useful enough for GA. Can we release a first version of it?

I was hoping to test it some more before hand, but I guess I can do it now

That took longer than I thought:
https://pypi.python.org/pypi/pypachy


Use QUICLY_EPOCH_* constants

Replace some more "magic numbers" by the corresponding constants.

Nice catch! Thank you for the PR.


Add GitHub Action workflow for automatically updating custom Wiki sidebar

Reference issues/PRs
Fixes #2855.
What does this implement/fix? Explain your changes.
This PR adds a GitHub Actions workflow that automatically updates the Wiki sidebar whenever a Wiki page is added or a page title is changed. It does this using a third-party github-wiki-sidebar tool. This way, the sidebar doesn't have to be manually updated each time a page changes. (It's a shame that GH doesn't do this natively, but alas!)
I tested this workflow on a personal repo (joshuacwnewton/test-github-action-wiki) and it works nicely:

Test page to check if the GH Actions workflow would automatically add the page to the sidebar.
Corresponding job that did in fact update the sidebar! :D

I can document exactly how to format pages so that they nest properly in this new sidebar, as well.

On second thought, the github-wiki-sidebar tool can't do everything. There are some ideas I have that require more:

External links (instead of just pages)
More complex ordering of pages (github-wiki-sidebar does alphabetic ordering)

Perhaps it is just better to manually update the sidebar instead.

@Drulex Since you've been doing great work on the Wiki, I'm wondering what you think of this PR, which automatically updates the sidebar (instead of manually editing _Sidebar.md).
See also: this Wiki Structure page I've just made.

Looks good to me. Structure is straightforward :+1:


⚠ TorrentLeech has degraded performance

In 7b05867, TorrentLeech ($TL) experienced degraded performance:

HTTP code: 200
Response time: 4512 ms

Resolved: TorrentLeech performance has improved in 25a91e7 after 7 minutes.


Enable Python 3.12

(Written by Adrian) Enables Python 3.12 and fixes a bug with the validation converter, which also happens to fix the cattrs issue that originally blocked this PR (see details in PR comment).

Hi @Scienfitz, it took me one afternoon of debugging, but I eventually found the issue. Turned out it has nothing to do with cattrs (as far as I can tell) but is related to how Protocols are handled in Python 3.12, which causes and unintended fallback dispatch to our RecommenderProtocol. The issue is quite delicate and there are many unlucky things coming together (e.g., the validation then succeeds because for that class additional keywords are currently dropped, which is another open problem in our code for which we already have a longstanding TODO). Anyway, here the link to an issue I've posted that recreates the problem in form of a minimal example: https://github.com/python-attrs/cattrs/issues/525
Regarding this PR: I made another minor change, which happens to fix the symptoms of the bug (for the root cause, we'll have to see what will happen in the ticket). The problem is fixed because the validation converter now contains an explicit hook for Campaign and therefore no longer relies on the incorrect fallback. However, note that the issue would return if we ever decided to remove that hook again, thus it's not a 100% satisfying solution. But for now, I think we can merge and track the ticket instead.

Solves #156


Issue 707 - Use case sensitive names for quoted table names in H2

I looked at the quoted table names test case and made the table name handling for H2 case sensitive for quoted names as well. I basically just moved the removal of the quotes to after the test for case sensitivity for H2. The tests are running on my machine.

@Cecilya I hope this works!


Investigate supporting recording per collection limits, removing collection limit

The collection limit is not technically needed, given the size restriction.
Investigate recording per collection limit for performance reasons.

Removed collection limit UI, was not enforced. Added check to prevent temp users from creating any collection besides temp.
Recording limit not needed for now, will revisit if becomes an issue later (eg. for perf reasons)


Add input_grayscale_image_pyramid, issue #354

Issue #354
I'm doing some test with it, I'll be uploading a performance comparison tomorrow using it in the mmod (the training takes several hours).
In the meantime I wanted to create the pull request, to be sure it's a good contribution, and to start reviewing the code.

Thanks for the PR.  The code looks correct.  You should use spaces instead of tabs though.  And if you could figure out how to reduce the code duplication that would be good too, like making a base class that contains most of the code and is inherited from.

Sorry about the tabs, I've fixed it already.
About the hierarchy, what I could do is create a base class input_image_pyramid, which implement all methods except to_tensor, and all those related to serialization, which would go to the derived classes. Does this seem better for you?
The problem is that to_tensor is a template member function, so I can not specialize it in derived classes.
One more thing. If the above is good for you, what would be the correct way to document it in the abstract?

Sorry for the late reply.  Yeah, that sounds fine. Don't use any virtual functions, you can just publicly inherit from the base class to get all the methods.  As for to_tensor, yeah, that's not really sharable.  But their are parts of it that could be trivially moved into protected helper methods in the base class and called from derived classes.
I wouldn't mention this inheritance in the documentation at all.  It's an implementation detail users don't need to know about.

With this commit I've create a base clase input_image_pyramid, which has the common methods of the derived classes.

And now I've refactored to_tensor method, to move repeated code to base class.

Some benchmarking I've made:

rgb
grayscale

640x360
18.14 us
16.05 us

400x300
10.31 us
9.22 us

It is around 11% faster.

Sweet, looks good.  Thanks for the PR :)


Add types

Hi there, thanks for your pull request, but at this time I’m not accepting typescript definition files. TS’s official recommendation is to not add definition files to projects, but instead to add them to DefinitelyTyped

Gotcha, will submit it there. Thanks!


Do not clobber VK_ICD_FILENAMES.

Fixes #2343

That's a good idea, I forgot that we provided an exists method.

On second thought this variable can be a list of colon-separated paths, I don't think we should be expected to parse and validate it.  Let's simply avoid clobbering it.


Vsts plugin fail : (select work items other than myself) (intellij)

IN intellij in the work item tab I used my own query "work items" (based on my tfs server) but when I  select a commit with a work item it shows only PBI from the assigned to me query and not something else.

I found the  a partial solution use a # with number of the work item to select the work item.


CI takes over 20 minutes

https://github.com/freenet/locutus/actions/runs/3073961505/jobs/4966424064
Looks like most of it is the Build step.
Per @iduartgomez:

[ ] Switch to Mold linker
[ ] Upgrade to get better CI instances

Free tier github runners have 1-core and are slow, that's why the build process takes so long, since rustc parallelizes at the crate level.
Must take a look at the caching we are using etc. too

Ah, interesting. I'll investigate an upgrade.

An other thing we must do is use an other linker than the default gcc one, using lld or even better mold should speed up the linking steep quite a lot

I've heard good things about mold.

I think we are not using caching of artifacts properly:

maybe not pointing to the right directory etc.
We need to look at this.

I played with mold a bit.
System: (Linux 5.10.0-18-amd64 Debian 5.10.140-1 (2022-09-02) x86_64 GNU/Linux)
Hardware: HP EliteBook 850 G8, 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz, 32gb RAM
Commands:
cargo clean
cargo build --all-features
// checks whether mold actually used or not
readelf -p .comment target/debug/locutus-node
Results
without mold:
Finished dev [unoptimized + debuginfo] target(s) in 11m 41s
with mold:
Finished dev [unoptimized + debuginfo] target(s) in 11m 29s
After several runs sometimes it's even faster without mold. So overall I'd say that +- 10 secs in both directions -> mold doesn't help(as I see on Linux at least)

Yes, the main problem is we rebuild all crates in almost all builds, so we are not making good use of build caching. Default Github runners have 1 core and ain't the fastest so it takes a while to build all the dependencies. The last linking steep not taking that long as you saw...
If we can improve/fix build caching, it should get much better.

Is this a simple matter of doing something like this? :
steps:
- name: Checkout code
  uses: actions/checkout@v2

- name: Cache cargo registry
  id: cache-cargo-registry
  uses: actions/cache@v2
  with:
    path: ~/.cargo
    key: cargo-registry-${{ hashFiles('Cargo.lock') }}
    restore-keys: cargo-registry-

- name: Build
  run: cargo build --release

- name: Cache cargo registry
  if: always()
  uses: actions/cache@v2
  with:
    path: ~/.cargo
    key: cargo-registry-${{ hashFiles('Cargo.lock') }}

Is this a simple matter of doing something like this? :
steps:
- name: Checkout code
  uses: actions/checkout@v2

- name: Cache cargo registry
  id: cache-cargo-registry
  uses: actions/cache@v2
  with:
    path: ~/.cargo
    key: cargo-registry-${{ hashFiles('Cargo.lock') }}
    restore-keys: cargo-registry-

- name: Build
  run: cargo build --release

- name: Cache cargo registry
  if: always()
  uses: actions/cache@v2
  with:
    path: ~/.cargo
    key: cargo-registry-${{ hashFiles('Cargo.lock') }}

Yes, just checked on the project where I can control github actions ci and it works.
So I think we can integrate that. But in order to correctly integrate that probably someone who has rights to actions manipulations should do that(cc @iduartgomez). So it will be easier to fix a problem if something goes wrong.
Nevertheless, If creating a PR will be helpful I can do that.

@kakoc I think a pull request would be great if @iduartgomez can confirm, perhaps there is a reason this approach wasn't used before.

Worth a  shoot, let's try out with a PR.

This has been greatly improved with the changes done in the messaging app PR: https://github.com/freenet/locutus/actions/runs/5724414933/job/15510859787?pr=658
will take an other look if necessary in the future, but the next would probably be using a multiprocessor machine for CI


Added dark mode to add network dialog on Add Custom RPC network screen

Tap Settings > Select Active Networks > + on top right corner. Select two or more networks. Tap Add Network button.

Before commit
After commit

@oa-s any issues with this PR?