[jest-worker] BaseWorkerPool should not accept a relative path because it breaks strict node module resolution package managers

🐛 Bug Report
When metro is bundling, it uses a worker pool to transform files.
The worker uses a require statement to execute its job. For metro, this file will be something like metro/src/DeltaBundler/Worker which is defined in metro-config defaults.
https://github.com/facebook/jest/blob/ca47512c77e6a325bca734a35a4ad15a45dee8aa/packages/jest-worker/src/workers/processChild.ts#L113-L115
The file parameter is sent to it via a message from the worker pool.
https://github.com/facebook/jest/blob/ca47512c77e6a325bca734a35a4ad15a45dee8aa/packages/jest-worker/src/base/BaseWorkerPool.ts#L25-L37
jest-worker#BaseWorkerPool runs require.resolve(workerPath) where workerPath = 'metro/src/DeltaBundler/Worker'.
The problem is that require('metro/src/DeltaBundler/Worker') is being run from from jest-worker that doesn't have an explicit dependency of metro. It is non-standard and relying on yarn's package hoisting to work. pnpm and yarn pnp require dependencies to be explicitly defined.
When using expo and pnpm this causes a strange error message such as:
TypeError: Transformer.transform is not a function
    at Object.<anonymous> (/Users/Vaughan/dev-mono/thirtyfive/node_modules/.pnpm/metro@0.64.0/node_modules/metro/src/DeltaBundler/Worker.js:80:38)
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (/Users/Vaughan/dev-mono/thirtyfive/node_modules/.pnpm/metro@0.64.0/node_modules/metro/src/DeltaBundler/Worker.js:14:24)
    at _next (/Users/Vaughan/dev-mono/thirtyfive/node_modules/.pnpm/metro@0.64.0/node_modules/metro/src/DeltaBundler/Worker.js:36:9)
    at /Users/Vaughan/dev-mono/thirtyfive/node_modules/.pnpm/metro@0.64.0/node_modules/metro/src/DeltaBundler/Worker.js:43:7
    at new Promise (<anonymous>)
    at Object.<anonymous> (/Users/Vaughan/dev-mono/thirtyfive/node_modules/.pnpm/metro@0.64.0/node_modules/metro/src/DeltaBundler/Worker.js:32:12)
    at Object._transform (/Users/Vaughan/dev-mono/thirtyfive/node_modules/.pnpm/metro@0.64.0/node_modules/metro/src/DeltaBundler/Worker.js:98:21)
    at Object.transform (/Users/Vaughan/dev-mono/thirtyfive/node_modules/.pnpm/metro@0.64.0/node_modules/metro/src/DeltaBundler/Worker.js:55:21)
    at execFunction (/Users/Vaughan/dev-mono/thirtyfive/node_modules/.pnpm/jest-worker@24.9.0/node_modules/jest-worker/build/workers/processChild.js:155:17) {
  type: 'TypeError'

This is because metro is being resolved to an incorrect version<EMAIL_ADDRESS>instead of<EMAIL_ADDRESS>because jest-worker is working in a non-standard way.
Suggested change
jest-worker#BaseWorkerPool should never accept a relative path, only absolute paths, as relative paths will most often not be resolved correctly.
To Reproduce
TODO
Expected behavior
TODO
Link to repl or repo (highly encouraged)
TODO
envinfo

  System:
    OS: macOS 10.15.7
    CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
  Binaries:
    Node: 14.2.0 - ~/nvm/versions/node/v14.2.0/bin/node
    Yarn: 1.22.4 - ~/.yarn/bin/yarn
    npm: 6.14.4 - ~/nvm/versions/node/v14.2.0/bin/npm

Agreed - wanna send a PR? Metro should just require.resolve the file themselves


unittest "test run" reports wrong test case count

Steps to reproduce
Write a unittest function with one test case data input
[DataTestMethod]
[DataRow(1)]
public void YouTest(int value)
{...}
When you run the test using

dotnet test

the output will be:
...
Starting test execution, please wait...
Total tests: 2. Passed: 2. Failed: 0. Skipped: 0. Test Run Successful.
Expected behavior
Actually it's only one test here, [DataTestMethod] is not a test.
Actual behavior
2 tests passed
Environment
MSTest 1.3.2
Note-  This happened after we added support for hierarchical results https://github.com/Microsoft/testfx/pull/417
Fix - It would perhaps be best to say both in the CLI output - x tests and x+n test results.

Also happening when marked the unit test function with [TestMethod] attribute.
Somehow the issue seems to be related with the DataRow attribute.

dotnet test
...
Starting test execution, please wait...
Total tests: 2. Passed: 2. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 1.4402 Seconds

Checking to see if I can figured out what's going on to provide a fix for this.

@parrainc : In case of data-driven tests, there is a parent result for all the aggregated test results. Currently, this parent result is also counted as test and hence a mismatch. So it would be better if we could clearly display that there are 'x tests and x+n test results' in our output.

Totally agree @jayaranigarg . It's way better if in the output it says what you point out instead of the actual count.
I'm looking at the code to provide some changes for this. Will keep commenting here if questions comes up or when have something to show.

@jayaranigarg did a change in UpdateResultsWithParentInfo method, removing the line 423, so the parent result is not added anymore in the results list. Even though this broke some of the tests, it's now behaving as it should in the example provided:

dotnet test
...
Total tests: 1. Passed: 1. Failed: 0. Skipped: 0.
Test Run Successful.
Test execution time: 1.4402 Seconds

Also, planning to add a property to the TestResult (something like ParentResult) for either holding the parent result that was being passed as a test or the count of parent test results (every inner result will hold its parent result).
My question is, where should I send those values in order to display them in the CLI output (kind of lost here)?

@parrainc : We will come back with an update on this. Making this change has other implications on our system and we will have to investigate that. Thank you for your patience.

This change is needed to ensure that the data driven tests work fine in different CI scenarios like distribution and rerun and is intentional.


⚠ Bofrost.lu has degraded performance

In 5811016, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1394 ms

Resolved: Bofrost.lu performance has improved in b769ba5 after 13 minutes.


Allow generation of CSS sourcemaps at development time

This MR provides an opt-in for creating CSS sourcemaps in dev mode. The related issue is #5707.
When the environment variable DEV_CSS_SOURCEMAPS is set to true, the sourcemaps are generated in development mode as well. Production mode is not affected.
Tested by running 'yarn start' with and without environment variables.
This is the default:

This is with DEV_CSS_SOURCEMAPS=true:

Any updates on this?


RDMA executor support

RDMA Executor header-only library:

Added support for RDMA-based data transfers in TransferBench using the newly introduced RDMA_Executor class. This executor enables data transfers using RDMA-capable NICs, bypassing host involvement for GPU/CPU transfers.
a MemoryRegister function to handle memory registration required for RDMA transfers.
Added initialization (InitDeviceAndQPs) and teardown (TearDown) processes for RDMA Executors.

Thread-safe RDMA Transfer function to work with the current logic of multithreaded transfers

Enabled multithreaded transfers per RDMA executor to allow concurrent data transfers over the same NIC and using the same QPs
Single and concurrent RDMA transfers using single or multiple NICs are supported

IBVerbs library Wrapper:

An IBVerbs wrapper to handle low-level RDMA operations
Logic added to detect and initialize RDMA NICs using IBVerbs (InitDeviceAndQPs) and CPU/GPU data transfers (TransferData).

Fallback when IBVerbs is not available

Compile-time fallback added to the Makefile to switch to GPU-based DMA executors if RDMA support is unavailable on the dynamic library cache. Method stubs are included to avoid breaking compatibility.
Updated the Makefile to conditionally compile RDMA executor support based on the availability of ibverbs on the system. If ibverbs is not found, RDMA executors are disabled with LIB_IBVERBS_UNAVAILABLE.

Misc:

Modified the example configuration file to include scenarios for RDMA transfers:
Added numNicDevices to the EnvVars structure, which stores the number of detected RDMA NICs to ensure that the correct number of NICs is used.
Stopped tracking binaries and ignored changes to binary files.
Added environment variable handling to control RDMA executor behavior, including the number of NICs to use (NUM_RDMA_DEVICES) and executor configurations via EnvVars.
Added input validation for RDMA NIC device counts. An error is raised if an invalid NIC index is specified, preventing out-of-bound access.

PR is only tested on a Mellanox IB server. Broadcom RoCE seems to have initialization issues. I am currently looking into it.

It can be tested now. Please report any issues you encounter.


Place an overlay icon on the taskbar button

Is your feature request related to a problem? Please describe.
I use multiple Visual Studio instances regularly. I already have a tool that separates the Visual Studio buttons on the taskbar.  So now I have two buttons but they look the same. Their ordering remains the same unless I close and reopen one of the windows. But they should be distinguishable to pick the right one when I'm working with the mouse.
Putting a colour bar inside the window doesn't help at all because you don't see it before you're there. The colour bar might only be a stronger indicator to know that you've landed in the wrong window again.
Describe the solution you'd like
There should be an overlay icon on the taskbar button to clearly identify each window. You can't go wrong when you click on the button that has the initial letters or even the icon of the project you want to work with.
There was an extension for Visual Studio that did this but the ever-changing extensibility APIs of Visual Studio regularly breaks such useful extensions. I could hack it into VS 2019 but failed with VS 2022.
Describe alternatives you've considered
There is currently a workaround on another level, outside of Visual Studio, using Windhawk. It doesn't support icons though.
Additional context

Got this working now:

Okay, but I can't use it. It doesn't help me decide on which taskbar button to click. I'm not using this preview stuff and taskbar button grouping because it takes ages for the preview to appear and then ages to disappear again. They're constantly in my way. One of the worse design decisions of the Windows 10 taskbar. It's not only about aesthetics, it's also about function.

@ygoe, check the latest version. It has an option to put the color directly on the taskbar app icons for the situation you described.


Fifth Korean l10n work for release-1.15

Fifth Korean l10n work for release-1.15

Translate concepts/scheduling/_index.md to Korean (#16072)
Translate concepts/workloads/controllers/replicaset.md in Korean (#16070)
Update outdated content in dev-1.15-ko.5 (#16162)
Translate using-api/client-libraries into korean (#16182)
ko: translate concepts/cluster-administration/proxies (#16030)
Translate concepts/workloads/controllers/deployment.md in Korean (#16113)

Co-Authored-By: Seokho Son<EMAIL_ADDRESS>Co-Authored-By: Eden<EMAIL_ADDRESS>Co-Authored-By: Yoon<EMAIL_ADDRESS>Co-Authored-By: Sunghoon Kang<EMAIL_ADDRESS>Co-Authored-By: Yuk, Yongsu<EMAIL_ADDRESS>Co-Authored-By: June Yi<EMAIL_ADDRESS>

/lgtm

@seokho-son @ianychoi 감사합니다!
/approve


do not spam extra shell / make killing soft by default

killing with -9 can have bad side-effects, let users opt-in that really want it instead of making it the default for copy-pasters
solves https://github.com/gaia-adm/pumba/issues/63
@Dieterbe

rebased

/cc @alexei-led

Thank you


Satellite image Display

Utilizes the S3 Sentinel images for visualizing timestamps:

When selecting a Region it will request the timestamps for that given region's bounding box.  This may take a few seconds

If the Region is larger than 1 degree in either the X/Y size it will display a warning.  I don't want the system to sit there trying to load timestamps for an abnormally large region because the backend would continue to try to grab data even if the user leaves the page or goes to another region.

There is an indication of the satellite list loading in the same location as the regular loading bar.

After the images have loaded a chip will be displayed showing the number of satellite images for the region.  Also the image icon will be enabled

At this point the image icon will be enabled to toggle images on (if no region is selected or no images are found for a region it will remain disabled.

The images displayed are synchronized with the time slider.  The closes timestamp is displayed in the chip as the user moves the timeslider.

If the user closes the region the images will automatically disable until a new region is selected.

within the settings there is an option to change the image opacity as well as an additional image checkbox which corresponds to the image icon.

If the region is larger than 1 degree in X/Y direction a warning will come up informing the user that it is too large to get the satellite images.  The warning can be dimissed.

Issues for the future:

First time it takes 30-90 seconds or more to load the timestamps.  On large regions, it may take even longer to load the timestamps.  That is why on regions > 1 degree X/Y it will display the warning message.
If you jump to another region while the current one is in the process of loading it will continue to download data on the server in an attempt to get the timestamps.  This is something that should be resolved in the future.
I've noticed a few times that the Access key for S3 has come up with warnings while testing.

Per the feedback from Aashish:

There is now a small loading bar when loading satellite tiles:

Additionally the satellite icon flashes while loading the tiles.


fix: High CPU Usage with Invalid Config

Hello @folke,
I've created a pull request to fix a bug where Neovim chews up 100% of a CPU core when it encounters an invalid configuration.
The bug seems to be in edgy.util.with_retry, where it doesn't increase the retries variable, causing endless loops of retries and high CPU usage.
I've committed a fix. This should properly deal with invalid configurations and prevent Neovim from overloading the CPU.
Hope this helps out. Happy to chat more if needed!
Cheers,
Daniil

Thanks!


chore: remove obsolete "version" entry in Docker Compose files

References: docker/compose#11628

bors merge

bors retry


typo in cmpivot.md

typo: score -> store

@LucasArona : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Verified the update per the context; merging.
@LucasArona Thanks for submitting this fix.


Added insertions scope for insert snippet action

snip funk after air
Checklist

[ ] I have added tests
[ ] I have updated the docs and cheatsheet
[ ] I have not broken the cheatsheet

I already do that with the checkboxes. Here they are still not implemented.

Yes I do want you to review what is here so we can discuss it.

Understood—I've marked it as draft to reflect that

updated

@pokey poke!


[docs] Demo UnstyledSelectControlled crashes

[x ] I have searched for similar issues in this repository and believe that this is not a duplicate.

Steps to Reproduce

Visit https://mui.com/base/react-select/
Enable device emulation in chrome developer tools or visit on mobile device
demo UnstyledSelectControlled crashes (doesnt crash on desktop)

Edit: all demos crash on https://mui.com/base/react-select/
Your Environment

Tech
Version

MUI
v5.9.1

netlify deploy
https://62d59767934a0000083cd4e9--material-ui-docs.netlify.app

Browser
Mozilla/5.0 (iPhone; CPU iPhone OS 13_2_3 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/13.0.3 Mobile/15E148 Safari/604.1 Edg/103.0.5060.114

This was fixed with #33882


Roll Flutter Engine from 68aa9ba386e1 to 4ac21cb7c6e0 (4 revisions)

https://github.com/flutter/engine/compare/68aa9ba386e1...4ac21cb7c6e0
2024-03-29<EMAIL_ADDRESS>Add completion callback to Shell::AddView (flutter/engine#51659)
2024-03-29<EMAIL_ADDRESS>[Windows] Move keyboard initialization (flutter/engine#51758)
2024-03-29<EMAIL_ADDRESS>[Windows] Don't always stop engine on view destruction (flutter/engine#51681)
2024-03-28<EMAIL_ADDRESS>[macOS] Group per-view information in FlutterCompositor into a class (flutter/engine#51738)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry<EMAIL_ADDRESS>on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Commit queue failed; closing this roll.


Improvements to test.ceylon.time

Many, MANY tests were calling assertEquals with the wrong argument order: assertEquals(expected, actual), whereas the correct order with positional arguments is assertEquals(actual, expected). A few of these mistakes were caught by ceylon/ceylon#6183. I attempted to fix them in a way that would be consistent with other tests in the file, so sometimes I swapped the parameters, and sometimes I changed the invocation to use named arguments.
Some tests did manual exception handling instead of using assertThatException.
Some tests could be parameterized (#159).

Can one of the admins verify this patch? (see README)

CC @DiegoCoronel, @luolong

@CeylonBuildBot ok to test

Wow @lucaswerkmeister you must really have a ton of unaccounted for time on your hands :)
Thanks, this is much better now 👍

Should I merge it or do you want to make these last few adjustments...?

I can make the adjustments. Should I amend the existing commit or add another one?

Oh, I forgot I wanted to make another change as well – rename members like data_1982_12_13 to date_1982_12_13. Or is that not a typo?

probably thats a typo @lucaswerkmeister .. in Brazil date is data .. probably I wrote in portuguese by mistake

Alright, all done except for the non-named arguments assertEquals in testDates.ceylon. Should I change them all to named arguments?
Also, the question of commits is still open… 7d2d111 should at least be squashed into c68b01e, but apart from that, I leave it to you if you want to merge the separate commits or a squashed commit. (I think squashing would make more sense.)

@lucaswerkmeister:

Should I amend the existing commit or add another one?

I guess, just adding commits to this PR is good enough...

Alright, I’ve pushed a squashed commit.

Thanks Lucas!

You’re welcome! :)


Add Jitsu live events API's to admin endpoints

Problem
Add Jitsu live events API's to the Jitsu docs. Right now, we do not know which endpoint to call to retrieve the information for the endpoint.
Solution
Add Jitsu live events API's to OpenAPI/Docs page i.e https://jitsu.com/docs/other-features/admin-endpoints

@absorbb Events Cache endpoints are available on the Jitsu docs (https://jitsu.com/docs/other-features/events-cache)


Netlify Lighthouse

Tried enabling Netlify Lighthouse plugin, which

Runs Lighthouse after every build
Defaults to mobile test
Yields low score for SEO as Netlify runs it on deploy permalinks which has noindex for crawlers (known issue)

Some of this can be changed with a netlify.toml file, but it may not be ideal to commit a host specific file to the repository.
Solution for now is to use pagespeed.web.dev

pagespeed.web.dev seem to not retain reports for long. Went ahead and enabled lighthouse plugin for Netlify even though the issues listed in OP still remain. Should be able to see Lighthouse scores in every PR.


Upgrade apiVersion to v1 from v1alpha1

What type of PR is this?

Uncomment only one  /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
What does does this PR do / why we need it:
We reached 1.0.0 a while ago! We can consider this apiVersion to be v1
now and obviously new features / changes to be alpha.
Which issue(s) this PR fixes:
Fixes https://github.com/openshift/odo/issues/2490
How to test changes / Special notes to the reviewer:
N/A, just run tests or deploy a component
Signed-off-by: Charlie Drage<EMAIL_ADDRESS>

/retest

According to https://github.com/openshift/odo/issues/2490#issuecomment-596642540
we'll have to implement some form of backwards compatibility if there are any breaking changes.

but I couldn't find anything to support backwards compatibility or am I missing something?

I think what @cdrage meant was to maintain backwards compatibility from now on. as currently there is nothing different between v1 and v1alpha1 there is no need to have anything for backward compatibility.
once @cdrage confirms this, I will approve this PR

I think what @cdrage meant was to maintain backwards compatibility from now on. as currently there is nothing different between v1 and v1alpha1 there is no need to have anything for backward compatibility.

But I think this will break things for the adapter team. @cdrage am I missing something?

/hold
/release-not-action-required
@cdrage please check with @dgolovin and @jeffmaury whatever they are using apiVersion field in VSCode and IntelliJ plugins or not.

/refresh

I confirmed with both Dennis and Jeff over slack that they both do not check for apiVersion.

ping @kadel @mik-dass @amitkrout @girishramnani for review + merge

f \"Master Machines\": failed to generate asset \"Platform Credentials Check\": validate AWS credentials: checking install permissions: error simulating policy: Throttling: Rate exceeded\n\tstatus code: 400, request id: 5e2f8636-3f95-4b94-a552-d24caaed21ff"

/retest

/approve

/retest

@cdrage Most of the json output test cases are failing on the prow
• Failure [61.732 seconds]
odo component command tests
/go/src/github.com/openshift/odo/tests/integration/cmd_cmp_test.go:13
  Creating component
  /go/src/github.com/openshift/odo/tests/integration/component.go:52
    should describe pushed component when it is created with json output [It]
    /go/src/github.com/openshift/odo/tests/integration/component.go:249
    Expected

        <string>: "...io/v1","kin..."
    to equal               |
        <string>: "...io/v1alpha1..."

Can you please have a look?
/hold

/remove hold

@cdrage any update on this?

/hold cancel

level=info msg="Consuming Install Config from target directory"
level=fatal msg="failed to fetch Common Manifests: failed to fetch dependency of \"Common Manifests\": failed to generate asset \"DNS Config\": getting public zone for \"origin-ci-int-aws.dev.rhcloud.com\": listing hosted zones: Throttling: Rate exceeded\n\tstatus code: 400, request id: d0df1712-35fb-41cf-8df6-18b7cae8d2fb"

/retest

/retest

@cdrage Can you please rebase this? Rest looks good to me.


Removed unnecessary lookup call to resource registry from internal WritePolicy operations

Description

Removed resource lookup from WriteDelegationPolicyInternal and DeleteAllRulesInPolicy
In both cases its only used for setting ResourceType on the DelegationChange and used for switching whether it's a App delegation change or ResourceRegistry delegation change that is to be written to the PostgreSQL database.
Changed this switching to instead just use the ResourceAttributeMatchType

Related Issue(s)

#147

Verification

[x] Your code builds clean without any errors or warnings
[x] Manual testing done (required)
[ ] Relevant automated test added (if you find this hard, leave it and we'll help out)
[x] All tests run green

Documentation

[ ] User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

Looks correct.
Good to save that call

Validating that the service is available for delegation will be the responsibility of the service specific implementation anyway before performing the internal delegation policy write operation


Missing - Ulimit and selinux policies when using instances

As I was implementing a number of instances on my RHEL 7.x i ran into 2 issues.

It doesn't look like ulimit is getting set correctly for each service.
It looks like this could be implemented on each individual service level with this in the systemd unit file.
LimitNOFILE=$ulimit

Since the available class for ulimit is private and not being called unless you use config via the "default_install => true" arguement, i think its a pretty safe addition to add it to the unit file template and reference it where necessary.

I'm using selinux (because RHEL). and because i'm defining multiple instances, every instance runs on a different port.  The problem was the port group for selinux was not allowing me start the service.  i was receiving the following error in the redis logfile.

# Creating Server TCP listening socket <IP_ADDRESS>:6381: bind: Permission denied
After looking around a bit, i found that the selinux group is not configured to allow the non-default port i was using (6381) to bind.
# semanage port -l | grep "redis_port_t"
redis_port_t                   tcp      6379, 16379, 26379

I was able to temporarily work around this with the addition of the non-default port
semanage port -a -t redis_port_t -p tcp 6381
now its all happy...
# semanage port -l | grep "redis_port_t"
redis_port_t                   tcp      6381, 6379, 16379, 26379

The ulimit part has been fixed in 0f930aad8cfed622b66ce522f2186b35de127165. Adjusting the title to only reflect the SELinux part.


AAP-33633: ModelPipelines: Configuration improvements. WCA(-onprem) API Key is optional

Jira Issue: https://issues.redhat.com/browse/AAP-33633
Description
Further to https://github.com/ansible/ansible-ai-connect-service/pull/1389
@TamiTakamiya reported Staging Pod's were failing to start as the api_key was missing.
I added ANSIBLE_AI_MODEL_API_KEY environment variable to both Staging and Production AWS Secret Manager.
However @ldjebran reported his use of VSCode against Production with the environment variable set was broken.
Reverting ANSIBLE_AI_MODEL_API_KEY fixed the problem; meaning api_key should be optional.
This PR makes api_key optional.
Testing
Unit Tests.
However the issue was not evident until deployment to Staging was attempted.
Production deployment

[x] This code change is ready for production on its own
[ ] This code change requires the following considerations before going to production:

pip-audit fix here:
https://github.com/ansible/ansible-ai-connect-service/pull/1409


problem when run command "composer install"

Steps to reproduce
composer install
No composer.lock file present. Updating dependencies to latest instead of installing from lock file. See https://getcomposer.org/install for more information.
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.
Problem 1
- Root composer.json requires php ^8.1 but your php version (7.4.33) does not satisfy that requirement.
Problem 2
- Root composer.json requires laravel/sanctum ^3.2 -> satisfiable by laravel/sanctum[v3.2.0, ..., 3.x-dev].
- laravel/sanctum[v3.2.0, ..., 3.x-dev] require php ^8.0.2 -> your php version (7.4.33) does not satisfy that requirement.
Problem 3
- laravel/framework[v10.25.0, ..., 10.x-dev] require php ^8.1 -> your php version (7.4.33) does not satisfy that requirement.
- Root composer.json requires laravel/framework ^10.24.2 -> satisfiable by laravel/framework[v10.25.0, ..., 10.x-dev].
What is expected?
not install folder vendor
What is actually happening?
not install folder vendor
Additional data

Hi @rahebsaeed,
Thanks for getting in touch with us!!
You are facing challenges installing Composer due to compatibility issues between PHP, Laravel and Sanctum versions.
To address this, we advise you to update the versions of PHP, Laravel and Sanctum on your local system according to the requirements specified in the composer.json file.
This step is crucial for ensuring that all components work seamlessly together, thereby resolving the installation difficulties you're facing.
Regards~


Cannot find example of configuring multiple remotes in documentation

Extension version: 0.6.0
VSCode Version: 1.33.1
OS: Windows _NT x64 6.1.7601

Steps to Reproduce:

Go to official extension documentation -> https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-pull-request-github
Scroll down to #6 in the "Getting Started" steps, and notice it mentions configuring githubPullRequests.remotes, but it doesn't show an example of that configuration

Not knowing what that looks like, makes it so that I do not know how to configure multiple remotes for my ultimate goal of seeing open PR's for multiple repositories.

Hey @jknapp25, I'll update some of the documentation so that this is clearer.
The githubPullRequests.remotes setting is an array of remote names, so something like
"githubPullRequests.remotes": ["origin", "fork"] would be a valid configuration, or leaving it null to have the default behavior of searching for "origin" and "upstream".
If you have a workspace with multiple folders open, you can select one of them in the source control viewlet:

This should cause the PR tree to refresh with PRs for that repository. We have an open feature request for making this UI clearer: https://github.com/Microsoft/vscode-pull-request-github/issues/1116

@RMacfarlane after selecting the other repo in my Source Control Providers list, the list of PR's in the extension does not update to the PR's for the selected repo. Is this a bug?

For the first point, can you share what the format of the urls for "origin" and "server" are with git remote -v? In the newest version of the extension, the icon should always be shown, but previously it would only bet shown if a remote pointing to GitHub was detected. So maybe we're having an issue parsing those urls.
The second point sounds like a bug, could you open another issue for that after testing with version 0.7.0 of the extension?
For the third point, is this https://github.com/microsoft/vscode-pull-request-github/issues/436?

Format of both URL's:
https://github.com/team-name/repo-name.git
Testing with 0.7.0:
How do I test with this version? In VSCode there is no update option, and it shows my extension is at 0.6.0
Lastly:
Yes, it does look like the same issue as #436

Ah, testing with 0.7.0 requires the latest version of VS Code, 1.34.0

Tested with 0.7.0, looks like it works now!
I think all that's left to be resolved is #436 now.
Thank you!


Proposed alias already exists

Not sure what's the issue here. I came across this in a question for Q10838:

Interesting...
So the wiki correctly lists the BAB 70 alias as already existing https://en.wikipedia.org/w/api.php?action=query&prop=extracts|pageterms&exlimit=20&exintro=1&titles=Bundesautobahn_70
And we can see that wikicrowd is aware of this as BAB 70 appears in the current aliases too...
Any alias candidates that already exist should be skipped and not have questiosn generated for them
https://github.com/addshore/wikicrowd/blob/454ff0fdc5534c98deccf68c48ed7fb04787de55/app/Jobs/GenerateAliasQuestions.php#L116-L126
Looking at the question itself in the DB it appears this is due to the space actually being a \u00a https://www.fileformat.info/info/unicode/char/000a/index.htm when extracted from Wikipedia...
>>> Question::where('unique_id', '=', 'Q10838/aliases/en/BAB 70')->take(1)->get()
=> Illuminate\Database\Eloquent\Collection {#4427
     all: [
       App\Models\Question {#6604
         id: 56283,
         question_group_id: 13,
         unique_id: "Q10838/aliases/en/BAB 70",
         properties: "{"item":"Q10838","label":"Bundesautobahn 70","aliases":["BAB 70","A 70","Autobahn 70"],"suggestion":"BAB\u00a070","html_context":"
English Wikipedia:<\/p><\/br>
English Wikipedia:<\/p><\/br>
English Wikipedia:<\/p><\/br>
Bundesautobahn\u00a070<\/b> (translates from German as Federal Motorway\u00a070<\/i>, short form Autobahn\u00a070<\/b>, abbreviated as BAB\u00a070<\/b> or A\u00a070<\/b>) is an autobahn in southern Germany, connecting the A\u00a07 via Schweinfurt and Bamberg to the A\u00a09. <\/p>","language":"en"}",
         created_at: "2022-03-29 10:41:40",
         updated_at: "2022-04-02 17:01:59",
       },
     ],
   }


[SP-4401] Backport of PDI-17203 - XML Output step: Null pointer excep…

…tion when processing fields with null values (7.1 Suite)
@pentaho-lmartins

Commit message and PR title is not OK.

Build Completed
:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.
Build Commands
mvn -B -fn -f 'plugins/pom.xml' -pl 'meta-inject-plugin' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install && mvn -B -fn -f 'plugins/pom.xml' -pl 'meta-inject-plugin' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd site

Cleanup Commands
mvn -B -f 'plugins/pom.xml' -pl 'meta-inject-plugin' -P '!assemblies' -amd build-helper:remove-project-artifact

Changed files
  plugins/meta-inject-plugin/src/main/java/org/pentaho/di/ui/trans/steps/metainject/MetaInjectDialog.java

License header violations

:heavy_exclamation_mark: Couldn't find acceptable copyright on plugins/meta-inject-plugin/src/main/java/org/pentaho/di/ui/trans/steps/metainject/MetaInjectDialog.java


KluctlDeployment.spec.args doesn't override args defined in .kluctl.yaml

Controller Version
v0.9.0
Kubernetes Version
any
Bug description
Args from KluctlDeployment works, but not if same arg already defined in .kluctl.yaml.
Steps to reproduce
No response
Relevant log output
No response

Can you give an example? We actively do overrides of args via KluctlDeployment.spec.args and it works for us.

Let's try!) I perform many tests and it's about only already defined args (I tested in .kluctl.yaml), if arg not defined, so KluctlDeployment doesn't override it, then it works as should.
The target from .kluctl.yaml:
- name: foo
  args:
    kafka-ui: true
    vars:
      namespace: override-me

KluctlDeployment:
apiVersion: flux.kluctl.io/v1alpha1
kind: KluctlDeployment
metadata:
  name: default
spec:
  target: foo
  targetNameOverride: BAR
  args:
    kafka: false
    kafka-ui: false
    vars:
      namespace: foo

Results:
# I said disable all about kafka, but UI still persist and it errors about not non-existent NS:
$ kubectl get kluctldeployments.flux.kluctl.io default -o yaml | grep kafka
          error: 'failed to patch override-me/Service/kafka-ui: namespaces "override-me" not found'

# All our args:
$ kubectl get kluctldeployments.flux.kluctl.io default -o json | jq .spec.args
{
  "kafka": false,
  "kafka-ui": false,
  "vars": {
    "namespace": "foo",
  }
}

# overrided name, but not others:
  rawTarget: |
    name: BAR
    args:
      kafka-ui: true
      vars:
        namespace: override-me

Yes, it's just an example that something is overrided. Args work the same in both cases.

Hmm, are you just looking at rawTarget to determine if it worked? I've just verified that the rawTarget does not take arg overrides into account, it is really just a 100% copy of what you've put into .kluctl.yaml.
Is it possible that the error you see is not actually or at least directly related to the args override?

I managed to reproduce this and fixed in https://github.com/kluctl/kluctl/pull/240. Next controller release will contain this fix.


Support for Xiaomi Mijia Sweeping And Mopping Robot M30S D103CN

Can you add support for Xiaomi Mijia Sweeping And Mopping Robot M30S D103CN?
I checked miot-spec and it looks a bit like xiaomi.vacuum.c102cn.
After that, I downloaded this integration (
v<IP_ADDRESS>b15), then added my device to custom_components/dreame_vacuum/config_flow.py. I also replaced protocol.py with https://raw.githubusercontent.com/Tasshack/dreame-vacuum/dev/custom_components/dreame_vacuum/dreame/protocol.py
Almost everything works except for a few things, most importantly Current Map and Current Room. But I can control room cleaning via Saved Map and I even generate rooms config using Vacuum Map to control cleaning by room. I also see the correct room names in the states.
List of all unavailable properties:

Clear Warning
Cruising History
Current Map
Current Map Data
Current Room
Floor Material Room Unavailable
Map Rotation
Mapping Time
Mop Pad Humidity Room Unavailable
Off-Peak Charging End
Off-Peak Charging Start
Order Room Unavailable
Room Name
Selected Map
Self-Clean
Suction Level Room Unavailable

Checked the logs and found the error:

"Map data decryption failed: Invalid IV size (0) for CBC.... Private key might be missing, please report this issue with your device model"

Additional Information

Model Name - xiaomi.vacuum.d103cn
Firmware Version - 4.3.9_1205
Home Assistant Version: 2024.06.2
Configuration Type - With  map support + cloud connection
Errors or warnings shown in the HA logs (if applicable):

"Map data decryption failed: Invalid IV size (0) for CBC.... Private key might be missing, please report this issue with your device model"

Thank you. Having looked at the previous issues, that's what I thought. Otherwise, even without the current map it is already possible to fully utilize the integration and use the automations.

The card's working.

There are still a few inaccessible propetries left, but they have more to do with the settings of the device itself. Funnily enough, I had previously seen an AI recognition setting that is not announced in this model and enabled it. It's not there now, but there is something similar to curtains on the map. Thank you very much.
List of unavailable properties(if it could be useful):

Auto-Add Detergent
Base Station Self Repair
Carpet Boost
Cleaning Mode Room
Cleaning Progress
Cleaning Times
Clear Warning
Cruising History
Floor Material
Mapping Time
Mop Pad Humidity
Off-Peak Charging End
Off-Peak Charging Start
Reset Detergent
Saved Wifi Map 1
Self-Clean
Suction Level

Share the vacuum, to acc<PHONE_NUMBER>.
Name - Vaccuum M30

Checked customization room properties. They are only available when the Customized Cleaning option is enabled.
I was just unloading in bulk and the room names in the parameters got wiped out.  That is, when the Customized Cleaning parameter is enabled, the general parameter (e.g. Cleaning Mode) becomes unavailable, but the parameters for each room become available.

Enjoy. Whenever convenient.
Thank you for your help.

@Tasshack There are also no settings for cleaning zones, only for rooms. In the application, when you select zone cleaning, you can select the standard settings for the cleaning mode.

It also seems camera obstacle identification/carpet sensor and mop swing are having issues.. mop swing issue on my device could be hardware failure.

@nmwael There is no carpet sensor in this vacuum cleaner model. The position of the carpet is indicated manually.

ahh so its not covered by the obstacle identification?

Is it correct that mop pad swing capability is not available?

why its may not working?

Uploading home-assistant_dreame_vacuum_2024-11-16T13-10-04.574Z.log…

@Dzhiday I cant see your log?

sorry. attach it again.
home-assistant_dreame_vacuum_2024-11-16T13-10-04.574Z.log

yea its strange, you have these lines in your log:
2024-11-16 17:03:09.932 WARNING (SyncWosrker_2) [custom_components.dreame_vacuum.dreame.protocol] Error while executing request: https://api.io.mi.com/app/v2/homeroom/gethome HTTPSConnectionPool(host='api.io.mi.com', port=443): Read timed out. (read timeout=5) 2024-11-16 17:03:16.917 ERROR (SyncWorker_2) [miio.miioprotocol] Got error when receiving: timed out 2024-11-16 17:03:16.940 WARNING (MainThread) [custom_components.dreame_vacuum] Integration start failed: Traceback (most recent call last):
I have the first one once in a while too..

so, what i must to do?))


Firefox can't open this page

I have been having this issue whenever I search anything where Firefox says:

Firefox Can’t Open This Page
To protect your security, www.google.com will not allow Firefox to display the page if another site has embedded it. To see this page, you need to open it in a new window.

I am not sure how to fix this as it is an issue with Firefox and I have not found anything in https://about:config that will help

It is blocked by default on browsers for many security concerns. However, I am not using any x-frames to render any page, which is odd.

Are you able to launch google.com without www?
You might have some firefox settings or extensions to explicitly disable launching pages with _self with some functionality required for such applications.
For a workaround as firefox mentioned, using targets as _blank instead of _self should keep it working if you do not want to hassle with security settings and such.

Please let me know what happens
For future reference, this issue is related to a security topic of Firefox located in https://support.mozilla.org/en-US/kb/xframe-neterror-page

ty i will look into what you are saying

YES, i fixed it by changing the target to _blank from _self as you described. tysm


Simpler notebooks

Hi @thawn ,
I know it's much to short-dated. Feel free to ignore this suggestion.
I think the filtering notebook seems to complicated for beginners. Consider replacing it with a simpler one, which pretty much only contains one-liners that apply filters. If you take the simpleitk-notebook, remove all cells but 3-4 where different filters are applied.
Thanks!
Best,
Robert

I like the filtering notebook, because it illustrates well how the image is formed (which ties in well with the presentation and also with other parts of the DIGS-BB LM course). I agree that the code is quite complicated, but I was planning to explain the code more on a high level not line-by-line. Also, I shortened the presentation to ~30 min so we have 45 min for the two notebooks.
Maybe we can briefly discuss the pros and cons in person later today?


Add missing state transition path

Description
According to the state descriptions, reboot is only entered/exited when the device actually reboots, and if not, the state would probably transition to ArtifactCommit directly, right?
If that is true, I'd convert this PNG to a drawio PNG which can be edited with a draw.io/diagrams.net editor (sources are included in the PNG text area). (Unless the source is already drawn in draw.io?)

I'd also like to have that clarified:

Therefore it is important to remember that when deploying a new update, all scripts will be run from the currently running root file system until ArtifactInstall, at which point the scripts from the new Artifact will take over.

Is this true also for rootfs updates? Will the ArtifactInstall_Leave be run from the new rootfs on the other partition? Will it be copied to the current partition? Or is the rootfs update a special case where the old scripts until ArtifactReboot_Enter run and after rebooting the scripts from the new rootfs partition are run (i.e. ArtifactReboot_Leave and onwards)?

According to the state descriptions, reboot is only entered/exited when the device actually reboots, and if not, the state would probably transition to ArtifactCommit directly, right?

Hey @Granjow, you're right, this transition is missing from the diagram. I have added them here.

If that is true, I'd convert this PNG to a drawio PNG which can be edited with a draw.io/diagrams.net editor (sources are included in the PNG text area). (Unless the source is already drawn in draw.io?)

They are hosted as Google Draw documents, which unfortunately aren't public, but you can see the result in the link I posted.

I'd also like to have that clarified:

Therefore it is important to remember that when deploying a new update, all scripts will be run from the currently running root file system until ArtifactInstall, at which point the scripts from the new Artifact will take over.

Is this true also for rootfs updates? Will the ArtifactInstall_Leave be run from the new rootfs on the other partition? Will it be copied to the current partition? Or is the rootfs update a special case where the old scripts until ArtifactReboot_Enter run and after rebooting the scripts from the new rootfs partition are run (i.e. ArtifactReboot_Leave and onwards)?

I think there is a misunderstanding: It says is that "the scripts from the new Artifact" will take over, not that it's switching root filesystem. It means that the scripts are taken from the new artifact, but it has not rebooted yet, so the operating system is still using the old root filesystem. The scripts are run from the data partition, so they are not copied to either of the active/passive rootfs partitions.
Closing this PR, since it is superseded by #1582.

@kacf Thanks for your answer and the updates to the diagrams!
Regarding the rootfs update, I have to state the question a bit more precisely. The docs simply states that at ArtifactInstall the new scripts will take over. I assume there are two different use cases:

If a reboot is not required, e.g. when installing some piece of software which also installs a state script, then ArtifactInstall will add/overwrite the existing state script and already ArtifactInstall_Leave will use that new script.
If a reboot is required due to a rootfs update, then ArtifactInstall sets up the other partition. So all state scripts that are included in the new version are on the new partition. In that case, I'd assume  that ArtifactInstall_Leave still only considers the state scripts of the old artifact, and so does ArtifactReboot_Enter, and after ArtifactReboot, the state scripts from the new artifact (partition) will be used, i.e. from ArtifactReboot_Leave  on onwards.

Is that correct?

No, that's not correct. All state scripts that start with "Artifact" do not exist on the filesystem at all, so there are no "existing scripts". The "Artifact" scripts are taken from the Artifact and are temporarily stored on the data partition while the installation is happening. Then they are deleted afterwards.

@kacf Okay. How would that work in case of rootfs updates? Can they also contain Artifact* scripts or not?

Okay. How would that work in case of rootfs updates? Can they also contain Artifact* scripts or not?

Yes, they can.


add -v flag to cli

Print the version number and exit if -v or --version is given when
running from the command line.

Coverage decreased (-0.3%) to 79.65% when pulling 5eb4e0ff1b1eecbcb8ac2b6f78f0ecbdce681dbe on collingreen:feature-print-version into 3dc2e9d055f83f0a19177ba22f1654415f6e9b33 on Miserlou:master.

Noice


SPMV Invalid Configuration Argument

Summary: The cub::DeviceSpmv::CsrMV function frequently fails with error: invalid configuration argument (9) due to incorrect kernel launch bounds.
Example Program:
#include <thrust/device_vector.h>
#include <iostream>
#include <cub/cub.cuh>  // or equivalently <cub/device/device_spmv.cuh>

#define CHECK_CUDA(func)                                                   \
  {                                                                        \
    cudaError_t status = (func);                                           \
    if (status != cudaSuccess) {                                           \
      printf("CUDA API failed at line %d with error: %s (%d)\n", __LINE__, \
             cudaGetErrorString(status), status);                          \
      return EXIT_FAILURE;                                                 \
    }                                                                      \
  }

int main(int argc, char** argv) {
  // Determine temporary device storage requirements
  void* d_temp_storage = NULL;
  size_t temp_storage_bytes = 0;

  int num_rows = 1000;
  int num_cols = 1000;
  int num_nonzeros = 20;

  thrust::device_vector<float> d_values(num_nonzeros, 0);
  thrust::sequence(d_values.begin(), d_values.end()); // 0,1,2,...

  // float* d_values;  // e.g., [1, 1, 1, 1, 1, 1, 1, 1,
  //        1, 1, 1, 1, 1, 1, 1, 1,
  //        1, 1, 1, 1, 1, 1, 1, 1]

  thrust::device_vector<int> d_column_indices(num_nonzeros, 0);
  thrust::sequence(d_column_indices.begin(), d_column_indices.end());
  // int*   d_column_indices; // e.g., [1, 3, 0, 2, 4, 1, 5, 0,
  //        4, 6, 1, 3, 5, 7, 2, 4,
  //        8, 3, 7, 4, 6, 8, 5, 7]

  thrust::device_vector<int> d_row_offsets(num_rows, 0);
  thrust::sequence(d_row_offsets.begin(), d_row_offsets.end()); // 0,1,2,...
  // int*   d_row_offsets;    // e.g., [0, 2, 5, 7, 10, 14, 17, 19, 22, 24]

  thrust::device_vector<float> d_vector_x(num_rows, 0);
  thrust::fill(d_vector_x.begin(), d_vector_x.end(), 1);
  // float* d_vector_x;       // e.g., [1, 1, 1, 1, 1, 1, 1, 1, 1]

  thrust::device_vector<float> d_vector_y(num_rows, 0);
  // float* d_vector_y;       // e.g., [ ,  ,  ,  ,  ,  ,  ,  ,  ]

  CHECK_CUDA(cub::DeviceSpmv::CsrMV(d_temp_storage, temp_storage_bytes,
                                    d_values.data().get(), d_row_offsets.data().get(), d_column_indices.data().get(),
                                    d_vector_x.data().get(), d_vector_y.data().get(), num_rows, num_cols,
                                    num_nonzeros, 0, true));

                                    CHECK_CUDA(cudaDeviceSynchronize());

  // Allocate temporary storage
  CHECK_CUDA(cudaMalloc(&d_temp_storage, temp_storage_bytes));

  printf("Allocated %d bytes of temp storage\n", temp_storage_bytes);

  // Run SpMV
  CHECK_CUDA(cub::DeviceSpmv::CsrMV(d_temp_storage, temp_storage_bytes,
                                    d_values.data().get(), d_row_offsets.data().get(), d_column_indices.data().get(),
                                    d_vector_x.data().get(), d_vector_y.data().get(), num_rows, num_cols,
                                    num_nonzeros, 0, true));

  CHECK_CUDA(cudaDeviceSynchronize());

  CHECK_CUDA(cudaFree(d_temp_storage));
}

Output:
Allocated 1535 bytes of temp storage
Invoking spmv_kernel<<<{2,-1,1}, 128, 0, 0>>>(), 7 items per thread, 12 SM occupancy
CUDA API failed at line 62 with error: invalid configuration argument (9)

I believe this error occurs due to an incorrect gridDim.y calculated parameter. By varying num_rows, num_cols, and num_nonzeros in the example, it is possible to have this parameter be 1, 0, or -1.
This behavior occurs with both the CUDA 11.2 included CUB as well as the most recent CUB dependency within the Thrust library downloaded and compiled from Github. This error additionally occurs with many of the matrixes in the suitesparse collection, and is not an artifact of the toy matrix defined in the above program.
System Specs:
CPU: Intel Xeon E5-2698
GPU: V100
nvcc 11.2.152
g++ 9.3.0

It looks like there are a few things going on here...
The gridDim.y issue appears to have been resolved by 63e2ad4be6316c98db99b90f2d113096d6e96038. I consistently get {1, 1, 1} for the grid dimensions on the current main branch.
Once that was fixed, new errors were emitted from the issue described in #162. Applying #163 resolves that.
Looks like this can be closed once #163 is merged.

FYI, I've edited the repro script to fix a bug:
  thrust::device_vector<int> d_row_offsets(num_rows, 0);

⬇
  thrust::device_vector<int> d_row_offsets(num_rows + 1, 0);

(row_offsets must contain an extra element with the total number of non-zero elements)


[Bugs]  lr_mult, decay_mult unavailable in optimizer

Hi, I find a bug in the code: ops/models.py
In pytorch, lr_mult, decay_mult is not available parameter, I guess this is because the original code is transformed from caffe which support these paramters.
        return [
            {'params': first_conv_weight, 'lr_mult': 5 if self.modality == 'Flow' else 1, 'decay_mult': 1,
             'name': "first_conv_weight"},
            {'params': first_conv_bias, 'lr_mult': 10 if self.modality == 'Flow' else 2, 'decay_mult': 0,
             'name': "first_conv_bias"},
            {'params': normal_weight, 'lr_mult': 1, 'decay_mult': 1,
             'name': "normal_weight"},
            {'params': normal_bias, 'lr_mult': 2, 'decay_mult': 0,
             'name': "normal_bias"},
            {'params': bn, 'lr_mult': 1, 'decay_mult': 0,
             'name': "BN scale/shift"},
            {'params': custom_ops, 'lr_mult': 1, 'decay_mult': 1,
             'name': "custom_ops"},
            # for fc
            {'params': lr5_weight, 'lr_mult': 5, 'decay_mult': 1,
             'name': "lr5_weight"},
            {'params': lr10_bias, 'lr_mult': 10, 'decay_mult': 0,
             'name': "lr10_bias"},
        ]

Hi, I agree that the code piece from TSN is a little hack to support different learning rate, but it should work fine with PyTorch. Do you find that it leads to bugs when running the code?

The related code is here: https://github.com/mit-han-lab/temporal-shift-module/blob/master/main.py#L362

Yes, the code can run.
However, the code mislead people who want to adjust the lr of different part of the layers. I am doing transfer learning projects and need to set the backbone  with smaller lr. I changed the parameter of lr_multi but it does not work and it costs me lots of time to fix the bug.
Since this project  already have near 1k stars, I guess it would be better to fix the bug so that it would not mislead other developer.
Again, thanks for your great work.

Yes, I will refactor this part to make it more clear when time permits.


Update mdm-enrollment-of-windows-devices.md

https://github.com/MicrosoftDocs/windows-itpro-docs/issues/2518
Added acronym descriptions.

@nenonix @JohanFreelancer9 Copy editing is needed for this PR. Thanks.

Looks good to me™. The suggestion can be merged by the PR author.


pull request for e2e test at 12/17/2016 01:45:18

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


F-Droid packages was broken

:clock11: When did the problem start?
No idea. At least 2 days.
:camera: Live badge
https://img.shields.io/f-droid/v/com.unciv.app

:information_source:
https://f-droid.org/api/v1/packages/com.unciv.app lists zero packages, which is untrue.
:bulb: solution
No action necessary. This is just to inform you that F-Droid fixed it, it will start working again soon.

Update: The API is fixed, but the badge still wrong. How long do you cache this stuff???

Damn right I'm blind. And mr whatshisname said that would be transparent to consumers... I still feel it would be better you adapted. It's not only Unciv.


encoding/binary uses wrong size for struct while using Read

I have a struct layed out like this
`type exitStatus struct {
Termination uint16
Exit        uint16
}
type utmp struct {
Type       uint16
Pid        uint32
Line       [UT_LINESIZE]uint8
ID         [4]uint8
User       [UT_NAMESIZE]uint8
Host       [UT_HOSTSIZE]uint8
ExitStatus exitStatus
Session    uint32
Sec        uint32
Usec       uint32
Addr6      [4]uint32
_          [20]uint8
}`
I am trying to use encoding/binary Read to read data into the utmp struct, but for some reason it treats that struct as a size of 382 (dataSize() in encoding/binary.go:339 returns 382) for data size which leads the Read function to read it wrong.
reflect.TypeOf(utmp).Size() and unsafe.Sizeof() gives me size 384 though.
I am using Go 1.6beta2 on Linux AMD64.

There is a two byte padding between Type and Pid. The compiler (and unsafe)
enforces struct padding, but encoding/binary only consider real fields so
you must use _ field to fill the two padding bytes.
This is working as intended.

Two bytes of padding exist between Type and Pid

On 7 Feb 2016, at 15:44, Quan Tran<EMAIL_ADDRESS>wrote:
I have a struct layed out like this
`type exitStatus struct {
Termination uint16
Exit uint16
}
type utmp struct {
Type uint16
Pid uint32
Line [UT_LINESIZE]uint8
ID [4]uint8
User [UT_NAMESIZE]uint8
Host [UT_HOSTSIZE]uint8
ExitStatus exitStatus
Session uint32
Sec uint32
Usec uint32
Addr6 [4]uint32
_ [20]uint8
}`
I am trying to use encoding/binary Read to read data into the utmp struct, but for some reason it treats that struct as a size of 382 (dataSize() in encoding/binarygo:339 returns 382) for data size which leads the Read function to read it wrong
reflectTypeOf(utmp)Size() and unsafeSizeof() gives me size 384 though
I am using Go 16beta2 on Linux AMD64
—
Reply to this email directly or view it on GitHub.


Fix validations failing when files are deleted from the validation directory

Files.walk() reads attributes from the files being walked. This requires the file to continue to exist between the directory scan and reading the attributes. If the file ceases to exist, an UncheckedIOException is thrown causing the validation to fail.
This PR removes reading file attributes except for testing if the path is a directory when discovering repositories. If the file stops existing Files.isDirectory() returns false and the validation continues.

@alencessda Could you take a look?


Tagging system is unstable - gives suggestions that don't exist in taxonomies.

I'm experiencing weird issues when selecting a country or a concept in the new tagging system. When starting to typ, the fields give you suggestions from the taxonomies but also apparently keywords that don't actually exist in the taxonomy - giving you an error.
Example country taxonomy:
Sometimes it selects a country without a capital letter, for example: I type in "Brazil", it selects "brazil", and then when I want to publish it - it says "illegal choice detected" and the geographical focus field appears empty. Then I type in Brazil again and I have the choice to select "brazil" and "Brazil". The last one is the only one that exists in the country taxonomy, so that one does not give an error. However, even when I start typing "Brazil", it will give "brazil" on the top of the list so if I hit enter quickly, that's the one it selects -- giving me the error. See below:

(Unfortunately not in the screenshot, but the geographical focus field was empty below).
Second example LandVoc concepts:
I typed in "security of tenure" and then I'll hit "security of tenure (land)", which is the LandVoc concept that I know. The field gives "security of tenure" (as is) as a suggestion and I'm able to select it and everything. Though I know that does not exist in LandVoc, nor is it listed as a synonym of "security of tenure (land)" -> https://landportal.info/voc/landvoc/concept/security-tenure-land
I had more concepts in the fields so it didn't give me an error, but when I was redirected back because of the geographical focus error, I noticed that the concepts that didn't exist in LandVoc were automatically deleted from the field.
So to sum up: the suggestions given by the fields should ONLY be those concepts that actually exist in our taxonomies !

From hangouts

ok I think I can explain it at least
Lisette what you actually "validated" / put in the field is what you typed
not the selection, which is confusing because in the dropdown, apparently, the first item is what you type not an existing term
(...)
what is true though is that is should validate the options and not let you put as a tag (letting you think its ok) something that doesn't exists
maybe just validation can help

fixed: no more "new" tags


[entropy_src] change of HEALTH_TEST_WINDOWS.FIPS_WINDOW and watermarks

Description
Default FIPS_WINDOW is set to 0x200, representing 2048 bits. If this window is set to a different value, e.g. 0x100 (1024 bit window), values in *_WATERMARK are not reset, and become useless as they immediately outside of the range.
Interplay for FIPS_WINDOW and configuration for health checks needs some clarification - it seems HI/LO values have to be recalculated, but it is not clear how window size impacts counters in different modes - 1 or 4 bit, scope combined or individual (CONF . THRESHOLD_SCOPE. E.g. for Markov test with default config watermark HI/LO values seems to be around 0x80 - which is 1/4 of 0x200 FIPS_WINDOW, but it is unclear from documentation why it is like that.

Test issue. Watermarks seems to be updated.


Ratings/Reviews Functionality

Ratings Model

Fields: vendor id, merchant id, star rating, comment, date reviewed
Query for ratings from the User Vendor model

Add rating logic: Merchant view -> Orders tab

"Show Rating" toggle only on vendor-approved orders

Show previous rating/review (if exists) and prevents 0 star rating/empty review
![screen shot 2016-04-10 at 10 45 29 am]
(https://cloud.githubusercontent.com/assets/5404536/14410988/919a4336-ff0a-11e5-8520-4bb5c86ce9fd.png)
Add star rating to Merchant view -> Listings tab

If exists, otherwise don't show anything

Add star rating and 3 reviews to Merchant view -> Vendor item overview

Reviews sorted on date reviewed (most recent to least)
Link to see all reviews for the vendor

Add view all ratings page + ratings breakdown to Merchant View

Breakdown of reviews: see total number of reviewers and percentage breakdown by the different star ratings
Pagination for all reviews along with their ratings sorted by decreasing date reviewed

Other

Mentioned where to add review in approve order email sent when Vendor approves a Merchant's order

TODO

Link to the orders page to review inside the approve order email?
Getting flash to work on orders page (flash error when merchant tries to leave 0 star rating or empty review)
More rigorous testing with multiple vendors (tested for multiple merchants already)
Styling

Fix the flash issue per the comment i suggested and you should be all set.


Syntax error in code block breaks document syntax highlighting

Initial checklist

[X] I read the support docs
[X] I read the contributing guide
[X] I agree to follow the code of conduct
[X] I searched issues and couldn’t find anything (or linked relevant results below)

Affected packages and versions
unifiedjs.vscode-mdx v1.8.9
Link to runnable example
No response
Steps to reproduce

Create a new MDX file in VS Code
Copy the following code in to the document (note the missing closing bracket):```ts
console.log('hi'
```

<Example prop="test" />

Expected behavior
The MDX code following the code block <Example prop="test" /> should be syntax highlighted correctly, as it is when the code block is valid:

Actual behavior
The MDX code following the code block is not syntax highlighted correctly.

Runtime
VS Code 1.92.1
Package manager
No response
OS
macOS
Build and bundle tools
No response

Heya!
Why you put syntax errors in code? 🤷♂
Like, if I write broken typescript in VS code, it also highlights “weirdly”?

Hey @wooorm. I can think of several reasons why you might do this. You might be documenting what not to do, or your code snippet may be a partial snippet that is not syntactically valid on its own, for example:

Change the function name to be foo:
function foo() {

Although I personally think that code snippets should be syntactically valid where possible, I think this is absolutely a valid thing to do and something that should not affect document syntax highlighting.

Like, if I write broken typescript in VS code, it also highlights “weirdly”?

Code inside a MDX/Markdown code block is typically not executed so syntactic validity is not important in the same way. Also, the syntax highlighting inside the code block looking weird is expected, but code block syntax highlighting should be isolated from the MDX document highlighting, in my opinion.
For what it's worth the Markdown language is VS Code doesn't have this issue.

But why call it TS if it is broken? I have started using ```mdx-broken when I show broken MDX, and the like.
With rehype-twoslash, which you can see in use on the MDX website, the javascript/typescript is evaluated.

Anyway, it’s a duplicate of https://github.com/wooorm/markdown-tm-language/issues/9, it’s already done

This looks similar to, but not the same as, https://github.com/microsoft/vscode/issues/224862. I agree ideally broken code blocks shouldn’t break syntax highlighting.
The linked issue was acknowledged to be a bug upstream and fixed, but there was a hint on how the MDX grammar could be improved to handle that situation in https://github.com/microsoft/vscode/issues/224862#issuecomment-2269917129.
Syntax highlighting of code blocks after can be broken due to unforeseen bugs in arbritrary grammars. I think this example is a bit silly, but it makes sense. Also I imagine it can be annoying if MDX highlighting outside the codeblock changes every time you open or close a quote inside a TypeScript code block.

@remcohaszing ping to make sure you saw my last comment.

Anyway, it’s a duplicate of https://github.com/wooorm/markdown-tm-language/issues/9, it’s already done

This does look like the same issue, thanks! Sorry I didn't find that earlier. Do you have an idea of when the fix will land in the MDX extension?

I agree ideally broken code blocks shouldn’t break syntax highlighting.

💯

It’s similar, but not a duplicate. https://github.com/wooorm/markdown-tm-language/issues/9 / https://github.com/microsoft/vscode/issues/224862 was explicitly about the YAML grammar being broken upstream. That’s fixed.
Based on https://github.com/microsoft/vscode/issues/224862#issuecomment-2269917129 I think we can be more defensive against broken grammars in code blocks (and frontmatter). I’m not going to pretend to fully understand these grammars though. I could easily be wrong.

No, the issue is not about yaml. It's about code.
The solution is for the grammar to be pulled into this project

Oh wow, I totally misread that and was mixing up things. You’re right, this is fixed upstream already


Translation information in README.md

I'm dreaming of making Translation Gang an international community of open-source translators, so there's a little bit of advertisement here, not just the information on existing translation projects.

I don't mind the advertisement if it could lead to a more thriving translation community. 🙂  Can you tell me more about what you hope to do with Translation Gang? And do you want to add a contact link in that section?

Well, there are many amazing open-source projects worldwide, and there are many awesome people ready to help with translations of these projects` documentation. But the issue is that it's enthusiasm is not a constant thing, while good project's life is long. So, there should be an organisation "in charge", taking responsibility for both completing translations and maintaining the docs in actual condition.
I seem to have succeeded in organising Translation Gang as a translators community for Russian language and Vue-related projects: while the core library docs were translated by me almost alone, at the stage of proof-reading there were already tens of people, and Nuxt.js docs were recently translated in a matter of days with only about 10% of actual translation done by me. And we also seem to be quite good at maintaining the docs in actual condition — for most of original docs updates the latency with translation is less then a day, normally just some hours.
So, Russian is not the only language which could benefit from the organised workflow, and Vue is not the only project we're interested in. Which means, we need more enthusiastic people =)
Also, there are good projects developed by people not so good at speaking English as writing the code. And these projects also could benefit from the involvement of the organised open-source translation community.
So, basically, I just want to make this world a bit better, if you could forgive me this high style =)

And about the contact link — I've simply used the VCard link as there are no private messages at GitHub AFAIK, so I guess it's better to give an interested person a way to contact me, not just a github nickname.

@gbezyuk Have you added the VCard link? I'm happy to merge this after that.

@chrisvfritz done ;)

BTW, @kazupon could you please add information on Japanese translation?

Vuetiful! 😉

@gbezyuk Yes, I could add information about japanese translation!


align wording

Algin the wording with the web https://github.com/mangelio/web/issues/247

There are two steps to this issue:

Resolve the issues as specified in #247 now
Resolve any other consistency issues as part of an enhancement (to be done later).

All right, I went through and applied the changes. I'd appreciate some input on these summaries, since they're still a little wordy and perhaps unclear.

Ok thanks. I have readded the enhancement label.

Moved to Trello.


Fixes a bug in avroio_test.py

Fixes a bug in avroio_test.py where we open a binary file without 'b' mode. Without this, file can get corrupted in Windows and the test becomes flaky.

R: @robertwb
Travis failure seems to be unrelated.

LGTM

This can be closed now.

Thanks.


Tweaking and Removing Various Questions

So I have many reservations about multiple questions, I did not know whether or not to to make them individually, so I just did it together for now. In order:

Oppression by corporations is more of a concern than oppression by governments:  "econ": 10,  "govt": 0,
The current form of this question should see a "govt: -10", because it's MORE of a concern. However this is a bad solution, as it would make an anarcho or libertarian leftist less on the economic scale, which if anything they should be more as many "strongly agree" here would be supporters of a planned economy.
So instead it should be this: Oppression by corporations is as much a concern as oppression by governments, as the current "default" in our society would be "disagree"

It is better to maintain a balanced budget than to ensure welfare for all citizens
This is a badly worded question as it implies that ensuring welfare would not be a "balanced budget". Which wouldn't make any sense for someone disagreeing with this.

Publicly-funded research is more beneficial to the people than leaving it to the market.:  "econ: -10", "scty": 10
The reason why "scty":10 is bc of ppl who would disagree with the notion of supporting research. However those people, an anarcho primitivist or perhaps a feudalist would disagree with the notion of a market itself. Theoretically I suppose you could, but it would be illogical to require them to be so.
The only solution to this question would honestly be to remove the society aspect of it, as that would also imply that a market would be bad for progress, which is not objective.

Taxes should be increased on the rich to provide for the poor
The idea of taxes conflicts with a revolutionary belief for the end of capitalism, so someone who would probably be even more for economic equality should say no, which would be wrong.
There is no good solution, it's a problem with just a yes no statement, but you could invert the question, or maybe add a clause.

Government intervention is a threat to the economy.: "econ":-10,  "govt": 0,
Many libertarian socialists would say that the government is a threat to the economy, and that only workers control it.
So it should be just "intervention".

The means of production should belong to the workers who use them: "econ":-10,  "govt": 0,
This implies that the government should not control them, so it should be -5, though this is a very small gripe as it is not wrong

My nation is great:  "dipl": -10, "govt": 0,
This is just a bad question overall, let alone what it does. Who's nation? Is this the government's actions? What type of government? The place that is literally is? All of which yield different results, it's just bad.

My religious values should be spread as much as possible.
What if you're an atheist? Or a believe in a new age religion like of spirituality or something? Those are both religious values, so it should be "traditional religious values".

Our nation's values should be spread as much as possible.  "dipl": -10, "govt": -5,
This is a bad question because "values" is unclear. Someone may believe say equality is an "American value" but doesn't believe that America should spread it, or that it does or embodies those values. It's a bit confusing. And what if your "nation's values" is of international cooperation or of democracy and freedom and an unpowerful state.

It is very important to maintain law and order
This is terrible, because no political ideology believes in the opposite. Anarchism is not chaos, it's just democracy. Anarchists are more likely to believe their ideology is more orderly, for example in it's opposition to war or the abolishment of the material forces that makes people commit crimes (poverty). So it actively hinders an accurate result.

Physician-assisted suicide should be legal   "govt": 10,"scty": 0
This should have an increase for "society".

Regardless of political opinions, it is important to side with your country.
This is a very narrow question which really doesn't cover even the most authoritarian or nationalist people. Because it's not a question of ideology or even nationalism.

A hierarchical state is best
The definition of a state is a hierarchy. With this implication of a non hierarchal state, this pulls into question things like "the very existence of a state is a threat to our liberty", because if a state is just a system of governance, no ideology believes in the alternative to one, as stated before.

Democracy is more than a decision-making process.
This means nothing. And even if it did, which I wouldn't even see how, nobody apparently does know what it means, and things shouldn't be so difficult that you can't even look it up, because it isn't a quote or anything like "each according to ability" which is just a bit confusing.

If we accept migrants at all, it is important that they assimilate into our culture."dipl": 0, "govt": -5,"scty": -10
There should be an increase for dip, this is actually a much more dip question then govt and maybe even scty. It's all about national identity of a nation state, what an agreer would use as justification.

It is important that we further my group's goals above all others  "econ": -10, "dipl": -10, "govt": -10, "scty": -10
This should specify your identity group like race and/or nationality, and perhaps also remove "further and goals", as I have seen many people interpret this as your political group, which is a no brainer for anyone and they see it as just how radical you are in general, which is not baked into the code.

I don't quite understand your opposition to 2. The question is just asking if it's worth a nation going into debt to ensure the welfare of its citizens.

@John-Ingram The issue is that there are 2 completely unrelated topics addressed in one question. For example, I believe that we should provide for our people, but I also believe that we should cover the cost through appropriate taxation rather than through the issuance of debt (as I don't believe there is any benefit to society from governments paying our tax dollars as interest payments on loans)
How should I answer that question?  In its current form I have to either agree that taking on debt is good, or agree that we shouldn't help those who need it. I don't believe either.

How should I answer that question? In its current form I have to either agree that taking on debt is good, or agree that we shouldn't help those who need it. I don't believe either.

It seems to me like a question of priority. Maybe changing the wording to reflect that more obviously would make sense.
something like "if you could only have one" might make it clearer.

If the question is really asking about whether you think it's worth spending money to help people. Ask that question instead of talking about debt, for example:
It is better to save the government money than to ensure welfare for all citizens.
I'm still not sure that's quite right, but I feel it's a better question than the current false dichotomy.

How about this:

It is more important to place limits on government spending than to ensure welfare for all citizens

I think with maybe a tweak or two to the wording something like this might be better.

I'm wondering if that might still bias the question a little bit?
Keep in mind that even those opposed to government spending usually believe that that opposition will lead to greater welfare for the population. This wording would make it clear that the trade-off is in regards to the government spending rather than simply in regards to an overall greater outcome.


HDXDSYS-1159  HDX Python Database - output errors if pg_restore fails

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.2%) to 94.306%

Totals

Change from base Build<PHONE_NUMBER>5:
-0.2%

Covered Lines:
265

Relevant Lines:
281

💛  - Coveralls


Improve file found in multiple build targets warning

What does this PR try to resolve?
close https://github.com/rust-lang/cargo/issues/11248.
Improve file found in multiple build targets warning. This PR tries to print the target name and kind in the warning message.
How should we test and review this PR?

[x] Unit Test

@ehuss Friendly ping~
Could you please take a look? Thanks!

@bors r+

:pushpin: Commit 7eadd58eef88239238159847458cba843f011644 has been approved by weihanglo
It is now in the queue for this repository.

:hourglass: Testing commit 7eadd58eef88239238159847458cba843f011644 with merge 324a935e044a981d6f32faefc0d28310e4420ef1...

:sunny: Test successful - checks-actions
Approved by: weihanglo
Pushing 324a935e044a981d6f32faefc0d28310e4420ef1 to master...


[macOS] Check for if_utun.h and provide needed defines, if the header is missing

@yarrick MacOS prior to released version of 10.6 does not have net/if_utun.h. The header itself in 10.6.8 is trivial though; perhaps, it can be checked in configure and it not detected, we can add required defines from 10.6.8 version?
:info:build make: Entering directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_net_iodine/iodine/work/iodine-0.8.0'
:info:build make[1]: Entering directory `/opt/local/var/macports/build/_opt_PPCSnowLeopardPorts_net_iodine/iodine/work/iodine-0.8.0/src'
:info:build CC tun.c
:info:build CC read.c
:info:build CC dns.c
:info:build CC encoding.c
:info:build CC login.c
:info:build OS is DARWIN, arch is Power Macintosh
:info:build CC base32.c
:info:build tun.c:34:25: error: net/if_utun.h: No such file or directory
:info:build CC base64.c
:info:build tun.c: In function ‘open_utun’:
:info:build tun.c:377: error: ‘UTUN_CONTROL_NAME’ undeclared (first use in this function)
:info:build tun.c:377: error: (Each undeclared identifier is reported only once
:info:build tun.c:377: error: for each function it appears in.)
:info:build tun.c:406: error: ‘UTUN_OPT_IFNAME’ undeclared (first use in this function)
:info:build Making base64u.c
:info:build CC base128.c
:info:build make[1]: *** [tun.o] Error 1
:info:build make[1]: *** Waiting for unfinished jobs....

This is on 10a190 build of 10.6. I borrowed the header from 10.6.8 SDK, and build worked fine then.

Does utun still work if just the header is copied over? Or does it have to use the normal tuntap device?
I guess disabling utun is the safer thing to do in this case.

Or I guess it will just fail in setup so it should be safe to try anyway. Submitted something, lets see if it builds.

Looks like it worked.


Build Catapult in CI using Jenkins and s2i with binary content

Don't trust s2i to know how to build the WAR; we'll want to use a builder image which has Jenkins and a job that passes the correct shell commands to Maven and to copy the WAR.  At the moment we get by due to changes in #110 eb7e9495901c7419ae4f496dd1cbd830156a9f66, but this is a stopgap

FYI @sabre1041, as discussed (I'll handle this later at some point and we'll take it on as tech debt until after Summit if needed)

Closing as part of our real testing strategy is stopgap handled by ci.centos.org at the moment, and we'll move to OSO Paid when we can


Investigate floating point read pixels

According to the spec, if either the extension EXT_color_buffer_float or EXT_color_buffer_half_float is enabled, then it is possible to call gl.readPixels with floating point input.
I've not confirmed this or verified that it works yet, but if true then this we should modify regl.read() to support this behavior.

I will take care of this.

But neither of those extensions are supported for me. They aren't supported on my Macbook running Intel integrated graphics, and neither on my stationary desktop running GTX960. Do you have it? Check here:
http://webglreport.com/

Nope, which is why I haven't implemented it yet.

well, then it is very hard to implement right now...

lol, Firefox implement  WEBGL_color_buffer_float , but not chrome! also the half-float one!

Like I said in the chat, due to spotty browser support, I am afraid we'll have to give up on using regl.read to read from floating point renderbuffers. However, we are able to use regl.read for floating point textures.

Due to spotty browser support, we decided on postponing this feature for now.


Web - Task - Checkmark is not automatically updated when assignee is not set

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: <IP_ADDRESS>
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:

Open a chat with another account (i.e account B)
Inside the chat click on plus icon in the composer
Click on assign task
Insert a title and click on next
Confirm the task without selecting an assignee
From account A click on the checkbox of the recently created task
Observe the task on account B

Expected Result:
The checkbox should update and change to being marked as done on account B right after the task is marked as done from account A.
Actual Result:
The checkbox stays unmarked even after the task was marked as done from account A
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/93399543/4842e605-bb01-4cd2-afc5-65aaec0d1434
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015113d6ac5682a883
Upwork Job ID:<PHONE_NUMBER>948653568
Last Price Increase: 2023-11-27

Production
https://github.com/Expensify/App/assets/93399543/6c812e9a-87d9-4f58-8dea-6964abdef130

hey @kbecciv can you try your production test again but don't assign the task? That seems to be the differentiator here. I'm seeing this bug replicated on production, so I want another set of eyes.
If it's indeed the case, this is a bug we should fix BUT it's not a deploy blocker. Thank you!

I am also able to reproduce it on prod..
I guess this is a backend pusher issue

This seems to be more so a backend issue, I will remove the deploy blocker label since its a last blocker

@dangrous able to reproduce in production.
https://github.com/Expensify/App/assets/43996225/07b28381-768f-4642-8d57-8b0addb682de

Great, thank you! We'll move forward with investigation but not as a blocker

Okay so two weird things:

participantAccountIDs when the task is completed from the creator's side only includes the creator. That's why it's not being sent. Not sure where this is occurring yet.
If you try to complete the task from the other account, there's a silent 411 Insufficient privileges error.

So I think somewhere the non-creator account is not being listed as a participant in the task, even though they should be. I think that would explain both bugs. TBD on a fix

Putting @thienlnam's comment from Slack here for posterity, will hopefully have time to chug through this this week:

Yeah I think we’d need to make sure all of those auth commands return the participants of the parent chat in $response['parentParticipants']['participantsAccountIDs'] , and then the parentReportActionID will need to have some more keys that represent the state of the task like childReportState or something similar (you’ll have to check what is returned currently)

Haven't had time for this this week, I will likely be able to look into it mid-next week at the earliest (trying to finish out the whatsnext budgets project)

as noted, no time yet. will get there.

I was out unexpectedly this week, this is somewhat low priority so I will hopefully be able to grab it next week

no update since above, hoping to get to this later this week

Maybe will have time this afternoon. But it's on my mind!

@thienlnam Can we get your advice on this one? I've finally had the chance to look into it, and I have a couple questions. So there are two issues:

The owner of a task completing it does not update the parent report for another user in the parent report.

But I'm confused as to why this is. Shouldn't this call to sendChildDetailsToParentAction send the status update to any participants in that report? Or does that not actually do what I think it does.

Another user in the parent report does not have the permissions to complete a task, until they've opened it.

Above, I mentioned that it is a 411 error, but I just tried it again and am getting 666 Cannot complete action which means it's now happening before it gets to the actual check for permissions. So how can we tell auth that that user should have permissions for the task? Do we need to change something on the creation side?

Shouldn't this call to sendChildDetailsToParentAction send the status update to any participants in that report?

I think you might have mis-linked but that method should do exactly that - I would maybe check if this has the parent participants correctly when it is being called but it should be sending that pusher update

Another user in the parent report does not have the permissions to complete a task, until they've opened it.

This is what I'm working on in here https://github.com/Expensify/Expensify/issues/339618, it turns out there's a lot of issues that come up when a user is not shared on a report. I believe we can fix this by just sharing the user to the report in the peek() of all these commands. Haven't tested it yet but should hopefully solve this problem

Oops yeah, I meant this - https://github.com/Expensify/Web-Expensify/blob/ac26ddb1425c58704478cc4f6d46347ff155d94c/lib/ReportAPI.php#L6089 - I looked at the stuff that it gets called with, and it had the right participants (i.e. everyone) but maybe wasn't sending the status along (but I don't really get why that would happen).
And great about the second question! I can focus on the first (unless you have ideas)

but maybe wasn't sending the status along (but I don't really get why that would happen).

Oh yes - you're on the right track here. That method needs to send back more parameters (i.e it's not passing back the childStateNum / childStatusNum)

Back now, will start trying to get this closed out tomorrow or later today

Dec 21, 2023

 Member

Ah lovely, this was it! Putting up a PR now.

Just tested this, it works nicely on prod now! I am going to close this - I don't believe any payment is due but @alitoshmatov (or anyone else?) please let me know if I am incorrect and we can reopen if needed!


Don't commit built code

Git is for source code, not compiled code :). Git diffs and logs are much harder to read when compiled code is committed, and the repo size is bloated. And Github is not a file host.

Hey @AndrewRayCode, we only commit built code in dist/ to provide a UMD bundle for CDN usage and for people who like that sort of thing. We only build these on tagged releases.

@tptee -- You may want to consider a future ticket of only publishing dist/ to npm and advising folks to use unpkg. E.g<EMAIL_ADDRESS>

Hey @AndrewRayCode, we only commit built code in dist/ to provide a UMD bundle for CDN usage and for people who like that sort of thing. We only build these on tagged releases.

I understand. None of these statements addresses the concerns in this issue.

Thanks for your concerns. We'll likely remove dist/ and recommend unpkg soon, but it's not a high priority.


NEST: 'Hit' type within 'InnerHits' does not include 'Nested' property with 'Offset' value

Bug
NEST/Elasticsearch.Net version: 2.3.1 / 2.3.1
Elasticsearch version: 2.2.0
Description of the problem including expected versus actual behavior:
NEST: 'Hit' type within 'InnerHits' does not include 'Nested' property with 'Offset' value
Steps to reproduce:

PUT /sample
PUT /sample/_mapping/document

{
  "properties": {
    "sections": {
      "type": "nested",
      "properties": {
        "number": {
          "type": "string"
        },
        "title": {
          "type": "string"
        }
      }
    }
  }
}

PUT /sample/document/1

{
   "sections": [
      {
         "number": "one",
         "title": "Network features"
      },
      {
         "number": "two",
         "title": "Network issues"
      }
   ]
}

POST /sample/document/_search

{
   "_source": false,
   "query": {
      "nested": {
         "query": {
            "match": {
               "sections.title": "Network"
            }
         },
         "path": "sections",
         "inner_hits": {
            "_source": false
         }
      }
   }
}

Expected response:
{
  "took": 4,
  "timed_out": false,
  "_shards": {
    "total": 5,
    "successful": 5,
    "failed": 0
  },
  "hits": {
    "total": 1,
    "max_score": 0.625,
    "hits": [
      {
        "_index": "sample",
        "_type": "document",
        "_id": "1",
        "_score": 0.625,
        "inner_hits": {
          "sections": {
            "hits": {
              "total": 2,
              "max_score": 0.625,
              "hits": [
                {
                  "_index": "sample",
                  "_type": "document",
                  "_id": "1",
----------------  "_nested": {
|                   "field": "sections",
|                   "offset": 1
----------------  },
                  "_score": 0.625
                },
                {
                  "_index": "sample",
                  "_type": "document",
                  "_id": "1",
----------------  "_nested": {
|                   "field": "sections",
|                   "offset": 0
----------------  },
                  "_score": 0.625
                }
              ]
            }
          }
        }
      }
    ]
  }
}

However, neither 'Hit' nor 'InnerHitsMetaData' types does not include 'Nested' property:
https://github.com/elastic/elasticsearch-net/blob/02bdf28788e657cffc253598d7766820f9eed62e/src/Nest/Search/Search/Hits/Hit.cs
https://github.com/elastic/elasticsearch-net/blob/02bdf28788e657cffc253598d7766820f9eed62e/src/Nest/Search/Search/Hits/InnerHitsMetaData.cs

Thanks for reporting @pedro-dlfa 👍

Many thanks for the fix @russcam :-)

This has been merged into 2.x in 179e5e312fa5d77e4eec9486741dce13a234f9e8 and will be in the next 2.x release which I'm looking to get out this week.


Your documentation needs to be SIMPLE, APPSettings for dotnet 6.0

Rick,
Your documentation here is terrible and very ambiguous....
You should focus on the term "AppSettings" since that is what we all google for!!
Next you need to show comparison between dotnet core 2.1, 3.1, and 6.0 since you do it different in each one.....
MEGA CONFUSING , for something so simple....
HERE IS THE FIX for dotnet c# 6.0:

builder.Configuration.SetBasePath(builder.Environment.ContentRootPath)
    .AddJsonFile("appsettings.json", optional: true, reloadOnChange: true)
    .AddJsonFile($"appsettings.{builder.Environment.EnvironmentName}.json", optional: true);

builder.Configuration.AddEnvironmentVariables();

builder.Services.Configure<AppSettings>(builder.Configuration);

Thanks

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 0eb4d762-3910-2c57-8741-3306c15537b6
Version Independent ID: ba2254a0-ea8e-9b28-e94b-edd0fc58c043
Content: Configuration in ASP.NET Core
Content Source: aspnetcore/fundamentals/configuration/index.md
Product: aspnet-core
Technology: aspnetcore-fundamentals
GitHub Login: @Rick-Anderson
Microsoft Alias: riande

Next you need to show comparison between dotnet core 2.1, 3.1, and 6.0 since you do it different in each one.....
We don't show difference between previous versions in the primary doc. Differences are shown in the migration docs. Use the version selector if you're not on the current released version.

HERE IS THE FIX for dotnet c# 6.0:

Fix for what?

fix for what? bad docs is what
another reason we are now moving to golang and react...


Draft7Validator

When I run
jupyter serverextension enable jupyterlab_sql --py --sys-prefix
I get the following error:
ImportError: cannot import name 'Draft7Validator' from 'jsonschema' (/usr/lib/python3/dist-packages/jsonschema/init.py)
This is with jupyter 4.4.0, python 3.7.3

Sorry I got this to work by pip3 install --upgrade jsonschema

Ah thanks -- it sounds like I'm missing a lower bound on the jsonschema dependency.

Resolved in PR #83.


✨🔧📝 Adding Typescript definition files

This way, the package can be used in Typescript projects.
It also should add Intellisense support for VSCode in JS or TS.

Thanks for another contribution @dudeofawesome. I'll check out the PR in a few and let you know what I'm thinking about it but it looks good so far.

Hey, what's the status on this?

Understood that. What about all the other interfaces you included? They're inaccessible from a void.
On Mar 18, 2017, 4:17 AM -0700, Louis Orleans<EMAIL_ADDRESS>wrote:

@dudeofawesome commented on this pull request.
In dist/lifx.d.ts (https://github.com/klarstil/lifx-http-api/pull/3#discussion_r106778825):

@@ -0,0 +1,8 @@ +declare module 'lifx-http-api' { + interface ILifxOptions { + bearerToken: string; + } + + const LifxHTTPAPI: (options: ILifxOptions) => void;

The goal of this file is to allow for
const lifx = require('lifx-http-api'); new lifx({ … });
The return type of a constructor must be void in TypeScript
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub (https://github.com/klarstil/lifx-http-api/pull/3#discussion_r106778825), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAONwJ5ZLCVPXJ0D883ommrMMetKT-Foks5rm71KgaJpZM4LnXFt).

For an example of how this works, you can check out my Travis CI build light project: https://github.com/dudeofawesome/ci-stoplight
I create a new LifxClient here, which is then injected in to my LifxController class here, and later used in a few places within that class, including here.
The constructor method of a class always has a return type of void.
When you say you don't see any hinting, do you mean that you've attempted to use, but when you instantiate a new instance, the type returned is any?

@klarstil What's the status of this?


Change from Exception to warning when the rt's ReferencedSOPInstanceUID is different from the CT's SOPInstanceUID

Problem:
Sometimes the CT used by the radiologist for the manual segmentation of ROIs might not be the one put in the final database.
To give a concrete example, one might have an injection CT and one without injection, do the rtstruct on the  injected one and put the non-injected one in the database.
Consequence
In this case the CT's SOPInstanceUID is different from thee RT's ReferencedSOPInstanceUID, even though the space is the same.
At lines 78-82, the check made raises an error if these are not identical.
Proposition
It would be great if the user could chose whether this should be a warning or an Exception, through a parameter passed to the RTStructBuilder (like strict_check_SOPInstanceUID=False)
If you think it's a good idea, I will submit a pull request  for it.

Closed by #64
Thanks again for working on this!


Add binary artifacts with cargo-dist

Add support of binary uploads on release with cargo-dist. Unfortunately I do not have the ability to release things or run Github Actions, so this will probably work, but I don't know
Fixes #84 and #87

Now with prerelease support for arm Macs!

Only just now realizing that this is almost the same as #87, with the only difference being that this one also builds binaries for Arm Macs


Excel Formula  and Cell ColumnSpan or RowSpan

Thanks for your great job. The  plugin is very awesome. I am using this spread sheet to develop our APP. In our case the Excel Formula "SUMPRODUCT" is a very popular formula, Can you support the formula in next version? Maybe support more formula. Another request about the column span or rowspan, I am using the css class to control the span. Can you support the feature in next version.
I also use insert row/column menucontext, but I have found the formula auto updated has some mistake. This operate only updates the row/column below. I have override the updateTableReferences in my development.

jExcel is built in a way you can develop and share your own implementations for formulas. Take a look on this example
`

`
https://bossanova.uk/jexcel/examples/including-formulas-on-your-spreadsheet


add option to specify cmd health check

@bearnard @saeedmb8 review please

👍 when done with the changes you suggested.