fix(components): allow A to accept class

closes #1038
Current behavior
A component was compiling the class props pretty gnarly and breaking the UI when combined with Panda CSS via Solid-Start app (non-islands setting).
New behavior

Fixes all TS type and eslint errors within component
Adds class prop with fixes the issue without conflicting with classList

Other
I tested this pretty heavily in my large Solid-Start app and it seems to work in all scenarios (including using end). Likewise, I'm aware that you typically want to avoid combining class and classList but this seems to work cohesively without causing conflicts.
I would even dare say that the active/inactive class design is probably outdated these days in favor of full control by the user so there is more flexibility of the component overall.
Because solid wants to keep the class and classList segregated, I just can't see how enforcing those internally is fully beneficial to the DX vs. letting the developer decide how they want to manage the styling (whether classes they create or using a lib like Panda-CSS).

Honestly I'd love to get rid of active/inactive. Honestly I'd love to get rid of classList (it was definitely a mistake). The first is at least something I'd entertain if the use cases were covered. I honestly have no idea what the expectation of the class usage and classList is. Someone previously did this big classList rewrite.. it's odd that it doesn't work. In your testing was it the server markup that was broken more so than the client?

@ryansolid it was actually the reverse! The server version was perfect and the client was all weird like in the issue.
I appreciate that insight too. If there's anything I can do in addition to this to help future solid please let me know. 💪

I'm still trying to figure out what the underlying issue is because the reason it was merged was to prevent the updating class wipes everything else issue. Like updating class will just replace the class and wipe out anything classList did. This is why we never recommend having both on a native element. Ideally for now we'd only have classlist managing both until I can deprecate it.

Makes sense. It is a weird thing that I can only duplicate in my project (which is pretty large now). I've also already just created this fix locally which fixes it just in case it doesn't get shipped. All the Panda team has figured out is that SR is creating the corrupted component on the client...in my specific app instance (but not on a fresh project using the Basic template for example)? 🤔

The history of the styling libs has been...

Test using CSS modules - ⛔
Test using Tailwind - works, but clogs up the code and is not scalable for multi-theming ⛔
Test using UnoCSS - works, but buggy and no multi-theming support ⛔
Panda - works, scalable, keeps the code clean ✅
a. Now seeing FOUC with the A component from SS/Router.

Wondering if one of the prior solutions has some weird corrupted meta that is somehow affecting the build still?


Product : Retrieving related object with single request

This proposal has been made conjointly with @xens
We would like to reduce the number of queries required to fetch all the data related to a Product. More specifically, we would like to provide a way to retrieve in a single query the data associated with fields defining a relation.
To do that we came up with essentially three proposals to achieve this :

Directly modifying the ProductSerializer to force it to follows these relations and get the data. The django framework support this feature natively and thus it is really easy to implement. However, the downside is that it would mean forcing a complete retrieval even if it is not needed.

Modifying the endpoint to support an additional parameter specifying if we want standard (as currently implemented) or full retrieval. Something along the line of /products/?full.

Modifying the endpoints to be even more parametric and be able to specify for which field we want to follow the relation.

As an example, we have implemented the retrieval for product_manager yielding
{
      "id": 3,
      "findings_count": 0,
      "findings_list": [],
      "product_manager": {
        "id": 1,
        "username": "admin",
        "first_name": "Admin",
        "last_name": "User",
        "email"<EMAIL_ADDRESS>        "last_login": "2020-10-16T07:31:49.047121Z",
        "is_active": true,
        "is_staff": true
      },
      "tags": [],
      "product_meta": [],
      ...
}

instead of
{
      "id": 3,
      "findings_count": 0,
      "findings_list": [],
      "product_manager": 5,
      "tags": [],
      "product_meta": [],
      ...
}

How does option 1 work? Could it be used but only when a parameter is specified (option 2). If possible, you don't want to write all the code to get all the relations (and their relations etc). How many levels deep will it go?

For option 1 we simply modify the ProductSerializer using the serializers corresponding to the fields for which we want to follow the relation and load the data. For example, for product_manager we use the UserSerializer. In our case we only need to follow the relation for the fields :

product_manager
technical_manager
team_manager
prod_type
regulations

We would like to avoid doing it for findings as the list can be relatively big. This is why we also propose option 3 that offers more granularity and allows us to generalize the approach. While option 2 is also possible we think that it would not scale well if, for example, we include also findings which might be required to be semantically coherent. For the depths of the retrieval, we only need 1 level in our case. I dont know if this is something worth adding as a parameter and also how easy it would be to implement it.
Let me know if my explanation is not clear or if I did not answer your questions :-)

yeah 3 is best and maybe not too much work if you can reuse the serializers for those relations.

I  did the implementation for the field technical_manager to illustrate the changes. This amount to adding a few lines of code inside the ProductSerializer as the snippet below shows :
 def to_representation(self, instance):
        parameters = self.context["request"].GET
        rep = super().to_representation(instance)

        if "technical_contact" in parameters and not rep["technical_contact"] is None:
            rep.pop("technical_contact")
            rep["technical_contact"] = UserSerializer(read_only=True).to_representation(instance.technical_contact)
        return rep

Then the endpoint for getting products can be called with the additionnal parameter technical_manager.
This is the most elegant way I found of doing it but since I'm not a Django expert, feel free to let me know if I should do it differently. Also, for the parameters, if you think that we should use different names than the names of the fields we want to expand, let me know as well.

I think it's elegant enough. It's all glue code, maybe it can even be made more generic doing something like for relation in ['technical_contact', 'product_manager', ...]: <the code above>
for the parameters I was thinking maybe it's nice to have some comma seperated parameter, i.e. include_related=technical_contact, product_manager, ....  Or multiple of the same, i.e. ìnclude=technical_contact&include=product_manager....`

We would like to get back on this proposal with some improvements (I've close the related PR).
Context : We have noticed that the feature that we proposed for the Product would be needed for other endpoint as well (Finding to name one). Therefore, we decided to see if this feature was generizable.
Observations : As can be seen in the code above, we implemented the prefetching directly inside the serializers. While this was initially a good approach it has a few downsides.

It induces more burden on the caller as, depending on the parameters given to prefetch, it produces JSON with fields that can either store an integer (the primary key) or an object. Therefore, unmarshalling of the response is more difficult and might be even impossible if the programming language used by the client does not support some kind of union type.
The auto generated swagger documentation is wrong as the existing inspectors cannot derive both the newly added query parameter nor support union type in the response model.
The data is added per product even if it's redundant which could yield large response

Thus, we decided to see if by generalizing we could also solve these problems.
Solution : We decided to implement prefetching by creating new mixin that implement the basic read and list operations so that it can be easily deployed on the selected endpoint. We take the example of the new list mixin as the read mixin is completly analogous.
Our list mixin, class PrefetchListMixin(mixins.ListModelMixin) only override the list(...) operation. The method is similar to the original one with the difference that it keep the prefetched data as a set. The result produced, for findings for example, is
{
   count: ...,
   previous: ...,
   next: ...,
   results: [ /* findings */],
   prefetch: {
       field_name1: {
           id1: { /* object1 */ },
           id2: { /* object2 */ }
      },
      field_name2: { ... },
      ...
   }

The main advantage with this method is that we do not have the typing problem mentionned above and also we avoid duplicated data. The prefetch field acts as a form of cache as it was intended.
The prefetching mechanism is completly automatized. The process goes according to the following (simplied) algorithm.
input:
    - object: ModelInstance // the object retrieved from the database
    - params: list[string] // the field we want to prefetch
output:
    - prefetched: dict()

prefetched = dict()
 // we gather all the available serializers in a map type -> serializer_class where type is the type of the model parsed by the serializer_class is the type of the serializer
serializers = build_serializers()

for param in params:
    // Find the best serializer that can be applied
    serializer = match_serializer(object[param], serializers)
    if serializer is None:
         continue
    data = serializer().to_representation(object[param])
    prefetched[param][data.id] = data

return prefetched

This process has been implemented and works well. For an endpoint represented as a ViewSet we only need to add the new mixin to support the operation. However, this does not resolve the problem of the swagger documentation. In our case, we need to add the new parameter with the list of field that can be prefetched as well as the new field in the response. The best way we found to do it is first to extand the AutoSwaggerSchema class to support the manual addition of new parameters and field inside the response. Then we provide a new decorator that can be added to a ViewSet and that compute automatically these new information without requiring any manual manipulation.
In the end, supporting prefetching for an endpoint can be done by writing (for example for the Product endpoints)
@prefetch_decorator(name="list", serializer=ProductSerializer)
class ProductViewSet(PrefetchListMixin, /* existing mixing */):
        /* original code */

We do you think ?

Sounds interesting, but would need to see the code to fully understand it.

Implemented in #3516


Spectrum Scale CSI 2.6.0 checklist

IBM Spectrum Scale CSI Driver GA release Checklist

[x] CSI snap works with/without CG on Vanila k8s, Openshift with and without OLM deployment - Abhishek/Vrushal/Monica - 10 June
[x] Verify GitHub links are working - Nitish - 10 June and 23 June
[x] Verify IBM docs links are working - Nitish co-ordinate with Teja - 10 June and 23 June
[x] Pause dev checkin once stop-ship phase starts - Amol - 13 June
[x] Create Golden Master images on quay (Atleast 1 week before GA) - Amol (backup Deepak) - 16 June
[x] Regression Complete - Abhishek, Sanjay - 10 June
[x] Realworld test complete - Tristan, Tom - 10 June
[x] OLM Packages Ready and Tested - Abhishek - 10 June
[x] Create case bundle for Cloudpak certification - Abhishek - 19 June
[x] Check images for Vulnerabilities(Driver, Operator, sidecars) - Vrushal - 13 June
[x] IBM Docs Content Verification (1 week before GA) - All - 15-17 June
[x] Create git release tag (draft) with release content (1 week before GA) - Amol - 16 June
[x] Merge dev into master (on GA date) - Amol - 23 June
[x] Push multi arch images to quay (on GA date) - Amol - 23 June
[x] Publish git tag (on GA date) - Amol - 23 June
[x] Verify the images and yaml from release branch are correct - CLI install/Upgrade (on GA date) - Vrushal - 23 June
[x] Create PR in private repo for Redhat Community Operator Listing (https://github.com/redhat-openshift-ecosystem/community-operators-prod) - Abhishek - 17 June
[x] Create PR in private repo for Community Operator Listing (https://github.com/k8s-operatorhub/community-operators) - Abhishek - 17 June
[x] Publish PR for Redhat Community Operator Listing (https://github.com/redhat-openshift-ecosystem/community-operators-prod) - (on GA date) - Abhishek - 23 June
[x] Publish PR for Community Operator Listing (https://github.com/k8s-operatorhub/community-operators) - (on GA date) - Abhishek - 23 June
[x] Update driver listing https://kubernetes-csi.github.io/docs/drivers.html - Not needed for 2.6.0
[x] Unpause dev checkin. (once OLM is verified for community operator) - Amol - 24 June
[x] Cloudpak certification (Content promotion ticket, Release PR, verify image digest) - Abhishek - 17-20 June
[x] Publish cloudpak certification - Abhishek - 22 June
[x] Image for ICR and artifactory push - GM and final release images - Amol (Deepak backup) - 9 June and 10 June
[x] Swap to production ICR - Amol - 20 June
[x] Quay image tagging and updating quay image tags/SHAs in CSI 'dev' branch - Amol - 23 June

All release tasks are completed.


move imagemin to peer, plugin loading to client, and test with webpack 4

This should fix #28 and fix #29.

As mentioned in the other ticket, I tested and it works great for me. I found the docs easy to follow.
Having said that, maybe a migration guide would be useful? The main cases, I suspect, would be:

user wants all optimizations switched on with default settings (i.e. like default settings before)
user wants the same as above but only in production mode
user wants per-optimizer settings (your docs already cover this pretty comprehensively, I think)

published as 3.0.0.


Visual Studio 2015 support

Reviewers: @miguelportilla @vinniefalco for their experience building in Windows. @rec may want to take a look, too, because I know he has SConstruct changes pending.
Installation documentation is now located in Builds/VisualStudio2015/README.md. Once these changes are merged / released, the wiki page will need to be redirected to that file (possibly with a note that 2013 is no longer supported). When/if the 3rd party OpenSSL installer we rely on is updated to support VS2015, we can decided whether to update SConstruct and the README to reference it, or let users continue to build themselves. (Alternately, if the consensus is to maintain compatibility, I could revert the relevant SConstruct changes, and add instructions to move and rename files appropriately. I think this is a bad idea.)

Builds all unity and non unity debug/release builds. All tests pass. Server starts, syncs and stops.
:+1:

AppVeyor doesn't like it, though.  :-(
For those of us without access to a Windows machine, this is the only way of seeing if our builds work.  Is there a way to preserve AppVeyor through the move?

@rec I noticed that's not a spurious failure either, so I'll try to fix it.

YEAHEHEHEHEHEAAAAAAH!  "AppVeyor build succeeded".

W0000000t

Now THIS is good news!

Relevant PR at https://github.com/ripple/Downloads/pull/2. If/when it is merged, we can change the RIPPLED_DEPS_URL in appveyor.yml to point to a more official Ripple repo.

Merge now, merge now!!!  Before ci/circleci whines! :-)

lol :)

Split the beast changes into a separate commit, and squashed the rest.

Rebased to b6.

This is already merged, so any changes would have to go into a new pull request.


Suggestion: document requirement for TypeScript @types packages

When importing this package in a TypeScript file, TypeScript will read pkg.typings in order to pick up the typings for this package (via https://github.com/alex3165/react-mapbox-gl/blob/f1f5b97c5f4c400fe2e4e89ccaab9db02b8e8229/package.json#L6).
I immediately ran into these error messages:
node_modules/react-mapbox-gl/lib/popup.d.ts(1,23): error TS2688: Cannot find type definition file for 'mapbox-gl'.

1 /// <reference types="mapbox-gl" />
                        ~~~~~~~~~

This is because the typing dependencies were not installed. In turn, this is because they are defined in devDependencies. (Even installing this package as a dev dependency won't install its devDependencies, as I found out.)
To workaround this, I had to manually install the missing type packages:
yarn add --dev @types/mapbox-gl @types/geojson

Could we document the requirement for this somewhere, so it doesn't confuse others?
Ideally these versions would be specified/managed internally. Have you got any thoughts on how to achieve that?

In fact, this is the reason TypeScript recommending libraries specify type dependencies as normal dependencies, not development dependencies: https://github.com/Microsoft/types-publisher/issues/81
Would you accept a PR to make that change?


Precompute list of metric IDs to improve performance

What does this PR do?
Do not compute and store the list of metrics for each object. This will save time when caching, as well as memory
Motivation
We were caching useless information
Review checklist

[ ] PR has a meaningful title or PR has the no-changelog label attached
[ ] Feature or bugfix has tests
[ ] Git history is clean
[ ] If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo

Additional Notes
Anything else we should know when reviewing?

Codecov Report

Merging #2221 into master will decrease coverage by 8.37%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##           master    #2221      +/-   ##
==========================================
- Coverage   86.28%   77.91%   -8.38%
==========================================
  Files         190       15     -175
  Lines       13620     1091   -12529
  Branches     1433      122    -1311
==========================================
- Hits        11752      850   -10902
+ Misses       1469      213    -1256
+ Partials      399       28     -371


Added option of python to start backend along with existing docker command

fixes #5573

Do not merge until https://github.com/plone/volto/pull/5564 is merged, and then this PR is revised to accommodate development in contributing/developing-core.md. We also want to move stuff into included files to ensure consistency throughout our documentation.

@Atharvp01 #5564 has been merged. Would you please resolve conflicts and push to this PR? Also the Python option needs to be added to docs/source/contributing/developing-core.md. Then we can discuss further revisions. Thank you!

@stevepiercy okay, got it.


[ISSUE #4377]Unnecessary null check before method call

What is the purpose of the change
Unnecessary null check before method call
Brief changelog
Unnecessary null check before method call

Coverage increased (+0.1%) to 52.209% when pulling a87579495c8870bddab3af0d7583ceeec6757a67 on coderbruis:Unnecessary_null_check_before_method_call into 65a8525a6045bf79ffd4b2984528b9b8b36892b1 on apache:develop.


Support GCP Vertex AI as inference provider

Description
Add GCP Vertex AI as a supported inference provider
Tasks

[ ]  Implement inference provider following these instructions
[ ]  Add example under provider folder
[ ]  Update docs to include supported interfaces
[ ]  Run tests

Tutorial on how to do so: https://i-am-bee.github.io/bee-agent-framework/#/llms?id=adding-a-new-provider-adapter

HI!  I would like try this.  Would you assign to me?  Thanks!

Awesome! just assigned you @akihikokuroda

Thanks!

I need some guidance here.
I'm trying to serialize VertexAI class from "@google-cloud/vertexai". This class has a member type of GoogleAuth from "google-auth-library" class.  I can register both classes to the serializer.  So these are OK.
The issue is that the VertexAI has another member type of VertexAIPreview that is a class defined in the same package as VertexAI class but it is not exposed so I can not register it to the serializer.
How can I workaround this?
Thanks!
Here is the class definitions : https://github.com/googleapis/nodejs-vertexai/blob/31de0e92bb7e0efd5afca2728d6175095175be04/src/vertex_ai.ts#L43
export class VertexAI {
  public readonly preview: VertexAIPreview;
  private readonly project: string;
  private readonly location: string;
  private readonly googleAuth: GoogleAuth;
  private readonly apiEndpoint?: string;
 ......
}

class VertexAIPreview {
  private readonly project: string;
  private readonly location: string;
  private readonly googleAuth: GoogleAuth;
  private readonly apiEndpoint?: string;

  private readonly apiClient: Resources.ApiClient;
  readonly cachedContents: Resources.CachedContents;
.....
}

Released in v0.0.43

@akihikokuroda thanks for the contribution!  could you also complete the following so that our docs and examples folders follow suite:

[ ] Add example under provider folder
[ ]  Update docs to include supported interfaces

I added examples because I wanted to try it with my GCP credentials.
However, the implementation is flawed and needs the following updates.

parameters are not used and are not typed, ideally they should correspond or map to `BaseModelParams.
hence you should completely rework the utility function createModel
you code contains expressions like for await (const chunk of await response.stream) {, rewrite to just for await (const chunk of response.stream) {


Fix before_timestamp in getMessages

The query variable is unused in getMessages.

Hello, thanks for your PR! It's been merged in v1.10.3 with slight modifications.


Grow up, leave because you're never getting unbanned. Here or on any other Pixelmon server


Automated cherry pick of #3444

Cherry pick of #3444 on release-5.15.

#3444: Fixing in-app links

/cc  @reflog

@reflog Please help merge.


Infinite loop detected while resolving name references

ConfuserEx Version: Confuser.Core 1.6.0+447341964f Copyright c 2014 Ki, 2018 - 2022 Martin Karing
Target Framework:  .NET Core 2.1
Operating System: Windows 10

Steps to Reproduce:

Download the demo
ConfuserEx2Test_InfiniteLoopDetected.zip

Open the project in VS. And modify the file path for Confuser.CLI.exe in "Post-build event command line".

Build

The output:
[DEBUG] Executing 'Renaming' phase...
[DEBUG] Renaming...
[ERROR] Infinite loop detected while resolving name references.
Processed definition: Original Name: ConfuserEx2Test.Internal.MyBaseClass::MyMethod(); Name Hash: 2EDCFF18
Assembly: ConfuserEx2Test.dll
Faulty References:
 - Member Override Reference(This Referenced Method(Original Name: ConfuserEx2Test.Internal.MyBaseClass::MyMethod(); Name Hash: 2EDCFF18); Base Referenced Method(Original Name: ConfuserEx2Test.Internal.MyInterfaceA::MyMethod(); Name Hash: E74373AE))
 - Member Override Reference(This Referenced Method(Original Name: ConfuserEx2Test.Internal.MyBaseClass::MyMethod(); Name Hash: 2EDCFF18); Base Referenced Method(Original Name: ConfuserEx2Test.Internal.MyInterfaceB::MyMethod(); Name Hash: 3002893D))

It was working with the old build "Confuser.Core 1.5.0-alpha Copyright c 2014 Ki, 2018 Martin Karing".
The changes in https://github.com/mkaring/ConfuserEx/commit/a69820a4b9a8be61966e45222fba91251ddf9efe# broken this case.
The related code:
https://github.com/mkaring/ConfuserEx/blob/320e90cd15ec0d06de223083b5966f6669b8dfe3/Confuser.Renamer/RenamePhase.cs#L82
If I revert this code
methodDef.Name = service.ObfuscateName(methodDef, mode);
to
methodDef.Name = service.ObfuscateName(methodDef.Name, mode);
then it can work.

It is correct that reverting this, will make the error disappear. How ever the "issue" actually remains. Due to the change you did, ConfuserEx is just unable to detect that there is a problem. The resulting obfuscated assembly should be broken at runtime with your change.
The problem is usually caused by the way ConfuserEx processes the different assemblies. At this point the only correct way to fix this issue, is to disable the rename obfuscation for one of the affected methods (this will block the rename obfuscation for all the methods).

Thanks for your comment.

The problem is usually caused by the way ConfuserEx processes the different assemblies.

There is only one assembly and the code is simple:
  abstract class MyBaseClass {
    public void MyMethod() { }
  }

  public interface MyInterfaceA {
    void MyMethod();
  }

  public interface MyInterfaceB {
    void MyMethod();
  }

  class MyClassA : MyBaseClass, MyInterfaceA {
  }

  class MyClassB : MyBaseClass, MyInterfaceB {
  }

The MyMethod is defined both in interface and class and used in a class at the same time. In this case, the ConfuserEx wrongly detects an infinite loop while renaming it.
I can refactor the code as a workaround. But I still think this is a bug in ConfuserEx.

It's a bug indeed. Caused by the sequential rename mode. I'm looking into it. The other rename modes are working fine.
Applying for example the unicode mode to the affected methods in the base class as well as both interfaces is a possible workaround.
  abstract class MyBaseClass {
    [Obfuscation(Exclude = false, Feature = "+rename(mode=Unicode)")]
    public void MyMethod() { }
  }

  public interface MyInterfaceA {
    [Obfuscation(Exclude = false, Feature = "+rename(mode=Unicode)")]
    void MyMethod();
  }

  public interface MyInterfaceB {
    [Obfuscation(Exclude = false, Feature = "+rename(mode=Unicode)")]
    void MyMethod();
  }

  class MyClassA : MyBaseClass, MyInterfaceA {
  }

  class MyClassB : MyBaseClass, MyInterfaceB {
  }

Check out the build here. This resolves the issue for the test case.
Would be great if you could give it  a spin with your real project.

Thank you. I test this in our real project and everything works.


[Feature Request] Build CLI tool without Qt / OpenGL

OpenGL seems to be a bit problematic with my nvidia graphics card. Also I don't need a live view of the profiling. I would like to be able to just output a trace / flamegraph / callgraph after capturing the output. For this I think it would be ideal to have a CLI version of orbit. That would also have fewer dependencies.

Thanks for the request. There is already a bit into this direction:
OrbitClientGpp allows you to take a fixed size capture of a specific PID and saves the capture file.
Please note that Orbit's capture format is currently rewritten and, will thus change in the near future (see here).

The (graphical) output/evaluation can be then done using the Jupyter notebooks (also mentioned in #1608).


Code Quality: Creating a language helper to work with the global language of the application

Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Closes #15440

Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

Work globaly correct

Jajx, how easy it is to inadvertently end a PR 😅

@hishitetsu thanks for the reminder, I forgot to format the file.
Yes the PR is still a draft, but after the last edits it will be ready and I will be able to change the PR status

Should I replace all occurrences with ApplicationLanguages.PrimaryLanguageOverride with this helper?

/format

\format

OMG, it still works well! they did great work.

I don't like uncommented classes with their properties and methods, the comments serve to better understand what the part does, why that part is still misunderstood. Yes it takes longer, but it saves a lot of time in the future.


0.10.7 doesn't work

I get the following error:

> @ generate-types /Users/clayne/workspace/casalova-web
> apollo-codegen generate **/*.graphql --schema graphql-schema.json --target typescript --output ./packages/casalova-web-client/src/universal/graphql-schema.d.ts

Apollo iOS does not support anonymous operations
This anonymous operation must be the only defined operation.
Cannot query field "hero" on type "Query".
Cannot query field "hero" on type "Query".
Apollo iOS inserts __typename automatically when needed, please do not include it explicitly
Unknown type "Episode".
Cannot query field "hero" on type "Query".
Unknown type "Character".
Unknown type "Droid".
Unknown type "Human".
Unknown type "Episode".
Cannot query field "hero" on type "Query".
Cannot query field "hero" on type "Query".
There can only be one operation named "HeroName".
There can only be one operation named "HeroName".
Cannot query field "hero" on type "Query".
Cannot query field "hero" on type "Query".
Cannot query field "hero" on type "Query".
There can only be one operation named "HeroName".
There can only be one operation named "HeroName".
Cannot query field "hero" on type "Query".
Apollo iOS needs to be able to insert __typename when needed, please do not use it as an alias
Validation of GraphQL query document failed

It seems **/*.graphql might be picking up the .graphql files used in the apollo-codegen tests. Maybe you installed it in your node_modules directory instead of globally? It might also be better to be more specific about your file locations and use something like src/**/*.graphql.

Got it - it is installed in my node_modules directory. Thanks.
On Mon, Feb 13, 2017 at 3:53 PM Martijn Walraven<EMAIL_ADDRESS>wrote:

It seems /*.graphql might be picking up the .graphql files used in the
apollo-codegen tests. Maybe you installed it in your node_modules
directory instead of globally? It might also be better to be more specific
about your file locations and use something like src//*.graphql.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/apollographql/apollo-codegen/issues/60#issuecomment-279518751,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACs0VCcCVBiEwS1i--4TDTZygT7BnYFnks5rcMLXgaJpZM4L_s7k
.


The pythons - microverse

include link to the original site on the README file

add a padding on the search bar

Both of them have been implemented. Thank you guys for the awesome feed -backs.


WIP stats: allow specifying tags when creating metric objects

Signed-off-by: Snow Pettersen<EMAIL_ADDRESS>Risk Level: Low
Testing: UTs
Docs Changes: n/a
Release Notes: n/a
#9194

Back from vacation now and will try to get this into a reviewable state

@snowp I assume I should wait till you take this out of 'draft' mode before doing a deeper review?

If you wanna take a look at the approach right now, its only implemented for histograms but should be accurate to what I had in mind at least. If this looks good then I'll do the same for gauges/counters and we can do a proper review

/wait

Going through and updating call sites made me realize that this won't be compatible with hot restart stats transfer in its current form due to the stats transfer just sending the name/value of the stats. Presumably we could pack the tag names into the name and parse them out on the receiving end, but that can probably wait until a follow up PR


Update dependencies to match aws-iot-device-sdk 1.19.1; stop limiting port to 16 bits

Issue #, if available:
Related to https://github.com/awslabs/aws-c-io/issues/576
Description of changes:
Update dependencies to match aws-iot-device-sdk 1.19.1: https://mvnrepository.com/artifact/software.amazon.awssdk.iotdevicesdk/aws-iot-device-sdk/1.19.1
This includes a change to stop limiting port numbers to 16 bits (now 32 bits).
Verified by the tests passing.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Closed and opened #7 instead due to workflow not running for some reason


Enable email notifications for the Jenkins Smokey job

I'd like to know as soon as possible if a change we've deployed means
that an associated Smokey test fails.
This is the same as the change I made for the Deploy App Jenkins job in
4cc88440d4fc49d1f495c813d1ad5fa95c80800b.
Prior to this change the only notification mechanism was Slack. This was
disabled in integration (the Slack auth token is set to disabled for environment in /etc/jenkins_jobs/jobs/smokey.yaml on CI) meaning that
we'd only see failures by looking at the Jenkins interface. Although it
was enabled in staging and production, the Slack notification only
includes a link to the failure which I'm not able to view because I
don't have access to those Jenkins instances.
I've copied the email configuration from the deploy_app.yaml.erb file as
I know we've received email notifications from that job in Jenkins.
I haven't added a test for this change as we don't appear to have added
tests for similar changes in the past.

I'm not sure whether I'm allowed to approve this, but the change looks good to me. 👍

I've asked in Slack whether you're allowed to approve this PR, @floehopper:

Oliver Byford
[5:19 PM]
the reviewer has to have write access to the repo
[5:19]
for it to ‘count’ with required reviews
Chris Roos [5:20 PM]
And is that the only requirement?
Oliver Byford
[5:21 PM]
“There are just four rules of reviewing and merging PRs:
master must be able to be released at any time
The change must have two reviews from people from GDS (preferably GOV.UK). This can (and normally will) include the author.
Use the Github Review UI to mark a PR as approved or requiring changes.
Use the Github UI to merge the PR. This ensures the PR number is added to the merge commit.”
[5:21]
from https://gov-uk.atlassian.net/wiki/display/GOVUK/RFC+52+-+Pull+Request+merging+process – which you might not be able to access…
[5:21]
so I would say as long as they’re confident in the change, I don’t see why not…
Chris Roos [5:22 PM]
Awesome. That’s really useful. Thanks @obyford :slightly_smiling_face:

In summary: you're allowed but it's up to you to decide whether you're confident in the change to do so.

Splendid. Thanks @floehopper. I'll get this merged now.


Email : [Errno -2] SMTP Name or service not known

Hi,
I'm trying to create my first rule. It's a frequency rule and it works fine with the tester and the debug alerter. However when I try to send a mail I have the following error :

ERROR:root:Error while running alert email: Error connecting to SMTP host: [Errno -2] Name or service not known
alert:

This is my config :

alert:

"email"
email:
<EMAIL_ADDRESS>smtp_host: "smtp.gmail.com"
smtp_port: "465"
smtp_ssl : "true"
from_addr<EMAIL_ADDRESS>smtp_auth_file: '' /etc/elasticsearch/smtp_auth.yaml"

Do you have an idea how to solve this issue please ?
Thanks

From what I can see, chances are your indentation of your rule is off (YAML is very picky) or your machine can't find an IP address for smtp.gmail.com.
For the first one could you format your config by placing it in code like so
```yaml
alert:
- "email"
email:
-<EMAIL_ADDRESS>```

For the second if you're on linux you could try to ping/dig smtp.gmail.com to make sure your machine can see it
ping smtp.gmail.com
dig smtp.gmail.com
You could also try to telnet to make sure you can connect
telnet smtp.gmail.com 465

The problem is on my end, emails are blocked on the testing network I'm currently.

Maybe port must be 587


How to set project path?

[x] updated
[x] read contribution guideline
Running fastlane beta prompts:
Couldn't automatically detect the project file, please provide a path:
What's the correct way to set the project file to avoid this prompt?

What have you already tried? What does your Fastfile look like?

@yogiben GYM_PROJECT enviromental variable will set this. Let me know how it goes!

Settings ENV["GYM_PROJECT"] in Fastfile works for me as a workaround.

We also met this issue.
The problem is the current working directory is changed to parent directory after update_project_provisioning action.
Here is related fastlane code:
    puts "Current working directory before: #{Dir.pwd}"

    update_project_provisioning(
      xcodeproj: proj_xcodeproj_file,
      profile: "#{bundle_id}.mobileprovision",
      target_filter: target
    )

    puts "Current working directory after: #{Dir.pwd}"

The output is
Current working directory before: PROJECT_DIR/fastlane

-----------------------------------------
--- Step: update_project_provisioning ---
-----------------------------------------
You’re updating provisioning profiles directly in your project, but have you considered easier ways to do code signing?
https://docs.fastlane.tools/codesigning/GettingStarted/
Parsing mobile provisioning profile from 'com.thescore.esports.mobileprovision'
Going to update project 'PROJECTNAME.xcodeproj' with UUID
Updating target PROJECTNAME...
Updating configuration Debug...
Updating configuration Ad-Hoc...
Skipping target PROJECTNAMETests as it doesn't match the filter 'PROJECTNAME'
Successfully updated project settings in'PROJECTNAME.xcodeproj'

Current working directory after: PROJECT_DIR

The workaround for us is Dir.chdir "fastlane", which corrects the working directory.

@honghaoz Did you try the other workaround?

@TKBurner I didn't try GYM_PROJECT, since I didn't want to use hard-coded environment value. But since it worked before. the problem may cause by update_project_provisioning  action.

@honghaoz Interesting. I think that is the case. You should be able to manually set this in your build settings. You can else use the provisioning_profile_specifier

I added ENV["GYM_PROJECT"] = "/Users/gringo/dev/project/project-app/0.31.0/ios/Project.xcodeproj" to the Fastfile but get the same prompt.
The path works when entered in the command line prompt.

Hi @yogiben can you also set the GYM_WORKSPACE? Thanks!

@TKBurner that did it. thanks :)


Model.dict() is taking to much time to respond

Describe the bug
Im using a model with 1 many to many rel and 1 foreign key, with ormar, but the seralization is taking too much to do it. After disabling dict() the overloaded method, the response model does not have any related model, but it takes almost a 1/100  (I didn't make the exact calculations) of the time to do it. This problem also affects  to make the json response, so we should expect a slow response time. Is there any way to disable this override method or is there any plan/idea to optimize it?
With ormar dict():

With only-pydantic dict():

The list of models that I´m loading doesn't have any related model loaded, neither items on the many to many relation

I'm trying to optimize the dict() if I can on a regular basis but to check your scenario I would need your models and sample data to make some tests.
That seems like a quite long response indeed, do you load the related models in the query or not?
Because if you do, then you serialize the main model plus n x related model, where n is a number of related model instances of the main model. So you are comparing the time of serializing one model (pydantic) versus n+1 models (ormar).
Do you want the related model included in the dict or not?

In answer to your questions, im not loading the related models.
Here are my principal models that im working on:
class Release(orm.Model):

    id: int = orm.Integer(name="id", primary_key=True)
    title: str = orm.String(max_length=200, default='')
    description: str = orm.Text(default='')
    tag: Tag = orm.ForeignKey(Tag, ondelete='CASCADE', onupdate='CASCADE')
    changelogs:  List[Changelog] = orm.ManyToMany(
        Changelog, through=ChagenlogRelease, ondelete='CASCADE', onupdate='CASCADE'
    )
    data: dict = orm.JSON(default={})

class Project(orm.Model):

    id: int = orm.Integer(name="id", primary_key=True)
    name: str = orm.String(max_length=100)
    description: str = orm.Text(default='')
    git_url: str = orm.String(max_length=500, default='')
    labels: Optional[Union[List[Label], Label]] = orm.ManyToMany(
        Label, through=ProjectLabel, ondelete='CASCADE', onupdate='CASCADE'
    )
    changelog_jira_tag: str = orm.String(max_length=100, default='')
    change_type_jira_tag: str = orm.String(max_length=100, default='')
    jira_prefix: str = orm.String(max_length=10, default='SAN')
    type: str = orm.String(max_length=10, default='cs')
    target_branch_name: str = orm.String(max_length=100, default='master')
    header: str = orm.String(max_length=250, default='')
    jira_url: str = orm.String(
        max_length=500,
    )
    changelog_file: str = orm.String(max_length=250, default='')
    version_file: str = orm.String(max_length=250, default='')
    members: Optional[Union[List[User], User]] = orm.ManyToMany(
        User, through=UserProject, ondelete='CASCADE', onupdate='CASCADE'
    )

The response I´m getting with pydantic .dict() func
[
    {
        "id": 9,
        "title": "prueba-2321",
        "description": "\n<!--- start changelog ver.v.<IP_ADDRESS> -->\n### [v.<IP_ADDRESS>] - 2021-08-19\n#### Resolved Issues\n\n#### Task\n\n- Probar flujo de changelog Automatic  Jira: [SAN-86](https://htech.atlassian.net/browse/SAN-86)\n\n    Description: Se probara el flujo de changelog automatic.  \n\n    Changelog: Se agrega función para extraer texto del campo changelog del dashboard de Sanval y ponerlo directamente en el changelog.md del repositorio. \n\n\n            \n<!--- end changelog ver.v.<IP_ADDRESS> -->\n",
        "data": {}
    },
    {
        "id": 8,
        "title": "prueba-123-prod",
        "description": "\n<!--- start changelog ver.v.<IP_ADDRESS> -->\n### [v.<IP_ADDRESS>] - 2021-08-19\n#### Resolved Issues\n\n#### Task\n\n- Probar flujo de changelog Automatic  Jira: [SAN-86](https://htech.atlassian.net/browse/SAN-86)\n\n    Description: Se probara el flujo de changelog automatic.  \n\n    Changelog: Se agrega función para extraer texto del campo changelog del dashboard de Sanval y ponerlo directamente en el changelog.md del repositorio. \n\n\n            \n<!--- end changelog ver.v.<IP_ADDRESS> -->\n",
        "data": {}
    },
    {
        "id": 6,
        "title": "prueba-3-2",
        "description": "\n<!--- start changelog ver.v.<IP_ADDRESS> -->\n### [v.<IP_ADDRESS>] - 2021-07-29\n#### Resolved Issues\n\n#### Task\n\n- Probar flujo de changelog Automatic  Jira: [SAN-86](https://htech.atlassian.net/browse/SAN-86)\n\n    Description: Se probara el flujo de changelog automatic.  \n\n    Changelog: Se agrega función para extraer texto del campo changelog del dashboard de Sanval y ponerlo directamente en el changelog.md del repositorio. \n\n\n            \n<!--- end changelog ver.v.<IP_ADDRESS> -->\n",
        "data": {}
    }
]

The response I´m getting with ormar .dict() func
[
    {
        "id": 9,
        "title": "prueba-2321",
        "description": "\n<!--- start changelog ver.v.<IP_ADDRESS> -->\n### [v.<IP_ADDRESS>] - 2021-08-19\n#### Resolved Issues\n\n#### Task\n\n- Probar flujo de changelog Automatic  Jira: [SAN-86](https://htech.atlassian.net/browse/SAN-86)\n\n    Description: Se probara el flujo de changelog automatic.  \n\n    Changelog: Se agrega función para extraer texto del campo changelog del dashboard de Sanval y ponerlo directamente en el changelog.md del repositorio. \n\n\n            \n<!--- end changelog ver.v.<IP_ADDRESS> -->\n",
        "data": {},
        "tag": {
            "id": 18,
            "taglabel": null,
            "tagcommit": null,
            "tagissue": null
        },
        "changelogs": []
    },
    {
        "id": 8,
        "title": "prueba-123-prod",
        "description": "\n<!--- start changelog ver.v.<IP_ADDRESS> -->\n### [v.<IP_ADDRESS>] - 2021-08-19\n#### Resolved Issues\n\n#### Task\n\n- Probar flujo de changelog Automatic  Jira: [SAN-86](https://htech.atlassian.net/browse/SAN-86)\n\n    Description: Se probara el flujo de changelog automatic.  \n\n    Changelog: Se agrega función para extraer texto del campo changelog del dashboard de Sanval y ponerlo directamente en el changelog.md del repositorio. \n\n\n            \n<!--- end changelog ver.v.<IP_ADDRESS> -->\n",
        "data": {},
        "tag": {
            "id": 17,
            "taglabel": null,
            "tagcommit": null,
            "tagissue": null
        },
        "changelogs": []
    },
    {
        "id": 6,
        "title": "prueba-3-2",
        "description": "\n<!--- start changelog ver.v.<IP_ADDRESS> -->\n### [v.<IP_ADDRESS>] - 2021-07-29\n#### Resolved Issues\n\n#### Task\n\n- Probar flujo de changelog Automatic  Jira: [SAN-86](https://htech.atlassian.net/browse/SAN-86)\n\n    Description: Se probara el flujo de changelog automatic.  \n\n    Changelog: Se agrega función para extraer texto del campo changelog del dashboard de Sanval y ponerlo directamente en el changelog.md del repositorio. \n\n\n            \n<!--- end changelog ver.v.<IP_ADDRESS> -->\n",
        "data": {},
        "tag": {
            "id": 12,
            "taglabel": null,
            "tagcommit": null,
            "tagissue": null
        },
        "changelogs": []
    }
]

Do you mean you get 52s with those 3 models in response or is it just a sample structure?

Im getting the 52s in that exact response :((

Ok there is something seriously wrong here, the whole test suite of ormar runs under 40s on all backends and it's over 380 tests with queries a lot more nested than yours. Will try to check that.
So you use the latest version of ormar?

I can reproduce the same error with ormar 0.10.15 and 0.10.18

After some testing, I think that there's an issue of a circular call of this functions or something like that, the solution that I have on this moment is to create an instance to save relation_map on an static property of the class and it reduced the time by 1/3.

        print(dict_instance)
        if include and isinstance(include, Set):
            include = translate_list_to_dict(include)
        if exclude and isinstance(exclude, Set):
            exclude = translate_list_to_dict(exclude)

        start_time = time()
        if(self.__class__.__relation_model__ is None):
            relation_map = (
                relation_map
                if relation_map is not None
                else translate_list_to_dict(self._iterate_related_models())
            )
            self.__class__.__relation_model__ = relation_map
        else:
            relation_map = self.__class__.__relation_model__
        procces_time = time() - start_time
        print(procces_time)
        print(relation_map)

After making another call to the function im getting the same response on only 2.43 sec, so I think that my models are making a very big relation map.

After more tests, I reduced the time to 11ms after the second call.

Sorry for leaving to many comments, but im trying to solve the issue. I Founded that the func _iterate_related_models of class  RelationMixin is calling too many times, so I added a limit for the recursion. I really want to hear of you, if you consider an issue to put a recursion limit.

The whole point of relation map is to limit recurrency as otherwise you would have infinite loop between models. It seems i missed some kind of scenario, will check this out. The map itself should limit the recurrent calls.

Since the relation map iterates all relations tree do you mind sharing the remaining models (and other models if the remaining models have further relations)?
From the code above I miss: Tag, User, ChangeLog, Label, ProjectLabel and UserLabel

sorry for the delay, but here you have all my models
models.txt

Ok I managed to reproduce the slow results (although for sqlite it takes like 4s not 50(!) it's way too long).
Wrote a test based on your models and will try to optimize it.
@pytest.mark.asyncio
async def test_relation_dict():
    async with database:
        tags = [
            {"id": 18,
             "name": "name-18",
             "ref": "ref-18"},
            {"id": 17,
             "name": "name-17",
             "ref": "ref-17"},
            {"id": 12,
             "name": "name-12",
             "ref": "ref-12"}
        ]
        payload = [
            {
                "id": 9,
                "title": "prueba-2321",
                "description": "\n<!--- start changelog ver.v.<IP_ADDRESS> -->\n### [v.<IP_ADDRESS>] - 2021-08-19\n#### Resolved Issues\n\n#### Task\n\n- Probar flujo de changelog Automatic  Jira: [SAN-86](https://htech.atlassian.net/browse/SAN-86)\n\n    Description: Se probara el flujo de changelog automatic.  \n\n    Changelog: Se agrega función para extraer texto del campo changelog del dashboard de Sanval y ponerlo directamente en el changelog.md del repositorio. \n\n\n            \n<!--- end changelog ver.v.<IP_ADDRESS> -->\n",
                "data": {}
            },
            {
                "id": 8,
                "title": "prueba-123-prod",
                "description": "\n<!--- start changelog ver.v.<IP_ADDRESS> -->\n### [v.<IP_ADDRESS>] - 2021-08-19\n#### Resolved Issues\n\n#### Task\n\n- Probar flujo de changelog Automatic  Jira: [SAN-86](https://htech.atlassian.net/browse/SAN-86)\n\n    Description: Se probara el flujo de changelog automatic.  \n\n    Changelog: Se agrega función para extraer texto del campo changelog del dashboard de Sanval y ponerlo directamente en el changelog.md del repositorio. \n\n\n            \n<!--- end changelog ver.v.<IP_ADDRESS> -->\n",
                "data": {}
            },
            {
                "id": 6,
                "title": "prueba-3-2",
                "description": "\n<!--- start changelog ver.v.<IP_ADDRESS> -->\n### [v.<IP_ADDRESS>] - 2021-07-29\n#### Resolved Issues\n\n#### Task\n\n- Probar flujo de changelog Automatic  Jira: [SAN-86](https://htech.atlassian.net/browse/SAN-86)\n\n    Description: Se probara el flujo de changelog automatic.  \n\n    Changelog: Se agrega función para extraer texto del campo changelog del dashboard de Sanval y ponerlo directamente en el changelog.md del repositorio. \n\n\n            \n<!--- end changelog ver.v.<IP_ADDRESS> -->\n",
                "data": {}
            }
        ]
        saved_tags = []
        for tag in tags:
            saved_tags.append(await Tag(**tag).save())

        for ind, pay in enumerate(payload):
            await Release(**pay, tag=saved_tags[ind]).save()

        releases = await Release.objects.order_by(Release.id.desc()).all()
        dicts = [release.dict() for release in releases]

        result = [
            {
                "id": 9,
                "title": "prueba-2321",
                "description": "\n<!--- start changelog ver.v.<IP_ADDRESS> -->\n### [v.<IP_ADDRESS>] - 2021-08-19\n#### Resolved Issues\n\n#### Task\n\n- Probar flujo de changelog Automatic  Jira: [SAN-86](https://htech.atlassian.net/browse/SAN-86)\n\n    Description: Se probara el flujo de changelog automatic.  \n\n    Changelog: Se agrega función para extraer texto del campo changelog del dashboard de Sanval y ponerlo directamente en el changelog.md del repositorio. \n\n\n            \n<!--- end changelog ver.v.<IP_ADDRESS> -->\n",
                "data": {},
                "tag": {
                    "id": 18,
                    "taglabel": None,
                    "tagcommit": None,
                    "tagissue": None
                },
                "changelogs": []
            },
            {
                "id": 8,
                "title": "prueba-123-prod",
                "description": "\n<!--- start changelog ver.v.<IP_ADDRESS> -->\n### [v.<IP_ADDRESS>] - 2021-08-19\n#### Resolved Issues\n\n#### Task\n\n- Probar flujo de changelog Automatic  Jira: [SAN-86](https://htech.atlassian.net/browse/SAN-86)\n\n    Description: Se probara el flujo de changelog automatic.  \n\n    Changelog: Se agrega función para extraer texto del campo changelog del dashboard de Sanval y ponerlo directamente en el changelog.md del repositorio. \n\n\n            \n<!--- end changelog ver.v.<IP_ADDRESS> -->\n",
                "data": {},
                "tag": {
                    "id": 17,
                    "taglabel": None,
                    "tagcommit": None,
                    "tagissue": None
                },
                "changelogs": []
            },
            {
                "id": 6,
                "title": "prueba-3-2",
                "description": "\n<!--- start changelog ver.v.<IP_ADDRESS> -->\n### [v.<IP_ADDRESS>] - 2021-07-29\n#### Resolved Issues\n\n#### Task\n\n- Probar flujo de changelog Automatic  Jira: [SAN-86](https://htech.atlassian.net/browse/SAN-86)\n\n    Description: Se probara el flujo de changelog automatic.  \n\n    Changelog: Se agrega función para extraer texto del campo changelog del dashboard de Sanval y ponerlo directamente en el changelog.md del repositorio. \n\n\n            \n<!--- end changelog ver.v.<IP_ADDRESS> -->\n",
                "data": {},
                "tag": {
                    "id": 12,
                    "taglabel": None,
                    "tagcommit": None,
                    "tagissue": None
                },
                "changelogs": []
            }
        ]

        assert dicts == result

After making another call to the function I'm getting the same response on only 2.43 sec, so I think that my models are making a very big relation map.

Yep, due to tags linking many models, your relation map has... almost 2600 entries. 😱
I will have to optimize the algorithm on this as right now it's iterating the same models many times when comes to them from different related models. 🤔
In the meantime, I did what you tried to do - so cache the relation_map in each Model class.
Can you install ormar from the add_index branch (pip install git+https://github.com/collerek/ormar.git@add_index
) and let me know how that looks for you after the update?
Already the first call should be quicker, and the next one should be much quicker.
This is a nice optimization anyway, so thanks! 😃

Saving the relation map, improves a lot the time of making the dicts, but im still having a 10 sec time on my first request when trying to build the relation map, what I can suggest is to have a flag to limit the recursion. Thats the only way I can resolve my issue on calling the dict() func. What do you think?

WOOOW!!
It is awesome the new implimentation it is sooo fast!

Thanks for your help @collerek  and thanks for making ormar!

Fixed in #346


Production version shows console warning for development mode

Version
2.5.17
Reproduction link
https://vuejs.org/v2/guide/installation.html#Direct-lt-script-gt-Include
Steps to reproduce

Download production version, vue.min.js.
Add script to page and check console.

What is expected?
Production mode, no warnings
What is actually happening?
The following warnings appear:

Download the Vue Devtools extension for a better development experience:
https://github.com/vuejs/vue-devtools

You are running Vue in development mode.
Make sure to turn on production mode when deploying for production.
See more tips at https://vuejs.org/guide/deployment.html

Just kidding. Was pulling in the wrong file.


fix: remove out of gas link

:tada: This PR is included in version 2.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Various ENI related fixes

This change is

Coverage decreased (-0.02%) to 44.574% when pulling 68d13bbbf81bc1f8db81dc261c44d13f23a5ddcf on pr/tgraf/eni-fixes into 57fa7a626db1246f769557821ec721caf4d3d1e7 on master.

test-me-please

test-me-please


Definition needed for SaaS

Needs to be written and finalized for V2. Please request to be assigned to it and refer to the style guide before getting started.

@sandipanpanda, we added a bunch of new issues. Wanna work on any of them? If so, please check the project board. Your serverless definition was great! If you have time, we'd love you to contribute more!

@CathPag Thank you for the opportunity! I am ready and would love to contribute more. I am excited to pick up and work on the new issues!

Great! Let us know what you want to work on and we'll assign it to you :)

Shall I pick up this?

Sure! Didn't want to choose SaaS for you but if this sounds good, let's do it!

Sure! Didn't want to choose SaaS for you but if this sounds good, let's do it!

I am willing to take up and work on the issue that you find me a good fit for. Can you please choose and assign that to me if that's possible?

I already did, it's yours :)

@CathPag The spell check failed for the definition. Let me know if I can make changes to it.


[macOS] FlutterEngine caused Memory Leak after FlutterViewController was released

On macOS, after I create an extra FlutterViewController and release it, the memory allocated for the FlutterViewController is not totally released.

Steps to Reproduce

Create a macOS demo
Copy and paste 'Code Sample' into MainFlutterWindow.swift
flutter run --debug
The first window will be displayed after the Demo started, and the second window will show after 5 seconds.
Then we close the second window,  but the memory allocated for it is still exists. We think something wrong and caused the memory leak.

We can use Xcode Memeory Tools to observe the memory use:

Then we use Xcode Memory Graph Tools to observe Flutter instance:

We can see that, although FlutterViewController has been released, but the FlutterEngine still exists. This proves that FlutterEngine case the memory leak.
Expected results:
After releae the FlutterViewController, app memory usage should go back to the original level.
Actual results:
Something case memory leak.

Code sample
class MainFlutterWindow: NSWindow {
    override func awakeFromNib() {
        let flutterViewController = FlutterViewController.init()
        let windowFrame = self.frame
        self.contentViewController = flutterViewController
        self.setFrame(windowFrame, display: true)

        RegisterGeneratedPlugins(registry: flutterViewController)

        super.awakeFromNib()

        self.perform(#selector(showWindow2), with: nil, afterDelay: 5)
    }

    @objc func showWindow2() {

        let flutterViewController = FlutterViewController.init()
        var windowFrame = self.frame
        windowFrame.origin = CGPoint.init(x: windowFrame.origin.x + 50, y: windowFrame.origin.y + 50)

        let sub1Window = NSWindow(contentViewController: flutterViewController)
        sub1Window.contentViewController = flutterViewController
        sub1Window.setFrame(windowFrame, display: true)

        RegisterGeneratedPlugins(registry: flutterViewController)

        sub1Window.makeKeyAndOrderFront(nil)
    }
}

Logs
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 2.10.3, on macOS 12.1 21C52 darwin-arm, locale zh-Hans-CN)
[!] Android toolchain - develop for Android devices (Android SDK version 32.1.0-rc1)
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 13.2.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.1)
[✓] VS Code (version 1.65.2)
[✓] Connected device (2 available)
[✓] HTTP Host Availability

! Doctor found issues in 1 category.

Diagnosis and Suggestion
After a series of debug and giagnosis，we thound we found the cause of th bug.
In the dealloc method of  FlutterViewController, FlutterEngine's setViewController method will be called:

By design, _flutterViewController should not be nil, and flutterViewController is nil, then shutDownEngine should be called.
But acually, the FlutterViewController has into dealloc process, both _flutterViewController and flutterViewController is nil at this moment. So nothing FlutterEngine was leaked.
Suggestion
FlutterEngine can provide a semantically explicit emthod for FlutterViewController to call when the controller enter dealloc method.

@Taijuk
Can you check if you are hitting same issue as https://github.com/flutter/flutter/issues/63092 ?

@Taijuk Can you check if you are hitting same issue as #63092 ?

@darshankawar  Sorry I'm not sure. These two issues may be related, but not like the same.

@Taijuk
Is it specific to macOS only ? Can you run the same on iOS and see if you still get same behavior ?

@Taijuk Is it specific to macOS only ? Can you run the same on iOS and see if you still get same behavior ?

@darshankawar YES, this problem is macOS only.

Thanks for the update.

3. flutter run --debug

Does the same occur in --release mode too, because this mode is vital to know if the memory leaks happens or not.

Thanks for the update.

flutter run --debug

Does the same occur in --release mode too, because this mode is vital to know if the memory leaks happens or not.

@darshankawar YES. --release mode has the some issue.

Thanks for the update. I do see similar behavior wherein there's a memory leak and a spike after it, using the code sample and steps to replicate mentioned in original description.
May be similar / related: https://github.com/flutter/flutter/issues/63092

 stable, master flutter doctor -v

[✓] Flutter (Channel stable, 2.10.4, on macOS 12.2.1 21D62 darwin-x64, locale
    en-GB)
    • Flutter version 2.10.4 at /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c860cba910 (3 days ago), 2022-03-25 00:23:12 -0500
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

[✓] Flutter (Channel master, 2.13.0-0.0.pre.379, on macOS 12.2.1 21D62
    darwin-x64, locale en-GB)
    • Flutter version 2.13.0-0.0.pre.379 at
      /Users/dhs/documents/fluttersdk/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision bc0ec85717 (5 hours ago), 2022-04-04 17:27:18 -0700
    • Engine revision e7e7ca1252
    • Dart version 2.17.0 (build 2.17.0-266.0.dev)
    • DevTools version 2.12.1

[!] Xcode - develop for iOS and macOS (Xcode 12.3)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    ! Flutter recommends a minimum Xcode version of 13.
      Download the latest version or update via the Mac App Store.
    • CocoaPods version 1.11.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] VS Code (version 1.62.0)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.21.0

[✓] Connected device (5 available)
    • SM G975F (mobile)       • RZ8M802WY0X • android-arm64   • Android 11 (API 30)
    • Darshan's iphone (mobile)  • 21150b119064aecc249dfcfe05e259197461ce23 •
      ios            • iOS 14.4.1 18D61
    • iPhone 12 Pro Max (mobile) • A5473606-0213-4FD8-BA16-553433949729     •
      ios            • com.apple.CoreSimulator.SimRuntime.iOS-14-3 (simulator)
    • macOS (desktop)            • macos                                    •
      darwin-x64     • Mac OS X 10.15.4 19E2269 darwin-x64
    • Chrome (web)               • chrome                                   •
      web-javascript • Google Chrome 98.0.4758.80

[✓] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

Thank you so much for the very detailed writeup and investigation! Just to confirm, have you tried your patch and see if the problem is gone?

Thank you so much for the very detailed writeup and investigation! Just to confirm, have you tried your patch and see if the problem is gone?

@dkwingsmt Yes, I have tried my 'workaround' solution, and the memory reduced after the FlutterViewController been released.

Would you like to submit a PR?

Great! Would you like to write up a PR yourself? Or, why do you call it only a workaround?

@dkwingsmt I'am not particularly familiar with FlutterEngine architecture, so I'am not sure if it's a proper solution😄.

cc @cbracken

Could this be similar to/the same issue as https://github.com/flutter/flutter/issues/96487?

Did you try to call destroyContext ?
https://api.flutter.dev/objcdoc/Classes/FlutterEngine.html#/c:objc(cs)FlutterEngine(im)destroyContext


Add strongly typed options to Intl modules

Good stuff @glennsl ! Ready to merge?

As far as I'm aware, yes. I wouldn't count out having made some mistakes though, so a thorough review wouldn't be a bad idea.

@glennsl Thanks!
There is also #65 (a more encompassing Intl bindings PR). One difference I see is that #65 distinguishes between Intl.Collator.options, Intl.Collator.resolvedOptions and Intl.Collator.supportedLocalesOptions.
Also see the discussion there starting with https://github.com/rescript-association/rescript-core/pull/65#issuecomment-1872567799 (polymorphic variants vs. regular variants).

There is also #65 (a more encompassing Intl bindings PR). One difference I see is that #65 distinguishes between Intl.Collator.options, Intl.Collator.resolvedOptions and Intl.Collator.supportedLocalesOptions.
Also see the discussion there starting with #65 (comment) (polymorphic variants vs. regular variants).

Ah, I've missed that. That's so much better! This is mostly just a lazy copy of my own bindings with some additions to flesh it out. I'll just close this and comment over there then.


storage/filesystem: avoid norwfs build flag

norwfs build flag was used to work on filesystems that do not support neither opening a file in read/write mode or renaming a file (e.f. sivafs).
This had two problems:

go-git could not be compiled to work properly both with regular filesystems and limited filesystems at the same time.
the norwfs trick was not available on Windows.

This PR removes the norwfs build flag, as well as the windows conditional flag on the dotgit package.
For the file open mode, we use the new billy capabilities, to check at runtime if the filesystem supports opening a file in read/write mode or not.
For the renaming, we just try and fallback to alternative methods if billy.ErrNotSupported is returned.
Signed-off-by: Santiago M. Mola<EMAIL_ADDRESS>

This depends on billy capabilities, which should be released soon (cc @jfontan). go-billy-siva also needs to be updated to report capabilities properly for this to work properly.


Invoking introMessage once per session?

Hey, I just have a question- how can I invoke the introMessage popup only once in React Native?
I noticed that in the instabug-iOS library you guys have a way of doing this as specified in this ticket: https://github.com/Instabug/Instabug-iOS/issues/66
Is there any place I can look for a way of doing this in the documentation?
Thank you.

Hey @natasha-robarge
Apologies for the late reply on this.
Yes you can indeed.
Set Instabug.setIntroMessageEnabled(false) and then invoke the API Instabug.showIntroMessage(); to invoke the SDK.
You can find all the details about this in out docs here


Order swagger input files

Fixes #5556

@maririos @chidozieononiwu when might this get deployed? The API Stewardship Board really needs this diffing functionality to be more effective. Hopefully this is enough for now.

@ruowan could you help us here on what the process needed is?

One thing needs to be done is to update version variable in this pipeline. https://dev.azure.com/azure-sdk/internal/_build?definitionId=1736.  I updated this version variable.

@ruowan thank you! so that means that any APIView generated from the spects repo will use this change.
In order to update the parser for manual uploads I created: https://github.com/Azure/azure-sdk-tools/pull/5583


monitor notices look weird

I have WeeChat in ZNC monitoring for some messages and Communi also receives the monitor messages (*route_replies doesn't seem to affect them). I see the numerics.
[731] NickServ
[730] NickServ!NickServ@services.

also wallops
? tomaw WALLOPS I need to do a minor services upgrade so NickServ and friends will be gone for a moment
If I recall correctly, you might have done something to monitor after the latest test build which I installed. Do you have any openrepos repository for test or daily builds or any plans?

Sorry, I'm unfamiliar with ZNC. Can you please explain this issue in more detail?

http://ircv3.net/specs/core/monitor-3.2.html
and based on the first line this is ZNC bug and I don't see where Communi Sailfish would need monitor.

communi-desktop monitors the targets of all open queries and shows the ones
that are offline as gray. perhaps communi-sailfish could do the same. it's
quite convenient :)
On Tue, Aug 18, 2015, 16:09 Mikaela Suomalainen<EMAIL_ADDRESS>wrote:

http://ircv3.net/specs/core/monitor-3.2.html
and based on the first line this is ZNC bug and I don't see where Communi
Sailfish would need monitor.
—
Reply to this email directly or view it on GitHub
https://github.com/communi/communi-sailfish/issues/106#issuecomment-132221663
.

update libcommuni submodule
IrcBufferModel::monitorEnabled=true
use IrcBuffer::active to determine whether the buffer should be "grayed out"

The same IrcBuffer::active property works for channels (active=true when the user is on the channel), but I don't remember if communi-sailfish visualizes that anyhow.


ARROW-13154: [C++] Remove the undocumented type_code <= 125 restriction in union types

For DENSE_UNION and SPARSE_UNION type_code must not be 126 or 127 which is not intended. This has been fixed. Furthermore array_union_test.cc has been modified to test for whether 127 is allowed as a type_code without errors.

@pitrou  Could you please review it? Really thanks!


Add "Last update" date as title to versionInfo

As discussed here

(The screenshot doesn't show my cursor, but it's hovering over the version)
Also adds a parseDate() function, because Firefox's Date.parse chokes on the format used in appdates.csv

This is great, thank you!


Changes in Endorser Protocol

This is a WIP Pull Request. It consists of the following changes of endorser protocol.

#1028
#1040

Looks pretty good, couple of changes requested.
FYI when I tested the flow, when I endorsed the transaction (as the Endorser) the status was actually returned to the Author as "refused".

Let me check this again, the last I checked, I was able to write the endorsed transaction to the ledger from Author's Agent.

Looks pretty good, couple of changes requested.
FYI when I tested the flow, when I endorsed the transaction (as the Endorser) the status was actually returned to the Author as "refused".

Let me check this again, the last I checked, I was able to write the endorsed transaction to the ledger from Author's Agent.

I checked this, It works for me, I am getting an "endorsed" transaction, that I am able to submit to ledger.
Is there any specific way that I should test?

Looks pretty good, couple of changes requested.
FYI when I tested the flow, when I endorsed the transaction (as the Endorser) the status was actually returned to the Author as "refused".

Let me check this again, the last I checked, I was able to write the endorsed transaction to the ledger from Author's Agent.

I checked this, It works for me, I am getting an "endorsed" transaction, that I am able to submit to ledger.
Is there any specific way that I should test?

I re-tested and was able to successfully write a schema to the ledger

Checked out the latest code and gave it a test run, looking good!
Just need to change the schema/cred def screen to take the endorser name instead of the connection id, and fix up the integration test.

Closing this PR, a new PR would be created to overcome the problems caused by git merge conflicts.

A new PR has been raised that contains the exact changes.
The new PR is :- #1116


Fix release script grep error

Fixes #34
This PR ...
replaced grep with sed due to errors with windows git bash.
The script should now run on all platforms.

Checklist

Checklist for Contributors

[x] Unit tests provided?
Unit tests are needed for new features or to reproduce the bug solved by this PR.
[x] Documentation updated?
[x] Unit tests successful
[x] Code smells (flake8) checked

Checklist for Reviewers

[ ] Read PR description
[ ] Check linked issue
[ ] Check CI/CD (build, automated tests, linting, preview build)
[ ] Check documentation changes
[ ] Add labels to PR

Codecov Report

Merging #37 (eb082e4) into main (02cba51) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   90.37%   90.37%
=======================================
  Files          72       72
  Lines        1153     1153
=======================================
  Hits         1042     1042
  Misses        111      111

Flag
Coverage Δ

pytest
90.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02cba51...eb082e4. Read the comment docs.


Update fonts_config to have default fonts and include calibre

@josephco Here's PR that creates the fonts repo https://github.com/CasperSleep/nightshade-fonts/pull/1. Would be great to get CR from you, too.
I'm still waiting to hear from JP about which URL you can use, but for now this path gives you https://s3.amazonaws.com/nightshade-fonts/fonts.min.css


Get block hash const libfunc

TITLE
Description
Description of the pull request changes and motivation.
Checklist

[ ] Linked to Github Issue
[ ] Unit tests added
[ ] Integration tests added.
[ ] This change requires new documentation.

[ ] Documentation has been added/updated.

Codecov Report
Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (b7f4a77) 73.90% compared to head (1ed3c5c) 73.80%.
Report is 1 commits behind head on main.

Files
Patch %
Lines

src/libfuncs/stark_net.rs
0.00%
34 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
- Coverage   73.90%   73.80%   -0.11%
==========================================
  Files          97       97
  Lines       22153    22184      +31
==========================================
  Hits        16372    16372
- Misses       5781     5812      +31

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Colorization Discrepancies between settings, source, and tooltips

Currently the intellisense tooltips seem to match my color settings better than the source code, but the tooltips have some internal discrepancies too.
These are my color settings

For C# everything matches

For F#.......not so much

Issues in the Source Coloring -

Classes are colored as modules instead of using their own color
Interfaces are colored as modules instead of using their own color
Structs are colored as modules instead of using their own color
Generics/Type Parameters are colored as modules instead of using their own color
In Generics ' is not colored the same as the rest of the parameter name
Some punctuation is not colored
Some punctuation is colored incorrectly as operators
Fully Qualified Union Cases aren't colored

Issues in the Tooltip Coloring -

<- is colored as punctuation instead of as a keyword
Interfaces and Classes are colored as structs in the body of the signature instead of using their respective colors
[] is colored as punctuation instead of as a Class
Methods/members are not colored

Since it has already been necessary to create new categories specific to F# I think it would be better to have all of the construct categories be language specific instead of trying to share with C#
C++ takes that approach.

Also I'd like to note that I think coloring constructs like obj and int32 as keywords is a bad convention because these types can be aliased over but they're still colored as keywords and although obj is a class and int32 is a struct they're colored the same as module,begin,andend? 😕
If it's a class, color it like all the other classes, if it's a struct color it like all the other structs
cc @vasily-kirichenko
Related information
VS 2017 with VisualFSharpOpenSource.vsix built off of master @ b89d98e692cd3caac0b8cd29529c90e60304d830

Quick info uses TaggedText, as far as I know, we cannot add new tags. TBH, I don't understand the way Roslyn matches, say, TextTag.Enum and enum classification to get the proper color.
About not respecting colors for modules, struct, etc in the editor, we just pass Roslyn classification type names here https://github.com/Microsoft/visualfsharp/blob/master/vsintegration/src/FSharp.Editor/Classification/ClassificationDefinitions.fs#L28. If it does not work, we should investigate why. I don't think it's a major bug though.

Looks like custom tags would be possible if we implemented our own IDeferredQuickInfoContent for use here:
https://github.com/Microsoft/visualfsharp/blob/master/vsintegration/src/FSharp.Editor/QuickInfo/QuickInfoProvider.fs#L78

Cases are now being colored for DUs but not for Enums

Enum cases don't have a construct name

Enum cases are listed as fields in tooltips on right side of pattern match

built off of master @ 331dde6aa9e37930eed1bdf2dd81f8da8ac53790

Not sure what's going on in lex.fs

built off of master @ 331dde6aa9e37930eed1bdf2dd81f8da8ac53790

Your color theme is so strange that I barely see any colorization issues there, sorry. Draw arrows with text like "this thing should be colored with green".

in lex.fs there are many things going wrong in the colorization, e.g. the color changes mid identifier

Qualified enum cases are not being colored

You can click on the imgs to open them at full resolution in a new tab

@cloudRoutine Could you split off another issue for the structured guidelines problem?  Thanks!
Interesting how colorization in lex.fs is so off with your settings.  Either way, good finds.

@cartermp what do you mean?  We can either revert it or investigate what's wrong. Could anybody review it? https://github.com/Microsoft/visualfsharp/pull/2402/files

@cloudRoutine #2722 also fixed enum case colouring

@cloudroutine:

the color changes mid identifier

it looks like a +1 / -1 thing on line number for this case, look how "trimBoth length" matches the color expected on above line.

@cloudRoutine @smoothdeveloper - notice the # 3 directive - I think everything's shifted by 2 lines.

@cloudRoutine Can we close this or should we complete every item mentioned above?

Closing as the major issues have been fixed

Also worth noting that source and tooltips are more aligned now in terms of coloring and tagging. And tooltips also structure classes/structs/interfaces consistently regardless of if it's F#-defined or .NET defined


Add: Power set of a set of elements

Is your feature request related to a problem? Please describe.
Given a set of elements, typically represented as an array, generate all possible subsets of that set, including the empty set and the set itself.
Describe the solution you'd like
To generate the power set, we can use an iterative approach that builds the power set incrementally. We start with an empty set, and then for each element in the original set, we consider whether to include or exclude it in each existing subset.
Please assign this to me under SSo'C 23.

Assigned!
@black-shirt : C, C++, Java & Python

please assign me this task under SSOC'2
can implement in c,c++,python

@black-shirt I am unassigning this issue and closing this issue due to inactivity

Sir please assign me this issue
I can work in all the languages


Data Bricks and Key Vault Stencils Missing?

I don't see "Data Bricks" or "Key Vault" stencils in this collection.
Any plans on adding them?
Thanks,
Sean

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6624d44c-f9f6-02f8-2c67-0f0637fed62e
Version Independent ID: 9346a8ff-bab5-be2c-9dc1-d546fda1efa9
Content: Azure Icons - Azure Architecture Center
Content Source: docs/icons/index.md
Service: architecture-center
GitHub Login: @doodlemania2
Microsoft Alias: pnp

@MilfordSound - Azure Databricks and Key Vault icons are now included.


Add a "columns" like Terminal Preview to check foreground readability on colored backgrounds

Would be useful to add a "columns" like Terminal Preview to check the readability of different foreground colors on colored backgrounds.
Example:

Great idea! I'll see what I can do here :+1:

There we go!


Don't set FFT work area when gained work area size is zero

hipfftMakePlan1d can output zero for the work area size, and given a null pointer returned by the allocator that supplied zero for the size, hipfftSetWorkArea (internally calls rocfft_execution_info_set_work_buffer) returns HIPFFT_INVALID_VALUE.
This PR fixes Plan1d not to set the work area pointer if the computed work area size is zero. Also PlanNd has the same fix.

I mistakenly pushed the branch to cupy repo instead of mine. Let me close this PR and post the correct one again.

Removed the branch.

Thanks!