(FACT-1502) acceptance: mount a tmpfs directory and check the fact

New acceptance test for verifying that 'facter mountpoints' show a tmpfs mount.
[skip ci]

CLA signed by all contributors.

Verified that the test passes, 👍 from me except for those nitpicks

Thanks @Magisus and @glennsarti for the review, I just pushed a new update based on @Magisus feedback

Perhaps we want to check that puppet successfully applied the catalog and resources were changed? If so I think we want detailed exit codes and to check for the right one.

+1 to @MosesMendoza 's comment

@Magisus @MosesMendoza @glennsarti : updated acceptable exit codes.


tests: timer: timer_behavior:  add a tick align

Add a tick align to reduce errors of calculating the spending cycles.

Backport of d37bd2eb3fb7482e295f8cc992b361b96767a684


[Misc] Modify BNB parameter name

As reviewed in https://github.com/vllm-project/vllm/pull/9917#discussion_r1826623757
BTW, fix the Resampler prefix bug
ping @mgoin

@mgoin  It looks like the CI failure is not due to this PR


New loading screen

A new loading screen that looks prettier

See game's PR here: https://github.com/OnionGalaxy/TwinlightSouls/pull/128

I'm closing this because branch doesn't follow naming style, and branch rules doesn't apply. Naming style here

-.- We're not even using the git flow plugin and without it the naming style for a branch is pretty much a waste of time


Computer crashed, now getting errors and can't populate map

2016-09-06 15:23:52,856 [       scan] [  ERROR] database disk image is malformed
2016-09-06 15:23:52,857 [       scan] [  ERROR] Unexpected error while parsing response.
I'm running this on OSX so things are a bit weird with the Applications Support folder anyway and I'm a bit confused how to work with all of this since my background is Windows.
I'm also seeing this message:
DatabaseError: database disk image is malformed
What all should I remove so it can recreate files as if I'm running this for the first time?

Delete pogom.db in your pogom folder

@favll I did that, in both the running folder and the applications support folder, and it's still throwing errors when it finds pokemon.
I tried deleting the applications support/pogo and just install it again from requirements.txt and it just tells me it's already installed. Any idea how I wipe it out and start over? Or is there something ELSE I need to delete to get back in order from my already-installed solution?

Amanda-Baylesss-iMac-2:~ emo_flamingo$ python 'downloads/pogom-master/runserver.py' -H "<IP_ADDRESS>" -P "5000"
2016-09-06 16:34:43,333 [     pgoapi] [   INFO] pgoapi v1.1.7 - Copyright (c) 2016 tjado https://github.com/tejado
[2016-09-06 16:34:46,619] ERROR in app: Exception on /map-data [GET]
Traceback (most recent call last):
File "/Library/Python/2.7/site-packages/flask/app.py", line 1988, in wsgi_app
response = self.full_dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request
rv = self.dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1625, in dispatch_request
return self.view_functionsrule.endpoint
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/app.py", line 171, in map_data
d['pokemons'] = Pokemon.get_active()
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/models.py", line 59, in get_active
for p in query:
File "/Library/Python/2.7/site-packages/peewee.py", line 2967, in iter
return iter(self.execute())
File "/Library/Python/2.7/site-packages/peewee.py", line 2960, in execute
self._qr = ResultWrapper(model_class, self._execute(), query_meta)
File "/Library/Python/2.7/site-packages/peewee.py", line 2656, in _execute
return self.database.execute_sql(sql, params, self.require_commit)
File "/Library/Python/2.7/site-packages/peewee.py", line 3492, in execute_sql
self.commit()
File "/Library/Python/2.7/site-packages/peewee.py", line 3316, in exit
reraise(new_type, new_type(*exc_args), traceback)
File "/Library/Python/2.7/site-packages/peewee.py", line 3485, in execute_sql
cursor.execute(sql, params or ())
DatabaseError: database disk image is malformed
2016-09-06 16:34:46,619 [        app] [  ERROR] Exception on /map-data [GET]
Traceback (most recent call last):
File "/Library/Python/2.7/site-packages/flask/app.py", line 1988, in wsgi_app
response = self.full_dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request
rv = self.dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1625, in dispatch_request
return self.view_functionsrule.endpoint
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/app.py", line 171, in map_data
d['pokemons'] = Pokemon.get_active()
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/models.py", line 59, in get_active
for p in query:
File "/Library/Python/2.7/site-packages/peewee.py", line 2967, in iter
return iter(self.execute())
File "/Library/Python/2.7/site-packages/peewee.py", line 2960, in execute
self._qr = ResultWrapper(model_class, self._execute(), query_meta)
File "/Library/Python/2.7/site-packages/peewee.py", line 2656, in _execute
return self.database.execute_sql(sql, params, self.require_commit)
File "/Library/Python/2.7/site-packages/peewee.py", line 3492, in execute_sql
self.commit()
File "/Library/Python/2.7/site-packages/peewee.py", line 3316, in exit
reraise(new_type, new_type(*exc_args), traceback)
File "/Library/Python/2.7/site-packages/peewee.py", line 3485, in execute_sql
cursor.execute(sql, params or ())
DatabaseError: database disk image is malformed
[2016-09-06 16:34:56,618] ERROR in app: Exception on /map-data [GET]
Traceback (most recent call last):
File "/Library/Python/2.7/site-packages/flask/app.py", line 1988, in wsgi_app
response = self.full_dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request
rv = self.dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1625, in dispatch_request
return self.view_functionsrule.endpoint
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/app.py", line 171, in map_data
d['pokemons'] = Pokemon.get_active()
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/models.py", line 59, in get_active
for p in query:
File "/Library/Python/2.7/site-packages/peewee.py", line 2967, in iter
return iter(self.execute())
File "/Library/Python/2.7/site-packages/peewee.py", line 2960, in execute
self._qr = ResultWrapper(model_class, self._execute(), query_meta)
File "/Library/Python/2.7/site-packages/peewee.py", line 2656, in _execute
return self.database.execute_sql(sql, params, self.require_commit)
File "/Library/Python/2.7/site-packages/peewee.py", line 3492, in execute_sql
self.commit()
File "/Library/Python/2.7/site-packages/peewee.py", line 3316, in exit
reraise(new_type, new_type(*exc_args), traceback)
File "/Library/Python/2.7/site-packages/peewee.py", line 3485, in execute_sql
cursor.execute(sql, params or ())
DatabaseError: database disk image is malformed
2016-09-06 16:34:56,618 [        app] [  ERROR] Exception on /map-data [GET]
Traceback (most recent call last):
File "/Library/Python/2.7/site-packages/flask/app.py", line 1988, in wsgi_app
response = self.full_dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request
rv = self.dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1625, in dispatch_request
return self.view_functionsrule.endpoint
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/app.py", line 171, in map_data
d['pokemons'] = Pokemon.get_active()
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/models.py", line 59, in get_active
for p in query:
File "/Library/Python/2.7/site-packages/peewee.py", line 2967, in iter
return iter(self.execute())
File "/Library/Python/2.7/site-packages/peewee.py", line 2960, in execute
self._qr = ResultWrapper(model_class, self._execute(), query_meta)
File "/Library/Python/2.7/site-packages/peewee.py", line 2656, in _execute
return self.database.execute_sql(sql, params, self.require_commit)
File "/Library/Python/2.7/site-packages/peewee.py", line 3492, in execute_sql
self.commit()
File "/Library/Python/2.7/site-packages/peewee.py", line 3316, in exit
reraise(new_type, new_type(*exc_args), traceback)
File "/Library/Python/2.7/site-packages/peewee.py", line 3485, in execute_sql
cursor.execute(sql, params or ())
DatabaseError: database disk image is malformed
[2016-09-06 16:35:10,058] ERROR in app: Exception on /map-data [GET]
Traceback (most recent call last):
File "/Library/Python/2.7/site-packages/flask/app.py", line 1988, in wsgi_app
response = self.full_dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request
rv = self.dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1625, in dispatch_request
return self.view_functionsrule.endpoint
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/app.py", line 171, in map_data
d['pokemons'] = Pokemon.get_active()
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/models.py", line 59, in get_active
for p in query:
File "/Library/Python/2.7/site-packages/peewee.py", line 2967, in iter
return iter(self.execute())
File "/Library/Python/2.7/site-packages/peewee.py", line 2960, in execute
self._qr = ResultWrapper(model_class, self._execute(), query_meta)
File "/Library/Python/2.7/site-packages/peewee.py", line 2656, in _execute
return self.database.execute_sql(sql, params, self.require_commit)
File "/Library/Python/2.7/site-packages/peewee.py", line 3492, in execute_sql
self.commit()
File "/Library/Python/2.7/site-packages/peewee.py", line 3316, in exit
reraise(new_type, new_type(*exc_args), traceback)
File "/Library/Python/2.7/site-packages/peewee.py", line 3485, in execute_sql
cursor.execute(sql, params or ())
DatabaseError: database disk image is malformed
2016-09-06 16:35:10,058 [        app] [  ERROR] Exception on /map-data [GET]
Traceback (most recent call last):
File "/Library/Python/2.7/site-packages/flask/app.py", line 1988, in wsgi_app
response = self.full_dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request
rv = self.dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1625, in dispatch_request
return self.view_functionsrule.endpoint
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/app.py", line 171, in map_data
d['pokemons'] = Pokemon.get_active()
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/models.py", line 59, in get_active
for p in query:
File "/Library/Python/2.7/site-packages/peewee.py", line 2967, in iter
return iter(self.execute())
File "/Library/Python/2.7/site-packages/peewee.py", line 2960, in execute
self._qr = ResultWrapper(model_class, self._execute(), query_meta)
File "/Library/Python/2.7/site-packages/peewee.py", line 2656, in _execute
return self.database.execute_sql(sql, params, self.require_commit)
File "/Library/Python/2.7/site-packages/peewee.py", line 3492, in execute_sql
self.commit()
File "/Library/Python/2.7/site-packages/peewee.py", line 3316, in exit
reraise(new_type, new_type(*exc_args), traceback)
File "/Library/Python/2.7/site-packages/peewee.py", line 3485, in execute_sql
cursor.execute(sql, params or ())
DatabaseError: database disk image is malformed
[2016-09-06 16:35:18,701] ERROR in app: Exception on /map-data [GET]
Traceback (most recent call last):
File "/Library/Python/2.7/site-packages/flask/app.py", line 1988, in wsgi_app
response = self.full_dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request
rv = self.dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1625, in dispatch_request
return self.view_functionsrule.endpoint
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/app.py", line 171, in map_data
d['pokemons'] = Pokemon.get_active()
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/models.py", line 59, in get_active
for p in query:
File "/Library/Python/2.7/site-packages/peewee.py", line 2967, in iter
return iter(self.execute())
File "/Library/Python/2.7/site-packages/peewee.py", line 2960, in execute
self._qr = ResultWrapper(model_class, self._execute(), query_meta)
File "/Library/Python/2.7/site-packages/peewee.py", line 2656, in _execute
return self.database.execute_sql(sql, params, self.require_commit)
File "/Library/Python/2.7/site-packages/peewee.py", line 3492, in execute_sql
self.commit()
File "/Library/Python/2.7/site-packages/peewee.py", line 3316, in exit
reraise(new_type, new_type(*exc_args), traceback)
File "/Library/Python/2.7/site-packages/peewee.py", line 3485, in execute_sql
cursor.execute(sql, params or ())
DatabaseError: database disk image is malformed
2016-09-06 16:35:18,701 [        app] [  ERROR] Exception on /map-data [GET]
Traceback (most recent call last):
File "/Library/Python/2.7/site-packages/flask/app.py", line 1988, in wsgi_app
response = self.full_dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request
rv = self.dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1625, in dispatch_request
return self.view_functionsrule.endpoint
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/app.py", line 171, in map_data
d['pokemons'] = Pokemon.get_active()
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/models.py", line 59, in get_active
for p in query:
File "/Library/Python/2.7/site-packages/peewee.py", line 2967, in iter
return iter(self.execute())
File "/Library/Python/2.7/site-packages/peewee.py", line 2960, in execute
self._qr = ResultWrapper(model_class, self._execute(), query_meta)
File "/Library/Python/2.7/site-packages/peewee.py", line 2656, in _execute
return self.database.execute_sql(sql, params, self.require_commit)
File "/Library/Python/2.7/site-packages/peewee.py", line 3492, in execute_sql
self.commit()
File "/Library/Python/2.7/site-packages/peewee.py", line 3316, in exit
reraise(new_type, new_type(*exc_args), traceback)
File "/Library/Python/2.7/site-packages/peewee.py", line 3485, in execute_sql
cursor.execute(sql, params or ())
DatabaseError: database disk image is malformed
[2016-09-06 16:35:28,953] ERROR in app: Exception on /map-data [GET]
Traceback (most recent call last):
File "/Library/Python/2.7/site-packages/flask/app.py", line 1988, in wsgi_app
response = self.full_dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request
rv = self.dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1625, in dispatch_request
return self.view_functionsrule.endpoint
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/app.py", line 171, in map_data
d['pokemons'] = Pokemon.get_active()
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/models.py", line 59, in get_active
for p in query:
File "/Library/Python/2.7/site-packages/peewee.py", line 2967, in iter
return iter(self.execute())
File "/Library/Python/2.7/site-packages/peewee.py", line 2960, in execute
self._qr = ResultWrapper(model_class, self._execute(), query_meta)
File "/Library/Python/2.7/site-packages/peewee.py", line 2656, in _execute
return self.database.execute_sql(sql, params, self.require_commit)
File "/Library/Python/2.7/site-packages/peewee.py", line 3492, in execute_sql
self.commit()
File "/Library/Python/2.7/site-packages/peewee.py", line 3316, in exit
reraise(new_type, new_type(*exc_args), traceback)
File "/Library/Python/2.7/site-packages/peewee.py", line 3485, in execute_sql
cursor.execute(sql, params or ())
DatabaseError: database disk image is malformed
2016-09-06 16:35:28,953 [        app] [  ERROR] Exception on /map-data [GET]
Traceback (most recent call last):
File "/Library/Python/2.7/site-packages/flask/app.py", line 1988, in wsgi_app
response = self.full_dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request
rv = self.dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1625, in dispatch_request
return self.view_functionsrule.endpoint
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/app.py", line 171, in map_data
d['pokemons'] = Pokemon.get_active()
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/models.py", line 59, in get_active
for p in query:
File "/Library/Python/2.7/site-packages/peewee.py", line 2967, in iter
return iter(self.execute())
File "/Library/Python/2.7/site-packages/peewee.py", line 2960, in execute
self._qr = ResultWrapper(model_class, self._execute(), query_meta)
File "/Library/Python/2.7/site-packages/peewee.py", line 2656, in _execute
return self.database.execute_sql(sql, params, self.require_commit)
File "/Library/Python/2.7/site-packages/peewee.py", line 3492, in execute_sql
self.commit()
File "/Library/Python/2.7/site-packages/peewee.py", line 3316, in exit
reraise(new_type, new_type(*exc_args), traceback)
File "/Library/Python/2.7/site-packages/peewee.py", line 3485, in execute_sql
cursor.execute(sql, params or ())
DatabaseError: database disk image is malformed
[2016-09-06 16:35:41,367] ERROR in app: Exception on /map-data [GET]
Traceback (most recent call last):
File "/Library/Python/2.7/site-packages/flask/app.py", line 1988, in wsgi_app
response = self.full_dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request
rv = self.dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1625, in dispatch_request
return self.view_functionsrule.endpoint
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/app.py", line 171, in map_data
d['pokemons'] = Pokemon.get_active()
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/models.py", line 59, in get_active
for p in query:
File "/Library/Python/2.7/site-packages/peewee.py", line 2967, in iter
return iter(self.execute())
File "/Library/Python/2.7/site-packages/peewee.py", line 2960, in execute
self._qr = ResultWrapper(model_class, self._execute(), query_meta)
File "/Library/Python/2.7/site-packages/peewee.py", line 2656, in _execute
return self.database.execute_sql(sql, params, self.require_commit)
File "/Library/Python/2.7/site-packages/peewee.py", line 3492, in execute_sql
self.commit()
File "/Library/Python/2.7/site-packages/peewee.py", line 3316, in exit
reraise(new_type, new_type(*exc_args), traceback)
File "/Library/Python/2.7/site-packages/peewee.py", line 3485, in execute_sql
cursor.execute(sql, params or ())
DatabaseError: database disk image is malformed
2016-09-06 16:35:41,367 [        app] [  ERROR] Exception on /map-data [GET]
Traceback (most recent call last):
File "/Library/Python/2.7/site-packages/flask/app.py", line 1988, in wsgi_app
response = self.full_dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1641, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1544, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/Library/Python/2.7/site-packages/flask/app.py", line 1639, in full_dispatch_request
rv = self.dispatch_request()
File "/Library/Python/2.7/site-packages/flask/app.py", line 1625, in dispatch_request
return self.view_functionsrule.endpoint
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/app.py", line 171, in map_data
d['pokemons'] = Pokemon.get_active()
File "/Users/emo_flamingo/Downloads/pogom-master/pogom/models.py", line 59, in get_active
for p in query:
File "/Library/Python/2.7/site-packages/peewee.py", line 2967, in iter
return iter(self.execute())
File "/Library/Python/2.7/site-packages/peewee.py", line 2960, in execute
self._qr = ResultWrapper(model_class, self._execute(), query_meta)
File "/Library/Python/2.7/site-packages/peewee.py", line 2656, in _execute
return self.database.execute_sql(sql, params, self.require_commit)
File "/Library/Python/2.7/site-packages/peewee.py", line 3492, in execute_sql
self.commit()
File "/Library/Python/2.7/site-packages/peewee.py", line 3316, in exit
reraise(new_type, new_type(*exc_args), traceback)
File "/Library/Python/2.7/site-packages/peewee.py", line 3485, in execute_sql
cursor.execute(sql, params or ())
DatabaseError: database disk image is malformed

So..I'm thinking it's Python that's screwed up, not anything to do with Pogo Map at all. Wonderful..time to figure out how to restore that to factory ;(


Transfer dies over long distances/bad connections

I guess it's because the sending side closes the connection after it thinks it has finished.

Codebase renews itself... closing.


Bug mne.cov.compute_covariance + multiprocessing

Hi,
I just want to mention that I used the mne.cov.compute_covariance function and it works with n_jobs =1 (as in the example) but if I put more jobs, I have the following error message:
File "/usr/lib/python2.7/multiprocessing/pool.py", line 558, in get
raise self._value
PicklingError: Can't pickle <class 'mne.cov._ShrunkCovariance'>: it's not found as mne.cov._ShrunkCovariance

Ah that's annoying. We did not have that before. Cannot take a look right
now. We should bisect and see when this came up. Laetita btw. you can use
MKL + Anaconda. In my experience it will be faster than using joblib here.
On Tue, Sep 29, 2015 at 11:59 AM, LaetitiaG<EMAIL_ADDRESS>wrote:

Hi,
I just want to mention that I used the mne.cov.compute_covariance function
and it works with n_jobs =1 (as in the example) but if I put more jobs, I
have the following error message:
File "/usr/lib/python2.7/multiprocessing/pool.py", line 558, in get
raise self._value
PicklingError: Can't pickle : it's not found as mne.cov._ShrunkCovariance
—
Reply to this email directly or view it on GitHub
https://github.com/mne-tools/mne-python/issues/2497.

denis can you reproduce?

I'm going to go ahead and close this as an isolated upstream bug (probably multiprocessing), but if it comes back up or is still happening, let's reopen


[security vulnerability]: GO (Go) Security Update for github.com/cilium/cilium (GHSA-wh78-7948-358j)

Issue
Sensitive information leak in cilium-bugtool
Fixed version 1.13.17, 1.14.12, 1.15.6
Affected binaries

usr/bin/hubble (gobinary) - github.com/cilium/cilium v1.15.4

Reference
CVE-2024-37307
https://github.com/cilium/cilium/security/advisories/GHSA-wh78-7948-358j

Ran the Trivy scan from the latest commit from microsoft's container registry, i.e. [7e6381f] and confirmed that there are no existing vulnerabilities:
beegii@bignamboi:~/src$ trivy image ghcr.io/microsoft/retina/retina-agent:7e6381f
2024-11-11T17:27:04Z    INFO    [vuln] Vulnerability scanning is enabled
2024-11-11T17:27:04Z    INFO    [secret] Secret scanning is enabled
2024-11-11T17:27:04Z    INFO    [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-11-11T17:27:04Z    INFO    [secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2024-11-11T17:28:50Z    INFO    Detected OS     family="cbl-mariner" version="2.0"
2024-11-11T17:28:50Z    INFO    [cbl-mariner] Detecting vulnerabilities...      os_version="2.0" pkg_num=5
2024-11-11T17:28:50Z    INFO    Number of language-specific files       num=3
2024-11-11T17:28:50Z    INFO    [gobinary] Detecting vulnerabilities...

ghcr.io/microsoft/retina/retina-agent:7e6381f (cbl-mariner 2.0)

Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)

Run trivy scan for retina images on linux-amd64 - no vulnerabilities based on latest upstream/main commit
❯ trivy image  ghcr.io/srodi/retina/retina-operator:v0.0.16-151-g7988580-linux-amd64
2024-11-12T11:44:16Z    INFO    [vuln] Vulnerability scanning is enabled
2024-11-12T11:44:16Z    INFO    [secret] Secret scanning is enabled
2024-11-12T11:44:16Z    INFO    [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-11-12T11:44:16Z    INFO    [secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2024-11-12T11:44:17Z    INFO    Detected OS     family="cbl-mariner" version="2.0"
2024-11-12T11:44:17Z    INFO    [cbl-mariner] Detecting vulnerabilities...      os_version="2.0" pkg_num=5
2024-11-12T11:44:17Z    INFO    Number of language-specific files       num=1
2024-11-12T11:44:17Z    INFO    [gobinary] Detecting vulnerabilities...

ghcr.io/srodi/retina/retina-operator:v0.0.16-151-g7988580-linux-amd64 (cbl-mariner 2.0)

Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)

❯ trivy image ghcr.io/srodi/retina/retina-init:v0.0.16-151-g7988580-linux-amd64
2024-11-12T11:47:47Z    INFO    [vuln] Vulnerability scanning is enabled
2024-11-12T11:47:47Z    INFO    [secret] Secret scanning is enabled
2024-11-12T11:47:47Z    INFO    [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-11-12T11:47:47Z    INFO    [secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2024-11-12T11:47:49Z    INFO    Detected OS     family="cbl-mariner" version="2.0"
2024-11-12T11:47:49Z    INFO    [cbl-mariner] Detecting vulnerabilities...      os_version="2.0" pkg_num=5
2024-11-12T11:47:49Z    INFO    Number of language-specific files       num=1
2024-11-12T11:47:49Z    INFO    [gobinary] Detecting vulnerabilities...

ghcr.io/srodi/retina/retina-init:v0.0.16-151-g7988580-linux-amd64 (cbl-mariner 2.0)

Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)

❯ trivy image ghcr.io/srodi/retina/retina-agent:v0.0.16-151-g7988580-linux-amd64
2024-11-12T11:49:13Z    INFO    [vuln] Vulnerability scanning is enabled
2024-11-12T11:49:13Z    INFO    [secret] Secret scanning is enabled
2024-11-12T11:49:13Z    INFO    [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-11-12T11:49:13Z    INFO    [secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2024-11-12T11:49:16Z    INFO    Detected OS     family="cbl-mariner" version="2.0"
2024-11-12T11:49:16Z    INFO    [cbl-mariner] Detecting vulnerabilities...      os_version="2.0" pkg_num=5
2024-11-12T11:49:16Z    INFO    Number of language-specific files       num=3
2024-11-12T11:49:16Z    INFO    [gobinary] Detecting vulnerabilities...

ghcr.io/srodi/retina/retina-agent:v0.0.16-151-g7988580-linux-amd64 (cbl-mariner 2.0)

Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)

Trivy scan results - running on images with tag 4f3dcb5
RETINA AGENT - https://github.com/microsoft/retina/pkgs/container/retina%2Fretina-agent/304246198?tag=4f3dcb5
LINUX/AMD64
~/src/repos/retina $  trivy image ghcr.io/microsoft/retina/retina-agent:4f3dcb5@sha256:4847b61c4efaacaaa3ee3b328d5699f020b4d7d358db24dd99c6dad1b34d794b
2024-11-12T12:30:15Z    INFO    [vulndb] Need to update DB
2024-11-12T12:30:15Z    INFO    [vulndb] Downloading vulnerability DB...
2024-11-12T12:30:15Z    INFO    [vulndb] Downloading artifact...        repo="ghcr.io/aquasecurity/trivy-db:2"
55.39 MiB / 55.39 MiB [-----------------------------------------------------------------------------------------------------------] 100.00% 5.27 MiB p/s 11s
2024-11-12T12:30:27Z    INFO    [vulndb] Artifact successfully downloaded       repo="ghcr.io/aquasecurity/trivy-db:2"
2024-11-12T12:30:27Z    INFO    [vuln] Vulnerability scanning is enabled
2024-11-12T12:30:27Z    INFO    [secret] Secret scanning is enabled
2024-11-12T12:30:27Z    INFO    [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-11-12T12:30:27Z    INFO    [secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2024-11-12T12:30:33Z    INFO    Detected OS     family="cbl-mariner" version="2.0"
2024-11-12T12:30:33Z    INFO    [cbl-mariner] Detecting vulnerabilities...      os_version="2.0" pkg_num=5
2024-11-12T12:30:33Z    INFO    Number of language-specific files       num=3
2024-11-12T12:30:33Z    INFO    [gobinary] Detecting vulnerabilities...
ghcr.io/microsoft/retina/retina-agent:4f3dcb5@sha256:4847b61c4efaacaaa3ee3b328d5699f020b4d7d358db24dd99c6dad1b34d794b (cbl-mariner 2.0)
Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)
LINUX/ARM64
~/src/repos/retina $  trivy image ghcr.io/microsoft/retina/retina-agent:4f3dcb5@sha256:d1d7328b1275c6e0bcd27ac93a8c9034237bf7c66274a787ab
b3537ce5d25a0b
2024-11-12T12:33:03Z    INFO    [vuln] Vulnerability scanning is enabled
2024-11-12T12:33:03Z    INFO    [secret] Secret scanning is enabled
2024-11-12T12:33:03Z    INFO    [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-11-12T12:33:03Z    INFO    [secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2024-11-12T12:33:09Z    INFO    Detected OS     family="cbl-mariner" version="2.0"
2024-11-12T12:33:09Z    INFO    [cbl-mariner] Detecting vulnerabilities...      os_version="2.0" pkg_num=5
2024-11-12T12:33:09Z    INFO    Number of language-specific files       num=3
2024-11-12T12:33:09Z    INFO    [gobinary] Detecting vulnerabilities...
ghcr.io/microsoft/retina/retina-agent:4f3dcb5@sha256:d1d7328b1275c6e0bcd27ac93a8c9034237bf7c66274a787abb3537ce5d25a0b (cbl-mariner 2.0)
Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)
WINDOWS/AMD64
PS C:\Users\kamilp> trivy image --debug ghcr.io/microsoft/retina/retina-agent:4f3dcb5@sha256:482f6e5b841ef17da742c2c06fd048b888cc97a5b5b52e22275f9d93620ba726
2024-11-12T13:25:47Z    DEBUG   No plugins loaded
2024-11-12T13:25:47Z    DEBUG   Default config file "file_path=trivy.yaml" not found, using built in values
2024-11-12T13:25:47Z    DEBUG   Cache dir       dir="C:\Users\kamilp\AppData\Local\trivy"
2024-11-12T13:25:47Z    DEBUG   Cache dir       dir="C:\Users\kamilp\AppData\Local\trivy"
2024-11-12T13:25:47Z    DEBUG   Parsed severities       severities=[UNKNOWN LOW MEDIUM HIGH CRITICAL]
2024-11-12T13:25:47Z    DEBUG   Ignore statuses statuses=[]
2024-11-12T13:25:47Z    DEBUG   DB update was skipped because the local DB is the latest
2024-11-12T13:25:47Z    DEBUG   DB info schema=2 updated_at=2024-11-12T12:17:49.02979874Z next_update=2024-11-13T12:17:49.029798369Z downloaded_at=2024-11-12T13:22:51.4222335Z
2024-11-12T13:25:47Z    DEBUG   [pkg] Package types     types=[os library]
2024-11-12T13:25:47Z    DEBUG   [pkg] Package relationships     relationships=[unknown root direct indirect]
2024-11-12T13:25:47Z    INFO    [vuln] Vulnerability scanning is enabled
2024-11-12T13:25:47Z    INFO    [secret] Secret scanning is enabled
2024-11-12T13:25:47Z    INFO    [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-11-12T13:25:47Z    INFO    [secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2024-11-12T13:25:47Z    DEBUG   Enabling misconfiguration scanners      scanners=[azure-arm cloudformation dockerfile helm kubernetes terraform terraformplan-json terraformplan-snapshot]
2024-11-12T13:25:47Z    DEBUG   Initializing scan cache...      type="fs"
2024-11-12T13:25:47Z    DEBUG   [secret] No secret config detected      config_path="trivy-secret.yaml"
2024-11-12T13:25:47Z    DEBUG   [secret] No secret config detected      config_path="trivy-secret.yaml"
2024-11-12T13:25:47Z    DEBUG   [image] Detected image ID       image_id="sha256:329fa344188b136af1c4c9ddc83dfc79cca581ae1e23201e65829b14cf30d37e"
2024-11-12T13:25:47Z    DEBUG   [image] Detected diff ID        diff_ids=[sha256:da2d874340bd0ca5f710fcb2bb9abc7423e71287e9f2b87694767375272e797d sha256:b95bb9177b7bd79ff392ee56ab21e602343779e68882b471e0550cdabc7344e0 sha256:d3b453ef623c1d451c919c7c6cdb9e31f802d6a29d77239cb7de894055545865 sha256:d7d2f166d6b226e46f764ff09321a3f5aa543906820c97e3c60da018abd194d7 sha256:2a4cd292eaa65567b4ef7bdef92865719e5209cc2416b3aa60f97169d7c1c11e sha256:e997e073e23a0e67d566fc8e7976d7dba2c4330979b70cce27baf7c7a3e557b2 sha256:4549d0bd635bfd3b68215eb7f411b3fe6633fec120a6433345f25ea88d94bc43]
2024-11-12T13:25:47Z    DEBUG   [image] Detected base layers    diff_ids=[]
2024-11-12T13:25:47Z    DEBUG   OS is not detected.
2024-11-12T13:25:47Z    DEBUG   Detected OS: unknown
2024-11-12T13:25:47Z    INFO    Number of language-specific files       num=2
2024-11-12T13:25:47Z    INFO    [gobinary] Detecting vulnerabilities...
2024-11-12T13:25:47Z    DEBUG   [gobinary] Scanning packages for vulnerabilities        file_path="Files/controller.exe"
2024-11-12T13:25:47Z    DEBUG   [gobinary] Skipping vulnerability scan as no version is detected for the package        name="github.com/microsoft/retina"
2024-11-12T13:25:47Z    DEBUG   [gobinary] Scanning packages for vulnerabilities        file_path="Files/captureworkload.exe"
2024-11-12T13:25:47Z    DEBUG   [gobinary] Skipping vulnerability scan as no version is detected for the package        name="github.com/microsoft/retina"
2024-11-12T13:25:47Z    DEBUG   [vex] VEX filtering is disabled
RETINA INIT - https://github.com/microsoft/retina/pkgs/container/retina%2Fretina-init/304246209?tag=4f3dcb5
LINUX/AMD64
~/src/repos/retina $  trivy image ghcr.io/microsoft/retina/retina-init:4f3dcb5@sha256:d91f7a64fd0562afcedb29b0c056bec88a83b8d253656b606b09ad61b640e9ad
2024-11-12T12:40:37Z    INFO    [vuln] Vulnerability scanning is enabled
2024-11-12T12:40:37Z    INFO    [secret] Secret scanning is enabled
2024-11-12T12:40:37Z    INFO    [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-11-12T12:40:37Z    INFO    [secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2024-11-12T12:40:38Z    INFO    Detected OS     family="cbl-mariner" version="2.0"
2024-11-12T12:40:38Z    INFO    [cbl-mariner] Detecting vulnerabilities...      os_version="2.0" pkg_num=5
2024-11-12T12:40:38Z    INFO    Number of language-specific files       num=1
2024-11-12T12:40:38Z    INFO    [gobinary] Detecting vulnerabilities...
ghcr.io/microsoft/retina/retina-init:4f3dcb5@sha256:d91f7a64fd0562afcedb29b0c056bec88a83b8d253656b606b09ad61b640e9ad (cbl-mariner 2.0)
Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)
LINUX/ARM64
~/src/repos/retina $  trivy image ghcr.io/microsoft/retina/retina-init:4f3dcb5@sha256:79f851e498909042a8b9abb133f096423e842cf840d19595851
4a946f1b496b5
2024-11-12T12:41:35Z    INFO    [vuln] Vulnerability scanning is enabled
2024-11-12T12:41:35Z    INFO    [secret] Secret scanning is enabled
2024-11-12T12:41:35Z    INFO    [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-11-12T12:41:35Z    INFO    [secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2024-11-12T12:41:36Z    INFO    Detected OS     family="cbl-mariner" version="2.0"
2024-11-12T12:41:36Z    INFO    [cbl-mariner] Detecting vulnerabilities...      os_version="2.0" pkg_num=5
2024-11-12T12:41:36Z    INFO    Number of language-specific files       num=1
2024-11-12T12:41:36Z    INFO    [gobinary] Detecting vulnerabilities...
ghcr.io/microsoft/retina/retina-init:4f3dcb5@sha256:79f851e498909042a8b9abb133f096423e842cf840d195958514a946f1b496b5 (cbl-mariner 2.0)
Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)
RETINA OPERATOR - https://github.com/microsoft/retina/pkgs/container/retina%2Fretina-operator/304243743?tag=4f3dcb5
LINUX/AMD64
~/src/repos/retina $  trivy image ghcr.io/microsoft/retina/retina-operator:4f3dcb5@sha256:5d186723f2fd5b455fd1ec587f3949bc387d88098f1d980d8dfe1b341d249204
2024-11-12T12:42:23Z    INFO    [vuln] Vulnerability scanning is enabled
2024-11-12T12:42:23Z    INFO    [secret] Secret scanning is enabled
2024-11-12T12:42:23Z    INFO    [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2024-11-12T12:42:23Z    INFO    [secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2024-11-12T12:42:24Z    INFO    Detected OS     family="cbl-mariner" version="2.0"
2024-11-12T12:42:24Z    INFO    [cbl-mariner] Detecting vulnerabilities...      os_version="2.0" pkg_num=5
2024-11-12T12:42:24Z    INFO    Number of language-specific files       num=1
2024-11-12T12:42:24Z    INFO    [gobinary] Detecting vulnerabilities...
ghcr.io/microsoft/retina/retina-operator:4f3dcb5@sha256:5d186723f2fd5b455fd1ec587f3949bc387d88098f1d980d8dfe1b341d249204 (cbl-mariner 2.0)
Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)


Using logging causes failures in some tests, including some in All post-commit tests

Describe the bug
Running at least one test with logging enabled causes failures. Specifically tests/ttnn/unit_tests/test_tracer.py::test_ttnn_bert, which is in All post-commit tests.
To Reproduce
Steps to reproduce the behavior:

Set the log variables:

export TT_METAL_LOGGER_LEVEL=DEBUG
export TT_METAL_LOGGER_TYPES=Op
export TTNN_ENABLE_LOGGING=True
export TT_METAL_DPRINT_CORES=all

run

pytest "tests/ttnn/unit_tests/test_tracer.py::test_ttnn_bert[bert=models.demos.bert.tt.ttnn_optimized_bert-sequence_size=384-batch_size=8-model_name=phiyodr/bert-large-finetuned-squad2-device_l1_small_size=0]"

which is part of All post-commit tests > fd-unit-tests > ttnn group 1 grayskull E150
causes
Fatal Python error: Segmentation fault

Thread 0x00007f050d6a8740 (most recent call first):
  File "/proj_sw/user_dev/bbradel/tt-metal/ttnn/ttnn/decorators.py", line 411 in call_wrapper
  File "/proj_sw/user_dev/bbradel/tt-metal/ttnn/ttnn/tracer.py", line 168 in call_wrapper
  File "/proj_sw/user_dev/bbradel/tt-metal/ttnn/ttnn/decorators.py", line 626 in call_wrapper
  File "/proj_sw/user_dev/bbradel/tt-metal/ttnn/ttnn/decorators.py", line 701 in __call__
  File "/proj_sw/user_dev/bbradel/tt-metal/models/demos/bert/tt/ttnn_optimized_bert.py", line 52 in bert_attention
  File "/proj_sw/user_dev/bbradel/tt-metal/models/demos/bert/tt/ttnn_optimized_bert.py", line 165 in bert_layer
  File "/proj_sw/user_dev/bbradel/tt-metal/models/demos/bert/tt/ttnn_optimized_bert.py", line 229 in bert
  File "/proj_sw/user_dev/bbradel/tt-metal/models/demos/bert/tt/ttnn_optimized_bert.py", line 251 in bert_for_question_answering
  File "/proj_sw/user_dev/bbradel/tt-metal/tests/ttnn/unit_tests/test_tracer.py", line 118 in test_ttnn_bert
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/_pytest/python.py", line 195 in pytest_pyfunc_call
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/pluggy/_callers.py", line 103 in _multicall
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/pluggy/_hooks.py", line 513 in __call__
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/_pytest/python.py", line 1789 in runtest
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/_pytest/runner.py", line 167 in pytest_runtest_call
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/pluggy/_callers.py", line 103 in _multicall
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/pluggy/_hooks.py", line 513 in __call__
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/_pytest/runner.py", line 260 in <lambda>
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/_pytest/runner.py", line 339 in from_call
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/_pytest/runner.py", line 259 in call_runtest_hook
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/_pytest/runner.py", line 220 in call_and_report
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/_pytest/runner.py", line 131 in runtestprotocol
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/_pytest/runner.py", line 112 in pytest_runtest_protocol
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/pluggy/_callers.py", line 103 in _multicall
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/pluggy/_hooks.py", line 513 in __call__
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/_pytest/main.py", line 349 in pytest_runtestloop
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/pluggy/_callers.py", line 103 in _multicall
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/pluggy/_hooks.py", line 513 in __call__
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/_pytest/main.py", line 324 in _main
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/_pytest/main.py", line 270 in wrap_session
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/_pytest/main.py", line 317 in pytest_cmdline_main
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/pluggy/_callers.py", line 103 in _multicall
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/pluggy/_manager.py", line 120 in _hookexec
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/pluggy/_hooks.py", line 513 in __call__
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/_pytest/config/__init__.py", line 167 in main
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/lib/python3.8/site-packages/_pytest/config/__init__.py", line 190 in console_main
  File "/proj_sw/user_dev/bbradel/tt-metal/python_env/bin/pytest", line 8 in <module>
Segmentation fault (core dumped)

Expected behavior
The test succeeds with no segmentation fault.
Please complete the following environment information:

OS: Ubuntu 20.04
Version of software: main

This is what I see:
terminate called after throwing an instance of 'std::runtime_error'
  what():  TT_ASSERT @ tt_metal/impl/debug/dprint_server.cpp:671: rpos <= bufsize
backtrace:
 --- /home/ubuntu/work/tt-metal/build/lib/libtt_metal.so(+0x3393c1) [0x7fffb55033c1]
 --- /lib/x86_64-linux-gnu/libstdc++.so.6(+0xe6793) [0x7ffff4665793]
 --- /lib/x86_64-linux-gnu/libpthread.so.0(+0x8609) [0x7ffff7dae609]
 --- /lib/x86_64-linux-gnu/libc.so.6(clone+0x43) [0x7ffff7ee8353]

Test passes after running unset TT_METAL_DPRINT_CORES


Update Facilitator and Group Membership

See https://github.com/ampproject/meta/issues/65. This is a refactor of the existing group and mandate.

 All committers have signed the CLA.


Fix some wording in 07 and 08

A few typos, e.g. peripheral vs peripheralS.
Made sure the code in 07/README matched the actual code.
Fixed a few comments where it said 'turn on' when it was actually 'turn off'.
A few wording fixes.

Thanks, @Grazfather. ❤

No problem :) Great work on these tutorials.


Classes transpiled down to es5 can't extend native es6 classes

TypeScript Version:  3.4.1
Search Terms: extend class transpiled es5
Code
// Part 1
function extender ( myClass ) {
  return class extends myClass { }
}

// Part 2
const Extended = extender ( class {} );
new Extended ();

The following code:

Works, if transpiled to es6+
Works, if transpiled to es5 too
Doesn't work, if the first part gets transpiled to es5 while the second part is still using es6. The first part may very well be a class decorator exported by some third-party package. The problem is that when transpiled down to es5 classes can't extend native classes.

Playground Link:  N/A, the playground is too limited for this

I believe this is a duplicate of #17088.

It looks like it is, thanks.


Fix syntax highlighting in network docs

Hi @dmand,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!


Fix space creating flow for gnosis safe with different controller address

Need to update the docs and the link here https://github.com/snapshot-labs/snapshot/blob/957bdfaa5637a2af2ca96a6398518970c85c97da/src/components/SetupController.vue#L90


pesqmain not found! Please add it your PATH

where is pesqmain source code?

I solve it

How did you solve?

Hi, could you tell me how to solve it?

I solve it

how did you get the pesqmain,i have a script but the pesq score is different with the score in paper,can you provide the pesqmain script

You can directly use the pesq module
check: https://pypi.org/project/pesq/
modify the function   def PESQ(ref_wav, deg_wav): to return pesq(16000,ref_wav,deg_wav,'wb')


Does azure_api_key support this sdk?

Does azure_api_key support this sdk?

Not yet. Should be easy to add to http.cpp.

add_compile_definitions(OPENAI_API_KEY="$ENV{OPENAI_API_KEY}")
add_compile_definitions(OPENAI_REALTIMEAPI="https://api.openai.com/v1/realtime?model=gpt-4o-mini-realtime-preview-2024-12-17")
Looks like that real-time model in Azure OpenAI uses WebSocket to connect to the service:
wss://my-eastus2-openai-resource.openai.azure.com/openai/realtime?api-version=2024-10-01-preview&deployment=gpt-4o-realtime-preview-deployment-name
(ref: https://learn.microsoft.com/en-us/azure/ai-services/openai/how-to/realtime-audio)
I guess that the model version is different and API is too.
Backend Selection
BACKEND=azure|openai
Azure OpenAI Configuration
AZURE_OPENAI_ENDPOINT=your-endpoint
AZURE_OPENAI_DEPLOYMENT=your-deployment
OpenAI Configuration
OPENAI_API_KEY=your-api-key
OPENAI_MODEL=your-model

I think Azure just needs some slightly different HTTP headers, e.g., x-api-key instead of authorization, and a different base URL (openai.azure.com/blah instead of api.openai.com/blah)


Improve panic capture dumps

The panic capture writes should probably be prefixed with some kind of timestamp for easier tracking of issues.

Turns out this is pretty hard to do..
#include <fcntl.h>

fn C.open(const_pathname &char, flags int, mode int) int

fn persist_stderr_to_disk() {
    fd := C.open(c'lilly.panic.log', C.O_CREAT | C.O_WRONLY | C.O_APPEND, 0o666)
    C.dup2(fd, C.STDERR_FILENO)
}

is how the panic invocation currently gets captured we just tell the proc to redirect stderr to the file lilly.panic.log, and that's it. I am unsure at this time how to per panic dump to prefix the unknown sized data being frantically written to disk before termination with a timestamp. This will need further investigation as a nice to have. For now though I don't want to waste any more time on this so it's going into On Hold.


chore: Remove .DS_Store and Update .gitignore

Description
Removed .DS_Store
Related Issues or Pull Requests
This change is related to issue #184.
Proposed Changes

The .DS_Store file within the /traffic-sniffer directory has been removed.
.DS_Store file has been added to the .gitignore

@leewan-09 thank you very much!


Add PDB info to crash info

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.

Codecov Report
Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 73.83%. Comparing base (98ad3dc) to head (55e0eb7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
- Coverage   73.85%   73.83%   -0.03%
==========================================
  Files         257      257
  Lines       37301    37312      +11
==========================================
- Hits        27549    27548       -1
- Misses       9752     9764      +12

Components
Coverage Δ

crashtracker
20.36% <0.00%> (-0.17%)
:arrow_down:

crashtracker-ffi
9.07% <0.00%> (-0.22%)
:arrow_down:

datadog-alloc
98.73% <ø> (ø)

data-pipeline
93.33% <ø> (ø)

data-pipeline-ffi
0.00% <ø> (ø)

ddcommon
83.08% <ø> (ø)

ddcommon-ffi
69.52% <ø> (ø)

ddtelemetry
59.10% <ø> (ø)

ddtelemetry-ffi
22.13% <ø> (ø)

dogstatsd
90.42% <ø> (ø)

dogstatsd-client
79.77% <ø> (ø)

ipc
83.58% <ø> (ø)

profiling
84.26% <ø> (ø)

profiling-ffi
77.42% <ø> (ø)

serverless
0.00% <ø> (ø)

sidecar
38.19% <ø> (ø)

sidecar-ffi
0.00% <ø> (ø)

spawn-worker
50.36% <ø> (ø)

tinybytes
94.77% <ø> (ø)

trace-mini-agent
72.47% <ø> (ø)

trace-normalization
98.25% <ø> (ø)

trace-obfuscation
95.73% <ø> (ø)

trace-protobuf
77.67% <ø> (ø)

trace-utils
93.87% <ø> (ø)


Hypershift operator: Give a priority that is higher than any controlplane component

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #
Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

waiting for test run to complete to ensure that the priority is being created and set on the HO operator

may be mention this here https://hypershift-docs.netlify.app/how-to/distribute-hosted-cluster-workloads/#priority

for the record, the HO pod did get the priority set correctly :+1:

/lgtm
/retest


Issue on ubuntu 20.04

Hi, I am on ubuntu 20.04 with Python 3.8.5 and I tried running your test.py file.
I get this error, on my terminal. Do you have any advice for me?
Traceback (most recent call last):
  File "/home/kevindo/Documents/pddlgym/test.py", line 5, in <module>
    from pddlgym_planners.ff import FF  # FastForward
  File "/home/kevindo/Documents/pddlgym/pddlgym_planners/ff.py", line 8, in <module>
    from pddlgym_planners.pddl_planner import PDDLPlanner
  File "/home/kevindo/Documents/pddlgym/pddlgym_planners/pddl_planner.py", line 14, in <module>
    from pddlgym_planners.FD.src.translate.translate import main as downward_translate
ModuleNotFoundError: No module named 'pddlgym_planners.FD'

Thank you!

Sorry for the inconvenience. I've just pushed a change. Let me know if that fixes it for you :)

It seems to be fixed now. Thank you for your fast response! :)


"Holobani" is listed in the drop-down menu

Description:
"Holobani" is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Holobani" in the search bar.

Expected results
The location is listed in the drop-down menu as "Holobani, Alba (Lupșa)".


memex ./app_setup.sh run problem

Hi here is the problem when i run  ./app_setup.sh
Please help in this issue.
from common_settings import *
File "/home/explorer/memex-explorer/source/memex/common_settings.py", line 67, in
"base.views.project_context_processor",
TypeError: can only concatenate list (not "tuple") to list
./app_setup.sh: line 15: deactivate: No such file or directory

Can you give me some info in your system and python version?

sure. i am using ubuntu 14.04 and python version 2.7

Setting enable stream viz to: FalseTraceback (most recent call last):
File "manage.py", line 10, in
execute_from_command_line(sys.argv)
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/django/core/management/init.py", line 385, in execute_from_command_line
utility.execute()
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/django/core/management/init.py", line 354, in execute
django.setup()
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/django/init.py", line 21, in setup
apps.populate(settings.INSTALLED_APPS)
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/django/apps/registry.py", line 115, in populate
app_config.ready()
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/debug_toolbar/apps.py", line 15, in ready
dt_settings.patch_all()
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/debug_toolbar/settings.py", line 228, in patch_all
patch_root_urlconf()
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/debug_toolbar/settings.py", line 216, in patch_root_urlconf
reverse('djdt:render_panel')
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/django/core/urlresolvers.py", line 522, in reverse
app_list = resolver.app_dict[ns]
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/django/core/urlresolvers.py", line 329, in app_dict
self._populate()
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/django/core/urlresolvers.py", line 269, in _populate
for pattern in reversed(self.url_patterns):
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/django/core/urlresolvers.py", line 372, in url_patterns
patterns = getattr(self.urlconf_module, "urlpatterns", self.urlconf_module)
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/django/core/urlresolvers.py", line 366, in urlconf_module
self._urlconf_module = import_module(self.urlconf_name)
File "/root/miniconda2/envs/memex/lib/python2.7/importlib/init.py", line 37, in import_module
import(name)
File "/home/ruba/memex-explorer/source/memex/urls.py", line 4, in
from rest import router, DataWakeView
File "/home/ruba/memex-explorer/source/memex/rest.py", line 4, in
from rest_framework import routers, serializers, viewsets, parsers, filters
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/rest_framework/routers.py", line 25, in
from rest_framework import views
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/rest_framework/views.py", line 16, in
from rest_framework import exceptions, status
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/rest_framework/exceptions.py", line 17, in
from rest_framework.utils.serializer_helpers import ReturnDict, ReturnList
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/rest_framework/utils/serializer_helpers.py", line 8, in
from rest_framework.compat import unicode_to_repr
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/rest_framework/compat.py", line 77, in
import django_filters
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/django_filters/init.py", line 3, in
from .filterset import FilterSet
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/django_filters/filterset.py", line 19, in
from .filters import (Filter, CharFilter, BooleanFilter,
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/django_filters/filters.py", line 118, in
class UUIDFilter(Filter):
File "/root/miniconda2/envs/memex/lib/python2.7/site-packages/django_filters/filters.py", line 119, in UUIDFilter
field_class = forms.UUIDField
AttributeError: 'module' object has no attribute 'UUIDField'
discarding /root/miniconda2/envs/memex/bin from PATH

Hello,
I was having the exact same problem. First time installing Memex-explorer.
I managed to fix this (and pass all tests) by freezing django-filter's version on environment.yml to 0.10:
diff --git a/environment.yml b/environment.yml
index 7fdc6fe..8a8ddeb 100644
--- a/environment.yml
+++ b/environment.yml
@@ -40,4 +40,4 @@ dependencies:
         - elasticsearch
         - supervisor
         - djangorestframework
-        - django-filter
+        - django-filter==0.10

Apparently newer versions of django-filters do not work with django 1.7.3 (which is also fixed at environment.yml)

Support and development for this project has been halted. We appreciate the help in clearing up these issues, and they will be solved when development is resumed.
Thanks.


release 0.17.0

I think this is okay for getting some more users back.
Open to feedback on the changelog, I used release-plz to generate the log for this release and made edits for further format
Remaining active work that is related to CI will be updated and likely minor version releases to [crates.io], included but not limited to:

code coverage reports. Note that I dropped the codecov badge on the readme for this release since it's inaccurate.
testing NIST data

Noting that at some point (#209) @FreezyLemon mentioned the idea of introducing MSRV to this project; I planned to delay adding that policy to the release that introduces that change that motivated it since this release is focused to get the project back on its feet.

I got some advice that if we're going to introduce the msrv may as well not wait on it.
I did some testing with cargo-hack and found that cargo check fails up through 1.60 on nalgebra. Note that 1.61 will also suffice for #209's proposed changes regarding.
I'll make these changes now.

Any MSRV should really be checked in CI, since it's very easy to accidentally break it while updating dependencies. It would also be nice to document it somewhere, e.g. at the bottom of the README (including when and for what reasons it will be changed, and how the crate version will reflect MSRV changes)

Seems like I only checked the lib in my local testing, our benches rely on criterion relying on rayon which has rust-version = 1.64
I'm okay excluding those benchmarks from the package, but I've not found a way to split the dependencies for benchmarking apart from testing, unsure if this is possible.
@FreezyLemon Do you know a way around this other than making a separate crate for testing?

Do you know a way around this other than making a separate crate for testing?

Another way of achieving this would be a crate feature that needs to be enabled for benchmarking, but it's not great for developer ergonomics.
It's also possible to just disable the default features for criterion which should remove rayon and possibly reduces the MSRV.

I can get it down to 1.65 with changing the features criterion uses and keeping the version pinned, which aligns around the 0.16 statrs release. However, my opposition is that the MSRV is higher than what the statrs lib itself needs, so I find it a little misguiding. I would clearly mention this in the docs.
I don't like the option to gate benches with a feature, but given the below reasons, I think we could get by.

the features benched aren't actively being developed it may not impede any developer
benchmarks should be reported with version compiled with
an MSRV higher than what our lib needs could remove it from consideration, only a few minor versions (5 months) newer.

Thoughts?

made a post on the forums to get others' input if this would be unexpected.

I honestly thought that disabling the criterion default features would solve the problem. The benches feature doesn't feel great... I'd honestly just set the expectation that the MSRV is meant for crate users (cargo add statrs) and not for crate devs (git clone <statrs>) and just be done with it. dev-dependencies are not something to consider for normal crate usage, and any dev should have a recent Rust version anyways.

I agree, and it makes me wonder if it's better to

hold off on an MSRV
disable/remove benches to make sure that CI is checking behavior that a lib user would see
have CI only check MSRV only for the lib target, not its tests (or benchmarks)

I'm leaning toward the last option, but it's potentially hiding a source of inconsistency in test results.

Think I'll hold off on it. Since inclusion of it is only policy, I imagine it would only change the fix release version.


ntr/tpv  tRNA-guanine transglycosylation

There is a similar issue to
ontology-requests/11743/ for queuosine
I captured this as "GO:1990397 queuosine salvage" which is  how it is described in the paper.
and although this seems to fit
GO:1990397 queuosine salvage
Any process which produces queuosine from derivatives of it, without de novo synthesis.
it isn't really salvage in the way that it is represented in the GO graph. Here, GO:1990397 queuosine salvage is a descendent of queuosine biosynthesis but the queuosine isn't 'salvaged' endogenously by fission yeast. it is acquired from a dietary source. So an annotation to "queuosine biosynthesis" is incorrect.
I think to annotate this paper  I needed instead a process term
tRNA-guanine transglycosylation instead?
defined as
the  insertion of queuine into target tRNAs by the replacement of a genetically encoded guanine
http://www.ncbi.nlm.nih.gov/pmc/articles/PMC2802272/
The existing term arrangement around
queuosine salvage
and
queuosine biosynthesis looks dodgy (in particular the parentage to tRNA modification)
Reported by: ValWood
Original Ticket: geneontology/ontology-requests/11744

@hdrabkin, trying to get Harold into the loop

@ValWood , I found this term:
queuine tRNA-ribosyltransferase activity
http://amigo.geneontology.org/amigo/term/GO:0008479
Does that help for your annotation?  We still need to do something about the queosine salvage term.
Also: GO:0008616 queuosine biosynthetic process should not be a descendent of tRNA modification unless all queuosine biosynthesis is part of tRNA modification
@hdrabkin, do you know if  all queosine biosynthesis is part of tRNA modification ?  If not, I will remove that parent and leave it straight under ribonucleoside biosynthetic process (and queosine metabolic process).

I remember commenting on this before.
Queuine always ends up in tRNA, but the modification can occur either by re-use of queuine from diet/breakdown of tRNA in some organisms, or de nova synthesis in others.
hjd

From: tberardini<EMAIL_ADDRESS>Sent: Friday, August 28, 2015 6:35 PM
To: geneontology/go-ontology
Cc: Harold Drabkin
Subject: Re: [go-ontology] ntr/tpv tRNA-guanine transglycosylation (#11905)
@ValWoodhttps://github.com/ValWood , I found this term:
queuine tRNA-ribosyltransferase activity
http://amigo.geneontology.org/amigo/term/GO:0008479
Does that help for your annotation? We still need to do something about the queosine salvage term.
Also: GO:0008616 queuosine biosynthetic process should not be a descendent of tRNA modification unless all queuosine biosynthesis is part of tRNA modification
@hdrabkinhttps://github.com/hdrabkin, do you know if all queosine biosynthesis is part of tRNA modification ? If not, I will remove that parent and leave it straight under ribonucleoside biosynthetic process (and queosine metabolic process).

Reply to this email directly or view it on GitHubhttps://github.com/geneontology/go-ontology/issues/11905#issuecomment-135903336.
The information in this email, including attachments, may be confidential and is intended solely for the addressee(s). If you believe you received this email by mistake, please notify the sender by return email as soon as possible.

Hi Tanya,
That is the function term we have.  I can't figure out the correct process for this. It isn't biosynthesis....
Val

Hi Val,
Why not tRNA modification?   http://amigo.geneontology.org/amigo/term/GO:0006400
Leaning towards obsoleting 'queuosine salvage' and creating the new replacement term 'tRNA-guanine transglycosylation' with direct parentage to 'tRNA modification'.  Or we could rename it since we've only got pombe annotations to it.
Based on @hdrabkin 's feedback, I will remove the 'tRNA modification' parent from 'queosine biosynthetic process' and leave it straight under ribonucleoside biosynthetic process (and queosine metabolic process).

Yeah I was being picky...all our other tRNA modifiers have specific processes.
http://www.ebi.ac.uk/QuickGO/GTerm?id=GO:0006400#term=children
I'm not particularly attached to the modification processes if they are peformend by single activities though. Its only the inconsistency that bothers me :)
Ignoring my pickiness, the only real problem  is that
GO:0008616 queuosine biosynthetic process
is a descendent of tNRA modification.......

I've removed the link to 'tRNA modification' .
@ValWood - shall we do anything about 'queuosine salvage' or leave it be?  If we should leave that alone, please close this issue.

so you removed  queosine bio from under modification? so the salvage term will no longer be under modification.
If so, I think there is a separate issue open about the salvage terms, so  this one can be closed.

Yes, I 'removed queosine bio from under modification.'
The issue on salvage and biosynthesis is this one #11890.


Suggestion-Any chance to allow more pics to be uploaded?

It seems the limit is 100 pics, any chance to increase the total amount? Thx~

Yes. it's 100 at present.
How many images do you want to save?
The number is a balance for query performance, server cost, and user requirements.

The v2 version was published you can upload 150 pics now


Add support for two factor authentication

Resolves #1569
Notes:

Uses google2fa-laravel and BaconQrCode
Provides a middleware for wrapping routes
Still a WIP but I have tested locally with the Google Authenticator app and can add a code that saves to the user account
Need to implement a view for the OTP and test out things like recovery codes/deactivation
Server requires Imagick to be installed to generate the QR code (PECL package here.)

After chatting with @tristan-orourke, it makes sense to refactor the TwoFactorController to use the User object rather than the Applicant as it is now. Will need some route refactoring since I'm passing the applicant ID through the url to the controller.

I think I'd like to remove this before going live, although we might want to add a "forget remembered devices" button on the settings page that calls cycleRememberDeviceToken().

Yep, good idea. I made those changes, and added success messages (following Grant's pattern) for Deactivate 2FA and Forget Trusted Devices.
Also, it seemed like remember token was only being saved if the user object happened to be saved elsewhere in the same request, so I made sure RememberDeviceTrait always saves the token to DB. But I'm confused about why it was working at all, previously, so please sanity check this @Khristophor cd080293fd8c3d44a04173f905d599c88e05022a

I think I'd like to remove this before going live, although we might want to add a "forget remembered devices" button on the settings page that calls cycleRememberDeviceToken().

Yep, good idea. I made those changes, and added success messages (following Grant's pattern) for Deactivate 2FA and Forget Trusted Devices.
Also, it seemed like remember token was only being saved if the user object happened to be saved elsewhere in the same request, so I made sure RememberDeviceTrait always saves the token to DB. But I'm confused about why it was working at all, previously, so please sanity check this @Khristophor cd08029

You are correct, it did only seem to be saving when the user was also saved. I did some more digging and different traits/contracts seem to handle different portions of the update cycle for remember tokens for some reason:
https://github.com/laravel/framework/blob/6.x/src/Illuminate/Auth/EloquentUserProvider.php#L80-L98
That would be what we're missing, not sure where it should live in the functionality of our app, but it's probably okay in the trait for now.


Clear Flags options removed

Hi,
Thanks for this great repo! In recent Unity versions with URP, the Clear Flags option has been removed and Camera Overlay is used instead. However, when Clear Depth was enabled on Overlay Camera, the Alpha channel is pure white. Any changes to the shaders required?

Hi @MrOCW unfortunately I have not tried the recent version, I will update this thread when I get the chance. Meanwhile if you figure it out, please post here.


[TODO] filter out certain folders from plugin

Hey, I just made a Pull Request!

In some situations we need to commit dependencies folders like 'vendor' from 'go mod'.
It will be nice if we could ignore these folders as those TODOs are not we can fix.
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[x] Added or updated documentation
[x] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Thank you, makes sense! 👍
Thinking we could make it code-driven rather than config though, feeling that's a better fit.

Thanks!! I will address those comments, and agree of unnecessary to have it configured through app-config.yaml.
By saying make it code-driven, will think it would better to have same logic like parser  configuration  or like exclude Extensions sit in todo backend code?


Stderr toggling

Modified App to accept an Enum FileView which specifies stdout or stderr for the App
Job watcher selects which path to read based on FileView
UI elements also toggle between stdout/stderr
Enum is toggled using o key (for output)
stderr added to squeue_args in JobWatcher
Streamlined generation of help to make it easier to add new elements

Thanks again, very useful!


Refactored IMetaDataStore into smaller repositories

Resolves
Fixes #199
Description
Addresses the fact that the IMetaDataStore does too much. Breaking it down into smaller repositories instead so we can get a better overview
I also broke IMetaDataStoreTests into smaller tests per repo so we get a better view of what we actually tets.

Still need to break down the MetaDataStoreTests into a test file for each catalog (e.g. Evaluation, LifeCycle etc.)

@AnoojNair  / @Brett-Parker  / @dcostea this is another big refactor but should be the last one for now (I promise). The underlying structure is now much more streamlined and once we get used to it, it will be easier to add new features and also see what areas we have good testing on and which we don't.

@aslotte don't apologize. Great work. I can't review right now but will take a look later if someone else hasn't already :)


Support Out keyword

Describe the solution you'd like
A useful syntactical sugar to have would be to mark a parameter as Out. twinBASIC allows a parameter to be passed ByVal or ByRef. However, I've often found myself coding this pattern in VBA:
Dim MyThing As Something
If TryGetSomething(OutSomething:=MyThing) Then
  'It's safe to access the MyThing variable here.
Else
  'I can't get to MyThing so I cannot use it. Do something without it.
End If

The advantage of coding in this matter is that the TryGet* neatly abstracts out the mechanics of getting the thing which could potentially fail (may not exist, is not available, whatever). However, there is no compile-time validation that the variable is correctly captured and corresponds to the intention of the code. This would be a misuse:
Dim MyThing As Something
MyThing As New Something
If TryGetSomething(MyThing) Then
  'Did MyThing mutate?
Else
  'I still have a valid MyThing instance?
End If

The Out parameter would disallow above and make it a compile-time error.
We would then declare it as:
Public Function TryGetSomething(Out TheThing As Something) As Boolean

and we can then use it in 3 ways:
Use unassigned local variable
Dim MyThing As Something
If TryGetSomething(Out MyThing)...

Or declare it inline:
If TryGetSomething(Out Dim MyThing As Something)...

Or if we don't care about the out variable:
If TryGetSomething(Out _)...

This would help the API become easier to understand and discoverable, even at the call sites so it's obvious when reading the code, we can see that it's expected to get something out as a parameter.

I have an issue with the INamespaceWalkCB::InitializeProgressDialog in my CNamespaceWalk class..
It crashes in 64 bit mode (VBA or TB) when assigning a custom dialog title.
In 32 bit mode it works..
Does it has todo something with the Out ?
[out] LPWSTR *ppszTitle
Currently I have this as ByRef lpszTitle As LongPtr
But it won't crash when not "touching" lpszTitle. So when not providing a custom caption..

[out] MIDL attribute does not really change the semantics; it's more like a flag to let us know that it should be used as a out parameter. However,
Looking at the header file, the definition is:
        virtual HRESULT STDMETHODCALLTYPE InitializeProgressDialog(
            /* [string][out] */ __RPC__deref_out_opt_string LPWSTR *ppszTitle,
            /* [string][out] */ __RPC__deref_out_opt_string LPWSTR *ppszCancel) = 0;

Based on comments in this article about header annotation and this thread, it sounds like we need something more akin to:
lpszTitle As Any
which at the call site, you must provide ByVal &H0 when you do not want the title, or otherwise a pointer variable.
I may be wrong, though. I'm a kinda of winging it.
But that said, if the new Out keyword is added, it should be able to handle that case. I know even in C#, it is a pain to deal with. Wayne may remember the back-bending he went through to get C# to play with some of type library API that dislikes getting initialized variables for the out variables.

[out] without [in] actually does have subtle differences in semantics. It means that the callee implementation should disregard any content already contained in the pointed to variable and not treat it as valid data.  Take this C++ example:
   // Note that something is not being initialized to nullptr, so in C++, something will contain whatever crud is on the stack (not necessarily zero!)
   IUnknown* something;
   myObject->GetSomething(&something);

   HRESULT __stdcall IFoo::GetSomething(IUnknown** outObject)
   {
       *outObject = m_myObject;
       m_myObject->AddRef();
       return S_OK;
   }

All is fine in the above example, since the GetSomething implementation doesn't try to call Release() on the passed in outObject.  But a normal ByRef parameter in VBx does not behave like this...  ByRef it is considered [in][out], and as such VBx will generate code something like this:
   HRESULT __stdcall IFoo::GetSomething(IUnknown** outObject)
   {
       if (*outObject) (*outObject)->Release();   // this is bad if outObject is an [out]-only parameter, since the value can contain crud data
       *outObject = m_myObject;
       m_myObject->AddRef();
       return S_OK;
   }

The same problem also applies to out-only Strings and Arrays in VBx, since these types are "managed" and so VBx/tB will try to release the pointed to values when you write to them.
At the moment, if you really must define out-only objects/strings/arrays as ByRef then you need to clear the content of the outObject variable immediately before you touch it (at the very top of your routine), carefully, by using RtlZeroMemory on it in order to clear the pointed to value to zero.  Even then, if you're stepping through the code, the debugger will try to read the crud value passed in before you get to set it to zero, and so a crash is likely.   The alternative is to redefine then parameters as pointers, and do everything manually, so you can ensure the out-only semantics are enforced.

Thanks for the help. I found the solution in my case.
So, for the [out] LPWSTR *ppszTitle I just create a string with CoTaskMemAlloc and assigning this on ByRef lpszTitle As LongPtr
But, previously I CoTaskMemFree'ed the string on the object's release. And that was the crash..
I re-checked in tB and it crashes there in 32 bit as well. Just wonder why not in VB6... But now it's resolved.
As the internals of the interface are like: (found on google)
LPWSTR pszTitle = NULL, pszCancel = NULL;

// Retrieve dialog text from callback.
hr = _pnswcb ? _pnswcb->InitializeProgressDialog(&pszTitle, &pszCancel) : S_OK;
if (SUCCEEDED(hr))
{
    [...]
}
CoTaskMemFree(pszTitle);
CoTaskMemFree(pszCancel);


proposed fix for a nil case

Hello,
I got an error in my case:
package main

import (
	"fmt"
	"github.com/mohae/deepcopy"
)

type A struct {
	Id uint32
}

type B struct {
	Id   string
	Data *A
}

func (p *A) DeepCopy() interface{} {
	if p == nil {
		return nil
	}
	c := *p
	return &c
}

func main() {
	b := &B{Id: "b"}
	c := deepcopy.Copy(b)
	fmt.Println(c)
}

My fix is to add a nil check here
	if original.CanInterface() {
		if copier, ok := original.Interface().(Interface); ok {
                        // return if original is nil
			if original.IsNil() {
				return
			}
			cpy.Set(reflect.ValueOf(copier.DeepCopy()))
			return
		}
	}

The proposed fix is not the right solution, because the problem is not about the original value but about the output of .DeepCopy().
Here is the correct fix:
	if original.CanInterface() {
		if copier, ok := original.Interface().(Interface); ok {
			out := copier.DeepCopy()
			cpy.Set(reflect.ValueOf(&out).Elem())
			return
		}
	}

@dolmen
have you verified your fix? it doesn't work.
the problem here is copier could be nil, thus copier.Deepcopy will panic.
it seems this author forgot the project now.


Update documentation for SSL VERIFY hooks.

(cherry picked from commit 458bb1f2c4c2917e103701acddf9ea1aab462105)

[approve ci]

Cherry-picked to 8.1.x


Update readme

Updated readme. Please merge after #137

Coverage increased (+0.03%) to 35.572% when pulling 6b37105525fc1db7228b2ce097635e78d7dc4743 on simontorres:update_readme into 498bbbd046889dfd7bfcb60d9e1a81775f6cc29c on soar-telescope:master.


Bluetooth assert on flash erase using mcumgr

Describe the bug
A bluetooth assert is hit when mcumgr is used to erase the flash for an image upload.
To Reproduce
Ensure slot sizes are large, I used a slot size of 0x70000, then build zephyr/samples/subsys/mgmt/mcumgr/smp_svr for a target board:

mkdir build
cmake -GNinja -DBOARD=<BOARD> -DAPP_DIR=.. -DSB_CONFIG_BOOTLOADER_MCUBOOT=y -Dsmp_svr_OVERLAY_CONFIG="overlay-bt.conf" ../../../../../../share/sysbuild/
ninja
west flash
Once device is flashed, use mcumgr to upload an application: mcumgr --conntype ble --connstring ctlr_name=hci0,peer_name='Zephyr' image upload zephyr/zephyr.signed.bin if this starts uploading right away with no error, hit reboot on the board and try again (erase will only run if there is data in the flash)
Board will assert with:

ASSERTION FAIL [0] @ WEST_TOPDIR/zephyr/subsys/bluetooth/controller/ll_sw/nordic/lll/lll.c:476 lll_preempt_calc: Actual EVENT_OVERHEAD_START_US = 3906
E: r0/a1:  0x00000003  r1/a2:  0x20004ee8  r2/a3:  0x00000001
E: r3/a4:  0x0003153d r12/ip:  0x00000000 r14/lr:  0x000191eb
E:  xpsr:  0x41000028
E: Faulting instruction address (r15/pc): 0x000191f6
E: >>> ZEPHYR FATAL ERROR 3: Kernel oops on CPU 0
E: Fault during interrupt handling
E: Current thread: 0x20001448 (mcumgr smp)
E: Halting system

Expected behavior
No assert
Impact
Showstopper
Environment (please complete the following information):

OS: Linux
Commit SHA or Version used: b8a957a0ebd955ed65b7f1e64c74dac794a37fb3

@nordicjm could you just double-check this is fixed in main?

Problem is fixed


Null Reference Exception when using HasData

I have a quite complex project, with a separate migrations assembly, modular asp.net (orchard) project, database seeding and owned types.
I was able to generate migrations with ef core 2.2, but am not longer able to do it with ef core 3.
First thing I tried, after making it compile, was doing a migration, and got this stack trace

System.NullReferenceException: Object reference not set to an instance of an object.
at lambda_method(Closure , ValueBuffer )
at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.InternalShadowEntityEntry..ctor(IStateManager stateManager, IEntityType entityType, ValueBuffer& valueBuffer)
at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.InternalEntityEntryFactory.NewInternalEntityEntry(IStateManager stateManager, IEntityType entityType, Object entity, ValueBuffer& valueBuffer)
at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.StateManager.CreateEntry(IDictionary`2 values, IEntityType entityType)
at Microsoft.EntityFrameworkCore.Migrations.Internal.MigrationsModelDiffer.TrackData(IModel source, IModel target)
at Microsoft.EntityFrameworkCore.Migrations.Internal.MigrationsModelDiffer.Diff(IModel source, IModel target, DiffContext diffContext)
at Microsoft.EntityFrameworkCore.Migrations.Internal.MigrationsModelDiffer.GetDifferences(IModel source, IModel target)
at Microsoft.EntityFrameworkCore.Migrations.Design.MigrationsScaffolder.ScaffoldMigration(String migrationName, String rootNamespace, String subNamespace, String language)
at Microsoft.EntityFrameworkCore.Design.Internal.MigrationsOperations.AddMigration(String name, String outputDir, String contextType)
at Microsoft.EntityFrameworkCore.Design.OperationExecutor.AddMigrationImpl(String name, String outputDir, String contextType)
at Microsoft.EntityFrameworkCore.Design.OperationExecutor.AddMigration.<>c__DisplayClass0_0.<.ctor>b__0()
at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.<>c__DisplayClass3_0`1.b__0()
at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.Execute(Action action)
Object reference not set to an instance of an object.

The project is in this github repo
https://github.com/laguer71/Albatros

I issue this command in the PMC
add-migration -Project Albatros.Data.Migrations -StartupProject Albatros -Context ApplicationDbContext SomeNewMigrationWithEfCore3-verbose

The code supplied to reproduce this issue is quite complex. It would help greatly to have a simplified project/solution or code listing that isolates the issue in EF.

I am trying to isolate the error, but so far have not been able to. Will keep trying latter today...

I havent been able to isolate the bug. @AndriySvyryd ... you tracked it to a HasData. Did you found out what entityt seed was the one ?

@laguer71 - No. Stacktrace tells us it is HasData but no details about what actual user code.

Couldn't isolate the bug, BUT found a regression bug for EF Core / Linq

I'm getting the same error

Microsoft.EntityFrameworkCore.Infrastructure[10403]
Entity Framework Core 3.0.0 initialized 'GamificationDbContext' using provider 'Microsoft.EntityFrameworkCore.SqlServer' with options: MigrationsAssembly=Netgo.Gamification.Infrastructure using lazy-loading proxies
System.NullReferenceException: Object reference not set to an instance of an object.
at lambda_method(Closure , ValueBuffer )
at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.InternalShadowEntityEntry..ctor(IStateManager stateManager, IEntityType entityType, ValueBuffer& valueBuffer)
at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.InternalEntityEntryFactory.NewInternalEntityEntry(IStateManager stateManager, IEntityType entityType, Object entity, ValueBuffer& valueBuffer)
at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.InternalEntityEntryFactory.Create(IStateManager stateManager, IEntityType entityType, Object entity, ValueBuffer& valueBuffer)
at Microsoft.EntityFrameworkCore.ChangeTracking.Internal.StateManager.CreateEntry(IDictionary2 values, IEntityType entityType)    at Microsoft.EntityFrameworkCore.Update.Internal.UpdateAdapter.CreateEntry(IDictionary2 values, IEntityType entityType)
at Microsoft.EntityFrameworkCore.Migrations.Internal.MigrationsModelDiffer.TrackData(IModel source, IModel target)
at Microsoft.EntityFrameworkCore.Migrations.Internal.MigrationsModelDiffer.Diff(IModel source, IModel target, DiffContext diffContext)
at Microsoft.EntityFrameworkCore.Migrations.Internal.MigrationsModelDiffer.GetDifferences(IModel source, IModel target)
at Microsoft.EntityFrameworkCore.Migrations.Design.MigrationsScaffolder.ScaffoldMigration(String migrationName, String rootNamespace, String subNamespace, String language)
at Microsoft.EntityFrameworkCore.Design.Internal.MigrationsOperations.AddMigration(String name, String outputDir, String contextType)
at Microsoft.EntityFrameworkCore.Design.OperationExecutor.AddMigrationImpl(String name, String outputDir, String contextType)
at Microsoft.EntityFrameworkCore.Design.OperationExecutor.AddMigration.<>c__DisplayClass0_0.<.ctor>b__0()
at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.<>c__DisplayClass3_0`1.b__0()
at Microsoft.EntityFrameworkCore.Design.OperationExecutor.OperationBase.Execute(Action action)
Object reference not set to an instance of an object.

@JulidaRocks - Can you share a repro project?

@JulidaRocks - Can you share a repro project?

I created a simplified project

@JulidaRocks - Thank you so much. I am able to reproduce the error in the repro code.

@smitpatel Is there a workaround to get around this issue until your changes will be published?

@JulidaRocks - I am not aware of any. @AndriySvyryd ?

Ry adding the seed data directly to the dbset
Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: Smit Patel<EMAIL_ADDRESS>Sent: Tuesday, October 15, 2019 12:51:37 PM
To: aspnet/EntityFrameworkCore<EMAIL_ADDRESS>Cc: Luis Guerrero<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [aspnet/EntityFrameworkCore] Null Reference Exception when using HasData (#17851)
@JulidaRockshttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJulidaRocks&data=02|01||9883f18844b841c2671508d751985466|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637067586995665799&sdata=RRWkm8DymlhU90NHbmrqitOMFlT%2FTxKuJt0TLyvLKt4%3D&reserved=0 - I am not aware of any. @AndriySvyrydhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAndriySvyryd&data=02|01||9883f18844b841c2671508d751985466|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637067586995675804&sdata=GryWlMnDa7xZLKjPTCuC%2BfEhZmTbqDNywQM7HkaEc%2Bc%3D&reserved=0 ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faspnet%2FEntityFrameworkCore%2Fissues%2F17851%3Femail_source%3Dnotifications%26email_token%3DAJSTUTJWQ4AU4QVF5RUA6MDQOX7KTA5CNFSM4IWXSHOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBJUXHY%23issuecomment-542329759&data=02|01||9883f18844b841c2671508d751985466|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637067586995685816&sdata=KSRcuInf8Y2JFKezTRV6LpP693H9R67yF2SZcfulUvU%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJSTUTLF2KLPXF4J6HKHFBLQOX7KTANCNFSM4IWXSHOA&data=02|01||9883f18844b841c2671508d751985466|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637067586995695821&sdata=L1frbqbeaboh34NN8c4iqs5Jtvh5HVXoFiizsedFqTA%3D&reserved=0.

do you think an hotfix will be released soon, like 3.0.1, or we've to wait till 3.1 in november?
I thought targeting old framework for new migration could be a workaround, but only for empty migration.

Ry adding the seed data directly to the dbset Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10
…
________________________________ From: Smit Patel<EMAIL_ADDRESS>Sent: Tuesday, October 15, 2019 12:51:37 PM To: aspnet/EntityFrameworkCore<EMAIL_ADDRESS>Cc: Luis Guerrero<EMAIL_ADDRESS>Mention<EMAIL_ADDRESS>Subject: Re: [aspnet/EntityFrameworkCore] Null Reference Exception when using HasData (#17851) @JulidaRockshttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJulidaRocks&data=02|01||9883f18844b841c2671508d751985466|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637067586995665799&sdata=RRWkm8DymlhU90NHbmrqitOMFlT%2FTxKuJt0TLyvLKt4%3D&reserved=0 - I am not aware of any. @AndriySvyrydhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAndriySvyryd&data=02|01||9883f18844b841c2671508d751985466|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637067586995675804&sdata=GryWlMnDa7xZLKjPTCuC%2BfEhZmTbqDNywQM7HkaEc%2Bc%3D&reserved=0 ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faspnet%2FEntityFrameworkCore%2Fissues%2F17851%3Femail_source%3Dnotifications%26email_token%3DAJSTUTJWQ4AU4QVF5RUA6MDQOX7KTA5CNFSM4IWXSHOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBJUXHY%23issuecomment-542329759&data=02|01||9883f18844b841c2671508d751985466|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637067586995685816&sdata=KSRcuInf8Y2JFKezTRV6LpP693H9R67yF2SZcfulUvU%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJSTUTLF2KLPXF4J6HKHFBLQOX7KTANCNFSM4IWXSHOA&data=02|01||9883f18844b841c2671508d751985466|84df9e7fe9f640afb435aaaaaaaaaaaa|1|0|637067586995695821&sdata=L1frbqbeaboh34NN8c4iqs5Jtvh5HVXoFiizsedFqTA%3D&reserved=0.

So you've moved from "HasData(new YourEntity())" to "DbSet<>().Add(new YourEntity())" for the seed that throws the exception?
How did you notice wich seeded entity throws the exception, since there's no clue on how to find it? may be because you've a null reference exception instead of invalid casting exception and so you've more detail?

A derived entity which has seed data, where base entity has a reference navigation would throw exception in model snapshot.

perform all his checks on data seed internally writing all those verbose logs like

If you have logs then look for last entity which was tracked. With above log, it is Permission entity with given key. Whatever is next entity being used in seed data is causing the issue.

perform all his checks on data seed internally writing all those verbose logs like

If you have logs then look for last entity which was tracked. With above log, it is Permission entity with given key. Whatever is next entity being used in seed data is causing the issue.

That's exactly what I've done, but without success. I will double check and see.
Thank you, really appreciated.
Am I wrong or your commit was merged into v.3.1.0 preview 1 recently?

It went into v 3.1.0-preview2. Would be available in nightly builds.


Update images.md

Platforms affected
Docs
What does this PR do?
Add unofficial note to android icon docs.
What testing has been done on this change?
I checked my android app and the icons now work as expected. The 6.0.0 version included the default cordova icons. No testing has been made for splash screens yet.
Checklist

[x] Reported an issue in the JIRA database
[x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ ] Added automated test coverage as appropriate for this change.

CB-12221: (android) Fix documentation issue.

Has this been fixed in Cordova-Android 6.1.0?

It was. My change was rejected, see CB-12221

Yes @shazron, the icon problem is fixed in cordova-android 6.1.0

closing


How can we store attachments using Spatie Medialibrary?

Hi ,
i am using the package to store incoming mails in db, but want to use spatie medialibrary to store the attachments.
Thanks.

Here is a simple approach:
 // save incoming attachments
collect($inboundEmail->attachments())->each(function (MessagePart $attachment) use ($model) {

    $model->addMediaFromString($attachment->getContent())
          ->usingFileName($attachment->getFilename() ?? 'unnamed')
          ->toMediaCollection('files');

});


Assembly output not usable with special chars in output name

If one creates an assembly job that has a nonbreaking space character (U+00A0) in it, the job will run properly but the generated job output is not browsable. It has a page icon instead of a finish flag icon, and if you click on it you get an empty page. Console has job result viewer data but the "Job result output files" diagnostic shows empty.
I'm looking at workspace ls() output and see that the autometadata for the bad job is empty. @aswarren  does the job page use the metadata to render?

This appears to be a UTF-8 handling problem in the autometadata code. Fixing it over there.