Relax Coveralls threshhold and suppress Code Climate PR status failures

We should improve test coverage someday.
In the meantime, Coveralls delivering red Xs to pull requests is demoralizing  and distracting without being helpful.
Therefore reconfigured Coveralls with cartoonishly low standards about test coverage. Should always pass. We still get the automatic calc, we can choose to engage with test coverage any time we want, but we stop with the annoyance in the meantime.
(Logged as GitHub issue for transparency.)

Related to https://github.com/uPortal-Project/uportal-app-framework/issues/574

Ditto Code Climate, done.

done.
https://github.com/uPortal-Project/uportal-home/issues/727#issuecomment-336184662

@apetro does that mean this ticket is complete and can be closed?

Think this is done, yes.


Error: Unexpected "a" at position 108 in state NULL1

00:20:50.939Z FATAL pterodactyl.daemon: (path=/server/power, method=PUT)
    Error: Unexpected "a" at position 108 in state NULL1
        at Parser.proto.charError (/home/ddynamic/Workspaces/wings/daemon/node_modules/jsonparse/jsonparse.js:84:16)
        at Parser.proto.write (/home/ddynamic/Workspaces/wings/daemon/node_modules/jsonparse/jsonparse.js:294:19)
        at Stream.<anonymous> (/home/ddynamic/Workspaces/wings/daemon/node_modules/JSONStream/index.js:21:12)
        at Stream.stream.write (/home/ddynamic/Workspaces/wings/daemon/node_modules/through/index.js:26:11)
        at write (/home/ddynamic/Workspaces/wings/daemon/node_modules/docker-modem/node_modules/readable-stream/lib/_stream_readable.js:623:24)
        at flow (/home/ddynamic/Workspaces/wings/daemon/node_modules/docker-modem/node_modules/readable-stream/lib/_stream_readable.js:632:7)
        at HttpDuplex.pipeOnReadable (/home/ddynamic/Workspaces/wings/daemon/node_modules/docker-modem/node_modules/readable-stream/lib/_stream_readable.js:664:5)
        at emitNone (events.js:80:13)
        at HttpDuplex.emit (events.js:179:7)
        at emitReadable_ (/home/ddynamic/Workspaces/wings/daemon/node_modules/docker-modem/node_modules/readable-stream/lib/_stream_readable.js:448:10)
00:20:50.943Z FATAL pterodactyl.daemon: (path=/server/power, method=PUT)
    Error: Unexpected "r" at position 109 in state NULL1
        at Parser.proto.charError (/home/ddynamic/Workspaces/wings/daemon/node_modules/jsonparse/jsonparse.js:84:16)
        at Parser.proto.write (/home/ddynamic/Workspaces/wings/daemon/node_modules/jsonparse/jsonparse.js:294:19)
        at Stream.<anonymous> (/home/ddynamic/Workspaces/wings/daemon/node_modules/JSONStream/index.js:21:12)
        at Stream.stream.write (/home/ddynamic/Workspaces/wings/daemon/node_modules/through/index.js:26:11)
        at write (/home/ddynamic/Workspaces/wings/daemon/node_modules/docker-modem/node_modules/readable-stream/lib/_stream_readable.js:623:24)
        at flow (/home/ddynamic/Workspaces/wings/daemon/node_modules/docker-modem/node_modules/readable-stream/lib/_stream_readable.js:632:7)
        at HttpDuplex.pipeOnReadable (/home/ddynamic/Workspaces/wings/daemon/node_modules/docker-modem/node_modules/readable-stream/lib/_stream_readable.js:664:5)
        at emitNone (events.js:80:13)
        at HttpDuplex.emit (events.js:179:7)
        at emitReadable_ (/home/ddynamic/Workspaces/wings/daemon/node_modules/docker-modem/node_modules/readable-stream/lib/_stream_readable.js:448:10)

I get this when trying to power on a server as well as several other errors of the unexpected position sort.

I'm wondering if your server's configuration JSON is corrupted. Can you run it though a parser for me?

config.json in the daemon folder is intact. I have the container ID set as sftp. Is that correct?

What about the specific server that this error is being thrown from. Does this error occur right when you press start, or is it after a few seconds?

Right when I press start, the server rapidly starts and stops for a few seconds then this error occurs.

Can I get some system details, unsure as to what the issue could be. Can you provide more of the log?

Can confirm the presence of this issue. I'm assuming something got changed in one of the modules, will investigate.

I believe I have closed this in f41cdcf and a68f7f8. No idea what changed to cause that error to occur, but it was clearly due to the modem.


Create sniff to flag string-concatenating markup in variables as warnings

We should be using PHP template tags and not concatenating strings into variables for printing.

@westonruter Do you have a code example?

@grappler Something like this:
$html = '
';
$html .= '' . esc_html( $text ) . '';
$html = '
';
echo $html;

I should think it is advisable to do this instead:

<a href="<?php echo esc_url( $url ) ?>"><?php echo esc_html( $text ) ?>

Thanks, ah yes, this would help with XSS errors which I mentioned in https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/748


Add BindTarget to BindableList

quick and easy.
closes #3212

We may want to add this to the interface

Added interface implementations. @smoogipoo please confirm the direction of cast I've used is correct for the underlying interface implementations.
Probably should add test coverage for this before merging.

now also closes #3213

As an aside, the interface addition will technically be a breaking change, unless we decide to provide a default implementation in the interface leveraging C# 8.0's default member implementations. I'm unconvinced if we should however, since default members have non-trivial gotchas and maybe it'd be better to make potential consumers wary of this change.

Yeah these are the perfect candidate for default implementations, will make the changes myself.

I originally did this as default interfaces but it felt pretty weird. Either or I guess.


Added updated list of usage examples

This should solve https://github.com/ably/ably-flutter/issues/376. I've collected all the usage examples from exisiting README files and created a new one, updating all the components to match current state of the API exposed by Ably library. I've split all those into separate markdown paragraphs so it's easy to find each feature. I've also reduced the amount of boilerplate and unnecessary code in the examples, so they're easier to read.
If this file is okay for the rest of the team, I'll probably use it to refactor the main repository README file, which has a lot of legacy code in examples and is missing a few methods.

I think I've added all missing examples, so this PR should also close https://github.com/ably/ably-flutter/issues/139 and https://github.com/ably/docs/issues/1153. The list of examples should now be up-to-date with features in the library 🙂


Playlist and XMLTV Availability %

Can you please explain how these availability numbers become less than 100%. Is it a corruption issue or ... ??? and then after it's below 100% how can I get it back to 100% without removing the file from xTeVe and re-adding it.

Availability Drops when your Network Connection to the EPG or Playlist is lost, causing xTeVe to use the backup file. It's a problem with your Source data, not xTeVe.

The EPG data is on the filesystem. There is no network conection to it. It updates once a day. Do you mind elaborating what's wrong with the file and then how to fix it without deleting it from xTevE and re-adding it.

The only time I have seen availability drop, was when the information was not available. We will have to research more into your issue to find out whats going on.

Is there a number of days for it to be 100%?
I have DizqueTV with 48 hours of EPG & xteve says it's 58% all the time. I change it to 24 hours & it goes to 70% update & it slowly climbs, but if I sit & wait it doesn't go up anymore when I check again, but manually "Updating" keeps going up, after 82% it takes 2 clicks for it to go up, but waiting 20 minutes still keeps you at the same spot. The higher it goes the more update clicks to increase. Same thing when I went the other direction & increased it to 72 hours

Is there a number of days for it to be 100%? I have DizqueTV with 48 hours of EPG & xteve says it's 58% all the time. I change it to 24 hours & it goes to 70% update & it slowly climbs, but if I sit & wait it doesn't go up anymore when I check again, but manually "Updating" keeps going up, after 82% it takes 2 clicks for it to go up, but waiting 20 minutes still keeps you at the same spot. The higher it goes the more update clicks to increase. Same thing when I went the other direction & increased it to 72 hours

The number is irrelevant as far as I'm concerned. There's nothing wrong with my EPG data. All the channels are still there regardless. IMO the statistic shouldn't even be a thing. The EPG file is what it is. It either has the data or it doesn't.


Attempts to download public images as /unlisted/ (404 errors)

revision 512687bd09798a7980bc5429cae2ffa4e8977dbd, current git head.
if I attempt downloading all images for a member ID, it tries to download them as if all images were unlisted. This causes 404 errors.
going hack to HEAD~1 (ddb99bf26ed344cf2037c780c027016e5083b341) avoids the issue.
OS is Debian Linux (Sid) with Python 3.12.

Sorry for the inconvenience caused. Let me look into it and I will create a FIX over the weekend.


phpts env seems not work in unix

Describe the bug
phpts env seems not work in unix(macos-latest, ubuntu-latest)
Version
all version (v1 v2 master)
Runners

[x] GitHub Hosted
[ ] Self Hosted

Operating systems
macos-latest, ubuntu-latest
PHP versions
not related
To Reproduce
ceshici2 (last job) on https://github.com/dixyes/ghactionsplay/blob/main/.github/workflows/mian.yml#L108
Expected behavior
installed PHP cli should be zts version
Screenshots/Logs
see: https://github.com/dixyes/ghactionsplay/actions/runs/631344469
Additional context
nope
Are you willing to submit a PR?

not yet

Only nts is supported on linux and macOS
https://github.com/shivammathur/setup-php#thread-safe-setup
This may change in future, but I currently have no plans of adding zts support for Linux and macOS.
Please refer to https://github.com/shivammathur/setup-php/issues/363#issuecomment-742884304


Arrow installation link expired

The link wget https://apache.bintray.com/arrow/$(lsb_release --id --short | tr 'A-Z' 'a-z')/apache-arrow-archive-keyring-latest-$(lsb_release --codename --short).deb in install_deps_ubuntu.sh seems to be expired, and the script should be modified according to https://arrow.apache.org/install/.

I see.. +1
can you attend to this?

👌


CI for Node

App
✕ Contains the compiled JavaScript (5 ms)
Game
Game
✕ Initializes with two players (3 ms)
nextPlayer
✕ Starts the game with a random player (1 ms)
✕ Sets the current player to be whoever it is not (1 ms)


Indexing a ChunksOfCountCollection can crash with "Index out of bounds"

Replace this paragraph with a short description of the incorrect incorrect behavior. If this is a regression, please note the last version that the behavior was correct in addition to your current version.
Swift Algorithms version:
main branch
Swift version:
swift-driver version: 1.26.21 Apple Swift version 5.5.2 (swiftlang-13<IP_ADDRESS> clang-13<IP_ADDRESS>)
Target: arm64-apple-macosx12.0

Checklist

[x] If possible, I've reproduced the issue using the main branch of this package
[x] I've searched for existing GitHub issues

Steps to Reproduce
The following code crashes:
import Algorithms
import Foundation

let input = "A|1|B|2"
let keyPairs = input
  .split(separator: "|", omittingEmptySubsequences: false)
  .chunks(ofCount: 2)

let aValue = keyPairs.first(where: {$0.first == "A"})
//  .flatMap { Array($0) }
  .flatMap { $0.count == 2 ? $0[1] : nil }

let bValue = keyPairs.first(where: {$0.first == "B"})
//  .flatMap { Array($0) }  // <--- uncomment this and it no longer crashes
  .flatMap { $0.count == 2 ? $0[1] : nil }   // <--- crash here with "Fatal error: Index out of bounds"

print("A: \(aValue ?? "n/a"); B: \(bValue ?? "n/a")")

Expected behavior
It shouldn't crash. Each chunk has a count of 2 so accessing a chunk with index 1 should not crash.
Actual behavior
It crashes. If I uncomment the conversion back to Array it works fine. Based on some testing, the crash appears to happen with every sub-chunk after the first one.

This is the expected behavior, if I’m understanding the point correctly.
Not all collection indices start at 0, and indeed they don’t need to have indices of type Int. However, when you obtain a slice of a collection, that slice shares indices with its parent. When you attempt to access the element of a slice at index 1, this is supposed to be out of bounds if the slice doesn’t include the parent collection’s element that’s at index 1.
There isn’t anything specific to ChunksOfCountCollection but rather common to all of Swift.

You are correct and I've learned something new about Swift. Using $0.count == 2 ? $0[$0.startIndex + 1] : nil is the proper way to do this.

Using $0.count == 2 ? $0[$0.startIndex + 1] : nil is the proper way to do this.

index(_:offsetBy:) exists to do this. This would work for indices that aren’t Int and those that might not count by 1s.


to have 4 channels, but got 5 channels instead

I am going to erase the area with the following two files. However, an error keeps occurring.
image file: https://d2dhsa6ilfcfin.cloudfront.net/sample/image.png
mask file : https://d2dhsa6ilfcfin.cloudfront.net/sample/image_mask.png
Error: Given groups=1, weight of size [64, 4, 7, 7], expected input[1, 5, 606, 806] to have 4 channels, but got 5 channels instead

Hi @dinoglobal. This looks like an error specific to the model you're using instead of the Python client library. If the model has a linked GitHub repo, you can try contacting the maintainers.


File root is public to access.

In the current setup there is an issue that all files are accessible from the web.
You can just access the html file "/application/index.html", but also the git records and everything.
This is not best practise.
An easy fix will be to create a "public" folder in the root dir.
create a softlink to the ./index.php file. (cd public && ln -s ../index.php index.php)
Then set your apache web root to /var/www/vhosts/LISA/public and fix all issues.

Hey! Thanks for taking the time to create an issue.
Yes, you are right that the current deployment strategy is sub-optimal. It's kinda due to how CodeIgniter constructs their repository by default.
For now the only security issue I see is that the Git folder is exposed, even though the repository is public might it be that downstream deployments include secrets or that sensitive information is stored locally in the repository, e.g. in /.git/config.
Anyway, personally not too fond of using symlinks, as it's an imperative way to address to problem, except maybe if it would be in some automation script, like a CICD pipeline.
Instead my preference goes to some declarative method like nginx config. I quickly mashed a PR together (#25), my nginx experience is quite limited, so if you would have time to give it a look and provide feedback, then that would be appreciated.

Obviously, the downside of this approach is deployments use their own configuration files for the webserver, then this fix - and any future similar ones - will be ignored.

If this is how CodeIgniter works in the default setup, is CodeIgniter still the best solution for this project? I see a lot of potential on this project and I've a lot of ideas to add to this system like auto topup via a tikkie QR code or some other payment gateway, multiple products with different values, settings to disable payments on someone else's account etc.
If you think this app is what it is and does what it needs to do thats fine too.

No, CodeIgniter is definitely not the future nor the best choice for the project.
Imo, the project has reached legacy stage a couple years ago. It works as it is supposed to be working, doesn't have any known bugs and also no major feature requests. Once in a while I make some small additions to it, just for fun, but the dev experience is bad for me, not to talk about on boarding new developers.
Switching away from CodeIgniter is not going to be easy at all, and that's because of me 😅. I wrote an abstraction layer/"framework like thing" on top of CI onto which LISA is written. Hence, the business logic of LISA has quite some assumptions which will not be met by any other framework where one would like to migrate it to.
In the end, it's probably less time consuming to rewrite the entire application in a more modern software stack (e.g. Facebook's React+GraphQL) when the need for some new major feature arrises.
Security fixes however are still important, as there is still at least one copy in production. So thank you for pointing out the public files issue out!

@all-contributors please add SjamonDaal for security, infra


Question: How to use static assets in server side Blazor (From a Blazor library?)

While working on https://github.com/Joelius300/ChartJSBlazor, @Joelius300 and I didn't find a nice way to integrate static assets from a Blazor library to a server side example Blazor project.
The only way I know to achieve this, is using the https://github.com/SamProf/EmbeddedBlazorContent library from @SamProf to integrate the files into the project.
We don't want to simply copy the assets into the wwwroot folder of the Blazor server side project during build (This won't help people using the library in their projects either), neither copying them to the target project before creating a new one.
I found a comment (https://github.com/aspnet/AspNetCore/issues/11174#issuecomment-507515137) on that topic as well, where something like <script src="_content/LIBRARY_NAME/example.js> was mentioned. We tried that and it didn't work.
Is there a standard way yet in Blazor (NetCore 3-preview9) to get the static assets from a library to a server side project easily without the need to copy them (programatically or manually)?
EDIT: There is an old stackoverflow question as well: https://stackoverflow.com/questions/54782249/css-in-blazor-component-library-doesnt-load.

I think this is already possible since Preview 6. Please read danroth's blog post about Static assets in Razor class libraries here
I always recommend to check this blog every week 😄

From looking at the readme of blazor UI it doesn't seem like they are. There are a few statements which let me believe they solved it in some other way.

Make sure the following folder is automatically created in your project’s wwwroot directory

If you just use the library, no folder should be created automatically.

lib/dx-blazor/dx-blazor.js

Their links are not referencing _content like they should be if this feature was used.
Are you sure that they are using this?

Thanks for contacting us, @SeppPenner.
Have you checked out the Static Assets docs at: https://docs.microsoft.com/en-us/aspnet/core/razor-pages/ui-class?view=aspnetcore-3.0&tabs=visual-studio#create-an-rcl-with-static-assets

I think I have found the error. When running the application from visual studio or a non-published version, you need to include webBuilder.UseStaticWebAssets(); otherwise it won't work. That also explains why I got different results depending on the way I deployed the project (I didn't always use dotnet publish).
That should fix the issue, thank you.
Will the need for webBuilder.UseStaticWebAssets(); be removed in later versions?

However, I have a quick follow up question. One of the things that confused me most about this issue was the fact that a freshly created blazor library always worked, without calling UseStaticWebAssets() and without dotnet run or dotnet publish; it always worked even when just starting from visual studio.
I thought I might be missing some package or I might not have specified what kind of content my static assets were but the .csproj of that new library is very simple:
<Project Sdk="Microsoft.NET.Sdk.Razor">

  <PropertyGroup>
    <TargetFramework>netstandard2.0</TargetFramework>
    <RazorLangVersion>3.0</RazorLangVersion>
    <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
    <Version>1.0.0-preview</Version>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.Components" Version="3.0.0-preview9.19424.4" />
    <PackageReference Include="Microsoft.AspNetCore.Components.Web" Version="3.0.0-preview9.19424.4" />
  </ItemGroup>

</Project>

When packing this library (using the GeneratePackageOnBuild option) and adding a nuget-reference to the built package in my consuming server-side blazor application, the link to the static assets worked immediately without adding that extra call. When I added my packed library (which is also packed using the GeneratePackageOnBuild option) I made sure that my csproj-file contains the same references, uses the same SDK and doesn't mention the static content at all (just like the fresh library). However when I tried to consume the static content of my own library by starting the app from VS, it would always result in a 404. After adding a call to UseStaticWebAssets() it finally worked (same with dotnet run) but not before that.
Is there something I'm missing about my csproj-file which makes this not work or why does the freshly created library not require that additional call?
My csproj-file (which doesn't work):
<Project Sdk="Microsoft.NET.Sdk.Razor">
  <PropertyGroup>
    <TargetFramework>netstandard2.0</TargetFramework>
    <IsPackable>true</IsPackable>
    <LangVersion>default</LangVersion>
    <RazorLangVersion>3.0</RazorLangVersion>
    <VersionPrefix>0.3</VersionPrefix>
    <Title>ChartJs.Blazor</Title>
    <RequireLicenseAcceptance>false</RequireLicenseAcceptance>
    <Company>Joel Liechti</Company>
    <Authors>Joel Liechti</Authors>
    <Description>-</Description>
    <RepositoryUrl>https://github.com/Joelius300/ChartJSBlazor</RepositoryUrl>
    <PackageProjectUrl>https://github.com/Joelius300/ChartJSBlazor</PackageProjectUrl>
    <PackageTags>ChartJS; Blazor; ASP.Net-Core</PackageTags>
    <PackageSummary>ChartJS port to Blazor.</PackageSummary>
    <PackageReleaseNotes>-</PackageReleaseNotes>
    <AssemblyName>ChartJs.Blazor</AssemblyName>
    <RootNamespace>ChartJs.Blazor</RootNamespace>
    <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
    <Version>0.10.3-preview</Version>
    <AssemblyVersion><IP_ADDRESS></AssemblyVersion>
    <FileVersion><IP_ADDRESS></FileVersion>
    <PackageLicenseExpression>MIT</PackageLicenseExpression>
    <PackageId>ChartJs.Blazor.Fork</PackageId>
    <Copyright>Joel Liechti © 2019</Copyright>
    <PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
  </PropertyGroup>

  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
    <DocumentationFile>.\ChartJs.Blazor.xml</DocumentationFile>
  </PropertyGroup>

  <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Release|AnyCPU'">
    <DocumentationFile>.\ChartJs.Blazor.xml</DocumentationFile>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.Components" Version="3.0.0-preview9.19424.4" />
    <PackageReference Include="Microsoft.AspNetCore.Components.Web" Version="3.0.0-preview9.19424.4" />
    <PackageReference Include="Microsoft.CSharp" Version="4.6.0-preview9.19421.4" />
    <PackageReference Include="Newtonsoft.Json" Version="12.0.3-beta1" />
  </ItemGroup>
</Project>

This csproj-file has no mention of the static assets, includes the same packages and is packed the same way. The target framework and the SDK are also the same. However it still doesn't behave the same way the razor components library template does.
The original csproj-file (which does contain mentions of static assets and some other stuff) can be found here but this didn't work either.
What's the reason my library requires this additional call while the template one doesn't?

Thanks for contacting us, @SeppPenner.
Have you checked out the Static Assets docs at: https://docs.microsoft.com/en-us/aspnet/core/razor-pages/ui-class?view=aspnetcore-3.0&tabs=visual-studio#create-an-rcl-with-static-assets

I actually didn't find that page :D

But as far as I can see, the questions from @Joelius300 are legit...

/cc @javiercn

@SeppPenner
Let me extract the important part for you from the doc link above :
Create an RCL with static assets
An RCL may require companion static assets that can be referenced by the consuming app of the RCL. ASP.NET Core allows creating RCLs that include static assets that are available to a consuming app.
To include companion assets as part of an RCL, create a wwwroot folder in the class library and include any required files in that folder.
When packing an RCL, all companion assets in the wwwroot folder are automatically included in the package.

To include companion assets as part of an RCL, create a wwwroot folder in the class library and include any required files in that folder.
When packing an RCL, all companion assets in the wwwroot folder are automatically included in the package.

That's how it should work. I need to check this again, but the last time I tried it, it didn't work like that.

Again. This doesn't work:
_Host.cshtml:
@page "/"
@namespace WebCore.Pages
@addTagHelper *, Microsoft.AspNetCore.Mvc.TagHelpers
@addTagHelper *,ChartJs.Blazor

<!DOCTYPE html>
<html lang="de-ch">
<head>
    <meta charset="utf-8" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>WebCore</title>
    <base href="~/" />
    <environment include="Development">
        <link rel="stylesheet" href="css/bootstrap/bootstrap.min.css" />
    </environment>
    <environment exclude="Development">
        <link rel="stylesheet" href="https://stackpath.bootstrapcdn.com/bootstrap/4.3.1/css/bootstrap.min.css"
              asp-fallback-href="css/bootstrap/bootstrap.min.css"
              asp-fallback-test-class="sr-only" asp-fallback-test-property="position" asp-fallback-test-value="absolute"
              crossorigin="anonymous"
              integrity="sha384-ggOyR0iXCbMQv3Xipma34MD+dH/1fQ784/j6cY/iJTQUOhcWr7x9JvoRxT2MZw1T" />
    </environment>
    <link href="css/site.css" rel="stylesheet" />
</head>
<body>
    <app>@(await Html.RenderComponentAsync<App>(RenderMode.ServerPrerendered))</app>

    <script src="_framework/blazor.server.js"></script>

    <script src="https://cdnjs.cloudflare.com/ajax/libs/moment.js/2.24.0/moment-with-locales.min.js"
            integrity="sha256-AdQN98MVZs44Eq2yTwtoKufhnU+uZ7v2kXnD5vqzZVo="
            crossorigin="anonymous">
    </script>
    <script src="https://cdnjs.cloudflare.com/ajax/libs/Chart.js/2.8.0/Chart.min.js"></script>
    <script src="_content/ChartJs.Blazor/ChartJsInterop.js" type="text/javascript" language="javascript"></script>
    <link rel="stylesheet" href="_content/ChartJs.Blazor/ChartJsBlazor.css" />
</body>
</html>

And there is no js file under _content/ChartJs.Blazor...
I have created a branch that uses the library like in the blog post here: https://github.com/SeppPenner/ChartJSBlazor/tree/test-static-assets. Honestly, I don't see the issue yet. @Joelius300 had the same problem. @sven5 If you have the time, you can try it out...

Hi,
https://github.com/SeppPenner/ChartJSBlazor/tree/test-static-assets works for me without issue. can you print out the output from dotnet --info? Can you do dotnet build /bl and share the msbuild.binlog file?

dotnet --info:
.NET Core SDK (gemäß "global.json"):
 Version:   3.0.100-preview9-014004
 Commit:    8e7ef240a5

Laufzeitumgebung:
 OS Name:     Windows
 OS Version:  10.0.18362
 OS Platform: Windows
 RID:         win10-x64
 Base Path:   C:\Program Files\dotnet\sdk\3.0.100-preview9-014004\

Host (useful for support):
  Version: 3.0.0-preview9-19423-09
  Commit:  2be172345a

.NET Core SDKs installed:
  1.1.14 [C:\Program Files\dotnet\sdk]
  2.1.202 [C:\Program Files\dotnet\sdk]
  2.1.508 [C:\Program Files\dotnet\sdk]
  2.1.801 [C:\Program Files\dotnet\sdk]
  2.2.401 [C:\Program Files\dotnet\sdk]
  3.0.100-preview8-013656 [C:\Program Files\dotnet\sdk]
  3.0.100-preview9-014004 [C:\Program Files\dotnet\sdk]

.NET Core runtimes installed:
  Microsoft.AspNetCore.All 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.All 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.All]
  Microsoft.AspNetCore.App 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.0.0-preview7.19365.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.0.0-preview8.19405.7 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.AspNetCore.App 3.0.0-preview9.19424.4 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 1.0.16 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 1.1.13 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.0.9 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.1.12 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 2.2.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.0.0-preview7-27912-14 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.0.0-preview8-28405-07 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.NETCore.App 3.0.0-preview9-19423-09 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
  Microsoft.WindowsDesktop.App 3.0.0-preview7-27912-14 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 3.0.0-preview8-28405-07 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
  Microsoft.WindowsDesktop.App 3.0.0-preview9-19423-09 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

To install additional .NET Core runtimes or SDKs:
  https://aka.ms/dotnet-download

msbuild.binlog:
https://drive.google.com/drive/folders/1iuYcKvn7eI76299WNl-3h0Hc2HBAKtui?usp=sharing

@SeppPenner It seems that the binlog is from an incremental build. Could you produce a binlog for a clean build? (no bin,obj folders anywhere).
Could you also try a couple of things?

Could you try and set the culture of your system to en-US? The logs are (I think) in German and its hard to understand what's going on.
Could you see if everything works for you when the culture is en-US? (That would help us pinpoint the root cause)

@SeppPenner It seems that the binlog is from an incremental build. Could you produce a binlog for a clean build? (no bin,obj folders anywhere).

Sorry. I can do that.

Could you try and set the culture of your system to en-US? The logs are (I think) in German and its hard to understand what's going on.

Yes, is done.

Could you see if everything works for you when the culture is en-US? (That would help us pinpoint the root cause).

I get the same error in the browser. Check the details below.
The new log is here: https://drive.google.com/open?id=1iuYcKvn7eI76299WNl-3h0Hc2HBAKtui. I renamed the old one to msbuild_old.binlog and the new one is msbuild.binlog.
When I run the project referencing the library, I get the following error on the command line (The browser shows the same error as before, 404 not found with the js and css stuff):
warn: Microsoft.AspNetCore.Components.Server.Circuits.RemoteRenderer[100]
      Unhandled exception rendering component: Could not find 'getAvailableMomentLocales' in 'window'.
Error: Could not find 'getAvailableMomentLocales' in 'window'.
    at http://localhost:5000/_framework/blazor.server.js:8:28065
    at Array.forEach (<anonymous>)
    at p (http://localhost:5000/_framework/blazor.server.js:8:28026)
    at http://localhost:5000/_framework/blazor.server.js:8:28733
    at new Promise (<anonymous>)
    at e.beginInvokeJSFromDotNet (http://localhost:5000/_framework/blazor.server.js:8:28707)
    at http://localhost:5000/_framework/blazor.server.js:1:19148
    at Array.forEach (<anonymous>)
    at e.invokeClientMethod (http://localhost:5000/_framework/blazor.server.js:1:19119)
    at e.processIncomingData (http://localhost:5000/_framework/blazor.server.js:1:17165)
Microsoft.JSInterop.JSException: Could not find 'getAvailableMomentLocales' in 'window'.
Error: Could not find 'getAvailableMomentLocales' in 'window'.
    at http://localhost:5000/_framework/blazor.server.js:8:28065
    at Array.forEach (<anonymous>)
    at p (http://localhost:5000/_framework/blazor.server.js:8:28026)
    at http://localhost:5000/_framework/blazor.server.js:8:28733
    at new Promise (<anonymous>)
    at e.beginInvokeJSFromDotNet (http://localhost:5000/_framework/blazor.server.js:8:28707)
    at http://localhost:5000/_framework/blazor.server.js:1:19148
    at Array.forEach (<anonymous>)
    at e.invokeClientMethod (http://localhost:5000/_framework/blazor.server.js:1:19119)
    at e.processIncomingData (http://localhost:5000/_framework/blazor.server.js:1:17165)
   at Microsoft.JSInterop.JSRuntime.InvokeWithDefaultCancellation[T](String identifier, Object[] args)
   at WebCore.Pages.LineTimeExample.TryChangeLocale() in C:\Users\Tim Hammer\OneDrive - IVU Softwareentwicklung GmbH\Git\Misc\ChartJSBlazor\WebCore\Pages\LineTimeExample.razor:line 30
   at WebCore.Pages.LineTimeExample.OnAfterRenderAsync(Boolean firstRender) in C:\Users\Tim Hammer\OneDrive - IVU Softwareentwicklung GmbH\Git\Misc\ChartJSBlazor\WebCore\Pages\LineTimeExample.razor:line 119
   at Microsoft.AspNetCore.Components.RenderTree.Renderer.GetErrorHandledTask(Task taskToHandle)
fail: Microsoft.AspNetCore.Components.Server.Circuits.CircuitHost[111]
      Unhandled exception in circuit 'Ysjo0RejbMSQZNNByrmLWJ5ZGq-sTeJB9_N2OPKjeLw'.
Microsoft.JSInterop.JSException: Could not find 'getAvailableMomentLocales' in 'window'.
Error: Could not find 'getAvailableMomentLocales' in 'window'.
    at http://localhost:5000/_framework/blazor.server.js:8:28065
    at Array.forEach (<anonymous>)
    at p (http://localhost:5000/_framework/blazor.server.js:8:28026)
    at http://localhost:5000/_framework/blazor.server.js:8:28733
    at new Promise (<anonymous>)
    at e.beginInvokeJSFromDotNet (http://localhost:5000/_framework/blazor.server.js:8:28707)
    at http://localhost:5000/_framework/blazor.server.js:1:19148
    at Array.forEach (<anonymous>)
    at e.invokeClientMethod (http://localhost:5000/_framework/blazor.server.js:1:19119)
    at e.processIncomingData (http://localhost:5000/_framework/blazor.server.js:1:17165)
   at Microsoft.JSInterop.JSRuntime.InvokeWithDefaultCancellation[T](String identifier, Object[] args)
   at WebCore.Pages.LineTimeExample.TryChangeLocale() in C:\Users\Test\Git\Misc\ChartJSBlazor\WebCore\Pages\LineTimeExample.razor:line 30
   at WebCore.Pages.LineTimeExample.OnAfterRenderAsync(Boolean firstRender) in C:\Users\Test\Git\Misc\ChartJSBlazor\WebCore\Pages\LineTimeExample.razor:line 119
   at Microsoft.AspNetCore.Components.RenderTree.Renderer.GetErrorHandledTask(Task taskToHandle)
info: Microsoft.AspNetCore.Routing.EndpointMiddleware[1]
      Executed endpoint '/_blazor'
info: Microsoft.AspNetCore.Hosting.Diagnostics[2]
      Request finished in 18143.0622ms 101

Running with Visual Studio has the same effect. I hope, this helps you somehow @javiercn

Any updates on this? @javiercn

@SeppPenner I found your issue.
You are changing the package id to ChartJs.Blazor.Fork which means that static web assets are located at _content/ChartJs.Blazor.Fork/.....
In your project you reference them in _Host.cshtml as
    <script src="_content/ChartJs.Blazor/ChartJsInterop.js" type="text/javascript" language="javascript"></script>
    <link rel="stylesheet" href="_content/ChartJs.Blazor/ChartJsBlazor.css" />

Changing that to follow the _content/<<PackageId>> convention described in the docs, fixes the issue
    <script src="_content/ChartJs.Blazor.Fork/ChartJsInterop.js" type="text/javascript" language="javascript"></script>
    <link rel="stylesheet" href="_content/ChartJs.Blazor.Fork/ChartJsBlazor.css" />

@javiercn Thanks.  The nuget is renamed to ChartJs.Blazor.Fork because ChartJs.Blazor already exists, but the project itself wasn't. Well, I will provide a pull request for this @Joelius300.

 Thanks @javiercn


[spark] Add validation for param 'early_stopping_rounds' and 'validation_indicator_col'

Signed-off-by: Weichen Xu<EMAIL_ADDRESS>Add validation for param 'early_stopping_rounds' and 'validation_indicator_col'

CC @trivialfis @wbo4958 Thanks!

@trivialfis @wbo4958 Ready for merging ! :)

@trivialfis @wbo4958 Ready for merging :)

Will look into the CI and merge it today.

+1 ed.

Could you please fix the test?

CC @trivialfis Tests fixed. Failed CIs are not related.


No unit test for enabled and disabled EndOfLine

If enabled, should be "$", if not, should be empty

Test ok, check on AppVeyor


does not contain bitcode

GoogleAppMeasurement.framework/GoogleAppMeasurement(APMEventAggregates.o)' does not contain bitcode. You must rebuild it with bitcode enabled (Xcode setting ENABLE_BITCODE), obtain an updated library from the vendor, or disable bitcode for this target. file '/Users/haru/Library/Developer/Xcode/DerivedData/Unity-iPhone-cuotwyogvxfhadenpzxqztkjdlfr/Build/Products/ReleaseForRunning-iphoneos/XCFrameworkIntermediates/GoogleAppMeasurement/WithoutAdIdSupport/GoogleAppMeasurement.framework/GoogleAppMeasurement' for architecture arm64

Bitcode was removed in the 10.1.0 release because it is no longer supported by Xcode 14.
It's recommended to remove bitcode from your Build Settings.
If you still want to use bitcode in an Xcode 13 build, stick with an earlier Firebase release.


Applying filter using applyFilterAsync breaks session?

I have a selection of marks that are shown at first, and after an action I would like to replace the filter to show only one of the marks in the selection. Performing the code below basically crashes my Tableau.
        ws.applyFilterAsync("REF_101_Perceelnummer", perceel, "replace").then(result => {           console.log(result);         });
Clicking "About" in the Extensions settings does not work, the debugger in my Chrome browser (http://localhost:8696/) is not responding either. Reloading the extension only gives me a white screen. Extensions only work again after restarting Tableau. This is on Desktop btw.

Tom:
Sorry for the delay. We have been battling #Snowmaggedon2019 here in the Seattle area. :-)
Is the action happening before you call applyFilterAsync a longer running command? We have found, and fixed, several issues with commands not being synchronized properly. These issues are fixed in 2019.1, coming soon. If that is the problem, there isn't a great way to solve it. You can put a delay before your applyFilterAsync. That would be a short term hack.
John

Hi Tom ... is this still an issue for you? We would need to see a log to get more insight into what might be happening. Let us know so we can figure out if this is still an issue or we should close this out.

No, its not. You can close it!


Typo in Pull Request template

There is a small typo in the PR template:
I think it should be devtools::document() and not devtools::documents()

Indeed. Good catch, thanks for spotting 👍

You cannot even commit directly to main 😉 Please open a PR. ALso, I think we should avoid PRs towards main as much as possible. Let's direct this at devel. We'll release soon anyway.


numérotée la liste

@yamommasofat yamommasofat
Upon reviewing your commit, we identified some inconsistencies in the JSON file structure. To resolve this issue, I kindly request that you take the following steps:
Review the JSON file structure guidelines: Familiarize yourself with the JSON file structure guidelines that we have established. These guidelines outline the expected format, key-value pairs, nesting, and any specific requirements for the JSON files in our repository.
Make necessary adjustments: Once you understand the JSON file structure guidelines, please make the necessary adjustments to your commit. Ensure that your changes align with the prescribed structure and follow the recommended practices.
Submit a revised commit: After making the required changes, please submit a revised commit with the updated JSON file adhering to the established guidelines. Provide a clear and concise commit message that describes the purpose of the changes you made


Lock attack options

Currently on RuneLite it is possible to remove attack options which is obviously useful for pures etc, however what I am suggesting is to add an option in which you can lock the option from being selected, not removing it from the combat options tab entirely. This means that if you try to click it, it doesn't let you and potentially tells you in the chat box. This was a feature on a previous client. The purpose is it looks a lot nicer than removing options all together and is essentially nicer for clips etc.
Same for auto-retaliate.

So you're requesting the same feature that's already offered in the attack styles plugin, but without removing the buttons from the interface? (so clicking them would have no effect) That seems kind of useless to me.

Imo this is nice request, because in case of weapons that change attack style, and you ahve that attack style hidden, you will at least see to what it was changed. I like just disabling input on them way more than hiding them

Going to look at this one as my first contribution.

Added the following:

enum options for auto retaliate (none, lock, remove) and how to handle warned styles (warn, lock, remove)
chat message for locked options and weapon switched to warned style

Would like to add a lock icon to the buttons but I'm not quite sure how to do this at the moment.


Import in Offline Environment

Good afternoon!
I work with an internal development environment completely offline, without internet connection.
I copied the 'brazil-latest.osm.pbf' file to my offline machine and started the import process.
During the import process, I ended up getting stuck when the import tries to request to the address  https://www.openstreetmap.org/api/0.6/node/10884626565/1
Is it possible to be carrying out this import process in a completely offline environment? Performing all the necessary downloads before and just passing the path of these files.

I don't think that it's possible but if I'm honest I don't know why.
You can start execute the import on a connected machine and then use docker import/export to move it to the offline one.

Well done for figuring it out.
If you can leave more detailed documentation here, I can link to it from the Readme.


diffutils: 3.5 -> 3.6

Motivation for this change
new version
Things done

[ ] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[X] Linux

[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[X] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Do you know if #25154 has been fixed?  We had to revert 3.4 -> 3.3 a month ago.


Support for Canvas isPointInPath()

Please add support information for isPointInPath() method on Canvas. Thank you.

Available via MDN now: https://caniuse.com/?search=isPointInPath


(maint) Update packaged modules

Update to latest modules for next bolt release.
!feature

Update puppet modules shipped with bolt packages
Modules shipped with bolt packages have been updated to latest.

latest puppet_agent module drops support for puppet6. I think that is fine, will need to do some test cleanup.


Support arbitrary attributes

It looks like OpenEXR supports arbitrary attributes in the header. There are a bunch of standard, but optional, atrtributes defined in https://github.com/openexr/openexr/blob/develop/OpenEXR/IlmImf/ImfStandardAttributes.h
It would be nice to support at least some of them, like owner, comments, or capDate.
I may give it a shot maybe if I can find a bit of time, but might need a little bit of guidance :)

For my project I absolutely need support for (writing) the multiView attribute.  This is the only attribute I need to get past a brick wall.
IMF_STD_ATTRIBUTE_DEF (multiView , MultiView, StringVector)
I need a very very short term fix otherwise I cannot progress with my project, a hack if necessary. Any suggestions?

I'll try to bang that one out; I'll probably want it someday myself.

See #39


Remove infra app from duper model only if it is supposed to be in duper model

Merging to unbreak CD - please still review


Fix endianness detection in memcopy.h

When memcopy.h is included into inffast.c, endianness-related
preperocessor defines are not set, which leads to
BYTE_ORDER == LITTLE_ENDIAN condition being always true. This breaks
decompression at least on s390x.

Looks good to me.  Thanks!


Cannot expand or collapse the tree

I also have the same problem! i get the tree but cannot expand or collapse it..
Working with .net core + angular 2, Visual studio template , Web pack
I added the css as well in to a css file and refered. Still no luck
I do not use angular cli
Thanks in advance

@dgkTiqri Could you reproduce an issue here so that I could help you?
https://stackblitz.com/edit/angular-ud8pry


[SPARK-7978] [SQL] [PYSPARK] DecimalType should not be singleton

cc @JoshRosen @rxin

Merged build triggered.

Merged build started.

Test build #33836 has started for   PR 6532 at commit 1425359.

Does this need to block 1.4?

@rxin I think so, it's a regression.

Test build #33836 has finished for   PR 6532 at commit 1425359.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

I guess the root cause of this bug was that the DecimalType class's singleton-ness was inherited due to our use of metaclasses.  In Scala, we didn't have this problem because the singleton-ness was implemented at the leaves of the class hierarchy by using object.
To prevent this sort of issue in the future, I wonder whether it would be clearer to apply a decorator on the leaf class declarations themselves (as in http://elbenshira.com/blog/singleton-pattern-in-python/) rather than using metaclasses.  It would be good to understand whether the difference between these approaches has any performance / correctness impacts.
In the meantime, the fix here makes sense to me: we're just pushing the singleton-ness a bit deeper into the class hierarchy so that it isn't inappropriately inherited by DecimalType.
From a test coverage perspective, what tests would have caught this?  It seems that something as simple as just manually constructing an instance of each type with all of its parameters specified would have caught this.  Even though it seems like an obvious / dumb test, maybe we should add a test that just checks that we're able to instantiate each of the types that take parameters.

Also, I wonder whether cov.py would have shown this as missing in its coverage report, since it seems like some sorts of branch coverage tests would notice that this path wasn't exercised.

Merged build triggered.

Merged build started.

Test build #33848 has started for   PR 6532 at commit c7fcbce.

@JoshRosen I think the new added test could coverage that DecimalType is not singleton, by
  self.assertTrue(t2 is not t1)

It may make sense to switch other singleton patterns, but I'd like to fix this first without introducing too much other things.

Test build #33848 has finished for   PR 6532 at commit c7fcbce.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Maybe another systematic fix is to not allow the singleton-ing of any Type that takes constructor args? At subclass time can you check that?

@davies, I agree that the test you added here acts as a proper regression test.  My comment was more to suggest that we could have prevented this regression in the first place with a relatively simple test that just tries to instantiate each data type with all of its constructor arguments.  The fact that this bug evaded unit tests implies that our existing unit tests didn't create DecimalTypes with any constructor arguments, implying that our test coverage of decimal-related code might be insufficient.  I think that this patch is fine, but for 1.5 we should make a dedicated effort to improve Python's test coverage.
@airhorns, do you mean that the single metaclass would act as a no-op when applied to Types that take constructor arguments or that it would throw an exception if applied to those types?  This is purely academic at this point, but I can imagine some contrived scenarios where the no-op behavior might be confusing: what if I had a class which accepted constructor parameters, then created a subclass which called its superclass constructor with constant values for those parameters?  In this case, the subclass can be a singleton but the superclass can't.  To avoid having to reason about these corner-cases, maybe it's better to just accept a bit of verbosity and use decorators instead.  We shouldn't do that for this patch, though; we can leave it as a followup for 1.5.

@JoshRosen sounds good to me!

As an experiment, I put together some code to run the PySpark test suite through coverage.py (https://gist.github.com/JoshRosen/60d590b1cdc271d332e5) and it turns out that line + branch coverage for the DecimalType class itself doesn't uncover this bug since it won't catch the fact that the constructor is only ever called with defaults for both of its arguments.  The closest thing to a red flag in the coverage report was the fact that the only call to DecimalType with arguments, inside of _parse_datatype_json_value, wasn't hit by the tests.


2 extra output classes in ImageNet-21K

Why are there 21843 classes when the dataset only has 21841?

You could see #7 for the WordNet IDs and check which are missing? I believe these may just be two IDs that did not have any images, but I do not remember exactly.

I think the two IDs are n03931044 & n09859684

Hi everyone
Can you please put the 21841 class text file. I really searched all internet but i couldn't find it. the word net id's also are 21843 numbers.
Thank you


Responsive 'stacked' causes rows to go over each other

I have large tables with a lot of data columns. The stacked option is a great idea for having the table provide data on smaller screens.
But the rows appear scrunched against each other, like this:

I tried the other responsive options but they are not what I'm looking for. Is there a solution?

Following @wdh2100's response on another issue I looked here and figured out a scheme that would work for me. But there is still one issue.
This is how I'm setting the relevant options on the table. First I check if the app is running on mobile or desktop:
let scroll = isMobile ? 'scrollMaxHeight' : 'scrollFullHeight';

Then in the table options:
denseTable: false,
responsive: scroll,

This works fine on mobile and large desktop screens, but on laptops or smaller desktop screens data is hidden on the right side of the screen, and there is no way to do horizontal scroll to view it.
You can see an example on https://deepdao.world, if you select one of the rows in the dashboard, and then either Proposals or Members. Both tables have a larger number of columns. Play with the screen size and you'll see the effect.
Is there a solution?

I think it's better to give you style {overflow : auto}

Great, thanks @wdh2100

This should be fixed in version 3.0.0.


⚠ Fortnite has degraded performance

In 6c1a085, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1673 ms

Resolved: Fortnite performance has improved in e0ea4b9.


How to download the build from cloud

Due to a hard disk crash, I lost my code base on localhost. But my app is available on appgyver cloud and I can use scanner to browse the app.
So, is there a way to download my app from appgyver's cloud?

Email<EMAIL_ADDRESS>and we can help you after we have verified your identity.
Please start using Github so that this won't happen to you again.

Thanks!
I use bitbucket and was able to recover from there successfully.
Sent from Outlook
On Mon, Mar 2, 2015 at 3:23 AM -0800, "Petrus Repo"<EMAIL_ADDRESS>wrote:
Email<EMAIL_ADDRESS>and we can help you after we have verified your identity.
Please start using Github so that this won't happen to you again.
—
Reply to this email directly or view it on GitHub.


How to determine last viewed sheet?

When parsing a Workbook, is there a way to determine what sheet was last viewed?  Is this information even available in an XLS file?
To further clarify, if I have 3 sheets in a workbook (named Sheet1, Sheet2, Sheet3) and Sheet2 was edited then saved, upon importing the workbook through SheetJS, is there a way to surface Sheet2 as the last viewed sheet in the workbook structure?

Sounds like interesting functionality you'd have in the code for the view's model. As such, I'd expect to get clearer input from https://github.com/SheetJS/SheetJS.github.io/ because they have a view there.
My guess is that they don't have this functionality, but that it should be "easy" to add in.

This information is stored in the Window1 record in XLS as well as in the workbookView tag in the XLSX/XLSM workbook xml and corresponding record in XLSB.  The problem is that it isn't uniquely defined: if you have multiple windows, there are multiple "last viewed" sheets, one for each view.
We could surface the current selected worksheet index/name in the wb.Workbook.Views array.  The file itself just stores the index -- should the index or the name be stored here, and how should worksheet reordering (re-sorting the wb.SheetNames array) affect this?

@SheetJSDev Sorry, I'm not sure if your response was waiting for a response from me. ;)

We could surface the current selected worksheet index/name in the wb.Workbook.Views array.

I think this would be a sufficient solution in my use case as I don't have multiple windows opening the same spreadsheet.
As I am not experienced enough with the inner workings of SheetJS at this moment, I would hazard a guess and suggest that storing the worksheet name would probably work best to address the worksheet reordering use case you brought up.
Having said the above, my need for this functionality has been lowered in priority since I first asked the question so unless others would find a need for this functionality, it can probably be noted and placed on the backburner.  Thanks for taking a look!

This is the same question as #1251


central topopaths

until now all the calculation of paths is done in different places. This PR introduces a TopoPaths struct that only holds references to  three things.

Path to the actual topology file
path to the working dir (where the configs are stored etc.)

All the other required paths are then generated from these, using a set of constants and rules.
The path calculation is hereby streamlined and unified.
next is to probably also feed the TopoPath into the Pre- and PostDeploy methods... But lets do so in the next step.
If someone would want to change the directory layout of clab, this would be possible by introducing an interface on top of this PR, and providing a different interface implementation thereby returning different paths.


When will Gradle 8.8 be released?

Expected Behavior
I am developing a package based on JDK 22, and I need Gradle 8.8 to support it.
Current Behavior (optional)
No response
Context
It would be nice if gradle 8.8 could be released to solve the problem that 8.7 does not support JVM 22

use gradle 8.8 nightly
https://services.gradle.org/distributions-snapshots/

use gradle 8.8 nightly https://services.gradle.org/distributions-snapshots/

Are you using gradle wrapper?

Yes, I also tried wrapper, with or without wrapper works fine.

Yes, I also tried wrapper, with or without wrapper works fine.

谢谢大佬，不过我的包依赖本地的gradle.我还是等它发布8.8再继续用吧

Your issue appears to be a question about how to use Gradle. They should be asked in a different channel, so we will close it. Your question might be answered in Gradle documentation or on our community Slack or forums. Find links to these resources on help.gradle.org.

Refer to the Compatibility Matrix. You can use 8.7 to build Java 22 projects by leveraging toolchains.


Unable to set horizontal errorbars, or both horizontal and vertical at same time

Hello,
The hv.errorbars object does not have any provision to allow both vertical and horizontal errorbars simultaneously.  I also cannot find an option to have the "error" in the errorbar be aligned along the horizontal x-axis. If this was a possibility, dual axis errorbars could be implemented by overlaying two plots.
This appears to be the case regardless of backend. Am I missing something in the documentation? Is this feature intentionally omitted?
Thank you,
-Simon

I'd be in favor of adding an option to draw the errorbars horizontally which would allow overlaying them to get both horizontal and vertical bars.

ErrorBars now have a horizontal parameter which is documented.


[Feature] Resolve variables in swagger template with stack output

Replace variables in swagger json templates with created output in Cloudformation stack.

Would also need to replace variables from created lambda functions (e.g. the created lambdas ARN)

implemented


Fix cls builder functions MOD-3210

Largely a revert of #1945
Changelog

Fixes error when running @modal.build methods, introduced in v0.63.19

👍 on the code change but is there a test we could have had that would have blocked this from going in originally?

An integration test for @build would have been the most straight-forward way of catching this. There are client tests too, but they sadly require the test setup to explicitly trigger the function in standalone mode rather than "new style method mode" which we weren't doing.
I'm separately working on fixing them, but we'd need a bit more of an "end to end" test harness in the client to safely do changes like this


Add LayerNorm documentation

I just realized I never added the documentation to the LayerNorm layer.
I also corrected a couple of typos in the batch_normalize function documentation.

Thanks :)


Added Message builder

Premise
See the related Trello checklist
Changes

Added a Message builder that allows to quickly build SMSMessage s containing requests and responses of each kind

Side Changes

Added Constructor in GeoPosition that takes an android.location.Location object, and a method that allows retrieving an android.location.Location object.

Added isAlarmResponse in AlarmManager (missed that in the previous pull)

Footer
No easter egg today
(you have been bamboozled)

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 2

Complexity increasing per file
==============================
- app/src/main/java/ingsw/group1/findmyphone/MessageBuilder.java  5
- app/src/test/java/ingsw/group1/findmyphone/MessageBuilderTest.java  1

See the complete overview on Codacy

If we leave the building logic inside other classes we gain very little in modularity, bacause if a message is badly formatted we still need to look into a separate class to find the issue. I suggest moving it all inside the builder class, also because I wouldn't consider it the other classes' job

What do you say about moving the other classes into the same package and make them package private, leaving the builder public?
I'm saying this bc we already have complete tests for them

Well, we need to call them from outside, when triggering the alarm for example, so Idk, if you can make it work then ok

Well, we need to call them from outside, when triggering the alarm for example, so Idk, if you can make it work then ok

Oh, you meant moving them close but keeping all public?

I was thinking about putting the methods of those classes inside the message builder, the position should still be retrieved by the Location Manager, but it's the background service that calls both and answers

I was thinking about putting the methods of those classes inside the message builder, the position should still be retrieved by the Location Manager, but it's the background service that calls both and answers

Swear I'm gonna fix this ASAP, the geoCalendar kept me busy

No probs considering I am not really helping there

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 4

Complexity increasing per file
==============================
- app/src/main/java/ingsw/group1/findmyphone/managing/location/GeoPosition.java  2
- app/src/main/java/ingsw/group1/findmyphone/managing/alarm/AlarmManager.java  2
- app/src/main/java/ingsw/group1/findmyphone/managing/ServiceManager.java  1
- app/src/test/java/ingsw/group1/findmyphone/managing/location/GeoPositionTest.java  2
- app/src/main/java/ingsw/group1/findmyphone/managing/alarm/AlarmMessageHelper.java  2
- app/src/main/java/ingsw/group1/findmyphone/managing/Manager.java  6
- app/src/test/java/ingsw/group1/findmyphone/managing/location/LocationMessageHelperTest.java  1
- app/src/main/java/ingsw/group1/findmyphone/managing/location/LocationManager.java  1
- app/src/main/java/ingsw/group1/findmyphone/managing/location/CommandResponseLocation.java  1
- app/src/test/java/ingsw/group1/findmyphone/managing/alarm/AlarmMessageHelperTest.java  1
- app/src/test/java/ingsw/group1/findmyphone/MessageBuilderTest.java  1
- app/src/main/java/ingsw/group1/findmyphone/managing/MessageBuilder.java  5
- app/src/main/java/ingsw/group1/findmyphone/managing/location/LocationMessageHelper.java  3

Clones added
============
- app/src/test/java/ingsw/group1/findmyphone/location/GeoPositionTest.java  1
- app/src/test/java/ingsw/group1/findmyphone/managing/location/GeoPositionTest.java  1

See the complete overview on Codacy

Wait I messed up

Wait I messed up

Ok it wasn't all my fault, Android studio kept a forgetfulness hidden from me.

 Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

Complexity increasing per file
==============================
- app/src/main/java/ingsw/group1/findmyphone/managing/alarm/AlarmMessageHelper.java  2
- app/src/test/java/ingsw/group1/findmyphone/MessageBuilderTest.java  1
- app/src/main/java/ingsw/group1/findmyphone/managing/alarm/AlarmManager.java  2
- app/src/main/java/ingsw/group1/findmyphone/managing/Manager.java  6
- app/src/main/java/ingsw/group1/findmyphone/managing/location/LocationManager.java  1
- app/src/test/java/ingsw/group1/findmyphone/managing/location/GeoPositionTest.java  2
- app/src/test/java/ingsw/group1/findmyphone/managing/location/LocationMessageHelperTest.java  1
- app/src/main/java/ingsw/group1/findmyphone/managing/ServiceManager.java  1
- app/src/test/java/ingsw/group1/findmyphone/managing/alarm/AlarmMessageHelperTest.java  1
- app/src/main/java/ingsw/group1/findmyphone/managing/location/GeoPosition.java  2
- app/src/main/java/ingsw/group1/findmyphone/managing/location/LocationMessageHelper.java  3
- app/src/main/java/ingsw/group1/findmyphone/managing/location/CommandResponseLocation.java  1
- app/src/main/java/ingsw/group1/findmyphone/managing/MessageBuilder.java  5

See the complete overview on Codacy

I was thinking about putting the methods of those classes inside the message builder, the position should still be retrieved by the Location Manager, but it's the background service that calls both and answers

Ok, I did not do that at the end, because in my opinion, it's too much code for a single class, but I did reorganize the packages, the result is the following:

Everyone, tell me your thoughts pls


Try to fix dataset update bug

This may fix the dataset update bug - I was only able to try with the Cell Type Annotation preview datasets - for some reason the Datasets search page is not working in my local portal-ui instance.
I think perhaps what is happening is that, in the portal, since the view configs have version 0.1.0, when they are "upgraded" to v1.0.0, they are all being assigned the same dataset ID. The data hook functions check the dataset ID to determine whether the useEffect needs to be re-run. If it is always "A", then perhaps it is not re-running as expected when a new dataset is selected from the portal dataset dropdown.

This looks like it works now.

@keller-mark It looks like the updates are one behind where they should be - trying to confirm now.


Youtube E0_NAlY2Z7U "No video formats found"

Checklist

[x] I'm reporting a broken site support
[x] I've verified that I'm running youtube-dl version 2020.06.06
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar issues including closed ones

Verbose log
C:\Users\Riki>youtube-dl -f mp4 https://www.youtube.com/watch?v=E0_NAlY2Z7U
[youtube] E0_NAlY2Z7U: Downloading webpage
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
C:\Users\Riki>youtube-dl -f mp4 https://www.youtube.com/watch?v=E0_NAlY2Z7U
[youtube] E0_NAlY2Z7U: Downloading webpage
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
C:\Users\Riki>youtube-dl --verbose -f mp4 https://www.youtube.com/watch?v=E0_NAlY2Z7U
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', '-f', 'mp4', 'https://www.youtube.com/watch?v=E0_NAlY2Z7U']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2020.03.08
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.14393
[debug] exe versions: ffmpeg git-2020-03-12-675bb1f, ffprobe git-2020-03-12-675bb1f
[debug] Proxy map: {}
[youtube] E0_NAlY2Z7U: Downloading webpage
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp378onz6j\build\youtube_dl\YoutubeDL.py", line 797, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp378onz6j\build\youtube_dl\extractor\common.py", line 530, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp378onz6j\build\youtube_dl\extractor\youtube.py", line 2364, in _real_extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp378onz6j\build\youtube_dl\extractor\common.py", line 1327, in _sort_formats
youtube_dl.utils.ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
C:\Users\Riki>youtube-dl --verbose -f mp4 E0_NAlY2Z7U
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', '-f', 'mp4', 'E0_NAlY2Z7U']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2020.03.08
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.14393
[debug] exe versions: ffmpeg git-2020-03-12-675bb1f, ffprobe git-2020-03-12-675bb1f
[debug] Proxy map: {}
[youtube] E0_NAlY2Z7U: Downloading webpage
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp378onz6j\build\youtube_dl\YoutubeDL.py", line 797, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp378onz6j\build\youtube_dl\extractor\common.py", line 530, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp378onz6j\build\youtube_dl\extractor\youtube.py", line 2364, in _real_extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp378onz6j\build\youtube_dl\extractor\common.py", line 1327, in _sort_formats
youtube_dl.utils.ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Description
For no obvious reason, https://www.youtube.com/watch?v=E0_NAlY2Z7U cannot be downloaded.
(1st attempt was with an approximately 1 month old version, I updated with -U in a separate window as superuser before the others)
Worth mentioning that I don't have a folder called "dst" (although I didn't check VirtualStore)?

Works fine for me.

I am experiencing this issue as well on a lot, but not all, videos.

Same problema ....................


gpio_matrix_in and gpio_matrix_out documentation is incorrect for esp32c3 (IDFGH-10490)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
The documentation for gpio_matrix_out states:
  * @param uint32_t signal_idx : signal index.
  *                        signal_idx == 0x100, cancel output put to the gpio

The parameter passed here is written directly to the GPIO_FUNCn_OUT_SEL_CFG_REG register, which according to the ESP32-C3 TRM:

If a value 128 is written to this field, bit n of GPIO_OUT_REG and GPIO_ENABLE_REG will be selected as the output value and output enable. (R/W)

The 0x100 value is correct for ESP32, but not for ESP32-C3.  The same problem is also present in the ESP32-C6 copy of the file.  Calling gpio_matrix_out(pin, 0x100, 0, 0) on ESP32-C3 results in connecting the output pin to signal 0, the SPIQ_out peripheral, with the GPIO_FUNCn_OUT_INV_SEL bit set.
Similarly, the documentation for gpio_matrix_in states:
  * @param uint32_t gpio : gpio number, 0~0x2f
  *                        gpio == 0x3C, input 0 to signal
  *                        gpio == 0x3A, input nothing to signal
  *                        gpio == 0x38, input 1 to signal

but the TRM entry for GPIO_FUNCn_IN_SEL_CFG_REG says:

Or selects 0x1e for a constantly high input or 0x1f for a constantly low input.

Fixing the documentation would help, but even better would be to provide #define entries for these constants so that the same code can be used on multiple ESP32 platforms without having to #ifdef each supported platform, and update the list of #ifdefs each time a new ESP32 platform is released.

@colincross  The GPIO_MATRIX_CONST_ONE_INPUT and GPIO_MATRIX_CONST_ZERO_INPUT defined in  the soc/gpio_pins.h are what you want.

Calling gpio_matrix_out(pin, 0x100, 0, 0) on ESP32-C3 results in connecting the output pin to signal 0

why? doesn't this mean to connect the signal whose ID is 0x100 to the GPIO with the number of pin? and signal 0x100 is SIG_GPIO_OUT_IDX, which means the normal GPIO output signal.

SIG_GPIO_OUT_IDX is 128 on ESP32-C3 (see https://github.com/espressif/esp-idf/blob/master/components/soc/esp32c3/include/soc/gpio_sig_map.h#L176), not 256 like on other platforms.  The GPIO_FUNCn_OUT_SEL field on ESP32-C3 is only 8 bits wide, so writing 0x100 to it sets GPIO_FUNCn_OUT_SEL=0x00 and GPIO_FUNCn_OUT_INV_SEL=1.
Thanks for the pointers to SIG_GPIO_OUT_IDX, GPIO_MATRIX_CONST_ONE_INPUT, and GPIO_MATRIX_CONST_ZERO_INPUT, those are exactly the values needed, so the only problem is that the gpio_matrix_in and gpio_matrix_out documentation refers to incorrect hardcoded values and should instead refer to those macros.

Thanks for the explanation. BTW, you can switch to using the APIs provided by esp_rom_gpio.h, which one is treated as stable and public APIs across all targets, including the API documentation there.

I also found GPIO_FUNC_IN_HIGH and GPIO_FUNC_IN_LOW in rom/gpio.h, which have the correct values for all platforms except for esp32c3, where they are 0x38 and 0x3C when they should be 0x1e and 0x1f: https://github.com/espressif/esp-idf/blob/master/components/esp_rom/include/esp32c3/rom/gpio.h#L31

@colincross Just wanted to say thank you for opening this issue. I think this may explain something that drove me nuts for weeks :)

#define FASTLED_INTERNAL                             //  Otherwise FastLED shows compile messages
#include <FastLEDHub.h>

#define NUM_LEDS 100
#define LED_TYPE WS2812B
#define LIGHTSTRIP_PIN 5

CRGB leds[NUM_LEDS];

void setup()
{
  FastLEDHub.initialize("Project Name");
  FastLEDHub.addLeds<LED_TYPE, LIGHTSTRIP_PIN, GRB>(leds, NUM_LEDS);
}

void loop()
{
  FastLEDHub.handle();
}

d:\Arduino\Sketchbook\libraries\FastLED\src\platforms\esp\32\clockless_rmt_esp32.cpp: In member function 'void ESP32RMTController::startOnChannel(int)':
d:\Arduino\Sketchbook\libraries\FastLED\src\platforms\esp\32\clockless_rmt_esp32.cpp:266:29: error: 'RMTMEM' was not declared in this scope
266 | mRMT_mem_start = & (RMTMEM.chan[mRMT_channel].data32[0].val);
| ^~~~~~
d:\Arduino\Sketchbook\libraries\FastLED\src\platforms\esp\32\clockless_rmt_esp32.cpp: In static member function 'static void ESP32RMTController::doneOnChannel(rmt_channel_t, void*)':
d:\Arduino\Sketchbook\libraries\FastLED\src\platforms\esp\32\clockless_rmt_esp32.cpp:347:5: error: 'gpio_matrix_out' was not declared in this scope; did you mean 'gpio_iomux_out'?
347 | gpio_matrix_out(pController->mPin, 0x100, 0, 0);
| ^~~~~~~~~~~~~~~
| gpio_iomux_out
exit status 1
Compilation error: exit status 1
https://user-images.githubusercontent.com/94954133/281659178-4d72d9af-ab59-4087-a02d-a1741ad86c8b.png


[Request] Allow remapping of ASCII tiles to different Unicode characters

Is your feature request related to a problem? Please describe. I'm trying to create a game in a language that doesn't use the Latin alphabet (Japanese), but even though my ascii.png contains all the necessary graphics, I have to manually enter the hexadecimal codes of each character into project.json. This makes it very tedious to add dialogue, and impossible to read in the editor.
Describe the solution you'd like. The user should be able to remap which Unicode characters correspond to each tile in ascii.png.
Describe alternatives you've considered. Unfortunately, true Unicode support seems out of the question. Exceeding 256 characters would make the tileset unable to fit into VRAM completely, therefore a system would be necessary to only load the required characters, similar to the current system used for backgrounds.
Additional context

Totally agree.
In the meantime, ill put my ascii table here incase people find this and can't type characters.
https://gist.github.com/RichardULZ/2920dca52989902dbb7225318256c545
Highly recommend a tool like notepad++ for bulk replacement too, there's a feature for multi replacement.
https://superuser.com/a/766489
If you set it all up, you may be able to type Japanese in the editor and run a bulk conversion on the json in notepad++ from Japanese to hex or special characters.


Windows [TP4] Trap Hyper-V exec failure

Signed-off-by: John Howard<EMAIL_ADDRESS>This traps a known issue in TP4 with Hyper-V containers and docker exec and don't end up logging an incomprehensible error message.

Thanks @jhowardmsft, I see there's a vendor update in there, could you move that to a separate commit? (i.e. one commit for the vendor-update and one for the other changes). Sorry for being a PITA there :relaxed:

@thaJeztah Ah, I can't.... This changes the return parameters of the function in HCSShim, so both need to go in at the same time. Sorry.

@jhowardmsft it's okay to have them in the same PR, just in a separate commit

Right, sure, I can do that. (Just don't believe I've ever seen that before on the docker project).

Vendor updates are normally split in to the vendor itself, and the code changes related to the vendor update, just picking a random one; https://github.com/docker/docker/pull/17056/commits

No prob. Will do this in the morning :) You should be asleep though!

@jhowardmsft actually in SF for two weeks, almost over, I'll be heading home Saturday

@thaJeztah Split :)

:scissors: :scissors: <3 thanks @jhowardmsft

LGTM

LGTM

\o/


⚠ Samsung has degraded performance

In 4978894, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2035 ms

Resolved: Samsung performance has improved in cf1980c.


factor: Refactor the factoring logic

[x] Separate the data structure and factoring logic (uu_factor::factor) from the CLI code and I/O.
Improves maintainability and readability.
[x] Avoid moving data around (~10% runtime improvements, reduction in memory usage)
[ ] Refactor things so factoring algorithms return a factor (or None) to factor.
This refactoring will enable implementing multiple factoring methods (and dynamically selecting the best one based on smoothness etc.)

@Arcterus (or any other maintainer) : this fails to build because of the uucore_procs::main! invocation, and I have no idea where that macro is documented; could you suggest a fix so I can make further progress on this?

That’s in the uucore repo at the moment.  I think the path is something like src/uucore_procs/src/lib.rs or something like that.  If you can wait until tomorrow (or I guess later today at this point...), I can suggest a fix.

If you can wait until tomorrow (or I guess later today at this point...), I can suggest a fix.

Yes, don't stress out about it  :)
It's not as if I didn't have another draft PR to work on, or a bunch of other local branches  :sweat_smile:

I think this is ready for review as-is.
I did not (yet) move the factoring functionality to its own crate, as I realised it's not obvious where to put it, how to integrate with the release process for coreutils, etc...

Found a couple minor improvements, should now be clean on Clippy.
I'm not doing the last change I mentioned (making find_factor return an Option<u64> instead of looping until success) quite yet, as it doesn't make sense without also implementing another factor-finding algorithm (which is entirely out-of-scope for this PR)

I just rebased on master and added further testsuite improvements, shaking a couple more bugs lose (one of which was also caught in #1554).
Regarding performance, the improvement compared to master is pretty negligible (~1% on its own), but when combined with #1554 we get another ~15% improvement (compared to #1554 alone, which is already 2× faster than master)


Add new 'session' table

Problem
Currently we have sessions which is basically same stream object but with parentId set. This sessions objects created by Mist when it starts transcoding.
But recently we introduced concept of user session - which internally consists of number of regular sessions. Currently user session object gets constructed on the fly from regular session objects. This is inefficient and complicates code.
Solution
Create new session table which will track properties of user session.

In the response, please be sure to include the following parameters
lastSeen
isActive
sourceSegments
transcodedSegments
sourceSegmentsDuration
transcodedSegmentsDuration
sourceBytes
transcodedBytes
id
kind
name
record
userId
parentId
playbackId (inherit from the "parent" stream object")
profiles
createdAt
ingestRate
outgoingRate
recordingStatus (do not show if record:false)
recordingUrl (do not show if record:false)

@darkdarkdragon

@wohlner do we really need isActive field on session object? It's kinda hard to manage and what's the purpose? This information is available on stream object.

I'm ok leaving it out. For streams without recording on, isActive on the parent stream should suffice. For streams with recording turned on, the isActive on the parent stream combined with the recordingStatus on the session should give the user all they need to know.


txn: change IsUnnecessaryKeyValue interface to report error(#390)

ref: 30410
Try to cherry-pick https://github.com/tikv/client-go/pull/390 to release tidb-5.3 branch.
Signed-off-by: cfzjywxk<EMAIL_ADDRESS>

@sticnarf
PTAL for v5.3 pick.

Actually, I hope there will be no more "tidb-*" branches...


Update description of working-directory parameter for v10 and later

This PR resolves issue https://github.com/cypress-io/github-action/issues/688 "Missing working-directory description for v10 and later".
It changes the working-directory example to use app-test instead of e2e and it adds examples for v10 as follows:

Working directory
In a monorepo, the end-to-end or component test might be placed in a different sub-folder from the application itself.
Using a Cypress legacy configuration (Version 9 or earlier) the structure could look like this:
repo/
  app/
  app-test/
    cypress/
      fixtures/
      integration/
      plugins/
      support/
    cypress.json
  package.json

For End-to-End testing using a Cypress configuration with Cypress Version 10 and later, the structure could look like this :
repo/
  app/
  app-test/
    cypress/
      e2e/
      fixtures/
      support/
    cypress.config.js
  package.json

Similarly for Component Testing with a Cypress configuration for Version 10 and later, the structure could look like this:
repo/
  app/
  app-test/
    cypress/
      component/
      fixtures/
      support/
    cypress.config.js
  package.json

You can specify the app-test working directory when running Cypress tests using the working-directory parameter
on: [push]
jobs:
  cypress-run:
    runs-on: ubuntu-20.04
    steps:
      - uses: actions/checkout@v3
      - uses: cypress-io/github-action@v5
        with:
          start: npm start
          working-directory: app-test

See cypress-gh-action-monorepo for a running example.

Also viewable for review on https://github.com/MikeMcC399/github-action/blob/docs/working-directory/README.md#working-directory.

This PR needs https://github.com/cypress-io/github-action/pull/690 merging, otherwise CI  fails. See<PHONE_NUMBER>.
Leaving in draft state until the above is done.


Clarify querability, greater separation between types and representations

This is intended to address #109.
However, with the recent discussions in #138, #141 and elsewhere, it has snowballed a bit to include numerous fixes to our term definitions and usage of types throughout. To make things internally consistent with our term definitions about unknown/nulls, I also had to quite heavily re-edit the language in that section.
I welcome discussions about this, and I am very much prepared to edit and re-edit this into a shape where we find an agreement. But I strongly believe that what is here is at least much better than the state before this PR.

@merkys suggestions addressed (possibly pending the discussion on the requirement on Entry name).
For the record, I really think we also need to sort out #144 before we can release (that text really is in error right now.) But it may be easier to merge this one before rewriting that one.

Concerning your comment in the recently merged PR #137, I can do the merge if you wish? I simply need writing access to your fork (can be set in settings I believe). Furthermore, I can add a commit to update it according to the philosophy of said PR? :)

Ok, fixes for everything commented on + a merge with upstream are in place. Except for a few open discussions still ongoing above.

@merkys comment addressed. Also:

Clarified what it meant that properties had a "fixed type".
I realized also entry type names must adhere to the same rules as property names, since they are used in the filter language when filtering on relationships. To not repeat the same thing twice, I made a term definition of Identifier, which I think is actually a positive thing for places where we use identifier in the text when not clearly referring to the filter language tokens.

* I realized also entry type names must adhere to the same rules as property names, since they are used in the filter language when filtering on relationships. To not repeat the same thing twice, I made a term definition of **Identifier**, which I think is actually a positive thing for places where we use identifier in the text when not clearly referring to the filter language tokens.

Good catch! I like the identifier term.

Sorry about the rapid "request review" and further changes being pushed. @merkys comments made me realize two quite important issues:

Merging upstream changes from #137 was relatively painless, but I missed a few formulation changes around IDs, which I now revert back to what was accepted in #137. These edits actually better resolves the review comment of @merkys than the edits I pushed first.
If we are defining Identifier to be a lowercase name, we probably shouldn't say that IDs and immutable ids are identifiers.

Fixes deployed.
Note: @CasperWA your example was added to local_id, but not immutable_id. Now I have put it in both places. (For some reason I cannot reply to that one comment)

Note: @CasperWA your example was added to local_id, but not immutable_id. Now I have put it in both places. (For some reason I cannot reply to that one comment)

That's fine. It was only meant for immutable_id, but it doesn't matter either way. Already approved :+1:

Travis is having a bit of hard time these days, but whenever it is done, I will merge it :+1:

Thanks @rartino !

:man_dancing:
Big thanks to @merkys and @CasperWA for whipping this huge PR into shape! Only two more to go for v0.10!

Great job! Thanks @rartino and @CasperWA! :)


Rate limit the /new/ endpoint

Addressing a piece of #19287. This only covers one endpoint, but the others can be done with a similar approach, so it seems to make sense to decide on whether the approach is fine and then do the other endpoints.
Also the conversation in https://github.com/zulip/zulip/pull/16190#discussion_r670707718 is relevant here - @alexmv With this approach we would start using domain rather than removing it, does that seem right? Alternatively, we could still get rid of domain and instead define separate RateLimitedSomething classes per endpoint - but that seems worse and the domain concept was probably made with this kind of scenario in mind

Addressing a piece of #19287. This only covers one endpoint, but the others can be done with a similar approach, so it seems to make sense to decide on whether the approach is fine and then do the other endpoints.

Looks good!

Also the conversation in #16190 (comment) is relevant here - @alexmv With this approach we would start using domain rather than removing it, does that seem right? Alternatively, we could still get rid of domain and instead define separate RateLimitedSomething classes per endpoint - but that seems worse and the domain concept was probably made with this kind of scenario in mind

I'm glad we'll be getting some use out of it. :)  Overall, I still think that the allowlist by domain is confusing overkill, and I'd love if we didn't use the term "domain" for it -- but those aren't strong enough objections to merit holding back this PR.
This is (I think) the first human-facing use of this codepath; everything else has been for APIs, which is why the RateLimited exception that this ends up throwing descends from JsonableError.  I expect (though I've not tested) that this means that if you create too many realms, you get shown a JSON blob as the result page -- can we catch the exception somewhere and return something more akin to the 502 page, but making clear that it's the user's fault?  We do have the possibility for false-positives (due to proxies and such) and having some thing friendlier than a JSON blob would be nice.

Merged, thanks @mateuszmandera!  I agree with @alexmv on all points above.


master/linux/grpc_portability failing due to error from build_python.sh

All errors seem to point to:
VENV_PYTHON=/var/local/git/grpc/py27_native/bin/python2.7
curl https://bootstrap.pypa.io/get-pip.py
/var/local/git/grpc/py27_native/bin/python2.7
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 1883k 100 1883k 0 0 6848k 0 --:--:-- --:--:-- --:--:-- 6848k
Traceback (most recent call last):
File "", line 24226, in
File "", line 199, in main
File "", line 82, in bootstrap
File "/tmp/tmpOBM481/pip.zip/pip/_internal/cli/main.py", line 60
sys.stderr.write(f"ERROR: {exc}")
^
SyntaxError: invalid syntax
According to https://stackoverflow.com/questions/65866417/pip-install-failing-on-python2, it seems that get-pip.py has moved.

Is there any way to bypass this? The check "Portability Tests Linux [Build Only] (internal CI)" is failing due to this, and it's required. So this is blocking the PRs.
Maybe this should be p1 not p2?

Is there any way to bypass this? The check "Portability Tests Linux [Build Only] (internal CI)" is failing due to this, and it's required. So this is blocking the PRs.
Maybe this should be p1 not p2?

This was fixed by #25277 and #25260. I will cherry pick the fix into my backport PRs.

This was fixed by #25277 and #25260. I will cherry pick the fix into my backport PRs.


Allow contextual plugins to persist temporarily

Fixes #72271
This makes the theme editor semi-persistent. If you edit a theme from the FileSystem Dock or directly in the inspector (via Edit), the editor will not be closed when something else takes over its editing context. A close button was added to close the editor manually.
The editor can still close automatically if its editing context vanishes (EditorProperty).
https://github.com/godotengine/godot/assets/2223172/7c23c1c8-be56-4085-83f3-b60316eab9d4

The bug is fixed.

But the case of editing a theme attached to a control is still important, I believe, and this trick doesn't cover that case.

The Theme Editor is closed, because the EditorProperty that was editing the theme is gone. I could make it persist, but then deselecting the node would keep the theme edited.

Done, but I had to do a questionable change. Inspector sets new object before clearing, so that plugins can know it before being cleared.

Going back in history is a font of all sorts of bugs 🙁 Closing the theme normally seems to work fine. But once you close it under the conditions demonstrated in the clip, you can no longer open the theme edit:
https://github.com/godotengine/godot/assets/11782833/02f4b251-d7b1-47d3-9304-7e0a5586874e
Regarding the unnatural thing that you had to do, it's probably fine. But to be absolutely safe you could add get_next_edited_object() or something like that? That's all you need from the hack, to be able to get a reference through the inspector dock to the upcoming edited object.

@KoBeWi Any news on fixing the bug (and maybe doing the pre-edit step in a less nasty manner)?

I will finish this one day.

I'll put it into draft for now, feel free to undraft once it's ready

Ok I fixed the history bug. I just forgot to unref Theme when closing the editor.
Also added get_next_edited_object() like you suggested.

As described on RC, there is currently an issue because behavior is different between the main inspector and sub inspectors. For subinspectors get_next_edited_object() doesn't work, because it gets cleared before we get to the theme editor, so it has nothing to work with. For subinspectors using the old get_edited_object() method is sufficient. But it works the other way around for the main inspector.
The solution can be as simple as moving the clearing step to the last possible moment:
diff --git a/editor/editor_inspector.cpp b/editor/editor_inspector.cpp
index 5985bdf525..233fcd10ce 100644
--- a/editor/editor_inspector.cpp
+++ b/editor/editor_inspector.cpp
@@ -3408,7 +3408,6 @@ void EditorInspector::edit(Object *p_object) {
 	per_array_page.clear();

 	object = p_object;
-	next_object = nullptr;

 	if (object) {
 		update_scroll_request = 0; //reset
@@ -3418,6 +3417,10 @@ void EditorInspector::edit(Object *p_object) {
 		object->connect("property_list_changed", callable_mp(this, &EditorInspector::_changed_callback));
 		update_tree();
 	}
+
+	// Keep it available until the end so it works with both main and sub inspectors.
+	next_object = nullptr;
+
 	emit_signal(SNAME("edited_object_changed"));
 }

However, you can still manage to permanently disable the theme editor with this PR. Open a theme resource, then edit its subresource. Use the inspector history to navigate back to the theme and close the editor. You will no longer be able to open it by any means.
https://github.com/godotengine/godot/assets/11782833/4a12faad-8f8f-4392-a2ba-ab7947f67daa
This does NOT happen if you open a control that has a theme as a subresource. Doing similar steps still restores the theme editor.

Fixed. Theme editor was clearing the inspector to remove itself, but the code for hiding editors did not handle self-owning plugins.

Thanks!


[PF2E] Speed and Perception aren't correctly displayed for NPCs

Foundry 0.7.8
Pathfinder 2nd Edition <IP_ADDRESS>5
Token Info Icons 2.1.2
PCs work fine, but speed and perception of NPCs won't work for me (as seen in the picture). For rolling initiative in combat tracker, the right values are used.

Passive Perception also does not calculate correctly if character has Observer feat clicked in Special traits (adds +5 to passive perception and passive investigation) OR if these are added manually as active effects


Allow spread members having varying length lists with var

Description:
$subject. As per https://github.com/ballerina-platform/ballerina-spec/issues/52#issuecomment-1120569771.

Fixed in #36248


[master] Fix showing failure message on diagnostics in IDL client gen command executor

Purpose
Fix for 2201.3.0-stage - https://github.com/ballerina-platform/ballerina-lang/pull/38470
Fixes #38451
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[ ] Added necessary tests

[ ] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

Closing as IDL feature is deprioritized atm

Closing this since the IDL feature won't be introduced soon


Remove txBytes parameter from deposit function

With RLPEncode library, we can make plasma transaction in RootChain contract removing txBytes parameter at deposit().

cost type
total gas used

transaction cost
51224 gas

execution cost
29952 gas

We're currently thinking about creating a different type of deposit transaction to avoid having to do this encoding on chain and reduce the gas cost in general. The deposit root would be calculated somewhat like this:
    /**
     * @dev Calculates the block root for a deposit transaction
     * @param depositor Address of the depositor
     * @param amount Amount deposited
     * @return The root to be used for the deposit block
     */
    function calculateDepositRoot(address depositor, uint256 amount)
        private
        view
        returns (bytes32)
    {
        bytes32 root = keccak256(depositor, amount);
        for (uint256 i = 0; i < 16; i++) {
            root = keccak256(root, zeroHashes[i]);
        }

        return root;
    }

Closing in favor of #72 which modified deposits so that deposit blocks are represented as keccak256(msg.sender, msg.value).


[WEB-996] Support Next.js TypeScript config validation

From SyncLinear.com | WEB-996

This is no longer relevant.


Update Modals.less

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Closes currently open issue (replace XXXX with an issue no): Closes #13764

Description

Changed the z-index value of .modal-backdrop to 1030.  This changes the backdrop overlay to cover everything, except for the modal.  Previously, input fields and the navbar were not covered by the backdrop.

@SlyTy7 Tested locally and LGTM. Thanks for making this change @SlyTy7 and thanks for contributing to freeCodeCamp! 🌮 🎉 👍

@dhcodes no problem!