Fixes for vhacd module

Fixed misplaced namespace VHACD in btConvexHullComputer.cpp. It was placed in #ifdef __GNUC__ which would break Windows builds.
1 alone didn't fix the build, thus used C++11 for vhacd because VHACD-ASYNC.cpp is using some C++11 features

Why do you want to move the typedefs outside the namespace? These should be just for the third party code. Godot has its own ints.

@toasteater  it was placed inside in #ifdef __GNUC__, which would break windows build.

@WindyDarian I see. It can make your intention clearer if you explain your changes in a bit more detail in the issue description.

@toasteater Will do. Thank you!

Thanks!


update monitoring spec machine

update monitoring spec machine

Coverage increased (+0.004%) to 63.912% when pulling 9bfdc0225dec642ef6488f5374f0f4d55151aa79 on adityahenanda:dev into 6d72fdb5261d5a42cdb3556a6cb17e445e836ef6 on danliris:dev.


Suggestion/implementation

Health and weapon esp please

Up for health and armor it would be great.

BTW only corners ESP it would be great also <3


Needs Updating for Version 10 Functionality

(This is probably not needed, so feel free to delete/remove if you are already aware)
Does not function in version 10.  When attempting to open an image the following error generates:
"Cannot set properties of undefined (setting '_copy')

Hmm, I was pretty sure this was now working with V10. Can you let me know your system, and more details about when this happens?

I disabled a couple of other modules and its working now. Dungeon Draw seems to be the culprit for breaking several things - and its not v10 compatible yet. So no worries. Thanks for taking the time to respond!


redirect wrong url after exception

After I installed dingo, \App\Exceptions\Handler can't work. But I need to do some redirect while some exceptions throw like below.
app('Dingo\Api\Exception\Handler')->register(function (CustomException $exception) {
            $url = '';
            return redirect($url);
        });

But I the redirect have to redirect to a blank page with redirect infomation first, then redirect to where I want.
So, anybody know how to keep the normal redirect functions? I just want to redirect the url directly.
Thanks!

@mani95lisa I'm not sure I follow, are you saying the redirect isn't working at all, or that its redirecting to a blank page, which then redirects correctly. Do you have a full example I could look at, if you're still having this issue?


Terminal: Kill All Terminals command kills remote SSH session on Windows

Type: Bug
On Windows, with the latest versions of VSCode and the Remote - SSH extensions, running the Terminal: Kill All Terminals command from the command palette now makes the remote connection die and reconnect. This does not happen on a Linux (specifically Ubuntu) installation of the same versions of VSCode and the remote extension. Moreover, this did not use to happen on Windows either a few weeks ago runninng older versions of VSCode and/or the remote extension.
This is a problem because frequently one would like to kill all idle running terminals while working remotely; now this is impossible on Windows as it messes with the remote connection itself.
VS Code version: Code 1.89.0 (b58957e67ee1e712cebf466b995adf4c5307b2bd, 2024-05-01T02:09:22.859Z)
OS version: Windows_NT x64 10.0.19042
Modes:
Remote OS version: Linux x64 5.15.0-105-generic

System Info

Item
Value

CPUs
Intel(R) Xeon(R) Gold 6242R CPU @ 3.10GHz (4 x 3093)

GPU Status
2d_canvas: unavailable_softwarecanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: disabled_softwaremultiple_raster_threads: enabled_onopengl: disabled_offrasterization: disabled_softwareraw_draw: disabled_off_okskia_graphite: disabled_offvideo_decode: disabled_softwarevideo_encode: disabled_softwarevulkan: disabled_offwebgl: unavailable_softwarewebgl2: unavailable_softwarewebgpu: unavailable_software

Load (avg)
undefined

Memory (System)
32.00GB (14.01GB free)

Process Argv
--crash-reporter-id 9e773f15-1d9a-4f02-85bc-7289c49113ba

Screen Reader
no

VM
100%

Item
Value

Remote
SSH: remote-hostname

OS
Linux x64 5.15.0-105-generic

CPUs
Intel(R) Core(TM) i9-7940X CPU @ 3.10GHz (28 x 1200)

Memory (System)
62.50GB (54.90GB free)

VM
0%

Extensions (22)

Extension
Author (truncated)
Version

vsc-python-indent
Kev
1.18.0

jupyter-keymap
ms-
1.1.2

remote-ssh
ms-
0.110.1

remote-ssh-edit
ms-
0.86.0

remote-explorer
ms-
0.4.3

vim
vsc
1.27.2

ruff
cha
2024.20.0

gitlens
eam
14.9.1

latex-workshop
Jam
9.20.1

vsc-python-indent
Kev
1.18.0

black-formatter
ms-
2024.2.0

debugpy
ms-
2024.6.0

isort
ms-
2023.10.1

python
ms-
2024.6.0

vscode-pylance
ms-
2024.5.1

jupyter
ms-
2024.4.0

jupyter-keymap
ms-
1.1.2

jupyter-renderers
ms-
1.0.17

vscode-jupyter-cell-tags
ms-
0.1.9

vscode-jupyter-slideshow
ms-
0.1.6

autodocstring
njp
0.6.1

even-better-toml
tam
0.19.2

A/B Experiments
vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscoreces:30445986
vscod805:30301674
binariesv615:30325510
vsaa593:30376534
py29gd2263:31024239
vscaat:30438848
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
h48ei257:31000450
pythontbext0:30879054
accentitlementsc:30995553
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
chatpanelc:31018788
dsvsc021:30996838
724cj586:31013169
a69g1124:31038041
dwnewjupytercf:31039676

I recommend setting "remote.SSH.useLocalServer": true. Note that you need to set this directly in your settings.json file even when it appears checked in the settings editor.
This will switch to a mode where a hidden terminal isn't used to manage the connection and is the default on other platforms, but not windows.

Ah yes, that seems to have fixed the issue, many thanks!. So does that mean that the default value of that setting has been recently changed on Windows? And, to maybe understand better, what would be the (dis)advantage of setting that to False?

It is just disabled by default on Windows because some older version of Windows OpenSSH had some bugs. At this point, most users will have moved off those versions of ssh, so I hope to switch the default to match other platforms.


Obligation date calculation

Are IRIS to calculate the Obligatory deadlines for our Customers based on a rudimentary accounting period plus 90 days?
Initial response from SDS was:
"No, HMRC will determine and provide obligation dates based on accounting period"
My new response is:
"When? I need to be coding in earnest last week to meet our deadlines.  How can we design our flows based upon the promise of something we’ve never seen?  We were told about the Obligations last year but there isn’t even a design or an API available for us to code or design against."

I believe this is the same issue as https://github.com/hmrc/self-assessment-api/issues/296.


test: don't use static buffer for formatting

Don't use a static buffer to hold human-readable "big" numbers.
The buffer isn't big enough for benchmarks like fs_stat that print a large number of them. Have the caller pass in a buffer instead.

It's only for decimal numbers. 1031 is about 2102 - stupefyingly big.


Possible to add a "field_names" helper function?

In a specific use case, I need to get all field names that are defined in an attrs class, which is as simple as
[f.name for f in attr.fields(MyClass)]

Do you think it's OK to add a public API for this?

Hm, I was rather thinking about exposing fields as a dict, because I needed string access to attributes.
That would give us:

attr.fields_dict(MyClass)[name] for me
and attr.fields_dict(MyClass).keys() for you

That's sounds good to me.


Create test.md

:x:

:warning:

Fact Checking

Statement: Kronos Research, a Taiwan-based quantitative trading firm, has indefinitely halted trading services after a hacker stole $25 million in crypto assets using compromised API keys. :white_check_mark:

Source: https://cryptonews.com/news/hacker-steals-25-million-from-kronos-research-through-compromised-api-keys.htm

Statement: The unauthorized entity made six transactions totaling 12,800 ETH to various wallet addresses. :white_check_mark:

Source: https://cryptonews.com/news/hacker-steals-25-million-from-kronos-research-through-compromised-api-keys.htm

Statement: Despite the substantial loss, Kronos Research is in good standing and plans to cover all losses internally. :white_check_mark:

Source: https://cryptopotato.com/kronos-research-reports-25-million-loss-in-security-breach/

Statement: The firm is actively conducting internal investigations to identify the perpetrator. :white_check_mark:

Source: https://cryptonews.com/news/hacker-steals-25-million-from-kronos-research-through-compromised-api-keys.htm

Statement: Additionally, Kronos Research is engaging with the hacker directly through an Ethereum translation message offering a 10% white hat bounty. :white_check_mark:

Source: https://www.coindesk.com/markets/2023/11/28/crypto-trading-firm-kronos-research-offers-10-bounty-to-hacker/

Statement: Kronos Research lost around 13,007 ETH, valued at $25 million at the time. :white_check_mark:

Source: https://cryptopotato.com/kronos-research-reports-25-million-loss-in-security-breach/

Editor's Notes

In the Summary section, reword the sentence "Despite the substantial loss, Kronos Research is in good standing and plans to cover all losses internally." to "Despite incurring substantial losses, Kronos Research remains financially stable and intends to absorb the losses internally." This improves clarity.

In the Timeline section, change "X (formally known as Twitter)" to just "Twitter". The explanation in parentheses is redundant.

Standardize the formatting of dates and times in the Timeline section. Use "November 18, 2023 at 19:00 UTC" format for all entries.

In the Security Failure Causes section, change the bullet "Unauthorized Access through API Key Compromise:" to a sentence: "The attackers gained unauthorized access by compromising Kronos Research's API keys."

Overall the content is well-structured and written. Just minor tweaks needed as suggested above.

Hugo SSG Formatting Check

Does it match Hugo SSG formatting? :white_check_mark:

Filename Check

Correct Filename: 2023-11-20-kronos-research.md
Your Filename: 2023-11-20-kronos-research.md :white_check_mark:

Section Headers Check

Allowed Headers: ## Summary, ## Attackers, ## Losses, ## Timeline, ## Security Failure Causes
Your Headers: ## Summary, ## Attackers, ## Losses, ## Timeline, ## Security Failure Causes :white_check_mark:

Metadata Headers Check

Allowed Metadata Headers: date, target-entities, entity-types, attack-types, title, loss
Your Metadata Headers: date, target-entities, entity-types, attack-types, title, loss :white_check_mark:

Fact Checking Results

Statement: The unauthorized entity made six transactions totaling 12,800 ETH to various wallet addresses. :white_check_mark:

Source: https://cryptonews.com/news/hacker-steals-25-million-from-kronos-research-through-compromised-api-keys.htm

Statement: Despite the substantial loss, Kronos Research is in good standing and plans to cover all losses internally. :white_check_mark:

Source: https://beincrypto.com/kronos-crypto-hack-suspends-trading/

Statement: The firm is actively conducting internal investigations to identify the perpetrator. :white_check_mark:

Source: https://cryptonews.com/news/hacker-steals-25-million-from-kronos-research-through-compromised-api-keys.htm

Statement: Additionally, Kronos Research is engaging with the hacker directly through an Ethereum translation message offering a 10% white hat bounty. :white_check_mark:

Source: https://www.coindesk.com/markets/2023/11/28/crypto-trading-firm-kronos-research-offers-10-bounty-to-hacker

Statement: Kronos Research lost around 13,007 ETH, valued at $25 million at the time. :white_check_mark:

Source: https://www.fxstreet.com/cryptocurrencies/news/breaking-kronos-research-loses-25-million-in-a-hack-202311191330

Statement: November 18, 2023, 23:05 UTC: Kronos Research published a post on X (formally known as Twitter) that around 19:00 UTC they had been hacked and had halted all trading while they conduct their investigation. :warning:

Source: None

Statement: November 18, 2023, 23:11 UTC: Blockchain researcher ZachXBT identified the Ether outflow connected to wallet 0x2b0502FDab4e221dcD492c058255D2073d50A3ae via an X (formally known as Twitter) post including the transfer timeline :warning:

Source: None

Editor's Notes
Overall, the text is well-written and provides a good summary of the Kronos Research hack incident. Here are some suggested improvements:

Standardize date formats to be consistent. Currently there is a mix of "November 18, 2023" and "November, 19, 2023". Suggest using "November 18, 2023" format throughout.

Some sentences are quite long and could be broken up to improve readability, e.g. the sentence starting "The attackers were able to gain access..."

In the Timeline section, the sub-headers with dates and times should be bold for consistency, e.g. "November 18, 2023, 23:05 UTC:"

Consider adding references/links to the specific tweets and transactions where possible to support the details in the Timeline section.

The Security Failure Causes section has some repetitive wording around "unauthorized access". Suggest rephrasing some items to avoid repetition.

Standardize capitalization of headers like "Security failure causes" vs "Security Failure Causes"

Fix typo "sucessful" -> "successful"

No major factual errors were identified.
Hugo SSG Formatting Check

Does it match Hugo SSG formatting? :white_check_mark:

Filename Check

Correct Filename: 2023-11-20-kronos-research.md
Your Filename: test.md :x:

Section Headers Check

Allowed Headers: ## Summary, ## Attackers, ## Losses, ## Timeline, ## Security Failure Causes
Your Headers: Same headers as allowed :white_check_mark:

Metadata Headers Check

Allowed Metadata Headers: date, target-entities, entity-types, attack-types, title, loss
Your Metadata Headers: date, target-entities, entity-types, attack-types, title, loss :white_check_mark:


[unittest-cpp] fix config.cmake file

Describe the pull request

What does your PR fix? Fixes #17080
UTPP_INCLUDE_DIRS is set to .../vcpkg/installed/include and does not include the triplet, modified the UnitTest++Config.cmake file  in a way that seems to fix this

Note: no feature need to test

did you test usage?

It has been tested and can be used successfully


Questions About GPU Memory Usage with Four 3090s on SAMed_h Version

We trained SAMed_h on one A100, whose memory should be equal to four 3090s GPUs. What's the exact problem in your case? Our of memory?


Manipulate arrays with unshift

Challenge http://www.freecodecamp.com/challenges/waypoint-manipulate-arrays-with-unshift has an issue.
Just a little detail that may lead to confusion: in the description of the Waypoint it's written "to the end", when the unshift function adds the new value to the beginning of the array:
"Let's take the code we had last time and unshift this value to the 'END': "Paul"". (I've written it in uppercase so you can see it better).
That's all. Thanks for the work you're doing! ;)

This appears to be fixed in  ae6746f


Group comparison values

Currently if you want to compare one value to multiple other values, you need to either write multiple comparisons then group them together with and/or, or iterate over an array. This is a very common thing to do so optimizing could be worth it. Making it possible to compare a value to multiple other values in a single comparison would mean less code to write and more readable code imo
When comparing a value, you can put multiple values inside brackets [] and would return true if the comparison is true for all values. The second = in the if x == y would use AND, having ~ be the second character in the comparison would use OR
local otherValue = 3

-- Current solution
if (self.SomeValueName == 1 or self.SomeValueName == 2 or self.SomeValueName == otherValue) then

end

-- New solution
if (self.SomeValueName == [1, 2, otherValue]) then -- x == 1 and x == 2 and x == otherValue

end

if (self.SomeValueName ~= [1, 2, otherValue]) then -- x ~= 1 and x ~= 2 and x ~= otherValue

end

if (self.SomeValueName =~ [1, 2, otherValue]) then -- x == 1 or x == 2 or x == otherValue

end

if (self.SomeValueName ~~ [1, 2, otherValue]) then -- x ~= 1 or x ~= 2 or x ~= otherValue

end

if (self.SomeValueName <~ [1, 2, otherValue]) then -- x <= 1 or x <= 2 or x <= otherValue

end

if ([1, 2, otherValue] >= self.SomeValueName) then

end

if ([1, 2, otherValue] >= [3, 5, 6]) then

end

I, uhh, don't think we should do this. A lot of these operators are not intuitively obvious and the feature overall seems very unique for a relatively narrow optimization (maybe some array languages do this?). The closest mainstream feature I can think of is Python's in but there's other issues with implementing that in Luau (although if we did you could at least do if self.SomeValueName in {1, 2, otherValue}).
We have plans to automatically optimize code in the motivating snippet, although they may or may not pan out due to issues around side effect semantics. But even if we end up unable to implement it, this just feels like a surprising and non-general solution to an issue that only occasionally comes up. For example, this is not too different from an equally common if self.SomeValue and self.SomeValue.Foo and self.SomeValue.Foo.Bar then in terms of the efficiency that is left on the table.
Modern languages typically solve problems like this with pattern matching, which might be interesting to investigate at some point but it requires a dedicated exploration and likely ends up looking quite different from this altogether.


attachListener/rendition2.js has wrong 'this' value and leaks memory

In an attempt to work around memory leaks in very old versions of IE, attachListener/rendition2.js stores a reference to the element in jessieNamespace.theseObjects for use as 'this' in the listener and then nulls the passed-in element variable. But the listener actually uses the passed-in element variable rather than the stored reference, so 'this' is always null in the callback.
If that is fixed, though, there is still no function in jessie that removes element references from jessieNamespace.theseObjects. That means no DOM elements used with attachListener/rendition2.js will be garbage collected while the page is open. So a test like this leaks memory:
var i, el, fn;
for (i = 0; i < 50000; i++) {
	el = document.createElement("div");
	el.innerHTML = "fill in with 1k of text so you notice the leak in task manager";
	fn = jessie.attachListener(el, 'click', function (event) {});
	jessie.detachListener(el, 'click', fn);
}

The following rendition does not leak with the above test in IE8.
attachListener = function (el, eventType, fn) {
	var listener = function () {
		fn.call(el, window.event);
	}
	el.attachEvent('on' + eventType, listener);
	return listener;
};

It may be worthwhile to offer a rendition for ancient IE that stores the 'this' value outside the closure, so long as there's a way to clean those up when discarding DOM elements.

Storing it in theseObjects does put it outside the closure. That's the point of that. I fixed the obvious typo where it is passing null instead of the stashed element reference.
Your leak test introduces additional variables. It is supposed to be testing attaching listeners, not creating elements or the innerHTML property. Shouldn't be detaching any listeners either. If you attach and then detach, barring any other variables, the net is 0.
You shouldn't have to clean up the listeners at all, that's the point of avoiding the circular reference by storing the element reference outside the closure. It's the same thing My Library does and it was leak-tested to death (with and without the unneeded IE-specific cleanup code) in all of the old IE versions.
So you should write the test without removing any listeners at all. Just refresh the page after each run. If the memory keeps going up (all things equal), then there's a leak.
The reason that last rendition you posted doesn't "leak" is that you are simply removing the listeners as fast as you add them. If you test properly (without detaching listeners at all), you'll find it does leak as it creates the classic circular reference.
http://jibbering.com/faq/notes/closures/#clMem

And thanks for spotting that typo in Rendition #2. :)

Rendition #3 had copied over the same typo. Fixed.

Summary:
Leaked memory cannot be reclaimed without restarting the browser. If you meticulously detach all attached listeners, then you don't need the leak management as found in Rendition #2 and #3. In fact, you could use the rendition posted, creating circular references on attach and breaking them on detach.
Context is always important. If writing a "single page app" and planning to attach and detach listeners repeatedly (usually sign of a bad design), and particularly if attaching to newly created (or cloned) elements each time, it should be clear that, if using #2 or #3 in old IE versions, the length of - theseElements - will increase each time and memory usage will go up until the page is refreshed (at which time the GC will reclaim the memory that appeared to leak).

I agree that the leak demonstrated in my test is not likely to cause actual problems in most well-designed systems. But renditions 2 and 3 are only creating ``theseObjects``` to work around bugs in browser versions that my customers don't use. Looking at the rendition, it irked me to think of introducing a potential resource leak for my IE 8 users in an attempt to accommodate non-existent IE 7 users.
This really points out a great feature of the Jessie approach: rather than simply taking the library code as a black box, I'm prompted to consider which renditions to include and think about the consequences of each. Thanks for that. It would be nice if more of the "why use this rendition?" arguments were available directly in the builder.

"I agree that the leak demonstrated in my test is not likely to cause actual problems in most well-designed systems."
Pseudo leak. Real leaks don't come back, even when navigating (e.g. to a login page) or refreshing.
"But renditions 2 and 3 are only creating theseObjects to work around bugs in browser versions that my customers don't use."
Right. So those shouldn't be your first choice.
"Thanks for that. It would be nice if more of the "why use this rendition?" arguments were available directly in the builder."
You're welcome. Code comments welcome. Each rendition should have a blurb at the top explaining its positives and negatives. Don't recall what the builder does (haven't seen it in years). Started working on my own version of it years ago, but other things have come up since.


Finding intersection node of two linked lists connected in y shape In cpp

🚀 Feature
There are two singly linked lists in a system. The end node of one of the linked list got linked to the second list, forming an inverted Y-shaped list. Write a program to get the point where two linked lists merge in Python
Linked Lists are one of the data structures to which basic to advanced coding interview questions are related. Hence as many as possible algorithms should be learned on linked lists.
Linked lists are a kind of data structure which have numerous applications. Many solutions can be made using linked lists as a data structure. Hence learning as many as possible algorithms related to it helps us resolve many issues in programming.

Would you like to work on this feature?

[x] Yes
[ ] No

@ajay-dhangar pls check'


Add auto-merge bot

@kevinsung is this auto-merge upon reviewers sign-off?

It automerges once a label is added to the PR.

Yeah, reviews are marked for auto-merge by adding a label, and it only works after the PR has been approved and passes CI.

This is done via github now.


feat(tracer): http tags

Adds exception info to the HTTP span tags

Could you please help me to test it?

Could you please help me to test it?

For sure, I'll write some and commit to this same PR.
Thanks for the review and improvements!

小哥 @huangzhhui 谷溪 @Reasno 你们看看这个？大段英文，对我来说难度较大。。。

Obviously @jcchavezs is the export in this field, but I think there is a standard somewhere for opentracing tags? Traces are mean to be distributed across systems and inventing custom tags from framework to framework is not fun.
As far as I am concerned, all my "error" tags are boolean. And yes, I am using elasticsearch as the backend. Converting error to an object will break my tracing system.
p.s. just googled this: https://github.com/opentracing/specification/blob/master/semantic_conventions.md

I think exceptions are better modeled as span logs entries rather than span tags, what do you guys think?

@Reasno Logs or annotations are "meaningful events in the span lifecycle", I feel an error isn't because that usually ends up in breaking the flow, the only use case I see an error can be part of the span lifecycle is if such error does not end the span (e.g. user choose to ignore the error) but in framework we don't have control of that. I would keep it as tag, remove file/line and rename it to exception.


Fixes for RHINENG-2254

Resets SigTable pagination whenever the filters change
Correctly sets selectedSigs when SigTable rows are selected/unselected
Apply secondary orderBy variable of NAME_ASC to table rows to add more determinism to their order

Some of the bugs this PR fixes ...
Fixed this pagination problem by resetting the offset after filter changes:

Fixed the signature names being in a random-ish order when sorting by other columns.
Before fix:

After fix:


Convert to Go modules

Checklist

[x] I've read and followed the Contribution Guidelines
[x] step.yml and README.md is updated with the changes (if needed)

Version
Requires a MAJOR/MINOR/PATCH version update

I'm not sure if converting to modules is a major, minor, or patch change. Please advise.

Context
While working on https://github.com/bitrise-steplib/steps-xcode-build-for-simulator/pull/31, I ran into an issue with the go-xcode dependencies. I tried updating it using dep, but was unsuccessful, so I thought I'd try my hand at converting the repo to use Go modules instead, and then update it.
Changes

Added the .idea directory go the .gitignore.
Converted the repo to use Go modules.

This included deleting the vendor directory, as I think that's not needed.

Updated the go-xcode dependency to point to the v1.0.6 tag.

Updating this dependency was required to work around an issue with parsing the output of the xcodebuild version command (https://github.com/bitrise-io/go-xcode/pull/152).
This also necessitated making a small change to the main.go file, as the SetDisableIndexWhileBuilding method was removed from build.go in (https://github.com/bitrise-io/go-xcode/pull/121).

Also in the Bitrise.yml file please remove dep-update:.
And I don't think we will need Gopkg.toml and Gopkg.lock

Also in the Bitrise.yml file please remove dep-update:.
And I don't think we will need Gopkg.toml and Gopkg.lock

Should be fixed in https://github.com/bitrise-steplib/steps-xcode-build-for-simulator/pull/32/commits/fce02bbd95fb8cfcfffa0d9c28fc9e9b5bde498f 👍

@hisaac looking good!

I should also update the version number. Would you say this would be a minor version bump? Or patch?

@hisaac let do it on the other PR. merging to master is not classed as a deploy


Make unit test simulations downloadable from docs webpage

The simulations are runnable from building the project which is good enough. Adding the VCDs to the docs source directory would unnecessarily bloat the repository.


Fix case sensitivity issue for DPad images

aims to resolve #10
going through the list quickly, it's hard to spot anything else that would cause an issue on this front.

thanks


New Version: GodotEngine.GodotEngine version 2.0

[x] Have you signed the Contributor License Agreement?
[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Packages\GodotEngine.GodotEngine__DefaultSource\Godot_v2.0_stable_win64.exe returned exit code: -1073741819
Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\Godot_v2.0_stable_win64.exe returned exit code: -1073741819
Executable C:\Users\Validator\AppData\Local\Microsoft\WinGet\Packages\GodotEngine.GodotEngine__DefaultSource\Godot_v2.0_stable_win32.exe returned exit code: -1073741819
Executable C:\Users\Validator\AppData\Local\Microsoft\WinGet\Links\Godot_v2.0_stable_win32.exe returned exit code: -1073741819

(Automated response - build 855.)

Godot 2.0 doesn't have Official Documentation anymore, so I've removed these fields in pre-2.1 versions. The other PRs ( for version 2.0.1, 2.0.2, 2.0.3, and <IP_ADDRESS>) will have the same issue as this one, and for the same reason.

Hi @og-mrk,

Godot 2.0 doesn't have Official Documentation anymore, so I've removed these fields in pre-2.1 versions. The other PRs ( for version https://github.com/microsoft/winget-pkgs/pull/141451, https://github.com/microsoft/winget-pkgs/pull/141453, https://github.com/microsoft/winget-pkgs/pull/141455, and https://github.com/microsoft/winget-pkgs/pull/141456) will have the same issue as this one, and for the same reason.

Guessing this is a response to the automated response above mine. Unless you meant that the missing documentation can cause a non-zero exit code?

@wingetbot waivers Add Validation-Executable-Error

Hi @og-mrk,

This PR's version number 2.0 has 2 parameters (sets of numbers between dots - major, minor, etc), which is less than the current manifest's version 4.2.1, which has 3 parameters.

Does this PR's version number exactly match the version reported in the Apps & features Settings page? (Feel free to attach a screenshot.)
(Automated response - build 855)

Hi @og-mrk,

Godot 2.0 doesn't have Official Documentation anymore, so I've removed these fields in pre-2.1 versions. The other PRs ( for version #141451, #141453, #141455, and #141456) will have the same issue as this one, and for the same reason.

Guessing this is a response to the automated response above mine. Unless you meant that the missing documentation can cause a non-zero exit code?

@stephengillie, Yes, it was.

"Guessing this is a response to the automated response above mine."

and no, the Removal of Documentation Field and its Sub-Fields Should Not cause a non-zero exit code, or in other words, it Shouldn't Cause the Installation to Fail.

Hi @og-mrk,

This PR's version number 2.0 has 2 parameters (sets of numbers between dots - major, minor, etc), which is less than the current manifest's version 4.2.1, which has 3 parameters.

Does this PR's version number exactly match the version reported in the Apps & features Settings page? (Feel free to attach a screenshot.)
(Automated response - build 855)

Hello @stephengillie,
This PR's Version number matches the one shown in the Apps & features Settings page, see the screenshot below.


FeathrClient: Output Feature Store UI url for exploring registered features lineage

After feature is registered successfully, feathr client should output a log with message "Features are registered successfully, please go to <FEATURE_STORE_URL> to explore features and track feature lineage.

This has been done in PR #618 , kudos to @enya-yx , closing.


CutMix + Mixup overhaul

Finally a cleaned up impl of CutMix, integrated with Mixup.
A number of mode options... some examples (command line arg combos), to cut & paste into docs at some point

Mixup active w/ alpha 0.2, performed on every batch, lambda sampled for each batch (old behaviour)

--mixup 0.2

Mixup active w/ alpha 0.3, cutmix active with alpha 1.0, lambda sampled for each batch, cutmix used 50% of the time

--mixup 0.3 --cutmix 1.0

Mixup active w/ alpha 0.2, cutmix active with alpha 1.0, cutmix used 30% of the time, a different lambda and cutmix vs mixup decision sampled for each batch element

--mixup 0.2 --cutmix 1.0 --mixup-switch-prob 0.3 --mixup-elem

Mixup active w/ alpha 0.2, cutmix active with minmax ratio set to [0.3, 0.8], cutmix used 30% of the time, some sort of mixing active 70% of the time, a different lambda, cutmix vs mixup, mixing active sampled for each batch element

--mixup 0.2 --cutmix-minmax 0.3 0.8 --mixup-switch-prob 0.3 --mixup-prob 0.7 --mixup-elem

Fix #8

Hi! Do you have in mind to test training with Attentive Cutmix? It seems that this simple technique improves scores by 1%
https://arxiv.org/abs/2003.13048


[Question] How did you build this?

Hi 👋
For educational purpose, I'd like to know if you still had documentation about how git interacts with ssh-keygen to sign commits, unless you reverse-engineered the way git was doing it?
I can't seem to find any documentation about the steps git follows to sign commits with an SSH key, and I am really curious about how you knew what to build 😊

It was mostly reverse engineered by reading the git code itself. You can clearly see from the code what git is passing to the signing process and what it expects back. Reading the ssh-keygen code got me the rest of the way. It took time, but both codebases are opensource, so it's all there for you to see. Does that answer your question?

Yes it does, thank you very much!


Add Ledger Nano support

Integration is possible, might require building with CGO_ENABLED=1, which might make cross-compilation a bit harder, we could have a ledger-enabled build for different platforms.
Refs:

https://github.com/ethanfrey/ledger

which uses https://github.com/ethanfrey/hid/blob/master/hid_darwin.go (CGO stuff for all platforms)

fairy-wallet uses https://github.com/tarassh/fairy-wallet/blob/master/app/actions/ledger.js which points to https://github.com/LedgerHQ/ledgerjs (see docs here: http://ledgerhq.github.io/ledgerjs/docs/ )
other HID implementation: https://github.com/karalabe/hid

+1


New UI Window for Weapons Detection Model Results

[x] Create a UI Window to display the ML model results after running the weapons detection model. A new image with a bounding box is displayed.

The UI window is created using HTML, CSS, JavaScript, and Bootstrap.


Docs: Update links

Update links resulting from shift from grafana repo to plugin-tools repo.

Replaced.


add configuration to disable kafka header

when to use
If your kafka broker version is 0.11+ but the log.message.format.version is overridden by a lower version than 0.11 (e.g. 0.10) which can not be automatically detected.

kafaka-2.4.1 $ ./bin/kafka-server-start.sh config/server.properties --override log.message.format.version=0.10.2

The Kafka Pinpoint headers will cause the messages delivered to the broker(s) can not be saved and get error:

[2021-01-19 13:47:36,188] ERROR [ReplicaManager broker=0] Error processing append operation on partition pinpoint-kafka-plugin-check-dev-0 (kafka.server.ReplicaManager)
java.lang.IllegalArgumentException: Magic v1 does not support record headers
at org.apache.kafka.common.record.MemoryRecordsBuilder.appendWithOffset(MemoryRecordsBuilder.java:410)
at org.apache.kafka.common.record.MemoryRecordsBuilder.appendWithOffset(MemoryRecordsBuilder.java:449)
at org.apache.kafka.common.record.MemoryRecordsBuilder.appendWithOffset(MemoryRecordsBuilder.java:602)
at kafka.log.LogValidator$$anonfun$convertAndAssignOffsetsNonCompressed$1$$anonfun$apply$1.apply(LogValidator.scala:151)
at kafka.log.LogValidator$$anonfun$convertAndAssignOffsetsNonCompressed$1$$anonfun$apply$1.apply(LogValidator.scala:149)
at scala.collection.Iterator$class.foreach(Iterator.scala:891)
at scala.collection.AbstractIterator.foreach(Iterator.scala:1334)
at scala.collection.IterableLike$class.foreach(IterableLike.scala:72)
at scala.collection.AbstractIterable.foreach(Iterable.scala:54)
at kafka.log.LogValidator$$anonfun$convertAndAssignOffsetsNonCompressed$1.apply(LogValidator.scala:149)

Detailed explanation: https://stuckintheloop.com/posts/a_kafka_magic_error/
how to use
Set the config profiler.kafka.header.enable=false, default to true. It will treat the kafka as a terminal service type.

@koo-taejin It's Kafka-related. Please take a look.

@koo-taejin It's Kafka-related. Please take a look.

@yjqg6666
I appreciate your effort for this PR. I am going to check it.
:)

@yjqg6666
I appreciate your effort for this PR. I am going to check it.
:)

kafaka-2.4.1 $ ./bin/kafka-server-start.sh config/server.properties --override log.message.format.version=0.10.2
kafaka-2.4.1 $ ./bin/kafka-server-start.sh config/server.properties
Running in both cases. kafaka-2.4.1 $ ./bin/kafka-broker-api-versions.sh --bootstrap-server localhost:9092  will have the same result.

kafaka-2.4.1 $ ./bin/kafka-server-start.sh config/server.properties --override log.message.format.version=0.10.2
kafaka-2.4.1 $ ./bin/kafka-server-start.sh config/server.properties
Running in both cases. kafaka-2.4.1 $ ./bin/kafka-broker-api-versions.sh --bootstrap-server localhost:9092  will have the same result.

@yjqg6666
Please check test that is failed in Travis-ci.
It seems that it is going to be fine, if you add MockConfig for traceContext object.
[ERROR] Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 0.144 s <<< FAILURE! - in com.navercorp.pinpoint.plugin.kafka.interceptor.ProducerAddHeaderInterceptorTest
[ERROR] beforeWhenUnsampled(com.navercorp.pinpoint.plugin.kafka.interceptor.ProducerAddHeaderInterceptorTest)  Time elapsed: 0.003 s  <<< ERROR!
java.lang.NullPointerException
	at com.navercorp.pinpoint.plugin.kafka.interceptor.ProducerAddHeaderInterceptorTest.beforeWhenUnsampled(ProducerAddHeaderInterceptorTest.java:102)
[ERROR] beforeWhenSampled(com.navercorp.pinpoint.plugin.kafka.interceptor.ProducerAddHeaderInterceptorTest)  Time elapsed: 0 s  <<< ERROR!
java.lang.NullPointerException
	at com.navercorp.pinpoint.plugin.kafka.interceptor.ProducerAddHeaderInterceptorTest.beforeWhenSampled(ProducerAddHeaderInterceptorTest.java:83)
[ERROR] beforeWhenV1(com.navercorp.pinpoint.plugin.kafka.interceptor.ProducerAddHeaderInterceptorTest)  Time elapsed: 0 s  <<< ERROR!
java.lang.NullPointerException
	at com.navercorp.pinpoint.plugin.kafka.interceptor.ProducerAddHeaderInterceptorTest.beforeWhenV1(ProducerAddHeaderInterceptorTest.java:119)

@yjqg6666
Please check test that is failed in Travis-ci.
It seems that it is going to be fine, if you add MockConfig for traceContext object.
[ERROR] Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 0.144 s <<< FAILURE! - in com.navercorp.pinpoint.plugin.kafka.interceptor.ProducerAddHeaderInterceptorTest
[ERROR] beforeWhenUnsampled(com.navercorp.pinpoint.plugin.kafka.interceptor.ProducerAddHeaderInterceptorTest)  Time elapsed: 0.003 s  <<< ERROR!
java.lang.NullPointerException
	at com.navercorp.pinpoint.plugin.kafka.interceptor.ProducerAddHeaderInterceptorTest.beforeWhenUnsampled(ProducerAddHeaderInterceptorTest.java:102)
[ERROR] beforeWhenSampled(com.navercorp.pinpoint.plugin.kafka.interceptor.ProducerAddHeaderInterceptorTest)  Time elapsed: 0 s  <<< ERROR!
java.lang.NullPointerException
	at com.navercorp.pinpoint.plugin.kafka.interceptor.ProducerAddHeaderInterceptorTest.beforeWhenSampled(ProducerAddHeaderInterceptorTest.java:83)
[ERROR] beforeWhenV1(com.navercorp.pinpoint.plugin.kafka.interceptor.ProducerAddHeaderInterceptorTest)  Time elapsed: 0 s  <<< ERROR!
java.lang.NullPointerException
	at com.navercorp.pinpoint.plugin.kafka.interceptor.ProducerAddHeaderInterceptorTest.beforeWhenV1(ProducerAddHeaderInterceptorTest.java:119)

@koo-taejin Updated & PTAL.

@koo-taejin Updated & PTAL.

@yjqg6666
If you do squash merge about all commit you posted, then I am going to merge it.
Thanks :)

@yjqg6666
If you do squash merge about all commit you posted, then I am going to merge it.
Thanks :)

@koo-taejin Squashed and rebased on the current master.

@koo-taejin Squashed and rebased on the current master.

Codecov Report

Merging #7560 (13caae2) into master (c5d96d6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7560      +/-   ##
==========================================
- Coverage   38.85%   38.84%   -0.01%
==========================================
  Files        3486     3486
  Lines       99863    99866       +3
  Branches    12269    12270       +1
==========================================
- Hits        38797    38789       -8
- Misses      58063    58073      +10
- Partials     3003     3004       +1

Impacted Files
Coverage Δ

...m/navercorp/pinpoint/plugin/kafka/KafkaConfig.java
73.33% <ø> (ø)

...afka/interceptor/ProducerAddHeaderInterceptor.java
64.44% <100.00%> (+2.53%)
:arrow_up:

...p/pinpoint/rpc/client/WriteFailFutureListener.java
50.00% <0.00%> (-18.75%)
:arrow_down:

...vercorp/pinpoint/rpc/packet/ClientClosePacket.java
55.55% <0.00%> (-11.12%)
:arrow_down:

...pc/server/LoggingServerMessageListenerFactory.java
90.00% <0.00%> (-10.00%)
:arrow_down:

...orp/pinpoint/profiler/sender/NioUDPDataSender.java
72.00% <0.00%> (-4.00%)
:arrow_down:

...tor/metric/datasource/DefaultDataSourceMetric.java
75.00% <0.00%> (-3.13%)
:arrow_down:

...vercorp/pinpoint/web/vo/ApplicationAgentsList.java
66.66% <0.00%> (-2.57%)
:arrow_down:

...cluster/zookeeper/ZookeeperClusterDataManager.java
52.90% <0.00%> (-1.94%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
78.39% <0.00%> (-1.05%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5d96d6...71a7af1. Read the comment docs.

Codecov Report

Merging #7560 (13caae2) into master (c5d96d6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7560      +/-   ##
==========================================
- Coverage   38.85%   38.84%   -0.01%
==========================================
  Files        3486     3486
  Lines       99863    99866       +3
  Branches    12269    12270       +1
==========================================
- Hits        38797    38789       -8
- Misses      58063    58073      +10
- Partials     3003     3004       +1

Impacted Files
Coverage Δ

...m/navercorp/pinpoint/plugin/kafka/KafkaConfig.java
73.33% <ø> (ø)

...afka/interceptor/ProducerAddHeaderInterceptor.java
64.44% <100.00%> (+2.53%)
:arrow_up:

...p/pinpoint/rpc/client/WriteFailFutureListener.java
50.00% <0.00%> (-18.75%)
:arrow_down:

...vercorp/pinpoint/rpc/packet/ClientClosePacket.java
55.55% <0.00%> (-11.12%)
:arrow_down:

...pc/server/LoggingServerMessageListenerFactory.java
90.00% <0.00%> (-10.00%)
:arrow_down:

...orp/pinpoint/profiler/sender/NioUDPDataSender.java
72.00% <0.00%> (-4.00%)
:arrow_down:

...tor/metric/datasource/DefaultDataSourceMetric.java
75.00% <0.00%> (-3.13%)
:arrow_down:

...vercorp/pinpoint/web/vo/ApplicationAgentsList.java
66.66% <0.00%> (-2.57%)
:arrow_down:

...cluster/zookeeper/ZookeeperClusterDataManager.java
52.90% <0.00%> (-1.94%)
:arrow_down:

...orp/pinpoint/rpc/server/DefaultPinpointServer.java
78.39% <0.00%> (-1.05%)
:arrow_down:

... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5d96d6...71a7af1. Read the comment docs.


[W6.1h][T09-B2]Nelson Quek Yee Jiel

Added getPrintableString() method and implemented Printable Interface in Person class.

@nelsonqyj Some comments added. Please close the PR after reading comments.

Ideally the getPrintableString(Printable … printable) method should be used somewhere.


[Nominations Open] Top Doc(umenter) Award 2024 🏆

This issue is to receive nominations for the Top Doc(umenter) Award 2024.
This award recognizes excellence in documentation contributions to the CDF and its projects. Outstanding technical documentation is one of the best ways projects can lower the barrier to contribution.
➡ Nominate someone, by replying to this issue with the following:

Full name of the person you’re nominating
Short description of their contributions to the Continuous Delivery Foundation and why they should win.

Nomination Deadline: Sunday, February 19, 2024 at 11:59 PST
Please note: Last year's winner, Terry Cox, cannot win the award for Top Doc(umenter) again this year.

CDF Award Guidelines
2024 Awards Page (where you can nominate someone for another award)

I would like to nominate Ole Lensmar for this award. Ole worked on CDEvents for testing, which included both design and excellent documentation. He has also contributed blogs on the topic.

I would like to nominate Vlad Silverman. Vlad is a Jenkin's documentation contributor.
https://github.com/vsilverman

I nominate Kevin Martens (@kmartens27) as CDF top documentor.
Kevin is the Jenkins documentation officer and is a key contributor to Jenkins documentation.  He creates the upgrade guide and the changelog for the Jenkins long term support releases every 4 weeks.  He monitors, maintains, updates, and corrects the weekly changelog.
Kevin is a skilled and capable reviewer of documentation pull requests.  He's been deeply involved as a reviewer of the versioned documentation project from Google Summer of Code 2023.  He regularly reviews and merges pull requests to the Jenkins documentation.
He hosts weekly documentation office hours and involves others in his efforts.  He is the lead author of contributor stories to the Jenkins contributor spotlight.  He has published 5 contributor spotlights with many more in preparation for publication in 2024.

⚠ Nominations for this award are now closed. Thank you all for submitting your nominations. Voting will open on February 22.
The CDF Award voting is done by members of the TOC, Ambassadors, and Outreach Committee,who will receive an email with information on how to vote.

Award Winners were announced at cdCon 2024.


The file setuppigen.sh doesn't exist

On the Readme.md file, line 32, you have mentioned that to run the setuppigen.sh script, but it seems the file doesnt exist.

Also, refering the cd pi-gen-basedocker on line 31, maybe you could rename it to cd pi-gen-docker


Change method used for tweening

This alternative implementation calculates the tweened value as a function of its start and target values, rather than its current and target values.
This fixes an issue when, for example, setting a duration of five seconds and a linear easing function, the tween would not animate linearly, and would be close to its target value in under a second.

I started writing some tests, but I think they could be improved.
The core thing I was trying to improve with this PR was an issue where the animation seemed to be taking the wrong amount of time, and wasn't easing in the way I would expect. To test for that sort of thing required stubbing requestAnimationFrame, which I've done with a third party library.
One thing I notice I haven't done is wrap my tests in a call to createRoot. When I did this, the timers stopped working correctly, and I wasn't sure why. So I've committed what I've done so far, all the tests pass, and they also don't pass when testing against main, which is a good thing.

It might be simpler to mock the raf without a dependency, this way no one has to research that library to figure out what exactly it's doing. like here: https://github.com/solidjs-community/solid-transition-group/blob/main/test/index.test.tsx. But it's fine if you don't want to.

One thing I notice I haven't done is wrap my tests in a call to createRoot. When I did this, the timers stopped working correctly, and I wasn't sure why.

Maybe solid's scheduling gets in the way of effects, you don't want update any signals or call any actions in the root/effect synchronously, but outside of it so that the effects queue is flushed immediately, just like it would when you would do that in eg a event handler. https://github.com/solidjs-community/solid-primitives/blob/i18n-generic-resolvers/packages/transition-group/test/list-transition.test.ts#L48


Is there any way to upload a video? Ive tried update_with_media but it does not work.

( tweepy.error.TweepError: Invalid file type for image: video/quicktime )is the error I get when trying to upload  a video.

Duplicate of #640


WIP | Ayr 447/sandbox deployment in ci

Changes in this PR

Added deploy_to_sandbox GH action workflow

Note:  Still need to decide on what AWS profile we can use to run Zappa in GH actions. Will speak with @ben-cerium about this. Once confirmed, will set the env var for it in the repo.
JIRA ticket
https://national-archives.atlassian.net/jira/software/projects/AYR/boards/66?assignee=63b4326678aabbefa9d4400d&selectedIssue=AYR-447

Closing this PR as per @ben-cerium's reminder that deployment code should be in private repo for security as per our engineering handbook.


OPP Flow control

Implement some kind of flow control for OPP. Currently, we can write faster than the controller can read.

currently not possible with the hardware


cmd/compile: pointer method example fails type interference when defined as a struct's method

I am looking at the pointer method example from generics doc. There it states:

This approach works as expected, but it is awkward to have to repeat Settable in the type arguments. Fortunately, constraint type inference makes it less awkward.

But if I convert that example into methods on a struct, the type interference does not make it less awkward. Demo
package main

import "strconv"

type Settable int

func (p *Settable) Set(s string) {
	i, _ := strconv.Atoi(s)
	*p = Settable(i)
}

type Setter[B any] interface {
	Set(string)
	*B // non-interface type constraint element
}

type F[T any, PT Setter[T]] struct{}

func (_ F[T, PT]) FromStrings(s []string) []T {
	result := make([]T, len(s))
	for i, v := range s {
		p := PT(&result[i])
		p.Set(v)
	}
	return result
}

func main() {
	_ = F[Settable, *Settable]{}.FromStrings([]string{"1", "2"})
	_ = F[Settable]{}.FromStrings([]string{"1", "2"})
}

The last line fails compiling. Are there plans to improve this?

@griesemer @findleyr

The problem here is not related to pointer methods in any way. For instance, this simplified version of the code:
package main

type F[T any, PT *T] struct{}

func main() {
	_ = F[int, *int]{}
	_ = F[int]{}
}

has the same problem. The issue is that type inference is not implemented for generic types because its possible to create cycles that our existing type inference cannot handle.
The plan forward is to enable type inference when certain cycles don't exist, but it's not a high priority at this point because you can simply use a factory function if needed:
// factory function for F type
func f[T any, PT *T]() struct{} {
	return F[T, PT]{}
}

Type inference works with the factory function (playground) and this way the code looks pretty nice. Here is the original example using a factory function.
I'm going to close this as working as intended.

@griesemer, thank you for your detailed explanation.
To me the issue here is that I am making an exported struct type from a package. I hoped that my users could just create a struct with one type variable, but now it seems just for the typing reasons I would have to provide a New function, even if it does not do anything else. While such a factory function seems nice, it feels to me as unnecessary?
On a side note, the only reason why I need two type variables seems like a more basic limitation to me. I would prefer if I could just do (play link):

type Setter interface {
	Set(string)
}

type F[T Setter] struct{}

func (_ F[T]) Make(s string) T {
	x := new(deref T)
	x.Set(s)
	return x
}

So the only reason I need two type variables is because there is not "deref" type operator, which would convert pointer to type to type and pass it to new. Doing x := *new(T) also does not work because you end up with nil.
Currently I decided to go with reflect (play link):
func newT[T Setter]() T {
	typ := reflect.TypeOf((*T)(nil)).Elem().Elem()
	return reflect.New(typ).Interface().(T)
}

But it feels to me like this should be unnecessary. Are there any plans to introduce such a type operator?

I'm going to close this as working as intended.

Why not leave it open until such (low priority) type inference is introduced?

@mitar Currently there's no plan to introduce a "deref" type operator - the mechanism we have in place is through additional (in this case a 2nd ) type parameters in the type parameter list with respective constraints. Using a "deref" operator is an interesting idea; it would be a type operator that allows you to "take apart" a type rather than construct a new type, which is what Go's type system usually does. Violating this "invariant" may have subtle repercussions that we may rely on elsewhere (need to think about it some more).
I closed this issue because a) there is no "bug" here, and b) we are aware of the missing type inference for generic types - it's something we hope to fix eventually. But it's not blocking anyone, and providing factory functions for exported types is not really a hurdle and may even be recommended.
Re: the "deref" idea: you could file a proposal if you are so inclined. Just know that may open the door to other "type deconstruction" operator requests. Not sure we want to go there. Thanks.

@griesemer Thank you again for the time for the explanation. I think my reflect approach above will work out for me just fine. Based on what you said I did try to write a generic newSiteT function with two type parameters where one would be inferred (because my understanding was that should work), but I just couldn't get it to work. I will leave to somebody else to propose the deref idea. Thanks.

@mitar I don't understand why the example I sent cannot be adjusted - it was based on your code. What are you intending to do? Why does that need reflection?


Changes live region

Adds a single live region permanently asap.
Gets rid of some of the timing problems with NVDA (e.g., initial speech string not read on Win8.1 IE11).
Does not help re Chrome problem of sub formulas not read.

LGTM


Add support for FreeBSD-amd64

Adds support for generating the rid string freebsd-x64.

Hi @kareigu! Thanks for the PR. Quick question — is it for personal use or do you plan to package the app for FreeBSD?

Just personal currently, though I did think of submitting to the ports tree at least.


confusing sentence and NOTES in caps in 4-2

62: Soon it became hard to know if, who and how one was reaching an audience with a website and proprietary search systems like Google and proprietary social networks like Facebook and Twitter became the platforms of choice for digital communication.
93:notes in caps

Addressed.


Image captured from Samsung device returns stream of incorrect length

If you are creating an issue for a BUG please fill out this information. If you are asking a question or requesting a feature you can delete the sections below.
Failure to fill out this information will result in this issue being closed. If you post a full stack trace in a bug it will be closed, please post it to http://gist.github.com and then post the link here.
Bug Information
var selectedPhoto = await CrossMedia.Current.PickPhotoAsync();
long size = selectedPhoto.GetStream().Length;
This returns 3119122 instead of 1785830 for the below image.
The image is taken from a Samsung phone. For images taken from other devices like OnePlus, Pixel, etc are returning the correct file size. Only Samsung images have this issue.
I also created a Console application to read the same image file and it returned the correct value.
Also using Xamarians.Media (https://github.com/Xamarians/Media) returns the correct file length for the same image.
We are using the file length to take a decision whether to compress the image or not. We have a requirement to keep the image file size below 2MB.
Sample image to verify the issue.

Version Number of Plugin: <IP_ADDRESS>
Device Tested On: Samsung S6 Edge and Samsung A50
Simulator Tested On: NA
Version of VS:  2019 16.5.0
Version of Xamarin: Xamarin.Forms <IP_ADDRESS>1640
Versions of other things you are using:
Steps to reproduce the Behavior
Expected Behavior
The stream should be of the correct length i.e. as per the file size
Actual Behavior
Incorrect stream length
Code snippet
var selectedPhoto = await CrossMedia.Current.PickPhotoAsync();
long size = selectedPhoto.GetStream().Length;
Screenshotst

We are having issues with A10 and A20 phones as well

Not sure if this is related, we had A10 and A20 phones randomly crash on taking photos. I do not have the phone myself (only a friend) plus with COVID we are isolated. So I had to improvise on testing. I created 4 buttons with 4 separate functions to see if an option was causing the crash. Here are the functions with their options. These options fared well.  ** GenerateFileName is a function I have outside of the scope here. Hope this helps.
 var file = await CrossMedia.Current.TakePhotoAsync(new StoreCameraMediaOptions { 		Directory = "Images", 		SaveToAlbum = true, 		CompressionQuality = 92, 		CustomPhotoSize = 50, 		PhotoSize = PhotoSize.MaxWidthHeight, 		Name = GenerateFileName(), 		AllowCropping = true, 		MaxWidthHeight = 1500 }); // 2nd var file = await CrossMedia.Current.TakePhotoAsync(new StoreCameraMediaOptions { 		Directory = "Images", 		SaveToAlbum = true, 		CompressionQuality = 92, 		CustomPhotoSize = 80, 		PhotoSize = PhotoSize.Large, 		Name = GenerateFileName(), 		MaxWidthHeight = 1500 });

We are having issues with a Samsung A10e that could be similar. but do not have access to the device myself to debug.

@jamesmontemagno Is it a known issue?


Browser Based Simulator:  Control by Operation not working

Control By operation not working when simulator is configured browser based.
]

Fixed in 2.1


Questions related to Debian packaging

I'm working on packaging various Bitcoin stuff for Debian. You can see my project at https://github.com/Kixunil/cryptoanarchy-deb-repo-builder/
I find lnbits to be a very interesting candidate for packaging. I have some questions that I need answers to before deciding on the priority and the proper approach:

Does lnbits include some kind of master management interface for the server admin?
Can lnbits initialize lnd wallet? No longer relevant
Is it possible to configure prefix for web paths? e.g. /lnbits/... instead of /..., the intention is to avoid conflicts with other apps
Is it possible to use configuration file instead of environment variables?
Is it possible to use multiple LN nodes? I was thinking having one system-wide node and optionally other nodes for users (ideally more per user, so the users can have multiple Tor identities). Note: not a priority.
Does lnbits support some kind of SSO natively?
Are there any plans on making the UI less complicated? (e.g. hiding various hex strings behind "advanced" menu)

I'm just looking into a way how to prefix web paths. Has anyone found an answer to that question?

@tomichec I didn't look into it yet as I was waiting for my questions to be answered.
I've update my issue to reflect current state of things. The repo is no longer experimental, but beta and I'm working on making it stable. I believe no more external packages will be added before stabilizing.

Let me answer your questions here @Kixunil:

Does lnbits include some kind of master management interface for the server admin? Not at this point.
Is it possible to configure prefix for web paths? Shouldn't this be done by a proxy in front of LNbits? I'm not sure what LNbits should do to support this, but if there is something to do we should.
Is it possible to use configuration file instead of environment variables? No, but you can always write the environment variables in a file and read it automatically when launching LNbits. I think that is done automatically by LNbits if the file is called .env and is located at the right place. I'm not exactly sure how this works because it's Python magic.
Is it possible to use multiple LN nodes? We intend to support this, but it's not possible now.
Does lnbits support some kind of SSO natively? No.
Are there any plans on making the UI less complicated? No.

Is it possible to configure prefix for web paths? Shouldn't this be done by a proxy in front of LNbits? I'm not sure what LNbits should do to support this, but if there is something to do we should.

I think it is a good idea to support it within lnbits. It should not be too much work and it greatly simplifies this setting in a range of other application (like BTCPayServer besides cryptoanarchy-deb-repo). Also, many other apps do support it by default and the nginx package that would support it is not in the default nginx installation.
I have done some research into it and it seems that hypercorn should be able to do it. There is some middleware dispatcher, that should be able to do exactly that, but I haven't manage to make it work even with the simplest hello-world application.
I have also found some suggestions that other packages could be used to do exactly that -- like Blueprint.
There is already also an issue that might be related, as it solves the proxy setup and suggestion is to use middleware instead of lnbits/proxy_fix.py
Perhaps the scope of the works is already enough to create another issue. What do you think?

I think a pull request that both this and #131 is what we need :grin:

Thanks for the answers!
Using proxy is totally fine for me as long as the paths don't mess up. Some apps don't take into account the possibility of root path being different from / and thus don't work. I think all applications I've seen so far needed to be configured to know about the prefix (This is not a problem for me, the only thing I care about is for it to work at all.)
I asked about env because I've heard claims of it not being secure but I couldn't find an exploit myself. Anyway it shouldn't matter here as there's no confidential information in env, so that's OK.

multiple LN nodes? We intend to support this

Good, my repo also has only one right now. Will try to coordinate in the future.
Would you accept a PR implementing SSO in the future? Would you be open to consider UI improvement ideas/PRs? I don't promise to do these things soon but they are something I'd be interested in looking into at some point.

There is confidential information in the env, yes. Keys to your node, for example.
It shouldn't be hard to change that to allow using a config file. But I think that if you read the .env file from inside the process that is running LNbits it will be the same, the values won't be leaked to the rest of the system (if that is your concern). But don't quote me in any of this.
What kind of SSO do you have in mind? Currently LNbits work by just giving you an URL to your wallet and that URL has all your credentials in it.

I was thinking of optionally enabling LNbits for the owner of the server/whitelisted users only. The SSO was meant to resemble one present on ThunderHub - pass a single-use token in the URL.


Add CI config

Enable travis for your Github account and enable this project, then the job should run on this PR!

My travis run is at https://travis-ci.org/gesslerpd/baseline


CSR Representation for Sparse Matrices

Resolves #37.
This PR implements CSR matrix-vector multiplication under the "csr" feature. (This was for me to debug; if CSR sould become the only representation, then we can simply replace and remove the feature.) We get a slight uptick in performance, around 10%.
Notes:
There are many sparse matrix crates available in rust. However, most of these crates are do not parallelize, or are not compatiable with field elements. For example, sprs does not parallelize its sparse matrix / dense vector multiplication. It's traits also require num_traits::Zero, which is not compatiable with ff::PrimeField.
CSR:
Nova-based VDF with MinRoot delay function
=========================================================
Proving 1 iterations of MinRoot per step
Producing public parameters...
PublicParams::setup, took 898.236583ms
Number of constraints per step (primary circuit): 9819
Number of constraints per step (secondary circuit): 10347
Number of variables per step (primary circuit): 9813
Number of variables per step (secondary circuit): 10329
Generating a RecursiveSNARK...
RecursiveSNARK::prove_step 0: true, took 3.208µs
RecursiveSNARK::prove_step 1: true, took 31.0505ms
RecursiveSNARK::prove_step 2: true, took 37.113ms
RecursiveSNARK::prove_step 3: true, took 37.011ms
RecursiveSNARK::prove_step 4: true, took 38.116292ms
RecursiveSNARK::prove_step 5: true, took 37.588333ms
RecursiveSNARK::prove_step 6: true, took 37.468125ms
RecursiveSNARK::prove_step 7: true, took 37.913125ms
RecursiveSNARK::prove_step 8: true, took 37.48625ms
RecursiveSNARK::prove_step 9: true, took 38.424084ms
Verifying a RecursiveSNARK...
RecursiveSNARK::verify: true, took 29.615583ms
Generating a CompressedSNARK using Spartan with IPA-PC...
CompressedSNARK::prove: true, took 721.547ms
CompressedSNARK::len 9407 bytes
Verifying a CompressedSNARK...
CompressedSNARK::verify: true, took 30.767459ms

No CSR:
Nova-based VDF with MinRoot delay function
=========================================================
Proving 1 iterations of MinRoot per step
Producing public parameters...
PublicParams::setup, took 891.275666ms
Number of constraints per step (primary circuit): 9819
Number of constraints per step (secondary circuit): 10347
Number of variables per step (primary circuit): 9813
Number of variables per step (secondary circuit): 10329
Generating a RecursiveSNARK...
RecursiveSNARK::prove_step 0: true, took 2.875µs
RecursiveSNARK::prove_step 1: true, took 34.667833ms
RecursiveSNARK::prove_step 2: true, took 40.504625ms
RecursiveSNARK::prove_step 3: true, took 40.93575ms
RecursiveSNARK::prove_step 4: true, took 41.700541ms
RecursiveSNARK::prove_step 5: true, took 41.201209ms
RecursiveSNARK::prove_step 6: true, took 41.845625ms
RecursiveSNARK::prove_step 7: true, took 41.882541ms
RecursiveSNARK::prove_step 8: true, took 41.978542ms
RecursiveSNARK::prove_step 9: true, took 42.167542ms
Verifying a RecursiveSNARK...
RecursiveSNARK::verify: true, took 28.778584ms
Generating a CompressedSNARK using Spartan with IPA-PC...
CompressedSNARK::prove: true, took 729.643958ms
CompressedSNARK::len 9406 bytes
Verifying a CompressedSNARK...
CompressedSNARK::verify: true, took 29.569208ms
=========================================================

Note: there are a few places where I don't do the most optimal calculation; I've neglected them in favor of getting this draft PR out.
However, everything on the "critical path" is as one would theoretically expect. Maybe there are more concrete optimizations to be made.

This PR implements CSR matrix-vector multiplication under the "csr" feature. (This was for me to debug; if CSR sould become the only representation, then we can simply replace and remove the feature.) ~We get a slight uptick in performance, around 10%.~ Nevermind, it equals out as constraints get larger.

Given the motivation for this change, and that it will change digests, etc., I would love to see a stronger indication that the current implementation will produce the expected performance improvement. I fully accept that we have solid theoretical ground for expecting it, but it would be worth working out enough of the implementation to be sure we won't need more digest-affecting changes in order to realize the gains.

Here are some concrete gains in lurk-rs, bench sha256_ivc_prove, rc=10, 100.

Here are some concrete gains in lurk-rs, bench sha256_ivc_prove, rc=10, 100. No CSR:

Ah, perfect — thanks. I think that's sufficient to show this is manifestly worthwhile. If we can gain confidence in the concrete representation being stable, I'd suggest we don't need a feature flag to accept this.

The conversion is indeed just part of setup, but when we're dealing with foldings that run in <40ms, I expect the additional handful of ms involved in this unnecessary conversion to show a difference.

It doesn't matter how long one folding takes. If we are folding many times, then the one-time cost of processing circuit shapes should not be a big deal. In other words, at the scale of proofs that will take seconds or minutes to generate, then ms are not that big a deal. However, I agree that we should just materialize whatever we are going to use, as a matter of efficiency in principal.
The reason I mention is that the only case (as I see it), where the one-time cost of creating the shape is significant, is the case where the whole proof is very very small. I'm trying to emphasize that this is not a very important case in terms of how we focus on optimization. So even though I agree it's worth this savings, the much more important point is to ensure that whatever we do here is indeed only being performed once, when creating parameters for a given circuit.

The reason I mention is that the only case (as I see it), where the one-time cost of creating the shape is significant, is the case where the whole proof is very very small. I'm trying to emphasize that this is not a very important case in terms of how we focus on optimization.

I agree, but that is very precisely the case chosen for the initial benchmarks @winston-h-zhang reported, which created some noise in communication.

The logical implication of what I'm saying is that if we want to justify the work based on measured performance rather than theory, then we should choose a representative benchmark (like the ones from lurk-rs that I found convincing). What I was observing above is that if we have the expected performance characteristics, then on a suitable benchmark we should observe that this question of conversion at a cost on the order of milliseconds won't be significant. To be clear, I'm not arguing that we shouldn't favor the more efficient method given the total decision. I'm just saying that it is not a first-order performance consideration. If our benchmarks are forcing us to treat it as significant, we should either change them or be sophisticated enough to look past them before letting the tail wag the dog.

Yes, sorry the digest work was just for testing on lurk-rs. Let me rebase

!benchmark

!benchmark

!benchmark

!benchmark


Autocomplete: Wait to initialize autocomplete until a token is retrieved

When initializing autocomplete, we check whether we need a token, conditionally retrieve one, and initialize the search. However, retrieving the token does not block, so there is a race condition where we might not get the token before we initialize search. This leads the search to display "Results could not be loaded" for the user.
This is rectified on subsequent visits, or if the user refreshes the page, but it would be ideal (and fairly negligible) to fix!

Looks like this was fixed in #1030


[SPARK][STREAMING] Invoke onBatchCompletion() only when all jobs in the JobSet are Success

What changes were proposed in this pull request?
The code changes in PR(https://github.com/apache/spark/pull/16542) make me very confusing:
https://github.com/apache/spark/blob/5a02e3a2ac8a25d92d98d3b3b0d1173dddb9cc91/streaming/src/main/scala/org/apache/spark/streaming/scheduler/JobScheduler.scala#L203
private def handleJobCompletion(job: Job, completedTime: Long) {     val jobSet = jobSets.get(job.time)     jobSet.handleJobCompletion(job)     job.setEndTime(completedTime)     listenerBus.post(StreamingListenerOutputOperationCompleted(job.toOutputOperationInfo))     logInfo("Finished job " + job.id + " from job set of time " + jobSet.time)     if (jobSet.hasCompleted) {       listenerBus.post(StreamingListenerBatchCompleted(jobSet.toBatchInfo))     }     job.result match {       case Failure(e) =>         reportError("Error running job " + job, e)       case _ =>         if (jobSet.hasCompleted) {           jobSets.remove(jobSet.time)           jobGenerator.onBatchCompletion(jobSet.time)           logInfo("Total delay: %.3f s for time %s (execution: %.3f s)".format(             jobSet.totalDelay / 1000.0, jobSet.time.toString,             jobSet.processingDelay / 1000.0           ))         }     }   }
If a Job failed and the JobSet containing it has completed, listenerBus will post a StreamingListenerBatchCompleted, while jobGenerator will not invoke onBatchCompletion. So the batch is completed or not ?
The key point is if a Job in a Batch failed, whether or not we consider the Batch as completed.
I think if someone register a listener on StreamingListenerBatchCompleted, he just wants to get notified only when the batch finishes with no error. So if a Job is failed, we should not remove it from its JobSet, thus the JobSet has not completed.
How was this patch tested?
existing tests
Please review http://spark.apache.org/contributing.html before opening a pull request.

Can one of the admins verify this patch?

cc @CodingCat, WDYT about this revert?

cc @zsxwing

Btw, I think this is not only revert the commit, seems it also proposes its fix. It is better to modify the title.

did I miss anything? @victor-wong , you are describing what https://github.com/apache/spark/pull/16542 does in your description, but you are reverting it in your changes?

@viirya Sorry for the misleading title, I have changed it now.

@CodingCat Yes, this PR wants to solve the same issue in https://github.com/apache/spark/pull/16542, but I think this is a better way to solve it.
If a Job failed, I think we should not remove it from its JobSet, so jobSet.hasCompleted will return false. As a result, we will not receive a StreamingListenerBatchCompleted.
What I want to say is that if a Job is failed, we should consider the Batch as not completed.
I am not confident about my English, if I am not describing it clear, please let me know.

What I want to say is that if a Job is failed, we should consider the Batch as not completed. isn't #16542 doing the same thing?

@CodingCat please checkout the difference between the two PR.
`
if (jobSet.hasCompleted) {

 jobSets.remove(jobSet.time)

 jobGenerator.onBatchCompletion(jobSet.time)

 logInfo("Total delay: %.3f s for time %s (execution: %.3f s)".format(

   jobSet.totalDelay / 1000.0, jobSet.time.toString,

   jobSet.processingDelay / 1000.0

 ))
 listenerBus.post(StreamingListenerBatchCompleted(jobSet.toBatchInfo))

}
`
As shown above, in In https://github.com/apache/spark/pull/16542, if a Job failed, listenerBus still post a StreamingListenerBatchCompleted, which I believe to be incorrect, because the Batch is not completed (a Job of it has failed).

#16542 has guaranteed that the failed batch can be re-executed, and I didn’t check if reverting the change in #16542 plus your new change can guarantee the same thing...
Suppose it also guarantees, the remaining discussion becomes “what does complete mean in English?” which is not interesting to me to discuss

One thing to note is that mute an event is a behavior change, if a user has introduced some customized listener to capture all completed batches and also extract failed job info, he/she will see a broken scenario with the change in this PR

@CodingCat

One thing to note is that mute an event is a behavior change
I agree with that, so we should be careful about changing the current behavior. I will close the PR later.

the remaining discussion becomes “what does complete mean in English?” which is not interesting to me to discuss
Maybe the remaining discussion should be how to let the user know that he will get a StreamingListenerBatchCompleted event even if the batch failed.
What about adding some comments:
 /** Called when processing of a batch of jobs has completed **(event if the batch failed)**. */   def onBatchCompleted(batchCompleted: StreamingListenerBatchCompleted) { }
As I was using the StreamingListenerBatchCompleted to do some metadata checkpointing stuff, which should be done only when the batch succeeded.

if you just worry about

As I was using the StreamingListenerBatchCompleted to do some metadata checkpointing stuff, which should be done only when the batch succeeded.

If this is your concern, you should handle whether complete is with a failure in your own listener, check: https://github.com/Azure/azure-event-hubs-spark/blob/fecc34de8a238049806d033d8a85d888cad75901/core/src/main/scala/org/apache/spark/streaming/eventhubs/checkpoint/ProgressTrackingListener.scala#L38
IMHO, Complete includes Failure&Success cases is more intuitive to the (scala) user since we are used to .OnComplete in Scala Future, etc.

@CodingCat
Thank you:)


Crowdstrike Playbooks missing/broken

Inside the Playbooks folder > Crowdstrike folder (direct link) most of the playbooks referenced don't seem to exist.
For example, the link to the base_playbook lands you on a 404 error with the message "The master branch of Azure-Sentinel does not contain the path Playbooks/CrowdStrike/Playbooks/CrowdStrike_Base."

We beleive we have found the missing 3 here -
https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/CrowdStrike Falcon Endpoint Protection/Playbooks
Can the links at least be updated, or the playbooks in the playbooks folder be removed?

Hi @Forcky, Thanks for flagging this issue, PR has been raised with corrections. Thanks!


Create tiffin.txt

Added tiffin

@kiaroa First stage of verification passed, official domain is tiffinschool.co.uk as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision. Proof of domain ownership: https://www.tiffinschool.co.uk/


Warning: Invalid DOM property fill-rule. Did you mean fillRule?

I am getting this error when calling openView.
It seems to be coming from the @interchain-ui package, but that package is not public.
I'm not using webpack, but using vite to compile my react app

@toshiSat hi, I'm fixing this in @interchain ui package, this can be safely ignored for now

fixed please update to the latest version @toshiSat


How much of prompt caching is done not being Shown in the Extension while using Openrouter

Which API Provider are you using?
OpenRouter
Which Model are you using?
Sonnet-3.5
What happened?
Its working fine just would be good if it shows how much prompt caching is being done in Openrouter
Steps to reproduce
1.You can just look into it
2.

Relevant API REQUEST output
No response
Additional context
No response

I'm wondering if cache is even being utilized in OpenRouter. With medium sized web projects, Claude directly gives me a large cache and ~$0.20 per API request, while switching and using OpenRouter is sometimes ~$1.95 per API request

Open Router doesn't seem to be caching for me either, but it does cache when I directly use the api.

My cost went like .3$ per api request and I had to stop my project
On Wed, 6 Nov, 2024, 20:09 bramblebrain, @.***> wrote:

image.png (view on web)
https://github.com/user-attachments/assets/f8962681-44c1-4283-94bc-554590710101
Open Router doesn't seem to be caching for me either, but it does cache
when I directly use the api.
—
Reply to this email directly, view it on GitHub
https://github.com/cline/cline/issues/580#issuecomment-2459930035, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/APTH6CWHZJJNRQM35B7OSGDZ7IS3JAVCNFSM6AAAAABQJAGPTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJZHEZTAMBTGU
.
You are receiving this because you authored the thread.Message ID:
@.***>

Here is the prompt for both except for the change in filename:

Using Python create a Monte Carlo Simulation inside a file test2
Modify the code so that there is a screenshot of the monte carlo simulation
Modify the monte carlo simulation so that is for trading
Change the number of simulations to 100 and remove the axis on the graph

It doesn't appear to be using prompt caching at all

I was wondering what was going on too. I spent 10 usd like nothing on openrouter. I think cache is not being used.

My findings confirms what you suspect - prompt caching is not being used with open router.
Each request is ~10x more expensive than with Anthropic's API for Sonnet 3.5, which is expected without prompt caching.
All activity items show this:

@ntrpnr @saoudrizwan I can confirm that as of today prompt caching has stopped working with Openrouter. It was working completely fine yesterday. I dont see any particular updates since then - maybe something changed on openrouters end?

I've done some investigation and with some changes I've managed to get it to work. It seems however like the 3rd request (file shared) in a chat session causes API Request Failed: Provider returned error. I can't get around it.

@nishantg96 Feel free to check if my PR #716 fixes it for you

@nishantg96 Prompt caching is working for me on v2.1.4 for anthropic/claude-3.5-sonnet:beta but not for anthropic/claude-3.5-sonnet

Even with anthropic/claude-3.5-sonnet:beta, the cost is still higher compared to using the Anthropic API directly. It's unfortunate that Anthropic's rate limits force me to rely on OpenRouter.

@nishantg96 Prompt caching is working for me on v2.1.4 for anthropic/claude-3.5-sonnet:beta but not for anthropic/claude-3.5-sonnet

This issue was fixed in 2.1.5, thank you for reporting!


Improve editor cooperation and teamwork: don't lock issues for ONE editor

I'm submitting a feature request
Brief Description, motivation, use case
As #394 and probably other issues mentioned right now the workflow is pretty simple:

reviewer checks the issues
if s/he thinks it's definitely good or bad, flags it
flagging locks the issue for the editor, nobody can do anything anymore about it
if the editor fixes it, good; if not, it's staying there forever, opened, unresolved.

This is not really good approach. Use cases:

I Flag an edit as bad + high impact + unresolved, but don't have the time to fix it.
I filter for bad+unresolved, and try to resolve them.
I review bad reports and realise that there's nothing bad about it, it was possibly accidentally flagged so (or vice versa).

Generally the person checking and the person fixing don't have to be the same. It is useful if that's so but don't have to be compulsory.
Suggestions

It should be possible to unlock my own locked issue, so I can flag it bad and unresolved and let others to fix.
It should be possible to tag issues of other people, especially "resolved" or "miscategorised" (if there's no other way)
It should be possible to unlock others' issues locked for months, or even years.

Other Information / context:
Trying to change an issue locked to someone else right now result a cryptic error message about "not logged in", which is highly misleading.

Related to https://github.com/mapbox/osmcha-frontend/issues/394
Yes, I think we definitely need to change the way the review works. I think we could allow at least the experienced users to change review status.


New Website Logo: LINE

To list your organization's logo on the Rust website, fill out the following information and click "submit new issue". Alternately, you may edit _data/users.yml as described therein and submit a pull request.

Organization name: LINE
Homepage url: https://line.me/
Logo url: https://i.gyazo.com/a0947250a466b200c9f33d6b9c67701a.png
How you are using Rust: configuration agent
Url describing Rust usage:
Organization contact<EMAIL_ADDRESS>

transparent background png: http://livedoor.blogimg.jp/line_hr/imgs/c/b/cb68fe4b.png

Merged. Thanks!


fix(server): set maxHttpBufferSize to the socket.io v2 default

Fixes #3621

:white_check_mark: Build karma 2868 completed (commit https://github.com/karma-runner/karma/commit/c4899f0459 by @johnjbarton)

:white_check_mark: Build karma 2868 completed (commit https://github.com/karma-runner/karma/commit/c4899f0459 by @johnjbarton)

Thx @johnjbarton

Thx @johnjbarton


Building and deploying documentation via gh-pages branch.

This change will eliminate the need to have separate repos for built docs and will enable multi-versioning. Making the necessary changes to the workflow and doc files to implement this feature.

Completed with docs of previous releases also added.


slack: blank screen on startup, nothing happens when using menu

Issue description
When starting slack the top menu and a blank screen is shown. None of the buttons does anything in the top menu except for the about button.
Here's what it looks like when I start it from my terminal:

Starting slack with logging and debug log level (slack -l . -g debug) creates two log files. On for the browser process and one for the rendering process.
In browser.log there are two errors:
2016-09-08T12:14:20.302Z - info: Creating local storage instance at path: /home/rzetterberg/.config/Slack/local-settings.json
2016-09-08T12:14:20.303Z - error: Couldn't load /home/rzetterberg/.config/Slack/local-settings.json: ENOENT: no such file or directory, open '/home/rzetterberg/.config/Slack/local-settings.json'
2016-09-08T12:14:20.447Z - error: Couldn't initialize keytar: Error: libgnome-keyring.so.0: cannot open shared object file: No such file or directory Check to make sure that all native keytar dependencies are installed properly (especially libgnome-keyring on Linux)

Inside the renderer-xxx.log there is a javascript exception catched by bugsnag:
  "stacktrace": "TypeError: path must be a string or Buffer\n    at TypeError (native)\n    at Object.fs.readdirSync (fs.js:945:18)\n    at Object.fs.readdirSync (ELECTRON_ASAR.js:496:28)\n    at Function.getInstalledLanguages (/src/renderer/dictionary-sync.js:323:49)\n    at Function.createDictionariesForInstalledLanguages (/src/renderer/dictionary-sync.js:242:63)\n    at new ContextMenuBuilder (/src/renderer/context-menu-builder.js:54:51)\n    at ContextMenuBehavior.setup (/src/renderer/behaviors/context-menu-behavior.js:40:30)\n    at behaviors.forEach.behavior (/src/renderer/components/web-view-ctx.jsx:139:37)\n    at Array.forEach (native)\n    at WebViewContext.componentDidMount (/src/renderer/components/web-view-ctx.jsx:138:20)",

Steps to reproduce

Use NixOS unstable
Install slack nix-env -iA nixos.pkgs.slack
Delete ~/.config/Slack if it exists, to make sure there aren't any old settings
Start slack slack

Technical details

Slack version: 2.1.0
System: NixOS unstable 16.09pre90254.6b20d5b (Flounder)
Nix version: 1.11.3

Same issue for me debian stretch 9

Now is not a good moment to test, according to https://status.slack.com/

Yeah, servers was down, laggy :)


Move ActivatorUtilities to Microsoft.Framework.DependencyInjection.Interfaces

...tion.Interfaces on Http.Extensions
Fixes: https://github.com/aspnet/HttpAbstractions/issues/228
@davidfowl

:shipit:

:shipit:

merged : https://github.com/aspnet/DependencyInjection/commit/702e9a7af37a20e1276521250d68c739778606b2


Speak stopped working

Anyone else have "Speak" and "Speak At Volume" stop working on them tonight?  Everything else I normally use seems to work fine, such as execute routines (speech in those work fine), change volume, and even announce works fine.  Been using this node addon since 586837r was maintaining it, and I'm on the most current version of Applestrudel's (v5.0.21 as of writing).  Tried everything I could think of tonight... refreshing cookie, fresh authentication, restarting Node Red, new Alexa Node Account w/ new port #, power cycling echo devices, and finally deleting out all flows and removing/re-installing alexa-remote2-applestrudel (with and without flow backups)... sadly nothing fixed it.  I am on an older version of Node Red / Home Assistant, but I wouldn't think that's the issue.  I'll try updating temporarily (new versions break some things I need) to see if that resolves it, and will report back here if it does.
Of course it's not beyond Amazon to make change to things, so this may need an Apollon77 update, followed by Applestrudel updating his node, which we super appreciate btw!  Hopefully for everyone else it's just me, and something simple I'm not thinking of.

I have just tried it manually and it worked. However, I could swear it didn't tell me the time earlier today. Also the Activity Log in the Alexa App stopped working a couple of hours ago and the manual test I just did doesn't show up either. So it's likely that there was some sort of outage.

Alright, doesn't work anymore. Just failed again.
Fun fact, Announcement still works for me. You can switch to that as a workaround for now.

custom-components/alexa_media_player#1683 (comment)
Seems like Amazon changed something. Or there's an outage. But we're not alone

Are you from oceania by any chance? Noticing a trend of who the alexa issue is impacting in the other thread

Alright, doesn't work anymore. Just failed again.
Fun fact, Announcement still works for me. You can switch to that as a workaround for now.

Well I guess I'm a tiny bit relieved that it's not just my setup acting screwy... though of course that sucks for everyone else.  Wish they would just give HA/Node Red "official support," but we all know that'll never happen.  Yeah the Announcement thing was one of the features I mentioned above that still works.  Likewise, I suppose we can create routines with the needed TTS if this issue drags out.  The latter gets rid of the heads-up tone, if that's something people want to avoid.  I don't seem to have the Activity Log issue, so I wonder what that's about... Bezos needs to stop buying yachts, and actually hire some decent software developers already!
At this point I guess I just need to have patience, and let the "Counsel of Geniuses" do their thing...

Yeah I'm here trying to figure out why it's not working as well.  In the US.  I don't see any errors generated.
Announcements are integral to the systems used to manage my ADD lol.

Yeah I'm here trying to figure out why it's not working as well. In the US. I don't see any errors generated. Announcements are integral to the systems used to manage my ADD lol.

Yes there is no error thrown. Nothing. Makes me think that it's an issue on their side.

Well it appears to be working again for me (for now) here in the US.  Looking more and more like it was just an issue/error on Amazon's side.  They were probably pushing out a server update, and someone forgot to carry a 1... :roll_eyes:

Still not working here.  Says it sent but nothing comes out..

It's working here, but the <audio src\> tag that used do play audio urls isn't working anymore.

Seems like it's back, thus closing this. Thanks everyone


Root validators pre=False are called before type checking

Checks

[x] I added a descriptive title to this issue
[x] I have searched (google, github) for similar issues and couldn't find anything
[x] I have read and followed the docs and still think this is a bug

Bug
Output of python -c "import pydantic.utils; print(pydantic.utils.version_info())":
             pydantic version: 1.8.2
            pydantic compiled: True
               python version: 3.9.12 (main, Apr  5 2022, 06:56:58)  [GCC 7.5.0]
                     platform: Linux-5.13.0-40-generic-x86_64-with-glibc2.31
     optional deps. installed: ['dotenv', 'typing-extensions']

According to the docs, root validators with pre=False should execute after field validation. However, I can see that when there's a type mismatch, they are executed before, see this snippet:
from pydantic import BaseModel, validator, root_validator

class RunTimeConfig(BaseModel):

    x: int = 32
    double_x: int = None

    @root_validator(pre=False)
    def double_x_val(cls, values):
        values["double_x"] = values["x"] * 2
        return values

    @validator("x")
    def x_val(cls, x):
        print("exec x_val")
        return x

# This throws KeyError: 'x on double_x_val, instead of failing with a type checking error
print(RunTimeConfig(x="oops"))

If we don't access values['x'] in the root validator, it will indeed fail with value is not a valid integer (type=type_error.integer) after executing double_x_val.
What I was expecting: @root_validator(pre=False) will give me all the values 1) after type checking, and 2) after filling defaults. Interestingly, if there isn't type mismatch (ie x=42), it follows the order I expected: x_val -> double_x_val.
Let me know if I'm reading incorrectly after field validation., or if there's another suggestion for what I'm doing (see context below).

Context
In a nutshell, I ended up here after reading https://github.com/samuelcolvin/pydantic/issues/1729#issuecomment-661868143.  I'm looking for dynamic fields creation, reminiscent of __post_init__, I tried with @validators as well but the type checking problem remains. I could add type checking manually on either type of validator, but I feel like that defeats the purpose a little bit.
Workaround I've tried: setting pre=True does fail with type checking before executing (what I expect). Unfortunately, it does execute the root_validator before it fills any default values (2nd thing I expected). See:
class RunTimeConfig(BaseModel):

    x: int = 32
    double_x: int = None

    @root_validator(pre=True)
    def double_x_val(cls, values):
        values["double_x"] = values["x"] * 2
        return values

    @validator("x")
    def x_val(cls, x):
        print("exec x_val")
        return x

# This throws KeyError: 'x', instead of taking the 32 as default and run succeed on creating double_x
print(RunTimeConfig())

I think you just need @root_validator(pre=False, skip_on_failure=True)

Also if you check the example code in the docs:
class UserModel(BaseModel):
    username: str
    password1: str
    password2: str

    @root_validator
    def check_passwords_match(cls, values):
        pw1, pw2 = values.get('password1'), values.get('password2')
        if pw1 is not None and pw2 is not None and pw1 != pw2:
            raise ValueError('passwords do not match')
        return values

it checks the values if it is not none though in the model is required to be a string

pre=False is not necessary it seems, @root_validator(skip_on_failure=True) is enough.


Sourcery: Create a default Sourcery configuration file for your project command fails

Running the Sourcery: Create a default Sourcery configuration file for your project command on VS Code fails with the following error:
'ascii' codec can't encode character '\U0001fa84' in position 2: ordinal not in range(128)

It looks like it's trying to add 🪄 somewhere?
Relevant version info:

Sourcery v0.12.6
VS Code v1.69.2
macOS v12.5

Hi @willfrey ,
Thanks a lot for reporting this :bug: .

It looks like it's trying to add :magic_wand:  somewhere?

Yes, exactly. :+1:
This command wants to:

create a .sourcery.yaml file
add some initial content to it

This initial content is starting with the line:
# 🪄 This is your project's Sourcery configuration file.

And unfortunately, this doesn't work with ascii.
We'll fix this and let you know when it's available.

Fixed with 0.12.9


🐛 下钻场景下的总计/小计展示错误

🏷 Version

Package
Version

@antv/s2
1.4.0 or 1.4.0-alpha.4

@antv/s2-react
1.4.0 or 1.4.0-alpha.4

🖋 Description
前提：

下钻场景下开启总计/小计
totalData 仅提供到城市维度的数据（不含下钻维度） { province: "浙江", city: "杭州", price: 666 }

点击某个下钻维度开始下钻后（图上等于 rows 新增了维度 sex），实际并未提供对应新下钻行的总计/小计数据，却会意外继承展示父级的汇总数据：

⌨ Code Snapshots
https://codesandbox.io/s/cocky-brook-e2y20?file=/src/useData.tsx
🔗 Reproduce Link
🤔 Steps to Reproduce

😊 Expected Behavior
😅 Current Behavior
💻 System information

:tada: This issue has been resolved in version @antv/s2-v1.5.0-alpha.4 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version @antv/s2-v1.6.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version @antv/s2-v1.7.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version @antv/s2-v1.8.0-alpha.1 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[ST] Linea relayer fee too low

Describe the bug
Test shows low relayer fee
https://connextscan.io/tx/0xb472fffceaa72b17d169825215ac5de9edd975e4681a0f55b1597830a9c2725c

Why is the estimate wrong?

We've fixed it, It was just a cache issue.