[SPIKE] Research upgrade for Terraform.

Is your spike related to a problem or idea? Please describe.
Currently the Terraform in Epicli was not updated/maintained for a long time. This already caus-es/-ed a bunch of issues:

#2706
#1570
#1569
#2774

Besides that support for data disks will need to be added for the upcoming support for Cloud Native Storage (#13)
Describe the outcome you'd like
This spike should research what is needed to get our current Terraform up to date. Few points of interest:

Check the work needed to upgrade Terraform to the latest version. ALso we would like to top the use our terraform-bin package and install it straight in the (dev)container.
2/ Check the work needed to upgrade the Azure provider to the latest version and check what is needed to upgrade our current templates.
Check the work needed to upgrade the AWS provider to the latest version and check what is needed to upgrade our current templates.
Check if we can provide an upgrade path from pre Epicli 2.0.0 to the latest Terraform + providers.
Check if its worth it to remove the use of autoscaling groups in AWS in favor of plain VMs. As AWS is currently mostly used internally for testing this is not really a requirement.
Check if we can upgrade the azure-cli package to the latest.

Expected that this spike would result in a list of issues we can pull in one by one but if it turns out to be easy this spike might also results in (partial) implementation.
Additional context

https://www.terraform.io/language/upgrade-guides/1-1

DoD checklist

[ ] Reader is able to understand the results of spike
[ ] The results of the spike are presented in a table (to show simply what are compared or researched parameters) / not applicable
[ ] Each value / cell in the results table is described more deeply below
[ ] Demo of the spike (automated as much as possible)
[ ] Design doc updated

@seriva #2001 seems to be a candidate to close as the same was done for #2000.

@seriva #2001 seems to be a candidate to close as the same was done for #2000.

Good point ill remove and close it. We can re-open a new issue if this team comes forward again.

For this spike I research and implemented to possible update strategies.
Minor upgrade
Changes can be viewed  in the following draft pull: https://github.com/epiphany-platform/epiphany/pull/2852
This upgrades the Terraform components as follows:

Terraform from 0.12.6 to 0.12.31.
azurerm provider from 1.38 to 1.44.
AWS provider from 2.26 to 2.70.1

This pull would resolve the following issues: #2706, #1570 #1569
This pull would not solve #2774 long-term as we would still have the issue that we cant upgrade past 2.29 Azure-cli and the new authentication mechanism.
Main benefit of this approach would be that the Terraform stays competible with Epicli 1.x.
Main down side would be that the version updated to here are already really old and might give issues long-term as Epiphany 2.0 would be an LTS version.
Major upgrade
Changes can be viewed  in the following draft pull: https://github.com/epiphany-platform/epiphany/pull/2852
This upgrades the Terraform components as follows:

Terraform from 0.12.6 to 1.1.3.
azurerm provider from 1.38 to 2.91.
AWS provider from 2.26 to 3.70.1

This pull would resolve the following issues: #2706, #1570,  #1569,  #2774
Main benefit of this approach would be that the Terraform would be at the latest of the latest and should be stable for long-term LTS use.
Main downside is that this would break compatibility with Epiphany 1.x clusters. However a manual update of the Terraform is possible.
Final though
IMO we should go for the major upgrade to save us the trouble moving forward with 2.0 LTS. Also as this LTS marks a major version change I don't think a breaking change would be weird. In the end a manual upgrade path is available as documented inside the major draft pull.
As for the upgrade of the AWS terraform, it would be nice to remove the 'launch_configurations' approach in favor of something similar like we do for Azure with creating the VMs ourselves. In the end this will make it easier later when doing proper scalable components. Also as AWS is not used for production anywhere I dont think we need to wory about backwards compatibility anyway.

Agree with the 'final though' part. In addition it can be mentioned somewhere with the pointing to --no-infra to leave existing infra untouched even with upgraded version of Terraform.

Tested with:
✔ provider: Azure: apply v2.0 (all components and apps enabled)
✔ provider: AWS: apply v2.0 (all components and apps enabled)
✔ provider Azure: apply v1.3, manual upgrade of Terraform, re-apply v2.0 (all components and apps enabled/minimal cluster)

More tests:

provider Azure:

Ubuntu and RedHat (all components and apps enabled):

init v2.0dev -> apply v2.0dev -> delete v2.0dev
upgrade from v1.0.1 -> v2.0dev:

includes manual Terraform upgrade
re-applying and re-upgrade to test idempotency
backup and recovery commands
delete

provider AWS:

Ubuntu and RedHat (all components and apps enabled):

init v2.0dev -> apply v2.0dev -> delete v2.0de
All scenarios verified with epicli test .


[DocumentIntelligence] Fixing typo in samples

Fixing a single-letter typo in samples that was causing failures in our live tests pipeline.

API change check
API changes are not detected in this pull request.


Using MDX and building for production outputs both optimized and original image assets

What version of starlight are you using?
0.17.1
What version of astro are you using?
4.2.6
What package manager are you using?
yarn 1.x
What operating system are you using?
macOS 14.3
What browser are you using?
Not browser specific
Describe the Bug
When the documentation is in "plain" Markdown files .md then the images get optimized and copied out into dist/_astro.
As soon as we renamed all the documentation files to .mdx (was a necessity, needed to use Astro/Starlight components), building for production yields both optimized and original assets. Specifically, am talking about images placed in src/assets (those in public are IIUC not optimized anyway).
To repro, simply create a new project, add a .png image to assets and reference it from a .md file and then build - you should get a single .webp image. Renaming to .mdx and changing nothing else, will yield the same screenshot being output twice - once as .webp and once as .png (renamed, but otherwise identical).
Yes, I am aware that I could post-process the build result and remove the .png files from the output, but it's not in the spirit of this project IMO where the tooling is so good and nothing needs silly tweaking.
Important: was unable to figure out how to add an image to StackBlitz, the repro needs a single Screenshot.png in the assets folder.
Link to Minimal Reproducible Example
https://stackblitz.com/edit/github-bwwxgj-kxfzr1?file=src%2Fcontent%2Fdocs%2Freference%2Fcool.mdx
Participation

[X] I am willing to submit a pull request for this issue.

Thanks for the issue @ddotlic! I also believe this should work in MDX the same way it does in Markdown, not sure why it might not.
As this behaviour is fully controlled by Astro, which Starlight builds on top of, I will transfer this over to that repository to be looked at.


Challenge: Generate code for Joplin - Gladiolus Rag

The good news: no crash reading the XML file.
The challenge: quite a few things to fix.

Our target :)

I like this approach. It gives us concrete bugs to work on. The cross-staff notations are particularly interesting.

@rvilarl, would you attach the MusicXML file somewhere in this issue please?

The score is this one https://musescore.com/user/58480/scores/1749906

@jaredjj3 the score produces this fault at https://vexml.dev/
Gladiolus_Rag__Scott_Joplin__1907.zip
17:12:14.620 (1296px) Error: [RuntimeError] BadArguments: Too few notes for beam. at new sf (https://vexml.dev/assets/index-e7Ei05G8.js:60:246688) at Wo.render (https://vexml.dev/assets/index-e7Ei05G8.js:60:1213988) at https://vexml.dev/assets/index-e7Ei05G8.js:60:1224036 at Array.map () at Jh.render (https://vexml.dev/assets/index-e7Ei05G8.js:60:1224027) at Zs.render (https://vexml.dev/assets/index-e7Ei05G8.js:61:5105) at mr.render (https://vexml.dev/assets/index-e7Ei05G8.js:63:174) at https://vexml.dev/assets/index-e7Ei05G8.js:63:7625 at Dc (https://vexml.dev/assets/index-e7Ei05G8.js:40:24283) at Ss (https://vexml.dev/assets/index-e7Ei05G8.js:40:42406)

Good catch, I think we can fix this by adding a check here and making the BeamRendering.vexflow.beam nullable.

The cross staff meeasures are no longer there in measure 5

@jaredjj3 also starting on measure 10 the second staff is missing.

There must be a bug with beaming. This will be a good score to thoroughly test the system.

I'm going to take another stab at this before going back to lilypond specs. Here's what I plan to work on:

[ ] Ensure that the top of a rendering is present.
[ ] Prevent ties from rendering across systems.
[ ] Investigate increasing StaveTie height, part distance, or both.
[ ] Render repeats.

Hmm, I don't remember fixing this, but it's rendering reasonably well. @rvilarl, will you open new issues for any remaining problems? If you also have the time, it would be ideal if you could trim the MusicXML document to only include the problematic section(s).

@jaredjj3 I am planning to go back to contributing on vexml. It also seems that I could now update piano play to use vexml, right? I have a cursor and a way to get the current notes.

That's great news! I recommend holding off until release (early Jan). I'm tightening up the public interfaces and I wouldn't want you to depend on something that changes underneath you.

Is there anything that you would like me to fix in vexfow. I want to release together with @ronyeh a new beta release in Jan?

My biggest ask at the moment is clear font loading documentation for browser and non-browser environments.

@ronyeh above the wish from Jared


Add support to tts.cloud_say

Current Alexa notifitaction service doesn't support many languages, and doesn't support tts.cloud_day.
This PR adds support to tts.cloud_say by converting cloud generated mp3 via ffmpeg to format accepted by Alexa, and then playing that mp3. For this to work, HA instance has to be publicly accessible (either via Nabu Casa cloud subscription or any other custom solution), and for that reason, new setting was added to integration configuration.

Thanks. I can ignore the validate error but please fix the pre-commit requirements.

All the pre-commit issues are sorted, except of one. That is "comment", which is not comment, but string literal. But this is taken from original repo and is spread through the code, not just this place.

The issue is you put code above the docstring. Your code addition needs to be under it.


RFE: Gradle support

This S2I Builder image IMHO really should ("out of the box") support Gradle in addition to Maven.
We can take (strong) inspiration from the following "prior art" work done to implement this here:

https://developers.redhat.com/blog/2018/12/18/openshift-java-s2i-builder-java-11-grade/
https://github.com/fabric8io-images/s2i/issues/118
https://github.com/fabric8io-images/s2i/pull/121
https://github.com/fabric8io-images/s2i/pull/151
https://github.com/fabric8io-images/s2i/pull/158/files
https://github.com/fabric8io-images/s2i/issues/150 (still TBD)
https://github.com/fabric8io-images/s2i/issues/161 (example end-user interest)

@jmtd before I may sink any time into working on this, I would like to "officially" propose Gradle support, for the product images, not just the community edition. What would be the appropriate issue tracker to start a discussion about that?

The best answer would be a JIRA issue in the jboss.org JIRA, CLOUD project at the moment. We haven't migrated out of that project even though Cloud Enablement has closed down, so there isn't a better answer yet.

Just FYI, my current TODO priorities are: Openshift 4 (OCP specifically) support and RHEL8 base image support. Just behind those are community image matters.

https://issues.jboss.org/browse/CLOUD-3107

I don't plan to work on this. If someone wants to step up and do it, re-open this issue so we can discuss it. Thanks!


Cars and mounts do not recieve the speed bonus from most py tiles.

Mod source
Factorio Mod Portal
Operating system

=Windows 10

What kind of issue is this?

[ ] Compatibility
[ ] Locale (names, descriptions, unknown keys)
[ ] Graphical
[ ] Crash
[ ] Progression
[ ] Balance
[ ] Pypostprocessing failure
[ ] Other

What is the problem?

Steps to reproduce
No response
Additional context
No response
Log file
No response

Fixed. Thanks for the report.


[v4.3] Including mixins multiple times shouldn't warn about RFS

Hi everyone, I'm opening this issue after a quick talk with @MartijnCuppens here : https://github.com/twbs/rfs/pull/50#issuecomment-462481420
Before 4.3.0, importing ~bootstrap/scss/mixins multiple times was ok, but now we get a warning :
WARNING: Watch out, RFS is included more than once!

Warning comes from scss/vendor/_rfs.scss imported in scss/_mixins.scss
In my opinion bootstrap should not warn for this, especially as there's no warning of that kind elsewhere (so doing it only for _mixins.scss seems weird, as at the end it won't generate any duplicated css).
Feel free to read my comment to rfs project for more details.
I'd be pleased to make a PR removing this warning, though as it's vendor/_rfs maybe we should do it in https://github.com/twbs/rfs instead.
Let me know, and have a good day guys 👋

@MartijnCuppens This is an update for RFS and not Bootstrap itself, correct? Or should we aim to develop RFS here and publish changes back to the main repo? (Let's figure that out and document it on our side for future reference.)

I think it makes more sense to make any changes upstream first and then update it here.

If including rfs multiple times is such a bad practice maybe it should be be decoupled from mixins.scss?

This functionality was originally added because RFS broke if it was included more than once. That's fixed in the meanwhile but I build in this warning to warn people if RFS was included multiple times in their config because they're probably doing something wrong. In the scope of RFS this is quite a handy feature, but a lot of people will not know what RFS is when they include Bootstrap.
Guess I'm just going to remove it, it was more a nice-to-have feature but if it confuses more than it helps, it's moot.
I'll make PR's in both repos.


Update for Django 3.1 and Python 3.9

Coverage decreased (-3.3%) to 73.492% when pulling 43db2c51548257de94a946fd53a02cfdf08175df on jgillard:django31-and-python39 into e04d44c07110443bbdeb8cb14effbe497ddbb98d on arteria:master.


IE8 messing up with ui-router

Hi all,
I've been searching for a while now and I couldn't get any answer, so here I am.
The thing is that I have a page which is something like https://localhost/site/ and I'm defininf the routes like this:
angular
  .module('SiteModule', deps)
  .config(function ($locationProvider, $stateProvider, $urlRouterProvider, $sceDelegateProvider) {
       $sceDelegateProvider.resourceUrlWhitelist(['path/to/template','self']);
       $locationProvider.html5Mode(true);
       $urlRouterProvider.otherwise('/entity/0');
       $stateProvider.state('entities', {
            url: '/entity/:id',
            templateUrl: 'path/to/template',
            controller: function() {...}
       });
   });

Everything works great on any browser except for IE8 (of course).
When you get to the site, and click a link to https://localhost/site/entity/ I'm redirected to https://localhost/site/#/entity/0 which is the root of my site. And by redirect I mean that I see the expected result of the UI being loaded correctly just a second and then the browser refreshes to load https://localhost/site/ content although the URL is https://localhost/site/#/entity/0.
I tried the base meta tag:
document.write('<base href="' + document.location + '" />');

but, I need to be able to go to an entity directly, so going to https://localhost/site/#/entity/123 should load correctly the content, which obviously does not.
Any ideas?
Thanks a lot in advance.

https://gist.github.com/eddiemonge/f6a58169c2846731a1eb


There is no usage description

Hi, how can I use the project as a module ? Our this is a base app for rss reader ?

Hey Breno, this is just a base app. You are free to fork / clone this project and use it as a starting point for your own project.


Way to check only real hyperlinks

Hi there,
I've been using pdfx with the '-c' option to check links in PDFs.
I was wondering if there's a way to restrict the list of links that it checks to actual PDF hyperlinks - because it seems to also pull out any non-hyperlinked body text that contains a URL.
My PDFs sometimes contain example URLs that shouldn't validate ( e.g. http://your-subdomain.example.com ) as plain text, so I want to avoid checking these.
Thanks,
Graeme

Currently pdfx -c checks all the links without the ability to restrict to
only pdfs. I will add this to the feature backlog.
On Tue, Jul 26, 2016 at 9:20 AM, Graeme West<EMAIL_ADDRESS>wrote:

Hi there,
I've been using pdfx with the '-c' option to check links in PDFs.
I was wondering if there's a way to restrict the list of links that it
checks to actual PDF hyperlinks - because it seems to also pull out any
non-hyperlinked body text that contains a URL.
My PDFs sometimes contain example URLs that shouldn't validate ( e.g.
http://your-subdomain.example.com ) as plain text, so I want to avoid
checking these.
Thanks,
Graeme
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/metachris/pdfx/issues/18, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHIyywUy-yNQFyUYo3b314Rv8Mc6Zyyks5qZbUlgaJpZM4JU2rV
.

Thank you Chris!


CGX:  incorrect framing

CGX 2.13

Frame-Problem und Linien-faces.zip
The model doesn't fit in the window despite of frame being issued after plotting the complete model.

Problem persists with 2.13.1


Can't build caffe2 on Ubuntu 16.04

Hi all, I followed the guide at (http://www.nvidia.com/object/caffe2-installation.html) to install caffe2. However, at the step of "cmake", I received the following error message. Do you have any hint/direction on fixing the issues?
I also attached CMakeOutput.log and CMakeError.log for ease of reference.
CMakeFiles.zip
Many thanks!
Frank
-- The BLAS backend of choice:Eigen
-- Could NOT find NNPACK (missing:  NNPACK_INCLUDE_DIR NNPACK_LIBRARY)
-- Will try to build NNPACK from source. If anything fails, follow the NNPACK prerequisite installation steps.
CMake Warning at cmake/External/nnpack.cmake:154 (message):
NNPACK is chosen to be installed, but confu and ninja that are needed by it
are not installed.  As a result we won't build with NNPACK.
Call Stack (most recent call first):
cmake/Dependencies.cmake:53 (include)
CMakeLists.txt:74 (include)
CMake Warning at cmake/Dependencies.cmake:58 (message):
Not compiling with NNPACK.  Suppress this warning with -DUSE_NNPACK=OFF
Call Stack (most recent call first):
CMakeLists.txt:74 (include)
-- Found gflags  (include: /usr/include, library: /usr/lib/x86_64-linux-gnu/libgflags.so)
-- Found system gflags install.
-- Found glog    (include: /usr/include, library: /usr/lib/x86_64-linux-gnu/libglog.so)
-- Found system glog install.
-- Found PythonInterp: /usr/bin/python (found version "2.7.12")
-- Could NOT find Benchmark (missing:  Benchmark_INCLUDE_DIR Benchmark_LIBRARY)
-- git Version: v0.0.0
-- Version: 0.0.0
-- Performing Test HAVE_STD_REGEX
-- Performing Test HAVE_STD_REGEX -- success
-- Performing Test HAVE_GNU_POSIX_REGEX
-- Performing Test HAVE_GNU_POSIX_REGEX -- failed to compile
-- Performing Test HAVE_POSIX_REGEX
-- Performing Test HAVE_POSIX_REGEX -- success
-- Performing Test HAVE_STEADY_CLOCK
-- Performing Test HAVE_STEADY_CLOCK -- success
-- Found lmdb    (include: /usr/include, library: /usr/lib/x86_64-linux-gnu/liblmdb.so)
-- Found LevelDB (include: /usr/include, library: /usr/lib/x86_64-linux-gnu/libleveldb.so)
-- Found Snappy  (include: /usr/include, library: /usr/lib/x86_64-linux-gnu/libsnappy.so)
-- Could NOT find RocksDB (missing:  RocksDB_INCLUDE_DIR RocksDB_LIBRARIES)
CMake Warning at cmake/Dependencies.cmake:139 (message):
Not compiling with RocksDB.  Suppress this warning with -DUSE_ROCKSDB=OFF
Call Stack (most recent call first):
CMakeLists.txt:74 (include)
-- OpenCV found (/usr/share/OpenCV)
-- Found PythonInterp: /usr/bin/python (found suitable version "2.7.12", minimum required is "2.7")
-- NumPy ver. 1.13.1 found (include: /usr/local/lib/python2.7/dist-packages/numpy/core/include)
-- Could NOT find pybind11 (missing:  pybind11_INCLUDE_DIR)
-- MPI support found
-- MPI compile flags:
-- MPI include path: /usr/lib/openmpi/include/openmpi/opal/mca/event/libevent2021/libevent/usr/lib/openmpi/include/openmpi/opal/mca/event/libevent2021/libevent/include/usr/lib/openmpi/include/usr/lib/openmpi/include/openmpi
-- MPI LINK flags path:  -Wl,-rpath  -Wl,/usr/lib/openmpi/lib  -Wl,--enable-new-dtags
-- MPI libraries: /usr/lib/openmpi/lib/libmpi_cxx.so/usr/lib/openmpi/lib/libmpi.so
CMake Warning at cmake/Dependencies.cmake:253 (message):
OpenMPI found, but it is not built with CUDA support.
Call Stack (most recent call first):
CMakeLists.txt:74 (include)
-- Adding -fopenmp
-- CUDA detected: 8.0
-- Added CUDA NVCC flags for: sm_35 sm_50
-- Found libcuda: /usr/lib/x86_64-linux-gnu/libcuda.so
-- Found libnvrtc: /usr/local/cuda/lib64/libnvrtc.so
-- Found cuDNN: v6.0.21  (include: /usr/local/cuda/include, library: /usr/local/cuda/lib64/libcudnn.so)
-- Could NOT find NCCL (missing:  NCCL_INCLUDE_DIR NCCL_LIBRARY)
-- NCCL: /home/frank/Dropbox/Toolbox/caffe2/third_party/nccl/build/lib/libnccl_static.a
-- Could NOT find CUB (missing:  CUB_INCLUDE_DIR)
-- Could NOT find Gloo (missing:  Gloo_INCLUDE_DIR Gloo_LIBRARY)
-- MPI include path: /usr/lib/openmpi/include/openmpi/opal/mca/event/libevent2021/libevent/usr/lib/openmpi/include/openmpi/opal/mca/event/libevent2021/libevent/include/usr/lib/openmpi/include/usr/lib/openmpi/include/openmpi
-- MPI libraries: /usr/lib/openmpi/lib/libmpi_cxx.so/usr/lib/openmpi/lib/libmpi.so
-- CUDA detected: 8.0
-- Found libcuda: /usr/lib/x86_64-linux-gnu/libcuda.so
-- Found libnvrtc: /usr/local/cuda/lib64/libnvrtc.so
-- Does not need to define long separately.
-- This compiler has builtin_cpu_supports feature.
-- GCC 5.4.0: Adding gcc and gcc_s libs to link line
-- Include NCCL operators
CMake Error at caffe2/contrib/CMakeLists.txt:6 (add_subdirectory):
add_subdirectory given source "transforms" which is not an existing
directory.
-- Including image processing operators
-- Excluding video processing operators due to no opencv
-- Excluding mkl operators as we are not using mkl
-- Automatically generating missing init.py files.

See also "/home/frank/Dropbox/Toolbox/caffe2/build/CMakeFiles/CMakeOutput.log".
See also "/home/frank/Dropbox/Toolbox/caffe2/build/CMakeFiles/CMakeError.log".

Hi, I met this problem when I compile caffe2 on Ubuntu 16.04. Originally, I use the command "git clone https://github.com/caffe2/caffe2.git", so i met this problem. I search on the Internet and found a solution is to use the command like "git clone --recursive https://github.com/caffe2/caffe2.git" and the problem has been solved. Hope it be useful for you!
ref: https://github.com/caffe2/caffe2/issues/574#issuecomment-303342057

The part of the pasted output that matters is:
CMake Error at caffe2/contrib/CMakeLists.txt:6 (add_subdirectory):
add_subdirectory given source "transforms" which is not an existing
directory.

This must have been caused by a partially updated repository or other form of mismatch between CMake build files and the state of your source tree. Pretty sure this would have been solved by a fresh checkout. Closing the issue.


Pin Godot 3.3 to same version of test project in CI

Pin test project with proper Godot version, to be able to use in feature new functions in project without needing to look at the compatibility with 3.3 version.
Also divided one task into three(downloading, opening editor, running project)
In 3.3 branch in CI editor with sanitizers opens and close in ~30/40 seconds but in master branch it took almost 170 seconds.

Needs a rebase to fix javascript CI.

Thanks!


Added security-analytics-dashboards, cross cluster replication, and asynchronous search plugins to 2.4 manifest.

Signed-off-by: AWSHurneyt<EMAIL_ADDRESS>Description

Added security-analytics-dashboards plugin to 2.4 manifest.
Added cross cluster replication, and asynchronous search plugins.

Issues Resolved
https://github.com/opensearch-project/opensearch-build/pull/2822
https://github.com/opensearch-project/opensearch-build/pull/2825
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2826 (1901412) into main (f06c877) will decrease coverage by 0.33%.
The diff coverage is n/a.

:exclamation: Current head 1901412 differs from pull request most recent head cc9ca7e. Consider uploading reports for the commit cc9ca7e to get more accurate results

@@            Coverage Diff             @@
##             main    #2826      +/-   ##
==========================================
- Coverage   94.15%   93.82%   -0.34%
==========================================
  Files         157      157
  Lines        4242     4242
==========================================
- Hits         3994     3980      -14
- Misses        248      262      +14

Impacted Files
Coverage Δ

src/system/temporary_directory.py
64.44% <0.00%> (-28.89%)
:arrow_down:

src/system/os.py
93.75% <0.00%> (-6.25%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Study index gentropy ETL step

Currently, study indexes are created from different sources (e.g., GWAS Catalogue, eQTL catalog, Finngen) and written in a GCP bucket location. The study indexes are self-contained within the data sources, independent of other datasets, and contain all the necessary study metadata.
When a release is due, the study indexes are moved to a central location using airflow operators and considered as the final study index.
❯ gsutil ls gs://genetics_etl_python_playground/releases/24.06/study_index/
gs://genetics_etl_python_playground/releases/24.06/study_index/eqtl_catalogue/
gs://genetics_etl_python_playground/releases/24.06/study_index/finngen/
gs://genetics_etl_python_playground/releases/24.06/study_index/gwas_catalog/

We want to expand this functionality to evaluate the study indexes and validate whether the records in them contain valid entities.
We would want 2 main functionalities similar to platform-etl:

entity validation, with the consequent log of invalid studies and reason
recover obsoleted IDs by using the respective indexes with a history log

In the context of study index, the fields to ensure validation are:

geneId
backgroundTraitFromSourceMappedIds
traitFromSourceMappedIds

Additionally, biosampleFromSourceId would also require validation, but because it currently contains both UBERON and CL codes, it might require additional considerations before validation.
This might be the first of a series of actions to ensure every dataset is compatible in the context of the Platform-gentropy integration.

On your snippet, you might want to create an invalid dataset as well.
Code snippet on how the platform-etl does it, in case it's useful for inspiration
Regarding geneId and targetId. In an ideal world, I agree we should probably use the targetFromSourceId and targetFromSourceMappedId for consistency. The API will turn targetFromSourceMappedId into a fully fletched target object.
The nesting of disease is really annoying

I'm practically taking advantage of the already existing QC flagging instrumentation in study locus class (update_quality_flag, which is now moved to the base dataset class, so shared across all datasets we have). Also having a specific set of flags for study QC issues.
(
    StudyIndex.from_parquet(session, study_paths)
    .validate_unique_study_id() # Flagging duplicated study ids
    .validate_study_type() # Flagging non-supported study types.
    .validate_target(gene_index) # Flagging studies with non-recognised EFOs
    .validate_disease(disease_index) # Flagging QTL studies with unresolved gene ids.
)

The result of all these validations will be collected in the qualityControls column and can be sorted into a failed and passed datasets (.filter(f.size('qualityControls) >0)).
I think we found the right level of abstraction here... I'm quite happy how it turned out.

Disease normalisation

The list of EFOs from the study index are all mapped to our disease index allowing matching to retired ids as well.
The source field is called diseaseFromSourceMappedIds, the mapped field will be called as diseaseIds. Also, the type is a list of strings.
diseaseIds contains all EFOs that could be matched from diseaseFromSourceMappedIds. Meaning some efos might got dropped.
Only those studies will be flagged that would have NO valid EFOs. So, if out of the 3 EFOs in the source list only one can be mapped, that's OK, the study passes the QC.


Method history behavior with no past versions (3.0.92)

If you have no past versions of a method, the method history menu item is enabled, and the method history browser shows up, but while it has two ticks, you cannot move to the first tick.
I would prefer that the menu item be disabled if there is no past history.  It is more informative than having to click, and then it looks like you do have history and just can't get to it.

The background of the method history is also a different shade of yellow, rather more lemony than the warm yellow of the regular text panes.  It clashes.

The extra items method history are still there in 3.2.12, but still not a serious problem.


Simplify contract and contract factory by removing name

Codecov Report

Merging #20 into master will decrease coverage by 1.10%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   96.04%   94.94%   -1.11%
==========================================
  Files           5        5
  Lines         177      178       +1
==========================================
- Hits          170      169       -1
- Misses          7        9       +2

Impacted Files
Coverage Δ

Arbie/Contracts/contract.py
86.66% <92.85%> (-3.66%)
:arrow_down:

Arbie/Contracts/tokens.py
100.00% <100.00%> (ø)

Arbie/Contracts/uniswap.py
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 940b5ee...26a7ff6. Read the comment docs.


/usr/local/bin/awrit: 7: exec: /usr/local/lib/awrit//awrit: not found

I'm on Void Linux (musl). I've built and installed awrit, but get.
/usr/local/bin/awrit: 7: exec: /usr/local/lib/awrit//awrit: not found
when I try to run it.
I tried it in both Kitty and Ghostty.

didn't bother reading everything when building.


[go_router] Add support for ShellRoute to TypedGoRoute

Use case
The class ShellRoute introduced a new way to implement nested navigation using go_router, but lacks the support for its use inside a TypedGoRoute tree.
In the following example the page returned by SettingsPageData contains a locally shared object (such as a Provider) that handles settings state and must be shared by all the sub routes.
Ex.:
@TypedGoRoute<RootPageData>(
  path: '/',
  routes: [
    TypedGoRoute<HomePageData>(
      path: 'home',
      routes: [

        // this should be a ShellRoute
        TypedGoRoute<SettingsPageData>(
          path: 'settings',
          routes: [
            TypedGoRoute<ProfilePageData>(
              path: 'profile',
            ),
            TypedGoRoute<AccountPageData>(
              path: 'account',
            ),
            TypedGoRoute<NotificationPageData>(
              path: 'notification',
            ),
          ],
        ),
      ],
    ),
  ],
)

Proposal
To support ShellRoute and future types of routes with typed routing it could be possible to repeat here the same class hierarchy implemented for GoRoutes.
Ex.:
abstract class RouteBaseData {}

abstract class GoRouteData extends RouteBaseData {...}

abstract class ShellRouteData extends RouteBaseData {...}

class TypedGoRoute<T extends RouteBaseData> {...}

This way go_router_builder can select the correct class to create.
Since ShellRoute is a pathless route it is necessary whether to make the parameter path in TypedGoRoute constructor not required or to move the said hierarchy to TypedGoRoute class
Ex.:
abstract class TypedRouteBase {}

class TypedGoRoute<T extends GoRouteData> extends TypedRouteBase {
  const TypedGoRoute({
    required this.path,
    this.routes = const <TypedRouteBase>[],
  });

  /// The path that corresponds to this rout.
  ///
  /// See [GoRoute.path].
  final String path;

  /// Child route definitions.
  ///
  /// See [GoRoute.routes].
  final List<TypedGoRoute<GoRouteData>> routes;
}

class TypedShellRoute extends TypedRouteBase {
  const TypedGoRoute({
    this.routes = const <TypedRouteBase>[],
  });

  /// Child route definitions.
  ///
  /// See [GoRoute.routes].
  final List<TypedGoRoute<GoRouteData>> routes;
}

duplicates of https://github.com/flutter/flutter/issues/111909


Added buildOptimizer option for the ng serve command

Added the --build-optimizer option to the ng serve command.
With this change you can use ng serve in a production configuration without optimization enabled, which is a lot faster. This can be convenient when doing debugging, of the production configuration. Without this change this is only possible by editing the angular.json file.

@googlebot I signed it!

Hi @Heerschop, thanks for your contribution. But, we would not like to add this atm.
In fact we want to remove more build related options for the dev server builder.
Let’s continue the discussion here: https://github.com/angular/angular-cli/issues/17473


Cannot delete a Resource from my project

Opened my project
Tried to remove a resource (not assigned to any task) from the project in the Resource tab (selected resource and pressed delete)
Got the attached error.
Tried 2 different resources, same result.
If this isn't possible due to database constraints, then the delete function shouldn't be available

.

Hello same issue :)


Fail fast and loud when build directory doesn't exist

I spent 5 hours last night debugging a production deploy that kept throwing the dreaded
application.css not in asset pipeline

This morning I realized that I had deleted app/assets/builds from the repo while thrashing around. That's not a problem in development, because it gets recreated (it does require a server restart). However, in production, there's no indication that anything went awry. rake assets:precompile runs, everything seems fine. You don't notice anything is wrong until you hit the application in the browser. Then you end up Googling for hours and realizing you've done something so incredibly wrong that most people don't do that 😄
I was wondering if it would be possible/preferable to throw a big fat error in production when that directory doesn't exist? Or possibly just create the directory if it doesn't exist.

Hello, I resolved this issue in this way:
moved the javascript folder to the assets folder, and add this line to the manifest.js:  //= link application.js. It worked.

Building just delegates to the build command used by the individual libraries. So if they're failing silently, that's a difficult one to change. But we can add a note to the README.

https://github.com/rails/cssbundling-rails/commit/f4977d5514f097c3bc9884685e42e926a032e3a5


Better support for Mach-O MH_OBJECTs and archive libraries

Universal Binary FileSystem is now aware of archive libraries
Mach-O loader can now handle empty segment names (using @leonardkoenig 's fix)

Fixes #2702

Merged for 9.2.3

Fixed by 49bb112


background-attachment: fixed doesn't seem to work

Hi,
I have an issue creating a parallax scrolling website using the background-attachment: fixed; element. The issue I have is that when you scroll down, the image I placed using background: url() doesn't appear on larger HiDPI screens but works on MDPI screens.

The empty white space should have an image there but doesn't. I narrowed it down to the .mdl-layout class and disabling both display: flex and display: webkit-flex.
Is there a way to fix this?
I'm on an Acer 720 Chromebook running 46.0.2490.71 beta (64-bit) and also doesn't seem to work on different browsers and on other laptops (Macbook Air)

Please use StackOverflow for implementation support. This issue tracker is only for core MDL issues.


Web - Emoji cannot be selected from chosen section using keyboard keys

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Issue found when executing PR https://github.com/Expensify/App/pull/16399
Action Performed:

Go to https://staging.new.expensify.com/
and login
Open any chat
Open a chat and open the emoji menu
Using Tab and Shift+Tab select emoji section, press Enter
Emoji from chosen section are displayed
Press Down Arrow key or try tabbing to emojis to select an emoji

Expected Result:
User expect that chosen emoji section stays on the screen so he/she an pick an emoji
Actual Result:
After pressing Down Arrow key or tabbing to emojis I see all emojis are scrolled up to the top again, so I have to go through the whole list again
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number: 1.2 92.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/93399543/228688094-c7dde5e4-f619-4d92-a5a8-79031507ec78.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

[ ] This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
[ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)

If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead

[ ] This bug is reproducible using the reproduction steps in the OP. S/O

If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
If the reproduction steps aren't clear and you determine the correct steps, please update the OP.

[ ] This issue is filled out as thoroughly and clearly as possible

Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.

[ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

So I think this is more of an accessibility issue we run into during the PR and since we do not treat those as of now, we decided to more on. I would close this for now until we will more generally try to fix such accessibility bugs


🐛 [Bug] Unable to compile DPT Midas depth estimation model using Torch-TensorRT.

Bug Description

I am trying to compile DPT-Hybrid depth estimation model using Torch-TensorRT. However, when I try to compile the traced DPT model using torch_tensorrt.compile. I get the following error
Code snippet
import torch_tensorrt

trt_model_fp32 = torch_tensorrt.compile(traced_model, inputs = [torch_tensorrt.Input((1, 3, 384, 512), dtype=torch.float32)],
    enabled_precisions = torch.float32, # Run with FP32
    workspace_size = 1 << 22)

Error
RuntimeError: [Error thrown at core/conversion/var/Var.cpp:136] Expected isITensor() to be true but got false
Requested ITensor from Var, however Var type is c10::IValue

See below, for full error trace.
To Reproduce
Steps to reproduce

Clone the repo and download the weights

git clone https://github.com/isl-org/DPT
wget https://github.com/intel-isl/DPT/releases/download/1_0/dpt_hybrid-midas-501f0c75.pt

Install TensorRT (<IP_ADDRESS>) and python packages for Torch-tensorRT (1.4.0)
Install all the required dependencies for DPT (basically torch and timm)
Run the following code

import torch
import util.io

import torch_tensorrt
from dpt.models import DPTDepthModel
from dpt.midas_net import MidasNet_large

model_weights = 'weights/dpt_hybrid-midas-501f0c75.pt'
model_type = 'dpt_hybrid'
net_w = net_h = 384

model = DPTDepthModel(
    path=model_weights,
    backbone="vitb_rn50_384",
    non_negative=True,
    enable_attention_hooks=False,
)
model.eval()
model.to(device)
traced_model = torch.jit.trace(model, [torch.randn((1,3,384,512)).to("cuda")])

trt_model_fp32 = torch_tensorrt.compile(traced_model, inputs = [torch_tensorrt.Input((1, 3, 384, 512), dtype=torch.float32)],
    enabled_precisions = torch.float32, # Run with FP32
    workspace_size = 1 << 22

Expected behavior

I was hoping it would compile like the simple ResNet example.
Environment

Build information about Torch-TensorRT can be found by turning on debug messages

Torch-TensorRT Version (e.g. 1.4.0):
PyTorch Version (e.g. 2.0.1):
CPU Architecture: x86_64
OS (e.g., Linux): Ubuntu 20.4
How you installed PyTorch (conda, pip, libtorch, source): pip3 install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/cu118
Python version: 3.9.17
CUDA version: 11.8
GPU models and configuration: RTX4090

Full error trace
---------------------------------------------------------------------------
RuntimeError                              Traceback (most recent call last)
Cell In[14], line 3
      1 import torch_tensorrt
----> 3 trt_model_fp32 = torch_tensorrt.compile(traced_model, inputs = [torch_tensorrt.Input((1, 3, 384, 512), dtype=torch.float32)],
      4     enabled_precisions = torch.float32, # Run with FP32
      5     workspace_size = 1 << 22
      6 )

File [~/miniconda3/envs/torch_tensorrt/lib/python3.9/site-packages/torch_tensorrt/_compile.py:133](https://vscode-remote+ssh-002dremote-002b192-002e168-002e68-002e62.vscode-resource.vscode-cdn.net/home/aayush/Projects/TensorRT_Examples/DPT/~/miniconda3/envs/torch_tensorrt/lib/python3.9/site-packages/torch_tensorrt/_compile.py:133), in compile(module, ir, inputs, enabled_precisions, **kwargs)
    128         logging.log(
    129             logging.Level.Info,
    130             "Module was provided as a torch.nn.Module, trying to script the module with torch.jit.script. In the event of a failure please preconvert your module to TorchScript",
    131         )
    132         ts_mod = torch.jit.script(module)
--> 133     return torch_tensorrt.ts.compile(
    134         ts_mod, inputs=inputs, enabled_precisions=enabled_precisions, **kwargs
    135     )
    136 elif target_ir == _IRType.fx:
    137     if (
    138         torch.float16 in enabled_precisions
    139         or torch_tensorrt.dtype.half in enabled_precisions
    140     ):

File [~/miniconda3/envs/torch_tensorrt/lib/python3.9/site-packages/torch_tensorrt/ts/_compiler.py:139](https://vscode-remote+ssh-002dremote-002b192-002e168-002e68-002e62.vscode-resource.vscode-cdn.net/home/aayush/Projects/TensorRT_Examples/DPT/~/miniconda3/envs/torch_tensorrt/lib/python3.9/site-packages/torch_tensorrt/ts/_compiler.py:139), in compile(module, inputs, input_signature, device, disable_tf32, sparse_weights, enabled_precisions, refit, debug, capability, num_avg_timing_iters, workspace_size, dla_sram_size, dla_local_dram_size, dla_global_dram_size, calibrator, truncate_long_and_double, require_full_compilation, min_block_size, torch_executed_ops, torch_executed_modules, allow_shape_tensors)
    112     raise ValueError(
    113         f"require_full_compilation is enabled however the list of modules and ops to run in torch is not empty. Found: torch_executed_ops: {torch_executed_ops}, torch_executed_modules: {torch_executed_modules}"
    114     )
    116 spec = {
    117     "inputs": inputs,
    118     "input_signature": input_signature,
   (...)
    136     "allow_shape_tensors": allow_shape_tensors,
    137 }
--> 139 compiled_cpp_mod = _C.compile_graph(module._c, _parse_compile_spec(spec))
    140 compiled_module = torch.jit._recursive.wrap_cpp_module(compiled_cpp_mod)
    141 return compiled_module

RuntimeError: [Error thrown at core/conversion/var/Var.cpp:136] Expected isITensor() to be true but got false
Requested ITensor from Var, however Var type is c10::IValue

Can you enable debug logging and share the logs? This would help us determine the root cause

Hi @garg-aayush - thanks for the report. With a small change to the DPT model (adding int casts here), I was able to trace and begin model compilation using the latest main of Torch-TRT.
I am able to reproduce the error you describe, and the problematic operator seems to be aten::upsample_bilinear2d.
A temporary workaround which makes compilation functional on my machine is to add these two lines to the compilation:
trt_model_fp32 = torch_tensorrt.compile(model, inputs = [torch_tensorrt.Input((1, 3, 384, 512), dtype=torch.float32)],
    enabled_precisions = torch.float32, # Run with FP32

##### Added the below:
    torch_executed_ops = ["aten::upsample_bilinear2d"],
    truncate_long_and_double = True,

@bowang007 @gs-olive Thank you for the reply. I made the suggested changes. However, I am getting the following error now.
Note, I am working with latest Torch TensorRT (1.4.0).
Error
RuntimeError: [Error thrown at core/conversion/conversionctx/ConversionCtx.cpp:169] Building serialized network failed in TensorRT

Code
import torch
from dpt.models import DPTDepthModel
import torch_tensorrt

# select device
device = torch.device("cuda" if torch.cuda.is_available() else "cpu")
model_weights = 'weights/dpt_hybrid-midas-501f0c75.pt'

model = DPTDepthModel(
    path=model_weights,
    backbone="vitb_rn50_384",
    non_negative=True,
    enable_attention_hooks=False,
)
model.eval()
model.to(device)

with torch_tensorrt.logging.debug():
    traced_model = torch.jit.trace(model,
                                    [torch.randn((1,3,384,512)).to("cuda")]
                                    )
    trt_model_fp32 = torch_tensorrt.compile(
        traced_model,
        inputs = [torch_tensorrt.Input((1, 3, 384, 512), dtype=torch.float32)],
        enabled_precisions = torch.float32, # Run with FP32
        workspace_size = 1 << 22,
        torch_executed_ops = ["aten::upsample_bilinear2d"],
        truncate_long_and_double = True,
        )

I am attaching the full debug log for your reference.
debug_log.txt

Hi @garg-aayush, with your provided output, I am able to reproduce the error. Based on this line in the debug logs:
ERROR: [Torch-TensorRT TorchScript Conversion Context] - 4: Could not find any implementation for node {ForeignNode[%15 : Tensor = aten::flatten(%8, %16, %17) # /home/aayush/Projects/TensorRT_Examples/DPT/dpt/vit.py:188:0 + %x.167 : Tensor = aten::transpose(%15, %44, %16) # /home/aayush/Projects/TensorRT_Examples/DPT/dpt/vit.py:188:0...(Unnamed Layer* 40) [Shuffle]]} due to insufficient workspace. See verbose log for requested sizes.

It seems that the workspace_size is insufficient for one of the operations. Could you try the run again and omit the line workspace_size = 1 << 22, from compilation? With this omission, the model compiles successfully on my machine.

Hi @gs-olive, Thanks! It works now.
However, one more question. I am trying to compile with float16/half. It compiles fine. However, when I run the inference. I get this weird error
Expected input tensors to have type Half, found type float

I saw in #1853 that you guys have fixed it. Am I correct? Do I need to upgrade my Torch TensorRT for it?

Hi @garg-aayush - sounds good. Regarding the error, the fix in #1853 is still in progress and has not yet been merged. It is intended to address issues like the one you describe.

I will wait for the merge. Thanks a lot for the help!


Add browse folder and browse file icons

Adds the missing "browse folder" and "browse file" icons and replaces the "Browse" text button of the ProjectDialog, and the FBXImporterManager to an icon button.
New icons:  and
I opened the folder icon in Inkscape ( editor/icons/Folder.svg), created circles of 1px of radius, then created an outline of 1px. Subtracted the outline from the folder icon.

Before
After

*typo fixed (added a period)

Relates to #88825
Edits

2024-02-26

Added the "browse file" icon
Added the browse file to the FBXImporterManager dialog.
Added the browse folder to the EditorFileSystemImportFormatSupportQueryBlend dialog.

This one requires a lot more spacing as it's not grid-aligned and not multicolored.

I added more space between the dots and the icon (moved from 1px to 1.5px).
And I added the browse file icon!

I added the browse folder icon to the EditorFileSystemImportFormatSupportQueryBlend dialog. This should wrap up all the "browse" buttons.

Could you try adding it here too?
https://github.com/godotengine/godot/blob/bb6b06c81343073f10cbbd2af515cf0dac1e6549/editor/editor_resource_picker.cpp#L197-L201

Could you try adding it here too?
https://github.com/godotengine/godot/blob/bb6b06c81343073f10cbbd2af515cf0dac1e6549/editor/editor_resource_picker.cpp#L197-L201

I don't think this PR obsoletes the load logo . I think that this PR means to replace the "Browse" text buttons, which don't load/open by themselves files, but only sets the path in the field.

True, this case here is still more a browse as it assigns a resource from a load, not opens it for editing as such

It's in the inspector, when you have a resource

@AThousandShips But this replaces the current resource, effectively loading it.

It loads it in the sense that it opens it in memory, but the main purpose is to replace the resource there, so I'd say it's the same as browsing for a file path, but it was just an idea :)

Should we use this icon for file properties in EditorInspector (e.g. in the Editor Settings)?

Should we use this new icon for file/directory properties in EditorInspector (e.g. in the Editor Settings)?

@Calinou Done! See the updated images on the PR description.

@Mickeon @MewPurPur @akien-mga Following this comment, I added back text labels for the "create project" dialog, the Blender dialog and the FBX dialog. See the PR description for the updated images.

Thanks!


v0.58.0 Autorun for  PowerToys task does not run

Microsoft PowerToys version
0.58.0
Running as admin

[X] Yes

Area(s) with issue?
General
Steps to reproduce
Although the "Run at startup" toggle definitely creates (1) and removes (0) the PowerToys task to "Run only when user is logged on":

the task never actually runs, and PowerToys do not start when user logs on:

I don't see this specific report for v0.58.0, or earlier versions. This may explain other reports, like "FancyZones" not available at startup or logon.
✔ Expected Behavior
scheduled logon task executes and PTs are ready once user logs on
❌ Actual Behavior
doesn't happen. PT logon task never runs, PTs do not start.
Other Software
No response

It may be connected to "compatibility" properties of PowerToys.exe, which has "Run this program as an administrator" toggle on after a clean install. If PowerToys is not set to run always as administrator, then the logon task resets itself to run without highest privileges.
This may cause a conflict of privileges.

The executable compatibility mode is "administrator"
The scheduled PowerToys task is not set for highest privileges
so when the task runs, the result is "The requested operation requires elevation. (0x800702E4)"
As a result the powertoys do not start at use logon.

OK - I updated my original report. I think I had not set PT to "Always run as administrator".
In this case (setting OFF for "always run as administrator"), I think the PowerToy logon task fails due to the PowerToys.exe compatibility mode default activation of "Run this program as an administrator". That's apparently a conflict between task action to start that program (which tries to start as admin for compatibility) and the task, which should run just as a user (without highest privileges).
If I toggle OFF this default compatibility mode ("C:\Program Files\PowerToys\PowerToys.exe" properties), then the startup at logon task completes successfully without running as admin.
I'll avoid running PT always as admin, until I detect some reason for higher privilege.
For now, startup seems to work, but only because I manually toggle OFF that exe compatibility property after a clean install or PT 0.58.0.

Yes, it's failing because if the Task Scheduler is not set to try to run as an administrator, the compatibility mode trying to run it as an administrator will fail due to having no priveleges. Thank you for the added information.

If the deployment of PowerToys runs with a tool which uses a service account, the run task is created for that useraccount. Which makes no sense. How the creation of thes run task can be avoided during installation?


Support Cloud Resources

Allow users to supply cloud resources for storage

Supported for DoltLab Enterprise in v2.1.6


startup / dispose hooks?

Hello,
I like to initialize a db connection on startup and also close this connection when the dev server reloads. Is there a way to hook into this? Thought of import.meta.hot, but that does not work. Also I couldn't find a Signal to listen to like process.on('SIGTERM'...
thanks in advance

Okay so we need hooks for startup, dev-server-reload, SIGTERM. Let me see how I can provide these. What do you mean by startup exactly?

@nksaraf  thanks for your quick answer!
I think a startup hook is not necessarry (at least for me) when it's not considered "bad practice" to simply execute code in the global scope of a file (e.g. establish a database connection).
My specific use case at the moment is a device that is connected to the server via a serial port. Before the dev server reloads, I have to disconnect the port so it's not busy when the script gets executed again.
I'm trying out the new solid start beta 2, but I think this is the repo where such functionality has to be implemented, right?

Yup yup! Okay so a hook into when the dev server reloads, sure ill come up with something

Great! Looking forward to what you come up with 😉 Thanks!

I think a startup hook is not necessarry (at least for me)

Imho the startup/dispose hooks would be very useful, especially to handle long running processes like websockets 😅. And Reload could be an own hook, or even a chained dispose->startup call 🤔

I have added some hooks to the dev server in vinxi:0.0.57. So you can hook into things by calling app.hooks.hook("...", () => {... }).
You can checkout the order of hooks here. Each hooks also comes with some data like an instance of the app, along with the dev server, etc.

Inside your application you can access the app via globalThis.app. I might create a helper function for this but ideally don't want this exposed too much yet until we know what might people do with it.

thanks @nksaraf , this looks promising... but I'm actually not sure how to use those hooks.
Maybe you could have a look at this demo repo: https://github.com/Torsten85/vinxi-hooks
Im trying to make a connection on startup (ideally before using a server function) and closing the connection on dev server reload. None of the hooks get called when I e.g. change a line in my ./app/db.ts file.


Test workflows should only run on dist or workflow changes

If a change does not impact the dist directory, then it can have no impact on most test workflows.

Fixed in 72e45fe25be01a488e23ab134e363faf46450a6c


docs: update all-contributors badge to new version

It is better to use new version of all-contributors badge.
ref https://allcontributors.org/docs/en/bot/faq

Thank you @tkoyama010! 🙏 You are the best 🙇


Attempted import error: 'Routes' is not exported from 'react-router-dom'.

import React from 'react';
import './App.css';
import { BrowserRouter, Routes , Route } from 'react-router-dom'
import Header from './components/Header'
import Home from './components/Home'
import Products from './components/Products'

function App() {
  return (
    <BrowserRouter>

        <Routes>
          <Route path='/' element={<Home />}></Route>
          <Route path='products' element={<Products />}></Route>
        </Routes>

    </BrowserRouter>
  );
}

export default App;

I'm trying to use react routes and it says import error

Make sure you're using React Router v6.

@timdorr  React Router v6 is still in beta . Do you suggest using that in a production grade app.
I see that 5.2.0 has been inconsistent and breaking for all major versions of node.  At first I though this to be a node-version compatibility issue since I was using latest LTS. V6 works fine in my case but I am wary of using it in production.
How to get around this?
I also couldn't find the schedule for the stable release of V6.

v5 is working just fine for all versions of Node and browsers they we know about. I'm not sure where you're getting that impression, but it's in use by many very popular applications (Twitter, for instance) as we speak.

I get you but in my case I get below error no mater what I try. Only the V6 beta seems to work.

import logo from "./logo.svg";
import "./App.css";
import { Routes, BrowserRouter as Router, Route } from "react-router-dom";
import { Home, GetDetails, NotFound } from "./pages";
import { Provider } from "react-redux";

function App() {
  return (

      {/* <Provider> */}
      <BrowserRouter>
      <Routes>
        <Route path="/" element={<Home />} />
        <Route path="app-2/element-details" element={<GetDetails />} />
        <Route path="*" element={<NotFound />} />
      </Routes>
      </BrowserRouter>
      {/* </Provider> */}

  );
}

export default App;

import logo from "./logo.svg";
import "./App.css";
import { Routes, Router, Route } from "react-router-dom";
import { Home, GetDetails, NotFound } from "./pages";
import { Provider } from "react-redux";

function App() {
  return (

      {/* <Provider> */}
      <Routes>
        <Route path="/" element={<Home />} />
        <Route path="app-2/element-details" element={<GetDetails />} />
        <Route path="*" element={<NotFound />} />
      </Routes>
      {/* </Provider> */}

  );
}

export default App;

Using 5.2.0, none of the above works for me. I get same error in both cases.
My package.json:

    "react-router": "^5.2.0",
    "react-router-dom": "^5.2.0",

I'm really not getting the essence. Nothing seems to work.

You're attempting to use the v6 API with v5. Routes is new in v6. You are getting that error because it doesn't exist in older versions.

Thanks for the guidance. I'll make the changes.


Position Edge Case: Index Error

module ch.fhnw.thga.IndexError where

native sayHello = sayHello

This code leads to an error message with a token position col == 0, which violates the spec that the col index is 1-based.
https://github.com/Frege/frege/blob/cbe4ce8fb87fb93246d4eaa47c0062b6cd9c205f/frege/compiler/types/Tokens.fr#L10-L11
As a result, I need to handle this edge case because the precondition that LSPColumnPosition = col - 1 (Since LSP indices are 0-based) is violated and leads to -1 character positions, as shown in the following debug log:
Since the LSP Position type is 0 I end up with
{
    "range": {
        "start": {
            "line": 3,
            "character": -1
        },
        "end": {
            "line": 3,
            "character": 0
        }
    },
    "severity": 1,
    "source": "frege compiler",
    "message": "syntax error, native generic type arguments cannot\nstart with ';'"
}

This then breaks VSCode, which drops not only the faulty error message but all errors and warnings for the affected file.

Possible Fix:
Ensure here:
https://github.com/tricktron/frege-lsp-server/blob/13fbb7cefcead210b6f260fed314840d02e8da89/src/main/frege/ch/fhnw/thga/fregelanguageserver/diagnostic/Diagnostic.fr#L34
and here:
https://github.com/tricktron/frege-lsp-server/blob/13fbb7cefcead210b6f260fed314840d02e8da89/src/main/frege/ch/fhnw/thga/fregelanguageserver/diagnostic/Diagnostic.fr#L44
That the col index is always >= 1 (1-based).

Reminder: Add a test case for the edge case.


Cypress. Fix some tests. Rework margin.

Motivation and context
Several tests failed with an error in nightly CI. This patch is intended to solve the issue.
How has this been tested?

Checklist

[x] I submit my changes into the develop branch
[ ] I have added description of my changes into CHANGELOG file
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[ ] I have linked related issues (read github docs)
[ ] I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

[x] I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
[x] I have updated the license header for each file (see an example below)

# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Coverage increased (+0.02%) to 75.177% when pulling 0d06de57bf221ca5828bbf908a7fbd7d55fc7f8e on dvkruchinin:dkru/cypress-test-fix-case-51 into 476bd7634888744861f8b117cfc22583e7d04aa5 on openvinotoolkit:develop.


fixed bug of not found text

Closes #189

Proposed Changes

Check List (Check all the applicable boxes)

[ ] Bug(s) fixed
[ ] Enhancement done
[ ] New Feature(s) added
[ ] Documentation changed
[ ] All new and existing tests passed.
[ ] My code follows the code style of this project.

Screenshots (if any)
https://github.com/group-patronage/group-patronage/assets/93243210/7acec4d8-2368-4fcf-933c-cb14e16a4d0f
Additional Information

@LakshaySK106  please review my PR


Tap to view: could be success could be failure

We get the above notification, but  it could mean two things:
Success, or failure. In this case it just happens indicate failure. Why not be more clear in the message?

PS, I tried to edit the image to crop it, but Github said the crop file size was too big. Hohoho.

I believe it changes to "Tap to view your upload" in case of success.

Well even so, the failure case still would need to be reworded to make it clear it failed.

The issue is likely to be seen on devices with large font sizes.
The actual notification reads: Uploading filename failed.
And as we see the failed part is not visible.
We can refractor the notification to something on the lines of Failed to upload filename.
Thanks, @jidanni.

@nicolas-raoul  I would like to work on this issue please assign me


Small Checkbox and Radio

For non-public-facing UK gov systems smaller sized input elements, especially checkbox and radio components, are often supported.  Examples of these can be found in the Home Office Design System:
https://home-office-digital-patterns.herokuapp.com/components/checkboxes
https://home-office-digital-patterns.herokuapp.com/components/radios
We should consider ways of adding support for such customisation.
There are potentially three options here:

Add a small prop that supports a (fixed) small size to these components
Add support for theming (see #578), and use that to support size variations
Have the atom (un-labelled checkbox/radio) exported from the component and used via a prop, allowing it to be re-styled

Or potentially some combination of all three options.

Home Office sass files with these alternate designs can be found here:
https://github.com/UKHomeOffice/design-system/tree/master/app/assets/sass/components

govuk-frontend now provides small radio options:
https://design-system.service.gov.uk/components/radios/small/index.html

I have developed an update for this . I have also added type support as noticed Size is something we use for many elements
Can someone please review my PR?
https://github.com/govuk-react/govuk-react/pull/1193


add plausible analytics

@pavithraes I'm merging this on my own to have the analytics now. Let's revert if you disagree.

Can confirm that the analytics is working. I see that there is also an option to add a feedback widget: https://material-plausible-plugin.ale.sh/#feedback-widget. Not sure if we want that, but open to discuss.


SW-5967 Limit application restart states

#2384  👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tommylau523 and the rest of your teammates on  Graphite

Merge activity

Sep 6, 2:03 PM EDT: @tommylau523 merged this pull request with Graphite.


Add max concurrent running task tests

Also do not allow lock/unlock in async code,  just for safety.

This PR fixes - Issue 9


Update vagrant to 2.0.1

After making all changes to the cask:

[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] The commit message includes the cask’s name and version.

Duplicate of https://github.com/caskroom/homebrew-cask/pull/40271

Just noticed there is already https://github.com/caskroom/homebrew-cask/pull/40271 and vagrant 2.0.1 is breaking at the moment


Upload image to remote server with org.apache.cordova.camera

Hi,
Any idea to upload  image to remote server with org.apache.cordova.camera

Have you tried to use the destinationType: Camera.DestinationType.DATA_URL?

Yeah, Found a way out. Thanks any way.
On Mon, Jul 6, 2015 at 8:31 AM, Moritz Post<EMAIL_ADDRESS>wrote:

Have you tried to use the destinationType: Camera.DestinationType.DATA_URL
?
—
Reply to this email directly or view it on GitHub
https://github.com/eclipsesource/tabris-js/issues/513#issuecomment-118774683
.

@ruarch Good to hear you solved the issue. What approach did you take?

I used the destinationType: window.Camera.DestinationType.DATA_URL
onSuccess, I post the data to a server side php script to write the data into an image file

var button = tabris.create("Button", {
layoutData: {left: 10, top: 10, right: 10},
id:"picturebtn",
text: "Take a picture"
}).appendTo(page).on("select", function() {
navigator.camera.getPicture(onSuccess, onFail, {
quality: 50,
targetWidth: 1024,
targetHeight: 1024,
destinationType: window.Camera.DestinationType.DATA_URL
});
function onSuccess(imageData) {
$.post( "http://<IP_ADDRESS>/apiserver/upload.php", {data: imageData}, function(data) {
imageView.set("image", {src: data});
});

Cool. Thanks for adding the snippet.


form.TableSection won't show Edit button

set an element to GridSection, and rows get Edit buttons.
GridSection inherits from TableSection. Yet TableSection does not show Edit buttons. GridSection has:
	/** @private */
	renderRowActions: function(section_id) {
		return this.super('renderRowActions', [ section_id, _('Edit') ]);
	},

How can I get Edit buttons (by default) without using .extedit?
fao @jow-

You can't. If you want a Table layout with an edit button, use a GridSection. That's its entire purpose - it extends TableView with a per-row edit capability.


chore(deps): update verdaccio-audit to fix express version

Type: chore
The following has been addressed in the PR:

There is a related issue? Not directly, but it is the same described in #1484, in this case, for 4.x version
Unit or Functional tests are included in the PR No

Description: Rollback express 4.18.0 to 4.17.1, introduced by verdaccio-audit plugin

I will add invalid due to Hacktoberfest track problem. After I complete the challenge I will remove it :wink:


python310Packages.afsapi: 0.2.0 -> 0.2.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python310Packages.afsapi is: "Python implementation of the Frontier Silicon API"
meta.homepage for python310Packages.afsapi is: "https://github.com/wlcrs/python-afsapi"
meta.changelog for python310Packages.afsapi is: ""
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS

Warning: a test defined in passthru.tests did not pass

0 of 0 passed binary check by having a zero exit code.

0 of 0 passed binary check by having the new version present in output.

found 0.2.1 with grep in /nix/store/rhi4jwb3h3cd47sbpm62i5xmfrw05waq-python3.10-afsapi-0.2.1

found 0.2.1 in filename of file in /nix/store/rhi4jwb3h3cd47sbpm62i5xmfrw05waq-python3.10-afsapi-0.2.1

Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 x86_64-darwin rebuild(s)

First fifty rebuilds by attrpath
python310Packages.afsapi
python39Packages.afsapi

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/rhi4jwb3h3cd47sbpm62i5xmfrw05waq-python3.10-afsapi-0.2.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python310Packages.afsapi https://github.com/r-ryantm/nixpkgs/archive/f5dfef02b93f8e51d393b22c631d21e8a204294a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/rhi4jwb3h3cd47sbpm62i5xmfrw05waq-python3.10-afsapi-0.2.1
ls -la /nix/store/rhi4jwb3h3cd47sbpm62i5xmfrw05waq-python3.10-afsapi-0.2.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

python310Packages.afsapi
python39Packages.afsapi

Maintainer pings
cc @fabaff for testing.

@ofborg eval


Add context to all callbacks

Version: 3.x-feature
Original reporter:
Continue bug#66.
Another example is the mxmlSetErrorCallback() which has no context assigned. It would be much easier to use if there is ability to set some void* context.
Also, I am not sure I understand why the error callback is thread specific.
This kind of library usually needs no global context. First argument of every function may provide the necessary context.
For the error callback, except of context it would be nice to get a details of the object that caused the error, or have a separate callback for errors during parsing. For example, if I parse 3 XML I want to present a different messages for each [without using globals].
Thanks

Not for 3.0...

This is now part of Git master for 4.0.


Update header

Move Powered by Granola to footer
Make Granola link the "link" color (so it is obvious it is a link without hovering)
Remove Mina Blockchain Explorer
Change search placeholder text to: Paste > Enter > Explore the Mina blockchain

Could be separated into multiple issues.


Add fix for nightly build

The Problem:
This is a fix for #365. The nightly build failed due to the docker network not being set up.
The Fix:
This PR adds the "ddev_default" network before running the servicetest group. Additionally, it failed more gracefully in the event that the network is not set up.

I enabled builds on my fork and am currently running the nightly build against this PR.

Looks like we got a nightly build pass! I also needed to update this PR to add -p 1 to the package tests. The servicetest package introduces a second set of tests which use docker. This caused tests to be running at the same time, and the ddev list tests were failing because of it. My best guess is there could have been other interactions as well, but I think reducing test parallelization is probably acceptable.
We should definitely compare test run times before merging this though, to make sure it's not a significant increase.

I just pushed a tag to my fork as I expect it will fix the failure for updatecheck. :crossed_fingers:


Route::controller doesn't exist

Laravel Version: v8.73.2

Description: In the laravel document, I see route controller as below, but i can't find out function in laravel router.

Hey there,
Unfortunately we don't support this version anymore. Please check out our support policy on which versions we are currently supporting. Can you please try to upgrade to the latest version and see if your problem persists? If so, please open up a new issue and we'll help you out.
Thanks!


Cursor: text

From @colmtuite

Inputs and textareas on marketing screens, auth screens and general app UI (hardcore product UIs can be special-cased) should have cursor: text.

I think the inputs in the App are better when the cursor is default instead of text. It gives it that native feel, which I think is appropriate.
We can approach this in a few different ways:

Introduce a variant which controls the cursor type
Have all the inputs with cursor:text
Override this behaviour globally from the App Global CSS

@colmtuite Do you have any preference?
I think if we think we'll have a few components that need a special treatment in the app environment, we could go with option 1 and make this variant consistent across all said components. Could be a variant named uiType which could be website or webapp. We can choose to default to the one where Radix will be used the most.
Just throwing some ideas out there.
Any thoughts?
/cc @benoitgrelard @vladmoroz

@peduarte I personally like the variant option, it's the cleanest and achieves what we want to do. Other options don't spark joy to me 🤔
Another suggestion: we'll be looking soon into a specialised editor input component of sorts – the one that presumably handles arrow keys, selection on focus, discard on Escape, all this stuff that is specific to cool apps for real proz™. We can handle it from there, be it custom styles just for that component or a variant.


Models remain resident in VRAM after deletion

What is the issue?
I downloaded the wrong model, ran it, realized my mistake, then deleted it, and noticed it was still listed as being present in VRAM according to ollama ps.
$ ollama ps
NAME            ID              SIZE    PROCESSOR       UNTIL
yi:9b-v1.5-q8_0 6ea05582d5ca    10 GB   100% GPU        4 minutes from now
$ ollama rm yi:9b-v1.5-q8_0
deleted 'yi:9b-v1.5-q8_0'
$ ollama ps
NAME            ID              SIZE    PROCESSOR       UNTIL
yi:9b-v1.5-q8_0 6ea05582d5ca    10 GB   100% GPU        4 minutes from now
$ nvidia-smi
Wed May 15 02:48:11 2024
+---------------------------------------------------------------------------------------+
| NVIDIA-SMI 535.171.04             Driver Version: 535.171.04   CUDA Version: 12.2     |
|-----------------------------------------+----------------------+----------------------+
| GPU  Name                 Persistence-M | Bus-Id        Disp.A | Volatile Uncorr. ECC |
| Fan  Temp   Perf          Pwr:Usage/Cap |         Memory-Usage | GPU-Util  Compute M. |
|                                         |                      |               MIG M. |
|=========================================+======================+======================|
|   0  NVIDIA GeForce RTX 3090        Off | 00000000:01:00.0 Off |                  N/A |
|  0%   50C    P8              24W / 420W |   9588MiB / 24576MiB |      0%      Default |
|                                         |                      |                  N/A |
+-----------------------------------------+----------------------+----------------------+

+---------------------------------------------------------------------------------------+
| Processes:                                                                            |
|  GPU   GI   CI        PID   Type   Process name                            GPU Memory |
|        ID   ID                                                             Usage      |
|=======================================================================================|
|    0   N/A  N/A     63185      C   ...unners/cuda_v11/ollama_llama_server     9582MiB |
+---------------------------------------------------------------------------------------+

OS
Linux
GPU
Nvidia
CPU
AMD
Ollama version
0.1.38

As noted in the output of ps it will unload after 5 minutes by default (looks like you had about 4 minutes remaining.)  We'll also unload an idle model if we need the VRAM for loading other models automatically, so you can safely pull and run the model you actually wanted to load.
If you upgrade to the latest version, you can use ollama.exe run yi:9b-v1.5-q8_0 --keepalive 0 "" to quickly trigger an unload.

I agree with what you said in general, but it is still surprising behavior, and if you're using the GPU for other things besides ollama... there is a window of opportunity for the surprising behavior to cause an OOM for whatever other application is trying to load a model into VRAM.


update limitlessled to 1.0.2 (#3541)

Description: 	update limitlessled to 1.0.2
This version of limitlessled handles transitions to the same color/brightness
Related issue (if applicable): fixes #3541
Checklist:
If code communicates with devices, web services, or a:

[x] Local tests with tox run successfully. Your PR cannot be merged unless tests pass
[x] New dependencies have been added to the REQUIREMENTS variable (example).
[x] New dependencies are only imported inside functions that use them (example).
[x] New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

Duplicate of https://github.com/home-assistant/home-assistant/pull/3552 :)


Aws code deploy failed on instance launched using autoscaling group.

When I am trying deploy application code using aws codepipeline getting script failed error on the instance launched using autoscale group.Previously when I used only one instance it gave success.But now I added this asg instance for the deployment one at a time,

I have only aws cli version ie.latest 2.

@rjshk013 running into this same issue. Any feedback on how you moved past this, if you did?


added TCP message following CoAP TCP draft

https://tools.ietf.org/html/draft-tschofenig-core-coap-tcp-tls-02

this is a first step, the next step is probably to change interface in server/client to be able to use the same handler with both UDP & TCP (use net.Conn and net.Addr vs net.UDPConn and net.UDPAddr)

Thanks, applied.


chore: Upgrade deps

Upgrade needed in particular to make jx gitops commands used in pipelines and Makefile.mk accept reusePullRequest field for environments.

/assign ankitm123


Ignore top level descriptions on json import

Is your feature request related to a problem? Please describe.
The w3c specs allow descriptions in groups (not tied to a specific token). Currently figma tokens imports those as "other" tokens. However I think it would be neat to ignore them (or allow the user to set a flag to ignore them).
Describe the solution you'd like
Since the token name description is define, you could just ignore all descriptions that are not within a token if the ignore group description flag is set.
Example json
{
  "core": {
    "description": "Our brand's core color palette", // ignore
    "white": {
      "value": "#ffffff",
      "type": "color"
    },
    "black": {
      "value": "#191919",
      "type": "color"
    },
    "green": {
     "description": "Brand green", // import to token
      "value": "#29D659",
      "type": "color"
    }
  }
 }

@six7 suggest to merge/close with the DTCG groups issue you are currently working on - labelling as archive.