Execute code in a field before submit

Are you submitting a bug report or a feature request?
Feature request
What is the expected behavior?
I have a custom field (signature field) consisting of a label, a canvas and a hidden input. I'd like to upload the image in the canvas when the user submit the form, then put the url I get back from uploading the image in the hidden field, so that it can be processed like a normal form input.
I can't find a way to detect the submit at the field level to do that.
Any help is appreciated, thanks !
What's your environment?
redux-form 6.7.0

Eh, this is more like a question, which is not suitable to the GitHub issue tracker 🙃
Anyway, here's something I would do:

Set some parse/format to your Field so that you can write to/from a blob string.
This way you don't have to rely on a hidden field and other complicated ideas;
When the form is submitted, upload the blob string (or a binary, or whatever the browser APIs can do with images nowadays) to your server;
Then use the resulting URL to actually proceed to submitting your form.

Thanks a lot for your suggestions ! I managed to save the canvas image in redux-form using the onChange prop, which is way cleaner than using a hidden field.
The point that is unclear to me is where to put the upload part.
I'd like it to be inside the component and not have to rewrite the submit on every form that uses it. Then the submit would just work like usual and send the url of the uploaded image.

That's a pretty common request and I reckon that format and normalize are not enough for every use case, for example:

Convert an input value to float before submit. Values "1", "1." and "1.2" should all work, but with a normalizer, "1." would become 1
Upload a file

These could indeed be done in a custom onSubmit handler but that would make modularisation harder: what if you want to have reusable field groups?
What about an API like the following?
<Field
  component="input"
  type="text"
  name="latitude"
  label="Latitude"
  onSubmitParser={value => Number(value)}
/>
<Field
  component="input"
  type="file"
  name="avatar"
  label="Avatar"
  onSubmitParser={file => upload(file)} // returns a promise and sets `submitting` to true
/>

Problem is: that would probably require the library to store functions in the Redux state,

I don't think this is even possible.
The best I can think for now is that you use a composable set of functions.

Because this issue saw almost no activity for a few months, I'm closing it.

@gustavohenke IMHO, a parseOnSubmit feature in fields is badly needed.


trade_date and strike_price wrongly formatted

Hi,
I just installed datamine_python and downloaded Time and Sales data on crude oil (CL and LO).
It seems that the field trade_date and strike_price are wrongly formatted.
The strike is 3550 where it should be 35.50 and the trade_date always starts in 1970 although these trades are from yesterday.
Cheers,
Viktor

Viktor,
Thank you for bringing this to our attention. The following adjustments have been made to the loader file:
trade_date typing incorrectly -- now types to proper datetime format
entry_date was not typed as date -- now typed as datetime
Please reference the following screenshot, which refers to the same record as you identified:

Note that the strike_price format is correct -- both strike_price & trade_priceare treated asfloat. strike_price` format is in spec with Globex.


unable to correct CUDA vs. JAX version mismatch

CUDA backend failed to initialize: Found cuDNN version 8600, but JAX was built against version 8906, which is newer. The copy of cuDNN that is installed must be at least as new as the version against which JAX was built. (Set TF_CPP_MIN_LOG_LEVEL=0 and rerun for more info.)
how can I deal with this issue?

I guess you might want to update your CUDA and cuDNN versions.


Add RemoveFromClassCommandParser tests

Codecov Report

Merging #266 (54c26c9) into master (9427549) will increase coverage by 0.51%.
The diff coverage is 14.28%.

@@             Coverage Diff              @@
##             master     #266      +/-   ##
============================================
+ Coverage     67.80%   68.31%   +0.51%
- Complexity      763      770       +7
============================================
  Files           127      127
  Lines          2587     2594       +7
  Branches        311      314       +3
============================================
+ Hits           1754     1772      +18
+ Misses          743      728      -15
- Partials         90       94       +4

Impacted Files
Coverage Δ

...commands/classcommands/RemoveFromClassCommand.java
83.72% <14.28%> (-13.51%)
:arrow_down:

...sscommandparsers/RemoveFromClassCommandParser.java
100.00% <0.00%> (+100.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9427549...54c26c9. Read the comment docs.

LGTM


[SOLVED] Hyperion.NG on Docker Hub for arm/Raspberry Pi

Feature request

I know there's containers for actually compiling/cross-compiling Hyperion.NG (https://hub.docker.com/u/hyperionproject), but can this official repository also please provide the current alpha releases for multiple platforms as well? There's a few (outdated) non-official Docker containers with Hyperion.NG out there, but not for all platforms. Currently there's no Raspberry Pi arm version for instance.
What problem does this feature solve?
Super easy installation for anyone running VM/RPi Hyperion setups.
What does the proposed API look like?
N/A
How should this be implemented in your opinion?
Official HyperionNG repo to add containers for all platforms of current pre-releases?
Are you willing to work on this yourself?
Yes, but I'm not a coder. Am able to happily test any RPi arm7 containers.

Hi. First off, big fan of the project so thank you and keep up the great work!
To clarify, yes, I am not talking about the actual releases that are now being compiled. This is a step further. For people using Docker Containers, it would essentially be a container with that release already installed.
An example of what I'm talking about is here: https://hub.docker.com/r/sirfragalot/hyperion.ng
However the issues with the above repository are: 1) it's outdated, so it's using a compiled version from 3 months ago and 2) will only work on OS/ARCH linux/amd64. So people with Raspberry Pi's will not be able to use this Docker Container for example.

Now I understand your question. :-)
Hyperion analyzes the screen content, which is not possible or only possible to a limited extent in a Docker container. This is the reason why we do not deliver finished Docker containers with Hyperion.
That our Docker containers (for the production of our releases) are not up to date, is because we want to be backwards compatible. The releases have the necessary dependencies, which enables execution on upward systems.

Maybe I'm confusing myself and you at the same time. Does that mean the above docker hub by SirFragalot would not have a working hyperion executable for AMD64 systems? :(
Sorry just got exposed to Docker Containers and have everything running in one now. Home Assistant, Pi-Hole, etc. Wanted to add Hyperion NG to the stack. Is this something that may be possible later or a limitation of containers and screen capture? Could it work with elevated privileges or anything?

Does that mean the above docker hub by SirFragalot would not have a working hyperion executable for AMD64 systems? :(

It's already running. I only doubt that this Docker container can pick up the screen signal and forward it to Hyperion.

Is this something that may be possible later or a limitation of containers and screen capture?

Unfortunately it is limited to get signals from the host system in the Docker container

Could it work with elevated privileges or anything?

I do not think so

Hello,
I have a question about the releases. When I extract the file and run it on my coreelec device it doesn't say v2.0.0 alpha 4. It just says v2.0.0. Can you explain me why this is? I tried compiling my own tar.gz for amlogic but it still doesn't work.
Thanks in advance.

Agree with @Paulchen-Panther that a docker wouldn't really work due to the nature of screen capture in general as that needs direct tie-ins with display and access to LEDS  via SPI / USB serial.
It will work for some cases like AtmoOrb where you only need to receive and send TCP/UDP commands but we couldn't maintain a docker image just for those as it would create confusion for sure :)

It will work for some cases like AtmoOrb where you only need to receive and send TCP/UDP commands but we couldn't maintain a docker image just for those as it would create confusion for sure :)

Now it makes sense! Thank you.
I am using a great utility for Android TV (https://play.google.com/store/apps/details?id=com.abrenoch.hyperiongrabber) which captures the screen and sends data to Hyperion. In my use case Hyperion would work just fine in a Docker since it does not grab the screen itself, correct?
Anyway, keep up the great work in Hyperion.NG! Really takes media to another level.

I am using a great utility for Android TV (https://play.google.com/store/apps/details?id=com.abrenoch.hyperiongrabber) which captures the screen and sends data to Hyperion. In my use case Hyperion would work just fine in a Docker since it does not grab the screen itself, correct?

It would still need something that connects to the LEDs.
That can be via Serial interface (COM port) as Docker can forward that to the container, not sure about performance though as there will be an added layer.

My setup is:
Android TV -> Arduino Nano -> RPi4 -> Hyperion.NG
Would running HNG in Docker work for this scenario? Guess I could always try and see but I haven't fully learned how to create a Docker container yet. D:

If the Arduino Nano is the one driving the leds and its connected to the RPi4 via USB that should work, you need to lookup the /dev/ttyXX serial device and forward that to the docker container:
https://stackoverflow.com/questions/24225647/docker-a-way-to-give-access-to-a-host-usb-or-serial-device
Then again running in natively on the RPi4 would probably be easier though unless you are gonna use the RPi4 for different applications which docker is great for.
Side note:
Recently went full Linux for my home server and 95% of my server applications run in Docker containers, manage everything with Portainer (web based Docker "interface") and can highly recommend that one as it beats tinkering with CLI commands :)
Docker has a very bright future and makes for easy managing of just about everything you can think off so it's worth investing time into for sure.

Recently went full Linux for my home server and 95% of my server applications run in Docker containers, manage everything with Portainer (web based Docker "interface") and can highly recommend that one as it beats tinkering with CLI commands :)
Docker has a very bright future and makes for easy managing of just about everything you can think off so it's worth investing time into for sure.

Yep! Exactly got this right now. DietPi + Home Assistant + Portainer = unlimited possibilities.
So this is why I was hoping someone could create a Docker container for Hyperion.NG. The few I found were not for arm architecture.

Too bad this one didn't publish the source code as that way we could try and run a test build on an ARM device:
https://hub.docker.com/r/sirfragalot/hyperion.ng
However you could mail him and ask to compile an image on a Raspberry or publish the Docker code to Github at least:
LABEL<EMAIL_ADDRESS>DESCRIPTION=Docker container for Hyperion-NG IMAGENAME=hyperion.ng OS=linux VERSION=0.1.0

https://hub.docker.com/layers/sirfragalot/hyperion.ng/0.1.0/images/sha256-c11bd96d1799ff631f1dcbffd2e9c5af7947b6e561cff7bffee87eacfcd26db6?context=explore
Does this show us the code? It's the makeup of the file.

Partially yes, missing a few definitions but in theory can reverse engineer it off that.
Here's an example of valid DockerFile:
https://github.com/RickDB/Docker-PlexAniSync/blob/master/Dockerfile

This is a very simple Dockerfile for the PI if no local system is needed (e.g. using network video capture and WLED etc.)
FROM balenalib/raspberrypi3:run

RUN install_packages \
	libpython3.5 \
	libjpeg62-turbo \
	libavahi-compat-libdnssd1 \
	libdbus-1-3 \
	libqt5sql5 \
	libqt5serialport5 \
	libqt5network5 \
	libqt5widgets5 \
	libqt5gui5 \
	libqt5core5a

ENV RELEASE 2.0.0-alpha.5/Hyperion-2.0.0-alpha.5-Linux-armv7hf-rpi

RUN curl -fsSL https://github.com/hyperion-project/hyperion.ng/releases/download/${RELEASE}.deb > /tmp/hyperion.deb && dpkg -i /tmp/hyperion.deb && rm -f /tmp/hyperion.deb

EXPOSE 8090 8091 19333 19400 19445
VOLUME /config

CMD hyperiond -u /config

Build with: docker build -t hyperion.ng .
Run with: docker run -d -v /path/on/host:/config --network host hyperion.ng

Thank you very much for this, @bradsjm!
It seems to be almost working.
[hyperiond DISPMANXGRABBER] <ERROR> Snapshot failed: -1, [hyperiond DISPMANXGRABBER] <ERROR> Previous line repeats 9 times, [hyperiond LEDDEVICE] <DEBUG> <LedDeviceAdalight.cpp:83:receivedData()> >>received 4 bytes data,
I am able to interface with Hyperion and change effect colors (since grabber not working it's in idle mode). But the Android Video Grabber is not able to connect it seems. Grabber options set to auto in settings for Hyperion. Any idea if some install file is missing perhaps?

`FROM balenalib/raspberrypi3:run
RUN install_packages
libpython3.5
libjpeg62-turbo
libavahi-compat-libdnssd1
libdbus-1-3
libqt5sql5
libqt5serialport5
libqt5network5
libqt5widgets5
libqt5gui5
libqt5core5a
ENV RELEASE 2.0.0-alpha.7/Hyperion-2.0.0-alpha.7-Linux-armv7l
RUN curl -fsSL https://github.com/hyperion-project/hyperion.ng/releases/download/${RELEASE}.deb > /tmp/hyperion.deb && dpkg -i /tmp/hyperion.deb && rm -f /tmp/hyperion.deb
EXPOSE 8090 8091 19333 19400 19445
VOLUME /config
CMD hyperiond -u /config`
Trying to run new container with updated alpha 7 build and get an error "cannot read properly 'url' of undefined." Any ideas why? I only changed the env from alpha 5 to alpha 7 in the above code. Thanks in advance, @bradsjm!

Nevermind. Looks to be a Portainer bug with Home Assistant. Probably works just fine once it gets fixed. Sorry for the commotion. :) Will leave this here in case anyone has similar issues. https://github.com/portainer/portainer/issues/4125

@Hukuma1 I assume you get the error from hyperion's UI,correct? I suggest you remove cookies and remove the browser cache.

Had anyone had any problems with exposed ports? While the 8090 works fine, the 19333 19400 19445 cannot be accessed at all (tested from an android phone using Android grabber & Hyperion app)?

I still have no clue why it is not working. This is a netstat from the running container with hyperion.ng
root@dba1ceb5-hyperion:/# netstat -antp
Active Internet connections (servers and established)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name
tcp        0      0 <IP_ADDRESS>:40097        <IP_ADDRESS>:*               LISTEN      -
tcp        0      0 <IP_ADDRESS>:40174       <IP_ADDRESS>:80        TIME_WAIT   -
tcp        0      0 <IP_ADDRESS>:37554       <IP_ADDRESS>:80       TIME_WAIT   -
tcp        0      0 <IP_ADDRESS>:37524       <IP_ADDRESS>:80       TIME_WAIT   -
tcp6       0      0 :::19400                :::*                    LISTEN      196/hyperiond
tcp6       0      0 :::19444                :::*                    LISTEN      196/hyperiond
tcp6       0      0 :::19445                :::*                    LISTEN      196/hyperiond
tcp6       0      0 :::8090                 :::*                    LISTEN      196/hyperiond
tcp6       0      0 :::8092                 :::*                    LISTEN      196/hyperiond
tcp6       0      0 <IP_ADDRESS>:8090        <IP_ADDRESS>:61592     ESTABLISHED 196/hyperiond
tcp6       0      0 <IP_ADDRESS>:19444       <IP_ADDRESS>:51028      ESTABLISHED 196/hyperiond
tcp6       0      0 <IP_ADDRESS>:8090        <IP_ADDRESS>:61587     ESTABLISHED 196/hyperiond
tcp6       0      0 <IP_ADDRESS>:8090        <IP_ADDRESS>:61586     ESTABLISHED 196/hyperiond
tcp6       0      0 <IP_ADDRESS>:8090        <IP_ADDRESS>:61585     ESTABLISHED 196/hyperiond

<IP_ADDRESS> - is hassio IP address
<IP_ADDRESS> - is host machine IP address
 <IP_ADDRESS> - is the address of the PC from which I access the web GUI
Any suggestions why I cannot connect to 19444 or 19445?

I just want to throw this out there. I was able to get some dockerfile (I wish I could find it again) for this running and by docker-compose by using the below elements in the compose file. So a docker setup is totally possible.
Devices:     /dev/video0:/dev/video0     /dev/spidev0.0:/dev/spidev0.0     /dev/spidev0.1:/dev/spidev0.1
my only issues were related to my capture device at video0 which I'm 95% sure are an artifact of my setup and cheap hardware. I recently rebuilt my pi and neglected to make a backup, so I will update this once I find the dockerfile I used.

I just want to throw this out there. I was able to get some dockerfile (I wish I could find it again) for this running and by docker-compose by using the below elements in the compose file. So a docker setup is totally possible.
Devices:     /dev/video0:/dev/video0     /dev/spidev0.0:/dev/spidev0.0     /dev/spidev0.1:/dev/spidev0.1
my only issues were related to my capture device at video0 which I'm 95% sure are an artifact of my setup and cheap hardware. I recently rebuilt my pi and neglected to make a backup, so I will update this once I find the dockerfile I used.

hi,
i have a pi4 with home assistant on docker. i have installed portainer . i have tried to install hyperion with the dockerfile above but that didn't work...
i'm not used with docker. Could someone help me in my setup ?
Thanks


CVE-2018-18955 can't work because SMBus Host Controller not enabled

install cve-2018-18955

Stucking in this screen after rebooting the system.

I tried to fix the problem but it didn't work.

@LinZiyuu Thanks! What's the version of your Ubuntu by the way? I will try to reproduce this bug.

Ubuntu18.04

@LinZiyuu Hi, I could not reproduce this bug yet.
My environment: Vagrant Ubuntu 18.04 Box from https://app.vagrantup.com/ubuntu/boxes/bionic64
After booting and installing Metarget I just type the command below and reboot:
./metarget cnv install cve-2018-18955 --verbose

It works for me:
➜  ~ uname -a
Linux ubuntu-bionic 4.15.0-041500rc1-generic #201711262030 SMP Mon Nov 27 01:32:09 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

Maybe you could try once again?

@brant-ruan Hi, I reinstalled the virtual machine then it  worked for new environment.


fixed bug in setLanAddress() function

found a typo in setLanAddress() function - variable ipaddress missing a s

Great - thanks for the fix

Great - thanks for the fix


[BUG] Latency info is not displayed when top queries by latency is enabled

What is the bug?
When I enable top queries by latency with UI and make search requests, the top queries are showing up on the overview page but latency info is not displayed.

How can one reproduce the bug?

Enable top queries by latency on the UI

Make search requests to the cluster
Check the overview page, the latency column shows "not enabled"
On the detail page, the stats are shown as "undefined", which is also not a good experience

What is the expected behavior?
The overview page should display latency info when enabled and detailed page should also say "not enabled" instead of undefined.
What is your host/environment?
macos.
Do you have any screenshots?
See above.

Will pick this up for 2.18

This is fixed by https://github.com/opensearch-project/query-insights-dashboards/pull/15


Added context menu items to show and hide all comments

This commit adds two new options to the block editor's context menu to show and hide all the comments on the workspace.
Resolves #1422

Although this uses the same implementation as #1353, the undo and redo buttons don't seem work for showing and hiding comments.

@conorshipp Undo/redo won't work because opening/closing the comment is a Blockly.Events.Ui event, which doesn't record on the undo stack. I'm okay with taking this change in spite of that as undo support will require changes to Blockly.

Merged. Thanks @conorshipp!


Redirect Loop Error

Alot of our members are getting Redirect loop errors when trying to sign up with steam Login handle.

What web server are you using? Are you up to date with IPS version? What
3rd party plugins and apps are installed?

Yes I'm running the very latest version of IPB.. VizionDev app is the 3rd party Application but it shouldn't conflict with it. I'm stumped I asked some of the IPB devs they said they can't look at it due to it being 3rd party. I disable the steam login handle the issue goes away.. Enable it and it returns...

I'm almost done watching Pixels. If you would like I could take a look if
that's okay with you?
Http://steamcommunity.com/id/madman32395

Found to be a compatibility issue with https://community.invisionpower.com/files/file/7482-terms-of-service/
I sent Adriano a message asking about it.

@ucjohn Was told that all 3rd party login methods are incompatible
https://community.invisionpower.com/topic/410868-terms-of-service/?do=findComment&comment=2600014


Spark parallel memory warnings

Hi!
I'm running TabularPredictor inside a Pandas function for each group of a spark dataFrame:

schema_2= StructType([
 StructField('ds', DateType()),
 StructField('yhat', IntegerType()),
 StructField('ID', StringType())

])

def autog(df: pd.DataFrame) -> pd.DataFrame:

 predictor = TabularPredictor(label="QTE",
                                  problem_type="regression") \
 .fit(train_data=df,
      excluded_model_types =["NN","KNN"],
      auto_stack=True,
      presets='best_quality',
      time_limit=5400)
  ....

 return prediction_df

(sparkdf
          .groupBy('GROUP_ID') # each group contain aprox 600K rows
          .applyInPandas(autog, schema=schema_2)
         )

I'm using 2 workers of 64G each, but some models are skipped :
Warning: Early stopped GBM model prior to optimal result to avoid OOM error. Please increase available memory to avoid subpar model quality.
	Warning: Exception caused LightGBMXT_BAG_L1 to fail during training... Skipping this model.

is there another solution (other than increasing the memory) to have better quality models ?
Thank you

In .fit I excluded NN models but it seems that autogluon is tring to fit  NeuralNetFastAI  :
Time limit exceeded... Skipping NeuralNetFastAI_BAG_L1.

I would recommend training AutoGluon predictor's sequentially rather than in parallel if possible, unless you have a spark cluster such that each worker is training a singular predictor in isolation. A single predictor tries to use as much resources as possible, so training them in parallel on the same machine would not be helpful as they are trying to use all cores. I'm unsure exactly how spark does this if there are more than 2 GROUP_ID's but only 2 workers, but if it tries to train 10 predictors on each worker at the same time, this probably isn't ideal (each predictor would train 10x slower due to fighting for the same resources, while taking a total of 10x the usual memory).
Given that LightGBM rarely runs into memory issues, I'm pretty sure it is this parallel training that is causing the problems.
Regarding the NN models, there are two NN models: NN and FASTAI, you'll need to add FASTAI to your excluded models list.
You may want to try with a smaller sample of your data this code and see if the problem still persists, 600k rows shouldn't cause issues in most cases, but if you have many unique GROUP_IDs, this might be the reason.


Integrate OPUS with Cosmographia

Cosmographia is a visualization tool that lets you look at objects in space at a particular point in time. We could interface with it to display where a spacecraft was and what it was seeing during an OPUS observation.

Another option is to use PyWWT: https://github.com/WorldWideTelescope/pywwt


Start-Job -WorkingDirectory only accepts native filesystem paths

This has two ramifications:

A path based on a PS drive isn't supported.

A note re a possible fix: The child process running the script block cannot be assumed to have the same PS (filesystem) drives defined, but at least a PS-drive-based input path should be resolved to the underlying native path.

The interchangeable use of / and \ isn't supported.

Implementation note: Making this fix is a good opportunity to switch from using ProcessStartInfo.Arguments to ProcessStartInfo.ArgumentList for more robust invocation of the hidden PowerShell child process that serves the background job, as discussed in https://github.com/PowerShell/PowerShell/pull/11041#discussion_r345358147
Steps to reproduce
New-PSDrive foo filesystem .; Set-Location foo:/

Start-Job { $pwd } -WorkingDirectory $pwd | Receive-Job -Wait -AutoRemove | Should -Match '^foo:[/\\]'

if (-not $IsWindows) {
  Start-Job { $pwd } -WorkingDirectory '\' | Receive-Job -Wait -AutoRemove | Should -Be '/'
}

Expected behavior
Both tests should pass.
Actual behavior
Both tests fail.
Environment data
PowerShell Core 7.0.0-preview.5

@mklement0 Will #11041 fix this? Should we add additional tests to #11041 ?

No, @iSazonov, this is a separate issue, and new tests (such as the ones in the OP) should be added to the PR that will fix this issue.


Channel reuse pattern should be exclusive with ServerConfig

Currently, the channel reuse is passed alongside ServerConfig, but they should be an either/or options. ServerConfig is only needed to create a channel, so if the channel is available, there's no need to also pass server options. This makes the construction of objects clearer to use.

"should be [exclusive] either/or option" - I disagree. You might want to know what the channel is connected to at some other time, since the Channel object doesn't hold that information in most languages.
"should be either [or both] option" - I agree, and it already is this way. If the channel object is defined, that takes priority. Otherwise, it opens a new channel to the provided config.
I have tried to balance the plethora of constructors (because Java and Golang don't allow optional arguments) to allow all permutations with the brevity of a single constructor using null arguments. For some languages like Python, C#, etc, we can just use named parameters.
Thought on the following setup?

Universal constructor: new(AccountProfile, ServerConfig, Channel)
New prod constructor: new(AccountProfile) -> new(AccountProfile, getProductionConfig(), null)
New prod AccountService constructor: new() -> new(getProductionConfig())

I'm open to other ideas.

The channel is a function of the server config, a transformation of it. Passing both causes a side effect, where one of them is ignored (based on priority), which cannot be communicated through method signatures, hence the side effect. It's an anti-pattern.
What's a good use case where you would provide server config, obtain channel, and then want to discover the server parameters again? Prod users won't be dealing with server config much anyway, we use it for test environments mostly now. Ideal production use would involve just passing auth credentials (account profile).
At minimum, AccountService can be constructed without parameters and all other services should only require AccountProfile as input. All other options for passing custom configuration, should be added as overloads, if the language supports. If not, use language specific best practices. This is one reason why I was advocating for the builder pattern, as I think it's a functional construction, as opposed to configuration based that's the most cross language consistent.
Here's a TDD approach of common use of services.
accountService = AccountService()
profile = accountService.signIn()

walletService = WalletService(profile)

// for optimization with channel reuse
walletService = WalletService(profile, accountService.channel)

We should be modeling base ctors with this in mind, and overload where needed.
I think expecting that users pass null when unnecessary can be confusing, like accountService = AccountService(null, someConfig, null). I also want to mention again that prod users won't be dealing with server config at all.

That all makes complete sense. I agree that having a side effects is an
anti-pattern. If nobody else is going to use the dev or staging server,
then we should probably Mark that as an internal constructor option. That
way we have the API surface that we need for easy construction using the
staging server and the API service exposed externally that we want people
to actually use. The one counterpart I have to think about that is would
there ever be a situation in which somebody would stand up their own server
infrastructure on premise?
On Fri, Dec 24, 2021, 21:47 Tomislav Markovski @.***>
wrote:

The channel is a function of the server config, a transformation of it.
Passing both causes a side effect, where one of them is ignored (based on
priority), which cannot be communicated through method signatures, hence
the side effect. It's an anti-pattern.
What's a good use case where you would provide server config, obtain
channel, and then want to discover the server parameters again? Prod users
won't be dealing with server config much anyway, we use it for test
environments mostly now. Ideal production use would involve just passing
auth credentials (account profile).
At minimum, AccountService can be constructed without parameters and all
other services should only require AccountProfile as input. All other
options for passing custom configuration, should be added as overloads, if
the language supports. If not, use language specific best practices. This
is one reason why I was advocating for the builder pattern, as I think it's
a functional construction, as opposed to configuration based that's the
most cross language consistent.
Here's a TDD approach of common use of services.
accountService = AccountService()
profile = accountService.signIn()
walletService = WalletService(profile)
// for optimization with channel reuse
walletService = WalletService(profile, accountService.channel)
We should be modeling base ctors with this in mind, and overload where
needed.
I think expecting that users pass null when unnecessary can be confusing,
like accountService = AccountService(null, someConfig, null). I also want
to mention again that prod users won't be dealing with server config at all.
—
Reply to this email directly, view it on GitHub
https://github.com/trinsic-id/sdk/issues/298#issuecomment-1000962044,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AD7QPF3EHFIND7GTFDEI5SLUSUWC7ANCNFSM5KWSN5LQ
.
You are receiving this because you commented.Message ID:
@.***>

Good question. We've talked about providing multi-region support, which would require passing endpoint info. In addition, dedicated infra deployments will require this, but they're not on the roadmap very soon. TBD for now.


add new adapters to sign and verify Helm Charts

At the time of writing this, GnuPG is the only option of signing/verifying Helm Charts. But there are new vendors that might help us to do the same such as cosign. Also, I believe there will be others in the future, so, we need to design this signing/verifying feature in an extensible way like accepting these adapters via a flag, for example, --sign cosign|gpg|...
WDYT?
Output of helm version:
Output of kubectl version:
Cloud Provider/Platform (AKS, GKE, Minikube etc.):

I agree that embracing other models to sign and verify charts would be great.
Something like this first needs to be a Helm Improvement Proposal (HIP). Is that something you're interested in writing or starting?


Single sign on support

Hey, great work on this so far. My users wont bother to use the chat widget if they have to log in every time they want to chat with us, it causes too much friction. Is this something that can be implemented relatively soon.
Canny.io has a similar web view implemented which has SSO support.
https://developers.canny.io/install/widget/sso

Hello @AyoCodess, thank you for your feedback. Regarding your concern, we will add a prop to allow users to boot their user profile every time they open the application, so they can have their login information readily available.

As for the SSO issue, we will plan and implement it in the upcoming deployment.

And if you're truly interested in addressing the SSO issue sooner, once we've implemented the user boot feature, you can go ahead and create a PR for the SSO functionality.

#6 I've pushed this boot info user feature, and you can try it with the new version.

@chative-tu how do we link this to our dashboard, i don't see where i can add a api key, and it looks like i can't get an api key without upgrading to business?

@chative-tu how do we link this to our dashboard, i don't see where i can add a api key, and it looks like i can't get an api key without upgrading to business?

Can you clarify what you're asking for? I don't understand the use case you're referring to

I spoke to someone in support and resolved it. Thanks


GOTR Tracking

At the start of GOTR games pouches are cleared

Based on data collection while sitting in games (solo and sat inside the minigame waiting for the guardian to die) it seems that

Varbit ID
Value
Description

13688
0
The GOTR game has started. Currently playing the game. Game UI shown.

13688
1
The GOTR game was over. Waiting for next game. Game UI was gone.

There could be a different state for the various states in the minigame

Start
Rifts open

I didn't specifically check for this, but I can't remember seeing 13688 change

The overpower event when you get to ~60%

Didn't play the game fully so didn't reach this

Guardian is at 100%

Didn't play the game fully so didn't reach this

Guardian is casting the final spell/animation right before the game ends in a win

Didn't play the game fully so didn't reach this

End

I didn't consider what happens if we walk out of the minigame. The guardian essence in the pouch should disappear too.


Upgrade to Cats 0.8.1

Beginning to resolve https://github.com/finagle/roc/issues/78

what's going on about this issue?
I got the same error because of the cats old version conflicts when i use the finagle 6.41 and roc version v0.0.4. roc should upgrade the cats version, if it's used with finagle 6.41.


Fix Daemon on XWayland

Fixes https://github.com/DaemonEngine/Daemon/issues/658

diff --git a/src/engine/sys/sdl_glimp.cpp b/src/engine/sys/sdl_glimp.cpp
index 1500e7cd..f14662d0 100644
--- a/src/engine/sys/sdl_glimp.cpp
+++ b/src/engine/sys/sdl_glimp.cpp
@@ -522,8 +522,14 @@ static bool GLimp_DetectAvailableModes()

        if ( SDL_GetWindowDisplayMode( window, &windowMode ) < 0 )
        {
+               // we can't use SDL_GetWindowWMInfo yet, so we can't use
+               // that and use getenv instead.
+               if (Q_stricmp(getenv("XDG_SESSION_TYPE"), "wayland") == 0)
+               {
+                       return true; // don't fail as this is normal on XWayland.
+               }
                logger.Warn("Couldn't get window display mode: %s", SDL_GetError() );
-               return true;
+               return false;
        }

        for ( i = 0; i < SDL_GetNumDisplayModes( display ); i++ )

If we're gonna make this test return true, we better revert the whole function to a void one.
The purpose of this function being a bool one and this test returning false was to catch this precise “Couldn't find display mode match” error and to prevent a segfault (so it was 100% done on purpose to return false there and abort).
@necessarily-equal What happens if you run latest master on Wayland, including the just merged:

https://github.com/DaemonEngine/Daemon/pull/657

Does it return to a safe resolution?
Note that this is not a fix for the issue you experience, but it would help to understand more what's going on.

@necessarily-equal can you add this simple comment above the return true; line
/* FIXME: returning true means the engine will crash if the window size is larger than what the GPU can do,
but we need to not fail to open window that are not using native screen resolutions even if the GPU can handle it. */

I assume it's better to give everyone the ability to open a window with an arbitrary size than preventing a crash that is only likely to happens on some obsolete hardware if the user tries to use an higher resolution than his GPU can do (which is expected to be already larger than his screen, so not something he wants).
We can do better things after 0.53, 0.52 didn't catch the said crash so not catching this crash in 0.53 isn't a regression, while preventing the creation of arbitrary window sizes is a regression.

Sounds good. I'll be afk tomorrow, you can push this to the PR and merge it if you want to proceed with the release
Le 27 juillet 2022 19:00:47 GMT+02:00, Thomas Debesse @.> a écrit :
@. can you add this simple comment above the return true; line

/* FIXME: returning true means the engine will crash if the window size is larger than what the GPU can do,
but we need to not fail to open window that are not using native screen resolutions even if the GPU can handle it. */

I assume it's better to give everyone the ability to open a window with an arbitrary size than preventing a crash that is only likely to happens on some obsolete hardware if the user tries to use an higher resolution than his GPU can do (which is expected to be already larger than his screen, so not something he wants).
We can do better things after 0.53, 0.52 didn't catch the said crash so not catching this crash in 0.53 isn't a regression, while preventing the creation of arbitrary window sizes is a regression.
--
Reply to this email directly or view it on GitHub:
https://github.com/DaemonEngine/Daemon/pull/659#issuecomment-1197047594
You are receiving this because you were mentioned.
Message ID: @.***>

merged as ba3538993e18bd6cb0966a4cb8395a7a2960a88a


Bug Fixes

"Training and tutorial" link fixed
Fixed spelling and grammar in many places

Looks Great!


Image is not saved

Hey there,
I am running your project on mac and everything runs through but the image is not saved anywhere, at least I can't find it. Any suggestion?
Thanks in advance

Can you try full path for output?
Example on Cli:
tweetcapture https://twitter.com/jack/status/20 -o /Users/username/Desktop/test.png

Same, still no image 🤷♂

I'll try to examine it. I haven't Mac so it will be hard for me. Thanks for reporting the issue.

Thanks again, fixed. Release: 0.0.12

I have a Mac and am facing the same issue

I have a Mac and am facing the same issue
Did you upgrade the package?

> pip3 install -U tweet-capture
> pip3 install -U selenium

There was a problem but it should be working on 0.0.13.
macOS test on 0.0.13:
https://github.com/Xacnio/tweetcapture/runs/7570222675?check_suite_focus=true
https://github.com/Xacnio/tweetcapture/suites/7571257875/artifacts/313009601


Using appmetrics with statsd

Hello
Appologies in advance as this might not be completely appmetrics related.
We want to use appmetrics so that we can capture node specific metrics and also want to use statsd to capture custom metrics and send them all to a statsd daemon. We've looked at appmetrics-statsd but realised that the library doesn't allow configuring appmetrics (https://github.com/RuntimeTools/appmetrics-statsd/issues/5). Also there doesn't seem to be much activity in that project. Was wondering if using appmetrics-statsd is the only option we have if we want to use appmetrics and statsd in tandem or if there's an alternative approach.

Hi, most of the work we do is around adding functionality to appmetrics and our core monitoring solutions (omr-agentcore).  the statsd library simply takes everything appmetrics produces and forwards to the statsd daemon.  It is still supported but the focus has been on this project in the short term.
What sort of configuration options would you like to see ?

Hi Toby, initially we'd like to be able to disable mqtt as we are not expecting to send any metrics to mqtt. But I would imagine the library being a wrap around appmetrics and statsd, it would be good to pretty much enable configuring both appmetrics and statsd the same way someone would configure it when using those libraries on their own. As far as I've understood, configuring statsd is possible from the appmetrics-statsd library, so I would hope having the same capability for appmetrics would also be sensible. Thanks.

Maybe appmetrics-statsd (and friends) should support dependency injection, so appmetrics can be configured, then passed. This would allows using two adapters at once, and allow direct use of appmetrics as well as the adapters:
var appmetrics = require('appmetrics');
appmetrics.configure({mqtt: false})

var statsd = require('appmetrics-statsd')({appmetrics: appmetrics, prefix: 'my-scope.'});

var elk = require('appmetrics-elk')({appmetrics: appmetrics, ....});

appmetrics.start();

^--- we'd probably need something like that in strong-supervisor to allow command line/env var configuration of the various adapters, and to have them use the appmetrics that supervisor depends on (instead of the internal dependency the adapters have now).
The adapters are well designed to be quick and simple to use ATM, but the internal dependency on appmetrics is inflexible, as @imranbohoran is running into.

just looking at exactly that now @sam-github  :-)

this is working for me when I install the latest appmetrics from git
var appmetrics = require('appmetrics');
appmetrics.configure({'mqtt':'off'});
var appstatsd = require('appmetrics-statsd').StatsD();

OK, so the approach above works because appmetrics is now a global singleton?

Hmm, As @sam-github says I guess it works this way since you had done a require('appmetrics') before require('appmetrics-statsd).statsD(). @tobespc is your recommendation we follow this approach or were you stating a work-around for here-and-now. IMHO the solution @sam-github suggested might be a bit more explicit on how appmetrics-statsd is configured.

@imranbohoran This will work for here-and-now. :-)  We have only just fininshed the work on exposing appmetrics configuration via an api call so how we will expose this up to our additional packages (statsd, elk etc) is still in design

@tobespc Thanks for that. Will keep this issue opened so we'll get notified when you complete the work. Thanks for your quick response. Much appreciated.

@sam-github appmetrics is not a global singleton right now, but the agent underneath it is, and the agent manages the properties, so that's why this works. It might be good for appmetrics itself to be a singleton to avoid anything strange happening.

@tobespc So we tried this and we can't see that mqtt is disabled.
  var appmetrics = require('appmetrics');
  appmetrics.configure({'mqtt':'off'});
  var appmetricsStatsd = require('appmetrics-statsd').StatsD(null, "localhost", 8125, 'app-prefix.');

When the app starts up we see com.ibm.diagnostics.healthcenter.mqtt INFO: Connecting to broker localhost:1883
I was expecting with mqtt set to off, no mqtt operations would take place. Am I missing something. Versions in use are;
    "appmetrics": "1.1.2",
    "appmetrics-statsd": "1.0.1"

I think this was added in appmetrics 1.2

Any chance getting 1.2.0 on npm please?

we will be release 1.2.0 to npm in a few days, just finishing off release work.   In the meantime, you can use it now by cloning this git repo and installing from that locally

npm i --save RuntimeTools/appmetrics will work until 1.2 is released, npm can install directly from github.

Closing as 1.2.0 is now released


Must be an instance of Illuminate\Redis\Database, instance of Redis given

Latest Laravel 5.1.10 is spitting out this error when cache=redis in the config. Only happens with cache.
ErrorException in RedisStore.php line 39:
Argument 1 passed to Illuminate\Cache\RedisStore::__construct() must be an instance of Illuminate\Redis\Database, instance of Redis given, called in /home/vagrant/Projects/localsite.dev/vendor/laravel/framework/src/Illuminate/Cache/CacheManager.php on line 205 and defined
in RedisStore.php line 39
at HandleExceptions->handleError('4096', 'Argument 1 passed to Illuminate\Cache\RedisStore::__construct() must be an instance of Illuminate\Redis\Database, instance of Redis given, called in /home/vagrant/Projects/localsite.dev/vendor/laravel/framework/src/Illuminate/Cache/CacheManager.php on line 205 and defined', '/home/vagrant/Projects/localsite.dev/vendor/laravel/framework/src/Illuminate/Cache/RedisStore.php', '39', array()) in RedisStore.php line 39
at RedisStore->__construct(object(Redis), 'localsite', 'default') in CacheManager.php line 205
at CacheManager->createRedisDriver(array('driver' => 'redis', 'connection' => 'default')) in CacheManager.php line 97
at CacheManager->resolve('redis') in CacheManager.php line 77
at CacheManager->get('redis') in CacheManager.php line 55
at CacheManager->store() in CacheManager.php line 310
at CacheManager->__call('forget', array('cartalyst.config')) in Repository.php line 242
at CacheManager->forget('cartalyst.config') in Repository.php line 242
at Repository->removeCache() in Repository.php line 183
at Repository->fetchAndCache() in CompositeConfigServiceProvider.php line 102
at CompositeConfigServiceProvider->setUpConfig() in CompositeConfigServiceProvider.php line 41
at CompositeConfigServiceProvider->register() in Application.php line 531
at Application->register(object(CompositeConfigServiceProvider)) in ProviderRepository.php line 74
at ProviderRepository->load(array('Illuminate\Foundation\Providers\ArtisanServiceProvider', 'Illuminate\Auth\AuthServiceProvider', 'Illuminate\Broadcasting\BroadcastServiceProvider', 'Illuminate\Bus\BusServiceProvider', 'Illuminate\Cache\CacheServiceProvider', 'Illuminate\Foundation\Providers\ConsoleSupportServiceProvider', 'Illuminate\Routing\ControllerServiceProvider', 'Illuminate\Cookie\CookieServiceProvider', 'Illuminate\Database\DatabaseServiceProvider', 'Illuminate\Encryption\EncryptionServiceProvider', 'Illuminate\Filesystem\FilesystemServiceProvider', 'Illuminate\Foundation\Providers\FoundationServiceProvider', 'Illuminate\Hashing\HashServiceProvider', 'Illuminate\Mail\MailServiceProvider', 'Illuminate\Pagination\PaginationServiceProvider', 'Illuminate\Pipeline\PipelineServiceProvider', 'Illuminate\Queue\QueueServiceProvider', 'Illuminate\Redis\RedisServiceProvider', 'Illuminate\Auth\Passwords\PasswordResetServiceProvider', 'Illuminate\Session\SessionServiceProvider', 'Illuminate\Translation\TranslationServiceProvider', 'Illuminate\Validation\ValidationServiceProvider', 'Illuminate\View\ViewServiceProvider', 'App\Providers\AppServiceProvider', 'App\Providers\EventServiceProvider', 'App\Providers\RouteServiceProvider', 'Cartalyst\Sentinel\Laravel\SentinelServiceProvider', 'Cartalyst\NestedSets\Laravel\NestedSetsServiceProvider', 'Cartalyst\DataGrid\Laravel\DataGridServiceProvider', 'Cartalyst\CompositeConfig\Laravel\CompositeConfigServiceProvider', 'Barryvdh\Debugbar\ServiceProvider', 'Barryvdh\LaravelIdeHelper\IdeHelperServiceProvider', 'Bugsnag\BugsnagLaravel\BugsnagLaravelServiceProvider', 'Former\FormerServiceProvider', 'BackupManager\Laravel\Laravel5ServiceProvider', 'Laravel\Cashier\CashierServiceProvider')) in Application.php line 507
at Application->registerConfiguredProviders() in RegisterProviders.php line 17
at RegisterProviders->bootstrap(object(Application)) in Application.php line 203
at Application->bootstrapWith(array('Illuminate\Foundation\Bootstrap\DetectEnvironment', 'Illuminate\Foundation\Bootstrap\LoadConfiguration', 'Illuminate\Foundation\Bootstrap\ConfigureLogging', 'Illuminate\Foundation\Bootstrap\HandleExceptions', 'Illuminate\Foundation\Bootstrap\RegisterFacades', 'Illuminate\Foundation\Bootstrap\RegisterProviders', 'Illuminate\Foundation\Bootstrap\BootProviders')) in Kernel.php line 222
at Kernel->bootstrap() in Kernel.php line 117
at Kernel->sendRequestThroughRouter(object(Request)) in Kernel.php line 87
at Kernel->handle(object(Request)) in index.php line 54

Can't replicate. Please ask on the fourms.

@goodevilgenius I'm at Laravel 5.4 now and no longer experience the issue. An upgrade might be your best route.

I was on Lumen 5.6. Fully upgraded.
Turns out the issue for me was that I failed to register the RedisServiceProvider.

@goodevilgenius same problem here, I solved running:
composer require illuminate/redis
available in : https://lumen.laravel.com/docs/5.8/cache#Redis Support
Disclaimer:
"This problem has been closed for a while, but I leave the record here in case anyone has the same problem, it happened to me recently."

@goodevilgenius same problem here using lumen 5.7, I solved running: composer require illuminate/redis and register $app->register(\Illuminate\Redis\RedisServiceProvider::class); in bootstrap/app.php available in : https://lumen.laravel.com/docs/5.8/cache#Redis Support
Disclaimer: "This problem has been closed for a while, but I leave the record here in case anyone has the same problem, it happened to me recently."

Thanks!


Better installation instructions

It is better to use Pristine Copy/Bundles dir for full bundles and Bundles dir for "patches"

I couldn't merge your patch as/is due to format problems (probably because you submitted it a year ago - sorry about that), so I updated it myself and listed you as author. Thanks!

@toy I couldn't merge your patch as/is due to format problems (probably because you submitted it a year ago - sorry about that), so I updated it myself and listed you as author. Thanks!

Yaaay! :)


Ingress Controller - whitelisting

We're running 0.8.3 ingress at present, the controller doesn't appear to order the whitelisted ip addresses, this is causing the controller to constantly reload on a 10s interval timer.
-            allow <IP_ADDRESS>/32;
-            allow <IP_ADDRESS>/16;
-            allow <IP_ADDRESS>/32;
             allow x.x.x.196/32;
             allow x.x.x.91/32;
             allow x.x.x.164/32;
             allow x.x.x.139/32;
+            allow <IP_ADDRESS>/32;
+            allow <IP_ADDRESS>/16;
+            allow <IP_ADDRESS>/32;
             deny all;
             # enforce ssl on server side

$ kubectl --namespace=ingress logs ingress-1936225639-bthcn 2>&1 | grep "NGINX configuration"
I1110 16:08:17.772854       1 utils.go:190] NGINX configuration diff a//etc/nginx/nginx.conf b//etc/nginx/nginx.conf
I1110 16:08:27.772171       1 utils.go:190] NGINX configuration diff a//etc/nginx/nginx.conf b//etc/nginx/nginx.conf
I1110 16:08:37.773965       1 utils.go:190] NGINX configuration diff a//etc/nginx/nginx.conf b//etc/nginx/nginx.conf
I1110 16:08:47.771990       1 utils.go:190] NGINX configuration diff a//etc/nginx/nginx.conf b//etc/nginx/nginx.conf
I1110 16:08:57.772153       1 utils.go:190] NGINX configuration diff a//etc/nginx/nginx.conf b//etc/nginx/nginx.conf
I1110 16:09:07.777353       1 utils.go:190] NGINX configuration diff a//etc/nginx/nginx.conf b//etc/nginx/nginx.conf
I1110 16:09:17.678405       1 utils.go:190] NGINX configuration diff a//etc/nginx/nginx.conf b//etc/nginx/nginx.conf
I1110 16:09:27.774084       1 utils.go:190] NGINX configuration diff a//etc/nginx/nginx.conf b//etc/nginx/nginx.conf
I1110 16:09:37.770101       1 utils.go:190] NGINX configuration diff a//etc/nginx/nginx.conf b//etc/nginx/nginx.conf
I1110 16:09:47.770506       1 utils.go:190] NGINX configuration diff a//etc/nginx/nginx.conf b//etc/nginx/nginx.conf
I1110 16:09:57.775239       1 utils.go:190] NGINX configuration diff a//etc/nginx/nginx.conf b//etc/nginx/nginx.conf

Hence every 10s i'm seeing
nobody   29510  0.0  0.0<PHONE_NUMBER>0 ?        Sl   16:12   0:00 nginx: worker process is shutting down
nobody   29511  0.0  0.0<PHONE_NUMBER>0 ?        Sl   16:12   0:00 nginx: worker process is shutting down
nobody   29512  0.0  0.0<PHONE_NUMBER>0 ?        Sl   16:12   0:00 nginx: worker process is shutting down
nobody   29513  0.0  0.0<PHONE_NUMBER>0 ?        Sl   16:12   0:00 nginx: worker process is shutting down
nobody   29514  0.0  0.0<PHONE_NUMBER>0 ?        Sl   16:12   0:00 nginx: worker process is shutting down
nobody   29515  0.0  0.0<PHONE_NUMBER>0 ?        Sl   16:12   0:00 nginx: worker process is shutting down
nobody   29516  0.0  0.0<PHONE_NUMBER>0 ?        Sl   16:12   0:00 nginx: worker process is shutting down
nobody   29517  0.0  0.0<PHONE_NUMBER>0 ?        Sl   16:12   0:00 nginx: worker process is shutting down
nobody   29783  0.0  0.0<PHONE_NUMBER>6 ?        Sl   16:12   0:00 nginx: worker process
nobody   29784  0.0  0.0<PHONE_NUMBER>6 ?        Sl   16:12   0:00 nginx: worker process
nobody   29785  0.0  0.0<PHONE_NUMBER>6 ?        Sl   16:12   0:00 nginx: worker process
nobody   29786  0.0  0.0<PHONE_NUMBER>6 ?        Sl   16:12   0:00 nginx: worker process
nobody   29787  0.0  0.0<PHONE_NUMBER>6 ?        Sl   16:12   0:00 nginx: worker process
nobody   29788  0.0  0.0<PHONE_NUMBER>6 ?        Sl   16:12   0:00 nginx: worker process
nobody   29789  0.0  0.0<PHONE_NUMBER>6 ?        Sl   16:12   0:00 nginx: worker process
nobody   29790  0.0  0.0<PHONE_NUMBER>6 ?        Sl   16:12   0:00 nginx: worker process

Just at a glance ... i'm guessing the issue is at https://github.com/kubernetes/contrib/blob/master/ingress/controllers/nginx/nginx/ipwhitelist/main.go#L56

@gambol99 fix to be included in next version.

cheers @aledbf  ... Any idea when the next release is scheduled? ... or I can just go an build a patched version for now ..

Any news on when the next release is scheduled?


Allow for unit testing? Unit testing can be a powerful way of learning about the data!

For example, I just ran a test to see if any trial had <90 degrees of pelvis rotation, and found that only one trial of one person did. This is very helpful! It would be great to auto-show results from this type of analysis in a table or PDF.

Definitely important! Unit tests can be another primitive object type, and users can add predefined or user-defined tests to each output variable of a function.

Duplicate of #50.


Handle known bad Amazon queries

There are some queries we know won't be accepted by Amazon (for example, queries can't be blank–it results in a blank result.)
We should validate the search for those very basic checks and supply an error message if a user tries to submit an invalid query.

@zr2d2 said he'd work on this one :tada:

Found another invalid query! An apostrophe seems to break signature generation: when I try to add "k'nex" or "sophie's world", I get the following error:
"Error"=>{"Code"=>"SignatureDoesNotMatch", "Message"=>"The request signature we calculated does not match the signature you provided. Check your AWS Secret Access Key and signing method. Consult the service documentation for details."}

There are two fixes to make here:

We should handle and log the "SignatureDoesNotMatch" error (currently it just shows a blank page)
We should make signatures work with apostrophes

Another error to handle:
"Error"=>{"Code"=>"RequestThrottled", "Message"=>"AWS Access Key ID: <redacted>. You are submitting requests too quickly. Please retry your requests at a slower rate."}


x/tools/cmd/godoc: url flag races against index creation

What version of Go are you using (go version)?

$ go version
go version devel +701f6a27b5 Mon Feb 11 18:18:45 2019 +0000 darwin/amd64

I'm comparing the x/tools repo at release-branch.go1.11 vs release-branch.go1.12.
Does this issue reproduce with the latest release?
Yes, this is broken in master of the x/tools repo.
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/rhys/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/rhys/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/49/zmds5zsn75z1283vtzxyfr5hj7yjq4/T/go-build329945537=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
go run golang.org/x/tools/cmd/godoc -url=/pkg/fmt -http=""
2019/02/15 10:34:12 HTTP error 404
exit status 1

What did you expect to see?
I expected to see HTML similar to what's served by https://golang.org/pkg/fmt/
What did you see instead?
I got an error message referencing an HTTP 404 code. It appears that the request to satisfy the url flag races against the index creation, so no packages are found.

I have a fix for this, including regression tests. I'll upload it shortly.

This is a regression from CL 141397, where the logic for whether to init corpus synchronously was modified. It was partially fixed for writing index mode in CL 141397, but not for url flag mode. It wasn't caught because we didn't have a test for the -url flag yet (we will after your CL, thanks for that).


Move to contrib?

Would you consider moving this to contrib? We'll trash photons and just use this if it's somewhere where multiple maintainers can contribute/admin it.

I'm definitely happy to move it to contrib, but I'd like to use the usual PR/review workflow.

For sure, it's more just for the very unlikely event that you stop working on this/purescript :smile:

Well if that ever happens, I'd definitely move my repos somewhere else, but they're all permissively licensed anyway, so using a fork in Bower should be doable.

The initial reason for this repo was as an experiment with profunctors, but it seems to have a dual purpose now as a more active lens replacement since @joneshf seems to be pretty busy these days. So I'd like for this to be a fairly stable API since things like Thermite and optic-ui depend on it. I might even switch over derive-lenses and foreign-lenses if people start using it.

Yeah, I remember that - I mentioned to Jon that I think it was intended to replace lens eventually when we talked about it the other day.
That's basically why we'd like to rely on it via contrib - so we don't end up in the simple-dom/optics situation we have now where there are minor changes that need making (version bumps and the like) but the original maintainer is busy with other things.
Forking is definitely an option when that happens, but it potentially means updating a whole bunch of other libraries as the dependency name will need changing for the fork too.
Stable is good, we don't really need anything other than what's already here aside from adding Contains, Index, At, which @jonsterling has put together and can PR on here, and then I added some prisms for Coproducts. Apart from that it's already awesome :)

Thanks!

Yep, I already saw the indexer stuff, on the photons repo. What I saw looked nice. Let's open a PR to just go over the module structure though.
And yes, this seems like a perfect candidate for contrib, since I'd like people to rely on it being around for a while. lens is technically pretty up to date, and compiles etc. but at least if it's in contrib, we can deprecate it or update it ourselves as need be.

sounds good! I'll open a PR later on today with that stuff.


[Bug] monaco.editor.tokenize does not return correct results

Reproducible in vscode.dev or in VS Code Desktop?

[X] Not reproducible in vscode.dev or VS Code Desktop

Reproducible in the monaco editor playground?

[ ] Not reproducible in the monaco editor playground

Monaco Editor Playground Code
monaco.editor.create(document.getElementById('container'), {
    value: "function hello() {\n\talert('Hello world!');\n}",
    language: 'typescript'
});

const tokens = monaco.editor.tokenize(`// My awesome TypeScript function!
export const areEqual = (a: number, b: number): boolean => {
    return a === b;
}`, "typescript");

console.log("tokens", tokens);

const tokensEscaped = monaco.editor.tokenize("// My awesome TypeScript function!\nexport const areEqual = (a: number, b: number): boolean => {\n\treturn a === b;\n}", "typescript");

console.log("tokensEscaped", tokensEscaped);

Reproduction Steps

Try to pass a preformatted string to monaco.editor.tokenize
Log out the results via console.log

Actual (Problematic) Behavior
Tokens are not detected (though lines are)
Expected Behavior
Tokens to be detected!
Additional Context
The strange thing is that if you paste the following into the terminal, it works:
tokens = monaco.editor.tokenize(`// My awesome TypeScript function!
    export const areEqual = (a: number, b: number): boolean => {
        return a === b;
    }`, "typescript");
console.log("tokens", tokens);
tokens (4) [Array(1), Array(27), Array(9), Array(1)]

I feel like this is some sort of initialization issue... but calling monaco.editor.tokenize even multiple times within my code doesn't seem to solve the problem, I still get empty token lines... very strange.
As you see I thought it was an escaping of \n and \t issue, but even the escaped single line string doesn't work....
Perhaps this is something small, but I can't see what is going wrong here. Need another set of eyes.

I looked into this further, this is almost definitely an initialization or asynchronous related bug. When I do this:
setTimeout(() => {
    const tokens = monaco.editor.tokenize(`// My awesome TypeScript function!
export const areEqual = (a: number, b: number): boolean => {
    return a === b;
}`, "typescript");

console.log("tokens", tokens);
}, 5000)

It works!
Perhaps tokenize should be Promise<Token[][]> ? Or there at least needs to be a way to check when the editor is ready, really I still have no idea what is going on internally to cause this behaviour.

You can do this before calling tokenize:
await languages.TokenizationRegistry.getOrCreate(languageId);

Closed

I can't find this anywhere in the Monaco documentation, nor is TokenizationRegistry a property on the TypeScript types for languages:
import { languages } from "monaco-editor/esm/vs/editor/editor.api";
// ...
await languages.TokenizationRegistry.getOrCreate("typescript");

Property 'TokenizationRegistry' does not exist on type 'typeof languages'.ts(2339)

Unless I'm mistaken and this languages is coming from some other library?
Therefore I would like a bit more clarification on this issue before it is closed.

Ah, it is only exposed by vs/editor/common/languages.

For anyone who may find this later, I currently have a fairly reliable workaround. essentially I access the global window.monaco object within a setTimeout and call tokenize. While this one usually fails, all subsequent tokenize calls work:
setTimeout(() => {
  (window as any).monaco.editor.tokenize(
    `export const dummyFunction = () => {
  console.log('hello world')
}`,
    "typescript"
  );
}, 1000);

obviously, I'd like to not use this hack, but it gets the job done for now.


URLSession: Dont try to send a body when URLRequest.httpBody is an empty Data()

If the .httpBody is set to an empty Data() instance then treat this
as if there was no .httpBody set and do not attempt to send a zero
byte body to the remote server.

Update TestURLSession.test_requestWithEmptyBody() and
TestURLSession.test_requestWithNonEmptyBody() to check the delegate
callbacks and the posted body sent back in the response.

@swift-ci test linux


CLI: Update references to Gotham when creating a new site

I agree with you. I have updated the commit and removed the reference to docs.gothamhq.com for now. We should merge this for now and we can open another PR once the docs / themes sites are live.


feat!: Boxing Day

Overview

Box spent the summer in France with cousins returned as an international polygon of mystery, and is now the coolest freshman in the history of CC High.
FlexBox and GridBox were there too I guess - but they are just younger siblings who follow Box around - v uncool

PR Checklist

[ ] Related to designs:
[ ] Related to JIRA ticket: ABC-123
[ ] I have run this code to verify it works
[ ] This PR includes unit tests for the code change

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.105-alpha.618a61.0@codecademy/gamut-labs@31.8.1-alpha.618a61.0@codecademy/gamut@46.1.2-alpha.618a61.0@codecademy/monaco@0.6.34-alpha.618a61.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6259a86718137405749a8e11--gamut-preview.netlify.appDeploy Logs

📬Published Alpha Packages:@codecademy/gamut-kit@0.6.106-alpha.7b658b.0@codecademy/gamut-labs@31.8.2-alpha.7b658b.0@codecademy/gamut@46.1.3-alpha.7b658b.0@codecademy/monaco@0.6.35-alpha.7b658b.0<EMAIL_ADDRESS>
🚀 Styleguide deploy preview ready!https://6259aaa44a8d110689c1dffa--gamut-preview.netlify.appDeploy Logs

❤ u @codecaaron


Change require('invariant') to require('fbjs/lib/invariant')

FIX #10400

Checking for "fbjs/lib" in certain requires could be good lint rule
@facebook-github-bot shipit


revert mint java code in preparation for mint in k in ocaml backend

Jenkins: test this please

Jenkins: test this please

Jenkins: test this please

Jenkins: test this please

Jenkins: test this please

@Andrew-Miranti does this resolve your issue?


Fix Postgresql environment variable name for password

Environment variable name of the password should be POSTGRES_PASSWORD instead of DB_PASS.
See documentation https://hub.docker.com/_/postgres/

CI for helm/charts needs some TLC, so ignore the failure. I tested this by hand. Thanks @etiennetremel!


If manufacturer is unknown use the OUI lookup from

https://github.com/Bluetooth-Devices/bluetooth-adapters/blob/cf855cac5ecd4cb220e1a08ba26ee9ff73249f22/src/bluetooth_adapters/systems/linux.py#L66
mac_vendor_lookup

Borrow example from ibeacon-ble

closed via #30


Signaling and media

The charter mentions considerations relating to both signaling and media.  It seems to me to me that the goals of each of these areas should be clearly (and distinctly) defined.

related to #14


PHP fatal error when I reload vscode after installing twigcs

[twigcs] PHP Fatal error: Declaration of Allocine\Twigcs\Compatibility\TwigLexer::tokenize(Twig_Source $source) must be compatible with Twig_LexerInterface::tokenize($code, $name = NULL) in /Users/martinsjastad/.composer/vendor/allocine/twigcs/src/Compatibility/TwigLexer.php on line 28

I encountered this issue too, but I managed to solve it. The issue occurred because I had an outdated version of twig (1.x). Upgrading twig to 2.x solved the problem.


I had A problem run demo.py

I had a problem with the last sentence of the demo（“attack_eval.eval(dataset, visualize=True)”）, and I don't know why

This problem is caused by nltk.data.load which perfomers differently when facing different paths on Windows. You can add the following piece of code right after "import OpenAttack" to solve the problem.
def nltk_loader(loader):
return lambda x: loader('file:' + x)
for name in OpenAttack.DataManager.data_loader:
if name in ["TProcess.NLTKSentTokenizer", "TProcess.NLTKPerceptronPosTagger"]:
OpenAttack.DataManager.data_loader[name] =
nltk_loader(OpenAttack.DataManager.data_loader[name])
We will handle this trouble in the next version.

When I put the following code at the beginning of Demo.py, I ran into a new problem (as shown in the screenshot).
def nltk_loader(loader):
    return lambda x: loader('file:' + x)
for name in OpenAttack.DataManager.data_loader:
    if name in ["TProcess.NLTKSentTokenizer", "TProcess.NLTKPerceptronPosTagger"]:
        OpenAttack.DataManager.data_loader[name] = \
            nltk_loader(OpenAttack.DataManager.data_loader[name])


Template Updates: DIY

Context
Updating the templates to match new designs.
~Note: new animations are being added later, so those have not been implemented here.~
April 10, 2021: Custom animations have been removed for existing animations
Summary
Updates the DIY template.
Relevant Technical Choices
n/a
To-do

[ ] Design review

User-facing changes
Before:
https://user-images.githubusercontent.com/22185279/113633370-1466b400-962a-11eb-97fd-0fe825f8295b.mov
After:
https://user-images.githubusercontent.com/22185279/113633367-12045a00-962a-11eb-8521-e6d3224c166f.mov
Should match these specifications:

Testing Instructions

Select the template the Explore Templates section in the dashboard
Go to the preview
Watch the new template with animations
Make sure the colors and animations line up with the figma document - there should be no custom animations

QA

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

Select the template the Explore Templates section in the dashboard
Go to the preview
Watch the new template with animations

UAT

[x] UAT should use the same steps as above.

Reviews
Does this PR have a security-related impact?
no
Does this PR change what data or activity we track or use?
no
Does this PR have a legal-related impact?
no
Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[ ] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #6971

Stickers are still behind a feature flag.
If we update the templates to use the new stickers feature, we should probably enable that flag by default ASAP.
FYI @BrittanyIRL

Stickers are still behind a feature flag.
If we update the templates to use the new stickers feature, we should probably enable that flag by default ASAP.
FYI @BrittanyIRL

We're just subbing out the existing "shapes" here for "stickers", like we did with the hearts on the beauty quotes. There's nothing really to interact with by anyone except pea pod implementing these. It's a bit of a test run with the whole thing. Unless I'm misreading what you are concerned about?

Ugh, apologies 🤦 I was worried that stickers as a whole are behind a feature flag. Turns out only the stickers panel is. False alarm!

Ugh, apologies 🤦 I was worried that stickers as a whole are behind a feature flag. Turns out only the stickers panel is. False alarm!

ohhh yeah that would be an issue! I'm glad you double checked and that it's a false alarm!

@BrittanyIRL could you please reply to the CLA bot since you made some changes here? thanks 🙂

@googlebot I consent.

Small fixes:
Page 3

Remove animation from image and "anonymous" text

Page 5

Remove animation from CTA text

Page 8

Remove animation from CTA text

Small fixes:
Page 3

Remove animation from image and "anonymous" text

Page 5

Remove animation from CTA text

Page 8

Remove animation from CTA text


proxy filtered-groups: Populate Region field API calls

Description
Populates the new Region field on all of the filteredgroupapi calls.
Related Issues
Requires https://github.com/elastic/cloud-sdk-go/pull/144 to be merged
Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Refactoring (improves code quality but has no user-facing effect)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation

Readiness Checklist

[x] My code follows the code style of this project
[ ] My change requires a change to the documentation
[ ] I have updated the documentation accordingly
[ ] I have added tests to cover my changes
[x] All new and existing tests passed

I'm merging this since I need it for my PR


Structure lib

The second commit should not work speaking from one comment in the code, but it seems to do anyway 🤔

Ah, the core::unreachable!() was changed at some point to always use the libcore panic!() macro. Since we track stable Rust, relying on that should be fine.


feat: add carbon components vue for Carbon 10

Add updates for carbon-components-vue
Changelog
A       src/content/getting-started/developers/vue.md
A       src/content/resources/images/vue-icon.png
M       .github/ISSUE_TEMPLATE/question.md
M       docs/CONTENT.md
M       src/components/ComponentCode/ComponentCode.js
M       src/components/ComponentExample/ComponentExample.js
M       src/components/ComponentStatus/ComponentStatus.js
M       src/content/components/accordion/code.md
M       src/content/components/breadcrumb/code.md
M       src/content/components/button/code.md
M       src/content/components/checkbox/code.md
M       src/content/components/code-snippet/code.md
M       src/content/components/content-switcher/code.md
M       src/content/components/data-table/code.md
M       src/content/components/date-picker/code.md
M       src/content/components/dropdown/code.md
M       src/content/components/file-uploader/code.md
M       src/content/components/form/code.md
M       src/content/components/inline-loading/code.md
M       src/content/components/link/code.md
M       src/content/components/list/code.md
M       src/content/components/loading/code.md
M       src/content/components/modal/code.md
M       src/content/components/notification/code.md
M       src/content/components/number-input/code.md
M       src/content/components/overflow-menu/code.md
M       src/content/components/pagination/code.md
M       src/content/components/progress-indicator/code.md
M       src/content/components/radio-button/code.md
M       src/content/components/search/code.md
M       src/content/components/select/code.md
M       src/content/components/slider/code.md
M       src/content/components/structured-list/code.md
M       src/content/components/tabs/code.md
M       src/content/components/tag/code.md
M       src/content/components/text-input/code.md
M       src/content/components/tile/code.md
M       src/content/components/toggle/code.md
M       src/content/components/tooltip/code.md
M       src/content/contributing/developers/developers.md
M       src/content/contributing/governance/governance.md
M       src/content/getting-started/about-carbon/about-carbon.md
M       src/content/getting-started/developers/angular.md
M       src/content/getting-started/developers/other-frameworks.md
M       src/content/getting-started/developers/react.md
M       src/content/getting-started/developers/vanilla.md
M       src/content/getting-started/faq/faq.md
M       src/content/help/faq/faq.md
M       src/content/help/support/support.md
M       src/content/index.md
M       src/content/resources/resources.md
M       src/data/components.json

Ahhh, looks like you may have been working off of an out of date fork?

Ahhh, looks like you may have been working off of an out of date fork?

Sure does, let me take a crack at fixing that.

Merging manually in a fresh fork.


Set HISTFILE to .${ROOT_SHELL}_history_root

Prevents ownership of $HISTFILE being changed to root (and then being unusable for the non-root shell)
I'm pretty sure we have a related bug report somewhere on the termux repo but I can't find it.

I'm reworking tsu..
But I will merge this for now


Sidebar shifts to right when a Bootstrap modal is opened

This isn't a huge deal, but it would be nice to be able to avoid having the sidebar shift to the right when a Bootstrap modal is invoked.  Bootstrap removes the scrollbar of the main viewport when a modal is opened, and thus the sidebar gets shifted to the right.  It's not a functional issue, but aesthetically it is distracting.
Given all the magic Bootstrap uses behind the scenes there is no simple CSS fix to prevent the issue without causing other problems.  Is there anything that could be added to allow the sidebar to detect removal of a scrollbar and compensate for that?

If I understood correctly, it's the same issue like when we have a dynamic width sidebar which is closed and the window is resized. Then a little part of the sidebar is shown.
I'm not sure but, we may fix the both issues using $(window).on("resize", doTheMagic).
Would you like to fix this?


Actually get nested virt

Without those options, at least on CS9 hypervisor, nested virt didn't
seem to work.
A VM created with this patch applied passes the virt-host-validate
CLI.
This PR has:

[X] Appropriate testing (molecule, python unit tests)
[X] Appropriate documentation (README in the role, main README is up-to-date)

recheck
weird issue with SSH...


Feature request: Ability to reorder PSTHs by selectivity

In some Dandisets we have PSTHs of 1000s of units.
https://neurosift.app/?p=/nwb&url=https://api.dandiarchive.org/api/assets/b305ccec-fa84-445e-aea5-0126d6eff558/download/&dandisetId=000253&dandisetVersion=draft&tab=view:PSTH|/intervals/create_receptive_field_mapping_presentations
With so many units, it can be laborious to look through these units to find the most interesting ones. It would be nice if we had a basic statistical test that allowed us to optionally reorder units so the ones that differentiate the category of interest most are first. We could put this in the Advanced section so it does not clutter the interface.

A couple issues here. First is figuring out what statistical test to use -- and that is going to depend on which variables are selected. Second is the computation/download time. Right now the data are downloaded lazily per unit -- I think it will be very time-consuming to download all of the data in order to make this computation -- at least in the example you shared. This might be something that is better performed in a Python script outside the browser...

Can you currently filter/order the PSTH widget by some other column of the Units column?
These can oftentimes be quality metrics, including possibly a custom field that a user creates (or NeuroConv/SI creates for them) representing a 'PSTH quality score' as imagined in this issue - that way you could be general about it and offload computation concerns to the file contents
Example on IBL: https://neurosift.app/?p=/nwb&url=https://api.dandiarchive.org/api/assets/37e571e6-cab5-4777-ac07-bffca527255e/download/&dandisetId=000409&dandisetVersion=draft
the 'label' property (proportion of quality metrics passed)

@CodyCBakerPhD That sounds doable. I'll see what I can put together.

Okay, there is now a "sort units by" selector in the advanced options

Awesome! Someone should think of some potential PSTH-relaated quality metrics (scalars) that could go into SI or somewhere else for this purpose
Just to put the idea in your head to imagine a more general UX that could work - how about joint filters, such as 'greater than 0.01 Hz firing rate && contamination ratio less than 0.5'?

Nice!


creating401UniqueRecords Test Method Fails

I dropped SmartFactory into a fresh dev org this morning and noticed the creating401UniqueRecords() test method is failing with "too many script statements: 200001".
I tweaked the last createSObjectList parameter on line 54 in SmartFactory_Tests and determined that 323 records pass and 324 records fail.
Let me know if you need more details or further testing. I forked the project with the intent of adding some default value parameters. This project has great potential for us - happy to help if you need anything.

Since SmartFactory wasn't designed for bulk data creation, I've removed the bulk unit tests.


Logging API. Add generated files.

These are the generated files for Logging API. I have made the PR against pubsub-alpha, since that is where the new branch is based off of. Ideally, this commit should go into ''logging-alpha'' branch of the repo.

Will redo this against the right branch.


Include "Housing Included" in the School Cards

Feature
"Housing Included" should be on the school cards.
Why is this feature being added?
Many coding boot camps include free housing for their students for the duration of their course, and i think that knowledge could be a big game changer for those seeking the right school to attend.
Schools that offer free housing that I know of: V School, 42, Dev Mountain, and CodeMasters Academy.
Schools that offer free housing and accept the GI Bill: V School.

Help narrow down this incredibly big decision for the Veteran.
What should your feature do?

Closed for #934


Azure Policy - Remediation tasks order

Bug exists on page
https://www.azurecitadel.com/arc/servers-hack/policy/#azure-policy
Describe the bug
Remediation will fail, add later in steps

I'm thinking we need to review the Azure Policy labs in light of GitHub Copilot. Thoughts?


Strange encrypt memo checkbox display

Can you make sure you re using the latest version?  <IP_ADDRESS>


PyQt versions of SelectROI and FileRenamer added/ updated

SelectROI is fuctional, FileRenamer is still in development

@JRMeyer it looks like you've included some temp files (ex. FileRename_Qt.py~).  Please remove these and push.  You might want to add a .*~ pattern to .gitignore to avoid adding them accidentally in the future.

When I run SelectROI_Qt.py and select a single .jpg file, it crashes with this error:
ValueError                                Traceback (most recent call last)
<ipython-input-3-0be69a7ff5cf> in <module>()
     37
     38 if __name__ == '__main__':
---> 39     main()

<ipython-input-3-0be69a7ff5cf> in main()
     31 def main():
     32     app = QtGui.QApplication(sys.argv)
---> 33     roi = ROI_selector()
     34     roi.destroy()
     35     sys.exit()

<ipython-input-3-0be69a7ff5cf> in __init__(self)
     10         super(ROI_selector, self).__init__()
     11         self.selectImages()
---> 12         self.getSumImage()
     13
     14     def selectImages(self):

<ipython-input-3-0be69a7ff5cf> in getSumImage(self)
     25                         img = cv2.imread(str(i))
     26                         tmp = numpy.zeros(self.csize)
---> 27                         tmp += img
     28                         sum_img += tmp
     29                 sum_img = sum_img/len(self.datafiles)

ValueError: operands could not be broadcast together with shapes (480,720) (480,720,3) (480,720)

The input for SelectROI_Qt.py is a folder of images (a dir not a file).
If we want to change that I can. Let me know.
Also, a dependency for the script is pyqtgraph. http://www.pyqtgraph.org/
Pyqtgraph itself only depends on PyQt4 and numpy, and it handles ROI
selection very cleanly, which was my thinking in using it.
I mentioned the additional dependency at our last couple meetings and no
one seemed opposed. In general don't like adding on more, but it is a very
useful library.
2015-03-10 17:05 GMT-07:00 Gustave Hahn-Powell<EMAIL_ADDRESS>
When I run SelectROI_Qt.py and select a single .jpg file, it crashes with
this error:
ValueError                                Traceback (most recent call last) in ()
37
38 if name == 'main':---> 39     main()
 in main()
31 def main():
32     app = QtGui.QApplication(sys.argv)---> 33     roi = ROI_selector()
34     roi.destroy()
35     sys.exit()
 in init(self)
10         super(ROI_selector, self).init()
11         self.selectImages()---> 12         self.getSumImage()
13
14     def selectImages(self):
 in getSumImage(self)
25                         img = cv2.imread(str(i))
26                         tmp = numpy.zeros(self.csize)---> 27                         tmp += img
28                         sum_img += tmp
29                 sum_img = sum_img/len(self.datafiles)
ValueError: operands could not be broadcast together with shapes (480,720) (480,720,3) (480,720)
--
Reply to this email directly or view it on GitHub
https://github.com/jjberry/Autotrace/pull/8#issuecomment-78175572.

--
Joshua Meyer
Ph.D. Student
Linguistics Department
University of Arizona

Hmm... it will only allow me to select images (the message at the top of the window also seems to suggest that's what the user should do).  Still no luck.  Any ideas?

@JRMeyer can you reopen this request on the APIL fork of AutoTrace?  Before doing that, though, I think some of this stuff should be moved to the data-analysis repo.


Bugfix in parquet writing empty lists of structs

Which issue does this PR close?
Closes #703
What changes are included in this PR?
Fix a bug in the definition level calculation for fields nested within a struct and a list. When a list is empty or null in parquet the nested field gets a null value. However, in arrow, the value is simply missing.  When serializing an immediate child of the list, the list offsets are used to calculate the correct definition level for its children, but it is not carried further to fields nested deeper (e.g., fields on a struct within a list).  This (somewhat hacky) fix treats a struct within a list as if it were a list.
Are there any user-facing changes?
No.

Codecov Report

Merging #1166 (608d211) into master (884c6a6) will increase coverage by 0.04%.
 Consider uploading reports for the commit 33b6543 to get more accurate results

@@            Coverage Diff             @@
##           master    #1166      +/-   ##
==========================================
+ Coverage   82.55%   82.59%   +0.04%
==========================================
  Files         173      173
  Lines       50673    50753      +80
==========================================
+ Hits        41833    41920      +87
+ Misses       8840     8833       -7

Impacted Files
Coverage Δ

parquet/src/arrow/levels.rs
84.28% <100.00%> (+1.40%)
:arrow_up:

arrow/src/array/transform/mod.rs
85.43% <0.00%> (-0.27%)
:arrow_down:

arrow/src/array/builder.rs
86.60% <0.00%> (+0.11%)
:arrow_up:

parquet_derive/src/parquet_field.rs
66.21% <0.00%> (+0.22%)
:arrow_up:

arrow/src/compute/kernels/arithmetic.rs
85.57% <0.00%> (+0.92%)
:arrow_up:

parquet/src/arrow/arrow_reader.rs
90.93% <0.00%> (+1.00%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 884c6a6...33b6543. Read the comment docs.

cc @mosyp and @chadbrewbaker

Thanks @helgikrs !


Encrypt SSHKey.private_key database field

FIELD_ENCRYPTION_KEY could be a list to support key rotation. This commit adds one as example, but the production value is stored in a private repository.
Based on #4303

Is there an easy method to decrypt, if say we wanted to switch encryption schemes on this field?

To decrypt the field we just access it via the Django field.
In case we can't access it using this module for whatever reason, we can use the same code to decrypt the field, which is simple. It only creates a crypter instance using the encrypt keys and then just call decrypt.

Oh, just had another idea. Perhaps we should have a security check on django start that looks for the default key and throws a warning or error? I'd feel safe shipping this with that change. Think that is overkill?

I'd expected that from the app since I saw this code while I was reading how it works: https://gitlab.com/lansharkconsulting/django/django-encrypted-model-fields/blob/develop/encrypted_model_fields/fields.py#L27
Although, I just checked for the app configuration and there is nothing in that module.
I agree with you that it's a good idea to have that checking in our side since it's not in the app already :/

Ha! I ran my test without the ssh app installed. I'm dumb.
Anyway, the code from the app fails at this point if the setting is not defined: https://gitlab.com/lansharkconsulting/django/django-encrypted-model-fields/blob/develop/encrypted_model_fields/fields.py#L24 because they are not proving the default value (None) that are checking in the next line.
So, if the key is not defined our server won't start because of that. That portion of code is ran on server startup since we import a field from that file.
I'm proposing a PR to fix that at https://gitlab.com/lansharkconsulting/django/django-encrypted-model-fields/merge_requests/11


Improve new user flow

[ ] npm start fails if on a version of Node that doesn't run ES6. We should use nvm or similar to require 6.4 (based on destructuring support, without which webpack fails)  or greater (have we decided formally on a target?)
[ ] Be more explicit in README about MAPBOX_ACCESS_TOKEN requirement and in error if not set up. I see this is in ./demo, but ./example/layer-browser requires it too, which means npm start fails out-of-the-box.
[ ] Install layer-browser deps the right way. postinstall hook is not correct. Will be fixed by https://github.com/uber/deck.gl/pull/504/.

@ibgreen any thoughts on Node version managing? Any precedent in other libs?

We should use nvm or similar to require 6.4

Hmm, while I am always open to ideas, I don't think we should be installing/running nvm. It is really the user's responsibility to organize his development environment and manage different node versions.

(based on destructuring support, without which webpack fails)

This doesn't sound right. Webpack should not require Node 6? Maybe just something in our webpack config files? They don't have to use every ES6 feature...
(have we decided formally on a target?)
Node version 6 brings ES6 support which is something we leveraged in deck.gl v4  to make tests run without transpilation. This was a pretty big effort and I would not like to go backwards.
I don't personally see a value in supporting use of old node versions for development of deck.gl.
We should certainly update the requirement listed in the README
https://github.com/uber/deck.gl/blob/master/README.md#node-version-requirement. Open a PR?

@ibgreen any thoughts on Node version managing? Any precedent in other libs?

I am not aware of any ways to provide warnings during development, other than adding additional scripts like you suggested.  The engines field in package.json is used during installation of the published package so not useful here.

Be more explicit in README about MAPBOX_ACCESS_TOKEN requirement and in error if not set up. I see this is in ./demo, but ./example/layer-browser requires it too, which means npm start fails out-of-the-box.

Just to confirm, failing to set the token should only mean that the map doesn't render. The app should still build and run. If that's not the case we have a problem.
FWIW, I just opened a doc-fix PR that adds more info about tokens, but of course this remains a "gotcha" for the casual user who jumps directly into the example without reading the docs, installs and runs, and fails to get a map.

Install layer-browser deps the right way. postinstall hook is not correct. Will be fixed by #504/.

Merged, thanks!

This doesn't sound right. Webpack should not require Node 6? Maybe just something in our webpack config files? They don't have to use every ES6 feature...

Correct, the layer-browser example's webpack config uses destructuring. I guess alternatively we can not use ES6 in there, but that seems antithetical to the motion toward not even transpiling.

Just to confirm, failing to set the token should only mean that the map doesn't render. The app should still build and run. If that's not the case we have a problem.

Correct, but without the map, (and with no layers on by default) the example feels broken.

Correct, the layer-browser example's webpack config uses destructuring. I guess alternatively we can not use ES6 in there.

Node 4 supports a lot of ES6 features - just not everything. I think just replacing the restructuring construct would likely make the rest of the config work on Node 4. PR welcome :)
And thinking more about this, you are absolutely right here: Ideally we would support two levels of Node.js (>6 for development of the core library, but >4 should suffice for running the examples).
Since we all work on Node 6 it can be hard to notice when we break Node 4 support, but that doesn't mean we shouldn't try.

Without the map, (and with no layers on by default) the example feels broken

Good point. I guess we could check that token != null in the examples and show some error in the browser (worst case, we could just use an ugly window.alert if we think this is better than just mysteriously showing no map?)

With #504, #507, #508, and #509, we can close this.


Fix needing two clicks to open search in Safari

Description
In safari, it requires two clicks on the "Search" button in the nav bar in order to open it. I fixed this by adding:
imba.commit().then do around some of the code in the show method that shows the search UI. I'm not sure this is the best technique, using a 1ms setTimeout also works.
How Has This Been Tested?
In my browser locally
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[x] I have read the CONTRIBUTING document.
[x] I have updated/added documentation affected by my changes.
[x] I have added tests to cover my changes.

I'm assuming this got solved one way or another? The search button seems to work fine on Safari on my machine, but I don't want to close this prematurely. Is this still an issue?

yeah it works for me now too...


Upgrade to newer Azure Storage SDK

We currently work against v6.0 of the Azure SDK. This is quite old and has some breaking changes from the newer versions. We should upgrade to a later version.

Note this has implications for other downstream dependencies such as JSON .Net as the other Storage ones e.g. EDM.


259 detailed report message for drive docs

🗣 Description
Update Drive and Docs rego and unit tests to support detailed report messages and group override policy
Closes #259
💭 Motivation and context
This issue is part of the epic #190 and #90
🧪 Testing
Ensure all use cases for report and unit tests pass
✅ Pre-approval checklist

[x] This PR has an informative and human-readable title.
[x] Changes are limited to a single goal - eschew scope creep!
[x] If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
[x] The relevant issues PR resolves are linked preferably via closing keywords.
[x] All relevant type-of-change labels have been added.
[x] I have read and agree to the CONTRIBUTING.md document.
[x] These code changes follow cisagov code standards.
[x] All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
[x] Tests have been added and/or modified to cover the changes in this PR.
[x] All new and existing tests pass.

✅ Pre-merge Checklist

[x] This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
[ ] Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

[ ] Delete the branch to clean up.
[ ] Close issues resolved by this PR if the closing keywords did not activate.

It looks like the last edit requested by Alden was completed by Sheetal yesterday! Looks like it should be good to go now?

It looks like the last edit requested by Alden was completed by Sheetal yesterday! Looks like it should be good to go now?

Unfortunately, this PR won't make it in time for this release. I only reviewed group 1. We didn't have enough time to get to the remaining groups.

It looks like the last edit requested by Alden was completed by Sheetal yesterday! Looks like it should be good to go now?

Unfortunately, this PR won't make it in time for this release. I only reviewed group 1. We didn't have enough time to get to the remaining groups.

Gotcha. All good.


Retry the connection after N*2 seconds if it fails

I just noticed a frustrating issue. Sometimes when you try to reach too much a server, it could put you in a queue list and you have to wait some seconds (usually one or two) to re-try. With the current version (1.0.1), my Convos installation tries to reach the server every ~500ms.
Can't we add a progressive timer for new connections if those fail?
Pseudocode
# in seconds
n = 1
if connection fails
    n = n*2;
    wait(n);

retry_connection

I find that very difficult to believe that you get reconnected after 500ms. There are some tests that says otherwise, and we used to have a lot of issues being kicked off before the tests and logic was in place.
The only exception is if you connect to "localhost".  The reasoning behind this is that whoever set up "localhost", is probably also in charge of Convos, and can therefor change the IRC server settings to allow instant connections for all users.
Either way: In b2dddd9, I've added a safe guard that looks for the "Trying to reconnect too fast." message that is sent by the IRC server (at least some) and will sort of use the same logic as in your pseudocode.
FYI: The reconnect timer can be configured though. CONVOS_CONNECT_DELAY default to 4 seconds, but can be set to 0.5. Doing so, will result in what you describe in the issue description.


Support for Apache HttpClient as Feign client

I added support for using an Apache HttpClient as the client for executing Feign HTTP requests

NetflixOSS » feign » feign-pull-requests #99 FAILURE
Looks like there's a problem with this pull request

NetflixOSS » feign » feign-pull-requests #101 SUCCESS
This pull request looks good

NetflixOSS » feign » feign-pull-requests #102 SUCCESS
This pull request looks good

NetflixOSS » feign » feign-pull-requests #103 SUCCESS
This pull request looks good

Thanks, Tristan! Only a couple small things then good to go.

Make the class final and change access to thinga marked protected to
package private. We don't want to support things that break due to
unexpected extension.
version is 8.3 as 8.2 just went out :)

Good job and looking forward to the new driver!

NetflixOSS » feign » feign-pull-requests #108 SUCCESS
This pull request looks good

NetflixOSS » feign » feign-pull-requests #109 SUCCESS
This pull request looks good

@adriancole Any ideas as to the timing of the 8.3.x release? Or will you be publishing snapshots (looks like the last published snapshot was 7.0.0-SNAPSHOT)?

I'll publish 8.3 by wednesday night pacific time.

@adriancole awesome!

ok tag pushed. magic should make this hit maven central later this afternoon!

Sweet! thanks
On Wed, May 13, 2015 at 2:53 PM, Adrian Cole<EMAIL_ADDRESS>wrote:

ok tag pushed. magic should make this hit maven central later this
afternoon!
—
Reply to this email directly or view it on GitHub
https://github.com/Netflix/feign/pull/229#issuecomment-101814045.