add integration with train network for players

Hey there,
I had a request https://github.com/leehuk/factorio-tnfp/issues/12 to add integration between TNfP and Vehicle Wagon 2, as tnfp tracks trains by their train.id field -- this changes when vehicle wagon 2 swaps the wagons around between loaded/unloaded and tnfp then notices the original trains no longer valid for use
Looked feasible to wrap the wagon replacement with a hook to notify tnfp, which can then handle the swap gracefully
Could you let me know what you think and whether you'd be up for merging it please?
Cheers, Lee H

There are lots of mods that change train IDs around, so I'm hesitant to add a special behavior here.  It would be better if you stored the LuaEntity and unit_number of the lead engine, for example, and checked what train it is currently in.  Or you could listen to on_train_created (which gives the new train, and 0, 1, or 2 old trains from which it was created) to detect when one of your tracked IDs changes.

Ahh I'd not clocked on_train_created passed the old id through, which is basically what this PR was recreating.  If there's a generic event thats much better
Thanks for the feedback, thats a massive help 👍

It'll be a little tricky because when the wagon is deleted, two different trains are created with the same parent. But in this case they will probably be merged back together so it doesn't matter which one you track.


where did dwlocalplayer go?

?!

What do you mean?

What do you mean?

Nvm lol, forgot to close it, dwLocalPlayerPawn is dwlocalplayer


failFast:true disables maxRetries config option

I am using creevey to run in our ci pipelines and fighting with some flaky tests/components, this is why I used a maxRetries: 5 setting. To get some faster feedback I also used the new failFast: true config option. Unfortunately it seems that failFast: true kind of disables the maxRetries config option and immediately fails on the first failing screenshot.
When both options are set I think it would be a more expectable behaviour when screenshotting is retried until maxRetries is reached and then creevey fails.

Hm... You're right, I didn't think about that combination, I'll take a look, it should be easy to fix.

@wKich great!


WIP: add gofmt check for pkg

add a check gofmt for PR.
For the time beeing this is for libvirt pkg golang only (since there is only 1 pkg atm)

Coverage remained the same at 49.397% when pulling 801f57b76d95e3eff952b961038075bb8e34deee on MalloZup:gofmt-travis into b03e4140f8d1cb4f06fd4e56aadf18aafb0bde6f on dmacvicar:master.

Coverage remained the same at 49.397% when pulling c3d694326defbfabdead0ba1cc7a5315dd9a41af on MalloZup:gofmt-travis into b03e4140f8d1cb4f06fd4e56aadf18aafb0bde6f on dmacvicar:master.

Coverage remained the same at 49.397% when pulling c3d694326defbfabdead0ba1cc7a5315dd9a41af on MalloZup:gofmt-travis into b03e4140f8d1cb4f06fd4e56aadf18aafb0bde6f on dmacvicar:master.

Coverage remained the same at 49.397% when pulling f6e8993cf58adf96a20385cb8561ad296f7d1b89 on MalloZup:gofmt-travis into b03e4140f8d1cb4f06fd4e56aadf18aafb0bde6f on dmacvicar:master.

Coverage remained the same at 49.397% when pulling 19a55f916d26966854628bb6526b308c22773997 on MalloZup:gofmt-travis into b03e4140f8d1cb4f06fd4e56aadf18aafb0bde6f on dmacvicar:master.

Coverage remained the same at 49.397% when pulling 698585f7fabdc8ca9f1bd85c9467cf3b79e66237 on MalloZup:gofmt-travis into b03e4140f8d1cb4f06fd4e56aadf18aafb0bde6f on dmacvicar:master.

Coverage remained the same at 49.397% when pulling 0c8d91a006a722b6b96dbf80902167a1a1370c92 on MalloZup:gofmt-travis into b03e4140f8d1cb4f06fd4e56aadf18aafb0bde6f on dmacvicar:master.


ProgressBar doc displays "None" intent but "Danger" is selected

@yozhgoor small one if you want

It doesn't look like it worked.... though the deployment seems alright

Fixed, was a problem from the deployement on Netlify


Incremental timeouts

Allow timeout as a function that receives the attempt number and let you specify the timeout value for the next request.

I don't think it's a good way to implement this. It should better be an option in qwest, don't you think?

Closed for inactivity.


Cached Manifests during Kubernetes deployment

Description
This PR fixes #2580
Notes for Reviewers
Added a yaml sruct and a new function for getting cached local manifests
Signed commits

[x] Yes, I signed my commits.

@piyushsingariya should I look into setting a unit test for the new function? If so, where are the unit tests so I can see how they are made?

@navendu-pottekkat @kumarabd a question on unit tests for mesheryctl.

@Maxgit3 We do not have unit tests for mesheryctl currently, but it is something that we are planning to add shortly. I would put it in the next release v0.7

@Maxgit3 @piyushsingariya What is the status for this PR?

@navendu-pottekkat I think it would just need to be tested to run offline.  I was looking into how that could be done.  does meshery have something like that?

@navendu-pottekkat I think it would just need to be tested to run offline. I was looking into how that could be done. does meshery have something like that?

@Maxgit3 You can test Meshery offline with your PR? I mean you should first have Meshery on your machine and then stop it and run without the Internet.
The initial fetching of files can be avoided for now.

@navendu-pottekkat I was working on testing offline.  I didnt see an option to switch between kubernetes and docker environment.  it always defaults to docker

A couple ways - https://docs.meshery.io/reference/mesheryctl/system/context
system context switch
system context create blah -p kubernetes
vi ~/.meshery/config.yaml

A couple ways - https://docs.meshery.io/reference/mesheryctl/system/context system context switch system context create blah -p kubernetes vi ~/.meshery/config.yaml

@metonymic-smokey ... a perfect excuse for another docs entry or blog post....

@leecalcote thank you

@leecalcote @navendu-pottekkat  I am running into an issue.
creating ~/.meshery/manifests folder....  downloading manifest files from https://github.com/layer5io/meshery/tree/v0.5.18/install/deployment_yamls/k8s Starting Meshery... Error: failed to start Meshery See https://docs.meshery.io/guides/mesheryctl/#meshery-lifecycle-management for usage details : Unable to discover an endpoint
I am using the Kubernetes KIND setup to test the ./mesheryctl build
The current Context is set to Kind-kind cluster
I have the .kube/config file in the home/user directory

@piyushsingariya @Maxgit3 A sample unit test implemented in istio adapter, we can follow the same. Do suggest changes if you have a better one - https://github.com/layer5io/meshery-istio/blob/master/istio/istio_test.go

@kumarabd @metonymic-smokey Any idea why the endpoint is not being discovered?

@Maxgit3 , are you able to access Meshery UI? If that is the case, then this could be a bug

@navendu-pottekkat I am not able to access the meshery UI. seems like some configuration issue. maybe with Kind?

Hmm, not sure. Deploying to KinD is pretty straightforward...
Could you try with MiniKube?

@navendu-pottekkat ok I will try minikube.  do you have to have something deployed and a service in the default namespace.  I wonder if thats why the kind is not discovering endpoints

You can add a loadbalancer to your cluster to expose the services. sth like
metallb
On Fri, 11 Jun 2021 at 06:04, Maxgit3 @.***> wrote:

@navendu-pottekkat https://github.com/navendu-pottekkat ok I will try
minikube. do you have to have something deployed and a service in the
default namespace. I wonder if thats why the kind is not discovering
endpoints
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/layer5io/meshery/pull/2807#issuecomment-859176303,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALZOXQYPFNJAJSBNWSHBQTTTSFK2XANCNFSM44AARWRA
.

@Maxgit3 any updates, are working on this? Let's try to get this landed quickly.

@navendu-pottekkat sorry about the late reply.  still having issues with my computer.  I probably will have to upgrade to something more powerful

@Maxgit3 are you able to work on this? It would be best to have this soon in mesheryctl. Please signal so that another contributor can take this from here.

@NupurThakur27 FYI ^

@navendu-pottekkat I'm sorry.  just don't have a computer sufficient enough to handle running kubernetes.  probably best to have someone else handle the issue

Thank you for the update @Maxgit3

@navendu-pottekkat @Maxgit3 Can I start further on this PR or probably start from scratch on #2580 ?

Sure @NupurThakur27 , closing this PR


Some quesition about calculating KL divergence

I notice in the function:https://github.com/wohlert/semi-supervised-pytorch/blob/7cde4959468d271552febdcfed5e1cfae9857613/semi-supervised/models/vae.py#L200, you are calculating the KL divergence as in
qz - pz
I am wondering, shouldn't the fomular should look something like
torch.exp(pz) * (qz - pz)
according to the KL divergence definition

The KL-divergence is specified as follows

You will notice that we do the same except we switch the name of q and p as we prefer the mode-seeking behaviour of "reverse KL". You will see that the original Gumbel-softmax implementation in Tensorflow does the same.

Oh, I am sorry, I link the wrong line.
This is what I really mean: https://github.com/wohlert/semi-supervised-pytorch/blob/7cde4959468d271552febdcfed5e1cfae9857613/semi-supervised/models/vae.py#L118

Ah yes, as I show in the documentation:
 KL(q||p) = -∫ q(z) log [ p(z) / q(z) ]
                 = -E[log p(z) - log q(z)]

This is another way to calculate it if we just have samples z drawn from the q-distribution. This is also known as a Monte-Carlo approximation to the expectation.

So the method is assming sample size =  1? or it depends on how we use the method?

The number of samples is specified in the inference method in SVI

Hi @wohlert , thank you for the clean code and nice documentation.
I was wondering why you used MC approximation of the KL divergence instead of the closed form solution when both distributions are Gaussians (for example p_z and q_z) ?
Is it simply to have a more general code, or is there a deeper reason?
Cheers

At the time I was experimenting with a lot of different distributions and torch.distributions wasn't implemented yet, so this was the best approach. For now, I would recommend either using the closed form solution or torch.distributions.


WIP: setting non-string values

analyzing #34

Coverage remained the same at 88.068% when pulling 7571fb8d11dfd0d6e5e3111ac6fa067a1e1f92e1 on tuxmea:non_string_values into 2c4f191d7046164163d43730b1bcbbeaa0689b2e on hercules-team:master.

@simonhoenscheid can you check if the test data is correct to reproduce the error?

Issue is unrelated to type/provider. see #34
closing


Fix gax and gax-grpc dependency mismatch

TESTED=build the nomulus tool locally and it run the list_cursors
command correctly. It used to fail.

This change is

All pins that are not breaking-changes should be reviewed now that we say goodbye to Java 8.

Reviewable status: 0 of 12 files reviewed, all discussions resolved (waiting on @ptkach)

Yes.
However the pins removed here were introduced when we upgraded to Java 17 (see bullet point 4). Back then not all dependencies were compatible with grpc-java. I guess now they are.


Cypress configuration file

Could not find a Cypress configuration file in this folder: .../cypress
Not able to run cypress via npx cypress run

@akshayaureatelabs
If your error message is saying that it could not find a configuration file in a folder on your C: drive with your name, then this means that it is not a problem with cypress-io/github-action which runs on GitHub, not on your local machine.
Is this your first time using Cypress? You would not normally execute commands such as npm install cypress or npx cypress run from the node_modules directory.
You can find some instructions to help you set up a working Cypress project under Getting Started. You can also clone this repository to find a set of ready-to-use examples, although these do assume that you have a working knowledge of Cypress.

@MikeMcC399
Firstly, thanks for the response.
Yes, I am using this cypress for the first time but I followed the instructions from Installing Cypress to which you refer. I just already follow the steps as per cypress documentation but it's not working for me.

@MikeMcC399
Hi, it's working now, I just update the all packages, and boom! BTW thanks for the response!

@akshayaureatelabs

Yes, I am using this cypress for the first time but I followed the instructions from Installing Cypress to which you refer. I just already follow the steps as per cypress documentation but it's not working for me.

It seems that you have missed out a step of creating a new directory for your cypress project. The instructions don't explicitly say to do that. It's implied. For instance:
mkdir my-new-project
cd my-new-project
npm init
npm install cypress --save-dev
npx cypress open

@akshayaureatelabs
It's good that it is working for you. From your last post it does look like you have a non-standard way of using directories. Cypress is quite complicated to learn, so I would recommend taking a training course to get further into using it. The training courses will usually walk you through everything step-by-step.

@akshayaureatelabs

Yes, I am using this cypress for the first time but I followed the instructions from Installing Cypress to which you refer. I just already follow the steps as per cypress documentation but it's not working for me.

It seems that you have missed out a step of creating a new directory for your cypress project. The instructions don't explicitly say to do that. It's implied. For instance:
mkdir my-new-project
cd my-new-project
npm init
npm install cypress --save-dev
npx cypress open

Thank you very much for instance instructions.

@akshayaureatelabs
It's good that it is working for you. From your last post it does look like you have a non-standard way of using directories. Cypress is quite complicated to learn, so I would recommend taking a training course to get further into using it. The training courses will usually walk you through everything step-by-step.

Copy that!

@akshayaureatelabs
It's good that it is working for you. From your last post it does look like you have a non-standard way of using directories. Cypress is quite complicated to learn, so I would recommend taking a training course to get further into using it. The training courses will usually walk you through everything step-by-step.

Copy that!


New annotations

https://github.com/kubernetes/enhancements/issues/2227#issuecomment-797269213
It is implemented in  1.21

/sig cli

/assign

LGTM
/approve
(would like someone else to /lgtm)

/lgtm
From sig-cli perspective
Thank you @pacoxu !


MiqQueue consistency with purging

Bring consistency to Purging:

remove boilerplate
removing inconsistency (slowly)
moving all from put_unless_exists over to put.
put into the general queue
following patterns (which are already tuned for performance)

This approach looks good to me.  Is it possible to have generic tests that each of these classes can be tested with shared examples?

@kbrock Is this for fine?

@kbrock Is this for fine?

Any reason it shouldnt be in fine?
Its needed for:
https://bugzilla.redhat.com/show_bug.cgi?id=1428595
https://github.com/ManageIQ/manageiq/pull/14322

ok, fine/yes sounds fine

Fine backport details:
$ git log -1
commit 9283c5a8a75ac449970f05752790527a7c6f98b2
Author: Jason Frey<EMAIL_ADDRESS>Date:   Mon Apr 10 17:54:05 2017 -0400

    Merge pull request #14676 from kbrock/miq_queue_purge_es

    MiqQueue consistency with purging
    (cherry picked from commit 932ac5773fcefa6dae3bc1234d95241549147af1)


Plugin Doesn't show what change occurred

Hello,
This app does most things right except one thing i've noticed. It'll inform you that a work item was updated and what it was updated to but it doesn't show what it was updated from. For example, I can assign a bug from John to Bill and people will see in the notification that the bug is assigned to Bill but there is nothing telling them that it was originally assigned to John. Is this something being looked into or on the roadmap?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b54bed72-4266-7c72-ef20-d48968dcaddd
Version Independent ID: a7109901-c230-b420-88b6-b3000faf002e
Content: Azure Boards with Slack - Azure Boards
Content Source: docs/boards/integrations/boards-slack.md
Product: devops
Technology: devops-agile
GitHub Login: @RGKarthik
Microsoft Alias: kaelli

@KehindeOwens Thank you for the question.
This is a good candidate for the Azure DevOps community.
There the product-team can provide additional feedback on feasibility and release schedules if the feature is approved.
In the meantime, perhaps try using custom fields to store previous information such as the auditing information mentioned in the example above.
@RGKarthik

Hi @KehindeOwens
Adding history / audit details isn't in our plans currently. We strive to ensure only key elements are available in the notification to reduce signal to noise element. I would love to understand what key problem are you trying to solve here.

Closing this issue now.


merge package template from arlac77/npm-package-template

package.json

chore(devDependencies): update<EMAIL_ADDRESS>from template

Coverage remained the same at 96.97% when pulling a51ed8ba92e6b7c3f6d1e0ce1f50bd02f41c084b on template-sync-1 into ab52fc02122fb00750abc91621f6a5113162d1bc on master.

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #22   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           2      2
  Lines          27     27
=====================================
  Hits           27     27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab52fc0...a51ed8b. Read the comment docs.


Fix MoveRelative potentially empty trajectory issue

We have run into an issue a few times with MoveRelative relative that causes a crash. If the ``PlannerInterfaceimplementation returns a trajectory with no waypoints, but a non-nullrobot_trajectory, then the back of an empty vector is accessed via robot_trajectory->getLastWayPointPtr()` leading to a crash.
A potential fix is to consider empty trajectories as a failed plan. We run into this issue frequently when the robot starts in or very close to a collision.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.65%. Comparing base (6b0f2c8) to head (e3cc52c).
Report is 32 commits behind head on master.

Files
Patch %
Lines

core/src/stages/move_relative.cpp
50.00%
1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
- Coverage   58.82%   56.65%   -2.17%
==========================================
  Files          91      131      +40
  Lines        8623    10656    +2033
  Branches        0      952     +952
==========================================
+ Hits         5072     6036     +964
- Misses       3551     4573    +1022
- Partials        0       47      +47

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Thanks. Don't you need the same check here as well:
https://github.com/moveit/moveit_task_constructor/blob/e3cc52cd0f018d91c119675cc11ee6d921e4109c/core/src/stages/move_relative.cpp#L330

Yes, we need to add the check there as well. Thanks for pointing that out.


Error while parsing JSON with Website Agent when data is null: "undefined method `size' for nil:NilClass"

I'm using the website agent to fetch JSON and it works until suddenly a field with an array in is null.
When this happens I get this exception:
[00:00:00] INFO -- : Dry Run started
[00:00:00] INFO -- : Fetching https://hnrss.org/newest.jsonfeed?q=notreal111
[00:00:01] INFO -- : Extracting json at $.items[*].content_html
[00:00:01] ERROR -- : Error when fetching url: undefined method `size' for nil:NilClass
/app/vendor/bundle/ruby/2.5.0/gems/jsonpath-1.0.1/lib/jsonpath/enumerable.rb:55:in `block in handle_wildecard'
/app/vendor/bundle/ruby/2.5.0/gems/jsonpath-1.0.1/lib/jsonpath/enumerable.rb:39:in `each'
/app/vendor/bundle/ruby/2.5.0/gems/jsonpath-1.0.1/lib/jsonpath/enumerable.rb:39:in `handle_wildecard'
/app/vendor/bundle/ruby/2.5.0/gems/jsonpath-1.0.1/lib/jsonpath/enumerable.rb:25:in `each'
/app/vendor/bundle/ruby/2.5.0/gems/jsonpath-1.0.1/lib/jsonpath/enumerable.rb:45:in `block in handle_wildecard'
/app/vendor/bundle/ruby/2.5.0/gems/jsonpath-1.0.1/lib/jsonpath/enumerable.rb:39:in `each'
/app/vendor/bundle/ruby/2.5.0/gems/jsonpath-1.0.1/lib/jsonpath/enumerable.rb:39:in `handle_wildecard'
/app/vendor/bundle/ruby/2.5.0/gems/jsonpath-1.0.1/lib/jsonpath/enumerable.rb:25:in `each'
/app/vendor/bundle/ruby/2.5.0/gems/jsonpath-1.0.1/lib/jsonpath/enumerable.rb:23:in `each'
/app/vendor/bundle/ruby/2.5.0/gems/jsonpath-1.0.1/lib/jsonpath.rb:71:in `to_a'
/app/vendor/bundle/ruby/2.5.0/gems/jsonpath-1.0.1/lib/jsonpath.rb:71:in `on'
/app/lib/utils.rb:96:in `values_at'

Here is the JSON for the agent:
{
  "expected_update_period_in_days": "365",
  "url": "https://hnrss.org/newest.jsonfeed?q=notreal1111",
  "type": "json",
  "mode": "on_change",
  "extract": {
    "description": {
      "path": "$.items[*].content_html"
    },
    "url": {
      "path": "$.items[*].url"
    }
  },
  "template": {
    "url": "{{ url }}"
  }
}

You can use this to see it populated with data (for testing):
{
  "expected_update_period_in_days": "365",
  "url": "https://hnrss.org/newest.jsonfeed?q=dang",
  "type": "json",
  "mode": "on_change",
  "extract": {
    "description": {
      "path": "$.items[*].content_html"
    },
    "url": {
      "path": "$.items[*].url"
    }
  },
  "template": {
    "url": "{{ url }}"
  }
}

Here is the JSON that returned when there's data:
{
  "version": "https://jsonfeed.org/version/1",
  "title": "Hacker News - Newest: \"dang\"",
  "description": "Hacker News RSS",
  "home_page_url": "https://news.ycombinator.com/newest",
  "items": [
    {
      "id": "1234",
      "title": "some text",
      "content_html": "
some html/p>\n",
      "url": "https://example.com",
      "external_url": "https://example.com",
      "date_published": "2020-05-20T17:32:19Z",
      "author": "foobar"
    }
  ]
}

Here is the JSON response when there is no data:
{
  "version": "https://jsonfeed.org/version/1",
  "title": "Hacker News - Newest: \"notreal111\"",
  "description": "Hacker News RSS",
  "home_page_url": "https://news.ycombinator.com/newest",
  "items": null
}

Is there some magic workaround for dealing with JSON fields that are suddenly missing or null? Or maybe this is a bug?

Hello! It might be better to just capture the entire item as a separate event.
Try:
{   "expected_update_period_in_days": "365",   "url": "https://hnrss.org/newest.jsonfeed?q=notreal1111",   "type": "json",   "mode": "on_change",   "extract": {     "description": {       "path": "$.items[*].content_html"     },     "url": {       "path": "$.items[*].url"     }   },   "template": {     "url": "{{ url }}"   } }

@degan6 I was going to do that but it's so much more work. Here's what I came up with.
For anyone else stuck on this like I was was. Here is a solution that I figured out which appears to work. You have to put all the fields as optional like this:
{
  ...
  "extract": {
    "url": {
      "path": "$.items[?(@.url)].url"
    },
    "description": {
      "path": "$.items[?(@.content_html)].content_html"
    },
    "title": {
      "path": "$.items[?(@.title)].title"
    }
  }
}


validators appear in the wrong networks

When calling https://data.xrpl.org/v1/network/validators/xahau-main all main and xahau-main validators are included.
When running locally this problem does not exist.  Looking at the data returned the validators have the correct networks and chain fields.

Running locally, this does happen for me. Sometimes will show up as Chain.5
Also, for some reason my VHS is collecting validators from every network, but I expected it to only find xahau validators. Filtering by network will have a mix of the network you specified and randomly other validators as well.

Why would you expect the VHS to only find Xahau validators? Did you edit the list of networks?
That might be because some peers stick around for a bit when a validator switches networks.

Why would you expect the VHS to only find Xahau validators? Did you edit the list of networks?
That might be because some peers stick around for a bit when a validator switches networks.

Yes, my config is set to only xahau
export MAINNET_P2P_ENTRY= (my endpoint on xahau)
export MAINNET_UNL=vl.xahau.org
export RIPPLED_RPC_ADMIN=(my endpoint on xahau)

Why would you expect the VHS to only find Xahau validators? Did you edit the list of networks?
That might be because some peers stick around for a bit when a validator switches networks.

Yes, my config is set to only xahau
export MAINNET_P2P_ENTRY= (my endpoint on xahau)
export MAINNET_UNL=vl.xahau.org
export RIPPLED_RPC_ADMIN=(my endpoint on xahau)

That's not the only place network data is stored. The main data is here: https://github.com/ripple/validator-history-service/blob/main/src/shared/database/networks.ts
The way that you're trying to just get Xahau data probably doesn't work properly with the UNLs.

Awesome, thank you!

Closing because this issue seems resolved. Feel free to reopen if you continue to run into this issue.


[$500] [MEDIUM] Tags: Unable to unselect or select a different tag after the request is created

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Found when validating PR : https://github.com/Expensify/App/pull/35541
Version Number: v1.4.43-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:
Action Performed:
Precondition:

User is an employee of Collect workspace.
The Collect workspace has categories and tags.

Go to staging.new.expensify.com.
Go to workspace chat.
Create a manual request with tag.
Go to request details page.
Click Tag.
Select a different tag.

Expected Result:
User should be able to unselect or select a different tag.
Actual Result:
Nothing happens when selecting a different tag. User is unable to change the tag after the request is created. The same goes for Category.
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos
https://github.com/Expensify/App/assets/115492554/895308f6-c90f-4439-8e14-038e1bae8221

View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015553cb48198a3559
Upwork Job ID:<PHONE_NUMBER>807922176
Last Price Increase: 2024-02-20

We think that this bug might be related to #wave5-free-submitters
CC @dylanexpensify

Same root cause as here  – it's caused by https://github.com/Expensify/App/pull/35880

@mountiny @Pujan92 could you please take a look and see if your PR here will resolve this issue as well?

@kadiealexander he PR got Cped to staging so if you can repro in 1.4.43-5 its not solved

Not reproducible anymore:

Please reopen if it comes back up.


Add days off provides blank dialog

Using on-premise TFS 2015 U3. The days off operation seems to provide an empty dialog, with no way to add day off information.

This happens in both Chrome and Edge.

Seems that you have to have selected iterations in the iteration admin tab for this feature to work.

Better to provide help text in this dialog. It would seem that adding days off when an iteration is unavailable would be indicative that the user doesn't know how to use this feature (me!); so having a little help documentation here would point us in the right direction.


CSS Modules in gomponents

Hey @markuswustenberg!
I was just tinkering around with your library again and thought it would be awsome to have something similar to CSS Modules in gomponents. This would be very benefitial for encapsulation and the pain of writing CSS selectors by hand, other options like Tailwind CSS integrate well but can get out of hand pretty quickly.
I created a proof of concept which integrates nicely with your library and I think it would be an awesome addition.
Attached is a screenshot which should demonstrate the look and feel, not necessarily the implementation details.
Please let me know what you think, especially if you could see this being added to gomponents or if it should rather live in its own package.
Cheers ✌🏼

Hey @philippta,
that's awesome! 😎 I think it's a good idea to have this. I'm personally a big fan of TailwindCSS and hadn't heard of CSS modules before now, but I can see how they solve the same problem (styling components) quite elegantly, in different ways.
My initial thought is that this would be nice to have in a separate Go module. I've done something similar with gomponents-heroicons and started (but never got far with) gomponents-tailwind, so a gomponents-css-modules or something would make great sense.
My dream with gomponents is to be part of creating a rich ecosystem of view libraries for Go. I always found that cool about using React in Javascript-land, because there's so many great libraries to choose from. I started a gomponents + page on the website to facilitate this, and if you end up creating this, I would love to put the project on there.
What do you think?

@philippta did you ever get further with this?

I know this issue is closed and I am two years late on that, but I do think the concept is interesting. That would be a nice extension to gomponents if someone feels like wanting to tackle this topic!


CAMEL-18131 - Adding health check to test conectivity

Signed-off-by: Rhuan Rocha<EMAIL_ADDRESS>
[x] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[x] Each commit in the pull request should have a meaningful subject line and body.
[x] If you're unsure, you can format the pull request title like [CAMEL-XXX] Fixes bug in camel-file component, where you replace CAMEL-XXX with the appropriate JIRA issue.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Run mvn clean install -Psourcecheck in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
Below are the contribution guidelines:
https://github.com/apache/camel/blob/main/CONTRIBUTING.md

Yes we can remove the component verifier which also means it should be removed on the component at
registerExtension(new AWS2S3ComponentVerifierExtension());

The PR keeps failing, wonder what that error is?
Also mind that this essentially makes the S3 component do health-checks with a live check to AWS every time its invoked. Not sure if AWS would rate limit you - meaning that the interval for triggering health checks should be a reasonable (5 or 10s or longer)

@davsclaus I have tested it in my local environment and it works fine. I think it is some issue about the environment. Mainly because the issue is in another component that is not related to this update.

Hi @orpiske,
Based on the file changed list, the files updated were just about the aws2-s3. Thus, I think I don`t need to rebase it. However, I will do that.

Hi @orpiske,
Based on the file changed list, the files updated were just about the aws2-s3. Thus, I think I don`t need to rebase it. However, I will do that.

Just as a matter of explanation: the rebase from upstream syncs your branch with the other changes that had been merged to upstream/main. Looking at your branch right, it was 227 commits behind upstream/main. When our diff script runs to find out what has changed, it compares the PR changes to upstream/main, therefore the greater the distance from main, the more will be tested (and this is why the label bot adds tags for jms, kafka and others even if the PR hasn't changed those).
On a side note: I should probably add this to the contribution guide 🫣


Opensubtitle integration [feature request]

Sorry I'm not sure how to 'tag' this as a request ...
It will be nice to have an integration with opensubtitle and if possible search by hash/title as this vlc extension do : https://github.com/exebetche/vlsub

For now, we want to stay neutral and not integrate with any third party centralized services.
See https://github.com/feross/webtorrent-desktop/issues/281#issuecomment-219152938

Having webtorrent desktop optional plugins might be interesting though. If it doesn't bring too much complexity anyway.


Reduce size of Poseidon machine

After analyzing what is taking such a long time when evaluating fixed column (#2083), I noticed that the Poseidon machine uses the default degree range, independent of the --max-degree-log degree log.
I set it to LARGE_SUBMACHINES_MAX_DEGREE instead, which means that it is 4x larger than the main machine. Given a block size of 31, that means that it has enough rows if at most 1 / 8 (=12.5%) of the CPU instructions are calls to Poseidon, which should be enough?
For --max-degree-log 18, this reduces the time to evaluate constant columns from 109s to 33s.

Seems to run OOM in CI now. I'm guessing because we set MAX_DEGREE_LOG=20 (so Poseidon was of size $2^{20}$ before this change), but set CompilerOptions::max_degree_log = 20 (so Poseidon is of size $2^{22}$ now)?
Maybe we can make the tests smaller? Or we can set Poseidon to MAIN_MAX_DEGREE, so at most 1 / 32 calls in Main can be calls to Poseidon?
I feel like the latter option could work, because, at least in the bootloader, we seem to be running about 16 instructions in between Poseidon calls, so as long as the bootloader is running for less than 50% of the chunk, it should be fine...

Let's reduce the main degree to 18 for CI, 20 is a lot anyway


Change stats from TODAY to PAST 24H

The stats page is a little annoying, It return today's score, but today is defined at UTC timezone, it does not take the player's timezone into account.
TODO:
Change the TODAY stats to PAST 24H stats
This can be achieved purely as a SQL query in postgres without having to introduce timezone for players.

done in https://github.com/timotheeg/nestrischamps/pull/50


feat: #21 sidebar on mobile

Hey, @Maianki  I also fixed the background color on the sidebar.

Hey, @Maianki I also fixed the background color on the sidebar.

Thanks for letting me know this.

@htcni Thanks for contributing. I have merged your PR.


Renovate sometimes creates incorrect yarn.lock files

Sometimes the yarn.lock file generated by renovate does not match the yarn.lock generated by CircleCI or my own laptop.
Examples:

https://github.com/singapore/renovate/pull/280/commits
https://github.com/singapore/renovate/pull/272/commits

Each time lately it's been the moment library. Here is what renovate changed:

This seems "wrong" - it's not optimized.

I fixed the yarn version to '0.24.5' in package.json "engines" so I'm pretty sure it's the same version being run everywhere now.
On a related note, npm install -g npm@latest installs 0.24.5 however npm install -g<EMAIL_ADDRESS>works too. I think this was a human error in publishing because yarn also has versions 0.25.x and 0.26.x out.

Could be the cache somehow impacting things?

Waiting for more evidence/occurrences


DNN-6539 Only English ASCII nicknames are searchable!

:shipit:

im going to close this, the clone project had an issue part way through and it appears it missed a few files - whilst it doesn't seem to have hurt in this case, I would prefer to get it right, so i'll copy the change, close this and reclone the repo.


Revert "Bump cargo from 1.51.0 to 1.57.0"

Reverts dependabot/dependabot-core#4585

It seems like the docker image is outdated in these PRs, the tests pass for me locally on 1.51.0 but fail on 1.57.0. I will dig into that separately, but going to assume that merging this will fix the builds for now


Freeze ReadVariableOp if the handle name is forwarded by Identity

FreezeSavedModel does not convert variables inside functions. To freeze variables in a model with functions, we need to inline the functions first. After inlining a function with resource variables, we have the following node sequence:
VarHandleOp -> Identity -> ReadVariableOP
This PR updates FreezeSavedModel to handle SavedModels where the GraphDef was inlined. This involves two steps:

Remove the assumption that VarHandleOp is an immediate parent of ReadVariableOp.
Change the dtype of Identity to match the dtype of the variable.

This is needed for #53082. Tagging @bixia1 for visibility.

I am trying to understand whether the Identity node is necessary and whether there is an existing optimization to remove such Identity nodes.

@tfeher Can you please check @bixia1's comments and keep us posted ? Thanks!

We had some discussion on this within google, and it seems that grappler should optimize it. Will close this PR once we have a grappler fix in place.

Thanks @bixia1 for the suggestion, I have updated the PR.

Thanks @bixia1 for sharing the feedback. I have updated the PR, please have another look.


Redact credentials from error messages

Remove the api_key, login_id and token from the exception object, to prevent this leaking in error logs.

Oops, wrong repo!


Add measurements module

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Move measurements config to another module.
Which issue(s) this PR fixes:

Fixes #1659
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/ok-to-test
Please remove

Fixes #1659

This PR alone is only a part of job that needs to be done to close https://github.com/kubernetes/perf-tests/issues/1659

Diff from https://github.com/mm4tt/k8s-util/tree/master/experimental/cl2-compare-config
Diff is:
53c53
<   name: Starting measurements
---
>   name: starting measurements
967c967
<   name: Collecting measurements
---
>   name: gathering measurements

Introduced some minor changes to the order of entries in the measurements.yaml that should not affect the overall behaviour. The new diff is:
53c53
<   name: Starting measurements
---
>   name: starting measurements
922,925c922,923
<       enableViolations: true
<       summaryName: APIResponsivenessPrometheus_simple
<       useSimpleLatencyQuery: true
<     identifier: APIResponsivenessPrometheusSimple
---
>       enableViolations: false
>     identifier: APIResponsivenessPrometheus
932,933c930,933
<       enableViolations: false
<     identifier: APIResponsivenessPrometheus
---
>       enableViolations: true
>       summaryName: APIResponsivenessPrometheus_simple
>       useSimpleLatencyQuery: true
>     identifier: APIResponsivenessPrometheusSimple
967c967
<   name: Collecting measurements
---
>   name: gathering measurements

/lgtm

/approve

/retest


Check user authorization in realm api requests

This PR adds authentication and authorization to all our realm's endpoints. If the http method is PUT, PATCH, POST, DELETE, then the request is considered a ✍ write request, otherwise it's a 📖  read request.
There's a new checkPermission function that will:

Authenticate the user using the provided JWT

If realm is publicly readable or writable it will not require a JWT
Otherwise it will require a JWT. Will respond with 401 if JWT is missing or invalid.

Check whether the current user has a permission to read when reading, and write when writing

It will respond with 403 if there is no permission to perform the action
Otherwise it will proceed to process the request

Notes

The realm tests have been refactored to support testing in realms with different permissions
The realm permissions config is now passed to the constructor of the realm (as opposed to the previous way of lazily reading it from the environment variable when permissions are checked). This has been changed so that it is more encapsulated and thus easier to test (can easily create different realms with different permissions in the same environment)
All the occurences of REALM_USER_PERMISSIONS="{}" in our realm start scripts have been removed. .realms.json.test and realms.json.development files have been introduced (permissions config) for better experience when changing permissions during development or for testing. However, in our deployed environments (not development or test),  REALM_USER_PERMISSIONS is a mandatory ENV variable. This is because in deployed environments it's easier to manage an ENV variable compared to file copying approach

Future work
Currently, all our deployed realms are public readable and writable. They will need to stay this way until we add support for realms to be be able to authenticate between each other, otherwise indexing cards from other realms (e.g. linked cards) will fail if there is no permission to read.

I've addressed all the review comments.
Also, this PR is somewhat sensitive to the deployment due to ENV var requirements and keeping things work for the world readable realms so I test deployed this branch to our staging. There was a problem that the new error from this PR handling caught successfully - the permissions config (parameter store) was faulty (realm keys were names when they should be URLs). I fixed that issue and redeployed to staging and things seem to be working ok. I've also addressed this issue in production param store.


About vector "left" , "right" and function “broadcasting”

Hi， I don't quite understand the use of  the vector "left" and "right" and  the function “broadcasting”, could you explain it more clearly？ thanks

Hi， I don't quite understand the use of the vector "left" and "right" and the function “broadcasting”, could you explain it more clearly？ thanks

Hi yxWisdom, Do you have any idea about that question? Thank you.

I also want to know that

oriLeft and oriRight shape: [B,T,U]
left transpose [1,0,2]: [T,B,U]；than expand dim 3: [T,B,U,1]
right transpose [0,2,1]:[B,U,T]；than expand dim 0: [1,B,U,T]
B = left + right: [T,B,U,T]
B transpose [1,0,3,2] : [B,T,T,U]
This means that in each sample, each word belongs to the confidence level of each relationship with other words


ModSecurity-nginx v3: have event block in modsecurity audit log but request still 200 success

Im setup nginx 1.12.2 with mod-nginx-v3 .
Here is my config
server {
    listen      80 default_server;
    server_name example.com;

    # redirect http to https
    #return 301 https://$server_name$request_uri;

    # custom log format
    access_log /var/log/nginx/access_aa_dummy.log example_com;

    modsecurity on;
    modsecurity_rules_file /etc/nginx/modsec_includes.conf;
    location / {
        root /usr/share/nginx/html;
    }

}

Here is modsec_includes.conf
SecRuleEngine DetectionOnly
SecRequestBodyAccess On
include modsecurity.conf
include owasp-modsecurity-crs/crs-setup.conf
include owasp-modsecurity-crs/rules/*.conf

When i test with url : http://example.com/?param= . Modsecurity dont block this url but have event in mod audit log.
is config have something wrong? Thanks!
here is mod audit log

---StiqOOiL---F--
HTTP/1.1 200
X-Frame-Options: SAMEORIGIN
X-Frame-Options: DENY
ETag: "5a0aa5ce-11"
Strict-Transport-Security: max-age=31536000
Strict-Transport-Security: max-age=63072000; includeSubdomains
Last-Modified: Tue, 14 Nov 2017 08:14:06 GMT
Connection: keep-alive
X-Content-Type-Options: nosniff
X-Content-Type-Options: nosniff
Content-Type: text/html
Content-Length: 17
Date: Tue, 14 Nov 2017 09:48:09 GMT
Server: nginx/1.12.2
X-XSS-Protection: 1; mode=block
Accept-Ranges: bytes
---StiqOOiL---H--
ModSecurity: Warning. detected XSS using libinjection. [file "/etc/nginx/owasp-modsecurity-crs/rules/REQUEST-941-APPLICATION-ATTACK-XSS.conf"] [line "17"] [id "941100"] [rev "2"] [msg "XSS Attack Detected via libinjection"] [data "Matched Data: accept-language found within ARGS:param: ">"] [severity "2"] [ver "OWASP_CRS/3.0.0"] [maturity "1"] [accuracy "9"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-xss"] [tag "OWASP_CRS/WEB_ATTACK/XSS"] [tag "WASCTC/WASC-8"] [tag "WASCTC/WASC-22"] [tag "OWASP_TOP_10/A3"] [tag "OWASP_AppSensor/IE1"] [tag "CAPEC-242"] [hostname "<IP_ADDRESS>"] [uri "/"] [unique_id "151065288923.665725"] [ref "v12,28t:utf8toUnicode,t:urlDecodeUni,t:htmlEntityDecode,t:jsDecode,t:cssDecode,t:removeNulls"]
ModSecurity: Warning. Matched "Operator Rx' with parameter (?i)([<\xef\xbc\x9c]script[^>\xef\xbc\x9e][>\xef\xbc\x9e][\s\S]?)' against variable ARGS:param' (Value: ">' ) [file "/etc/nginx/owasp-modsecurity-crs/rules/REQUEST-941-APPLICATION-ATTACK-XSS.conf"] [line "63"] [id "941110"] [rev "2"] [msg "XSS Filter - Category 1: Script Tag Vector"] [data "Matched Data: "] [severity "2"] [ver "OWASP_CRS/3.0.0"] [maturity "4"] [accuracy "9"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-xss"] [tag "OWASP_CRS/WEB_ATTACK/XSS"] [tag "WASCTC/WASC-8"] [tag "WASCTC/WASC-22"] [tag "OWASP_TOP_10/A3"] [tag "OWASP_AppSensor/IE1"] [tag "CAPEC-242"] [hostname "<IP_ADDRESS>"] [uri "/"] [unique_id "151065288923.665725"] [ref "o2,8o2,8v12,28t:utf8toUnicode,t:urlDecodeUni,t:htmlEntityDecode,t:jsDecode,t:cssDecode,t:removeNulls"]
ModSecurity: Warning. Matched "Operator Rx' with parameter (?i)<[^\w<>](?:[^<>"'\s]:)?[^\w<>](?:\W?s\W*?c\W*?r\W*?i\W*?p\W*?t|\W*?f\W*?o\W*?r\W*?m|\W*?s\W*?t\W*?y\W*?l\W*?e|\W*?s\W*?v\W*?g|\W*?m\W*?a\W*?r\W*?q\W*?u\W*?e\W*?e|(?:\W*?l\W*?i\W*?n\W*?k|\W*?o (3246 characters omitted)' against variable ARGS:param' (Value: ">' ) [file "/etc/nginx/owasp-modsecurity-crs/rules/REQUEST-941-APPLICATION-ATTACK-XSS.conf"] [line "195"] [id "941160"] [rev "2"] [msg "NoScript XSS InjectionChecker: HTML Injection"] [data "Matched Data: <script found within ARGS:param: ">"] [severity "2"] [ver "OWASP_CRS/3.0.0"] [maturity "1"] [accuracy "8"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-xss"] [tag "OWASP_CRS/WEB_ATTACK/XSS"] [tag "WASCTC/WASC-8"] [tag "WASCTC/WASC-22"] [tag "OWASP_TOP_10/A3"] [tag "OWASP_AppSensor/IE1"] [tag "CAPEC-242"] [hostname "<IP_ADDRESS>"] [uri "/"] [unique_id "151065288923.665725"] [ref "o2,7o19,8v12,28t:utf8toUnicode,t:urlDecodeUni,t:htmlEntityDecode,t:jsDecode,t:cssDecode,t:removeNulls"]
ModSecurity: Warning. Matched "Operator Ge' with parameter %{tx.inbound_anomaly_score_threshold}' against variable TX:ANOMALY_SCORE' (Value: 15' ) [file "/etc/nginx/owasp-modsecurity-crs/rules/REQUEST-949-BLOCKING-EVALUATION.conf"] [line "36"] [id "949110"] [rev ""] [msg "Inbound Anomaly Score Exceeded (Total Score: 15)"] [data ""] [severity "2"] [ver ""] [maturity "0"] [accuracy "0"] [tag "application-multi"] [tag "language-multi"] [tag "platform-multi"] [tag "attack-generic"] [hostname "<IP_ADDRESS>"] [uri "/"] [unique_id "151065288923.665725"] [ref ""]
ModSecurity: Warning. Matched "Operator Ge' with parameter %{tx.inbound_anomaly_score_threshold}' against variable TX:INBOUND_ANOMALY_SCORE' (Value: 15' ) [file "/etc/nginx/owasp-modsecurity-crs/rules/RESPONSE-980-CORRELATION.conf"] [line "61"] [id "980130"] [rev ""] [msg "Inbound Anomaly Score Exceeded (Total Inbound Score: 15 - SQLI=0,XSS=15,RFI=0,LFI=0,RCE=0,PHPI=0,HTTP=0,SESS=0): NoScript XSS InjectionChecker: HTML Injection"] [data ""] [severity "0"] [ver ""] [maturity "0"] [accuracy "0"] [tag "event-correlation"] [hostname "<IP_ADDRESS>"] [uri "/"] [unique_id "151065288923.665725"] [ref ""]
---StiqOOiL---I--
---StiqOOiL---J--
---StiqOOiL---Z--

Hi,
You configured ModSecurity in DetectionOnly mode.
If you want to block a requset use SecRuleEngine On, in your modsec_includes.conf.
You can find further information https://github.com/SpiderLabs/ModSecurity/wiki/Reference-Manual#SecRuleEngine

@tatdatpham please follow @LeeShan87 advice and you should be able to get it working.


500 internal server error. Spaceship?

2016-10-25T09:31:17.657529+00:00 app[web.1]: Completed 500 Internal Server Error in 1132ms
2016-10-25T09:31:17.658574+00:00 app[web.1]:
2016-10-25T09:31:17.658576+00:00 app[web.1]:   app/controllers/invite_controller.rb:161:in `login'
2016-10-25T09:31:17.658575+00:00 app[web.1]: Spaceship::TunesClient::ITunesConnectError (invalid request body):
2016-10-25T09:31:17.658577+00:00 app[web.1]:   app/controllers/invite_controller.rb:140:in `app'
2016-10-25T09:31:17.658578+00:00 app[web.1]:   app/controllers/invite_controller.rb:152:in `block in app_metadata'
2016-10-25T09:31:17.658578+00:00 app[web.1]:   app/controllers/invite_controller.rb:150:in `app_metadata'
2016-10-25T09:31:17.658579+00:00 app[web.1]:   app/controllers/invite_controller.rb:165:in `set_app_details'

Is it possibly related to this issue? https://github.com/fastlane/fastlane/issues/6711
Even the demo app on Heroku is currently down.
https://boarding.herokuapp.com

Seeing the same thing. Doesn't look like boarding has been updated for the fixes in fastlane/fastlane#6711, so redeploying from master doesn't help.

Hey everyone, thanks for the reports, I just pushed some changes, please follow the documentation on how to update your Heroku app

After seeing @bchrobot's reply on here, checked my boarding instance and it also is indeed down. I can confirm mine was working as recently as Friday.

Thanks, should be fixed with https://github.com/fastlane/boarding/pull/111, please update 👍


Followed Mesos fetcher signature change.

see summary.

Yeah, it seems this repo still has no release-branches. Before applying the above, we should fork a 1.9 branch which leaves this stuff untouched.

Actually, there are release-branches -- "1.9.x" exists.

The build against dcos/dcos:mesos master is triggered by the nightly CI builds - so I guess that is the rule for this repo.


Don't use $ref for project

avoid duplicate titles and descriptions, $ref was used only for layout
same issue as https://github.com/open-contracting/ocds-extensions/issues/54

See https://github.com/open-contracting/ocds-extensions/issues/40#issuecomment-383940824

Ignoring whitespace: https://github.com/open-contracting/ocds_budget_projects_extension/pull/13/files?w=1


Add support for Laravel 11

This PR adds support for Laravel 11. No noticeable changes are required

I'm not sure what's wrong with the test, do you have any clue @Namoshek ?

The error comes from a different PHPUnit version. I guess its fine but I'll look into it.

No idea how PHPUnit 11 is selected, but this shouldn't matter. Merging this...


it does not start

hi:
i'm getting started to use kong.
i followed doc to install ‘kong’ step by step.but it does not work.
the error is"unconfigured table schema_keyspaces"
it seems lack of config.
please, thank you.

please respect the issue template. We can't help without the basic info;
### Summary

SUMMARY_GOES_HERE

### Steps To Reproduce

1.
2.
3.
4.

### Additional Details & Logs

- Kong version (`$ kong version`)
- Kong configuration (registered APIs/Plugins & configuration file)
- Kong error logs (`<KONG_PREFIX>/logs/error.log`)
- Operating System

i'm so sorry to miss the  template.
Summary
i followed doc to install ‘kong’ step by step.but it does not work.
the error message  is"unconfigured table schema_keyspaces".
Steps To Reproduce

install jdk1.8,and it works.
install cassandra 3.7,and it starts.
install kong 0.8.3, exec  'kong start',

Additional Details & Logs

Kong version :0.8.3
Kong configuration:default
Operating System:centos7

I would try to delete the Cassandra keyspace with the following command and try to restart Kong:
DROP KEYSPACE kong;

Be aware that this operation will delete all of your data. Only execute it in a staging or dev environment.

the same error:Error: [Invalid] unconfigured table schema_keyspaces
kong: 0.9.0
cassandra: 3.7  (is up)
kong.config: /usr/local/kong/kong.conf
prefix = /usr/local/kong/
log_level = notice
#custom_plugins = acl,correlation-id,galileo,jwt,log-serializers,request-transformer,ssl,udp-log,cors,hmac-auth,key-auth,oauth2,response-ratelimiting,statsd,basic-auth,datadog,http-log,ldap-auth,rate-limiting,response-transformer,syslog,bot-detection,file-log,ip-restriction,loggly,request-size-limiting,runscope,tcp-log
anonymous_reports = on
proxy_listen = <IP_ADDRESS>:8000
#proxy_listen_ssl = <IP_ADDRESS>:8443
admin_listen = <IP_ADDRESS>:8001
nginx_worker_processes = auto
nginx_daemon = on
mem_cache_size = 128m
#ssl = on
#ssl_cert = none
#ssl_cert_key = none
database = cassandra
cassandra_contact_points = <IP_ADDRESS>,<IP_ADDRESS>
cassandra_port = 9042
cassandra_keyspace = kong
cassandra_consistency = ONE
cassandra_timeout = 5000
#cassandra_ssl = off
#cassandra_ssl_verify = off
#cassandra_username = kong
#cassandra_password = kong
cassandra_repl_strategy = SimpleStrategy
cassandra_repl_factor = 1
cassandra_data_centers = <IP_ADDRESS>:2,<IP_ADDRESS>:3
cluster_listen = <IP_ADDRESS>:7946
cluster_listen_rpc = <IP_ADDRESS>:7373
cluster_advertise = <IP_ADDRESS>:7946
#cluster_encrypt_key = none
cluster_ttl_on_failure = 3600
cluster_profile = lan
dnsmasq = on
dnsmasq_port = 8053
#dns_resolver = <IP_ADDRESS>
#lua_ssl_trusted_certificate = none
#lua_ssl_verify_depth = 1
#lua_code_cache = on
#lua_package_path = none
#lua_package_cpath = none

Kong is only compatible with Cassandra 2.1/2.2 for now. This error will go away once you use a compatible Cassandra version.

BTW,
custom_plugins = acl,correlation-id,galileo,jwt,log-serializers,request-transformer,ssl,udp-log,cors,hmac-auth,key-auth,oauth2,response-ratelimiting,statsd,basic-auth,datadog,http-log,ldap-auth,rate-limiting,response-transformer,syslog,bot-detection,file-log,ip-restriction,loggly,request-size-limiting,runscope,tcp-log

There are default plugins and do not need to be specified in the custom plugins as well.

@thibaultcha Is there any news on updating the DAO for newer Cassandra versions?
What are the reasons kong can't support cassandra 3.5? (We would like to move more of our data load to cassandra but would also like to avoid having to run two clusters)

@Tigraine See #831 and #1294


Command: boson init

boson init should initialize a boson environment in the current directory. It should:

Create a boson.yaml if there is not already one. If there is, use it.
The newly created config file should contain values inherited from the global config.
Genesis block and stuff should be created.
If there already is data, we should see if it's what the genesis config wants (account and stuff). If not, we ask user whether it should be nuked so we can reset. If it is, nothing needs to be done.
Finally we should report state to user and let the user run boson start to start the local chain (and boson connect, etc. for remote chain)

One problem we need to fix is that the YAML file contains a dictionary (like JSON) and not a hierarchy. We should also inflate accounts automatically.


fix: accounts breadcrumbs with chain name

Description
Fixes the Breadcrumbs string for Accounts Transaction History pages so they display the chain name. Previously they displayed the fee asset name (which can be different from the chain name) and also it had been broken (see before screenshot below) since #4339 (when the path to /accounts/ changed to /dashboard/accounts/).

Pull Request Type

[x] :bug: Bug fix (Non-breaking Change: Fixes an issue)
[ ] :hammer_and_wrench: Chore (Non-breaking Change: Doc updates, pkg upgrades, typos, etc..)
[ ] :nail_care: New Feature (Breaking/Non-breaking Change)

Issue (if applicable)

N/A
Risk
Low.

Testing
Check the full transaction history for specific accounts on various chains. These pages are accessible only for assets which have a long enough history of transactions, you can access them by going in the Dashboard, then Wallet, then choose a chain, then expan the accounts, then click on the "..." icon and "View account" (or simply on the account for UTXO chains), then on the Account page scroll down to the Transaction History. If there are enough transaction a "See all" link will be available. You can manually access it if there are not enough transaction by going to the same Account page and add /transactions/ at the end of the URL.
The breadcrumbs string should display the chain's name correctly.

Engineering
☝

Operations
☝

Screenshots (if applicable)
Before:

After:

Thanks for the review !


Update enums.md

Description modify

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thanks for contributing.... can you sign the CLA so we can merge your change?

Since you did not sign the CLA we have to close this PR.


Fix loading design configs again

- revert previous "fix"
~ only substitute glob when there is a match.
~ wrap section that parses each variable in try and catch so that the exception message contains both key and value. Previously, some exceptions thrown due to value errors were captured at the main function scope and hence losing the ability to find at which key the exception occurred. This is not a mandatory change and can be removed if not desirable.

I must admit I don't entirely see the value in reporting a failed glob as an exception. Why not just print a warning?

Makes sense. How about this: if a glob doesn't match, keep the *, warn the user and continue?

@donn I found out that there is no current mechanism for tcl.py (and others) to report warnings and I thought that there isn't much added value for a warning. This will simply only resolve the ref in case of failed glob. I believe other parts in the flow can capture "wrong" file path


UniFi poe switch state does not restore on HA restart

Home Assistant release with the issue:

0.98.0 through 0.100.2
Last working Home Assistant release (if known):
0.97.0 (probably 0.97.x)
Operating environment (Hass.io/Docker/Windows/etc.):

Hass.io
Integration:

unifi
Description of problem:
Using the unifi integration I have four poe switch ports controlled via Home Assistant to turn on/off cameras. These switch entities restore their state to "off" in HA versions up to 0.97 but do not restore reliably or at all in more recent HA versions.
Home Assistant either restores only two out of four switch entities (both belonging to switchports on the same physical switch), on subsequent restarts not even those restore their state.
The only way to get them back is to enable poe via the unifi controller and restart home assistant, which then detects the entities again.
Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):
System options: "Enable newly added entities: off"
Options: All off

Traceback (if applicable):

Additional information:
Pinging @Kane610

The only real change to the switch platform of UniFi integration is when I added better management to catch clients wrongfully marked as wired. And that was on release 0.100
https://github.com/home-assistant/home-assistant/commit/09c5b9feb35b70c96848b8796b6d4a747de998f6#diff-7859bcf768e81bbf13f1bbe317bca39f

@olbjan there have been no real changes related to the parts you have issue with

Oh well... I just tested and I can confirm the entities do restore... but in unavailble state. So the issue of not being able to turn on switchport poe after an HA restart persists but looks different now.


Fix gj/gk/gM to avoid being affected by non-inline virtual text

Fixes #12028
Problem
As mentioned in https://github.com/vim/vim/issues/12028#issuecomment-1966441523, gj/gk needed to be repeated for each virtual text line to skip over them.  It was actually moving the w_curswant position onto the outer virtual text, as if the outer virtual text (and their padding) was a part of the line, even though the actual cursor position would be shifted to stay in the actual text.
I found a similar issue with gM including the outer virtual text in the line length used to calculate where the middle of the line is to move the cursor there.
Solution
I've added a linetabsize_no_outer function in order to get the line length with outer virtual text properties excluded.  We can't just exclude text properties entirely, since we do want the influence of inline virtual text in these cases.  I've then used that to get the line length in the functions to handle gj/gk/gM cursor movement.
Note that I had tested gk on the first line and gj on the last line to ensure the cursor doesn't move, however, I omitted that from the included regression test due to issue #14261 causing the ruler to change when I would otherwise verify that the screen didn't change.  Also, the regression tests screen dumps will need updating if we exclude the 'above' virtual text from the ruler's vcol as I suggested in that issue.

thanks. I think this makes sense.

Hi @dylanahsmith Coverity complains about

I think this is a false positive, right?

Yeah, that looks like a false positive, since cts_text_prop_count is 0 if cts_text_props is NULL, and has a branch ensuring that if the allocation of cts_text_props fails.

Yes thanks that was also what I thought. Just wanted to get a second opinion about it. I have now marked it false positive in coverity.


Info on valueformat options. Can only display %

Is there an option to display the value as something other than a percentage? There are no options provided in the readme for the valueformat property.
I just want to display without percentage sign - have tried using 'number' and 'integer'.

Solved - used empty string for 'unit' property.


Release v0.2.13

Updated charts for releasing v0.2.13, updated aca-py base image

Seems to be working on this PR and has latest dev code at least
703d27c4-29e9-4b21-9c02-fcf3eb512b60
cbb25132-6193-4a76-83c3-5a05919685c8

Merged to avoid it from being a never-ending PR - things have been validated working 🙂


Added ugm file

Added Universitas Gadjah Mada's file

@GusZandy I am sorry, the domain mail.ugm.ac.id is removed from our trusted domains list because it was abused in the past. If you are the student of this school, please enroll to GitHub Student Developer Program. Then apply for JetBrains educational subscription with your GitHub account (GitHub tab at https://www.jetbrains.com/shop/eform/students).


Add support for MQTT over web sockets.

Types of changes

[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)

Proposed changes
It appears that support for MQTT over Web Sockets was intended, as some dead code already exists.  This code adds a checkbox on the MQTT configuration screen following the same pattern as for "use TLS".  If unchecked, current behavior stays the same.  If checked, MQTT requests use ws:// instead of mqtt:// for the run-time connection to the queue.
The workaround as it stands works, but seems a little kludgy.
https://discourse.nodered.org/t/mqtt-broken-url-and-port/1275
I am holding off on creating unit tests for MQTT node, since there is no coverage at all at this time.  If people agree this is a good idea, I'll create tests for the full node.
Checklist

[x] I have read the contribution guidelines
[x] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
[x] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Coverage increased (+0.05%) to 76.362% when pulling 052f1aa108567dde339ad7b52a0e94be53aa881e on tboman:topic/MQTT-over-ws into 6fa8b7f5f179fd6d97b5af9938d92d0fc44bfda0 on node-red:master.

Hi, the node already supports websockets.
The sidebar help for the broker config node describes how to do it. So the title of this pr confused me at first until I read the details.
So the purpose of this pr is to add an explicit checkbox, rather than just rely on the broker URL?
I can't review the code until tomorrow now, but does this maintain backward compatibility for users already using websockets with the node?
It also appears your commits have been made with a different email address to your GitHub account. As we require the contributor license agreement to be signed before accepting contributions, that relies on the commits coming from identifiable users. You'll need to fix that up before we can consider merging anything.

Right, the purpose is to add an explicit checkbox.  Using the scheme in the broker URL works, but I've seen a lot of people trip over it when connecting to our system that required web sockets.

Closed, see https://github.com/node-red/node-red/pull/1881


Upgrade default Bootstrap version 4.5.2 -> 4.5.3

Links from
https://getbootstrap.com/docs/4.5/getting-started/introduction/
Use cdn.jsdelivr.net consistently, replace a stackpath link

Typo'd the branch name but should be good otherwise :(

Closes: https://github.com/zostera/django-bootstrap4/issues/233

Closes: https://github.com/zostera/django-bootstrap4/issues/233


Tooltips Styling

add the theme styling to tooltips as well

I will play around with the tooltips and see what I can do!

@bwoah-md I added styles for tooltips! It would be great if you could test it out for me!

@ElsaTam Can you test this out too?

@Erallie  It is now Kapirklaa approved!

Perfect! I will close this issue now.

@bwoah-md I added styles for tooltips! It would be great if you could test it out for me!

yes it works perfectly well now, thanks erallie and sorry for the late reply 😅
its icy approved as well 😉

@bwoah-md Wonderful! Thank you for getting back on this! 😄


2.0.7 doesnt work, 2.0.6 does.

error message, (I dont have time to fully track the problem)

packages.json(BEFORE) NOT WORKING

packages.json(AFTER) WORKING

I've got the same issue, upgrading the app broke my nextjs app (with typescript)

It seems the raw source code was published and not the compiled one.

Same issue here :(

Same here :(

Same issue and I must downgrade 2.0.6

same issue here

i have the same issue , but jsute when I build my app (ps: I use Vite).I spent two days looking for where the problem comes from. I think it's better to stay on the 2.0.6 for the moment.

exactly, I have been getting the same error in the 2.0.7 version

Yeah same issue using nextjs

If anyone needs a quick fix just set the package version to 2.0.6 in your package.json for the time being.

Same here, thanks a lot for your work, but pls establish some basic CI to prevent something like that.

Hey guys,
This issue is fixed on v2.0.8


Patch kolla-ansible to allow Skyline SSO

Backports change 905860 from kolla-ansible that allows enabling of Skyline SSO
Upstream review: https://review.opendev.org/c/openstack/kolla-ansible/+/905860

This patch is outdated. Will create a new one once upstream is ready to merge.


KAFKA-9567: Docs, system tests for ZooKeeper 3.5.7

These changes depend on KIP-515: Enable ZK client to use the new TLS supported authentication, which was only added to 2.5.0. The upgrade to ZooKeeper 3.5.7 was merged to both 2.5.0 and 2.4.1 via https://issues.apache.org/jira/browse/KAFKA-9515, but this change must only be merged to 2.5.0 (it will break the system tests if merged to 2.4.1).
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@ijuma Take a look.  Just cannot be merged to 2.4.1 -- can only merge to 2.5.0.

ok to test

Since @rajinisivaram reviewed the original change, I think she may be better places to review this one too.

@omkreddy @rajinisivaram Any possibility of reviewing this?  A 2.5 RC is going to be cut soon, and this needs to be in the final release.  It is just doc changes and an additional system test.

@rondagostino Will review today. thanks.

Merging to trunk and 2.5.


fix: chart keys in MultiLineViz

SUMMARY
fixing multi-line viz issue of incorrectly formatted text for chart key when single line chart is used as a data
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before

After

TEST PLAN
Observe correctly formatted key for data in API call for both multi-line charts and single-line charts as a chart source
ADDITIONAL INFORMATION

[x] Has associated issue: #12935
[x] Fixes #12935
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

Codecov Report

Merging #12937 (65f3417) into master (77093a8) will decrease coverage by 1.76%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #12937      +/-   ##
==========================================
- Coverage   68.98%   67.21%   -1.77%
==========================================
  Files        1025      489     -536
  Lines       48767    28670   -20097
  Branches     5241        0    -5241
==========================================
- Hits        33641    19271   -14370
+ Misses      14989     9399    -5590
+ Partials      137        0     -137

Flag
Coverage Δ

cypress
?

javascript
?

python
67.21% <0.00%> (-0.42%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

superset/viz.py
59.01% <0.00%> (-0.04%)
:arrow_down:

superset/db_engines/hive.py
0.00% <0.00%> (-85.72%)
:arrow_down:

superset/db_engine_specs/hive.py
73.84% <0.00%> (-16.93%)
:arrow_down:

superset/db_engine_specs/presto.py
81.38% <0.00%> (-6.93%)
:arrow_down:

superset/db_engine_specs/mysql.py
89.79% <0.00%> (-2.05%)
:arrow_down:

superset/views/database/mixins.py
80.70% <0.00%> (-1.76%)
:arrow_down:

superset/models/core.py
87.22% <0.00%> (-1.64%)
:arrow_down:

superset/db_engine_specs/base.py
85.50% <0.00%> (-0.50%)
:arrow_down:

superset/views/core.py
74.98% <0.00%> (-0.45%)
:arrow_down:

superset/connectors/sqla/models.py
90.41% <0.00%> (-0.14%)
:arrow_down:

... and 536 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77093a8...65f3417. Read the comment docs.

sorry - was making this into a single commit


[UE2Rigify] Added Blender 4 Compatibility

Added support for Blender 4+ while maintaining Blender 3.6 compatibility.
Added @gzmuszynski's UE mannequin rigs.

Hmm action didnt trigger

Ah yes I have to the workflow setup to run on push. We could change it to run on PR if the branch was a PR from this repo. Just for security reasons, it would be too easy for someone to PR changes to run_tests.py and execute arbitrary python code on our runners.
I created a dev branch, so maybe we can intake PRs to the dev branch and then the CI will run then we can squash and merge to main when tests are passing.

I like the dev branch idea that would be great!

Actually so I did a little digging and looks like I can set the repo settings to not run PRs on forks from unknown members unless approved first. To there would just be a manual step of approving the workflow run, which will let us look at the code in the PR first, which should achieve the same goal as with what I was proposing with the dev branch. So Ill give that I shot.


Added envelope* methods to Geometry.

[X] I agree to follow the project's code of conduct.
[X] I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

bors r+


Ibeacon example not transmitting Major, Minor, Txpower

I try ibeacon with nrf52 example, ibeacon scanned with missing major, minor and txpower.
Then i check data transmitting with nRF connect on android. RAW data showed only uuid. This RAW data i record from nRF connect.
0x02010615FF4C000215A196C876DE8C4C47AB5AD7AFD5AE7127
Last 16 byte must from uuid.
-Arduino -
char* uuidString             = "a196c876-de8c-4c47-ab5a-d7afd5ae7127";
-RAWdata-
A196C876DE8C4C47AB5AD7AFD5AE7127
Any suggestion?

@vanbwodonk could you please try the change from PR #148 and provide your feedback.

@sandeepmistry it's worked. Major, minor, TXpower now transmitted. Thanks !!

@vanbwodonk great, thanks for trying it out. I've merged #148.


UNIQUE constraint failed when creation of the recipe

bug was eliminated by looking up for a category title only but not id


very minimal update

Tkinter-Designer instead of tkinter-designer in the CLI usage manual 2.3.III I believe
that's what worked on my device

Thanks @osbyrne


Can not install go module !   what's problem ?

What version of Go are you using (go version)?

$ go version
go version go1.16 darwin/amd64

Does this issue reproduce with the latest release?
What operating system and processor architecture are you using (go env)?
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/folls/Library/Caches/go-build"
GOENV="/Users/folls/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/folls/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/folls/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.16"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/dr/0hks8_y50xqffqdrtqtpdl3c0000gn/T/go-build2301911714=/tmp/go-build -gno-record-gcc-switches -fno-common"
GOROOT/bin/go version: go version go1.16 darwin/amd64
GOROOT/bin/go tool compile -V: compile version go1.16
uname -v: Darwin Kernel Version 20.3.0: Thu Jan 21 00:07:06 PST 2021; root:xnu-7195.81.3~1/RELEASE_X86_64
ProductName:	macOS
ProductVersion:	11.2.2
BuildVersion:	20D80
lldb --version: lldb-1<IP_ADDRESS>
Apple Swift version 5.3.2 (swiftlang-1200.0.45 clang-1<IP_ADDRESS>)

What did you do?
Install go extension module with vscode
What did you expect to see?
What did you see instead?
Error Log
ools environment: GOPATH=/User/folls/Desktop/go
Installing 1 tool at /User/folls/Desktop/go/bin in module mode.
gopls
Installing golang.org/x/tools/gopls FAILED
{
"killed": false,
"code": 1,
"signal": null,
"cmd": "/usr/local/go/bin/go get -v golang.org/x/tools/gopls",
"stdout": "",
"stderr": "go: writing stat cache: mkdir /User: read-only file system\ngo: downloading golang.org/x/tools/gopls v0.6.6\ngo: writing stat cache: mkdir /User: read-only file system\ngo: downloading golang.org/x/tools v0.1.0\ngo get golang.org/x/tools/gopls: mkdir /User: read-only file system\n"
}
1 tools failed to install.
gopls: failed to install gopls(golang.org/x/tools/gopls): Error: Command failed: /usr/local/go/bin/go get -v golang.org/x/tools/gopls
go: writing stat cache: mkdir /User: read-only file system
go: downloading golang.org/x/tools/gopls v0.6.6
go: writing stat cache: mkdir /User: read-only file system
go: downloading golang.org/x/tools v0.1.0
go get golang.org/x/tools/gopls: mkdir /User: read-only file system
no output

The error says "read-only file system"; it looks like Go cannot write files where it needs to. This is probably an issue with your machine, not a Go bug. Does that folder exist? Can you write on it?

From the go env output, I believe this is a typo in your GOPATH setting.
I see (emphasis added):

GOCACHE="/Users/folls/Library/Caches/go-build"
GOMODCACHE="/Users/folls/go/pkg/mod"

but:

GOPATH=/User/folls/Desktop/go

So the problem here seems to be that /Users has been typo'd as /User, and the go command cannot create the top-level /User directory (no s) because your root directory is (correctly) not writable.


hydrocarbon and syngas should be included

Description of the issue
this comes from #761
The definition of steam reformer references both hydrocarbon and syngas. Therefore, it would be useful to have them as concepts in our ontology and connect them to steam transformer.
A steam reformer is an energy converting device that produces syngas from hydrocarbons such as natural gas.
Hydrocarbon also appears in the definitions of several material entities.
Ideas of solution

hydrocarbon

definition: any of a class of organic chemical compounds composed only of the elements carbon (C) and hydrogen (H). (source)
classification: subclass of portion of matter, superclass of methane (?)
natural gas and oil and petroleum products has part some hydrocarbon
has role some fuel role
has disposition some combustible energy carrier disposition

syngas

definition: a fuel gas mixture consisting primarily of hydrogen, carbon monoxide, and very often some carbon dioxide. (source)
classification: material entity
has role some fuel role
has disposition some combustible energy carrier disposition

Workflow checklist

[ ] I discussed the issue with someone else than me before working on a solution
[ ] I already read the latest version of the workflow for this repository
[ ] The goal of this ontology is clear to me

I am aware that

[ ] every entry in the ontology should have a definition
[ ] classes should arise from concepts rather than from words

Why do you suggest for syngas material entity and not portion of matter as parent class? We already have other gas mixtures as portion of matter, notably air.

I don't have a reason for this, I assume this was just a mistake. I corrected that now and also made the definitions aristotelian:
Syngas is a portion of matter which is a fuel gas mixture consisting primarily of hydrogen, carbon monoxide, and very often some carbon dioxide.
Hydrocarbon is a portion of matter which is member of class of organic chemical compounds composed only of the elements carbon (C) and hydrogen (H).


Upgrade Observatorium API GW

Upgrade Observatorium API GW to its latest version
cc @nmagnezi

lgtm on green

I need to check why the operator fails.

You should also update the image tag in the CR example/core_v1alpha1_observatorium.yaml

It would be great to have the CR example generated from https://github.com/observatorium/configuration/blob/master/environments/base/default-config.libsonnet


GEODE-2423: Remove unused keystore files and rename to geode.keystore

The keystore files are used by the security related integration tests.

LGTM


Use default resolve function on non-scalar types

graphql uses a defaultResolveFn on all fields that don't provide one (scalar and non-scalar)
This is nice in the case that your resolved data for a parent type is already nested in the same way (via ORM, NoSQL, etc)
Example
Type Definition:
type Account {
  id: ID!
  address: Address
  firstName: String!
  lastName: String
}

type Address {
  street: String
  city: String
  county: String
  state: String
  postalCode: String
  country: String
  longitude: Float
  latitude: Float
  status: String
}

Data resolved by a parent type:
{
  id: 'xxxx-xxxx-xxxx-xxxx',
  address: {
    street: '1234 Avenue',
    city: 'Anywhere',
    state: 'NY',
  }
}

I shouldn't have to define a resolve method for data that matches my GraphQL schema.
Does removing this restriction break graphql-tools in any way?

Removing this wouldn't break graphql-tools. The reason I included that error is because more often than not, a missing resolve function for a non-scalar type indicates a typo or something. I thought it was an acceptable tradeoff to explicitly write resolve functions that just return a property for the cases where you need to pass through to non-scalar types.
How common is this passing through in your code? I'm asking because we could always add an option to turn these errors off, but I want to be sure it's actually something people need.

I think an option to use the default resolve function would be amazing!
Currently almost every one of our existing objects does some kind of nesting. We're transitioning a decent sized API from REST to GraphQL. We wanted to add some structure to the flat monolithic Salesforce objects, so the majority of our existing endpoints have 3-4 nested objects that get mapped by our ODM. The worse offender of nested structure is easily our /projects endpoint:
{
  id: 'Id',
  serviceNumber: 'Service__r.Service_Number__c',
  serviceId: 'Service__c',
  solarPhase: 'Solar_Phase__c',
  primaryCad: 'Primary_CAD__c',
  account: 'Account__c',
  contacts: {
    primary: {
      id: 'Account__r.Primary_Contact__r.Id',
      firstName: 'Account__r.Primary_Contact__r.FirstName',
      lastName: 'Account__r.Primary_Contact__r.LastName',
      fullName: 'Account__r.Primary_Contact__r.Name',
      email: 'Account__r.Primary_Contact__r.Email',
      phone: 'Account__r.Primary_Contact__r.Phone',
      mobilePhone: 'Account__r.Primary_Contact__r.MobilePhone',
    },
    secondary: {
      id: 'Account__r.Secondary_Contact__r.Id',
      firstName: 'Account__r.Secondary_Contact__r.FirstName',
      lastName: 'Account__r.Secondary_Contact__r.LastName',
      fullName: 'Account__r.Secondary_Contact__r.Name',
      email: 'Account__r.Secondary_Contact__r.Email',
      phone: 'Account__r.Secondary_Contact__r.Phone',
      mobilePhone: 'Account__r.Secondary_Contact__r.MobilePhone',
    },
  },
  meta: {
    assignedRepId: 'Opportunity__r.Sales_Credit__c',
    created: 'CreatedDate',
    updated: 'LastModifiedDate',
    campaign: 'Opportunity__r.CampaignId',
  },
  status: {
    hibernated: 'Hibernate__c',
    contractVerified: 'Customer_Agreement_Approved__c',
    active: 'Status__c',
    hoa: 'Opportunity__r.Solar_Have_an_HOA__c',
    installed: 'Installation_Complete__c',
    commissioned: 'Start_Billing__c',
    paymentInfo: 'Service__r.Billing_Account__r.Zuora__PaymentMethod_Type__c',
    billingRecord: 'Service__r.Billing_Account__c',
  },
  utilityProvider: {
    name: 'Opportunity__r.Solar_Utility_Provider__r.Name',
    rate: 'Primary_CAD__r.Current_Annual_Energy_Consumption__c'
  },
  address: {
    street: 'Service__r.Service_Address_1__c',
    street2: 'Service__r.Service_Address_2__c',
    city: 'Service__r.Service_City__c',
    state: 'Service__r.Service_State__c',
    zip: 'Service__r.Service_Zip_Code__c',
    country: 'Service__r.Service_Country__c',
  },
  date: {
    service: {
      created: 'Service__r.CreatedDate'
    },
    opportunity: {
      created: 'Opportunity__r.CreatedDate',
    },
    account: {
      created: 'Account__r.CreatedDate',
    },
    paymentMethod_collected: 'Payment_Method_Collected_On__c',
    creation_complete: 'Project_Create_Date__c',
    cancel: {
      requested: 'Cancellation_Requested_Date__c',
      complete: 'Cancellation_Date__c',
    }
    notary: {
      requested: 'Solar_Phase__r.Notary_Scheduled_On__c',
      complete: 'Solar_Phase__r.Notary_Complete_Date__c',
      appointment: 'Solar_Phase__r.Notary_Scheduled_For__c',
    },
    siteSurvey: {
      requested: 'Solar_Phase__r.Site_Survey_Scheduled__c',
      appointment: 'Site_Survey_Scheduled_For__c',
      complete: 'Site_Survey_Complete__c',
      approved: 'Site_Survey_Approved1__c',
    },
    siteSurveyExt: {
      complete: 'Site_Survey_Exterior_Completed__c',
    },
    siteSurveyInt: {
      complete: 'Site_Survey_Interior_Completed__c',
    },
    priorUsage: {
      complete: 'Usage_Completed__c',
    },
    cad: {
      complete: 'Solar_Phase__r.CAD_Design_Complete__c',
    },
    cadAsBuilt: {
      complete: 'Solar_Phase__r.As_Built_CAD_Completed__c',
    },
    cadPre: {
      complete: 'Pre_Design_Complete__c',
    },
    structuralReview: {
      complete: 'Structural_Review_Completed__c',
    },
    corporateCheck: {
      complete: 'Customer_Agreement_Approved__c',
    },
    permit: {
      requested: 'Permit_Submitted__c',
      approved: 'Permit_Approved__c',
    },
    hoaAppl: {
      requested: 'HOA_Application_Requested__c',
      approved: 'HOA_Application_Approved__c',
    },
    install: {
      requested: 'Solar_Phase__r.Installation_Scheduled_On__c',
      appointment: 'Installation_Scheduled_For__c',
      complete: 'Installation_Complete__c',
      approved: 'Solar_Phase__r.Installation_Data_Approved__c',
    },
    electrician: {
      requested: 'Solar_Phase__r.Electrician_Scheduled_On__c',
      appointment: 'Electrician_Scheduled_For__c',
      complete: 'Electrician_Complete__c',
      approved: 'Solar_Phase__r.Electrical_Data_Approved__c',
    },
    separateBldgInspection: {
      requested: 'Solar_Phase__r.SB_Inspection_Scheduled_On__c',
      appointment: 'Solar_Phase__r.Building_Inspection_Scheduled_For__c',
      complete: 'Solar_Phase__r.Building_Inspection_Complete__c',
    },
    bldgInspection: {
      requested: 'Solar_Phase__r.Building_Inspection_Requested__c',
      appointment: 'Building_Inspection_Scheduled_For__c',
      complete: 'Building_Inspection_Complete__c',
    },
    elecInspectionPhase: {
      requested: 'Solar_Phase__r.Elec_Inspection_Scheduled_On__c',
      appointment: 'Solar_Phase__r.Electrical_Inspection_Scheduled_For__c',
      complete: 'Solar_Phase__r.Electrical_Inspection_Complete__c',
    },
    elecInspection: {
      requested: 'Solar_Phase__r.Electrical_Inspection_Requested__c',
      appointment: 'Electrical_Inspection_Scheduled_For__c',
      complete: 'Electrical_Inspection_Complete__c',
      approved: 'Electrical_Inspection_Approved__c',
    },
    interconnectionPostinstall: {
      submitted: 'Interconnection_Post_Install_Submitted__c',
    },
    utilityUsage: {
      submitted: 'Usage_Submitted__c',
    },
    utilityBill: {
      submitted: 'Utility_Bill_Submitted__c',
    },
    utility: {
      requested: 'Utility_Interconnection_Requested__c',
      complete: 'Utility_Interconnection_Approved__c',
    },
    startBilling: {
      complete: 'Start_Billing__c',
    },
    ptoAwarded: {
      complete: 'PTO_Awarded_Date__c',
    },
    inService: {
      complete: 'In_Service_Date__c',
    },
    interconnectionPreinstall: {
      requested: 'Interconnection_Pre_Install_Requested__c',
      approved: 'Interconnection_Pre_Install_Approved__c',
    },
    mountInspection: {
      appointment: 'Solar_Phase__r.Mount_Inspection_Scheduled_For__c',
      complete: 'Solar_Phase__r.Mount_Inspection_Complete__c',
    },
    mountInstall: {
      appointment: 'Solar_Phase__r.Mount_Installation_Scheduled_For__c',
      complete: 'Solar_Phase__r.Mount_Installation_Complete__c',
    },
    elecUpgrade: {
      requested: 'Solar_Phase__r.Electrical_Upgrade_Scheduled_On__c',
      appointment: 'Solar_Phase__r.Electrical_Upgrade_Scheduled_For__c',
      complete: 'Solar_Phase__r.Electrical_Upgrade_Complete__c',
    },
    elecUpgradeInspection: {
      requested: 'Solar_Phase__r.Electrical_Upgrade_Inspection_Sched_On__c',
      appointment: 'Solar_Phase__r.Electrical_Upgrade_Inspection_Sched_For__c',
      complete: 'Solar_Phase__r.Electrical_Upgrade_Inspection_Complete__c',
      approved: 'Solar_Phase__r.Electrical_Upgrade_Inspection_Approved__c',
    },
    corpCancel: {
      request: 'Corp_Idle_Date__c',
      complete: 'Corp_Cancellation_Date__c',
    },
    corpChecked: {
      complete: 'Customer_Agreement_Approved__c',
    },
    cadQa: {
      complete: 'CAD_QA_Complete__c',
    },
    cadCustomer: {
      approved: 'CAD_Customer_Approved__c',
    },
    fin: {
      received: 'FIN_Received__c',
    },
    credit: {
      lastPulled: 'Opportunity__r.Credit_Score_Report__r.Credit_Check_Date__c',
    },
    ppa: {
      verified: 'Transaction_Date__c',
    },
  },
  bank: {
    accountNumber: 'Service__r.Solar_Bank_Account_Number__c',
    routingNumber: 'Service__r.Solar_Bank_Routing_Number__c',
    accountType: 'Service__r.Solar_Bank_Account_Type__c',
  },
  attachments: 'projectId'
}

My gosh, look at that endpoint...

Wow, yeah, I can definitely see why you'd want to turn off the resolver checks for this!

I think this is taken care of by #45, so I'm closing the issue.


Improperly initializing state during construction

Detailed description
I have seen Warning: AccordionItem: Did not properly initialize state during construction. Expected state to be an object, but it was undefined. triggered in multiple different components, such as AccordionItem, RadioButtonGroup and NumberInput.
Do you know why this happens?
Also, I cannot reproduce it since when using 6.28.0, it cannot render at all since some other states that need to read from the component state but the state is null.
Additional information
version 6.28.0

Should be addressed by #1255 - Feel free to speak up otherwise!


GH-1368 Added a RioSetting Compact_Xml.

GitHub issue resolved: #1368
Briefly describe the changes proposed in this PR:
Added a  "COMPACT_XML" in BasicWriterSettings to present the XML output as proposed, without rdf:nodeID.
We are checking If COMPACT_XML setting is set as true in RDFXMLPrettyWriter, the output is formatted accordingly.

PR Author Checklist (see the contributor guidelines for more details):

[x] my pull request is self-contained
[ ] I've added tests for the changes I made
[ ] I've applied code formatting (you can use mvn process-resources to format from the command line)
[ ] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change
[ ] every commit has been signed off

Note: we merge all feature pull requests using squash and merge. See RDF4J git merge strategy for more details.

Thanks for contributing.
Could you also please format the code with mvn process-resources (see also the details in https://github.com/eclipse/rdf4j/blob/master/.github/CONTRIBUTING.md#code-formatting)
The build server is quite strict about it, so even if your code is technically correct, it will refuse to build (that's why the checks above failed)

The commit is taking time because git is doing code analysis after reformatting.

Unfortunately, another problem is that the commit has not been signed off, as described in the contributor guidelines.
Since your branch only has one commit, you could try to fix this by doing git commit -s --amend on your local branch, and then using git push --force-with-lease to force-push the (now correctly signed off) commit.

So we've reformatted the code according to the guidelines and signed it off as well. Still the Last check from this Eclipse Foundation is failing until now.

Hi @REVERB283
assuming you have signed the Eclipse CA, have you used the same email address in the git commit signoff ? If they don't match, the last test will fail.

The commit was done by @iamaryananand, and his Eclipse ID was made after
the commit because we were not aware about this Contributor Agreement.
On Sun 31 May, 2020, 6:14 PM Bart Hanssens<EMAIL_ADDRESS>wrote:

Hi @REVERB283 https://github.com/REVERB283
assuming you have signed the Eclipse CA, have you used the same email
address in the git commit signoff ? If they don't match, the last test will
fail.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/eclipse/rdf4j/pull/2294#issuecomment-636466497, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AHYJY5GPI4Y7VGGN55T27O3RUJGKXANCNFSM4NOCCULA
.

OK, thank you for the information
@iamaryananand have you used the same email address in the git commit signoff as in your Eclipse Contributor Agreement ? Because it looks like git is using an Anonymous / noreply address.
You can change this easily, either in the IDE itself or using the command line: https://stackoverflow.com/questions/30677775/how-do-i-set-user-email-and-user-name-in-intellij-14-with-git-integration
Then you probably have to do git commit -s --amend  and git push --force-with-lease  again, like @jeenbroekstra mentioned in https://github.com/eclipse/rdf4j/pull/2294#issuecomment-636248790

@barthanssens @jeenbroekstra
We can't seem to remove the Failure in our eclipsefdn/eca test, even after following all the necessary steps you sent us.
Is there any way we can pass that test, or do we need to generate another pull request.

No worries
When all the changes have been made (e.g. moving the COMPACT_XML from BasicWriterSettings to eclipse.rdf4j.rio.helpers.XMLWriterSettings) and you're happy with the code, all the commits can be  "squashed" into 1 single commit (see https://rdf4j.org/documentation/developer/squashing/)
And you can then signoff that squashed commit with the "correct" email address.

So we've finally managed to successfully commit the changed made and signoff with proper author credentials. Kindly check for any discrepancy if it's ready for merge.

@iamaryananand  @REVERB283 are you still available to finish this PR? No rush, but I noticed that after a lot of activity it has suddendly gone a bit quiet. Also if you don't have time to finish this, just let us know, and we can take over.

Hi!
We've made the changes as you guys requested and would like to ask for another review.


Can't open on latest unity 2019.3.0a4

After upgrade. I get those errors:
"The type or namespace name 'NetworkSystem' does not exist in the namespace 'UnityEngine.Networking' (are you missing an assembly reference?
"
"
Assets/CaptainsMess/CaptainsMessClient.cs(23,35): error CS0246: The type or namespace name 'NetworkDiscovery' could not be found (are you missing a using directive or an assembly reference?)
"
I guess cause the networking library was updated

Thanks for the report, the library definitely needs to be updated. It hasn't had any love for quite some time. I'm actually in the process of finding a network programmer to help me maintain and upgrade it, so hopefully there will be some changes in the next month or two!

Just a tip: If the assembly references get messed-up/lost after upgrading Unity and you're using Visual Studio, I've found that deleting the Visual Studio-generated files and the .vs folder, then recreating them by double-clicking on one of your scripts from within Unity might fix the issue.
Also, I've seen where, even when using the "#using UnityEngine.Networking;" directive doesn't find classes, explicitly referencing the namespace from within code works, for example, "UnityEngine.Networking.NetworkSystem..."

In this case it's probably due to the deprecation of UNet. I'm going to investigate the new system they have planned but I'm also looking into alternatives like Mirror and Telepathy.

UNet is being deprecated, and its libraries are now marked as [obsolete], but it should still be included and functional with Unity 2019.3.0a4.

I tried to correct those errors, are you interested in a pull request with the fixes ? (I’m using Unity 2020.1.7f1)

Sure!  I'm not supporting this library at the moment but it's possible some people will still find it helpful.


Adding between code

Hey @blastdan can you remove the dockerfile that you added? otherwise lgtm

@blastdan just need your CLA filled out per above in order to merge

I had to squash the commits to remove the other contributors for the CLA check to pass. Now it seems the rest of the checks aren't moving.

Ok thanks. Yea I'll figure out the other checks, those are new.
On Tue, May 7, 2024, 08:56 Daniel McCrady @.***> wrote:

I had to squash the commits to remove the other contributors for the CLA
check to pass. Now it seems the rest of the checks aren't moving.
—
Reply to this email directly, view it on GitHub
https://github.com/GoogleCloudPlatform/bigquery-geotools/pull/9#issuecomment-2098343969,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHWLWSSY7HIOBMOHWO6633ZBDFPZAVCNFSM6AAAAABARZGAPCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJYGM2DGOJWHE
.
You are receiving this because you commented.Message ID:
@.***>


POST dataset dublicate names

When I create a dataset and then to the same call again then the triples get added. Instead it should throw an error message Dataset "name" already exists. and response code 400.

spotted the same behaviour today.
If POST + existing name -> Dataset "name" already exists.
If PUT + existing name -> update fields (name, description, etc.) + append the entities (if sent any) to the dataset
If I read well the code in https://github.com/freme-project/freme-ner/blob/master/src/main/java/org/elinker/core/rest/FremeNerManageDatasets.java
PUT is not implemented.
Note that it was in the pre-architecture update, and it was working as described above.

Should be fixed. Please recheck.

PUT is not implemented.

This should be implemented, it's done by this function. @m1ci what kind of (wrong) behaviour did you notice?

I see, there is no possibility to change the identifier (name) of a dataset. Should we implement this? How was this done before the architecture update?

The name, is a unique ID for the dataset. So please leave it as it is.

Was this possible before the architecture update?

No it was not possible.

@ArneBinder

This should be implemented, it's done by this function. @m1ci what kind of (wrong) behaviour did you notice?

PUT does not seem to be implemented (or I do smth wrong)
I try to submit PUT request
  curl -X PUT --header "Content-Type: text/n3" --header "Accept: application/json" --header "X-Auth-Token: XXXXXXX" -d @data.nt "http://api-dev.freme-project.eu/current/e-entity/freme-ner/datasets?informat=turtle&name=mycooldata1&description=bla&language=en&visibility=public"
and I get
{    "timestamp":1461049917726,    "status":405,    "error":"Method Not Allowed",    "exception":"org.springframework.web.HttpRequestMethodNotSupportedException",    "message":"Request method 'PUT' not supported","path":"/e-entity/freme-ner/datasets" }

it works, I used wrong URI, sorry for the noise.

I tested again and it works. Thanks


Add additional printer columns and make the engine/experiment CR fields selectable

Is this a BUG REPORT or FEATURE REQUEST?
Choose one: BUG REPORT or FEATURE REQUEST

What happened:
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:

Not supported yet!