Character for parameters

Now, SQLite supports five types of the representation of parameters:
?NNN
?
:AAAA		.
@AAAA
$AAAA

AlaSQL also supports two forms:
?
$[1]

I need a dollar sign $ or colon :for other purposes. What is I leave only two representations of parameters and ?
?
?0, ?1, ?3...

What do you think?

Second question: In some SQL dialects (MS Access) this character is using for constants of date type, like #Jul 1, 2015#.  I want to use number sign # for reference operator (refer to the object by it's id). Is it so important to have date constants? Or may be we can use another approach, like D'Jul 1,2015' ?

Awwww - its not good to change the sqlite specification so one have to replace ? and $ in existing code.
Hmm. Can we do something else? how are we using the $ and : now? could they be escaped? can we use a flag to set behavour?
I think its a general discussin: will AlaSQL mimic a specific SQL falvour - or make its own? if we state that it supports SQLite or MS access (uhhffff) then we must obay implementation. If we make our own falvour, lets be creative and clever.

You are right...

Let's make AlaSQL own flavor in version 0.2 when we will have modular structure, and we can develop AlaSQL dialect without any references to other databases as a separate module.
How I would like to use $? Now $ sign is widely used by JavaScript libraries (e.g.jQuery), and we can use these variables and columns and function names without square brackets (now we have to use [$])
Colon... do not know yet.

Other ideas, how AlaSQL uses these signs:
4. At @ is used as variables names (like in T-SQL)
5. Number # can be used as date (like in MS Access) or I would like to use it for "reference" operator for document-storage/graph operators, Like:
    CREATE CLASS Person;
    CREATE CLASS City;
    CREATE CLASS Country;

    INSERT INTO Person SET name="John", city=
        (INSERT INTO City SET name = "Kuala Lumpur", country =
             (INSERT INTO Country SET name = "Malasia"));
    SELECT name, city#name, city#country#name FROM Person;
     -- returns [{"name":"John","city#name":"Kuala Lumpur","city#country#name":"Malasia"}]

Plus, for graphs I would like to add something like --> and -->> operators:

    SET @john = (CREATE VERTEX SET name = "John");
    SET @mary = (CREATE VERTEX SET name = "Mary");
    CREATE EDGE FROM @john TO @mary SET name = "loves";
    SEARCH OUTE() OUTV() @mary FROM @john;
    -- returns [{name:"loves", $id:124, $in:[122],$out:[123], $onto:"edge"}]
    SEARCH OUTE() OUTV() FROM @john;
    -- returns [{name:"Mary", $id:123, $in:[124],$out:[], $onto:"vertex"}]
    SEARCH OUTV() FROM @john;
    -- returns [{name:"Mary", $id:123, $in:[124],$out:[], $onto:"vertex"}]
    SEARCH OUTE(name="loves")  FROM @john;
    -- returns [{name:"loves", $id:124, $in:[122],$out:[123], $onto:"edge"}]
    SEARCH INE(name="loves")  FROM @mary;
    -- returns [{name:"John", $id:122, $in:[],$out:[123], $onto:"vertex"}]
    PRINT @john, @mary;
    -- returns 122,123

PS. Sorry, I am all in this document/graph database idea right now. But I like the idea to extend AlaSQL with simple Graph syntax to make simple social network anaylysis.

Go dive deep !

closing - as its implemented...
> alasql('value of select $1', [4,5])
5


Update dependency on azure-devtools

To avoid a new version to be selected unintentionally

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

[ ] I adhere to the Command Guidelines.

View a preview at https://prompt.ws/r/Azure/azure-cli/6292
This is an experimental preview for @microsoft users.


Extra entry for previous commit on dashboard with "git push --mirror"

Gitea version (or commit ref): 1.5.0
Git version: 2.18.0
Operating system: Debian GNU/Linux 9.5
Database (use [x]):

[ ] PostgreSQL
[ ] MySQL
[ ] MSSQL
[x] SQLite

Can you reproduce the bug at https://try.gitea.io:

[x] Yes: https://try.gitea.io/markshep/duplicate-dashboard-entries
[ ] No
[ ] Not relevant

Log gist:
?

Description
When a client/downstream repo has a post-commit hook that invokes "git push --mirror origin" then whenever a push happens two new entries will appear on the dashboard.  There's the expected one for the commit that just happened, but then an extra one that refers to the previous commit, but with with "refs/remotes/origin/master" listed as the branch rather than just "master".
Screenshots

Closing as this seems to be fixed now.  I think the fix happened somewhere between 1.6.4 and 1.7.0.
(Dunno why this issue was marked as a question - it isn't!)


Custom "Site Maintenance" page

From @jayjun on June 21, 2017 16:14
It'll be nice to be able to customise the blank "Site Maintenance" page, seen after deis maintenance:on.
Maybe a volume of static files can be mounted for nginx to read from. Not sure which volume type fits best?
Copied from original issue: deis/router#349

From @krancour on June 26, 2017 18:25
A simpler implementation would be (optional) support for a designated "maintenance app" to which all traffic for an app under maintenance can be routed.

From @chdsbd on December 13, 2017 19:5
Heroku has a pretty simple solution of using config variables pointing to static page urls: https://devcenter.heroku.com/articles/error-pages#configure-your-application. So a user could set a config variable MAINTENANCE_PAGE_URL pointing to some static site to display.
From a cursory glance through the code base, this will require changes across multiple repos (there are probably more): controller, router model, router nginx config, workflow-cli
EDIT: Just realized Workflow is EOL... ☹

This can be done and it would be a nice feature for the hephy-router. It can be done through annotations of a GLOBAL_MAINTENANCE_PAGE_URL on the router deployment object.


Example main file

The link to the example main file appears to be broken.

I guess I'm being stupid, it is only the link in the readme that is broken.


Deprecate the package

Motivation
Which issue does this fix? Fixes #issue number
If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist

[ ] Code follows coding conventions held in this repo
[ ] Automated tests have been added
[ ] Tests are passing
[ ] Docs have been updated (if applicable)
[ ] Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test
If manual testing is required, what are the steps?

I'm not a member of js maintainers but I approve this deprecation message on their behalf 🤷 rip


l2_cost oneoff script

Dual Net will calculate L2 cost over these variables
vars names(166 reduced to 12):
	 batch_normalization/beta:0
	 batch_normalization/gamma:0
	 batch_normalization_<X>/beta:0
	 batch_normalization_<X>/gamma:0
	 conv2d/bias:0
	 conv2d/kernel:0
	 conv2d_<X>/bias:0
	 conv2d_<X>/kernel:0
	 dense/bias:0
	 dense/kernel:0
	 dense_<X>/bias:0
	 dense_<X>/kernel:0

Reading models 200-477, eval_every=100
vars names(415 reduced to 29):
	 batch_normalization/beta
	 batch_normalization/beta/Momentum
	 batch_normalization/gamma
	 batch_normalization/gamma/Momentum
	 batch_normalization/moving_mean
	 batch_normalization/moving_variance
	 batch_normalization_<X>/beta
	 batch_normalization_<X>/beta/Momentum
	 batch_normalization_<X>/gamma
	 batch_normalization_<X>/gamma/Momentum
	 batch_normalization_<X>/moving_mean
	 batch_normalization_<X>/moving_variance
	 conv2d/bias
	 conv2d/bias/Momentum
	 conv2d/kernel
	 conv2d/kernel/Momentum
	 conv2d_<X>/bias
	 conv2d_<X>/bias/Momentum
	 conv2d_<X>/kernel
	 conv2d_<X>/kernel/Momentum
	 dense/bias
	 dense/bias/Momentum
	 dense/kernel
	 dense/kernel/Momentum
	 dense_<X>/bias
	 dense_<X>/bias/Momentum
	 dense_<X>/kernel
	 dense_<X>/kernel/Momentum
	 global_step

LGTM


added footer

For #123
Added footer to home and contributors pages.

@akankshat05 Not working

Can I know what should be fixed?

@Palak-137

@akankshat05 Not working

Can I know what should be fixed?

change the font family of the footer
fix the position of the footer like an header
footer should be visible on all the pages like: login, signup

@akankshat05

@BRAVO68WEB do include it under gssoc!

@akankshat05 Done


Doc?

Hello,
How can I use vue-bulma?
Is there a proper documentation?
best,

I will do PR for docs.


Update README URLs based on HTTP redirects

Created with https://github.com/dkhamsing/frankenstein
GitHub Corrected URLs

Was
Now

https://github.com/kciter/KCFloatingActionButton
https://github.com/kciter/Floaty

https://github.com/kciter/KCHorizontalDial
https://github.com/kciter/HorizontalDial

https://github.com/kciter/KCSelectionDialog
https://github.com/kciter/SelectionDialog

          1 Error

:no_entry_sign:
Found 1 link issue

          1 Warning

:warning:
Too many changes (when adding, please keep it to one project per Pull Request)

Link issue by awesome_bot

Line
Status
Link

2529
522
http://rypress.com/tutorials/objective-c/index

  Generated by :no_entry_sign: Danger


Lua error message when shooting from weapon, im using ARCCW

[Dynamic Weapon Reverb] lua/autorun/server/dwr_server.lua:207: attempt to index global 'entity' (a nil value)
1. v - lua/autorun/server/dwr_server.lua:207
2. unknown - lua/includes/modules/hook.lua:96
NOTE: In previous update there was no errors when shooting from these weapons like ARCCW

will push a fix soon

pushed

pushed

thx


use StandardCharsets instead of string

Since Java 7 StandardCharsets can be used for standard charsets. It prevents the unnecessary lookup of the charset and in addition no  UnsupportedEncodingException can be thrown.

Good to know. I thought this is a trivial change. I will sign the CLA and notify you as soon is its done.

Thanks, ICLA as received.


Add a control to unfollow/re-follow the current scene root's movement

Right now, the camera will follow the scene root when it moves, which is useful to ensure the user doesn't lose track of the action. But in order to make sure everything is behaving correctly, it's often important to be able to see the motion of the scene as a whole.

Implemented in commit cad2b2a


[BUG] azure-identity specifies a variable version range for net.minidev:json-smart, leading to dependency resolution issues

Describe the bug
Same issue as #22807 and #14907.
I'm seeing this bug with azure-identity 1.3.4. Is it possible that there was a regression between the patch releases, or perhaps the issue was closed mistakenly?
Exception or Stack Trace
Add the exception log and stack trace if available
To Reproduce
Steps to reproduce the behavior:
Code Snippet
Add the code snippet that causes the issue.
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Setup (please complete the following information):

OS: [e.g. iOS]
IDE: [e.g. IntelliJ]
Library/Libraries: [e.g. com.azure:azure-core:1.16.0 (groupId:artifactId:version)] com.azur:azure-identity:1.3.4

Additional context
Add any other context about the problem here.
Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

[ X ] Bug Description Added
[ ] Repro Steps Added
[ X ] Setup information Added

Hi @dincciftci , json-smart is pinned to 2.4.7 in the released 1.3.4 pom - https://repo1.maven.org/maven2/com/azure/azure-identity/1.3.4/azure-identity-1.3.4.pom
<!--  This dependency pins the version to 2.4.7 and is required to be pinned as part of issue https://github.com/Azure/azure-sdk-for-java/issues/22807.
     Don't remove this until the version gets pinned in msal4j library. -->
<dependency>
<groupId>net.minidev</groupId>
<artifactId>json-smart</artifactId>
<version>2.4.7</version>
<!--  {x-version-update;net.minidev:json-smart;external_dependency}  -->
</dependency>

@g2vinay can you please link to the msal4j github issue tracking this?

Also sharing link to the code in the main branch - https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/identity/azure-identity/pom.xml#L90-L97

@joshfree thanks for taking a look quickly.
Here's what gradle tells me when inspecting this dependency after taking a dependency on azure-identity 1.3.4:
 ./gradlew dependencyInsight --configuration runtime --dependency net.minidev:json-smart                                                                                > Task :dependencyInsight
net.minidev:json-smart:2.4.7 (selected by rule)
   variant "runtime" [
      org.gradle.status          = release (not requested)
      org.gradle.usage           = java-runtime (not requested)
      org.gradle.libraryelements = jar (not requested)
      org.gradle.category        = library (not requested)
   ]

net.minidev:json-smart:2.4.7
\--- com.azure:azure-identity:1.3.4
     \--- runtime

net.minidev:json-smart:[1.3.1,2.3] -> 2.4.7
+--- com.nimbusds:nimbus-jose-jwt:8.14.1
|    \--- com.nimbusds:oauth2-oidc-sdk:7.4
|         \--- com.microsoft.azure:msal4j:1.10.1 (requested com.nimbusds:oauth2-oidc-sdk:9.7)
|              +--- com.azure:azure-identity:1.3.4
|              |    \--- runtime
|              \--- com.microsoft.azure:msal4j-persistence-extension:1.1.0 (requested com.microsoft.azure:msal4j:1.4.0)
|                   \--- com.azure:azure-identity:1.3.4 (*)
\--- com.nimbusds:oauth2-oidc-sdk:7.4 (*)

(*) - dependencies omitted (listed previously)

Notice the following line indicating a variable version range:
net.minidev:json-smart:[1.3.1,2.3] -> 2.4.7

My project downgrades the OIDC library to a lower version than what Azure Identity ships with -- to outrule issues stemming from this, here's a more vanilla use of azure-identity demonstrating the same problem:
> Task :dependencyInsight
net.minidev:json-smart:2.4.7 (selected by rule)
   variant "runtime" [
      org.gradle.status          = release (not requested)
      org.gradle.usage           = java-runtime (not requested)
      org.gradle.libraryelements = jar (not requested)
      org.gradle.category        = library (not requested)
   ]

net.minidev:json-smart:2.4.7
\--- com.azure:azure-identity:1.3.4
     \--- runtime

net.minidev:json-smart:[1.3.3,2.4.7] -> 2.4.7
\--- com.nimbusds:oauth2-oidc-sdk:9.7
     \--- com.microsoft.azure:msal4j:1.10.1
          +--- com.azure:azure-identity:1.3.4
          |    \--- runtime
          \--- com.microsoft.azure:msal4j-persistence-extension:1.1.0 (requested com.microsoft.azure:msal4j:1.4.0)
               \--- com.azure:azure-identity:1.3.4 (*)

(*) - dependencies omitted (listed previously)

@dincciftci
Looking at the trees above.
In the vanilla scenario, Gradle doesn't downgrade the Oauth2-oidc-sdk while in your project it downgrades it.
This is likely happening due to another dependency in your project that is using a lower version of json-smart or oauth2-odic-sdk library and that is causing dependency resolution to a lower version.
In that scenario, I would recommend to have those libraries upgraded to use latest version of json-smart library.
As any version lower than or equal to 2.3 has this critical level CVE in it and is not safe for the application.
Your application should be using the latest version of json-smart as that has the CVE fix included in it.
The azure-identity library is pinning to the latest version of json-smart currently.
Further, we have opened this issue here in the Msal4j library that is using the json-smart library via Oauth2-oidc-sdk, so that it gets pinned at that level, as azure-identity doesn't directly utilize the json-smart dependency.

Related Issue in oauth2-oidc-sdk bitbucket issue tracker https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions/issues/370/variable-range-of-netminidev-json-smart

@g2vinay @joshfree Thank all for tracking the issues with the upstream sources of these problems!
With the current fix, gradle continues to interpret a variable version range (net.minidev:json-smart:[1.3.1,2.3] ) while having a preference for a fixed version 2.4.7. The original fix was (somehow) not causing this, but I'm not familiar enough with Maven to tell you what's different.
IMO it's not worth your effort to spend more time trying to fix up the version in azure-identity, I'm hoping the libraries with a direct dependency on json-smart will solve this once and for all. Until then, we'll continue to pin the version of json-smart to azure-identity's preferred version.
So on that note you're welcome to close this issue -- I really appreciate your help pushing for a fix here.
I would still recommend adding build-time checks to prevent such issues from leaking through Azure Java SDK but that's something you can track at your discretion, with your general backlog and priorities in mind.

@dincciftci

With the current fix, gradle continues to interpret a variable version range (net.minidev:json-smart:[1.3.1,2.3] ) while having a preference for a fixed version 2.4.7.

<version>2.4.7</version> means 2.4.7 is recommended.
<version>[1.3.3,2.4.7]</version> means [1.3.3,2.4.7] is required.

You can refer to Understanding Maven Dependency Mediation (Part 2) to get more information about recommended version and concrete version.
You can avoid version range in your side by exclusion like this:
    <dependency>
      <groupId>com.azure</groupId>
      <artifactId>azure-identity</artifactId>
      <version>xxx</version>
      <exclusions>
        <exclusion>
          <groupId>net.minidev</groupId>
          <artifactId>json-smart</artifactId>
        </exclusion>
      </exclusions>
    </dependency>

FYI: I created a PR to avoid bring version range to our customer: #27453

Hi, @dincciftci

The issue is in the third party oauth2-oidc-sdk library and they're working to fix it. Link to their issue.

You can fix the version range problem by excluding the dependency. Here is example:

    <dependency>
      <groupId>com.azure</groupId>
      <artifactId>azure-identity</artifactId>
      <version>xxx</version>
      <exclusions>
        <exclusion>
          <groupId>net.minidev</groupId>
          <artifactId>json-smart</artifactId>
        </exclusion>
      </exclusions>
    </dependency>

Once the oauth2-oidc-sdk fixes it, we will ship the updated version of the library.


accountPickerScreen: Fix re-render on every event of long poll.

Use reselect in getAccountStatuses, so that it memorize accounts and
return same object for same value and saves re-render.

Merged -- thanks @jainkuniya !


Azure login screen

To start, the way our login prompt is set up for WPF, Microsoft generates it and we have no real control/access for it. When running our automation tests we get this error 90% of the time "Failed to locate opened application window with appId".
How can I get this resolved?
WAD version 1.1.1809

You need to create a root session and then switched to the opened window. check FAQ

You need to create a root session and then switched to the opened window. check FAQ

@anunay1 We tried that, it didn't work.

@anunay1 We tried that, it didn't work.

Are the elements shown in inspect.exe for login azure

Are the elements shown in inspect.exe for login azure

Are the elements shown in inspect.exe for login azure

Yes they are showing. We ended up doing this for it to work. It's probably not a good way of going about this but it works:
` if (session == null)
{
try
{
// Start a new session by creating a new instance of the WindowsDriver object,
// we pass the WinAppDriver url and the appiumOptions parameters we created.
session = new WindowsDriver(new Uri(WindowsApplicationDriverUrl), appiumOptions);
curWindow = session.CurrentWindowHandle;
loginWindow = session.WindowHandles[0];
//System.Diagnostics.Trace.WriteLine("Application Window: " + session.CurrentWindowHandle + " Login Window: " + loginWindow + " Window Handle count: " + session.WindowHandles.Count());
}
catch(Exception ex)
{
   // Assert.IsNotNull(session);

   do

   {

     session = new WindowsDriver<WindowsElement>(new Uri(WindowsApplicationDriverUrl), appiumOptions);

      curWindow = session.CurrentWindowHandle;

   }while(session == null);

}
}`
`[TestMethod]
    public void PrePopulated_Test()

    {

        System.Diagnostics.Trace.WriteLine("PrePopulated_Test");

        if(session != null)

        {

            // Click prepopulated account name

            // session.FindElementByName(fix.UserName).Click();

            loginTests.Login(fix.UserName, fix.PassWord, "loginWindow");

            session.SwitchTo().Window(session.WindowHandles[0]);

        }

        else

        {

             Assert.Equals(session, null);

        }

    }`

@anunay1 Now it doesn't work again. There doesn't appear to be a cure all fix for this.


Missing key when connecting to linux target

My Linux target doesn't have the compiler or GDB, so when I add a connection in the Cross Platform settings page, there will be an error saying that it could not find items for IntelliSense.  According to comment from Marc Goodner in a blog post, this is fine since we are not building on this machine. However, in 16.1.3, when I try to update a CMake Linux project's launch.vs.json ${remoteMachineName} to this target, there will be an exception saying that a "key does not exist".  I think that's the general dictionary exception message, and is probably not working due to the IntelliSense error.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 77337ba5-50f6-b474-89db-dd51bd8b560d
Version Independent ID: cdc28c8a-a50e-f6d6-bf25-f5d80b056a5a
Content: Connect to your target Linux system in Visual Studio
Content Source: docs/linux/connect-to-your-remote-linux-computer.md
Product: visual-cpp
Technology: cpp-linux
GitHub Login: @mikeblome
Microsoft Alias: mblome

@infinite-persistence this sounds like a product issue for 16.1. Are you willing to raise the issue on developer community, so that it can be triaged and addressed by the product team?


out of memory issue

Hi @hturki,
How are you! Thanks for the great work!
I am trying to visualize 'quad' dataset model. It has been very successful during model training, eval, creating octree, and building the viewer, but I got 'out of memory' error after the model was loaded (as the screenshot shows).
I understand my gpu has small memory. Any suggestions to walk around with it? Can I create octree and view it for just part of model i.e. the model before merging. I briefly tried, but no luck. Thank you!
GPU: GeForce RTX 3070 (with 8 GB memory)
OS: Ubuntu 20.04
cuda: 11.6
libtorch: 1.12+cu116 C++ distribution (I tried to use lower version libtorch and cuda to save memory, but got some issues)

I switched to a better gpu.


center_loss_cls is too big

Hi, yifan,
I tried to train the model on  my own dataset, but I found the value of center_loss_cls is too big(from 100 to 300) when training.
I want to know why and how to solve that problem.

Sorry I don't know much about your own data. These might be caused by inaccurate predictions of candidate points, so you can turn down the vote weight in LOSS_WEIGHTS, and adjust the EXTRA_WIDTH in TARGET_CONFIG. May it help you!


chore: Adopt Google's formatting style

Fix #157
@fermadeiral I know we said no review on this one, but this is a tiny bit different than what we discussed, so I want to run it by you before I merge. Instead of using Checkstyle, I opted for Spotless. It's a neat tool that can plug into Maven to do the formatting for you, and can also run checks. mvn spotless:apply to apply formatting fixes, and mvn spotless:check to check for violations.
Now, what I found pragmatic about Spotless is that it will only report a check violation if it can be automatically fixed. So, for example, Google's formatting style is very picky about having a Javadoc comments on every public method and class, that lines are less than 100 characters, etc. However, the autoformatter often can't fix those things, and so fixing them is a manual affair. Spotless will not complain about such violations, because google-java-format can't fix them.
This seems like a nice tradeoff. We get a consistent code style with absolutely no manual effort, and it doesn't hinder contributions by others as all violations can be fixed by a simple mvn spotless:apply. What do you think about this?
And one more thing: 2 spaces or 4 spaces for indentation, any preference? The tool allows us to choose.
Ps. Only .travis.yml and pom.xml contain changes other than formatting. Note that I've updated Travis to use OpenJDK11 as google-java-format requires that as of 1.8 (and they are now on 1.9). This requires developers of sorald to use JDK11+, but it can still be built with JDK8+ as Spotless is not hooked into any phase and won't run unless explicitly asked to. Alternatively, we can downgrade to google-java-format 1.7, but I really do think it's time for the world to move on from Java 1.8 :)

This seems like a nice tradeoff. We get a consistent code style with absolutely no manual effort, and it doesn't hinder contributions by others as all violations can be fixed by a simple mvn spotless:apply. What do you think about this?

Seems good to me!

And one more thing: 2 spaces or 4 spaces for indentation, any preference? The tool allows us to choose.

I prefer 4 spaces.

I also prefer 4 spaces, so let's go with that. Will fix that and merge tomorrow morning!

@slarse ok!

@fermadeiral I'm merging this as I need it right now to be able to keep working. Feel free to retroactively change anything. Here's a summary of the non-formatting changes.

Spotless added to pom.xml.

Not bound to any phase, must be run manually with mvn spotless:check to check compliance or mvn spotless:apply to apply the formatter.
AOSP style used, i.e. 4 spaces

CONTRIBUTING.md now contains a step about ensuring code compliance with mvn spotless:apply
.travis.yml updated to run spotless:check, and use JDK11 (required by newer versions of google-java-formatter)

Thanks, @slarse.


How to checkout code without artifacts/git

Is it possible to checkout code in container without using artifacts/git ?

Handled in container after checkout


Add test files for evaluation by pytest and pytest-mpl

This PR will vastly improve stability and help support collaboration. Currently, continuous integration includes only the User Guide examples, and image comparison is not carried out on the figures. Instead, to minimize bugs, I've been manually running tests on my machine and then visually inspecting the test figures. Considering proplot's growing popularity and recurring "regressions" in recent releases, this approach is clearly unsustainable.

This had too many conflicts with the base branch. Replaced by #325.


Currency endpoint: Wrong date in beginDate parameter in arion.js

beginDate was set to Yesterday. Correct date is today

🆒


Simplify return type of createForm

Is your feature request related to a problem? Please describe.
Simplify return type of createForm
Describe the solution you'd like
To have a single generic type for the return type of createForm. It would allow passing the form between components in a typesafe way.
At present, what would be the type of a property on a component that accepts a createForm() value?
Describe alternatives you've considered
Using any.
Additional context
Using Solidjs

Catching up a bit. Currently I don't export any types for it but is it generic enough if you do something such as this?
export type FelteForm = ReturnType<typeof createForm>;


django-ckeditor working on one computer, not working in another

Hi, in relaction of my other post (https://github.com/django-ckeditor/django-ckeditor/issues/425), this is a very weird problem. I have same OS, same version, same django, same django-ckeditor, etc.
Where is not working: on my PC (local development) and on my server (production)
Where is working: on my Notebook (local development).
Here you can see that all JS and CSS from ckeditor is loading (my notebook): http://imgur.com/a/0pAyO
Now, the same in my PC, you can see that is not loading all related stuff to ckeditor: http://imgur.com/a/XScLe
I load ckeditor by doing {{ form.media }} and the widget is being loaded in both cases but not working, like I said, in my PC and Server: http://imgur.com/a/rAHIj
I don't know what else to test, I don't know if in my PC and Server I've missing deps (which seems in my notebook does not)...
OS: Ubuntu 16.04
Django: 1.11.4
Django-ckeditor: 5.3.0
Any one can help me? Thanks in advance...

Does JS console has any errors? Does the static files load (or maybe they throw 404 or alike)?

Hi,
No errors on console and static files loads correctly.

Hi,
For testing, I've installed a fresh install on a VirtualBox, and is not working (as like I said, is not working on my PC and on my Production server).
I don't know if related, but outside ajax call of the form, the widget loads just fine:
Inside Ajax: https://imgur.com/a/eagCq
Outside Ajax: https://imgur.com/a/QiIEQ
Like I said in my other post, the static files are being loaded even in the ajax call, so I don't have a clue.
Now, what I don't understand why in my Notebook is working (inside or outside Ajax call), with same version of everything, which difficults me to find a solution...

Hi,
Today testing: I've harcoded adding all JS and CSS thats ckeditor loads in the form template and still does not work inside ajax:
{% load static %}

	{% csrf_token %}
	{{ services_form.as_p }}
	{{ services_form.errors.as_p }}

Does work outside Ajax...
Just to mention, I've tested with django-tinymce and works just fine inside ajax, outside ajax, etc.


OpenAI API Url field doesn't save

If I switch chats or pause the App or do anything the URL field always reverts to the default.
Also the text input field seems broken on my device, the cursor always jumps to the end making it next to impossible to edit text in the middle.
(And there isn't any error message, the conversation just shows that it's processing indefinitely, despite the request probably having failed.)
Android 13 (F-Droid version of Maid)
I'm trying to connect it to KoboldCPP's OpenAI compatible endpoint, which works for one message until I run into this issue.

Having the same issue, it doesnt appear to get a model list? Test URl is here : https://koboldai-koboldcpp-tiefighter.hf.space/v1

I believe this is fixed now so I'm closing. If not let me know and I'll reopen.

I can recreate this on current HEAD and 1.2.7 android builds. I figured saving the url field was unsupported until seeing this issue.


A loader for nested imports?

@benjamin has enabled the following experiment in Meteor:
https://www.reddit.com/r/javascript/comments/4m5f03/meteor_133_introduces_nested_import_statements_if/
The Meteor user-base is wide, so the experiment will be highly tested. It might be nice for webpack to have a nested-imports-loader so that more people can experiment with the idea.

I took a look. Currently the implementation of ES6 Modules for meteor doesn't comply to the spec is more aspects than nested imports/exports (see https://github.com/benjamn/reify/pull/24). Let's focus on that before experimenting with new features.

Thanks for sparking this discussion, @trusktr! The reify compiler, and by extension the Meteor community, will be much better off because of @sokra's feedback.

@trusktr Is this relevant still?

Solution: https://github.com/airbnb/babel-plugin-dynamic-import-node


[ES6 class] Update UsersStore to es6 class

ℹ   This branch depends on features that will be introduced with #275, thus it will fail until the respective branch is merged.

Update store to es6 class – this is part of series of PRs to update all the stores as discussed in https://github.com/dcos/dcos-ui/pull/246/files/b4b52fcdb5f899fd74f9bd68cfa3d216177fcecf#r64962494

Reviewer: @jfurrow


Expose TextPainter.computeLineMetrics on RenderParagraph

Hi there,
I have a need to access the line metrics of a rendered Text widget, and while the information is available on TextPainter, RenderParagraph doesn't expose it. Can we get a computeLineMetrics method on RenderParagraph?
Thanks!
cc @GaryQian

The main area of consideration is whether this should be exposed at the RenderParagraph level and how to handle the fact that it can be expensive due to requiring a full layout at the LibTxt level to compute.
I'll see if I can get to this after a few more pressing issues.

Hello, is this issue actionable ?


f32

Hi,
at the CppCon talk you mentioned why there is only f64, something regarding inconsistent sizes across iOS architectures (it's been a while). However that only applies to CGFloat which is an alias to either float or double, depending on whether it runs on arm64 or not. The actual values of sizeof(float) and sizeof(double) always give 4 and 8, respectively. On Java the aliases jfloat and jdouble already do the right thing.
So I'm not entirely sure I understand why there is only f64.
Regards
Miro

+1
All (C++, Java, JNI and Obj-C) support float as primitive data type and it's size is 4 bytes. And it is supported by NSNubmer class. Any reason do not include f32?
Thank you.

+1

I don't think C++ guarantees that float is always 4 bytes, so much as that it's at least 4 bytes.  Then I think the same is true for double and 8 bytes.  Unfortunately C++ doesn't supply floating-point equivalents of the fixed-width integer types (presumably because floating point accuracy is about more than just size).
I don't object to an f32 type, and I just confirmed that iOS does have consistent size of "float" on 32 vs. 64-bit platforms.  I think we just never had a case where we needed a floating point value and weren't willing to simply use an f64.

Maybe it does make more sense to then drop the bit designation and stick to float and double. All the languages in Djinni's scope have these datatypes named the same, there is quite the legacy. As long as the generated code can reliable transform between C++ float/double and the foreign language types, everything is fine. I just see our code littered with static_cast in all interface classes because the entire model works with floats and takes them in its interface and we run with -Weverything so implicit narrowing leads to an explosion of warnings.


Setting up Commitlint + Rules

Quoting Bultz from Discord who summed up this nicely. This is from the #wiki-working-group in the Battlesnake Discord

So for commits, are there a general consensus of:

type and scope = error
rest = warning

type and scope are in the conventional commits, so if they use that, doesn't really look like it's someone first time. So I would say it's fair.
Not sure if the only thing to say we enforce is the max 50 char in the subject and warning on the rest or make the subject also a warning.
it looks like we can change the warning and error messages, so we can make it more clear on the WHY, instead of "this is a warning", "this is a error"

Links:
https://github.com/conventional-changelog/commitlint

Just gonna let people know, I'm working on this one.


Mojo::Cookie::Response does not set the domain parameter according to RFC 6265

Mojolicious version: 7.61
Perl version: 5.24
Operating system: Debian Stretch / Ubuntu Xenial

Steps to reproduce the behavior

Use Mojo::UserAgent to retrieve a cookie from a site that does not set the domain parameter.
Test the domain parameter of this cookie in the UA's cookie jar.

Expected behavior
The cookie should have a host_only flag set, and have its domain set as specified in RFC 6265 Section 5.3 bullet point 6: https://tools.ietf.org/html/rfc6265#section-5.3

If the domain-attribute is non-empty: … Otherwise … Set the cookie's domain to the canonicalized request-host

Actual behavior
An extra 'origin' attribute was introduced to attempt to fix this problem which holds the original source of the cookie: https://github.com/kraih/mojo/commit/8e1895893360fcde403df19e51035f0cdb72477f
This introduces an additional bug however, in that two cookies with the same name from the same domain are considered distinct due to the unset 'domain' parameter: https://github.com/kraih/mojo/blob/master/t/mojo/cookiejar.t#L289 — RFC 6265 Section 5.3 bullet point 11 indicates these conflict and the old one should be removed from the store.

Let old-cookie be the existing cookie with the same name, domain, and path as the newly created cookie … Remove the old-cookie from the cookie store

The result of this is that cookies can be submitted to sites regardless of them having a blank domain set due to the non-standard origin attribute. Without knowledge of this attribute cookies cannot be serialized or copied correctly.
This tiny mojo lite app exhibits the behaviour, the cookie stored in the jar should include the domain name of its source.
use Mojolicious::Lite;
use Mojo::UserAgent;
use Data::Dump 'pp';

get '/set' => sub {
	my $c = shift;
	$c->cookie(test => 'ing');
	return $c->rendered(200);
};

get '/say' => sub {
	my $c = shift;
	return $c->render(
		text => "Say handler got cookies: " . join ', ', map { pp($_) } $c->req->cookies->@*
	);
};

my $ua   = Mojo::UserAgent->new;
# This request sets a testing cookie without a domain parameter
# according to RFC 6265 Section 5.3 bullet 6 this should be set to the request-host
$ua->get("/set");

# Printing the cookie's parameters show no domain. Serializing or copying this cookie without
# copying the instance or the 'origin' parameter results in inconsistent behaviour below.
map { say "Cookie '" . $_->name . "' has domain '" . $_->domain . "'" } $ua->cookie_jar->all->@*;

# This request will send the acquired cookie despite it appearing not to have a domain above
# as it silently promotes 'origin' to 'domain' upon making the request
#
# This behaviour was introduced to fix this same problem, but does so incorrectly
# https://github.com/kraih/mojo/commit/8e1895893360fcde403df19e51035f0cdb72477f
say $ua->get("/say")->res->body;

[Wed Jan 31 15:31:52 2018] [debug] GET "/set"
[Wed Jan 31 15:31:52 2018] [debug] Routing to a callback
[Wed Jan 31 15:31:52 2018] [debug] 200 OK (0.000491s, 2036.660/s)
Use of uninitialized value in concatenation (.) or string at test.pl line 27.
Cookie 'test' has domain ''
[Wed Jan 31 15:31:52 2018] [debug] GET "/say"
[Wed Jan 31 15:31:52 2018] [debug] Routing to a callback
[Wed Jan 31 15:31:52 2018] [debug] 200 OK (0.000557s, 1795.332/s)
Say handler got cookies: bless({ name => "test", value => "ing" }, "Mojo::Cookie::Request")

Since there's a work in progress pull request open now i'll close this issue.


The command line keys from akv-keys doesn't work

Hi @0x3N3JVhPUV, would it be possible to have a detailed description of your issue here? thanks


Teams - No sound in call

Describe the bug
No sound in MS Teams call
Expected behavior
Sound is available in calls
Desktop:

OS: Parrot Linux 4.8 (Debian 11)
Ferdi Version: 5.4.3 / 5.4.4-beta.3
Server Used: https://api.getferdi.com

Additional context
Using default UA in Ferdi. Sound works with same UA in Franz
"use strict";

module.exports = Franz => class MicrosoftTeams extends Franz {
  overrideUserAgent() {
    return window.navigator.userAgent.replace(/(Franz|Electron)([^\s]+\s)/g, '').replace(/(Chrome\/)([^ ]*)/g, '$163.0.3239.84');
  }
};

Quite a lot of errors in service console log for MS Teams in and out of call: console.log (hope it's readable)

Teams, in general, seems to be broken in Ferdi even though it works through Franz. The devs don't have Teams credentials to test with so that makes it difficult for them to troubleshoot.  :(

I use teams quite a lot and so far I have only two problems - this and that screen sharing doesn't work. Sound problem is Ferdi specific, screen sharing doesn't work in Franz either

I have found solution for screen sharing, have a PR for this. see https://github.com/getferdi/recipes/pull/116

@all-contributors please add gautamsi for code

Is this still the case in 5.5.0-gm.2?

Yeah, happening the same as of 5.5.0

this issue still is actual, there is no sound in any current stable/nightly release

i am going to guess that this is not a priority and nobody is fixing it?

I am using it for long, works for Teams, see the audio device. once problem I faced is that no notification for call ringer and no sound for that.

every time i try, it's the same. call accept works, but no sound comes out or goes in (no speakers/mic). sound meter just stays at 0 and can't be changed to anything else

This issue is still ongoing.

This issue is still ongoing.

I am using teams everyday for last 8-9 months now, have no problem.
only sound you miss is the ringer, otherwise if you are able to call it works and have both way sound/video/sharing working

I am using teams everyday for last 8-9 months now, have no problem.
only sound you miss is the ringer, otherwise if you are able to call it works and have both way sound/video/sharing working

I am still encountering this issue with the latest Frerdi nightly. Seems to have shown up in the past 2-3 months.


[hotfix][state] Serialize KeyGroupsStateHandle in shared Incremental …

What is the purpose of the change
JM can serialize only certain types of state handles. Currently,
this doesn't include KeyGroupsStateHandle which is addressed
by this PR.
The change is motivated by PoCs of FLIP-151 and FLIP-158 but is
general enough to be applied before actual implementations.
Verifying this change
This change is a trivial rework without any test coverage.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): no
The public API, i.e., is any changed class annotated with @Public(Evolving): no
The serializers: no
The runtime per-record code paths (performance sensitive): no
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: yes
The S3 file system connector: no

Documentation

Does this pull request introduce a new feature? no
If yes, how is the feature documented? no

Build failure is unrealted, private build passed, merging.


Yandex provider update

Small enchancement of the yandex geo provider.

Thanks, but I'm closing this for the following reasons:

https is already a default scheme 7caa79f
apikey bug has been fixed in 6fb6171
passing arbitrary params is discouraged as per CONTRIBUTING.md

I've added kind param to the reverse method in 3434648.
I guess the other useful ones are (according to the yandex maps API doc):

ll, spn,  bbox for setting a bounding box (see also #261)
results, skip for results pagination.

PRs are welcome!


Lspsaga diagnostic_jump_next doesn't show current cursor diagnostic; instead it jumps to the next diagnostic

Describe the bug
https://github.com/nvimdev/lspsaga.nvim/assets/57322459/334a773e-1e76-45a2-a155-8e0e88f2e370
According to the doc:

Invoke :Lspsaga diagnostic_jump_next and :Lspsaga diagnostic_jump_prev to jump around diagnostics. When the current cursor position has a diagnostic available, the commands will show the diagnostic in a nice float.

Steps to reproduce
Test with below:
unction greet() {
  console.log("Hello World!");
}

greet();

Cursor is at unction
Run Lspsaga diagnostic_jump_next

Expect to show Unknown keyword or identifier. Did you mean 'function'?
Instead, it jumps to the next diagnostic and gives ';' expected. 1:17:1 tsserver 1005
Expected behavior
When the current cursor position has a diagnostic available, the commands will show the diagnostic in a nice float.
Neovim version (nvim -v)
v0.10.0
lspsaga commit
6f920cf
Terminal name/version
kitty 0.35.1

@glepnir any estimate on when this will be fixed?
I want to be able to open that menu where my cursor is.
Alternatively, have another way to show this menu for the current cursor position (with a command for it)


[Builtins] Specialize '[Integer]' in 'geq'

This specializes geqStep a bit further, so that handling of [Integer] and [Data] doesn't require any recursive calls and can get inlined fully. I doubt it's going to make a difference, but I thought it'd be easy enough to check, so why not.

/benchmark nofib

/benchmark nofib

/benchmark nofib

Not worth it.


Translation does not appear to be idiomatic Julia

I understand that the translation syntax mimics that of OpenSCAD, but it doesn't make any sense to me from the perspective of a (beginner) Julia programmer. How can you put two functions next to each other and not have an infix operator or have them wrapped in a function call?

You can use * as an infix operator if you chose to be explicit. The examples use the implicit idioms handled by the parser, the same thing that turns 2y into 2*y.


View port scroll issues

Hi Tomas,
Scrolling in a text area with varying text sizes affects the size of the scrolling step, and causes a few things:
If caret is at a position in BIG text, scroll bars do not go down with mouse scrolls. It works with moving the carrot position by arrow keys. Alternatively, if I clock the scroll bar (rectangle handle grab thingy--what you call it?), it goes to the end of text as expected.
Another issue I noticed is that if the carrot is in a position, and I scroll down with mouse, if it works and reach the end of the text (now carrot position is not shown in the view port, in this case if I keep scrolling down, the view port will jump back up to a place where the carrot position is shown in the view port.
I'll do more testing to give better report.
but general, things work MUCH better, selecting and highlighting text is much faster now, I believe it is now instantaneous.
best,
Maher

Hi Tomas, were you able to reproduce this?

I am having a similar problem (involving scrolling) using CodeArea.  When I have a line that is longer than the width of the control, the horizontal scroll bar appears at the bottom of the control as it should, but will not allow me to scroll.  Furthermore, as I continue to type past the right end of the control, the view is not scrolled with the cursor, and the horizontal scroll bar stays in the far left position.
Note: the vertical scrollbar works as expected.

Seems like two separate issues. Hopefully I will be able to get to it over the weekend.

The horizontal scrolling issue (reported by @ejames2) is now fixed in the latest SNAPSHOT version.

Tomas,
I noticed another thing with vertical scrolling. In the video below, making a selection and then scrolling sometimes deselects a selected range.
Video 1:
View port jumping pack to the carrot position after the scroll bar (using mouse) reaches upper limit.
When I do this using a scroll bar, it stays in place. But the when the mouse goes over the view port, it jumps back again.

Video 2:
In this video, the selected text ranges get deselected after I scroll to the upper limit. Also, sometimes, when the mouse is not over the selected range, it gets deselected (after the scroll). This happens at the end of the video:

I am not I am capturing the pattern here to reproduce the scroll (and possible related deselection). I will try to look for more reproducible steps on my end.

Thank you for the videos, it is now clearer what the problem is.

0.6.1 has improved scrollbar experience. Let me know if you experience any further weirdness.

Hi Tomas, I ran into three new issues.
Issue 1--Can't scroll to select text beyond what is shown in the view port:

Issue 2: Flickering text when adding, deleting, or inserting new lines. For some reason, the flickering s not being captured by the video...It happens when you add a new text, remove, or change existing text.
Issue 3: Layout. Some lines seem to overlay.. Both in this video

I am running Java U40. b23.
Are you able to reproduce this?

Thanks for reporting back.

It is not clear to me what is not working. Are you trying to select some text and keep dragging the mouse down while the mouse button is still pressed?
I can reproduce this. Can you file it as a separate issue, since it is not related to this one?
I haven't experienced this myself, but it has just been reported by someone else in #114. Can you add your video there?

For number 1, yes. I select text and keep dragging the mouse down to extend my selection. I just another try and noticed that selection (add more to text) stops working once the mouse cursor is outside of the view port.
I will post the other issue and video accordingly.

OK, I see what you are expecting. That never was a feature in RichTextFX. It is reasonable to expect, because some editors support that. You can file a new feature request.
You may observe that it "somehow" works, when you come close enough to the edge of the text area, but don't cross it. This is not a feature, but a side effect of the following: the caret is slightly taller than the line, so it overlaps by approx. 1 pixel to the next and previous line. When the text area is automatically scrolled (e.g. down) to show the whole caret, it also shows a 1 pixel stripe from the next line. If you move the mouse over that one pixel stripe, the caret is repositioned to the next line, and area is scrolled to show the caret, which again shown a 1 pixel stripe of the following line, and so on. Not a feature, just a consequence of the caret being a little taller.

What does work reliably for selecting text beyond the viewport is: start the selection, keep the mouse button pressed, and scroll down/up with the mouse wheel.

Yes. That explains it. Because it seemed like it was sort of supported.
I'll file a separate enhancement issue.
On Feb 23, 2015 9:43 AM, "Tomas Mikula"<EMAIL_ADDRESS>wrote:

What does work reliably for selecting text beyond the viewport is: start
the selection, keep the mouse button pressed, and scroll down/up with the
mouse wheel.
—
Reply to this email directly or view it on GitHub
https://github.com/TomasMikula/RichTextFX/issues/110#issuecomment-75592392
.


Error id field is read only! even though i am not setting it

I have Two Rows VSRow and BSSRow
VSId in BSSRow is Foreign key refers to ID column of VSRow.
public sealed class BSSRow : Row, IIdRow, INameRow
    {

        [DisplayName("Id"), Identity]
        public Int32? Id
        {
            get { return Fields.Id[this]; }
            set { Fields.Id[this] = null; }
        }

        public string? BSSName
        {
            get { return Fields.BSSName[this]; }
            set { Fields.BSSName[this] = null; }
        }

        [DisplayName("Vs"), NotNull, ForeignKey(typeof(VSRow), "Id"), LeftJoin("v")]
        [LookupEditor(typeof(VSRow), InplaceAdd = true), TextualField("VSName")]
        public Int32? VSId
        {
            get { return Fields.Id[this]; }
            set { Fields.Id[this] = value; }
        }

        [Origin("v"), DisplayName("VSName"), QuickSearch]

        public String VSName
        {
            get { return Fields.VSName[this]; }
            set { Fields.VSName[this] = value; }
        }
	}

Below Method throws error saying id field is read only! , i am not setting id feils of BSSRow i am only settigg Foreign Key Column VSId in BSS ROw
	 private int CreateVSRecord(UnitOfWork uow, MRootItem rootitem)
        {
            var VInfo = new VSRow
            {
                VNumber = rootitem.AVN,
                VName = rootitem.VN,
            };

            new VSRepository().Create(uow, new SaveRequest<VSRow>
            {
                Entity = VInfo
            });

            foreach (var bl in rootitem.BLLS)
            {

                var BSSinfo = new BSSRow
                {
                    BSSName= bol.name
                    VSId = VInfo.Id,

                };

                new BSSRowRepository().Create(uow, new SaveRequest<BSSRow>
                {
                    Entity = BSSinfo
                });
            }

            uow.OnCommit += () =>
            {

            };

            uow.OnRollback += () =>
            {

            };

            return (int)VInfo.Id;
        }

I tried debugging the save request passed to create method of repository, something is setting id column of BSSRow even though i am not assigning anything to it.
I also tried to add below override in BSSRepository, But belwo statment sets both 	Id & VSId to null.
I feel somewhere AutoSync happening b/w both values, i.e value of one reflecting in both VSId &Id of BSSRow
public SaveResponse Create(IUnitOfWork uow, SaveRequest<MyRow> request)
        {
            if (request.Entity.Id != null) request.Entity.Id = null;
            return new MySaveHandler().Process(uow, request, SaveRequestType.Create);
        }

You have set Identity attribute that marks field as identity field. If you want Id as normal field, remove identity attribute

@Estrusco  ID is identity feild, but not VSId Feild.
Issue is not ID is set, Why VSId and Id are autosynched.
Thats if i write any values to VSId, same value also set in ID field in BSSRow.


qt5 bottle

Hello,
Could you add some bottle the oldest osx for the bottle (and not forget the qt update) :

high sierra
sierra
el capitan

Because the compilation time are just insane !
By advance,
Thanks

I'm pretty sure that's not gonna happen, as the earliest OS available in CI is now Mojave.

Yes, sorry. Homebrew's build and testing systems are only running Mojave, Catalina, and Big Sur, so I'm afraid those bottles would be impossible.

Ok could you redirect me for a doc which explains how to build the bottle via GitHub ?
Regards,

You're probably looking for GitHub Actions, about which I know next to nothing.
Even then, GitHub only offers Actions for Catalina at the earliest. Homebrew uses its own CI hardware, so is able to provision back to Mojave.

You can have a look at this: https://brew.sh/2020/12/01/homebrew-2.6.0/
However, as @gromgit points out, they only document support for Catalina and Big Sur. However, digging into their repo suggests that they might have nodes that run High Sierra and Mojave. This is not documented, so may not work.

Thank you for all :)


(fix) - typos in docs

Please describe the changes this PR makes and why it should be merged:
This PR fixes a few small typos in the docs files.
Status

[x] Code changes have been tested against prettier, or there are no code changes
[x] I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

[ ] This PR changes the codebase

[ ] This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
[ ] This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)

[X] This PR only includes non-code changes, like changes to documentation, README, etc.

LGTM, thanks!

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 59.337%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
1408

Relevant Lines:
2471

💛  - Coveralls


TAXIICollectionSource should support 2.1 filters

_parse_taxii_filters() doesn't support the TAXII 2.1-specific filters of limit, next, or spec_version.
See also: https://github.com/oasis-open/cti-taxii-client/issues/100.

@zrush-mitre - is this something we need before we release python-stix2 3.0? (for 2.1)

No rush to get this out with major release. I'll plan on working on this next week and hopefully submitting a PR.

So a little update for this issue:
The 'limit' filter is not difficult to implement on TAXIICollectionSource, since there's only one or two functions that will actually go to call the TAXII server and they already have a paging functionality included, so replacing that with an argument for the 'limit' filter is pretty easy and immediately works well.
The problem comes from the 'next' filter: since 'next' only ever gets used after subsequent 'limit' responses, it doesn't really make sense for a user to explicitly give this value in the request, since paged requests will just return all of the objects collected with multiple requests to the server. However, a user may not actually want to receive all the returned objects with the 'limit' filter in the first place, and instead, the TAXIICollectionSource would need to either hold onto paged objects and only give them to the user when requested, or the functions would need to be refactored to not make all paged requests immediately.
I'm not sure what is the best way forward here, so this requires further investigation.


Polly response never sent to handset

I am logging the contents of audio_chunk_queue_out, and it is empty before the polly request and full after the request, but it is never emptied. This makes me think that it is not being sent to the handset correctly. I am not hearing it being played back. And the welcome message is occasionally cut off.

Do you have logs and versions of your VoIP adapter?
Maybe related? https://github.com/tcz/rotary-gpt/issues/1
Please check the steps suggested there and do the debugging of the device, perhaps something will come up. I'm here to help but I need a bit more info.

Log included below. I'm using the same device as #2 . Please help me understand the code here. Once the chunk is sent to audio_chunk_queue_out, where in the code is the chunk received/sent to RTP? It seems like you are using this Queue as an asynchronous channel of messages which is being collected elsewhere, but I just can't find where.
Log:
2023-09-19 14:46:14 MainThread [DEBUG]: Registered function accent__change_accent
2023-09-19 14:46:14 MainThread [DEBUG]: Registered function weather__get_weather_today
2023-09-19 14:46:14 SIP server [INFO]: SIP server started on <IP_ADDRESS>:5060
2023-09-19 14:46:25 SIP server [DEBUG]: Creating SIP request to address: ('<IP_ADDRESS>', 5060)
2023-09-19 14:46:25 SIP server [INFO]: Incoming SIP request b'INVITE'
2023-09-19 14:46:25 SIP server [DEBUG]: b'INVITE sip:<IP_ADDRESS>:5060 SIP/2.0\r\nVia: SIP/2.0/UDP <IP_ADDRESS>:5060;branch=z9hG4bK1513924939;rport\r\nFrom: <sip:IPCall@<IP_ADDRESS>:5060>;tag=1571951054\r\nTo: <sip:<IP_ADDRESS>:5060>\r\nCall-ID<EMAIL_ADDRESS>60 INVITE\r\nContact: <sip:IPCall@<IP_ADDRESS>:5060>\r\nMax-Forwards: 70\r\nUser-Agent: Grandstream HT801 <IP_ADDRESS>\r\nSupported: replaces, path, timer, outbound, eventlist\r\nAllow: INVITE, ACK, OPTIONS, CANCEL, BYE, SUBSCRIBE, NOTIFY, INFO, REFER, UPDATE\r\nContent-Type: application/sdp\r\nAccept: application/sdp, application/dtmf-relay\r\nContent-Length: 480\r\n\r\nv=0\r\no=IPCall 8000 8000 IN IP4 <IP_ADDRESS>\r\ns=SIP Call\r\nc=IN IP4 <IP_ADDRESS>\r\nt=0 0\r\nm=audio 5004 RTP/AVP 0 8 4 18 2 97 123 9 101\r\na=sendrecv\r\na=rtpmap:0 PCMU/8000\r\na=ptime:50\r\na=rtpmap:8 PCMA/8000\r\na=rtpmap:4 G723/8000\r\na=rtpmap:18 G729/8000\r\na=fmtp:18 annexb=no\r\na=rtpmap:2 G726-32/8000\r\na=rtpmap:97 iLBC/8000\r\na=fmtp:97 mode=20\r\na=rtpmap:123 opus/48000/2\r\na=fmtp:123 maxplaybackrate=16000\r\na=rtpmap:9 G722/8000\r\na=rtpmap:101 telephone-event/8000\r\na=fmtp:101 0-16,32-36,54\r\n'
2023-09-19 14:46:25 SIP server [INFO]: Response body before mod: None
2023-09-19 14:46:25 SIP server [INFO]: SIP response sent 200
2023-09-19 14:46:25 SIP server [DEBUG]: b'SIP/2.0 200 OK\r\nVia: SIP/2.0/UDP <IP_ADDRESS>:5060;branch=z9hG4bK1513924939;rport\r\nTo: <sip:<IP_ADDRESS>:5060>\r\nFrom: <sip:IPCall@<IP_ADDRESS>:5060>;tag=1571951054\r\nContact: <sip:<IP_ADDRESS>:5060>\r\nCall-ID<EMAIL_ADDRESS>60 INVITE\r\nContent-type: application/sdp\r\nContent-Length: 153\r\n\r\nv=0\no=RotaryGPT 1 1 IN IP4 <IP_ADDRESS>\ns=SIP Call\nc=IN IP4 <IP_ADDRESS>\r\nt=0 0\r\nm=audio 5004 RTP/AVP 0\r\na=sendrecv\r\na=rtpmap:0 PCMU/8000\r\na=ptime:20\r\n'
2023-09-19 14:46:25 SIP server [INFO]: Response body after mod: v=0
o=RotaryGPT 1 1 IN IP4 <IP_ADDRESS>
s=SIP Call
c=IN IP4 <IP_ADDRESS>
t=0 0
m=audio 5004 RTP/AVP 0
a=sendrecv
a=rtpmap:0 PCMU/8000
a=ptime:20

2023-09-19 14:46:25 SIP server [INFO]: Port: 5004
2023-09-19 14:46:25 SIP server [DEBUG]: Calling incoming call callbacks with client RTP address <IP_ADDRESS>:5004
2023-09-19 14:46:25 SIP server [INFO]: RTP sender: <IP_ADDRESS>:5004
2023-09-19 14:46:25 RTP sender [INFO]: RTP sender started with peer <IP_ADDRESS>:5004
2023-09-19 14:46:25 Conversation [INFO]: Conversation started
2023-09-19 14:46:25 Conversation [DEBUG]: Sending greeting
2023-09-19 14:46:25 SIP server [DEBUG]: Finished incoming call callbacks
2023-09-19 14:46:25 RTP receiver [INFO]: RTP receiver started on <IP_ADDRESS>:5004
2023-09-19 14:46:25 SIP server [DEBUG]: Creating SIP request to address: ('<IP_ADDRESS>', 5060)
2023-09-19 14:46:25 SIP server [INFO]: Incoming SIP request b'ACK'
2023-09-19 14:46:25 SIP server [DEBUG]: b'ACK sip:<IP_ADDRESS>:5060 SIP/2.0\r\nVia: SIP/2.0/UDP <IP_ADDRESS>:5060;branch=z9hG4bK91898588;rport\r\nFrom: <sip:IPCall@<IP_ADDRESS>:5060>;tag=1571951054\r\nTo: <sip:<IP_ADDRESS>:5060>\r\nCall-ID<EMAIL_ADDRESS>60 ACK\r\nContact: <sip:<IP_ADDRESS>:5060;ob>\r\nMax-Forwards: 70\r\nSupported: replaces, path, timer, outbound, eventlist\r\nUser-Agent: Grandstream HT801 <IP_ADDRESS>\r\nAllow: INVITE, ACK, OPTIONS, CANCEL, BYE, SUBSCRIBE, NOTIFY, INFO, REFER, UPDATE\r\nContent-Length: 0\r\n\r\n'
2023-09-19 14:46:25 Conversation [DEBUG]: Starting Whisper request
2023-09-19 14:46:25 RTP sender [DEBUG]: New talkspurt, marker bit set
2023-09-19 14:46:26 Conversation [DEBUG]: Receiving audio
2023-09-19 14:46:30 Conversation [DEBUG]: Silence detected
2023-09-19 14:46:30 Conversation [DEBUG]: Sending Whisper request
2023-09-19 14:46:31 Conversation [DEBUG]: Whisper returned
2023-09-19 14:46:31 Conversation [INFO]: User message: ←[31;1mHello, how's the weather today?←[0m
2023-09-19 14:46:31 Conversation [DEBUG]: Sending GPT request
2023-09-19 14:46:33 Conversation [INFO]: Function call: {'role': 'assistant', 'content': None, 'function_call': {'name': 'weather__get_weather_today', 'arguments': '{\n  "location": "New York",\n  "day": "2023-09-19"\n}'}}
2023-09-19 14:46:34 Wait speaker [INFO]: Waited longer than 4.0s to respond, sending wait a moment
2023-09-19 14:46:34 RTP sender [DEBUG]: New talkspurt, marker bit set
2023-09-19 14:46:34 Conversation [INFO]: Function response: ←[32;1mWeather forecast for 2023-09-19 in New York, US

Prediction: Mainly clear, partly cloudy, and overcast
Max temperature: 21.5°C
Min temperature: 13.8°C
Precipitation probability: 100%←[0m
2023-09-19 14:46:34 Conversation [DEBUG]: Sending GPT request
2023-09-19 14:46:37 Conversation [INFO]: Agent message: ←[33;1mThe weather today in New York is mainly clear, partly cloudy, and overcast with a maximum temperature of 21.5°C and a minimum temperature of 13.8°C. There is a 100% chance of precipitation.←[0m
2023-09-19 14:46:37 Conversation [DEBUG]: Sending Polly request
b'HTTP/1.1 200 OK\r\nx-amzn-RequestId: ABC123-...\r\nx-amzn-RequestCharacters: 189\r\nContent-Type: audio/pcm\r\nTransfer-Encoding: chunked\r\nDate: Tue, 19 Sep 2023 18:46:38 GMT\r\nConnection: close'
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 RTP sender [DEBUG]: New talkspurt, marker bit set
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:39 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:39 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:39 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:39 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:39 Conversation [DEBUG]: Polly fully returned, waiting for audio out queue to be consumed
2023-09-19 14:46:54 Conversation [DEBUG]: Audio out queue empty
2023-09-19 14:46:58 Conversation [DEBUG]: Starting Whisper request
2023-09-19 14:47:00 Conversation [DEBUG]: Receiving audio

Log included below. I'm using the same device as #2 . Please help me understand the code here. Once the chunk is sent to audio_chunk_queue_out, where in the code is the chunk received/sent to RTP? It seems like you are using this Queue as an asynchronous channel of messages which is being collected elsewhere, but I just can't find where.
Log:
2023-09-19 14:46:14 MainThread [DEBUG]: Registered function accent__change_accent
2023-09-19 14:46:14 MainThread [DEBUG]: Registered function weather__get_weather_today
2023-09-19 14:46:14 SIP server [INFO]: SIP server started on <IP_ADDRESS>:5060
2023-09-19 14:46:25 SIP server [DEBUG]: Creating SIP request to address: ('<IP_ADDRESS>', 5060)
2023-09-19 14:46:25 SIP server [INFO]: Incoming SIP request b'INVITE'
2023-09-19 14:46:25 SIP server [DEBUG]: b'INVITE sip:<IP_ADDRESS>:5060 SIP/2.0\r\nVia: SIP/2.0/UDP <IP_ADDRESS>:5060;branch=z9hG4bK1513924939;rport\r\nFrom: <sip:IPCall@<IP_ADDRESS>:5060>;tag=1571951054\r\nTo: <sip:<IP_ADDRESS>:5060>\r\nCall-ID<EMAIL_ADDRESS>60 INVITE\r\nContact: <sip:IPCall@<IP_ADDRESS>:5060>\r\nMax-Forwards: 70\r\nUser-Agent: Grandstream HT801 <IP_ADDRESS>\r\nSupported: replaces, path, timer, outbound, eventlist\r\nAllow: INVITE, ACK, OPTIONS, CANCEL, BYE, SUBSCRIBE, NOTIFY, INFO, REFER, UPDATE\r\nContent-Type: application/sdp\r\nAccept: application/sdp, application/dtmf-relay\r\nContent-Length: 480\r\n\r\nv=0\r\no=IPCall 8000 8000 IN IP4 <IP_ADDRESS>\r\ns=SIP Call\r\nc=IN IP4 <IP_ADDRESS>\r\nt=0 0\r\nm=audio 5004 RTP/AVP 0 8 4 18 2 97 123 9 101\r\na=sendrecv\r\na=rtpmap:0 PCMU/8000\r\na=ptime:50\r\na=rtpmap:8 PCMA/8000\r\na=rtpmap:4 G723/8000\r\na=rtpmap:18 G729/8000\r\na=fmtp:18 annexb=no\r\na=rtpmap:2 G726-32/8000\r\na=rtpmap:97 iLBC/8000\r\na=fmtp:97 mode=20\r\na=rtpmap:123 opus/48000/2\r\na=fmtp:123 maxplaybackrate=16000\r\na=rtpmap:9 G722/8000\r\na=rtpmap:101 telephone-event/8000\r\na=fmtp:101 0-16,32-36,54\r\n'
2023-09-19 14:46:25 SIP server [INFO]: Response body before mod: None
2023-09-19 14:46:25 SIP server [INFO]: SIP response sent 200
2023-09-19 14:46:25 SIP server [DEBUG]: b'SIP/2.0 200 OK\r\nVia: SIP/2.0/UDP <IP_ADDRESS>:5060;branch=z9hG4bK1513924939;rport\r\nTo: <sip:<IP_ADDRESS>:5060>\r\nFrom: <sip:IPCall@<IP_ADDRESS>:5060>;tag=1571951054\r\nContact: <sip:<IP_ADDRESS>:5060>\r\nCall-ID<EMAIL_ADDRESS>60 INVITE\r\nContent-type: application/sdp\r\nContent-Length: 153\r\n\r\nv=0\no=RotaryGPT 1 1 IN IP4 <IP_ADDRESS>\ns=SIP Call\nc=IN IP4 <IP_ADDRESS>\r\nt=0 0\r\nm=audio 5004 RTP/AVP 0\r\na=sendrecv\r\na=rtpmap:0 PCMU/8000\r\na=ptime:20\r\n'
2023-09-19 14:46:25 SIP server [INFO]: Response body after mod: v=0
o=RotaryGPT 1 1 IN IP4 <IP_ADDRESS>
s=SIP Call
c=IN IP4 <IP_ADDRESS>
t=0 0
m=audio 5004 RTP/AVP 0
a=sendrecv
a=rtpmap:0 PCMU/8000
a=ptime:20

2023-09-19 14:46:25 SIP server [INFO]: Port: 5004
2023-09-19 14:46:25 SIP server [DEBUG]: Calling incoming call callbacks with client RTP address <IP_ADDRESS>:5004
2023-09-19 14:46:25 SIP server [INFO]: RTP sender: <IP_ADDRESS>:5004
2023-09-19 14:46:25 RTP sender [INFO]: RTP sender started with peer <IP_ADDRESS>:5004
2023-09-19 14:46:25 Conversation [INFO]: Conversation started
2023-09-19 14:46:25 Conversation [DEBUG]: Sending greeting
2023-09-19 14:46:25 SIP server [DEBUG]: Finished incoming call callbacks
2023-09-19 14:46:25 RTP receiver [INFO]: RTP receiver started on <IP_ADDRESS>:5004
2023-09-19 14:46:25 SIP server [DEBUG]: Creating SIP request to address: ('<IP_ADDRESS>', 5060)
2023-09-19 14:46:25 SIP server [INFO]: Incoming SIP request b'ACK'
2023-09-19 14:46:25 SIP server [DEBUG]: b'ACK sip:<IP_ADDRESS>:5060 SIP/2.0\r\nVia: SIP/2.0/UDP <IP_ADDRESS>:5060;branch=z9hG4bK91898588;rport\r\nFrom: <sip:IPCall@<IP_ADDRESS>:5060>;tag=1571951054\r\nTo: <sip:<IP_ADDRESS>:5060>\r\nCall-ID<EMAIL_ADDRESS>60 ACK\r\nContact: <sip:<IP_ADDRESS>:5060;ob>\r\nMax-Forwards: 70\r\nSupported: replaces, path, timer, outbound, eventlist\r\nUser-Agent: Grandstream HT801 <IP_ADDRESS>\r\nAllow: INVITE, ACK, OPTIONS, CANCEL, BYE, SUBSCRIBE, NOTIFY, INFO, REFER, UPDATE\r\nContent-Length: 0\r\n\r\n'
2023-09-19 14:46:25 Conversation [DEBUG]: Starting Whisper request
2023-09-19 14:46:25 RTP sender [DEBUG]: New talkspurt, marker bit set
2023-09-19 14:46:26 Conversation [DEBUG]: Receiving audio
2023-09-19 14:46:30 Conversation [DEBUG]: Silence detected
2023-09-19 14:46:30 Conversation [DEBUG]: Sending Whisper request
2023-09-19 14:46:31 Conversation [DEBUG]: Whisper returned
2023-09-19 14:46:31 Conversation [INFO]: User message: ←[31;1mHello, how's the weather today?←[0m
2023-09-19 14:46:31 Conversation [DEBUG]: Sending GPT request
2023-09-19 14:46:33 Conversation [INFO]: Function call: {'role': 'assistant', 'content': None, 'function_call': {'name': 'weather__get_weather_today', 'arguments': '{\n  "location": "New York",\n  "day": "2023-09-19"\n}'}}
2023-09-19 14:46:34 Wait speaker [INFO]: Waited longer than 4.0s to respond, sending wait a moment
2023-09-19 14:46:34 RTP sender [DEBUG]: New talkspurt, marker bit set
2023-09-19 14:46:34 Conversation [INFO]: Function response: ←[32;1mWeather forecast for 2023-09-19 in New York, US

Prediction: Mainly clear, partly cloudy, and overcast
Max temperature: 21.5°C
Min temperature: 13.8°C
Precipitation probability: 100%←[0m
2023-09-19 14:46:34 Conversation [DEBUG]: Sending GPT request
2023-09-19 14:46:37 Conversation [INFO]: Agent message: ←[33;1mThe weather today in New York is mainly clear, partly cloudy, and overcast with a maximum temperature of 21.5°C and a minimum temperature of 13.8°C. There is a 100% chance of precipitation.←[0m
2023-09-19 14:46:37 Conversation [DEBUG]: Sending Polly request
b'HTTP/1.1 200 OK\r\nx-amzn-RequestId: ABC123-...\r\nx-amzn-RequestCharacters: 189\r\nContent-Type: audio/pcm\r\nTransfer-Encoding: chunked\r\nDate: Tue, 19 Sep 2023 18:46:38 GMT\r\nConnection: close'
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 RTP sender [DEBUG]: New talkspurt, marker bit set
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:38 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:39 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:39 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:39 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:39 Conversation [DEBUG]: Polly chunk arrived, sending to RTP
2023-09-19 14:46:39 Conversation [DEBUG]: Polly fully returned, waiting for audio out queue to be consumed
2023-09-19 14:46:54 Conversation [DEBUG]: Audio out queue empty
2023-09-19 14:46:58 Conversation [DEBUG]: Starting Whisper request
2023-09-19 14:47:00 Conversation [DEBUG]: Receiving audio

Hello,
Regarding the queues, it's being consumed here:
https://github.com/tcz/rotary-gpt/blob/9a0f18c3708ebdb727bbc6e864e3f160f15f93e3/rotarygpt/rtp.py#L84
Have you been able to debug HT801 as suggested in #1? I'd love to see the logs. Unfortunately it seems that my HT801 is an older hardware version and it works just fine. Apparently with Cisco ATAs also works, as per #2. I looked at buying a newer HT801 but I can only find HT802 on Amazon - might be worth it nevertheless, but it's a bit pricier just for debugging.

Can you test if the latest version works better?
See https://github.com/tcz/rotary-gpt/issues/2#issuecomment-1762329789


Add PHSZ - Schwyz University of Teacher Education

Please add Schwyz University of Teacher Education
https://www.phsz.ch/
a URL of a page on the official website where a long-term (>1 year) IT related course is offered by the university:
Bachelor: https://www.phsz.ch/ausbildung/bachelorstudium/studiengaenge-und-studienformate
Master: https://www.phsz.ch/ausbildung/masterstudium
a URL of a page or some other proof (.pdf or a screenshot are OK) showing that the university recognizes the domain which you are submitting as an official email domain for the enrolled students:
https://www.phsz.ch/person/raffael-meier

@raffaelmeier First stage of verification passed, official domain is phsz.ch as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@raffaelmeier Thank you for your patience while waiting for a review and processing your request. Pull request merged.


OCM-6387 | ci: Fix HCP jobs

What this PR does / why we need it:
This fix a small issue with HCP CI jobs
Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story (OCM-xxxx):
https://issues.redhat.com/browse/OCM-6387
Change type

[ ] New feature
[ ] Bug fix
[ ] Build
[x] CI
[ ] Documentation
[ ] Performance
[ ] Refactor
[ ] Style
[ ] Unit tests
[ ] Subsystem tests

Checklist

[ ] Subject and description added to both, commit and PR.
[ ] Relevant issues have been referenced.

/lgtm

/approve


Come with me, and you'll be...

... in a worllllld of pure plugins!
To test:

Clone this branch or whatever
Go to plugins folder, create redditbuilds
Add an index.js with this and npm init the folder
Go to /config, duplicate default_settings.json into settings.json
Add a plugin "redditbuilds": {} inside "plugins"
RUNNNNNN IT!

I don't understand why you need to create a folder inside plugins/

Because a plugin is a module. That way, plugins can install any other modules they want. Lastly, it makes it extremely easy to npm publish with no issues.

Any file that does module.exports = {} is a module. But okay fine.

@rom1504 I think it would work without the folder, however if I were teaching someone about this, I would teach them to create a folder since it's best practice and since they'll hopefully be publishing it.

Yeah yeah sure, I agree.

@demipixel Also, it makes plugins/ cleaner if people want to split their plugin into multiple files.

Alright, it works fine, nice.


[KYUUBI #902] Wrong operation statistics on kyuubi page

Why are the changes needed?

When serveral sql statements finished, wrong statistics of operations are displayed on kyuubi page.
1 session(s) are online, running 5 operations

ROOT CAUSE
When run each statement, will run getTypeInfo internally.
SparkSQL Engine Log
2021-08-08 14:31:40.086 INFO log.OperationLog: Creating operation log file /tmp/hadoop-08fa33a4-0aee-4556-865e-bb9866f3fb3a/operation_logs/b9ba0414-4960-4e3a-b31c-717b9dcdd1e1/84e35aea-f84e-4da1-a827-97e818062d78
2021-08-08 14:31:40.087 INFO operation.GetTypeInfo: Processing hadoop's query[2714ab78-b9f6-4fd2-ac43-dc9d0ac52157]: INITIALIZED_STATE -> RUNNING_STATE, statement: GET_TYPE_INFO
2021-08-08 14:31:40.088 INFO operation.GetTypeInfo: Processing hadoop's query[2714ab78-b9f6-4fd2-ac43-dc9d0ac52157]: RUNNING_STATE -> FINISHED_STATE, statement: GET_TYPE_INFO, time taken: 0.001 seconds
2021-08-08 14:31:40.088 INFO monitor.KyuubiStatementMonitor: Add kyuubiStatementInfo into queue is [true], statementId is [84e35aea-f84e-4da1-a827-97e818062d78]
2021-08-08 14:31:40.088 INFO operation.ExecuteStatement: s statemendId 84e35aea-f84e-4da1-a827-97e818062d78, sessionId: b9ba0414-4960-4e3a-b31c-717b9dcdd1e1
2021-08-08 14:31:40.088 INFO operation.ExecuteStatement: s statemendId 84e35aea-f84e-4da1-a827-97e818062d78, sessionId: b9ba0414-4960-4e3a-b31c-717b9dcdd1e1
2021-08-08 14:31:40.088 INFO operation.ExecuteStatement: s statemendId 84e35aea-f84e-4da1-a827-97e818062d78, sessionId: b9ba0414-4960-4e3a-b31c-717b9dcdd1e1
2021-08-08 14:31:40.088 INFO operation.ExecuteStatement: Processing hadoop's query[84e35aea-f84e-4da1-a827-97e818062d78]: INITIALIZED_STATE -> PENDING_STATE, statement: select 1
2021-08-08 14:31:40.089 INFO operation.ExecuteStatement: Processing hadoop's query[84e35aea-f84e-4da1-a827-97e818062d78]: PENDING_STATE -> RUNNING_STATE, statement: select 1

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

cc @zhang1002, this fix looks correct to me

Already tried to use jdbc client connect to spark thriftserver, hiveserver, learn that the jdbc itself will not send getTypeInfo request to server internally in those cases.
After patch, the statistics is right.

Codecov Report

Merging #904 (e5bce88) into master (c86767f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master     #904   +/-   ##
=========================================
  Coverage     79.19%   79.19%
  Complexity       11       11
=========================================
  Files           143      143
  Lines          5384     5384
  Branches        651      651
=========================================
  Hits           4264     4264
  Misses          756      756
  Partials        364      364

Impacted Files
Coverage Δ

...uubi/engine/spark/operation/ExecuteStatement.scala
88.46% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c86767f...e5bce88. Read the comment docs.

thanks, merged to master


Add Example for fonts with word space between them like Josefin Sans

There is no clear example to in the documentation to add fonts that have word space in there name.
\\ camel case does not load the font
 googleFonts: {
    families: {
      JosefinSans: true,
    },
}
\\ results in JosefinSans
\\ expected result is Josefin+Sans

Here an example
  googleFonts: {
    families: {
      'Nunito+Sans': true,
      'Playfair+Display': true,
    },
  },

in your case
  googleFonts: {
    families: {
      'Josefin+Sans': true
    },
  },

I had to try this one out, too. It would be good to include such an example in the documentation.


[Question] Does moneris send email of invoice to customer when there is a purchase or billing invoice created?

Or the invoicing should be done in my application?
Thanks!

Hey @ajcastro, I personally have never seen an invoicing offering through this API. To my knowledge, it only handles the payment processing

Thanks for the response!


Clarification on: "Our network performed no better than random"

In your blog, you said "We originally implemented BYOL in PyTorch using code we had written for MoCo. When we began training our network, we found that our network performed no better than random".
Just to clarify, do you mean to say that a randomly intialised network without any training performs the same as BYOL without Batchnorm?
If yes, isn't that strange? I would expect a random network to perform better than a mode collapsed network.
Also, thank you for the blog. I enjoyed reading it :smiley:.

Thanks @SohamTamba , this is a good question!
In the early stages of representation collapse (in our experiments, until cosine similarity is around 0.99999), the linear network used for accuracy evaluation is capable of using the small variation between embeddings just as well as the original random embeddings. This results in evaluation performance that is flat for a while. As collapse continues past that, the variation in encodings is no longer high enough for the linear fit to separate instances from each other, and the performance drops down to random chance. You can see this in Appendix C under "Experiments without batch normalization in the encoder."
Let us know if you have any more questions!


init_copy never used

Hi u seem to mistakenly name init_copy[_] with underscore so it never actually got called:
https://github.com/pmed/fixed_size_function/blob/master/fixed_size_function.hpp#L298
I was wondering what is the purpose in defining MaxSize for function wrapper?

Thanks, fixed.
This is a demo project for a class like std::function that avoids dynamic memory allocation. It's based on a topic here: http://rsdn.ru/forum/cpp/5732236 (in Russian).
MaxSize is the maximum size for internal buffer.


MH-13566 Accept duration as either string or number in scheduling JSON

The implementation released in 6.0 requires a string duration, but
the docs say Integer, which is consistent with usage elsewhere.
So accept both formats, enforce presence of duration when rrule is
specified, and update the docs to show correct examples.

Looks okay → merged.
Though the overall state of the external API seems horrible and it easier to break something than it is not to.
But that's not the problem of this pull request ;-)

Though the overall state of the external API seems horrible and it easier to break something than it is not to.

Just wondering: Why do you think the overall state is horrible?

Because testing this patch I found multiple ways to break something generating long stack traces and internal server errors by providing just slightly modified inputs. The state seems to be that the API mostly does what is expected if you provide precisely the right input. But no one seems to have spared any remote thought about properly handling incorrect inputs… that's not what I would call a good state.


Causes crashes in some enchantments

Coming from https://github.com/AllTheMods/ATM-6/issues/374, we have multiple reports of the Displacement enchantment from Ensorcellation crashing the server. After a conversation with the mod dev, it turns out that the Displacement mod only supports up to level 3, while Apotheosis allows it to reach to level 5 (and beyond), which causes unexpected behavior, and thus a crash. The mod author will add a check to prevent this, but this issue raises a more important question - is it safe to assume that all enchantments can scale infinitely? I can only imagine that a lot of other enchantments will have the same issue in some way or another. As suggested by the Ensorcellation dev, could you make it so that enchantments could opt in to the higher scaling, instead of having to opt out, or apply other forms or sanity checks?

Realiatically speaking this would be up to the modpack developer to apply maximum levels such that the modpack functions within reason.  The scaling cannot be opt-in as that would just make it a headache for people to use since it would no longer be automatic.
Recall that vanilla can attain enchantments above normal levels simply just by the /give command, and so the burden would fall on ensorcellation to not explode when the level is greater than 3.

Hard disagree. I don't impose my bow enchantment functionality on other bows. Opt-in is not a headache.
And by your logic, vanilla allows enchantment levels which absolutely break various parts of the game. But they aren't obtainable without commands. You've circumvented that.

This is the difference between a level and level > 3 ? 3 : level or Math.max(3, level) or a dev changing a config file.  There's a reason there is a config file.
Making it opt in would be miserable for the vast majority of users who will never look at a config file in their life, as suddenly almost nothing would have an increased level cap anymore.

Opt in by the devs, not by the packmakers. Seriously, make an API.

I could make it opt-out at an api level, but opt-in?  I don't have enough faith for most developers to bother, call me pessimistic about it, I guess.
An opt-out IMC message would be sufficient, I think

That is reasonable enough I feel, yes.

Alright, I'm away from a dev env for a while, but the spec will likely end up as sending over a regname list to opt out via nbt string array

The enchantment module is now prepared to receive IMC messages on modid apotheosis at method set_ench_hard_cap.
It expects a single EnchantmentData per message that specifies an explicit hard cap for that enchantment.
858fd72


lapack/gfortran dependency in latest linux binaries

It seems blas/lapack is now installed by default on the github linux runner.
This gets picked up by dune-common so the 1.5.0 release linux binaries depend on

liblapack.so.3
libblas.so.3
libgfortran.so.5
libquadmath.so.0

It would be good to fix this by:

(easier) uninstalling blas/lapack on CI
(harder) build & bundle static versions of blas/lapack (see also https://github.com/spatial-model-editor/sme_deps_common/issues/28)

Statically linking turned out to be unreasonably complicated so this is resolved for now by simply removing the system blas/lapack libraries from the linux CI runners before building.


Make code compatible with JDK 18

@werli reported that he got some errors when running Error Prone Support with JDK 18.0.2.
After some investigation I found these two JDK bug reports:

https://bugs.openjdk.org/browse/JDK-8249634
https://bugs.openjdk.org/browse/JDK-8160675

The first one flagged quite some violations. To resolve these violations, the default non-arg constructors are added with Javadoc. This solution is not ideal. However by looking at the docs of the javadoc command, and more specifically the options, I don't see a way to configure the check to go around this...
For me, this check flags a lot of missing Javadocs during development. Therefore, it'd be a good idea to not disable this check and use this PR to make the code compatible with JDK 18.
$ java -version
openjdk version "18.0.2" 2022-07-19
IBM Semeru Runtime Open Edition <IP_ADDRESS> (build 18.0.2+9)

I'll get back to this PR later on. I had checked out the branch however and the advertised mvn clean install now works using OpenJDK 18. :tada:
$ java --version
openjdk 18.0.2 2022-07-19
OpenJDK Runtime Environment (build 18.0.2+0)
OpenJDK 64-Bit Server VM (build 18.0.2+0, mixed mode)

Should've marked it ready a bit sooner. Will merge once last part is 🟢 .


bump dependencies version

bump dependencies version

I'm going to test this out and merge it today.


Select tiflash with RR strategy

What problem does this PR solve?
Select TiFlash store with RR strategy to avoid only one TiFlash works
Test

[x] Test manually

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests

/run-all-tests test-flash=true

/run-all-tests

success

/merge


Should the download notification persist after the fetch has completed?

Seems like a nice privacy feature, and gives the user something to interact with afterwards.

Fixed in https://github.com/jakearchibald/background-fetch/commit/52bf7437807d2b540697d35f7f5002c09543315d


Add Azure Sphre bootcamp sample model for AVNET Starter Kit

Thank you for contributing to the IoT Plug and Play Models repository
:memo: Please review this checklist before submission

[ X ] The models submitted in this PR follow the DTDL Naming Guidelines for contributing to this repository.
[ X ] dmr-client validate -m "AVNETSK-1.json" -r https://raw.githubusercontent.com/JuergenSchwertl/iot-plugandplay-models/main
[Validating]: C:\Repos\iot-plugandplay-models\dtmi\azsphere\spherettt\AVNETSK-1.json

Validating model file content conforms to DTDL version 2.
Validation passed without errors

[ X ] I understand once the PR is approved, the models are considered immutable: any edits will require to submit new files.
[ X ] No new top level namespace added

PR Info Template
Company Info

Microsoft Deutschland GmbH
www.microsoft.com
Azure Sphere bootcamp samples repo: https://github.com/JuergenSchwertl/AzureSphereSamples

IoT Plug and Play Device Info
AVNET Azure Sphere Starter Kit (rev1 and rev2)
https://www.avnet.com/wps/portal/us/products/avnet-boards/avnet-board-families/ms-azure-sphere/
Azure Sphere OS on Mediatek MT3620 micro-controller (ARM A7 & M4)
Model Submission Goals
Azure IoT Central integration for AVNET Starter Kit development boards during Azure Sphere bootcamp workshops
Code Owners & Reserved Names
@JuergenSchwertl ( https://github.com/JuergenSchwertl<EMAIL_ADDRESS>)

Uppercase file name undetected by dmr-client running on Windows.


Added validation for presence of tokens in token response

@shahzaibj - Where would you recommend that I add tests for this.  I can create artificial ones, but i'd like to create an end to end test for B2C that demonstrates this particular problem.

Partial resolution for https://github.com/AzureAD/microsoft-authentication-library-for-android/issues/563

@shoatman If this is something that you want to test with Robolectric / ROPC then you can add a test here: https://github.com/AzureAD/microsoft-authentication-library-for-android/tree/dev/msal/src/test/java/com/microsoft/identity/client/e2e/tests/network
If instead you want to test this with ui automation then you can add a test here: https://github.com/AzureAD/microsoft-authentication-library-for-android/tree/dev/msalautomationapp/src/androidTest/java/com/microsoft/identity/client/msal/automationapp/testpass/b2c

@shoatman I took the liberty of bringing the lastest changes into your branch

@shoatman I took the liberty of bringing the lastest changes into your branch

Thanks Brian.  I forgot I had this open.


[pigeon] Nested list types aren't preserved

The Everything type in pigeons/all_datatypes.dart has a field List<List<bool?>?>? nestedList. In an integration test of the echo API I tried to do a listEquals on the sent and received objects' nestedList items and got:
type 'List<Object?>' is not a subtype of type 'List<bool?>?' in type cast

It looks like we're not correctly reconstructing the nested types in the host->Dart direction. Even just trying to print the object is throwing a cast error.

Is this happening with all platforms?

The current implementation of nested lists uses the .cast method.
nestedList: (result[10] as List<Object?>?)?.cast<List<bool?>?>(),
.cast is a shallow method, it only implies that the next level down.
There's an open issue on the dart-lang github https://github.com/dart-lang/language/issues/1574, but I don't expect this is something that's going to change.
The nested lists will need to be cast at each level, or recreated with the correct types.
I tried a few ways to work around this but ended up with this code:
  final List<Object?> list = <Object?>[
    <Object?>[
      true,
      false,
    ],
    <Object?>[
      true,
      false,
    ]
  ];

  // final List<List<bool?>?> newList = list.cast<List<bool?>?>();
  final List<List<bool?>?> newList = <List<bool?>?>[];

  for (int i = 0; i < list.length; i++) {
    final List<bool?> newInnerList = <bool?>[];
    if (list[i] != null) {
      final List<Object?> innerList = list[i]! as List<Object?>;
      for (int j = 0; j < innerList.length; j++) {
        newInnerList.add(innerList[j] as bool?);
      }
      // item = List<bool?>.from(list[0]! as List<bool?>);
    }
    newList.add(newInnerList);
  }

Not the most elegant solution, and it would need to be recursive for each level of list.
I'll look for a way to clean it up a bit, but if you have any suggestions, I'm down to see them as well.


Improve performance

PR Checklist
Please check if your PR fulfills the following requirements:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe: Improvement

What is the new behavior?
Improved FPS and stuttering most noticeable on large datasets
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information
This is based off react-three-fiber's recommendations to not mount indiscriminately: https://docs.pmnd.rs/react-three-fiber/advanced/pitfalls#don't-mount-indiscriminately
BEFORE
https://github.com/reaviz/reagraph/assets/40581813/afb9dbfa-013e-4b08-8b64-51d7d71027a7
AFTER
https://github.com/reaviz/reagraph/assets/40581813/4641faaa-89f7-46d0-94d1-218fba5ec009

Awesome solution - i can't find anything wrong!


Fixed hook function name for hook displayPaymentReturn

Questions
Answers

Description?
Fixed hook function name for hook displayPaymentReturn

Type?
bug fix

BC breaks?
no

Deprecations?
no

Fixed ticket?
Fixes PrestaShop/PrestaShop#27118

How to test?
Cf. PrestaShop/PrestaShop#27118

Thank you @Progi1984


qemu-user-static support seems broken: Requested architecture isn't supported by this host

It seems a regression introduced around v2.0.10:
lxc containers no longer launch in qemu-user-static environment:
#l xc version
2.0.10
# lxd --version
2.0.10

Steps to reproduce
On x86_64 host:
# sudo apt-get install qemu-user-static
# lxc init ubuntu:16.04/armhf arm1
error: Requested architecture isn't supported by this host
# lxc launch ubuntu:16.04/armhf arm1
error: Requested architecture isn't supported by this host

At the same time container created before with older version of lxc/lxd can start under 2.0.10 with qemu user emulation in the same environment.

I'm surprised that you're reporting this as a regression, it's never something which we supported on LXD and the architecture check has been around for a long time. It may have been that a bug in LXD somehow wasn't tripping that check for you, but it sure was never meant to work.
LXD will let you copy images for another architecture but will only ever let you spawn containers for your native architectures. The use of qemu-user-static is something which we had in LXC (for Ubuntu and Debian templates) but which was way too bugy for us to ever consider supporting in LXD.
If you really wanted, you could still produce images that register as amd64 but contain an armhf filesystem, mixed with the needed qemu-user-static binaries in there and with the various network tools and init system coming from the native architecture of the host (as anything using netlink or ptrace will fail under qemu-user-static). Since such an image would register as amd64, LXD would let you run it, but we'd obviously not offer any kind of support on that :)


search 80 dimension vector cause program panic

create a space like.
		"vector": {
			"type": "vector",
			"model_id": "img",
			"dimension": 80,
			"format": "normalization"
		}

program panic during search. 64 or 128 dimension work fine.
are there some restrictions on vector dimensions？

great work btw

Please provide space creation statement.

Please provide space creation statement.

{
"name": "test_sapce",
"dynamic_schema": "strict",
"partition_num": 1,
"replica_num": 1,
"engine": {
"name": "gamma",
"index_size": 9999,
"max_size": 100000
},
"properties": {
"string": {
"type": "text",
"index": "false"
},
"int2": {
"type": "integer",
"index": "true"
},
"int": {
"type": "integer",
"index": "true"
},
"vector": {
"type": "vector",
"dimension": 80,
"model_id": "img",
"format": "normalization"
}
},
"models": [{
"model_id": "img",
"fields": ["string"],
"out": "feature"
}]
}
@wxingda

Provide the chubao-ps-startup.log on panic.

not sure where is it?

nohup file  or  log dir   gamna.log
On 12/23/2019 22:49, zhyon404 wrote:
not sure where is it?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

nohup.txt
gamma.log


fix javadoc about lnglevel

drools.dialect.java.compiler.lnglevel is the correct system property name.
https://github.com/tkobayas/drools/blob/master/drools-core/src/main/java/org/drools/core/rule/builder/dialect/asm/ClassLevel.java#L26

Can one of the admins verify this patch?

Merged into master and 6.3.x. Thanks for the PR!