Inv. response function U is not monotonic

Hello there, thanks for open-source.
I have a question that the inverse response function U is not monotonic based on my dataset (more than 1000 images, static scene and different exposure time from 0.05ms to 20ms). You said in this case, "it" should be smoothed or perturbed on your paper, and what is "it"?
I have modified some code like "G[255]" to "Gmax"(which is the max value in the G[]), is there some other codes I need to modified?
I'm sure that there are many different objects in the static scene, and the exposure time are incremental.
Best wishes.

see https://github.com/JakobEngel/dso/issues/16

Hi @chaizheng2157, could you please tell me how you can obtain the exposure time from your camera?
From what I know, the exposure time is equal to the shutter speed of the camera and should be constant all the time.
Can you clarify my understanding?
Thank you.


Sticky headers on the weather table

This PR changes the weather table - not massively, but noticeably. The new behavior is off by default but can be enabled in two ways:

set EXPO_PUBLIC_NEW_WEATHER_TABLE=true in your .env file while developing
or flip the new-weather-table feature flag in posthog

The changes are:

row and column headers are sticky
~column widths are uniform. This might not be a long-term requirement, but it's definitely gonna be more challenging to make the column header widths line up with the data widths when they're no longer lined up in a single VStack.~ now applying a rough heuristic size based on label length

Marking as draft for now, I want to do a little more side-by-side testing. Feel free to give feedback/ask questions though.
Still TODO:

[x] support font scaling
[ ] use same approach for NAC weather data table

before
after

/preview

brought the columns closer together, added support for font scaling

/preview

Fixed awkward label display for Solar Radiation column

I've gone through every NWAC weather station and haven't seen any regressions when using the new table (data is where it's supposed to be, no awkward text wrapping in column headers).

FWIW on SNFAC most of the MESOWEST and SNOTEL are identical sensors to each other so you can get a good indication of how this works without sifting through all 300

Oh I am definitely not going through all 300 😂 Checked a couple of each and they seem fine!

MESOWEST
SNOTEL

/preview

I think this should be safe to merge, and should be a no-op from a user perspective until the feature flag is changed.

You might need to rebase on #594 for the falsy display update? Your videos show Pcp1 column with '-' values instead of 0 still

Sweet! Let's do it


Update: RubyInstallerTeam.RubyWithDevKit version <IP_ADDRESS>

Removing old versions to reduce clutter
Microsoft Reviewers: Open in CodeFlow

/azp run


Handle more cases in ResolveConsolidator

Make an indicator consolidator for when the data is custom, but extends a TradeBar (so still has OHLC).
Update the ResolveConsolidator in QCAlgorithm to accept/search for this Custom : TradeBar data

We need to support consolidation of BaseData (time-value pairs), dynamic trade bar data (such as Quandl) with and without volume, and also tick consolidation.

721ecf3 updates ResolveConsolidator to use TickConsolidator and BaseDataConsolidator. DynamicDataConsolidator coming soon to a QC near you!

ef04c41 adds the DynamicDataConsolidator
These changes should allow the indicators to work with any custom data.


Clean up rsync progress display

The current implementation has a memory leak, use Ticker instead.
Also add --partial, --progress, --human-readable flags to rsync call.

Codecov Report
Patch coverage: 89.47% and no project coverage change.

Comparison is base (2928cb1) 76.57% compared to head (85de375) 76.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1789   +/-   ##
=======================================
  Coverage   76.57%   76.58%
=======================================
  Files          59       59
  Lines        5584     5594   +10
=======================================
+ Hits         4276     4284    +8
- Misses       1012     1014    +2
  Partials      296      296

Impacted Files
Coverage Δ

pkg/utils/common.go
80.05% <89.47%> (-0.01%)
:arrow_down:

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

@frelon just out of curiosity: how Ticker helps to remove/reduce the memory leak?

@ldevulder ran some tests with the different implementation, and it was because I used a break instead of a return in the select, which breaks from the select and causes an infinite loop instead of breaking from the loop:
	stop := make(chan bool)
	go func() {
		for {
			select {
			case <-stop:
				break // <- this should be a return
			case <-time.After(5 * time.Second):
				fmt.Println(message)
			}
		}
	}()

So the Ticker implementation is not needed, but I will keep it since it's already merged!


Jupyter: Enable Scrolling For Cell Outputs not working in the new version since last week.

Does this issue occur when all extensions are disabled?: Not Relevant

VS Code Version: 1.57.1
OS Version: windows 10 Pro 21H1

Steps to Reproduce:

Open a Jupyter Notebook
Run any code in a cell that generates a lot os lines and it will not create the scroll bar for the output. It will fill the hole lenght of the notebook.

Thanks for reporting, duplicate of https://github.com/microsoft/vscode/issues/126863 and let's track it there.


pyb module support

Can't get autocompletion for pyb module. Even import is red

It's known problem. We still don't have Python stub files with type hints for pyb. Please follow #16.


First cleanup of bitwise adapter + add to docs

Follow-up to @edi33416's https://github.com/dlang/phobos/pull/4927 (which imho was merged too early) and adds some of my unaddressed review comments:

adds to booktable (s.t.  it's listed on the docs
adds bitwise and hides the helper struct (no need to expose it and gives more flexibility later. The exposed public symbols are a relict)
adds a nice public example and hides the internal tests (see current docs for the motivation
fixes style (no parenthesis for @property functions)
fixed various typos
removes __PRETTY_FUNCTION__ from assert (current Phobos policy is to use plain assert. Improvements to assert should be done in the compiler)
addresses @andralex's remaining comment

@edi33416 could you please add a lot more tests?
When I tried to come up with nice examples for the documentation I immediately hit a bug:
[3, 9].bitwise[$ - 5 .. $ - 1].writeln; // ERROR: Attempting to fetch the front of an empty array of int

Also please:

See my question about calculating the mask every time in front.

Calculating the mask every time seems to be an unnecessary expensive operation. What is your rationale for storing the position and not the mask directly?
(front is expected to be called a lot more often thanopSlice and opIndex`)

See Andrei's remark about uncovered lines

Add a @nogc unittest

Make the second unittest @safe as well

Maybe add more "showcase" examples if you wish so

Don't forget to add a changelog as well

Did you do some benchmarks on iteration via bitwise and "naive" bitwise iteration? (i.e. the incurred overhead)

cc @edi33416 please review

LGTM

When I tried to come up with nice examples for the documentation I immediately hit a bug

I'm looking into it. I figured where the issue is and I hope I'll have a fix as soon as possible.

See my question about calculating the mask every time in front.

Andrei pointed out during the first stages of the review that storing both the mask and the maskPos is redundant since we can calculate one based on the other.

Add a @nogc unittest

Will do

Make the second unittest @safe as well

Sure

Maybe add more "showcase" examples if you wish so

I will add some more examples

Don't forget to add a changelog as well

Will remember to do so

Did you do some benchmarks on iteration via bitwise and "naive" bitwise iteration? (i.e. the incurred overhead)

No, I have not.
Thank you for your comments and observations.

Andrei pointed out during the first stages of the review that storing both the mask and the maskPos is redundant since we can calculate one based on the other.

Yes, but my question was whether you benchmarked before you choose to store maskPos?
It's just that for e.g. front (a) it looks like a lot of work to do parent.front & mask(maskPos) vs. parent.front & mask

Did you do some benchmarks on iteration via bitwise and "naive" bitwise iteration? (i.e. the incurred overhead)
No, I have not.

It would be great if you could do so.
You can use e.g. benchmark.
People usually use bit* stuff if they want superior performance.
Btw @edi33416 you know about core.bitop, right?
(these function are intrinsics and guaranteed to be one assembly instruction - well at least if your architecture supports them)

Yes, but my question was whether you benchmarked before you choose to store maskPos

We usually don't use benchmarks as criteria for acceptance. In this case the maintenance cost of the redundancy seemed too high.

cc @edi33416 please review
LGTM

Ping & raising the priority on this one.
The bitwise PR exposed internal tests & and we now test them, CircleCi now errors for master :/
It did go undetected because of https://github.com/dlang/phobos/pull/4964
(the PR changed the selective imports in std.meta to a package wide and which is publicly imported in std.range)
As this PR will provide a proper public example, it will also fix CircleCi for master.


Anonymize ACRA reports

See how we can better anonymize ACRA reports, that may contain sensitive information.
These information are basically URIs to resources, so we should should make sure we don't include these URIs in possibly uncaught exceptions (i.e. in the message of the exception).

OK, removed any sensitive info. Standard reports with usual debug information without identifiable data are now sent.

Done.


NIV and IV ventilator mode & Oxygen support Modality mode have no data reflection in patient consultation page

Describe the bug
In the patient consultation page, currently, there is a badge present their respiratory support is either NIV, IV, or OS but the related ventilator mode or modality mode is shown nowhere in the platform

To Reproduce
Steps to reproduce the behavior:

Go to patient consultation page
Click on log update and file the detailed log updated
post creation, go to the consultation page.
See error

Screenshots

Expected behavior

[ ] Add a table on the "ventilation tab" in patient dashboard (https://care-staging.ohc.network/facility/da95c77c-cf2f-4400-be53-6da766951552/patient/70ff1884-89ca-43fd-bc6c-2354cff9457d/consultation/9b1b3f6d-581d-46f3-8279-456596defd35/ventilator). The table to appear on top of the ventilator tab before the graphs of PIP and MAP

[ ] Indicate change in modality and vantilator mode/oxygen modality by adding a vertical line as marker on the time series graphs for the various parameters

@rithviknishad Mind assigning this to me? Thanks!

I've added the vertical line as a marker, though it looks a bit weird when we switch to bar graph.

On a side note, if we adding the modality in the graphs themselves, wouldn't it make more sense to add the line markers to the points themselves, than the mid-points 🤔 @nihal467
For ex: with the marker line, the image (in the original post) makes it seem like C-PAP started before 2:32 on 19/08/2024.

I've added the vertical line as a marker, though it looks a bit weird when we switch to bar graph.

On a side note, if we adding the modality in the graphs themselves, wouldn't it make more sense to add the line markers to the points themselves, than the mid-points 🤔 @nihal467
For ex: with the marker line, the image (in the original post) makes it seem like C-PAP started before 2:32 on 19/08/2024.

@aparnacoronasafe can you comment on this

@Jacobjeevan This was discussed over slack.
Are there any specific issues to be addressed here?

@Jacobjeevan This was discussed over slack.
Are there any specific issues to be addressed here?

Nothing as of now 👍

I agree that the bar graph view does not look great. What are the alternatives we have?

I'm checking the charts library we are using to see if there are any other alternatives; will update you 👍

I tried switching to Mark Area, which works for line charts but doesn't render correctly for bar charts; it seems to combine consecutive modes/modalities. I've attached the Mark Line ones below for reference.
Mark Area

Mark Line

@aparnacoronasafe Well, we could use the markArea feature and instead disable the switching to bar charts feature for these graphs, depends on how important/useful they are.

I managed to get it working with markLine, take a look and see if this works 🤔  We can adjust the label position as needed.

@Jacobjeevan i think mark area looks better.
Let's retain the bar graph option as well?

@Jacobjeevan i think mark area looks better.
Let's retain the bar graph option as well?
Also could you add (IV/NIV/O2) also against the ventilator mode/oxygen modality mentioned?

@aparnacoronasafe Sure, we can add those.
We can keep the bar graphs, however there's some inconsistency in how it depicts the data for markArea🤔
For example: In the line chart, NP starts at 2:45PM (which is correct), but switching to bar chart, NP shows up later (I've highlighted 2:45PM on the bar chart below). Not only that, but the distinctions between NP/SFM/HFNC isn't as clear.

After discussing with team, going with the markLine since markArea presents inaccurate data when switching to bar charts. Here's how the latest looks:

Looks good @Jacobjeevan

Looks good @Jacobjeevan
However, I donot see the current ventilator mode marked in the graph. in the above eg, IV-PCV should also be marked in the right end of the graph right? Could you check?

@aparnacoronasafe ah, good catch, I had excluded the latest datapoint to render markArea graphs; I'll get it fixed :+1:

Fixed the above (render the most recent modality/mode on graph).


feat: Support escaped string literals (PostgreSQL)

Hello!
It's a draft which implements special PostgreSQL escaped string syntax.
https://www.postgresql.org/docs/8.3/sql-syntax-lexical.html#SQL-SYNTAX-STRINGS

PostgreSQL also accepts "escape" string constants, which are an extension to the SQL standard. An escape string constant is specified by writing the letter E (upper or lower case) just before the opening single quote, e.g. E'foo'. (When continuing an escape string constant across lines, write E only before the first opening quote.) Within an escape string, a backslash character () begins a C-like backslash escape sequence, in which the combination of backslash and following character(s) represents a special byte value. \b is a backspace, \f is a form feed, \n is a newline, \r is a carriage return, \t is a tab.

Thanks

@alamb can you take a look to verify that it's a correct approach. Thanks

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

63 of 80 (78.75%)  changed or added relevant lines in 4 files are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.1%) to 90.384%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/parser.rs
4
6
66.67%

src/ast/value.rs
12
18
66.67%

src/tokenizer.rs
31
40
77.5%

Files with Coverage Reduction
New Missed Lines
%

src/parser.rs
1
82.94%

src/tokenizer.rs
5
89.5%

Totals

Change from base Build<PHONE_NUMBER>:
-0.1%

Covered Lines:
8365

Relevant Lines:
9255

💛  - Coveralls

Thanks -- I am a little behind in sqlparser-rs review. I will try and find
time this weekend to review
On Wed, May 18, 2022 at 2:52 PM Coveralls @.***> wrote:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
https://coveralls.io/builds/49246117

63 of 80 (78.75%) changed or added relevant lines in 4 files
are covered.
6 unchanged lines in 2 files lost coverage.
Overall coverage decreased (-0.1%) to 90.384%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs
https://coveralls.io/builds/49246117/source?filename=src%2Fparser.rs#L908
4 6 66.67%
src/ast/value.rs
https://coveralls.io/builds/49246117/source?filename=src%2Fast%2Fvalue.rs#L207
12 18 66.67%
src/tokenizer.rs
https://coveralls.io/builds/49246117/source?filename=src%2Ftokenizer.rs#L402
31 40 77.5%
Files with Coverage Reduction New Missed Lines %
src/parser.rs
https://coveralls.io/builds/49246117/source?filename=src%2Fparser.rs#L909
1 82.94%
src/tokenizer.rs
https://coveralls.io/builds/49246117/source?filename=src%2Ftokenizer.rs#L775
5 89.5%
Totals [image: Coverage Status] https://coveralls.io/builds/49246117
Change from base Build<PHONE_NUMBER> https://coveralls.io/builds/49129477:
-0.1%
Covered Lines: 8365
Relevant Lines: 9255
💛 - Coveralls https://coveralls.io
—
Reply to this email directly, view it on GitHub
https://github.com/sqlparser-rs/sqlparser-rs/pull/502#issuecomment-1130388116,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AADXZMNOF6E5YP7YTXV5CJ3VKU35NANCNFSM5WJMUQGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>


Balancer Composable stable pool strategy

Adds support for Balancer's Composable stable pools.
Connected PR: https://github.com/OriginProtocol/origin-dollar/pull/1849

Closing as we are no longer doing this strategy


Preflight styles?

How to get the Preflight styles with railwind, i.e., to remove all default browser CSS?

You can use the -p flag to add the preflight. Check the -h flag for help.

Yes, it works. Thank you. Sorry for opening this issue, I had to look into the source first.


As a Data user I want to compare time periods of data (for a species/several species) ..so that I can assess the changes over time

original id#37

Needs clarification and aggregation level.

Do they really want to compare "data" (summary of seach effort/ number of sightings) or some metric of animal density/abundance/presence over time?

Steering group meeting 26th March - ticket parked for future discussions (no-one commented on clarifying or owning the ticket)


Add design note on lifted transformations

This is great! just spelling nits, etc.

You will be happy to learn I just found myself a VSCode spell checker plugin :)

Codecov Report

Merging #1267 (2606bf3) into master (279f80b) will decrease coverage by 0.00%.
The diff coverage is n/a.

:exclamation: Current head 2606bf3 differs from pull request most recent head 0802b94. Consider uploading reports for the commit 0802b94 to get more accurate results

@@            Coverage Diff             @@
##           master    #1267      +/-   ##
==========================================
- Coverage   82.27%   82.26%   -0.01%
==========================================
  Files          65       65
  Lines        5303     5295       -8
==========================================
- Hits         4363     4356       -7
+ Misses        940      939       -1

Impacted Files
Coverage Δ

flax/metrics/tensorboard.py
73.23% <0.00%> (-1.45%)
:arrow_down:

flax/linen/linear.py
99.43% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 279f80b...0802b94. Read the comment docs.

@jheek Sorry for too many comments, hope some of them help! This is a great doc, I'm learning so much 👍 Thank you

@jheek Sorry for too many comments, hope some of them help! This is a great doc, I'm learning so much 👍 Thank you

Your help is much appreciated! GitHubs review UI is a bit verbose for reviewing text but that's what it is.

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.
We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

@8bitmp3 could you add your consent? This is for the applied suggestions

@googlebot I consent.


Videos and thumbnails jumbled

I have had wrong video play in the past and never thought much of it until today. I just tried watching two different shows (documentary's, one is wonders of the universe, already forgot the other one) and both played the wrong video. But this time I remembered having seen watched the proper videos some time ago. So now I'm guessing there really is an issue there. Something changed things around.

And this is from my favorites folder I'm talking about. And not every source does it. VIDICS/ZSTREAM played the wrong one (some sci Fi movie) but VIDICS/DACLIPS plays the proper one. So maybe it's not as bad as I thought. If one source doesn't work, try another. Fair enough.


Default for <summary> text should be non bold with the option to make it bold via explicit tags

Right now the default rendering for the following MDX:
<details><summary>Expand for example User model with an @@id block</summary>

```prisma
model User {
  firstName String
  lastName  String

  @@id([firstName, lastName])
}

```
Is this:

In this case, it feels a bit weird because the font is bigger and bolder than the heading right above... I wonder if generally the summary should be rendered as normal/plain text and then it should rather be possible to maybe change the font on demand, e.g. using ` tags.

Closing as not planned. The current 'summary' text is now set to 16px in line with the body text and H4.


Misc doc changes

Besides other fixes, this commit allows the generated HTML doc for
HexDocs.pm will become the main doc source for this Elixir module.
List of changes:

Use common source url
Set readme as main html doc
Use and set ex_doc to latest version
Add license section
Update gitignore
Add code formatter
Fix markdown and typos
Badges and more badges!
Tally minimum Elixir requirement version with CI

Screenshots:

can you rebase against master to make sure the test passes

can you rebase against master to make sure the test passes

Done.


Docs for admins

Installation and configuration docs for admins.

Edited as of https://github.com/TxtDot/txtdot/issues/31#issuecomment-1693061637

Edited because of https://github.com/TxtDot/txtdot/issues/31#issuecomment-1693061637

Is this going to be in the general repository?

Didn't think about it, but yeah, we can place docs in a separate repository.
I'll start by writing Markdown files, later they can be built into a web site with MkDocs or something similar.


adding license

@gpad please check if the ragione sociale is correct
coders51 S.R.L., because I recall something strange that @keown told me :)

@baldarn which type fo license is it? I'm not an expert. Is it a MIT license?


Add iCE40 CW312 Board Support

This adds support for a new iCE40 board used by ChipWhisperer

Oops thanks for catching - fixed (also renamed the default branch so it's 'main' to match everything else, I forgot that wasn't done on that repo)

Thanks!


Add Option for Custom Escape Character

Added option for custom escape character to allow for more flexibility. The value defaults to " so that it's not a breaking change.
I did rename the variables from quote to escape to be more semantically correct (e.g. you would "escape" a quote by adding an escape character in front of it). Since you are the maintainer of this project I will fall back to your naming convention preference here. Let me know if you disagree/dislike escape, _escaped, and isEscaped and I'll change them back to be quote-based variable names.
NOTE: It's not perfect as it assumes the character being escaped and the escape character are the same. For example it does not allow this: "some \"column\" value" (the escape character being \ in this scenario). I feel that this type of change is more significant to the core functionality and would require it's own Pull Request.

This is a really good PR. Both from a description standpoint, to tests, and to the implementation. Great job! Released in 1.8.0

Thanks @mafintosh…happy to give back! Also, thank you for the quick merge/release!!


MBTiles DataSource

Testing with OSM2Vectortiles http://osm2vectortiles.org/downloads/

This is awesome! I will be looking through this (and trying out with osm2vectortiles).

Wonderful.

We do not need add the mbtiles attribute,
just support for a new URL schema,
url:  mbtiles://file_path;
That's would reduce much code effort.
And also suggest merge all the UrlWorker into a single place.
Do not implement them in platform code.
but in tangram-es/core directly.
I''ve done that in
https://github.com/tangrams/tangram-es/pull/836

Hi @lygstate
I don't think we want to invent a new non-standardized URL scheme. An 'mbtiles' scheme wouldn't be usable with existing libraries the way that 'http' and 'file' are. A separate 'mbtiles' entry also allows us to add optional caching in a backwards-compatible way.
The design of UrlWorker isn't strictly related to this PR, but I'd gladly review those changes separately. (By the way, #836 hasn't been forgotten - thanks for staying active in the project!)

Hi @hjanetzek - how is progress on this PR coming?

Hey @hallahan, I think the branch is in a good shape. DataSource refactoring needs to be reviewed first though and everybody is busy with things we need for the mobile SDKs - I hope we will get back to this soon.

This includes code for md5 sums. Is there something already included in one of the other libraries required that could be used, like sha256?
How can we make sure we only write to mbtiles files which are written in a way we understand? There is no guarantee that we can write to an arbitrary mbtiles file, even if it is storing vector tiles from the same source, because they could implement the mbtiles tables interface in a different way.

Good questions. @blair1618 will make a proposal as to Tangram syntax for handling the different read/write/fallback scenarios.

Hey, how are things going? Any word on this PR and MBTiles support?

Yes, @hallahan. We were busy with a project which we finished in december. Will be giving this a good shot now, expect more action on this now :D.
Thanks for the patience and sorry for the delay on this.

I have not reviewed all of this yet, but so far it's looking mostly solid.
One problem I've noticed is that SQLiteCpp/sqlite3 seems to have its own implementation for opening and reading a file path. This has two results for us:

We need to resolve the mbtiles path from a scene file into an absolute path before we give it to sqlite (paths in the scene file might be absolute, but more often they are relative to the scene file's location).
Android applications currently can't bundle an mbtiles file. Android application bundles are effectively zip archives, and so there is no file path that identifies any individual file within the bundle. One could work around this by sneakily copying a bundled mbtiles database to a location on disk at run-time (given suitable permissions and with a start-up delay).

Configuration seems to still be an open question here. I see that suggestions have been made for new parameters in the scene file, which is the typical way that we introduce new features, but in this instance I feel that some of these configuration options go beyond "styling a scene" and enter the territory of application implementation. For example, the location of an mbtiles file will probably need to be different on Android and iOS because of their storage mechanisms (as in my previous comment). Even more generally, I don't know whether we would expect to ever support mbtiles files as a data source in the JS engine, though @bcamper may have thoughts here.
With these considerations in mind, I would suggest that an interface for configuring MBTiles data sources/caches should be part of the tangram-es API and not part of the scene file.

There are offline situations where this could be useful for Tangram JS, too.
On Thu, Jan 19, 2017 at 9:17 AM, Matt Blair<EMAIL_ADDRESS>wrote:

Configuration seems to still be an open question here. I see that
suggestions have been made for new parameters in the scene file, which is
the typical way that we introduce new features, but in this instance I feel
that some of these configuration options go beyond "styling a scene" and
enter the territory of application implementation. For example, the
location of an mbtiles file will probably need to be different on Android
and iOS because of their storage mechanisms (as in my previous comment).
Even more generally, I don't know whether we would expect to ever support
mbtiles files as a data source in the JS engine, though @bcamper
https://github.com/bcamper may have thoughts here.
With these considerations in mind, I would suggest that an interface for
configuring MBTiles data sources/caches should be part of the tangram-es
API and not part of the scene file.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tangrams/tangram-es/pull/1015#issuecomment-273838854,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0EO0ZuhT7HMPQ6m1EdwoHLqSeyPyJwks5rT5rHgaJpZM4KW6BG
.

We do have an tangram ES level API to add an MBTile DS in this PR. But yes it utilizes updating the scene ultimately adds a DS via scene yaml load!
If JS has a use case of having offline MBTile Datasource, I am fine keeping it in the scene file description only.

@nvkelso I can imagine that an offline data cache of some kind would be useful for tangram-js, but it is unclear to me whether a SQLite database file is a good fit for this purpose. It seems undesirable to add a SQL library to the JS engine for just this use. And even if tangram-js did support reading MBTiles files, the issue would remain that it would likely use a different configuration (file location, timeouts, etc) than, say, an Android application.

@matteblair I recall @bcamper's opinion being similar.  But it remains a valid use case that I think we should either support out of the box or provide documentation around the suggested workaround (e.g. running a local tileserver reading from the SQLite DB and masquerading it as a local tile endpoint).

@nvkelso Totally! It is a valid use case. I think there was also talk of using zip archives for offline use - tangram-js already has a zip reader so that might get us to a solution faster.
@pnorman 's concern about different access modes to an MBTiles file seems sensible to me - we will want our interface to encourage/enforce safe usage patterns.
I can currently see two use patterns for MBTiles files:

Pre-downloaded data set, read only.

Data cache created by tangram, read+write.

As long as we keep these roles distinct, we can be confident that we won't accidentally write incompatible entries to a database. The files used for these roles could be specified in clearly different ways.
Are there other use patterns that I'm not thinking of?

As I'm thinking through using an MBTiles file as a cache mechanism, it occurs to me that we can only store one set of tiles in a single database (or else I misunderstand the MBTiles format). If that's true, then if we wanted to cache the data from a scene like Walkabout (which uses a vector tile set and a raster tile set) then we would need two separate MBTiles files to store the combined data.
In general, it seems that we'll need one database file per network data source to effectively cache map data, which is a minor bummer.

@matteblair you are correct in saying that we will need one database file per network datasource for caching with mbtiles. It looks like its exactly what is implemented in this PR with when caching mode is enabled for an mbtiles datasource.
Way I see it being used for caching with all network datasources is by defining an MBTiles datasource for each network source and enabling offline and caching mode for the corresponding MBTiles datasource.

I can currently see two use patterns for MBTiles files:

Pre-downloaded data set, read only.

Data cache created by tangram, read+write.

As long as we keep these roles distinct, we can be confident that we won't accidentally write incompatible entries to a database. The files used for these roles could be specified in clearly different ways.

So I think currently the core MbTileDatasource code handles this gracefully, and won't accidentally write incompatible entries to a db.
Currently, how it is implemented via SceneLoader all MBTileDataSource will have read+write support. We will have to aptly exposed via an API, and let the user define the behavior when setting a MBTile Datasource.

I think MBTilesDataSource is able to follow the policy we want, but it's important that the user interface makes it easy to set up both offline sources and caches correctly, rather than relying on run-time checks.

Exactly my point :D

If we were to use the scene file to configure MBTiles sources, the most sensible approach I can think of is to allow a new type of sources entry where the url field contains the location of a file with the .mbtiles extension and the type field is not used (tile format is deduced from the MBTiles metadata). e.g.
sources:
  _my_source:
    url: /storage/emulated/0/mapdata/newyork.mbtiles
    max_zoom: 16

For the caching use pattern, we can use a new field for sources entries, tentatively called cache, that specifies the location of a file with the .mbtiles extension. The cache file is permitted to not yet exist, but the path to the file must exist. e.g.
sources:
  _my_source:
    type: MVT
    url: https://tile.mapzen.com/mapzen/vector/v1/all/{z}/{x}/{y}.mvt
    url_params:
      api_key: xxxxxxx
    cache: /storage/emulated/0/mapdata/cache.mbtiles

Some things to note about this approach:

The paths in these examples are typical for local file storage on Android. I used these paths because unlike most file paths we specify in scene files, these cannot be relative paths from the scene file (at least on Android). The caching use pattern will require (different) absolute file paths on both Android and iOS. The application developer will also need to request any needed permissions to write a file to disk. This illustrates my concerns that configurations using this approach are not portable.
The read/write access to MBTiles files should be evident with this syntax. The file in url is always read-only and the file in cache: is always read-write.
There is much more that could be specified about caching behavior, e.g. the timeout duration on the primary data source, the expiration of cached data, etc. Many of these parameters are application-dependent, they would differ between a mobile and desktop application. This makes me hesitate to put them in the scene file, which aims to be as platform-agnostic as possible.

I'm really interested in using this feature so I'll add some comments - I don't know a lot about this project and some might not be relevant:
Using .mbtiles files

tile format is deduced from the MBTiles metadata

May be it could be good to add a type: mbtiles anyway for extensibility purpose ?
cache
sources:
  _my_source:
    cache: /storage/emulated/0/mapdata/cache.mbtiles

App devs probably care about a fs backed cache, do they really care about where the cache will be stored, ie should the path be optional ?
Should you also provision a type: mbtile entry here for extensibility - it could probably be the default for now.
Anyway kudos for this projectand can't wait for the offline support to be merged !

Hi @vicb, thanks for the rapid feedback!

May be it could be good to add a type: mbtiles anyway for extensibility purpose ?

I was thinking about this too. The reason I didn't suggest it is that the other options for type are vector tile data formats, whereas MBTiles is a database that can contain tiles in any of the other formats, so it's not really consistent.

App devs probably care about a fs backed cache, do they really care about where the cache will be stored, ie should the path be optional ?

Fair point. The path will be important for some cases, e.g. if an app wants to use a temporary folder for the cache or be able to pull the file off the device later. For other cases it might not matter. I believe that we can access a reasonable "default" location for saving files on all of our supported platforms. To configure this we could make the cache field a mapping, allowing for more options later:
cache:
  url: /storage/emulated/0/mapdata/cache.mbtiles # optional!

or we could use a Boolean true to represent "unspecified caching":
cache: true

Again, I see both of these as going beyond the intended purpose of the scene file :\

@matteblair sounds all pretty much good to me.  Could you add these changes?
I think it will generally makes sense to pass mbtiles options as SceneUpdate on scene loading (left to the application developer or Mapzen SDK) - No need to consider portability of mbtiles paths imo right now.
Another thing to keep in mind/take care of: When mbtiles are used for raster sources they have to be registered via scene files since the initial tile sources are checked to build the shaders.

@hjanetzek Yep, I will start implementing these suggestions, beginning with the read-only usage since that seems the most clear.

@matteblair
sources:
  _my_source:
    url: /storage/emulated/0/mapdata/newyork.mbtiles
    max_zoom: 16

From the docs the type is required w/o default.
I think that omitting the type here would harm extensibility - how would you implement a mztiles format for example ?
I understand that the tile themselves could be in different format but still you need to know how to read the container, don't you ?

@vicb Yep, type is currently required for all data sources but that could change with the addition of MBTiles sources. What I was proposing was that we use the file extension of the URL to signify that we are using an MBTiles source (or, in the future, .mztiles for a hypothetical MZTiles source).
The drawback I see to mandating type: MBTiles is that it is redundant information and it could invite errors where a type is given that conflicts with the URL (e.g. someone mistakenly uses the vector tile type for an MBTiles source). That said, with MVT tile sources we have a similar tradeoff, since MVT could be inferred from the file extension, and we still require a type for those sources.
I now agree that it would be more consistent to require that MBTiles sources specify type: MBTiles.

I'm still working on making the user experience here make sense, these are my current thoughts.
When I'm using an existing MBTiles database as a data source, there should be no need to specify the format of the tiles in the database because the database itself holds that information as metadata. If I download an MBTiles file without knowing exactly what it contains, I am not sure how I would determine the format of its contents (short of running SQL queries on it). I wouldn't know what to put in the type parameter in this case.
This led us to deciding on the type: MBTiles option, which lets tangram-es deduce the tile format from the MBTiles file itself.
There are still cases where the user must know something about the tile format in the database. When I use an MBTiles file as a raster tile source, I must know that the contents are raster tiles so that I can set the rasters parameter of other data sources that use it. When tangram-es is initializing data sources it must also be aware that a source with type: MBTiles might be a raster source, but also might not be, which is a little weird.
In code terms, the type: MBTiles approach also implies that the "type" of a tile source isn't known until after it is initialized, which is difficult with our current inheritance-based approach to tile sources. I'm currently working on resolving this by refactoring for composition instead of inheritance.

Just a couple thoughts since I'm interested in seeing this feature.
It sounds like while technically the more specific type can be inferred, there are some cases in the yaml where it would be an error to have a mismatch, such as the rasters example. Perhaps the type for mbtiles can be used as an assertion that the data source is this type rather than choosing a parser.  Thus, specifying 'type:MBTiles-raster' would assert that it's a raster and can be used as a raster in other sources.  'type:MBTiles' would not be able to be used as a raster in other sources.

Alright - here's where I've landed on this.
The scene file now supports only read-only MBTiles sources using existing files. When the url of a sources entry ends with the .mbtiles extension, it is recognized as an MBTiles source. The type field remains unchanged, that is it should be set to the type of vector or raster tile expected from the data source. For example:
sources:
  _savedTiles: #This is an example MBTiles data source.
    type: TopoJSON #We expect TopoJSON data from the source.
    url: /path/to/my/file.mbtiles #Only absolute file paths supported for now.
    max_zoom: 16 #Other optional parameters are applied as usual.

I think we should merge this now to provide the core functionality and then add caching and additional configuration later on as we figure out usage.

Will give the updates a look in a bit and merge if all good.

Agreed this is the right initial scope, thanks!

Will be merging this when CI builds are done.

Rebasing - hang tight

Does it work for Android and iOS? I was able to render map from mbtiles on Linux. But with the same scene.yaml I cann't make it work on Android. Im also using file picker to get path of mbtiles.
sources:     osm:         type: MVT         url: /sdcard/Download/prague.mbtiles         max_zoom: 14
Picker in code below returns correct path "/sdcard/Download/prague.mbtiles".
`        dialog.setDialogSelectionListener(new DialogSelectionListener() {
@Override
public void onSelectedFilePaths(String[] files) {
List updates = new ArrayList();
updates.add(new SceneUpdate("sources.osm.url", files[0]));
view.getMapAsync(MainActivity.this, "sceneMbtiles.yaml", updates);
}
});
    dialog.show();`

Is this MBTiles sources support usable for offline maps on Android? Have you tested it? I am just asking, I didn't tried nor looked into it. Thank you.

Hi @rwrx
Using MBTiles as an offline source of map tiles is working on all platforms we support. There are other usecases of MBTiles discussed in the (merged) PR which are not fully supported.
To use a MBTiles set in your scene you can refer to this comment above.

It is also possible to change that path to mbtiles file at runtime? I mean not only hardcode it into yaml scene file. And it is possible to have multiple mbtiles paths defined? I mean a use case where user has for example downloaded multiple mbtiles for countries and I need to show them on the map.

Has this functionality been documented anywhere, or better yet implemented in a demo? Would be great to have a working example.

@kueda There's an open issue to add this in our docs repo: https://github.com/tangrams/tangram-docs/issues/192, thanks for the reminder to add this!


Implement bytes length

Description
The bytes type does not currently support the length constraint as the string type does currently.
For example, the following string.sysl:
App:
  !table T:
    s <: string(0..1024)

Produces the following in the generated proto structure (trimmed for brevity):
sysl pb string.sysl
key: "s"
value: {
  primitive: STRING
  constraint: {
    length: {
      max: 1024
    }
  }
}

However, the following bytes.sysl:
App:
  !table T:
    b <: bytes(0..1024)

Produces an error while parsing.
Expected behavior
The bytes type should support the length constraint:
sysl pb bytes.sysl
key: "b"
value: {
  primitive: BYTES
  constraint: {
    length: {
      max: 1024
    }
  }
}

Your Environment
$ sysl info
Build:
  Version      : v0.170.0
  Git Commit   : cb1ad4b5d238c3a7c78694b04466b15ec9de75ee
  Date         : 2020-07-31T07:22:34Z
  Go Version   : go1.13.14 linux/amd64
  OS           : darwin/amd64

Upon inspection, this may be a simple as adding sysl.Type_BYTES to makeTypeConstraint in listener_impl.go.


Fdopen

Adds fdopen back using Lua >= 5.2's luaL_Stream API, and using compat-lua-5.2 to make it work with LuaJIT and 5.1.

Nicely done, sir!


Autorotation but nonContinuous?

Hi,
Not really and issue but a request: Is it possible to enable auto-rotaion but not endless? When I try autorotation:1 and continuous:0 (or nonContinuous class) together, the panorama stops sliding. I use a 180° picture and so I'd like the panorama stops where the image ends and then scroll to oposite side. Is this possible? Thanks

I do not think it is possible right now, but it would be an enhancement. If autorotation:1 and continuous:0 are active the direction should be reversed at the edge of the image.


Update docker-image.yml

Going to close this PR, Because changes already merged with main branch, The reason for creating this PR, we are trying resolve the access denied issue, But it issue from authorisation a2d2-repo in docker hub, when access get granted so its started pushing image, We no need this merge this PR


Update README.md

Typo in icon

Integration Test / self-test (push) will fail. No solution.
We don't need to update the version of the action if we are changing documentation.
The version check on push can't be skipped as we cannot provide the label documentation which the action uses to skip itself.


I'd enjoy that a lot.
By the way, great work, this is really nice! I love the YouTube integration!

This feature falls out of the scope of what a "music bot" should do. The project is open source though, and you're more than welcome to implement this on your own fork and run it.


Add variable debug option to CLI

Proposed changes

Adds a --verbose flag for INFO logging output
Changes the --debug flag to an option instead which requires the debug level output. E.g. --debug DEBUG

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

[ ] python lib/cli/cli.py -d DEBUG check that you get DEBUG output when trying to run any module
[ ] python lib/cli/cli.py -d DEBUG -v should ignore the verbose flag as debug has priority

Related issue
Fixes #85

I'm not able too see any output, I used to be able too see how the model parsed the input but can't seem to see it on this branch. Something might be wrong on my end tho, not sure.

Thanks. I fixed that bug now in the latest commit.


[Feature Request]: Want to Improve Ui of Add Product Page

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I Want to Improve Ui of Add Product Page
Use Case
It will provide good user experience to users
Benefits
No response
Add ScreenShots

Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@nishant0708 nice go ahead


refactor: 💡 New Examples Folder

Includes multiple library/framework examples with nextjs and vitejs
being the first
BREAKING CHANGE: 🧨 n
✅ Closes: #242
Closes #242
Description
See https://github.com/Developer-DAO/web3-ui/issues/242
📝 Additional Information

@Dhaiwat10 @with-heart would you be able to review this?

@codingwithmanny I will absolutely review this once I have internet that's NOT 500kbps lol. Hopefully soon

@allcontributors please add @codingwithmanny for code!


Widget for Voice Command

Have the microphone on the home screen will be a +1!

+1
2015-09-19 21:39 GMT+02:00 Dario Di Maio<EMAIL_ADDRESS>
Have the microphone on the home screen will be a +1!
—
Reply to this email directly or view it on GitHub
https://github.com/souliss/soulissapp/issues/68.

+1
Il 19/set/2015 11:16 PM, "juanpintom"<EMAIL_ADDRESS>ha scritto:

+1
2015-09-19 21:39 GMT+02:00 Dario Di Maio<EMAIL_ADDRESS>
Have the microphone on the home screen will be a +1!
—
Reply to this email directly or view it on GitHub
https://github.com/souliss/soulissapp/issues/68.

—
Reply to this email directly or view it on GitHub
https://github.com/souliss/soulissapp/issues/68#issuecomment-141708198.

Had a try, is working fine. But the Widget is overwritten with the label Souliss Voice Command, for Widgets there should be an external label as per app shortcut.
Also the icon should be without the external rectangle, as is for apps on the home page


Magnet Puzzle added with correct output

Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. Your PR title can be also used in here.
Types of changes
What types of changes does your content introduce to this project?
Put an x in the boxes that apply (without "`")

[ ] Proofreading (fix spelling, grammar, punctuation, accuracy) Proofreading
[ ] New content (new section, new readme, etc)
[ ] Modifications (modifying existing content, adding new content)
[ ] Other (please describe)

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. Don't hesitate to ask if you're unsure about any of them. We're here to help! This is simply a reminder of what we will look for before merging your code.
Note: If you submit code make sure to test it

[ ] Tested any code that was added/modified in this PR
[ ] Added the necessary explanation
[ ] I have added the necessary links in the working section
[ ] Added external links
[ ] Added internal links
[ ] Added images
[ ] Added videos
[ ] Added code snippets

Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
Adding your name in the contributors list
Comment "@all-contributors please add @your_username for content" to add your name in the contributors list.
You can change the "content" with any of this
Reviewers:

[ ] @username

If you adding code, please make sure that you are not adding any sensitive information like API keys, secrets, passwords, tokens, usernames, or other credentials. Refrain from adding your name, email, or other personal information to the code.

@SohamDey80 you don't have create a new pr for every commit. You can just change the code and push to branch that is on PR. In your case it's the main branch. Nevertheless I am closing your previous pr. And adding this.


Spec type fixes: hsl hsv hwb

This PR aims to fix a few cases where the parser allows more than what the spec allows, such as float values where only percentages are allowed. See the individual commits for details.

Note that in addition to this PR, I also have a branch with fixes for Lab/LCH which I can submit later as it is based on these changes.


Ambassador module configuration flag to enable diagnostics

Addressing https://github.com/datawire/ambassador/issues/354 and piggybacking on https://github.com/datawire/ambassador/pull/355 .
Leaving the existing behavior as-is: the diagnostic dashboard routes on the service port is enabled by default.
For security reasons we do need to disable it in production, as not to expose active configurations to attackers and allowing them to change the log level.

Hey @alexgervais, can you modify one of the e2e tests to test this? I'd like to include it -- thanks!

I did a quick check and given the widespread usage of check_diag in end-to-end tests, I think it'll take me a little while to figure out how to tackle this test and refactoring... :/

Make a local check_diag for one test that uses kubectl exec to run the curl on the Ambassador pod? That shouldn't be too bad, and should work just fine.

@kflynn is this good to go?

@alexgervais I'm going to take it after I get 0.33.0 get (long story, working on the release process for Ambassador). I'll probably add a negative test - to make sure that you cannot actually reach the diag service through Ambassador - after that, unless you want to.
Sorry for the delay!


added /users route

Two new routes!

/users lists all users in a site, and allows creating new users
/users:name gives data for an individual user, and allows updating and deleting individual users

Notes:

:name is the automatically-generated ID you get when creating a user. Uses the same UID generator as component instance IDs.
After this I'll start adding oauth stuff that uses the user data

👎  some things in here need to change for auth. I'm gonna roll this up into that PR instead.


Worker memory steadily increases when Ingress controller is trying to push a bad config

Summary
I have Kong 2.0.2 (also seen with 1.5.1) deployed with the ingress controller 0.7.1. In a case where the ingress controller is trying to submit a "bad" config, the nginx worker memory usage steadily increases until hitting the cgroup memory limit and getting terminated by the OOM killer.
It doesn't seem to particularly matter how you break the config, as long as the ingress controller is trying over and over to sync the config. The moment that the config is fixed and the ingress controller stops trying to continuously sync the config, the memory usage levels off.
Both an OOM event and the moment that I fixed the config are pretty clear in this graph:

Steps To Reproduce

Deploy kong with ingress controller
Create a "bad" config
Watch memory usage climb

Additional Details & Logs
Workers getting killed:
2020/03/26 20:04:16 [notice] 1#0: start worker process 28
2020/03/26 20:04:16 [notice] 1#0: start worker process 29
...
2020/03/26 20:12:22 [notice] 1#0: signal 17 (SIGCHLD) received from 29
2020/03/26 20:12:22 [alert] 1#0: worker process 29 exited on signal 9
2020/03/26 20:12:22 [notice] 1#0: start worker process 30
2020/03/26 20:12:22 [notice] 1#0: signal 29 (SIGIO) received
2020/03/26 20:17:11 [notice] 1#0: signal 17 (SIGCHLD) received from 28
2020/03/26 20:17:11 [alert] 1#0: worker process 28 exited on signal 9
2020/03/26 20:17:11 [notice] 1#0: start worker process 31
2020/03/26 20:17:11 [notice] 1#0: signal 29 (SIGIO) received
2020/03/26 20:22:45 [notice] 1#0: signal 17 (SIGCHLD) received from 30
2020/03/26 20:22:45 [alert] 1#0: worker process 30 exited on signal 9
2020/03/26 20:22:45 [notice] 1#0: start worker process 32
2020/03/26 20:22:45 [notice] 1#0: signal 29 (SIGIO) received

Example bad config error from ingress controller:
E0326 19:27:56.322072       1 controller.go:119] unexpected failure updating Kong configuration:
posting new config to /config: 400 Bad Request {"fields":{"consumers":[{"basicauth_credentials":[{"@entity":["all or none of these fields must be set: 'password', 'consumer.id'"]}]},{"basicauth_credentials":[{"@entity":["all or none of these fields must be set: 'password', 'consumer.id'"]}]},{"basicauth_credentials":[{"@entity":["all or none of these fields must be set: 'password', 'consumer.id'"]}]}]},"name":"invalid declarative configuration","code":14,"message":"declarative config is invalid: {consumers={{basicauth_credentials={{[\"@entity\"]={\"all or none of these fields must be set: 'password', 'consumer.id'\"}}}},{basicauth_credentials={{[\"@entity\"]={\"all or none of these fields must be set: 'password', 'consumer.id'\"}}}},{basicauth_credentials={{[\"@entity\"]={\"all or none of these fields must be set: 'password', 'consumer.id'\"}}}}}}"}

@agaffney Thank you for reporting! We will try to reproduce this on our and and report back the results!

If you need a config for the ingress controller that should reproduce this, the one from https://github.com/Kong/kubernetes-ingress-controller/issues/587 should work

As a side note, this also seems to happen during periods with a lot of config churn, such as adding a bunch of new Ingress/KongPlugin resources over a ~30 minute period.


HTTPStatusError: Failed to fetch Vehicle Features

Describe the issue
I have two vehicles in my account, one of which is quite old and doesn't really support anything of value via the app/api. However, there doesn't seem to be a way to skip a vehicle as unsupported while still supporting others.
The logs I've attached are from running the cli status command.
If I modify the code to skip the unsupported VIN, everything works fine.
Expected behavior
I would expect to be able to still load my supported vehicle details, and either skip the unsupported vehicle or show the few details available and that it's unsupported.
Which Home Assistant version are you using?
core-2023.6.0
What was the last working version of Home Assistant Core?
No response
What is your region?
North America
MyBMW website

[X] I can still successfully login to the BMW MyBMW website and the car status is available there.
[X] I have MyBMW enabled for my vehicle.

Number of cars

[X] I have 2 or more cars linked to the MyBMW account.
[ ] I have a Mini vehicle linked to my account.

Output of bimmer_connected fingerprint
No response
Anything in the logs that might be useful for us?
DEBUG:httpcore:http11.receive_response_body.started request=<Request [b'GET']>
DEBUG:httpcore:http11.receive_response_body.complete
DEBUG:httpcore:http11.response_closed.started
DEBUG:httpcore:http11.response_closed.complete
ERROR:bimmer_connected.api.client:MyBMW API error: HTTPStatusError: Failed to fetch Vehicle Features.
DEBUG:httpcore:connection.close.started
DEBUG:httpcore:connection.close.complete
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.11/site-packages/bimmer_connected/api/client.py", line 72, in raise_for_status_event_handler
    response.raise_for_status()
  File "/srv/homeassistant/lib/python3.11/site-packages/httpx/_models.py", line 749, in raise_for_status
    raise HTTPStatusError(message, request=request, response=self)
httpx.HTTPStatusError: Server error '500 Internal Server Error' for url 'https://cocoapi.bmwgroup.us/eadrax-vcs/v4/vehicles/state?apptimezone=1200.0&appDateTime=1686193717192'
For more information check: https://httpstatuses.com/500

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/srv/homeassistant/bin/bimmerconnected", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/srv/homeassistant/lib/python3.11/site-packages/bimmer_connected/cli.py", line 356, in main
    loop.run_until_complete(args.func(args))
  File "/usr/local/lib/python3.11/asyncio/base_events.py", line 653, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/srv/homeassistant/lib/python3.11/site-packages/bimmer_connected/cli.py", line 138, in get_status
    await account.get_vehicles()
  File "/srv/homeassistant/lib/python3.11/site-packages/bimmer_connected/account.py", line 98, in get_vehicles
    state_response = await client.get(
                     ^^^^^^^^^^^^^^^^^
  File "/srv/homeassistant/lib/python3.11/site-packages/httpx/_client.py", line 1757, in get
    return await self.request(
           ^^^^^^^^^^^^^^^^^^^
  File "/srv/homeassistant/lib/python3.11/site-packages/httpx/_client.py", line 1530, in request
    return await self.send(request, auth=auth, follow_redirects=follow_redirects)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/homeassistant/lib/python3.11/site-packages/httpx/_client.py", line 1617, in send
    response = await self._send_handling_auth(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/homeassistant/lib/python3.11/site-packages/httpx/_client.py", line 1645, in _send_handling_auth
    response = await self._send_handling_redirects(
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/homeassistant/lib/python3.11/site-packages/httpx/_client.py", line 1703, in _send_handling_redirects
    raise exc
  File "/srv/homeassistant/lib/python3.11/site-packages/httpx/_client.py", line 1685, in _send_handling_redirects
    await hook(response)
  File "/srv/homeassistant/lib/python3.11/site-packages/bimmer_connected/api/client.py", line 74, in raise_for_status_event_handler
    await handle_httpstatuserror(ex, log_handler=_LOGGER)
  File "/srv/homeassistant/lib/python3.11/site-packages/bimmer_connected/api/utils.py", line 79, in handle_httpstatuserror
    raise _ex_to_raise(_err_message) from ex
bimmer_connected.models.MyBMWAPIError: HTTPStatusError: Failed to fetch Vehicle Features.

Additional information
No response

Could you provide a fingerprint from the CLI?
Maybe there is some information in the vehicle overview on which we can ignore vehicles.

Adjusting the library to be more resilient with errors is something I have planned, but not found the time to look into yet.
My car is even older than yours and still works.
One thing is weird with your request: your apptimezone parameter is 1200.0, meaning UTC+20 (which doesn't exist). Could you double check the time zone of your device?

everything works fine for my other car though. in the meantime, I have removed the unsupported car from my account as a workaround.
assuming timezones would wrap around, UTC+20 sounds about right since I'm in EDT, which is UTC-4


Add Laravel Gentelella support

Add PHP / Laravel 5 boilerplate project with Gentelella Admin theme support

Yaaass! :100:


Add features to send data.

1.Add string and array supported to send data(sendString).
2.Use encodeURIComponent to avoid potential problems caused by some special characters (Like + and whitespace).
Just let me know  if  anything inappropriate. :smiley:

@mc-zone  I'll merge it after checking ASAP , Thanks for the pull request ! :+1:

Looks cool to me :+1:


Custom gulp build with --types=Pie, Pie is not a function?

I'm trying to build a custom version of the library with just the Pie chart but it doesn't seem to be working.  My gulp task runs fine with:
gulp build --types=Pie
But when I try to draw a chart with:
var chart = new Chart(myChart).Pie(chartData, pieOptions);
I get Pie is not a function.  I tried adding Core to the types but it doesn't help.  Any ideas what I'm missing with the gulp build?

Use --types=Doughnut. Pie is just a special case of Doughnut (with cutoutPercentage = 0).

This works perfectly!  Thank you.


Devices use case

Still room for improvement... but in the spirit of shipping and continual improvement...

I'm also still getting errors on the deploy preview

I'm also still getting errors on the deploy preview

Interestingly, the presence of ThemeContext.Extend seems to cause this issue. Investigating...


& behavior is WRONG!

Problem
After applied to my project, I've found out that this function
https://github.com/rootEnginear/svelte-action-motionone/blob/ac963c726ad058a47e30564911cda847e69c490d/src/lib/utils/selector.ts#L3-L8
is so SO WRONG! — let's look at it from case by case.
&>* (child combinator)
In this case, it will be evaluated to { isSelf: false, selector: "*" } which is WRONG! Because * means EVERYTHING, not only the direct children.
& *, &+*, &~* (descendant, next-sibling, subsequent-sibling combinator)
In this case, it will be passed to Motion (or select directly from document in getNodeElement) since it's neither a single & nor pass the /^\s*&\s*>/, hence the result from parseStringSelector is { isSelf: false, selector: "& *" }
The (easy) solution is just make the behavior correct and call it a day, for now.

Fixed in v0.5.0!


error: Argument 1 to "astype" of "Series" has incompatible type "dtype[generic] | ExtensionDtype"; expected "type[object] | ExtensionDtype"  [arg-type]

Describe the bug
Series.dtype is incompatible with Series.astype
To Reproduce
import pandas as pd

s = pd.Series([1, 2, 3])
s = s.astype(s.dtype)  # ✘ [arg-type]

Please complete the following information:

OS: Ubuntu 22.04
python version 3.10
mypy 1.4.1
pandas                        2.0.3
pandas-stubs                  <IP_ADDRESS>605

I think if we replace
https://github.com/pandas-dev/pandas-stubs/blob/8d5a8279d448afa188f5160e7fe787c1fcb6015e/pandas-stubs/_typing.pyi#L195
with DtypeObj (and move the definition of DtypeObj above AstypeObj, then this error would get fixed.


I had an error compiling a program using SFML-2.5.1 in Linux

./SFML-2.5.1/include/SFML/System/Thread.inl:48:25: ERROR：expression cannot be used as a function
virtual void run() {m_function(m_arg);}
My error message is like this, how should I solve it?
My linux is Centos7.9 ,and I installed glibc2.18 and libstdc++ so.6.0.22, but I still reported thread. Inl error .
I use gcc like { g++ -I ./SFML-2.5.1/include/ -I . -L ./SFML-2.5.1/lib/ -std=c++11 -o ./a.out ./*.cpp}.
If you know how to solve it, I would be very grateful.

Please use the forum or join Discord if you need help with using SFML, as we like to use the issue tracker for confirmed issues.
What's your code exactly?
Side note: The C++ files should be listed before the library linking.


Add keep alive to tcp plugin

Which issue(s) this PR fixes:
Fixes #3960
What this PR does / why we need it:
TCP keepalive should be supported by in_tcp to avoid dead connection, as same as in_forward
Docs Changes:
send_keepalive_packet should be added to https://docs.fluentd.org/input/tcp
Release Note:
Same with the title

@fujimotos could you please approve running the workflows?

@dimitarKiryakov Thank you for contribution!

TCP keepalive should be supported by in_tcp to avoid dead connection, as same as in_forward

I eyeballed your patch. It seems good, but I want to do a bit of more
testing on it tomorrow. Wait for me.

@fujimotos Thanks a lot for your help on this. This feature is very crucial for us as it will mitigate the issue of dead connections. I think that the currently failing tests are not related to my change. Did you manage to test it?
Thank you a lot!

Here is how I tested this patch. First, I created a simple TCP server
using the configuration attached below:
$ fluentd -c tcp.conf

I initiated a TCP connection to the server in another terminal, and kept
it open for a while:
$ telnet localhost 9000

Then I monitored the network stream using tcpdump:
$ tcpdump
...
14:20:21.470600 IP <IP_ADDRESS>.40446 > <IP_ADDRESS>.9000: Flags [.], ack 1, win 512, options [nop,nop,TS val<PHONE_NUMBER> ecr<PHONE_NUMBER>], length 0
14:21:22.182178 IP <IP_ADDRESS>.9000 > <IP_ADDRESS>.40446: Flags [.], ack 1, win 512, options [nop,nop,TS val<PHONE_NUMBER> ecr<PHONE_NUMBER>], length 0
14:21:22.182196 IP <IP_ADDRESS>.40446 > <IP_ADDRESS>.9000: Flags [.], ack 1, win 512, options [nop,nop,TS val<PHONE_NUMBER> ecr<PHONE_NUMBER>], length 0
14:22:23.622148 IP <IP_ADDRESS>.9000 > <IP_ADDRESS>.40446: Flags [.], ack 1, win 512, options [nop,nop,TS val<PHONE_NUMBER> ecr<PHONE_NUMBER>], length 0

As shown above, keepalive packets are being transmitted after some
period of inactivity. So I believe the feature is working as expected.
tcp.conf
<source>
  @type tcp
  port 9000
  format none
  tag "test.log"
  send_keepalive_packet true
</source>
<match test.**>
  @type stdout
</match>

Merged via 66c4a8b4031.
Note: I described more details in the commit message and also
added a little tweak to the test case.


added script cards to index

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

BingAds/index.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Make sure referenced chunks are not GC'ed

https://github.com/prometheus/tsdb/pull/224 is a result of referenced chunks being GC'ed. Another place with the workaround for this: https://github.com/prometheus/tsdb/blob/f1512a368acb6e596a219f7f5322cd59bfbd4ecf/head.go#L1296-L1298
Not a trivial fix.

dupe of #182


pixi global install does not allow version specifications in 0.26.x

Checks

[X] I have checked that this issue has not already been reported.

[X] I have confirmed this bug exists on the latest version of pixi, using pixi --version.

Reproducible example
❯ pixi --version
pixi 0.26.1
❯ pixi global install numpy=2.0.1
  × 'numpy=2.0.1' is not a valid package name. Package names can only contain 0-9, a-z, A-Z, -, _, or .

Ignore that numpy isn't a good example for global install. It happens with other packages too :
❯ pixi global install bat=0.24.0
  × 'bat=0.24.0' is not a valid package name. Package names can only contain 0-9, a-z, A-Z, -, _, or .

Issue description
pixi global install fails when the package has a version specified. This does not happen on versions <= 0.25.0.
Expected behavior
Previous versions allowed a version specification during global install. I see no reason to continue allowing version specifications for global installs.

My current work-around is to install pixi v0.25.0 binary as pixi-0.25.0 and use that for global installs that need a version specified.
❯ ./pixi-0.25.0 global install kneaddata=0.12.0
✔ Installed package kneaddata 0.12.0 pyhdfd78af_1 from bioconda
  These executables are now globally available:
   -  kneaddata_trf_parallel
   -  kneaddata
   -  kneaddata_bowtie2_discordant_pairs
   -  kneaddata_database
   -  kneaddata_build_database
   -  kneaddata_read_count_table
   -  kneaddata_test

Thanks for reporting! We will fix this. As a workaround try adding spaces: "numpy 2.0.1"

Thanks for reporting! We will fix this. As a workaround try adding spaces: "numpy 2.0.1"

Looks like that uncovers another bug:
❯ pixi global install bat 0.24.0
✔ Installed package bat 0.24.0 he8a937b_0 from conda-forge
  × Cannot solve the request because of: No candidates were found for 0.24.0 *.
  │

Youll need to add quotes!

Youll need to add quotes!
pixi global install "bat 0.24.0"

❯ pixi global install "bat 0.24.0"
  × 'bat 0.24.0' is not a valid package name. Package names can only contain 0-9, a-z, A-Z, -, _, or .

Quotes works on previous versions though:
❯ ./pixi-0.25.0 global install "bat 0.24.0"
✔ Installed package bat 0.24.0 he8a937b_0 from conda-forge
  These executables are now globally available:
   -  bat

Haha Im sorry, its currently missing an operator, try:
pixi global install "bat =0.24.0"
Ill take a better look next week. Parsing and the error messages can definitely be improved.

Haha Im sorry, its currently missing an operator, try:
pixi global install "bat =0.24.0"
Ill take a better look next week. Parsing and the error messages can definitely be improved.

Still broken on the latest version, but works on the previous:
❯ pixi global install "bat =0.24.0"
  × 'bat =0.24.0' is not a valid package name. Package names can only contain 0-9, a-z, A-Z, -, _, or .

❯ ./pixi-0.25.0 global install "bat =0.24.0"
✔ Installed package bat 0.24.0 he8a937b_0 from conda-forge
  These executables are now globally available:
   -  bat


Live runner environment to interactively run terraform commands.

Howdy!
We are using a finicky terraform provider that bails whenever the remote resources have been deleted outside of terraform.
Ideally this should be fixed in the provider to just recreate the resources but this got me thinking that it might be useful to have a live pod where we can exec inside and run terraform commands (specifically terraform state ... ones).
The use cases I have in mind are mainly:

remove terraform resources from the state
move terraform resources around (for refactoring)

Currently the process is a bit awkward:

pause the reconciliation of the terraform object
get the state (as documented)
run terraform commands
upload the changed state (as documented)
resume the reconciliation

I have tried to set spec.alwaysCleanupRunnerPod: false and exec in the runner but I can't find the manifests and it does not have the secrets mounted (maybe I'm missing something?).

Thank you @elisiano

Currently the process is a bit awkward:
pause the reconciliation of the terraform object
get the state (as documented)
run terraform commands
upload the changed state (as documented)
resume the reconciliation

Yes, we would also encapsulate these steps into a command to help the debugging process.

I have tried to set spec.alwaysCleanupRunnerPod: false and exec in the runner but I can't find the manifests and it does not have the secrets mounted (maybe I'm missing something?).

We are locked down by Kubernetes' security for some reasons, yes. Me too; I exec into the pod and didn't find any manifest.
But for the Secrets, we're trying to be as secure as possible by design. There are no secrets mounted into the pod. We obtained them via API, so there are no secrets for you to see there.

Besides the tf.state, the tfctl command could also help into extracting the current variables configured on the cluster and referenced in Terraform CR in  into a terraform.tfvars.json local file
I've used the following (ugly!) command as a workaround to extract the variables from the Terraform CR (without yet dealing with the varsFrom)
k get terraform terraform -o yaml | yq '.spec.vars| map({ (.name): .value})' | grep TF_VAR | sed 's/TF_VAR_//' | yq -o json | jq 'add'  > terraform.tfvars.json
then I can run terraform init && terraform plan

@elisiano - This functionality is now being provided by the break-glass mode - please can you try that out, and let us know if it meets your requirements?

Closing in light of previous comment -- the ask has been addressed.


Add isComponentOpened method

Hi, I would like to programming open menu by myself, like this.
Usage:
- (IBAction)buttonClick:(id)sender {
    if (![self.navBarMenu isComponentOpened]) {
        [self.navBarMenu openComponent:0 animated:YES];
    } else {
        [self.navBarMenu closeAllComponentsAnimated:YES];
    }
}

but I cannot have the status to determine it when open or close.
so I add a method, please take a look, thanks.

I notice that travis-ci build failed. I just ignored that error?

Hi @j796160836
I think rather than adding the -isComponentOpened method we should just expose the selectedComponent property, which would cover more use-cases.
For the CI, I think travis has some issues with Xcode 8 builds, I'll need to figure out.
Also looks like you have pushed your own project changes to this pull request, you'll have to discard them on this branch to make it work.

Added the selectedComponent property in v1.3.1

Hi Max,
I haven't noticed that pull request branch and own use branch are same. I should make a independent branch for you, Sorry.
Yeah, I forked do the small modify for your great module. My use-case is using this dropdown drawer and putting my custom view there. That is why having following commit there.
I stripped out the TableView and simplify the code there because I just use one cell for that.
Anyway, it works great, Thanks.


Annual Assessment Pentesting starts 1/29 (50% complete)

In order to meet the March 17, 2024, Annual Assessment delivery for cloud.gov to the Joint Authorization Board (JAB) and maintain our Provisional Authority to Operate (P-ATO), we must provide interviews to the third-party assessment organization (3PAO) SecureIT to conduct Penetration Testing.
Security considerations
None

50% complete


Network Refactor

In response to concerns Re: network performance, especially when loading chunks (#2139), I've rewritten most of the logic around network formation, splitting and similar. Anyone who comes across this and feels like being helpful, please test the release here for any bugs, crashes, or other oddnesses that seem related to network things. @aidancbrady, there's a chance I've failed at merging in some of the changes you've made to transmitters in the past week or so, please take a look when you have a chance and let me know if there's anything I've missed. @halvors, you seem like you know what you're doing, and you seem to be good at finding issues. I know you were having issues with network lag, so try out the release and see if it helps the situation. Of course, also let me know if I broke anything.

Also, if it turns out this makes performance way worse, let me know about that as well, and I'll scrap this whole thing.

This changeset contains significant changes to the API, but there's only one place I'm aware of that these changes broke any other mods. I've now rectified this in the development branch.


Login to dashboard is super slow

Steps:
Clean install of develop branch
Logout
Click login link
Enter in login info and submit
Wait 25 seconds for page to load.
There have been a few reports of this, and I can replicate it locally.

This is because we're pulling data from marketplace and other sources on first load, and it can be slow. To mitigate this we need to implement https://github.com/concrete5/concrete5/issues/4650

Another cause of this could be that we render the welcome page twice:
here we render concrete/single_pages/dashboard/welcome.php and immediately after we render concrete/themes/dashboard/desktop.php.
BTW those two view files are almost identical...

Interesting. Yeah, we need to fix this.


add custom does not fail on uninitialized projects

Before opening, please confirm:

[X] I have installed the latest version of the Amplify CLI (see above), and confirmed that the issue still persists.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

How did you install the Amplify CLI?
npm
If applicable, what version of Node.js are you using?
14
Amplify CLI Version
7.x
What operating system are you using?
macos
Amplify Categories
Not applicable
Amplify Commands
add
Describe the bug
In an empty folder amplify add custom does not fail early.

Expected behavior
fail with project the error before asking any prompts.
Reproduction steps

mkdir foo
cd foo
amplify add custom

GraphQL schema(s)

# Put schemas below this line

Log output

# Put your logs below this line

Additional information
No response

Yes, it's a requirement to do "amplify init" for adding any Amplify resources. Is the ask here to show the message at the start rather than showing after two questions?

May I work on this please? Thanks


Exercise 6 verify wrong

I ran the verification of my solution twice, once thru sudo and once without. Both times, my solution seemed to work, but the verification step failed.
❯ expressworks verify index.js
Verifying "PARAM PAM PAM"...

ACTUAL                             EXPECTED
------                             --------
"663918365c1cf4aa90e1b997464837eeb216ff69" != "Cannot PUT /message/3f0a916de79d2a84e747342296f9ddb8"
# FAIL

Your solution to PARAM PAM PAM didn't match the expected output.
Try again!
❯ sudo expressworks verify index.js
Password:
Verifying "PARAM PAM PAM"...

ACTUAL                             EXPECTED
------                             --------
"467e7714bb0b77755e016a3737d2b8d961a3bd45" != "Cannot PUT /message/fd42373de17b40c04517a6e4c956778d"
# FAIL

Your solution to PARAM PAM PAM didn't match the expected output.
Try again!

My code (slightly different than the provided solution, but the same in spirit):
"use strict";

var express = require("express");
var crypto = require("crypto");

var app = express();
var port = process.argv[2];

app.put("/message/:id", function(req, res) {
    var id = req.params.id;
    var date = crypto.createHash("sha1").update(new Date().toDateString() + id).digest("hex");
    res.end(date);
});

app.listen(port);

I tried removing "use strict" as well as changing res.end(date) to res.send(date) to see if either was causing the verification script to fail to execute, but neither step resolved anything.

#58


async/ non-blocking tween calculation

since the tween calculation is very slow, it would be nice if it was async, ran in another web-worker

This feature is real cool indeed, just I don't have the time to develop.

understandable :)
i dont have time to dig through this package, but i managed to tuck together an fromToAsync without touching your code ;)
interface.ts
export interface TweenResultMessage {
	error?: String;
	data?: KUTE.Tween;
}

export interface TweenInputMessage {
	elem: Element;
	from: KUTE.tweenProps;
	to: KUTE.tweenProps;
	opts?: KUTE.tweenOptions;
}

morphWorker.ts
import KUTE from 'kute.js';
import type {TweenInputMessage, TweenResultMessage} from './interface';

onmessage = (e:MessageEvent<TweenInputMessage>):void => {
  const {elem, from, to, opts} = e.data;
  try {
    const tween = KUTE.fromTo(elem, from, to, opts)
    postMessage({data: tween} as TweenResultMessage);
  } catch (error) {
    postMessage({error} as TweenResultMessage);
  }
};

export {};

KUTEAsync.ts
import TweenCalculationWorker from "./morphWorker?worker";
import type {TweenInputMessage, TweenResultMessage} from './interface';
import type KUTE from "kute.js";

const fromToAsync = (elem:Element, from:KUTE.tweenProps, to:KUTE.tweenProps, opts:KUTE.tweenOptions):Promise<KUTE.Tween> => {
    const worker = new TweenCalculationWorker();
    worker.postMessage({elem, from, to, opts} as TweenInputMessage);
    return new Promise((resolve, reject) => {
        worker.onmessage = (e:MessageEvent<TweenResultMessage>) => {
            const m = e.data;
            if (m.error) reject(m.error);
            else resolve(m.data);
        }
    });
}

export default {fromToAsync};

Usage
import KUTEA from 'KUTEAsync'
const tween = KUTEA.fromToAsync(...args);

Wow you are awesome! Thanks for that!


builder: use new abstraction to guarantee alignment

Before this PR, both builder structs (HeaderBuilder, BootInformationBuilder) build their corresponding structures in a Vec<u8>. However, there is no guarantee of an 8-byte alignment in that case. As long as the allocator_api is not stable, I chose the following workaround:
Use a regular Vec<u8> with a capacity of expected_len + 7. This way, I can add zeroes at the beginning to the vec for alignment adjustments. A wrapper type returns a slice to the actual and aligned bytes of the corresponding structure, i.e, the wrapper type knows an offset between 0 and 7 where the structure actually starts.
The only problem with this type: I can't create a reliable unit test for the alignment offsetting magic. I created a local test run using the allocator_api and a "weird" (unaligned) pointer from the allocator and everything worked as expected. I tested the new code with miri and miri reported no allocation or alignment errors 🥳

@YtvwlD I'm curious. Did you encountered problems with the builder in your project due to alignment issues?
If the allocator "is friendly", you might never have encountered any problems.

Ah, interesting. On Windows, the allocator triggered one of my new assertions
https://github.com/rust-osdev/multiboot2/actions/runs/5344793550/jobs/9689626355?pr=156

Strictly speaking, the Vec -> Box conversion is overkill. I could also keep the vector in the byte wrapper.

I did not encounter any errors yet. But you're right: According to the spec the struct should be 8-byte aligned.


Finish Week 4 Tasks

finish unit test tutorial and Calendar task(pass all unit tests).

Modify according to comment

Modify according to comment


Corrected H1 Title and added link to Reddit

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

LGTM

Congrats @natiapreutesei  on your first pull request (PR)! 🎉
Thank you for your contribution to the page! 👍
We're happy to accept these changes, and look forward to future contributions. 📝


fix mailIssueCommentBatch for pull request

fix #14250

Codecov Report

Merging #14252 (d2e77ad) into master (126c933) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #14252   +/-   ##
=======================================
  Coverage   41.97%   41.97%
=======================================
  Files         735      735
  Lines       78933    78936    +3
=======================================
+ Hits        33132    33134    +2
  Misses      40346    40346
- Partials     5455     5456    +1

Impacted Files
Coverage Δ

services/mailer/mail_issue.go
63.95% <100.00%> (+1.30%)
:arrow_up:

modules/util/timer.go
42.85% <0.00%> (-42.86%)
:arrow_down:

modules/log/event.go
59.90% <0.00%> (+0.94%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 126c933...d2e77ad. Read the comment docs.

Codecov Report

Merging #14252 (d2e77ad) into master (126c933) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #14252   +/-   ##
=======================================
  Coverage   41.97%   41.97%
=======================================
  Files         735      735
  Lines       78933    78936    +3
=======================================
+ Hits        33132    33134    +2
  Misses      40346    40346
- Partials     5455     5456    +1

Impacted Files
Coverage Δ

services/mailer/mail_issue.go
63.95% <100.00%> (+1.30%)
:arrow_up:

modules/util/timer.go
42.85% <0.00%> (-42.86%)
:arrow_down:

modules/log/event.go
59.90% <0.00%> (+0.94%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 126c933...d2e77ad. Read the comment docs.


Added loader

Added loader to page so page is not empty while website gets data from API

Added loader to page so page is not empty while website gets data from API


feat(editor): add autosave configuration

This add an autosave-interval key to editor config, allowing to set up autosave.
The config setting default to zero, which disable auto-saving.
Closes #248

Very nice, thank you!
On the other hand, I don't think configurability makes much sense here. A 1s delay should be good enough and allowing 1ms (which basically means save every keystroke) might be a bit harsh on flash storage, as well as probably a bad UX on spinning drives. But maybe I'm wrong :)

On the other hand, I don't think configurability makes much sense here.

I think it's reasonable to provide that config. VSCode also gives option to set it to 1ms

VSCode also gives option to set it to 1ms

We only need to take what's actually good, though :) But if you think it's reasonable, I won't argue much.


Make site extension not use SemVer 2.0

Still a work in process. There are some oddities in how versions numbers flow, so my attempt at this locally may not work.
I'm building this locally at the moment. Builds are slow so multiplexing verification.

Aight, this is now actually working.

Running an internal build as PR version don't have semverv2.

if i can help test/validate let me know.

The versions look correct to me here: https://dev.azure.com/dnceng/internal/_build/results?buildId=242559&view=results. @bradygaster can you validate this?


Implement old API version setting test

Implement https://github.com/Azure/cadl-ranch/pull/555 from cadl-ranch

Fixed by https://github.com/Azure/autorest.java/pull/2695


Authorized OAuth apps are not listed in the dashboard as expected

Version: 5.9.0 RC2
Scenario:

Create a few OAuth apps and try the authorization grant or implicit flow. Do not exchange the code for a token.
In the consent screen, select the "Approve Always" options
Log in to the user dashboard and view the approved authorized apps gadget

(No authorized apps will be displayed)

Exchange the code for a token and then check the approved authorized apps gadget

Revoke the token and then check the gadget again. You will see that the list will be empty.

This behaviour is incorrect since in the next authorization code you will not be prompted for consent. So unless an app has an active token, the end-user cannot revoke the consent given to the app which is not correct.
A user should be able to revoke the consent given to an app anytime regardless of whether the app has obtained a token using the provided consent or not.

Closing the issue since the dashboard application is not shipped with the product anymore.

Have we verified this behaviour with the new user portal?

I have checked in the latest restAPIs and the behavior is still the same. We need to improve the logic.
https://is.docs.wso2.com/en/5.10.0/develop/authorized-apps-rest-api/#/me/listLoggedInUserAuthorizedApps

I have checked in the latest restAPIs and the behavior is still the same. We need to improve the logic.
https://is.docs.wso2.com/en/5.10.0/develop/authorized-apps-rest-api/#/me/listLoggedInUserAuthorizedApps


How to use deepspeed zero3 with cpu offload?

Please check that this issue hasn't been reported before.

[X] I searched previous Bug Reports didn't find any similar reports.

Expected Behavior
Working
Current behaviour
Using the following config:
{
  "bf16": {
    "enabled": true
  },
  "optimizer": {
    "type": "AdamW",
    "params": {
      "lr": "auto",
      "betas": "auto",
      "eps": "auto",
      "weight_decay": "auto"
    }
  },
  "scheduler": {
    "type": "WarmupLR",
    "params": {
      "warmup_min_lr": "auto",
      "warmup_max_lr": "auto",
      "warmup_num_steps": "auto"
    }
  },
  "zero_optimization": {
    "stage": 3,
    "offload_optimizer": {
      "device": "cpu",
      "pin_memory": true
    },
    "offload_param": {
      "device": "cpu",
      "pin_memory": true
    },
    "overlap_comm": true,
    "contiguous_gradients": true,
    "sub_group_size": 1e9,
    "reduce_bucket_size": "auto",
    "stage3_prefetch_bucket_size": "auto",
    "stage3_param_persistence_threshold": "auto",
    "stage3_max_live_parameters": 1e9,
    "stage3_max_reuse_distance": 1e9,
    "stage3_gather_16bit_weights_on_model_save": true
  },
  "gradient_accumulation_steps": "auto",
  "gradient_clipping": "auto",
  "steps_per_print": 2000,
  "train_batch_size": "auto",
  "train_micro_batch_size_per_gpu": "auto",
  "wall_clock_breakdown": false
}

I get eval loss = nan or loss = 0 after a few steps of training.
Steps to reproduce

Mistral 7B model full tune
Open hermes 2.5 dataset

Config yaml
base_model: /home/layla/src/text-generation-webui/models/Mistral-7B-v0.1
base_model_config: /home/layla/src/text-generation-webui/models/Mistral-7B-v0.1
model_type: MistralForCausalLM
tokenizer_type: LlamaTokenizer
is_mistral_derived_model: true

load_in_8bit: false
load_in_4bit: false
strict: false

datasets:
  - path: /home/layla/src/Layla-datasets/datasets_formatted/base/dailydialog.topicalchat.openhermes.jsonl
    ds_type: json # see other options below
    type: sharegpt
    conversation: vicuna_v1.1

# datasets:
#   - path: /home/layla/src/Layla-datasets/datasets_formatted/airoboros_alpaca.jsonl
#     type: alpaca

dataset_prepared_path: last_run_prepared
val_set_size: 0.002
output_dir: ./out

sequence_len: 8192
sample_packing: true
pad_to_sequence_len: true

wandb_project:
wandb_entity:
wandb_watch:
wandb_run_id:
wandb_log_model:

gradient_accumulation_steps: 4
micro_batch_size: 2
num_epochs: 1
optimizer: adamw_bnb_8bit
lr_scheduler: cosine
learning_rate: 0.0000005

train_on_inputs: false
group_by_length: false
bf16: true
fp16: false
tf32: false

gradient_checkpointing: true
early_stopping_patience:
resume_from_checkpoint:
local_rank:
logging_steps: 1
xformers_attention:
flash_attention: true

warmup_ratio: 0.05
eval_steps: 0.1
eval_table_size:
eval_table_max_new_tokens: 128
eval_sample_packing: false
save_steps: 100
debug:
deepspeed: /home/layla/src/Layla-datasets/axolotl/configs/deepspeed/zero3_cpuoffload.json # multi-gpu only
weight_decay: 0.0
fsdp:
fsdp_config:
special_tokens:
  bos_token: "<s>"
  eos_token: "</s>"
  unk_token: "<unk>"

Possible solution
No response
Which Operating Systems are you using?

[X] Linux
[ ] macOS
[ ] Windows

Python Version
3.11
axolotl branch-commit
2d65f470d54986f2df542cb8332e31113c04112d
Acknowledgements

[X] My issue title is concise, descriptive, and in title casing.
[X] I have searched the existing issues to make sure this bug has not been reported yet.
[X] I am using the latest version of axolotl.
[X] I have provided enough information for the maintainers to reproduce and diagnose the issue.

Are you sure it's due to cpu offload? Can you try use the regular ds3_bf16

Hi, in Axolotl there are now preset deepspeed zero3 config jsons within the directory deepspeed_configs/ , some of which takes care of CPU offload: https://github.com/axolotl-ai-cloud/axolotl/tree/main/deepspeed_configs


Take a look at booru yolo

cc https://github.com/aperveyev/booru_yolo

closed as completed in #105


Fix logic for constraining variables based on dataElementDependencyOrder

The previous logic used was incorrect. Entities were not properly excluded based on ancestor lineage. The comments were also a bit off. This PR fixes the logic and comments.
fixes #318

Gonna review in a minute!
On Thu, Sep 16, 2021 at 6:58 PM Jamie Long @.***> wrote:

@.**** approved this pull request.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/VEuPathDB/web-eda/pull/444#pullrequestreview-756612960,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACLLH7CDII2RMMVTGZUHXTUCIV5PANCNFSM5ED2TIFA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Thanks for the feedback, @bobular. I think you're right that the variable names I chose are not very good. I will change them before merging.