[YouTube] Annotations not downloaded when --write-annotations is passed

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm requesting a site-specific feature
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
United States
Example URLs
https://youtu.be/W0FIDjx4Ig8
https://youtu.be/29-q7YnyUmY
https://youtu.be/k3LGsM_o_GU
https://youtu.be/Uqe6kxgvpms
https://youtu.be/-K9_PNRbuZg
Provide a description that is worded well enough to be understood
Annotations as a feature have long since been deprecated from YouTube. Despite this, they are still publicly available, and can be re-enabled in the browser via extensions such as "Annotations Restored for YouTube™" (Chrome, Firefox, GitHub). While the feature is no longer supported in yt-dlp (according to the bottom of the README), the --write-annotations flag no longer works, displaying a warning that there aren't any annotations, regardless the video has them or not.
Annotations are available via the Google API in XML format like this; https://storage.googleapis.com/biggest_bucket/annotations/W/W0F/W0FIDjx4Ig8.xml.gz (although the file path implies this response is compressed, none of the above videos put into the function below result in a compressed file... weird). For any given YouTube video, the URL can be formatted like so;
// this code has been sampled from:
// https://github.com/isaackd/AnnotationsRestored/blob/989ab3e5c823286f3a97beeab8c2a453294e6531/js/background.js#L6-L22
// ...licensed under the GNU General Public License v3.0
const annotationsEndpoint = "https://storage.googleapis.com/biggest_bucket/annotations";

function getAnnotationPath(videoId) {
    if (videoId.length !== 11) {
        throw new Error("Video ID must be exactly 11 characters long");
    }

    // Temporary fix for a GCS mistake
    let annotationFileDirectory = videoId[0];

    if (annotationFileDirectory === "-") {
        annotationFileDirectory = "-/ar-"
    }

    return `${annotationsEndpoint}/${annotationFileDirectory}/${videoId.substring(0, 3)}/${videoId}.xml.gz`;
}

Ideally, this XML file should be placed in the same folder as the downloaded video, with a filename such as ⧸a⧸ sings - Cruel Angels Thesis [Evangelion opening] [W0FIDjx4Ig8].annotations.xml or something similar. I've attached the UNCOMPRESSED (see above) annotations file below in case it is needed.
W0FIDjx4Ig8.xml.gz
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
D:\Videos\tube>yt-dlp -vU --embed-metadata --embed-subs --write-annotations https://www.youtube.com/watch?v=W0FIDjx4Ig8
[debug] Command-line config: ['-vU', '--embed-metadata', '--embed-subs', '--write-annotations', 'https://www.youtube.com/watch?v=W0FIDjx4Ig8']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-master-builds [5ce582448] (win_exe)
[debug] Python 3.8.10 (CPython AMD64 64bit) - Windows-10-10.0.19044-SP0 (OpenSSL 1.1.1k  25 Mar 2021)
[debug] exe versions: ffmpeg 2024-02-15-git-a2cfd6062c-full_build-www.gyan.dev (setts), ffprobe 2024-02-15-git-a2cfd6062c-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.20.0, brotli-1.1.0, certifi-2024.06.02, curl_cffi-0.5.10, mutagen-1.47.0, requests-2.32.3, sqlite3-3.35.5, urllib3-2.2.2, websockets-12.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets, curl_cffi
[debug] Loaded 1831 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp-master-builds/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp-master-builds
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp-master-builds)
[youtube] Extracting URL: https://www.youtube.com/watch?v=W0FIDjx4Ig8
[youtube] W0FIDjx4Ig8: Downloading webpage
[youtube] W0FIDjx4Ig8: Downloading ios player API JSON
[debug] [youtube] Extracting signature function js_71059424_107
[debug] Loading youtube-sigfuncs.js_71059424_107 from cache
[debug] Loading youtube-nsig.71059424 from cache
[debug] [youtube] Decrypted nsig nkZmSDO_bB8lLG4hJ => QRF6Up5wNlXEDA
[youtube] W0FIDjx4Ig8: Downloading m3u8 information
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, vcodec:vp9.2, channels, acodec, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec:vp9.2(10), channels, acodec, lang, proto, size, br, asr, vext, aext, hasaud, id
[debug] Default format spec: bestvideo*+bestaudio/best
[info] W0FIDjx4Ig8: Downloading 1 format(s): 135+140
[info] There are no subtitles for the requested languages
WARNING: There are no annotations to write.
[debug] Invoking http downloader on "https://rr5---sn-vgqsknsk.googlevideo.com/videoplayback?expire=1719971801&ei=eVuEZvKrAt2U2_gP66aC0A8&ip=2601%3A243%3A0%3A4a0%3A8cbd%3Aed34%3A7ae0%3Af6d3&id=o-AG3qBB_wCyiOS4ZQ5XItRmrp2_wLay8Pb65boJpkrJMn&itag=135&source=youtube&requiressl=yes&xpc=EgVo2aDSNQ%3D%3D&mh=Fd&mm=31%2C29&mn=sn-vgqsknsk%2Csn-vgqsrnzs&ms=au%2Crdu&mv=m&mvi=5&pl=36&initcwndbps=1280000&vprv=1&svpuc=1&mime=video%2Fmp4&rqh=1&gir=yes&clen=1403974&dur=90.760&lmt=1573432789551338&mt=1719949987&fvip=5&keepalive=yes&c=IOS&txp=1306222&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cxpc%2Cvprv%2Csvpuc%2Cmime%2Crqh%2Cgir%2Cclen%2Cdur%2Clmt&sig=AJfQdSswRQIhAP0QgbMh8J8SJXw-7H5bkSL_hfR_4Co6fn178kjkKxM0AiAOVa7gH0tNraXPu7CucR2KoIHFak0dMcYRBZgAvHz6kA%3D%3D&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AHlkHjAwRQIgWG7f9sL3z3mAm1UHlfYdLrAskYxdjwcd70cOp3OuzZQCIQC0khiWowgkTIGWtN3aSmNpNnBs3hy4njoRcH9nAerbhg%3D%3D"
[debug] File locking is not supported. Proceeding without locking
[download] Destination: ⧸a⧸ sings - Cruel Angels Thesis [Evangelion opening] [W0FIDjx4Ig8].f135.mp4
[download] 100% of    1.34MiB in 00:00:00 at 7.09MiB/s
[debug] Invoking http downloader on "https://rr5---sn-vgqsknsk.googlevideo.com/videoplayback?expire=1719971801&ei=eVuEZvKrAt2U2_gP66aC0A8&ip=2601%3A243%3A0%3A4a0%3A8cbd%3Aed34%3A7ae0%3Af6d3&id=o-AG3qBB_wCyiOS4ZQ5XItRmrp2_wLay8Pb65boJpkrJMn&itag=140&source=youtube&requiressl=yes&xpc=EgVo2aDSNQ%3D%3D&mh=Fd&mm=31%2C29&mn=sn-vgqsknsk%2Csn-vgqsrnzs&ms=au%2Crdu&mv=m&mvi=5&pl=36&initcwndbps=1280000&vprv=1&svpuc=1&mime=audio%2Fmp4&rqh=1&gir=yes&clen=1471981&dur=90.906&lmt=1573432784652545&mt=1719949987&fvip=5&keepalive=yes&c=IOS&txp=1301222&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cxpc%2Cvprv%2Csvpuc%2Cmime%2Crqh%2Cgir%2Cclen%2Cdur%2Clmt&sig=AJfQdSswRgIhAPWeyQeZvYzPRLvPTavD_UtLII14_xWlagfpS7icQhSnAiEArD-PTaKQ4iUtUoIIzpeHbPfyhQU3bK2MLH8HLPhLlcM%3D&lsparams=mh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpl%2Cinitcwndbps&lsig=AHlkHjAwRQIgWG7f9sL3z3mAm1UHlfYdLrAskYxdjwcd70cOp3OuzZQCIQC0khiWowgkTIGWtN3aSmNpNnBs3hy4njoRcH9nAerbhg%3D%3D"
[download] Destination: ⧸a⧸ sings - Cruel Angels Thesis [Evangelion opening] [W0FIDjx4Ig8].f140.m4a
[download] 100% of    1.40MiB in 00:00:00 at 22.99MiB/s
[Merger] Merging formats into "⧸a⧸ sings - Cruel Angels Thesis [Evangelion opening] [W0FIDjx4Ig8].mp4"
[debug] ffmpeg command line: ffmpeg -y -loglevel repeat+info -i "file:⧸a⧸ sings - Cruel Angels Thesis [Evangelion opening] [W0FIDjx4Ig8].f135.mp4" -i "file:⧸a⧸ sings - Cruel Angels Thesis [Evangelion opening] [W0FIDjx4Ig8].f140.m4a" -c copy -map 0:v:0 -map 1:a:0 -movflags +faststart "file:⧸a⧸ sings - Cruel Angels Thesis [Evangelion opening] [W0FIDjx4Ig8].temp.mp4"
Deleting original file ⧸a⧸ sings - Cruel Angels Thesis [Evangelion opening] [W0FIDjx4Ig8].f135.mp4 (pass -k to keep)
Deleting original file ⧸a⧸ sings - Cruel Angels Thesis [Evangelion opening] [W0FIDjx4Ig8].f140.m4a (pass -k to keep)
[EmbedSubtitle] There aren't any subtitles to embed
[Metadata] Adding metadata to "⧸a⧸ sings - Cruel Angels Thesis [Evangelion opening] [W0FIDjx4Ig8].mp4"
[debug] ffmpeg command line: ffmpeg -y -loglevel repeat+info -i "file:⧸a⧸ sings - Cruel Angels Thesis [Evangelion opening] [W0FIDjx4Ig8].mp4" -map 0 -dn -ignore_unknown -c copy -write_id3v1 1 -metadata "title=/a/ sings - Cruel Angels Thesis [Evangelion opening]" -metadata "date=20090803" -metadata "description=AND THERE IT IS!

With all their might, Anonymous and Tripfriends of /a/ sing Cruel Angels Thesis, and prove once for all they're all pretty cool guys eh sings terribly and doesn't afraid of anything.

And yes, this project is s̶t̶i̶l̶l̶ ̶a̶l̶i̶v̶e̶ more dead than fried chicken!

With all their might, Anonymous and Tripfriends of /a/ sing Cruel Angels Thesis, and prove once for all they're all pretty cool guys eh sings terribly and doesn't afraid of anything.

And yes, this project is s̶t̶i̶l̶l̶ ̶a̶l̶i̶v̶e̶ more dead than fried chicken!

Mp3:
http://www.mediafire.com/?rmudky1ntby

Also, don't forget to join us @IRC!
irc://irc.rizon.net/singchan (a relic of a bygone era)

DEM ANOTATIONS (dead, fuck YouTube)
http://www.youtube.com/watch?v=W0FIDjx4Ig8&layer_token=2fb7b5397c8ce5d3" -metadata "purl=https://www.youtube.com/watch?v=W0FIDjx4Ig8" -metadata "comment=https://www.youtube.com/watch?v=W0FIDjx4Ig8" -metadata "artist=Nife" -movflags +faststart "file:⧸a⧸ sings - Cruel Angels Thesis [Evangelion opening] [W0FIDjx4Ig8].temp.mp4"

This is not an official API by Google, but just someone using Google Cloud Storage to store the annotations dataset scraped before the shutdown. (ref)
I don't think this is fit for inclusion in yt-dlp, but anyone is free to write a plugin that includes this data.

My mistake; thank you for clarifying!


npm publish

Is it possible to publish the new shiny 0.9 version to npm? We would love to be able to set redis port.

Done :)


Unable to search all documents

Hi,
I'am new to ES or elassandra and trying to learn some basic concept but I'am stuck at one point. My issue is when I am viewing single document by this query http://<IP_ADDRESS>:9200/twitter/tweet/1?pretty=true . ES gives result as
{
"_index": "twitter",
"_type": "tweet",
"_id": "1",
"_version": 1,
"found": true,
"_source": {
"message": "This is a tweet!",
"user": {
"uid": "12345",
"name": {
"last_name": "Royer",
"first_name": "Vincent"
}
}
}
}
But when I'am trying to view all the records it gives total records as 0 -
http://<IP_ADDRESS>:9200/twitter/tweet/_search?pretty=true
{
"took": 1,
"timed_out": false,
"_shards": {
"total": 1,
"successful": 1,
"failed": 0
},
"hits": {
"total": 0,
"max_score": null,
"hits": []
}
}
Where I'am gong wrong please help...

Hi,
It should work as shown bellow.
Do you issue an http GET request when searching ?
What is your elssandra version ?
$curl -XPUT "$NODE:9200/twitter/tweet/1" -d' {
"message": "This is a tweet!",
"user": {
"uid": "12345",
"name": {
"last_name": "Royer",
"first_name": "Vincent"
}}}'
{"_index":"twitter","_type":"tweet","_id":"1","_version":1,"_shards":{"total":1,"successful":1,"failed":0},"created":true}
Then, you should get this when searching :
$ curl -XGET "$NODE:9200/twitter/tweet/_search?pretty"
{
"took" : 46,
"timed_out" : false,
"_shards" : {
"total" : 1,
"successful" : 1,
"failed" : 0
},
"hits" : {
"total" : 1,
"max_score" : 1.0,
"hits" : [ {
"_index" : "twitter",
"_type" : "tweet",
"_id" : "1",
"_score" : 1.0,
"_source" : {
"message" : "This is a tweet!",
"user" : {
"uid" : "12345",
"name" : {
"last_name" : "Royer",
"first_name" : "Vincent"
}
}
}
} ]
}
}
Thanks,
Vincent.

Le 31 juil. 2017 à 08:26, writeaditya<EMAIL_ADDRESS>a écrit :
Hi,
I'am new to ES or elassandra and trying to learn some basic concept but I'am stuck at one point. My issue is when I am viewing single document by this query http://<IP_ADDRESS>:9200/twitter/tweet/1?pretty=true http://<IP_ADDRESS>:9200/twitter/tweet/1?pretty=true . ES gives result as
{
"_index": "twitter",
"_type": "tweet",
"_id": "1",
"_version": 1,
"found": true,
"_source": {
"message": "This is a tweet!",
"user": {
"uid": "12345",
"name": {
"last_name": "Royer",
"first_name": "Vincent"
}
}
}
}
But when I'am trying to view all the records it gives total records as 0 -
http://<IP_ADDRESS>:9200/twitter/tweet/_search?pretty=true http://<IP_ADDRESS>:9200/twitter/tweet/_search?pretty=true
{
"took": 1,
"timed_out": false,
"_shards": {
"total": 1,
"successful": 1,
"failed": 0
},
"hits": {
"total": 0,
"max_score": null,
"hits": []
}
}
Where I'am gong wrong please help...
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub https://github.com/strapdata/elassandra/issues/104, or mute the thread https://github.com/notifications/unsubscribe-auth/AJzHmeld17oLk0GoKnUYF3mmryMnDPrWks5sTXOagaJpZM4On8z_.

Hi Vincent,
Still no result.
Yes I have issued GET command to get results
and I'am using 2.4.2 elassandra version
{
"name": "<IP_ADDRESS>",
"cluster_name": "TestCluster",
"cluster_uuid": "1787a6cf-ad47-41e3-a12e-933e9222954c",
"version": {
"number": "2.4.2",
"build_hash": "cfeba3780e2f027a15f5e4943d2903ca9201fbba",
"build_timestamp": "2017-03-02T22:03:10Z",
"build_snapshot": false,
"lucene_version": "5.5.2"
},
"tagline": "You Know, for Search"
}
I'am not using curl to execute search query. Working on postman chrome integration

Hi,
According to the build date, your are probably using the release 2.4.2-10 having a bug fixed in <IP_ADDRESS>+ (bug #84 = only indexing in debug mode). Please upgrade to 2.4.2-13 or to the very last release <IP_ADDRESS>).
Thanks,
Vincent.
Envoyé de mon iPhone

Le 31 juil. 2017 à 12:51, writeaditya<EMAIL_ADDRESS>a écrit :
Hi Vincent,
Still no result.
Yes I have issued GET command to get results
and I'am using 2.4.2 elassandra version
{
"name": "<IP_ADDRESS>",
"cluster_name": "TestCluster",
"cluster_uuid": "1787a6cf-ad47-41e3-a12e-933e9222954c",
"version": {
"number": "2.4.2",
"build_hash": "cfeba3780e2f027a15f5e4943d2903ca9201fbba",
"build_timestamp": "2017-03-02T22:03:10Z",
"build_snapshot": false,
"lucene_version": "5.5.2"
},
"tagline": "You Know, for Search"
}
I'am not using curl to execute search query. Working on postman chrome integration
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

Hi Vincent,
It worked now , may be there was some issue with version. We can close this call . Thanks for your support.


About in_checkmate() with Ka7 or Ka8

Hello, why this is a true:
var game = new Chess ('k7/2Q5/8/8/8/8/8/8 w - - 0 1');
alert (game.in_checkmate()); //true

but for any similar position returned value is false:
var game = new Chess ('7k/5Q2/8/8/8/8/8/8 w - - 0 1');
alert (game.in_checkmate()); //false

Only for positions with king on a7 or a8 (and without opposite king on the board) the function says "true" and i can't get moves() array for any piece.

It's not a valid position, you need a white king on the board.

Of course. But there are different ways to use the API. I am confused by the difference of the function logic


[feature] add server information

wip: started with https://github.com/terabyte3/crust/commit/9d06518f3b98fc6f7814400667b705cda1b9c191

[x] class implemented
[x] route added
[ ] stable
[ ] complete
soon:tm:

Will add


KAFKA-3522: Add RocksDBTimestampedSegmentedBytesStore

Part of KIP-258.

Call for review @guozhangwang @bbejeck @vvcephei @ableegoldman

Updated per comments. Thanks @bbejeck and @vvcephei

Java8 passed. Java11 timed out.
Retest this please.

Java8 failed with https://issues.apache.org/jira/browse/KAFKA-7965
Java 11 passed.
Retest this please.

Updated this.

Ack. It's internal and we can refactor later if it turns out to be worth it. Merging as-is for now.


Initial support of vitest benchmark

This separated pr is required to merge into main branch for testing github actions workflow in next coming pr #100. I just copied one of the tests from typescript-runtime-type-benchmark just for demo purposes.
Is benchmarks folder in ./library/src good place for storing benchmarks files?

Thank you very much! The next few days I have to focus on my bachelor thesis. As soon as I find time, I'll get back to you.

Do you have any idea how we can make the result comparable to the latest version of Valibot, so we can see if changes have a positive or negative impact on the performance?

We could add the latest version of Valibot as a dev dependency and run the benchmark for both to have a comparison of the codebase to the latest Valibot version.

Yes, I will try to check it in the next few days.

Sorry for not coming back to this, but other things had a higher priority. I am also not sure if we really need it, since the basic structure of the library is set and changes will most likely not have a major impact on performance. It is still useful, but other things have a higher priority for me.


Add screenshots to README

Visual, but without screenshots we can't see what's visual in it without actually installing it.

Good point. The full documentation will definitely need lots of diagrams and screenshots.

-> #11 for future documentation. The README has a screenshot now though (thanks Paul!) so closing.


Correct the default JUnit version in JvmTestSuite Javadoc

Rebased version of https://github.com/gradle/gradle/pull/19669

@bot-gradle test and merge

OK, I've already triggered a build for you.


chore: remove outdated comment

we don't do any of that anyway.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#345
#344  👈
#343
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pepyakin and the rest of your teammates on  Graphite

Merge activity

Aug 27, 11:09 AM EDT: @rphmeier started a stack merge that includes this pull request via Graphite.


[DEMO] CodeAction Features

Fix MethodDirectiveParameter
This is a very simple code-action feature, added as a first step to add a logic for further code-action features in coc-laravel in the future.
https://github.com/yaegassy/coc-laravel/assets/188642/6ae9c66c-bc94-4ee6-92dd-4ae459ab63b2

Create blade component
https://github.com/yaegassy/coc-laravel/assets/188642/a3e4ade4-c8ec-45d5-8efc-7762d45a234c


Druid Ldap

Does current version of Druid that is 0.16.1 supports LDAP authentication?.
If yes then what are the properties required for the change in common run time files.
LDAP extension
Druid now supports LDAP authentication. Authorization using LDAP groups is also supported by mapping LDAP groups to Druid roles.
LDAP authentication is handled by specifying an LDAP-type credentials validator.
Authorization using LDAP is handled by specifying an LDAP-type role provider, and defining LDAP group->Druid role mappings within Druid.
LDAP integration requires the druid-basic-security core extension. Please see https://druid.apache.org/docs/0.17.0/development/extensions-core/druid-basic-security.html for details.
As this is the first release with LDAP support, and there are a large variety of LDAP ecosystems, some LDAP use cases and features may not be supported yet. Please file an issue if you need enhancements to this new functionality.

LDAP authentication isn’t available or supported in Druid 0.16.1, it is instead officially supported in 0.17.0
But, I believe the LDAP authentication changes are compatible and would work with Druid 0.16.1 as well.
So, If you REALLY want LDAP authentication feature for 0.16.1, you can try and test it out by placing the Druid 0.17.0 druid-basic-security extension to your Druid 0.16.0 extensions folder.
Thanks,
Mohammad J. Khan
From: averma111<EMAIL_ADDRESS>Reply-To: apache/druid<EMAIL_ADDRESS>Date: Saturday, January 25, 2020 at 6:22 PM
To: apache/druid<EMAIL_ADDRESS>Cc: Subscribed<EMAIL_ADDRESS>Subject: [EXTERNAL] [apache/druid] Druid Ldap (#9256)
Does current version of Druid that is 0.16.1 supports LDAP authentication?.
If yes then what are the properties required for the change in common run time files.
LDAP extension
Druid now supports LDAP authentication. Authorization using LDAP groups is also supported by mapping LDAP groups to Druid roles.
LDAP authentication is handled by specifying an LDAP-type credentials validator.
Authorization using LDAP is handled by specifying an LDAP-type role provider, and defining LDAP group->Druid role mappings within Druid.
LDAP integration requires the druid-basic-security core extension. Please see https://druid.apache.org/docs/0.17.0/development/extensions-core/druid-basic-security.html for details.
As this is the first release with LDAP support, and there are a large variety of LDAP ecosystems, some LDAP use cases and features may not be supported yet. Please file an issue if you need enhancements to this new functionality.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/apache/druid/issues/9256?email_source=notifications&email_token=AEMA7FBSIHCHYGBEB54DDT3Q7TJUPA5CNFSM4KLT5D32YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IIXBLPQ, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEMA7FADAILZORS5M4AWVRDQ7TJUPANCNFSM4KLT5D3Q.


803 broke compilation fix

Fix for #803 broken compilation issue

CLA signed.

Codecov Report

Merging #837 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #837   +/-   ##
=======================================
  Coverage   79.23%   79.23%
=======================================
  Files           4        4
  Lines         236      236
  Branches       53       53
=======================================
  Hits          187      187
  Misses         30       30
  Partials       19       19

Impacted Files
Coverage Δ

lib/googleapis.ts
78.18% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 477824a...3a6769a. Read the comment docs.


Very Very Slow ToString In BigInteger

Hi,
for special cases, ToString (In Base 10) can take very very long to execute for BigIntegers where BitLength is >= 64
An Example Case is this
BigInteger b = new BigInteger("2");
BigInteger exp = b.Pow(65536);
var  s = exp.ToString();
can anything be done to improve this, maybe a more optimal algorithm or implementation?
Regards.

Well, it could certainly be improved, but the functionality is mostly there for completeness.
The BigInteger class in BC exists primarily to support the cryptographic functions of the rest of the library and conversion to base 10 is not really useful for that apart from debugging or test vectors, and even then it's normal to use hexadecimal (i.e. ToString(16)). Also, efficiency is mostly concerned with bit lengths in the few-thousand range, and (in case you were expecting it), we don't attempt much in the way of clever handling for special values like powers-of-2.

@peterdettman , thanks for your explanation.

I found some time to improve this (changes take a while to mirror here). On my machine, ToString(10) for random 100,000 bit numbers now takes < 1 second.  Still not ideal, but a lot better.

@peterdettman , seems you forgot to make the push?

@peterdettman , have been finally able to test it, huge improvement noticed.
Thanks a lot.
you can now close this issue if you please.
Thanks a bunch.
I own you one.

Glad it helped.


Fix device scan limit_size feature

Fix device scan limit_size feature

@stanleytsang-amd waiting for the internal CI results.


Use latest workflow builder packages and catalogs

Lockfile was also audit fixed.

Setting 'additionalProperties=true' makes app less nice

typos in prop names can not be caught and
unwanted stuff can end up in workflow.cfg that is executed

, but allows less_io to be passed as data value.


Require Whitespace after ParticleArgumentDirection and Type

The white-space after ParticleArgumentDirection and ParticleArugmentType was previously not associated with the preceding token.
The token or the white-space could appear or not appear independently.
We now, correctly require spacing between the ParticleArgumentDirection and ParticleArgumentType.

Also found two trailing white-spaces that I think are safe to remove.


[Bug] Meet the Team SVG header blurry on smaller screens

yeah change all the images to the same shape as lg screens; also, make each subsection heading (development, admin etc) a lil larger than the names

update the balloon image as well


get clicked checkbox

Hello!
In my app, i will have an item additions screen, with multiple FormBuilderCheckboxGroups, each indicating a specific category of additions.
In that screen there will be a total item price as well, reflecting the changes in the item's price as additions are selected and
un-selected.
Due to this, I want that on the click on any checkbox to immediately add it's price (in an ItemExtra model class) to the total, if that checkbox's new status is True, and deduct from the item's price if the new checkbox status is false.
Can (& How) this be achieved in this package? . I know there's an onChanged property, but as it only gets the new list, and the amount of lists will be dynamic, it will be unfeasible to do such a calculation on every checkbox click.

Hi @evanholt1,
I suggest that you use this trick:

You can initialize a Map object in your screen with the types String, List<dynamic> as the group name, and selected values list respectively.

Map<String, List<dynamic>> resultMap = {};

Then you can use onChanged parameter in every FormBuilderCheckboxGroup widget that you use. And in it, you assign the result of the selected List with the group widget name.

FormBuilderCheckboxGroup(
  name: 'myList1'
  onChanged: (List<Object?>? value) {
    resultMap['myList1'] = value ?? [];
    print(resultMap);
  },
// other parameters
)

And you can get your results from the Map.

 Have a great day.

Hello again!
thanks for your reply.
I am sorry, i must have clarified more in the question:
I have an ItemExtra model which has a property Map<ItemExtra, Null> extras (it should be a Set, but wrote it a Map because of Hive-Flutter's constraints),
and an Item model whose price property  changes based on the ItemExtras chosen.
Map<ItemExtra, Null> extras is used all over the place in our app for business logic, so it would be hard to change it everywhere.
Thus far(before learning about this package and handling validations) I have on each checkbox click updated the item's price directly.
I am asking if there is similar functionality in the CheckboxGroup widget, or something comparably fast, as i really liked the validations & less boilerplate of this package.

UPDATE:
I found out the most performant way to do this was to add 2 properties to FormBuilderCheckboxGroup,
one is of type Function(I called onCheckboxChanged), and is the custom function which will be executed on clicking any checkbox in that group,
and the other is of type T (I called identifiers), and is the argument to the custom function above which will help identify exactly which checkbox was selected.
As an example, i added in the widget tree:
 FormBuilderCheckboxGroup<List<ItemExtra>> (
     identifiers: categoryItemExtrasList, // list of itemExtras
     onCheckboxChanged: (bool selected, ItemExtra itemExtra) {
         updateItemPrice(selected, itemExtra) // adds or removes the itemExtra depending on the boolean
     },
    // other options
)

and i passed those 2 new parameters down to GroupedCheckbox, where i changed:
final control = Checkbox(
      // ...previous options
      onChanged: isOptionDisabled
          ? null
          : (selected) {
              if (widget.onCheckboxChanged != null)
                  widget.onCheckboxChanged(selected, widget.identifiers[index]);
             // rest of code...
            },
    );

And this now sends the new state of the checkbox, along which checkbox was clicked (identifiers[index]),
to the value of onCheckboxChanged_ defined in FormBuilderCheckboxGroup<List<ItemExtra>>.
While this is a bit of a niche case, i do think that sometimes it would be useful to be able to define a custom callback when a checkbox is clicked. So i think this feature (the 2 parameters) would be nice to have as optional in FormBuilderCheckboxGroup.

I am not sure about it, but using a Typed FormBuilderFieldOption does not satisfy you? Also, if you want the exactly item clicked, you may use its return (as I mentioned, it can be typed, so you can pass any value), and compares it with any other data. Considering that, you can use or Equatable, or override Equality, so you can compare two objects


Bump Discord API version to version 9 and add more message type to be deleted

Discord clients are now using the version 9 of the Discord API.
Version 9 is required in order to be able to use Threads.
This pull request also adds more message types to be deleted (≥6 & ≤21).

As far as I know they are all messages types that can be deleted without any issue.

Please note that the script currently does not work on Threads as they don't seem to be indexed.
{"message": "Missing Access", "code": 50001}

I'm not sure if it's a bug or a limitation of the early access.
Anyway this is something to look for as Threads aren't a released feature yet.

This change is

I forgot to mention that ever since the threads feature officially launched, deleting messages from them works fine (if they aren't archived).
Messages from threads are indexed in the channel search itself.

I have incorporated your PR in my forked repository.


Inserting brackets around selection doesn't work with the vscode extension

Normally when you select something in VSCode and press ( the selection gets surrounded by () instead of being replaced with (. The same thing happens with curly braces and square brackets as well.
This feature seems to work for every kind of file except for .civet when the extension is installed so I assume the extension overrides the default behaviour in some way it shouldn't.
As a sidenote for those looking for a somewhat clunky workaround, you can configure this snippet for civet files and assign it to a separate shortcut, you'd need to do this for each type of bracket which is not ideal but which is still better than nothing...
"surroundParens": {
    "prefix": "(",
    "scope":"civet",
    "language":"civet",
    "body": ["($SELECTION)$0"],
    "description": "Surround with parens"
  }

and the keybinding
{
  "key": "alt+9",
  "command": "editor.action.insertSnippet",
  "when": "editorTextFocus && editorHasSelection",
  "args": {
    "name": "surroundParens",
    "langId": "civet"
  }
}

Same thing with quote marks as well.

Should be fixed in extension version 0.3.10!

Maybe it would be nice to also enable this functionality for angle brackets < > too as they are common brackets in both typescript and JSX.
I found it is much more common that I want to fix a forgotten Promise<_> or something similar instead of replacing the selection with <.


Blocks: Remove WP <5.5 compatibility code

Context

Summary
Remove backwards compatiliby workarounds to support WP 5.3
Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

QA

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

UAT

[ ] UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[x] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #7674

Seems good but we should wait with merging to ensure the WP min level is set to 5.5 in code, too.

Absolutely. All tickets were created separately for this effort and set as blockers accordingly.

Ok, tested just now a little bit and I can see this for example when selecting stories:
Not sure if related or not -- all good in your local?

This is broken on main from 5.3-5.7 :( I will create a create a follow up issue.

Follow up issue https://github.com/google/web-stories-wp/issues/7991

E2E Tests are still running for 5.3 here:

Was that changed in another issue? I know running PHP 7 was changed elsewhere for PHP unit tests, what about the e2e?

This PR is blocked by #7926

@spacedmonkey The e2e tests seem to be consistently failing, thoughts?

@swissspidy Seems like all the components that have backfill are valid, as they were only added in 5.6. So for that reason I am going to close out this PR.


Utility API generates "inconsistent" class-names when omitting the "class" option

I'm using Alpha 3 and noticed that the utility API is a little bit inconsistent when generating utilities without the "class" option.
Using this config:
"block": (
  responsive: true,
  property: display,
  class: null,
  values: block
 )

Expected:
// ...
.block-sm {
  display: block;
}
// ...

Got:
// ...
.sm-block {
  display: block;
}
// ...

Another example would be:
"box-sizing": (
      responsive: true,
      property: box-sizing,
      class: box,
      values: (border: border-box, content: content-box)
)

Which yields:
//...
.box-sm-border {
    box-sizing: border-box !important;
}
 .box-sm-content {
    box-sizing: content-box !important;
}
//...

If you specify a value that is null or empty for the "class" option, you don't get a "properly-named" utility.
BTW, I'm not sure if "inconsistent" is the right word for it, but I think this is a use-case I was hoping was supported. It allows us to generate less verbose utilities when the property value is the same as the class-name (instead of display-sm-block or block-sm-block, for example).
My proposal is to swap the "responsive" and "name" strings when generating utilities if the class option is null so you can generate classes like block for display: block, etc.
Update: I don't know if this interferes with the current naming schema for the responsive classes like d-block or  d-sm-block where the breakpoint comes first, but... wouldn't it actually be more intuitive if the breakpoint was at the end of the class-name or prefixed like Tailwindcss? eg: d-block-sm, sm:d-block. This way it wouldn't be a problem when you concatenate the names and it seems a much cleaner solution to avoid mixing the prefixes.
On another note: Maybe the "class" option should be called "prefix" since this seems to be what it does. Also because you can change the actual class name by using the map notation on the "values" option (the final class name then is a combination of factors).
PS.: I know that the same thing happens if you generate responsive utilities for the "overflow" property that comes with Bootstrap, you'll get class-names split by the breakpoint suffix: overflow-sm-auto and overflow-sm-hidden are other examples - so this might be by design (I'm just finding it supper weird now that we are relying even more on utility classes).

I think this is what we hit the other day in the RTL PR @ffoodd?

Not sure about what you're referring to, but this is clearly by design since every given examples is the expected output ATM.
There's no bug nor issue here—only questionning our naming convention for utilities.
Using prefix instead of class makes sense.
Moving breakpoint at the end/start of utilities is questionnable, IMHO. That's a convention, it's been Bootstrap's one for years, and as soon as it's documented and known I don't see the point of changing our convention.
BTW, maybe I'm too used to Bootstrap but having d-block d-lg-none seems clearer to me than d-block d-none-lg for responsive variations.

Yeah, we're locked in for the naming because of the beta, but this also makes sense as it is—d for display comes before -sm-block, so it follows that you get sm-block at the other end without a class. Closing as a won't fix.

Yeah, we're locked in for the naming because of the beta, but this also makes sense as it is—d for display comes before -sm-block, so it follows that you get sm-block at the other end without a class. Closing as a won't fix.


Feat: adding newsletter to subscribe in footer

Describe the feature
we can add a heading for daily news letter in footer above email field and the subscribe button for the same
Add ScreenShots

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

@Its-Aman-Yadav please assign me this task


You can configure color theme the ionic-datepicker from the config me…

…thod and bug fixes

Could you please resolve the conflicts and update the PR?


[raymath] Fix for issue 4454, MatrixDecompose() gave incorrect output for certain scale and rotations

For transform matrices with certain ranges of rotation angles and scaling factors, MatrixDecompose() would give incorrect answers.
I narrowed down the issue to where the scaling factors are removed from the cloned transform, before the rotation is extracted: the scale factors needed to be taken into account for extra matrix members.
The models_loading_gltf example still works correctly after this fix.
Further tests and discussion here: https://github.com/raysan5/raylib/issues/4454

@waveydave Thanks for the review!


Bug/6.3/tdi 37635

Please check if the PR fulfills these requirements

[x] The commit message follows Talend standard
[x] Tests for the changes have been added (for bug fixes / features)

What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
please see the comment in https://jira.talendforge.org/browse/TDI-37635.
adjust the tdataprepdbinput component to meet the requirement of https://jira.talendforge.org/browse/TCOMP-344
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information:
https://jira.talendforge.org/browse/TDI-37635
https://jira.talendforge.org/browse/TCOMP-344

Pull request test result: failure :x:

Pull request test result: failure :x:

need to rebase to the master

Pull request test result: success :star:

Pull request test result: failure :x:

seem need to rebase to master.

done : rebase to master

https://github.com/Talend/components/pull/295

Pull request test result: failure :x:

Pull request test result: failure :x:

rebase to master

after doing the action :

rebase my local branch to origin/master after a fetch all
call git push --force-with-lease 37635 origin/37635
then no build and test information for the pull-merged-to-master branch, need to fix it.

Pull request test result: failure :x:

i will create new dev branch and pull request to avoid the jenkins and github status issue .


[fix] use free workers, remove dependabot as we dont use it, remove end2end…

… tests which we cannot run anymore (as-is)
In the mid-term, we should select a list of examples to run. Running all of them as of now is not an option as we would exhaust our free worker time very fast.
Also update python version to more recent ones and use 3 instead of 4 to save compute.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Files
Coverage Δ

setup.py
0.00% <ø> (ø)

tst/schedulers/test_choose_acqfunc.py
41.37% <100.00%> (-58.63%)
:arrow_down:

tst/schedulers/test_schedulers_api.py
94.93% <100.00%> (+0.13%)
:arrow_up:

... and 26 files with indirect coverage changes


Integrated terminal ctrl+click doesn't work for directories

Issue Type: Bug
I don't recall this ever working actually so this might be a feature request more than a bug but often I have logs that print a directory with more logs or other things.
I'd really like to just be able to ctrl+click the path and have file explorer open that directory.
VS Code version: Code 1.41.1 (26076a4de974ead31f97692a0d32f90d735645c0, 2019-12-18T14:58:56.166Z)
OS version: Windows_NT x64 10.0.18362

/duplicate https://github.com/microsoft/vscode/issues/29499


fix locales issues + allow locale configuration + extra_packages

Why
We had some locales issues (perl ... LANG = (unset) ...). This is fixed now.
Now we can even choose the system language, by combinating extra_packages with language variables.
Let's say I want to have a french system (assuming we include the common-packages role):
extra_packages: [ 'language-pack-fr' ]
language: 'fr_FR.UTF-8'

It's that easy :)

to v1.3.0


Source Generator also Generates Scene and Audio Enums

Prefabs Class
The source generator currently creates a Prefabs class that works with Game.LoadPrefab(Prefab prefab).
Additional Enhancements
The source generator should also generate:

Scene Enum

A Scene enum for SceneManager.SwitchScene(Scene scene) instead of SceneManager.SwitchScene(string scene).

Audio Enum

An Audio enum that searches the project for audio files with extensions: .ogg, .mp4, .wav, .flac, .aac, .m4a.

Summary
These enhancements improve type safety and simplify asset management in the game code.

The source generator now generates a Scene enum. I will work on the Audio enum now.

The source generator now also generates a Audio enum.


time: no Parse format for GNU style RFC3339

Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (go version)?
go version go1.10.3 linux/amd64
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
Ubuntu 18.04, amd64
What did you do?
Attempted to time.Parse the result of 'date --utc --rfc-3339=ns':
time.Parse(time.RFC3339Nano, "2018-06-18 10:19:31.800140702+00:00")

package main

import (
	"fmt"
	"os/exec"
	"strings"
	"time"
)

func main() {
	raw, err := exec.Command("date", "--utc", "--rfc-3339=ns").Output()
	if err != nil {
		panic(fmt.Sprintf("failed to run date: %v", err))
	}
	from_ubuntu := strings.TrimSpace(string(raw))
	t, err := time.Parse(time.RFC3339Nano, from_ubuntu)
	if err != nil {
		fmt.Printf("Unparsable: %q\n", string(from_ubuntu))
	} else {
		fmt.Printf("Parsed: %v\n", t)
	}
}

What did you expect to see?
Parsing to succeed
What did you see instead?
Failure, due to an old disagreement about the RFC: http://lists.gnu.org/archive/html/bug-coreutils/2006-05/msg00019.html
GNU coreutils team maintain whitespace is allowed, but the Go library requires the 'T' separator between the date and time components of the string representation.
Options to allow interoperability between GNU style and Go style RFC-3339 complient strings would be to either relax the Go parsing, or provide alternative predefined styles in the time package (time.RFC3339GNU and time.RFC3339NanoGNU, or time.GNU3339 and time.GNU3339Nano, or similar)

/cc @rsc

While there is a note in RFC3339 saying that applications may choose to replace the T with a space, this is not what the formal ABNF specification there supports. The underlying ISO 8601 standards mandates the use of the T.  Since any application choosing to support space can easily define their own constants, I don't think new constants in time are needed.

I don't see a need to change anything here.  We appear to follow the RFC.  It's easy to adapt.

Taken directly from the RFC:
NOTE: ISO 8601 defines date and time separated by "T".
Applications using this syntax may choose, for the sake of
readability, to specify a full-date and full-time separated by
(say) a space character.

Yes, the ABNF doesn't included characters other than T, but there is a second note which makes it clear that the ABNF is not exhaustive:
NOTE: Per [ABNF] and ISO8601, the "T" and "Z" characters in this
syntax may alternatively be lower case "t" or "z" respectively.

As such, I would argue that the time library doesn't fully conform to RFC3339.

@crawford This issue is closed, and we don't track comments on closed issues.  You can write formats yourself to do whatever you need.


Rename 'name' to 'named' to avoid puppet 4 errors.

In puppet 4/future parser this code will cause
"The parameter $name redefines a built in parameter in the 'define'
expression" to be logged and rspec tests to fail.

:+1: Merge when ready


Fixed a typo

This is a very rare case but it happens.

Thanks! @mjameswh I hope you're keeping track of these.


Implement Alizer --no-port-detection option

Which area/kind this issue is related to?
/area alizer
/area documentation
Issue Description
This issue is part of #1153 EPIC and it focuses on the updates of the CLI as an optimization to the port detection logic. That said, we should:

Introduce the --no-port-detection option which will skip the port detection for this execution.
We need to mention explicitly that the port-detection arg is deprecated and mention the new --no-port-detection option instead in our documentation

Acceptance Criteria

[ ] The --no-port-detection functionality should be add to the enricher.go in order to prevent port detection if this flag is present. Also, the component.go inside the cli package should include this option like all other cli args.
[ ] The --port-detection cli arg of component command should be mentioned as deprecated.
[ ] All documentation related to the component command will have to be updated, by mentioning the two changes (deprecation of port-detection and addition of `no-port-detection)
[ ] Test cases should be added for the --no-port-detection flag.

Target Date: 22 Aug 2023

Started working on the issue :)

A PR is created for the issue and is currently under review


ui: show read from ova only for ova format

Description
Fixes #5107

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?

@blueorangutan ui

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5108 (SL-JID-246)

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 234

LGTM (thanks)
(have not tested REALLY uploading the template - I assume we just hide/show things, and the correct parameters are still sent as before)


Repack seems to only works on valid delimiters?

quad repack [W]hiskey
Will replace the curly brackets around the function rather than the single quotes around the (fake) string. In Java single quotes are only used for characters and double quotes are used for strings. As such defining a string with single quotes is incorrect. I am assuming that the delimiter search is based on the parser which does not recognize the single quotes as delimiters.
To reproduce:
Create a java file in the vscode and paste:
public class TestSingleQuoteDelimiter {

    public static void main(String[] args) {
        String notAString = 'this will not work';
    }

}

The result after the command is:
public class TestSingleQuoteDelimiter {

    public static void main(String[] args) "
        String notAString = 'this will not work';
    "

}

@AndreasArvidsson would your https://github.com/cursorless-dev/cursorless/issues/1600 help here?

Yes, I think that should fix it. Since tree sitter would not know what to do with the single quotes they should remain as valid delimiters.
Srry I didn’t find that issue when i was searching for similar issues.

I think so


load from file path

Hi, can someone help me with code,
I have a PHP file that involved with codemirror which works great, but I want each text area to load the code from other file using PHP like index.php, main.css, main.js, and show preview from all of those files to combines.
I have tried everything I could even try with .js codemirror js file, but not successful.
My question is that how can write that code inside of each text area to link another page!
many thanks.
AM

Hi. I don't quite understand your question, but it looks like a request for help, rather than a bug report. This isn't the place for that. Maybe try stackoverflow.com

sorry fro confusing...I reported to the stackoverflow.com please see that page...
http://stackoverflow.com/questions/40493728/how-to-load-code-using-codemirror
What I'm trying to say is that let say that I have .css file name shopping.css, and I want .css text area from codemirror to load the code from shopping.css for me to see or change.
somewhere where I need to put file path name to link to another page ...
hope is clear what I'm trying to say!
AM


Banners

Refers to https://github.com/JetBrains/jewel/issues/611

Actually, the banner border are missing after #699, so undoing the approval for now


Installed Ghost but getting error 404 like nothing is there?

My site is: http://jsbyw.me
Ive installed Ghost both through the CLI which was unsuccessful and manually which has worked and over SSH it says it is running but i only get a error 404 as if ghost isn't there. No errors at all now. Im confident it is installed correctly.
Anyone any ideas?

Ghost Version: Latest
Running Plesk on the server.

Hey @jsbyw  👋 We ask that you please do not use GitHub for help or support, the default issue template pointed you to our forum for this type of question 😄 We use GitHub solely for bug-tracking and on-going feature development so we try to keep it noise free.
Many questions can be answered by reviewing our docs for self-hosters, our theme API, or our public API. If you can't find an answer then our forum is a great place to get community support, plus it helps create a central location for searching problems/solutions.
FYI: Many projects have their own support guidelines and GitHub will highlight them for you, or the project owners will use issue templates to point you in the right direction, please read them before opening issues


[feature proposals] [ARM] Arm data prefetch instruction

Platform: ARM64
Arm data prefetch instruction, e.g. prfm [arm64], pld[arm32]
It seems TVM not support this feature, as I can not find these instructions in the .o generate by TVM. (I disassemble mobilnet.o to get the assemble file ). Is that right? or is there any compile cfg can do this?

cc @were @ajtulloch  there is already prefetch support as schedule primitive, however, we did not find it bring performance benefit yet. Maybe there are some gaps in the generated code


Configure Continuous Integration with Jenkins

Continuous Integration configured by JHipster

jhipster jenkins file generated successfully, no merge approval is needed


Fix and add test cases for persistable context

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Proposed changes

We fixed and added test cases of switch and change node for persistable context.
Checklist

[x] I have read the contribution guidelines
[ ] For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
[x] I have run grunt to verify the unit tests pass
[ ] I have added suitable unit tests to cover the new/changed functionality

Coverage remained the same at 75.321% when pulling 6fc863a91e1bb08c6963a606ef70577edcf11b2a on node-red-hitachi:master-switch-change-test into ab0fc2ecfa05221b8f7aaa270f74203bee5522ae on node-red:master.


docs(mock-data): adding covalent-data docs

Description
Adding docs for basic usage of the new mock data server
What's included?

Update Docs > Getting Started w/ link to new mock-data page
Update docs nav list w/ link to mock-data
Add /docs/mock-data

Test Steps

[ ] ng serve
[ ] go to Docs and scroll to bottom of Getting Started
[ ] go to Docs > Mock Data

Screenshots or link to CodePen/Plunker/JSfiddle
Getting Started link

lgtm!


Decide which files to push

I want to decide which files should be pushed on which route.
currently on hitting home page only main bundle.js is pushed from the h2 server, how to push more files?

Hmm - it should push the route chunks too, is it not?

I might have been wrong in observing this, but hey I might know something super important that cli was not able to figure out. need a way to add that


How to use with Grape ?

Is it possible to use this gem with grape ?
I've added the gem, I have access to the ApiAuth module, but when I try to call sign! or authenticated? they seem not to be available. Is some kind of initialization necessary ?

nevermind. I was checking out api_auth which was installing an archaic version.
api-auth is where its at.

I made the same mistake, thanks.


Sort and Compose functions aren't accessible in portrait mode

Expected behavior
Sort and Compose functions are accessible in both orientation modes.
Actual behavior
I can see these buttons only in landscape mode. While it has 9 functions accessible in landscape mode, it has only 7 in portrait mode, missing the mentioned ones.
Steps to reproduce
You'll probably need to run it on a phone with specific screen size (4.5")

Go to Inbox folder.
Press on-screen or system menu button in portrait mode. You'll see 7 items in sum with Sort and Compose missing.
Repeat previous step for landscape mode. You'll see 9 items in sum.

Environment
K-9 Mail version: I was trying a lot of versions, from the latest (5.403) to  4.*. All of them have this bug.
Android version: 5.1

You should find the "missing" actions in the overflow menu (the three dots). If not, that's likely a bug with your Android version.
We have plans to change K-9 Mail to make portrait and landscape layouts more consistent. And with that hopefully less confusing.


Feature Request: Color Picker

I'm wondering if it would be possible to add a color picker sort of similar to the one in Visual Studio Code:

Currently, if I want to use a color not supported out of the box, I have to leave the app to generate the color in another app and return to paste it in.

Added a quick example with react-color

Would definitely be interesting something like this. if anyone wants to provide some suggestions for the UI i can make this feature

I don't think that adding such a feature would be good for the project. One of the key feature of Excalidraw is the simplicity and good defaults. If you want something else, we added the ability to enter arbitrary hex colors. Using a different program for that is, I believe, a good enough experience compared to adding complexity in the UI.

Yeah, I get what you mean regarding defaults and simplicity. But I think Excalidraw's main appeal is not with its limited color palette but rather the limited shapes and styles in which they're drawn. I often find that the existing colors do not suit my needs.
In my experience, it's actually been pretty annoying to copy-paste hex codes into Google and use the color picker there :/

What about allowing people to manually enter custom colors, then saving the most recent 5 (or whatever) in the color picker?

Not bad. It won't complicate the base UI because it won't even show until you paste custom color.
I'd maybe tweak the idea and show X recent color that are actually on the scene (if found), before showing X recent custom-picked colors, because you may play with a color before settling on it, and it would replace all your recent colors with shades of a single one.

For reference, Balsamiq also don't have a color picker but I find their color palette much more suitable for my real-world needs, probably because there are several hues for each color.

But people still requests custom palettes / remembering previous choices / color picker in Balsamiq products 😄.
My point of view:

Remembering previous custom values would indeed be useful.
Maybe full color picker could be behind something like option-click or something (agree that the simplicity of the the primary UI is important).

A good middle ground between having an entire color picker grid and just the hex code would be to have a  "picker" that grabs any color on the page.
Like this:

It would allow to easily reuse colors already on the page without having to type anything and the added UI would just be a pipette:

I'm super interested in that feature so if you agree I'll happily create a PR for it 👍

Not sure if a color sampler will be useful considering most diagrams use hachure/cross-hatch fills where picking the color would be really hard.
You'd either have to use solid fills, or keep extra elements with solid fills on scene to serve as a swatch palette (at which point it's better to just support user swatches).

As @vjeux mentioned, we'll keep it simple in Excalidraw.

I am dumbstruck that this isn't possible in Excalidraw.
Use Case: I want to make some brown boxes in my sketch. Pretty straightforward, right? Okay, there's no brown option. Okay, where's the color picker? There is none. Okay... What is the hex code for brown??? Who knows that off the top of their head, and how do you expect someone to find a color they want without opening up some kind of website or tool just to find the hexcode paste in?
Why couldn't a discreet color picker button be put somewhere on the color change popup, which opens a slightly more advanced color picker that everyone who has used the most basic of graphical editing software has seen 5000 times before in their life? It doesn't have to be visible by default; just add the option for people who need it. I can't understand how "not complicating the UI" is an excuse to ignore a pretty basic need and egregious pain point of UX.

A good middle ground between having an entire color picker grid and just the hex code would be to have a "picker" that grabs any color on the page.
Like this:
It would allow to easily reuse colors already on the page without having to type anything and the added UI would just be a pipette:

I'm super interested in that feature so if you agree I'll happily create a PR for it +1

I think a color pipette would also be another fine discreet button to add. If I am sketching ideas in Excalidraw (as one does, because it's a great program for rudimentary sketches), there might be a photo that I'm looking at that I like, and I want to grab a color out of it, or a website. I should be able to easily grab eyedrop that color so I can get it in my sketch. Otherwise I would have to open up element inspector in my browser, or if it's a local photo open up some OTHER photo editing program just to eyedrop the color, or have an eyedropper integrated into my desktop environment, which I'm pretty sure not many users do.

+1 for color picker (for example, palette opening thru click on color rectangle). As for me, color picker is not a feature but a necessary thing.

With no intention to keep kicking a dead horse, but I am trying to create a yellow text over black background button and I enter the hex for yellow and it looks olive. I don't know if this is an optical illution caused by the contrast of both colours but in my actual web site it looks ok. I have randomly tried other yellow-like hexes with the same result. I don't know how to make it look as I intent and I feel a color picker that live updates the target as I hover the colurs would be ideal in my use case.
I understand that Excalidraw is not a design tool and you want to keep it simple, but on the other hand I certainly don't need a full blown Figma just to try out a couple look and feel tweaks or discussions.
Those are my two cents and all I can do with them is throw 'em in the wishing well while asking for a clor picker. Good night and thanks for reading.


12 new API Gateway managed resources generated by ACK

Description of your changes
Using https://github.com/aws/aws-controllers-k8s/pull/449 , we are able to generate all APIs under apigatewayv2 that is made available in ACK. Note that update is not available in the generated code and I haven't added it manually yet.
TODOs:

[ ] Add examples to examples directory.
[ ] Manually test every one of the new APIs.
[ ] (Optional) Implement update functionality in provided hooks.go files.

What do you guys think about including these resources in this week's release? If we're good I can complete the TODO list above and make it ready to review. I don't think we need to wait for https://github.com/aws/aws-controllers-k8s/pull/449 to be merged before using the generated code. After all, it's pretty similar to what we'd have written by hand.
Depends on https://github.com/crossplane/provider-aws/pull/401

Fixes #
I have:

[ ] Read and followed Crossplane's contribution process.
[x] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested
I have yet to test them with a real cluster.

I just pushed some updates that include example YAMLs of API and Stage CRDs. Also, you can see how we reference API object from Stage via inlined CustomStageParameters struct.
Also, we needed a field ignore feature in ACK, which exists in https://github.com/aws/aws-controllers-k8s/pull/449 right now, hence generator-config.yaml includes ignore.field_paths that is used to specify what fields to ignore during generation. We need it to exclude identifier fields, which we use external-name annotation for, and referenced fields which we add to custom parameters struct because in many cases they are marked as required but in Crossplane we don't mark them required at CRD level since objects can be created without them having a value.
Right now, both API and Stage CRDs work as expected without update. It took a bit more than I expected due to changes necessary in ACK PR to accommodate unexpected ignore.shape_name behavior that used to work for ECR and different nature of ReadMany used in API Gateway resources.

Right now, we got 6 of the resources working end-to-end with references. The process of making them work is pretty mechanical:

The field that will be used as external-name should be ignored in generator-config.yaml.
The fields that are required and can be referenced should be ignored in generator-config.yaml.
Write referenced fields into the resource's Custom*Parameters struct.
Implement the referencer resolver function, which is mostly copy-paste.
Implement filterList so that the correct object is chosen from returned list.
Make sure ignored fields end up in the AWS request input objects, like CreateApiInput, via hooks.
If the object's external-name is assigned by AWS, then we need to set external name in postCreate hook.

Note that there is no update at all since ACK doesn't currently provide any mechanisms for it. I'll complete the rest of the resources tomorrow and try to get updates implemented for some resources but I believe we can still merge this without updates.

@negz @hasheddan @kasey This is ready to go. I believe the places to review are mostly custom_types.go, references.go and generator-config.yaml in API folder. Controller custom hooks live under pkg/controller/apigatewayv2/*/hooks.go files. You can test them manually if you'd like to with YAMLs in examples/apigatewayv2 folder.
Generation is based on current latest form of https://github.com/aws/aws-controllers-k8s/pull/449 which is this commit


smartstring is unsound and has UB

In part of my miri testing of Rhai, I've discovered that the smartstring crate is unsound in general. After spending many hours tracking down the cause of the UB, I finally narrowed it down and found an issue report for the exact UB. The example I posted also introduces the same UB in Rhai when using the ImmutableString type. (Though it's not limited to my example)
I don't know what the exact unsound conditions for the UB are, but I'm sure someone has accidentally triggered it in Rhai (as I have as well).
The same UB mentioned in the issue below can also be triggered with a var.into() for ImmutableString in Rhai.
Since the last update for this crate was ~2 years ago, I have some doubts on whether the UB will ever be fixed.
https://github.com/bodil/smartstring/issues/49
Note, there IS a PR with the fix as far as I can tell, but the author seems to have been unresponsive to issues/PRs. This could be quickly patched by cloning the repo and using that one instead however
For any people who see this and want to fix the potential UB, see this PR for the fix, clone the repo and commit the fix, then place the following lines in your Cargo.toml:
# original dependency has UB, it's fixed here
[patch.crates-io]
smartstring = { git = "URL to your patched git repo" }

There is a way to use a GitHub PR in Cargo.toml...
[patch.crates-io]
smartstring = { git = "https://github.com/bodil/smartstring", ref = "refs/pull/34/head" }


Configurable timeouts

At the moment IdleTimeout is used + it's hardcoded: https://github.com/gambol99/keycloak-proxy/blob/1741a5b3fdf0c5e80656fa64e4a88756d57a390d/server.go#L336-L340
Could you add options to set value of ReadTimeout, WriteTimeout, IdleTimeout please?
Upstream proxy also can implement some timeouts TLSHandshakeTimeout, ResponseHeaderTimeout, ExpectContinueTimeout:
https://github.com/gambol99/keycloak-proxy/blob/1741a5b3fdf0c5e80656fa64e4a88756d57a390d/server.go#L552-L556
Reference:
https://blog.cloudflare.com/the-complete-guide-to-golang-net-http-timeouts/
https://medium.com/@nate510/don-t-use-go-s-default-http-client-4804cb19f779

fixed in #268


Fix ID Generation For RelationshipTemplates

The generation of IDs for new RelationshipTemplates was incorrect. It was only checked once if the generated ID was already taken.

[x] Ensure that you followed http://eclipse.github.io/winery/dev/ToolChain#github---prepare-pull-request. Especially, we require a single commit
[x] Ensure that the commit message is a good commit message
[x] Ensure to use auto format in all files
[x] Ensure that you appear in NOTICE at Copyright Holders

@saatkamp and @ledicjp can you please have a look at this?


HTTP Fails to connect on Vagrant install

Environment details:

local deployment: vagrant
Following the directions in the Vagrant setup

Steps to reproduce the issue:
Trying to setup non ssl connection to the nginx frontend:

git clone https://github.com/openwhisk/openwhisk.git
cd openwhisk/tools/vagrant
./hello
../../bin/wsk property set --apihost <IP_ADDRESS> --auth `vagrant ssh -- cat openwhisk/ansible/files/auth.guest`
../../bin/wsk action -i invoke /whisk.system/utils/echo -p message hello --blocking --result
../../bin/wsk property set --apihost http://<IP_ADDRESS> --auth `vagrant ssh -- cat openwhisk/ansible/files/auth.guest`
../../bin/wsk action invoke /whisk.system/utils/echo -p message hello --blocking --result

Provide the expected results and outputs:
{
    "message": "hello"
}

Provide the actual results and outputs:
error: Unable to invoke action 'utils/echo': Post http://<IP_ADDRESS>/api/v1/namespaces/whisk.system/actions/utils/echo?blocking=true&result=true: dial tcp <IP_ADDRESS>:80: getsockopt: connection refused
Run 'wsk --help' for usage.

Additional information you deem important:

In vagrant ( not sure if this needs to be controlled in other deployments ) it's helpful to be able to see the HTTP requests that wsk makes. So having a non-ssl connection is quite helpful. Not sure if this was an oversight or a security decision. If it was a security decision perhaps hiding it behind a setting in ansible is more appropriate than the PR that claims to fix this.

http://<IP_ADDRESS> should be http://<IP_ADDRESS>:10001 - the nginx conf (as you found) doesn't listen to port 80.

We've debated this in the past: should nginx support http as well; if we enable this but don't test it, it will break. If we enable it and test it, how much test coverage do we apply?

Ah, so the PR is wrong then, I added nginx listening on 80 so that everything was still going through there. So all the requests should be the same to the downstream systems. Directly hitting the controller would change things much more.

Works for me with recent vagrant changes
vagrant@ubuntu-xenial:~/openwhisk$ ifconfig | grep 192
          inet addr:<IP_ADDRESS>  Bcast:<IP_ADDRESS>  Mask:<IP_ADDRESS>
vagrant@ubuntu-xenial:~/openwhisk$ exit
logout
Shared connection to <IP_ADDRESS> closed.
⛄  $ ../../bin/openwhisk-cli/build/darwin-amd64/wsk property set --apihost <IP_ADDRESS> --auth `vagrant ssh -- cat openwhisk/ansible/files/auth.guest`
ok: whisk auth set. Run 'wsk property get --auth' to see the new value.
ok: whisk API host set to <IP_ADDRESS>

⛄  $ ../../bin/openwhisk-cli/build/darwin-amd64/wsk -i action invoke /whisk.system/utils/echo -p message hello --blocking --result
{
    "message": "hello"
}
⛄  $ date
Thu Apr 19 13:00:11 EDT 2018


object_store/InMemory: Make clone() non-async and implement Clone trait

Which issue does this PR close?

Closes #4496.
What changes are included in this PR?

As described in the issue and the commit messages, this PR is removing the async keyword from the clone() fn of the object_store::InMemory struct and then implements the Clone trait for it.
Are there any user-facing changes?
Yes, since the function signature changes and any users would have to remove the .await from any calls to this function.

If there are any breaking changes to public APIs, please add the breaking change label.

I'm not sure how to do that since I can't select any labels when opening the PR. Since we are changing the signature of the public clone() fn I guess this should be considered a breaking change.

I also wonder if it would just be better to encourage applications to pass round Arc<InMemory> as none of the other stores implement Clone

if we impl<S: ObjectStore> ObjectStore for Arc<S> (or something like that) it might work, but I guess the original goal was to abstract the Arc away inside of the InMemory implementation.

Could we possibly just deprecate this method to avoid this being a breaking change?

It's possible, yes. As I hinted at in https://github.com/apache/arrow-rs/issues/4496#issuecomment-1628521794, I think it makes sense to have two ways of cloning the in-memory store. One that forks/copies the data inside the store, creating two independent in-memory stores. And another function which creates a linked instance, where changes in one instance are reflected in the second one.
I guess we could deprecate clone() and instead have clone_copied() and clone_shared() or something like that?

I like the idea of deprecating clone and creating a new method fork that does the same thing. I think the semantics are more obvious then.
I'm not sure if we would then implement Clone as well, I think the semantics might be a bit unclear / hard to document

any naming suggestions for the clone_shared() variant? :)

any naming suggestions for the clone_shared() variant? :)

I think I would encourage the use of Arc<dyn ObjectStore> or possibly Arc<InMemory> to achieve this

Is this superseded by #4499


HAWQ-793. Temporarily remove the snappy info in metadata but keep the…

… snappy support for row oriented storage.

LGTM. +1


keywords are not allowed as local specifier in imports

Q
A

Bug fix?
yes

Breaking change?
no

New feature?
no

Deprecations?
no

Spec compliancy?
yes

Tests added/pass?
yes

Fixed tickets

License
MIT

This should not be allowed
import { default } from "foo";

Current coverage is 97.27% (diff: 100%)

Merging #307 into master will increase coverage by <.01%

@@             master       #307   diff @@
==========================================
  Files            21         21
  Lines          4000       4004     +4
  Methods         490        478    -12
  Messages          0          0
  Branches       1170       1186    +16
==========================================
+ Hits           3891       3895     +4
  Misses           49         49
  Partials         60         60

Powered by Codecov. Last update 999b655...0dd0ca2


The sleepy_device demo failed and kept restarting (CON-841)

Is your feature request related to a problem? Please describe.
While I was compiling and running the sleepy-device demo, the chip kept restarting. Here's the log of that time.
The chip I used was esp32h2 and I updated to the latest esp-idf and esp-matter.
Describe the solution you'd like
Description of what you want to happen.
Describe alternatives you've considered
Description of any alternative solutions or features you've considered.
Additional context
log.txt

Now when I use chip-tool for networking, the Bluetooth connection always drops and reconnects until chip-tool times out.

Thanks for your report, it is an issue about the external crystal. And we will fix this issue ASAP.

@wqx6 Hello, is this problem solved now?

@KEEPHEADU Yes, this problem is solved now.

@wqx6 Ok, I'll close the issue.

@wqx6 Hello, I updated the latest esp-idf and esp-matter versions, but the chip still keeps restarting when running the sleepy_device example. Below is the log.
esp-matter branch : main 8b28a13 Merge branch 'docs/prerequisites_and_WSL' into 'main'
esp-idf branc: remotes/origin/release/v5.1 8c6114d0d2 Merge branch 'feature/free_bt_memory_v5.1' into release/v5.1
log.txt

Sorrt for that there is an issue on openthread port which has been fixed in https://github.com/espressif/esp-idf/commit/1dc2a98d1eef76ff5bba838bcf0c93e64a5caa1b on ESP-IDF master, but this commit is still not back-port to release v5.1. Could you cherry-pick the commit and try again?

遗憾的是，在 ESP-IDF 主站的乐鑫/ESP-idf@1dc2a98 中修复了 openthread 端口上的问题，但此提交仍然没有向后移植到 v5.1 版本。你能挑选提交并重试吗？

Ok, I'll switch and try again.

@wqx6 Hello, I switched esp-idf to 1dc2a98 commit in master branch, but when I compile the esp-matter example, I get an error, the error message is the same for every example, below is the log.
esp-idf version: 1dc2a98d1e (HEAD -> master) HEAD@{0}: reset: moving to 1dc2a98d1eef76ff5bba838bcf0c93e64a5caa1b
esp-matter version: 8b28a13 (HEAD -> main, origin/main, origin/HEAD) HEAD@{0}: pull: Fast-forward
log.txt

After switching branches, I reexecuted./install.sh and the esp-idf example compiled correctly, as did the esp-matter example./install.sh, but the esp-matter example did not compile correctly.

@wqx6 Hello, I switched esp-idf to 1dc2a98 commit in master branch, but when I compile the esp-matter example, I get an error, the error message is the same for every example, below is the log.
esp-idf version: 1dc2a98d1e (HEAD -> master) HEAD@{0}: reset: moving to 1dc2a98d1eef76ff5bba838bcf0c93e64a5caa1b esp-matter version: 8b28a13 (HEAD -> main, origin/main, origin/HEAD) HEAD@{0}: pull: Fast-forward
log.txt

I solved this problem by changing the TestCert_PAA_NoVID_Cert variable to constexprs and it worked.


Got an error reading communication packets

When disconnection/closing the connection from the server-side I get  this warning:
 [Warning] Aborted connection 14 to db: 'unconnected' user: 'root' host: '<IP_ADDRESS>' (Got an error reading communication packets)

At first, I thought it could be because of the HAProxy in front but after testing with the native MySQL client it works as expected, please here find a way to reproduce this behavior here: https://github.com/nbari/haproxy-mariadb
You can reproduce the same behavior with the app mycli
mycli -h <IP_ADDRESS> --port 3306 -uroot --pass secret

or with this rust example
use mysql_async::prelude::*;

#[tokio::main]
async fn main() {
    let opts = mysql_async::OptsBuilder::default()
        .user(Some("root"))
        .pass(Some("secret"))
        .db_name(Some("world"))
        .ip_or_hostname(String::from("<IP_ADDRESS>"))
        .tcp_port(3306)
        .stmt_cache_size(0);
    let mut conn = mysql_async::Conn::new(opts).await.unwrap();

    let version: Option<String> = conn.query_first("SELECT VERSION()").await.unwrap();
    drop(conn);
    println!("{}", version.unwrap());
}

From https://mariadb.com/kb/en/com_quit/:

int<1> 0x01 : COM_QUIT Header

I found here: https://github.com/blackbeam/mysql_async/blob/e41e2415569afe20732fefcf70bc90d52dc53edf/src/conn/mod.rs#L403
Tried already with something like
 self.write_command_data(Command::COM_QUIT, &[1]).await?;

But no luck, any ideas?


Proposal to add color picker chrome extension using Js

Describe the project you want to add with tech stack
Color picker extension will extract any color from the web page which user can use later. Tech stack: html,css,js
Expected behavior
The proposed project involves creating a Chrome extension that enables users to pick colors directly from web pages. This extension will offer a user-friendly interface, allowing users to select any color on a web page and obtain its corresponding hexadecimal or RGB value.
Additional context (optional )
This enhancement aligns with the needs of web designers, developers, and graphic designers who seek a quick and efficient way to pick colors from web pages.

Hey i m GSsoc'23 contributor , please assign this issue to me.

Please assign me this issue so that I can resolve it under GSSOC-23

hi can you please assign this project to me so i'll work on it under GSSOC-23


Enable testing with multiple interpreter versions

Currently bazel tests only with python3.9. We should try to enable testing with more than one python version, since users may be on a variety of versions. In the meantime, we should consider pinning bazel to the minimum supported version.

Maybe follow recipe in this comment https://github.com/bazelbuild/rules_python/issues/728#issuecomment-1183495302


release: v1.4.4

Signed-off-by: davidko<EMAIL_ADDRESS>

This PR verified with blow test scenarios

[x] Fresh install v1.4.4 by helm
[x] Upgrade from v1.4.3 to v1.4.4 by helm
- Create Longhorn CRs before upgrade
- After upgrade success, restore volume, replica rebuild, detach/attach volume by scale workload worked properly
[x] Uninstall
- No longhorn.io CRD remain
- Name space longhorn-system terminated


Numbered bounding boxes

Is there a way you can create a small number in the upper left of each bounding box so you can easily associate a box with an image? Also, it would be great if you could modify the order of these box numbers to suit your needs. It would also be great if you could output a standard html image map text file so that the bounding boxes could be used on a website with the image so that when you hover over the image, it will tell you info about each specimen (based on data you enter in Inselect).
For an example bounding box numbering, see http://www.maschek.hu/imagemap/imgmap

Thanks very much for the suggestions @FetznerJ .

Object numbers and titles in boxes - excellent idea, we will add this
Altering the ordering of box - yes, this is an annoying limitation of Inselect - to be handled by #212
HTML image map export - we recently altered Inselect to include locations bounding boxes in the CSV (see #247) - it should be possible to use that to create an HTML image tailored to your needs

@FetznerJ we have spent some time looking into showing object numbers and titles in boxes and have been unable to find a scheme that we are happy with. It has not been possible to get something that works well across the diversity of specimen types and at different zoom levels. We have also found it difficult to intelligently place labels so that important information is not obscured. Our feeling is that this feature would only work well in a handful of cases and in most cases will be a distraction.
We have chosen instead to add a bar along the bottom that shows the number of boxes, the number of selected boxes and, when a single box is selected, shows the number and label of the selected box - see #218.


Unattended lab build fails because of vmware tools installation

Operating System Version: Windows 10 Build 1903
Provider (VirtualBox/VMWare): VMware Workstation Pro 15.5.1
Vagrant Version: 2.2.6
Packer Version: 1.4.5
Are you using stock boxes (downloaded) or were they built from scratch using Packer? stock boxes
Is the issue reproducible or intermittent? reproducible

The git master branch was used and is up to date.
Description of the issue:
While building the windows hosts, the vmware tools installation will want to restart the vm and a popup is displayed. If this is not answered with no the vm will restart and the build will fail because the reboot is unexpected. This makes it not possible to building the lab unattended.

@ReddingZH this shouldn't be the case - the host should eventually just restart. I'm unable to reproduce this on my Win10 box with VMWare. Which host is hanging and can you provide the vagrant_up_.log in the Vagrant folder?

I think the currently installed version of VMware tools is not supported on Workstation 15.5. I'm working on getting new boxes uploaded that should address this issue.

It happened on the 2 windows servers. The win10 box was not affected. If the problem is known the workout is pretty easy.

This should be fixed with the v1.4 boxes now live on VagrantCloud. Feel free to re-open if you continue to experience this.


Gson does not correctly serialize with polymorphism

If you have a base class that has some properties, and then another class which extends it - you do not get any of the properties from either class in the resulting JSON output.
You can see this behavior demonstrated here: https://github.com/inktomi/auto-value-gson-bug
Run the ExtensionTest class. You can see that the Extension class has a type in it, defined as a BaseType. We set that to an autovalue CarType and then write out the JSON. Is it expected that in the resulting JSON the type is "type":{}?
I would expect that Gson should be configured to know the possible types of BaseType and choose the correct one using the TypeToken available at serialization/deserialization time.

I'm not sure this is the problem of this extension as the exact same behavior would happen if you used Gson directly. You need to create a polymorphic type adapter for BaseType which either defers lookup of the actual type until serialization time or registers a list of available type adapters to delegate to based on the runtime type.

I agree. I'm fine with closing this out as "not a bug", but as that code is somewhat formulaic to write it might be nice to generate it if possible, since the actual @AutoValue types all have their own type adapters available for use.

Yeah that makes sense. A problem might be though that this code could be in a library and then there are other subclasses of BaseType in other modules that consume the library. In order for what you propose to work there'd have to be a guarantee that it's a sealed type where no more subclasses would be created.

Running into an issue which sounds similar to that...
Base class looks like that:
public abstract class TrackerEvent {

    private final String _type;

    public TrackerEvent(String type) {
        _type = type;
    }

    public String type() {
        return _type;
    }

}

Then the auto-value class:
@AutoValue
public abstract class AppInit extends TrackerEvent {

    public AppInit() {
        super("APP_INIT");
    }
...

Using a Gson without the generated type adapter will serialize the _type field.
Using a Gson with the generated type adapter will not serialize the _type field.

Nothing else to be done here, this is more of a gson usage nuance.


Skip the creation of DistinctLimitNode for global aggregation node

Currently if there is a global aggregation node with no aggregation functions and if we try to merge with a limit node we end up creating a DistinctLimitNode which fails when executed because there is no grouping key. So we skip the creation of DistinctLimitNode for such aggregation
nodes.
This is will solve this issue (https://github.com/prestodb/presto/issues/11276).

@martint , @findepi , @kokosing Can you please review this ?

@kokosing Have resolved the above comments.


Undefined pages when pasting text

Tested in

Operating System
Browser
Renderer

Windows
Chrome 128
v3

Description of the issue
When pasting text in a brew with multiple pages, the DOM seems to update incorrectly, leaving unreferenced pages in the preview. See attached file:
https://github.com/user-attachments/assets/d8cb104c-84f9-4126-b33b-3c1a2c4d9ac6

For posterity, the issue was caused by the page at the current cursor position being given first priority when rendering pages. This is desired in most cases, since it allows cross-page content (variables, links) to update first before re-rendering other pages. This breaks if we suddenly reduce the number of pages with the editor cursor on the last page:

CTRL+A places the cursor at the last page
pasting over the editor with fewer pages means the last known "cursor page" is greater than the actual page count.
BrewRenderer attempts to render the last known "cursor page", which is empty, resulting in an "unknown" content page.


create additional dataset preprocess code [LM-153]

Why this PR
In order to added preprocessing code for datasets such as LST , BEST , SCB
Changes

added Additional_datasets_preprocess.py  at /openthaigpt-pretraining/src/data/openthaigpt_pretraining_data/core/Additional_datasets_preprocess.py

Related Issues
Close #
Checklist

[ ] PR should be in the Naming convention
[ ] Assign yourself in to Assigneees
[ ] Tag related issues
[ ] Constants name should be ALL_CAPITAL, function name should be snake_case, and class name should be CamelCase
[ ] complex function/algorithm should have Docstring
[ ] 1 PR should not have more than 200 lines changes (Exception for test files). If more than that please open multiple PRs
[ ] At least PR reviewer must come from the task's team (model, eval, data)

@ArthurMinovsky Did you forget to push your commit?

@ArthurMinovsky Did you forget to push your commit?

Nah, I already pushed. I think you have to see in file changed again. 🤔


Add getTimezone() in JS

fixes #73
and corrects 2 typos in README

@GantMan can you merge this too please? it's pretty straightforward :)

LGTM! 👍


Custom formatter for Chrome Devtools

Chrome Devtools is getting support for custom formatters (currently in Canary).
https://docs.google.com/document/d/1FTascZXT9cxfetuPRT2eXPQKXui4nWFivUnS_335T3U/preview
This will make debugging immutable values much easier. We'll be able to display useful information in watches, console, etc.
A bare-bones formatter is here: https://gist.github.com/jsdf/e27e0e467dc8db3fb1e1 but we could make one that does way more than just JSONifying.

Should this live in a separate project (and NPM module)? Since we'd probably only want it in debug builds. Something like:
import Immutable from "immutable";
if (DEBUG) {
  const initFormatter = require("immutable-devtools");
  initFormatter(Immutable);
}

I've made a start on this: https://github.com/andrewdavey/immutable-devtools

Dupe of #287

Closing this out as a duplicate of #287


DEV: Logo Display Issue on Small Screens

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
1- Open the web app in development mode.
2- Access the app using a device or browser with a small screen size (mobile size).
3- Observe the logo display on the splash screen.
Expected Result:
The logo on the splash screen should be fully displayed, without any cropping or misalignment, regardless of the screen size.
Actual Result:
Only around 1/4 of the logo is visible on the splash screen, indicating that the logo is not being displayed correctly on small screens.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number:
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/d645eb32-c625-48b2-ae60-ab800cad9878
Expensify/Expensify Issue URL:
Issue reported by: @ahmdshrif
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692601767190289
View all open jobs on GitHub

Proposal
by @ahmdshrif
Please re-state the problem that we are trying to solve in this issue.
The logo on the splash screen is not being displayed correctly on small screens. Only around 1/4 of the logo is visible, indicating that the logo is being cropped.
What is the root cause of that problem?
The root cause of the problem is that the SVG image of the logo does not have a viewBox attribute. The viewBox attribute defines the coordinate space of the SVG image. When you resize the image, the viewBox attribute is used to scale the image proportionally. Without a viewBox attribute, the image is simply cropped to fit the new size.
What changes do you think we should make in order to solve the problem?
To fix the problem, we need to add a viewBox attribute to the SVG image. The viewBox attribute should be set to the same dimensions as the image. For example, if the image is 80 pixels wide and 80 pixels high, the viewBox attribute would be set to:
<svg viewBox="0 0 80 80">
  ...
</svg>

This will ensure that the image is resized proportionally when it is resized.
What alternative solutions did you explore? (Optional)
We could also use CSS to scale the image proportionally. However, this would be less efficient than using a viewBox attribute.

I don't have a dev environment to test. I'm asking for clarification on whether we'd fix this.

@abdulrahuman5196 can you reproduce this one on dev?

@abdulrahuman5196 friendly bump... is this reproducible on dev?

Testing on dev now

@tjferriss I am not able to repro the issue in Dev as well as adhoc builds.


Add insertSpaceAfterOpeningAndBeforeClosingEmptyBraces to tsserver protocol

Looks like #35427 added a new formatter setting: insertSpaceAfterOpeningAndBeforeClosingEmptyBraces
I see this setting in code but it is not exposed in the tsserver protocol at the moment. Should it be added there as well?

@DanielRosenwasser What do you think about this issue?


Endpoint breaking

Motivation

API definitions and usage should be completely disjoint - this enables distinct upgrade paths as well as eliminates problems from multiple versions of shared pieces.
Solution

@rest-hooks/normalizr is now for Endpoint users

normalize, denormalize functions
interface compatibility definitions for those wanting to use (like Denormalize, Normalize)

@rest-hooks/endpoint is now for API definitions

Endpoint
All schema implementations

Shared interfaces are currently in interface.ts in each package. This could be split into another package but since it's interfaces only for now we'll just repeat the code.
This means all schema implementations will be moved into endpoint. All Endpoint interfaces will be exported from normalizr for users to use.

Codecov Report

Merging #2159 (53a55dc) into master (550fb22) will decrease coverage by 0.46%.
The diff coverage is 93.16%.

@@            Coverage Diff             @@
##           master    #2159      +/-   ##
==========================================
- Coverage   98.49%   98.03%   -0.47%
==========================================
  Files         103      109       +6
  Lines        1933     1983      +50
  Branches      407      417      +10
==========================================
+ Hits         1904     1944      +40
- Misses         13       20       +7
- Partials       16       19       +3

Impacted Files
Coverage Δ

packages/core/src/controller/Controller.ts
95.60% <ø> (ø)

packages/core/src/controller/createFetch.ts
86.66% <ø> (ø)

packages/core/src/controller/createInvalidate.ts
100.00% <ø> (ø)

packages/core/src/controller/createOptimistic.ts
100.00% <ø> (ø)

packages/core/src/controller/createReceive.ts
100.00% <ø> (ø)

packages/core/src/controller/createSubscription.ts
100.00% <ø> (ø)

packages/core/src/index.ts
100.00% <ø> (ø)

...kages/core/src/react-integration/hooks/useCache.ts
100.00% <ø> (ø)

...kages/core/src/react-integration/hooks/useError.ts
100.00% <ø> (ø)

.../src/react-integration/hooks/useFetchDispatcher.ts
100.00% <ø> (ø)

... and 47 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Add language internationalization.

var language = window.navigator.userLanguage || window.navigator.language;

https://angular.io/guide/i18n
https://plnkr.co/edit/JyE4l4TjEruuPsrbanmK?p=info
https://github.com/ngx-translate/core
Tasks:

[x] #140
[x] #141
[ ] Add ru language translation
[x] Add ch language translation
[x] Add fr language translation
[x] Automatically detect the default user browser language #174
[x] Have option to change language #183

Can't seem to get a russian translator. 😔


Enhance workflows to use subscription-manager(8) remove command at the end of a successful workflow run

According to @jamesfalkner the remove sub command of the subscription-manager(8) command can be used to remove the entitlement.  Indeed, I see this text in the subscription-manager(8) man page, which I can read when I ssh into a RHEL vm.
subscription-manager(8)                        Subscription Management                        subscription-manager(8)

NAME
       subscription-manager  -  Registers  systems to a subscription management service and then attaches and manages
       subscriptions for software products.

SYNOPSIS
       subscription-manager command [options]

DESCRIPTION
...
COMMANDS AND OPTIONS
       subscription-manager  has  specific  options  available for each command, depending on what operation is being
       performed. Subscription Manager commands are related to the different subscription operations:
...
   REMOVE OPTIONS
       The remove command removes a subscription from the system. (This does not uninstall the associated products.)

       --serial=SERIALNUMBER
              Gives  the  serial  number  of the subscription certificate for the specific product to remove from the
              system. Subscription certificates attached to a system  are  in  a  certificate,  in  /etc/pki/entitle‐
              ment/<serial_number>.pem.  To remove multiple subscriptions, use the --serial option multiple times.

       --pool=POOLID
              Removes  all  subscription  certificates for the specified pool id from the system.  To remove multiple
              sets of subscriptions, use the --pool option multiple times.

       --all  Removes all of the subscriptions attached to a system.

I think we want subscription-manager remove --all.

Here is an experiment to see if --remove is what we want.

Deploy a single node vm with the pipeline https://github.com/edburns/rhel-jboss-templates/actions/runs/2878190160 .

ssh into the vm
[root@28781901605vm ~]# subscription-manager list --installed
+-------------------------------------------+
    Installed Product Status
+-------------------------------------------+
Product Name:   JBoss Enterprise Application Platform
Product ID:     183
Version:        7.4
Arch:           x86_64
Status:         Subscribed
Status Details:
Starts:         02/28/2022
Ends:           02/28/2023

Product Name:   Red Hat Enterprise Linux for x86_64
Product ID:     479
Version:        8.5
Arch:           x86_64
Status:         Subscribed
Status Details:
Starts:         02/28/2022
Ends:           02/28/2023

Product Name:   Red Hat Enterprise Linux for x86_64 - Extended Update Support
Product ID:     70
Version:        8.4
Arch:           x86_64
Status:         Subscribed
Status Details:
Starts:         02/28/2022
Ends:           02/28/2023

Look in the customer portal

run the remove command
[root@28781901605vm ~]# subscription-manager remove --all
1 local certificate has been deleted.
1 subscription removed at the server.

# subscription-manager remove --all

1 local certificate has been deleted.
1 subscription removed at the server.

[root@28781901605vm ~]# subscription-manager list --installed
+-------------------------------------------+
    Installed Product Status
+-------------------------------------------+
Product Name:   JBoss Enterprise Application Platform
Product ID:     183
Version:        7.4
Arch:           x86_64
Status:         Not Subscribed
Status Details: Not supported by a valid subscription.
Starts:
Ends:

Product Name:   Red Hat Enterprise Linux for x86_64
Product ID:     479
Version:        8.5
Arch:           x86_64
Status:         Not Subscribed
Status Details: Not supported by a valid subscription.
Starts:
Ends:

Product Name:   Red Hat Enterprise Linux for x86_64 - Extended Update Support
Product ID:     70
Version:        8.4
Arch:           x86_64
Status:         Not Subscribed
Status Details: Not supported by a valid subscription.
Starts:
Ends:

Look in the customer portal

I don't think this is removed enough.

Let's try unregister.
[root@28781901605vm ~]# subscription-manager unregister
Unregistering from: subscription.rhsm.redhat.com:443/subscription
System has been unregistered.

Yes, that's what we want.  Will update description.


debugPaper not working with shadowJar

I have authored plugins that use shadow to compile dependencies. When run alone the shadowJar task functions fine and I get the uber jar as expected. I have added tasks.debugPaper.dependsOn shadowJar and the tasks run fine but in the spigot/paper plugins folder I only get the lean jar. I have the shadowJar task overwrite the lean jar with the uber jar, but that does not fix this problem.

Hi @Magnum97, the jar copy task is prepareSpigotPlugins, so you must make shadowJar depends on the prepareSpigotPlugins at least, the best is on assemble or jar.
You can try: jar.dependsOn(shadowJar), this should be work.
I'll add some shadowJar tips on docs, Thank you for sharing your experience

tasks.prepareSpigotPlugins.dependsOn shadowJar does exactly what I wanted - thanks for the help!